Question regarding storage on multi-node install

I set up a multi-node install of microk8s 1.19, and enabled storage.
However, when I try to deploy a statefulset with a volume template, I run into issues.
The server pod can be brought up on a different node from the one the PV is actually created on, causing the pod to fail to start, as the directory for the volume does not exist.  Is this expected?  How can I ensure the volume is provisioned on the correct node?
Here's the relevant bit from my helm template with the volume claim:
apiVersion: apps/v1
kind: StatefulSet
metadata:
  name: {{ $namePrefix }}-postgres
  labels:
    {{ include "baseline-study.selectorLabels" . | nindent 4 }}
spec:
  replicas: 1
  serviceName: {{ $namePrefix }}-studydb
  updateStrategy:
    type: RollingUpdate
  selector:
    matchLabels:
      app: postgres
      tier: database
      {{- include "baseline-study.selectorLabels" . | nindent 6 }}

  template:
    metadata:
      labels:
        app: postgres
        tier: database
        {{- include "baseline-study.selectorLabels" . | nindent 8 }}
    spec:
      {{- if .Values.postgres.configFile }}
      {{ $pgconf := .Values.postgres.configFile }}
      {{- if (len (.Files.Get $pgconf)) }}
      volumes:
        - name: {{ .Release.Name }}-pgconfig
          configMap:
              name: {{ .Release.Name }}-pgconfig
      {{ end -}}
      {{ end -}}
      terminationGracePeriodSeconds: 10

      containers:
        - name: postgres
          image: postgres:12.4

          {{- if .Values.postgres.configFile }}
          {{ $pgconf := .Values.postgres.configFile }}
          {{- if (len (.Files.Get $pgconf)) }}
          args:
           - -c
           - config_file=/etc/postgres.conf
          {{ end -}}
          {{ end -}}

          imagePullPolicy: IfNotPresent

          ports:
            - name: postgres
              containerPort: 5432
              protocol: TCP

          resources:
            requests:
              cpu: 100m     # TODO: is this right???
              memory: 512Mi # TODO: is this right???

          env:
            - name: POSTGRES_USER
              valueFrom:
                secretKeyRef:
                  key: pg.username
                  name: {{ $pgCredSecretName }}
            - name: PGUSER
              valueFrom:
                secretKeyRef:
                  key: pg.username
                  name: {{ $pgCredSecretName }}
            - name: POSTGRES_PASSWORD
              valueFrom:
                secretKeyRef:
                  key: pg.password
                  name: {{ $pgCredSecretName }}
            - name: POSTGRES_DB
              value: studydb
            - name: PGDATA
              value: /var/lib/data/postgresql/data/pgdata
            - name: POD_IP
              valueFrom:
                fieldRef:
                  apiVersion: v1
                  fieldPath: status.podIP

          livenessProbe:
            exec:
              command: ["sh","-c","exec pg_isready --host $POD_IP"]
            failureThreshold: 6
            initialDelaySeconds: 60
            periodSeconds: 10
            successThreshold: 1
            timeoutSeconds: 5

          readinessProbe:
            exec:
              command: ["sh","-c","exec pg_isready --host $POD_IP"]
            failureThreshold: 3
            initialDelaySeconds: 5
            periodSeconds: 5
            successThreshold: 1
            timeoutSeconds: 3

          volumeMounts:
            - mountPath: /var/lib/postgresql/data/pgdata
              name: {{ $namePrefix }}-data-vol
              subPath: postgres-db
            {{- if .Values.postgres.configFile }}
            {{ $pgconf := .Values.postgres.configFile }}
            {{- if (len (.Files.Get $pgconf)) }}
            - name: {{ .Release.Name }}-pgconfig
              mountPath: /etc/postgres.conf
              subPath: postgres.conf
            {{ end -}}
            {{ end -}}

            {{ $files := .Files.initdb }}
            {{ range $files }}
            - name: {{ $namePrefix }}-initdb
              mountPath: /docker-entrypoint-initdb.d/{{ . }}
              subPath: {{ . }}
            {{ end }}
  volumeClaimTemplates:
    - metadata:
        name: {{ $namePrefix }}-data-vol
        labels: {{ include "baseline-study.selectorLabels" . | nindent 10 }}
      spec:
        accessModes:
          - ReadWriteOnce
        resources:
          requests:
            storage: 10G

@dajester2013 the storage addon is a hostpath based storage.  Not really for multi node cluster.
There are other storage solutions that is more suited for multi nodes.  Such as rook (ceph), openebs, portworx, etc...
I have tried rook with ceph and i find it difficult to work with.  Its also very much possible that im just not familiar with these.
@stubbss did try openebs. He may have some feedback about it.

Hi @dajester2013 yes there are quite a few options. Openebs has worked well for me. Their local pv is probably what you looking for https://docs.openebs.io/docs/next/localpv.html

Hi @dajester2013 yes there are quite a few options. Openebs has worked well for me. Their local pv is probably what you looking for https://docs.openebs.io/docs/next/localpv.html

Thanks - I'll give that a shot.  I'm still a bit new to the kubernetes world.

@sstubbs Have you managed to get OpenEBS cStor working on microk8s? I got the localPV to work relatively easily, but am encountering an error with cStor. I was wondering if it was an issue with microk8s, OpenEBS, or a fault of my own...

Hi @Namyts. I did use cstore as well as ceph via rook for a few months. Both of them fairly straightforward to setup from what I remember but did need a bit of altering of configuration. Now I only use openebs localpv.
For anything that needs clustered storage I now use minio operator with their direct csi driver. Not because of issues with openebs or rook ceph but because I like a lot of things that minio does. They busy reworking the csi driver to handle different storage classes. Once that's done I will probably use it for everything not just minio if it works well https://github.com/minio/direct-csi as I'm trying not to have too many different projects doing the same thing.
I never tested it with loop devices instead of raw block devices. That could potentially be a problem. openebs have a great slack channel. Perhaps ask there.

So, just installed openebs using helm3, but any attempt to create a PVC results in a timeout error:
StorageClass manifest (copied from openebs local pv docs):
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: local-hostpath
  annotations:
    openebs.io/cas-type: local
    cas.openebs.io/config: |
      - name: StorageType
        value: hostpath
      - name: BasePath
        value: /var/local-hostpath
provisioner: openebs.io/local
reclaimPolicy: Delete
volumeBindingMode: WaitForFirstConsumer

PVC manifest:
kind: PersistentVolumeClaim
apiVersion: v1
metadata:
  name: local-hostpath-pvc
spec:
  storageClassName: local-hostpath
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 5G

This is the error I get when trying to apply the PVC manifest:
Internal error occurred: failed calling webhook "admission-webhook.openebs.io": Post "https://admission-server-svc.openebs.svc:443/validate?timeout=5s": context deadline exceeded

@dajester2013 the storage addon is a hostpath based storage. Not really for multi node cluster.

Can't this be alleviated a bit by setting volumeBindingMode to WaitForFirstConsumer? The docs say that if volumeBindingMode is not specified, then Immediate is used, and that can lead to the PV being created in one node and the pod in another one:

volumeBindingMode
VolumeBindingMode indicates how PersistentVolumeClaims should be
provisioned and bound. When unset, VolumeBindingImmediate is used. This
field is only honored by servers that enable the VolumeScheduling feature.

In https://github.com/ubuntu/microk8s/blob/83f24a689c57b1c729c72cf0d4d6df82906e8be6/microk8s-resources/actions/storage.yaml#L40 it's not set, meaning the default Immediate value is used then.

@dajester2013 the storage addon is a hostpath based storage. Not really for multi node cluster.

Can't this be alleviated a bit by setting volumeBindingMode to WaitForFirstConsumer? The docs say that if volumeBindingMode is not specified, then Immediate is used, and that can lead to the PV being created in one node and the pod in another one:

volumeBindingMode
VolumeBindingMode indicates how PersistentVolumeClaims should be
provisioned and bound. When unset, VolumeBindingImmediate is used. This
field is only honored by servers that enable the VolumeScheduling feature.

In https://github.com/ubuntu/microk8s/blob/83f24a689c57b1c729c72cf0d4d6df82906e8be6/microk8s-resources/actions/storage.yaml#L40 it's not set, meaning the default Immediate value is used then.

For what is worth, rancher's local-path provisioner sets it to the correct value:
ubuntu@f1-k3s:~$ kubectl get sc local-path -o yaml | grep ^volumeBindingMode:
volumeBindingMode: WaitForFirstConsumer

It's still kind of a workaround, since obviously the volume is still local to the node.

For what is worth, rancher's local-path provisioner sets it to the correct value:
ubuntu@f1-k3s:~$ kubectl get sc local-path -o yaml | grep ^volumeBindingMode:
volumeBindingMode: WaitForFirstConsumer

It's still kind of a workaround, since obviously the volume is still local to the node.


Review of contract documentation for Public Cloud services in order to advise CLBC on privacy compliance.

Describe the issue
CLBC asked OCIO to provide guidance on the appropriate privacy terms for their contract with a vendor to provide public cloud services.
Additional context
CLBC approached OCIO to onboard to the Managed Public Cloud in the pilot stage and OCIO was not ready to onboard external public sector organizations at the time. A commitment was made to support CLBC with advice on their requirements for privacy and security once CLBC had selected a vendor via a procurement process. CLBC has specifically requested that a comparison of the vendors proposed Enterprise Agreement is reviewed for privacy compliance.  PCT provided some high level advice but is not prepared to do the necessary legwork to review the vendor's proposed terms.
Originally we sent CLBC away when they asked us for cloud space.  CLBC did their own procurement.  We committed to sharing the Privacy and Security compliance.  Took a long time to get the NDA in place.  We are not allowed to share our terms as these are GoC terms under our own NDA.
OCIO gave them the CSS and Privacy Cloud Schedule.  The vendor has provided comment on these.  We need to do a 4 way comparison in order to provide them advice whether their contract is ready to go.
Terms from Privacy Protection Schedule, AWS' Feedback, make a new third column for the EA, other comment from SSC, risk evalution, final column his (OCIO) comments (eg, this is aligned to terms in cloud agreement)
Definition of done

obtain the documentation from CLBC: Vendor Enterprise Agreement, CLBC Table of commentary on Privacy Schedule
obtain the GC Framework Agreement and relevant Annexes (A, D) - especially Annex A Schedule 1- Security Obligations and Schedule 2 - Privacy Obligations; and the Additional Terms to SO for the BC Government, and Indemnity (memorandum)
Review the documents for comprehension and to get a sense of the work estimate for planning.

We will need to break this up @OmoAttah , we can 1:1 and help Gary as this seems to be a bigger piece than expected


feat(#215): support config column height.

close #215

If you set columnHeight to 85 it will look like the image below.

The icon on the right side of the column is half hidden
Need to add vertical alignment function for column titles
Fix and add 6 failed test codes

I'm busy with other things, so I don't know when I'll be able to handle it.

I'm sorry I couldn't reflect your code in the main.
I added a property to adjust the column height to the grid while adding the group column function.
https://github.com/bosskmk/pluto_grid/releases/tag/2.8.0
PlutoGrid version 2.8.0 has been deployed.


Is there any way to update the google API key after the Google Map initialized from MAUI Program.

SUMMARY
Is there any way to update the google API key after the Google Map initialized from MAUI Program
DETAILS
We are getting this key from backend service and wanted to update once, key reciewved from api
PLATFORMS

[x] Android
[ ] iOS

Is there any way to update the google API key after the Google Map initialized from MAUI Program

no


add option to manipulate xlabel size

If I am not mistaken then size of xlabels (variable names) is not affected by labsize-option and the twoway-options are not passed to the graph.
It would be good to either harmonize xlable-size with size of category labels affected by labsize or to offer xlabelsize-option to specify this size.

Dear Asjad, I agree with this suggestion. Furthermore, if the 'flow steps' are indeed x-axis positions, then it should also be possible to use code to set the labels, like:
sysuse nlsw88.dta, clear
tw scatter hours grade , xlab(0 "no" 5 "five" 10 "ten" 15 "15" 20 "top" , labc(blue) labs(*1.3))

which results in:

I assume to be able to get the same done in alluvial, like:

we need something like:
sysuse nlsw88.dta, clear
label define racelbl 3 ".    O", modify
alluvial race married collgrad smsa union, palette(CET C7) labs(*1.4) showtot boxw(*16) shares vals(*1.2) valf(%12.2f) xlab(1 "Race" 2 "Married" 3 ""College" "graduate"" 4 ""Lives in" "SMSA"" 5 ""Union" "worker"" , labc(blue) labs(*1.3))

which would set the color and the size of x-axis labels as well as enable the visualization of (long) labels over two (or more) lines.


Transform the docs folder in this repo into a handbook site for OL Platform Engineering

Description/Context
Right now, all our docs live at https://github.com/mitodl/ol-infrastructure/tree/main/docs are just Markdown files.
Navigating to a given doc is moderately painful, and there's no searchability short of good old fashioned grep in the checked out repo.
This isn't amazing and isn't the kind of easy consumability we want in order to bar raise our operational excellence.
Plan/Design
Use the example set by http://mitodl.github.io/handbook/ to create a separate MIT OL Platform Engineering Github Pages/Jekyll site.
Organize it by categories at first, with a very brief routing page to help people understand which category will contain the docs they want.
Ensure that the site is searchable from the webpage.

I think using the Hugo Book theme - https://themes.gohugo.io/themes/hugo-book/ will simplify this a bunch. I already have a branch with a decent looking site up. Just need to figure out how the inline directives will create the menu structure we want.

After days of churn where I couldn't get a theme that worked for our needs and also couldn't get past Hugo's insane complexity and deploying that to Github Pages, I've dropped back and punted to Nikola, the simple Python SSG I use for my own blogs.
I was able to get an ugly site up in minutes.
Now I need to:

Configure the built in Github pages deployment functionality
Make the site less ugly.
Figure out why the documents show up as both .md and .html

Just something to consider: github's markdown rending is pretty decent. Do we even need to render the docs? What do we get out of it?

https://pe.ol.mit.edu is LIVE! :)


Confirmation links unit tests

Jira issue:
https://glia.atlassian.net/browse/MOB-2872
What was solved?
Added unit tests for confirmation dialog.
Also, the SnackBar tests now use SnapshotStringProvider. With these changes, the actual value of the R.string doesn't matter for the snapshots tests.
Release notes:

[ ] Feature
[x] Ignore
[ ] Release notes (Is it clear from the description here?)
[ ] Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

[x] Tests updated? Added? Unit, acceptance, snapshots?
[ ] Logging for future troubleshooting of client issues added?

Screenshots:

@DavDo Yes, I'm currently working on snapshot tests for the confirmation dialog.

!squash


ENH: PCA works with NumPy/Pandas data

What does this PR implement?
This PR allows Dask-ML's PCA implementation to work with NumPy arrays and Pandas DataFrames.
This PR closes #578 (well https://github.com/dask/dask-ml/issues/578#issuecomment-548973996).

In theory, we could pass non-dask objects through to sklearn.decomposition.PCA.

How in theory?
I'm not sure I like the practice of accepting NumPy/DataFrame objects as well as accepting Dask Array/DataFrame objects (k_means.py#L177, _incremental.py#L469, _encoders.py#L166). I believe that will create a maintenance burden, and I'd rather users choose the right tool. However, having a NEP-18 style interface would be convenient.

My primary concern with passing the ndarray through to the sklearn base
class is that we may end up using entirely different algorithms for
PCA(ndarray) vs. PCA(dask.array.Array).
The other option is to wrap the non-dask object into a single-partition
dask object, and then proceed with our algorithm. But that will typically
be slower than the NumPy version.
All in all, perhaps erroring is best.
On Fri, Nov 1, 2019 at 8:42 PM Scott Sievert<EMAIL_ADDRESS>wrote:

In theory, we could pass non-dask objects through to
sklearn.decomposition.PCA.
How in theory?
I'm not sure I like the practice of accepting NumPy/DataFrame objects as
well as accepting Dask Array/DataFrame objects (k_means.py#L177
https://github.com/dask/dask-ml/blob/6c3b91cfafdf230408fccc875a749ce67014e89b/dask_ml/cluster/k_means.py#L177,
_incremental.py#L469
https://github.com/dask/dask-ml/blob/6c3b91cfafdf230408fccc875a749ce67014e89b/dask_ml/model_selection/_incremental.py#L469,
_encoders.py#L166
https://github.com/dask/dask-ml/blob/6c3b91cfafdf230408fccc875a749ce67014e89b/dask_ml/preprocessing/_encoders.py#L166).
I believe that will create a maintenance burden, and I'd rather users
choose the right tool. However, having a NEP-18 style interface would be
convenient.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask-ml/pull/580?email_source=notifications&email_token=AAKAOITQEE7HIBNUR6QJZUDQRTEFZA5CNFSM4JIBO2TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC4PQXA#issuecomment-548993116,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKAOIRZZQ4YG5K2BVVHXXLQRTEFZANCNFSM4JIBO2TA
.

perhaps erroring is best

:+1: I raise an error that pushes the user towards using Scikit-learn's implementation. I do mention that wrapping in Dask Array/Dataframe will resolve this but don't recommend that solution.

Thanks for the review. Resolved. This LGTM now.

The CI is green, except for the sklearnDev tests. One unrelated test is failing. Here's some of the relevant pytest output from Azure:

tests/preprocessing/test_data.py::TestRobustScaler::test_df_values FAILED [ 81%]
...
 Thanks.


fm.fit taking forever

in the matlab wrapper fooof.m, I can get through the first few lines just fine, but then when the line "fm.fit(freqs, power_spectrum, f_range)" is executed, it's taking forever.
I think this is not a matlab/python problem since the first few lines run just fine (e.g. py.numpy.array, pylist, etc.).
I'm using python 3.7 w/ cpython on matlab 2020a.

We would need some more information to be able to troubleshoot this. Does model fitting finish at all, or is it hanging? How long is "forever"? What is the data you are trying to fit and what settings are you using?

We would need some more information to be able to troubleshoot this. Does model fitting finish at all, or is it hanging? How long is "forever"? What is the data you are trying to fit and what settings are you using?

Thank you for quick response!
I am simply running the cell in 'fooof_example_one_spectrum.m', using the provided data in 'ch_dat_one.mat'
The model never finishes even when I let it run for >10 minutes.
I tried changing the default settings as follows, and still have the same issue.
settings.peak_width_limits=[2 5];
settings.max_n_peaks=2;
settings.min_peak_height=0.1;
settings.peak_threshold=2;
settings.aperiodic_mode='fixed';
settings.verbose=true;

Thank you for quick response!
I am simply running the cell in 'fooof_example_one_spectrum.m', using the provided data in 'ch_dat_one.mat'
The model never finishes even when I let it run for >10 minutes.
I tried changing the default settings as follows, and still have the same issue.
settings.peak_width_limits=[2 5];
settings.max_n_peaks=2;
settings.min_peak_height=0.1;
settings.peak_threshold=2;
settings.aperiodic_mode='fixed';
settings.verbose=true;

Same here. But I get one additional output warning:
FOOOF WARNING: Lower-bound peak width limit is < or ~= the frequency resolution: 0.98 <= 0.50 	Lower bounds below frequency-resolution have no effect (effective lower bound is the frequency resolution). 	Too low a limit may lead to overfitting noise as small bandwidth peaks. 	We recommend a lower bound of approximately 2x the frequency resolution.

I was able to solve it with the answer on StackOverflow. Just run:
py.sys.setdlopenflags(int32(10))
py.importlib.import_module('ssl')

and you should be good to go.


Fix windows creation of relative symlinks to directories

On windows, we need to specify an extra flag if we are creating a symlink to a directory. To do this, we check if the provided destination is a directory using FileManager.fileExists(atPath:isDirectory:). However, the destination path is relative to the symlink and not relative to the current working directory like fileExists(atPath:) expects so we must first convert the relative path into an absolute path using the symlink path as a base.
Resolves https://github.com/apple/swift-foundation/issues/928

@swift-ci please test

@swift-ci please test

@swift-ci please test Linux platform

@swift-ci please test

@swift-ci please test Windows platform

@swift-ci please test macOS platform


SVG images with clipPath is not rendered correctly

The attached image FW-5_PM-1.zip is not rendered correctly by svgren.
Firefox renders everything correct.
There is a clipPath at line 123 and 139 which causes the Problem.
The image in file FW-5_PM-1-fine is exactly the same image without clipPath and renders as it should.
FW-5_PM-1-fine.zip
FW-5_PM-1.zip

clipPath is not implemented yet. I will do it soon

Thanks again for your quick help.
We use Affinity Designer from serif to create and export our images.
Since the last versions clippath is used more often (not just when using contrains) when exporting to svg.
Unfortunately there is no option to not use clippath in the export.
It would be a great help if you implement clippath quite soon.

Hi,
after some more investigation I think the problem is not the clippath.
The transitions ar made with images now:
<image id="_Image11" width="46px" height="33px" xlink:href="data:image/png;base64,
I think this is not supportet too?

Hi Ivan,
I found out, it's all my fault.
I got the export options in Affinity Designer wrong. Unsupported feature were rendered as embedded images.
After changing to not rendering anything every thing looks fine again.
Do you want me to close this issue?

ok, good to know it works for you now!
But I think this issue still can be open, since it is about clipPath which is not implemented, and it would be good to have it implemented eventually :)


distinct() with omit parameter.

Is your feature request related to a problem? Please describe.
I have found that using the distinct() "extension" in the calls i.e.
 stream: globals.mWorkDatabase.getSelectedOrder(
                    SettingKey.userSelectionSelectedFirm,
                    SettingKey.userSelectionSelectedOrder
                ).watchSingleOrNull().distinct(),

Could be benifitial if you update data in backend, but the data didn't really change, and you could then avoid refresh / flashing of your data content.
But now I have a problem, sometimes only one field, actually a reading timestamp, is the only value which is updatet. That value isn't normally visible, but the distinct function haven't any parameter where I could tell omit this field on the compare. I could of course explode the member extension function and compare each value, but that feels awkward when the tables may have over 30 columns...
Describe the solution you'd like
I wish for some kind of parameter [an array maybe] where I could give the member names which should not be tested during the compare. Like
 stream: globals.mWorkDatabase.getSelectedOrder(
                    SettingKey.userSelectionSelectedFirm,
                    SettingKey.userSelectionSelectedOrder
                ).watchSingleOrNull().distinct( omit:["readTime", "lastUpdated"] ),

We don't have a particularly efficient way to deal with this unfortunately, but you can do this:
extension<T extends Insertable<T>> on Stream<T> {
  Stream<T> distinctIgnoring(Iterable<String> ignoredFields) {
    return distinct((previous, next) {
      final prevFields = previous.toColumns(false);
      final nextFields = next.toColumns(false);

      for (final MapEntry(:key, :value) in prevFields.entries) {
        if (ignoredFields.contains(key)) continue;
        if (nextFields[key] != value) {
          return false;
        }
      }

      return true;
    });
  }
}

Then you could call distinctIgnoring(const ['read_time', 'last_updated']).


I hope to increase the word spacing of this configuration

VSCode Version: 1.12.2 (1.12.2)
OS Version:  MAC

I hope to increase the word spacing of this configuration, because the long time to write code, the word spacing is too small will make my visual fatigue

You can instead the font family and font size in the settings. You can also scale the entire UI with cmd++.


Performance discrepancy of Llama3.1-8b-instruct

Hi,
Thank you for your valuable benchmark. I used your code to test the performance of Llama3.1-8b-instruct on the 16K but got much better results than the number you reported. The config I use is:
llama3.1-8b-instruct)
    MODEL_PATH="${MODEL_DIR}/Meta-Llama-3.1-8B-Instruct"
    MODEL_TEMPLATE_TYPE="meta-chat"
    MODEL_FRAMEWORK="hf"
    ;;

and the results are:

0,1,2,3,4,5,6,7,8,9,10,11,12,13
Tasks,niah_single_1,niah_single_2,niah_single_3,niah_multikey_1,niah_multikey_2,niah_multikey_3,niah_multivalue,niah_multiquery,vt,cwe,fwe,qa_1,qa_2
Score,100.0,100.0,99.8,99.4,100.0,99.0,97.9,99.75,99.96,91.3,100.0,89.6,99.8
Nulls,0/500,0/500,0/500,0/500,0/500,0/500,0/500,0/500,0/500,0/500,0/500,0/500,0/500

which has a mean of 98.19. However, you reported 91.6. I wonder what's the reason of the discrepancy.

@zhenyuhe00 I guess another reason is you should change template for Llama 3.1 models like
<|begin_of_text|><|start_header_id|>user<|end_header_id|>\n\n{task_template}<|eot_id|><|start_header_id|>assistant<|end_header_id|>\n\n
Default meta-chat is used for Llama 2 series.

Also, it is interesting you can get nearly perfect scores for QA tasks. From my side, I usually get qa_1: 8x and qa_2: 6x-7x even for closed-source Gemini or GPT4 models.

Also, it is interesting you can get nearly perfect scores for QA tasks. From my side, I usually get qa_1: 8x and qa_2: 6x-7x even for closed-source Gemini or GPT4 models.

LOL I also can't get nearly perfect scores for QA tasks even on 16k context.

@Wangmerlyn @hsiehjackson does the current order of essays match what has been used to populate the tables in the repo and the paper?

Also, it is interesting you can get nearly perfect scores for QA tasks. From my side, I usually get qa_1: 8x and qa_2: 6x-7x even for closed-source Gemini or GPT4 models.

It is the problem of the Llama 3.1 tokenizer. The text after applying the tokenizer's encode and decode functions would differ (e.g., from ". ..." to "...."). Therefore, the prompt in the question-answering task is incorporated into the prediction because of this line:
if text.startswith(prompt):
It would be better to comment out this line and force to truncate the generated tokens to exclude the prompt.

@zhenyuhe00 I managed to reproduce the results of 3.1 (with the right model template) and I think I haven't been affected by this issue with the tokenizer? Could you please share more specific steps to reproduce the behaviour you're talking about?

@zhenyuhe00 I managed to reproduce the results of 3.1 (with the right model template) and I think I haven't been affected by this issue with the tokenizer? Could you please share more specific steps to reproduce the behaviour you're talking about?

I don't think the tokenizer glitch would cause the issue of reproducibility. However, there could be some underlying unexpected behaviours.  If this line is not activated "if prompt in pred", the input prompt will not be truncated from the prediction. Since the metrics are match part and match all, this will lead to a whole score even if the model gets the wrong answer.
@hsiehjackson Can u please take a quick look into this?

Also, it is interesting you can get nearly perfect scores for QA tasks. From my side, I usually get qa_1: 8x and qa_2: 6x-7x even for closed-source Gemini or GPT4 models.

It is the problem of the Llama 3.1 tokenizer. The text after applying the tokenizer's encode and decode functions would differ (e.g., from ". ..." to "...."). Therefore, the prompt in the question-answering task is incorporated into the prediction because of this line: if text.startswith(prompt): It would be better to comment out this line and force to truncate the generated tokens to exclude the prompt.

You are probably not using the Pipeline from transformers. Llama 3.1 tokenizer does have this problem of that a text segment may not remain the same before and after encode then decode.
However if you are using the Pipeline from transformers (if you have flash-attn installed then the Pipeline should be used) , the prompt should be removed from the generated tokens (tested on my machine). I guess the reason is that text-generation pipeline is not the same as directly encode and decode the prompt. That's why even using the llama 3.1 tokenizer does not trigger this prompt not being able to be removed glitch.
I have opened a new PR addressing this problem when Pipeline is not used.


ReferenceConstructor should accept a single type argument

and allocate an internal buffer of the correct size.

run ci

@jasssonpet: I've updated the patch with handling for the cases we discussed, please take a look.

Looks good to me, :+1:


Broken style on VHOST Edit / Delete action buttons

https://www.dropbox.com/s/z0g4jzz6dvvvzih/Screenshot 2016-02-22 11.03.22.png?dl=0

Ugh, this is on me for refactoring some styles for SPD.  Will fix


Consider whether we need support minimal CRD installation

Summary
As numaflow support minimal CRD installation, we'd like to consider if numaplane needs to do the same.

Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

seems like you are doing this now?

it seems like if we don't see a need, we could just close this until a need arises in the future, if it ever does


KIC 2.0.0 Alpha.1 KEP Updates

Several iterations have occurred during the experimental phases between our last KEP updates and our alpha1. pre-release of KIC 2.0, as such it's now time to make sure recent changes are captured in the relevant KEPs that are tracking alongside this work so that it's easy for outside reviewers to understand the current state of things without digging deeply into code.

The KEP has been updated along with updates throughout the alpha stage, there's nothing fundamental to change until we're ready to mark the KEP as implemented when 2.0 goes GA.


Improve behavior in iOS Safari

Setting scrollTop does not work as expected during momentum scrolling.

It may be better adding a prop like deferJump: boolean not changing overall behavior as a first step.


No .gitignore, Readme.

There needs to be a labview .gitignore so the .lvlpls and .aliases files aren't tracked. And now they also need to be removed from all the branches. And while we're at it, lets add a readme.

finished


use message toast on new bike creation

This replaces the hard to see purple message with the new message toast interface. It also clears the new bike form on success to make it easier to add several bikes in a row

before:

after:


[Issue-2558] Fix issues related to earning

PR for #2558

🚀 Deployed on https://pr-2573--sw-web-runner.netlify.app


[Bug] restrict-clusterrole-nodesproxy is overprotective and should take ApiGroups into account

Kyverno Version
1.10.x
Kubernetes Version
1.26.x
Kubernetes Platform
Bare metal
Description
If a ClusterRole gets created that uses the "*" Resource in any ApiGroup, this policy prevents it, since theoretically the "*" could include "nodes/proxy" . The "nodes/proxy" Resource however is only dangerous in the "" ApiGroup (the core kubelet api), see https://blog.aquasec.com/privilege-escalation-kubernetes-rbac
The policy doesn't take the ApiGroup into account, breaking a lot of helm charts from granting "*" Resource access to their own ApiGroups. This for example prevents an istio installation.
A default istio installation tries to create the following clusterrole for example
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  labels:
    app: istiod
  name: istiod-clusterrole-istio-system
rules:
- apiGroups:
  - config.istio.io
  - security.istio.io
  - networking.istio.io
  - authentication.istio.io
  - rbac.istio.io
  - telemetry.istio.io
  - extensions.istio.io
  resources:
  - '*'
  verbs:
  - get
  - watch
  - list

Since only "nodes/proxy" inside the "" ApiGroup grants you dangerous code execution rights, this policy should be adjusted to also check for the ApiGroups.
A proposed change to the policy, the change is in spec.rules.validate.deny.conditions:
apiVersion: kyverno.io/v1
kind: ClusterPolicy
metadata:
  name: restrict-clusterrole-nodesproxy
  annotations:
    policies.kyverno.io/title: Restrict ClusterRole with Nodes Proxy
    policies.kyverno.io/category: Sample
    policies.kyverno.io/severity: medium
    policies.kyverno.io/subject: ClusterRole, RBAC
    kyverno.io/kyverno-version: 1.7.0
    policies.kyverno.io/minversion: 1.6.0
    kyverno.io/kubernetes-version: "1.23"
    policies.kyverno.io/description: >-
      A ClusterRole with nodes/proxy resource access allows a user to
      perform anything the kubelet API allows. It also allows users to bypass
      the API server and talk directly to the kubelet potentially circumventing
      audits and admission controllers. See https://blog.aquasec.com/privilege-escalation-kubernetes-rbac
      for more info. This policy prevents the creation
      of a ClusterRole if it contains the nodes/proxy resource.
spec:
  validationFailureAction: Audit
  background: true
  admission: true
  rules:
    - name: clusterrole-nodesproxy
      match:
        any:
        - resources:
            kinds:
              - ClusterRole
      validate:
        message: "A ClusterRole containing the nodes/proxy resource is not allowed."
        deny:
          conditions:
            all:
            - key: nodes/proxy
              operator: AnyIn
              value: "{{ request.object.rules[].resources[] }}"
            - key: ""
              operator: AnyIn
              value: "{{ request.object.rules[].apiGroups[] }}"

Steps to reproduce

Install kyverno (for example via helm)
Apply the /other/restrict-clusterrole-nodesproxy/restrict-clusterrole-nodesproxy.yaml policy, but change validationFailureAction to Enforce
Try to install istio (for example via helm https://istio.io/latest/docs/setup/install/helm/)
The installation gets prevented even though istio doesn't request "nodes/proxy" resources in the ApiGroup "" for the ClusterRole it creates

Expected behavior
The Rule should only prevent the resource "nodes/proxy" in the "" ApiGroup (the core kubelet api), not in "config.istio.io" ApiGroup.
Screenshots
No response
Kyverno logs
No response
Slack discussion
No response
Troubleshooting

[x] I have read and followed the documentation AND the troubleshooting guide.
[X] I have searched other issues in this repository and mine is not recorded.

Agree, will make this adjustment.


Hide generative drop from the deployments

What happened?
Since gen art is not implemented, some people are asking why is it on prod

Please reproduce in steps

Go to drops
Open chained
See nothing

Expected Behavior
Genart should be hiden on *.kodadot.xyz deployments
(Prod, canary, beta)
What browsers are you seeing the problem on?
No response
At which address did you encounter bug?
No response
Are you logged in?
None
Which wallet you are using?
No response
At which chain did you encounter bug?
No response
Screenshots
_
Relevant log output
No response
Payment link for reward
https://kodadot.xyz/ksm/transfer/?target=<My_Kusama_Address_check_https://github.com/kodadot/nft-gallery/blob/main/CONTRIBUTING.md#creating-your-ksm-address>
Code of Conduct

[X] I agree to follow this project's Code of Conduct

still need to hide it?


Split db.query.parameter.<key> to include the parameter type

Area(s)
area:db
Is your change request related to a problem? Please describe.
When sending a command to a database, the parameters may have a type associated with them (in MSSQL they always have, not sure about other databases).
At the moment only the value of the parameter is stored, but not the type.
Describe the solution you'd like
Split db.query.parameter.<key> into

db.query.parameter.<key>.value which stores the value as previously db.query.parameter.<key>
db.query.parameter.<key>.type which stores the parameter type

Describe alternatives you've considered
One possibility would be to store the type as part of the value, like
db.query.parameter.foo=42 (Int32)

However parsing this now need special logic, especially for strings.
Additional context
Related to https://github.com/open-telemetry/semantic-conventions/pull/866

Discussed in db semconv meeting, and suggestion is to keep db.query.parameter.<key> and introduce db.query.parameter.type.<key>


fixed memory leak

I hit >600MB memory usage after 10K requests of rendering of react.js components.
quote @ry
let me know if you can find a test case for the mem leak

Sorry I didn't have a testcase for it. I spotted the memory leak and it was a easy fix.
	defer C.free(unsafe.Pointer(scriptName_s))
	defer C.free(unsafe.Pointer(code_s))

thanks. landed in 9ba136c410ffae3720278658e919efcb044d2be1


🐛 Bug Report: OneLogin provider doesn't refresh token returning 401

📜 Description
Refreshing the page with the OneLogin setup, tries to log you in again.
The OneLogin provider tries to refresh the bearer token. resulting in a 401, because of a scope issue.
👍 Expected behavior
The provider should handle refreshing tokens properly. The provider should allow the user to customize the scope.
👎 Actual Behavior with Screenshots
We've inspected the error below in our network tab when inspecting the website:
{
  "error": {
    "name": "AuthenticationError",
    "message": "Refresh failed; caused by Error: Failed to refresh access token [object Object]",
    "cause": {
      "name": "Error",
      "message": "Failed to refresh access token [object Object]",
      "stack": "Error: Failed to refresh access token [object Object]\n    at /app/node_modules/@backstage/plugin-auth-backend/dist/index.cjs.js:526:18\n    at /app/node_modules/oauth/lib/oauth2.js:191:18\n    at passBackControl (/app/node_modules/oauth/lib/oauth2.js:132:9)\n    at IncomingMessage.<anonymous> (/app/node_modules/oauth/lib/oauth2.js:157:7)\n    at IncomingMessage.emit (node:events:529:35)\n    at IncomingMessage.emit (node:domain:489:12)\n    at endReadableNT (node:internal/streams/readable:1400:12)\n    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)"
    }
  },
  "request": {
    "method": "GET",
    "url": "/api/auth/onelogin/refresh?optional&scope=openid%20email%20profile%20offline_access&env=development"
  },
  "response": { "statusCode": 401 }
}

Adding a console.log inside the file @backstage/plugin-auth-backend/dist/index.cjs.js:526:18 gives us:
{
   statusCode: 400,
   data: '{"error":"invalid_scope","error_description":"refresh token missing requested scope","scope":"email profile offline_access"}'
}

👟 Reproduction steps

Setup OneLogin provider with backstage
Log in with your credentials
Inspect browsers network and filter on /refresh
Refresh the page, redirects you to login page
401 occurs
You're logged in again

📃 Provide the context for the Bug.
app.config.yaml
auth:
  providers:
    onelogin:
      development:
        clientId: ${AUTH_ONELOGIN_CLIENT_ID}
        clientSecret: ${AUTH_ONELOGIN_CLIENT_SECRET}
        issuer: ${AUTH_ONELOGIN_ISSUER}

auth.ts
import {
  createRouter,
  defaultAuthProviderFactories,
  providers,
} from '@backstage/plugin-auth-backend';
import { Router } from 'express';

import { PluginEnvironment } from '../types';

export default async function createPlugin(env: PluginEnvironment): Promise<Router> {
  return createRouter({
    logger: env.logger,
    config: env.config,
    database: env.database,
    discovery: env.discovery,
    tokenManager: env.tokenManager,
    providerFactories: {
      ...defaultAuthProviderFactories,
      onelogin: providers.onelogin.create({
        signIn: {
          async resolver(info, ctx) {
            const {
              profile: { email },
            } = info;
            if (!email) {
              throw new Error('User profile contained no email');
            }

            const [name] = email.split('@');

            return ctx.signInWithCatalogUser({
              entityRef: { name },
            });
          },
        },
      }),
     },
  });
}

🖥 Your Environment
  @backstage/app-defaults                                          1.4.5
  @backstage/backend-app-api                                       0.5.8
  @backstage/backend-common                                        0.17.0, 0.19.9
  @backstage/backend-dev-utils                                     0.1.2
  @backstage/backend-openapi-utils                                 0.1.0
  @backstage/backend-plugin-api                                    0.6.7
  @backstage/backend-tasks                                         0.5.12
  @backstage/catalog-client                                        1.4.6
  @backstage/catalog-model                                         1.2.0, 1.4.3
  @backstage/cli-common                                            0.1.13
  @backstage/cli-node                                              0.2.0
  @backstage/cli                                                   0.24.0
  @backstage/config-loader                                         1.5.3
  @backstage/config                                                1.1.1
  @backstage/core-app-api                                          1.11.1
  @backstage/core-components                                       0.12.4, 0.12.5, 0.13.8
  @backstage/core-plugin-api                                       1.0.6, 1.7.0, 1.8.0
  @backstage/errors                                                1.2.3
  @backstage/eslint-plugin                                         0.1.3
  @backstage/frontend-plugin-api                                   0.3.0
  @backstage/integration-aws-node                                  0.1.8
  @backstage/integration-react                                     1.1.21
  @backstage/integration                                           1.7.2
  @backstage/plugin-api-docs                                       0.10.0
  @backstage/plugin-app-backend                                    0.3.55
  @backstage/plugin-app-node                                       0.1.7
  @backstage/plugin-auth-backend-module-gcp-iap-provider           0.2.1
  @backstage/plugin-auth-backend-module-github-provider            0.1.4
  @backstage/plugin-auth-backend-module-gitlab-provider            0.1.4
  @backstage/plugin-auth-backend-module-google-provider            0.1.4
  @backstage/plugin-auth-backend-module-oauth2-provider            0.1.4
  @backstage/plugin-auth-backend                                   0.20.0
  @backstage/plugin-auth-node                                      0.4.1
  @backstage/plugin-bitbucket-cloud-common                         0.2.14
  @backstage/plugin-catalog-backend-module-aws                     0.3.1
  @backstage/plugin-catalog-backend-module-bitbucket-cloud         0.1.22
  @backstage/plugin-catalog-backend-module-github                  0.4.5
  @backstage/plugin-catalog-backend-module-scaffolder-entity-model 0.1.4
  @backstage/plugin-catalog-backend                                1.15.0
  @backstage/plugin-catalog-common                                 1.0.18
  @backstage/plugin-catalog-graph                                  0.3.0
  @backstage/plugin-catalog-import                                 0.10.2
  @backstage/plugin-catalog-node                                   1.5.0
  @backstage/plugin-catalog-react                                  1.2.1, 1.9.0, 1.9.1
  @backstage/plugin-catalog                                        1.15.0
  @backstage/plugin-events-node                                    0.2.16
  @backstage/plugin-github-actions                                 0.6.7
  @backstage/plugin-home-react                                     0.1.5
  @backstage/plugin-home                                           0.5.10
  @backstage/plugin-kubernetes-common                              0.7.1
  @backstage/plugin-org                                            0.6.16
  @backstage/plugin-permission-common                              0.7.10
  @backstage/plugin-permission-node                                0.7.18
  @backstage/plugin-permission-react                               0.4.17
  @backstage/plugin-proxy-backend                                  0.4.5
  @backstage/plugin-scaffolder-backend                             1.19.1
  @backstage/plugin-scaffolder-common                              1.4.3
  @backstage/plugin-scaffolder-node                                0.2.8
  @backstage/plugin-scaffolder-react                               1.6.0
  @backstage/plugin-scaffolder                                     1.16.0
  @backstage/plugin-search-backend-module-catalog                  0.1.11
  @backstage/plugin-search-backend-module-pg                       0.5.16
  @backstage/plugin-search-backend-module-techdocs                 0.1.11
  @backstage/plugin-search-backend-node                            1.2.11
  @backstage/plugin-search-backend                                 1.4.7
  @backstage/plugin-search-common                                  1.2.8
  @backstage/plugin-search-react                                   1.7.3
  @backstage/plugin-search                                         1.4.2
  @backstage/plugin-tech-radar                                     0.6.10
  @backstage/plugin-techdocs-backend                               1.9.0
  @backstage/plugin-techdocs-module-addons-contrib                 1.1.2
  @backstage/plugin-techdocs-node                                  1.10.0
  @backstage/plugin-techdocs-react                                 1.1.13
  @backstage/plugin-techdocs                                       1.9.0
  @backstage/plugin-user-settings                                  0.7.12
  @backstage/release-manifests                                     0.0.11
  @backstage/test-utils                                            1.4.5
  @backstage/theme                                                 0.2.19, 0.4.4
  @backstage/types                                                 1.1.1
  @backstage/version-bridge                                        1.0.7

👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
None

I'm not super familiar with OneLogin, so this is a bit of a shot in the dark, but offline scope might be necessary for refreshes? Have you tried adding that scope?

Hi any update on this issue?
Having the same issue after an upgrade to backstage 1.22.2 from 1.19.3.
The docs don't seem to mention anything about the offline scope.

@akira-personio the docs that you linked to mention offline_access scope. That's the exact scope that I think is going to help with refresh tokens. Do you provide that scope?

Hi, nope we aren't customizing the scopes at all, but it seems to be included... as we get the same error on refresh failure:

{"statusCode":400,"data":"{"error":"invalid_scope","error_description":"refresh token missing requested scope","scope":"email profile offline_access"}"}

or i wonder if those scopes listed are the available scopes, not the scopes in the token... 🤔

Hmm looks like offline_access is in the defualt list of scopes for OneLogin

when I log the refreshToken in the OneLoginProvider i get smth like:
{"jti":"xxx","sub":"xxx","iss":"xxx,"iat":111,"exp":111,"scope":"openid","aud":"xxx"}

The refresh token on the previous Backstage version (that works) looks pretty similar (same scope)... 😞

I do notice; however, that the refresh url is different:
old/works:
"GET /api/auth/onelogin/refresh?optional&env=local HTTP/1.1" 200
new/doesn't work:
"GET /api/auth/onelogin/refresh?optional&scope=openid%20email%20profile%20offline_access&env=local HTTP/1.1" 401

@akira-personio hmm, well this is interesting.
Looking at the diff for the two versions theres, not really much thats changed in the auth-backend apart from the Microsoft auth provider: https://github.com/backstage/backstage/compare/v1.22.2...v1.19.3

ok, thanks for sticking with me... for what it's worth... the refresh for onelogin appears to work if i remove the scope var entirely from:
https://github.com/backstage/backstage/blob/v1.22.2/plugins/auth-backend/src/lib/passport/PassportStrategyHelper.ts#L165
the url doesn't seem to matter, but it's could be generated from the contents of the scope var which is different now

Hmm ok - I'm gonna bring in @Rugvip to this too, he might have some ideas, but it's good that you've found something that at least works so we can investigate this a little more.

@akira-personio, hmm, the old behaviour actually seems a bit strange, I'd expect the scopes to be present in the refresh call, and especially not cause any issues. Do you know if the same scopes are present during the initial login?
Something to try out would be to override the default onelogin provider API in the frontend with one that sets a different set of default scopes, in case either of those scopes are causing trouble. Something like this but with your own defaultScopes option passed to OneLoginAuth.create in packages/app/src/apis.ts: https://github.com/backstage/backstage/blob/05e6b8389703b7795fb25483ae1f3af1fa6a66f6/packages/app-defaults/src/defaults/apis.ts#L202-L216

Hi @Rugvip ...
I'm not sure about the initial login, but In start method we appear to be using a single hard-coded scope of 'openid'.
(login appears to fail, if this is changed to req.scope)
If I modify the scope var in the executeRefreshTokenStrategy to 'openid', it seems to work, tho.
Will take a look at ur example and see if that works...

Yup, changing the defaultScopes to ["openid"] in the OAuth2.create seems to work... unfortunately, the options in the OneLoginAuth.create don't allow for that 😢

Yeah kind looks like we'll just want to hardcode this to just be 'openid' tbh, to mirror the behavior in the start method. On the frontend we can then simply remove the scopes altogether, since they'll be ignored anyway.

hey team we are having same issue, is there any ongoing work to fix this? what is the temporal fix you are using? Thanks

Solved in https://github.com/backstage/backstage/pull/23582


CRQ-8069 Change log level from debug to trace to prevent OutOfMemoryE…

Changed log level from debug to trace to prevent OutOfMemoryException in case of large data

The fix will go on 2.3+ branches


New TBR model from Jon Shimwell

In GitLab by @mkovari on Oct 11, 2016, 09:16
Jon has a new set of ~1000 runs for TBR, and a new method of fitting using a "Gaussian process" method, consisting of 1000 Gaussians.  This could be included, either
(a) wrap the the Python code and calling it from Fortran,
(b) writing Fortran code to evaluate the Gaussians, or
(c) wait until PROCESS is fully or partly refactored.
However...as far as I know the blanket thickness, major and minor radii etc are all fixed, which may make the model unsuitable.

As mentioned above, the model from Jon (even if it were still available) is not suitable.  I have emailed Chantal Shand to see if her team might come up with a surrogate model for TBR.  For the time being I will close this issue.
@jonmaddock


A clear working example of how code signing works with repack

Ask your Question
I am using repack and I am not absolutely sure how repack works with code signing. When i add the below configurations to Webpack config my bundling seems to fail and I need a clear understanding of which file/folder i need to make a change to get the mini app to work  with code signing
I have generated a private and public key using the below shell command
ssh-keygen -t rsa -b 4096 -m PEM -f code-signing.key
# Don't add passphrase
openssl rsa -in jwtRS256.key -pubout -outform PEM -out code-signing.key.pub
cat code-signing.key
cat code-signing.key.pub

wepack config
  new Repack.plugins.CodeSigningPlugin({
                privateKeyPath: './code-signing.key',
                outputFile: 'code_signing_mapping.json',
                outputPath: path.join(dirname, 'build/outputs', platform, 'remotes'),
            })

index.js
/**
 * @format
 */

import { AppRegistry } from 'react-native';
import App from './src/App';
import { name as appName } from './app.json';
import { ScriptManager, Script, Federated } from '@callstack/repack/client';

const resolveURL = Federated.createURLResolver({
    containers: {
        ECG: 'http://localhost:9000/[name][ext]',
    },
});
ScriptManager.shared.addResolver(async (scriptId, caller) => {
    // obtain your code-signing-mapping.json from filesystem?
    // how do i read the file locally based on the platform? for the tokens
    const resolveToken = Federated.createTokenResolver(tokens);
    let url;
    let token;
    if (caller === 'main') {
        url = Script.getDevServerURL(scriptId);
    } else {
        url = resolveURL(scriptId, caller);
        token = resolveToken(scriptId, caller);
    }
    if (!url) {
        return undefined;
    }
    return {
        url,
        token,
        cache: false,
        // verifyScriptSignature: true,
        verifyScriptSignature: __DEV__ ? 'off' : 'strict',
        query: {
            platform: Platform.OS,
        },
    };
});

AppRegistry.registerComponent(appName, () => App);

Hi @Nazehs,
you seem to got almost everything right, I think you forgot to add the generated public key to android strings.xml and/or ios Info.plist
check out this PR: https://github.com/callstack/super-app-showcase/pull/43
the only thing that isn't included in there is this:
verifyScriptSignature: __DEV__ ? 'off' : 'strict',

if it's failing during compilation please provide some logs

@jbroma quick question does this apply that i would have the same key for all the mini apps that i would include in the host app? or each would have it private/public key differently?

@Nazehs only sam key is supported for now

@jbroma i am still not sure of how i am suppose to get the below
 // obtain your code-signing-mapping.json from filesystem?
    // how do i read the file locally based on the platform? for the tokens
    const resolveToken = Federated.createTokenResolver(tokens);
    ```

@Nazehs I missed the fact that you are using TokenResolver, which I'm not sure was ever published.
The tokens are now integrated, this PR has some more insights on this matter, and contains some examples as well.

@jbroma i am still struggling to get this working because it stops bundling when i add the code signing plugin and i have different errors from the compiler each time i run it. I have a draft PR that i might want you to assist and look into and see if you are able to figure out what i am missing https://github.com/Nazehs/super-app-react-native/pull/3
Thank you in advance

@jefmoraes If you setup CodeSigningPlugin then the integrity tokens will be generated and automatically attached to the bundle itself. When you load the bundle from a remote origin, we split the bundle into two parts: the code and the token, verify it and return just the code to the JS runtime. So there is no need to setup TokenResolver at all (not to mention it's not a valid import).
@Nazehs Thanks for providing your setup, I'll take a look when I have a chance
Saying all that, I do apologise for the lack of better documentation, it's clear that the PR's are not enough and are confusing.

@Nazehs @jefmoraes
regarding the repository I did check it out and found two issues:

In packages/mini-app/webpack.config.mjs please change the privateKeyPath to './code-signing.pem' to make it work properly - only relatives path are supported for that field, this is fixed in Re.Pack v4 (available as 4.0.0-rc.0 as of right now).
Different versions of Re.Pack are being used in the project, that might be potential cause of some issues (e.g. enabled field of CodeSigningPlugin was introduced in 3.4.0)

@Nazehs @jefmoraes
I've added a draft of CodeSigningPlugin docs, please take a look and let me know what you think, and whether it is clear enough now. Your feedback would be greatly appreciated 🙏

Docs are now available here: https://re-pack.dev/4.x/docs/plugins/code-signing

Hi @jbroma how do you validate the proper configuration of code signing? Are there any methods to do so?

The easiest way to validate if your configuration is right is to simply run the app with verifyScriptSignature set to strict in the ScriptManager and verify that it works.

The easiest way to validate if your configuration is right is to simply run the app with verifyScriptSignature set to strict in the ScriptManager and verify that it works.

As you mentioned, I tried this but encountered the following error when start:

Do you have any idea how to resolve this?


Translate codebase

The codebase is still largely in Dutch which is a problem especially now that we have non-Dutch speaking members in the committee. Thus we should translate it asap.

Need to find out what the proper (and most fail-safe) way is to rename Django modules. Simply making migrations (when the module directory has been renamed) results in issues.

In the amelie directory:

[ ] activiteiten
[ ] alv
[ ] api
[ ] bedrijven
[ ] bestanden
[ ] blame
[ ] claudia
[ ] dreamspark
[ ] iamailer
[ ] ianew
[ ] inbitweencheck
[ ] jelte
[ ] kalender
[ ] kamerdienst
[ ] leden
[ ] msdnaa
[ ] narrowcasting
[ ] nieuws
[ ] oauth2
[ ] oauth2lib
[ ] onderwijs
[ ] over
[ ] settings
[ ] statistics
[ ] streeplijst
[ ] tools
[ ] twitter
[ ] videos
[ ] weekmail

Files in amelie directory:

[ ] forms.py
[ ] test_translation.py
[ ] test_urls.py
[ ] urls.py
[ ] views.py

Files in the scripts directory:

[ ] compile_css.sh

Other top-level project directories of which their files need translating:

[ ] templates
[ ] locale (?)

Other files that need translating that were not included in any of the above:

[ ] pullmaster.sh

All translation branches should branch from ticket294. Only after all branches have been merged back into ticket294 we can merge this branch into master.


Change some type annotation in YARD doc

Description
Some of the type annotations in the documentation referrenced types that
were not in scope for the annotation. This means that a compiler
generating the doc could incorrectly associate the constants with
another type which would be in scope.
Completed Tasks

[x] I have read the Contributing Guide.
[x] The pull request is complete (implemented / written).
[x] Git commits have been cleaned up (squash WIP / revert commits).
[ ] I wrote tests and ran bundle exec rake locally (if code is attached to PR). (no code)

Coverage increased (+1.0%) to 94.56% when pulling 9f8bfba61514961b971bcf985ea79ca94c9edf6f on gmalette:gm/change-annotations-for-scoping into 44ca65d53d76c5a401d5a7453bf0d1a58c238207 on lsegal:master.


Update AddressBookParserTest

100% line coverage on Intellij

Codecov Report

Merging #219 (7104171) into master (ee3adc5) will increase coverage by 3.60%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #219      +/-   ##
============================================
+ Coverage     63.81%   67.41%   +3.60%
- Complexity      650      696      +46
============================================
  Files           105      105
  Lines          2432     2434       +2
  Branches        324      325       +1
============================================
+ Hits           1552     1641      +89
+ Misses          754      647     -107
- Partials        126      146      +20

Impacted Files
Coverage Δ

...va/seedu/address/logic/commands/ManualCommand.java
92.85% <0.00%> (-7.15%)
:arrow_down:

...a/seedu/address/logic/commands/ArchiveCommand.java
5.55% <0.00%> (+5.55%)
:arrow_up:

...va/seedu/address/logic/commands/DeleteCommand.java
63.26% <0.00%> (+10.20%)
:arrow_up:

...java/seedu/address/logic/commands/UndoCommand.java
11.11% <0.00%> (+11.11%)
:arrow_up:

...a/seedu/address/logic/commands/HistoryCommand.java
16.66% <0.00%> (+16.66%)
:arrow_up:

...du/address/logic/commands/ConfirmClearCommand.java
16.66% <0.00%> (+16.66%)
:arrow_up:

...eedu/address/logic/parser/DeleteCommandParser.java
82.60% <0.00%> (+21.73%)
:arrow_up:

...du/address/logic/commands/DeleteModuleCommand.java
25.00% <0.00%> (+25.00%)
:arrow_up:

.../address/logic/parser/DeleteTaskCommandParser.java
39.47% <0.00%> (+39.47%)
:arrow_up:

...eedu/address/logic/commands/DeleteTaskCommand.java
47.72% <0.00%> (+47.72%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee3adc5...7104171. Read the comment docs.

LGTM 👍


Pubsub redis redelivers a message after 1 min

By default, with a vanilla dapr-redis and pubsub, it appears that redis redelivers a message if a subscriber doesn't respond within 1 min. That might be by design or it might be a function of redis more than dapr.
This discussion started on discord. Not sure if this is the right dapr/ repo to post on, happy to move it if required. The suggestion there was to set processingTimout to 0 in component's meta. I am not sure if and how that affects at least once delivery semantics.
Is this an expected default behavior for pubsub w/redis?

Thanks @yaron2
Before I close this issue, do you think adding a bit of a warning to the docs about this 'default' behavior would be warranted? Not sure if this is documented anywhere but it may not be that hard to run into and there is not that much in a way of logs as you see below. I was expecting some sort of warning about a one min timeout.
Here are the logs from a sample app and with the redelivery message
`== APP == [10:04:55 INF] Doing work 6 fe854ae0-aaa6-400a-b066-7b372b4877cb
== APP == [10:04:56 INF] Request starting HTTP/1.1 GET http://<IP_ADDRESS>:5004/health - -
== APP == [10:04:56 INF] Executing endpoint 'Health checks'
== APP == [10:04:56 INF] Executed endpoint 'Health checks'
== APP == [10:04:56 INF] Request finished HTTP/1.1 GET http://<IP_ADDRESS>:5004/health - - - 200 - **text/plain 0.2664ms
time="2021-07-24T10:05:00.0865061+02:00" level=debug msg="Processing Redis message<PHONE_NUMBER>469-0" app_id=daprpubsub-longjobservice instance=DTS scope=dapr.contrib type=log ver=1.2.0
== APP == [10:05:00 INF] Request starting HTTP/1.1 POST http://<IP_ADDRESS>:5004/longjob application/cloudevents+json 1204
== APP == [10:05:00 INF] Executing endpoint 'DaprPubSub.LongJobService.Controllers.LongJobController.Run (DaprPubSub.LongJobService)'`

@tstojecki we can add a note in the docs, sure. actually, if you want to submit a PR for it, that'd be awesome.


Feature/v0.96 civ rep improvements

I have changed a few things with wounded civilians:

Animations were not playing correctly for clients on dedicated server because switchMove is local command. I have added function F_cr_woundedAnim  which animates unit with random animation, this function uses remoteExec so animations will be synchronized correctly to clients.
After wounded civilian is healed he will play standing up animation, it looks a bit rough at the moment.

After healing civilian, message with format "Civilian named %1 is thankful for your help." will be broadcasted so players are not only informed about negative reputation changes but also when they do something positive ;-)
Function F_cr_penaltyMsg was renamed to F_cr_globalMsg for this functionality.

removeAllItems is called on wounded civilians. I have noticed that sometimes they healed themselves with FAK, this resulted in "free" reputation gain. This should fix this problem.

Good catch with the local effect on the animation. Thanks for the contribution. Really appreciate it :)


ReflectionXamlMetadataProvider GetXamlType taking more than 17 seconds to execute at app startup

Describe the bug
We have a large (104 DLLs and 1 EXE referencing all the DLLs) UWP app that was ported from WPF into UWP. The app uses many custom Xaml controls and forms spread out in ~50 DLLs. In Release with NET Native enabled, the app launches quickly (~3 seconds). In Debug, however, the code execution goes from App.cs into autogenerated XamlTypeInfo.g.cs, there it goes into GetXamlType(string fullName) where it calls Provider.GetXamlTypeByName(Provider being ReflectionXamlMetadataProvider) and at this point it starts loading all 104 DLLs into the memory which takes ~17 seconds on a fairly powerful machine to complete (8-core i7, 32GB RAM, SSD). This makes the UWP app impossible to use in Debug on HoloLens where this method takes ~1 minute to complete, because HoloLens determines that the app is not responding and shuts it down before we get to execute any code.
Steps to reproduce the bug
I guess you need many DLLs that contain a lot of XAML. Unfortunately, I can't share our code base. Then I think the behavior might be related to the following App.xaml.cs we are using:
sealed partial class App : MobileApplication, IServiceProvider
<mvvm:MobileApplication
…
Basically, we've derived our own App class in order to have our own bootstrap and IoC container. The call into GetXamlTypeByName tries to look for MobileApplication class.
Expected behavior
The call into GetXamlTypeByName  should not load all our DLLs into the memory which takes too long and I assume it also uses a lot of reflection. We didn't have this issue before updating to 1809 where all the UWP projects started referencing Microsoft.UI.Xaml.Markup by default.
Screenshots

Version Info
Windows 10 1903, UWP app has Min/Target versions set to 1809.
NuGet package version:
Microsoft.NETCore.UniversalWindowsPlatform 6.2.9

Windows 10 version
Saw the problem?

May 2019 Update (18362)
Yes

October 2018 Update (17763)
Yes

April 2018 Update (17134)
No

Fall Creators Update (16299)
No

Creators Update (15063)
No

Device form factor
Saw the problem?

Desktop
Yes

Mobile
No

Xbox
No

Surface Hub
No

IoT
No

Additional context

There is a compile time flag to turn off the ReflectionMetadataProvider. I can't find the docs on what the property is though. @Fabiant3 @danzil can you help?

We use the reflection metadata provider in debug configs to help speed up incremental builds. For your case, it looks like the large number of dll is actually making things worse, so the best course of action is to disable it using this property in your project that is referencing the dlls.
  <PropertyGroup>
    <EnableTypeInfoReflection>false</EnableTypeInfoReflection>
  </PropertyGroup>

Thank you! It helped!

@realtommyklein I'm assigning this to you to see if there is any way this can be improved. Are we able to provide hints to the ReflectionMetadatProvider so that it can more efficiently find types, or maybe figure out which projects might run into this issue and fire warnings?

Yes, we can definitely improve the search behavior by following the WinRT naming convention (e.g. when searching for "Foo.Bar.Employee" type, first look for a "Foo.Bar" assembly, then a "Foo" assembly).  We can also raise a warning when this would be insufficient because a type violates the naming convention, and there are many assemblies referenced by the project.

I don't know if the Xaml Compiler should be in the business of raising warnings about how types are organized in assemblies. We could definitely better optimize those lookups.

I don't know if the Xaml Compiler should be in the business of raising warnings about how types are organized in assemblies.

We should definitely optimize our lookup. But if we're shipping a feature that fundamentally degrades the user experience in certain scenarios, and we can detect those scenarios, then I think raising a warning is appropriate.
Actually, activating types in this scenario (when violating WinRT naming conventions) doesn't even work does it? If that's the case, would disabling the feature entirely make more sense?

We're already having a lot of trouble with MIDL and WinRT imposing these silly assembly naming conventions. Since type activation in .Net does not require it (you can reference a Class Library instead of a Windows Runtime Component), I don't believe the Xaml Compiler should either. We should fix our perf and perhaps warn about the reflection provider not being the right mechanism to use if it really takes that long, but not about how the assembly is organized.

It looks like the false flag has stopped working in VS 2019 16.5.2. The delay at startup is back even though the flag is still present in the startup project's csproj. Additionally, the app started crashing with NullReferenceException looking for type ObservableCollection in Debug (the stack trace points to the ReflectionMetadataProvider). In Release, it works fine without crashing.

Were there any other changes made besides upgrading the version of Visual Studio?  In particular, were there any new projects added that are referenced/built by the app, like a WinRT component that serves as a Xaml control library?  It's possible another Xaml project that's part of your build and referenced by the main app still has the flag enabled, and would still use the reflection provider.
Otherwise, I'd recommend enabling Diagnostic MSBuild logging (in Visual Studio: Tools -> Options -> Projects and Solutions -> Build and run -> MSBuild project output build verbosity -> Diagnostic).  Then rebuild your solution, and in the Build output window, Ctrl+F for EnableTypeInfoReflection and verify they're always set to false (if the value has been overwritten/reassigned, the logs will also indicate that).


In Network DAO, update contract, after transaction success, an error occurs in console

Description
In Network DAO, update contract, after transaction success, an error occurs in console
Steps To Reproduce

Log in...
Enter Network DAO, contract management page, choose update contract

Current Behavior

After updating contract success, an error occurs in console

https://github.com/TomorrowDAOProject/tomorrowDAO-interface/assets/167854655/fc6520a3-d692-4aae-81a1-5483f4fa5709
Expected Behavior

No error occur

Environment

Platform: PC
Node: v18.18.0
Browser: Chrome 126.0.6478.56

fixed confirm


Integrated terminal closes immediately when set to Windows Bash

VSCode Version: 1.3.1
OS Version: Windows 10.0.14393

Steps to Reproduce:

Enable user setting "terminal.integrated.shell.windows": "C:\\Windows\\System32\\bash.exe"
Open integrated terminal

Seeing this as well. I tried to switch back to cmd.exe and the same thing happens.

To clarify, in my case, switching back to cmd/git-bash is successful. But whenever I try pointing to Windows Bash, it fails.

Failed to launch through "c:\Windows\System32\bash.exe" or "c:\Windows\sysnative\bash.exe" .
Same thing in Atom editor.

@mzvast Does switching back to cmd.exe work for you?

@brianblakely Nope. Either in Atom.
default value "terminal.integrated.shell.windows": "C:\\WINDOWS\\system32\\cmd.exe"
T_T

@mzvast Hmm, does that mean something possibly with Electron? Aren't they both built on Electron?

@brianblakely
Yep,they are  electron-based.
Interesting, when I launch C:\windows\system32\bash.exe on WebStorm(which is a java-based IDE),it prompt an error that
java.io.IOException: Couldn't create PTY
in which,I think, maybe lies the problem.

Interestingly, if I set ComSpec to %windir%\system32\cmd.exe then it behaves just like if I try to set it to ``bash.exe. If I set ComSpectoC:\WINDOWS\system32\cmd.exethencmd.exe` works fine.

I wrote up some documentation on configuring the terminal for Windows recently https://code.visualstudio.com/docs/editor/integrated-terminal#_configuration
Try using c:\\Windows\\sysnative\\bash.exe, and make sure it's installed and you can access it in a regular cmd.exe prompt.

@Tyriar Interesting. If I do that, then the CTRL+` works, but CTRL+SHIFT+C does not.

@mattblang that's because c:\Windows\sysnative\bash.exe is a console program instead of a full-blown terminal, you need to run it through cmd.exe. You may be able to write a wrapper batch script that runs cmd.exe and bash.exe inside that, then use that as the external terminal.

@Tyriar Should c:\windows\system32\bash.exe not work for both of the hotkeys?

Thank you for the help @Tyriar

@mattblang don't know enough about it, but my assumption is that bash.exe needs cmd.exe's UI to be able to run. If you can get it working please share and I'll add to the docs :smiley:

After deleting Code repo in %appdata% and reinstalling VSCODE,then it works.
I've upgraded from 10586,without reset my computer .
Maybe some  cache cause the flashing~
Thanks for all of you.Well done~
:)

So, I'm not on the anniversary update, and pointing to bash.exe didn't work, but doing the below seems to be working for me (only just tried it, haven't used it extensively):
// settings.json
{
    "terminal.integrated.shell.windows": "C:\\Windows\\System32\\cmd.exe",
    "terminal.integrated.shellArgs.windows": [
        "/k",
        "C:\\Program Files\\Git\\bin\\bash.exe"
    ]
}

@jamiebarrow that's git bash, the version of bash shipped with the git installer, this issue is specifically about the Bash on Ubuntu (WSL) executable.

@Tyriar Ah okay, I don't have the anniversary edition installed, though was wondering if perhaps that would be a workaround if people are getting the same issue I had - trying to run git bash on Win 10 in integrated terminal was giving me the same issue, terminating immediately. Thought it was worth sharing :)

@jamiebarrow perhaps, thanks for sharing :smiley:

I came here with this issue, bash integrated terminal just immediately closing upon opening the terminal. I read this thread and then tried opening cmd and running bash. I then realised I didn't have developer mode turned on, and hadn't installed bash correctly.  I fixed it by switching developer mode on, and installing bash by calling it from cmd.
I originally went to windows features, switched on the linux subsystem, did a restart and then "installed" bash by clicking start, typing bash, and clicking on it, based on some older instructions I read. Then modified the vscode settings. Clearly the wrong process to set it up. I'm just adding this comment because other people might have done the same.


Swift 4?

Im getting a lot of syntax errors after migrating to Swift 4 and Xcode 9.

I went through and fixed them

@Maxnelson997 do you have already a solution?

same problem - any news about Swift 4 and Xcode 9 support?

Ah dang I really wanted to contribute... I should have hopped on this the day I fixed it.. :(

I tried going through and fixing them, but not all had a 'Fix' button and I would rather not have to go figure out what to do, so I would really appreciate seeing a new version as quickly as possible (I'm on the last strings of getting my app out and actually flying in tonight to see the 'principals', so doing the update is pretty important!)

@Vaberer ? Please help us by merging the swift 4 fix and create a new release. Thanks !

Hello, update the pod to 1.7.0 Thanks for your patience. If there is sth urgent in the future, contact me at<EMAIL_ADDRESS>

I still get those errors on Xcode 9.1 with 1.7.1. Any idea?

Same here, any updates on this?

works fine for me.......
 pod 'Font-Awesome-Swift', '~> 1.7.0'
be sure to do pod update before pod install - then Swift Language Version of 4.0 works (compiles with no Font-Awesome-Swift errors)


Unit tests are actually Integration tests

Issue
In the test suite there is one folder containing tests tests/Unit.
These are not unit tests as they interact with an external service integration. Thus they are tests/Integration tests because they touch either SQLite or MySQL implementation.
Solution
Rename tests folders to represent the tests they actually perform.

Will consider this. I completely understand where you are coming from.


Add file info extension (remove checksum extension)

Related Issue(s): #879 #921
Proposed Changes:

Add file info extension with 5 fields, see #921
Remove checksum extension (is now part of the file info extension)

cc for review: @geospatial-jeff @kylebarron @emmanuelmathot @vincentsarago
PR Checklist:

[x] This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
[ ] This PR has no breaking changes.
[x] I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
[ ] This PR affects the STAC API spec, and I have opened issue/PR #XXX to track the change.

Great. Merging for now, but let me know if you find additional things to change/improve/add. Happy to make further PRs.


Val cannot be reassigned

your code doesn't work. Please update it with correct code. The problem is occurring here:
viewFinder.surfaceTexture = it.surfaceTexture
Best

Hey just send me a PR with a fix and I'll happily merge!
Thanks

Code still doesn't work but I have decided to use some other method to achieve similar results. Therefore, closing.


Additional seeding workflows

[ ] prisma reset should reset the database and initiate seeding if a seed property is present (optionally provide --no-seed flag)
[ ] prisma import should accept a .graphql file for seeding
[x] prisma seed (optional): Run seed according to seed property in prisma.yml. This would be convenient, but developers needs to make sure to run prisma reset before (if she so wishes).
[ ]  more ideas here: https://github.com/graphcool/prisma/issues/1181

Right now, the best workflow to "start from scratch" + seeding is this:
prisma seed --reset

Right now, the best workflow to "start from scratch" + seeding is this:
prisma delete
prisma deploy

I think the suggested behaviour of prisma reset above would be super cool.

Yes, I just used prisma reset expecting it will seed data from seed.graphql only to find out it didn't. I think it doesn't make much sense to have seed file there as a part of initial boilerplate while its modification doesn't matter as it cannot be used anymore.

@FredyC
What's so hard about

prisma delete
prisma deploy

It works fine for me.

@gihrig It's not about hard, but about some sort of comfort and I bet it's even faster to just reset data then destroy and recreate the whole service. For automated tests having extra seconds does matter, especially if you need to reset several times to ensure a clean slate.

Really looking forward to this feature - destroying services each time for the sake of resetting seeds is overkill.

We added prisma seed in 1.7.1:
prisma seed # seed data according to `seed` property in `prisma.yml`
prisma seed --reset # reset service before seeding.

@marktani great news on prisma seed would it be worth updating the documentation to show that this is now possible?
https://www.prisma.io/docs/reference/service-configuration/prisma.yml/yaml-structure-ufeshusai8#seed-(optional)

Hello
I'm starting a new project for automating the seeding on multiples db with javascript and knex.js, please have a look at this and let me hear your recommends, thanks
here is a code example:
//creating and seeding process
ks.createAndSeed(userTableModel, 10).then(() => {
    //creating the table automatically & seeding ...
    ks.createAndSeed_close(roleTableModel, 10, (table) => { //closes the connection after process
        //creating the table with knex.js fn & and seeding ...
        table.increments(),
            table.string('name'),
            table.string('category'),
            table.timestamps(true, true)
    }).then(()) =>{
        //do something here...
  }
})

One code to seed them all!

Thanks for sharing @2rhop, can you elaborate how this is relevant for Prisma? 🙂

Is graphcool cli going to support this too?
I'm using graphcool-framework and not prisma, and I need to import a .graphql file for seed data. Should I open a new issue in the graphcool-framework repository?

If like me you wanted to clear the db and then re-seed:
prisma reset
y
prisma seed

It was mentioned that we can supply a script for seeding, does that mean it is just a hook, and no method from prisma is injected?

@marktani It's not relevant. He's advertising his OSS (with logos and self-thumbs-up and everything)... 🤦♂


fix(lua-language-server): rename sumneko_lua -> lua_ls

Fixes #147
Based from the changes on https://github.com/neovim/nvim-lspconfig/pull/2439

Thanks!!

Eagerly waiting on this to be merged

Eagerly waiting on this to be merged

Me too :)

@williambotman /fixup

To help with Googling, for those using lsp-zero and have sumneko_lua in ensure_installed, you will see the following error:
[mason-lspconfig.nvim] Server "sumneko_lua" is not a valid entry in ensure_installed. Make sure to only provide lspconfig server names.

Thanks!  This will produce the following, new, warning message from mason-lspconfig for some using require("mason-lspconfig").setup_handlers():
mason-lspconfig.setup_handlers: Received handler for unknown lspconfig server name: sumneko_lua.

So, how do I avoid this warning?🥺

Thanks!  This will produce the following, new, warning message from mason-lspconfig for some using require("mason-lspconfig").setup_handlers():
mason-lspconfig.setup_handlers: Received handler for unknown lspconfig server name: sumneko_lua.

So, how do I avoid this warning?🥺

Just uninstall all the sumneko_lua and install lua_ls. Thank you...


Feature request: return payment hash on a successful LNURL withdrawal

It would be useful if LnUrlCallbackStatus::Ok included the payment hash of the invoice sent to the LNURL-w service. Otherwise, unless I'm missing something, it's hard for a consumer of the SDK to know exactly which payment is associated with this withdrawal.

Sounds like a valid use case to me. cc @ok300


Adjust API path

According to our API specification we are using the plural for resources ("/users/" instead of "/user"), this PR updates the path (and also is used to test modifications to the not working github action.

Is this supposed to be merged or is it just for testing purposes @henrybrink?. If it is supposed to be merged, I don't quite get why the route should be /users implying that getting a user by his id is /users/1. /user/1 "sounds" more sensible (see Github API Documentation).

I'll agree - as the backend action now is working we can close this PR


News Scenarios for CapricornCafe

When @therealfnadeau will have tested locally his new scenario files, then I will merge.

is there a way to test scenarios with travis ?

I've been thinking about it, not really since they all require api keys etc.
I think the best we can setup is test mocks for the go functions

I should probably give go a try and try to implement these 🎅

Would be a great idea ;)


quote the environment

Signed-off-by: Chuck Ha<EMAIL_ADDRESS>What this PR does / why we need it:
I swear the example didn't have quotes 😭
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #67
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note:
NONE

/lgtm


Possible to name subreddit ripped pics as titles of posts?

Hey, amazing work on this program.
I would like to ask if it is possible to name the pics downloaded from a subreddit as the link titles in the subreddit.
Thanks!

I would like to ask if it is possible to name the pics downloaded from a subreddit as the link titles in the subreddit.

Looking over the reddit ripper it appears that it cannot name pictures after the post they were downloaded from

I don't know if there's a good reason we can't. I'll investigate this.


Please add 530003

Please add 530003

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fa732de6-2cab-d780-aa21-dfec80e0a8fe
Version Independent ID: 1a11b9b6-cf4f-3581-0864-0d5046943b6e
Content: Error codes in the Azure Active Directory portal
Content Source: articles/active-directory/reports-monitoring/reference-sign-ins-error-codes.md
Service: active-directory
Sub-service: report-monitor
GitHub Login: @MarkusVi
Microsoft Alias: markvi

@dcpopescu , Thanks for raising the issue.We will investigate the issue and update you.

I have staged an updated version of this article.
#please-close


.Net: C# TextChunker customizability

The current TextChunker uses the following hardcoded separators to split lines.  Defined as:
private static readonly string?[] s_plaintextSplitOptions = new[] { "\n\r", ".", "?!", ";", ":", ",", ")]}", " ", "-", null };
private static readonly string?[] s_markdownSplitOptions = new[] { ".", "?!", ";", ":", ",", ")]}", " ", "-", "\n\r", null };
The public methods does not allow one to specify your own separators. The above is problematic for instances like ours where the decimal point in numbers is a ".". Therefore given text like "The return of X is 0.5%" the chunker will see "The return of X is 0." as a line.  This causes some paragraphs to cut off at critical points. Though this can be solved to an extend by overlaps, we have various instances where this causes vectors on content to cut off like this.
Is it possible that public functions be made available where these can be specified by the caller. What would be nice is if they remain strings and not char. we can then specify ". ". i.e a full stop followed by a space as a valid sentence breakpoint. This will make the TextChunker much more usable. It would also be nice if this can be specified as part of the runtime configuration settings.

Hi @rnortje-sygnia thanks for submitting this. Would you be interested in submitting a PR to fix this issue?

Would love to but do not have the capacity to do this at this stage, at least not in a reasonable timeframe.

We'll be removing the text chunker from v1.0.0 of Semantic Kernel, so I'm closing this issue.

I may have spoken too soon! We're reopening this issue and hoping to find a new home for the TextChunker. In the meantime, we'll be marking as experimental.

All .Net issues prior to 1-Dec-2023 are being closed. Please re-open, if this issue is still relevant to the .Net Semantic Kernel 1.x release. In the future all issues that are inactive for more than 90 days will be labelled as 'stale' and closed 14 days later.


ftplugin/python.vim: E518: Unknown option: ]\?def\|class\)

Steps to reproduce
update to vim v9.1.0411:
edit reproduce.vim:
set nocompatible
filetype plugin on

start vim:
vim -u reproduce.vim

edit an arbitrary python file:
:edit foo.py

and you will see:
Error detected while processing BufNewFile Autocommands for "*.py"..FileType Autocommands for "*"..function <SNR>25_LoadFTPlugin[18]..script /usr/local/opt/share/vim/vim
91/ftplugin/python.vim:
line   17:
E518: Unknown option: ]\\?def\\|class\\)
Press ENTER or type command to continue

screen capture:

I believe it was introduced by https://github.com/vim/vim/commit/86f6e2c2eed7df2bf5c60cc74d08d7a8d3c75f45
Expected behaviour
no exception.
Version of Vim
9.1.411
Environment
OS: Both Windows and Linux
Terminal: no matter terminal vim or gvim
Logs and stack traces
No response

@tpict , can you confirm this ?

It has been already fixed in 7961210b861ce9a1a773cfc1fe96b388216bb1f2. Please try v9.1.0412.
Thanks.


Rename examples_src to examples

I'd like it if the built examples could go in build/examples.  This would make it easier to search for things in our sources (if you exclude build when searching) and people would be less prone to accidentally editing the built examples.
The slight downside of this is that after npm start you browse to http://localhost:3000/build/examples/ to view the examples (instead of http://localhost:3000/examples).  An alternative would be to rework things in a bigger way and run the development server with a different root, but I'm trying to make incremental improvements.
Any other opinions?

I'd be in favour of such a change, and I have no strong opinion on whether to change the development server root or to browse to http://localhost:3000/build/examples/ to run the examples.

I would be supportive of this change, and wouldn't mind browsing to build/examples

+1 to move the examples to build

+1

+1, I don't like having both examples and examples_src at the root of the repo. It's confusing. build/examples sounds good to me.

Ok, I've started on this (and some other cleanup of build.py related to examples) in my built-examples branch.

You finally decided against using build/examples as the destination directory?

You finally decided against using build/examples as the destination directory?

No, I just had a temporary commit in place to start untangling all the resources that the examples depend on.  The change is fairly involved, see #3558.


Control of setting the event to multiple layers (map and vector)

Hi,
If you have set a click event to the map and the vector layer , it will also be firing map of events when you click on the feature of the vector.
Suppresses the event set in the map, Is it possible to fire only events set in the vector Layer ?
Please check since the sample was prepared.
http://jsfiddle.net/mfdev1/zgj6q6La/4/

I am not quite sure if I understood you correctly, but I think you only want one event to be fired and not two different ones? So only the click on the map OR the click on the vector layer?
If so, I guess you could try fixing your fiddle by using the same event for both the map AND the layer:
        defaults: {
            events: {
                map: ['click'],
                layers: ['click']
            }
        }

[...]

    $scope.$on('openlayers.map.click', function (event, data) {
        $scope.$apply(function (scope) {
            $scope.mouseClickVector = '';
            if (data) {
                var p = ol.proj.transform([data.coord[0], data.coord[1]], data.projection, 'EPSG:4326');
                $scope.mouseClickMap = p[0] + ', ' + p[1];
            }
        });
    });

Hi @BenSower, thanks for your answer.
But, it was not I wanted answers.
Any example that I received seems to be firing two events.
As for me, if the feature of the vector layer is selected, I want to know how you do not want to fire the events of the map layer.
It supports now be handled in a map of the event.
See http://jsfiddle.net/mfdev1/zgj6q6La/12/ for full example
please tell me if there is a smart way

I'm doing some housekeeping and closing the issue since it's quite old. Please feel free to re-open it if it still persists. Also maybe try to upgrade to the latest version as it might fix it for you.


Jobtastic Task uses the root logger

I thought that the best practice was to get the logger at the top of the module:
import logging
logger = logging.getLogger(__name__)

class JobtasticTask(Task):

    def apply_async(self, args, kwargs, **options):
        if task_id:
            logger.info('Found existing cached and completed task: %s', task_id)

Currently, JobtasticTask just uses the root logger in a few places (logging.info('Found existing cached and completed task: %s', task_id)) which makes it hard to create special logging configurations for Tasks.
Is there a reason to use the root logger, or can I create a PR to change them?

This seems to have been completed partially, but there are still a bunch of calls to logging.info.  They should probably be replaced with a local logger so they can be enabled/disabled.


Revert low_cpu_fsdp implementation

we had two implementations of low_cpu_fsdp:

load full model on rank0, and meta device on all other ranks.  then we use sync_module_states to broadcast the weights.
use meta device on all ranks. and random init it in FSDP call. and post-load the state dict.

we switched from 1 to 2 when we switched from FSDP to 2d (TP + FSDP), as TP's parallelize_module does not like implementation 1 due to variables on different devices during tp-parallelize.
However, as we cut TP and 2d in this open source version of training, we want to revert this and use the first implementation which will make post_init easier.

Now come to think about this, we might want to keep implementation 2 -
When start from scratch, we have
    if start_step == 0:
        print("Starting from scratch - initializing parameters")
        model.reset_parameters()

as a post-init to guarantee the true init
And when continue training, we have checkpointer to load from ckpt.


async is now a keywordand breaks pylama in Python 3.7

pylama has an argparse option called async, in Python 3.7 async is now a keyword,
Line 10 of of main.py throws an error
from .async import check_async

and line 46
if options.async:

and finally line 202 of config.py
if options.async and 'pylint' in options.linters:

are three references I found that caused pylama to break for me on Python 3.7. I don't use the --async option so I just removed all those references locally to hack in a fix.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

I have merged @michael-k's pull request #120 into Pylava. Pylava is intended to be a community maintained fork of Pylama. It works with Python 3.7.
Enter the following command to install Pylava:
pip install pylava

With Python 3, you may need to enter the following command instead:
pip3 install pylava

After that you need to use pylava instead of pylama, for example, by updating your pylama commands to pylava commands.
Thanks to @michael-k for the pull request.


Angular Project not working

Describe the bug
When creating a new angular project from stack blits it works fine but after adding it to Git, it does not work.
Link to the blitz that caused the error
https://stackblitz.com/~/github.com/kashifbhatti4/stackblitz-starters-gegzfj
Steps to reproduce
open the repository and it starts compiling which throws multiple errors.
Expected behavior
ng serve should be successful.
Parity with Local

[X] I have run the project in my local machine and I could not reproduce the issue.

Screenshots
No response
Platform
Version = 1.84.0
Hash = a5b1ce2088a8c48a3bfda4a131ef20e00b36d9eb
WebContainer = a2aabdd9

Browser name  = Chrome
Full version  = <IP_ADDRESS>
Major version = 120
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 94468338,
  "usedJSHeapSize": 89931538,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}

Additional context
No response

Hey @kashifbhatti4 👋 . Thanks for reporting! This is indeed an error on our side. I just noticed that the devDependencies are entirely out of date. I've raised this issue internally and created a ticket so we can address this.
You could replace the devDependencies with these in the mean time
  "devDependencies": {
    "@angular-devkit/build-angular": "17.0.8",
    "@angular/cli": "17.0.8",
    "@angular/compiler-cli": "~17.0.8",
    "typescript": "~5.2.0"
  }


Catch and process CSV::MalformedCSVError

The CSVProcessor crashed please provide the following information to your coordinator to send to the System Administrators Illegal quoting in line 5094. ["/usr/local/lib/ruby/2.6/csv/parser.rb:879:in parse_quotable_robust'", "/usr/local/lib/ruby/2.6/csv/parser.rb:818:in block in parse_quotable_loose'", "/usr/local/lib/ruby/2.6/csv/parser.rb:31:in block in each_line'", "/usr/local/lib/ruby/2.6/csv/parser.rb:28:in each_line'", "/usr/local/lib/ruby/2.6/csv/parser.rb:28:in each_line'", "/usr/local/lib/ruby/2.6/csv/parser.rb:779:in parse_quotable_loose'", "/usr/local/lib/ruby/2.6/csv/parser.rb:303:in parse'", "/usr/local/lib/ruby/2.6/csv.rb:1236:in each'", "/usr/local/lib/ruby/2.6/csv.

@PatReynolds I don't think you meant to assign Anna?

Code updated to provide a simpler more informative email to the user when MalFormedCSVError is encountered.
Full code trace is still available in log.


Can't create a synonym in BAS on VSC

Hi Team, i have an issue can you help me, when i try to create a synonym in BAS on VSC can't get the information of tables on container:

Regards,
Fabian.

same problem


Status - operation not permitted(

Hi all.
I ran into a problem, the whole system works fine, but when I click the status button in the interface, I get the error "operation not permitted".
Tell me how to fix this?

search.. https://github.com/ngoduykhanh/wireguard-ui/issues/176


Add error hint for common version const format mistake

No issue with adding this but I will say I given our loose model and lack of consistency of this version info there are likely other errors lurking in our future as well. For example I'm waiting for us to return the wrong version because we find multiple version matches in the files.

Yeah I kind of expect this to involve into a compendium of common format errors and a corresponding hint to fix each one.


Assets with a 0 balance are displayed in the UI

If we create assets in a CLI and open its db via the UI. Then assets with 0 balance will be displayed

Pass 1
wallet.zip

Only assets with any 0-zero value will be displayed now. It is possible that asset entry in assets pane would be still 0 if asset for example is 'receiving' or 'maturing' or 'sending'. Though only registered assets would be not displayed. If you had an asset and sent all the amount to somebody it will be displayed while sending > 0 but removed when sent completely. Translations with 100% spent asset would be still visible in the transactions table.

checked

checked