Resolves #2046

Typo in module name
https://github.com/MicrosoftDocs/windows-powershell-docs/issues/2046

Docs Build status updates of commit 279b2ea:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/iisadministration/Get-IISAppPool.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Add-WebConfiguration.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Add-WebConfigurationLock.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Add-WebConfigurationProperty.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Backup-WebConfiguration.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Clear-WebCentralCertProvider.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Clear-WebConfiguration.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Clear-WebRequestTracingSetting.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Clear-WebRequestTracingSettings.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/ConvertTo-WebApplication.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Disable-WebCentralCertProvider.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Disable-WebGlobalModule.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Disable-WebRequestTracing.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Enable-WebCentralCertProvider.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Enable-WebGlobalModule.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Enable-WebRequestTracing.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebAppDomain.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebAppPoolState.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebApplication.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebBinding.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebCentralCertProvider.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebConfigFile.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebConfiguration.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebConfigurationBackup.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebConfigurationLocation.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebConfigurationLock.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebConfigurationProperty.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebFilePath.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebHandler.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebItemState.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebManagedModule.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebRequest.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebURL.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebVirtualDirectory.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-Website.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebsiteState.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebAppPool.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebApplication.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebBinding.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebFtpSite.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebGlobalModule.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebHandler.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebManagedModule.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebVirtualDirectory.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-Website.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Remove-WebAppPool.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Remove-WebApplication.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Remove-WebBinding.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Remove-WebConfigurationBackup.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Remove-WebConfigurationLocation.md
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

@dariomws @get-itips @tseward
Peer review needed for this PR. Thanks.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

I did not use git mv but it is still detected as a rename only. I do not see history in the files. Will redo it with git mv. Very good point, I did not think about the history.

I'm sorry to disappoint you but we'll lose history anyway.
Seems that we only see file renames as the difference in this PR, so it could be ok. Also, I think you should take care of the TOC file and redirections.

@dariomws Yeah, it seems like history cannot be preserved in Github while you can still see it using git log -follow. I am not sure I understand what you mean by  TOC file and redirections. I search the whole repo for the misspelled webadminstration and found only 1 match that has been corrected.

Docs Build status updates of commit b192397:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/iisadministration/Get-IISAppPool.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Add-WebConfiguration.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Add-WebConfigurationLock.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Add-WebConfigurationProperty.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Backup-WebConfiguration.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Clear-WebCentralCertProvider.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Clear-WebConfiguration.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Clear-WebRequestTracingSetting.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Clear-WebRequestTracingSettings.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/ConvertTo-WebApplication.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Disable-WebCentralCertProvider.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Disable-WebGlobalModule.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Disable-WebRequestTracing.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Enable-WebCentralCertProvider.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Enable-WebGlobalModule.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Enable-WebRequestTracing.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebAppDomain.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebAppPoolState.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebApplication.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebBinding.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebCentralCertProvider.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebConfigFile.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebConfiguration.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebConfigurationBackup.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebConfigurationLocation.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebConfigurationLock.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebConfigurationProperty.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebFilePath.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebHandler.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebItemState.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebManagedModule.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebRequest.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebURL.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebVirtualDirectory.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-Website.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebsiteState.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebAppPool.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebApplication.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebBinding.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebFtpSite.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebGlobalModule.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebHandler.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebManagedModule.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebVirtualDirectory.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-Website.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Remove-WebAppPool.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Remove-WebApplication.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Remove-WebBinding.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Remove-WebConfigurationBackup.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Remove-WebConfigurationLocation.md
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit b6a0ac5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/iisadministration/Get-IISAppPool.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Add-WebConfiguration.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Add-WebConfigurationLock.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Add-WebConfigurationProperty.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Backup-WebConfiguration.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Clear-WebCentralCertProvider.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Clear-WebConfiguration.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Clear-WebRequestTracingSetting.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Clear-WebRequestTracingSettings.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/ConvertTo-WebApplication.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Disable-WebCentralCertProvider.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Disable-WebGlobalModule.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Disable-WebRequestTracing.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Enable-WebCentralCertProvider.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Enable-WebGlobalModule.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Enable-WebRequestTracing.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebAppDomain.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebAppPoolState.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebApplication.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebBinding.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebCentralCertProvider.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebConfigFile.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebConfiguration.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebConfigurationBackup.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebConfigurationLocation.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebConfigurationLock.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebConfigurationProperty.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebFilePath.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebHandler.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebItemState.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebManagedModule.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebRequest.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebURL.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebVirtualDirectory.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-Website.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebsiteState.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebAppPool.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebApplication.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebBinding.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebFtpSite.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebGlobalModule.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebHandler.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebManagedModule.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebVirtualDirectory.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-Website.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Remove-WebAppPool.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Remove-WebApplication.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Remove-WebBinding.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Remove-WebConfigurationBackup.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Remove-WebConfigurationLocation.md
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

I checked the history of one of the files that you are changing the folder in your fork and it seems we would lose it

(Comparing this to other PRs, the whole history is included in the fork)
We would need to cross check with Kateyanne or the responsible person for this repo if is it acceptable to lose the file history in this case... was the last commit made with git mv?

@get-itips Yes, there is no history and I was not able to find a way to preserve it without re-commiting it... It was done with git mv. Based on my understanding git mv helps to recognize files as renamed instead of added and deleted but does not keep history. If it has been done before it would be nice to check and do it here as well. Could you share an example?
I remember when files where renamed from lower case to title case history was lost.

@get-itips Yes, there is no history and I was not able to find a way to preserve it without re-commiting it... It was done with git mv. Based on my understanding git mv helps to recognize files as renamed instead of added and deleted but does not keep history. If it has been done before it would be nice to check and do it here as well. Could you share an example?
I remember when files where renamed from lower case to title case history was lost.

Yes, I think we will lose history anyway. Should we move forward ? @dariomws @tseward

@velkovb TOC = Table of Content
For example:
https://github.com/velkovb/windows-powershell-docs/blob/fix-2046-module-name-typo/docset/docs-conceptual/windows/toc.yml
But I think there is no content to update here.
I think we are missing redirection here. If there are some articles in another repo with links to these articles they will fail with error 404. There is more detail in the document I shared, please let me know if you can open it.

@dariomws You are right, redirection must be put in place, will take a look at the doc

I have searched MicrosoftDocs organization for webadminstration and could not find any other reference.

@velkovb I have done a "rename" job some weeks ago and I have to (in summary):

Rename (using git mv)
Redirection
a. Create redirections in the .openpublishing.redirection.json file
b. Update links all-around Microsoft Docs (despite step a)

"Step a" will handle redirection for articles outside Docs, for example, techcommunity.microsoft.com, support.microsoft.com, and even non-Microsoft articles.

@dariomws Thanks for the info. I really do not understand what needs to be done in the .openpublishing.redirection.json
        {
        "source_path": "docset/virtual-directory-module/webadministration/webadministration.md",
        "redirect_url": "/powershell/module/webadministration",
        "redirect_document_id": false
        },

Should I duplicate this with the old incorrect name?

You can check an example here:
https://github.com/MicrosoftDocs/office-docs-powershell/blob/master/.openpublishing.redirection.json
On Exchange, I removed the folders. For example:

Removed organization folder:
"source_path": "exchange/virtual-folder/exchange/organization/Set-ExchangeAssistanceConfig.md",
"redirect_url": "https://docs.microsoft.com/powershell/module/exchange/set-exchangeassistanceconfig",
Removed policy-and-compliance folder:
"source_path": "exchange/virtual-folder/exchange/policy-and-compliance/Get-InformationBarrierPolicy.md",
"redirect_url": "https://docs.microsoft.com/powershell/module/exchange/get-informationbarrierpolicy",

Docs Build status updates of commit 8c04051:
:clock10: Pending: waiting for processors (6 builds ahead of you)
:warning: Docs Build is busy, currently there are 6 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

@dariomws
Thank you for the example. I added redirection based on the other information available there. Hopefully, this is the correct syntax.

Docs Build status updates of commit 8c04051:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docset/windows/iisadministration/Get-IISAppPool.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Add-WebConfiguration.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Add-WebConfigurationLock.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Add-WebConfigurationProperty.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Backup-WebConfiguration.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Clear-WebCentralCertProvider.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Clear-WebConfiguration.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Clear-WebRequestTracingSetting.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Clear-WebRequestTracingSettings.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/ConvertTo-WebApplication.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Disable-WebCentralCertProvider.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Disable-WebGlobalModule.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Disable-WebRequestTracing.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Enable-WebCentralCertProvider.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Enable-WebGlobalModule.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Enable-WebRequestTracing.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebAppDomain.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebAppPoolState.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebApplication.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebBinding.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebCentralCertProvider.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebConfigFile.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebConfiguration.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebConfigurationBackup.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebConfigurationLocation.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebConfigurationLock.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebConfigurationProperty.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebFilePath.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebHandler.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebItemState.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebManagedModule.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebRequest.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebURL.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebVirtualDirectory.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-Website.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Get-WebsiteState.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebAppPool.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebApplication.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebBinding.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebFtpSite.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebGlobalModule.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebHandler.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebManagedModule.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-WebVirtualDirectory.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/New-Website.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Remove-WebAppPool.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Remove-WebApplication.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Remove-WebBinding.md
:white_check_mark:Succeeded

docset/winserver2012-ps/webadministration/Remove-WebConfigurationBackup.md
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

@traya1 Can you help us verify whether the redirection configuration is the correct syntax? Please see the discussion for details. Thank you.

Just to help me out, what's the priority on this? I'm working on some pri 0 items right now.

@traya1 You may take your time in reviewing this. Thanks.

@traya1 Please let us know whether there is any progress on this. Thank you.

Hi guys, just like share with you that, this issue can be resolved without updating the file names after the PR "Replace legacy build pipeline with PowerShell SDP build pipeline" is ready and merged. Because the metadata Module Name in module's yaml header will be respected.
Here's the preview page: https://review.docs.microsoft.com/en-us/powershell/module/webadministration/add-webconfigurationlock?view=win10-ps&branch=sdp

Signing off as the PR #2078 has been merged.

Hi guys, just like share with you that, this issue can be resolved without updating the file names after the PR #2078 is merged. Because the metadata Module Name in module's yaml header will be respected.
Here's the preview page for that PR: https://review.docs.microsoft.com/en-us/powershell/module/webadministration/add-webconfigurationlock?view=win10-ps&branch=sdp

I can see that now the module name is displayed properly but the URL is still with the wrong name. Should we continue to actually fix the URL as well?

@dariomws @get-itips What do you guys think?

@velkovb I understand, based on the information that @qinezh provide us, that the decision must be taken by the product team.

Is there someone we should include here than? @e0i

Closing as the original issue has been solved. Thank you for the contributions as always.

Closing as the original issue has been solved. Thank you for the contributions as always.


Apache HTTPd sample configuration

Apache HTTPd sample configuration to proxify, Registry v1 in mirror mode, Registry v1 in hosting mode and Registry v2 in hosting mode

Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:hgomez/distribution.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

This will update the existing PR, so you do not need to open a new one.

@hgomez This looks like a good start!
Could you move this to a "contrib/apache" directory?

Sure, I'll update it

Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:hgomez/distribution.git somewhere
$ cd somewhere
$ git rebase -i HEAD~4
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

This will update the existing PR, so you do not need to open a new one.

Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:hgomez/distribution.git somewhere
$ cd somewhere
$ git rebase -i HEAD~5
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

This will update the existing PR, so you do not need to open a new one.

LGTM!

@hgomez while I'm checking this out can you squash and rebase? Checkout your branch and then:
http://docs.docker.com/project/create-pr/#rebase-your-branch

@hgomez To be consistent with what we have in contrib/compose, would you be willing to move the instructions into a README?
#
# Docker Registry 1.0 in Mirror mode : port 5001
# Docker Registry 1.0 in Hosting mode : port 5000
# Docker Registry 2.0 in Hosting mode : port 5002
#
# Registry v1 :
# docker run -d -e SETTINGS_FLAVOR=dev -v /var/lib/docker-registry/storage/hosting-v1:/tmp -p 5000:5000 registry:0.9.1"
#
# Mirror :
# docker run -d -e SETTINGS_FLAVOR=dev -e STANDALONE=false -e MIRROR_SOURCE=https://registry-1.docker.io -e MIRROR_SOURCE_INDEX=https://index.docker.io \
#               -e MIRROR_TAGS_CACHE_TTL=172800 -v /var/lib/docker-registry/storage/mirror:/tmp -p 5001:5000 registry:0.9.1"
#
# Registry v2 :
# docker run -d -e SETTINGS_FLAVOR=dev -v /var/lib/axway/docker-registry/storage/hosting2-v2:/tmp -p 5002:5000 registry:2.0"
#
# For Hosting mode :
#
# users should have account (valid-user) to be able to fetch images
# only users using account docker-deployer will be allowed to push images

Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:hgomez/distribution.git somewhere
$ cd somewhere
$ git rebase -i HEAD~6
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

This will update the existing PR, so DO NOT open a new one.

LGTM!

@hgomez Please address my comment above and we can get this merged.

LGTM ? What does it means ? Did there is something missing in README.MD ?

When header is set in /v2/ location, it don't work, authentication mecanism didn't works

@hgomez LGTM = "looks good to me". However, I deleted the comment after realizing the header was being included whether or not the endpoint was part of v2. If this is actually working, me may want to just go ahead with tit.

@hgomez After conferring with colleagues, we've identified the nature of the header and will add documentation clearly describing what it is for. With regards to this PR, the Apache configuration is correct.
More details here: https://github.com/docker/distribution/issues/99#issuecomment-96815035
LGTM!

As soon as header bug will be fixed on Docker/Registry side, we could safely remove it from httpd config


Allow to download media to subfolder under current folder, just like obsidian does

This way we can still keep all media organized, instead of having one folder under root with tons of files.

seconded

+1

+1

+1

Yea this would be really useful because otherwhise its usefulness is very limited for me.

+1

+1

+1

+1


java release notes for the 2021-11 release

This is an automated pull request to gather the java release notes for the 2021-11 release. See Producing Release Notes for details of the processing.

@vhvb1989, @weshaggard do we need to do something similar for C++?
I think we have to do something for Embedded C manually, doesn't look like the release notes page here is filled in atm, for the storage beta release:
https://azure.github.io/azure-sdk/releases/2021-11/c.html
FYI @antkmsft

@ahsonkhan looks like the C++ release notes were already merged see https://github.com/Azure/azure-sdk/pull/3566. As you mention you will need to manually create PR for C

@g2vinay are the java notes ready to merge? It looks like the last of set of Nov release notes left.


Bump nixpkgs

Bumped nixpkgs, and changed connection to crypton-connection since the former is deprecated. After this change, when I run stack ls dependencies in the nix shell I see that tls is bumped to 1.8.0.
Closes #142

Wait... we already had a PR which contains most of the fixes this will need that was just never released (#140). I'll fixup that instead.


MAINT: SCIPY_USE_PROPACK

this is effectively a forward port and modernization
of the release branch PROPACK shims that were added in 1.8.x (but not main)
gh-15432;
in short, PROPACK + Windows + some linalg backends
was causing all sorts of trouble, and this has never been resolved

I've switched to SCIPY_USE_PROPACK instead of USE_PROPACK
for the opt-in, since this was requested by @h-vetinari, though the change
between release branches may cause a little confusion (another
release note adjustment to add maybe)

I think the issues are painful to reproduce; for my part,
I did the following just to check the proper skipping/accounting
of tests:

SCIPY_USE_PROPACK=1 python dev.py -j 20 -t scipy/sparse/linalg

932 passed, 172 skipped, 8 xfailed in 115.57s (0:01:55)

python dev.py -j 20 -t scipy/sparse/linalg

787 passed, 317 skipped, 8 xfailed in 114.80s (0:01:54)

why am I doing this now? well, to be frank the process of manually
backporting this for each release is error-prone, and may cause
additional confusion/debate, which I'd like to avoid. Besides, if it
is broken in main we may as well have the shims there as well. I would
point out that you may want to add SCIPY_USE_PROPACK to 1 or 2 jobs
in CI? The other reason is that if usage of PROPACK spreads, I don't
want to be manually applying more skips/shims on each release (which
I already had to do here with two new tests it seems)

once finalized, I would plan to backport this to maintenance/1.9.x

I've switched to SCIPY_USE_PROPACK instead of USE_PROPACK for the opt-in, since this was requested by @h-vetinari, ...

Just to note that this was more of a question/suggestion than a request. :)

@mckib2 shall we add SCIPY_USE_PROPACK to at least one CI job then?

@mckib2 shall we add SCIPY_USE_PROPACK to at least one CI job then?

Yes!  If it's not already running in the GitHub Meson Linux and MacOS pipelines, that might be a good place for them.  Did you want a Windows build as well or will we poke that beast when those issues are fully ironed out?

Ok, I added SCIPY_USE_PROPACK=1 to meson testing in CI on all 3 platforms and fixed the linting issues. PROPACK was being used everywhere before so I see no reason not to test on all 3 platforms now--the real problem is when you swap linalg backends on conda-forge, etc. I think (and maybe with 32-bit Windows sometimes, based on wheels repo...).
If there are any other nitpicks feel free to push them right in. I see that the patch diff coverage may suggest that the meson jobs are not reporting coverage to codecov -- I have no comment on that other than pointing this out to reviewers who may be curious about the numbers there.

I see that the patch diff coverage may suggest that the meson jobs are not reporting coverage to codecov -- I have no comment on that other than pointing this out to reviewers who may be curious about the numbers there.

There's something off with gcov integration, see gh-15896. I'm aware of it, just not highest prio right now.


v22.4.1 cleanup (app|app_dev).php

Current coverage is 100% (diff: 100%)

Merging #600 into master will not change coverage

@@           master   #600   diff @@
====================================
  Files          29     29
  Lines         439    439
  Methods       111    111
  Messages        0      0
  Branches        0      0
====================================
  Hits          439    439
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last update 5cd4a81...88addda


Missing residues

Some residues at the beginning and at the end of the chains are missing in the mesh.
If you compare a cartoon mesh from pymol/VMD/avogadro... and the mesh created by ribbon.go, you can see that some parts are missing.
For example :
Beginning of the chain:

End of the chain

Good catch!
I pulled up the code and look what I found: https://github.com/fogleman/ribbon/blob/master/ribbon/ribbon.go#L286
I can look into it.
What are you doing with the code? I'm excited to see someone else using it!


SwiftPM support

          1 Warning

:warning:
Too many modifications. Please consider splitting the PR if possible.

          1 Message

:book:
Executed 26 tests, with 0 failures (0 unexpected) in 8.147 (8.174) seconds

Develop PR Check Result

Item
Result

Head Branch check
:o:

Base Branch check
:o:

Merge Commits check
:o:

Modification Volumn check
:heavy_exclamation_mark:

  Generated by :no_entry_sign: Danger


Add script to generate translated template to work on

This python script helps generate a translated template to work on to speed up the translation workflow. It generates a file $language.po.new that you can fix up and then rename to $language.po.
Edit the language variable in translator.py to change the language that it translates too. Using the https://huggingface.co/facebook/m2m100_418M model for translation from FaceBook so can't get rate limited for the translations.

Alright, this looks ok, let's merge this!


Build error

error[E0599]: no method named `vectorizes_over_list` found for struct `PluginSignature` in the current scope
  --> src/nu_plist.rs:20:14
   |
12 |           vec![PluginSignature::build("from plist")
   |  ______________-
13 | |             .usage("Parse text as an Apple plist document")
14 | |             .plugin_examples(vec![PluginExample {
15 | |                 example: "cat file.plist | from plist".to_string(),
...  |
19 | |             .category(Category::Experimental)
20 | |             .vectorizes_over_list(false)
   | |             -^^^^^^^^^^^^^^^^^^^^ method not found in `PluginSignature`
   | |_____________|
   |

A quick glance in the docs for PluginSigature shows no alternative to that option. Simply deleting it seems to work fine, but I'm not sure if that's the solution

This should be fixed now.


rasa 0.14.4 fails to start with Python 3.6

Rasa NLU version:
Operating system (windows, osx, ...):
Content of model configuration file:

Issue:

(rasa) D:\starter-pack-rasa-stack>python -m rasa_nlu.train -c nlu_config.yml --data data/nlu_data.md -o models --fixed_model_name nlu --project current --verbose
D:\Anaconda\envs\rasa\lib\site-packages\h5py_init_.py:36: FutureWarning: Conversion of the second argument of issubdtype from float to np.floating is deprecated. In future, it will be treated as np.float64 == np.dtype(float).type.
from ._conv import register_converters as _register_converters
2019-03-06 13:13:43 INFO     rasa_nlu.utils.spacy_utils  - Trying to load spacy model with name 'en'
Traceback (most recent call last):
File "D:\Anaconda\envs\rasa\lib\runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "D:\Anaconda\envs\rasa\lib\runpy.py", line 85, in _run_code
exec(code, run_globals)
File "D:\Anaconda\envs\rasa\lib\site-packages\rasa_nlu\train.py", line 184, in
num_threads=cmdline_args.num_threads)
File "D:\Anaconda\envs\rasa\lib\site-packages\rasa_nlu\train.py", line 148, in do_train
trainer = Trainer(cfg, component_builder)
File "D:\Anaconda\envs\rasa\lib\site-packages\rasa_nlu\model.py", line 155, in init
self.pipeline = self._build_pipeline(cfg, component_builder)
File "D:\Anaconda\envs\rasa\lib\site-packages\rasa_nlu\model.py", line 166, in build_pipeline
component_name, cfg)
File "D:\Anaconda\envs\rasa\lib\site-packages\rasa_nlu\components.py", line 441, in create_component
cfg)
File "D:\Anaconda\envs\rasa\lib\site-packages\rasa_nlu\registry.py", line 142, in create_component_by_name
return component_clz.create(config)
File "D:\Anaconda\envs\rasa\lib\site-packages\rasa_nlu\utils\spacy_utils.py", line 73, in create
nlp = spacy.load(spacy_model_name, parser=False)
File "D:\Anaconda\envs\rasa\lib\site-packages\spacy_init.py", line 21, in load
return util.load_model(name, **overrides)
File "D:\Anaconda\envs\rasa\lib\site-packages\spacy\util.py", line 119, in load_model
raise IOError(Errors.E050.format(name=name))
OSError: [E050] Can't find model 'en'. It doesn't seem to be a shortcut link, a Python package or a valid path to a data directory.
(rasa) D:\starter-pack-rasa-stack>python -c "import rasa_nlu; print(rasa_nlu.version);"
0.14.4

Hi @abroojalil, Rasa is trying to load your spacy model and failing to find it. I see you're using the starter pack -- did you install a spacy model using python -m spacy download en within your virtual environment as described in Setup and installation here? https://github.com/RasaHQ/starter-pack-rasa-stack

Requirement already satisfied: en_core_web_sm==2.0.0 from https://github.com/explosion/spacy-models/releases/download/en_core_web_sm-2.0.0/en_core_web_sm-2.0.0.tar.gz#egg=en_core_web_sm==2.0.0 in d:\anaconda\envs\py36\lib\site-packages (2.0.0)
You do not have sufficient privilege to perform this operation.
Linking successful
D:\Anaconda\envs\py36\lib\site-packages\en_core_web_sm -->
D:\Anaconda\envs\py36\lib\site-packages\spacy\data\en

You can now load the model via spacy.load('en')

yes, I did.

To me it looks like the spacy package is located in the py36 environment while you're trying to load it from within the rasa environment -- is this not the case?

To me it looks like the spacy package is located in the py36 environment while you're trying to load it from within the rasa environment -- is this not the case?

Actually, I created two different environments. both virtual environments are raising the same issue.

Hmm okay, I think you're running into the same security issue as this here: https://github.com/explosion/spaCy/issues/1283
I would read this thread and follow their suggestions -- i.e. try the security options thing first (giving symlink permissions to the relevant users) and if that doesn't work try I can try to help you to hack it using import like they've described instead. Unfortunately I'm not on windows so I can't reproduce the issue or test the fix, but let me know if that thread helps or if you're still stuck. Make sure to check out the links that user ines posted in the thread too :)


Name and Device reference number fields are missing in sharing device and also on requesting device

Describe the bug
Name and Device reference number fields are missing in sharing device
To Reproduce
Dvice A --> Requesting
Device B --> Sharing
Open qrcode in Device A
Open scanner in Device B
Scan the qrcode from Device B
connection is established, Now select VC to share screen appears.
Current behavior
Name and Device reference number fields are missing in sharing device , We see only requested by and reason for sharing fields.
Expected behavior
Sharing Device screen should contain Name and Device reference number field.
Screenshots

Smartphone (please complete the following information):
Device: android
MOSIP Version: 121
MOSIP server: qa-121.mosip.net
APK link : https://github.com/mosip/inji/actions/runs/3287270987
Additional information:
this same bug for IOS: https://github.com/mosip/inji/issues/225

@kyanthony were these fields removed intentionally? If yes, then we need to ensure that there is no information loss post this change.

@rakhimosip Yes, the fields were removed here. It was discussed before that it could be confusing to have multiple device identifiers on the screen.
The ones removed were:

Name - this was the user-configurable identifier from the settings page (e.g. Paolo's iPhone)
Device ID - from this function call: RNDeviceInfo.getDeviceId()

The one left:

Device Name - this uses the name that is set on the user's device typically found in the bluetooth settings

@Anushree09-N Please verify

verified this issue in qa5 env the app is working as expected, its projecting the bluetooth name of the device, hense closing this bug


Revert sprayproxy migration

There is an issue pushing images to quay actually
Error: POST https://quay.io/v2/redhat-appstudio/pull-request-builds/blobs/uploads/: UNAUTHORIZED: access to the requested resource is not authorized; map[]
main.go:74: error during command execution: POST https://quay.io/v2/redhat-appstudio/pull-request-builds/blobs/uploads/: UNAUTHORIZED: access to the requested resource is not authorized; map[]

We suspect the issue coming from https://github.com/redhat-appstudio/infra-deployments/pull/3435
We trying to revert https://github.com/redhat-appstudio/infra-deployments/pull/3435 here https://github.com/redhat-appstudio/infra-deployments/pull/3469
If the revert is merged we should also revert this

/test appstudio-e2e-tests-ocp-4-14

@enarha  I hink you are right, We may not need this, so initially i thought we need the new secret to pull images from quay.io/konflux-ci(new repo) but doesnt seem to be the case. I will close this one then


datepicker opens but is blank with build-optimizer (aot) enable

Bug, feature request, or proposal:
mat-datepicker fails to open and throws error when compiled with:
ng cli build --prod --build-optimizer
This appears in @angular/cdk / @angular/material version 6.3.3.  It was working in version 6.2.1.
What is the expected behavior?
Same behavior as without build-optimizer
What is the current behavior?
Doesn't open on click and immediately throws error with build-optimizer option:
ERROR Error: Unable to process animations due to the following failed trigger transitions
@transformPanel has failed due to:

query("@fadeInCalendar") returned zero elements. (Use query("@fadeInCalendar", { optional: true }) if you wish to allow this.

What are the steps to reproduce?
Compile ng cli project with angular material, add mat-datepicker, compile with:
ng build --prod --build-optimizer
What is the use-case or motivation for changing an existing behavior?
Needs to work with aot
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
ng 6.0.9
mat 6.3.3
Is there anything else we should know?

I tried to setup a project that does exactly what you described, but I was not able to reproduce that. Can you provide a demo that shows the issue?

I have the exact same error when build as Angular Elements.

Also just spotted the same issue. These are the Angular packages I'm using:
    "@angular/animations": "^6.0.7",
    "@angular/cdk": "github:angular/cdk-builds",
    "@angular/common": "^6.0.7",
    "@angular/compiler": "^6.0.7",
    "@angular/core": "^6.0.7",
    "@angular/forms": "^6.0.7",
    "@angular/http": "^6.0.7",
    "@angular/material": "github:angular/material2-builds",
    "@angular/platform-browser": "^6.0.7",
    "@angular/platform-browser-dynamic": "^6.0.7",
    "@angular/router": "^6.0.7",

So the error goes:
ERROR Error: Unable to process animations due to the following failed trigger transitions
 @transformPanel has failed due to:

- `query("@fadeInCalendar")` returned zero elements. (Use `query("@fadeInCalendar", { optional: true })` if you wish to allow this.)

    at t.reportError (main.7e30741973d319bd7c18.js:1)
    at t._flushAnimations (main.7e30741973d319bd7c18.js:1)
    at t.flush (main.7e30741973d319bd7c18.js:1)
    at e.t.flush (main.7e30741973d319bd7c18.js:1)
    at main.7e30741973d319bd7c18.js:1
    at e.invoke (polyfills.7a0e6866a34e280f48e7.js:1)
    at t.run (polyfills.7a0e6866a34e280f48e7.js:1)
    at t.runOutsideAngular (main.7e30741973d319bd7c18.js:1)
    at t.end (main.7e30741973d319bd7c18.js:1)
    at t.detectChanges (main.7e30741973d319bd7c18.js:1)

And when the datepicker is open, there is an error that is triggered continuously but disappears after I close the datepicker:
ERROR TypeError: p.ngDoCheck is not a function
    at main.7e30741973d319bd7c18.js:1
    at main.7e30741973d319bd7c18.js:1
    at Ko (main.7e30741973d319bd7c18.js:1)
    at _a (main.7e30741973d319bd7c18.js:1)
    at Object.updateDirectives (main.7e30741973d319bd7c18.js:1)
    at Object.updateDirectives (main.7e30741973d319bd7c18.js:1)
    at Go (main.7e30741973d319bd7c18.js:1)
    at na (main.7e30741973d319bd7c18.js:1)
    at ta (main.7e30741973d319bd7c18.js:1)
    at Go (main.7e30741973d319bd7c18.js:1)

The above is probably the validator failing? In any case, the issue is there, @DevVersion.

Thanks for the updates. I will have another look tomorrow.
Meanwhile, could someone share the template of the datepicker? (just to be sure)

Rolled back to 6.3.0 and everything is working correctly again (it's the only thing I changed). Using CLI 6.0.8.

I'm using latest cli and ng.  Versions of node 8.11.2 and npm 6.1.0.  I've tried to reproduce using a new simpler project and failed.
However, I found a fix that worked for me (I thought these days had passed):
rm -rf node_modules; npm i
Prior to doing this, I was getting these warnings when compiling with the build-optimizer:
WARNING in ./src/app/app.module.ngfactory.js
138:7344-7352 "export 'ɵd24' (imported as 'i68') was not found in '@angular/material/menu'
WARNING in ./src/app/app.component.ngfactory.js
143:1294-1302 "export 'ɵf24' (imported as 'i11') was not found in '@angular/material/menu'
WARNING in ./src/app/examples/todos/todos.component.ngfactory.js
151:341-349 "export 'ɵf24' (imported as 'i21') was not found in '@angular/material/menu'
WARNING in ./src/app/app.component.ngfactory.js
154:166-174 "export 'ɵf24' (imported as 'i11') was not found in '@angular/material/menu'
WARNING in ./src/app/examples/todos/todos.component.ngfactory.js
167:341-349 "export 'ɵf24' (imported as 'i21') was not found in '@angular/material/menu'
WARNING in ./src/app/app.component.ngfactory.js
170:166-174 "export 'ɵf24' (imported as 'i11') was not found in '@angular/material/menu'
WARNING in ./src/app/examples/todos/todos.component.ngfactory.js
183:341-349 "export 'ɵf24' (imported as 'i21') was not found in '@angular/material/menu'
WARNING in<EMAIL_ADDRESS>20:694-701 "export 'ɵd24' (imported as 'i1') was not found in '@angular/material/menu'
WARNING in<EMAIL_ADDRESS>49:191-198 "export 'ɵf24' (imported as 'i1') was not found in '@angular/material/menu'
WARNING in<EMAIL_ADDRESS>68:152-159 "export 'ɵf24' (imported as 'i1') was not found in '@angular/material/menu'
WARNING in ./src/app/examples/examples.module.ngfactory.js
85:2014-2022 "export 'ɵd24' (imported as 'i22') was not found in '@angular/material/menu'
`

My markup is the same as yours except for using formControlNames. Again, serving ng locally there's no issues, it's only when building w/ --build-optimizer.

That's clear. I constantly tried running ng build --prod --build-optimizer. I'm not sure how I can help with that issue if no one is able to reproduce it in a new app.
I will close the issue for now. This does not mean that I'm not listening to any updates here anymore. Just closing since there is apparently no reproduce-able issue (yet) .

A possible workaround:
Set buildOptimizer as false in angular.json. Output files are still the same size and the date picker works like a charm!
My config:
"@angular/cli": "~6.0.8"
"@angular/material": "^6.3.0"

Have the same issue after updating both @angular/material and @angular/cdk from 6.3.0 to 6.4.6 .
When I used "ng build --prod"
not only datepicker, the mat-tree combined with mat-tree also got error. Besides, the property [panelWidth] of mat-input not work either.
the error from mat-tree as below:
ERROR Error: Uncaught (in promise): TypeError: a.ngOnDestroy is not a function
TypeError: a.ngOnDestroy is not a function
    at Ua (main.a04e041dad630a65e567.js:1)
    at j (polyfills.99b05666391ec91781c2.js:1)
    at polyfills.99b05666391ec91781c2.js:1
    at e.invokeTask (polyfills.99b05666391ec91781c2.js:1)
    at Object.onInvokeTask (main.a04e041dad630a65e567.js:1)
    at e.invokeTask (polyfills.99b05666391ec91781c2.js:1)
    at t.runTask (polyfills.99b05666391ec91781c2.js:1)
    at d (polyfills.99b05666391ec91781c2.js:1)
    at t.invokeTask [as invoke] (polyfills.99b05666391ec91781c2.js:1)
    at _ (polyfills.99b05666391ec91781c2.js:1)

When using "ng build --prod --build-optimizer=false",
everything are working excellent!
@angular/cli : 6.0.8
@angular/cdk : 6.4.6
@angular/material : 6.4.6


Picker has been extracted from react-native core and will be removed in a future release. It can now be installed and imported from '@react-native-community/picker' instead of 'react-native'. See https://github.com/react-native-community/react-native-picker

This issue still persist if i used community picker.
# Bug report

Summary

Environment info

react-native info output:
# paste it here

Library version: x.x.x
Steps to reproduce

…
…

Describe what you expected to happen:

…
…

Reproducible sample code

I've you're using nativebase then it will be fixed when this PR goes out https://github.com/GeekyAnts/NativeBase/pull/3230

@vaibhav-navsoft There may be a file in your package that is using the Picker module from react-native (maybe NativeBase, as mentioned above.) please check which line the error is coming from.


multipath Route

Hi,
is there anyway i could implement two or more paths in Route component? e.g.
<Route path={['/u', '/user', '/profile/user']} />.
I see wouter supports path-to-regexp but i think array of path would be more easy to understand.
Cheers

+1
Or match multiple in useRoute(['path', 'path2'])

+1 nice idea!

Hey everyone, I put together a demo that demonstrates the multipath routing: https://codesandbox.io/s/wouter-demo-multipath-routes-42bi3?file=/index.js
The idea is that you can customize the function that will be used when a path is matched against the pattern.


feature_request(save_data): preventing all data loss

1. Summary
If user pressed Ctrl+Delete:
it would be nice if he didn’t irrevocably lose all record data.
2. Argumentation
Preventing unwanted data loss. It’s no good when the data on which the user worked for many minutes may disappear at once.
3. Steps to reproduce
ScreenToGif 2.27.3.
I made any recording → I made any actions in ScreenToGif editor → Ctrl+Delete (I wanted Ctrl+End, but missed the keyboard).
4. Behavior
4.1. Current
All data of my recording loss 😿. Ctrl+Z and Home → Undo have no effect. I need to record my apng again.
4.2. Example of desired
Dialog box with Yes and No buttons. Example text:

WARNING
Are you sure you want to delete all data of your recording? You can’t undo this action.

Thanks.

Hi @Kristinita.
There's already a confirmation dialog for that action (it defaults to No too, as a safeguard):

It's enabled by default, but it can be disabled:

Perhaps it was disabled, unless there is somehow, a way to bypass that.

Status: CONFIRMED :heavy_check_mark:
Yes, it solves the problem. Sorry for wasting your time.
I don’t remember ever changing anything in the Editor settings, so I didn’t even look there.
Thanks.


Unable to use any CDN for ESM

With recent split of the wasm file from the main module and recent module changes where UMD is preferred (a pretty defunct module kind on the Web as inherently incompatible with ESM) it's fairly impossible to use a CDN to run this project.
Assuming I use this end point:
https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>the import from @bjorn3/browser_wasi_shim breaks everything.
Assuming I use the CDN to deliver https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>I don't get the same export fields or the same logic actually present in the previous export.
unpkg breaks with ?module appended, esm.run fails, jsdelivr can't serve ESM.
Is there any plan to ship a proper ESM module or a different folder / dist structure that could benefit from these CDNs?
REaching the counter .wasm file is OK-ish, even if elsewhere, but the entry ESM point is basically unusable, thanks.

I think https://cdn.jsdelivr.net/npm/@ruby/wasm-wasi@next/dist/browser/+esm would work for you

The issue is that from that CDN I can't infer the WASM but we removed Ruby support in polyscript due too many issues in following progress around multiple CDNs where we had no luck in making any combination work.
Once there will be a single ESM target file beside its WASM counterpart we'll surely reconsider adding support for Ruby. Wasmoon, Pyodide and MicroPython, among PHP and even QuickJS don't have such issue with targeting the standard browser environment such as ESM.

I think you can use the following URL combination of ESM and Wasm:

https://cdn.jsdelivr.net/npm/@ruby/3.2-wasm-wasi@next/dist/browser/+esm
https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>

I will try again but last time I had no luck ... exported things where different ... I'll try to see if that combination works though, it's still awkward to infer, but if those end points won't change later on, we might be good.

@kateinoigakukun I can confirm that combination provides the expected exports and I will keep using that very same end point to also grab the related ruby.wasm counterpart, thank you.


Is project still active?

Hi @HelloKay27 !
I see that there haven't been updates on this repo since a long time; is it still used/relevant, or shall we archive it?
Thanks in advance!

After talking with the CatchIT team we have decided not to archive the project and to take action on the following:

CatchIT team to revise and update documentation/readme.
CatchIT team to contribute new features ~ Q3 2023.
CatchIT team to look at and compare CatchIT to GitHub's secret scanning alerts integration.
Start thinking about OSFF in November and the potential for a demo.
FINOS to gather health metrics around CatchIT.

Thanks again and feel free to add anything I may have missed.


iOS 17.1 crash when using UIDatePicker

We are using 4.3.4 version of SumUp SDK. After we updated to iOS 17.1 our application started crashing when you are trying to select time in UIDatePicker. Removing SumUp SDK fixes the issue. Apparently, it uses method swizzling which does something that crashes the app. Please fix it ASAP because until then our customers will not be able to use SumUp terminals - we are forced to remove it from our application because it crashes in places which are not even related to SumUp. I am attaching stack trace:
*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[__NSPlaceholderDictionary initWithObjects:forKeys:count:]: attempt to insert nil object from objects[0]'

This is happening to us too. Only when selecting a time, picking a date seems fine. Only on iPadOS 17.1.
Can this be addressed soon please.

This is happening on our app on all devices. Can you please fix this issue as soon as possible.

Hi @sleivysarnas, so far we have been unable to reproduce the issue.
Could you please verify if it is reproducible in the SumUpSDKSampleApp that comes together with the SumUpSDK and share the modified SumUpSDKSampleApp with us?

I have created a skeleton project that pulls in your cocoapod that causes the date picker to crash. It will only crash on a physical device running iOS17.1.
If I remove the pod, it does not crash. I have tested with all the pods our app uses, and unfortunately it's this pod that crashes it. A lot of customers are also raising this to our support.

Strangely, it does not crash on iOS 17.1 with physical device using SumUp sample app. Something must be different in project setup or something is conflicting with other libraries. Will update as soon as I figure this out. Any insights would be appreciated too.

Hi, we were able to reproduce the issue and currently working on a fix. We will come back to you with an update next week.

The same issue on all the devices on ios17.1 and  ios17.2
How to solve the problem?

Hi @annaafanasyeva-sumup,
Can you please advise when you are expecting a new release with the fix will be available?

Hi, thank you for your patience! We are currently preparing the new release and will make it available later this week.

The same issue on all the devices on ios17.1 and ios17.2 How to solve the problem?

the same issue me, if i remove the sumup library works

Same happening here.. can we have a URGENT fix?

any news about the new release?

Hi, please try version 4.4.0 which includes the fix for this issue! It is available under: https://github.com/sumup/sumup-ios-sdk/releases/tag/v4.4.0

works thanks ;)

I was hoping the minimum deployment would have stayed the same as this was a critical bug. We have a lot of customers on iOS 12 still.

i need version with last minimun deployment because many customer use it

wtf... why would you increase the min deployment target by 2 versions for a hotfix??
We have thousands of customers on iOS13..

Is there an estimated date for the fix with ios13 support?

We’re sorry for the inconvenience. We are working on SDK 4.3.5, a hotfix release that will fix this issue without changing the minimum deployment target.
It will take some more time for us to release this version based on an older version, as our internal codebase and tooling no longer support iOS 12 and 13.
We will provide a progress update on this later in the week.

Update on the 4.3.5 hotfix: we are finalizing testing and will release this early next week if all goes well.  For those with a minimum deployment target of 14 or higher, please consider upgrading to 4.4.0 to fix this issue.

Is there any updates to when to expect 4.3.5?

Hi, SDK 4.3.5 with iOS 12 & 13 minimum deployment target support is available under: https://github.com/sumup/sumup-ios-sdk/releases/tag/v4.3.5

Hi, SDK 4.3.5 with iOS 12 & 13 minimum deployment target support is available under: https://github.com/sumup/sumup-ios-sdk/releases/tag/v4.3.5.

@annaafanasyeva-sumup how did you manage to solve the issue? (same happens to us with a legacy project still compiled with Xcode 14 😢)

thanks, now works

@matteobianchi3 the problem was 2 category methods (tintColor, colorForStyle:) defined on UIColor; the 4.3.5 hotfix renames these to avoid collisions with same-named method(s) in iOS 17, while the 4.4.0 release completely removes them.

is it normal that after use sumapp payment and loggin inside the page, after some minute re-ask the login?

this has finally fixed this issue also


PipeCD Control Plane displayed unknown field error when config recreate for ECSApplication

What happened:
PipeCD Control Plane displayed an error message Failed to load application config: json: unknown field "recreate" when our ECSApplication was configured with "recreate: true" on quickSync.
https://pipecd.dev/docs-v0.47.x/user-guide/configuration-reference/#ecs-application
What you expected to happen:
recreate is an expected field, so the above error should not occur.
How to reproduce it:
Our ECSApp config
apiVersion: pipecd.dev/v1beta1
kind: ECSApp
spec:
  name: dev-myapp
  labels:
    env: dev
    layer: backend
  input:
    serviceDefinitionFile: servicedef.yaml
    taskDefinitionFile: taskdef.yaml
  attachment:
    sources:
      config: app-config.yaml
    targets:
      - taskdef.yaml
  description: |
    desc-myapp
  quickSync:
    recreate: true

Environment:

piped version:	v0.47.0
control-plane version:
Others:

@minhquang4334
Thank you for reporting.
I'm sorry but I could not reproduce the problem.
I used piped v0.47.0 and my app.pipecd.yaml was:
apiVersion: pipecd.dev/v1beta1
kind: ECSApp
spec:
  name: ecs-4909-recreate
  input:
    serviceDefinitionFile: servicedef.yaml
    taskDefinitionFile: taskdef.yaml
    targetGroups:
      primary:
        targetGroupArn: <MASKED>
        containerName: web
        containerPort: 80
  description: |
    desc-example
  quickSync:
    recreate: true

Would you please re-confirm your yaml's indents?
BTW, when I used the following wrong yaml, the same error occured.
spec:
  ...
  quickSync:
  recreate: true. # NOT INDENTED

@t-kikuc Thank you for investigating.
There are no invalid indents in our yaml file.
But when I use the same config with other apps, the error did not occur.
Additionally, I added a test to the pipeCD yaml parser, but it did not produce any problem.

@minhquang4334
I got it.
Then I close this issue.


🐞 Bug : Nav bar is not responsive in mobile version

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
In the mobile view the nav bar is not working properly it is not responsive . when we press the [X] button the nav bar is not getting closed

Steps To Reproduce

go to the web page in mobile
Now press the nav bar her you can see it will open but it i will not close
Here you can see the problem

Expected Behavior
when we press the [X] button the nav bar should disappear
Screenshots
No response
Device Information [optional]
- OS:
- Browser:
- version:

Additional context
No response
Are you working on this issue?
Yes

@salmoneatenbybear can you please assign me the issue so that i can raise the pullrequest

@Saipradyumnagoud this has been addressed and fixed in #5203.
@tachyons please could you close this issue if you get time

@salmoneatenbybear I think the issue did not solve yet please you can see once

@Saipradyumnagoud it has solved the bug the prod version is just not built again

@Saipradyumnagoud once we deploy the new changes it will be fixed

okay @salmoneatenbybear


Adding the GINO model

This PR adds a GINO model that can map between functions defined on arbitrary coordinate meshes.
It also contains a bug fix (oops) for the naive CPU-runner-only implementation of segment_csr that uses einsum for an added speed bonus.

Excellent, thanks @dhpitt! Can we add a small test case for the bug you fixed? I'll merge this so others can start using GINO!


Add Vim Motions Support to TurboRepo UI Input Handling

Summary:
This PR introduces support for basic Vim-style key bindings within the tui component of TurboRepo, specifically for pane navigation. The goal is to improve navigation efficiency for users familiar with Vim-like key motions.
Key Changes:

Added support for h, j, k, and l Vim keybinds for interactive mode:

Ctrl+h: Exit interactive mode.
Ctrl+j: Move down.
Ctrl+k: Move up.
Ctrl+l: Enter interactive mode.

General Vim-style motions:

j: Move down.
k: Move up.
l: Enter interactive mode.

Motivation:
Adding these motions provides a more intuitive interface for users familiar with Vim commands, enhancing navigation within the pane section of the TurboRepo UI.
Related discussion

Don't really know why the workflows are failing. I updated my branch, waiting for approval : )

hey just to keep you in the loop, I was reviewing this just now and we're gonna talk about it at our next team meeting and get back to you: there are some future plans for some of these keys (beyond just j and k) and we need to make sure we don't disrupt those plans.

Hey, @AlvaroParker! Just wanted to see if you're interested in finishing this one up. If not, we can remove the unwanted functionality on your behalf.
Thanks, excited for this!

Hey @anthonyshew, sorry for not making the changes earlier—it’s been a busy couple of weeks. I’ve committed the changes to just use j and k. Let me know if I missed anything!

Allow CI Workflow Run

[ ] approve CI run for commit: f7b8a0bc78ca126018ab5536fb7beb45cc6a53d4

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer


arch: common: Fix up_check_tcbstack() for CONFIG_ARCH_ADDRENV=y

Summary

I noticed that ps shows incorrect stack usage when running
getprime in the background.
With CONFIG_ARCH_ADDRENV=y, a user task including pthread
allocates its stack in the user space that needs to be
accessed with a correct address environment.
This commit fixes this issue.

Impact

CONFIG_ARCH_ADDRENV=y only

Testing

Tested with sabre-6quad:knsh on qemu-6.2

riscv should have the same problem too, could you fix it too?

riscv should have the same problem too, could you fix it too?

@xiaoxiang781216
Yes, I tried to fix it locally but I encountered another issue.
I think the issue depends on RISC-V only but I need to investigate it later.


chore: update rector from 0.19.8 to 1.0.0

Description
update rector from 0.19.8 to 1.0.0
Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[ ] Conforms to style guide

Thank you @datamweb


When using a single navbar for all applications, repeated navigations within a single app fail

This occurs when you have a single navbar app that controls navigation between multiple applications, including their subroutes.
The first navigation to any app or app subroute completes successfully. Any subsequent navigation inside that same app will fail. For example:
/app1 -> /app2 -> /app1 will succeed.
/app1 -> /app1/subroute will fail to load the subroute.
/app1 -> /app2 -> /app1/subroute will succeed.
In other words, navigation switching between apps works fine, but subsequent navigations within a single app (from routes on the navbar) will fail until you first navigate outside of the app.

I am able to navigate within app but it logs exception when navigate between multiple applications:
core.js:15724 ERROR Error: Expected to not be in Angular Zone, but it is!
at<EMAIL_ADDRESS>(core.js:17197)
at Object.next (core.js:17403)
at SafeSubscriber.schedulerFn [as _next] (core.js:13515)
at SafeSubscriber../node_modules/rxjs/_esm5/internal/Subscriber.js.SafeSubscriber.__tryOrUnsub (Subscriber.js:196)
at SafeSubscriber../node_modules/rxjs/_esm5/internal/Subscriber.js.SafeSubscriber.next (Subscriber.js:134)
at Subscriber../node_modules/rxjs/_esm5/internal/Subscriber.js.Subscriber._next (Subscriber.js:77)
at Subscriber../node_modules/rxjs/_esm5/internal/Subscriber.js.Subscriber.next (Subscriber.js:54)
at EventEmitter../node_modules/rxjs/_esm5/internal/Subject.js.Subject.next (Subject.js:47)
at<EMAIL_ADDRESS>(core.js:13499)
at core.js:17274
StephenRansom: kindly share sample of your main.ts and route files. it seem an issue with our configuration.

@HemendPatel63 Are you using the most recent beta (12 at this time), and are you doing all of your navigation from a single navbar app? If I have a navbar that only contains links to each app root, and each subapp does it's own routing (from a self contained navbar), I don't encounter issues. It's only when I do all routing from the separate navbar app that I encounter this issue. I'll post a sample when I get a chance though.  (for reference, https://github.com/StephenRansom/single-spa-beta-tabbed-app-navigation works fine)

I made a copy of joel's example app and added subroutes to demonstrate what I'm seeing. (you can also just ng g component subroute in one of your applications to quickly test it yourself, just don't forget to add the routes in).  Click around between the app1 subroutes, then try clicking between app1 -> app2 -> app1/subroute -> app2 etc  https://github.com/StephenRansom/single-spa-routing-issue-example

Yeah beta.12 should solve the "Expected to not be in Angular Zone, but it is!" issue. I'll take a look at that example repo for the issue described for subroutes.

@StephenRansom - How do you maintain the state between application?


Deleting files does not remove them from disk

Calling the deleteImage method does not delete files from disk. At the moment, the model is assigning $existingRow->value = null and that's it. It seems to me that it is worth adding the deletion of a file from the disk, at least to give such an opportunity by determining the config.
https://github.com/outl1ne/nova-settings/blob/3bc1dd6f714bfe31d0ff3baac6805d9387a343b6/src/Http/Controllers/SettingsController.php#L117

Thanks for reporting this! Fixed in version 5.0.3. ;)

This actually does not work whenever you group the fields into Panels, e.g.:
Panel::make(__('CompanyInformation'), [
    Image::make(__('Logo'), 'company_logo')->prunable(),
]),

Because of SettingsController:118:
$field = collect(NovaSettings::getFields($pathName))->firstWhere('attribute', $fieldName);

firstWhere is actually looking in the panels array, not the fields array inside the panel.

@holyboly Fixed by @marttinnotta in version 5.1.0.


When putting Network.host in Config it Doesn't Show up in Elasticsearch.yml

What am I doing wrong? I added network.host in the config but when running puppet on the client machine the network.host is not in the elasticsearch.yml
class { 'elasticsearch':
version => '2.2.0-1',
}
elasticsearch::es01":
config => {
'http.cors.allow-origin'                  => '/.*/',
'http.cors.enabled'                       => 'true',
'http.cors.allow-credentials'             => 'true',
'network.host'                            => 'myHost',
'discovery.zen.ping.multicast.enabled'    => 'false'
}
}

Hi @cpitzak, could you re-open this question on the Elasticsearch Discourse forums? We can open an issue if we happen to find an actual bug in the module.
On the topic you create, could you also include the configuration files puppet creates in addition to your puppet manifest? You can tag me directly on the topic under the same handle (@tylerjl) to pull me into the new topic.
Thanks!

Thanks for the quick response.
I resolved the issue I was having. It was on my side, the elasticsearch puppet module had no problems. My puppet master was failing and falling back on a cache copy of the last known working version of the manifest. I fixed the error and also ran with no caching on fail.
Thanks.


WIP: Match muted behavior with JS SDK

lol, just saw the WIP.. oops. I probably jumped the gun when reviewing. converted this to a draft PR

Oh this is still WIP haha will continue later today 😅

I will test it 🙂


Add Edges().to(_:) - Enables to attach the edge of the view to another view or LayoutGuide.

PR adds methods to enable to attach edges of view to other layout-guide or view.
Motivation
I often write the following code in order to attach the edges of the view to UILayoutGuide.
This code is a bit verbosity, and we could have a shorthand if we could add a method to Edges.
Before:
 myOverlayView.easy.layout([
    Top().to(overlayViewLayoutGuide, .top),
    Left().to(overlayViewLayoutGuide, .left),
    Right().to(overlayViewLayoutGuide, .right),
    Bottom().to(overlayViewLayoutGuide, .bottom),
  ])

After:
 myOverlayView.easy.layout(
   Edges().to(overlayViewLayoutGuide)
 )

I've become a collaborator by @nakiostudio. Thanks.
I merge this PR.
And I'm going to continue enhancing this library.

I've become a collaborator by @nakiostudio. Thanks.
I merge this PR.
And I'm going to continue enhancing this library.


[release/v2.7] Add post and pre upgrade resource validation tests

[x] This PR relies on  #38404 and #38171 and requires a rebase after these are reviewed and merged.
[x] This PR relies on #39341. And requires updates for workloads according to the changes.

Extensions Updates

Implemented:

A function to access an ingress externally to extensions/ingresses/ingresses.go

Validation Tests

Implemented:

Post-upgrade and pre-upgrade resource validation cases
Private wait healthy response helper built on top of the access an ingresses helper
Private wait ingress hostname update helper built on top of the wait package
Private string prefix helpers to get an item and check an item in a slice of strings
Private name constructor to generate random suffixes with given names

Updated the v1 steve client changes, ready to review.
Additionally, moved templates from Kube API extensions to rancher extensions, and added logging chart CRD uninstall.

Backport: #39570


Extend service resource to support systemd user services

systemd support the concept of user services (https://wiki.archlinux.org/index.php/Systemd/User), which are like system services, but are run and supervised within a user session.
This patch adds support for managing user services within the service resource, e.g. by doing
service 'foo' do
  user 'bar'
  action [:enable, :start]
end

the  service foo will be enabled and started whenever the user baz logs in.
I'm a Facebook employee and @jaymzh will do the final merge.

I am really not comfortable with adding so much to the core service resource that is entirely specific to systemd. This is not even remotely generic, you should be using a systemd_service resource.

@coderanger: from the discussion in #4307 with @lamont-granquist, my understanding is that we do not want to make the service resource resolve to anything other than Chef::Resource::Service for now. Given that, how do you propose we do this? Yes, the implementation of this is systemd specific, but user services are services and are modeled well by the existing service resource. While we could make a completely separate systemd_service resource and provider, that would end up duplicating a lot of code and logic from service; it does not feel the right solution to me and it will end up being harder to maintain in the future.

You should make something that subclasses Chef::Resource::Service and provides(:systemd_service) in my opinion. This should be separate from service in both resource and provider give how much it is deviating from the model of service.

But to be clear, this is not an instruction to change the code, just my view as one maintainer :)

Right, the issue is that I view that as the lesser of two evils.  We can either:

break the validation model and the service resource will allow systemd-specific actions to hit non-sytemd providers

break the lazy provider resolver mechanism so that if you have a system running systemd you will only (ever) be able to manage systemd service resources

I really don't like the second breakage at all and feel its more potentially 'crippling' breakage that ties our hands in the future -- while the first breakage only affects people who try to use non-systemd resources like systemd resources, which should be an edge condition, and the effect is they get an uglier error message or we have to inject some defensive programming into the service provider base class to fix up the error messages.

paging @thommay

If you know you are using systemd-specific features, I don't see why it's a problem that they only work with systemd.

To be clear, I'm not talking about remapping service, I'm saying this should be it's own resource a la package and deb_package/rpm_package.

so the prior code in the PR was implemented that way but it remapped service "foo" to systemd_service "foo" in the DSL and hardwired all services to be systemd services

I would say in the realm of choosing between two evils, we should (a) be consistent and (b) pick the one that provides more flexibility in the short term. So, for now, lets keep this the way we did #4307 which is consistent and provides more flexibility even though it bloats the service resource a bit, and then we can revisit the resolution code if we want to be able to abstract that out later.

If we do that, we should figure out a way to at least warn, preferably error, if this property is set for any other provider. With actions that is relatively easy, but currently this would be silently ignored for other providers.

@coderanger yeah adding checks is a good idea. Ideally we'd do  that in lib/chef/provider/service.rb so it doesn't have to be reimplemented in every other provider, but I'm not sure how to do that.

consistency is definitely king here. I'm :+1: on this approach

:+1:

@jaymzh feel free to merge :)

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
GitHub Users Who Are Not Authorized To Contribute
The following GitHub users do not appear to have signed a CLA:

@davide125

Please sign the CLA here.


[3.60 beta 16] iOS has no audio

Version

Phaser Version: Phaser 3.60 Beta 16

Operating system: iPhone 11

Browser: Safari, latest

Description
iOS does not have any sound, using all default environment (WebAudio?).
Example Test Code
        this.load.audio('jack',  'assets/audio/jack.wav');         this.jackPlayer = this.sound.add('jack');         this.jackPlayer .play();

Sure it does. Here is a video of an iPhone 14 with iOS16 running 3.60 Beta 16 from the Labs demos (https://labs.phaser.io). Audio on to hear it working in the video:
https://user-images.githubusercontent.com/164476/206224624-d9ce8492-80dd-412b-8c93-6a5ad7565146.mp4
Make sure you're using file formats iOS can actually play. Make sure the phone isn't set to 'silent mode' and make sure you tap/click the screen, playback will not start until you do.

Here's a video of an iPhone 11 (real device, not emulated) playing audio:
https://user-images.githubusercontent.com/164476/206314289-87b2d9fa-6d5a-4a44-8aa6-8f8c80e2494f.mp4


Stop sorting attributes

When I do:
link[rel=import][href=../foo/bar.html]

It expands to
<link href="../foo/bar.html" rel="import">

While that's normally fine, it would be great if sparkup kept the order of the attributes as they are written instead of sorting them. Looking at the Python code, it's not immediately obvious where the order of attributes would be controlled though.
Maybe have an option that would respect the attribute order?

Without deeper knowledge, I can only take a guess: The attributes are stored in a dictionary, and dictionaries in python are unordered. So when you get the attributes back out, it will always give them in alphabetical order.
You could try opening sparkup.py and change the line
self.attributes = {}

into
self.attributes = OrderedDict()

with
from collections import OrderedDict

at the top of the file.
That might help with populating the object, but I don't see where that attributes dictionary is being consumed.


Semantic highlighting protocol extension

Note: The description was copied as is from https://github.com/Microsoft/vscode-languageserver-node/issues/368#issue-336150366

I have started to work on a semantic highlighting extension of the LSP.
The semantic highlighting information is pushed from the server to the client as a notification. This notification contains the lines and the ranges where the coloring has the be applied and the desired coloring details are given as TextMate scopes.
In the reference implementation of the client, I was trying to map the TextMate scopes into the appropriate theme I can use as a decoration in the TextEditor decoration. How can one map the TextMate scopes into themes (and eventually TextEditorDecorationType) with the current VS Code API?
Any suggestions and feedback are welcome. Thanks!
Related issues:

Support semantic highlighting (Microsoft/language-server-protocol)
Proposal for (Semantic) Coloring (see #18) (Microsoft/language-server-protocol)
Provide an API for advanced/semantic source highlighting (Microsoft/vscode)
Add support for lexical syntax coloring (Microsoft/language-server-protocol)

The corresponding PR with the proposed changes is here: https://github.com/Microsoft/vscode-languageserver-node/pull/367

@kittaakos Just to make sure I understand what's going on, would you mind showing the JSON notification of a) opening a new file and b) making a change to one line? Let's just say the URI of the file is lsp:/folder/file.ts.
A: User opens the following TypeScript file in a LSP client.
export class Sample {
    protected test = 0;
}

B: User changes 0 to "value" on the second line.
export class Sample {
    protected test = "value";
}

Great idea, it's always bugged me that different editors have different syntax highlighting semantics.

This would be great!


[Tip Bot V2] Make Tip Bot Asynchronous

There are a bunch of ideas that we can do to take the tip bot to the next level:

Allow users to submit their associated address ahead of time, either through some local DB or maybe just easier to maintain a JSON file which people can submit PRs to.
Automatically pick the size of the tip based on the "Size of issue" tag on the PR
Introduce new tag "tip" which allows the tip bot to execute on that PR
Allow anyone (mainly the contributor) to trigger a tip one time, given the appropriate tags, the bot will execute
Maybe a new tag "tip-paid" used to signal that the tip was paid.

This will improve the process for getting tips for good PRs. We can passively add this tag, and the users can themselves trigger the tip bot, rather than waiting for us to do it.
The only issue might be that we may not want to allow ANYONE to add a tip tag to the PR. Is it possible to limit certain kinds of tags?

@shawntabrizi
as I understood, the main motivations behind the ideas are

reduce the time that you spend on guidance for contributor how to get a tip (so you don't explain each time how/where to add address etc)
remove merge dependency on core team so the contributors can asynchronously be tipped if allowed earlier
make sure the bot automatically tips once and no more with the size defined in "Size of issue" tag

Did i miss any other motivation?
If no - few questions:

what's reason you want bot to add a new tag 'tip-paid'? is it supposed to prevent new tip or you might wanna use it when you filtering or reviewing the tipped issues through the time?
could you help me learn what are the tags which defined the "size of the issue" ?

Thanks

Allow users to submit their associated address ahead of time, either through some local DB or maybe just easier to maintain a JSON file which people can submit PRs to.

If I understand you right here:

User can add DOT: 123...ff to their github profile

Fetch this via the github api

@shawntabrizi . your issue-text mentions tag, you mean a label, like https://github.com/paritytech/substrate-tip-bot/labels/bug

tip-paid tag allows us to track the PRs which are earning tips. Great for metrics, community building, and also can help prevent the same PR from getting multiple tips. Or imagine that someone requests a tip, but somehow they are tipped via a bounty or some other program. That can also signal that a treasury tip is not needed.
For tags, you would introduce tip-small through tip-large tags, which can be added to a PR by appropriate owners, and can allow the tip bot process to happen without need of further involvement of users.

thanks @shawntabrizi
After I read last comment from @bkchr here https://github.com/paritytech/substrate-tip-bot/issues/41#issuecomment-1466249544

This is the reason we give tips in retro perspective

I got an impression that a proposed improvement is contradicting with this reasoning. Isn't it?

Inclusion of the tag can happen at any point in the PR, and payout only happens after the PR is merged.
The main point with making things async is that someone who is reviewing the PR for a tip can simply add some tags, and then they are not involved anymore for making the payout happen when it should happen.
For example, i see a PR, it's 98% done. I gave my final review, there are some small nit picks, but i approve the PR.
I can also at that time, put the tip tags, and then when it gets merged (after fixed and another review) then the PR owner can trigger the tip process themselves.

I asked in tip-bot room and this proposal didn't get any support, so doesn't look like this is something needed


Error: connect ETIMEDOUT <IP_ADDRESS>:8060

I usually leave this server running for development and once in a while, specially every morning when resuming my laptop to keep working, I get this ETIMEDOUT error. I'm using version 0.8.5. Any clues about it?
/usr/local/lib/node_modules/http-server/node_modules/http-proxy/lib/http-proxy/index.js:119
    throw err;
    ^

Error: connect ETIMEDOUT <IP_ADDRESS>:8060
    at Object.exports._errnoException (util.js:837:11)
    at exports._exceptionWithHostPort (util.js:860:20)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1060:14)

This could be happening if a request is made to the server just before the laptop sleeps/hibernates/whatever, and so the response is never sent? Do you still see this issue on the latest version of http-server?

I don't know about this anymore since I'm using http-proxy now.


Fix a race condition in SetPartitioner when party changes during handling of lock acquisition

This pull request is made on top of #271. I've noticed that there is a race condition due to which we might get a deadlock or invalid partition result.
In https://github.com/KonishchevDmitry/kazoo/commit/808aa9207e0788542b8af7bf5e347904644a172e I've wrote two tests for race conditions that current version of SetPartitioner doesn't pass and than fixed the error in https://github.com/KonishchevDmitry/kazoo/commit/7fb411b92a317c5edd0225aab6f3a24e5516b969.

The failed tests seems to be not my fault.

Kicked a new build off.

r+, this looks good to me pending the test.


Make examples folders self-contained by including necessary setup files

Working towards #61

This change is

Is this PR fully finished?  My recollection from the last Kitware/TRI sync meeting was that it was known to be incomplete and is still being reworked.  Let me know whether I should start my review.

Hearing nothing, I'll de-assign myself in order to clean up my reviews dashboard.  Feel free to re-add me once it's ready.


Cluster whole Collections instead of just one Movie

For example by average color
Idea: User can click on a color (belongs to a shotid) -> shotid gets used for query by example -> We show the list of shots which are similar (disable motion & edge features for that query ideally).
On the Backend Side: Return A list of Shots and their AvgColors -> Ideally, those shots are far apart in our color-space.
On the Frontend Side: Visualize a list of shots (not necessarily in the same movie) in a D3-Graph
The clicking -> Query-by-example thing is on the wishlist

Ideally we do this with a d3.js graph

We will maybe try to do this with one sunburst graph as a proof-of-concept. It looks like the overhead for visualizing without heavily modifying d3.js

Sein showed a proof-of-concept at the final presentations


more usable api/library - option to repeat until success

Example of max repeat reached without success: (status=503:50 means return 50% of 503s)
$ go run . -expected 200 -repeat 1 -repeat-delay 1s localhost:8080/?status=503:50
18:28:42 I Fortio multicurl dev  go1.19.5 arm64 darwin, using resolver ip, GET localhost:8080/?status=503:50
18:28:42 I Resolved ip localhost:8080 to port 8080 and 2 addresses [::1 <IP_ADDRESS>]
18:28:42 I 1: Status 200 "200 OK" from ::1
18:28:42 E 2: Status 503 "503 Service Unavailable" from <IP_ADDRESS>
18:28:42 E [1] 1 error (0 warnings)
18:28:43 E 1: Status 503 "503 Service Unavailable" from ::1
18:28:43 E 2: Status 503 "503 Service Unavailable" from <IP_ADDRESS>
18:28:43 E [2] 2 errors (0 warnings)
18:28:43 E Reached max repeat 1
18:28:43 I Total iterations: 2, errors: 3, warnings 0
exit status 2

With eventual success
$ go run . -expected 200 -repeat -1 -repeat-delay 1s localhost:8080/?status=503:50
18:30:40 I Fortio multicurl dev  go1.19.5 arm64 darwin, using resolver ip, GET localhost:8080/?status=503:50
18:30:40 I Resolved ip localhost:8080 to port 8080 and 2 addresses [::1 <IP_ADDRESS>]
18:30:40 I 1: Status 200 "200 OK" from ::1
18:30:40 E 2: Status 503 "503 Service Unavailable" from <IP_ADDRESS>
18:30:40 E [1] 1 error (0 warnings)
18:30:41 E 1: Status 503 "503 Service Unavailable" from ::1
18:30:41 E 2: Status 503 "503 Service Unavailable" from <IP_ADDRESS>
18:30:41 E [2] 2 errors (0 warnings)
18:30:42 E 1: Status 503 "503 Service Unavailable" from ::1
18:30:42 E 2: Status 503 "503 Service Unavailable" from <IP_ADDRESS>
18:30:42 E [3] 2 errors (0 warnings)
18:30:43 I 1: Status 200 "200 OK" from ::1
18:30:43 E 2: Status 503 "503 Service Unavailable" from <IP_ADDRESS>
18:30:43 E [4] 1 error (0 warnings)
18:30:44 E 1: Status 503 "503 Service Unavailable" from ::1
18:30:44 I 2: Status 200 "200 OK" from <IP_ADDRESS>
18:30:44 E [5] 1 error (0 warnings)
18:30:45 I 1: Status 200 "200 OK" from ::1
18:30:45 I 2: Status 200 "200 OK" from <IP_ADDRESS>
18:30:45 E [6] 0 errors (0 warnings)
18:30:45 I Total iterations: 6, errors: 7, warnings 0

With timeout before success
$ go run . -expected 200 -repeat -1 -repeat-delay 1s -total-timeout 5s localhost:8080/?status=503
18:31:27 I Fortio multicurl dev  go1.19.5 arm64 darwin, using resolver ip, GET localhost:8080/?status=503
18:31:27 I Resolved ip localhost:8080 to port 8080 and 2 addresses [::1 <IP_ADDRESS>]
18:31:27 E 1: Status 503 "503 Service Unavailable" from ::1
18:31:27 E 2: Status 503 "503 Service Unavailable" from <IP_ADDRESS>
18:31:27 E [1] 2 errors (0 warnings)
18:31:28 E 1: Status 503 "503 Service Unavailable" from ::1
18:31:28 E 2: Status 503 "503 Service Unavailable" from <IP_ADDRESS>
18:31:28 E [2] 2 errors (0 warnings)
18:31:29 E 1: Status 503 "503 Service Unavailable" from ::1
18:31:29 E 2: Status 503 "503 Service Unavailable" from <IP_ADDRESS>
18:31:29 E [3] 2 errors (0 warnings)
18:31:30 E 1: Status 503 "503 Service Unavailable" from ::1
18:31:30 E 2: Status 503 "503 Service Unavailable" from <IP_ADDRESS>
18:31:30 E [4] 2 errors (0 warnings)
18:31:31 E 1: Status 503 "503 Service Unavailable" from ::1
18:31:31 E 2: Status 503 "503 Service Unavailable" from <IP_ADDRESS>
18:31:31 E [5] 2 errors (0 warnings)
18:31:32 E Interrupted/total timeout reached
18:31:32 I Total iterations: 5, errors: 10, warnings 0
exit status 2

(will add tests in a bit)


unknown http.Transport field 'TLSNextProto'

When I want to upgrade of lego from 0.3.0 to 0.3.1 or do a clean install with:
go get -u github.com/xenolf/lego
I get the following error message:
# github.com/JamesClonk/vultr/lib
lego/src/github.com/JamesClonk/vultr/lib/client.go:80: unknown http.Transport field 'TLSNextProto' in struct literal

This is on OpenBSD 5.9.
Is there anything that I need to add?

You need Go 1.6 or higher now. Time to upgrade! :+1:

Thanx!


[RoleManagement] Consider Button use

Side note: Maybe spin up a secondary bot to demo stateless reaction menus built on base32768 encoding a protobuf of role rules into the custom_id field

Can't go stateless with this right now, discord does nothing preventing spoofing interactions.