Create .NET docs What's new section

Contributes to #16189
First pass automation for "What's new" page.
It turned out that automating it (in part) took less time than putting it together by hand.
I'd like everyone I tagged to review this. I already recognized a few false positives in the "what's new" article, and at least one MS employee in the contributor list.
False positives: Some articles had significant formatting changes, but aren't really new. Some others had large amount of changes, but really aren't noteworthy.
I'll merge this after approval, and merging #16248. I'll add a "highlight" for the What's new page.

What's new landing page internal review link.
What's new in November2019

Open question:
Because the individual monthly pages are automated, should I add pages for October and September to pick up the updates for the .NET Core 3.0 launch?

Love it @BillWagner! Left a few comments for you to consider.

Updated status of this PR
I made numerous programming changes this morning based on the feedback. (See the last commit message). I like the automated parts quite well. Some notes for us as a team:

I'm using the PR title for the "description of the changes". That's OK, and I think it can be a bit better if we think about the "What's new" page when we write PR titles going forward.

I tried an experiment using the PR body, but that had too much text in most cases, including the internal review link, related issue, and quite a bit of markdown formatting. It really looked bad.

I'm using membership it either the "Microsoft" org or the "Microsoft Docs" org to filter MS employees from the contributor list. As Maira points out, that's not perfect: It doesn't filter out Ron, as he's retired. It doesn't filter out vendors, and it misses a few FTEs that haven't joined those orgs. There are three solutions. They all have tradeoffs. What do others think?

I could hard code known GitHub Ids.
We edit these by hand each month.
We define a team that I can filter on in addition to the org membership.

The biggest question for the team and @MaximRouiller: Is this "close" to the right set of important content? Should I set the changed threshold higher (fewer articles), or lower (more articles)?

Agreed on using PR title and that it'll improve as we give more thought to where it's going to show up when we write the titles.
I vote for hard-coding the GitHub IDs.
I vote for setting the threshold higher.  IF there are significant changes we want to call out that don't make the cut in the automated page creation, we can add them manually.

I vote for setting the threshold higher. IF there are significant changes we want to call out that don't make the cut in the automated page creation, we can add them manually.

Check the three latest commits. I set the change threshold at 50, 75, and 100 (from the initial 25). Which do you like best?

There are three solutions. They all have tradeoffs. What do others think?

I could hard code known GitHub Ids.
We edit these by hand each month.
We define a team that I can filter on in addition to the org membership.

1 would mean a list we have to maintain. 2 would be easy to remove as most employees are in the org and we could train those who aren't to join. 3, I don't quite understand.

The biggest question for the team and @MaximRouiller: Is this "close" to the right set of important content? Should I set the changed threshold higher (fewer articles), or lower (more articles)?

Reviewing this in a few more minutes. Going through the backlog.

@MaximRouiller

Reviewing this in a few more minutes. Going through the backlog.

The last four commits show different modification thresholds: 25, 50, 75, 100. That should make it easier to compare.

100 is extremely aggressive. 75 is very aggressive, and 50 sounds about right.
New articles being removed, is it a bug? If it's new, it should include them whether there is 2 lines or 150 lines. For example, I kind of like 75 but it removes good articles from F# and .NET.
On a side note, we should that number as "movable" throughout this experiment. I say we start at 75)(keeping new articles regardless of size) and see where it leads us.
Too many links may lead to people just ignoring the article. I think 75 sounds about right.
For NuGet, it was set to 15 as they mostly make smaller changes. No idea what to do with this.

New articles being removed, is it a bug?

Yes, that's a bug. I fixed the code, but I didn't re-run all the commits yet. I'll do that once we settle on the threshold for modified articles.

Approved the results. I love what you've done @BillWagner! This is amazing work!

Oh and I may owe the .NET Docs team a beverage of their choice. Or maybe I can pay in Maple Syrup? 🤔

@mamccrea

How can we add .NET for Spark to the automation?

I should be picking those up. Looks like I have a bug to fix. Can you point me to a PR in the November sprint that should be included?

@mamccrea
How can we add .NET for Spark to the automation?
I should be picking those up. Looks like I have a bug to fix. Can you point me to a PR in the November sprint that should be included?

I think this is the only one: https://github.com/dotnet/docs/pull/15840
The others were opened in Nov but merged in Dec.

Thanks @mamccrea That helped me find it.
I'll commit a new update soon that includes a number of areas that got removed by mistake. I'm glad you helped catch that.

On the threshold. I agree with @MaximRouiller

(keeping new articles regardless of size)
Too many links may lead to people just ignoring the article. I think 75 sounds about right.

Additional suggestion: Omit any file that is only updated by a PR that has the default GitHub-generated title of "Update " + filename

I think no algorithm will be perfect. But as we were reviewing Max’s reddit posts, I think it’s easy for us to identify some oddities right after we finish a month.


Oracle Cloud event catcher fails due to private method

ent_monitor) EMS [] as [ocid1.user.oc1..aaaaaaaa3yzc47pwxfbrjdnft6ptoxw45vu4poctevj2e2a666s2watp3hxa] Started Event Monitor Thread
ERROR -- evm: MIQ(ManageIQ::Providers::OracleCloud::CloudManager::EventCatcher::Runner#start_event_monitor) EMS [] as [ocid1.user.oc1..aaaaaaaa3yzc47pwxfbrjdnft6ptoxw45vu4poctevj2e2a666s2watp3hxa] Event Monitor Thread aborted because [private method `event_stream' called for #<ManageIQ::Providers::         OracleCloud::CloudManager::EventCatcher::Runner:0x00005626cbe0da60>]
ERROR -- evm: [NoMethodError]: private method `event_stream' called for #<ManageIQ::Providers::OracleCloud::CloudManager::EventCatcher::Runner:0x00005626cbe0da60>  Method:[block (2 levels) in <class:LogProxy>]
ERROR -- evm: /opt/IBM/infrastructure-management-gemset/bundler/gems/bluecf-providers-oracle_cloud-c988b7356399/app/models/manageiq/providers/oracle_cloud/cloud_manager/event_catcher/runner.rb:43:in `ensure_event_stream'
  /opt/IBM/infrastructure-management-gemset/bundler/gems/bluecf-providers-oracle_cloud-c988b7356399/app/models/manageiq/providers/oracle_cloud/cloud_manager/event_catcher/runner.rb:10:in `monitor_events'
  /var/www/miq/vmdb/app/models/manageiq/providers/base_manager/event_catcher/runner.rb:156:in `block in start_event_monitor'

Version: https://github.com/ManageIQ/manageiq-providers-oracle_cloud/commit/c988b73 (morphy)

Updated the OP to show that commit is on morphy.


Replaces Terser/Babel. Improves Build Time

DRAFT
This PR replaces Babel + Terser with SWC which improves the build time of each target.
The same ES5 targets are used for UMD build outputs.
With Terser/Babel ~ 1m40s
created build/playcanvas.js in 9.9s
created build/playcanvas in 6.2s
created build/playcanvas.mjs in 1.3s
created build/playcanvas.dbg.js in 9.8s
created build/playcanvas.dbg in 6s
created build/playcanvas.dbg.mjs in 1.8s
created build/playcanvas.prf.js in 9.4s
created build/playcanvas.prf in 6s
created build/playcanvas.prf.mjs in 1.2s
created build/playcanvas.min.js in 7.5s
created build/playcanvas.min.mjs in 6.4s

With SWC ~ 51s
created build/playcanvas.js in 3.6s
created build/playcanvas in 2.6s
created build/playcanvas.mjs in 1.3s
created build/playcanvas.dbg.js in 3.8s
created build/playcanvas.dbg in 2.6s
created build/playcanvas.dbg.mjs in 1.6s
created build/playcanvas.prf.js in 3.2s
created build/playcanvas.prf in 2.6s
created build/playcanvas.prf.mjs in 1.2s
created build/playcanvas.min.js in 1.9s
created build/playcanvas.min.mjs in 1.4s

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

Any change to sizes?

Also is there a difference in ECMA compliance, if there is a difference between ES5 versio s, and what it results in?

It has the same targets for both UMD and ES builds, so should match current
outputs.
I need to adjust some settings to get the build size back in line though,
so consider this draft for now.
On Fri, 6 Sep 2024 at 18:15, mrmaxm @.***> wrote:

Also is there a difference in ECMA compliance, if there is a difference
between ES5 versio s, and what it results in?
—
Reply to this email directly, view it on GitHub
https://github.com/playcanvas/engine/pull/6920#issuecomment-2334493431,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADJFLFPULMRTOP2IBLJDHTZVHPLDAVCNFSM6AAAAABNY3P7G2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZUGQ4TGNBTGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Below are the file sizes. Will continue investigating

Build Output
SWC
Babel/Terser

playcanvas.d.ts
1.7MiB
1.7MiB

playcanvas.dbg.js
16MiB
18MiB

playcanvas.dbg.mjs
13MiB
16MiB

playcanvas.js
2.8MiB
2.9MiB

playcanvas.min.js
1.6MiB
1.7MiB

playcanvas.min.mjs
1.6MiB
1.6MiB

playcanvas.mjs
2.7MiB
2.5MiB

playcanvas.prf.js
2.8MiB
2.9MiB

playcanvas.prf.mjs
2.7MiB
2.5MiB

The wins from this looks extremely compelling. I'd be supportive of switching.

Comparison of Existing Build System vs SWC Build System

File
Existing Gzip Size
Existing Build Time
SWC Gzip Size
SWC Build Time

playcanvas.dbg.js
4.0MiB
10.7s
3.9MiB
4.9s

playcanvas.dbg.mjs
3.2MiB
2.5s
3.2MiB
2.2s

playcanvas.js
588KiB
10.6s
555KiB
3.4s

playcanvas.min.js
431KiB
7.0s
412KiB
1.9s

playcanvas.min.mjs
416KiB
6.5s
419KiB
1.8s

playcanvas.mjs
536KiB
1.4s
551KiB
1.4s

playcanvas.prf.js
589KiB
8.8s
556KiB
5.1s

playcanvas.prf.mjs
537KiB
1.4s
552KiB
2.0s

Observations

Build Times: SWC achieves faster build times across all file types.
Gzip Sizes: SWC gzip sizes are generally comparable or slightly smaller, except for playcanvas.min.mjs and playcanvas.mjs.


Unable to retrieve child resources.  Details: Cannot read property 'version' of undefined

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Storage Explorer Version
1.21.2
Regression From
1.09.0
Architecture
x64
Storage Explorer Build Number
20210924.14
Platform
Windows
OS Version
Windows 10
Bug Description

[](url

)
Steps to Reproduce

Actual Experience

Expected Experience
No response
Additional Context
No response

Closing due to lack of response. If you are still having issues we recommend either:

opening an azure support ticket via the azure portal
opening a new issue here


Add greenspace detection and fixing to the linter

The linter should be able to detect greenspace (whitespace at the end of a line) and fix it.

Fixed by #10


Support for adding categories

Currently it's not possible to create new view categories.
A manual step is needed before I can create my view via terraform.
It would be helpful if we the provider would be able to directly create and mange categories

@seeruyy
looks like this was delivered? https://registry.terraform.io/providers/logdna/logdna/latest/docs/resources/logdna_category

@l2fprod Yes, we released this enhancement in 1.8.0 version.


MUX with single 74HC165 and 4 Encoders

Hi,
I'm unsuccessfully trying to implement the example of multiplexing encoders with a 74HC165 on an Arduino Micro, but using only one multiplexer (also setting encoderCount to 4).
Turning the first encoder (pins 6 & 7 of the IC) I'm getting the following readings:
Encoder: 0 value: 1385 delta: -1
Encoder: 1 value: 318 delta: 1
Encoder: 0 value: 1386 delta: 1
Encoder: 1 value: 317 delta: -1
Encoder: 0 value: 1385 delta: -1
Encoder: 1 value: 316 delta: -1
Encoder: 0 value: 1384 delta: -1
Encoder: 1 value: 315 delta: -1
Encoder: 0 value: 1383 delta: -1
Encoder: 0 value: 1382 delta: -1
Encoder: 0 value: 1383 delta: 1

Turning any other Encoder has no effect.
All encoders are routed directly to the IC as they are boarded with pull-up resistors.
I also tried with two ICs, because I don't fell 100% shure I can set QH_B = -1 as it is set by default for the switches' IC. Got any luck either.
Am I doing anything really silly?
Thx in advance.

I'm unsuccessfully trying to implement the example of multiplexing encoders with a 74HC165 on an Arduino Micro, but using only one multiplexer (also setting encoderCount to 4).

That won't work with the example code, it expects the A and B signals on different encoders. There is a schematic in the repo showing how to connect the encoders. https://github.com/luni64/EncoderTool/tree/master/Resources/Extras#Multiplexerwith74HC165
If you want to connect your 4 Encoders to one 74165 you need to adapt the reading code see here how this is done for another multiplexer. Translation to a '165 should be straight forward https://github.com/luni64/EncoderTool/tree/master/examples/2_multiplexing/multiplexed_MCP23S17

Ah! Sorry @luni64, I didn't realise that the IC's labels in your schematic were corresponding to:
A1 -> Pin A of Encoder 1
B1 -> Pin B of Encoder 1
A2 -> Pin A of Encoder 2
And so on...
All clear!!
Thanks a lot for your quick reply and this library


Missing support for custom domains in now logs -f

I am able to use the now log to print the logs in my terminal but it does not work when I use the -f follow option. When I activate the -d debug option this is the output:
CMD: now log -d -f mydomaine.com.
result : > [debug] Socket connected                > [debug] Socket disconnect

Just verified that this is only the case for custom domains!

@leo Here's a duplicate issue https://github.com/zeit/now-cli/issues/871

Closed as a duplicate of #871


fix: rename fields count

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.66%. Comparing base (4fc5884) to head (cd5d3d6).
Report is 3 commits behind head on 3.0.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.0     #356      +/-   ##
==========================================
- Coverage   69.29%   64.66%   -4.64%
==========================================
  Files          88      105      +17
  Lines       11245    13908    +2663
==========================================
+ Hits         7792     8993    +1201
- Misses       2721     4116    +1395
- Partials      732      799      +67

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[don't merge] Refactor CSS assets to use Sprockets instead of Webpack

Fixes #1862, #1762
Changes proposed in this PR:

Move CSS files into app/assets
Use Sprockets for SCSS compilation
Update rake assets:precompile to support JS and CSS

If I remember well, we decided to move towards npm to handle front-end related issues since they are more actively maintained than front-end assets handled through ruby gems.
Although these changes certainly keep the codebase more Rails focused, I got my doubts whether or not it is an appropriate move knowing that Rails 5 introduced Webpack on their assets pipeline...

Readme should be updated to include:
Assets Management
Javascripts
Javascript are written using ES6 and can be found in app/assets/javascripts. The application uses the recommended configuration for using Webpack in Rails 5: the webpacker gem.
You don't have to run a separate process for Webpack for JS to be compiled. This is compiled automatically on each request (in development).
Be sure to check the Rails log if you are seeing unexpected Javascript behaviour. There's an ESLint check run each time the assets are compiled, and errors are reported in the Rails log.
Stylesheets, images and other assets
Stylesheets are written using Sassy CSS (via lib-c SASS)
Stylesheets use Rails' asset pipeline for compilation. For more information on how that is configured, please read this guide: https://guides.rubyonrails.org/asset_pipeline.html
Compiling
To compile assets for development, please use the rake task rake assets:precompile

👍 The changes look fine to me. I will need to do some updating of the customized CSS for the DMPTool once this is in place.
It would be good to write up some recommendations/suggestions for how to go about customizing the CSS for local installations.
Feel free to merge into dev while I'm away

@Bodacious as this is pointed at the next-sprint branch, is there still reason not to merge it into that branch?

@xsrust Let me have another look at it and make sure it's ready.

Please ignore this. Prefer #1962

would suggest just closing this PR in favor of #1962


Patch 1

Great! Thank you Oksana!
Please also check for JocelynDAO repository, if you need to update information for our dashboard, you can do that directly via PR.
cheers
Caro.


Questions mit PlaceAvailabilityResponse

We have two

Should Compartement.number be mandatory?
isSelectable needed in this data structure?

Compartment.number should be optional. In case of open space coaches it has no meaning.

isSelectable indicates that the entire compartment is selectable, e.g. in night trains fo offers on complete compartments.

duplicate


Feature request: Connection alias

It would be nice to have a new option that allow us to set an alias to a stored connection.

close as duplicate #71


Better support for request-specific headers

This is more of a question than an issue, but there is no mailing list for Feign that I could find.
From what I can tell, feign does not support request-specific headers unless they are declared as a method parameter. This is problematic from the standpoint of incorporating Feign into a set of stateless web services as a singleton bean, and wanting to optionally forward a set of headers from service to service without having the client explicitly have to deal with them.
It seems that creating feign clients per-request could be a performance concern since reflection is used to generate the proxy. I couldn't find anywhere in the Feign builder infrastructure which caches the reflected object state to improve the performance of repeated builds of the same interface with minor adjustments to the builder object.
Has any thought been put into either adding some mechanism for allowing modifications to a specific request before sending it, or reducing the cost of creating Feign instances? Either of these approaches would help me achieve my goal. The first suggestion could potentially dovetail with the ticket for asynchronous requests that I saw on the board.
Thanks,
Chad

Hi, Chad.
Good point on no mailing list :) I suppose if we get enough issues etc
we'll start looking at SO or maybe a mailing list.
So, it is true that one should cache instances created by feign. It
isn't impossible to make a feign compiler, and that sort of thing
would be welcome. Since feign has only one method, it shouldn't be too
hard to make a forwarding caching function.
Also, I might look at RequestInterceptor, as this is what I use in
denominator for example to decorate requests. (Also look at
denominator, as a lot of patterns are there).
Does any of this help? If not, can you give some concrete examples
you'd like to enable?

Hi Adrian,
I was looking at using RequestInterceptor, but it seems like it would be less than straightforward to leverage that functionality to achieve per-request header forwarding if one were to share a single Feign instance across multiple requests.
My plan right now is to test out the possibility of using ThreadLocal to write an interceptor capable of being hooked into Spring MVC. Since SpringMVC uses the thread-per-request model, this should theoretically allow injection of request-specific headers in my use case. This is obviously a very tailored solution for my platform, and wouldn't work for a platform based on Netty's non-blocking IO (like the Play framework). Assuming that works, I might not have an immediate need for improved performance when creating Feign instances.
If it doesn't work, I'll likely look into adding reflection caching for the feign builder in the near future and submitting a pull request. The improved build performance would likely allow me to use per-request scoped Feign clients, built with a simple interceptor which adds the request's headers. I'd like to add this functionality either way because it seems like it is a more resilient mode of operation.
If you have any concrete examples of dealing with per-request-variation types of problems, I'd be glad to see them. I searched through the denominator project, but didn't find any examples of interceptor use.
Thanks

oh. you are right.. actually denominator pretty much always customizes
request headers using the Target object. Ex. this is how it adds
authentication data.
Chad, could you help me by being more concrete about the use case? (vs the
implementation)
Ex. can you sketch a sample client that and what you would be doing to it?
Would the caller interact with a hook before invocation or would they set
state? Would a system just set state for them? What is the state (ex. is
this a more generalizable security or tracing thing?) A couple use cases
will help me understand better.
I think there's room for defining a request scope (or even making clients
cheaper), just want to make sure we can write a test case for it.

Ps more on places that can help workaround
Target is the last step before the request is invoked by the client.
https://github.com/Netflix/feign/blob/master/core/src/main/java/feign/Target.java
You could also play with a forwarding Client.
https://github.com/Netflix/feign/blob/master/core/src/main/java/feign/Client.java
Or something more fancy like what spring cloud does by overriding invocation
https://github.com/Netflix/feign/blob/master/core/src/main/java/feign/InvocationHandlerFactory.java
https://github.com/spring-cloud/spring-cloud-netflix/tree/master/spring-cloud-netflix-core/src/main/java/org/springframework/cloud/netflix/feign
Cc @spencergibb
Hope this helps!

Apologies for the idea storm.
I bet JMH would show most time is spent parsing the annotations (Contract).
This might be a quicker and more stable place to get some caching quick
wins.

Concrete Example:
So I'm trying to write a server + client library as succinctly as possible. The primary use case for the client library is to enable simple service-to-service communication. I would like to have the Authorization header automatically pass through when doing such a service-to-service communiqué. This is primarily to reduce the boilerplate associated with declaring the Authorization header as a method parameter on every method, in every server.
So, lets say I have two service-oriented servers: One to get Cookies and one to get Ingredients. I want to define the interfaces exactly once, and have those be usable by both Feign and SpringMVC. So I'm using the spring-cloud-netflix SpringContract to enable the SpringMVC annotation support in Feign. Thus I have:
// Defined in Cookie API
... interface CookiesTemplate {
  @RequestMapping(value="/cookies/{id}" method=GET, mediaType=JSON)
  public Cookie get(@PathParam("id") String id);
}

// Defined in Ingredient API
... interface IngredientsTemplate {
  @RequestMapping(value="/ingredients/{id}" method=GET, mediaType=JSON)
  public Ingredient get(@PathParam("id") String id);
}

I can implement these interfaces in my servers (one each) to write my SpringMVC based web services. I can also build a client around these interfaces using Feign. This is awesome, because it just so happens that the Cookie server depends on the Ingredient server. I need the get() method of the Cookie server to call the get() method of the Ingredient server.
Ideally I want to set up the Feign clients as Spring beans, so that they can be accessed freely in my services.
@Configuration // Inside of Cookie Service
public class ConfigForCookie {
  @Bean
  public IngredientsTemplate ingredientClient() {
    return ...; // return Feign client built around the IngredientTemplate class
  }
}

Here the Feign client is defined as a bean and provided to any place within the Cookie server that needs to use it.
Every endpoint is secured, meaning that it requires an Authorization header. Since both of these endpoints are secured using the Authorization header, I'm trying to figure out how to pass that around properly. The Authorization header contains a user's access token, and it can be different for every request. We have a security library that uses Spring Interceptors to validate the Authorization header on every request, and don't have to deal with it directly. I'd like to set up something similar such that the user's token is passed along the service-to-service call chain without having to do it manually.

I was considering adding caching within the Contract, but that doesn't allow me to cache at the Class level. My assumption is that a class only needs to be interpreted once by any specific Contract implementation, since it generally will not change at runtime. If the RequestTemplate instances could be cached at the completion of processing an interface, you could bypass all future calls to that Contract for that interface. Making the Feign building performant would allow me to add a couple of Spring annotations and call it a day with the stock interceptors.
Example:
@Autowired
private HttpHeaders headers;
...
@Bean(scope= DefaultScopes.REQUEST)
@ScopedProxy
public IngredientsTemplate ingredientsClient() {
  return ...;// Feign client with basic interceptor using simple headers from the HttpHeaders object
  // The returned object is good for the current request's scope only, and a new one will be built
  // for the next request
}

I basically want to make service-to-service calls as simple as one would expect from Feign.
!!! - new potential avenue
I might be able to build a Feign interceptor around the HttpHeaders object directly. That object is supposed to be request scoped already. I'm going to pursue that avenue first.
But - I still think it would be good to have a better way to achieve this sort of functionality independent of anything Spring supplies.

Good idea wrt http headers via interceptor (or target which is basically the same thing).
I will process this further later tonight or tomorrow morning. Thanks a million for taking the time to elaborate this, Chad.

@chadjaros I'll also take a further look.

Apologies for the delay. I'm using all OSS energy to get a denominator
release cut by april 1. I will circle back at the end of the week.

Not a problem

I've come up with a pattern that I think would allow both for request-specific parameters, and for asynchronous operations as requested in this ticket.  Take a look and let me know what you think:
public class FeignClient<T> {

    // Things that you want to modify on a per-request basis. This includes
    // interceptors and load balancing rules.
    private List<RequestInterceptor> interceptors;
    private List<IRule> rules;

    public T go() {
        return proxy(interceptors, rules);
    }

    public RequestBuilder request() {
        return new RequestBuilder(interceptors, rules);
    }

    public AsyncRequestBuilder asyncRequest() {
        return new AsyncRequestBuilder(interceptors, rules);
    }

    protected T proxy(List<RequestInterceptor> interceptors, List<IRule> rules) {
        // TODO apply additional interceptors and rules
        // TODO Return proxy with injected settings
        return null;
    }

    @Data
    @Accessors(chain = true, fluent = true)
    class RequestBuilder {
        private List<RequestInterceptor> builderInterceptors;
        private List<IRule> builderRules;

        public RequestBuilder(Collection<RequestInterceptor> interceptors, List<IRule> rules) {
            builderInterceptors = Lists.newArrayList(interceptors);
            builderRules = Lists.newArrayList(rules);
        }

        private RequestBuilder addInterceptor(RequestInterceptor interceptor) {
            builderInterceptors.add(interceptor);
            return this;
        }

        private RequestBuilder addRule(IRule rule) {
            builderRules.add(rule);
            return this;
        }

        public T go() {
            return proxy(builderInterceptors, builderRules);
        }
    }

    @Data
    @Accessors(chain = true, fluent = true)
    class AsyncRequestBuilder {

        private List<RequestInterceptor> builderInterceptors;
        private List<IRule> builderRules;

        public AsyncRequestBuilder(Collection<RequestInterceptor> interceptors, List<IRule> rules) {
            builderInterceptors = Lists.newArrayList(interceptors);
            builderRules = Lists.newArrayList(rules);
        }

        private AsyncRequestBuilder addInterceptor(RequestInterceptor interceptor) {
            builderInterceptors.add(interceptor);
            return this;
        }

        private AsyncRequestBuilder addRule(IRule rule) {
            builderRules.add(rule);
            return this;
        }

        public <U> ListenableFuture<U> go(Function<T, U> function) {

            SettableFuture<U> future = SettableFuture.create();

            {   //TODO execute asynchronously
                future.set(function.apply(proxy(builderInterceptors, builderRules)));
            }

            return future;
        }
    }
}

After an initial look, the code that would need to change to support this is somewhat substantial. The binding to a target would be delayed until the call to FeignClient#proxy, so code that is executed up to that point would need some refactoring to make it more efficient than it currently is.
I'm going to take a run at making something like this work, and I'll let you know how it goes.

Thanks, Chad. I plan to have a deep look at this tomorrow.

Here is a quick and dirty proof of concept. Completely untested, but I think it illustrates the emphasis on late binding.
https://github.com/chadjaros/feign/compare/master...chadjaros:late-binding-client?expand=1

Cool. Today got away from me. Will try again tomorrow!

@chadjaros I've looked at this, and I'm wondering if this can't be solved with composed Targets?
Ex. a Target can have an instance of a feign client. It completely controls the request sent, so can do anything. If there's something of asynchronous nature, we'd probably best decouple that from collaborative clients as it makes the topic easier to grok.
Ex. take a look at the existing thing here:
https://github.com/Netflix/feign/blob/master/core/src/test/java/feign/TargetTest.java
I targets to deal with credential supplying in denominator, too. For example, there's one where a discovery client needs to be invoked to get the endpoint and header to pass to other things. Target was literally made for this usecase.
Thoughts?

For example, there's one where a discovery client needs to be invoked to get the endpoint and header to pass to other things.

I definitely see how Target can be used to provide endpoints and headers for certain use cases. I definitely plan to create custom targets for use cases around discovery.

It completely controls the request sent, so can do anything.

I think that your assertion makes sense, and could be suitable for my use case if it were in a single threaded context. In this respect, I could do something such as:
CustomTarget target = new CustomTarget(MyInterface.class, "https://server");
MyInterface proxy = Feign.builder()
    ...
    .target(target);

target.setLoadBalancingKey("Only servers on port 4444");
target.setHeader("headerKey", "headerVal1", "headerVal2");

Cake chocolateCake = proxy.getCake("chocolate");

Is this along the lines of what you were thinking?
In a multi-threaded context I don't think this continues to work. If I tried to execute a second request concurrently using the same target and proxy, the header and load balancer key values become unpredictable, and neither request can be guaranteed to execute properly.
As I understand it, the interface proxy to Target relationship is 1 to 1. Any parameters that I pass into the target can will affect the proxy generated from that target. To make this paradigm safe in a concurrent application, you must pass all of the modifiable parameters in a single scope. The way that the proxy object and Target are defined means that you likely have to create a new target and proxy for arguments that fall outside of the interface's method arguments, and as we discussed before that doesn't seem to be very efficient. The code that I provided is an attempt to make creating the new target and proxy as efficient as possible, and thread-safe as well.
As for asynchronous execution, I'm not sure how it would be possible to handle this within the target. Since the call to your proxy (and subsequent return value) is synchronous, any asynchronous work you do within the target must be re-synchronized to return a valid resultant. I'd like using an asynchronous interface to be as straightforward as using the synchronous one, and I think that the object I proposed above does just that:
FeignClient<MyInterface> client = ....target(...);
ListenableFuture<Cake> futureCake = client.asyncRequest().go( request -> {
    return request.getCake("chocolate");
});

Am I way off base here? If so, can you help illustrate more clearly how these use cases could be solved using the existing model?

No.. I don't think you are way off base. It is hard to relate nuances like
this in text, but you've done a surprisingly good job, Chad.
I will make another pass at thinking through this. Personal deadline is
Weds but maybe sooner.
Thanks for championing this feature!

Thanks Adrian, it's my pleasure.

Ok so another round, and looking for least efforts and new concepts to support request-scoped overrides, such as headers, applied via thread-locals.
base case: cache feign and do .newInstance for each request
Feign (the object) has a .newInstance(Target) method, which for at least the case of synchronous commands could achieve the goal of late binding context including any headers. Without any tuning, "laptop speeds" are 12K contract parses per second, and could be improved.
alternative: no change to feign, but deeper integration in a framework.
One way to avoid the performance burden could be to fix the number of calls to feign.newInstance (instances) to the threads that affect state.
i.e. the source of request-scoped data is a thread-local, coordinate with it. Ex. have feign also be a thread-local, use an invocation handler, custom target or otherwise to ensure that when the framework applies state, it goes to whatever hook is present at the same time.
alternative: make it cheaper to customize feign (aka chad's idea)
Looking closer at chad's idea, deferring the application of interceptors or target. I think this can work.
If you look carefully at Feign.newInstance, just about everything deals only with Target.type, the interface type T. Everything else is not very important until a request is made.
I like Chad's idea, but would feel comfortable with a little less initial scope. For example, by limiting scope to target, there are less new concepts in feign, and should still be possible to construct new abstractions.
Feigned<Foo> foo = Feign.prepare(Foo.class); // forgive the name, this does everything expensive
Foo requestScoped = foo.target(new FooTarget()); // call this as often as per request

Something like this we'd call beta until async is done. In any case I'd really like to ensure whatever we make has test cases that would break if we screwed up the impl (ex. actually set a thread-local in a test.)
Thoughts?
cc @spencergibb
ps apologies but I can only participate on this thread more tomorrow, as I'll be offline till early june.

I like the second idea. I think that it solves both per-request and asynchronous use cases, and is generic enough to work with any framework.
I agree that separating the target from the interface type is something that could happen. In my quick and dirty example I considered it, but then decided not to since it was quick and dirty.
If we did this, you could even supply a default target in the builder. Overriding the target could be optional as a late binding effort to support advanced scenarios.

cool, so if you are cool from moving from quick and dirty land to
implementation, give it a go! I can review on June 2. If you choose to,
make sure no deps are added.
Otherwise, I can have a go when I get back. Thanks regardless for thinking
this through including mockups, Chad.

I have to wait for GrubHub to put together our github organization and get our legal ducks in a row before I can submit such an implementation. I'd like to do that, but it might take a couple more weeks to get everything in order.
I'll let you know.

Okie. Keep us posted!

@chadjaros I too am very much interested in this solution. I have the same basic requirements, where I'm building a set of micro-services using Spring Cloud and need to propagate the request header information so that I can pass along the request-specific authorization information from one service to the next.

@chadjaros Any updates on your possible solution?

Sorry for the delay guys. I never was able to get my old company to set up an OSS policy, and was hamstrung by that. I've since changed jobs and now should have the freedom to work on this on the side.

@chadjaros I ran into this thread as we are running into difficulties trying to set per-request headers as well. Is this feature something we can look forward? Is there other ways to tackle this problem today?

We were trying out Feign to replace our clients written in Jersey. Not being able to set request headers per-request is preventing us from a full blown adoption. So why can't we use the Target class? Thread safety?
Any plans to include this in a future roadmap or any simple workarounds?

folks, to make it more clear what you're looking for, can you vote for any of the proposals above? or should we assume you want "alternative: make it cheaper to customize feign (aka chad's idea)"

Again, sorry for the delay.
@faizanahemad You can't use the target class for this exactly because of thread safety. The target is logically disconnected from the act of making a request. I wasn't able to figure a way to tie something in the target to a specific request without making the target synchronized for the duration of each request. This, of course, seriously impedes performance in a multi-threaded web server that uses a singleton instance of a feign client.

I have the exact same use case, except environment is jersey/guice. +1 for alternative: chad's idea

@adriancole
adriancole
Hi adriancole,
I am trying to call below method through feignClient
ResponseEntity getTransactionList(
@Valid TransactionSearchRequest categorizedTransactionSearchRequest,
@apiparam("Pageable information") @pageabledefault(size = 05, page = 0) Pageable p);
But i am getting below exception
Caused by: java.lang.IllegalStateException: Method has too many Body parameters: public abstract org.springframework.http.ResponseEntity com.worldline.fpl.banking.budget.controller.IBudgetController.getTransactionList(
com.worldline.fpl.banking.budget.json.TransactionSearchRequest,org.springframework.data.domain.Pageable)
at feign.Util.checkState(Util.java:128)
at feign.Contract$BaseContract.parseAndValidateMetadata(Contract.java:114)
at org.springframework.cloud.netflix.feign.support.SpringMvcContract.parseAndValidateMetadata(SpringMvcContract.java:133)
at feign.Contract$BaseContract.parseAndValidatateMetadata(Contract.java:64)
at feign.hystrix.HystrixDelegatingContract.parseAndValidatateMetadata(HystrixDelegatingContract.java:34)
at feign.ReflectiveFeign$ParseHandlersByName.apply(ReflectiveFeign.java:146)
at feign.ReflectiveFeign.newInstance(ReflectiveFeign.java:53)
at feign.Feign$Builder.target(Feign.java:209)
at org.springframework.cloud.netflix.feign.HystrixTargeter.target(HystrixTargeter.java:48)
at org.springframework.cloud.netflix.feign.FeignClientFactoryBean.loadBalance(FeignClientFactoryBean.java:146)
at org.springframework.cloud.netflix.feign.FeignClientFactoryBean.getObject(FeignClientFactoryBean.java:167)
at org.springframework.beans.factory.support.FactoryBeanRegistrySupport.doGetObjectFromFactoryBean(FactoryBeanRegistrySupport.java:168)
... 44 common frames omitted
When i debugged it, i got know that these
interface org.springframework.data.web.PageableDefault
interface javax.validation.Valid
are not the feign supported annotations and that's why it is failing
But i am not getting the solid fix for it .
Can you help me on this as soon as possible ?

@GarimaJainATOS your message is on an unrelated issue about spring-cloud-netflix. please raise a new issue there!

Same here, stuck on having to set request specific header through interceptor with data stored in session.
Bit trashy, issue has been open for 2 years and seems to be a common use case, is there any plan to make it easier?
Or to wrap the API method with an extra Map parameter that would be the extra headers to add ?

I've just ran into this issue - has there been any update?

@adriancole I have several question abort the interceptor of open feign that is it thread-safe when i use to it set header like 'token' ?

Any updates on this, ran into the same issue to make request specific header with jwt

Any update on this?

There are a number of ways to accomplish this today.  I've included the relevant documentation below:
Headers: https://github.com/OpenFeign/feign#headers
Dynamic Per Target: https://github.com/OpenFeign/feign#setting-headers-per-target
Request Interceptor: https://github.com/OpenFeign/feign#request-interceptors
JHipster also has one approach for building authorized Feign Clients: https://www.jhipster.tech/using-uaa/
For this specific request, no work has started.  Chad's idea is one we could consider, which involves creating a new Feign target per request, but I want to see if there are any other alternative proposals.  We will then consider this feature for the next major release of Feign (11)

This is such a blocking issue for me, we are gonna move away from feign solely because of this


Issue on constructor initialization.

Hi
In file VVSwiftFunctionCommenter.m, on method captureReturnType, there is a little fix to do.
On constructors 'init(....)' should not be the return type.
By the way, good job!

+1


Compile error on rx1_motor

Hi, I have a compilation problem with rx1_motor.
Here is the error:
[ 82%] Linking CXX executable /home/exotrapp/catkin_ws/devel/lib/rx1_motor/rx1_motor_node
/usr/bin/ld: /home/exotrapp/catkin_ws/devel/lib/librx1_motor.so: undefined reference to rx1_motor::Rx1Motor::TORSO_ACC_' /usr/bin/ld: /home/exotrapp/catkin_ws/devel/lib/librx1_motor.so: undefined reference to rx1_motor::Rx1Motor::ARM_ACC_'
/usr/bin/ld: /home/exotrapp/catkin_ws/devel/lib/librx1_motor.so: undefined reference to rx1_motor::Rx1Motor::TORSO_SPEED_' /usr/bin/ld: /home/exotrapp/catkin_ws/devel/lib/librx1_motor.so: undefined reference to rx1_motor::Rx1Motor::ARM_SPEED_'
/usr/bin/ld: /home/exotrapp/catkin_ws/devel/lib/librx1_motor.so: undefined reference to rx1_motor::Rx1Motor::HEAD_ACC_' /usr/bin/ld: /home/exotrapp/catkin_ws/devel/lib/librx1_motor.so: undefined reference to rx1_motor::Rx1Motor::HEAD_SPEED_'
collect2: error: ld returned 1 exit status
make[2]: *** [rx1/rx1_motor/CMakeFiles/rx1_motor_node.dir/build.make:120: /home/exotrapp/catkin_ws/devel/lib/rx1_motor/rx1_motor_node] Error 1
make[1]: *** [CMakeFiles/Makefile2:2180: rx1/rx1_motor/CMakeFiles/rx1_motor_node.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 88%] Linking CXX shared library /home/exotrapp/catkin_ws/devel/lib/librx1_ik.so
[ 88%] Built target rx1_ik
make: *** [Makefile:141: all] Error 2
Invoking "make -j4 -l4" failed

Thanks for reporting! It seems that some compiler doesn't like the static constexpr in the header file. There are two ways to solve it, you can either add add_compile_options(-std=c++17) to your CMakeLists.txt to he rx1_motor (I have just pushed this change, you just need to pull the latest again).
Alternatively, if you don't want to use c++17, you could also change the static constexpr values in the rx1 motor header file to pure const, like const double TORSO_ACC_=1.5

great, I just recompiled and it works perfectly. Thank you so much


Non-CLI project Support

Is there any way to use this in a non-CLI project?
I am fairly new to the Ember and cant use CLI for requirements reasons. There doesnt appear to be much in the way of doing cloaking in "regular" Ember projects.

What sort of requirement prevents you from using ember-cli? It's inter-workable with any other existing build system.  I won't be providing a globals build, as globals based versions of addons lack proper configurability.
There is a way to use this in non-cli projects, but that too is experimental: https://github.com/ef4/ember-giftwrap

@runspired Thank you so much for the quick reply.
The reason I havent gone to CLI is because of human issues not because of technical issues: I am the only web developer building on-top of their existing ASP.NET project (which they still need to be able to modify themselves sometimes). The idea of getting a bunch of .NET devs to sign-off on a new build system that is not CTRL-B in Visual Studio is going to be a no go for a while. Especially since all the rolling agents use MSBUILD. Sigh. Working on the Microsoft platform always gives weird challenges.
Anyway I understand that it is not worth shipping a globals version if there is not enough demand. Thank you for all of your hard work and for the suggested work around.


Support casks in brew edit.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?
[x] Have you successfully run brew man locally and committed any changes?

Nice work but it'd be nice to hold off on merging these for a bit as-per https://github.com/Homebrew/brew/pull/8989.


number fields

hi
i have a number field in grid that accepting String also how to restrict to numbers only, and i seen that
ticket no  #76 that's not working for me can u plz send the working code. i don't have much experience in front-end.

#76 does answer the question how to subscribe to event in the edit field.
See this fiddle to know how to prevent typing letters http://jsfiddle.net/lesson8/HkEuf/1/
If you will have problems with it, provide a fiddle with you tries.

thank you very much for fast reply,
this fiddle for common html input fields but i need to integrate it with grid input types, am unable to capture key-press event for grid input types, plz help me.

To integrate it with jsGrid you need to redefine editTemplate or insertTemplate just as it's done in #76.
Change the following fiddle http://jsfiddle.net/tabalinas/zzzfmpgt/ to demonstrate how you try to do it and the problem you faced with.

this is the fiddle, https://jsfiddle.net/vekomy/zzzfmpgt/8/  Actually am unable understand Template concepts, remining every thing is fine. deletion operations, rowRendering, cutomViews, every thing is fine.

The problem in your fiddle is that inserting for the grid is turned off J
Add inserting: true to the grid config.

can u plz send me the currect working fiddle.

This is your fixed fiddle http://jsfiddle.net/tabalinas/zzzfmpgt/9/ (just added inserting: true). Here you got alert on keypress in Address field.

Thank u very much for spending your valuable time for me, but still i didn't get  any alert in this fiddle,
am using latest version of chrome browser, is there any browser capability required for this, and alerts also not blocked in my browser.

 You should click the plus icon to switch to insertion and then type something in Address input.

yes your  right its working fine, but my requirment is i need that event while editing exiting data, not for new entry, is this possible?
any way great work Tabalinas thank you very much.

Why not? Just do the similar code for the editTemplate (as you did for insertTemplate).


Checking for update failed

OS: macOS(10.14.6)
node: v12.9.1
now-cli: 16.1.3-canary.4
I just updated now-cli to the latest version(canary) and I receive the following message. I'm not sure if this is a bug or a problem with the api where the latest version of now is verified :-(

The problem has just disappeared in the latest canary version of now 😄
now version: 16.1.3-canary.6


Data of the interaction mode and the holarchy screen should be shared

To prevent 2 API calls to be made with the same data and settings (loading the same results)
To prevent modals from appearing twice on the same conditions but after switching screens.

oplossing: check toevoegen aan interactive elements of state is aangepast in slider


Add unplug-vue-macros and other updates from vitesse

Thanks for sharing this template. We're finding it very helpful.
There have been a couple of updates to vitesse in the last year. Would you be able to add them?

Add unplug-vue-macros packlage. See: https://github.com/antfu/vitesse/blob/75e627165659d615148a69fa2f43156e23f34ab8/package.json#L52 and https://vue-macros.sxzz.moe/
Add vite-plugin-vue-component-preview package. See: https://github.com/antfu/vitesse/blob/75e627165659d615148a69fa2f43156e23f34ab8/package.json#L57
Add starter Dockerfile. See: https://github.com/antfu/vitesse/blob/main/Dockerfile

I think that's all the changes... I may have missed something though

I will take a look into this in the weekend! :)


[Feature] Push latest github version as a beta

Hello, can you please create the wheels for the latest github code that can support chrome123? I tried building this myself and keep getting errors and would like to be able to install it via poetry.
Thanks

Blocked by https://github.com/yifeikong/curl-impersonate/issues/62

Blocked by yifeikong/curl-impersonate#62

Ahh what a shame, chrome122 or 123 are very important for my project and I don't think you added 122 support and skipped it.
Well thanks for the reply, cheers!


cmd/go: tests timing out on aix builder

The cmd/go tests are timing out on the aix/ppc4 builder:
https://build.golang.org/log/86480370eb2fba22d0f47458ad1fecf8ce9beea7
It looked similar to the Plan 9 failures reported in #29033 at first, but @bcmills suggested to track this in a different issue as the lockedfile implementation for plan9 is different from the other platforms.
@Helflym mentioned in https://github.com/golang/go/issues/29033#issuecomment-443196871 that the timeout is only triggered on the builder, but not on a fresh install fetched from git. So there might be some issue with the builder.
Also, it seems the last few commits haven't been built by the aix/ppc64 builder which also indicates some issue with the aix builder.
/cc @bradfitz

First, I've opened issue 29078 which might be the problem with cmd/go timeout.
However, currently the builder is stuck in a cmd/compile at:
(gdb) bt
#0  0x0000000100023210 in runtime.(*gcWork).checkPut (w=0x100025598 <runtime.(*mheap).allocManual+56>) at /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/src/runtime/mgcwork.go:120
#1  0x00000001000234d8 in runtime.(*gcWork).putBatch (w=0xe8c10088e8e10090, obj=...) at /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/src/runtime/mgcwork.go:191
...

(I don't have the rest of the backtrace, as gdb isn't fully working yet)
I'm not sure this is related to the PATH problem. A few crashes that occurred seems linked with a problem inside the runtime:
https://build.golang.org/log/a7041ed8be3d4c3c9f21bf367590a69e52d460de
Morever, is there a way to manually trigger a build ? I could make some experiments to figuring out what's wrong. If not, I'll let the builder stuck until PATH is changed. This will avoid unnecessary fails and provides more tests that everything was related to PATH afterwards.

It appears that the aix builder is down, so I also can't get a gomote session to it to investigate further.
I did try running go test cmd/go/internal/lockedfile/... on it last week, and those tests failed because /tmp is apparently mounted in a way that does not support flock-based file locks. I'm not sure whether that's a configuration issue or a fundamental limitation of the OS.
I tried running go test -short -timeout=1m cmd/go, but that ended up hung at this line:
https://github.com/golang/go/blob/1adbb2bb9b256907eaf3f012d7f818765e6e2a2b/src/cmd/go/script_test.go#L882
That suggests that either there is a serious hang in cmd/go or a bug in the aix kernel, perhaps regarding the interaction of signals and file-locks?

aix builder is in a infinite loop currently. I'd rather kill the hanged process, once the new PATH has been provided. Except if it doesn't need an update of 'cmd/buildlet' in this case, I'll release it as soon as you want.
Moreover, the new package cmd/go/internal/lockedfile isn't AIX friendly. AIX flock isn't blocking if it's called twice by the same thread. I'm already working on it.

Yes, it do have it but filelock_solaris.go seems even more constrained. I'm not sure AIX will need the whole inode stuff. It seems to work with a mutex above every Flock calls. (It needs few adjustments though).
By the way, syscall.Flock is calling fcntl on AIX, cf flock_aix.go.

By the way, syscall.Flock is calling fcntl on AIX, cf flock_aix.go.

That seems dangerous: at least on other platforms, flock and fcntl normally release their locks a different points (flock when the first descriptor cloned from the same open call is closed, and fcntl when the first descriptor referring to the same underlying file is closed).
FWIW, we rejected a similar implementation for Solaris (#24684). We should probably remove the one for AIX before it gets released: we can always add it back later if needed. I'll open a separate issue.

We should probably remove the one for AIX before it gets released

Filed as #29084.

Ok thanks.
By the way, I have tried solaris version of filelock and it does work.

I've made some investigations and the timeouts seem to come from different issues.
The main problem is the runtime being stuck in an infinite loop during runtime.(*gcWork).checkPut. This was introduced to resolve #27993. This happens mainly during a cmd/link or a cmd/compile launched by go build. Only once in a while though.
I currently have a cmd/link stuck with gcWorkPauseGen = 3 and w.pauseGen = 3:
 (gdb) bt
 #0  0x0000000100022dc0 in runtime.(*gcWork).checkPut (w=0x100025414 <runtime.(*mheap).allocSpanLocked+276>) at /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/src/runtime/mgcwork.go:120
 #1  0x0000000100023078 in runtime.(*gcWork).putBatch (w=0xe8c10088e8e10090, obj=...) at /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/src/runtime/mgcwork.go:191

(Sadly, I don't have more backtrace as gdb isn't fully working on aix/ppc64...)
I've also found out different crashes which seem to be related to P objects:

stopTheWorld failed:

https://build.golang.org/log/50ec0b78e9620a26462f7b1ea21a05d15649396a
https://build.golang.org/log/22750e2042a017af794fc0c6d54443f52136dd36

sigsegv during wirep:

https://build.golang.org/log/939122096495ea23de59f61139ecfa89125440ba
https://build.golang.org/log/714b6da7d8504932c0e0f527c27d075daf22fe65

forEachP not done:

https://build.golang.org/log/a7041ed8be3d4c3c9f21bf367590a69e52d460de

I think every think is linked to AIX syscalls that are made by calling 'asmcgocall' and C functions. How does GC know that a thread is in a C syscall ? It's for possible that I've forgotten to add a GOOS="aix" somewhere to handle syscalls correctly, even if I've check several times.
Morever, we are aware that the test machine has a really really slow local disk. That's why we have created a ramdisk to store the build folder. The person who have provided the machine is trying to find a way to fix this slowness. However, it might be interesting to change TMPDIR and GOTMPDIR to /ramdisk0/tmp. This might accelerate the whole process.
I still don't understand why these timeouts occur everytime within the builder but never when I manually launch all.bash... Are there many differences between both ?
Note that during the manual launches, cmd/go takes ~227s and net ~100s. Net is strange because during most of the builds made by the builder it takes only 50s, but sometimes it timeouts too:

https://build.golang.org/log/6f8710caf5b22e34b7e6e5423749bc2b38b787f1

If anyone has ideas about the origin of these bugs, you're welcome !
/cc @aclements

Tests are still timing out even after the new PATH CL 152457 and the remove of Flock in cmd/go/internal/lockedfile CL 152397. There are still some problems with the last one, but it does trigger an error and not a timeout.
I've been searching for a few days and still don't understand what's wrong with the builder. How far the environment or the execution are different from a classic ./all.bash ?
I've tried with fresh git clones and it never times out in cmd/go tests. It does time out sometimes because of the issue that I've spoken above (with runtime.(*gcWork).checkPut) but it's not that common anyway.
The timeout during cmd/go tests seems to always be related to TestScript/script_wait test. sleep process seems to never be killed... Maybe, there is something wrong with signals on AIX. But it's really strange that it never occurs while running ./all.bash. There is no error handler in script_test.go:interruptProcess(), I'll submit a patch which might give us more information about why sleep isn't killed.

It seems to inherit that from buildlet command which is also ignoring INT signal. Is something done on purpose by cmd/buildlet ?

I have no memory of doing such a thing on purpose (or accident).

Well, it seems that this sigignore came from how we were launching our builder. It should be ok now. We'll see if it works during the next commit !

The main problem is the runtime being stuck in an infinite loop during runtime.(*gcWork).checkPut.

If some thread is stuck on checkPut, then the real question is what's going on on the other threads. There should be another thread running gcMarkDone, since the condition checkPut is spinning on is only true while gcMarkDone is running. If, as you mention, there are issues with stopping Ps on aix (in stopTheWorld and forEachP), then that's probably the root cause, since gcMarkDone has to stop all of the Ps before it can release the spin loop in checkPut.


pip install xstac breaks gcsfs (due to pip install adlfs)

Encountered this issue while using xstac for https://github.com/pangeo-forge/pangeo-forge-orchestrator/pull/1
Reproducer:

Create and activate a new conda env (python=3.8)
conda install gcsfs
Open an interpreter: import gcsfsworks
pip install git+https://github.com/TomAugspurger/xstac.git
Open an interpreter: import gcsfs fails with:

>>> import gcsfs
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/cs/.pyenv/versions/anaconda3-2019.10/envs/pfo2/lib/python3.8/site-packages/gcsfs/__init__.py", line 5, in <module>
    from .core import GCSFileSystem
  File "/Users/cs/.pyenv/versions/anaconda3-2019.10/envs/pfo2/lib/python3.8/site-packages/gcsfs/core.py", line 1095, in <module>
    class GCSFile(fsspec.spec.AbstractBufferedFile):
AttributeError: 'EntryPoint' object has no attribute 'AbstractBufferedFile'

My workaround is to install xstac from a branch which drops the adlfs dependency in pyproject.toml; this appears to work. Presumably the pip install adlfs triggered by the git install of xstac is not resolving correctly.
Perhaps the solution is to make a conda-forge recipe for xstac?

Belated thanks for this prompt fix, Tom!


Use latest tslint config and fix some lint errors

This is fairly uncontroversial, so I'm going to merge after a green build.


Adding hosts ads to basic

Maybe this right? no duplicate?

I'm sorry Denny @hexageek1337 I will try to explain this again.
The root hosts file in this repository is generated from data.  This PR changes a file that is regenerated by updateHostsFile.py.
Our data sources are found in the data folder.
This is all explained in the readme of this repository.
Closing.


FreeBSD activerecord-jdbcsqlite3-adapter fails to create or connect to database

While I am using FreeBSD 10.2-RELEASE-p7 and JRuby <IP_ADDRESS>, this has been failing for several months, and was also failing on JRuby 1.7.x and <IP_ADDRESS>.
sqlite_issue.txt

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/34512841-freebsd-activerecord-jdbcsqlite3-adapter-fails-to-create-or-connect-to-database?utm_campaign=plugin&utm_content=tracker%2F136963&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F136963&utm_medium=issues&utm_source=github).

seems like a problem with SQLite itself (but I can not confirm without a FreeBSD machine).
you could try -Darjdbc.debug.trace=true or monkey-patch around the error if there's a Java cause.

Here is a trace with -Darjdbc.debug.trace=true -Darjdbc.debug=true
sqlite1.txt

the trace confirms its a native library loading issue under FreeBSD :
Caused by: java.lang.Exception: No native library is found for os.name=FreeBSD and os.arch=x86_64
        at org.sqlite.SQLiteJDBCLoader.loadSQLiteNativeLibrary(SQLiteJDBCLoader.java:284)
        at org.sqlite.SQLiteJDBCLoader.initialize(SQLiteJDBCLoader.java:65)
        at org.sqlite.core.NativeDB.load(NativeDB.java:53)
        at org.sqlite.core.CoreConnection.open(CoreConnection.java:211)
        at org.sqlite.core.CoreConnection.<init>(CoreConnection.java:76)
        at org.sqlite.jdbc3.JDBC3Connection.<init>(JDBC3Connection.java:24)
        at org.sqlite.jdbc4.JDBC4Connection.<init>(JDBC4Connection.java:23)
        at org.sqlite.SQLiteConnection.<init>(SQLiteConnection.java:45)
        at org.sqlite.JDBC.createConnection(JDBC.java:114)
        at org.sqlite.JDBC.connect(JDBC.java:88)

thus this one is blocked by https://github.com/xerial/sqlite-jdbc/issues/106

should be good with latest jdbc-sqlite3


Doesn't work with x.com URLs

The plugin needs to be updated to support the new x.com domain.

the code changes already down, but I encountered some issue when I try to upload the new release, I will let you know once the new version (1.2.0) uploaded.

Awesome! Thanks!


Added post stack Shandie Dash Wait functionality

Includes Advanced Settings checkbox

This functionality has been converted into an Addon found at:
https://github.com/JonBallinger/IC_ShandieDashWait


ingress uses unsupported LBType LoadBalancer

Hi,
I just started witch kubernetes and find voyager (if I understand it right) preaty awesome.
Unfortunally i run in an error creating a new ingress:
error when creating "ingress.yaml": admission webhook "admission.voyager.appscode.com" denied the request: ingress website-namespace/ingressname uses unsupported LBType LoadBalancer for cloud provider baremetal
It might be a "noob bug".
System information:
os:
Fedora 29
kubectl version:
Client Version: version.Info{Major:"1", Minor:"12", GitVersion:"v1.12.2", GitCommit:"17c77c7898218073f14c8d573582e8d2313dc740", GitTreeState:"clean", BuildDate:"2018-10-24T06:54:59Z", GoVersion:"go1.10.4", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"12", GitVersion:"v1.12.2", GitCommit:"17c77c7898218073f14c8d573582e8d2313dc740", GitTreeState:"clean", BuildDate:"2018-10-24T06:43:59Z", GoVersion:"go1.10.4", Compiler:"gc", Platform:"linux/amd64"}
I really hope somebody can help me.
Maximilian

maybe you can use:
kubectl delete validatingwebhookconfiguration admission.voyager.appscode.com

I had the same problem, and this document helped me solve it:
https://github.com/appscode/voyager/issues/1203


Added compile support for NuttX system

This is a basic version of compile support and only x86 simulator lightning-APP is supported now.
The compilation method is shown below:
bash examples/lighting-app/nuttx/build_sim.sh
and compiled binaries are in the examples/lighting-app/nuttx/out directory.
Detailed introduction about NuttX system can refer to this link: https://github.com/apache/nuttx
I have a few questions to ask the experienced mentors in the community.

Because the nutx platform supports most posix interfaces, most Linux code can be reused without recreating the NuttX platform-specific source directory. Whether this behavior is okay?
Whether the compilation process provided in patch is appropriate?
How can I add a CI workflow that covers the NuttX compilation process?
Currently, the compilation script automatically downloads the latest version of NuttX, because the latest tag does not include support for matter, should I wait for a NuttX tag version that supports matter to update this patch again?

Thank you very much for your comments and suggestions. I greatly appreciate your input.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Requestion changes: use a build setup as other platforms:

separate docker file and chip-build-vscode update
make sure the SDK files are not a moving target
integrate with build_examples.py
Add CI

@andy31415  Thank you very much for your reply. I will modify the code according to your requirements, but is there any documentation on how to add CI? thanks.

Requestion changes: use a build setup as other platforms:

separate docker file and chip-build-vscode update
make sure the SDK files are not a moving target
integrate with build_examples.py
Add CI

@andy31415 Thank you very much for your reply. I will modify the code according to your requirements, but is there any documentation on how to add CI? thanks.

@zhhyu7 CI workflows are generally items in https://github.com/project-chip/connectedhomeip/tree/master/.github/workflows
you can pick one of the embedded examples as a starter (e.g. ameba, asr, boufallolab, cc*, efr32, esp32, infineon, k32w etc).
The steps are likely like this:

a PR to define a docker image that can be used. (and add the SDK to vscode image as well)
add support to build_examples.py to compile with something like --target nuttx-lighting-app or similar
create a examples-nuttx.yaml which runs the compilation step for the example app to make sure it keeps compiling at least

if you have some way to add support for some emulator tests after that, that would be great.
For new platforms we also need contact information for maintainer. To not leak e-mails/handles here, could you contact me in slack and be prepared to provide maintainer(s):  github handle, slack handle, e-mail address.
Generally this would be used to help with platform specific breakages or to discuss updates that may affect a lot of platforms (e.g. we discussed C++ compiler version updates at some point).

@andy31415 Please help review this patch, thank you very much!


404 on Refresh

Describe the bug
Currently when you login and click refresh on any page you get a 404 error.
To Reproduce
Steps to reproduce the behavior:

Go to Momentum Mentors
Click on login
Refresh the page
See error

Expected behavior
Users should be able to refresh any page and not get an error.
Screenshots
N/A
Desktop (please complete the following information):

Browser [chrome, safari]

Additional context
N/A
┆Issue is synchronized with this Trello card by Unito

Fixed with https://github.com/TeamProductionSystem/Team_Production_System/pull/102


Reduce logging in DEBUG for MasterService:run

Description
Reduce logging in DEBUG for MasterService:run by introducing short and long summary in TaskBatcher.
Existing Behavior:
Today, as part of creating task summary in TaskBatcher:run, we are taking upto 10 mins to create tasksSummary for scenario where pending task batchingKey has 200K tasks. This summary is primarily eventually used in logging at DEBUG mode and passed as source field in ClusterChangedEvent object.
Proposed Behaviour:
We will introduce an additional short tasks summary as as part of TaskBatcher:run, it will be comprising of just the batching key name, it will be used for DEBUG logging and passed as source field in ClusterChangedEvent object.
Only if trace logs are enabled, we will compute resource intensive tasksSummary which will now be passed as supplier from TaskBatcher:run to MasterService:run.
Performance Impact -
Savings of ~10 minutes to compute the long task summary during recovery phase for cluster with 200K shards. We will only compute long summary if TRACE level logging is enabled.
Related Issues
Resolves #12249

Check List

[Yes] Functionality includes testing.
[N/A] API changes companion pull request created, if applicable.
[N/A] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

❌ Gradle check result for 9a43c12: ABORTED
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Failed test is FLAKY - org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testWriteLargeBlob
https://github.com/opensearch-project/OpenSearch/issues/14318

Failing gradle check due to flaky test org.opensearch.action.admin.indices.create.RemoteCloneIndexIT.testCreateCloneIndexLowPriorityRateLimit
Tracking Issue - https://github.com/opensearch-project/OpenSearch/issues/14292

This might break operator tooling since most developers rely on node-left and node-join logs of MasterService to figure out the reason of cluster instability, which now needs to be enabled as TRACE cc: @rajiv-kv @shwetathareja
Logs now go like which contains the class name, making it hard for operators to read/comprehend
[2024-10-12T16:42:09,946][WARN ][o.o.c.s.MasterService    ] [aa6030d2df35ee37b021971c031436d8] took [1m], which is over [10s], to compute cluster state update for [Tasks batched with key: org.opensearch.gateway.GatewayService and count: 1]
[2024-10-12T16:43:27,216][WARN ][o.o.c.s.MasterService    ] [aa6030d2df35ee37b021971c031436d8] took [58.6s], which is over [10s], to compute cluster state update for [Tasks batched with key: org.opensearch.cluster.routing.BatchedRerouteService and count: 1]

This PR https://github.com/opensearch-project/OpenSearch/pull/16421 makes necessary improvements.


Add TLD on CSP frame ancestor

In the future, these headers could be added via environment variables, decoupling from deco knows about the admin URL and allowing users to add their frame-ancestors. Does it make sense?


Regression in several device lab metrics for analyzer_benchmark microbenchmarksweb_benchmarks_html

https://flutter-flutter-perf.skia.org/e/?begin=1604242084&end=1604571480&keys=X3a8d39b49bc8119825b0b6aeb766da91&requestType=0&xbaroffset=22352
Affects the following metrics:
flutter_repo_batch MatrixUtils_persp_transformPoint_iteration bench_update_many_child_layers.html.drawFrameDuration.average bench_update_many_child_layers.html.totalUiFrame.average flutter_repo_batch_minimum flutter_repo_watchflutter_repo_watch_minimum flutter_repo_watch_maximum
Looks like it may be engine roll #69709.

https://flutter-flutter-perf.skia.org/e/?begin=1604242084&end=1604917080&queries=sub_result%3Dbench_update_many_child_layers.html.totalUiFrame.average%26sub_result%3Dbench_update_many_child_layers.html.drawFrameDuration.average&requestType=0&xbaroffset=22352


Parsing tuples

After a bunch of iteration on Zulip, we've got a design for tuples!
Here are the parsing changes involved:

You can now write (x, y), (x, y, z), etc. as an Expr. There can be as many commas as you like, but for it to be a tuple, there must always be at least one comma. There is no().
You can also write them in the same way for Patterns.
You can write them the same way in type annotations, but - just like with records and tag unions - you can also have an "ext var" type variable right after the closing paren. So for example, (Str, Str), (Str, Str)*, (Str, Str)a, and (Str, Str)(Str, Str) should all be valid syntactically.
You can access tuples' fields the same way you can record fields, except instead of like expr.foo, expr.bar, it's expr.0, expr.1 etc. So a dot followed by an integer instead of a letter. This is "tuple access."
You can write .1, .2, etc. and it's a "tuple accessor" function similar to how .x and .y are "record field accessor" functions. So 0.1 is a number, but .1 is a function. (This should be easy to give a nice error message around if people mistakenly try to write .1 as a number, so any confusion should be very short-lived.)

Makes sense!
QQ: For (3), what does (Str, Str)(Str, Str) mean? I assume that would be equivalent to(Str, Str, Str, Str), except in a context where you're refining the type of something like (Str, Str)a, where a = (Str, Str); is that right?

Yeah exactly! 👍

Here's an interesting ambiguity / inconsistency:

(Str, Str)a represents a tuple that has at least two fields and maybe other fields (as specified by a)
Similarly, we have (Str, Str) that has exactly two fields
A corresponding value would be ("a", "b") - all good so far.
1-element tuple values don't exist, and neither do 0-element ones
However, should types for those exist, like (Str)a - a tuple with at least one string field, and maybe others?
Or ()a, representing a tuple has some unknown fields

(Str)a seems probably useful, but it already breaks symmetry with single-element tuples (which don't exist). But what about ()a? It feels weird not to allow that as a degenerate case, but it also feels weird to have that, from a symmetry perspective.

Whoops forgot to mark this one done


[filegen] move plansdk.FlakePlan and plansdk.FlakeInput

Summary

move plansdk.FlakePlan and plansdk.FlakeInput into filegen and make both internal to the package.
move impl.FlakePlan() to filegen.newFlakePlan() (note, it is internal)
move impl.FlakeInputs() to filegen.flakeInputs() (again, internal now)

How was it tested?

Current dependencies on/for this PR:

main

PR #1187

PR #1188

PR #1189

PR #1190

PR #1191   👈

This comment was auto-generated by Graphite.

Discussed offline with Lucille that I did originally envision filegen to be for files in .devbox/gen. We'll rename it to devboxgen , since filegen sounds too generic.


fail complile in compile.exe and in sourcemod.net/compiler.php

could u give a .smx?thx bro

dude, this is 3 years old. it was written for sourcemod 1.7 or something like that.
I don't have any intention of updating the mod, I doubt you'd need to change anything major, so if you have some experience in programming you should be able to figure it out.
Even if I gave you a .smx I doubt it would run on modern SourceMod


API call (partially) unauthorized

Hi there,
not sure if this is the right place to post my question, but here it goes anyway.
I noticed that the History-Tile is not working in TIleboard for me, it doesn't show a graph and I get an error popup, saying the api call return with code -1.
So I extracted the call from the debug terminal, and it looks something like this:
curl -X GET \
  https://homeassistant.<MYDOMAIN>/api/history/period/2021-07-08T07:49:34.386Z?end_time=2021-07-08T07:50:04.386Z&filter_entity_id=<SENSOR> \
  -H 'Authorization: Bearer <MYTOKEN>‘

It fails with 401 unauthorized.
The weird thing is, if I remove the last variable (filter) it works:
curl -X GET \
  https://homeassistant.<MYDOMAIN>/api/history/period/2021-07-08T07:49:34.386Z?end_time=2021-07-08T07:50:04.386Z \
  -H 'Authorization: Bearer <MYTOKEN>‘

This works perfectly fine, my HASS instance is hosted as a subdomain behind an Nginx reverse proxy.
Any idea what the root cause of this is?

It is probably related to #386

I can't confirm that removing the filter makes it work. Fails the same way for me. I think it's just #386.

The curl might be failing the request because the URL is unquoted. Maybe try something like:
curl -X GET \
  'https://homeassistant.<MYDOMAIN>/api/history/period/2021-07-08T07:49:34.386Z?end_time=2021-07-08T07:50:04.386Z&filter_entity_id=<SENSOR>' \
  -H 'Authorization: Bearer <MYTOKEN>'

In any case, the issue that makes it fail in the browser is related to CORS and CORS doesn't apply when using curl so it's not really relevant to test with curl.

Duplicate of #386


support network interface for haaseduk1. #1642

感谢提交 Pull Requests！
Thanks for submitting a pull request.

auto build fail,number:122

Security Check : 56ebcc091057b81381d6bcb057ba677fa6d85d5f

abandon


error if i m hiding select2 from  page

i have select on user page and it is on create page if user is updating after create then i m hiding select2,then it is giving me this error and below is attachment,
i m not hiding select2 exactly ,i have php if condition where it is not showing if user is on update.
old version was working good ,no issue but this is giving me error.

If you look at the first error, I think it makes it clear what the issue is.

The select2('data') method was called on an element that is not using Select2.

You can't use select2('data') without calling select2() first.

@kevin-brown then how to use select2 call can u help me


Support showLinkMeta property to post a message

Typetalk Post message API support to not show OGP data of URL included in message.
https://developer.nulab-inc.com/docs/typetalk/api/1/post-message/

Name
Type
Description

showLinkMeta (Optional)
Boolean
show OGP data of URL included in message. default value: true

This PR allows to pass the option.
Response is same with or without the option.
I would like you to release new version after you review and merge this PR.
Because fluent-plugin-typetalk wants to support the option.

@tsuyoshizawa Thank you for your pull request. I've released 0.1.0. check this out, please.

Thank you!


[BEAM-308] Mark test PipelineOptions interface public

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[x] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

This is a work-around for [BEAM-308], which causes flakey test runs. We should also fix the root-cause, in a separate PR.

R: @bjchambers

LGTM


Answer Error Issue

Hi, I think I briefly tested the answers you added three days ago and made a pull request to fix the error,  I think today my friend was doing the homework and she asked me why the "official answer" is not working, would you please check my pull request or just modified the tiny errors inside your code?  Thank you so much for this amazing open source course:)!

Closing as it was fixed by PR #257


[1.20] Unable to enable Linkerd

Unable to enable linkerd on 1.19 and 1.20.
This is because linkerd 2.9.0 binaries does not exist in the releases page. Updating the version to 2.9.2, which contains some critical fixes.

Code merge closing

Sorry about that. We removed those binaries because there was a problem with that release.


Import inventory, organizations, orders and donations/purchases from 7-1 to release

Import inventory, organizations, orders and donations/purchases from 7-1 to release

This has been done via code not in the repo


How to determine wich report user is requested

Flowing instruction here on web I managed to start debugging security extension on  SSRS2017.
Before I start implementing my own logic, I am wondering , is there a way to implement security per folder / report.
When I attach visual studio debugger,VS hit break point at CheckAccess methods.
Bud I do always get null for secDesc parameter.
I do get username , userToken is also always "0x0000000000000000".
,secDesc is also alwys null.
Did my setup missing something or is there any other method to implement so I can check  whic folder / report user is requesting

The username and usertoken should match what was provided by your Authentication Extension. The securityDescriptor should be the one your authorization extension returned when CreateSecurityDescriptor was called. So I suggest placing breakpoints there to see the flow, that would be called when the item is created and provided during check access. Note that since the authorization model for ssrs allows for inheritance, you will not have one per item (they would by default just inherit from the parents permissions).

@gboreki  > CreateSecurityDescriptor
I do not why but I cant get event to hit break point in CreateSecurityDescriptor .
When I did set permissions for user on Report Portal now I am getting secDesc in requests.
Do I need manually to call CreateSecurityDescriptor or it does report server.

Apologies for spamming
Looks like I figured how it is works.
Can someone please confirm am I understanding thins correct:
methods CheckAccess receiving params   secDesc and username.
secDesc param holds permissions set on SSRS item (eg report, folder, datasource).
in CheckAccess methods we need to check does username parameter maching in secDesc.
If secDrescrpion contains macing username with matching requierd operation metho retun true for autorization?

@adopilot I am in the same boat as you were. I can't seem to hit the CreateSecurityDescriptor. How did you solve it? Can you please share.


Fix systemd unit

without the [install] part, the systemd unit won't activate

without the [install] part, the systemd unit won't activate

thanks, man! Very helpful!

You might want to add User=someone because otherwise it is run as root. Especially the worker complains about that...

makes sense. In docker image app runs as user=www and group=www. Thank for the tip!


[v2.9] Fix Qase reporting timeout failure

Issue:

Problem
 Where there is a timeout failure in a go test the Qase reporter fails
Solution
 Updated parsing to account for parsing timeout failures
Testing
 Ran on Qase
Engineering Testing
Manual Testing

Automated Testing

Test types added/modified:

Unit
Integration (Go Framework)
Integration (v2prov Framework)
Validation (Go Framework)
Other - Explain: EXPLAIN
None
REMOVE NOT APPLICABLE BULLET POINTS ABOVE

If "None" - Reason: EXPLAIN THE REASON

If "None" - GH Issue/PR: LINK TO GH ISSUE/PR TO ADD TESTS

Summary: TODO
QA Testing Considerations

Regressions Considerations

TODO
Existing / newly added automated tests that provide evidence there are no regressions:

TODO

Backports:

https://github.com/rancher/rancher/pull/44888
https://github.com/rancher/rancher/pull/44890


Change package name to com.microsoft.signalr

Changing the package name from com.microsoft.aspnet.signalr to com.microsoft.signalr
Fixes: #3091
//cc @JonathanGiles look at what we're doing!

Don't forget to link the issue 😸

Great work! My powers know no limits :-)

// cc @muratg just to make sure it's visible that we're changing the package name

We've got the approval so as long as everything builds correctly we should be able to ship to this groupId.

@mikaelm12 when this is merged, please post to aspnet/Announcements describing the upcoming change in preview3. Make sure to follow the pattern of creating an issue on aspnet/SignalR to discuss the change and locking the Announcements issue (to avoid spamming the people following that repo)


Update read_data_test.rb to work with secured endpoints

Summary
Pulls out the Bearer token from the posted UDS+ manifest if it is part of the manifest.
Then uses relevant token in followup request for the given Bulk FHIR file.
Enables testing against FileRequest endpoints that require an authenticated request.
Resolves #22

Per the response of @ljtucker on issue 22, authentication is out of scope for this iteration of the test kit.

In that case, I'll add on some of my thoughts to that chain.
I think this should be in scope for the current version of the test kit, and I'm happy to make any needed changes to the pull request to get this added to the repo.

Hi @hbader93 and @rpassas, we have discussed this addition internally and see the benefit of its inclusion. We would like to integrate this addition into our upcoming release of the Test Kit, which will coincide with the release of v1.0.2 of the UDS+ IG. @hbader93, thank you for your work building this addition! Have you verified that these changes allow the test to successfully extract ndjson data for Import Manifests with AND without bearer tokens?

@ljtucker Sorry for the delay. I spent a bit of time getting a local unsecured instance up and running / connected, but the current code does work both with AND without bearer tokens.

Disclaimer: The data I've been testing with is a bit sparse, so there are a few warnings as to some data being missing, but to me that offers more evidence to it working.


fix CookieJar process set cookie when value has = & HttpClient support custom headers.Cookie

fix CookieJar process set cookie when value has =
fix CookieJar get cookie string, cookie join with ;
remove cookie value encode while server give cookie value
HttpClient support custom headers.Cookie

thanks, that works.
the only thing we might have to adjust is the compatibility to cookie strings that don't have a space after the semicolon. but that's not important i guess.


Question about LocalizedString

hi
Is it possible to use LocalizedString  in class or struct as property ?
if it possible , is there any consideration about it?
thank you

Sure!
Look here in the sample project, where LocalizedString is used as property.
public LocalizedString HelloWorld { get; }
public LocalizedString CounterBtnText { get; }
public LocalizedString CurrentCulture { get; }

public MainPage(ILocalizationResourceManager resourceManager)
{
    InitializeComponent();
    this.resourceManager = resourceManager;

    HelloWorld = new(() => $"{resourceManager["Hello"]}, {resourceManager["World"]}!");
    CounterBtnText = new(() => GetCounterBtnText());
    CurrentCulture = new(() => resourceManager.CurrentCulture.NativeName);

    BindingContext = this;
}

Like this, you could declare LocalizedString as property in e.g. your ViewModels.
To reference these properties from XAML it looks like this:
<Label
    FontSize="32"
    HorizontalOptions="Center"
    Text="{Binding HelloWorld.Localized}" />

Answer your question?

This is great .
There  is another question  .
is there  any way to translate small dataset (such as filter criteria for search) by using online translate service API (such as google translate) at run time ?
is it  possible  to replacing AppResources file by online translate service ?

I could be done by building a custom ResourceManager that uses a translation service for text lookup. That could then be added and used by this plugin!
Maybe I will create a extension for this plugin that will do this. ;)


[Backend] Db Server Stats

partially closes #10

@AKlaus created as draft at-the-moment since I haven't fully tested it yet. You can go ahead and provide any remarks if you want.

Hi @yj7o5,
Thank you for submitting a PR. I'll write notes on the files and some here when they're applicable to multiple files.

Need automated tests to cover the new functionality. We aren't aiming 100% coverage but the main goal is to ensure that the feature works in principle and all fragile bits (usually, integration points) a covered by tests
All the new DTOs shouldn't be added to Database.Common project (it's a shared project with common classes between Database and Domain, see the diagram here). The best way would be to add another service to Domain project (e.g. call it ServerStatsService). Put all the DTOs into a subfolder of the service folder.
The preferable way to communicate with the server by using the existing IDocumentStore rather than via HTTP. See this link.

Thanks @AKlaus will go ahead and perform the changes.

Closing it, as it appears abandoned by the submitter (idle for more than a year)


[FLINK-13109][docs-zh]Translate "Restart Strategies" page into Chinese

初次翻译，请多指教。

very good!!!

It's a great honour to me. Thank you all very much.


Timescale

Multiple timescales support

PR Review Notes:
TODO:

Fix all RUFF code style guide violations
Fix the SimReport and TestSpec redefinitions in the new test file, currently the tests are not testing the actual code (this should also fix older python version builds)
Add similar warning for not specifying time units to StrsSpec and 'append_steps', currently they implicitly default to hours
helpers.py already had a time conversion helper function that is also nicer in that it can go both ways, can we merge the two new ones into _convert_time in an elegant way so that the implementation is less clunky than the current design? SimReport/export_to_json is also similarly clunky

Changed in b072a1e:

Moved time unit handling to MechMdl instead of duplicate code in DegMechMdl and FailMechMdl
Fixed up demo scripts to match current package dependencies, require numpy <2.0
Shortened sim.py changes

Correction: All lint errors are due to new codes and are unrelated to the timescales changes, do not need to fix to merge this PR


Improve Education

Add online tutorials, e.g.

Introduction to Python: a jupyter notebook on Google collab, and you can do it in 2 or 3 hours

added @R workshops
TODO: introduction to Python (Colab)


Not connecting to phone after Creators update.  I cannot connect in both Remote and Photo Gallery modes. Perhaps this is after Creators update. It does work on PC though.
My camera is Sony Nex-6. It used to work very well before.

Can you try re-install Locana?
Something might broken by OS upgrade.

I did it. I tried restarting the phone, resetting the app, removing and installing the app but unfortunately nothing worked. :(

I'm sorry I bothered you. I removed the saved wi-fi connection to the camera and set it up again. And after restarting Locana it found the phone! I was so afraid the app didn't support Creators update. Now I'm happy again! :)

Umm... Can you get debug logs and send it to us?

Connect Wi-Fi to camera.
Open side menu in Locana and select "About Locana"
"Advanced settings" -> Enable "Debug logging mode"
Open side menu in Locana and select "Remote"
Wait for about 1 minutes.
Open side menu in Locana and select "About Locana"
"Advanced settings" -> Disable "Debug logging mode" and allow to attach to e-mail
Send it to us.

Debug log is not needed anymore, is it? Thanks!

Oh, that's great. Enjoy our app!

I really do! Thank you!


[Android] Problem with pinch-to-zoom

The pinch-to-zoom doesn't work correctly. When I zoom in on the image and remove one finger, the image will jump. It happens only on Android.
I used the latest version of react-native-awesome-gallery (0.4.2). My react-native version is 0.74.5 and react-native-gesture-handler 2.18.1. Also, I tried to use different versions of react-native-gesture-handler and react-native. This problem appears starting from a version of react native 0.73+.
Here's a video of how it works on Android
https://github.com/user-attachments/assets/10748077-823d-4a0c-a189-262f38472945

I have same issue

same here!

It seems that this line is causing the trouble:

https://github.com/pavelbabenko/react-native-awesome-gallery/blob/0d7d4911a95c4864ee420bb7c4aa548eb30a2a81/src/index.tsx#L412

After commenting it out the focal is correct and the image is properly zoomed.

@efstathiosntonas I confirm removing this line fixes the issue on android, thanks!


Add spellchecker to build time

Everyone makes mistakes! I can't spell or type well.
Adding this utility as a check at the beginning of the build (check everything past the frontmatter) would be amazing.
It should fail the build if a spelling error is found.
Questions to answer:

Can we add ignore words?
Will it fail on acronyms?
Can we add words we would like to not publish anymore - e.g. We change the name of a featur and we want to identify every use of the old name

Nice article related on this
https://blog.codeship.com/improve-documentation-by-automating-spelling-and-grammar-checks/

@mamat-rahmat I got an email notification that you had added a link to this article (but it looks like you deleted it?): https://blog.codeship.com/improve-documentation-by-automating-spelling-and-grammar-checks/
Adding it back in because I think it's very on point

@ksigler7 sorry for deleted that. The article talk about node-based tool. I was doubt that it was unrelated.
Btw, is ruby-based package preferred here? or open to others? (like node/python)

Seems like (spellchecker)[https://rubygems.org/gems/spellchecker/versions/0.1.5] is lack of feature unmaintained.
I am researching about alternative tools. Gonna post about the result soon.

@mamat-rahmat - I don't think it necessarily needs to be ruby based as long as we can still incorporate it into our build

Looking at this. According to the article @mamat-rahmat first posted, markdown-spellcheck with npm could work? I could just add the check in the build scripts in package.json. Is that what you are looking for in this project? @ksigler7


Increase padding for the Button

Your task is very simple - just increase the padding for the Button component.
Steps to accomplish the task:

If you haven't done already, create a new branch that you'll make your changes on.
Navigate to the file, src/common/styles/_variables.scss
Find the line that says $btn-padding: 5px 40px;
Change the padding to 8px 45px or something better.
Follow the steps to submit your PR.

I want to contribute - Team Blaise

hii, me and Zoe from Min Hao group would like to  contribute this issue


chunkc tiling::monitor -f 2 goes to 3rd monitor

Hi 😄
I have 3 monitors.
And I always put only a window onto a monitor.
Now I put

iTerm2 window onto 1st monitor
Vivaldi window onto 2nd monitor
Vivaldi window onto 3rd monitor

also I do chunkc tiling::monitor -f 2,
then it goes to the 3rd monitor 😭
I want to go to 2nd monitor.
But if I arranged to

iTerm2 window onto 1st monitor
Vivaldi window onto 2nd monitor
non Vivaldi window onto 3rd monitor

and I do chunkc tiling::monitor -f 2, it works finely.
Please help me :joy:

This is a limitation of the macOS API that is used. There is a way around this if you install the scripting addition (chunkwm-sa), but then you need to disable SIP on your system.
Sent from my iPhone
On 14 May 2019, at 06:24, aiya000 <notifications<EMAIL_ADDRESS>wrote:
Hi 😄
I have 3 monitors.
And I always put only a window onto a monitor.
Now I put

iTerm2 window onto 1st monitor
Vivaldi window onto 2nd monitor
Vivaldi window onto 3rd monitor

also I do chunkc tiling::monitor -f 2,
then it goes to the 3rd monitor 😭
I want to go to 2nd monitor.
But if I arranged to

iTerm2 window onto 1st monitor
Vivaldi window onto 2nd monitor
non Vivaldi window onto 3rd monitor

and I do chunkc tiling::monitor -f 2, it works finely.
Please help me 😂
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/koekeishiya/chunkwm/issues/623?email_source=notifications&email_token=ABPDZV7NDYDV4TLSNWQSURTPVI5G3A5CNFSM4HMVZIKKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GTSMIJQ, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABPDZV5ZFBAWBES7TGXW4M3PVI5G3ANCNFSM4HMVZIKA.

See the first comment in issue #511 for more information.

After install chunkwm-sa, it works finely.
I like chunkwm!
Thanks so much!
https://koekeishiya.github.io/chunkwm/docs/sa.html


npm package is incompatible with Vite 4.0.0 or higher.

Error when installing with Vite 4.0.0 or higher:
> npm install --save-dev vite-plugin-html-minifier
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/vite
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/vite-plugin-html-minifier
npm ERR!   dev vite-plugin-html-minifier@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Please update the npm package to enable Vite 4 compatibility.

Works well! Thank you for the update.


MyCommand - custom permissions not working

So you may have heard about a plugin called "MyCommand it allows you to create aliases, menus, clickable NPCs, clickable blocks, etc...
If you create a custom alias and set a custom permission for that, that permission will not work.
Example:
send-arcade:   command: /cmd-server-arcade   type: BUNGEE_TP   server_name: arcade   delaytimer: 3   permission-required: true   permission-node: mycmd.server.defaults
so the required permission should be mycmd.server.defaults but even if i add it to the user itself or the default group, it does not work. It is not checked my LuckPerms
Regards.

Please do the following:

Run /lp verbose record <your username>
Run the send-arcade command
Run /lp verbose paste, and paste the link it gives you back to me.

Hello.
I reinstalled the whole thing and seems like it works.
I don't know why it did not work before, i suppose my configuration...
I request lock.
Regards, thank you for such a good resource 😄


 The task.Kill request cares about the exec-id.
Note: in task.go and process.go, KillRequest never utilized KillInfo's Process so I removed it
Signed-off-by: Jess Valarezo<EMAIL_ADDRESS>

Codecov Report

Merging #1742 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1742   +/-   ##
=======================================
  Coverage   48.58%   48.58%
=======================================
  Files          28       28
  Lines        4250     4250
=======================================
  Hits         2065     2065
  Misses       1750     1750
  Partials      435      435

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17093c2...5b1dd97. Read the comment docs.

LGTM

LGTM