"Attempt to authenticate with a custom backend failed" is logged as error, should be info?

Hi @aleksihakli,
We recently ran into a small but somewhat annoying issue. We are using django rest framework with pyjwt to authenticate from our mobile app. This means no request is available which is not a problem for django but it does trigger an error when axes tries to log the login attempt. I have linked the commit where the logging was changed from info to warning.
https://github.com/jazzband/django-axes/pull/274
While I've read the comments along the commit it remains unclear to me why it should be an error instead of info or, at most, a warning. After all nothing terrible happens, axes simply does not have enough info to log this access attempt without the request info. It would be great if this could be changed.
As a side note we would like to use Axes for login attempts from our app as well. Work on that will start shortly, its a high priority for us. If such functionality is already in the making, or you have specific idea's on how to approach it, I am all ears!

Please open a PR for fixing the related code if you wish to change the log level :)
As a side note, you will need to customize axes to read the correct variables in your custom application depending on your method of authentication. Please refer to examples and source code for usage.

Please open a PR for fixing the related code if you wish to change the log level :)

I will do that! Thanks for providing me a link to the examples, that will certainly come in handy.


Fixes bug where show all directory results doesn't do anything

Fixes bug where the 'see all directory results' link doesn't do anything.
Pretty sure that the bug was introduced long ago.  Fixes, but no unit tests to prevent this in the future.
This button:

ignore my (successful by not great looking) attempt at censoring
It now shows all directory results

Contributor License Agreement adherence:

[x] This Contribution is under the terms of Individual Contributor License Agreements (and also Corporate Contributor License Agreements to the extent applicable) appearing in the Apereo CLA roster.

coverall failure due to threshold of 31% test coverage not being met.  I've lowered the threshold.


Replacing static home icons by dynamic icons

Is it possible to replace the static home icons defined in the .plist by the dynamic ones ?

You should Google that - this plugin simply does what Apple intended quick items to do.


Function Search to creating a connection list only non-racked device

Environment

Python version:  3.6.7
NetBox version:  2.5.9

Steps to Reproduce
1.Go on device
2.Select "Connect" on one interface
3.Search a device with "Search" function
Expected Behavior
List all device, and can filter if we write anything
Observed Behavior
List only non-racked device and finally "search" become unusable

Caused by rack_id=null not showing all racks.

Looks like this was added in f6345b9a5d503ed72e9f78a7bb0dc6fbd0347b35 inadvertently

Darn, I just picked this up too :-)  When searching for "wrn", tcpdump shows:
GET /api/dcim/devices/?q=wrn&brief=1&limit=50&offset=0&rack_id=null

... so it only matches unracked devices.


fix: Only check encryptionScheme when is not null and not empty string

Fixes https://github.com/shaka-project/shaka-player/issues/7057

According to https://w3c.github.io/encrypted-media/:

null is the default value
empty string whould be treated as an unrecogniezed encryption scheme, in our case we assume that any encryption scheme would be valid.


Alluxio Fuse GC failure

Hi,
We have seen our alluxio fuse pod keep get GC failure after running sometime. We have to manually restart pod. Is there setting related to alluxio fuse pod GC?

[Eden: 0.0B(1632.0M)->0.0B(1632.0M) Survivors: 0.0B->0.0B Heap: 32689.1M(32768.0M)->32689.1M(32768.0M)]
[Times: user=0.00 sys=0.00, real=0.00 secs]
2021-05-13T01:21:58.732+0000: 61322.243: [Full GC (Allocation Failure)  32689M->32689M(32768M), 7.3094920 secs]
[Eden: 0.0B(1632.0M)->0.0B(1632.0M) Survivors: 0.0B->0.0B Heap: 32689.1M(32768.0M)->32689.1M(32768.0M)], [Metaspace: 29241K->29241K(34816K)]
相关日志，
相关参数设置：
fuse:
env:
MAX_IDLE_THREADS: "64"
image: alluxio/alluxio-fuse
imageTag: 2.5.0-2
imagePullPolicy: IfNotPresent
Change both to true to deploy FUSE
enabled: false
clientEnabled: false
Properties for the fuse component
properties:
alluxio.fuse.jnifuse.enabled: "false"
alluxio.fuse.shared.caching.reader.enabled: "true"
alluxio.fuse.debug.enabled: "true"
alluxio.fuse.cached.paths.max: "3000000"
alluxio.fuse.logging.threshold: 1000ms
alluxio.fuse.user.group.tranlation.enabled: "true"
Customize the MaxDirectMemorySize
These options are specific to the FUSE daemon
jvmOptions:
- "-Xmx32G -Xms32G -XX:+UseG1GC -XX:MaxDirectMemorySize=64G -XX:ActiveProcessorCount=4 -XX:+UnlockExperimentalVMOptions -XX:+PrintGC -XX:+PrintGCDateStamps -XX:+PrintGCDetails -XX:+PrintGCTimeStamps"
hostNetwork: true
hostPID requires escalated privileges
hostPID: true
dnsPolicy: ClusterFirstWithHostNet
user: 0
group: 0
fsGroup: 0
args:
- fuse
- --fuse-opts=kernel_cache,max_read=131072,attr_timeout=7200,entry_timeout=7200,allow_other
Mount path in the host
mountPath: /mnt/alluxio-fuse
resources:
limits:
cpu: 4
memory: 96G
requests:
cpu: 4
memory: 96G
podAnnotations: {}
nodeSelector:
alluxio: worker

Hi @AlexChenSkyBlue thanks for reporting this issue. Are you on Java 8 or 11? We recommend to use concurrent mark and sweep instead of G1GC -XX:+UseConcMarkSweepGC

We are using official docker image which is using java 8. Do you suggest we switch to java 11? we will try the jvm option

No, I suspect it may due to our cluster has large amount of data reader, over 100T per day. We use this option:
alluxio.fuse.shared.caching.reader.enabled = true. We try to disable it to see if it improve

After we switch to jnifuse with client cache disabled. this problem seems goes away


Throw exception for the wrong field name case

Fix #1

@protolambda it seems a PR doesn't trigger the CI, could you enable it?


Verbose mode breaks some commands

Using the -v flag breaks some commands (tested with 0.13.0b1 installed via pip)
For example, the commands below result in a traceback:
$ globus-automate flow get 23392c51-17b6-4558-bb56-dc915e1faf39 -v
$ globus-automate flow list -v

Traceback (most recent call last):
  File "/home/david/venvs/cfde/bin/globus-automate", line 8, in <module>
    sys.exit(app())
  File "/home/david/venvs/cfde/lib/python3.8/site-packages/typer/main.py", line 214, in __call__
    return get_command(self)(*args, **kwargs)
  File "/home/david/venvs/cfde/lib/python3.8/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/home/david/venvs/cfde/lib/python3.8/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/home/david/venvs/cfde/lib/python3.8/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/david/venvs/cfde/lib/python3.8/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/david/venvs/cfde/lib/python3.8/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/david/venvs/cfde/lib/python3.8/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/home/david/venvs/cfde/lib/python3.8/site-packages/typer/main.py", line 497, in wrapper
    return callback(**use_params)  # type: ignore
  File "/home/david/venvs/cfde/lib/python3.8/site-packages/globus_automate_client/cli/flows.py", line 459, in flow_list
    RequestRunner(
  File "/home/david/venvs/cfde/lib/python3.8/site-packages/globus_automate_client/cli/rich_helpers.py", line 441, in run_and_render
    self.render(result)
  File "/home/david/venvs/cfde/lib/python3.8/site-packages/globus_automate_client/cli/rich_helpers.py", line 421, in render
    Renderer(
  File "/home/david/venvs/cfde/lib/python3.8/site-packages/globus_automate_client/cli/rich_helpers.py", line 370, in render
    d = self.details_as_text
  File "/home/david/venvs/cfde/lib/python3.8/site-packages/globus_automate_client/cli/rich_helpers.py", line 309, in details_as_text
    return Text(self.result.details, style=self.detail_style)
  File "/home/david/venvs/cfde/lib/python3.8/site-packages/globus_automate_client/cli/rich_helpers.py", line 247, in details
    return get_http_details(self.result)
  File "/home/david/venvs/cfde/lib/python3.8/site-packages/globus_automate_client/cli/helpers.py", line 40, in get_http_details
    base_request = result.data["request"]
KeyError: 'request'

Thanks for the report @DavidKelly999! It looks like the fix from #108 should resolve this once it's released.

David, we've released 0.13.0b2, which should fix this issue. Please let us know if you encounter additional issues, and thank you again for testing this!


Homebrewed Wormhole on an M1 not working

I have installed Wormhole on an M1 Mac (macOS 12.6 Monterey) both directly and from source
brew install --build-from-source magic-wormhole
brew install magic-wormhole
Running wormhole fails similarly in both cases:
➜  ~ wormhole receive 67-hideaway-adrift
Traceback (most recent call last):
  File "/opt/homebrew/bin/wormhole", line 33, in <module>
    sys.exit(load_entry_point('magic-wormhole==0.12.0', 'console_scripts', 'wormhole')())
  File "/opt/homebrew/bin/wormhole", line 25, in importlib_load_entry_point
    return next(matches).load()
  File "/Users/avs/Applications/QGIS.app/Contents/Resources/python/importlib/metadata.py", line 77, in load
    module = import_module(match.group('module'))
  File "/Users/avs/Applications/QGIS.app/Contents/Resources/python/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 992, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 992, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/opt/homebrew/Cellar/magic-wormhole/0.12.0_7/libexec/lib/python3.10/site-packages/wormhole/__init__.py", line 1, in <module>
    from ._rlcompleter import input_with_completion
  File "/opt/homebrew/Cellar/magic-wormhole/0.12.0_7/libexec/lib/python3.10/site-packages/wormhole/_rlcompleter.py", line 8, in <module>
    from twisted.internet.defer import inlineCallbacks, returnValue
  File "/opt/homebrew/Cellar/magic-wormhole/0.12.0_7/libexec/lib/python3.10/site-packages/twisted/internet/defer.py", line 44, in <module>
    from twisted.internet.interfaces import IDelayedCall, IReactorTime
  File "/opt/homebrew/Cellar/magic-wormhole/0.12.0_7/libexec/lib/python3.10/site-packages/twisted/internet/interfaces.py", line 26, in <module>
    from twisted.python.failure import Failure
  File "/opt/homebrew/Cellar/magic-wormhole/0.12.0_7/libexec/lib/python3.10/site-packages/twisted/python/__init__.py", line 9, in <module>
    from .deprecate import deprecatedModuleAttribute
  File "/opt/homebrew/Cellar/magic-wormhole/0.12.0_7/libexec/lib/python3.10/site-packages/twisted/python/deprecate.py", line 755, in <module>
    ) -> Callable[[_Tc], _Tc]:
  File "/Users/avs/Applications/QGIS.app/Contents/Resources/python/typing.py", line 875, in __getitem__
    return self.__getitem_inner__(params)
  File "/Users/avs/Applications/QGIS.app/Contents/Resources/python/typing.py", line 265, in inner
    return cached(*args, **kwds)
  File "/Users/avs/Applications/QGIS.app/Contents/Resources/python/typing.py", line 888, in __getitem_inner__
    return self.copy_with(params)
  File "/Users/avs/Applications/QGIS.app/Contents/Resources/python/typing.py", line 860, in copy_with
    return _CallableGenericAlias(self.__origin__, params,
  File "/Users/avs/Applications/QGIS.app/Contents/Resources/python/typing.py", line 729, in __init__
    self.__parameters__ = _collect_type_vars(params)
  File "/opt/homebrew/Cellar/magic-wormhole/0.12.0_7/libexec/lib/python3.10/site-packages/typing_extensions.py", line 136, in _collect_type_vars
    if _should_collect_from_parameters(t):
  File "/opt/homebrew/Cellar/magic-wormhole/0.12.0_7/libexec/lib/python3.10/site-packages/typing_extensions.py", line 110, in _should_collect_from_parameters
    t, (typing._GenericAlias, _types.GenericAlias, _types.UnionType)
AttributeError: module 'types' has no attribute 'UnionType'. Did you mean: 'FunctionType'?

And now I see the problem, which is a borked Python installation.


how to handle dataset that is too large to be loaded in the memory?

Suppose I have a dataset of 3000w items, each item is a 2048-d vector.
Thanks

what exactly is the size,  didnt get 3000w? in principal, if you cant load the data in the memory, you need to use/develop some mechanisms to handle this, e.g. data parallel /map-reduce implementations etc,. With FINCH it should be more practical, as you can compute the first neighbors using e.g., ANN methods that process data by mapping it to hash codes and then use these to load into memory and/or compute 1-NN.  One can imagine how you can build a processing chain with data read/write operations to handle  very large data.

thanks


thodsathon

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Thanks for the thumps up. Did you want to add a feature request or report a bug?

Close this because not information was provided.


Add poisson_regression_loss

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (bf395dd) to head (3c13adc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #369   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          102       103    +1
  Lines         3198      3206    +8
  Branches       267       267
=========================================
+ Hits          3198      3206    +8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Check the request method before redirecting to login page

Description
On rare events when an ajax request triggers the session timeout, and loads the
login page, the startup page will be a page not found error.
This PR prevent the page not found error in this cases. In the cases of an ajax POST request that triggers the timeout, we will answer with an unauthorized replay and not redirect to the login page.
Sceenshot

Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1341664
https://bugzilla.redhat.com/show_bug.cgi?id=1370202

@miq-bot add_label providers/containers, bug
@simon3z @zeari @alongoldboim please review

A Note about the foreman specs
In spec/controllers/provider_foreman_controller_spec.rb we alter two tests.
This tests where false positive, they got response status 200 OK, but it was from the login page and not from a valid response for the test query.
After this PR any POST request without a valid credentials will get response status 403 Forbidden.

@yaacov why are we touching foreman specs?

@simon3z

why are we touching foreman specs?

The foreman specs are checking that the http response is 200-OK.
The request did not do what they intended to do, but they where successful because they got 200-OK from the login page ( they where redirected to it when authentication failed )
After this PR, ajax POST is no longer redirected to the login page, but return an "unauthorized" Error.
To fix the tests you have to login before running the ajax, now they actually work and return 200-OK.

@miq-bot add_label darga/yes
https://bugzilla.redhat.com/show_bug.cgi?id=1370202
cc @moolitayer @dclarizio

LGTM

@yaacov this fix does not resolve the described issue. The unauthorized response causes the page to be stuck with the revolver and manually going to the login page still redirects to the same url.
@martinpovolny @himdel Could you please provide feedback on how to resolve this?

@moolitayer :+1: changed the logic of preventing an ajax request from setting session[:start_url]
moved from checking for POST , to setting session[:start_url] only for requests that has html format.
This make more sense since we want to have a .html page waiting for us after we login, we do not want to be sent to a .js page after we login.

@yaacov this version makes sense to me. What is the behavior now? (redirect? what happens after the login?)
@martinpovolny  @himdel does it makes to not set start_url for ajax|js requests (curious, what are format.js requests?)

hat happens after the login?

@moolitayer when session[:start_url] is not set we are redirected to the default startup page. This is not a best solution, but it's beter than redirecting the user to a page not found.
@martinpovolny @himdel is their a way to know what was the last valid url ?

@martinpovolny could you please review

@dclarizio can we get a ui review please

I'm not sure this makes sense. There are URLs which are perfectly happy to respond both to format.js and to format.html - and rejecting them simply because an ajaxy transition was requested sounds wrong - I think what you really want to check for is whether it was a POST request or a GET request..

..Also, the reverse is true, format.html does not imply you can GET it..

@himdel :+1: thanks, changed the logic to GET vs POST

Thanks, I think this looks good, the code can cope just fine with the value being nil.. Should work :) :+1:

LGTM :+1:

Thanks @himdel

This bug is darga/yes, needs back-porting:
https://bugzilla.redhat.com/show_bug.cgi?id=1370202

This bug is darga/yes, needs back-porting:
https://bugzilla.redhat.com/show_bug.cgi?id=1370202

cc @chessbyte

Darga Backport details:
$ git log

commit 71e564dd576596390c3e4dbb2f9150707f02cc51
Author: Martin Povolny<EMAIL_ADDRESS>Date:   Thu Sep 1 15:59:30 2016 +0200

    Merge pull request #10702 from yaacov/prevent-ajax-calles-from-setting-the-startup-page

    Check the request format before setting the redirection after the login page
    (cherry picked from commit d9e7b3e21723687dd12be96084875fdc75e32e88)


Update resource pattern for policy validation

Issue #, if available:
fix #3334
Description of changes:

Update resource pattern for policy validation

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks!


Pause Song

What is your question?
Is there any way to get which song will play on the pause screen?

Yep, it's getPropertyFromClass('PauseSubState', 'songName') I believe
setPropertyFromClass('PauseSubState', 'songName', 'breakfast') --song must be in /music
to change the pause music

Ok thank you...


Figure out how to add map points to the google maps api

The implementation comes from the google maps api docs. The nice thing is, we can add images and text pretty easily for when the pointer is clicked.


Follow redirects when downloading AEM.

AEM download links are now redirecting from nexus.bsl.eur.adobe.com to artifactory.corp.adobe.com. Adding the -L flag to curl makes curl follow the redirect. It may also be correct to update the config to reflect the new location.

This solved problems for me and I think it should be merged. 👍

sorry it took so long to merge - only saw it now...


Use associated types in const generics

Rust Tracking issue: https://github.com/rust-lang/rust/issues/60551
This would allow use to simplify our Fp<P: FpConfig<N>, N> to just Fp<P: FpConfig> (as FpConfig would itself have N as an associated type. The same simplification would occur for our MontConfig and MontBackend.

It'll improve many things like avoiding this Vec but right now they've some odd problem with associated constants used internally not being recognized as appropriately bound: https://play.rust-lang.org/?version=nightly&mode=debug&edition=2015&gist=e1114345b12197fdb922ef1acb2e80ae


[R4R]:add some logic

add some logic after internal audit.

@Sha3nS There are some failed unit tests. Please fix them


feat: allow optimize indices to control index merge behavior

Allow users to specify how many indices to merge together. Can choose a non-negative integer.

Closes in favor of #1841


Add id based 'before' argument to the get_notifications api

Please add in a before argument to the get_notifications API, so that notifications can be fetched in batches. Please make the argument id rather than index based, because the list is constantly changing making the index a moving target.
So, calling the API with limit: 10, before: 9999, would return the ten most recent notifications that came before the notification with id '9999'. Ideally, the result set would not include #9999.

This is done


Beacon of Ruin + Shock Effectiveness

Hello,
Im trying a build using Elementalist's Beacon of Ruin, but I think shock effectiveness is not increasing my damage at all. I created a flask with "50% increased effect of shock" and the damage does not change at all. Can someone explain the reason behind this?
Thanks a lot!

Thank you for the answer but that doesn't solve my question. I know Beacon of Ruin inflicts a 20% shock. My question is, why doesnt the damage increased if I add 50% shock effectiveness? Because that is what is happening

https://pastebin.com/4wzFbqWq
Here is a simple test. Beacon of Ruin is selected. "Enemy is shocked" is selected. I have a flask with '50% increased shock effect'. It doest nothing to the DPS.

From what I understand, the checkbox for "Enemy is Shocked" applies the maximum value of shock (50% increased damage taken).
Checking the "Enemy is Shocked" box can be misleading sometimes if your damage doesn't quite hit the threshold needed for full effectiveness.
Again, this is taken from the same wiki page and explains it better than I could:

The base duration of shock is 2 seconds and the damage increase scales relative to the amount of Lightning damage dealt to the enemy's maximum life. Increased damage from shock is capped at 50% at 10% of the target's maximum life dealt by Lightning damage, scaling down to 0% at no damage. Hits below the minimum threshold of 1% effect are discarded,[1] effectively requiring a hit of 0.2% enemy maximum life. As an example, The Shaper has approximately 20 000 000 life. Minimally shocking The Shaper requires a single hit of 40 000 lightning damage.

Most important bits:

Increased shock effect will reduce the threshold required to reach the cap. For example, with 100% increased Shock effect, a hit that deals 5% of the target's maximum health or more in Lightning damage will apply shock for 50% increased damage.

If that is the case, then it is explained


Browserupdate flag all as bot

Hi,
I have noticed a problem with your script for several days.
For an unknown reason, all browsers have been marked as robots, so they do not display pop-ups.
Can you check it?.
Example of a page with a problem.:
https://www.soft-music.pl/

Thanks for reporting.
This is fixed now.

Fixed in 29b61971b219442d99e2c89e8dfed7f49eb37fa2


how to download images from the topics!

I couldn't download image form the topics, such as http://imgur.com/topic/Awesome/uK5yF

Hello, I added topic support in my fork https://github.com/Szero/imgur-album-downloader


split screen horizontally and vertically simultaneously

like atom

I believe this is a duplicate of #14909

Duplicate of #14909


Get rid of reference to /var/lib/config/puppet-generated

The path was used in TripleO but it no longer makes sense because we'll not use puppet to generate config files.

@kajinamit you should rebase this patch to main. It's not mergiable as is.

Tested with quay.io/ralfieri/openstack-ansibleee-runner:fix-conf-path


LDAP authentication

Are there any plans to add LDAP authentication (against an external LDAP server)?
Maybe something like https://www.unboundid.com/products/ldap-sdk/ could easily be integrated (I'd be happy to contribute in case somebody volunteers to review the code).

Can someone point me in the direction of some docs that show how to do this? I've looked through the docs, but couldn't seem to find LDAP auth.

+1


Update sbt-scalajs, scalajs-compiler, ... to 1.0.0

Updates

org.scala-js:sbt-scalajs
org.scala-js:scalajs-compiler
org.scala-js:scalajs-test-interface

from 0.6.32 to 1.0.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-js" } ]

labels: library-update, semver-major

included in #62


Implement Notification for Blocked Pop-Ups when Generating Order Documents

Current behavior
Currently, our system lacks a clear notification mechanism for users when they attempt to generate order-related documents, but their browser's pop-up blocker prevents the action. This leads to user confusion, as they may not understand why the document generation process is not working.
Expected behavior
A notification that clearly informs users when their browser's pop-up blocker is preventing the generation of order-related documents.
Steps to reproduce the issue

Can you handle fixing this bug by yourself?

[ ] YES
[ ] NO

Environment details

Browser:
OS:
Code Version:

Additional information


updated docs on SIG Release connection

SIG Release has been refining its processes around build/release
staffing and role management.  This obviously bumps into the Security
Release Process.  This process document had a broken link pointing
to an old Release Managers page and the process description had
drifted slightly out of date.  This brings it up to what SIG Release
is currently doing.
Signed-off-by: Tim Pepper<EMAIL_ADDRESS>

/lgtm
/approve


octomap_ros ROS package is not available

This makes all the CI tests fail (build log).

Closing because it's unclear it's just because of octomap_ros or another issue.


Olympia.windows.com link does not work

https://github.com/MicrosoftDocs/windows-itpro-docs/blob/497c6d7ae578004a565841fa6b35392f7f0cb333/windows/deployment/update/olympia/olympia-enrollment-guidelines.md?plain=1#L34
The link "see https://olympia.windows.com/Info/FAQ." directs the user to a 403 web app has stopped error page.

@e0i , Actual article link for  above issue
https://docs.microsoft.com/en-us/windows/deployment/update/olympia/olympia-enrollment-guidelines

@mapalko Thank you for your feedback. Olympia Corp, a virtual corporation was set up to reflect the IT infrastructure of real world businesses and Olympia has been formally retired on October 31, 2022.
Hope this helps!
@yogkumgit This can be closed.
Thanks
Sri

@msbemba Thank you very much for the contribution and sharing this explanation. @mapalko Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


[Core] Zero-copy asdict for InputMetadata

 PR Checklist (Click to expand. Please read before submitting.)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

dataclasses.asdict will deepcopy tensors inside InputMetadata, leading to an avoidable overhead. This PR adds a new method to InputMetadata which will return a dict of fields and their values without copy.
Before:

After:

It seems the deepcopy of dataclasses.asdict is notorious, see https://github.com/python/cpython/issues/88071 .
How about moving to attrs? https://www.attrs.org/en/stable/index.html it is not a builtin package, but just a third-party library.
from attrs import asdict, define
@define
class MyDataClass:
    a: int
    b: list
instance = MyDataClass(1, [2, 3])
data1 = asdict(instance, recurse=False)
assert data1['b'] is instance.b

Its asdict has a recursive parameter.

Here is the whole picture:
import attrs
@attrs.define(slots=False)
class MyDataClass:
    a: int
    b: list
    def __attrs_post_init__(self):
        self.c = None
instance = MyDataClass(1, [2, 3])
data1 = asdict(instance, recurse=False)
assert data1['b'] is instance.b # make sure it is shallow copy
assert "c" not in data1 # make sure asdict only contains annotated fields

I don't think it makes sense to add a third-party library just for this one specific usecase.

Oh, attrs is quite a famous library, and it motivates the builtin dataclasses.
One reason that attrs does not become builtin, is because attrs does not want to be bound with python versions. So you can basically think attrs as an advanced replacement of dataclasses.
e.g. when you want to use new features from dataclasses, you have to upgrade python interpreter; however, with attrs, you just need to update a package.
I vote for attrs because later I plan to refactor vllm/config.py to use dataclass-like features (so that we can easily print/log them for debugging). And I might switch to attrs in all the places.
Open to any feedback :)

I think it's fine if your PR makes use of it, but I don't think it's necessary to couple attrs with this particular PR :)

Then please make sure to rename asdict_zerocopy to _asdict_zerocopy, so that users know this is private and they won't call it.

Then please make sure to rename asdict_zerocopy to _asdict_zerocopy, so that users know this is private and they won't call it.

I think it should be asdict_zerocopy since it's outside InputMetadata?

@Yard1 It seems the CI failed. Could you please double check?

yeah let me see

Should be good now!


Training on a single GPU

Has the example given for training on a single GPU in debug mode been tested to work ok to fully train the model? I want to try training the model since I haven't done it before, but not sure if the settings need to be tweaked to make sure the model turns out properly.

train.py will take about 20GB vRAM to train the default tiny 15M weight model.

I think I have the vRAM covered. Have you run train.py in debug mode? Is it able to complete all the way through without needing to change the training parameters?

The debug run will not produce a working model. If you run train.py without any changes it will stop after 100,000 iterations and should be able to create a paragraph or two. The model will be saved to disk every 20,000 iterations if it has improved so you can test it as the training runs. I have produced models that trained for 100k & 200k iters on tinystories and now 500k iterations on wiki. The tinystories models can create basic coherent stories. The Wikipedia model creates things that look like Wikipedia excerpts but are completely hallucinated.

The debug run will output checkpoints, but each checkpoint will be written over by the next one. I stopped it after it reached over 20k iterations. The models produce an output during inference, but I am not certain if it will continue to converge up to 100k iterations.
I also tried a train.py run in Kaggle and used 2 GPUs, but had to set the batch size to something like 60 to stay under the memory limit with some margin. Compile is set to false because it was having some compatibility issue and wouldn't run.
!torchrun --standalone --nproc_per_node=2 train.py --compile=False --batch_size=60
Does that look correct to being able to successfully train the model?

This is what I have, but I modified the training script slightly. I would need to rerun it without mods if you are comparing it to the standard output. This is running on 2 GPUs, so it's not really relevant to my original question since I was wondering if debug mode could still properly train a model:
2400 | loss 1.5063 | lr 4.997533e-04 | 461.35ms | mfu 2.06%
2401 | loss 1.4834 | lr 4.997530e-04 | 459.82ms | mfu 2.06%
2402 | loss 1.4958 | lr 4.997526e-04 | 458.69ms | mfu 2.06%
2403 | loss 1.4984 | lr 4.997523e-04 | 459.70ms | mfu 2.07%
2404 | loss 1.4848 | lr 4.997519e-04 | 457.45ms | mfu 2.07%
2405 | loss 1.4913 | lr 4.997516e-04 | 458.32ms | mfu 2.07%
2406 | loss 1.5180 | lr 4.997512e-04 | 459.81ms | mfu 2.07%
2407 | loss 1.5500 | lr 4.997509e-04 | 459.08ms | mfu 2.07%
2408 | loss 1.4798 | lr 4.997505e-04 | 460.21ms | mfu 2.07%
2409 | loss 1.5128 | lr 4.997501e-04 | 458.27ms | mfu 2.07%
2410 | loss 1.5132 | lr 4.997498e-04 | 460.12ms | mfu 2.07%
2411 | loss 1.5215 | lr 4.997494e-04 | 457.54ms | mfu 2.07%
2412 | loss 1.5630 | lr 4.997491e-04 | 459.22ms | mfu 2.07%
2413 | loss 1.4953 | lr 4.997487e-04 | 458.48ms | mfu 2.07%
2414 | loss 1.5301 | lr 4.997484e-04 | 459.46ms | mfu 2.07%


try to reproduce async choice error revealed in #1378

/cc @eiriktsarpalis
I run the sample A LOT and it seems to be failing

Failed : FSharp.Core.Unittests.FSharp_Core.Microsoft_FSharp_Control.AsyncModule.Async.Choice repro
  Expected: less than or equal to 4
  But was:  5
at FSharp.Core.Unittests.FSharp_Core.Microsoft_FSharp_Control.AsyncModule.Async.Choice repro() in C:\projects\visualfsharp-3dtit\src\fsharp\FSharp.Core.Unittests\FSharp.Core\Microsoft.FSharp.Control\AsyncModule.fs:line 438

@forki Could you try adding this?
ThreadPool.SetMinThreads(100,100)

http://stackoverflow.com/questions/17429246/preventing-thread-pool-starvation-with-a-timer-running-at-same-time-as-parallel

@KevinRansom this is not compiling on coreclr!? but I have the code under
#if !(FSHARP_CORE_PORTABLE || FSHARP_CORE_NETCORE_PORTABLE)

any ideas why it's still in the coreclr build?

Build timed out (after 120 minutes). Marking the build as aborted.

It looks like this actually fixed the test. So let me remove the brute-force test and keep the ThreadPool.SetMinThreads(100,100) for the property-based test. This should remove a bit of flakyness.

ok I think this is ready to go in


Subpackages

SIGnificant updates

reorganized directory
deleted unused code
implemented code as python package
added sphinx documentation
added read the docs operability

Looks good!

Looks good, pull approved.


release-helper: update appVersion to latest release

ping @anbraten

FYI I am using it in https://github.com/pat-s/otf-agent-helm and it works as expected :)


Update SIGGRAPH 2024

Which conference does this PR update?
SIGGRAPH 2024
Related URL
https://s2024.siggraph.org/program/technical-papers/
Additional Information
The deadlines of SIGGRAPH 2024 has not been updated on this page: https://s2024.siggraph.org/submit-to-siggraph/ , however it is updated on this page: https://s2024.siggraph.org/program/technical-papers/ . The time may be subject to change.

Please adjust the date format ~

I Updated the time information according to the regex. Please check. Thank you!


Homichel/qpafilter unittest

Added a couple more testcases.

@tswhison I was thinking another PR.  The notes are meant to be things to revisit again later, after discussing with you and Rodrigo.  For example, for the ones in (test_get_filter, test_get_verifier), I can see a possible testcase for something but I think it may fail right now, which is why I didn't want to add it yet.


[WFLY-5019] JMSTopicManagementTestCase intermittent failure

Reenable the removeJMSTopicRemovesAllMessages test after underlying
Artemis issue ARTEMIS-177 has been fixed
JIRA: https://issues.jboss.org/browse/WFLY-5019

Linux Build 9752 outcome was FAILURE using a merge of 998fcee0f55288762a8e646ea4673fdaa7fa96bf
Summary: Error while applying patch Build time: 00:03:22

retest this please

Windows Build 4829 outcome was FAILURE using a merge of 998fcee0f55288762a8e646ea4673fdaa7fa96bf
Summary: Tests failed: 1 (1 new), passed: 3330, ignored: 194 Build time: 01:04:33
Failed tests
org.jboss.as.test.clustering.cluster.web.passivation.FineSessionPassivationTestCase(SYNC-tcp).test: java.lang.AssertionError: response doesn't contain header 'result', all response headers = {name=Connection, value=keep-alive}, {name=X-Powered-By, value=Undertow/1}, {name=Set-Cookie, value=JSESSIONID=hBtZBkgESws3rqOi2MKoHiLn17UxCdyYDQyoDQ2s.node-0; path=/passivation}, {name=Server, value=WildFly/10}, {name=J_anP1AQdnnntucXFBcPgcPiTXbbD1P_xk2zNwpU, value=PASSIVATION}, {name=Content-Length, value=0}, {name=jsessionid, value=hBtZBkgESws3rqOi2MKoHiLn17UxCdyYDQyoDQ2s}, {name=Date, value=Tue, 19 Apr 2016 08:07:05 GMT},
	at org.jboss.as.test.clustering.cluster.web.passivation.SessionPassivationTestCase.getRequiredHeaderValue(SessionPassivationTestCase.java:207)
	at org.jboss.as.test.clustering.cluster.web.passivation.SessionPassivationTestCase.test(SessionPassivationTestCase.java:153)
------- Stdout: -------
10:07:05,202 INFO  [org.jboss.as.test.clustering.NodeUtil] (main) Starting deployment=NONE, container=container-0
10:07:05,202 INFO  [org.jboss.as.test.clustering.NodeUtil] (main) Starting deployment=NONE, container=container-1
10:07:05,202 INFO  [org.jboss.as.test.clustering.NodeUtil] (main) Deploying deployment=deployment-0
10:07:05,215 INFO  [org.jboss.as.repository] (management-handler-thread - 4) WFLYDR0001: Content added at location C:\BuildAgent\work\a31d203e70e89f90\testsuite\integration\clustering\target\wildfly-SYNC-tcp-0\standalone\data\content\8a\884f3e615d9f519893024ac5b10e4fed906270\content
10:07:05,217 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-4) WFLYSRV0027: Starting deployment of "passivation.war" (runtime-name: "passivation.war")
10:07:05,272 INFO  [org.infinispan.configuration.cache.EvictionConfigurationBuilder] (ServerService Thread Pool -- 20) ISPN000152: Passivation configured without an eviction policy being selected. Only manually evicted entities will be passivated.
10:07:05,273 INFO  [org.infinispan.configuration.cache.EvictionConfigurationBuilder] (ServerService Thread Pool -- 20) ISPN000152: Passivation configured without an eviction policy being selected. Only manually evicted entities will be passivated.
10:07:05,274 INFO  [org.infinispan.configuration.cache.EvictionConfigurationBuilder] (ServerService Thread Pool -- 19) ISPN000152: Passivation configured without an eviction policy being selected. Only manually evicted entities will be passivated.
10:07:05,275 INFO  [org.infinispan.configuration.cache.EvictionConfigurationBuilder] (ServerService Thread Pool -- 19) ISPN000152: Passivation configured without an eviction policy being selected. Only manually evicted entities will be passivated.
10:07:05,275 INFO  [org.infinispan.configuration.cache.EvictionConfigurationBuilder] (ServerService Thread Pool -- 20) ISPN000152: Passivation configured without an eviction policy being selected. Only manually evicted entities will be passivated.
10:07:05,275 INFO  [org.infinispan.configuration.cache.EvictionConfigurationBuilder] (ServerService Thread Pool -- 20) ISPN000152: Passivation configured without an eviction policy being selected. Only manually evicted entities will be passivated.
10:07:05,282 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 20) WFLYCLINF0002: Started routing cache from web container
10:07:05,288 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 19) WFLYCLINF0002: Started passivation.war cache from web container
10:07:05,317 INFO  [org.wildfly.extension.undertow] (ServerService Thread Pool -- 20) WFLYUT0021: Registered web context: /passivation
10:07:05,331 INFO  [org.jboss.as.server] (management-handler-thread - 4) WFLYSRV0010: Deployed "passivation.war" (runtime-name : "passivation.war")
10:07:05,337 INFO  [org.jboss.as.test.clustering.NodeUtil] (main) Deploying deployment=deployment-1
10:07:05,347 INFO  [org.jboss.as.repository] (management-handler-thread - 3) WFLYDR0001: Content added at location C:\BuildAgent\work\a31d203e70e89f90\testsuite\integration\clustering\target\wildfly-SYNC-tcp-1\standalone\data\content\8a\884f3e615d9f519893024ac5b10e4fed906270\content
10:07:05,349 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-2) WFLYSRV0027: Starting deployment of "passivation.war" (runtime-name: "passivation.war")
10:07:05,403 INFO  [org.infinispan.configuration.cache.EvictionConfigurationBuilder] (ServerService Thread Pool -- 4) ISPN000152: Passivation configured without an eviction policy being selected. Only manually evicted entities will be passivated.
10:07:05,405 INFO  [org.infinispan.configuration.cache.EvictionConfigurationBuilder] (ServerService Thread Pool -- 4) ISPN000152: Passivation configured without an eviction policy being selected. Only manually evicted entities will be passivated.
10:07:05,406 INFO  [org.infinispan.configuration.cache.EvictionConfigurationBuilder] (ServerService Thread Pool -- 4) ISPN000152: Passivation configured without an eviction policy being selected. Only manually evicted entities will be passivated.
10:07:05,406 INFO  [org.infinispan.configuration.cache.EvictionConfigurationBuilder] (ServerService Thread Pool -- 4) ISPN000152: Passivation configured without an eviction policy being selected. Only manually evicted entities will be passivated.
10:07:05,407 INFO  [org.infinispan.configuration.cache.EvictionConfigurationBuilder] (ServerService Thread Pool -- 34) ISPN000152: Passivation configured without an eviction policy being selected. Only manually evicted entities will be passivated.
10:07:05,408 INFO  [org.infinispan.configuration.cache.EvictionConfigurationBuilder] (ServerService Thread Pool -- 34) ISPN000152: Passivation configured without an eviction policy being selected. Only manually evicted entities will be passivated.
10:07:05,416 INFO  [org.infinispan.CLUSTER] (remote-thread--p8-t1) ISPN000310: Starting cluster-wide rebalance for cache routing, topology CacheTopology{id=1, rebalanceId=1, currentCH=DefaultConsistentHash{ns=80, owners = (1)[node-0: 80+0]}, pendingCH=DefaultConsistentHash{ns=80, owners = (2)[node-0: 40+40, node-1: 40+40]}, unionCH=null, actualMembers=[node-0, node-1]}
10:07:05,420 INFO  [org.infinispan.CLUSTER] (remote-thread--p8-t1) ISPN000310: Starting cluster-wide rebalance for cache passivation.war, topology CacheTopology{id=1, rebalanceId=1, currentCH=DefaultConsistentHash{ns=80, owners = (1)[node-0: 80+0]}, pendingCH=DefaultConsistentHash{ns=80, owners = (2)[node-0: 40+40, node-1: 40+40]}, unionCH=null, actualMembers=[node-0, node-1]}
10:07:05,449 INFO  [org.infinispan.CLUSTER] (remote-thread--p8-t2) ISPN000336: Finished cluster-wide rebalance for cache passivation.war, topology id = 1
10:07:05,448 INFO  [org.infinispan.CLUSTER] (remote-thread--p8-t1) ISPN000336: Finished cluster-wide rebalance for cache routing, topology id = 1
10:07:05,451 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 34) WFLYCLINF0002: Started passivation.war cache from web container
10:07:05,451 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 4) WFLYCLINF0002: Started routing cache from web container
10:07:05,472 INFO  [org.wildfly.extension.undertow] (ServerService Thread Pool -- 4) WFLYUT0021: Registered web context: /passivation
10:07:05,486 INFO  [org.jboss.as.server] (management-handler-thread - 3) WFLYSRV0010: Deployed "passivation.war" (runtime-name : "passivation.war")
10:07:05,511 INFO  [stdout] (default task-60) http://[::1]:8080/passivation/listener?operation=set&name=a&value=1;jsessionid=J_anP1AQdnnntucXFBcPgcPiTXbbD1P_xk2zNwpU

10:07:05,518 INFO  [stdout] (default task-64) http://[::1]:8080/passivation/listener?operation=set&name=a&value=2;jsessionid=S-CLHHczo8MKsiIKCxnZLxnnRw2Qo5fkTBF6KjMo

10:07:05,527 INFO  [stdout] (default task-4) http://[::1]:8080/passivation/listener?operation=get&name=a;jsessionid=J_anP1AQdnnntucXFBcPgcPiTXbbD1P_xk2zNwpU

10:07:05,537 INFO  [stdout] (default task-2) http://[::1]:8080/passivation/listener?operation=get&name=a;jsessionid=hBtZBkgESws3rqOi2MKoHiLn17UxCdyYDQyoDQ2s

10:07:05,538 INFO  [org.jboss.as.test.clustering.NodeUtil] (main) Starting deployment=NONE, container=container-0
10:07:05,539 INFO  [org.jboss.as.test.clustering.NodeUtil] (main) Starting deployment=NONE, container=container-1
10:07:05,539 INFO  [org.jboss.as.test.clustering.NodeUtil] (main) Undeploying deployment=deployment-0
10:07:05,546 INFO  [org.wildfly.extension.undertow] (ServerService Thread Pool -- 20) WFLYUT0022: Unregistered web context: /passivation
10:07:05,557 INFO  [org.infinispan.eviction.impl.PassivationManagerImpl] (ServerService Thread Pool -- 17) ISPN000029: Passivating all entries to disk
10:07:05,557 INFO  [org.infinispan.eviction.impl.PassivationManagerImpl] (ServerService Thread Pool -- 17) ISPN000030: Passivated 2 entries in 0 milliseconds
10:07:05,560 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 17) WFLYCLINF0003: Stopped passivation.war cache from web container

Windows Build 4529 outcome was FAILURE using a merge of 998fcee0f55288762a8e646ea4673fdaa7fa96bf
Summary: Execution timeout (new); tests passed: 3134, ignored: 194 Build time: 01:40:28


Remove simplereport.gov/resources/**/* pages from Azure

We're still seeing old pages like: https://simplereport.gov/resources/using-simplereport/conduct-and-submit-tests/
In addition to the current page: https://simplereport.gov/using-simplereport/conduct-and-submit-tests/
We should remove all simplereport.gov/resources/**/* pages from the site bc the old pages are appearing in search results. For example: https://search.usa.gov/search?utf8=✓&affiliate=simplereport&query=“facility+access+request+form”&commit=
Also, noting that training.simplereport.gov/* is appearing in the results

That last thing seems like a thing that robots.txt should take care of—do we have that parameterized by environment?

It's pointed to our sitemap, which I assumed would only show what's there, but we could add an explicit exclude for it
https://github.com/CDCgov/prime-simplereport-site/blob/main/robots.txt

We need a robots.txt for the training environment and to disallow it

duplicate of https://github.com/CDCgov/prime-simplereport/issues/994


Lava generated stone doesnt give rewards

Hi. With the miner job. The plugin only gives money/rewards for mining blocks which were generated by the chunks itself. But it doesn't give anything when mining lava-generated stone (for instance when water and lava generates obsidian or stone).
How can i fix this?
Jobs version:
Jobs version <IP_ADDRESS>
Server Type (Spigot/Paper/etc): Paper
Server Version (using /ver): git-Paper-378 (MC: 1.17.1)

Hi. this was apearently already enabled. But for some kind of reason doesnt change anything when i set it to false and use /jobs reload. also when I change it back.

Hi. I tried to disable this but it still doesnt seem to work.


maxNotifications to be applied immediately

Hi there,
I really enjoy this library, however I have an issue with the current way the maxNotifications prop works.
If I set it to one, I would like only one notification to pop up.
Currently, many more appear for a moment and then they fade away leaving the only one behind. Is there anyway we can make maxNotifications to completely prevent adding additional notifications even for a split second?
Thank you!

Fixed #41


Pin jetty versions

Unpinned versions caused ewer versions to be pulled in that in turn made jakarta.servlet-api (the successor of javax.servlet-api) required for compilation, causing the exception java.lang.NoClassDefFoundError: jakarta/servlet/ServletContextListener on start-up.

Hi @maccabeelevine, just added you as reviewer for your information. Of course, in case you have any comments to this you're welcome to add them. Don't know if you've seen the java.lang.NoClassDefFoundError: jakarta/servlet/ServletContextListener  exception.


[Fix] Extend and Update interface.yaml

Status
DEVELOPMENT
Description
Extend and Update interface.yaml
New Features

Node/Topic names shall start with global namespace /
Wildcard * that shall not step over namespace / can be used.

- name: /*/dpm_ocv
  publish: [/*/image_obj]
  subscribe: [/config/*/dpm, /image_raw]

Add server and client key for ROS service server/client nodes

- name: /vector_map_client
  publish: [/vector_map_client]
  subscribe: [/vector_map_info/*, /current_pose, /final_waypoints]
  client: [/vector_map_server/get_white_line, /vector_map_server/get_stop_line,
    /vector_map_server/get_cross_walk, /vector_map_server/get_signal]
- name: /vector_map_server
  server: [/vector_map_server/*]

Moved to #1292 by mistake


I am using angular 11 with msal version 1, Do u have any example for that.

I am using angular 11 with msal version 1, Do u have any example for that.
I am basically looking an example for logger as I have some issue with reset password

@garvraj if you can, please migrate to msal v2 as its more secure and msal v1 no longer receives updates (other than critical security updates).
We have an older sample using msal-angular v1, but unfortunately its angular 9, you can see it here
If you need an angular 11 app, there's one using msal-angular v2 here.
I've shared B2C apps as I think you are using B2C here.

@derisen I am migrating to msal V2 and I am facing some difficulty, I don't want to use msal guard and msal interceptor.
But I have some authorized api calls, With msal V1, I used to get accesstoken from msal which I was using for further api call but in msal V2 I am not getting accesstoken instead I am getting idToken but with idToken api calls are saying unautorized , can you help me on this

@garvraj this is expected, you should not use Id token for API calls. You can certainly get an access token without using msal interceptor or guard. msal-angular exposes the same methods as regular msal, so you can use those to request an access token for certain scopes. In your component, simply instantiate an MsalService object, then use one of the acquireToken* methods. See this sample which shows how to use msal directly in an Angular app without msal-angular features like msal interceptor etc.

Closing due to inactivity. Let us know if you need further help.


Improve CI workflow

With recent updates, we included the automated building of thecpgo library on macOS. This needs to be done in a separate building task. Because the library needs to be put into the resources before publishing, we need to run the task before our regular build task. However, that means that our build is extended by at least 1 min even if the Go code never changes. Therefore we need a smart solution.
Maybe we can split the publish and the build task (we only need the publish task in tagged releases) and use artefacts to transfer the build artefacts from the build to the publish task and then only depend on the build-cpgo task in publish.

Already solved by extracting cpgo in http://github.com/Fraunhofer-AISEC/libgoast


OpenXR: Allow GDExtensions to implement _on_pre_draw_viewport() and _on_post_draw_viewport()

For some reason, OpenXRExtensionWrapperExtension doesn't expose _on_pre_draw_viewport() and _on_post_draw_viewport(), despite exposing all other virtual methods.
I don't think there's any reason for this, I think it was just an accidental omission.

Ah, it looks like PR https://github.com/godotengine/godot/pull/97151 also exposes _on_post_draw_viewport() because it needed it. To me, that's a further indication that both of these should be exposed.

Thanks!


Allow parallel conversion on multiple ADCs

This patch splits the current convert() method of ADC in two public methods: start_conversion() and read_sample(). With this, it is now possible to start conversion on multiple ADCs at the same time and then collect results.
There is one issue I'm not sure how to solve - I can call start_conversion on one channel and then read_sample on another and it would successfully read something. I suppose it would be better to protect user by exploding in case two channels are mixed. Thoughts?

This is a nice improvement for the ADC support, thanks!
There is definitely potential for confusion when supplying pin as an argument to both methods. One simple solution would be to store the current channel as an Option<u8> in the Adc struct. Then there's no extra arguments needed for read_sample.

@richardeoin right, I have updated that.

Looks good, thanks!
bors r+


[Q] How to prevent drawing of duplicate frames?

Hi,
I am currently developing a video player in Regl that allows the user to zoom and pan whilst playing a live video feed. In an effort to reduce system resource consumption, I would like to make sure a frame is not drawn to the screen if nothing has changed from the last frame (which I have successfully kept track of), but is there a way to keep the old frame around and temporarily not draw anything in the regl.frame() loop?
Would something like this work?:
regl.frame(() => {
  if (dontDraw() === true) {
    return;
  }

  drawVideoShader({
     // shader params go here
  });
});

Thank you!

Yes, the above should work just fine! Come to think of it, I don't know exactly what triggers this mechanism, but since WebGL uses double-buffering, if you don't draw anything the image should stay on the screen.

Ah, maybe this is roughly what triggers it. I'd just always taken it for granted and hadn't thought about how it works: https://stackoverflow.com/questions/33327585/why-webgl-clear-draw-to-front-buffer

Anytime you do anything that effects the WebGL drawingBuffer (think "backbuffer) it gets marked to swap/copy.


Multi Head Attention Layer

I think is a good idea start to think how to implement this sort of layer in Keras.
I know that is a really fresh algorithm, but I believe that's a new cutting edge tech in Deep Learning for the next years.
Paper: Attention is all you need (https://arxiv.org/abs/1706.03762)
Blog showing some results: Google Research Blog
Tensor2Tensor library tensor2tensor
Pytorch implementation pytorch-t2t

@grafael Please keep an eye on this https://github.com/fchollet/keras/pull/8296. I'll try to have a look at the specific case to see if it will be covered.

Thank @andhus I'll follow the updates

@soham97 it would be great if you could i was trying to implement it couldn't get the thing working

Hi,
I implemented this some time ago in a fork. It is somewhat dirty and lacks test suites, but it works (an NMT example of this).
Cheers.

Whats the status on this?
Seeing OpenAI's success with them made me want to try it.

Closing, as there is now a Keras-friendly multi-head attention layer in TensorFlow Addons. Thanks for the feature request!


Add publicPath to type="module" scripts

What problem does this feature solve?
This will give the ability to web components to be imported in the browser and have things like static assets properly loaded.
What does the proposed API look like?
No api change it's a small update in the setPublicPath file.  I can make a pull request for it.
Idea is to add
if ((i = import.meta) && (i = i.url.match(/(. \/)[^/] \.js(\?.*)?$/))) {
    __webpack_require__.p = i[1] // eslint-disable-line
  }

Is it possible to add a flag of some sort to tell script what kind of module it will be loaded as?
--script-type module,nonmodule or maybe --target wc-module?

I think webpack currently cannot parse this syntax yet.
So let's wait for their official support.
https://github.com/webpack/webpack/issues/6719#issuecomment-396955907

In my case. I use an vue-cli builded sdk in an other vue-cli created app project.
- test-vue-cli-sdk-demo
--- test-vue-cli-sdk(cjs module with some static assets imgs ...

test-vue-cli-sdk assets path is incorrect, such as http://localhost:8082/js/img/logo.82b9c7a5.png
@brion-fuller , Your MR can resolve problem in this case ?


allow use of rails 6.1+ including rails 7

Using rails 7.0.0 (was <IP_ADDRESS>)
better than #7 that it actually allows rails 7, I ran bundle update and it did upgrade to rails 7 and ran make test and tests pass
oopsie for the previous PR

Nice branch name :)
Thanks for doing this!

the really nice thing is that this is compatible for future versions of rails, I think rails main branch switched to 8 already and this is compatible with rails main then

Merged and new release published:
https://rubygems.org/gems/action_mailbox_amazon_ingress/versions/0.1.3
Thanks for fixing so quickly, @dorianmariefr and thanks, @skylarmacdonald for reporting/advising.


fix: Use official go2rtc build

Prerequisites checklist

[x] I have read the contributing guidelines.

What is the purpose of this pull request? (put an "x" next to an item)

[ ] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain: MR got merged, so we don't need to use my fork anymore.

What changes did you make? (Give an overview)
Switched to official go2rtc URL.
Is there anything you'd like reviewers to focus on?
Still needs to be tested.

.tar.gz not exist


Backreferences

[#start_line [ | '1' | [capture 1+ '11'] [1+ #repeat:1] ] #end_line]

Should compile to:
^(?:1?|(11+?)\1+)$

(which is a slight rephrasing of https://stackoverflow.com/questions/3296050/how-does-this-regex-find-primes)
[#start_line [ | '1' | [capture:factor 1+ '11'] [1+ #repeat:factor] ] #end_line]

Should compile to the same:
^(?:1?|(?P<factor>11+?)\1+)$

(because named backreferences aren't available in regex)
[capture #token][#repeat:0]1

Should compile to:
(\w*)(?:\1)1

(Wrapping required to disambiguate "\1 and then 1" from \11)
See e.g. https://learnbyexample.github.io/py_regular_expressions/groupings-and-backreferences.html

Python is done, Rust still needs doing


[IMP] View / gather subscriptions according to group

And while first at it (bugging the heck out of @fguillot, as if the man doesn't have enough on his plate) -
perhaps Subscribtions should be listed by group - when viewing the feeds list
Group: News
--- feed 1 name
--- feed 2 name
Group: Tech
--- feed 3 name
--- feed 4 name
--- feed 5 name
Group: Software
--- feed 6 name
--- feed 7 name

@sparkles645 This idea was dropped in favor of a simpler implementation. Check https://github.com/kordianbruck/miniflux/issues/4
You are welcome to implement it.


fillText not working

Hello, thanks for creating this library! It's much less painful to use than node-canvas because it doesn't work on new Node.js versions...
At the moment I'm facing a little issue with canvas. Even though fillText has been added to canvas already, it doesn't seem to be working for me.
This is the code:
import { createCanvas } from '@napi-rs/canvas'
import fs from 'fs/promises'
import path from 'path'

const canvas = createCanvas(1000, 1000)

const ctx = canvas.getContext('2d')

ctx.fillStyle = 'red'
ctx.font = '30px Noto Serif'
ctx.textAlign = 'center'
ctx.fillText('Hello World', 500, 500)

export function generateImage(title: string) {
  try {
    return canvas.encode('png')
  } catch (e) {
    console.log('Failed to encode image: ' + e.message)
    throw e
  }
}

and this is what I get:

System info

Node.js 16.5.0
Linux 5.10.49-1-MANJARO
@napi-rs/canvas 0.0.12

Additional context
skia-canvas seems to work fine

I have not implement the "preload system fonts" features because this library doesn't depend on fontconfig. I will implement it in https://github.com/Brooooooklyn/canvas/pull/265 . For now you can load font manually like: https://github.com/Brooooooklyn/canvas/blob/70fd0491c2d106b9ae028c4d233557f5ad3738e4/draw-text.js#L11

preload system fonts has been done, it should work fine now.


TOTP time drift specified breaks auth

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[ x ] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[ x ] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
v21.1.7_1 - When I set 120 seconds in "Time Window" and 120 seconds in "Grace period" when creating an authentication server with TOTP, it breaks and when testing with Tester in will never pass authentication.
If I remove the Time Window and Grace period, it works
To Reproduce
Steps to reproduce the behavior:
Have a user with a TOTP seed created
Create a server of type "Local Authentication + TOTP"
Set "Time Window" and "Grace Period" to 120
Check "Reverse token order" to place TOTP code after password
Go to Tester and test the authentication, it fails.
Expected behavior
Tester should show that the authentication passes
Describe alternatives you considered
When I removed the Time Window and Grace Period (Made them blank) and they use default values, then it is working in that case.
Environment
Software version used and hardware type if relevant, e.g.:
OPNsense 21.1.7_1 (amd64, OpenSSL <IP_ADDRESS>k).

You are aware that the other end needs to use the same "Time Window" as well (https://en.wikipedia.org/wiki/Time-based_One-Time_Password)? if the token switches every 30 seconds in the authenticator app, the server needs to use the same. The grace period however is flexible, it just defines how many of the generated numbers may be used.

You are aware that the other end needs to use the same "Time Window" as well

Hmmm I think I wasn't, the info said : "The time period in which the token will be valid, default is 30 seconds. " and so I assumed from that wording by bringing it up to 120 seconds it meant that the code would be usable for 120 seconds. But I guess that's what the Grace period is for instead.


docs: Remove outdated note on IPv6 BPF masqerading being incompatible with the Host Firewall

Since commits 9c1031e31719 ("bpf: fix missing ipv6 ct entry for snated traffic") and cfed66ee55c5 ("Revert "daemon: Forbid IPv6 BPF masquerading with the host firewall""), IPv6 BPF masquerading is compatible with the Host Firewall. The documentation still states the opposite, as we forgot to remove the related note. Clean it up now.

/test


Support command initialization methods in the picocli lifecycle

Often several subcommands will need to wire up the same dependency based on common option values passed to a parent command, as is seen in the following example:
@Command(name = "top", subcommands = { SubCommand.class })
public class TopCommand {

    @Option(names = "--host")
    private String host;

    @Option(names = "--port")
    private int port;

    @Command(name = "sub")
    static class SubCommand {
        @ParentCommand
        TopCommand top;

        @Command(name = "create")
        public void create() {
            new MyClient(top.host, top.port).create());
        }

        @Command(name = "read")
        public void read() {
            new MyClient(top.host, top.port).read());
        }

        @Command(name = "update")
        public void update() {
            new MyClient(top.host, top.port).update());
        }

        @Command(name = "delete")
        public void delete() {
            new MyClient(top.host, top.port).delete());
        }
    }
}

Notice how a new MyClient(host, port) must be created in each of the create, read, update and delete command methods.
A convenience method such as
public void myClient() {
    return new MyClient(top.host, top.port);
}

could be declared in the SubCommand class, and called from the CRUD command methods in order to eliminate this duplication, but that assumes that a given command only ever calls the method once. If a command method needs to make multiple MyClient calls, then we must create a SubCommand#myClient field and conditionally initialize it, e.g.:
@Command(name = "sub")
static class SubCommand {

    @ParentCommand
    TopCommand top;

    private MyClient myClient;

    private MyClient myClient() {
        if (myClient == null)
             myClient = new MyClient(top.host, top.port);
        return myClient;
    }

     // CRUD command methods follow ...
}

So it's starting to get pretty ugly and boilerplate-ish, especially if the application has many such sub and sub-subcommands.
Better would be to allow for an explicit init method to be called in the picocli lifecycle after all picocli-injected fields have been wired up, but before any command method execution has occurred, e.g.:
@Command(name = "sub")
static class SubCommand {

    @ParentCommand
    TopCommand top;

    private MyClient myClient;

    @ComandLine.CommandInitializer
    private void init() {
        myClient = new MyClient(top.host, top.port); // where the 'top' field is guaranteed to have already been injected by picocli
    }

     // simplified, POJO-ish command methods follow, e.g.:

    @Command(name = "create")
    public void create() {
        myClient.create();
    }

    // ...
}

Alternatively, the @Command annotation could be enhanced to support an initMethod attribute, e.g.:
@Command(name = "sub", initMethod="init")
static class SubCommand {

    private void init() {
        // ...
    }
}

And as another alternative, picocli could provide e.g. an InitializableCommand interface that guarantees the same semantics (shown here in conjunction with Runnable for extra clarity):
@Command(name = "sub")
static class SubCommand implements Runnable, InitializableCommand {

    @Override // from InitializableCommand
    private void init() {
        // guaranteed to run after any picocli-injected fields have been initialized and before the run() method below is called
    }

    @Override // from Runnable
    private void run() {
        // guaranteed to run after the init() method above
    }

}

One advantage of the annotation-based approach would be that the annotated init method could accept any number of parameters injected by picocli, e.g. @Options, the @ParentCommand, etc. Doing it this way would further cut down on boilerplate as it would avoid the need for fields in many cases.
Note that I am aware of picocli's existing CommandLine#setExecutionStrategy approach, as documented at https://picocli.info/#_initialization_before_execution, but upon experimenting with it, it appeared that the strategy only applied to the top-level command class, i.e. the one provided to new CommandLine(...). If this approach can achieve what I'm looking for above, then I missed it.
Thanks for your consideration.

It is hard to know where to draw the line for some of these things, but it seems to me that the myClient convenience method that caches the MyClient object in a field is not bad. In terms of lines of code it is actually not that different from the proposed solution with the @ComandLine.CommandInitializer-annotated init method. And it is easy for anyone who reads the manual initialization code to understand what it does, without needing to go to the picocli documentation to find out about the exact timing of when @CommandInitializer-annotated methods are called. :-)
I would like to keep things simple in the library.
It is an interesting suggestion, and I may change my mind at some point 😉  but for now I am inclined to say no to this.

Thanks for getting back, @remkop. It may be that my use case is relatively rare, and I understand the desire to keep picocli as pico as possible 😉 Should implementing something like this become a possibility in the future, I'd think that the interface-based approach described above would be the least magical for users and probably the simplest to implement.

@cbeams wrote:

Note that I am aware of picocli's existing CommandLine#setExecutionStrategy approach [... ] if this approach can achieve what I'm looking for above, then I missed it.

On a second look, it was possible to achieve what I wanted with the existing IExecutionStrategy hook:
import picocli.CommandLine;
import picocli.CommandLine.ExecutionException;
import picocli.CommandLine.ParameterException;

public class InitializeAndRunLast implements CommandLine.IExecutionStrategy {

    @Override
    public int execute(CommandLine.ParseResult parseResult) throws ExecutionException, ParameterException {
        var topLevelCommand = parseResult.commandSpec().commandLine().getCommand();
        initialize(topLevelCommand);
        parseResult.subcommands().forEach(subcommandParseResult -> {
            var subcommand = subcommandParseResult.commandSpec().commandLine().getCommand();
            initialize(subcommand);
        });
        return new CommandLine.RunLast().execute(parseResult);
    }

    private void initialize(Object command) {
        if (command instanceof InitializableCommand)
            ((InitializableCommand) command).init();
    }
}

where InitializableCommand is defined as an interface
public interface InitializableCommand {
    void init();
}

that any @Command class can implement, e.g.
@Command(names="example")
public class ExampleCommand implements Runnable, InitializableCommand {
    @Override
    public void init() {
        // do any initialization logic prior to run() being called.
    }

    @Override
    public void run() {
        // ...
    }
}

And the InitializeAndRunLast execution strategy is configured against the CommandLine instance prior to execution as usual:
public static void main(String... args) {
    new CommandLine(ExampleCommand.class)
                .setExecutionStrategy(new InitializeAndRunLast())
                .execute(args);
}

For concision the example command above does not declare any subcommands, but the InitializeAndRunLast implementation does support them. Each command and subcommand is initialized in the order declared on the command line and then the last command is executed.
This approach is working well for my needs, so I'll close the issue.

Nice! 👍


can't  join the discord of fuelLabs

can't  join the discord of fuelLabs,  how to join it ,

I'm assuming you were able to get past this, if not please reopen the issue with more details about the error you're running into when you try to join.


fail fetch nipy data

Data absent, downloading...
Extracting data from /Users/alex/nilearn_data/nipy-data-0.2.tar.gz...
Error uncompressing file: CRC check failed 0x23fd1d03 != 0x5f3d7a64L
Archive corrupted, trying to download it again.

I never had that one on Travis nor on my box. Can this be a mac-related
thing ? Have you already seen this kind of issue previously ?
Best,
B

I had an unfinished downloaded file. works now. Sorry for the noise


Add node whitelist function

I added whitelist function to constrain nodes which correspond with operation policy.
(Opposite of blacklist function, nodeExcludes in settings.js)
This function uses nodesIncludes in settings.js.
I have already discussed the design of this function with Dave and Nick.

Coverage decreased (-0.009%) to 84.039% when pulling d972a9ca70bf85fac61a71d00f366c309e7f1f7c on kazuhitoyokoi:0.17 into 27b7fb54e8c8c272d99dd171176c8e0626f9dc99 on node-red:0.17.


Bad path to creating files

Hi,
I try to load te plopfile from global lib but, when I try to add some files the path where I want create is wrong
This is the file that run node-plop:
#!/usr/bin/env node

'use strict';

const nodePlop = require('node-plop');
const plop = nodePlop(__dirname + `/plopfile.js`);

async function createMs(){
    let msGen = plop.getGenerator('ms');
    try{
      let data = await msGen.runPrompts();
      let result = await msGen.runActions(data);

      let changes = result.changes;
      let fails = result.failures;
      console.log(fails);
      console.log(changes);

  }catch(error){
    console.log(error);
 }

createMs();

I packing this function whit the plofile and then install  npm i -g lib.tgz then calling this using mg new ms.
When try to write de proyect folder throws this error, because is trying to write in the path where plopfile is located no where comand is called
[ { type: 'addMany',
    path: '',
    error: 'EACCES: permission denied, mkdir \'/usr/lib/node_modules/ms-node-generator/my-microservice\'' } ]
[]

Yes, that is correct. plop uses the path of the plopfile as the base for all other paths. This is because the plopfile exists to enforce a certain structure that (most of the time) is not based on the user's cwd. If you want to use the cwd in the construction of paths, you can do that, but it won't be the default behavior. All actions support the data property. Which can be used to add your own data to the prompt data.
plop.setGenerator('test', {
  ...
  actions: [{
    ...
    path: '{{rootPath}}/some/folder/file.ext',
    data: {rootPath: process.cwd()}
  }]
});

Yes, that is correct. plop uses the path of the plopfile as the base for all other paths. This is because the plopfile exists to enforce a certain structure that (most of the time) is not based on the user's cwd. If you want to use the cwd in the construction of paths, you can do that, but it won't be the default behavior. All actions support the data property. Which can be used to add your own data to the prompt data.
plop.setGenerator('test', {
  ...
  actions: [{
    ...
    path: '{{rootPath}}/some/folder/file.ext',
    data: {rootPath: process.cwd()}
  }]
});

reading the source code of node-plop, I found that nodePlop() accept a config.
So I did use this config:
const plop = nodePlop(__dirname + `/plopfile.js`,{destBasePath:process.cwd()});

yes, this will also work. However, just know that this will force all generators in that plopfile to treat this path as their base path. If that's what you need for your use case, great. 👍


manage version with gradle.properties

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master      #6   +/-   ##
========================================
  Coverage      90.9%   90.9%
  Complexity       28      28
========================================
  Files             3       3
  Lines            66      66
  Branches         11      11
========================================
  Hits             60      60
  Misses            3       3
  Partials          3       3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2c0db1...507e462. Read the comment docs.


Add/fix flash controller nodes for NXP kinetis SoCs

Its looks like the only flash controller node that might be correct is dts/arm/nxp/nxp_k6x.dtsi.
Several dtsi don't have flash controller nodes at all:

dts/arm/nxp/nxp_kl25z.dtsi
dts/arm/nxp/nxp_kw40z.dtsi
dts/arm/nxp/nxp_kw41z.dtsi

And dts/arm/nxp/nxp_kw2xd.dtsi has copied the k64 node.
Need to update all these .dtsi to have proper flash controller nodes.

fixed


Buffer removed, it cause some trouble

Hello.
I use twing-loader based on twing but this lib is based on Buffer and it is incompatible with webpack 5.
Ironically in my case we don’t need Buffer in the front bundle beacause Twing-loader is only a template loader chained with html-loader and htmlWebpackPlugin, so Buffer is not used in the browser (only for dev mode).
You recommand to use browser entry in package.json https://github.com/defunctzombie/package-browser-field-spec#spec
And you mention a way to add a polyfill manualy:

It's possible to manually add a polyfill for a node.js core module. An error message will give a hint on how to achieve that.

I try to run my webpack mut I have an error ReferenceError: Buffer is not defined without message to explain how to manually add a polyfill.
So:

How to manually add a polyfill ?
Add a browser entry in twing package.json with a Buffer polyfill is the best way to fix it ?

https://github.com/feross/buffer is for example a solution for the browser but it depends on the library that you use. This is not a really a problem with webpack itself imo.

Buffer in general is not part of the browser APIs and only a NodeJS API.

Regarding the browser field, see https://webpack.js.org/configuration/resolve/#resolvealiasfields and https://github.com/webpack/webpack/issues/151
If this does not work try importing directly<EMAIL_ADDRESS>

@DanielRuf
I'm building a library which creates a umd, cjs builds. I use some packages which require Buffer polyfill.
What configuration should i use so that Buffer module gets polyfilled in my outputs.?
I tried resolve alias field and it didn't work for Buffer. ( it worked for others like crypto, process etc)

@chaitanyapotti
new webpack.ProvidePlugin({
  Buffer: ['buffer', 'Buffer'],
})

See: https://github.com/duplotech/create-react-app/commit/d0be703d40cd4bc32cd91128ba407a138c608243

Thanks @sebinsua
That seems to have resolved that issue. However, when i try to use libraryTarget: "module",
i get the following error:
Module external type is not implemented yet
Is the feature not yet built?


Fix win32 compile error in KR unittest.

MmapAllocator is currently Posix-only, so the unittest also needs to be Posix-only.

Closing as this is no longer necessary with the new MmapAllocator implementation for Windows.


Client frontend contract

Plan to move all node related contracts (which has no business on chain) to a single directory.
The client frontend contract should have these functions implemented:
Hubble frontend contracts

Transfer

processTx
applyTx
processFee
checkSignature

Create2Tranfer

processTx(which takes encoded tx data and compresses it on contracts)
ApplyTx ( checks if tx.from == mp.account.path and routes to ApplyTxSender)
processFee
checkSignature

Mass Migrations

processTx
ApplyTx
processFee (not ready on contract yet)

Notes

ApplyTx wraps ApplyTxSender and ApplyTransferTxReceiver
ProcessTx on frontend contracts takes encodedTxData and converts to Tx.Transfer on fly before routing to transfer.ProcessTx
encodedTxData to compressed data should be in ProcessTx and ApplyTx

Can you assign this to someone?  I can take it up if you have tasks at hand

Fixed partially in #282

closing in favor of #291


plt savefig not working

I have no time for a thorough and reproducible report, I might improve this in a week. Please just see the link.
https://stackoverflow.com/questions/53217247/stop-showing-plots-in-spyder/53217344#53217344
Essence from the comment below the question:
The plt.ioff() helped me only at first: now a day later, using the exactly same script, I do not get the png saved. The other answer (deactivate graphics support in "Preferences | IPython Consonle | Graphics | Support for Graphics") does not help either in this situation. I use Spyder 4.1.4 on Windows 10 64bit. The same script is running fine in PyCharm.
The script that does not save the png:
    # Plot
    result_mul = seasonal_decompose(x=df.data, model='multiplicative', extrapolate_trend='freq', period=3)
    plt.rcParams.update({'figure.figsize': (10,10)})
    result_mul.plot().suptitle('Multiplicative Decompose', fontsize=22)
    plt.savefig('example.png', format="png")
    plt.close()

I have no time for a thorough and reproducible report

Ok, please let us know when you have one.

I have found the files. The files have been saved directly in my user folder C:\Users\Admin. Apparently, my working directory was not set correctly. Normally, I would expect Spyder to set the working directory to the directory of the .py file itself. It is possible that I have missed something here, since I have found other pictures saved a month ago, thus I do not make this mistake the first time. Could you please tell me whether in Spyder the working directory needs to be set in every session?

I found out at https://stackoverflow.com/questions/38393628/set-working-directory-in-python-spyder-so-that-its-reproducible that this is an old and still open issue, see https://github.com/spyder-ide/spyder/issues/3154. This can be closed.

Glad you figured this one out. I was about to tell you the same. I doubt we'll address because we're clearly displaying what the current directory is at any time and for every console.


Save Checked Items in localStorage to Retain on Page Reload

Implement functionality to save the state of checked items in localStorage. This will ensure that checked items remain marked even after reloading the page.

@antonioalanxs could you assign this to me? 😄


Fix CircleCI config

Signed-off-by: Ionut Mihalcea<EMAIL_ADDRESS>

Do you see the results somewhere?

Do you see the results somewhere?

Not yet, still just trying to get it to run :angry-laugh:


Dapr sidecar stop working intermediary in microservice

Hi, I am using dapr in my microservice with hasura, while it worked great for some time and then sidecar is failed to communicate with the service.
This is the docker-compose config
verlagg_service:
    build: ./services/verlagg
    image: verlagg_service:latest
    depends_on:
      graphql-engine:
        condition: service_healthy
      rabbitmq:
           condition: service_healthy
    ports:
      - 3501:3501
      - 8001:8001
    env_file:
      - ./services/verlagg/.env
    command: sh -c "yarn build && yarn start"
    volumes:
      - ./services/verlagg:/opt/app
      - ./services/verlagg/node_modules:/opt/node_modules
      - ./services/verlagg/package.json:/opt/package.json
      - ./services/verlagg/yarn.lock:/opt/yarn.lock
      - ./services/verlagg/.env:/opt/app/.env
    labels:
      - traefik.enable=true
      - traefik.http.routers.verlagg_service.entrypoints=web
      - traefik.http.routers.verlagg_service.service=verlagg_service
      - traefik.http.services.verlagg_service.loadbalancer.server.port=3501
      - traefik.http.routers.verlagg_service.rule=(Host(`localhost`) && PathPrefix(`/dapr/functions/verlagg_service`))
      - traefik.http.middlewares.strip-verlagg_service.replacepathregex.regex=^/dapr/functions/verlagg_service(.*)
      - traefik.http.middlewares.strip-verlagg_service.replacepathregex.replacement=/v1.0/invoke/verlagg_service/method/$$1
      - traefik.http.routers.verlagg_service.middlewares=strip-verlagg_service@docker
    networks:
      - ips_verlagg

  #########################
  # VERLAGG SERVICE SIDECAR #
  #########################

  verlagg_service_sidecar:
    image: daprio/daprd:edge
    depends_on:
      - verlagg_service
    volumes:
      - ./dapr/components/:/components
    command:
      - ./daprd
      - --app-id
      - verlagg_service
      - --app-port
      - '8001'
      - --placement-host-address
      - placement:50006
      - --app-protocol
      - http
      - --components-path
      - /components
      - --dapr-http-port
      - '3501'
      - --log-level
      - debug
      - --log-as-json
    env_file:
      - ./services/verlagg/.env
    network_mode: service:verlagg_service

When I check the logs,  verlagg_service service is running fine as well as sidecar shows the connection initialised. But the sidecar is not able to communicate.
Solution I had
I had to restart the sidecar to make it work.
Question

Please confirm when the sidecar will stop?
How to add proper detail log in sidecar?

Could you please share the logs from both your app and daprd? We will need to take a look at them to see what's going on

@ItalyPaleAle
Thanks for the response. This is the intermediary error and since I do not have the record of the logs. I am sharing the log when the sidecar is working.
I will update same when I get the same error.
{"app_id":"verlagg_service","component":"mdns (nameResolution/v1)","instance":"2fff677713b1","level":"debug","msg":"0 IPv4 address(es) expired for app id verlagg_service.","scope":"dapr.contrib","time":"2023-03-31T16:43:26.262648894Z","type":"log","ver":"edge"}
{"app_id":"verlagg_service","component":"mdns (nameResolution/v1)","instance":"2fff677713b1","level":"debug","msg":"Refreshing mDNS addresses for app id verlagg_service.","scope":"dapr.contrib","time":"2023-03-31T16:43:26.262701492Z","type":"log","ver":"edge"}
{"app_id":"verlagg_service","component":"mdns (nameResolution/v1)","instance":"2fff677713b1","level":"debug","msg":"mDNS response for app id verlagg_service received.","scope":"dapr.contrib","time":"2023-03-31T16:43:26.263306575Z","type":"log","ver":"edge"}
{"app_id":"verlagg_service","component":"mdns (nameResolution/v1)","instance":"2fff677713b1","level":"debug","msg":"Adding IPv4 address <IP_ADDRESS>:41709 for app id verlagg_service cache entry.","scope":"dapr.contrib","time":"2023-03-31T16:43:26.263749854Z","type":"log","ver":"edge"}
{"app_id":"verlagg_service","component":"mdns (nameResolution/v1)","instance":"2fff677713b1","level":"debug","msg":"mDNS browse for app id verlagg_service timed out.","scope":"dapr.contrib","time":"2023-03-31T16:43:29.263474436Z","type":"log","ver":"edge"}
{"app_id":"verlagg_service","component":"mdns (nameResolution/v1)","instance":"2fff677713b1","level":"debug","msg":"Refreshing mDNS addresses for app id verlagg_service timed out.","scope":"dapr.contrib","time":"2023-03-31T16:43:29.263552052Z","type":"log","ver":"edge"}

Thanks. I don't see anything odd in there, but please let us know when you have logs that show any error

Hey @ItalyPaleAle, seems issue with Redis in my server. closing now


[python-package] Do we have the support for merging of multiple lightgbm models?

I have an application that trains a boosting sequence with tree models and linear models like: linear-model, trees, linear-model, and trees. In the end, I want to combine all the tree models into one.
I do not find the function to do that in lightgbm.
In catboost library, they have a function called: sum_models: https://catboost.ai/en/docs/concepts/python-reference_sum_models
which does this.

One way I can think of is to just write a wrapper and mock all the functions currently existing for the lightgbm.Booster class.

@jinyyy666 Thanks for using LightGBM. Unfortunately, we don't have an official approach to merge multiple LightGBM models.
If the goal is just to combine the prediction results of multiple boosting model, I think it can be achieved by simply adding the prediction results from different models together.
However, if the goal is the blending different base learners (trees or linear models) during ONE boosting process, I think it can hardly be achieved by existing GBDT tools without modifying the source code.
If you have any further problems, please feel free to post them here. Thanks!


Fixed::No dark mode on login page #512

FIXED::No dark mode on login page #512
-Optimized js code made it inside one script
-removed unnecesaary html codes
#512

[ y] Bug fix (non-breaking change which fixes an issue)

Checklist:

[ ] I have made this from my own
[ ] I have taken help from some online resourses
[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK
https://github.com/anuragverma108/SwapReads/assets/101548649/6b7bd7d6-dce9-4b73-a08e-ebb11fa50084

Great contribution to GSSOC'24! 🎉


style(cmd-api-server): fix Unexpected any linter W in startCockpitFileServer()

Description

I'd like to fix this linter warning

@bmvd70 You got it! Thank you!


Setting up remote interpreter in PHPStorm - documentation

Info:

Docker version ($ docker --version): Docker version 17.03.1-ce, build c6d412e
Laradock commit ($ git rev-parse HEAD): b9b9d52e572a44c4d42b9e80cadc837abb125463
System info (Mac, PC, Linux): Linux
System info disto/version: Ubuntu 17.0.4

Issue:
Hello, this is not issue per se, but after 4 hours of fiddling around, I've finally been able to correctly setup remote interpreter on Ubuntu 17.04 - including finding docker host ip, setting WORKSPACE_INSTALL_WORKSPACE_SSH to TRUE (ha, that one was nasty), correcting permissions on workspace/insecure_id_rsa etc. I'm willing to document this process and send pull request with updated documentation, my question is, if you are interested in this.
FOR ANYONE COMING HERE
Process is as follows:
Find your Docker Host IP
Open terminal, run ifconfig and look for docker0 interface, note the IP address. Example output:
docker0: flags=4099<UP,BROADCAST,MULTICAST>  mtu 1500         inet === IP IS HERE => <IP_ADDRESS>  netmask <IP_ADDRESS>  broadcast <IP_ADDRESS>         inet6 fe80::42:7aff:fe74:e3dc  prefixlen 64  scopeid 0x20<link>         ether 02:42:7a:74:e3:dc  txqueuelen 0  (Ethernet)         RX packets 19980  bytes 1627092 (1.6 MB)         RX errors 0  dropped 0  overruns 0  frame 0         TX packets 25136  bytes 34818849 (34.8 MB)         TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0
Enable SSH in workspace
set WORKSPACE_INSTALL_WORKSPACE_SSH to true: WORKSPACE_INSTALL_WORKSPACE_SSH=true this is important, otherwise, you will get connection refused error
Set found Docker Host IP
set DOCKER_HOST_IP variable to found ip in .env :
DOCKER_HOST_IP=${FOUND_IP} //e.g. <IP_ADDRESS>
Fix permissions on ssh keys
For me, the pregenerated .ppk files were not working (corrupted format error message in PHPStorm), so i used the ${LARADOCK_FOLDER}/workspace/insecure_id_rsa, but before you can do that, you need to fix the permissions, othwerwise, they will get ignored by ssh. They should be 0600. You can do that with following command:
chmod 0600  ${LARADOCK_FOLDER}/workspace/insecure_id_rsa
Set up deployment in PHPStorm
In PHPStorm, go to Settings -> Build, Execution, Deployment add a new SFTP deployment. Set it as follows:

SFTP host: ${FOUND_IP} - e.g. <IP_ADDRESS>
Port: 2222 (can be found in laradock .env - )
Root path: /var/www
User name: root
Auth type: Key pair
private key file:  ${LARADOCK_FOLDER}/workspace/insecure_id_rsa
Click Test SFTP Connection - should work.

Set up the remote interpreter in PHPStorm

Go to Settings -> Languages & Frameworks -> PHP
click on three dots next to CLI Interpreter
add a new one, select From docker, vagrant, remote, ..
select deployment configuration - and select the previously configured deployment
click OK

You should be all set

Hi
I'm struggling to find the DOCKER_HOST IP
docker ps -a returns several active containers including laradockstoryboard_workspace. When i type ifconfig docker0 from OSX command line it returns an error ifconfig: interface docker0 does not exist
The env-example file already has the DOCKER_HOST_IP set to <IP_ADDRESS> but this doesn't work when I add it to a deployment in PHPStorm
thanks
chris

Hi, this guide is for Ubuntu Linuxu, unfortunately I do not know where to
find this IP adress in os x :(
On Fri, Aug 11, 2017, 11:58 Chris Hodgson<EMAIL_ADDRESS>wrote:

Hi
I'm struggling to find the DOCKER_HOST IP
docker ps -a returns several active containers including
laradockstoryboard_workspace. When i type ifconfig docker0 from OSX
command line it returns an error ifconfig: interface docker0 does not
exist
The env-example file already has the DOCKER_HOST_IP set to <IP_ADDRESS> but
this doesn't work when I add it to a deployment in PHPStorm
thanks
chris
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/laradock/laradock/issues/951#issuecomment-321773375,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGVQcM0rl_rYsGMi2EFpzSxUq89s9yAZks5sXCXTgaJpZM4NfFba
.

--
S přátelským pozdravem
Lukáš Benke
mobil: 739 260 256 | e-mail<EMAIL_ADDRESS><EMAIL_ADDRESS>AKON Česká republika, s.r.o.
Bayerova 588/16, 602 00, Brno
tel./fax: 548 211 210
KamvBrne.cz http://www.kamvbrne.cz/ | KamvPraze.cz
http://www.kamvpraze.cz/ | Akon.cz http://www.akon.cz/

I follow the procedure to the letter and everything worked.
I did want to configure PHPUnit to run trough the editor so there is a few extra step.
Languages & Frmeworks > PHP
Add the path mappings from your root project to /var/www on the remote machine
Languages & Frmeworks > PHP > test Frmeworks
Add PHPUnit by remote interpreter
PHPUnit library Use Composer Autoloader
Path to script: /var/www/vendor/autoloader.php
Enjoy !

@mpoiriert  Amazing, worked for me

This article was helpful to me too: http://webandapp.fr/blog/2017/09/where-is-my-database-host/
After updating Docker recently, by "Docker" setting in PHPStorm no longer worked and I realized that the docker-compose setting is supposedly the preferred one and works.

This is useful for Mac users:
https://www.youtube.com/watch?time_continue=50&v=bWbXMy_mxxE


More Cross Compilation Work

I'll come back to this tomorrow...

I'm going to work on the PR description above and then also work on the changes to README.md to talk about cross-compiling, "trusted", and the trusted-pgx crate.  Neither of those should hold up a review and a merge.
I think this is in good (enough) shape and passes my smoke testing locally.

test tests::tests::pg_plrust_one_sleepy_boi ... FAILED

Between all the PRs being merged, the assert somehow made its return...?

It seems to be intermittent. Which is another level of awesome.

I'm going to merge this over the error and address the issue in followup if needs be.


Fix the issue with some CDRs being set to 0

When it is changed to Nil, it seems to interfere with non list parameter to function

The issue was fixed. It was essentially getting rid of places that depended on "CDR being 0" to determine if it was the end of the list


Add HTMLElement properties/methods

Per #48.
I worked from the IDL in that comment, removing properties which are inherited from Element, and the event handlers per @garyb's comment. Additional omissions (because they seem hard/non-obvious) are
readonly attribute DOMStringMap dataset;
attribute HTMLMenuElement contextMenu;
readonly attribute CSSStyleDeclaration style;

Thanks very much!


编译出错

Describe the bug
使用0.14.53版本，编译ssg阶段报错

Reproduction
编译ssg阶段报错
System Info
win

Used Package Manager
npm
Validations

[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

发现问题所在，addons我有些是不使用的，所以没有安装

Will fix it asap.

Fixed it in 0.14.54.


Extract payload related types from engine types

Describe the feature
currently the payloadbuilder types are defined in the enginetypes:
https://github.com/paradigmxyz/reth/blob/5100ddd28e3ae0396aa97633d6f700d77aefb50f/crates/engine-primitives/src/lib.rs#L32-L46
and used like this:
https://github.com/paradigmxyz/reth/blob/5100ddd28e3ae0396aa97633d6f700d77aefb50f/crates/payload/builder/src/service.rs#L276-L280
afaik the payload impls only need these three types,
we should extract those to a new trait and then reuse and restrict those in EngineTypes
TODO

First PR: introduce new crate payload-primitives and move the traits and relevant types from: https://github.com/paradigmxyz/reth/blob/5100ddd28e3ae0396aa97633d6f700d77aefb50f/crates/payload/builder/src/traits.rs#L7-L7
Then, Introduce a PayloadTypes trait that contains the 3 associated types from engine types
reuse in enginetypes and add the existing TryFrom restrictions etc.

Additional context
No response

Can I take this one?


APYSwap Boost: earnedToken to 'APYS-BNB LP'

UI is currently showing that you earn APYS when you actually earn APYS-BNB LP
Had a couple of questions about it on Discord.
Not sure if changing this will effect APY calculation/price - maybe need to change oracle too?

Thank you!
The oracle is correct one - LP