Firstpage does not get updated [not a bug]

Just a feature. Firstpage gets updated only after adding hours or when the app is started.
If the app is left on without adding hours and the day changes, the info is wrong.
Should maybe get updated everytime the firstpage gets viewed?

Definitely a bug.


fix(tests): fix failing unit and e2e tests

Some tests failed due to a missing localization of expected time values.
One e2e got removed because it isn't valid anymore.
Please check whether the localized expected time values work in your timezone as well.
PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/ngneat/transloco/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
Some unit tests failed under the wrong time zone.
Some e2e tests failed because of various reasons:

legacy
wrong time zone

What is the new behavior?
All unit tests and e2e tests run fine.
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

@chrsi Thanks for the PR! 🙂

@chrsi the first commit was made as a fix which will bump the version, can you please update the commits to be test-related only?

yeah sure, done


Fix delegate navigation from region page

Fixes #31

lgtm. Going by the icon rather than the indexed child should be safer for future changes as well.


Ability to cancel/redirect the initial state load

In the 0.3.x releases and before, I had seen some discussion of ways that people had hacked together to catch the event of the initial state loading and potentially cancel or redirect it for use case such as checking if a user is authenticated.
I thought the $transition feature was going to add the functionality in some way, but as far as I can tell, there is still no way to do it.  There has to be some state stuff happening when the page initially loads to get the view on the screen, and it would be awesome if we could attach events to it somehow.  Something like $transition.onBegin being called or even $transition.onInitialLoad. I know this would help me a lot and I'm sure it would clean up some other people's code as well.

here are some ideas:
Check if the transition is coming from the "root" state?
$transitions.on({ from: "" })

Check the transition id (incremented counter)
https://ui-router.github.io/docs/latest/classes/transition.transition-1.html#_id
https://github.com/ui-router/core/blob/master/src/transition/transition.ts#L124
$transitions.on({}, ($transition$) => {
  if ($transition$.$id === 0)
    ///
});

Wait to synchronize the url (which generally triggers the intiial transition) until you know the answers to the async questions

.config($urlRouterProvider => $urlRouterProvider.deferIntercept())
.run(($http, $urlRouter, $state) => {
  $http.get('/check')
     .then(resp => doSomethingWith(resp.data))
     .catch(() => $state.go('login'))
     .then(() => {
       $urlRouter.listen();
       $urlRouter.sync();
     }).catch(() => ;
});

@christopherthielen Thanks for the reply. I tried the first two suggestions (although I had to change $transitions.on() to $transitions.onBefore() or $transitions.onStart() because the .on() function didn't exist.  When using any of those, the event never gets fired.  The first suggestion seems like a really elegant way of solving the problem though, and it would be awesome if the team working on UI Router could add that.

All three solutions work right now.  Here's a plunker that shows both option 1 and option 2: http://plnkr.co/edit/03aCSBrHoPa5wco5y1yh?p=preview
Since these solutions exist, work, and seem to satisfy your request, I'm closing this issue

Ah, I ended up getting it working. I had a progress bar being initialized before I registered the onBefore event, and the state change must have been triggered before it made it that far into the function. Thanks for the help!


✨ Add GetStatement method

feat: Add GetStatement method
Full method documentation:
https://developer.help.paycom.uz/metody-merchant-api/getstatement
This commit adds a new method called GetStatement.
To return a list of transactions for a specified period,
the GetStatement method is used.
The new method uses the following parameters:

from: Beginning of period (Timestamp).
to: End of period (Timestamp).

LGTM!


fix: flush empty outputs

This change fixes a bug that prevented mo.spinner() from being cleared on context manager exit (previously it was only cleared at the end of cell execution, by the cell's last expression -- but when running in a callback there is no "last expression").

@mscolnick FYI added a unit test. It's kind of messy


Handle DNS TXT record sets with > 1 record

Some domains have multiple TXT records. Although this is not allowed in the specification (link), it would still be good to handle it.

TXT RRs MUST be unique for a particular selector name; that is, if there are multiple records in an RRset, the results are undefined.

The easiest option is probably to just add them all - any faulty ones will be handled by https://github.com/zkemail/archive.prove.email/issues/85
Alternatively, parse them and pick those that are valid DKIM TVL and have valid ASN1 DER encoded public key in p=.
At the moment, we have just picked the first record. But there seem to be a few cases in the archive (could be as much as 1%), for which we have actually missed the "real" key because the record with the real key was preceded by some invalid value. They are easy to find though, so we can process them and add any extra selectors.
One example:
dig default._domainkey.ictwaarborg.nl txt +short returns 2 records:
Record 1 (note the underline in _p=):
"_v=DKIM1; k=rsa; _p=MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDLjLBpwYVJZWQ46dsN7UE/BdLPgZPg5FTz/FirVwuaiv5/TYyPskX1Xd4Bc7owME/b7QJv4J81T4gn5G/pLtY8fAqhWI6oLUb1stGjpERHqDClwIf7/k0jXlSPt62NrOeG2pcme+8pICY5hmxLrwoeII3TMiOnO/qS9m4zVHZIKwIDAQAB"

Record 2 (probably the correct one):
"v=DKIM1; k=rsa; p=MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA3+OfJn9qgnu0NqgIYzH9lvsXnHe6fq5Od7PmEmDWvsBLxG3MVj+v694Kzgjhce9J4KGzI4/yyy6rbsdOhPtPcBVmhxNvNsWj1Dbd+NAs8/cEKRrk+ToU1zSl7fFAb6D7Vu68WDVxBo3OKAwBjiJFByD4+uqzNy+RMQFPwcIu2eSu6WpH05KChCblw4uKVrkjN" "r4ZvjoKhrI66+MMoZm1GCe6CbngnzHGphYpc8BOs/V0/NJQu1ovc1LqKLgKQywzard2O1DmOAnXMfx0e59oiDzEh6DsFU8LWlWwg8sZkPNcmhCTRsX56MbvLZRd2NiQMnhQtUZHmd/eFHvzJlqptwIDAQAB;"

Another example:
dig mail._domainkey.flyadeal.com TXT +short
"k=rsa"
"k=rsa;p=MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDeMVIzrCa3T14JsNY0IRv5/2V1/v2itlviLQBwXsa7shBD6TrBkswsFUToPyMRWC9tbR/5ey0nRBH0ZVxp+lsmTxid2Y2z+FApQ6ra2VsXfbJP3HE6wAO0YTVEJt1TmeczhEd2Jiz/fcabIISgXEdSpTYJhb0ct0VJRxcg4c8c7wIDAQAB"

Observation:
Some domains have divided the data in several records (instead of several partial strings of the same record, which is the normal way)
In the example below, the data is divided in 3 records, which are returned in a random order. To handle cases like this, we would need to try to concatenate together in all possible combinations and see which combination gives a valid key. Maybe for the time being, this is not worth the extra complexity, also given that this does not follow the DKIM specification.
> dig +short TXT mandrill._domainkey.galleon.ph

"B3tVFB+Ch/4mPhXWiNfNdynHWBcPcbJ8kjEQ2U8y78dHZj1YeRXXVvWob2OaKynO8/lQIDAQAB;"

"v=DKIM1; k=rsa; p=MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQCrLHiExVd55zd/IQ/J/mRwSR"

"MAocV/hMB3jXwaHH36d9NaVynQFYV8NaWi69c1veUtRzGt7yAioXqLj7Z4TeEUoOLgrKsn8YnckGs9i3"

fixed by https://github.com/zkemail/archive.prove.email/commit/8d009003ec5cbaea11499997a463d65a0f28bc4b


Fix broken codesign option for bundle dependency

Resolves @mime29 's case https://github.com/yonaskolb/XcodeGen/issues/1022#issuecomment-874434220

@yonaskolb Okay, I added a changelog sentence 👍

Thanks @kateinoigakukun!


refactor(sdk): always capture tag in tensorboard logs

@kptkin I updated this PR and added a CoreLogger.With method which is a nicer way to accomplish this.


Concurrent data generation (thread safety)

I'm using faker to generate data for a simulation that has multiple goroutines. It seems faker is currently unable to work with more than a single thread due to the fact that it uses rand.NewSource
here .
The docs say:
NewSource returns a new pseudo-random Source seeded with the given value. Unlike the default Source used by top-level functions, this source is not safe for concurrent use by multiple goroutines.

https://golang.org/pkg/math/rand/
It would be great to make it so we're able to use faker across multiple threads.

can write an example of how you use faker in multiple goroutines?

on this topic I've found this discussion

We can add methods from native package and set seed
rand.Seed(time.Now().UnixNano()) as suggested in the discussion.
I put this entry in the general function(FakeData)
func FakeData(a interface{}) error {
	rand.Seed(time.Now().UnixNano())
// ...

// excerpt
func randomString(n int) string {
	b := make([]byte, n)
	for i, cache, remain := n-1, rand.Int63(), letterIdxMax; i >= 0; {

I did not notice that he did the same
 ZwbxVNpRjFBVyWfARJTCZRKqS WQJphBDMjQZmYkmrYVgHJWVkM ZrIWzJKnMQrxIUXAuvFaCZFHF zLTjnSfNjILIQfjsXnmakPEAa JExvPuGysQIoZnSlqlCdUGbat

@rdelval Do you have any suggestions?
You or I can send PR, just let us know)

In this case, to keep the pseudo-randomess it's best to keep a single seed set at the beginning of the initialization and use the default source throughout the rest of the program.
I'll raise a PR and we can continue the discussion there.
Thanks for looking into this and being receptive to feedback!

PR https://github.com/bxcodec/faker/pull/23


TESSCut TPFs do not display a target ID

At tess.party, a user pointed out that the string representation of a TESSCut TPF displays an empty TICID, which is unhelpful:
[1]: lk.search_tesscut("TIC167304735", sector=2).download()
TessTargetPixelFile(TICID: )

Thank you for reporting this issue @tfetherolf!  :+1:
It has been resolved over in #477!


[Event Request] Report 99001020 - Carry Out Action Msg. - Plan. - OnRefOrderTypePurchaseOnBeforeCarryOutActions

Hi,
Would it be possible to update the OnRefOrderTypePurchaseOnBeforeCarryOutActions event in Report 99001020 (Carry Out Action Msg. - Plan.), like this:
dataset
    {
        dataitem("Requisition Line"; "Requisition Line")
        {
            DataItemTableView = SORTING("Worksheet Template Name", "Journal Batch Name", "Vendor No.", "Sell-to Customer No.", "Ship-to Code", "Order Address Code", "Currency Code", "Ref. Order Type", "Ref. Order Status", "Ref. Order No.", "Location Code", "Transfer-from Code");
            RequestFilterHeading = 'Planning Line';

            trigger OnAfterGetRecord()
            var
                IsHandled: Boolean;
            begin
                IsHandled := false;
                OnBeforeRequisitionLineOnAfterGetRecord("Requisition Line", CombineTransferOrders);
                if not IsHandled then
                    WindowUpdate;

                if not "Accept Action Message" then
                    CurrReport.Skip();
                LockTable();

                Commit();
                case "Ref. Order Type" of
                    "Ref. Order Type"::"Prod. Order":
                        if ProdOrderChoice <> ProdOrderChoice::" " then
                            CarryOutActions(2, ProdOrderChoice, ProdWkshTempl, ProdWkshName);
                    "Ref. Order Type"::Purchase:
                        begin
                            IsHandled := false;

                           //*****START
                            OnRefOrderTypePurchaseOnBeforeCarryOutActions("Requisition Line", PurchOrderChoice, ReqWkshTemp, ReqWksh,
                               IsHandled, NoPlanningResiliency, CounterFailed);
                           //*****END

                            if not IsHandled then
                                if PurchOrderChoice = PurchOrderChoice::"Copy to Req. Wksh" then
                                    CarryOutActions(0, PurchOrderChoice, ReqWkshTemp, ReqWksh);
                        end;
                    "Ref. Order Type"::Transfer:
                        if TransOrderChoice <> TransOrderChoice::" " then begin
                            CarryOutAction.SetSplitTransferOrders(not CombineTransferOrders);
                            CarryOutActions(1, TransOrderChoice, TransWkshTemp, TransWkshName);
                        end;
                    "Ref. Order Type"::Assembly:
                        if AsmOrderChoice <> AsmOrderChoice::" " then
                            CarryOutActions(3, AsmOrderChoice, '', '');
                    else
                        CurrReport.Skip();
                end;
                Commit();

                OnAfterRequisitionLineOnAfterGetRecord("Requisition Line", ProdOrderChoice);
            end;

[IntegrationEvent(true, false)]
    local procedure OnRefOrderTypePurchaseOnBeforeCarryOutActions(var RequisitionLine: Record "Requisition Line"; PurchOrderChoice: Option " ","Make Purch. Orders","Make Purch. Orders & Print","Copy to Req. Wksh"; ReqWkshTemp: Code[10]; ReqWksh: Code[10]; var IsHandled: Boolean; NoPlanningResiliency: Boolean; var CounterFailed: Integer);
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Ubuntu 2004 image build fails when install ruby with script ruby.sh

Description
Ubuntu 2004 image build fails when install ruby.sh
Area for Triage:
Ruby
Question, Bug, or Feature?:
Cannot build the image with packer
Virtual environments affected

[ ] Ubuntu 16.04
[ ] Ubuntu 18.04
[X] Ubuntu 20.04
[ ] macOS 10.15
[ ] macOS 11.0
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

Image version
Ubuntu 2004
Expected behavior
Packer installation ends with success
Actual behavior
Packer installation shows those errors when install gem dependencies of ruby. Image build is canceled
Raw logs are here:
rawlog.txt
Here the errors during the execution of ruby.sh
azure-arm: Building native extensions. This could take a while...
==> azure-arm: ERROR:  Error installing readline-ext:
==> azure-arm: 	ERROR: Failed to build gem native extension.
==> azure-arm:
==> azure-arm:     current directory: /var/lib/gems/2.7.0/gems/readline-ext-0.1.1/ext/readline
==> azure-arm: /usr/bin/ruby2.7 -I /usr/lib/ruby/2.7.0 -r ./siteconf20210504-187946-lnaij1.rb extconf.rb
==> azure-arm: checking for tgetnum() in -lncurses... yes
==> azure-arm: checking for readline/readline.h... no
==> azure-arm: checking for editline/readline.h... no
==> azure-arm: *** extconf.rb failed ***
==> azure-arm: Could not create Makefile due to some reason, probably lack of necessary
==> azure-arm: libraries and/or headers.  Check the mkmf.log file for more details.  You may
==> azure-arm: need configuration options.
azure-arm: Successfully installed google-apis-storage_v1-0.3.0
azure-arm: Building native extensions. This could take a while...
==> azure-arm: invalid options: -SHN
==> azure-arm: (invalid options are ignored)
==> azure-arm: /usr/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:92:in `require': cannot load such file -- rdoc/markup/table (LoadError)
azure-arm: Parsing documentation for aws-sdk-kms-1.43.0
azure-arm: Installing ri documentation for aws-sdk-kms-1.43.0
azure-arm: Parsing documentation for aws-sdk-s3-1.94.0
azure-arm: Installing ri documentation for aws-sdk-s3-1.94.0
azure-arm: Parsing documentation for fastlane-2.181.0
azure-arm: Installing ri documentation for fastlane-2.181.0

==> azure-arm: Provisioning step had errors: Running the cleanup provisioner, if present...
Repro steps
Launch ./images.CI/linux-and-win/build-image.ps1 with parameters
-ResourcesNamePrefix 1_1 `
Other parameters depends by environment
-ClientId $(CLIENT_ID)                         -ClientSecret $(CLIENT_SECRET)
-TemplatePath $(TemplatePath)                         -ResourceGroup $(AZURE_RESOURCE_GROUP)
-StorageAccount $(AZURE_STORAGE_ACCOUNT)                         -SubscriptionId $(AZURE_SUBSCRIPTION)
-TenantId $(AZURE_TENANT)                         -Location $(AZURE_LOCATION)
-VirtualNetworkName $(BUILD_AGENT_VNET_NAME)                         -VirtualNetworkRG $(BUILD_AGENT_VNET_RESOURCE_GROUP)
-VirtualNetworkSubnet $(BUILD_AGENT_SUBNET_NAME)

Duplicate https://github.com/actions/virtual-environments/issues/3303


Add instructions about installing with go get

Closed by https://github.com/git-hooks/git-hooks/pull/31

Thanks for figuring out the issue, I have update the description in another PR :)


BROOKLYN-567 Prevent mutating EntitySpecSupplier's flag field

I believe this fixes the issue.
Glad to do a little Sunday hiking in Apache Brooklyn.

good to see you hiking these trails!  is #911 a safe further simplification of this?
(merging that will merge this; if there are subtleties that it misses then good to explain them here and then we can merge this and close that)


[BUG] Extra recurring jobs being created after volume restoration

Describe the bug
Test case test_recurring_job_restored_from_backup_target fails on master-head:
https://ci.longhorn.io/job/public/job/master/job/sles/job/amd64/job/longhorn-tests-sles-amd64/961/testReport/tests/test_recurring_job/test_recurring_job_restored_from_backup_target_s3_/
set_random_backupstore = None
client = <longhorn.Client object at 0x7f7cfef45910>
batch_v1_api = <kubernetes.client.api.batch_v1_api.BatchV1Api object at 0x7f7d0d5db450>

    @pytest.mark.recurring_job  # NOQA
    def test_recurring_job_restored_from_backup_target(set_random_backupstore, client, batch_v1_api):  # NOQA
        """
        Scenario: test recurring job backup (S3/NFS)

        1. Create a volume and attach it to a node or a workload.
        2. Create some recurring jobs (some are in groups)
        3. Label the volume with created recurring jobs (some are in groups)
        4. Create a backup or wait for a recurring job starting
        5. Wait for backup creation completed.
        6. Check if recurring jobs/groups information is stored in
           the backup volume configuration on the backup target

        7. Create a volume from the backup just created.
        8. Check the volume if it has labels of recurring jobs and groups.

        9. Delete recurring jobs that are already stored in the backup volume
           on the backup.
        10. Create a volume from the backup just created.
        11. Check if recurring jobs have been created.
        12. Check if restoring volume has labels of recurring jobs and groups.
        """
        common.update_setting(client,
                              common.SETTING_DEGRADED_AVAILABILITY, "false")

        SCHEDULE_1WEEK = "0 0 * * 0"
        SCHEDULE_2MIN = "*/2 * * * *"
        snap1 = SNAPSHOT + "1"
        back1 = BACKUP + "1"
        back2 = BACKUP + "2"
        group1 = "group01"
        volume_name1 = "record-recur" + "-" + generate_volume_name()
        rvolume_name1 = "restore-01" + "-" + generate_volume_name()
        rvolume_name2 = "restore-02" + "-" + generate_volume_name()

        recurring_jobs = {
            back1: {
                TASK: BACKUP,
                GROUPS: [DEFAULT],
                CRON: SCHEDULE_2MIN,
                RETAIN: 1,
                CONCURRENCY: 1,
                LABELS: {},
            },
            snap1: {
                TASK: SNAPSHOT,
                GROUPS: [],
                CRON: SCHEDULE_1MIN,
                RETAIN: 2,
                CONCURRENCY: 1,
                LABELS: {},
            },
            back2: {
                TASK: BACKUP,
                GROUPS: [group1],
                CRON: SCHEDULE_1WEEK,
                RETAIN: 3,
                CONCURRENCY: 3,
                LABELS: {},
            },
        }

        common.update_setting(client,
                              SETTING_RESTORE_RECURRING_JOBS, "true")

        create_recurring_jobs(client, recurring_jobs)
        check_recurring_jobs(client, recurring_jobs)

        volume = client.create_volume(name=volume_name1, size=SIZE,
                                      numberOfReplicas=2)
        volume = wait_for_volume_detached(client, volume_name1)
        volume = volume.attach(hostId=get_self_host_id())
        volume = wait_for_volume_healthy(client, volume_name1)
        volume.recurringJobAdd(name=snap1, isGroup=False)
        volume.recurringJobAdd(name=back1, isGroup=False)
        volume.recurringJobAdd(name=group1, isGroup=True)
        wait_for_volume_recurring_job_update(volume,
                                             jobs=[snap1, back1],
                                             groups=[DEFAULT, group1])

        write_volume_random_data(volume)
        time.sleep(120)

        # 2 from job_snap, 1 from job_backup, 1 volume-head
        wait_for_snapshot_count(volume, 4)

        complete_backup_1_count = 0
        restore_snapshot_name = ""
        wait_for_backup_completion(client, volume_name1)
        volume = client.by_id_volume(volume_name1)
        for b in volume.backupStatus:
            if back1+"-" in b.snapshot:
                complete_backup_1_count += 1
                restore_snapshot_name = b.snapshot

        assert complete_backup_1_count == 1

        volume.detach()

        # create a volume from the backup with recurring jobs exist
        _, backup = find_backup(client, volume_name1, restore_snapshot_name)
        client.create_volume(name=rvolume_name1,
                             size=SIZE,
                             fromBackup=backup.url)
        rvolume1 = wait_for_volume_detached(client, rvolume_name1)
>       wait_for_volume_recurring_job_update(rvolume1,
                                             jobs=[snap1, back1],
                                             groups=[DEFAULT, group1])

test_recurring_job.py:2073:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

volume = {'accessMode': 'rwo', 'backingImage': '', 'backupCompressionMethod': 'lz4', 'backupStatus': [], 'cloneStatus': {'snaps...218', 'parameters': {'disableFrontend': 'true'}, 'satisfied': False}}, 'volume': 'restore-01-longhorn-testvol-76zhnm'}}
jobs = ['snapshot1', 'backup1'], groups = ['default', 'group01']

    def wait_for_volume_recurring_job_update(volume, jobs=[], groups=[]):
        ok = False
        for _ in range(RETRY_COUNTS):
            volumeJobs, volumeGroups = get_volume_recurring_jobs_and_groups(volume)
            try:
                assert len(volumeGroups) == len(groups)
                for group in groups:
                    assert group in volumeGroups

                assert len(volumeJobs) == len(jobs)
                for job in jobs:
                    assert job in volumeJobs

                ok = True
                break
            except AssertionError:
                time.sleep(RETRY_INTERVAL)
>       assert ok
E       AssertionError

common.py:5541: AssertionError

According to the description of setting Restore Volume Recurring Jobs:
Restore recurring jobs from the backup volume on the backup target and create recurring jobs if not exist during a backup restoration.

Recurring jobs will be created if not exist during a backup restoration, but on master-head, even though the recurring jobs have already existed, extra recurring jobs are still created after a backup restoration:
The original volume uses existing recurring jobs:

Then restore a volume from the backup of the original volume, the restored volume uses automatically created recurring jobs with restored-recurring-job- prefix:

Unexpected recurring jobs with restored-recurring-job- prefix are created:

To Reproduce
Run test case test_recurring_job_restored_from_backup_target
Expected behavior

Support bundle for troubleshooting

Environment

Longhorn version: master-head
Impacted volume (PV):
Installation method (e.g. Rancher Catalog App/Helm/Kubectl): helm
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: v1.30.0+k3s1

Number of control plane nodes in the cluster:
Number of worker nodes in the cluster:

Node config

OS type and version: sles 15-sp5
Kernel version:
CPU per node:
Memory per node:
Disk type (e.g. SSD/NVMe/HDD):
Network bandwidth between the nodes (Gbps):

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal):
Number of Longhorn volumes in the cluster:

Additional context

Test case test_recurring_job_restored_from_backup_target failed for the same reason: https://ci.longhorn.io/job/public/job/master/job/sles/job/arm64/job/longhorn-tests-sles-arm64/896/testReport/tests/test_recurring_job/test_recurring_job_restored_from_backup_target_s3_/

This is a regression from the new feature in v1.7.0
Full backup support: https://github.com/longhorn/longhorn/issues/7070
no need to backport

Hello @mantissahz
Can you help the verification? Thanks.

e2e test passed:
https://ci.longhorn.io/job/private/job/longhorn-tests-regression/7207/

Verified PASSED with longhorn-manager-test:master-head (36a79e7015fc)
Ran test case test_recurring_job_restored_from_backup_target 60 times (s3 30 times, NFS 30 times) on the test server.
https://ci.longhorn.io/job/private/job/longhorn-tests-regression/7209/


fix: ingress LB status records

Signed-off-by: Jintao Zhang<EMAIL_ADDRESS>Please answer these questions before submitting a pull request

Why submit this pull request?

[x] Bugfix

[ ] New feature provided

[ ] Improve performance

[ ] Backport patches

Related issues

Bugfix

Description

How to fix?

New feature or improvement

Describe the details and related test reports.

Backport patches

Why need to backport?

Source branch

Related commits and pull requests

Target branch

Codecov Report

Merging #788 (2032d88) into master (1bbadf0) will decrease coverage by 0.30%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #788      +/-   ##
==========================================
- Coverage   32.42%   32.11%   -0.31%
==========================================
  Files          65       65
  Lines        6872     6875       +3
==========================================
- Hits         2228     2208      -20
- Misses       4396     4412      +16
- Partials      248      255       +7

Impacted Files
Coverage Δ

pkg/ingress/status.go
0.00% <0.00%> (ø)

pkg/apisix/plugin.go
80.00% <0.00%> (-20.00%)
:arrow_down:

pkg/apisix/cluster.go
30.02% <0.00%> (-3.31%)
:arrow_down:

pkg/apisix/route.go
36.91% <0.00%> (-2.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bbadf0...2032d88. Read the comment docs.


Update Content Community of Practice text

We've received a request to update the content regarding our content community of practice on dta.gov.au. The request included some references to Guides.
What do you need?
On https://guides.service.gov.au/content-guide/, can you please update the text reading Join our government content community to make suggestions and provide feedback. to read, Join our government [Content Community of Practice](https://www.dta.gov.au/help-and-advice/communities-practice#content-design-and-strategy-community) to make suggestions and give feedback. To join, email [content@dta.gov.au](mailto:content@dta.gov.au)?

Thanks @imperator99 I'll take a look.


[Improvement] Make ProcBuilder decouple with YARN

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

What would you like to be improved?
Currently, ProcBuilder#killApplication's implementation suppose that all the engine process would be started via submitting an application to YARN. But this suppose may be not right, e.g. Flink SQL Engine.
How should we improve?
No response
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

+1


openssh_hpn: 9.2p1 -> 9.3p1

Description of changes
Update the OpenSSH HPN to 9.3p1 from the FreeBSD port
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

This should probably be backported to stable, given that it resolves a CVE?


Adding more useful information to mutation tooltip

When we zoom in to single points on the plot showing mutations by time and genomic position, we can see the time of node above mutation and the genomic position at the tooltip. This information can be read off the axes and it would probably be more useful to investigate specific mutations, if we display the mutation ID, number of descendants and number of inheritors instead.

completed in #70


[8.x] Introducing Job Encryption

This PR adds a UsesEncryption interface. When the interface is used, laravel will encrypt the command inside the payload and decrypt it while running CallQueuedHandler.
Encrypting the command payload hides the job class properties which may hold sensitive information (API keys, passwords, personal information, etc...).

Is there any downside to using this all the time?

@crnkovic The overhead of encryption/decryption plus the extra payload size might not be necessary for most jobs.

@themsaid With the implementation of AES operations directly into most modern CPUs' instruction set, OpenSSL encryption/decryption (which Laravel uses) runs very, very fast. There is no overhead. 2 MB of data gets encrypted and decrypted in 0.050s with OpenSSL using AES-256-CBC as cipher. But I (relatively) agree with the payload size though, especially when using in-memory store like redis (or SQS which has the payload limit) since the payload size will double when encrypted.

@themsaid can we put an integration test on this?

@taylorotwell done


Release notes for 329

Hive
* Delete HDFS location when dropping an empty schema. (:issue:`2463`)

https://github.com/prestosql/presto/pull/2466

General
* Fix incorrect result of ``last_day_of_month`` function for first day of month. (:issue:`2452`)

https://github.com/prestosql/presto/pull/2454 https://github.com/prestosql/presto/issues/2452

Hive
* Fix incorrect data returned when using S3 Select on uncompressed files. In our testing, S3 Select
  was apparently returning incorrect results when reading uncompressed files, so S3 Select is disabled
  for uncompressed files. (:issue:`2399`)
* Fix incorrect data returned when using S3 Select on a table with ``skip.header.line.count`` or
  ``skip.footer.line.count`` property. S3 Select API does not support skipping footers or more than one
  line of a header.  In our testing, S3 Select was apparently sometimes returning incorrect results when
  reading a compressed file with header skipping, so S3 Select is disabled when any of these table
  properties is set to non-zero value. (:issue:`2399`)

https://github.com/prestosql/presto/pull/2399

Hive
* Fix ``INSERT`` or ``CREATE TABLE .. AS`` query failure when one of the inserted ``REAL`` or ``DOUBLE`` values
  is infinite or ``NaN``.

https://github.com/prestosql/presto/pull/2471

Hive
* Add explicit support for conversion from Parquet decimal
column type to Presto integer column types. (:issue:`2451`)
* Add validation of Parquet decimal column type scale (:issue:`2451`)

https://github.com/prestosql/presto/pull/2451

General
---
- Handle common disk failures during the spill. When on of disks got broken, it Presto will use another one without failing the query. (:issue:`2444`)

#2444

General
-------

* Reduce number of metadata queries when querying `information_schema`. (:issue:`2488`)

https://github.com/prestosql/presto/pull/2488

Hive
----

* Execute table and partition drops in parallel. (:issue:`1812`)

https://github.com/prestosql/presto/pull/1812


improve the search button & fix it

change the search icon style & improve its ui
before👇🏻

after 👇🏻

Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!


[?] Add a note for red users to pin or move future development to a new branch

@mikeshardmind Pick one and I'll write up the details.

I don't want to break existing users since I'm keeping the git history anyway with there being some insights available in git history as to why certain things are a specific way.
v3 branch will remain safe for use with red, or at the very least, wont be intentionally broken.


Migrate CI from Travis/Appveyor to Github actions

Since Travis is significantly reducing the open-source offerings (See this Julia thread), I believe we should switch to Github actions. I have performed the migration for the osqp-python but the CI of the main repo still needs to be ported.
I would really appreciate if anyone could help migrating the scripts in the /ci folder.

Related to reformatting CI: Bintray will close on 01 May 2021.
We should start attaching artifacts to github releases.

The Appveyor and TravisCI pieces have now been completely removed and replaced with GitHub actions.

Still, there is no place to download the binaries (For example, for MATLAB) from.

You can find the binaries here. If you want to install MATLAB from binaries, try running
websave('install_osqp.m','https://raw.githubusercontent.com/osqp/osqp-matlab/master/package/install_osqp.m');
install_osqp


@conda-forge-admin, please add user @zigaluksic

Additional comment:
@zigaLuksic is maintainer of the eo-learn.

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added user @zigaluksic in conda-forge/eo-learn-ml-tools-feedstock#24.


Issues on the current implementation

With higher priority

Document

Remove the signing/verification step at the level of Transaction.Payload (VerifyAndParseDocument)
Authorization needs to be considered more seriously to guard security (IsDocumentAuthorized)
A posted document should be checked somewhere that it contains (all of) the latest descriptors that are recorded in the application. This is not considered in the current implementation, so maybe we should add IsDocumentComplete. Alternatively, we could let the application create the document automatically when it calls Commit, and do not need transactions that deal with adding documents.
Add utility functions to help create valid documents

Query

Should provide suitable ProofOps inside the query response (for light clients)
Should properly define keys of the query
If descriptors are mentioned in the doc only through their keys, the application should also allow query for descriptors.

Transaction

Use either eddsa or ed25519 package, but not both at the same time to avoid misuse

Application Unit Test

Write tests on all types of commands (only 1 of them is covered for now)
The tests should use tendermint ABCIQuery to check for results with proof required

With lower priority

Move syntactic and semantic checks from executeTx to isTxValid as many as possible
Naming on error codes inside application

@greatect
For the validating the latest descriptors in document, we didn't log the updated/created time for the descriptors, might need to add another map for this. And what's your concern about not including the latest descriptor?
For the utility, I think we need to add another function to create descriptors too. I already write the steps to create the documents and descriptors in tests.
For the query, it look good to me. The hardest part might be fetching merkle proof from tendermint because we didn't store another proof.
I totally agree with adding more unit test and formalize the usage of eddsa/ed25519.

@sc0Vu
If we do not make such checks on the document, it could include a complete different set of nodes than the ones that were published on the app. So the document has to refer back to previous transactions (or the affected state) where descriptors were published.
I also mentioned the query keys because we could clarify there what type of commands we are handling then (through prefix). We could also do these taggings in our keys when updating the database. Another reason to do this is that both the mix descriptors and authorities have storing keys being their public keys (although for now they are processed with different encoding styles, but maybe we should use base64 in both), but we should allow nodes to act as both at the same time.

With higher priority

Document

[ ] Remove the signing/verification step at the level of Transaction.Payload (VerifyAndParseDocument)

[ ] Authorization needs to be considered more seriously to guard security (IsDocumentAuthorized)

[ ] A posted document should be checked somewhere that it contains (all of) the latest descriptors that are recorded in the application. This is not considered in the current implementation, so maybe we should add IsDocumentComplete. Alternatively, we could let the application create the document automatically (generateDocument of katzenpost authority) when it calls Commit, and do not need transactions that deal with adding documents.

[ ] Add utility functions to help create valid documents

Query

[ ] Should provide suitable ProofOps inside the query response (for light clients)

[ ] Should properly define keys of the query

[ ] If descriptors are mentioned in the doc only through their keys, the application should also allow query for descriptors.

Transaction

[ ] Use either eddsa or ed25519 package, but not both at the same time to avoid misuse

Application Unit Test

[ ] Write tests on all types of commands (only 1 of them is covered for now)

[ ] The tests should use tendermint ABCIQuery to check for results with proof required

With lower priority

[ ] Move syntactic and semantic checks from executeTx to isTxValid as many as possible
[ ] Naming on error codes inside application

These issues have been dealt with


Fix NLopt relative solution tolerance, add max feval NLopt criterion

The relative X tolerance criterion was previously set to optsum.ftol_rel
(this may have been a typo). This change changes it to optsum.xtol_rel
In addition, this sets the NLopt maxeval stopping criterion to
optsum.feval ( -1 by default)

Coverage increased (+0.02%) to 82.043% when pulling 86f41401d29ee8d7196fd92754740193df62ae4d on kaskarn:master into fffc2d11d3dd84c5d907b757b625f9129b650314 on dmbates:master.

Thank you for catching these issues.


MNE-NIRS shows up as not installed in "mne sys_info" in CI jobs

Needs to be investigated, haven't had a look at this locally.

Probably an issue where the latest release is not compatible with MNE-Python dev / mne.externals removal. Any error on input makes a library show up as not installed.


v6.0.0 causes app to freeze

Solely by upgrading the Mixpanel SDK in our app to v6.0.0, the app freezes when starting a new activity.
We need to pause and resume the app for the new activity to be displayed.
I tested the upgrade from both our current version (v5.6.4) but also the previous latest one (v5.9.6).
Note: This only occurs when upgrading the app. Everything seems to work fine on a clean app install with v6.0.0
https://user-images.githubusercontent.com/5360604/148970104-c2fa652b-2e9e-4586-80d8-179d110cdfa0.mp4

hi @mrstif , thanks for bringing it up. We will have a look.

hi @mrstif , we could not replicate the issue. Could you turn on the Mixpanel log (mixpanel.setEnableLogging(true); ), When you tap the item and it causes the freeze, do you track any events or call any Mixpanel API from there? If you do, is there any Mixpanel log you could share? The main difference for 6.0.0 is that it removes Messages and A/B testing related features. Do you have any A/B testing related setups previously?

I'm closing this one now due to no activity, please feel free to reopen if you believe the problem still exists.


RT-748-Simplified-layer-options-panel

Overview
Use RxJS Subject for multicasted values to many Observers.
Pass showLayerOptionPanel is equal to false from the app-component.html file to the fhir-chart-layout.component and then use RxJs Subject for the passed value to dataset-options.component.
Write functions in shared-data-layer-service for set subject$ value and getting subject$ value.
Write test cases for shared-data-layer-service.
Update test cases according to changes.
How it was tested
Tested using run all charts-on-fhir apps.
Checklist

[x] The title contains a short meaningful summary
[x] I have added a link to this PR in the Jira issue
[x] I have described how this was tested
[x] I have included screen shots for changes that affect the user interface
[x] I have updated unit tests
[x] I have run unit tests locally
[ ] I have updated documentation (including README)

In cardio-health-app

In showcase app

We do not want to show the "point size" slider when advanced options are disabled. The only option we want is line smoothing.

@semicolin can you please show me what is line smoothing

@semicolin can you please show me where is line smoothing

Oh sorry, it's called "Cubic Interpolation". We should probably change that label to "Line Smoothing".


Make required numpy version less strict

Right now, this repository depends on a rather outdated version of numpy,  Thus, if I want to use these stubs in a project, I have to use an old version of numpy, which doesn't seem ideal.  I just changed the numpy requirement to be more permissive; I would imagine that numpy's api hasn't changed in such a way to make these stubs invalid since numpy 1.14. Ideally, this would be updated in sync with numpy's release cycle to keep the dependencies in sync, but it doesn't seem like there's been much activity on this repository for a while.  I really just want to be able to type pip install git+https://github.com/numpy/numpy-stubs and have something that works without having to downgrade numpy -- this pull request should do that :)

Thanks!


How are the docs being translated to other languages?

Hey folks,
I have a question - how are the docs being translated to other languages - here is an example of german article: https://docs.microsoft.com/de-de/windows/apps/windows-app-sdk/release-channels#features-available-by-release-channel
In the repo I only see MD files in English? Or is it some automated translation?

Hi -
Most topics are translated by a ML system, but some are done by hand. There is no repo that is accessible containing German (or any language other than English).
The URL you shared contains de-de, which means your browser gets this translated version. You can adjust settings to always see English if you prefer.
If you need to make a specific correction to German content, please create another issue with feedback on that topic and it can be passed to the localization team.
thanks!
-john


Extracting Components of Responsive Classes

First of all congratulations to and a big thanks for releasing Tailwind, it's looking great so far.
I'm having one problem which I'm not quite sure on how to best solve: Currently it's not possible to use breakpoint prefixes when extracting a component. Any chance to make this happen?
Currently when trying to do something like:
.foo {
    @apply .bg-blue .sm:bg-green;
}

I get: CssSyntaxError: /Users/daniel/lab/tailwind/src/styles.css:21:5: No .sm\:bg-green class found.

I wasn't able to test this but I think it might work:
.foo {
   @apply .bg-blue;
   @screen sm {
      @apply .bg-green;
   }
}

Hm, that gives me:
internal/streams/legacy.js:59
      throw er; // Unhandled stream error in pipe.
      ^
Error: CSS parse error styles.css: Identifier is expected
 3647 |
 3648 |  @media (min-width: 576px) {
 3649 |    background-color: #38c172;
----------------------------^
 3650 |  }
 3651 |}

That is strange because this page of the docs has this example:
.btn {
  &:hover {
    @apply .bg-blue;
  }
  @screen md {
    @apply .inline-block;
  }
}

Which is why I thought that would work. Will try to test this myself later and see what I can find.

Hey! So that example from the docs page assumes you are using a preprocessor like Sass or Less, or even using CSSNext, all of which support that sort of nesting.
Tailwind itself doesn't bake that sort of thing in, so if you are just writing your stuff in raw CSS, you'll need to put the hover declarations and media queries outside of the original declaration:
.btn {
  /* ... */
}
.btn:hover {
  @apply .bg-blue;
}
@screen md {
  .btn {
    @apply .inline-block;
  }
}

Again, if you want to use the nested syntax, it's absolutely no problem to just write your CSS in Sass or Less; Tailwind doesn't care 👍
I've personally been enjoying using CSSNext lately, which is another PostCSS plugin for adding forward-facing CSS features, including support for nesting.
If you want to give that a shot, pull it in like this:
npm install postcss-cssnext

...then add it as a PostCSS plugin after Tailwind. Here's a quick example using Laravel Mix:
let cssnext = require('postcss-cssnext');

mix.postCss('resources/assets/css/app.css', 'public/css', [
  tailwindcss('./tailwind.js'),
  cssnext()
]);

CSSNext supports nesting media queries without doing anything fancy, and since Tailwind will convert any @screen rules into plain media queries before CSSNext sees your CSS, @screen is fully nestable as well.
Hope that helps!

Try moving postcss-nested after Tailwind, I usually use cssnext which
includes postcss-nested and that’s where I put that plugin.
On Sun, Jun 10, 2018 at 12:25 PM Kenyon Kowal<EMAIL_ADDRESS>wrote:

I haven't been able to get this to work with postcss-nested. Is this a
known problem?
Here's my postcss config
var tailwindcss = require('tailwindcss');
module.exports = {
plugins: [
require('postcss-easy-import')({ prefix: '_' }),
require('postcss-mixins'),
require('postcss-simple-vars'),
require('postcss-conditionals'),
require('postcss-nested'),
require('postcss-color-function'),
require('postcss-hexrgba')(),
tailwindcss('tailwind.js'),
require('autoprefixer')()
]
}
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tailwindcss/discuss/issues/12#issuecomment-396061988,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEH3bOehhxxai4wKlk5fRp9r-UzaLGkAks5t7Uh8gaJpZM4QPhV4
.

Ah yeah, that worked. Thanks!


refactor(accordion)!: perf and API improvements

What I did

Move stuff from BaseAccordion to PfeAccordion
Update and reorganize
Remove code from *Accordion*
refactor same

@marionnegp there are margins on the panel contents in the demo in this pr, that's because in keeping with semantic html best practises I wrapped the demo panel contents in <p>. so, even though this isn't a pixel-perfect match, I think there's room for the pr to pass design review here.

This looks great @bennypowers, really like the setup for the tests and the layout of the files.  I'll need to do some testing too with rh-accordion to see if I see any changes there but this is awesome.

I have a couple changes lined up for accordion, based on this PR

@bennypowers - Moved the single attribute into the child component since rh-accordion won't be needing it at this time (it was defaulting to true), just needed to be able to grab the headers from pfe-accordion to do so

@bennypowers are there still changes you want to make to this branch or are we good to update & merge?

i'm g2g


Merging multiple snapshots into a single HTML report

In Java Spring JUnit tests I collect the snapshots at the end of every test with
coverageBuilder.coverageSnapshot(processInstance);

and then I have a final action to save all the HTML reports
  @After
  public void saveCoverageSnapshots() {
    coverageBuilder.saveCoverageSnapshots();
  }

However I was wondering if there is already a functionality in place to merge all those reports into a single HTML file (so that a single coverage report is generated for every class, rather than for every process instance).
If it is already there and you could explain that to me, I'm happy to add an example to the readme too

No feature like that is currently implemented.  My thinking was: in cases where you needed a single file or report (like the Spock report image in the readme), you would create a HTML file with multiple embeds/iframes that are losing the needed HTML files.
Can you give me some more usage reasons for needing a single file?
Side note: we could add the ability to get the coverages as a list of input streams. And you could save these into a single HTML file.

Another item about my original thinking: there are multiple files because the snapshots were designed to be used throughout the process, not just at the end.  So there are multiple files to show the different shots of the single process.
If you have a single file, are you looking to add additional text like headers for each process/snapshot?

I believe that what you've done already is really good to check whether the path was correct or not and if it terminated correctly. My usage scenario is to generate a report that shows all the tasks that have been tested, and therefore determine if more tests are needed to achieve 100% coverage. Of course that single report won't take into account all the possible paths but just the task completion (a bit like the heat maps in Camunda Cockpit). I believe that summing the number of executions for each task (in the green box you have already) should be sufficient for this feature.
What do you think?

@LucaMozzo can you provide a use case scenario: Like a mock BPMN image showing the flow and describe how you are executing and the type of result you want to create/validate against? (What a good result looks like and what a bad/useless result looks like)

Ok let's pick a basic example.
I have a diagram that looks like this

I have a class with tests for each possible outcome, since I want to ensure that all cases work fine
class Tests {

@Test
void Task1Task2&Complete() {.  //test for red path
...
coverageBuilder.coverageSnapshot(processInstance);
}

@Test
void Task1Task3&CompleteWithErrors() {  //test for green path
...
coverageBuilder.coverageSnapshot(processInstance);
 }

  @After
  public void saveCoverageSnapshots() {
    coverageBuilder.saveCoverageSnapshots();
  }
}

So basically every time I call coverageSnapshot it "accumulates" the number of task executions and when I call saveCoverageSnapshots() it generates a single html report with the accumulated task executions. For instance in the first test I'll have
Task 1 : 1 execution
Task 2: 1 execution
Task 3: 0 executions
and after the second test
Task 1 : 2 executions
Task 2: 1 execution
Task 3: 1 execution
And a single diagram is exported with the values specified above.
If instead I wanted to generate a single report for every test (like it is working now) I would save the snapshots after every test:
class Tests {

@Test
void Task1Task2&Complete() {
...
coverageBuilder.coverageSnapshot(processInstance);
coverageBuilder.saveCoverageSnapshots();
}

@Test
void Task1Task3&CompleteWithErrors() {
...
coverageBuilder.coverageSnapshot(processInstance);
coverageBuilder.saveCoverageSnapshots();
 }
}

This is an example, and the way I thought the library was working by looking at the usage.
Of course in my example it doesn't make sense since it's really simple, but when you have 10+ workflows with about 5 to 10 tests each, you would be able to generate a single report for every workflow (like in the first snippet of code) ending up with 10 reports instead of 100.
Does this example help you understanding the scenario (on a bigger scale)?
Having a single file for each test is more informative because you can see each of the paths that have been covered, but on a large scale it's not possible to look at every single path.
The idea of the heat maps sounds good, but I don't know how much work it required, but having the general functionality in place with just the numbers like in your photo above would be enough

@LucaMozzo in your example (even at scale), why would you want the sums?  The sums seem to be a "cross-check", but they could easily throw a false positive due to other weird errors occurring.
Would you not want a Visual Per method? So you have a report for each method you are executing and thus validating visually each path?
class MyBPMN123Tests {

@Test
void Task1Task2&Complete() {
   ...
   coverageBuilder.coverageSnapshot("task1-task2-complete", processInstance);
}

@Test
void Task1Task3&CompleteWithErrors() {
   ...
   coverageBuilder.coverageSnapshot("task1-task3-complete-with-error", processInstance);

 }

@AfterClass
public static void teardown() {
   coverageBuilder.saveCoverageSnapshots();
}
}

With the above you would generate files with names of each method and only generate the snapshot.  I am assuming each @Test is a compartmentalized scenario and you are doing cleanup inbetween tests? aka you have new process instances per @test?

It's not much for "better visualisation" but more for admin. For instance you can't create a QA report with 70 screenshots attached to it, but you rather have a less informative diagram, but you can see at a first glance if all tasks have been covered in each of the workflows.
Of course for a more in-depth qualitative testing the current method would be the best.

@LucaMozzo okay so for the "QA Report" its more of a quick check without the need for further analysis, but you are accepting the risk that it could be a false positive?

Yes I am aware that the fact that, even if all tasks are completed, some paths might not have been covered. That just needs to be an approximate view

@LucaMozzo I have not had time to write the implementation for this, but I do have a solution for you which you can write with some post-class code:

I released v0.14.  In that version there is a setter and getter for the coverageSnapshots property.  You can now access this in your javaclass due to the addition of the getter. getCoverageSnapshots()

It will return a hashmap of <String, CoverageData>.  Using this you can post-process all of the coverage data snapshots into a single Coverage Data object.  Essentially you are doing a Merge/addition (would be a good use case for using a java 8 Stream.) of each of the coverageData objects' data/properties and creating a new coverage data object which is  new CoverageData(); (io.digitalstate.camunda.coverage.bpmn.CoverageData;) You can populate that object with the new aggregated values.

then do something like coverageBuilder.setCoverageSnapshots(["aggregated-data": theNewCoverageDataObject])

then coverageBuilder.saveCoverageSnapshots()

This should result in a single file being saved with your aggregated data.

@StephenOTT Thanks a lot, that's great!!


chore(tests): make reporter more silent

Current tests output is too verbose, this PR makes reporter more silent.

Released in<EMAIL_ADDRESS>


npm install

Investigate if an npm install method for swim is feasable (in addition to to the curl download option already supported).
This would be especially nice because npm supports versioning and updating far better than swim's current swim update command does.

curl works just fine


Allow ingredients and steps to be crossed out

Played around with this. I think it'd be a better UX to have a check{box/mark} at edge, and then set style that way rather than light strikethrough on hover

Played around with this. I think it'd be a better UX to have a check{box/mark} at edge, and then set style that way rather than light strikethrough on hover


Max frecuenzy sending data

HI,
We are using your library in arduino project to sent information to a mosquito v 2.0. For example, our data is this: 0000015KG to this topic: TopicEx.
We need to know the max speed in milliseconds that we can send this data. In our test we try this:
Frequency          Result
250 ms               Works about 1hour and a half and then lost connection
300 ms               Works about 1hour and a half and then lost connection
350 ms               Works about 1hour and a half and then lost connection
The time is more o less, not exactly.
We need to know whats is the best frequency to send data persistently....
Thanks

I can't give you any more information than your testing in your own environment on your own hardware will tell you.


docs(directive): Directive docs incorrectly shows arguments as a subsection of animations

Do you want to request a feature or report a bug?
Docs issue
What is the current behavior?
On the docs of directives which include the animation section, arguments are shown as a h3 element below the animation's h2 element, making it look like it's a subsection of animations.
Example: https://docs.angularjs.org/api/ng/directive/ngClass
What is the expected behavior?
Arguments sounds like a subsection of Usage. Moving the animation section (https://github.com/angular/angular.js/blob/master/docs/config/templates/ngdoc/api/directive.template.html#L64) to the end of the file, right before the last endblock would render the arguments h3 element after the usage h2 element.

I added a PR to demonstrate the change I'm talking about, but I'm more than happy to change the PR according to what gets discussed here.


Errors are not detected as errors and out is in the wrong order

I have some scripts that have errors in the execution but the job finishes as successful.
In some cases im also getting the error output printed before the output of echo commands that execute before it.
mv : Cannot create a file when that file already exists.
At C:\WINDOWS\TEMP\12-102-DIWEB_SelfService-dispatch-script.tmp.ps1:16 char:1
+ mv "./Temp/$ArtifactName" $env:TEMP
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : WriteError: (C:\Users\SI5559...ortal-0.5.0.zip:F
   ileInfo) [Move-Item], IOException
    + FullyQualifiedErrorId : MoveFileInfoItemIOError,Microsoft.PowerShell.Com
   mands.MoveItemCommand

Exception calling "ExtractToDirectory" with "2" argument(s): "Could not find
file 'C:\Users\SI555945\selfservice.portal-0.5.0.zip'."
At C:\WINDOWS\TEMP\12-102-DIWEB_SelfService-dispatch-script.tmp.ps1:19 char:1
+ [System.IO.Compression.ZipFile]::ExtractToDirectory($ArtifactName,
"./$ArtifactN ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
~~~
    + CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
    + FullyQualifiedErrorId : FileNotFoundException

I think it is known issue with powershell
please look at this, it may  help
http://stackoverflow.com/questions/15777492/why-are-my-powershell-exit-codes-always-0

About order.
All output and errors is collected and after that printing in one step.
But errors printed first.
I need to do it because errors come in xml format and i need to cleanup it for better read
I may try to change code for live output, but errors anyway will be collected and printed after all.
And I not sure that simple change will help.
Want to be beta tester?

@vvchik I understand the exit code, but maybe if you see something on stderror terminate with error... otherwise.
Im fine with errors being printed, but they should be printed in the order they would appear in a normal console output.
Im happy to beta test, just let me know which branch / release :D
Thanks!

if you see something on stderror terminate with error

Warnings also going via STERR...

May you please try code from https://github.com/NetDocuments/rd-winrm-plugin/tree/feature/longlive_output_error_order branch

Will do this Monday morning thanks!

Will do this Monday morning thanks!

Sorry for the delay i was having some issues with rundeck require of the winrm gem (still unresolved but  have worked around it)
Output:
 WARN  WinRM::WinRMWebService : WinRM::WinRMWebService#run_powershell_script is deprecated. Use WinRM::CommandExecutor#run_cmd instead
gonzalop-lt001\testuser
#< CLIXML
<Objs Version="<IP_ADDRESS>" xmlns="http://schemas.microsoft.com/powershell/2004/04"><S S="Error">dir : Cannot find drive. A drive with the name 'z' does not exist._x000D__x000A_</S><S S="Error">At line:1 char:57_x000D__x000A_</S><S S="Error">+ $ProgressPreference='SilentlyContinue';whoami;sleep 10; dir z:_x000D__x000A_</S><S S="Error">+                                                         ~~~~~~_x000D__x000A_</S><S S="Error">    + CategoryInfo          : ObjectNotFound: (z:String) [Get-ChildItem], DriveNotFoundException_x000D__x000A_</S><S S="Error">    + FullyQualifiedErrorId : DriveNotFound,Microsoft.PowerShell.Commands.GetChildItemCommand_x000D__x000A_</S><S S="Error"> _x000D__x000A_</S></Objs>

Notes:

There where some updates to winrm gem so that might be why the warning at the beginning
The error at the end is not parsed properly and im seeing the xml
The error is displayed at the end correctly
The error is not detected as an error and job finished "successfully"

Ok this seems to be an issue because of the way the winrm library outputs stderr/stdout ... Ill try and get it fixed over there.


feat(chat-e2e): add gpt 4o alias model to tests

Description:
add gpt 4o alias model to tests
Checklist:

[x] the pull request name complies with Conventional Commits
[x] the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
[ ] the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
[x] I confirm that do not share any confidential information like API keys or any other secrets and private URLs

/deploy-review


Pdf view not displaying for base64 data

I installed this library to view uploaded pdf. I m converting the uploaded file as base 64.
I m converting pdf to Base 64 as follows:
var selectedFile = document.getElementById("inputFile").files;
//Check File is not Empty
if (selectedFile.length > 0) {
// Select the very first file from list
var fileToLoad = selectedFile[0];
// FileReader function for read the file.
var fileReader = new FileReader();
var base64;
// Onload of file read the file content
fileReader.onload = function(fileLoadedEvent) {
base64 = fileLoadedEvent.target.result;
// Print data in console
console.log(base64);
};
// Convert data to base64
fileReader.readAsDataURL(fileToLoad);
}
i m giving the base64 value to view the pdf. But i m getting the following error in console
Failed to execute 'atob' on 'Window': The string to be decoded is not correctly encoded

you have to remove data:application/pdf;base64, from the generated base64 string to make it work.


Introduce the tracer pattern, and new patterns for configuration.

Coverage decreased (-3.0%) to 80.488% when pulling df1e61141807951e3f1428b25b1be8af40fa7e80 on modernize-config into 32cf69891d1440cbbcb24b27578cb99a0591cc52 on master.


New command: Revoke Sign-in Sessions

Usage
m365 entra user revokesessions [options]
Description
Revokes all sign-in sessions for a given user
Options

Option
Description

-i, --id [id]
The object ID of the user. Specify id or userName but not both.

-n, --userName [userName]
User principal name of the user. Specify id or userName but not both.

Examples
Revoke sign-in sessions of user with id 4fb72b9b-d0b0-4a35-8bc1-83f9a6488c48
m365 entra user revokesessions --id 4fb72b9b-d0b0-4a35-8bc1-83f9a6488c48

Revoke sign-in sessions of user by name
m365 entra user revokesessions --userName<EMAIL_ADDRESS>
Default properties
No response
Additional Info
https://learn.microsoft.com/en-us/graph/api/user-revokesigninsessions?view=graph-rest-1.0&tabs=http

Hi, @piniontech777, thanks for the suggestion! I suggest that we change a few things to the spec:

Let's name the command entra user session revoke
Let's add a -f, --force option so users have to confirm this destructive action.

Looks good to me! Do you want to work on it @piniontech777, or should we open it up?


Show  a placeholder when no images are returned

Currently, nothing is shown when the API does not return anything . Show some animated gif or an animated image saying that No images were found for that search term.
If the image or the gif would be related to space, it would be awesome.

hey @parthpanchal123  i would like to work on this issue . Plz assign it to me

@Shubh-2402 @error434 is already working on this issue , meanwhile you can explore the project and point out any new issues  if you find them :)

this can now be closed right?


Separate integration for L7

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@mattgrande @bezhermoso

✅


Add the bind argument to the docker quickstart section

The Docker image forgot to change the bind address to <IP_ADDRESS> at release 2.6.0,
and users will be frustrated if they cannot connect to the server after starting the server.
So it'd be better to fix the quickstart guide document.
refer: #1905 #1851

Maybe we can also add this workaround in the website.

Good point, will do it soon.


cr/bugs

Environment (please complete the following information):

OS (e.g., Windows 10):
Extension version (e.g., 1.2.3):

Describe the bug:

Repro steps:

Expected behavior:

Additional context:

Closing as incomplete.


chore: import repository https://github.com/hazem-internship/spring1.git

this commit will trigger a pipeline to generate the CI/CD configuration which will create a second commit on this Pull Request before it auto merges

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Update DG with more user stories, use cases, NFRs

Codecov Report
Patch and project coverage have no change.

Comparison is base (abf33bc) 72.15% compared to head (8486110) 72.15%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #43   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add hook for support Twig > 2.7

The class Twig_Extension has been deprecated with message: since Twig 2.7, use Twig\Extension\AbstractExtension instead
Filename: src/Twig/Extension/PaginationExtension.php
LineNumber: 15
Link: https://scrutinizer-ci.com/g/gpslab/pagination-bundle/issues/master/files/src/Twig/Extension/PaginationExtension.php?orderField=path&order=asc&honorSelectedPaths=0&issueId=39952960
The class Twig_SimpleFunction has been deprecated with message: since Twig 2.7, use Twig\TwigFunction instead
Filename: src/Twig/Extension/PaginationExtension.php
LineNumber: 36
Link: https://scrutinizer-ci.com/g/gpslab/pagination-bundle/issues/master/files/src/Twig/Extension/PaginationExtension.php?orderField=path&order=asc&honorSelectedPaths=0&issueId=39952959

Coverage decreased (-0.007%) to 99.876% when pulling 7d195850758316f0e739ccdabaa6fdcecd916fa9 on peter-gribanov:twig_2.7 into 32137b4dced94acef93a3a0eaa8cf1386fe1799e on gpslab:master.

Coverage decreased (-0.007%) to 99.876% when pulling 7d195850758316f0e739ccdabaa6fdcecd916fa9 on peter-gribanov:twig_2.7 into 32137b4dced94acef93a3a0eaa8cf1386fe1799e on gpslab:master.

Coverage decreased (-0.007%) to 99.876% when pulling 7d195850758316f0e739ccdabaa6fdcecd916fa9 on peter-gribanov:twig_2.7 into 32137b4dced94acef93a3a0eaa8cf1386fe1799e on gpslab:master.

Coverage decreased (-0.007%) to 99.876% when pulling 7d195850758316f0e739ccdabaa6fdcecd916fa9 on peter-gribanov:twig_2.7 into 32137b4dced94acef93a3a0eaa8cf1386fe1799e on gpslab:master.

Coverage decreased (-0.007%) to 99.876% when pulling 7d195850758316f0e739ccdabaa6fdcecd916fa9 on peter-gribanov:twig_2.7 into 32137b4dced94acef93a3a0eaa8cf1386fe1799e on gpslab:master.


Feature/adding support classes

Just merging the branch with untouched files back to main, ahead of working on the files.

Even though the repo doesn't have any production code yet, it's bad practice to merge an intermediate stage of development to the main branch. It's best to keep working on it until it's in a good shape / production ready.

Fair enough. Technically this code is already in production in another repo but I take your point, I'll close this PR.


Unable to install sqlite3

Issue Summary
I am using the Win11 operating system and I want to integrate SQLITE3 into Electron, but it cannot be compiled and installed in node 18.18.2. Strangely, he will search for it link
However, this address does not exist
Relevant logs or output
• electron-builder  version=24.9.1
• loaded configuration  file=H:\Code\WebstormProjects\electron-app\electron-builder.yml
• rebuilding native dependencies<EMAIL_ADDRESS>platform=win32 arch=x64
• install prebuilt binary  name=sqlite3 version=5.1.7 platform=win32 arch=x64 napi=
• build native dependency from sources  name=sqlite3
version=5.1.7
platform=win32
arch=x64
napi=
reason=prebuild-install failed with error (run with env DEBUG=electron-builder to get more information)
error=prebuild-install info begin Prebuild-install version 7.1.1
prebuild-install warn This package does not support N-API version 36
prebuild-install warn install prebuilt binaries enforced with --force!
prebuild-install warn install prebuilt binaries may be out of date!
prebuild-install info looking for local prebuild @ prebuilds\sqlite3-v5.1.7-napi-v36-win32-x64.tar.gz
prebuild-install info looking for cached prebuild @ C:\Users\Letudou\AppData\Roaming\npm-cache_prebuilds\9aa761-sqlite3-v5.1.7-napi-v36-win32-x64.tar.gz
prebuild-install http request GET https://github.com/TryGhost/node-sqlite3/releases/download/v5.1.7/sqlite3-v5.1.7-napi-v36-win32-x64.tar.gz
prebuild-install http 404 https://github.com/TryGhost/node-sqlite3/releases/download/v5.1.7/sqlite3-v5.1.7-napi-v36-win32-x64.tar.gz
prebuild-install warn install No prebuilt binaries found (target=36 runtime=napi arch=x64 libc= platform=win32)
• rebuilding native dependency  name=sqlite3 version=5.1.7
⨯ cannot execute  cause=exit status 1
$ prebuild-install -r napi || node-gyp rebuild
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
                errorOut=prebuild-install warn This package does not support N-API version 28.1.1
prebuild-install warn install No prebuilt binaries found (target=28.1.1 runtime=napi arch=x64 libc= platform=win32)
gyp info it worked if it ends with ok
gyp info using<EMAIL_ADDRESS>gyp info using<EMAIL_ADDRESS>| win32 | x64
gyp info find Python using Python version 3.10.9 found at "D:\Python\Python310\python.exe"
gyp info find VS using VS2022 (17.8.34330.188) found at:
gyp info find VS "C:\Program Files\Microsoft Visual Studio\2022\Professional"
gyp info find VS run with --verbose for detailed information
gyp info spawn D:\Python\Python310\python.exe
gyp info spawn args [
gyp info spawn args   'H:\\Code\\WebstormProjects\\electron-app\\node_modules\\node-gyp\\gyp\\gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'msvs',
gyp info spawn args   '-I',
gyp info spawn args   'H:\\Code\\WebstormProjects\\electron-app\\node_modules\\sqlite3\\build\\config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   'H:\\Code\\WebstormProjects\\electron-app\\node_modules\\node-gyp\\addon.gypi',
gyp info spawn args   '-I',
gyp info spawn args   'C:\\Users\\Letudou\\.electron-gyp\\28.1.1\\include\\node\\common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=C:\\Users\\Letudou\\.electron-gyp\\28.1.1',
gyp info spawn args   '-Dnode_gyp_dir=H:\\Code\\WebstormProjects\\electron-app\\node_modules\\node-gyp',
gyp info spawn args   '-Dnode_lib_file=C:\\\\Users\\\\Letudou\\\\.electron-gyp\\\\28.1.1\\\\<(target_arch)\\\\node.lib',
gyp info spawn args   '-Dmodule_root_dir=H:\\Code\\WebstormProjects\\electron-app\\node_modules\\sqlite3',
gyp info spawn args   '-Dnode_engine=v8',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'H:\\Code\\WebstormProjects\\electron-app\\node_modules\\sqlite3\\build',
gyp info spawn args   '-Goutput_dir=.'
gyp info spawn args ]
gyp: Active code page: 65001
..\node-addon-api\node_api.gyp not found (cwd: H:\Code\WebstormProjects\electron-app\node_modules\sqlite3) while loading dependencies of binding.gyp while trying to load binding.gyp
gyp ERR! configure error
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (H:\Code\WebstormProjects\electron-app\node_modules\node-gyp\lib\configure.js:259:16)
gyp ERR! stack     at ChildProcess.emit (node:events:517:28)
gyp ERR! stack     at ChildProcess._handle.onexit (node:internal/child_process:292:12)
gyp ERR! System Windows_NT 10.0.22631
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "H:\\Code\\WebstormProjects\\electron-app\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
gyp ERR! cwd H:\Code\WebstormProjects\electron-app\node_modules\sqlite3
gyp ERR! node -v v18.18.2
gyp ERR! node-gyp -v v8.4.1
gyp ERR! not ok

error Command failed with exit code 1.
                command='C:\Program Files\nodejs\node.exe' 'D:\node\nvm\v18.18.2\node_modules\yarn\bin\yarn.js' run install
                workingDir=H:\Code\WebstormProjects\electron-app\node_modules\sqlite3

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Version
5.1.7
Node.js Version
18.18.2
How did you install the library?
yarn add sqlite3

But I'm going to modify the ` node_ In modules/sqlite3/package. json ',' binary ': {' napi_versions': [3,6]} 'is' binary': {'napi_versions': [6]}', which can be processed

I also encountered the same problem. Do you know how to solve it? thanks

I also encountered the same problem. Do you know how to solve it? thanks

#1746   I feel that the problem is the same as the problem I raised, and this solution proposed by this friend or manually downloaded to the local can be temporarily solved @laozl

I also encountered the same problem. Do you know how to solve it? thanks

#1746 I feel that the problem is the same as the problem I raised, and this solution proposed by this friend or manually downloaded to the local can be temporarily solved @laozl

"I've conducted tests and discovered that the issue began with version 5.1.7 of sqlite3. To temporarily resolve this, you can specify version 5.1.6 in your package.json file. Simply add or modify the sqlite3 dependency in the following manner:
"dependencies": {
    "sqlite3": "5.1.6"
}

This should bypass the issue until a permanent fix is implemented.

I also encountered the same problem. Do you know how to solve it? thanks

#1746 I feel that the problem is the same as the problem I raised, and this solution proposed by this friend or manually downloaded to the local can be temporarily solved @laozl

I've conducted tests and discovered that the issue began with version 5.1.7 of sqlite3. To temporarily resolve this, you can specify version 5.1.6 in your package.json file. Simply add or modify the sqlite3 dependency in the following manner:
"dependencies": {
    "sqlite3": "5.1.6"
}

This should bypass the issue until a permanent fix is implemented.

Thank you very much. Your plan has solved the troubles that have troubled me for a few days at once

I'm having the same issue with v5.1.7:
prebuild-install info looking for local prebuild @ prebuilds\sqlite3-v5.1.7-napi-v36-win32-x64.tar.gz
which should be looking for sqlite3-v5.1.7-napi-v6-win32-x64.tar.gz
Will pin to version v5.1.6 for now, but would love to make use of the improved bundling!

+1

+1 with sqlite3 5.1.7

it doesn't work for me since
"sqlite3": "5.1.6",
"electron": "^28.2.1",
"electron-builder": "^24.13.3",

"sqlite3": "5.1.6"

It worked for me, thank you very much.
Funciono para mi, Muchas gracias

This worked:
export LDFLAGS="-L`brew --prefix`/opt/sqlcipher/lib"
export CPPFLAGS="-I`brew --prefix`/opt/sqlcipher/include/sqlcipher"
npm install<EMAIL_ADDRESS>--build-from-source --sqlite_libname=sqlcipher --sqlite=`brew --prefix` --runtime=electron --target=27.3.9 --dist-url=https://electronjs.org/headers

node -e 'require("sqlite3")'

Thanks @xieerduos

Is this issue resolved? I'm on
electron: "^7.0.0"
electron-builder: "^22.11.7"
After I downgraded sqlite3 to 5.1.6, when I build the app, it got stuck at packaging stage

electron: "^7.0.0"
@Sailwayfun why are you using such an old version of electron? It's currently on version 33.

electron: "^7.0.0"

@Sailwayfun why are you using such an old version of electron? It's currently on version 33.

I'm on several legacy desktop electron projects, and our team has no intention of QAing an up-to-date version. Anyways I finally downgraded sqlite3 to 5.0.0 and it worked fine.


fix: Useing 'type' instad of 'which', which is more robust

For reference, see: https://stackoverflow.com/questions/592620/check-if-a-program-exists-from-a-bash-script.

The reason for this, is that when aliasing curl, to have a different default behavior (or use noglob curl), then which will report an error, thinking that curl does not exist.
Using type fixes this.

Fixed in master using $commands[curl] instead (idiomatic zsh).


[#1937] Multiple membership extensions

This fixes #1937.
The existing field extended was migrated into extensions which
is a list (array) of single extensions.
For example, [30, 60] means that membership was extended by
30 and then by 60 days, for a total of 90 days extension.
The total (cumulative) value is also displayed in the membership details
page.

One feature missing: extension log (see #1937 for details).


nfdump: <IP_ADDRESS> -> 1.7.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/phaag/nfdump/releases.
meta.description for nfdump is: "Tools for working with netflow data"
meta.homepage for nfdump is: "https://github.com/phaag/nfdump"
meta.changelog for nfdump is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.7.1 with grep in /nix/store/3iygbqw9ndv825d078gwc5cs6hd3jfqr-nfdump-1.7.1
found 1.7.1 in filename of file in /nix/store/3iygbqw9ndv825d078gwc5cs6hd3jfqr-nfdump-1.7.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
nfdump

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/3iygbqw9ndv825d078gwc5cs6hd3jfqr-nfdump-1.7.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A nfdump https://github.com/r-ryantm/nixpkgs/archive/c30e3bc5d00fbb59e8b37a5694c90c56c4529060.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/3iygbqw9ndv825d078gwc5cs6hd3jfqr-nfdump-1.7.1
ls -la /nix/store/3iygbqw9ndv825d078gwc5cs6hd3jfqr-nfdump-1.7.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

nfdump

Maintainer pings
cc @takikawa for testing.

Result of nixpkgs-review pr 208449 run on x86_64-linux 1

1 package marked as broken and skipped:

nfdump

Result of nixpkgs-review pr 208449 run on x86_64-linux 1

1 package built:

nfdump


Fix JSXStyle renders styles too late

We tried master on zeit.co and it seems that when we have the side effects in componentDidMount styles are rendered after the content causing transitions to apply to properties that wouldn't otherwise be animated e.g. padding similarly to this https://jsfiddle.net/uwbm165z/ (unfortunately I wasn't able to reproduce with React yet but here is my attempt https://codesandbox.io/s/p7q6n6r35m).
In this patch we move the side effect styleSheetRegistry.add to render making sure that shouldComponentUpdate doesn't trigger unnecessary re-renderings. On update we then remove the old styles early enough aka on getSnapshotBeforeUpdate.
@bvaughn this is a "followup" of the conversation we had in https://github.com/zeit/styled-jsx/pull/457#issuecomment-400329970 Does it make sense?

Hm. This looks unsafe for the reasons mentioned here.

My guess is that because this component is a child of the elements it styles, the styles are rendered slightly late (ha ha).
Anyhow if sCU is solid this should render (as for render is called only once during the render phase) only once right?

getSnapshotBeforeUpdate is meant to be read-only, but...I wonder if you considered trying it for the stylesheet modification? At least it would only be called during (right before) commit.

I could do that too, would it be safe to keep a class properly to track the mounted state? I need to call styleSheetRegistry.remove only on updates (not on mounting). Also for ssr i’d need the constructor hack I guess

My guess is that because this component is a child of the elements it styles, the styles are rendered slightly late (ha ha).

Still doesn't seem right to me. Changes to the DOM are committed synchronously, so there should only be one layout+paint. 😕

Anyhow if sCU is solid this should render (as for render is called only once during the render phase) only once right?

No. Render can be called multiple times– if there's an error, or if your app is using the new async rendering mode.

I could do that too, would it be safe to keep a class properly to track the mounted state? I need to call styleSheetRegistry.remove only on updates (not on mounting).

Yes, assuming you only set that property in componentDidMount– that sounds safe.

Also for ssr i’d need the constructor hack I guess

For now ☹ unless/until we land this new lifecycle.

Still doesn't seem right to me. Changes to the DOM are committed synchronously, so there should only be one layout+paint.

Yeah I will try harder and see if I can manage to make a test case.

No. Render can be called multiple times– if there's an error, or if your app is using the new async rendering mode.
Yes, assuming you only set that property in componentDidMount– that sounds safe.

So it seems that for our case the safest thing to do is to have all the side effects in getSnapshotBeforeUpdate 👌

@bvaughn what I don't understand is this part:

DOM are committed synchronously, so there should only be one layout+paint

Is everything committed after componentDidMount? If so how is it possible that I can get a ref to the DOM in didMount? To me it seems that the DOM is already there and we apply the styles with our side effect.

No. The DOM is mutated before componentDidMount is called– but componentDidMount is called synchronously (right afterward). The browser doesn't do layout/paint until React's work is done.

interesting, it is not quite clear to me how layout and paint happen after componentDidMount yet? Does it have to do with the fact that you make everything fit inside of a frame? Also if I have access to the dom reference in componentDidMount and I can read from the dom eg. computed value I'd expect layout to be done at least 🤔

i mean aren't mutation synchronous as well (i.e. might trigger a layout/paint)?

Also if I have access to the dom reference in componentDidMount and I can read from the dom eg. computed values I'd expect layout to be done at least 🤔

Reading certain properties will force the browser to do sync layout before returning.

Reading certain properties will force the browser to do sync layout before returning a value

@bvaughn does this mean that if if I access certain properties the browser could do layout before mine applies styles?
If so could you show me how to reproduce that behavior? https://codesandbox.io/s/l725xqoknl

Here's a list @paulirish created some time ago of which property reads trigger the browser to synchronously calculate the style and layout
https://gist.github.com/paulirish/5d52fb081b3570c81e3a

I access certain properties the browser could do layout before mine applies styles?

If React has mutated the DOM in such a way as to have invalidated layout or styles, and you force layout/reflow by reading one of these properties, then yeah– the browser would synchronously recalculate things.

@bvaughn I figured out a way to replicate https://twitter.com/giuseppegurgone/status/1041319367886221312

@bvaughn for this specific use case would it be ok to keep the side effect in render like this:
render() {
  const stringifiedProps = this.props.styleId + String(this.props.dynamic)
  if (this.stringifiedProps !== stringifiedProps) {
    this.stringifiedProps = stringifiedProps
    styleSheetRegistry.add(this.props)
  }
  return null
}

the comparison is a guard to make sure that styleSheetRegistry.add is only called once when the props don't change

All side effects are potentially dangerous.
In the case of updates, my best guess for when styles could safely be added is still getSnapshotBeforeUpdate– because it's part of the commit phase and it runs before the DOM is mutated or componentDidMount/componentDidUpdate get called.
Unfortunately it wouldn't work for the initial render nor for the server-side rendering case. I don't really have a good solution for those to be honest.

I suggest you all might create an RFC for this.
This one I created a while ago could help with your server side rendering case but it wouldn't help with the client-side mount case:
https://github.com/reactjs/rfcs/pull/8

@bvaughn thank you, that's precious information!

I have some good news for you! We are working on something (no RFC yet– but hopefully soon) that should solve the mount+update mutation timing issue we've been discussing here. I hope to share more soon!

aw nice, can't wait to see what you came up with! (happy to help if necessary)

I was looking at this code trying to figure out some concurrent mode compatibility issues. This fix is not concurrent mode safe (for example, it could remove things before the new changes have committed).
I was able to repro in React by simply adding a previous sibling like this (the codesandbox is broken for me right now so I can't fork it):
<div ref={n => { if (n) n.clientWidth; }} />

This forces a layout. This seems to trick Chrome into treating this as already mounted. Any subsequent mutations then cause a CSS transition to happen. What happens in this case is this: 1) React adds the DOM nodes to the document. 2) Something reads layout in a different life-cycle/effect. 3) React fires JSXStyle's life-cycle which then inserts the style sheet into the document. This causes Chrome to think this is an update to an already visible component and triggers a transition.
Now even if this was fixed in browsers, this sequencing would still leave the second step to potentially read the wrong layout.
We originally planned to add something like useMutationEffect which is what I think @bvaughn was referring to. Since then we decided not to do this. However, the alternative https://github.com/reactjs/rfcs/pull/96 would not actually be sufficient for this case.
So this is missing a good solution atm.

@sebmarkbage this is an intermediate patch, the final version where I tried to make it concurrent mode safe is here https://github.com/zeit/styled-jsx/blob/343795d3b2fef6d3d085921b0d4cf31b4d9be709/src/style.js but back then my understanding of all this was very poor and I haven't looked into it ever since.

Leaving a link to a reproduction for future reference https://codesandbox.io/s/react-17-repaint-demo-forked-c716t?file=/src/App.js


Move the menu bar entry definitions to the backend

It is currently defined in JS. This should hopefully mean that checkboxes should become functional.

@mfish33 you might be interested in taking this on in the future.