Unable to disable aft_feature_cloudtrail_data_events

Terraform Version & Prov:
AFT Version: 1.7.0
Terraform Version & Provider Versions
terraform version: v1.3.6

Click to expand for full version details
Terraform v1.3.6
on darwin_amd64
+ provider registry.terraform.io/hashicorp/archive v2.2.0
+ provider registry.terraform.io/hashicorp/aws v4.48.0
+ provider registry.terraform.io/hashicorp/local v2.3.0
+ provider registry.terraform.io/hashicorp/random v3.4.3
+ provider registry.terraform.io/hashicorp/time v0.9.1

terraform providers
hashicorp/time v0.9.1
hashicorp/aws v4.48.0
hashicorp/local v2.3.0
hashicorp/random v3.4.3
hashicorp/archive v2.2.0

Click to expand for full providers details
Providers required by configuration:
.
├── provider[registry.terraform.io/hashicorp/aws] 4.48.0
└── module.control_tower_account_factory
    ├── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0, < 5.0.0
    ├── provider[registry.terraform.io/hashicorp/local]
    ├── module.aft_feature_options
    │   └── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    ├── module.aft_iam_roles
    │   ├── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    │   ├── module.ct_management_service_role
    │       └── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    │   ├── module.log_archive_exec_role
    │       └── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    │   ├── module.log_archive_service_role
    │       └── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    │   ├── module.aft_exec_role
    │       └── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    │   ├── module.aft_service_role
    │       └── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    │   ├── module.audit_exec_role
    │       └── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    │   ├── module.audit_service_role
    │       └── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    │   └── module.ct_management_exec_role
    │       └── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    ├── module.aft_code_repositories
    │   ├── provider[registry.terraform.io/hashicorp/local]
    │   └── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    ├── module.aft_lambda_layer
    │   ├── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    │   ├── provider[registry.terraform.io/hashicorp/random]
    │   └── provider[registry.terraform.io/hashicorp/local]
    ├── module.aft_customizations
    │   ├── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    │   └── provider[registry.terraform.io/hashicorp/local]
    ├── module.aft_backend
    │   └── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    ├── module.aft_account_request_framework
    │   ├── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    │   └── provider[registry.terraform.io/hashicorp/time]
    ├── module.aft_ssm_parameters
    │   ├── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    │   └── provider[registry.terraform.io/hashicorp/random]
    ├── module.packaging
    │   └── provider[registry.terraform.io/hashicorp/archive]
    └── module.aft_account_provisioning_framework
        └── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0

Providers required by state:

    provider[registry.terraform.io/hashicorp/time]

    provider[registry.terraform.io/hashicorp/random]

    provider[registry.terraform.io/hashicorp/aws]

    provider[registry.terraform.io/hashicorp/archive]

    provider[registry.terraform.io/hashicorp/local]

Bug Description
Switching the value of aft_feature_cloudtrail_data_events from true to false does not appear to do anything.
To Reproduce
Steps to reproduce the behavior:

Deploy AFT to a new account with aft_feature_cloudtrail_data_events = true
Modify value from true to false
Run terraform plan

Expected behavior
Either TF should attempt to delete the cloudtrail trail, buckets, etc OR at least not try to re-create them if manually removed.
Additional context
I initially enabled aft_feature_cloudtrail_data_events on first deployment of AFT. I then realized this was duplicating the cloudtrail logs already collected by the organization trail enabled through Control Tower.
I swapped the feature flag to false and ran a terraform apply, but noting happened. I ended up manually deleting all the resources, as I had a loop between data events in the TF-created logs/buckets and my CT org trail.
Now a plan wants to re-create the resources which I manually deleted, even though the feature flag is set to false.
Related Logs

Output of `terraform plan`
...
module.control_tower_account_factory.module.aft_customizations.aws_sfn_state_machine.aft_invoke_customizations_sfn: Refreshing state... [id=arn:aws:states:us-east-1:12345EXAMPLE:stateMachine:aft-invoke-customizations]

Note: Objects have changed outside of Terraform

Terraform detected the following changes made outside of Terraform since the last "terraform
apply" which may have affected this plan:

# module.control_tower_account_factory.module.aft_feature_options.aws_s3_bucket.aft_access_logs has been deleted
- resource "aws_s3_bucket" "aft_access_logs" {
    - arn                         = "arn:aws:s3:::aws-aft-s3-access-logs-12345EXAMPLE-us-east-1" -> null
    - id                          = "aws-aft-s3-access-logs-12345EXAMPLE-us-east-1" -> null
    - region                      = "us-east-1" -> null
      tags                        = {}
      # (8 unchanged attributes hidden)

      # (5 unchanged blocks hidden)
  }

# module.control_tower_account_factory.module.aft_feature_options.aws_s3_bucket.aft_logging_bucket has been deleted
- resource "aws_s3_bucket" "aft_logging_bucket" {
    - arn                         = "arn:aws:s3:::aws-aft-logs-12345EXAMPLE-us-east-1" -> null
    - id                          = "aws-aft-logs-12345EXAMPLE-us-east-1" -> null
    - region                      = "us-east-1" -> null
      tags                        = {}
      # (9 unchanged attributes hidden)

      # (4 unchanged blocks hidden)
  }

Unless you have made equivalent changes to your configuration, or ignored the relevant
attributes using ignore_changes, the following plan may include actions to undo or respond
to these changes.

────────────────────────────────────────────────────────────────────────────────────────────

Terraform used the selected providers to generate the following execution plan. Resource
actions are indicated with the following symbols:
+ create
~ update in-place

Terraform will perform the following actions:

# module.control_tower_account_factory.module.aft_feature_options.aws_s3_bucket.aft_access_logs will be created
+ resource "aws_s3_bucket" "aft_access_logs" {
    + acceleration_status         = (known after apply)
    + acl                         = (known after apply)
    + arn                         = (known after apply)
    + bucket                      = "aws-aft-s3-access-logs-12345EXAMPLE-us-east-1"
    + bucket_domain_name          = (known after apply)
    + bucket_regional_domain_name = (known after apply)
    + force_destroy               = false
    + hosted_zone_id              = (known after apply)
    + id                          = (known after apply)
    + object_lock_enabled         = (known after apply)
    + policy                      = (known after apply)
    + region                      = (known after apply)
    + request_payer               = (known after apply)
    + tags_all                    = {
        + "managed_by" = "AFT"
      }
    + website_domain              = (known after apply)
    + website_endpoint            = (known after apply)

    + cors_rule {
        + allowed_headers = (known after apply)
        + allowed_methods = (known after apply)
        + allowed_origins = (known after apply)
        + expose_headers  = (known after apply)
        + max_age_seconds = (known after apply)
      }

    + grant {
        + id          = (known after apply)
        + permissions = (known after apply)
        + type        = (known after apply)
        + uri         = (known after apply)
      }

    + lifecycle_rule {
        + abort_incomplete_multipart_upload_days = (known after apply)
        + enabled                                = (known after apply)
        + id                                     = (known after apply)
        + prefix                                 = (known after apply)
        + tags                                   = (known after apply)

        + expiration {
            + date                         = (known after apply)
            + days                         = (known after apply)
            + expired_object_delete_marker = (known after apply)
          }

        + noncurrent_version_expiration {
            + days = (known after apply)
          }

        + noncurrent_version_transition {
            + days          = (known after apply)
            + storage_class = (known after apply)
          }

        + transition {
            + date          = (known after apply)
            + days          = (known after apply)
            + storage_class = (known after apply)
          }
      }

    + logging {
        + target_bucket = (known after apply)
        + target_prefix = (known after apply)
      }

    + object_lock_configuration {
        + object_lock_enabled = (known after apply)

        + rule {
            + default_retention {
                + days  = (known after apply)
                + mode  = (known after apply)
                + years = (known after apply)
              }
          }
      }

    + replication_configuration {
        + role = (known after apply)

        + rules {
            + delete_marker_replication_status = (known after apply)
            + id                               = (known after apply)
            + prefix                           = (known after apply)
            + priority                         = (known after apply)
            + status                           = (known after apply)

            + destination {
                + account_id         = (known after apply)
                + bucket             = (known after apply)
                + replica_kms_key_id = (known after apply)
                + storage_class      = (known after apply)

                + access_control_translation {
                    + owner = (known after apply)
                  }

                + metrics {
                    + minutes = (known after apply)
                    + status  = (known after apply)
                  }

                + replication_time {
                    + minutes = (known after apply)
                    + status  = (known after apply)
                  }
              }

            + filter {
                + prefix = (known after apply)
                + tags   = (known after apply)
              }

            + source_selection_criteria {
                + sse_kms_encrypted_objects {
                    + enabled = (known after apply)
                  }
              }
          }
      }

    + server_side_encryption_configuration {
        + rule {
            + bucket_key_enabled = (known after apply)

            + apply_server_side_encryption_by_default {
                + kms_master_key_id = (known after apply)
                + sse_algorithm     = (known after apply)
              }
          }
      }

    + versioning {
        + enabled    = (known after apply)
        + mfa_delete = (known after apply)
      }

    + website {
        + error_document           = (known after apply)
        + index_document           = (known after apply)
        + redirect_all_requests_to = (known after apply)
        + routing_rules            = (known after apply)
      }
  }

# module.control_tower_account_factory.module.aft_feature_options.aws_s3_bucket.aft_logging_bucket will be created
+ resource "aws_s3_bucket" "aft_logging_bucket" {
    + acceleration_status         = (known after apply)
    + acl                         = (known after apply)
    + arn                         = (known after apply)
    + bucket                      = "aws-aft-logs-12345EXAMPLE-us-east-1"
    + bucket_domain_name          = (known after apply)
    + bucket_regional_domain_name = (known after apply)
    + force_destroy               = false
    + hosted_zone_id              = (known after apply)
    + id                          = (known after apply)
    + object_lock_enabled         = (known after apply)
    + policy                      = (known after apply)
    + region                      = (known after apply)
    + request_payer               = (known after apply)
    + tags_all                    = {
        + "managed_by" = "AFT"
      }
    + website_domain              = (known after apply)
    + website_endpoint            = (known after apply)

    + cors_rule {
        + allowed_headers = (known after apply)
        + allowed_methods = (known after apply)
        + allowed_origins = (known after apply)
        + expose_headers  = (known after apply)
        + max_age_seconds = (known after apply)
      }

    + grant {
        + id          = (known after apply)
        + permissions = (known after apply)
        + type        = (known after apply)
        + uri         = (known after apply)
      }

    + lifecycle_rule {
        + abort_incomplete_multipart_upload_days = (known after apply)
        + enabled                                = (known after apply)
        + id                                     = (known after apply)
        + prefix                                 = (known after apply)
        + tags                                   = (known after apply)

        + expiration {
            + date                         = (known after apply)
            + days                         = (known after apply)
            + expired_object_delete_marker = (known after apply)
          }

        + noncurrent_version_expiration {
            + days = (known after apply)
          }

        + noncurrent_version_transition {
            + days          = (known after apply)
            + storage_class = (known after apply)
          }

        + transition {
            + date          = (known after apply)
            + days          = (known after apply)
            + storage_class = (known after apply)
          }
      }

    + logging {
        + target_bucket = (known after apply)
        + target_prefix = (known after apply)
      }

    + object_lock_configuration {
        + object_lock_enabled = (known after apply)

        + rule {
            + default_retention {
                + days  = (known after apply)
                + mode  = (known after apply)
                + years = (known after apply)
              }
          }
      }

    + replication_configuration {
        + role = (known after apply)

        + rules {
            + delete_marker_replication_status = (known after apply)
            + id                               = (known after apply)
            + prefix                           = (known after apply)
            + priority                         = (known after apply)
            + status                           = (known after apply)

            + destination {
                + account_id         = (known after apply)
                + bucket             = (known after apply)
                + replica_kms_key_id = (known after apply)
                + storage_class      = (known after apply)

                + access_control_translation {
                    + owner = (known after apply)
                  }

                + metrics {
                    + minutes = (known after apply)
                    + status  = (known after apply)
                  }

                + replication_time {
                    + minutes = (known after apply)
                    + status  = (known after apply)
                  }
              }

            + filter {
                + prefix = (known after apply)
                + tags   = (known after apply)
              }

            + source_selection_criteria {
                + sse_kms_encrypted_objects {
                    + enabled = (known after apply)
                  }
              }
          }
      }

    + server_side_encryption_configuration {
        + rule {
            + bucket_key_enabled = (known after apply)

            + apply_server_side_encryption_by_default {
                + kms_master_key_id = (known after apply)
                + sse_algorithm     = (known after apply)
              }
          }
      }

    + versioning {
        + enabled    = (known after apply)
        + mfa_delete = (known after apply)
      }

    + website {
        + error_document           = (known after apply)
        + index_document           = (known after apply)
        + redirect_all_requests_to = (known after apply)
        + routing_rules            = (known after apply)
      }
  }

# module.control_tower_account_factory.module.aft_feature_options.aws_s3_bucket_acl.aft_access_logs_acl will be created
+ resource "aws_s3_bucket_acl" "aft_access_logs_acl" {
    + acl    = "log-delivery-write"
    + bucket = (known after apply)
    + id     = (known after apply)

    + access_control_policy {
        + grant {
            + permission = (known after apply)

            + grantee {
                + display_name  = (known after apply)
                + email_address = (known after apply)
                + id            = (known after apply)
                + type          = (known after apply)
                + uri           = (known after apply)
              }
          }

        + owner {
            + display_name = (known after apply)
            + id           = (known after apply)
          }
      }
  }

# module.control_tower_account_factory.module.aft_feature_options.aws_s3_bucket_lifecycle_configuration.aft_access_logs_lifecycle_configuration will be created
+ resource "aws_s3_bucket_lifecycle_configuration" "aft_access_logs_lifecycle_configuration" {
    + bucket = (known after apply)
    + id     = (known after apply)

    + rule {
        + id     = "aft_access_logs_lifecycle_configuration_rule"
        + status = "Enabled"

        + filter {
            + prefix = "log/"
          }

        + noncurrent_version_expiration {
            + noncurrent_days = 365
          }
      }
  }

# module.control_tower_account_factory.module.aft_feature_options.aws_s3_bucket_lifecycle_configuration.aft_logging_bucket_lifecycle_configuration will be created
+ resource "aws_s3_bucket_lifecycle_configuration" "aft_logging_bucket_lifecycle_configuration" {
    + bucket = (known after apply)
    + id     = (known after apply)

    + rule {
        + id     = "aft_logging_bucket_lifecycle_configuration_rule"
        + status = "Enabled"

        + noncurrent_version_expiration {
            + noncurrent_days = 365
          }
      }
  }

# module.control_tower_account_factory.module.aft_feature_options.aws_s3_bucket_logging.aft_logging_bucket_logging will be created
+ resource "aws_s3_bucket_logging" "aft_logging_bucket_logging" {
    + bucket        = (known after apply)
    + id            = (known after apply)
    + target_bucket = (known after apply)
    + target_prefix = "log/"
  }

# module.control_tower_account_factory.module.aft_feature_options.aws_s3_bucket_policy.aft_logging_bucket will be created
+ resource "aws_s3_bucket_policy" "aft_logging_bucket" {
    + bucket = (known after apply)
    + id     = (known after apply)
    + policy = (known after apply)
  }

# module.control_tower_account_factory.module.aft_feature_options.aws_s3_bucket_public_access_block.aft_access_logs will be created
+ resource "aws_s3_bucket_public_access_block" "aft_access_logs" {
    + block_public_acls       = true
    + block_public_policy     = true
    + bucket                  = (known after apply)
    + id                      = (known after apply)
    + ignore_public_acls      = true
    + restrict_public_buckets = true
  }

# module.control_tower_account_factory.module.aft_feature_options.aws_s3_bucket_public_access_block.aft_logging_bucket will be created
+ resource "aws_s3_bucket_public_access_block" "aft_logging_bucket" {
    + block_public_acls       = true
    + block_public_policy     = true
    + bucket                  = (known after apply)
    + id                      = (known after apply)
    + ignore_public_acls      = true
    + restrict_public_buckets = true
  }

# module.control_tower_account_factory.module.aft_feature_options.aws_s3_bucket_server_side_encryption_configuration.aft_access_logs_encryption will be created
+ resource "aws_s3_bucket_server_side_encryption_configuration" "aft_access_logs_encryption" {
    + bucket = (known after apply)
    + id     = (known after apply)

    + rule {
        + apply_server_side_encryption_by_default {
            + sse_algorithm = "AES256"
          }
      }
  }

# module.control_tower_account_factory.module.aft_feature_options.aws_s3_bucket_server_side_encryption_configuration.aft_logging_bucket_encryption will be created
+ resource "aws_s3_bucket_server_side_encryption_configuration" "aft_logging_bucket_encryption" {
    + bucket = (known after apply)
    + id     = (known after apply)

    + rule {
        + apply_server_side_encryption_by_default {
            + kms_master_key_id = "arn:aws:kms:us-east-1:12345EXAMPLE:key/00000000-0000-0000-0000-000000000000"
            + sse_algorithm     = "aws:kms"
          }
      }
  }

# module.control_tower_account_factory.module.aft_feature_options.aws_s3_bucket_versioning.aft_access_logs_versioning will be created
+ resource "aws_s3_bucket_versioning" "aft_access_logs_versioning" {
    + bucket = (known after apply)
    + id     = (known after apply)

    + versioning_configuration {
        + mfa_delete = (known after apply)
        + status     = "Enabled"
      }
  }

# module.control_tower_account_factory.module.aft_feature_options.aws_s3_bucket_versioning.aft_logging_bucket_versioning will be created
+ resource "aws_s3_bucket_versioning" "aft_logging_bucket_versioning" {
    + bucket = (known after apply)
    + id     = (known after apply)

    + versioning_configuration {
        + mfa_delete = (known after apply)
        + status     = "Enabled"
      }
  }

# module.control_tower_account_factory.module.aft_ssm_parameters.aws_ssm_parameter.aft_logging_bucket_arn will be updated in-place
~ resource "aws_ssm_parameter" "aft_logging_bucket_arn" {
      id             = "/aft/account/log-archive/log_bucket_arn"
    + insecure_value = (known after apply)
      name           = "/aft/account/log-archive/log_bucket_arn"
      tags           = {}
    ~ value          = (sensitive value)
    ~ version        = 1 -> (known after apply)
      # (5 unchanged attributes hidden)
  }

Plan: 13 to add, 1 to change, 0 to destroy.

────────────────────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't guarantee to take
exactly these actions if you run "terraform apply" now.

Thank you in advance!

On further investigation, I discovered the buckets are re-created but the actual cloudtrail trail is not. I assume this is expected behavior?
It would be nice to be able to remove the buckets, as mine are currently empty. BUT I can see this as being complicated though, particularly to avoid deleting logs on someone who has been using the integration but is now disabling it.
Does anyone have an idea on how to enable this? Perhaps check if the bucket is empty?


UG-617 Set lint test to use the right Ansible version

The version being used for lint testing does not
match the version being deployed. This fixes
that.

recheck_trusty_deploy_swift
recheck_trusty_majorupgrade_ceph

recheck_trusty_deploy_swift

recheck_trusty_deploy_swift
recheck_trusty_majorupgrade_ceph

recheck_cit_trusty_deploy_swift
recheck_cit_trusty_majorupgrade_ceph

recheck_cit_trusty_majorupgrade_swift

recheck_cit_trusty_majorupgrade_swift

recheck_cit_trusty_majorupgrade_swift


Testing integration tests in CI

Signed-off-by: Mohammad Qureshi<EMAIL_ADDRESS>Description
Use the build target that runs integration tests.
This PR is a duplicate of #12 but will be used for testing since the integ failures are happening on the GitHub Action workflow but not locally.
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I'll close this since it is a dup of #12. Integ tests do fail locally if you build against the alpha1 tag of OpenSearch. Once we have an alpha2 tagged I'll update that PR and we'll get to a green state.

I'll close this since it is a dup of #12. Integ tests do fail locally if you build against the alpha1 tag of OpenSearch. Once we have an alpha2 tagged I'll update that PR and we'll get to a green state.

I wasn't seeing consistent test results locally vs. on GitHub Actions even when using alpha1 tag for OpenSearch in both cases. It would usually pass locally but fail using GitHub Actions a lot.  I'm fine with checking again with alpha2 but it does feel like there could possibly be a bleed between tests that's more likely to occur when running with CI.
If we still see consistent failures with the CI workflow, we can try adding sleeps in the beginning of the tests to see if late cleanup operations are possibly interfering with the next test that runs. That's what I was planning to check with this duplicate PR but we can perform the same work in #12

I added @Ignore on the tests and opened https://github.com/opensearch-project/job-scheduler/issues/15.


Sync branchs

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Adding fixpointinteration for valid definitions to declarations that …

…improves the Control-Flow sensitivity
This pass iterates over all intraprocedural paths of functions to collect valid definitions of a variable at join-points (nodes with more than one incoming EOG-Edge). In a second iteration over all EOG-Paths the state (map of VariableDeclarations to multiple definitions for a variable) is propagated to use-points(DeclaredReferenceExpression of a VariableDeclaration) and compute edges that have to be removed from the control-flow insensitive DF-Graph to realize a DF-sensitive-Graph.

Could you maybe get rid of some of the easier code smells, i.e. using isEmpty?
Any specific reason in renaming the pass? We should keep it API-compliant I think.
Then I think its good to merge.

Could you maybe get rid of some of the easier code smells, i.e. using isEmpty?
Any specific reason in renaming the pass? We should keep it API-compliant I think.
Then I think its good to merge.

Yes, but this PR was also not assigned to a reviewer as I was not finished with all the changes that I had in mind, thanks for the feedback though :)

Could you maybe get rid of some of the easier code smells, i.e. using isEmpty?
Any specific reason in renaming the pass? We should keep it API-compliant I think.
Then I think its good to merge.

The reason for the renaming was also temporary as I wanted to merge functionality of 2 files because the separation was not  necessary anymore and I tried to use git-mv to keep the code history intact. Apparently I failed, or changed to much of a file and now I am the sole author of the file

Could you maybe get rid of some of the easier code smells, i.e. using isEmpty?
Any specific reason in renaming the pass? We should keep it API-compliant I think.
Then I think its good to merge.

Yes, but this PR was also not assigned to a reviewer as I was not finished with all the changes that I had in mind, thanks for the feedback though :)

Understood, in this case, we should mark the PR as "Draft"


white__space feature request

I use this extension extensively, sometimes i need to make bulk amount of sentences from names of my functions / variables, so i have made this feature request, not to do it manually.

Thank you @valerian720


Hello, where are these guys coming from WTF

1f0 is a gobsmacker.

and 1f3 the same, this time for fans:

Both in master (04068ad) and dynamic_min_samples (83677a2) these plot fine now without those fans from no-where. Closing.


Class DiskLruHttpCacheStore not recognized

Tried to use DiskLruHttpCacheStore but get a unresolved reference error.
When I look at the Apollo package I do not see the folder 'http' which should contain the DiskLruHttpCacheStore class

Tested with Apollo 0.4.3 and 0.4.4-SNAPSHOT with same result

Had to add to my grade build complied. Http caching is in a different (& optional) artifact separate from the main apollo package.
Added:
compile "com.apollographql.apollo:apollo-http-cache:$apollo_version"


ARROW-10420: [C++] Refactor io and filesystem APIs to take an IOContext

The io::IOContext class allows passing various settings such as the MemoryPool used for allocation and the Executor for async methods.

A couple things to discuss:

API choices: should we take a const IOContext&, a const IOContext*, a IOContext*?
I've added an owned IOContext to the base FileSystem class. Should we do that on RandomAccessFile or InputStream as well?

@westonpace  @bkietz  input welcome.

I've added an owned IOContext to the base FileSystem class. Should we do that on RandomAccessFile or InputStream as well?

My gut says no but I could be convinced otherwise.  For example, the S3 filesystem (if I understand correctly) would plug the executor into the AWS client configuration and the random access files / etc. would rely on that and not the Executor directly.   At best it would just be for convenience right?  A way to provide implementors easy access to the context instead of having to take care of passing it around?

Drive by naming nit: IoContext

@westonpace I think I misphrased my question. This PR adds an owned IOContext to filesystem instances. My question was whether stream objects should also have an owned IOContext; currently they only keep a const-ref, meaning it has to be kept alive elsewhere.
@emkornfield Hmm, I'm not sure what the convention should be. We currently have Status::IOError, though.

@emkornfield Hmm, I'm not sure what the convention should be. We currently have Status::IOError, though.

According to the style guide IoContext:

For the purposes of the naming rules below, a "word" is anything that you would write in English without internal spaces. This includes abbreviations, such as acronyms and initialisms. For names written in mixed case (also sometimes referred to as "camel case" or "Pascal case"), in which the first letter of each word is capitalized, prefer to capitalize abbreviations as single words, e.g., StartRpc() rather than StartRPC().

However, if we want to keep consistency I'm OK with IO.

Since IOContext only wraps pointers and an id integer, semantically it represents a reference. Therefore I'd recommend never producing references to them; it's redundant and the structure is tiny and trivially copyable anyway.

@ursabot please benchmark

@bkietz Do you want to give this another look?

CI failure is ARROW-11717. Merging


Remove duplicated infos

Remove duplicated infos, only show deployment result in class DeployMojo, for #862

Codecov Report

Merging #866 into develop will increase coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop     #866      +/-   ##
=============================================
+ Coverage      44.55%   44.56%   +<.01%
  Complexity       765      765
=============================================
  Files            134      134
  Lines           5169     5168       -1
  Branches         741      741
=============================================
  Hits            2303     2303
+ Misses          2692     2691       -1
  Partials         174      174

Impacted Files
Coverage Δ
Complexity Δ

...e/maven/webapp/handlers/DeploymentSlotHandler.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 383d185...d118f62. Read the comment docs.


sitemap.xml question

@caarlos0 How did you instruct jekyll-sitemap to use the CNAME domain (carlosbecker.com)?
I am using jekyll-sitemap too, but the sitemap.xml is generated with amihaiemil.github.io links instead of amihaiemil.com: http://www.amihaiemil.com/sitemap.xml

as far as I remember I just created the CNAME file in the root of the site...

yeah, I have that too

have you tried<EMAIL_ADDRESS>

not yet, thanks for the suggestion :)

np


xtensor_forward.hpp cleanup

This PRs removes includes and move some definitions to more appropriated files.

If we disable xfixed on msvc because of their compiler bugs with constexpr, we could decide to actually constexpr more things in it, and drop all msvc workarounds.

This currently fails after cleaning the xtensor_forward.hpp header, so I guess it's a mix of constexpr and forward declarations that lead to ICE. I've disabled the tests to be sure this PR is fine.
However I agree with you, I think we should stop trying to support xfixed on MSVC (at least until the compiler is fixed), we just delay the time we get a new ICE and the code get uglier and uglier.


(359) Allow reason to be specified when withdrawing application

Screenshots

 Ability to withdraw Placement Requests

 Fix issue with lost bed dates in the calendar not always displaying correctly


file: Ensure FileTest.charset is fixed under Windows #3530

@jamesnetherton Concerning #3530, I have the hope that it is fixed as side of effect of the #3627 fix. Let's see in this PR if that's actually the case.

Looks there is an issue:
org.awaitility.core.ConditionTimeoutException: org.apache.camel.quarkus.component.file.it.FileTest expected "Hello2" but was "" within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.AbstractHamcrestCondition.await(AbstractHamcrestCondition.java:86)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:939)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:645)
	at org.apache.camel.quarkus.component.file.it.FileTest.filter(FileTest.java:157)

Let's have another run to see whether it's flaky or consistent.

On both run, the charset related test has not failed. We don't see the expected UTF-8 string being read as Hello World ??.
So I would at least merge this one and close the ticket.
Now, those file tests seems to still be flaky. So, yet another ticket should be re-opened for that I think.
@jamesnetherton What do you think ? Maybe you have identified other tasks for the ticket at hand ?


Entering vim for the first time will leave lots of empty line

Hi there,
I use skwp's dotfiles, and I run into this behavior when entering vim for the first time, and exit vim. There will be lots of empty lines in the console.
Here are the screenshots.

if I disable all vim plugins by typing vim -u NONE, it stop occurring. So, it is not specific to zsh nor bash.
I wonder if anyone can help on figuring out the cause of that strange behavior. Thank you in advance.

This is going to be a pretty deep rabbithole to figure out for a relatively minor effect. I don't think this should be here as an issue. Please continue conversation with other users here https://groups.google.com/forum/#!forum/yadr-users

@skwp I've found out the reason why it keeps occurring. Please see my PR Thank you.

nicely done thanks


Silent failure with dockerizePip on CI

Are you certain it's a bug?

[X] Yes, I'm using the latest plugin release

Is there an existing issue for this?

[X] I have searched existing issues, it hasn't been reported yet

Issue description
potentially similar to https://github.com/serverless/serverless-python-requirements/issues/785
When I do serverless package --verbose -c serverless.yml -p dist --stage qa, it works locally, but in Github Actions and in Jenkins the docker command errors out but doesn't seem to include any error message.
It's clear that something has gone wrong, but I haven't been able to find any log files anywhere to find out what. I've removed a good chunk of the functions and configuration in my serverless.yml, but it still happens consistently with this serverless.yml.
I need to package individually for size reasons. I need pip to run in docker because it's compiling science packages.
Service configuration (serverless.yml) content
service: projectName
frameworkVersion: '3'

provider:
  name: aws
  runtime: python3.10
  environment:
      S3_BUCKET: projectBucket
      DEBUG: true

plugins:
  - serverless-python-requirements
  # - serverless-step-functions

custom:
  pythonRequirements:
    dockerizePip: true

functions:
  Postback:
    module: postback
    handler: postback.lambda_handler

package:
  individually: true
  exclude:
    - .git/**
    - node_modules/**

Command name and used flags
package --verbose -c serverless.yml -p dist --stage qa
Command output
Run<EMAIL_ADDRESS>/usr/bin/docker run --name e519d1f229f1572e3f48b3a1f7801d30a01c33_ab7ec9 --label e519d1 --workdir /github/workspace --rm -e "SLACK_WEBHOOK_URL" -e "DEPLOY_ENVIRONMENT" -e "DEPLOY_DESCRIPTION" -e "DEPLOYMENT_ID" -e "AWS_DEFAULT_REGION" -e "AWS_REGION" -e "AWS_ACCESS_KEY_ID" -e "AWS_SECRET_ACCESS_KEY" -e "AWS_SESSION_TOKEN" -e "NPM_CONFIG_USERCONFIG" -e "NODE_AUTH_TOKEN" -e "pythonLocation" -e "PKG_CONFIG_PATH" -e "Python_ROOT_DIR" -e "Python2_ROOT_DIR" -e "Python3_ROOT_DIR" -e "LD_LIBRARY_PATH" -e "INPUT_ARGS" -e "HOME" -e "GITHUB_JOB" -e "GITHUB_REF" -e "GITHUB_SHA" -e "GITHUB_REPOSITORY" -e "GITHUB_REPOSITORY_OWNER" -e "GITHUB_REPOSITORY_OWNER_ID" -e "GITHUB_RUN_ID" -e "GITHUB_RUN_NUMBER" -e "GITHUB_RETENTION_DAYS" -e "GITHUB_RUN_ATTEMPT" -e "GITHUB_REPOSITORY_ID" -e "GITHUB_ACTOR_ID" -e "GITHUB_ACTOR" -e "GITHUB_TRIGGERING_ACTOR" -e "GITHUB_WORKFLOW" -e "GITHUB_HEAD_REF" -e "GITHUB_BASE_REF" -e "GITHUB_EVENT_NAME" -e "GITHUB_SERVER_URL" -e "GITHUB_API_URL" -e "GITHUB_GRAPHQL_URL" -e "GITHUB_REF_NAME" -e "GITHUB_REF_PROTECTED" -e "GITHUB_REF_TYPE" -e "GITHUB_WORKFLOW_REF" -e "GITHUB_WORKFLOW_SHA" -e "GITHUB_WORKSPACE" -e "GITHUB_ACTION" -e "GITHUB_EVENT_PATH" -e "GITHUB_ACTION_REPOSITORY" -e "GITHUB_ACTION_REF" -e "GITHUB_PATH" -e "GITHUB_ENV" -e "GITHUB_STEP_SUMMARY" -e "GITHUB_STATE" -e "GITHUB_OUTPUT" -e "RUNNER_OS" -e "RUNNER_ARCH" -e "RUNNER_NAME" -e "RUNNER_ENVIRONMENT" -e "RUNNER_TOOL_CACHE" -e "RUNNER_TEMP" -e "RUNNER_WORKSPACE" -e "ACTIONS_RUNTIME_URL" -e "ACTIONS_RUNTIME_TOKEN" -e "ACTIONS_CACHE_URL" -e "ACTIONS_ID_TOKEN_REQUEST_URL" -e "ACTIONS_ID_TOKEN_REQUEST_TOKEN" -e "ACTIONS_RESULTS_URL" -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/projectName/projectName":"/github/workspace" e519d1:f229f1572e3f48b3a1f7801d30a01c33 package --verbose -c serverless.yml -p dist --stage qa --param="deployDescription=develop-latest"
Running "serverless" from node_modules

Packaging projectName for stage qa (us-east-1)

Generated requirements from /github/workspace/postback/requirements.txt in /github/workspace/.serverless/postback/requirements.txt
Installing requirements from "/github/home/.cache/serverless-python-requirements/e29a8fbd0127f5ea361fb998fc6a150bec13d9d834f2dad4fb4e6a5d8497bb71_x86_64_slspyc/requirements.txt"
Docker Image: public.ecr.aws/sam/build-python3.10:latest-x86_64
Using download cache directory /github/home/.cache/serverless-python-requirements/downloadCacheslspyc
Running docker run --rm -v /github/home/.cache/serverless-python-requirements/e29a8fbd0127f5ea361fb998fc6a150bec13d9d834f2dad4fb4e6a5d8497bb71_x86_64_slspyc\:/var/task\:z -v /github/home/.cache/serverless-python-requirements/downloadCacheslspyc\:/var/useDownloadCache\:z public.ecr.aws/sam/build-python3.10\:latest-x86_64 /bin/sh -c 'chown -R 0\\:0 /var/useDownloadCache && python3.10 -m pip install -t /var/task/ -r /var/task/requirements.txt --cache-dir /var/useDownloadCache && chown -R 0\\:0 /var/task && chown -R 0\\:0 /var/useDownloadCache'...
Environment: linux, node 18.17.1, framework 3.36.0 (local) 3.36.0v (global), plugin 7.1.0, SDK 4.4.0
Error:
Docs:        docs.serverless.com
Support:     forum.serverless.com
Bugs:        github.com/serverless/serverless/issues

1 deprecation found: run 'serverless doctor' for more details
Running "docker run --rm -v /github/home/.cache/serverless-python-requirements/e29a8fbd0127f5ea361fb998fc6a150bec13d9d834f2dad4fb4e6a5d8497bb71_x86_64_slspyc:/var/task:z -v /github/home/.cache/serverless-python-requirements/downloadCacheslspyc:/var/useDownloadCache:z public.ecr.aws/sam/build-python3.10:latest-x86_64 /bin/sh -c chown -R 0\:0 /var/useDownloadCache && python3.10 -m pip install -t /var/task/ -r /var/task/requirements.txt --cache-dir /var/useDownloadCache && chown -R 0\:0 /var/task && chown -R 0\:0 /var/useDownloadCache" failed with: ""

Environment information
Running "serverless" from node_modules
Framework Core: 3.36.0 (local) 3.36.0 (global)
Plugin: 7.1.0
SDK: 4.4.0

`"serverless-python-requirements": "^6.0.1",` in my package.json

@timnoinc Have you been able to solve this for the CI?

@timnoinc @kvnn Are you using the serverless github action by any chance?
I found that kept hitting silent errors when usin dockerizePip but also was using the above action. That action was erroring with Node 18 which was mismatched from the version I'd installed within setup-node. On closer inspection that actions Dockerfile is using Node 18 and Python 3.10.
Replacing it with an action that installs serverless seems to have resolved my issues:
- run: npm install -g serverless
- name: serverless deploy
  run: "serverless plugin install -n serverless-python-requirements && serverless deploy --stage=prod --verbose"


Add Validation to Plugin Setting Schema

We have replaced the config defaults part of the code but have not replaced the field validation part. Validation should be added to the spec. For example, my /atb plugin has the following config field validations:
    todoChar: /^(?!(?:.*\*){2})[\*|\-|#{1,}]+$/,
    timeBlockHeading: /^[^#+].*/,
    workDayStart: /^\d{2}:\d{2}$/,
    workDayEnd: /^\d{2}:\d{2}$/,

Maybe this is not MVP, but it should be in the dot-one release of settings. Validation settings should be included in the plugin settings so that Eduard can validate the field that the user has entered. I am going to add a regex field called "validation" (a string with escaped RegEx) to my plugin.settings, e.g.:
  "plugin.settings": [
    {
        "key": "todoChar",
        "type": "string",
        "validation": "^(?!(?:.*\\*){2})[\\*|\\-|#{1,}]+$",
	"choices": ["*","-","#","##","###","####"],
        "title": "Time Block Leading Character",
        "description": "For NotePlan to recognize a line as a Time Block, the leading character must be one of: a '*', a '-' or one or more '#'s. You can choose between the 3, but if you are going to create real calendar events from your Time Blocks, you must use the *",
        "default": "*",
        "required": true
    }
  ]

Maybe this is not the ideal example, because there are 'choices', and a user cannot enter other values. But I have many of these, some of which are free-text-entry.

This is a good request. I can immediately think of 1 (but only 1) place I'd add it to my existing settings.
BTW, @EduardMe, there's no visual validation on the "number" type as I was expecting. A text string does get → 0 in the file, but there's no warning to the user.

I think Eduard is using the "type" so he knows what kind of field to use. But that type should also be first-order validation.


Bug: "Reopen closed tab" is always disabled

Description
"Reopen closed tab" is always disabled when right-clicking on a tab even if there are closed tabs. Ctrl+Shift+T works as expected though.

Steps To Reproduce

Close a tab.
Right-click on a remaining tab.
Observe "Reopen closed tab" is disabled.

Requirements
"Reopen closed tab" should be enabled if there are closed tabs.
Files Version
<IP_ADDRESS>
Windows Version
10.0.22631.2715
Log File
n/a

Also affects <IP_ADDRESS>.

Thanks for the report


exploitdb: 2022-10-07 -> 2022-10-18

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/exploitdb/versions.
meta.description for exploitdb is: "Archive of public exploits and corresponding vulnerable software"
meta.homepage for exploitdb is: "https://github.com/offensive-security/exploitdb"
meta.changelog for exploitdb is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2022-10-18 with grep in /nix/store/f3fjn8k5y5pw4vnsxr8fg58i3q49qs0j-exploitdb-2022-10-18
found 2022-10-18 in filename of file in /nix/store/f3fjn8k5y5pw4vnsxr8fg58i3q49qs0j-exploitdb-2022-10-18

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
exploitdb

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/f3fjn8k5y5pw4vnsxr8fg58i3q49qs0j-exploitdb-2022-10-18 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A exploitdb https://github.com/r-ryantm/nixpkgs/archive/22fe35131e0220ca4854761602f0b8c49a53ef33.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/f3fjn8k5y5pw4vnsxr8fg58i3q49qs0j-exploitdb-2022-10-18
ls -la /nix/store/f3fjn8k5y5pw4vnsxr8fg58i3q49qs0j-exploitdb-2022-10-18/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

exploitdb

Maintainer pings
cc @applePrincess @fabaff for testing.

Result of nixpkgs-review pr 197050 run on x86_64-linux 1

1 package built:

exploitdb

[nix-shell:~/.cache/nixpkgs-review/pr-197050-1]$ ./results/exploitdb/bin/searchsploit Wordpress Plugin ImageMagick-Engine 1.7.4
[i] Found (#1): /nix/store/f3fjn8k5y5pw4vnsxr8fg58i3q49qs0j-exploitdb-2022-10-18/share/exploitdb/files_exploits.csv
[i] To remove this message, please edit "/nix/store/f3fjn8k5y5pw4vnsxr8fg58i3q49qs0j-exploitdb-2022-10-18/share/exploitdb/.searchsploit_rc" for "files_exploits.csv" (package_array: exploitdb)

[i] Found (#1): /nix/store/f3fjn8k5y5pw4vnsxr8fg58i3q49qs0j-exploitdb-2022-10-18/share/exploitdb/files_shellcodes.csv
[i] To remove this message, please edit "/nix/store/f3fjn8k5y5pw4vnsxr8fg58i3q49qs0j-exploitdb-2022-10-18/share/exploitdb/.searchsploit_rc" for "files_shellcodes.csv" (package_array: exploitdb)

----------------------------------------------------------------------------------------------------------------------------------------------------------------------- ---------------------------------
 Exploit Title                                                                                |  Path
----------------------------------------------------------------------------------------------------------------------------------------------------------------------- ---------------------------------
Wordpress Plugin ImageMagick-Engine 1.7.4 - Remote Code Execution (RCE) (Authenticated)                                                                                | php/webapps/51025.txt
----------------------------------------------------------------------------------------------------------------------------------------------------------------------- ---------------------------------
Shellcodes: No Results

looks good to me.


US29: The Lobby has WebSocket-integration, e.g. updates the users for all clients when somebody joins.

Closed with commit: 6ce98d8998877e9c76e02fb80f97109aae1d70e1


Update create-safe-sender-lists-in-office-365.md

Removed repetitive word(configure)

@JohanFreelancer9 Please copy review

Issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/3154

@chrisda Please merge this PR. Thanks.


Unable to load an AWS profile by name using either config or process

When I try creating a secret as follows:
CREATE SECRET s3secret (
    TYPE S3,
    PROVIDER CREDENTIAL_CHAIN,
    CHAIN 'process',
    PROFILE 'testprof'
);

I get a return of true but the secret doesn't seem to be valid because I get a 403 when I try to read an S3 parquet file.
Here is an example of what my .aws/config looks like for this profile:
[profile testprof]
granted_sso_start_url      = https://d-xxx.awsapps.com/start
granted_sso_region         = us-east-1
granted_sso_account_id     = xxx
granted_sso_role_name      = SSO-AdministratorAccess
granted_sso_registration_scopes = sso:account:access
common_fate_generated_from = aws-sso
credential_process         = granted credential-process --profile testprof

What additional information can I provide to try to debug this?

you can get the versions of extensions with select * from duckdb_extensions()
and i assume you have tried a different tool like the aws cli to confirm the sso profile is working?
Also just wondering, why are you specifying the process chain? could you try it with the default chain by omitting the chain parameter?

Yes, I use the aws cli and several other tools and utilities with these profiles on a daily basis.
I was trying to use the process chain because currently, DuckDB is not able to get a valid secret and use it with the default chain because I don't currently generate the AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY environment variables, only the AWS_PROFILE variable when I authenticate.
Other tools such as the aws cli will use the credential process of the specified profile if there aren't an id and secret in the environment, and that is what I was attempting to get DuckDB to use as well.
I was able to work around this by passing an argument to granted's authentication telling it to export a temporary id and secret and then launch DuckDB inside that shell, but it isn't optimal because it means I don't get automatic renewal of the credentials and I can't launch DuckDB inside another process such as my database explorer.


Running App

Hello, I have been trying to get your ABR program running but keep seeming to run into environment issues. After running the setup.py and then trying to run abr_gui, I get the following error:
Traceback (most recent call last):
File "/usr/local/bin/abr_gui", line 11, in
load_entry_point('ABR==0.0.0', 'console_scripts', 'abr_gui')()
File "/home/fjames/.local/lib/python3.6/site-packages/pkg_resources/init.py", line 484, in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "/home/fjames/.local/lib/python3.6/site-packages/pkg_resources/init.py", line 2714, in load_entry_point
return ep.load()
File "/home/fjames/.local/lib/python3.6/site-packages/pkg_resources/init.py", line 2332, in load
return self.resolve()
File "/home/fjames/.local/lib/python3.6/site-packages/pkg_resources/init.py", line 2338, in resolve
module = import(self.module_name, fromlist=['name'], level=0)
ModuleNotFoundError: No module named 'abr.app'
Could you provide any insight?

Yes, there are probably some bugs in the setup.py script because I have
only been testing this via "python setup.py develop" (as opposed to "python
setup.py install" or pip install". I have some very recent changes that may
fix this. I'll push these changes either Friday or next week.
On Wed, Oct 10, 2018 at 12:57 PM Frankie James<EMAIL_ADDRESS>wrote:

Hello, I have been trying to get your ABR program running but keep seeming
to run into environment issues. After running the setup.py and then trying
to run abr_gui, I get the following error:
Traceback (most recent call last):
File "/usr/local/bin/abr_gui", line 11, in
load_entry_point('ABR==0.0.0', 'console_scripts', 'abr_gui')()
File "/home/fjames/.local/lib/python3.6/site-packages/pkg_resources/init.py",
line 484, in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "/home/fjames/.local/lib/python3.6/site-packages/pkg_resources/init.py",
line 2714, in load_entry_point
return ep.load()
File "/home/fjames/.local/lib/python3.6/site-packages/pkg_resources/init.py",
line 2332, in load
return self.resolve()
File "/home/fjames/.local/lib/python3.6/site-packages/pkg_resources/init.py",
line 2338, in resolve
module = import(self.module_name, fromlist=['name'], level=0)
ModuleNotFoundError: No module named 'abr.app'
Could you provide any insight?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bburan/abr/issues/1, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAT5QjX2PnhDOWSnwptqevERX9xQmfx3ks5ujlEagaJpZM4XWNpu
.

So I actually found what the issue was, the PYTHONPATH is not getting updated correctly by the setup.py script. In 'packages' you need to include abr.app and abr.parsers and this will solve the above issue however you will still get a "ModuleNotFoundError" saying "No module named 'abr.main_window'" however this can be resolved by export PYTHONPATH=/path/to/abr and then everything will work after a few minor tweaks. I am not sure how to avoid the explicit export though.

@fjames003 I pushed some changes that should fix the issues you're reporting. This version of the program is in development, so you may find a few additional bugs. Please report as you find them. Are you using this with ABR files generated using the EPL CFTS?


Using ".." in a Layout path doesn't work

Repro:
Create a Layout in the parent folder of the view and reference it like this:
Layout = "..\\MyLayout.cshtml";
NB: In Orchard so might affect the behavior.

Does it work with forward slashes?
BTW what exactly "doesn't work"? Bad file path exception thrown? View not found? Where did it look?

I tried this out and seems to works fine. We did fix a bug in preview2 (https://github.com/aspnet/Mvc/issues/6448) where paths returned by ViewLocationExpanders that contain back slashes wouldn't have worked. Perhaps you were hitting this? Let me know if you're still seeing this in preview2 \ RTM  bits.

Just tried with @sebastienros with a <AspNetCoreVersion>2.0.0-*</AspNetCoreVersion>.
We can confirm that Layout = "../_Layout.cshtml" works.

Thanks @jtkech


Update inject container name from istio-proxy to proxy.

Fixed https://github.com/istio/istio.github.io/issues/430

Jenkins job istio.github.io/presubmit passed

istio-proxy is the correct container name in the master branch (see here). proxy is only used by the 0.1 branch.

@ayj I think that we should update document to proxy, as the document will enable user to get the released version which is proxy, comments?

Can you rebase this fix against the release-0.1 branch which corresponds to the 0.1.x versions?

v0.1 document https://istio.io/v-0.1/docs/tasks/istio-auth.html using proxy instead and should works. @ayj


pipeline: init at 1.15.0

Description of changes
Pipeline lets you watch and download videos from YouTube and PeerTube, all without needing to navigate through different websites.
Metadata

homepage URL: https://gitlab.com/schmiddi-on-mobile/pipeline
source URL: https://gitlab.com/schmiddi-on-mobile/pipeline
license: gpl3+

Closes https://github.com/NixOS/nixpkgs/issues/331023

Things done

Built on platform(s)

[X] x86_64-linux
0- [ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[X] sandbox = true

[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ByteSudoer Do you plan to update your PR at some point? I'm going to move it to draft in the meantime, feel free to mark it as ready when you feel it's ready to be reviewed again.


APEXCORE-533 layering of the properties in case of config apps were …

…failing, because of the order in which they are processed, now fixed
@davidyan74 please review.

@davidyan74 addressed all the review comments.


rebuild image when base FROM image is updated

If I have a Dockerfile to describe an image based on (I.e. FROM) say centos:latest, when I rebuild (docker build) that image again with no other changes to the Dockerfile the image is built out of the existing cache layers resulting in an image identical to the previous one.  Good so far.
Where this seems to be a problem is that it appears to be the case even when centos:latest has been updated since the last time I build the image.
It seems to me that FROM would be more useful if it would notice when the source of what it's specifying has been updated and the image is rebuilt from that updated source.
Thoughts?

Closing, this is the wrong repository to report this in. Please ask in https://github.com/moby/moby/

https://github.com/moby/moby/issues/46280 for anyone who comes across this issue.


Enable metrics-server by default

We will build arm images for now as it seems like none are available presently . Currently, we should leverage https://github.com/rancher/metrics-server at least for now.
We should enable metrics-server by default.

rancher/metrics-server:v0.3.6 is now available and supports amd64, arm64, and arm

I was able to confirm that metrics server is being deployed on amd64, arm64, and arm with k3s v0.11.0-alpha4
amd64
root@ip-172-31-24-72:~# kubectl top pods -A
NAMESPACE     NAME                                      CPU(cores)   MEMORY(bytes)
kube-system   coredns-d798c9dd-m2566                    2m           6Mi
kube-system   local-path-provisioner-58fb86bdfd-zqrgq   2m           5Mi
kube-system   metrics-server-6d684c7b5-48fzm            1m           12Mi
kube-system   svclb-traefik-kzmgc                       0m           3Mi
kube-system   traefik-65bccdc4bd-jcd5t                  3m           14Mi

arm
root@husseinpi:~# kubectl top nodes
NAME        CPU(cores)   CPU%   MEMORY(bytes)   MEMORY%
husseinpi   2147m        53%    591Mi           63%

arm64
root@ip-172-31-13-70:~# kubectl top nodes
NAME              CPU(cores)   CPU%   MEMORY(bytes)   MEMORY%
ip-172-31-13-70   56m          1%     740Mi           9%


Cloud endpoints V2: WARNING: storagePath only applies to Dev Appserver v2 and will be ignored by Dev Appserver v1

After migrating to endpoints v2 as per the documentation (https://cloud.google.com/appengine/docs/standard/java/tools/maven-reference). On adding <devserver.storagePath> to appengine-maven-plugin I see a warning "storagePath only applies to Dev Appserver v2 and will be ignored by Dev Appserver v1" and the data store path is ignored.

Hi @darshanlbangre!
Thanks for filing this issue. @loosebazooka have you seen this issue before?

Notice: this issue has been closed because it has been inactive for 651 days. You may reopen this issue if it has been closed in error.


Suggested tweaks to new file methods

I like the handling of str inputs to save(). For load(), it may be better to pass a parameter to enable decoding instead of having an ambiguous return type. Will get some proposed changes up in a sec.

Great stuff, thanks again!

No problem, thank you for contributing!


Resolve Enchantment Name Matching

Stripping underscores here meant enchantments would never match if their equivalent in CMIEnchantment had an underscore in the name as that is what the config is ultimately parsed as.
e.g. Having an enchant such as water_worker which is translated to AQUA_AFFINITY in jobInfo would fail to match as it is compared against the stripped enchantName of aquaaffinity.
My primary concern is that this could break "custom enchants" as the change was initially made for in a451653

We do check by lower cased name without underscore on initialization and when it comes to custom enchant detection we have separate one to fill up cache which is again lower case and removes underscore from all registered enchantments for quick detection. So it should not break custom enchant detection atleast i cant see why it would with current code.

@Zrips Sorry if my description was a little misleading. I'm not concerned that the current code doesn't work with custom enchants, I was concerned that my change might break them.
The current master branch code does not work when processing enchantments with an underscore. The call to prog.getJob().getJobInfo(info, prog.getLevel()) at Jobs:1098 simply returns null.
Perhaps a better solution would be to add more explicit comparisons for EnchantActionInfo to Job.getJobInfo() as there are for PotionItemActionInfo?


Please remove or rename Solarized Dark Grey theme

I was under the impression we were in the process of discussing including the theme in the collection. I've replied to you at Node-RED forum asking not to archive the repository and explaining the reasoning why I would be ok if it was not included in the collection while I would have liked it to be found under the @node-red-contrib-themes org. Now I see the repository archived and no more have access to remove the notice and point the possible few users of the theme back to my personal GitHub repository where I apparently will be maintaining the theme in future.
As I explained in my reply, this is one way to keep my CSS skills up-to-date but I need to be able to maintain the creative freedom to include the "unorthodox" customizations required to make the theme look like it does on the screenshots I've posted at https://discourse.nodered.org/t/announce-node-red-contrib-themes-solarized-dark-grey/29504, even if it means it cannot then be included in the official theme pack.

As per your request, I will remove the theme from the collection.

And if you want, I can transfer ownership of the repository to you.

Thank you!

I still have my own version at https://github.com/ristomatti/node-red-contrib-theme-solarized-dark-grey. Thanks anyway!


Added ALVR repo link

Contributing
Added ALVR repo in repositories for intermediate and advanced coders
If you want to add a project to this list, please make sure that:

[x] You read the contributing guide
[x] The repository has hacktoberfest as topic and counts for hacktoberfest event
[x] The project can't be just an "add your name" or simply + 1 contribution to hacktoberfest
[x] Place them in alphabetical order
[x] One repository per PR/contribution - avoid conflicts and simplify review
[x] Your pull request is not spammy just adding an empty line, otherwise it will be marked as invalid and not count to hacktoberfest.

If they meet the requirements above, feel free to create a PR. Happy Hacking! :sparkles:

Hey, some changes happened in the repository and now we have a git conflict in the repository.
If it's your first time with conflicts, don't worry, it happens sometimes and it is a good opportunity to learn how handle with conflicts. I recommend you to read this article about resolving conflicts.
So, can you fix the conflict?

Hey, some changes happened in the repository and now we have a git conflict in the repository.
If it's your first time with conflicts, don't worry, it happens sometimes and it is a good opportunity to learn how handle with conflicts. I recommend you to read this article about resolving conflicts.
So, can you fix the conflict?

Fixed.

Since all changes were in the same line, each pr that I approve creates another conflict with your prs. Can you fix it again?

Since all changes were in the same line, each pr that I approve creates another conflict with your prs. Can you fix it again?

Yeah have seen. But only because of the rule one repo contribution per pr that’s why created each pr for each added repo

Since all changes were in the same line, each pr that I approve creates another conflict with your prs. Can you fix it again?

Fixed


websocket integration tests missing for Command Docs

@lucifercr07  created new issue for missing tests

@lucifercr07  i havn't worked on this will work on this weekend

hi @lucifercr07  what type of IT in websocket should i add for command docs it is just a retrieval command

I have added other IT in http and async . so i want to know if i should do something in websocket as i believe it would be a simple call just like async and http

@lucifercr07  can you review #1323

@lucifercr07  i think i dont understand complete architecture for this project should i just read architecture of redis , can you guide me on that part to understand what to look into , thanks

Closing, merged as part of https://github.com/DiceDB/dice/pull/1323


fix: ci with no npm cache

Checklist:

I hope this fixes the issues of git permissions, based on Naomi's suggestion - so, if it does not work == not my fault

Did this make a difference?

No, but I am too lazy to add it back 😅


Scalar type ResolverInfo::getFieldSelection support

Support calling ResolveInfo::getFieldSelection() on scalar types
Related: https://github.com/webonyx/graphql-php/pull/528

Love github mobile. @simPod squash merge this for me? 😇

@vladar is owner here, let's wait what he has to say on this ;)

Merged. Thanks, guys!

Awesome thanks 🙏 can you tag a release? Thanks! 🚀

Just published v0.13.6


steam api.dll deletes itself when showing the mod manager its directory

Please check the troubleshooting guide in the Wiki before submitting an issue.
As soon as I set the directory, the steam api.dll is deleted and copy pasting doesnt get it back, neither does moving a backup into the folder.
To Reproduce
Steps to reproduce the behavior:

Set directory
open the game in any way
See error

Expected behavior
The game opening like normal
Screenshots

Desktop (please complete the following information):

Windows:
11

Additional context
when i DO have the api.dll, the game shows a 0xc0000906 error

This isn't an issue with the Manager as it does nothing to this file. If you're having errors with this, your antivirus likely believes it to be a virus.
Generally having issues with this file means you pirated the game as this file acts as DRM. We do not ensure things work with pirated copies, and we won't provide any assistance on making it work either.


Make timestamp parser able to use optional property?

In our datasource, we have two timestamps, "createdAt" and "updatedAt". Problem is that "updatedAt" is not available on new objects. They only get that property once they have been save at least once after their creation.
So, using the following offset pointer will break on new objects, but work fine otherwise.
"http.response.record.offset.pointer": "key=/id, timestamp=/updatedAt"
Would it be possible override some of the classes to come around this?

Managed to successfully override this. It's a bit awkward, as I have to copy the full structure of the JacksonKvRecordHttpResponseParser class just to be able to override the JacksonResponseRecordParser::toJacksonRecord :)
    private JacksonRecord toJacksonRecord(JsonNode jsonRecord, Map<String, Object> responseOffset) {
        if (jsonRecord.has("createdAt") && !jsonRecord.has("updatedAt")) {
            ((ObjectNode) jsonRecord).put("updatedAt", jsonRecord.get("createdAt"));
        }

        return JacksonRecord.builder()
                .key(recordParser.getKey(jsonRecord).orElse(null))
                .timestamp(recordParser.getTimestamp(jsonRecord).orElse(null))
                .offset(merge(responseOffset, recordParser.getOffset(jsonRecord)))
                .body(recordParser.getValue(jsonRecord))
                .build();
    }


Rebased and switched to the expected Logger

Hi,
Having noticed you did not do the change in August to have the credential service be integrated into NuKeeper, I took the liberty to do the needed updates, as well as to rebase the branch you were proposing.
I hope this very modest contribution could help you take the needed steps to have your PR completed.
Regards,

Aha! I somehow missed this, I usually get notifications for everything on GitHub. This looks great, Thanks for contribution!


ciao-cnci-agent: use /etc/pki/ciao for keys

For simple historical reasons github.com/01org/ciao/networking/ciao-cnci-agent/scripts/generate_cnci_cloud_image.sh uses /var/lib/ciao/ instead of /etc/pki/ciao for key location as the rest of Ciao uses.  It should use the standard location for consistency with the rest of ciao.

Dropping bug label as this doesn't cause any problems.


Make sure there is enough space left in the packet before adding frames

When we add frames in Connection.send(), some frames are missing
checking if there is enough space left in the packet (left),
may cause underflow of left in release build (debug build
it will crash runtime)

Also tweaked the macro's docs a bit.


[Bug]: Using bazel-bin/external/pnpm to run a helper shell file (via package.json script) include unnecessary environment variables breaks tooling

What happened?
We have multiple shell files which helps locate build target and build specific arguments to run against bazel test and bazel run. These shell files run bazel commands. To trigger these shell scripts, we have added them to package.json scripts--so we can just pnpm run <script name> <args>.
While trying to add further Playwright integration to update snapshots, we are noticing that Playwright is reporting "missing tests". Upon investigating, we found that bazel-bin/external/pnpm includes a bunch of NPM_* and JS_BINARY_* environment variables to the shell script, which in turn make available to the bazel run call in the script and confuses Playwright. If we were to bazel run directly from the terminal, Playwright can locate the test. It seems that the issue is from these environment variables being included as part of running pnpm as unsetting all of the JS_BINARY_* variables inside the shell script before calling bazel run fixes the issue.
Overall, the problem seem to stem from bazel-bin/external/pnpm as it should not be "leaking" these JS_BINARY_* environment variables.
Version
Development (host) and target OS/architectures:
Output of bazel --version: 7.1.1
Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file: 1.42.3
Language(s) and/or frameworks involved: Playwright
How to reproduce
No response
Any other information?
No response

A workaround that we came up with temporarily is our shel scripts do this if they detect pnpm is running under bazel
# Unset any environment variables that start with JS_BINARY__
for var in $(env | grep -o '^JS_BINARY__[^=]*'); do
  if [ "$var" != "JS_BINARY__NODE_BINARY" ] && [ "$var" != "JS_BINARY__NODE_PATCHES" ]; then
    unset "$var"
  fi
done


WIFI does not appear (esp32WROOM-32D/WROVER/WROOM-32)

I do everything according to the example. (a month ago this process was successful, there was QR pairing with RAINMAKER and Homekit).
Flashing devices is a success
Also WIFI does not appear when I flash from esp-homekit-sdk
Data from the device monitor:
00:19:54.617 -> x⸮�⸮x⸮{R⸮⸮⸮⸮0,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
00:19:54.617 -> mode:DIO, clock div:2
00:19:54.617 -> load:0x3fff0030,len:4
00:19:54.617 -> load:0x3fff0034,len:6964
00:19:54.617 -> load:0x40078000,len:13072
00:19:54.617 -> load:0x40080400,len:3896
00:19:54.617 -> entry 0x40080688
00:19:54.617 -> I (28) boot: ESP-IDF v4.1-dirty 2nd stage bootloader
00:19:54.733 -> I (28) boot: compile time 00:16:56
00:19:54.733 -> I (28) boot: chip revision: 1
00:19:54.733 -> I (31) boot_comm: chip revision: 1, min. bootloader chip revision: 0
00:19:54.733 -> I (40) boot.esp32: SPI Speed      : 40MHz
00:19:54.733 -> I (43) boot.esp32: SPI Mode       : DIO
00:19:54.733 -> I (47) boot.esp32: SPI Flash Size : 4MB
00:19:54.733 -> I (52) boot: Enabling RNG early entropy source...
00:19:54.733 -> I (57) boot: Partition Table:
00:19:54.733 -> I (61) boot: ## Label            Usage          Type ST Offset   Length
00:19:54.733 -> I (68) boot:  0 sec_cert         unknown          3f 00 0000d000 00003000
00:19:54.733 -> I (76) boot:  1 nvs              WiFi data        01 02 00010000 00006000
00:19:54.733 -> I (83) boot:  2 otadata          OTA data         01 00 00016000 00002000
00:19:54.733 -> I (91) boot:  3 phy_init         RF data          01 01 00018000 00001000
00:19:54.733 -> I (98) boot:  4 ota_0            OTA app          00 10 00020000 00190000
00:19:54.733 -> I (106) boot:  5 ota_1            OTA app          00 11 001b0000 00190000
00:19:54.733 -> I (113) boot:  6 fctry            WiFi data        01 02 00340000 00006000
00:19:54.733 -> I (121) boot: End of partition table
00:19:54.733 -> I (125) boot_comm: chip revision: 1, min. application chip revision: 0
00:19:54.733 -> I (132) esp_image: segment 0: paddr=0x00020020 vaddr=0x3f400020 size=0x47108 (291080) map
00:19:54.745 -> I (252) esp_image: segment 1: paddr=0x00067130 vaddr=0x3ffbdb60 size=0x04008 ( 16392) load
00:19:54.745 -> I (259) esp_image: segment 2: paddr=0x0006b140 vaddr=0x40080000 size=0x00404 (  1028) load
00:19:54.745 -> I (260) esp_image: segment 3: paddr=0x0006b54c vaddr=0x40080404 size=0x04acc ( 19148) load
00:19:54.757 -> I (276) esp_image: segment 4: paddr=0x00070020 vaddr=0x400d0020 size=0x101e1c (1056284) map
00:19:55.165 -> I (679) esp_image: segment 5: paddr=0x00171e44 vaddr=0x40084ed0 size=0x18808 (100360) load
00:19:55.232 -> I (738) boot: Loaded app from partition at offset 0x20000
00:19:55.232 -> I (738) boot: Disabling RNG early entropy source...
00:19:55.232 -> I (739) cpu_start: Pro cpu up.
00:19:55.232 -> I (742) cpu_start: Application information:
00:19:55.232 -> I (747) cpu_start: Project name:     switch
00:19:55.232 -> I (752) cpu_start: App version:      1.0
00:19:55.232 -> I (757) cpu_start: Compile time:     Oct 13 2020 00:16:39
00:19:55.279 -> I (763) cpu_start: ELF file SHA256:  5a9de1beab98ca2a...
00:19:55.279 -> I (769) cpu_start: ESP-IDF:          v4.1-dirty
00:19:55.279 -> I (774) cpu_start: Starting app cpu, entry point is 0x40081368
00:19:55.279 -> I (0) cpu_start: App cpu up.
00:19:55.279 -> I (784) heap_init: Initializing. RAM available for dynamic allocation:
00:19:55.279 -> I (791) heap_init: At 3FFAFF10 len 000000F0 (0 KiB): DRAM
00:19:55.279 -> I (797) heap_init: At 3FFB6388 len 00001C78 (7 KiB): DRAM
00:19:55.302 -> I (803) heap_init: At 3FFB9A20 len 00004108 (16 KiB): DRAM
00:19:55.302 -> I (810) heap_init: At 3FFBDB5C len 00000004 (0 KiB): DRAM
00:19:55.302 -> I (816) heap_init: At 3FFCEA78 len 00011588 (69 KiB): DRAM
00:19:55.302 -> I (822) heap_init: At 3FFE0440 len 00003AE0 (14 KiB): D/IRAM
00:19:55.338 -> I (828) heap_init: At 3FFE4350 len 0001BCB0 (111 KiB): D/IRAM
00:19:55.338 -> I (835) heap_init: At 4009D6D8 len 00002928 (10 KiB): IRAM
00:19:55.338 -> I (841) cpu_start: Pro cpu start user code
00:19:55.338 -> I (859) spi_flash: detected chip: gd
00:19:55.338 -> I (860) spi_flash: flash io: dio
00:19:55.338 -> I (860) cpu_start: Starting scheduler on PRO CPU.
00:19:55.338 -> I (0) cpu_start: Starting scheduler on APP CPU.
00:19:55.371 -> I (868) esp_rmaker_commands: Registering command: up-time
00:19:55.371 -> I (0) esp_rmaker_console: Initialising UART on port 0
00:19:55.371 -> I (878) uart: queue free spaces: 8
00:19:55.371 -> I (888) esp_rmaker_commands: Registering command: mem-dump
00:19:55.371 -> I (888) esp_rmaker_commands: Registering command: task-dump
00:19:55.371 -> I (898) esp_rmaker_commands: Registering command: cpu-dump
00:19:55.404 -> I (898) esp_rmaker_commands: Registering command: sock-dump
00:19:55.404 -> I (908) esp_rmaker_commands: Registering command: heap-trace
00:19:55.404 -> I (918) esp_rmaker_commands: Registering command: reset-to-factory
00:19:55.404 -> I (918) esp_rmaker_commands: Registering command: add-user
00:19:55.404 -> I (928) esp_rmaker_commands: Registering command: get-node-id
00:19:55.438 -> I (938) esp_rmaker_commands: Registering command: wifi-prov
00:19:55.438 -> I (938) esp_rmaker_commands: Registering command: local-time
00:19:55.438 -> I (948) esp_rmaker_commands: Registering command: tz-set
00:19:55.438 -> I (958) gpio: GPIO[0]| InputEn: 1| OutputEn: 0| OpenDrain: 0| Pullup: 1| Pulldown: 0| Intr:3
00:19:55.438 -> I (958) gpio: GPIO[19]| InputEn: 0| OutputEn: 1| OpenDrain: 0| Pullup: 1| Pulldown: 0| Intr:0
00:19:55.472 -> W (968) ws2812_led: WS2812 LED is disabled
00:19:55.507 -> I (1038) wifi:wifi driver task: 3ffd4ec4, prio:23, stack:6656, core=0
00:19:55.507 -> I (1038) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE
00:19:55.540 -> I (1038) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE
00:19:55.540 -> I (1068) wifi:wifi firmware version: 3ea4c76
00:19:55.540 -> I (1068) wifi:config NVS flash: enabled
00:19:55.540 -> I (1068) wifi:config nano formating: disabled
00:19:55.574 -> I (1068) wifi:Init dynamic tx buffer num: 32
00:19:55.574 -> I (1068) wifi:Init data frame dynamic rx buffer num: 32
00:19:55.574 -> I (1078) wifi:Init management frame dynamic rx buffer num: 32
00:19:55.574 -> I (1088) wifi:Init management short buffer num: 32
00:19:55.574 -> I (1088) wifi:Init static rx buffer size: 1600
00:19:55.574 -> I (1088) wifi:Init static rx buffer num: 10
00:19:55.574 -> I (1098) wifi:Init dynamic rx buffer num: 32
00:19:55.608 -> I (1118) esp_claim: Initialising Assisted Claiming. This may take time.
00:19:55.608 -> I (1148) esp_claim: Private key already exists. No need to re-initialise it.
00:19:55.640 -> I (1168) app_main: RainMaker Initialised.
00:19:55.640 -> I (1168) esp_rmaker_node: Node ID ----- 3C71BF5EEA1C
00:19:55.674 -> I (1178) esp_rmaker_ota: OTA state = 2
00:19:55.674 -> I (1178) esp_rmaker_ota_using_params: OTA enabled with Params
00:19:55.674 -> I (1178) esp_rmaker_time_sync: Initializing SNTP. Using the SNTP server: pool.ntp.org
00:19:55.674 -> I (1188) esp_rmaker_core: Starting RainMaker Core Task
00:19:55.674 -> I (1198) app_main: RainMaker Claim Started.
00:19:55.674 -> I (1198) esp_claim: Waiting for assisted claim to finish.
00:19:55.708 -> I (1198) wifi_prov_scheme_ble: BT memory released
00:19:55.708 -> I (1208) app_wifi: Starting provisioning
00:19:55.813 -> I (1318) phy: phy_version: 4180, cb3948e, Sep 12 2019, 16:39:13, 0, 0
00:19:55.813 -> I (1318) wifi:mode : sta (3c:71:bf:5e:ea:1c)
00:19:55.813 -> I (1328) BTDM_INIT: BT controller compile version [219866f]
00:19:55.813 -> I (1328) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE
00:19:56.157 -> I (1688) wifi_prov_mgr: Provisioning started with service name : PROV_5EEA1C
00:19:56.190 -> I (1688) app_wifi: Provisioning started
00:19:56.190 -> I (1688) app_wifi: Scan this QR code from the phone app for Provisioning.
00:19:56.258 ->
00:19:56.258 ->   █▀▀▀▀▀█ ▀▀▀█▄█   █▀▄ ▀█▀  █▀▀▀▀▀█
00:19:56.258 ->   █ ███ █  ▀▄█ █▄ ▀▄█▀ ▀  ▄ █ ███ █
00:19:56.258 ->   █ ▀▀▀ █  ▄▀█▀▄▀ ▀█ ▀▀▀▄█  █ ▀▀▀ █
00:19:56.258 ->   ▀▀▀▀▀▀▀ █▄▀ █▄█▄█ ▀▄▀ █ ▀ ▀▀▀▀▀▀▀
00:19:56.293 ->   ▀▀▄▀▀▄▀▄ ▀▄ ▀▄ ▄▀▀▄█  ▀▄▄ ▀▄▄ ▄▄▀
00:19:56.293 ->   ▀▄ ███▀ ▄▀  ▀▀▀▀▄█  ▄▀ ▀ █  ▄█▄█▀
00:19:56.293 ->   ▀▀ ▀ ▄▀▀███ ▄▄██▄ ▄▀▄▀   ▄▀█ ▀▄▄▀
00:19:56.293 ->   ██▀ ▄█▀█▄   ▄ ▄█▄ ▀█▄ ▀▄▀▄▄█  ▄
00:19:56.330 ->   █ ▀▀██▀ █▀██▀▀ █▀▄▀▄▀ ▄█  ███▄ ██
00:19:56.330 ->      █ █▀▀ ▀▄▄▀▄███  ▀█ ▀█ █▀▀ ▀▄▄▀
00:19:56.330 ->   █▀▄▀██▀▀▀ █▀▄▄█▄▀▀█▄█▄█▀▀█ ▀▄ ▄▀
00:19:56.330 ->   █ ▄▀ ▄▀█▄█▀█▄  ▀█▄█▄▀▀█▀█ ▄█ ▀▄▄█
00:19:56.330 ->   ▀▀  ▀ ▀ █▀▀▀▀▄▄██▄█▀█ ▀██▀▀▀█▄▄▀
00:19:56.363 ->   █▀▀▀▀▀█  ▄ █▀▀▀██ ▄▀▄ █▄█ ▀ █ ▄ ▄
00:19:56.363 ->   █ ███ █ █▄▀▄█▀▀█▀▄█▄▄ ▀██▀▀▀▀▄▄▀▀
00:19:56.363 ->   █ ▀▀▀ █ ▄█▀▀ ▄█▀█ █▀ ▀▀███▄▀█ █▄█
00:19:56.363 ->   ▀▀▀▀▀▀▀ ▀▀▀▀  ▀▀ ▀     ▀▀▀▀▀▀
00:19:56.401 ->
00:19:56.401 ->
00:19:56.401 -> I (1898) app_wifi: If QR code is not visible, copy paste the below URL in a browser.
00:19:56.401 -> https://rainmaker.espressif.com/qrcode.html?data={"ver":"v1","name":"PROV_5EEA1C","pop":"5d1f5ea7","transport":"ble"}
00:19:56.401 -> I (1918) app_wifi: Provisioning Started. Name : PROV_5EEA1C, POP : 5d1f5ea7
00:20:45.334 -> E (50848) security1: Security version mismatch. Closing connection
00:20:45.334 -> E (50848) protocomm_ble: Invalid content received, killing connection

I answer to myself. It is necessary (in advance) to be registered in advance in the rainmaker application

Hello @shahpiyushv
flash devices on different examples went great. But the problem is that the rebooted device does not broadcast open WIFI. WIFI is hidden. BLE Provisioning and SoftAP Provisioning cannot find the device. ESP RainMaker has fixed the situation. But you must first register there. Also at the moment there is the following issue https://github.com/espressif/esp-idf/issues/5962#issuecomment-706987249 and I am using a workaround and using links to QR codes on web-browser.


chore: adopt opentelemetry-propagator-jaeger

Move opentelemetry-propagator-jaeger from contrib to core.
This is to enable turning on the jaeger propagator using ENV variables.
Default Node Tracer Provider needs to depend on Jaeger propagator.
Which problem is this PR solving?

Progress towards #1675
unblocks #1929
open-telemetry/opentelemetry-js-contrib#351

Short description of the changes

moves opentelemetry-propagator-jaeger from contrib into core, allowing other core packages to rely on it

Default Node Tracer Provider needs to depend on Jaeger propagator.

Sorry but i can't find in the spec where they require to install jeager propagator by default on the node tracer, unless i misunderstood ?

@vmarchaud so the basic requirements are here https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/sdk-environment-variables.md#general-sdk-configuration. We have discussed a couple of approaches back in early January and we never managed to come up with a good optional dependency approach. E.g. peerdependencies generates warnings, so in the end we decided to just pull it in. Let me know if it's an issue.

Well not sure if that means the sdk need to be able to instantiate all of them ? I mean there are values for vendor specific propagator

@vmarchaud Thanks for the time to review! Last time it was discussed there were no 3rd party propagators, now there are. 1st party propagators in core and loading out of the box seems like a good user experience to me. I'm not sure what to do about 3rd party propagators. Maybe it's best to quickly discuss this during SIG?

Maybe it's best to quickly discuss this during SIG?

Can you please add it to the agenda?

1st party propagators in core and loading out of the box seems like a good user experience to me

Agree, lets discuss this at the SIG indeed

Is it possible to try doing this while preserving the history? I've never done this and it doesn't look like fun, but it would be "nice".
medium.com/@ayushya/move-directory-from-one-repository-to-another-preserving-git-history-d210fa049d4b

I have done this multiple times. The best way I have found to do it is to use git-filter-repo, then you rebase that onto the new repository.

get a fresh clone of the source repo
use git-filter-repo to filter the source repo down to only the files you need

git-filter-repo --path propagators/opentelemetry-propagator-jaeger --path-rename propagators/opentelemetry-propagator-jaeger:packages/opentelemetry-propagator-jaeger

add the target repo as a remote on your source clone

git remote add core git@github.com:open-telemetry/opentelemetry-js.git

rebase the source on the target main

git fetch core
git rebase core/main

during this step you may need to use the -i flag to edit any commits with invalid CLA

push the source branch to a new branch on the target

git push core HEAD:jaeger

Create a pull request from that branch to main

The biggest issue is ensuring all commit authors have signed the CLA. It shouldn't be a problem for us though because it is our repo.

Seeing the result of importing the history i would prefer to not import it at all, we will have release commit from contrib inside the core which i think will give us trouble later to understand what happened. Since all commits reference their PR for the context, i think it should be enough to squash everything.

Seeing the result of importing the history i would prefer to not import it at all, we will have release commit from contrib inside the core which i think will give us trouble later to understand what happened. Since all commits reference their PR for the context, i think it should be enough to squash everything.

Squash looses the blames and the dates things happened which can be useful when debugging issues later. I personally use blame all the time to figure out who to ask about certain things. The release commits are different because these will be the release dates of the jaeger propagator (contrib) not the core repo. I think we can keep everything.

@jtmalinowski I think we can move this forward, could you upgrade to use the version 0.18.0 of the API as the rest of the repo ?

We need to merge this before merging https://github.com/open-telemetry/opentelemetry-js-contrib/pull/351 so the propagator exists in one of our repo.
cc @open-telemetry/javascript-approvers can someone review this ? This is a simple cp from the contrib  (see https://github.com/open-telemetry/opentelemetry-js-contrib/pull/351)

@jtmalinowski are you still working on this? There are several open comments over a week old

@dyladan To be honest, I don't think I'll have enough time to ensure smooth progress of this feature (specification env vars) within the next couple of weeks, so it's probably best if you reassign it to someone else. Unless you're fine if it's resumed in late April.

it's fine if you don't have time for the ENV var feature, but we should at least try to bring the jaeger package across with no other changes yes?

@dyladan Sure, that makes sense. I'll address the comments within 2-3 days.

Apologies, I had to force-push, because someone merged main in the meantime and there would otherwise be quite a lot of git history straightening for me locally.
@dyladan in terms of final commit structure, because we can't squash-merge for linear history, I suggest:

one final interactive rebase right before merging
interactive rebase to remove "merge main" commits
squash all my changes into 1 commit
merge PR using rebase-merge

If you don't mind non-linear history then just rebase-merge should be fine.

I don't mind nonlinear history. I'm more worried about accurate blames than the timeline.


Reworked all the toggles to be checkboxes

Reworked all the toggles to be checkboxes, to comply with the rest of the tweaks,
This allows us to use it from the config winutil -Config <path> -Run, now we can automate this and even tweaks,
UNDO also works and Get Installed also works
@ChrisTitusTech Feel free to not take this PR is you think toggles as they were are more important than ability to automate everything.
NEXT: If PR is taken, fold this into Microwin.iso and run it after install is done

Yeah I think having toggles and being more user friendly is far more important than automating it. Most of the user base these days are more normal users than power users.

@ChrisTitusTech sounds good makes total sense.  :-) In this case I would also recommend to back out my other commits that add Global Config Import/Export functionality. See, importing settings doesn't work well with things real time knobs that change the environment in real time when you press a button. And because of that there is a bug right now, if you export let's say a white theme and you have a dark theme set the knobs will act in reverse. (there is an issue reported on that) Which settings you need a positive "hand off" like you load them and click apply button. In that regard I really like how the tweaks are done, it's almost all data driven which is awesome.
Hope you don't mind me splitting the project, I will probably rename it to like WinUtilEx and continue working on this path, I really want to be able to call winutil at the end of the setup in microwin. The point that I want to get to, is create microwin image that will allow and call winutil at the end of setup process to setup all the apps and apply all the tweaks to the system, in order to do that I need this import/export functinality to work properly and for that we can't have real time knobs. :)


Class 'DOMPDFModule\View\Model\PdfModel' not found

in my controller
use DOMPDFModule\View\Model\PdfModel;
public function monthlyReportPdfAction()
{
$model = new PdfModel();
$model->setOption('paperSize', 'a4');
$model->setOption('paperOrientation', 'landscape');
    return $model;
}

clear my issue,
I just download ur  DOMPDFModule and put in my vendor

Hi @bhuvaneshwaran and @mamont77,
As you've noticed DOMPDFModule hasn't received the time and attention it deserves. I understand how frustrating this is and I'm sorry you've had to deal with this frustration 😢
I'm currently taking steps to stabilize DOMPDFModule which includes code updates as well as creating a backlog that will ensure its continued success.
You can follow project Phoneix  to see what immediate work is being prioritized.
Thank you for your understanding and patience.

@bhuvaneshwaran and @mamont77 please try installing v0.4.0 via composer. If you continue to experience issues please open a new issue.
Closing issue due to age and proposed solution.


S3 location loader

Has anyone created a loader that will read from s3?
http://owner.newinstance.it/latest/apidocs/org/aeonbits/owner/loaders/Loader.html
We're on a PaaS that has an ephemeral filesystem and want to be able to read and write properties dynamically.

I'm not aware of anyone providing the S3 loader.
if you implemented by your own, you can contribute it into the owner-extras module with unit tests (mandatory), and eventually write some documentation for the site (optional).
If the code is ok and you're agreeing to license it with OWNER license I will merge it.
Thanks.
L.


Added SSRF Finding

Added metadata as requested.  Yea. Definitely willing to update with some pictures once you decide on how you want to handle that.

please put any images in the "imgs/" director and reference them using ![](imgs/web/ssrf1.png) format.

Should be good to go now.  When I used ![](imgs/web/ssrf1.png) as requested, it was looking in ...cfdb/web/imgs/web/ssrf1.png.
I'm still a git n00b, so the only way I could get it to work was putting an imgs directory inside of web, which is what you can see now - ex: ![](imgs/ssrf3.png).
Let me know if what you see is not what you envisioned.


[stable/prometheus-operator] fixed hardcoded label for grafana servicemonitor

Now each grafana instance can have it's own servicemonitor. Fixes #23513

[x] DCO signed
[x] Chart Version bumped

/assign @bismarck

/hold
Let’s hold PRs to stable prometheus charts for a short time until prometheus-community/community#28 (comment) is resolved. If you want to help with that effort, to test etc, that would be great!


Objective-c Compatibility

Is it compatible Objective-c ? The override change stat doesn't call with Objective-c code.
Thanks in advance.

you can import the swift file in the Objective C project using bridging header.
Check this :
http://stackoverflow.com/questions/24002369/how-to-call-objective-c-code-from-swift

@remirobert : just use paper switch in Obj C Code :
https://github.com/JigarM/paper-switch-ObjectiveC

It doesn't work for me programtly, from a UItableViewCell or a simple UIView.
self.switchResponse = [[RAMPaperSwitch alloc] init];
self.switchResponse.frame = CGRectMake(self.mainView.frame.size.width - self.switchResponse.frame.size.width - 10, 0,
self.switchResponse.frame.size.width, self.switchResponse.frame.size.height);
[self.mainView addSubview:self.switchResponse];
[self.switchResponse setOnTintColor:[UIColor blueColor]];


Add UNSTIM university domain

I add UNSTIM, Benin University domain to get the license of Jetbrains product for student from UNSTIM.

@TawalMc Pull request merged. Thank you!

Thank you too much.
Le dim. 28 févr. 2021 à 01:18, Philip Torchinsky<EMAIL_ADDRESS>a écrit :

@TawalMc https://github.com/TawalMc Pull request merged. Thank you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/JetBrains/swot/pull/10798#issuecomment-787208645, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AHXC4BF2IJDTT75NGH2GL7LTBGDWTANCNFSM4X3AHNKA
.

Or I have a question how many times will I wait to download the student
version ?
Le dim. 28 févr. 2021 à 12:35, Tawal Mc<EMAIL_ADDRESS>a
écrit :

Thank you too much.
Le dim. 28 févr. 2021 à 01:18, Philip Torchinsky<EMAIL_ADDRESS>a écrit :

@TawalMc https://github.com/TawalMc Pull request merged. Thank you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/JetBrains/swot/pull/10798#issuecomment-787208645,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHXC4BF2IJDTT75NGH2GL7LTBGDWTANCNFSM4X3AHNKA
.


Issue when we try to download heavy project (700Mo) on Qfiel-dev app Android from Cloud

We have create new projet from windows Qgis application and then upload to Qfield cloud whithout any issue. But when we try to open the project on Android application, we have an error message ("download error. Exportation issue"). We have try to download form WIFI an from 4G connexion with the same. This project is haevy 700Mo, we don't have any problem with a light project (28Mo).
Thanks

@lkino hey, thanks for checking QFIeldCloud. We have detected and fixed some issues with timeouts, which prevented users to download big projects. Have you tried recently to confirm if this is still an issue for you?


Newtonsoft dll error while installing the Templates

Hi,
I am getting the following error on running the power shell command let for  Provisioning the template.
PowerShell Command
Apply-SPOProvisioningTemplate -Path "[Partner-Pack-Source-Code-Folder]\OfficeDevPnP.PartnerPack.SiteProvisioning\OfficeDevPnP.PartnerPack.SiteProvisioning\Templates\Infrastructure\PnP-Partner-Pack-Infrastructure-Jobs.xml"
ERROR
Apply-SPOProvisioningTemplate : Could not load file or assembly 'Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral,
PublicKeyToken=30ad4fe6b2a6aeed' or one of its dependencies. The system cannot find the file specified.
Has anyone else encountered the same issue ?
Thanks in advance.
Rajesh

Please, be sure to have the latest release of the PnP PowerShell cmdlets, which are available here: https://github.com/OfficeDev/PnP-PowerShell/tree/master/Binaries
Thanks,
Paolo

Hi Paolo,
I tried doing this but still the same error...
I tried updating the Newtonsoft dll's to the latest version i.e. <IP_ADDRESS> but i still get the same error. I couldn't find any reference to <IP_ADDRESS> version of Newtonsoft anywhere .
Am i missing something here ?
Thanks,
Rajesh

So...I updated nuget package for all projects...re-installed PnP Powershell commandlets...didn't work
Closed everything...restarted...bingo....all good...
Rajesh


Try to eliminate useNetworkGateway settings

Now, if someone uses Docker for Mac then they must manually set useNetworkGateway=false. It would be great to automatically detect presence of Docker for Mac and if present then automatically use localhost.

Could you please look at this, @remen?

Also discussed in #18. We should probably wait for final version of Docker for Mac/Windows.

Well, after thinking about it for 5m, I think a good temporary workaround would be to determine whether it is a Mac at all, in which case either DOCKER_HOST will be set (if using docker-machine), or we can assume that we can connect to localhost.
The situation is probably a bit more complex than that, because Docker for Mac has a bunch of options for networking. But this would at least support the majority of the use cases, and we can evolve the design from there.
Sound good? In that case I'll investigate this path and send another PR.

Sounds good, thanks!

Alrighty. Added a new PR which checks whether running on Mac.
If this is merged, when is the next release upcoming? Need to know whether to release an internal version at our company or if we can wait for next release of this plugin.

I will release a new version right after merging.


Update ThreeStacks - isEmpty function

variable is not equal to the parameter you are passing

Good catch, thank you!