Use ExceptT instead of (deprecated) ErrorT

The ErrorT monad transformer is deprecated.

Good timing, I am in the process of switching to ExceptT in elm-compiler, so I was going to have to make it flow through everything soon!
Thanks for the PR!


Exercise requires iMod without much previous exposure to the tactic

Following the Recommended Learning Path, by the time one gets to the hoare_triple_dfrac exercise in resource_algebra.v, one will have seen iMod being used to make use of a lemma exactly once – in persistently.v, quite a while ago.
Moreover, at that point one doesn't have much practical experience doing that themselves. hoare_triple_dfrac is the first exercise that requires iMod.
This might make it quite hard to remember that iMod is how one is supposed to eliminate the update modality. Indeed, I myself got stuck expecting iApply to handle the modality for me. It might be a good idea to either insert more exercises requiring the use of iMod along the way, to give students the chance to learn it when it is being first introduced, or add a hint to the hoare_triple_dfrac exercise reminding the student of the existence of the iMod tactic.

For what it's worth, I did hoare_triple_dfrac using only iApply, which I guess is willing to eliminate the |==> in a hypothesis if it's being applied to a goal that has a (fancy) update modality.

@hackedy could you share your proof? I tried exactly that and it didn't work. Maybe Iris has changed since you did the exercise?

Hi Maja, here's my proof
Lemma hoare_triple_dfrac (γ : gname):
  {{{ own γ (DfracOwn 1) }}} #1 + #1 {{{v , RET v; own γ DfracDiscarded }}}.
Proof.
  iIntros "* Hown Hpost".
  rewrite own_dfrac_update.
  wp_pures.
  iApply "Hpost".
  iApply "Hown".
Qed.

Here's the versions of everything
% opam list
# Packages matching: installed
# Name                # Installed # Synopsis
base-bigarray         base
base-domains          base
base-nnp              base        Naked pointers prohibited in the OCaml heap
base-threads          base
base-unix             base
conf-gmp              4           Virtual package relying on a GMP lib system install
conf-pkg-config       3           Check if pkg-config is installed and create an opam
coq                   8.19.2      The Coq Proof Assistant
coq-core              8.19.2      The Coq Proof Assistant -- Core Binaries and Tools
coq-iris              4.2.0       A Higher-Order Concurrent Separation Logic Framewor
coq-iris-heap-lang    4.2.0       The canonical example language for Iris
coq-stdlib            8.19.2      The Coq Proof Assistant -- Standard Library
coq-stdpp             1.10.0      An extended "Standard Library" for Coq
coqide-server         8.19.2      The Coq Proof Assistant, XML protocol server
dune                  3.16.0      Fast, portable, and opinionated build system
host-arch-arm64       1           OCaml on AArch64 (64-bit)
host-system-other     1           OCaml on an unidentified system
ocaml                 5.2.0       The OCaml compiler (virtual package)
ocaml-base-compiler   5.2.0       Official release 5.2.0
ocaml-config          3           OCaml Switch Configuration
ocaml-options-vanilla 1           Ensure that OCaml is compiled with no special optio
ocamlfind             1.9.6       A library manager for OCaml
zarith                1.14        Implements arithmetic and logical operations over a

Ah, I see, I was trying to do iApply own_dfrac_update.


Bug: Remove deprecated/obsolete AWS Foundational Security Best Practices Benchmark Controls

Some AWS Foundational Benchmark Controls were removed, see https://docs.aws.amazon.com/securityhub/latest/userguide/doc-history.html
For example, https://hub.steampipe.io/mods/turbot/aws_compliance/controls/control.foundational_security_ec2_27?context=benchmark.foundational_security/benchmark.foundational_security_ec2 should be removed because it got removed from the officiel benchmark in 20. July 2020 (see EC2.27 is retired in benchmark history above) with the comment “Security Hub has retired EC2.27 - Running EC2 Instances should not use key pairs, a former control in the AWS Foundational Security Best Practices (FSBP) standard.”
It would make imho a lot of sense to remove the "retired" controls from the benchmark of the compliance mod as well.

@sfunkernw, Thanks for using Steampipe!
We appreciate your notifying us; we will include further checking our monthly update cycle.
Cheers! 👍


Version

Hi,
I've a project of dll library and a private nuget server.
My AssemblyInfo.cs contains this instructions:
[assembly: AssemblyVersion("4.1.*")] [assembly: AssemblyFileVersion("<IP_ADDRESS>")]
but when I deploy the package the version is force to 4.1. How I can to add the numbers of revision and build?
I know I can enter manually but i looking for autofill from build.
Thank you

I know what you mean.however,I haven't find a good solution to implement it recently.Maybe later.

Dear @lelelic ,this feature has been released in V2.0.1.


Why execute the function 'trackDepsOnRender'?

Hello, I've been learning your code lately, but I'm having some difficulties and I don't understand why the 'trackDepsOnRender' function is executed. I don't understand the comments of the code, and there doesn't seem to be a similar example of unit tests, can you give an example to explain why you do this, thanks ~

Hello,
Initially the reactive effect function is setup to track dependencies when rendering the component. Since the render call is moved into an async callback to delay the hydration, the dependencies will not be tracked.
In simple terms this means that the lazily hydrated component will have no reactivity when finally hydrated.
https://github.com/freddy38510/vue3-lazy-hydration/blob/5a04bb5a76b9b3988fa81cfab8d4c35dab252cb6/src/composables/useLazyHydration.ts#L73&L78
https://github.com/vuejs/core/blob/160d5df34ae35c282fa48226842631584402d9fe/packages/runtime-core/src/renderer.ts#L1361&L1369
The trackDepsOnRender function re-run the reactive effect function when the render function is finally called. This is a trick to restore reactivity to the lazily hydrated component.
You can see it live through the demo, cloning the repository and running the dev script. Try commenting out the trackDepsOnRender function call, you will see that the counter component will not be reactive once hydrated.


enhance: relax graphqlEndpoint check

Not sure whether I like this. I would rather prefer a more fine granular matching via a function
If we make graphqlEndpoint a function, this would be a breaking change because graphqlEndpoint is a property of YogaServerInstance.

If we change the === to .startsWIth that is also a breaking change...

If we change the === to .startsWIth that is also a breaking change...
This is a dfferent discussion. Changing YogaServerInstance.graphqlEndpoint is a breaking change in the API while the other one is related to the functionality.

I would rather have a breaking change in the API instead of one that changes the functionality.

I would rather have a breaking change in the API instead of one that changes the functionality.

If we change graphqlEndpoint to function, all typings relying on that property get broken. So this is definitely a breaking change.
If we change the behavior of the same property, this isn't more "breaking" than changing default content-type from application/graphql-response+json to application/json. This is debatable.
However as I already said in my previous comment, we can basically accept "path patterns" like /graphql* that wouldn't break both API and functionality. If someone experienced with RegExp wants to tackle this, they can feel free to go :D

Thanks for tackling this issue!
This PR will fix the issue for normal GraphQL request (#2132), but may not be enough for GraphiQL, I'm afraid.
For example:

Yoga is mounted on /graphql/:random (not /graphql)
graphqlEndpoint: '/graphql'

Then, GraphiQL now uses graphqlEndpoint to make request to the server, but /graphql is not routed. Therefore, 404 is responded.
Support for graphqlEndpoint: '/graphql/:random' may solve this GraphiQL issue, but it is weird to request /graphql/:random

We could simply allow functions that receive a Request object and set the graphqlEndpoint to "" if a function was provided. That would not break any existing users and allow full control.

This is not relevant anymore. Yoga now accepts URL patterns like /graphql/:path


Dashboard UI

Readability and hierarchy are off.

[x]  Increase shadow visibility either through reducing blur or decreasing transparency or could add faint gray outline to white cards. Card is currently not clearly defined from the background
[x]  Increase line spacing between concepts on resume card
[ ]  Make it to where "resume" card only shows 3 concepts. The top two being what the student just finished and the 3rd being what they are currently working on
[x]  Make it to where the user can click on a concept line within the "Resume" card and be directed to that specific concept
[x]  Have the concepts underline on hover
[x]  Have the Course name underline on hover

@tcp

Make it to where "resume" card only shows 3 concepts. The top two being what the student just finished and the 3rd being what they are currently working on

We now show lessons on resume cards not concepts. Should we change this behavior?

We now show lessons on resume cards not concepts. Should we change this behavior?

Yes.
And the display cases should be one of the following:
1 | 2 | 3 | 4
--------------
u | f | f | f
u | u | f | f
u | u | u | f

u: unfinished concept
f: finished concept

@tcp I got that point.
I was asking if we are now showing concepts instead of lessons on that resume card.

We now show lessons on resume cards not concepts. Should we change this behavior?
I was asking if we are now showing concepts instead of lessons on that resume card.

Yes, that's the change :)


Document the use of labels and selectors

Document the new functionality based on https://github.com/pachyderm/pachyderm/issues/3873

For deployments, this is being addressed by the helm chart and the helm chart values.yaml. For pipelines and repos, this is not an option and may be part of a future feature request hence closing this issue until there's a clear path to a feature.


Parsing errors

{"level":"fatal","ts":1620296288.6564505,"caller":"kminion/main.go:29","msg":"failed to parse config","error":"1 error(s) decoding:\n\n* 'kafka' expected a map, got 'slice'","stacktrace":"main.main\n\t/home/runner/work/kminion/kminion/main.go:29\nruntime.main\n\t/opt/hostedtoolcache/go/1.16.0/x64/src/runtime/proc.go:225"}
Hi, I have problems with using v2.0+ minion. I had no issue so far with version 1 :( any idea how to get more debug info while running ? I cannot find a problem with config file/ environment variables

@PythonDanny Can you paste what your config looks like? Especially the config under your kafka key. Please compare it to the reference config: https://github.com/cloudhut/kminion/blob/master/docs/reference-config.yaml#L19
I believe there's an issue with how your config looks like.

Hi, thanks for the reponse.
I i thought kafka key is wrong , however I cannot find a problem
I've tried brokers: ["test01-domain.com,test02-domain.com,test03-domain.com"] (with and without ports) aswell  - using kafka brokers+sasl
yaml got validated with yamllint and ansible-lint aswell - both say its valid yaml
tried aswell with out ports brokers: [test01-domain.com,test02-domain.com,test03-domain.com]
original config.yml
kafka:
brokers: [test01-domain.com:9092,test02-domain.com:9092,test03-domain.com:9092]
clientId: "kminion"
rackId: ""
tls:
enabled: false
caFilepath: ""
certFilepath: ""
keyFilepath: ""
passphrase: ""
insecureSkipTlsVerify: false
sasl:
enabled: true
username: "secretuser"
password: "secretpassword"
mechanism: "SCRAM-SHA-256"
gssapi:
authType: ""
keyTabPath: ""
kerberosConfigPath: ""
serviceName: ""
username: ""
password: ""
realm: ""
and getting  when try to run it
level":"fatal","ts":1621341844.2820017,"caller":"kminion/main.go:29","msg":"failed to parse config","error":"1 error(s) decoding:\n\n* 'kafka' expected a map, got 'slice'","stacktrace":"main.main\n\t/home/runner/work/kminion/kminion/main.go:29\nruntime.main\n\t/opt/hostedtoolcache/go/1.16.3/x64/src/runtime/proc.go:225"}

tried this aswell without success :(
kafka:
brokers:
- test01-domain.com:9092
- test01-domain.com:9092
- test01-domain.com:9092
{"level":"fatal","ts":1621342735.7698393,"caller":"kminion/main.go:29","msg":"failed to parse config","error":"1 error(s) decoding:\n\n* 'kafka' expected a map, got 'slice'","stacktrace":"main.main\n\t/home/runner/work/kminion/kminion/main.go:29\nruntime.main\n\t/opt/hostedtoolcache/go/1.16.3/x64/src/runtime/proc.go:225"}
and
this one with expected exception:
kafka:
brokers:
- test01-domain.com: 9092
- test01-domain.com: 9092
- test01-domain.com: 9092
with
{"level":"fatal","ts":1621342726.7393641,"caller":"kminion/main.go:29","msg":"failed to parse config","error":"3 error(s) decoding:\n\n* 'kafka.brokers[0]' expected type 'string', got unconvertible type 'map[string]interface {}', value: 'map[cpkafka01-test-blue.cz.infra:9092]'\n* 'kafka.brokers[1]' expected type 'string', got unconvertible type 'map[string]interface {}', value: 'map[cpkafka02-test-blue.cz.infra:9092]'\n* 'kafka.brokers[2]' expected type 'string', got unconvertible type 'map[string]interface {}', value: 'map[cpkafka03-test-blue.cz.infra:9092]'","stacktrace":"main.main\n\t/home/runner/work/kminion/kminion/main.go:29\nruntime.main\n\t/opt/hostedtoolcache/go/1.16.3/x64/src/runtime/proc.go:225"}
and I've tried aswell without use of yml and used env variables
export KAFKA_BROKERS="test01-domain.com:9092,test02-domain.com:9092,test03-domain.com:9092"
again with
{"level":"fatal","ts":1621342930.776594,"caller":"kminion/main.go:29","msg":"failed to parse config","error":"1 error(s) decoding:\n\n* 'kafka' expected a map, got 'slice'","stacktrace":"main.main\n\t/home/runner/work/kminion/kminion/main.go:29\nruntime.main\n\t/opt/hostedtoolcache/go/1.16.3/x64/src/runtime/proc.go:225"}

Can you please post your configuration with the proper formatting in github (using tripple backticks). Otherwise the indenting gets lost and therefore I can't check what's wrong anyways.

kafka:
  brokers: [test01-domain.com:9092,test02-domain.com:9092,test03-domain.com:9092]
  clientId: "kminion"
  rackId: ""
  tls:
    enabled: false
    caFilepath: ""
    certFilepath: ""
    keyFilepath: ""
    passphrase: ""
    insecureSkipTlsVerify: true
  sasl:
    enabled: true
    username: "secretadmin"
    password: "supersecretpswd"
    mechanism: "SCRAM-SHA-256"
    gssapi:
      authType: ""
      keyTabPath: ""
      kerberosConfigPath: ""
      serviceName: ""
      username: ""
      password: ""
      realm: ""

minion:
  consumerGroups:
    enabled: true
    scrapeMode: adminApi
    granularity: partition
    allowedGroups: []
    ignoredGroups: []
  topics:
    granularity: partition
    allowedTopics: []
    ignoredTopics: []
  logDirs:
    enabled: true

exporter:
  namespace: "kminion"
  host: ""
  port: 8090

logger:
  level: info

most recent try
filled SALS,brokers and change port from 8080 to 8090

Can you try to use strings for the broker addresses?
Like that:
brokers: ["test01-domain.com:9092","test02-domain.com:9092","test03-domain.com:9092"]

tried and didn't help :( I'm kinda confused , tried to destroy YAML and always it said incorrect YAML couldn't parse it - and once u put the correct one it changed to map vs slice error - cannot figure it out (the previous version worked fine, however, I need SASL support now )


Issue with archived file

Hi,
I want to use DeepPocket to make some predictions. For that, I think I need the checkpoint files of the models. I tried downloading the archived zip file in OneDrive but it seems like having an issue unzipping it. Every attempt to unzip the file results in errors indicating that the zip file is corrupted or damaged.
Could you please assist in resolving this issue?
Thanks

oh ok give me a few days i'll try to fix this

It should be fixed now, please check again

Yes, I can access those files now! thanks


SINGA-500 add onnx example models

Can this be merged?
Pls fix the conflicts and format the code.

Can this be merged?
Pls fix the conflicts and format the code.

cannot yet, after merge the gemm, I will continue to work on this PR.

you can mark it as a draft like #580

cannot convert an existing PR to draft :), https://github.com/isaacs/github/issues/1547
I will be careful next time.


fix can't show databases when creating a new user in external catalog

Proposed changes
Problem summary
Fix bug: A new user with grants to access external catalog can't show databases.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[x] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[x] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.6 seconds
load time: 631 seconds
storage size:<PHONE_NUMBER>3 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221220095500_clickbench_pr_65578.html


[Question] Is there a way to set the name of the report after the test completes?

hi again Cenfun,
I have a frame work that has multiple test types [regression,sanity,smoke] I want the name of the report to be prefixed with by one of the test types after the test completes i.e "regression report" , "sanity report" .
However, because the report name is set in the config. The config is called before the test completes . If I used an env variable to set the report name after the test completes then that will only be set for the next test and not the test that just completed.
reporter:
[list],
['monocart-reporter', {
name: process.env.TEST_TYPE + "report",
]
Any ideas

Using env variables should work if you set TEST_TYPE before test start.

set env TEST_TYPE -> start test -> load config -> test complete -> generate report -> set next env TEST_TYPE -> start next test ...

Also, you can try onData hook
onData: (reportData) => {
    // console.log('onData', reportData);
    reportData.name = process.env.TEST_TYPE + "report";
}

The onData function will be executed after report data generated (before onEnd).

Thanks Cenfun, the onData hook looks ideal but where should I call it in config file and should I leave the name as blank in :
reporter:
[list],
['monocart-reporter', {
name: ?
]

it doesn't seem to be working, I also have visitor: state: that is called before onEnd: , maybe I should onData: to top? Does this work in a specific version?

yes, please try latest version.

Thanks Cenfun, this worked but I have add a line to get  it to work properly:
// playwright.config.js
module.exports = {
reporter: [
['monocart-reporter', {
name: "whatever or empty",
outputFile: './monocart-report/index.html',
        onData: (reportData) => {
           dotenv.config({override:true});
           reportData.name = process.env.TEST_TYPE + "report";
        }
    }]
]

};


Re-add linux support

i used to be able to run this on linux but now it only supports macOS, what happened to linux support? can you try to add it back?

Linux support hasn't been removed, what error are you getting?

it gives me this error
Traceback (most recent call last):
File "./inferius.1", line 3, in
from utils.api import API
ModuleNotFoundError: No module named 'utils.api'
and according to the reade it says it requires a computer running macos

Can you re-clone the latest commit, and try again from within the Inferius directory?

it is still the same

You don't seem to be running Inferius correctly. I've tested on a Linux machine on my end, and it works fine. As for the bundlegen script, it is macOS only, and that won't be changing any time soon.


[gym] Add graphical node-base editor for pipeline design.

One option is to integrate piper.

Related to https://github.com/duburcqa/jiminy/issues/247


Add function_call to FakeListChatModel

This PR allows users to simulate function calls using the FakeListChatModel by passing in dictionary values as the responses.

@NarekA Hi , could you, please, resolve the merging issues and address the last comments (if needed)? After that, ping me and I push this PR for the review. Thanks!

Looks like this isn't being worked on anymore. I'll close for now, and if you resume work, feel free to reopen!


Follow option on pets

For solo dance parties, and cooler conga lines.

What?
Doubt this is even possible.
What?

This isn't possible and even if it was it would be against the rules.


[CGP-286] Convert newtype coercions into explicit wraps and unwraps

This adds support for newtypes by treating them as data constructors with a single constructor. We handle coercions by looking for coercions between a newtype and its definition. If we find such a wrap or unwrap, we handle it by either creating a trivial match or wrapping up the value.
It would be nice to also offer GHC's guarantee that newtypes are represented exactly as the underlying type, but I think we can view that as future optimization (I'll open a ticket).

https://iohk.myjetbrains.com/youtrack/issue/CGP-292

I'm mainly looking for feedback on whether there's a really good reason not to do it this way, otherwise I think it's straightforward.

Let's go with this for now.

I think, this is fine.


Todo list for kcp website and documentation

Todos

[ ] #19
[ ] Update readme for build and contribution instructions
[ ] Port css/js for the homepage to hugo (check feasibility)
[ ] Add CR examples

I think this issue is not relevant now. PTAL @sttts @clubanderson

Right, this predates the current website.


fix textual lagging

Stops textual from lagging as mentioned here.
Pull Request Checklist

[x] Documentation has been updated, or this change doesn't require that

This is a big improvement, thank you very much!


az cosmosdb check-name-exists fails with 500s

Describe the bug
Command Name
az cosmosdb check-name-exists
Errors:
request failed: Error occurred in request., RetryError: HTTPSConnectionPool(host='management.azure.com', port=443): Max retries exceeded with url: /providers/Microsoft.DocumentDB/databaseAccountNames/myinspire-staging?api-version=2015-04-08 (Caused by ResponseError('too many 500 error responses',))

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

az login
az cosmosdb check-name-exists --name {}

Expected Behavior
A true or false is returned without error
Environment Summary
Linux-4.9.125-linuxkit-x86_64-with
Python 3.6.4
Shell: bash

azure-cli 2.0.67
docker image: microsoft/azure-cli@latest

Additional Context
This started happening in our Azure DevOps pipelines today and appears to be persistent. As it has been happening for at least 7 hours.

I have the same issue.

Hi @gavinbarron thank you for reporting this issue. We are looking into it.

Also experiencing the issue with Python 2.7.5 and azure-cli (2.0.28)

Im having same issue.

Hi all, thank you for your patience. We have corrected the issue and check name calls should be working again.

This issue is happening in our GitLab-ci DevOps pipelines and in my local setup.
az cosmosdb check-name-exists --name ACCOUNTNAME
Response:
request failed: Error occurred in request., RetryError: HTTPSConnectionPool(host='management.azure.com', port=443): Max retries exceeded with url: /providers/Microsoft.DocumentDB/databaseAccountNames/ACCOUNTNAME?api-version=2019-08-01 (Caused by ResponseError('too many 500 error responses',))
I tried login with "az login" and service principal.
I noticed it while I was trying to launch my Terraform plan, this error ocurred and then I tried to debug it:
2020/06/02 11:37:09 [ERROR] <root>: eval: *terraform.EvalSequence, err: Error checking if CosmosDB Account "ACCOUNTNAME" already exists (Resource Group "RESOURCEGROUPNAME"): documentdb.DatabaseAccountsClient#CheckNameExists: Failure responding to request: StatusCode=500 -- Original Error: autorest/azure: error response cannot be parsed: "" error: EOF

Error: Error checking if CosmosDB Account "ACCOUNTNAME" already exists (Resource Group "RESOURCEGROUPNAME"): documentdb.DatabaseAccountsClient#CheckNameExists: Failure responding to request: StatusCode=500 -- Original Error: autorest/azure: error response cannot be parsed: "" error: EOF

  on main.tf line 40, in resource "azurerm_cosmosdb_account" "db":
  40: resource "azurerm_cosmosdb_account" "db" {

I am using version 2.12
provider "azurerm" {
  subscription_id = var.SUBSCRIPTION_ID
  tenant_id       = var.SERVICEPRINCIPAL_TENANT_ID
  client_id       = var.SERVICEPRINCIPAL_CLIENT_ID
  client_secret   = var.SERVICEPRINCIPAL_CLIENT_SECRET

  version = "= 2.12"
  features {}
}


MonsterBlocks on 12.327 and DnD5e 3.2.1 not working at all.

Foundry VTT: 12.327
DnD5e: 3.2.1
Monster Blocks: 3.4.0
I know this isn't supported (yet), but just testing what is and isn't working on v12 and Monster Blocks definitely isn't working (when selected, no NPC sheet at all anymore). So besides the ton of deprecation warnings, we got the following errors:

Just editing out line# 347 in MonsterBlock5e.js atleast shows the Monster Blocks NPC sheet again.
// this.getTraitChecklist(id, menu, system.traits.${id}, "damage-type", CONFIG.DND5E.damageResistanceTypes);
That 'fixes' the error, but leaves a ton of deprecation warnings and we're missing a ton of info with the '[object Promise]' bug #233.
Note: I'm not a programmer/developer, just a monkey with a keyboard.

@zeel01 do you have any timeline for working on this? I would be happy to help fundraise to compensate you for your time to get monster blocks updated.  I really appreciate your willingness to contribute though.
Unrelatedly, this issue appears to be the same as #233 so I'll close this one as a duplicate.


clarify intent label ("Add task")

activity_add_task_title ("Create") left this clarification up to the icon

A more extensive solution would be https://github.com/katrinleinweber/opentasks/commit/073c4dd9ba7a642e6eb6e8ecbdb1abb6c26be68e. Please let me know if that one should be in this PR instead of the above quick fix.

The "share as task" intent filter looks good. I'd prefer this one over the "quick fix. Thanks.

OK, here you are :-)

Thanks. Looks almost good, except for the French and Brazilian translations being empty.

Note to self: triple–check next time m-)
Just out of curiosity about Git(Hub) itself: Would it have been a problem for the PR if I had amended & force-pushed your suggested changes into the original commit?

I would expect that GitHub can handle the amended commit. I've never tried that though.

@katrinleinweber @dmfs pull requests are associated with a repository and a branch name.
You can push additional commits or do rebased or amended force pushes as long as the branch name stays the same.
Also see the following link: https://github.com/github/hub/issues/198

@mkroehnert Thanks for clarifying.


feat: load all plugins

Checklist

[x] npm test passes
[ ] tests and/or benchmarks are included
[ ] documentation is changed or added
[x] commit message follows commit guidelines

Affected core subsystem(s)

Description of change

Loading all plugins by egg-utils .
The plugin.d.ts will become to
// This file is created by egg-ts-helper
// Do not modify this file!!!!!!!!!

import 'egg';
import 'egg-onerror';
import 'egg-session';
import 'egg-i18n';
import 'egg-watcher';
import 'egg-multipart';
import 'egg-security';
import 'egg-development';
import 'egg-logrotator';
import 'egg-schedule';
import 'egg-static';
import 'egg-jsonp';
import 'egg-view';
import 'egg-router-plus';
import { EggPluginItem } from 'egg';
declare module 'egg' {
  interface EggPlugin {
    onerror?: EggPluginItem;
    session?: EggPluginItem;
    i18n?: EggPluginItem;
    watcher?: EggPluginItem;
    multipart?: EggPluginItem;
    security?: EggPluginItem;
    development?: EggPluginItem;
    logrotator?: EggPluginItem;
    schedule?: EggPluginItem;
    static?: EggPluginItem;
    jsonp?: EggPluginItem;
    view?: EggPluginItem;
    routerPlus?: EggPluginItem;
  }
}

Make it more intelliSense in writing plugin.ts

Codecov Report

Merging #32 into master will decrease coverage by 1.89%.
The diff coverage is 83.52%.

@@            Coverage Diff            @@
##           master      #32     +/-   ##
=========================================
- Coverage   97.16%   95.26%   -1.9%
=========================================
  Files          13       14      +1
  Lines         493      528     +35
  Branches       61       63      +2
=========================================
+ Hits          479      503     +24
- Misses          5       13      +8
- Partials        9       12      +3

Impacted Files
Coverage Δ

src/index.ts
97.19% <ø> (ø)
:arrow_up:

src/scripts/eggInfo.ts
100% <100%> (ø)

src/generators/plugin.ts
73.46% <67.64%> (-15.42%)
:arrow_down:

src/utils.ts
94.66% <93.33%> (-0.86%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc5ac29...b2d1428. Read the comment docs.


should improve gitsynch performance

The current performance is not good enough, it takes time to check and sync.
I guess we can improve its performance by:
git checkout #{branch} -b #{branch}
And use current branch with desired branch to compare if we need to update when they're different.
Currently, we use ref to check, I guess it's the cause of slowness.

make sure go add measurement to see how much performance is gained with the changes.

assigned to @phuonglm to see if the performance can be improved.

timer debug logger added, try this to check the timer:
$ LOG_LEVEL=debug LOG_PROGNAME="Extension::Manager|Location::Manager" vagrant status

move out of v0.6.0-a5 scope, will address this on beta releases.


Remove Latest.

https://cockroachlabs.atlassian.net/browse/DOC-2774

This change is

Add the JIRA in the description (it's a nit I receive from Lauren a lot) but otherwise LGTM!

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @stbof)

I usually do. Got distracted. Done.


Release/Revision Change_Requests.md

This issue was created to collect comments about the upcoming metrics release.
This thread is for comments about Change_Requests.md
GitHub location: https://github.com/chaoss/wg-evolution/blob/master/metrics/Change_Requests.md
See all release candidates: https://chaoss.community/metrics/

Name change revision - From "reviews to "change request"

The name change looks good to me 👍
Signed-Off-By: Armstrong<EMAIL_ADDRESS>

closing for release

This is a metric that should be reviewed. It is one of our most widely referenced metrics and we should make sure we are being consistent in our terminology within the metric (I see some terms in there that I have seen referenced in other ways in other metrics).

We decided to open new issues for revisiting old metrics.


Project still active?

There aren't updates, commits or activity in 6 months.
Is the project still active and/or mantained?

Yes, is there something that needs to be updated?

No: it works and I like the API very much.
There are many unmantained project out there and I wanted to be sure this is not the case before using it in my project.
Thank you!


Autocomplete for Alias in .bashrc

Is your feature request related to a problem? Please describe.
I have so many aliases that maybe I forget, or I do have typos when typing fast.
Describe the solution you'd like
It is nice to have autocompletion for the listed aliases in .bashrc
Additional context
I'm using windows with git-bash and listing all my setting and alias in .bashrc file.
For example, I have the alias 'pyenv_cr' for creating environment 'python311 -m venv env', it is nice if the intellisense appears by I type 'pyev...'
Thanks a lot for this opensource project.

Tagging some information here as this is something Fig supports:

https://fig.io/docs/reference/arg#parserdirectives
https://github.com/withfig/fig/issues/792


Fix F# sample

Now it'll compile and run

Sample compiles now but if I don't pass any arguments, nothing is printed. By design?
I'd also update ms.date to reflect the changes on the article.
Other than that, LGTM.

Actually, let me change it just so that it would work as-is without arguments


perf: lower pipeline run threshold to 1 epoch

lower the max allowed distance for live sync
this will be the last remaining gap that we close via block chain tree and is currently blocking and can lead to timed out CL requests.
syncing > 32 blocks via pipeline is more efficient

Does this mean we might insert blocks that get reorged to the db? How do we get them out on FCU? Do we also call unwind similarly on larger ranges?


Remove Service and Operation Objects

In order to completely remove service objects and operation objects from botocore a bunch of tests needed to be removed and updated. That is why the PR is so large. Here is a summary of what I did:

Remove operation.py and service.py and their corresponding tests
Remove the deprecated paginators and waiter and update their tests if the client version did not have a form of the test.
Remove some tutorials that I found that use the service/operation interface.
Remove the service specific unit test and converted them to protocol tests.
Convert all unit and integration tests to the client/model interface such that they pass.

This will not be the final PR however, there are a few points that I want to address:

There are a couple of integration that goes through the manual process of creating a presigned url for s3. This uses the old interface. I want to update these tests when we add the presigning class for clients. In the end, I decided to mark them as a skip because it is a lot of extra code to get a presign url and figured it is better off to wait till the presigning class as none of our features rely on an s3 presigner.

Remove the response parsing tests and convert any coverage drops to the protocol tests. In the pull request, I updated the response parsing tests only because if I completely remove it, the coverage drops. I was going to save this for a subsequent PR as it potentially could be a fair amount of extra tests.

Let me know what you think.
cc @jamesls @danielgtaylor

Coverage increased (+1.0%) to 95.63% when pulling a0e93ffa68291e0bad40c946b016cb9fa05df557 on kyleknap:client-only-removal into c22f6f4261f653248b7f171ef39adaec3161ad43 on boto:clients-only.

:shipit:  Looks good to me.  Jus had one question about the tutorial that uses clients.

Coverage increased (+1.0%) to 95.63% when pulling d4d6466e4f2d8633436829eea09949c705b3eeeb on kyleknap:client-only-removal into 0e17d7a46a9caf1ce2acf2a60672f21b83e13252 on boto:clients-only.

LGTM :ship:-it!


scf.mol.nao_nr() gives incorrect result after loading from fcidump

The function pyscf.tools.fcidump.to_scf doesn't properly set the molecule's number of orbitals.
import pyscf
import pyscf.tools

# Build molecule
mol = pyscf.gto.Mole()
mol.build(
    atom=[["H", (0, 0, 0)], ["H", (1.0, 0, 0)]],
    basis="sto-6g",
    symmetry="Dooh",
    verbose=0,
)

# Run SCF
scf = pyscf.scf.RHF(mol).run()

# nao and nao_nr() give same result
print(f"nao before: {scf.mol.nao}")
print(f"nao_nr() before: {scf.mol.nao_nr()}")
assert scf.mol.nao == scf.mol.nao_nr()

# Save to FCIDUMP and load it back
pyscf.tools.fcidump.from_scf(scf, "test.fcidump")
scf = pyscf.tools.fcidump.to_scf("test.fcidump")

# nao and nao_nr() give different results
print(f"nao after: {scf.mol.nao}")
print(f"nao_nr() after: {scf.mol.nao_nr()}")
assert scf.mol.nao == scf.mol.nao_nr()

nao before: 2
nao_nr() before: 2
Parsing test.fcidump
nao after: 2
nao_nr() after: 0
---------------------------------------------------------------------------
AssertionError                            Traceback (most recent call last)
Cell In[1], [line 28](vscode-notebook-cell:?execution_count=1&line=28)
     [26](vscode-notebook-cell:?execution_count=1&line=26) print(f"nao after: {scf.mol.nao}")
     [27](vscode-notebook-cell:?execution_count=1&line=27) print(f"nao_nr() after: {scf.mol.nao_nr()}")
---> [28](vscode-notebook-cell:?execution_count=1&line=28) assert scf.mol.nao == scf.mol.nao_nr()

AssertionError:

The mol.nao_nr method computes the number of basis functions based on the atoms, basis sets in the molecule. mol.nao is an attribute that allows overwritten. When mol is loaded from FCIDUMP , number of basis functions are read from the FCIDUMP file, but the geometry of the molecule is missing.
I tend to not change the output of nao_nr. Because it is supposed to be consistent with a bunch of other functions that produces GTO basis locations, such as ao_loc_nr, nao_cart, nao_2c (= 2*nao_nr()).

I see. I still find this behavior to be confusing, but I'm not sure if there's a good way to fix it. Perhaps it's just a matter of documenting more clearly the difference between nao_nr and nao. Feel free to close this issue if there's nothing to be done.


Update README.md

Thanks Omar!

My pleasure, that might be the smallest pull request possible though :)

@OmarElabd small but important!

Just like me (well 50% of that is definitely true ;-) )

:+1:


[WIP] Another try to fix FastlanePty

WIP!
Open3.popen2e doesn't set $?.exitstatus but return the statuscode, so we need work with that
Process.wait also doesn't return what we want in Windows, so we make sure that it is only run when Pty is available (which is not on Windows)
Finally we hack the test to pass as bot Process.wait and $?.exitstatus are not called on Windows because of above

Checklist

[ ] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[ ] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[ ] I've read the Contribution Guidelines
[ ] I've updated the documentation if necessary.

Motivation and Context

Description

          1 Warning

:warning:
Pull Request is Work in Progress

  Generated by :no_entry_sign: Danger

Reworked the code and force pushed - please note of the new PR description.
(Code now is much nicer as before - I'm happy that I tackled it again)

Whew... I am relieved ;)


Remodel run with correct Path causes a os error 3 for some reason

I tried to run a script to build a file, but every time I try to run it, it gives me an error. I tried multiple files, reinstalling Remodel and changing Paths. I am right now in need of help.

This is an error occurring inside your script. You appear to be calling the readDir function on a directory that does not exist. Remodel is finding your script and running it okay.

The issue is, that the directory actually is existing. Maybe I just have configured the file wrong. I am right now not really sure.

The paths provided to readDir are relative to your working directory, not the directory that the script is in. readDir("songs") when run from your user directory will look for that directory in your user directory.
This is not unique to Remodel; I recommend looking into how programs inherit working directories and how it impacts the code that you write.


Gradle task/output configuration

Steps to Reproduce

Run flutter run while an Android phone is connected.
The Flutter build tools call gradlew build.

Logs
> flutter run
Launching lib/main.dart on Pixel 2 in debug mode...
Initializing gradle...                                              0,7s
[...]
Running 'gradlew build'...
Running 'gradlew build'... Done                                    24,8s

> flutter analyze
Analyzing sudoku...
No issues found! (ran in 9.4s)

> flutter doctor -v
[√] Flutter (Channel stable, v1.5.4-hotfix.2, on Microsoft Windows [Version 10.0.17134.765], locale de-DE)
    • Flutter version 1.5.4-hotfix.2 at C:\Users\kiese\AppData\Local\flutter
    • Framework revision 7a4c33425d (5 weeks ago), 2019-04-29 11:05:24 -0700
    • Engine revision 52c7a1e849
    • Dart version 2.3.0 (build 2.3.0-dev.0.5 a1668566e5)

[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at C:\Users\kiese\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: C:\Users\kiese\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\183.5522156\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
    • All Android licenses accepted.

[√] Android Studio (version 3.4)
    • Android Studio at C:\Users\kiese\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\183.5522156
    • Flutter plugin version 36.0.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

[√] IntelliJ IDEA Ultimate Edition (version 2019.1)
    • IntelliJ at C:\Users\kiese\AppData\Local\JetBrains\Toolbox\apps\IDEA-U\ch-0\191.7479.19
    • Flutter plugin version 36.0.4
    • Dart plugin version 191.7479.14

[√] VS Code, 64-bit edition (version 1.34.0)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.0.2

[√] Connected device (1 available)
    • Pixel 2 • FA7A61A10729 • android-arm64 • Android 9 (API 28)

• No issues found!

Issues

Instead of calling gradlew build, Flutter should specify the Gradle :app module explicitly: gradlew :app:build.
The use of gradlew assembleDebug might be sufficient and would save some build time.
The APK output directory is hard-coded by Flutter. Instead the tools should be able to get the path dynamically, as that can change in different Gradle configurations.

Solution
I would recommend writing a custom Gradle Task flutterAssembleDebugApk that could then be accessed via gradlew :app:flutterAssembleDebugApk, and takes care of copying the generated APK to an appropriate folder in the flutter root dir. That task could depend on the assembleDebug task and read it's output path.

The first issue is especially annoying in build setups with high modularization of the android app.
When the app module is not specified, Gradle builds all modules, even those not referenced from the app module.

Closing due to inactivity.


Unify io.ReadDir usage (#7029)

Closes https://github.com/prometheus/prometheus/issues/7029

Please merge.


[WIP][Bug] init docker compose DATABASE env

Purpose of the pull request

Brief change log
Verify this pull request

Manually verified the change by testing locally.

I found that tools/bin/upgrade-schema.sh: line 22: /opt/dolphinscheduler/bin/env/dolphinscheduler_env.sh: No such file or directory , and we use sh ./tools/bin/upgrade-schema.sh to upgrade, see upgrade.

PTAL @liqingwang

I found that tools/bin/upgrade-schema.sh: line 22: /opt/dolphinscheduler/bin/env/dolphinscheduler_env.sh: No such file or directory , and we use sh ./tools/bin/upgrade-schema.sh to upgrade, see upgrade.

we should add
        <fileSet>
            <directory>${basedir}/../script/env</directory>
            <outputDirectory>conf</outputDirectory>
            <includes>
                <include>dolphinscheduler_env.sh</include>
            </includes>
            <fileMode>0755</fileMode>
            <directoryMode>0755</directoryMode>
        </fileSet>

in https://github.com/apache/dolphinscheduler/blob/515c3631480c33c3b12fd0188fe064d59ade7b94/dolphinscheduler-tools/src/main/assembly/dolphinscheduler-tools.xml#L40 to make it work

and I will test locally

should also change the doc to tell users how to change database type in docker and docker-compose

Codecov Report

Merging #10244 (fc2bc7b) into dev (c5c68a8) will increase coverage by 0.00%.
The diff coverage is n/a.

:exclamation: Current head fc2bc7b differs from pull request most recent head 95c4658. Consider uploading reports for the commit 95c4658 to get more accurate results

@@            Coverage Diff            @@
##                dev   #10244   +/-   ##
=========================================
  Coverage     40.95%   40.96%
- Complexity     4734     4735    +1
=========================================
  Files           854      854
  Lines         34565    34565
  Branches       3819     3819
=========================================
+ Hits          14156    14158    +2
+ Misses        19056    19051    -5
- Partials       1353     1356    +3

Impacted Files
Coverage Δ

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...e/dolphinscheduler/remote/NettyRemotingClient.java
53.52% <0.00%> (+1.40%)
:arrow_up:

...org/apache/dolphinscheduler/remote/utils/Host.java
40.00% <0.00%> (+2.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5c68a8...95c4658. Read the comment docs.

should also change the doc to tell users how to change database type in docker and docker-compose

I found the doc of docker, when user want to use exists PostgreSQL and ZooKeeper, they can use docker run directly. So I think it's no need to tell users how to change database type in .env. WDYT?

should also change the doc to tell users how to change database type in docker and docker-compose

I found the doc of docker, when user want to use exists PostgreSQL and ZooKeeper, they can use docker run directly. So I think it's no need to tell users how to change database type in .env. WDYT?

Makes sense


Migrate performance improvements from GCSFS

There has been a fair amount of use of gcsfs recently on large datasets.  This exposed several performance bottlenecks that were subsequently fixed.  Are some of these performance bottlenecks likely to occur on s3fs as well?  Are there performance improvements that we should take care to migrate over?

The major part, using directory prefixes, is already implemented on s3fs, so I am not aware of any performance problems that people are experiencing. There is no FUSE implementation in s3fs, but maybe there are people out there using other s3/fuse libraries?
An explicit benchmark of s3fs versus gcsfs for a specific use-case (say zarr storage) has not been done, but perhaps should be. That would depend on a number of variables, of course, such as which compute infrastructure was being used.


feat(keychain-azure-kv): complete request handler and endpoints

Description
As a developer, I want to complete the code to enable the endpoints
get-keychain-entry
set-keychain-entry
delete-keychain-entry (or maybe use set-keychain-entry with tags for deletion)
Also, write tests that use the API client instead of the plugin instance directly.
Acceptance Criteria

Update openapi.json at packages/cactus-plugin-keychain-azure-kv/src/main/json/openapi.json
Update the endpoints at packages/cactus-plugin-keychain-azure-kv/src/main/typescript/webservices
Update the remote adapter code at packages/cactus-plugin-keychain-azure-kv/src/main/typescript/plugin-keychain-azure-kv-remote-adapter.ts
Update the test code at packages/cactus-plugin-keychain-azure-kv/src/test/typescript/integration/plugin-keychain-azure-kv.test.ts

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo @petermetz @arnab-roy @petermetz  @TonyRowntree @travis-payne

cc: @ty-lazar @Jeff-Ushry @twiggins120 @awadhana @Leeyoungone

Working on it now

@petermetz  the cactus-plugin-keychain-azure-kv package doesn't exist - could it be an old name for a package that was since renamed?

@petermetz the cactus-plugin-keychain-azure-kv package doesn't exist - could it be an old name for a package that was since renamed?

believe this issue is dependent on #991

@ty-lazar the azure-kv plugin is still in PR, thus not yet visible in the code.


XML:writeFormatting is not working

I coded as follows
ocr_engine = CloudOCR(application_id='', password='')
jpg = open('pic16.JPG', 'rb')
file = {jpg.name: jpg}
result = ocr_engine.process_and_download(file, exportFormat='xml&xml:writeFormatting=true', language='English')
result
for format, content in result.items():
with open('converted.xml', 'wb') as output_file:
output_file.write(content.read())
output_file.close()
it threw the following Error:
HTTPError: 450 Client Error: Unknown format xmlwriteFormatting=true for url: http://cloud-eu.ocrsdk.com/processImage?exportFormat=xmlwriteFormatting%3Dtrue&language=English

Hi! It seems that the request to Cloud OCR SDK server is not formed correctly: the processing URL should look like "http://cloud-eu.ocrsdk.com/processImage?exportFormat=xml&xml:writeFormatting=true&language=English". Please try to pass xml:writeFormatting=true as a separate processing parameter or escape '&' symbol.

Hi,
I've tried with escaping '&' symbol, same error popped up. how to pass xml:writeFormatting as separate Parameter

Worked like a charm, thank you @helen-os .


[Bug] The BETWEEN operator reported an internal error.

Search before asking

[X] I searched in the issues and found nothing similar.

Version
version 1.3.2 (Build: aa0ff4a)
Describe the bug and provide the minimal reproduce step
DROP DATABASE root.db0
CREATE DATABASE root.db0

CREATE TIMESERIES root.db0.t1 WITH datatype=DOUBLE compressor=GZIP 'MAX_POINT_NUMBER'='8';
INSERT INTO root.db0(timestamp, t1) VALUES<PHONE_NUMBER>999, 0.1);
INSERT INTO root.db0(t1) VALUES (0.2);

# query 1 success
SELECT t1 FROM root.db0 WHERE t1 BETWEEN (0) AND (100.0)

# query 2 error
SELECT t1 FROM root.db0 WHERE 1 BETWEEN (t1) AND (100.0)

What did you expect to see?
Query 1 returned result set: 0.1 and 0.2
Query 2 returned result set: 0.1 and 0.2
What did you see instead?
Query 1 returned result set: 0.01 and 0.02
Query 2 reported an internal error: Msg: org.apache.iotdb.jdbc.IoTDBSQLException: 305: [INTERNAL_SERVER_ERROR(305)] Exception occurred: "SELECT t1 FROM root.db0 WHERE 1 BETWEEN (t1) AND (100.0)". executeStatement failed. java.lang.Long cannot be cast to java.lang.Double
Anything else?
Dear IoTDB team, I think this might be a bug. If this functionality is not supported, should relevant information be returned to inform the user of the error reason, instead of a 305 internal error?
Are you willing to submit a PR?

[X] I'm willing to submit a PR!

The error message here may not be intuitive enough, but the reason for the error has also been pointed out.
Inconsistent data types


Append items to annotation attribute array

What's changed?
Based on the feature request in #4157, I added a few tests to illustrate the test for the final behavior. However, while the tests themselves are relatively straightforward, I still got stuck on the configuration / desired behavior of the recipe for arrays. Specifically how we want to configure the recipe with this extended functionality.
The current functionality is limited, allowing a user to set or replace a value with a single option (addOnly) to prevent overwriting if a value already has been set. The planned enhancement introduces more flexibility for handling arrays, which cannot be captured in the current configuration option, effectively giving four options.

Set: Only set attribute value if no value is already provided.
Replace: Value will be replaced, disregarding its current contents.
Append: For arrays only, the user can append to the existing array.
Set append: There might be the wish for a “set-like” behavior, where items should only be added without duplication. For example, in the case of configuration options, and aren’t repeatedly appended, preventing redundant entries while ensuring necessary configurations are present.

I am unsure what would be best, some options:

In addition to the addOnly option, add a new binary option, specifically for arrays, allowing us to capture the four modes.
Alternatively, a single option can capture each mode.

// Example
public enum UPDATE_MODE {
    SET,
    REPLACE,
    ARRAY_APPEND,
    ARRAY_SET_APPEND
}

What's your motivation?
See #4157
Anything in particular you'd like reviewers to focus on?
Desired behavior and recipe options.
Anyone you would like to review specifically?

Checklist

[ ] I've added unit tests to cover both positive and negative cases
[ ] I've read and applied the recipe conventions and best practices
[ ] I've used the IntelliJ IDEA auto-formatter on affected files

I think you first proposed option is the way to go. You'd want to separately be able to specify whether you only want to add a property value when it's missing but also to specify whether you want to replace or append the new value(s)


Pruning of react-component fields that no longer work in redesign_v2

I would like to propose the removal of the following components in the dashboard that no longer seem to be propagated correctly in redesign_v2:
Checking / unchecking these checkboxes do not seem to visually change anything

Start Location and Destination are always empty here. Active Task Duration is also not populated:

Location and Destination are undefined here. Task progress is also always at 11%:

@koonpeng  @aaronchongth  @mxgrey ?

How was progress being measured previously? I'm not sure there's any meaningful way to measure progress, tbh. Best case scenario would be to base it off of time estimates, but then we could see progress slide backwards due to delays.

How was progress being measured previously? I'm not sure there's any meaningful way to measure progress, tbh. Best case scenario would be to base it off of time estimates, but then we could see progress slide backwards due to delays.

iirc, it was using a super naive approach of (current_time - start_time) / (est_end_time - start_time).

I think we have enough information now to go back to that definition of progress, at least until we can think of something more meaningful.

closing this to focus on merging https://github.com/open-rmf/rmf-web/pull/581


Client attempts to reconnect during shutdown

When shutting down the GELF Client, it immediately attempts to reconnect, which results in the following error message:

INFO org.graylog2.gelfclient.transport.GelfHttpTransport - Channel disconnected!

The same issue happens for the transport.stop() and transport.flushAndStopSynchronously() methods.
No ill effects occur, but this should be cleaned up. Reconnects should not be attempted after calling either of the stop methods.

I was reading through the class GelfHttpTransport.java, lineno:113 and am wondering , if method exceptionCaught is missing ctx.close() in it.
 @Override                             public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) throws Exception {                                 LOG.error("Exception caught", cause);                             }

JUST an FYI, to enable debugging pass this as a vm argument in INtellij
-Dorg.slf4j.simpleLogger.defaultLogLevel=debug

@danotorrey  In class , GelfHttpEncoder, making the HTTP header connection, to keep alive,  request.headers().set(HttpHeaderNames.CONNECTION, HttpHeaderValues.KEEP_ALIVE);
doesn't call the lifecycle method
public void channelInactive(ChannelHandlerContext ctx) throws Exception
I'm thinking this is not a bug. Please advice.


Lw12wifi

Description:
New platform added to support the Lagute LW-12 WiFi LED Controller. The controller is stateless and communicates via UDP. To handle the controller itself the python module python-lw12 is required and automatically installed by the REQUIREMENTS.
The platform supports 29 effects, brightness, rgb color and transition speed settings.
Example entry for configuration.yaml:
light:
  - platform: lw12wifi
    # Host name or IP of LW-12 LED stripe to control
    host: <IP_ADDRESS>
    # (Optional) Some firmware versions of the LW-12 controller listen
    # on different ports.
    port: 5000
    # (Optional) Friendly name
    name: LW-12 FC
    # (Optional) Effect to use as default (Default=None). Comment out to
    # set the value to None. For a full list of all 29 supported effects see:
    # https://github.com/jaypikay/python-lw12/blob/v0.9.2/lw12.py#L54
    effect: "Gradient Cyan"
    # (Optional) Transition speed for effects (Value: 0-255)
    transition: 10
    # (Optional) LED Brightness (Value: 0-255)
    brightness: 10
    # (Optional) RGB value array as standard color to set.
    # This option is is ignored when effect is set.
    rgb: [255, 255, 255]

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies have been added to the REQUIREMENTS variable.
[x] New dependencies are only imported inside functions that use them.
[x] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hi @jaypikay,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

To answer the question why we should have configuration options like effect, brightness or rgb? It was my understanding to use these options, as they are provided by homeassistant.const. Should I rename rgb to default_color instead? It is also the only way to define a default behaviour for the lights, because the controller itself is very unreliable. I can remove it, but on the other hand I do not see a disadvantage in this.

What I was trying to say is that I don't understand why we should provide these options at all. I mean if we don't know the state at startup, why should the configuration know for us what these brightness, color, ... values will be at startup?
This platform can't ask the device for states, ok. But then I would just assume the platform would initialize the light as off.

All settings but host are optional. Having the other values set are for a smoother user experience with these lights. Instead of defining a switch or similar, the light will turn on using the favored settings, when I click the power button. The RGB selection is not available when home assistant assumes the device as powered off.
I developed the platform using my experience with the hardware in mind and what would be nice to have. But I am happy to help by fixing my code.
Using service calls is possible and is at the moment the only way to set the transistion speed when using effects. I had hoped for a slider like brightness.

Sorry for bumping, but do I need to improve something to get it merged in a future release, or simply wait?

Thanks for the feedback and review. I will implement the changes.


error: failed to write /workspace/intro/hardware-check/Cargo.lock

esp@3b9a22d3b7a6:/workspace/intro/hardware-check$ cargo run
Updating crates.io index
error: failed to write /workspace/intro/hardware-check/Cargo.lock
Caused by:
failed to open: /workspace/intro/hardware-check/Cargo.lock
Caused by:
Permission denied (os error 13)

Hi! Would you mind giving more details? How are you trying to build the project? CI is building the example with the Docker image  with no issues

I will be closing the issue for inactivity, if the issue persists, feel free to reopen it


Office Hour news 10/11/23

Need to cut the video and upload then paste the link here.

Video link: https://bcgcatenax.sharepoint.com/sites/CommunitiesofPractises/_layouts/15/stream.aspx?id=%2Fsites%2FCommunitiesofPractises%2FShared Documents%2FCX-CoP DevSecOps%2FOffice_Hours_Regular_Recordings%2FCXDevSecOps Office Hours-20231110.mp4&referrer=StreamWebApp.Web&referrerScenario=AddressBarCopied.view

PR: https://github.com/catenax-ng/catenax-ng.github.io/pull/217


Limit the number of subsequent requests to the Maps API using the same payload, params and options

Fixes: https://github.com/CartoDB/cartodb.js/issues/1283.
@viddo I'd like to know your thoughts about this approach... CartoDB.js won't try to instantiate the exact same map more than three times with this change.
cc: @rochoa

Aight, I wait with reviewing it then, ok?

Yes please. I'll ping you here once I'm done.

@viddo ready again! With the latest change, request to instantiate map will only be triggered if something has changed (payload, params, options) and one of responses from the 3 previous requests is different.

looks legit, not much to say 👍


Release 4.1.0

Checklist

[x] I've given this PR a concise, self-descriptive, and meaningful title
[x] I've linked relevant issues in the PR body
[x] I've applied the relevant labels to this PR
[ ] I've added relevant tests for my contribution
[x] I've updated the documentation and/or added correct docstrings
[x] I've assigned a reviewer
[x] I've consulted ADS's internal developer documentation to ensure my contribution is in line with any relevant design decisions

Description

Updates version to 4.1.0 and creates a CHANGELOG entry for this version.
Linked issues

#643

I followed all the steps under Checklist for creating a new release in this wiki entry: https://github.com/axondeepseg/axondeepseg/wiki/How-to-create-a-new-release.
After this PR is merged, the steps under Steps on Github after the PR is merged will need to be completed to finalize the release.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.425%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1150

Relevant Lines:
1286

💛  - Coveralls

New release finalized with the GitHub step: https://github.com/axondeepseg/axondeepseg/releases/tag/v4.1.0
Thanks @hermancollin !


feat: Adding ewm_mean

What type of PR is this? (check all applicable)

[ ] 💾 Refactor
[x] ✨ Feature
[ ] 🐛 Bug Fix
[ ] 🔧 Optimization
[ ] 📝 Documentation
[ ] ✅ Test
[ ] 🐳 Other

Related issues

Related issue #
Closes #

Checklist

[ ] Code follows style guide (ruff)
[ ] Tests added
[ ] Documented the changes

If you have comments or can explain your changes, please do so below.
I didn't add anything for Arrow because I'm waiting to see the feedback for https://github.com/narwhals-dev/narwhals/pull/1290

The javascript is to add Latex:

Added one test for adjust.
I haven't added anything for Arrow because I'm not sure if we want to add it or not.

I added tests for the parameters.

Added the NarwhalsUnstableWarning 😇


Remove count pixels for the different memory state conditions

Task/Issue URL: https://app.asana.com/0/414730916066338/1201404025058112/f
Description
This PR removes the count pixels we fire when devices enter the different low memory states

During internal and F&F we added pixels to detect how often user devices would get into different memory criticality states
We added m_atp_ev_memory_[low/moderate/critical]_[c/d] pixels
where _c pixels would fire every time the device would enter that level of criticality
and _d pixels would be fired for that respective criticality level but on a first-in-day basis
And we consider these don't add a lot of value anymore

Steps to test this PR

install assembleID
execute adb shell am send-trim-memory com.duckduckgo.mobile.android:vpn <N> where:

N is 5, 10 or 15 to send MODERATE, LOW or CRITICAL level respectively

verify the m_atp_ev_memory_[low/moderate/critical]_c pixels don't fire

Current dependencies on/for this PR:

develop

PR #1564  (this PR)

This comment was auto-generated by Graphite and will continue to be automatically updated while this PR remains open.


Loki can't find alert rules configured at kubegems-real-alerting-rules

What did you do?
Access loki api /prometheus/api/v1/rules
What did you expect to see?
All rules.
What did you see instead? Under which circumstances?
Only rules in fake directory.
{
    "status": "success",
    "data": {
        "groups": [
            {
                "name": "kubegems-loki-recoring-rules",
                "file": "loki-alerting-rules.yaml",
                "rules": [
                    {
                        "name": "gems_loki_logs_count_last_1m",
                        "query": "sum by(namespace,pod,container)(count_over_time({stream=~\"stdout|stderr\"}[1m]))",
                        "labels": {},
                        "health": "ok",
                        "lastError": "",
                        "type": "recording",
                        "lastEvaluation": "2022-07-01T06:40:43.305586872Z",
                        "evaluationTime": 0.01630321
                    },
                    {
                        "name": "gems_loki_error_logs_count_last_1m",
                        "query": "sum by(namespace,pod,container)(count_over_time({stream=~\"stdout|stderr\"} |~ \"error\"[1m]))",
                        "labels": {},
                        "health": "ok",
                        "lastError": "",
                        "type": "recording",
                        "lastEvaluation": "2022-07-01T06:40:43.32190286Z",
                        "evaluationTime": 0.007911313
                    }
                ],
                "interval": 60,
                "lastEvaluation": "2022-07-01T06:40:43.305573645Z",
                "evaluationTime": 0.024247343
            }
        ]
    },
    "errorType": "",
    "error": ""
}

Environment

Kubegems version:

v1.21.0-rc.3

Loki version:

v2.5.0

Reason: https://github.com/grafana/loki/issues/6523#issuecomment-1172000328
Resolve: Because of loki's helm chart't limit as:
https://github.com/kubegems/kubegems/blob/94c95212fad97297e0e0abdae6d949c4e287f273/deploy/plugins/logging/templates/loki.yaml#L155-L169
I can't put alert rules in alerting_groups, Because this will be overwrite when logging plugin update.
Maybe I'll move recording rules in alerting_groups out to configmap, too


feat(cli): dbrp cli

Closes #19950
This adds DBRP management to the CLI.

Will take a deeper look later, but low-hanging fruit to start: can you add a line to the CHANGELOD.md?

Failed gotest seems(?) unrelated, I opened #20069 to track it


Allow greedy decoding with 0.0 temperature

Description
This PR adds the optional tag to the temperature field so that we can test presence in the server, and use greedy decoding if a user passes 0.0 temperature. This is to reduce confusion with the OpenAI api, which doesn't have a sampling/greedy flag and just uses zero temperature to enable greedy decoding.
As is, users will see an error about the temperature being too low if they pass in a temperature in the range (0, 0.05), but if they send in exactly 0, we instead default back to 1. This causes users to open bug reports about greedy mode returning random results. This PR also removes the low temperature check, since I think it would be confusing to disallow low temperatures but explicitly allow zero.
How Has This Been Tested?
I ran a server with vllm-tgis-adapter@main installed, and booted up one grpcui instance so that it would pick up the old protobuf definition. I then stopped the server, installed vllm-tgis-adapter@zero-temperature-support, booted the server again, and started a second grpcui instance so it would pick up the new protobuf definition. I verified that both:

Unset temperature and temperature==0 requests with the old protobuf defs returned random results
Unset temperature requests with the new protobuf defs returned random results
Temperatue==0 requests with the new protobuf defs returned greedy results

Merge criteria:

[ ] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

Codecov Report
Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.53%. Comparing base (2c80c72) to head (1b2f097).

Files with missing lines
Patch %
Lines

src/vllm_tgis_adapter/grpc/grpc_server.py
50.00%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
+ Coverage   62.46%   62.53%   +0.07%
==========================================
  Files          28       28
  Lines        1721     1719       -2
  Branches      211      210       -1
==========================================
  Hits         1075     1075
+ Misses        544      543       -1
+ Partials      102      101       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix pagination links for server-side searches

Should fix #2217

Why Voyager does not accept the merge???

This is working fine also.
Tried with a few thousand entries and tried switching filters, pages etc once in a while.

@akoSalman, it was waiting for one of our QA people (@emptynick in this case) to review it.

Merging despite TravisCI being unhappy.  The issue was fixed elsewhere and just not pulled into Op's branch


Trace viewer precision

https://github.com/rocket-connect/graphql-debugger/issues/4

Problem
The trace viewer doesn't accurately display the whole trace, see in the screenshot how we are only plotting spans in MS and not accounting for those spans that are of a lesser value.

Due to the fact, we dont account for spans that are of a smaller value than an MS, the width and offset of each trace in the viewer is skewed.

Trying out a few things, got it displaying the right units at least, depending on how big the durationNano value is

Figuring out the width and making the logic reusable will be the next steps

Played around with some BigInt maths, the existing logic appears overly complicated since it was trying to contextualise everything into ms whereas all we needed was a percentage of the total time span. Resolution was also being lost when casting to Number so that's been saved for the last step of the calculations

Finally, some proper precision in calculating the time;

I've placed the logic from the Span component into the unix-nano module so it's all contained in one place, and got some janky BigInt maths holding it all together. I suppose as we're targeting developers machines, browser support isn't top priority and most of this stuff is supported by recent versions of all major browsers so users shouldn't have too hard a time running it


Support multiple embeds in CreateMessage-like endpoints

Discord now allows multiple embeds to be sent with message endpoints. This is done by adding the
embeds field to requests. For the time being, the embed field will still function, however it
will be removed in the next API version.
On our end, the changes are pretty simple. Any embed function can still accept a single embed, and
it would now push to the embeds field. We will also need to add an embeds function that accepts
a list of embeds.
Docs PR: https://github.com/discord/discord-api-docs/pull/3105

The docs PR was just merged.


sources for generated code are not published

It makes it hard to navigate and explore API from IDE

Thanks for reporting that, definitely not intentional!


Map Jive style 'love' style to material 'favorite' icon

I've added some "Jive Style" button mapping to BBC sounds.
The mapping for the "love" jive style was missing.  I've mapped it to the appropriate material icon.

Thanks for this. I was literally about to start work on it when I saw this pull request!


Fix lotties for Nano X in new BLE pairing flow

📝 Description
The wrong lotties were used for the Nano X in BLE pairing flow. Replaced them with the correct one and adjusted styling
❓ Context

Impacted projects: ledger-live-mobile
Linked resource(s): FAT-536

✅ Checklist

[ ] ~Test coverage~: no UI testing on mobile yet
[x] Atomic delivery
[x] No breaking changes

📸 Demo

N/A, see slack channels
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

QA OK


WIP: fixes for the current pytest-asyncio

The changes here at least make tests/server run through; the ones in tests/template still hang indefinitely somewhere, after
the main test code times out. Possibly the hang is in the added code for event loop cleanup, like loop.shutdown_asyncgens and loop.shutdown_default_executor?
Maybe in the same go, the notebook template tests can be made more robust in some way...
Hopefully fixes #1187 once it is finished.
Contributor Checklist:

[ ] I have added or updated my entry in the creators.json file
[ ] I have added a changelog entry for my contribution
[ ] I have added/updated documentation for all user-facing changes
[ ] I have added/updated test cases
[ ] I have included the rebuilt production build of the client (only if changes were made to the GUI)

Reviewer Checklist:

[ ] /azp run libertem.libertem-data passed

/AzurePipelines help

/azp run libertem.libertem-data

As a reminder: this needs to be re-run with re-creating tox envs, as it has a crucial dependency change. Need to manually select "run pipeline" and enter refs/pull/1188/merge as branch/tag.

/azp run libertem.libertem-data

Tested successfully on Win 10 with current pytest and pytest-asyncio. Thx, merging!


No additonal properties

fix names of dictionaries and remove additionalProperties in Converter.get_source_schema() for Blackrock, Openephys and SpikeGLX

Will merge this at same time as PR #189


Support arm64 architectures

Describe the bug
Running the docker container from an arm based machine:
❯ docker run -it ghcr.io/ublue-os/bluefin:latest bash
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
bash-5.2#

pulls the image successfully and will mount/run my command, but it throws a warning about the architecture.
And it looks like there is only 1 x86 manifest:
❯ crane manifest ghcr.io/ublue-os/bluefin:latest | jq
{
  "schemaVersion": 2,
  "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
  "config": {
    "mediaType": "application/vnd.docker.container.image.v1+json",
    "size": 23813,
    "digest": "sha256:1169c58f27ec705ec18099dfd6105215ba33744cab7a43aff9eefbcfff992c57"
  },
  "layers": [
        ...
    ]
}

I'm also not seeing arm supported ISOs in the releases. And from reading the .github/workflow scripts, I'm not seeing builds against arm64 so my assumption is it's not supported.
What did you expect to happen?
It'd be great if bluefin supported arm architectures: this would open the door for alot of fun side projects on raspberries pies, edge IOT devices, etc.
Output of rpm-ostree status
n/a

Extra information or context
FYI, here is the mac I ran this from:
OS: macOS 13.3 22E252 arm64
CPU: Apple M2 Max (arm64)

Yeah we don't have arm builds yet: https://github.com/ublue-os/main/issues/365

We'll inherit this from main so closing here.


Removes LLVM custom recipe

It causes issues when installing Julia because it contains outdated patches. The custom recipe is not really needed anyway, as it only contained version updates.
This PR addresses https://github.com/PawseySC/pawsey-spack-config/issues/201 and it is currently being tested by rebuilding the stack on my own local directory.

@dipietrantonio which version of llvm did you compile with this recipe<EMAIL_ADDRESS>has used<EMAIL_ADDRESS>during our recent Joey deployment, other than that it's<EMAIL_ADDRESS>


Connection is not returned to the pool if connection.getTransactionIsolation() throws an exception

Hello Dear Maintainers!
On one of projects I'm using datasource-proxy (1.9) in connection with Spring Sleuth to collect trace spans. Installation includes Tomcat JDBC Connection Pool with Postgres JDBC driver underneath. Everything is configured using springboot (2.6.15) autoconfigurations except Tomcat JDBC Pool properties.
We have recently faced an issue with connection leak on the pool. After a couple of SocketException's been thrown all connections became "busy" and all subsequent attempt to acquire a connection from the pool resulted in timeouts (actually "couple" here is the configured max number of connections in the pool). During the research we found out that issue is reproduced when exception is thrown by Connection.getTransactionIsolation() during invocation from net.ttddyy.dsproxy.support.ProxyDataSource.getConnectionProxy() method.
It turns out that connection is gathered from the underlying pool but never returned back in such case.
Can you please comment if there is a bug here or might we be using the datasource-proxy in a wrong way?
Posting a slightly truncated stacktrace:
Caused by: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is org.postgresql.util.PSQLException: An I/O error occurred while sending to the backend.
at org.springframework.jdbc.datasource.DataSourceUtils.getConnection(DataSourceUtils.java:83)
at org.springframework.jdbc.core.JdbcTemplate.execute(JdbcTemplate.java:646)
at org.springframework.jdbc.core.JdbcTemplate.query(JdbcTemplate.java:713)
at org.springframework.jdbc.core.JdbcTemplate.query(JdbcTemplate.java:738)
at org.springframework.jdbc.core.JdbcTemplate.query(JdbcTemplate.java:794)
at org.springframework.jdbc.core.namedparam.NamedParameterJdbcTemplate.query(NamedParameterJdbcTemplate.java:209)
Caused by: org.postgresql.util.PSQLException: An I/O error occurred while sending to the backend.
at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:382)
at org.postgresql.jdbc.PgStatement.executeInternal(PgStatement.java:490)
at org.postgresql.jdbc.PgStatement.execute(PgStatement.java:408)
at org.postgresql.jdbc.PgStatement.executeWithFlags(PgStatement.java:329)
at org.postgresql.jdbc.PgStatement.executeCachedSql(PgStatement.java:315)
at org.postgresql.jdbc.PgStatement.executeWithFlags(PgStatement.java:291)
at org.postgresql.jdbc.PgConnection.execSQLQuery(PgConnection.java:476)
at org.postgresql.jdbc.PgConnection.execSQLQuery(PgConnection.java:469)
at org.postgresql.jdbc.PgConnection.getTransactionIsolation(PgConnection.java:913)
at jdk.internal.reflect.GeneratedMethodAccessor132.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at org.apache.tomcat.jdbc.pool.ProxyConnection.invoke(ProxyConnection.java:131)
at org.apache.tomcat.jdbc.pool.JdbcInterceptor.invoke(JdbcInterceptor.java:107)
at org.apache.tomcat.jdbc.pool.interceptor.AbstractCreateStatementInterceptor.invoke(AbstractCreateStatementInterceptor.java:78)
at org.apache.tomcat.jdbc.pool.JdbcInterceptor.invoke(JdbcInterceptor.java:107)
at org.apache.tomcat.jdbc.pool.DisposableConnectionFacade.invoke(DisposableConnectionFacade.java:81)
at jdk.proxy2/jdk.proxy2.$Proxy277.getTransactionIsolation(Unknown Source)
at net.ttddyy.dsproxy.support.ProxyDataSource.getConnectionProxy(ProxyDataSource.java:91)
at net.ttddyy.dsproxy.support.ProxyDataSource.getConnection(ProxyDataSource.java:73)
at org.springframework.jdbc.datasource.DelegatingDataSource.getConnection(DelegatingDataSource.java:99)
at org.springframework.jdbc.datasource.DataSourceUtils.fetchConnection(DataSourceUtils.java:159)
at org.springframework.jdbc.datasource.DataSourceUtils.doGetConnection(DataSourceUtils.java:117)
at org.springframework.jdbc.datasource.DataSourceUtils.getConnection(DataSourceUtils.java:80)
... 137 common frames omitted
Caused by: java.net.SocketException: Connection reset
at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:328)
at java.base/sun.nio.ch.NioSocketImpl.read(NioSocketImpl.java:355)
at java.base/sun.nio.ch.NioSocketImpl$1.read(NioSocketImpl.java:808)
at java.base/java.net.Socket$SocketInputStream.read(Socket.java:966)
at org.postgresql.core.VisibleBufferedInputStream.readMore(VisibleBufferedInputStream.java:161)
at org.postgresql.core.VisibleBufferedInputStream.ensureBytes(VisibleBufferedInputStream.java:128)
at org.postgresql.core.VisibleBufferedInputStream.ensureBytes(VisibleBufferedInputStream.java:113)
at org.postgresql.core.VisibleBufferedInputStream.read(VisibleBufferedInputStream.java:73)
at org.postgresql.core.PGStream.receiveChar(PGStream.java:453)
at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:2119)
at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:355)
... 160 common frames omitted

datasource-proxy implements the JDBC API. In general, it is the caller's responsibility to perform the necessary clean-up operations when an error is thrown. However, it is a bit tricky in this case.
TL;DR, I believe it is an issue with Tomcat JDBC connection pool, as it is not invalidating its managed connection when an error occurred.
From the caller's perspective (spring JdbcTemplate/DataSourceUtils#getConnection), the operation to get a connection ended up as CannotGetJdbcConnectionException/SQLException. The caller considers this is a failure to retrieve a connection. This failure does not trigger any cleanup operations on the JDBC API because it does not have a connection object.
At the datasource-proxy level, the ProxyDataSource#getConnection performs two operations - DataSource#getConnection and Connection#getTransactionIsolation. The former succeeded, but the latter failed, so the original ProxyDataSource#getConnection call fails with SQLException. At this level, since ProxyDataSource does not know the underlying datasource(in this case, tomcat jdbc pool), it does not(cannot) do anything. It considers simply the underlying datasource/connection operation has failed and propagates the error to the caller.
At the tomcat jdbc pool level, the initial DataSource#getConnection operation succeeds and returns a pooled connection. However, the subsequent Connection#getTransactionIsolation operation fails. When an operation on a managed connection fails, the connection pool should invalidate the connection. Based on your observations, it seems that the pool is not doing so, resulting in the behavior you have described.
From the perspective of the JDBC API, when there is a failure in either DataSource#getConnection or Connection#getTransactionIsolation, there is no clean-up action required. It is up to either the caller or the actual JDBC implementor (in this case, tomcat jdbc pool) to respond to the failure.
In my opinion, tomcat jdbc pool needs to react to failures from its managed connections and ensure the stability of the connection pool.


Option to manipulate the pom-file before calling the maven invoker

To be able to load snapshots and similar experimental tools, we will need to be able to tell repairnator to use non-maven-central repos. Currently, I am not aware of any way to load a custom pom-model into the invoker, and thus adding these repos into the pom before calling the maven-invoker seems to be the most simple way of doing this.
I put this into a separate PR since I will be adding some tests and messing with the configuration files, and it is a separate feature to NPEFixSafe, although at the moment necessary.

It seems that evosuite.org is currently timeouting, which seems to lead to the build erroring due to taking too long. The job exceeded the maximum time limit for jobs, and has been terminated. Is at the very end of the raw log.

Do we have a flaky test?
Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 13.035 sec <<< FAILURE! - in fr.inria.spirals.repairnator.realtime.TestRTScanner
testRepositoryWithoutCheckstyleIsInteresting(fr.inria.spirals.repairnator.realtime.TestRTScanner)  Time elapsed: 3.101 sec  <<< FAILURE!
java.lang.AssertionError
	at fr.inria.spirals.repairnator.realtime.TestRTScanner.testRepositoryWithoutCheckstyleIsInteresting(TestRTScanner.java:49)

Results :

Failed tests:
  TestRTScanner.testRepositoryWithoutCheckstyleIsInteresting:49

Tests run: 9, Failures: 1, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] repairnator-root ................................... SUCCESS [ 13.592 s]
[INFO] repairnator-core ................................... SUCCESS [ 15.071 s]
[INFO] repairnator-pipeline ............................... SUCCESS [19:18 min]
[INFO] repairnator-scanner ................................ SUCCESS [02:09 min]
[INFO] repairnator-dockerpool ............................. SUCCESS [  4.604 s]
[INFO] repairnator-checkbranches .......................... SUCCESS [  3.286 s]
[INFO] repairnator-realtime ............................... FAILURE [ 14.983 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 22:26 min
[INFO] Finished at: 2019-07-05T11:41:14Z
[INFO] Final Memory: 148M/970M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on project repairnator-realtime: There are test failures.
[ERROR]
[ERROR] Please refer to /home/travis/build/Spirals-Team/repairnator/repairnator/repairnator-realtime/target/surefire-reports for the individual test results.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :repairnator-realtime
travis_time:end:057e3316:start=1562325526369763698,finish=1562326875272432247,duration=1348902668549
The command "./.travis/travis-run.sh" exited with 1.

Done. Your build exited with 1.

I believe the failing test might be because our test is relying on a repository that was recently updated, and where they specifically mention that they updated their checkstyle version 3 days ago.
nosan/embedded-cassandra

This PR should now be done.

LGTM but CI is red. How to fix this?

The NPERepair test was failing, and I assume it's because I updated the version of maven-repair it is running. Updated the test accordingly now and if it doesn't work I'll revert the update (the version is only relevant for NPEFixSafe) and see if that works.

One of our tests for checkstyle is currently faulty due to the repository recently starting to use checkstyle. I've ignored the test for now (it was passing before) but if we want to keep a test we should find a new repo that has the same desirable traits as it used to have.
@monperrus It should be done now.

Thanks!


Include hemispheric averaging

Include new hemispheric averaging from NCO. Add figures for hemispheric time-series to global-time-series. To keep backwards-compatibility, we’ll have to check the dimensions: if regional dimension is not there, do what we were doing before. Keep glb directory structure?

@chengzhuzhang @golaz I have some design questions regarding this issue. Thanks!
I see if I add the following block to zppy/templates/ts.bash, I can easily process it in zppy/global_time_series.py by changing "atm_monthly_glb" to "atm_monthly_rgn". Of course, this only a debugging run and not useful as an end-feature.
{%- elif mapping_file == 'rgn' -%}
-o output \
--rgn_avg \
--area={{ area_nm }} \

Is that the general idea for ts? We want users to be able to specify a mapping file rgn in another ts subtask from the glb subtask? I'm unclear how the particular hemisphere (north/south) is specified simply with setting rgn.
As for the global_time_series task, I see quite a few references to glb subdirectories:
$ git grep -n glb zppy/templates/
zppy/templates/coupled_global.py:472:            "atmos": "{}/post/atm/glb/ts/monthly/{}yr/glb.xml".format(
zppy/templates/coupled_global.py:477:            else "{}/post/ocn/glb/ts/monthly/{}yr/glb.xml".format(
zppy/templates/coupled_global.py:482:            else "{}/post/ocn/glb/ts/monthly/{}yr/".format(case_dir, ts_num_years),
zppy/templates/coupled_global.py:485:            else "{}/post/ocn/glb/ts/monthly/{}yr/glb.xml".format(
zppy/templates/global_time_series.bash:45:cd ${case_dir}/post/atm/glb/ts/monthly/${ts_num_years}yr
zppy/templates/global_time_series.bash:46:cdscan -x glb.xml *.nc
zppy/templates/global_time_series.bash:57:    mkdir -p ${case_dir}/post/ocn/glb/ts/monthly/${ts_num_years}yr
zppy/templates/global_time_series.bash:69:    cd ${case_dir}/post/ocn/glb/ts/monthly/${ts_num_years}yr
zppy/templates/global_time_series.bash:70:    cdscan -x glb.xml *.nc
zppy/templates/global_time_series.bash:79:    cp ${moc_file} ../../../../../ocn/glb/ts/monthly/${ts_num_years}yr/
zppy/templates/ocean_month.py:18:path_out = "{}/post/ocn/glb/ts/monthly/{}yr".format(case_dir, ts_num_years)
zppy/templates/ocean_month.py:44:    out = "%s/mpaso.glb.%04d01-%04d12.nc" % (path_out, year1, year2)
zppy/templates/ts.bash:77:{%- elif mapping_file == 'glb' -%}
zppy/templates/ts.bash:79:--glb_avg \

Do we want to add logic to use a rgn subdirectory and/or a glb subdirectory depending on the plots chosen? I can set dependencies and other logic in zppy/global_time_series.py and zppy/templates/global_time_series.bash based on what is set for plot_names (https://github.com/E3SM-Project/zppy/blob/main/zppy/templates/default.ini#L274).

Hi @forsyth2, Aerosol working group has this feature listed as a second tier metrics, I'm a little unsure about the status, could you let me know what this PR cover? I think the goal is to have hemisperical average temperature time series as standard over view plots.

I think the goal is to have hemisperical average temperature time series as standard over view plots.

@chengzhuzhang Hmm I thought that was in fact accomplished by #306, but looking at https://web.lcrc.anl.gov/public/e3sm/zppy_test_resources/expected_complete_run/global_time_series/global_time_series_1850-1860_results/v2_historical_0201.pdf, it seems our expected results still just have global plots, rather than plots for each hemisphere... I will need to investigate this further.

Created #456

I think the goal is to have hemisperical average temperature time series as standard over view plots.

@chengzhuzhang #459 resolves this.


Implement own: URI subscheme, remove as: and my: support

Part of #11
https://github.com/ucan-wg/spec#42-own

This maybe weighs on #10 , which maybe needs to have its scope updated.

As of 0.10.0, own is removed https://github.com/ucan-wg/spec/pull/132

Continuing with this for 0.10.0, own has been removed from the spec, and the new ucan: fulfills a similar role. Additionally, the prf: scheme is no longer supported

Done in https://github.com/ucan-wg/rs-ucan/pull/131.
ucan:, ucan:, ucan:./, ucan:///* works, ucan:/// is disabled, as it requires more work.
My concern is the lack of tests to ensure that all cases of delegation work as expected in the specification.


Add make clean rule to remove *.o and target files

With how things are right now, we have to manually remove all the intermediate and target files before contributing.
Proposal: create a make "clean" rule to do this for us automatically. This should make the dev workflow just a tad nicer :D

@Typeaway14 ping pong (forgot to ping yet again :exit:)

@procub3r Wonderful Idea! You have the green. Make it happen and I'll assign points to you :)

This issue has been solved!


feat: add TreeView component

Demo: https://trendmicro-frontend.github.io/tonic-ui-demo/react/pr-785/components/tree-view
TODOs

[ ] Resolve animation delay when toggling nodes
[ ] Improve performance when rendering a significant number of nodes (e.g. 100 or more)

顯示層數時，會有lag的情況
https://github.com/trendmicro-frontend/tonic-ui/assets/24446505/e15e32f8-f9f1-4e25-957e-f2bb96ac76ed

收合selectable tree時，會有頓頓的情況
https://github.com/trendmicro-frontend/tonic-ui/assets/24446505/61a821cd-b3c5-4bdc-ab49-840533c480d2

顯示層數時，會有lag的情況
Screen.Recording.2023-08-10.at.11.25.43.AM.mov

Fixed in https://github.com/trendmicro-frontend/tonic-ui/pull/785/commits/25090954b8194416a8b818d5939ea81be1b1fe7e by setting appear to false to avoid the enter transition of the first mount
   <TransitionComponent
-   appear={true}
+   appear={false} // do not perform the enter transition when it first mounts
    in={isExpanded}
    role="group"
    unmountOnExit={true}

收合selectable tree時，會有頓頓的情況
Screen.Recording.2023-08-10.at.11.51.56.AM.mov

The delay in expanding the scrollable area of the tree will be acknowledged as a known issue for now.


Attributes on relationships

Hi,
I have some issues about manage many to many relationships.
I would like to have attributes between my two entities.
For example, I have a person performing in a movie. On the movie, I have a relation performers where I want to put everyone that have performed in the movie.
Movie
{
    "data": [
        {
            "id": "1fb4294f-6a9a-4747-9f66-40d864ae4cc6",
            "type": "movie",
            "attributes": {
                "title": "Matrix"
            },
            "relationships": {
                "performers": {
                    "data": []
                }
            }
        }
    ]
}

Person
{
    "data": {
        "id": "c1e52924-b92d-4962-b1b9-3e3d21276122",
        "type": "person",
        "attributes": {
            "first_name": "Keanu",
            "last_name": "Reeves"
        }
    }
}

What the specification suggest, I would do something like that
{
    "data": [
        {
            "id": "1fb4294f-6a9a-4747-9f66-40d864ae4cc6",
            "type": "movie",
            "attributes": {
                "title": "Matrix"
            },
            "relationships": {
                "performers": {
                    "data": [
                        {
                            "id": "c1e52924-b92d-4962-b1b9-3e3d21276122",
                            "type": "person"
                        }
                    ]
                }
            }
        }
    ]
}

But I also want to keep track of the roles of each person. Here, Keanu Reeves is the Neo.
I can't just add a new attribute. So I was thinking about create a new entity but as I don't have an entity in backend, I use the same ID.
{
    "data": [
        {
            "id": "1fb4294f-6a9a-4747-9f66-40d864ae4cc6",
            "type": "movie",
            "attributes": {
                "title": "Matrix"
            },
            "relationships": {
                "performers": {
                    "data": [
                        {
                            "id": "c1e52924-b92d-4962-b1b9-3e3d21276122",
                            "type": "performer",
                            "attributes": {
                                "roles": "Neo"
                            },
                            "relationships": {
                                "person": {
                                    "data": {
                                        "id": "c1e52924-b92d-4962-b1b9-3e3d21276122",
                                        "type": "person"
                                    }
                                }
                            }
                        }
                    ]
                }
            }
        }
    ]
}

I was wondering if there is a solution to add attributes on a relationships or if that means I need to rethink the backend.

why not:
...
                    "data": [
                        {
                            "id": "c1e52924-b92d-4962-b1b9-3e3d21276122",
                            "type": "person",
                            "role": "Neo"
                        }
                    ]
...

Hi @SimonMiaou! Support requests like this belong on our discussion forum. Would you please create a thread at http://discuss.jsonapi.org?
Thanks!

Oh, I didn't notice it. Thanks.
For those who find this issue and wondering the solution, here are the topic that helped me: http://discuss.jsonapi.org/t/metadata-about-relationships/86


Too Many Unique Cards Can Overflow The Deck Menu

When over 32 unique cards are selected in a deck, cards begin to go off screen with no scroll wheel option.

Will probably not happen with most decks, but if one wants to play another format it is bad. Working on it


successful compilation generates error report instead of info report

when compiling .erl source files, the Eshell outputs the compilation results as an "ERROR REPORT" regardless of whether or not there are errors/warnings. in the case of 0 errors and 0 warnings, the output should display in INFO REPORT instead
example output:
$ sudo yaws -i
...
=ERROR REPORT==== 1-Dec-2015::16:47:41 ===
Compiled "/usr/local/var/yaws/www/src/test.erl" [0 Errors - 0 Warnings]
...

Can you provide more details about what you're doing to cause your file to be compiled?

in my yaws.conf file, i've specified the following as suggested here:
src_dir = /usr/local/var/yaws/www/src
test.erl looks as such:
-module(test).
-export([thing/1]).
thing(X) -> X.

OK, thanks. I've reproduced the issue.

Fixed in c8f1918.