Sui doc content issue or request

If this is an issue with existing content, provide the URL or GitHub path to the topic. Otherwise, use New.
Describe the issue or request. Provide as much detail as possible. For issues, it is helpful to copy the specific section of the topic into the issue.
Thank you for taking the time to let us know about the issue or request. We triage all new issues and requests within 2 business days. We will follow up if we need additional information.

Hi @Duma1234 Could you provide additional info about your issue? Without any additional info this ticket will be closed.


Describe how you compare to vcluster?

How does your implementation compares with  https://github.com/loft-sh/vcluster
Are you aware of, or working with, this team?
Would be great to see a reference in the documentation in the sense of what else is around.

VC and vcluster are equal from user's perspective.  Each user gets a dedicated control plane. The key differences are:

vcluster uses per tenant cluster syncer approach but VC uses one syncer for many tenant control planes;
vcluster uses one namespace to combine all tenant resources in super cluster but VC uses 1:1 mapping between tenant namespace and super master namespace (the key architectural difference) to maximally retain API compatibility;
VC provides comprehensive consistency checks to handle various transient failures.
VC supports extension for syncing CRDs.
VC fully supports native k8s as virtualcluster. vcluster relies on a K3s distribution because the apiserver needs to be modified to proxy kubelet requests.
You may find more subtle implementation differences when looking at both projects in more details.
Last but not least, VC is a production grade project which has been used in cloud serverless production for quite a while, we have done many optimizations and feature enhancements to satisfy various production requirements.
You can check our ICDCS paper for more if you are interested.
https://github.com/kubernetes-sigs/multi-tenancy/blob/master/incubator/virtualcluster/doc/vc-icdcs.pdf

We will discuss with Loft people to seek collaboration.

Thanks @Fei-Guo  for your detail summary , while checking with the differences of two project .
Looks like both of them has syncer per tenant , according to https://www.vcluster.com/docs/getting-started/deployment , kubectl tab , there's syncer container each statefulset
I think most differences coming from
No. 2:

vcluster uses one namespace to combine all tenant resources in super cluster but VC uses 1:1 mapping between tenant namespace and super master namespace (the key architectural difference) to maximally retain API compatibility;

vcluster deal resources inside one ns , comparing to , VC need handle cluster-wide resources/RBAC .
No. 5

VC fully supports native k8s as virtualcluster. vcluster relies on a K3s distribution because the apiserver needs to be modified to proxy kubelet requests.

Besides , from the feature aspect , looks like VC is more mature . vcluster is still a baby  :-)

I think this is settled. Closing for now.
Feel free to copy the answer somewhere in a FAQ in case this topic comes up again.
Thank you!


luci-app-package-manager: Swap ternary outputs

follow-up for 9a5a5ec5784848a60e3c10895d762d3a69b3d13e
Signed-off-by: Paul Donald<EMAIL_ADDRESS>luci-app-filemanager: fixed negative time zone parsing

[ ] This PR is not from my main or master branch :poop:, but a separate branch :white_check_mark:
[ ] Each commit has a valid :black_nib: Signed-off-by<EMAIL_ADDRESS>row (via git commit --signoff)
[ ] Each commit and PR title has a valid :memo: <package name>: title first line subject for packages
[ ] Incremented :up: any PKG_VERSION in the Makefile
[ ] Tested on: (architecture, openwrt version, browser) :white_check_mark:
[ ] ( Preferred ) Mention: @ the original code author for feedback
[ ] ( Preferred ) Screenshot or mp4 of changes:
[ ] ( Optional ) Closes: e.g. openwrt/luci#issue-number
[ ] ( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
[ ] Description: (describe the changes proposed in this PR)

Invalid.
You are including here changes from @systemcrash that have already been committed to the repo.
The whole commit is in his name, although your main content is quite something different


firebase test lab (reopening)

this was closed because stale
https://github.com/fzyzcjy/flutter_convenient_test/issues/262
idea still shows promise?

My thoughts are mentioned before :) Feel free to PR!


OSA - Remove FQDN parameters and update ensure_osa_aad flow

This checklist is used to make sure that common guidelines for a pull request are followed.

[X] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[X] I adhere to the Command Guidelines.

CC @jim-minter @mjudeikis @amanohar

@tjprescott can you give another look please ? Thanks


VTimeZone DAYLIGHT and STANDARD collections

VTimeZone.FromSystemTimeZone method now generates DAYLIGHT or STANDARD collections

New to github.  I didn't realize this pull request would include ALL my commits.

Hi. This looks interesting - it adds support for adding the vtimezone data to the ical feed, is that correct? Is there a reason it's not been reviewed or accepted?

Correct.
I didn't follow some of the guidelines of making a proper pull request...  so I'm assuming it's that.

I haven’t had the time or energy is all.

Ok, whew!  At least I'm not being ignored. ;)

Any news on this one, or anything I can do to help out? This is a blocker for us being able to upgrade from DDay.iCal...

I’ll have a look at it in the next few days. I have some major breaking changes I’m making right now. (I.e., v4 is on the way.)

I love this change. I'm sorry I didn't get to it sooner. It's implemented exactly how I would have done it (using the NodaTime databases), and even the design and coding style is similar.
I'm not going to merge this PR. I'm going to lift its changes into the version in net-core, whose major version will be bumped to 4 this week. v4 contains many more bugfixes ( #320, #330, #331, #332, #318 ), and thematically is almost entirely time-focused, so this fits with that theme very nicely.
At this point, I have to stop supporting v2.

Is it possible to merge this pull request into v2 as well? Lots of people would be happy to have this functionality in current version of Ical.Net for existing projects that can't use net-core.
Thanks you in advance.

net-core targets NetStandard 1.3, which means applications .NET 4.6+ can use it.
Your applications are < 4.6?

Awesome! Glad you like it.  I look forward to contributing more! -Cheers

I lifted these changes into net-core, which works with NetStandard 1.3+ (which is .NET 4.6+). They're available in nuget version 4.0.0: https://www.nuget.org/packages/Ical.Net/4.0.0

@rianjs Your applications are < 4.6?

Yes, we have a legacy application that targets .NET 4.0. I would appreciate if you could incorporate this change as is into the final version of Ical.Net v2/v3 nuget package even without future support.
Thanks!

I suppose. v2 really is deprecated, though.

OK, it's 2.3.5 on nuget.

Just wanted to chime in and say thank you to everyone who worked on this. We were injecting tzdb timezone identifiers into our iCal feeds which was fine on everything we tested (Google Calendar, iCalendar) with but Outlook, which seems to serialize out using Windows system TZ names. I pull in this change and had us fixed up with real TZ info in no time.
We did try using the 2.3.5 for minimal friction, but it seems to have a hard dependency on NodaTime 1.x (and we are using 2.x). I got errors when trying it related to how they rearranged the SystemClock API in 2.x. The jump from .NET 4.5 to 4.6+ was an easy one though in our case.

We did try using the 2.3.5 for minimal friction, but it seems to have a hard dependency on NodaTime 1.x (and we are using 2.x). I got errors when trying it related to how they rearranged the SystemClock API in 2.x. The jump from .NET 4.5 to 4.6+ was an easy one though in our case.

There are a few differences between NodaTime v1 and v2, not the least of which are different data sources behind the scenes. I actually had to tweak the unit test assertions for the net-core version because they were slightly different for some relatively obscure corner cases/time zones.


Stitching Tree Cookie Samples

Hi!
I am attempting to use this package to stitch together tree cookie image samples generated by a HQ raspberry pi camera. For each cookie, we have ~600 images.
On a "zoomed out" sample (15 images for the entire cookie), we are able to get pretty decent results using this package, but when we tried on our full dataset, it is unable to align our images. I have tried using a variety of values in the downsizing parameter, but am not sure if there is any other parameters to tune/ways to help improve performance.
Here is a zip of a few rows of our images (didn't include them all bc the file sizes are massive!)
Any help/guidance would be very appreciated!
from stitch2d import StructuredMosaic, create_mosaic
import os

mosaic = create_mosaic(
    tile_path,
    dim=16,                  # number of tiles in primary axis
    origin="upper left",     # position of first tile
    direction="horizontal",  # primary axis (i.e., the direction to traverse first)
    pattern="raster"          # snake or raster
  )

mosaic.downsample(0.9)
mosaic.align()
mosaic.reset_tiles()
mosaic.save_params()

mosaic.smooth_seams()
mosaic.save("mosaic.jpg")

Update:  We found that the overlap between images was not sufficient. We have yet to try on a full cookie because it takes a while to get all the photos, but on a sample of 3 rows we have very promising results!


Update all variants of *ResourceTest to extend EntityResourceTest

Extending EntityResourceTest reduces a load of duplication across different data entities in Test classes
Refer
https://github.com/open-metadata/OpenMetadata/blob/main/catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/EntityResourceTest.java
cc: @sureshms

No longer needed


Improve accessibility

The tags and their contents should be accessible.

[x] Investigate whether current state is or isn’t accessible for assistive tech and keyboard navigation. Does the button/content-pair makes sense? Should taggd provide additional descriptions?
[x] Investigate what and how issues can be improved. Changes in DOM hierarchy, tags, or by adding ARIA attributes.
[ ] Apply the changes ;)

Changes:

[ ] Wrap image in figcaption tag
[ ] Wrap buttons in figcaption tag, and set size on figcaption to prevent invisible element overlap
[ ] Wrap tooltips in figure-tag.
[ ] Add focus or active event to a button to enable keyboard navigation

@timseverien You might consider using the HTML5 figure tag along with figcaption for accessibility. This would probably require someone to wrap their image in a figure tag (or the library could do it) but for each tag, the library could create a corresponding nested figure object (styled to match the current buttons) with a hidden figcaption. This would be accessible, as the content would be available for users with screen readers; it would also be more semantic.
The button/content pair does not currently work with keyboards. The buttons are tabbable, but the content will not be shown.

Thank you so much @jedd-ahyoung. I’ve added criteria based on your comment. Could you please review them?

Looks good, but I think you've reversed figure and figcaption. The figure tag would wrap an image or an area of content, while the figcaption would actually contain the tooltip text, like so (I've added inline styles to make this more clear):

My tooltip here

My second tooltip here

Based on this, you could actually style the nested figures to have width and heights, so that they could "frame" areas of sorts (like an image map, or like how you can frame faces of people in photos on facebook). Hope that made it more clear.

Clearly I was just testing your alertness... lol :D
Should be fixed now!


Uploading box image doesn't work

I tried to upload a picture of my sensebox but saving it doesn't work.
What I did: insert API key on the Manage tab, click Edit, switch to Information tab, select a file, switch back to Manage tab and click Save.
What happened: The default image on the information tab disappeared, being replaced with http://opensensemap.org/userimages/57062bcb45fd40c81974667e.jpeg. But requesting that file only returns a 404 error, i.e. I guess the uploading process doesn't work properly.
System used: Windows 7 running latest Firefox 45.0.2. Using the latest Chrome 50 didn't work either.

Sorry it is broken on the website right now, will be fixed later today, images are saved in the wrong place... I will move it to the right place

Should be working now


Unit testing Image Based Gadgets

Unit Testing for Image based gadgets.
fixes: #3195
This PR introduces new changes in which unit-testing capability for image based gadgets are added which leverages newly added gadgetrunner which is a wrapper on top of golang api (simple operator used) which can generate event before and in between the gadget running process and captured events can be validated against the expected output using the pre existing matching function in utilstest package and runner being used for event generation.
How to use
To try out the newly added unit test for image based gadget you can use following  cmd: go test -exec 'sudo -E' -v
Inside any unit directory that is present in the test directory for some gadgets, Below is an example.
mastersans@sanskar-vivobook:~/inspektor-gadget/gadgets/top_file/test/unit$ go test -exec 'sudo -E' -v

more unit test for different other gadgets will be added in future. Currently added are:

Trace_Open
Trace_Tcp
Top_File
Snapshot_Process

Works needs to be done on PR:
Older TODO:

[x] Fix problems while running Parallel test.
[x] Improve gadgetapi to support running of different gadgets
[x] Work on respective Makefile and Yaml file.
[x] Port different buildin gadgets unittest to image based once
[ ] Documentation.

Testing done
Testing is done locally with same procedure as mentioned before and for CI respective Makefile target and Workflow is added and tested on Fork.

Hi! I know updating the documentation is still in your TODO, but could you please update the explanations in the PR description?

The PR description says "unit testing" but the PR contains both unit tests and integration tests
Before running the command "go test -exec 'sudo -E' -v":

cd gadgets/snapshot_process/test/unit
Build the gadget: which command did you use? I got the error "getting signing information" and I didn't see if I can pass parameters like "--verify-image"
Alternatively, did you use export GADGET_REPOSITORY=ghcr.io/inspektor-gadget/gadget/snapshot_process GADGET_TAG=latest? I still couldn't pass the signature error.

About the import utilstest "github.com/inspektor-gadget/inspektor-gadget/internal/test": is it planned to move it outside of internal? Can it be used for external gadgets? Could you add "update github.com/inspektor-gadget/gadget-template" in your TODO?

Hi @alban as image verification is by default set to true, using the gadgetrunner  will check for verification in contrary to that if you want to turn off the image verification you can set operator.oci.verify-image: false in the parameter pass in gadgetrunner but that logs a warning regarding the disabled verification, Yes i checked the image verification part you shared locally, It seems to pass for me so really unsure how to handle it   ; )
regarding other comments I'll get it done ASAP:

I think this should be a good start for the Makefile and Workflow. Also will fix commit history soon.

@mastersans This PR breaks make test-gadgets using the Makefile from the top-level directory:
$ make test-gadgets
echo Building ig-linux-amd64
Building ig-linux-amd64
...
sudo cp ig /usr/local/bin/ig
make -C gadgets/ test
make[1]: Entering directory '/home/alban/go/src/github.com/inspektor-gadget/inspektor-gadget/gadgets'
make[1]: *** No rule to make target 'test'.  Stop.
make[1]: Leaving directory '/home/alban/go/src/github.com/inspektor-gadget/inspektor-gadget/gadgets'
make: *** [Makefile:385: test-gadgets] Error 2

Could you fix it? The test-gadgets target could be replaced by two targets test-unit-gadgets and test-integration-gadgets.

Hi @alban  I'll get the appropiate changes to done to https://github.com/inspektor-gadget/inspektor-gadget/pull/3631 to get it fixed :+1:


Cannot execute Kubeflow Pipeline in secured OpenShift environment

Describe the issue
After having secured our Kubeflow cluster with OpenShift OAuth, Elyra seems to have issues executing a pipeline in this cluster (in-cluster, from within a Kubeflow notebook server). Executing fails with this issue (see detailed logs further below):
ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self signed certificate in certificate chain (_ssl.c:1131)

I'm using KUBERNETES_SERVICE_ACCOUNT_TOKEN and am not sure whether this works correctly given our OpenShift OAuth setup. Also, note that using the Kubeflow Pipelines SDK, everything works as expected:
client = kfp.Client()
...
client.create_run_from_pipeline_func(
    my_pipeline,
    namespace='user-example-com'
)

...successfully creates a pipeline run.
To Reproduce
Steps to reproduce the behavior:

Setup OAuth with Kubeflow in OpenShift
Start a new notebook server featuring Elyra
Try to run a pipeline against the Kubeflow cluster

Screenshots or log output

Log Output

Traceback (most recent call last):
  File "/opt/conda/lib/python3.8/site-packages/urllib3/connectionpool.py", line 703, in urlopen
    httplib_response = self._make_request(
  File "/opt/conda/lib/python3.8/site-packages/urllib3/connectionpool.py", line 386, in _make_request
    self._validate_conn(conn)
  File "/opt/conda/lib/python3.8/site-packages/urllib3/connectionpool.py", line 1040, in _validate_conn
    conn.connect()
  File "/opt/conda/lib/python3.8/site-packages/urllib3/connection.py", line 414, in connect
    self.sock = ssl_wrap_socket(
  File "/opt/conda/lib/python3.8/site-packages/urllib3/util/ssl_.py", line 449, in ssl_wrap_socket
    ssl_sock = _ssl_wrap_socket_impl(
  File "/opt/conda/lib/python3.8/site-packages/urllib3/util/ssl_.py", line 493, in _ssl_wrap_socket_impl
    return ssl_context.wrap_socket(sock, server_hostname=server_hostname)
  File "/opt/conda/lib/python3.8/ssl.py", line 500, in wrap_socket
    return self.sslsocket_class._create(
  File "/opt/conda/lib/python3.8/ssl.py", line 1040, in _create
    self.do_handshake()
  File "/opt/conda/lib/python3.8/ssl.py", line 1309, in do_handshake
    self._sslobj.do_handshake()
ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self signed certificate in certificate chain (_ssl.c:1131)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/opt/conda/lib/python3.8/site-packages/elyra/pipeline/kfp/processor_kfp.py", line 158, in process
client.list_experiments(namespace=user_namespace, page_size=1)
File "/opt/conda/lib/python3.8/site-packages/kfp/_client.py", line 533, in list_experiments
response = self._experiment_api.list_experiment(
File "/opt/conda/lib/python3.8/site-packages/kfp_server_api/api/experiment_service_api.py", line 567, in list_experiment
return self.list_experiment_with_http_info(**kwargs)  # noqa: E501
File "/opt/conda/lib/python3.8/site-packages/kfp_server_api/api/experiment_service_api.py", line 668, in list_experiment_with_http_info
return self.api_client.call_api(
File "/opt/conda/lib/python3.8/site-packages/kfp_server_api/api_client.py", line 364, in call_api
return self.__call_api(resource_path, method,
File "/opt/conda/lib/python3.8/site-packages/kfp_server_api/api_client.py", line 181, in __call_api
response_data = self.request(
File "/opt/conda/lib/python3.8/site-packages/kfp_server_api/api_client.py", line 389, in request
return self.rest_client.GET(url,
File "/opt/conda/lib/python3.8/site-packages/kfp_server_api/rest.py", line 230, in GET
return self.request("GET", url,
File "/opt/conda/lib/python3.8/site-packages/kfp_server_api/rest.py", line 208, in request
r = self.pool_manager.request(method, url,
File "/opt/conda/lib/python3.8/site-packages/urllib3/request.py", line 74, in request
return self.request_encode_url(
File "/opt/conda/lib/python3.8/site-packages/urllib3/request.py", line 96, in request_encode_url
return self.urlopen(method, url, **extra_kw)
File "/opt/conda/lib/python3.8/site-packages/urllib3/poolmanager.py", line 376, in urlopen
response = conn.urlopen(method, u.request_uri, **kw)
File "/opt/conda/lib/python3.8/site-packages/urllib3/connectionpool.py", line 813, in urlopen
return self.urlopen(
File "/opt/conda/lib/python3.8/site-packages/urllib3/connectionpool.py", line 813, in urlopen
return self.urlopen(
File "/opt/conda/lib/python3.8/site-packages/urllib3/connectionpool.py", line 813, in urlopen
return self.urlopen(
File "/opt/conda/lib/python3.8/site-packages/urllib3/connectionpool.py", line 785, in urlopen
retries = retries.increment(
File "/opt/conda/lib/python3.8/site-packages/urllib3/util/retry.py", line 592, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='kubeflow.apps.edb-p1306.cecc.ihost.com', port=443): Max retries exceeded with url: /pipeline/apis/v1beta1/experiments?page_token=&page_size=1&sort_by=&resource_reference_key.type=NAMESPACE&resource_reference_key.id=user-example-com (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self signed certificate in certificate chain (_ssl.c:1131)')))
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/opt/conda/lib/python3.8/site-packages/tornado/web.py", line 1704, in _execute
result = await result
File "/opt/conda/lib/python3.8/site-packages/elyra/pipeline/handlers.py", line 133, in post
response = await PipelineProcessorManager.instance().process(pipeline)
File "/opt/conda/lib/python3.8/site-packages/elyra/pipeline/processor.py", line 143, in process
res = await asyncio.get_event_loop().run_in_executor(None, processor.process, pipeline)
File "/opt/conda/lib/python3.8/asyncio/futures.py", line 260, in await
yield self  # This tells Task to wait for completion.
File "/opt/conda/lib/python3.8/asyncio/tasks.py", line 349, in __wakeup
future.result()
File "/opt/conda/lib/python3.8/asyncio/futures.py", line 178, in result
raise self.exception
File "/opt/conda/lib/python3.8/concurrent/futures/thread.py", line 57, in run
result = self.fn(*self.args, **self.kwargs)
File "/opt/conda/lib/python3.8/site-packages/elyra/pipeline/kfp/processor_kfp.py", line 165, in process
raise RuntimeError(
RuntimeError: Failed to kfp.Client().list_experiments() against: 'https://kubeflow.apps.edb-p1306.cecc.ihost.com/pipeline' - Check Kubeflow Pipelines runtime configuration: 'dev_runtime-_kubeflow_pipelines' - [TIP: ensure namespace 'user-example-com' is correct]

Expected behavior
Pipeline should execute successfully.
Deployment information
Describe what you've deployed and how:

Elyra version: 3.8.0
Operating system: linux (RHEL 8.4 on ppc64le; SELinux enabled)
Installation source: custom container image (https://github.com/lehrig/kubeflow-ppc64le-notebook-images -> quay.io/ibm/kubeflow-notebook-image-ppc64le:elyra3.8.0-py3.8-tensorflow-cpu2.7.0)
Deployment type: Kubeflow (v1.5.0) Notebook Server on OpenShift v4.8

Pipeline runtime environment
If the issue is related to pipeline execution, identify the environment where the pipeline is executed

Kubeflow Pipelines (v1.5.0, multi-user auth enabled using OpenShift OAuth)

Runtime configuration settings

this one also fails with the same error using the KFP client initialized via:
client = kfp.Client(host="kubeflow.apps.edb-p1306.cecc.ihost.com")

this one works:
client = kfp.Client(host="http://ml-pipeline.kubeflow.svc.cluster.local:8888/")

-> together with https://elyra.readthedocs.io/en/latest/user_guide/runtime-conf.html#public-kubeflow-pipelines-api-endpoint-public-api-endpoint, I was also able to make it work with Elyra using the in-cluster host.
Great - thanks for your support!


[SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec

What changes were proposed in this pull request?

This pr proposes to define an individual method for each common subexpression in HashAggregateExec. In the current master, the common subexpr elimination code in HashAggregateExec is expanded in a single method; https://github.com/apache/spark/blob/4664a082c2c7ac989e818958c465c72833d3ccfe/sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala#L397
The method size can be too big for JIT compilation, so I believe splitting it is beneficial for performance. For example, in a query SELECT SUM(a + b), AVG(a + b + c) FROM VALUES (1, 1, 1) t(a, b, c),
the current master generates;
/* 098 */   private void agg_doConsume_0(InternalRow localtablescan_row_0, int agg_expr_0_0, int agg_expr_1_0, int agg_expr_2_0) throws java.io.IOException {
/* 099 */     // do aggregate
/* 100 */     // common sub-expressions
/* 101 */     int agg_value_6 = -1;
/* 102 */
/* 103 */     agg_value_6 = agg_expr_0_0 + agg_expr_1_0;
/* 104 */
/* 105 */     int agg_value_5 = -1;
/* 106 */
/* 107 */     agg_value_5 = agg_value_6 + agg_expr_2_0;
/* 108 */     boolean agg_isNull_4 = false;
/* 109 */     long agg_value_4 = -1L;
/* 110 */     if (!false) {
/* 111 */       agg_value_4 = (long) agg_value_5;
/* 112 */     }
/* 113 */     int agg_value_10 = -1;
/* 114 */
/* 115 */     agg_value_10 = agg_expr_0_0 + agg_expr_1_0;
/* 116 */     // evaluate aggregate functions and update aggregation buffers
/* 117 */     agg_doAggregate_sum_0(agg_value_10);
/* 118 */     agg_doAggregate_avg_0(agg_value_4, agg_isNull_4);
/* 119 */
/* 120 */   }

On the other hand, this pr generates;
/* 121 */   private void agg_doConsume_0(InternalRow localtablescan_row_0, int agg_expr_0_0, int agg_expr_1_0, int agg_expr_2_0) throws java.io.IOException {
/* 122 */     // do aggregate
/* 123 */     // common sub-expressions
/* 124 */     long agg_subExprValue_0 = agg_subExpr_0(agg_expr_2_0, agg_expr_0_0, agg_expr_1_0);
/* 125 */     int agg_subExprValue_1 = agg_subExpr_1(agg_expr_0_0, agg_expr_1_0);
/* 126 */     // evaluate aggregate functions and update aggregation buffers
/* 127 */     agg_doAggregate_sum_0(agg_subExprValue_1);
/* 128 */     agg_doAggregate_avg_0(agg_subExprValue_0);
/* 129 */
/* 130 */   }

Why are the changes needed?

To avoid the too-long-function issue in JVMs.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Added tests in WholeStageCodegenSuite

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15234/
Test PASSed.

Test build #110237 has started for PR 25710 at commit ba36945.

Test build #110237 has finished for PR 25710 at commit ba36945.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class CodegenContext extends Logging

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110237/
Test FAILed.

Test build #110238 has started for PR 25710 at commit 9016673.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15236/
Test PASSed.

Test build #110238 has finished for PR 25710 at commit 9016673.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class CodegenContext extends Logging

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110238/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15248/
Test PASSed.

Test build #110251 has started for PR 25710 at commit 9016673.

Test build #110251 has finished for PR 25710 at commit 9016673.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class CodegenContext extends Logging

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110251/
Test PASSed.

// the current master
Elapsed time: 47.920266373s

I also ran this benchmark to verify, but seems current master doesn't take so long on my laptop. It tooks about 5s.
Is anything causing the difference?

I also ran this benchmark to verify, but seems current master doesn't take so long on my laptop. It tooks about 4-5s.
Is anything causing the difference?
Probably, I made some mistakes.... I will re-run and update the description later. Anyway, thanks for your check!

also cc: @cloud-fan @rednaxelafx @mgaido91

I haven't reviewed this PR in detail yet, just some first thoughts:
At a glance I'm neutral about this PR. In general I don't like code splitting that cause premature spilling of state from locals to fields. I might be more in favor of:
long commonSubExpr0 = agg_subExpr_0(input1, input2);
agg_doAggregate_sum_0(commonSubExpr0);
...

than
agg_subExpr_0(input1, input2); // result goes to this.commonSubExpr0
agg_doAggregate_sum_0(); // argument passed through `this`
...

In practice, after thorough inlining, the performance shouldn't be too different, but I just don't like the idea of blindly spilling state to fields when it's not necessary.
JIT compilers can optimize code, but usually has a hard time optimizing field layout and removing "unnecessary" fields -- that requires strong inter-procedural analysis.

I agree with @rednaxelafx . Introducing many class fields shouldn't probably cause issues with the constant pool since we can batch variables in arrays, but this is also suboptimal. So it'd be great if we could avoid that.

Yea, I think so, too. If its possible for a split function to return two variables (value and isNull), we can easily localize these variables without the evil constant pool issue.... but, IIUC we currently has no logic for that. Any other idea to avoid that?

What about leaving global only the isNull?

Ah, that's one of choices. I'll try to brush up the code based on that. Thanks!

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15290/
Test PASSed.

Test build #110295 has started for PR 25710 at commit 3314954.

Test build #110295 has finished for PR 25710 at commit 3314954.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110295/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15296/
Test PASSed.

Test build #110301 has started for PR 25710 at commit 3314954.

Test build #110301 has finished for PR 25710 at commit 3314954.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110301/
Test PASSed.

LGTM. As usual, can we have a simple microbenchmark to show the advantage? I saw some discussion about the perf numbers but I can't find it in the PR description.

oh... I forgot to re-benchmark that. (I put wrong benchmark numbers first, so I removed then). I'll run benchmarks again and update the description for that soon.

(base) maropu@~:$system_profiler SPHardwareDataType
Hardware:
    Hardware Overview:
      Processor Name: Intel Core i5
      Processor Speed: 2 GHz
      Number of Processors: 1
      Total Number of Cores: 2
      L2 Cache (per Core): 256 KB
      L3 Cache: 4 MB
      Memory: 8 GB

(base) maropu@~:$java -version
java version "1.8.0_181"
Java(TM) SE Runtime Environment (build 1.8.0_181-b13)
Java HotSpot(TM) 64-Bit Server VM (build 25.181-b13, mixed mode)

val numCols = 40
val colExprs = "id AS key" +: (0 until numCols).map { i => s"id AS _c$i" }
spark.range(3000000).selectExpr(colExprs: _*).createOrReplaceTempView("t")

val aggExprs = (2 until numCols).map { i =>
  (0 until i).map(d => s"_c$d")
    .mkString("AVG(", " + ", ")")
}

// Drops the time of a first run then pick that of a second run
timer { sql(s"SELECT ${aggExprs.mkString(", ")} FROM t").write.format("noop").save() }

// the master
maxCodeGen: 12957
Elapsed time: 13.607463254s

// this pr
maxCodeGen: 4375
Elapsed time: 2.07037412s

ping @cloud-fan @viirya

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15470/
Test PASSed.

Test build #110495 has started for PR 25710 at commit 3314954.

Test build #110495 has finished for PR 25710 at commit 3314954.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110495/
Test PASSed.

ping @rednaxelafx

retest this please

Test build #110578 has started for PR 25710 at commit 3314954.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15555/
Test PASSed.

Test build #110578 has finished for PR 25710 at commit 3314954.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110578/
Test PASSed.

Merged build finished. Test PASSed.

Thanks! Merged to master.
Thanks for all the reviewers! @rednaxelafx if you have some comments and I need follow-ups, please let me know!


TODO

[x] JsForView
[x] AppJS
[x] ViewFile
[x] Remove TOP_LEVEL_NAMESPACE
[x] remove tmp/
[ ] command line

Making a Command-line Ruby Gem — Write, Build, and Push | by Steve Grice | Medium

ARGV - the command line arguments of a Ruby program


urlrules no works ModelSearch%5Bid%5D - [yii 3].

I have been working with yii 3.0 and everything works as it should, but I have not been able to make this rule work in the url which should work since the special characters are written in words.
urls.php:

return [
    [
        'pattern' => 'terminal/index/<ModelSearch%5Bid%5D:\d+>',
        'route' => 'terminal/index',
    ],
]

Q
A

Yii version
3.0

PHP version
7.1.17

Operating system
Centos 7

I'm not sure how this supposed to work. ModelSearch[id] is not a valid get param name, it will be translated as array (['ModelSearch' => ['id' => '']]).


Determine ($) Tiers for Courses

We know customers will be able to produce free tier courses but what other tiers will there be? $30? $50? $100+? How much of this money (per student enrolled) goes to the collective? How much to the customer? and how much for operational costs?

Don't forget about offering a monthly option. Businesses, with good negotiating and marketing, can often be counted on to start paying and not quit.


Refactoring the wgpu renderer internals and how it deals with updates

[x] Adds an example that draws 1000 small plots. This puts a strain on the amount of work that Python must do each draw.
[x] Put the stdinfo uniform into a singleton uniform that is reused by all objects.
[x] The world_transform that was previously in stdinfo is now in a per-wobect uniform. This is what makes the 1000-plot example fast.
[x] Investigate the need for collections. We don't seem to need them!
[x] All shaders now uses binding set 0 for uniforms, and 1 for textures and storage buffers (just for consistency).
[x] The ortho camera can be set to not maintain aspect ratio.
[x] Add (basic) support for instancing, including an example.
[ ] Would be nice to let those meshes in the instanced mesh example rotate ...
[ ] Only update world-uniform when needed.
[ ] Smarter updating overall.

I'm not entirely sure about the API for instancing here (as in, I don't fully understand how it works), but, let's merge this and keep the progress going!

I'm not entirely sure about the API for instancing here (

I replicated the API from ThreeJS. An InstancedMesh is like a normal mesh, but it has a count and a set_matrix_at method. You can imagine it has an object that has n sub-objects that are all replica's, but positioned individually.
ThreeJS also has InstancedBufferAttribute, so you can also give each instance e.g. a different color. We could do something along those lines as well.


[Admin: Eco News] When Admin edits a News item, another News item is created

#Steps to reproduce:

Go to Admin section > Eco News.
Click Add Eco News.
In the Add Eco News pop-up window, fill in all the fields and select Add.
A new News item is created.
Next to the newly created News item, select the Edit button.

In the Edit pop-up window, edit the Text field, select Save.

Actual result
The same news item is duplicated under different IDs.

Expected result
There is only one News item in which latest changes are saved.
User story and test case links
"User story #1116

Can`t reproduce

Can`t reproduce


[BUG] K3s cluster is stuck in Updating state on an etcd snapshot restore

Rancher Server Setup

Rancher version: 2.7-head commit id: 1f014b7
Installation option (Docker install/Helm Chart): Helm install

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): RKE1 - 1.4.3-rc4 and local cluster on v1.25.9 k8s version

Information about the Cluster

Kubernetes version: v1.26.4+k3s1 and v1.25.9+k3s1
Cluster Type (Local/Downstream): 3 etcd and cp (on one node) and 2 worker nodes - Linode Node driver cluster

User Information

What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom): Admin

Describe the bug
K3s cluster is stuck in Updating state on an etcd snapshot restore - "Configuring bootstrap node(s) test-k3s-sowmya-master-5ff49b9555-xmfth: waiting for cluster agent to connect"
To Reproduce

Deploy the cluster
Take a manual snapshot once cluster is active
Restore from one of the snapshots.
cluster is stuck in Updating state on an etcd snapshot restore.
One of the etcd/cp nodes is stuck in Reconciling state and Waiting for cluster agent to connect message on the node.

Expected Result
The cluster restore should go through and cluster must come up Active.

journalctl -u rancher-system-agent logs:

May 08 21:07:44 test-k3s-125-sowmy-pool1-07a52a96-hzgbt rancher-system-agent[6701]: time="2023-05-08T21:07:44Z" level=info msg="[K8s] updated plan secret fleet-default/test-k3s-125-sowmy-bootstrap-template-8r5b2-machine-plan with feedback"
May 08 21:07:45 test-k3s-125-sowmy-pool1-07a52a96-hzgbt rancher-system-agent[6701]: time="2023-05-08T21:07:45Z" level=info msg="[K8s] updated plan secret fleet-default/test-k3s-125-sowmy-bootstrap-template-8r5b2-machine-plan with feedback"
May 08 21:17:20 test-k3s-125-sowmy-pool1-07a52a96-hzgbt rancher-system-agent[6701]: time="2023-05-08T21:17:20Z" level=info msg="[Applyinator] No image provided, creating empty working directory /var/lib/rancher/agent/work/20230508-211720/b47f7b07c38e3ad26c359b30d3>
May 08 21:17:20 test-k3s-125-sowmy-pool1-07a52a96-hzgbt rancher-system-agent[6701]: time="2023-05-08T21:17:20Z" level=info msg="[Applyinator] Running command: sh [-c k3s etcd-snapshot list --etcd-s3=false 2>/dev/null]"
May 08 21:17:20 test-k3s-125-sowmy-pool1-07a52a96-hzgbt rancher-system-agent[6701]: time="2023-05-08T21:17:20Z" level=info msg="[b47f7b07c38e3ad26c359b30d33a46d361feea4a85ccc51abeb58a7ecca9e5b2_0:stdout]: Name                                                       >
May 08 21:17:20 test-k3s-125-sowmy-pool1-07a52a96-hzgbt rancher-system-agent[6701]: time="2023-05-08T21:17:20Z" level=info msg="[b47f7b07c38e3ad26c359b30d33a46d361feea4a85ccc51abeb58a7ecca9e5b2_0:stdout]: on-demand-test-k3s-125-sowmy-pool1-07a52a96-hzgbt-168357983>
May 08 21:17:20 test-k3s-125-sowmy-pool1-07a52a96-hzgbt rancher-system-agent[6701]: time="2023-05-08T21:17:20Z" level=info msg="[b47f7b07c38e3ad26c359b30d33a46d361feea4a85ccc51abeb58a7ecca9e5b2_0:stdout]: on-demand-test-k3s-125-sowmy-pool1-07a52a96-hzgbt-168357983>
May 08 21:17:20 test-k3s-125-sowmy-pool1-07a52a96-hzgbt rancher-system-agent[6701]: time="2023-05-08T21:17:20Z" level=info msg="[b47f7b07c38e3ad26c359b30d33a46d361feea4a85ccc51abeb58a7ecca9e5b2_0:stdout]: on-demand-test-k3s-125-sowmy-pool1-07a52a96-hzgbt-168357986>
May 08 21:17:20 test-k3s-125-sowmy-pool1-07a52a96-hzgbt rancher-system-agent[6701]: time="2023-05-08T21:17:20Z" level=info msg="[b47f7b07c38e3ad26c359b30d33a46d361feea4a85ccc51abeb58a7ecca9e5b2_0:stdout]: on-demand-test-k3s-125-sowmy-pool1-07a52a96-hzgbt-168357999>
May 08 21:17:20 test-k3s-125-sowmy-pool1-07a52a96-hzgbt rancher-system-agent[6701]: time="2023-05-08T21:17:20Z" level=info msg="[Applyinator] Command sh [-c k3s etcd-snapshot list --etcd-s3=false 2>/dev/null] finished with err: <nil> and exit code: 0"
May 08 21:17:20 test-k3s-125-sowmy-pool1-07a52a96-hzgbt rancher-system-agent[6701]: time="2023-05-08T21:17:20Z" level=info msg="[K8s] updated plan secret fleet-default/test-k3s-125-sowmy-bootstrap-template-8r5b2-machine-plan with feedback"

Note:

On 2.7.3 - tried it 3 times, I was not able to reproduce this.
On 2.7-head, hit it 2 out of 3 times with the above mentioned cluster config ^

Added regression label as it could be a regression based on:

On 2.7.3 - tried it 3 times, I was not able to reproduce this.
On 2.7-head, hit it 2 out of 3 times with the above mentioned cluster config ^

FYI @Oats87

@sowmyav27 is this on the "same set" of etcd nodes or is it a new set of etcd nodes? i.e. did you delete any of the machines?
I've been noticing some issues when restoring onto brand new nodes that I am trying to figure out how to handle.

I don't believe that this is a regression. It stems from the fact that K3s/RKE2's stock kube-controller-manager does not perform taint based eviction for NotReady nodes in small < 50 clusters.

https://github.com/rancher/rancher/pull/41459 adds etcd restore logic that proceeds to both clean up stale nodes and pods that need to be restarted

Ticket #41457 - Test Results - ✅
Verified with HA Helm Rancher on v2.7-1ae8ca94691cd2a5a6d6732da4a8670af6206f0f-head:

Fresh install of rancher v2.7-head
Provision a downstream K3s Linode Node driver cluster (3 etcd/cp nodes, 2 wkr nodes) w/ k8s v1.26.4+k3s1
Provision a downstream K3s Linode Node driver cluster (3 etcd/cp nodes, 2 wkr nodes) w/ k8s v1.25.9+k3s1
Once clusters are active, take a manual snapshot of each
Verified - snapshots successfully captured
For each cluster, restore to latest snapshot taken
Verified - both clusters successfully restore
For each cluster, take a second manual snapshot
Verified - both clusters successfully capture second snapshot
For each cluster, restore to second manual snapshot taken
Verified - both clusters successfully restore
Take one final manual snapshot for each cluster
Verified - 3rd manual snapshot successfully captured
For each cluster, restore to third manual snapshot taken
Verified - both clusters successfully restore
Verified - snap/restore working as expected for downstream K3s clusters

In addition to the above posted test results, the same use case was also tested and confirmed using a downstream RKE2 Linode Node driver cluster w/ k8s v1.26.4+rke2r1.


expose original source address of WireGuard UDP packets in TcpStream

The source socket of WireGuard UDP packets (i.e. the socket address of the WireGuard client outside the WireGuard tunnel) can now be accessed with TcpStream.get_extra_info("original_src").
There's currently no way to do the same for UDP packets, since the callback for received UDP packets only accepts (payload, src_addr, dst_addr) as arguments.

Adding this was pretty simple and it doesn't make the code more complicated than it already is.
Even if it ends up being unused by mitmproxy, it's nice for debugging (I also included it in the output TcpStream.__repr__() to match original_dst which was already there).


ember-browserify not being installed in blueprint

afterInstall() at this line of code needs to return the promise:
  return this.addAddonToProject('ember-browserify');
to have the install wait on ember-browserify to install.
The work around is to manually run ember install ember-browserify.
Sorry I didn't catch this earlier when we were looking at the PR.

Thats ok. I'll do it quickly.


Typography changes are not present in exports

Describe the bug
Typography changes are not present in exports
To Reproduce
Steps to reproduce the behavior:

Change a property one of the 15 M3 typography roles

Export to DSP or Jetpack Compose

Open zip - check fonts.json or Type.kt

Values are the defaults

Expected behavior
That exports should have the up to date values.
Desktop (please complete the following information):

OS: Windows 10

Currently only supporting a static font, but there is work being done to support multiple types.


[tracking] warning: exported type MemoryStorage should have comment or be unexported (golint)

https://github.com/RedHatInsights/insights-results-aggregator-mock/issues/53

Fixed in https://github.com/RedHatInsights/insights-results-aggregator-mock/issues/53


Empty page from add new object from Osmose

After click on the blue box the page is empty (fully withe)

With this in the browser console:
The above error occurred in the <Editor> component:
    in Editor (at EditorModal.jsx:24)
    in div
    in main
    in styled.main
    in aside
    in styled.aside
    in Transition
    in Modal (at EditorModal.jsx:23)
    in span
    in styled.span
    in ThemeProvider
    in DefaultTheme (at EditorModal.jsx:22)
    in EditorModal (at OsmoseSidebar.jsx:88)
    in span
    in styled.span
    in ThemeProvider
    in DefaultTheme (at OsmoseSidebar.jsx:70)
    in OsmoseSidebar (created by Connect(OsmoseSidebar))
    in Connect(OsmoseSidebar) (at EditionRoutes.jsx:32)
    in Route (at EditionRoutes.jsx:29)
    in EditionRoutes (at App.jsx:63)
    in section
    in styled.section
    in Section (created by Styled(Section))
    in Styled(Section) (at App.jsx:42)
    in span
    in styled.span
    in ThemeProvider
    in DefaultTheme (at App.jsx:41)
    in Router (created by BrowserRouter)
    in BrowserRouter (at App.jsx:40)
    in App (created by Connect(App))
    in Connect(App) (at index.jsx:12)
    in Provider (at index.jsx:11)

Consider adding an error boundary to your tree to customize error handling behavior.
Visit https://fb.me/react-error-boundaries to learn more about error boundaries.
index.js:2178
TypeError: can't convert null to object
index.js:7379
TypeError: can't convert null to object

The fix is deployed on the instance


DTM-12541 Removed "hide activity" support.

https://jira.corp.adobe.com/browse/DTM-12541
If you set a local storage item named com.adobe.reactor.hideActivity, it will prevent actions from running when rules run. It was a carry-over from DTM. As far as I know, nobody has used it ever in Launch and it's intentionally not documented anywhere. The purpose as I understood it was that when clients were having problems on their page and attributed the problems to Launch, we could set the local storage item to easily determine if it was Launch that was causing the problem or not. In such a case, we could easily enough proxy a library using something like Charles and turn off running of actions that way. The usefulness of com.adobe.reactor.hideActivity doesn't merit its weight in the library IMO.

Coverage decreased (-0.02%) to 97.929% when pulling 3ad1b799fa02ec7633a3b6df99e1734e38f28e3e on remove-hide-activity into cc97ef4f58a8b6c835ed41e8772d0e01a0f1a709 on master.


Simple without reward token

Avoid using RewardToken
so far the precision seems to get hit (more rounding error)
For example, this unittest is failing
brownie compile && brownie test tests/test_sktl.py::TestSKTLSimpleDvd::test_simple_rewards --verbose

@wohlrich I have added a "beforeSupply" to help the calculations.  However, this new implementation is still failing my unit tests.  The main reason is that in "rewardBalance()", we simply use the "balanceOf(address)" to calculate the balance.  It doesn't take into account of compound rewards when the holder hasn't withdrawn rewards after multiple rewards.
This is the reason why I have "rewardToken" in the first place.  The rewardToken is like the reward share as it stays the same for a given address as long as there is no token transfer taken place.
Closing this PR as it can't support compound rewards.


Create examples using each of the Flatland class diagrams

Create an xmm / mss example pair for each of the Flatland class diagrams in the documentation directory.  In other words, use Flatland to draw its own diagrams!

Done


Remove unused/broken javascript

This is a follow up to #400
I'm removing this code because I can't find it referenced anywhere other than the places I removed it from.
I realize this pull request doesn't add any functionality, but if someone adds a class of date to a th element this change will stop the functionality from breaking.

Coverage remained the same at 81.714% when pulling 9e6bb2604e27f11101342ff3c1f16f7f7235b2f4 on kirkins:patch-2 into 66d344b3c16944771f3d7fcb88f6f974d8ec4814 on voxpupuli:master.

Realizing that the sort function isn't working. Instead of deleting this I will go back and try to fix the code.
Example of not working:

It's used. About 4 months ago I cleaned up the ordering of all the JavaScript.

It should trigger on any table header with class of date. I didn`t see any of those when I looked, except for the ones I removed.
If you find any with the class I'll be interested to see if it works.

So it's sorting alpha numeric instead of by date?

@mterzo yes I think so. I think it's the case for tables referencing date or time.

I will try to fix it when I go back to work tomorrow if it's still an issue. I don't have it setup at home right now.

Brought back the classes deleted in #400.
Found the javascript was breaking because of the " - " in the date-time string.

Coverage remained the same at 81.714% when pulling b2bc87e3e8544554f2e02e6caed4a34ecca7fc2c on kirkins:patch-2 into 66d344b3c16944771f3d7fcb88f6f974d8ec4814 on voxpupuli:master.

Coverage remained the same at 81.714% when pulling 4f9930fc53eaa73909038d2dd86bbda0d2d6e302 on kirkins:patch-2 into 66d344b3c16944771f3d7fcb88f6f974d8ec4814 on voxpupuli:master.

This may need another modification, I'm seeing this warning in javascript console log:

Deprecation warning: moment construction falls back to js Date. This is discouraged and will be removed in upcoming major release. Please refer to https://github.com/moment/moment/issues/1407 for more info.

Coverage remained the same at 81.714% when pulling 8e2160bc93950442d95903ac6cb9b13d15506309 on kirkins:patch-2 into 66d344b3c16944771f3d7fcb88f6f974d8ec4814 on voxpupuli:master.

Coverage remained the same at 81.714% when pulling 8e2160bc93950442d95903ac6cb9b13d15506309 on kirkins:patch-2 into 66d344b3c16944771f3d7fcb88f6f974d8ec4814 on voxpupuli:master.

Coverage remained the same at 81.714% when pulling 8e2160bc93950442d95903ac6cb9b13d15506309 on kirkins:patch-2 into 66d344b3c16944771f3d7fcb88f6f974d8ec4814 on voxpupuli:master.

Sorry for all the commits and then removing. I thought I made a typo in push.

Coverage remained the same at 81.714% when pulling a555611cc61e170731af449dfd695b64af469cb0 on kirkins:patch-2 into 66d344b3c16944771f3d7fcb88f6f974d8ec4814 on voxpupuli:master.

Coverage remained the same at 81.714% when pulling 18df71924acef8ae169b621c64b07704a258d963 on kirkins:patch-2 into 66d344b3c16944771f3d7fcb88f6f974d8ec4814 on voxpupuli:master.

Gonna look at this tomorrow.

@mterzo Have a chance to see if my change works on your end?

So is the sorting correct in upstream as of now?

Without the change sorting of dates is done alphabetically.
So you won't notice this bug unless you have a date based column with different months.
For testing you can modify the dom directly and then resort to see the problem.

OK, I thought this also affected sorting in all other types of numerical lists. I'd like to see lists of integers, like the 'uptime' facts, sorted numerically instead of alphabetically.

@mterzo can we have this merged in?


 The new BS API is much more resilient: https://bucklescript.github.io/docs/en/object.html#record-mode
That one's an intermediate step toward compiling record to js object, if it ever happens. If not, then it's still a solid step up.

Right ;) I think the object needs to stay for a number of reasons. Having restructuring like this would be awesome. (also n.b. that the abstract deriving mode doesn't support destructuring either)


Can't add more than 20 options

No longer allows >20 options

I would also adjust the readme from 30 to 20 options


First round of polish for css and mobile-responsiveness

This somehow got deleted out of your document

{
font-family: 'Gentium Book Plus', serif;
}


SIMSBIOHUB-490/521: Import Observations with measurements

Links to Jira Tickets
SIMSBIOHUB-490
SIMSBIOHUB-521
Description of Changes

Added support for measurement columns to observation imports
Added custom validation to measurement columns

Note: Test coverage needs updating still, but we plan to merge this to Dev first, so QA can proceed in the meantime.
Testing Notes
CSV Upload

Get test file attached to SIMBIOHUB-490 ticket
Navigate to observation management page
Upload CSV
See new wolf observations appear in table
Open gear menu above observation table -> + Add Measurements
Search and add Estimated Age, Juvenile count, Juvenile at heel indicator
See new measurement data

Codecov Report
Attention: Patch coverage is 15.88785% with 270 lines in your changes are missing coverage. Please review.

Project coverage is 54.46%.  Consider uploading reports for the commit 80ca767 to get more accurate results

Files
Patch %
Lines

api/src/utils/xlsx-utils/worksheet-utils.ts
10.00%
72 Missing :warning:

app/src/contexts/observationsTableContext.tsx
0.00%
64 Missing :warning:

api/src/services/observation-service.ts
15.55%
38 Missing :warning:

...ies/observation-subcount-measurement-repository.ts
20.00%
28 Missing :warning:

...vey/{surveyId}/observations/measurements/delete.ts
0.00%
18 Missing :warning:

...rvices/observation-subcount-measurement-service.ts
30.00%
7 Missing :warning:

api/src/services/subcount-service.ts
22.22%
7 Missing :warning:

...able/configure-table/ConfigureColumnsContainer.tsx
0.00%
6 Missing :warning:

app/src/hooks/api/useObservationApi.ts
0.00%
6 Missing :warning:

api/src/repositories/observation-repository.ts
71.42%
4 Missing :warning:

... and 9 more

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1227      +/-   ##
==========================================
- Coverage   55.12%   54.46%   -0.67%
==========================================
  Files         603      598       -5
  Lines       18293    18357      +64
  Branches     2817     2836      +19
==========================================
- Hits        10084     9998      -86
- Misses       7542     7707     +165
+ Partials      667      652      -15

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Two things I noticed while testing:
1. Column widths are a bit off (see attached image).

2. The new measurement columns should not be marked as `sortable` in the DataGrid.

Updated to make the measurement columns not sortable.
The widths will probably have to be a Jer thing. Right now they just matching the string and number widths of the other fields.


What is the predicted affinity unit? Can it convert to IC50?

Issue summary
What is the predicted affinity unit? Can it convert to IC50?
Steps to reproduce
Your system configuration
Operating system:
Compiler:
CUDA version (if applicable):
CUDNN version (if applicable):
Python version:

It is a "pK" so 9 corresponds to 1nM, 6 to 1µM etc.


Continental - The number of jobs posted on https://solr.peviitor.ro (153) is not the same as the number of jobs posted on the company's website (322)

ENVIRONMENT: production
URL: https://solr.peviitor.ro/
Browser: Chrome
Device: Laptop
OS: Windows 11
STEPS TO REPRODUCE:

Open the URL in the browser
Execute Query for "Continental" company
Check the number of jobs
Open https://jobs.continental.com/en/#/?locationSuggestChecksums=97df691231f6e638f96c63c52454e425&sorting=cityLabel_stringS ASC
Check the number of jobs
EXPECTED RESULTS:
The number of jobs is the same

ACTUAL RESULTS:
The number of jobs posted on https://solr.peviitor.ro (153) is not the same as the number of jobs posted on the company's website (322)
On peviitor.ro page is the same

Fixed!


Clearing connection queue? (conn._protocol._queue)

Are there any safer / recommended ways to clear out the connection queue of queries to prevent them from being executed? I discovered I could manually set connection._protocol._queue to an empty array, and that would accomplish my goal ... but it feels dirty.
Any other means, or is clearing out _queue not as dangerous as it seems?

Both yes and no, but to get an appropriate answer, perhaps would it be possible to describe your use case as to why you are trying to clear the queue?

I've got a bunch of models in our application backend, wrapped in a .beginTransaction(). Depending on the complexity of the action, they can get pretty long and heavy. A bunch of stored procedure calls are queued up through a whole heap of promise arrays, nested inside a .then() of another Promise.all, nested in a promise, nested in another promise, etc. I've found that in some cases, when one of these queries fails, the Promise.all().catch() is triggered immediately by a reject and moves on to the main wrapper .catch() right away, while some sibling promises are still waiting to be handled.
The main catch calls a connection.rollback() to get rid of anything that happened in this transaction, and then goes about creating some error logs before committing again. The remaining queries then finish up their sql process AFTER the connection.rollback(), and get themselves commit with the errors. Boo! When I set connection._protocol_queue = [] before connection.rollback(), those promises don't come through anymore! I'm worried that might have some adverse effects, though.

Ah, I see. So what is happening is that in your code you end up in a condition where you expect to be in a transaction, but there is a condition that triggers a rollback of said transaction, but nothing in the code to prevent those queries from actually getting run on the connection after the rollback occurs, so they are all auto committed, is that right?
Unless I'm missing something here I cannot see how clearing the (empty) queue would prevent the queries from still running after the rollback, though. It would break any currently executing sequence though since it is tracked by being at index zero in a few places.
Would it be possible to provide code that demonstrates what you are seeing here so I can use that to better understand how to solve this issue?


examples/train_qlora/llama3_lora_sft_gptq.yaml  i can not  find  quantization_bit param (but i  see in  LLaMA-Factory/examples/extras/fsdp_qlora /llama3_lora_sft.yaml)   how  can  i  set  param to design 4/8 bit quantization

Reminder

[X] I have read the README and searched the existing issues.

System Info
llama_factory 0.9.0
Reproduction
you can see the information  examples/train_qlora/llama3_lora_sft_gptq.yam  this
model
model_name_or_path: TechxGenus/Meta-Llama-3-8B-Instruct-GPTQ
method
stage: sft
do_train: true
finetuning_type: lora
lora_target: all
dataset
dataset: identity,alpaca_en_demo
template: llama3
cutoff_len: 1024
max_samples: 1000
overwrite_cache: true
preprocessing_num_workers: 16
output
output_dir: saves/llama3-8b/lora/sft
logging_steps: 10
save_steps: 500
plot_loss: true
overwrite_output_dir: true
train
per_device_train_batch_size: 1
gradient_accumulation_steps: 8
learning_rate: 1.0e-4
num_train_epochs: 3.0
lr_scheduler_type: cosine
warmup_ratio: 0.1
bf16: true
ddp_timeout: 180000000
eval
val_size: 0.1
per_device_eval_batch_size: 1
eval_strategy: steps
eval_steps: 500
Expected behavior
No response
Others
No response

Meta-Llama-3-8B-Instruct-GPTQ is already a 4-bit model

@hiyouga sorry，the code posted is  llama-factory example-code,but my question is  that  if  i  set model not  'TechxGenus/Meta-Llama-3-8B-Instruct-GPTQ' ,i want to qlora yi-1.5-34b, how can  i  set  8 bit or 4 bit  ，example did not show this  parameter

see https://github.com/hiyouga/LLaMA-Factory/blob/main/examples/train_qlora/llama3_lora_sft_otfq.yaml


[WFLY-9288] Enable session auto-creation in the event that the wrong interface type is invoked

https://issues.jboss.org/browse/WFLY-9288

/cc @fl4via

Failure is related; looks like I'll need a ejb-client upgrade.  Will reopen later.


not work with vue 3 typescript

i just create vue3 typescript , its like stuck and not working

and  click (open children) not work

Hey, can you provide reproduction env ?

its in development env not reproduction

If don't see your code how am i supposed to tell you what is wrong ? Can you provide a candesandbox ?

Maybe just declare module in your d.ts file ?
like "declare module 'vue3-treeview';" ?

looks like it is duplicate of 10


Proposed API changes

For discussion, not final

@nkolba @tim-dinsdale Next we need to get the website documentation updated for this.


Clicking TabBarTop entry while the text input trey is open closes the trey but does not navigate

Current Behavior
If I am in the process of entering text on iOS, and I click a different tab with TabBarTop, it does not navigate to the new tab and instead simply closes the text trey (the text area that slides up from the bottom on iOS with a keyboard etc).
Expected Behavior
When I am entering text on iOS, and I click a different tab with TabBarTop, it should close the text entry trey / ios keyboard AND navigate to the new tab.
Your Environment

software
version

react-navigation
1.0.0-beta.9

expo
16.0.0

node
6.9.5

npm or yarn
yarn (0.16.1)

Might be related to https://github.com/react-community/react-navigation/issues/1339

This should probably be configurable, maybe just like a scrollview?
https://facebook.github.io/react-native/docs/scrollview.html#keyboardshouldpersisttaps

Related issue in the appropriate repo: https://github.com/react-native-community/react-native-tab-view/issues/339

Good news, this should be fixed in  v0.0.70 of react-native-tab-view (thanks @Kerumen for the link) so it will be most likely be fixed for beta.16

@thebigredgeek we released new versions which use the aforementioned version of react-native-tab-view; can you try upgrading and closing this issue if it got fixed?
(if no answer I'll close in 7 days)

Hi there @thebigredgeek ,
In an effort to cleanup this project and prioritize a bit, since this issue had no follow up since my last comment I'm going to close it.
If you are still having the issue with the latest version (especially if it's a bug report) please check the current open issues, and if you can't find a duplicate, open a new one that uses the new Issue Template to provide some more details to help us solve it.


Eclipse EGIT client fails with 401 error when attempt to push using https

GOGS Version: 0.11.4
Git Version: Eclipse EGIT, <IP_ADDRESS>704051617-r, issue exists in all versions of egit that I have tried that include the full suite of Neon releases, as well as pre-release of Oxygene
Operating system: Windows 7 SP1,
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[x ] SQLite

Can you reproduce the bug at https://try.gogs.io:

[x ] Yes (https://try.gogs.io/KevinTester/TestTest.git)
[ ] No
[ ] Not relevant

Log gist (usually found in log/gogs.log):

Description
I am using the Eclipse IDE.  Eclipse integrates git operations into the IDE, allowing you to perform most GIT operations directly from the IDE.  When I attempt to push my changes using eclipse (https) to a remote GOGS repo I consistently get a 401 unauthorized error.
If however I go into GOGS and change the repo so that its a private, and then attempt to push, egit will either request my credentials or it will use the cached credentials and complete the push successfully.
This issue does not occur with the GIT command line.
To reproduce issue:

clone the repository: https://try.gogs.io/KevinTester/TestTest.git
add the cloned repo to eclipse
turn off sslVerify (this could be unique to my environment)

git config http.sslVerify false

make some changes to the readme file and then commit and push.  You should get a prompt asking for credentials, but instead it will error, with the message: Can't connect to any repository: 401 Unauthorized)

interestingly enough if I toggle the repository to become a private repo, and then retry the push in eclipse everything works correctly, i.e. it gives me a prompt for the credentials, or uses the cached credentials and completes the push successfully.
The issue only seems to come up with GOGS, I don't have this issue when working with other remote git repositories like bitbucket, or github.
Please let me know if I can do anything to help resolve this bug / issue
Thanks.

$ org.eclipse.jgit.pgm-<IP_ADDRESS>704051617-r.sh push
Counting objects:       3
Finding sources:        100% (3/3)
Getting sizes:          100% (2/2)
Compressing objects:    100% (101/101)
Writing objects:        100% (3/3)
org.eclipse.jgit.api.errors.TransportException: https://try.gogs.io/KevinTester/TestTest.git: 401 Unauthorized
        at org.eclipse.jgit.api.PushCommand.call(PushCommand.java:180)
        at org.eclipse.jgit.pgm.Push.run(Push.java:136)
        at org.eclipse.jgit.pgm.TextBuiltin.execute(TextBuiltin.java:199)
        at org.eclipse.jgit.pgm.Main.execute(Main.java:252)
        at org.eclipse.jgit.pgm.Main.run(Main.java:143)
        at org.eclipse.jgit.pgm.Main.main(Main.java:115)
Caused by: org.eclipse.jgit.errors.TransportException: https://try.gogs.io/KevinTester/TestTest.git: 401 Unauthorized
        at org.eclipse.jgit.transport.TransportHttp$Service.openResponse(TransportHttp.java:972)
        at org.eclipse.jgit.transport.TransportHttp$MultiRequestService.execute(TransportHttp.java:1076)
        at org.eclipse.jgit.transport.TransportHttp$Service$HttpExecuteStream.read(TransportHttp.java:1001)
        at org.eclipse.jgit.util.io.UnionInputStream.read(UnionInputStream.java:145)
        at org.eclipse.jgit.util.IO.readFully(IO.java:247)
        at org.eclipse.jgit.transport.PacketLineIn.readLength(PacketLineIn.java:225)
        at org.eclipse.jgit.transport.SideBandInputStream.needDataPacket(SideBandInputStream.java:154)
        at org.eclipse.jgit.transport.SideBandInputStream.read(SideBandInputStream.java:136)
        at org.eclipse.jgit.util.IO.readFully(IO.java:247)
        at org.eclipse.jgit.transport.PacketLineIn.readLength(PacketLineIn.java:225)
        at org.eclipse.jgit.transport.PacketLineIn.readString(PacketLineIn.java:155)
        at org.eclipse.jgit.transport.BasePackPushConnection.readStringLongTimeout(BasePackPushConnection.java:422)
        at org.eclipse.jgit.transport.BasePackPushConnection.readStatusReport(BasePackPushConnection.java:369)
        at org.eclipse.jgit.transport.BasePackPushConnection.doPush(BasePackPushConnection.java:221)
        at org.eclipse.jgit.transport.TransportHttp$SmartHttpPushConnection.doPush(TransportHttp.java:886)
        at org.eclipse.jgit.transport.BasePackPushConnection.push(BasePackPushConnection.java:170)
        at org.eclipse.jgit.transport.PushProcess.execute(PushProcess.java:172)
        at org.eclipse.jgit.transport.Transport.push(Transport.java:1310)
        at org.eclipse.jgit.api.PushCommand.call(PushCommand.java:169)
        ... 5 more

No such problem in gogs v0.8.10

No such problem in gogs v0.8.10 - v0.9.141
Problem exists since gogs v0.10(RC)

The problem is from commit v0.9.141-51 d521e716dd59617dbbb637a3e8028bf4a5c6f849

If you use core git client, you will find git sends objects before promoting username/password. This is very strange.
$ git push
Counting objects: 3, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 291 bytes | 0 bytes/s, done.
Total 3 (delta 2), reused 0 (delta 0)
Username for 'http://localhost:3000':

Recently upgraded to 0.11.10 and experience the same issue with Eclipse Git in Neon.3 over normal HTTP. If the repository is changed to Private, Eclipse Git will work. Other Git clients appear to work without adjustments. Everything was working correctly with Gogs / Eclipse Git prior to upgrading from <IP_ADDRESS>5.

Based on https://discuss.gogs.io/t/eclipse-git-https-try-gogs-io-https-try-gogs-io-xiaoye-test-git-401-unauthorized/1138/9, change visibility to private can push normally. But still no idea about the core issue.

JGit connects to https://<gogs-server>/<user>/<repo>.git/info/refs?service=git-receive-pack. The server does not ask for authentication for this URL if the repo is public, returns HTTP 200 and a meaningful result. When JGit then tries to send data to the git-receive-pack endpoint, the server suddenly responds with the 401.
Don't know if that is correct, or if the server should ask for authentication already for the service=git-receive-pack query.
JGit bug is https://bugs.eclipse.org/bugs/show_bug.cgi?id=513043 .

Looks to me as if this change sets isPull to true for all GET requests, and then later (line 70) skips authentication if the repo is public.

@linquize wrote above:

If you use core git client, you will find git sends objects before promoting username/password. This is very strange.

No, it isn't. The 401 can be gotten by the client only after it has sent the data. Only then it can re-try, and it must re-send the data.
For JGit, there's a fix in the works, but it'll also have to send the data at least twice.
I think it would be much better if GOGS required authentication already on the capability-checking GET to info/refs?service=git-receive-pack. Authentication re-tries will then occur on this cheap request, and the POST can then be done with the correct authentication headers up front, and the client thus needs to send the data only once.

JGit has been fixed now to handle servers that request authentication only on the POST. So with an EGit/JGit from the latest nightly builds, this problem should no longer occur.
It would still be good if GOGS required authentication for receive-pack already on the GET. Authentication on POST only slows down clients in general, not just JGit, since they'll have to send data twice.

I have the same (similar) problem with EGit/jGit even after installing the latest version from the nightly build repository. We are connecting to a locally hosted TFS GIT instance using https. Git Windows command line client as well as GUI front ends like SourceTree or the Github Desktop work fine. EGit does prompt for credentials but then fails with an authentication error. Here is a sample stacktrace:
!ENTRY org.eclipse.egit.core 4 0 2017-09-27 15:33:03.493
!MESSAGE An exception occurred during push on URI https://tfs.synergy.net.au/tfs/Synergy/WBU/_git/STARS: https://tfs.synergy.net.au/tfs/Synergy/
WBU/_git/STARS: null
!STACK 0
org.eclipse.jgit.api.errors.TransportException: https://tfs.synergy.net.au/tfs/Synergy/WBU/_git/STARS: null
at org.eclipse.jgit.api.PushCommand.call(PushCommand.java:180)
at org.eclipse.egit.core.op.PushOperation.run(PushOperation.java:215)
at org.eclipse.egit.ui.internal.push.PushJob.performJob(PushJob.java:84)
at org.eclipse.egit.ui.internal.jobs.RepositoryJob.run(RepositoryJob.java:57)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
Caused by: org.eclipse.jgit.errors.TransportException: https://tfs.synergy.net.au/tfs/Synergy/WBU/_git/STARS: null
at org.eclipse.jgit.transport.BasePackPushConnection.doPush(BasePackPushConnection.java:238)
at org.eclipse.jgit.transport.TransportHttp$SmartHttpPushConnection.doPush(TransportHttp.java:1119)
at org.eclipse.jgit.transport.BasePackPushConnection.push(BasePackPushConnection.java:170)
at org.eclipse.jgit.transport.PushProcess.execute(PushProcess.java:172)
at org.eclipse.jgit.transport.Transport.push(Transport.java:1310)
at org.eclipse.jgit.api.PushCommand.call(PushCommand.java:169)
... 4 more
Caused by: java.io.IOException
at org.eclipse.jgit.transport.HttpAuthMethod$Negotiate.configureRequest(HttpAuthMethod.java:560)
at org.eclipse.jgit.transport.TransportHttp.httpOpen(TransportHttp.java:861)
at org.eclipse.jgit.transport.TransportHttp$Service.openStream(TransportHttp.java:1150)
at org.eclipse.jgit.transport.TransportHttp$Service.sendRequest(TransportHttp.java:1187)
at org.eclipse.jgit.transport.TransportHttp$MultiRequestService.execute(TransportHttp.java:1415)
at org.eclipse.jgit.transport.TransportHttp$Service$HttpExecuteStream.read(TransportHttp.java:1345)
at org.eclipse.jgit.util.io.UnionInputStream.read(UnionInputStream.java:145)
at java.io.FilterInputStream.read(FilterInputStream.java:133)
at org.eclipse.jgit.util.io.TimeoutInputStream.read(TimeoutInputStream.java:112)
at org.eclipse.jgit.util.IO.readFully(IO.java:247)
at org.eclipse.jgit.transport.PacketLineIn.readLength(PacketLineIn.java:225)
at org.eclipse.jgit.transport.SideBandInputStream.needDataPacket(SideBandInputStream.java:154)
at org.eclipse.jgit.transport.SideBandInputStream.read(SideBandInputStream.java:136)
at org.eclipse.jgit.util.IO.readFully(IO.java:247)
at org.eclipse.jgit.transport.PacketLineIn.readLength(PacketLineIn.java:225)
at org.eclipse.jgit.transport.PacketLineIn.readString(PacketLineIn.java:155)
at org.eclipse.jgit.transport.BasePackPushConnection.readStringLongTimeout(BasePackPushConnection.java:437)
at org.eclipse.jgit.transport.BasePackPushConnection.readStatusReport(BasePackPushConnection.java:369)
at org.eclipse.jgit.transport.BasePackPushConnection.doPush(BasePackPushConnection.java:221)
... 9 more
Caused by: GSSException: No valid credentials provided (Mechanism level: No valid credentials provided (Mechanism level: Attempt to obtain new I
NITIATE credentials failed! (null)))
at sun.security.jgss.spnego.SpNegoContext.initSecContext(SpNegoContext.java:454)
at sun.security.jgss.GSSContextImpl.initSecContext(GSSContextImpl.java:248)
at sun.security.jgss.GSSContextImpl.initSecContext(GSSContextImpl.java:179)
at org.eclipse.jgit.transport.HttpAuthMethod$Negotiate.configureRequest(HttpAuthMethod.java:554)
... 27 more
Caused by: GSSException: No valid credentials provided (Mechanism level: Attempt to obtain new INITIATE credentials failed! (null))
at sun.security.jgss.krb5.Krb5InitCredential.getTgt(Krb5InitCredential.java:343)
at sun.security.jgss.krb5.Krb5InitCredential.getInstance(Krb5InitCredential.java:145)
at sun.security.jgss.krb5.Krb5MechFactory.getCredentialElement(Krb5MechFactory.java:122)
at sun.security.jgss.krb5.Krb5MechFactory.getMechanismContext(Krb5MechFactory.java:187)
at sun.security.jgss.GSSManagerImpl.getMechanismContext(GSSManagerImpl.java:224)
at sun.security.jgss.GSSContextImpl.initSecContext(GSSContextImpl.java:212)
at sun.security.jgss.GSSContextImpl.initSecContext(GSSContextImpl.java:179)
at sun.security.jgss.spnego.SpNegoContext.GSS_initSecContext(SpNegoContext.java:882)
at sun.security.jgss.spnego.SpNegoContext.initSecContext(SpNegoContext.java:317)
... 30 more
Caused by: javax.security.auth.login.LoginException: No password provided
at com.sun.security.auth.module.Krb5LoginModule.promptForPass(Krb5LoginModule.java:919)
at com.sun.security.auth.module.Krb5LoginModule.attemptAuthentication(Krb5LoginModule.java:760)
at com.sun.security.auth.module.Krb5LoginModule.login(Krb5LoginModule.java:617)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at javax.security.auth.login.LoginContext.invoke(LoginContext.java:755)
at javax.security.auth.login.LoginContext.access$000(LoginContext.java:195)
at javax.security.auth.login.LoginContext$4.run(LoginContext.java:682)
at javax.security.auth.login.LoginContext$4.run(LoginContext.java:680)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.login.LoginContext.invokePriv(LoginContext.java:680)
at javax.security.auth.login.LoginContext.login(LoginContext.java:587)
at sun.security.jgss.GSSUtil.login(GSSUtil.java:258)
at sun.security.jgss.krb5.Krb5Util.getTicket(Krb5Util.java:158)
at sun.security.jgss.krb5.Krb5InitCredential$1.run(Krb5InitCredential.java:335)
at sun.security.jgss.krb5.Krb5InitCredential$1.run(Krb5InitCredential.java:331)
at java.security.AccessController.doPrivileged(Native Method)
at sun.security.jgss.krb5.Krb5InitCredential.getTgt(Krb5InitCredential.java:330)
... 38 more

This isn't the same issue. You're trying to connect to a TFS server, not GOGS. Let's continue this discussion in the Egit forum, where you already had posted this, but then never replied to my questions.

My apologies for being tardy. Different to this forum the Eclipse Egit forum didn't send me a notification when you posted your questions and I failed to check it manually. Anyway, I posted answers to your questions in the Egit forum.

I used to set the visibility to private but now I installed Gogs for at my work and we can't work in team if we set the visibility to private... Any other solution ?

This issue isn't restricted to this one client.  I see identical behavior with nodegit.
GETs git-receive-pack which returns 200, then chokes on POST git-receive-pack with 401.  Client is capable of asking for credentials, but never does as the GET returns 200.

Same here with Git commandline client (git version <IP_ADDRESS>)

Seems to be a git client issue with 1.7.10... installed 1.9.1 from Backports and it now asks for credentials for public repo's as well and works successfully.
Seems that "public" repo's could have been pushed with anonymous user earlier e.g. on github.. But with Gogs you need to use your credentials to push in any case. Newer git clients seems to be aware of that.

But git 1.7/1.9 is quite old

This issue seems to have disappeared for me personally with the most recent update.
I can push using netbeans again just fine with making the repository private.

I think it worked for you because you made the repository private. I'm still experiencing the issue after updating to the latest version.

Also encountering this problem. I can confirm that downgrading to <IP_ADDRESS>1 makes this issue go away.
When i attempt to make the same clone in the latest version, i get the initially mentioned failure.

Hey, its 2020 and this issue still seems to be around.
We're using  2020 Gogs Version: <IP_ADDRESS>1
I use the Github Desktop Client now but did try it with Cong and gitG aswell. after changing the status to private, it just worked ^^"


feat: support data transfer protection in HDFS artifacts (#13482)

Fixes #13482
Motivation

As shown in https://github.com/argoproj/argo-workflows/blob/main/examples/hdfs-artifact.yaml, I am working on storing artifacts in HDFS. In my environment, the HDFS cluster has dfs.data.transfer.protection set to authentication. When I run the example, I encounter a read: connection reset by peer error.
Modifications

The HDFS client supports the data transfer protection option, which can be configured to authentication, integrity, privacy, or left empty, as detailed in this pull request. With this configuration, the issue described above is resolved.
This feature is available in versions v2.4.0, v2.3.0, v2.2.1, and v2.2.0 (see commit). Since we are using version v2.4.0 of the HDFS client (as specified here), we can utilize this feature.
Verification

Referring to the hdfs-artifact.yaml example, you can specify the value of artifacts.hdfs.dataTransferProtection as 'authentication', 'integrity', 'privacy', or leave it empty.
  - name: print-message
    inputs:
      artifacts:
      - name: message
        path: /tmp/message
        hdfs:
          dataTransferProtection: authentication

If an incorrect value is provided, the following error will occur.
$ kubectl get workflow
NAME                  STATUS   AGE     MESSAGE
hdfs-artifact-td82h   Failed   33m     invalid spec: templates.artifact-example.steps[1].consume-artifact templates.print-message.inputs.artifacts.message.hdfs.dataTransferProtection must be one of `authentication`, `integrity`, `privacy`, or empty

@terrytangyuan @sarabala1979
Hi, is there anything else needed to proceed with the approval? Thanks.

@Looka149 Your PR looks good. I can merge it. Only thing I'm thinking is that it may be better not to validate on these specific strings which could theoretically change, per my comment, but I may be convinced otherwise. Thanks.

@juliev0 Thank you for reviewing my PR, I agreed with your feedback and have removed the validation. Thank you.

/retest

/retest

/retest

@Looka149 assuming the CI failures aren't related to your change, would you mind adding empty commits  until the CI passes?

@juliev0 I have merged the main branch, and the CI tests have completed successfully.


updateOnly option for publication for api import

User story
Joel from BNPP PF want to publish a new API, with this Organisation account with the DevOps Toolchain using apim-cli.
The DevOps administrator want only publication in the APIM if the API already exist, in the DevOps Toolchain launched by Ansible & Jenkis the CLI cmd is configured with an option ReplaceOnly
Like in this exemple
apim.bat api import -c C:\git_repos\Test_cli_qa\cpay_special_revolving_payment_transfer\api-config.json -s qa --replaceonly
If an API with the same frontend Url and organization exist it will be replaced
If the API is not present nothing happen
Additional context
The CLI is launched in our devops toolchain with Jenkins and Awx (Ansible) the cmd line options for the CI are fixed.
We simply want to execute the CLI with an option to only update existing API.

Implementing such a parameter is not problem, but I think it should be named: --updateonly, as an existing API is updated (and for that sometimes replaced).
If the API not yet exists the CLI will terminate with a specific error code.

Implemented new toggle: -updateOnly will be part of the release.


Wrong answer using PySA in knapsack problem example

Let's figure out where the issue is!

This problem was solved in PySA.jl. It was due to a mismatch with the matrix representation convention adopted by PySA.


Rename favicons.html to custom-head.html

Users may not only want to add favicons in the head but also add anything they want, so rename favicons.html to custom-head.html can indicate the purpose of the template file.

Sounds good to me. @hszhakka Please update the relevant areas in README.md as well.

Sounds good to me. @hszhakka Please update the relevant areas in README.md as well.

OK, I have updated it.

OK, I have updated it.

There is one other place where you need to mention this:
https://github.com/jekyll/minima#includes

There is one other place where you need to mention this:

Mentioned.

@jekyllbot: merge +minor


[Event Request] Page 256 "Payment Journal" - OnAfterSetControlAppearanceFromBatch

🕮 Describe the request
In Page 256 "Payment Journal", we requiere an OnAfter-trigger in the function SetControlAppearanceFromBatch:

[IntegrationEvent(true, false)]
local procedure OnAfterSetControlAppearanceFromBatch(var Rec: Record "Gen. Journal Line"; GenJournalBatch: Record "Gen. Journal Batch")
begin
end;

Additional context
We need to set additional variables.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 12553.


unclear how to pass custom arguments and files to the container started on browser

I am able to start my container in browser using WASI on browser
But it's unclear how I can

pass custom arguments to this container.
pass files to this container (via stdin or some kind of volume that would expose a virtual filesystem from localstorage)

any guidance?

You can pass them to the container via on-browser WASI host. In our example, we construct these parameters in the following file and pass them to the container via WASI host  (browser_wasi_shim).
https://github.com/ktock/container2wasm/blob/9f60d3fdf889c4215cbfc30e3898a3690e1c4b87/examples/wasi-browser/htdocs/worker.js#L25-L43

It would be great if we could upload/download files in the demo (like how it works in JSLinux).