bluetooth: controller: Remove trailing semicolons in HCI defines.

Remove trailing semicolons from defines.
Signed-off-by: Wolfgang Puffitsch<EMAIL_ADDRESS>

Codecov Report

Merging #13228 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13228   +/-   ##
=======================================
  Coverage   48.75%   48.75%
=======================================
  Files         319      319
  Lines       46871    46871
  Branches    10835    10835
=======================================
  Hits        22850    22850
  Misses      19394    19394
  Partials     4627     4627

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e4ff80...2b4185a. Read the comment docs.

I do not see how the failing shippable tests are possibly connected to the change. How should I proceed?

recheck

I do not see how the failing shippable tests are possibly connected to the change.

They are not.


Prevent usage of findDOMNode (react/no-find-dom-node)

https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-find-dom-node.md
Facebook will eventually deprecate findDOMNode as it blocks certain improvements in React in the future.
It is recommended to use callback refs instead. See Dan Abramov comments and examples.
Rule Details
Examples of incorrect code for this rule:
class MyComponent extends Component {
  componentDidMount() {
    findDOMNode(this).scrollIntoView();
  }
  render() {
    return

  }
}

Examples of correct code for this rule:
class MyComponent extends Component {
  componentDidMount() {
    this.node.scrollIntoView();
  }
  render() {
    return
 this.node = node} />
  }
}

This is unfortunate, if you're using a third party library that does not expose the ref you are after you are left with no choice.
https://github.com/yannickcr/eslint-plugin-react/issues/678#issuecomment-419403757 explains this perfectly.
And the response is that you should disable it per line with a comment, which is not possible with standard.
https://github.com/yannickcr/eslint-plugin-react/issues/678#issuecomment-419405080
This leaves me being blocked because I'm using standard.  If a third party library doesn't provide an adequate API I have to remove my linter?


Simplify the Migration class and rename it to AbstractMigration

Renamed it to AbstractMigration based on PHP-FIG Naming Conventions.

:+1:


Example showing how to sync data to Algolia

That can either happen using subscription functions, or logic directly in the resolver code.

@marktani - we are starting this process this week. I will update this ticket as we discover things and any issues we run into. Hopefully that can be extracted out into a good set of examples and gotchas.

Any updates new updates on this?

The examples provided are only for Graphqcool backend, not for Prisma itself. Would be great if there is a solution to integrate algolia easily into Prisma.

Sorry for not updating this. It's really as simple as following their base getting started instructions in their docs. Include the npm module and follow along. I felt like this was going to be complicated, but since you index all of your data on their servers and leverage their API, it's really only about opening that access up via a resolver or several in your code base.


error: capa failed to load some rules

Description
Capa fails to load some rules, which have "description" (introduced in  https://github.com/fireeye/capa-rules/pull/137) as a statement and reports those as invalid rules.
Expected behavior:
Capa should load the rules correctly.
Actual behavior:
Capa throws an error like the following
C:\Users\rony>capa --version
capa 1.3.0

C:\Users\rony>
C:\Users\rony>
C:\Users\rony>
C:\Users\rony>capa C:\Users\rony\Desktop\02179f3ba93663074740b5c0d283bae2.exe_
loading :   3%|##                                                             | 12/368 [00:00<00:07, 47.24     rules/s]
ERROR:capa:invalid rule: c:\python27-x64\lib\site-packages\capa\..\rules\anti-analysis\anti-debugging\debugger-detection\check-for-trap-flag-exception.yml: invalid rule: unexpected statement: description

C:\Users\rony>

Versions
capa 1.3.0

Thanks for reporting! Are you using the stand-alone version?
We need to cut a new release of it, soon.

I checked both stand-alone and capa as python library.

Right, stand-alone and the pip package result in that error.
As a workaround you can run capa from source, see https://github.com/fireeye/capa/blob/master/doc/installation.md#method-3-inspecting-the-capa-source-code or comment out the - description lines.
Sorry for the inconvenience!

no problem :) and yeah I was going to that, thanks!

sounds like we'd better get 1.4 out!

fixed in newest release, https://github.com/fireeye/capa/releases/tag/v1.4.0


Release perform is not pusing images

We have all configuration set for the build and push to private registry, -DpushImage is pushing the docker images when run with normal build.
Like below
clean deploy -U -DpushImage

BUT
If we try using Release commands.
mvn release:prepare release:perform -U -DpushImage

Above is not pushing the image, Do i have to setup anything?

IIRC the maven-release-plugin runs the separate steps in forked builds, so your -DpushImage argument doesn't make it to the JVM running those maven commands. I think you can configure http://maven.apache.org/maven-release/maven-release-plugin/perform-mojo.html#arguments to have -DpushImage.
You might want to also look at having the docker image just built in perform and not prepare

You might also consider just changing the configuration of the release plugin to include the docker goals that you want executed.  For example, I use the following on my project to make sure that the image is built during release preparation (to test the image build configuration) and then pushed to the repo during release perform (to mimic deploying the other artifacts):
<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-release-plugin</artifactId>
    <version>2.5.2</version>
    <configuration>
        <!-- Modify the goals to include building and deploying the docker container -->
        <preparationGoals>clean verify docker:build</preparationGoals>
        <goals>deploy docker:build docker:push</goals>
    </configuration>
</plugin>

Here is my configuration to build, tag (short & long name) and push image during a Maven release.
<plugin>
  <groupId>com.spotify</groupId>
  <artifactId>docker-maven-plugin</artifactId>
  <configuration>
    <imageName>my-image-short-name</imageName>
    <dockerDirectory>[...]</dockerDirectory>
    <forceTags>true</forceTags>
    <imageTags>
      <tag>${project.version}</tag>
    </imageTags>
    <serverId>my-docker-server</serverId>
    <registryUrl>docker.my-company.com</registryUrl>
    <resources>[...]</resources>
  </configuration>
  <executions>
    <execution>
      <id>build-image</id>
      <phase>package</phase>
      <goals>
        <goal>build</goal>
      </goals>
    </execution>
    <execution>
      <id>tag-image</id>
      <phase>package</phase>
      <goals>
        <goal>tag</goal>
      </goals>
      <configuration>
        <image>my-image-short-name:${project.version}</image>
        <newName>docker.my-company.com/my-image-short-name:${project.version}</newName>
      </configuration>
    </execution>
    <execution>
      <id>push-image</id>
      <phase>deploy</phase>
      <goals>
        <goal>push</goal>
      </goals>
      <configuration>
        <imageName>docker.my-company.com/my-image-short-name:${project.version}</imageName>
      </configuration>
    </execution>
  </executions>
</plugin>

how to build docker image while release:prepare release:perform.
my docker maven plugin is as follows

com.spotify
docker-maven-plugin
0.4.1

XXXXXXXXXXX
src/main/docker

/
${project.build.directory}
${project.build.finalName}.war

closing as @cthiebault and @brianshowers comments both mention good ways to configure the plugin or release-plugin to accomplish this goal.


82 loghashes

Documenting all the zero-topic hashes for every event in the libraries
Closes #82

Codecov Report

Merging #83 into master will decrease coverage by 0.12%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   98.92%   98.79%   -0.13%
==========================================
  Files          26       26
  Lines        2412     2412
  Branches      365      365
==========================================
- Hits         2386     2383       -3
- Misses          0        3       +3
  Partials       26       26

Impacted Files
Coverage Δ

TokenLib/truffle/contracts/ThrowProxy.sol
100% <100%> (ø)
:arrow_up:

...okenLib/truffle/contracts/TokenLibTestContract.sol
100% <100%> (ø)
:arrow_up:

TokenLib/truffle/contracts/TokenLibTestSpender.sol
100% <100%> (ø)
:arrow_up:

TokenLib/truffle/contracts/BasicMathLib.sol
40% <0%> (-60%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbc4d40...9798dd0. Read the comment docs.


Set STS_DEFAULT to 43200 (AWS default)

The STS_DEFAULT should be the same as AWS's value:
http://docs.aws.amazon.com/cli/latest/reference/sts/get-session-token.html
Replace the help string for --duration by the AWS help  of
aws sts get-session-token for '--duration-seconds'

My final vote is to remove STS_DEFAULT completely. Then, in each case of https://github.com/broamski/aws-mfa/blob/master/aws-mfa#L212-L245, set the default value if args.duration is empty.

So, am I implementing this changes or are you @kenden ?

I will take a look today. (If I don't, please don't wait on me).

@broamski I rebased.
Now setting args.duration to defaults it is empty, as you suggested.


Add a template for soundcloud links

This fixes #51
Adds a template for SoundCloud track links, similarly to the already active YouTube video links

SoundCloud track links aren't distinguishable from other SoundCloud pages, they just follow an author and a title pattern. That's why the redirect link check is implemented with a regex as opposed to just checking for certain keywords like with the other template implementations.

Branch is now even with the master branch

Perfect thank you :+1:


Add fuzzer for FulcioVerifier

Summary

Add fuzzer for FulcioVerifier, FulcioCertificateVerifier and SigningCertificate class
Release Note

Documentation

@AdamKorcz

@arthurscchan Can you change the title (including in the git commit message) to indicate fuzzers in plural?


Use collections.abc.Coroutine for asyncio.iscoroutine() when available.

This should help to resolve issues like #233.
Should I also include 'collections.abc.Generator'?

Not every generator is a coroutine.

Not every generator is a coroutine.

That was the original request in #233. However, the newly added collections.abc.Coroutine should be enough.

LGTM

This PR was merged in 3a09a93277afc2cdb43badf92a2c85c2789813f6.


Image import: Don't re-zero PDs

This change enables qemu-img's --target-is-zero option. Since we're writing to new persistent disks, we don't need to re-zero the destination.
This table shows the elapsed  time (minutes:seconds) for running daisy_workflows/image_import/inflate_file.wf.json against four different disk files. Overall, applying this PR results in ~2x speedup for inflation. Notably, this speedup includes file types other than VMDK; the one VHD example had a nearly 3x speedup.

FileGB
DiskGB
Type
Operation
Duration

24
82
VMDK
Legacy
33:47

24
82
VMDK
NoZero
17:54

24
82
VMDK
NoZeroS512
17:34

24
82
VMDK
Native
1:58

2
10
VMDK
Legacy
5:14

2
10
VMDK
NoZero
1:59

2
10
VMDK
NoZeroS512
1:51

2
10
VMDK
Native
0:34

0.3
10
VMDK
Legacy
1:45

0.3
10
VMDK
NoZero
0:56

0.3
10
VMDK
NoZeroS512
1:05

0.3
10
VMDK
Native
0:23

31
31
VHD
Legacy
22:10

31
31
VHD
NoZero
8:12

31
31
VHD
NoZeroS512
7:52

NoZero: This PR, with the -S 512 flag omitted.
NoZeroS512: This PR, with the -S 512 flag included.
Legacy: Before this PR
Native: Using the disks.insert API.

Can we have a source saying that it's guaranteed that the new disk is zeroed? Thus, once that assumption became false, people are able to find it.

@dntczdx, good idea. Added a link to the docs that say new PDs are blank.


Fix Operation class to allow unknown attributes

lxd 3.0.0-beta{x} grew a new feature in that the operation metadata
includes a 'description' tag.  This breaks pylxd, and so this fix adds
the 'description' key, and also then makes the class more robust to
handle unknown attributes in the future.  Note that ALL the other
classes got this fix in 2.2.4.
Fixes bug: #284

Codecov Report

Merging #285 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
+ Coverage   97.25%   97.27%   +0.01%
==========================================
  Files          11       11
  Lines         728      733       +5
  Branches       84       84
==========================================
+ Hits          708      713       +5
  Misses          6        6
  Partials       14       14

Impacted Files
Coverage Δ

pylxd/models/operation.py
96.42% <100%> (+0.77%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d76bb3d...4c85d93. Read the comment docs.


[SPARK-28773][DOC][SQL] Handling of NULL data in Spark SQL

What changes were proposed in this pull request?
Document NULL semantics in SQL Reference Guide.
Why are the changes needed?
Currently Spark lacks documentation on how NULL data is handled in various expressions and operators. This is aimed at addressing this issue.
Does this PR introduce any user-facing change?
Yes.
How was this patch tested?
Tested using jykyll build --serve

Test build #110333 has started for PR 25726 at commit 8e7f9cd.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15324/
Test PASSed.

Test build #110333 has finished for PR 25726 at commit 8e7f9cd.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
.tclass
.tsclass
.tsclass th
<!-- .tclass tr
.tclass th

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110333/
Test PASSed.

Test build #110334 has started for PR 25726 at commit f698272.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15325/
Test PASSed.

Test build #110334 has finished for PR 25726 at commit f698272.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110334/
Test PASSed.

cc @gatorsmile

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15347/
Test PASSed.

Test build #110359 has started for PR 25726 at commit 4246bf7.

Test build #110359 has finished for PR 25726 at commit 4246bf7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110359/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15356/
Test PASSed.

Test build #110369 has started for PR 25726 at commit 4f2f3a6.

@gatorsmile Many thanks for correcting the doc. It looks fine to me.

Test build #110369 has finished for PR 25726 at commit 4f2f3a6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110369/
Test PASSed.

Thanks! Merged to master

@gatorsmile Thanks a LOT for your help with the writeup.


FF returns FF22062: Negative numeric value... for large numeric input parameters

When passing a JSON payload that contains parameters to FireFly (e.g. to deploy a contract that has constructor parameters) evmconnect returns FF22062: Negative numeric value is invalid for component %!!(MISSING)s(uint16=256)%!!(MISSING)(EXTRA string=[0]) if the numeric parameter exceeds the maximum size of a float64.
This appears to be because Golang deserialises large JSON numbers to float64 when deserialising to an interface{}, and silently loses any precision caused by the JSON number exceeding the maximum representable value of a float64.

I've done most of the work to fix this under https://github.com/hyperledger/firefly-common/pull/147 and https://github.com/hyperledger/firefly-signer/pull/76. PRs for other repos such as firefly-evmconnect and firefly-transaction-manager will be needed to pull in the updated firefly-common and firefly-signer packages.

Thanks for the work and context on this one @matthew1001!
This fix is important for all consumers of FireFly and I think warrants a new patch release to v1.3.2.
Things that I would love to be figure out as part of this work for v1.3.2

[ ] Verify that the generate OpenAPI contract interface enforce strings for all integers on /invoke and /query calls
[ ] Upgrade FireFly core to the latest firefly-common and verify in all the places where this fix might apply

The first place I would look at would be the /contract/invoke api flow

[ ] Verify that this fix also works for contract listeners, so emitting an event with
[ ] This issue has look quiet closely at the EVM path, but we also have Fabric and Tezos (fyi @denisandreenko ) to look at
[ ] Look at the Javascript based tools in FireFly that might have the same issue

The node sdk when invoking APIs...
The Sandbox UI
DataExchange... try sending a message with a large number in the data payload...

[ ] FireFly CLI has a deploy command where you can specify constructor parameters this might have the same problem and will need updating to the latest FireFly Common as well
[ ] Documentation to explain to users that the safest way to pass large numbers into the system is to keep them as strings

This is now completed! Thanks @matthew1001


[chore] Explain how Daily Digest works

Can you please comment on this issue how currently does daily digest work?

This is implemented using gen_daily_digest.py management command. In crux it does the following:

Show random results if we don't have historical information about users
If we have historical information it generate articles from specific categories {E.g. Looks at last 14 days interactions for making this decisions}


Support for recipe name abbreviations

Often times recipes have very long names, like install-dev-dependencies.
It might be nice if just could allow you to run these recipes with less typing.
One idea is to have a wildcard character:
some-long-recipe:
  @echo Doing stuff...

strip-binary:
  @echo Stripping binary...

$ just so~
Doing stuff...
$ just s~
error: `s~` is ambiguous, possibilities are `some-long-recipe` and `strip-binary`

I think this is probably unnecessary. If anyone wants this, feel free to comment and I'll open it and implement it.


Client "npm i" failing

Describe the error/difficulties:

Trying to do "npm i" on client throws dependency issues with redux and redux-thunk. After bypassing that there's "node-sass" and "node-gyp" build errors at the end of the "npm i" causing it to fail.

What have you done:

Re-installed Python, node and Visual Studio
Tried --force, --legacy-peer-deps and downgrading/upgrading respective packages
Deleted node modules and retried "npm i"
Reconfigured Path env to include Python and VS paths
Added python.exe to npm config
npm i -g node-sass
npm cache clean --force
npm install --global windows-build-tools
Tried almost everything in this

I am new to MERN but understand enough to be able to customize this code if I can get it to run. But the client side "npm install" process isn't executing without errors. Is this a local error on my behalf or a problem with node-sass? I have my environment paths and installs already configured. Any help would be appreciated if possible. Thank you.

I faced the same problem. On the client side, I use - npm install --legacy-peer-deps. This command fixed my problem.

i have the same issue.


Doorbird add Audio stream

Hi, can someone help me, how can I add audio stream. On the internet I found the following, but how do I insert it correctly?
ffmpeg -re -f mjpeg -i<EMAIL_ADDRESS>-i<EMAIL_ADDRESS>

Do you know what codec inside your audio? You can try something like this:
streams:
  camera1:
  -<EMAIL_ADDRESS>  -<EMAIL_ADDRESS>
Or use one exec source

Can this help?

Have you tried my example?

Yes, unfortunately to no avail

I found the following on reddit.
ffmpeg -re -rtsp_transport tcp -i rtsp://doorbirduser:doorbirdpass@yourdoorbirdip:8557/mpeg/media.amp -f mulaw -ar 8000 -i<EMAIL_ADDRESS>-f matroska - | ffplay -
But I don't know how to use it.

Can you explain to me how to use exec Source properly?

Like in my example. Go2rtc streams can have any sources from any types

This works for my doorbird, hope it helps
streams:   doorbirdaudio: exec:ffmpeg -f mulaw -ar 8000 -i<EMAIL_ADDRESS>-f rtsp {output}   camera.gate:     -<EMAIL_ADDRESS>   - ffmpeg:doorbirdaudio#audio=opus

This works for my doorbird, hope it helps
streams: doorbirdaudio: exec:ffmpeg -f mulaw -ar 8000 -i<EMAIL_ADDRESS>-f rtsp {output} camera.gate: -<EMAIL_ADDRESS>- ffmpeg:doorbirdaudio#audio=opus

Can you please send it as formatted code? And what is camer.gate?

@fergalom why you using transcoding to opus. It have no any point. You already has PCMU codec, supported in WebRTC.

Thanks for re-formatting as code, thought I had pasted in correctly.
It seemd to be the only way I could get it to work for my use case (WebRTC / frigate) on homeassistant but I'm no expert so happy to try an easier approach.

Hi,
I'm also using go2rtc together with Doorbird. My Doorbird completely crash after some time. So Keypad, RFID and Camera doesn't work anymore after a period of time if go2rtc is activated.
Does anyone have the same issue or an idea on how to fix it?

Please reopen issue if you have other questions.

It's better to continue all discussion about this camera model in single place https://github.com/AlexxIT/go2rtc/issues/1060

@fergalom @artur90226
Please see #1060
Maybe you can also help improving backchannel audio for doorbird devices?


list: refactor command options & move --unbrewed switch

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?
[x] Have you successfully run brew man locally and committed any changes?

Rearrange the logic so this command behaves more predictably and errors out where it should. Also move the --unbrewed switch to brew --prefix which seems like a better fit. It now operates in one of these modes:

(no named args): list all installed formulae/casks, in columns or a list
(with named args and none of the options below): list files or artifacts for specified formulae/casks
--full-name: show full names of formulae/casks, either all installed or only those specified, in columns or a list
--versions: list installed or specified formulae/casks with their version numbers
--pinned: only list any or specified pinned formulae

Review period will end on 2020-11-27 at 22:21:28 UTC.

Review period ended.

Thanks @EricFromCanada!


Tests with failures in both test method and cleanup method report only the cleanup failure.

We're running our test cases with JUnit and using the @Before and @After annotations to do setup and cleanup.  When a test fails in setup or the test method, it will sometimes ALSO fail in cleanup.  One of the things we like about Allure is that it reports these double-failed tests as only a single failed test, maintaining the accuracy of the failure count.
However, recently we've noticed that the one failure that is being reported is the failure in the cleanup method -- the LAST failure, not the first one.  It would be strongly preferable to report the first failure, as it is likely the cause of the second one.

@dsafar thanks for suggesting!
I afraid there is a few different opinions about this problem. Someone think that only last failure is important because it finally fail the test (an example - you can catch first failure and continue the test execution), but other people think that first failure more import because it is the reason of other failures.
I personally like your proposition - IMHO each test should contains only one failure (and maybe few cleanup unimportant failures).
Any ideas how we can solve the problem and don't break other people?

IMO failures in setup or cleanup are different from failures in test methods, and I would prefer to see them reported differently.
Interaction with the functionality under test should all be contained in the test method, which means that a failure in the setup method doesn't actually mean the test failed -- rather, the test couldn't even be executed, because some other functionality that was prerequisite to it failed.  There should be a different test case testing that prerequisite functionality, which we would expect to be failing in its test method because of this defect.
Similarly, if the setup and the test method pass, but a failure occurs in cleanup, then the functionality under test is working fine -- technically, the test passed, but some other functionality necessary to return the environment to its default state is broken.  Again, I would expect to see another test case testing this functionality specifically and failing.
That may be a bit much to ask for -- it's a fundamental shift in how we view what "passing" and "failing" mean and I'm not aware of a reporting tool that actually does it that way.  Some thoughts on this, assuming the technical challenge of detecting and differentiating the two failures is minimal and this is really a question of deciding what the right thing to do is:
I see two main options here to satisfy my request and the needs of other users who prefer it the way it is:

Let the user decide.  This could be controlled by a setting (report first failure vs. report last failure) in the pom file or passed in by Jenkins (or equivalent for users who aren't using Maven/Jenkins).

Report both, but only count one.  For instance, when I click through from the summary to the testsuite to the test case, perhaps the test case panel would have two red boxes with stack trace buttons on it instead of one -- either setup and cleanup or the test method and cleanup.  The two should be listed in the order they occurred and clearly labeled so we can tell whether the first one is from the setup method or the test method.  As I mentioned above, knowing whether the test method itself failed is important to knowing whether the failure indicates that the functionality under test is broken or something else is broken.

Between the two, I think reporting both is preferable (although the two are not mutually exclusive; the setting could offer values of "first", "last", or "both").  It would show me at a glance both errors/exceptions generated by the test case and let me decide which one is more important, and also what kind of issue it may have caused later in the test so I can think about whether that's okay or whether additional work is needed to ensure that cleanup doesn't experience that kind of issue when a previous method fails in that way.

I would love to see the second idea. We are using the clean-up also for checks that should be done after each test (like checking if the application does not show an error). Currently these exceptions are shown nicely in JUnit and Allure. But this exception overrides the error that was thrown by the test itself.

check out brand new TestNG adaptor https://github.com/allure-framework/allure-java


(REQUEST) Ebikore+ Amagami - PS Vita Edition

I would like to request a script for this game.
(Thought the ps vita version would be better for its resolution)
Thanks.

There is a script out for the Vita and PSP versions. This can be closed now.


Update glam to 0.27

Hopefully they don't start releasing breaking versions every week :sweat_smile:

indeed!


Consider introducing CHANGELOG.md

I know that there is a releases page, but it would be nice if there were a changelog file in the project directory breaking changes between releases.
Possible options include using standard-option for automatic changelog generation.

Oh, this sounds like a good idea! I think for now we'll just keep changes at the "releases" page because we don't make very frequent changes, especially now that we've hit version 1.0.
That being said, communicating new features in Stripe.js and react-stripe-elements is a broader goal that we're working on. Thanks for the tip!


Front Door + MAPI

I believe we should add more clarity (or a section) regarding integration of Front Door with APIM's Management endpoint.
The default host does not apply for MAPI, therefore, if we follow the same dev portal instructions it will be misleading for the customers.
Thank you!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 55019441-f9cb-aeba-08ca-b74b96292120
Version Independent ID: 8dede9a1-be65-8a16-f871-0e37823f150c
Content: Configure Azure Front Door in front of Azure API Management
Content Source: articles/api-management/front-door-api-management.md
Service: api-management
GitHub Login: @dlepow
Microsoft Alias: danlep

@tiago-msft
Thanks for your feedback! We will investigate and update as appropriate.

@ferantoMSFT - Do we want to document using Front Door in from of management endpoint? Thanks!

@ferantoMSFT @dlepow Developer Portal admin mode and AAD functionality has a hard dependency on the management endpoint. If we are showcasing the optional step for developer portal, we need to add one for management endpoint too.

I created a backlog work item to add this information when we next update this content. According to our usual process, I'll now proceed to close this issue. If you have questions or want to continue the discussion, please feel free to create another issue. Thanks again for pointing this out.
#please-close


setup of logger for slack java (logback / slf4j )

By default following the example of slack web api, the dependencies like slf4j is necessary to include,
then it is needed to output and persist a log file in drive.
if there is any sample/documentation for slack logger setup for logging purpose both info or debug level (slf4j? or logback)
it could write a log file in a folder \log which the log folder is next to executable main program of .jar for sending msg to slack channel.
guess it needs an appender and config.xml (logback.xml) and add dependencies to pom file
got a main program and some threads will be generated by main function per message connection to be logged to a single logfile.

Hi, @MING-LI! Thank so much for writing in! 🎉
We have a "Use Logger" section in our "Bolt Basics" guide within the Java SDK docs that touches on using either logback-classic or SLF4J with some code snippets. I hope this helps!

now logback dependencies setup in pom, but the log file doesnt show.
wonder what get wrong, I have try to use filewriter class of java which can write to the desired log destination to eliminate the without access rights factor.

org.slf4j
slf4j-simple
1.7.36

ch.qos.logback
logback-core
1.4.0

ch.qos.logback
logback-classic
1.4.0

Hi @MING-LI, there is an example of logback configuration in the java starter template this is what the logback.xml file looks like.
I believe a fileAdapter may be required in order to log to a file.
Hopefully this helps you out 🗺

Not sure what still missed out, still no progress
previously my post test should eliminate the write access by writing a test file out with test text inside.
Here is how my logback.xml looks:
`

<appender name="FILE" class="ch.qos.logback.core.rolling.RollingFileAppender">
    <file>${LOG_ROOT}/${LOG_FILE_NAME}.log</file>
    <rollingPolicy class="ch.qos.logback.core.rolling.SizeAndTimeBasedRollingPolicy">
        <fileNamePattern>${LOG_ROOT}/${LOG_FILE_NAME}.%d{yyyy-MM-dd}.log</fileNamePattern>
        <!-- each archived file's size will be max 10MB -->
        <maxFileSize>10MB</maxFileSize>
        <!-- 60 days to keep -->
        <maxHistory>60</maxHistory>
        <!-- total size of all archive files, if total size > 100GB, it will delete old archived file -->
        <totalSizeCap>10GB</totalSizeCap>
    </rollingPolicy>
    <encoder>
        <pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n</pattern>
    </encoder>
</appender>

<root level="debug">
    <appender-ref ref="FILE" />
</root>

`
Here comes the pom.xml snippet:
<dependencies>         <dependency>             <groupId>org.slf4j</groupId>             <artifactId>slf4j-api</artifactId>             <version>1.7.36</version>         </dependency>         <dependency>             <groupId>org.slf4j</groupId>             <artifactId>slf4j-simple</artifactId>             <version>1.7.36</version>         </dependency>         <dependency>             <groupId>ch.qos.logback</groupId>             <artifactId>logback-core</artifactId>             <version>1.4.0</version>         </dependency>         <dependency>             <groupId>ch.qos.logback</groupId>             <artifactId>logback-classic</artifactId>             <version>1.4.0</version>         </dependency>         <dependency>             <groupId>com.slack.api</groupId>             <artifactId>slack-api-client</artifactId>             <version>1.24.0</version>         </dependency>		 </dependencies> <build> 		 ...other details etc... </build>

@MING-LI A few comments on your configuration:

When you use logback, you don't need to have slf4j-simple. You can (and perhaps should) remove it.
The latest version of logback is primarily compatible with slf4j-api 2.0. So, using the latest versions for your app may be safer. See also: https://github.com/slackapi/java-slack-sdk/issues/1034

I haven't checked your log configuration on my end but when you are stuck with logging, I generally recommend starting with the examples in the library website (logback-classic in this case) and then gradually modifying it.


Exception:Object of class MongoId could not be converted to int

When I write below code,
$users = User::all()->toJson(); // or:
$users = User::all()->toArray(); //

Then:
ErrorException in Model.php line 2875:
Object of class MongoId could not be converted to int

Is this a bug? I want to get user id in array / json, what should I do?
Thank you :smile:

You have to set in Your model public $incrementing = false;. This will avoid casting for primary key IMO Jenssegers\Mongodb\Model is missing this. This happens because getCasts method is invoked and primary key gets int cast.
    /**
     * Get the casts array.
     *
     * @return array
     */
    protected function getCasts()
    {
        if ($this->incrementing) {
            return array_merge([
                $this->getKeyName() => 'int',
            ], $this->casts);
        }

        return $this->casts;
    }

@tabbi89 Thank you very much :+1:


fix: maintain Unity's copyright notice

IANAL but my understanding from the MIT license,  is that we cannot modify unity's copyright notice.
But we can add our own copyright notice.
This should fix this issue

Changes I suggest: Either 1. Dont be explicit about what your and vishals copyright covers. Usually you just state Copyright (c)  name. If you want to be explicit, include EVERYONE. Such as "Modifications Copyright (c)  Vis2k, Paul and Contributors. This is what for example CoreRT has opted for. https://github.com/dotnet/corert/blob/master/LICENSE.TXT

:tada: This PR is included in version 3.11.8 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[cc2538] set frame pending correctly

The commits set frame pending correctly for cc2538 platform.
Only works when OPENTHREAD_CONFIG_CC2538_USE_RADIO_RX_INTERRUPT=1, not implemented otherwise.
This is one of TODOs of PR #3785 .

@sjlongland, can you help review and provide your thoughts?

@srickardti would you please help to take a look?

I note only the OPENTHREAD_CONFIG_CC2538_USE_RADIO_RX_INTERRUPT=1 case is handled, I wonder if we ensured that the NVIC channel for the radio was left disabled (whilst enabling the interrupt flags on the radio module itself), would that enable the same logic to work for OPENTHREAD_CONFIG_CC2538_USE_RADIO_RX_INTERRUPT=0?
Is there a down-side to not implementing it for the pure polling case?

Is there a down-side to not implementing it for the pure polling case?

Yes and thanks for the idea :+1:
I have included in the latest commit the implementation for the pure polling case. Please take a look.
@sjlongland

@sjlongland, can you help review this again? Thanks!


302 on trying to install jdk

$ scoop install oraclejdk
Installing 'oraclejdk' (10.0.1-10) [64bit]
The remote server returned an error: (302) Moved Temporarily.
URL http://download.oracle.com/otn-pub/java/jdk/10.0.1+10/fb4372174a714e6b8c52526dc134031e/jdk-10.0.1_windows-x64_bin.exe#/dl.7z is not valid
$ scoop install oraclejdk-lts
Installing 'oraclejdk-lts' (8u172-b11) [64bit]
The remote server returned an error: (302) Moved Temporarily.
URL http://download.oracle.com/otn-pub/java/jdk/8u172-b11/a58eab1ec242421181065cdc37240b08/jdk-8u172-windows-x64.exe#/dl.exe is not valid

I think this belongs here.

@rasa I think there might be a redirection issue in some scenarios. I have not been able to reproduce the errors, and I cannot find any errors in the manifests. One user experiencing the problem had upgraded from Windows 8 to Windows 10 but scoop was installed in Windows 8. Not sure how that would be relevant…
Maybe we can reopen this issue to allow tracking of the specifics and find a solution for those effected?


[web demo] PHP lexer does not work

I tried out the web demo with the PHP lexer, and it just didn't work. Why? Is it related to the breaking changes introduced in PHP 8 and 8.1? (Other lexers do work as expected)

Reference code:
#[Attribute]
class MyAttribute
{
    const VALUE = 'value';

    private $value;

    public function __construct($value = null)
    {
        $this->value = $value;
    }
}

Turns out, I forgot to include <?php at the start.


Support modal interactions

Modal support would be really convenient. A basic struct for modals would be great.
#[derive(ModalDerive)]
#[modal(title="my modal's title", custom_id="this_will_be_used_in_the_parser_too"]
struct MyModal {
    // The fields will automatically get wrapped with actionrows maybe?
    #[modal_field(custom_id="foo", label="Foo", value=1_u8, type=select_menu)]
    my_modal_field: u8,
    #[modal_field(custom_id="bar", label="Bar", max_length=20, text_input_ style=short, type=text_input)]
    my_text_input_field: String
}

Hello! Modals are much simpler than commands, I don't think that derive macros are necessary for this (especially since it is complicated to maintain). What do you think about a method similar to CommandInputData::parse_field instead?

A parser is really the thing I'm looking for

A parser is what I would be looking for too. Creating them with a macro would be nice, parsing them with a macro would be amazing.

modals work with components, why not make it so that it works with components and modals
here's a PoC:
#[derive(ComponentModel, CreateComponent)]
struct MyComponents {
    #[component(label = "just the beginning", kind = ComponentType::Button)]
    // custom_id is my_component
    my_component: Vec<String>, // values, can be anything that impl parse from String, empty for buttons etc
}

// create usage
interaction_client.create_response(.., &Response {
        ...
    }.add_component::<MyComponents>::() // provided by CreateComponent trait
)

// parse usage
MyComponents::from_components(
    ComponentInputData::from(message_component_interaction_data)
)?


Can't Reset Default Skin

LMS 8.2.0 running on PiCore. Sizing issues on Android tablet running Firefox - too large for screen. I could finally resize if I went into Material Skin Interface settings and pinched. Tried to revert to default skin. I only get a bit of the layout now, and the rest is blank. Same is true if I go to the LMS setup page, but not if I go through the link in PiCore.
I deinstalled the Material Skin plugin. No change. Now in the interface list, there is Default, Light, Classic, and FR.
Please advise.
Thanks!

This has nothing todo with Material. Sorry, but these sort of questions belong on the LMS forums.
BTW, there is a APK for Material that will alloy you to set a zoom level - Material APK


[Feature Request]: How to do  paging querys for SqlSever or Oracle?

Is this support paging querys for SqlSever or Oracle?
the limit，offset  is not supported by these databases。

Both Oracle and SQL Server support offset and fetch first like this:
select(foo).from(bar).offset(4).fetchFirst(4).rowsOnly()

Thanks for your replay.  But  this failed for me：
And the sql  from above code is  like this:
SELECT
	*
FROM
	TABLEA
WHERE
	upload <> 1 offset 4 ROWS FETCH FIRST 4 ROWS ONLY

This sql will failed  execute  in sqlserver 2012

[42000] [Microsoft][SQL Server Native Client 11.0][SQL Server]'offset' 附近有语法错误。 (102)
[42000] [Microsoft][SQL Server Native Client 11.0][SQL Server]在 FETCH 语句中选项 FIRST 的用法无效。 (153)

You may need to add an order by expression in SQL Server. See the docs here:
https://docs.microsoft.com/en-us/previous-versions/sql/sql-server-2012/ms188385(v=sql.110)


Expansion of Path tool

There are a few expansions to the Path tool that would be useful for me. I'm not sure how doable these are, but this can just be a starting point for discussion.

Take an existing Path and break it - creating two Path entities, but they are still "connected" at the split point.
Connect existing Vertices into a Path (i.e. snap the Path drawing tool to the nearest Vertex within a tolerance).
Close a Path to create a polygon - possibly consisting of multiple connected Paths, snapping would be required here also.

The idea of splitting a path at a node was discussed in the meeting we had together today.

What does it mean for a path to be broken but still connected?

I believe that has been clarified. A node can indicate a split between two path without actually splitting the path in terms of how it is visualized or interacted with (though you probably want to show some visual hint that a split is present).

This gets back to one of the original capabilities that we decided not to try for in round one. Other software indicate this by giving these nodes a different name and visualization. i.e. Feature Vertices with a larger dot. A primary use case is having arcs along a polygon that are used for refinement or assigning boundary conditions.

Related to my description of XMS functionality in #41

This is my general summary of the path forward (at least the way that I see it):
Create a distinction between vertices and nodes

nodes are the stop and end points on a path (a polygon has one, a line has two)
vertices are the intermediate points along a path that are not a start or end point
in other software platforms this is visualized by vertices being much smaller than nodes
if a node or vertex is moved, the connecting paths will also move (it will remain connected)

Add ability to convert between nodes and vertices
Add ability to define a polygon as a series of connected paths.

usecase: I have a polygon that defines the exterior of a region to be meshed. I want to specify boundary conditions on only certain segments of the polygon. To do this, I would 'break' the polygon into multiple edges, specify attributes to each individual edge, but still maintain a single polygon to feed to a mesher.

Add ability to convert between nodes and vertices

This has been completed
The remaining two steps have not been worked on:

Create a distinction between vertices and nodes
Add ability to define a polygon as a series of connected paths.


[FEAT] Migrate shared configurations only

Is your feature request related to a problem? Please describe.
migrate shared (Module) configurations only
Describe the solution you'd like
Currently this helps with 'like for like' migrations. However often times the base system is already set up and I just need Virtual Servers, Awaf Policies, AFM Policies, APM configurations ect ect to be migrated. Often times I am moving from one system to another and the Hostname, Device Cert, Networking (VLANs and Self IPs) are already configured because they are changing from the Legacy system to the newly deployed system.
Describe alternatives you've considered
Currently I keep dropping back to using SCF files and the associated .tar file to do migrations because I can pull all the Clustering, Networking, Hostname ect out of the file and just merge in what I want. This has limitations as the full ASM policies are not there.
Additional context
I would like some where for it to be an option asking what data you want to bring over from the Legacy system and uncheck or easily remove system configurations like Networking, Clustering but ensuring that full configurations for each module come over.

Hello @dwigley
Thanks for your feedback. Have you had a chance to look into the per-app migration flow? I know this only supports LTM+SSL cert&keys but we would like to add ASM policy eventually too.
Thanks

Good afternoon,
I have looked at that but it seems to want to do everything via AS3 and create a JSON file. I usually don't have a client that is able or willing to do things the new way they just want good ol TMOS (tmsh load sys config...)

Hello @dwigley
You could technically use Journeys Per-App (using AS3) to do the migration, but then nobody forces you to use AS3 to manage the migrated config :) You can also use the good old TMOS. It's not what I recommend but this would work fine too!
Best,


Search box visual tweaks

Made some changes to the search box:

Adjusted spacing inside the box
Detached the search box from the titlebar (as explained here)
The search box is now 8px further to the left, in case the scrollbar is always enabled
Made some controls use default properties, so that they'll adjust nicely to the 2.6 styles

Other: the search box and command palette now use OverlayCornerRadius
Before/After:

Is this design ok?

@cinnamon-msft for the design sign off, but I sure think it looks cool.
<showerthought> Plus, if it's detached, then we could add a little handle somewhere and allow the user to just like, drag it wherever they want in the Terminal. That would solve the whole "dock to top" vs "dock to bottom" debate! I'm absolutely not saying you should do this now though. That's just a crazy idea.</showerthought>

I dig it. :) The only thing I'm not too keen on is that the close button is larger than the rest of the buttons. Is that just the default properties being applied?

I suspect that that is "correct" -- the close button is not a search option!

Right.. but I haven't found other search dialogs that have a larger close button compared to the other options :/

It was inspired by the InfoBar, which has a larger button that has the same space on top, right and bottom.

Would either of these look better?
A) consistent 8px menu padding

B) equal spacing around the close button

The brushes can be done in a different PR, because it will take a bit longer. I wanted to use the default ones from menus, but in light mode it's hard to see which button is selected.
Is the design ok as it is now?

<aside> It'd be cool if there was a shadow underneath the search dialog, like there is for the command palette. Almost certain there's an existing issue for this...

@msftbot make sure @cinnamon-msft signs off on this one

I wonder how we got a merge conflict o_O

I wonder how we got a merge conflict o_O

It was the spellcheck PR 🤷 I think I merged it but I'm afraid that the GH conflict resolve tool secretly botched the xaml formatting. Guess we'll see...


error when running remote apply "Error: error retrieving queue: resource not found"

I'm using terratest to run tests remotely on terraform enterprise. I ran into "Error: error retrieving queue: resource not found" periodically, when executing the following code.
terraform.InitAndApply(t, terraformBootstartOptions)
Error message:

Actually, the plan was queued successfully in terraform enterprise

As best as I can tell, this is a Terraform Enterprise error. Perhaps contact HashiCorp support for more info on what the error means?


After login navbar design

After log in navbar will change and show some more valid data and need to look more professional .

I want to solve this issue , can you please assignee me!


[runtime] Enable graph command buffer in hip HAL driver

Right now we are seeing missing symbols and wrong validation regarding hipDrvGraphAddMemcpyNode. Need to have a build fixing those issues. And then enable SDXL on it to see how it performs.

Update 5/28: public release still have the wrong validation. custom build with validation turned off. Next need to run sdxl.

Closing this--we have it enabled and initial reading it's slower. Also identified a few issues to improve.


Feature/input validation

Fixes #1909
Describe the changes you have made in this PR -

Added form validation so that the page doesn't reload if the input value is empty

Screenshots of the changes (If any) -
Before

The page used to reload even if there is no value entered in the input box

After

If there is no value entered, or only white spaces are entered then the page doesn't reload and make the input borders red

Coverage remained the same at 88.019% when pulling d22682abb1f769fcc9cbcdfddf77ce0bc107b08f on dipanshparmar:feature/input-validation into c5c865f1d46d22b7c453aa3e414e2f8fb0367081 on CircuitVerse:master.

@aayush-05 please review

Imo a better way to handle this and depict the same to user is to disable the submit button on page load and with no input. Cc @satu0king

Imo a better way to handle this and depict the same to user is to disable the submit button on page load and with no input. Cc @satu0king

@aayush-05 please have a look now.

Closing this PR. Will make a new one soon with the features mentioned in #1909


Hiera return nil for false value

In a yaml file:
myvar: true
Query Hiera will return true

myvar: false
Query Hiera will return nil
I'm using Puppet behind, and setting a parameter to nil will make Puppet fail as the parameter is not defined.

This is solved in 421e37f2e. Just build a new version of the gem until the next version is released.

You are correct! This error appears to be coming from https://github.com/ripienaar/hiera/blob/master/lib/hiera/backend.rb#L166 because a false will fail the || and query parse_string() instead.


Fixed ECSQL scanner mem leak detected by Valgrind

Valgrind found a memory leak in ECSQL parser which was caused due to someOSQLParseNode not freed.
Tested with CLANG_SANTIZER=leak with CLANG13 which seems more accurate and performant than valgrind.

Hoping to pull this into the next addon. Can we get this reviewed?
@kabentley @rschili @calebmshafer @ColinKerr


New subcommand: agent

This would be a way to add consul-template-like functionality to gcredstash the existing template subcommand does help, but it would be helpful to add a bit more order to things and to run commands if a template has been successfully written out.
This subcommand would take an additional parameter: --config. This points at a TOML file with roughly the following schema:
table = "credential-store"
default_interval = "1h"

[[template]]
source = "path/to.tmpl"
destination = "path/to/result.conf"
mode = 0o644
owner = "foo"
group = "bar"
create_dest_dirs = true
# A list of daemons to reload if there's a change.
exec = ["foo"]

# How to reload the 'foo' daemon.
[exec.foo]
command = ["pkill", "-HUP", "foo"]
timeout = "5s"

# Put an explicit refresh period on keys. The initial template render tells
# gcredstash which template have which secrets.
[secret.key-name]
interval = "5m"
# KMS encryption context, if any
context = { foo = "bar" }

After the initial render, gcredstash will have a list of secrets and their corresponding templates, and will schedule the periodic querying of each. If any secrets have their versions incremented since the previous fetch, the corresponding templates will be marked for rendering and any reload tasks will then be executed.
An additional avenue that might be worth considering is some mechanism based on DynamoDB streams. This might be rather heavyweight, however, and I can see it only really being useful in circumstances where a particular secret must be refreshed in close to realtime. This would mean that the agent would need to either (a) listen on an SQS queue or (b) receive notifications on a HTTP endpoint. Both have their issues. An example might be where some credentials for a Docker registry are stored in a credstash table and periodically rotated and the old credentials are immediately invalidated. A secret like this would need to fetched and written out as soon as it came available.

Nah, I won't do this. The only reason for me to implement this is a legacy issue at work and credstash in all its incarnations should really be replaced with Secrets Manager or HCP Vault these days when dealing with static secrets.
It would've been a nice idea five years ago though.


refactor: add base storage factory test

Following up: #210
Moving end-to-end storage test (upload/fetch/delete) to a base test for storage factory, and leave individual op tests on storage test class.

Thanks @AnatolyPopov
Fair points. Storage Factory does give access to those interfaces and it's also configurable. Therefore, the goal of this test was to ensure configs are parsed and interfaces accessed by having an end-to-end flow.
Though, I agree Storage Factory doesn't add much and we may consider flatten the storage layers a bit (e.g. have Storage class implement configurable and storage interfaces), but this could be discussed in another thread (e.g. #177)
If we agree to discuss StorageFactory somewhere else and tackle this test later, I think we can drop this PR; but if we plan to keep StorageFactory we can redefine the scope of this test, wdyt?

I think we should reshuffle the code a bit and if we will proceed with #177 then I would maybe bring a little bit more logic there, e.g. implementing those 3 interfaces there for example and getting rid of calls to methods like fileFetcher() that are spread through the code base and do not make to much sense to me. And only after that this refactoring IMO will make sense. I would continue this discussion in #177 and first make a decision on that one, e.g. how we should proceed on that one.

As of current implementation tests are in the places where they should be.


Error: Not allowed to load local resource

After building with electron support, I start the server using npm run dev, then open electron with npm run app in a new shell, but get Not allowed to load local resource: file:///Users/myusername/myappname/app/dist/index.html in the electron window dev console.
electron version: 1.4.7
node version: 6.3.1
thanks for any help!

fixed, I changed it to load index.html from http://localhost:4000


Client-side prepared statements

Are client-side prepared statements supported?
https://docs.singlestore.com/managed-service/en/developer-resources/connect-with-application-development-tools/using-prepared-statements.html
If yes, how can it be enabled?
If no, what would be a good approach for a PR be like?

This is the equivalent of using the :text encoding for queries but we don't have emulation. Emulating would be possible if implemented but I am a bit skeptical because parameters help everyone avoid SQL injection attacks, so it seems to be troublesome to disable this for performance(?) reasons.

Turning off binary protocol is not supported?
https://docs.singlestore.com/managed-service/en/connect-to-your-cluster/connect-with-mysql/connect-with-any-mysql-compatible-tool-to-singlestore.html

As mentioned above you can use the text protocol with that option. There is no global option that would make all queries use text by default.


cmd/cue: should complain about commands declared in the wrong files

This is a bit buried in the docs:

Commands are defined in cue files ending with _tool.cue

I was following the Kubernetes tutorial, and since it made no mention of this restriction, I just added a dump command to my existing drone.cue file.
$ cue cmd dump
cmd must be run as one of its subcommands: unknown subcommand "dump"
Run 'cue help cmd' for known subcommands.

I now understand why that is thanks to @rogpeppe, but I was stuck for a good while. Perhaps cue cmd (or even most cue commands) should warn or error if any commands are defined in the wrong files.

Just realised that the tutorial does have a similar line:

Commands are defined in files ending with _tool.cue in the same package as where the configuration files are defined on which the commands should operate.

To be honest though, I skimmed much of the text, so I missed the detail :) I still think it would be useful for cue to give a more helpful error here.

It could look if a command with that name
Is defined in the normal configuration and suggest that be moved. Alternatively it could just always mention commands should be in _tool.cue files.

This issue has been migrated to https://github.com/cue-lang/cue/issues/126.
For more details about CUE's migration to a new home, please see https://github.com/cue-lang/cue/issues/1078.


Remove 'simplification' and other associated tests #1362

Description
Removed Simplification class and relevant tests associated with it. Also, moved simplify_if_constant() to symbol.py.
Fixes #1362
Completed all the tasks specified in #1362
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

[ ] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)
[x] Bug fix (non-breaking change which fixes an issue)

Key checklist:

[x] No style issues: $ flake8
[x] All tests pass: $ python run-tests.py --unit
[x] The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.
Further checks:

[ ] Code is commented, particularly in hard-to-understand areas (not required)
[ ] Tests added that prove fix is effective or that feature works (not required)

@all-contributors add @asinghgaba for code


Update coefficients for SPECpower Q3 2021

Update the coefficients to include the results of the Q3 2021 tests at https://www.spec.org/power_ssj2008/results/res2021q3/

Hi David! Thanks for adding this. Were you thinking of picking it up yourself or should we put it in the Ready To Do?

Yeah I was planning to take this one. Can you assign to me please if nobody else is going to do it over the next few days?

I've just opened https://github.com/cloud-carbon-footprint/cloud-carbon-coefficients/pull/5 which updates the SPECpower dataset. There are no changes to the coefficients from this update because all servers are in the Ice Lake arch which isn't currently covered. Something to look into after this issue.

Hi @davidmytton, upon merging the PR into the coefficients repo, we noticed that there were actually quite a few coefficients that changed. Was this intended, or were you thinking there would be no changes since the servers were all in Ice Lake?

The merge of https://github.com/cloud-carbon-footprint/cloud-carbon-coefficients/pull/5 should have no coefficients changed because they were all in Ice Lake. However, the values in the notebook don't match the values in this repo. During the course of https://github.com/cloud-carbon-footprint/cloud-carbon-footprint/issues/331 we found some discrepancies and so there was a pending task to make sure they were both the same.
I updated the data to match SPECpower Q3 2021 to make sure that the latest data was there, then https://github.com/cloud-carbon-footprint/cloud-carbon-footprint/pull/411 ensures the values match.

Thank you for the clarification. Just wanted to make sure :)


Fix tabular printing of dataset information

Motivation
When the length of the last row_data is less than 10 and greater than 0, the row_data will not be printed
Modification
When the last row_data is not empty, add to table_data

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

LGTM

大佬


pump + webpack-stream exits watch task

The combination of webpack-stream and pump exits the watch task on error during webpack execution. I used the same pattern as the uglify example here: https://github.com/gulpjs/gulp/tree/master/docs/why-use-pump
Is this most likely an issue within webpack-stream (maybe it doesn't exit correctly?) or is there any option in pump to not exit on error??? I thought pump does exactly this -> to reliably catch errors and does not exit the running watch process...

pump doesn't exit on error. it shuts down the streams in the pipeline, by calling .destroy on all of them. this sounds like an error in the module you are using.

Wouldn't be the first issue in the webpack-stream module :( Thank you for the quick reply!!! Think we are going to remove it completely soon


Check pre-existing content for changes due to Duty Support

Any triggers/timelines that existed prior to Duty Support coverage being added should be checked for changes.  Zones that have had Duty Support added so far:
Added in 6.1:

[x] Sastasha (no prior coverage)
[x] The Tam-Tara Deepcroft (no prior coverage)
[x] Copperbell Mines (no prior coverage)
[ ] The Bowl of Embers
[x] The Thousand Maws of Toto-Rak (no prior coverage)
[ ] Haukke Manor
[ ] Brayflox's Longstop
[ ] The Navel
[ ] The Stone Vigil
[x] The Howling Eye (no prior coverage)
[x] Castrum Meridianum (no prior coverage)
[x] The Praetorium (no prior coverage)
[x] The Porta Decumana (new zone)

Added in 6.2:

[ ] Snowcloak
[x] The Keeper of the Lake (no prior coverage)
[ ] Sohm Al
[x] The Aery (no prior coverage)
[ ] The Vault

re: #4250, #4684, #4936, #5115, #5116

Yes. I've been through most of this content so far and didn't notice any discrepancies besides Titan, but I can check through some of it during the long US holiday. My gut feeling is that most of it is fine with just a small number of actual changes. (Stone Vigil's second boss is completely different, for instance.)

Haukke Manor and Stone Vigil can be trivially marked as okay. They have no timelines, and the triggers all seem to be working.

The Vault seems fine as well. There was an actual change to Grinneaux, in that Faith Unmoving had an indicator added, but the action ID hasn't changed.
(It looks like I never added a trigger for the Holy Chains mechanic on Charibert though. Oops! I'll look at adding that this weekend.)

Sirensong Sea, no changes needed.


Fix: lakeFS instrumentation

docker file used wrong environment variable for credentials causing lakeFS samples repo instrumentation to be registered as "Run"

How is the name of env variable fix this issue? The env that was used was configured to to enable running lakectl commands that will work with the same lakefs instance. So I guess I am missing the main issue.

We rely on an environment variable:
func getInstrumentationMetadata() string {
	lakefsAccessKeyID := viper.GetString("installation.access_key_id")
	switch {
	case strings.HasSuffix(lakefsAccessKeyID, "LKFSSAMPLES"):
		return InstrumentationSamplesRepo
	case strings.HasSuffix(lakefsAccessKeyID, "QUICKSTART"):
		return InstrumentationQuickstart
	default:
		return InstrumentationRun
	}
}

Notebook is broken on main - unrelated to changes


Add min width to data use tab

Closes #4099
Code Changes

[ ] Add min width to data use tab

Steps to Confirm

[ ] run fides
[ ] add a system
[ ] click the data use tab
[ ] shrink then grow the size of the window
[ ] verify there is no jumping of the data use section under the tabs
[ ] add a data use
[ ] shrink then grow the size of the window
[ ] verify there is no jumping of the data use section under the tabs

Pre-Merge Checklist

[ ] All CI Pipelines Succeeded
Documentation:

[ ] documentation complete, PR opened in fidesdocs
[ ] documentation issue created in fidesdocs

[ ] Issue Requirements are Met
[ ] Relevant Follow-Up Issues Created
[ ] Update CHANGELOG.md
[ ] For API changes, the Postman collection has been updated

Looks good to me!


failed to signin: failed to create user,error:failed to create user in db,error:ERROR: duplicate key value violates unique constraint "users_email_key" (SQLSTATE=23505)

Describe the bug
When recreated casdoor pod or container, init_data.json is reloaded. It cause fronted login failed with following:
'failed to signin: failed to create user,error:failed to create user in db,error:ERROR: duplicate key value violates unique constraint "users_email_key" (SQLSTATE=23505)'

To Reproduce
Steps to reproduce the behavior:

helm install csghub -n csghub (wait for all pods ready)
login from page with root
kubectl delete pod/csghub-casdoor-xxxxxx
wait for casdoor pod ready
login from page with root again

Expected behavior
A clear and concise description of what you expected to happen.
When casdoor pod is recreated, root user can login normally.
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: ubuntu:22.04
Browser:firefox
Version: csghub helm v1.0.0

Additional context
Add any other context about the problem here.

Workaround:
# Downgrade casdoor image from 1.725.0 to 1.571.0
kubectl -n csghub patch deployment csghub-casdoor -p '{"spec":{"template":{"spec":{"containers":[{"name":"casdoor","image":"opencsg-registry.cn-beijing.cr.aliyuncs.com/opencsg_public/casbin/casdoor:v1.571.0"}]}}}}'

# Restart deploy csghub-casdoor
kubectl -n csghub rollout restart deploy csghub-casdoor

# Waiting for casdoor pod ready


Redesign About activity

Replaces the WebView with a normal layout
I've done my best to adjust existing strings for:

debug_version_fmt (-> version)
app_license
about_title_fmt (-> about_title)

Roughly follows the design from #1859

I thought there was an issue specifically for this, but it seems it was just my imagination
Added stuff

icons (Google's code and description)
link to source code
link to contributors list
libraries list their licenses

TODO

alter app_revision_fmt
localize about_libraries
use fancy Kotlin Android extensions
make an openURL method for links?
final XML cleanup

I've tested this on a real device, looks and works very well :+1:

Maybe the "Version" field should also be clickable opening the built-in change-log? I know the changelog is in the overflow menu but both Authors and License are clickable, that'd make it a consistent behavior.

Might as well get rid of the overflow menu, then?

Version field now opens changelog, overflow menu removed (2473a57)

This looks very good on my device :+1:. I'll take a better look at the source tomorrow to get this merged as soon as possible.
Thank you!

Merged, thanks for your work @williamvds! It finally looks modern now! :)


0.4.0 changelog not updated

This isn't super critical but it would be nice to not have to read the commit history.

Triage: CHANGELOG has since been updated.


The background image fails to load when accessed with a directory appended to the domain.

Command
build, new
Is this a regression?

[X] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
17.0.0
Description
Background image fails to load when a directory is present in the domain.
Minimal Reproduction
1.I created a new project using the following command:
ng new ng18 --style=scss --routing --skip-tests
2.Then I created a directory named “images” under “public” and placed an image named “001.jpg” inside it. The path to the image is public/images/001.jpg.

My website domain is similar to the following. I have created many directories on the server, each containing various projects, so I access them directly using the domain plus directory:
www.xxxx.com/test

4.My SCSS code is:
background: url("/images/bg_01.png") no-repeat center;
I tried the following method, but it failed (error occurred):
background: url("./images/bg_01.png") no-repeat center;
5.My index.html has the following base tag:

If I use something like www.xxxx.com, the background image appears, but it fails for www.xxxx.com/test.
Exception or Error
No response
Your Environment
Angular CLI: 18.1.0
Node: 18.20.3
Package Manager: npm 10.7.0
OS: win32 x64

Angular:
...

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.1801.0 (cli-only)
@angular-devkit/core         18.1.0 (cli-only)
@angular-devkit/schematics   18.1.0 (cli-only)
@schematics/angular          18.1.0 (cli-only)

Anything else relevant?
No response

ng18.zip

Duplicate of https://github.com/angular/angular-cli/issues/28050
This is working as expected and this behaviour has not changed since the early versions of the Angule CLI.

Duplicate of #28050
This is working as expected and this behaviour has not changed since the early versions of the Angule CLI.

Please advise, how should I write it?

Duplicate of #28050
This is working as expected and this behaviour has not changed since the early versions of the Angule CLI.

Duplicate of #28050
This is working as expected and this behaviour has not changed since the early versions of the Angule CLI.

v17 can be written like this
background: url("../assets/images/001_tn.jpg") no-repeat center;
v18 will report an error if written like this
background: url("../../public/images/001_tn.jpg") no-repeat center;

Duplicate of #28050
This is working as expected and this behaviour has not changed since the early versions of the Angule CLI.

I know where the problem is.


Update page is miss leading when the product was officially released

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3275e223-a9cc-1efb-07ec-01c8501d7a46
Version Independent ID: 538673ca-22c5-2a5c-97c0-1552ae9f7b79
Content: Migrate your app from Xamarin.Forms to .NET MAUI - .NET MAUI
Content Source: docs/get-started/migrate.md
Product: dotnet-mobile
Technology: dotnet-maui
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hi @jmarti326
You mean the sentence that says: "Visual Studio support for .NET Multi-platform App UI (.NET MAUI) is currently in preview."?
If so, afraid it's accurate. While the MAUI SDK has been released, Visual Studio support for it is still in preview.


Feature/markhornak/sc 106148/implement get folders

Shortuct
Overview
Update to py_sdk to add get_folders() call.  This included adding a new class Folder to contain the objects returned by the get_folders call.  Test coverage was also added.
Note: it seems this PR contains some massive formatting changes that came about from VSCodes use of an updated python formatter, apologies if this is hard to discern...

@aHojo - I can't seem to find any of your comments to review or resolve them!!


Idl test 1

This PR lays out structure for some new classes, em and idl files, needed for type support. Still 'work in progress', but shows design / style intentions.

Is this review ready? If so, please click "Ready for review" to make it official.

Please update the title.  "Idl test 1" doesn't tell me anything

Another problem when building test_msgs with this branch. I think it would be good to get this merged soon so we can start to see some of the other problems.
/opt/workspace/build/test_msgs/rosidl_typesupport_opendds_cpp/test_msgs/action/dds_opendds/fibonacci__type_support.cpp:234:10: fatal error: test_msgs/action/dds_opendds/Fibonacci__RequestResponseC.h: No such file or directory  #include <test_msgs/action/dds_opendds/Fibonacci__RequestResponseC.h>           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[2]: *** [CMakeFiles/test_msgs__rosidl_typesupport_opendds_cpp.dir/rosidl_typesupport_opendds_cpp/test_msgs/action/dds_opendds/fibonacci__type_support.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... /opt/workspace/build/test_msgs/rosidl_typesupport_opendds_cpp/test_msgs/action/dds_opendds/nested_message__type_support.cpp:344:10: fatal error: test_msgs/action/dds_opendds/NestedMessage__RequestResponseC.h: No such file or directory  #include <test_msgs/action/dds_opendds/NestedMessage__RequestResponseC.h>           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated.


Fix buffers.pl hotlist colors

This fixes the #16 problem for me.
buffers.pl appears to depend on the color not being set in a channel name in order to properly set the hotlist_* colors. Previously the color was being set to default, this change stops setting any color if channels_not_on_current_server_color isn't set.

Ahh thanks! This seems like a sensible fix.


Bro

Just want to say sank you!

Hi there,
Did this sock_proxy can handle http_proxy data ?
Thanks for you're answer, I'm new in proxy servers.


[Tree]getHalfCheckedNodeList can not get the nodes

Version
1.6.0
Environment
Angular6
Reproduction link
https://stackblitz.com/edit/ng-zorro-antd-start-1tpsiy
Steps to reproduce
Initialize  nzCheckStrictly is true，then change to false.
Uncheck 0-0-0-0，click on the button to get halfCheckedNodeList，console print halfCheckedNodeList is []
What is expected?
I want to get 0-0 and 0-0-0  node
What is actually happening?
halfCheckedNodeList is []
Other?

有没有一种方法，获取所有勾选，半选？

@DoesntWong 你可以在nzCheckStrictly=false时，将返回的nzTreeNode数组遍历，取出全部节点和子节点ID


Remove "domain" from subnets

This should prevent dnsmasq to push "search domain" flag.
As a pull request owner and reviewers, I checked that:

[X] Appropriate testing is done and actually running

/lgtm

/lgtm

/approve

/approve
since the bot asks me to approve it... :]


Update scala3-library, ... to 3.1.0

Updates

org.scala-lang:scala3-library
org.scala-lang:scala3-library_sjs1

from 3.0.2 to 3.1.0.
GitHub Release Notes - Version Diff - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (3.0.2).
You might want to review and update them manually.
.github/workflows/ci.yml

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-lang" } ]

labels: library-update, semver-minor, old-version-remains

I would like to wait for a -target compiler option to be available before we update the Scala 3 version.


Added test case where decorator gets ignored. Reproduces Github #169

Added test case for https://github.com/dadhi/DryIoc/issues/169
Hierarchy is like this:
Controller -> ServiceA -> (RepositoryDecorator) Repository
Controller2 -> ServiceB -> (RepositoryDecorator) Repository

Everything is singleton, except Controllers. When calling method from Controller2 it does not go to decorator. However calling from Controller1 it does go there.

AppVeyor is failing because tests fail:
Expected: "REPO_DECORATOR__B_Controller2"
But was:  "REPO_B_Controller2"

Could you add [Ignore("fix me")] attribute on the test class. Then I can merge he PR and fix later.

Okay

Do you have any idea when this will get fixed? It would be nice to upgrade rather than rollback 4.0.5

Do you have any idea when this will get fixed?

Maybe Tomorrow.


IZE-722 passed aws region via an env var for up tunnel

Change:
passed aws region via an env var for up tunnel
Test:

Codecov Report

Merging #544 (ccbc040) into main (501eba9) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #544      +/-   ##
==========================================
- Coverage   30.55%   30.55%   -0.01%
==========================================
  Files          64       64
  Lines        8228     8229       +1
==========================================
  Hits         2514     2514
- Misses       5470     5471       +1
  Partials      244      244

Impacted Files
Coverage Δ

internal/commands/tunnel_up.go
27.16% <0.00%> (-0.07%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


livestyle-client in polling mode get stuck in infitite page refreshes

Closing the issue since we disabled watching the html file itself, which was triggering this behavior.


Unable to install autopy on Mac ARM64 M1

After installing the AutoPy (pip install autopy), when I try to use it in my code I got following errors:
File "/Users/pawellewicki/git/FX/venvARM/lib/python3.8/site-packages/autopy/init.py", line 6, in
from . import alert, bitmap, color, key, mouse, screen
ImportError: dlopen(/Users/pawellewicki/git/FX/venvARM/lib/python3.8/site-packages/autopy/alert.cpython-38-darwin.so, 0x0002): tried: '/Users/pawellewicki/git/FX/venvARM/lib/python3.8/site-packages/autopy/alert.cpython-38-darwin.so' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64e')), '/usr/local/lib/alert.cpython-38-darwin.so' (no such file), '/usr/lib/alert.cpython-38-darwin.so' (no such file)

I have experienced this with the opencv-python library. It seems like your command line is running it on intel architecture, but the package is meant for ARM64.
Im not sure what your running it from, but I would recommend trying it out from terminal first. The command
arch
should return ARM64. If not, you should disable rosetta mode in your terminal


Always show error message when server start up fails

Message was only printed when Show better when selected port was already
being used.
Signed-off-by: Otavio Pontes<EMAIL_ADDRESS>

LGTM :+1:


[WIP] C ABI plugin system

Hi !
I played around with waybar a bit, and developed a quick proof of concept for a C ABI plugin system, that could allow people to develop more complex waybar modules, without modifying waybar itself.
The idea is to have waybar allocate a GTK container for the cabi plugin, and send its pointer to the plugin, that takes care of populating the widget as needed. The C ABI is very handy because GTK is in C and almost most languages can generate a C ABI (C++, rust, python, ...) and call GTK functions.
My end goal is to develop a custom system monitor module, that displays CPU, IO and network activity in a very compact manner (eventually with graphs) !
As I said, this currently a PoC and needs to be worked on to improve the ABI, add more features and config options, ...
I would like to get your opinion on the C ABI idea, and if it is worth spending more time on this PR
To try it out:

Compile the plugin dynamic library: cd cabi_example && meson build && meson compile -C build
Copy this waybar config:

{
    "modules-center": ["cabi/c_example"],
    "cabi/c_example": {"path": "cabi_example/build/libwaybar_cabi_c_example.so"}
}

Run waybar ./build/waybar -c cabi_config

This could be a really nice addition!
Would love to see how far we can get in this direction 😃

Sorry for the delay, I got carried away by other projects
I think this PR is ready to be reviewed / merged !
The current ABI may not be perfect yet, but it's definitely usable and can always be improved later using feedback from custom module devs.
There's an example module located in resources/custom_modules/cffi_example/, written in C. I also started writing my own plugin in Rust for displaying CPU graphs in a GtkDrawingArea, but it's nowhere near ready.
Some key points for maintaining and upgrading the CFFI ABI:

Waybar detects the ABI version used by the plugin with the wbcffi_version constant. Waybar should be able to handle different ABI versions by wrapping the raw function pointers with std::function (or do some later logic using the version number)
The ABI version should only be incremented with breaking changes, i.e. when modifying existing symbols or requiring new symbols. You can add additional optional hooks or append new members to wbcffi_init_info without incrementing the ABI version number.
Plugins can require specific waybar versions (e.g. when a new optional hook has been added without incrementing the ABI version) by checking the waybar version during plugin initialization

Nice, look pretty simple for a first iteration, thx!
Can you also add a man to redirect the user to the example files and possible module conf?
And aswell for the Github wiki :)

Done !
The file resources/custom_modules/cffi_example/waybar_cffi_module.h documents the symbols to define for a module to be loaded. I'm not sure it should be stored in the example directory, but I'm not sure where it belongs to


txwatcher: improve logging in csvPassedCallback

Enhances logging in the csvPassedCallback function to provide more context when errors occur.
It now includes the swap ID, transaction ID, and starting block height along with the error message.
This change aids in debugging and troubleshooting issues related to CSV transaction handling.

ACK 0ff7ed6


No mentions in doc that button dropdowns requires bootstrap-dropdown.js

I've spent some time trying to figure why my dropdown button wasn't active and I figured that I needed to import bootstrap-dropdown.js, but didn't find any mention on it in the doc at http://twitter.github.com/bootstrap/components.html#buttonDropdowns.

Resolved in 2.0.1-wip—added a block to mention this. Thanks!

Thanks :)


Error with "filter_bam"  "[main_samview] fail to read the header from "-"."

Hello, I encountered an error when running the command filter_bam HMHiC.bam 1 --nm 3 --threads 14 | samtools view - -b -@ 14 -o HMHiC.filtered.bam, which states "[main_samview] fail to read the header from "-"." I checked that my HMHiC.bam file and its path are correct, and I ran haphic check which also indicated that everything is normal.
Additionally, when I tried to split the command into two parts, specifically filter_bam HMHiC.bam 1 --nm 3 --threads 14 > HMHiC.filtered.tmp.bam and samtools view HMHiC.filtered.tmp.bam -b -@ 64 -o HMHiC.filtered.bam, the first command filter_bam HMHiC.bam 1 --nm 3 --threads 14 > HMHiC.filtered.tmp.bam resulted in an error indicating "Segmentation fault (core dumped)." Do you have any suggestions?
[dir@c01n0002 ~]$ cd HiFi
[dir@c01n0002 HiFi]$ conda activate haphic
(haphic) [dir@c01n0002 HiFi]$ /share/org/DIR/dir/HapHiC/haphic check
Checking pysam... Successful (version: 0.20.0).
Checking portion... Successful (version: 2.4.2).
Checking numpy... Successful (version: 1.26.4).
Checking scipy... Successful (version: 1.14.0).
Checking scikit-learn... Successful (version: 1.5.1).
Checking networkx... Successful (version: 3.3).
Checking sparse_dot_mkl... Successful (version: 0.9.4).
Checking matplotlib... Successful (version: 3.9.1.post1).
(haphic) [dir@c01n0002 HiFi]$ /share/org/DIR/dir/HapHiC/utils/filter_bam HMHiC.bam 1 --nm 3 --threads 14 | samtools view - -b -@ 14 -o HMHiC.filtered.bam
[main_samview] fail to read the header from "-".
(haphic) [dir@c01n0002 HiFi]$ /share/org/DIR/dir/HapHiC/utils/filter_bam HMHiC.bam 1 --nm 3 --threads 14 > HMHiC.filtered.tmp.bam
Segmentation fault (core dumped)
(haphic) [dir@c01n0002 HiFi]$ /share/org/DIR/dir/HapHiC/utils/filter_bam -h
Segmentation fault (core dumped)
(haphic) [dir@c01n0002 HiFi]$ /share/org/DIR/dir/HapHiC/utils/filter_bam
Segmentation fault (core dumped)
(haphic) [dir@c01n0002 HiFi]$ /share/org/DIR/dir/HapHiC/utils/filter_bam --H
Segmentation fault (core dumped)
(haphic) [dir@c01n0002 HiFi]$ /share/org/DIR/dir/HapHiC/utils/filter_bam --help
Segmentation fault (core dumped)

Maybe the binary version of filter_bam did not work properly on your system. I'm curious about what kind of CPU you are using. You can try the Python version (filter_bam.py) instead:
/path/to/HapHiC/utils/filter_bam.py HiC.bam 1 --NM 3 --threads 14 | samtools view - -b -@ 14 -o HiC.filtered.bam

It seems that using filter_bam.py worked fine. Thank you for your help. Also, my CPU model is Intel 8458P.

I have the same issue:
/raven/u/luelze/sw/bwa/bwa mem -5SP -t 28 /ptmp/luelze/analysis/wGorVio/haphic/linked_assemblies/assembly_haplotig2.fasta /ptmp/luelze/analysis/wGorVio/haphic/hic_reads/R1.fastq.gz /ptmp/luelze/analysis/wGorVio/haphic/hic_reads/R2.fastq.gz | samblaster | samtools view - -@ 24 -S -h -b -F 3340 -o HiC.bam

Activating conda environment: haphic
[main_samview] fail to read the header from "-".

I have Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz

Hi @AlcaArctica,
Will using filter_bam.py instead of filter_bam solve the issue?
Best regards,
Xiaofei


Use with Angular2

Hi, I am attempting to make this work with an Angular2 application.
I'm assuming this would need to be set up in my app.component.ts file which looks like:
import { Component } from "@angular/core";

@Component({
  selector: "main",
  template: "<page-router-outlet></page-router-outlet>"
})
export class AppComponent {
    constructor() { }
}

I am not sure how to set up the delagate. When trying to use the code in the ReadMe I get an error that UIResponder isn't defined.
Any help would be greatly appreciated, thanks!

I would add the delegate in the main.ts and since you are getting that error it's just the ts complaining about the missing type so to by pass that you can add declare var UIResponder:any; to the top of your component or install tns-platform-declarations then add the ref

I add the tns-platform-declarations, but it is not recognizing the module:
MacBook-Pro-de-Ignacio:hezea-app ignacio$ tns plugin add nativescript-splashscreen

><EMAIL_ADDRESS>postinstall /Users/ignacio/Workspaces/DuenoVende/hezea-app/node_modules/nativescript-splashscreen
> node install

<EMAIL_ADDRESS>/Users/ignacio/Workspaces/DuenoVende/hezea-app
├── UNMET PEER DEPENDENCY<EMAIL_ADDRESS>├── UNMET PEER DEPENDENCY<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>  └──<EMAIL_ADDRESS>

Successfully installed plugin nativescript-splashscreen.
MacBook-Pro-de-Ignacio:hezea-app ignacio$ tns run ios
Executing before-prepare hook from /Users/ignacio/Workspaces/DuenoVende/hezea-app/hooks/before-prepare/nativescript-dev-android-snapshot.js
Executing before-prepare hook from /Users/ignacio/Workspaces/DuenoVende/hezea-app/hooks/before-prepare/nativescript-dev-typescript.js
Found peer TypeScript 2.1.6
app/main.ts(5,30): error TS2307: Cannot find module 'nativescript-splashscreen'.

Here is the code:
// this import should be first in order to load some required settings (like globals and reflect-metadata)
import { enableProdMode } from "@angular/core";
import { platformNativeScriptDynamic } from "nativescript-angular/platform";
import * as application from "application";
import { SplashScreen } from "nativescript-splashscreen";

import { AppModule } from "./app.module";

if (application.ios) {
    var FRESH_LAUNCH: boolean = true;

    class MyDelegate extends UIResponder implements UIApplicationDelegate {
        public static ObjCProtocols = [UIApplicationDelegate];

        applicationDidFinishLaunchingWithOptions(application: UIApplication, launchOptions: NSDictionary<any, any>): boolean {
            return true;
        }

        applicationDidBecomeActive(application: UIApplication): void {
            if (FRESH_LAUNCH) {
                FRESH_LAUNCH = false;
                let splash = new SplashScreen('twitterIcon.png', '#4E75E2');
                application.keyWindow.addSubview(splash.start());
            }
        }
    }

    application.ios.delegate = MyDelegate;
}

enableProdMode();

platformNativeScriptDynamic().bootstrapModule(AppModule);

I just created this PR https://github.com/triniwiz/nativescript-splashscreen/pull/16 adding a demo-ng sample with the way I understood the plugin should be applied, unfortunately it is still incomplete because of the error I just mentioned.
Help will be appreciated :)

I think you have to declare it as module in SplashScreen.ios.d.ts file:
declare module "nativescript-splashscreen" {
    export class SplashScreen {
        ....

I am using this plugin with nativescript angular, should I add the App_Resources/drawable/splash_icon.png file into my existing App_Resources? And if so, under which folder? It's not too clear in the readme


New Release Soon?

The last release was in February and a lot of work has gone into the app since then with many fixes and QoL changes. If you ask me, it's due for an update. Do you have plans for creating a new release soon?

Hi @chickdan
I hope to get a release out soon. I'm giving myself to the end of January to clean things up for a 2.0 release.

Sounds good, thank you!

2.0 Beta is out now.. please test!


Not deleting old versioned files after new build @v0.8.0

#406 The issue has been closed.
I am here to address the issue in more details.
As of v0.8.0, I have create another config, let say version.config.js + version.mix.js to do only version actions for some custom files. The files are been versioned correctly and added to the manifests.json. And, the previous default config webpack.config.js + webpack.mix.js runs basic js compiling and file combines with hot reload support.
Run sequence:

npm run dev
npm run version (the config is pointed to version.config.js + version.mix.js)

Issues:

The second config with mix files run after the default config with mix files, doesn't delete the old versioned files.
It is because the hot reload HMR doesn't support versioned files, so that I have to put the second config files in order to have both versions support and HMR support.

We do have some HMR work to do, so files not being versioned is a known issue and is detailed in one of the other open issues here.

@JeffreyWay How to address the first issue?


New package: SpikeSorting v0.2.0

Registering package: SpikeSorting
Repository: https://github.com/paulmthompson/SpikeSorting.jl
Created by: @paulmthompson
Version: v0.2.0
Commit: df66fb98cdab298146237507012601e7f2b688e5
Git reference: master

I n00bed out and opened a new pull request when I addressed the issues above. This pull request here can be deleted because the new one went through.


https://github.com/grammy-jiang/scrapy-enhancement-examples

This link is not working

Yeah, i didn't fill content into this link...

An example would be nice, there is nothing in your docs that actually tells you how to use it


[BUG] cpdef method used to create iterator from child class fails

Describe the bug
Working on some Cython code I encountered a problem in using classes where a cpdef method in the parent class is used inside a generator in a child class. The compilation step doesn't fail but  it outputs this before finishing:
/home/bob/Desktop/mesa-perf/mesa_perf/bug_cython.c: In function ‘__pyx_pf_10bug_cython_1b_func’:
/home/bob/Desktop/mesa-perf/mesa_perf/bug_cython.c:3214:220: warning: passing argument 1 of ‘__Pyx_CFunc_7b59a9__object__lParena__comma_object__comma_int__dunderpyx_skip_dispatch__rParen__etc_to_py_4self_1i’ from incompatible pointer type [-Wincompatible-pointer-types]
 3214 | vtabstruct_10bug_cython_b *)__pyx_v_self->__pyx_base.__pyx_vtab)->__pyx_base.filt); if (unlikely(!__pyx_t_1)) __PYX_ERR(0, 11, __pyx_L1_error)
      | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
      |                                                                             |
      |                                                                             PyObject * (*)(struct __pyx_obj_10bug_cython_a *, PyObject *, int) {aka struct _object * (*)(struct __pyx_obj_10bug_cython_a *, struct _object *, int)}
/home/bob/Desktop/mesa-perf/mesa_perf/bug_cython.c:1959:132: note: expected ‘PyObject * (*)(struct __pyx_obj_10bug_cython_a *, PyObject *)’ {aka ‘struct _object * (*)(struct __pyx_obj_10bug_cython_a *, struct _object *)’} but argument is of type ‘PyObject * (*)(struct __pyx_obj_10bug_cython_a *, PyObject *, int)’ {aka ‘struct _object * (*)(struct __pyx_obj_10bug_cython_a *, struct _object *, int)’}
 1959 | omma_object__comma_int__dunderpyx_skip_dispatch__rParen__etc_to_py_4self_1i(PyObject *(*)(struct __pyx_obj_10bug_cython_a *, PyObject *)); /*proto*/
      |

And then, trying to use the function gives an error:
>>> from bug_cython import b
>>> s = b()
>>> s.func([2])
<filter object at 0x7f62c6e2a620>
>>> list(s.func([2]))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<stringsource>", line 67, in cfunc.to_py.__Pyx_CFunc_7b59a9__object__lParena__comma_object__comma_int__dunderpyx_skip_dispatch__rParen__etc_to_py_4self_1i.wrap
TypeError: wrap() takes exactly 2 positional arguments (1 given)

Experimenting a bit it seems that if the cpdef function is mutated in a def function or if it is moved in the child class the code instead works.
Code to reproduce the behaviour:
cdef class a:

    cpdef filt(self, i):

        return True

cdef class b(a):

    def func(self, list_):

        return filter(self.filt, list_) # it fails also with other functions returning iterators: map, ...

Expected behaviour
No compilation warning and no error when using the method
Environment
OS: Linux
Python version: 3.10.6
Cython version: 3.0.0a11

This is now an error in GCC 14: https://github.com/gcc-mirror/gcc/commit/9715c545d33b3a32ddc1ae817ba9356ade1fb9df .
A temporary workaround is to set CFLAGS="${CFLAGS} -Wno-error=incompatible-pointer-types".


[Coverity CID :187069] Memory - illegal accesses in /subsys/logging/log_msg.c

Static code scan issues seen in File: /subsys/logging/log_msg.c
Category: Memory - illegal accesses
Function: log_msg_hexdump_data_op
Component: Other
CID: 187069
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996

@nordic-krch can you please take a look?


Usings sorting differs based on system culture

It seems that system culture affects the usings ordering. I use cs-CZ culture on my PC, but our CI has en-US. This creates different lists in different environments.
For example this:
using Microsoft.ApplicationInsights.Channel;
using Microsoft.ApplicationInsights.DataContracts;
using Microsoft.ApplicationInsights.Extensibility;

gets sorted like this in Czech:
using Microsoft.ApplicationInsights.DataContracts;
using Microsoft.ApplicationInsights.Extensibility;
using Microsoft.ApplicationInsights.Channel;

This is because in Czech the ch is a "single letter" which is part of our alphabet and is placed between h and i.
When ordering the usings it should probably just always use something like Ordinal (https://learn.microsoft.com/en-us/dotnet/standard/base-types/best-practices-strings#recommendations-for-string-usage).
This started happening after upgrading from version 0.25.0 to 0.26.3 as part of our .net 8 upgrade.

.assign

Is this an intended side effect? 0.26.4 sorts NSubstitute before Newtonsoft.Json


[WIP] Hunterize iroha

Motivation
Current approach with dependencies is bad, because we are forced to hardcode paths for libs and include headers. This is error prone is some toolchains, such as XCode, which we need to support.
The solution we've selected is Hunter -- CMake-only script, which manages all dependencies in configuration time.
Comments

This trunk and PR is used to test CI and keep track of progress.
do not push directly to this branch, only via PRs.

After we finish hunterization of all dependencies, we will forget about headache with them forever.
This is a good way to manage dependencies and good chance to upgrade their versions to the latest.
Current state
This branch will be used as trunk. This trunk will be merged into develop as soon as all dependencies will be hunterized.
Please do not update the following list by yourself. It helps to keep track of tasks required to finish migration to Hunter.
List of dependencies. (x - hunterized, empty - not hunterized)

[ ] protobuf
[ ] postgresql + pqxx
[ ] grpc
[x] rapidjson 1.1.0
[x] boost 1.65.1

[x] filesystem
[x] system
[ ] spirit

[x] gtest and gmock 1.8.0
[ ] gflags 2.2 - needs to be tested, may be buggy, so probably we will need to hunterize different version.
[ ] c-ares
[x] spdlog 0.13 -- but we need 0.16, so we need to hunterize new version.
[ ] rxcpp
[ ] ed25519 -- repository hyperledger/iroha-ed25519 is ready to be hunterized
[ ] tbb
[ ] optional (martinmoene)
[ ] swig
[ ] google benchmark

Also, all CI systems and scripts should be cleaned and fixed:

[ ] CircleCI
[ ] Jenkins

Other changes

organize cmake files and scripts in better structure
add new configuration type -DCMAKE_BUILD_TYPE=Coverage, which adds necessary flags to collect more quality coverage metrics
add ccache support for XCode
add hunter binary cache:
Now you can specify 2 environment variables: GITHUB_USER with your username and GITHUB_USER_PASSWORD with your personal access token with permission public_repo, then specify cmake .. -DHUNTER_RUN_UPLOAD=ON and it will download, build and upload binary files to https://github.com/soramitsu/hunter-binary-cache . Cache hit will be if and only if hunter version, toolchain and architecture are same.
fix bug in clang-format target: it fixed by mistake all files inside external directory.
update minimal required cmake to 3.7

This PR is going to be splitted onto multiple PRs.
First is https://github.com/hyperledger/iroha/pull/983