Watchers in nested elements in keep alive are called twice

Version
3.2.26
Reproduction link
code : github.com
demo : netlify.com
Steps to reproduce

Click https://vue-3-watcher-called-twice.netlify.app/home/nested
Open devtools on the console tab.
Click About link.
Click "Modify shared state".

What is expected?
Modifying state should trigger related watchers once.
What is actually happening?
Modifying state triggers related watchers twice.

Related topic :
https://forum.vuejs.org/t/vue-3-watcher-called-twice/125548

This is because when for example "home" is active, keepAlive caches About -> RouterView (RounterView renders NestedHome), it results in two NestedHome instances.

If you check keepAlive official doc

keep-alive does not work with functional components because they do not have instances to be cached.

However, according to router-view doc, RounterView is a functional component.
This contradictory should be resolved in router

similar to #5252,
because the children are not cached.

Closing in favor of https://github.com/vuejs/core/issues/5386 without vue-router involved


standard/array-bracket-even-spacing breaks in destructuring with flowtype

([x, y]: C) => x + y gives Expected consistent spacing (standard/array-bracket-even-spacing)
([x, y]) => x + y and (c: C) => x + y are fine.
Should I file the issue here or at gajus/eslint-plugin-flowtype?
--fix doesn't get it there, but it is actually satisfied with the weird ([ x, y]: C) => x + y

I noticed another weird behavior with this.
This works:
const x = y(([, a, b, c, d]) => ({ /* ... */ }))

...as does this:
const x = y(([, a, b, /* c is unused */, d]) => ({ /* ... */ }))

But this gives me an error Expected consistent spacing (standard/array-bracket-even-spacing):
const x = y(([/* always zero */, a, b, c, d]) => ({ /* ... */ }))

This package isn't used by standard anymore, as of standard v16. See: standard/standard/issues/1316


F* mode considerable slow down on large files commented using //

When commenting with the recent // syntax change, my emacs gets a huge slow down.
This was not the case before with the (* *) style of comments :)

Hi @beurdouche,
Can you give a concrete example? I haven't noticed the slowdown here :)
Thanks!

Hey @cpitclaudel !
As an example, you can take /opt/hacl-star/code/hash/Hacl.Hash.SHA2_512.fst, comment the file and then try to navigate in it... This is super slow in my setting :)

Thanks! Will look into it soon.

Ok, I pushed a tentative fix.

Please try it and let me know

Cool ! Will test, Thanks a lot !


fix(genesis): Base Fee Params fixes"

Description
Fixes base fee param loading in the ChainConfig -> RollupConfig conversion to actually pull in the OpBaseFeeParams defined in the optimism field of the ChainConfig.

📚 $\text{Stack Overview}$
Pulls submitted in this stack:

#292 👈
main

This comment was automatically generated by st.


[BUG] Incorrect port available for Health Check in Load Balancer

Describe the bug

When creating a LoadBalancer, in the Health Check screen, the list of ports shown are incorrect. The list shows incoming ports where as it should show backend ports.
To Reproduce
Steps to reproduce the behavior:

Go to LoadBalancer Screen
Create a new LoadBalancer
Define a listener, add an incoming port, backend port
Define server selector
On the Health Check screen try to select the backend port in the drop down list. Notice the backend port isn't available for selection.

Expected behavior

List of ports must show backend ports. Note that it is possible to edit YAML to add the correct port manually.
Support bundle

Environment

Harvester ISO version: 1.3.0
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): HPE Proliant Gen9

Additional context
Add any other context about the problem here.

According to documentation:
Health Check Port means Specifies the port. The prober will access the address composed of the backend server IP and the port. Currently it shows and writes load balancer port, but I could modify config by Edit YAML to make it correct. So, I think it's an GUI Issue, it seems this line.
For more details of workaround, let's say if we have listener port is 8080, and backport is 7777.
After created by GUI, the YAML will be:
  healthCheck:
    failureThreshold: 1
    periodSeconds: 2
    port: 8080
    successThreshold: 2
    timeoutSeconds: 2
  ipam: dhcp
  listeners:
    - backendPort: 7777
      name: myport
      port: 8080
      protocol: TCP

But, it should be:
  healthCheck:
    failureThreshold: 1
    periodSeconds: 2
    port: 7777
    successThreshold: 2
    timeoutSeconds: 2
  ipam: dhcp
  listeners:
    - backendPort: 7777
      name: myport
      port: 8080
      protocol: TCP

@torchiaf If you need help of load balancer, feel free to reach @starbops

Thanks for the fix @torchiaf  - this looks good on:
Harvester Version: master-9c0a3a1-head

I'll go ahead and close this out :+1:


Add support of open source blas for tests

ACML is closed source and EOL, why not to add support of any other BLAS implementation? For example, someone may want to build and test clBLAS on ARM or MIPS platform.

You can do this by unclicking "CORR_TEST_WITH_ACML" and the test suite will try link against netlib blas.

Done, but it can't find netlib path itself. In Ubuntu it is /usr/lib/libblas/libblas.so.3 - please add it to FindNetlib.cmake

Hi with PR #181 on my Ubuntu system I can find and build test with libblas.so fairly straightforward. Can you verify that it works for you?

Seems like this is a. plausibly fixed in 'develop' b. really old, and probably can be closed?


Sheet missing from Sheets object but showing up in SheetNames array

I am experiencing the same symptom as issue #145, where I have what seems to be a valid xlsx, but when I parse it the SheetNames array contains the sheet name, but the Sheets object is empty. I am using v 0.8.0.
https://gist.github.com/jordanrogers/8b20c2b87118532f3add
If I open the file in excel and save it, it parses fine. I've tried hacking up the .xlsx to isolate the issue, without success.

Got same issue there, open and save xlsx again can resolve it.

+1

This file had the same problem as #508 -- unexpected namespaces in the XML.  This issue was fixed in 0.8.3 and it appears to work in http://oss.sheetjs.com/js-xlsx/ as well as in the node module.


go proto: include vtprotobuf generation

Commit Message: go proto: include vtprotobuf generation
Additional Description:
See https://github.com/envoyproxy/go-control-plane/issues/824 for more information
This PR adds the vtprotobuf protoc plugin for Go. This works on top of the existing protoc-gen-go, to add optimized marshal functions that callers can opt in to using. This is not like gogo, which was a very invasive change -- everything is layered and opt-in. See issue for benchmarks, etc.
Risk Level: Low - only additional opt in code
Testing: Manually tested in Istio codebase
Docs Changes: NONE
Release Notes: NONE
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

For the binary size risk you highlight, is that risk for the go-control-plane binary, the Envoy binary or both?

Binary size: importing every proto results in a 4MB increase in binary size. Not its quite uncommon to import every proto in the repo, so typically this cost is much smaller
Mitigation, if needed: expose this only under a build tag, so a use can opt in (or opt out)

this exclusively impacts go-control-plane (binary and importers of the library)

cc @dfawley since grpc-go consumes go-control-plane

cc @dfawley since grpc-go consumes go-control-plane

Thank you.  IIUC this should not affect us since we don't use bazel?

cc @dfawley since grpc-go consumes go-control-plane

Thank you. IIUC this should not affect us since we don't use bazel?

This will impact the generated code in go-control-plane (everything under https://github.com/envoyproxy/go-control-plane/tree/main/envoy)

I see...

Binary size: importing every proto results in a 4MB increase in binary size

How can I see what the impact will be to grpc-go binary sizes with xds enabled?
Our set of protos imported is currently:
"github.com/envoyproxy/go-control-plane/envoy/admin/v3"
"github.com/envoyproxy/go-control-plane/envoy/api/v2"
"github.com/envoyproxy/go-control-plane/envoy/api/v2/core"
"github.com/envoyproxy/go-control-plane/envoy/api/v2/endpoint"
"github.com/envoyproxy/go-control-plane/envoy/config/cluster/v3"
"github.com/envoyproxy/go-control-plane/envoy/config/core/v3"
"github.com/envoyproxy/go-control-plane/envoy/config/endpoint/v3"
"github.com/envoyproxy/go-control-plane/envoy/config/listener/v3"
"github.com/envoyproxy/go-control-plane/envoy/config/rbac/v2"
"github.com/envoyproxy/go-control-plane/envoy/config/rbac/v3"
"github.com/envoyproxy/go-control-plane/envoy/config/route/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/clusters/aggregate/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/filters/common/fault/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/filters/http/fault/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/filters/http/rbac/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/filters/http/router/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/filters/network/http_connection_manager/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/least_request/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/pick_first/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/ring_hash/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/round_robin/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/wrr_locality/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/rbac/audit_loggers/stream/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/transport_sockets/tls/v3"
"github.com/envoyproxy/go-control-plane/envoy/service/discovery/v3"
"github.com/envoyproxy/go-control-plane/envoy/service/load_stats/v3"
"github.com/envoyproxy/go-control-plane/envoy/service/status/v3"
"github.com/envoyproxy/go-control-plane/envoy/type"
"github.com/envoyproxy/go-control-plane/envoy/type/matcher/v3"
"github.com/envoyproxy/go-control-plane/envoy/type/v3"
"github.com/envoyproxy/go-control-plane/pkg/cache/types"
"github.com/envoyproxy/go-control-plane/pkg/cache/v3"
"github.com/envoyproxy/go-control-plane/pkg/resource/v3"
"github.com/envoyproxy/go-control-plane/pkg/server/v3"
"github.com/envoyproxy/go-control-plane/pkg/wellknown"

I see...

Binary size: importing every proto results in a 4MB increase in binary size

How can I see what the impact will be to grpc-go binary sizes with xds enabled?
Our set of protos imported is currently:
"github.com/envoyproxy/go-control-plane/envoy/admin/v3"
"github.com/envoyproxy/go-control-plane/envoy/api/v2"
"github.com/envoyproxy/go-control-plane/envoy/api/v2/core"
"github.com/envoyproxy/go-control-plane/envoy/api/v2/endpoint"
"github.com/envoyproxy/go-control-plane/envoy/config/cluster/v3"
"github.com/envoyproxy/go-control-plane/envoy/config/core/v3"
"github.com/envoyproxy/go-control-plane/envoy/config/endpoint/v3"
"github.com/envoyproxy/go-control-plane/envoy/config/listener/v3"
"github.com/envoyproxy/go-control-plane/envoy/config/rbac/v2"
"github.com/envoyproxy/go-control-plane/envoy/config/rbac/v3"
"github.com/envoyproxy/go-control-plane/envoy/config/route/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/clusters/aggregate/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/filters/common/fault/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/filters/http/fault/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/filters/http/rbac/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/filters/http/router/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/filters/network/http_connection_manager/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/least_request/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/pick_first/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/ring_hash/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/round_robin/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/wrr_locality/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/rbac/audit_loggers/stream/v3"
"github.com/envoyproxy/go-control-plane/envoy/extensions/transport_sockets/tls/v3"
"github.com/envoyproxy/go-control-plane/envoy/service/discovery/v3"
"github.com/envoyproxy/go-control-plane/envoy/service/load_stats/v3"
"github.com/envoyproxy/go-control-plane/envoy/service/status/v3"
"github.com/envoyproxy/go-control-plane/envoy/type"
"github.com/envoyproxy/go-control-plane/envoy/type/matcher/v3"
"github.com/envoyproxy/go-control-plane/envoy/type/v3"
"github.com/envoyproxy/go-control-plane/pkg/cache/types"
"github.com/envoyproxy/go-control-plane/pkg/cache/v3"
"github.com/envoyproxy/go-control-plane/pkg/resource/v3"
"github.com/envoyproxy/go-control-plane/pkg/server/v3"
"github.com/envoyproxy/go-control-plane/pkg/wellknown"

Using examples/features/xds/client and go build -ldflags '-extldflags -static -s -w' .:
Before: 21M (21368832 bytes)
After: 23M (24104960 bytes)
go mod edit -replace<EMAIL_ADDRESS>can temporarily test the change before this merges

@adisuissa Would you like to take a look at this? but let me know if I'm assigned to the wrong person. Thanks!

Thanks for working on this!
Generally speaking I'm ok with this assuming the new dependency is ok, but want to highlight the risks that you mentioned:

Binary size: importing every proto results in a 4MB increase in binary size. Not its quite uncommon to import every proto in the repo, so typically this cost is much smaller
Mitigation, if needed: expose this only under a build tag, so a use can opt in (or opt out)
Increase dependency that could, in theory, start to decay.
Mitigation: dropping vtprotobuf would be compatible, as noted above (just have a large performance impact)

Specifically the binary size increase may be impacting Envoy-Mobile. @alyssawilk to chime in on this.

Specifically the binary size increase may be impacting Envoy-Mobile. @alyssawilk to chime in on this.
The impact is only for golang code which I assume doesn't impact mobile (?)

It seems like a lot of hangup is on binary size. What if we make it opt-in behind a go build tag?

The binary size will matter a lot for Envoy Mobile, 4MB is quite a bit to add to the binary size of a mobile app library.  It would be interesting to see what the Envoy Mobile binary size impact is with and without this PR.
@howardjohn could you kindly run the following commands with and without your branch, and report back on the results:

bazel build --config=remote //test/performance:test_binary_size --config=sizeopt --copt=-ggdb3 --linkopt=-fuse-ld=lld --config=release-android
strip -s -o bazel-bin/test/performance/test_binary_size_stripped bazel-bin/test/performance/test_binary_size
ls -alh bazel-bin/test/performance/test_binary_size_stripped

The binary size will matter a lot for Envoy Mobile, 4MB is quite a bit to add to the binary size of a mobile app library. It would be interesting to see what the Envoy Mobile binary size impact is with and without this PR.
@howardjohn could you kindly run the following commands with and without your branch, and report back on the results:

bazel build --config=remote //test/performance:test_binary_size --config=sizeopt --copt=-ggdb3 --linkopt=-fuse-ld=lld --config=release-android
strip -s -o bazel-bin/test/performance/test_binary_size_stripped bazel-bin/test/performance/test_binary_size
ls -alh bazel-bin/test/performance/test_binary_size_stripped

This only impacts Go (via go-control-plane) so its not relevant to Envoy mobile

The binary size will matter a lot for Envoy Mobile, 4MB is quite a bit to add to the binary size of a mobile app library. It would be interesting to see what the Envoy Mobile binary size impact is with and without this PR.
@howardjohn could you kindly run the following commands with and without your branch, and report back on the results:

bazel build --config=remote //test/performance:test_binary_size --config=sizeopt --copt=-ggdb3 --linkopt=-fuse-ld=lld --config=release-android
strip -s -o bazel-bin/test/performance/test_binary_size_stripped bazel-bin/test/performance/test_binary_size
ls -alh bazel-bin/test/performance/test_binary_size_stripped

This only impacts Go (via go-control-plane) so its not relevant to Envoy mobile

So it wouldn't get compiled into the Envoy Mobile .so?  Based on your PR, it looks like it effects the api_proto_package which EM would indirectly use.

So it wouldn't get compiled into the Envoy Mobile .so? Based on your PR, it looks like it effects the api_proto_package which EM would indirectly use.

I don't see how it would, it only impacts go-control-plane. I cannot run the commands you sent to verify though, they do not seem to work for me.

I don't see how it would, it only impacts go-control-plane. I cannot run the commands you sent to verify though, they do not seem to work for me.

I tried it and the binary size didn't change for Envoy Mobile.  So I don't have concerns with this PR from the Envoy Mobile point of view.  Thanks!

I'm not sure this is a good idea.

This can never be removed once it is included.
It has downsides (binary size) to go along with its benefits (performance).
It might prevent us from upgrading protoc-gen-go if there is ever an incompatible change made in protoc-gen-go and this project stops being maintained.

Can vtproto not work as a separate add-on?  Why does it need to generate code into the same package as the protoc-gen-go code?

This can never be removed once it is included.

I disagree. vtprotobuf is designed in a way such that the same program can compile with or without it included (https://github.com/vitessio/vitess/blob/40f314c1d052db3fa5a52e5fb2ddd2bddaefde44/go/vt/servenv/grpc_codec.go#L40-L49 for example). This gives envoy flexibility to rip it out at anytime without breaking compatibility with importers (of course, they don't get the benefits anymore). This is very different from gogo proto.

It has downsides (binary size) to go along with its benefits (performance).

See https://github.com/envoyproxy/envoy/pull/31172#issuecomment-1852199211 and https://github.com/planetscale/vtprotobuf/pull/122, I intend to change this to make it opt-in.

It might prevent us from upgrading protoc-gen-go if there is ever an incompatible change made in protoc-gen-go and this project stops being maintained.

If so, we can remove it per above. I would not expect protoc-gen-go to make such changes given how things are layered; any change that could break vtprotobuf would laso likely completely break compatibility and represent a protobuf-go v3. vtproto doesn't depend on any internal details of protoc-gen-go really, aside from the fact a Go struct exists.

Can vtproto not work as a separate add-on? Why does it need to generate code into the same package as the protoc-gen-go code?

It is attaching methods to the types which can only be done in the same package

It is attaching methods to the types which can only be done in the same package

Is that really the only way they could find to improve the performance?
Or are there maybe other options that would allow this project to benefit everyone without requiring someone to go modify the official codegen for every project that has protos?

/wait-any

With the most recent commit this is now opt-in. Any user that doesn't explicitly opt in should have no impact.

/wait-any for further review - cc @moderation @adisuissa

@howardjohn seems DCO is broken

@howardjohn seems DCO is broken

Thanks, fixed.

cc @dfawley and @htuch for any comments, as they've probably had more experience in this domain.

If this is opt-in, I have no concerns from the gRPC side, as our users will be unaffected (unless they choose to enable it in their builds).

Please merge main.
Change LGTM. Assigning @htuch for senior-maintainer review.
/assign @htuch

@adisuissa thanks! I merged. Test is failing due to the v1.29.0 publishing I think


fix: pin @types/jest to 25.1.1

:tada: This PR is included in version 2.0.20 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Error: "Could not find commit hash for master"

Hey there—I'm trying to get started with Svelte and running:
Environment:

macOS 10.14 Mojave
Node v8.11.4
degit v2.1.3

Running:
degit sveltejs/template-webpack

... gives me:
! could not find commit hash for master

Double checking that the user/repo is correct, I'm not really sure why it can't find the hash. I tried it with a couple other repos out there and no-go.
Any ideas?

Well derp, I was trying to run this on a new Macbook Pro that I hadn't installed Xcode or the Command Line Tools on, so git wasn't ready to go yet. Now that it's installed, I tried degit again and everything worked like a charm.
It may be pertinent in the rare cases when people don't have git properly configured (who even does that?!) that degit properly pass any errors along that may occur like this.

Would be interesting if degit doesn't depend on git to work. I was trying to figure out for weeks why some team mates had the same issue. :smile:

git update helped on windows 10

I just updated to latest git on Win 10 same problem:
PS C:\Users\Oliver\dev> degit svetlejs/template svetle-test
! could not find commit hash for master

Any more ideas?

@oliverjanik Could you make sure git is on your PATH (or at least usable with the git command in your prompt?) It's possible you need to relink it after updating or installing.

This error manifests itself in Travis CI too. Trying to use degit there currently results in this error:
(node:5343) UnhandledPromiseRejectionWarning: Error: could not find commit hash for master
    at Degit.clone (/home/travis/build/osdevisnot/tslib-cli/node_modules/degit/index.js:170:10)
    at Object.<anonymous> (/home/travis/build/osdevisnot/tslib-cli/cli.js:39:15)
    at Module._compile (internal/modules/cjs/loader.js:701:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:712:10)
    at Module.load (internal/modules/cjs/loader.js:600:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:539:12)
    at Function.Module._load (internal/modules/cjs/loader.js:531:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:754:12)
    at startup (internal/bootstrap/node.js:283:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:622:3)

I had the same problem using it in my wsl shell but had no problem using it in my powershell.
I was using git version 2.11.0 in my powershell and 1.9.1 in my wsl. Maybe that helps someone.

I replaced degit with lukeed/gittar, and it's sufficient for what I need.
It isn't a pure replacement, and maybe doesn't have all the features you are using on degit, but it can suit most use cases.

@docmars , @Rich-Harris
I think we can close this issue, because I don't think anymore that it would be the case to adapt degit to don't depend on git, because it's exactly what gittar does.
We can live with both libraries, each one with its pros and cons.
Degit has more features, but requires git. Degit is more simple, but doesn't requires git. Each developer chooses the one it sees fit.

Agree with @paulocoghi here. For my small project I ended up using gittar as well.

maybe you need to write about it in the documentation?

Setting the cache value to false in the degit options solved this for me:
degit(repo, {
      cache: false,
      force: true,
      verbose: true,
    });

@cogoo, in the most cases, this error occurs when git isn't available/installed.

@cogoo, in the most cases, this error occurs when git isn't available/installed.

I have git installed. With cache: true it attempts to find the repo from a local cache, which is what caused the error for me

Thanks for saving me some time on this one... same situation, just did a phresh install with Catalina. You'd think the error message would be a little more... helpful.

thanks @cogoo it worked !!

If you're seeing the following error(s):
`$ npx degit https://github.com/sveltejs/sapper-template#rollup my-app
! could not find commit hash for rollup`
or
`$ npx degit https://github.com/sveltejs/sapper-template#webpack my-app
! could not find commit hash for webpack`
It's because git isn't working. git depends on xcode and xcode requires you to accept it's license agreement.
Try running "git" and if you see the following message:
$ git Agreeing to the Xcode/iOS license requires admin privileges, please run “sudo xcodebuild -license” and then retry this command.
then type:
sudo xcodebuild -license and follow instructions for scrolling through the license agreement. At the end, you will need to type "agree" then
At that point, your original command should work fine.

I have the same error with sveltejs/template.
Doc said to just run degit sveltejs/template svelte-app
Results:
$ degit sveltejs/template svelte-app
! could not find commit hash for master

What
Version

Linux Manjaro
18.1.0 Juhraya

Git
2.23.0

Node
12.9.1

NPM
6.11.2

Degit
2.1.4

I use git everyday without any problems.
Cloning the svelte template repo manually works without problems.

@masterl did you try what I have suggested above?
https://github.com/Rich-Harris/degit/issues/37#issuecomment-536226465

@vguhesan That doesn't apply.
I'm neither on mac, nor don't have git installed and configured.
Everything is on the comment, I have git, node, npm, degit all installed.
As I also said above, I can clone the repo directly without any problems.
The issue seems to be on degit itself.

@masterl , can you try again with cache: false ?

@paulocoghi Where do I use that?
running degit --help the cache option doesn't even has a parameter:
--cache, -c Only use local cache

@masterl , unfortunately you are right.
As mentioned by @cogoo and @riazXrazor, when using degit on code (not as cli), setting cache to false on the options may solve this problem
But it seems that we can't do the same on cli.

So, how to disable  caching in degit?

@PlkMarudny , this way:
degit(<repo_url>, {
    cache: false
});

Had the same issue ... it was a certificate related issue:
https://confluence.atlassian.com/bitbucketserverkb/ssl-certificate-problem-unable-to-get-local-issuer-certificate-816521128.html
wget the right one, copy to  /bin, and adjust .gitconfig in home.  Worked for me

I was just looking into getting degit to display more helpful error messages when it runs into a problem, and I found that it does display the underlying error if you call it with the verbose -v flag. Does it make sense to always display that error? I'm hoping that will eliminate a lot of questions in Svelte issues and the chatroom about this. In the meantime, now that I know this, I suppose we can tell people to run it again with -v so we can get some sort of idea of what's happening.

I know this thread is covering a lot of different issues now, but I had the same "could not fetch remote":
npx degit "sveltejs/sapper-template#webpack" sapper-test
! could not fetch remote https://github.com/sveltejs/sapper-template
! could not find commit hash for webpack

but it turns out that my .gitconfig in my home directory had an invalid http proxy that I could no longer access. Hope this helps someone.

Would be interesting if degit doesn't depend on git to work. I was trying to figure out for weeks why some team mates had the same issue. 😄

What if degit supports cloning local repos? That wouldn't work. I think we should properly display error messages so people can act to solve problems, not dodge them

@bernardoadc , you are right :+1: I had not thought about this possibility and, in this case, it is interesting that degit uses git.
Since gittar is a good alternative when all you want is to clone public repos, I believe that we have good options for any case.

I know this thread is covering a lot of different issues now, but I had the same "could not fetch remote":
npx degit "sveltejs/sapper-template#webpack" sapper-test
! could not fetch remote https://github.com/sveltejs/sapper-template
! could not find commit hash for webpack

but it turns out that my .gitconfig in my home directory had an invalid http proxy that I could no longer access. Hope this helps someone.

I was getting this same error trying to run degit through npx. Once I installed degit globally, everything worked like a charm

I run this "degit sveltejs/template my-svelte-project" on git terminal not the cmd .. and it works .
just right click then choose git bash here and run the command there . I hope that will be helpful .

fregante's mention above of #242/#207 helped me figure my encounter with this error message out
when I ran it with the -v option per Conduitry's suggestion I got: > destination directory is empty, not helpful.
but the problem was I needed to append the branch, #trunk in this case, because this repo does not have a master branch.

Note that Github itself has seemingly begun to default new repos to a main branch.
Today I ran into what looked like a degit issue (! could not find commit hash for master) which actually wasn't degit's problem. There indeed wasn't a master branch. As soon as I created one and ran degit again there was much joy.

A PR adding a check to see which branch is available between main and master can solve the scenario mentioned by @netaisllc .

D:\ANZ104AngularDemo\ANZ104AngularDemo\angular\taskbox>degit chromaui/intro-storybook-angular-template
! could not fetch remote https://github.com/chromaui/intro-storybook-angular-template
! could not find commit hash for HEAD
Pls give a solution...

hi @rajeeshsays, please open an issue on the repository in question, as:
npx degit chromaui/intro-storybook-svelte-template taskbox

from intro-storybook-svelte-template works fine, and the command that you presumably ran correctly in a supported environment is in their readme:
npx degit chromaui/intro-storybook-angular-template taskbox

installed the latest git version 2.34.1.windows.1
Failed with same error

... it does display the underlying error if you call it with the verbose -v flag

For @NateDawg360 and everyone else: please use -v (verbose mode) to display the root cause, as already explained on the thread by Conduitry

I am also getting this error while using the JS Api I am on Arch Linux, with git installed.
Setting cache to false, solves this.
Enabling verbose does not result in a more descriptive error.


Slab Buildmode removes items even in creative move.

Describe the bug
When placing layered slabs, either vertical or horizontal, with slab buildmode, either with the command or holding the button, the first one will place the slab, then the second will remove the item from your inventory when you place it
To Reproduce
Steps to reproduce the behavior:

Place the first one, it keeps the item in your inventory and makes the slab.

Place the second one, this one removes the item from your inventory when placed.
Expected behavior
The item should not be getting removed from your inventory in creative mode.
Additional context
Quarter and Eighth blocks don't cause the same issue (these don't let you build it up to a full size block with slab buildmode instead)

This is now fixed and will be included in the next update. 0.1.4


Not working with Selenium Standalone Containers (due to protocol changes with GeckoDriver) > 3.4

What are you trying to achieve? (Expected behavior)
Trying to use the latest selenium standalone docker, e.g. image: "selenium/standalone-firefox-debug:3.6.0-3.6.0-bromine, or even 3.5.3-boron.
What do you get instead? (Actual behavior)
Exception after exception
How could the issue be reproduced? (Steps to reproduce)
Using the docker instructions run a local standalone firefox selenium container. Try to use this library and you'll not get very far.
Revert to an older image (e.g. working = image: "selenium/standalone-firefox-debug:3.4.0-dysprosium"), will work perfectly well with this library.
Details

Php-webdriver version: 1.4.1 (latest at time of writing).
PHP version: 7.1.9
Selenium server version: anything > 3.4
Operating system: whatever the docker container is based on
Browser used + version: Firefox

The issue came more from the GeckoDriver than from Selenium itself. There is a new Webdriver Specification which is implemented in the GeckoDriver and this project still uses old Selenium JsonWireProtocol.
There are plans for supporting the spec as mentioned here (#469).
By then, we will have problems supporting new Selenium releases.

Yeah, I've recently dropped using this library in favour of the Ruby and Python bindings as they seem to work using the new W3C WebDriver protocol and also fully support actions too. On top of that it means we can use the latest selenium standalone containers. Looks like a serious work to upgrade the php-webdriver though :/

Updated the title of this issue to reflect the actual issue more clearly.

Hi @dlgoodchild , thanks for the report.
This is a known issue, caused by the fact that Selenium since version 3.5 do not translates to the W3C protocol by default, and firefox does only support the W3C protocol. The W3C protocol is not yet fully implemented in php-webdriver, so in meanwhile, you could either use Chrome (which works pretty well), or Selenium 3.4, or it is not a problem to disable the W3C protocol in Selenium (as mentioned in #469), using selenium option -enablePassThrough false. For docker, this would mean something like this:
docker run -p 4444:4444 -p 5900:5900 -e SE_OPTS="-enablePassThrough false" selenium/standalone-firefox-debug:3.6
(However, you will still face some issues, with actions() etc.)
Closing this, as this will be solved by #469 .
Thank you


Improve/provide original details

List of requests (do note that firmware is defered via #136)

[ ] Fetch hardwarwe version (str|None)

[x] Hardware version displayed

[ ] Add mac addresses (str|none) where applicable

[x] Gateways
[x] Plugs
Added preliminary tests on legacy anna, anna fw42, and adam_multiple_devices_per_zone
[ ] Decide on more testing

[ ] from actuator functionality (xml) import

[x] inside objects as <actuator_functionalities> -> <thermostat_functionality id= -> below entries
[x] <lower_bound>4</lower_bound>
[x] <upper_bound>30</upper_bound>
[x] 0.1 (step in HA)
Added preliminary tests on legacy anna and anna fw42
[ ] Decide on more testing

Working code (as in: needs refactoring left and right)

Rebased, also created #136 for firmware update for a future PR

Yes! We're getting there :)

Looking good, everything should be complete with the last addition 👍


[TASK-7] [Logic] As a user, I can load more or refresh surveys list

https://github.com/minhnimble/android-surveys-list/projects/1#card-46082926
What happened
When users are looking at the surveys list, they will be able to scroll to the end of the list to load more or pull down to refresh the list.
This PR is for handling load more items logic when user scrolls and reaches to the end (right most) and refresh items logic when pulling down to refresh. Also, update UI to remove ViewPager, replace with animated TextView and ImageView and set the Next Button to be static on the screen to match with design. I cannot use the ImageSwitcher and TextSwitcher due to the fact that it cannot be constrained properly with Constraint Layout. Need to investigate further why but for now I will use the Animator instead to achieve the same behavior. 🙏
Insight

[x] Implement pagination logic to load more surveys
[x] Implement caching logic after loading more surveys
[x] Implement pull down to refresh logic to refresh the contents and load the new initial surveys list page
[x] Implement clear cache logic when refreshing the contents
[x] Extend surveys list API to support pagination
[x] Use animated TextView and ImageView and static Next Button on screen.

Proof Of Work
Load more logic:

Pull down to refresh logic:

Hi @manh-t, I fixed and reply all your comments via 13d0d52. Please help me take a look again.
@hoangnguyen92dn, @sleepylee, @luongvo please help me review this PR as well 🙏

Hi @manh-t and @hoangnguyen92dn, thanks so much for your reviews and suggestions, I updated everything here 6b3692a, code also looks much cleaner, please help me take a look

...I think we just need to cache survey list in in-app memory rather than database. If we store in the database, could we display survey to UI in case no connectivity

Yeah right now if you loaded some data in previous session and restart the app without connection, it will display cache data. Not sure why you just want to just cache survey list in in-app memory? 🤔 Caching in database will provide a much better users experience... 🧐

And as the quick look, there are some unused classes and imports (DiffUpdateAdapter, RetrofitModule), can you check again to make sure clean unnecessary things from your code base.

Scanned and updated, thanks for reminding me about this 🙏


[Request]Steam community workshop [video] [wallpaper engine etc.]

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting a new site support request
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that none of provided URLs violate any copyrights or contain any DRM to the best of my knowledge
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and am willing to share it if required

Region
japan
Example URLs
https://steamcommunity.com/sharedfiles/filedetails/?id=[number]
https://steamcommunity.com/profiles/[steam id]/myworkshopfiles/
Provide a description that is worded well enough to be understood
Request websites to be able to download from links https://steamcommunity.com/sharedfiles/filedetails/?id=[number] and from profile's workshop items https://steamcommunity.com/profiles/[steam id]/myworkshopfiles/
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
none

https://steamcommunity.com/sharedfiles/filedetails/?id=[number]

https://github.com/yt-dlp/yt-dlp/blob/be3579aaf0c3b71a0a3195e1955415d5e4d6b3d8/yt_dlp/extractor/steam.py#L20
this one should be supported

Complete Verbose Output
none

also, please show your verbose output

closing since there's not even actual urls given


Enable OCIS to log to a file

As per other software (nginx, apache, ...) and to make OCIS deployment more dev/admin friendly,
OCIS should have an option to log to a file.
Zerolog allows for that as we are using in in Reva so it comes out of the box.

I don't think we should implement logging to a file. logging to stdout/stderr is already handled out of the box by docker and systemd.
When starting it as a systemd unit stdout logging is already taken care of, see http://0pointer.de/blog/projects/journalctl.html

[...] the journal is a component of systemd, that captures Syslog messages, Kernel log messages, initial RAM disk and early boot messages as well as messages written to STDOUT/STDERR of all services, indexes them and makes this available to the user. It can be used in parallel, or in place of a traditional syslog daemon, such as rsyslog or syslog-ng. [...]

The official docker containers for nginx and apache even redirect their logfiles to stdout to let docker capture them, see https://docs.docker.com/config/containers/logging/
Logfiles seem to be a step back, don't they?

Let me explain you the workflow we have for logs:
Our daemons create log files that are stored in the local filesystem for a period of time (3 months).
A fluentd agent tails the logs file and ships them to a centralized sink for post-processing and ultimately to ES/InfluxDB.
By having OCIS not having the possibility to write to a file when technically is possible, means that we need to configure another dependency (rsyslog or systemd) to accomplish that.  Less external dependencies the better, etcd is also another one part of the picture.
I thought to the goal was to run OCIS of the box, but this is currently not possible as many core functionalities are delegated to external services.

Related discussion on Talk https://talk.owncloud.com/channel/infinitescale?msg=EXpyWL3vhPvi8uP8P


Please tag and release 2.1.0pre

https://rubygems.org/gems/axlsx/versions/2.1.0.pre
The version has been published to rubygems but no release has been tagged.
Thank you

Closing this issue. Release will be handled in #501


Improve consistency of orchest-webserver telemetry events

Description
Minor PR to improve the consistency of the payload schema of telemetry events sent by the webserver.

LGTM! Just not completely sure about the branch this is merging into, but I guess that is also fine.

Should have probably branched off directly from a common parent branch, will do so next time


kube-apiserver: Adapted initial delay seconds of livenessProbe to livez-grace-period

How to categorize this PR?

/area control-plane
/kind cleanup
What this PR does / why we need it:
This pull request adapts the initial delay of the kube-apiservers liveness probe to the grace period of the livez endpoint defined in the kube-apiserver args.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Relates to  https://github.com/gardener/gardener/blob/7145aa25f9523945ec7bfbd257ec9101176ade4c/charts/seed-controlplane/charts/kube-apiserver/templates/deployment.yaml#L142
Release note:

Liveness probe of kube-apiserver is now adapted to the grace period of the /livez endpoint.

Thank you @mganter for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

Thanks @mganter!
/reviewed ok-to-test
Can you please explain the rationale of this change? Why do we need it/what is currently happening without this change?

OK, thanks, I see. So, without this change, we might report kube-apiserver pods as "healthy" too early (after 15s) although some of the post-start hooks are not yet completed. Consequently, it's better to wait for the 1m (livez-grace-period) before starting the ready checks because after this time non-finished post-start hooks are indeed reported as "unhealthy", right?

That's exactly what we want to achive

/author-action

HI there, we did some tests regarding livez-grace-period, it seems like it doesn't have any effect. I will close this PR until i have more accurate information.


Clause 7 for pub

DO NOT MERGE
Clause 7 branch prepared for the purpose of publication. Also contains some editorial changes.

@tomkralidis -- As discussed, this is a branch dedicated to the publication of clause 7 in the WIS2 manual.  After your review, I will proceed with following through with the other specs.


Documentation is seriously outdated

Version
2.0.13
Platform
NA
Description
Block in https://github.com/gakonst/ethers-rs/blob/ethers-v2.0.13/ethers-core/src/types/block.rs and https://docs.rs/ethers/2.0.13/ethers/core/types/struct.Block.html do not have the same number of fields

Documentation is not outdated, it's built with --all-features, which excludes all the #[cfg(not(feature = "celo"))] fields.

@DaniPopes I see. Well then we need it to be mentioned. Most users are not using it for Celo so non-Celo-only fields still need to be included.


Duplicate file finder

Description of the new feature / enhancement
Find, sort, delete duplicate files based on first ceation date or a filter by name or other specifications etc
Scenario when this would be used?
i now use a third party to do sorting for my photography work.
Supporting information
No response

I'm convinced there are many good apps that do this already.

I am in favor of such tool. If one the duplicate file has the " (1)" ending, it should delete that file with priority. But it should always do the comparison based on file hash, since the files with <filename [ (int)]> don't have to be the same in content. Typical example is downloading documents from some generators - such as a bank report, which are usually always named the same - while downloading such files, it gets renamed with the int counter, but are in reality different documents.
@Jay-o-Way that is not a very practical comment. You only inform us, that there are other 3rd party tools. That is irrelevant - 1) it is true for most of power tools, 2) the main driver behind power tools is to have native tools to avoid the need for 3rd party for every little job. 3) you don't even link them.

/dup #8100


board.GetPiece() doesn't return correct piece after board.MakeMove()

im using EvilBots MoveIsCheckmate as an example here:
    // Test if this move gives checkmate
    private bool MoveIsCheckmate(Board board, Move move)
    {
        board.MakeMove(move);
        Piece piece = board.GetPiece(move.TargetSquare); // i added this line for debugging this issue
        bool isMate = board.IsInCheckmate();
        board.UndoMove(move);
        return isMate;
    }

if you use the debugger in Visual Studio and step into this function, you can see that the variable piece is null, even though it should be the piece you moved.
im not sure why this happens.
what i do know is that if you go much deeper in the variables of board and look at the Squares, you can see that the piece you moved is at the correct square. So i imagine that there's somehow something not being done in the board.GetPiece() function

Hi, this was a bug in the original version. Please make sure you have the latest version (you can see the Change Log section in the readme for more details).

oops, i didnt fork the project so i didnt have the latest version.
my bad.
thanks for the fix

No worries, sorry for the bug!


Merging hal.device.switch feature branch.

Adding a new hal.device.switch op that allows us to nicely generate backend/device-specific logic that can be transformed into efficient code for runtime. There's a lot of folders needed to help here, however this initial structure will let us begin work on #1168 as it exposes the ability to generate device-specific dispatch ops.
Future iteration will add more device matchers to allow more fine-grained codegen. For example, matchers that look for supported device-specific extensions, minimum allocation alignment, unified vs. discrete memory, maximum descriptor set count, etc can all be added in a generic way and efficiently lowered to runtime code.
Progress towards heterogeneous execution will cause the !hal.device type to change to a hal.device<ordinal> form, allowing better compile-time evaluation of the hal.device.switch blocks when placement happens. For now we still only have a single runtime-selected hal.ex.shared_device so this cannot happen.

(this will require a submodule update as it is dependent on https://reviews.llvm.org/D77455)

Just an FYI, you could use TypeSwitch for this

Wow, nice! Done!


Fix bad report by jsx-no-comment-textnodes

The rule was reporting usage of two slashes via html entities at the
beginning of a literal between JSX elements. Since that is not a valid
comment, there should be no error reported by this rule.
Closes #1517

Thanks!


No release assets for v1.8.0

It looks like the release workflow failed. There are no binaries or container images for the release.

Thanks for the heads up, looking into it now!

Thanks @ecordell!

Fixed! Looks like it was some transient networking issue when pulling base images. Fifth time's the charm.


File Pathing

Problem

When initializing this project, an error was made in the unzipping of assets, storing them in a redundant child folder of the same name as the parent folder (prework-study-guide/prework-study-guide/).

Solution

Before deployment, I would like to tidy this by moving the files up one level and removing the child folder.

Resolved following instructions: https://docs.github.com/en/repositories/working-with-files/managing-files/moving-a-file-to-a-new-location


Upgrade kafka to 2.8.1

Description
Upgrade kafka to 2.8.1
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

[ ] Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

[ ] Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

New configuration options
Deprecation of configurations
Signature changes to public methods/interfaces
New plugins added or old plugins removed

[ ] Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

Codecov Report

Merging #7883 (bfca249) into master (fcccf1b) will decrease coverage by 56.96%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master    #7883       +/-   ##
=============================================
- Coverage     71.38%   14.41%   -56.97%
+ Complexity     4081       80     -4001
=============================================
  Files          1583     1538       -45
  Lines         81863    79993     -1870
  Branches      12238    12035      -203
=============================================
- Hits          58434    11534    -46900
- Misses        19466    67610    +48144
+ Partials       3963      849     -3114

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
?

unittests2
14.41% <0.00%> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcccf1b...bfca249. Read the comment docs.


Move colors to css vars

This is the first step towards respecting the OS's theme
NOTE: This is just a first draft. There are still some hard-coded colors (mainly in shadows) that should be moved out to variables as well. You can find them easily with the regex :.*(rgba?\(|#(?!\{)). I didn't split those into vars because I wasn't sure exactly what to call them.

Looking good! Moving the other colors can certainly wait for now.


need to share my content w MS to export a PDF?

I keep a personal 5 sheet medical log a simple spreadsheet in excel Mac
I daily print PDFs off of sections in case I need to quickly share results with a doctor by sending them a PDF attachment
I just started syncing this spreadsheet with iOS excel.
I just tried to print export  a section of a sheet to PDF in iOS excel and was pushed to a badly written page giving me choices to share the content of my spreadsheet with Microsoft.
I had all the data sharing troubleshooting options turn off, so implication appears to be if I want to export a PDF of my own medical data, I need to share it with
Microsoft.
Which I will never do.
Any workarounds?  Rebuild it all in Numbers? One of the Office clones?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f9f215c4-d995-2d6c-0693-bca19f66fe2f
Version Independent ID: a9aa816b-f30d-3bbe-8fdc-204777b25dfe
Content: Connected experiences in Office - Deploy Office
Content Source: DeployOffice/privacy/connected-experiences.md
Service: o365-proplus-itpro
GitHub Login: @DHB-MSFT
Microsoft Alias: danbrown

To make it easier for you to submit feedback on articles on learn.microsoft.com, we're transitioning our feedback system from GitHub Issues to a new experience.
As part of the transition, this GitHub Issue will be moved to a private repository. We're moving Issues to another repository so we can continue working on Issues that were open at the time of the transition. When this Issue is moved, you'll no longer be able to access it.
If you want to provide additional information before this Issue is moved, please update this Issue before December 15th, 2023.
With the new experience, you no longer need to sign in to GitHub to enter and submit your feedback. Instead, you can choose directly on each article's page whether the article was helpful. Then you can then choose one or more reasons for your feedback and optionally provide additional context before you select Submit.
Here's what the new experience looks like.
Note: The new experience is being rolled out across learn.microsoft.com in phases. If you don't see the new experience on an article, please check back later.
First, select whether the article was helpful:

Then, choose at least one reason for your feedback and optionally provide additional details about your feedback:

Article was helpful
Article was unhelpful

Finally, select Submit and you're done!


Setup poetry

Resolves #30
Steps Taken To Set  up poetry

Active virtual environment
pip install --upgrade pip
pip install poetry
poetry init to generate pyproject.toml file
poetry add "alembic>=1.6.5" "pandas>=1.3.1" "psycopg2>=2.9.1" "sqlacodegen>=2.3.0" "sqlalchemy>=1.4.22" "mysqlclient>=2.0.3"
poetry add --dev "bump2version>=0.5.11" "wheel>=0.33.6" "watchdog>=0.9.0" "flake8>=3.7.8" "tox>=3.14.0" "coverage>=4.5.4" "Sphinx>=1.8.5" "Click>=7.0" "pytest>=6.2.4" "pytest-runner>=5.1" "pytest-order>=1.0.0" "django"
poetry install -v to install opencdms in itself in development mode. similar to pip install -e .

On a fresh environment, run poetry install -v to install all dependencies and dev dependencies.

Thank you @Shaibujnr, I'll try using poetry to push an update to PyPI


Issue with Folder Nesting in vite-plugin-qwik-speak-inline Plugin

Dear qwik-speak developer,
Allow me to start by thanking you for the effort and dedication put into creating this exceptional plugin, whose contribution has been immense.
I am reaching out to you because I have experienced a problem when trying to execute the "build" or "preview" functions of QwikJS. The issue lies in an error that arises with vite-plugin-qwik-speak-inline. Specifically, the error message reflects: "ENOENT: no such file or directory, scandir '/src/translations/en'".
This error does not appear in the "dev" development mode of QwikJS, which has led me to carry out a more detailed diagnosis. I found that the root of the problem is that the qwik-speak's vite-plugin-qwik-speak-inline plugin does not recognize ".json" files located in subfolders. An example of this is "src/translates/en/contact/contact.json". Despite it working correctly in the "dev" mode of QwikJS.
In other words, the vite-plugin-qwik-speak-inline plugin does not support nesting of folders, which, from my perspective, would be a substantial improvement. This capability would allow for a more efficient organization of the folder and file structure. Without it, we are forced to host all JSON files within a single folder, which can become confusing, especially in medium to large sized applications.
I would greatly appreciate it if you could provide me with some guidance on how to tackle this issue. Attached below is a code snippet that reflects the current configuration of qwik-speak in my application.
Once again, thank you for your commitment to creating this useful plugin. I am looking forward to your response.
import { server$ } from<EMAIL_ADDRESS>
import { configuration } from '~/configuration';

import type { SpeakConfig, Translation, TranslationFn } from 'qwik-speak';

const translationFiles = import.meta.glob<Translation>(
  '/src/translations/**/*.json'
);

function getAssets(): string[] {
  const assets: string[] = [];

  for (const path of Object.keys(translationFiles)) {
    let finalPath = path;

    for (const language of configuration.i18n.language.available) {
      finalPath = finalPath.replace(`/src/translations/${language}`, '');
    }

    if (!finalPath.startsWith('/')) {
      finalPath = `/${finalPath}`;
    }

    if (!assets.includes(finalPath) && !finalPath.endsWith('runtime.json')) {
      assets.push(finalPath);
    }
  }

  return assets;
}

export const speakConfig: SpeakConfig = {
  assets: getAssets(),
  defaultLocale: {
    lang: configuration.i18n.language.default,
  },
  runtimeAssets: ['/runtime/runtime.json'],
  supportedLocales: configuration.i18n.language.available.map((language) => ({
    lang: language,
  })),
};

export const translationFunction: TranslationFn = {
  loadTranslation$: server$(async (language: string, asset: string) => {
    return translationFiles[`/src/translations/${language}${asset}`]();
  }),
};

I deeply appreciate your prompt response.
Regarding my practice of making all translations available on each page, I want to point out that I adopt this strategy because it does not cause performance issues during the development phase. In the production stage, I plan to use the "inline" plugin, which will embed the texts directly into the code, optimizing its operation.
As for the "extract" command, I understand that its function is to store all ".json" files in a specific directory. However, it is not clear to me why there would be a problem if the "inline" plugin supported the nesting folder structure. From my technical point of view, if it doesn't find any more directories, it should simply get the files from the last one found. Although I'm sure there must be a conflict reason, given that you, as the creator of the system, have a deeper understanding of its internal workings.
Lastly, I was wondering if there could be an option in the "inline" plugin that allows for the nesting of folders. This could provide an alternative solution to the situation.


Refactors release end-to-end tests to include Windows

Before, we didn't test Windows. This adds tests and also makes updating
the homebrew formula depend on e2e succeeding.
Moreover, this removes a shell script in favor of gh commands which
are included in the default images.
See https://github.com/actions/virtual-environments/blob/main/images

ps I tested the commands used on a fake draft release, however the real test will be the next real one. We may have some glitches but I will fix any as they occur, as always.


Modify serial nc tests init part

During initialization phase of the 2 NC serial tests,
there is a character being sent from host to target,
based on MBED_HOSTTEST_START. The problem is that
the target firmware then creates a "new" serial on the
same serial interface. the new or should, or at least may,
induce a reset of the IP, so that the character sent by host
would be lost. So we're moving the new earlier.
the real testing part happens later, to check the next
character is not received or sent.

@mbed-bot: TEST
HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

@mbed-bot: TEST
HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

Based on the test results (even though they say failed, those are older issues), this doesn't look it causes regressions in other platforms.
LGTM

Hello @bridadan ,
I just noticed that with this PR, the MBED_37 is no more testing getc while TX is at NC state.
Is it a problem or is it acceptable ?
Kind regards
Armelle

Hi @adustm, I missed that the first time, thanks for pointing it out!
That change is actually fine because that is not the behavior being tested.

Hi
So do you need me to update the test with more case (like Serial(NC, USBRX); )?
Laurent

I have shared a proposal here but I have not proposed it for pull request yet ... let me know if you think useful or not ... depending on what you say, this would require a wider testing

I see what you're doing, though I'm not sure that I immediately see the benefit. The E character kind of acted like a sync before.
Can I ask what motivated this change? Are you seeing any improvements on your end?
In the meantime I'll run a bigger test to see what changes it has.

@mbed-bot: TEST
HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

@bridadan  Sorry if not clear.
I am proposing to add again a "getc while TX is at NC state" as suggested by adustm.
But to do this, I wanted to have a proper sync, which _ I think _ was not the case before.
Indeed, up to now target was calling MBED_HOSTTEST_START and just after that it was reconfiguring the serial link to "tx not connected + rx" - this was a raise condition to me because we're not sure whether the character from HOST would be sent before or after the new serial instance on TARGET will be created. Therefore, the character might be missed.
Maybe the thing is that I am not clear of the complete path on how  SerialNCRXTest wlll be called. Maybe a simple "time.sleep(0.5)" on HOST would be enough to ensure we leave enough time to target to delete serial instance and create new one ...

Ah I see what you're saying, thanks for clarifying!
It looks like this change has caused a regression in the NUCLEO_L053R8, I'll need to do a little bit more testing. I haven't seen any other platforms have regressions from this though.

@bridadan What is the regression that you see on NUCLEO_L053R8 ?

@bridadan : How have you noticed a L053R8 regression ? when I try to follow 'details' link above I get an ERR_CONNECTION_TIMED_OUT
As far as I know the test result is mainly unstable so far ...  so the possible errors you may see from time to time on NUCLEO boards shall anyway be fixed by another pull request:
https://github.com/mbedmicro/mbed/pull/1801

@0xc0170  I hopefully fixed the tabs issue in this new version (vim' expandtab option is definitely better than my hands made alignments )
Also Brian directly answered your questions - nothing to add from my side.

@0xc0170
Branch just rebased,
Questions were answered I think - anything preventing a merge ?


Add release notes to Zulip bot announcements

Background:
When a napari-plugin has a new release, a message should appear in the napari-hub-bot zulip chat alerting community members of an update.  However, the bot doesn't post any information about that new plugin, and community members have to manually navigate to the repo in order to learn about the update. This process is inefficient and promotes a bad user experience and explicitly including release notes could motivate developers to maintain them, increasing the health of the plugin community.
Changes:
I modified the update_cache() function in model.py to pass metadata information to the zulip bot. This information is then used to help the zulip bot find release notes from the github API and include them in it's messages. If it doesn't find anything, it will not include anything as a release note.
Testing:
Added some unit tests to test a new methods I added to help get messages from the github API and test the logic of the message generation. I also tested getting information from the github API on a jupyter notebook and posted the results here.

I then created a jupyter notebook to directly send myself zulip bot messages and was able to post messages to myself as seen in the screenshot below. Those selections of plugins cover the spectrum of the types of plugins I expect the bot to deal with when sending messages. i tested messages for plugins with v and without v in their version number, plugins with and without release notes, and plugins with and without code repositories.

I think this is a good PR for Richa to help review, can you please tag her?

Thanks for tagging me! Is there a corresponding github issue for this PR?

Yep! It's related to this

Thanks @potating-potato and @lgan-czi  - I'll make time to review this early next week, if not sooner.

@lgan-czi @potating-potato I took a cursory look at this - there are a lot of changes here (some of which I'd like to give more thoughtful feedback to) so I don't feel comfortable approving and moving forward without a more detailed review.
Given that this work wasn't discussed in sprint planning and would require some time from the hub team, I'd like to defer a review until more hub members are settled back in from PTO and we can prioritize upcoming work. I'm happy to chat more about any of this but want to be mindful of the priorities we already committed to as a team.

Sounds good!

Thanks for the chat @richaagarwal! I'll be implementing some of the changes regarding documentation and improving readability!


UST Table for REST Scrape, unsuccessful

Good afternoon!  I would like to please ask about a REST scrape of the following Service Base URL: https://services.arcgis.com/cJ9YHowT8TU7DUyn/ArcGIS/rest/services/UST_Finder_Feature_Layer_2/FeatureServer/4
How can I return CSV Rest Scrape result with full/complete count for the UST Table (not limited to only 2000 records)? Or because this is as a table and not a true layer, will a REST Scrape not work properly?  Thank you for your time in advance.

Hi!
The issue here appears to be that the service supports query cache hints which makes my standard count check always return 0 if the "cacheHint=false" option is not provided in the request. I should be able to have a fix created sometime later tomorrow.

I have pushed the change of #21 to resolve this issue. You can now scrape this service but it's quite large so give it some time to complete all the requests and let me know if anything else comes up!

Good Morning Steven!
Thanks so much for your time to help me with this issue.
I have the scrape in process, its been going for a while already - but like you said, its over 2 mil for the feature count so I'll be patient.
Jennifer Horan
Data Collection Manager | ERIS
P:<PHONE_NUMBER> Ext. 93121  C:<PHONE_NUMBER> | W: erisinfo.com
Tw: @ERISInformationhttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.com%2FERISInformation&data=05|01|jhoran%40erisinfo.com|8a334621713a404fbef508da4b2f8c88|5a6f30998a9543e9a941e2c7022c9f11|0|0|637904964860347979|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=iW%2FhAeHxheC8I196FnWa4q6yEFaV%2Fvsg3nIHs4ybxsQ%3D&reserved=0 | Li: @ERIShttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.linkedin.com%2Fcompany%2Fenvironmental-risk-information-services%2F%3FviewAsMember%3Dtrue&data=05|01|jhoran%40erisinfo.com|8a334621713a404fbef508da4b2f8c88|5a6f30998a9543e9a941e2c7022c9f11|0|0|637904964860347979|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=g0%2BFE5So6TPeyasrUrtgUln4HT5vKMgpYBMdjmp2HEI%3D&reserved=0
https://www.erisinfo.com/ca/[cid:e76bc7f5-0dad-4773-843b-3b915502d046]https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgo.erisinfo.com%2Fl%2F506521%2F2022-05-09%2Fcn9dh2&data=05|01|jhoran%40erisinfo.com|8a334621713a404fbef508da4b2f8c88|5a6f30998a9543e9a941e2c7022c9f11|0|0|637904964860347979|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=iLn4OJaxmJ%2FlSATej2WcWf1z9dwWz5sZVbKKlWTAMT8%3D&reserved=0

From: Steven Thomson @.>
Sent: Tuesday, February 14, 2023 8:39 PM
To: ClasicRando/web_rest_scraper @.>
Cc: Jennifer Horan @.>; Author @.>
Subject: Re: [ClasicRando/web_rest_scraper] UST Table for REST Scrape, unsuccessful (Issue #20)
Closed #20https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FClasicRando%2Fweb_rest_scraper%2Fissues%2F20&data=05|01|jhoran%40erisinfo.com|7057996c3f494434c83d08db0efde30e|5a6f30998a9543e9a941e2c7022c9f11|0|0|638120255823576999|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=nVsmeepTGwa7g0pwjNIBIHj2ldfPTCNL6JRi4bwB89g%3D&reserved=0 as completed.
—
Reply to this email directly, view it on GitHubhttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FClasicRando%2Fweb_rest_scraper%2Fissues%2F20%23event-8521523266&data=05|01|jhoran%40erisinfo.com|7057996c3f494434c83d08db0efde30e|5a6f30998a9543e9a941e2c7022c9f11|0|0|638120255823576999|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=nHM3aZOSEH0SEaVxuKWmFlsp7G7Q52DWMRs0%2BFnsnuk%3D&reserved=0, or unsubscribehttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA54AKIK53B6GFB7LREL7F5DWXQ6WXANCNFSM6AAAAAAU2VLVRE&data=05|01|jhoran%40erisinfo.com|7057996c3f494434c83d08db0efde30e|5a6f30998a9543e9a941e2c7022c9f11|0|0|638120255823733212|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=GpcIa5o19LIYWq3nh0hIaFZQAGcds59T%2Fj3hjah5lb8%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>


Error parsing dates of schemaless embedded documents

If I run the following query:
insert into V set events = [{"on": date("2005-09-08 04:00:00", "yyyy-MM-dd HH:mm:ss", "UTC")}, {"on": date("2005-09-08 04:00:00", "yyyy-MM-dd HH:mm:ss", "UTC")}]

I will get the following for the new vertex:
{ "events": [{"on":"_NOT_PARSED_"},{"on":"_NOT_PARSED_"}] }

Is there a way to set dates for an embedded document?

fixed in develop branch


ActiveRecord: fix for toArray serialization;

Q
A

Is bugfix?
yes

New feature?
no

Breaks BC?
no

Tests pass?
yes

Fixed issues
comma-separated list of tickets # fixed by the PR, if any

Fix toArray serialization for ActiveRecord.

Change is incorrect: in this way you eliminate aboility of usage ObjectID instance from returned array.

Without this fix BaseActiveRecord::toArray return an empty array for ObjectID

https://github.com/yiisoft/yii2/issues/5624

332edb1fa03255a1188c174e30042bbac964a4ee


Add fallback locale for 'locale that uses comma' test

OSX uses this format for locales

Or it could just be changed to 'UTF-8'. I see the other tests use that format too.

Thanks for the suggestion, I think we will leave it to current setup for now.


GH-2261 rename XMLSchema to XSD

GitHub issue resolved: #2261
Briefly describe the changes proposed in this PR:

renamed XMLSchema to XSD (because it has been irritating me for years)
kept deprecated XMLSchema class for backward compatibility

PR Author Checklist:

[x] my pull request is self-contained
[ ] I've added tests for the changes I made
[x] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change
[x] every commit has been signed off

Note: we merge all feature pull requests using squash and merge. See RDF4J git merge strategy for more details.

God yes. I always have to spend a minute trying to find it anytime I want a standard datatype.
FYI Jena is just as bad. Theirs is called XSDDatatype.


Support for VK_KHR_ray_tracing_pipeline

I'm interested in contributing towards adding support for VK_KHR_ray_tracing_pipeline, but I don't 100% understand what would be required to make this happen.
VK_KHR_acceleration_structure is already supported, and it's obvious that a RayTracingPipeline struct would be required.
Would anyone be able to advise what other work would need to be done for pipelined ray-tracing support?
Many thanks!

This is something I've been thinking about as well. My current plan is to split this into two separate PRs, each of which implements a subset of the features. First, implement the RayTracingPipeline type and its vkGetRayTracing* methods. Then, in the next PR, implement all the command buffer commands.
Of course, the ray tracing pipeline object is useless without any commands to use it. Splitting the PRs is only to make the problem becomes a bit more manageable, and so that the additions are more self-contained and easier to check and test. Divide and conquer, in other words. It also means that the whole thing doesn't have to be added by one person, the work can be divided too.

That sounds very sensible to me.
To clarify - the vkGetRayTracing* methods are these?

vkGetRayTracingShaderGroupStackSizeKHR
vkGetRayTracingShaderGroupHandlesKHR
vkGetRayTracingCaptureReplayShaderGroupHandlesKHR

I've done a bit more digging - I'm not clear on if the AccelerationStructure is suitable for use at the moment - indeed, in coverage it says "Host acceleration structure operations" are not supported but I'm not clear on what that means precisely.
The shader binding table-related items are also a bit esoteric but I think I should be able to get to work on this soon.

I'm also noticing that the Ash PipelineBindPoint enum does not contain RAY_TRACING_KHR - is this likely to be a problem?

To clarify - the vkGetRayTracing* methods are these?
* `vkGetRayTracingShaderGroupStackSizeKHR`

* `vkGetRayTracingShaderGroupHandlesKHR`

* `vkGetRayTracingCaptureReplayShaderGroupHandlesKHR`

Yes.

indeed, in coverage it says "Host acceleration structure operations" are not supported but I'm not clear on what that means precisely.

The acceleration structure operations come in two forms: the vkCmd* prefixed ones, which are recorded onto command buffers and then executed on the device, and the vk* prefixed ones, which are executed by the host rather than device. The latter kind is not very well supported by Vulkan drivers, so they were skipped for the moment.

I'm also noticing that the Ash PipelineBindPoint enum does not contain RAY_TRACING_KHR - is this likely to be a problem?

It's listed in the Ash documentation: https://docs.rs/ash/latest/ash/vk/struct.PipelineBindPoint.html. Where were you looking for it?

Ah thank you, that's my mistake. I was looking in the enums where the graphics and compute enums are defined - slipped my mind it's an extension.

I'm testing creating a pipeline and I've run into a bit of a roadblock with shader compilation:
trying to load a shader module with GL_EXT_ray_tracing : enable is panicking:
called `Result::unwrap()` on an `Err` value: a validation error occurred

Caused by:
    create_info.code: uses the SPIR-V capability `RayTracingKHR`

Requires one of:
    feature `ray_tracing_pipeline`

Vulkan VUIDs:
    VUID-VkShaderModuleCreateInfo-pCode-08742

I'm having some trouble tracking down what kind of "feature" is meant here - khr_ray_tracing_pipeline is enabled on the device. I assume it relates to SPIR-V in some way but I've not been able to track it down.

You're not the first person to be confused about "features", so I'm wondering if naming them "device features" here would help make it clear.

That seems like a good idea to me.

Yep, someone else just came to the Vulkano discord confused about the same thing! Clearly a rename is in order, haha

What's the status on this? Can I help?

I have a working fork, but it's not feature complete. I'll get it on the main repo soon.

I have created a PR to add support for VK_KHR_ray_tracing_pipeline, SBT, etc. #2564


Container builds

:tada: This PR is included in version 0.9.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


WAP settings - stuck.

Sorry, but I am missing something in how you describe what to do.
I have to rename my machine (Ubuntu) to vtrush-flash and set the password for the WAP.
And I also have to set the IP address to <IP_ADDRESS> - or so I read.
I try that, but also need to set up a netmask.   <IP_ADDRESS>
I see the  WAP from my phone but as soon as I try to connect it all just falls over.
The WAP dies.
It "worked" ok - getting IP - before but when I suspected/realised the IP also needs to be set, and did that, it just kills the WAP when the phone tries to get an IP address.

I am not getting how this is supposed to work.
The name of the WAP the board gives is not really explained, but I guess that isn't a problem.
Oh, it also has no password.   So it is an open WAP.
I have an INTEL I7 NUC running Ubuntu 18.04 LTS.  The WAP device is wlp58s0  and I edited the config.txt file to suit.
Could you help me understand why the NUC's WAP is not working and clarify if the IP address is really needed/important for it to work.

You shouldn't need to perform any of these steps manually, the script setup_ap does all this when called from start_flash. Just set WLAN=wlp58s0 in your config.txt and run start_flash.

Thanks.
So, given what you said:
That would/could explain why I lose the network icon when the script is run.
However, it doesn't come back and I see the script trying to send data.
I'll keep digging.
Appreciated.
Mind if I leave this open for now?

That would/could explain why I lose the network icon when the script is run.

Yes, you won't be connected as a station while running the vtrust-flash AP.

However, it doesn't come back and I see the script trying to send data.

When you're done, run stop_flash

But "setup_ap.sh" is in the scripts directory.
Which is not where I "am* when I run the script. I'm in the parent directory.

You'll see that earlier in the script we change directory with pushd

I am trying to do everything from one machine.

That shouldn't be a problem, it should be run from one machine. You'll only need another device to connect to the vtrust-flash AP in order to complete the pairing procedure.

@Just-another-pleb have you resolved your issue?

(Sorry been away and now playing "catch up".)
Not really.
It would seem I need two machines to do this and I am just not ready for that level of complication.
I shall get in touch with someone I know who may be able to help me.  He has done a couple of these before I believe.
Sorry to have bothered you.   (Not blaming you.)

No problem. Not sure I understand why you would need two machines for this, but let me know if I can help any further. Good luck!

Sorry to go on.  (And bother you)
I got it flashed and it is here, in front of me.
I am now a bit confused with how to set it up now.
I open the CONFIGURE part then CONFIGURE MODULE.

So I am guessing I have to "cross connect" things so the 3 relays are assigned to different GPIO pins.
Yeah, but I am not getting what is what in the picture.
(And I don't get/know/understand what to send in MQTT)
I've got the name - set to BAUHN-1- which is all well and good.  But I am stuck beyond that.
I've opened the terminal and send commands like   power1 on  and power1 off
Nothing happens.
Pressing the TOGGLE on the web page, I see the MQTT message.   But no relays change state.
Mind pointing me in the right direction?

Update:
I got it working, but not as nice as I would like.
This is the configuration screen:

You will see that I have the relays as:  1, 2, 4, 3, 5, 6.
I'll get to that.
This is the "gui" screen I see:

The only buttons that work are:  3, 4, and 5.
But those buttons are for relays 1 2 and 3 on the board.   (It only has 3 relays.)
If I make the first two "none" the other buttons don't work.
The board is (in sequential order) are:  relay 4, relay 3 and 6.
I am not able to get only 3 buttons on the screen controlling relay 4, 3, 6.
If I have anything less than what I show, the buttons don't work.
As it is:  Button 1, 2, and 6 do nothing.
Can you explain what I am missing, or is this a software problem?

Glad you figured out your flashing issue! Tasmota is a separate project, you'll need to seek help there for post installation issues.


[doc][config]Add missing transaction config in standalone.conf and broker.conf

Motivation & Modification
Add missing transaction config in standalone.conf and broker.conf
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API: (yes / no)
The schema: (yes / no / don't know)
The default values of configurations: (yes / no)
The wire protocol: (yes / no)
The rest endpoints: (yes / no)
The admin cli options: (yes / no)
Anything that affects deployment: (yes / no / don't know)

Documentation
Check the box below or label this PR directly.
Need to update docs?

[ ] doc-required
(Your PR needs to update docs and you will update later)

[ ] no-need-doc
(Please explain why)

[x] doc
(Your PR contains doc changes)

[ ] doc-added
(Docs have been already added)

@liangyepianzhou this PR adds not only missing configs but also new configs to align with #15137, correct?
If yes, can you please follow the PR naming convention to add [feature] ahead of [doc] to show the dependency with #15137? This will help everyone to better understand your PR.


Added yorickpeterse/nvim-pqf plugin

Checklist:

[x] The plugin is specifically built for Neovim.
[x] The lines end with a .. This is to conform to awesome-list linting and requirements.
[x] It's not already on the list.

Thanks for the PR!


How to enable search location/place feature?

Hello,
How can I enable search control with the ui-leaflet? As I tried but didn't find it working anyway.

Hi,
I stumbled upon the necessity to use some form of geocoding onto leaflet maps. Ended up extending the bounds with nominatim example to implement a rudimentar search box. As such, check it out and see if it helps you

I upgraded the plugin code to support leaflet v1 and added http://esri.github.io/esri-leaflet/examples/geocoding-control.html it works perfectly, thanks for the advice!! :)

Seems that it's all done, thanks.


Move Scalactic dependency to test only

"org.scalactic" %% "scalactic" should only be needed in the test artifacts.  This PR updates the build file to do that.

This should not conflict with https://github.com/databricks/spark-deep-learning/pull/151 but feel free to ignore this PR until the other PR is merged.

Codecov Report

Merging #152 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   85.37%   85.37%
=======================================
  Files          34       34
  Lines        1922     1922
  Branches       41       41
=======================================
  Hits         1641     1641
  Misses        281      281

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6be7772...0f8b258. Read the comment docs.

LGTM. I tested locally. It is fine.


[New Feature] Multiple pages/dashboards

Would be great to allow creation of multiple pages and controls to get there.

In the simplest form it could be an 'app' or 'bookmark' which loads other page (preferably in the same browser tab).

Other solution for me would be to spin another flame instance and make a bookmark to it. However bookmark/app always opens new page in a new tab. Should be the same tab replacing previous contents.

Thank you.

Easy to do by adding option to an app/bookmark to open in the same tab instead of a new.


Connect to password required cluster failed

Redis server v=3.0.4
ioredis version: 1.9.1
NodeJS: 4.2.1
Ubuntu: 14.04
var redis = new Redis.Cluster([{
port: 6379,
host: "10.240.xxx.xxx",
password: "xxxxxxxx"
},{
port: 6379,
host: "10.240.xxx.xxx",
password: "xxxxxxxx"
}]);
got error message
Error Error: Failed to refresh slots cache.

Currently there's no support for connecting to a password-protected cluster. It's not straightforward to implement this feature since the nodes may have different passwords. Although passwords can be specified when you creating a Redis.Cluster instance (like your example), ioredis may auto-detect more nodes in the cluster that have different passwords.
According to this topic: https://groups.google.com/d/msg/redis-db/Z8lMxTfDct8/Rny9BIK9xGYJ, it seems that setting passwords to the cluster may not be a best practice, and redis-trib.rb also doesn't support it.
What do you suggest given the above thoughts?

Thx, That make sense, I can use it as internal servers without password.
But I still think add password support for cluster will more secure, even you can require all Redis cluster nodes to use same password.
Thank you for your help.

Hi, this feature is implemented and shipped in 1.10.0. Refer to https://github.com/luin/ioredis#password for details. Let me know whether this works for you :laughing:

works very good for me.
Thank you


fix and new feature.

Hi! Thanks for the PR 🙌
Can you describe what you're trying to achieve here in the PR's description?
thank

Hi!
Sure, first in the filters.rb i fixed a borderline situation where this code
value = value.to_s.split(',').reject(&:blank?) if value.include?(',')

converts the value to an array where there are commas inside. This conflict with elasticsearch-rails gems that expects a string and never an array. But i think we should never return an array in this position, o idk what specific usage there is?
The second one is to fix the #2.
You can sort things like this:


Reduce scope of AWS IAM role

Currently in order to use AWS you are required to hand over full access to EC2 for your account. In order to effectively use this at a larger org the scope of this access must be reduced, for example, to a single VPC.

Gather user stories and requirements around how this application might be used inside a larger AWS account
Allow additional parameters to be injected allowing effective use of a reduced AWS role (e.g. vpc id, subnets, security groups etc)
Move optionally definable attributes from role to field (e.g. use existing security group rather than create one)

Thi is related to #372 - @kris-nova or @xmudrii would you like to consolidate the two? I intend to work on these - I know very well what orgs are needing (I started the Cloudbreak project) but currently got sucked into a longer surfing trip ... I assume, though this should be cloud agnostic somehow, reusing similar features/concepts across providers (e.g. Azure).
Shall I make a larger user story for this, and breaking down on smaller pieces, see if people would like to pick some of the tasks?

@matyix if you are willing to work on these issues we trust you to divide the work as you see best fit.

@kris-nova please see #472. Half of the issue is done now, for the reuse there is a partial code, however I'd like to discuss it through as it can affect other providers and a path in the codebase which is frequently used. As an example - if the cluster is reusing an existing VPC, when it's deleted and the user has an appropriate role the delete process will remove the VPC as well, as it has no notion of whether its new or has been reused.
I am sending you a DM and lets find an appropriate time to quickly go through these (and a few others), I assume it's faster over a call. Only issue is that I am deep in the middle of Indian ocean surfing, so I am most likely 12 hours ahead of Pacific time.


Issue with Linux build & docker

Fetching gem metadata from https://rubygems.org/...........Fetching gem metadata from https://rubygems.org/..Resolving dependencies...
Bundler could not find compatible versions for gem "bundler":
In Gemfile:
rails (= 4.0.3) was resolved to 4.0.3, which depends on
bundler (< 2.0, >= 1.3.0)
Current Bundler version:
bundler (2.0.1)
This Gemfile requires a different version of Bundler.
Perhaps you need to update Bundler by running gem install bundler?
Could not find gem 'bundler (< 2.0, >= 1.3.0)', which is required by gem 'rails
(= 4.0.3)', in any of the sources.
Bundler could not find compatible versions for gem "coffee-rails":
In Gemfile:
coffee-rails (~> 4.0.0)
turbolinks (= 2.2.1) was resolved to 2.2.1, which depends on
coffee-rails
Bundler could not find compatible versions for gem "turbolinks":
In Gemfile:
turbolinks (= 2.2.1)
jquery-turbolinks (= 2.0.2) was resolved to 2.0.2, which depends on
turbolinks
ERROR: Service 'fluxday-app' failed to build: The command '/bin/sh -c bundle install' returned a non-zero code: 6

Hey @ggalia I had the same issue, @_@

Using #83b2c6b85e21db96461080f767fcec55cebd10f0
O/S : Ubuntu 16.04

I hope this will help, as sudo type : gem uninstall bundler
it will ask you which version, but just to be safe uninstall all the versions...
next gem install bundler -v '1.17.3' --source https://rubygems.org/
And got myself working ^-^!


vertical progress line now showing in Right to left layout(Arabic)

vertical progress line now showing in Right to left layout(Arabic)

. please check this.

Hi @azarhaneef96 could you please provide code sample or a reproduction project for us to investigate this better?


Add a Bun migrator

Per discussion on #6, Kodergarten is using uptrace/bun for migrations. This issue is to track the addition of a Bun-compatible migrator to the project.
While Bun supports golang code migrations, the implementation will most likely only be able to support .sql-file migrations, similar to the golangmigrator. This is due to needing a hash of each migration's contents in order to correctly implement the migrator's Hash() method.

Done thanks to @BrynBerkeley !