Integrations as their own resource types

Currently, integrations are configured by calling methods on the resources. For example:
bucket.addEventNotification(s3.EventType.OBJECT_CREATED, new s3n.SnsDestination(topic));

There will be support for generic function calls, but for this particular pattern, the UX would be better if we had integrations as their own resource types. Something like:
"SnsDestination": {
  "Type": "aws-cdk-lib.aws_s3_notifications.SnsDestination", // Maybe a different name
  "Properties": {
    "bucket": {
      "Ref": "MyBucket"
    },
    "eventType": "OBJECT_CREATED",
    "topic": {
      "Ref": "MyTopic"
    }
  }
}

For this specific example, I think the right way would be to introduce an extended design to the underlying CDK module.
Spefically we could have a top-level classes/constucts s3n.SnsNotification(props) that wraps the above calls.

Out of scope for now. If we decide to bring this back, it will need some deeper discussion and design.


Biblatex Annotation Import Bug

Sorry to bug you with another Biblatex bug, but according to the Biblatex Chicago documentation, annotation is an alias for Bibtex's annote Entry field. However, annotation fields are imported differently by BBT than annote fields (annotation fields end up in the extra field).
Additionally, note entry fields end up in the Extra field as well. Given that note is for "bibliographic data that doesn’t easily fit into any other field," this may well be intentional.
Thanks as always for the hard work!

Do you you have a sample for me?

Yep:
@Book{Demus1984,
Title                    = {The Mosaics of San Marco in Venice},
Author                   = {Demus, Otto},
Date                     = {1984},
Location                 = {Chicago},
Publisher                = {University of Chicago Press},
Annotation                 = {a "monumental" work on the mosaics of San Marco},
}

The problem is fixed but github is experiencing an outage which prevents a release. I think that as soon as the outage is resolved the release process will be started automatically, but I'll try to keep an eye on it.

The release is out.


Implement fixed length packets

I found that a lot of cheap NRF24L01+ knockoffs do not work with variable length packets. It would be nice to have support for fixed length packets so I can sniff the communication of those modules, too.

Resolved by PR https://github.com/omriiluz/NRF24-BTLE-Decoder/pull/3


Guidance for MS-Organization-Access certificates, transitioning from Azure AD Registered to Hybrid Joined

We have completed a transition from Azure AD Registered Workstations to Hybrid Joined (all Windows 1709). Historically with Azure AD Registered workstations (Synced using AD Connect), Azure would issue an "MS-Organization-Access" certificate to the MY (Personal-User) certificate store, this certificate was then accessible by all our standard browsers: Edge, IE and Chrome. We could then pass Device Context claims and manage access in ADFS using Device Authentication.
The behavior has changed with Hybrid Joined devices, the MS-Organization-Access certificate is now added to the local computer certificate store, and Microsoft's own documentation has indicated that this was by design to ensure that Hybrid Devices could always pass Device Context claims regardless of who is logged into the device.
Our testing has shown however that Edge doesn't actually parse the computer certificate store the way it's supposed to, and Chrome can't. There is an add-on available for Chrome, but it doesn't support Federated Identities. Ultimately what we're left with is being stuck between two worlds: with Azure AD Registration only, all our browsers can pass Device Authentication silently, but we miss out on a lot of great integration features, with Hybrid Joined devices, we get more advanced capability but we actually are in a worse position when it comes to seamless authentication.
We've been trying to figure out if there is a way to force a device to request an MS-Organization-Access certificate that will be placed in the personal user store even while being Hybrid Joined, but so far it doesn't appear to be possible.
The documentation certainly doesn't describe the change in behavior, and any organization, like ours, that wandered into this without any warning about the change in authentication behavior when using federated identities could end up with some significant challenges that Microsoft hasn't provided any guidance for resolving.

@dustinadam We will now proceed to close this thread. Please open a new GitHub on the document you are providing feedback on and we will surely help you with it.
Also if there are further questions regarding to an issue with implementation, please open a new MSDN forum post and community will help address your query. Please refer to below link to MSDN forum to ask new question -
https://social.msdn.microsoft.com/Forums/azure/en-US/newthread?category=windowsazureplatform


It toke too much time in "Initializing TorchBackend in DeepSpeed with backend nccl " this step!

I work it in docker contrainer,  CMD:  docker run --gpus all --shm-size=512g xxxx
pip list :
nvidia-nccl-cu11         2.14.3
torch                    2.0.0
When I start to run:  ./scripts/run_finetune.sh  or run_evaluation_with_lora.sh
It will stuck  "Initializing TorchBackend in DeepSpeed with backend nccl "  this step for almost 10 minutes.
But it can runs normally after this.
My HPC is 8*A100 SXM.
I try with my PC which only have 1* GTX1080 , it run normally, no stuck.
Are there any missing parameters when I starting the container?

Hi,
If you are trying to finetune a relative large model (33B, 65B), it do take some time to initialize and load. You may first try 2*A100 which should take within 5 minutes to see if it works on your machine. Then you can try 8 * A100 and wait for longer time.

Hi, If you are trying to finetune a relative large model (33B, 65B), it do take some time to initialize and load. You may first try 2*A100 which should take within 5 minutes to see if it works on your machine. Then you can try 8 * A100 and wait for longer time.

Thx for reply, I have solved the problem, as long as the environment is connected, it will be normal. Previously, my environment was not connected.


I noticed that loc_loss uses l1 loss instead of smooth l1 loss. Does l1 loss perform better?

As the title says, does the l1 loss have a better performance than the smooth l1 loss, is there any relevant data? Because in your paper, the regression loss uses a smooth l1 loss.
I am looking forward to someone who can answer me, thank you.

https://www.jianshu.com/p/19483787fa24

@chun-chun123
Yes, as the article says, smoothL1 has many advantages.
https://github.com/STVIR/pysot/blob/052b9678a7ed336752f74dc6af31cc00eb004551/pysot/models/loss.py#L31
But I saw in the code that L1 loss was used, so I asked this question.

This is actually a great question.
I don't think Bo et al. had tried smooth_l1_loss, you are definitely welcome to have a try and share the result with us.


similar projects

@ouven @blstream
Hi guys,
it look like you are working on something really similar
https://index.scala-lang.org/ouven/akka-visualmailbox
https://index.scala-lang.org/blstream/akka-viz

Hi,
my approach is meant to be less intrusive. So I use no dependencies and you can start vizualizing without recompiling your artefacts. As this is one of the primary design goals https://github.com/ouven/akka-visualmailbox has less vizualisation opportunities then this project.

Hi @ouven @MasseGuillaume
To use akka-viz you don't need to recompile anything, we use runtime weaving, all you need is just add akka-viz jar dependency and make sure you run with AspectJ weaver. (or use the sbt-plugin)
Our plan for akka-viz was to make it more like debugger for Akka, to make developers life easier. Thats why you can see internal state of the actors, payload of exchanged messages and have Websocket REPL to experiment with the actors. You can enable monitoring when you need it - for example when you notice some kind of deadlock in actor systems - with akka-viz disabled (you can toggle that using web UI) overhead shouldn't be too big.
Unfortunately in recent months development halted as we moved to different projects/companies. If you have any comments, questions or ideas how to review that project, or what features you would like to see please share.


General question about persistance in Policy Reporter

Hello, Community.
I am totally new to policy-reporter, so because of that I am wondering whether some Persistance is needed for Policy-reporter to save it`s data after reboot?
I am curious about that since I tried to deploy some pod that violate my policy "disallow-latest-tag". Later in "Logs" tab into "Policy-Reporter UI" I found entry about violation. But after reboot of deployments of policy reporter and policy reporter ui, this log entry disappeared.
Maybe logs entries is not so important but another stuff like (Cluster) Policy Reports is important.
So my question: Is it possible and is it needed to add some persistence(persistent volumes) to policy-reporter/ui, for saving some important data like (Cluster) Policy Reports, after reboot/fail/disruption.
Thanks in advance!

Hey, in general you don't need additional persistence.
The Logs page is an simple in memory notification target, to show case the notification feature. Notifications are only send for new results, after a restarted the already existing targets are skipped, to not spam the targets with duplicates.
But the internal Database and Views are recover from the (Cluster)PolicyReports in your cluster after a restart. The PolicyReport view should show the some results as before.
If you want a persistent Logs view, you can configure a Redis cache for it but I would recommend to use metrics or another target for timeseries information like Loki or Elasticsearch.
For the other UI pages additional persistence is not required.

Hello @fjogeleit! Thanks for reply.
Maybe you know how to send to Slack notification with Information that i see in "Logs" tab? For example I deploy some resource that are not compliant with some policy and this resource was blocked by policy. And I want to receive slack notification about this. But I don`t want to receive notifications for (Cluster) Policy result that visible into UI, only when something is was blocked by policy.
Thanks in advance!

You need to enable the kyverno plugin for this. Because Kyverno does not create policy reports for blocked resources by default.
See: https://kyverno.github.io/policy-reporter/guide/helm-chart-core#enable-enforce-violation-policyreports-requires-kyverno-170
In the slack notification config you can set the source filter to only send Kyverno Event events. So only blocked resources create a notification.

Thanks, it`s working!
Maybe you know is there a way to specify from which cluster the notification received?
For example, I have two different EKS clusters and single Slack channel to receive notifications. In notification I see only pod name but there no information about which cluster the notification coming from.

Alle notification targets have a customFields config which you can use to add static information to the notification like:

target:
  slack:
    minimumPriority: "warning"
    skipExistingOnStartup: true
    customFields:
      cluster: dev-1

@fjogeleit is it possible to show correct time in the Policy Reporter UI? Since in every event I see something like on screenshot.

I will take a look

I created a new plugin version, you can set it in your values.yaml at this path: kyvernoPlugin.image.tag: 1.6.4.
It should fix the time for new created entries.


Unable to highlight text

Expected behavior
We should be able to highlight text
Actual behavior
Unable to highlight text
Steps to reproduce
Version: 0.8.0 (Chromium:76.0.3803.0)
Type .api for help and .exit to quit

openBrowser()
✔ Browser opened
goto("github.com")
✔ Navigated to url http://github.com
highlight("Sign in")
✔ Highlighted the element matching text "Sign in"

Versions
➜  issue535 taiko -v
Version: 0.8.0 (Chromium: 76.0.3803.0) 574e989dc09432ddcf4494e44257d63da4c8bf53

Fix available in b04dbbf

This issue has been verified and found fixed with the commit version b04dbbf


Max Idle Queue Retention Period is set to 5 minutes

The maximum idle queue retention period is set to 5 min in the AmazonSQSIdleQueueDeletingClient ( https://github.com/awslabs/amazon-sqs-java-temporary-queues-client/blob/master/src/main/java/com/amazonaws/services/sqs/AmazonSQSIdleQueueDeletingClient.java#L73 ).
This upper bound appears to be arbitrary without a technical limitation keeping users from specifying a larger value.
Services with longer running tasks may not send/receive messages on the temporary queues as frequently as 5 minutes meaning that virtual queues can be unexpectedly deleted even when they are in use

Good suggestion and safe enough to raise within reason. What is the maximum period you intend to be able to set?

Services with longer running tasks may not send/receive messages on the temporary queues as frequently as 5 minutes meaning that virtual queues can be unexpectedly deleted even when they are in use

Just to clarify, the IdleQueueRetentionPeriodSeconds attribute only controls how long a queue can sit empty and without any API calls before it is a candidate for deletion. A host queue will always have at least one background thread polling it via ReceiveMessage calls and hence keep it from being idle, and virtual queues are usually polled in a similar way as soon as they are created (. This parameter is intended to be tight enough so that queues can't be leaked for TOO long, but loose enough to allow for potentially pauses in the processes using queues (e.g. garbage collection). Do you actually need this period to be longer than 5 minutes?


Automated Package Upgrade

:tada: This PR is included in version 25.6.66 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Not being able to set chunk size for local.ai embeddings

https://github.com/Mintplex-Labs/anything-llm/blob/5ad8a5f2d0c545a913319a641877d70aa7b82b09/server/utils/EmbeddingEngines/localAi/index.js#L16
Why is this not configurable using EMBEDDING_MODEL_CHUNK_SIZE or something? Because some embedding models need lower chunk sizes.
For example, sentence-transformers/all-MiniLM-L6-v2 has a default of 256 "word pieces".

- this.embeddingChunkLimit = 1_000;
+ if(!process.env.EMBEDDING_MODEL_CHUNK_SIZE)
+   this.embeddingChunkLimit = 1_000;
+ else {
  let size = parseInt(process.env.EMBEDDING_MODEL_CHUNK_SIZE)
  if(size === NaN || size <=0) throw new Error("Invalid int for EMBEDDING_MODEL_CHUNK_SIZE.");
  this.embeddingChunkLimit = size;
}
```Should do the trick.

This is not the size of a chunk, its how many chunks can be sent at once via the API. Most embedding apis allow you to send many n long chunks at the same time so you dont have to send a request n times.
That is what the 1,000 is actually referring to. I imagine that with LocalAI, it cannot handle more than one request at a time though and that is likely the issue

Apart from this, I kinda doubt you can append 2 embeddings, as they would represent 2 different meanings.

https://github.com/Mintplex-Labs/anything-llm/blob/master/server/utils/vectorDbProviders/qdrant/index.js#L172-L180
I found this code, as said: not every embedder can process such amount of tokens at once.


Separate "waiting period threshold" into own setting.

This PR follows-up on #12276 to separate the "waiting period threshold" based on discussion in Zulip.
Quoting from the first commit:

This commit separates the waiting_period_threshold setting from
the create_stream_policy setting, adding a new setting that the user
can use to select a waiting period threshold.
Both the invite to stream policy and create stream policy now have three
options: admins only, members and admins, or members after waiting
period/admins.

cc @rishig @timabbott
Testing Plan:
I've updated the frontend tests (both node and casper) and tested manually.
GIFs or Screenshots:

I assume for "new users" we want to have it just be "All members with ..." -- admins shouldn't ever have that tag, I think?

I've updated this PR after discussion in Zulip with @rishig.

I've added a new commit that changes the terminology used based on this conversation.

@rishig can you review the UX on this?

Thanks David for your work on this! The commits had a number of changes mixed together, so I separated them out a bit and made a few wording and variable name changes as well.
The three commits ending in https://github.com/zulip/zulip/commit/c3af126766af8727bb689f8762791a2da3754f2a
have the changes to the code. Would you be able to take a look and also update the tests?
Once this is merged I can deal with updating and merging the documentation commits.
Thanks again for your work on this!

@rishig I've updated this PR with the commits from your branch (GitHub orders them strangely, but they look fine locally so I assume it is just a rendering issue).
I've fixed the tests so they pass after your changes.

Tim, just making sure this isn't blocking on me?

Oh, I definitely thought this waiting on you, sorry about that!  Looking now.


NIFI-4775: FlowFile Repository implementation based on RocksDB

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Provides a FlowFile Repository implementation which makes use of the RocksDB key-value store.  It uses periodic syncronization to ensure that no created or received data is lost (as long as nifi.flowfile.repository.rocksdb.accept.data.loss is set false).  In the event of power loss, work done on FlowFiles through the system (i.e. routing and transformation) may still be lost.  Specifically, the record of these actions may be lost, reverting the affected FlowFiles to a previous, valid state.  From there, they will resume their path through the flow as normal.  This guarantee comes at the expense of a delay on operations that add new data to the system.  This delay is configurable (as nifi.flowfile.repository.rocksdb.sync.period), and can be tuned to the individual system.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[x] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

+1
This implementation has been in use on high volume data flows for several months without incident. Not only is it a great addition, it has proven to be very reliable. Impact on performance has been negligible.


TypeError [ERR_INVALID_ARG_TYPE]: The "code" argument must be of type number. Received type string ('ENOENT')

When I am trying to install cordova-plugin-firebasex with cordova android 12, I am getting this error
TypeError [ERR_INVALID_ARG_TYPE]: The "code" argument must be of type number. Received type string ('ENOENT')

i'm getting the same error running cordova build android with cordova android 12.

Please validate your local build environment by building the example project which is a known working codebase.
Below is the console output of the example project building with the latest plugin version using cordova-android@12 in my local build environment.
If you can reproduce the error with the example project, please fill out the issue template including the full console output, appending the --verbose argument to the CLI command which raises the error.
If the issue template is not filled out fully with your environment info and details of the error, I will be unable to investigate and this issue will be closed.
Console output

console output

$ cordova -v
12.0.0<EMAIL_ADDRESS>
$ node -v
v16.13.2

$ cmd /c ver

Microsoft Windows [Version 10.0.19045.3803]

$ git clone https://github.com/dpa99c/cordova-plugin-firebasex-test
Cloning into 'cordova-plugin-firebasex-test'...
remote: Enumerating objects: 878, done.
remote: Counting objects: 100% (207/207), done.
remote: Compressing objects: 100% (83/83), done.
remote: Total 878 (delta 145), reused 178 (delta 124), pack-reused 671
Receiving objects: 100% (878/878), 506.61 KiB | 1.12 MiB/s, done.
Resolving deltas: 100% (513/513), done.

$ cd cordova-plugin-firebasex-test/

$ cp ../../Git/cordova-plugin-firebasex-test/google-services.json .

$ cordova plugin add cordova-plugin-firebasex@latest
Adding cordova-plugin-firebasex to package.json

$ cordova platform add android@12
Using cordova-fetch for cordova-android@12
Adding android project...
Creating Cordova project for the Android platform:
        Path: platforms\android
        Package: uk.co.workingedge.firebase.test
        Name: FirebaseTest
        Activity: MainActivity
        Android Target SDK: android-33
        Android Compile SDK: 33
Subproject Path: CordovaLib
Subproject Path: app
Android project created with<EMAIL_ADDRESS>Installing "cordova-plugin-customfcmreceiver" for android
Installing "cordova-plugin-firebasex" for android
Subproject Path: CordovaLib
Subproject Path: app
Discovered plugin "cordova-custom-config". Adding it to the project
Installing "cordova-custom-config" for android
Adding cordova-custom-config to package.json
Discovered plugin "cordova-plugin-dialogs". Adding it to the project
Installing "cordova-plugin-dialogs" for android
Adding cordova-plugin-dialogs to package.json
Discovered plugin "cordova-plugin-enable-multidex". Adding it to the project
Installing "cordova-plugin-enable-multidex" for android
Subproject Path: CordovaLib
Subproject Path: app
Adding cordova-plugin-enable-multidex to package.json
Discovered plugin "cordova-plugin-androidx-adapter". Adding it to the project
Installing "cordova-plugin-androidx-adapter" for android
Adding cordova-plugin-androidx-adapter to package.json
Discovered plugin "cordova-plugin-hello-c". Adding it to the project
Installing "cordova-plugin-hello-c" for android
Adding cordova-plugin-hello-c to package.json
Discovered plugin "cordova.plugins.diagnostic". Adding it to the project
Installing "cordova.plugins.diagnostic" for android
Subproject Path: CordovaLib
Subproject Path: app
Adding cordova.plugins.diagnostic to package.json
Discovered plugin "cordova-plugin-facebook-connect". Adding it to the project
Installing "cordova-plugin-facebook-connect" for android
Subproject Path: CordovaLib
Subproject Path: app
Adding cordova-plugin-facebook-connect to package.json
cordova-custom-config: Applied custom config from config.xml to D:\Temp\cordova-plugin-firebasex-test\platforms\android\app\src\main\AndroidManifest.xml
cordova-plugin-androidx-adapter: Processed 35 source files in 537ms
cordova-plugin-firebasex: Preparing Firebase on Android
cordova-plugin-firebasex: Updated colors.xml with accent color
cordova-plugin-firebasex: Added tools namespace to AndroidManifest.xml

$ cordova build android
cordova-custom-config: Skipping auto-restore of config file backup(s)
cordova-custom-config: Applied custom config from config.xml to D:\Temp\cordova-plugin-firebasex-test\platforms\android\app\src\main\AndroidManifest.xml
cordova-plugin-androidx-adapter: Processed 35 source files in 499ms
cordova-plugin-firebasex: Preparing Firebase on Android
Checking Java JDK and Android SDK versions
ANDROID_HOME=G:\Users\dpa99\AppData\Local\Android\sdk (recommended setting)
ANDROID_SDK_ROOT=G:\Users\dpa99\AppData\Local\Android\sdk (DEPRECATED)
Using Android SDK: G:\Users\dpa99\AppData\Local\Android\sdk
Starting a Gradle Daemon, 1 incompatible Daemon could not be reused, use --status for details
Configuration on demand is an incubating feature.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.4.2/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 22s
1 actionable task: 1 executed
Subproject Path: CordovaLib
Subproject Path: app
Starting a Gradle Daemon, 1 incompatible Daemon could not be reused, use --status for details
Configuration on demand is an incubating feature.

> Configure project :app
WARNING:DSL element 'dexOptions' is obsolete and should be removed.
It will be removed in version 8.0 of the Android Gradle plugin.
Using it has no effect, and the AndroidGradle plugin optimizes dexing automatically.
strippedNativeLibsDir is deprecated and no longer used. Please remove it from your build configuration.

> Task :CordovaLib:compileDebugRenderscript
The RenderScript APIs are deprecated. They will be removed in Android Gradle plugin 9.0. See the following link for a guide to migrate from RenderScript: https://developer.android.com/guide/topics/renderscript/migrate

> Task :CordovaLib:compileDebugJavaWithJavac
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

> Task :app:compileDebugJavaWithJavac
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.6/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 2m
54 actionable tasks: 54 executed
Built the following apk(s):
        D:\Temp\cordova-plugin-firebasex-test\platforms\android\app\build\outputs\apk\debug\app-debug.apk

$

If you are able to reproduce the issue in the example project, please open a new issue and fill out the issue template in full, including steps to reproduce in the example project and details of test devices used to reproduce the issue.

I am also running into this issue now on Windows with Cordova 12.0.0, node 20.5.0, and cordova-android 12.0.1. I have Android Studio 2023.1.1 Patch 2 installed. When I run cordova platform rm android --verbose on a project that had previously added the android platform, I get the error:

No scripts found for hook "before_platform_rm".
TypeError [ERR_INVALID_ARG_TYPE]: The "code" argument must be of type number. Received type string ('EBUSY')
at process.set [as exitCode] (node:internal/bootstrap/node:123:9)
at C:\Programs\nvm\v20.5.0\node_modules\cordova\bin\cordova:32:22

When I try to remove the platforms directory with rm platforms (Yes to All), I get a number of WriteError ... IOException errors because some directories cannot be removed. I suspect something is locking a few files, and the cordova platform rm android command is failing due to that -- but is providing a misleading error message.

I have the same problem on MacOS...
the problem for me was an xml node not closed correctly!!
If in the config.xml you have an xml node like this:
<plugin name="cordova-plugin-someplugin">
when you try to run some command with Cordova, the NodeJs output is:

Error of type [ERR_INVALID_ARG_TYPE]: ...

After fixing the code in this line:
<plugin name="cordova-plugin-someplugin" />
every other cordova command now seems to work correctly!!

The example project does not build for me, it stops at "run ios":
# cordova run ios cordova-custom-config: Skipping auto-restore of config file backup(s) Overwriting existing resource file at platforms/ios/FirebaseTest/Resources/res/ios/sound/blackberry.caf Overwriting existing resource file at platforms/ios/FirebaseTest/Resources/res/ios/sound/crystal.caf Overwriting existing resource file at platforms/ios/FirebaseTest/Resources/res/ios/sound/msn.caf Overwriting existing resource file at platforms/ios/FirebaseTest/Resources/res/ios/pn-actions.json cordova-plugin-firebasex: Preparing Firebase on iOS cordova-plugin-firebasex: cordova-plugin-firebasex: Applied post install block to Podfile cordova-plugin-firebasex: cordova-plugin-firebasex: Added URL scheme "undefined" Cannot read properties of undefined (reading 'replace')

Been getting this error recently and it's quite irritating as I have to remove and re-add Android every time. I didn't use to get this error. Is there a fix?

Been getting this error recently and it's quite irritating as I have to remove and re-add Android every time. I didn't use to get this error. Is there a fix?

The fix for me was upgrading my config.xml from <preference name="android-targetSdkVersion" value="33" /> to <preference name="android-targetSdkVersion" value="34" />

hey jtjames thanks for your reply, working together with @customautosys on this. Unfortunately upgrading our config.xml didn't get rid of the error. In fact it is now throwing the error at every instance we try to run it. Wondering if anyone else out there has another possible fix!

hey jtjames thanks for your reply, working together with @customautosys on this. Unfortunately upgrading our config.xml didn't get rid of the error. In fact it is now throwing the error at every instance we try to run it. Wondering if anyone else out there has another possible fix!

To clarify the error is different on API 34, it is now some gradle error and unable to compile debug resources.

hello i try to install firebasex with cordova ios 8.0.0-beta.1 but i have this error :
cordova-plugin-firebasex: Preparing Firebase on iOS
TypeError [ERR_INVALID_ARG_TYPE]: The "code" argument must be of type number. Received type string ('ENOENT')
at process.set [as exitCode] (node:internal/bootstrap/node:123:9)
at /usr/local/lib/node_modules/cordova/bin/cordova:32:22
at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
all my error  when try to install plugin in  this version of cordova ios 8.0.0-beta.1
iOS project created with<EMAIL_ADDRESS>Installing "com.rjfun.cordova.httpd" for ios
Installing "cordova-plugin-advanced-http" for ios
Plugin dependency<EMAIL_ADDRESS>already fetched, using that version.
Installing "cordova-plugin-file" for ios
Installing "cordova-plugin-android-permissions" for ios
Installing "cordova-plugin-app-version" for ios
Installing "cordova-plugin-background-download" for ios
Installing "cordova-plugin-clear-data" for ios
Installing "cordova-plugin-device" for ios
Installing "cordova-plugin-document-viewer" for ios
Plugin doesn't support this project's cordova-ios version. cordova-ios: 8.0.0-beta.1, failed version requirement: >=5.1.1
Skipping 'cordova-plugin-document-viewer' for ios
Plugin "cordova-plugin-file" already installed on ios. Making it top-level.
Installing "cordova-plugin-file-transfer" for ios
Plugin dependency<EMAIL_ADDRESS>already fetched, using that version.
Dependent plugin "cordova-plugin-file" already installed on ios.
Installing "cordova-plugin-firebasex" for ios
Plugin doesn't support this project's cordova-ios version. cordova-ios: 8.0.0-beta.1, failed version requirement: >=5
Skipping 'cordova-plugin-firebasex' for ios
Installing "cordova-plugin-inappbrowser" for ios
Plugin doesn't support this project's cordova-ios version. cordova-ios: 8.0.0-beta.1, failed version requirement: >=6.0.0
Skipping 'cordova-plugin-inappbrowser' for ios
Installing "cordova-plugin-ionic-keyboard" for ios
Installing "cordova-plugin-ionic-webview" for ios
Plugin doesn't support this project's cordova-ios version. cordova-ios: 8.0.0-beta.1, failed version requirement: >=4.0.0-dev
Skipping 'cordova-plugin-ionic-webview' for ios
Installing "cordova-plugin-splashscreen" for ios
Installing "cordova-plugin-statusbar" for ios
Installing "cordova-plugin-wkuserscript" for ios
Installing "cordova-plugin-wkwebview-file-xhr" for ios
Plugin doesn't support this project's cordova-ios version. cordova-ios: 8.0.0-beta.1, failed version requirement: >=4.0.0
Skipping 'cordova-plugin-wkwebview-file-xhr' for ios
Installing "@moodlehq/cordova-plugin-zip" for ios
Plugin dependency<EMAIL_ADDRESS>already fetched, using that version.
Dependent plugin "cordova-plugin-file" already installed on ios.
cordova-plugin-firebasex: Preparing Firebase on iOS
TypeError [ERR_INVALID_ARG_TYPE]: The "code" argument must be of type number. Received type string ('ENOENT')
at process.set [as exitCode] (node:internal/bootstrap/node:123:9)
at /usr/local/lib/node_modules/cordova/bin/cordova:32:22
at process.processTicksAndRejections (node:internal/process/task_queues:105:5)

I am also running into this issue now on Windows with Cordova 12.0.0, node 20.5.0, Java 11.0.21, and cordova-android 12.0.1. I have Android Studio 2023.1.1 Patch 2 installed. When I run cordova platform rm android --verbose on a project that had previously added the android platform, I get the error:

No scripts found for hook "before_platform_rm".
TypeError [ERR_INVALID_ARG_TYPE]: The "code" argument must be of type number. Received type string ('EBUSY')
at process.set [as exitCode] (node:internal/bootstrap/node:123:9)
at C:\Programs\nvm\v20.5.0\node_modules\cordova\bin\cordova:32:22

When I try to remove the platforms directory with rm platforms (Yes to All), I get a number of WriteError ... IOException errors because some directories cannot be removed. Java is locking the file classes.dex for some reason, and the cordova platform rm android command is failing due to that -- but is providing a misleading error message.
After forcing java to quit, cordova platform rm android worked correctly.

Using Task Manager to kill all instances of java.exe did the trick for me as well, thanks!  Didn't want to have to restart my machine.


Request: Add Disabled Option to Select

Hi, it would be great to be able to add a disabled option in the Metro_4 select, currently the disabled attribute seems to be ignored when building the replacement select.
Thanks for your work on this great library !

added in 4.3.1. You can use disabled attribute for option:
<select id="my-select" data-role="select" data-add-empty-value="true" data-placeholder="Select value..." data-empty-value="-1">
    <option value="1">Value 1</option>
    <option value="2" disabled>Value 2</option>
    <option value="3">Value 3</option>
    <option value="4">Value 4</option>
</select>

Hi

Hi, but, the select element, by itself, can´t be disabled? I don´t want the user can be able to dropdown the select until it double clicks on it.


setTimeout and setInterval callback parameters

In JavaScript, only some browsers support:

scope.setTimeout(function[, delay, param1, param2, ...]); (link)
scope.setInterval(func, delay[, param1, param2, ...]); (link)

It would be great if we could get some data about which browsers support this specific feature.

(MDN data via mdn/browser-compat-data#1296)


Add “drain” to glossary

This is a Feature Request

What would you like to be added
Update https://kubernetes.io/docs/reference/glossary/ to explain the term “drain”
Explain the overall concept, and maybe also mention kubectl drain specifically. Remember that glossary entries need to be brief.
Why is this needed
drain is a jargon term and readers may not recognize it
Comments
/language en
/kind feature
/help
/triage accepted
/priority backlog

/assign

/assign


Caused by: java.io.FileNotFoundException: .../target (Is a directory)

Caused by: java.io.FileNotFoundException: .../target (Is a directory)
POM File
<build>
        <plugins>
            <plugin>
                <groupId>org.springframework.boot</groupId>
                <artifactId>spring-boot-maven-plugin</artifactId>
                <version>1.5.10.RELEASE</version>
                <configuration>
                    <mainClass>com.lonly.example.nlpparserapi.NlpParserApiApplication</mainClass>
                    <includeSystemScope>true</includeSystemScope>
                </configuration>
                <executions>
                    <execution>
                        <goals>
                            <goal>repackage</goal>
                        </goals>
                        <configuration>
                            <finalName>${project.build.finalName}</finalName>
                        </configuration>
                    </execution>
                </executions>
            </plugin>
            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-compiler-plugin</artifactId>
                <configuration>
                    <source>${java.version}</source>
                    <target>${java.version}</target>
                </configuration>
            </plugin>
            <!-- For Building Docker Image-->
            <plugin>
                <groupId>com.spotify</groupId>
                <artifactId>dockerfile-maven-plugin</artifactId>
                <version>1.4.0</version>
                <configuration>
                    <repository>${docker.image.prefix}/${project.artifactId}</repository>
                    <tag>${project.version}</tag>
                    <dockerInfoDirectory>${project.basedir}</dockerInfoDirectory>
                    <verbose>true</verbose>
                    <forceCreation>true</forceCreation>
                    <buildArgs>
                        <JAR_FILE>target/${project.build.finalName}.jar</JAR_FILE>
                    </buildArgs>
                </configuration>
                <executions>
                    <execution>
                        <id>default</id>
                        <phase>package</phase>
                        <goals>
                            <goal>build</goal>
                        </goals>
                    </execution>
                </executions>
            </plugin>
            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-surefire-plugin</artifactId>
                <version>2.20.1</version>
                <configuration>
                    <skipTests>true</skipTests>
                </configuration>
            </plugin>
        </plugins>
    </build>

Docker File
FROM frolvlad/alpine-oraclejdk8:slim
VOLUME /tmp
ARG JAR_FILE
ADD ${JAR_FILE} app.jar
ADD model model
ENV JAVA_OPTS=""
ENTRYPOINT [ "sh", "-c", "java $JAVA_OPTS -Djava.security.egd=file:/dev/./urandom -jar /app.jar" ]

Command
mvn package -Dmaven.test.skip=true dockerfile:build

Errors

Hard to reproduce without a complete pom.xml, hard to troubleshoot with an obscured screenshot of the log output.
Consider making a SSCCE of your issue, you may discover the cause in the process.
Regardless, here are some ideas to try:

Don't do this:
<dockerInfoDirectory>${project.basedir}</dockerInfoDirectory>
I doubt you're doing anything that requires moving that directory from the default location.

Use the Maven variable for target, e.g.:
<JAR_FILE>${project.build.directory}/${project.build.finalName}.jar</JAR_FILE>
This makes an absolute path, which could prevent some issues. Hard to say without more information on your build.

Prefer COPY over ADD in your Dockerfile. See What is the difference between the COPY and ADD commands in a Dockerfile?

How do you deal with it?

Why is there no easy way to port to docker files?
Is spotify-maven the only plugin?

Try adding false -> it will not copy content of dockerInfoDirectory which should not contain directories (but other plugins could create some at dockerInfoDirectory location)


Typescript: need to declare class variables.

the typings for the instructions aren't great. Most of the fields are missing. It would appear it is because the instructions don't declare the field in the class, they are simply assigned in the constructor. Then presumably that doesn't get included in the typings.
example: https://github.com/aurelia/templating/blob/master/src/instructions.js#L146

Yes, we can certainly improve all of that. It's mostly internal details though. If you were using that I'd probably be concerned ;) But in your case, knowing what you are doing, I'll make an exception :) Let me know if you have any questions in the mean time.

Would you accept a PR if I define the variables through-out? I really like intellisense...  :D

What do you mean by "variables throughout"?

well basically defining the variables explicitly in the class, and raising PRs when I spot (need) them.
So for ViewCompileInstruction
constructor(targetShadowDOM?: boolean = false, compileSurrogate?: boolean = false) {
    this.targetShadowDOM = targetShadowDOM;
    this.compileSurrogate = compileSurrogate;
    this.associatedModuleId = null;
}

I guess it needs;
export class ViewCompileInstruction
{
    targetShadowDOM: boolean ;
    compileSurrogate: boolean;
    associatedModuleId: string;
    ...

unless there is some trickery you can do when you generate the d.ts typings?

Oh, gotcha. Yes, absolutely. If you want to move those to fields and define the types, that's fantastic. We're happy to take PRs like that.

Btw, do you need me to sign anything for contributions?

Stock message ;)
We noticed that you haven't yet signed our CLA. We would appreciate it if you would consider doing that for us. Before signing, please take a few minutes to read our contributing guidelines. These guidelines will help get you up to speed on how our community likes to operate and how the pull request process works. Once you have read that, assuming you are in agreement, simply sign our online CLA.
After you've signed, please ping this issue.

/signed

+1 was about to open an issue for that.
Most classes lack public fields in aurelia-templating type defs. For example TargetInstruction, ViewSlot, etc.
This is not a problem for most users but when trying to do advanced stuff that manipulates instructions / View / ViewSlot directly, the experience with TS is not good :(
A downside is that it is unclear which fields are considered internal implementation details and which fields are public supported API.

PR merged. We've opened up more apis as public in templating. We're being careful about this because if we open up the wrong things, we prevent ourselves from making future optimizations. If there's something you need specifically, make a request and we can consider it.


Feature: Add Docker file

Maybe @lirantal or @mikicho or @rluvaton will have some additional insights

I haven't reviewed it all but I left a comemnt

@DanielGluskin I added one more dimension to the comparison table and overall we had a serious discussion here and ready to progress?
I would go with bullseye-slim


Added a smaller base image for the debug container

Looking at the sizes from xenial and buster...
FROM ubuntu:xenial
<none>               <none>              9d98cc446dfe        10 seconds ago      249MB

FROM debian:buster-slim
<none>               <none>              46e4a9c6a849        4 seconds ago       181MB

Signed-off-by: JJ Asghar<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @jjasghar. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdake / @costinm / @hklai
Can I get an update on this review/PR?

@sdake / @costinm / @hklai
Friendly bump!

@jjasghar sorry about the delay.
@sdake has more context here but I think he may be still be on leave. @costinm, could you take a look?

@hklai right, I was on travel, then PTO, then travel, so - I'm back 👍 Hope the travel is more muted next year.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jjasghar, sdake
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/assign @hklai
When master opens up, can you merge this PR?  I don't have permissions on the docker dir.
Cheers
-swteve

@jjasghar: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bb056cf1d535cf2685dd94125954433da424a7c5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/ok-to-test

@jjasghar: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bb056cf1d535cf2685dd94125954433da424a7c5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
bb056cf1d535cf2685dd94125954433da424a7c5
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jjasghar: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bb056cf1d535cf2685dd94125954433da424a7c5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
bb056cf1d535cf2685dd94125954433da424a7c5
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Poke!

@jjasghar - we believe we are handling this with this work: https://github.com/istio/istio/issues/12122#issuecomment-477499536
If you agree, can you close this issue.  If not, you might try rebasing to get the gate into a green state.
I don't have ACLs to merge into this directory.
/assign @costinm


No plural in the relation name

Sometimes, and I do not know why, Gii generates a relation without plural (s). For example
    public function getGebeurtenistype()
    {
        return $this->hasOne(\app\models\Gebeurtenistype::className(), ['gebeurtenistype_id' => 'gebeurtenistype_id']);
    }

This gives errors in forms.
The bug? was first seen in the IO generator of  mootensai/yii2-enhanced-gii.
However, he writes:

I've tried using yii2 default gii module, and it gives me the same error when using your database. Maybe you should create an issue on yii2 github.

This is expected: 'has-one' relation is genereted in singular, only 'has-many' - in plurar.


Error: exec proxy not found for :: SocialSharing :: shareViaWhatsApp

Run:
$cordova plugin add cordova-plugin-x-socialsharing
$ cordova prepare

 share: function (url) {
      window.plugins.socialsharing.shareViaWhatsApp('Acho que irá gostar dos produtos abaixo.', url, url, this.shareSucess, this.shareError)
    }
    shareSucess: function () {
      console.log('share ok')
    }
    shareError: function (errormsg) {
      console.log(errormsg)
    }

Error:
Error: exec proxy not found for :: SocialSharing :: shareViaWhatsApp
Missing Command Error

Same Error

Had u solve it?

I'm getting the same issue with shareViaFacebook()

This problem is only caused when run cordova run browser, on the device this does not happen.

Thank u very much! I tried with a real device and everything goes fine

hi @mMarcos208 the ionic native plugin documentation lists this plugin as supporting the browser platform:
https://ionicframework.com/docs/native/social-sharing
Perhaps that needs to be updated?

Yes, the documentation says the browser platform is supported - I think that should be removed / updated.

This problem is only caused when run cordova run browser, on the device this does not happen.

no it also happens in device also


Implementation details in few-shot ImageNet evaluation

Thanks for the amazing paper! I have a few questions about the details of the results in Figure 6 in the paper. I tried to use the linear probing code in the README.md on CIFAR to run one-shot evaluation on ImageNet. However, my evaluation implementation, with VIT-B/32, only gets 27% accuracy on ImageNet validation set (not ImageNet V2) instead of about 45% as mentioned in the paper. Therefore, I suspect that I missed some details in the paper experiments and I have a few questions:

What CLIP model is figure 6 using? The zero-shot accuracy makes me think that it's ViT-B/32. However, in my personal evaluation, ViT-B/32 does not provide a 45% one-shot accuracy.
Could you disclose the C parameter in sklearn for this experiment? Although on my end the performance does not vary much in different C values, I will appreciate it if this value could be provided.
How are the instances per class selected? I select the first sample of each class in ImageNet training set, which leads to a dataset size of 1000 and each with feature dimension 768 (which is obtained before the final projection to 512 dimensions). Does my selection approach sound reasonable?

Thanks again for the amazing paper and thanks in advance for helping me.

I tried run testing on CIFAR100 following by README.md (Zero-Shot Prediction) and also can't achieve the performance in paper. did you solve this problem?

Please refer to https://github.com/openai/CLIP/blob/fcab8b6eb92af684e7ff0a904464be7b99b49b88/notebooks/Prompt_Engineering_for_ImageNet.ipynb for this concern.


Keep commands with - unescaped

Hi,
Here's a PR for this use case: https://github.com/typicode/minihost/issues/5
Not a Windows expert, so not sure why it tries to look in that particular PATH.
But basically, it seems like it doesn't like - in globally installed modules:
var spawn = require('cross-spawn')
spawn('node-dev', [], { stdio: 'inherit' }) // KO
spawn('nodemon', [], { stdio: 'inherit' }) // OK

module.js:340
    throw err;
          ^
Error: Cannot find module 'D:\tmp\node-cross-spawn\node_modules\node-dev\bin\nod
e-dev'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:280:25)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)
    at node.js:906:3

Tries to run cmd.exe /s /c ""node-dev"" instead of cmd.exe /s /c "node-dev"
I've changed the escapeCommand so that it doesn't escape commands with -.

Landed in 0.2.9.

Thanks :)
2015-04-08 18:18 GMT+02:00 André Cruz<EMAIL_ADDRESS>
Landed in 0.2.9.
—
Reply to this email directly or view it on GitHub
https://github.com/IndigoUnited/node-cross-spawn/pull/10#issuecomment-90964130
.


Printing fails with new browser enabled

Vienna 3.8.7
MacOS 13.4

With one or more articles selected, press ⌘P (print from the file menu)
The print dialog opens, the preview pane shows a blank preview of two (2) pages that  will be printed (either to PDF or on paper).
From the PDF dropdown widget at the bottom, select “Preview…” to verify the output. Preview opens showing a file with  2 blank pages.

Expected  -  print the article
With Old browser, it works correctly with the one minor issue in that the article being viewed scales down slightly when the print dialog is open – as if “print preview” in the Webkit developer tools is selected (elements tab).

This is addressed for versions 3.9
Pull request #1635 has already been merged into master.

A public beta of 3.9 is expected to be available this month.

This is addressed for versions 3.9

Oh. Thank you. I somehow did not see that when scanning  recentish commits.
Looking forward to a beta for 3.9!


Make study and assay names editable via SODAR

Problem
After iRODS collections were created, studies and assays can no longer be removed i.e. renamed. This makes sense to prevent orphaned files in iRODS when the user re-uploads samplesheets, but when a change is done via the SODAR GUI, there is no reason to loose track of associated collections.
Solution
Introduce a process to rename studies/assays via the SODAR GUI.

This will probably be one of the first things I add when we get to working on missing editor features.
Hint: a lot of this is already listed in #771, no need to repeat until we actually start putting these on the roadmap.


Unexpected token import when I try to import reducer as burgerMenu in my reducer file

When I have this code in my reducer file
import { routerReducer as routing } from 'react-router-redux'
import { combineReducers } from 'redux'
import subreddits from './subreddits'
import menu from './menu'
import { reducer as burgerMenu } from 'redux-burger-menu'

const appReducer = combineReducers({
  subreddits,
  menu,
  burgerMenu,
  routing
})

const rootReducer = (state, action) => {
  return appReducer(state, action)
}

export default rootReducer

I get this error:
index.js:1Uncaught SyntaxError: Unexpected token import

Hey @yongelee, update to the latest version and this should be fixed. Thanks for raising the issue :)


Sentiment analysis as an additional feature

Sentiment analysis may be done including external data sets.

If we want to proceed with the Google API we must provide personal information such as credit card account, which is an inconvenient situation. Instead, I found this interesting repository of a team that won a sentiment analysis competition at Kaggle:
https://github.com/Wronskia/Sentiment-Analysis-on-Twitter-data/tree/master/Final
I will rater go for this approach.

@steremma Could you please close this issue. It was already solved :)


Update plan_snapshot_summary to observe which versions are discarded from amendments

depends on #193
will fix legal dates not making sense after discarding amendment.

Testing instructions:
Discard amendment, see previous legal version as still legally standing (go to versions and see what is there).  Other legal start and end dates make sense/are not missing.

testing blocked by #218


Non-2xx HTTP response code emits a DANGER validation error

The spec for the @http trait states that for the code:

The provided value SHOULD be between 100 and 599, and it MUST be between 100 and 999.

However, when providing a non-2xx value for code, such as 418 (why not?), the Smithy validation emits a DANGER message:
[DANGER] aws.protocoltests.misc#ResponseCodeRequiredOperation: Expected an `http` code in the 2xx range, but found 418 | HttpResponseCodeSemantics

Which is correct? The spec or the error?

It seems fair for the reference implementation as a tool to provide reasonable validation like this. We could add a note to the spec that the status code SHOULD be in the 2xx range. Returning a successful response outside this range isn't properly adhering to the semantics of HTTP, which is kind of the point of the REST bindings for Smithy.

To pick up on this topic,
why is choosing the Http trait considered choosing REST?

Sure, I should have said HTTP and not REST. Smithy's HTTP bindings do control how requests and responses are serialized over HTTP. There is plenty of guidance in the HTTP spec for what is and isn't a successful status code. The@http trait on an operation is meant to capture the status code of a successful response.

Ok , so if our focus is purely HTTP, the 300 range carries with it quite a few success responses that do not prompt further action for example statuses used in Oauth flows

Do you have a concrete example? OAuth isn't something you'd typically want to model directly in Smithy but rather you'd abstract over it with an auth trait.

I'm curious about how the redirect-based SAML flow is typically documented with Smithy.
For example as shown here:
https://en.wikipedia.org/wiki/SAML_2.0#/media/File:Saml2-browser-sso-redirect-post.png
Let's say a service has a /login endpoint that uses SAML with an an external identity provider. The service provider, or application that the user is interacting with, will redirect the user several times to the identity provider, and also maintain an endpoint to handle call backs from the identity provider.
Are there examples of using the auth trait to abstract over this?

We don't have documentation specifically for that. I would not try to model those redirects in a Smithy model. They aren't something your users call directly or should have to contend with. It's something generated clients should handle on their behalf. It would be an implementation detail of a hypothetical SAML SSO redirect auth trait.
Putting the developer experience aside -- you could try to model these things if you wanted to, you just need to suppress the validation. It's not a blocker, but a nudge. If someone were trying to model SAML or something directly, and they had to stop and think about whether they should because of the validation, then I think the validator is working as intended.


[tutorial] Add iframe to homepage

This adds a preview of the completed project to the homepage. (We'd previously used the Stackblitz preview, but its call-to-action button distracted some readers and it doesn't work on all browsers.)

LET'S GO! @Jutanium


DRY: you've got two dependency management strategies

I was going to file an issue about the dependencies missing from requirements.txt, but then I saw your post showing an Arch CLI command installing that other set of dependencies. Maybe you have a good reason for that but I say you should go with one or the other way.  Python's future seems to in virtual environments, so I think you should go that way. After all, requirements.txt becomes trustworthy documentation when you are not doing things behind its back. Not that I love virtual environments. That whole area of dependency resolution and installation is rotten across a bunch of popular language. NodeJS..... Go, Rust, Nim, aren't better. I have a bit of a crush on Nim because it implements some of the intellectual idealism from the 1950s that modern language language designers never heard of. I prefer reprogrammable languages because I can't trust the language designers to have give me what I want. That 1950's language. I found some of it in the subbasement of Emacs. How did they let decades of work accumulate on top of a language that gets lists and sequences wrong? Well, it was kind of a first try. The wrongness is that the entire CAR/CDR stuff is an implementation detail should have been invisible. Python does need it. And Python has slicing and generators and comprehensions!

you're right about venvs but the problem was about running it as a terminal command where it wont be working as a venv. if you find a fix for it please let me know.

I'm unable to identify the missing modules. could you please tell me which libs are missing?

They are missing; it's hard to spot them. setuptools is one of. I think that the full list of the missing in your arch command line. The only reason that requirements.txt  and pip don't have a problem is that you hae magically installed those things. Now I'm trying to find that post of yours. It's probably in one of the repo Readmes. Found it! "If you're like me and you use arch linux and install python modules from arch repo. You can do this: sudo pacman -Sy python-py-cpuinfo python-psutil python-requests python-termcolor"  I understand you about the "how do I handle venvs when my app is installed?" Question. Python's entire build/install system is ancient and needs replacing. It (and the Python core developers) come from a time when Python programs could be just one simple Python code file. Python is one of the few languages where that could work even today for some programs, but the whacky and dangerous auto-magic dependency management has taken over. Years ago I used Py2Exe when I had to deliver on Windows. Freeze is supposed to be that on Linux, but I've never used it. There are about six incompatible replacements for pip. The Open Source community doesn't have some magic that resolves this kind of technical issue with a big social component.  I think (just my opinion) that you should go with the flow of main python development. I'm sorry that it is inconsistent.  I think if you go with venvs, you'll be able to research the issue of install and running. You'll figure it out. I'm deep in Emacs at the moment and not doing Python. I may be moving on from Python for some more expressive (more ideas per line of code) language, but I mostly don't like what I see. I like Elm (but it is dying of anti-social leader problems). Coffeescript was brilliant. Python as imagined by a Ruby fan. Oh. Him. He's doing this now: Livescript.


[Improvment] Pass it multiple packages

Do you have an idea on how to do this one?

Pass packages as a list of strings instead of a single string, I guess.

Something like this?
packageName = ["x.y.z", "p.d.q"]

Are you working on it?

Unfortunately not 😓 regular "bread and breakfast" stuffs may be shipped

same problem but we are thinking of trying it ourselves.

Not sure if this plugin is still developed, but I have an amendment: it would be nice to define packageName and outputFile as pairs, so you can create a seperate diagram for each package.

Hello all,
Great idea to pair package and output file. I'm currently a bit busy to maintain this plugin but would have some time in Q3 I hope. So my plan will be to set this pair in this class: https://github.com/RoRoche/plantuml-gradle-plugin/blob/master/src/main/groovy/com/github/roroche/plantuml/tasks/ClassDiagramExtension.groovy
and then iterate on it by refactoring this one: https://github.com/RoRoche/plantuml-gradle-plugin/blob/master/src/main/groovy/com/github/roroche/plantuml/tasks/BuildClassDiagramTask.groovy
Coming soon! Thank you for your nice suggestions ;)


Sort language list alphabetically, change ranking into category emoji

The reason for this proposition is:

There can be more than one implementation of a language binding, in which case separating them by rank may not be convenient for reading.

The new list can be sorted more conventionally as:
{Language} {category-emoji}*

{Implementation [0-9]+}
{Description}

This is more easily maintainable as ranks can be added just like any other category emoji.

This does probably make more sense since people would mostly be interested in how well their favorite language holds and not an arbitrary gradation. Though I'd still probably keep GDScript and Godot's visual scripting at the top in a separate section, as those are Godot specific tools and should be mentioned as such.

Interesting, perhaps hint subliminally that you usually don't need to use anything else! ;)

However, it is similar to just organising by Official and Community Support.

That would be precisely it, yes.

Maybe we should organise by maintainers instead. The Community bindings list is the one which is most likely to grow anyway.

List alphabetically within the categories yes
I love this list first and foremost for the ordering by quality

List alphabetically within the categories yes
I love this list first and foremost for the ordering by quality

This does however separate bindings from the same language.
We could still move forward with reorganising the way the entries are written I guess.

Yeah, and separating language bindings of the same language is something very minor to me, while ordering the quality is all this repository is about. I love to have an overview, which languages are supported in which way and to which quality. This is 100% the purpose of this project in my perspective.

This would be much more fun if we could actually interactively sort entries by whichever criteria we put in. But that's a tale for another time.


[kddockwidgets] Update version to 2.1.0

Fix https://github.com/microsoft/vcpkg/issues/38641

[x] Changes comply with the maintainer guide.
[x] SHA512s are updated for each updated download.
[ ] The "supports" clause reflects platforms that may be fixed by this new version.
[ ] Any fixed CI baseline entries are removed from that file.
[ ] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

All features are tested successfully in the following triplet:

x86-windows
x64-windows
x64-windows-stataic

Note #38611, https://github.com/microsoft/vcpkg/issues/38509.

Obsolete since #40327.


ISP_DFU no switch LDROM to APROM after loading

After loading bin-file, DFU no switch LDROM to APROM in Config0 register.

Yes, we did not implement the function in ISP_DFU. You could implement it.


Fix asset name for Tinkerbell stack and CRDs artifacts in bundle

The asset name for Tinkerbell stack and CRDs Helm chart has the Helm suffix in config/bundle_release.go, which gets set as the key, so we need to use the same to fetch it from the map.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


chore: migrate to setup.cfg

closes #644 #662 #663
Why is this needed?
Migrate to python packaging best practices.
Proposed Changes

use setup.cfg & pyproject.toml to build kazoo

Does this PR introduce any breaking change?
No

Codecov Report

Merging #666 (9ed34ce) into master (9bb8499) will decrease coverage by 1.32%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
- Coverage   94.47%   93.14%   -1.33%
==========================================
  Files          57       57
  Lines        8375     8259     -116
==========================================
- Hits         7912     7693     -219
- Misses        463      566     +103

Impacted Files
Coverage Δ

kazoo/tests/test_selectors_select.py
93.22% <50.00%> (-3.80%)
:arrow_down:

kazoo/protocol/serialization.py
92.20% <0.00%> (-6.85%)
:arrow_down:

kazoo/tests/test_client.py
95.78% <0.00%> (-2.92%)
:arrow_down:

kazoo/tests/test_cache.py
55.44% <0.00%> (-2.73%)
:arrow_down:

kazoo/client.py
95.96% <0.00%> (-2.45%)
:arrow_down:

kazoo/tests/test_eventlet_handler.py
87.35% <0.00%> (-2.27%)
:arrow_down:

kazoo/handlers/gevent.py
92.39% <0.00%> (-2.24%)
:arrow_down:

kazoo/protocol/connection.py
92.97% <0.00%> (-2.08%)
:arrow_down:

kazoo/testing/harness.py
96.61% <0.00%> (-1.73%)
:arrow_down:

... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bb8499...9ed34ce. Read the comment docs.

Hey @ceache
Really sorry for not having check this before :(

Wasn't in scope originally but I'll add it in a next PR
On Tue, Sep 20, 2022, 12:53 Stephen Sorriaux @.***>
wrote:

@.**** approved this pull request.
Thank you!
In setup.cfg
https://github.com/python-zk/kazoo/pull/666#discussion_r975606038:

+description = "Higher Level Zookeeper Client"
+long_description = file: README.md, CHANGES.md
+long_description_content_type = text/markdown
+license = Apache 2.0
+license_file = LICENSE
+platform = any
+keywords = zookeeper, lock, leader, configuration
+classifiers =

Development Status :: 5 - Production/Stable
License :: OSI Approved :: Apache Software License
Intended Audience :: Developers
Operating System :: OS Independent
Programming Language :: Python
Programming Language :: Python :: 3
Programming Language :: Python :: 3.7
Programming Language :: Python :: 3.8

is Python 3.9 missing?
—
Reply to this email directly, view it on GitHub
https://github.com/python-zk/kazoo/pull/666#pullrequestreview-1114174449,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIFTHWG4BZHKRH6VZ3UG7LV7HTX5ANCNFSM5V6EOUAA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Corner case

When running this on the corner case of a factor being equal to "_n", it fails with a confusing/unrelated message.
EG:
sysuse auto
gen i = _n
regife price weight, f(i turn, 1)

Quite low priority, but still.
Thanks!
Sergio

Thank. Do you know if there is to get the error message returned by reghdfe, not just the return code?

AFAIK there is no built-in way of doing that in Stata.
I'm guessing you want to catch an error (capture) and re-raise it, like in most modern languages, but I'm not aware of a way. Since almost all of my error messages go to an internal Assert.ado script, I thought about saving the messages in a global "RC_MESSAGE" so I may be able to do that.

yes exactly. I guess I'll end up catching the error, print "reghdfe fails because" and retry reghdfe so that the relevant error message is printed. This code is already a mess anyway.


How to display friendly in admin?

Hi author.
How can i display json friendly in admin like.

I just released a package for this -- see https://github.com/kevinmickey/django-prettyjson

Thanks @kevinmickey that looks like a good solution.


don't trigger sysroot rebuilds on some commands

like clean and update
closes #49

@homunkulus r+

:pushpin: Commit 99343d2 has been approved by japaric

:hourglass: Testing commit 99343d2 with merge 99343d2...

:sunny: Test successful - status-appveyor
Approved by: japaric
Pushing 99343d27ccc519bf51fdcbdc26101debc74ca4e7 to master...


feat(chat): add attachment charts support (Issue #1021)

Description:
Add attachment charts support
Issues:

https://github.com/epam/ai-dial-chat/issues/1021

UI changes:

Checklist:

[x] the pull request name complies with Conventional Commits
[x] the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
[x] the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
[x] I confirm that do not share any confidential information like API keys or any other secrets and private URLs

/deploy-review

/deploy-review

/deploy-review


StructScan Unmarshalling Behaviour: no fields in dest. interface

Is there a way to change the behaviour (default or optional) of StructScan to match that of Go's json.Unmarshal where any fields in the destination struct that don't exist in the source are implicitly skipped?
Example: I have a tsv field that contains tsvector data in a postgres DB for full text search. I can avoid having a matching field in the destination struct if I SELECT <list of columns not including tsv however it's pretty verbose once you have a few columns and it'd be easier to just SELECT * FROM <table> and drop the columns not in the dest struct.

There is a nice work around for this issue.
Instead of using rows.StructScan, use MapScan and then use mapstructure lib https://github.com/mitchellh/mapstructure to fill the struct from the map.
This has been also quite convenient when making JOIN queries.
Golang does not allow joining two structs into a new struct type. So when making JOIN queries I just mapstructure. Decode the JOIN result into multiple structs.


Invalid Australian phone number

My app is trying to validate this number 0567 427 942 by using this:
[phoneUtil isValidNumber:[phoneUtil parse:"0567427942" defaultRegion:"AU" error:&error]]
But I'm receiving as invalid, but we know that this number is in fact an Australian Phone Number.
We also tried to change the 0 for the country code 61, but without success we keep receiving this as invalid.
Can you help me with this?

Having the same issue with the 0493 number in Australia. It's an issue with libPhoneNumber, not platform specific, we tested with Android and Golang libPhoneNumber and they failed too.

I've started using this SPM Package. It fixed my problem.
https://github.com/marmelroy/PhoneNumberKit


Use commander and chalk for command line tools

I use the node packages commander and chalk for wikidata-taxonomy. Asked by a German Wikipedia to create a command line tool to get coordinates of a Wikidata item, I created another script using these packages and I would like to make it part of wikidata-cli:
https://github.com/nichtich/wikidata-cli/tree/wdcoords
would you mind adding commander and chalk as dependencies? I think the other scripts can also benefit from them.

(sorry for the delayed answer, I missed the notification somehow)
Yes! I was already considering commander indeed!
What about using it to restructure the whole wikidata-cli à la git with one root command (wd?), and subcommands?
chalk's needs is already covered by colors.js but I wouldn't mind trying it in this project :)

Yes, subcommands is a good idea but it may be easier to start moving one command after another. Maybe start with wdprops and wdsparql as they already start with wd ;-)

I started working on commander integration in a dedicated branch commander, would love to have your feedback on that before publishing it as v2.0.0 :)

Looks great. I am not sure about lib/strings but don't no better way to repeat its content. We could implement global options such as --language and --clipboard by subclassing `commander and move some other functionality common to all commands to this subclass - but this is refactoring.

Closing this issue: solved by 6f29435 (and following commits) for commander, and b4f6d8e for chalk.
Support for -l, --lang was added by d25724f, d34cfa3, and 4f5e805.
The discussion on --clipboard can continue in #4


Feature/chrome version

Fixes broken build. Adds compatibility check between Puppeteer and Chrome, better handling of versions, various improvements.

Looks good, the only thing that comes to mind is that it doesn't really guarantee compatibility, because Puppeteer does not claim any compatibility with Chrome at all and the major version check only makes sure that we don't update Chrome too soon before some new DevTools features land 😞

Yeah true, but better than nothing.
On Sat, 4 Jan 2020 at 10:06, Ondra Urban<EMAIL_ADDRESS>wrote:

Looks good, the only thing that comes to mind is that it doesn't really
guarantee compatibility, because Puppeteer does not claim any compatibility
with Chrome at all and the major version check only makes sure that we
don't update Chrome too soon before some new DevTools features land 😞
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apifytech/apify-actor-docker/pull/14?email_source=notifications&email_token=ACQ7CBEBNCLWLH5FX4N4KB3Q4BGQVA5CNFSM4KCS76P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEICT6SQ#issuecomment-570769226,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACQ7CBF7W2UEVJ3XLYVQV2TQ4BGQVANCNFSM4KCS76PQ
.

Let’s merge this?


Addition of Sparsemax activation

PR for creating the sparsemax activation layer as requested in issue (#20554)[https://github.com/keras-team/keras/issues/20554]. (Original paper)[https://arxiv.org/abs/1602.02068]
Test cases checked: Yes
Documentation rendering checked: No

Codecov Report
Attention: Patch coverage is 47.22222% with 38 lines in your changes missing coverage. Please review.

Project coverage is 60.13%. Comparing base (e0f61ee) to head (75df0b9).

Files with missing lines
Patch %
Lines

keras/src/backend/jax/nn.py
7.69%
12 Missing :warning:

keras/src/backend/tensorflow/nn.py
7.69%
12 Missing :warning:

keras/src/backend/torch/nn.py
7.69%
12 Missing :warning:

keras/api/_tf_keras/keras/activations/__init__.py
0.00%
1 Missing :warning:

keras/src/ops/nn.py
92.30%
1 Missing :warning:

:exclamation:  There is a different number of reports uploaded between BASE (e0f61ee) and HEAD (75df0b9). Click for more details.
HEAD has 6 uploads less than BASE

Flag
BASE (e0f61ee)
HEAD (75df0b9)

keras
4
1

keras-torch
1
0

keras-tensorflow
1
0

keras-jax
1
0

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #20558       +/-   ##
===========================================
- Coverage   82.20%   60.13%   -22.07%
===========================================
  Files         515      515
  Lines       48085    48157       +72
  Branches     7526     7527        +1
===========================================
- Hits        39527    28958    -10569
- Misses       6740    17441    +10701
+ Partials     1818     1758       -60

Flag
Coverage Δ

keras
60.13% <47.22%> (-21.92%)
:arrow_down:

keras-jax
?

keras-numpy
60.13% <47.22%> (-0.02%)
:arrow_down:

keras-tensorflow
?

keras-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


beforeLoad adds ~400ms delay on page reload

Describe the bug
When adding beforeLoad to a route (even an empty one), the router gets mounted and then displays a white page for approx. 400ms before the actual page is rendered.
Your Example Website or App
https://stackblitz.com/github/tanstack/router/tree/main/examples/react/quickstart-file-based
Steps to Reproduce the Bug or Issue

Fork the file-based QuickStart example on StackBlitz.
Add an beforeLoad: () => {} to any page - I chose the about page.
Go to the page you changed and reload the page in the browser.

Expected behavior
Simply adding the beforeLoad option should not materially change load times.
Screenshots or Videos
https://github.com/user-attachments/assets/eaa57efa-7c2f-4fad-b64d-a9f10017e9cf
Platform

OS: macOS Sonoma
Browser: Arc
Version: 1.56.0

Additional context
No response

I've been experiencing this too, however my might be a little different. Rendering the actual app is delayed by almost 1 second.
const InnerApp = () => {
    const auth = useAuthStore();

    if (auth.loading) {
        return
Loading...
;
    }

    return (
        <ThemeProvider theme={lightTheme}>
            <CssBaseline />
            <RouterProvider router={router} context={{ auth }} />
            <Toaster />
        </ThemeProvider>
    );
};

export default () => {
    return (
        <StrictMode>
            <QueryClientProvider client={queryClient}>
                <InnerApp />
            </QueryClientProvider>
        </StrictMode>
    );
};

I also checked the performance tab in devtools and it looks like nothing is happening (the selected range is when nothing is rendered)

As a temporary fix, add pendingMinMs: 0.

I just saw this issue and added the fix and my app feels way faster now... This needs a fix.

Also noticed that adding this makes the app a lot more snappy, especially since we perform a lot of middleware/guard checks in beforeLoad() which takes almost no time. The default pendingMinMs is 500 which is pretty long.
Can be disabled for the entire router by setting defaultPendingMinMs: 0,

The presence of beforeLoad or loader, even if they are empty (we still await their functions, even if they don’t return a promise) make pendingMinMs “trigger” (if there is a pending component defined).
Even if we have pendingMinMs: 0, the loader flashes quickly.
To goal of this setting is to ensure that loads don’t flash - if we need to see them, we should see them “for a bit”. Because loader or beforeLoad are defined, we determine that we should see the pendingComponent. We don’t really make a difference between a loader that takes 1ms, or one that takes 200ms.
If you only have a beforeLoad or a loader that is sufficiently fast, my suggestion would be to set:
pendingComponent: undefined,
pendingMinMs: 0

for that route. Mostly, I think the defaults are fine because loaders will be used to load data, which can take a couple hundreds of milliseconds, so we’d want to really avoid flashing in the loader (which even happens with pendingMinMs: 0
@schiller-manuel FYI


Add documentation regarding usage of style tags in components containing html tags (i.e. layout components)

📋 Explain your issue
I'm opening this issue to ask for advice on fixing a gap in the documentation regarding layout components. The issue is that if a layout component contains an html tag, any style tags (this might also apply to script tags?) need to be nested inside the html tag. This is different to how astro components normally behave where the style tag is usually placed outside of any other tags.
Example
// invalid
---
---

  ...
  ...

// valid
---
---

  ...
  ...

The behaviour and workaround was confirmed in this issue.
Suggestion
I think this would make sense to explain in a callout box on the layouts page. Something akin to

[!WARNING]
A style tag in an Astro component containing an html tag must be nested inside the html tag.

I don't think I have seen this mentioned anywhere else in the docs, but I might have overlooked it. Ideally this should trigger at least a linter warning in the language tools, but getting it documented would be a good start.
More than happy to send a PR!

Can confirm the suggestion is valid based off Issue linked & withastro/astro/blob/main/examples/blog/src/layouts/BlogPost.astro. Hit your PR right away 😉

I saw the discussion and agree it seems to be something that needs documenting!
I will point out though, that a call out is probably NOT the way to do this.  ;)  Cautions and warnings are for: security risk, might lose data, set your house on fire etc. In general, "how things work" is not a special note, it's just part of regular documentation!
So, I would encourage you to look for where, in normal paragraph text, this content makes sense to add! Then, I'll help edit it and get it over the finish line. 💪

@sarah11918 Thanks, good point regarding the callout. I will write something up later today and send it through. I can also send through a German translation at the same time, I presume I'd do that in a separate PR?

Yes! The German would be in a 2nd PR, thanks!  Especially since you won't know for sure what the final English version will be until Team Docs is finished reviewing and possibly editing it, it saves work by not doing the translation too early. 🙌


added grpc-no-content-exception

I added GrpcNoContentException .
Please !!!

@zphtet Thanks for opening a PR. please remove the package-lock.json and then we can merge it.

When will it be merged?

@mohsenbostan @zphtet
The commit is not visible in the main branch.


Truncate all ALU32 except for bit-endianess

All ALU32 operations are supposed to truncate the target register. Adding code to ensure that this is always done.

coverage: 81.564%. first build
when pulling ff667aa0139f8dda704004b0f7f50bc79a334f0b on Alan-Jowett:fix_alu32_operations
into 307de7dc7aebbc65d144f71160d8d08eaa73e400 on iovisor:main.


Restructured code

Switched to codegen keeping DRY principle in mind.
Sorry for the messed up diff.

Should I make a separate file interface.jl (or fitsinterface.jl) for keeping the code of FITS interface?
PS: methods.jl has become quite lengthy

How about adding helper.jl? This would make the code look very neat.

helper.jl is pretty ambiguous. How about fits.jl.


feat(wasm): experimental support for WASI

Signed-off-by: Runji Wang<EMAIL_ADDRESS>brew install wasmer
rustup target add wasm32-wasi
cargo b --target wasm32-wasi --no-default-features
wasmer target/wasm32-wasi/debug/risinglight.wasm

I was working on some WASM-related things recently I would prefer compiling it using wasm-pack so that it can run in the browser.

I was working on some WASM-related things recently I would prefer compiling it using wasm-pack so that it can run in the browser.

Just curious about what it is? (if not confidential) 👀
Cuz we are going to explore WASM UDF recently. 🤡

see prisma-engines :)


Assertion Errors in test_plot

After building the virtual environment and running make test, I receive these errors.
Below is the error section:
=============================================== FAILURES ================================================
_____________________________________ test_twcli_plot_pandl_percent _____________________________________

    def test_twcli_plot_pandl_percent():
        pf = gen_portfolio()
        pf_tmp = gen_portfolio(True)
        nl = pf_tmp._get_starting_net_liq('1y')
        val = pf.plot('1y', starting_net_liq=nl)

>       assert round(val, 2) == _REALIZED_PANDL_PERCENT
E       assert -13.61 == -14.56
E        +  where -13.61 = round(-13.612839563968665, 2)

tests/test_plot.py:42: AssertionError
____________________________________ test_twcli_plot_netliq_percent _____________________________________

    def test_twcli_plot_netliq_percent():
        pf = gen_portfolio(True)
        pf_tmp = gen_portfolio(True)
        nl = pf_tmp._get_starting_net_liq('6m')
        val = pf.plot('6m', starting_net_liq=nl)

>       assert round(val, 2) == _NET_LIQUIDITY_PERCENT
E       assert 89.78 == 87.41
E        +  where 89.78 = round(89.77612117172752, 2)

tests/test_plot.py:51: AssertionError

Yup, I accidentally made the tests non-deterministic. Fixed by #18.

#18 is merged, so closing this.


Remove meaningless password regeneration on resetSSHKeyForVirtualMachine

Description
On API resetSSHKeyForVirtualMachine, ACS also regenerates VM password when it uses a template with Password Enabled as true; there is already anAPI to reset VM password, therefore, the reset SSH keys API should not reset the VM SSH password as well.
Besides running a meaningless process, the VM's password regeneration slows down the main process and may cause a confusion in operations due to password change in the VM without being explicity requested.
This PR intends to remove the meaningless password regeneration from resetSSHKeyForVirtualMachine.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[x] Minor

How Has This Been Tested?
It has been tested locally in a test lab.

I created VM with a template with Password Enabled as true.
I logged in VM with the generated password on creation.
I stopped the VM and called the API.
I started the VM and tried to login with the password. Before this changes, the password would be changed and I could not login to the VM because I did not have the password anymore. After this changes, I could login normally.

@blueorangutan package

@GutoVeronezi There is a reason why we are generating a new password upon reset ssh key.
We save the encrypted password (using ssh public key) of VM in the database. There is an API also which gets the VM password if it is saved "getVMPassword". If we don't reset the password upon reset ssh key then the saved password is CloudStack is no more valid and "getVMPassword" API will not serve its purpose.

-1 from my side for now unless if there are plans to deprecate "getVMpassword" API and not to save VM password in database.

@harikrishna-patnala
This behavior does not make any sense outside of the first password/resetting password API context. I see no problem in using the SSH key public key to encrypt the VM password, but not at this point.
Let's take a look at these cases:

A VM is created and a random password is generated. Users logins into their VM and changes their password, then they enable/set a new SSH key to the VM. So what now? They cannot log in anymore with the password had been using so far due to 'resetSSHKeyForVirtualMachine' changing the VM password without it being requested;
A VM is created with an SSH key and a random encrypted password is generated. The password of the VM is saved in the database. Users login into their VM and change its password. Now VM's password is different than what was saved in the database and getVMPassword will not serve its purpose too;

Users changing VM's password is a normal behavior (and they should do it). the API (getVMPassword) is not the source of truth for the VM password. It has its purpose in a specific life-cycle in ACS, which is the life-cyle of initial passwords and reset password processes.
What is the problem if the API method resetSSHKeyForVirtualMachine stops doing that password-change? It will not break anything. It will not change anything for the end-user. The getVMPassword will keep returning the last password randomly generated by ACS, which is probably not valid anymore as expected because the user changed his/her password already in the operating system of the VM.

I agree with @GutoVeronezi on this, @harikrishna-patnala can you explain the ratio behind your -1. getVMpassword is only for initial pw change anyway, it should not give anybody any value after that, but is vital at that moment. I don't see why deprecating it either.

I'm talking about my concern from the management server perspective. I thought of the following use case in which fetching first VM password will also not be useful if initial SSH key is lost.

Deploy VM with password enabled template
User got the password X. Management server saved the Encrypted password with Publickkey1 P1(X)
Reset the SSH key (dont reset the password) to Publickey2 P2
User forgot the password and tries to getVMPassword
API will return encrypted password which user cannot decrypt if initial ssh key is not there.

I got your use cases as well where you are saying when user has changed the password. I'm speaking when the cases where the management server generated password is still in use and since getVMpassword API is available.
So overall I see it here there are two sides of the issue where we have to take a stand. I'm fine with the PR if everyone agrees that getVMPassword should not be taken into consideration always and it is not the source of truth.
The reason why I'm speaking about deprecating getVMPassword because resetVMpassword makes more sense in those usecases. resetVMpassword will always gives a new password and does not have any limitations like getVMpassword which is not true in many use cases as you mentioned.

Ok, I see your point @harikrishna-patnala. I think we should address this by means of a limitation of warranty on the API description. deprecating it is not needed. In addition to that any reset of the ssh key should than not reset but just delete the old PW. A subsequent call to the get-API could return an error message with the proper instructions if the password is in-decyferable or empty.

Thanks @DaanHoogland, deleting of old password from the database upon reset of ssh key seems to be good step here satisfying all usecases.

ok @GutoVeronezi @harikrishna-patnala @GabrielBrascher , can we do this in a new PR or do we need to add that here? I'm not sure off the top of my head what an empty PW does, but functionally this is the right way to go, i think.

@DaanHoogland @harikrishna-patnala @GabrielBrascher as suggested, now resetSSHKeyForVirtualMachine removes the encrypted password. I did a few tests with VMs and routers and catch no problem.
Also, I did a little refactor on the getVMPassword API, focusing in improving logs.

@DaanHoogland @harikrishna-patnala @GabrielBrascher any comment about the recent changes?

Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 85

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian Build Failed (tid-740)

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-731)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48575 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4819-t731-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 86 look OK, 2 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_03_vpc_privategw_restart_vpc_cleanup
Failure
493.46
test_privategw_acl.py

test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL
Failure
555.82
test_vpc_redundant.py

test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers
Failure
476.75
test_vpc_redundant.py

test_05_rvpc_multi_tiers
Failure
511.03
test_vpc_redundant.py

Trillian test result (tid-741)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47651 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4819-t741-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 87 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_invalid_upgrade_kubernetes_cluster
Failure
3615.09
test_kubernetes_clusters.py

test_07_deploy_kubernetes_ha_cluster
Failure
3607.91
test_kubernetes_clusters.py

test_08_deploy_and_upgrade_kubernetes_ha_cluster
Failure
0.04
test_kubernetes_clusters.py

test_09_delete_kubernetes_ha_cluster
Failure
0.04
test_kubernetes_clusters.py

ContextSuite context=TestKubernetesCluster>:teardown
Error
99.44
test_kubernetes_clusters.py

@harikrishna-patnala @GabrielBrascher @sureshanaparti @DaanHoogland is there anything else to do?

@GutoVeronezi , I don't think so. @harikrishna-patnala , @GabrielBrascher are we ready to merge this?

@GutoVeronezi @DaanHoogland @harikrishna-patnala I am OK with this PR as it is, LGTM.

Let me review a few test cases for potential regression and get back with the review in a few days. Was config drive tested as well?
@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Let me review a few test cases for potential regression and get back with the review in a few days. Was config drive tested as well?
@blueorangutan package

@rhtyd if by config driver you mean CloudInit; then yes, it has been tested locally in a test lab, with CloudInit enabled.

I created VM with a template with Password Enabled as true.
I logged in the VM with the generated password on creation..
I stopped the VM and called the API.
I started the VM and tried to login with the password. Before this changes, the password would be changed and I could not login to the VM because I did not have the password anymore. After this changes, I could login normally with both password and ssh key certificate.

@GutoVeronezi a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 180

By config drive I mean yes cloud-init but enabling config drive by creating a new network offering @GutoVeronezi and checking with/without cloud-init if the the behaviour with this PR matches expectation on say SSH reset operation.

@rhtyd I created a network offering with user-data enabled and created a VM with echo "test" > /etc/file-with-user-data in user-data. The file was created and resetSSH worked as expected.
I do not see how this change can affect config-drive workflow. Do you have any situation?

That sounds good to me. Let's merge this given tests have passed (failure intermittent in nature, not related to this PR) and Hari, Gabriel, Suresh has LGTM'd.

@GutoVeronezi one tip - if you write the description in your commit message while doing git commit, it will automatically show up in the Github PR description and also helps when merging the PR (we won't need to copy/paste the PR description in the merge-commit msg).


[cli_config] Handle paths on Windows

And add Windows CI.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

5 of 5 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
236

Relevant Lines:
236

💛  - Coveralls

Thanks for the quick review @HosseinYousefi !