Side chain bias - pull request

Description
Updates to the side chain move class that facilitate identification of dihedral atom indices (without manual entry) as well as target rotamer bins (based on an input rotpref.yaml file)
Status

Needs review

@khburley Your PR looks good for the most part, except some of your tests are failing.

            Takes in a PDB filename (as a string) and list of residue numbers.  Returns
            a nested dictionary of rotatable bonds (containing only heavy atoms), that are keyed by residue number,
            then keyed by bond pointer, containing values of atom indicies [axis1, axis2, atoms to be rotated]
            Note: The atom indicies start at 0, and are offset by -1 from the PDB file indicies

            Returns
            -------
            rot_atoms : dict
                Dictionary of residues, bonds and atoms to be rotated
            rot_bonds : dict of oechem.OEBondBase
                Dictionary containing the bond pointers of the rotatable bonds.
            qry_atoms : dict of oechem.OEAtomBase
                Dictionary containing all the atom pointers (as OpenEye objects) that
                make up the given residues.

            """
        backbone_atoms = self.getBackboneAtoms(self.molecule)

        # Generate dictionary containing locations and indicies of heavy residue atoms
        #print('Dictionary of all query atoms generated from residue list\n')
        qry_atoms, backbone_atoms = self.getTargetAtoms(self.molecule, backbone_atoms, self.residue_list)

        # Identify bonds containing query atoms and return dictionary of indicies
        rot_bonds = self.findHeavyRotBonds(self.molecule, qry_atoms)

        # Generate dictionary of residues, bonds and atoms to be rotated
        rot_atoms = self.getRotAtoms(rot_bonds, self.molecule, backbone_atoms)

        # Read in yaml file
>       rotfile = open('rotpref.yml',"r")
E       FileNotFoundError: [Errno 2] No such file or directory: 'rotpref.yml'

Maybe you can use the blues.utils.get_data_filename() function to get the path to the rotpref.yml file in the package to get around that.


Actual URL query params (?param=value) are mixed into hash route query params

Let's say I have a Route set up for browse/:id
When navigating to this URL:
http://localhost:9000/?debug=false&noCache=false#browse/tv?renderStrategy=deferNextFrame

I get the following data coming back in the call to _onUrlParams(params):
{
  id: "tv",
  Symbol(queryParams): {
    debug: "false",
    noCache: "false",
    renderStrategy: "deferNextFrame"
  },
  Symbol(store): undefined
}

You can see the actual URL params debug and noCache are mixed in with the hash URL param renderStrategy. I think there should be a way to distinguish these two types of URL params. The actual ones are used to control aspects of the application globally, the hash ones target specifically the Page pointed to at that route.
If anything it would be great to have easier access (not using symbols) to such params. Why not mix the hash URL params in with the hash route params? Something like this, as a suggestion:
{
  urlParams: {
    debug: "false",
    noCache: "false",
  },
  routeParams: {
    id: "tv",
    renderStrategy: "deferNextFrame"
  }
}

Hi @forthrightwit,
I recently found a situation like this in a Lightning app, and as far as I can tell, the URL format you presented (with queryParams, an hash and more query params afterwards) is against RFC-3986 spec. Specifically, all query params in a URL should come before the # and not after, read here: https://superuser.com/questions/498617/does-an-anchor-tag-come-before-the-query-string-or-after
I don't know what is the solution here (nor do I make those kind of decisions in Lightning), but I'm not sure the Lightning team should be developing a feature to support something non-standard.

Hi @forthrightwit, thanks for your patience on this issue.
We have looked at your request, and although we understand that it would make easier access, we unfortunately don't plan to implement this feature.
Also as @mauro1855 also pointed out, the URL format you proposed is invalid. And it's not intended behavior to add query params to a route segment itself.


Skype call sample not detecting dtmf tones

URL of Code Sample

Problem Description
I cloned the Skype calling sample from here and made all the changes mentioned , and published the Bot.
After publishing whenever i call the bot , it is only repeating the welcome message in repeat mode.
The code is same as in sample , only i have added some keys.
Can anyone help me out here.
@msft-shahins  @msftgits
`  // Response messages depending on user selection
private const string WelcomeMessage = "Hello, you have successfully contacted Test Calling Bot";
private const string MainMenuPromptMessage = "Please press 1 to continue";
private const string NoConsultantsMessage = "Whilst we wait to connect you, please leave your name and a description of your problem. You can press the hash key when finished. We will call you as soon as possible.";
private const string EndingMessage = "Thank you for leaving the message, goodbye";
private const string OptionMenuNotSupportedMessage = "The option you entered is not supported. Please try again.";
    private readonly Dictionary<string, CallState> callStateMap = new Dictionary<string, CallState>();

`

Even Skype Android App, doesn't have any dialpad to submit 1. it is just repeating first welcome message.

@CoHealer not sure if we're planning to make any progress on this.  it's very old

Resolving as won't fix


Using {build_type} in pyproject.toml

Preamble: Thanks a lot for this wonderful tool! I don't know if issues are the way to make feature requests. So please excuse me if it is not.
In order to speed-up rebuilds, I would find it wonderful to have the possibility to configure the build directory with a {build_type} metadata in the pyproject.toml file, the same way we can use {wheel_tag}.
I can't even figure if this is possible and easy to implement. I just searched the issues for this feature and could not find any.

Thanks a lot @henryiii 😃


@jgoz/esbuild-plugin-livereload parameter to accept external connections

Attempt at fixing issue #114.
I was uncertain how to go about testing the changes, however, I did verify that setting host to <IP_ADDRESS> in packages/esbuild-plugin-livereload/src/server.ts does fix the issue for me.
This PR adds an option that sets the server host to <IP_ADDRESS>, while preserving the host value that determines where the script is fetched from.

@KurtPreston Thanks for submitting this, but I think it might be unnecessary. There is already a host option that you set to <IP_ADDRESS> directly: https://github.com/jgoz/esbuild-plugins/tree/master/packages/esbuild-plugin-livereload#function-livereloadpluginoptions-livereloadpluginoptions-plugin
Can you give that a try and let me know if it works?

Closing in favor of b23f695f5c05e1877f06043bcaef861a4a7170dc. Thanks again for contributing


feat(FX-4311): Loading states for Activity Panel

Demo
Loading activity item placeholder
https://user-images.githubusercontent.com/3513494/193255621-e002be35-3edb-47a1-b5ee-2919d1dc9f8f.mp4
Fetching more indicator
https://user-images.githubusercontent.com/3513494/193255646-c7b2d3c1-43f2-4db1-866a-16bf94028d28.mp4

This PR resolves FX-4311
QA Testing

Acceptance Criteria

Setup Instructions

PR Checklist

[x] I tested my changes on iOS / Android.
[x] I added screenshots or videos to illustrate my changes.
[ ] I added Tests and Stories for my changes.
[ ] I added an app state migration.
[x] I hid my changes behind a feature flag.
[ ] I have prefixed changes that need to be tested during a release QA with [NEEDS EXTERNAL QA] on the changelog.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

Loading states for Activity Panel - dimatretyak

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

hmmm, I noticed that in the videos that you attached (thank you for that) the placeholder disappears and after that we see for a sec a blank screen after the sections appear 🤔

unfortunately, I haven't been able to come up with a simple solution to fix the this loading behavior 🥲


nyani??!?!??!?!

e-ewwor instawwing o-on em1 makbuk p-pwo ('_')
```error[E0432]: unresolved import uwuifier::uwuify_sse
--> /Users/myrealnameudontsee/.cargo/registry/src/github.com-1ecc6299db9ec823/uwuify-0.2.2/src/main.rs:1:5
|
1 | use uwuifier::uwuify_sse;
|     ^^^^^^^^^^^^^^^^^^^^ no uwuify_sse in the root
error: aborting due to previous error
For more information about this error, try rustc --explain E0432.
error: failed to compile uwuify v0.2.2, intermediate artifacts can be found at /var/folders/q3/v84w5_7j11g__d2g4b0z5sqh0000gp/T/cargo-install2HXfsc

also i uwuified the first sentence by hand lmao

formatting took an f dont mind it

ur cpu probably doesn't have sse support (eg., recent-ish intel or amd cpu) :'(

yup

m1, which is an arm cpu, isn't currently supported rn :'(
pain

awwwwwwww :(:(:(:(:(:(:(


[FEATURE] Expose SkSL?

It seems the SkSL has a public API, and had GPU and CPU backends.
Although Google says it is likely to change a bit since it is under active development.
Since back in the days even good old Silverlight had such a feature, I think it would make sense to expose it in SkiaSharp.
If so, I would be happy to make a PR.

I don't think that this will be useful because you need to compile shaders alongside Skia itself. If it would be possible to compile shaders at runtime this would be a killer feature.

I think I saw a demo where the shader was just a string... So maybe? I have been keeping an eye on that and I think a runtime compilation might actually be something. I'll have a closer look...

According to the reply I got from Google in Skia discuss, it now has an interpreter and JIT...
In the CanvasKit fiddle you just pass a string:
https://jsfiddle.skia.org/canvaskit/33ff9bed883cd5742b4770169da0b36fb0cbc18fd395ddd9563213e178362d30
But that one is running on the GPU, so not a good reference...
I will ask more questions in Skia discuss, but if you have to precompile shaders, it is indeed limited.
We could of course write a backend for SkSL that generates SIMD ILASM ;-)

Keep up the discussion there! Then I can see what needs to be done to make it work well in SkiaSharp

For those following along at home https://groups.google.com/forum/m/#!topic/skia-discuss/LNCQs-7b7rk

I think it was @kekekeks was asking about this in the past?

Y being able to compile shaders at runtime would allow us to introduce custom effects.

Our idea was to provide GLSL text and a pointer to software implementation func. Proper SkSL with JIT on the Skia side would be indeed way better.

My feeling from following the discussion in the skia mailing list, is that the CPU implementation is currently a bit behind the GPU one.
My customer's current server side renderer uses DirectX 11 WARP, a purely software implementation of DirectX 11, so it seems Skia is not yet at that level, but its catching up (in 2008, WARP could run Crysis on a Core i7!)
Nevertheless I think that most users will use the GPU for rendering with Skia, and then exposing SkSL might be a really nice feature?
It seems one just needs to expose the SkRuntimeShader class, with some small helper structs. To pass data, Span<byte> could be used. Of course a much higher level interface could be provided, using .NET marshalling to provide the values of the uniforms, like SharpDX does.

Having a look right now. going to get a very simple thing working and see what happens. I should be working on actual issues, but COVID-19, right?

That's the positive side of the Corona crisis. Some people have more time to spend on things they love.

Good news folks! Things seem to be working!!! At least on Windows x64. Just tweaking the bindings and adding a few tests and then I'll push a branch for folks to play around with. Seems all we need is a string and we are off to the races!

That is great news! So you couldn't resist, hehe, I know the feeling ;-)
I guess in the longer term we will need some methods to transfer/marshal uniform data and SkShader instances to the runtime shader?

Hehe, no I couldn't. We might be able to do something with a "dictionary" type of thing for the inputs. There is some iterable object.
The tests have a possible starting point: https://github.com/google/skia/blob/5f6b41e6d8aa1ead3cbdb94a483bc8bea32e0fb3/tests/SkRuntimeEffectTest.cpp#L74-L90

I have the code here for now (https://github.com/mono/SkiaSharp/pull/1221).
The GPU bits seem to work - 1 simple test. The CPU needs some compiler options but I think the GPU is fine for basic testing and experimentation. I need to do actual work now...

Moved the code and changes to a new PR which is much better and I hope to get a working GPU package out: #1321

I have been doing some work on this... Let me know what you think: https://github.com/mono/SkiaSharp/issues/1319#issuecomment-640529824

This has been implemented and 3.x of SkiaSharp now has full support.


xpdan >=0.8.2

Currently, the version conda picked for us is 0.5.2 (observed during the deployment visit).

That may not be needed anymore, as pdfstream will be used from now on for PDF/XPD production. Need to confirm with @danolds if it's OK to remove xpdan and other relevant config libs from the environment.


Add custom barrier that doesn't cover the dropdown button

This is updated PR related to changes described here: https://github.com/AhmedLSayed9/dropdown_button2/pull/180

Awesome, Thanks!


Crafting a diamond (or potentially any upgraded) quiver via smithing table and holding a bow causes the game to crash

crash-2024-10-06_18.38.44-server.txt
latest.log
Title and above logs are the only information i have about this.

Update: attempting to edit all problematic items out of inventory via NBTexplorer has not changed a single thing. The game still behaves as if i still have the quiver, arrows, and bow in my inventory. This needs to be fixed via an update.


Moving some scripts/css to be less render-y blocking.

I think there's some more way to optimize this, but this is the bare minimum.
Since landing.js requires jQuery it needs to remain in <head> as well as TypeScript since it is responsible for css and fonts above the fold.

This PR breaks both the navigation and tabs on mobile.


change to opensearch

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I'm in the process of moving this workshop to workshops.aws. I already performed this change. This repository will be closed after the migration. Thanks anyway for your help.

Nice! I ran the workshop twice, including one today.
The one feedback I have is that Lab3 needs more details and screenshots in the section about creating the Access Policy in Elastic Search. I added a couple in my fork but attendees were still quite confused so maybe that part needs to be fleshed out a bit more.
Great workshop!

Thanks for the feedback. I will have a look and take your input to improve
this part.
Le mar. 28 sept. 2021 à 21:13, Sohan @.***> a écrit :

Nice! I ran the workshop twice, including one today.
The one feedback I have is that Lab3 needs more details and screenshots in
the section about creating the Access Policy in Elastic Search. I added a
couple in my fork
https://github.com/sohanmaheshwar/workshop-textract-comprehend-es/tree/master/synchronous/Lab3
but attendees were still quite confused so maybe that part needs to be
fleshed out a bit more.
Great workshop!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/aws-samples/workshop-textract-comprehend-es/pull/4#issuecomment-929548113,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA4WISP65PZXZVULTUTLQ3UEIHVRANCNFSM5E5ZSHTA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


[VT-78] VITtk font "zooming"

David Patrick on 2011-04-24T05:49:42Z says:
It can be annoying to start "VITtk":/wiki/Vittk without the correct font size setting, and be forced to remember what my preferred settings are and how to invoke them. Considering that there is only a limited set of possibilities, couldn't a keybinding be assigned to drive the display font up and down that list ? Wouldn't that be like "zooming" ? Might we use the same combo as our browsers ? (Ctrl + and Ctrl -) ?

Migrated metadata:
Created: 2011-04-24T05:49:42Z
Modified: 2014-02-09T02:26:42Z

steve rader on 2011-04-24T14:03:13Z says:
You don't have to remember your preferred font: set it via a
font= setting in ~/.vittkrc.
VITtk can't zoom fonts like e.g. Firefox does because it doesn't
have a reasonably workable method for mapping the current font to
e.g. the current font plus one point.

David Patrick on 2011-04-24T14:54:48Z says:
steve rader wrote:

You don't have to remember your preferred font: set it via a
font= setting in ~/.vittkrc.

That's true, although I had been supplying those settings via command alias.
There are times though, like when I'm connected remote, from another desktop, with another resolution, or when my eyes go fuzzy, that it would be handy to bump it up or down a notch.

VITtk can't zoom fonts like e.g. Firefox does because it doesn't
have a reasonably workable method for mapping the current font to
e.g. the current font plus one point.

Of course it will never have the granularity of a full GUI app, but how many font/line-hight setting are there (within the range of practical) ? 8 ? 10 ? If the "zoom" control just went up and down that list of available sizes, it might be very likeable.

steve rader on 2011-04-25T11:37:11Z says:

Of course it will never have the granularity of a full GUI app, but how many font/line-hight setting are there (within the range of practical) ? 8 ? 10 ? If the "zoom" control just went up and down that list of available sizes, it might be very likeable.

What's problematic isn't the availability of various font sizes--VITtk can
display all the same fonts as GTK+ applications do.  This issue is that
Xwindows fonts are not necessarily scalable fonts.  Restricting VITtk to only
the scalable fonts isn't practical because there isn't a portable monospaced
scalable font available.  (The portable monospaced font is "TkFixedFont" and
there is no map to progamatically map it to the same font one size bigger.)
VITtk could "zoom" between user specified fonts but won't be motivated
to add that feature until someone provides a patch or there like a half
dozen users clamoring for it.

David Patrick on 2011-04-25T14:13:32Z says:
steve rader wrote:

VITtk could "zoom" between user specified fonts but won't be motivated
to add that feature until someone provides a patch or there like a half
dozen users clamoring for it.

Well I'll just start a "clamoring for live font-size-selection-in VITtk" Facebook group then, won't I ?
clamourclamour
;)


Listener timeout after waiting for [30000] ms

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?

What's the reason for this?What can I do to avoid this mistake?
Background: the address of our ali cloud ecs machine was changed, and then the collector service was restarted after a period of time, and the agent only had one service restarted.

Bug

Which version of SkyWalking, OS and JRE?

Which company or project?

What happen?
If possible, provide a way for reproducing the error. e.g. demo application, component version.

Requirement or improvement

Please describe about your requirements or improvement suggestions.

That is as it said... ElasticSearch doesn't response.

We also have a machine connected to this es, which can work normally all the time

Then, you should check the version, auth. or anything affecting the es connectable. There is nothing special there.

Are you saying that we failed to connect with es successfully?

From the log, yes. This is just a very simple query to es, but can't access.

Version, address, username and password are all correct. What else might be the reason?

I am not sure then. SkyWalking is just supporting easy auth. Please check whether it fits your server side. Have you read this? https://github.com/apache/skywalking/blob/master/docs/en/setup/backend/backend-storage.md#about-authentication

I changed the log level to debug and found the logs. I guess it's the reason for the cache (mesh-buffer, trace-buffer).

I've seen this problem before, and the solution is set the elasticsearch RestClient.builder socketTimeOut，Specific setting method asks baidu。


Unable to pull image from private registry when starting container

I have pushed a custom image to a private docker registry (using the standard registry image).  When I attempt to start a container using the private image using "myhost.com:5000/repo/my-image" I get an "Error not found".
I have used an ansible-playbook to log into all of my docker hosts and execute "docker pull myhost.com:5000/repo/my-image".  Once this completed and I re-attempted to run a container via shipyard and it starts a container on one of my engines fine.
Is it possible to get the docker pull to work from a private docker registry?

I'm getting the same "Error  not found" with version 2.0.8 when I want to deploy a container from a private registry.
The docker client at the host is logged in. There's a ping happening against the private registry, but no other requests.


column_property not supported

from pprint import pprint as pp
from flask import Flask
from flask_sqlalchemy import SQLAlchemy

from sqlalchemy.orm import column_property
from sqlalchemy import select, func, literal_column

app = Flask(__name__)
app.config['SQLALCHEMY_DATABASE_URI'] = 'sqlite:///:memory:'
app.config['SQLALCHEMY_ECHO'] = False
db = SQLAlchemy(app)

from sqlalchemy import Column, Integer, String

class Book(db.Model):
    __tablename__ = 'books'

    id = Column(Integer, primary_key=True)
    name = Column(String)
    author_id = Column(Integer)

class Author(db.Model):
    __tablename__ = 'authors'

    id = Column(Integer, primary_key=True)
    name = Column(String)
    books_count = column_property( select([func.count()]).where(Book.author_id==id) )

db.create_all()

author = Author(name='Andrea')
db.session.add(author)
db.session.commit()
pp(author)

book = Book(name='Random book name', author_id=author.id)
db.session.add(book)
db.session.commit()
pp(book)

pp(("Andrea's books_count", author.books_count))

from pydantic_sqlalchemy import sqlalchemy_to_pydantic
pp(sqlalchemy_to_pydantic(Book))
pp(sqlalchemy_to_pydantic(Author))

Calling sqlalchemy_to_pydantic(Author) goes in error:
Traceback (most recent call last):
  File "/home/andreossido/.local/lib/python3.8/site-packages/sqlalchemy/sql/elements.py", line 747, in __getattr__
    return getattr(self.comparator, key)
AttributeError: 'Comparator' object has no attribute 'default'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "script.py", line 49, in <module>
    pp(sqlalchemy_to_pydantic(Author))
  File "/home/andreossido/.local/lib/python3.8/site-packages/pydantic_sqlalchemy/main.py", line 32, in sqlalchemy_to_pydantic
    if column.default is None and not column.nullable:
  File "/home/andreossido/.local/lib/python3.8/site-packages/sqlalchemy/sql/elements.py", line 749, in __getattr__
    util.raise_(
  File "/home/andreossido/.local/lib/python3.8/site-packages/sqlalchemy/util/compat.py", line 182, in raise_
    raise exception
AttributeError: Neither 'Label' object nor 'Comparator' object has an attribute 'default'

I also tried with code below
column_property( db.Column(db.Integer), select([func.count()]).where(Book.author_id==id) )

With Integer column sqlalchemy_to_pydantic doesn't throws exceptions, but author.books_count is wrong
Because query select field authors.books_count (that not exists)

I wrote a very dirty solution, but works
from sqlalchemy.orm import column_property
from functools import wraps
def custom_column_property(func):
    @wraps(func)
    def wrapper(*args, default=None, nullable=True, **kwargs):
        v = func(*args, **kwargs)
        for column in v.columns:
            column.default = default
            column.nullable = nullable
        return v
    return wrapper
column_property = custom_column_property(column_property)

In this way you can declare column_property in models as always and calling sqlalchemy_to_pydantic doesn't throws errors

Just for instance, you can call column_property in these ways:
books_count = column_property( select([func.count()]).where(Book.author_id==id) )
books_count = column_property( select([func.count()]).where(Book.author_id==id), default=-1 )
books_count = column_property( select([func.count()]).where(Book.author_id==id), nullable=False )
books_count = column_property( select([func.count()]).where(Book.author_id==id), default=-1, nullable=False )


add Noto Serif CJK

Add Noto Serif CJK

[x] Named the cask according to the [token reference].
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.
[x] Checked there are no [open pull requests] for the same cask.
[x] Checked the cask was not already refused in [closed issues].

Update download URL

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Thank you.


typescript/lib/es5.ts' not found, typescript/lib/dom.ts' not found, es2015.promise' has unsupported extension

I compile in node with version 3.5.2 .ts code to .js using the example compiler from here:
https://github.com/Microsoft/TypeScript/wiki/Using-the-Compiler-API
passing in options like this:
 target: ts.ScriptTarget.ES5,             allowJs: true,             skipLibCheck: true,             lib: [                 'dom', 'es5', 'es2015.promise'             ]
and I get a warnings:
typescript/lib/es5.ts' not found, typescript/lib/dom.ts' not found, es2015.promise' has unsupported extension
Bug.

When using the programmatic api, "lib" contains strings with full file name:
lib: ['lib.es2017.d.ts', 'lib.dom.d.ts']

thx. works. closing.

Sorry, one more question: Cannot find name '$'. Do you need to install type definitions for jQuery? Try npm i @types/jquery.
I do have types/jquery in packages, but I still get above. I would rather not declare in each file. What can I do to remove?

Probably you need moduleResolution set to node.


Fix test toy dataset predictions

Description
Fix the fix-test_toy_dataset_predictions test by adding a factor to the EPSILON precision machine variable higher than 1 in order to ensure that the inequalities are always verified.
Fixes #154
Type of change
Please remove options that are irrelevant.

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Unit tests seem to pass on Windows jobs.
Checklist

[x] I have read the contributing guidelines
[x] I have updated the HISTORY.rst and AUTHORS.rst files
[x] Linting passes successfully : make lint
[x] Typing passes successfully : make type-check
[x] Unit tests pass successfully : make tests
[x] Coverage is 100% : make coverage
[x] Documentation builds successfully : make doc

Codecov Report

Merging #156 (f856417) into master (462207a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #156   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           18        18
  Lines         1305      1317   +12
  Branches       151       151
=========================================
+ Hits          1305      1317   +12

Impacted Files
Coverage Δ

mapie/_machine_precision.py
100.00% <100.00%> (ø)

mapie/classification.py
100.00% <100.00%> (ø)

mapie/tests/test_classification.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 462207a...f856417. Read the comment docs.


[Fix] Summary types

Se cambian los strings de los summary item types.

Codecov Report

Merging #672 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           develop     #672   +/-   ##
========================================
  Coverage    28.92%   28.92%
========================================
  Files          243      243
  Lines        17501    17501
  Branches      1518     1518
========================================
  Hits          5063     5063
  Misses       11915    11915
  Partials       523      523

Impacted Files
Coverage Δ

...in/java/com/mercadopago/model/SummaryItemType.java
0% <ø> (ø)
:arrow_up:

...k/src/main/java/com/mercadopago/model/Summary.java
85.96% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9cb77b...b50573e. Read the comment docs.


[nRF Platform Example] Bring up CHIP Stack - Support Pairing Start button

Problem
<what's wrong or missing, please include any applicable:

expected behavior
actual behavior
steps to reproduce
system configuration
screenshots, images, logs, etc.

Proposed Solution
<suggested fix, suggested enhancement>

Already done.

Actually this probably still needs work as it triggers thread commissioning.

That is already implemented and not valid for the nRF Connect platform. Closing.


*: tidy FunctionString.cpp

What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/cc @Lloyd-Pottiger

/run-all-tests

/merge


[v2.6] set kubernetes.io/cluster tag for rke2 ec2 instances

https://github.com/rancher/rancher/issues/34233


Intellisense is insane recommending stuff that doesn't match what was typed

Issue Description
Steps to Reproduce
Expected Behavior
Actual Behavior
Logs
OmniSharp log
Post the output from Output-->OmniSharp log here
C# log
Post the output from Output-->C# here
Environment information
VSCode version: 1.41.0
C# Extension: 1.21.9
Dotnet Information
.NET Core SDK (reflecting any global.json):
 Version:   3.1.100
 Commit:    cd82f021f4
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.19041
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\3.1.100\
Host (useful for support):
Version: 3.1.0
Commit:  65f04fb6db
.NET Core SDKs installed:
2.2.402 [C:\Program Files\dotnet\sdk]
3.1.100 [C:\Program Files\dotnet\sdk]
.NET Core runtimes installed:
Microsoft.AspNetCore.All 2.1.14 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.2.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.2.8 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.14 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.2.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.2.8 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.1.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.1.14 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.2.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.2.8 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.1.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 3.1.0 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
To install additional .NET Core runtimes or SDKs:
https://aka.ms/dotnet-download

Visual Studio Code Extensions

Extension
Author
Version

angular-console
nrwl
10.0.0

angular-essentials
johnpapa
0.6.3

Angular2
johnpapa
8.2.0

angular2-inline
natewallace
0.0.17

application-insights
VisualStudioOnlineApplicationInsights
0.4.2

auto-using
Fudge
0.7.9

autorest
ms-vscode
2.0.1

azds
azuredevspaces
2.0.220191204

azure-account
ms-vscode
0.8.7

azure-pipelines
ms-azure-devops
1.157.4

azurecli
ms-vscode
0.4.6

csharp
ms-vscode
1.21.9

dart-code
Dart-Code
3.7.1

debugger-for-chrome
msjsdiag
4.12.3

debugger-for-edge
msjsdiag
1.0.13

docomment
k--kato
0.1.8

dotnet-test-explorer
formulahendry
0.7.1

EditorConfig
EditorConfig
0.14.3

flutter
Dart-Code
3.7.1

githistory
donjayamanne
0.4.11

material-icon-theme
PKief
3.9.2

msbuild-project-tools
tintoy
0.3.2

ng-template
Angular
0.900.2

powershell
ms-vscode
2019.11.0

prettier-vscode
esbenp
3.14.0

python
ms-python
2019.11.50794

remote-containers
ms-vscode-remote
0.94.0

remote-ssh
ms-vscode-remote
0.48.0

remote-ssh-edit
ms-vscode-remote
0.48.0

remote-wsl
ms-vscode-remote
0.41.6

team
ms-vsts
1.161.0

vs-sharper
eservice-online
0.2.0

vscode-ai
ms-toolsai
0.6.8

vscode-aks-tools
ms-kubernetes-tools
0.0.4

vscode-angular2-files
alexiv
1.6.2

vscode-azureappservice
ms-azuretools
0.16.2

vscode-azureeventgrid
ms-azuretools
0.1.1

vscode-azurefunctions
ms-azuretools
0.20.1

vscode-azurestorage
ms-azuretools
0.7.2

vscode-cosmosdb
ms-azuretools
0.11.0

vscode-docker
ms-azuretools
0.9.0

vscode-firefox-debug
firefox-devtools
2.6.0

vscode-kubernetes-tools
ms-kubernetes-tools
1.0.9

vscode-npm-script
eg2
0.3.10

vscode-peacock
johnpapa
3.2.0

vscode-remote-extensionpack
ms-vscode-remote
0.19.0

vscode-typescript-tslint-plugin
ms-vscode
1.2.3

vscode-versionlens
pflannery
0.24.0

vscode-yaml
redhat
0.6.1

vscodeintellicode
VisualStudioExptTeam
1.2.0

vsliveshare
ms-vsliveshare
1.0.1377

winteriscoming
johnpapa
1.3.0

xml
DotJoshJohnson
2.5.0

I have an object named dto for example. if I type 'dto.' it recommends 'decimal' instead even though that doesn't match dto and there is an object named dto that it should match.

Please set "omnisharp.loggingLevel":"trace" and provide the output.
It would be helpful to also provide a repro project that is causing you issues.
Otherwise it's pretty much impossible to provide any support. Thanks.

Closing out as no additional info was added.


Bossbar

No config

What ? Hahaha

Crashes now

Hey I saw you in my stream thanks for watching :))

can i see the error log?


Stick down some versions so it builds

This is not really "fixing" it entirely since there are still mysterious build failures on rustc 1.44-nightly 2020-04-09, only with cargo install --path ., but not with cargo build. Regardless, this PR causes it to sometimes build.
dev/srv - [fix-build●] » cargo install --path .
  Installing srv v0.1.0 (/home/lf/dev/srv)
    Updating crates.io index
    Updating git repository `https://github.com/gyscos/Cursive.git`
    Updating git repository `https://github.com/daboross/rust-screeps-api.git`
   Compiling srv v0.1.0 (/home/lf/dev/srv)
warning: unused imports: `cell::RefCell`, `rc::Rc`
 --> src/ui/console.rs:1:11
  |
1 | use std::{cell::RefCell, mem, rc::Rc};
  |           ^^^^^^^^^^^^^       ^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

warning: unused imports: `CbSink`, `ColorStyle`, `Direction`, `EventResult`, `Event`, `Key`, `MouseButton`, `MouseEvent`, `Orientation`, `Printer`, `Vec2`, `XY`, `menu::MenuTr
ee`
  --> src/ui/console.rs:4:17
   |
4  |     direction::{Direction, Orientation},
   |                 ^^^^^^^^^  ^^^^^^^^^^^
5  |     event::{Event, EventResult, Key, MouseButton, MouseEvent},
   |             ^^^^^  ^^^^^^^^^^^  ^^^  ^^^^^^^^^^^  ^^^^^^^^^^
6  |     menu::MenuTree,
   |     ^^^^^^^^^^^^^^
7  |     theme::{BaseColor, Color, ColorStyle},
   |                               ^^^^^^^^^^
...
11 |     CbSink, Cursive, Printer, Vec2, XY,
   |     ^^^^^^           ^^^^^^^  ^^^^  ^^

error[E0220]: associated type `SinkError` not found for `futures_sink::Sink<websocket::message::OwnedMessage>`
   --> src/net.rs:252:28
    |
252 |     Si: Sink<OwnedMessage, SinkError = Error> + Unpin,
    |                            ^^^^^^^^^ associated type `SinkError` not found

error: aborting due to previous error

For more information about this error, try `rustc --explain E0220`.
error: failed to compile `srv v0.1.0 (/home/lf/dev/srv)`, intermediate artifacts can be found at `/home/lf/dev/srv/target`

Caused by:
  could not compile `srv`.

To learn more, run the command again with --verbose.

Thanks!
I haven't maintained this project in a while, but I wouldn't be against getting it into a working state.

With regards to the FutureSink error, if I had to guess I think it's probably our depending on an old version of futures-preview. I think if we set the version to something like version = "=0.3.0-alpha.whateverlastworked" it should fix it for now.
A better solution would be to fully migrate to async/await and futures 0.3, but I think that's more work.

Thanks for explaining the reasoning behind the changes - I think this should be reasonable to merge now.


test(node affinity): verify volume provisioning by adding non existing node-affinity rule

Pull Request template
Why is this PR required? What issue does it fix?:
This PR is required to add negative test cases of
node-affinity feature.
What this PR does?:
This PR adds the following test cases:

Provision volume by adding non-existing node-affinity rule and
verify that volume provisioning should fail.
Add a non-existing node-affinity rule to one of the nodes and
verify that volume provisioning should succeed

Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:

[ ] Fixes #
[x] PR Title follows the convention of  <type>(<scope>): <subject>
[ ] Has the change log section been updated?
[ ] Commit has unit tests
[x] Commit has integration tests
[ ] (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
[ ] (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

Codecov Report

Merging #71 (be421c2) into develop (cbb6dc2) will increase coverage by 8.31%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop      #71      +/-   ##
===========================================
+ Coverage    36.83%   45.15%   +8.31%
===========================================
  Files           27       27
  Lines         2234     2241       +7
===========================================
+ Hits           823     1012     +189
+ Misses        1366     1159     -207
- Partials        45       70      +25

Impacted Files
Coverage Δ

provisioner/config.go
0.00% <ø> (ø)

provisioner/helper_kernel_nfs_server.go
76.11% <ø> (+76.11%)
:arrow_up:

provisioner/provisioner.go
0.00% <0.00%> (ø)

pkg/kubernetes/api/core/v1/container/container.go
45.08% <0.00%> (ø)

provisioner/env.go
28.57% <0.00%> (+14.28%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbb6dc2...be421c2. Read the comment docs.


⚠ Mobitopup has degraded performance

In 268ebac, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 11217 ms

Resolved: Mobitopup performance has improved in 5b42455.


Properties hotkey

What feature or improvement do you think would benefit Files?
In regular explorer I can do Alt+Enter or Alt+double click on a file or folder and open the properties window.
Can this be added to Files? Seems like an oversight.
Thanks!
Evan
Requirements

Add Alt-Enter as a hotkey for opening the properties window.
Add Alt-Double click as a hotkey for opening the properties window.

Files Version
<IP_ADDRESS>
Windows Version
10.0.22621.1848
Comments
No response

Thank you for your feedback, alt + enter is already implemented, can you give it a try?


Doesnt work on chapter 2 season 6 and above

When injecting, it says

Can you dump the FortniteClient-Win64-Shipping.exe with Scylla and send it to me?

Can you dump the FortniteClient-Win64-Shipping.exe with Scylla and send it to me?
Whats Scylla and wheres the download for it

Here is the download: https://github.com/NtQuery/Scylla/releases/download/v0.9.8/Scylla_v0.9.8.rar
To dump, extract the RAR file, open Fortnite and then:

Open Scylla_x64.exe.
In the top, click the long bar and scroll through until you find "FortniteClient-Win64-Shipping.exe".
Once you've found it, click it to select it.
Press dump in the bottom right, then select where you want the file to be.
After that, use Google Driver or something similar to upload the file you saved.
Then send me the link and I will update the cheat to fix the crash.

Not OP but im working on it @raax7

Error: Cannot dump image.

Could you send a screenshot of the error? And could you walk me through how you are dumping it?

I'm gonna try dumping now.

https://gofile.io/d/9aGCms

Thank you, I will update the cheat in the next hour or so to support your new version. I will close this issue once I have updated it.

Just to confirm, this build is Chapter 2 Season 6 correct?

I've pushed a fix for this. Re-download the source code and it should work. If it still doesn't work, please re-open the issue and let me know.

Just to confirm, this build is Chapter 2 Season 6 correct?

chapter 2 season 6 to chapter 3


Progressive ideology

pesgores
There is something I noticed that is a bit annoying. Most countries never develop Progressive pops, even if there are Progressive parties. My guess is the Nationalists being an 8th ideology messed something up, perhaps. Also Communist pops sometimes are so small that they effectively disappear, is that WAD?
simsulla
This may be related to "incorrect base chance change ideology 0% #587", that will be fixed in 1.08.
In general progressives should gain strength as the game progress (by consciousness and affluence). But I see they are overshadowed by liberals. Created issue

By transender
Bureaucrats and Liberalism
They are more liberal because they belong to middle strata, but instead of Liberalism they should support ruling party more (+50% in democracy +150% in dictatorship)
Ruling parties will try to replace "their" men with "our" men. And in dictatorships... well the state apparatus is very likely to be of the same ideology than the ruling party.


Capture the device's thermal state

Problem Statement
As a user, I'd want to see the customer's device's thermal state as part of the events I get in the dashboard. These can also be treated as App hangs and have their separate events.
Solution Brainstorm
I have written a small plugin that gets an iOS device's current thermal state and it subscribes to thermal state changes and sends the events to Flutter (it uses ProcessInfo just like the Apple docs say). I'm sure this will be trivial in Android. I'm confused about where some events come from because of the flags that control native performance reporting. So I don't know if this should be the responsibility of Flutter or Android and iOS SDKs.
Are you willing to submit a PR?
Yes

@ahmdaeyz Thanks for your message.
Do you mean something like https://source.android.com/docs/core/power/thermal-mitigation#thermal-api ?
We already collect the device temperature as well https://github.com/getsentry/sentry-java/blob/3baa73f8cb421d911d8606916fa0945193251178/sentry-android-core/src/main/java/io/sentry/android/core/DefaultAndroidEventProcessor.java#L471-L481
Is your plugin on GitHub? can you share the link so we can take a look?
Thanks.

Also, what's the relation between the thermal state and app hangs?
I see the thermal state as extra metadata, but part of a thrown error, while the app hangs, is its own error.

@ahmdaeyz any feedback on the questions above?

Hey @marandaneto
I'm sorry for my late reply. For some reason I can't see the temperature in the dashboard. Maybe it is sent on certain events with a logic behind it? Where is it supposed to show up?
What I meant with

These can also be treated as App hangs and have their separate events
I meant treat it just like app hangs, When the device thermal state of the user reaches a critical state it might be reasonable to log it so that If the app is getting hot on users device the developer get notified and fix it.

I will try to push my thermal plugin code to Github and link you to it.

It's part of the Device context on the Issue details page.
https://your_org.sentry.io/issues/?project=your_project -> eg click on any Android issue, it should be a real device with temperature capabilities.
I don't think it's a good idea to raise an event if the device's thermal state is hot since it can be caused by any other app or even the OS, leading to a lot of false-positive/noise.
Tag me and I can take a look, thanks for raising this, closing it for now.


Update release notes

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

I see updates to mostly main release notes here, assuming the respective extension ones are updated already. Just want to confirm.


BUG: split_search skips non_match sequences if --frag-len too large

split_search.py produces no output, i.e. 0 match and non_match files for this outfile:
Query         NZ_GG666849.1_2_251-330 # 798 # 2885 # -1 # ID=1_2;partial=00;start_type=TTG;rbs_motif=AGxAGG/AGGxGG;rbs_spacer=5-10bp;gc_cont=0.499
Match_columns 80
No_of_seqs    1 out of 1
Neff          1
Searched_HMMs 36595
Date          Sun May 21 18:41:09 2017
Command       hhsearch -i ./02-split_pdb/2/NZ_GG666849.1_2_251-330.fasta -d /projects/microprot/dbs/pdb70/pdb70 -e 0.1 -o ./03-search_cm/NZ_GG666849.1_2_251-330.out -oa3m ./03-search_cm/NZ_GG666849.1_2_251-330.a3m

 No Hit                             Prob E-value P-value  Score    SS Cols Query HMM  Template HMM
  1 2j27_A Triosephosphate isomera  27.5      24 0.00065   24.6   0.0   30   26-55     88-121 (250)
  2 4y96_A Triosephosphate isomera  26.6      25  0.0007   24.7   0.0   29   26-54     92-124 (255)
  3 4o4v_A Triosephosphate isomera  26.5      26  0.0007   24.6   0.0   30   26-55     87-120 (252)

I used parameters: split_search.py -e 0.1 -l 40
expected behavior: there are no match sequences, so the entire input sequence goes to non_match, because it's longer than 40 residues

Either I don't understand the problem, or I am not able to reproduce it properly. The following execution
(microProt) barnacle x86_64 ~/MicroProt/microprot/microprot/scripts>python split_search.py -o testme -e 0.1 -l 40 /projects/microprot/benchmarking/snakemake_test/03-search_cm/NZ_GG666849.1_2_251-330.out /projects/microprot/benchmarking/snakemake_test/02-split_pdb/2/NZ_GG666849.1_2_251-330.fasta
Leads to the creation of two files: testme.match which is empty and testme.non_match with the content:
>NZ_GG666849.1_2_251-330_1-80 # 798 # 2885 # -1 # ID=1_2;partial=00;start_type=TTG;rbs_motif=AGxAGG/AGGxGG;rbs_spacer=5-10bp;gc_cont=0.499
IGIQGDTYSEDEDYPELPRTANGRLSSYILVNHKEQVHVYNQIATKLGLQKESGEVVMLPSQFINRFSLRNEHGRGIPDQ

Can you elaborate on how you produced the unwanted behaviour and what exactly it is?

wow... ok, it seems that you got the correct behavior. You understand my problem correctly.
Let me try to reproduce my error once again

I have the feeling that - if you specify --subseq_fp - no files are produced

I double checked. No, those files get produced.

I messed up. Indeed,
cd /projects/microprot/benchmarking/snakemake_test
python /projects/microprot/microprot/scripts/split_search.py 03-search_cm/NZ_GG666849.1_2_251-330.out 02-split_pdb/2/NZ_GG666849.1_2_251-330.fasta -o 04-split_cm/x -e 0.1 -l 40

works just fine.
The reason why my example didn't work is that I just gave folder path (-o 04-split_cm/), not folder and out_root.

I was also a bit surprised, that no files where generated in directory -o root/04-split_cm, but there where files root/04-split_cm.match and root/04-split_cm.nonmatch.
Should we change the behaviour of our function, if even the developer get's confused?

probably a good idea! :)

I was also a bit surprised, that no files where generated in directory -o root/04-split_cm, but there where files root/04-split_cm.match and root/04-split_cm.nonmatch.
Should we change the behaviour of our function, if even the developer get's confused?

resolved by #44


Implemented SSL support

Seems good, but maybe you can add .ssl.gz as well as supported extension.

I will do that, I will fix some other things as well


stackdriver adapter memory usage optimization

Restrict buffer size to prevent excessive memory usage of stackdriver adapter. Right now sd adapter will buffer all timeseries and merge them before sending periodically, which consumes too much memory and does not work when mixer is under  load. This PR adds async merging limit the size of buffer. Test indicates the new logic consumes much less memory.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: bianpengyuan
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bianpengyuan: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
40203f8e98ef2436ce6db77ed610484cb67114a5
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
40203f8e98ef2436ce6db77ed610484cb67114a5
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
40203f8e98ef2436ce6db77ed610484cb67114a5
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
40203f8e98ef2436ce6db77ed610484cb67114a5
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
40203f8e98ef2436ce6db77ed610484cb67114a5
link
/test istio-pilot-multicluster-e2e

prow/e2e_pilotv2_auth_sds.sh
40203f8e98ef2436ce6db77ed610484cb67114a5
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bianpengyuan, douglas-reid
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [douglas-reid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bianpengyuan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
40203f8e98ef2436ce6db77ed610484cb67114a5
link
/test istio-pilot-multicluster-e2e

prow/e2e_pilotv2_auth_sds.sh
40203f8e98ef2436ce6db77ed610484cb67114a5
link
/test istio_auth_sds_e2e

prow/istio-integ-k8s-tests.sh
692b9d1869bc8d64f40bf7537a7d74f7833c7c13
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
40203f8e98ef2436ce6db77ed610484cb67114a5
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
692b9d1869bc8d64f40bf7537a7d74f7833c7c13
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
692b9d1869bc8d64f40bf7537a7d74f7833c7c13
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

reinvoked circle ci workflow

@bianpengyuan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
692b9d1869bc8d64f40bf7537a7d74f7833c7c13
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
692b9d1869bc8d64f40bf7537a7d74f7833c7c13
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
692b9d1869bc8d64f40bf7537a7d74f7833c7c13
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@duderino Required tests all passed. Thanks!


Send heartrate, floor, and respiration rate values to Home Assistant

This change sends the heartrate, respiration rate, stepcount, and floors climbed/descended to Home Assistant as mobile app entities. There are a lot more sensors that could potentially be added.
I have only tested this on a Vivoactive 4s as that is the only device I own.
Let me know what you think and if there are any changes you would like to see.

Apologies, I've only just seen this. I'll take a look.

Again apologies, as a bug fix has upset the merge by causing a conflict. It should be as simple as a single condition involving
if (System.getDeviceSettings().phoneConnected) {
} else {
}

I'm compiling this for a private beta test on my Venu2 watch. I'll sort out that merge conflict and commit back to this branch if that's okay with you?
I am curious as to how you'll make use of these newly reported values on your Home Assistant.

All working on my Beta app.

@KPWhiver Are you happy with my small amendments?

Yes looks good


State Management API Overhaul

Fixes #375.

NOTE: I've applied the WIP tag because this is not 100% ready to merge yet as there are open discussion items that, depending on the answer, will change some of the tests that are failing right now. For example, the FileSystemStateStore doesn't handle some optimistic concurrency situations yet.

Ok, for now I've just bitten the bullet and implement optimistic concurrency for the FileSystemStateStore in a way that should work. I'd love any feedback on the approach taken. In a nutshell a specific metadata property called @@botFramework is added to the JSON blob that looks like this:
"@@botFramework": {
        "rawNamespace": "test/state/namespace/9dd5d3d2-7cfe-437a-bf83-80bead6b8815",
        "rawKey": "ac6bcb6f-b990-4248-96e6-14841f7ba6e2",
        "eTag": "e1cdc90444f249eda6909ce2ac49574b"
    }

The original raw[Namespace|Key] properties are there because the file system can't support all possible characters in its paths/file names and the eTag property is a naked guid value that is generated anew on every write.

@cleemullins I have addressed the issues we discussed today. It looks like I need to rebase in some changes from master regarding the middleware that were made and now conflict. I will take care of that ASAP. Please take another pass over and let me know if I have sufficiently addressed all of your feedback.

Rebased against latest from master again.

Just rebased against latest from master again.

After quite a bit of internal discussion, the more recent State changes are our current plan of record. This PR may come back in the future, but for now I'm going to close it out.


Advertising do not change client routes

##Reference page: https://docs.microsoft.com/en-us/azure/vpn-gateway/vpn-gateway-p2s-advertise-custom-routes

Hi!
I' already have my VPN Gateway configured. Using this documentation I was able to advertise my clients that I have a new IP to use with this Gateway.
However, all clients were restarted but they never got the new IP.
If I download again my VPN Gateway and reinstall, it works.
#Scenario:

I have a VPN Gateway configured to use the IP x.x.x.x (storage account on azure).
I downloaded this VPN Client
I installed it

I can access my storage normally.
Now, I will advertise to add other Azure Resource (other storage account with ip y.y.y.y)

I executed the command line:
Set-AzVirtualNetworkGateway -VirtualNetworkGateway $gw -CustomRoute x.x.x.x/xx , y.y.y.y/yy
My VPN client was restarted

I'm NOT be able to access the storage account y.y.y.y
If I download againt my VPN client and reinstall it, it will work.
Can I advertise my clients without to reinstall them?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4f9877ab-87ad-9743-e992-216dfa16c344
Version Independent ID: 03649d3f-3712-8228-0af3-4bd842be5c7a
Content: Azure VPN Gateway: Advertise custom routes for P2S VPN clients
Content Source: articles/vpn-gateway/vpn-gateway-p2s-advertise-custom-routes.md
Service: vpn-gateway
GitHub Login: @cherylmc
Microsoft Alias: cherylmc

@lcarli This is a limit of P2S VPN Gateways. All configuration is taken when you download the VPN client (routes, address space, DNS, ect) and is not updated unless you re-download the VPN / client.
If you would like us to add this functionality in the future, please leave your feedback at azure networking's feedback.azure.com page.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


One vs many interpreters

Write that every document has its own kernel and therefore differs from traditional SuperCollider.
Maybe provide a way to share the kernel?

Implemented in 40ece566e04f62f7e830a71b88a4bde0d758693d


EDID Policies

We may need to consider certain scenarios that involve mismatched capabilities in multicast. This is a cut and paste of a work-in-progress document that I've been working on internally. I've decided to include the entire document (except the part that is discussed in Issue #32). The section that is not background material and is relevant to policy starts with Handling Native Modes in Multicast.
EDID Policy Notes for Default Behavior
EDID, Hot Plug Detect (HPD), and InfoFrames (in HDMI at least) are the primary mechanisms that baseband devices and monitors use to establish an optimal and compatible video flow upon connection. These methods are also used to change video modes, should the device request it, e.g. user changes video modes or the device requires it due to content change or an application request.
IPMX operates on IP networks with uni and multicast flows. This introduces many scenarios that were not contemplated when VESA was designing EDID. Therefore, we must:

Define some terms to be used
Review how HPD, InfoFrames, and EDID work together in baseband applications.
Determine how to best emulate the baseband connection experience
Consider the additional scenarios created by multicast IP connections, including conflicting monitor types dropping in and out, and what behavior should be expected by default.
Highlight additional requirements owing to IP network considerations, user/application customization, and related connection traffic such as HDCP.
Briefly discuss issues related to multiple controllers accessing the system.

Terms
IPMX Source: A device that supports IPMX as a sender. This could be a source device (streaming box, DVD, computer) or an IPMX Gateway between baseband and IPMX.
IPMX Sink: A device that supports IPMX receiving. This could be a monitor, capture device, or an IPMX Gateway between Baseband Sinks and an IPMX system.
Baseband Source: A source that supports HDMI, DisplayPort, DVI, or another baseband signal. In this document, this is the device that is typically plugged into an IPMX Gateway.
Baseband Sink: A monitor or other receiving device that supports HDMI, DisplayPort, DVI, or another baseband signal. In this document, this is the device that is typically plugged into an IPMX gateway.
IPMX Gateway: A device that receives or sends IPMX flows and supports IPMX APIs to represent and support Baseband Sources and Sinks. Specifically, this includes the MPA1000 and ME10.
Baseband Connections (EDID, Normally)
Normally, a baseband connection is one output device sending to one display/sink device and EDID is designed for this scenario:

A cable is plugged into the device and HPD is asserted.
After .2 seconds (?), the EDID binary payload is being requested by the source.
The source reads the EDID file and picks any resolution that is reported to be supported by that file or does not connect.
If a match is made, video and/or audio data starts. This includes InfoFrames, which advertise the format of the video.
The monitor sets its timing to support the video and audio.

Note that the source is the sole decider for what the video should be. The monitor cannot request a specific setting or change what it reports, apart from special circumstances regarding latency, which involves CEC control.
Preferred Timing and the Nominal Case
EDID structures define the first mode listed as preferred or native. In addition, Video Data Blocks may contain one or more Short Video Descriptors (SVDs), which may mark the resolution as native.
Whether it is the first mode or listed as native, each communicates that these video modes will be produced with the best quality on the given display device. Typically, it's expected that the connected source will use one of these modes unless it cannot support it, or the user overrides that choice by selecting a different, yet still compatible mode.
IPMX Connections
For AV over IP generally, and IPMX in particular, there are additional use cases and issues to consider. Most notably, it is more often the case that there is a one-to-many relationship between source and receivers in the IP world. This was always possible with EDID, especially with HDMI distribution amplifiers (DA), but it was never handled well because EDID was not designed to handle DAs and switchers. With IPMX, we intend to give the user more deterministic access and control over how the video profile is selected in scenarios with multiple monitors/sink devices.
Furthermore, since EDID was designed for baseband connections, it does not include all of the relevant information relevant to making a connection. There may be constraints related to the network capabilities of each device, or potentially network bandwidth available between devices. Also, supported codecs (or no codec at all), supported profile codecs, and other similar data are relevant to the connection in the same way as EDID data.
Finally, HDCP support is not represented in EDID but is relevant in the same way as EDID is and should also be included in the information communicated to the sender and receiver.
For IPMX, we need to include all of the relevant data to make a connection, including EDID, and establish reasonable default behaviors so that users of IPMX systems can come to expect a certain behavior in their devices.
What is that behavior?
In 1:1 connections
A connection between a monitor and a source should result in the same resolution being selected, regardless of whether the connection is DisplayPort, HDMI, or IPMX, accepting that each transport is capable of the same set of timing and profiles.

Note: Here and in the following sections, the exact procedure for what happens is grossly oversimplified. The actual process is documented in the AMWA NMOS EDID Connection Management GitHub repository.

The user connects the Source and Display directly, or through IPMX Gateway devices if the Source Device and/or Display Device do not support IPMX.  Hereinafter IPMX Source or IPMX Sink
The relevant data from the source is collected and received by an API endpoint on the IPMX Source.
Source makes a selection and starts the video, producing InfoFrames.
InfoFrames are used to create the correct stream profile and the NMOS components are updated (Flow, Sender, ...) (the exact API process is part of the AMWA NMOS EDID Activity group.)
The connection is made or error.

In One to Many connections
When more than one EDID is present, only the modes supported by all EDID representations (XOR) shall be used to determine the set of legal modes.
When no legal modes are possible, an error is returned.

The user connects Source and Displays (more than one).
The relevant data from all sources are collected, XOR’d to a set that supports all IPMX Sinks (Native modes are handled in the way described in the next section)
The IPMX Source receives a constrained set of capabilities.
Source creates InfoFrames and NMOS components are updated.
The connection is made or error.

Handling Native Modes in Multicast
Handling multiple EDID structures with different sets of native modes presents a challenge when multiple monitors of different makes and models are used. There are multiple reasonable approaches to handling some of these scenarios and it's assumed that others may have their own opinions. Some things to consider:
EDID has only one level native. It may be interpreted that the first mode listed is more native than the modes listed in SVDs, but the specification is not defined that way.
Should the best native mode be used, if it's supported by all but is native in only a minority?
Should the majority always win out? What if 20 monitors support 3840 by 2160 natively and one projector supports 4096 x2160 natively?
What if some modes are native to all and some are supported by all, but native to only some?
What if no modes are native to all?
What if no modes are supported by a majority of monitors? (all tied)
Proposed Rules
The following rules shall apply to modes that are supported by all connected monitors:

If all EDID structures support a mode as native, then that mode shall be listed as native.
If some modes are matched as native for all displays, then only those modes should be considered native. For modes that are native for only some displays, they should not be included in the list of native modes.
If no modes match as native for all displays, modes that are supported as native in the majority of monitors should be listed as native.
If there is only a tie, then the highest pixel count should be listed as native. If the modes don’t differ by pixel count, then the highest framerate should be listed as native. If framerate does not differ, then the highest bit-depth. If this is a tie, then the choice is undefined and any mode is acceptable as native.

Adding Monitors to an Existing Multicast Group
When adding monitors to an existing multicast group, there are scenarios that need consideration. Below is a list of scenarios and proposed default actions:

A monitor is added that natively supports the current Flow.
a. Add the monitor without resetting the current connection.
A monitor is added that does not support the current Flow.
a. Is there an alternate mode that is supported by all?
i. Yes. Reset the connection using the new aggregated EDID structure.
ii. No. Error and refuse to add the Monitor.
A monitor is added that supports the current connection, but not natively.
a. Is the current stream native to the aggregate EDID of the connected displays?
i. If yes, then would the new aggregate change what is native and would that change include a mode that is native in the new display?
1. Yes. Reset the connection.
2. No. Do not reset the connection.
ii. No. Add the monitor without resetting the connection.

Removing Monitors from an Existing Multicast Group
Similar issues arise when removing monitors from a multicast group. In each case, the monitor is removed, but whether or not the connection must be reset is answered:

A monitor is removed and the set of native modes does not change.
a. Do not reset the connection.
A monitor is removed and the set of native modes changes.
a. Does the current stream match a native mode for the remaining monitors?
i. If yes, then does the new aggregate EDID include the current stream in the native set?
1. Yes. Do not reset.
2. No. Reset.
ii. If no, then does the new aggregate EDID include the current stream in the native set?
1. Yes. Reset.
2. No. Do not reset.

Other Capabilities
Beyond the default behavior, the user may wish to force certain behavior. For example, a laptop and a monitor may otherwise negotiate a certain profile, but because a projector is calibrated in a particular way, the user may choose to force a certain timing or video mode using a controller or the gateway's web interface. Also, the above logic might not be ideal in certain scenarios and the user's preferences might be difficult to achieve by manipulating the source.
Depending on the policy established by the IPMX Controller and the connection and disconnection (HPD) events it receives, the controller may do any of the following:

reject certain connections for not matching the current stream.
arbitrarily constrain the video profile to a single setting, based on a user's input.
any other policy that an application developer might choose to support.

Because it's impossible to guess what may be the "correct" policy, it should be possible to replace the default policy with customized versions and to override policy by specifying profiles or new constraints within the web interface.

Note that the numbering above is kind of confusing in that the deeper levels are not being read correctly

@andrewstarks What's the current status of this issue (including taking into account recent terminology changes)?

I went through this text and that's my opinion.
Such baseband scenarios as changing video mode on a source, plugging/unplugging a monitor and video mode negotiation between a source and a monitor are covered in the current text of IS-11.
The Terms are obsolete. All these concepts live under other names now.
Native modes are covered in BCP-005-01. An NMOS Controller works with Constraint Sets and their preferences which is not the same but lets the NMOS Controller to apply Proposed Rules to native modes of a monitor and other modes preferred by a Receiver for some reason.
The bottom line of Handling Native Modes in Multicast as I understood it is that the user says the last word. I believe https://specs.amwa.tv/is-11/branches/v1.0-dev/docs/Behaviour_-_Client_Side.html states the same.
So I think it can be closed but I surely would like to hear what @andrewstarks thinks about it.


Activate Feram for all repos

@drlippman @pkra @jipsen
Hi,
I just wanted to ask if it's OK with you if I activate Feram for asciimath's repositories. It's a tool which automatically finds bugs and proposes patches for them.
(Disclaimer: I'm cofounder of the company =P).
What do you think?

So long as it just proposes patches and doesn't commit them automatically, seems fine with me :)

Ok cool :grin:, but I just realized I don't have the rights to activate it.
Can someone of you do it? It's just 2 clicks: https://github.com/apps/feram

Anyone? 😅

I don't seem to have the rights to active it either.

@jipsen I guess you're the only who has the rights to activate then 😅

Ok, I think it should now be activated on asciimath

👍 Now whenever someone opens a pull request, Feram will check the code :grin:
We will also soon release a version which checks every commit (so even if you just push into the master)

That looks pretty magical, nice job on this @adius

Thanks! 😁

Oh btw: We released the new version and now we check every commit.
Just look out for the red cross ❌


[Bug] The bot apparently isn't working

I added an rss feed, the bot reacted with a verified emoji, but it didn't send any messages afterwards
It would be good to include it in the status part:
https://status.t2bot.io/

For help and support on the bot, please visit [#help:t2bot.io](https://matrix.to/#/#help:t2bot.io] on Matrix.


Compile with code coverage enabled, collect coverage result and upload result to codecov.

@martinpitt, could you please add another test in cockpit CI to run test on chrome with code coverage enabled? Thanks.
The test needs two environment variables in cockpit CI container.

CODECOV=true
CODECOV_TOKEN=
Could you please add two environment variables? Thanks.

Passing arbitrary env variables (or more generally, run them with different scenarios) is not currently possible, so we'll need to extend Cockpit's tests-invoke a bit to generalize $TEST_OS. I'll look into it ASAP (but will take a few days, I'm travelling a lot).

With that you also don't need a $CODECOV switch -- just enable coverage if ~/.config/codecov-token exists.

https://github.com/cockpit-project/cockpituous/pull/210 implements the ~/.config/codecov-token secrets symlink in our tests containers. @henrywang , can you please gpg-send me the token, or put it onto some red hat server where I can get it?

@martinpitt, shared token with you by google doc.

With that you also don't need a $CODECOV switch -- just enable coverage if ~/.config/codecov-token exists.

@martinpitt, the cockpit ci will add ~/.config/codecov automatically on chrome scenario? Thanks.

@martinpitt, updated according to your comments. I'll fix failed case on chrome in another PR. Thanks.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6505c78). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #366   +/-   ##
=========================================
  Coverage          ?   34.83%
=========================================
  Files             ?       49
  Lines             ?     1840
  Branches          ?      327
=========================================
  Hits              ?      641
  Misses            ?     1199
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6505c78...e74bdff. Read the comment docs.


Put cheat sheet with common commands on marvin website

On https://github.com/apps/marvin-mk2 it would be great if there was a short list with the typical commands

Great idea! I totally forgot that I could put text there. That might also somewhat solve a problem I've been thinking about: When phasing out the opt-in model and incorporating the whole backlog, posting the greeting to every old PR would create a huge flood of spam in people's inboxes, presumably making people mad. At the same time not explaining the usage would be confusing to the PR authors. This could be a nice middle ground.

I've written a few words. What do you think?

Great! If you want, I have a few nitpicks and structuring ideas:
Marvin-Mk2 - Making sure your Pull Request gets a review
This is a bot with two primary purposes:

managing and labeling a pull-requests status, based upon who needs to take action (the author / a reviewer) and who is needed to proceed
triaging pull requests and automatically assigning reviewers where possible.

As a PR author
Normally, you shouldn't need to directly interact with the bot. It will automatically add the correct labels based on your actions.
As a reviewer
Quite a few status changes are also automatic. You may want to manually set the status to needs_merger when you have finished your review and would merge this yourself if you could (but do not have the privilege to do so). Try to anticipate the "merger"s feedback as well as possible, ideally no additional review should be necessary. Do so on a best-effort basis -- this is a learning process for all parties.
For more details, see the usage document. If you want to use marvin on your PRs, you currently have to explicitly opt-in since it is still experimental:
/marvin opt-in
/status needs_reviewer
Only the PR author can opt-in.

Good call on cleanly separating the author/reviewer instructions. I've updated the description, please review.

Closing this, feel free to reopen if you have more feedback.

Sorry, I forgot to tell you that the version now looks great to me and is helpful.


PTRACE_SETREGS lets a process raise a tracee's IOPL for privilege escalation

https://github.com/klange/toaruos/blob/master/kernel/sys/ptrace.c#L289
PTRACE_SETREGS copies the value of eflags from userspace with no checks. This lets the tracer change the tracee's IOPL in the the tracee's EFLAGS. When IOPL=3 the tracee can directly talk to the hardware with port I/O from userspace.

It also allows setting cs register to arbitrary value, which may lead to execution of tracee's code in kernel mode.

This one... doesn't surprise me. Based on when PTRACE_SETREGS was implemented, I think was wholly committed to developing on and for aarch64, so I had completely forgotten the userspace register set on x86-64 included such sensitive things - and, on top of that, I was only trying to support intercepting system calls (eg. setting the syscall register to something else): https://github.com/klange/toaruos/commit/aa8d79c81adc522c761e1c76e7207d27445d8981
Good opportunity to get rid of that #ifdef and push this over to an arch_ function that can do the appropriate sanitation and copying of additional registers.
The rflags filtering has already been floating around in return-from-signal-handler; hopefully that does the right thing: https://github.com/klange/toaruos/blob/e03e2ff189c3d424701a2dd10dc7ffbd55a3f346/kernel/arch/x86_64/user.c#L99


Provide the Channel with the Response

Use Case
In addition to executing an HTTP request, I also need to send additional data to the server after the initial request and periodically after that.
I don't believe this is currently possible but would be required for my use case.
Potential Solution
One solution could be to provide the Connection as a property of the Response.
This is similar to a solution I used for OkHttp (an HTTP client for Android):
// Inside an Interceptor
Runnable nmeaProvider = new NMEAProvider(ntripReq, Objects.requireNonNull(chain.connection()).socket());

Willing to Contribute
This is my top priority. If my solution is approved, I would be happy to provide a pull request implementing it right away along with any required tests.

With the new async/await API you can provide an AsyncSequence to be used as the body of the request, using this constructor: https://github.com/swift-server/async-http-client/blob/7f998f5118de081fa2034833ce95bb5925dc6459/Sources/AsyncHTTPClient/AsyncAwait/HTTPClientRequest.swift#L291
This should allow you to publish data incrementally as needed. Note that it will still be HTTP-framed, so it does not allow arbitrary data sending.

Unfortunately AsyncSequence is unavailable (need to support iOS 12 minimum). If you know of any other way, please let me know. Glad to know it will be possible, thank you for your help.

Is the new data you have to send part of the HTTP body of your request?

Is the new data you have to send part of the HTTP body of your request?

Yes. The data needs to be sent after the HTTP head (as soon as possible), then roughly every 10~ seconds. Here is an example:
$GPGGA,111123.0,1220.70000000,N,06753.40600000,E,4,10,1.0,0.000,M,0.0,M,,*6B<CR><LF>

Interesting. So you can use the existing StreamWriter abstraction for this. If you set the Request body to .stream, that callback will be invoked with a StreamWriter.  You can stream body parts into this StreamWriter (and thus into the request) by calling StreamWriter.write, which will return you a Future that completes when the write is flushed. From the callback that gives you the StreamWriter, you return a Future that signals that you're finished sending the body (you need to complete the associated promise when you're done).
Importantly, you can safely escape the StreamWriter and save it off somewhere. This will let you achieve your goal, I think.

You can see an example of using this here:
https://github.com/swift-server/async-http-client/blob/7f998f5118de081fa2034833ce95bb5925dc6459/Tests/AsyncHTTPClientTests/HTTPClientTests.swift#L2046-L2113

Completely missed the stream option. Appears to be working


Us042 ready for review state

Work to implement READY_FOR_REVIEW state of collection exercise.  Checks when:

mandatory collection exercise events have been loaded
at least one collection instrument has been loaded
at least one sample file has been loaded

 US028: Set and View 'Ready for Live' State of a CE [Large]

 US042: Create and View 'Ready for Review' State of a CE [M]

 US041: Create and View 'Scheduled' State of a CE [M]

All state transitions work fine from created to ready for live 👍

 US040: Create and View 'Created' State of a CE [M]


Add "keypress = bool" to mario.lua

It would be cool if something like "self.leftkeypress = true" be added to mario.lua

Like that,if doesn't exists
		self.leftkeypress = true
	else
		self.leftkeypress = false
	end
	if upkey(self.playernumber) and self.controlsenabled then
		self.upkeypress = true
	else
		self.upkeypress = false
	end
	if downkey(self.playernumber) and self.controlsenabled then
		self.downkeypress = true
	else
		self.downkeypress = false
	end
	if rightkey(self.playernumber) and self.controlsenabled then
		self.rightkeypress = true
	else
		self.rightkeypress = false
	end
	if usekey(self.playernumber) and self.controlsenabled then
		self.usekeypress = true
	else
		self.usekeypress = false
	end
	if jumpkey(self.playernumber) and self.controlsenabled then
		self.jumpkeypress = true
	else
		self.jumpkeypress = false
	end
	if runkey(self.playernumber) and self.controlsenabled then
		self.runkeypress = true
	else
		self.runkeypress = false
	end
	if reloadkey(self.playernumber) and self.controlsenabled then
		self.reloadkeypress = true
	else
		self.reloadkeypress = false
	end```

ahaha, no. There are so many other ways to read a players input like idk... the animation system? It literally has triggers for pressing, holding and undressing keys.

You can already do this if you make a button controller, instead of suggesting a feature be added that like 3 people can use correctly


Template syntax error while creating a new project based on cookiecutter

I have just tried to setup project using cookiecutter and have stumbled upon this issue.
  File "./LICENSE", line 3, in template
jinja2.exceptions.TemplateSyntaxError: Encountered unknown tag 'now'. Jinja was looking for the following tags: 'elif' or 'else' or 'endif'. The innermost block that needs to be closed is 'if'.
  File "./LICENSE", line 3
    Copyright (c) {% now 'utc', '%Y' %}, {{ cookiecutter.author_name }}

@Rajesh-Yogeshwar please, make sure with you has a latest version of cookiecutter:
pip install "cookiecutter>=1.6" --upgrade

If this works, please close this issue.
Additionally, this error occurs because you do not have the correct version of cookiecutter and jinja2-time
https://github.com/audreyr/cookiecutter/blob/1.6.0/setup.py#L32

I'm having the same issue with 1.6.0 and jinja-time 0.2.0.


Fill ITensor with zeros if empty after contracting with ProjTTN.

This PR ensures that the result of a ProjTTN to ITensor contraction always results in an ITensor with the same flux and the allowed blocks densely filled.
Lack of this edit leads to instability of KrylovKit.exponentiate when used on product states of fermionic systems with regions where the action of the projected Hamiltonian on the state vanishes. There may be more appropriate fixes to this at the ITensors level, if this PR is not compatible with planned changes to the ITensors storage.

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (56fcb93) 72.90% compared to head (1ef03c5) 72.87%.

Files
Patch %
Lines

src/treetensornetworks/projttns/abstractprojttn.jl
33.33%
2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
- Coverage   72.90%   72.87%   -0.03%
==========================================
  Files          71       71
  Lines        4097     4100       +3
==========================================
+ Hits         2987     2988       +1
- Misses       1110     1112       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

This also only works for ProjTTN of an operator with vanishing flux. The cleaner way would be to compute the flux of the environment in order to compute the flux of the tensor resulting from the contraction, allocate the resulting tensor filled with zeros, and in-place add the actual result of the contraction into it (all inside the if clause).

@b-kloss could you explain this a bit more? Under what situation does isempty(Hv) return true? I think that would help to determine a fix to use.

This happens in the very first call to PH(phi) in from KrylovKit.exponentiate when the action of the projected Hamiltonian on the state vanishes. E.g. in a region of a product state that's inert under the local Hamiltonian, let's say a single domain wall initial condition for a tight-binding model in 1D on an MPS, more than two sites away from the domain-wall.
Hv = ITensor ord=2
Dim 1: (dim=1|id=867|"19,20")' <Out>
 1: QN("Nf",10,-1) => 1
Dim 2: (dim=2|id=441|"Fermion,Site,n=20")' <Out>
 1: QN("Nf",0,-1) => 1
 2: QN("Nf",1,-1) => 1
NDTensors.BlockSparse{Float64, Vector{Float64}, 2}
 1×2

storage(Hv) = Float64[]```

Superseded by #1318, so I'll close this.


tests: Add combined coverage handling

This slows invoked subprocesses by ~30% (or less, if they do heavy computation) which is hopefully acceptable cost. We already did gather coverage on the main pytest process.
I wonder if this breaks codecov or if it is somehow broken anyway - https://app.codecov.io/gh/Aiven-Open/astacus/pull/165 shows this as in 'processing' state for half an hour now. Perhaps we're not classified as open source plan and are hitting some limit? Or different coverage invocation makes it unable to find the parent commit (it has coverage % which is higher than what is in main).

Do you plan to fix the 'processing' state first or the PR is already useful in the current state ?
(I tried to check https://app.codecov.io/gh/Aiven-Open/astacus/pull/165 but it says "Missing base commit" and "Coverage data is unknown", not sure if it's because the recent fixes to the base branch were not yet in place or something else.)

TBH I don't really know what is wrong - I think the options are either merge it and hope (and revert if it breaks the coverage in general) or not do this at all.

TBH I don't really know what is wrong - I think the options are either merge it and hope (and revert if it breaks the coverage in general) or not do this at all.

Ok, that's not too hard to revert in case of problems.

Codecov Report
Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.63%. Comparing base (36214f4) to head (327ad09).
Report is 171 commits behind head on main.

Files with missing lines
Patch %
Lines

...gration/coordinator/plugins/clickhouse/conftest.py
50.00%
1 Missing :warning:

tests/utils.py
83.33%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
+ Coverage   87.31%   89.63%   +2.32%
==========================================
  Files         141      141
  Lines       10035    10044       +9
==========================================
+ Hits         8762     9003     +241
+ Misses       1273     1041     -232

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add index.html

[ ] # 2 #****Well welcome to the bark at the Moon site.
It's the best around so far !!#

#2 add index 2

[ ] Well to do ****
Welcome to the Bark at the Moon
[ ] > Website****


Publish on cdnjs

The title says it all!

in progress. Better late than never :-)

https://github.com/cdnjs/cdnjs/pull/4587

Done


[MM-29496, MM-29497] Update changeCSS() call to CSS variable for away…

Summary
ApplyTheme Campaign: This PR completes the merge of the theme.awayIndicator commits from the campaign branch.
Dev approval for the changes was completed on the original PR(s), so we are just looking for rubber stamp approvals by dev's to satisfy merge requirements.
As QA was skipped PR merges into campaign branches, this PR will need proper QA before merging. See below for details on what to QA for this PR.
Ticket Link

https://github.com/mattermost/mattermost-server/issues/15883
https://github.com/mattermost/mattermost-server/issues/15884

Related Pull Requests

https://github.com/mattermost/mattermost-webapp/pull/6721

@jgilliam17, to QA this PR, just verify that all occurrences of the user away indicator icon's have the correct colour applied per theme.

@jgilliam17, to QA this PR, just verify that all occurrences of the user away indicator icon's have the correct colour applied per theme.


Add some simple comparison formulas

Is your feature request related to a problem? Please describe.
Having the ability to compare two string fields on the screen to then make an action would be nice if those comparisons where a function that return true/false.   Right now I have to code each comparison, example:
    selectedValue = $("h3:contains('Request Phase')").closest('tr').find('select').val();
    requestOpen = $("h3:contains('RequestOpen')").closest('tr').find('select').val();
    if (((selectedValue == 'Approved') || (selectedValue == 'Denied') || (selectedValue == 'Canceled'))) {
        Lozzi.Fields.disable("Request Phase");

Or checking to see of a downdown has changed:
    //on change of dropdown of Is this Critical we will call this
    $("h3:contains('Is this Critical')").closest('tr').find('select').change(function () {
        showHideRows();
    });

Describe the solution you'd like
Well, this is a lot harder.  In general, one compares two values and based on the results an action needs to happen. some examples might be:

If a value is Yes, then display a field, else no.
if a value changes and the new value is xx, then display another field (or make it mandatory).  Yeah, that's another feature.
if two values are the same or different
Comparing dates, or numbers might be helpful.  Not certain

Describe alternatives you've considered
Code it as I had shown above.
Additional context

This is a good idea, though might be very large to implement. I'll think it through some. In the meantime, you should be able to use var theCell = Lozzi.Fields.getCell(fieldName) to get the cell, then something like theCell.find("input,select,textarea,img") to get the control with the value in it.


Homebrew formula

This is a really useful tool for getting unwieldy CSVs into Postgres for quick analysis.
Have you considered creating a Homebrew formula for it, for easy installation on OSX?

Have you considered creating a Homebrew formula for it, for easy installation on OSX?

Considered it but I think I cannot let homebrew download binaries (so you require the Go ecosystem on your machine to install pgfutter).
That's why I haven't done it yet - I think downloading a binary is perhaps easier to set up.
But would be very happy if you contribute a formula!!

Used pgfutter this morning and it was a real life-saver, so I created my first homebrew formula: https://gist.github.com/joallard/11a97b2ee3eed44f1a93690fecdfe92a, but it's still pretty drafty. We can probably incorporate this into this repo or homebrew/core at some point.

Used pgfutter this morning and it was a real life-saver, so I created my first homebrew formula: https://gist.github.com/joallard/11a97b2ee3eed44f1a93690fecdfe92a, but it's still pretty drafty. We can probably incorporate this into this repo or homebrew/core at some point.

Thanks for the draft @joallard! ❤
Makes sense to have it as Go program it can be in homebrew!
Would be very thankful if you push it to homebrew. They have pretty good documentation how to do it.
You used pgfutter for CSV or JSON imports?

I think the brew repo has some more criteria to have it in, I'm waiting for some people who test the script, and then we can probably get their input.
I used it to import a CSV with the schema, it was pretty easy.

I haven't been using this tool lately, less DB tasks in my contemporary role. Closing this issue for the time being, as it's stale.


Logging settings should not be changed on import

netifaces2 calls logging.basicConfig on import here. That will interfere with log setup by the application. Note that logging.basicConfig does nothing the second time it is called, so if an application uses logging.basicConfig for its own logging setup and switches from netifaces to netifaces2, it will silently break the logging setup.

You are correct. Fixing

Fixed in >=0.0.19.
Thanks for reporting!


testBox failure on i386

System Slackware 14.0, 32 bit, gcc 4.7.1
Compiles but "make check" fails into the testing of ImathTest. I'm trying to put together a full clean build/install of OpenEXR, CTL (1.5 rc) to utilize ultimately ctlrender command for some testing. I've removed prior builds and removed openexr 1.7.0 package which comes with Slackware by default.
lt-ImathTest: testBox.cpp:253: void {anonymous}::testExtendByPoint(const char*) [with T = Imath_2_0::Vec2]: Assertion `b.min == p && b.max == p' failed.
/bin/sh: line 5:  8024 Aborted                 ${dir}$tst
FAIL: ImathTest
#1 of 1 test failed
make[2]: *** [check-TESTS] Error 1
make[2]: Leaving directory /home/qbit/Documents/OpenEXR/openexr-2.0.1/IlmBase/ImathTest' make[1]: *** [check-am] Error 2 make[1]: Leaving directory/home/qbit/Documents/OpenEXR/openexr-2.0.1/IlmBase/ImathTest'
make: *** [check-recursive] Error 1
qbit@0xFFFB:~/Documents/OpenEXR/openexr-2.0.1/IlmBase$
Thanks,
Bill Mandel

Looking into the OpenEXR issue backlog.  Is this still an issue, or ok to close?

Closing the issue for now, feel free to re-open or file a new issue if you need further help.


Confusion about UseInstance and RegisterInstance documentation

Hey!
Documentation here (https://bitbucket.org/dadhi/dryioc/wiki/RegisterResolve#markdown-header-useinstance) says this

Note: The DryIoc version prior 3.0 also contains RegisterInstance method. The method is obsolete and its usages should be replaced with UseInstance.

So UseInstance is preferred way? But then I noticed in the source code all UseInstance methods are marked as Obsolete
https://github.com/dadhi/DryIoc/blob/master/src/DryIoc/Container.cs#L5571-L5629
I'm using latest version of DryIoc should I use useInstance or registerInstance ?

Use RegisterInstance, I will update the docs on BB. But the up-to-date version of docs is here: https://github.com/dadhi/DryIoc/blob/master/docs/DryIoc.Docs/RegisterResolve.md#registerinstance

Seems like there are some useInstace -usages in official DryIoc packages.
https://github.com/dadhi/DryIoc/blob/9f111e8cc9a65076353e9360a84e553efb661f3d/src/DryIoc.Microsoft.DependencyInjection/DryIocAdapter.cs#L87
https://github.com/dadhi/DryIoc/blob/be545dbd08bd9f750abac3f47225c91d08089bab/src/DryIocZero.WebApi/DryIocWebApi.cs#L71