[Feature Suggestion] Queue System

I have no experience with gradio otherwise i would even attempt it myself. I plan to even learn from it haha
My suggestion is to add a queue system to the voice generation. Instead of clicking generate, you would basically click add to queue. Process queue would then take care of it. This would help with line splitting as well. In this specific case i am talkign about tortoise. As i am getting way more stable results from that one
https://www.reddit.com/r/StableDiffusion/comments/zq0wl9/i_made_a_queue_system_for_automatic1111s_stable/
https://github.com/Kryptortio/SDAtom-WebUi-us
This is an example on how i envision it

Thanks for letting me know about tortoise, I assumed it was unused. As for
the queue - before that, let's speed up tortoise at least a little. I will
check if I can cache the model.
Meanwhile, there is a way to queue within gradio, although I'm not sure it
will work as well (since it might try to do it in parallel, resulting in a
mess): open multiple tabs, and generate in each tab.
There's a queue size (in the code, I'll expose the setting), if I set it to
1, then everything will be run in a single queue.
I'll check if the links can help improve this.
On Mon, Jun 19, 2023, 12:05 PM Sven Elmendorp @.***>
wrote:

I have no experience with gradio otherwise i would even attempt it myself.
I plan to even learn from it haha
My suggestion is to add a queue system to the voice generation. Instead of
clicking generate, you would basically click add to queue. Process queue
would then take care of it. This would help with line splitting as well. In
this specific case i am talkign about tortoise. As i am getting way more
stable results from that one
https://www.reddit.com/r/StableDiffusion/comments/zq0wl9/i_made_a_queue_system_for_automatic1111s_stable/
https://github.com/Kryptortio/SDAtom-WebUi-us
This is an example on how i envision it
—
Reply to this email directly, view it on GitHub
https://github.com/rsxdalv/tts-generation-webui/issues/44, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABTRXI2ES5QED5KNFGD2Y7TXMAI6LANCNFSM6AAAAAAZLUBO5Q
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Personally i dont care much about the speed. If i put a 100 entry queue in, its gonna run in the background anyway so im good with that. I always run on highest quality and CVVP amount maxed (I have no clue what it is. but it makes it sound way better than 0 or 0.5). The links is just to visually understand it. i believe the exention itself is just a JS code that interacts with the webclient. (Which i would also be fine with ofcourse haha). What i would like to add though is maybe some adjustment on the filename/output if the queue is used. just for organisation

Wait just a question since you mentioned it before - what's the use case?

In that case a "split by lines" would be a good match and follow the Bark
UI.
On Mon, Jun 19, 2023, 12:16 PM Sven Elmendorp @.***>
wrote:

Personally i dont care much about the speed. If i put a 100 entry queue
in, its gonna run in the background anyway so im good with that. I always
run on highest quality and CVVP amount maxed (I have no clue what it is.
but it makes it sound way better than 0 or 0.5). The links is just to
visually understand it. i believe the exention itself is just a JS code
that interacts with the webclient. (Which i would also be fine with
ofcourse haha). What i would like to add though is maybe some adjustment on
the filename/output if the queue is used. just for organisation
—
Reply to this email directly, view it on GitHub
https://github.com/rsxdalv/tts-generation-webui/issues/44#issuecomment-1596818756,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABTRXI2OVEPW55HYSWRCE2TXMAKHLANCNFSM6AAAAAAZLUBO5Q
.
You are receiving this because you commented.Message ID:
@.***>

If you could implement split by lines in tortoise that would also be nice! however, I wanted to have multiple generations by line. (This is not a hard requirement for me though).
So line one would be generated 3 times
line two would be generated 3 times.. etc
I dont believe thats possible now with the split by lines functionality. Also adjusting parameters per line:
line 1 - param 1 3 times
line 1 - param 2 3 times
line 2 - param 1 3 times
etc..
Again, this is not a hard requirement but a nice to have. i would definitely already be satisfied by a split by lines haha

thats nice! ill gladly mess around a bit more with that. in that case the split by line for tortoise would be good 💪

I'd like to come up with a good queue system. For me, it's not about splitting text, it's about setting 50 different very specific UI widgets in the way that I tend to do, super tweaked settings, and then the hard part, take your output files and using them as new inputs, in different ways. The last part is what flummoxed me in Gradio. I could still do it by just ignoring the Gradio UI but in my head I'm drawing input output lines between widgets.
Anyway, if you want to put our heads together on a queue, I'm all for it. My current best working concept is to take the code that saves and loads user setting in the most recent (last month update) Automatic1111. They use this code to save defaults, but it's an example of scanning all possible Gradio UI widgets and either reading or changing them. So my idea is basically, hey, that's a general purpose queue. You scan every Gradio widget, archive it, then on demand load it later. However the files are still a problem. That code doesn't deal with it. I don't want to encoded huge audio files into a json. So I guess I have to make copies or something.

I'd like to come up with a good queue system. For me, it's not about splitting text, it's about setting 50 different very specific UI widgets in the way that I tend to do, super tweaked settings, and then the hard part, take your output files and using them as new inputs, in different ways. It's lots of 3 or 4 step recursive loops. I do these in Jupyter notebooks now and can't figure out how to make it to work in Gradio. The files part is what really flummoxed me in Gradio. I could still do it by just ignoring the Gradio UI but in my head I'm drawing input output lines between widgets.
Anyway, if you want to put our heads together on a queue, I'm all for it. My current best working concept is to take the code that saves and loads user setting in the most recent (last month update) Automatic1111. They use this code to save defaults, but it's an example of scanning all possible Gradio UI widgets and either reading or changing them. So my idea is basically, hey, that's a general purpose queue. You scan every Gradio widget, archive it, then on demand load it later. However the files are still a problem. That code doesn't deal with it. I don't want to encoded huge audio files into a json. So I guess I have to make copies or something.
Alternatively maybe that Automatic is good.

I would just stick to having a gradio function that sends the inputs to an Rx (or any) stream, where the "prediction" function subscribes to this stream.
It looks like this:

$subject = new Subject()

gr.Button("queued").click(fn=lambda **args: $subject.on_next(args))

$subject.subscribe(fn=predict)

Although the APIs are probably a bit different from this pseudo code.
https://rxpy.readthedocs.io/en/latest/reference_subject.html#reactivex.subject.Subject.on_next
If they figured out how to serialize gradio that's great, I've also worked on it, although I think I'll start ditching gradio soon enough, it's really a backend framework with a frontend representation.

Hey man so whats the status/ETA on this? Is there anything i can help with? It looks like you got it figured out haha

https://github.com/rsxdalv/tts-generation-webui/commit/6b29cb652e894c2cae26ee8cbcf5b494e8d77378 is this the commit? I have only been looking at the release page. But im willing to pull master and try it out

Yes, if you have the one-click installer than "update" otherwise git pull and pip install


How to scroll down on a webpage to make hidden elements appear

from user query at https://github.com/kelaberetiv/TagUI/issues/419#issuecomment-604367733

Hi Kensoh,
I have one page where the element only loads when we scroll down. What needs to be done in that case? I am initialising tagui in Python code and then calling t.fucntions()

Hi @soorejmg for RPA for Python, raise issues over there as it is a separate personal project - https://github.com/tebelorg/RPA-Python/issues
If the element does not show up, you can't use any of the step to automatically scroll to it and interact with it. There are 2 solutions.
First solution is use the dom() function to tell browser to scroll down, for eg below will scroll down by 1000 pixels. So you just scroll accordingly for the element you need.
r.dom('window.scrollBy(0, 1000)')

Second solution is use the visual automation method to use keyboard keys to scroll down on the browser. See examples on how to use visual automation method. To use this method, make sure to click somewhere on the browser first using visual automation to ensure that browser is the active window.
r.keyboard('[down][down][down][down][down]')
r.keyboard('[pagedown]')


Updated dotnet ef cli command

According to new changes fo dotnet ef cli new command should use to match new cli requirement, so changed from dotnet ef to dotnet-ef

@timonsk Can you provide some more details on why this is needed? Do you have a reference for what these "new changes" are?

@ajcvickers looks like this https://docs.microsoft.com/en-us/ef/core/cli/dotnet, where dotnet-ef is as a separate tool.

@timonsk The underlying binary is dotnet-ef, but once the command is installed, either globally or as a project tool, then it is accessed through the dotnet runtime with dotnet ef. This is not something that has changed.

okay, closing the pr then. thanks!


Prepare a presentation

And decide on a presenter

Do we not present as a group?

We could. But 4 minutes is not very long, and every team last year had at most two presenters

OK. I nominate myself 'cause I feel comfortable ranting about the image matching. I would definitely want someone else to talk about the communications or client stuff though.


Add tabKey to prevent child mount/unmount on label change

fix https://github.com/skv-headless/react-native-scrollable-tab-view/issues/148
example code that is broken, it should log only mounted once, not when label change
import React from 'react';
import {
    View,
    Text,
} from 'react-native';
import ScrollableTabView from 'react-native-scrollable-tab-view';

class Page extends React.Component {
    componentDidMount() {
        console.log('mounted');
    }
    render() {
        return (<View>
            <Text> Test </Text>
        </View>);
    }
}

export default
class App extends React.Component {
    constructor(props) {
        super(props);
        this.state = {
            i: 0,
        };
    }
    componentDidMount() {
        setInterval(() => {
            this.setState({ i: this.state.i + 1 });
        }, 1000);
    }
    render() {
        const { i } = this.state;
        return (
          <ScrollableTabView>
            <Page tabLabel={`React (${i})`} />
            <Page tabLabel="Flow" />
            <Page tabLabel="Jest" />
          </ScrollableTabView>
        );
    }
}

Maybe key property would be better?

There is react warning when using key prop https://fb.me/react-special-props

please check this in master


Feature request: Return both summary & eval_results from Evaluation.evaluate

For this code:
https://github.com/wandb/weave/blob/3eea8df108274ff22e4a9a382c66cc1e54f7213d/weave/flow/eval.py#L493-L510
Only summary is returned. For our use-case, we also want to grab eval_results for downstream rendering and storage (to present user-friendly results to non-technical stakeholders; the Weave UI is information overload for those folks). Would this change make sense?
As a workaround, I can call get_eval_results and summarize separately, but lose eval tracking in Evaluations since only Evaluation.evaluate Calls are picked up.

Hi @TeoZosa, I can raise this to the team tomorrow.

@jwlee64 sounds good, thanks for the prompt reply 👍
FWIW for feedback, I'm working around the issue by vendoring the code with this change:
-   @weave.op()
+   @weave.op(postprocess_output=lambda output: output[0])
    async def evaluate(self, model: Union[Callable, Model]) -> dict:
        eval_results = await self.get_eval_results(model)
        summary = await self.summarize(eval_results)

        print("Evaluation summary", summary)

-        return summary
+        return summary, eval_results

Hi @TeoZosa, we are going to have someone tackle this in the next week or so, or at minimum document a better way to get the eval_results with the current api.

Got it. Thanks for the update @jwlee64, keep me posted! 🙏


Serializing Path

I'm trying to use Map<Path, Metadata> in my code because it's the File replacement. Unfortunately it uses sun.nio.fs.WindowsPath under the hood on Windows. I've tried to write a custom serializer, but it seems like to me I can only write a serializer when I name the concrete class. Neither AbstractPath or WindowsPath from the sun.nio.fs package are public so I can't name the class files when I go to call registerSerializer(), I can only use Path.class which doesn't work.
I also I thought that using true in the alsoForAllSubclasses would help, but it did not.
Am I missing something, or is it impossible to serialize a private concrete class?

registering for Interfaces is not supported, registering for whole class hierarchies is. You might try to register for private classes using Class.forName()

That worked like a charm. Here's the code I used. Thanks!
        fstConfiguration.registerSerializer(Class.forName("sun.nio.fs.WindowsPath"), new FSTBasicObjectSerializer() {
            @Override
            public void writeObject(FSTObjectOutput out, Object toWrite, FSTClazzInfo clzInfo, FSTClazzInfo.FSTFieldInfo referencedBy, int streamPosition) throws IOException {
                out.writeStringUTF(toWrite.toString());
            }

            @Override
            public Object instantiate(Class objectClass, FSTObjectInput fstObjectInput, FSTClazzInfo serializationInfo, FSTClazzInfo.FSTFieldInfo referencee, int streamPositioin) throws IOException, ClassNotFoundException, InstantiationException, IllegalAccessException {
                String stringPath = fstObjectInput.readStringUTF();
                return Paths.get(stringPath);
            }
        }, false);

reopend as FAQ


Add germplasm.available to know if a germplasm can be ordered in a genebank

When searching for list of germplasms, we should know if that plant material can be ordered in the genebank.
the easy approach would be to add an available field, but maybe not enough:
"germplasm":{"available": "restricted|public|dependingOnStock|..."
Maybe something more complete like :
"germplasm":{
   "distributors": [
        {
          "institute": {
            "logo": null,
            "acronym": "INRAE_UMR_ABCD",
            "address": "5 Chemin de ABCD, Paris, France",
            "webSite": "https://www.clermont.inrae.fr/umr1095",
            "organisation": "INRAE",
            "instituteCode": "FRA1234",
            "instituteName": "Cereal ABCD",
            "instituteType": "Public-sector research organization"
          },
          "accessionNumber": "6027",
          "distributionStatus": "Available with restrictions"
        }
      ],
}

@Nicolas971 @cmichotey

It could be interesting to have distributionStatus with a list of predefined values. Maybe even a distributionDescription since sometimes collection managers can only answer orders a specific time of the year or they have other kind of limitation.

I would not recommend adding too much to Germplasm, since it is used for more that just genebank plant material ordering. Pethaps a separate endpoint is required for this?

To avoid having redundant information between distributors and collection, could we just add the available status into the collections field ? And the other information about the distributors could be retrieved with the GET collection endpoint (issue #577 ) ?
Something like that :
{
[...],
  "result": {
    "data": [
      {
        "accessionNumber": "A0000003",
        [...]
        "collections": [
             {
                   "collectionDbId": "123",
                   "collectionName": "Tournesol",
                   "distributionStatus": "restricted|public|dependingOnStock|..."
              }
         ],
        [...]
      }
    ]
  }
}

@aliceboizet I am not very comfortable with that proposition. It could be sub optimal with the rare-basket use case. What do you think @Nicolas971 @cmichotey @raflo64
I would really stick to the availability as a property of the germplasm, not of the collection. Am I missing something ?

I would not recommend adding too much to Germplasm, since it is used for more that just genebank plant material ordering. Pethaps a separate endpoint is required for this?

A separate endpoint would be too complicated when displaying those information on genebank cards. Furthermore, those are optional information, so if they are not available they can simply be not implemented.

@aliceboizet I am not very comfortable with that proposition. It could be sub optimal with the rare-basket use case. What do you think @Nicolas971 @cmichotey @Raflo64 I would really stick to the availability as a property of the germplasm, not of the collection. Am I missing something ?

I think you misunderstood my proposition. It is really close to what you proposed but instead having a new field "distributors" with the availability status in it, I proposed to put the availability status into the "collections" field (in the germplasm endpoint response). This proposition is relevant only if you confirm that you need to have several collections on one germplasm (I sent an email about that), and so we need the availability status depending on the collection.

I would not put the availability into collection, because it is a status of the germplasm and not the whole collection.
Maybe just a typed availability property the main part of germplasm should suffice.

I would not put the availability into collection, because it is a status of the germplasm and not the whole collection. Maybe just a typed availability property the main part of germplasm should suffice.
Having the availability property in the main part of germplasm sounds good to me (because I think that a germplasm would belong to only one collection). But if there can be several collections for the germplasm (as Cyril requested in #570), how do you know to which collection the availability status applies ?

As far as I'm concerned, an accession can only have one availability status (whether it can be ordered via a genbank or not). Status is a property of the accession, not of a collection.
The notion of collection is another problem. What do we mean by collection?
If it is a physical collection, then it seems to me that an accession can belong to only one collection, and therefore have only one distribution status.
If it is a way of grouping accessions and therefore creating a list, then an accession can belong to several collections. However, it will still have only one distribution status, independent of the collection chosen.

This very much Genebank specific request. In a plant breeding database the 'available' property and any additional information about how to order Germplasm would always be false/not present. I would have a separate endpoint that can be used for getting information about ordering Germplasm, which does not need to be implemented in non-genebank databases that use Germplasm.


Problem with PhoneNumber  property in UpdateCurrentAsync api

PhoneNumber is empty and the API returns an error.
await GetApiClient<AccountClient>().UpdateCurrentAsync(ProfileModel);

@abdolian we are doing the same in UserController. Mention your branch.

@pournasserian 1401-review-auth-plugin-and-apply-new-input-components-changes

related to https://github.com/fluentcms/FluentCMS/issues/1504


Loading failed for local openapi json file

When I update my project from the old version "0.4.0" to the latest version "0.6.0", I can't start the project.
Below is a screenshot of the error.

screenshot

How to reproduce
I started from the template one
npx create-docusaurus-openapi docusaurus-openapi-example

Then update the package
yarn upgrade docusaurus-preset-openapi --latest

Also, add url for fixing url issue
yarn add url

Then, I start the project
cd docusaurus-openapi-example
yarn start

Check the above screenshot.
The following is my package.json

package.json
{
  "name": "docusaurus-openapi-example",
  "version": "0.0.0",
  "private": true,
  "dependencies": {
    "@docusaurus/core": "2.0.0-beta.21",
    "@mdx-js/react": "^1.6.21",
    "clsx": "^1.1.1",
    "docusaurus-preset-openapi": "0.6.0",
    "prism-react-renderer": "^1.2.1",
    "react": "^17.0.1",
    "react-dom": "^17.0.1",
    "url": "^0.11.0"
  },
  "scripts": {
    "docusaurus": "docusaurus",
    "start": "docusaurus start",
    "build": "docusaurus build",
    "swizzle": "docusaurus swizzle",
    "deploy": "docusaurus deploy",
    "clear": "docusaurus clear",
    "serve": "docusaurus serve",
    "write-translations": "docusaurus write-translations",
    "write-heading-ids": "docusaurus write-heading-ids"
  },
  "browserslist": {
    "production": [
      ">0.5%",
      "not dead",
      "not op_mini all"
    ],
    "development": [
      "last 1 chrome version",
      "last 1 firefox version",
      "last 1 safari version"
    ]
  }
}

Comment
Please let me know if I make any mistakes in the initialization of the project.
PS: Maybe the template example also needs a version update💖

@yzhe819 I have the same issue on Windows. The absolute path of the api file is recognized as a valid URL (see https://github.com/nodejs/node/issues/34765). utils.isUrl() needs to be changed to support absolute paths.

@ianberryman Thanks for your advice. I use regular expressions instead of URL to avoid this platform issue. Just waiting for code review. Feel free to take a look.

@yzhe819 Nice, I'm going to pull your fork and use it until the PR is merged


Issue 8269 - The 'with statement' does not observe temporary object lifetime

Do not create a temporary with a dtor inside an expression.
https://issues.dlang.org/show_bug.cgi?id=8269

That's actually worth mentioning in the changelog @yebblies.

Just a few lines @yebblies, it's a really nice feature.

Really?  It's just a bugfix, and only affects using 'with' with an rvalue that has a dtor.

with (File("output.log", "w"))
{
    writeln("Content");
}
// File is automatically closed

That is quite a nice pattern. I think Python has something similar.

I think that's the reason why there was a 250$ bounty on this.

Ok what do I need to do?

The changelog file is here, just add a few words about an old bug being fixed and a small example, e.g. the one from above.
https://github.com/D-Programming-Language/dlang.org/blob/master/changelog.dd
Here is a simple example pull for package level protection.
https://github.com/D-Programming-Language/dlang.org/pull/922


[Clojars] Add downloads badge

Since #1192 seems to have been abandoned, I had a go at creating a Clojars downloads badge myself.
For now just total downloads, although in the json response there are download counts for some recent versions.
Closes #1152.

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @emlyn!

  Generated by :no_entry_sign: dangerJS


Small Caps font feature does not work if Language is selected

Description
Version v2.9d (the latest dev version) does not understand small caps if Language is selected
Check/indicate

[x] Relevant for XeTeX
[x] Relevant for LuaTeX
[x] Issue tracker has been searched for similar issues?

Minimal example demonstrating the issue
\listfiles
\documentclass{article}
\usepackage[english]{babel}
\RequirePackage{fontspec}
\setmainfont
[
  Ligatures=TeX,
  Numbers=Lowercase,
  Extension=.otf,
  UprightFont=*-Regular,
  ItalicFont=*-Italic,
  BoldFont=*-Bold,
  BoldItalicFont=*-BoldItalic,
  Language=English,
  Script=Latin
]{EBGaramond}
\begin{document}
\textsc{aaaa23}
\end{document}

Further details
The example above gives warnings
Package fontspec Warning:
(fontspec)                Language 'English' not explicitly supported within
(fontspec)                font 'EBGaramond-Regular' with script 'Latin'. Check
(fontspec)                the typeset output, and if it is okay then ignore
(fontspec)                this warning. Otherwise a different font should be
(fontspec)                chosen.

and
LaTeX Font Warning: Font shape `TU/EBGaramond(0)/m/sc' undefined
(Font)              using `TU/EBGaramond(0)/m/n' instead on input line 18.

Here are the package versions used
 *File List*
 article.cls    2023/05/17 v1.4n Standard LaTeX document class
  size10.clo    2023/05/17 v1.4n Standard LaTeX file (size option)
   babel.sty    2024/04/20 v24.4 The Babel package
 english.ldf    2017/06/06 v3.3r English support from the babel system
babel-english.tex
fontspec.sty    2024/05/07 v2.9d Font selection for XeLaTeX and LuaLaTeX
  xparse.sty    2024-03-14 L3 Experimental document command parser
   expl3.sty    2024-04-11 L3 programming layer (loader)
l3backend-luatex.def    2024-04-11 L3 backend support: PDF output (LuaTeX)
fontspec-luatex.sty    2024/05/07 v2.9d Font selection for XeLaTeX and LuaLaTeX

 fontenc.sty    2021/04/29 v2.0v Standard LaTeX package
fontspec.cfg
  ts1cmr.fd    2023/04/13 v2.5m Standard LaTeX font definitions
 ***********

If I comment out Language, the bug disappears
\listfiles
\documentclass{article}
\usepackage[english]{babel}
\RequirePackage{fontspec}
\setmainfont
[
  Ligatures=TeX,
  Numbers=Lowercase,
  Extension=.otf,
  UprightFont=*-Regular,
  ItalicFont=*-Italic,
  BoldFont=*-Bold,
  BoldItalicFont=*-BoldItalic,
%  Language=English,
  Script=Latin
]{EBGaramond}
\begin{document}
\textsc{aaaa23}
\end{document}

Ah. Sorry about that. My test suite coverage needs improvement!
I think fontspec should check if small caps exists within any script+language combo in a preset but customisable list of defaults (e.g. Latin+Default, Default+Default,...).
If it exists there then we can still apply it and the engine will likely figure out what to do.
I'm starting to wonder if my interpretation of @khaledhosny 's advice to stop checking Script + Language was correct... maybe it would have been better to add a new set of options like ForceLanguage and ForceScript which had the new (non-checking) behaviour, and the old ones behaved as they always did.

Since many people use babel and other interfaces, you probably want to set the old behavior as the one invoked by \babelfont, unless one explicitly selects the option, say,  StrictChecking

This seem to be another case of #515. Diffing the long when language is specified and when it is not, I see:
-(fontspec)             <->"[EBGaramond-Regular.otf]/OT:script=latn;language=ENG
-;mapping=tex-text;"
-(fontspec)             - 'small caps'  (m/sc) with NFSS spec.:
+(fontspec)             <->"[EBGaramond-Regular.otf]/OT:script=latn;language=dfl
+t;+onum;mapping=tex-text;"
+(fontspec)             - 'small caps'  (m/sc) with NFSS spec.:
+(fontspec)             <->"[EBGaramond-Regular.otf]/OT:script=latn;language=dfl
+t;+onum;+smcp;mapping=tex-text;"

So fontspec is not requesting the feature when the language is set.

I have fontspec 2.9c, though, which I think does not have the fix for #515.

If I understand correct, fontspec wants to know if the font supports smcp feature to set up NFSS smallcap font. That is indeed different from the user explicitly asking for a feature. I think in this case checking for smallcaps under any script/language combination is probably the safest approach.
You can keep the existing behavior if both specified script and language exist, and check any combination if the specified ones do not exist.


VCS integration for Godot Editor

Godot version:
3.2
Feature description:

This project is a part of Google Summer of Code 2019, which will be ending soon. I am Twarit Waikar and I was mentored by @groud and @jahd2602 for the entire program.

The VCS integration makes Godot aware of being in the presence of a version control system, applies basic VCS initialisations, version diffing, staging, committing from within the editor. This makes the Godot editor more favourable for people who use their VCS intensively while iterating.
The integration is in an improvable state and lays down the groundwork for more advanced VCS data visualisations and editions to be implemented in the future. The feature is currently only implemented for Git, as planned for GSoC 2019. However, the same API can be implemented for some other VCS and that should work fine too.
Instructions for testing the Git API

Currently the GDNative plugin is available at https://github.com/IronicallySerious/godot-git-plugin. And it requires the user to build the plugin themselves. A release will be made soon that provides binaries for all platforms.

I have provided the demo project from the above-mentioned Git API repository that has the binaries for Windows currently. The build instructions for Linux are provided in the repository.
[EDIT] Windows and Linux binaries are included in the demo project folder. Just download the demo folder as is.

Extract the demo project present here https://github.com/IronicallySerious/godot-git-plugin/tree/master/demo.
Open Godot Project Manager. Select the newly extracted demo project.
Select Project > Version Control > Set Up Version Control.
In the popup, select GitAPI. If you don't see this option, it means that Godot can't find the GDNative plugin. Verify if you have the correct project open.
Next, you will see the Version Control dock appear at the bottom and the Commit panel appear on the right-hand side (alongside Inspector and Node panels).
Try to follow the same workflow as the VCS integration present in VSCode/VS/Atom etc. i.e. make a change to a file, see it get reflected in the stage area, stage the file, add a commit message, and commit the file.
When you are done, you can select Project > Version Control > Shut Down Version Control to remove all VCS UI.

Use cases:

Introducing Git project management from within the editor
Creating diff for text files and displaying them so as to implement features like #25442.
Providing a singular interface for Git/SVN/Perforce/etc. through a single EditorVCSInterface class. Documentation for the interface will be pushed soon so that similar Editor Wide plugins can be implemented for Perforce/SVN/Mercurial etc.
Addresses #25542
Implements the backend linkages required for #25442 and #27984 and a few more (which I probably didn't notice)

This may not be merged yet.
I am writing documentation and would probably require inputs from the community to incorporate necessary changes

The staging area UI is needing some changes as @groud had recommended. I will be working on these.
The change I am making is that the file status should be reflected by the color of the font that it appears in or the tag added to its file name e.g. new_script.gd (deleted). Right now all files are categorized in the staging area according to their change type.

Haven't had time to review yet, but just noting down for potential merge (me later or anyone else): 86 commits sounds like a ton, this should likely be squashed into a smaller number.

This branch has been basically re-made to remove the excessive amounts of commits that eventually compile with a future commit.
To see the actual history of the project, go to https://github.com/IronicallySerious/godot/tree/add-vcs-integration-dirty
The above branch was cleaned up to remove the useless experiments we made with the codebase.

Thanks a ton for your work :)


fix-1519

Please check if the PR fulfills these requirements

[] The commit message follows our guidelines
[] If your PR contains DB doc changes have you made an API migration and a localDB migration if necessary?
[] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[] Tests for the changes have been added (for bug fixes / features)
[] Passes e2e testing
[] Passes lint
[] Docs have been added / updated if necessary (for bug fixes / features)

What kind of change does this PR introduce?

What is the current behavior?
closes issue #

Does this PR introduce a breaking change?

It would be nice if the check for bad rows happens before hitting the save button

The UX for this page could be redesigned based on the new information we're displaying. The redesign would be a bigger task. I think its worth it to ship the feature before redesigning since we're running into issues in production.


Add support for translating the Pagefind search modal

What kind of changes does this PR include?

Changes to Starlight code

Description

Adds Pagefind’s translation keys to the i18n schema and passes them to Pagefind UI if provided — adding support for languages that Pagefind doesn’t provide out of the box.
Aliases our existing search.label string to Pagefind’s placeholder string, which fixes the input placeholder not being translated on non-English sites.
Adds docs on the above to the i18n guide.

size-limit report 📦

Path
Size

/index.html
13.13 KB (+0.24% 🔺)

/_astro/*.js
16.58 KB (+0.26% 🔺)

/_astro/*.css
9.04 KB (0%)

Thanks for calling that out @Yan-Thomas! My thinking was that given it’s only a dev notice it wasn’t worth translating, but I guess that may be making assumptions about our users. Don’t think we need to block this PR for this, but maybe you’re right that we should add this as an option. If you want to wire that up in a separate PR, I’d be happy to merge!


Improve support for the node-fetch polyfill

'node-fetch' is great but does not use what wg streams API ReadableStream for response.body.
See https://github.com/node-fetch/node-fetch/issues/754
This means that @protobuf-ts/grpcweb-transport will not work on node, even with the node-fetch polyfill.

Hi @timostamm I noticed that this was fixed for grpc web but it seems like it's still an issue for twirp. I'm happy to do to the work to get it working for Twirp too unless you have the time to quickly knock it out. Any pointers on what needs addressing?

After doing some more digging, I'm running into a FileReader.readAsArrayBuffer is not implemented error from my React Native app when arrayBuffer is called.


Sidekiq Documentation

Can one detail how you run Sidekiq jobs with AMT?
Digging through the code I found this:
https://github.com/citusdata/activerecord-multi-tenant/blob/c4747ade6e51259b1915f3984bea1e9ea3fc1fc4/lib/activerecord-multi-tenant/sidekiq.rb
which seem to mirror the acts_as_tenant code which is just as vague on how to actually implement this.
I tried this adding require 'activerecord-multi-tenant/sidekiq' to mu initializer then adding this to my job call:
Searchkick::ProcessQueueJob.perform_later(class_name: "Location", multi_tenant: { class: 'Company', company_id: 9 } )
Sidekiq jobs fail with:

ArgumentError: unknown keyword: multi_tenant

I think a documentation could still be useful, since theres a few steps that needs to be performed. For instance
require 'activerecord-multi-tenant/sidekiq'

Sidekiq.configure_client do |config|
  config.client_middleware do |chain|
   ...
    chain.add(Sidekiq::Middleware::MultiTenant::Client)
  end
end
Sidekiq.configure_server do |config|
  ...
  config.server_middleware do |chain|
    ...
    chain.add(Sidekiq::Middleware::MultiTenant::Server)
  end
end

UPDATE: We also need to add
  config.client_middleware { |chain| chain.add(Sidekiq::Middleware::MultiTenant::Client) }

To sidekiq server config, to ensure that jobs that enqueue other jobs also get the multi_tenant object set. So the full config looks like this
Sidekiq.configure_client do |config|
  config.client_middleware do |chain|
   ...
    chain.add(Sidekiq::Middleware::MultiTenant::Client)
  end
end

Sidekiq.configure_server do |config|
  ...
  config.server_middleware do |chain|
    ...
    chain.add(Sidekiq::Middleware::MultiTenant::Server)
  end

  config.client_middleware { |chain| chain.add(Sidekiq::Middleware::MultiTenant::Client) }
end

I am happy to open a PR to document this somewhere. Or this comment can serve as documentation 👍🏾


Kafka to 2.6 and Core to 1.2.1

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Coverage remained the same at 100.0% when pulling e1ba25cb77b806f1995c684e8f891f1eac838019 on bullet-core-1.2.1 into 8e4d14fc7626012e0d73e77e85a451297aa47f3f on master.


Suggest npm test instead of make test

Is there a reason for suggesting the use of make test instead of npm test and users adding "test": "mocha --reporter list" to their package.json file?
Advantages include integration with travis ci and standardization of testing of node projects

whichever you want. I prefer make test because all my projects in various languages are the same, but it's up to you

npm test is cross-platform, whereas make test is *nix only.

meh

And obviously npm test cannot be fully cross-platform with paths (a/b/c vs a\b\c on win) so if your test command contains them (mocha test/unit), you need to create additional file (runtests.js) and execute node runtests.js.
That's the advantage of Cakefiles (etc) to Makefiles.


404 on internal link to planner page

There's a 404.
From this public page:
https://learn.microsoft.com/en-us/semantic-kernel/frameworks/agent/agents
search for this text:
"To learn more about planning with Semantic Kernel, see the "
This text is followed by a "planning article" link that 404s.
This is the destination of the link that 404s:
https://learn.microsoft.com/en-us/semantic-kernel/frameworks/agent/planning.md
which perhaps should be:
https://learn.microsoft.com/en-us/semantic-kernel/concepts/planning
Source code page is:
https://github.com/MicrosoftDocs/semantic-kernel-docs/blob/main/semantic-kernel/concepts/agents.md
The offender is line 229:

To learn more about planning with Semantic Kernel, see the planning article.

There's another link near the bottom of this source file (the second-to-last line - line 447) that appears it would also 404 because it also references ./planning.md, but I can't find where the "Next steps" section appears on the live site so unable to prove it:

439:  ## Next steps
440: Now that you've built your first agent, you can now deep dive into the different components of Semantic Kernel.
441:
442: | Section                                     | Description                                                |
443: | ------------------------------------------- | ---------------------------------------------------------- |
444: | Kernel                       | Setting up and using the core Kernel object                |
445: | AI Services       | Integration and usage of various AI services               |
446: | Plugins               | Integrate native code and APIs with Semantic Kernel        |
447: | Planners                   | Enabling your AI agents to complete multi-step tasks       |
448: | Personas                   | Customize your AI agents to better collaborate with others |

This no longer appears to be happening (the pages seem to have moved a bit). Closing.


[Suggestion]:Debugger tool supports moving to the left or right blank area at the top

If opening many files will cause the debugger tool to obscure the file name or code of the open file.

You can consider supporting moving the debugger tool to the left or right blank area on the top, or fixing it at that location to prevent users from moving it by mistake.

You might like to set "debug.toolBarLocation": "docked", that will move it into the debug viewlet.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Add tags on table and columns

they can be shown and updated through detail sidebar
they could be used in search (using a # char?)
they could be seen on diagram on hover, still not sure where...

Done in stream: https://github.com/azimuttapp/azimutt/pull/209


[1.x] Add dependabot.yml

Description
Adds dependabot.yml to 1.x branch. This PR adds dependabot.yml directly to 1.x branch. With all of the dependabot PRs against main, labels like backport 2.x, backport 1.x and backport 1.3 must be added to the PR in order to trigger backport bot to backport the PR to the respective branches. This process is manual and causes drifts between release branches if the labels are not added to the PR.
I am creating a PR to add dependabot.yml directly in 2.x and 1.x to keep all of the release branches up to date.
The PR against 1.x includes an automatic label of backport 1.3 so that 1.x and 1.3 can stay synchronized.

Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Maintenance
Check List

[ ] New functionality includes testing
[ ] New functionality has been documented
[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Thank you for getting all sections @peternied ! I updated the companion PR against 2.x as well.


Process New Song Files

[ ] Get a new song (or songs) from the user
[ ] Process the target file(s) to pull tag metadata
[ ] Capture Purchase/Add date from user
[ ] Add song data to the in-memory dataset
[ ] Verify integration with export feature (#3)

#8 needs to be done first so that the edit functionality can be used here to set purchase date and fix any incorrect data for new songs. Moving this back to "To do".


Implementing angular-moment to automatically update dates / durations

Allowing durations and dates to auto update over time, similar to how GitHub and twitter handle time periods. It still uses Momemt.js, but implements it as a directive and allows the time periods to be updated automatically.

very cool. thanks!


Breaking Exporters doesnt drop installed filters

Issue description:
Breaking Exporters doesn't drop installed filters
What happens:
No filters drop
What you expected to happen:
Filters to drop
Steps to reproduce:

Place Exporter
Insert filter
Break Exporter

Version (make sure you are on the latest version before reporting):

Minecraft: 1.12.2
Forge: <IP_ADDRESS>32
Refined Storage: 1.15.21

Does this issue occur on a server? [yes/no]
Yes

Read before creating an issue. Literally 3 issues under you: #1531 -.-


Watch for page changes

Is there a way in which I can choose to follow certain pages and be notified of changes to them?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c5ed2449-4122-2660-56be-78ceebd0de66
Version Independent ID: b5b1c94e-3efe-b234-5366-79823678f237
Content: Monitor Azure Event Grid message delivery
Content Source: articles/event-grid/monitor-event-delivery.md
Service: event-grid
GitHub Login: @spelluru
Microsoft Alias: spelluru

@simonvane Can you please elaborate on pages? What do you actually mean by pages in context of this document?

I mean any documentation page in  https://docs.microsoft.com/en-us/. The
documentation changes rapidly, especially for Azure, and it would be great
to be notified of those changes for topics I am interested in . This could
either be a specific page or a page and all it's child pages.
On Wed, 4 Sep 2019 at 10:22, KetanChawda-MSFT<EMAIL_ADDRESS>wrote:

@simonvane https://github.com/simonvane Can you please elaborate on
pages? What do you actually mean by pages in context of this document?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/38248?email_source=notifications&email_token=AAK3OUMRNNTFZJGFNZDZKPLQH545TA5CNFSM4ITO7RZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD526CUI#issuecomment-527819089,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAK3OUO5SPXAVL3HPWRCPITQH545TANCNFSM4ITO7RZQ
.

@simonvane This channel is for driving improvements towards the content of MS Docs, Since this issue is not related directly to the doc content,  I would recommend you to create a issue on this github repo Once you post your issue, it will have visibility across the platform owner which is a better suited audience for such types of issues.

@simonvane Thanks for the raising the issue in Microsoft Feedback repo. We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


appveyor ci support go1.12

See the issue. https://github.com/appveyor/ci/issues/2875

Add the following script
environment:
  GOPATH: c:\gopath
  GOVERSION: 1.12.4

install:
  # Install the specific Go version.
  - rmdir c:\go /s /q
  - appveyor DownloadFile https://storage.googleapis.com/golang/go%GOVERSION%.windows-amd64.msi
  - msiexec /i go%GOVERSION%.windows-amd64.msi /q
  - choco install bzr
  - go version
  - go env


Add a new Spin The Wheel project

This pull request introduces the "Spin the Wheel" feature, which allows users to spin a virtual wheel and receive randomized values.

fix #1063


feat: Integrating search bar on navbar

Embedding Search Bar on Navbar for Product Search by Category
Description
Problem Statement
We need to enhance user experience by embedding a search bar on the navbar, allowing users to search for products based on category directly from any page.
Proposed Solution

Integrate a search bar into the navbar.
Enable users to enter search queries.
Implement functionality to filter search results by category.
Display search results in a user-friendly format.

Additional Features

Autocomplete Suggestions: Provide autocomplete suggestions as users type in the search bar to enhance usability.
Responsive Design: Ensure the search bar is responsive and works seamlessly across all devices and screen sizes.

UI/UX Considerations

Positioning: Determine the optimal position for the search bar in the navbar to maximize visibility and accessibility.
Styling: Maintain consistency with the existing navbar design while making the search bar visually prominent.

Priority
Medium,
Labels

enhancement
search
navbar
category

@Niharika0104 I have assigned this issue to you.
Happy Contributing !! 😃

@trishanu-init Do I have to create a backend route for this or just the ui will be sufficient?

@trishanu-init Do I have to create a backend route for this or just the ui will be sufficient?

Yes! Just the ui is not sufficient.

@trishanu-init can you please assign me this issue as it's been inactivity for more than 20 days and I wish to work on it

I will update by tomorrow on this

@trishanu-init can you reopen and please assign me this issue, I wish to work on it

this feature has been implemented already @Asymtode712 ,please find some other issue


[HOTFIX] Support both listfile() and listfile(maxCount) in InsertStag…

…e flow
Why is this PR needed?
Flink writes files to obs with setting the filename in order of time, when loading stages files to carbondata, files are list and loaded with the parameter "maxcount" which will return "maxcount" files with smaller filename, in the other words, "maxcount" files with earliest generation time. but in same senario, it is possible that the filename of stage files is not in order of time, a switch is used here to judge whether to list files with specify batch size, or just list all files in the stage dir.
What changes were proposed in this PR?
A swith "CARBON_STAGE_FILENAME_IS_IN_ORDER_OF_TIME" is added.
Does this PR introduce any user interface change?

No

Is any new testcase added?

No

Build Success with Spark 2.4.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.4/296/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/2000/

@marchpure Please rebase and fix the comments


Define Data Routing Rules

Define the specification for the data routing rules for DICOM, FHIR.

Closing due to redesign


Removing advocate

Take the change to remove advocate Tim H

Docs Build status updates of commit 168a262:
:warning: Validation status: warnings

File
Status
Preview URL
Details

advocates/index.html.yml
:warning:Warning
View
Details

advocates/index.yml
:warning:Warning
View
Details

advocates/map.yml
:white_check_mark:Succeeded
View

advocates/media/profiles/tim-heuer.png
:white_check_mark:Succeeded
View

advocates/tim-heuer.yml
:white_check_mark:Succeeded
View

advocates/toc.yml
:white_check_mark:Succeeded
View

advocates/index.html.yml

Line 0: [Warning] Invalid file link:(~/tweets).
Line 0: [Warning] Invalid file link:(~/map).

advocates/index.yml

[Warning] Unable to find uid "advocates.brian-holt".
[Warning] Unable to find uid "advocates.brian-peek".
[Warning] Unable to find uid "advocates.bridget-kromhout".
[Warning] Unable to find uid "advocates.jessica-frazelle".
[Warning] Unable to find uid "advocates.jonathan-giles".
[Warning] Unable to find uid "advocates.marcelo-bellinaso".
[Warning] Unable to find uid "advocates.sarah-drasner".
[Warning] Unable to find uid "advocates.tim-heuer".
Line 0: [Warning] Invalid file link:(~/media/profiles/marcelo-bellinaso.png).
Line 0: [Warning] Invalid file link:(~/media/profiles/bridget-kromhout.png).
Line 0: [Warning] Invalid file link:(~/media/profiles/jonathan-giles.png).
Line 0: [Warning] Invalid file link:(~/tweets).
Line 0: [Warning] Invalid file link:(~/media/profiles/jessica-frazelle.png).
Line 0: [Warning] Invalid file link:(~/media/profiles/brian-holt.png).
Line 0: [Warning] Invalid file link:(~/media/profiles/brian-peek.png).
Line 0: [Warning] Invalid file link:(~/map).
Line 0: [Warning] Invalid file link:(~/media/profiles/tim-heuer.png).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


How to set eos-on-timestamps-reset=False in module.yml

I have a bad RTSP stream which sometimes provides non-monotonous timestamps, and it's causing frequent source resets (every few seconds), with messages like "'Timestamps on source xxx non-monotonous. Resetting source."
Hacking around I've found the eos-on-timestamps-reset property in savant_rs_video_demux.py, which is set to True by default. If i hack the script to turn it False, it stops the resets.
Is there a clean way to set this property from module.yml? I've adapted one of samples in the samples folder, using a RTSP Source adapter, so I don't have a source: element in my pipeline:.
Is there a  downside to setting eos-on-timestamps-reset to False?

Hello,
I would recommend first trying fixing PTS with the adapter, e.g. you can utilize ffmpeg source adapter and pass extra arguments to get rid of PTS, like fflags +genpts, not sure it helps.
But, in general, I assume it is better to do this sort of fix outside of the module, in the adapter. E.g. you can write a buffer adapter that just reads from the stream, fixes pts, and writes s to the stream. You can find a sample of such an adapter here:
https://github.com/insight-platform/Savant/blob/develop/adapters/python/bridge/buffer.py
it is more complex than you need, but you can completely remove unnecessary gears and use it just to fix PTS.

Thanks, I will look into the adapters, but I don't really know how to fix the PTS myself. When I run one of the pure DeepStream samples on the same RTSP stream, things just work and the video output is completely smooth. I haven't even realized there might be a timestamp problem in the RTSP stream until I switched to Savant.
I already use ffmpeg source adapter, and I tried various parameter combinations (use_wallclock_as_timestamps=1,fps_mode=1,fflags=+genpts+igndts+ignidx), but haven't seen an improvement. It's either still resetting, or the video output is non-smooth (when I use_wallclock_as_timestamps).
In my experiments I haven't seen any problem yet caused by setting eos-on-timestamps-reset=False.

@nikcleju if it works for you, you can use it. We discuss if it is possible to export eos-on-timestamps-reset to configuration parameters.

Haven't had any problems yet with my workaround, I'm closing the issue. Thanks for the help!


Metrics Controller: Error message from previous reconciliation attempt is not deleted after successful retrieval of value

In the metrics controller, when a previous attempt to retrieve a value for a metric failed (e.g. due to no value being available yet), we store the related error message in the status of the KeptnMetric. However, once a value has successfully been retrieved in a later attempt, this error message is still there. This looks confusing since there is a value in the status of a KeptnMetric, with a error message next to it, as in the following example:
apiVersion: metrics.keptn.sh/v1beta1
kind: KeptnMetric
metadata:
  labels:
    app.kubernetes.io/instance: simple-go
  name: response-time
  namespace: simple-go
  resourceVersion: '4729'
  uid: 0d91d168-7e4b-4950-a253-caa12e385206
spec:
  fetchIntervalSeconds: 10
  provider:
    name: my-provider
  query: >-
    histogram_quantile(0.8, sum by(le)
    (rate(http_server_request_latency_seconds_bucket{status_code='200',
    job='simple-go-backend'}[5m])))
status:
  errMsg: no values in query result
  lastUpdated: '2023-12-21T07:04:23Z'
  rawValue: IjAuMDA0MDAwMzQxMTgwNDg0NDc2NSI=
  value: '0.0040003411804844765'

To fix this, we should clear the error message after successfully retrieving a value. This can be done here:
https://github.com/keptn/lifecycle-toolkit/blob/5456786ed7128766016b065e262fad1a4a4f3ee6/metrics-operator/controllers/metrics/controller.go#L114
DoD

[ ] A KeptnMetric should not contain an error message in its status when a value has been retrieved successfully

Acceptance Criteria

[ ] Unit tests
[ ] Integration tests

I would like to work on it @bacherfl can you please assign me .

@bacherfl Can you please assign me this issue

@bacherfl I worked on this and created a draft PR #2754. For the unit and integration test, can you provide a little more context on how this can be achieved?

Hi @aryasoni98 @Vickysomtee since both of you are interested in this issue, would you be open to collaborating on this one?

@bacherfl Yeah, I"m happy to collaborate with @Vickysomtee .
@Vickysomtee can be connect on slack or any other platform.

awesome @aryasoni98 , thanks - @Vickysomtee seems to already have started a PR, so my suggestion would be to work together on Unit tests and a Kuttl test for this one :-)

@bacherfl Yeah, I"m happy to collaborate with @Vickysomtee .
@Vickysomtee can be connect on slack or any other platform.

I sent you a message on Twitter

Hello @bacherfl I noticed there is already an existing test here that returns an empty error message https://github.com/keptn/lifecycle-toolkit/blob/5d7ebbdc2ef55714e62dd8ad8b600a1098f9adef/metrics-operator/controllers/metrics/controller_test.go#L231

Hello @bacherfl I noticed there is already an existing test here that returns an empty error message
https://github.com/keptn/lifecycle-toolkit/blob/5d7ebbdc2ef55714e62dd8ad8b600a1098f9adef/metrics-operator/controllers/metrics/controller_test.go#L231

Hi, @Vickysomtee you are right, however, I would expect a test that proves that an already existing error status is overwritten. So similar to the vanilla test but with the metric CR having a status error and a check that this error is not there after running the function.


Nextflow fix

Changed sra2gev nextflow so that it uses channels throughout.

Hi @JohnHadish Can you remove the nextflow.config file from the commit and put your changes in the nextflow.config.example file?   Since other folks will use this in the future we just provide the generic example and when we pull updates it won't overwrite our customized actual config file.

Thanks much! @JohnHadish


Add fallback names to probe to account for platform differences

This PR adds support for fallback-names to allow dealing with different names on different platforms. It also updates the documentation and adds tests. The user can specify fallback-names directly on the dependency entry, and on the version overrides.

Thanks for the patch! I think that makes sense.
Can you please fix formating by running cargo fmt?

Thanks for the quick review!

Can you please fix formating by running cargo fmt?

Whoops, done :)

Thanks!


NETOBSERV-867 UI: Table Histogram help

These changes brings a reusable guided tour and implements it for histogram.
It automatically shows up at first usage and be called again from the "?" button.
Screencast from 2023-02-22 14-38-17.webm
Suggestions:

[ ] increase the image sizes
[ ] wording

@andrew-ronaldson what do you think about this approach ?

/ok-to-test

@jpinsonneau For the first and the last tip, the images are quite small to see what is happening. Other than that the tips look good!

@jpinsonneau For the first and the last tip, the images are quite small to see what is happening. Other than that the tips look good!

Should I increase the size ? Or would it be better to use static images instead of animated gif ?

Increasing the size would be helpful

lgtm apart from the type, and would defer to other folks for more reviews (also @andrew-ronaldson for UX )

/lgtm

/ok-to-test

@jpinsonneau I see this error message for flows

Steps to recreate the error

Select a block using the tooltips
click on left Double arrows multiple times
Click on zoom out multiple times
The above error will be seen. Let me know if you need more logs/info

/label qe-approved

/lgtm


Input textarea visible in top left corner when gutter has different background than editor and the cursor is scrolled out of view

editor.background leaks through editorGutter.background when you scroll past cursor
"editor.background": "#F00",
"editorGroupHeader.tabsBorder": "#333",
"editorGutter.background": "#222",

Is this element important? Am I losing something setting:
.textAreaCover {
    background: transparent;
}

@usernamehw nothing bad happens doing that if you don't use CJK languages or others that require composition.

Thanks.


Add zaps

Zapper.fun? Not working w/o extension :(
Some zapper widget?
Custom zap implementation?

Done

Is there a difference between Profile zaps and individual note/post zaps?
As an author I'd really like to see zaps per note prompted at the bottom of the page so I can track note/story performance.

Is there a difference between Profile zaps and individual note/post zaps?

Yes there is, note zaps have a link to specific note.

As an author I'd really like to see zaps per note prompted at the bottom of the page so I can track note/story performance.

Most apps will show you the zap amount under each of your note.


multiple acquisitions

Dear all,
I am about to make the BIDS renaming, but I have 2 issues:

multiple acquisitions: should I rename all the files? let's say I acquired the same sequence twice, but the second is the good one. Should I rename both, or the second one is enough?
partial acquisitions: in case the number of files I have is partial (let's say, in case of DWI I have 4 files instead of the correct number, that should be 8): in this case should I rename them or is this not necessary (i.e., I will not send my data anywhere)?

Hey @Lolibike95 your question sounds more like a "usage" question rather than a problem with the specification itself, or a proposal to change it.
Usage questions on BIDS are best handled over at Neurostars, with the BIDS tag: https://neurostars.org/tag/bids
You are more likely to get helpful answers there.


How to have other users republish mutable content?

It seems like nodes are already doing this automatically, through the regular DHT routing stuff, but I need to do this programmatically.
For instance, I publish a signed message using put, and then I leave the network. I want other users to keep it alive by republishing it, and I obviously don't want to provide them with my priv key.
Any help?

I guess in the put users can simply set the sign function to return the signature from a previous get right?
sign: function (buf) {
    //return ed.sign(buf, keypair.publicKey, keypair.secretKey)
    return <signature returned by get>;
}

You should be able to just put the content you get
dht.get({k: ...}, function (err, res) {
  // republish this
  dht.put(res)
})

This should work for both immutable and mutable content. I'm not sure we have a test for this so if you run into problems let me know.

Ah very cool. Makes sense. Will try and let you know thanks!

@mafintosh I actually thought it was not possible as the nodeID was signed along the rest of the request... I'll see if it works in real life, as it would be an amazing feature !

@pldubouilh bep44 explicitly allows this in the spec

Yep, you're right. For some reason, I thought the signature was stripped on arrival. Very good, so I checked, and I -indeed- receive the signature back, which allow us to republish content.
Although, there's a error when using this
dht.get(location, function (err, res) {
  dht.put(res)
})

 if (!message.a.sig) message.a.sig = opts.sign(encodeSigData(message.a))
TypeError: opts.sign is not a function  at DHT._put

... as DHT.prototype.put is expecting a function, and not a signature. I just fixed it. I'm running some tests to see if its any good and I'll PR.

could you add an additional test for this as well?

Fixed in 6.4.0. You can now always do this
dht.get(mutableOrImmutableKey, function (err, res) {
  dht.put(res, function () {
    console.log('re-hosted', res)
  })
})


changed the about page UI

Build : Changed the UI of About-us page.
Related Issue
Closes: #724
Description
I was Assigned to the task for doing changes in about-us page , I simply add some more features to UI of that page like by adding horizintal line , png's , aligning the content , etc . By doing this the about us page looks more attractive now!!
How Has This Been Tested? ⚙

Changing the source code .
Previewing it on chrome browser
Inspecting through chrome.
Finalizing the change.

Video After Change 📷
https://github.com/user-attachments/assets/64010936-c36b-4f87-b7a3-8171a28a77bc
Type of change
What sort of changes have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist

[x] My code follows the code style of this project.
[x] I have followed the contribution guidelines
[x] I have performed a self-review of my own code.
[x] I have ensured my changes don't generate any new warnings or errors.
[ ] I have updated the documentation (if necessary).
[ ] I have resolved all merge conflicts.

Okk

hello admin !!
I had resolved the merge conflict.

You need to resolve merge conflicts or you can create a new pr either

How to resolve merge conflicts???

How to resolve merge conflicts???

You can simply raise a new pr after making changes in the most updated version of the repo if you don't know how to resolve merge conflicts

@vishanurag i had resolved all the merge conflicts caan u plz accept my pull request

There are several problems in this PR.
You can check them at: https://deploy-preview-796--tourmaline-bavarois-d21f10.netlify.app/


Use local zuul.

I think using the local package would be safer.

When an npm script is ran, ./node_modules/.bin/ is added to $PATH which makes this PR useless 😥. My bad.


Deep association only populating first result

I have these structs:
// User is the User table in the database
type User struct {
	gorm.Model
	Username     string `sql:"not null;unique"`
	Email        string `sql:"not null;unique"`
	PasswordHash string `sql:"not null;unique"`
	UserLevel    int    `sql:"not null;default:0"`
	Characters   []Characters
	MainPosts    []ForumMainThreadsPosts
	ReplyPosts   []ForumMainPostsReplies
}

// Characters is a table in the database
type Characters struct {
	gorm.Model
	UserID          int    `sql:"index"`
	CharacterName   string `sql:"not null;unique"`
	CharacterServer string `sql:"not null"`
	CharacterLevel  int    `sql:"not null"`
	CharacterMain   bool   `sql:"not null"`
	CharacterClass  string `sql:"not null"`
	CharacterPic    string `sql:"not null"`
}
type ForumMainThreadsPosts struct {
	gorm.Model
	UserID             int `sql:"index"`
	ForumMainThreadsID int `sql:"index"`
	User               User
	ForumMainThreads   ForumMainThreads
	Title              string `sql:"not null;unique"`
	Body               string `sql:"type:text;not null"`
	Sticky             bool   `sql:"not null;default:0"`
	Views              int    `sql:"not null;default:0"`
	ReplyCount         int    `sql:"not null;default:0"`
	Replies            []ForumMainPostsReplies
}

Then I call:
db.Where("forum_main_threads_id = ?", vals["threadid"]).Preload("User").Preload("User.Characters").Preload("ForumMainThreads").Find(&forumPosts)

for _, post := range forumPosts {
                log.Println("LOOPING ONCE")
		log.Println(post.User)
		log.Println(post.User.Characters)
}

each loop is the exact same User.ID so I don't understand why the first one gets populated but the second one doesnt
Then what I get from the loop is:
2015/12/12 23:46:19 LOOPING ONCE
2015/12/12 23:46:19 {{1 2015-12-13 00:02:35 +0000 UTC 2015-12-13 00:02:35 +0000 UTC <nil>} Gacnt<EMAIL_ADDRESS>0 [{{1 0001-01-01 00:00:00 +0000 UTC 0001-01-01 00:00:00 +0000 UTC <nil>} 1 Murgon Mal'Ganis 100 true Warrior http://render-api-us.worldofwarcraft.com/static-render/us/internal-record-3684/30/119827486-avatar.jpg?alt=/wow/static/images/2d/avatar/2-0.jpg}] [] []}
2015/12/12 23:46:19 [{{1 0001-01-01 00:00:00 +0000 UTC 0001-01-01 00:00:00 +0000 UTC <nil>} 1 Murgon Mal'Ganis 100 true Warrior http://render-api-us.worldofwarcraft.com/static-render/us/internal-record-3684/30/119827486-avatar.jpg?alt=/wow/static/images/2d/avatar/2-0.jpg}]
2015/12/12 23:46:19 LOOPING ONCE
2015/12/12 23:46:19 {{1 2015-12-13 00:02:35 +0000 UTC 2015-12-13 00:02:35 +0000 UTC <nil>} Gacnt<EMAIL_ADDRESS>asd 0 [] [] []}
2015/12/12 23:46:19 []

if I do
	for _, post := range forumPosts {
		characters := []common.Characters{}
		db.Model(&post.User).Related(&characters)
		log.Println(characters)
	}

I get the data I'm expecting

Anybody got any information on this?

Please follow https://github.com/jinzhu/gorm/blob/master/CONTRIBUTING.md

@jinzhu Thanks for the reply and I'm loving gorm unfortunately the code is just too proprietary to replicate, I tried to provide enough information. I was hoping maybe you could see how I was calling the query to the database maybe I was doing it wrong.

Not sure about the problem, and this should be tested, so should be fine.
As even you can't reproduce the issue, it would be pretty time costing for me to check it, and don't even know it is a real problem or misusage, so going to close it.
Feel free to reopen it when you could provide reproducible demo.
Thank you.


normalize can implement simple cases without unfolding declarations

That is, application on Data and Codata.

For cons and proj we postpone the implementation after we have discussed about #28


Spanish translation updated

Hi Roshan. This is an updated version of the Spanish Read me.
Please let me know if everything is good.
Thanks

Spanish Read me Updated

Hi Roshan.
Yes sure. Reach me out at any time to contribute with any changes required
in the Spanish translation or for reviews.
I will be more that happy to help because I love collaborate in an Open
Source.
Best regards.
On Wed, Oct 4, 2017 at 12:48 PM, Roshan Jossey<EMAIL_ADDRESS>wrote:

Merged #690 https://github.com/Roshanjossey/first-contributions/pull/690
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Roshanjossey/first-contributions/pull/690#event-1278365355,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQI9KEfvLX_Cx3xIovstFQejbHpx5M85ks5so7bZgaJpZM4Pt5m1
.

Hi again Roshan.
I hope you're doing well.
I recently started to apply for jobs and I would like to ask you if I can
list you as a reference during my job/internship search.
As I see, the Open Source collaboration is highly valued in this industry
so, I think that will be a good thing for me.
Thank you very much.
Neisy
On Wed, Oct 4, 2017 at 1:05 PM, Neisy Wilson<EMAIL_ADDRESS>wrote:

Hi Roshan.
Yes sure. Reach me out at any time to contribute with any changes required
in the Spanish translation or for reviews.
I will be more that happy to help because I love collaborate in an Open
Source.
Best regards.
On Wed, Oct 4, 2017 at 12:48 PM, Roshan Jossey<EMAIL_ADDRESS>wrote:

Merged #690
https://github.com/Roshanjossey/first-contributions/pull/690.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Roshanjossey/first-contributions/pull/690#event-1278365355,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQI9KEfvLX_Cx3xIovstFQejbHpx5M85ks5so7bZgaJpZM4Pt5m1
.

@yirini: I'll be honored. Have I invited to our slack group yet? If you're not there, join by going to https://firstcontributions.herokuapp.com

Hi Roshan.
Thank you very much. I really appreciate it. The only thing that I will
need if it's possible is your email address as a contact information. Thank
you for invited me to the slack group, I just joined.
Best regards.
Neisy
On Oct 6, 2017 9:00 PM, "Roshan Jossey"<EMAIL_ADDRESS>wrote:

@yirini https://github.com/yirini: I'll be honored. Have I invited to
our slack group yet? If you're not there, join by going to
https://firstcontributions.herokuapp.com
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Roshanjossey/first-contributions/pull/690#issuecomment-334899990,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQI9KKdmWsJplDpC3IOvOupUmFut43Lyks5sps06gaJpZM4Pt5m1
.


bazel: expand linkstamp beyond binary rules.

bazel: expand linkstamp beyond binary rules.
Description: linkstamp is currently used by the VersionInfo class to stamp envoy binaries.  However, there are two current problems with it:

It is poorly documented and understood. https://github.com/bazelbuild/bazel/issues/2893
linkstamp is not available for non-binary rules. Thus if the version_info_lib is compiled outside of a top-level binary rule the linker will not be able to find symbols defined by the linkstamp rule. For now this is resolved by https://github.com/envoyproxy/envoy/pull/6803. However, it would be great to use the same, robust linkstamp mechanism we use for binary rules.

cc @htuch lmk if this is sufficient for the bazel folks, or if you'd like me to open an issue against bazel.

@junr03 it's sufficient for me to share, thanks. I think if we want action on the Bazel front though, it would be good to have a tracking issue in their GH.


Data

Hello, I want to run your code on SWaT and WADI datasets, but how can I get train.csv, test.csv, and list.txt? Is WADI_14days_new.csv in the WADI dataset the original training set (WADI_attackdataLABLE.csv is the original test set)?  Then it is processed by process() in TimeDataset.py to become the training data set used in your article?
Looking forward to your reply, thank you very much!

It's also my question!


[en]: Update hwameistor/resources/volume-eviction

Update the English version to be consistent with the Chinese version

MTPE

see preview:
https://deploy-preview-5389--daocloud-docs.netlify.app/en/storage/hwameistor/resources/volume-eviction


Fix text squeezing on large displays.

On large displays (with width >>14in), when viewing the documentation pages, the padding kicks in. It is meant to shift the text towards the center while preserving the width of the main text (through the max-width property). However, the padding is part of the width, so it ends up reducing the usable text width.
We could switch to controlling the margin, but then the thin left border also moves, which is unpleasant. I guess we could do that AND have the sidebar draw the border, but that's two steps.
So anyway, this adjusts the max-width to take the padding into account.
This addresses https://github.com/ExaWorks/exaworks.github.io/issues/5
PS: checks fail due to #362

May be set max-width as following calc(max(8in, 100% - max((100% - 14in) / 2, 8pt)));?
p.s. current update makes it look better than it is now, but there is still a lot of empty space on a right side, that's why in my proposal I've added 100% -

I am not sure what the inversion of max(calc(),...) to calc(max(...)) does, but trust that this is intentional. Looks good to me.

It's for consistency with max-width mostly and to essentially have all calculations under a single calc()

May be set max-width as following calc(max(8in, 100% - max((100% - 14in) / 2, 8pt)));?
p.s. current update makes it look better than it is now, but there is still a lot of empty space on a right side, that's why in my proposal I've added 100% -

The limited width is intentional and is understood to help with legibility. See, e.g., https://practicaltypography.com/line-length.html. The current line length is a bit less than 90 characters, which is the upper limit that the fellow that wrote that document recommends. See https://baymard.com/blog/line-length-readability for another, similar, suggestion.

The limited width is intentional and is understood to help with legibility. See, e.g., https://practicaltypography.com/line-length.html. The current line length is a bit less than 90 characters, which is the upper limit that the fellow that wrote that document recommends. See https://baymard.com/blog/line-length-readability for another, similar, suggestion.

oh, that the next level for me :) thank you for explanation and links!

On the other hand, I'm not sure wikipedia agrees: https://en.wikipedia.org/wiki/Line_length
That said, I'm not quite sure wikipedia agrees with wikipedia on that one.


[vcpkg_cmake_config_fixup] allow custom TARGET_PATH

Describe the bug
From a vcpkg port, I run a pip install. So everything is installed in ${CURRENT_PACKAGES_DIR}/tools/python3/Lib/site-packages.
I have warning :
[cmake] ...\vcpkg-registry\ports/PROJECT/<IP_ADDRESS>\portfile.cmake: warning: There should be no absolute paths, such as the following, in an installed package. To suppress this message, add set(VCPKG_POLICY_SKIP_ABSOLUTE_PATHS_CHECK enabled)
[cmake] note: D:\vcpkg\packages
[cmake] note: ...\build\vcpkg_installed
[cmake] note: D:\vcpkg\buildtrees
[cmake] note: D:\vcpkg\downloads
[cmake] note: Absolute paths were found in the following files
[cmake] D:\vcpkg\packages\PROJECT_x64-wsmep: note: the files are relative to ${CURRENT_PACKAGES_DIR} here
[cmake] note: debug/tools/python3/Lib/site-packages/PROJECT/lib/cmake/PROJECT-<IP_ADDRESS>_static/PROJECTConfig.cmake
[cmake] note: debug/tools/python3/Lib/site-packages/PROJECT/lib/cmake/PROJECT-<IP_ADDRESS>_static/PROJECTTargets-relwithdebinfo.cmake
[cmake] note: tools/python3/Lib/site-packages/PROJECT/lib/cmake/PROJECT-<IP_ADDRESS>_static/PROJECTConfig.cmake
[cmake] note: tools/python3/Lib/site-packages/PROJECT/lib/cmake/PROJECT-<IP_ADDRESS>_static/PROJECTTargets-relwithdebinfo.cmake
[cmake] ...\vcpkg-registry\ports/PROJECT/<IP_ADDRESS>\portfile.cmake: warning: Found 5 post-build check problem(s). These are usually caused by bugs in portfile.cmake or the upstream build system. Please correct these before submitting this port to the curated registry.

To fix it, I need to launch
  vcpkg_cmake_config_fixup(
    PACKAGE_NAME "PROJECT" CONFIG_PATH
    "tools/python3/Lib/site-packages/PROJECT/lib/cmake"
  )

My problem it that all CMake files are moved to  ${CURRENT_PACKAGES_DIR}/share instead of ${CURRENT_PACKAGES_DIR}/tools/python3/Lib/site-packages/PROJECT/share
Expected behavior
Be able to use vcpkg_cmake_config_fixup so that all CMake files are moved to ${CURRENT_PACKAGES_DIR}/tools/python3/Lib/site-packages/PROJECT/share.
Solution
Patch vcpkg-cmake-config to support following syntax:
  vcpkg_cmake_config_fixup(
    PACKAGE_NAME "PROJECT" CONFIG_PATH
    "tools/python3/Lib/site-packages/PROJECT/lib/cmake/PROJECT-${VERSION}${suffix}"
    TARGET_PATH "tools/python3/Lib/site-packages/PROJECT/share/PROJECT"
  )

Fixing vcpkg_cmake_config_fixup is quite easy. If my problem and my solution are fine, I can make a PR.

cc @vicroms @BillyONeal Could you please help take a look?

My problem it that all CMake files are moved to ${CURRENT_PACKAGES_DIR}/share instead of ${CURRENT_PACKAGES_DIR}/tools/python3/Lib/site-packages/PROJECT/share

If they were in that location they can't be found, so I'm not sure what you're trying to do with that.

I want to create two Python modules A and B. B depends on A.
A and B are in C++ and uses external dependencies. These dependencies are managed by vcpkg.
When building B module, I would like to use the A module with its header and its CMake target files.
As I use pip install . to build the B module, I need to use the A module installed in ${CURRENT_PACKAGES_DIR}/tools/python3/Lib/site-packages/PROJECT_A.
I will start working on this problem today. I will tell you if adding a TARGET_PATH parameter in vcpkg_cmake_config_fixup is sufficient or the good solution.

The problem is that vcpkg_cmake_config_fixup's purpose is to make the resulting configs work from vcpkg's toolchain file, and it will never ever look in ${CURRENT_PACKAGES_DIR}/tools/python3/Lib/site-packages. It will only look in ${CURRENT_PACKAGES_DIR}/share, which is why vcpkg_cmake_config_fixup moves the files there. Is pip trying to invoke cmake somehow?

Yes, pip invokes CMake via the extension cmake-build-extension.

It's more complicated than I thought. I want to use the system python.
So I don't want to install in ${CURRENT_PACKAGES_DIR}/tools/python3/Lib/site-packages but in the system python (which is a virtual environment in my case).
I don't think that vcpkg has a way to know which is the current python executable.

I don't think that vcpkg has a way to know which is the current python executable.

For ports depending on a particular version of python, a dependency on python3 is the key to ABI tracking and the injection point for user-provided overlay ports.
Things get tricky when the target triplet is not the host triplet.


503 between services deployed on a VM even with authentication disabled

Bug description
I've deployed Bookinfo on a VM, and it works fine. As soon as I install Istio in a GKE cluster, and I install Istio on the VM, the service-to-service communication breaks, with 503 errors such as this one, from curl running in a Pod in the GKE cluster, and from the Istio logs on the VM:
$ curl -v productpage.default.svc.cluster.local:9080
* Rebuilt URL to: productpage.default.svc.cluster.local:9080/
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to productpage.default.svc.cluster.local (<IP_ADDRESS>) port 9080 (#0)
> GET / HTTP/1.1
> Host: productpage.default.svc.cluster.local:9080
> User-Agent: curl/7.58.0
> Accept: */*
>
< HTTP/1.1 503 Service Unavailable
< content-length: 190
< content-type: text/plain
< date: Mon, 31 May 2021 20:18:30 GMT
< server: envoy
<
* Connection #0 to host productpage.default.svc.cluster.local left intact
upstream connect error or disconnect/reset before headers. reset reason: connection failure, transport failure reason: TLS error: 268435703:SSL routines:OPENSSL_internal:WRONG_VERSION_NUMBER

[2021-05-31T20:18:30.595Z] "GET / HTTP/1.1" 503 UF,URX upstream_reset_before_response_started{connection_failure,TLS_error:_268435703:SSL_routines:OPENSSL_internal:WRONG_VERSION_NUMBER} - "TLS error: 268435703:SSL

This is true for all the services of the bookinfo app deployed on the VM, regardless of accessing them directly, or if exposed via an Istio gateway running in the GKE cluster. I can still access the services from localhost on the VM directly:
$ curl -v localhost:9083
* Rebuilt URL to: localhost:9083/
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to localhost (<IP_ADDRESS>) port 9083 (#0)
> GET / HTTP/1.1
> Host: localhost:9083
> User-Agent: curl/7.58.0
> Accept: */*
>
< HTTP/1.1 200 OK
< content-type: text/html; charset=utf-8
< content-length: 1683
< server: envoy
< date: Mon, 31 May 2021 20:57:23 GMT
< x-envoy-upstream-service-time: 3
<
<!DOCTYPE html>
<html>
....

If I stop istio on the VM (systemctl stop istio), I can access the services again from the VM public IP.
If I disable the peer authentication and mTLS (see below to reproduce), I'm able to access the services with curl, but the services cannot communicate with each other:
DEBUG:urllib3.connectionpool:http://reviews:9080 "GET /reviews/0 HTTP/1.1" 503 91
DEBUG:urllib3.connectionpool:Starting new HTTP connection (1): reviews:9080
send: b'GET /reviews/0 HTTP/1.1\r\nHost: reviews:9080\r\nuser-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.77 Safari/537.36\r\nAccept-Encoding: gzip, deflate\r\nAccept: */*\r\nConnection: keep-alive\r\nX-B3-TraceId: 6ef28298d8a3b8f4\r\nX-B3-SpanId: 6ef28298d8a3b8f4\r\nX-B3-Sampled: 1\r\n\r\n'
reply: 'HTTP/1.1 503 Service Unavailable\r\n'
header: content-length: 91
header: content-type: text/plain
header: date: Tue, 01 Jun 2021 14:31:40 GMT
header: server: istio-envoy
header: x-envoy-decorator-operation: :0/*
DEBUG:urllib3.connectionpool:http://reviews:9080 "GET /reviews/0 HTTP/1.1" 503 91

[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Expected behavior

Istio should take care of configuring authenticatiion between services, without the need to explicitly disable it.
Istio should allow plaintext communications, but this was not the case. I had to disable authentication entirely (PERMISSIVE was not enough).
Istio should allow service-to-service communication in the above scenarios.

Steps to reproduce the bug
(for info, I also attached the output of istioctl bug-report

Provision a GCE VM, and open the 9080-9084 TCP port ranges in the firewall.
Deploy bookinfo with docker compose on the GCE VM: docker-compose -f bookinfo.yaml up -d

bookinfo.yaml
---
version: '3'
services:
  details:
    image: istio/examples-bookinfo-details-v1:1.16.2
    expose:
      - "9080"
    ports:
      - "9082:9080"
  productpage:
    image: istio/examples-bookinfo-productpage-v1:1.16.2
    expose:
      - "9080"
    ports:
      - "9083:9080"
  ratings:
    image: istio/examples-bookinfo-ratings-v1:1.16.2
    expose:
      - "9080"
    ports:
      - "9081:9080"
  reviews:
    image: istio/examples-bookinfo-reviews-v3:1.16.2
    expose:
      - "9080"
    ports:
      - "9084:9080"
...

Verify that it works if you try to load productpage from the external IP
Provision a GKE cluster.
Install Istio (see below) in the GKE cluster and in the GCE VM
Deploy a Gateway

---
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
  name: default-gateway
  namespace: istio-system
spec:
  selector:
    istio: ingressgateway # use Istio default gateway implementation
  servers:
    - port:
        number: 80
        name: http
        protocol: HTTP
      hosts:
        - "*"
...

Deploy the following WorkloadEntries (add the public IP of the GCE VM first):

---
apiVersion: networking.istio.io/v1alpha3
kind: WorkloadEntry
metadata:
  name: productpage
spec:
  address: # PUBLIC IP OF THE GCE VM
  labels:
    app: productpage
    instance-id: source-environment-vm
  serviceAccount: bookinfo-gce
...
---
apiVersion: networking.istio.io/v1alpha3
kind: WorkloadEntry
metadata:
  name: details
spec:
  address: # PUBLIC IP OF THE GCE VM
  labels:
    app: details
    instance-id: source-environment-vm
  serviceAccount: bookinfo-gce
...
---
apiVersion: networking.istio.io/v1alpha3
kind: WorkloadEntry
metadata:
  name: ratings
spec:
  address: # PUBLIC IP OF THE GCE VM
  labels:
    app: ratings
    instance-id: source-environment-vm
  serviceAccount: bookinfo-gce
...
---
apiVersion: networking.istio.io/v1alpha3
kind: WorkloadEntry
metadata:
  name: reviews
spec:
  address: # PUBLIC IP OF THE GCE VM
  labels:
    app: reviews
    instance-id: source-environment-vm
  serviceAccount: bookinfo-gce
...

Deploy the following ServiceEntries:

---
apiVersion: networking.istio.io/v1alpha3
kind: ServiceEntry
metadata:
  name: productpage
spec:
  hosts:
    - productpage
    - productpage.default.svc.cluster.local
  location: MESH_INTERNAL
  ports:
    - number: 9080
      name: http
      protocol: HTTP
      targetPort: 9083
  resolution: STATIC
  workloadSelector:
    labels:
      app: productpage
...
---
apiVersion: networking.istio.io/v1alpha3
kind: ServiceEntry
metadata:
  name: details
spec:
  hosts:
    - details
    - details.default.svc.cluster.local
  location: MESH_INTERNAL
  ports:
    - number: 9080
      name: http
      protocol: HTTP
      targetPort: 9082
  resolution: STATIC
  workloadSelector:
    labels:
      app: details
...
---
apiVersion: networking.istio.io/v1alpha3
kind: ServiceEntry
metadata:
  name: ratings
spec:
  hosts:
    - ratings
    - ratings.default.svc.cluster.local
  location: MESH_INTERNAL
  ports:
    - number: 9080
      name: http
      protocol: HTTP
      targetPort: 9081
  resolution: STATIC
  workloadSelector:
    labels:
      app: ratings
...
---
apiVersion: networking.istio.io/v1alpha3
kind: ServiceEntry
metadata:
  name: reviews
spec:
  hosts:
    - reviews
    - reviews.default.svc.cluster.local
  location: MESH_INTERNAL
  ports:
    - number: 9080
      name: http
      protocol: HTTP
      targetPort: 9084
  resolution: STATIC
  workloadSelector:
    labels:
      app: reviews
...

Deploy the following VirtualServices:

---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: productpage
spec:
  hosts:
    - "*"
  gateways:
    - istio-system/default-gateway
  http:
    - match:
        - uri:
            exact: /productpage
        - uri:
            exact: /login
        - uri:
            exact: /logout
        - uri:
            prefix: /api/v1/products
        - uri:
            prefix: /static
      route:
        - destination:
            host: productpage.default.svc.cluster.local
...
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: details
spec:
  hosts:
    - details
  http:
    - route:
      - destination:
          host: details.default.svc.cluster.local
...
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: ratings
spec:
  hosts:
    - ratings
  http:
    - route:
      - destination:
          host: ratings.default.svc.cluster.local
...
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: reviews
spec:
  hosts:
    - reviews
  http:
    - route:
      - destination:
          host: reviews.default.svc.cluster.local
...

To disable peer authentication and mTLS:

---
apiVersion: security.istio.io/v1beta1
kind: PeerAuthentication
metadata:
  name: default
  namespace: default
spec:
  mtls:
    mode: DISABLE
...
---
apiVersion: networking.istio.io/v1alpha3
kind: DestinationRule
metadata:
  name: productpage-short
spec:
  host: productpage
  trafficPolicy:
    tls:
      mode: DISABLE
...
---
apiVersion: networking.istio.io/v1alpha3
kind: DestinationRule
metadata:
  name: details-short
spec:
  host: details
  trafficPolicy:
    tls:
      mode: DISABLE
...
---
apiVersion: networking.istio.io/v1alpha3
kind: DestinationRule
metadata:
  name: ratings-short
spec:
  host: ratings
  trafficPolicy:
    tls:
      mode: DISABLE
...
---
apiVersion: networking.istio.io/v1alpha3
kind: DestinationRule
metadata:
  name: reviews-short
spec:
  host: reviews
  trafficPolicy:
    tls:
      mode: DISABLE
...

Version (include the output of istioctl version --remote and kubectl version --short and helm version --short if you used Helm)
client version: 1.10.0
control plane version: 1.10.0
data plane version: 1.10.0 (5 proxies)

Client Version: v1.21.1
Server Version: v1.20.6-gke.1000
[bug-report.tar.gz](https://github.com/istio/istio/files/6580204/bug-report.tar.gz)

How was Istio installed?
With istioctl
---
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
  name: istio
spec:
  components:
    ingressGateways:
      - name: istio-eastwestgateway
        label:
          istio: eastwestgateway
          app: istio-eastwestgateway
        enabled: true
        k8s:
          env:
            # sni-dnat adds the clusters required for AUTO_PASSTHROUGH mode
            - name: ISTIO_META_ROUTER_MODE
              value: "sni-dnat"
          service:
            ports:
              - name: status-port
                port: 15021
                targetPort: 15021
              - name: tls
                port: 15443
                targetPort: 15443
              - name: tls-istiod
                port: 15012
                targetPort: 15012
              - name: tls-webhook
                port: 15017
                targetPort: 15017
  meshConfig:
    defaultConfig:
      proxyMetadata:
        # Enable basic DNS proxying
        ISTIO_META_DNS_CAPTURE: "true"
        # Enable automatic address allocation
        ISTIO_META_DNS_AUTO_ALLOCATE: "true"
      tracing:
        zipkin:
          address: zipkin.istio-system:9411
  values:
    global:
      meshID: mesh1
      multiCluster:
        clusterName: "Kubernetes"
      network: ""
...

On the VM, I installed Istio by following Istio VM setup and the following workload-group.yaml and VM_NAMESPACE=default:
---
apiVersion: networking.istio.io/v1alpha3
kind: WorkloadGroup
metadata:
  name: bookinfo
  namespace: default
spec:
  metadata:
    labels:
      app: bookinfo
  template:
    serviceAccount: bookinfo-gce
    network: ""
...

Environment where the bug was observed (cloud vendor, OS, etc)
Google Kubernetes Engine, Google Compute Engine
Additionally, please consider running istioctl bug-report and attach the generated cluster-state tarball to this issue.
Refer cluster state archive for more details.
DONE
bug-report.tar.gz

@ferrarimarco I had the same issue. Can you make sure port 9080 is open on the security group attached to the worker nodes

I double checked, and yes, that port is open. Thanks!


[opencv] add nonfree as feature for opencv

What could be the reason to build opencv_contrib package, but not the opencv itself with its support?
Wouldn't be sufficient to enable OPENCV_ENABLE_NONFREE switch if user has selected the contrib feautre?

What could be the reason to build opencv_contrib package, but not the opencv itself with its support?
Wouldn't be sufficient to enable OPENCV_ENABLE_NONFREE switch if user has selected the contrib feautre?
Just to give the users who love freesofeware

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: cyyever sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for the PR, @cyyever!


For NLQ2SPARQL: When the ontology grows too large, the accuracy of recalling the entities of the ontology drops.

Currently, in order to advance "Converting Natural Language Query to SPARQL query," we offer the ontology as a representation of the database frame work , serving as the context for ChatGPT. However, when the ontology grows too large, the accuracy in recalling the entities of the ontology decreases. Therefore, we should find a solution to manage an oversized ontology.
This follows Issue https://github.com/DDMAL/linkedmusic-datalake/issues/161

Let's take an example, there is an ontology accessible from SPARQL Endpoint http://www.usources.cn:8891/sparql
The graph name (Default Data Set Name) is http://ont.library.sh.cn/graph/ccmusic_lit_inf.

Now another refined method is about "Sub-Grarph Extraction". we prompt Gpt this way:

Extract Classes and Properties from the Ontology

Given an ontology:

the OWL code...

--Base on the above ontology, please extract classes or properties by analysing the natural language question: "有哪些特藏独立资源_作品是涉及顺化市（顺化市作为一个地域类）的？这些特藏独立资源_作品分别对应什么“音乐类型(乐种)”和乐器？"
(The classes and properties should be matched with the entities in the above ontology.)

Then prompt chatGPT to convert that natural language again to SPARQL:

Given an ontology:

@prefix rdf:	<http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
@prefix bf:	<http://id.loc.gov/ontologies/bibframe/> .
@prefix owl:	<http://www.w3.org/2002/07/owl#> .
@prefix rdfs:	<http://www.w3.org/2000/01/rdf-schema#> .
@prefix ctm:	<https://lib.ccmusic.edu.cn/ontologies/chinese_traditional_music#> .
@prefix mo:	<http://purl.org/ontology/mo/> .

bf:Place
	rdf:type	owl:Class ;
	rdfs:label	"\u5730\u57DF" , "\u5730\u70B9" .
ctm:SpecialIndependentResource
	rdf:type	owl:Class ;
	rdfs:label	"\u7279\u85CF\u72EC\u7ACB\u8D44\u6E90_\u4F5C\u54C1" , "\u9986\u85CF\u4F5C\u54C1" .
ctm:MusicType
	rdf:type	owl:Class ;
	rdfs:label	"\u97F3\u4E50\u7C7B\u578B(\u4E50\u79CD)" , "\u4E50\u79CD" .
ctm:OrientalMusicalInstrument
	rdf:type	owl:Class ;
	rdfs:label	"\u4E1C\u65B9\u4E50\u5668" .
ctm:relatesInstrument
	rdf:type	rdf:Property ;
	rdfs:label	"\u7279\u85CF\u72EC\u7ACB\u8D44\u6E90\u6D89\u53CA\u2026\u4E50\u5668" ;
	rdfs:domain	ctm:SpecialIndependentResource ;
	rdfs:range	ctm:OrientalMusicalInstrument , mo:Instrument ;
	rdfs:comment	"\u6307\u4E00\u4E2A\"\u7279\u85CF\u72EC\u7ACB\u8D44\u6E90_\u4F5C\u54C1\"\u6D89\u53CA\u7684\u4E1C\u65B9\u4E50\u5668" .
ctm:relatesMusicType
	rdf:type	rdf:Property ;
	rdfs:label	"\u7279\u85CF\u72EC\u7ACB\u8D44\u6E90\u6D89\u53CA\u2026\u97F3\u4E50\u7C7B\u578B(\u4E50\u79CD)" ;
	rdfs:domain	ctm:SpecialIndependentResource ;
	rdfs:range	ctm:MusicType ;
	rdfs:comment	"\u6307\"\u7279\u85CF\u72EC\u7ACB\u8D44\u6E90_\u4F5C\u54C1\"\u6D89\u53CA\u67D0\u97F3\u4E50\u7C7B\u578B(\u4E50\u79CD)" .
ctm:relatesPlace
	rdf:type	rdf:Property ;
	rdfs:label	"\u7279\u85CF\u72EC\u7ACB\u8D44\u6E90\u6D89\u53CA\u2026\u5730\u57DF" ;
	rdfs:domain	ctm:SpecialIndependentResource ;
	rdfs:range	bf:Place ;
	rdfs:comment	"\u6307\"\u7279\u85CF\u72EC\u7ACB\u8D44\u6E90_\u4F5C\u54C1\"\u6D89\u53CA\u67D0\u5730\u57DF\u6216\u5730\u70B9" .
mo:Instrument
	rdf:type	owl:Class ;
	rdfs:label	"\u4E50\u5668" .

–Base on the above ontology, please provide a SPARQL query for the natural language question: “有哪些特藏独立资源_作品是涉及顺化市（顺化市作为一个地域类）的？这些特藏独立资源_作品分别对应什么“音乐类型(乐种)”和乐器？”
Then, see the result:
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX bf: <http://id.loc.gov/ontologies/bibframe/>
PREFIX ctm: <https://lib.ccmusic.edu.cn/ontologies/chinese_traditional_music#>
PREFIX mo: <http://purl.org/ontology/mo/>

SELECT ?specialResource ?musicType ?instrument
WHERE {
  ?specialResource rdf:type ctm:SpecialIndependentResource ;
                   ctm:relatesPlace ?place ;
                   ctm:relatesMusicType ?musicType ;
                   ctm:relatesInstrument ?instrument .

  ?place rdf:type bf:Place ;
         rdfs:label "顺化市" .
}

Execute the SPARQL on the Chinese Traditional Knowledge Database http://www.usources.cn:8080/dcmusic/sparql

Don't forget to activate the reasoning rules. define input:inference 'urn:owl.ccmusicrules' above all the other SPARQL code.

Advantage:
(1)It can always returns results even if it's only similar (not the precise one)
Disadvantage or things to be explored:
(1)It requires the class/type assertion of instances.
(2)I am not sure if it's applicable across different graphs.


ExecJs::RuntimeError

ExecJS::RuntimeError in Teachers#index
Showing E:/Ruby_workspace/Others/KhunCool/app/views/layouts/application.html.erb where line #6 raised:
䌧尺坜湩潤獷屜祓瑳浥㈳屜獣牣灩⹴硥履‧獩渠瑯爠捥杯楮敺獡愠湩整湲污漠⁲硥整湲污挠浯慭摮ബ漊数慲汢牰杯慲牯戠瑡档映汩⹥਍
(in E:/Ruby_workspace/Others/KhunCool/app/assets/javascripts/teachers.js.coffee)
Extracted source (around line #6):
3:
4:   KhunCool
5:   <%= stylesheet_link_tag    "application" %>
6:   <%= javascript_include_tag "application" %>
7:   <%= csrf_meta_tags %>
8:
9:
This error occurs after I created scaffold Teacher and went to localhost:3000/teachers. what should I do with this problem? I use rails 3.1 and the verison of execjs is 1.2.8 .

Still have the same problem running execjs is 1.2.8 and 1.2.9.

Still i have the problem. I am using 1.2.12


Remove warnings

This includes Ross' PR #89
I've got an instance of #[allow(dead_code)] at the TCP close function.  It's needed to avoid the tests hanging, but it's telling that it's unused in the main codebase.  This could well be the cause of the hanging thread causing the Windows issue #84.
Once I get to the bottom of the issue I expect the close function will be getting used then, and the #[allow...] can go away.
There are also many places where I'm ignoring the result of thread::spawn calls, but again I'll be looking at these while debugging the Windows issue.

Reviewed files:

examples/crust_node.rs @ r1
src/beacon.rs @ r1
src/bootstrap.rs @ r1
src/connection_manager.rs @ r1
src/lib.rs @ r1
src/tcp_connections.rs @ r1
src/transport.rs @ r1

src/bootstrap.rs, line 40 [r1] (raw file):
Excellent

src/connection_manager.rs, line 743 [r1] (raw file):
Do you do this to force a join ? seems like a neat trick

Comments from the review on Reviewable.io

src/lib.rs, line 22 [r1] (raw file):
Every lib should do this now Ross

Comments from the review on Reviewable.io

Changes Unknown when pulling abe18ec4a4a78be98b39ead3ffaf75b881350600 on Fraser999:remove_warnings into ** on dirvine:master**.

src/connection_manager.rs, line 743 [r1] (raw file):
No - this is an example of one of the places where we just ignore the return and don't wait for the thread to join.  thread::scoped would cause the thread to join when the returned value is destroyed.
These are the red flags I'll be trying to get my head round while debugging #84

Comments from the review on Reviewable.io