Step Functions

Is your feature request related to a problem? Please describe.
Integrating Step Functions is not currently supported, but is something I find myself using
Describe the solution you'd like
I would love it if Step Functions were to become officially supported to be provisioned and given access in the Amplify CLI.
Describe alternatives you've considered
I'm currently manually integrating the CloudFormation behind the scenes, or alternately using Terraform as a completely separate side application which then gets called from Amplify Apps.
Additional context
AWS Step Functions is a very powerful solution for a lot of backend processes that I have behind the apps I write. To be able to natively use it in Amplify would be such a big time saver. Looks like the CloudFormation itself for it is pretty easy, but using Lambdas in the state machine is something I'm still figuring out and I'm guessing is the more difficult implementation blocker to overcome.

Is there any work being done on this? Worth submitting ideas / PR?

@andrestone Currently there isn’t work going on this. Would be great if you could submit a public RFC before working on a PR and get some comments from the core team and the community.

+1 for this.  Need step functions for use with Amplify CLI.

Can you give us information on your business use case? This will help us with future designs. For example "In my app I need to provide a checkout system, etc." Thanks

CRM Application.  Someone creates an issue, or is even just working an issue and changes a field on a Case... either scenario could kickoff a workflow.  Emails might need to be sent, tasks created and assigned, application wide notifications, the sky is the limit. At this point we are just evaluating the product but it seems like it might be a good fit.  So far we've been able to stick to using the amplify cli for everything and I was actually surprised to see that there was no support for step functions currently.

I'm also interested in Step functions.
My workflow is essentially request comes in -> identity check needs to be done on customer -> request assigned to appropriate person to fulfill -> request fulfilled -> "deliverable" shipped digitally or physically as appropriate -> communicate to customer -> charge customer card -> after a week send NPS score request for feedback.
It's similar to e-commerce workflow: order comes in -> fraud check -> assign to appropriate fulfillment center -> ship the item -> charge customer.

Can someone please share their workarounds to integrate step functions into an Amplify application?
I just started learning about Amplify and would love to have a detailed guide on how that's done.

@cschow-ucsd I make step-functions working by creating a "Custom CloudFormation stacks". Similar to this this but for using Step Functions as orchestration instead of SNS topics for monitoring

@cschow-ucsd I make step-functions working by creating a "Custom CloudFormation stacks". Similar to this this but for using Step Functions as orchestration instead of SNS topics for monitoring

Thanks! I have it working following the docs and a couple of examples at Github:
https://github.com/aws-samples/aws-etl-orchestrator/blob/master/cloudformation/step-functions-resources.yaml
https://github.com/widdix/aws-step-functions-example/blob/master/template.yml
I'm curious when this would be released. There are some plans on supporting this, right? It was a pain in the... fingers... to make it work doing it manually (it cost me 3 complete days to do this without previous CloudFormation knowledge).
My use case is to schedule some processes to be run a couple of minutes after, to check some flags, and then act in consequence to that. I've done that using EventBridge rules but it has some absurd limitations that cannot scale well.
I think we can write the state machine definition ourselves when doing the generation of the templates, but it would be great to have the rest automated as is in the other implementations (common things like role generation, environments, outputs, parameters, etc).

+1 for Step functions with Amplify, as well as SNS and SQS! Currently, I'm using custom CF for adding SNS, and SQS, and will do the same for a workflow, but would be natural to be able to add them all through CLI.

Hi for to the recent commenters on this thread - could you give more details on your use case and the application you're trying to build? We're interested in the specific use case as it pertains to a mobile or web application as this will help use scope design in the future. We don't have a timeline but this will help investigate.

Hi for to the recent commenters on this thread - could you give more details on your use case and the application you're trying to build? We're interested in the specific use case as it pertains to a mobile or web application as this will help use scope design in the future. We don't have a timeline but this will help investigate.

Hi @undefobj ,
In our case, the particular application is like a multi-sided platform, that schedules events (interviews) between candidates and organizations. During that process a workflow is supposed to move candidates' applications through different stages. In that process the system will send SMS messages, SNS notifications, update status and move applicants through different stages as the requirements are completed, or not.
The application will be served on different devices, but I wouldn't say that it's predominantly a mobile app that we're building.
Not sure if this gives enough information, and the idea about the type of application we're building?
In the past I was part of the team that built a mortgage advancing application, that used FileNet (later IBM) Visual Workflow, which in a similar fashion moved objects through a workflow based on multitude of conditions. So, I'm looking for a similar usage.

In our case we use a state machine for AWS Account creation as part of an Account Vending Machine.
We are working on an Angular frontend for this Account Vending Machine with Amplify.
I ended up using the AWS API Gateway calling the step functions API.
I have build a custom REST API with amplify "Custom CloudFormation stacks" which calls the step functions API.
Building this custom REST API was a bit cumbersome  as the Amplify documentation is not that expressive about how to do that. The most difficult part was to get de api endpoint automatically in the aws-exports.js file when I preform an amplify push .
I eventually added a rest api with the amplify cli amplify add api and replaced the generated cloudformation code with my custom cloudformation code. This way when I perform an amplify push the endpoint is automatically added to the "aws_cloud_logic_custom" entry in the aws-exports file. I don't think this is the intended way to go but it works and I haven't found another way yet.
Perhaps it's an idea that on adding a REST API with the amplify cli you could also choose to integrate with other AWS Services like Step Functions.

+1 for step functions with amplify. Is there anyway to see if this feature is currently being looked at, or if it's included in a roadmap / feature update?

+1

+1.. I need to build an order management system.

+1

+1 We have two use-cases:

Synthetic "big" data generator
Custom glue orchestration (in fact, being able to describe glue config via Amplify would also be awesome)

+1
Any update on this feature? It will be really helpful to integrate Step functions with amplify.

+1
Any update on this feature? It will be really useful to have step functions integration with amplify.

+1

Use case for us with Step Functions (and SNS/SQS).
When a user visits the site and signs up, we want to send them a welcome email or text, along with a reminder email or text with some further prompts after a certain amount of time if they haven't further engaged with the site. For the case where we want to send a reminder, Step Functions are very handy, b/c they can be used as a kind of "cron" to wait a given amount of time before processing further, i.e. before kicking off the process that sends a message. The SQS parts of the flow are useful for storing large amounts of messages, so that the process will scale.
The flow generally looks like:
User sign-up -> DynamoDB Stream -> Lambda -> SQS -> Lambda -> Step Functions -> SQS -> Lambda -> SNS -> Email/Text to user
Currently, we have this workaround where set up and maintain this stack using the Serverless framework, and it's a pain to manage this stack in parallel to the front-end/API which are in Amplify. But we do use some of the output of the Amplify deployment (such as the DynamoDB stream ID) as inputs for the Serverless stack, which is brittle, especially when other devs want to stand up their own personal version of the stack. Ideally, we would want this stack to be a part of our Amplify CI/CD. Also, it is hard to test this stack in conjunction with front-end work. Admittedly, we are also kicking off the deploy of this stack manually, which is a pain, we just haven't had the time or resources to invest in a better way. So if there was a straightforward way to spin up this stack, it would be greatly preferred.

+1

+1
Use case for Step Functions
We are trying to make machine learning as easy as possible for people using SQL through Amazon Athena. We want to provide a unified experience for data analysts to leverage SageMaker from our SQL Interface.
User flow:
User writes a SQL query with the target column and then submits a model training job.
SQL Query + Target Column -> Step Function -> [create athena query execution -> write query to S3 -> Start SageMaker Autopilot job -> package model -> deploy endpoint] -> user makes predictions with Athena ML.
So far, we have not built anything yet but our assumption is that a Lambda function can trigger our state machine.

+1

This would be something we'd love to have.
Heavy users of both Amplify and Step Functions - not as much in combination, unfortunately - as we always have to set up the Step Functions manually and then make sure we have the right permissions on the Lambdas.

+1

+1 for step functions with Amplify

+1

+1

Would be great to see this included. I have a bit of a hybrid system where one Dynamo record can be updated by two different sources. Step functionality would allow me to only run certain lambda functions depending on the originating source (API Gateway triggers a lambda function to update a record; Dynamo Stream then fires another lambda function that sends an API request to a third party)

+1

+2

+1

+1

To add an extra use case I'm using Wait in Step functions to be able to trigger lambda functions in the future.
For example, I need to send a push notification to a user in 2 days to remind them of something.

@johnf one option for your use case is to use dynamo table with TTL property and stream it to a lambda. See https://theburningmonk.com/2019/03/dynamodb-ttl-as-an-ad-hoc-scheduling-mechanism/

Given AppSync limit for queries at 30 sec, there are no reliable alternatives to Step Functions for long-running queries or mutations.
https://dev.to/aws-builders/how-to-call-aws-step-functions-from-aws-amplify-21lm - great example how to implement with CDK
There is a fair amount of VTL pain, if Amplify team could take care of it and have SFN native integration - that would be Amazing addition.


Add support native window.Promise without wrap

Could we use window.Promise without such wrapper in users code:
var storage = new CrossStorageClient('http://localhost:3000/hub.html', {
promise: (typeof Promise !== 'undefined') ? Promise : require('es6-promise').Promise
});

What if I wanted to pass Bluebird or RSVP, rather than the default Promise implementation or a polyfill?

Gonna close for now. It needs to be flexible enough for a user to supply their own promise implementation even if supported by the browser. Also, you don't need to do:
var storage = new CrossStorageClient('http://localhost:3000/hub.html', {
  promise: (typeof Promise !== 'undefined') ? Promise : require('es6-promise').Promise
});

You can just do:
require('es6-promise').polyfill();
var storage = new CrossStorageClient('http://localhost:3000/hub.html');

It'll only update the global Promise object if a complete implementation doesn't exist: https://github.com/jakearchibald/es6-promise/blob/master/lib/es6-promise/polyfill.js#L21-L23


chore(main): release 1.0.2

:robot: I have created a release beep boop
1.0.2 (2024-04-09)
Bug Fixes

deps: bump github.com/stretchr/testify from 1.8.4 to 1.9.0 (#20) (a955786)
deps: bump golang.org/x/net from 0.21.0 to 0.22.0 (#19) (517a4f0)
deps: bump golang.org/x/net from 0.22.0 to 0.24.0 (#23) (d5fb585)
deps: bump golang.org/x/oauth2 from 0.16.0 to 0.17.0 (#16) (abd3e18)
deps: bump golang.org/x/oauth2 from 0.17.0 to 0.19.0 (#24) (8aeea5c)
deps: bump gopkg.in/dnaeon/go-vcr.v3 from 3.1.2 to 3.2.0 (#22) (593ebe7)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/shanduur/labeler/releases/tag/v1.0.2 :sunflower:


negative margin results in overflow for grid on smaller screens

You can see this problem even on the demo page if you look at it on a smaller screen(e.g. 320px width). A scrollbar will appear and you can scroll to the right because of the negative margin for every .grid
One option maybe would be to refactor the grid gutter, so that it does not need this negative space trick, but instead uses some more complex selectors to address the first and last column (also will writing this i have to admit that might be impossible, as you never know what the last colum is ;) ) Maybe there is another option, or if everything fails just clear the negative margin for smaller screens.
Tested on FF latest, windows 10. (should be the same in every browser)

as a quick fix: body { overflow-x:hidden } would also work

Yep, because of negative margins... no alternative :(
but yes, overflow-x is the better way to prevent scrollbar


[FLINK-10872] Extend SQL client end-to-end to test KafkaTableSink for kafka connector 0.11

What is the purpose of the change
This pull request extends SQL client end-to-end to test KafkaTableSink for kafka connector 0.11
Brief change log

Extend SQL client end-to-end to test KafkaTableSink for kafka connector 0.11

Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@twalthr I cherry-picked your refactor about FLINK-10624 and squashed them so that I can process this issue in parallel. But I split it into a single commit. But in essence, it is still blocked by FLINK-10624.

cc @pnowojski

@pnowojski The travis was green before dropping the pre-commit change. I have deleted the commit.

Thank you @yanghua. Merging...


Implement MutatingWebhookConfiguration patch precheck

Description

Implement MutatingWebhookConfiguration patch precheck.
Reasons

MutatingWebhookConfiguration patch should not be performed on every reconciliation loop if configuration did not change comparing to what is offered by Istio chart in Kyma.
AC

[ ] MutatingWebhookConfiguration patch is performed when configuration is different to what is in Istio Kyma chart, skipped otherwise

Attachments

See: https://github.com/kyma-incubator/reconciler/issues/926

I'm closing it, as we will drop mwc patch soon.


Errors during iotivity-node installation. How to install iotivity-node properly?

Hello there!
I will be very specific and will divide my question into points.
I am running a Ubuntu 14.04 LTS machine with node.js on board
1. What I want to achieve in overall:
I want to install the iotivity-node npm package on my local computer
2. What is not working:
During the installation I get the following logs and errors:

<EMAIL_ADDRESS>install /usr/local/lib/node_modules/iotivity-node node-gyp rebuild
make: Entering directory `/usr/local/lib/node_modules/iotivity-node/build' ACTION Building CSDK iotivity-installed Cloning into '/usr/local/lib/node_modules/iotivity-node/iotivity-native'... remote: Counting objects: 3825, done remote: Finding sources: 100% (3825/3825) remote: Total 3825 (delta 281), reused 1993 (delta 281) Receiving objects: 100% (3825/3825), 13.87 MiB | 365.00 KiB/s, done. Resolving deltas: 100% (281/281), done. Checking connectivity... done. Note: checking out '0c90ca6ffcbb6a2c56c977ec11bebb7b1d14053b'.
You are in 'detached HEAD' state. You can look around, make experimental changes and commit them, and you can discard any commits you make in this state without impacting any branches by performing another checkout.
If you want to create a new branch to retain commits you create, you may do so (now or later) by using -b with the checkout command again.  System Linux 3.13.0-107-generic gyp ERR! command "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild" gyp ERR! cwd /usr/local/lib/node_modules/iotivity-node gyp ERR! node -v v6.4.0 gyp ERR! node-gyp -v v3.4.0 gyp ERR! not ok npm ERR! Linux 3.13.0-107-generic npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "-g" "iotivity-node" npm ERR! node v6.4.0 npm ERR! npm v3.10.8 npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: node-gyp rebuild npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'. npm ERR! Make sure you have the latest version of node.js and npm installed. npm ERR! If you do, this is most likely a problem with the iotivity-node package, npm ERR! not with npm itself. npm ERR! Tell the author that this fails on your system: npm ERR! node-gyp rebuild npm ERR! You can get information on how to open an issue for this project with: npm ERR! npm bugs iotivity-node npm ERR! Or if that isn't available, you can get their info via: npm ERR! npm owner ls iotivity-node npm ERR! There is likely additional logging output above.

3. Have you run across this issue while installing iotivity-node and if yes how you have resolved it? Thank you in advance for your answers.

@bart84 looks like there was an error cloning the tinycbor git repo. You should simply try again. Let me know if it keeps failing!

@bart84 looks like things have cleared up. If you're still running into errors, please open another issue!


Configuration: visualisation of duration

The user can activate/deactivate the visualisation of the duration.

The requested functionality is implemented. UI will be implemented at a later stage, therefore the issue is kept open.

The requested functionality is implemented. UI will be implemented at a later stage, therefore the issue is kept open.

The UI part of this issue has moved to https://github.com/IRT-Open-Source/imsced/issues/109. Otherwise, the core requirement of this issue has been met and it can be closed.


[Feature]Namesrv support get namesrv config (request code 319)

Namesrv support get namesrv config (request code 319)

Hey! Since i did the update of namesrv config could i pick up this one as well?

Hey! Since i did the update of namesrv config could i pick up this one as well?

Sure


Add drawer support for Operations that are not subclasses of Instruction

What should we add?
We need to support drawing circuits with any operation that is not an Instruction, and in particular with Cliffords and AnnotatedOperations. We also need to add tests.

@alexanderivrii This circuit
from qiskit import QuantumCircuit
from qiskit.quantum_info import Clifford, random_clifford
from qiskit.circuit.annotated_operation import AnnotatedOperation, InverseModifier, ControlModifier
from qiskit.circuit.library import SGate

qc = QuantumCircuit(3)
cliff = random_clifford(2)
qc.append(cliff, [0, 1])
qc.ccx(0, 1, 2)
op1 = AnnotatedOperation(SGate(), [InverseModifier(), ControlModifier(2)])
qc.append(op1, [0, 1, 2])
qc.draw('mpl')

produces

What additional info do you want to be displayed? Also I just noticed there's a bug in the 'text' drawer that crashes on this circuit. :-(


Show unsubmitted answers in review mode

At the moment, in review mode only the last submitted answer is shown. If you forget to submit an answer, it looks like you just didn't answer the part at all.
The student is shown warnings about unsubmitted answers, but nobody reads warnings.
Maybe we should be charitable and try submitting unsubmitted answers, and keep whichever of the last submitted answer and the unsubmitted answer gives most credit. This could lead to weird inconsistencies with adaptive marking or explore mode, though.
Or show the unsubmitted answer in a box next to the original input, like the "expected answer" box.
Or refuse to end the exam when there are unsubmitted answers. It's not clear what to do when the exam times out, though - allow the student to choose whether to submit unsubmitted answers, but otherwise not change anything?

How about accepting an unsubmitted answer, but only if there isn't already a last-submitted answer in that gap?

I can still see students complaining that they'd changed their answer, so why wasn't it recorded?

An idea: if there are any unsubmitted answers when trying to end the exam, don't end the exam. Like the "prevent" option for moving away from an unanswered question.

I've looked at this. There's an inconsistency between the review mode immediately after ending an exam, and when you resume an attempt in review mode.
If you submit an invalid answer and then end the exam, the invalid answer is still saved in part.studentAnswer, so is shown in the answer widget.
When the attempt is loaded, the part is marked as unanswered, so isn't submitted, and the invalid answer isn't saved to part.studentAnswer, so the answer widget is blank.


Test Occurrence Probability Routines

Need to add 'random' variables to pysat testing, with known properties, so that the seasonal occurrence probability routines can be tested.
Plan:

Add a signal to pysat_testing and pysat_testing2D that goes above a gate value some known percentage of the time. The percentage of times above the gate needs to vary spatially over longitude and latitude
Another signal that varies over 3D bins
Create tests that verifies the operation of the test signal as well as the seasonal occurrence routines.

This should be done before the next major release (2.0), since it will greatly improve the testing coverage.

This is easier to test without 'random' variables.  A sample is uploaded for the 2D occur_prob routines at https://github.com/rstoneback/pysat/blob/test_occur_prob/pysat/tests/test_ssnl_occur_prob.py
In both cases, I am looking at longitude and latitude as my x and y bins, and my gate selection is slt greater than 12.  As long as sufficient data is loaded (about a year in the code above), the by_orbit routine should return 0.5 within some tolerance for all bins (since over many precession cycles, all local times will be sampled equally), and the daily routine should return 1.0 (since at some point in a given day, it is afternoon somewhere).
Open issues for discussion:

The number of bins and amount of data will affect the tolerance.  In this case, a 3x3 grid and a year of testing data produce 0.5 \pm 0.01 in all bins.  Run time is about 1 min.  We can use more bins, but the tolerance increases as there are less points in each bin.
This can be generalized to the 3d case, but in a roundabout way.  Use slt as the third dimension and as the gate parameter.  In the simplest case, use two bins for slt, and 12 for the gate.  Barring some edge effects, the low bins should all be 0, and the high bins should all be 1.
Potentially, this could be adapted for the 2d bins as well, and look at latitude vs slt rather than longitude.

Thoughts?

Closed with merge of #188.


Is there any way I can add an argument to addField?

I have this in my model.
    public function center_room($center_id)
    {
        // return rooms which belongs to the center
        return Room::where('center_id', $center_id)->get();
    }

And I want to use it in addField, but I am not sure how to add an argument.
        $this->crud->addField([
            'name' => 'room_id',
            'label' => 'Room ID',
            'type' => 'select2',
            'entity' => 'center_room',
            'attribute' => 'name',
            'center_id' => $this->user->center_id,
            'model' => 'App\Models\Room'
        ])->beforeField('title');

Not without fiddling with the code a little.
You could probably put the center_id into the session and then extract it from the session though...

Hi @shinokada ,
If you pass center_id to addField() like that, it will be available in select2.blade.php as $field->center_id. You can overwrite the select2 field to take advantage of that, or maybe create a different field type for this particular purpose. Say... select2_room.
Hope it helps. Cheers!
PS. This is not a bug, nor a proposal, so I'll close the issue.


How to handle omvs functions not conforming to (the latest) posix standards?

When porting nano I came across the issue that realpath is not compliant to the current posix standard on omvs.
Posix.1-2008 descibes that it should accept the second parameter as a NULL value and that it should allocate a buffer using malloc in that case (https://pubs.opengroup.org/onlinepubs/9699919799/).
For z/os it does not conform to that standard (https://www.ibm.com/docs/en/zos/2.4.0?topic=functions-realpath-resolve-path-name) and will not accept the second parm as a NULL (giving an EINV response). I guess this was the expected behaviour in some earlier posix standard.
This leads to the following questions:

To what posix version is omvs suppost to be compliant?
Is there a commitment somewhere to get omvs compliant to a more recent version of the posix standard?
How should we resolve such an incompliantly behaving function:

Fix it in the code of the actual application
Fix it in zoslib until it is fixed in omvs
Fix it in a specific library that enhances existing functions to comply to more recent posix standard.

Also, I was reading about library interposing, in linux this can be done using LD_PRELOAD. Does omvs support the same concept?

My opinion would be that we add the function into zoslib so everyone porting can benefit and also raise an enhancement request to z/OS for them to improve the function going forward. That provides a practical as well as strategic approach to making progress.

I had the same idea, but I'm not sure if it is possible in this case (without changing the nano code), since realpath is a syscall. I'm not sure if it is possible to override a syscall with a function from a shared library with the same name and still be able to call the original syscall from that function.

Ah, it can be done using the syscall function as it seems

hmm, don't see a syscall function on omvs... So I guess it is possible to intercept the system call be providing a library function with the same name, but can you then still call the original syscall?

I might even be mistaken that realpath is a syscall. It is listed as a C/C++ library function. Would it be possible to override realpath in zoslib and load the actual realpath using dlsym as real_realpath?

So far it seems there is no syscall available and also RTLD_NEXT is not supported, so I don't think there is a way to actually 'wrap' the realpath function, at least not a way that I can find.

I think I may have found a way, that is to call BPX4RPH from the 'wrapper' function. I still have to test the idea further, but it looks promising. One issue is that it works in ebcdic, so the path and the returned path should be translated if the calling application is running in ascii. Is the idea of ports that they will always run in ascii, or should a solution be bimodal? Also, will it always be 64 bit, or should it also support 31 bit callers? Even if I get it to work, I wouldn't want to include it in zoslib, perhaps a zoscompatlib or something would be a better idea for 'enhancing' syscalls until omvs fixes it themselves?

note to self: https://github.com/libuv/libuv/blob/64669fdd8de8fce478e6ce1f7c954905f682c75b/src/unix/fs.c#L759

That’s great to hear. Hope it pans out. We are building everything 64-bit and ASCII. You could make it bimodal if you want. I have to think of the best way to do that but one way would be to check if the _BPX_AUTOCVT option is on. @IgorTodorovskiIBM probably has a better way. To convert from EBCDIC to ASCII you can use iconv

I can use __isASCII() to check if the thread is running in ascii. I'm having some issues building at the moment. Did the perl environment change? It seems the version in /etc/profile is not there anymore.

Hi
Hm. Nothing changed that I know of but I don’t use /etc/ for Perl - I use
zopen download to pull down my tools including Perl
On Sat, Nov 26, 2022 at 09:51 mfsysprog @.***> wrote:

I can use __isASCII() to check if the thread is running in ascii. I'm
having some issues building at the moment. Did the perl environment change?
It seems the version in /etc/profile is not there anymore.
—
Reply to this email directly, view it on GitHub
https://github.com/ZOSOpenTools/meta/issues/77#issuecomment-1328087896,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOSFFEMIJOCLBYMZS77OUELWKJEYJANCNFSM6AAAAAASF7TFOU
.
You are receiving this because you commented.Message ID:
@.***>

You could use the technique we use to override LE's open as in here: https://github.com/ibmruntimes/zoslib/blob/zopen/include/fcntl.h#L38 and https://github.com/ibmruntimes/zoslib/blob/zopen/src/zos-io.cc#L720
Right now we're building all our tools, including zoslib in 64-bit ASCII mode.

Yes, that should work! I'll see if I can add realpath that way.
Note to self:
offset for realpath at 884 for the debug.
@MikeFultonDev; When I add zoslib as a dependency it will download to zopen/prod, so if I clone zoslibport and add the change there that would be the easiest way to create a change in zoslib locally?
I have succesfully tested the concept by adding below code in one of the c files:
int pathmax_size(const char* path) {
  int pathmax;

  pathmax = pathconf(path, _PC_PATH_MAX);

  if (pathmax == -1)
    pathmax = PATH_MAX;

  return pathmax;

}

char *realpath(const char *restrict path, char *restrict resolved_path)
{
   char *ebcdic_path = malloc(strlen(path) + 1);
   strcpy(ebcdic_path, path);
   if (__isASCII()){
      __a2e_s(ebcdic_path);
   }
   int path_length=strlen(path);
   if (resolved_path == NULL){
      int len = pathmax_size(path);
      resolved_path = malloc(len + 1);
   }
   int path_resolved_length=strlen(resolved_path);
   int rv, rc, reason;
   BPX4RPH(&path_length, ebcdic_path, &path_resolved_length, resolved_path, &rv,
 &rc, &reason);
   free(ebcdic_path);
   if (rv == -1) {
      errno = rc;
      return NULL;
   }
   if (__isASCII()){
      __e2a_s(resolved_path);
   }
   return resolved_path;
}

Hi Hm. Nothing changed that I know of but I don’t use /etc/ for Perl - I use zopen download to pull down my tools including Perl
…
I made a change to Makefile.am, so it triggered the automake/autoconf stuff. But avoided that issue by adding the test code directly to one of the existing c files so I didn't need to change the Makefile.am

Hi, usually this is the process I follow when I want to test a change I made in zoslib with another dependency.

clone zoslibport and build it with zopen build
Make my changes in the zoslibport/zoslib dir and then rebuild with zopen build
Once installed, I move the ~/zopen/prod/zoslib-zopen* dir to ~/zopen/prod/zoslib so that it gets picked up by the dependent projects.
Rebuild my project that depends on zoslib
If all is ok, I create a PR against https://github.com/ibmruntimes/zoslib/tree/zopen

I'm getting an error when trying to build zoslibport:
CMake Error at /mfsyspg/zopen/prod/CMake-heads.v<IP_ADDRESS>21116_114743.zos/share/cmake-3.24/Modules/CMakeTestCXXCompiler.cmake:62 (message):
  The C++ compiler

    "/bin/xlclang++"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: /mfsyspg/zoslibport/zoslib/CMakeFiles/CMakeTmp

    Run Build Command(s):/mfsyspg/zopen/prod/make-4.3.20221111_144539.zos/bin/make -f Makefile cmTC_a5b5d/fast && /mfsyspg/zopen/prod/make-4.3.20221111_144539.zos/bin/make  -f CMakeFiles/cmTC_a5b5d.dir/build.make CMakeFiles/cmTC_a5b5d.dir/build
    make[1]: Entering directory '/mfsyspg/zoslibport/zoslib/CMakeFiles/CMakeTmp'
    Building CXX object CMakeFiles/cmTC_a5b5d.dir/testCXXCompiler.cxx.o
    /bin/xlclang++   -+ -qascii -qnocsect -qenum=int  -o CMakeFiles/cmTC_a5b5d.dir/testCXXCompiler.cxx.o -c /mfsyspg/zoslibport/zoslib/CMakeFiles/CMakeTmp/testCXXCompiler.cxx
    Linking CXX executable cmTC_a5b5d
    /mfsyspg/zopen/prod/CMake-heads.v<IP_ADDRESS>21116_114743.zos/bin/cmake -E cmake_link_script CMakeFiles/cmTC_a5b5d.dir/link.txt --verbose=1
    /bin/xlclang++ -+ -qascii -qnocsect -qenum=int  CMakeFiles/cmTC_a5b5d.dir/testCXXCompiler.cxx.o -o cmTC_a5b5d
    FSUM3010 Specify a file with the correct suffix (.C, .hh, .i, .c, .i, .s, .o, .x, .p, .I, or .a), or a corresponding data set name, instead of -o./cmTC_a5b5d.
    make[1]: *** [CMakeFiles/cmTC_a5b5d.dir/build.make:99: cmTC_a5b5d] Error 1
    make[1]: Leaving directory '/mfsyspg/zoslibport/zoslib/CMakeFiles/CMakeTmp'
    make: *** [Makefile:127: cmTC_a5b5d/fast] Error 2

Any idea why this is happening? Is my setup wrong somewhere?

https://www.ibm.com/docs/en/SSCH7P_3.8.0/python.pdf seems to have the answer:
If you see the following errors,
FSUM3010 Specify a file with the correct suffix (.C, .hh, .i, .c, .i, .s, .o, .x, .p, .I,
or .a), or a corresponding data set name....
export the following environment variables:
export _CC_CCMODE=1
export _CXX_CCMODE=1
export _C89_CCMODE=1
export _CC_EXTRA_ARGS=1
export _CXX_EXTRA_ARGS=1
export _C89_EXTRA_ARGS=1

Yes, that should fix it! That's why we added it to zopen's common.inc file: https://github.com/ZOSOpenTools/utils/blob/main/bin/lib/common.inc#L35

Ah thanks, I hadn't noticed the utils repo yet.

If you clone utils and set your PATH to utils/bin, then you should be able to do a zopen build -v in your zoslibport directory.

I must be doing something wrong, I just cannot get it to call the zoslib version of realpath I implemented.
I've basically added this to zos-bpx.cc:
char *__realpath_orig(const char __restrict__ *path, char __restrict__ *resolved_path) asm("@@A00187");

char *__realpath_extended(const char __restrict__ *path, char __restrict__ *resolved_path){
   if (resolved_path == NULL){
      resolved_path = (char*) malloc(pathmax_size(path) + 1);
   }
   return __realpath_orig(path, resolved_path);
}

When I call __realpath_extended from the nano code directly it works flawlessly, so the zoslib library is correctly linked.
When I use realpath from the nano code, it goes to the default realpath. These are the changed I made to the include/stdlib.h in zoslib:
diff --git a/include/stdlib.h b/include/stdlib.h
index bf6b4fa..f02ae7d 100644
--- a/include/stdlib.h
+++ b/include/stdlib.h
@@ -15,6 +15,7 @@
 #if defined(__cplusplus)
 extern "C" {
 #endif
+__Z_EXPORT extern char *__realpath_extended(const char * __restrict__, char * __restrict__);
 __Z_EXPORT int __mkstemp_ascii(char*);
 #if defined(__cplusplus)
 };
@@ -22,15 +23,22 @@ __Z_EXPORT int __mkstemp_ascii(char*);

 #if defined(ZOSLIB_OVERRIDE_CLIB) || defined(ZOSLIB_OVERRIDE_CLIB_STDLIB)

+#undef realpath
+#define realpath __realpath_replaced
 #undef mkstemp
 #define mkstemp __mkstemp_replaced
 #include_next <stdlib.h>
-#undef mkstemp
+#undef mkstemp
+#undef realpath

 #if defined(__cplusplus)
 extern "C" {
 #endif

+/**
+ * Same as original realpath, but this allocates a buffer if second parm is NULL as defined in Posix.1-2008
+ */
+__Z_EXPORT extern char *realpath(const char * __restrict__, char * __restrict__) asm("__realpath_extended");
 /**
  * Same as C mkstemp but tags fd as ASCII (819)
  */

My understanding is, that the original realpath prototype will be renamed to __realpath_replaced and that the new realpath definition will be 'diverted' to __realpath_extended.
Any idea why this is not working?

This is the original definition of realpath from stdlib.h:
        char        *realpath(const char * __restrict__,
                                    char * __restrict__) __THROW;

Hmm, I don't see anything obviously wrong with the changes you made.  One thing to confirm is that the zoslib -I includes are being added. I think in one case I noticed CPPFLAGS was ignored by a project, but it still built because C only warns for implicit definitions.
Another thing to check is are you seeing some of the other overridden symbols like open and mkstemps are changed to the __open_ascii/__mkstemp_ascii symbols. You should be able to use the nm utility to check this. Although you'll probably have to remove the -Wl,EDIT(NO) option or change it to YES to get symbols.

ah ok, I already looked with nm and I do see the __realpath_extended, but did not see the overriden ones. Where whould I have to remove the -Wl,EDIT(NO)?

Just to confirm, you added zoslib as a dependency in your buildenv and ran it through zopen build?
You could temporarily modify utils/bin/lib/zopen-build to remove -Wl,EDIT(NO). It might make sense to not set this when the buildtype is debug (zopen build -b debug) so that we can check the symbols.

yes, I added the dependency and I can see with nm that __realpath_extended is in the nano executable

I wonder if  -DZOSLIB_OVERRIDE_CLIB=1 is being passed, which is part of the CPPFLAGS

You're seeing __realpath_extended after you directly called it or via the override?

I think it is, I can see that the open function is overridden. I also tested this by removing the if defined(ZOSLIB_OVERRIDE_CLIB), but it didn't make a difference.

I see that it is included in the module with nm and I can call it directly, but not via the override

Hmm, it might be worthwhile to check the preprocessor output via the -E option to see if it's actually getting replaced

I can't get the zoslib build to use the -E option, it works for my nano build. Probably something with the cmake stuff.
I'm thinking that it is perhaps the asterisk in *realpath that is the issue. The #define realpath __realpath_replace might not match *realpath, but I cannot find a way to create a #define *realpath *__realpath_replace to test that theory

Hmm, I just tried doing the macro hackery on a small test and with -E it does show it as being replaced:
...
        char *__realpath_replaced(const char * ,
                                    char * );

I noticed on my system it's picking up stdlib from /usr/include/le/stdlib.h and it doesn't have __THROW at the end.
I wonder if you manually compile the one nano source file that uses realpath and do a -E on it, does it get replaced for you?

I found my error, I only copied the lib directory, I forgot to copy the changed stdlib.h

I created a pull request for the enhanced realpath:
https://github.com/ibmruntimes/zoslib/pull/7


Constant page refresh after install

After installing Kanboard on Ubuntu 14.04.4 using docker, and connecting it to my Gitlab server I find myself unable to use it because after sign in any page I go to will constantly refresh. I noticed a few other people have flagged this issue, but no response so far.
I use the chrome plugin "redirect path" and it is showing a perpetual loop of javascript redirects.
I'm accessing my installation through chrome, however IE produces the same problem

I cannot really reproduce this issue at least with the last Docker image.
Can you describe how you are running the Docker image and how you access it?


adds maintainer

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

Looks like recipe/meta.yml was updated, but not the README. Otherwise looks good to me.

The tooling should have the README updated. Checkout the README.md file modified by this PR. Looks like you are being added properly?

Here is the section I am referencing.

Ah, I didn't see that in the commit history, so I missed it. Thanks!


✨[Feature Request]: Add Newsletter Subscription Feature

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
The Rapidoc repository lacks a newsletter subscription feature, which is crucial for keeping users informed about the latest blogs, news, and developments ,doctor visits,medicines availability. This feature would greatly enhance user engagement and retention by providing a means for users to opt-in to receive regular updates
Use Case
a newsletter feature can provide significant value by keeping users informed, engaged, and connected with the RapiDoc project while offering the project team valuable insights and opportunities for growth
Benefits
No response
Add ScreenShots

Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

Where have you added this

I haven't added it yet mam,but i have an idea,
After Signup or Registration:
Thank You Page: After users sign up for an account or complete a form on the site, redirect them to a thank-you page that includes an option to subscribe to the newsletter
if it is okay i will work on it or else suggest me where to add this mam @Anishkagupta04!!

rather than feedback we can have loyalty program
in which when user register for opd or for any health checkup he she gets voucher on discounts or say off on medicine

Unlike feedback mechanisms, a newsletter is used to share information and engage our patients on multiple levels. It provides regular updates on our project’s progress, offers educational content such as health tips and wellness articles, and promotes our services and upcoming events.
While the loyalty program you suggested is an excellent idea for encouraging patient visits and promoting retention through direct rewards,
Newsletter can serve as a platform to highlight the loyalty program, encourage participation, and share success stories, further enhancing our patient engagement efforts.
if you are okay with it i would like to work on newsletter part as i am unaware of loyalty program! @Anishkagupta04

@Anishkagupta04 will i be assigned this or not?


Drag and Drop wordlist not attributing Type

When you drag and drop a wordlist in BB. It automatically detect it and set it's Type.
Per example ; MailPass
While in openbullet, the Type is always Default.
Is that a normal behavior ?

If you looked carefully you would've seen this https://github.com/openbullet/openbullet/commit/32f623a3b804ef6150474842f87f9ef7af2d243e commit fixes the issue, so either recompile or get the 1.0.1 version which already has the fix inside it.


Unit offset fixes

Fixes #63, plus a few other fixes related to offsets.
Not sure about the addition of CompilationUnitHeader. It's simply to get the right type for unit.offset().

Coverage increased (+0.7%) to 92.523% when pulling 3c52adc1ded006445b30603e009426896556861a on philipc:unit-offset into c9794eb9262d6202dbbd680379656661b1c2e720 on gimli-rs:master.

Not sure about the addition of CompilationUnitHeader. It's simply to get the right type for unit.offset().

I like it 👍


how to user getBlockedUsers

I'm trying to user the getBlockedUsers function but nothing happens when i do it (or I am doing it wrong). This is how i call the function:
swifter?.getBlockedUsers(includeEntities: false, skipStatus: true, cursor: "", success: mySuccess as? Swifter.CursorSuccessHandler, failure: failureHandler)
and this is what my success handler looks like:
let mySuccess: (JSON, String, String) -> Void = { someJson, someString, anotherString in print("some array: ", someJson)
print("some array: ", someString)
print("some array: ", anotherString)}

After this....nothing is printed to the console when i go to user that has people blocked.

The type for your success handler does not match Swifter.CursorSuccessHandler and so when you optionally cast the object mySuccess as? Swifter.CursorSuccessHandler, it returns nil and so has no success handler (hence, why nothing is printed)


Error, Multiple repositories are found

I'm trying top cross-build a project for scala 2.11, 2.12, and 2.13
The project is here https://github.com/ryanstull/ScalaNullSafe
When the build script runs on travisCI, I also get this error:
[error] Multiple repositories are found:
[error] [comryanstull-1025] status:open, profile:com.ryanstull(9dd2c8b46008f8) description: Implicitly created (auto staging).
[error] [comryanstull-1026] status:open, profile:com.ryanstull(9dd2c8b46008f8) description: Implicitly created (auto staging).
[error] [comryanstull-1027] status:open, profile:com.ryanstull(9dd2c8b46008f8) description: Implicitly created (auto staging).

sbt-ci-release is pushing each different version to a separate sonatype repo, and then when it tries to publish to the main repo, it gets confused.
Here's the full log from TravisCI: https://gist.github.com/ryanstull/83e7578ef933dbfeafb161b89d87ad42
build.sbt: https://github.com/ryanstull/ScalaNullSafe/blob/master/build.sbt
.travis.yml: https://github.com/ryanstull/ScalaNullSafe/blob/master/.travis.yml
Is there a setting I can change to make all of the different versions go into the same repo?  Any help would be appreciated.

Thanks for reporting! This is working as expected, sbt-ci-release defaults on the safe side and tries only to release a single staging repository or fail if there are multiple. You can configure export CI_SONATYPE_RELEASE=sonatypeReleaseAll to release all staging repositories.

Note that you can run sonatypeReleaseAll from your local sbt shell or sonatypeDrop (to remove the staging repos).
I have never fully understood when publishSigned chooses to open new staging repositories vs. reusing existing ones. I really wish it behaved the same way as in mill publish where each publish step opens/closes its own staging repositoriy.

The reason sonatypeReleaseAll is not the default is because it can publish half-complete staging repositories when publishing from parallel jobs.

I'm not sure why publishSigned would create multiple staging repositories for the ScalaNullSafe build since it only has one project with multiple crossScalaVersions. I use the same setup in large multi-module, multi-platform and cross-scala version builds and it still only opens a single staging repository 🤔

Thanks for the quick reply!  I'll try that out

It seems that adding export CI_SONATYPE_RELEASE=sonatypeReleaseAll did not fix the issue.
https://gist.github.com/ryanstull/84700a7b77497cbcb0913f0f86106a45

This environment variable is used here
https://github.com/olafurpg/sbt-ci-release/blob/9c1513d48e7dc0d3294ec3183839d45b8fba3c3d/plugin/src/main/scala/com/geirsson/CiReleasePlugin.scala#L92
What version of sbt-ci-release are you using?
What happens if you run sbt sonatypeReleaseAll from your local computer?

Looks like updating to the latest version of sbt-ci-release fixed this.  Before I was on 1.2.2 and it worked after changing to 1.2.6, in combination with defining CI_SONATYPE_RELEASE=sonatypeReleaseAll.
Thanks for the help!


Does this potentially improve startup latency?

Does this approach potentially improve startup latency? We're looking to reduce our nodejs startup times.

Well, in theory, yes. However, I haven't tested this aspect myself.
Have a look here v8-compile-cache, which I think fits what you want to acheive.


Changelog updates

Updates

Thanks! I will keep this open and merge with a new date before the release is tagged. Waiting for some feedback on RC1 currently


Add french translation

I didn't know if I should use en.yml or zh-cn.yml, so I took the one that was the most complete. And what is the showcase:  value ?

@c2tz thanks for the PR!
the "showcase" entry was for the top navigation bar:

Yeah I just saw it while browsing 😄 .  I think my translation is pretty good, at worst it can be improved afterwards.

@imfing that ok for me

@c2tz Merci beaucoup!


Charts enhancement

This PR add two enhancements for charts :

A tooltip button is now displayed to explain how to use filters in charts
Total cost in Pie Chart is now updated when user select items

@simonmeyerrr Done


FAQ - Remove outdated information from FAQ and review existing entries 🔧

Motivation
Due to the now substantial version history of the CWA, the FAQ contains a lot of legacy information. Content describing issues/fixes for several releases is often mixed together, creating possibilities for confusion. Formatting also varies between the individual entries.
Suggested change
Overhaul all entries by removing, improving or reordering them

[x] Check existing entries for relevance
[x] Check existing entries for outdated info
[ ] Trim entries that are overly long or split them into separate issues
[ ] Use consistent wording (for terminology: https://github.com/corona-warn-app/cwa-website/issues/524) and formatting, e.g. instructions should always be a enumerated list and the app name should be "Corona-Warn-App" with hyphens
[ ] Move obsolete/resolved entries to somewhere else (either through https://github.com/corona-warn-app/cwa-website/pull/894 or other means)

FAQ entries that were updated:

[x] who_can_help (https://github.com/corona-warn-app/cwa-website/pull/1083)
[x] international_phone_numbers (https://github.com/corona-warn-app/cwa-website/pull/1078)
[ ] further_details
[ ] update_iOS
[ ] cause2001  (https://github.com/corona-warn-app/cwa-website/pull/1081)
[x] access-list  (https://github.com/corona-warn-app/cwa-website/pull/1069)
[ ] battery_optimization_background  (https://github.com/corona-warn-app/cwa-website/pull/1085)
[ ] no_risk_update_ios14 (https://github.com/corona-warn-app/cwa-website/pull/1075)
[x] ios_black_screen  (https://github.com/corona-warn-app/cwa-website/pull/1077)
[ ] encounter_but_green
[ ] android_location
[ ] qr_scan
[x] qr_test  (https://github.com/corona-warn-app/cwa-website/pull/1073)
[ ] red_card_how_to_test
[x] battery (https://github.com/corona-warn-app/cwa-website/pull/1084)
[ ] no_risk_update_ios
[x] ios_power_save (https://github.com/corona-warn-app/cwa-website/pull/1076)
[ ] no_risk_update
[x] huawei_honor (https://github.com/corona-warn-app/cwa-website/pull/1079)
[x] ENError13 (https://github.com/corona-warn-app/cwa-website/pull/1080)
[ ] exposure_check
[ ] cause9002_recovery
[x] various_device_problems (https://github.com/corona-warn-app/cwa-website/pull/1071)
[ ] minimum_requirements
[ ] ios135
[ ] beta_ios
[ ] rooted_devices (https://github.com/corona-warn-app/cwa-website/pull/1072)
[ ] available_languages
[ ] interoperability_countries
[ ] age_restriction
[ ] apk (https://github.com/corona-warn-app/cwa-website/pull/1070)
[ ] other_platforms (https://github.com/corona-warn-app/cwa-website/pull/1074)
[x] where_to_get (https://github.com/corona-warn-app/cwa-website/pull/1082)
[ ] QRcodes
[ ] keys_matches
[x] close_app (https://github.com/corona-warn-app/cwa-website/pull/1051)
[ ] days_last_risk_encounter
[x] bluetooth_off (https://github.com/corona-warn-app/cwa-website/pull/1052)
[ ] ios_logging_bt
[x] backup (https://github.com/corona-warn-app/cwa-website/pull/1042)
[x] new_device (https://github.com/corona-warn-app/cwa-website/pull/1047)
[ ] delete_random_ids
[x] risk_info (https://github.com/corona-warn-app/cwa-website/pull/1044)
[ ] test_multiple_devices
[ ] test_in_other_country
[x] sick_leave (https://github.com/corona-warn-app/cwa-website/pull/1045)
[ ] recovered
[ ] hearing_impaired
[x] risk_update_24 (https://github.com/corona-warn-app/cwa-website/pull/1043)
[x] mobile_data_costs (https://github.com/corona-warn-app/cwa-website/pull/1049)
[ ] ENF_version
[ ] dissimilar_indication_of_risk_status
[x] mutation (https://github.com/corona-warn-app/cwa-website/pull/1048)
[x] encounter_count_19 (https://github.com/corona-warn-app/cwa-website/pull/1221)
[x] encounter_19_calc (https://github.com/corona-warn-app/cwa-website/pull/1050)
[ ] encounter_criteria
[ ] low_risk_green
[ ] encounter_same_person
[ ] count_per_day
[ ] have_to_use
[x] numbers_RKI (https://github.com/corona-warn-app/cwa-website/pull/1046)
[ ] central_entity
[ ] contact_diary
[ ] why_oss
[ ] oss_complete
[ ] dev_status
[ ] how_to_contribute

@heinezen
Has there been any announcement about the minimum version of CWA which is still supported?
Perhaps the main FAQ could cover the current release and the previous release, moving older information to the "somewhere else" place? I expect that most devices will auto-update to the latest version when it is released.

Forwarding what @dsarkar shared with us here:

[...] On the server the min. req. version iOS 1.5.3 and Android 1.0.4 (!). There shouldn't be users with working CWA versions older than those mentioned, and all FAQ entries referring to < iOS 1.5.3 / Android 1.0.4 can be archived.

This is relevant for archiving older FAQ articles.
In this case here, it means, we still need the info of the old article.

If the decision for Android is to continue to keep FAQ articles going back to CWA Android 1.0.4 then this is no relief for simplifying the FAQs. As far as I could see on a quick run through the articles there is nothing which can be removed for Android.

After a quick look at the FAQ I found this entries that can be removed (iOS):

https://www.coronawarn.app/de/faq/#app_does_not_open
https://www.coronawarn.app/de/faq/#migration_Apple

We should also consider to remove articles which talk about iOS 13.5 - 1.6.1 (like https://www.coronawarn.app/de/faq/#ENError5 and below this entry).

@MikeMcC399 @Ein-Tim
Thanks. I'll start going through everything today, categorize the entries and look for errors. The results will be posted here for feedback.

Corona-Warn-App Open Source Team

Part 1
Genereal issues/remarks

Corona-Warn-App spelled differently across English/German

Phone number format should be international (+49 ...) --- but not 0800 numbers !

Important: FAQ entries should actually answer a question and not something completely differently

Remove TMI stuff

Use a unified format for instructions

enumerated list
UI element names enclosed in ''
Traversing menu items should be indicated by an arrow: ->

For entries with UPDATE:

need clarify which info is outdated and which is still relevant

who_can_help

Split into multiple entries

Merge Hotline national/international entries (international_phone_numbers)
New entry for "where to find the responsible health authority"

"If the test result is not available in the Corona-Warn-App..." section

very general, what question does it answer?

Link to possible outdated blog entry from August: https://www.coronawarn.app/de/blog/2020-08-25-notes-qr-codes/

better link to FAQ entry qr_scan

Link to Bundesregierung page is about CWA, but link to RKI is about Corona in general

New entry for general Corona (not CWA!) updates from Breg/RKI?

English issues:

You can reach the technical hotline from Monday to Saturday from 7 a.m. to 10 p.m. (except on German public holidays), and it is free of charge for you within Germany.

Should be national holidays (bundesweit) so that this is not confused with federal holidays

The various feedback channels of the Corona-Warn-App-Community will help you with your questions about the open source project of the Corona-Warn-App.

embedded link links to german page

international_phone_numbers

Should be merged with national phone numbers, so that we can link to it from other places in the FAQ

many older entries only reference the national phone number

"News" section

These are not questions, why?
Would be better as blog entries?

further_details

Entry: "In-App Statistiken ab Release 1.11" is WIP, it will explain in more detail the four statistic cards.
Key "further_details" is not descriptive

better use "in_app_stats"
anchor can't be changed, since this FAQ entry is linked from within the app!

The number of new infections is published once a day by the Robert Koch Institute (RKI). 'Yesterday' means that the value considers all reported new infections from the previous day until 23:59.

Clarify that 'Yesterday' refers to something in the UI (the R-value card)

or remove it because it is only relevant for the R-value card

Link the first mention of nowcasting to: http://www.rki.de/covid-19-nowcasting

English issues:

Last sentence starts with "However", but german entry does not

update_iOS

More information can be found in this FAQ entry.

More information about what? Clarify!

"More information on how to upgrade to iOS 13.7"

Clarify that CWA switch to ENFv2 in CWA version ??? and therefore requires it

ios135 answers the same question, although with a slightly different approach

Merge entries?

cause2001

List with instructions needs formatting update (see above)

access-list

Key "access-list" is not snake case

"Some firewalls" -> "some firewall settings" (english/german)

"contacting the backend" -> "contacting its test result/verification backend" (english/german)

format access list as HTML list

battery_optimization_background

When you switch on the prioritized background activity on some Android devices, the battery optimization for the Corona-Warn-App is not turned off on OS level. This is a known limitation for a limited number of Android devices.

Which ones?
Rephrase to "is not turned off [...] immediately"

English issues:

"switch on" -> "enable"

no_risk_update_ios14

Still relevant?
List with instructions needs formatting update (see above)

However, it will take 24 hours until the app resumes the data collected so.

Grammar?
Is it still 24 hours? might be 4 hours because of the 6x per day update

On mobile data there is only one update per 24 h

German issues:

"1x" -> "einmal"

ios_black_screen

Still relevant? Yes, in the AppStore relevant
List with instructions needs formatting update (see above)

encounter_but_green

entry explains a lot which is already explained elsewhere

encounter_19_calc
encounter_criteria

second paragraph is very confusing due to nested sentences

needs mention of encounters which are filtered out by the app

cwa-risk-assessment.md is still outdated!

Jedem dB-Wert lässt sich eine Entfernung im Freiraum (d.h. ohne Hindernisse im Signalweg) zuordnen.

No mention of this in english entry
Not accurate enough

we use dB ranges in the CWA

German issues:

Als Nächstes wird für jede Positivkennung anhand aller dazu passenden Zufalls-IDs geschätzt, wie lange die Begegnungen jenes Tags insgesamt gedauert haben und wie nahe die Smartphones sich dabei im Durchschnitt waren.

analysiert (like in the english entry)

android_location

List with instructions needs formatting update (see above)

This notification is not applicable for Android 11 phones and will be removed in one of the following updates of the Corona-Warn-App.

Implemented? Yes, the text has changed.

Here you can allow or deny other apps to use your location, but since Corona-Warn-App doesn't need this permission, it doesn't even appear in the list.
Again, as described above: You should not deactivate 'Use location' under 'Settings' > 'Security & Location' > 'Location', because this is a prerequisite for exchanging the encrypted random IDs.

Explanation issue: We should explicitly say what the difference between the BLE location and GPS location is

BLE = localized location tracking
GPS = globalized location tracking (not used in CWA)

German issues:

Sehen Sie sich die Liste der Apps an, die auf Ihren Standort zugreifen können, wenn Sie es zulassen. Sie sehen: Die Corona-Warn-App ist nicht aufgeführt.

"Sie sehen" is not in the english version of the entry

qr_scan

Section "The code was already used once for registration" could mention test_multiple_devices

qr_test

Link to FAQ entry with TAN Hotlines instead of mentioning phone numbers directly

English issues:

Missing single quote: 'Display Test' -> 'Delete test

red_card_how_to_test

The linked PDF is not great if you are on mobile. There should be a mobile version or image.

English issues:

"screened" -> "tested"

battery

List with instructions needs formatting update (see above)

The Corona-Warn-App uses the latest Bluetooth technology: Thanks to the Exposure Notification API from Apple and Google, the app can use the energy-efficient BLE (Bluetooth Low Energy) technology.

English version is "biased" and should use a more neutral tone

This means that a frequently and intensively used phone has a very low percentage of battery consumption per app. On the contrary, if you use your phone mainly to make phone calls and only occasionally stream music or use social media, the percentage per app will be relatively high.

Wording? Is it understandable?

"Note for Android phones" -> "Note for Android devices"

Here you can deny other apps permission to use your location if you don't think they need it.

Difference in wording

no_risk_update_ios

List with instructions needs formatting update (see above)

Why is there a blogpost on LinkedIn?

and it's german only???

Make sure that exposure logging is active.

How?

ios_power_save

iOS 13.6.1 is not supported anymore, so this entry should be moved to "Resolved"

no_risk_update

This entry is loooooooooooooong (split or trim content?)

Make sure that exposure logging is active.

How?

"de-activate" -> "deactivate" (english german)

English issues:

You do so directly in the energy saving settings. of your phone.

Remove dot

max_power_save
huawei_honor

Move to resolved section

What is EMUI 4: The custom OS

According to current information, a system update seems to be available for newer Huawei devices that is explicitly intended to fix the problems with Corona-Warn-App.

Link to official info
Tell users to install it

The GitHub community has compiled suggestions for making additional settings and has also linked information about the system update. You can find all the details in this GitHub issue.

Issue is closed

ENError13

Still relevant? Yes. Occurs typically after CWA updates. Notification might be suppressed in future.
Do not have so many paragraphs with single sentences

exposure_check

The log has a fixed limit of 100 entries on iOS devices. On Android devices the limit is 300 entries. If there are more entries, only the latest are kept.

Is this still true?

German issues:

"drei-Punkte-Icon" -> "Dreipunktmenü"

cause9002_recovery

Still relevant?

German heading starts with "[Google/Android]: ", but the english one does not

Resetting the data also means that the information on how long your app has been active is lost (the number of active days is set to 0).

This display was removed in current CWA

The technical background section suffers from too much information

various_device_problems

List with instructions needs formatting update (see above)

Since I installed the app, my phone sometimes behaves oddly. Example: There are occasional problems with other apps and devices that use Bluetooth. What can I do?

Question is in text instead of heading

Still relevant?

What is the current status?
Examples for devices?

minimum_requirements

Android: Link to googleplay entry (aka "Why are Android 6 and Google Play Services minimum requirements?")

Already done for Apple section

"v2 version" -> "ENFv2 version"

there is a confusion: Currently it is ENF version 1.8, but API 2, not API 1. In the Android devices ENF version number is shown as 18nnnnnnnnn

See also [Apple/iOS]: Why is iOS 13.7 a minimum requirement? and the blog articles [Telekom and SAP to make Corona Warn app available for iOS 12.5.] and [Corona-Warn-App version 1.12 comes with two new features]

Links to blog articles could be removed since they can also be found in the linked FAQ entry
Remove the dot after 12.5 (english)

@Ein-Tim @MikeMcC399 above are our remarks and notes so far. You can already give feedback :)
There will be a part 2 for the other entries (probably on Thursday)

Corona-Warn-App Open Source Team

Thanks @heinezen, looks good so far, some thoughts & remarks:
who_can_help
Don't forget that this FAQ is linked to from everywhere on the www.coronawarn.app page ("Wer hilft bei Corona-Warn-App Fragen?").
further_details
Use the redirect to change the anchor?
update_iOS
Was created to link from in-app update screen. See https://github.com/corona-warn-app/cwa-app-ios/issues/2045. If it's not getting implemented then merge with ios135.
no_risk_update_ios14
Not relevant anymore IMHO, should be moved to solved section.
encounter_but_green
This entry is linked to from the app if the user had low risk encounters. It should probably be adapted to only explain why the encounter is green and how the user should behave. Details about the risk calculation should be moved to encounter_19_calc and encounter_criteria.
no_risk_update_ios
Blogpost was published when press wrote about non working background updates on iOS. Why it's on Linkedin, idk. 😁
no_risk_update
Entry is only about android but isn't "no_risk_update_android", maybe change anchor (-> redirect).

Part 2
ios135

Key "ios135" does not fit anymore
entry explains more about 13.7 than 12.5

more details about versioning for non-techical users?

The version 1.12.1 is already available.

Must refer to $current_version
Vertical bar in english version after bullet points, but not in german version

More details about the system requirements can be found in this FAQ entry.

Links to minimum requirements, which contains less information

Last two sentences: Repetition of leider/unfortunately

beta_ios

Unclear what support means (ability to install the app? no support for bug fixing? i assume it is only the latter)

rooted_devices

Answer does not match the question

It can be used on a rooted device
Rooted devices will just not receive official support

English issues:
- "Also" in the heading should be removed
googleplay

available_languages

Link to hotline FAQ entry

Please note that many countries release their own Corona tracking apps. Because the German Corona-Warn-App is also available in the app stores and play stores of these countries, the Corona tracking apps could be mixed up. Therefore, make sure that you download the app for your country.

Does not really fit to an entry about languages

Better suited for entry: international

Entry touches several different topics
New FAQ entry?

I have to travel abroad. Can I still use the Corona-Warn-App?

Therefore, make sure that you download the app for your country.

Should be: For the country you are currently residing in

but CWA can also accept tests from other countries via TeleTAN (SEE test_in_other_country)

interoperability_countries

Can tests in the respective countries still only be submitted through the country's own app?

Does the phone number formatting follow any pattern?

Germany: Email is<EMAIL_ADDRESS>but maybe it should be the opensource@sap address?

spellchecks and checks for missing information might be necessary

Slovenia errors:

Ministry of Public Administration (MJU) and Ministry of Public Administration (MJU)

-> Ministry of Public Administration (MJU) and National Institute of Public Health (HIJZ)
- german entry: use "und" instead of "and"

what does DPO stand for?
HIJZ phone number missing

age_restriction

Reason for the age of 16 are likely privacy regulations
Link to CWA Privacy notice

apk

Outdated

there is an Fdroid fork now
It is not made by the RKI -> no support
made by the community using the code from CWA
Link to it?

Furthermore, the app only works with Google Play Services.

google play services are not required anymore

Links need to be updated with newer issue links:

https://github.com/corona-warn-app/cwa-app-android/issues/1483

Furthermore, there is an initiative in the developer community to make the Corona-Warn-App executable independently of Google Play Services via appropriate extensions. Details can be found in the issue corona-warn-app/cwa-app-android#75.

If this refers to microG, then the initiative has been successful

other_platforms

Link/mention CCTG?

where_to_get

Links to store page?

QRcodes

At the moment, many families are tested at the airport after returning from their holidays.

"at the moment" might refer to last year
mentioning airports specifically is weird

For each family member that is being tested, they get a leaflet that displays a QR-Code.

Link to an example

A lot of the information is already mentioned in qr_scan

are just qr_scan

is the only time multiple QR codes are mentioned

Restructure entry with more direct info

(Apparently) multiple people are sometimes tested at once
If that's the case: Everyone should scan their respective QR code in their own device
QR codes of kids/others who do not have their own device should not be scanned
For scanning the QR code, refer to qr_scan

keys_matches

What do the exposure check logs show?

Minor discrepancy in heading

Exposure checks
This value does not reflect the number of encounters. Please tap one level further: This is where the checks of up to 15 days are logged (today plus the last 14 days). Selecting an entry leads to a detailed view with the corresponding time stamps and the number of matched keys.

Shouldn't explain what it's not first -> Rearrange explanation

Provided Key Count (Apple) | Number of keys (Android)

Matched Key Count (Apple) | Number of matches (Android)

iOS instead of Apple

If your risk status stays green, that is, 'Low Risk', find more information at An encounter has been reported, but the risk status stays green.

Needs more explanation

"Your risk status can remain at "Low risk" (green card)despite having severa encounters. Find more information at ..."

Date and time at which the check happened.

"check" -> "exposure check by the app"

German issues:

"Gültigkeitsdatum" -> "Validierungszeitstempel"

close_app

Yes. As long as you have activated exposure logging in the app and Bluetooth is on, encounters are logged in the background. The app itself doesn't have to be open for this.

Additional info: Exposure logging is done on OS level as long as a COVID app is installed.

German issues:

Sicherheitshalber öffnen Sie die App täglich nach Ablauf von 24 Stunden einmal.

"einmal am Tag" is okay too, especially since the app updates more frequently now

days_last_risk_encounter

Resolved; since CWA 1.13 dates for green and red are shown

bluetooth_off

Therefore, make sure to have Bluetooth and for Android, the location services, active whenever you meet someone, be it guests or when you're on the road.

Improve readability (german/english)

You can deny other apps to use your location, if you want: see I'm asked to activate my location.

Für alle anderen Apps können Sie die Standortverwendung ausschalten, wenn Sie das möchten: siehe Meldungen zur Aktivierung der Standortverwendung.

Link text does not match entry heading [Google/Android]: When activating exposure logging or Bluetooth I'm asked to activate my location. Do I have to do this?

ios_logging_bt

backup
English issues:

"back up" -> "backup" (heading)

new_device
English issues:

Corona Alert app :smile:

[...] please note this FAQ entry.

Link text includes space after "this"

delete_random_ids

Last paragraph has discrepancy between english and german version

improve formatting
use the same descriptions for the steps
description needs more details (e.g. where are the settings?)

English issues:

"re-install" -> "reinstall"

German issues:

"Neu-installation" -> "Neuinstallation"

risk_info

needs update on wording

If you are diagnosed with COVID-19, you can upload your diagnosis keys to the server.

"server" -> "test result server"

If there is a match between a key downloaded from the server and a key saved locally on your device, this means you were exposed to a person who has been diagnosed with COVID-19. Matching the encounters does not require a Bluetooth connection.

Say that the keys are compared

Introduce 4.: App assesses risk based on XYZ (can link to FAQ entry)

If there is a match between a key downloaded from the server and a key saved locally on your device, this means you were exposed to a person who has been diagnosed with COVID-19.

Gibt es eine Übereinstimmung zwischen einem vom Server heruntergeladenen und einem lokal gespeicherten Schlüssel, dann bedeutet das, dass es eine Begegnung mit einer Person gab, die positiv auf Corona getestet wurde.

use the english version for the german entry

German issues:

Point out that the solution architecture document is english-only

result_time

rapid_test

test_negative

test_multiple_devices

Link to hotline FAQ entry

If you additionally want to share a positive result via your company device or any other additional smartphone, this can be done via a so-called TeleTAN.

Wenn Sie darüber hinaus auch über Ihr Firmengerät ein positives Ergebnis teilen möchten, geht dies ausschließlich über eine sog. TeleTAN.

difference in tone between german/english

German issues:

"sog." -> "sogenannte"

test_in_other_country

Link to hotline FAQ entry

sick_leave
German issues:

"Teststelle" -> "Testzentrum"

recovered

you have the option to reactivate the app after recovering from a SARS-CoV-2

where/how?

hearing_impaired

"TAN" -> "TeleTAN" (?)

risk_update_24
German issues:

"Zero-Rating Verpflichtungen" needs additional dash

mobile_data_costs
German issues:

"Datenvolumina" -> "Datenvolumen"

ENF_version

too much historical information

dissimilar_indication_of_risk_status

Key "dissimilar_indication_of_risk_status" is very long
Actual question in text instead of heading

mutation

Include the titles of the linked blogposts

encounter_count_19

Entry talks in past tense about versions < CWA 1.9, but they are still supported on some devices
Drop separation of "In simplified terms" and "In detail:" sections

both are relevant for understanding

remove mention of 10 minutes signal attenuation time window and just keep 5 minutes

Englisch issues:

However, in the operating system's contact log, a count is performed. However, this is not an error.

2x however

Missing dot at end of last sentence

encounter_19_calc

remove mention of 10 minutes signal attenuation time window and just keep 5 minutes

Based on the transmission risk level (III to VIII), only a factor between 0.6 and 1.6 is determined. The weighted time from the previous step is multiplied by this factor, which then results in the weighted contact time. This weighted time is now used to decide what type of encounter this time slot is:

Weighted contact time <15 minutes: Encounter with a low risk (green).

Weighted contact time >=15 minutes: Encounter with increased risk (red).

Finally, all time windows of a day are considered (the weighted contact times) and added up. If the sum is >= 15 minutes, the overall status becomes red, otherwise it is green. Ultimately, this means that several 'green' encounters (time windows) can result in a red status in total. For those who would like to dive even deeper into the subject:

Last paragraph should come before bullet points to emphasize that time windows are accumulated

English issues:

Based on the transmission risk level (III to VIII), only a factor between 0.6 and 1.6 is determined.

"only"?

encounter_criteria

Answers two questions at one -> split up

By which criteria are encounters evaluated?
how do the recommendations for action differ?

wording is different between paragraphs:

"increased risk" vs. "high risk"

As of version 1.9.1, the app also shows the last time (within the last 14 days) an encounter with increased risk took place. You can now see an exact date to better track your contacts or behaviour on that specific day.

Should be moved to the second to last paragraph

encounter_deletion

low_risk_green

There should be at least something like "try to minimize your encounters" with other people here, not "there is no particular need for action"

encounter_same_person

does the answer match the question?

count_per_day

same as encounter_same_person?

have_to_use

Should be more precise about

the whole app being voluntary
that the app functions are optional

more than two functions

exposure logging
test retrival
sharing result
contact diary

German issues:

nichts geschieht ohne Ihre Zustimmung.

add "explizite" like in english version

numbers_RKI

question in heading could be more general about statistics

objectives

reasoning_decentralized

cost_benefit

constraints

non_dev_related

central_entity

Additional info: Expousure events are stored by OS ENF, not by app

backend_ops

client_server

contact_diary

Heading is not a question
mention that fearure requests can be found/made on Github

link to contact jounal overview

English issues:

"extension by functions" -> "extension by features"

why_oss

Second sentence is in first paragraph in english version, but in second paragraph in germa version

through reviews and pull requests

very technical

better: "through code reviews and contributions via Pull Requests"

oss_complete

Link to Github!!

dev_status

We will be able to publish information as soon as it is available on the issue as to whether the code in GitHub is really the same as that in the app in the respective app stores ('reproducible builds'). You can find further information on the progress of this issue in the respective GitHub issue.

Needs clarification

how_to_contribute

removing mistakes in the source code, helping with the documentation, raising questions or commenting on the project.

and reporting bugs

German issues:

Die Zusammenarbeit innerhalb der Community unterliegt einem Code of Conduct. Alle Richtlinien zur Beteiligung findest Du hier.

informal Du

github

coc

Hey @heinezen, only two comments:
ios135

Shouldn't say something about the app version minimum, it's about the iOS version

hearing_impaired

Yes, "TeleTan" (See https://github.com/corona-warn-app/cwa-documentation/blob/master/.spelling#L99-L102)

Have nice easter days!

Starting today, the FAQ entres will gradually be updated with what we found. We will make a separate PR for each entry which I will link in the list in the top post. PRs will stay open for some time to get feedback. The PR will also include a changelog in the description.
I'll start with the least complicated entries and we will gradually work ourselves through the more sophisticated changes.
Happy easter!

Corona-Warn-App Open Source Team

@Ein-Tim @MikeMcC399 A new batch of entries has landed!

@heinezen
Thank you for the heads-up. I will take a look at the new PRs.

I added my suggestions & remarks. Weren't that much 👍

@heinezen
I have finished reviewing and commenting. Back to you now!

@heinezen
You mentioned the entry update_ios here, I think it could be merged with ios135 now for the reason I also closed https://github.com/corona-warn-app/cwa-app-ios/issues/2045.

@Ein-Tim @MikeMcC399 Thank you both for your feedback! It's really appreaciated.
We are going to start with merging the entries before we create the other PRs. 2.0 will also arrive soon and might take over priority for a while.

@heinezen
You mentioned the entry update_ios here, I think it could be merged with ios135 now for the reason I also closed corona-warn-app/cwa-app-ios#2045.

I've mirrored this into my notes and will propose a solution, once we'll get to that entry.

Sorry for not coming back to the FAQ updates for a while. We were quite busy with the releases. I'll resume the FAQ updates this month.

@MikeMcC399
I definitely I agree with you.
Also, the open PRs from @heinezen should either be made ready to be merged now or be closed.
I don't think @heinezen will do this himself, as he has left the Corona-Warn-App Open-Source-Team, sadly.

The FAQ site has been redesigned.
This issue has not been maintained so it is no longer a useful reference of what needs to be reviewed or changed.

I suggest to close it. It is almost one year since is has been touched.

This remains a stale issue.


Now unknown animation types are replaced with Failure (fix #663)

We were previously catching the case with a known "typename" which failed to construct.  We were not catching the case where the "typename" is missing or can't be imported.

Checks Failed :( Does this still work with Remote?

Ooops, pushed a fixup.
Absolutely, I in fact tested both types of failure with remote:

Bad typename
existing typename with bad constructor parameters.

lgtm
On Mon, May 21, 2018 at 9:55 AM Tom Swirly<EMAIL_ADDRESS>wrote:

Ooops, pushed a fixup.
Absolutely, I in fact tested both types of failure with remote:

Bad typename
existing typename with bad constructor parameters.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/pull/816#issuecomment-390660655,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA6a6tYArxKImNkKVDq7WWptF-5fUqpfks5t0sdagaJpZM4UG03u
.


Installing in cpanel

Hi, how can I install this app on a cpanel server

The steps would be:

install nodejs on your cpanel server, see for example https://stackoverflow.com/questions/44079039/run-node-js-on-cpanel-hosting-server
Clone the db on your server, and run the backend https://github.com/amaurymartiny/login-with-metamask-demo#start-the-backend-using-yarn

I don't have much experience with cpanel. Will close this issue for now, as it's not related to the codebase itself.


Copy change and URL update request - webassembly

@potch - the Dev Marketing team (Porfirio) would like to ask for a copy and URL change in the games.mozilla.org site.
The requested changes are documented here in line 8
Please<EMAIL_ADDRESS>with any questions.
Thanks,
Eric

I emailed<EMAIL_ADDRESS>and got a bounced-back email. Is that the correct email still?

@cvan - please ping<EMAIL_ADDRESS>if you have any questions (or find him on Slack)

Hey cvan,
just confirming that TL&I have made some updates to the changes we would like on the Games page, here
To summarize, we are looking to make 3 changes:

Change copy and CTA for WebAssembly
Replace Open Web Games tile with WebVR tile (New copy, Image and CTA link)
Reorder all of the cards.

Please let me know if you have any questions.

@moz-mpluta
I've made these changes in Pull Request #133.

Because the site's background colour of the card footers is white, and the image for the new WebVR card has a white background, the lack of contrast looked a bit awkward alongside the "Firefox Hardware Report" card. Compare the two images below, and let me know your thoughts.
I also replaced the WebAssembly image with one with the updated branding. Let me know if you think that looks fine.
Everything else look okay to you? If so, I'll merge PR #133 and push it live to https://games.mozilla.org/

Hey @cvan
Thank you, this is great! I had a look with Porfirio and we think that the second version with the grey band looks better.
After looking at the punctuation, we would like to change the copy of the VR subhead
From: Build in A-Frame. Share in Firefox.
To: Build VR with A-Frame and share files in Firefox
This way the copy will have consistent punctuation on the page.

This way the copy will have consistent punctuation on the page.

Yeah, np, I thought it looked a bit inconsistent. Just changed to Build VR with A-Frame and share files in Firefox

What about changing and share files in Firefox to and enjoy VR in Firefox?

hey @cvan, that sounds good, let's do it. Thanks!

done, and pushed to production: https://games.mozilla.org/

a few additional notes:
I filed issue #134 for updating the Mozilla branding.
I don't work on the Games projects anymore, although I did work on the initial version of this site. it was then redesigned by a firm Andre worked with.
I know @potch has been helping out with maintenance on this. but just mentioning this because there are a couple outstanding issues (#119 and #138), namely around page-load perf (namely the artwork: [1] the background graphic and [2] the graphic headline).

Thank you @cvan this is looking fantastic! We really appreciate your help.

Hey @cvan, when reviewing the live page, Judy noticed that the headline copy for VR and WebAssembly is identical... We really apologize about the back and forth on this, but would it be possible to change the copy one last time?
This change to VR tile would solve the issue:
Hed: WebVR Ships in Firefox
Deck: Build new virtual worlds in A-Frame

@moz-mpluta: updated: https://games.mozilla.org/
the text for the WebVR card is now a tad longer than those of the other cards. let me know if you want me to tweak this further or if there are any other changes you'd like made.

@moz-mpluta: I adjusted the font size of the headings now. see Pull Request #143: https://github.com/mozilla/moz-games/pull/143#issue-255495687
you can see the change now at https://games.mozilla.org/


style: Setup prettier-plugin-prisma.

Closes #1982

@janpio hey, I was out of loop these few weeks, is there any blocker for the PR?

The resolving of the conflicts was one 💯
Will take another look later and then try to get this merged asap.


HDDS-1468. Inject configuration values to Java objects

According to the design doc in the parent issue we would like to support java configuration objects which are simple POJO but the fields/setters are annotated. As a first step we can introduce the OzoneConfiguration.getConfigObject() api which can create the config object and inject configuration.
Later we can improve it with annotation processor which can generate the ozone-default.xml.
See: https://issues.apache.org/jira/browse/HDDS-1468

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
23
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

0
mvndep
40
Maven dependency ordering for branch

+1
mvninstall
1207
trunk passed

+1
compile
74
trunk passed

+1
checkstyle
31
trunk passed

+1
mvnsite
76
trunk passed

+1
shadedclient
833
branch has no errors when building and testing our client artifacts.

+1
findbugs
113
trunk passed

+1
javadoc
58
trunk passed

_ Patch Compile Tests _

0
mvndep
11
Maven dependency ordering for patch

+1
mvninstall
74
the patch passed

+1
compile
70
the patch passed

+1
javac
70
the patch passed

-0
checkstyle
25
hadoop-hdds: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
mvnsite
61
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
804
patch has no errors when building and testing our client artifacts.

+1
findbugs
119
the patch passed

+1
javadoc
54
the patch passed

_ Other Tests _

+1
unit
78
common in the patch passed.

-1
unit
88
server-scm in the patch failed.

+1
asflicense
27
The patch does not generate ASF License warnings.

3896

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-772/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/772

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux 8e6273679b38 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 0b3d41b

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/1/artifact/out/diff-checkstyle-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/1/artifact/out/patch-unit-hadoop-hdds_server-scm.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/1/testReport/

Max. process+thread count
464 (vs. ulimit of 5500)

modules
C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
32
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

0
mvndep
59
Maven dependency ordering for branch

+1
mvninstall
1152
trunk passed

+1
compile
89
trunk passed

+1
checkstyle
31
trunk passed

+1
mvnsite
77
trunk passed

-1
shadedclient
264
branch has errors when building and testing our client artifacts.

-1
findbugs
16
common in trunk failed.

-1
findbugs
26
server-scm in trunk failed.

-1
javadoc
26
common in trunk failed.

_ Patch Compile Tests _

0
mvndep
15
Maven dependency ordering for patch

-1
mvninstall
27
common in the patch failed.

-1
mvninstall
20
server-scm in the patch failed.

+1
compile
80
the patch passed

+1
javac
80
the patch passed

+1
checkstyle
30
the patch passed

-1
mvnsite
23
server-scm in the patch failed.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
627
patch has no errors when building and testing our client artifacts.

-1
findbugs
19
server-scm in the patch failed.

-1
javadoc
40
hadoop-hdds_common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-1
javadoc
21
hadoop-hdds_server-scm generated 6 new + 5 unchanged - 0 fixed = 11 total (was 5)

_ Other Tests _

+1
unit
78
common in the patch passed.

-1
unit
24
server-scm in the patch failed.

+1
asflicense
34
The patch does not generate ASF License warnings.

3007

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/772

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux 42a19cb93db1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c35abcd

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/branch-findbugs-hadoop-hdds_common.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/branch-findbugs-hadoop-hdds_server-scm.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/branch-javadoc-hadoop-hdds_common.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/patch-mvninstall-hadoop-hdds_common.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/patch-mvninstall-hadoop-hdds_server-scm.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/patch-mvnsite-hadoop-hdds_server-scm.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/patch-findbugs-hadoop-hdds_server-scm.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/diff-javadoc-javadoc-hadoop-hdds_common.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/diff-javadoc-javadoc-hadoop-hdds_server-scm.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/artifact/out/patch-unit-hadoop-hdds_server-scm.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/testReport/

Max. process+thread count
445 (vs. ulimit of 5500)

modules
C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/2/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

+1, Looks good. Thanks.

Thanks the review @anuengineer . Merging it right now...


unpack parameters as Dictionary

Unpacking parameters assuming they are Dictionary rather than a Base. Works with simple attributes, but Revit models seems to start sending null in "parameters" (e.g. https://latest.speckle.systems/projects/126cd4b7bb/models/523fc1299b ), need newer model to test

@KatKatKateryna they are sent under ‘properties’ not ‘parameters’


Add support for icm42686 and tune for NXP VMURT1170

Support both icm42688 and icm42686 through the same driver
Add support for setting Anti Alias Filter for Accelerometer and Gyroscope
Tune icm4268x sensors for VMURT1170 for NXP's Mobile Robotics
products

Please split up the first commit into a few commits...

renaming icm42688 to icm4268x and adding the additional 686 compatible
Adding additional dt config options
Adding sample app (I'm not entirely convinced of this? whats special about this sample?)

The last commit modifying the vmu board dts seems ok to me.

Please split up the first commit into a few commits...

renaming icm42688 to icm4268x and adding the additional 686 compatible
Adding additional dt config options
Adding sample app (I'm not entirely convinced of this? whats special about this sample?)

The last commit modifying the vmu board dts seems ok to me.
@teburd
There is no real use of the sample app, I just wrote it for my testing and kept it as is.
Please suggest if you want me to remove it.

Please split up the first commit into a few commits...

renaming icm42688 to icm4268x and adding the additional 686 compatible
Adding additional dt config options
Adding sample app (I'm not entirely convinced of this? whats special about this sample?)

The last commit modifying the vmu board dts seems ok to me.

@teburd .. Created the commits as per your suggestion.. Please check now

Will review once CI passes

@teburd .. Please review..

@bperseghetti do take a look if you can

Marking DNM until people have a chance to test this out, as it is a pretty big change. I'll try and test it out next week.

@teburd .. The source repo is deleted due to some internal policy related issues.. but please continue your testing.. I'll raise it from another Repo and link it to this one


[BUG] Error 404: Not Found

Hello there ! I'm facing this bug in tv series section... Whenever i click on page it shows this error but movies section is working fine.. and i can search tv series from search and home page but tv series page always shows this error
ScreenShot:

I just went to your libDrive deployment lib****x.herokuapp.com
I'm not having the problem you're describing.

I just went to your libDrive deployment lib****x.herokuapp.com
I'm not having the problem you're describing.

Please open web series page and check bruh

I just went to your libDrive deployment lib****x.herokuapp.com
I'm not having the problem you're describing.

Please open web series page and check bruh

Oh I understand what you mean now, you're talking about the browse page
The issue is in your category_list config, the / character is not allowed in the category name, removed it and it should be fixed.

I just went to your libDrive deployment lib****x.herokuapp.com
I'm not having the problem you're describing.

Please open web series page and check bruh

Oh I understand what you mean now, you're talking about the browse page
The issue is in your category_list config, the / character is not allowed in the category name, removed it and it should be fixed.

Okay bro trying that

I just went to your libDrive deployment lib****x.herokuapp.com
I'm not having the problem you're describing.

Please open web series page and check bruh

Oh I understand what you mean now, you're talking about the browse page
The issue is in your category_list config, the / character is not allowed in the category name, removed it and it should be fixed.

That problem solved thanks for help but now whenever i refresh the browse page an error pops up and says me to logout or retry that wasn't happened earlier
ScreenShot:

@LabbadBeta the category name has a trailing space
chrome is automatically removing the space when you reload, which makes libDrive unable to find the category
remove the space at the end of the name and it'll be fixed.

@LabbadBeta the category name has a trailing space
chrome is automatically removing the space when you reload, which makes libDrive unable to find the category
remove the space at the end of the name and it'll be fixed.

Thanks For Quick Help 🥰


⚠ Processors has degraded performance

In acb28e4, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 57 ms

Resolved: Processors performance has improved in 3696ff8.


is_authenticated() returns false after correct auth_app_id() call.

setup:
$ vault auth-enable app-id
$ vault write auth/app-id/map/app-id/0d1ab824-d56d-4fed-991d-5056dccf3ce1 value=root display_name=root
$ vault write auth/app-id/map/user-id/66064160138498 value=0d1ab824-d56d-4fed-991d-5056dccf3ce1

code:
>>> import hvac
>>> client = hvac.Client("http://<IP_ADDRESS>:8200")
>>> print client.auth_app_id(appID, uuid.getnode())
{u'lease_id': u'', u'lease_duration': 0, u'data': None, u'auth': {u'client_token': u'c2faafc8-fdaa-f92d-423a-6bc57debcb8a', u'lease_duration': 2592000, u'renewable': False, u'policies': [u'root'], u'metadata': {u'userid': u'sha1:e3676dc08fd42cbb74cbcd7d77ff87b5f0225efb', u'app-id':u'sha1:8b9dcb03444de65755802dd6e65dc134f6c35bff'}}, u'renewable': False}
>>> print v.client.token
u'c2faafc8-fdaa-f92d-423a-6bc57debcb8a'
>>> print client.is_authenticated()
False

Makes me sad.  read/write work, even if is_authenticated lies to you.  You can go forth and write, read, etc (per policy)

Well, that method simply calls GET /auth/token/lookup-self. So either this is a bug in Vault or we need a better way to check if the token is valid.

right, I have no idea, I'm very very new to vault, so still learning (today is day 2).

I encountered the same issue, and realized that the lookup-self policy is not enabled by default on new tokens. So there are a few possible "solutions" here:

Ensure that all policies (even ones for AppID authentication) have explicit read access to auth/token/lookup-self
Don't rely on is_authenticated() to tell you the truth just try to read secrets.
Open an issue with the Vault team and ask if this is an intentional feature or an accidental bug.

Seems vault knows about it, and fixed it (on Nov. 6th):
https://github.com/hashicorp/vault/issues/732

I think the suggestions by hobbeswalsh are currently the best solutions to this problem. If anyone has other suggestions for how we can fix this in Vault, I would appreciate it :)