Error in summary.connection(connection) : invalid connection

Project Robyn
I'm getting this error when running robyn_outputs step.

Running Pareto calculations for 10000 models on 3 fronts...
Error in summary.connection(connection) : invalid connection

My dataset has about 300 rows and 40 variables, and I'm running on 2000 iterations * 5 trials. When I was on old 3.6x version of Robyn everything is perfectly fine. I looked at previous issues and tried manually changing cores to be 1 or 7 (as max is 8) but it still doesn't work
Environment & Robyn version

Check and share Robyn version: 3.7.2
R version 4.2.2
Running on windows

Can you please share your sessionInfo()$R.version? Also, can you try installing this commit version using remotes::install_github("facebookexperimental/Robyn/R", ref="80dbaa0018422bde2a65826398eeea364ed28d33”), then restart, reload the lib and retry to see if the error still occurs?

$platform
[1] "x86_64-w64-mingw32"
$arch
[1] "x86_64"
$os
[1] "mingw32"
$crt
[1] "ucrt"
$system
[1] "x86_64, mingw32"
$status
[1] ""
$major
[1] "4"
$minor
[1] "2.2"
$year
[1] "2022"
$month
[1] "10"
$day
[1] "31"
$svn rev
[1] "83211"
$language
[1] "R"
$version.string
[1] "R version 4.2.2 (2022-10-31 ucrt)"
$nickname
[1] "Innocent and Trusting"
btw I cant install the commit version

I was having a similar issue earlier today.
I ran the code successfully a few times this morning but sometime mid-day I started having the same connection error at the same point when I switched from Geometric to Weibull-PDF adstock. After the inital error I still had the connection error code occur even when I switched back to the Geometric models.
I restarted my R session and ran the code provided above from the contributer: * Note I had to retype the last quotation mark*
remotes::install_github("facebookexperimental/Robyn/R", ref= "80dbaa0018422bde2a65826398eeea364ed28d33" )
This code required me to update my Plyr package from version 1.8.7 - 1.8.8; after running I was able to run a Geometric model where before it would fail at the first trial and provide the connection error that Cynthia received.
I was able to confirm I can make a Weibull model after running the above code which updated the plyr package.
:: Here is my R session Information ::
$platform
[1] "x86_64-w64-mingw32"
$arch
[1] "x86_64"
$os
[1] "mingw32"
$crt
[1] "ucrt"
$system
[1] "x86_64, mingw32"
$status
[1] ""
$major
[1] "4"
$minor
[1] "2.1"
$year
[1] "2022"
$month
[1] "06"
$day
[1] "23"
$svn rev
[1] "82513"
$language
[1] "R"
$version.string
[1] "R version 4.2.1 (2022-06-23 ucrt)"
$nickname
[1] "Funny-Looking Kid"

That's really useful information @Alopes-data
Just checked and plyr package was updated to 1.8.8 (in CRAN) a couple of days ago (2022-11-11). What's weird is that plyr changelog shows only check fixes, no new feature, bugs, or change of default behaviors since almost 7 years ago.

This is quite puzzling that you have different file size than your colleagues. What machines / OS systems are you and your colleagues using?

@gufengzhou We're all on Windows. I compared the OutputModels objects and it seems like mine is much larger due to the vec_collect - which is in current version robyn_run fuction but not in previous version. It creates additional xDecompVec etc. variables in trail[i] and also vec_collect item on its own.

Hello! Can you guys update to latest dev version and check how it goes? I've reduced the size of the OutputModels by aggregating results into a single aggregated dataframe thus returning a 50% lighter object.

@laresbernardo Hi I re-ran with demo datasets on 2000 iterations * 5 trials and compared the size of OutputModels for 3 different recent packages:
3.8.1 - 538.1MB
dev version you posted above - 1GB
3.8.2 - 563.1 MB (please note that I was trying to install 3.7.2 using remotes::install_github("facebookexperimental/Robyn/R", version='3.7.2'), however for some reason it installed 3.8.2 instead). I think compared to 3.7.2 it still has all those additional xDecompVec items in each trial although vec_collect so the size is down to half compared to what I saw earlier

Hi @cynthia10wang can you run it once more with latest version (3.8.2 - just released)? We got rid of that vec_collect list and are calculating the decomp values from bottom to top so no memory issues should occur. Sorry for all these changes but we believe this last iteration will be the final onwards.

Yes I checked version before running those 3 comparisons and the last one is 3.8.2
My point is that it's still significantly larger than 3.7x versions due to xDecompVec...and I'd like to reverse back to 3.7.2 so that I can get the exact size of same OutputModels, but I can't seem to install 3.7.2 now.
With uninstalling and installing remotes::install_github("facebookexperimental/Robyn/R", version='3.7.2'), it's still installing 3.8.2 for me

To downgrade<EMAIL_ADDRESS>But I'd recommend you keep using the latest version so you can leverage all the new features and bugs fixed. If you actually ran the latest version I deployed a couple of hours ago, then you shouldn't have the vec_collect list, so the size of your output won't be as large as you mention. Please, check again and after you change any version, you must reset your session.

Sorry just realized I missed typing two words in the previous comment where I posted the screenshot so it might be confusing.

Yes, in 3.8.2 vec_collect is gone, so size of OutputModels is down to half compared to 3.8.1 or one of the 3.8.1 dev version
However, it's still quite larger than 3.7.2, because although vec_collect is gone, xDecompVec, xDecompVecImmediate, xDecompVecCarryOver are still in each trial; while 3.7.2 doesn't keep all these in OutputModels. I successfully downgrade my version to 3.7.2 and running the demo with everything else the same, the size of OutputModels is only 37.9MB, compared to 563.1 MB from 3.8.2.

Attached is the OutputModels screenshot from 3.7.2 - you can see the differences compared to the previous screenshot I attached from 3.8.2.

Unless the three (xDecompVec, xDecompVecImmediate, xDecompVecCarryOver) are kept there for further use, otherwise it could have a huge impact on larger dataset/# of iterations etc.

YES! You're absolutely right, I missed that redundancy. I've just merged all 3 results (xDecompVec, xDecompVecImmediate, xDecompVecCarryOver) into a single data.frame (xDecompVec) for OutputModels object. Doing this reduced the results from 563 MB to 330 MB [41% reduction], following the demo (5 trials, 2000 iterations) as you did.
We are already delivering ~30% of the 3.8.1 version OutputModels size and probably there are a few other things we can do to keep reducing the size but not much without having to re-calculate these results.

Last commit reduced OutputModels size to 246 MB (using the same demo example), so we are now 78% smaller than 3.8.1 version! Is it good enough for you to adopt this new version which is 6-ish times larger given we've split immediate and carryover effects?

Hi, some of our models are at least 300~400M big under 3.7.2 and upgrading to 3.8.1 meaning about 1.5-2GB difference and we found that it sometimes causes issues like Rstudio crashing and parallel plotting errors (using 1 fewer cores still doesn't help).
Is there a way to turn this off if we're not doing calibration?

@cynthia10wang can you please update to latest version (3.8.2) and see how it goes? It will be larger than the results you had when running 3.7.2, but that's because we are splitting immediate and carry-over effects for each model not only to calibrate against one of them but to provide the % of carryover / immediate response for each media variable (paid and not paid). That's something we can't run off because we strongly believe this information will be helpful for users to pick the model that best describes their marketing strategy and understand the mid-term effect of their marketing efforts.

Hi, some of our models are at least 300~400M big under 3.7.2 and upgrading to 3.8.1 meaning about 1.5-2GB difference and we found that it sometimes causes issues like Rstudio crashing and parallel plotting errors (using 1 fewer cores still doesn't help). Is there a way to turn this off if we're not doing calibration?

@cynthia10wang We'll try further reducing the object size in the future. Until then, maybe one work-around.: you could also try reducing the sizes by running less iterations each time --> e.g. you could run like 20005 to see how the hyperparameter ranges change in higher iterations, then narrow down the hyppar ranges and rerun 20005 etc or even less, if you can observe the metrics converge. This way you could avoid having to go for large iters in one go. Let us know how it works for you.

I'm on version 3.9.0 on Windows 10 OS and am having this same issue where I run out of memory while trying to export the one pagers. It get's through the first few and then fails. My OutputModels object is over 1.5GB with each trial having a xDecompVec being 596,596 rows.

Closing this task given it's been inactive for some months. Feel free to re-open.

Hello, I have the same problem on Robyn <IP_ADDRESS>00. I can't output models if I set clusters to TRUE, this is the error

Running Pareto calculations for 10000 models on auto fronts...
Automatically selected 5 Pareto-fronts to contain at least 100 pareto-optimal models (111)
Calculating response curves for all models' variables (555)...
Error in summary.connection(connection) : invalid connection

Hi @Luinehil as mentioned in this thread, this is a memory issue. Did you try with less iterations or less trials? We are currently working on a way to reduce the size of these objects so users don't get memory problems this easily (10K models in your case). We'll update once we have a permanent scalable solution.

Hey @laresbernardo I have managed to get a clustered output on Robyn 3.9.0, on 2 trials with 2000 iterations but I had to do it twice (as I got the same error on the first run), and it took almost 99% of my memory (I work on Win 11, 32GB RAM).

or in summary.connection(connection) : invalid connection when I run the model and I want to change the train size to use 90% data. When I say train_size=0.9 -- it is erroring out.


Sweep: please add a utilsService (✓ Sandbox Passed)

Description
This pull request adds a new utilsService to the src/lib/services/utils directory. It includes a diff method for calculating the difference between two timestamps in seconds, minutes, hours, or days.
Summary

Added new file utilsService.ts in src/lib/services/utils directory
Added new test file utilsService.test.ts in src/lib/services/utils directory
Implemented diff method in UtilsService class to calculate time differences in seconds, minutes, hours, or days

Fixes #26.

🎉 Latest improvements to Sweep:

New dashboard launched for real-time tracking of Sweep issues, covering all stages from search to coding.
Integration of OpenAI's latest Assistant API for more efficient and reliable code planning and editing, improving speed by 3x.
Use the GitHub issues extension for creating Sweep issues directly from your editor.

💡 To get Sweep to edit this pull request, you can:

Comment below, and Sweep can edit the entire PR
Comment on a file, Sweep will only modify the commented file
Edit the original issue to get Sweep to recreate the PR from scratch

Rollback Files For Sweep

[ ] Rollback changes to  src/lib/services/utils/utilsService.test.ts
[ ] Rollback changes to  src/lib/services/utils/utilsService.ts

Can we change the diff signature to use enums?

Can we change the diff signature to use enums pleaes?


Allow inheritance from resilient classes with missing members

When a class has missing vtable entries, we don’t allow it to be subclassed. This is unnecessarily restrictive for resilient classes, and @_implementationOnly imports now make missing vtable entries much more common. This PR carves out an exception to that rule for resilient classes.
Fixes rdar://problem/50902125.

@swift-ci please smoke test

Ah, nice catch.


Installation error

Describe the bug
Hello could you please help me with my instalation it crashes every time and takes 1gb of my storage
What did you expect to happen?
To install bazzite
Output of rpm-ostree status
I cant:(
Hardware
I have amd processor and amd graphic 1tb and 2tb m2 ssd and gygabyte motherboard
Extra information or context
Please message me back

Same problem. You can try this fix:
https://docs.bazzite.gg/General/Installation_Guide/troubleshoot_guide/
Note: this didn't work for me :(


Lepiter: Roam Import breaks when collapsible parenthesis are used inside the DB

The functionality I refer to: https://twitter.com/RoamResearch/status/1338741084256669699?s=20
When you put something between double parenthesis (and it's not a block reference) - Roam will show that as a collapsed roam glyph.
When this is used in DB you're trying to import - the import breaks with the assertion on the length of the uuid (as it's trying to treat that thing as a block).

for the record - tried again and this is still broken :(

on removing the cases when the above  breaks, it crashes now with json parser being unhappy about unicode encoding 🙈

and then

Thanks for trying.
We expect to get a UTF-8 encoding.
It's hard to fix problems without a concrete input that we can reproduce. Do you happen to have such an input that we can utilize?

will provide a simplified test input in a bit!

ok, first one is easy - havin a string longer then 24 chars in brackets triggers the assert
lepiter-canary.zip

We expect to get a UTF-8 encoding.

I think that one is caused by Roam mangling an emoji sometimes when it's at the end of the block 🤔. It makes sense that you can't parse that mangling, but it should probably just result in a weird character vs import getting broken

for the last error - I thought it'd be something like a reference to a block that doesn't exist anymore, but failing to create a repro for that so far


oci_tarball: set time, user and group to reproducible values for Linux

Applied suggestion for Linux from:
http://h2.jaguarpaw.co.uk/posts/reproducible-tar/
Left out MacOS and other systems for now (waiting for tar toolchain).
MacOS does not have the same options for tar, for now fixing this only
for Linux.

Follow up for #380.

this is a gnu tar flag, this won't work on other tars...for reference bsd/mac tar uses --uname and --gname

We'll fix this after we have https://github.com/aspect-build/bazel-lib/pull/468 so the same hermetic tar is used everywhere.

Rebased PR with the revert for #380.
Updated to set parameters only for Linux (I could also set parameters for Mac, but I don't have a way to test it, so preferred to leave the functionality unchanged for Mac). Optimally it would be better to use the tar toolchain (https://github.com/aspect-build/bazel-lib/pull/468), but not having reproducible tars is a regression when migrating from rules_docker to rules_oci, so I'd personally prefer to have it fixed in the meantime.

Sorry, I'd rather not merge a fix that's only for one platform, that just leaves both the original bug and also some tech debt for us to remove. #385 is probably the better change, though it may take a couple weeks to land. I suggest you apply this patch in your own repo for now.

Sure. Is #385 already dealing with reproducible tars or it's just starting
to use the tar toolchain?

The tar rule in bazel-lib should already be reproducible, that's part of its API contract.

okay I updated that PR with halfway working implementation that uses an mtree file to exactly specify deterministic content of the tar file.
Not sure when @thesayyn or I will get time to finish it...

Thank you! Let me know if I can help in any way (I could contribute
something if necessary).
Surely I will test this implementation.

Can confirm that #385 already implements reproducible tars.


It seems the matrix output don't correct

I input the matrix,for example
$ \begin{matrix} 1 & 2 \\ 3 & 4 \\ \end{matrix} $,
But the output seems don't correct
Would you like to give me some suggestion?
thanks a lot

I tried \\[ \begin{matrix} 1 & 2 \\\ 3 & 4 \\ \end{matrix} \\] and it works as expected. But it seems the $ separator is not working correctly. Will investigate

also tested $$ \begin{matrix} 1 & 2 \\\ 3 & 4 \\ \end{matrix} $$ and
```latex
\begin{matrix} 1 & 2 \\\ 3 & 4 \\ \end{matrix}
```

they both work


Fix a misspelling

README.md: mainteners -> maintainers

Glad that such important PR has been merged. Thanks for contribution!


Does this work with serverless?

I was wondering if I can use Nanoexpress in cloud functions of firebase or lamda of aws.

Hi. Sadly, nanoexpress does not work with serverless framework. But you can check my dev env based on Lambda API which works in any serverless environment as possible.
https://github.com/dalisoft/lambda-api-dev-env

Thanks for that!

Thanks for that! :)


Added my part to the story

Following the tutorial lead me here... not sure what else to write here...

This should resolve all the merge issues, move my part of the story below the image.


Add Derivation Sections to SSP

Add the Derivation blocks of text (and equations) between Instance Models and Data Definitions. Making this a separate issue so I can close #271.

b1db4ff8a409ea49f6aaa94fe30357092919d8f2 closes this. Wait till #319 to finish the one section that requires matrices. There are also a few issues with indexing which needs #265


Update NCCL version to the latest release v2.6.4-1

System information

TensorFlow version (you are using): master
Are you willing to contribute it (Yes/No): No

Describe the feature and the current behavior/state.
Could you please update NCCL used within TensorFlow building to the latest release v2.6.4-1: https://github.com/NVIDIA/nccl/releases/tag/v2.6.4-1
Will this change the current api? How? No
Who will benefit with this feature?
Needed to enable new NCCL features (in particular network collectives).
Any Other info.

@artemry-nv,
Is this still an issue?
Please feel free to close the issue if resolved. Thanks!

What is the current NCCL version used for TF building?


simplify travis

The issue section of the repo mentioned in the helper file is gone.
Given the time that has passed, I assume it is fixed by now.
(PR for test run to trigger)

Works. @juliusv

:+1:


Support for custom dataset training

Thanks for your great effort and the results you have provided.
I wonder if you have any plans to provide a guideline on how to create custom dataset TSV files.
I am interested in reproducing your COCO dataset training results, but I am facing difficulties due to a lack of resources for creating TSV datasets.
I attempted to recreate the 'image_embedding_after' and 'image_embedding_before' data from the raw 'image' data in the flickr30k's TSV dataset, but unfortunately, I was unsuccessful in doing so.
For instance, I tried to using the data you provided in the HuggingFace dataset's flickr_tsv, which can be found here.
from ldm.modules.encoders.modules import FrozenClipImageEmbedder

# First solution
image = Image.open(image_path)
image = transforms.ToTensor()(image).unsqueeze(0).cuda()
clip_image_embedder = FrozenClipImageEmbedder("ViT-L/14", device="cuda", jit=False, antialias=False)
image_processed = clip_image_embedder.preprocess(image)
outputs = clip_image_embedder(image_processed)

# Second Solution
model = CLIPVisionModel.from_pretrained("openai/clip-vit-large-patch14")
processor = AutoProcessor.from_pretrained("openai/clip-vit-large-patch14")
inputs = processor(images=image, return_tensors="pt", padding=True, max_length=77, truncation=True)
outputs = model(**inputs)

The outputs I obtained are different from the "image_embedding_before" and "image_embedding_after" in the flickr_tsv dataset.
If you are unable to provide a solution directly at the moment, I would greatly appreciate any advice or guidance you can offer to help me resolve this issue.

Hi, thanks for interesting our work. I have uploaded three scripts that we used for getting TSV in DATA folder.
First run process_grounding.py to get all CLIP features (text and image) (before and after linear projection layer). Each embedding (for one bounding box) will be saved as a single file. The provided code is used for our data (GoldG, SBU, CC3M and O365). You may need to write you own init and getitem functions to fit your own current data format.
Then, please run mydata_to_tsv.py to create a tsv file.

Thanks for your sharing!!
I want to reproduce COCO2017D experiment from your paper.
If you don't have enough resources to provide TSV generation for the COCO detection dataset, I would like to contribute codes in your process_grounding.py.
Do you mind if I do that?

Oh, I didn't know that O365 annotation json format is the same with COCO format.
I successfully convert the COCO annotation data with your process_grounding.py.
Thanks a lot!

Hi, can I ask where is the process_grounding.py file? Cause now I cannot find it

Hi!
I attempted to reproduce your training step as follows:
python DATA/process_grounding.py --is_o365 True --json_path /home/joonjeon/data/COCO/training/stuff_train2017.json --image_root /home/joonjeon/data/COCO/training/images/
python DATA/mydata_to_tsv.py --which_dataset detection
python main.py --name=COCO --yaml_file=configs/coco2017D.yaml --official_ckpt_name=sd-v1-5-pruned.ckpt

But the error message says:
Traceback (most recent call last):
  File "/home/joonjeon/SDPipeline/GLIGEN/main.py", line 76, in <module>
    trainer.start_training()
  File "/home/joonjeon/SDPipeline/GLIGEN/trainer.py", line 388, in start_training
    loss = self.run_one_step(batch)
  File "/home/joonjeon/SDPipeline/GLIGEN/trainer.py", line 367, in run_one_step
    model_output = self.model(input)
  File "/home/joonjeon/miniconda3/envs/pytorch/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/joonjeon/miniconda3/envs/pytorch/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/joonjeon/SDPipeline/GLIGEN/ldm/modules/diffusionmodules/openaimodel.py", line 433, in forward
    objs = self.position_net( **grounding_input )
  File "/home/joonjeon/miniconda3/envs/pytorch/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/joonjeon/miniconda3/envs/pytorch/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
TypeError: forward() got an unexpected keyword argument 'boxes'

What should I do?

Hi? Could you share the proper config file for COCO2017D?
I tried to modify the configuration file for training on COCO2017K dataset to do so, but as the result of training, the bounding boxes won't match with the desired objects.

The same issue occurs with flickr.
I followed the exact steps as mentioned above, but even after training the bounding boxes won't match with the desired objects.
Please help me..

When I attempt to merge TSVs, the following error occurs:
ValueError: invalid literal for int() with base 10: '113880\t{"data_id": 113880, "image": "/9j/4AAQSkZJRgABAQAAAQABAAD/2wBDAAgGBgcGBQgHBwcJCQgKDBQNDAsLDBkSEw8UHRofHh0aHBwgJC4nICIsIxwcKDcpLDAxNDQ0Hyc5PTgyPC4zNDL/2wBDAQgJCQwLDBgNDRgyIRwhMjIyMjIyMjIyMjIyM


Add support for glTF extension: KHR_texture_transform

Add support for glTF extension: https://github.com/KhronosGroup/glTF/tree/master/extensions/2.0/Khronos/KHR_texture_transform
Currently failing related tests on: https://github.com/cx20/gltf-test:

Priority of this may change if users request / require this extension to be supported.

Note that we already support the scale and offset attributes of this extension https://github.com/playcanvas/engine/blob/master/src/resources/parser/glb-parser.js#L923.

I tested it on the latest version of PlayCanvas and noticed that the results have changed.
Is this an expected change?

Library
TextureTransformTest.gltf result

PlayCanvas v1.44.2

PlayCanvas v1.45.0

I don't know if it's related to the above, but I can see some changes in the test results of the KHR_mesh_quantization extension model.

Library
Duck/glTF result
Duck/glTF-Quantized result

PlayCanvas v1.44.2

PlayCanvas v1.45.0

Thanks @cx20, I will address the texture transform issue.

Thank you so much.
I have confirmed that TextureTransformTest.gltf and glTF-Quantized Duck.gltf are displayed correctly in PlayCanvas v1.46.0.

I think TextureTransformMultiTest.gltf has also improved considerably.
There seems to be some issue about Unlit and Clearcoat Normal.

PlayCanvas v1.45.3
PlayCanvas v1.46.0

Hmm, It is the display result of PlayCanvas v1.46.0 + TextureTransformMultiTest.gltf above, but it seems that a shader error is appearing. Is it a matter of usage?
playcanvas-latest.js:15394

Failed to compile fragment shader:
  :
ERROR: 0:61: 'vUv0' : undeclared identifier
ERROR: 0:61: '=' : dimension mismatch
ERROR: 0:61: '=' : cannot convert from 'const highp float' to 'highp 2-component vector of float'

Been a while since this issue was updated @slimbuck. Would you like to reassign this to @GSterbrant perhaps?

This is fixed

Oh, was it fixed in this PR: https://github.com/playcanvas/engine/pull/4254
Because the deployed glTF viewer still shows the problem.

Actually I was trash talking. Unlit was still broken.
However: https://github.com/playcanvas/engine/pull/4396

@slimbuck  Cool OK, so when we deploy 1.55.0 this week, @cx20 can flip the cross to a tick for that test?

yep

I tested it again with PlayCanvas v1.55.0. I think the test below has passed.
PlayCanvas v1.55.0 + TextureTransformMultiTest.gltf result:


Change position of SwiperControl

Improvement request:
It would be great to being able to put the swiper control arrows somewhere else on the screen.
In my case, I don't want them to be centered, instead I need them somewhere more to the top of the screen.

I want this feature, too.

I want this feature as well. Like JS Swiper library. Or am I missing something?

Is this currently being worked on, also hiding arrows would be cool as well.

How about size of SwiperControl ? or may be a custom swiper icon.


Reduce published package size

After adding adding grid-styled to opencollective/frontend, we noticed the node_modules directory grew larger than expected.
Analysis graph from Duc:

With styled-space being included with the installation of grid-styled, the devDependencies for styled-space are installed. This includes everything from styled-system, i.e. the large examples/ directory.
This PR removes any file or directory not required for the published package to work:

src/
styled-space/
.babelrc
travis.yml

node_modules was also added to the .gitignore to prevent it being accidentally added when committing to this repo.

Awesome! Thanks!

:tada: Updated analysis graph:


Fixed console-ui bundle readme grammar

Checked the Grammar of the readme file and made the required changes.
This was done to improve the overall quality of the project files.
Fixed: Issue

[x] 👩🎓 I read contribution guidelines
[x] 🐞 Pull request introduces a BC-Break
[x] ✅ Pull request is covered by tests
[x] 📒 Pull request is properly documented in docs

To make Signed commits we don't need to make a sign-off, what we need is to configure GPG keys associated with our Github account.  Check docs at https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification#gpg-commit-signature-verification and https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits
If you have any questions don't hesitate to ask. Thank you for contributing

Hey, I've set up my gpg. However could you please guide me regarding how can I signoff this pull request now

To make Signed commits we don't need to make a sign-off, what we need is to configure GPG keys associated with our Github account. Check docs at https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification#gpg-commit-signature-verification and https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits
If you have any questions don't hesitate to ask. Thank you for contributing

Thanks a lot @kpicaza. I have signed my commit. Thank you for helping me out and will be happy to contribute to this repository in future too.😊

Thenks @VividhPandey003 We will be  glad to see you here again :muscle::muscle::muscle:

Hey, @kpicaza could you please add hacktoberfest-accepted tag to my pull request.😊😊


Pre-trained Weights

Hi @hamidriasat!
Do you have any pre-trained weights to share?
Thanks

Sorry, I trained it on my own custom dataset.

No problem! I'm gonna train on Cityscapes and share with you the weights.

@EscVM have you trained it on Cityscapes?

Hi @hamidriasat! Yes, I trained it but I obtained very awful results :) I didn't have enough time to catch the problem and so I left it. If you want I can share my notebook with you!

Yes kindly share the notebook.


Improve yes.lua

Cache the printing string, instead of repeatedly building it.
Referencing #20

Any update on this?
Ping @mubaris

Sorry, I forgot about this


[ddc/dart2js] lib/html/transition_event_test.dart times out on DDC canary bot

This test went from flaky to timeout on ddc-canary-linux-chrome and ddc-canary-linux-chrome-unsound. It is also flaky on a number of dart2js and ddc bots.

Note that the flaky => timeout transition is probably caused by a change I made int the test to properly use async-helper: https://github.com/dart-lang/sdk/commit/6b8224d2e5ca9633a2c1d50960f36c268e3b7b75

I just approved Pass -> Timeout on the ddc-canary-linux-chrome-unsound config.


Tracklist parsing is broken

Just tested this today with the following url: "https://www.1001tracklists.com/tracklist/1lmf4011"
Am seeing the following:
Traceback (most recent call last):
  File "<input>", line 1, in <module>
  File "\lib\site-packages\tracklists\tracklists.py", line 61, in __init__
    self.fetch()
  File "\lib\site-packages\tracklists\tracklists.py", line 68, in fetch
    self.load_metadata(left_pane)
  File "\lib\site-packages\tracklists\tracklists.py", line 98, in load_metadata
    for interaction_detail in left_pane.find_all("meta", itemprop = "interactionCount"):
AttributeError: 'NoneType' object has no attribute 'find_all'

Seems like 1001tracklists updated the website structure again.
I'll try my best fixing this fast but would also be happy about a PR.

@tha23rd Normally the URL ends with ".html" (For example "https://www.1001tracklists.com/tracklist/z2hq2zk/lane-8-spring-2022-mixtape-2022-03-30.html")
I used this api today and it worked just fine

Thanks @bloedboemmel. I'll close this for now.

Getting the same error as @tha23rd even when using:

url = "https://www.1001tracklists.com/tracklist/z2hq2zk/lane-8-spring-2022-mixtape-2022-03-30.html"
t1 = Tracklist(url)

Did you fix it?


Fix circular dependency found by Node.JS 14

Istanbul version 0.4.5 seems to produce a circular dependency when using Node.JS 14
(node:23084) Warning: Accessing non-existent property 'VERSION' of module exports inside circular dependency
    at emitCircularRequireWarning (internal/modules/cjs/loader.js:650:11)
    at Object.get (internal/modules/cjs/loader.js:664:5)
    at Object.<anonymous> (/home/robert/Documents/HOPR/hoprnet/node_modules/sc-istanbul/lib/command/help.js:9:37)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
    at Module.load (internal/modules/cjs/loader.js:928:32)
    at Function.Module._load (internal/modules/cjs/loader.js:769:14)
    at Module.require (internal/modules/cjs/loader.js:952:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at /home/robert/Documents/HOPR/hoprnet/node_modules/sc-istanbul/lib/util/factory.js:56:35

The problem seems to be that  VERSION is loaded before lib/commands/index.js is built and ready to be exported.
Requiring VERSION once it is needed, namely once the help command runs, solves the problem.
Referring to issue https://github.com/hoprnet/hoprnet/issues/1241.

Coverage remained the same at 97.523% when pulling e735f69e55856b4b3c55638b34cd40b87f55bc46 on robertkiel:master into bc84c315271a5dd4d39bcefc5925cfb61a3d174a on gotwarlost:master.

Same error on Node v.15.5.0. thx for the PR, hoping it will get merged asap

A simpler change is just to read the VERSION from Command defined in line 6:
var Command = require('./index.js'),
...
    // VERSION = require('../../index').VERSION
    VERSION = Command.VERSION,

👍 Can we get this change merged?

@gotwarlost Hello from 2023. Can we please get this merged?

Assuming this repo remains confusingly not archived, from npm's instanbul:

This module is no longer maintained, try this instead: npm i nyc Visit https://istanbul.js.org/integrations for other alternatives.

Looking for a fix on this issue.  The nyc command doesn't seem to fix the issue in the babel-plugin-istanbul package, which seems to be the cause of this.
Thanks,


Ask for metrics code

Hello,
sorry for bothering
recently, I am confused about the matting metrics like 'SAD' and 'MSE', 'Gradient' , 'Connectivity' , do you have codes for that? It would be great help to me. Thanks~

its here:
https://github.com/foamliu/Deep-Image-Matting/blob/master/utils.py

Thank you for your reply!
In this file, I see 'SAD'and 'MSE'. Can you provide code about 'Gradient' and 'Conenctivity'?
Thank you agin~

It is not done yet, please feel free to create a PR for this.

Thank you for your reply!
In this file, I see 'SAD'and 'MSE'. Can you provide code about 'Gradient' and 'Conenctivity'?
Thank you agin~

Hello, have you solved this problem? I also don't know how to code this two metrics

I need too.

Hi,
I think you can find them here.
https://github.com/JizhiziLi/GFM/blob/master/core/evaluate.py


implement resource pool client

This repo contains resource pool server implementation which helps to select VF from right resource pool based on tokenID passed from client in the service request.
Can we also extend it to have client implementation so that VF attachment support available for endpoint container?

Sounds good to me.
@Bolodya1997 Looks like it is related to your owning component. Could you also take a look at the suggestion?

We can extract some common logic and create a client chain element, but there is some basic problem with it.
When we are selecting VF for the Client requesting VFIO mechanism we have such scheme:
Client  --( token ID  )->  Forwarder
Client  <-(IOMMU group)--  Forwarder

With Endpoint there will be another scheme:
Forwarder  --(        )->  Endpoint
Forwarder  <-(token ID)--  Endpoint

So the only way to pass IOMMU group back to the Endpoint is to make second Request from the Forwarder. And there is no way to make this selection before we get token ID from the Endpoint.
So yes, we can add some client chain element to select a VF for the Endpoint and inject it in there, but there will be a problem to tell what we have selected back to the Endpoint.

@Bolodya1997 Good find! in case of smartnic scenario, the VF would be just a kernel interface (also can be used as a DPDK device) configured inside endpoint container with IP address and routes (though interface name is derived in the forwarder) sent by endpoint upon service request. I hope that would be sufficient for endpoint to figure out which interface belongs to which p2p network in case if that's needed by endpoint application, it also has to have extra logic to figure out pci address of the VF device in dpdk scenario.
/cc @JanScheurich

Mellanox SRIOV VFs are always bound to their mlx5_core kernel driver, so the netdev will be visible to the NSE pod.
As long as the NSE can map the interface name in the pod to the connected client, we should be fine. It is possible to map the netdev to the PCI device address for use with DPDK. Is the netdev interface name signaled to the NSE in the service request?

@JanScheurich A question (to make sure I understand :) ).

Mellanox SRIOV VFs are always bound to their mlx5_core kernel driver, so the netdev will be visible to the NSE pod.

Am I correct that by 'netdev' you mean the kernel interface for the SRIOV VF?
If I'm correct about that, do you mean you want the netdev inserted into the NSE Pods Namespace, or do you mean it is inserted into the NSE Pods namespace?
If you mean it is inserted into the NSE Pods namespace, how exactly is that happening?

Am I correct that by 'netdev' you mean the kernel interface for the SRIOV VF?
Yes

If I'm correct about that, do you mean you want the netdev inserted into the NSE Pods Namespace, or do you mean it is inserted into the NSE Pods namespace?
The SmartVF netdevs must be inserted into the NSE and NSC pod namespaces. Otherwise the NSC/NSE could not use it at all neither via kernel networking, nor as DPDK interface, nor as RDMA interface.

If you mean it is inserted into the NSE Pods namespace, how exactly is that happening?
That's the job of the OVS forwarder. It injects in into the pod namespace and applies all the normal interface configuration for a kernel interface.

Is the netdev interface name signaled to the NSE in the service request?

@JanScheurich currently its not, but in case of ovs forwarder, let it create a service request with interface name in mechanism preference parameter and let NSE use it for mapping afterwards. but application have find a way to retrieve PCI device address using interface name.

That's the job of the OVS forwarder. It injects in into the pod namespace and applies all the usual interface configuration for a kernel interface.

  Happy to have misunderstood there :)

@pperiyasamy

@JanScheurich currently its not, but in case of ovs forwarder, let it create a service request with interface name in mechanism preference parameter and let NSE use it for mapping afterwards. but application have to find a way to retrieve PCI device address using interface name.

I believe there are lots of ways of retrieving the PCI information for an interface:
$ ethtool -i eth0
driver: i40e
version: 1.5.16
firmware-version: 5.04 0x800024cd 0.0.0
bus-info: 0000:06:00.0
supports-statistics: yes
supports-test: yes
supports-eeprom-access: yes
supports-register-dump: yes

and https://github.com/safchain/ethtool


[1.12.0-RC1] Failed to initialize CoreCLR (seccomp regression)

Output of docker version:
Client:
 Version:      1.12.0-rc1
 API version:  1.24
 Go version:   go1.6.2
 Git commit:   1f136c1
 Built:        Wed Jun 15 05:11:00 2016
 OS/Arch:      linux/amd64
 Experimental: true

Server:
 Version:      1.12.0-rc1
 API version:  1.24
 Go version:   go1.6.2
 Git commit:   1f136c1
 Built:        Wed Jun 15 05:11:00 2016
 OS/Arch:      linux/amd64

Output of docker info:
Containers: 3
 Running: 0
 Paused: 0
 Stopped: 3
Images: 69
Server Version: 1.12.0-rc1
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 113
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: null host overlay bridge
Swarm: inactive
Runtimes: default
Default Runtime: default
Kernel Version: 4.2.0-36-generic
Operating System: Ubuntu 15.10
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 15.56 GiB
Name: emu
ID: LKRP:5O4R:KBMJ:MAMD:BDVP:RUTH:SDKP:UNOZ:G44Q:3H3E:HMZ3:5LTH
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
WARNING: No swap limit support
Experimental: true
Insecure Registries:
 <IP_ADDRESS>/8

Steps to reproduce the issue:
$ cat Dockerfile
FROM microsoft/dotnet:1.0.0-preview1
ADD project.json .
RUN dotnet restore project.json

$ cat project.json
{
    "name": "Worker",
    "buildOptions": {
        "emitEntryPoint": true,
        "warningsAsErrors": true
    },
    "dependencies": {
        "StackExchange.Redis": "1.1.604-alpha",
        "Npgsql": "3.1.3",
        "Newtonsoft.Json": "9.0.1-beta1",
        "Microsoft.NETCore.App": {
            "type": "platform",
            "version": "1.0.0-rc2-3002702"
        }
    },
    "frameworks": {
        "netcoreapp1.0": { }
    },
    "runtimeOptions": {
        "configProperties": {
            "System.GC.Server": true
        }
    }
}

Describe the results you received:
$ docker build .
Sending build context to Docker daemon 4.608 kB
Step 1 : FROM microsoft/dotnet:1.0.0-preview1
 ---> 1707bb9a2d73
Step 2 : ADD project.json .
 ---> Using cache
 ---> 3fbaf0ff1173
Step 3 : RUN dotnet restore project.json
 ---> Running in 92dee24d170c
Failed to initialize CoreCLR, HRESULT: 0x8007001F
The command '/bin/sh -c dotnet restore project.json' returned a non-zero code: 137

Describe the results you expected:
docker build does not fail.

Running with 1.12-rc1 (non-experimental) I also got:
$ docker build .
Sending build context to Docker daemon 4.608 kB
Step 1 : FROM microsoft/dotnet:1.0.0-preview1
1.0.0-preview1: Pulling from microsoft/dotnet
5c90d4a2d1a8: Pull complete
ab30c63719b1: Pull complete
c6072700a242: Pull complete
2a65fccac866: Pull complete
973b97c12bc6: Pull complete
Digest: sha256:c0ed658db4baf6ee6e455b5059d81448b507ed0344d101e1187c894a1b6cea13
Status: Downloaded newer image for microsoft/dotnet:1.0.0-preview1
 ---> 1707bb9a2d73
Step 2 : ADD project.json .
 ---> 3fbaf0ff1173
Removing intermediate container 43f50a3be052
Step 3 : RUN dotnet restore project.json
 ---> Running in ae78895fe50a
failed to create endpoint hungry_hypatia on network bridge: network e8114286baa69774dae8cb442252c0636344bacfb16464ca16e8c56662fc07a0 does not exist

Not sure if this is expected. Seems to correct itself after a few resets ...

Cc @mrjana @mavenugo!

The Failed to initialize CoreCLR, HRESULT: 0x8007001F is a seccomp regression, my fault, doing a patch.

Fixed by #23593


Add EMP.Money

Add EMP.Money platform, tokens, and initial pools.  App updates coming 1-Apr-2022 @ 1200UTC per Zapmore.
@sircryptomaxi DD reviewed

just use common/getMasterChefApys next time


chore: set up pull request template

Fixes #3
I copied the version from the dev-2.2.0 branch of the main rdmo repo:
https://github.com/rdmorganiser/rdmo/blob/dev-2.2.0/.github/PULL_REQUEST_TEMPLATE.md

How about this one?


compile failed

==> tzdata
Compiled lib/tzdata/parser_organizer.ex
Compiled lib/tzdata/release_parser.ex
Compiled lib/tzdata/util.ex
Compiled lib/tzdata/table_parser.ex
Compiled lib/tzdata/parser.ex
Compiled lib/tzdata/table_data.ex
Compiled lib/tzdata/leap_sec_parser.ex
Compiled lib/tzdata/basic_data.ex
Compiled lib/tzdata/period_builder.ex
Compiled lib/tzdata/far_future_dynamic_periods.ex
Killed

@jschoch Could you provide some more details? What version of Elixir/Erlang, and what OS are you building on? The builds are passing in Travis and locally, so I'll need some more detail in order to help troubleshoot.
/cc @lau

https://github.com/lau/tzdata/issues/4#issuecomment-121946267
this is an AWS t2.micro so it is hitting the 2GB memory issue in the ticket above.

Ah that makes sense, sounds like @lau is working on a fix, so I'll keep this open until the next version of tzdata is released.

This should be fixed in master now.


Offline use?

Hello! I didn't find any similar questions here. Could you clarify whether the library can be used offline? Can I install in static directory bootstrap5 and override links in settings.py? Thank you in advance!

Hi, it looks like you might need some help getting set up. The best place to ask for help is StackOverflow. You will receive answers from a community of programmers!
If you ask your question on StackOverflow and use the tag django-bootstrap5, we'll be happy to reply over there!


Release 10.0.0-alpha.4

Coverage remained the same at 100.0% when pulling 158c671cb597849b3b67245a685f03764dafcc73 on release_10.0.0-alpha.4 into b5968c67a7cfaa919c932230d5021c113437ed70 on master.


Add New Analytics Tab

Describe the solution you'd like
Create a New Page for analytics purposes.
Additional context
For now, show the Total sales for each menu item in the last 7 days and also the total usage of inventory items in the last 7 days to help, restaurant owner to make informed decision and plan for next week accordingly.

Frontend Done, please review: #22
@drs1951  please complete the backend request and let me know, so we can merge and make it fully working.
Thanks
Jay

@jaypatel31 APIs have been created. Please review this PR.
Thanks
Devansh

The issue has been resolved. So closing the issue


HSEARCH-2665 Promote IndexingInterceptor to be no longer experimental

another trivial one..

https://hibernate.atlassian.net/browse/HSEARCH-2665

Merged, thanks!


add Cody: Open Autocomplete Trace View and associated view

Added a Cody: Open Autocomplete Trace View command palette action opens a webview with trace info about the most recently triggered completion. This helps understand what params, prefix, suffix, context, etc., was used. It is only shown in the command palette when cody.debug.enabled is true.
Video
https://github.com/sourcegraph/cody/assets/1976/fa83e9d1-1528-4f42-8f07-ad5f027f87fa
Screenshot

Test plan
Set cody.debug.enabled to true, run the new command palette action (Cody: Open Autocomplete Trace View), and then trigger completions.

@philipp-spiess thanks! And that export idea is a great one.


functions for testing minimization

Would it be useful to gather some of these functions together?  I've noticed they are scattered across the scipy codebase.  I was thinking of something like a scipy/optimize/bench.py module to collect the functions, and add a few new ones.
The functions I have in mind would be smooth functions for minimization and would provide R^N -> R function evaluation, and also the gradient, the hessian, and an evaluation of the hessian-vector product for an arbitrary vector.
But the interface could become a little bit messy.  For example you might want to list one or more local or global mins or argmins for each function.  Maybe someone would also want the roots f(x)=0 when the function is R^1 -> R.  Furthermore, some functions (e.g. Rosenbrock) are parameterized R^N -> R where N can be specified by the user.  Some functions might have box constraints on their domains, or they might have more complicated domain constraints.

@andyfaff @antonior92  Certainly this has been addressed for global optimization. There  are several benchmark tests for minimize, too. Do you think this can be closed?
(Note: trust-constr needs to be added to the list of methods that are benchmarked, but that's a separate issue.)

I think this can be closed, but it would be nice to have all the NIST test cases in the benchmarking suite.

I agree that this can be closed since is a quite old issue and it does have been (partially) addressed over the last years. Even though I do agree with @andyfaff  that there is space for a lot of improvements in benchmarking the optimization methods (i.e. including CUTEst test cases)

So should there be a new issue (enhancement request) that is more specific?


Cannot infer from usage when generic class does not have a member or function parameter/return value of the generic type.

TypeScript Version:  2.1.0-dev.20160830
Code
interface A<T> {
    test(value: Object): value is T;
    // a: T;  // No error if uncommented.
    // or test(value: T | Object): value is T;
}

type B<T> = T | A<T>;

function f1<T>(b: B<T>) {}

function f2<T>(b: B<T>) {
    f1(b); // The type argument for type parameter 'T' cannot be inferred from the usage. Consider specifying the type arguments explicitly.
           //   Type argument candidate 'T' is not a valid type argument because it is not a supertype of candidate 'T'.
}

Expected behavior:
No error.
Actual behavior:
The error reported with the code.
Note that this may seem same as #8619, however here, adding a member of type T, or a function with a parameter/return value of type T, solves the issue.

Please see https://github.com/Microsoft/TypeScript/wiki/FAQ#why-doesnt-type-inference-work-on-this-interface-interface-foot--- for more details.

But there is reference to T in "value is T".

Unless TS considers "value is T" as just a boolean?

There is not really a "use" of T that the compile can infer from. i.e. a parameter or a property. The main issue here is TS type system is structural, it tries to use the structure to know the type, these are things that would exist at runtime in your js code.


Turn off Antialiasing on webkit 15.3 to avoid rendering issues

Update #4141
The same issue appeared in 15.3 and added as a workaround.

It seems likely this multisampling issue also applies to offscreen render targets (see https://github.com/playcanvas/model-viewer/issues/165). Might be worth setting maxSamples on the device to 1 as well? @mvaligursky

Is there some repro of the issue on iOS 15.3? All related webkit tickets list this as 15.4 only.
https://bugs.webkit.org/show_bug.cgi?id=238022
https://bugs.webkit.org/show_bug.cgi?id=237906
https://bugs.webkit.org/show_bug.cgi?id=237006
https://bugs.webkit.org/show_bug.cgi?id=238196

Although we did not report any bugs, an issue occurred in 15.3 in our service.

To go ahead with disabling of antialiasing for 15.3 devices, we'd need to have an issue to investigate and confirm this is the right workaround. It's possible there is some other bug, possibly in your application, causing the issue.


Adjust how TrailingSemicolon lints List and Map variable definitions

Fixes #627

:+1: Thanks for the pull request!


Move Lookup logic from current Proxy to Forward

Right now, fixes for fallback most likely induce fix in proxy (in fact in the Lookup part)
It would be better to improve plugin Forward instead of Proxy.
However, that needs some adaptation in plugin Forward to implement reusable Lookup and ensure the Lookup can be defined from Setup parameters.

I am wondering. Should we keep support of both: fallback and proxy or it is better not to overcomplicate and just switch to forward?

I would propose the next syntax for fallback plugin with proxy by default for now and making forward default and it in future:
{
    fallback [original] [proxy|forward] RCODE PROXY_PARAMS
}

@miekg , @johnbelamaric : what are the rules for backward incompatibility or deprecation for an external plugin such as Fallback ?
if @ekleiner switch implementation of inner proxy of Fallback from proxy.Proxy to forward.Proxy, most likely the parameters PROXY_PARAMS will change, which will create a backward incompatible path.
Example, right now:
. {
    ...
    fallback NXDOMAIN . <IP_ADDRESS>:53 <IP_ADDRESS>:53 {
        protocol dns force_tcp
    }
}

will become easily:
. {
    ...
    fallback NXDOMAIN . <IP_ADDRESS>:53 <IP_ADDRESS>:53 {
        force_tcp
    }
}

[ Quoting<EMAIL_ADDRESS>in "Re: [coredns/fallback] Move Lookup ..." ]

@miekg , @johnbelamaric : what are the rules for backward incompatibility or deprecation for an external plugin such as Fallback ?

The rules are:
version 1.x.y: announce deprecation
version 1.x.y+1: allow config, but noop the functionality
version 1.x+1.0: deprecate and remove the code

Maybe the wise way is to follow that path : deprecate current "fallback" and create a new one based on the proxy ability of forward plugin.

Big question would be: what name for the new plugin ?

can we name "ffallback" for "forward-fallback" ?

@miekg : is your reply about deprecation about external plugin ?
NOTE: as an external plugin it is not in the released image of CoreDNS ...
hum.. but how do we warn the change of stanza in that case ?
need to version the external plugins ? (at least the one hosted on coreDNS repo ?)

If we do change the name (if we actually need to), how about... "default"

The plan is to deprecated this Fallback plugin based on Proxy plugin as proxy itself will be deprecated soon) and create a similar plugin named "Alternate" that will be based on Forward plugin (using proxy capability of Forward).
Current users of this Fallback plugin will have the deprecation time to move to the other Alternate plugin and adapt to the new syntax.
@miekg : are you o with this solution ?
if Yes, can you create the repo "alternate" : https://github.com/coredns/altenate.
(I guess anyone can create it, but I am not sure what should be the setting and if anyone can do those settings once it is created).
Thanks

[ Quoting<EMAIL_ADDRESS>in "Re: [coredns/fallback] Move Lookup ..." ]

The plan is to deprecated this Fallback plugin based on Proxy plugin as proxy itself will be deprecated soon) and create a similar plugin named "Alternate" that will be based on Forward plugin (using proxy capability of Forward).
Current users of this Fallback plugin will have the deprecation time to move to the other Alternate plugin and adapt to the new syntax.
@miekg : are you o with this solution ?

This is outside coredns/coredns, so being a bit blunt I don't care that much.

if Yes, can you create the repo "alternate" : https://github.com/coredns/altenate.
(I guess anyone can create it, but I am not sure what should be the setting and if anyone can do those settings once it is created).

you should be able to create it.

you should be able to create it.

You are right. I just did it.
@ekleiner : the repo is now available. I am able to define the settings for this repo (I guess because I am the creator).

@fturib, please provide me an access there


Difficulty creating the Imperial Calendar from the Traveller RPG setting

The Traveller RPG has a calendar whereby the first day of the year (Day 1) is called 'Holiday', then from Day 2 onwards it follows a seven-day week. There are no months, it's all a single bucket of days - 'Holiday' on Day 1, then from Day 2 to 365 it's a seven day cycle. (link to calendar here: https://wiki.travellerrpg.com/Imperial_Calendar).
I either end up with the first weekday of the year being numbered '1' (it should be 2), or alternately day 2 falls on the second weekday of the year (it should be the first weekday). Would be great if I could find a way around this so that I could use your wonderful plugin

So would the “month” display on this calendar just show all 364 days? Just trying to understand!

Yeah, there are no months at all, so the single 'month' is 364 days, numbered 002 to 365, with Day 001 being an intercalary day

I sorta have this working by using an intercalary month of length 1 for Holiday.  Of course, the day numbers end up wrong.  Tried it with a Leap Day, and while that works on fantasy-calendar.com correctly with day numbers and everything, it fails in Obsidian Fantasy Calendar.  JSON for the Third Imperium Calendar available, if you can tell me how to send it in.

I sorta have this working by using an intercalary month of length 1 for Holiday.  Of course, the day numbers end up wrong.  Tried it with a Leap Day, and while that works on fantasy-calendar.com correctly with day numbers and everything, it fails in Obsidian Fantasy Calendar.  JSON for the Third Imperium Calendar available, if you can tell me how to send it in.

Thanks for that - yeah, the days numbers don't work out, which is a shame. Thanks for trying!

Oh, the other way to do it is to sat the first day of the week to Senday, but that leaves the weeks not lining up

This is now possible by creating an intercalary leap day.


Max instead of Min?

https://github.com/Anton1o-I/thompson-sampling/blob/578c3724993cefdf058fed1da23cf2dc76135c78/thompson_sampling/exponential.py#L29
Hey man, great package and thank you for creating it, but do you not mean max here?

my bad, misinterpreted the code


add text-based spec format for command tests

In Vintageous, I'm using a plain text format to declare tests for ST commands. This allows me to write the tests much faster than in Python code.
Long-term, I'd like to 'outsource' all the testing to a specialized package like UnitTesting. Given that the text-based approach is generally useful, what do you think about including a similar feature in UT?
Here's an example file:
https://github.com/guillermooo/Vintageous/blob/master/tests/commands/vi_x-internal-normal-mode.cmd-test
My current implementation is very simple, but it could be extended with the following features:

check state of view/window settings
better traceback fo failing .cmd-test
teleport user to failing .cmd-test
options to toggle checking of selections before/after and possibly other options
autogeneration of .cmd-test stubs for all *Command classes found in the project
...

Um, it would be also nice to have some helper functions.

Closing for now. It's been a long time.


deps: update com_google_protobuf to 3.18.1

deps: update guava to v31
deps: update grpc to 1.41.0
deps: update auto-value to 1.8.2
deps: update api-common to 2.0.5
deps: update google-http-client to 1.40.1

Merge after the release pipeline has been fixed.


Honey comb links

Great script and works perfectly in the list view. Something has changed. Previously this worked on a web part page, now there seems to be a height issue and it does not display more than a few pixels from the first row only on a web part page.

I was able to apply some CSS for a quick fix. It seems like Microsoft has a property with a min-height:1px. Adding this code to the page works, but it is not the best solution.
<style> div[role='presentation'] > div[role='presentation'] > div[data-focuszone-id*='FocusZone'] {    min-height: 600px!important;  } </style>

Hi @jaxkookie .
Hmmm, I think the links used to be displayed in the List Web Part... Maybe the specification of the List Web Part has changed😔
I modified it so that the link is also displayed in the list web part. The modified code is as follows.

Formatting JSON
{
  "$schema": "https://developer.microsoft.com/json-schemas/sp/v2/row-formatting.schema.json",
  "hideSelection": true,
  "hideColumnHeader": true,
  "rowFormatter": {
    "elmType": "div",
    "children": [
      {
        "elmType": "div",
        "style": {
          "height": "150px",
          "display": "=if(@rowIndex%5==0,'','none')"
        }
      },
      {
        "elmType": "div",
        "style": {
          "position": "absolute",
          "width": "150px",
          "height": "150px",
          "left": "=if(floor(@rowIndex/5) % 2 == 0 , @rowIndex % 5 * 150 + 'px' , @rowIndex % 5 * 150 + 75 + 'px' )",
          "top": "=if(@rowIndex%5==0,'','-150px')"
        },
        "children": [
          {
            "elmType": "a",
            "style": {
              "position": "relative",
              "display": "flex",
              "justify-content": "center",
              "align-items": "center",
              "width": "100%",
              "height": "100%"
            },
            "attributes": {
              "href": "[$URL]",
              "target": "_blank",
              "class": "ms-fontColor-themePrimary ms-fontColor-themeDark--hover"
            },
            "children": [
              {
                "elmType": "svg",
                "style": {
                  "fill": "currentColor",
                  "cursor": "pointer"
                },
                "attributes": {
                  "viewBox": "-150 -150 300 300"
                },
                "children": [
                  {
                    "elmType": "path",
                    "attributes": {
                      "d": "M130 75 L0 150 L-130 75 L-130 -75 L-0 -150 L130 -75 z"
                    }
                  }
                ]
              },
              {
                "elmType": "div",
                "style": {
                  "position": "absolute",
                  "display": "flex",
                  "flex-direction": "column",
                  "align-items": "center",
                  "justify-content": "center",
                  "cursor": "pointer",
                  "width": "100%",
                  "height": "100%"
                },
                "attributes": {
                  "class": "ms-fontColor-white"
                },
                "children": [
                  {
                    "elmType": "div",
                    "style": {
                      "font-size": "32px",
                      "margin-bottom": "5px"
                    },
                    "attributes": {
                      "iconName": "[$Icon]"
                    }
                  },
                  {
                    "elmType": "div",
                    "style": {
                      "font-size": "14px",
                      "width": "75%",
                      "text-align": "center"
                    },
                    "txtContent": "[$Title]"
                  }
                ]
              }
            ]
          }
        ]
      }
    ]
  }
}

Vertical spacing between links is wider than before.

I hope you will try the modified code and give me your feedback.

@tecchan1107
thanks for the quick reply. I am not getting the same result. I still see the same result as the image I submitted above.

@tecchan1107 ,
I played around with the code a bit, and I was able to close the gap. in the anchor element, around line 30+, I added this:
"top": "=if(floor(@rowIndex / 4) % 4 != 0,((floor(@rowIndex / 4) % 4) * -10) + (((floor(@rowIndex / 4) % 4) * -10)) + 'px','') "
I have 4 items in a row, but I am sure it is easily adjusted for 5

@jaxkookie
Wooooow! Very cool and nice idea😍😍!!
Based on your idea, I would like to modify the original code as well.
Thank you for the issue and for your great ideas!

@tecchan1107
absolutely; let me know if you need anything.

One thing I added to a secondary view for this was a way to see the colors visually. I have the honeycomb view and a secondary input view. Without replicating the honeycomb, I formatted a column called ColorPreview to see it easily. I hope it helps. Thanks again!

Column Code

{
  "$schema": "https://developer.microsoft.com/json-schemas/sp/v2/column-formatting.schema.json",
  "elmType": "div",
  "style": {
    "display": "inline-flex",
    "text-align": "center",
    "background-color": "=if([$bgColor],[$bgColor],'#002855')",
    "justify-content": "center",
    "align-content": "center",
    "align-items": "center",
    "border-width": "2px",
    "border-style": "solid",
    "border-color": "=if([$fColor],[$fColor],'#cedbea')"
  },
  "children": [
    {
      "elmType": "div",
      "style": {
        "font-size": "1.2em",
        "font-weight": "bold"
      },
      "children": [
        {
          "elmType": "div",
          "style": {
            "color": "=if([$fColor2],[$fColor2],if([$fColor],[$fColor],'#cedbea'))",
            "font-size": "32px",
            "margin-bottom": "5px"
          },
          "attributes": {
            "iconName": "[$Icon]"
          }
        },
        {
          "elmType": "div",
          "style": {
            "color": "=if([$fColor],[$fColor],'#cedbea')",
            "font-size": "14px",
            "width": "100%",
            "text-align": "center"
          },
          "txtContent": "=[$Title]+if([$SubTitle],'\n'+[$SubTitle],'')"
        }
      ]
    }
  ]
}


Cannot rip from tumblers containing sensitive media

Ripme version: 1.7.6
Java version: 1.8.0_144
Operating system: Microsoft Windows [Version 6.3.9600]
Exact URL you were trying to rip when the problem occurred: https://m8aa.tumblr.com/
Please include any additional information about how to reproduce the problem:

Expected Behavior
Get all images from tumbler blog.
Actual Behavior
All images failed to rip, most likely because tumbler is marked as containing sensitive media.
Perhaps being able to input tumbler account credentials into the ripper could fix this?

This was fixed in 1.7.8


Elasticsearch Salt State

@thusoy I've pinned us at 7.6.1 for the version, I think that makes more sense than 7.x.
As for how we handle configuration, I personally prefer templating the actual config file as you know what will be replaced by pillar and what is set by default. I don't see what benefit you get from serializing everything into pillar (other than the files being pre-compiled). Is it difficult to access pillar values? I guess being able to pull back all values at once rather than 1 at a time (if encrypted) wouldn't be bad. I think we should choose 1 way to do it and stick with it

For the pillar_check to actually do anything you need to include it from the init.sls.

I think the only thing missing here is opening up the firewall for port 9200 and 9300. There's an example here that allows outbound DNS and multiple ports, we're doing something very similar where we want to allow outbound DNS and 9300 for the ES user, and inbound tcp 9200 and 9300.


Can't use precompiled binaries in M1 apple chip Macbook

None of those archive work for M1 Apple chip Macbook.  I have followed instruction from here. But while setting they all give same issue which is cannot be opened because it is from an unidentified developer

Hey @123oli , that's probably not to do with platform, but with permissions.
Try opening the location of swanky executable in finder, right clicking and choosing open, and in the popup dialog choose "open" again.
It should run once in the terminal app, and then you'd be able to use it from your cli.

@codespool  While using swanky --version command, it show @astar-network/swanky-cli/1.0.10 darwin-x64 node-v18.2.0 which means swanky installed successfully. But when creating swanky project with command swanky init flipper it throws Cannot find module 'tslib' error and I installed with npm install tslib --force and successfully install but still not working.

@codespool with right clicking and choose open then cannot execute binary file error message display. Why this?

I'm using M1 mac and everything works fine. I haven't checked deeply but it's because Rosetta is not installed?
Basically mac artifacts are targeting Intel x86_64 architecture, M1 mac (aarch64) users need to install Rosetta to be compatible with x86_64 programs.

I'm using M1 mac and everything works fine. I haven't checked deeply but it's because Rosetta is not installed? Basically mac artifacts are targeting Intel x86_64 architecture, M1 mac (aarch64) users need to install Rosetta to be compatible with x86_64.

@shunsukew thanks after installing rosetta it works :)


API Documentation small mistake

In the API documentation, session controller "json/2" gets called with conn even though conn is already in the pipeline.
https://github.com/danschultzer/pow/blob/master/guides/api.md#add-api-controllers

Thanks! Fixed in #416


⚠ Samsung has degraded performance

In df4853a, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2808 ms

Resolved: Samsung performance has improved in af5984b.


Add "appetizer" to LEARN section

we have the quick and informative openziti.io/appetizer page that does a good job of giving an overview of application embedded zero trust but it's not discoverable at this time.
add something to the LEARN section for exploring openziti that links to the page

Consider also linking to the CloudZiti examples too


Open a iframe window show the debug.html in context.html.

I create this pull request because I want to autoload debug.html in many kinds of devices. What do you think about this idea?

@Esoul Thanks! But why you want autoload debug.html in many kinds of devices?
Maybe you want autoreload debug.html. For me debug.html need only when I really debug tests.
Really it's feature not responsibility of karma-mocha plugin. You can try create PR to karma itself. But for me it's strange feature


Cannot close the application via TestFX

Hello, i am trying to use FXGL with TestFx and I can not find a way to close the application via TestFx. I am starting the application via customLaunch, but when running multiple tests one after another i get a logger error. We already tried triggering ALT+F4, but this also throws an error.
My code
@Override
    public void start (Stage stage) throws Exception {
        GameApplication.customLaunch(app, stage);
        TimeUnit.MILLISECONDS.sleep(200);
    }

Errors:
java.lang.IllegalStateException: Logger already configured
    at com.almasb.sslogger.Logger$Companion.configure(Logger.kt:29)
    at com.almasb.sslogger.Logger.configure(Logger.kt)

Can you mention a quick fix for this? I am not so experienced so there might be a workaround for this.
Kind regards

Hi, I'm afraid there is no quick for this as FXGL is not meant to be multi-instance. I will not go into detail, but by design, only a single FXGL instance per JVM will function correctly.
If you do need to test with FXGL, the only viable approach I can think of is to start an FXGL application, do all tests, then close the FXGL application.

Thanks so much for the fast reply!
I am not aiming to run the tests concurrently. Am I understanding it right that the following process is not possible: Start FXGL Game via Test framework -> Run Test -> Close FXGL Game after test -> Run New instance of FXGL -> Run next test.
TestFX is starting a new application for every test so this will obviously not work. My hope was that if I could properly shut down the FXGL Game (maybe with some other testing library or a method via the custom stage) I could somehow achieve the wanted behaviour.

I found a solution which works for now.
When using testfx you can make an extra class for every test.
Then in build.gradle add:
test {
forkEvery = 1
}

Doing so will prevent testfx from starting multiple FXGL instances.

Ah nice, I haven't used TestFX before, seems like a cool framework for testing javafx related stuff.


No ore dubling with create

create ore doubling has been removed.

https://github.com/MrAwesomeRocks/the-latest-summer-fun/blob/fe03aa0b9fbf3477ebd4367f1b2d55d9acf2656d/modpack/overrides/kubejs/server_scripts/theLatestSummerFun/recipes/block.js#L25
This line in particular.

https://github.com/MrAwesomeRocks/the-latest-summer-fun/blob/fe03aa0b9fbf3477ebd4367f1b2d55d9acf2656d/modpack/overrides/kubejs/server_scripts/theLatestSummerFun/recipes/block.js#L25
This line in particular.

https://github.com/MrAwesomeRocks/the-latest-summer-fun/blob/fe03aa0b9fbf3477ebd4367f1b2d55d9acf2656d/modpack/overrides/kubejs/server_scripts/theLatestSummerFun/recipes/block.js#L15
This only adds recipes for ingots and gems, and a milling, not a crushing recipe.
All ore doubling works in single-player.

This only adds recipes for ingots and gems, and a milling, not a crushing recipe.

Yes that is not the line

All ore doubling works in single-player.

No?

Create

I think you overwrote all the crushing recipes with milling recipes.

IE crushing has been gutted, so has thermal pulverizing. Induction smelting has also been removed for all intents and purposes.

And what is the recipe ID?

I think you overwrote all the crushing recipes with milling recipes.

Yup they are all milling recipes. There are some that are not milling recipes, they were added by kjs in
the-latest-summer-fun/modpack/overrides/kubejs/server_scripts/theLatestSummerFun/recipes/block.js
Two example recipe IDs:

create:kjs_1goubo5mcg5sqvxq5b1h3oc3l
create:milling/iron_ore


🐛 [Bug] Scrollbar on mobile

🐛 Bug

Scrollbar on mobile
There is a minimal scroll on my browsers mobile view emulation.
Is this also present on mobiles?
Is it reproducable by others?
Browser: Chromium

A
B

I could reproduce the issue with chrome's developer tools BUT only there. In fact although I tested it with my pysical smartphone, several real devices in browserstack and different browsers I was not able to reproduce it there. So I came to the result that it is just a harmless issue of Chrome's developer tools itself.
Anyway I found an another real issue in relation to scrolling in the Starmap (see screenshots).
The main effort was to test it. It should be fixed now.


Batch Mode for Scanners

This PR started out to make the scanner configurable.  Which then is really about making the scanners to be runnable in batch mode.  In order to make this happen, the individual scanners have to be more self-contained and modular.  This then make scanner.py a lot of simpler, and the individual scanners to be more flexible in their actual implementations.

@carise, this PR is WIP for you to preview the changes, which followed most of our earlier discussion, and give any additional feedback.  This PR only cover the IAM scanner, but will include the other scanners.

@thenenadx, you have worked with the scanner a lot, so would appreciate your feedback here.

@blueandgold Really nice PR! It's lovely, thank you for the initiative.

This PR is now ready for review.

Adding cla: yes label, as the PR author is a googler at the time of this PR was created.


Move implicit initial value check to runtime

Purpose
Purpose of this PR is to relax var length array rules, by move implicit initial value check to runtime. This allows initializing variable length arrays without filler values. However, it will panic if we try to create a sparse array without filler values.
Fixes #15885
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

https://github.com/ballerina-platform/ballerina-spec/issues/216
https://github.com/ballerina-platform/ballerina-lang/issues/15885

PS: This is the updated PR of #15996 for JBallerina.

Codecov Report

:exclamation: No coverage uploaded for pull request base (jballerina@1f1cb40). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             jballerina   #16118   +/-   ##
=============================================
  Coverage              ?    10.4%
  Complexity            ?     2378
=============================================
  Files                 ?     1466
  Lines                 ?    70283
  Branches              ?     8351
=============================================
  Hits                  ?     7314
  Misses                ?    62305
  Partials              ?      664

Impacted Files
Coverage Δ
Complexity Δ

...llerinalang/compiler/semantics/analyzer/Types.java
0% <ø> (ø)
0 <0> (?)

...lang/compiler/semantics/analyzer/CodeAnalyzer.java
0% <ø> (ø)
0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f1cb40...fc3618f. Read the comment docs.


ML.NET tutorials - bug fixes

Fixes #5330
Fixes #5329
Fixes #5343
Fixes #5366
Fixes #5346
Companion PR: https://github.com/dotnet/samples/pull/70
Main things addressed in this PR are:

fix wrong NuGet package name
added link to the whole sample listing
made the VS steps match in both tutorials
Internal Review URL - Sentiment Analysis
Internal Review URL - Taxi Fare Predictor

@JRAlexander I think this is ready for a final review. We need the samples changes merged for this PR to pass.

Closing and reopening to restart failed build


Implement 'Never' type (!)

This allow us to use error(…) in almost all contexts. In particular, it makes the following code compile for all X:
if <some precondition>
  then X
  else error("please make sure <some precondition> is met")

@Bzero This one is for you :smile:

Thanks @sharkdp 😄!


[BUG]: Angle measurement direction when you dimension a line

Describe the bug
Angles are measured in the clockwise direction when you dimension a line (red curve). The typical convention is to go counterclockwise. Also it would be nice if sketch updated changes to dimensions like this when you make them. I am having to leave the sketch and come back to it in order for it to refresh and adjust the lines.

Steps to Reproduce
N/A
Expected Behavior
The typical convention is to go counterclockwise. Also it would be nice if sketch updated changes to dimensions like this when you make them. I am having to leave the sketch and come back to it in order for it to refresh and adjust the lines.
Screenshots and Recordings
See above!
Desktop OS
MacOS
Browser
No response
Version
v0.20.1
Additional Context
N/A

https://github.com/KittyCAD/modeling-app/assets/29681384/5d4e5c58-bcc5-462a-a3fd-ce8b5a33a8a3

The typical convention is to go counterclockwise.

The video above matches the expected workflow as well as matching Kurt's video back in May.
https://github.com/user-attachments/assets/152cbe7c-0331-459e-9d6b-7033410ac4a7

Also it would be nice if sketch updated changes to dimensions like this when you make them. I am having to leave the sketch and come back to it in order for it to refresh and adjust the lines.

I was able to edit the variable of the angle constraint from the code editor and it updated the line properly. I did not have to go in and out of sketch mode to see any updates.
Additionally I was able to click and drag the line to update the constraint as well within sketch mode.
I'll be closing this issue since this is working as expected and there is no bug reported. Please reopen this issue if there is any other findings.


Bump powershell yaml versions to 0.4.7

Found some pipeline failures installing 0.4.1, not sure if it was transient but figured we might as well update anyways.
I might be breaking myself into a world of hurt here 😅

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

@benbp should we try to also move this package to our DevOps feed as part of this update?
cc @scbedd

@weshaggard good point, I'll change this PR to incorporate that given the recent discussion.


Correct byte order of bcdUSB and bcdDevice

This will break bcdUSB (usb_spec_version) and bcdDevice (device_revision) usage in existing scripts that specify them, but I think it is correct to do so as it fixes a bug. The spec is clear about the byte order of these fields and explicitly says "version 2.0 is represented with a value of 0x0200".

Converted to draft for doc updates.

It turned out that all the things I was concerned about in the docs were auto-generated from things already fixed.


The user is not authorized for this task or item. [ems_infra/new]

Hello,
I am trying to add a new infra provider and I am getting this error message. Screenshot below:
The user is not authorized for this task or item. [ems_infra/new]

Bz link - https://bugzilla.redhat.com/show_bug.cgi?id=1238530

@Fryguy @blomquisg @chessbyte we're experiencing this as well (not for containers but for underlying infrastructures: openstack/rhev, etc.).

@matthewd @tenderlove i looked into this issue, and found out that recent changes to move providers models around has caused this issue. We have a model method(https://github.com/ManageIQ/manageiq/blob/master/vmdb/app/controllers/ems_common.rb#L981) in ems_common that's being used to determine feature id for assert_privileges call. Feature id for providers are all prefixed based upon the type/model for example to add a new cloud provider, feature id is ems_cloud_new, previously model method used to return EmsCloud as model but with recent changes it is returning ManageIQ::Providers::CloudManager due to which all of Provider related RBAC checks(https://github.com/ManageIQ/manageiq/blob/master/vmdb/app/controllers/ems_common.rb#L231) are blowing up.
Do we need to change all the xxx provider feature id's in miq_product_features.yml and button toolbars to match the new model name or can this be fixed differently, some examples of the feature id's and toolbar yaml:
https://github.com/ManageIQ/manageiq/blob/master/vmdb/db/fixtures/miq_product_features.yml#L887
thru
https://github.com/ManageIQ/manageiq/blob/master/vmdb/db/fixtures/miq_product_features.yml#L946
https://github.com/ManageIQ/manageiq/blob/master/vmdb/db/fixtures/miq_product_features.yml#L1081
thru
https://github.com/ManageIQ/manageiq/blob/master/vmdb/db/fixtures/miq_product_features.yml#L1144
https://github.com/ManageIQ/manageiq/blob/master/vmdb/db/fixtures/miq_product_features.yml#L3479
thru
https://github.com/ManageIQ/manageiq/blob/master/vmdb/db/fixtures/miq_product_features.yml#L3526
https://github.com/ManageIQ/manageiq/blob/master/vmdb/product/toolbars/ems_cloud_center_tb.yaml
https://github.com/ManageIQ/manageiq/blob/master/vmdb/product/toolbars/ems_clouds_center_tb.yaml
https://github.com/ManageIQ/manageiq/blob/master/vmdb/product/toolbars/ems_infra_center_tb.yaml
https://github.com/ManageIQ/manageiq/blob/master/vmdb/product/toolbars/ems_infras_center_tb.yaml
https://github.com/ManageIQ/manageiq/blob/master/vmdb/product/toolbars/ems_container_center_tb.yaml
https://github.com/ManageIQ/manageiq/blob/master/vmdb/product/toolbars/ems_containers_center_tb.yaml

@h-kataria can we try decoupling the model name from the permissions?  For example:
diff --git a/vmdb/app/controllers/ems_common.rb b/vmdb/app/controllers/ems_common.rb
index c8bf57e..c26475a 100644
--- a/vmdb/app/controllers/ems_common.rb
+++ b/vmdb/app/controllers/ems_common.rb
@@ -228,7 +228,7 @@ module EmsCommon
   end

   def new
-    assert_privileges("#{model.to_s.underscore}_new")
+    assert_privileges("#{permission_name}_new")
     @ems = model.new
     set_form_vars
     @in_a_form = true
@@ -237,7 +237,7 @@ module EmsCommon
   end

   def create
-    assert_privileges("#{model.to_s.underscore}_new")
+    assert_privileges("#{permission_name}_new")
     return unless load_edit("ems_edit__new")
     get_form_vars
     case params[:button]
@@ -280,7 +280,7 @@ module EmsCommon
   end

   def edit
-    assert_privileges("#{model.to_s.underscore}_edit")
+    assert_privileges("#{permission_name}_edit")
     @ems = find_by_id_filtered(model, params[:id])
     set_form_vars
     @in_a_form = true
@@ -326,7 +326,7 @@ module EmsCommon
   end

   def update
-    assert_privileges("#{model.to_s.underscore}_edit")
+    assert_privileges("#{permission_name}_edit")
     return unless load_edit("ems_edit__#{params[:id]}")
     get_form_vars
     case params[:button]
@@ -978,6 +978,10 @@ module EmsCommon
     session["#{prefix}_catinfo".to_sym]    = @catinfo
   end

+  def permission_prefix
+    self.class.model.permission_prefix
+  end
+
   def model
     self.class.model
   end

Note that this patch is incomplete.  We would need to add a permission_prefix method to each model, but it means that we would avoid changing all the yaml files (and we would be free to do more renaming in the future).

@tenderlove this looks good, just to make sure that i understand it correctly permission_name method will be added to each model for example cloud_manager will have permission_name method return "ems_cloud" so we dont have to change any of our yaml files and existing features.

Should permission_name be derived from the model class name, or from the controller name?

@matthewd ya, I think you're right.  We should probably derive this from the controller, not the model.
@h-kataria rather than adding the method to the model, why don't we just add a permission_name method to EMS controllers and have it return the right string?

@tenderlove @matthewd @h-kataria Would permission_name_prefix or permission_area make more sense, since we're then gluing on an "action" to this?  Also, if we're adding a method to the controllers, the super method could just return controller_name, as that should be correct in most cases.

Probably prefix would be better for now.  The main thing we need to do is disconnect it from the models.

We should add a permission_prefix method to ems_common that returns controller_name appropriately for ems_infra, ems_cloud & ems_container controllers, then change all assert_privilige callers in ems_infra, ems_cloud & ems_Container controllers to assert_privileges("#{permission_prefix}_edit") that should send up the correct feature id. permission_prefix method can be added to inidividual controller to return the appropriate string incase we want to overload the method in mixin. Spec test can be added to make sure new/edit screens are rendered successfully.

@h-kataria @dclarizio @martinpovolny Who is making the PR to fix this issue?

current work around is to disable privilege checking:
application_controller.rb:2687
  def assert_privileges(feature)
  end

@chessbyte See the associated BZ link, @lgalis is on it.

PR #3409

Fixed in #3409


VSCode Stack depth is too high

I introduced the @nabla/vite-plugin-eslint plugin

You can see that TS reports an error：Stack depth is too high

How can this problem be solved?

I switched to the vite-plugin-eslint plugin, and this still happened

I'm not sure that the problem is related to the plugin.
This TS problem often appears when you have two versions of the project installed.
If you have yarn v1, you can use https://github.com/scinos/yarn-deduplicate, for other package manager it's probably built-in.
If you want more help, please provide a small reproduction via something like Stackblitz: https://antfu.me/posts/why-reproductions-are-required
Hope it help and happy to investigate any issue with the plugin once it's more easy for me to look into it


LIB-307-resolve-postgres-sql-db-book-sequencing-issue

Hibernate generates used id issue during the POST request from Web Portal to create new book in the Backend

Hibernate generates used id issue during the POST request from Web Portal to create new book

The other issue blocking the POST request from completing its transaction was located at the Frontend project.
The image was converted to base64 but there is a need to remove the data-url which is the string data:/;base64 in the result of the conversion.
To retrieve only the Base64 encoded string, I have used Regex in Typescript and removed the data-url.

The other issue was located in the Frontend.
I was able to remove the data-url (data:/;base64) after using FileReader: readAsDataURL() method to convert the image extracting the base64 encoded string.
By removing the data-url, I am able to resolve the POST request issue in the frontend to complete the entire transaction to create new book.


L2: Add approve in L2Migrator

What does this pull request do? Explain your changes. (required)

Cherry picked<PHONE_NUMBER>aa09c00a12797948834421c18a6caa from https://github.com/livepeer/arbitrum-lpt-bridge/pull/49 which includes a fix that was already included in the testnet L2Migrator deployment for adding a missing approve() call before bondForWithHint(). Also, fetches the token address using the Controller.
Specific updates (required)

How did you test each of these updates (required)

Updated tests.
Does this pull request close any open issues?

N/A
Checklist:

[x] README and other documentation updated
[x] All tests using yarn test pass

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

6 of 6 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
280

Relevant Lines:
280

💛  - Coveralls


Clearing the variables in a console also clears Pylab and SymPy name spaces and variables

Issue:
Currently on 3.x if you have automatically load NumPy and Matplotlib(aka Pylab) or SymPy enabled in the IPython configuration variables and namespaces associated with those packages will be removed when you clear all the variables. This would come as a surprise to most uses because they would consider that a property of the console not a user defined variable.
What happens in similar software:
As a reference starting ipython with the --pylab option and then running %reset removes all of pylab.  Even in isympy running %reset removes SymPy. Octave, Matlab, R and Julia don't do this because those options are in the base language.
Options:
All of the options below would need a way to find out the options of the current console stored in its environment variables.

The simplest would be to remap clearing the variables to a kernel restart on console with these options enabled.

I find that the console restarts in less than a second on my computer but it seem this is not the case on every platform.

Reload the features after the variables are removed.

Should be faster than a full restart, but I fear there will be code duplication here

Remove only user defined variables and not the pre-imported packages

I think that this would be quite difficult and fragile

The simplest would be to remap clearing the variables to a kernel restart on console with these options enabled.

The issue with this is that it is functionally quite different from just clearing user-defined variables as the user requested; it also wipes any loaded packages/modules, terminates any attaches processes, doesn't reflect any IPython magics (e.g. automatic pdb calling with pdb, options to the matplotlib backend, etc), clears all scrollback including displayed input, output, and plots, resets the runtime and prompt counters, and otherwise discards all state). This is totally different from what the user expects and what it is "supposed" to do, and is more destructive than anticipated to boot. In fact, I'd consider this a bigger problem than the one it
Why not just silently run the pylab command after clearing variables as normal, assuming you've implemented

a way to find out the options of the current console stored in its environment variables.

as you say all three require? That seems to be simpler, faster and cleaner than any of them

For sympy, the commands it needs to execute are pretty simple, but perhaps there is a straightforward way to call them from an existing function without a full restart.
So, basically I'm suggesting a variant of 2. I share your concerns about 3., and have even graver reservations about 1. as stated above.

The first option wouldn't work anyway because the clear variable option was made because the restarts were too slow.

So, basically I'm suggesting a variant of 2.

I think this is way to go as well.  The current functions that run pylab and sympy just run those simple commands which are unlikely to change, but there is some code that deals with matplotlib backend selection that is a bit more complicated. I looks like the setting for the inline figures are still there after clearing all variables.  So that might be just fine.


Add ERC: ABI specification for REVERT reason string

This PR includes the missing ERC838
It was firstly described here: https://github.com/ethereum/EIPs/issues/838
I am not one of the original authors
the first inclusion attempt hapnned here: https://github.com/ethereum/EIPs/pull/7186
and later it was recommended to be made here,
Solidity already implements this

This PR includes the missing ERC838

@RenanSouza2 discussed in eip-editors channel of EthCatHerders Discord: https://discord.com/channels/916516304972824576/916713912970412103/1250615350127628438
If the ERC remains substantially unchanged then it can use the originally issued number.  To add you as an author would require approval by the current author: @federicobond
Otherwise you can create a new ERC and a new ERC number can be issued with you as an additional author.

I haven't been involved with Ethereum since 2018 so unless there are objections from other more involved people I am happy to approve @RenanSouza2 as an additional author.


Robusta fetching data but not giving recommendations

I have configured my own prometheus to robusta and its fetching data but in efficiency tab its showing no data for every deployment's recommendation.

Hey @manishbitscrunch we're talking on the community and waiting for more information to reproduce this. Please reply on Slack or here so that we can help you!


Restart worker pool after running into error state

Closes #1315
Contributor Checklist:

[x] I have added or updated my entry in the creators.json file
[x] I have added a changelog entry for my contribution
[ ] I have added/updated documentation for all user-facing changes
[ ] I have added/updated test cases
[N/A] I have included the rebuilt production build of the client (only if changes were made to the GUI)

Reviewer Checklist:

[x] /azp run libertem.libertem-data passed
[x] No import of GPL code from MIT code

/azp run libertem.libertem-data

Tested with LiberTEM-live - restart works well (on Linux).

/azp run libertem.libertem-data

Fix confirmed, thx!


Using ownKeys trap for custom objects not working

Hey,
I have some kind of a custom object that uses proxy to virtualize properties and pass the properties access to an inner handler, so writing a.b.c.d will access each of the levels one by one with the getter function and push the next inner object (or final leaf value) to the stack along with its own proxy and other things. However, when I trap ownKeys for enumeration, to use in for-in clauses, my returned properties array seems to be ignored, and no cycle of the for loop ever runs.
I read this may have to do with the absence of getOwnPropertyDescriptor trap. Is it actually that as long as this trap is not handled by duktape, whatever returned in ownKeys is meaningless and for-in will never be executed for customized properties of user-implemented objects? Is there a different way to implement that while still using proxies? I cannot define each separate property of the objects explicitly, because they are dynamic - the usage of general getters and setters is essential for this specific purpose.
Both calling duk_def_prop for each property in each access to the custom object did not resolve the problem, even calling duk_get_prop_desc for each property of the object immediately afterwards does not even return what I just added. Also adding has trap to the proxy object and having it always return TRUE had no effect whatsoever.
I guess what I'm doing is pretty unusual and may seem a bit weird but it enables necessary semantics of access to internal data structures through javascript. Is there a solution currently supported? Am I doing something wrong and using the correct solution improperly? Or should I give up the usage of for-in clauses for this purpose with the current version of duktape.
Thanks.

As you noted, the values returned by ownKeys must also exist in the target object (https://www.ecma-international.org/ecma-262/10.0/index.html#sec-proxy-object-internal-methods-and-internal-slots-ownpropertykeys):
duk> O = {foo:1, bar:2, quux: 3}
= {foo:1,bar:2,quux:3}
duk> P = new Proxy(O, { ownKeys: function () { return ['foo', 'bar', 'quux', 'nosuch'] } })
= {foo:1,bar:2,quux:3}
duk> for (var i in P) { print(i); }
foo
bar
quux
= undefined

In the above, 'nosuch' does not exist in the target so it is not enumerated.
To virtualize enumeration one would need to define a "getOwnPropertyDescriptor" trap, but unfortunately Duktape doesn't support it at present.

Or should I give up the usage of for-in clauses for this purpose with the current version of duktape.

Unfortunately so :/

Thank you for the quick and to the point reply. How difficult would it be to implement this trap, or even locally make a small custom code change to bypass the ECMA specification? This may be one pretty significant thing that enables duktape to serve as a fast scripting tool that utilizes internal interfaces of generic platforms, although I understand the way I'm using it is probably unusual.

Adding specific support for the trap for enumeration would not be too difficult, but it also affects other places. Some of the existing Proxy limitations will need some reworking rather than incremental addition of functionality, so I'll probably address this and the remaining limitations in a larger rework.
As for the use case, virtualizing enumeration is IMO not a very unusual use case, so I can definitely understand why it would be useful.


Add install support for FreeBSD

The current snapshot of client does not compile on FreeBSD, courtesy: missing functions for FreeBSD in install package. This commit copies install_linux.go  to install_freebsd.go, replacing linux with freebsd, and seems to works fine.
It is tested on FreeBSD 10.3 (amd64).
Thanks!

@wahjava Thanks for the PR!  Do you think it would work to rename install_linux.go to install_unix.go and put +build linux,freebsd in there?  It seems like it would be better not to duplicate the file if there are no changes and we can avoid it.
CC @gabriel

Sure, that'll be better longer term. I can adapt my submission to this later today.
Thanks for the feedback.

@cjb Updated the PR, and used +build linux freebsd constraints, unlike what you mentioned.
Let me know if you see any other issue.
Thanks!

👍
Testing in CI and will merge if passes

This merges ok: https://github.com/keybase/client/pull/3552

@wahjava Thanks for the contribution! :confetti_ball:


construct_runtime! macro should not require Log type to be Deserialize

cc @bkchr

This was addressed; all runtime macros no longer require deserialize.


[Feature] [Connector-V2 E2E] Add mysql and postgres e2e test

Purpose of this pull request

Check list
Add mysql and postgres e2e test

[x] Code changed are covered with tests, or it does not need tests for reason:
[x] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs

@CalvinKirs @EricJoy2048 @Hisoka-X @hailin0 @ashulin @TyrantLucifer @laglangyue @531651225
PTAL


ARTEMIS-3219 Improve FQQN message routing

https://issues.apache.org/jira/browse/ARTEMIS-3219

This is both improving performance of FQQN routing by reducing the amount of map lookups to compute the next binding search and it's improving normal routing by removing from the hot path less common or slow path methods eg duplicate cache lookups.
I need to run an end 2 end test with FQQN before merging this + running the full CI, because it contains a big number of changes.


Should add an option for allowed extension to be case insensitive

As the title said, I want to select a *.jpg file without adding both ['.jpg', '.JPG']

Is this what this PR does?
https://github.com/andyduke/filesystem_picker/pull/22