KYLIN-4355 add ut

Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have create an issue on Kylin's jira, and have described the bug/feature there in detail
[x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
[x] Compiling and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If this change need a document change, I will prepare another pr against the document branch
[ ] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

Pull Request Test Coverage Report for Build 6013

5 of 11 (45.45%)  changed or added relevant lines in 4 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.03%) to 28.278%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
0
1
0.0%

stream-receiver/src/main/java/org/apache/kylin/stream/server/StreamingServer.java
0
1
0.0%

server-base/src/main/java/org/apache/kylin/rest/controller/AdminController.java
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java
1
78.12%

server-base/src/main/java/org/apache/kylin/rest/controller/AdminController.java
1
0%

Totals

Change from base Build 6008:
0.03%

Covered Lines:
25790

Relevant Lines:
91202

💛  - Coveralls

Check list

[ ] Step 1. [OPTIONAL]Understand background/root cause/design basically(one hour EST) . Its issue type is

[ ] bug fix
[ ] new feature
[x] enhancement

[x] Step 2. Test cases are designed and documented (30 minutes EST).
[x] Step 3. Prepare specific env, for example:

mock data (maybe some specific data type)
test env (maybe install a RDBMS instance).

[x] Step 4. Verify and make sure test cases passed.
[x] Step 5. Paste manual important steps and screenshots here (20 minutes EST).

If you find difficulty in pick most important evidence, please attach diagnosis package.

[ ] Step 6. Do more check in user perspective (20 minutes EST)

[ ] Doc need be updated? And if it is updated? Ask help for release manager if so.
[ ] If it is a breaking change so we should notify Kylin community? Ask help for release manager if so.

[x] Step 7.  Summarize this test (20 minutes EST).

Total estimate

4 hours for small issue from optimistic estimate.

Note
If you find some unexpected and unrelated error/mistake, please DO report it if it is truly a mistake, I think we may research and fix it in the future.
If you find background information/root cause analysis is not complete or ambiguous, please try to contact to author or do a quick research and record what you find. It is a good chance to learn something interesting.
If you find it is not easy to design testcase, please notify release manager.

Design test case
Prepare test env

Start one Kylin instance and two receivers.

Design test case

Create a streaming cube.
Enable streaming cube and reassign cube replica set.

Verify test case

Ressign cube replica set(Invalid. Partition 5 is assigned to two replica set at the same time)

Ressign cube replica set(Valid)

Summary

Invalid reassign can be detected and pop up error.


Task managment implemented

task managment implemented. Tasks persisted, listen on new tasks , task changes or task deletion

LGTM


Update CADability Debugger Visualizer to support Visual Studio 2022

The old Debugger Visualizers didn't work anymore.
I followed this instruction to rework the current visualizers.
https://learn.microsoft.com/en-us/visualstudio/debugger/walkthrough-writing-a-visualizer-in-csharp?view=vs-2019
One of the drawbacks of this way is that it does not support Interfaces.
You have to specify every type that implements the interface e.g.
//ICurve Implementations
[assembly: System.Diagnostics.DebuggerVisualizer(typeof(CADability.DebuggerVisualizers.CurveVisualizer), typeof(VisualizerObjectSource),
Target = typeof(CADability.GeoObject.BSpline), Description = "CADability ICurve Visualizer")]

You also have to use a .NET Framework Class Library.
.NET Standard 2.0 (CADability) does not work, because of the host (Visual Studio).
That's why I had to create a new project.

I still don't get the "magnifying glass" icon in the quick watch or watch:

Do I have to install the CADabilityDebuggerVisualizers.dll somewhere?

You have to copy the output of:
...\Repos\SOFAgh\CADability\CADability.DebuggerVisualizers\bin\Release
To:
C:\Users\UserName\Documents\Visual Studio 2022\Visualizers
Von: Gerhard Hofmann @.>
Gesendet: Montag, 7. November 2022 09:35
An: SOFAgh/CADability @.>
Cc: Michel Metzler @.>; Assign @.>
Betreff: Re: [SOFAgh/CADability] Update CADability Debugger Visualizer to support Visual Studio 2022 (PR #117)
I still don't get the "magnifying glass" icon in the quick watch or watch:
[QuickWatch]https://user-images.githubusercontent.com/37174533/200262825-3617c14d-6636-49c1-901e-d08cc97dba77.png
Do I have to install the CADabilityDebuggerVisualizers.dll somewhere?
—
Reply to this email directly, view it on GitHubhttps://github.com/SOFAgh/CADability/pull/117#issuecomment-1305259021, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AK4L7JHLPM2QCZP7ONISFHLWHC5KFANCNFSM6AAAAAARX4JJAQ.
You are receiving this because you were assigned.Message ID<EMAIL_ADDRESS>

Thanks a lot ! I spent days to figure out how to make it work without success!


added filter suffix to alerts

added the .toparquet filter suffix to the alerts.

Not sure but it looks like the contents of lambda.tf has gone into alerts.tf.

The latest commit should fix this.


DuckDBConnection.CreateAppender not dealing correctly when table with special characters

Hello,
First of all, thank you for this library. Very simple to use and straightforward!

The Issue
The following code will fail when trying to create an appender:
using var conn = new DuckDB.NET.Data.DuckDBConnection("Data Source=:memory:");
conn.Open();
var specialTableName = "SPÉçÏÃL - TÁBLÈ_";
using (var cmdCreateTable = conn.CreateCommand())
{
    cmdCreateTable.CommandText = @$"CREATE TABLE ""{specialTableName}"" (SomeField TEXT)";
    cmdCreateTable.ExecuteNonQuery();
}

try
{
    using (var appender = conn.CreateAppender(specialTableName))
    {

    };
    Console.WriteLine("Passed!");
}
catch (Exception e)
{
    Console.Error.WriteLine($"Failed to retrieve schema: {e.Message}");
}

Stack Trace:
Failed to retrieve schema: DuckDB.NET.Data.DuckDBException (0x80004005): Catalog Error: Table "main.SP????L - T?BL?_" could not be found
   at DuckDB.NET.Data.DuckDBAppender.ThrowLastError(DuckDBAppender appender)
   at DuckDB.NET.Data.DuckDBConnection.CreateAppender(String schema, String table)
   at DuckDB.NET.Data.DuckDBConnection.CreateAppender(String table)

It seems that the CreateAppender is not correctly converting the string to the correct encoding before calling the native API.
If you have any guidance on this, I can provide a PR.

In the CreateAppender method the schema and table need to be converted to utf8 with Utils.ToUnmanagedString

Apparently easier than I thought. Just followed the pattern used in 3aea4640d9ea761ea6aab457a840bc583e440ddf. Made the PR #163 - hope is fine.


Investigate BMM error in older tt_lib stable diffusion perf test / get rid of the test

@tt-asaigal said that this might be incorrect op dispatch.
https://github.com/tenstorrent/tt-metal/actions/runs/8742619140/job/23991319245
2024-04-18T18:43:39.2806225Z models/experimental/stable_diffusion/tests/test_perf_unbatched_stable_diffusion.py::test_perf_bare_metal[42-95]                  Device | INFO     | Opening user mode device driver
2024-04-18T18:43:39.3448753Z 2024-04-18 18:43:39.344 | INFO     | SiliconDriver   - Detected 4 PCI devices : {0, 1, 2, 3}
2024-04-18T18:43:39.5350213Z 2024-04-18 18:43:39.534 | INFO     | SiliconDriver   - Detected 4 PCI devices : {0, 1, 2, 3}
2024-04-18T18:43:39.6698957Z 2024-04-18 18:43:39.669 | INFO     | SiliconDriver   - Detected 4 PCI devices : {0, 1, 2, 3}
2024-04-18T18:43:39.8014822Z 2024-04-18 18:43:39.801 | INFO     | SiliconDriver   - Detected 4 PCI devices : {0, 1, 2, 3}
2024-04-18T18:43:39.8794848Z                   Metal | INFO     | Initializing device 0. Program cache is NOT enabled
2024-04-18T18:43:39.9390269Z                   Metal | INFO     | AI CLK for device 0 is:   1202 MHz
2024-04-18T18:43:40.7347396Z                   Metal | INFO     | Enabling program cache on device 0
2024-04-18T18:43:40.9096752Z The config attributes {'scaling_factor': 0.18215} were passed to AutoencoderKL, but are not expected and will be ignored. Please verify your config.json configuration file.
2024-04-18T18:43:42.1114764Z 2024-04-18 18:43:42.110 | WARNING  | tt_lib.fallback_ops.conversion_wrapper:check_log_pytorch_warning:15 - Pytorch tensor was passed as input to fallback op instead of TT tensor. This is currently supported to improve perf but support for this will be deprecated.
2024-04-18T18:44:25.2857974Z
2024-04-18T18:44:26.9819437Z   0%|          | 0/2 [00:00<?, ?it/s]
2024-04-18T18:44:26.9820357Z   0%|          | 0/2 [00:01<?, ?it/s]
2024-04-18T18:44:26.9820763Z
2024-04-18T18:44:29.9119430Z   0%|          | 0/2 [00:00<?, ?it/s]2024-04-18 18:44:29.911 | INFO     | models.utility_functions:run_conv_on_device_batch_one:896 - Running Conv with following parameters on device -
2024-04-18T18:44:29.9122511Z 2024-04-18 18:44:29.911 | INFO     | models.utility_functions:run_conv_on_device_batch_one:897 - K=320 C=4 H=32 W=32 R=3 S=3 U=1 V=1 PH=1 PW=1 dilation=1 groups=1
2024-04-18T18:44:29.9125119Z 2024-04-18 18:44:29.911 | INFO     | models.utility_functions:run_conv_on_device_batch_one:924 - Going to run conv on tt device
2024-04-18T18:44:31.6891546Z 2024-04-18 18:44:31.688 | INFO     | models.utility_functions:run_conv_on_device_batch_one:936 - conv on tt device done
2024-04-18T18:44:32.9129595Z 2024-04-18 18:44:32.912 | INFO     | models.utility_functions:run_conv_on_device_batch_one:896 - Running Conv with following parameters on device -
2024-04-18T18:44:32.9132423Z 2024-04-18 18:44:32.912 | INFO     | models.utility_functions:run_conv_on_device_batch_one:897 - K=320 C=320 H=32 W=32 R=3 S=3 U=1 V=1 PH=1 PW=1 dilation=1 groups=1
2024-04-18T18:44:32.9134802Z 2024-04-18 18:44:32.912 | INFO     | models.utility_functions:run_conv_on_device_batch_one:924 - Going to run conv on tt device
2024-04-18T18:44:33.2813986Z 2024-04-18 18:44:33.280 | INFO     | models.utility_functions:run_conv_on_device_batch_one:936 - conv on tt device done
2024-04-18T18:44:33.8398550Z 2024-04-18 18:44:33.839 | INFO     | models.utility_functions:run_conv_on_device_batch_one:896 - Running Conv with following parameters on device -
2024-04-18T18:44:33.8401036Z 2024-04-18 18:44:33.839 | INFO     | models.utility_functions:run_conv_on_device_batch_one:897 - K=320 C=320 H=32 W=32 R=1 S=1 U=1 V=1 PH=0 PW=0 dilation=1 groups=1
2024-04-18T18:44:33.8403232Z 2024-04-18 18:44:33.839 | INFO     | models.utility_functions:run_conv_on_device_batch_one:924 - Going to run conv on tt device
2024-04-18T18:44:34.2052175Z 2024-04-18 18:44:34.204 | INFO     | models.utility_functions:run_conv_on_device_batch_one:936 - conv on tt device done
2024-04-18T18:44:40.9096912Z                  Always | FATAL    | launch_with_autoformat must be used if output tensor for op can be placed on host.
2024-04-18T18:44:40.9112748Z
2024-04-18T18:44:41.0671658Z FAILED                  Metal | INFO     | Closing device 0
2024-04-18T18:44:41.0961924Z                   Metal | INFO     | Disabling and clearing program cache on device 0
2024-04-18T18:44:41.1004662Z
2024-04-18T18:44:41.1005129Z
2024-04-18T18:44:41.1010502Z =================================== FAILURES ===================================
2024-04-18T18:44:41.1011017Z   0%|          | 0/2 [00:13<?, ?it/s]
2024-04-18T18:44:41.1011617Z _________________________ test_perf_bare_metal[42-95] __________________________
2024-04-18T18:44:41.1011981Z
2024-04-18T18:44:41.1012516Z device = <tt_lib.device.Device object at 0x7f3932712570>
2024-04-18T18:44:41.1013029Z use_program_cache = None, expected_inference_time = 42
2024-04-18T18:44:41.1013517Z expected_compile_time = 95
2024-04-18T18:44:41.1014975Z
2024-04-18T18:44:41.1015360Z     @pytest.mark.models_performance_bare_metal
2024-04-18T18:44:41.1015837Z     @pytest.mark.parametrize(
2024-04-18T18:44:41.1016251Z         "expected_inference_time, expected_compile_time",
2024-04-18T18:44:41.1016658Z         (
2024-04-18T18:44:41.1016878Z             (
2024-04-18T18:44:41.1017101Z                 42,
2024-04-18T18:44:41.1017344Z                 95,
2024-04-18T18:44:41.1017580Z             ),
2024-04-18T18:44:41.1017963Z         ),
2024-04-18T18:44:41.1018292Z     )
2024-04-18T18:44:41.1018889Z     def test_perf_bare_metal(device, use_program_cache, expected_inference_time, expected_compile_time):
2024-04-18T18:44:41.1020010Z >       run_perf_unbatched_stable_diffusion(expected_inference_time, expected_compile_time, device)
2024-04-18T18:44:41.1023741Z
2024-04-18T18:44:41.1024405Z models/experimental/stable_diffusion/tests/test_perf_unbatched_stable_diffusion.py:293:
2024-04-18T18:44:41.1025465Z _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
2024-04-18T18:44:41.1026653Z models/experimental/stable_diffusion/tests/test_perf_unbatched_stable_diffusion.py:237: in run_perf_unbatched_stable_diffusion
2024-04-18T18:44:41.1027679Z     tt_noise_pred_cond = tt_unet(tt_conditioned, _t_cond, encoder_hidden_states=tt_text_embeddings)
2024-04-18T18:44:41.1029319Z build/python_env/lib/python3.8/site-packages/torch/nn/modules/module.py:1511: in _wrapped_call_impl
2024-04-18T18:44:41.1030440Z     return self._call_impl(*args, **kwargs)
2024-04-18T18:44:41.1031539Z build/python_env/lib/python3.8/site-packages/torch/nn/modules/module.py:1520: in _call_impl
2024-04-18T18:44:41.1032520Z     return forward_call(*args, **kwargs)
2024-04-18T18:44:41.1033345Z models/experimental/stable_diffusion/tt/unet_2d_condition.py:510: in forward
2024-04-18T18:44:41.1034258Z     sample, res_samples = downsample_block(
2024-04-18T18:44:41.1035387Z build/python_env/lib/python3.8/site-packages/torch/nn/modules/module.py:1511: in _wrapped_call_impl
2024-04-18T18:44:41.1036391Z     return self._call_impl(*args, **kwargs)
2024-04-18T18:44:41.1037538Z build/python_env/lib/python3.8/site-packages/torch/nn/modules/module.py:1520: in _call_impl
2024-04-18T18:44:41.1038189Z     return forward_call(*args, **kwargs)
2024-04-18T18:44:41.1038901Z models/experimental/stable_diffusion/tt/unet_2d_blocks.py:451: in forward
2024-04-18T18:44:41.1039441Z     hidden_states = attn(
2024-04-18T18:44:41.1040145Z build/python_env/lib/python3.8/site-packages/torch/nn/modules/module.py:1511: in _wrapped_call_impl
2024-04-18T18:44:41.1040847Z     return self._call_impl(*args, **kwargs)
2024-04-18T18:44:41.1041567Z build/python_env/lib/python3.8/site-packages/torch/nn/modules/module.py:1520: in _call_impl
2024-04-18T18:44:41.1042213Z     return forward_call(*args, **kwargs)
2024-04-18T18:44:41.1042755Z models/experimental/stable_diffusion/tt/transformer_2d.py:496: in forward
2024-04-18T18:44:41.1043289Z     hidden_states = block(
2024-04-18T18:44:41.1043982Z build/python_env/lib/python3.8/site-packages/torch/nn/modules/module.py:1511: in _wrapped_call_impl
2024-04-18T18:44:41.1044670Z     return self._call_impl(*args, **kwargs)
2024-04-18T18:44:41.1045391Z build/python_env/lib/python3.8/site-packages/torch/nn/modules/module.py:1520: in _call_impl
2024-04-18T18:44:41.1046033Z     return forward_call(*args, **kwargs)
2024-04-18T18:44:41.1046576Z models/experimental/stable_diffusion/tt/transformer_2d.py:259: in forward
2024-04-18T18:44:41.1047432Z     attn_output = self.attn2(
2024-04-18T18:44:41.1048152Z build/python_env/lib/python3.8/site-packages/torch/nn/modules/module.py:1511: in _wrapped_call_impl
2024-04-18T18:44:41.1048828Z     return self._call_impl(*args, **kwargs)
2024-04-18T18:44:41.1049649Z build/python_env/lib/python3.8/site-packages/torch/nn/modules/module.py:1520: in _call_impl
2024-04-18T18:44:41.1050299Z     return forward_call(*args, **kwargs)
2024-04-18T18:44:41.1050847Z models/experimental/stable_diffusion/tt/cross_attention.py:147: in forward
2024-04-18T18:44:41.1051563Z     return CrossAttnProcessor(
2024-04-18T18:44:41.1052127Z models/experimental/stable_diffusion/tt/cross_attention.py:228: in CrossAttnProcessor
2024-04-18T18:44:41.1052872Z     attention_probs = attn.get_attention_scores(query, key, attention_mask)
2024-04-18T18:44:41.1053504Z _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
2024-04-18T18:44:41.1053866Z
2024-04-18T18:44:41.1053986Z self = TtCrossAttention()
2024-04-18T18:44:41.1054515Z query = ttnn.Tensor([[[[-0.26953,  0.03271,  ...,  0.37500,  0.13086],
2024-04-18T18:44:41.1055728Z                [-0.36133,  0.24023,  ...,  0.35156,  0....67578,  ..., -0.07471,  0.21289]]]], shape=Shape([1, 8, 1024, 40]), dtype=DataType::BFLOAT16, layout=Layout::ROW_MAJOR)
2024-04-18T18:44:41.1056675Z key = ttnn.Tensor([[[[-1.02344,  0.21973,  ..., -2.28125,  0.26562],
2024-04-18T18:44:41.1057734Z                [-4.90625,  0.34961,  ...,  4.34375, -2....1.91406,  ...,  3.00000, -3.31250]]]], shape=Shape([1, 8, 77, 40]), dtype=DataType::BFLOAT16, layout=Layout::ROW_MAJOR)
2024-04-18T18:44:41.1058487Z attention_mask = None
2024-04-18T18:44:41.1058690Z
2024-04-18T18:44:41.1058814Z     def get_attention_scores(
2024-04-18T18:44:41.1059336Z         self, query: ttl.tensor.Tensor, key: ttl.tensor.Tensor, attention_mask=None
2024-04-18T18:44:41.1059932Z     ) -> ttl.tensor.Tensor:
2024-04-18T18:44:41.1060361Z         t_key = ttl.tensor.transpose(key, -2, -1)
2024-04-18T18:44:41.1060759Z
2024-04-18T18:44:41.1061053Z >       temp = ttl.tensor.bmm(query, t_key)
2024-04-18T18:44:41.1061938Z E       RuntimeError: TT_ASSERT @ tt_eager/tt_dnn/op_library/run_operation.cpp:713: outputs.at(i).tensor_attributes->dynamic_storage
2024-04-18T18:44:41.1062685Z E       info:
2024-04-18T18:44:41.1063193Z E       launch_with_autoformat must be used if output tensor for op can be placed on host.
2024-04-18T18:44:41.1063772Z E       backtrace:
2024-04-18T18:44:41.1064291Z E        --- tt::tt_metal::Device::push_work(std::function<void ()>&&, bool)
2024-04-18T18:44:41.1067279Z E        --- tt::tt_metal::operation::launch_op(std::function<std::vector<tt::tt_metal::Tensor, std::allocator<tt::tt_metal::Tensor> > (std::vector<tt::tt_metal::Tensor, std::allocator<tt::tt_metal::Tensor> > const&, std::vector<std::optional<tt::tt_metal::Tensor const>, std::allocator<std::optional<tt::tt_metal::Tensor const> > > const&)>&&, std::vector<tt::tt_metal::Tensor, std::allocator<tt::tt_metal::Tensor> >, std::vector<tt::tt_metal::Tensor, std::allocator<tt::tt_metal::Tensor> >&, std::vector<std::optional<tt::tt_metal::Tensor const>, std::allocator<std::optional<tt::tt_metal::Tensor const> > >)
2024-04-18T18:44:41.1070271Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/tt_eager/tt_lib/_C.so(+0x37fdc0) [0x7f3936065dc0]
2024-04-18T18:44:41.1071336Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/tt_eager/tt_lib/_C.so(+0x3777aa) [0x7f393605d7aa]
2024-04-18T18:44:41.1072393Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/tt_eager/tt_lib/_C.so(+0x223bb1) [0x7f3935f09bb1]
2024-04-18T18:44:41.1073537Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(PyCFunction_Call+0x59) [0x5d5499]
2024-04-18T18:44:41.1074784Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyObject_MakeTpCall+0x296) [0x5d6066]
2024-04-18T18:44:41.1076078Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalFrameDefault+0x6329) [0x54ce69]
2024-04-18T18:44:41.1077638Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalCodeWithName+0x26a) [0x54552a]
2024-04-18T18:44:41.1079152Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3() [0x4e1bd0]
2024-04-18T18:44:41.1080345Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalFrameDefault+0x5d69) [0x54c8a9]
2024-04-18T18:44:41.1081658Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalCodeWithName+0x26a) [0x54552a]
2024-04-18T18:44:41.1082963Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyFunction_Vectorcall+0x393) [0x5d5a23]
2024-04-18T18:44:41.1084188Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(PyObject_Call+0x62) [0x5d4c12]
2024-04-18T18:44:41.1085454Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalFrameDefault+0x1f26) [0x548a66]
2024-04-18T18:44:41.1086769Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalCodeWithName+0x26a) [0x54552a]
2024-04-18T18:44:41.1088059Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyFunction_Vectorcall+0x393) [0x5d5a23]
2024-04-18T18:44:41.1089189Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3() [0x4e1b5c]
2024-04-18T18:44:41.1090273Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(PyObject_Call+0x62) [0x5d4c12]
2024-04-18T18:44:41.1091516Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalFrameDefault+0x1f26) [0x548a66]
2024-04-18T18:44:41.1092833Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalCodeWithName+0x26a) [0x54552a]
2024-04-18T18:44:41.1094124Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyFunction_Vectorcall+0x393) [0x5d5a23]
2024-04-18T18:44:41.1095243Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3() [0x4e1b5c]
2024-04-18T18:44:41.1096325Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(PyObject_Call+0x62) [0x5d4c12]
2024-04-18T18:44:41.1097571Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalFrameDefault+0x1f26) [0x548a66]
2024-04-18T18:44:41.1098885Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalCodeWithName+0x26a) [0x54552a]
2024-04-18T18:44:41.1100162Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyFunction_Vectorcall+0x393) [0x5d5a23]
2024-04-18T18:44:41.1101295Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3() [0x57a4af]
2024-04-18T18:44:41.1102393Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(PyObject_Call+0x25e) [0x5d4e0e]
2024-04-18T18:44:41.1103645Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalFrameDefault+0x1f26) [0x548a66]
2024-04-18T18:44:41.1104943Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalCodeWithName+0x26a) [0x54552a]
2024-04-18T18:44:41.1106224Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyFunction_Vectorcall+0x393) [0x5d5a23]
2024-04-18T18:44:41.1107345Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3() [0x4e2079]
2024-04-18T18:44:41.1108448Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(PyObject_Call+0x62) [0x5d4c12]
2024-04-18T18:44:41.1109907Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalFrameDefault+0x1f26) [0x548a66]
2024-04-18T18:44:41.1111276Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalCodeWithName+0x26a) [0x54552a]
2024-04-18T18:44:41.1112571Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyFunction_Vectorcall+0x393) [0x5d5a23]
2024-04-18T18:44:41.1113682Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3() [0x4e2079]
2024-04-18T18:44:41.1114761Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(PyObject_Call+0x62) [0x5d4c12]
2024-04-18T18:44:41.1116001Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalFrameDefault+0x1f26) [0x548a66]
2024-04-18T18:44:41.1117317Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalCodeWithName+0x26a) [0x54552a]
2024-04-18T18:44:41.1119053Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyFunction_Vectorcall+0x393) [0x5d5a23]
2024-04-18T18:44:41.1120184Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3() [0x57a4af]
2024-04-18T18:44:41.1121314Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyObject_MakeTpCall+0x296) [0x5d6066]
2024-04-18T18:44:41.1122607Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalFrameDefault+0x690a) [0x54d44a]
2024-04-18T18:44:41.1123907Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalCodeWithName+0x26a) [0x54552a]
2024-04-18T18:44:41.1125190Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyFunction_Vectorcall+0x393) [0x5d5a23]
2024-04-18T18:44:41.1126320Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3() [0x4e1b5c]
2024-04-18T18:44:41.1127418Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(PyObject_Call+0x62) [0x5d4c12]
2024-04-18T18:44:41.1128454Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalFrameDefault+0x1f26) [0x548a66]
2024-04-18T18:44:41.1129497Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalCodeWithName+0x26a) [0x54552a]
2024-04-18T18:44:41.1130526Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyFunction_Vectorcall+0x393) [0x5d5a23]
2024-04-18T18:44:41.1131424Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3() [0x4e1b5c]
2024-04-18T18:44:41.1132288Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(PyObject_Call+0x62) [0x5d4c12]
2024-04-18T18:44:41.1133287Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalFrameDefault+0x1f26) [0x548a66]
2024-04-18T18:44:41.1134336Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalCodeWithName+0x26a) [0x54552a]
2024-04-18T18:44:41.1135366Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyFunction_Vectorcall+0x393) [0x5d5a23]
2024-04-18T18:44:41.1136267Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3() [0x57a4af]
2024-04-18T18:44:41.1137179Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyObject_MakeTpCall+0x296) [0x5d6066]
2024-04-18T18:44:41.1138210Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalFrameDefault+0x690a) [0x54d44a]
2024-04-18T18:44:41.1139417Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalCodeWithName+0x26a) [0x54552a]
2024-04-18T18:44:41.1140514Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyFunction_Vectorcall+0x393) [0x5d5a23]
2024-04-18T18:44:41.1141417Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3() [0x4e2079]
2024-04-18T18:44:41.1142294Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(PyObject_Call+0x62) [0x5d4c12]
2024-04-18T18:44:41.1143294Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalFrameDefault+0x1f26) [0x548a66]
2024-04-18T18:44:41.1144344Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalCodeWithName+0x26a) [0x54552a]
2024-04-18T18:44:41.1145381Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyFunction_Vectorcall+0x393) [0x5d5a23]
2024-04-18T18:44:41.1146274Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3() [0x4e2079]
2024-04-18T18:44:41.1147144Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(PyObject_Call+0x62) [0x5d4c12]
2024-04-18T18:44:41.1148147Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalFrameDefault+0x1f26) [0x548a66]
2024-04-18T18:44:41.1149203Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalCodeWithName+0x26a) [0x54552a]
2024-04-18T18:44:41.1150224Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyFunction_Vectorcall+0x393) [0x5d5a23]
2024-04-18T18:44:41.1151122Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3() [0x57a4af]
2024-04-18T18:44:41.1152034Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyObject_MakeTpCall+0x296) [0x5d6066]
2024-04-18T18:44:41.1153069Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalFrameDefault+0x690a) [0x54d44a]
2024-04-18T18:44:41.1154119Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalCodeWithName+0x26a) [0x54552a]
2024-04-18T18:44:41.1155147Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyFunction_Vectorcall+0x393) [0x5d5a23]
2024-04-18T18:44:41.1156045Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3() [0x4e1b5c]
2024-04-18T18:44:41.1156929Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(PyObject_Call+0x62) [0x5d4c12]
2024-04-18T18:44:41.1157924Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalFrameDefault+0x1f26) [0x548a66]
2024-04-18T18:44:41.1159320Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalCodeWithName+0x26a) [0x54552a]
2024-04-18T18:44:41.1160360Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyFunction_Vectorcall+0x393) [0x5d5a23]
2024-04-18T18:44:41.1161259Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3() [0x4e1b5c]
2024-04-18T18:44:41.1162125Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(PyObject_Call+0x62) [0x5d4c12]
2024-04-18T18:44:41.1163126Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalFrameDefault+0x1f26) [0x548a66]
2024-04-18T18:44:41.1164181Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalCodeWithName+0x26a) [0x54552a]
2024-04-18T18:44:41.1165345Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyFunction_Vectorcall+0x393) [0x5d5a23]
2024-04-18T18:44:41.1166308Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3() [0x57a4af]
2024-04-18T18:44:41.1167223Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyObject_MakeTpCall+0x296) [0x5d6066]
2024-04-18T18:44:41.1168259Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalFrameDefault+0x690a) [0x54d44a]
2024-04-18T18:44:41.1169290Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyFunction_Vectorcall+0x1b6) [0x5d5846]
2024-04-18T18:44:41.1170324Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalFrameDefault+0x725) [0x547265]
2024-04-18T18:44:41.1171381Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalCodeWithName+0x26a) [0x54552a]
2024-04-18T18:44:41.1172408Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyFunction_Vectorcall+0x393) [0x5d5a23]
2024-04-18T18:44:41.1173386Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(PyObject_Call+0x62) [0x5d4c12]
2024-04-18T18:44:41.1174389Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalFrameDefault+0x1f26) [0x548a66]
2024-04-18T18:44:41.1175441Z E        --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/build/python_env/bin/python3(_PyEval_EvalCodeWithName+0x26a) [0x54552a]
2024-04-18T18:44:41.1175983Z
2024-04-18T18:44:41.1176231Z models/experimental/stable_diffusion/tt/cross_attention.py:176: RuntimeError

I just tried running the test again.
The tensors are not on the device, which is required to run matmul. The test will need to be updated.

@mywoodstock
I made some changes and got past the matmul errors. Now it's bcast related errors.
I feel like getting this test to work will take too long and I should just delete this test.
Are you okay with that?

@bbradelTT Yes that is fine with me

@bbradelTT Yes that is fine with me

I'll delete the test then.
In case the test needs to be revived, my notes are below.
I think there are two problems:

the tensors need to be on device before they can be processed by ops
the tensor sizes are not compatible with the hardware. Specifically, for matmul/linear, one of the created tensors has a size of [1,1,1,320]. I tried padding that tensor in a really roundabout way, but I don't think that's a good solution, and there are other problems further in the execution of the test.

        elif self.downsample is not None:
            assert False, "Downsample in residual block is not implemented!"

        hidden_states = self.conv1(hidden_states)

        if temb is not None:
            temb = self.nonlinearity(temb)

            temb = self.time_emb_proj(temb)
            temb = fallback_ops.reshape(temb, temb.get_legacy_shape()[2], temb.get_legacy_shape()[3], 1, 1)

        if temb is not None and self.time_embedding_norm == "default":
>           hidden_states = ttl.tensor.bcast(
                hidden_states,
                temb,
                ttl.tensor.BcastOpMath.ADD,
                ttl.tensor.BcastOpDim.HW,
            )
E           RuntimeError: TT_FATAL @ ../tt_eager/tt_dnn/op_library/bcast/bcast_op.cpp:106: input_shape_a[i] == input_shape_b[i] && "Broadcast with batch is currently only supported when bN*bC=1 or N & C match or equivalent"

Test deleted.


Support OmegaConf hparams on LightningModule

What does this PR do?
Fixes bug in this stacktrace: https://gist.github.com/ananthsub/07f99b2acacb7ef46bf426f0323cc615
The LightningModule in question does this in the init:
class MyModule(LightningModule):
    def __init__(self, cfg=None, visualize_cfg=None, benchmark_cfg=None, **kwargs):
        super().__init__()
        self._cfg = cfg
        self._visualize_cfg = visualize_cfg
        self._benchmark_cfg = benchmark_cfg
        self.save_hyperparameters()
...

where all the cfgs are OmegaConf containers. It doesn't look like the framepointer logic for save_hyperparameters handles this well. The LightningModule hparams convert OmegaConf hparams to AttributeDict from this conversion: https://github.com/PyTorchLightning/pytorch-lightning/blob/master/pytorch_lightning/core/lightning.py#L1640-L1641
This causes checks in the tensorboard logger to never trigger, because the type(hparams) is type(params) is <class 'pytorch_lightning.utilities.parsing.AttributeDict'>. This results in YAML dumping to file issues, as seen in the stacktrace
Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Abandoning this PR. The workaround was to

Merge the OmegaConfs into a single object
set self.hparams = <merged omegaconf>
Drop the call to save_hyperparameters()

Ideally hparams could be set in the init instead


Move to https instead of ssh

@qcastel may I ask what's your relationship with DIF?
@BernhardFuchs


Please help: with format a string with numbers or allocator instance in microzig.

Hello!
Thank you for your work on that project.
I start to use it in development. I want to write some simple apps to understand if it works.
I want to be able to format a string with numbers.
I need help with the allocator issue. I need help finding a way to use the standard library functions that require an allocator instance.
Example:
  const allocator = os.heap.page_allocator;

   const string1 = try std.fmt.allocPrint(allocator, "{d}", .{count()});
   defer allocator.free(string1);
   microzig.hal.uart.write(0, string1);

Gives me the error:
 error: root struct of file 'start' has no member named 'os'
 root.os.heap.page_allocator

Is there a way to get the allocator in the Microzig? or ESP32C2 environment? Can I resolve those issues without the allocator usage?
Thank you in advance.

Hi sorry for the late reply. For embedded projects you have to setup an allocator yourself. The easiest way you can do that is to use a fixed buffer allocator.
var buffer: [4096]u8 = undefined;
var fba = std.heap.FixedBufferAllocator.init(buffer[0..]);
const allocator = fba.allocator();

For the example above keep in mind that you can't free the memory allocated from a FBA, i.e., you have to place it strategically in your code.
If you have any questions regarding Microzig and embedded programming in Zig, the best place to go is the Zig Embedded Group Discord server (https://discord.gg/XRbsd3Ee). The response time is usually pretty quick.


Add support for accepting Deno more command-line arguments

In our main project, we make have use of import maps, which can be specified via the CLI argument --import-map <FILE>. The extension already supports the --unstable flag. Maybe add similar support for --import-map <FILE>, --lock <FILE>, --lock-write, and other common flags?

It'll be fairly easy to add support for per-project tsconfig.json and import maps. Should happen soon. 👍
I think args like --lock only work with deno run and deno bundle, but I just added Task templates for those which have preferences where you can pass these kinds of options!

Great to hear. Thanks for working so hard on this.

Added this in a quick v0.3 which should be available for download shortly. Let me know if this meets your needs!

I just installed the new version of the extension, and the new preferences for the import map and tsconfig work well. Thanks, again, for taking care of this issue.


support multiple libs? caikit_config.libraries dict

https://github.com/caikit/caikit/blob/6a8e61c9951daa9d3b7c760261bf3be4d4383362/caikit/runtime/servicers/global_train_servicer.py#L68-L69

Unintended issue creation.


Fix broken link to project/MAINTAINERS.md

The link to project/MAINTAINERS.md was broken (it's not a MarkDown file), in addition, /MAINTAINERS containers more relevant information on the LGTM process and contains info about maintainers of all subsystems.
Please check if the 'root' "MAINTAINERS" document is indeed the intended target of this link.

LGTM

LGTM


chore: updated dev dependencies of ui-components and verify overrides

Triggered by https://github.com/SAP/open-ux-tools/issues/1232 I had a look at updating the devDependencies of module @sap-ux/ui-components with following results:
Update from storybook@6 to @storybook@7
There have been fundamental changes to storybook, I've followed migration guide https://storybook.js.org/docs/react/migration-guide. It required to modify the storybook scripts, added .babelrc.json, modified .eslintrc.js and .storybook/main.js. I also had do modify .storybook/manager-head.html as the setStories event is deprecated.
As a positive effect, overrides for storybook are not required anymore and dependency to webpack could be removed, storyboard uses now module @storybook/react-webpack5.
Update @testing-library/jest-dom
Unfortunately, update of @testing-library/jest-dom did not solve https://github.com/SAP/open-ux-tools/issues/1232. We also can't update to the very latest major version due to peer dependency to react 18.
Other devDependencies
I've also looked through other devDependencies of @sap-ux/ui-components and updated if possible.

Should probably add a changeset for ui5-components to release a new version.

Was not sure about this, the only change I saw that could potentially alter the dist result is updated of "sass": "1.66.1". But as you mentioned it, can't harm to increase the patch level. Will add changeset.

Should probably add a changeset for ui5-components to release a new version.

Was not sure about this, the only change I saw that could potentially alter the dist result is updated of "sass": "1.66.1". But as you mentioned it, can't harm to increase the patch level. Will add changeset.

storybook output folder /storybook is also published in the npm module.


Illegal instruction (core dumped)

Hi I have been able to run this code with CNNs but when using transformer models, I am having some issues. For example, running it with this conformer model https://colab.research.google.com/github/burchim/EfficientConformer/blob/master/EfficientConformer.ipynb#scrollTo=0HTj66OxQ4in
gives me an error "Illegal instruction (core dumped)".
When I remove the mutli_head_attention layers and also the "linear", "fc" and "subsampling" then the error is not there anymore. Additionally, when these layers are removed but I use the configuration "e5m2" rather than "e4m3" or "e3m4", i also get this error.
Any ideas, why I am getting this error when running these layers and this fp8 configuration?

Which platform are you running this on?
If you skipped "mutli_head_attention", "linear", "fc" and "subsampling" it would not invoke this library at all.
Can you include the stacktrace?

Thanks for your response. I'm using a "Tesla V100 SXM2 16GB" GPU and an "Intel(R) Xeon(R) CPU E5-2686 v4 @ 2.30GHz" CPU. I have run the code on CNNs from torchvision on the same system and haven't had issues there, only when I then moved to this Conformer model.
The error occurs at line 61 of "FP8_Emulation_Toolkit/mpemu/pytquant/cuda/fpemu.py", i.e. inside this function:
outputs = fpemu_cuda.forward(input.contiguous(), mode, size, inplace, scale, blocknorm, blocksize)., which then calls the cuda code. Do you need a further trace from this inside the cuda?
To reproduce the error - all I have done is instantiated the emulator in main.py of the respository I sent through, after the model is created. Like so:
  list_exempt_layers = [] list_layers_output_fused = [] model, emulator = mpt_emu.quantize_model(model,dtype='e4m3'.lower(), hw_patch='none',                             list_exempt_layers=list_exempt_layers, list_layers_output_fused=list_layers_output_fused, device=device, verbose=True)

Further trace down to CUDA level would be useful.
Also, which python module/layer is the origin for this error?

Are you sure you are running this on CUDA ? (check device input to the script)
The CPU you listed is old and not supported by this code -- if the code is attempted to run on this CPU, it will produce "illegal instruction" error.
On GPU, often times its insufficient memory issue -- if you are running calibration the code will allocate additional tensors to maintain internal state. Try and reducing the batch size to rule out this problem.

no activity on this issue, closing.


Doumentation Fix

Hii @Dev-tanay
The documentation does not contain the technology used section. A good documentation must contain what all techs are being used in the project.
I would love to fix this documentation issue. Please assign it to me under GSSoC'24.

Can you please level this issue?

please assign me this documentation i also want to contribute @nimitagarwal26

Hii @Dev-tanay
Could you please assign level to this issue because I won't be scored if level is not assigned.

hello @Dev-tanay
Can you please assign me the issue for gssoc '24.
Regards,
V Meenakshi Iyer


docz v2 upgrade

Description: ✍

Issue(s): 🎟

Visual: 🔍

Reference(s): 📖

@kevinbluer you using some sort of github invisible text? :P


Error parsing JS that contains property lookup macro

Similar to #289, I ran into a failure that can be reproduced with this case:
it("works when 'macro' is a property lookup", function() {
  var obj = {
    macro: 42
  };

  expect(obj.macro).to.eql(42);
});

When parsing obj.marco in the last line, it throws a stack trace like this:
/Users/btilley/.nvm/v0.10.26/lib/node_modules/sweet.js/lib/sweet.js:101
                    throw err;
                          ^
TypeError: Cannot call method 'expose' of undefined
    at eval (eval at <anonymous> (/Users/btilley/.nvm/v0.10.26/lib/node_modules/sweet.js/lib/scopedEval.js:16:69), <anonymous>:19:39)
    at step (/Users/btilley/.nvm/v0.10.26/lib/node_modules/sweet.js/lib/expander.js:1207:30)
    at enforest (/Users/btilley/.nvm/v0.10.26/lib/node_modules/sweet.js/lib/expander.js:1334:16)
    at step (/Users/btilley/.nvm/v0.10.26/lib/node_modules/sweet.js/lib/expander.js:1136:38)
    at step (/Users/btilley/.nvm/v0.10.26/lib/node_modules/sweet.js/lib/expander.js:1128:28)
    at step (/Users/btilley/.nvm/v0.10.26/lib/node_modules/sweet.js/lib/expander.js:1143:28)
    at step (/Users/btilley/.nvm/v0.10.26/lib/node_modules/sweet.js/lib/expander.js:1294:28)
    at enforest (/Users/btilley/.nvm/v0.10.26/lib/node_modules/sweet.js/lib/expander.js:1334:16)
    at expandToTermTree (/Users/btilley/.nvm/v0.10.26/lib/node_modules/sweet.js/lib/expander.js:1506:17)
    at expandTermTreeToFinal (/Users/btilley/.nvm/v0.10.26/lib/node_modules/sweet.js/lib/expander.js:1735:34)

I've been trying to track the cause of this one down, but it's giving me a bit more trouble than the last one. :)

I'm mass closing issues due to the release of 1.0 obviating lots of bugs. If you feel this issue is something we still need to address feel free to reopen.


Allow statements to be filtered by their tags

This pull request is referenced to https://github.com/gunthercox/ChatterBot/issues/925
Still needs to complete

[ ] Update training process
[ ] Tests
[ ] Statement update
[ ] Mongodb update
[ ] Documentation?

Any comments about this Preserve categories https://github.com/gunthercox/chatterbot-corpus/pull/38

@gunthercox Master, I am closing this pull request, due to many conflicts. I apologies delaying this task due to many other priority tasks on my head.

@vkosuri no problem


Fix #1382: this inside event listener object handleEvent was wrong

Leave callback a reference to the object, and only check for handleEvent method at invoke time.

and only check for handleEvent method at invoke time.

That doesn't sound quite right. Can you add the following two tests, and make sure they pass? (They're in a jsbin so I can be sure they pass in browsers. Which, well, only Chrome supports this level of ES6; so embarassing.)
http://jsbin.com/nuyavoroqe/1/edit?html,output

The tests pass for me, would you like me to add them to EventTarget-this-of-listener.html or to a new test file?

Same file works!
Would you mind trying another test? Change obj.handleEvent to a different function after addEventListener but before dispatchEvent, and see which one browsers call and which one your implementation calls.

I tested that in Safari while working on this, and it calls whatever the current handleEvent property is. Changing it after addEventListener works. I'll make tests for that too.

Great stuff, thank you very much! Will release 8.0.4 with this shortly.


Add _resource_changed() helper method to EditorResourcePicker

Similar to #95545
I noticed these two lines repeat a lot, so I extracted it into a method. It allows for less SNAME instances too.

Needs rebase.

Thanks!


CSS class for edge

Hello. How can i use css class for edges?
Now i can use only style from code:
let lineStyle = "strokeColor=rgb(96,96,96);";
let newEdge = graph.insertEdge(parent, line.line_id, '', from.vertex, to.vertex, lineStyle );

Maybe something like:
newEdge.class = ".agLine";

See named styles


Instead of a string as a key to lookup Property and Model values can we enhance it using a Enum type object?

Question: Can properties get looked up using Enums by instead of type String?
Answer: No (not yet), the APIs are currently only using a property name of type String and PropertyIdentifier.
Let’s talk about the idea of a Enum type object. This will offer another way to lookup property & model values by using a Enums. Enums in Java allow a concise way to create enumerated types such as the following:
public enum PersonField {
   FIRST_NAME("First Name"),
   MI("Middle Initial"),
   LAST_NAME("Last Name"),
   DATE_OF_BIRTH("DOB")

   private final String name;
   private PersonField(String name){
        this.name = name;
    }
    public String name() {
       return name;
    }
}

As you can see enums are more concise compared to a public static String FIRST_NAME = "firstName"; as a property name.
Current State
The current MVVM capability of Cognitive only looks up property and model values based on a key of type String of a property name (used to reference a field in a UI form). Additionally there is new support for looking up PropertyIdentifier type objects.
Enhancement
An enhancement updates the APIs to allow a Enum type object that represents a Java enumerated type. e.g. Color enum can have a label, red, green and blue color channel as shown above.
Add (create) a property using a Enum with validation

ValidationViewModel personVm =  new ValidationViewModel()
   .addProperty(FIRST_NAME, "Fred")
   .addValidator(FIRST_NAME, FIRST_NAME.name(), (ReadOnlyStringProperty prop, ViewModel vm) -> {
      // Check if first character is capitalized
      String firstChar = prop.get().substring(0,1);
      if (firstChar.toUpperCase().equals(firstChar))
         return VALID;

      return new ValidationMessage(FIRST_NAME, MessageType.ERROR, "${%s} first character must be capitalized. Entered as %s ".formatted(FIRST_NAME, prop.get()));

   });

String firstName = personVm.getPropertyValue(FIRST_NAME); // fred

Above you'll notice personVm.getPropertyValue(FIRST_NAME) is looked up by a PersonField.FIRST_NAME enum.

Released in version 1.3.0
:-)


{"detail":"Hmm...something seems to have gone wrong. Maybe try me again in a little bit."}

Describe the bug
问题描述
A clear and concise description of what the bug is.
To Reproduce
如何复现
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
期望行为
A clear and concise description of what you expected to happen.
Screenshots
截图说明
If applicable, add screenshots to help explain your problem.
Please complete the following information):
请补全以下内容

OS: [e.g. Windows]
Browser: [e.g. chrome, safari]
Extension Version: [e.g. v2.0.2]

Additional context
其他
Add any other context about the problem here.

This is usually an error from OpenAI, maybe because their servers are under too much pressure


Fixes #2765: Replaced Lambdas with method references

Description
Replaced Lambdas with method references which are available in Java 8.
Related issues and discussion
Fixes #2765

@deniger @teolemon Can you please review this PR?

@Karljoones conflicts resolved. Can you review the PR again?


ARC-470 GitHub config pg

Changes in this PR include:

Update to the overall UI of the GH config page (old vs new).

Update sync status modal - which previously had a big white gap at the bottom (old vs new)

Removal of sync options 'Normal' and 'Full' and removal of retry modal that explained what these 2 types were. 'Resync' can be found in the dropdown and will run a full sync.

Addition of a retry icon next to and failed sync with 'Retry' label that displays on hover.

Update UI when there is an error (failed connection)

Ugly error we used to render

New error:

I wonder if this PR is the chance to rename "sync" to "backfilling"? This would make it more clear that this is only for historical data.
Also: in the first screenshot in the column "Repository access" it says "All repos (3/101)". Should that be "Selected repos (3/101)"?

I wonder if this PR is the chance to rename "sync" to "backfilling"? This would make it more clear that this is only for historical data.

Have we confirmed as a team that this is the terminology we want to adopt?

Also: in the first screenshot in the column "Repository access" it says "All repos (3/101)". Should that be "Selected repos (3/101)"?

All repos means I have given access to all repos (which at the time of this screenshot was 101). At the time of the screenshot 3/101 repos were successfully synced.


intellisense not working for Javascript files stored in sharepoint document library

VSCode Version:1.5.2
OS Version:Windows 10

Steps to Reproduce:

Upload a JavaScript to a SharePoint document library
Open the document library within windows explorer
Open the Javascript file with VSCode

4. Javascript intellisense is not working
5. the file path is<EMAIL_ADDRESS>Please help to look at this issue, thank you!

Are you getting IntelliSense when typing Math.? Could you paste the content of test.js?

nothing was show whatever I typed，console. Math. function even var. VSCode
behaves like notepad
2016年9月22日 上午12:04，"chrmarti"<EMAIL_ADDRESS>
Are you getting IntelliSense when typing Math.? Could you paste the
content of test.js?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/12350#issuecomment-248659255,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADIYUIuN1N2mWP5rR3tYFBtlQDEi3CtHks5qsVV2gaJpZM4KCXSR
.

What is the detected language shown in the lower right corner of the window?

@waderyan Any idea why a file on a SharePoint would not have IntelliSense? (I tried with a network path and that worked fine.)

This may be related to https://github.com/Microsoft/TypeScript/issues/10735
@Wayne-Shen can you do the following to help us debug the issue?
Set this flag in your settings. Then open the Output window. Send us a screen capture.
"typescript.tsserver.trace": "verbose"

Hello @waderyan ,
I followed your steps and find the error message is:
TypeScript Service: tried to cancel request with sequence number 2. But request got already delivered.
TypeScript Service: canceled request with sequence number 3
TypeScript Service: canceled request with sequence number 5
TypeScript Service: canceled request with sequence number 8
...

Ok thank you. This is the same thing we have seen before.

Going to close this as its tracked above.


Adding Jesuit High School

Jesuit High School of Sacramento California, Provides<EMAIL_ADDRESS>Example: Bill Gates graduates in 2016<EMAIL_ADDRESS>School website is jesuithighschool.org, but the club page can be accessed via jhs.net

Hey when can this be merged? I am about to run out on my trial and I love using this for school...

I'm sorry for the delay. http://www.jesuitportland.org/ - is the school address, while jsh.net is not registered. please reapply with the correct domain.

@zweizwei The high school is Jesuit High School of Sacramento California
This is the whois record, and the home website for Jesuit is Jesuithighschool.org
Domain Name: JHS.NET
Registry Domain ID: 5276248_DOMAIN_NET-VRSN
Registrar WHOIS Server: whois.networksolutions.com
Registrar URL: http://networksolutions.com
Updated Date: 2015-01-28T23:28:49Z
Creation Date: 1997-05-06T04:00:00Z
Registrar Registration Expiration Date: 2016-05-07T04:00:00Z
Registrar: NETWORK SOLUTIONS, LLC.
Registrar IANA ID: 2
Registrar Abuse Contact Email:
Registrar Abuse Contact Phone: +1.8003337680
Reseller:
Domain Status:
Registry Registrant ID:
Registrant Name: Jesuit High School
Registrant Organization: Jesuit High School
Registrant Street: 1200 Jacob lane
Registrant City: Carmichael
Registrant State/Province: CA
Registrant Postal Code: 95608
Registrant Country: US
Registrant Phone: +1.9164826060
Registrant Phone Ext:
Registrant Fax: +1.231231234
Registrant Fax Ext:
Registrant Email:
Registry Admin ID:
Admin Name: Jesuit High School
Admin Organization: Jesuit High School
Admin Street: 1200 Jacob lane
Admin City: Carmichael
Admin State/Province: CA
Admin Postal Code: 95608
Admin Country: US
Admin Phone: +1.9164826060
Admin Phone Ext:
Admin Fax: +1.231231234
Admin Fax Ext:
Admin Email:
Registry Tech ID:
Tech Name: Network Solutions, LLC.
Tech Organization: Network Solutions, LLC.
Tech Street: 13861 Sunrise Valley Drive
Tech City: Herndon
Tech State/Province: VA
Tech Postal Code: 20171
Tech Country: US
Tech Phone: +1.8886429675
Tech Phone Ext:
Tech Fax:
Tech Fax Ext:
Tech Email:
Name Server: NS37.SECURENET-SERVER.NET
Name Server: NS38.SECURENET-SERVER.NET
DNSSEC: Unsigned
URL of the ICANN WHOIS Data Problem Reporting System: http://wdprs.internic.net/

Thanks for the additional info, adding the domain then.


save as

Add command to the save as menu button (the only one that is really missing)

Save as is almost completed, I am reworking opening and closing in general with a new ProjectExport{<:Any} type (this allows for multiple writers for the same file format.) E.G. write as raw julia instead of cells.

both this and #81 are nearly done!

Completed by #86 (86'd it ;))


TableQuery.Where is NOT immutable

Link to article:
https://docs.microsoft.com/en-us/dotnet/api/microsoft.windowsazure.storage.table.tablequery.where?view=azure-dotnet#remarks
Problem:
The documentation is incomplete. It seems that TableQuery.Where changes the query object that it is being called on.
For example:
_getQuery = new TableQuery<T>().Where(TableQuery.GenerateFilterCondition("PartitionKey", QueryComparisons.Equal, _partitionkey));
// _getQuery.FilterString => "PartitionKey eq 'Test'"
var qry = _getQuery.Where(TableQuery.GenerateFilterCondition("BrandId", QueryComparisons.Equal, brandID));
// _getQuery.FilterString => "BrandId eq 'b1'"

I am not sure if this is missing documentation, or a bug in the Where( ) method. I expected that _getQuery would remain unmodified, and that qry would have a FilterString = "PartitionKey eq 'Test' and BrandId eq 'b1'".
As a side remark (possible another bug): I don't have a possibility to enter comments on this page.
kr,
Gaston Verelst

@dendeli-msft Can you take a look at this issue?

GitHub user seguler has been removed from the MicrosoftDocs organization, so they were automatically removed as an assignee.

@supernova-eng The assignee has been automatically removed.


Gov Conference Travel expenses

Travel expenses for committee members and invited guests need to be budgeted and approved.

I'm willing to assist in doing this.

Just create an Issue "Travel Expenses"
Set a budget for example $10.000
Find 3 members to set this budget in Budget 201712
Travellers write in the comment of the issue for what reason they travel,
when, and the amount. And they add an invoice with copy/paste (see #171)
Ask your friends if they agree with your expenses and ask them to fill out
a percentage in Rewards 201712
For example:
If you go on holiday to Zambia and you organize a Meetup about RChain
there.
Clear? OK. Go for it :-)
--
Cheers,
HJ
On Sun, Dec 3, 2017 at 9:52 PM, ResonanceXX<EMAIL_ADDRESS>wrote:

I'm willing to assist in doing this.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rchain/Members/issues/194#issuecomment-348813562, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB0x924dcMNMQDx6pZ4OYF7Ig7xn_ufwks5s8wodgaJpZM4Qzu87
.

@lapin7 I would need authorization access for the budget sheet document. I await your response to begin work.

Please send me your email and then I can add you to the Google group RChain
--
Cheers,
HJ
On Mon, Dec 4, 2017 at 2:01 PM, ResonanceXX<EMAIL_ADDRESS>wrote:

@lapin7 https://github.com/lapin7 I would need authorization access for
the budget sheet document. I await your response to begin work.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rchain/Members/issues/194#issuecomment-348955862, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB0x93tiLrqDp6kywk-CaHgrRX_WefrEks5s8-00gaJpZM4Qzu87
.

<EMAIL_ADDRESS>Sent from Yahoo Mail on Android
On Mon, 4 Dec 2017 at 14:46, HJ<EMAIL_ADDRESS>wrote:   Please send me your email and then I can add you to the Google group RChain
--
Cheers,
HJ
On Mon, Dec 4, 2017 at 2:01 PM, ResonanceXX<EMAIL_ADDRESS>wrote:

@lapin7 https://github.com/lapin7 I would need authorization access for
the budget sheet document. I await your response to begin work.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rchain/Members/issues/194#issuecomment-348955862, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB0x93tiLrqDp6kywk-CaHgrRX_WefrEks5s8-00gaJpZM4Qzu87
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Take a look at this dear Mr. HJ
Sent from Yahoo Mail on Android
On Mon, 4 Dec 2017 at 15:11, Kenechukwu<EMAIL_ADDRESS>wrote<EMAIL_ADDRESS>Sent from Yahoo Mail on Android
On Mon, 4 Dec 2017 at 14:46, HJ<EMAIL_ADDRESS>wrote:   Please send me your email and then I can add you to the Google group RChain
--
Cheers,
HJ
On Mon, Dec 4, 2017 at 2:01 PM, ResonanceXX<EMAIL_ADDRESS>wrote:

@lapin7 https://github.com/lapin7 I would need authorization access for
the budget sheet document. I await your response to begin work.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rchain/Members/issues/194#issuecomment-348955862, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB0x93tiLrqDp6kywk-CaHgrRX_WefrEks5s8-00gaJpZM4Qzu87
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@ #

How much money will you need in Seattle? $149 is the average daily price for traveling in Seattle. The average price of food for one day is $37. The average price of a hotel for a couple

@ResonanceXX The current discussed options on discord are:
Proposed Dates
Thursday 2/15 - Sunday 2/18
(Valentines day is Feb 14, 2018)(edited)
Location:
St. Petersburg FL (TPA)
Denver, CO (DEN)

@ResonanceXX sorry for the mis-communication. But it seems to be good now. You're set up for google groups and github. So please go ahead.

Thank you. I will research some more with the updated info.
Sent from Yahoo Mail on Android
On Tue, 5 Dec 2017 at 10:57, HJ<EMAIL_ADDRESS>wrote:
@ResonanceXX sorry for the mis-communication. But it seems to be good now. You're set up for google groups and github. So please go ahead.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Hello HJ
A little clarity on the exact amount of attendees. I can compute a final figure. But check this out meanwhile.
https://docs.google.com/document/d/10nsH-bE0De1cqaaYQg4woi1QHMcYXds5RaOVVy1RkCE/edit?usp=drivesdk

HJ I suppose this could work.
https://docs.google.com/document/d/1JZR5t88dtdcMtn5ICoeQxkK6imLh-iSVS1O8yS9As6w/edit?usp=drivesdk

@ResonanceXX Did you intentionally leave out flight expenses as they vary a lot and have to be set on case by case basis?

Yeah. There would have to be a list of  location guide. Because naturally do not suppose all attendees are from same state. I'll check the average costs of travel to both probable host cities.  Thank you.

ResonanceXX

Sent from Yahoo Mail on Android
On Wed, 6 Dec 2017 at 17:10<EMAIL_ADDRESS>wrote:
@ResonanceXX Did you intentionally leave out flight expenses as they vary a lot and have to be set on case by case basis?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@Phistr90  Here are some prices for a round trip ticket to Denver, CO.
Pending the final  collective choice location. This only just guessing.
https://docs.google.com/document/d/1fnEZO5rMC5AMDRBvy1mXZzGYhjVY6LPr_JuV3c-4GQE/edit?usp=drivesdk

@ResonanceXX I brought up this issue due to the fact that I am from Germany and travel costs will be higher for me. So I guess flight expenses have to be set on case by case basis.

@Phistr90 Yeah. That would be carefully done.
Although the vote for final location is ongoing.
I do hope you have voted.

@Phistr90 Please raise the budget for #194 in Gsheet "Pub...." https://docs.google.com/spreadsheets/d/1uxuxx8YN17KCIWcH1cUoGuSm2hAnIya2iAc6wxoaq1o/edit#gid=176786742

This is done to my satisfaction.


Is it possible to use the mod (or the tool) to crack MC seed outside MC?

I'm playing Bedrock right now, so installing mod is impossible. Can I use some way to enter the coordinates into a standalone version of this mod (if it exists) or into my friend's modded client?
(assume that I can find the right coordinates for needed structures and blocks.)

I assume not, since this is a java version not c++.


Mime mapping created by letsencrypt-win-simple don't work

Hi,
The web.config file created by letsencrypt-win-simple to allow iis to serve file without extension don't work in my environment (Server 2012R0 IIS 8.0) : the acme challenge response is not accessible (error 404). I had to edit the web.config manually and replace

By

(without star).

This solution will not work as the web.config is replaced before every validation request.
This need to be changed in the source code and recompiled. I'll submit a code change asap (I have the same problem in the same environment, which produces 404 error as the mime-type isn't properly handled).

This is working for me, too. :+1:

Added in pull #33.
Included web.config has been tested with stock IIS on Server 2012, Server 2012 R2, Server 2016, Win 7, and Win 8.1. If anyone needs to make changes to the web.config file, you can update the web_config.xml file in the root of the app.That is copied instead of using text hard coded in the app. So no more need to recompile to change the web.config.

Is there a reason the challenge file can't just be created with the .html? That way most web servers would already be configured for it to be publicly accessible. Also can't allowing the dot extension lead to unintended consequences. Maybe the file extension of the challenge file can be a configuration parameter, that way no configuration changes would be needed, the implementer could simply choose an extension they know is already supported. Just an idea I'm running into this problem myself right now. Thanks.

Yes


delete some unnecessary code, fix some wrong spelling in comment

single quotation mark don't need escape.
thread should reset interrupted flag after been interrupted.
remove two unnecessary toString().
etc.

sorry, I don't notice that '<>' with anonymous inner classes is not supported in Java7, I will fix this and create a new pr.


How can use this to detect images with in certain distance?

Hi
It is a nice library, I want to build a software where I want to use real-time object detection where the object is within a certain range from the camera. How can I achieve this

See #8


Improve visualization of small inline changes

Currently, the animation slides each changed line out of the way to replace it with the new version. However, this means small changes (e.g. one character changes) will look like entire line changes, and it will be hard to tell the difference between the old line and the new line.

Another case would be indentation changes: difference in whitespace at the beginning of lines.

One potential fix could be to just slide in the new characters (instead of the whole line), while the unchanged characters in the line simply move as needed to make way for the new characters.

+1, as a small typo fix got the same line slide in/out animation as a complete line rewrite. It would be visually nicer if small typos / Inline changes get a different animation (e.g. slide-in single characters  instead of the whole line)


Loop install error when updating to lnd 0.10 after recovering from 1.5RC2 with lnd 0.10

Documenting this error (doesn't seem to break anything):

Updated a 1.5RC2 with lnd0.10 with a new 1.5 SDcard.
LND 0.10 needs to be installed manually and the Loop install shows an error ,despite being installed already.
Seems to work for now.

Saw it two but forgot to open an issue.

Loop remained on v0.5.1 (for lnd 0.9.2) where it restored initially and did not update with lnd 0.10.
Reinstalling Loop from the menu solved it and it is now functional on v0.6.0.

Normally when updating LND to 0.10.0 if LOOP was activated tit should get deinstalled and then reinstalled ... but I found a typo. Fixed this.


Add upload to Azure Storage file with full url

Related command

az storage file upload
Is your feature request related to a problem? Please describe.

Currently, I have a Azure Storage File URL with SaS token like " https://mystorageaccount.file.core.windows.net/myshare/myfile?sv=2019-02-02&st=2020-12-22T07%3A07%3A29Z&se=2020-12-23T07%3A07%3A29Z&sr=b&sp=racw&sig=redacted"
But when I use az storage file upload command to upload my local file to remote, I need to parse the URL into share-name, path and sas-token and finally invoke the command.
What worse is there is no built-in command to parse such URL into object. I have to write a script todo.
Arguments
    --share-name -s              [Required] : The file share name.
    --source                     [Required] : Path of the local file to upload as the file content.
    --sas-token                             : A Shared Access Signature (SAS). Must be used in
                                              conjunction with storage account name or service
                                              endpoint. Environment variable:
                                              AZURE_STORAGE_SAS_TOKEN.

Describe the solution you'd like

I am wondering whether the command can be designed similar to az storage blob upload. I can pass the file url as a parameter instead of parse it to several parameters.
 --blob-url                              : The full endpoint URL to the Blob, including SAS token
                                              and snapshot if used. This could be either the primary
                                              endpoint, or the secondary endpoint depending on the
                                              current `location_mode`.
Examples
 Upload to a blob with blob sas url.
        az storage blob upload -f /path/to/file --blob-url https://mystorageaccount.blob.core.window
        s.net/mycontainer/myblob?sv=2019-02-02&st=2020-12-22T07%3A07%3A29Z&se=2020-12-
        23T07%3A07%3A29Z&sr=b&sp=racw&sig=redacted

Describe alternatives you've considered

CLI can also provide a built-in method, do the contrast way of az storage file url to parse the given URL to an object. Then I can pass the object parameter to the existing command.
Additional context

Thank you for opening this issue, we will look into it.


SRC -847-fixed-operator-position

This PR:

fixed the problem of multiple display for the same dag graph
modify the /positioning gateway code to maintain a persistent order when processing the operators and returning operator dag positions

Test:
loom recording
SDK

Backend will handle the reordering of node position. Frontend and SDK only pass additional operator name into the map.


Update README.md

'zlib1g-dev' is required for ps2-packer.

If you see in the readme we don't put directly the name that the package has in Ubuntu, we put the name of the library.
For Ubuntu could be zlib-dev but for others could be just zlib as for instance MacOS.
So either we start putting in the readme the specific required libraries per platform or you just use zlib for now, which is the official name of the library
Thanks

Ok. For now, let's just use the 'general' name for the library. I edited to 'zlib'. Thanks.


feat: remove rules from default VPC security group and ACL

Description
Allows the use of new feature in the landing-zone-vpc-module to remove (clean) all rules from the default security groups and ACLs that get created with a VPC.
Currently, IBM Cloud does not allow removal of the default security group or ACL that are automatically created with a VPC, and the default rules are very permissive. Since secure landing zone creates its own groups, the defaults are not needed. They cannot be removed in whole, but the rules can be completely removed from both defaults to increase security posture.
Types of changes in this PR
No release required

[ ] Examples or tests (addition or updates of examples or tests)
[ ] Documentation update
[ ] CI-related update (pipeline, etc.)
[ ] Other changes that don't affect Terraform code

Release required

[ ] Bug fix (patch release (x.x.X): Change that fixes an issue and is compatible with earlier versions)
[ ] New feature (minor release (x.X.x): Change that adds functionality and is compatible with earlier versions)
[x] Breaking change (major release (X.x.x): Change that is likely incompatible with previous versions)

Release notes content
All patterns will now utilize the clean_default_security_group and clean_default_acl variables added to terraform-ibm-landing-zone-vpc in v7.1.0, which if set to "true" will remove all rules from the default security groups and ACLs created automatically when new VPCs are deployed.
All patterns will now set both variables to "true" by default for all VPCs, and you can override these values for each VPC when using the "override.json" file.
Since the default security group and ACL for a VPC are created with very permissive rules, setting these values to "true" to remove those rules will increase the overall security posture of the deployment.

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

Merge by using "Squash and merge".

Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author.
The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).

I think the release note should includes the following details for consumers:

How to migrate an existing override.json to be compatible with new version (eg: adding clean_default_security_group and clean_default_acl )
How to disable the new behavior that deletes network acl rules and sg rules.

@toddgiguere can you help get release notes updated before we merge? Thanks

2. How to disable the new behavior that deletes network acl rules and sg rules.

The only way to disable the behavior in the patterns is to use the override.json. I had figured that since the patterns do not attach default ACL and do not include default security group rules, the patterns will set these to "true" always (opinionated).

:tada: This PR is included in version 4.0.0 :tada:
The release is available on:

GitHub release
v4.0.0

Your semantic-release bot :package::rocket:


Tidier.jl link is broken in writeup

It should be: https://github.com/TidierOrg/Tidier.jl

Thanks for reporting this @gyansinha. I'm assuming you mean the link in this post? If so, then this is now fixed.


请问支持openEuler 这个操作系统么

最近开始操作系统国产化，这个项目考虑对openEuler 支持么

Kubean is based on kubespray, which already supports cluster deployments based on the openeuler 22.03 LTS OS.


ArgoCD have a problem with labels from Kube-State-Metrics

We encountered a issue in the template from k8s-monitoring here related to the kube-state-metrics, when I deploy using the ArgoCD, the template force used the k8s-monitoring helm in label kubernetes.io/instance, with this if you need a change to use another label in selector ArgoCD don't identify the another label same using the SelectorOverride or LabelMatchers.
For example:
The ArgoCD will generate the label using the name of cluster but the KSM don't scrape the metrics because in the template it expected the label kubernetes.io/instance: k8s-monitoring (without cluster name)
Argo CD generate like this: kubernetes.io/instance: k8s-monitoring-integration-us-east-1
K8s-monitoring-helm Kube-State-Metrics expected is: kubernetes.io/instance: k8s-monitoring
I tried to use selectorOverride like this:
kube-state-metrics:
  selectorOverride:
    app.kubernetes.io/name: k8s-monitoring
    app.kubernetes.io/instance: k8s-monitoring

Or labelMatchers like this:
  labelMatchers:
    app.kubernetes.io/name: kube-state-metrics

I tried to use both but they don’t work for me, and looking at the template I found this line here: https://github.com/grafana/k8s-monitoring-helm/blob/main/charts/k8s-monitoring/templates/alloy_config/_kube_state_metrics.alloy.txt#L16
That forces the label Release.Name in the labels because this here using the ArgoCD didn’t work, I think it can be removed of the template to avoid this kind of problem. Because it doesn't make sense to use labelMatchers if the template forces a label, there is no flexibility.

this seems like the problem that i had #239. I'm updating my grafana version from 0.12 to 1.4 and I have the same problem again. going to keep trying

This should be fixed with https://github.com/grafana/k8s-monitoring-helm/pull/696
We no longer use app.kubernetes.io/instance because ArgoCD's hijacking of that label. Instead, we use the release label, which is set to the Helm release name.


feat: gbuild add BuiltVersion

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.04 :tada:

Comparison is base (4fc24e1) 79.11% compared to head (94f822b) 79.16%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2754      +/-   ##
==========================================
+ Coverage   79.11%   79.16%   +0.04%
==========================================
  Files         633      631       -2
  Lines       52010    51891     -119
==========================================
- Hits        41150    41081      -69
+ Misses       8825     8781      -44
+ Partials     2035     2029       -6

Flag
Coverage Δ

go-1.15-386
79.12% <100.00%> (+<0.01%)
:arrow_up:

go-1.15-amd64
?

go-1.16-386
?

go-1.16-amd64
79.13% <100.00%> (+0.02%)
:arrow_up:

go-1.17-386
79.13% <100.00%> (-0.01%)
:arrow_down:

go-1.17-amd64
79.09% <100.00%> (-0.04%)
:arrow_down:

go-1.18-386
?

go-1.18-amd64
?

go-1.19-386
?

go-1.19-amd64
?

go-1.20-386
?

go-1.20-amd64
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

os/gbuild/gbuild.go
65.62% <100.00%> (+1.10%)
:arrow_up:

... and 4 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


feat(insight): support error formatting for Github actions

Also allows disabling info and error loggers

This is pretty cool:

This seems fine as well, shouldn't show up for users since the node_modules are not checked in:


Dev

[x] Python3 compatibility
[x] New solver for bicgstag/jacobi
[x] Paradiso @dwfmarchant
[x] better testing on py3 and various solvers
[x] update the interface to the paradiso solver
[x] add sym/cmplx flags

Coverage remained the same at 94.495% when pulling 61cad86178ed541e1d0eecca6ea071c76c04610a on dev into 898b75b73d645458d7ae5f3eedd0bb8dd6e4d538 on master.

Coverage remained the same at 94.495% when pulling d8232e9fa5f6c322cc7a19615c63839da8f096e5 on dev into 898b75b73d645458d7ae5f3eedd0bb8dd6e4d538 on master.

Coverage remained the same at 94.089% when pulling 7b2ac6236b3b322f0fce038f3e2e6c3db79ede45 on dev into 898b75b73d645458d7ae5f3eedd0bb8dd6e4d538 on master.


MD WIDGETS: Extract the code from Riopod and place it into the markdown_widgets package

Description
In Riopod, we defined and implemented a series of markdown-like syntax to generate widgets on the survey page. Now, we plan to extract this part of the code into a standalone package named markdown_widgets, making it easier to maintain and accessible for use in other code.
This issue requires migrating the code from Riopod into this repository and creating it as a standalone package.

Need to review and structure the code.
For discussion

[ ] lib/markdown-widgets.dart will list the exports.
[ ] Every functionality split from the single large file
[ ] Folders for features, widgets, utils, etc.

This can represent the first version. Other issues can be created to work on from here.
Can be closed once PR merged.


demos/.cargo/config.toml: exercise dot-asm/bellperson:supraseal-facelift.

@vmx, I should have checked and suggested this earlier, sorry about that, but have a look at https://github.com/dot-asm/bellperson/commit/c033439668a2f02581a3ca521401b5020872d042. The "keyword" there is switch from supraseal_c2::generate_groth16_proof() to supraseal_c2::generate_groth16_proofs(). I can open pull request in the
bellperson...

Makes sense. Yes, please open an PR on the bellperson repo.


instantiate buttons within controller

make everything final and move all of the definitions from the method to the class instantiation?

make all them jaunts final, but you won't be able to move it bc they need the this instance

literally just moved them and it's fine 🙄

wait what

can you push that commit?

boom

ok then


ENB Doesn't seem to load within FiveM

ENB Doesn't seem to load within FiveM. I followed the instructions exactly but can't seem to get ENB to actually work

That's true the menu of ENB doesn't show up when you install fsr mode :(

There is similar proxy configuration in enb's ini file. Try to rename fsr to d3d11_fsr.dll, enb to d3d11.dll and change enb config similar to fsr. I hope you understand the idea

It does not work by using enb's proxy function still.

There is similar proxy configuration in enb's ini file. Try to rename fsr to d3d11_fsr.dll, enb to d3d11.dll and change enb config similar to fsr. I hope you understand the idea

Triied that method with FiveM. I Use ReShade 5.2.2 too, and ENB version is <IP_ADDRESS>, that comes with QuantV's 2022 April package.
In enbloca.ini these values were set:
[PROXY]
EnableProxyLibrary=true
InitProxyFunctions=true
ProxyLibrary=d3d11_fsr.dll
In gta5_frs.ini:
[PROXY]
EnableProxyLibrary=false
InitProxyFunctions=false
ProxyLibrary=
Same files has debug enabled:
[DEBUG]
PrintDebug=true
Graphics are set to 2560x1440 resolution in advanced settings, and 1920x1080 as render resolution. ENB menu works, and in DebugView, when FiveM starts, it shows:
[13288] DirectX11 DLL's found.
[13288] GTA5_FSR: PrintDebug is 1
[13288] GTA5_FSR: Reading config file...
[13288] GTA5_FSR: UseFidelityFxSuperResolution is 1
[13288] GTA5_FSR: AutoSharpness is 1
[13288] GTA5_FSR: Sharpness: 0.500000
[13288] GTA5_FSR: EnableProxyLibrary is 0
but when I start story mode, no other GTA5_FSR debug lines are shown, that were displayed before, when ENB was renamed and set to GTA5_FSR.ini but not worked.

Anyone found a solution for this yet?

There is similar proxy configuration in enb's ini file. Try to rename fsr to d3d11_fsr.dll, enb to d3d11.dll and change enb config similar to fsr. I hope you understand the idea

I can't make it work in fivem with ENB (QuantV),

I do have enb d3d11 as d3d11.dll and fsr d3d11 as d3d11_fsr.dll
I also have gta5_fsr.ini with false proxy status
and enblocal.ini with true proxy status

Anyone knows how to help me?
My fsr debug view is empty, but ENB menu work. If I remove ENB it also works.

Does anyone found a solution?

I don't have fsr files at all, but it's not working

I found solution! Put your ENB files in fivem directiory in plugins folder


[Feature Request] Add currency field to Characters

I know that it it possible/recommended to add a ressource traker for money.
Having said this, I request a field/value on the character sheet for currency which corresponds to the cost field of Foundry items.
This would allow for a proper shop use with Monk's Enhanced Journal . Enabling an autonomous shopping/loot experience without the need for a GM.

@LordOHelmet Do you know what the path is to money that Monk's Enhanced Journal expects?

@mjeffw Sorry, I don't know. But I asked ironmonk88 if he could help us out.

@LordOHelmet Do you know what the data path is to money that Monk's Enhanced Journal expects?

to Actor5e#system.currency and has .pp, .gp, .sp, .cp, and .ep


[breaking change] mapping rules will be replaced instead of adding missing rules

https://issues.redhat.com/browse/THREESCALE-7215
Fixes #306

Codecov Report

Merging #308 (dccf0dd) into main (038686c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #308   +/-   ##
=======================================
  Coverage   98.43%   98.44%
=======================================
  Files         343      345    +2
  Lines       16256    16294   +38
=======================================
+ Hits        16002    16040   +38
  Misses        254      254

Impacted Files
Coverage Δ

...e_toolbox/commands/product_command/copy_command.rb
100.00% <ø> (ø)

...toolbox/commands/product_command/import_command.rb
98.36% <ø> (ø)

...unit/commands/backend_command/copy_command_spec.rb
100.00% <ø> (ø)

...e_toolbox/commands/backend_command/copy_command.rb
100.00% <100.00%> (ø)

..._command/copy_command/delete_mapping_rules_task.rb
100.00% <100.00%> (ø)

...lbox/commands/backend_command/copy_command/task.rb
100.00% <100.00%> (ø)

...product_command/copy_command/copy_backends_task.rb
100.00% <100.00%> (ø)

...and/copy_command/delete_mapping_rules_task_spec.rb
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 038686c...dccf0dd. Read the comment docs.

ready for review @miguelsorianod


beforeRender / afterRender events not implemented?

Sigma exposes beforeRender and afterRender events in its AdditionalEvents. Registering them doesn't do anything, and further investigation yields there is no mention of them in react-sigma's useRegisterEvents.ts. Implementing them would be much appreciated, thanks!

Published in v3.3.0


Unexpected clang-tidy indentation warning on Qt's emit keyword

Problem
This issue is related to clang-tidy diagnostics, which is run by VSCode's clangd extension. If this is not the right place for this issue, please indicate the right spot.
I have a Qt-based project, with some code looking as the one below:
void Class::_set_progress(const float &value)
{
    constexpr float MIN = 0.0, MAX = 100.0;

    if (_progress != value) {
        if (value < MIN) {
            _progress = MIN;
        }
        else if (value > MAX) {
            _progress = MAX;
        }
        else {
            _progress = value;
        }

        emit progress_changed();
    }
}

Qt supplies #define emit so the preprocessor replaces emit with nothing and clang-tidy emits a warning on progress_changed:
misleading indentation: statement is indented too deeply [readability-misleading-indentation]
        emit progress_changed();
             ^
did you mean this line to be inside this 'if'
        if (value < MIN) {
        ^

If I remove a space before emit, the warning disappears.
Since emit is a standard Qt keyword, would it be possible to not display this warning ?
Logs
N/A
System information
Output of clangd --version:
clangd version 16.0.6
Features: windows
Platform: x86_64-pc-windows-msvc

clang-tidy is also on version 16.0.6
Editor/LSP plugin:
Visual Studio Code clangd plugin
Operating system:
Windows 10 Entreprise, version 22H2, build 19045.4529

Nevermind, I just found https://github.com/llvm/llvm-project/issues/71767 which solves my issue.


Provide a method to start Docker for MAC with LCFS

Docker runs in a Linux VM on MAC.  This VM could be accessed by running the following command:
"screen ~/Library/Containers/com.docker.docker/Data/com.docker.driver.amd64-linux/tty"
It should be possible to install LCFS in that VM and start docker with LCFS as graphdriver.  Provide a method to automate this for end user.

To clarify, the convenience script for lcfs does not run on VM because bash is not available.
Also, the documentation states that one must "Chose a device to provide to lcfs. lcfs requires a block device (you can also use a file, but this is not recommended due to performance reasons)". My question is, is the expected performance of lcfs using a file device still expected to be higher than overlay2? If so, the resolution of this issue should contain some wording which states that.

Ideally, a device should be given to the VM for using as the backend of /var/lib/docker.  It is hard to say whether lcfs performance will be better than overlay2 when a file is used, given that the file is backed by the vmdk.

Hey @jjobi I'm told that you managed to get LCFS on the Docker for Mac VM up and running. Please could you share your method for compiling tcmalloc, or did you perhaps work around this? It seems that gperftools which provides tcmalloc is not supported on Alpine (due to musl).

I did not get it working.  You could probably try to build it after removing tcmalloc and profiler from Makefile.

Did you try running commands in the convenient script manually?  You may bypass building from sources that way....

Install Docker: https://docs.docker.com/docker-for-mac/install
Log into the Docker VM:
screen ~/Library/Containers/com.docker.docker/Data/com.docker.driver.amd64-linux/tty
Run this to install and run LCFS:
apk update && apk add bash util-linux && curl -fsSL http://lcfs.portworx.com/alpine/lcfs-setup.sh | bash

Thanks for this installer. The installation process was painless and successful.
However, about 13m into building all our containers, I ran into this error:
ERROR: Service 'quark' failed to build: Post http://%2Frun%2Fdocker%2Fplugins%2F61139cdf6bf4b70aa27e81ea3eed40ce0c1dc7cdb0df6606db741db8f46680f1%2Flcfs.sock/GraphDriver.Diff: dial unix /run/docker/plugins/61139cdf6bf4b70aa27e81ea3eed40ce0c1dc7cdb0df6606db741db8f46680f1/lcfs.sock: connect: no such file or directory

Immediately prior to installing LCFS I had reset ("pressed the bomb") the Docker for Mac VM.
Should I file a new issue for this?

Restarting the Docker for Mac VM brought it up again with the default storage driver and no images. I understand this is because the start command for dockerd needs some flags, however I don't think users will widely utilise this storage driver if they need to issue some incantations after every reboot. Is it possible to modify the startup script?

Thanks for trying out LCFS for Mac.
Updated instructions for installing LCFS for MAC can be viewed in https://github.com/portworx/lcfs/blob/master/INSTALL-Mac.md.
Please open issues for any problems you encounter while testing LCFS.  LCFS needs to be re-configured every time Docker is restarted from the menu as of now.  We are working on addressing that issue.  Docker could be restarted from the VM by running "/etc/init.d/lcfs restart".

Rob, you might have hit OOM while testing LCFS.  LCFS being a Docker V2 plugin, requires more memory to run as the plugin needs to transfer large tar archives between Docker and LCFS.  So please retry after increasing the memory for the VM to 4GB.  If you encounter any issues, please check for the presence of any cores (in /var/cores, /tmp etc.).  Also check /var/log/messages for any indication of the problem.


Docker automated builds

I noticed the last time the Docker Hub image was updated was 2 months ago.

Is it possible to setup automated builds? The screenshot below shows the required config for both a "latest" (i.e. built from master) and a released version.

Source Type
Source
Docker Tag

Branch
master
latest

Tag
/^v([0-9.]+)$/
release-{\1}

@zricethezav is there anything else I can do to help this one? Happy to configure this for you if want to make me a collaborator on Docker Hub for this project.

Looks like the author is struggling to deal with the popularity of this library :(

I'll get on it this week

https://hub.docker.com/r/zricethezav/gitleaks/tags @prabhu @petegallagher there ya go. I'll be updating the makefile/dockerfile next release

Awesome, thank you.


added postgres

added postgres support

Codecov Report
Base: 50.33% // Head: 50.11% // Decreases project coverage by -0.22% :warning:

Coverage data is based on head (b789740) compared to base (01d9cef).
Patch coverage: 6.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   50.33%   50.11%   -0.22%
==========================================
  Files          32       32
  Lines        2529     2542      +13
==========================================
+ Hits         1273     1274       +1
- Misses       1256     1268      +12

Impacted Files
Coverage Δ

cashu/core/db.py
68.00% <0.00%> (-7.23%)
:arrow_down:

cashu/mint/startup.py
0.00% <0.00%> (ø)

cashu/core/settings.py
95.34% <100.00%> (+0.11%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

psycopg2-binary

Please add psycopg2-binary as a optional dependency to pyproject.toml under the group name "postgres"

We also need to catch the error on import if the user chose postgres without installing the dependencies:
try:
    import psycopg2
except ImportError:
    raise Exception("Install psycopg2 or psycopg2-binary if you want to use a PostgreSQL database")

ok will do!

Please run make format and push again.

ok - I think I added psycopg2-binary to the pull request. Can you check if ok?

Hi @trbouma I've resolved the conflicts. Can you run make format once again please?
I would like to put the postgres dependency as an optional one into the pyproject. Can you do that?

We should also add the default entry into .env.example and a comment of how to use postgres and what kind of MINT_DATABASE entry to add if you want to use it.

in other pull request