Unable to read reference sequence base past end of current cached sequence.

Erik;
I was working on validating the latest head today and ran into issues like:
Exception: Unable to read reference sequence base past end of current cached sequence.

I know you checked in a fix to address this (https://github.com/ekg/freebayes/commit/c5efe19a4eb40ce6c1f6ef82c67bb766d319c0f6), but I'm still finding issues with this included.
Here's a reproducible test case with a small shell script. You should only need to adjust the path to GRCh37:
https://s3.amazonaws.com/chapmanb/fb/freebayes_pastend.tar.gz
While reducing this, I noticed that the command will work okay with no changed parameters but not with --min-repeat-entropy 1:
freebayes -f $ref -b reads.bam --targets regions.bed > ok.vcf
freebayes -f $ref -b reads.bam --targets regions.bed --min-repeat-entropy 1 > fail.vcf

So this raises a couple of issues:

There are still some edge cases causing this problem, which this hopefully helps identify.
Should I still be using --min-repeat-entropy? I added it based on this discussion (https://groups.google.com/forum/#!msg/freebayes/GvxIzjcpbas/1G6e3ArxQ4cJ) but I don't know where that stands with the latest development work.

Please let me know if any other information would be useful. Thanks much.

Erik;
I put together a validation of the latest FreeBayes head (0.9.21-13) versus Genome in a Bottle using single, pooled and joint calling. This removed --min-repeat-entropy so I'd avoid the error above. It looks like something is problematic with the latest set of changes as they are much less sensitive than the previous evaluation. Here's the 0.9.21-13 comparison:
http://imgur.com/a/hQAps
and here is 0.9.21-7:
http://imgur.com/a/ancGz
Hope this helps and happy to provide more details. Thanks as always for all the great work on FreeBayes.

Thanks Brad. At least we know which version is functioning better, so I can
compare them to see what might be triggering this.
On Apr 25, 2015 10:28 AM, "Brad Chapman"<EMAIL_ADDRESS>wrote:

Erik;
I put together a validation of the latest FreeBayes head (0.9.21-13)
versus Genome in a Bottle using single, pooled and joint calling. This
removed --min-repeat-entropy so I'd avoid the error above. It looks like
something is problematic with the latest set of changes as they are much
less sensitive than the previous evaluation. Here's the 0.9.21-13
comparison:
http://imgur.com/a/hQAps
and here is 0.9.21-7:
http://imgur.com/a/ancGz
Hope this helps and happy to provide more details. Thanks as always for
all the great work on FreeBayes.
—
Reply to this email directly or view it on GitHub
https://github.com/ekg/freebayes/issues/165#issuecomment-96168621.

Do you have the commit id for 0.9.21-7. I can dig around to figure it out.

Erik;
Thanks so much. Here is 0.9.21-7, that works as expected:
https://github.com/ekg/freebayes/commit/7dd41dbc8c789d5a82288bbafc983ad525f04061
and 0.9.21-13 was problematic:
https://github.com/ekg/freebayes/commit/c5efe19a4eb40ce6c1f6ef82c67bb766d319c0f6

Hi Erik,
I am still having the same error as above with either using 7dd41db or c5efe19 when I try to call variants. An interesting thing is that 5 out of 10 samples ran without errors while the rest of samples keep returning the error looking like below using the same reference file:

Exception: Unable to read reference sequence base past end of current cached sequence.
isotig04815:22
21-324
alignment: CTCCCTCGGATTTTCAAGGGCCGTCGAAAGCGCACCGGACCCCACAAGAAGTGTGGGGCTTTACCGGACGTGAAACCCTATCTCCGGCTAAACCGATTTCAGGGTGACAGCCCGTTAAAAAGAAAAGAGAACTCTTCCCGGGGCTCTCGCCGACGTCTCCGAGTTCGGTTGCGTTACCGCTGGTG----CCACTAG--GTGGCAGTATCCCTGTTCTGGTTCGGGAATATTAACCCGATTCCCTTTCGATAGGCGGCCCAAGATTGGGCACTTTGTAACGGAATTTCCCTATCTCTTAGGATC
currentSequence: CTCCCGCGGATTTTCAAGGGCCTCCCGCGGATTTTCAAGGGCCGTCGAGAACGCACCGGACACCACAAGAAGTGTGGTGCTTTACCAGGCATTAAACCCTATCTCCGGACAATCCGATTTCAGGGTGAAAGCCTGTTAAAAAGAAAAGAGAACTCTTTCCGGGGCCCCCGCCGGCGTCTCCGCGTTCGGTTGCGTTGCCGCACTTGCCACCCACGAGGAGTGGCAATATCCGTGTTCCGGTTCGGGAATATTAACCCGATTCCCTTTCGATAGACGGCCCAAGATTGGGCACTTTGACACGGAGTTTCCCTATCTCTTAGG
currentSequence matching:
terminate called after throwing an instance of 'std::out_of_range'
what():  basic_string::substr
Aborted
I was curious if you have any suggestion what to do with this issue. Any comment/suggestion will be appreciated. Thank you for your time.
KT

The problem is dependent on the use of --targets. So this seems to relate to issues with running whole-genome vs. targeted analysis producing different (or broken) results. I think I see what's going on. The jump of target regions is resetting the cached reference sequence (which should be the entire chromosome now). Then the entropy calculation is trying to examine bits of the reference and thus causes the crash.
I should have a fix for this soon, although I'm very concerned about @chapmanb 's report of regressions in sensitivity. I'm not sure what's going on there as in the test provided I don't detect any difference in the output of 7dd41db and c5efe19. That said, numerical instabilities with very small probabilities seem to be yielding minutely different QUAL values for some sites, which makes comparison a bit of a pain. I can run on a larger dataset but I'm feeling like this problem is more related to mishandling the --targets case than something fundamental about the operation of the model.


AutoSizer doesn't show List after zooming out

I have this weird bug when I use AutoSizer and List together, along with display flex applied on a parent container. Pseduocode below:

<AutoSize>
{({width, height}) => <List width={width} height={height} />}
</AutoSize>

When I try to zoom out to 80%, the list disappears. If I try to drag the browser to enlarge it vertically, it reappears. Upon investigation, the rowRenderer function doesn't run when I zoom out. I couldn't write code to reproduce it because it seems to appear on some laptops and not others. (For example, I could reproduce it with a different screen size.)
This is a really weird bug and I suspect it has something to do with certain browsers only. Do you know anything that might cause this problem or anyone opened a similar issue before?

Sorry, but I don't know what would cause this. It could be a browser bug, maybe a flexbox quirk. I don't think there's any action I can take on this though with this little amount of information unfortunately.
I think I'm going to close this for now since I don't think there's any action I can take on it, but we can still talk about it via comments and I can re-open if more info is provided and it looks like something caused by, or avoidable by, react-virtualized. 👍


combine licence files for StationEvents audio

About the PR
I don't think there was any particular reason these were in two separate files, just legacy clutter
Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Ah. I see. I did not realise we were playing the "do not volunteer yourself to go URL hunting" game

The commit hash was changed because, it turns out, the one we had on file was for an unrelated change

Yep, I checked both hashes and the new one seems to be the correct one.

Damn, Ed sniped my merge while I was typing my message.


Integration example

Hello, im having trouble integrating this into other training loops. The shapes of the arrays are a bit hard to understand. Would you mind showing an example of where you use it on a dataset?

The demo is just of an untrained perceiver model doing a prediction on a fake image. It doesn't show how to train


bug: investigate potential app mode bug

Don to provide details and confirm if this is in fact a bug and fix it if it is

When I changed the app modes, it goes into a debug and takes a while to change the mode.


Fix threads library linkage issue

fixes library linkage #2
adds modern CMake way of linking libraries

Thanks :D


ref #581: transfer custom data to new basket article used to update b…

…asket
required to allow custom data dependent stock from being properly calculated

Q
A

Branch
6.3.x

Bug fix?
yes

New feature?
no

BC breaks?
no

Deprecations?
no

Tests pass?
yes

Fixed issues
chameleon-system/chameleon-system#581

License
MIT

doubled


suggestions to use DOWNSAMPLINGS in the v3 freq_meta

I copied the changes you made for the merge_arrays and update how we use get downsamplings, test worked.

Why though? Are the ones one the release HT wrong?

If they are not wrong, I would much prefer take them from there, just like we do the hists

They are not present in v3 release HT.

I saw the error in your test run.

So odd, I'm not sure why they are not there, thanks for putting in

Yes, it looks better, I only changed it to int() instead of str().

Ah yes, good point


Color legend

First off, thanks for this incredible tool 😄
I may have missed this, but it'd be nice to know what the different colors mean.
At first I thought green meant "resolved" and yellow meant "not enough info" or something. It was only after finding this that I could see a full list (and even then, you can only get an idea of what the color is since it's code).
A legend in the docs, README, or better yet, in options.html would be awesome.

Great idea! I still don't know the meaning of these colors :cry:

I thought it would become natural as you used it, but since you two are saying this I just realized I was very wrong.

yellow means the module is external, probably fetched from a registry;
blue means it is from the standard library;
green means it's a relative file or "local" module;
red means "not enough info" so the link is a guess and may be wrong;
brown (almost yellow) means the module is external, and we're purposedly linking to its documentation instead of to its source code (this occurs only in functional languages).

These colours are set with CSS variables, so it would be easy to make them configurable through the options page, but I don't know if it is a good idea. What do you think?

@fiatjaf I think that legends can be quite enough for now. Or may be hint (tooltip, like title attribute) will be more helpful and useful!


Integer values are converting into float while reading with inferschema

Original Data.Check the contractID in original data.

Check after reading with inferschema the .0 has been added to id's

And also unlike csv badrecordspath while reading with schema is not working in this.Did someone tried schema withbadrecordspath?

Hi
The addition of the ".0" is how the value is being displayed. It does this because the value is a double and this, in turn, is because Excel stores all worksheet numbers as doubles (despite all the options in Excel they end up as doubles). They can be easily cast to integers after extraction though.
The badrecordpath is an interesting one. For things like csv and json the string of the record read so far is written out, but Excel doesn't have a string representation of a record, and so it would need to be converted to a different format before being written out. But could be something that we look at as an option.

Hi
Thank you for the response
I am reading the dataframe with .schema option expecting all bad records
will go into badrecordsPath given in the options but it keeping null values
in place of badrecords(just like cast option).So, I thought of doing
subtract operation between dataframe(reading without schema option) and
dataframe(with schema option or casted dataframe) to get badrecords. This
logic is working for me for delta sources as delta also won't support
badrecordsPath option. Since the dataframe(reading without schema) has all
the double values in it the subtract/left anti join wouldn't work. So, Is
there is any option to get bad records seperately while reading a folder of
excels with schema?
On Sat, 20 May, 2023, 11:50 am Darren Fuller, @.***>
wrote:

Hi
The addition of the ".0" is how the value is being displayed. It does this
because the value is a double and this, in turn, is because Excel stores
all worksheet numbers as doubles (despite all the options in Excel they end
up as doubles). They can be easily cast to integers after extraction though.
The badrecordpath is an interesting one. For things like csv and json the
string of the record read so far is written out, but Excel doesn't have a
string representation of a record, and so it would need to be converted to
a different format before being written out. But could be something that we
look at as an option.
—
Reply to this email directly, view it on GitHub
https://github.com/elastacloud/spark-excel/issues/26#issuecomment-1555682402,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM6TTQMEL75CLI776LJUP7DXHBPDZANCNFSM6AAAAAAYH5BLR4
.
You are receiving this because you authored the thread.Message ID:
@.***>

Bad records tend to be those which do not comply with the document format, so invalid JSON in a multi-line JSON file, or CSV files where the line doesn't have enough records.
So reading this, are you looking for records which do not conform to the supplied schema?

Yes
In our case bad records are the records which do not obey schema
On Sat, 20 May, 2023, 3:49 pm Darren Fuller, @.***>
wrote:

Bad records tend to be those which do not comply with the document format,
so invalid JSON in a multi-line JSON file, or CSV files where the line
doesn't have enough records.
So reading this, are you looking for records which do not conform to the
supplied schema?
—
Reply to this email directly, view it on GitHub
https://github.com/elastacloud/spark-excel/issues/26#issuecomment-1555880855,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM6TTQMYDAMKPEC54MHDY2LXHCLCHANCNFSM6AAAAAAYH5BLR4
.
You are receiving this because you authored the thread.Message ID:
@.***>

So one of the things that we could do is implement a failure safe parser which would write the data to a "corrupt" column, which you would need to specify in the schema you're passing in. The issue would be working out how to represent the Excel data this way, and there are some who advise against using this, but it would mean that in PERMISSIVE mode you would have a way of getting to that data.
Another option would be to simply check for null values and filter out those rows, especially in instances where you know the column should not contain nulls.
The problem with Excel is you could end up with a lot of these as it's pretty (very) rubbish as a data interchange format, so blank rows, partial rows, etc... would very likely fail a schema check.

Have a look at the PR #27 and let me know if it's the kind of thing you're looking for

Hi Darren,
That was very quick
Will check and get back to you
Thank you!
On Sun, 21 May, 2023, 3:03 pm Darren Fuller, @.***>
wrote:

Have a look at the PR #27
https://github.com/elastacloud/spark-excel/pull/27 and let me know if
it's the kind of thing you're looking for
—
Reply to this email directly, view it on GitHub
https://github.com/elastacloud/spark-excel/issues/26#issuecomment-1556130838,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM6TTQL5VSYRRG7T7SRDVWDXHHOOFANCNFSM6AAAAAAYH5BLR4
.
You are receiving this because you authored the thread.Message ID:
@.***>

I'm trying to avoid the list of house chores I need to do 😆

Lol!
On Sun, 21 May, 2023, 3:14 pm Darren Fuller, @.***>
wrote:

I'm trying to avoid the list of house chores I need to do 😆
—
Reply to this email directly, view it on GitHub
https://github.com/elastacloud/spark-excel/issues/26#issuecomment-1556133039,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM6TTQI74WS3S2CVS3GI4XLXHHPW5ANCNFSM6AAAAAAYH5BLR4
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hi Darren
Now I'm getting another issue!Could you check is it because of the enhancement.

Weird, that looks like a problem reading the Excel source file. Is there a chance you're able to share it?

yes, this is the file I was trying to read. I placed this file inside a folder, and I have given folder path in spark read command.
SampleData.xlsx

Any update on this issue?

I've loaded up the sample data and can't re-create the error that you're seeing. I'm using a version of the library compiled for Spark 3.3.2 against Databricks Runtime 12.2 LTS

I am using DBR of 11.3LTS. Can you downgrade you DBR and try again if possible?


Support for COUNT(*)

The query parser seems to not support COUNT(*). Is there a timetable for resolving this problem?
PS: I also vote for adding FILTER NOT EXISTS to clever.

Hi,
PR #1411 Will add support for COUNT([DISTINCT] *). It is already running on our public wikidata endpoint. Not that there is currently a bug that shows too large results for the DISTINCT case when the query contains a property path. This has already been fixed, but not yet deployed to the endpoint.
You can expect this to be merged some time next week hopefully.
FILTER NOT EXISTS is somewhere on the list (currently thinking about the correct semantics and an efficient implementation), but we do not have an estimated time frame for this.

That's great news. Thank you this information. Please keep me posted about FILTER NOT EXISTS.

Hi, thanks again for supporting this.
However, I couldn't get it to work:
> qlever --version
qlever 0.5.6

> curl -s localhost:7019 -H "Accept: text/tab-separated-values" --data-urlencode query='SELECT (count (distinct *) as ?cnt) WHERE { ?s ?p ?o } LIMIT 10'
{
    "exception": "Invalid SPARQL query: This parser currently doesn't support COUNT(*), please specify an explicit expression for the COUNT",
    "metadata": {
        "line": 1,
        "positionInLine": 8,
        "query": "SELECT (count (*) as ?cnt) WHERE { ?s ?p ?o } LIMIT 10",
        "startIndex": 8,
        "stopIndex": 16
    },
    "query": "SELECT (count (*) as ?cnt) WHERE { ?s ?p ?o } LIMIT 10",
    "resultsize": 0,
    "status": "ERROR",
    "time": {
        "computeResult": 2,
        "total": 2
    }
}

Any hints?

@tholiebig It looks like you are using an old version of QLever. Are you using Docker? Then make sure that you pull the latest version with docker pull adfreiburg/qlever.

Yes, that did it. Thanks @hannahbast  I suggest to add this to the usage description.


MySql supports numeric field values  +1

MySql supports numeric field values from +1, but I found that after exp.Record conversion will be treated as a string
follows
g.Record{"rec": "rec + 1"}
conversion
rec =  'rec + 1'
However I just want to get something like this
rec =  rec + 1
Do you have a better solution for this?

goqu.Record{
	"index": goqu.L("index +1"),
}


Change bytecode from Enum to bytes

Currently, to save time, the byte code is generated as an enum variant instead of raw bytes. This means that every instruction will be the same size, which increases the size of the output code. All byte code should be generated as raw form, so it is truly byte code.

Fixed


Enhancement of the plot_transitions() method

plot_transitions() is a method of class ParameterSweepBase which can be used for plotting energies associated with various transitions as a function of a scanned parameter. An example of how it can be used is presented here.
We are looking to add an enhancement where one can pass lists of tuples as arguments initial and/or final, with specific state labels that represent initial and final transition end-points of transitions that should be plotted. So for example calling:
    sweep.plot_transitions(initial=[(1,2,4), (1,3,1)], final=[(0,1,0)])

should lead to (only) transitions between levels with labels (1,2,4)<->(0,1,0) and (1,3,1)<->(0,1,0) being plotted.
These changes should not break current code, and should be documented in the method's docstring.
(It would of course be great, if this addition would be also briefly explained in the documentation - but that is not part of the bounty).

I will work on this

Great. No need to assign. Please feel free to work on this. Yes the old format from passing in final state  should also work.

Currently working on this will send a PR shortly

let us know if you are having any issues @anushkrishnav  and if we can help in any way.

plot_transitions() is a method of class ParameterSweepBase which can be used for plotting energies associated with various transitions as a function of a scanned parameter. An example of how it can be used is presented here.
We are looking to add an enhancement where one can pass lists of tuples as arguments initial and/or final, with specific state labels that represent initial and final transition end-points of transitions that should be plotted. So for example calling:
    sweep.plot_transitions(initial=[(1,2,4), (1,3,1)], final=[(0,1,0)])

should lead to (only) transitions between levels with labels (1,2,4)<->(0,1,0) and (1,3,1)<->(0,1,0) being plotted.
These changes should not break current code and should be documented in the method's docstring.
(It would of course be great if this addition would be also briefly explained in the documentation - but that is not part of the bounty).

I was able to get the graph working for a list of initial and final however,
I am getting error when I try to recreate the above example where initial= [(1,2,4), (1,3,1)], final=[(0,1,0)]
Error:

Reason being initial_energies being nan for initial state of (1,2,4)
While the below works
sweep["ng":0.0].plot_transitions(initial=[(1,0,0),(0,0,0)],final=[(1,1,0)])

Also when I remove the
["ng":0.0] I am met with the following error, is it coore

Thanks for taking a stab at this @anushkrishnav
Maybe you can check in a version of the code with your changes (to a forked repo, say), and add the notebook you're writing to test this - and I can take a closer look.
It is indeed true that some of the labels will be essentially undefined; it just means that there isn't a single bare state that is a "close enough" match with a large enough overlap. I'm not sure if this is the issue here, or it's something else... but if you check in your code, i can try to take a quick look.

Pushing the notebook on a PR here, can delete it or force merge later ?

@petergthatsme I have created a PR, can you please check I would love to get this  issue done by 12 th

thanks. I will try to take a closer look tonight.

thanks. I will try to take a closer look tonight.

Awesome let me know I am available for the next 12 hrs to work on this

sorry for the slow response - busy day.
I had a quick chance to look at your comments above.

Reason being initial_energies being nan for initial state of (1,2,4)

In the worksheet i see that dim for the last subsystem is set to 4... so that would make a state labeled (1,2,4) invalid; i.e. one could at most have three photons resulting in (x,y,3). So maybe that's the problem.
A somewhat related issue; in an arbitrary Hilbertspace objects, some of the bare_labels will be undefined as some states may just be too hybradized. The code should ideally handle those cases gracefully; i.e. not crash... (if that's the only state provided for either initial or final, maybe even spit out the warning?).. not sure if we're currently handling all the corner cases gracefully though.

Also when I remove the ["ng":0.0] I am met with the following error, is it coore

well.. this makes sense.. the scan is over two variables, so by removing that, you're not fixing either of them.. hence the plots would have to be 3d - not something we support here.. (although make a nicer error message could be nice ;)

In the worksheet i see that dim for the last subsystem is set to 4... so that would make a state labeled (1,2,4) invalid; i.e. one could at most have three photons in the last subsystem resulting in (x,y,3). So maybe that's the problem.

Got it so I will try to check the code with (x,y,3) maybe also throw an error back to user if they attempt what I did ? gives them a straightforward reason why something like (1,2,4) might not work ?

right.... it would indeed be good to maybe have some sanity checking code at the beginning of the method that will check all the input; i.e. are all the provided states (initial or final) in the right ranges.

I am currently working on this do you have any example code to test the plot transition with initial and final ?

well you could just use the code you already have in the notebook, but just try passing some invalid initial/final states (e.g. out of range levels, bad formatting, etc).

Just to confirm, the current task in hand is to handle wrong inputs, did you get a chance to test if the plot works for valid inputs on initial and final?
Also what would be a valid initial final tuple ? it would nice to get a few example to check if plot works well

well.. this makes sense.. the scan is over two variables, so by removing that, you're not fixing either of them.. hence the plots would have to be 3d - not something we support here.. (although showing a nicer error message could be nice ;)

The warning for this is already being raised
File ~/Documents/scqubits/scqubits/core/param_sweep.py:748, in ParameterSweepBase.plot_transitions(self, subsystems, initial, final, sidebands, photon_number, make_positive, coloring, param_indices, **kwargs)
    [746](https://file+.vscode-resource.vscode-cdn.net/Users/anushkrishnav/Documents/scqubits/~/Documents/scqubits/scqubits/core/param_sweep.py:746) param_indices = param_indices or self._current_param_indices
    [747](https://file+.vscode-resource.vscode-cdn.net/Users/anushkrishnav/Documents/scqubits/~/Documents/scqubits/scqubits/core/param_sweep.py:747) if not self._slice_is_1d_sweep(param_indices):
--> [748](https://file+.vscode-resource.vscode-cdn.net/Users/anushkrishnav/Documents/scqubits/~/Documents/scqubits/scqubits/core/param_sweep.py:748)     raise ValueError(
    [749](https://file+.vscode-resource.vscode-cdn.net/Users/anushkrishnav/Documents/scqubits/~/Documents/scqubits/scqubits/core/param_sweep.py:749)         "Transition plots are only supported for a sweep over a "
    [750](https://file+.vscode-resource.vscode-cdn.net/Users/anushkrishnav/Documents/scqubits/~/Documents/scqubits/scqubits/core/param_sweep.py:750)         "single parameter. You can reduce a multi-dimensional "
    [751](https://file+.vscode-resource.vscode-cdn.net/Users/anushkrishnav/Documents/scqubits/~/Documents/scqubits/scqubits/core/param_sweep.py:751)         "sweep by pre-slicing, e.g.,  <ParameterSweep>[0, :, "
    [752](https://file+.vscode-resource.vscode-cdn.net/Users/anushkrishnav/Documents/scqubits/~/Documents/scqubits/scqubits/core/param_sweep.py:752)         "0].plot_transitions(...)"
    [753](https://file+.vscode-resource.vscode-cdn.net/Users/anushkrishnav/Documents/scqubits/~/Documents/scqubits/scqubits/core/param_sweep.py:753)     )
    [754](https://file+.vscode-resource.vscode-cdn.net/Users/anushkrishnav/Documents/scqubits/~/Documents/scqubits/scqubits/core/param_sweep.py:754) specdata_for_highlighting = self.transitions(
    [755](https://file+.vscode-resource.vscode-cdn.net/Users/anushkrishnav/Documents/scqubits/~/Documents/scqubits/scqubits/core/param_sweep.py:755)         subsystems=subsystems,
    [756](https://file+.vscode-resource.vscode-cdn.net/Users/anushkrishnav/Documents/scqubits/~/Documents/scqubits/scqubits/core/param_sweep.py:756)         initial=initial,
   (...)
    [762](https://file+.vscode-resource.vscode-cdn.net/Users/anushkrishnav/Documents/scqubits/~/Documents/scqubits/scqubits/core/param_sweep.py:762)         param_indices=param_indices,
    [763](https://file+.vscode-resource.vscode-cdn.net/Users/anushkrishnav/Documents/scqubits/~/Documents/scqubits/scqubits/core/param_sweep.py:763)     )
    [766](https://file+.vscode-resource.vscode-cdn.net/Users/anushkrishnav/Documents/scqubits/~/Documents/scqubits/scqubits/core/param_sweep.py:766) specdata_all = copy.deepcopy(self[param_indices].dressed_specdata)

ValueError: Transition plots are only supported for a sweep over a single parameter. You can reduce a multi-dimensional sweep by pre-slicing, e.g.,  <ParameterSweep>[0, :, 0].plot_transitions(...)

well.. if you can get some sanity checks in place that would be good.
Valid inputs include initial and final states that are in-range. So say, you have a two-subystem Hilbert space of dimensions (3,5). Valid states include those where the first index varies between 0 and 2 and second between 0 and 4.
i haven't not had a chance to extensively test your code yet.

Sounds good, I will put some checks and request a review on the code


Bug fix: reintroduce _modules.prepare to import_module

Issue #, if available:
import_module needs to use _modules.prepare as well.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #139 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   95.47%   95.47%   +<.01%
==========================================
  Files          20       20
  Lines         839      840       +1
  Branches       73       73
==========================================
+ Hits          801      802       +1
  Misses         23       23
  Partials       15       15

Impacted Files
Coverage Δ

src/sagemaker_containers/_modules.py
97.1% <100%> (+0.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b23264e...7387d83. Read the comment docs.


fast clone instructions

This is a blobless clone (full tree/history, but files not attached to master HEAD pulled on demand)
https://github.blog/2020-12-21-get-up-to-speed-with-partial-clone-and-shallow-clone/
$ time git clone --filter=blob:none --recurse-submodules --also-filter-submodules https://github.com/commaai/openpilot.git
Cloning into 'openpilot'...
remote: Enumerating objects: 64512, done.
remote: Counting objects: 100% (498/498), done.
remote: Compressing objects: 100% (248/248), done.
remote: Total 64512 (delta 313), reused 389 (delta 228), pack-reused 64014
Receiving objects: 100% (64512/64512), 13.83 MiB | 27.88 MiB/s, done.
Resolving deltas: 100% (41397/41397), done.
remote: Enumerating objects: 1620, done.
remote: Counting objects: 100% (442/442), done.
remote: Compressing objects: 100% (413/413), done.
remote: Total 1620 (delta 36), reused 43 (delta 28), pack-reused 1178
Receiving objects: 100% (1620/1620), 72.12 MiB | 20.40 MiB/s, done.
Resolving deltas: 100% (230/230), done.
Updating files: 100% (1746/1746), done.
Filtering content: 100% (6/6), 82.08 MiB | 47.35 MiB/s, done.
Submodule 'body' (https://github.com/commaai/body.git) registered for path 'body'
Submodule 'cereal' (https://github.com/commaai/cereal.git) registered for path 'cereal'
Submodule 'laika_repo' (https://github.com/commaai/laika.git) registered for path 'laika_repo'
Submodule 'opendbc' (https://github.com/commaai/opendbc.git) registered for path 'opendbc'
Submodule 'panda' (https://github.com/commaai/panda.git) registered for path 'panda'
Submodule 'rednose_repo' (https://github.com/commaai/rednose.git) registered for path 'rednose_repo'
Submodule 'tinygrad' (https://github.com/geohot/tinygrad.git) registered for path 'tinygrad_repo'
Cloning into '/tmp/openpilot/body'...
remote: Enumerating objects: 301, done.
remote: Counting objects: 100% (167/167), done.
remote: Compressing objects: 100% (71/71), done.
remote: Total 301 (delta 110), reused 123 (delta 94), pack-reused 134
Receiving objects: 100% (301/301), 44.03 KiB | 1.38 MiB/s, done.
Resolving deltas: 100% (182/182), done.
Cloning into '/tmp/openpilot/cereal'...
remote: Enumerating objects: 2224, done.
remote: Counting objects: 100% (301/301), done.
remote: Compressing objects: 100% (153/153), done.
remote: Total 2224 (delta 157), reused 277 (delta 141), pack-reused 1923
Receiving objects: 100% (2224/2224), 430.02 KiB | 2.81 MiB/s, done.
Resolving deltas: 100% (1173/1173), done.
Cloning into '/tmp/openpilot/laika_repo'...
remote: Enumerating objects: 1080, done.
remote: Counting objects: 100% (220/220), done.
remote: Compressing objects: 100% (99/99), done.
remote: Total 1080 (delta 164), reused 144 (delta 115), pack-reused 860
Receiving objects: 100% (1080/1080), 175.41 KiB | 2.28 MiB/s, done.
Resolving deltas: 100% (635/635), done.
Cloning into '/tmp/openpilot/opendbc'...
remote: Enumerating objects: 3507, done.
remote: Counting objects: 100% (1448/1448), done.
remote: Compressing objects: 100% (87/87), done.
remote: Total 3507 (delta 1398), reused 1376 (delta 1361), pack-reused 2059
Receiving objects: 100% (3507/3507), 822.68 KiB | 4.52 MiB/s, done.
Resolving deltas: 100% (2064/2064), done.
Cloning into '/tmp/openpilot/panda'...
remote: Enumerating objects: 11884, done.
remote: Counting objects: 100% (80/80), done.
remote: Compressing objects: 100% (44/44), done.
remote: Total 11884 (delta 57), reused 51 (delta 36), pack-reused 11804
Receiving objects: 100% (11884/11884), 1.78 MiB | 8.34 MiB/s, done.
Resolving deltas: 100% (8194/8194), done.
Cloning into '/tmp/openpilot/rednose_repo'...
remote: Enumerating objects: 216, done.
remote: Counting objects: 100% (95/95), done.
remote: Compressing objects: 100% (48/48), done.
remote: Total 216 (delta 70), reused 61 (delta 47), pack-reused 121
Receiving objects: 100% (216/216), 34.40 KiB | 1.07 MiB/s, done.
Resolving deltas: 100% (94/94), done.
Cloning into '/tmp/openpilot/tinygrad_repo'...
remote: Enumerating objects: 10209, done.
remote: Counting objects: 100% (10209/10209), done.
remote: Compressing objects: 100% (3677/3677), done.
remote: Total 10209 (delta 6194), reused 10177 (delta 6176), pack-reused 0
Receiving objects: 100% (10209/10209), 1.37 MiB | 7.02 MiB/s, done.
Resolving deltas: 100% (6194/6194), done.
remote: Enumerating objects: 277, done.
remote: Counting objects: 100% (35/35), done.
remote: Compressing objects: 100% (33/33), done.
remote: Total 277 (delta 2), reused 14 (delta 0), pack-reused 242
Receiving objects: 100% (277/277), 1.81 MiB | 7.55 MiB/s, done.
Resolving deltas: 100% (44/44), done.
Submodule path 'body': checked out '396fa7b923099640d6843f338950ed41300793ec'
remote: Enumerating objects: 71, done.
remote: Counting objects: 100% (54/54), done.
remote: Compressing objects: 100% (54/54), done.
remote: Total 71 (delta 0), reused 10 (delta 0), pack-reused 17
Receiving objects: 100% (71/71), 79.88 KiB | 1.86 MiB/s, done.
Resolving deltas: 100% (1/1), done.
Submodule path 'cereal': checked out '2077dd1a1b0054713102aee8197434f8cfa07de7'
remote: Enumerating objects: 73, done.
remote: Counting objects: 100% (50/50), done.
remote: Compressing objects: 100% (50/50), done.
remote: Total 73 (delta 0), reused 11 (delta 0), pack-reused 23
Receiving objects: 100% (73/73), 4.93 MiB | 18.84 MiB/s, done.
Resolving deltas: 100% (5/5), done.
Submodule path 'laika_repo': checked out 'ef21c612f4b0d68c790b4b1a6d637cd5fce7732e'
remote: Enumerating objects: 167, done.
remote: Counting objects: 100% (140/140), done.
remote: Compressing objects: 100% (102/102), done.
remote: Total 167 (delta 58), reused 38 (delta 37), pack-reused 27
Receiving objects: 100% (167/167), 499.24 KiB | 2.84 MiB/s, done.
Resolving deltas: 100% (60/60), done.
Submodule path 'opendbc': checked out 'a1582f5e28fe0df23b6821c907188be477aac11c'
remote: Enumerating objects: 452, done.
remote: Counting objects: 100% (284/284), done.
remote: Compressing objects: 100% (269/269), done.
remote: Total 452 (delta 45), reused 16 (delta 15), pack-reused 168
Receiving objects: 100% (452/452), 4.82 MiB | 17.39 MiB/s, done.
Resolving deltas: 100% (67/67), done.
Submodule path 'panda': checked out '1f475a8affc5270227af18e9c418b5fcd12575b9'
remote: Enumerating objects: 38, done.
remote: Counting objects: 100% (28/28), done.
remote: Compressing objects: 100% (28/28), done.
remote: Total 38 (delta 1), reused 7 (delta 0), pack-reused 10
Receiving objects: 100% (38/38), 358.76 KiB | 1.87 MiB/s, done.
Resolving deltas: 100% (1/1), done.
Submodule path 'rednose_repo': checked out '22f02dd650361e091f09f1ae94c5c96a9419c2d4'
remote: Enumerating objects: 211, done.
remote: Counting objects: 100% (211/211), done.
remote: Compressing objects: 100% (187/187), done.
remote: Total 211 (delta 24), reused 96 (delta 13), pack-reused 0
Receiving objects: 100% (211/211), 14.24 MiB | 12.68 MiB/s, done.
Resolving deltas: 100% (24/24), done.
Submodule path 'tinygrad_repo': checked out 'd8dda2af3afcef0bb772fff580cfa8b3eabf7f69'

real    0m20.032s
user    0m5.618s
sys     0m2.584s

$ du -sh openpilot/
535M    openpilot/

merge?

We can't merge this as the default for the reason above.

 batman@workstation-harald:~$ time git clone --filter=blob:none --recurse-submodules https://github.com/commaai/openpilot.git
Cloning into 'openpilot'...
remote: Enumerating objects: 64153, done.
remote: Counting objects: 100% (65/65), done.
remote: Compressing objects: 100% (56/56), done.
remote: Total 64153 (delta 21), reused 44 (delta 9), pack-reused 64088
Receiving objects: 100% (64153/64153), 13.84 MiB | 19.04 MiB/s, done.
Resolving deltas: 100% (41163/41163), done.
remote: Enumerating objects: 1622, done.
remote: Counting objects: 100% (455/455), done.
remote: Compressing objects: 100% (418/418), done.
remote: Total 1622 (delta 46), reused 41 (delta 36), pack-reused 1167
Receiving objects: 100% (1622/1622), 72.12 MiB | 17.77 MiB/s, done.
Resolving deltas: 100% (236/236), done.
Updating files: 100% (1748/1748), done.
Filtering content: 100% (6/6), 82.08 MiB | 59.91 MiB/s, done.
Submodule 'body' (https://github.com/commaai/body.git) registered for path 'body'
Submodule 'cereal' (https://github.com/commaai/cereal.git) registered for path 'cereal'
Submodule 'laika_repo' (https://github.com/commaai/laika.git) registered for path 'laika_repo'
Submodule 'opendbc' (https://github.com/commaai/opendbc.git) registered for path 'opendbc'
Submodule 'panda' (https://github.com/commaai/panda.git) registered for path 'panda'
Submodule 'rednose_repo' (https://github.com/commaai/rednose.git) registered for path 'rednose_repo'
Submodule 'tinygrad' (https://github.com/geohot/tinygrad.git) registered for path 'tinygrad_repo'
Cloning into '/home/batman/openpilot/body'...
remote: Enumerating objects: 776, done.
remote: Counting objects: 100% (223/223), done.
remote: Compressing objects: 100% (96/96), done.
remote: Total 776 (delta 138), reused 175 (delta 121), pack-reused 553
Receiving objects: 100% (776/776), 1.93 MiB | 7.41 MiB/s, done.
Resolving deltas: 100% (400/400), done.
Cloning into '/home/batman/openpilot/cereal'...
remote: Enumerating objects: 3603, done.
remote: Counting objects: 100% (491/491), done.
remote: Compressing objects: 100% (229/229), done.
remote: Total 3603 (delta 304), reused 409 (delta 255), pack-reused 3112
Receiving objects: 100% (3603/3603), 1.03 MiB | 6.98 MiB/s, done.
Resolving deltas: 100% (2377/2377), done.
Cloning into '/home/batman/openpilot/laika_repo'...
remote: Enumerating objects: 1722, done.
remote: Counting objects: 100% (472/472), done.
remote: Compressing objects: 100% (191/191), done.
remote: Total 1722 (delta 360), reused 322 (delta 275), pack-reused 1250
Receiving objects: 100% (1722/1722), 10.47 MiB | 24.37 MiB/s, done.
Resolving deltas: 100% (1140/1140), done.
Cloning into '/home/batman/openpilot/opendbc'...
remote: Enumerating objects: 7944, done.
remote: Counting objects: 100% (5364/5364), done.
remote: Compressing objects: 100% (229/229), done.
remote: Total 7944 (delta 5217), reused 5156 (delta 5134), pack-reused 2580
Receiving objects: 100% (7944/7944), 2.62 MiB | 14.07 MiB/s, done.
Resolving deltas: 100% (6317/6317), done.
Cloning into '/home/batman/openpilot/panda'...
remote: Enumerating objects: 19791, done.
remote: Counting objects: 100% (145/145), done.
remote: Compressing objects: 100% (65/65), done.
remote: Total 19791 (delta 97), reused 115 (delta 80), pack-reused 19646
Receiving objects: 100% (19791/19791), 10.11 MiB | 34.61 MiB/s, done.
Resolving deltas: 100% (15087/15087), done.
Cloning into '/home/batman/openpilot/rednose_repo'...
remote: Enumerating objects: 375, done.
remote: Counting objects: 100% (190/190), done.
remote: Compressing objects: 100% (92/92), done.
remote: Total 375 (delta 143), reused 122 (delta 98), pack-reused 185
Receiving objects: 100% (375/375), 413.69 KiB | 2.78 MiB/s, done.
Resolving deltas: 100% (205/205), done.
Cloning into '/home/batman/openpilot/tinygrad_repo'...
remote: Enumerating objects: 16396, done.
remote: Counting objects: 100% (1165/1165), done.
remote: Compressing objects: 100% (175/175), done.
remote: Total 16396 (delta 1063), reused 1013 (delta 988), pack-reused 15231
Receiving objects: 100% (16396/16396), 18.97 MiB | 29.98 MiB/s, done.
Resolving deltas: 100% (11658/11658), done.
Submodule path 'body': checked out '396fa7b923099640d6843f338950ed41300793ec'
Submodule path 'cereal': checked out '1ee48e0110a46fbdd9db50ed89a38bb5a748cfcb'
Submodule path 'laika_repo': checked out 'ef21c612f4b0d68c790b4b1a6d637cd5fce7732e'
Submodule path 'opendbc': checked out 'a1582f5e28fe0df23b6821c907188be477aac11c'
Submodule path 'panda': checked out 'aed103d5372d1e5b3fb686d2aa8f111081b37fd0'
Submodule path 'rednose_repo': checked out '22f02dd650361e091f09f1ae94c5c96a9419c2d4'
Submodule path 'tinygrad_repo': checked out 'd8dda2af3afcef0bb772fff580cfa8b3eabf7f69'
real    0m17.467s
user    0m4.473s
sys     0m1.482s
batman@workstation-harald:~$ du -sh openpilot/
549M    openpilot/
`


Fama-French alpha beta

Adds Fama-French benchmark to alpha and beta plots in Bayesian tear sheet.
Not currently functional.  Line 106:
start = pm.find_MAP(fmin=sp.optimize.fmin_powell)
fails with the following TypeError:
TypeError: Ambiguous name: beta - please check the names of the inputs of your function for duplicates.
I might need some help to debug this one.

Fama-French model can be used as a benchmark for alpha beta plots in the Bayesian tear sheet.  I think this code is ready to be implemented on quantopian:master.

Looks great @sbussmann (but see minor comments). The main issue are the git problems so you might have to start from a fresh master with this.

I brought this branch up to date with quantopian:master and addressed the minor comments.  Hope it's in good shape now!

Closing in favor of https://github.com/quantopian/pyfolio/pull/200.


#620 create market

This PR includes all tests related to market input validation + creation.

Coverage increased (+5.0%) to 73.635% when pulling 832190cb3bc9fd8d7137640e9f9122800fc06c16 on #620-create-market into 27f6a4a0213cb047a6e84962856887cfea9376b1 on master.


docs: design of apisix ingress-controller  is not included in the sidebar

Actual Behaviour
https://apisix.apache.org/docs/ingress-controller/design

#321

@KishaniKandasamy Thanks for your report!


Launch error with "Vysor binary was not found at" on Windows with Vysor 4.1.77 installed

I have been installed Vysor-win-4.1.77 before use vysor-cli.
Got "Vysor binary was not found at C:\Users\Admin\Local\Vysor\Vysor.exe" error.
The vysor binary on my PC (Windows 10) is located on C:\Users\Admin\AppData\Local\vysor\Vysor.exe.
Also I have look at the code on vysor-cli's cli.ts, I try to launch Vysor with Vysor.exe --args -s DEVICE_SN, but vysor still start normally. I except that could be launch vysor screen with the device connected.

Same problem here. It's looking at the wrong path, it's missing AppData.
I created a symbolic link from C:\Users\User\Local\Vysor to C:\Users\User\AppData\Local\Vysor and it now launched the main screen, but using vysor --s DEVICE_SN it just launches the main Vysor screen.

Oddly enough, if I type vywsor -d it launches the remote control screen to my Android.

I created a PR that fixes the path here:
https://github.com/koush/vysor-cli/pull/2

Resolved and published thank you

😊 thank you

Hello,
Just noticed that the npm package is still pointing to the wrong folder location.
Installed using
npm -g install vysor

As you can see, it's missing the username here.


Fixed: Cannot run register.sh in CloudShell

I thought it would be straightforward and a good fit to run register.sh in AWS CloudShell but it was not; it was complaining about default region.
I tried setting AWS_DEFAULT_REGION but this did not work...
I dug into register.sh and made the region detection more robust, working from CloudShell (no environment var needed) and also tested on my local CLI, and made a PR:
https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-awsutilities-commandrunner/pull/53

Done! Thank you @gitshawn


Suggested edit if - else statement in ServiceRouteUtil class

Motivation:
Because I think final keyword is unnecessary at routingStatus variable, i remove final keyword and refactoring if - else statement.
// exisiting code
final RoutingStatus routingStatus;
     if (headers.method() == HttpMethod.OPTIONS) {
          if (isCorsPreflightRequest(headers)) {
              routingStatus = RoutingStatus.CORS_PREFLIGHT;
          } else if ("*".equals(originalPath)) {
              routingStatus = RoutingStatus.OPTIONS;
          } else {
              routingStatus = RoutingStatus.OK;
          }
    } else {
      routingStatus = RoutingStatus.OK;
 }

After the routingstatus variable has been assigned a value
 return DefaultRoutingContext.of(serverConfig.findVirtualHost(hostname, port),
                                        hostname, reqTarget, headers, routingStatus, sessionProtocol);

static RoutingContext of(VirtualHost virtualHost, String hostname, RequestTarget reqTarget,
                             RequestHeaders headers, RoutingStatus routingStatus,
                             SessionProtocol sessionProtocol) {
        return new DefaultRoutingContext(virtualHost, hostname, headers, reqTarget, routingStatus,
                                         sessionProtocol);
}

DefaultRoutingContext(VirtualHost virtualHost, String hostname, RequestHeaders headers,
                          RequestTarget reqTarget, RoutingStatus routingStatus,
                          SessionProtocol sessionProtocol) {
        this.virtualHost = requireNonNull(virtualHost, "virtualHost");
        this.hostname = requireNonNull(hostname, "hostname");
        this.headers = requireNonNull(headers, "headers");
        this.reqTarget = requireNonNull(reqTarget, "reqTarget");
        this.routingStatus = routingStatus;
        this.sessionProtocol = sessionProtocol;
        method = headers.method();
        contentType = headers.contentType();
        acceptTypes = headers.accept();
        hashCode = hashCode(this);
}

private final RoutingStatus routingStatus;

I could see that after passing through the above code, the final variable with 'final' appended is being assigned the value of routingstatus.
So I think that.
If there are any inaccuracies in my suggested, please feel free to point them out. Thank you.
Modifications:

Edit the if - else statement in ServiceRouteUtil class

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Because I think final keyword is unnecessary at routingStatus variable, i remove final keyword and refactoring if - else statement.

As it stands, I agree functionally there is no difference between the status quo and the suggested patch.
However, I think the final keyword provides value by guaranteeing that routingStatus is immutable.
I'm thinking it's probably better to leave as-is unless I'm missing anything.
Perhaps you would like to take a look at the good first issues if you're looking for contribution opportunities?

Thanks, I think i was wrong

+1 for leaving as-is since we prefer final whenever possible.


What is meant by "Just put all these files in your ESPHome folder"?

This is probably a silly question but despite 20 years experience in software development , what is meant by "Just put all these files in your ESPHome folder"?  Because if I check out the code of this repo, then copy in all the files from the original project, then surely the files which have the same name will get overwritten and it will simply be running the original code?  Am I being stupid? :)
How should you merge the source folders so this extension still works? I feel like there's a step missing from the instructions or something?

No need to overwrite anything, or merge, or even use the original files, everything you need is already contained in this project.

But there is no .ino file in this project so how to you build it?   Sorry if I'm asking stupid questions but I'm totally new to Arduino.

Um... This isn't exactly Arduino, you know, this project is specifically created for a certain hardware (basically, for the ESP8266-based board, D1 mini), and is adapted to be used in Home Assistant by either uploading it via the add-on, or via "esphome run".
In other words, you don't need an .ino file, the main module is the .yaml file — quite unlike Arduino projects.

Thanks and sorry for my misunderstanding :)  I have a D1 mini but couldn't see how to upload raw code to a device once I'd flashed it to the D1.  So, so far I have the Esphome module added to Home Assistant and ESPHome running on the D1 so I'll have another look when I have more time.

That's the ESP's own web-interface, you don't really need it for now.
First of all, you need to either have ESPHome installed on your PC, or have it as an add-on in Home Assistant (I assume that you do have Home Assistant, as otherwise you don't need this project).
In case of add-on, you can use its UI to compile the code and upload it using a USB cable right from your browser. You can get the same UI with a local install by running "esphome dashboard" — alternatively, with local installs you can use "esphome run" to build and upload the code.

Would it work to instead of using the "includes" option to use this as an "external_component" as well? I would like to keep this in a distinct folder within esphome or even point here to the repo through the external component option to ensure the latest version is always being used. Would this work?

In which folder ?

Next to the airco-woonkamer.yaml should work.
My listing:
/config/esphome/mhi_ac_ctrl.h
/config/esphome/MHI-AC-CTRL-core.cpp
/config/esphome/mhi-my-ac.-config.yml

Hey, I'm currently using the project what this was based on and recently got into ESPHome. Am I correct that rather than copy pasting the files I should be able to use external components for this ?
That might also make it easier to describe, as you can provide just the yaml to copy-paste, without any further instructions

I believe using external components is only possible if the MHI-AC-Ctrl project starts putting source files in a components dir.

I believe using external components is only possible if the MHI-AC-Ctrl project starts putting source files in a components dir.

I've checked it out, and it seems a bit more complex than that, It'll also need like an __init__.py and other files to make it work properly.
It seems that inspiration could be taken from other climate platforms in ESPHome in order to make one for MHI AC Ctrl

I'll convert it into a custom component installable through github somewhere this weekend.

@synegic , did you manage to get it working? Or did you hit some roadblocks? I tried to do it myself but I'm not versed enough in ESPHome/C to make anything happen

@MidasLamb I haven't had time to properly look at it yet. But I am still intending to. I'll also directly address #51.

I have done much of why you're talking about locally (having it work as an external module with python config). But i haven't had the time to clean it up and document it and won't for at least a month. I'll try and push what I have soon though and link it here and maybe it helps a little. I just updated it to the 2.6 and it's nice to have the auto fan mode working!

Well it's a mess, but I've made it into a git repo
https://github.com/tfyoung/esphome-MHIHeatPump
It's working for me, with the new fan control stuff, but there's a lot of debug code and things missing.

I want to place a comment for the implementers of this project to HA to solve the same problem as OP;

Download this project as a zip and unzip.
Go to file editor in HA, search for the ESPhome folder. Upload [MHI-AC-Ctrl-core.h}, [mhi_ac_ctrl.h]and the [MHI-AC-Ctrl-core.h]. Restart HA
Connect a new ESP to your computer and run the new device install in ESPhome
When the ESP is online in the ESP dash, go to edit copy the code of [lr_mhi_ac_ctrl.yaml] and overwrite the current ESP yaml code.
Name your ESP without underscores and capitals (rule 3,5 and 8). Update your wifi credentials
Save. Install by following the wired install steps (download .bin, and upload by espHomeweb)
Restart HA, it should find the new installed ESP. Do not adopt this ESP in HA before the above steps.

This is probably a silly question but despite 20 years experience in software development , what is meant by "Just put all these files in your ESPHome folder"? Because if I check out the code of this repo, then copy in all the files from the original project, then surely the files which have the same name will get overwritten and it will simply be running the original code? Am I being stupid? :)
How should you merge the source folders so this extension still works? I feel like there's a step missing from the instructions or something?

Did you get it to work? If so, how?

Does this make it easier: https://github.com/RobertJansen1/MHI-AC-Ctrl-ESPHome/blob/TerminatorNL-master/README.md#Installation


People profile sheet for blog authors

We want to manage the blog authors via some Google Sheet. Blog posts will only store a reference to the author. Author details (images, job title, description) should be loaded dynamically.

[x] setup & publish the people profile sheet

@mhaack all that is left here is to populate the sheet with the blog authors.

Assigned to @jonatan-lledo-netcentric who will provide an export containing all the authors.

Closed with #95

Author profiles are available via https://main--netcentric--hlxsites.hlx.live/profiles/query-index.json

Author profiles are available via https://main--netcentric--hlxsites.hlx.live/profiles/query-index.json


enable pluralize spec

I'm enabling the pluralize test, which had an error :)
Please review @carlosvillu @davecarter @vincepal

:+1:

:+1:


How to generate the accept_user_invitation_url

Hello,
I need the link accept_user_invitation_url. Any ideas how can I do that?
I can't find how to get the raw_invitation_token to generate the link.
Thanks.

In the email view, you can use @resource.raw_invitation_token or @token, they are the same
If you are loading the resource from db, you don't have raw token anymore, that's the point of the raw token, don't save it and save encrypted one to db. Probably the only way is generate new token, then you can use raw_invitation_token method


Rework Lint/RedundantSafeNavigation to be more safe

Closes #8867
Closes #8868
I reworked this to make an offense only when used inside conditions and only for whitelisted methods.
cc @bbatsov @marcandre @natematykiewicz

Good points 👍 Removed nil? and marked as unsafe.

Great. Would it be difficult to exclude foo&.respond_to?(:to_a) and others, when the argument is a literal symbol corresponding to one of the few methods that NilClass defines that may not be defined on other objects?

Updated with suggestion.
This surely was easy, I just was lazy 😄

@marcandre Thank you for all reviews 💪
Updated with your suggestions.

Updated with suggestions. Let me know if there is anything else I can improve.

Thanks!


Occasional stalls on "Finding nearby sensors"

I haven't been able to reliably make this happen to debug this, but I have seen this happen to me a few times where it just stalls out on "Finding nearby sensors" and never progresses. Clearing the cache and reloading does nothing.

😒 This just happened to me and it seemed to be me hitting the API limit.

Closing in favor of https://github.com/skalnik/aqi-wtf/issues/30


Group targets into subdirectories of the Xcode project

Hi - reading through the project spec, I don't see a way to group project level targets. I'd like to achieve the following:

Project
-> Apps
---- App1
---- App2
-> App Extensions
---- AppExtension1
---- AppExtension2

Is there any way to accomplish this with XcodeGen?

Hi
There is an option createIntermediateGroups which makes the structure of groups not so flat. I am not sure is it an answer for your question, but you can find explanation for this flag in documentation


OCIO development process documentation feedback

A new document PROCESS.md was recently added to the repository documenting project practices around proposing changes to the core library and how small and large changes are approved before being merged into the codebase.
This document was raised for discussion at three OCIO TSC meetings and was available for reivew in the original pull request ( #1140 ), but in an effort to have wider community engagement I'm opening this issue to invite additional feedback from anyone with interest or opinion on what was documented. This is important because it defines how the project operates and what checks and balances are in place to guard to code. This document was made in response to issue ( #1124 ) for those not following the original discussion.
Please chime in if you have comments, and any feedback will be discussed in this issue and in a future TSC meeting (which all are welcome to attend) to determine if any further edits are necessary. If there is no additional feedback after two weeks we will close this issue and keep the document in its current state.
Thanks all.

To go back to https://github.com/AcademySoftwareFoundation/OpenColorIO/pull/1158#issuecomment-701745081 and my OP here https://github.com/AcademySoftwareFoundation/OpenColorIO/pull/1140#issuecomment-701159344

The sections @KelSolaar flagged are present in CONTRIBUTING.md even with this reverted, so the policy is present in either case.

Should this be made explicit in the PROCESS.md document?

So to reiterate your point from #1140 @KelSolaar , you are suggesting that we should not allow two affiliated approvals ((i.e. from two developers from the same company) in the two week PR review clause, correct? And to restate your argument, which is a fair point:

Isn't this still empowering a group of affiliated people to steer the project where they want? It is Christmas break, Michael is taking some holidays, and we get a raytracer in OCIO at New Year's Eve, because, well nobody really looked at the project... :) I think that Core changes should not have an escape door.

I don't really have a dog in this fight, but it seems to me that no matter what hooliganism occurs over Christmas break, on January 2nd anybody in the community can say, "whoa, that commit from last week was a hot mess, let's revert it and take some time to rethink this feature."  It would only be a real problem if it happened immediately prior to a release, allowing the bad ideas to escape into the wild and have to be supported. But you can fix that by deciding that there should be a design/feature freeze for a few weeks before major release and give extra scrutiny during that period to any last-minute changes and also to allow any iffy ideas from the past to get edited while there's still time.

All of this sounds quite reasonable to me. Informative and well written.

Isn't this still empowering a group of affiliated people to steer the project where they want?

I definitely haven't given this nearly as much thought as others have, and I may be failing to imagine problematic scenarios... but in my mind, provided the group isn't disproportionately represented in the TSC, and contributors are communicative and responsive to feedback / questions / suggestions communicated in GitHub... if the alternative is PR approval limbo and crickets, I'm not sure I have a problem with empowering a group of affiliated people to drive the project. I feel like there are sufficient precautions in place to keep OCIO from being hijacked anywhere it wasn't roughly headed toward already. And like Larry says, we can always make u-turns (although it's helpful not to land first). This has not been my finest metaphor.
On the same token, if there's controversy surrounding a proposed feature, ideally, those concerned or affected would summarize / argue cases for or against publicly on GitHub. If all it takes is an active objection to keep a PR from being automatically merged after two weeks, then I'd imagine the PR would be held off until a consensus is reached. Maybe I'm wrong.
I don't want to disincentivize or frustrate well-communicated, non-breaking efforts towards TSC-kosher contributions (from anyone); and I do want to encourage and reward constructive feedback and open discussion. I think the process guidelines reinforces productive, prosocial behavior while limiting (although not eliminating) the risk of... (puts on eyepatch)... corporate mutiny.
Also, this wasn't clear to me -- do I have the ability to give grey-star "approvals"? I like that idea. There are times I've inspected PRs to grok what's going on; and although it wouldn't be appropriate for me to give bona-fide code reviews for a language I barely have experience with, I would like to communicate my approval of general ideas / mechanisms / apparent implementations without having to type stuff.

I don't really have a dog in this fight, but it seems to me that no matter what hooliganism occurs over Christmas break, on January 2nd anybody in the community can say, "whoa, that commit from last week was a hot mess, let's revert it and take some time to rethink this feature."

I don't disagree but at this stage, the community is tiny and depending on its availability, it might take a while to realise that stuff happened. It relates to what Mark (@Shootfast) was saying at the last TSC, depending on your workload, you might simply not have time to check OCIO development as much as you would want but still, it is a critical piece in your work. I actually write that on a Sunday at 10pm because it is the only time I found this week to look back at what happened.

But you can fix that by deciding that there should be a design/feature freeze for a few weeks before major release and give extra scrutiny during that period to any last-minute changes and also to allow any iffy ideas from the past to get edited while there's still time.

That would work well for OIIO where you have a quite regular release cadence but OCIO is at orders of magnitude slower pace.

OCIO v2 is years in the making. It seems like it would be easy, barely a blip in the schedule, to say that the last 6 weeks before declaring it final is a design and feature freeze -- no new ideas or unvetted features -- with the only changes to be bug fixes, completion of promised features that are documented/speced out but not fully implemented, and corrective responses to any community concerns about the design.

Agreed but at some point people might have started to build around the new features in their software and it could be challenging to ask for any change, case in point some discussions around some of CLF operators, e.g. Range, faced a lot of resistance to make any changes.

@zachlewis you are definitely encouraged to give approvals for any review you do, yes. All feedback and opinions are valued.

Thanks for the input all, including in last week's TSC meeting. Sounds like we can add some policy around feature freezes, and also consider future revisions to the approval policy after OCIO v2 releases, under the intent that with a reduction in the cadence of major changes to the library there is likely more time and cycles from the community and committers for in-depth review, so hopefully less need for an escape hatch. I'll work on some revisions in the coming weeks and submit another PR, referencing it here for further open discussion.


Plugin seems to break test.state property in cy.state('runnable') of a test suite

When a test fails and is retried, that test's details in the cy.state('runnable') object is somehow broken.  From an example I have here, I can see in the cypress logger that my test has failed:

However the cy.state('runnable') output on that test considers it 'passed':

This is throwing off a plugin I use to report test results.  Any information you have on this issue would be helpful.

@proCrichard could you mention what plugin you are using?

I wrote a custom plugin to send test results to datadog.
Starts with an after hook:
after(() => {
  const findTests = suite => {
    suite.tests.forEach(test => {
      cy.task('logTestResults', {
        title: `${test.parent.title}${test.title}`,
        state: test.state,
      });
    });

    if (suite.suites.length < 1) {
      return;
    }
    suite.suites.forEach(nestedSuite => {
      findTests(nestedSuite);
    });
  };

  cy.state('runnable').parent.suites.forEach(suite => {
    findTests(suite);
  });
});

Which triggers this event listener:
const dogapi = require('dogapi');
const changeCase = require('change-case');

module.exports = (on, app) => {
  const dogapiOptions = {
    api_key: process.env.DATADOG_API_KEY,
    app_key: process.env.DATADOG_APP_KEY,
  };
  dogapi.initialize(dogapiOptions);

  on('task', {
    logTestResults({ title, state }) {
      const tags = [];

//This if statement is to catch state=undefined which is sent from tests that failed and were retried.
      if (!state) {
        state = 'failed';
      }

      tags.push(`outcome:${state}`);
      tags.push(`description:${changeCase.snakeCase(title)}`);
      tags.push(`app:${app}`);
      dogapi.metric.send(`app.e2e`, 1, { tags }, (error, results) => {
        console.dir(results); // eslint-disable-line no-console
      });
      return null;
    },
  });
};

did your test that failed (but had state: passed) fail from a beforeEach hook or in the test body?
What retry number do you have enabled?

Retries set to 2
I had the same outcome when I forced a test to fail in:

before() hook
beforeEach()
test body

@proCrichard alright, and what version of cypress and this plugin?
I just added your after() to my spec for this project, and I am getting the correct state set on the runnables

"cypress-plugin-retries": "1.2.2"```

@proCrichard ok, I think I am reproducing it now. Thanks

Ok great. I appreciate you jumping on this for me.

@proCrichard after spending a couple hours on this, I'll need to edit the Cypress source directly to fix this, but I have a PR to do so here https://github.com/cypress-io/cypress/pull/3968
I would recommend using the module API to pull results out instead of using runnable instances. https://docs.cypress.io/guides/guides/module-api.html#cypress-run. However, I know that can be cumbersome


Aptly should read control field names case-insensitively when adding packages to repo

Experimenting with Aptly I noticed that adding some of the packages our developers build in-house doesn't work quite as it should. When running aptly repo add myrepo somedeb_1.0.0-*_all.deb I would get the following output:
$ aptly repo add myrepo somedeb_1.0.0-*_all.deb
Loading packages...
[+] _1.0.0-1_all added
[+] _1.0.0-2_all added
[+] _1.0.0-3_all added
[+] _1.0.0-4_all added

Apparently Aptly doesn't recognise the package names. Looking at the package's control file it see this:
$ dpkg --info somedeb_1.0.0-1_all.deb
 new debian package, version 2.0.
 size 28236694 bytes: control archive= 4592 bytes.
     201 bytes,     7 lines      control
   11991 bytes,   127 lines      md5sums
     346 bytes,    12 lines   *  postinst             #!/bin/bash
 package: somedeb
 Version: 1.0.0-1
 Section: java
 priority: optional
 Architecture: all
 Maintainer: Our Devs<EMAIL_ADDRESS> Description: Some Debian package

The problem seems to be that the field containing the package name isn't read by Aptly because it is package and not Package in the control file (note the wrong case). Same goes for the priority field (priority vs Priority).
The Debian policy says this about case-sensitivity of field names:

Field names are not case-sensitive, but it is usual to capitalize the field names using mixed case as shown below. Field values are case-sensitive unless the description of the field says otherwise.

So obviously we should fix our package creation scripts to adhere to the convention of capitalising field names.
But I also think Aptly should read field names case-insensitively, to avoid such problems.
Apart from that I like Aptly very much so far, thanks for creating it! It is definitely more featureful and performant than Freight (which we currently use and which is also great).

Thanks for reporting that!

Fixed in master, aptly will now complain if package/version/arch is missing. Also field names are case-insensitive now.


Make brod dance with elvis

Description
Introducing elvis to Brod to enforce style checks via Travis. Minor code changes needed to get Elvis to dance with Brod. A few rules or modules are excluded from Elvis since Elvis doesn't like to dance on those songs.
Open question
How do we want to run Elvis on Travis? There's a few options:

Compile Elvis on Travis.
Advantage: Always got a clean Elvis binary built from source
Disadvantage: Time consuming
Build the Elvis escript and include it in the scripts repo. This way the only thing that has to be called from Travis is elvis rock and you'll be good to go.
Advantage: fast. Takes around 2.5 - 3 seconds to run the elvis check
Disadvantage: "untrusted" binary is added to the repo. Updating the elvis binary becomes a possible security issue. Whoever creates a PR to update the binary could potentially sneak in arbitrary code.

Open tasks

[ ] Possibly squash the commits before merging them in since the commits are a tad verbose. (Done on purpose to make reviewing easier).

 Elvis got this covered

commit 15dc3c83716c0c79629e6eb2e54606f45a0e420b
Elvis-fixes: Fix used_ignored_variable

commit 754de4985d2971188bcaf2687898279c8bac5481
Elvis-fixes: Use types when referring to records

commit 70dd752dc18d942eec0dfe0fae008b05f1dd52b1
Elvis-fixes: Include elvis.config

Couple exceptions are made compared to default elvis.config:
- macro_names rule is turned off
- dont_repeat_yourself has increaased min_complexity from 10 -> 15
- brod_group_coordinator and brod_utils are excluded from nesting_level rule
- brod and brod_utils are excluded from god_modules rule
- brod_sock and brod_group_coordinator are excluded from invalid_dynamic_call rule

I vote to compile elvis in travis.

[ ] Do not merge yet. There seems to be a problem with elvis on Travis. Will investigate more later this week. (See example: https://travis-ci.org/onno-vos-dev/brod/jobs/295992948 which should see elvis failing but it doesn't)

@zmstone Fixed your comments and Travis now runs Elvis as well. I'm happy to squash as soon as you're done reviewing. :+1:

very nice. squash please.

btw, i'll take care of version bumping, changelog.md update etc in my on going pr when I rebase on top of this one.
will release in 3.3.0

Thank you! 👍🏻


Release 1.2.6

@rultor release it; the tag is 1.2.6.

@rultor release it; the tag is 1.2.6.

@rafamizes OK, I will release it now. Please check the progress here

@rultor release it; the tag is 1.2.6.

@rafamizes Done! FYI, the full log is here (took me 1min)


[BANDWIDTH_THROTTLING] {DEPENDS-ON PR#2061} Refactor QuotaChargeCallback and its implementations.

Refactor QuotaChargeCallback and its implementations.

Deprecate QuotaChargeCallback methods charge(), check() and quotaExceedAllowed().
Add new methods for checkAndCharge(). The new methods will check if specified conditions are met, and charge the quota accordingly.
Rename RejectingQuotaChargeCallback to PostProcessQuotaChargeCallback. In essence, this implementation of QuotaChargeCallback is used for enforcing quota after a chunk has been processed.

Note that an implementation of PreProcessQuotaChargeCallback will follow. That implementation will be used for enforcing quota for bandwidth throttling case, which will happen before chunks are processed.

Codecov Report

Merging #2069 (0922455) into master (a81aefa) will decrease coverage by 58.28%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master    #2069       +/-   ##
=============================================
- Coverage     73.49%   15.20%   -58.29%
+ Complexity     9954     2285     -7669
=============================================
  Files           718      718
  Lines         54486    54527       +41
  Branches       6731     6739        +8
=============================================
- Hits          40044     8293    -31751
- Misses        12311    45753    +33442
+ Partials       2131      481     -1650

Impacted Files
Coverage Δ

...in/java/com/github/ambry/network/ResponseInfo.java
0.00% <0.00%> (-93.11%)
:arrow_down:

.../com/github/ambry/network/SocketNetworkClient.java
0.00% <0.00%> (-92.86%)
:arrow_down:

...github/ambry/network/http2/Http2NetworkClient.java
0.00% <0.00%> (-67.75%)
:arrow_down:

...ub/ambry/quota/PostProcessQuotaChargeCallback.java
0.00% <0.00%> (ø)

...c/main/java/com/github/ambry/quota/QuotaUtils.java
0.00% <0.00%> (-78.27%)
:arrow_down:

.../github/ambry/router/AdaptiveOperationTracker.java
0.00% <0.00%> (-88.99%)
:arrow_down:

...main/java/com/github/ambry/router/RouterUtils.java
0.00% <0.00%> (-98.47%)
:arrow_down:

...om/github/ambry/router/SimpleOperationTracker.java
0.00% <0.00%> (-94.52%)
:arrow_down:

.../github/ambry/router/TrackedRequestFinalState.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../github/ambry/router/UndeleteOperationTracker.java
0.00% <0.00%> (-97.96%)
:arrow_down:

... and 574 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a81aefa...0922455. Read the comment docs.


Bugfix/username change

Actually checking username length and forcing letter first standard.

Ignore the deployed to heroku- it's not running this branch until the container fix branch gets merged in.


Added Algerian Arabic language.

@claudep Thanks :+1: Can you add release notes?

Sure, it's out of question to merge this in stable, right?

I was thinking about 3.1 :thinking: but I'm fine to backport this to 3.0.1. Are you going to fetch translations before January, 2nd?

I don't always fetch translations for .1 releases, depending on the activity, I sometimes wait for the .2 release. After some thoughts, I think it would be wiser to commit this for 3.1.

@infosrabah @claudep Thanks.


Add support for sign scalar function

Summary of the changes / Why this improves CrateDB
Closes #15641
Added sign(numeric) scalar function. The function will return one of the following:
- If number > 0, it returns 1
- If number = 0, it returns 0
- If number < 0, it returns -1
- If number is NULL, it returns NULL
Checklist

[ ] Added an entry in the latest docs/appendices/release-notes/<x.y.0>.rst for user facing changes
[ ] Updated documentation & sql_features table for user facing changes
[ ] Touched code is covered by tests
[ ] CLA is signed
[ ] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in the latest docs/appendices/release-notes/<x.y.0>.rst
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

Can one of the admins verify this patch?

You can simply only register double-> double, and numeric->numeric, and the "infrastructure" will take care to apply any implicit casts, so the registration can look like:
public static void register(Functions.Builder builder) {

        builder.add(
            scalar(NAME, DataTypes.NUMERIC.getTypeSignature(), DataTypes.NUMERIC.getTypeSignature())
                .withFeature(Scalar.Feature.NULLABLE),
            (signature, boundSignature) -> {
                DataType<?> argType = boundSignature.argTypes().getFirst();
                return new UnaryScalar<>(
                    signature,
                    boundSignature,
                    argType,
                    x -> BigDecimal.valueOf(Math.signum(((Number) argType.sanitizeValue(x)).longValue()))
                );
            }
        );

        builder.add(
            scalar(NAME, DataTypes.DOUBLE.getTypeSignature(), DataTypes.DOUBLE.getTypeSignature())
                .withFeature(Scalar.Feature.NULLABLE),
            (signature, boundSignature) ->
                new DoubleScalar(signature, boundSignature, Math::signum)
        );
    }

ok to test

@azatyamanaev can I please ask you to sign our CLA?

@azatyamanaev can I please ask you to sign our CLA?
I did it when creating pull request

Thanks again @azatyamanaev for your contribution!


Build error after changing .csproj for .NET core, goes away after git clean -xdf

Repro:

git clone https://github.com/KirillOsenkov/MSBuildStructuredLog
nuget restore
msbuild <-- this is important
Open MSBuildStructuredLog.sln in VS 2017 RC4 (or newer)
Make sure it builds from the IDE (F6)
Unload StructuredLogger project and edit the .csproj
Replace the .csproj contents with this: https://github.com/KirillOsenkov/MSBuildStructuredLog/blob/d3e5742cbc1c7bfc914acaee594aa09b6da92202/src/StructuredLogger/StructuredLogger.csproj
Reload the project
Build (you can even Clean/Rebuild)

Expected: build succeeded
Actual: build error:
Severity	Code	Description	Project	File	Line	Suppression State
Error	CS0579	Duplicate 'System.Reflection.AssemblyTitleAttribute' attribute	StructuredLogger(netstandard1.5)	C:\MSBuildStructuredLog\src\StructuredLogger\obj\Debug\net46\StructuredLogger.AssemblyInfo.cs	18	Active

This is fixed only by BOTH closing VS and doing git clean -xdf.
If you don't close VS and do git clean -xdf, you get 39 errors.
If you close VS and don't git clean -xdf, you still get the 1 error above.

I suspect the assemblyinfo file generated by project.json is called differently from the one generated by the SDK and that causes both files to be around until you do a git clean -xdf?

Does the SDK generate an assembly info file? Where can I find out more about this? I've only seen one file in the repo (in obj) (the other might go to TEMP?)
Also how do I investigate what got passed to Csc? Somehow the log output from inner builds doesn't make it into the logger...

Yes see here - https://github.com/dotnet/sdk/blob/master/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.GenerateAssemblyInfo.targets
I'm not aware of issues with loggers - the inner build is just a msbuild invocation - do the loggers need to passed through specifically?

No, it was a problem on my end. Everything is fine.
So the real problem in this bug is that the error (although legit - since both NerdBank.GitVersioning and the SDK are generating the AssemblyTitle attribute) doesn't go away after I fix it unless I git clean and restart VS.

doesn't go away after I fix it

How are you fixing it? By turning off assembly info generation? Are you saying that when that's turned off the temp file from obj is not getting deleted?

Sorry I got super confused by a similar bug yesterday. Please ignore my comment about NerdBank.GitVersioning.
The repro steps above still seem to constitute a problem though...

This issue was moved to dotnet/sdk#1009


Add missing stream built in type

Coverage remained the same at 100.0% when pulling cc1cdad27b0b9ce8fdd68b6a097274fef55ef5fa on DASPRiD:feature/stream-proxy into 2098c1b4efb335d3eda735d205b7cae6fd6f0242 on soliantconsulting:develop.


error: unknown option `--inspect'

Node.js supports the --inspect flag and the --debug flag (deprecated). However, it seems that MAGE, not recognizing them, simply errors out.
We should try to find a way to make sure that not only collisions are avoided, but also that we accept Node flags as well. cc @ronkorving

Actually, I take this one back. I was doing something wrong - I think.


No branding on downloaded image

It is good if we include something like Generated using Github Wrapped or so.
If people post on social media there is no way to depict from where this image was generated.

Thanks for the idea, Ayush. I've added a link to Wrapped.run at bottom-right. Please let me know if it's hard to read.
Also nice commit numbers 🚀

Looks great now. Thanks for adding the same.
Closing issue


Broken JSON requests

There is something wrong with the #meeting_create method. After trying variations of this over and over -
zoom_client.meeting_create(
      :user_id    => 'me',
      :type       => 2,
      :topic      => "My Test Event",
      :start_time => 1.day.from_now,
      :duration   => 60
    )

I kept getting a Request Body should be a valid JSON object. response.
After tearing my hair out for two hours, I tried the @eclemens fork and it worked fine. Not sure where the issue is, just wanted to note it.

Pushed 207d8e9a6880dbc266842175a876e49a3dc2be02 to resolve this. My bad. I'll leave this open to serve as a reminder to myself to write more thorough end-to-end tests.

Thanks!!!

Thank you for posting. My hope is that  people PR their forks so that we can all work from a relatively complete API wrapper. I have some work time allocated for this in coming weeks so I'll be sure to get things merged as quickly as possible.

Hey, it's the same story with the roles API that was merged a couple of days ago
https://github.com/hintmedia/zoom_rb/pull/22
I will bring the to_json back and create another PR shortly.

I believe user.rb has a similar problem.
It should be "body: params.except(:id).to_json" in user_update. Otherwise I got "Request Body should be a valid JSON object."
I didn't test other methods though.

I believe this has been resolved by the refactoring work done in #392


[Feature] NNBD migration

We have scheduled for migrate to nnbd (non-nullable-by-default) to this package and other relative packages recently, with the roadmap of nnbd in flutter. It's a release blocker so there will be no release version until it's done.

ok

ok


always shown tip

is there a way to make the tip always shown and not dependant of an event or smth ?
Thanks :)

I'm also interested on this feature. @eMerzh Did you manage to do something on your own?

@marco-lobo-jd no, didn't get the time to explore it yet... never say never but if you find smth i'm interested ;-)

I'm interested too. Did anyone find out anything on that?

Shouldn't it work just to call tip.show() manually, instead of in response to an event? You're in complete control of when the tip is shown and hidden.


MongoDB Configuration broken

We are using 5.2.0-RC1 and are experiencing unexpected issues with MongoDB. We are using both the MongoDB Ticket and Service Registry. Configuration of the two as per the documentation seems to imply that these are two different configuration with two distinct data sources. This is not the case! The first datasource generated will win. The reason is that the actual construction of the datasource takes place in the abstract superclass AbstractMongoConfiguration. This superclass creates a MongoTemplate and a MongoRegistryFactory and defines beans with the respective method names.  When called for the second time the call will be intercepted and the object created returned.

Thanks for the logging the issue report. This seems like something that might need fixing. As the next step, please review this guide to get started.
You can also learn how to build and run CAS from here.
Thanks again!


Change Board_ToHash() / Board_FromHash() exchange format

Issue:

current exchange format of Board_ToHash() / Board_FromHash() is a numpy array
numpy array needs to be converted to bytes before it can be written to a file etc.

Suggested Solution:

modify the exchange format from numpy array to Python type 'bytes' or 'bytearray' for better compatibility
therefore use the byte streaming / buffering API of CPython (https://docs.python.org/3/c-api/buffer.html)
test the new exchange format with unit tests

For AI applications it could be more useful to have the board hash as numpy bytes array for feeding it to a neuronal network. Therefore the issue is not relevant at the moment.


Question: Does "privacy.clearOnShutdown.siteSettings = TRUE" clear also local storage?

Just a quicky, since I am curios and if anyone happens to know, before digging into.
Does "privacy.clearOnShutdown.siteSettings = TRUE" clear also local storage?
Thank you
Cheers

I don;t think so. It clears site permissions and things like zoom levels. Storage is a different "container". I could possibly test it, but I have virtually nothing with any local storage, if anything. I don't mind copying my current portable FF and wiping my site settings to test - but I need some local storage - where can I get some?

Hah .. https://www.wolframalpha.com/ creates dom storage elements

Idk if you know JS but if you do here's the code for siteSettings sanitize

I think local storage is cleared with cookies, but I haven't checked recently.

That makes sense francois. I know Cookie Controller clears and handles dom storage and cookies together. It also has context menu items to clear dom storage / cookies separately (indeed, cookies can be handled via the FF ui), so they're not intrinsically (or tragically?) tied to each other.

Just came back. Thank you all


Notify player when game is full (#141)

Show a transient notification when the the game sends a GameFull-Command as requested in #141 .
Following tasks remain open:

show a preview of the game (i.e. preview of current map)
click on notification opens ingame lobby
I added TODOs for these.

Please note the the current GameFull-Implementation of the game is buggy. It does not fire when the last slot is closed. It fires multiple times if the last slot is filled with an AI. Behavior was not tested with human players.
Connect to #141

Coverage decreased (-0.03%) to 54.111% when pulling 9164d6cef7d70cc428f1face43ec9a089db0883a on feature/#141-game-full into e0aba779dc949f34bfbcc4869c2d1c96800c0012 on develop.

Coverage increased (+0.03%) to 54.174% when pulling 79857e29a3c4d3d3a7dac51f5e1908db9bced481 on feature/#141-game-full into e0aba779dc949f34bfbcc4869c2d1c96800c0012 on develop.


feat: Add inputOnly option for exclusive input utilization

This commit adds the inputOnly option to EnvsafeOpts, enabling exclusive use of input values and enhancing typo detection. When inputOnly is set to true, envsafe disregards runtime environment variable references and solely relies on the provided input values.
This improvement ensures better reliability and prevents unnoticed typos in environment variable references that were previously masked by fallback values.

I strongly agree with the opinion that there could be a better name than "inputOnly" for the introduced option.
Closes #146

It seems that they are no loanger needed now, so closed.


[ARO-12458] Remove excess JWT dependency and update the one we do have

Which issue this PR addresses:
Fixes ARO-12458
What this PR does / why we need it:
Removes an excess dependency and updates the one we use.
Test plan for issue:
E2E, unit tests
Is there any documentation that needs to be updated for this PR?
N/A
How do you know this will function as expected in production?
E2E

/azp run


Add doc and httproute example for HTTP request mirroring

Added example HTTPRoute yaml for configuring HTTP request mirroring.

What type of PR is this?
/kind documentation
What this PR does / why we need it:
Added examples for HTTP request mirroring.
Which issue(s) this PR fixes:
Fixes #2833
Does this PR introduce a user-facing change?:
None

/assign @robscott

/approve

/ok-to-test

This LGTM but I'll wait for @robscott or @howardjohn to give the final LGTM.

This LGTM but I'll wait for @robscott or @howardjohn to give the final LGTM.

Thanks for reviewing! I just added the route to the new page in mkdoc.yml and verified that it works via mkdocs serve.

Thanks @sawsa307!
/lgtm


Translate docs/third-party into Korean

/area documentation
/kind content
/kind translation
What would you like to be added:
Translate docs/third-party into Korean
Why is this needed:
No ko doc for docs/third-party

/assign


cannot click any buttons, channels or members after BetterChannelList finished loading and displays the last message from every channel in the server

Plugin:
📜 BetterChannelList
What version of BetterDiscord are you using?
core v1.9.7
What version of the selected plugin(s) are you using (if applicable)?
v1.0.4
What client are you using?
🔵 Stable
Describe the bug
after BetterChannelList finished loading and displays the last message from every channel in the server, I suddenly cannot click any buttons, channels or members anymores
I can open my settings, but after it opens, I once again cannot click any buttons there, including the close button (the escape key also does not work anymore)
Additional comments
No response
I have read and agree to the following:

[X] I have searched existing/closed issues to confirm that this hasn't been solved already.
[X] I've already tried to disable all other plugins (or themes) to confirm this issue is related to the plugin.
This isn't necessarily required

I can't reproduce this issue. Do you have access to the console so you could check if any errors appear?

Closed due to inactivity from author. Re-open if the problem still occurs.


Add the path and the overall score as individual rows

Makes it look a bit nicer when the path is longer.

Thanks!


fix: Respond to preflight request properly when origin evaluated as invalid by custom function

if custom function for origin validation return err or false for preflight request control is passed to the next middleware
that's not the case if origin is defined statically
mentioned in and fixes #241

Sorry everyone, I went back over the docs and for the origin, false to disable CORS. The current behavior is correct in this case, as the preflight behavior is a condition of CORS being enabled. The correct callback response to have CORS enabled but reject the CORS request as denied is actually callback(null, []). Apologies for the confusion as I am not the original author and took over tge module a while back. I relized my error here when I was just looking at tge original commits.

Ok, I see, never mind. Thanks for help!