[NoQA] Use the variable from hook rather then props

A simple follow up to https://github.com/Expensify/App/pull/21312 @WoLewicki because the props.smallScreenWidth has been deprecated since the last commit in the PR and we missed syncing with main
Details

Fixed Issues

$ https://github.com/Expensify/App/issues/20370
Tests

Same tests as in here https://github.com/Expensify/App/pull/21312, we just changing where the value is coming from (not from props)

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Will be QAed with these steps https://github.com/Expensify/App/pull/21312

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos
Tested locally but taking screenshots from the linked PR since the behaviour is same

Web

https://github.com/Expensify/App/assets/32481228/0c3d6f42-d059-4c2c-b727-a07742d724ed
https://github.com/Expensify/App/assets/32481228/5b4f3492-4e0a-4e4d-a4b6-6657278d1133
https://github.com/Expensify/App/assets/32481228/ddcd9fe9-baf1-4615-954d-8cbe20cf1a4c

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.37-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


[VS Code] [Audio] Request startOrJoinCall failed unexpectedly without providing any details.

Error:
Request startOrJoinCall failed unexpectedly without providing any details.
Steps to Reproduce:
1.
2.

Version Data

extensionName
VSLS-Audio

extensionVersion
0.1.91

applicationName
VSCode

applicationVersion
1.61.2

platformName
Windows

platformVersion
10.0.22000

Closing and marking as a duplicate of #4076. This could be caused by a corrupt install, so please try running the command >Live Share: repair audio installation. You can also try uninstalling the Live Share audio extension so you can use Live Share without the audio feature.


facial bone hypoplasia

facial bone hypoplasia
DEF: underdevelopment or reduced size of one or more facial bones, usually due to a reduced number of cells
SYN: hypoplastic facial bone
SYN: hypoplastic facial bones
Children terms include:
frontal bone hypoplasia MP:0004869
hyoid bone hypoplasia MP:0009899
mandible hypoplasia MP:0000460
premaxilla hypoplasia MP:0004871
maxilla hypoplasia MP:0000457
lacrimal bone hypoplasia MP:0030056
nasal bone hypoplasia MP:0000103
palatine bone hypoplasia MP:0004475
vomer bone hypoplasia MP:0009900
zygomatic bone hypoplasia MP:0030112

facial bone hypoplasia MP:0030386


Squid Log integ added

What does this PR do?
Adds new Squid log integration
Motivation
Publish new Squid log integration
Review checklist (to be filled by reviewers)

[x] PR title must be written as a CHANGELOG entry (see why)
[x] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[x] PR must have changelog/ and integration/ labels attached
[ ] Feature or bugfix must have tests
[x] Git history must be clean
[ ] If PR adds a configuration option, it must be added to the configuration file.

@gusai-dd Need rebase

@ofek Rebase on master done, please accept & merge the PR.

@DataDog/agent-integrations
Validated today in Staging environment.
Please proceed with merge and load in Prod.

Hello @FlorianVeaux ,
thanks for the review.
Leading spaces removed.
You can proceed with the merge.
Thanks in advance!


bookworm config --force mysql not working

Hi, I ran bookworm config --force MySQL got following error. Anyone know what's missing?
Some background on this issue: I installed apache, mariaDB, other pre-requisite softwares. Mysql is able to create, drop databases. On Ubuntu server, I called Makefile under BookwormDB-master successfully.
Traceback (most recent call last):
File "/usr/local/bin/bookworm", line 9, in
load_entry_point('bookwormDB==0.4.0', 'console_scripts', 'bookworm')()
File "/usr/local/lib/python2.7/dist-packages/bookwormDB-0.4.0-py2.7.egg/bookwormDB/manager.py", line 567, in run_arguments
getattr(my_bookworm,args.action)(args)
File "/usr/local/lib/python2.7/dist-packages/bookwormDB-0.4.0-py2.7.egg/bookwormDB/manager.py", line 76, in config
bookwormDB.configuration.reconfigure_passwords(args.users,args.force)
File "/usr/local/lib/python2.7/dist-packages/bookwormDB-0.4.0-py2.7.egg/bookwormDB/configuration.py", line 392, in reconfigure_passwords
if not args.force:
UnboundLocalError: local variable 'args' referenced before assignment

Thanks for the commit. The error is raised inside some old code from before the --force option was added, that only arises when the bookworm command is run as the root user. I've [https://github.com/Bookworm-project/BookwormDB/commit/6d393b4863067a36c5f7b48a7255bbc3ed86e143](deleted the relevant lines in the last commit); hopefully this fixes it, but I don't have a test machine set up to run as the root user to check right now, so I'll leave the issue open.

I tested, the "if not args.force:" error is gone! Thank you.
Now a new error pops up, "Access denied for user 'root'@localhost' (using password: NO)")
I thought we need sudo to run the code, it will make me as root. Any suggestion? New trace log is below.
Traceback (most recent call last):
File "/usr/local/bin/bookworm", line 9, in
load_entry_point('bookwormDB==0.4.0', 'console_scripts', 'bookworm')()
File "/usr/local/lib/python2.7/dist-packages/bookwormDB-0.4.0-py2.7.egg/bookwormDB/manager.py", line 567, in run_arguments
getattr(my_bookworm,args.action)(args)
File "/usr/local/lib/python2.7/dist-packages/bookwormDB-0.4.0-py2.7.egg/bookwormDB/manager.py", line 76, in config
bookwormDB.configuration.reconfigure_passwords(args.users,args.force)
File "/usr/local/lib/python2.7/dist-packages/bookwormDB-0.4.0-py2.7.egg/bookwormDB/configuration.py", line 398, in reconfigure_passwords
update_settings_for(name,force=force)
File "/usr/local/lib/python2.7/dist-packages/bookwormDB-0.4.0-py2.7.egg/bookwormDB/configuration.py", line 349, in update_settings_for
admin.change_client_password()
File "/usr/local/lib/python2.7/dist-packages/bookwormDB-0.4.0-py2.7.egg/bookwormDB/configuration.py", line 212, in change_client_password
db = MySQLdb.connect(user="root",passwd="",host="<IP_ADDRESS>")
File "/usr/local/lib/python2.7/dist-packages/MySQLdb/init.py", line 81, in Connect
return Connection(*args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/MySQLdb/connections.py", line 193, in init
super(Connection, self).init(*args, **kwargs2)
_mysql_exceptions.OperationalError: (1045, "Access denied for user 'root'@'localhost' (using password: NO)")

Ah, it's never that easy. Could you send a brief description of what your system framework is here? I'm guessing something like an Ubuntu VM in the cloud that runs all operations as root?
If you don't need this to run non-interactively (ie., this is the last time you're setting up the server), you could try running bookworm config mysql without the --force. This handles a few more cases; the --force option is particularly useful if you're trying to script the installation of bookworm across multiple machines.
Looking at the codeblock (below), I see that the config file just assumes the root mysql password is empty. It's possible that in your installation process, you set a root password; if so, it needs to be visible to my.cnf, most likely at ~/.my.cnf. The interactive version of bookworm config mysql should find this for you.
            else:
                # Hail-mary that maybe works on travis
                db = MySQLdb.connect(user="root",passwd="",host="<IP_ADDRESS>")

Correct, Ubuntu 16.04 VM. I think I can get out of root, but most commands working better as root. I don't need to script the installation across multiple machines at this time, so I just tried without --force. It comes back ask me admin user name/password, guess I need to add a user to admin group in mysql. I don't have ~/.my.cnf, that's another thing I'm planning to fix.

Tried bookworm config mysql, still not working. keep getting "Please enter an *administrative" username....", however, after entered 'foobar'(my admin user), getting No username found for the user in the admin role. I have added foobar in ~/.my.cnf, restarted mysql client section. If I enter foobar for several time, gets error message No option 'password' in section: client. But user & password are all presented in ~/.my.cnf.
Please help!

Emptied root password. It's now has OK when run command python test_API.py with some warnings.
This ticket can be closed. Still a mystery why admin user foobar doesn't work though, but it could be a mysql issue.

I'm going to keep this open because there are a couple things we could do better:

At the least, fail more verbosely in this case.
Ideally, be a little better at handling the configuration in the root-only case. The recent switch to storing some passwords at /etc/bookworm should make this more doable than it was when I first wrote the code.
Eg., If a user can type mysql -e "CREATE USER 'xxx'" at the command prompt, we might just fallback to a subprocess.Popen() call to get the account creation stuff started without worrying about where these files are located.


Replacing builders suffixed by OrThrow with those without a suffix in design goals

Description
Like discussed in the idea #104, we would like to replace the recommandation on using builders suffixed by OrThrow with those without a suffix in the Explicit builders for better error handling section of the design goals.
Dependencies
This issue is blocked by the following ones:

[x] #117

Checklist

[ ] Update documentation.

This issue is outdated.


Support OAuthenticator for our hubs

Description
Right now, we only support using Auth0 for our hub authentication. Individual hubs should be able to opt-in to using OAuthenticator for specific features, rather than being forced to just use Auth0.
Benefit
While our Auth0 setup allows us to create arbitrary new hubs without needing to provision external auth credentials (like GitHub OAuth secrets, Google OAuth secrets, etc), it doesn't allow us to use provider specific features present in the JupyterHub OAuthenticator - such as allowing users with a GitHub org or team to login (https://github.com/2i2c-org/pilot-hubs/issues/598).
Many communities may want to use these features, particularly the more advanced ones. Most importantly, this would allow us to mirror Pangeo's authentication setup.
Implementation

Note that if we set up OAuthentication for our hubs, this will be a manual step
We should explore whether we can do the same thing but using OAuth instead of a manual OAuthentication

Tasks to complete

[x] Make a release of Z2JH (since changes to OAuthenticator are on master right now)
[x] Bump our z2jh image in basehub chart and /images/hub: #635
[x] Implementation proposal for how we'd support both Auth0 + OAuthenticator
[ ] Support specifying secret config on a per-hub / per-cluster basis, to store auth credentials
[ ] Determine policy for when we should use OAuthenticator directly vs Auth0

Updates

[x] 2021-09-14 - For this sprint, @sgibson91 is going to put together a design proposal for how we could balance using both Auth0 and the native authenticator in our hub deployments.
[ ] 2021-09-21 - Give a shot at implementing native OAuthenticator on our hubs + using that to authenticate with GitHub Teams. Will open another issue for long-term options using Auth0.

Changelog for v1.1.3 of z2jh merged and tag release made https://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/2361

Opened #635 to bump the version of z2jh we're using

Next steps

Come up with a design proposal for how we'd implement this in our hub deployments.

I have a HackMD with the design proposal here: https://hackmd.io/@sgibson91/S1CWEnemY (The section on the deployer still needs fleshing out but it's close to being done) Feedback appreciated!

Hey @sgibson91 - I will take a closer look this week! But I had two really quick top-level questions:

Can we rule out the possibility of using Auth0 + GitHub Teams authentication? If this were possible it'd simplify things a bit (at least in the short term), but I'm assuming we've already checked and it isn't possible.
For the secret credentials, couldn't we just store those in the same hub config file, so long as they were encrypted? If I recall, sops still produces valid YAML even when the file is encrypted, so as long as we remembered to decrypt as part of deploys, maybe it'd be possible?

I left a couple comments in the hackmd, @sgibson91. But overall +1 from me.
To get this to work with auth0, I think we'll need to add functionality that so that somehow when auth0 is authenticating with GitHub, it fetches information about 'groups' from GitHub, populates it into auth0, and then uses that for login authorization. I think auth0 has RBAC functionality (https://auth0.com/docs/authorization/rbac/) that can be used to do this and more. The question is how to get info from GitHub in auth0, and I haven't played around with it. I feel like it should be possible, since it is such an obvious use case.
However, the path forward that @sgibson91 has outlined here with sops and OAuthenticator is simpler to implement right now, and more of a known quantity to us. I'm happy to defer to her on wether the auth0 option should be investigated further or not.

Thanks for the comments @yuvipanda! I would have to do some further digging into the Auth0 use case.

For the secret credentials, couldn't we just store those in the same hub config file, so long as they were encrypted? If I recall, sops still produces valid YAML even when the file is encrypted, so as long as we remembered to decrypt as part of deploys, maybe it'd be possible?

There are a couple of reasons that make me want to push-back against this:

We configure auth on a per-hub basis, not a per-cluster basis. So putting all config in one file and encrypting it would mean encrypting config for all hubs, even if they don't have the secret fields associated with the JupyterHub OAuthenticator. This is overkill.
While sops maintains the YAML structure, it still encrypts all values. And I think "remembering to decrypt" would get in the way of some quick operating tasks, such as updating image tags or domain names, that could presently be done in the browser if required.
I also think 2 begins to get in the way of our Right to Replicate. How can a community replicate their infrastructure, specifically without our support, if we've encrypted it? At least in the current proposal, the minimal amount of config is obscured and that can easily be deduced from the z2jh/OAuth docs.

Do we already have one?

None that I'm aware of

2021-09-21 - Give a shot at implementing native OAuthenticator on our hubs + using that to authenticate with GitHub Teams. Will open another issue for long-term options using Auth0.

Will open another issue for long-term options using Auth0.

Issue opened here https://github.com/2i2c-org/pilot-hubs/issues/698

I have a first pass at this here: https://github.com/2i2c-org/pilot-hubs/pull/706
This is currently deployed and working on Pangeo staging, but I'd like some early feedback to check that what I'm doing isn't too hacky.

Reopening as merging #706 caused some validation errors that I'm going to look into with fresh eyes. I reverted the change in #721. CI isn't green across the board, but the errors are mostly timeout related I think due to hitting various APIs with a lot of traffic in a short amount of time. I re-ran once and got a different set of hubs failing with timeout errors so I think they're all up to date with post-721 merge, just being flakey

Closing as this was fixed by #728 (the resulting CI failures where related to the prometheus version https://github.com/2i2c-org/pilot-hubs/issues/616)


Discover performance issues when deployed and used together with the frontend

Describe the aim of this enhancement
This issue will serve as a discovery page for any performance-related or usability problems with the API server as it interacts with a PostgreSQL server and a frontend application.
To-Dos

[x] Open a request at kweeznuts
[ ] Write test cases, considering experiences with the Canvas LMS
[ ] Explore the deployed application, publish findings as issues and mention them on this page

Discovery#1: #32 (for optimization)


consesus: Apply 4.0.2 patches against 4.1

This applies 4.0.2 patches against 4.1 and improve versionbit checking for assets.
The patches are:

Restore FORKID to VerifyScript
Fix nCoinCacheUsage
Fix ComputeBlockVersion
Restore assets versionbit checking

Tested on: mainnet testnet regtest

Merging since tested on v4.0.2.


Unstable - promote

Is this needed any longer or can we close this pull?

I closed it.
On Mon, Aug 24, 2015 at 3:21 PM, Wade Wegner<EMAIL_ADDRESS>wrote:

Is this needed any longer or can we close this pull?
—
Reply to this email directly or view it on GitHub
https://github.com/developerforce/Force.com-Toolkit-for-NET/pull/135#issuecomment-134398436
.

--
Thanks,
Dave


Determine weco:patron_role to DLCS role mapping

https://github.com/dlcs/protagonist/issues/278 provided a sample app for mapping patron roles to DLCS roles.
We need to determine:

What roles we require in DLCS (currently restrictedFiles, clinicalImages and clickthrough).
How the weco patrol roles are mapped to these (from Reader, Staff, SelfRegistered and Excluded), and whether these are granular enough.

The mappings configured in the demo app are visible here : https://auth-test.wellcomecollection.digirati.io/mappings

See discussion in Slack
https://digirati.slack.com/archives/CBT40CMKQ/p1664283005119249
In the experiemental Archivematica METS some assets have "Restricted" and in order to process them I have added this as a known AccessCondition. This should be removed once the final form of METS is in use.

See further discussion in Slack: https://wellcome.slack.com/archives/CBT40CMKQ/p1717676657432939
Relates to:

https://github.com/wellcomecollection/identity/issues/400
https://github.com/wellcomecollection/identity/pull/403


Layout Issue with title

The title is a bit cut off on one of my Libs.
Screenshot:

I'm using Version 5.2.2 and the LibsBuilder as an Activity.

@RubenGees interesting. on my phone it adds "..." to cut the name of the library. two lines is no option

I looked a bit through the layouts, they seem to be correct. I think that might be an Android issue or something, it happens on no other device I have tested this against either. https://code.google.com/p/android/issues/detail?id=13895 maybe it's this bug?

hmm could be something similar

@RubenGees is this still a topic for you?

Well, it was never a real problem, as it is really unlikely to happen, so i'll close this. I just wanted to show it if you maybe would have wanted to look for a solution.

yeah i have not really found what could cause the problem as it works in some cases. and in your case not. really weird


Update readme.md

Improve syntax highlighting and code formatting in readme's JSX code examples

Super nitpicky, but could we do 2 spaces instead of 1?
Good PR besides that.

Sure thing @jariz, done! :)


Setup help

These are my settings
And after I run the program(both cmd and IDE), it goes "entering heartbeat" and begins to spam me in cmd prompt infinitely, but on IDE it spams me shortly and gives me a few errors..

Also, I'm a bit confused how the "min-kak" setting works, depending on its value will the bot automatically claim any character more than min-kak? Or will it only be looking for wishlist characters worth more than min-kak? Either way, if a specifically listed character / series is worth less than min-kak will the bot still claim it?
Thanks, I appreciate your work and efforts.

Yes so it seems like you have a older version of discum which is why it is giving errors
And yes min kak is a separate sniping option so it will not limit other sniping method if you have a character that is worth 1 kak it will still snipe is because atleast 1 will be true
Sent from my iPhone

On Sep 28, 2021, at 10:11 PM, BlamoThePollo @.***> wrote:

These are my settings
And after I run the program(both cmd and IDE), it goes "entering heartbeat" and begins to spam me in cmd prompt infinitely, but on IDE it spams me shortly and gives me a few errors..
Also, I'm a bit confused how the "min-kak" setting works, depending on its value will the bot automatically claim any character more than min-kak? Or will it only be looking for wishlist characters worth more than min-kak? Either way, if a specifically listed character / series is worth less than min-kak will the bot still claim it?
Thanks, I appreciate your work and efforts.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Took me a while but I managed to get the correct version of discum and now your program is up and running!
Does it also snipe wishlist characters (Regardless of kakera/if i listed it)? And also what would be the minimum time to be able to get it as fast as possible? (My server has no timer and I set it to 1 as you recommended it but I think it is slower than my friends reaction), can I set it to a float value?

currently there is a small delay added of like .5 seconds but other than that all snipe timers are automated in the current version so it will do the math and see what timer is on what server no need to worry about that per say
you can think of timing in stages
Computer Processing speed (how fast your personal computer can run all this codes and the various checks) > Wait .sleep function if needed > Discord Interaction (speed at which the Discum library functions * out of my control * and your connection to discord servers > Mudae (time Mudae sees that you have reacted)
Normal interaction for human can be seen as
Roll > See X > Reacts > Mudae(too fast or too slow)
ultimately the person rolling will always get priority as there are way less steps to do
the bot usually wins when it comes if someone rolls and someone other than the roller wants to claim X character
if you need more of an explanation just let me know
as for Wished
All functions are considered one check so if kak_value > min_kak is one check  another will be if username in message.content is the wish check , if series_name in series_list and finally if name in Embed.name so if it passes even one of those check it will snipe

Program has been working pretty well so far, I do recieve this error in command prompt occasionally

But it hasnt caused any major issues with it yet.
Was also wondering if there is anyway I can make the program even faster? To the point where it could steal a character from whoever was rolling.

Delete every function that is not needed so it doesn’t have to run thru code
You could also update to the developmental version to possibly speed up discord interactions
And that error is usually a thing when you get a message from mudae that doesn’t have an embed
Sent from my iPhone

On Sep 29, 2021, at 6:23 PM, BlamoThePollo @.***> wrote:

Program has been working pretty well so far, I do recieve this error in command prompt occasionally
But it hasnt caused any major issues with it yet.
Was also wondering if there is anyway I can make the program even faster? To the point where it could steal a character from whoever was rolling.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Would you mind outlining which functions I can delete without any issues?
Currently im only checking for if the kakera value of the character > min value or if the character is one of my listed characters or from a listed series, and reacting to the character if so. I am also having the bot react to kakera depending on its color.
I believe that the wait function / setting is unnecessary in my situation, and the automatic rolling / claiming at the end of each 3 hour period as I am not using that either.
And what would I be updating to the developmental version and how would I do that?
Also, even if i were to do so, by how much would this speed up my claim time?

That would fall into the realm of me personally designing the app. I can say that kakera sniping and claim sniping are on the same thread.
You can delete the wish sniping , char sniping etc.
As for developmental version of discum that is a discum dev question as He/she has told me to us about the developmental version so you can contact them also to update
As for time saved this is variable and based on many factors like processing speed , internet connection , mudae so can’t really give you a estimate without testing on your machine
Sent from my iPhone

On Sep 29, 2021, at 7:46 PM, BlamoThePollo @.***> wrote:

Would you mind outlining which functions I can delete without any issues?
Currently im only checking for if the kakera value of the character > min value or if the character is one of my listed characters or from a listed series, and reacting to the character if so. I am also having the bot react to kakera depending on its color.
I believe that the wait function / setting is unnecessary in my situation, and the automatic rolling / claiming at the end of each 3 hour period as I am not using that either.
And what would I be updating to the developmental version and how would I do that?
Also, even if i were to do so, by how much would this speed up my claim time?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Alright, I appreciate it!

No problem let me know if there are any more issues or more features you would like to add. Remember to star to repo if you haven't it's a free way to let me know that my project is well received. I will be closing this issue as of now thank you


it requires several clicks on folders to open them

sometimes the script reacts as expected. but mostly I have to click the folder button or the folder-up button 3 or 4 times to get an reaction.
PHP version is 5.4.24
DirectoryLister is 2.6.1

This sounds like an issue specific to your installation and/or web browser.  Does the problem happen on http://demo.directorylister.com ?

No, it works on your demo. But what could it be? Any suggestions?


HOLD: Line-comment-start character is semicolon

http://www.saremba.de/chessgml/standards/pgn/pgn-complete.htm#c5
For some reason I had % instead.

Oh I see.  I was supporting % in the first position because of "escaping" http://www.saremba.de/chessgml/standards/pgn/pgn-complete.htm#c6.  Semicolon doesn't have to be in the first position.  Thinking…

Self-merging.  This is a straightforward improvement which brings us closer to the PGN spec.


Unknown POSIX error while trying to render a template

Hi! I'm trying to render a liquid template using the provided information on the README and I'm getting this error.
Layout.liquid
{% render "post" %}

Post.liquid
Hello From Post

And then:
content = File.read!("theme/layout.liquid")
{:ok, template_ast} = Liquex.parse(content)
{content, _context} = Liquex.render!(template_ast, %{})

** (File.Error) could not  nil: unknown POSIX error
    (liquex 0.10.1) lib/liquex/file_system.ex:22: Liquex.FileSystem.Liquex.BlankFileSystem.read_template_file/2
    (liquex 0.10.1) lib/liquex/tag/render_tag.ex:218: anonymous fn/2 in Liquex.Tag.RenderTag.load_contents/2
    (liquex 0.10.1) lib/liquex/tag/render_tag.ex:143: Liquex.Tag.RenderTag.render/2
    (liquex 0.10.1) lib/liquex/render.ex:25: Liquex.Render.render!/3
    (liquex 0.10.1) lib/liquex.ex:213: Liquex.render!/2
    iex:7: (file)

Do I have to do any other setup for this to work?

I apologize for not responding earlier, but this is happening because you haven't set a file system for your context. See the example below. I have fixed the error to instead show an error message to help avoid this issue in the future:
file_system = Liquex.LocalFileSystem.new("/some/path")

# Whatever your scope is
scope = %{}

context = Liquex.Context.new(scope, file_system: file_system)
Liquex.render!(template, context)


Update Azure.Android README.md

Still in progress. Not yet ready for review 🙂.

This is now outdated. I'm closing it.


[Bug] Sync Secrets failing to keep secrets in sync

Kyverno Version
1.12
Kubernetes Version
1.28
Kubernetes Platform
GKE
Description
When I raise sync secret policy and i update the upstream secret, I see no change to the downstream secret. This extends to both editing the secret to change a label and deleting the upstream secret entirely. Does it have to do with excluding the namespace that the clone secret is derived from?
Steps to reproduce
Apply the below kyverno sync-secrets policy. Edit or delete the parent secret and observe that the child secrets are unaffected.
The policy:
# this is a Generate rule which creates new Kubernetes resources based on a
# policy and optionally keep them in sync. See more:
# https://kyverno.io/docs/writing-policies/generate/
apiVersion: kyverno.io/v1
kind: ClusterPolicy
metadata:
  name: sync-secrets
  annotations:
    policies.kyverno.io/title: Sync Secrets
    policies.kyverno.io/category: my-team
    policies.kyverno.io/subject: Secret
    policies.kyverno.io/minversion: 1.6.0
    policies.kyverno.io/description: >-
      Copy the wildcard secret into every namespace and keep it in sync.
spec:
  generateExisting: true
  background: false
  rules:
  - name: sync-wildcard-secret
    match:
      any:
      - resources:
          kinds:
            - Namespace
    exclude:
      any:
      - resources:
          namespaces:
          - kube-system
          - default
          - kube-public
          - kube-node-lease
          - kyverno
    generate:
      kind: Secret
      apiVersion: v1
      name: wildcard
      namespace: "{{ request.object.metadata.name }}"
      synchronize: true
      clone:
        namespace: kube-system
        name: wildcard

then either kubectl edit or kubectl delete the original secret and observe no change in the data inside the child secrets.
Expected behavior
Per https://kyverno.io/docs/writing-policies/generate/#clone-source I expected to see the downstream copies of the secret deleted.
Is it because the clone source of the secret is in a namespace that is being excluded?
The below logs are when deleting the child secrets where evidence is shown of the sync being respected. No logs are produced when the clone source is deleted.
Screenshots
No response
Kyverno logs
kyverno-background-controller-67d4c74d47-g8t49 controller {"level":"info","ts":"2024-06-27T16:06:06Z","logger":"background","caller":"generate/generate.go:101","msg":"start processing UR","name":"ur-c2wn7","policy":"sync-secrets","resource":"v1/Namespace//","ur":"ur-c2wn7","resourceVersion":"146331005"}
kyverno-background-controller-67d4c74d47-g8t49 controller {"level":"info","ts":"2024-06-27T16:06:06Z","logger":"background","caller":"generate/generate.go:101","msg":"start processing UR","name":"ur-s4fsh","policy":"sync-secrets","resource":"v1/Namespace//","ur":"ur-s4fsh","resourceVersion":"146331006"}
kyverno-background-controller-67d4c74d47-g8t49 controller {"level":"Level(-2)","ts":"2024-06-27T16:06:06Z","logger":"background","caller":"generate/generate.go:458","msg":"created generate target resource","name":"ur-s4fsh","policy":"sync-secrets","resource":"v1/Namespace//","target":"v1/Secret/example-system-global/wildcard"}
kyverno-background-controller-67d4c74d47-g8t49 controller {"level":"Level(-2)","ts":"2024-06-27T16:06:06Z","logger":"background","caller":"generate/generate.go:458","msg":"created generate target resource","name":"ur-c2wn7","policy":"sync-secrets","resource":"v1/Namespace//","target":"v1/Secret/example-system-global/wildcard"}

Slack discussion
No response
Troubleshooting

[X] I have read and followed the documentation AND the troubleshooting guide.
[X] I have searched other issues in this repository and mine is not recorded.

Does it have to do with excluding the namespace that the clone secret is derived from?

Yes, almost certainly.

the problem I'm trying to solve by excluding the namespace where the clone secret is is that Kyverno does not own the clone secret and it should not try to write to that namespace.
Is there another way besides rules.exclude to tell the below policy to ignore updates to the cloned secret's namespace?
      namespace: "{{ request.object.metadata.name }}"

An obvious workaround is to name the copy of the secret something else (i.e. wildcard-copy) but that's logistically complicated.

kube-system is excluded in webhooks by default, therefore whether it's listed in the exclude block in this policy is irrelevant. Kyverno must be able to "see" admission events on clone sources, and with it being excluded in the webhook this isn't possible. You can change the webhook exclusions either during install or on day2 by modifying Kyverno's ConfigMap.

Thanks! Please close, I've redirected this as a documentation fix. Appreciate the help!


feat: update ui with new page header, breadcrumb and sidebar

Closes #230, closes #231

:tada: This PR is included in version 1.11.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


chore: adding changelog generator

Adding change log generation via changelogen.
I've changed the bumpp script in package.json to use the new generation script.
I've also added the CHANGELOG.md file, containing all of the previous releases.
The new bumpp command would do the following tasks:

Bump the version (Automatic/Manual)
Update CHANGELOG.md file
Generate changelog for automatic release PR description.
Push the new PR and setting it to draft status

from this point onward, a maintainer would check the PR, change the description if required, then merge it with dev branch.
To test this script:

Create a Github token  to access project via API
Create/update .env file, following .env.example structure
Create a fork of shadcn-vue and change content of changelog.config.ts to match the new created fork.
3.1 This step is really important as we would be manipulating  the original repo if the tester has write access to shadcn-vue
Create a dummy commit following conventional commits instructions.
Execute npm run bumpp
Select the desired new version
Done

Please feel free to share your thoughts and suggestions.
What is left is changelog page for app, which I'll be working on it soon.

Thanks @Saeid-Za for the PR! May I ask what's the main difference between using this scripts/changelog and https://github.com/changesets/changesets ya? I'm kinda leaning towards changesets for the moment as we can utilize it for better version control, and don't need to worry about maintaining our own scripts.

main difference between using this scripts/changelog and https://github.com/changesets/changesets ya?

changelogen's changelog is fancier than changesets changelog 😄 I wonder if we could exact same style from changelogen in changesets

Thanks for the feedback !
Well, this is not solely about styling, let me elaborate.

I'm kinda leaning towards changesets for the moment as we can utilize it for better version control, and don't need to worry about maintaining our own scripts.

I'm not sure if I understand the version control part, why would it be better? we still have the manual (if needed ofcourse) control over what version we're releasing. the script is using bumpp  under the hood and supports granular control.
Not that maintaining the script is inherently a bad idea, but I understand that it would require further burden if change is frequent. I don't think this script needs changing that much, furthermore, We will always need a script if we would to automate PR request with changelog, see the nuxt release page.

If you think changeset is a better alternative, we could swap changelogen with that, because they are really the same tool (with almost the same API) for the same job, but if we were to add automated PRs for releasing the new version with changelog, this some sort of script should exist
Is there anything I missed?

Oh, It seems that I was wrong on one point. This repo has a Bot that generates changelog for github. I'll close the PR since this doesn't bring any value.
We still miss a changelog.md file though.


Request: Set icon size in the Fences

Would it be possible to choose the scale of the icons displayed in each fence?
This would make Fences that display images particularly useful.
What do you think?

Yup, should be possible


Material for a very soft (no bounce) collision

I want to create an almost bounce-free collision... I've been playing with the ContactMaterial properties but the rebound is still too fast.
This is the best I can do so far:
const mat = new CANNON.ContactMaterial(
	ballMat, pillowMat,
	{
		friction: 10.0,
		restitution: 0.0,
		contactEquationRelaxation: 10.0,
		frictionEquationStiffness: 1
	}
)

Any tips? :)

Experiment with those parameters. You can use this demo to get the effect you want (press space to rerun with same params): http://schteppe.github.io/cannon.js/demos/singleBodyOnPlane.html
Also consider reducing gravity and increasing body damping. This will reduce the overall velocity, therefore the overall contact penetration and therefore also the amount of rebound (this is a common gamedev physics trick, also used to improve physics performance).

Hi schteppe, thanks. You mean the linearDamping property when creating a body? That seems to increase "air drag" but that's not what I want.
I did some more experimentation, it seems setting restitution = 0 and high value for contactEquationRelaxation like 1000 or more give me the best result. The other parameters don't seem to change much so I'm omitting them.
If needed I guess I can simply reduce the velocity myself upon contact.

So, experimenting some more, I think I'll get better results if I just clamp the velocity myself. I've run into a bit of a snag however.
I used addEventListener('collide', ...) to the pillow object for collisions. It fires when the ball hits it. At that point, I clamp the ball velocity to a small value, however it doesn't seem to change the velocity. I'm guessing because the collision is still happening and my velocity change is overwritten by cannon.
I see in this thread that there should be an 'endContact' event. I tried using that instead of 'collide', however it doesn't seem to fire.
Any ideas on how best to manually adjust the velocity when contact is detected?
Also, I can't seem to find a list of event names that can be used with Body#addEventListener - that would be helpful. :)

Right. Yea, damping will reduce velocity of objects in general. Probably not the effect you want, just a suggestion.
You probably want to clamp the velocity after each step. Something like this?
world.addEventListener("postStep", function(event){
    if(shouldClamp){
        body.velocity.y = 0;
        shouldClamp = false;
    }
});
world.addEventListener("beginContact", function(event){
    shouldClamp = true;
});

I'm not sure why event doesn't work for you. Try using the latest master branch version from github?
Looks like the docs are not available for those events yet! Wanna add?

Looks like the docs are not available for those events yet! Wanna add?

Sure, I could help with that.
Hmm, I used body.addEventListener('endContact'... I'll try re-building, I thought I was using a fresh build but I'll double check.
Been pretty busy tring to meet a deadline. I'll try to put together a small test case, there's another little quirk I want to demonstrate as well.

I made a little test - this demonstrates that 'collide' events fire, but 'endContact' events don't:
http://www.spacejack.ca/cannon-contact-example/
I put up a source repo here:
https://github.com/spacejack/cannon-contact-example
This is using a freshly pulled cannon.js repo, built with grunt.
I set up the endContact event on this line in the source.


HOTT-1252: Check the last 10 files for a correct sequence in Taric

Jira link
https://transformuk.atlassian.net/browse/HOTT-1252
What?
I have added/removed/altered:

[x] Alter the file sequence check business logic in TaricUpdate such that we check the last 10 files for correct sequence

Why?
I am doing this because:

We want this because we can have multiple files arrive out of order.
This can lead to us treating a correct sequence of the last two files as
a false positive indicator to proceed when we should be flapping in
slack.

I've validated this works with a current dump of the staging XI data


Bonfire: Steamroller

My code:
var res = [];

function steamroller(arr) {

  for(var i=0; i<arr.length; i++) {
    if(Array.isArray(arr[i])) {
      steamroller(arr[i]);
    }
    else {
      res.push(arr[i]);
    }
  }

  return res;
}

steamroller([1, {}, [3, [[4]]]]);

returns the correct results to the tests. Test are marked as incorrect though. The difference between results returned by my function and expected results are the "spaces" after the comas in the array, which as far as I know is impossible to add.
For example ["a", "b"] is expected in place of ["a","b"] returned.

I haven't done enough research before opening the issue, problem solved. I'm very sorry.


Outputcache issues

Hello. First of all, thank you for this fantastic product, it is amazing.
If you dont mind, I would like to report some bugs using outputcache.
Here is my config:
  <cacheManager xmlns="http://cachemanager.michaco.net/schemas/CacheManagerCfg.xsd">
    <managers>
       <cache name="defaultCache" updateMode="Up" enableStatistics="false" enablePerformanceCounters="false" backplaneName="redis1" backplaneType="CacheManager.Redis.RedisCacheBackplane, CacheManager.StackExchange.Redis" serializerType="CacheManager.Serialization.Json.GzJsonCacheSerializer,CacheManager.Serialization.Json">
        <handle name="systemRuntime" ref="systemRuntimeHandle" />
        <handle name="redis1" ref="redisHandle" isBackplaneSource="true" />
      </cache>
    </managers>
    <cacheHandles>
      <handleDef id="systemRuntimeHandle" type="CacheManager.SystemRuntimeCaching.MemoryCacheHandle`1, CacheManager.SystemRuntimeCaching" />
      <handleDef id="redisHandle" type="CacheManager.Redis.RedisCacheHandle`1, CacheManager.StackExchange.Redis" />
    </cacheHandles>
  </cacheManager>

  <outputCache defaultProvider="CacheManagerOutputCacheProvider">
    <providers>
      <add cacheName="defaultCache" name="CacheManagerOutputCacheProvider" type="CacheManager.Web.CacheManagerOutputCacheProvider, CacheManager.Web" />
    </providers>
  </outputCache>

<cacheManager.Redis xmlns="http://cachemanager.michaco.net/schemas/RedisCfg.xsd" xdt:Transform="Insert">
  <connections>
    <connection id="redis1" allowAdmin="true" password="password" ssl="true">
      <endpoints>
        <endpoint host="url" port="6380" />
      </endpoints>
    </connection>
  </connections>
</cacheManager.Redis>

Here are the bugs:
1. When using serializer CacheManager.Serialization.Json.GzJsonCacheSerializer with outputcache, it generates the following exception:
Unable to find a constructor to use for type System.Web.Caching.CachedVary. A class should either have a default constructor, one constructor with arguments or a constructor marked with the JsonConstructor attribute. Path '', line 1, position 2.
The exception is raised after retrieval (it adds to the redis cache fine)
2. When setting outputcache duration to 0 (not expires), cachemanager/redis thinks it is 0 seconds and it is doesnt work (is already expired)
3. Outputcache is being created with 2 keys on redis. For example:
"a2/pagename"
"a2/pagenameHQFCDE"
The first one never expires (-1) and the second on works fine. I dont know why it creates 2 keys. I think it should create only one with the correct ttl.
4. When using CacheManager.StackExchange.Redis 1.1.0 with the CacheManager.Web I get the following exception (When using CacheManager.StackExchange.Redis 1.0.1 it works fine. I dont know why):
Parser Error Message: Version string portion was too short or too long.
Source Error:
<outputCache defaultProvider="CacheManagerOutputCacheProvider">
<providers>
<add cacheName="defaultCache" name="CacheManagerOutputCacheProvider" type="CacheManager.Web.CacheManagerOutputCacheProvider, CacheManager.Web" />
</providers>
</outputCache>

Thanks for all the help. Please let me know if you have additional questions, I will try to answer to my best knowledge.

Hi @hermesramos, thanks for reporting all this although I think not all of those are actually bugs ;)
Regarding 1) - Serialization
Unfortunately, the output cache stuff has a few limitations as almost everything in System.Web.Caching is internal. The serialization is pretty restricted because of that and as far as I have tested, only binary serialization doesn't care and works.
So, regarding setting the serialization, don't use Json or GzJson or anything else than default (binary serialization).
Regarding 2)
If I set duration to zero, nothing gets cached (as expected) => [OutputCache(Location = OutputCacheLocation.Server, Duration = 0)]
Setting duration to zero means it should not cache at all. You have to give it a positive number in seconds to actually cache things (that's how OutputCache works and has nothing to do with CacheManager).
Regarding 3) That key without expiration is added by the ASP.NET framework. It is not your page data, just some meta information I think. So, just don't worry about that one, that's again just how OutputCache works and has nothing to do with CacheManager
Regarding 4) Yup, that's actually a bug. If nothing is specified, the configuration section sets the version string to string.Empty which causes that issue, I'll fix it. Until then you can work around by setting the version to a valid value if you want, strictCompatibilityModeVersion="3.0" for example

Hello! Good morning and thanks for the prompt answer.
All looks good. You are right on the duration 0!

Ok cool, I'll close this one then


DB2: support begin/end blocks rules

We probably need to add more sophisticated rule for block parse. Currently we use just block begin/end literals which don't respect context.

Fixed:

Note that regular BEGIN and END keywords are colored using different color unlike ROW BEGIN and ROW END.
This example uses different highlighting color for the sake of visualization.
Which means that:

ROW BEGIN must not be treated as a valid block beginning
BEGIN ... END blocks are supported back again now (and folding should work with them)

verified


progressive supranuclear palsy SCTID

Mondo term (ID and Label):
MONDO:0019037 progressive supranuclear palsy
Xref that should be fixed (ID and label):
SCTID:28978003 (Actually maps to "Progressive supranuclear ophthalmoplegia," per UMLS's representation of SNOMED.  Is this the same as MONDO:0020257 "supranuclear oculomotor palsy"??)
SNOMED code for "progressive supranuclear palsy" (again, per UMLS's SNOMED map) is 192976002
Your nano-attribution (ORCID)
If you don't have an ORCID, you can sign up for one here
Other comments:
This needs additional clinical review before making any changes. I am relying heavily on simple string matching, UMLS's mapping of the SCTIDs and hierarchies, and limited clinical descriptions provided in Metathesaurus and on Mondo.

Hello @kanems
I'm Sabrina, a new curator who recently joined the Mondo team.
We will address your issue as soon as possible. Thank you for your patience.
If this is a high priority, please let me know and we can prioritize it. Thank you!

this means you have some issue with moving your eyes. Progressive supranuclear ophthalmoplegia is a phenotype, there is a record in OMIM because there is a gene associated with this.

[ ] 'progressive supranuclear palsy' is incorrectly classified as a genetic disease, should remove those superclasses. Exclude 'genetic dementia' and 'inherited neurodegenerative disorder'

@ahamosh
OMIM has progressive supranuclear palsy and lists  STEELE-RICHARDSON-OLSZEWSKI SYNDROME  as a synonym, but other literature appears to regard the latter as an idiopathic non Mendelian disease , e.g.,
https://www.mjdrdypu.org/article.asp?issn=0975-2870;year=2013;volume=6;issue=3;spage=342;epage=345;aulast=Gokhale;type=3
Should we introduce some superclass for diseases that are primarily characterized by SNOP and then have two subclasses
Mendelian SNOP and Complex SNOP (or something like that). Also the above cited article appears to further subdivide  STEELE-RICHARDSON-OLSZEWSKI SYNDROME

Steele-Richardson-Olszewski disease may refer to all three subtypes, OMIM used this as an alternative name for only one subtype. There is not a PS. OMIM should create a PS.
Steele-Richardson-Olszewski disease should be an exact synonym for MONDO:0019037 'progressive supranuclear palsy'. and this should be equiv to OMIMPS when it is created.


first implementation

There is a question of what to do about the feature names, since technically, the child's feature names should always be a superset of the parent's. I think we can just let users of the Type class deal with that. Thoughts @tomsilver ?

Re: feature name question, that's interesting... I agree that we should let the users deal with that.


Evaluate CSVtoCSVW for LeBeDigital

Generates JSON-LD for various types of CSVs.
trying out the tool for mapping data files to json-ld metadata for LeBeDigital:
https://csvtocsvw.matolab.org/
trying out the tool for MapToMethod:
https://maptomethod.kupferdigital.org/
trying out the tool for converting and validating YARRRML and Chowlk files to RDF, which is applied to Material Sciences Engineering (MSE) Methods, for example, on Cement MSE experiments.
https://rdfconverter.matolab.org/

[x] mapping data files (CSVS) to json-ld metadata
[x] map content of JSON-LD files (output of CSVToCSVW) that describing CSV files to Information Content Entities in knowledge graphs describing methods
[x] Conversion and validation of YARRRML and Chowlk files to RDF

APIs:
Generates JSON-LD for various types of CSVs:  https://csvtocsvw.matolab.org/api/docs
Tool to map content of JSON-LD files:  https://maptomethod.matolab.org/api/docs#/
Conversion and validation of YARRRML and Chowlk files to RDF :http://rdfconverter.matolab.org/api/docs/#/


Adding converter samples

Description of Change
Added the Stated converters in #430
Bugs Fixed

Added missing Converters to sample app.
Code House Keeping
API Changes
No api changes
PR Checklist

[ ] Has tests (if omitted, state reason in description)
[x] Has samples (if omitted, state reason in description)
[ ] Rebased on top of main at time of PR
[x] Changes adhere to coding standard

[ ] Updated documentation

@pictos thank you for taking the time to review my pr , i have committed the changes that you requested, if there is any way we can further optimize the code please tell me.

@AndreiMisiukevich changes met

@pictos  Thank you for taking the time to review it, it was my pleasure working on it :D


Performance Issue - Slow Dragging and Dropping Files/Folders

I'm experiencing slowness dragging files and folders. The problem persists with all other plug-in disabled.  Replacing the style.css with an empty file fixed the slow file/folder dragging issue.  The vault with the issue has 6,000 notes.  Added a video of the issue.  https://github.com/user-attachments/assets/8aa0544c-2ecf-4ce1-9fdd-01758ebf54a1
Obsidian 1.7.3
Codeblock Customizer: 1.2.8
The issue is similar to this issue from a while back.  https://github.com/mugiwara85/CodeblockCustomizer/issues/54
Tested in a test vault (100 files) and it is not an issue.  Not sure how the size of the vault could be an issue.  Tied on my laptop and it is not an issue....
Next, I'm going to un-install and reinstall Obsidian to see if that has an impact.

No need to reinstall Obsidian. Which Theme are you using? Also, when you tried in a test Vault with less files, where you using the same theme?

I am using the minimal theme but set it back to default as a troubleshooting step.
I downloaded the latest and version of Obsidian 1.6.7 and installed it.  (Didn't un-install first, tried the lazy path first.) That fixed the issue!  Maybe some underlining Electron dependency...

Wait. You said in your first message that you are using Obsidian 1.7.3. But I just saw that the current version is 1.6.7. So, you were using an older version of Obsidian?
It is working now correctly, right?
This behavior is definitely a CSS problem. It is also possible that the problem was in Obsidian CSS, or in a Themes CSS, or that there was some CSS which conflicted with the plugins CSS, or the plugins CSS conflicted with one of them. Anyway, it is hard to debug, that's why I asked you to open a new issue, since I already fixed the other one. That shouldn't be a problem anymore.

I am running the insider release 1.7.3.  I reinstalled 1.6.7 then updated to 1.7.3.
Yes it is working now.

Glad, it is working fine.


feat: Add support for EKS Auto Mode and EKS Hybrid nodes

Description

Add support for EKS Auto Mode

Adds new role creation for EKS Auto Mode node role when using built-in nodepools system and/or general-purpose

Add support for EKS Hybrid nodes
Add variable enable_security_groups_for_pods to maintain current cluster IAM role policy behavior; this can be disabled for those not using security groups for pods. This variable and the attachment of the AmazonEKSVPCResourceController policy will be removed in the next breaking change

Motivation and Context

https://github.com/hashicorp/terraform-provider-aws/pull/40370
https://github.com/hashicorp/terraform-provider-aws/pull/40371
Resolves #3226

Breaking Changes

No

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

Waiting to try this one.

FYI - https://github.com/hashicorp/terraform-provider-aws/issues/40411

we'll go ahead and merge this since it supports creating clusters with EKS Auto Mode and EKS Hybrid nodes, and also supports opting into EKS Auto Mode - the only scenario which is not support at this time is opting into EKS Auto Mode utilizing the built-in nodepools (system, general-purpose). This requires https://github.com/hashicorp/terraform-provider-aws/issues/40411 to be resolved to support that scenario

This PR is included in version 20.31.0 :tada:


Issue with Multi-GPU

transformers version: 4.3.3
Platform: Linux-4.15.0-132-generic-x86_64-with-Ubuntu-18.04-bionic
Python version: 3.6.9
PyTorch version (GPU?): 1.7.1 (True)
Tensorflow version (GPU?): 2.3.0 (True)
Using GPU in script?: Yes, multi GeForce RTX 2080 Ti GPUs
NVIDIA-SMI 440.33.01    Driver Version: 440.33.01    CUDA Version: 10.2

I use os.environ["CUDA_VISIBLE_DEVICES"]="6,7" to choose GPUs and everything else in the code is pretty straightforward with using BertClassifier() as model. I am able to run it with CPU with no such issue.
    model = BertClassifier()
    model.bert_model = 'bert-base-uncased'
    model.max_seq_length = 512
    model.train_batch_size = 8
    model.eval_batch_size = 8

I had some issue with Transformers then I resolved it by actually removing the bits of code that sets up DataParallel, https://github.com/huggingface/transformers/issues/10634. I am still not sure why this happens.
0it [00:00, ?it/s]Building sklearn text classifier...
Loading bert-base-uncased model...
Defaulting to linear classifier/regressor
Loading Pytorch checkpoint
train data size: 1320, validation data size: 146
Training  :   0%|                                                                                | 0/42 [00:09<?, ?it/s]
0it [00:27, ?it/s]                                                                                | 0/42 [00:00<?, ?it/s]
Traceback (most recent call last):
  File "seg_pred_skl.py", line 46, in <module>
    model.fit(X_train, y_train)
  File "/mnt/sdb/env1/lib/python3.6/site-packages/bert_sklearn/sklearn.py", line 374, in fit
    self.model = finetune(self.model, texts_a, texts_b, labels, config)
  File "/mnt/sdb/env1/lib/python3.6/site-packages/bert_sklearn/finetune.py", line 121, in finetune
    loss, _ = model(*batch)
  File "/mnt/sdb/env1/lib/python3.6/site-packages/torch/nn/modules/module.py", line 727, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/mnt/sdb/env1/lib/python3.6/site-packages/torch/nn/parallel/data_parallel.py", line 161, in forward
    outputs = self.parallel_apply(replicas, inputs, kwargs)
  File "/mnt/sdb/env1/lib/python3.6/site-packages/torch/nn/parallel/data_parallel.py", line 171, in parallel_apply
    return parallel_apply(replicas, inputs, kwargs, self.device_ids[:len(replicas)])
  File "/mnt/sdb/env1/lib/python3.6/site-packages/torch/nn/parallel/parallel_apply.py", line 86, in parallel_apply
    output.reraise()
  File "/mnt/sdb/env1/lib/python3.6/site-packages/torch/_utils.py", line 428, in reraise
    raise self.exc_type(msg)
StopIteration: Caught StopIteration in replica 0 on device 0.
Original Traceback (most recent call last):
  File "/mnt/sdb/env1/lib/python3.6/site-packages/torch/nn/parallel/parallel_apply.py", line 61, in _worker
    output = module(*input, **kwargs)
  File "/mnt/sdb/env1/lib/python3.6/site-packages/torch/nn/modules/module.py", line 727, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/mnt/sdb/env1/lib/python3.6/site-packages/bert_sklearn/model/model.py", line 95, in forward
    output_all_encoded_layers=False)
  File "/mnt/sdb/env1/lib/python3.6/site-packages/torch/nn/modules/module.py", line 727, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/mnt/sdb/env1/lib/python3.6/site-packages/bert_sklearn/model/pytorch_pretrained/modeling.py", line 959, in forward
    extended_attention_mask = extended_attention_mask.to(dtype=next(self.parameters()).dtype) # fp16 compatibility
StopIteration

Issue resolved by following what is discussed in https://github.com/pytorch/pytorch/issues/40457.
Updating Line 959 and 973 in bert_sklearn/model/pytorch_pretrained/modeling.py to:
extended_attention_mask = extended_attention_mask.to(dtype=input_ids.dtype) # fp16 compatibility
and
head_mask = head_mask.to(dtype=input_ids.dtype)


unable to render previews

hello i m  not able to load previews it shows unable to render

Try this : https://nbviewer.org/ or any other notebook viewer

Try this : https://nbviewer.org/

thankyou so much


Improvement on postings intersection

Tree-like recursive methods in the current implementation of Intersect() can cause unnecessary Seek().
An example
Suppose there are 4 postings [1,2,3,4,5], [3,4, 5], [5,6,7,8], [5, 8].
Calling func Intersect(), p1 and p2 will form an intersectPostings, p3 and p4 will form an intersectPostings. The steps are as follows.

Next() for ip1
1.1 Next() for p1 → 1
1.2 Seek(1) for p2 → 3
1.3 Seek(3) for p1 → 3
Seek(3) for ip2
2.1 Seek(3) for p3 → 5
2.2 Seek(3) for p4 → 5
Seek(5) for ip1
3.1 Seek(5) for p1 → 5
3.2 Seek(5) for p2 → 5
Next() for ip1

There are unnecessary Seek(3).
If not use recursive func Intersect(), instead manage all together in an array and Seek() the max value each time. The steps are as follows.

Next() for p1, p2, p3, p4 → max=5
Seek(5) for p1 → 5
Seek(5) for p2 → 5
Next() for p1, p2, p3, p4 → finish

Benchmark
benchmark                       old ns/op     new ns/op     delta
BenchmarkIntersect/case_1-8     199           100           -49.75%
BenchmarkIntersect/case_2-8     195           95.6          -50.97%

benchmark                       old allocs     new allocs     delta
BenchmarkIntersect/case_1-8     4              2              -50.00%
BenchmarkIntersect/case_2-8     4              2              -50.00%

benchmark                       old bytes     new bytes     delta
BenchmarkIntersect/case_1-8     208           96            -53.85%
BenchmarkIntersect/case_2-8     208           96            -53.85%

After banging my head for a long time, this looks good! I think the recursion causes some overhead in the previous implementation and this new one is actually better in all cases I tested with.

benchmark                       old ns/op     new ns/op     delta
BenchmarkIntersect/case_1-8     210           95.5          -54.52%
BenchmarkIntersect/case_2-8     235           115           -51.06%
BenchmarkIntersect/case_3-8     7617750       385602        -94.94%

benchmark                       old allocs     new allocs     delta
BenchmarkIntersect/case_1-8     4              2              -50.00%
BenchmarkIntersect/case_2-8     4              2              -50.00%
BenchmarkIntersect/case_3-8     99999          1              -100.00%

benchmark                       old bytes     new bytes     delta
BenchmarkIntersect/case_1-8     208           96            -53.85%
BenchmarkIntersect/case_2-8     212           98            -53.77%
BenchmarkIntersect/case_3-8     4799952       32            -100.00%

much easyer to understand now, Thanks @naivewong
I found a way to simplify it a bit more.
func (it *intersectPostings) doNext(id uint64) bool {
Loop:
	for {
		for _, p := range it.arr {
			if !p.Seek(id) {
				return false
			}
			id = p.At()
			if p.At() > it.cur {
				it.cur = p.At()
				continue Loop
			}
		}
		return true
	}
}

func (it *intersectPostings) Seek(id uint64) bool {
	return it.doNext(id)
}

benchmark                              old ns/op     new ns/op     delta
BenchmarkIntersect/ManyPostings-8      18495452      649025        -96.49%
BenchmarkIntersect/LongPostings2-8     422           136           -67.77%
BenchmarkIntersect/LongPostings1-8     341           125           -63.34%

benchmark                              old allocs     new allocs     delta
BenchmarkIntersect/ManyPostings-8      99999          1              -100.00%
BenchmarkIntersect/LongPostings1-8     4              2              -50.00%
BenchmarkIntersect/LongPostings2-8     4              2              -50.00%

benchmark                              old bytes     new bytes     delta
BenchmarkIntersect/ManyPostings-8      4799963       32            -100.00%
BenchmarkIntersect/LongPostings2-8     216           98            -54.63%
BenchmarkIntersect/LongPostings1-8     208           96            -53.85%


feat: added "capture" util

:tada: This PR is included in version 2.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Parser add tasks

Supports adding somedays and deadlines; events not yet supported. Closes #4 and #25.

Parser supports adding events

Added test coverage. Closes #24

reviewed

reviewed


docs(Shorthand|Theming): rework docs to be more actual

Fixes #561.
This PR reworks and adds more information about APIs and theming 🥇
Augmentation
Fully new docs page that covers as prop usage 👍
Theming
Added fully new guide about theming in Create React App :atom:
Shorthand
Docs for shorthand props, very detailed 🎉 Thanks to Stardust team for them 👍

/cc @brianespinosa you may be interested 🐰

Codecov Report

Merging #3564 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3564      +/-   ##
==========================================
- Coverage   99.81%   99.81%   -0.01%
==========================================
  Files         174      174
  Lines        2730     2725       -5
==========================================
- Hits         2725     2720       -5
  Misses          5        5

Impacted Files
Coverage Δ

src/behaviors/Visibility/Visibility.js
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c93cdd...d96b1e9. Read the comment docs.

Thanks @layershifter! You're awesome.
I've had almost zero time for open source the past few months. Thanks for keeping things going.


Feature: OnKeyDown Event

Hello,
I think it will be nice when we add a onKeyDown event for the multipleSelect with the textbox, to receive the current input from the multipleSelect Textbox. I dont know if this already exists, but i dont found it until now 🍡
Good Regards,
cRUSHER

Please 👍 and follow #1305.


ecs run_task with FARGATE fails with no container_instances

We use ECS clusters to run tasks, exclusively with 'FARGATE' which runs tasks on FARGATE without us setting up container instances.
When attempting to mock things out with moto, I receive the error  "No instances found in cluster" which comes from https://github.com/getmoto/moto/blob/d0cfddebfd32211bf665d359652039185cc214a7/moto/ecs/models.py#L1232
Moto is hard coded to require container_instances, and our "clusters" don't have them.
Moto should instead, if all tasks are "FARGATE", return the tasks instead of trying to place them on container instances.

Whoops! This is on me, it does this already. "Fargate" != "FARGATE". Closing!

Does AWS throw an error if you specify an unknown type (such as Fargate)?
If do, it would be nice if Moto could do the same. That would prevent this from happening to others.

I suspect it does, but I was writing this test from scratch. None of our actual code had a Fargate in there.


It is possible to add a regex as a ACS URL from the carbon management console

A regex can be added as an ACS URL in the SAML2 Web SSO Configuration even though checking the regex pattern is not internally implemented. The UI validations need to be changed to properly validate this input case.
Steps to reproduce;
In the SAML2 Web SSO Configuration add the following as an ACS URL and it will be accepted.
regexp=(https://myapp.com/callback|https://testapp:8000/callback)

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Improvement/options pattern

Changes identity database configuration to use the options pattern and merges with latest identity branch as of 12:50PM 4/16/23.

If this branch builds off the identity branch that is currently in PR, it probably makes sense to merge this to that branch rather than development so that we aren't seeing the code this branch and identity have in common as changes. That will make review a bit easier as well. We can talk about this tomorrow night.


Extending FolioReaderWebView

Hello!
I'm trying to keep your UIMenuController with highlight, play, etc. buttons and add extra functionality there, such as instant translation of a selected text.
However, I can't find any solution to extend existing WebView.
I saw this example with extending basic FolioReaderContainer:
https://github.com/FolioReader/FolioReaderKit/blob/43d5c57859a872d808ea8b3a40628dc0f78aeaa4/Example/Storyboard-Example/ExampleFolioReaderContainer.swift#L12
Is it possible to do the same with the WebView or the only way to do it is forking the repo and making the changes in my own repo?
Thanks in advance!

@hebertialmeida, thanks a lot for useful reference!
Closing the issue.


Apply mdc-line-ripple only for Filled select type.

A visual underline artifact was present when using the outlined select type due to  being applied. Per the documentation, this span is not used for the Outlined type.

Good spot. Thanks for the PR.


⚠ PrivateHD has degraded performance

In 85ddf4c, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 2686 ms

Resolved: PrivateHD performance has improved in ed71d0d.


AnvilLoader fails to properly load chunks with a section that contains exactly 1 or greater than 4 distinct biomes.

If a ChunkSection contains exactly 1 biome type across the entire section, then it will always be loaded as the biome with ID 0 (generally Biome.PLAINS unless that has been overridden) rather than the biome that it is supposed to be. Additionally, if a ChunkSection contains 5 or more distinct biomes, then the entire chunk fails to load due to a java.lang.IndexOutOfBoundsException originating from line 158 of org.jglrxavpok.hephaistos.mca.ChunkSection.<init>. Both of these issues are caused by incorrect handling of the biome palette, and I have detailed the issue and solution on Issue #23 on the Hephaistos repo. I would submit a PR to resolve the issue, but I am not familiar with Kotlin, and I would not know how to properly test the fix.

Version 2.4.6 of Hephaistos has now fixed this.


Add Port Option

It would be helpful if the port (8082) could be customizable so that multiple cavy instances can be run at once.

https://github.com/pixielabs/cavy-cli/pull/26 PR for a solution


Cleanup utils

Breaks up vane.util.Util into multiple classes
Removes the duplicated utils in vane-waterfall
Prevent potential NPEs in resolve_skin/resolve_uuid

Is there a preferred naming style for classes in util? Should they all have a Util suffix?

Thanks for your PR!
There isn't really a preferred style. When I started this project I didn't anticipate to have that many utils, so they just grew into the state they are at now :P
I'd also happily accept this PR, but I am wondering how you plan to combine the waterfall utils with the vane utils? As the waterfall plugin is started on the proxy server, it has no access to classes from the vane-core package (which is why they were duplicated, because I was lazy). Are you going to shadow them into the waterfall plugin?

Ah, sorry it's not often I work with Java :sweat_smile:. Is shadowing the best thing to do here?

I feel you, the ecosystem isn't great.
Shadowing definitely is an option, but don't ask me how to shadow a single file from another project :P
Symbolic linking might be the easiest way to achieve deduplication.
I'm sure there are a plethora of ways to do it directly in the build.gradle, but I won't really be able to help you there. I'm not overly proficient in writing such specific gradle things.

I just added the utils back to waterfall for now. I gave it a shot, but gradle is too crazy of a beast for me :smile:.

Hey, I'm not too familiar with clang-format. I just ran it and the diff is pretty large.
The command I'm using is: clang-format -i vane-waterfall/src/main/java/org/oddlama/vane/waterfall/*.java
Am I doing something wrong or is the formatter just not used often?

No you are not doing it wrong. We were previously using spotless to format the code, but using it just for formatting was  discontinued upstream, which meant we had to abandon it after the switch to Java 17.
When I'm programming I just use the autoformatter of my language server (eclipse.jdt.ls with neovim), so you can just ignore it. Next time is open those files they will get formatted. :)

Thanks!


Research Next.js hot reload performance

Hot reload is taking too long which affects the UX quite a bit. Research why it is taking so long and if there is any way of making it faster.

When change is done (i.e add a property to a component) there is a doOperation request that is done to API to manipulate the metadata, the project then does a full reconcile of file system and finally the next server is restarted. In the frontend this trigger of operation is locked to a debounced mechanism that is triggered when there are no more changes in the property for 300ms.
This debounced mechanism is responsible to prevent multiple unwanted operations that might be redundant or part of a final operation (i.e editing a text content from a text primitive). This constitutes an overhead of at least 300ms before the server is rendered. To tackle this limitation an different approach should be followed:
Decouple doOperation actions from render actions: The render action should be done in a AOT render style for when a change occurs, the application tries immediately to render it. If a new change is detected this mechanism should cancel the previous render request and start a new one. This would constitute an "elastic debounced" approach where the time it takes to render the changes is the tick of change's listener.
Regarding the reconcile approach, today when a change to a component is done there is a call to the same mechanism used when you load project which tries to validate all the components from the metadata (used preload() hook). This also constitutes a smaller overhead since its coupled with how much components a project has, in tests with production grade projects I'm getting values between 50ms and 150ms. This could be improved if only the changed components were required to be checked by the FSGen.
Other issues:
While investigating this case I was able to identify an issue with the paths of the files in the project. If a project is opened in a windows machine, the Cluch folder is in a absolute location (different from unix systems that rely on the ~ [home] folder) that are being uploaded to the project with that absolute path, making a copy of it when you open the project in an unix system.

The debounce on operations is not really to debounce the work since the work to be done is done in a queue fashion. The issue is with creating thousands of similar operations that then need to go into the server. Ideally these should merge if they have the same purpose, this would be done in the operation manager that already defers the communication of operations to the server.
As to hot reloading, that needs to be handled by next, if the fs gen is fast and all that is working efficiently, then it should be up to the hot reloading to handle it fast. a good one would be to try out next turbopack and see if we can already use for projects and see if it has big performance benefits.
As to the fs gen, checking if certain components fs should be reconciled should be fast unless that mechanism is broken somehow.

If I understand, regarding the doOperation mechanism we would insert the wanted renders in said operations queue but pre-process them before sending the request to API, clearing/merging changes that are redundant, reducing this way the number of done operations but keeping them coupled with render process (possibly overcoming any synching issues that might arrive if we went for a AOT render process?
Regarding the hotreload. I have 2 separated behaviours atm. If I change a property on a component this render is not triggered by a file system watch trigger but instead uses a memoized change on project metadata: https://github.com/clutch-creator/creator/blob/development/packages/core/src/features/creator-project/manager/hooks.ts#L105
The fsGen part was already optimized to work with nodejs runtime in parallel (as a worker process) instead of being done in the DOM itself. It has a cache validation that is fairly fast (also done in parallel agains the required file array). The quirk I found here was a BUG I believe that included more files than it should (referring to the windows issue with files in C:\.... The optimization was instead of sending an event to reconcile every file (even tho most of them are already cached), we could send only the required ones based on the changes made.


Same hash for integer

Hi
I try to generate random hash as
var md5 = require('MD5');
var dt = (new Date).getTime();
var hash = md5( Math.floor((Math.random() * 100000) + 1) +  dt);
//hash = d41d8cd98f00b204e9800998ecf8427e[always]

But it shows the same hash even the dt and random numbers are different.
i solve this by converting the random integer to string by appending toString():
var dt = (new Date).getTime();
var hash = md5( (Math.floor((Math.random() * 100000) + 1) +  dt).toString());

It looks like in it's current state md5(12345) and md5('12345') will still return different results. I am wondering if this is due to the fact that Strings get converted into byte arrays and integers are not. What is the expected outcome?

Calling md5 with something different than strings or buffers is undefined behaviour.
Tobias Haar<EMAIL_ADDRESS>schrieb:

It looks like in it's current state md5(12345) and md5('12345') will still return different results. I am wondering if this is due to the fact that Strings get converted into byte arrays and integers are not. What is the expected outcome?

You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/pvorb/node-md5/issues/3#issuecomment-221966565

the result of md5(12345) and md5('12345') should be same, i don't understand why not now; if the message is not strings or buffers, it should be converted to string at first, and then return the md5 value


[medAbstractWorkspace] rm last layer removes also the view

In Layer settings, when you removed the last layer, there was an empty data displayed on the view. This PR allows to clean and remove the view when there is no data left on the view. I removed also the call to
updateLayersToolBox() because it's automatically done.
:m:

OK


Rewrite dask.array.reshape

It now handles more cases efficiently, including the one identified in #1468. I think I've now covered every scenario where it's possible to reshape in contiguous order by calling np.reshape on each chunk, but I haven't proved it.
In cases where we cannot reshape without creating a ridiculously large number of tasks, it now fails noisily with a ValueError.
This is a breaking change, but one that I think will result in a better user experience. Let's save it for a major dask release (0.11?).

Looks like this is failing only due to a flake8 issue

Fixed the flake8 issue.

This looks fine to me.  The increased test suite around reshape is encouraging.  I admit that I haven't read through this in any particular depth.

My main concern is the design choice to fail hard instead of proceeding slowly in cases that can't be handled efficiently.

Is this a consistent with the behavior of other dask operations? I think so, though I don't think there are any similar examples in dask.array.
Is there a better error message than ValueError that we should be raising? Maybe dask.array.ChunkingError?

Given that bad performance is often very bad in these settings I'm usually pretty happy about failing hard with informative exceptions.  I'd much rather be clear about what we can't do than have people complain that we're slow.

Defining a ChunkingError seems reasonable.  The NumPy ShapeError seems to be well used.

The NumPy ShapeError seems to be well used.

I don't think NumPy has ShapeError

In any case ChunkingError should clearly inherit from ValueError, so we can add that later.

I don't think NumPy has ShapeError

Well now I feel dumb.  Curious now what I was thinking of.

I'm slightly allergic to custom error classes, but could be persuaded to include one here if it'd be useful to users to distinguish this error from others. I do agree with Matt that failing on cases that can't be done efficiently is preferred.
Is there anything else to do here? This lgtm.

I'm slightly allergic to custom error classes, but could be persuaded to include one here if it'd be useful to users to distinguish this error from others.

I think there a few other cases where things fail because of mismatched chunks. I like custom error classes for these sorts of use cases because they are an example of a specific class of errors with a standard solution. In this case, create or rechunk your array to use different chunks. Python 3 has quite a few of these. It's true that this is less common in the PyData space, though.

Is there anything else to do here? This lgtm.

I wasn't quite sure on your release schedule for dask. Merge this now would preclude patch releases.

There are already enough big changes since the last release that the next one shouldn't be a patch release (IMO). I'd be fine with merging this as is.

Agreed.  I think we should bump minor version.
On Tue, Aug 16, 2016 at 6:52 PM, Jim Crist<EMAIL_ADDRESS>wrote:

There are already enough big changes since the last release that the next
one shouldn't be a patch release (IMO). I'd be fine with merging this as is.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/pull/1469#issuecomment-240264104, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszDQbdE8Fc-XR0zNXE3ZyfjIosSsVks5qgj8cgaJpZM4Jj2sT
.


Implement equality checks for data structures

Currently we do not implement custom equality checks for our data structures (including all core data structures such as ParseItem, Expression, ValueExpression and Token (including all implementations) as well as interface data structures such as Environment, Source, etc.)
A major problem with this is that we do a == check on Source in cycle detection. This is simply wrong, because the check should determine whether two sources lead to the same state -- which means that two different instances of the same underlying objects such as environment or dataExpression should be determined as equal.

Some things left to do:

Get code coverage back to 100%.
Consider removing CurrentOffset or handling the empty case.
Determine how to handle classes without fields that now return a constant in hashCode().


Feature request: allow "gem" subcommand

I use brew-gem to manage my installed Ruby gems with homebrew, but when I put gem install somegemname on a line in a Brewfile, I get Error: Invalid Brewfile.
Can you make these two great tastes taste great together?

What's the advantage of brew-gem over a Gemfile? I'm hesitant to support this given that Gemfiles do a much better job here.

My understanding is that by using brew-gem, gems are installed in the Cellar and are much more self-contained than they would be if installed via gem directly. I would regard supporting brew-gem in a Brewfile as analogous to supporting homebrew-cask.

I think we'll pass on this as out-of-scope, sorry!


MySQL Multiserver & Sync UUID players

Hello,
I am using MySQL as a database for the synchronization of claims and some other things that are saved and I have encountered a big problem.
A premium user M4M3R71C0 with UUID 91ccf1ba-84e5-4ef2-a744-3605195c4e61 claims X kits (Ultra, Legend, Titan) for example. This same user a few hours later changes his name to WhySoDumm and rejoins the server.
Using UUIDs v4, the user's progress continues as the UUID remains the same. This user can request ALL kits in a totally unlimited way except the ones he had requested.

This image is a real case, the user can request all the red kits in an unlimited way (/kit claim ultra, you change server and request it again, you don't have cooldown). ELITE and BANDIDO kits still have the cooldown.

Perhaps the ideal is to apply COMPELTO support for UUIDs. I hope you can solve the problem.

UPDATE!
I'm checking and apparently if on the same server you try to request the kit twice, it won't let you. You have to go to another server to be able to use the bug. It only happens to you user who has changed the name being premium with uuid v4.


LNP-943: 🔥  remove field_not_in_series filter when querying for content within a category

Context

Does this issue have a Jira ticket?

https://dsdmoj.atlassian.net/browse/LNP-943

If this is an issue, do we have steps to reproduce?

N/A
Intent

What changes are introduced by this PR that correspond to the above ticket?

Removes unnecessary filter.

Would this PR benefit from screenshots?

No
Considerations

Is there any additional information that would help when reviewing this PR?

No

Are there any steps required when merging/deploying this PR?

No
Checklist

[x] This PR contains only changes related to the above ticket
[x] Tests have been added/updated to cover the change
[ ] Documentation has been updated where appropriate
[ ] Tested in Development

This is not yet tested on dev, but the query was run with and without the filter locally for ten sample categories, and the results were identical for each.


CX Potential_Usage_of_Vulnerable_Log4J @ packages/sub/pom.xml [master]

Potential_Usage_of_Vulnerable_Log4J issue exists @ packages/sub/pom.xml in branch master
The Log4j dependency set in packages\sub\pom.xml at line 35 contains known vulnerabilities and should not be used.Similarity ID: -2144876778
Severity: Information
CWE:400
Checkmarx
Training
Recommended Fix
Lines: 35

Code (Line #35):
<dependency>

Issue still exists.

Issue still exists.

Issue still exists.

Issue still exists.

Issue still exists.

Issue still exists.

Issue still exists.


how to implement FPN+Trident?

Hello,
It is noted that the FPN+Trident code is not included in this rep.  May I have any suggestions for
reproducing corresponding results as indicated in the original paper.
Thank you! 😃

The original paper does not report any result of FPN + Trident.


Conflicting algorithm is used to calculate pipeline name

Describe the issue
A conflicting algorithm is used to calculate pipeline name
Some code/tests are looking for it at
pipeline_definitions['pipelines'][0]['app_data'].pop('name')

But pipelines are using it as:
pipeline_definitions['pipelines'][0]['app_data']['properties'].pop('name')

@lresende the pipeline-editor package doesn't make use of the pipeline name field, but the elyra extension sets it here: https://github.com/elyra-ai/elyra/blob/a31afee97c716feacec1b43feee66b119de71397/packages/pipeline-editor/src/PipelineEditorWidget.tsx#L258
pipelineJson.pipelines[0].app_data.properties.name = pipeline_name;


Thank you!

This is not a bug report, but it's important enough to make an issue :stuck_out_tongue_winking_eye:
I am an open source maintainer myself and I know that most people only get in touch when something doesn't work.
So here's the other way around: it works wonderfully and allows me to write powerful macros :smile:
So at this point I just want to say: Thank you very much! ❤

Cheers -- I appreciate the note.


Moved constants to separate file

Added comment for updating 2.8888 to 2.76
Updated baseline b0 multiply value to be clearer

Do the BLC dates still match with 2.76?

they should since IIRC we manually overrode the param in the notebook but will double-check.


Placeholder in error: Cannot determine executable for debug adapter '{0}'.

This error message doesn't get its placeholder replaced correctly:

(Don't worry about the reason for the error; that's my fault; but the message should have the ID in it!)

Verified by code review.


shadow cljs fix

I believe that this fixes https://github.com/clojure-emacs/clj-suitable/issues/15. I'll test this some and would invite others testing as well.

Looks good to me as well - at the very least this is no longer going to blow up with shadow, even if it turns out the completion doesn't work properly. I guess @thheller can potentially confirm if we're using the right shadow-cljs API right now.
Other than this - seems you've reflowed the entire README (I see most like breaks are gone), so it's hard to understand what are the documentation changes, but I'll assume those are fine.
I was thinking it will be nice if there was a section in the docs about hacking on suitable - should be useful to potential contributors.

One more thing - if this API didn't exist before shadow 2.10, we should probably guard against this and just return an empty list of candidates.

LGTM. I'll make sure that cljs-eval API fn stays alive and functional.

@bbatsov the pure diff of README.md, only minor changes. Sorry the line breaks did bother me.

I saw you already cut 0.4, so I guess it's time to merge this branch. Big thanks for working on this!


Customize "composer install"

Currently the following command is executed in the Installing binaries and runtimes step:
composer install --no-interaction --prefer-source
I'd love to have an option to customize this. For development I need this:
composer install --no-interaction
For production I need this:
composer install --no-interaction --no-dev --prefer-dist --optimize-autoloader

@tylerflint @notxarb could you have another look at this? Currently starting boxes takes ages since every package is cloned instead of simply downloaded via dist.

I've just applied this change to my fork and box startup is now a lot faster.
For now I'll use engine: mbrodala/nanobox-engine-php in my boxfile.yml but of course, this only a temporary solution.

@mbrodala This looks good to me. I'm curious why we have the --prefer-dist in the command by default. @notxarb do you know?

From composer docs:
--prefer-dist: Reverse of --prefer-source, Composer will install from dist if possible. This can speed up installs substantially on build servers and other use cases where you typically do not run updates of the vendors. It is also a way to circumvent problems with git if you do not have a proper setup.
I think we ran into issues of asking if you wanted to add a key to the known hosts file, or if the ssh key has a passphrase. The prefer-dist avoids those issues.

Any updates on this? How about allowing customization through the boxfile.yml?

That's a great idea. @notxarb any objections?

I don't have any objections to allowing a custom command for composer

@notxarb please rethink about that. we use external projects where composer fails without --no-dev I know that the issue needs to be fixed in the project itself - but as a workaround it would be great to add custom commands or run composer by hand in the nandbox.

I think this could be a fairly simple change. We could leave the current composer install command as a reasonable default, but let users override it with a boxfile.yml config where they just pass custom composer install arguments and flags. This would only customize the composer install command that runs during the build. All other composer commands would just need be added as extra_steps.
run.config:
  engine: php
  engine.config:
    composer_install: --no-dev --prefer-source --optimize-autoloader
  extra_steps:
    - composer dump-autoload

@sanderson I'm not sure this is enough, at least I don't see how I could set two different commands for local and build.
And composer dump-autoload is not necessary, composer install does this automatically. ;-)

Local is what we call "build", whereas production is what we call "compile". For the compile phase, you simply add:
deploy.config:
  extra_steps:
    - composer install --no-interaction --no-dev --prefer-dist --optimize-autoloader

and Composer will clean up your dependencies at that point.

Thanks @mbrodala, I was just dropping random flags in as an example. @danhunsaker, is the deploy.config > extra_steps > composer ... included by the engine? If not, I wonder if it should be.

I don't believe it is, no. Not all projects care about dev versus prod dependencies, but re-running the install command during compile, with --no-dev added, is very much a sane default.

I also think it would be good practice to put in there, people who care about dev/prod dependencies no longer have two include extra's in their boxyfile.yml while the people who don't care wel... they don't care.
Another way to make it easier would be to allow importing of snippets into our boxfile.yml. 😄

@danhunsaker Good idea, the overhead should be minimal since Composer only needs to remove packages which where installed on build already.

Hi all! I would like to know the status of this feature. The implementation on feature/custom-composer looks pretty good!
Also I would like to ask if it will be possible to add hirak/prestissimo globally to speed up composer install.
Thanks for your work!

I think this just got lost in the shuffle of everything going on at once, honestly. We'll review this again Monday (in about 32 hours, give or take, from when this comment gets posted), and probably get it merged. We'll still have to evaluate the compile hook described above, before including it as well.
As to the Composer plugin you linked above, could you open a separate issue for that one, so we can properly explore that idea in full? Thanks in advance!

Any updates on this? The current method of composer cloning all the dependencies takes a long time.

how is this issue going ? I'm super interested in having the custom options for composer

This is now available through the composer_install engine config option
run.config:
  engine: php
  engine.config:
    composer_install: 'composer install --prefer-source --no-interaction'

Resolved by adfe8277abd9e8363f3d53b4a8ef044b3e8550ae


Include SUPIR  in SwarmUI

SUPIR is the best upscaler but requieres a olot of VRAM,  the option of include supir with optimization with an inpainting options, checkpoints and loras will be incredible
Thanks

Specifically this feature should add recognition for this Comfy node pack: https://github.com/kijai/ComfyUI-SUPIR
I note, recognition and not an autoinstaller - that license looks very unfriendly

@mcmonkey4eva WDYT? 🤔🙏