test(#2374): provide a framework to easily unit test processing elements

Added a couple of features to the test executor.

Option to provide custom configuration. TestComposeProcessor required to set output strategies and TestMergeByTimeProcessor required to set output key selectors.
Mocked mockParams.getModel(). Required for processors of type StreamPipesDataProcessor, which generate their own extractor based on the graph provided
Updated event creation to detect the prefix in the map keys and parse it properly

Refactored all tests in streampipes-processors-filters-jvm to use the executor
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no

Thanks a lot for the PR and updating the old tests. I really appreciate your effort in improving the testing framework step by step.
While reviewing the current version, I have some minor comments that I think could enhance the overall clarity and cleanliness of the codebase:

Regarding the ProcessingElementTestExecutor, I'm not entirely convinced if adding a separate method to validate an exception is thrown is the best approach. Instead, I suggest that the test asserts that an exception is thrown. This adjustment would make the API cleaner, as it would prevent the expectedOutputEvents and invocationConfigs parameters from consistently being empty or null. What are your thoughts on this?

Additionally, I believe we can make some improvements to the API of ProcessingElementTestExecutor. Currently, all methods are static. My suggestion is to make these variables non-static by passing them into the constructor. This approach would allow us to provide different constructors if certain parameters must not be set. Specifically, I propose adding IStreamPipesDataProcessor processor, Map<String, Object> userConfiguration, and Consumer<DataProcessorInvocation> invocationConfig as constructor parameters. Consequently, the run method's signature would be updated to accept List<Map<String, Object>> inputEvents and List<Map<String, Object>> expectedOutputEvents. What do you think of that?

Please feel free to respond to the comments, especially if you have a different opinion.
As soon as we have cleaned up the API a bit, we can think about how to remove the stream prefixes from the tests.  These currently make the tests somewhat difficult to read

@tenthe Suggestions make sense to me. Made the updates

@IsaakKrut, thanks for the changes.
I'll merge this PR.
As a next step, my suggestion would be to move the ProcessingElementTestExecutor into the module streampipes-test-utils. You can add a new package there.
Furthermore, I would suggest to write a builder to create the userConfigurations. Within this builder we will hopefully be able to 'hide' the prefix information of event streams.
@IsaakKrut, do you want to provide a suggestion for the design of such an API?
Do you want to create an issue for this or shoud I do that?

@tenthe I created issue #2737. Could you assign it to me?


[Bug]: .create doesn't return extended and merged values

As you can see from the screenshot, the fields in WithDefautTimestamps and WithDefaultId are not being returned immediately are using the .create method
I have updated my demo repo with a new branch
 to reflect these changes

Update:
Looks like it had nothing to do with using zod's .extend or .merge but because i defined default values for them. If you manually set these values when creating a new entry, they get returned back upon creation
Here's the code and terminal output of a case in another project

Code

terminal output

VS

thanks for opening this issue! Just to clarify, the if the values have a default value, the  default values don't get returned when calling .create?

thanks for opening this issue! Just to clarify, the if the values have a default value, the default values don't get returned when calling .create?

Yes, if the fields have a default set, they don't get returned. You have to manually set them when creating a new entry

Hello, this is fixed in the newest commit! Thanks for opening this issue :)

Hello, this is fixed in the newest commit! Thanks for opening this issue :)

Hey, thanks. I can confirm that this issue has been fixed in v0.1.4


Inconsistent sidebar styles

Issue #1: The problem was occurring because in two places in the sidebar the names had an underscore separator rather than a hyphen. They were being interpreted as a new class, rather than belonging to a class already defined in the stylesheet. I changed the two lines so that they include the correct hyphenated class.

Nice work!
FYI https://help.github.com/articles/closing-issues-via-commit-messages/


Scrapper, Maria Bukina - 22FPL2

No activity in PR. It is good time to start working on lab assignment

No activity in PR. It is good time to start working on lab assignment

nothing to review

Nothing to review today.

Nothing to review today.

Nothing to review today.

Nothing to review today.


Add new pillar variables to the documentation

... and change BitBound to BitHound.
Some of the pillar variables are new (the python_ ones), and some I added since I was going to delete them from the margarita README, so wanted them documented somewhere.

One optional suggestion and :shipit:


Allows a variable number of arguments to be passed into git hooks.

Fixes #45.
This has been tested with a custom script using the git hook prepare-commit-msg, which takes up to three arguments. This test script has not been included in the pull request.
Not taking #77 into consideration, both the custom prepare-commit-msg python script and the already existing post-rewrite python script work with git hooks, despite the fact that they take different numbers of inputs.
(As an aside: my commits from the very beginning of my involvement are appearing in this PR thread, is this normal?)

Perfect, thanks. I think this was the easiest review I've ever done 👍


Update kops Linux Setup Step

Moving the downloaded kops binary in Linux to the path /usr/local/bin/kops requires privileged permissions, hence the need to add the sudo command.

/assign @steveperry-53

/lgtm
/approve


Math error in BinaryPower example in User Guide

The BinaryPower class in the Specialized Parameter types subsection of the user guide does not validate binary powers but merely divisibility by 2.
https://param.holoviz.org/user_guide/Parameters.html#specialized-parameter-types

Another issue is that this Parameter class does not respect None values.
If you want to keep this example based on param.Parameter you might update it to:
    def _validate_value(self, val, allow_None):
        if allow_None and val is None:
            return

        super(BinaryPower, self)._validate_value(val, allow_None)
        if not isinstance(val, numbers.Number):
            raise ValueError("BinaryPower parameter %r must be a number, "
                             "not %r." % (self.name, val))

        if (not float(val).is_integer()) or (val < 2) or (bin(int(val)).count("1") is not 1):
            # in Python >= 3.10 use `int(val).bit_count() is not 1`
            raise ValueError("BinaryPower parameter %r must be a power of 2, "
                             "not %r." % (self.name, val))

I would rather suggest to have the example based on param.Integer with default=2... but that does not read so well with the way this section is structured currently ?

Thanks for reporting this!
In https://github.com/holoviz/param/pull/634 I address this by keeping the correct code and changing the example to one that only allows even integers. The purpose of the docs here is to show that parameters can be defined easily and not to have people think too much about the precise validation logic itself.

Addressed in #634 which is now merged.


Fix #295

@daltoniam Please review.

Ah thanks! I'm going to merge this and run through some testing. Thanks again.


pre-commit: PR117118

Link: https://github.com/llvm/llvm-project/pull/117118
Requested by: @dtcxzyw

/add-label reviewed
/close


Add STS root folder override

Useful for debugging scenarios.
Steps to use (will document this elsewhere as a follow-up):

Publish STS project you want to debug (such as service layer). This is needed to get full set of dependent assemblies
Set ADS_SQLTOOLSSERVICE env var to publish path (e.g. C:\src\sqltoolsservice\src\Microsoft.SqlTools.ServiceLayer\bin\Debug\net5.0\publish
Launch ADS

Note that there are 3 "clients" that all come from the same STS folder. If any of them don't exist (because you didn't publish them) then it'll just fall back to using the normal STS install for those ones.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 42.034%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
26422

Relevant Lines:
56976

💛  - Coveralls


Refactor the ingress service for istio

Fixes #1206

I've confirmed that this works for me wrt. my issue reported in #1206. Thanks much @houshengbo!
Not sure if I'm bestowed with powers for this tag to matter, but /lgtm

/lgtm

/cherry-pick release-1.7

/cherry-pick release-1.7


Enhance markdown the ``` shortcut for code block

Currently, pressing "``` " converts paragraph to a code block (unless it is already a code block).
It also supports "```js " for a code block with language = 'js'.
We'd like this to be "```" + return where the return makes the conversion to code block. Current functionality should be retained:
i. undo should restore "```" and the return key.
ii. the "``` " with the space should continue to work.
iii. the "```" should only appear at the start of the non-code block paragraph and not in the middle of it.
When inside a code block paragraph, markdown is typically disabled.
However, when the user types "```" followed by a return, the code block should toggle off.  We could also trigger this with a space.  In either case the new paragraph should be converted to normal.
As a stretch, the user might also type the 3 ticks + return in the middle of a code block paragraph. In this case, the next paragraph should be made normal and the 3 ticks removed.
The following is prescriptive but suggestion only. The engineer should treat below as advisory only:
So, to implement this, we need to expand the current trigger. Currently, the trigger is a " " and defined as TRIGGER in the code.
We should alter this to be an enumeration of types:
type AutoFormatTriggers = whitespaceTrigger | newlineTrigger | codeBlockOffTrigger | codeBlockOffTrigger.

@zurfyx Is this resolved? I tried lexical and @lexical/markdown 0.7.6 and a code block is only created when I use a space after "```", not when I use a return.
See https://codesandbox.io/s/zealous-thunder-9zceu2 (I checked on latest Chrome and Firefox on macOS).

@kraisler ?


KeyError: 'address'

Hi,
thank you for your script. It is exactly what I needed :-)
I got exception parsing some YYYY_MONTH.json files:
`  File "/home/ts/RTS/googledata/semantic_location_parser.py", line 18, in process_file
address = obj['placeVisit']['location']['address']
KeyError: 'address'
So I added thisto semantic_location_parser.py in line 15:                 try:
address = obj['placeVisit']['location']['address']
except KeyError:
address = obj['placeVisit']['location']['name']`
regards
Thomas

So your replacing the name with the address if it does not exist? That works! if you'd like to raise a pull request feel free.  Wonder why that fixed i it. Can you paste the error you were receiving? I wonder if there's an additional key value that wasn't in my json it wasn't handling. if you'd like to raise a pull request feel free. Glad this helped you out

Hi,
this is the full error message I received:
`$ python semantic_location_parser_org.py
Traceback (most recent call last):
File "/home/ts/RTS/googledata/semantic_location_parser_org.py", line 47, in
main()
File "/home/ts/RTS/googledata/semantic_location_parser_org.py", line 44, in main
process_file(file_path, data_writer)
File "/home/ts/RTS/googledata/semantic_location_parser_org.py", line 18, in process_file
address = obj['placeVisit']['location']['address']
KeyError: 'address'
The csv file is filled correctly until the error `appears. I have 20 YYYY_MONTH.json files. 17 will be parsed correctly. Only with 3 of them I got the error. So I decided to add the exception handler for "address"


runner: add possible repetitive handler registerring check.

Just encountered this when testing the old and new versions at
the same by renaming the old handlerXX.so to handlerYY.so, and
forgot to make clean or remove them. But this won't report any
warning or error message.
Maybe my way doing the test is not very wise, but this could be
a potential bug.
Signed-off-by: Xiubo Li<EMAIL_ADDRESS>

updated with s/beed/been

Seems like a good idea to me. Thanks.


Navigation bar color does not work

I'm using your ApplicationChrome (https://github.com/zeh/unity-tidbits/blob/master/application/ApplicationChrome.cs) script.
I've set both status bar and navigation bar to visible, and I set the colors for both. The status bar color works, but the navigation bar color does not change from its default grey color.
I've also tried running your demo APK (http://zehfernando.com/d/2015/UnityAndroidChrome.apk), and it has the same issue.
For reference, I'm running it on an LG G6 running Android 7.0.
p.s. This script has been very useful. Thanks for releasing it 🎉

Just in case someone will come here in the future, this is how I managed to set custom color for navigation bar:
ApplicationChrome.statusBarState = ApplicationChrome.States.TranslucentOverContent;
ApplicationChrome.statusBarColor = ApplicationChrome.navigationBarColor = 0xff222222;

The caveat is that you must have statusBar at Translucent.

Thanks for the answer @AVAVT.
Agreed that the API is somewhat confusing - it does have to be translucent. Android's UI flags are weird...
I'm working on a revision of the library and will hopefully have a more clear API.
For now, I'll close this as I think there's no additional changes needed.


[QIP][DAITO] Clean uninstall doesn't stop Dashboard container

Describe the bug
If an existing dashboard container is there with different version, cleanup creates new dashboard container (with different image version) but doesn't stop it as other version is already running
To Reproduce
Installed OpenSDS from Installer v0.10.0
Removed the dashboard image (though by mistake)
Installed "latest" version (dashboard:latest) manually
Now executed cleanup of installation
Cleanup went fine
Installed again
Now the dashboard does not comes up as there is another version (latest) already running. But ideally the dashboard v0.10.0 container should go in stopped state.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
TASK [telemetry-uninstaller : clean all created work directories] ****************************************************
task path: /root/gopath/src/github.com/opensds/opensds-installer/ansible/roles/telemetry-uninstaller/scenarios/clean_telemetry_tools.yml:101
skipping: [localhost] => {
"changed": false,
"skip_reason": "Conditional result was False",
"skipped": true
}
META: ran handlers
META: ran handlers
PLAY RECAP ***********************************************************************************************************
localhost                  : ok=13   changed=10   unreachable=0    failed=0
root@aks:~/gopath/src/github.com/opensds/opensds-installer/ansible# ansible-playbook site.yml^Ci local.hosts  -vvv
root@aks:~/gopath/src/github.com/opensds/opensds-installer/ansible# docker ps -a
CONTAINER ID        IMAGE                         COMMAND                  CREATED              STATUS              PORTS               NAMES
b99454007fb5        opensdsio/dashboard:v0.10.0   "/bin/sh -c /opt/das…"   About a minute ago   Created                                 dashboard
acca40a16122        opensdsio/dashboard:latest    "/bin/sh -c /opt/das…"   8 minutes ago        Up 8 minutes                            opensds-dashboard
root@aks:~/gopath/src/github.com/opensds/opensds-installer/ansible# docker ps
CONTAINER ID        IMAGE                        COMMAND                  CREATED             STATUS              PORTS               NAMES
acca40a16122        opensdsio/dashboard:latest   "/bin/sh -c /opt/das…"   8 minutes ago       Up 8 minutes                            opensds-dashboard
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

This issue is fixed in PR #332

Closing as fixed


Do not post close callback in ops queue if not started.

Ops queue is started in Bind(). If Close() is called
when bind did not happen (because the underlying peer connection
closed before bind), the close callback does not run.
Check if ops queue is running before posting close callback
into the queue.
Not pretty, but covers this case. Need to think about it more.

@cnderrauber I am avoiding it because of potential leak. It is possible to create an sfu/DownTrack and then something else fails down the line, like adding track to peer connection fails or something else. In that case, that object is not closed. So, the callback queue goroutine will just hang. So, starting the queue carefully only when we know that close will be called.


Request: Ability to turn the fingerprint LED off completely

The fingerprint/power LED can be controlled thanks to the work done in #9. Being able to set this to "low" is very much appreciated, but it would be nice to have to option to turn it off completely.
Is disabling the LED completely possible?

That's an interesting idea.
But one of the purposes of the power button LED is to let you know whether the system is awake or asleep.
When the system is asleep/suspended the power button LED shows a breathing animation. If it's always off, you can't distinguish between the system being asleep or just screen off.
Please help me understand the reason and situation in which you'd like to have the LED turned off completely. Maybe we can figure out a good solution.

The reason I'd like to have the LED completely off is that in the dark, even low brightness is pretty distracting and un-easy on my eyes, particularly when using dark themes or watching movies, where you generally don't want other sources of light interfering with your viewing experience. I usually disable the keyboard backlight as well in those situations, so having a light that can't be disabled there is a bit of a bummer.
The suspend situation you described is definitely a trade-off though. For me, it's one I'd be willing to make, as it makes my general usage much more pleasant, and my laptop is set to wake from suspend when I open the lid, so I don't have to worry about the indicator being a source of truth for that. I figure that mostly anyone using the input module CLIs would be pretty aware of any configurations that they've done in that regard and adapt their expectations for how the light behaves accordingly.
Either way, thanks for your response and consideration!

Alternatively, if an "off" mode is considered to be too niche of a request, maybe offer an "ultra-low" mode that illuminates the LED at the lowest possible value it can be while still being on. This would be a compromise for me, as I'd still like to remove any extraneous distractions from the screen when using it in low-light environments, but it's an improvement.
Another alternative might be to allow adjusting by percentage values and letting people set it to 0%, but I'm not sure if the underlying firmware supports that or how much additional work would be involved in making that work.


[HOTFIX] ZEPPELIN-2221's dependency issue

What is this PR for?
Fixing some CI by changing hadoop-client version of ₩spark_coreandguavaversion ofzeppelin-python. We basically remove zeppelin-pythondependency fromzeppelin-spark` interpreter in a near future.
What type of PR is it?
[Hot Fix]
Todos

[x] - Fix dependency problem between hadoop-client and guava

What is the Jira issue?
N/A
How should this be tested?

It should pass CI

Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

@zjffdu I've fixed a dependency issue by upgrade hadoop-client of spark_core. Please review and merge it. https://travis-ci.org/jongyoul/zeppelin/builds/389071799

Thanks @jongyoul LGTM, will merge soon


Add builds on Python nightly

Some import errors on current Python nightly (3.6.0a0).
Might be better to allow failures in this env, but maybe worth trying without.

Hi,
Can't say I'm massively interested in tracking Python nightly builds.
What's your use case?
Chris

I'm just interested in knowing whether there is anything coming up in the future.

Okay, I'm afraid I'm not when it comes to alphas.


Password recovering

Hello Chrislee,
I am reporting some trouble that I have got with this bot. I have some issues with the password to access the front-end.
I was asked to enter my password before accessing the page. But I forget the password then i tried several passwords now I am blocked. How can I solve this problem ?
Thank you

here is what i got when accessing the front-end.

Ok i will check and close the issue when i'm satisfied!

Here is my docker-compose.server.yml, there is no password in there.
In my .env content t

here's no session for authentication  like this:
Authentication
BINANCE_AUTHENTICATION_ENABLED=true
Please set your own password.
BINANCE_AUTHENTICATION_PASSWORD=123456
BINANCE_JOBS_TRAILING_TRADE_BOT_OPTIONS_AUTHENTICATION_LOCK_LIST=true
BINANCE_JOBS_TRAILING_TRADE_BOT_OPTIONS_AUTHENTICATION_LOCK_AFTER=120
The file is only limited to :
Feature Toggles
BINANCE_FEATURE_TOGGLE_NOTIFY_ORDER_CONFIRM=true
BINANCE_FEATURE_TOGGLE_NOTIFY_DEBUG=false

Here's the terminal output

I didn't find any password in docker-compose.server.yml and not authentication session in .env file.
Thank you!

If you didn't set, it will be default password.
https://github.com/chrisleekr/binance-trading-bot/blob/master/config/default.json#L43

Yes good i have got access using the default password but the UI is not coming. I only see a blank page.

I have the blank page don't see the UI.
Thank you

Issue solved !
Thank you for assistance.


Aws endpoint

Ref: https://github.com/DigiThinkIT/frappe/pull/269

Pull Request Test Coverage Report for Build 1078

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-49.9%) to 0.0%

Totals

Change from base Build 1066:
-49.9%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls


[#1857] Add batch get interface

Introducing missing Interface for BatchGet
Description

Motivation and Context

Testing

Screenshots (if appropriate)
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[ ] I have read the README document
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

License

[ ] I confirm that this pull request can be released under the Apache 2 license

Closing this PR as we don't explicitly implement an interface for this class


Suggestions for additional environments

[ ] Sokoban (see DeepMind's boxoban)
[ ] N-puzzle
[ ] Rush Hour

I have implemented this and will add to jumanji once we have experiments and required tests for the environment.

Can we have a Pickup and Deliveries environment something similar to this https://developers.google.com/optimization/routing/pickup_delivery ?

@chkda would CVRP work for you?


[FLINK-21158][Runtime/Web Frontend]  wrong jvm metaspace and overhead size show in taskmanager metric page

What is the purpose of the change
the size of jvm metaspace and jvm overhead  on taskmanager metrics page  not the derived value from flink-conf.yaml  but
always  be the default value.  This pull request is trying to fix it.   More details you can find in this link   FLINK-21158
Brief change log
adding JVM_METASPACE/JVM_OVERHEAD_MIN/JVM_OVERHEAD_MAX to TaskExecutorProcessUtils#generateDynamicConfigsStr
Verifying this change
This change is already covered by existing tests, such as TaskExecutorProcessUtilsTest#testGenerateDynamicConfigurations
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no) no
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)no
The serializers: (yes / no / don't know)no
The runtime per-record code paths (performance sensitive): (yes / no / don't know)no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)no
The S3 file system connector: (yes / no / don't know)no

Documentation

Does this pull request introduce a new feature? (yes / no)no
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)not applicable

@pengkangjing
Please take a look at the CI report. There's a compiling failure due to code style violation.
Please refer to the following guidelines on how to use the new code format tool.
https://ci.apache.org/projects/flink/flink-docs-release-1.12/flinkDev/ide_setup.html#code-formatting

@pengkangjing
Please take a look at the CI report. There's a compiling failure due to code style violation.
Please refer to the following guidelines on how to use the new code format tool.
https://ci.apache.org/projects/flink/flink-docs-release-1.12/flinkDev/ide_setup.html#code-formatting

@xintongsong   Another error seem to be not related to this change

@xintongsong   Another error seem to be not related to this change


handle additional gcc/g++ compiler flags

resolves #1366

Depends on #1508

We will keep the current behavior not to forward unhandled arguments just log them out for debugging.

This will be fixed in #1970


jhlite custom: ignore all children of a parent module

Fix #4338

I implemented the first request:

keep current property, and improve the behavior to exclude this module and all dependant module

The second request, I add a comment at the properties jhlite-hidden-resources.slugs and increment the documentation:

maybe, display the excluded modules at start, to avoid "silent" exclusions

@pascalgrimaud, could you tell me where do you want to display the hidden modules?

@renanfranca : maybe in the logs at startup, would be enough

@renanfranca : maybe in the logs at startup, would be enough

Thank you @pascalgrimaud , I ll try to do it 👍

Hello @DamnClin,
This jhispter lite custom module impressed me!!! It actually runs the original jhipister lite project (backend and frontend) only by importing it as a dependency with maven!
That makes me so curious that I've been studying it, I learn how to do it using a classifier tag  (here is the article: https://medium.com/publicis-sapient-france/import-spring-boot-application-as-a-maven-dependency-a25e03e5c3a ). But I didn't know how the hipster lite did it, there wasn't any classifier tag...
What I want to do is to generate an application using jhlite module and it could be able to run with my changes which weren't merged yet.
if you could point me in the right direction, I appreciated it 😄

What I want to do is to generate an application using jhlite module and it could be able to run with my changes which weren't merged yet.

mvn install on your branch on JHipsterLite
Generate an app with custom JHlite
Update JHlite version in your generated app to use the snapshot one you just built

Haven't tried it now but I think I remember doing it when working on that feature

mvn install on your branch on JHipsterLite
Generate an app with custom JHlite
Update JHlite version in your generated app to use the snapshot one you just built

Haven't tried it now but I think I remember doing it when working on that feature

I tried the ./mvnw install but it didn't install the jhlite-0.27.1-SNAPSHOT-test.jar and when I run the generated app with the snapshot I got the following message Failed to execute goal on project customjhlite: Could not resolve dependencies for project tech.jhipster.customjhlite:customjhlite:jar:0.0.1-SNAPSHOT: Could not find artifact tech.jhipster.lite:jhlite:jar:tests:0.27.1-SNAPSHOT.
When I looked at the maven local repository and compare the generated files of the jhlite-0.27.0 version, it was generated the jhlite-0.27.0-test.jat (image below)

I studied that the ./mvnw install should be enough to install the jhlite-0.27.1-SNAPSHOT-test.jar, Do you remember if have to do additional command?

Took a quick look to the test classifier and it was only built when deploying, dunno why it was done that way, did https://github.com/jhipster/jhipster-lite/pull/5381 to fix that, waiting for @pascalgrimaud approval

Took a quick look to the test classifier and it was only built when deploying, dunno why it was done that way, did #5381 to fix that, waiting for @pascalgrimaud approval

Nice! good to know 👍

@renanfranca : to ease the test, you can directly add the ignore in jhlite to test, instead of a jhlite-custom

@renanfranca : to ease the test, you can directly add the ignore in jhlite to test, instead of a jhlite-custom

Thank you @pascalgrimaud! 😃 👍

Hello @DamnClin and @pascalgrimaud ,
I pushed the logging hidden modules slugs feature 👍

Bounty Claimed https://opencollective.com/generator-jhipster/expenses/124093 😃 👍
Thank you @pascalgrimaud !
Thank you @DamnClin for the fast response and for being patient 😄

@renanfranca : approved, thanks for your work


Incident related changes

Please:
add missing optional attr ogit/ServiceManagement/resolvedInTime for entity ogit/ServiceManagement/SLA
remove edge ogit/Software/Connector => ogit/opens ogit/ServiceManagement/Incident
add edges:
ogit/Software/Connector => ogit/creates ogit/ServiceManagement/Incident
ogit/Software/Connector => ogit/creates ogit/ServiceManagement/ChangeRequest

Normally deleting something will affect an increase of first position of the version. If you are sure nobody else use this connection delete it without increasing first position of the version.

it was only created for ConnectIT purpose very recently, so yes absolutely sure! :-)

done


DITA-OT 2.1.0 TopicMerge fails when using DITA 1.3 schemas

TopicMerge fails with following message when using DITA 1.3 schema in DITA-OT 2.1.0.
[PDF2]
preprocess:

map2pdf2:
[topic-merge] Processing D:\My_Documents\XML2015\Jobs\20150807_ditaot_diff\temp\pdf\diff_20150807.ditamap
[topic-merge] Processing D:\My_Documents\XML2015\Jobs\20150807_ditaot_diff\temp\pdf\topic\c_first_chapter.dita
[topic-merge] Processing D:\My_Documents\XML2015\Jobs\20150807_ditaot_diff\temp\pdf\topic\c_before_driving.dita
[topic-merge] Processing D:\My_Documents\XML2015\Jobs\20150807_ditaot_diff\temp\pdf\topic\t_floor_mat.dita
[topic-merge] Processing D:\My_Documents\XML2015\Jobs\20150807_ditaot_diff\temp\pdf\topic\c_floor_mat_warning.dita
[topic-merge] Processing D:\My_Documents\XML2015\Jobs\20150807_ditaot_diff\temp\pdf\topic\c_for_safety_drive.dita
[topic-merge] Processing D:\My_Documents\XML2015\Jobs\20150807_ditaot_diff\temp\pdf\topic\c_correct_driving_posture.dita
[topic-merge] Processing D:\My_Documents\XML2015\Jobs\20150807_ditaot_diff\temp\pdf\topic\c_correct_use_of_the_seat_belts_in_safty.dita
[topic-merge] Processing D:\My_Documents\XML2015\Jobs\20150807_ditaot_diff\temp\pdf\topic\c_seat_belts.dita
[topic-merge] Processing D:\My_Documents\XML2015\Jobs\20150807_ditaot_diff\temp\pdf\topic\c_correct_use_of_the_seat_belts.dita
[topic-merge] Processing D:\My_Documents\XML2015\Jobs\20150807_ditaot_diff\temp\pdf\topic\c_second_chapter.dita
[topic-merge] Processing D:\My_Documents\XML2015\Jobs\20150807_ditaot_diff\temp\pdf\topic\c_warning_lights_and_indicators.dita
[topic-merge] Processing D:\My_Documents\XML2015\Jobs\20150807_ditaot_diff\temp\pdf\topic\c_third_chapter.dita
[topic-merge] Processing D:\My_Documents\XML2015\Jobs\20150807_ditaot_diff\temp\pdf\topic\c_keys.dita
[topic-merge] Processing D:\My_Documents\XML2015\Jobs\20150807_ditaot_diff\temp\pdf\topic\c_the_keys.dita
[topic-merge] null
[topic-merge] Error on line 108 column 276
[topic-merge]   SXXP0003: Error reported by XML parser: Attribute name "fi" associated with an element
[topic-merge]   type "topicref" must be followed by the ' = ' character.

Steps to reproduce:

Install DITA-OT 2.1.0 from https://github.com/dita-ot/dita-ot/compare/2.1...develop
Move plugins/org.oasis-open.dita.v1_2 to backup directory.
Install DITA 1.3 schema from https://github.com/dita-community/org.oasis-open.dita.dita13.doctypes/tree/develop
Modify the catalog file. https://lists.oasis-open.org/archives/dita-comment/201507/msg00001.html
Run PDF2 or PDF5 (https://github.com/AntennaHouse/pdf5) from oXygen

All of the data files and error log file can be downloaded from following URL:
https://www.dropbox.com/s/uc7yrvozsex65vs/20150807_ditaot_diff.zip?dl=0
Regards,
Toshihiko Makita

I've downloaded the sample zip and built with the upcoming 2.3 code.
The NPE no longer occurs with the DITA 1.3 document types that ship natively with DITA-OT 2.2 and 2.3.
The grammar file copies at dita-community were not the official copies; I suspect either they were out of date or otherwise out of sync with the OASIS versions. There is no error from the topic merge process, and the PDF is produced using the PDF2 transform type.


Faulty documentation: "The version property of the image must be set to **."

On page https://learn.microsoft.com/en-us/azure/virtual-machine-scale-sets/virtual-machine-scale-sets-automatic-upgrade
there is following description under "Requirements for configuring automatic OS image upgrade":
The version property of the image must be set to **.
This is faulty, ** does not work, must be "latest":
The version property of the image must be set to latest.
Please fix, thanks!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 51c75ce7-2144-d81a-693c-fb51cc00f3e5
Version Independent ID: cba654ea-ee84-fca4-a76d-717bfb9d9bf5
Content: Automatic OS image upgrades with Azure Virtual Machine Scale Sets - Azure Virtual Machine Scale Sets
Content Source: articles/virtual-machine-scale-sets/virtual-machine-scale-sets-automatic-upgrade.md
Service: virtual-machine-scale-sets
Sub-service: automatic-os-upgrade
GitHub Login: @ju-shim
Microsoft Alias: jushiman

@justenh1431
Thanks for your feedback! We will investigate and update as appropriate.

@justenh1431
Thank you for bringing this to our attention! We've initiated a pull request (PR) to address this issue. Once the author reviews the changes, they will be merged, and the updates should go live shortly. Your diligence is much appreciated!


addAutomaticKeepAlives missing from PageView and is causing children to be re-rendered unnecessarily

Steps to Reproduce

Create a widget containing a PageView
Add multiple children to the PageView
Add breakpoints to each build function of the children
Scroll between pages and watch the breakpoints being hit each time (even after already going there)

Logs

No logs provided as this is pretty self explanatory.
It is causing a lot of issues with state management solutions like flutter_redux as children with a StoreBuilder/Connector will always be rebuilt, even if the Store has not changed. Both ListView and GridView have this field addAutomaticKeepAlives, so it seems weird that PageView does not.

info - Unused import: 'package:alchemy/redux/actions/loading/update_state_loading_action.dart' - lib\components\edit_profile\edit_profile_view_model.dart:2:8 - unused_import
   info - Unused import: 'package:firebase_storage/firebase_storage.dart' - lib\components\images\upload_image_view_model.dart:9:8 - unused_import
   info - Unused import: 'package:path/path.dart' - lib\components\images\upload_image_view_model.dart:10:8 - unused_import
   info - Unused import: 'package:random_string/random_string.dart' - lib\components\images\upload_image_view_model.dart:12:8 - unused_import

[√] Flutter (Channel beta, v0.11.9, on Microsoft Windows [Version 10.0.17134.407], locale en-GB)
    • Flutter version 0.11.9 at C:\Users\ryand\Documents\flutter
    • Framework revision d48e6e433c (3 days ago), 2018-11-20 22:05:23 -0500
    • Engine revision 5c8147450d
    • Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)

[√] Android toolchain - develop for Android devices (Android SDK 28.0.2)
    • Android SDK at C:\Users\ryand\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.2
    • Java binary at: D:\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
    • All Android licenses accepted.

[√] Android Studio (version 3.2)
    • Android Studio at D:\Android Studio
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)

[√] IntelliJ IDEA Community Edition (version 2018.2)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2018.2.5
    • Flutter plugin version 29.1.3
    • Dart plugin version 182.4892.25

[√] VS Code (version 1.29.1)
    • VS Code at C:\Users\ryand\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 2.20.0

[√] VS Code, 64-bit edition (version 1.27.2)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 2.20.0

[!] Connected device
    ! No devices available

As a note, I know there is a "keepPages" field in the PageController, although this doesn't appear to work as it should be true by default anyway!

I minimal runnable reproduction would be helpful.

Thanks for reassuring me that I am not being stupid and that this is in fact weird Julian haha.
@zoechi Code can be found on my repo here: https://github.com/SKLn-Rad/PageView-Rebuild-Demo
Really weird part is that if I force the keep alive of page 3 by using KeepAliveNotification and I scrolled to it from page 2, then when I go back to page 2 it is not actually rebuilt. Seems like using that notification is actually preventing previous children from being updated; might be worth keeping this behaviour in other things like ListViews!

I assume https://github.com/flutter/flutter/issues/11655#issuecomment-348287396 applies here as well

addAutomaticKeepAlives is still missing  PageView class

in AutomaticKeepAlive documentation it says:

Allows subtrees to request to be kept alive in lazy lists.

Is PageView.builder not a lazy list in nature?
@TahaTesser right now trying to implement a video feed like TikTok/Snapchat/etc with PageView is impossible. Too much memory issues. Do you think this will be fixed? or any suggestions?

in AutomaticKeepAlive documentation it says:

Allows subtrees to request to be kept alive in lazy lists.

Is PageView.builder not a lazy list in nature?
@TahaTesser right now trying to implement a video feed like TikTok/Snapchat/etc with PageView is impossible. Too much memory issues. Do you think this will be fixed? or any suggestions?


make a copy of helix manager, so that each job can keep using it with…

…out worrying about disconnect
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-XXX

Description

[ ] Here are some details about my PR, including screenshots (if applicable):

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #3427 (ef825ce) into master (5bc22a5) will increase coverage by 7.91%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3427      +/-   ##
============================================
+ Coverage     43.29%   51.20%   +7.91%
- Complexity     2017     6838    +4821
============================================
  Files           402     1288     +886
  Lines         17325    47971   +30646
  Branches       2121     5363    +3242
============================================
+ Hits           7500    24564   +17064
- Misses         8987    21222   +12235
- Partials        838     2185    +1347

Impacted Files
Coverage Δ

...er/GobblinHelixDistributeJobExecutionLauncher.java

...pache/gobblin/cluster/GobblinHelixJobLauncher.java

...rg/apache/gobblin/cluster/GobblinHelixJobTask.java

.../gobblin/cluster/HelixRetriggeringJobCallable.java

.../org/apache/gobblin/util/limiter/MultiLimiter.java

...gobblin/cluster/ClusterEventMetadataGenerator.java

.../apache/gobblin/cluster/GobblinClusterManager.java

...blin/audit/values/auditor/ValueAuditGenerator.java

.../apache/gobblin/metastore/DatasetStoreDataset.java

...src/main/java/org/apache/gobblin/util/Sleeper.java

... and 1680 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bc22a5...ef825ce. Read the comment docs.


[Airflow chart] proper use of git secret for init-container / private git repo

Hi y'all,
I'm encountering an issue with the stable/airflow chart and was hoping someone may be able to point me in the right direction.
I'm currently using the following values.yaml file:
dags:
  initContainer:
    enabled: true
  git:
    url: git@github.com:org/repo.git
    secret: airflow-deploy-key
logsPersistence:
  enabled: true
  storageClass: efs
persistence:
  enabled: true
  storageClass: efs
postgresql:
  persistence:
    enabled: true
    storageClass: efs
redis:
  existingSecret: airflow-redis

in the attempt to pull DAGs from a private git repo, as noted in the init-container instructions for the chart. I've created an ed25519 key and added a k8s secret with the keys and known_hosts file:

but I get the following warning on helm install:
> helm install --namespace default -f airflow.yaml --name "airflow" stable/airflow
2019/08/22 15:21:15 Warning: Merging destination map for chart 'airflow'. Cannot overwrite table item 'secret', with non table value: map[]

and a few of the Airflow pods (flower, scheduler, web, worker) are all stuck in a Waiting: PodInitializing state. I get no meaningful logs on my pods, just a single line on each like:
container "airflow-scheduler" in pod "airflow-scheduler-5bc964468b-492c8" is waiting to start: PodInitializing
and I see the following events:

Output of helm version:
$ helm version
Client: &version.Version{SemVer:"v2.14.3", GitCommit:"0e7f3b6637f7af8fcfddb3d2941fcc7cbebb0085", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.14.3", GitCommit:"0e7f3b6637f7af8fcfddb3d2941fcc7cbebb0085", GitTreeState:"clean"}

Output of kubectl version:
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.3", GitCommit:"5e53fd6bc17c0dec8434817e69b04a25d8ae0ff0", GitTreeState:"clean", BuildDate:"2019-06-06T01:44:30Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"11+", GitVersion:"v1.11.10-eks-f12431", GitCommit:"f12431e9d92fa990fbbc2b52006351d381bd4bed", GitTreeState:"clean", BuildDate:"2019-07-26T01:16:21Z", GoVersion:"go1.10.8", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.):
AWS, EKS.

The warning you received was a YAML merging error:
Warning: Merging destination map for chart 'airflow'. Cannot overwrite table item 'secret', with non table value: map[]

secret has a default value of {}. You can see it here. In your YAML you have a string.
It looks like the proper format should be a string. You can see the usage here. I would suggest a PR against the airflow chart to fix this.

Great, thank you @mattfarina . Just to confirm, you're saying the default value of dags.git.secret should be:
secret: ""

Is that right?
I can definitely file a PR. Thanks for the quick help.


feat(bats): bats-libs, update file to 0.4.0 and add bats-detik

Description of changes
The Bats organization has another useful library called bats-detik under its umbrella. This library is used for Kubernetes end-to-end tests. This PR will add bats-detik to the list of supported libraries for Bats.
Please note the following:

Bats-detik is widely used and packaged like the other libraries.
It is normal to use bats_load_library bats-detik/detik.bash in the tests because detik does not have load.bash.
I have appointed myself as the maintainer for this library, as I am already responsible for maintaining some other bats libraries under other package/ci systems. However, I must clarify that I am not an expert in nix or nixos so If someone else prefer to become the maintainer I'm happy to switch the usernames :)
I would like to apologize in advance for any potential mistakes, as this is my first pull request in the Nix world.

Additionally, a new version of bats-file has been released and updated.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

We do not follow Semantic Commits. Get rid of it.

Sorry, yesterday I had to stop for some urgent matters, I have all the fixes ready, will push it later today

@drupol @AndersonTorres @FliegendeWurst Thanks a lot for your kind suggestions, I believe I was able to fix all the issues and follow the conventions, let me know if not :pray:

Thanks a lot for the assistance!!! have a nice day


Make the docke image built on circle runnable...

Use netgo tag to rebuild go std lib so resulting binaries are statically compiled.
Couple of other tweaks to make it work.

Fixes #74

Oof. Well, if it works! :shipit:


Traefik fails to install on RC builds

Description:
Traefik fails to install. The helm-install pod logs give:
+ helm_v3 install --set-string global.systemDefaultRegistry= traefik https://<IP_ADDRESS>:443/static/charts/traefik-19.0.000.tgz --values /config/values-01_HelmChart.yaml
Error: INSTALLATION FAILED: execution error at (traefik/templates/ingressclass.yaml:10:8): ERROR: You must use at least Kubernetes v1.16 with this Chart

Can workaround this by applying the following manifest:
apiVersion: helm.cattle.io/v1
kind: HelmChartConfig
metadata:
  name: traefik
  namespace: kube-system
spec:
  valuesContent: |-
    ingressClass:
      enabled: false

I believe the error occurs due to k8s version including the rcX in the semver:
$ kubectl version --short
Client Version: v1.25.4-rc1+k3s1
Kustomize Version: v4.5.7
Server Version: v1.25.4-rc1+k3s1

Versions:
Confirmed this happens on v1.25.4-rc1+k3s1, but likely not limited to that so including v1.23.14-rc1+k3s1 and v1.24.8-rc1+k3s1 as well.

Just confirming that this issue occurred and was resolved with the above fix.yaml on ARM SLES 15.4

Confirmed that this affects rc builds only; a local build using GA tags works fine:
brandond@dev01:~$ kubectl version --short
Flag --short has been deprecated, and will be removed in the future. The --short output will become the default.
Client Version: v1.24.3
Kustomize Version: v4.5.4
Server Version: v1.25.4+k3s1

brandond@dev01:~$ kubectl get pod -A -o wide
NAMESPACE     NAME                                      READY   STATUS      RESTARTS   AGE   IP          NODE           NOMINATED NODE   READINESS GATES
kube-system   coredns-597584b69b-5d2mj                  1/1     Running     0          71s   <IP_ADDRESS>   k3s-server-1   <none>           <none>
kube-system   local-path-provisioner-79f67d76f8-tsplz   1/1     Running     0          71s   <IP_ADDRESS>   k3s-server-1   <none>           <none>
kube-system   svclb-traefik-49fd70a3-2kl4n              2/2     Running     0          63s   <IP_ADDRESS>   k3s-server-1   <none>           <none>
kube-system   helm-install-traefik-crd-xf8cn            0/1     Completed   0          71s   <IP_ADDRESS>   k3s-server-1   <none>           <none>
kube-system   helm-install-traefik-g6nhn                0/1     Completed   1          71s   <IP_ADDRESS>   k3s-server-1   <none>           <none>
kube-system   traefik-68cb5f8998-smlt4                  1/1     Running     0          63s   <IP_ADDRESS>   k3s-server-1   <none>           <none>
kube-system   metrics-server-5c8978b444-wc7bc           1/1     Running     0          71s   <IP_ADDRESS>   k3s-server-1   <none>           <none>

Validated in v1.25.4-rc4+k3s1, v1.24.8-rc3+k3s1, v1.23.14-rc3+k3s1, and v1.22.16-rc2+k3s1 that traefik and svclb all install successfully


ci: drop Node.js v14

Unblocks https://github.com/electron/github-app-auth/pull/15.
CircleCI has switched executors from MacOS / Medium Gen2 to MacOS / M1 Medium - Node.js v14 does not release an arm64 version and therefore does not work anymore.

given its long past EOL - why? Could we not at this point try adding 22?

given its long past EOL - why?

The package supports v14, so we should test it in CI to prevent accidentally introducing breaking changes. At the moment Ecosystem WG policy is to minimize the number of breaking changes for any given package, so we've been avoiding dropping support for old Node.js versions unless we have to, or we're doing other breaking changes.

Could we not at this point try adding 22?

We could, but I think that's a separate question.


Open issues if the response times are too high

Similar to the current "🛑 Endpoint is down" issues, a warning issue for large response times saying ":warning: Endpoint is experiencing degraded performance" would be nice.

Sounds like a good idea!

This is now added in upptime/uptime-monitor v1.15.0. You can set the maxResponseTime of each site like so:
sites:
  - name: Example
    url: https://example.com
    maxResponseTime: 5000

In the above example, 5000 [ms] means that if the response time is greater than 5 seconds, mark the site as "degraded performance". Some interesting changes:

status (in the API, commits, README, etc.,) can now be "up", "down", or "degraded", rather than only "up" or "down"
On the README summary of a site, you can see "🟩 Up", "🟥 Down", or "🟨 Degraded"
On the overall summary of your README, you can see:

"🟩 All systems operational" if all your sites are up
"🟨 Degraded performance" if one or more sites are degraded
"🟧 Partial outage" if one or more sites are down
"🟥 Complete outage" if all your sites are down

Lastly, you can now also customize each of these messages using the configuration file

I hope this solves your use case! 😄

Wow! thanks a lot! this awesome 🚀

This doesn't seem to be documented yet

Thanks for the reminder, all done!


Sync does not allow a product update with a new variant and not all same-for-all-variant values on the master sku defined

Description
The import appears to fail if a variant is being added to a product when the master variant has not been fully specified with values for same-for-all-variant values.
product-csv-sync import --projectKey ${_ctProjectKey} --clientId ${_ctClientId} --clientSecret ${_ctClientSecret} --sphereHost [api.commercetools.co|http://api.commercetools.co] --sphereAuthHost [auth.commercetools.co|http://auth.commercetools.co] \
  --csv '/var/www/vhosts/[completenutrition.com/data/productsync_import/CNEcommItemFeed.csv|http://completenutrition.com/data/productsync_import/CNEcommItemFeed.csv]' --language 'en' --csvDelimiter ',' --multiValueDelimiter ';' \
  --continueOnProblems --allowRemovalOfVariants --verbose --matchBy sku --encoding 'utf8' \
  2>&1 | tee ${_importlog}

project-key : cn-ecomm-test

product data
productType,variantId,sku,prices,name.en,benefit,size,flavor
supplement,1,5014017,US-USD 3999;US-USD 2999 Club,Elite Gold Uptake,,30srv,grnapple
,2,5015013,US-USD 3999;US-USD 2999 Club,Elite Gold Uptake,,30srv,grape
,3,5015014,US-USD 3999;US-USD 2999 Club,Elite Gold Uptake,,30srv,strbrypine
,4,5015027,US-USD 3999;US-USD 2999 Club,Elite Gold Uptake,,30srv,lmnade

Expected Behavior
You can import new variants without having to provide all the master variant values each time.
Current Behavior
If the update is specified with known variants (or the new variants are created manually in the admin) the price update will work fine without any additional fields specified for the masterVariant.
Otherwise it will produce the following error.
....[row2]
BadRequest: The value \'"<undefined>"\' is not valid for field \'shortDescription\'. The value of the attribute must be the same across all variants.
{
  "statusCode": 400,
  "message": "The value \'\\"<undefined>\\"\' is not valid for field \'shortDescription\'. The value of the attribute must be the same across all variants.",
  "errors": [
    {
      "code": "InvalidField",
      "message": "The value \'\\"<undefined>\\"\' is not valid for field \'shortDescription\'. The value of the attribute must be the same across all variants.",
      "action": {
        "action": "addVariant",
        "sku": "5015027",
        "prices": [
          {
            "value": {
              "currencyCode": "USD",
              "centAmount": 3999
            },
            "country": "US"
          },
          {
            "value": {
              "currencyCode": "USD",
              "centAmount": 2999
            },
            "country": "US",
            "customerGroup": {
              "typeId": "customer-group",
              "id": "a03bb017-8566-4089-8af2-54f469cabbc8"
            }
          }
        ],
        "images": [],
        "attributes": [
          {
            "name": "size",
            "value": "30srv"
          },
          {
            "name": "flavor",
            "value": "lmnade"
          }
        ],
        "assets": [],
        "staged": true
      },
      "actionIndex": 1,
      "invalidValue": "<undefined>",
      "field": "shortDescription"
    },
    {
      "code": "InvalidField",
      "message": "The value \'\\"<undefined>\\"\' is not valid for field \'xsell\'. The value of the attribute must be the same across all variants.",
      "action": {
        "action": "addVariant",
        "sku": "5015027",

Context
Currently our client cannot provide the additional data other than basic price,size,flavor etc in their feed and wish to automate adding new variants with pricing.
Possible Solution

Hello @ebonertz
thanks for reporting, this is a valid bug that we aware of.
We are working on this and should be ready before the end of next week.

Can't seem to reproduce this error and everything seems to work as expected. Could you explain more about this problem?

ping @ebonertz

Hello @ebonertz
I took a deeper look into this issue and noticed that the reason why this issue exist is because the user is trying to add a new variant  and not providing all the values for the same-for-all-variant attributes.
The API defaults to using undefined hence the error.
I think there is little we can do here(this module), but I wonder why the API is defaulting to undefined if the value is not present, I will expect that the default value (already present in the API) is used since same-for-all-variants flag is turned on for the product-type
I am open to any suggestions how to go about this or the beseech the user to provide all required values
Cc @VasumathiJayakumar @stmeissner @Oehmi @hajoeichler @mmoelli @emmenko @yanns

Can you explain:
/quote the API is defaulting to undefined
?
I don't really understand what you mean.

@yanns
If the attribute is not present and the same-for-all flag is set, the API uses undefined and I guess that is the reason for this error message
The value \'"<undefined>"\' is not valid for field \'shortDescription\'. The value of the attribute must be the same across all variants.

undefined was not sent from the SDK, so it probably must have been set by the API somehow

@hisabimbola could you please verify if I understood the scenario correctly:
Given

a product with at least the master variant with a same-for-all attribute value set
and
an "Add ProductVariant" update action with same-for-all attribute value not given
should be accepted with no error message since the value can be copied from master variant

It shouldn't matter whether the same-for-all attribute is defined as isRequired or not, correct?

@hisabimbola ok, this is not a very good error message.
We should do better here.

@hisabimbola @yanns  Any way we can get this out of the "On Hold" Status? Customer was asking again yesterday if there was a fix for this. Not urgent but we would like to get this resolved as I don't think the current behavior is intended.

This is something to be discussed with the platform team IMO. @stmeissner @Oehmi can you take care of moving this discussion in an appropriate place for the platform?

@idamia FYI

@Oehmi @idamia Can we please take some action here? This in pending since March and I have brought it up several times in our weekly call.

Maybe error message from API could be better but it seems that behaviour is correct for sameForAll attributes. There two ways to go around it:

remove sameForAll constraint for attributes which are sameForAll and can not be delivered on addVariant action

extend sync with boolean option prefillMissingSameForAllValues which defaults to false and can be activated on demand. It would use product type to determine sameForAll attributes and would prefill missing sameForAll attributes of new variants with values of existing variant.
Other cases to cover:

previous variant might have no value set which is also kind of state/value which means that new variants should be also left without those values/attributes defined.
In case existing value is not set and any of new variants has new value than setAttributeInAllVariants with new value should supplied before any addVariant actions.
In case new variants have different values for sameForAll attributes - error should be thrown/logged.

It would be also nice to add this option to https://github.com/sphereio/sphere-product-import also.


Bind doesn'tt update

The foillowing HTML
<!DOCTYPE html>

        <select size="2" style="width: 100px"
                ng-model="selected"
                ng-options="i as i.name for i in items track by i.name"
        />

Description: <input type="text" name="descr" ng-model="selected.descr"/>

Reference: <input type="text" name="ref" ng-model="selected.ref"/>

and JS
var tstapp = angular.module('tstApp', [])
tstapp.controller('tstCtrl', function($scope) {
    $scope.items = [
                {
                        "name" : "ITEM1",
                        "descr" : "This is item1",
                        "ref" : "Reference1"
                },
                {
                        "name" : "ITEM2",
                        "descr" : "This is item2",
                        "ref" : "Reference2"
                }
    ];
        $scope.selected = $scope.items[0];
});

works when using 1.2.1 but change to 1.4.8 and changes to Description or Reference are not remembered

Can you please create a plunker with the example above?

http://plnkr.co/edit/G7DNLp6eHz9BGqPZceRv

I verified with 38.1.1 on Linux and latest Chrome on Windows.

Yes, there is definitely something odd going on. It seems like when using track by, the selected model is not a always a reference to the object in the options array. But the behavior is a bit erratic and definitely needs some investigating,

Sorry, it is my first day with AngularJS so I will only be a spectator and leave it to the pros.

I meet this issue same as you, and i use ng-repeat in options to replace use ng-options in select tag.

Duplicate of https://github.com/angular/angular.js/issues/15980


Support jsx-runtime for jest babel transform

This is a part of work about #205 .
I upgrade react-scripts to 4.0.1 version, and everything fine with npm run start / npm run build.
But when I run npm run test, the error occurs like this:

Here is the example project: craco-jsx-runtime-jest-bug, will get the same error.
Then I go to the react-scripts/config/jest/babelTransform.js, find we need runtime option to support jsx-runtime. So I create this pull request.
For old version babel-preset-react-app(I have checked this file), it's ok to pass same options, I just ignore version check.

Hi @wanglam
Thanks for the PR :)
Did you do anything else to make Jest works with react-script 4.0.1 and React 17?
I get the following error:

Thank you,
Patrick

Hi @patricklafrance
No, I didn't do anything else to make Jest work with react-scripts 4.0.1 and React 17.
I confirmed If you create a new project based CRA(version 4.0.1) and run npm run test. Everything work fine, no error will be found.
Would you like to upload your project? Maybe we can check it together.
Lin

@wanglam I was running yarn jest instead of yarn test :(

Works fine, thanks for the PR :)

Released in<EMAIL_ADDRESS>


Turn Go warnings into errors

/good-first-issue
Let's try to prevent having to do #138 all over again.

Hey!
I've added staticcheck (https://staticcheck.io/) as a step in the Makefile. This seems to be one of the de-facto static code analysis tools for go. The change is minimal (see f52ebfcee433a7e6d31ad2d07fa185d08ef3d308); it will install staticcheck and run it against the same files as go vet either with make staticcheck or during build, docker-build, docker-push-multi:
One remaining problem right now is, that there's still a bunch of warnings left (for 9c08a710995b703e5ed67a269a8076662d00f7b1), these should be fixed before this is going to be used as a default step.
❯ make staticcheck
staticcheck ./api/... ./cmd/... ./internal/...
internal/anchor/reconciler.go:245:13: error strings should not be capitalized (ST1005)
internal/anchor/reconciler.go:295:13: error strings should not be capitalized (ST1005)
internal/anchor/reconciler.go:358:22: func (*Reconciler).deleteInstance is unused (U1000)
internal/anchor/validator.go:58:10: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/anchor/validator.go:103:11: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/anchor/validator.go:108:11: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/anchor/validator.go:117:12: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/anchor/validator.go:126:11: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/config/namespace.go:101:11: error strings should not be capitalized (ST1005)
internal/config/namespace.go:104:11: error strings should not be capitalized (ST1005)
internal/forest/namespace.go:151:5: should omit comparison to bool constant, can be simplified to ns.allowCascadingDeletion (S1002)
internal/hierarchyconfig/validator.go:14:2: package "k8s.io/apimachinery/pkg/api/errors" is being imported more than once (ST1019)
        internal/hierarchyconfig/validator.go:15:2: other import of "k8s.io/apimachinery/pkg/api/errors"
internal/hierarchyconfig/validator.go:95:10: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/hierarchyconfig/validator.go:128:10: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/hierarchyconfig/validator.go:132:10: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/hierarchyconfig/validator.go:185:10: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/hierarchyconfig/validator.go:193:10: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/hierarchyconfig/validator.go:203:10: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/hierarchyconfig/validator.go:213:10: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/hierarchyconfig/validator.go:218:10: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/hierarchyconfig/validator.go:227:10: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/hierarchyconfig/validator.go:235:10: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/hierarchyconfig/validator.go:407:12: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/hierarchyconfig/validator.go:412:12: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/hierarchyconfig/validator.go:419:12: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/hierarchyconfig/validator.go:423:12: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/hncconfig/reconciler_test.go:457:6: func updateTypeConfig is unused (U1000)
internal/hncconfig/reconciler_test.go:486:6: func unsetTypeConfig is unused (U1000)
internal/hncconfig/reconciler_test.go:583:16: should use fmt.Errorf(...) instead of errors.New(fmt.Sprintf(...)) (S1028)
internal/hncconfig/reconciler_test.go:587:14: should use fmt.Errorf(...) instead of errors.New(fmt.Sprintf(...)) (S1028)
internal/hncconfig/reconciler_test.go:604:17: should use fmt.Errorf(...) instead of errors.New(fmt.Sprintf(...)) (S1028)
internal/hncconfig/reconciler_test.go:621:16: should use fmt.Errorf(...) instead of errors.New(fmt.Sprintf(...)) (S1028)
internal/hncconfig/reconciler_test.go:625:14: should use fmt.Errorf(...) instead of errors.New(fmt.Sprintf(...)) (S1028)
internal/hncconfig/validator.go:52:11: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/hncconfig/validator.go:65:10: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/hncconfig/validator.go:142:11: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/integtest/helpers.go:9:2: should not use dot imports (ST1001)
internal/integtest/helpers.go:10:2: should not use dot imports (ST1001)
internal/integtest/helpers.go:84:3: unnecessary assignment to the blank identifier (S1005)
internal/integtest/helpers.go:92:3: unnecessary assignment to the blank identifier (S1005)
internal/integtest/helpers.go:380:2: unnecessary assignment to the blank identifier (S1005)
internal/integtest/setup.go:24:2: should not use dot imports (ST1001)
internal/integtest/setup.go:25:2: should not use dot imports (ST1001)
internal/namespace/validator.go:56:10: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/namespace/validator.go:140:11: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/namespace/validator.go:148:12: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/namespace/validator.go:176:10: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/namespace/validator.go:187:10: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/namespace/validator.go:204:11: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/namespace/validator.go:219:10: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/namespace/validator.go:237:10: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/namespace/validator.go:250:11: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/objects/validator.go:84:11: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/objects/validator.go:94:11: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/objects/validator.go:128:11: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/objects/validator.go:134:11: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/objects/validator.go:138:11: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/objects/validator.go:141:11: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/objects/validator.go:144:11: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/objects/validator.go:150:11: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/objects/validator.go:251:10: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/objects/validator.go:259:11: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/objects/validator.go:263:11: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/objects/validator.go:273:11: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/objects/validator.go:280:11: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/objects/validator.go:286:11: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/objects/validator.go:295:9: webhooks.Deny is deprecated: Use DenyFromAPIError instead; please don't add new callers.  (SA1019)
internal/stats/stats.go:139:31: argument total is overwritten before first use (SA4009)
        internal/stats/stats.go:144:3: assignment to total
internal/stats/stats.go:148:7: should omit comparison to bool constant, can be simplified to !working (S1002)
internal/stats/stats.go:156:7: should omit comparison to bool constant, can be simplified to working (S1002)
make: *** [Makefile:195: staticcheck] Error 1

I have submitted https://github.com/kubernetes-sigs/hierarchical-namespaces/pull/137 to fix most of the callers to the deprecated func. PTAL!

@erikgb Here's the output against the state of #137 - looks way better now:
❯ staticcheck ./api/... ./cmd/... ./internal/...
internal/anchor/reconciler.go:245:13: error strings should not be capitalized (ST1005)
internal/anchor/reconciler.go:295:13: error strings should not be capitalized (ST1005)
internal/anchor/reconciler.go:358:22: func (*Reconciler).deleteInstance is unused (U1000)
internal/config/namespace.go:101:11: error strings should not be capitalized (ST1005)
internal/config/namespace.go:104:11: error strings should not be capitalized (ST1005)
internal/forest/namespace.go:151:5: should omit comparison to bool constant, can be simplified to ns.allowCascadingDeletion (S1002)
internal/hncconfig/reconciler_test.go:457:6: func updateTypeConfig is unused (U1000)
internal/hncconfig/reconciler_test.go:486:6: func unsetTypeConfig is unused (U1000)
internal/hncconfig/reconciler_test.go:583:16: should use fmt.Errorf(...) instead of errors.New(fmt.Sprintf(...)) (S1028)
internal/hncconfig/reconciler_test.go:587:14: should use fmt.Errorf(...) instead of errors.New(fmt.Sprintf(...)) (S1028)
internal/hncconfig/reconciler_test.go:604:17: should use fmt.Errorf(...) instead of errors.New(fmt.Sprintf(...)) (S1028)
internal/hncconfig/reconciler_test.go:621:16: should use fmt.Errorf(...) instead of errors.New(fmt.Sprintf(...)) (S1028)
internal/hncconfig/reconciler_test.go:625:14: should use fmt.Errorf(...) instead of errors.New(fmt.Sprintf(...)) (S1028)
internal/integtest/helpers.go:9:2: should not use dot imports (ST1001)
internal/integtest/helpers.go:10:2: should not use dot imports (ST1001)
internal/integtest/helpers.go:84:3: unnecessary assignment to the blank identifier (S1005)
internal/integtest/helpers.go:92:3: unnecessary assignment to the blank identifier (S1005)
internal/integtest/helpers.go:380:2: unnecessary assignment to the blank identifier (S1005)
internal/integtest/setup.go:24:2: should not use dot imports (ST1001)
internal/integtest/setup.go:25:2: should not use dot imports (ST1001)
internal/objects/validator.go:149:11: webhooks.Deny is deprecated: Use one of the explicit deny reason funcs instead; please don't add new callers.  (SA1019)
internal/objects/validator.go:250:10: webhooks.Deny is deprecated: Use one of the explicit deny reason funcs instead; please don't add new callers.  (SA1019)
internal/objects/validator.go:262:11: webhooks.Deny is deprecated: Use one of the explicit deny reason funcs instead; please don't add new callers.  (SA1019)
internal/objects/validator.go:272:11: webhooks.Deny is deprecated: Use one of the explicit deny reason funcs instead; please don't add new callers.  (SA1019)
internal/objects/validator.go:279:11: webhooks.Deny is deprecated: Use one of the explicit deny reason funcs instead; please don't add new callers.  (SA1019)
internal/objects/validator.go:285:11: webhooks.Deny is deprecated: Use one of the explicit deny reason funcs instead; please don't add new callers.  (SA1019)
internal/stats/stats.go:139:31: argument total is overwritten before first use (SA4009)
        internal/stats/stats.go:144:3: assignment to total
internal/stats/stats.go:148:7: should omit comparison to bool constant, can be simplified to !working (S1002)
internal/stats/stats.go:156:7: should omit comparison to bool constant, can be simplified to working (S1002)

Nice! I am planning to fix the deprecated callers. Feel free to fix the remaining warnings in a dedicated PR!

Yeah, will do in the next few days :)

Fixed by #169
/close


chore: Bound Jellyfish <1.1.2

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

https://github.com/jamesturk/jellyfish/issues/217 was closed. Looks like we can revert this.


Point nuget.org/packages/WindowsAzure.ServiceBus/ to new preview package

https://www.nuget.org/packages/WindowsAzure.ServiceBus/ should have a blurb that points to the preview package.

Please review this one as well: https://www.nuget.org/packages/Microsoft.Azure.ServiceBus.EventProcessorHost/

And this one: https://www.nuget.org/packages/Microsoft.Azure.ServiceBus/

@AlexGhiondea:  Not quite sure of the proper routing/tagging on this, so I'm just shifting it from the needs-triage bucket and lightly categorizing.   Please feel free to adjust as you feel is appropriate.

This is now done.


Fix property_name namespace deprecation

https://docs.chef.io/deprecations_namespace_collisions.html

This deprecation takes effect as of Chef 14.0 and requires that all
references to property_name inside a resource be namespaced to
new_resource.property_name.

This would be really great to get merged in since this cookbook won't work on Chef 14 without it


⬆ Update TS and fix keyof issue from 4.2

Fixes: #37

Codecov Report

Merging #38 (f9adc65) into master (cfef63b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   98.98%   98.98%
=======================================
  Files           9        9
  Lines         198      198
  Branches       41       41
=======================================
  Hits          196      196
  Misses          1        1
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfef63b...f9adc65. Read the comment docs.


Swipe left not change title color, version 1.4.0

Hi, see bug in video: https://www.dropbox.com/s/jrl7ttava4hr5l0/recyclertablayout_bug.mp4?dl=0
version 1.1.0 not have this bug

@mishindmitriy
Thank you for your report!
Oh I missed.  Will you please try v1.5.0?

In 1.5.0 it doesn't center the selected title at the beginning. After a swipe it turns normal and centers the selected title.

@orhunkupeli7
I can't reproduce your issue.
Could you show me your screenshot?
And I change a little, please check version 1.5.1.snapshot.
( https://github.com/nshmura/RecyclerTabLayout/commit/93e27fa1d887902fe2b117fef0223ce54eda7459 )

At the beginning it looks like this after a swipe it centers the selected one. Thanks for your reply.

Thanks for your snapshot!
It's odd ...
If it is possible, Would you please show me your code or sample code it reproduce this issue ?
Or please try "ImitationLoop" in demo application,  and tell me what happened.
https://github.com/nshmura/RecyclerTabLayout/tree/master/demo
And Would you please tell me your device and OS version?

@orhunkupeli
Thanks for your snapshot!
It's odd ...
If it is possible, Would you please show me your code or sample code it reproduce this issue ?
Or please try "ImitationLoop" in demo application, and tell me what happened.
https://github.com/nshmura/RecyclerTabLayout/tree/master/demo
And Would you please tell me your device and OS version?

@nshmura 1.5.1 works good, thank you!


Updated Docker-Compose file to add delay before starting API

Added 7 second delay to allow database to be built before starting the API

Looks fine


JCenter sunsetting

JCenter is sunsetting on May 1, 2021, per https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/
Katana is published on JCenter, and not on Maven Central, so anyone using it will be affected.
Knowing that Katana is not actively developed anymore, I'm not sure anyone has any serious expectation that the library would be re-published elsewhere.
What are your thoughts on publishing Katana on Maven Central or another channel?

Thanks for letting me know. Since Katana is still used by a few projects, I will investigate what is necessary to publish to Maven Central.

After a lot of sweating & swearing 😉 I finally managed to publish Katana to Maven Central via Sonatype OSSRH. The latest version 1.14.0 is now available on Central. From now on any future versions will only be published to Central and not to JCenter.


When Go to login , the text is not visible

🖥 Frontend Issue
Description
When you click on the login page the text is not visible and it can be lot better than as it is Now.
Screenshots or Video

Are you participating in GSSoC?

[x] Yes
[ ] No

@dhairyagothi  Assign This issue to me

there is alreay same issue for that alignment
assigning you if can make some else changes . lets see

@dhairyagothi  I will start work on this .


HAWKULAR-1048 fix returning array instead of Object

If array but the request return Object, the request is thrown away. So change ResourceRecursiveChildrenUnderFeed method to return array on GET requests.

Merge #96

@karelhala version 0.9.3


PowerToys Run not finding PowerShell script shortcuts in User Start Menu

Environment
Windows build number: 10.0.19041.264
PowerToys version: 0.18.2
PowerToy module for which you are reporting the bug (if applicable): Run
Steps to reproduce
If you have PowerShell scripts (or other scripts) that you create shortcuts too and put in the Start Menu folder(s) they are not found.
Other apps in those locations are found. I have quite a few admin scripts that I can run from Windows 10 Search (Win + Q, just Win, etc.). For example, I created a folder in C:\Users\UserID\AppData\Roaming\Microsoft\Windows\Start Menu\Programs and created shortcuts to all of my PowerShell scripts in there. Windows 10 search finds them, PowerToys Run does not. Even after days (incase it was index timing) they are still not found.
Expected behavior
Anything in the Start Menu folders (All Users, Current Users) should be available to be run, including shortcuts, etc.
Actual behavior
PowerToys Run does not find shortcuts to PowerShell scripts (and maybe others, but the scripts are what I've tested on several machines).
Screenshots

Great catch, we'll work on this

Thank you for reporting!
I've created countless shortcuts in %APPDATA%\Microsoft\Windows\Start Menu\ and expected them to show up. Some are shortcuts to applications, some are scripts, Hyper-V profiles, etc. I prefer PowerToys Run, but I'm stuck with the regular old start menu search for now.

v0.19 fixed the issue for me. I can now find the shortcuts to PowerShell scripts in the tool. Thanks!

I still have the issue, any shortcuts inside my user's start menu does not appear on power toys run results.

I still have the issue, any shortcuts inside my user's start menu folder don't appear in power toys run results.

@justanindieguy PowerShell script shortcuts, correct?

@justanindieguy PowerShell script shortcuts, correct?

Yes, that's correct.

I just popped one on my desktop and it loaded in 0.21.1, @justanindieguy still an issue?

I just popped one on my desktop and it loaded in 0.21.1, @justanindieguy still an issue?

I did the same and now it's working fine. I'm on PT v0.21.1

Going to close this, if it isn't fixed, please comment.


Why do we need service principal to have RBAC-reader on vault?

Using the Key Vault REST API, we just need the service principal to have read (secrets / keys / certificates) policy in the vault.
We do not need to have Azure Control Plane / RBAC Reader on the Key Vault itself.
So why do we need to give that privilege?  Principle of Least Privilege would dictate to just have the policy, no?

@vplauzon You are referring to this step right?
az role assignment create --role Reader --assignee <principalid> --scope /subscriptions/<subscriptionid>/resourcegroups/<resourcegroup>/providers/Microsoft.KeyVault/vaults/<keyvaultname>
This is required by https://github.com/Azure/kubernetes-keyvault-flexvol/blob/master/azurekeyvault-flexvolume/keyvaultFlexvolumeAdapter.go#L145-L146 to get and validate the keyvault client.

I see.  This allows us to validate the Key Vault does exist I suppose.
The Key Vault API doesn't require RBAC access.  It is a different plane.
For instance, in this blog, I use the Key Vault REST API while having only policies access.  If you run the sample (ARM template), you'll see the Logic App Managed Identity isn't given any access on the Key Vault resource itself.
It is a minor inconvenience, but one I did step into.  It adds to the number of mistakes one can do when configuring the feature as I did.

That's right, we need to first validate the key vault exists before getting content from it. Hence we need access in both places. Closing this issue for now. Feel free to reopen if you have other questions.

we need to first validate the key vault exists before getting content from it

Why is this a requirement?  You can validate the provided Keyvault name meets the officially documented name restrictions (specifically, Key Vault names are selected by the user and are globally unique.  and Key Vault name must be a 3-24 character string, containing only 0-9, a-z, A-Z, and -.), and if it does just try to connect.  You don't need to be able to 'see' it to attempt to access it.  The act of connecting validates that the bearer token represents a user that is allowed to connect to that keyvault.
The reason why this matters is because many azure governance strategies restrict the ability for random users to assign arbitrary RBAC roles to other random users.  In this kind of environment, "just add the RBAC rule" is an extremely onerous thing to ask of someone that doesn't have full access to control RBAC.
Especially in the case where you're using Pod Identity, and new "users" come in and out of existence according to the needs of the cluster.  This means that any user with the Contributor role on the keyvault can delegate access to the keyvault to the pod identities, and the only RBAC rights they would need is Contributor (as opposed to Owner if they were assigning RBAC), and the Pod Identity itself wouldn't need any RBAC assignments.

Thanks for the feedback @infogulch! Regarding

many azure governance strategies restrict the ability for random users to assign arbitrary RBAC roles to other random users.

What about assigning permission to the key vault objects? Are these also restricted? e.g.:
az keyvault set-policy -n $KV_NAME --key-permissions get --spn <YOUR SPN CLIENT ID>

Setting access policies in an azure keyvault only requires the Contributor role on the scope of the keyvault.
Whereas assigning an RBAC Reader role on the keyvault to another user (e.g. giving the PI-user Reader role) requires Owner permission on the scope.
Conceptually, keyvault is authenticated against your AAD tenant, but it's authorized based on the access policy, not RBAC.

Based on quickly scanning the repo, it appears that the only thing that needs to change to eliminate all need for users to alter RBAC is simplifying the keyvaultFlexvolumeAdapter.getVaultURL() method to return the vault endpoint based on the name after validating it matches the published documentation.
Something like this: (untested)
func (adapter *KeyvaultFlexvolumeAdapter) getVaultURL() (vaultURL *string, err error) {
	// See docs for validation spec: https://docs.microsoft.com/en-us/azure/key-vault/about-keys-secrets-and-certificates#objects-identifiers-and-versioning
	if match, _ := regexp.MatchString(`[-a-zA-Z0-9]{3,24}`, adapter.options.vaultName); !match {
		return nil, errors.Errorf("Invalid vault name: %q, must match [-a-zA-Z0-9]{3,24}")
	}
	// Note: The ".vault.azure.net" endpoint tld may depend on something else like adapter.options.cloudName.  e.g. govcloud may use a different endpoint.  I'm not familiar enough to know or not.
	return "https://"+adapter.options.vaultName+".vault.azure.net/"
}

I've implemented a PR for this:
https://github.com/Azure/kubernetes-keyvault-flexvol/pull/128


:recycle: Refactor GroupColumnForm, move more logic to backend

#505  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @acco and the rest of your teammates on  Graphite


Button: Add type prop to typings

Fixes #576
Change-type: patch
Signed-off-by: Lucian Buzzo<EMAIL_ADDRESS>

@resin-ci retest


fix: pressing backspace closes drawer

Fixes #2840

rip https://github.com/payloadcms/payload/pull/2973


Don't use this slider

Don't use this slider newer!!!!!!!!!!!!!!!!!

Why? whats the reason?

Why? whats the reason?

Your slider blocks all input on page and you don't care about it.
Look:
https://github.com/xwpongithub/vue-range-slider/issues/15
https://github.com/xwpongithub/vue-range-slider/issues/13
https://github.com/xwpongithub/vue-range-slider/issues/7
https://github.com/xwpongithub/vue-range-slider/issues/4

True, this slider gives really weird side effects to the rest of the code. I think the best alternative is this: https://github.com/xwpongithub/vue-range-slider/issues/13#issuecomment-628857746


Fix datatype of SkillCorner metadata.periods

The SkillCorner deserializer stored the metadata.periods attribute as a dictionary. According to the spec, it should be stored as a list of periods.

Thanks a lot Pieter!


merge operator not associative

https://github.com/facebook/rocksdb/wiki/Merge-Operator#associativity-vs-non-associativity
Merge operators in blockchain module are not associative. e.g. https://github.com/yangl1996/prism-rust/blob/master/src/blockchain/mod.rs#L1610
Sometimes RocksDb tries to execute the merge operator in the backend, supplying it with values already in the database. This is invalid to our merge operators. E.g. in the case above, the operator takes a singe tuple, while the value stored in the table is a vector of another type.

Will be fixed in the upcoming PR that gets rid of RockdDB in the blockchain db.


Disable auto-login and lightdm breaks?

Using the .ova file and ESXi setup. Deploy .ova, update image, make sure it can reach internal smb share with correct creds, and then go to user settings and disable autologin. After rebooting, lightdm doesn't start and you're presented with CLI. Login using default creds and try to use startx and it errors out trying to lock the file. Try rebooting, still get CLI. Login using default creds, run sudo systemctl enable lightdm, reboot, and get GUI login with SANSFORENSICS as user name and asking for password. When I type the password, it acts like it wants to login but then displays login screen again. Entering a wrong password displays as a wrong password. Any ideas? I can redeploy .ova and try disabling auto-login another way if that's easier than fixing this issue, but I've reproduced this twice now.

Sounds like a permissions issue. I’ve seen the behavior before but haven’t been able reproduce it.
Sent from my iPhone

On Oct 16, 2018, at 12:13, cgisecurity<EMAIL_ADDRESS>wrote:
Using the .ova file and ESXi setup. Deploy .ova, update image, make sure it can reach internal smb share with correct creds, and then go to user settings and disable autologin. After rebooting, Unity doesn't start and you're presented with CLI. Login using default creds and try to use startx and it errors out trying to lock the file. Try rebooting, still get CLI. Login using default creds, run sudo systemctl enable lightdm, reboot, and get GUI login with SANSFORENSICS as user name and asking for password. When I type the password, it acts like it wants to login but then displays login screen again. Entering a wrong password displays as a wrong password. Any ideas? I can redeploy .ova and try disabling auto-login another way if that's easier than fixing this issue, but I've reproduced this twice now.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Fixed.

What was the fix?
Sent from my iPhone

On Oct 16, 2018, at 13:36, cgisecurity<EMAIL_ADDRESS>wrote:
Closed #318.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Disable auto login first and then reboot the machine before doing anything
else.
Not really a fix, just didn't break it on my third try. It seems to happen
when you disable auto login, set a static ip, and change host name before
rebooting.
On Tue, Oct 16, 2018, 9:56 PM Erik Kristensen<EMAIL_ADDRESS>wrote:

What was the fix?
Sent from my iPhone

On Oct 16, 2018, at 13:36, cgisecurity<EMAIL_ADDRESS>wrote:
Closed #318.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/sans-dfir/sift/issues/318#issuecomment-430471958, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AmSkGDH4CEU0bytY8RszQ_v5-i7DwKqVks5ulpxqgaJpZM4Xf0Rr
.


sidebars: Correct placement of browse more streams, invite more users links.

This PR computes legacy values using different but context-appropriate methods for the left and right sidebar, so that links at the bottom of each sidebar scales up and preserves the legacy space from the bottom of the viewport.
Fixes parts of #30476.

Screenshots and screen captures:

Legacy, before
Legacy, after (no change)

16/140, before
16/140, after

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Merged, thanks @karlstolley!


PROD-395/welcome-back-screen-changes

The chompy head icon resolution is poor. Can you use unoptimized prop and export the image with 2x size?
<Image
    src={url}
    alt={alt}
    width={width}
    height={height}
    unoptimized
/>

I just added a bigger image. I think it is a not good idea to do unoptimization for images.


Repair ngsync

<ngsnyc direction="clientToServer" /> and <ngsnyc direction="clientToServer" /> are broken, possibly because of the update to AngularJS 1.3.

Done.


Omit waiting for method response

I want to call a remote method but I don't need to wait for the response.
How do I send such "signals" with go-micro?

This is what the broker is for. Asynchronous messaging. The RPC client deals with synchronous communication. If you do not want to wait for a response just fire the request in a go routine but the correct way would be to use the Publish method.

Can I Publish just to one service? (I want to use the client side load balancing. )

Publish is a method which uses the broker. For only a single service to receive the message requires the use of a Queue which ensures messages are only sent to one subscriber.

If you would like to discuss this further please join the slack. This is usage rather than an issue.


Exception hierarchy for client

Cases that should be covered:

empty json response
malformed json response

Other things todo:

take out all instances of Exception in client and replace with custom class

Exceptions should be added to exceptions.py, but not derive from BaseServerException

Fixed in #541


electron_{11,12,13,14}: updates

Motivation for this change

electron_11: 11.4.12 -> 11.5.0
electron_12: 12.0.18 -> 12.1.0
electron_13: 13.2.3 -> 13.3.0
electron_14: init at 14.0.0

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 136531 run on x86_64-linux 1

17 packages built:

deltachat-desktop (deltachat-electron)
electron (electron_13)
electron_11
electron_12
element-desktop
element-desktop-wayland
etcher
freetube
jitsi-meet-electron
logseq
nix-tour
obsidian
stretchly
super-productivity
todoist-electron
uivonim
vieb

Result of nixpkgs-review pr 136531 run on x86_64-linux 1

18 packages built:

deltachat-desktop (deltachat-electron)
electron (electron_13)
electron_11
electron_12
electron_14
element-desktop
element-desktop-wayland
etcher
freetube
jitsi-meet-electron
logseq
nix-tour
obsidian
stretchly
super-productivity
todoist-electron
uivonim
vieb

electron = electron_14; should be set in pkgs/development/tools/electron/default.nix. element-desktop should be pinned to electron_13.

Done!

Backport to stable in https://github.com/NixOS/nixpkgs/pull/136676