Changes required for aio stage deployment

Description
The creds that TVM generates only have access to one specific folder.
So trying to list the parent folder shouldn't ideally work and that is the case for Stage.
Hence appending a slash at the end to make this work.
Also, stage bucket is not public for security reasons. Hence the ACL of public-read throws an AccessDenied error.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

lgtm


Include manually skipped packages in report

To reduce confusion about why a certain nixpkgs-review run did not build a certain package it would be helpful to include packages, that were manually skipped (-P) in the report.

This should also only list packages that could have been build and not every blacklisted package because then if not we would get the same default list in every report.


Adding PushNotificationIOS finish method usage

Motivation (required)
What existing problem does the pull request solve?
PushNotificationIOS finish method usage in case of remote notification. It was unclear from the documentation. Found the usage from  here http://stackissue.com/facebook/react-native/remote-notification-completion-handler-8040.html
Test Plan (required)
Tested the PushNotifcationIOSExample on device.

It has registered and got deviceToken.
DeviceToken has been sent to ProviderService.
ProviderService sent a push notification and the device was able to get it.

Attaching the screenshots of

alert of registered deviceToken

alert of received push notifcation

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with Canny! Check out its new home: https://react-native.canny.io/feature-requests/p/adding-pushnotificationios-finish-method-usage


Extra uses-sdk entry getting added to AndroidManifest.xml

Hello,
It appears this entry in your plugin.xml file is causing ionic to append an extra uses-sdk entry in the AndroidManifest.xml file.
    <config-file target="AndroidManifest.xml" parent="/manifest">
        <uses-sdk   android:minSdkVersion="19" android:targetSdkVersion="19"/>
    </config-file>

After performing an ionic build, we end up with this in our manifest file which causes all android builds to fail since there's a project level version support configuration and the one this plugin injects.
uses-sdk android:minSdkVersion="19" android:targetSdkVersion="22"
uses-sdk android:minSdkVersion="19" android:targetSdkVersion="19"
Is there another way to document this dependency to prevent this the injection?

Hey sorry for the very late reply, I had unwatched the repo by accident and never got to see this.
I am not using ionic, but will be happy to accept a PR that fixes it for you. Can you try keeping the minimum sdk directive and remove the target and let me know if this fixes it for you?

Done in #10

Thank you :)


[api-docs] Document creation limitation for Lottie stickers

A new commit was made into the api-docs repo. This issue was created automatically. Need to review if we made any change to the library for this commit.
https://github.com/discord/discord-api-docs/commit/69770ab441c6ca28b55143e002c2d8da41ca7d4d

Done


Spring echo sample not working when deployed on Azure

Version
Build from latest master branch.
Describe the bug
I have cloned, built and run the spring echo sample locally and confirmed that I can communicate with the Microsoft Bot Emulator locally.
I have successfully deployed to Azure as per the instructions.
When I test the bot with the "Test in WebChat" functionality on Azure I get the following error. I have confirmed that the message is received and it seems to be an error when sending a message back to the bot:
java.util.concurrent.CompletionException: com.microsoft.bot.connector.rest.ErrorResponseException: Status code 400, {"error": {"code": "BadSyntax","message": "Invalid or missing Activity in request"}}at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:273) ~[na:1.8.0_212]at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:280) ~[na:1.8.0_212]at java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:604) ~[na:1.8.0_212]at java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:577) ~[na:1.8.0_212]at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) ~[na:1.8.0_212]at java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962) ~[na:1.8.0_212]at retrofit2.CompletableFutureCallAdapterFactory$ResponseCallAdapter$2.onResponse(CompletableFutureCallAdapterFactory.java:119) ~[retrofit-2.5.0.jar!/:na]at retrofit2.OkHttpCall$1.onResponse(OkHttpCall.java:129) ~[retrofit-2.5.0.jar!/:na]at okhttp3.RealCall$AsyncCall.execute(RealCall.java:203) ~[okhttp-3.12.2.jar!/:na]at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32) ~[okhttp-3.12.2.jar!/:na]at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[na:1.8.0_212]at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[na:1.8.0_212]at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_212]Caused by: com.microsoft.bot.connector.rest.ErrorResponseException: Status code 400, {"error": {"code": "BadSyntax","message": "Invalid or missing Activity in request"}}at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[na:1.8.0_212]at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) ~[na:1.8.0_212]at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[na:1.8.0_212]at java.lang.reflect.Constructor.newInstance(Constructor.java:423) ~[na:1.8.0_212]at com.microsoft.rest.ServiceResponseBuilder.build(ServiceResponseBuilder.java:122) ~[client-runtime-1.6.12.jar!/:na]at com.microsoft.azure.AzureResponseBuilder.build(AzureResponseBuilder.java:56) ~[azure-client-runtime-1.6.12.jar!/:na]at com.microsoft.bot.connector.rest.RestConversations.replyToActivityDelegate(RestConversations.java:341) ~[bot-connector-4.0.0-SNAPSHOT.jar!/:4.0.0-SNAPSHOT]at com.microsoft.bot.connector.rest.RestConversations.lambda$replyToActivity$4(RestConversations.java:324) ~[bot-connector-4.0.0-SNAPSHOT.jar!/:4.0.0-SNAPSHOT]at java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:602) ~[na:1.8.0_212]... 10 common frames omitted
To Reproduce
Follow steps as described above.
Expected behavior
The bot should work.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
I suspect this is due to a versioning issue, i.e. that the Azure protocol has changed and the corresponding java library is not up to date. I tried updating to the latest version but to no avail.
Furthermore I have tried deploying a bot remotely and registering it with Azure. This gives the same error from "Test in WebChat". Interestingly, I am able to add this bot to Skype and send messages. However the error message is slightly different:
java.util.concurrent.CompletionException: com.microsoft.bot.connector.rest.ErrorResponseException: Status code 400, {"error":{"code":"BadSyntax","message":"Payload is incorrect, field is in the wrong format: timestamp"}}
at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:273) ~[na:1.8.0_222]
at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:280) ~[na:1.8.0_222]
at java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:604) ~[na:1.8.0_222]
at java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:577) ~[na:1.8.0_222]
at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) ~[na:1.8.0_222]
at java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962) ~[na:1.8.0_222]
at retrofit2.CompletableFutureCallAdapterFactory$ResponseCallAdapter$2.onResponse(CompletableFutureCallAdapterFactory.java:119) ~[retrofit-2.5.0.jar:na]
at retrofit2.OkHttpCall$1.onResponse(OkHttpCall.java:129) ~[retrofit-2.5.0.jar:na]
at okhttp3.RealCall$AsyncCall.execute(RealCall.java:203) ~[okhttp-3.12.2.jar:na]
at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32) ~[okhttp-3.12.2.jar:na]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[na:1.8.0_222]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[na:1.8.0_222]
at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_222]
[bug]

Hello @diskdan - Are you saying you followed the instructions here?
There are multiple possibilities for which set of instructions you followed. Did you deploy to a new resource group or an existing resource group?

Have you tried cloning from the 4.6 preview 2 branch? Master is changing quickly as Bot-builder is added. I suspect there are some issues with the change from joda-time to Java 8 Date & Time.

From: diskdan<EMAIL_ADDRESS>Sent: Friday, October 4, 2019 2:05:38 AM
To: microsoft/botbuilder-java<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [microsoft/botbuilder-java] Spring echo sample not working when deployed on Azure (#123)
Version
Build from latest master branch.
Describe the bug
I have cloned, built and run the spring echo sample locally and confirmed that I can communicate with the Microsoft Bot Emulator locally.
I have successfully deployed to Azure as per the instructions.
When I test the bot with the "Test in WebChat" functionality on Azure I get the following error. I have confirmed that the message is received and it seems to be an error when sending a message back to the bot:
java.util.concurrent.CompletionException: com.microsoft.bot.connector.rest.ErrorResponseException: Status code 400, {"error": {"code": "BadSyntax","message": "Invalid or missing Activity in request"}}at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:273) ~[na:1.8.0_212]at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:280) ~[na:1.8.0_212]at java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:604) ~[na:1.8.0_212]at java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:577) ~[na:1.8.0_212]at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) ~[na:1.8.0_212]at java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962) ~[na:1.8.0_212]at retrofit2.CompletableFutureCallAdapterFactory$ResponseCallAdapter$2.onResponse(CompletableFutureCallAdapterFactory.java:119) ~[retrofit-2.5.0.jar!/:na]at retrofit2.OkHttpCall$1.onResponse(OkHttpCall.java:129) ~[retrofit-2.5.0.jar!/:na]at okhttp3.RealCall$AsyncCall.execute(RealCall.java:203) ~[okhttp-3.12.2.jar!/:na]at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32) ~[okhttp-3.12.2.jar!/:na]at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[na:1.8.0_212]at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[na:1.8.0_212]at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_212]Caused by: com.microsoft.bot.connector.rest.ErrorResponseException: Status code 400, {"error": {"code": "BadSyntax","message": "Invalid or missing Activity in request"}}at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[na:1.8.0_212]at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) ~[na:1.8.0_212]at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[na:1.8.0_212]at java.lang.reflect.Constructor.newInstance(Constructor.java:423) ~[na:1.8.0_212]at com.microsoft.rest.ServiceResponseBuilder.build(ServiceResponseBuilder.java:122) ~[client-runtime-1.6.12.jar!/:na]at com.microsoft.azure.AzureResponseBuilder.build(AzureResponseBuilder.java:56) ~[azure-client-runtime-1.6.12.jar!/:na]at com.microsoft.bot.connector.rest.RestConversations.replyToActivityDelegate(RestConversations.java:341) ~[bot-connector-4.0.0-SNAPSHOT.jar!/:4.0.0-SNAPSHOT]at com.microsoft.bot.connector.rest.RestConversations.lambda$replyToActivity$4(RestConversations.java:324) ~[bot-connector-4.0.0-SNAPSHOT.jar!/:4.0.0-SNAPSHOT]at java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:602) ~[na:1.8.0_212]... 10 common frames omitted
To Reproduce
Follow steps as described above.
Expected behavior
The bot should work.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
I suspect this is due to a versioning issue, i.e. that the Azure protocol has changed and the corresponding java library is not up to date. I tried updating to the latest version but to no avail.
Furthermore I have tried deploying a bot remotely and registering it with Azure. This gives the same error from "Test in WebChat". Interestingly, I am able to add this bot to Skype and send messages. However the error message is slightly different:
java.util.concurrent.CompletionException: com.microsoft.bot.connector.rest.ErrorResponseException: Status code 400, {"error":{"code":"BadSyntax","message":"Payload is incorrect, field is in the wrong format: timestamp"}}
at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:273) ~[na:1.8.0_222]
at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:280) ~[na:1.8.0_222]
at java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:604) ~[na:1.8.0_222]
at java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:577) ~[na:1.8.0_222]
at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) ~[na:1.8.0_222]
at java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962) ~[na:1.8.0_222]
at retrofit2.CompletableFutureCallAdapterFactory$ResponseCallAdapter$2.onResponse(CompletableFutureCallAdapterFactory.java:119) ~[retrofit-2.5.0.jar:na]
at retrofit2.OkHttpCall$1.onResponse(OkHttpCall.java:129) ~[retrofit-2.5.0.jar:na]
at okhttp3.RealCall$AsyncCall.execute(RealCall.java:203) ~[okhttp-3.12.2.jar:na]
at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32) ~[okhttp-3.12.2.jar:na]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[na:1.8.0_222]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[na:1.8.0_222]
at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_222]
[bug]
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fbotbuilder-java%2Fissues%2F123%3Femail_source%3Dnotifications%26email_token%3DAAH2HBUAEPNC45C3FDEBKQTQM3TMFA5CNFSM4I5MB7WKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HPTBVXA&data=02|01|tracy.boehrer%40microsoft.com|d6b5e4fa36f2484de29f08d74899436a|72f988bf86f141af91ab2d7cd011db47|1|0|637057695409591942&sdata=DFd0zxWPWxqvg9IcHOX9rRzHwQAsmtbEbViUL8xio5s%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAH2HBRX2I7I2M3UF6EVWMDQM3TMFANCNFSM4I5MB7WA&data=02|01|tracy.boehrer%40microsoft.com|d6b5e4fa36f2484de29f08d74899436a|72f988bf86f141af91ab2d7cd011db47|1|0|637057695409591942&sdata=Tq%2BWH2WSneeEUA%2F1kiZnUFe%2BMgcPBZEGF6QrVgOa5sY%3D&reserved=0.

Hi, many thanks for getting back to me on this and apologies for lack of clarity.
I deployed to an existing resource group following the instructions in the readme.md file in the spring-echo sample project.
I will try the recommended branch - hopefully this will resolve the issues (I am keeping my fingers crossed).

Great news, switching to the branch solved my issues. I guess I should have thought of trying this myself... Many, many thanks for your help on this !

Glad to here that.  I merged some fixes for master.  However, I would recommend sticking with the 4.6-preview2 branch for now.  At the end of October, there will be a Preview 3 that includes the bot-builder module with almost all of the functionality from dotnet's bot-builder.


Config file documentation review

fixed typos and white spaces
cleaned up line length for comments

(again: I might have overdone it a bit, sorry for not spitting it up into more commits.)

Thanks!


Allow debugging of trunk and branch interfaces using port mirroring and VPC flow logs

What would you like to be enhanced:

AWS docs “What is Traffic Mirroring?” states that only ENI of type “interface” are supported.
When Security Groups for Pods are enabled, trunk interfaces on supported instance types will be created and a correspomnding CloudWatch Log stream for the trunk ENI will be created. But there is no log stream for branch interfaces.

Why is the change needed and what use case will it solve:

Customer would like to debug trunk and branch interfaces using port mirroring
Customer would like to debug branch ENI by having a dedicated CW log stream for it.

Can you elaborate what the exact use case looks like regarding Traffic Mirroring? Since AWS EC2 console provides branch ENI's info, the mirroring should be feasible to set up. They can easily find the branch interface id from pods' annotation and pods' event history. I am also not sure what log stream for branch interfaces refers to in this case. Thanks.


Run CI on Windows

This PR runs CI on three operating systems:

Linux (Ubuntu)
macOS
Windows

@IanButterworth I'm assuming that the test failures on Windows (both 32-bit and 64-bit) are due to the same GHA temp directory problems that we had on Pkg.jl? Any chance you can help me fix them?

Huh, never mind. That was surprisingly easy to fix.

Alright this is ready to review now.
cc: @kmsquire

Bump @andreasnoack @ararslan


Expose isGroup() and createMappingFunction() in *.d.ts files

Related issue https://github.com/datavisyn/tdp_core/issues/138#issuecomment-441655310
prerequisites:

[x] branch is up-to-date with the branch to be merged with, i.e. develop
[x] build is successful
[x] code is cleaned up and formatted
[x] tested with Firefox 52, Firefox 57+, Chrome 64+, MS Edge 16+

Summary
The functions isGroup() and createMappingFunction() are exported, but ignored in the *.d.ts files. Removing the internal comment should fix this and make it available for the integration in tdp_core.

why is it needed that these to functions are public?

See errors reported in https://github.com/datavisyn/tdp_core/issues/138#issuecomment-441655310.
The related code using this functions:
https://github.com/datavisyn/tdp_core/blob/18bb21670578d6214f32b6b675d6199bdb402a1d/src/lineup/ARankingView.ts#L199
https://github.com/datavisyn/tdp_core/blob/18bb21670578d6214f32b6b675d6199bdb402a1d/src/lineup/internal/cmds.ts#L147

Thanks for merging.


So, I spent 3 hours trying to vagrant up

....then, finally, I install my repo, and type 'git hours' at the prompt expecting magic.
I get this
vagrant@git-hours:~/XXXXXX$ git hours
git: 'hours' is not a git command. See 'git --help'.
vagrant@git-hours:~/XXXXXX$
Any idea at all?

Try to run git-hours. To get the git hours working, I guess you have to have git-hours command in your $PATH. Anyways, just git-hours should work.

I changed the wording about Vagrant in the README.md. It's more about easing the pain to install the dependencies: node, nodegit etc. Not always the quickest installation option.

Nah 'git-hours' didnt work - for me

I just installed the vagrant box with: vagrant up, then vagrant ssh and git hours command worked for me so I can't replicate the issue.

You need to locate where the git-hours binary was installed and run it from there, or add the containing directory to $PATH.

Is it right that that vagrant box has been up since 2012?
I am 'vagrant reload'ing my box now to see if its made a difference

(thanks for your help)

I am not alone
http://stackoverflow.com/questions/31604512/git-hour-hours-is-not-a-git-command

The vagrant apparently is using pretty old version of Ubuntu. Someone three years ago has packaged the box, that's why it shows the last login then. It hasn't been up for three years, though. No problem.

I am confused - there is a git hours binary somewhere?
I cant see it in the repo.......

By "binary" I mean the index.js. On npm install, npm should install the file so that it can be run.

I don't know how to help further since I don't have any logs / information about your system. I got it working by following the Vagrant setup guide. Here's an example from my vagrant box:
➜  git-hours git:(master) ✗ vagrant ssh
git-Welcome to Ubuntu 12.04 LTS (GNU/Linux 3.2.0-23-generic x86_64)

 * Documentation:  https://help.ubuntu.com/
New release '14.04.2 LTS' available.
Run 'do-release-upgrade' to upgrade to it.

Welcome to your Vagrant-built virtual machine.
Last login: Fri Jul 24 08:03:02 2015 from <IP_ADDRESS>
git-hvagrant@git-hours:~$ git-hours
Error: Could not find repository from '.'
vagrant@git-hours:~$ which git-hours
/usr/bin/git-hours
vagrant@git-hours:~$ git clone https://github.com/twbs/bootstrap
Cloning into 'bootstrap'...
remote: Counting objects: 73036, done.
remote: Compressing objects: 100% (3/3), done.
remote: Total 73036 (delta 0), reused 0 (delta 0), pack-reused 73033
Receiving objects: 100% (73036/73036), 85.69 MiB | 1.35 MiB/s, done.
Resolving deltas: 100% (44482/44482), done.
vagrant@git-hours:~$ cd bootstrap/
vagrant@git-hours:~/bootstrap$ git hours
git-hours{
  "total": {
    "hours": 7894,
    "commits": 11470
  }
}
vagrant@git-hours:~/bootstrap$ git-hours
{
  "total": {
    "hours": 7894,
    "commits": 11470
  }
}
vagrant@git-hours:~/bootstrap$

In your vagrant box, try to run:
sudo apt-get -y update
sudo apt-get -y install git python-software-properties python g++ make
sudo add-apt-repository -y ppa:chris-lea/node.js
sudo apt-get -y update
sudo apt-get -y install nodejs

npm install -g git-hours

After that, try git hours in any repository.
If it doesn't work, please provide the output of the above commands, and also output of:
which node
which git-hours
which npm
node --version
npm --version

So after I figured out I needed to 'sudo npm install -g git-hours' I got the following error
vagrant@git-hours:~$ sudo npm install -g git-hours
/

<EMAIL_ADDRESS>install /usr/lib/node_modules/git-hours/node_modules/nodegit
node lifecycleScripts/install

module.js:485
throw err;
^
SyntaxError: /usr/lib/node_modules/git-hours/node_modules/nodegit/generate/input/v0.22.2.json: Unexpected token
npm ERR<EMAIL_ADDRESS>install: node lifecycleScripts/install
npm ERR! Exit status 8
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is most likely a problem with the nodegit package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node lifecycleScripts/install
npm ERR! You can get their info via:
npm ERR!     npm owner ls nodegit
npm ERR! There is likely additional logging output above.
npm ERR! System Linux 3.2.0-23-generic
npm ERR! command "/usr/bin/node" "/usr/bin/npm" "install" "-g" "git-hours"
npm ERR! cwd /home/vagrant
npm ERR! node -v v0.10.37
npm ERR! npm -v 1.4.28
npm ERR! code ELIFECYCLE
npm ERR! not ok code 0
I will shortly post the responses to your commands

which node

usr/bin/node/

which git-hours

Nothing. Nada. Probably related to failed install above

which npm

usr/bin/npm

node --version

v0.10.37

npm --version

1.4.28

Not sure if this helps, but i rebuilt the vagrant box and I noticed this error
==> default: [nodegit] Everything is ready to go, attempting compilation
==> default: [nodegit] Building native node module.
==> default: { [Error: Command failed: npm ERR! addLocal Could not install /usr/lib/node_modules/nodegit
==> default: npm ERR! Linux 3.2.0-23-generic
==> default: npm ERR! argv "node" "/usr/lib/node_modules/nodegit/node_modules/.bin/npm" "install" "--ignore-scripts"
==> default: npm ERR! node v0.10.37
==> default: npm ERR! npm  v2.13.2
==> default: npm ERR! path /root/.npm/nodegit/0.4.1/package
==> default: npm ERR! code EACCES
==> default: npm ERR! errno 3
==> default:
==> default: npm ERR! Error: EACCES, mkdir '/root/.npm/nodegit/0.4.1/package'
==> default: npm ERR!  { [Error: EACCES, mkdir '/root/.npm/nodegit/0.4.1/package']
==> default: npm ERR!   errno: 3,
==> default: npm ERR!   code: 'EACCES',
==> default: npm ERR!   path: '/root/.npm/nodegit/0.4.1/package' }
==> default: npm ERR!
==> default: npm ERR! Please try running this command again as root/Administrator.
==> default:
==> default: npm ERR! Please include the following file with any support request:
==> default: npm ERR!     /usr/lib/node_modules/nodegit/npm-debug.log
==> default: ] killed: false, code: 3, signal: null }
==> default: undefined
==> default<EMAIL_ADDRESS>/usr/lib/node_modules/mocha
==> default: ├──<EMAIL_ADDRESS>==> default: ├──<EMAIL_ADDRESS>==> default: ├──<EMAIL_ADDRESS>==> default: ├──<EMAIL_ADDRESS>==> default: ├──<EMAIL_ADDRESS>==> default: ├──<EMAIL_ADDRESS><EMAIL_ADDRESS>==> default: ├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>==> default: ├──<EMAIL_ADDRESS><EMAIL_ADDRESS>==> default: └──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>==> default:
==> default<EMAIL_ADDRESS>/usr/lib/node_modules/nodegit
==> default: ├──<EMAIL_ADDRESS><EMAIL_ADDRESS>==> default: ├──<EMAIL_ADDRESS><EMAIL_ADDRESS>==> default: ├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>==> default: ├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>==> default: └──<EMAIL_ADDRESS>==> default: Running provisioner: shell...
default: Running: inline script
==> default: stdin: is not a tty
==> default: Running provisioner: shell...
default: Running: inline script
==> default: stdin: is not a tty
==> default:
==> default: ><EMAIL_ADDRESS>install /usr/lib/node_modules/git-hours/node_modules/nodegit
==> default: > node install.js
==> default: [nodegit] Determining dependencies.
==> default: [nodegit] Removing vendor/libgit2.
==> default: [nodegit] Fetching vendor/libgit2.
==> default: [nodegit] Configuring native node module.
==> default: [nodegit] Building native node module.
==> default: [nodegit] Failed to build nodegit.
==> default: [nodegit] Attempting to fallback on a prebuilt binary.
==> default: [nodegit] Fetching binary from S3.
==> default: [nodegit] Completed installation successfully.
==> default: /usr/bin/git-hours -> /usr/lib/node_modules/git-hours/index.js
==> default<EMAIL_ADDRESS>/usr/lib/node_modules/git-hours
==> default: ├──<EMAIL_ADDRESS>==> default: ├──<EMAIL_ADDRESS>==> default: ├──<EMAIL_ADDRESS><EMAIL_ADDRESS>==> default: ├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>==> default: └──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Kimmo, Im sorry, I gave up.....

@niclowe I got that same error when installing vagrant box but git-hours worked in the end. I'm sorry that you didn't get this fun tool running, nodegit is indeed quite tough to get installed sometimes.
Since you gave up I'll close this for now. Feel free to reopen this issue if you want to get back to this. We can have a Google Hangouts if you want to get it working. Anyone else getting the same error, please reopen this issue.

Had the same problem, and have found a work around:
Install nodegit manually (run npm install -g nodegit [as an administrator / i.e. sudo or cmd with admin privileges])
Locate the node_modules root directory (should now include both nodegit and git-hours). Navigate into nodegit's build folder and copy the release folder. Now navigate to the node_modules/git-hours folder, and then to git-hour's node_modules folder (which will contain a nodegit folder). Replace the git-hours\node_modules\nodegit\build\Release folder with the Release folder from node_modules\nodegit\build\Release. Furthermore, copy the folder again to the same directory, but this time name it Debug, not Release.
3). Try running git hours again, from within your chosen git repo.


Bindings still evaluated despite "if" attribute test failing

Originally opened as dart-lang/sdk#21110
This issue was originally filed by<EMAIL_ADDRESS>
What steps will reproduce the problem?

Make a <template> attribute with a failing "if", and some binding that would cause an exception.
  e.g. <template if="{{false}}" bind="{{false['key']}}"></template>
Use this in a page.

What is the expected output? What do you see instead?
The expected output is nothing.  Instead
What version of the product are you using?
Polymer.dart 0.12.
On what operating system?
Windows 8
What browser (if applicable)?
Dartium 37.0.2062.76 (289648).
Please provide any additional information below.

<img src="https://avatars.githubusercontent.com/u/1343914?v=3" align="left" width="48" height="48"hspace="10"> Comment by sgjesse

Added Area-Pkg, Pkg-Polymer, Triaged labels.

This comment was originally written by<EMAIL_ADDRESS>
Sorry, forgot to mention what I see instead: an exception is thrown upon Polymer.dart trying to use the [] operator of bool.


add strip_num and strip_alpha modifiers

Coverage increased (+0.02%) to 99.467% when pulling d60fb50c6b6317df558d7254fb6294ba47f0e0e9 on frederikhors:add-num-modifier into df5a59bfe050f4dd502ba297b9b5e8302aae6218 on go-playground:master.

I added here unicode ones.


Add support for promscale ext 0.2.x

This is the newest version of the extension.
Start support for pushdowns of vector selector
and rate/increase with this version as the
beta had some correctness issues with rate/increase.

bors r+


Boomerang Agent Builder

Currently we have a form for Boomerang Agent Builder which can be found at: http://<IP_ADDRESS>:8000/index#/browser/agent/builder
We need to implement functionality that is building JS file which is concatenation in this order  of:

Boomerang JS
Boomerang Plugins
Boomerang config snippet

For boomerang config snippet we need to add this JS:
BOOMR.init({
    beacon_url: "http://yoursite.com/beacon/"
  });

Once the file is generated we should minify the JS. We can use what we are doing here with closure compiler: https://github.com/revampix/boomerang-client-builder/blob/master/src/boomerang-build.php
Boomerang source:
We can find JS source files here:

Boomerang JS: https://raw.githubusercontent.com/SOASTA/boomerang/master/boomerang.js
Boomerang Plugins: https://github.com/SOASTA/boomerang/tree/master/plugins

We need to add Boomerang JS in our project and we need to place them in folder with nice name because those libraries are updated every 4 months. May be when we have a new release of Boomerang we will create new folder with actual plugins and Boomerang JS.
Later we will add links to every plugin official documentation but not now.
History:
We need to keep history of all Boomerang builds in order the admins to be able to look at or download old builds. The build also needs to contain meta information which settings were used for build.
At the end after a build is ready it should appear in right side column with build date. Currently we have a mockup only with build date but we also can add little info what a build contains.
This example of the mockup:

Additionally I will add:

Iframe include snippet
Links to documentation of Boomerang project

Currently the builds section looks like:
Build configuration

Build info


Update use-group-policy.md

Updated string IDs

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@adeejoseph
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@adeejoseph
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Add sort_keys option

As a prettier option and a big improval for tests that compare a toml file, I think a sort_keys like json option is useful.It ensure two toml file with same content will be able to do a text-compare after sorting keys.

Thanks for the issue!
As the README file mentions, Tomli-W respects sort order of the input dict, so you can do
import tomli_w

def order_dict(d):
    return {k: order_dict(v) if isinstance(v, dict) else v for k, v in sorted(d.items())}

d = {"b": 2, "a": {"b": 2, "a": 1}}
sorted_toml = tomli_w.dumps(order_dict(d))

It's trivial enough to come up with a sort function of your own that I'm not sure Tomli-W needs to ship with one (that may not sort exactly the way you want).


TTL doesn't decrement

TTL doesn't decrement, but always shows the value that the domain was configured with
test.com.		30	IN	A	<IP_ADDRESS>
# sleep 5 && dig test.com
test.com.		30	IN	A	<IP_ADDRESS>

That’s expected for an authoritative server. Why would it go down?

Hey good point! Thanks


The usage of regex  in replace will change only the first match. Consider using a regular expression with the global replacement flag (/g).

Describe the bug
In File: src/components/ knnresults.js
The usage of regex [Line:229] in replace [Line:229] will change only the first match. Consider using a regular expression with the global replacement flag (/g).
File: src/components/ knnresults.js
To Reproduce
Done by source-code analysis using AI to learn from millions of developers around the world.
Additional context
See the details here after logging into GitHub:
https://www.deepcode.ai/app/gh/covid19india/covid19india-react/212c2d6e2e18f47566cc2b771bc28d1ca6ea941d/_/%2Fsrc%2Fcomponents%2Fknnresults.js/javascript%2Fdc%2FGlobalReplacementRegex/229/code
There are 8 other issues with suggestions in the report.

/claim


Incorrect response while querying array in vespa

Describe the bug
We have added an array of struct field in our vespa schema. Our struct has a string key and value.
We want to write a query such that the key and value matches with a particular array elememnt .
Please let us know if this is expected behavior.
{
"yql": "select * from sources * where weakAnd(field_s contains sameElement(key contains "wildCardKeyp_s", value contains "wildCardFieldValueg"),field_s contains sameElement(key contains "wildCardKeyp_s", value contains "wildCardFieldValuev"));",
"timeout": "120s",
"hits": 50
}
But in the response payload we are getting documents where the key and value are not part of same struct,
Example -
"field_s": {
"wildCardKeym_s": "wildCardFieldValuel",
"wildCardKeyb_s": "wildCardFieldValuea",
"wildCardKeyp_s": "wildCardFieldValuer",
"wildCardKeys_s": "wildCardFieldValued",
"wildCardKeyw_s": "wildCardFieldValuet",
"wildCardKeyy_s": "wildCardFieldValuel",
"wildCardKeyj_s": "wildCardFieldValuep"
}
Expected behavior
We wanted to retrieve documents that have array elements {key:wildCardKeyp_s, value: wildCardFieldValueg} or {key:wildCardKeyp_s, value: wildCardFieldValuev}
Environment (please complete the following information):

Infrastructure: Kubernetes

Vespa version
7.559.12

I'm not sure what you expect here by using weakAnd, can you simplify this report by
A) what does a single sameElement operator do, and does it match your expectations
2) What does sameElement() or sameElement do
And how is the array of struct field defined?

struct wildcard_string {
field key type string { }
field value type string { }
}
field field_s type array<wildcard_string> {
indexing: summary
struct-field key {
indexing: attribute
attribute: fast-search
}
       struct-field value {
            indexing: attribute
            attribute: fast-search
       }

}
A) I want to retrieve documents where the key and value are in the same struct. Example if I am searching with field_s contains sameElement(key contains x, value contains y) it should only match with documents that have an array element {key: x, value: y}
B) I want to retrieve docs that contain docs that contains either {key: x, value: y} or {key: x, value: z}

Yes, that is what sameElement does. Please try as I said with

Using 1 sameElement and see if that match your expectations
Using 2 sameElement and connect them using logical or.

I'm not sure if weakAnd is what you want here, weakAnd is a very special query operator as described in https://docs.vespa.ai/en/using-wand-with-vespa.html to be used for text search matching.

{
"yql": "select * from sources * where field_s contains sameElement(key contains "wildCardKeyb_s", value contains "wildCardFieldValuev") OR field_s contains sameElement(key contains "wildCardKeyb_s", value contains "wildCardFieldValueo");",
"timeout": "120s",
"hits": 50
}
Response had this document -
field_s": {
"wildCardKeyl_s": "wildCardFieldValues",
"wildCardKeyb_s": "wildCardFieldValuen",
"wildCardKeyo_s": "wildCardFieldValuee",
"wildCardKeyj_s": "wildCardFieldValueo",
"wildCardKeyy_s": "wildCardFieldValues",
"wildCardKeyi_s": "wildCardFieldValuey",
"wildCardKeye_s": "wildCardFieldValuem",
"wildCardKeyg_s": "wildCardFieldValuer"
},
{
"yql": "select * from sources * where field_s contains sameElement(key contains "wildCardKeyb_s", value contains "wildCardFieldValuev");",
"timeout": "120s",
"hits": 50
}
Documents in the response
field_s": {
"wildCardKeyl_s": "wildCardFieldValues",
"wildCardKeyb_s": "wildCardFieldValuen",
"wildCardKeyo_s": "wildCardFieldValuee",
"wildCardKeyj_s": "wildCardFieldValueo",
"wildCardKeyy_s": "wildCardFieldValues",
"wildCardKeyi_s": "wildCardFieldValuey",
"wildCardKeye_s": "wildCardFieldValuem",
"wildCardKeyg_s": "wildCardFieldValuer"
}

Is it possible to not use an example that could look like spell mistakes? wildCardKeyy_s. Formatting of the json would also help.
Here is the system test for searching in array of struct using the sameElement query operator.

Feed file https://github.com/vespa-engine/system-test/blob/master/tests/search/struct_and_map_types/docs_search.json
tests https://github.com/vespa-engine/system-test/blob/master/tests/search/struct_and_map_types/struct_and_map_types.rb#L54

If you are able to create a reproducible setup it would be great.

Hey Joe,
We used random field names to populate the arrays.
Reproducible Steps would be

Deploy vespa application with array of structs.

struct wildcard_string {
field key type string { }
field value type string { }
}
field field_s type array<wildcard_string> {
indexing: summary
struct-field key {
indexing: attribute
attribute: fast-search

}
struct-field value {
        indexing: attribute
        attribute: fast-search
}

}

Try searching using yqls similar to the ones mentioned above.

Again, our tests demonstrate that this works as intended, so it's up to you to demonstrate how to reproduce what you observe.
Here is the system test for searching in array of struct using the sameElement query operator.
Feed file https://github.com/vespa-engine/system-test/blob/master/tests/search/struct_and_map_types/docs_search.json
tests https://github.com/vespa-engine/system-test/blob/master/tests/search/struct_and_map_types/struct_and_map_types.rb#L54

@jobergum
So we realised that the sameElement works perfectly, however the confusion was due to search response garbling up the struct
Ingest payload
my_favourite_food_array_field: [
{ "key":"mango",
"value":"ladyfinger"},
{ "key":"grapes",
"value":"chickpea"},
{ "key":"apple",
"value":"beans"} ]

Search result:
Note how struct field name is removed altogether and mapping from one key-value pair to another is messed up. Are key and value special keywords?
my_favourite_food_array_field:
{
"mango":"beans",
"grapes":"ladyfinger",
"apple":"chickpea"}

Note that matched-elements-only only will display elements that matched the query https://docs.vespa.ai/en/reference/schema-reference.html#summary

We are not using matched-elements-only if that's what you mean in the comment above @jobergum ?

Yes. Feel free to produce a simple schema, a sample document, and a query that reproduces the behavior.

Hey Neha,
Schema defined ->
    struct wildcard_string {
        field key type string { }
        field value type string { }
    }

	field field_s type array<wildcard_string> {
        indexing: summary
        struct-field key {
             indexing: attribute

       }

       struct-field value {
            indexing: attribute

       }
    }

Doc ingestion payload -
{
"fields": {
"field_s": [
{
"key": "fruit",
"value": "apple"
},
{
"key": "fruit",
"value": "banana"
},
{
"key": "fruit",
"value": "orange"
},
{
"key": "food",
"value": "burger"
},
{
"key": "food",
"value": "pizza"
},
{
"key": "food",
"value": "pasta"
}
],
"isNewWildCardFieldAdded": true,
"author": [
"person"
],
"language": "English",
"table": "tableName"
}
}
Search with docId -
{
"pathId": "/document/v1/namespace/documentType/docid/701683489",
"id": "id:namespace:documentType::701683489",
"fields": {
"language": "English",
"table": "tableName",
"eventualIndex": false,
"field_s": [
{
"value": "apple",
"key": "fruit"
},
{
"value": "banana",
"key": "fruit"
},
{
"value": "orange",
"key": "fruit"
},
{
"value": "burger",
"key": "food"
},
{
"value": "pizza",
"key": "food"
},
{
"value": "pasta",
"key": "food"
}
],
"isNewWildCardFieldAdded": true,
"author": [
"person"
]
}
}
yql search with one sameElement
{
"root": {
"id": "toplevel",
"relevance": 1.0,
"fields": {
"totalCount": 1
},
"coverage": {
"coverage": 100,
"documents": 6414070,
"full": true,
"nodes": 228,
"results": 38,
"resultsFull": 38
},
"children": [
{
"id": "id:namespace:documentType::701683489",
"relevance": 0.0,
"source": "lexdoc",
"fields": {
"sddocname": "documentType",
"documentid": "id:namespace:documentType::701683489",
"author": [
"person"
],
"language": "English",
"table": "tableName",
"field_s": {
"fruit": "orange",
"food": "pasta"
},
"eventualIndex": false,
"isNewWildCardFieldAdded": true
}
}
]
}
}

@jobergum
Schema defined ->
    struct wildcard_string {
        field key type string { }
        field value type string { }
    }

	field field_s type array<wildcard_string> {
        indexing: summary
        struct-field key {
             indexing: attribute

       }

       struct-field value {
            indexing: attribute

       }
    }

Doc ingestion payload -
{
"fields": {
"field_s": [
{
"key": "fruit",
"value": "apple"
},
{
"key": "fruit",
"value": "banana"
},
{
"key": "fruit",
"value": "orange"
},
{
"key": "food",
"value": "burger"
},
{
"key": "food",
"value": "pizza"
},
{
"key": "food",
"value": "pasta"
}
],
"isNewWildCardFieldAdded": true,
"author": [
"person"
],
"language": "English",
"table": "tableName"
}
}
Search with docId -
{
"pathId": "/document/v1/namespace/documentType/docid/701683489",
"id": "id:namespace:documentType::701683489",
"fields": {
"language": "English",
"table": "tableName",
"eventualIndex": false,
"field_s": [
{
"value": "apple",
"key": "fruit"
},
{
"value": "banana",
"key": "fruit"
},
{
"value": "orange",
"key": "fruit"
},
{
"value": "burger",
"key": "food"
},
{
"value": "pizza",
"key": "food"
},
{
"value": "pasta",
"key": "food"
}
],
"isNewWildCardFieldAdded": true,
"author": [
"person"
]
}
}
yql search with one sameElement
{
"root": {
"id": "toplevel",
"relevance": 1.0,
"fields": {
"totalCount": 1
},
"coverage": {
"coverage": 100,
"documents": 6414070,
"full": true,
"nodes": 228,
"results": 38,
"resultsFull": 38
},
"children": [
{
"id": "id:namespace:documentType::701683489",
"relevance": 0.0,
"source": "lexdoc",
"fields": {
"sddocname": "documentType",
"documentid": "id:namespace:documentType::701683489",
"author": [
"person"
],
"language": "English",
"table": "tableName",
"field_s": {
"fruit": "orange",
"food": "pasta"
},
"eventualIndex": false,
"isNewWildCardFieldAdded": true
}
}
]
}
}

I have reproduced the issue, using https://github.com/vespa-engine/sample-apps/tree/master/album-recommendation and added to music.sd:
        struct wildcard_string {
            field key type string { }
            field value type string { }
        }

        field field_s type array<wildcard_string> {
            indexing: summary
            struct-field key {
                 indexing: attribute
            }
            struct-field value {
                indexing: attribute
            }
        }

I ingested this file:
{
  "put": "id:mynamespace:music::fruits",
  "fields": {
    "field_s": [
      {
        "key": "fruit",
        "value": "apple"
      },
      {
        "key": "fruit",
        "value": "banana"
      },
      {
        "key": "fruit",
        "value": "orange"
      },
      {
        "key": "food",
        "value": "burger"
      },
      {
        "key": "food",
        "value": "pizza"
      },
      {
        "key": "food",
        "value": "pasta"
      }
    ]
  }
}

Query:
$ vespa query "select * from music where true"
{
    "root": {
        "id": "toplevel",
        "relevance": 1.0,
        "fields": {
            "totalCount": 1
        },
        "coverage": {
            "coverage": 100,
            "documents": 1,
            "full": true,
            "nodes": 1,
            "results": 1,
            "resultsFull": 1
        },
        "children": [
            {
                "id": "id:mynamespace:music::fruits",
                "relevance": 0.0,
                "source": "music",
                "fields": {
                    "sddocname": "music",
                    "documentid": "id:mynamespace:music::fruits",
                    "field_s": {
                        "fruit": "orange",
                        "food": "pasta"
                    }
                }
            }
        ]
    }
}

see that for field_s, we get the last element for fruit and food - it behaves like a map.
I then re-did the experiment, but this time I used kkey and vvalue :
        struct wildcard_string {
            field kkey type string { }
            field vvalue type string { }
        }

        field field_s type array<wildcard_string> {
            indexing: summary
            struct-field kkey {
                 indexing: attribute
            }
            struct-field vvalue {
                indexing: attribute
            }
        }

{
  "put": "id:mynamespace:music::fruits",
  "fields": {
    "field_s": [
      {
        "kkey": "fruit",
        "vvalue": "apple"
      },
      {
        "kkey": "fruit",
        "vvalue": "banana"
      },
      {
        "kkey": "fruit",
        "vvalue": "orange"
      },
      {
        "kkey": "food",
        "vvalue": "burger"
      },
      {
        "kkey": "food",
        "vvalue": "pizza"
      },
      {
        "kkey": "food",
        "vvalue": "pasta"
      }
    ]
  }
}

$ vespa query "select * from music where true"
{
    "root": {
        "id": "toplevel",
        "relevance": 1.0,
        "fields": {
            "totalCount": 1
        },
        "coverage": {
            "coverage": 100,
            "documents": 1,
            "full": true,
            "nodes": 1,
            "results": 1,
            "resultsFull": 1
        },
        "children": [
            {
                "id": "id:mynamespace:music::fruits",
                "relevance": 0.0,
                "source": "music",
                "fields": {
                    "sddocname": "music",
                    "documentid": "id:mynamespace:music::fruits",
                    "field_s": [
                        {
                            "kkey": "fruit",
                            "vvalue": "apple"
                        },
                        {
                            "kkey": "fruit",
                            "vvalue": "banana"
                        },
                        {
                            "kkey": "fruit",
                            "vvalue": "orange"
                        },
                        {
                            "kkey": "food",
                            "vvalue": "burger"
                        },
                        {
                            "kkey": "food",
                            "vvalue": "pizza"
                        },
                        {
                            "kkey": "food",
                            "vvalue": "pasta"
                        }
                    ]
                }
            }
        ]
    }
}

This time, we get all the 6 elements in the field_s field.

Are key and value special keywords?
I think you are spot on, @nehajatav . I think this is due to the way https://docs.vespa.ai/en/reference/schema-reference.html#type:map is implemented. I will have @geirst comment on this - it could be that using an array of key,value is a restriction and should be documented.

I will update once @geirst has chimed in - but you now know that not using key/value as names is a workaround, unless you want this to behave as a map ...

@arnej27959 I think this behavior changes with vespa-8 / maybe we can configure Vespa for new behavior now? or other things we should know?

To render maps as json maps use: renderer.json.jsonMaps
as a query property.

Thanks! here we use array of struct and I think we want to have the array with all elements in the response - not interpreted as a map with only unique key-elements

Aha, it’s the opposite problem. Indeed, an array of objects with «key» and «value» fields is recognized as a map. So key/value are reserved words here.

Thanks!
Will define the schema with different key and value names.

I have added this to documentation in https://github.com/vespa-engine/documentation/pull/2041 - thanks for finding this!


Deleting package from Search index doesn't work

While updating index, package deletes from DB are not applied to the search index and the UpdateSearchIndexJob throws "ArgumentOutofRangeException"
The issue seems to be related to the commit : .
https://github.com/NuGet/NuGet.Services.Search/commit/bc77f5d2ffa62d9764f95b0d106ab93b15fa6b24#diff-8728326a7661b44a7f1a61a0e0be07a7.
The PackageFetcher ( @ https://github.com/NuGet/NuGet.Services.Search/blob/master/src/NuGet.Indexing/UpdateIndexTask.cs#L52) tries to retrieve the package record from DB using the package key. While this works fine for Adds and updates, deletes doesn't work as the record with the specific key will not be found in the DB anymore ( as the package is already deleted).

closing this issue here as its is covered by the consolidation issue.


Add optional kwargs when initialising SentenceTransformerEmbeddingFunction class

https://github.com/chroma-core/chroma/blob/1e5e024fa2984e06d1ab17ee3d9c4960c56400b4/chromadb/utils/embedding_functions.py#L63
See example usage of the trust_remote_code variable that can be passed to the SentenceTransformer class.
from sentence_transformers import SentenceTransformer
model = SentenceTransformer("nomic-ai/nomic-embed-text-v1", trust_remote_code=True)

Thanks for the feature request @hhan-wooliesx . This seems relatively straightforward -- I'd be happy to review a PR on this or I may be able to get to it this week.

I have a PR ready for review

Closing as the PR #1891 has been merged and released in 0.5.0


Alleyway (World) GB cannot move the paddle

Fixed in dev. https://github.com/skylersaleh/SkyEmu/pull/40


Text/Code viewer not executed

withStreamClaimRender not loading the code viewer right

Seems like closed by #2603

Opinion:  the withStreamClaimRender HOC design is problematic when it's variables, sourceLoaded for example, is mutated by the wrapped child.  Wrapper and wrappee should be orthogonal, no?  If not mistaken, for the embed player case, it currently needs to let the child render first so that sourceLoaded is updated (I could be wrong).
Perhaps hooks are a better choice to consolidate logic?
Related:  https://github.com/OdyseeTeam/odysee-frontend/issues/2624 (had to revert the earlier fix)


[7458] DTTP namespace should be removed from register part 2

Context
o clear some tech debt we want to remove references to DTTP from the codebase. There are many such references so we'll do this in multiple PRs. This second PR follows on from https://github.com/DFE-Digital/register-trainee-teachers/pull/4578 and removes code that interfaces with the DTTP API.
Changes proposed in this pull request
Remove:

DTTP Parsers
API client classes
API sync jobs

Guidance to review
Per commit recommended
Important business

[x] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
[x] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?
[x] Do we need to send any updates to DQT as part of the work in this PR?
[x] Does this PR need an ADR?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

Looks like there's some specs to be fixed or removed.


Make use of tslib

TypeScript generates lots of helpers for inheritance et al. They bloat up our code. We have some fragile regex tricks to remove unnecessary code. Since TypeScript support has gotten a lot better we should make use of tslib and the new emit flags

Closing this without action because the fix for #24770 will check that our current solution works and leaving out helper at compile time will make development harder. Removing waste at bundling is the right point in time


(firefox)  Exploitable Vulnerability in version < 130

Checklist

[X] I have checked the moderation queue that no new version has been submitted (only visible when logged in), or the submitted package version has failed the automated checks.

Please navigate to the following link to view the moderation queue.

[X] I have verified that the new version is a stable release.
[X] I have looked to see if there are any Bug reports that prevents a new version being submitted and that no existing Outdated Reports have been created.
[X] I have verified the new version has a Windows binary (EXE or MSI installer, Zip or other archive, etc).
[X] I have verified that this is the correct repository, and the package is maintained by the chocolatey-community user.

New Software Version
130.0
Download location
https://download.mozilla.org/?product=firefox-130.0-ssl&os=win&locale
Package Page
https://community.chocolatey.org/packages/Firefox

CVE Info: https://www.cvedetails.com/cve/CVE-2024-8389/

What is it you're asking to be done?

What is it you're asking to be done?

Most likely the au script for Firefox needs a fix: https://gist.github.com/choco-bot/a14b1e5bfaf70839b338eb1ab7f8226f/a6e3f26d8e8af3f4788aff0b124d4db850786830#firefox. After fixing that script, it's likely that the Firefox package in Chocolatey community will be updated to 130 with vulnerabilities fixed.

As this is a community repository, there is no one person to fix, enhance or manage anything. PR's are welcome.

As this is a community repository, there is no one person to fix, enhance or manage anything. PR's are welcome.

Accepted!

My parts is done.

Anything I need to do to get things started?


Module request: Wreckfest

Module Request
Game Information:

Game Title: Wreckfest Dedicated Server
Where it can be obtained: Steam
Supported OSs and platforms: Windows 7+
Does the server support either RCON or console input to administer it? Console input
NOTE - Dedicated server might require purchase of the actual game (binaries are.. the same-ish)

I confirm:

[x] that I have searched for an existing module request for this application.
[x] that the server is an official server distributed by the games publishers/developers.
[x] that the server is available to the general public.
[x] that the server can be run headless (without a GUI).

Please note that wreckfest (dedicated server) is constructed in an weird way. Server-information, and banlist are stored under the specific users profile - meaning running more than one server will corrupt files and create mayhem. Recommended approach is to keep each server under a specific account. Also the console is an odd child, and server log-file cannot be verbose enough to show a "mirror" of the console. Some commands can only be performed under the console as well. The server binaries are not "clean" from the full game binaries, as it has dependencies on directx ..

Can you tidy up the checkboxes in your original post? They should be [x] verbatim for ticked.

Can you tidy up the checkboxes in your original post? They should be [x] verbatim for ticked. You also need to remove the comment tags so the post can be seen in full.

Done - However - I am not 100% sure as my note stated in the request itself that the server is available via steam without the purchase. Hence, the not checked box ' available to general public' .

As long as it can be downloaded via steamcmd or similar it's not a problem and can be worked around.

Like to have Wreckfest too.

Does the server have a Linux version?


Fix/setup

added version in  init
remove automatic pytest
remove fenics requirements

The code changes don't seem to reflect what the pr description is. Is this ready for review?

Forgot to push...Now it reflects the description

Does this fix the issue that you were experiencing? Seems like you had an incompatibility w versions.  Shouldn't we set the install equal to what we have so the install gives a clearer error message "incompatible fenics version"?

I added a warning in the version of Dolfin is wrong and the program stops if Dolfin is not installed. See init.py

Done. I also moved to HTML so it looks nicer on github


Error message stays in a system, although it's not actual

Describe the bug
System keeps error message although it's not actual
Set up
https://www.kafka-ui.provectus.io/
Steps to Reproduce
Steps to reproduce the behavior:

Navigate to any form (f.ex.HSQL query execution)
Input data in a wrong format
Press Execute
Make sure that error message appears
Correct the data format
Press Execute again

Expected behavior
The error message should disappear if it's not actual
Screenshots
https://user-images.githubusercontent.com/104780608/174954612-0e55618d-bc87-494b-9816-742e14feff55.mov
Additional context

Fixed in #2312


Enable visitor of pass.jhu.edu to see a user friendly message during the Proxy Submitter feature migration window.

Ideally, the static and public pages would be available to the public during migration. Only when user logs in that he/she shown the under construction message. But if that's too much given the timeframe, taking PASS completely offline would be fine.
I think the work would at least include:

(For Karen) creation of a themed and static html page with appropriate message to be shown to visitor
-- The message should include the time estimate as to when PASS will be back online
(For Derek) some magic that would show user the above page at the opportune time (either when they visit pass.jhu.edu or when they get to pass.jhu.edu/app) depending on how complicate this is to implement.

Hmm.  This is very difficult as the infrastructure completely goes down.  I can bring up a new docker service to serve a single web page.
This will work for https://pass.jhu.edu and all under it.  I just need the assets from @karenhanson

@derekbelrose as I mentioned in the plan for next week, we can launch without this being implemented, if it proves to be too much for the time frame.

I understand, but I do think it is important to have regardless.  If I have time, I want to implement this functionality for downtime, updates, etc.


Fix schemas transformation

Fixes #1162
Fixes #1167

Codecov Report

Merging #1168 (e9f6ea5) into master (ce92e34) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1168      +/-   ##
==========================================
- Coverage   99.34%   99.19%   -0.16%
==========================================
  Files          69       69
  Lines        5194     5193       -1
  Branches      848      848
==========================================
- Hits         5160     5151       -9
- Misses         17       22       +5
- Partials       17       20       +3

Flag
Coverage Δ

unittests
99.19% <100.00%> (-0.12%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/schemathesis/specs/openapi/parameters.py
100.00% <ø> (ø)

src/schemathesis/specs/openapi/schemas.py
100.00% <100.00%> (ø)

src/schemathesis/_compat.py
50.00% <0.00%> (-50.00%)
:arrow_down:

src/schemathesis/extra/pytest_plugin.py
98.23% <0.00%> (-1.77%)
:arrow_down:

src/schemathesis/cli/callbacks.py
98.24% <0.00%> (-1.76%)
:arrow_down:

src/schemathesis/cli/cassettes.py
98.43% <0.00%> (-1.57%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce92e34...e9f6ea5. Read the comment docs.


ES5 class rewriting incompatible with frozen intrinsics

Bug Report
When TSC targets ES5, classes that extend other classes generate JS that throws a Cannot assign to read only property 'constructor' of object TypeError when the intrinsics, particularly the Function.prototype, are frozen. This affects programs that are freezing their intrinsics to protect against supply chain attacks, particularly using SES.
🔎 Search Terms

constructor
frozen

🕗 Version & Regression Information
I identified this issue in the published code of external-editor 3.1.0, which is using TypeScript 3.5.2 https://github.com/mrkmg/node-external-editor/blob/e1070a8295b8ebbafa7b29802ae0e2da0fad47c0/tsconfig.json
In the playground, the output is consistent for the very oldest and very newest versions of TypeScript when targeting ES5.
⏯ Playground Link
Playground link with relevant code
💻 Code
Object.freeze(Function);
Object.freeze(Function.prototype);
class Foo {
    constructor() {
    }
}
class Bar extends Foo {
    constructor() {
    }
}

🙁 Actual behavior
This code throws an exception like:
TypeError: Cannot assign to read only property 'constructor' of object ''
🙂 Expected behavior
This should not throw an exception. This can be achieved by using Object.defineProperty(prototype, 'constructor', {value: constructor}) instead of prototype.constructor = constructor. This is a symptom of the so-called property override mistake, in the design of ES5.

Attn @DanielRosenwasser @rbuckton

This can be achieved by using Object.defineProperty(prototype, 'constructor', {value: constructor})

Our helper emit is designed to work in ES3 as well, where defineProperty is not available. I'm not sure that other alternatives are available; you can provide your own __extends helper that uses that approach if you're not running in ES3 environments.

Would it be an option to feature-test Object.defineProperty to discriminate at runtime?

There’s no way to discriminate the output based on ES5 vs ES3?

This just confuses the situation, because this is a global helper with "first in wins" semantics (to enable you to provide your own, as mentioned) - so if an ES3-targeted library loads before an ES5-targeted library, which is a totally legal situation, then the ES3 version of the helper is going to win and you're back where you started.

Would it work if the ES3 and ES5 helpers were identical:
function __extends(x, y) {
  if (Object.defineProperty) {
    Object.defineProperty(x, 'constructor', {value: y});
  } else {
    x.constructor = y;
  }
}

We do this in __makeTemplateObject, __createBinding, and __setModuleDefault for what it's worth.

We do that in __makeTemplateObject, __createBinding, and __setModuleDefault for what it's worth.

I took a look and we do that wrong in __makeTemplateObject, unfortunately. For __createBinding and __setModuleDefault we check for Object.create (which is good), but we check for Object.defineProperty in __makeTemplateObject. The problem with testing for Object.defineProperty is that IE8's Object.defineProperty could only be used on DOM nodes, however IE8 did not support Object.create.
So, we need to fix __makeTemplateObject, and the __extends helper should probably be:
var __extends = (this && this.__extends) || (function () {
    var extendStatics = function (d, b) {
        extendStatics = Object.setPrototypeOf ||
            ({ __proto__: [] } instanceof Array && function (d, b) { d.__proto__ = b; }) ||
            function (d, b) { for (var p in b) if (Object.prototype.hasOwnProperty.call(b, p)) d[p] = b[p]; };
        return extendStatics(d, b);
    };
    var setConstructor = function (f, d) {
        setConstructor = Object.create ?
            function (f, d) { Object.defineProperty(f, "constructor", { value: d, writable: true, configurable: true }) } :
            function (f, d) { f.constructor = d; };
        setConstructor(f, d);
    };
    return function (d, b) {
        if (typeof b !== "function" && b !== null)
            throw new TypeError("Class extends value " + String(b) + " is not a constructor or null");
        extendStatics(d, b);
        function __() { setConstructor(this, d); }
        d.prototype = b === null ? Object.create(b) : (__.prototype = b.prototype, new __());
    };
})();

@rbuckton should this
setConstructor = Object.create ?
be
setConstructor = Object.defineProperty ?

oh i see you explained exactly why you did this 🤦  I suppose adding a comment would help clarify its intentional. 😸

Hi @rbuckton any progress on https://github.com/microsoft/TypeScript/issues/43450#issuecomment-811593214 ?


Clean up the docs

closes #22
RHCLOUD-36308
Before:

Now:

Preview: https://react-data-view-pr-data-view-152.surge.sh

TO DO: improve full example for toolbar and whole overview

@edonehoo thank you for the great comments! I've just pushed the updated version

@edonehoo I tried to add the requested changes. Please let me know if something needs to be further improved. Thank you for all your comments!


Show a shareable link when user is not on network and add copy icon

Closes https://github.com/relaycc/receiver/issues/117

Before


[GHSA-29mw-wpgm-hmr9] Regular Expression Denial of Service (ReDoS) in lodash

Updates

Affected products

Comments
Hello!
If i understand correctly, lodash team has moved lodash.trim and lodash.trimend packages inside lodash package:
https://github.com/lodash/lodash/tree/npm-packages/lodash.trim =>  https://github.com/lodash/lodash/blob/npm/trim.js
They have stopped updating of these packages:
https://www.npmjs.com/package/lodash.trim
https://www.npmjs.com/package/lodash.trimend
I checked code and looks like there is no fix for this CVE for these packages:
e.g.:
lodash.trimend still uses string.replace(reTrimEnd, '')(with /\s+$/ value) -  https://github.com/lodash/lodash/blob/aaa111912cb05e6f0f9f23d1eb8a41ccfcf9c2c2/lodash.trimend/index.js#L356 (fix of this - https://github.com/lodash/lodash/pull/5065/files#diff-36b7ba0ba252cc39fa5921d9484b7674c8bc7af119636ba7f46194ee871047b6R15046).
I could be wrong. Can you take a look and correct me/update this advisory.
Thank you in advance!
Best Regards, Dmitriy

Hi @DmitriyLewen, we appreciate your contribution to the GitHub Advisory Database. Just to confirm we are reviewing the fix to the correct CVE can you please specify which CVE you are referring to? It would be helpful to include any references that validate your proposed change :)

I said about CVE-2020-28500 (https://github.com/advisories/GHSA-29mw-wpgm-hmr9)


Rip out the certs.sh test since the certs.go test has been stable

Will close #4185

All deletion so approval is yes.


Update repository with comments and instructions

Add a README.md file to provide a brief description of the repository, setup instructions, and contribution guidelines.
Update .github/workflows/build.yml:

Add comments to explain each step in the workflow.
Update actions/checkout to version 4.
Add a step to notify the team on Slack when the build is complete.

Update .gitmodules:

Add comments to explain the purpose of each submodule.
Update submodule URLs to use SSH instead of HTTPS.

Update commits.json:

Add comments to explain the purpose of the file.
Update commit hashes to the latest versions of the submodules.

For more details, open the Copilot Workspace session.

Please test/play with Copilot elsewhere.


add executable example/tutorial

fixes #6

Just a small issue. The convention for the ODM is [table]_[part] not  [table].[part]. We do that because using _ generates a valid name in all programming languages. (.) does not.


add tests and write function for avg_daily_return function

Hi @alexYinanGu0 ,
When I run pytest with your function, it returns this error. Please help to double check.
Hi @berkaybulut , I am sorry that I am not able to suggest any revision for Alex's tests. Since you are most experienced with Python, it would be great if you could spare sometime to review this PR.

Thank you for the feedback! The changes are made to deal with the error in the new pull request!


Remove largeSource argument to convertMap.fromSource

Looks like this hasn't been necessary since https://github.com/thlorenz/convert-source-map/commit/fbb99a6b1a47b113b5835ecdcf467d168f2664ae .
Type definitions fixed by DefinitelyTyped/DefinitelyTyped#19226

@weswigham


tests: remove -enforce-exclusivity=unchecked from another test.

This is a follow-up on https://github.com/apple/swift/pull/29759

@swift-ci smoke test and merge

@swift-ci smoke test linux


docs(README) detailed README

Update the README to give visitors a sense of what the project is,
how it relates to Cycle.js and why it exists.
Touch on relation to Cycle.js, and that it is not a fork that
disregards it's inspiration entirely.
Introduce the goals of the project, and explain the difference and
similarites in the 'Goals' section.
Add an API section to show that it is the same as Cycle.js
Closes #14

@staltz I assigned this to you, because it makes the most sense for you to comb through this as it touches on it's relationship to Cycle.js. Feel free to assign it to someone else if you don't have the time.

Apart from typos, I really like the README.

Alright, I'll get to work on these fixes soon.
Any suggestions on clarifying and correcting this?

The main function expects a collection of "driver source" Observables/Streams as input, and should return a collection of "driver sink" Observables/Streams.

Suggestion:

The main function takes an object of sources as input. Sources are the outputs from the various drivers. To complete the cycle, main should return a sinks object, which is a mapping of return values from the program to the drivers, i.e., inputs to the drivers, usually Observables/Streams.

I’d really like to merge this. If there’s no objections, can I reassign this, as André is pretty busy?

All yours @Frikki


Depth estimation from images without any pose information

Very nice results! Is it possible to generate depth information from an image sequence which has no pose information at all?

Unfortunately not for our method, we need the pose information to model the geometry constraints for feature matching.

Hi @haofeixu, with respect to the demo of depth estimation, using the same settings as the colab notebook, after adding some noise to the rotation part of pose while keeping the translation part the same, I found the depth quality drops a lot. Similarly, after adding some noise to the translation part of pose while keeping the rotation part the same, the depth quality drops a lot as well. Seems like the depth estimation head is not robust to pose. Any ideas to handle this?

@spiegelball @haofeixu are poses used when estimating flow? It didn't seem to me that they were. If not, then it would seem to me this could be done in two stages

Estimate the flow
Estimate camera pose from intrinsics + features matches
Estimate depth


Unable to start playlist using My-Sonos Node

Hey,
i know this was raised several times in the issues but i could not figure out my problem.
I try to start playing a playlist from "My Sonos" randomly. I used the demo code from the "My Sonos" Node wiki but it fails with get my sonos: Cannot read property 'length' of undefined ::
This is the flow, basically taken from the example:
[{"id":"833ef74d.ef1e88","type":"inject","z":"f57f2ef2.84554","name":"","topic":"Songs","payload":"export","payloadType":"str","repeat":"","crontab":"","once":false,"onceDelay":0.1,"x":2932,"y":2449,"wires":[["712aabb.c92c354"]]},{"id":"712aabb.c92c354","type":"sonos-manage-mysonos","z":"f57f2ef2.84554","confignode":"89956c78.ba78d","name":"","x":3143,"y":2451,"wires":[["a1e031d.5a1bed"]]},{"id":"a1e031d.5a1bed","type":"sonos-universal","z":"f57f2ef2.84554","confignode":"89956c78.ba78d","name":"any","x":3303,"y":2451,"wires":[["25562451.8fc0bc"]]},{"id":"25562451.8fc0bc","type":"debug","z":"f57f2ef2.84554","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"true","targetType":"full","x":3303,"y":2413,"wires":[]},{"id":"89956c78.ba78d","type":"sonos-config","z":"","name":"coordinator","serialnum":"xxx","ipaddress":"yyy"}]

The playlist "Songs" is added to MySonos.

but basically everything fails with the same error of the example page.
I also added the universal node examples, there when i click the "TuneIn" example, it starts playing swr3 with no problem. (the tunein example of the My-Sonos node fails)
What am i doing wrong? Is there a way to start a my-sonos (or spotify) playlist using the universal node?
Thanks !

What sonos-plus version do you use?

what Node.js version do you use? It should be 10 or 12.

🤦 i was on 3.1.1.
Thanks for the quick help and all your work on these libraries!
Would i be able to randomly start a my-sonos playlist using the universal node yet?

Not now but I guess Node-RED can do that. Use get.items and store it in a flow variable. Then use other Node-RED nodes to create "random" number between 1 and get.items array length.


#3 created global key to get the instance of the scaffold

most of the changes are from dartfmt.
the main change is that the instace of the scaffold is provided with the global key and not with the context (which does not work)

Thanks!


Namespace inferred serializer resolution.

This reimplements the changes in pull https://github.com/ruby-grape/grape-active_model_serializers/pull/58 on top of the refactor of pull https://github.com/ruby-grape/grape-active_model_serializers/pull/59.
This borrows some logic from the serializer resolution logic in active_model_serializers. Given that active_model_serializers no longer supports the namespace option passed into the serializer_for method, in order to support namespace inference we need to reuse some of their serializer_for logic in grape-asm. I will work with the asm team to add back support for that option, but in order to support the existing 0.10.x asm versions, we need to reimplement some of that logic.

Merging. See my comment on Rubocop, can address later.


CAMEL-17767: Check for null and empty String

Eventually we need to backport on 3.14.x too. Thanks Benjamin.


[FEAT]  Controllers Components

Controllers will help us inside dev environment to simulate back services.
Controllers are components too.
here's an example.

this will helps simulate services quickly

actual step:

next step: let the store fetch data from controllers
this works in dev and in prod for now.
need to test if this is scalable

0.16.0-rc.14 implements those Controllers Components

[ ] can import modules inside Controllers
[ ] Controllers can only use other Controllers Components


Functionality - using one source for cached and private gems

The problem I'm trying to solve is use one source URL for both cached and private gems. The reason for that is because I don't have control on the Gemfile in various projects that will source from Gemstash.
I was hoping this problem was already taken care of as I see some rewriting taking place in the logs, but fetching the private gems still requires /private in URL.
Rewriting '/private/api/v1/dependencies?gems=my-gem' to '/api/v1/dependencies?gems=my-gem'
Anyway, I though I'll work around this by forcing Gemstash to cache my private gem, so I bundled locally from a Gemfile such that my-gem will be source from localhost/private URL.
source "http://localhost/"
source "http://localhost/upstream/#{CGI.escape("http://localhost/private")}" do
  gem 'my-gem', '0.1.2'
end

It seems Gemstash cached my private gem indeed:
$ sudo ls -l  /var/gemstash/gem_cache/
localhost_ea033f2a0ee6dc9d989885050b5252fa
rubygems.org_17ac4526301fd97a7a1a9e64103d89f2

But now when I try to bundle from source "http://localhost" it tells me my-gem cannot be found in any of the gem sources listed.
I'm not sure why dependencies metadata doesn't resolve the locally cached gem. Is there an easier way to solve this problem ? It's hard for me to believe every Gemstash user would maintain multiple sources in their Gemfile.

Try this:
source "http://localhost/private" do
gem 'my-gem', '0.1.2'
end

Sure, I know I can download from /private, I mentioned already. Found a workaround, closing.

Ah sorry, didn't fully read.  What was your workaround?

Run 'gem server' on the build server:

bundle install community gems from Gemfile to dedicated path (it installs all gems in the list + dependencies)
git clone, rake build local projects & gem install to same path as above (it install private gems + community deps)
The run gemstash as a cache pointing to the build server.

This is all meant to avoid pushing gems to gemstash because of its inability to service community and private gems from the same URL.
The only upset I have with that is client's gem install will attempt to 'GET /api/v1/dependencies' from gemstash, which in turn will ask it from gem server. For some reason 'gem server' returns HTTP/1.1 404 Not Found, but then client will default to 'GET /specs.4.8.gz' which works fine.


Contingency Protocol bug

** Fly Casual Release Version**
Latest
Describe the bug
When Contingency Protocol (CP) triggers, all ships with Contingency Protocol are allowed to do an action.
To Reproduce
Steps to reproduce the behavior:

Play some droids with the Contingency Protocol upgrade
Have 1 of them destroyed
The destroyed ship and all other ships are allowed to do an action

Expected behavior
Card text says "Another ship" is allowed to do an action.
That means upon being destroyed, you choose 1 OTHER ship with the CP upgrade. That ship may perform an action, even while stressed.

Updated Contingency Protocol to be triggered from destroyed ship to simplify ability. Commit 8dbd256.


fix multiple ssh key

The current implementation for git (using ssh key) does't works fine with multiples git artifacts are defined:
  - name: code
     path: /workdir/src
     git:
         ...
   - name: plywood
      path: /workdir/src/plywood
      git:
          repo: ....

It returns error failed to load artifacts: mkdir /root/.ssh: file exists
The reason fo that is the creation of ~/.ssh many times which is failing at the second key in the list even if it is the same key.
This PR simply check if the directory exists or not before trying to create it.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

For ioutil.WriteFile it overrides (truncates) the file, which I guess is not a problem.


If druid is shutdown anomaly, Discovery does not know temporary data source has been disabled.

Describe the bug
If Druid is shutdown abnormally after creating a temporary data source, Discovery does not know the data source has been disabled and tries to get data from it.
To Reproduce
Steps to reproduce the behavior:

Create linked datasource.
Create dashboard from created linked datasource.
Restart Druid.
The dashboard does not show data.

Expected behavior
Discovery needs to know the temporary datasource is disabled and reload it.
Screenshots
Desktop (please complete the following information):
Additional context

You can check existing local (temporary) datasource names by /druid/v2/datasources/local


Feature Request - Add a developer setup guide

I am requesting to add a developer setup guide for allowing users to contribute to this project!
Is your feature request related to a problem? Please describe.
I've noticed that the current contributor guide for dbt-score does not have detailed information on setting up and using the development environment with PDM. This makes it challenging for new contributors to set up their environment and start contributing.
Describe the solution you'd like
A developer guide included in the dbt-score documentation. This guide would include:

Step-by-step instructions for setting up the development environment using PDM.
Detailed explanations of the scripts and commands used in the project, such as linting, testing, and building the docs.
A clear description of the build system setup from the pyproject.toml file.
Guidance on best practices when contributing to the project, including how to propose new features or rules.

To support this, I am willing to help draft this guide based on my own experiences setting up the environment and contribute by sharing code snippets and command examples that have worked for me
Describe alternatives you've considered
As an alternative to a full developer guide, a series of blog posts or wiki pages that cover various aspects of the development process could be considered. These could be linked directly from the README to assist new contributors. Additionally, enhancing the comments within the pyproject.toml could partially address the need for more detailed setup instructions.

Hi @farmanp, thanks for your elaborate issue! I think most of the things you listed is actually covered here: https://dbt-score.picnic.tech/contributing/. Could you check it out, if it covers all your questions?
The link to the contributors guide can be found in the README, maybe it's a little bit hard to find?

PDM was new to me and I followed the guide and this allowed me to do my first PR on this project  😃

Good points everybody! I'm going to close this issue and familiarize myself with the DBT package first. Thanks for the inputs here.


wallet: Detect DuplicateAddress earlier

This PR makes check for DuplicateAddress error easier and earlier.

which requires the wallet to be locked

Do you mean "unlocking" using WalletModel::UnlockContext?

Inside SendCoinsDialog ::PrepareSendText, before calling WalletModel::prepareTransaction, we are looping over all the entries to load up the recipients list --> Line 257 of SendCoinsDialog.

Would it make logic a bit messier?

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts
Reviewers, this pull request conflicts with the following ones:

#149 (Intro: Have user choose assumevalid by luke-jr)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Going to leave this PR up for grabs.
cc @furszy


Move AIX OpenJ9 builds to AIX 7.1.5 machines

Required for fixing https://github.com/AdoptOpenJDK/openjdk-build/issues/1733
Signed-off-by: Stewart Addison<EMAIL_ADDRESS>

This seems to tie to openj9 machines only - what about hotspot builds for that platform?

This seems to tie to openj9 machines only - what about hotspot builds for that platform?

What about them? Do you want them changed too? There is no issue with the HotSpot builds so if we're moving them it would be for consistency rather than any requirement to do so, but it may adjust the minimum OS level required to run those builds going forward

I'm probably confused but for example, I look at the change in pipelines/jobs/configurations/jdk11_pipeline_config.groovy and the change adds the buildj9 label which I think means that this build must choose an (xlc13 and buildj9) labeled machine.  Are pp64Aix only OpenJ9 builds?  a label of buildj9 wouldn't make sense for a hotspot build.
ppc64Aix    : [
os                  : 'aix',	                os                  : 'aix',
arch                : 'ppc64',	                arch                : 'ppc64',
additionalNodeLabels: 'xlc13',	                additionalNodeLabels: 'xlc13&&buildj9',
test                : [	                test                : [
nightly: ['sanity.openjdk'],	                        nightly: ['sanity.openjdk'],
release: ['sanity.openjdk', 'sanity.system', 'extended.system']	                        release: ['sanity.openjdk', 'sanity.system', 'extended.system']
]	                ]
],	        ],

I've now adjusted the way I'm doing the labels as I didn't like the use of buildj9 anyway, even though we have used it elsewhere previously. Have now used aix710 and aix715 since that's the capability - the difference that causes it to pass/break is in the dump command that shipeed with AIX 7.1SP5.
At the moment all of the aix710 systems are offline as I was artificially forcing everything through to the new boxes to ensure the OpenJ9 builds went there, but once this is in we can re-enable the old systems again :-)


Add test for physical instance delete to GitHub actions

It's quite easy for the Instance_Del stored procedure to get broken as a result of new features added to the application.  e.g. #777.  Ideally, issues should be picked up automatically in the GitHub action that runs.
A test could be run at the end of the current workflow(s) to call Instance_Del with @HardDelete=1.  Some PowerShell could also verify that the instance has been deleted.

This is included in version 3.0.   🚀


KAFKA-1811 Ensuring registered broker host:port is unique

Adds a ZKLock recipe implementation to guarantee that the host:port pair is unique among the brokers registered on ZooKeeper.

Hi @fpj and @gwenshap, whenever you have some free time, it would be awesome if you could review my ZKLock recipe as well as the feature. See if it does make sense at all. Cheers! :)

@junrao since you filed the JIRA could you take a look at this PR after @eribeiro rebased it?

This has been somewhat addressed by https://github.com/apache/kafka/pull/4897. The JIRA has been closed so I will close this PR. Please, reopen it if it is still relevant.

Adds a ZKLock recipe implementation to guarantee that the host:port pair is unique among the brokers registered on ZooKeeper.


ci: build windows app and report artifact

This adds a GitHub Action job to build the Windows app and create the installer. Artifacts will be reported on Mattermost, like with other platforms.
Notable differences to our previous Appveyor CI:

The GitHub windows-2019 image comes with Vistual Studio Enterprise instead of the Community edition. A directoy junction is created to point calls from the Community to the Enterprise path.
NSIS, MinGW and Make are pre-installed already, not requiring any installations with choco anymore.
Qt is not pre-installed anymore and now installed using an Action.

Because there are no changes to other files, the Appveyor build will continue to work and can be used in parallel.

We can delete the appveyor one then right? I don't see the need to maintain two Windows CI builds.

We can delete the appveyor one then right? I don't see the need to maintain two Windows CI builds.

I recommended that we wait a couple of weeks and test out this integration first. but I have nothing against killing appveyor.


Removed unnecessary files to deploy planner as a docker container

I believe you don't need anymore these files:

openshift files: you won't be deployed as a single pod.
dockerignore: there isn't any dockerfile in the repo.

@hectorj2f @nimishamukherjee please restore the .dockerignore file as there are Dockerfiles still present in the repo.


Multiple load functions

Describe the problem
Say I have a load function that fetches data based on:

page.params.paramA
page.params.paramB
or any other page/session argument that would rerun load

Each data fetching call is independent from one another.
If I goto to change only paramA, all my data fetching calls will be rerun, when only the one depending on paramA needs to rerun.
Describe the proposed solution
I'd like to be able to define different load functions that would refetch if its dependencies change, but would return a Promise.resolve() of previously fetched data if other params change.
For instance, we might imagine a loaders field in load inputs, and other loadX functions with the same load signature:
function loadA({ page, fetch }) {
    return fetch(`/some-endpoint/${page.param.a}`);
}

function loadB({ page, fetch }) {
    return fetch(`/some-endpoint/${page.param.b}`);
}

export function load({ loaders }) {
    return Promise.all(loaders).then(([dataA, dataB]) => {
        return {};
    });
}

Alternatives considered
Use data fetching without load, with onMount.
Importance
nice to have
Additional Information
No response

This would make the API around data fetching quite a bit more complicated. This is something that's probably better implemented in userland:
const cache = new Map();

function cached(id, fn) {
  if (!cache.has(id)) {
    cache.set(id, fn());
  }

  return cache.get(id);
}

export async function load({ fetch, params }) {
  const [a, b] = Promise.all([
    cached(params.a, () => fetch(`/some-endpoint/${params.a}`).then(r => r.json()),
    cached(params.b, () => fetch(`/some-endpoint/${params.b}`).then(r => r.json()),
  ]);

  return {
    props: { a, b }
  };
}

You'd obviously have to consider when to invalidate the cache; this could be done using lifecycle functions in the component if you didn't want the cache to survive indefinitely.


Update test cases for MatchTest

Resolve #74
Resolve #30

Pull Request Test Coverage Report for Build 847

3 of 3 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 84.197%

Totals

Change from base Build 779:
0.03%

Covered Lines:
2536

Relevant Lines:
3012

💛  - Coveralls

Pull Request Test Coverage Report for Build 785

3 of 3 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 84.197%

Totals

Change from base Build 779:
0.03%

Covered Lines:
2536

Relevant Lines:
3012

💛  - Coveralls


Can not use the new docker/login version v1.0.1

Since the new version a few minutes ago, we get the following error:
`node:internal/modules/cjs/loader:936
throw err;
^
Error: Cannot find module '@actions/core'
Require stack:

/home/runner/work/_actions/azure/docker-login/v1/lib/login.js
at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
at Function.Module._load (node:internal/modules/cjs/loader:778:27)
at Module.require (node:internal/modules/cjs/loader:1005:19)
at require (node:internal/modules/cjs/helpers:102:18)
at Object. (/home/runner/work/_actions/azure/docker-login/v1/lib/login.js:13:14)
at Module._compile (node:internal/modules/cjs/loader:1101:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
at Module.load (node:internal/modules/cjs/loader:981:32)
at Function.Module._load (node:internal/modules/cjs/loader:822:12)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12) ***
code: 'MODULE_NOT_FOUND',
requireStack: [ '/home/runner/work/_actions/azure/docker-login/v1/lib/login.js' ]
***`

We are also getting the same error

Hi, I have seen the same issue on my projects for a few minutes. I would prefer not to have to explicitly reference v1.0.0 in all my workflows...

Yes. I also getting the same issue with azure/docker-login@v1
Error:
Error: Cannot find module '@actions/core'

Hi, I have seen the same issue on my projects for a few minutes. I would prefer not to have to explicitly reference v1.0.0 in all my workflows...

unfortunately the previous version is called only "v1". Due to that v1.0.0 does not even work :(

Hi, I have seen the same issue on my projects for a few minutes. I would prefer not to have to explicitly reference v1.0.0 in all my workflows...

unfortunately the previous version is called only "v1". Due to that v1.0.0 does not even work :(

You can do @2faa66cfd1a1e8d02713b5df43a1f4da62872ec2

Same error, started happening today

Anyone know what commit was tagged "v1" before one hour ago ?

Sorry just saw 2faa66cfd1a1e8d02713b5df43a1f4da62872ec2, thx @bamarch

I am getting the same error with 2fa...
Run azure/docker-login@2faa66cfd1a1e8d02713b5df43a1f4da62872ec2
node:internal/modules/cjs/loader:936
  throw err;
  ^

Error: Cannot find module '@actions/core'

Hi, I have seen the same issue on my projects for a few minutes. I would prefer not to have to explicitly reference v1.0.0 in all my workflows...

unfortunately the previous version is called only "v1". Due to that v1.0.0 does not even work :(

You can do @2faa66cfd1a1e8d02713b5df43a1f4da62872ec2

Unfortunately this also does not seem to work. If you look under tags https://github.com/Azure/docker-login/tags it seems like the v1 tag is now also updated to the broken version v1.0.1

Ok, so my question is still valid :)
Anyone know what commit was tagged "v1" before one hour ago ?

@BALAGA-GAYATRI Can you get eyes on this? quite likely to have broken a lot downstream

https://github.com/Azure/docker-login/commit/7c3fbb89c5162a802bc3743389996c6a647bd5db this worked for us.

Can you please check now?

v1 currently points at the same commit as v1.0.1 (broken) https://github.com/Azure/docker-login/commit/83efeb77770c98b620c73055fbb59b2847e17dc0
About 15 mins ago v1 pointed at https://github.com/Azure/docker-login/commit/2faa66cfd1a1e8d02713b5df43a1f4da62872ec2
Now v1 is gone, and v1.0.1 still points to https://github.com/Azure/docker-login/commit/83efeb77770c98b620c73055fbb59b2847e17dc0

Anyone know what commit was tagged "v1" before one hour ago ?

Unclear what it was since the tags keep getting changed, seems like going back far enough in time is working:
https://github.com/Azure/docker-login/commit/7c3fbb89c5162a802bc3743389996c6a647bd5db

Can you please check now?

I've just ran using @v1 and it works in my environment

v1 is working now.

I have chacked v1.0.1 is also working now. Please re-run once and confirm

I have chacked v1.0.1 is also working now. Please re-run once and confirm

Thanks. Looks like it is fixed.


Migrate managedCluster tests

Refactor and migrate tests located in "clc-ui-e2e/cypress/tests/clusters/managedClusters".
Refactoring may not be necessary for every test, but to meet our maintainability goals, we should consider refactoring where ever it's needed.

Migrated tests, currently correcting runtime issues.


Connection with firebase 3/2/2019

unable to connect with firebase but day before i was able to connect with firebase and everything was going great

ditto!

same here...

Please update your library, it has been updated with new fingerprint.
On Sat, Mar 2, 2019, 8:06 PM beaconIOT<EMAIL_ADDRESS>wrote:

same here...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/FirebaseExtended/firebase-arduino/issues/411#issuecomment-468976050,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD3-GHslnmMgusbLwREg4o2OowkaMllgks5vSyAzgaJpZM4bac4A
.

Please tell me why we must to change this sha1 fingerprint? in the furture, I use this library to sell my product, but it's depend on fingerprint code? How to fix this and make the library stable?

Thanks, I updated the library and it worked again 👍
https://github.com/FirebaseExtended/firebase-arduino.git

If upgraded to arduino core 2.5.0 , we can install with the google root cert. That we can assume only update once every few years. It also takes a bit more heap.

Hi,
I updated the fingerprint but still, it doesn't work. Please help!

Hi,
I updated the fingerprint but still, it doesn't work. Please help!

Try restarting the IDE

@Newsoul693
Instead of pre-defining the fingerprint, it might be possible to update the fingerprint from the code during run-time. Store the fingerprint on your database and read it every time the code runs.


Workspace icons disappearing when getting a notification

Describe the issue
If I am in workspace y and I get a notification in workspace x, the icon of workspace x disappears from polybar. The same happens if firefox is open in workspace x and I click a link in workspace y
Expected behavior:
workspace x icon shouldn't disappear
Actual behavior:
workspace x icon disappears
Was it working before?
No
To Reproduce
config: https://del.dog/crilyfostu.txt
Open firefox in workspace x
switch to workspace y and click on any web link
OR
Open any app that you expect to get a notification in
switch to workspace y and wait for a notification
Polybar Log
Nothing relevant
Screenshots

(Firefox in workspace 1)
Environment:

WM: i3
Distro: Arch Linux
Output of polybar -vvv:

polybar 3.4.3

Features: +alsa +curl +i3 +mpd +network(libnl) +pulseaudio +xkeyboard

X extensions: +randr (+monitors) +composite +xkb +xrm +xcursor

Build type: Release
Compiler: /usr/bin/c++
Compiler flags: -D_FORTIFY_SOURCE=2 -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -Wall -Wextra -Wpedantic -O3 -DNDEBUG
Linker flags: -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now

You bar text color is almost the same as the background color. The workspace with the urgent tag is still getting displayed, it's just displayed as black on a black background.
This doesn't happen for the other workspaces because you have explicitly set the foreground color for them to white.

@patrick96 thanks!


Update https-everywhere.badssl.com to mention which release it was added to.

This is a follow-up to #83, pursuant to https://github.com/EFForg/https-everywhere/pull/3111

You can assign it to me if you want. :smiley:

https://github.com/EFForg/https-everywhere/pull/3111 was merged.
So now we have to pay attention when a new HTTPS-E version is released.
Additionally you should add a link to the top website so that this subdomain can be visited from them main page.

Additionally you should add a link to the top website so that this subdomain can be visited from them main page.

I don't think there is a common testing use case for this, so I'd prefer to leave it as an unlisted domain for now.