GestureDetector.onTap is ignored after scaling activity

Steps to reproduce
To reproduce using the sample code below (for scaling, I used MacOS trackpard):

Tap on the view (should print onTap)
Zoom in and Zoom out using two fingers multiple times (see screen recording)
Tap on the view (it would print onScale)

if that does not happen, repeat step 2 and zoom in then out to the max.

https://github.com/flutter/flutter/assets/46427323/905087e2-8d02-42f8-8d06-40a544e03506
Expected results
I expect GestureDetector.onTap to be invoked for taps on the widget.
Actual results
Tapping on the widget after scaling invokes onScale... instead of GestureDetector.onTap.
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(
    MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Scaffold(
        appBar: AppBar(),
        body: Padding(
          padding: const EdgeInsets.all(8.0),
          child: ScaleTapIssue(),
        ),
      ),
    ),
  );
}

class ScaleTapIssue extends StatefulWidget {
  const ScaleTapIssue({
    Key? key,
  }) : super(key: key);

  @override
  State<ScaleTapIssue> createState() => _ScaleTapIssueState();
}

class _ScaleTapIssueState extends State<ScaleTapIssue> {
  var scale = 1.0;

  @override
  Widget build(BuildContext context) {
    return GestureDetector(
      onTap: () {
        print('onTap');
      },
      onScaleUpdate: (details) {
        // to avoid printing all events
        if (details.scale == 1.0) {
          print('onScale');
        } else {
          final newScale = scale - ((1 - details.scale) * 0.2);
          if (newScale >= 0.1 && newScale <= 4.0) {
            setState(() {
              scale = newScale;
            });
          }
        }
      },
      child: Center(
        child: Container(
          color: Colors.yellow.shade200,
          height: 500,
          width: 500,
          child: ClipRect(
            clipBehavior: Clip.hardEdge,
            child: Transform.scale(
              scale: scale,
              child: Center(
                child: Container(
                  color: Colors.red,
                  height: 50,
                  width: 50,
                ),
              ),
            ),
          ),
        ),
      ),
    );
  }
}

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.16.5, on macOS 12.7 21G816 darwin-x64, locale en)
[!] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.
[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 4.1)
[✓] VS Code (version 1.85.1)
[✓] Connected device (2 available)
[✓] Network resources

! Doctor found issues in 1 category.

Additional Details:
I have previously filed the following issue for InteractiveViewer, and I believe this new issue is its root cause or closer to it:

#136622

p.s. I would like to mention that GestureDetector.onScale has few other unexpected behaviors such as the conflict with onPan and the treatment of  "single finger scroll" as a scaling event. Here are some issues that I ran into while working with scaling and other gestures:

#115061
#13102
#13101

I just realized if GestureDetector.onTap is not provided, then all tap events invokes GestureDetector.onScale....
So I think the issue above is that after scaling activity, the .onTap never wins the gesture. But according to .onTap documentation, .onTapCancel  is supposed to be called, but this does not happen:
  /// This triggers when the tap gesture wins. If the tap gesture did not win,
  /// [onTapCancel] is called instead.

Thanks for finding this, there was a mistake in my macOS side trackpad gesture handling. So in certain cases it would not send the final PanZoomEnd event. Then the ScaleGestureRecognizer would be stuck "accepted" until the user alt-tabbed. That's why it always claimed the subsequent tap instead of the onTap.
Fix is here https://github.com/flutter/engine/pull/49424

Thanks @moffatman for taking care of it 🙏🏽
A side question please:
Given that I cannot use GestureDetector.onPan with GestureDetector.onScale, how can I distinguish between a scroll and a drag in GestureDetector.onScaleUpdate? I noticed that the ScaleUpdateDetails.pointerCount does not report the fingers correctly (it's always 1) so that didn't help. I was hoping to use pointerCount to treat 1-finger as drag and 2-fingers as scale/scroll.

Why do you need to treat them differently? Actually it's possible to both scale and pan at the same time. Just want some more info on your use case and I can give you advice.

I am building a grid based application (think flow charts for simplicity).
I would like to keep two finger scrolling for moving the grid around (similar to InteractiveViewer).
On the other hand, I would like to use one finger drag to draw a selection box. For a concrete example, I am trying to achieve a similar behavior to that of https://excalidraw.com/  (scroll moves around, drag draws a selection box)

Two finger scroll should have different pointerdevicekind (.trackpad)

Both ScaleStartDetails and ScaleUpdateDetails do not have a PointeDdeviceKind.  (Sorry, I forgot to mention that I am also using pinching to zoom, hence I am relying on GestureDetector.onScale..).

Hmm.... I guess the problem is too that you can have combined trackpad+touch (technically). So maybe the best thing is to change pointerCount for trackpad to 2 instead of 1. Then you should always be able to tell them apart?

so that would be:

pointerCount == 1  --> single finger scroll (drag) in my case
pointerCount == 2 --> two finger scroll in my case

I think that would work as long as they can be distinguished.

Will look at making that change... however you may have more problems. Because remember every two finger drag starts with one finger... what happens when we go from 1 to 2.

Will look at making that change..
Thanks a lot!

what happens when we go from 1 to 2.
I guess I will have to capture this info in onScaleUpdate and react upon it. InteractiveViewer does a similar thing where it differentiate between the different gesture types within onScaleUpdate. I will have to wait and see how that will turn out though 😅

Thanks for the report. I was able to replicate it using the code sample provided.

 stable, master flutter doctor -v
[!] Flutter (Channel stable, 3.16.5, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.16.5 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 78666c8dc5 (13 days ago), 2023-12-19 16:14:14 -0800
    • Engine revision 3f3e560236
    • Dart version 3.2.3
    • DevTools version 2.28.4
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.18.0-18.0.pre.47, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 3.18.0-18.0.pre.47 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 3df4e735d5 (3 days ago), 2023-12-29 14:07:39 -0500
    • Engine revision 9e03a57cde
    • Dart version 3.3.0 (build 3.3.0-273.0.dev)
    • DevTools version 2.31.0-dev.0
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/dhs/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for
      more details.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13C100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 65.1.4
    • Dart plugin version 213.7228

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (3 available)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 15.3.1 19D52
    • macOS (desktop)           • macos                                    •
      darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 109.0.5414.119

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Hi @darshankawar
It seems the bot closed this issue but it's still not resolved (waiting for https://github.com/flutter/engine/pull/49424 to land).
Could you please reopen it? (I don't have the option)
Thanks


Please add to the site more detailed instructions for changing the elements of the forms

Please add to the site more detailed instructions for changing the elements of the forms, because it is not clear how to edit the registration form and the forgotten password form. Designers send us layouts with completely different fields, buttons and a completely different arrangement of field names, and it is not clear how to do it.
It would be good to use your own pages for login, registration, forgot password, which will correspond to the design of the project.

Need to add docs:

@kliatskiidenis see docs:

Signup items table: https://casdoor.org/docs/application/signup-items-table
Signin items table: https://casdoor.org/docs/application/signin-items-table


dots setting is not work

May be dots's value is string！ Not changed to  Boolean
<slick dots="true"></slick>

+1

have a look 3.1.4 version
Thanks!


Third Party tracing crate

I noticed that there is a home grown tracing module in crate/common/tracing.rs. I was wondering if there is no capable third party crate that could remove the maintenance burden of a homegrown version.

Tracing should also use RAII concepts in order to create and close spans in order to avoid manual creation/closing timing bugs.


Bring the diagram to a new level (assets)

Coverage remained the same at 100.0% when pulling f55c837e16f7a589b0c081535f7cf68505ca549b on sofiiakopach:documents into bcf735fabcafa94d95eeefee447752ebe1ca065f on openprocurement:master.

Потрібно забрати digraph G {.....} з файлу basicAsset.rst

Coverage remained the same at 100.0% when pulling f1728099f067475c8ff8f2ae151184b7fed0afa2 on sofiiakopach:documents into bcf735fabcafa94d95eeefee447752ebe1ca065f on openprocurement:master.


Channel creation with custom protocols

Hello!
I've run into some issues when creating channels with a custom protocol (i.e., not http or https). This is supported by grpc via registerResolver.
Basically the issue boils down to the channel creation logic here:
https://github.com/deeplay-io/nice-grpc/blob/22d3f9e050a8804787a4c0959a773eb5dc99bd48/packages/nice-grpc/src/client/channel.ts#L8-L33
I have some thoughts on this logic generally, but in terms of fully supporting grpc, http and https are not the only protocols one can use (e.g., consul:)
I am happy to submit a PR but would like your opinion on what the best approach might be. Here are my initial thoughts:

New flag / param indicating that none of the validation should occur and the information should be passed straight through as-is into new Channel(). Pro: explicit. Con: additional flag / configuration
If credentials are provided, the user is opted out of any "validation" by the library. Pro: No new config. Con: implicit and the relationship between credentials and protocol is unclear.
Remove validation altogether and allow the grpc-js library to validate. Pro: Less logic in this library, less change for drift in behavior. Con: likely a breaking change because you set credentials conditionally based on protocol.
If parsed protocol is different than http or https, do not throw an error and instead pass the address as-is directly into new Channel(). Pro: backwards compatible, no new config. Con: none that I can think of. You will need to set credentials to a default value if not provided, but I think that is not a big deal.

I currently like option (4) the most since it's (mostly) backwards compatible and allows for custom protocols without any additional configuration.
If you have other thoughts, please let me know. 😄 I'm happy to make a PR for any suggestion since I am currently blocked on this issue.
Thank you!

Hey,
First of all, thank you for such a nicely composed proposal!
Option 4 seem like the best to me as well.

you set credentials conditionally based on protocol

This was the main motivation for making a wrapper around new Channel(). We wanted to be able to change endpoints solely by configuration, without touching the code, regardless of secure / insecure, just like you do with plain HTTP. Also to be able to have endpoints of the same format as in nice-grpc-web.
Otherwise, option 3 would be preferable to keep things simple. But I think it's fine to have special behavior for http and https.
Looking forward to see your PR!


Added social sharing buttons

The Image details page lacked any way of sharing the page. A file was found under src/components with social icons designed. I have implemented it on the page details.
#104
Image-

@brenoferreira can this be closed?

This is done in #221


added hover effects

Title and Issue number

Title : hover effet
Issue No. : #103
Close #103

Screnshots
Additional context(if any)
Are you contributing under any Open-source programme?

ok! @YooAshu


Add networks to sdx_global.cfg

In order to build the mininet topology from the cfg files, the advertised networks by each participant should be also stated in the config.
Suggestion:
"a1": {
            "Ports": [
                {
                    "Id": 5,
                    "MAC": "08:00:27:89:3b:9f",
                    "IP": "<IP_ADDRESS>",
                    "Networks": ["<IP_ADDRESS>/24", "<IP_ADDRESS>/24"]
                }
            ],

This will allow to substitute this line per participant in the simple_sdx.py from the config:
networks=['<IP_ADDRESS>/24', '<IP_ADDRESS>/24']

@TribuneX  I thought about it last night and I am not so sure about it now. Because it might have meaning to create the mininet topology, but for the iSDX code  (so far) it has no use.
As the sdx_global.cfg contains information required to configure the fabric, i wonder if adding a new field only for creation of test topologies would not add "noise" to the config file.
in my opinion, it is interesting to create the mininet topo with the sdx_global.cfg, but i would put the announcements in a separate file.

Just discovered that there is already a mininet.cfg which includes this information. I pushed a new master version which uses the networks defined in the mininet.cfg for building the topology.


review ethnicity property

There are several issues arising from attempts to standardize donor ethnicity

The current schema standardizes using HANCESTRO, an ontology designed to capture ancestry, not ethnicity. So not the intended purpose of the ontology, plus these are two concepts that can be confused for each other by researchers, so entangling them is not ideal.
 Without standardization of those options, standardization of the recorded values is incredibly difficult.
A majority of primary human data in cellxgene currently is 'unknown' for ethnicity (quick sum of datasets that are human and all cells are is_primary_data=True - datasets that are all 'unknown' total 8,384,599 cells while the rest total 5,920,981 cells
Ethnicity is a complex concept. We recently had the following cases reported for patients in a Seed Network study (each bullet is the record ethnicity for a single patient)...

White and Asian, Japanese
White and Ashkenazi Jew
Black and Ashkenazi Jew
Black and white, Northwestern European
Black, Legacy African-american and white, Western Asian and North African
Afro-Caribbean and Hispanic or Latin American

Some other groups that would be valuable to hear from on this topic (not necessarily schema)

HCA Genetic Diversity WG - I have joined
NAS Committee on Use of Race, Ethnicity, and Ancestry as Population Descriptors in Genomics Research - upcoming workshop on Apr 4
ClinGen Ancestry and Diversity Forum - I have joined & they have their previous presentations all recorded and available on the website

I had a great conversation with Alice Popejoy (co-chair of the ClinGen Ancestry and Diversity WG, which runs the Forum mentioned above & author of this informative piece that outlines issues with the terms & concepts used in genomics research).
A few notes:

capturing self-reported ethnicity at the cellular level which we do is going to make it incredibly likely that researchers will treat it as a biologically-connected concept, which it is not.
in doing so, they may find correlation, and mistakenly assign causation to ethnicity (when, in fact, ethnicity may be a proxy for geography, diet, any number of environmental variables, batch effects, etc. in a given study and those are the significant variables).
there's a risk that in addition to that mis-assigned causation, they then take those findings, draw conclusions, and those reinforce biological racism that's already prevalent due to these rampant assumptions made by others previously

If the only reason to capture ethnicity is to gauge the diversity of populations represented in the data corpus, then this could be ingested as it is now, but removed from the cxg explorer & downloadable datasets. Then used to summarize the whole data corpus.
If that's not even a good enough reason, then we just remove it from the schema all together.

Proposal from Lattice

Remove ethnicity_ontology_term_id and ethnicity from the schema.
Add self_reported_ethnicity to the schema, a free text field (unknown is still used to capture the lack of information). The self_reported_ can help further disambiguate the information from genotyped ancestry. Curators can do our best to ensure capitalization is consistent, typos do not appear, delimiters are consistent, etc.
Remove the ethnicity filter on Dataset/Collection search pages. This is likely not a common filtering use case anyway, but instead information to consider later when evaluating the variability/diversity in an already-filtered dataset.
To migrate, remove ethnicity_ontology_term_id from existing datasets. ethnicity can remain, and Lattice can, over time, update those standardized labels to the originally reported values as we can.

The proposal is a statement that the information is valuable, but we don't know how to standardize yet. So we will collect it as-is for now and standardize later on.
Continuing the use of HANCESTRO terms as an enum is going to result in more information loss. Reported values are being converted to a set of values that we know to be insufficient and even misleading (the ancestry ontology is used to capture ethnicity). In some cases, multiple values are being reported and they're being condensed into one. The original reported values are not being retained.
Adopting a new enum risks the same information loss, even if we allow for multiple values to be selected.
Removing this field from the schema altogether (thus, making it optional) will result in even less ethnicity information submitted.

Reviewed with small group (Norbert, Jason, Harley, Kuni, Brian R).
TLDR - Agreed to adopt Lattice proposal despite misgivings about the value of free text to inform a future controlled vocabulary or ontology.

To migrate, remove ethnicity_ontology_term_id from existing datasets. ethnicity can remain, and Lattice can, over time, update those standardized labels to the originally reported values as we can.

@jahilton - to help with this migration do you require the curator API to continue returning the ethnicity label for legacy datasets in responses or may both the label and ontology_term_id be removed from the portal database and responses? If required, then my recommendation would be to simply return the current response unchanged (perhaps with an annotation of "deprecated" to warn others):
        "ethnicity": [
          {
            "label": "Asian",
            "ontology_term_id": "HANCESTRO:0008"
          },

Additional requirements
Lattice is responsible for manual validation of self_reported_ethnicity including separators. The cellxgene-schema CLI MUST ignore.
self_reported_ethnicity MUST appear under Author Categories in the cellxgene explorer LSB and NOT Standard Categories.
Ethnicity MUST be removed from analytics dashboards.

@brianraymor thanks for the visibility!
Do you want to replace current "Ethnicity" with what is in the self_reported_ethnicity field or remove any analytics on the entire topic?
I assume that means the ethnicity filter will be removed as well?

Do you want to replace current "Ethnicity" with what is in the self_reported_ethnicity field or remove any analytics on the entire topic?

Please remove until we can assess the set of values being returned by self_reported_ethnicity.

I assume that means the ethnicity filter will be removed as well?

Yes.

I've removed "Ethnicity" from the Cellxgene - data availability dashboard
Once the filter is removed from the UI I will remove that part from the Cellxgene - usage dashboard

Once the filter is removed from the UI I will remove that part from the Cellxgene - usage dashboard

@ainfeld - I will be creating an epic in single-cell to model and track all the required changes related to the deprecation. Do you have a repo where you track dashboard issues? If so, I could create an issue and add a blocking dependency on the filter removal.

@brianraymor I'm just in the process of setting up a system to track requests for changes to the dashboard. I just created a #single-cell-analytics repo to link my notebooks in databricks with the scripts to extract data for the dashboards so that the engineers can do fairly traditional PR requests. Would it work to create an issue in that repo?

Yes. I've added that repo to our zenhub workspace.

@brianraymor we will also want to remove the ethnicity filter on scExpression as part of the deprecation. Once you create the deprecation epic let me know and I can link an issue for scExpression. Thank you!

@jahilton
RE

To migrate, remove ethnicity_ontology_term_id from existing datasets. ethnicity can remain, and Lattice can, over time, update those standardized labels to the originally reported values as we can.

Would it not be more consistent for Lattice to delete ethnicity_ontology_term_id and rename ethnicity to self_reported_ethnicity immediately. In general, we want to start warning/failing when previous metadata exists in datasets.

If we are planning to warn/fail on any previously-used metadata fields, then I would expect the schema to explicitly state which fields are not allowed. Is this the plan?
The renaming solution would actually be inconsistent with the schema for self_reported_ethnicity which will be advertised as free text when those migrated values would still be "bent" to HANCESTRO.

The renaming solution would actually be inconsistent with the schema for self_reported_ethnicity which will be advertised as free text when those migrated values would still be "bent" to HANCESTRO.

@jahilton I wanted to verify: completely absent is better than "bent to HANCESTRO"?

completely absent is better than "bent to HANCESTRO"?

No, knowing now that ethnicity will be disallowed, then migration should be renaming the existing ethnicity values to self_reported_ethnicity immediately.

@jahilton - My aspiration is to have a cellxgene-schema CLI option to automate some of the 2.0->3.0 migration for Lattice:

Delete ethnicity_term_ontology_id
Rename ethnicity to self_reported_ethnicity
Delete X_normalization
Update schema_version to "3.0.0"
Remove human-readable labels for ontology term id(s)
etc.

@brianraymor I always liked you

Closing now that we're in alignment.

Re-opened. Per July 12 call with Norbert, @jahilton, and @hthomas-czi - we agreed to rename and reuse the current ethnicity field with its HANCESTRO value.
self_reported_ethnicity_ontology_term_id

Key
self_reported_ethnicity_ontology_term_id

Annotator
Curator

Value
categorical with str categories. If organism_ontolology_term_id is "NCBITaxon:9606" for Homo sapiens, this MUST be either a HANCESTRO term or "unknown" if unavailable. Otherwise, for all other organisms this MUST be "na".

self_reported_ethnicity

Key
self_reported_ethnicity

Annotator
Data Portal

Value
categorical with str categories. This MUST be "na" or "unknown" if set in self_reported_ethnicity_ontology_term_id; otherwise, this MUST be the human-readable name assigned to the value of self_reported_ethnicity_ontology_term_id.

I've proposed that the pipeline 3.0.0 re-validation process automate the rename on behalf of the curators.

Addressed in #268


Fail deserialization of malformed base64 in nodejs

Right now, Buffer.from(str, 'base64') will act as if successful even if the string was not in base64 format. The browser's atob will throw an error in these cases.
In order to handle the getByteInvalid autorest.testserver scenario, we should consider adding a validation or an alternate base64 decoder which will fail on the malformed string.

Closing this as separate efforts are underway to get to test coverage for autorest.typescript


Feature Request: Enable mocking for expect interface

It would be nice to be able to mock an expect interface with generated mocks for the actual interface for each target 😄

MocKMP is a test tool.
Having a tool that generates actual implementations for expect interfaces is not a test tool and outside the scope of MocKMP.

Sorry I wasn’t clear: I’m definitely trying to use it in tests!
To be more specific:

I’ve got an expect interface in commonMain,
already have actual interfaces in JVM and iOS
My commonMain code extensively uses the expect interface

What I’m looking for is being able to

write a test case in commonTest that only verifies behavior of methods on the common expect interface
tell mockmp to mock the expect interface in commonTest, and
have mockmp generate mocks via the (already existing!) actual interfaces for each target
Have mockmp allow me to mock the common methods in commonTest

I reopen this issue because the use-case is valid, and MocKMP does not support it at the moment.
However, until the aforementioned KSP issue is fixed, consider it dormant, as I don't think it can be done.


Improve startup logging

What
Log version and commit right after starting and add more detailed logging around in-memory storage initialization.
Why
We found situations in which RPC took 30 mins to start
Known limitations
N/A

this was triggered during investigation of https://github.com/stellar/soroban-rpc/issues/128


Laravel Mix and JS stop working

Question
Answer

Issue or Enhancement
Issue

Laravel Version
8.39.0

Project Version
3.5

Current Behavior
When I follow the steps in the wiki to enable Laravel Mix, this line in the resources/js/bootstrap.js file seem to not load the JS properly. For example, the sidebar toggles don't work:
require('../../vendor/almasaeed2010/adminlte/dist/js/adminlte'); // not working
For a reason that I don't know, in my project, there is also a folder called /public/vendor/adminlte/dist/js/adminlte.
In the resources/js/bootstrap.js file, when I do this, the javascript is loaded properly and the sidebar toggles start working again:
try {
    window.Popper = require('popper.js').default;
    window.$ = window.jQuery = require('jquery');
    require('bootstrap');
    require('overlayscrollbars');
    require('../../public/vendor/adminlte/dist/js/adminlte'); // working
    //require('../../vendor/almasaeed2010/adminlte/dist/js/adminlte'); // not working

} catch (e) {}

Do you know why I have this folder?
/public/vendor/adminlte/dist/js/adminlte

Do know know why require('../../public/vendor/adminlte/dist/js/adminlte') is working, but not require('../../vendor/almasaeed2010/adminlte/dist/js/adminlte') even if those files are identicals?

Thanks
Expected Behavior
I would expect require('../../vendor/almasaeed2010/adminlte/dist/js/adminlte') to load JS properly.

Hi @podionne , I'm not familiar with laravel mix. But maybe next issues can help you, the problem was similar:

#854
#629

Do you know why I have this folder?
/public/vendor/adminlte/dist/js/adminlte

Yes, it is part of the installation of this package, usually the AdminLTE files are published on the public folder. So we can include it on the master.blade.php file using the Laravel's asset() method. Note this procedure is only used when not enabling laravel mix. On the other hand, for laravel mix I think multiple files are compiled and installed (also) inside the public folder but usually as css/app.css and js/app.js (Check issue #525). However I may be wrong here...
Good luck, maybe someone can help you better here...

I have the same problem exactly.

@aksvitpav Maybe @podionne has found a solution by this time. However, have you checked for permissions problem or errors on the browser's console?

@Shidersz No errors in console, all permissions are ok.  require('../../public/vendor/adminlte/dist/js/adminlte') is my solution too.

@aksvitpav Not sure what can be the problem. I'm not familiarized with Laravel Mix... However, share your resources/js/bootstrap.js content. Maybe other can help you. Just in case, when @podionne shared his config, he wrote:
try {
    window.Popper = require('popper.js').default;
    window.$ = window.jQuery = require('jquery');
    require('bootstrap');
    require('overlayscrollbars');
    require('../../public/vendor/adminlte/dist/js/adminlte'); // working
    //require('../../vendor/almasaeed2010/adminlte/dist/js/adminlte'); // not working

} catch (e) {}

Can you try commenting out require('bootstrap') to see what happen? Since is not mentioned on the documentation .

Thanks, guys! I haven't found any other solution yet. I'll keep you posted if I find why.

May be I am wrong but you can't access files outside of the public directories. As public is the root directory of laravel.
Detailed information is given in this link.
https://stackoverflow.com/a/31528972

Hello. Today I'm create new Laranel 8 project with Laravel-AdminLTE and I do not have this problem anymore.

@aksvitpav Thanks for sharing. However the problem is rare, I hope someone can found a clue of what is causing that issue on the future.

yo resolví ese problema con lo siguiente:
npm install jquery
en el archivo bootstrap.js:
window.$ = window.jQuery = require('jquery');
require('overlayscrollbars');
require('../../vendor/almasaeed2010/adminlte/dist/js/adminlte.min.js');

Solution
Hello guys, so I had the same issue and start to test a lot of things. At some point we learnt to import the app.js & app.css into the blade page, but here we don't need it to load, because this repo do it by itself, in the config file config/adminlte.php when it is specified the paths of this files.
If we import this files into our blade pages then some issues may happen, like the collapse button of the sidebar, the search that is shown in the sidebar when is collapsed and others, so if you are having this issues remember to not to import app.js & app.css into the blade pages.
Hope this works for y'all.


Export from command line hangs if target file exists.

Godot version:
3.1.alpha.calinou.c3bb4ed
OS/device including version:
OS X 10.13.6
MacBook (Retina, 12-inch, 2017)
Issue description:
When exporting a project from the command line, the editor hangs if the target output file already exists.
Steps to reproduce:
(For this example, 'godot3.1' is a symlink to Godot.app/Contents/MacOS/Godot)
Using the attached project:

Do a CLI export to the build/ directory

$ godot3.1 project.godot --export "HTML5" ./build/index.html
arguments
0: godot3.1
1: project.godot
2: --export
3: HTML5
4: ./build/index.html
Current path: /Users/kmurphy/Desktop/Export Test
OpenGL ES 3.0 Renderer: Intel(R) HD Graphics 615
$ ls build
index.html  index.js    index.pck   index.png   index.wasm

The project is successfully exported, and the godot editor quits when the export is complete.

Repeat the process, leaving the existing export in place

$ godot3.1 project.godot --export "HTML5" ./build/index.html
arguments
0: godot3.1
1: project.godot
2: --export
3: HTML5
4: ./build/index.html
Current path: /Users/kmurphy/Desktop/Export Test
OpenGL ES 3.0 Renderer: Intel(R) HD Graphics 615

At this point, the editor hangs and does not exit, showing the "beachball" cursor. Ctrl-C in the terminal that launched the export successfully forces the editor to exit.

Remove the contents of build/

rm build/*

Try to export again.

godot3.1 project.godot --export "HTML5" ./build/index.html
arguments
0: godot3.1
1: project.godot
2: --export
3: HTML5
4: ./build/index.html
Current path: /Users/kmurphy/Desktop/Export Test
OpenGL ES 3.0 Renderer: Intel(R) HD Graphics 615
$ ls build
index.html  index.js    index.pck   index.png   index.wasm

The export succeeds.
Minimal reproduction project:
Export Test.zip

It appears to be fixed in the current master branch.


[CHANGE] Fixed camera coordinate system

Switched camera coordinate system to left handed, and flipped the y axis.

Closed since we accepted meine's fix instead.


Can't get oauth2 authorization code

I have a localhost api on my machine and after setting up the oauth 2 client plugin on that when I try to get the authorization code I get the error cannot get /undefined. I am using  the kong hello world node js client.
Kong version - 0.10.x

Can you please write down the commands to replicate?

@thefosk  Hi I was able to resolve the issue. The uri field that I gave while cerating the api and the api url that I gave while asking for the auth code were not matching.


Out of memory

Hi!
I'm trying to execute the script in the console and after a while I get an error.
Out of memory
debugging connection was closed reason render process gone.
How can I fix or prevent that? maybe there is an option to create a file with the usernames list instead of the GUI ?
Thanks.

We are aware of that. On the previous issue. Its probably because the amount of users that are being listed sinultaneously.
Working on a fix as soon as possible.

Duplicate #39

Thank you very much! Thanks for your response and thank you for this script

I have pushed a new update, now should work without crashing in large amount of unfollowers


queries returning messed up column names

Apologies for horrible title, have no concise way to describe what I'm seeing.
Bug report
System info:
influxdb 1.0 beta 3
CentOS/7 x86_64
Steps to reproduce:

select * from mymeasurement

Expected behavior: [What you expected to happen]
Receive correct column names
Actual behavior: [What actually happened]
One of the expected columns has _1 appended to it.
Additional info: [Include gist of relevant config, logs, etc.]
This is an example insert:
postgresql_databases,database=postgres,group=gdbs,host=iad1gdbs01,location=iad1,os=FreeBSD blk_read_time=0,blk_write_time=0,blks_hit=863929036i,blks_read=1611i,conflicts=0i,deadlocks=0i,numbackends=1i,temp_bytes=0i,temp_files=0i,tup_deleted=0i,tup_fetched=405057875i,tup_inserted=0i,tup_returned=506686415i,tup_updated=0i,xact_commit=7980561i,xact_rollback=90638i<PHONE_NUMBER>202000000

Here's the output of a select:
> select * from postgresql_databases where time > now() - 1m
name: postgresql_databases
--------------------------
time                    blk_read_time   blk_write_time  blks_hit        blks_read       conflicts       database        database_1      deadlocks       env     group   host            location        numbackends     os      temp_bytes      temp_files      tup_deleted     tup_fetched     tup_inserted    tup_returned    tup_updated     xact_commit     xact_rollback
1474066535068000000     0               0<PHONE_NUMBER>7<PHONE_NUMBER>      0                               denver          0                       gdbs    iad1gdbs03      iad1            0               Linux<PHONE_NUMBER>454   110155          0<PHONE_NUMBER>8     0<PHONE_NUMBER>23    0               581097          752
1474066535068000000     0               0               30305384        297             0                               postgres        0                       gdbs    iad1gdbs03      iad1            1               Linux   0               0               0               15896586        0               15935938        0               234910          0
1474066535068000000     0               0               0               0               0                               sessions        0                       gdbs    iad1gdbs03      iad1            0               Linux   0               0               0               0               0               0               0               0               0
1474066535726000000     0               0<PHONE_NUMBER>      5614            0                               postgres        0                       gdbs    iad1gdbs02      iad1            1               FreeBSD 0               0               0               562679893       0               689582443       0               16081429        49943
1474066535726000000     0               0<PHONE_NUMBER>6<PHONE_NUMBER>      51                              denver          0                       gdbs    iad1gdbs02      iad1            0               FreeBSD<PHONE_NUMBER>311   85479           0<PHONE_NUMBER>0     0<PHONE_NUMBER>95    0               1243071         431
1474066535726000000     0               0               215945218       6522            0                               sessions        0                       gdbs    iad1gdbs02      iad1            0               FreeBSD 0               0               0               97489928        0               261962611       0               786330          0
1474066541501000000     0               0               155196239       239             0                               postgres        0                       kdbu    iad1kdbu01      iad1            1               FreeBSD 0               0               0               82169108        0               285502974       0               875909          191616
1474066549274000000     0               0               864046661       1611            0                               postgres        0                       gdbs    iad1gdbs01      iad1            1               FreeBSD 0               0               0               405112983       0               506755662       0               7981649         90648
1474066549274000000     0               0<PHONE_NUMBER>      162666631       0                               sessions        0                       gdbs    iad1gdbs01      iad1            20              FreeBSD 0               0               85915491        159475201       85915957        739847886       8956436         16549066        4
1474066549274000000     0               0<PHONE_NUMBER>04<PHONE_NUMBER>      0                               denver          291                     gdbs    iad1gdbs01      iad1            153             FreeBSD<PHONE_NUMBER>817   56055           99531230<PHONE_NUMBER>98    249909043<PHONE_NUMBER>638   259918676       854287759       12567178
1474066564452000000     0               0               100624965       467             0                               postgres        0                       gdbp    iad1gdbp01      iad1            1               Linux   0               0               0               53670677        0               148832751       14              555096          109986
1474066564453000000     0               0<PHONE_NUMBER>7<PHONE_NUMBER>      0                               pricebot        103                     gdbp    iad1gdbp01      iad1            15              Linux<PHONE_NUMBER>073   2270            809926205<PHONE_NUMBER>4     947380758<PHONE_NUMBER>453   461810522       150412718       15192

Notice how the database column is empty, and we instead have a database_1.
This gets even weirder if you try to select these columns:
> select "database","database_1",xact_commit from postgresql_databases where time > now() - 1m
name: postgresql_databases
--------------------------
time                    database        database_1      xact_commit
1474066535068000000                                     581097
1474066535068000000                                     234910
1474066535068000000                                     0
1474066535726000000                                     16081429
1474066535726000000                                     1243071
1474066535726000000                                     786330
1474066541501000000                                     875909
1474066549274000000                                     7981649
1474066549274000000                                     16549066
1474066549274000000                                     854287759
1474066564452000000                                     555096
1474066564453000000                                     150412718

And if you try to use the columns, also nothing:
> select * from postgresql_databases where time > now() - 1m and "database"='postgres';
> select * from postgresql_databases where time > now() - 1m and "database_1"='postgres';
>

I just upgraded to 1.0.0 (not beta3), and issue is still present.

The problem just as suddenly went away. Nothing was changed. It just stopped.
However, I took a filesystem snapshot while the issue was present, and starting influxdb up with this snapshot still shows the issue.

@phemmer is it possible for me to get that dataset? Also, query logging should print out the expanded query. Can you paste the log output related to this query?

Unfortunately the data is now gone. Was on an LVM snapshot, and the snapshot ran out of space early this morning, and was destroyed.
I'll keep an eye out for the problem and capture the requested info when it happens again.
As for getting the data to you, I'm not sure. It's several GB, so it's not easy to move around, unless there is some way of only grabbing the relevant data.

Ok, if it happens again, please comment here and I'll reopen the issue. I'm going to close this as not able to reproduce.

I had a similar issue with rows like row and row_1
My error was to define row as Tag and Field

I just installed influx and this happened pretty much immediately. I never added a column symbol_1

Just like previous poster, this issue went away as soon as I restarted my machine.

Unlike the previous posters,

I absolutely did not have the same column as a field and a tag. It was always a tag - I simply did not change the code that was writing to the measurement, only the measurement name, but after I ran a SELECT * INTO newmeasuremnet FROM oldmeasurement, writes into newmeasurement (or queries from it) return all tags with _1 appended.
The problem did not go away after restarting the Influx server.


googleapiclient.errors occur, what is the problem?

I have install autosub,when I  run a demo using google api key you provided in code ,I got a error like this, how did it happen?
hustclf@ubuntu:~/.local/bin$ ./autosub -o /home/hustclf/ -F srt -S zu -D en -K AIzaSyBOti4mM-6x9WDnZIjIeyEU21OpBXqWBgw /home/hustclf/Desktop/zulu.vdat  Converting speech regions to FLAC files: 100% |###################################| Time: 0:00:08 Performing speech recognition: 100% |#############################################| Time: 0:00:38 Exception in thread Thread-3:8% |####                                             | ETA:  0:00:00 Traceback (most recent call last):   File "/usr/lib/python2.7/threading.py", line 801, in __bootstrap_inner     self.run()   File "/usr/lib/python2.7/threading.py", line 754, in run     self.__target(*self.__args, **self.__kwargs)   File "/usr/lib/python2.7/multiprocessing/pool.py", line 389, in _handle_results     task = get()   File "/home/hustclf/.local/lib/python2.7/site-packages/oauth2client/util.py", line 137, in positional_wrapper     return wrapped(*args, **kwargs) TypeError: ('__init__() takes at least 3 arguments (1 given)', <class 'googleapiclient.errors.HttpError'>, ())

+1 I'm getting the same error.  I'm using Python 2.7.9.

I tried to debug this but couldn't, I will look more into it tomorrow.

Same issue with translate option.

yes billing solved my problem

thanks @nhtera

Thanks, The api I used is not free any more

https://github.com/matheuss/google-translate-api
https://ctrlq.org/code/19909-google-translate-api


Use the async transform API, add caller and drop dependencies on the beta/rc range.

Just prepping for the stable release.

Drop Node 4.x
Use transformAsync
Pass caller

Failure is from travis node 4, so can remove from travis.yml


feat(tdhttp): add With, T, Run, OrDumpResponse and AutoDumpResponse

*tdhttp.TestAPI methods

Pull Request Test Coverage Report for Build 604124286

123 of 123 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 99.82%

Totals

Change from base Build 602799603:
0.002%

Covered Lines:
7754

Relevant Lines:
7768

💛  - Coveralls

@deathiop better late than never :)


All statements should include an id

I do not believe that this library fulfils the following requirement from the cmi5 quartz specification:

The AU MUST assign a statement id property in UUID format (as defined in the xAPI specification) for all statements it issues.

Forgive me if I have missed something.
The code seems very clear and easy to follow.

Hi @thomasturrell thanks for reporting an issue.
I've quite possibly misinterpreted this requirement as "IF a statement from the AU contains an ID, the ID must be in the UUID format", rather than "EVERY statement from the AU must have an ID, which is in the UUID format".
Within the broader xAPI specification, the ID property is optional when creating statements from the AU and it suggests that the ID SHOULD be generated by the LRP, and MUST be created by the LRS if one is not supplied.
I'm happy to add an autogenerated ID from the client-side, although it does open up the rare possibility of an ID clash within the LRS. Do you think we would also need the option to manually specify/override the ID?

In theory it's virtually impossible for a statement ID to clash with an existing one in the LRS. However in practice I have seen it happen (frequently), there are LRPs out in the wild which do not use at the correct algorithm for generating a UUID.
I am unsure why there is a requirement for the AU to generate the statement ID. Personally, I do not think the statement ID is useful to the AU, most implementations send and then forget statements.
In my opinion autogenerating the ID from the client side library (using a decent UUID library) without giving the option to override is the way to go.

I cannot argue with that 😄 does #102 meet the criteria?

Looks good to me. I approved your pull request (which seems a bit weird, hopefully you don't mind!)

Thanks @thomasturrell - the change will be included as part of the next release cycle.


Specify functionality and design of the web app

Button to reset the sudoku form

Generating a random sudoku to solve

Title + About page


Customize player name with dialogic

I am trying to set up where the player can create their own player name through dialogic but I don't know how.  I suspect it's done through the character file and creating a json file.  But I'm not sure.  I can get it running but I can't get it do what I want.  Plus help

You likely need to add a variable definition named Buddy too for this to work.

Could you please let us know if adding a "Buddy" definition fixed this for you? Otherwise I will have to close this soon.

I tried that, but it didn't work
On Sun., Apr. 23, 2023, 5:31 a.m. Jowan-Spooner, @.***>
wrote:

Could you please let us know if adding a "Buddy" definition fixed this for
you? Otherwise I will have to close this soon.
—
Reply to this email directly, view it on GitHub
https://github.com/coppolaemilio/dialogic/issues/1516#issuecomment-1519042372,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7HQOYBNMVV4D2RPLBYERZLXCUHKTANCNFSM6AAAAAAXBKL5JM
.
You are receiving this because you authored the thread.Message ID:
@.***>

Alright, thanks then maybe @zaknafean has to take another look. Personally left 1.x behind a long time ago...

I know how to do this on renpy.  I'm new to godot, and I'm still learning.
so I tried to figure out what I'm doing wrong. Unfortunately, anytime I ask
either reddit or someone on YouTube it seems they don't know for sure
either.  There must be a way to do it but I don't know how to do that.
On Sun., Apr. 23, 2023, 12:43 p.m. Jowan-Spooner, @.***>
wrote:

Alright, thanks then maybe @zaknafean https://github.com/zaknafean has
to take another look. Personally left 1.x behind a long time ago...
—
Reply to this email directly, view it on GitHub
https://github.com/coppolaemilio/dialogic/issues/1516#issuecomment-1519129875,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7HQOYEQBZSEDA3Y7H3EM3DXCVZ5XANCNFSM6AAAAAAXBKL5JM
.
You are receiving this because you authored the thread.Message ID:
@.***>

If you are not too far into development I would recommend you to start with Godot 4 and Dialogic 2. It is pretty simple to do something like this in the new Dialogic, even if it is still not officially released.

Sorry only just saw this. So this works, but you're slightly overcomplicating things. Dialogic will handle the definition for you, but you have to set it up ahead of time. I'll attach a quick video of it working in action.
https://user-images.githubusercontent.com/7741797/235303919-fbefbf10-930b-4495-86ef-d53f751391b2.mp4
And the relevant screenshots in Dialogic
The Timeline

The Character

and critically, the definition

Within your script, here is where the defintiion is being set:

You aren't and do not need to edit the JSON directly. Let the definitions do the work

Thx for getting back to me.  I'll definitely look into it.  If I'm able to
get working I'll show you my progress just in case.  Because I would like
to use it, because it does have a good set up, and helps to reduce errors.
I can't say the same thing with Renpy where the coding was easy but I ran
into huge problems.
On Sat., Apr. 29, 2023, 7:05 a.m. zaknafean, @.***>
wrote:

Sorry only just saw this. So this works, but you're slightly
overcomplicating things. Dialogic will handle the definition for you, but
you have to set it up ahead of time. I'll attach a quick video of it
working in action.
https://user-images.githubusercontent.com/7741797/235303919-fbefbf10-930b-4495-86ef-d53f751391b2.mp4
And the relevant screenshots in Dialogic
The Timeline
[image: image]
https://user-images.githubusercontent.com/7741797/235303961-4ef625d4-8cac-4a4b-845c-a4e4de4e56e6.png
The Character
[image: image]
https://user-images.githubusercontent.com/7741797/235303976-89b553ef-f8e1-4199-9145-a4d472a5a681.png
and critically, the definition
[image: image]
https://user-images.githubusercontent.com/7741797/235303999-267d43ce-e0c9-4b24-8fb0-119009174770.png
Within your script, here is where the defintiion is being set:
[image: image]
https://user-images.githubusercontent.com/7741797/235304021-642f34f5-4445-41f1-af4c-c68b396ee806.png
You aren't and do not need to edit the JSON directly. Let the definitions
do the work
—
Reply to this email directly, view it on GitHub
https://github.com/coppolaemilio/dialogic/issues/1516#issuecomment-1528784004,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7HQOYDVY7RYX4IOKZZGNNDXDUGYPANCNFSM6AAAAAAXBKL5JM
.
You are receiving this because you authored the thread.Message ID:
@.***>

@MrAnonymous96 let us know if this was fixed or abandoned, so we can close this.

No, it has not.
On Sat., Aug. 26, 2023, 2:43 a.m. Jowan-Spooner, @.***>
wrote:

@MrAnonymous96 https://github.com/MrAnonymous96 let us know if this was
fixed or abandoned, so we can close this.
—
Reply to this email directly, view it on GitHub
https://github.com/coppolaemilio/dialogic/issues/1516#issuecomment-1694230482,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7HQOYA5LNIKOEUYITMOZDLXXGZJ3ANCNFSM6AAAAAAXBKL5JM
.
You are receiving this because you were mentioned.Message ID:
@.***>

Following zaknafean's process, I can confirm it works like a charm for dynamically changing character names.  I think if you follow zaknafean's process, you should be able to get what you're looking for.
https://github.com/coppolaemilio/dialogic/assets/117393840/58ffacbb-b239-4d70-b607-cd828561fc1e


Fix longer compile time issues with direct SPIR-V backend

This is already tracked under nvbugs
https://nvbugs/4337483 Vulkan driver takes long time to compile Slang generated SPIRV shaders.

What is going on why does this person keep posting issues with broken links?

We can consider this issue fixed. We are within 10% difference.


Tag last batch when coalescing

Updates the coalesce iterator to tag the last batch being emitted.  This allows code using the iterator to detect the last batch from the iterator without relying on hasNext which often has the unfortunate side-effect of manifesting another batch in memory.

build


added criteria for signing and verifying assets

This splits off part of #35 into criteria for producing signatures and producing signature verification docs

@eddie-knight I repushed your branch to fix the merge conflicts.


Allow contributions of custom CSS properties to CSS extension

The motivation is that today, css Language Service would suggest that you have invalid properties.
https://github.com/Microsoft/vscode-css-languageservice/issues/68

Although by adopting MDN data we should solve the problem, however if new properties come up CSS LS can still fall behind.
We should provide a config [css/less/scss].validate.acceptedProperties or something similar that stops CSS LS from complaining about "unknown property".

@aeschli Actually today we already have a config css.lint.unknownProperties, you can set it to ignore to suppress this error. Can you link to original issues that describe the issue?

Isn't this setting ignores all properties? For instance, this will pass:
body {
    teapot: yes;
}

@usernamehw My worry is that we are offering too much surface area for linting settings, when all we offer is a subset of https://github.com/CSSLint/csslint and now we are forking with some more options...
When we have MDN data for properties it'll actually solve all three existing "unknown properties" issues:

overscroll-behavior: https://github.com/Microsoft/vscode/issues/46866
font-display: https://github.com/Microsoft/vscode/issues/46423
backdrop-filter: https://github.com/Microsoft/vscode/issues/27204

@octref yes, you can use "less.lint.unknownProperties" to turn off all validation warnings.
But the idea is to just be able to pass a list accepted properties, so you can still get validation for all others.

@aeschli The MDN data contains experimental properties such as appearance. CSSNext only implements what's already in Recommendation Candidate, by which point MDN would already have a data point on it.
I suggest that we pull in the MDN data, see if that addresses people's complaint

Given that post-processors become more and more common, custom properties getting more used to.

If the need arises we can always add that. But I think if someone is using a property not known on MDN (as compared to now known on our outdated css-schema), it's fair we output a warning.

Would it be possible to fix the type in the title of this issue? As it is, it doesn't show up in a search for "unknown property". It would help those of us searching for this exact issue know it is being worked on. Thanks!

@shockthetoast Done, thanks!

This is no longer an issue — using latest data from MDN so we don't have "unknown properties" any more.

Hi, I'm searching for a way to add custom properties to css.lint, since in our project (Apache Royale) we have custom properties related only to our project, since I'm using VSCode, I'd love to have some way to add custom properties and even create some extension for it. Thanks for any advice on this.

I also think we should have this for custom properties.

Great,
I think so, since CSS is open its capabilities and used in many new ways that can't be controlled.
Here's a screenshot of a typical Apache Royale use case:

I expect that we can remove the css lint error configuring in some way a config file. Even add this config file to extensions like AS3 & MXML Extension that already manages Apache Royale projects so we can catch error typing this kind of custom css properties.
Thanks!

I think this'd be where the custom properties would be injected?: https://github.com/Microsoft/vscode-css-languageservice/blob/5d43b341a3b149bcabc3e178ada73ef0b876f2f3/src/services/languageFacts.ts#L777

So I've gotten a decent way through making this work, but I can't figure out the correct way to pass the custom property configuration into the place it's needed.
I see this line elsewhere in the vscode-css-languageservice repo, but I can't figure out how to pass a settings object to the languageFacts.ts file in a similar way.
The docs say to use vscode.workspace.getConfiguration('myExtension'), but I can't get the vscode module imported into the vscode-css-languageservice extension for whatever reason. I just end up with Cannot find module 'vscode'. (this is after adding vscode as a dependency in the package.json, installing, and restarting).
I suppose it's also important to note that I added the configuration to the package.json for vscode/extensions/css-language-features, rather than vscode-css-languageservice, because all other existing configuration options were there already.
Any guidance on how I should pass the user's configuration into vscode-languageservice's languageFacts.ts? I can share my current code if that'd help.

Hi connor, thanks for working on this. Just to understand the progress. Are you implementing some kind of property file where we can add the custom css properties we want to be recognized by vscode lint, and get rid of lint errors? (event get code-intelligence for those custom properties defined in that property file? Thanks!

@carlosrovira Right now it's a WIP so it's hard-coded until I can figure out how to pass the configuration into it, but it looks like this:

Currently the description isn't able to be customized, it's just set as "Custom property", but that can probably be changed relatively easily if you'd really like to be able to do that.
The properties would be defined in a VS Code settings.json file, which could be user-specific or workspace-specific (e.g. you'd have a file at .vscode/settings.json and it defines various custom properties you use in that project), like this:
{
  "css.customProperties": [
    "custom-property-name",
    "another-custom-property",
    "custom-property-three"
  ]
}

@connorshea It would be better start working after discussing with me or @aeschli. I don't think we'll go with that approach (more likely going with the direction of the Markdown Extension API https://code.visualstudio.com/docs/extensionAPI/api-markdown), specify a JSON format and add contribution points.
This issue is only for adding a setting to make VS Code not complain about unknown properties.

@octref

@connorshea It would be better start working after discussing with me or aeschli.

Fair enough, that's my bad :)

This issue is only for adding a setting to make VS Code not complain about unknown properties.

A setting to make VS Code not complain about unknown properties already exists as you mentioned above ("css.lint.unknownProperties": "ignore"), the issue does mention a [css/less/scss].validate.acceptedProperties setting, though, which is what I was trying to implement.
Also, just to clarify, a "CSS Extension API" would be preferable because it would allow extensions to add CSS properties, or am I missing other reasons?

Oops, the title tricked me, updated.

Also, just to clarify, a "CSS Extension API" would be preferable because it would allow extensions to add CSS properties, or am I missing other reasons?

As compared to saving everything in the project config, I think putting all the custom CSS property definitions in a JSON and allow a setting/contribution to refer to it would be better. This keeps clutter away from workspace config and allows others to auto-generate the JSON file.

@octref I'm not against allowing users to define sets of properties in a separate file, but IMO a simple user setting is a good start/ The css language service doesn't deal with files anyways, it's just a library, also to be used in Monaco. All validation configuration comes in through config objects, so LanguageSettings is the right place.
Where this gets relevant is in the server that uses the service. Let's discuss how we proceed once we are there.
@Connormiha The validation happens here:
https://github.com/Microsoft/vscode-css-languageservice/blob/83462f41b87303ffc32b58b714a18806da389182/src/services/lint.ts#L413
Here you would say, only report error of not a known property or not in the list.

Also, just to clarify, a "CSS Extension API" would be preferable because it would allow extensions to add CSS properties, or am I missing other reasons?

I expect the AS3 & MXML(http://as3mxml.com/) extension could add a file so we have our custom properties manages directly by the extension that provide all the language support.
Thanks

FYI: https://github.com/Microsoft/vscode/issues/64164


Issues when deleting images

When I tried to delete images from a gallery, I am getting:
event.layerX and event.layerY are broken and deprecated in WebKit. They will be removed from the engine in the near future.
and:
Refused to set unsafe header "Connection"
SilverStripe v2.4.6

both are unrelated to the module, you'll find the first one appeared with a recent release of Chrome and probably all webkit browsers. something to do with the old version of jquery shipped with Silverstripe (1.4.2 I believe).
the latter one is related to the Silverstripe core.
thanks
James


Makefile无法使用

你好，我在windows平台，使用gcc-arm-none-eabi-5_4编译器，git clone后在路径下make，出现了以下错误:
arm-none-eabi-gcc    -c -o stm32f10x_lib/CMSIS/CM3/DeviceSupport/ST/STM32F10x/startup/gcc_ride7/startup_stm32f10x_md_vl.o stm32f10x_lib/CMSIS/CM3/DeviceSupport/ST/STM32F10x/startup/gcc_ride7/startup_stm32f10x_md_vl.s arm-none-eabi-gcc    -c -o user/main.o user/main.c user/main.c:5:23: fatal error: stm32f10x.h: No such file or directory compilation terminated. make: *** [<builtin>: user/main.o] Error 1

for linux or osx is ok


multiple windows on osx

Hi there,
trying to understand why I'm getting this error
Traceback (most recent call last):
  File "_ctypes/callbacks.c", line 237, in 'calling callback function'
  File "/Users/spencerw/miniconda3/envs/bmi38/lib/python3.8/site-packages/pyglet/libs/darwin/cocoapy/runtime.py", line 1120, in objc_method
    args = convert_method_arguments(encoding, args)
  File "/Users/spencerw/miniconda3/envs/bmi38/lib/python3.8/site-packages/pyglet/libs/darwin/cocoapy/runtime.py", line 1000, in convert_method_arguments
    new_args.append(ObjCInstance(a))
  File "/Users/spencerw/miniconda3/envs/bmi38/lib/python3.8/site-packages/pyglet/libs/darwin/cocoapy/runtime.py", line 921, in __new__
    if not isinstance(object_ptr, c_void_p):
RecursionError: maximum recursion depth exceeded while calling a Python object
Segmentation fault: 11

running the multiple window example here, specifically when i try to click (firing the callback).
also interestingly the "windows" are tabs within one window, but i think this might be my default setting on osx / cocoa
looks like the example is pretty old-- happy to make a PR for a fix, but would be good to understand the expected multiple windowing solution. my application needs to update graphics on several windows at each render.
thanks!

Hi,
there was a bug affecting newer Macs, which is now fixed in the pyglet-1.5-maintenance branch. It will be in the upcoming point release. In the mean time, give that branch a try and let us know if it fixes it for you.

haven't tried the branch, but turning off Prefer tabs when opening documents in SysPref-->Dock fixed this issue. Will try the branch and comment as well

The fix in the maintenance branch is just for the RecursionError not the tabs. Did you mean switching to tab had an affect on that as well?

switching to Do not prefer tabs removes the error-- seems like just an OSX/Cocoa glitch when using tabs.

Since you got this figured out, I'll close this for now. Please reopen it, or a new ticket if you're still having issues. Thanks!


./hack/update-codegen.sh fails to run in temp folder in macOSX

The ./hack/update-codegen.sh script fails to create and run in temp GOPATH. For the ./hack/update-openapigen.sh thus swaps all the github path to local paths and led to the following API rule violations.
± ./hack/update-codegen.sh
You appear to be running from outside of GOPATH.
This script will create a temporary GOPATH at /var/folders/6w/78wy05qx2y3cwd5v96bmdt0000zp1h/T/tmp.8bYDTSCl/.gopath for code generation.
Moving to /var/folders/6w/78wy05qx2y3cwd5v96bmdt0000zp1h/T/tmp.8bYDTSCl/.gopath/src/github.com/tektoncd/pipeline
# k8s.io/code-generator/cmd/lister-gen
ld: warning: -no_pie is deprecated when targeting new OS versions
ld: warning: non-standard -pagezero_size is deprecated when targeting macOS 13.0 or later
# k8s.io/code-generator/cmd/informer-gen
ld: warning: -no_pie is deprecated when targeting new OS versions
ld: warning: non-standard -pagezero_size is deprecated when targeting macOS 13.0 or later
# k8s.io/code-generator/cmd/defaulter-gen
ld: warning: -no_pie is deprecated when targeting new OS versions
ld: warning: non-standard -pagezero_size is deprecated when targeting macOS 13.0 or later
# k8s.io/code-generator/cmd/client-gen
ld: warning: -no_pie is deprecated when targeting new OS versions
ld: warning: non-standard -pagezero_size is deprecated when targeting macOS 13.0 or later
# k8s.io/code-generator/cmd/deepcopy-gen
ld: warning: -no_pie is deprecated when targeting new OS versions
ld: warning: non-standard -pagezero_size is deprecated when targeting macOS 13.0 or later
Generating deepcopy funcs for pipeline:v1alpha1,v1beta1,v1
/Users/jeromeju/Desktop/pipeline/hack/generate-groups.sh: line 71: /var/folders/6w/78wy05qx2y3cwd5v96bmdt0000zp1h/T/tmp.8bYDTSCl/.gopath/bin/deepcopy-gen: No such file or directory

./hack/update-openapigen.sh
Generating OpenAPI specification for v1beta1 ...

ERROR: New API rule violations found which are not present in hack/ignored-openapi-violations.list.
It seems that otherwise it confused GOPATH on where the repo lives with relative paths.


Flake: AccessLogManagerImplTest.ReopenRetry

Flake: AccessLogManagerImplTest.ReopenRetry
Description:
has code coverage test failure from test, 19914, 19962, 19777
Running it with coverage locally:
[06:55:04] kbaichoo:envoy:0 $bazel test --config=coverage //test/common/access_log:access_log_manager_impl_test --runs_per_test=1000 --test_filter="*ReopenRetry*"
INFO: Analyzed target //test/common/access_log:access_log_manager_impl_test (0 packages loaded, 227 targets configured).
INFO: Found 1 test target...

  bazel-bin/test/common/access_log/access_log_manager_impl_test
INFO: Elapsed time: 1305.064s, Critical Path: 177.43s
INFO: 1003 processes: 2 internal, 1001 linux-sandbox.
INFO: Build completed, 1 test FAILED, 1003 total actions
//test/common/access_log:access_log_manager_impl_test                    FAILED in 61 out of 1000 in 166.9s
  Stats over 1000 runs: max = 166.9s, min = 5.5s, avg = 120.4s, dev = 25.5s

Flake seems related with https://github.com/envoyproxy/envoy/pull/19714
  [07:37:55] kbaichoo:envoy:0 $cat  /usr/local/google/home/kbaichoo/.cache/bazel/_bazel_kbaichoo/75388abe3eaf73a64e5fc0563befa9b7/execroot/envoy/bazel-out/k8-fastbuild/testlogs/test/common/access_log/access_log_manager_impl_test/run_997_of_1000/test.log
exec ${PAGER:-/usr/bin/less} "$0" || exit 1
Executing tests from //test/common/access_log:access_log_manager_impl_test
-----------------------------------------------------------------------------
Note: Google Test filter = *ReopenRetry*
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from AccessLogManagerImplTest
[ RUN      ] AccessLogManagerImplTest.ReopenRetry
test/common/access_log/access_log_manager_impl_test.cc:447: Failure
Expected equality of these values:
  0UL
    Which is: 0
  store_.gauge("filesystem.write_total_buffered", Stats::Gauge::ImportMode::Accumulate) .value()
    Which is: 12
Stack trace:
  0x88a4e0: Envoy::AccessLog::(anonymous namespace)::AccessLogManagerImplTest_ReopenRetry_Test::TestBody()
  0x7f3968a026dd: testing::internal::HandleSehExceptionsInMethodIfSupported<>()
  0x7f39689e97c1: testing::internal::HandleExceptionsInMethodIfSupported<>()
  0x7f39689cd34d: testing::Test::Run()
  0x7f39689ce0a4: testing::TestInfo::Run()
... Google Test internal frames ...

[  FAILED  ] AccessLogManagerImplTest.ReopenRetry (25 ms)
[----------] 1 test from AccessLogManagerImplTest (25 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (25 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] AccessLogManagerImplTest.ReopenRetry

[optional Relevant Links:]

Any extra documentation required to understand the issue.

/assign @pyrl247
Mind taking a look since the flake seems related to a line you added? Thanks


restart: always

It makes sense to add restart: always to docker-compose.yml because this will auto-restart the mail container in case of docker service/host reboot and other issues.

Could you add this to the README and dist file?

@tomav: PR for adding to docker-compose.yml (dist) files (also to the elk variant): https://github.com/tomav/docker-mailserver/pull/550

Fixed by #550


1.1.0-never_closed_socket

When connect() failed in __apn_connect(), socket is never closed.

fault operation.


Allow exclusion of priority data

What change(s) does this PR introduce?

My team doesn't use Priority in Jira, the API returns nothing from our Priority endpoint, and so source jira.priority never gets loaded into the warehouse. Instead, we use custom fields. We still need downstream models like jira__issue_enhanced, which depend on priority data. This PR allows exclusion of priority data, so jira__issue_enhanced can get built even if a team lacks priority data.
Makes priority data optional. Allows new env var jira_using_priorities. Models jira__issue_enhanced and int_jira__issue_join won't require source jira.priority or contain priority-related columns if jira_using_priorities: false.
Did you update the CHANGELOG?

[x] Yes

Does this PR introduce a breaking change?

[ ] Yes (please provide breaking change details below.)
[x] No  (please provide an explanation as to how the change is non-breaking below.)

Priority data is still used by default (env var jira_using_priorities: true in dbt_project.yml).
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

[x] Yes

Project versions bumped in both files.
Is this PR in response to a previously created Bug or Feature Request

[ ] Yes, Issue/Feature [link bug/feature number here]
[x] No

How did you test the PR changes?

[ ] CircleCi
[x] Local (please provide additional testing details below)

Tested manually with dbt CLI (dbt run --select jira_source jira) from my local machine (Windows 10, PowerShell) to a Redshift warehouse using dbt-core 1.0.4 and dbt-redshift 1.0.0. All models defined in this repo are built successfully. All models in fivetran/jira_source package except stg_jira__priority_tmp and stg_jira__priority are built successfully; stg_jira__priority_tmp throws an error and stg_jira__priority gets skipped, but this is intentional.
Output:
> dbt run --select jira_source jira
17:38:22  Running with dbt=1.0.4
17:38:25  Found 130 models, 117 tests, 0 snapshots, 0 analyses, 586 macros, 0 operations, 0 seed files, 37 sources, 0 exposures, 0 metrics
17:38:25
17:38:29  Concurrency: 1 threads (target='dev')
17:38:29
17:38:29  1 of 46 START view model stg_jira.stg_jira__comment_tmp......................... [RUN]
17:38:29  1 of 46 OK created view model stg_jira.stg_jira__comment_tmp.................... [CREATE VIEW in 0.60s]
17:38:29  2 of 46 START view model stg_jira.stg_jira__component_tmp....................... [RUN]
17:38:30  2 of 46 OK created view model stg_jira.stg_jira__component_tmp.................. [CREATE VIEW in 0.59s]
17:38:30  3 of 46 START view model stg_jira.stg_jira__field_option_tmp.................... [RUN]
17:38:30  3 of 46 OK created view model stg_jira.stg_jira__field_option_tmp............... [CREATE VIEW in 0.56s]
17:38:30  4 of 46 START view model stg_jira.stg_jira__field_tmp........................... [RUN]
17:38:31  4 of 46 OK created view model stg_jira.stg_jira__field_tmp...................... [CREATE VIEW in 0.60s]
17:38:31  5 of 46 START view model stg_jira.stg_jira__issue_field_history_tmp............. [RUN]
17:38:32  5 of 46 OK created view model stg_jira.stg_jira__issue_field_history_tmp........ [CREATE VIEW in 0.59s]
17:38:32  6 of 46 START view model stg_jira.stg_jira__issue_link_tmp...................... [RUN]
17:38:32  6 of 46 OK created view model stg_jira.stg_jira__issue_link_tmp................. [CREATE VIEW in 0.60s]
17:38:32  7 of 46 START view model stg_jira.stg_jira__issue_multiselect_history_tmp....... [RUN]
17:38:33  7 of 46 OK created view model stg_jira.stg_jira__issue_multiselect_history_tmp.. [CREATE VIEW in 0.60s]
17:38:33  8 of 46 START view model stg_jira.stg_jira__issue_tmp........................... [RUN]
17:38:33  8 of 46 OK created view model stg_jira.stg_jira__issue_tmp...................... [CREATE VIEW in 0.60s]
17:38:33  9 of 46 START view model stg_jira.stg_jira__issue_type_tmp...................... [RUN]
17:38:34  9 of 46 OK created view model stg_jira.stg_jira__issue_type_tmp................. [CREATE VIEW in 0.58s]
17:38:34  10 of 46 START view model stg_jira.stg_jira__priority_tmp....................... [RUN]
17:38:34  10 of 46 ERROR creating view model stg_jira.stg_jira__priority_tmp.............. [ERROR in 0.32s]
17:38:34  11 of 46 START view model stg_jira.stg_jira__project_tmp........................ [RUN]
17:38:35  11 of 46 OK created view model stg_jira.stg_jira__project_tmp................... [CREATE VIEW in 0.57s]
17:38:35  12 of 46 START view model stg_jira.stg_jira__resolution_tmp..................... [RUN]
17:38:36  12 of 46 OK created view model stg_jira.stg_jira__resolution_tmp................ [CREATE VIEW in 0.58s]
17:38:36  13 of 46 START view model stg_jira.stg_jira__sprint_tmp......................... [RUN]
17:38:36  13 of 46 OK created view model stg_jira.stg_jira__sprint_tmp.................... [CREATE VIEW in 0.57s]
17:38:36  14 of 46 START view model stg_jira.stg_jira__status_category_tmp................ [RUN]
17:38:37  14 of 46 OK created view model stg_jira.stg_jira__status_category_tmp........... [CREATE VIEW in 0.54s]
17:38:37  15 of 46 START view model stg_jira.stg_jira__status_tmp......................... [RUN]
17:38:37  15 of 46 OK created view model stg_jira.stg_jira__status_tmp.................... [CREATE VIEW in 0.57s]
17:38:37  16 of 46 START view model stg_jira.stg_jira__user_tmp........................... [RUN]
17:38:38  16 of 46 OK created view model stg_jira.stg_jira__user_tmp...................... [CREATE VIEW in 0.56s]
17:38:38  17 of 46 START view model stg_jira.stg_jira__version_tmp........................ [RUN]
17:38:38  17 of 46 OK created view model stg_jira.stg_jira__version_tmp................... [CREATE VIEW in 0.57s]
17:38:38  18 of 46 START table model stg_jira.stg_jira__comment........................... [RUN]
17:38:41  18 of 46 OK created table model stg_jira.stg_jira__comment...................... [SELECT in 2.11s]
17:38:41  19 of 46 START table model stg_jira.stg_jira__component......................... [RUN]
17:38:41  19 of 46 OK created table model stg_jira.stg_jira__component.................... [SELECT in 0.84s]
17:38:41  20 of 46 START table model stg_jira.stg_jira__field_option...................... [RUN]
17:38:42  20 of 46 OK created table model stg_jira.stg_jira__field_option................. [SELECT in 0.85s]
17:38:42  21 of 46 START table model stg_jira.stg_jira__field............................. [RUN]
17:38:43  21 of 46 OK created table model stg_jira.stg_jira__field........................ [SELECT in 0.84s]
17:38:43  22 of 46 START table model stg_jira.stg_jira__issue_field_history............... [RUN]
17:38:52  22 of 46 OK created table model stg_jira.stg_jira__issue_field_history.......... [SELECT in 9.19s]
17:38:52  23 of 46 START table model stg_jira.stg_jira__issue_link........................ [RUN]
17:38:53  23 of 46 OK created table model stg_jira.stg_jira__issue_link................... [SELECT in 0.84s]
17:38:53  24 of 46 START table model stg_jira.stg_jira__issue_multiselect_history......... [RUN]
17:38:56  24 of 46 OK created table model stg_jira.stg_jira__issue_multiselect_history.... [SELECT in 3.05s]
17:38:56  25 of 46 START table model stg_jira.stg_jira__issue............................. [RUN]
17:38:58  25 of 46 OK created table model stg_jira.stg_jira__issue........................ [SELECT in 1.88s]
17:38:58  26 of 46 START table model stg_jira.stg_jira__issue_type........................ [RUN]
17:38:59  26 of 46 OK created table model stg_jira.stg_jira__issue_type................... [SELECT in 0.89s]
17:38:59  27 of 46 SKIP relation stg_jira.stg_jira__priority.............................. [SKIP]
17:38:59  28 of 46 START table model stg_jira.stg_jira__project........................... [RUN]
17:39:00  28 of 46 OK created table model stg_jira.stg_jira__project...................... [SELECT in 0.96s]
17:39:00  29 of 46 START table model stg_jira.stg_jira__resolution........................ [RUN]
17:39:01  29 of 46 OK created table model stg_jira.stg_jira__resolution................... [SELECT in 0.88s]
17:39:01  30 of 46 START table model stg_jira.stg_jira__sprint............................ [RUN]
17:39:02  30 of 46 OK created table model stg_jira.stg_jira__sprint....................... [SELECT in 0.98s]
17:39:02  31 of 46 START table model stg_jira.stg_jira__status_category................... [RUN]
17:39:03  31 of 46 OK created table model stg_jira.stg_jira__status_category.............. [SELECT in 0.92s]
17:39:03  32 of 46 START table model stg_jira.stg_jira__status............................ [RUN]
17:39:04  32 of 46 OK created table model stg_jira.stg_jira__status....................... [SELECT in 0.94s]
17:39:04  33 of 46 START table model stg_jira.stg_jira__user.............................. [RUN]
17:39:05  33 of 46 OK created table model stg_jira.stg_jira__user......................... [SELECT in 0.90s]
17:39:05  34 of 46 START table model stg_jira.stg_jira__version........................... [RUN]
17:39:06  34 of 46 OK created table model stg_jira.stg_jira__version...................... [SELECT in 0.93s]
17:39:06  35 of 46 START incremental model test.int_jira__issue_calendar_spine............ [RUN]
17:40:50  35 of 46 OK created incremental model test.int_jira__issue_calendar_spine....... [SELECT in 104.21s]
17:40:50  36 of 46 START incremental model test.int_jira__agg_multiselect_history......... [RUN]
17:40:59  36 of 46 OK created incremental model test.int_jira__agg_multiselect_history.... [SELECT in 8.69s]
17:40:59  37 of 46 START table model test.int_jira__issue_type_parents.................... [RUN]
17:41:02  37 of 46 OK created table model test.int_jira__issue_type_parents............... [SELECT in 3.11s]
17:41:02  38 of 46 START incremental model test.int_jira__combine_field_histories......... [RUN]
17:41:56  38 of 46 OK created incremental model test.int_jira__combine_field_histories.... [SELECT in 53.70s]
17:41:56  39 of 46 START incremental model test.int_jira__daily_field_history............. [RUN]
17:42:01  39 of 46 OK created incremental model test.int_jira__daily_field_history........ [SELECT in 4.83s]
17:42:01  40 of 46 START table model test.int_jira__issue_join............................ [RUN]
17:42:07  40 of 46 OK created table model test.int_jira__issue_join....................... [SELECT in 6.12s]
17:42:07  41 of 46 START incremental model test.int_jira__pivot_daily_field_history....... [RUN]
17:42:09  41 of 46 OK created incremental model test.int_jira__pivot_daily_field_history.. [SELECT in 1.23s]
17:42:09  42 of 46 START table model test.int_jira__field_history_scd..................... [RUN]
17:42:10  42 of 46 OK created table model test.int_jira__field_history_scd................ [SELECT in 1.61s]
17:42:10  43 of 46 START incremental model test.jira__daily_issue_field_history........... [RUN]
17:44:59  43 of 46 OK created incremental model test.jira__daily_issue_field_history...... [SELECT in 168.66s]
17:44:59  44 of 46 START table model test.jira__issue_enhanced............................ [RUN]
17:45:25  44 of 46 OK created table model test.jira__issue_enhanced....................... [SELECT in 25.88s]
17:45:25  45 of 46 START table model test.jira__project_enhanced.......................... [RUN]
17:45:27  45 of 46 OK created table model test.jira__project_enhanced..................... [SELECT in 1.93s]
17:45:27  46 of 46 START table model test.jira__user_enhanced............................. [RUN]
17:45:28  46 of 46 OK created table model test.jira__user_enhanced........................ [SELECT in 1.22s]
17:45:28
17:45:28  Finished running 17 view models, 23 table models, 6 incremental models in 423.05s.
17:45:28
17:45:28  Completed with 1 error and 0 warnings:
17:45:28
17:45:28  Database Error in model stg_jira__priority_tmp (models\tmp\stg_jira__priority_tmp.sql)
17:45:28    relation "jira.priority" does not exist
17:45:28    compiled SQL at target\run\jira_source\models\tmp\stg_jira__priority_tmp.sql
17:45:28
17:45:28  Done. PASS=44 WARN=0 ERROR=1 SKIP=1 TOTAL=46

Select which warehouse(s) were used to test the PR

[ ] BigQuery
[x] Redshift
[ ] Snowflake
[ ] Postgres
[ ] Databricks
[ ] Other (provide details below)

@everettttt thanks for opening this PR! Taking a look at the changes you have proposed, I feel this would be a valuable addition to the package.
There is one adjustment that will need to be made in order for the package to properly succeed with this variable. We will need to add the jira_using_priorities config logic to our source models:

stg_jira__priority_tmp
stg_jira__priority

Once the config logic is added to these models to be disabled with the jira_using_priorities: false then we will be good to go! Let me know if you would be open to creating a PR on our source package. If not, I am happy to tackle that update 😄

Let me know if you would be open to creating a PR on our source package. If not, I am happy to tackle that update

I'll do it.

Thanks so much @everettttt! Feel free to tag me in the PR and I will be sure to review it as soon as possible once it is open 😄

Thanks for the update @everettttt! 2 weeks will be perfect. There haven't been any other requests at the moment for this to be addressed asap.  So that timeline is great. Thanks again 😄

There is one adjustment that will need to be made in order for the package to properly succeed with this variable. We will need to add the jira_using_priorities config logic to our source models:

Submitted a PR to fivetran/dbt_jira_source.

Conflicts resolved, I hope. Added myself as a contributor to the changelog.


[FSDE-11826] Migrate Marketing icon component to new Vue documentation

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-266/1/. :white_check_mark:

You can check this PRs instance in https://a6e7b08208f34212e4ab2ef8f625f2f1ff8709f7-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-266-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-266/2/. :white_check_mark:

You can check this PRs instance in https://743337585e0474189572206086164909c07f124b-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-266-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-266/4/. :white_check_mark:

You can check this PRs instance in https://cb97ac43e9f4742f054dc4385520f97bb11c7944-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-266-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-266/5/. :x:

The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-266/7/. :x:

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-266/8/. :white_check_mark:

You can check this PRs instance in https://f89c22f676622839a4eb882ed29d8dc15efab23a-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-266-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-266/9/. :white_check_mark:

You can check this PRs instance in https://f552a9c3623c0fe0398512e2ad95362e6e01b2d9-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-266-ux-chi.kubeodc-test.corp.intranet/ (internal)


initTokenClient never calls call back.

I'm trying to use this new auth method and nothing seems to work.
Summary
no callback is fired during auth.
Browser(s)/Version(s)
Chrome latest
Expected Behavior
a call back
Actual Behavior
no call back
Steps to Reproduce
This is my code
client = google.accounts.oauth2.initTokenClient({
client_id: CLIENT_ID,
scope: 'https://www.googleapis.com/auth/spreadsheets.readonly',
callback: (tokenResponse) => {
access_token = tokenResponse.access_token;
gapi.client.setApiKey(API_KEY);
gapi.load('client', test() );
		  },
	})

I can alert the function   google.accounts.oauth2.initTokenClient  and it has loaded.  but nothing is running in the call back function

@ulao  did you ever find a workaround for this? having the same issue. can get the sign in popup to work just fine, but once it closes, the callback is not invoked.

For people struggling with this issue, it seems that Google wants your site to either be http, or https with a real (not self signed) certificate.  I can't find any documentation that points to this requirement, but I tried changing my https (self signed cert) over to http, and the callback is now firing as expected.

In my case, it doesn't fire callback because of Header set Cross-Origin-Opener-Policy "same-origin".

What worked for me was adding an error_callback. It helped me to understand why my callback wasn't being called.


Remove mypy testing

Since there are basically no objections to #48, here is a PR to implement it.
The motivator for me is that I'll need numpy for array types and mypy chokes on it.
Fixes #48

For good measure, could we also get rid of every # type: ignore comment and every call to cast(...)?

Done.


change some instances of bit to record to avoid confusion

This PR doesn't change any logic or functionality. It just contains some cases of bit changed to record that I made while debugging statusChan logic in the pdk.

There are a few tests failing:
./client_it_test.go:762:177: undefined: importBitsFunction
./client_it_test.go:780:163: undefined: importBitsFunction
./client_it_test.go:1605:38: undefined: importBitsFunction

client_it_test.go is compiled only when tags=integration flag is given, e.g., with make test-all.


Build a testing interface that doesn't require patching the test subject

RIght now, the suggested way to test configurable classes looks like this:
require "dry/configurable/test_interface"

# this is your module/class that extended by Dry::Configurable
module AwesomeModule
  enable_test_interface
end

before(:all) { AwesomeModule.reset_config }
# or
before(:each) { AwesomeModule.reset_config }

I don't like this approach for several reasons:

It requires me to add some code to my configurable class
It makes my code less deterministic as it's different in every environment
I just don't like using reset and before/after hooks

I suggest an interface that accepts a block, updates the config, then brings it back as it was.
Examples
around do |example|
  stub_configurable(described_class, value_one: 1, nested_value: { key: :value }) do
    example.run
  end
end

If the param syntax is too complex, we can break it down to something like this:
around do |example|
  stub_configurable(described_class) do |configurable|
    configurable.config.value_one = 1
    configurable.config.nested_value.key = :value

    example.run
  end
end

or just like this:
around do |example|
  stub_configurable(described_class) do
    described_class.config.value_one = 1
    described_class.config.nested_value.key = :value

    example.run
  end
end

Resources
N/A

I suggest an interface that accepts a block, updates the config, then brings it back as it was.

that's literally what the test interface does, see:
     def reset_config
        @config = config.pristine
      end

You can do it in around hook too:
around do |example|
  example.run
  described_class.reset_config
end

It could be extracted to an rspec-specific helper too, and provide stub_configurable, although internally it would do the same thing as reset_config, so I'm not sure what would be the point?

oh and btw you can just have this:
def stub_configurable(configurable)
  yield(configurable)
  example.run
  configurable.config.update(configurable.config.pristine.to_h)
end

no extra methods required

I'm gonna close this as there was no follow-up for a while now and it doesn't seem to be a priority.


[1.12] Update Argo CD notes with webhook labels

Description
https://github.com/kyverno/kyverno/pull/9015 adds a webhook labels key primarily intended for Argo CD users. Add this to the Notes for ArgoCD Users section.
Slack discussion
No response

For the reasons outlined in https://github.com/kyverno/kyverno/issues/9551, there are still users who will be unable to guarantee the removal of the webhooks with the new label value.
Namely those who use ArgoCD's annotation tracking mode.


Add support for image pullsecret and installing the CRD - helm chart

Hello,
I wonder if it would be possible to add functionality to the helm chart so that:

provide a image pullsecret (you already allow to provide a custom repo in the values, but if a pullsecret is required there's no option).
install the CRD

Thanks for your time..

@hawksight At least the CRD installation can be optimized. At the moment, CRDs are applied as manifests by HELM.
There is an option to put CRD definitions into a special subdirectory crds. This allows the user to skip the CRD installation using HELM's command line flag. In addition to that, HELM will not fail if the CRDs are already available.
This can be the case if you install all CRDs for your cluster manually before installing HELM chart releases.
A possible use case is the Terraform Kubernetes Provider which requires that supported CRDs must be available before execution.
AFAICS, moving the CRD definition to the crds directory should be enough.
Ref.: https://helm.sh/docs/chart_best_practices/custom_resource_definitions/#method-1-let-helm-do-it-for-you

I came here looking for a way to install the Bundle CRD separately from the trust-manager chart. I want to make trust-manager a subchart dependency of my application, but Helm will not install the subchart first to satisfy the CRD requirement of my chart, so I need to peel off the /crds in advance, then install my chart which depends on trust-manager. This is how it works with cert-manager.

Thanks @bephinix & @qrkourier for the notes. Just taking a look at #102 it seems that the CRDs are now optional through the values options, see here. Released in v0.4.0
So the CRDs are now installed automatically for a default helm installation, but can be disabled. That seems like it resolves the initial issue's request.
I don't think it's exactly the way that the helm docs suggest, but it is similar to cert-manager's configuration.
So an install without CRDs can be applied with:
# Assuming repo is added and up to date
helm template -n cert-manager jetstack/trust-manager --set crds.enabled=false

And applying the CRDs manually can be done with:
k apply -f https://raw.githubusercontent.com/cert-manager/trust-manager/v0.4.0/deploy/crds/trust.cert-manager.io_bundles.yaml

Does that help your use case @qrkourier with the sub chart or not? If it doesn't I'd suggest we open a separate issue for that use case.

That worked around it for me! Thanks so much.

I think this issue can be closed. The support for image pull secrets was introduced in https://github.com/cert-manager/trust-manager/pull/15. For the CRDs, cert-manager projects have implemented another approach for Helm: https://cert-manager.io/docs/installation/helm/#helm-installation. That Helm lacks proper support for CRDs is well-known, and I think the cert-manager approach is by far the least evil solution to this problem.

Closing as per @erikgb 's comment - thanks all!


interfaces, aliases on lo0 should get configured at bootup

[x] Redmine Issue: https://redmine.pfsense.org/issues/8393
[x] Ready for review

@PiBa-NL thanks for the quick fix!
I committed a slightly different patch as I noted that my last commit was wrong.
The checks that I added already exists in interface_ipalias_configure(), so I just copied them to interface_carp_configure(), which allowed me to reduce some duplicate code.


Set URI source version numbers dynamically to simplify maintenance

Replace hardcoded version numbers embedded in source URIs with associated WASDK version numbers.

/azp run


Added instrumentationScope to Logger and LogRecord

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#127  👈
#126
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @evanlauer1 and the rest of your teammates on  Graphite