custom attribute panicked when using it in a member of a workspace

When using hs_bindgen macro in a member of a workspace, it will raise error
message: fail to read content of `hsbindgen.toml` configuration file
          n.b. you have to run the command `cargo-cabal` to generate it: Os { code: 2, kind: NotFound, message: "No such file or directory" }

At this time, the current dir is project root, but hsbindgen.toml is generated in member dir. It cause toml::config() failed to find hsbindgen.toml.
Following is a reproduced project
|- Corgo.toml
|- binding-haskell
 |- Cargo.toml
 |- hsbindgen.toml
 |- binding-haskell.cabal
 |- Setup.lhs
 |- src
  |- ...

./Cargo.toml
[workspace]
members = ["binding-haskell"]

[workspace.package]
...

At this project, toml::config() will try finding ./hsbindgen.toml, rather than ./binding-haskell/hsbindgen.toml.

This issue seems to be linked to https://github.com/yvan-sraka/antlion/issues/1! Thank you very much for the bug report. I will investigate it and get back to you shortly :)

Thank you for responding. It seems that they are 2 different issues. I add an empty [workspace] manually in the sandbox's Cargo.toml, which successfully fix https://github.com/yvan-sraka/antlion/issues/1 temporarily. However, custom attribute still panicked.

In this pull request, https://github.com/yvan-sraka/hs-bindgen-attribute/pull/3/files#diff-1492d610b0587c015f48aac6fff2fee1fcc7310f2c5ef01d6c178332ebfda682R14-R18, I introduced a HSBINDGEN_CONFIG environment variable that can be set by users. This approach allows users to specify a path for the hsbindgen.toml config file. However, another potential method is to utilize the CARGO_MANIFEST_DIR https://doc.rust-lang.org/cargo/reference/environment-variables.html environment variable, which inherently points to the directory of the Cargo.toml manifest.
The issue at hand is that you want to place the hsbindgen.toml file in the module directory that uses the binding generation, rather than the root directory of the Cargo workspace. While a CARGO_MANIFEST_DIR-like approach seems cleaner, it might not cater to this specific need as it points to the workspace root, and I've not found yet a non-hacky way of doing it …

Maybe we need to wait for https://github.com/rust-lang/cargo/issues/3946 to finish.
It imports a new environment variable CARGO_WORKSPACE_DIR, which points to workspace root.

Thank you for your pointers. It's a bit unclear to me, reading the cargo documentation, how CARGO_MANIFEST_DIR should behave if CARGO_WORKSPACE_DIR is introduced.
From what I understand so far, CARGO_MANIFEST_DIR refers to the directory of the current crate, and could serve as the default value of HSBINDGEN_CONFIG (the location for the hsbindgen.toml file). Is that in line with what you need in your use case?
I'm also uncertain if these environment variables might be accessible only in a build.rs script. If so, it would require a workaround to export the crate directory path as a constant.
I will update my PR and run some tests to clarify this. If you already have a sample repository, that would be very helpful :)

Thank you! CARGO_MANIFEST_DIR meets my needs. It works well about hsbindgen.toml.
However, there is a new bug. Generated haskell source files will try writing in root dir rather than CARGO_MANIFEST_DIR. Maybe we should also use CARGO_MANIFEST_DIR here.
https://github.com/yvan-sraka/hs-bindgen-attribute/blob/ce0897aecb0d86177446130f1ce70f11ba8a58ef/src/lib.rs#L51-L54

Thank you for your feedback! I've updated my PR based on your suggestions :) I also decided to remove the option of setting HSBINDGEN_CONFIG_DIR through an environment variable, as I couldn't really identify a use case that would justify this feature. Let me know if you think there's anything else that needs fixing before I hit the merge button :D


Move remaining interactions into styled pages -- breadcrumbs and
image and links if appropriate

My account needs a breadcrumb menu and the title "Actions" above the actions section.

There are some other UX changes that will probably make that last request unnecessary.

closing then


[GUI] Template name empty: the text was not translated

The text was not translated into Portuguese:

Steps to reproduce the problem:

Click "Novo modelo"
Click "Salvar"

Affected Version: 58.2-20190321

Test OK.

Tested on Version: 62.3-20190603


Add frozen_string_literal: true

I used memory_profiler to check where rubyXL was using a lot of memory, and fixed it.
Added frozen_string_literal: true to lib/ files.
Testing seems to be fine, but depending on how users use the library, it may have an impact.
Result

write xlsx

https://github.com/ooooooo-q/rubyxl_memory_usage/blob/main/operate.rb#L8

read xlsx

https://github.com/ooooooo-q/rubyxl_memory_usage/blob/main/operate.rb#L42

rubyXL 3.4.20 (with Ruby 3.1.0)

write file

Total allocated: 16.41 MB (335760 objects)
Total retained:  6.58 kB (128 objects)

read file

Total allocated: 24.26 MB (340069 objects)
Total retained:  6.23 kB (57 objects)

frozen_string_literal

write file

Total allocated: 15.56 MB (314304 objects)
Total retained:  6.58 kB (128 objects)

read file

Total allocated: 24.02 MB (334013 objects)
Total retained:  6.23 kB (57 objects)

I do not believe these savings are significant. Besides, recent ruby automatically freezes literals (which caused issue fixed by 076ccdae048423bcb1bf31a459c5a1374378c20e)

I seem to remember that automatically freezes literals in ruby3 has been abandoned, but I may be mistaken.
https://bugs.ruby-lang.org/issues/11473#note-53


Why can't it be extended into an iOS App?

I don't have deep knowledge in native development and I'm curious why it can't be extended for iOS also. Are there some architecture problems?

Hi ! It's simply that I don't own a Mac computer, and developping for IOS requires a Mac computer. That's it.

@loloof64 I see, I want to use your library for my pet project and I really want to make it work on iOS also. If I have some sucess on this issue I will let you know. Thank you!

Thank you for your interest in my project, but it is unlikely that it is ported to IOS. Meanwhile, if you or if you know someone which can extends it with a Mac computer, I'll be very fine with that.


.start (offset) doesn't work?

I tried using Address.record_limit(n).start(address), but with my own models and no matter what is passed to .start() the records would always be returned from the same position. FYI I'm using a specific hash key, email, and not the default id one.
.record_limit() & scan_limit() seem to be working fine, just that the offset is never applied.
(this using dynamodb local but I imagine it doesn't matter - just pointing it out in case that could change something)
On the other hand, using the same exact local dynamodb instance & table, same credentials, issuing the command directly from from the official sdk works as expected:
 client.scan(
          {
            table_name: "thetable_name",
            limit: 2,
            select: "ALL_ATTRIBUTES",
            consistent_read: false,
            exclusive_start_key: {
              "email" =><EMAIL_ADDRESS>
            }
          })

Will result in 2 records from the first record with that key
Removing exclusive_start_key will result in the 2 first records in the table, and so on.
I tried looking at the code but not really sure where the chaining of the methods is happening?
If somebody can point me out to where I could dig it I could work on a PR
ps:
I also noticed that start expects a Dynamoid Document? But shouldn't it expect an arbitrary value and then map it to whatever is the defined key in the document?

@richardhsu
So I have got this to work with a few changes - but in fact I don't seem to understand how it even works and passes tests targeting the function.
In dynamoid/criteria/chain.rb you can see that:
def scan_opts
        opts = {}
        opts[:record_limit] = @record_limit if @record_limit
        opts[:scan_limit] = @scan_limit if @scan_limit
        opts[:batch_size] = @batch_size if @batch_size
        opts[:next_token] = start_key if @start
        opts[:consistent_read] = true if @consistent_read
        opts
  end

Basically it creates a key `next_token`, from the `start_key` method. `start_key` method expects a `dynamoid record` to be passed to it, from which it then calls the `hash_key` method (or `range` depending on table configs)  and then assembles something like this:

<EMAIL_ADDRESS>
So if I call `User.start(a_user_record)`, that's the options that are being sent over and read in `aws_sdk_v2.rb` (the adapter), on the `scan` method, which isn't reading that `next_token` key any way (While most of AWS services use next_token to paginate results, dynamodb doesn't from what I gather).

My solution is very simple, it's to allow passing a hash instead of a record, it's one line more on `chain.rb`, and then two lines in `aws_sdk_v2.rb`, if a hash is passed into `.start()` it sets one more option as `exclusive_start_key` which gets picked over in the plugin adapter and included in the request. It respects all previous tests, and allows the plugin adapter to still use the `exclusive_start_key` in subsequent queries if `last_evaluated_key` is present and it needs to fetch more records.

I was going to rewrite the `next_token` and change the `start_key` method but it broke 7 tests - although I'm not sure what they're testing since start doesn't work with this simple case.

I can write a small paragraph in the readme and push the changes if this is a PR you would like to merge. It's minimal the changes (3 lines) but they do work and are backwards compatible with whatever.

It sounds reasonable.  Would like to get input from others, as I don't have an implementation to test this on right now.

@mnussbaumer this sounds reasonable, I'm not sure which tests broke originally so cannot speak to what they are testing but please feel free to open a PR and we can review it. But I'm guessing the tests are targeting queries over scans. If this is not the case, we'll need to update the tests suite so please let us know which tests are in question. Finally this does show we're lacking coverage for scan in case of a start.
Now for the changes, at least for my use cases, I rarely have a start without holding onto a particular record since likely due to some kind of scan or querying with pagination. But I can see just having it as a hash of data.
I think that scan not utilizing next_token is just the fact that the improvement was never made to scan. Please make sure in your PR that your update of the code has it pass as next_token for consistency when passing the opts to the scan in aws_sdk_adapter code.
Although the way you describe your solution, we will want to add documentation that if you are passing the hash as the start then you need to be sure you are passing a proper exclusive_start_key that matches the appropriate composite key for the table or index, otherwise the query/scan will fail. Whereas with record passing, the chain module will build the composite key correctly based on the table/index being used.
@mnussbaumer thanks :) Looking forward to the PR!

@richardhsu
So yes, I agree - I ran into this because I needed to present paginated records, without query (meaning just show them all) but paginated to not put too much strain on the request. After toying a bit more with it I think that the best would be to have a different method of assembling the start_key for scans specifically:
Something like this:
# ~/lib/dynamoid/criteria/chain.rb
def scan_opts
        opts = {}
        opts[:record_limit] = @record_limit if @record_limit
        opts[:scan_limit] = @scan_limit if @scan_limit
        opts[:batch_size] = @batch_size if @batch_size
        # we removed the :next_token line for this one
        opts[:exclusive_start_key] = scan_start_key if @start
        opts[:consistent_read] = true if @consistent_read
        opts
 end

# we added this method
def scan_start_key
        hash_key = @hash_key || source.hash_key
        range_key = @range_key || source.range_key
        key = {}
        key[hash_key] = @start.send(hash_key) if @start.send(hash_key)
        key[range_key] = @start.send(range_key) if @start.send(range_key)
        key
end

# ~/lib/dynamoid/adapter_plugin/aws_sdk_v2.rb

def scan(table_name, scan_hash = {}, select_opts = {})
        request = { table_name: table_name }
        request[:consistent_read] = true if select_opts.delete(:consistent_read)

        # Deal with various limits and batching
        record_limit = select_opts.delete(:record_limit)
        scan_limit = select_opts.delete(:scan_limit)
        batch_size = select_opts.delete(:batch_size)
        exclusive_start_key = select_opts.delete(:exclusive_start_key)

        request_limit = [record_limit, scan_limit, batch_size].compact.min
        request[:limit] = request_limit if request_limit

        # this was added
        request[:exclusive_start_key] = exclusive_start_key if exclusive_start_key

       # ... remaining stuff
end

This keeps exactly the same semantics as of now, doesn't introduce any new way of querying. I ran the tests and it doesn't break anything, I would write tests to ensure that it's working, and I double checked with the existing tests and indeed if we start on a scan it will not offset results.
The other way would be as I suggested earlier with the option to pass a hash to the .start() method.
So in:
# ~/lib/dynamoid/criteria/chain.rb
def scan_opts
        opts = {}
        opts[:record_limit] = @record_limit if @record_limit
        opts[:scan_limit] = @scan_limit if @scan_limit
        opts[:batch_size] = @batch_size if @batch_size
        opts[:exclusive_start_key] = @start if @start && @start.is_a?(Hash)
        opts[:consistent_read] = true if @consistent_read
        opts
 end

But in this case it would probably require us to write some warning in case you passed a record to it, since you would expect it to just work if you did so, or add the other method as outlined in the first solution, which then begs the question of why adding this second syntax instead of keeping the same one...
I think the first one is the way to go, if you agree then I'll work on the tests and open a PR

@richardhsu in fact I just noticed that we don't even need to change the aws_sdk_v2.rb plugin file with the first solution as it creates the right fields before passing it to the plugin

@richardhsu It wouldn't break query because query will still use the regular start_key method and that indeed seems to work when it's querie's case.
Although I just looked into the adapter's query method and what it is doing is changing the next_token key, into an exclusive_start_key one by doing this:
opts.delete(:next_token).tap do |token|
          break unless token
          q[:exclusive_start_key] = {
            hk  => token[:hash_key_element],
            rng => token[:range_key_element]
          }
          # For secondary indices the start key must contain the indices composite key
          # but also the table's composite keys
          q[:exclusive_start_key][table.hash_key] = token[:table_hash_key_element] if token[:table_hash_key_element]
          q[:exclusive_start_key][table.range_key] = token[:table_range_key_element] if token[:table_range_key_element]
        end

Which seems to just duplicate the logic of the start_key method in chain.rb. So perhaps the best way is to make start_key assemble correctly exclusive_start_key from the beginning, and then in both the adapter's query and scan removed the superfluous translation into this key by just getting it from the opts.
This would simplify the adapter (as both scan & query start will only require the exclusive_start_key to be there - instead of doing more transformations) and the logic for translating the record passed into .start() will be totally on the chain.rb module.
What do you think?

@richardhsu  Perhaps it's just better if I write the PR so you can actually see the changes and test it on your end? I think this last option I mentioned is actually the way to go but if I run into any problem I will write something else

@mnussbaumer That sounds good and I agree, I like the idea we consolidate it so chain builds the correct exclusive_start_key and then passes it down and query and scan just pull it without any extra logic as that'd simplify the logic of the adapter and other places can use it more consistently with how DynamoDB queries are built.

Looks like the issue solved here https://github.com/Dynamoid/Dynamoid/pull/229


Let keyword in queries does not work as described

This issues is about this page: https://docs.microsoft.com/en-us/azure/azure-monitor/log-query/datetime-operations
I'm trying to use variables in my queries using the let keyword but it give me the following error:
'where' operator: Failed to resolve scalar expression named 'startTime'

If issue persists, please open a support ticket.

Request id: 01ae5f8e-1dad-4b15-ac26-6defc12da2cd

This is the query I'm trying to run on my Application Insights logs:
let startTime = todatetime("2020-04-24T05:00:00Z");

exceptions
| where timestamp between(startTime .. datetime(2020-04-28T12:33:00Z))
| project timestamp, operation_Id, message, type, name, problemId, application_Version
| order by timestamp asc

When I hardcode the startTime just like the endTime in this example it works.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 199d3a41-f8bc-6da2-7b96-f47cdafbe887
Version Independent ID: 79ad40d7-25e3-12d2-ddca-e82e9e46399b
Content: Working with date time values in Azure Monitor log queries - Azure Monitor
Content Source: articles/azure-monitor/log-query/datetime-operations.md
Service: azure-monitor
Sub-service: logs
GitHub Login: @bwren
Microsoft Alias: bwren

@wilgert Thanks for the Feedback.
Can you please share the document url that you are referring.

@wilgert I believe you are not selecting the first line of the query while running it i.e., I was able to reproduce your issue as shown below. Observe the cursor hasn't selected the first line of the query.

However, as shown below, if you select the whole query including the first line and then you don't see any error and we does get the output on running it.

Hope this helps!

Wow, I did not know you have to select the query to run it. The ui does not make this clear at all. But thanks for helping me out!

Closing this issue for now. If there are further questions or feedback regarding referred Azure documentation then please let us know so that we will gladly continue the discussion.


chore(deps): update to Vite 4

Quick Checklist

[X] I have read the contributing guidelines
[ ] I have written new tests, as applicable (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] I have added a changeset, if applicable

What kind of change does this PR introduce? Dependency update

What is the new behavior (if this is a feature change)? N/A

Does this PR introduce a breaking change? No

Other information:

Unless something is wrong on my side, I still get the "Cannot find package 'imagetools-core' " with vite 4 and vite-imagetools 4.0.12


Add EMI Calculator

I want to work on this issue under JWOC

Please describe a more what you want to implement.

Want to add a classic EMI (Equated Monthly Installment) calculator which will take three params. principle amount, rate of interest, and time period for total repayment. And will result in the amount which will be required every month.

@TuhinBanerjee31 Go for it.


Added recurse switch

Allows for a deeper file structure while still pulling all the ps1 files correctly

Thanks for the pull request!
While we don't have hard rules on how to organize public/private folders, most projects I've seen keep it simple and avoid subfolders. It was already a bit of a struggle to get folks to use src/public and src/private, and many preferred just keeping everything in one place.
If you can point me to a couple of projects that use subfolders for PS1 files, I'm happy to approve this. Let me know what you think!

Thank you for understanding. Recurse is a little tricky, although its within in scope of public/private folder, its still good idea to limit to specific folder at root level to keep things under control.
I will keep this in my own tracker and if i come across any project then I include in the module. Thanks again.

I did close it also because I found a few issues that needed to be resolved.  The recurse switch needs to be added in a few additional areas that I missed which caused some problems.

Needs to be added here so that the manifest has the correct functions names added to the 'FunctionsToExport' collection
$PubFunctionFiles = Get-ChildItem -Recurse -Path $data.PublicDir -Filter *.ps1

Needs to be added here so that all the private functions are grabbed properly
$files = Get-ChildItem -Recurse -Path $data.PrivateDir -Filter *.ps1 -ErrorAction SilentlyContinue


Improve toggle comment function in script editor

Improved the toggle comment feature to automatically adjust the selection area & cursor position when toggling comments on a section of code.
Should close #22214.

CC @Paulb23

I tweaked the behaviour slightly to include the delimiter on the first line in the selection, if the selection starts from column 0. Also updated cursor accordingly. Let me know if anything else should be changed.

Thanks!


[Enhancement] Add Faces/Vertices to Existing Models

I figure this is a rather big request, but would it be possible to implement a way to add new vertices/faces to existing models/Worldspawn as part of the face editor?
Some Goldsrc maps have missing faces on complex geometry due to being assigned to Worldspawn. For example some hanging rockets in hl1 (c2a5d).

A feature for adding faces/verts to Worldspawn could greatly help fix these problems.

@marigi64 you can use manually verts manipulation with Face editor widget to edit near faces, or add model with needed forms and place them.


Still no any plan to support the new docker swarm mode?

As title indicated, I think currently the new docker swarm mode is already stable enough, registrator still doesn't have any plan to support that?
Basically run registrator on each node is not the  right way to go, 2 or at most 3 on manager node is more than enough.
@josegonzalez @progrium

As far as I know, gliderlabs folks do not use docker swarm - new or old - in production, so there isn't any reason for us to write any code to handle it.
At the risk of sounding cliche, pull requests welcome.


WIP: capability to generate non Opt* struct for parameters with default value

@tdakkota @ernado @shadowspore
https://github.com/ogen-go/ogen/issues/966
I saw some reactions on the issue and I've got some time now so diving into this.
This PR includes only a minimal draft changes to discuss the implementation strategy, once the direction is consolidated I'm happy to do the rest of the work.
Just want a quick feedback at this point about if it's looking good or there's any other better ways. Honestly, haven't given much thought nor read the whole codebase yet so there could be some limitation in this strategy.
Naming of the variables and types are also draft, will pick better ones if there's any along the way.

@tdakkota PTAL
We need to decide how we going to implement this feature


Mek oxygen should work with Galacticraft Oxygen

Minecraft version:
Unabridged or Abridged version:
Issue Description:
Steps to Reproduce:
Crash report or log (uploaded to gist.github.com or pastebin.com):

Unconfirmed

They already work


Use JSON.stringify to display arrays in explore

Adds JSON.stringify to fix the display of arrays.
Since the above was already used for ndarrays and lists, this commit
combines the logic of all 3 types.

Fixes #1921.

Awesome thanks!


UX: Update and add manual links on the dashboard

Description
We need to update the link for the manual on the dashboard and add a new link for the manual.
Implementation

[ ] First of all, please update the existing manual link (the third slider) to https://manual.grid.tf/
[ ] Please add a link to the manual beneath the Playground link on the left-hand sidebar

Duplicate to: https://github.com/threefoldtech/info_grid/issues/73

Hey any clear update on this one? Hard to see what the progress is.

Hello @samtaggart, yeah I just paused the work here as I mentioned above until I fix the threefold connect issue

OK got it – I saw that it went from In Progress to Verification back to In Progress back to Accepted, so wasn't sure what the latest was.
This issue should be easy to execute, no? It's just a matter of adding a link and changing a link. Maybe we can see if someone else can do it, if you are busy on the ThreeFold Connect issue?

@samtaggart
Should be updated in https://github.com/threefoldtech/tfgrid-sdk-ts/pull/243

Thank you 🙏

@A-Harby
Updated in https://github.com/threefoldtech/tfgrid-sdk-ts/pull/367

@A-Harby
In the development and staging modes, the image and all static files are successfully loaded, as demonstrated in the following example: https://www2.manual.grid.tf/.
However, in the production mode, there seems to be an issue with the image not loading correctly. This discrepancy suggests that there might be a deployment issue specific to the production environment.

Hi all – Anything I can help with? When will this go live?

@A-Harby In the development and staging modes, the image and all static files are successfully loaded, as demonstrated in the following example: https://www2.manual.grid.tf/.

@Mahmoud-Emad in your comment manual link is https://www2.manual.grid.tf/ while the one use in the dashboard sidebar link is https://manual.grid.tf/ could be that this is different causing the error?

@samtaggart
Hey Sam,
I wanted to bring to your attention an issue with the currently deployed version of the manual. The main page image is not loading correctly. We are aware of this problem and will work on fixing it.
@A-Harby
Yes, Harby, I understand that the links I mentioned are different. The link I provided was specifically for the staging environment, where everything is loading correctly. The reason for mentioning the error is to highlight that the production instance is experiencing this issue.

@all, the issue should be fixed now according to  https://github.com/threefoldtech/tf_operations/issues/1705

Niceee, so when will this come alive on production?

Hi friends just checking to see when this will come live on production.


Issues in creating a new karma plugin.

Hi I'm trying to create an karma plugin. Looks like I'm missing something down the line.
My package.json is
{
  "name": "testing",
  "version": "0.0.1",
  "description": "Test",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "keywords": [
    "grooscript",
    "karma-grooscript"
  ],
  "devDependencies": {
    "karma": "^0.12.36",
    "grooscript" : "1.1.1"
  }
}

and my index.js is:
var path = require('path');

var pattern = function(file) {
    return {pattern: file, included: true, served: true, watched: false};
};

var framework = function(files) {
    files.unshift(pattern(path.join(__dirname, 'adapter.js')));
    files.unshift(pattern(path.resolve(require.resolve('grooscript'), '../grooscript.js')));
};

framework.$inject = ['config.files'];
module.exports = {'framework:testing': ['factory', framework]};

and my adapter.js is:
var gs;
(function(window) {
    window.gs = window.gs;
})(window);

All these files reside in a parent directory something like this:
testing/
    index.js
    adapter.js
    package.json

And in order to test them, I created an sample karma project. I installed the above plugin in the sample karma project like this:
npm link ../testing

which does install it (could able to see under the node_module directory). Then in the karma config.js, I added testing as frameworks:
module.exports = function(config) {
  config.set({
    // base path, that will be used to resolve files and exclude
    basePath: '',

    frameworks: ['jasmine', 'dojo',"testing"] // <--- here

Once done, if I run the karma like:
karma start

I get an error like this:
/Users/user/programs/groovy/grooscript/esri-karma-tutorial/node_modules/karma/node_modules/di/lib/injector.js:9
      throw error('No provider for "' + name + '"!');
            ^
Error: No provider for "framework:testing"! (Resolving: framework:testing)
    at error (/Users/user/programs/groovy/grooscript/esri-karma-tutorial/node_modules/karma/node_modules/di/lib/injector.js:22:68)
    at Object.parent.get (/Users/user/programs/groovy/grooscript/esri-karma-tutorial/node_modules/karma/node_modules/di/lib/injector.js:9:13)
    at get (/Users/user/programs/groovy/grooscript/esri-karma-tutorial/node_modules/karma/node_modules/di/lib/injector.js:54:19)

where I'm making mistake?

@antoaravinth How look your full karma.conf.js file?
Thanks!

Here we go:
module.exports = function(config) {
  config.set({
    // base path, that will be used to resolve files and exclude
    basePath: '',

    frameworks: ['jasmine', 'dojo',"testing"],

    // list of files / patterns to load in the browser
    files: [
      'spec/main.js',

      // all the sources, tests
      {pattern: 'src/**/*.js', included: false},
      {pattern: 'spec/*.js', included: false}
    ],

    // uncomment the following for code coverage
    // preprocessors: {
    //   // source files, that you wanna generate coverage for
    //   // do not include tests or libraries
    //   // (these files will be instrumented by Istanbul)
    //   'src/**/*.js': ['coverage']
    // },

    // test results reporter to use
    // possible values: dots || progress
    reporters: [
      'dots'
      // uncomment the following line for code coverage
      // , 'coverage'
    ],

    // web server port
    port: 9876,

    // proxy for cross domain requests
    proxies:  {
      '/arcgis/': 'http://imagery.arcgisonline.com/arcgis/'
    },

    // cli runner port
    runnerPort: 9100,

    // enable / disable colors in the output (reporters and logs)
    colors: true,

    // level of logging
    // possible values: LOG_DISABLE || LOG_ERROR || LOG_WARN || LOG_INFO || LOG_DEBUG
    logLevel: config.LOG_INFO,

    // enable / disable watching file and executing tests whenever any file changes
    autoWatch: true,

    // Start these browsers, currently available:
    // - Chrome
    // - ChromeCanary
    // - Firefox
    // - Opera
    // - Safari
    // - PhantomJS
    // NOTE: you may need to first set it's path in an environment vairable, for example:
    // set FIREFOX_BIN="c:\Program Files (x86)\Mozilla Firefox\firefox.exe"
    // see: http://karma-runner.github.io/0.10/config/browsers.html
    browsers: [
      'Chrome'
      // add the name (from above) for each additional
      // browser you want to test below
      // , 'Firefox'
    ],

    // uncomment the following for coverage options
    // see: https://github.com/karma-runner/karma-coverage#options
    // coverageReporter: {
    //   type : 'text',
    //   dir: 'coverage/'
    // },

    // Continuous Integration mode
    // if true, it capture browsers, run tests and exit
    singleRun: false
  });
};

If you want to have a look at the complete karma project, I cloned it from here : https://github.com/tomwayson/esri-karma-tutorial

@antoaravinth and where located your plugin relate to this project?
karma by default look plugins in node_modules with prefix karma-

@maksimr : Thanks, looks like I named the module as testing and hence karma wasn't picking. Changing the name with prefix karma- works.
However I see some minor issue in the adapter.js :
(function(window) {
   console.log(window.gs)
    window.gs = window.gs;
})(window);

the console.log does print the window.gs to correct groovy script fn.
However if I do :
gs // or window.gs

in the console, I see its undefined. I'm getting confusion now. If it could print window.gs, why not I cant access it via console. Am I missing something here?

@antoaravinth it's strange gs should be defined, because in your index.js
grooscript load before adapter.js
var framework = function(files) {
    files.unshift(pattern(path.join(__dirname, 'adapter.js')));
    files.unshift(pattern(path.resolve(require.resolve('grooscript'), '../grooscript.js')));
};

You can try debug this behavior on debug.html(http://localhost:9876/debug.html) page.

@maksimr : Thanks for your help. However in the debug page, I could able to see gs defined. But not in the karma running context. I'm confused.
Any ideas, of why does this would happen?

I'm supsecting your code gets executed in the test iframe rather than the outside frame (which is where the default karma window console drops you in) so if you want to debug from that frame you can use the iframe context switcher in the devtools to drop into the iframe and there window.hs should be defined

Closing as answered.


captcha error

Cant get captcha: list index out of range
Cant get captcha: list index out of range

it's because cloudflare protection, i can't help with it

so the bot is broken/patched or is it because of my ip adress?


[Blackhole bringup] Run didt confirmed test

Running unit tests posted in https://github.com/tenstorrent/tt-metal/issues/8665
Currently runs two iterations then hits watcher assert due to bad noc alignment

Running unit tests posted in #8665
Currently runs two iterations then hits watcher assert due to bad noc alignment

Fix for this issue is in https://github.com/tenstorrent/tt-metal/pull/10357

Closing this because successfully able to run a didt target workload


[CSBindings] NFC: Refactor some of the repetitive uses of type variab…

…le in graph node

@swift-ci please smoke test

@swift-ci please smoke test macOS platform


Hunting ELK machine is not configuring with Kibana or eslastic stack

Issue
When running ad.py with --helk enabled the helk machine does not appear to be configured properly. When attempting to access the Kibana UI either with the internal IP from one of the machines on the network (tested with DC1) or from the external IP address getting a "connection refused" error message. After running into this message, I remoted into the velocihelk machine and confirmed that it is not configured with Kibana or any of the tools expected from the Hunting ELK repo / elastic stack. I ended up destroying that range and running the following process again just to confirm the issue.
$ python3 ad.py --admin admin --password Password1 --endpoints 1 --location eastus --helk

helk.tf

resource "azurerm_public_ip" "vh-external" {
  name                    = "vh-public-ip-${random_string.suffix.id}"
  location                = var.location
  resource_group_name = "${var.resource_group_name}-${random_string.suffix.id}"
  allocation_method       = "Static"
  idle_timeout_in_minutes = 30

  depends_on = [azurerm_resource_group.network]
}

resource "azurerm_network_interface" "vh-nic-int" {
  name                    = "vh-nic-int-${random_string.suffix.id}"
  location                = var.location
  resource_group_name = "${var.resource_group_name}-${random_string.suffix.id}"
  internal_dns_name_label = local.virtual_machine_name_helk

  ip_configuration {
    name                          = "primary"
    subnet_id                     = azurerm_subnet.siem_subnet-subnet.id
    private_ip_address_allocation = "Static"
    private_ip_address            = "<IP_ADDRESS>"
    public_ip_address_id          = azurerm_public_ip.vh-external.id
  }

  depends_on = [azurerm_resource_group.network]
}

locals {
  virtual_machine_name_helk = "velocihelk"
}

# Create (and display) an SSH key
resource "tls_private_key" "example_ssh" {
    algorithm = "RSA"
    rsa_bits = 4096
}

# Enable if you want to see the SSH key - It is written to a file
output "tls_private_key" {
  value = tls_private_key.example_ssh.private_key_pem
  sensitive = true
}

data "template_file" "linux-vm-cloud-init" {
  template = file("${path.module}/files/helk.sh.tpl")

  vars = {
   helk_ip = "<IP_ADDRESS>"
  }
}

resource "azurerm_linux_virtual_machine" "vh_vm" {
  name                          = local.virtual_machine_name_helk
  location                      = var.location
  resource_group_name = "${var.resource_group_name}-${random_string.suffix.id}"
  network_interface_ids         = [azurerm_network_interface.vh-nic-int.id]
  size                       = "Standard_D2s_v3"
  admin_username		= "helk"
  disable_password_authentication = true

  custom_data = base64encode(data.template_file.linux-vm-cloud-init.rendered)

  source_image_reference {
    publisher = "Canonical"
    offer     = "UbuntuServer"
    sku       = "18.04-LTS"
    version   = "latest"
  }

  os_disk {
    name              = "${local.virtual_machine_name_helk}-disk1"
    caching           = "ReadWrite"
    storage_account_type = "Premium_LRS"
    disk_size_gb	= 100
  }

  admin_ssh_key {
    username       = "helk"
    public_key     = tls_private_key.example_ssh.public_key_openssh
  }

  tags = {
    environment = "Velociraptor HELK Prod"
  }

  depends_on = [azurerm_resource_group.network]
}

# write public IP address of Linux host to file
resource "local_file" "hosts_cfg_velociraptor" {
    content = templatefile("${path.module}/templates/hosts.tpl",
        {
        ip = azurerm_public_ip.vh-external.ip_address
        huser = "helk"
        }
    )
    filename = "${path.module}/hosts.cfg"

}

# write ssh key to file
resource "local_file" "ssh_key" {
    content = tls_private_key.example_ssh.private_key_pem
    filename = "${path.module}/ssh_key.pem"
    file_permission = "0700"
}

resource "null_resource" "helk-scp-velociraptor-config" {

  provisioner "remote-exec" {
      inline = ["echo 'Hello World'"]

  connection {
    host     = azurerm_public_ip.vh-external.ip_address
    type     = "ssh"
    user     = "helk"
    private_key = tls_private_key.example_ssh.private_key_pem
    timeout  = "3m"
  }
}

provisioner "local-exec" {
  command = "scp -o StrictHostKeyChecking=no -i ${path.module}/ssh_key.pem helk@${azurerm_public_ip.vh-external.ip_address}:/home/helk/config.yaml ${path.module}/files/Velociraptor.config.yaml"
}
  depends_on = [azurerm_linux_virtual_machine.vh_vm]
}

Confirmed.  We are getting this.  Not enough available memory to run HELK once the VM sizes were switched over.  I'm going to bump up the HELK instance to 14 GB memory instead of 8 GB
[HELK-INSTALLATION-INFO] HELK hosted on a Linux box
[HELK-INSTALLATION-INFO] Available Memory: 7462 MBs
[HELK-INSTALLATION-INFO] You're using ubuntu version bionic

*****************************************************
*      HELK - Docker Compose Build Choices          *
*****************************************************

1. KAFKA + KSQL + ELK + NGNIX
2. KAFKA + KSQL + ELK + NGNIX + ELASTALERT
3. KAFKA + KSQL + ELK + NGNIX + SPARK + JUPYTER
4. KAFKA + KSQL + ELK + NGNIX + SPARK + JUPYTER + ELASTALERT

[HELK-INSTALLATION-INFO] HELK build set to 4
[HELK-INSTALLATION-INFO] Your available memory for HELK build option 4 is not enough.
[HELK-INSTALLATION-INFO] Minimum required for this build option is 8000 MBs.
[HELK-INSTALLATION-INFO] Please Select option 1 or re-run the script after assigning the correct amount of memory

I bumped the HELK instance size to Standard_D4s_v3 and  confirmed all services are working now and the installation is just fine.  This bumps memory up to 16 GB.  I've updated the cost estimate page as well.
Kibana now listening:
helk@velocihelk:~$ sudo netstat -tulpn | grep 443
tcp        0      0 <IP_ADDRESS>:443             <IP_ADDRESS>:*               LISTEN      8269/docker-proxy
tcp6       0      0 :::443                  :::*                    LISTEN      8277/docker-proxy
helk@velocihelk:~$

I've pushed the commit up @Johndpete316
I'll keep this open, let me know if you can confirm that it is now working for you and we can close it.
Thanks for reporting this!

Tested with a fresh environment and the installations worked fine.
Thanks again for the quick response, huge lifesaver!

No problem - Good Luck!


[Error View] Move Test Examples

Summary
Move from nightwatch dir to examples/test-examples dir

Should I leave them? I know the doc is deprecated

I'd leave them alone for now. I'd like to remove the packages entirely soon.


Improved Key Visualizer and Slow Queries

Feature Request
The current "Key Visualizer" looks like this:

And the "Slow Queries" page looks like this:

The key visualizer page is great for use by DBA's that focus on the complete system, but isn't great for developers that only focus on a specific database that is used for the (part of) the application that they are working on.
The slow query page has a dropdown to select one or more databases, the key visualizer page doesn't have this. The key visualizer allows you select a focus area with the "Select & Zoom" button.
As a developer I would want to focus on the schema I'm interested in without seeing data from other schemas that might be from other applications that I don't have influence over.
Improvement 1
Add a dropdown for database schema on the "Key Visualizer" page.
Improvement 2
Make the schema and table names on the "Key Visualizer" page clickable.

Improvement 3
Combine the key visualizer and slow query pages
This is a mock-up:

This is similar to what "Top SQL" shows:

But "Top SQL" shows CPU time, not hotspots etc. Note that "Top SQL" also doesn't let you focus on a single schema.

@dveeden Thank you for your suggestion. I think it's reasonable, we will design this scenario soon.


[WIP] Pulsar Functions worker configuration

@aahmed-se Right now it's not clear what's going to happen with the configuration (processContainerFactory, etc.). I think that needs to be determined before this can be finished.

Close this one since it is not active, and we will be on the new website after 2.1.0 release. so have to redo this work anyway.


Fixes incorrect file reference

This PR fixes an issue where the training script currently uses the test files for both the training and the test files.
Signed-off-by: Oleg S<EMAIL_ADDRESS>

The change looks good -- it'd be great to call out what the impact was.  At a quick glance, it seems like it could be as bad as we weren't actually using the generated data for training.  Is it that bad?  Is it something else?

@russellb Yeah that's the case, but I think this was a minor thing that was overlooked in #1471 so it hasn't made it into a release yet.

Could PyTorch training produces poor results consistenly be related to this problem? Please create a ticket to remind us, that we must write unit/functional for the code block.


FarmMgmt: grid 3 compliant flag

allow the user to upgrade to grid 3 pricing: in the update request you can send is_grid3_compliant param with True
https://github.com/threefoldtech/tfexplorer/pull/307/files
note: don't show the button if the farm is compliant with grid 3

verifying this

Verified
Branch
development
Commit
e23494b847e44ad8fce4add28c4c8cf88585b85f


How to set the character set value of the Content-Type response header

Hi! I started playing with Grapevine recently, but still couldn't figure out how to properly respond with UTF-8 characters.
For example, "Injeção" becomes "InjeÃ§Ã£o".
Among other things, I tried setting Response.ContentEncoding to Text.Encoding.UTF8, but nothing seemed to work.
What am I doing wrong?

The HttpResponse.ContentEncoding property is used in conjunction with the request output stream, and maps directly to the HttpListenerResponse.ContentEncoding property. The property is set to Encoding.UTF8 by Grapevine by default.
This property is not related to the Content-Encoding http response header, which is used to communicate content encoding to the client, and is most commonly used to indicated that the response body has been compressed.
Neither of these are related to the character set being used in the response body.
The changing of the text (which is only an issue in browsers, try with Postman and it doesn't happen) is because there is not currently a default value for the character set used in the response body. In future versions of Grapevine, a default will be provided to avoid this issue going forward.
Meanwhile, you can provide a value per response:
context.Response.ContentType = "text/plain; charset=UTF-8";

This updated will be in the next release.


GitHub Action Step output for coverage is an object not a string?

I have setup pytest with the following options:
https://github.com/jrwagz/cards-proj/blob/add-coverage-badge/pyproject.toml#L43
--cov-report html --cov-report xml:coverage.xml --cov=cards

And then I configured my actions as follows:
      - name: Publish Coverage Report as comment
        id: coverageComment
        if: ${{ matrix.os == 'ubuntu-latest' && matrix.python-version == '3.10' }}
        uses<EMAIL_ADDRESS>        with:
          pytest-xml-coverage-path: ./coverage.xml
          unique-id-for-comment: ${{ matrix.os }} ${{ matrix.python-version }}

https://github.com/jrwagz/cards-proj/blob/add-coverage-badge/.github/workflows/tests.yml#L32-L57
However, when I try get the coverage percentage as just a string, I get an object instead:
      - name: Check the output coverage
        if: ${{ matrix.os == 'ubuntu-latest' && matrix.python-version == '3.10' }}
        run: |
          echo "Coverage Percentage - ${{ steps.coverageComment.outputs.coverage }}"
          echo "Coverage Color - ${{ steps.coverageComment.outputs.color }}"

  echo "Coverage Percentage - {"name":"TOTAL","stmts":182,"miss":100,"cover":"45%"}"
  echo "Coverage Color - orange"

Am I doing something wrong?

In this same exact workflow, the comment created seemed to be correct:
https://github.com/jrwagz/cards-proj/commit/e16995f5160d049ab189fbce890144297fa6a312#commitcomment-93994345

The output coverage was not supported for pytest-xml-coverage-path, I added support for this and release a new version, which you can use:
- name: Pytest Coverage Comment
  uses: MishaKav/pytest-coverage-comment@main
  with:
    pytest-xml-coverage-path: ./coverage.xml

or use a specific version
- name: Pytest Coverage Comment
  uses<EMAIL_ADDRESS>  with:
    pytest-xml-coverage-path: ./coverage.xml

Fantastic work, thank you!


Make package:web_installers accessible from flutter/flutter

package:web_installers is our standard package for installing and manipulating webdrivers. However, the package only exists on Github. There's no way to add a dependency on it using flutter/flutter's standards means. Therefore some of the functionality is duplicated in flutter/flutter.
This is not currently blocking anything. It's more of a code health issue.
/cc @nturgut

superseded by #98552?


ncc_changes_rollback_cb not being called at startup if failed confirmed-commit is detected in the past

Version 2.1.36
In main.c the call tries restore previous confirmed commit
    /* Restore a previous confirmed commit if restore file exists */
    ncc_try_restore();

The code reads the meta file and looks at the timestamp and timeout.  If the timeout was in the past, the code calls
    VRB("Restoring a previous confirmed commit.");
    ncc_commit_timeout_schedule(new_timeout);

but new_timeout will be 0 in this case.   ncc_commit_timeout_schedule has this code
    if (timer_settime(timer_id, 0, &its, NULL) == -1) {
        ERR("Could not set time in timer for confirmed commit rollback (%s).", strerror(errno));
        return SR_ERR_SYS;
    }

The its structure will be all 0's.   From the linux timer_settime manual page we see

If new_value->it_value specifies a zero value
(i.e., both subfields are zero), then the timer is disarmed.

The timer_settimer will not set a timer but rather the timer will be disarmed or in this case, never armed.   This leaves the previous confirmed commit around forever and then causes issues where an subsequent confirmed commit will fail.

Right, should work now.


feat: use for each for ram principles (rebased against current HEAD)

Description
This is a rebase of PR #16 against master

Motivation and Context

Breaking Changes

This is a breaking change if the a RAM Principle has been passed to the module, otherwise it's a no-op.  If you've shared the TGW with this module it will attempt to delete and recreate all the aws_ram_principal_association resources. This would require the recipient of the share to re-accept the shared RAM principle.
basically aws_ram_principal_association.this["0"] will be delete and recreated as aws_ram_principal_association.this["xxxxxxxxxxxx"]  this can be mitigated by manually using terraform state mv SOURCE DESTINATION to migrate.
How Has This Been Tested?
Tested by sharing a RAM principle between accounts and confirming that the plan/apply with the patch delete and recreate the resource

[ ] I have tested and validated these changes using one or more of the provided examples/* projects

still an issue, please merge

Bump


⚠ gorzdrav.org has degraded performance

In 24698bc, gorzdrav.org (https://gorzdrav.org) experienced degraded performance:

HTTP code: 200
Response time: 1693 ms

Resolved: gorzdrav.org performance has improved in b5da36a after 5 minutes.


MarkdownMagic script updates

Description of the Change

Quoted pathname used in exec, allowing for embedded spaces
Changed codefence language to 'text'
Saved markdownTOC output to variable prior to output

Alternate Designs
NA
Why should this be in core?
NA
Benefits
Code can now run on Windows if pathname contains spaces.
Possible Drawbacks
None to knowledge.
Applicable issues
semver-patch

Coverage remained the same at 91.687% when pulling 062e4b7bd3ebaa505f78e607805df6d9b7f61bc1 on plroebuck/markdown-magic into b27bc60224552b74852161405d15765b9fb59ef2 on master.

@plroebuck 	merge at will


Add warning about missing Microsoft.DBforPostgreSQL resource provider for private DNS zones

The Microsoft.DBforPostgreSQL resource provider needs to be registered in the subscription, even if the subscription only hosts the private DNS zone for PostgreSQL.
This cost me three days of work to find out – my deployments just kept timing out after 2 hours, with an error message just telling me to try again…

@GennadNY
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Closing this PR because the content set has moved. Please open a new PR in azure-databases-docs if the changes still apply.


Support $startIndex param on Pos method

Description
The Pos method used in SilverStripe template loops supports adjusting the starting number of the position index (see silverstripe-framework/src/View/SSViewer_BasicIteratorSupport.php). It would be good to add feature parity for those wishing to use zero based indexes ;)
Additional context or points of discussion
No response
Validations

[X] You intend to implement the feature yourself
[X] You have read the contributing guide
[X] You strongly believe this feature should be in core, rather than being its own community module
[X] You have checked for existing issues or pull requests related to this feature (and didn't find any)

Hiya.
As mentioned in your original PR, this can only be done in a major release. Feel free to open a new pull request targeting the 6 branch.


Video Player Android Application

Title and Issue number
Video Player Android Application
Issue Number #3895
Close #3895
Checklist:

[X] I have mentioned the issue number in my Pull Request.
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have created a helpful and easy to understand README.md

I have attached Some video of  an APP:-
https://github.com/pranjay-poddar/Dev-Geeks/assets/130477475/d0e856f7-37de-4745-be2b-7f478999e04e
@MohitGupta121 Sir kindly review the project and approved the PR

@MohitGupta121 Sir kindly review the project and approved the PR

@MohitGupta121 @TusharKesarwani @pranjay-poddar Sir kindly review the project


backend/assistants_web: Move Default Agent usage to backend

In the previous assistants_web, a lot of logic was hardcoded to include a BASE_AGENT variable.
I've now renamed this to reference a default agent, and moved this to a config in the backend. Currently this lives as as hardcoded set of values rather than a DB migration of sorts because I wanted to maintain the flexibility of being able to modify the default agent without having to modify a migration or touch the DB.
This removes several frontend constants previously used, and updates several client calls.
I've also fixed some issues with sorting recent agents.
AI Description

This PR introduces a new default agent, replacing the previous base agent. The default agent is defined in src/backend/config/default_agent.py and is used throughout the codebase.
Changes:

The src/backend/config/default_agent.py file is added, defining the default agent with its ID, name, description, tools, and other attributes.
The src/backend/main.py file is modified to remove the JSONResponse import and the validation_exception_handler function, which handled exceptions and returned a JSON response.
The src/backend/routers/agent.py file is updated to include the default agent ID and the get_default_agent function from the new src/backend/config/default_agent.py file. The create_agent function now uses Depends(get_context) instead of Depends(get_context()). The list_agents function appends the default agent to the list of agents, and the get_agent_by_id function checks if the agent ID is the default agent ID before fetching the agent.
The src/backend/schemas/agent.py file is modified to change the organization_id field from Optional[str] = Field(exclude=True) to Optional[str] = None.
The src/backend/tests/unit/routers/test_agent.py file is updated to import the default agent ID and the get_default_agent function from the new src/backend/config/default_agent.py file. A new function, filter_default_agent, is added to filter out the default agent from a list of agents. The test_list_agents_empty function is renamed to test_list_agents_empty_returns_default_agent and now checks that the default agent is returned. The test_list_agents, test_list_organization_agents, test_list_private_agents, test_list_public_agents, and test_list_agents_with_pagination functions now use the filter_default_agent function to filter out the default agent from the list of agents.
The src/backend/tests/unit/routers/test_main.py file is modified to remove the test_global_exception_handler function, which tested the global exception handler.
The src/interfaces/assistants_web/src/app/(main)/(chat)/c/[conversationId]/page.tsx and src/interfaces/assistants_web/src/app/(main)/(chat)/page.tsx files are updated to replace references to BASE_AGENT with DEFAULT_AGENT_ID and to import the getCohereServerClient function.
The src/interfaces/assistants_web/src/app/(main)/discover/DiscoverAgentCard.tsx file is modified to replace references to checkIsBaseAgent with checkIsDefaultAgent and to use the isDefaultAgent variable instead of isBaseAgent.
The src/interfaces/assistants_web/src/app/(main)/layout.tsx file is updated to replace references to DEFAULT_AGENT_TOOLS with BACKGROUND_TOOLS and to import the getCohereServerClient function.
The src/interfaces/assistants_web/src/app/(main)/new/CreateAgent.tsx file is modified to replace references to DEFAULT_AGENT_TOOLS with BACKGROUND_TOOLS.
The src/interfaces/assistants_web/src/cohere-client/client.ts file is updated to import the DEFAULT_AGENT_ID constant and to add a new function, getDefaultAgent, which fetches the default agent by its ID.
The src/interfaces/assistants_web/src/cohere-client/generated/schemas.gen.ts file is modified to add an organization_id field to the AgentPublic type, allowing it to be either a string or null.
The src/interfaces/assistants_web/src/cohere-client/generated/types.gen.ts file is updated to add an optional organization_id field to the AgentPublic type and to remove the display_name and description fields from the Tool type.
The src/interfaces/assistants_web/src/components/AgentSettingsForm/ToolsStep.tsx file is modified to remove the AGENT_SETTINGS_TOOLS constant and to update the availableTools variable to filter tools based on their name, availability, and visibility.
The src/interfaces/assistants_web/src/components/AgentSettingsForm/index.tsx file is updated to remove a comment about the metadata of the read_file and search_file tools.
The src/interfaces/assistants_web/src/components/Agents/AgentLogo.tsx file is modified to replace references to checkIsBaseAgent with checkIsDefaultAgent and

Codecov Report
Attention: Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.26%. Comparing base (ccf41ea) to head (396e749).

Files with missing lines
Patch %
Lines

src/backend/routers/agent.py
80.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
+ Coverage   79.25%   79.26%   +0.01%
==========================================
  Files         250      251       +1
  Lines       10637    10651      +14
==========================================
+ Hits         8430     8443      +13
- Misses       2207     2208       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Student Reviewing Scenario

When a Student completes a scenario, they should be able to go back and review their playthrough. To do this, they would click the review button on the scenario card of the scenario that want to review, which is located in the completed scenarios section on the dashboard. When the scenario loads in, they will be able to access all the pages in accordance with their previous play through. They should not be able to make changes to any actions taken, stakeholders talked to, nor reflections answered. They should be able to see all the information in the gathered information sidebar, and navigate with the stepper as well.

We were not able to integrate all the endpoints having to do with completing and updating progress completed on scenarios. When a student revisits a scenario, as of now, the pages are not loaded in correctly.


0.7.13 to 0.7.25 fails with Invalid configuration for 'external_url' retrieved from environment variable EXTERNAL_URL

Describe the bug
A clear and concise description of what the bug is.
was running 0.7.13 and attempted to run 0.7.25. and it failed with fails with Invalid configuration for 'external_url' retrieved from environment variable EXTERNAL_URL
To Reproduce
Steps to reproduce the behavior:
i did a docker pull firezone/firezone:latest which is 0.7.25 according to the id
irezone/firezone   0.7.25    81e3718a4b35   13 days ago   82.1MB
firezone/firezone   latest    81e3718a4b35   13 days ago   82.1MB
caddy               2         4120819d2095   6 weeks ago   46MB
postgres            15        680aba37fd0f   6 weeks ago   379MB
firezone/firezone   0.7.13    914cd0f95350   7 weeks ago   81.8MB

did a docker compose up and got the following error
Expected behavior
A clear and concise description of what you expected to happen.
just works
Screenshots / Logs
If applicable, add screenshots and log traces to help debug your problem with any sensitive data removed.
firezone-manual-firezone-1  | ** (RuntimeError) Invalid configuration for 'external_url' retrieved from environment variable EXTERNAL_URL.
firezone-manual-firezone-1  |
firezone-manual-firezone-1  | Errors:
firezone-manual-firezone-1  |
firezone-manual-firezone-1  |  - `"vpn.example.tld"`: does not contain a scheme or a host
firezone-manual-firezone-1  |     lib/fz_http/config/errors.ex:10: FzHttp.Config.Errors.raise_error!/1
firezone-manual-firezone-1  |     /app/releases/0.7.25/runtime.exs:17: (file)
firezone-manual-firezone-1  |     (elixir 1.14.3) src/elixir.erl:309: anonymous fn/4 in :elixir.eval_external_handler/1
firezone-manual-firezone-1  |     (stdlib 4.2) erl_eval.erl:748: :erl_eval.do_apply/7
firezone-manual-firezone-1  |     (stdlib 4.2) erl_eval.erl:492: :erl_eval.expr/6
firezone-manual-firezone-1  |     (stdlib 4.2) erl_eval.erl:136: :erl_eval.exprs/6
firezone-manual-firezone-1  |     (elixir 1.14.3) src/elixir.erl:294: :elixir.eval_forms/4
firezone-manual-firezone-1  |     (elixir 1.14.3) lib/module/parallel_checker.ex:110: Module.ParallelChecker.verify/1

Platform (please complete the following information):

Firezone Version [e.g. 0.7.12] 0.7.25
OS: [e.g. Linux] linux
Distro: [e.g. Ubuntu 18.04] 18.04
Kernel version: [e.g. 5.10.11] 5.4.0-1099-aws
Deployment method: [e.g. Docker / Omnibus / Source] docker

Additional context
Add any other context about the problem here.

Hello @marafa-sugarcrm, this is intentional. Now we validate the configuration and do not start the service when it's invalid, the logged error explains what is wrong:
firezone-manual-firezone-1  | ** (RuntimeError) Invalid configuration for 'external_url' retrieved from environment variable EXTERNAL_URL.
firezone-manual-firezone-1  |
firezone-manual-firezone-1  | Errors:
firezone-manual-firezone-1  |
firezone-manual-firezone-1  |  - `"vpn.example.tld"`: does not contain a scheme or a host


wishlist: an official docker image of pliers

There is a Dockerfile so it should be easy to build/provide an image for pliers from docker hub.  I think it is just a matter of flipping a switch.
Ideally there should then be tagged versions which correspond to releases (when the next release comes)
ATM there is already https://hub.docker.com/r/kaczmarj/pliers/tags since I guess @kaczmarj just builds for all repos he has and he has a clone of pliers ;-)

may be no official docker image because of some restrictive licenses of installed/bundled/downloaded components e.g. from
Step 9/11 : RUN python -m pliers.support.download
 ---> Running in 850656a5a419
[nltk_data] Downloading package punkt to /home/pliers/nltk_data...
[nltk_data]   Unzipping tokenizers/punkt.zip.
[nltk_data] Downloading package maxent_treebank_pos_tagger to
[nltk_data]     /home/pliers/nltk_data...
[nltk_data]   Unzipping taggers/maxent_treebank_pos_tagger.zip.
[nltk_data] Downloading package averaged_perceptron_tagger to
[nltk_data]     /home/pliers/nltk_data...
[nltk_data]   Unzipping taggers/averaged_perceptron_tagger.zip.
[nltk_data] Downloading package vader_lexicon to
[nltk_data]     /home/pliers/nltk_data...

step?

ha - i guess i do tend to build docker images for the projects i fork..
i don't know which licenses these data use, but the data are here. maybe we can also forego this download step, if it would prevent us from making an official docker image.

oops, i meant to include the link to the data http://www.nltk.org/nltk_data/
we might also consider not downloading the data in the docker image, if the licenses are restrictive. the error message related to not having the data gives the command to get the data.


Fix deprecated import for Iterable

This PR fixes the way Iterable is imported. With this change, it will import it from collections.abc rather than collections (which emitted a deprecation warning).
Explanation:
Importing abstract base classes from collections instead of from collections.abc was deprecated starting in Python 3.3+, and in 3.8 it will stop working.  The "Astract Base Classes for Collections" module (collections.abc) was introduced in Python 3.3.  In previous Python versions, the ABC's were part of the collections module.
Note:
The deprecation warning was not displayed when running tests with tox because nosetests was swallowing the message.

Codecov Report

Merging #436 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   80.81%   80.81%
=======================================
  Files          23       23
  Lines        3941     3941
  Branches      458      458
=======================================
  Hits         3185     3185
  Misses        680      680
  Partials       76       76

Impacted Files
Coverage Δ

pywt/_utils.py
76.92% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6116b29...f4ea04d. Read the comment docs.

Merged, thanks @cgoldberg


BUG: Fixing errors

while compiling the pyseams using docker, I saw the following:

The version of fmt was still 9.0.0 in pyseams.

I changed it to 9.1.0.

One of the python binding was erroring out.

I commented it out for now, will fix it later.

The seams-core.wrap file was linked to the older version of code which lead to compilation problem

I changed it to the newer version of code.

Thanks @RuhiRG.


Version is not shown during flashing

See:

In the previous dialog, the "name" and the "version" were shown, in this dialog only the "name"
Previous dialog:

I did that on purpose. While installing, that information doesn’t matter anymore. Instead what matters is the progress.


Add ShowFullName property

Summary

Adds the ShowFullName property to be used by the mobile app the same way ShowEmailAddress is being used for the user profile view. ShowFullName property is being used to control whether or not to display the first_name and last_name in profile view based on the system console settings.
Tested on iOS simulator. First and last name fields are displayed/hidden as expected, just like the ShowEmailAddress property.
Ticket Link

Related to:

PR in mattermost-server #14189
PR in mattermost-mobile #4092

Checklist

[ ] Added or updated unit tests (required for all new features)
[ ] Has UI changes
[ ] Includes text changes and localization file updates

@shred86 this is adding the the property support in the Config type, but is it going to be used somewhere? If it is, where?
Also not sure if this setting is being applied anywhere as Maria pointed out in the server PR which means there is a chance that this is a legacy setting and no longer used?

It would be used in the spot I made changes to in the #4092 PR. Basically, we would just check to see if ShowFullName is set to true before displaying the first and last name fields.
I had to mess around with this for a bit to figure out what I assume this setting is for. I noticed without this setting, if I disabled the option for users to view full names in the user profile, they would still show up on the mobile app. The email address would be hidden as you would expect (which has a property ShowEmailAddress). However, that was for existing user profiles I’ve already viewed, because if I tried to view a different user profile I haven’t looked at yet, then the full name would no longer display. My assumption was that the user profile data is being cached somewhere on the mobile device and this setting is a way to hide the full name field.
I could be completely off here, but that was just based on trial and error. Do we know who implemented the ShowEmailAddress option?

It would be used in the spot I made changes to in the #4092 PR. Basically, we would just check to see if ShowFullName is set to true before displaying the first and last name fields.

Right but shouldn't that work be done in this same PR ?

Ideally, yeah. I would have liked to add it in that PR but figured it would be better to add it later since adding the ShowFullName property requires a server change and I thought it would be better to wait a few releases after #14189.
I'm not entirely sure how it works when you disable the show full name option from the system console but it seems like the change is immediate for profiles you haven't viewed yet and just takes a while to update for profiles you have viewed (I'm assuming because the data is cached and still available). Adding the ShowFullName property just seems to hide to immediately even if the data is cached (if that's in fact what's even happening).

@shred86 now that the server PR was merged, would you be completing this one ?

@enahum Yeah this one should be good to go just so the property is available. I can make another PR that adds the use of this property and just put a note that references this PR.

Just out of curiosity, why a different PR instead of having this one adding the setting + the use of it?

Good point, I can just add it here!

This should be good to go.

@migbot yes!

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/8029
https://circleci.com/gh/mattermost/mattermost-mobile/8027

Artifact links:
https://8029-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.apk
https://8027-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.ipa

@josephbaylon I just pulled the latest mattermost-server and ran this mobile app branch in iOS simulator and it seems to be working as expected. Is there any way to double check that server you're connecting to has the ShowFullName property implemented? I would imagine it does but I can't think of any reason why the first and last name fields would not be showing up.
As for the full name showing up under the avatar, this really needs to be fixed in the user_utils.ts. However, I'm not exactly sure how to get access to the ShowFullName property from the displayUsername function. I'm sure it's simple, I'm just a react newbie and haven't been working on these PRs in a while. If anyone has any pointers on that, it should be fairly easy to just add it as a condition before displaying the full name.

@josephbaylon I just pulled the latest mattermost-server and ran this mobile app branch in iOS simulator and it seems to be working as expected. Is there any way to double check that server you're connecting to has the ShowFullName property implemented? I would imagine it does but I can't think of any reason why the first and last name fields would not be showing up.
As for the full name showing up under the avatar, this really needs to be fixed in the user_utils.ts. However, I'm not exactly sure how to get access to the ShowFullName property from the displayUsername function. I'm sure it's simple, I'm just a react newbie and haven't been working on these PRs in a while. If anyone has any pointers on that, it should be fairly easy to just add it as a condition before displaying the full name.

@shred86 It looks like the server changes are only available on v5.26. I'll retest this later against that and let you know.


create exceptions type to support chained errors

This PR resolves #120 by adding a type which will serialize to https://docs.sentry.io/clientdev/interfaces/exception/ When creating a packet you can either include an Exceptions or an Exception type but not both.

an example gist of what can be supported with this type and the github.com/pkg/errors package is available here
Generally, this is very useful functionality to expose to support cases where multiple errors need to be returned with stack traces.

@mattrobenolt is it possible to merge this PR? or any additional feedback.

Sorry for the delay here. :) This looks good!


bugfix: fix incorrect getAnnotation about class and method

Ⅰ. Describe what this PR did
bug fix for getAnnotation
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #2617 into develop will decrease coverage by 0.14%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #2617      +/-   ##
=============================================
- Coverage      51.18%   51.03%   -0.15%
  Complexity      2806     2806
=============================================
  Files            554      554
  Lines          17772    17754      -18
  Branches        2099     2062      -37
=============================================
- Hits            9096     9061      -35
+ Misses          7819     7814       -5
- Partials         857      879      +22

Impacted Files
Coverage Δ
Complexity Δ

...ing/annotation/GlobalTransactionalInterceptor.java
9.21% <0.00%> (-0.13%)
2.00 <0.00> (ø)

...obuf/convertor/BranchRegisterRequestConvertor.java
90.47% <0.00%> (-9.53%)
3.00% <0.00%> (ø%)

...otobuf/convertor/BranchReportRequestConvertor.java
90.90% <0.00%> (-9.10%)
3.00% <0.00%> (ø%)

...obuf/convertor/BranchRollbackRequestConvertor.java
92.00% <0.00%> (-8.00%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalBeginResponseConvertor.java
92.59% <0.00%> (-7.41%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalCommitRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalStatusRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...obuf/convertor/GlobalRollbackRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...protobuf/convertor/RegisterTMRequestConvertor.java
94.73% <0.00%> (-5.27%)
3.00% <0.00%> (ø%)

...protobuf/convertor/RegisterRMRequestConvertor.java
90.47% <0.00%> (-4.77%)
3.00% <0.00%> (ø%)

... and 20 more

add test case

add test case

ok

@zjinlei PTAL

@zjinlei @slievrly PTAL

toString，hashcode these methods also take distributed transactions?

测试了一下，注解加在类上、方法上、类及方法上混用、嵌套调用都没问题

toString，hashcode these methods also take distributed transactions?

PTAL@slievrly

add hashCode and equals ... test case?

Codecov Report

Merging #2617 into develop will decrease coverage by 0.52%.
The diff coverage is 23.52%.

@@              Coverage Diff              @@
##             develop    #2617      +/-   ##
=============================================
- Coverage      50.95%   50.42%   -0.53%
- Complexity      2830     2851      +21
=============================================
  Files            563      564       +1
  Lines          18043    18366     +323
  Branches        2136     2187      +51
=============================================
+ Hits            9193     9261      +68
- Misses          7980     8208     +228
- Partials         870      897      +27

Impacted Files
Coverage Δ
Complexity Δ

...ing/annotation/GlobalTransactionalInterceptor.java
10.40% <15.38%> (+1.59%)
4.00 <2.00> (+2.00)

...ta/spring/annotation/GlobalTransactionScanner.java
51.51% <50.00%> (-0.57%)
17.00 <0.00> (ø)

...obuf/convertor/BranchRegisterRequestConvertor.java
90.47% <0.00%> (-9.53%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalBeginResponseConvertor.java
92.59% <0.00%> (-7.41%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalCommitRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalStatusRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...obuf/convertor/GlobalRollbackRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...protobuf/convertor/RegisterTMRequestConvertor.java
94.73% <0.00%> (-5.27%)
3.00% <0.00%> (ø%)

...protobuf/convertor/RegisterRMRequestConvertor.java
90.47% <0.00%> (-4.77%)
3.00% <0.00%> (ø%)

...otobuf/convertor/BranchReportRequestConvertor.java
95.45% <0.00%> (-4.55%)
3.00% <0.00%> (ø%)

... and 22 more


Run tests in true cross-domain mode

Maybe using <IP_ADDRESS> rather than localhost?

Got this working great with latest refactoring. Only catch now, as far as I can tell, is -- how do we share window.__coverage__?

Closing this for now as no way around the coverage issue. :(


[TW#14610] Malformed mgmt. frames in promiscuous mode (IDFGH-5718)

I'm working on a project using the promiscuous mode to sniff and save WiFi traffic.
I noticed that all captured managment frames have 4 bytes at the end that don't make any sense.
That leads to malformed packets.

I'm using the Arduino IDE, however @Staubgeborener was able to reproduce the same issue using the ESP-IDF: https://gist.github.com/Staubgeborener/6977a6851510a296eabde0b9148f4658
I can provide more examples if necessary.
I bypassed this issue in my project with a simple if-statement: if(type == WIFI_PKT_MGMT) len -= 4;. So it doesn't save the last 4 bytes, if it's a managment frame.

Isn't the last 4 bytes of any wifi packet the FCS?
Or are you saying the packet length for management frames are including 4 extra bytes beyond the FCS?

@SoftwareSamurai Those 4 bytes are appended after the checksum.

@spacehuhn and @Staubgeborener, have you been able to confirm @liuzfesp's prediction about frames aving CRC errors or is the same happening with CRC-successful frames? How did you solve the issue in your final code?

@drws  Hi, can you please let us know what specific issue you met?

I only used basic promiscuous mode functions and was still researching more advanced topics when I stumbled upon this report. I thought it would be interesting to hear feedback from OP or other participants.

I can’t say anything more about it, @drws . This issue was opened a few years ago and I'm currently neither working with the esp mcu nor with the promiscuous mode, so I can't tell you how it turned out back then. Maybe @spacehuhn can tell you something else.

I was able to fix the malformed packet error by implementing what @liuzfesp said. Not sure what else to tell you. ¯_(ツ)_/¯

Thank you all for your input :)


ORC-1021: Add -fno-omit-frame-pointer in DEBUG and RELWITHDEBINFO builds

What changes were proposed in this pull request?

This PR adds -fno-omit-frame-pointer gcc option in DEBUG and RELWITHDEBINFO builds, which helps to generate stacktrace in debugging and profiling. Refs:
https://www.brendangregg.com/perf.html#StackTraces
https://issues.apache.org/jira/browse/IMPALA-4132
Why are the changes needed?

Described as above.
How was this patch tested?

Built in ubuntu16.04 with gcc 8.4.0.

+1 LGTM

I backported this to branch-1.7.


[Bugs] Build OK but run error in ArchLinux

As titled.
When I finished building,I run the app,but I got errors:
$ ./note-mark
Error occurred in handler for 'getNotes': [Error: EACCES: permission denied, mkdir '/home/zxp-endeavouros\NoteMark'] {
  errno: -13,
  code: 'EACCES',
  syscall: 'mkdir',
  path: '/home/zxp-endeavouros\\NoteMark'
}

I don't think such a directory structure should appear in all Linux Distributions.

BTW,the icon of the app seems like the electron's?


Microflow button doesn't work

Using the microflow button property in the widget doesn't seem to work. It actually breaks the widget with an error about $ is not a function.
I tried working around this, but I cannot seem to get the widget to work with the microflow button. Any chance you could fix this?

Hi @Mcpoowl I will look into your issue ASAP.
Thanks flagging this problem.


Fix CursorRow::get_text

Update fetch_size for the Indicator::NoTotal case in CursorRow::get_text.

Pull Request Test Coverage Report for Build cf865b0fbeeb172bc20d4d2c3f4f8ae0334294e5-PR-290

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 83.42%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

odbc-api/src/cursor.rs
0
1
0.0%

Totals

Change from base Build 69b0c007b8df7c1b01b77be780c721939f2aaf76:
-0.02%

Covered Lines:
4166

Relevant Lines:
4994

💛  - Coveralls

Hi @blankname ,
thanks for the Bugfix. Any hint how to reproduce this? What DB did it occur for you, in which value type. I prefer to have a reproducing test before merging a Bugfix. From what I can see though, the code really has a Bug and you did fix it, so thanks.
Best, Markus

Hi @pacman82,
I encountered the bug when running the following against db2 for ibm i (using unixodbc):
match conn.execute("values QSYS2.JOB_NAME", ()) {
  Ok(Some(mut cursor)) => {
    if let Ok(Some(mut row)) = cursor.next_row() {
      let mut buf = Vec::new();
      row.get_text(1, &mut buf);
    }
  },
    _ => panic!(),
}

QSYS2.JOB_NAME is a built-in global variable (varchar(28)).
I also tried selecting a column (varchar(128)) view and that didn't trigger the bug.
It's possible? that the column and the global variable have different character encodings.
I wonder if it would be possible to reproduce this with a database that's used in the test suite by selecting a large object column (ex. Blob).
I can probably take a look next weekend.

I wonder if it would be possible to reproduce this with a database that's used in the test suite by selecting a large object column (ex. Blob).

Explored that option here: https://github.com/pacman82/odbc-api/blob/400282bba8d575bffac2f748f855c0c7458c29fb/odbc-api/tests/integration.rs#L2263
Next I'll try fetching a fixed size column with a buffer too small.

Since the obvious attempts to reproduce fail, I'll merge this as is. If you have some insight for me how much effort it would be to add db2 to my test suite please tell me. Is there a docker image I could directly use in CI?

On second thought, I think the logic for fetch_size must be different.
let old_len = buf.len();
// Use an exponential strategy for increasing buffer size.
buf.resize(old_len * 2, 0);
let buf_extend = &mut buf[(old_len - 1)..];
fetch_size = buf_extend.len();
target = VarCharSliceMut::from_buffer(buf_extend, Indicator::Null);
self.get_data(col_or_param_num, &mut target)?;

releasing odbc-api 0.50.3. Contains a fix. Hopefully 😓

@blankname Please let me know if the issue is resolved for you, and if you have any tipps how to reproduce.
Cheers, Markus

@pacman82
There's a db2 for Unix, Linux, Windows, but I believe it requires a license.
I did some source searching of ODBC drivers for databases that are already used in this repo's tests to try to find cases where they will return SQL_NO_TOTAL.
Postgres:
https://github.com/iress/psqlodbc/blob/4bfff48941cc81f7a1b26fc7cae253fdfb30f040/pgtypes.c#L972
MariaDB:
https://github.com/mariadb-corporation/mariadb-connector-odbc/search?q=SQL_NO_TOTAL
I plan on trying to reproduce the issue this weekend.

On second thought, I think the logic for fetch_size must be different.

The new logic you implemented is a cleaner solution.
To make sure I understand what was wrong if there was a bug in my original fix: Will buf_extend.len() ever be different from old_len + 1 since the buffer is being doubled (and we're overwriting the existing null at the end of the buffer)?

To make sure I understand what was wrong if there was a bug in my original fix

Nope, do not think you had a Bug. Just was to tired to see that it is the same thing. 😓  One thing I did though is to apply the same fix to the binary get_data as well.

I plan on trying to reproduce the issue this weekend.

If you can come up with a way to cover this code via integration testing, I would be thankful. I still have not figured out how to make the coverage information publicly available (not the percentage, but what lines of code precisly). If you can tell me, I'd be happy to do set the necessary permissions. That might be helpful if working on a branch.
Of course a good old printf debugging might also do the trick.
Again much thank you very much for reporting and analyising the issue and sorry you had to experience a Bug!
Best, Markus

Tested with Postgres BYTEA, but did not cover NO_TOTAL: https://github.com/pacman82/odbc-api/blob/d267163aa113e58d2668cb56fbdf0f411c4cf4e9/odbc-api/tests/integration.rs#L2256

I wasn't able to figure out a way to get either MariaDB or PostgreSQL to return SQL_NO_TOTAL.
I tried building both drivers with debug info and stepping through using GDB, but SQLGetData seems like it doesn't get the length using any of the functions I was seeing return SQL_NO_TOTAL.
Thanks for the library and your commitment to maintaining good code coverage!

Yeah, I could of course restructure the code to have a lower level unit test, but so far the intergration tests have been very good at defeating my bias of what I thought the drivers would do. Thanks for opening a Bug report and providing a fix.
FYI: If you do not need to stream really large individual field values, you get much better performance (often two orders of magnitude) if you bind buffers to the cursor instead of using get_data.
Best, Markus


Another try to make rust-criu work with crates.io

@rst0git The previous change did not work with crates.io. Maybe this approach is better.

No, still not perfect.

@rst0git PTAL, this seems to be finally something that makes sense and is accepted by crates.io.

Hmm, the test seems to fail when building locally without GENERATE_PROTOBUF=1 GENERATE_TEST_PROCESS=1:
$ GENERATE_PROTOBUF=1 GENERATE_TEST_PROCESS=1 cargo build
$ sudo ./target/debug/rust-criu-test `which criu`
Version from CRIU found in $PATH: 31800
Version from /usr/sbin/criu: 31800
Dumping PID 375151
Restoring PID 375151
Cleaning up

$ sudo git clean -dfx
$ cargo build
$ sudo ./target/debug/rust-criu-test `which criu`
Version from CRIU found in $PATH: 31800
Version from /usr/sbin/criu: 31800
thread 'main' panicked at 'Starting test process failed (Os {
    code: 2,
    kind: NotFound,
    message: "No such file or directory",
})', src/bin.rs:34:19
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

That is expected as the test process is not created by build.rs without the right environment variable.
To upload something to crates.io nothing should be created outside of OUT_DIR.
Should I add a line to the readme about how to test?

Should I add a line to the readme about how to test?

Yes, it might be useful for future reference.


Updating the Azure Terraform Container to include VS Code Task Configuration for Terraform Commands

Updating the existing Azure Terraform Container to do the following:

Include VS Code Task Configuration for Terraform Commands:

init
validate
fmt
plan
apply
destory

Add a test project to test the definition

Update the readme to include steps on how to test the definition with the sample project and simplify the steps

@Chuxel - Please let us know if you need any additional information to get this PR reviewed?

@cmendible another PR I'd love your opinion on - looks good to me but wanted to run it by you :)

@2percentsilk LGTM now...


Fix programId detection

Super cool, that you fixed the problem so quickly regarding broken downloads frm tv.nrk.no. The single episode download now works as before 👍
The -a switch still doesn't work though. Applying the -a switch gives no output (worked before):
test@HOMELAB:/mnt/volume0/nrk-tv-downloader# ./nrk-tv-downloader.sh -a http://tv.nrksuper.no/serie/peppa-gris/MSUI44003409/sesong-1/episode-35 test@HOMELAB:/mnt/volume0/nrk-tv-downloader#

Yeah, the changes were bigger than i thought. This PR fixes mostly tv.nrk, and i will look at  the rest later today.
@greddost


No font awesome icons in firefox

Hi i cannot load icons in firefox. Screenshot atteched. Doesnt work on server and on local
https://www.dropbox.com/s/2g7ae1kkvxijkpa/Zrzut ekranu 2014-12-12 19.33.20.png?dl=0

same issue.
could not install bower :(


Hide empty fields

Empty fields shouldn't be visible : packaging, categories, traces, additives etc often display "null" or an empty field, they should be hidden instead.
In the nutrition page, an indication should be present saying a given nutritional info is not indicated, or if they aren't available for the product (when "Nutrition facts are not specified on the product") instead of "nullnull" everywhere.

is it a duplicate of #86 ?
Do you have an exemple of a product that can be used for to test the empty fields ?


Add smooth cursor animation?

Please consider adding cursor's animation like that in vscode(provided as an option), neovide or Microsoft Word(2013 and later). This feature is intended to enhance cursor visibility while typing, and also adds to aesthetics. I tried replicating that elegant nonlinear animation myself but ended up realizing it is beyond my capabilities.
Though this feature is not so widely discussed on the internet and  that this feature is sometimes controversial, I do hope someone could realize this feature in a md editor and, more hopefully, in Swift.

Thank you for your meticulousness. It took me a long time to discover this small detail.
However, considering that users will hardly notice this feature at the moment and it will take some time to implement in Swift, I plan not to do it for now.


Finish up preparation for v3 of site

Signed-off-by: Tristan Partin<EMAIL_ADDRESS>

meson setup build
ninja -C build
ninja -C build deploy
ninja -C build serve

Still defaults to 2.x. Not sure how to change that.

I really really really don't like how GitHub Pages works.

meson setup build
ninja -C build
ninja -C build deploy
ninja -C build serve

Still defaults to 2.x. Not sure how to change that.

mike set-default 3.x

I really really really don't like how GitHub Pages works.

Don't know why, it's easy, and nothing to manage.  But that's outside the scope of this PR....

What is replacing the requirements.txt?

What is replacing the requirements.txt?

Why does something need to replace it?

What is replacing the requirements.txt?

Why does something need to replace it?

Sure, the alternative is to specify what to install in README.md.

Can build docs at this point. Nits: 1) "ninja -C build serve" has versions 2.x and 1.x rather than 3.x and 2.x, and 2) "ninja -C build deploy" does not issue a "mike set-default 3.x", however this can be done manually before pushing the gh-pages branch, along with "mike delete 1.x" to remove that version.

Did you run deploy before serve? Try deleting the gh-pages branch before serving. There is nothing I can change with regard to what is in your local gh-pages branch.

I forgot to run deploy before serve, my bad.  Now when I serve I see all three versions (1.x, 2.x, 3.x) with 2.x being the default.  This is actually what I would expect given that 1) we need to manually remove 1.x via "mike delete 1.x", and 2) after "ninja -C build deploy" we need to manually run "mike set-default 3.x".

I think we should actually keep this open until HSE 3.0 is tagged. That way I can change the hse-3 wrap file.

I think we should actually keep this open until HSE 3.0 is tagged. That way I can change the hse-3 wrap file.

Makes sense.


[bug] Add jump-in buttons to common inputs

Would be better to have jump-in buttons as separate inputs

Closed by 6433bb5568255588d8e48bb3d4f2299e4f34b678


We don't want BigCommerce

Hello, we are only working on a prototype project as a team. That's why we don't want to use BigCommerce. How can we remove BigCommerce from the project? I would be glad if you could help.
Note: I cloned the project and changed .env.template to .env.local.
Thanks

I think it would be a good start to state what do you want from this project? Let's say if you don't want BigCommerce, do you want another eCommerce platform or just the UI of the app?

@wtLau Let's assume I would keep the UI of the app but implement my own functionality for the eCommerce platform. That would mean that I'm fetching the data from my Mongo database, display the products to the users and I would have Stripe integration for the payment. What would be the general steps to accomplish that?

@JusticeBringer - you might like to fork https://github.com/vendure-ecommerce/vendure as that is an ecommerce node based backend and according to the author "Vendure supports multiple databases. Currently it is tested with MySQL/MariaDB, PostgreSQL, SQLite and SQL.js. Since Vendure uses TypeORM to manage data access, it can theoretically also work with CockroachDB, Microsoft SQL Server and MongoDB, though these are as yet untested"
It should give you a large leg up on the sort of project you're describing.
That project also has a front-end in the works or you could hybrid your solution using vercel/commerce in the front and vendure-ecommerce in the back.

Hello! We're about to ship the agnostic branch and we will ship with Shopify and more providers. Thank you!


Qeom refactoring

Fix #769 #415 #52
Summary
Proposition for a modification to QEOM internals to :

Make the code easier to follow
Improve the potential for parallelism
Improve the performances of the classical calculations by using a custom treatment of the tapering.

A new functionality as also added to compute excited state properties and transition amplitudes of arbitrary observables
The typical interface to use it would be the following:
from qiskit.algorithms.optimizers import COBYLA
from qiskit.primitives import Estimator

from qiskit_nature.units import DistanceUnit
from qiskit_nature.second_q.algorithms import VQEUCCFactory, GroundStateEigensolver
from qiskit_nature.second_q.algorithms.excited_states_solvers import QEOM
from qiskit_nature.second_q.circuit.library import UCCSD
from qiskit_nature.second_q.drivers import PySCFDriver
from qiskit_nature.second_q.mappers import QubitConverter
from qiskit_nature.second_q.mappers import JordanWignerMapper

import numpy as np

optimizer = COBYLA(maxiter=500,disp=False)
qubit_converter = QubitConverter(JordanWignerMapper(), z2symmetry_reduction=None, two_qubit_reduction=False)

new_driver = PySCFDriver(
    atom="H 0 0 0; H 0 0 1.735",
    basis="sto3g",
    charge=0,
    spin=0,
    unit=DistanceUnit.ANGSTROM,
)
new_es_problem = new_driver.run()
hamiltonian_op, _ = new_es_problem.second_q_ops()
aux_ops = {'hamiltonian':hamiltonian_op}

# Qeom results
vqe_solver = VQEUCCFactory(Estimator(), UCCSD(), optimizer)
me_gsc = GroundStateEigensolver(qubit_converter, vqe_solver)
qeom_solver = QEOM(me_gsc, estimator=Estimator(), excitations='sd', aux_eval_rules="all")
results_qeom = qeom_solver.solve(new_es_problem, aux_operators=aux_ops)

print("Aux QEOM")
for aux_op_eval in results_qeom.aux_operators_evaluated:
    print(aux_op_eval)

print("Transi QEOM")
for indice, value in results_qeom.raw_result.transition_amplitudes.items():
    print(indice, value)

Details and comments
The following guides details some of the changes that are proposed
QEOM_refactoring-3.pdf

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: Anthony-Gandon:x: Anthony GandonAnthony Gandon seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: Anthony-Gandon:x: Anthony GandonAnthony Gandon seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


sbt configuration for scala 2.10 and scala 2.11

On http://www.scalatest.org/download, instead of
libraryDependencies += "org.scalatest" % "scalatest_2.11" % "2.2.1" % "test"

the documentation should be:
libraryDependencies += "org.scalatest" %% "scalatest" % "2.2.1" % "test"

Actually at one point the sbt powers that be told me to stop using the %%, but then later I think theybacktracked. I believe it was when Scala started ensuring binary compatibility of point releases. I think at first they may have thought they would need to deprecate %% but then figured out how to make it know whether to use 3 or 2 version numbers. I'll ask again and switch back to %% if that's recommended.


Generating API code from the remote template in the new version has an error.

To Reproduce
Steps to reproduce the behavior, if applicable:

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Environments (please complete the following information):

OS: Linux
go-zero version: 1.5.3
goctl version: 1.5.3

Please try it with the master version
eg :  go install github.com/zeromicro/go-zero/tools/goctl@master


MaterialIconStyles not found

In Nuget packet 1.2.2. with Avalonia preview5 there is no MaterialIconStyles.cs.

Ok. I think i misunderstood because I saw last merged PR for Upgrade to Avalonia 11.0.0-preview5 https://github.com/SKProCH/Material.Icons/pull/15

So it is not supported yet Upgrade to Avalonia 11.0.0-preview5?


Support point size with custom value

Point size Or color may link same value. eg. system load、temperature.

This is a great idea and something I think we'd definitely like to add. We're gathering feedback at the moment and we'll see where we can slot this in 😄

Would love to see this as well!


Extended scalars doesn'nt work as described

I define a scalar type scalar Date in my schema. Then I configured extended scalars over the configuration
graphql:
  extended-scalars: Date

and expect that the graphql spring boot starter autoconfiguration register the new type automatically.
But I got the following Exception
Caused by: graphql.kickstart.tools.SchemaClassScannerError: Expected a user-defined GraphQL scalar type with name 'Date' but found none!

I added the library
   <dependency>
	<groupId>com.graphql-java</groupId>
	<artifactId>graphql-java-extended-scalars</artifactId>
	<version>15.0.0</version>
   </dependency>

But I have still the same problem because I still have no auto-configuration.
I miss an auto-configuration like with this library.
<dependency>
	<groupId>com.zhokhov.graphql</groupId>
	<artifactId>graphql-datetime-spring-boot-starter</artifactId>
	<version>4.0.0</version>
</dependency>

Or am I doing something wrong?

You shouldn't have to define that extended-scalars dependency. The one you're listing here is actually older than the one being pulled in by this library.
The GraphQLExtendedScalarsInitializer should be auto-configuring them.

I used version 11.0.0. The feature is available with 11.1.0. That was my fault!!


[9.3.x] ISPN-9641 Using expiration with off heap doesn't subtract size properly

with expiration

Make sure to include expiration when not using version or custom

https://issues.jboss.org/browse/ISPN-9641

Integrated, thanks Will!


Source -> New -> enable Person type

When I create a source, then I want to be able to use the Person subclass.

Option is enabled and working now.