How to convert hifigan V3 to haiku correctly?

Hi,
I'm trying to using resblock: 2 on HiFi-Gan config v3. Could you please help me to fix the convert script so that it could inference correctly?
Using the model converted from the convert_torch_model_to_haiku.py not work with v3.
Here is the error I'm dealing with:
Traceback (most recent call last):
  File "/usr/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/content/vietTTS/vietTTS/synthesizer.py", line 38, in <module>
    wave = mel2wave(mel)
  File "/content/vietTTS/vietTTS/hifigan/mel2wave.py", line 40, in mel2wave
    wav, aux = forward.apply(params, aux, rng, mel)
  File "/usr/local/lib/python3.7/dist-packages/haiku/_src/transform.py", line 400, in apply_fn
    out = f(*args, **kwargs)
  File "/content/vietTTS/vietTTS/hifigan/mel2wave.py", line 32, in forward
    return net(x)
  File "/usr/local/lib/python3.7/dist-packages/haiku/_src/module.py", line 433, in wrapped
    out = f(*args, **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/haiku/_src/module.py", line 284, in run_interceptors
    return bound_method(*args, **kwargs)
  File "/content/vietTTS/vietTTS/hifigan/model.py", line 119, in __call__
    xs = self.resblocks[i * self.num_kernels + j](x)
  File "/usr/local/lib/python3.7/dist-packages/haiku/_src/module.py", line 433, in wrapped
    out = f(*args, **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/haiku/_src/module.py", line 284, in run_interceptors
    return bound_method(*args, **kwargs)
  File "/content/vietTTS/vietTTS/hifigan/model.py", line 72, in __call__
    xt = c(xt)
  File "/usr/local/lib/python3.7/dist-packages/haiku/_src/module.py", line 433, in wrapped
    out = f(*args, **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/haiku/_src/module.py", line 284, in run_interceptors
    return bound_method(*args, **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/haiku/_src/conv.py", line 200, in __call__
    w = hk.get_parameter("w", w_shape, inputs.dtype, init=w_init)
  File "/usr/local/lib/python3.7/dist-packages/haiku/_src/base.py", line 333, in get_parameter
    name, bundle_name))
ValueError: Unable to retrieve parameter 'w' for module 'generator/~/res_block1_0/~/conv1_d'. All parameters must be created as part of `init`.

Hi! You may need to modify this line
https://github.com/NTT123/vietTTS/blob/8d2ee1f1d6542efd7647866bf4c1803b5eefe487/vietTTS/hifigan/convert_torch_model_to_haiku.py#L45
with
a = f"generator/~/res_block2_{x}/~/{y}_{z}"

Hi! You may need to modify this line
https://github.com/NTT123/vietTTS/blob/8d2ee1f1d6542efd7647866bf4c1803b5eefe487/vietTTS/hifigan/convert_torch_model_to_haiku.py#L45
with
a = f"generator/~/res_block2_{x}/~/{y}_{z}"

Thank you so much,
I've read the code and guess I have to modify that line, but after modifying as you've said and I re-convert it. I'm also meet this error:
Traceback (most recent call last):
  File "/usr/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/content/vietTTS/vietTTS/hifigan/convert_torch_model_to_haiku.py", line 82, in <module>
    main()
  File "/content/vietTTS/vietTTS/hifigan/convert_torch_model_to_haiku.py", line 78, in main
    convert_to_haiku(a, h, device)
  File "/content/vietTTS/vietTTS/hifigan/convert_torch_model_to_haiku.py", line 30, in convert_to_haiku
    generator.load_state_dict(state_dict_g["generator"])
  File "/usr/local/lib/python3.7/dist-packages/torch/nn/modules/module.py", line 1498, in load_state_dict
    self.__class__.__name__, "\n\t".join(error_msgs)))
RuntimeError: Error(s) in loading state_dict for Generator:
	Missing key(s) in state_dict: "ups.3.bias", "ups.3.weight_g", "ups.3.weight_v", "resblocks.0.convs1.0.bias", "resblocks.0.convs1.0.weight_g", "resblocks.0.convs1.0.weight_v", "resblocks.0.convs1.1.bias", "resblocks.0.convs1.1.weight_g", "resblocks.0.convs1.1.weight_v", "resblocks.0.convs1.2.bias", "resblocks.0.convs1.2.weight_g", "resblocks.0.convs1.2.weight_v", "resblocks.0.convs2.0.bias", "resblocks.0.convs2.0.weight_g", "resblocks.0.convs2.0.weight_v", "resblocks.0.convs2.1.bias", "resblocks.0.convs2.1.weight_g", "resblocks.0.convs2.1.weight_v", "resblocks.0.convs2.2.bias", "resblocks.0.convs2.2.weight_g", "resblocks.0.convs2.2.weight_v", "resblocks.1.convs1.0.bias", "resblocks.1.convs1.0.weight_g", "resblocks.1.convs1.0.weight_v", "resblocks.1.convs1.1.bias", "resblocks.1.convs1.1.weight_g", "resblocks.1.convs1.1.weight_v", "resblocks.1.convs1.2.bias", "resblocks.1.convs1.2.weight_g", "resblocks.1.convs1.2.weight_v", "resblocks.1.convs2.0.bias", "resblocks.1.convs2.0.weight_g", "resblocks.1.convs2.0.weight_v", "resblocks.1.convs2.1.bias", "resblocks.1.convs2.1.weight_g", "resblocks.1.convs2.1.weight_v", "resblocks.1.convs2.2.bias", "resblocks.1.convs2.2.weight_g", "resblocks.1.convs2.2.weight_v", "resblocks.2.convs1.0.bias", "resblocks.2.convs1.0.weight_g", "resblocks.2.convs1.0.weight_v", "resblocks.2.convs1.1.bias", "resblocks.2.convs1.1.weight_g", "resblocks.2.convs1.1.weight_v", "resblocks.2.convs1.2.bias", "resblocks.2.convs1.2.weight_g", "resblocks.2.convs1.2.weight_v", "resblocks.2.convs2.0.bias", "resblocks.2.convs2.0.weight_g", "resblocks.2.convs2.0.weight_v", "resblocks.2.convs2.1.bias", "resblocks.2.convs2.1.weight_g", "resblocks.2.convs2.1.weight_v", "resblocks.2.convs2.2.bias", "resblocks.2.convs2.2.weight_g", "resblocks.2.convs2.2.weight_v", "resblocks.3.convs1.0.bias", "resblocks.3.convs1.0.weight_g", "resblocks.3.convs1.0.weight_v", "resblocks.3.convs1.1.bias", "resblocks.3.convs1.1.weight_g", "resblocks.3.convs1.1.weight_v", "resblocks.3.convs1.2.bias", "resblocks.3.convs1.2.weight_g", "resblocks.3.convs1.2.weight_v", "resblocks.3.convs2.0.bias", "resblocks.3.convs2.0.weight_g", "resblocks.3.convs2.0.weight_v", "resblocks.3.convs2.1.bias", "resblocks.3.convs2.1.weight_g", "resblocks.3.convs2.1.weight_v", "resblocks.3.convs2.2.bias", "resblocks.3.convs2.2.weight_g", "resblocks.3.convs2.2.weight_v", "resblocks.4.convs1.0.bias", "resblocks.4.convs1.0.weight_g", "resblocks.4.convs1.0.weight_v", "resblocks.4.convs1.1.bias", "resblocks.4.convs1.1.weight_g", "resblocks.4.convs1.1.weight_v", "resblocks.4.convs1.2.bias", "resblocks.4.convs1.2.weight_g", "resblocks.4.convs1.2.weight_v", "resblocks.4.convs2.0.bias", "resblocks.4.convs2.0.weight_g", "resblocks.4.convs2.0.weight_v", "resblocks.4.convs2.1.bias", "resblocks.4.convs2.1.weight_g", "resblocks.4.convs2.1.weight_v", "resblocks.4.convs2.2.bias", "resblocks.4.convs2.2.weight_g", "resblocks.4.convs2.2.weight_v", "resblocks.5.convs1.0.bias", "resblocks.5.convs1.0.weight_g", "resblocks.5.convs1.0.weight_v", "resblocks.5.convs1.1.bias", "resblocks.5.convs1.1.weight_g", "resblocks.5.convs1.1.weight_v", "resblocks.5.convs1.2.bias", "resblocks.5.convs1.2.weight_g", "resblocks.5.convs1.2.weight_v", "resblocks.5.convs2.0.bias", "resblocks.5.convs2.0.weight_g", "resblocks.5.convs2.0.weight_v", "resblocks.5.convs2.1.bias", "resblocks.5.convs2.1.weight_g", "resblocks.5.convs2.1.weight_v", "resblocks.5.convs2.2.bias", "resblocks.5.convs2.2.weight_g", "resblocks.5.convs2.2.weight_v", "resblocks.6.convs1.0.bias", "resblocks.6.convs1.0.weight_g", "resblocks.6.convs1.0.weight_v", "resblocks.6.convs1.1.bias", "resblocks.6.convs1.1.weight_g", "resblocks.6.convs1.1.weight_v", "resblocks.6.convs1.2.bias", "resblocks.6.convs1.2.weight_g", "resblocks.6.convs1.2.weight_v", "resblocks.6.convs2.0.bias", "resblocks.6.convs2.0.weight_g", "resblocks.6.convs2.0.weight_v", "resblocks.6.convs2.1.bias", "resblocks.6.convs2.1.weight_g", "resblocks.6.convs2.1.weight_v", "resblocks.6.convs2.2.bias", "resblocks.6.convs2.2.weight_g", "resblocks.6.convs2.2.weight_v", "resblocks.7.convs1.0.bias", "resblocks.7.convs1.0.weight_g", "resblocks.7.convs1.0.weight_v", "resblocks.7.convs1.1.bias", "resblocks.7.convs1.1.weight_g", "resblocks.7.convs1.1.weight_v", "resblocks.7.convs1.2.bias", "resblocks.7.convs1.2.weight_g", "resblocks.7.convs1.2.weight_v", "resblocks.7.convs2.0.bias", "resblocks.7.convs2.0.weight_g", "resblocks.7.convs2.0.weight_v", "resblocks.7.convs2.1.bias", "resblocks.7.convs2.1.weight_g", "resblocks.7.convs2.1.weight_v", "resblocks.7.convs2.2.bias", "resblocks.7.convs2.2.weight_g", "resblocks.7.convs2.2.weight_v", "resblocks.8.convs1.0.bias", "resblocks.8.convs1.0.weight_g", "resblocks.8.convs1.0.weight_v", "resblocks.8.convs1.1.bias", "resblocks.8.convs1.1.weight_g", "resblocks.8.convs1.1.weight_v", "resblocks.8.convs1.2.bias", "resblocks.8.convs1.2.weight_g", "resblocks.8.convs1.2.weight_v", "resblocks.8.convs2.0.bias", "resblocks.8.convs2.0.weight_g", "resblocks.8.convs2.0.weight_v", "resblocks.8.convs2.1.bias", "resblocks.8.convs2.1.weight_g", "resblocks.8.convs2.1.weight_v", "resblocks.8.convs2.2.bias", "resblocks.8.convs2.2.weight_g", "resblocks.8.convs2.2.weight_v", "resblocks.9.convs1.0.bias", "resblocks.9.convs1.0.weight_g", "resblocks.9.convs1.0.weight_v", "resblocks.9.convs1.1.bias", "resblocks.9.convs1.1.weight_g", "resblocks.9.convs1.1.weight_v", "resblocks.9.convs1.2.bias", "resblocks.9.convs1.2.weight_g", "resblocks.9.convs1.2.weight_v", "resblocks.9.convs2.0.bias", "resblocks.9.convs2.0.weight_g", "resblocks.9.convs2.0.weight_v", "resblocks.9.convs2.1.bias", "resblocks.9.convs2.1.weight_g", "resblocks.9.convs2.1.weight_v", "resblocks.9.convs2.2.bias", "resblocks.9.convs2.2.weight_g", "resblocks.9.convs2.2.weight_v", "resblocks.10.convs1.0.bias", "resblocks.10.convs1.0.weight_g", "resblocks.10.convs1.0.weight_v", "resblocks.10.convs1.1.bias", "resblocks.10.convs1.1.weight_g", "resblocks.10.convs1.1.weight_v", "resblocks.10.convs1.2.bias", "resblocks.10.convs1.2.weight_g", "resblocks.10.convs1.2.weight_v", "resblocks.10.convs2.0.bias", "resblocks.10.convs2.0.weight_g", "resblocks.10.convs2.0.weight_v", "resblocks.10.convs2.1.bias", "resblocks.10.convs2.1.weight_g", "resblocks.10.convs2.1.weight_v", "resblocks.10.convs2.2.bias", "resblocks.10.convs2.2.weight_g", "resblocks.10.convs2.2.weight_v", "resblocks.11.convs1.0.bias", "resblocks.11.convs1.0.weight_g", "resblocks.11.convs1.0.weight_v", "resblocks.11.convs1.1.bias", "resblocks.11.convs1.1.weight_g", "resblocks.11.convs1.1.weight_v", "resblocks.11.convs1.2.bias", "resblocks.11.convs1.2.weight_g", "resblocks.11.convs1.2.weight_v", "resblocks.11.convs2.0.bias", "resblocks.11.convs2.0.weight_g", "resblocks.11.convs2.0.weight_v", "resblocks.11.convs2.1.bias", "resblocks.11.convs2.1.weight_g", "resblocks.11.convs2.1.weight_v", "resblocks.11.convs2.2.bias", "resblocks.11.convs2.2.weight_g", "resblocks.11.convs2.2.weight_v".
	Unexpected key(s) in state_dict: "resblocks.0.convs.0.bias", "resblocks.0.convs.0.weight_g", "resblocks.0.convs.0.weight_v", "resblocks.0.convs.1.bias", "resblocks.0.convs.1.weight_g", "resblocks.0.convs.1.weight_v", "resblocks.1.convs.0.bias", "resblocks.1.convs.0.weight_g", "resblocks.1.convs.0.weight_v", "resblocks.1.convs.1.bias", "resblocks.1.convs.1.weight_g", "resblocks.1.convs.1.weight_v", "resblocks.2.convs.0.bias", "resblocks.2.convs.0.weight_g", "resblocks.2.convs.0.weight_v", "resblocks.2.convs.1.bias", "resblocks.2.convs.1.weight_g", "resblocks.2.convs.1.weight_v", "resblocks.3.convs.0.bias", "resblocks.3.convs.0.weight_g", "resblocks.3.convs.0.weight_v", "resblocks.3.convs.1.bias", "resblocks.3.convs.1.weight_g", "resblocks.3.convs.1.weight_v", "resblocks.4.convs.0.bias", "resblocks.4.convs.0.weight_g", "resblocks.4.convs.0.weight_v", "resblocks.4.convs.1.bias", "resblocks.4.convs.1.weight_g", "resblocks.4.convs.1.weight_v", "resblocks.5.convs.0.bias", "resblocks.5.convs.0.weight_g", "resblocks.5.convs.0.weight_v", "resblocks.5.convs.1.bias", "resblocks.5.convs.1.weight_g", "resblocks.5.convs.1.weight_v", "resblocks.6.convs.0.bias", "resblocks.6.convs.0.weight_g", "resblocks.6.convs.0.weight_v", "resblocks.6.convs.1.bias", "resblocks.6.convs.1.weight_g", "resblocks.6.convs.1.weight_v", "resblocks.7.convs.0.bias", "resblocks.7.convs.0.weight_g", "resblocks.7.convs.0.weight_v", "resblocks.7.convs.1.bias", "resblocks.7.convs.1.weight_g", "resblocks.7.convs.1.weight_v", "resblocks.8.convs.0.bias", "resblocks.8.convs.0.weight_g", "resblocks.8.convs.0.weight_v", "resblocks.8.convs.1.bias", "resblocks.8.convs.1.weight_g", "resblocks.8.convs.1.weight_v".
	size mismatch for conv_pre.bias: copying a param with shape torch.Size([256]) from checkpoint, the shape in current model is torch.Size([512]).
	size mismatch for conv_pre.weight_g: copying a param with shape torch.Size([256, 1, 1]) from checkpoint, the shape in current model is torch.Size([512, 1, 1]).
	size mismatch for conv_pre.weight_v: copying a param with shape torch.Size([256, 80, 7]) from checkpoint, the shape in current model is torch.Size([512, 80, 7]).
	size mismatch for ups.0.bias: copying a param with shape torch.Size([128]) from checkpoint, the shape in current model is torch.Size([256]).
	size mismatch for ups.0.weight_g: copying a param with shape torch.Size([256, 1, 1]) from checkpoint, the shape in current model is torch.Size([512, 1, 1]).
	size mismatch for ups.0.weight_v: copying a param with shape torch.Size([256, 128, 16]) from checkpoint, the shape in current model is torch.Size([512, 256, 16]).
	size mismatch for ups.1.bias: copying a param with shape torch.Size([64]) from checkpoint, the shape in current model is torch.Size([128]).
	size mismatch for ups.1.weight_g: copying a param with shape torch.Size([128, 1, 1]) from checkpoint, the shape in current model is torch.Size([256, 1, 1]).
	size mismatch for ups.1.weight_v: copying a param with shape torch.Size([128, 64, 16]) from checkpoint, the shape in current model is torch.Size([256, 128, 16]).
	size mismatch for ups.2.bias: copying a param with shape torch.Size([32]) from checkpoint, the shape in current model is torch.Size([64]).
	size mismatch for ups.2.weight_g: copying a param with shape torch.Size([64, 1, 1]) from checkpoint, the shape in current model is torch.Size([128, 1, 1]).
	size mismatch for ups.2.weight_v: copying a param with shape torch.Size([64, 32, 8]) from checkpoint, the shape in current model is torch.Size([128, 64, 4]).

Hi @NTT123,
I've tried to replace the config to v3 in assets/hifigan/config.json with the file same as config_v3.json
Then update the code same as this commit but my v3 has some error about the keys:
Traceback (most recent call last):
  File "/usr/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/content/vietTTS/vietTTS/hifigan/convert_torch_model_to_haiku.py", line 83, in <module>
    main()
  File "/content/vietTTS/vietTTS/hifigan/convert_torch_model_to_haiku.py", line 79, in main
    convert_to_haiku(a, h, device)
  File "/content/vietTTS/vietTTS/hifigan/convert_torch_model_to_haiku.py", line 30, in convert_to_haiku
    generator.load_state_dict(state_dict_g["generator"])
  File "/usr/local/lib/python3.7/dist-packages/torch/nn/modules/module.py", line 1498, in load_state_dict
    self.__class__.__name__, "\n\t".join(error_msgs)))
RuntimeError: Error(s) in loading state_dict for Generator:
	Missing key(s) in state_dict: "resblocks.0.convs.0.bias", "resblocks.0.convs.0.weight_g", "resblocks.0.convs.0.weight_v", "resblocks.0.convs.1.bias", "resblocks.0.convs.1.weight_g", "resblocks.0.convs.1.weight_v", "resblocks.1.convs.0.bias", "resblocks.1.convs.0.weight_g", "resblocks.1.convs.0.weight_v", "resblocks.1.convs.1.bias", "resblocks.1.convs.1.weight_g", "resblocks.1.convs.1.weight_v", "resblocks.2.convs.0.bias", "resblocks.2.convs.0.weight_g", "resblocks.2.convs.0.weight_v", "resblocks.2.convs.1.bias", "resblocks.2.convs.1.weight_g", "resblocks.2.convs.1.weight_v", "resblocks.3.convs.0.bias", "resblocks.3.convs.0.weight_g", "resblocks.3.convs.0.weight_v", "resblocks.3.convs.1.bias", "resblocks.3.convs.1.weight_g", "resblocks.3.convs.1.weight_v", "resblocks.4.convs.0.bias", "resblocks.4.convs.0.weight_g", "resblocks.4.convs.0.weight_v", "resblocks.4.convs.1.bias", "resblocks.4.convs.1.weight_g", "resblocks.4.convs.1.weight_v", "resblocks.5.convs.0.bias", "resblocks.5.convs.0.weight_g", "resblocks.5.convs.0.weight_v", "resblocks.5.convs.1.bias", "resblocks.5.convs.1.weight_g", "resblocks.5.convs.1.weight_v", "resblocks.6.convs.0.bias", "resblocks.6.convs.0.weight_g", "resblocks.6.convs.0.weight_v", "resblocks.6.convs.1.bias", "resblocks.6.convs.1.weight_g", "resblocks.6.convs.1.weight_v", "resblocks.7.convs.0.bias", "resblocks.7.convs.0.weight_g", "resblocks.7.convs.0.weight_v", "resblocks.7.convs.1.bias", "resblocks.7.convs.1.weight_g", "resblocks.7.convs.1.weight_v", "resblocks.8.convs.0.bias", "resblocks.8.convs.0.weight_g", "resblocks.8.convs.0.weight_v", "resblocks.8.convs.1.bias", "resblocks.8.convs.1.weight_g", "resblocks.8.convs.1.weight_v".
	Unexpected key(s) in state_dict: "ups.3.bias", "ups.3.weight_g", "ups.3.weight_v", "resblocks.9.convs1.0.bias", "resblocks.9.convs1.0.weight_g", "resblocks.9.convs1.0.weight_v", "resblocks.9.convs1.1.bias", "resblocks.9.convs1.1.weight_g", "resblocks.9.convs1.1.weight_v", "resblocks.9.convs1.2.bias", "resblocks.9.convs1.2.weight_g", "resblocks.9.convs1.2.weight_v", "resblocks.9.convs2.0.bias", "resblocks.9.convs2.0.weight_g", "resblocks.9.convs2.0.weight_v", "resblocks.9.convs2.1.bias", "resblocks.9.convs2.1.weight_g", "resblocks.9.convs2.1.weight_v", "resblocks.9.convs2.2.bias", "resblocks.9.convs2.2.weight_g", "resblocks.9.convs2.2.weight_v", "resblocks.10.convs1.0.bias", "resblocks.10.convs1.0.weight_g", "resblocks.10.convs1.0.weight_v", "resblocks.10.convs1.1.bias", "resblocks.10.convs1.1.weight_g", "resblocks.10.convs1.1.weight_v", "resblocks.10.convs1.2.bias", "resblocks.10.convs1.2.weight_g", "resblocks.10.convs1.2.weight_v", "resblocks.10.convs2.0.bias", "resblocks.10.convs2.0.weight_g", "resblocks.10.convs2.0.weight_v", "resblocks.10.convs2.1.bias", "resblocks.10.convs2.1.weight_g", "resblocks.10.convs2.1.weight_v", "resblocks.10.convs2.2.bias", "resblocks.10.convs2.2.weight_g", "resblocks.10.convs2.2.weight_v", "resblocks.11.convs1.0.bias", "resblocks.11.convs1.0.weight_g", "resblocks.11.convs1.0.weight_v", "resblocks.11.convs1.1.bias", "resblocks.11.convs1.1.weight_g", "resblocks.11.convs1.1.weight_v", "resblocks.11.convs1.2.bias", "resblocks.11.convs1.2.weight_g", "resblocks.11.convs1.2.weight_v", "resblocks.11.convs2.0.bias", "resblocks.11.convs2.0.weight_g", "resblocks.11.convs2.0.weight_v", "resblocks.11.convs2.1.bias", "resblocks.11.convs2.1.weight_g", "resblocks.11.convs2.1.weight_v", "resblocks.11.convs2.2.bias", "resblocks.11.convs2.2.weight_g", "resblocks.11.convs2.2.weight_v", "resblocks.0.convs1.0.bias", "resblocks.0.convs1.0.weight_g", "resblocks.0.convs1.0.weight_v", "resblocks.0.convs1.1.bias", "resblocks.0.convs1.1.weight_g", "resblocks.0.convs1.1.weight_v", "resblocks.0.convs1.2.bias", "resblocks.0.convs1.2.weight_g", "resblocks.0.convs1.2.weight_v", "resblocks.0.convs2.0.bias", "resblocks.0.convs2.0.weight_g", "resblocks.0.convs2.0.weight_v", "resblocks.0.convs2.1.bias", "resblocks.0.convs2.1.weight_g", "resblocks.0.convs2.1.weight_v", "resblocks.0.convs2.2.bias", "resblocks.0.convs2.2.weight_g", "resblocks.0.convs2.2.weight_v", "resblocks.1.convs1.0.bias", "resblocks.1.convs1.0.weight_g", "resblocks.1.convs1.0.weight_v", "resblocks.1.convs1.1.bias", "resblocks.1.convs1.1.weight_g", "resblocks.1.convs1.1.weight_v", "resblocks.1.convs1.2.bias", "resblocks.1.convs1.2.weight_g", "resblocks.1.convs1.2.weight_v", "resblocks.1.convs2.0.bias", "resblocks.1.convs2.0.weight_g", "resblocks.1.convs2.0.weight_v", "resblocks.1.convs2.1.bias", "resblocks.1.convs2.1.weight_g", "resblocks.1.convs2.1.weight_v", "resblocks.1.convs2.2.bias", "resblocks.1.convs2.2.weight_g", "resblocks.1.convs2.2.weight_v", "resblocks.2.convs1.0.bias", "resblocks.2.convs1.0.weight_g", "resblocks.2.convs1.0.weight_v", "resblocks.2.convs1.1.bias", "resblocks.2.convs1.1.weight_g", "resblocks.2.convs1.1.weight_v", "resblocks.2.convs1.2.bias", "resblocks.2.convs1.2.weight_g", "resblocks.2.convs1.2.weight_v", "resblocks.2.convs2.0.bias", "resblocks.2.convs2.0.weight_g", "resblocks.2.convs2.0.weight_v", "resblocks.2.convs2.1.bias", "resblocks.2.convs2.1.weight_g", "resblocks.2.convs2.1.weight_v", "resblocks.2.convs2.2.bias", "resblocks.2.convs2.2.weight_g", "resblocks.2.convs2.2.weight_v", "resblocks.3.convs1.0.bias", "resblocks.3.convs1.0.weight_g", "resblocks.3.convs1.0.weight_v", "resblocks.3.convs1.1.bias", "resblocks.3.convs1.1.weight_g", "resblocks.3.convs1.1.weight_v", "resblocks.3.convs1.2.bias", "resblocks.3.convs1.2.weight_g", "resblocks.3.convs1.2.weight_v", "resblocks.3.convs2.0.bias", "resblocks.3.convs2.0.weight_g", "resblocks.3.convs2.0.weight_v", "resblocks.3.convs2.1.bias", "resblocks.3.convs2.1.weight_g", "resblocks.3.convs2.1.weight_v", "resblocks.3.convs2.2.bias", "resblocks.3.convs2.2.weight_g", "resblocks.3.convs2.2.weight_v", "resblocks.4.convs1.0.bias", "resblocks.4.convs1.0.weight_g", "resblocks.4.convs1.0.weight_v", "resblocks.4.convs1.1.bias", "resblocks.4.convs1.1.weight_g", "resblocks.4.convs1.1.weight_v", "resblocks.4.convs1.2.bias", "resblocks.4.convs1.2.weight_g", "resblocks.4.convs1.2.weight_v", "resblocks.4.convs2.0.bias", "resblocks.4.convs2.0.weight_g", "resblocks.4.convs2.0.weight_v", "resblocks.4.convs2.1.bias", "resblocks.4.convs2.1.weight_g", "resblocks.4.convs2.1.weight_v", "resblocks.4.convs2.2.bias", "resblocks.4.convs2.2.weight_g", "resblocks.4.convs2.2.weight_v", "resblocks.5.convs1.0.bias", "resblocks.5.convs1.0.weight_g", "resblocks.5.convs1.0.weight_v", "resblocks.5.convs1.1.bias", "resblocks.5.convs1.1.weight_g", "resblocks.5.convs1.1.weight_v", "resblocks.5.convs1.2.bias", "resblocks.5.convs1.2.weight_g", "resblocks.5.convs1.2.weight_v", "resblocks.5.convs2.0.bias", "resblocks.5.convs2.0.weight_g", "resblocks.5.convs2.0.weight_v", "resblocks.5.convs2.1.bias", "resblocks.5.convs2.1.weight_g", "resblocks.5.convs2.1.weight_v", "resblocks.5.convs2.2.bias", "resblocks.5.convs2.2.weight_g", "resblocks.5.convs2.2.weight_v", "resblocks.6.convs1.0.bias", "resblocks.6.convs1.0.weight_g", "resblocks.6.convs1.0.weight_v", "resblocks.6.convs1.1.bias", "resblocks.6.convs1.1.weight_g", "resblocks.6.convs1.1.weight_v", "resblocks.6.convs1.2.bias", "resblocks.6.convs1.2.weight_g", "resblocks.6.convs1.2.weight_v", "resblocks.6.convs2.0.bias", "resblocks.6.convs2.0.weight_g", "resblocks.6.convs2.0.weight_v", "resblocks.6.convs2.1.bias", "resblocks.6.convs2.1.weight_g", "resblocks.6.convs2.1.weight_v", "resblocks.6.convs2.2.bias", "resblocks.6.convs2.2.weight_g", "resblocks.6.convs2.2.weight_v", "resblocks.7.convs1.0.bias", "resblocks.7.convs1.0.weight_g", "resblocks.7.convs1.0.weight_v", "resblocks.7.convs1.1.bias", "resblocks.7.convs1.1.weight_g", "resblocks.7.convs1.1.weight_v", "resblocks.7.convs1.2.bias", "resblocks.7.convs1.2.weight_g", "resblocks.7.convs1.2.weight_v", "resblocks.7.convs2.0.bias", "resblocks.7.convs2.0.weight_g", "resblocks.7.convs2.0.weight_v", "resblocks.7.convs2.1.bias", "resblocks.7.convs2.1.weight_g", "resblocks.7.convs2.1.weight_v", "resblocks.7.convs2.2.bias", "resblocks.7.convs2.2.weight_g", "resblocks.7.convs2.2.weight_v", "resblocks.8.convs1.0.bias", "resblocks.8.convs1.0.weight_g", "resblocks.8.convs1.0.weight_v", "resblocks.8.convs1.1.bias", "resblocks.8.convs1.1.weight_g", "resblocks.8.convs1.1.weight_v", "resblocks.8.convs1.2.bias", "resblocks.8.convs1.2.weight_g", "resblocks.8.convs1.2.weight_v", "resblocks.8.convs2.0.bias", "resblocks.8.convs2.0.weight_g", "resblocks.8.convs2.0.weight_v", "resblocks.8.convs2.1.bias", "resblocks.8.convs2.1.weight_g", "resblocks.8.convs2.1.weight_v", "resblocks.8.convs2.2.bias", "resblocks.8.convs2.2.weight_g", "resblocks.8.convs2.2.weight_v".
	size mismatch for conv_pre.bias: copying a param with shape torch.Size([512]) from checkpoint, the shape in current model is torch.Size([256]).
	size mismatch for conv_pre.weight_g: copying a param with shape torch.Size([512, 1, 1]) from checkpoint, the shape in current model is torch.Size([256, 1, 1]).
	size mismatch for conv_pre.weight_v: copying a param with shape torch.Size([512, 80, 7]) from checkpoint, the shape in current model is torch.Size([256, 80, 7]).
	size mismatch for ups.0.bias: copying a param with shape torch.Size([256]) from checkpoint, the shape in current model is torch.Size([128]).
	size mismatch for ups.0.weight_g: copying a param with shape torch.Size([512, 1, 1]) from checkpoint, the shape in current model is torch.Size([256, 1, 1]).
	size mismatch for ups.0.weight_v: copying a param with shape torch.Size([512, 256, 16]) from checkpoint, the shape in current model is torch.Size([256, 128, 16]).
	size mismatch for ups.1.bias: copying a param with shape torch.Size([128]) from checkpoint, the shape in current model is torch.Size([64]).
	size mismatch for ups.1.weight_g: copying a param with shape torch.Size([256, 1, 1]) from checkpoint, the shape in current model is torch.Size([128, 1, 1]).
	size mismatch for ups.1.weight_v: copying a param with shape torch.Size([256, 128, 16]) from checkpoint, the shape in current model is torch.Size([128, 64, 16]).
	size mismatch for ups.2.bias: copying a param with shape torch.Size([64]) from checkpoint, the shape in current model is torch.Size([32]).
	size mismatch for ups.2.weight_g: copying a param with shape torch.Size([128, 1, 1]) from checkpoint, the shape in current model is torch.Size([64, 1, 1]).
	size mismatch for ups.2.weight_v: copying a param with shape torch.Size([128, 64, 4]) from checkpoint, the shape in current model is torch.Size([64, 32, 8]).

Do I need to re-implement the key mapping for the model?


Branch master is failing

Trying to build master at commit 4bc650679b1f702338e40abe56c43f80c97dc801 failed.
More info at: https://travis-ci.com/Qiskit/qiskit-terra/jobs/232360455

Looks like a regular network issue with the ibmq api:
qiskit.providers.ibmq.api_v2.exceptions.RequestsApiError: 524 Server Error: Origin Time-out for url: https://api-qcon.quantum-computing.ibm.com/api/Network/ibm-q/Groups/open/Projects/main/devices/ibmq_ourense/queue/status?access_token=...'
Closing because there's nothing to fix in terra.


Parse 4575 pretest

Codecov Report

Merging #2 into master will increase coverage by 0.06%.
The diff coverage is 44.82%.

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage   71.89%   71.95%   +0.06%
==========================================
  Files         352      352
  Lines       47858    47937      +79
==========================================
+ Hits        34406    34492      +86
+ Misses      13452    13445       -7

Impacted Files
Coverage Δ

src/posix/platform/hdlc_interface.hpp
100% <ø> (ø)
:arrow_up:

src/posix/platform/spi_interface.cpp
0% <0%> (ø)
:arrow_up:

src/posix/platform/hdlc_interface.cpp
52.81% <55%> (-1.27%)
:arrow_down:

src/posix/main.c
69.5% <79.62%> (+17.59%)
:arrow_up:

src/posix/platform/uart.cpp
69.23% <0%> (-0.86%)
:arrow_down:

src/core/thread/mle_router.cpp
89.4% <0%> (-0.24%)
:arrow_down:

src/core/thread/mle.cpp
91.5% <0%> (+0.36%)
:arrow_up:

src/core/mac/mac.cpp
88.49% <0%> (+0.49%)
:arrow_up:

src/posix/platform/radio_spinel.cpp
82.81% <0%> (+1.2%)
:arrow_up:

src/core/thread/time_sync_service.cpp
95.06% <0%> (+1.23%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e13c06e...1644079. Read the comment docs.


[BUG] pyximport uses deprecated "imp" module

Replace it with importlib or whatever seems appropriate and modern.

I was looking into the problem and pyximport uses more deprecated components - e.g. we are implementing find_module hook which is deprecated from 3.10 [1]. Since we still need do compatibility magic (importlib cannot be used in python 2.7), maybe it will be easier to total refactor of pyximport rather than trying to fit importlib to old way of importing. (We will keep old pyximport for 2.7 support)
[1] https://docs.python.org/3/library/importlib.html#importlib.abc.Finder.find_module

total refactor of pyximport rather than trying to fit importlib to
old way of importing. (We will keep old pyximport for 2.7 support)

Sounds good to me. We could have a _pyximport2 and a fresh _pyximport3 module, and then have pyximport itself only import the right one. We would drop the ...2 version in Cython 3.1 then, and stick with the clean new module. So that's a good preparation.

Right, this will cause a conflict with #4625, so waiting is prudent. The split between pre- and post-python3.5 there will allow the newer version to use os.path.common.


Adding animation effects to component

Is there any way semantic components exposes a way to add animation provided in semantic-ui ?

Duplicate, see #200.
We plan to re-use SUI CSS animations.  A proof of concept was done for the Dropdown.  We will implement a solution after first updating all legacy components.


http://start.dubbo.io/ 无法访问

使用Win 10，Chrome 83访问  http://start.dubbo.io/  时，系统500报错，截图如下。
Whitelabel Error Page
This application has no explicit mapping for /error, so you are seeing this as a fallback.
Sat Jun 13 12:46:05 CST 2020
There was an unexpected error (type=Internal Server Error, status=500).
Could not determine version based on '2.4.0-SNAPSHOT': version format is Minor.Major.Patch.Qualifier (e.g. 1.0.5.RELEASE)

现在是这个网址了  https://start.aliyun.com/bootstrap.html


Unable to load the ckpt file

Hi,
When I am trying to run the prediction. I am getting the following error
Start prediction
starting
Traceback (most recent call last):
  File "/opt/conda/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/opt/conda/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/opt/algorithm/process.py", line 90, in <module>
    Unet_baseline().process()
  File "/opt/algorithm/process.py", line 84, in process
    monai_unet.run_inference(self.ckpt_path, self.nii_path, self.output_path)
  File "/opt/algorithm/monai_unet.py", line 137, in run_inference
    segment_PETCT(ckpt_path, data_dir, export_dir)
  File "/opt/algorithm/monai_unet.py", line 108, in segment_PETCT
    net = Net.load_from_checkpoint(ckpt_path)
  File "/home/algorithm/.local/lib/python3.10/site-packages/pytorch_lightning/utilities/model_helpers.py", line 125, in wrapper
    return self.method(cls, *args, **kwargs)
  File "/home/algorithm/.local/lib/python3.10/site-packages/pytorch_lightning/core/module.py", line 1586, in load_from_checkpoint
    loaded = _load_from_checkpoint(
  File "/home/algorithm/.local/lib/python3.10/site-packages/pytorch_lightning/core/saving.py", line 63, in _load_from_checkpoint
    checkpoint = pl_load(checkpoint_path, map_location=map_location)
  File "/home/algorithm/.local/lib/python3.10/site-packages/lightning_fabric/utilities/cloud_io.py", line 57, in _load
    return torch.load(f, map_location=map_location)  # type: ignore[arg-type]
  File "/opt/conda/lib/python3.10/site-packages/torch/serialization.py", line 1040, in load
    return _legacy_load(opened_file, map_location, pickle_module, **pickle_load_args)
  File "/opt/conda/lib/python3.10/site-packages/torch/serialization.py", line 1258, in _legacy_load
    magic_number = pickle_module.load(f, **pickle_load_args)
_pickle.UnpicklingError: invalid load key, 'v'.

After googling a bit I found that the it might be caused because the model epoch=777-step=64573.ckpt is not downloaded properly. After checking the size I found the model size was 4.0k
Can you please look into this.

Did you check out the GIT repository with GIT LFS?
git lfs pull
The trained weights are stored as LFS.

Thanks that works.


BagIt creation failure

We just found that one of our resource had an error for creating BagIt file.
When we click the "Download all content as Zipped bagIt Archive" button, the BagIt file should be created, then download starts, but it just wait and nothing happened.
Other resources are fine. Just this has the problem.
Here is the link for the resource:
https://www.hydroshare.org/resource/c65bce3e4459476f9950c6510728695e/
And here is the screenshot.

@Maurier @pkdash do recent updates to the UI handle this now?

I just tested.  Behavior is exactly the same as Jan 8 report above.  Beta gives a bag download in a few seconds, but www gives a long line of .... that never ends.  These sort of problems make me worry about resource integrity and make me think that we perhaps need some of the debug scripts we used to have from @alvacouch .  It also makes me think of the script we used to have from @Castronova to test downloads of all resources to detect these sort of problems.  Tony's script was set aside because it was time consuming and a more efficient check resources script was written.  But we still evidently have problems with some resources, and we do not, at least in the case of this one, know why, and this worries me.  I am going to bump this up to high priority, because something like this that raises concerns about resource integrity, without an explanation, should get high priority intention.

I just tried and can download the bag for this problematic resource in the issue successfully. Perhaps the cleanup I did fixed this bag download issue. You can close this issue now that the bag can be downloaded successfully for this resource.
Thanks,
Hong


Docker image build fails on cache_models.py, uses 12GB of RAM

I am trying to build a custom Docker image for a serverless inference endpoint, to use RunDiffusion/Juggernaut-X-v10. The build fails on running cache_models.py with the error below. It looks like it could possibly be an out of memory error, but I am on an M1 MacBook Pro with 16GB RAM, and I have increased my Docker config to be able to use 12GB, and it still fails. Interestingly, it always fails at Loading pipeline components...:  71%, regardless of Docker's memory allowance.
 => [7/9] COPY builder/cache_models.py /cache_models.py                                                                                0.0s
 => ERROR [8/9] RUN python3.11 /cache_models.py &&     rm /cache_models.py                                                                                1337.1s
------
 > [8/9] RUN python3.11 /cache_models.py &&     rm /cache_models.py:
2.158 The cache for model files in Transformers v4.22.0 has been updated. Migrating your old cache. This is a one-time only operation. You can interrupt this and resume the migration later on by calling `transformers.utils.move_cache()`.
0it [00:00, ?it/s]
3.265 /usr/local/lib/python3.11/dist-packages/diffusers/models/transformers/transformer_2d.py:34: FutureWarning: `Transformer2DModelOutput` is deprecated and will be removed in version 1.0.0. Importing `Transformer2DModelOutput` from `diffusers.models.transformer_2d` is deprecated and this will be removed in a future version. Please use `from diffusers.models.modeling_outputs import Transformer2DModelOutput`, instead.
3.265   deprecate("Transformer2DModelOutput", "1.0.0", deprecation_message)
Fetching 17 files: 100%|██████████| 17/17 [00:01<00:00, 16.57it/s]
Loading pipeline components...:   0%|          | 0/7 [00:00<?, ?it/s]Some weights of the model checkpoint were not used when initializing CLIPTextModel:
1300.9  ['text_model.embeddings.position_ids']
Loading pipeline components...:  71%|███████▏  | 5/7 [00:11<00:03,  1.93s/it]/bin/bash: line 1:     7 Killed                  python3.11 /cache_models.py
------
Dockerfile:18
--------------------
  17 |     COPY builder/cache_models.py /cache_models.py
  18 | >>> RUN python3.11 /cache_models.py && \
  19 | >>>     rm /cache_models.py
  20 |
--------------------
ERROR: failed to solve: process "/bin/bash -o pipefail -c python3.11 /cache_models.py &&     rm /cache_models.py" did not complete successfully: exit code: 137

View build details: docker-desktop://dashboard/build/desktop-linux/desktop-linux/jx8kdgsse2539d4hxel3vl1z7

Shouldn't 12GB be enough RAM to complete the build? Also, is there another workflow that I'm not aware of for deploying a serverless inference endpoint with a custom model? This process has been pretty painful so far.

I am getting this error, how did you solve it?

Hi sorry for the delay, I didn't actually solve this issue locally. I first got it running with the Github Actions included in the repo, but that also failed some of the time, so ultimately I switched to using Docker Cloud, which ended up being a lot easier: https://docs.docker.com/build-cloud/usage/


can not support  [pd.Group(key='date',freq='1M') ,pd.Group('ID')]

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Modin version (modin.__version__):
Python version:
Code we can use to reproduce:

Describe the problem

Source code / logs

Hi @sunshine0123 thanks for the report!
What was the error message that you saw? Did it fail completely or just show a warning?

Hi @KabratKingEstelle! I'm marking this issue as resolved, since it hasn't been updated in a while. If you have any further questions, please feel free to reopen this issue, or open a new one.


Texture and model optimizations.

This PR makes several optimizations to models and textures which reduce the total size of the final jar by just over 1mb. (1 038 320 bytes).
Here is a break down of the various optimizations applied.

Removed unused and irrelevant user metadata from textures files.
Applied Zopfli compression to texture files. This is lossless compression that does not affect quality or color of textures. It is also compatible with the PNG specification.
Added auto json minify at build time. This removes superfluous white space and new line characters from json files when the json file is copied into the final jar. The original source copy of the file is not modified.

Wow, thanks! I'll merge this and test it. I will most likely move these improvements over to the 1.14.4 branch as well.


ZIPファイルの例を追加

Codecov Report

Merging #113 (7922a51) into master (9caf03f) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
- Coverage   97.39%   97.15%   -0.24%
==========================================
  Files          24       30       +6
  Lines         997     1197     +200
==========================================
+ Hits          971     1163     +192
- Misses         26       34       +8

Impacted Files
Coverage Δ

source/data/zip_example.d
100.00% <100.00%> (ø)

source/typecons_example.d
100.00% <0.00%> (ø)

thirdparty/vibe-d/source/vibed_usage/_common.d
100.00% <0.00%> (ø)

thirdparty/vibe-d/source/vibed_usage/https.d
92.59% <0.00%> (ø)

thirdparty/vibe-d/source/vibed_usage/http.d
95.34% <0.00%> (ø)

thirdparty/vibe-d/source/vibed_usage/web.d
95.23% <0.00%> (ø)

thirdparty/vibe-d/source/vibed_usage/rest.d
96.15% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9caf03f...7922a51. Read the comment docs.


Manually-created themes not detected

Does this issue occur when all extensions are disabled?: N/A: I cannot load any custom or third-party themes with extensions disabled

Versions/OS:

Version: 1.72.0-insider (Universal)
Commit: bcb6c9b7e0e795bdf65ea440025d204060e4bfc8
Date: 2022-09-30T05:18:31.322Z
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 21.6.0
Sandboxed: Yes

Steps to Reproduce:

Create new theme, either via yeoman extension creator or by copying an existing theme and renaming it (folder, files, manifest metadata)

What happens:

Theme not detected via theme picker shortcut or settings tab
Process works fine when done in VS Code 1.72 release version—theme detected and loaded

Where did you copy it?

Yes, that should work. Make sure your manifest has no syntax errors. Check the logs and outputs.
The recommended way to test an extension is to open its folder in VSCode and use the Run button in the Run and Debug view, or press F5.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!

Yes, that should work. Make sure your manifest has no syntax errors. Check the logs and outputs.
The recommended way to test an extension is to open its folder in VSCode and use the Run button in the Run and Debug view, or press F5.

Yes—new themes load as expected in Run and Debug view with no errors. I still can find no way to load them for normal use on the latest VSC Insiders commit.
With my release version of VSC, I can drop a new theme extension into ~/.vscode/extensions/ and it is available to use as a theme instantly. Up until recently, I was able to do this on Insiders as well.

Dropping in the extension folder is not really the recommended way, but normally works. @sandy081 Anything special to know when doing that?

This does not work if you have created a new profile. Have you?

Sorry, but I'm simply not sure. I had made new settings profiles since I initially installed Insiders, so it's likely.
For now I am building the themes as extensions and installing them manually from VSIX, while previewing any changes I make with the debugger. My lazy side does not prefer this but it does seem more correct.


[Event Request] Base Application, Codeunit 134262 "Bank Pmt. Appl. Tolerance"

[Event Request] Base Application, Codeunit 134262 "Bank Pmt. Appl. Tolerance"

Could you please insert an Initialize-Call at the beginning of all test procedures in the codeunit and an Initialize procedure like in other test codeunits?

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Is there anything new about this issue? Still waiting for the event in BC16 CU1.


Install coc plugins and rename .dotfiles to dotfile.

c8555ed eb55061
The idea of creating coc-package.json and install packages in setup script is based on altescy/dotfiles.
Huge thanks for publishing the awesome dotfiles.
https://github.com/altescy/dotfiles/commit/337e9358bf498e8a7e1fecca5425865c238c84a6


delimiter attribute in  collector should be optional

Sometimes concatenation does not require a delimiter between the strings being combined. Currently the delimiter attribute must be set to an empty string to allow this. It would be handy if this were the default value for this attribute.
Not all users find the method of setting delimiter to an empty string intuitive.

+1


suggest username available from mongodb using symfony2

I use FOSUserBundle; I want that when a user enters an existing username; it has a username list available

@wajaja and how exactly ODM can help you?

If I my guess of is right, he is looking for an autofill or autocomplete like this.
https://jqueryui.com/autocomplete/
Scott

@malarzm ;  i would like this:
before creating a user; make a query the database to get the username list available whose names correspond to the one introduced by the user; Then he suggested the username by adding a number of order.
example: if cedrickngeja are suggested cedrickngeja1, cedrickngeja2, cedrickngeja6

@wajaja I get the idea but how is this anything for ODM itself? :) If we'd be to ship something like this it'd be in bundle since it's Symfony related but we can't since desired format depends on frontend tool you might want to use. Such things are supposed to be crafted per project by developers, at least in my opinion.

Ah, that isn't the same as what I thought you meant and definitely has nothing to do with ODM.
Scott

Closing since there's nothing we can do.


Client generated code does not compile

I am attempting to generate C# client out of this spec: http://wiki.eoilreports.com/download/attachments/365059/dataconnect.json?api=v2
The NSwag produces code with bits like:
public System.Threading.Tasks.Task 1Async(string accountNumber, Version6 version, DataConnectComponent body)
{
return 1Async(accountNumber, version, body, System.Threading.CancellationToken.None);
}
public async System.Threading.Tasks.Task 2Async
and also lots of ambigous variables and method calls.

I haven't investigated in depth, but it seems to be caused by the operations with a "_" (e.g. create_1 )


Chrome update broke tailwindcss-container-query (which uses container-query-polyfill)

I've been using a plugin tailwind-container-query which uses container-query-polyfill.
After last week's stable-channel-update-for-desktop for Google Chrome on Mac OS, the plugin stopped working.  I dont know which library is broken, but I'd assume the other one since people here would probably notice if there was an issue.  Figured I'd check though - anyone else seeing this or have any ideas?

Hey, I am using tailwind-container-query aswell! After surma left google, devknoll updated the entire container-query-polyfill (alpha version) which has raised a lot of confusion on my part.
I am having these issues (with the latest version, not alpha)
Issue 1
https://github.com/GoogleChromeLabs/container-query-polyfill/issues/23
Solution: https://github.com/GoogleChromeLabs/container-query-polyfill/issues/23#issuecomment-1216849203
Issue 2
https://github.com/GoogleChromeLabs/container-query-polyfill/issues/34
Solution: https://github.com/GoogleChromeLabs/container-query-polyfill/issues/34#issuecomment-1216866099
Both solutions should be fixed in the new version of the polyfill by @devknoll
I made this to check if the alpha solves issue 2:
https://github.com/Enebz/container-query-demo/tree/alpha
And it works perfectly, however this is not using the tailwind version.
Anyways
After installing the alpha version for my project where I use tailwindcss-container-query, nothing works at all. I am not getting issue #23 simply because nothing about it works.
When testing with the latest version (0.1.2), the library works just like it did before the chrome update you are talking about. Where I am still getting error #23 and #34. To fix error #23 I used https://github.com/GoogleChromeLabs/container-query-polyfill/pull/33 this, but issue #34 still remained.
I do not think your issue comes from the chrome update as I have no issues using the latest version on my project.
Also, can you specify which version of container-query-polyfill you are using?

Thanks for the reply.  I do think it's the Chrome update because I was at burning man for a week (no code changes) and came back to it no longer working in Chrome and still working in Safari.
It will take some more time for me to create a clean sandbox example, but here's safari on the left and chrome on the right with a basic text-red tag on the text if a large container size is detected:

This is with<EMAIL_ADDRESS>and both<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Using Chrome 105.0.5195.102 (as matching the update blog post link shared above) on MacOS 12.5.

Okay, hmm. I will test some more on my side as I am using exactly the same versions as you.

Thanks @Enebz - appreciate the responses.  How are you using the libraries?  I'm using like this:

Red if Large

with this tailwind config:
theme: {
        /* using the container queries plugin https://github.com/dgknca/tailwindcss-container-query */
        containerName: {
            cw: 'cardWidget',
            // ...
        },
        containerQuery: {
            lg: '440px',
        },
        /* END */

I was able to solve this by using different syntax and it worked fine.  Will make a note to trace it through more to understand why my syntax worked last week and not this week, but for now it's good.


Remove reference to scheduled Whitehall publications

This was ported to the new platform in https://github.com/alphagov/govuk-helm-charts/pull/1677

The old "not queued" alert is Edition.future_scheduled_editions.count - ScheduledPublishingWorker.queue_size > 0. I think that can only be true if the "overdue" alert is also firing (i.e. Edition.due_for_publication.count > 0). Is that a valid statement?

I'm not aware of any discussions around these checks, but the two metrics are actually different on staging and integration, (in staging, the overdue count is 32 and the unenqueued count is over 500)

Thanks @samsimpson1!


TypeError: nodes[0] is undefined - custom priority parameter

I'm using a custom priority parameter and getting the following error TypeError: nodes[0] is undefined
https://github.com/kurkle/chartjs-chart-sankey/blob/9dbd19faa27a67000403197ca6940a2c2931e357/src/layout.js#L215
nodes[0] assumes that there is always at least one element and this is not true in my case.
<EMAIL_ADDRESS><EMAIL_ADDRESS>

Don't know if this is related or not. In my data set, if I filter items with flow > 1 the error goes away.

If you can, please provide a codepen or equivalent that reproduces the issue.

This was fixed by #111


Appointment with recurrence overwrite start/end date

When having appointments with recurrences, then we have no way to find the original start/end date, since they are always overwritten by the values from the "calculated" part of the JSON answer.
For example here, the event definition has start/end dates of the "Main" entry as 4.nov. 2023
But the calculated values from the recurrence overwrite this in the returned data set.
In most cases this doe snot cause an Issue, since it's what we wish, but so we don't have a way to get hold of "base start/end" and "calculated start/end" dates.
A breaking change would be to move the "calculated" start/end dates into two separate fields, but then the returned start/end dates will not be for the current occurence of the event, but for the base definition. (Which is probably what api users want in 98% of the cases)
Or we leave it as it is, and store the "base start/end" and "calculated start/end" into additional properies, this would be more api user friendly, but might cause confusions later on.
Not sure which approach you prefer
{
      "base": {
        "id": 600783,
        "caption": "Nidau: Jungschar-Nachmittag",
        "note": "EL",
        "address": {
          "meetingAt": "Bibliotheksplatz Nidau",
          "street": "Hauptstrasse 73",
          "addition": null,
          "district": null,
          "zip": "2560",
          "city": "Nidau",
          "country": "CH",
          "latitude": "47.1244565",
          "longitude": "7.2411075"
        },
        "version": 1,
        "calendar": {
          "id": 32,
          "name": "Anlässe FW und extern",
          "nameTranslated": "Anlässe FW und extern",
          "sortKey": 14,
          "color": "#f691b2",
          "isPublic": true,
          "isPrivate": false,
          "randomUrl": "Y4qjxtxPOAFutQ4A7cLriupJlaFMYvuw",
          "iCalSourceUrl": "",
          "campusId": null,
          "eventTemplateId": null,
          "meta": {
            "modifiedDate": "2018-01-24T14:22:11Z",
            "modifiedPid": 1
          }
        },
        "information": "Treffpunkt beim Bibliotheksplatz<EMAIL_ADDRESS>        "image": null,
        "link": "",
        "isInternal": false,
        "startDate": "2023-11-04T13:00:00Z",
        "endDate": "2023-11-04T16:15:00Z",
        "allDay": false,
        "repeatId": 999,
        "repeatFrequency": null,
        "repeatUntil": null,
        "repeatOption": null,
        "additions": [
          {
            "id": 1107,
            "date": "2023-11-18",
            "isRepeated": false,
            "meta": {
              "modifiedDate": "2023-09-05T15:50:09Z",
              "modifiedPid": 1516
            }
          },
          {
            "id": 1108,
            "date": "2023-12-02",
            "isRepeated": false,
            "meta": {
              "modifiedDate": "2023-09-05T15:50:09Z",
              "modifiedPid": 1516
            }
          },
          {
            "id": 1109,
            "date": "2023-12-16",
            "isRepeated": false,
            "meta": {
              "modifiedDate": "2023-09-05T15:50:09Z",
              "modifiedPid": 1516
            }
          }
        ],
        "exceptions": [],
        "signup": null,
        "meta": {
          "createdDate": "2023-09-05T15:50:09Z",
          "createdPerson": {
            "id": 1516
          },
          "modifiedDate": "2023-09-28T07:28:50Z",
          "modifiedPerson": {
            "id": 1
          }
        },
        "onBehalfOfPid": null
      },
      "calculated": {
        "startDate": "2023-11-18T13:00:00Z",
        "endDate": "2023-11-18T16:15:00Z"
      }
    }

I noticed this behaviour when investigating this issue:
https://github.com/a-schild/churchtools-wp-calendarsync/issues/2

I recommend incorporating extra fields for storing both the "base start/end" and "calculated start/end" as separate properties. This approach ensures that we avoid breaking changes. Additionally, it aligns with my understanding of the most logical structure. The "startDate" property is likely to be the most frequently used by users, while the "base" and "calculated" properties are designed for those who require more advanced information.

#177


Update frontend to 1.1.1

Updates dependency version number
Removes fix that added margin to table component as the margin is now part of the component CSS

You can preview this change here:
Built with commit d4487bc40efd32017667aad6380d0f344ca18971
https://deploy-preview-449--govuk-design-system-preview.netlify.com


Different output than PuttyGen

When I use a PEM with just one "-----BEGIN RSA PRIVATE KEY-----" it won't generate a correct .PPK.
The server rejects the key.
If I generate the ppk with puttygen.exe it works. Any ideas?

Hi.
The conversion part of this program uses the following code.
https://antonymale.co.uk/generating-putty-key-files.html
It may be a problem with this code.
In that case, I will not be able to fix this code. Because I can not understand this code…
I have generated the key with the following contents, which is going well.
ssh-keygen -t rsa -b 4096 -f ./test.pem
I use connection software TeraTerm and tested server UbuntuServer 16.04.
(I am not good at English. I happy to your message.)

Hi Akira,
Check these files out out:
Input Private Key: rsa private key.pem.txt
Output from PuttyGen: puttygen.ppk.txt
Output from your code (different and wrong): pem2ppk_code.ppk.txt
Public Key (For reference): public key.pem.txt

Hi .
I was late reply. sorry. I'm too busy work ....
I got your same file, set it on my test server and tried ssh connection.
On my test server, both of them succeeded. Both files is puttygen.ppk.txt and pem2ppk_code.ppk.txt.
My test server is CentOS Linux release 7.3.1611. I use SSH Client Software is TeraTerm.
The procedure I tried is as follows.
1:Download same files(rsa.private.key.pem.txt、puttygen.ppk.txt、pem2ppk_code.ppk.txt)
2:Convert rsa.private.key.pem.txt and set authorized_keys.
ssh-keygen -y -f rsa.private.key.pem.txt > ~/.ssh/authorized_keys
 chmod 0600 ~/.ssh/authorized_keys
3:I attempted to connect to the test server using the rsa.private.key.pem.txt key or the puttygen.ppk.txt key or the pem2ppk_code.ppk.txt key. I used TeraTerm.
4:I also tried using rsa.private.key.pem.txt again convert with pem2ppk.
In all I was able to connect with SSH.


Add common quality/compression interface

What would you like to have changed?
Add a common interface to allow setting of compression level using int. e.g.
type ConfigurableCompressionLevel interface {
  SetCompressionLevel(int)
}

(this could be SetCompressionLevel(int) bool to say whether this level is acceptable.)
Why is this feature a useful, necessary, and/or important addition to this project?
Many archivers/compressors have a way of setting compression level and this would allow these to be exposed in a common fashion.
What alternatives are there, or what are you doing in the meantime to work around the lack of this feature?

We can continue by casting as individual types of archiver
Could use reflect.ValueOf(...).FieldByName("CompressionLevel").SetInt(...) / "Quality" as appropriate

Please link to any relevant issues, pull requests, or other discussions.
N/A at the moment.

I see the API has changed considerably for v4 and this may not be as useful.

Thanks; I think if this was implemented it should be an optional interface that can be type-asserted to use, but I don't know how useful this would be since if you're customizing a compressor you usually are working with the concrete type already anyways.

I don't know of a good way to make this work cross-format, though, I think it might be best for the user/caller to just set the options per-format instead.


User with access right Member & Contributor is not getting added in Power BI Workspace V2 using REST API

🛑 IMPORTANT: You can get your feedback addressed faster if you use the comment section for the article in which you encountered a problem.
Link to article:
Tell us where exactly a problem occurs.
Article - Add User To group in Power BI
Link - https://docs.microsoft.com/en-gb/rest/api/power-bi/groups/addgroupuser#groupuseraccessright
Problem:
What's wrong with the article?
A User with GroupUserAccessRight = 'Admin' is getting added successfully in WorkspaceV2 but in the same workspace the user with GroupUserAccessRight = 'Member' and GroupUserAccessRight = 'Contributor' is not getting added. Also the option to remove a user from workspace with parameter as GroupUserAccessRight = 'None' is also not working.
Please look into this issue as soon as possible.
Thanks,
Saurabh Porwal
<EMAIL_ADDRESS>

@eligr Can you please take a look at this?

Hi Saurabh!
As the note at the top of the page says, only Admin access right is supported.
We have support of other permissions on our backlog, will release them in about a month.
Eli.

Thank you for your response! Awaiting for the same.
Thanks & Regards,
Saurabh Porwal
On Wed 29 May, 2019, 11:45 AM Eli Greenwald<EMAIL_ADDRESS>wrote:

Hi Saurabh!
As the note at the top of the page says, only Admin access right is
supported.
We have support of other permissions on our backlog, will release them in
about a month.
Eli.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/feedback/issues/1549?email_source=notifications&email_token=AEIU2NW5MWLZCCEP5LV4ZKLPXYNPDA5CNFSM4HPY6CG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWOJBOA#issuecomment-496799928,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEIU2NVO7PHNWZAESRUVYFDPXYNPDANCNFSM4HPY6CGQ
.


Feature/coverage with other report

Summary
Add coverage overview report for Bitbucket.

Codecov Report

Merging #194 (ebc62ab) into master (3bca2c6) will decrease coverage by 0.77%.
The diff coverage is 91.78%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##             master     #194      +/-   ##
============================================
- Coverage     91.74%   90.98%   -0.77%
- Complexity      101      106       +5
============================================
  Files            21       23       +2
  Lines           521      588      +67
  Branches         50       57       +7
============================================
+ Hits            478      535      +57
- Misses           11       16       +5
- Partials         32       37       +5

Impacted Files
Coverage Δ

...odeInsights/infrastructure/dto/BitbucketRequest.kt
66.66% <66.66%> (ø)

...ns/codeInsights/domain/coverage/CoverageRequest.kt
73.33% <80.00%> (+3.33%)
:arrow_up:

...o/jenkins/plugins/codeInsights/KotlinEntryPoint.kt
100.00% <100.00%> (ø)

...s/codeInsights/domain/coverage/CoverageOverview.kt
100.00% <100.00%> (ø)

.../plugins/codeInsights/infrastructure/HttpClient.kt
95.95% <100.00%> (-4.05%)
:arrow_down:

...ns/plugins/codeInsights/usecase/CoverageUsecase.kt
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seito2
Good job.
Thank you for your contribution.
I'll merge this and release soon


where is the io.confluent.examples.streams package? Is it from parent?

where is the acro package under io.confluent.examples.streams in the example
https://github.com/confluentinc/kafka-streams-examples/tree/5.0.0-post? I am not finding the Product, PlayEvent, Song etc classes, microservices packages mentioned in the io.confluent.examples.streams.avro package for this project.
Is it from parent rest util? Sorry, I am since I am working from restricted env, can download from all the repos, so cant see if present in parent proj

I had the same problem.
Just switch to the latest stable release (v5.0.0 for now):
git checkout tags/v5.0.0 -b v5.0.0

Please ignore this question, when I fully built it outside restricted environment, I am able to get them. They are generated sources for schemas. Thanks


Exercises should lead up to the capstone

An exercise (or five!) should involve working with byte slices, readers, and writers. Maybe even posting HTTP.
(Also, I think it should be possible to avoid mentioning the header in the explanation. We really only care about the body. It's helpful to understand an HTTP header, but for students who are already getting overwhelmed, the header is something that can be ignored.)

Perhaps this could involve the error exercise(s) as well. I did not really like the one I used DivideErr, since it was fairly contrived and non-practical. Could deal with temporary (503) or fatal (404) Http responses instead.

For errors, I'd suggest an exercise which involves cascading errors up to the main function, and exiting the program if there's an error. I know that's extremely simple, but that's 99% of what a beginner needs to do with errors.


Redis supports failover through Sentinel

Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/

Can you write the description of the change proposed in the PR? Looks like
the "thanks for contributing" was left unchanged.
On Tuesday, September 6, 2016, Juntao<EMAIL_ADDRESS>wrote:

Thanks for contributing to Logstash! If you haven't already signed our
CLA, here's a handy link: https://www.elastic.co/contributor-agreement/
You can view, comment on, or merge this pull request online at:
https://github.com/logstash-plugins/logstash-output-redis/pull/39
Commit Summary

Redis supports failover through Sentinel

File Changes

M lib/logstash/outputs/redis.rb
https://github.com/logstash-plugins/logstash-output-redis/pull/39/files#diff-0
(28)

Patch Links:

https://github.com/logstash-plugins/logstash-output-redis/
pull/39.patch
https://github.com/logstash-plugins/logstash-output-redis/
pull/39.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/logstash-plugins/logstash-output-redis/pull/39, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAIC6gH37K1E-yyfGT3Oh0X0nKPSmlx0ks5qnmC6gaJpZM4J2mJj
.

hey @juntaozhang do you want to fix this or I make another PR for this feature?

@jsvd I think this could be a great addition. Do you think that it could be merged, now?

Are there any plans to merge this in, along with https://github.com/logstash-plugins/logstash-input-redis/pull/50 too?
cc @jsvd @jordansissel

+1024, we want it!

Any news on this?

+1


add intro video topics and linked scenes to directly navigate to

I found this video very useful to get an overview on how contribute to React. Also I liked the fact, that most of the topics were clearly scoped explained.
So in case somebody wants to have a quick info on a specific React contributing topic without watching the whole video, theses shortlinks to the proper scenes in the video might be of help. I referenced the links using > symbol, as otherwise the hyperlink styles would be too style-dominating in the visual appearance of that docs section. In case you want this to be changed, I can adjust the pull request.

@bvaughn thx for your tips. PR is updated.

@bvaughn thx for your tips. PR is updated.


Flatbuffer Graber Not working on 18.0 Beta3

Bug report, debug log and your config file (FULL LOGS ARE MANDATORY)
https://pastebin.com/ZPAztNw8
Steps to reproduce
Using Piccap and HyperHDR 18 Beta3.
What is expected?
Seeing a flatbuffer source in the remote section. Like it is with 17.0
What is actually happening?
No source is visible.
System

System info
HyperHDR Server:

Build:           (HEAD detached at 8d314bc) (Awawa-5b8ed09/8d314bc-1654356765)
Build time:      Jun  4 2022 15:51:17
Git Remote:      https://github.com/awawa-dev/HyperHDR
Version:         <IP_ADDRESS>beta3
UI Lang:         en (BrowserLang: de-DE)
UI Access:       default
Avail Capt:      Linux (V4L2)
Database:        read/write

HyperHDR Server OS:

Distribution:   Debian GNU/Linux 11 (bullseye)
Architecture:   arm64
CPU Type:       Raspberry Pi 4 Model B Rev 1.1
CPU Revision:   c03111
CPU Hardware:   BCM2835
Kernel:         linux (5.15.32-v8+ (WS: 64))
Qt Version:     5.15.2
Browser:        Mozilla/5.0 (iPh

First of all, webos version & configurations are not supported and maintained by me, but for sure I'll fix potential bugs that I can reproduce on the HyperHDR to HyperHDR flatbuffer communication. Secondly flatbuffers for sure works in v18beta3: tested by me (HyperHDR to HyperHDR) and many people using piccap (please check webos discord). In your logs I can't see any attempt to establish flatbuffer connection so I would look for the problem outside (network/firewall/piccap configuration). BTW your network is available about 10 seconds after starting HyperHDR.

I am not using the WebOS HyperHDR. It is running on my raspberry pi. Everything is running find with 17.0 as soon as I installiert 18.0 it is Not working any more. Without any settings changed.

I know but your are using external flatbuffer server which I don't support.  Only HyperHDR to HyperHDR flatbuffer configuration are officially supported. But it's working even with piccap, I can assure you. I can only hope that your piccap version can communicate on the non-standard 19445 port, but if it worked before....

Waiting for the official Version. Doing a clean install then:


How do I include a blade template from a twig one?

I saw that this was asked in #39 and was then referenced as part of "Improve template loading" in 0.6.0 (#62 and #72) and checked off, but it's not clear how exactly it was improved.
The suggested workaround of {{ view_make('view-name') }} is not working for me. I'm trying to include a partial provided by a package so I'm doing {{ view_make('package-name::template-name') }}. I'm told view_make doesn't exist.
Attempting to include the template directly (with Twig's include statement) doesn't work either.

Why would you want this?

I am using a package which provides various partials in Blade format, like widgets. I don't want to rewrite this package with Twig templates, because then I wouldn't benefit from upstream fixes.

It would also be useful if I were to transition an existing application from Blade to Twig (as I have been considering doing). It's not practical with applications of a certain scale to do it all at once: this would allow me to do it piece by piece.

What about adding the 'View' facade to your config, and call View.make('view-name'), or add view to the functions in the config: {{ view('view-name') }}

That seems reasonable, at least for now.
In theory would it be possible to overload Twig's include statement to run Laravel's view behind the scenes? It would be nice if this were transparent, i.e. the include was format-agnostic.

I don't think you can really mix them, except for just rendering something as a string.

In this case particualar that would suffice. But in other cases (transitioning an app bit by bit) it would not.
That's a shame to hear.
You can consider this ticket a wishlist item, then. Thanks.

These issues really need closing.


Card | FE | spacing and border radius props

Jira
http://vjira2:8080/browse/BDS-2041
http://vjira2:8080/browse/BDS-2081
Summary
Adds spacing and border-radius props to the card component.
Details

spacing prop will control the spacing on the card body and card actions, it makes sure content and actions will line up regardless what spacing is being used.
border-radius prop enables the card to have either small or large border-radius.
Removed a few utility classes on certain Academy pages because they are no longer needed.
An interim (also future proof) solution is used for writing the CSS for the border-radius prop. Please let me know if you agree with this simpler approach. Otherwise, I will change it back to class based CSS, which will add another 70 lines of code. Keep in mind if we can make the JS solution to work so overflow:hidden can be used freely, this interim solution won't be needed.
Fixes an issue with the card border not raising with the clickable card on hover.
Fixes an issue with the card media not respecting the border-radius of the card.
Fixes an issue with the stacking order of link, background, media, body, and actions.

How to test
Pull down the branch locally and perform the following.
Check tests

[ ] 1. Given I have pulled down the branch locally
[ ] 2. And I am in the root folder
[ ] 3. When I run the command npx jest packages/components/bolt-card-replacement/__tests__/card-replacement.js
[ ] 4. Then I should see all tests indicated as "Pass"

Check spacing prop

[ ] 1. Given I am looking at the card component's spacing doc page
[ ] 2. Then I should see cards with spacing options that are indicated in the schema
[ ] 3. And visually each card's spacing matches the stated spacing

Check border-radius prop

[ ] 1. Given I am looking at the card component's border-radius doc page
[ ] 2. Then I should see cards with border-radius options that are indicated in the schema
[ ] 3. And visually each card's border-radius matches the stated border-radius

Check Academy Blueprints

[ ] 1. Given I am browsing through all pages under Blueprints in PL
[ ] 2. Then visually all cards should match closely with their counterparts on master

Technically, it's a backwards breaking change. On the other hand, we kind of half assed that prop in the first place (it was never added to the schema or built as a proper prop), so I'm inclined to just ship this and then update the three places it appears in the academy theme when it comes time to pull in this Bolt version there. Thoughts @danielamorse?

@remydenton yessir, that's the plan. There's a ticket on the Academy board that goes with v2.22.

PR was released with v2.22.0


Exception occurs under wechat debug tool under canvaskit enginge when using flutter web

haowmazss-MacBook-Pro:flutter_module haowmazs$ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 2.0.2, on Mac OS X 10.15.5 19F101 darwin-x64, locale en-CN)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
[!] Xcode - develop for iOS and macOS
    ✗ Xcode installation is incomplete; a full installation is necessary for iOS development.
      Download at: https://developer.apple.com/xcode/download/
      Or install Xcode via the App Store.
      Once installed, run:
        sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer
        sudo xcodebuild -runFirstLaunch
    ! CocoaPods 1.9.1 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.
[✓] Chrome - develop for the web
[✓] Android Studio (version 3.5)
[✓] IntelliJ IDEA Ultimate Edition (version 2017.1.6)
[✓] VS Code (version 1.54.2)
[✓] Connected device (2 available)

! Doctor found issues in 1 category.

exception as below

--web-renderer = html is OK

@stoneLee81
Can you provide a complete minimal reproducible code sample that shows this issue ?

This exception will only appear in the WeChat debugging tool

@stoneLee81
I believe WeChat debugging tool is 3rd party to Flutter web and this issue should be reported in dedicated repo (refer how and from where did you installed that tool).
Closing this from here. If you disagree or think this is indeed related to Flutter web, write in comments and I'll reopen it.


Results Pane Header Issue

The header row will disappear from results pane view when scrolling with the arrow keys on the keyboard.

Azure Data Studio Version:

Steps to Reproduce:

Execute a query that has more records than you can screen in the results pane without scrolling
Click in the Results pane.
Navigate down (using the down arrow key on the keyboard) past the records that are visible on screen.
The header row will disappear no mater how much scrolling up you do (using the up arrow key on the keyboard) or using the search bars on the right hand side. [The header row should never disappear when scrolling with arrow keys]

The only way to see the headers again is to click the arrow to collapse the results pane which seems to refresh that pane.

@JASM2007 thanks for reporting this issue.  I've updated the result grid sizing and scrolling behavior with #5285 and it should hopefully resolve this problem.  At least I can longer repro it.  Please let me know if the issue persists on the latest insider build or the 1.7.0 release planned for next week.


Update scalacheck-1-14 to <IP_ADDRESS>

Updates org.scalatestplus:scalacheck-1-14 from <IP_ADDRESS> to <IP_ADDRESS>.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalatestplus", artifactId = "scalacheck-1-14" } ]

labels: library-update

Codecov Report

Merging #374 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #374   +/-   ##
=======================================
  Coverage   95.54%   95.54%
=======================================
  Files          15       15
  Lines         764      764
  Branches       45       45
=======================================
  Hits          730      730
  Misses         34       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e42207...93df155. Read the comment docs.


Faster XTC decoding

This PR adds faster decoding of integers which are stored as <= 64 bits. For these values, integer arithmetic can be used as proposed here and implemented by libxtc.
libxtc also has a special implementation for larger ints using 128 bit ints. I found that these lengths are rather unusual in "typical" MD trajectories.
Instead, the old algorithm is used to decode those values here eliminating special compile time checks for the presence of 128 bit types.
Also, a testcase for these large ints is added to test the old code paths.
The changes reduce the time to read the ubuquitin.xtc test file by more than 20%.

merged! thanks for doing this!


Fixes/uninitialized constant base

Fixes issue when loading in non development environment, was failing on staging with:
NameError: uninitialized constant AuditTables::Base

when rails was booting up.
NOTE: this issue never occurred on CI or development :(

Going to go with explicit for all of them for now - I don't see us making many changes to this library in the short term.

👍


A NULL NTL (null-terminated list) results in a invalid JSON if generated from spec

The following JSON is generated (via dati_to_json) when a NTL (null-terminated list)
{
  "op":2,
  "d":{
    "token":"TOKEN",
    "properties": {
      "$os":"POSIX",
      "$browser":"orca",
      "$device":"orca"
    },
    "compress":false,
    "large_threshold":0,
    "presence": {
      "since":"2021-03-19T16:34:31.262Z",
      "activities":,
      "status":"online",
      "afk":false
    },
    "guild_subscriptions":false,
    "intents":13824
  }
}

As you can see from the activities field, that results in a invalid JSON that can't be interpreted by the receiver. If a NTL is NULL the resulting value should also be null or absent from the JSON.

fixed.

it will render null for NULL ntl.


mysqlxx transaction exception safety

Fix terminate on exception and rollback query fail.

Can one of the admins verify this patch?

Can one of the admins verify this patch?


rtorrent: requires curl installed

curl is a must for rtorrent installation => added as dependency

If I remember correctly, you should add "unless OS.mac?" to the end of the line you changed so it remains compatible with Homebrew.

fixed.
@iggyvolz thanks for the hint

Is curl only a build-time dependency or also a run-time dependency?

Please report the exact error message that you see without this patch, or brew gist-logs rtorrent

checking for libcurl... no
configure: error: Package requirements (libcurl >= 7.15.4) were not met:

No package 'libcurl' found

Based on this error message, I don't think it's a :build dependency. Modified and merged. Thanks for your contribution, Peter.


[SNAP-944] Kryo serializer optimizations

use a pool implementation for KryoSerializerInstance. Unlike SparkSqlSerializer
that uses separate static APIs for using the pooled instances, this one
changes the KryoSerializer.newInstance itself.
use a more optimized version for serialization of Decimal using BigInteger.toByteArray
updated kryo version reference explicitly to pull the fix for
bug #312 (https://github.com/EsotericSoftware/kryo/issues/312)

@rishitesh @hbhanawat Please review. I will update this to avoid changing KryoSerializer rather add own implementation in SnappyData layer (like PooledKryoSerializer), but review the basic code meanwhile.

Apart from the comment that I have given, the code looks good. It would help to update the description to explain why resourcePool is needed for kryoSerializer when it is not being used at many places.

@hbhanawat Didn't get your comment? What is not being used in many places? Note that kryo is used throughout when spark.serializer is set to it (and can be set to our pooled impl as noted in my comments). Other than than in Spark 2.0 it is also useful for Catalyst layer since SparkSqlSerializer and its pool has been completely removed (while there was good reason for former, but its pool was a casualty in the process). Every usage of SparkEnv.serializer will use kryo when so configured, and every such call will create a new kryo object with fresh registrations which is quite expensive.
From what I can tell kryo should work just fine in all cases and we can set that for embedded by default, even though the Spark tuning doc claims otherwise, since it will fallback to java serialization (unless "spark.kryo.registrationRequired" is set). Nevertheless the first thing in every Spark tuning doc is to use kryo serializer which does make a significant difference, and this change is to make it efficient especially for queries that won't be that long running.

Sorry for being brief. Two reasons why I thought it would not be of much use:

KryoSerializerInstance.serialize already had a kryo instance caching mechanism. But now when I further looked I realized it is a pool of size 1.
SparkSqlSerializer.serialize would anyway use a pool. But, yeah as you had said that's a static API.

So my arguments do not hold. I am good with the change. Please go ahead with the merge

Ok, thanks. Also SparkSqlSerializer is gone in Spark 2.0 so this will also help with catalyst serialization in 2.0


Proposal: introduce actix-web to simplify HTTP handling?

Feature Request
Is your feature request related to a problem? Please describe:
Refer to #4444
Seem that we may add more and more HTTP APIs so the origin hyper can't fit our need.
@BusyJay and @breeswish think https://github.com/actix/actix-web is a better choice.
Describe alternatives you've considered:
Maybe compare other Web frameworks.

Actix is a decent library, but it has downsides: it uses non-standard futures (which may have soundness issues), it is a pretty opinionated, heavyweight framework, and it is large and complex. We should definitely compare other web frameworks to make sure we pick the right one; we should at least consider Rocket and Tide. It would also be good to know exactly how Hyper is not meeting our needs - I had a quick look at #4444 but it wasn't obvious what Actix offers which Hyper doesn't.

@nrc We mostly want a framework with some better routing features, for example, able to match path parameters. As you can see in #4444 we did that manually which is pretty awful.

The Rocket is quite an application framework which is not a good choice for intergration.

Yes, I also feels Rocket is a bit too large. Tide is new and aiming for using standard futures I remember. I think it was relatively small sometime ago but I can see it keeps on growing. (Or perhaps the growing of it will not be an issue...)
Anyway I think Tide have very nice api designs:
https://github.com/rustasync/tide/blob/master/examples/messages.rs
async fn get_message(cx: Context<Database>) -> EndpointResult {
    let id = cx.param("id").client_err()?;
    if let Some(msg) = cx.state().get(id) {
        Ok(response::json(msg))
    } else {
        Err(StatusCode::NOT_FOUND)?
    }
}

fn main() {
    let mut app = App::with_state(Database::default());
    app.at("/message/:id").get(get_message).post(set_message);
    app.run("<IP_ADDRESS>:8000").unwrap();
}

What do you think?  @breeswish  have you also looked into Tide? However it is very new marked as not production ready, and perhaps less people using it in production.

@liufuyang I don't have experience with Tide, but your example looks to be pretty attractive. My concern is that it is marked as not production ready and I don't know why it is not ready :)

yeah... perhaps it uses many unstable features such as futures-preview = "0.3.0-alpha.16"? Perhaps I can try ask in the workgroup about it.

As I can see for now we only need to add a simple config endpoint to handle HTTP GET calls, perhaps we can just use current hyper solution, and we can wait a bit on using a web framework now? As soon the standard future will be ready (I hope), then many things could be changed and perhaps it will be easier to select a web framework (or even customise a small web server later on, or implement the feature we need directly in hyper?). I feel if Rust can do the async IO well with awesome build-in futures, things could look quite different by then.

@liufuyang You can continue working on switching to (a stable) framework and later change to some better ones when it is ready.

Here's the actix-web issue for releasing 1.0 https://github.com/actix/actix-web/issues/722 and there's some discussion about futures in there. The goal I think is to transition to futures 0.3 when tokio does.
I think one big plus for actix-web is that its development is very active and was recently released as 1.0.

just use current hyper solution, and we can wait a bit on using a web framework now?

I would encourage this - I don't think any of the current solutions are great and there is a high risk of getting trapped into one. Perhaps it is possible to write a routing utility specific to our needs which is not too complicated?

marked as not production ready and I don't know why it is not ready

by understanding is that it is just at an early stage of development and needs iteration, rather than there being any specific issue.

The Rocket is quite an application framework which is not a good choice for intergration.

I agree, and also feel the same way about Actix.

Anyway I think Tide have very nice api designs:

Yes! It has the best API IMO and also sticking very closely to standard Rust conventions/patterns/libraries.

yeah... perhaps it uses many unstable features such as futures-preview = "0.3.0-alpha.16"

Note that futures 0.3 is the version of futures which will become 1.0 futures and everyone not using it will have to upgrade at some point (including us!).

@breeswish What do you think, should we wait a bit on this? And before that we can now just add a few more endpoints for getting configs? Correct me if I am wrong but for now I think adding just a few more config showing endpoints sounds something could be very useful and beside that we don't have clear plans on adding more endpoints for other purpose? 🤔

Switching to a better routing facility / framework is just a remaining task of previous failpoint PRs. It does not have strong relationship with future changes. @liufuyang

@breeswish Yes, I agree it's good to have some better routing. What's your take on nrc's input? Do you think he worries too much and we should just give actix-web a try now or? I hope an agreement can be made soon so @jlerche and I can try start working on related stuff :)

em, I think we waste too many time on this, introducing an HTTP framework has a low risk because it is not in the critical path. we can try anyone if we think it is good to use.
If now we can using hyper can solve our problem, let's keep the same, if not, let's decide one and go on.
@breeswish @jlerche @nrc @liufuyang can you make a decision this week?

If you don't reach an agreement, I think we can let @liufuyang choose one solution and advance it. If he chooses one framework but we have to use another later, I also think he is able to do the migration.

I can see that no great solution is available at the moment. I suggest to keep current implementation and wait a little bit to see what happen next.

Thanks for the input above. So how about this, we (@jlerche  and me) will start on adding the config endpoint with the current hyper way. Then at the same time I will see whether I can do some refactory (perhaps making current status server a standalone package module?) and also at the same time try out actix-web or tide, and see whether the build time has any influence and so on.
Then later if the code looks easy to change to another web framework, then perhaps we can ship with actix-web or tide directly then continue polishing it if necessary.
@breeswish  @siddontang How do you think about this idea? I can promise you I will try to make the status server part looks better, hopefully before the end of this year 😄

I feel fine, since status server is not in our critical path and future change does not heavily depend on the framework change.

I have no problem continuing with hyper.
I am personally biased towards actix, however, as I have been using it for quite a while, so it gets my vote when the time comes 😀

Thanks, sounds good. @jlerche you can start adding those config list endpoints now I think, just make a PR and let take a look at it when you get it working :) You can ping me or others on the community slack for help. I am new to tikv repo as well but we can learn it together :)

sgtm!

Related to #4997


Remaining (non CSS) issues to resolve on slides

[ ]
[ ]
[ ]
[ ]

Question/Comment: it's unclear from the cover page text that users can also use/access/view additional notes when using the markdown slides in presentation mode. Should/Can we add a third link to the cover page for all modules that links directly to the slide view that includes/makes visible the additional notes text?

To clarify my previous comment-- the presentation functionality exists/works already, but needs to be more visible both on the cover page and described more clearly in the Readme.

Time to close this issue?

Yes!! Hurrah!


[ffmpeg] build failure

bug control file
vcpkg install ffmpeg[*]:x64-windows

The following packages will be built and installed:
ffmpeg[bzip2,core,ffmpeg,ffplay,ffprobe,ffserver,gpl,lzma,nonfree,opencl,openssl,vpx,x264]:x64-windows
Starting package 1/1: ffmpeg:x64-windows
Building package ffmpeg[bzip2,core,ffmpeg,ffplay,ffprobe,ffserver,gpl,lzma,nonfree,opencl,openssl,vpx,x264]:x64-windows...
CMake Warning:
No source or binary directory provided.  Both will be assumed to be the
same as the current working directory, but note that this warning will
become a fatal error in future CMake releases.

https://github.com/microsoft/vcpkg/blob/master/ports/ffmpeg/CONTROL
extra line breaks

Description: a library to decode, encode, transcode, mux, demux, stream, filter and play pretty much anything that humans and machines have created. [BUG] <<--
FFmpeg is the leading multimedia framework, able to decode, encode, transcode, mux, demux, stream, filter and play pretty much anything that humans and machines have created. It supports the most obscure ancient formats up to the cutting edge. No matter if they were designed by some standards committee, the community or a corporation. It is also highly portable: FFmpeg compiles, runs, and passes our testing infrastructure FATE across Linux, Mac OS X, Microsoft Windows, the BSDs, Solaris, etc. under a wide variety of build environments, machine architectures, and configurations.

I can't reproduce it locally. I installed it successfully with Visual Studio 2017 and vcpkg latest source. There are no warnings on my VM. This is my build log:
Starting package 8/8: ffmpeg:x64-windows
Building package ffmpeg[bzip2,core,ffmpeg,ffplay,ffprobe,ffserver,gpl,lzma,nonfree,opencl,openssl,vpx,x264]:x64-windows...
-- Downloading http://ffmpeg.org/releases/ffmpeg-4.1.tar.bz2...
-- Extracting source F:/0812/vcpkg/downloads/ffmpeg-4.1.tar.bz2
-- Applying patch create-lib-libraries.patch
-- Applying patch detect-openssl.patch
-- Applying patch configure_opencv.patch
-- Applying patch fix_windowsinclude-in-ffmpegexe-1.patch
-- Applying patch fix_windowsinclude-in-ffmpegexe-2.patch
-- Applying patch fix_libvpx_windows_linking.patch
-- Applying patch fix-debug-build.patch
-- Using source at F:/0812/vcpkg/buildtrees/ffmpeg/src/ffmpeg-4-bb005b3e35
-- Acquiring MSYS Packages...
-- Acquiring MSYS Packages... OK
-- Building Options: --enable-asm --enable-yasm --disable-doc --enable-debug --enable-runtime-cpudetect --enable-nonfree --enable-gpl --enable-openssl --enable-ffmpeg --enable-ffplay --enable-ffprobe --enable-libvpx --enable-libx264 --enable-opencl --enable-lzma --enable-bzlib  --extra-cflags=-DHAVE_UNISTD_H=0 --disable-static --enable-shared
-- Building Relase Options:  --extra-cflags=-MD --extra-cxxflags=-MD
-- Building ffmpeg for Release
-- Building Debug Options:  --extra-cflags=-MDd --extra-cxxflags=-MDd --debug
-- Building ffmpeg for Debug
-- Generating F:\0812\vcpkg\packages\ffmpeg_x64-windows\debug\lib\avcodec.lib
-- Generating F:\0812\vcpkg\packages\ffmpeg_x64-windows\debug\lib\avdevice.lib
-- Generating F:\0812\vcpkg\packages\ffmpeg_x64-windows\debug\lib\avfilter.lib
-- Generating F:\0812\vcpkg\packages\ffmpeg_x64-windows\debug\lib\avformat.lib
-- Generating F:\0812\vcpkg\packages\ffmpeg_x64-windows\debug\lib\avutil.lib
-- Generating F:\0812\vcpkg\packages\ffmpeg_x64-windows\debug\lib\postproc.lib
-- Generating F:\0812\vcpkg\packages\ffmpeg_x64-windows\debug\lib\swresample.lib
-- Generating F:\0812\vcpkg\packages\ffmpeg_x64-windows\debug\lib\swscale.lib
-- Generating F:\0812\vcpkg\packages\ffmpeg_x64-windows\lib\avcodec.lib
-- Generating F:\0812\vcpkg\packages\ffmpeg_x64-windows\lib\avdevice.lib
-- Generating F:\0812\vcpkg\packages\ffmpeg_x64-windows\lib\avfilter.lib
-- Generating F:\0812\vcpkg\packages\ffmpeg_x64-windows\lib\avformat.lib
-- Generating F:\0812\vcpkg\packages\ffmpeg_x64-windows\lib\avutil.lib
-- Generating F:\0812\vcpkg\packages\ffmpeg_x64-windows\lib\postproc.lib
-- Generating F:\0812\vcpkg\packages\ffmpeg_x64-windows\lib\swresample.lib
-- Generating F:\0812\vcpkg\packages\ffmpeg_x64-windows\lib\swscale.lib
-- Installing: F:/0812/vcpkg/packages/ffmpeg_x64-windows/share/ffmpeg/copyright
-- Performing post-build validation
-- Performing post-build validation done
Building package ffmpeg[bzip2,core,ffmpeg,ffplay,ffprobe,ffserver,gpl,lzma,nonfree,opencl,openssl,vpx,x264]:x64-windows... done
Installing package ffmpeg[bzip2,core,ffmpeg,ffplay,ffprobe,ffserver,gpl,lzma,nonfree,opencl,openssl,vpx,x264]:x64-windows...
Installing package ffmpeg[bzip2,core,ffmpeg,ffplay,ffprobe,ffserver,gpl,lzma,nonfree,opencl,openssl,vpx,x264]:x64-windows... done
Elapsed time for package ffmpeg:x64-windows: 26.19 min
Total elapsed time: 50.21 min

@wangli28
maybe this is an extra validation \ check, from the imported code
https://github.com/microsoft/vcpkg/pull/7129/files
but still there is an extra line feed, and this is not permissible
while I close of course


Improve the release process for UI

Currently to update UI we need to:

in /app run : NODE_ENV=production npm run dist
git add git add ../pipelines/api/app_dist/index.html and git add ../pipelines/api/app_dist/(bundlename)
commit

We should aim for:

Don't have the hash in bundle name
Add an exception to .gitignore for that file.

This is improved so that new UI release process is:

cd app npm run dist
git add ../pipelines/api/app_dist/client/dist/bundle.min.js
git commit
git push


Create pull request to the main branch

Create the PR.

May I do this?

Already did. Thanks anyway.


[bug] No matching signal for on_addPeer_clicked()

Bug Report
Current behavior:
When running dogecoin-qt the following gets logged in debug.log:
GUI: QMetaObject::connectSlotsByName: No matching signal for on_addPeer_clicked()
GUI: QMetaObject::connectSlotsByName: No matching signal for on_removePeer_clicked()
GUI: QMetaObject::connectSlotsByName: No matching signal for on_testPeer_clicked()

Expected behavior
The messages above should be not be logged since the buttons do indeed function correctly.
Steps to reproduce:
Run dogecoin-qt and view debug.log
Dogecoin Core version
Dogecoin Core 1.14.6-3a29ba6d4
Machine specs

OS: Arch Linux x86_64
CPU: Intel Core i5
RAM: 8GB
Disk size: 1TB
Disk Type (HD/SDD): HD

Extra information
The message is misleading since the buttons work as expected. I believe I have a found a potential fix: Qt parses on_<name_of_object>_<action> as a default slot; however, our signal is not default it is manually coded. Renaming all instances of on_addPeer_clicked() in rpconsole.cpp and peerdialog.cpp to on_addPeerClicked() may fix this issue.

Fixed by #3063


Update docs with how to use the Hedera faucet

Problem
The Hedera faucet will be a way to anonymously get testnet hbar and create an account. Docs will need to be updated to capture this new flow.
Solution
Add content for the Hedera faucet and complete the tasks listed in the task list section.
Alternatives
No response
### Tasks
- [ ] https://github.com/hashgraph/hedera-docs/issues/531
- [x] Update getting started with the Hedera faucet flow for anonymous account creation
- [x] Update "Testnet Accounts" under Networks > Testnets

Resolved in 2db233a