☂ eslint-plugin-import

[!WARNING]
This comment is maintained by CI. Do not edit this comment directly.
To update comment template, see https://github.com/oxc-project/oxc/tree/main/tasks/lint_rules

This is tracking issue for eslint-plugin-import.
There are 44(+ 1 deprecated) rules.

3/8 recommended rules are remaining as TODO
33/36 not recommended rules are remaining as TODO

To get started, run the following command:
just new-import-rule <RULE_NAME>

Then register the rule in crates/oxc_linter/src/rules.rs and also declare_all_lint_rules at the bottom.
Recommended rules

  ✨: 5, 🚫: 0 / total: 8

Status
Name
Docs

import/no-unresolved
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-unresolved.md

✨
import/named
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/named.md

✨
import/default
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/default.md

import/namespace
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/namespace.md

✨
import/export
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/export.md

✨
import/no-named-as-default
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-named-as-default.md

✨
import/no-named-as-default-member
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-named-as-default-member.md

import/no-duplicates
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-duplicates.md

✨ = Implemented, 🚫 = Not supported

Not recommended rules

  ✨: 3, 🚫: 0 / total: 36

Status
Name
Docs

import/no-namespace
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-namespace.md

import/no-mutable-exports
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-mutable-exports.md

import/extensions
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/extensions.md

import/no-restricted-paths
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-restricted-paths.md

import/no-internal-modules
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-internal-modules.md

import/group-exports
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/group-exports.md

import/no-relative-packages
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-relative-packages.md

import/no-relative-parent-imports
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-relative-parent-imports.md

import/consistent-type-specifier-style
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/consistent-type-specifier-style.md

✨
import/no-self-import
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-self-import.md

✨
import/no-cycle
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-cycle.md

import/no-named-default
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-named-default.md

import/no-anonymous-default-export
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-anonymous-default-export.md

import/no-unused-modules
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-unused-modules.md

import/no-commonjs
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-commonjs.md

✨
import/no-amd
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-amd.md

import/first
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/first.md

import/max-dependencies
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/max-dependencies.md

import/no-extraneous-dependencies
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-extraneous-dependencies.md

import/no-absolute-path
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-absolute-path.md

import/no-nodejs-modules
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-nodejs-modules.md

import/no-webpack-loader-syntax
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-webpack-loader-syntax.md

import/order
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/order.md

import/newline-after-import
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/newline-after-import.md

import/prefer-default-export
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/prefer-default-export.md

import/no-default-export
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-default-export.md

import/no-named-export
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-named-export.md

import/no-dynamic-require
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-dynamic-require.md

import/unambiguous
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/unambiguous.md

import/no-unassigned-import
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-unassigned-import.md

import/no-useless-path-segments
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-useless-path-segments.md

import/dynamic-import-chunkname
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/dynamic-import-chunkname.md

import/no-import-module-exports

import/no-empty-named-blocks
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-empty-named-blocks.md

import/exports-last
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/exports-last.md

import/no-deprecated
https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/no-deprecated.md

✨ = Implemented, 🚫 = Not supported

Deprecated rules

  ✨: 0, 🚫: 0 / total: 1

Status
Name
Docs

import/imports-first
https://github.com/import-js/eslint-plugin-import/blob/7b25c1cb95ee18acc1531002fd343e1e6031f9ed/docs/rules/imports-first.md

✨ = Implemented, 🚫 = Not supported

Sponsorship link is broken

I think it kind of trivial to implement export rule

It's already implemented, checkboxes are obsolete

It's already implemented, checkboxes are obsolete

updated

@Boshen seems to be for implementing no-named-as-default we need to provide also Atom in ModuleRecord for export_default.

Can I try to add it? Maybe there are other way to do it?

@XantreGodlike To be honest I don't really get this rule, and there's so many issues with it https://github.com/search?q=repo%3Aimport-js%2Feslint-plugin-import+no-named-as-default&type=issues
But for default exports, you may add a Option<Atom> because you can default export a function, which may not have a name.

yarn pnp support is huge for us 🙏🏻 🙏🏻 🙏🏻 🙏🏻 🙏🏻 🙏🏻 🙏🏻 🙏🏻 🙏🏻 🙏🏻 🙏🏻 🙏🏻 🙏🏻

@yordis Is it separate rule?

There is not new-import-rule

There is not new-import-rule

The test cases eslint-plugin-import's aren't static enough for us to convert automatically, all the test cases are ported manually :-(

Regarding yarn pnp support, it's a method of loading dependencies using a cache of zip files rather than the node_modules folder. It uses a custom loader resolution file that exports a generated list of packages and their zip counterparts. More information here: https://yarnpkg.com/features/pnp

I want to tackle the list of super slow rules that use ExportMap in eslint-plugin-import:

default
no-named-as-default-member.js
namespace
no-unused-modules
export
no-deprecated
named
no-cycle
no-named-as-default

Wish me luck.

To port the tests, we'll need to clone eslint-plugin-import, and a console.log console.log(valid.map((test) => test.code)) and copy the code over.

Great news)

After battling cjs / esm for 3 days ... I'm going to cut the scope and focus on ESM only. i.e. Only lint if the imported file is a ESM file.
Most of the rules are working intended unless a CJS file is import, which may contain any kind of bizarre export :-)

Performance wise, we should expect import-plugin + all the other rules finish within a second on a M2.
In a typical project with thousands of files:
AFFiNE canary ❯ ~/github/oxc/target/release/oxlint --import-plugin -D correctness -D no-cycle
Finished in 224ms on 1295 files with 88 rules using 8 threads.
Found 0 warnings and 0 errors.

Maybe a good addition: https://github.com/thepassle/barrel-begone

Sharing some data on how much some ESLint rules take in the world. Would be nice to prioritise the slow ones
Rule                                          | Time (ms) | Relative
:---------------------------------------------|----------:|--------:
import/namespace                              | 27496.040 |    24.5%
@typescript-eslint/await-thenable             |  8834.873 |     7.9%
import/no-extraneous-dependencies             |  8648.620 |     7.7%
@typescript-eslint/no-floating-promises       |  7816.454 |     7.0%
react/destructuring-assignment                |  5010.386 |     4.5%
@typescript-eslint/strict-boolean-expressions |  4807.847 |     4.3%
import/extensions                             |  4265.243 |     3.8%
local/disallow-null-attributes                |  4235.864 |     3.8%
@typescript-eslint/no-unused-vars             |  4053.110 |     3.6%
react/no-this-in-sfc                          |  2530.419 |     2.3%

import/no-unused-modules is useful and should be prioritized.

import/no-unused-modules is useful and should be prioritized.

Not sure if that rule even belongs in a linter or if a separate tool like knip is a better idea: https://knip.dev/


Chore: upgrade flow-bin to latest

This is a preparatory PR to get ready for switching to the new context API as mentioned in #1459. flow-bin has been upgraded along with any other dependency necessary to keep flow checks running properly. All new warnings/errors surfaced by the upgrade (save
for a few $flowFixMe TODOs) have also been corrected.
I will wait to merge/finalize until #1664 has made its way in (to manage conflicts etc...), but wanted to get this PR up just to see if I was even headed in the right direction as well as get reviews/advice.
R/
halvves

I also meant to ask if we could switch from the manually added flow-typed for lodash as that is now throwing an error.

I also meant to ask if we could switch from the manually added flow-typed for lodash as that is now throwing an error.

Refactoring away from any manual typing when a community-managed version is available seems like the right choice to me.

@probablyup - It actually looks like lodash has been removed completely, so I just removed the defs.

@probablyup it looks like the appveyor integration is hanging on eslint for some reason and erroring out after an hour. yarn lint is running fine for me locally and on travis. 😞

@halvves looks like flow-bin v0.73.0 is now out 😄

@halvves let's do the final upgrade and hopefully close this out. Sorry about AppVeyor... it seems to fail in annoying ways.

@halvves Does this force downstream users to also use 0.73 btw or just for local development? If the former, we'll need to bundle this together with the 4.0 release this summer like the Typescript one.

@probablyup - My understanding is that this is merely devDependency. It also looks like we are using rollup-plugin-flow to strip out flow typings on build, so any change in our inner flow code shouldn't be an issue. I would defer to @mxstbr or @kitten just in case though, since I am pretty new to the proj and may have missed something.

@probablyup - really sorry about the appveyor stuff... i hope it wasn't something i did 😬

No no nothing on you - it's always flaky :sigh:

Woot!


Fix#7532: Allow overriding service connection config when ingesting from CLI

Fixes: #7532
Describe your changes :
Added an option to force the overriding entities.
Type of change :

[x] Improvement

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers
Ingestion: @open-metadata/ingestion

does this require migration of openMetadataServerConnection? @nahuelverdugo


[Pluralsight] Unable to log in

Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp0icdbhzn\build\youtube_dl\YoutubeDL.py", line 792, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp0icdbhzn\build\youtube_dl\extractor\common.py", line 501, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp0icdbhzn\build\youtube_dl\extractor\common.py", line 405, in initialize
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp0icdbhzn\build\youtube_dl\extractor\pluralsight.py", line 164, in _real_initialize
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp0icdbhzn\build\youtube_dl\extractor\pluralsight.py", line 211, in _login
youtube_dl.utils.ExtractorError: Unable to log in; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

I've the latest version of youtube-dl (2018.09.10)

If any additional information is needed please let me know. I am not able to download. Thanks


6.0 Feedback: LPC not handling error thrown when Thermocycler lid is closed

Overview
When I have a protocol with a Thermocycler in it and the lid is closed, when I perform LPC it throws an unhandled error. When I manually open the lid and rerun LPC I do not get the error.
Current Behavior
See overview
Expected Behavior
Given you are running LPC and the Thermocycler lid is closed.
When I hit the step for LPC to check the Thermocycler
I should get an error saying the lid is closed.
The error should direct me to open the lid.
The error should have a button to continue LPC.
The system should verify that the lid is open and move on with LPC.
If the lid is still closed the error should show again
Steps To Reproduce

Load a protocol that has a thermocycler in it
Make sure the thermocycler lid is closed
Run LPC
When you hit the step to run LPC for thermocycler you will get an error

https://user-images.githubusercontent.com/20705756/178536687-09fdebd8-0c39-4157-b24f-8befc361def3.mp4
Operating system
Linux
Robot setup or anything else?
No response

The error is due to a 410 from
POST to
http://<IP_ADDRESS>:31950/modules/TCV0220211102A02
{"command_type":"open","args":[]}
response is
{"message":"This endpoint has been removed. Use POST /commands instead."}

Closed by #11111


Create design library base repository.

As a developer I need a design library to reliably build the UIs based on app design guidelines.
Acceptance criteria

Design library repository with public available methods to be implemented.

https://github.com/tiki/style


[#1192] Hide dex tiebreakers in combat tracker

Modifies context preparation on CombatTracker5e to drop any decimal digits after the initiative value.

I turn on the Initiative Dexterity Tiebreaker setting in my game but never liked the information leakage. I've been tempted to fix this myself but never liked the solutions I came up with. I was thinking of ways to change the sorting algorithm but this is much cleaner. Keep the underlying data the same but just don't show it by rounding the number when prepping the data.


trivy: 0.18.0 -> 0.18.1

Motivation for this change
Bump trivy to 0.18.1
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 122894 run on x86_64-linux 1

1 package built:

trivy

/marvin opt-in
/status needs_reviewer


[BUG] How to merge pull requests with groups of contributors in feature branches

Describe the bug
The Identity project contributors are not maintainers in OpenSearch, they have a feature branch is for building up and prototyping features.  How can these contributors apply their own gates and merge their pull requests?
Desired solution
Grant 'feature branch maintainership' to the contributors on this project.
Additional context
While one member (me) of the group does have authority to merge pull requests, this effectively bottlenecks the team on one person.
While the integration with CI is useful, shifting to a full fork where everyone can have maintainer access seems much better for rapid iteration.

FYI @opensearch-project/security created this issue based on our discussion today

Thank you @peternied.
To follow-up with more context from the POV of someone who is not a maintainer:
The current situation makes working on any changes to identity slow and challenging. Because Peter is the only one who review/merge PRs and also the only one who can edit issues, we get stuck tagging him a lot and waiting. I think we all understand and appreciate the importance of what maintainership means, and none of us would want to skirt the requirements, but until we are able to earn maintainership in core, it is challening to iterate. As Peter mentioned, we were wondering if we (the @opensearch-project/security maintainers) could have maintainership over just the Identity branch so that we could work more effectively without being full maintainers of core.
Thank you!

@dblock / @CEHENKLE What do you think here?

I don't see a good solution from GitHub where you can grant permissions on branches. I think working on a fork where you administer permissions is probably the best course of action.

@cwperks What do you think spinning up a fork for this effort?

@peternied Where should the fork live if identity went with that approach?

Follow-up on @cwperks question. Will the opensearch-project be create a fork of core repo? What would public-visibility look like for the fork?

I am not sure where the best place would be.  One of the teams personal accounts might work, something to look into.


Test Hardhat with EDR in third-party repositories

Depends on

[x] #273

Definition of Done
For quality assurance, we need to test Hardhat with EDR in the following third-party repositories:

[ ] Test in OpenZeppelin
[ ] Test in https://github.com/NexusMutual/smart-contracts
[ ] Test in https://github.com/ProjectOpenSea/seaport/
[ ] Test in https://github.com/smartcontractkit/chainlink/tree/develop/contracts
[x] Test in https://github.com/rocket-pool/rocketpool/
[ ] Test in https://github.com/neptune-mutual-blue/protocol
[ ] Test in https://github.com/safe-global/safe-contracts
[ ] Test in https://github.com/taikoxyz/taiko-mono
[ ] Decide whether to test more based on https://www.notion.so/nomicfoundation/Testing-with-real-projects-bd896ef0b11c45fbb41eeb6df16e6584

This can be combined with these performance testing tests

Failures discovered so far:
https://github.com/NomicFoundation/edr/issues/281
https://github.com/NomicFoundation/edr/issues/282
https://github.com/NomicFoundation/edr/issues/283
https://github.com/NomicFoundation/edr/issues/287
https://github.com/NomicFoundation/edr/issues/288

Rocketpool@6a9dbfd8 is 4x faster in EDR mode than with EthereumJS and all tests pass.
Tested with EDR version https://github.com/NomicFoundation/hardhat/commits/30001589a

Safe Contracts@914d0f8 is 1.5x faster in EDR mode than with EthereumJS and all tests pass.
Tested with EDR version https://github.com/NomicFoundation/hardhat/commits/954c6a631

neptune-mutual-blue/protocol@8db6480
Same 29 failures in EJS and EDR mode. ✅
EDR mode is 9% slower due to memory pressure from large state (~60k transactions in the test suite). 👎
uniswap/v3-core@d8b1c63.
All tests pass in EDR mode and there is one failure in EJS mode. ✅
EDR is 1.5x faster. 👍
Tests must be ran with rm -rf test/__snapshots__ && npx hardhat compile && time npx hardhat test, otherwise there are snapshot mismatch errors due to gas cost. This is expected.
synthetix@9a3a109f
Test failures due to lack of Smock support and one sporadic failure in EDR mode. ❌
When running a subset of tests where EDR succeeds (npx hardhat test --grep "Perps"), EDR is 3x faster. 👍
EDR starts swapping with state cache size 64 on a full test run, had to be reduced to 10. Need to revisit once a full test run passes. 👎
seaport@4f4e7c20
Same test fails in EDR and EJS mode ✅ , but the the cause of the failures is different. In EJS mode the returned value doesn't match the expected, in EDR mode it fails, because the test accesses a private property of the VM. I think it's ok to ignore this.
EDR is 20% faster. 👍

NexusMutual/smart-contracts@e0294fa4
Doesn't run with edr/main Hardhat in either EJS or EDR mode due to hardhat-tracer error: ❌
Require stack:
- /home/ubuntu/dev/smart-contracts/node_modules/hardhat-tracer/dist/src/utils/check-opcodes.js
- /home/ubuntu/dev/smart-contracts/node_modules/hardhat-tracer/dist/src/utils/index.js
- /home/ubuntu/dev/smart-contracts/node_modules/hardhat-tracer/dist/src/chai/message-call.js
- /home/ubuntu/dev/smart-contracts/node_modules/hardhat-tracer/dist/src/chai/index.js
- /home/ubuntu/dev/smart-contracts/node_modules/hardhat-tracer/dist/src/index.js
- /home/ubuntu/dev/smart-contracts/hardhat.config.js/index.js
- /home/ubuntu/dev/smart-contracts/node_modules/hardhat/internal/core/config/config-loading.js
- /home/ubuntu/dev/smart-contracts/node_modules/hardhat/internal/cli/cli.js
- /home/ubuntu/dev/smart-contracts/node_modules/hardhat/internal/cli/bootstrap.js
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:1134:15)
    at Function.Module._load (node:internal/modules/cjs/loader:975:27)
    at Module.require (node:internal/modules/cjs/loader:1225:19)
    at require (node:internal/modules/helpers:177:18)
    at Object.<anonymous> (/home/ubuntu/dev/smart-contracts/node_modules/hardhat-tracer/src/utils/check-opcodes.ts:1:1)
    at Module._compile (node:internal/modules/cjs/loader:1356:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1414:10)
    at Module.load (node:internal/modules/cjs/loader:1197:32)
    at Function.Module._load (node:internal/modules/cjs/loader:1013:12)
    at Module.require (node:internal/modules/cjs/loader:1225:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/ubuntu/dev/smart-contracts/node_modules/hardhat-tracer/dist/src/utils/check-opcodes.js',
    '/home/ubuntu/dev/smart-contracts/node_modules/hardhat-tracer/dist/src/utils/index.js',
    '/home/ubuntu/dev/smart-contracts/node_modules/hardhat-tracer/dist/src/chai/message-call.js',
    '/home/ubuntu/dev/smart-contracts/node_modules/hardhat-tracer/dist/src/chai/index.js',
    '/home/ubuntu/dev/smart-contracts/node_modules/hardhat-tracer/dist/src/index.js',
    '/home/ubuntu/dev/smart-contracts/hardhat.config.js/index.js',
    '/home/ubuntu/dev/smart-contracts/node_modules/hardhat/internal/core/config/config-loading.js',
    '/home/ubuntu/dev/smart-contracts/node_modules/hardhat/internal/cli/cli.js',
    '/home/ubuntu/dev/smart-contracts/node_modules/hardhat/internal/cli/bootstrap.js'
  ]
}

chainlink@4c4ac47228
Uses parallel mode. Many test failures. One failure only in parallel mode. ❌
taiko-mono@c1ed8b7
Switched to Foundry, so it's not applicable.

One failure in synthetix@9a3a109f with hardhat@d351c2b50 and smock@f87cb73:
1) Contract: BaseSynthetixBridge (unit tests)
       when all the deps are mocked
         when the target is deployed and the proxy is set
           initiateSynthTransfer
             fails if synth is not enabled:
     AssertionError: expected 'VM Exception while processing transac…' to include 'Transaction reverted without a reason…'
      at Object.assertRevert [as revert] (test/utils/index.js:495:12)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
      at Context.<anonymous> (test/contracts/BaseSynthetixBridge.unit.js:207:6)

This is safe to ignore, because it looks like they're relying on an older bug of Hardhat, where a transaction that reverted with a reason string would show up with a "reverted without a reason" error. (h/t @fvictorio for the explanation.


socket.io.js ?

Thank you for your code! I am new to d3. After deployed your code in my server I found out that socket.io.js is missing, or am I making some mistake? Thanks.

Hey, which version of node do you use?
I've just cloned from repo and did npm install npm start and everything worked well.
Socket.io is already available since it's included in packages configuration.

Thanks! Everything works well now.


social dating css  not loading and anminpanlel 404

ph7 14.0.0 i choose 1st (social dating) that css not loading

How do you want to get help if you don't help yourself !!!
Give us logs, and what you're running on !
Do you use modsecurity-crs?
On September 26, 2018 7:44:32 AM EDT, rimer10<EMAIL_ADDRESS>wrote:

ph7 14.0.0 i choose 1st (social dating) that css not loading
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/pH7Software/pH7-Social-Dating-CMS/issues/315

--
Polyna-Maude R.-Summerside

@rimer10  Although I already said it, can you make sure that the .htaccess has been correctly been uploaded to the root directory.

And that Apache mod_rewrite is CORRECTLY setup https://ph7cms.com/doc/en/how-to-install-rewrite-module

@rimer10 Please let me know if this issue is solved?

@rimer10 Because you didn't get back to me, I assume this issue is solved by now.
Please reopen it if it isn't the case.


feat!: upgrade to v4x.x.x

Base branch for all of the v4.x.x changes

note: gonna hold off on merging this until we have all of the v4.x.x changes in here. Still need to wrap up the docs gen, some breaking method changes, and docs refactoring


build: remove qt4 from macros

Removes Qt4 from bitcoin_qt.m4, so that the build fails at configuration when no Qt5 is found.
The result is that ./configure on a system where only Qt4 is installed fails with:
configure: error: Qt dependencies not found

Note that this retains most now-single-option conditionals intact, as those could be helpful for future Qt6 adoption. As an exception to this, I've removed the condition around Widgets and PrintSupportPlugin as those were only conditional because Qt4 doesn't have these modules, but for Qt5 and onward they are mandatory.
This can be done independently from #3462

Do you have a system in mind where only Qt4 is available? Asking for a friend who is comfortable writing his own Dockerfile to test that case too.

Do you have a system in mind where only Qt4 is available?

You can test Qt4 with Debian 10 (final Debian version where that was shipped) and simply not install Qt5.

Asking for a friend who is comfortable writing his own Dockerfile to test that case too.

No need to write another Dockerfile - I provided one a few weeks ago with #3427

With that Dockerfile, I see as expected:
configure: error: Qt dependencies not found


Forgot Password

I forgot my password, I logged into the server using docker exec -ti actual-server sh, but I can't seem to find the location where the password is stored. Can anyone advice? Thanks!

Hey @notflip,
Take a look at these files
https://github.com/actualbudget/actual-server/blob/master/util/validate-user.js
https://github.com/actualbudget/actual-server/blob/master/sql/account.sql
That should give you some idea of where to look
Cheers
Rich

Thanks @rich-howell I looked at the docker setup but I'm not sure as to where I can get to the actual data. Should I look for an sqlite file inside the docker container and open that to change the password? Thank you

There should be a SQL Lite database on your local machine which you can edit, it is stored in the browser storage. If you inspect actual web you should be able to see it (I am not on a computer with actual at the moment so can't screen shot)

@rich-howell Great, I managed to open accout.sqlite, I see a hashed password there, what type of hash is used? Then I can set a new one!

@notflip make a backup of it first and I think if you delete it you should be prompted to create a new one when you load actual....

It worked! Thank you very much @rich-howell

fwiw the password uses bycrypt: https://github.com/actualbudget/actual-server/blob/master/app-account.js#L16


removed custom dbclick zoom behaviour

I misunderstood what was expected for double click behavior. I removed custom behavior written in Mapzen.js.
closes #252

I’m having some trouble testing this. dist/index.html is showing a blank screen, and Wikimedia's GeoIP lookup server is dead. Are the build instructions up to date?

We decided to move examples to dedicated folder examples. Did you check if your index.html is left over from old build process?  (We probably can add examples folder to circle artifacts to make check easier)

It must have been left over. Looking at examples/index.html, I do see the correct new behavior.


Retry build of v1.2.6 as it does not seem to be in conda-forge

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin, please rerender


feat(random): add random-integer

Porting integer sub-command in random
Finally! This is the last random command on the porting list.
It is not currently on the porting list, but there is a uuid in the sub-command of random.
Would it be better to port this too? If it does, it would be fine to do it with this PR because the amount of code is very small.

@jaeheonji yes, we would like 100% feature parity with nushell. So, yes, if random uuid is missing we'd like to port it.

Hi @fdncred ! Thanks for answering my question.
Since the implementation of uuid is simple, I pushed a commit to this PR. :)

Looks good!


feat(config): Modified default scrapers for hostmetric receiver in the sample config

Proposed Change
Added the following scrapers to the host metric receiver in the sample config:

filesystem
memory
network
cpu
disk

Added notes in config that cpu and disk are not compatible on MacOS. See table in Getting Started of hostmetric receiver.
Checklist

[x] Changes are tested
[ ] CI has passed

Process metrics are very popular for us, but require root / Administrator, it might be worth adding process (commented out, with an explanation)?

@jsirianni We chose not to add those in as they don't work for everyone out of the box and we wanted a config that always works on install to validate the collector.
I'm unsure if I want to add these in commented out. We do link to the receiver docs at the top. Were you thinking of a more comprehensive explanation or more something simple like below?
# Uncomment the below section to get process level metrics. You'll need to restart the collector with root/Administrator permissions
process

If you have something better would you mind sharing and I'll add it in.

Process metrics are very popular for us, but require root / Administrator, it might be worth adding process (commented out, with an explanation)?

@jsirianni We chose not to add those in as they don't work for everyone out of the box and we wanted a config that always works on install to validate the collector.
I'm unsure if I want to add these in commented out. We do link to the receiver docs at the top. Were you thinking of a more comprehensive explanation or more something simple like below?
# Uncomment the below section to get process level metrics. You'll need to restart the collector with root/Administrator permissions
#process:

If you have something better would you mind sharing and I'll add it in.

That makes sense. There is some extra configuration that would be required, and I suppose that is already covered here: https://github.com/observIQ/observiq-otel-collector/tree/main/config/google_cloud_exporter/hostmetrics


Assignment 2: questionnaire-a

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding assignment 2: questionnaire-a.
What did you learn from the changes you have made?
I've learned how to define the purpose of the survey, the population, sampling frame, sampling units and observational units.  To think about what questions could be asked to better understand the problem and define possible solutions.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist

[x] I can confirm that my changes are working as intended

A2: INCOMPLETE
Please specify the sampling strategy and justify it (SRS/STRATA/CLUSTER, etc...)
I would also avoid open ended questions on a questionnaire as the follow up analysis on such questions can be very difficult.

@Melokazz the questionnaire has been updated, please check it out. Thank you.

A2:PASS


Onboarding Request

Your Twitch username
gornygon

Hello, I apologize for the long reply. I just now saw your post in the thread and added you in discord afterwards

Added you, thanks


Cloud Storage and Firestore issue

Whenever I create Cloud Firestore database in my project, Cloud Storage gets enabled too. By default, Cloud Storage security rules say that any authenticated user can read or write to the database. I have been receiving traffic for a long time without knowing, until the console showed me its statistics. I am on the Blaze plan. I'm spending money on a product that I don't want to use. Is there any way to delete the storage bucket altogether?
PS ~ How to use Cloud Storage for the Web

Please reply.


MDL checkboxes don't work with column-count

I made a page with a few mdl-checkbox instances, and then wrapped them in a <div style="column-count: 2"> to make two nice columns.  They all look fine, but the checkboxes in the second column don't work quite right.
Here's an example: http://codepen.io/anon/pen/eJMxpQ
In Safari 9, I get 3 checkboxes in the first column, and 1 checkbox in the second column.  The first 3 checkboxes work great.  The one in the second column is funny.  The border of the box does change from gray to blue and back, but it never fills.  When you click the box, the "touch" circle appears in both the bottom of the first column, and in the second column.

In Firefox, when using the -moz- prefix, they work great.
In Chrome, when using the -webkit- prefix, they are broken in the same way as Safari, except that the "touch" circle never appears at all.
I haven't tried Explorer yet.
I'm using MDL 1.0.6, and the latest version (AFAIK) of each of these browsers.

Very interesting bug report, thank you @kengruven. I don’t think we have tested against column styles at all. Not sure if we can/will fix this in the MDL 1 timeline, as we are about to start working towards v2, but we will definitely keep this in mind.
@sgomes @addyosmani WDYT?

It is also worth noting that columns still have bugs so this could be stumbling into the same kind of territory.
Deeper investigation is needed here. Also, it should certainly not be something to look at in 1.x as far as a blocking bug since the column specification is still not a candidate recommendation. It is development technology and people building with it should understand that. We should keep it in mind when building for 2.x, but remembering it may still have bugs itself within engines.

Agreed, this would be 2.0 work if anything.

Yeah, I didn't realize column-count was still so experimental.  I saw an unprefixed selector, and I checked caniuse.com and didn't see any issues related to what I was seeing, so I assumed it should be safe.
If this isn't actually MDL-related, then feel free to close this issue.


Give the option of outputting the region coordinates to geojson.

Default is the current, which is just the hull.
This is necessary if we want the gene assignment stage to be its own pipeline stage, since this is the output of segmentation and the input for gene assignment.

Codecov Report

Merging #100 into master will increase coverage by 0.02%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage    68.9%   68.93%   +0.02%
==========================================
  Files          24       24
  Lines         981      985       +4
==========================================
+ Hits          676      679       +3
- Misses        305      306       +1

Impacted Files
Coverage Δ

starfish/munge.py
76.36% <83.33%> (-0.11%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44832a6...0580df7. Read the comment docs.


AAU Report template

I am submitting

[x] a new package
[ ] an update for a package

Description: Explain what the package does and why it's useful.

I have read and followed the submission guidelines and, in particular, I

[x] selected a name that isn't the most obvious or canonical name for what the package does
[x] added a typst.toml file with all required keys
[ ] added a README.md with documentation for my package
[ ] have chosen a license and added a LICENSE file or linked one in my README.md
[ ] tested my package locally on my system and it worked
[x] excluded PDFs or README images, if any, but not the LICENSE

[x] ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

Note: I need to finish the remaining tasks before ready for review

Closing this due to inactivity. Feel free to reopen when it's ready.


[WIP] docs(quickstart): quickstart revised with verbose mode toggle button

@naomiblack @kwalrath  ... ready for your review

This looks ok to ship as an interim solution while we work on expandos. Like the thinner sidebar lines.

Added to this PR the plunker image revision requested by @naomiblack  and related changes; see 12500eb


Fix false positive ExampleLength offense when skipping/pending a group example

The ExampleLength raise a false positive offense when using pending or skip on example group.
Example:
# Cop config => { "Max": 4 }

pending "#total_count" do
  let(:store) { create(:parkstoreing) }

  it "returns the number of eligible car" do
    create(:car, :qualified)
    create(:car, :disqualified)
    create(:car, :test)
    expect(subject.total_count).to eq(1)
  end
 end

 => RSpec/ExampleLength: Example has too many lines. [7/4]
  pending "#total_count" do ...
  ^^^^^^^^^^^^^^^^^^^^^^^^^

Whereas using regular example group (eg: describe) does not raise an offense.
This PR is a proposal to fix this behaviour by excluding node example group from the check_code_length method.
Let me know!
Thanks.

Before submitting the PR make sure the following are checked:

[X] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[X] Added tests.
[x] Updated documentation.
[X] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

[ ] Added the new cop to config/default.yml.
[ ] The cop is configured as Enabled: pending in config/default.yml.
[ ] The cop is configured as Enabled: true in .rubocop.yml.
[ ] The cop documents examples of good and bad code.
[ ] The tests assert both that bad code is reported and that good code is not reported.
[ ] Set VersionAdded: "<<next>>" in default/config.yml.

If you have modified an existing cop's configuration options:

[ ] Set VersionChanged: "<<next>>" in config/default.yml.

skip works coincidentally, as the block contents isn't executed.
pending fails with an obvious error. RSpec pending doc. pending is not purposed to include examples, as it is an example itself.
Use xdescribe for skipping whole example groups.


not load pretrain in nets/test.py

i cannot load pretrained model in file nets/test.py

i cannot load pretrained model in file nets/test.py

sorry, forget to update test.py for tensorflow2.1 , I will be done in recently.

i cannot load pretrained model in file nets/test.py
you can fetch and update. I have tested it for image.  Video is not avaiable for me.

i cannot load pretrained model in file nets/test.py
U can update your code, and then retry. There exist bug in tensorflow loader when load weights from grp-model(https://github.com/tensorflow/tensorflow/issues/38698).

i cannot load pretrained model in file nets/test.py

there exist a bug from tensorflow loader. I have hot fixed it. U need to update your repos.


Allow multiple storageclients per namespace

This commit blocks the creation of multiple storageclients for the same provider and allows the creation of multiple storageclients in the same namespace.

/assign @nb-ohad
/assign @jarrpa


Ecto.Changeset.validate_confirmation/3 is not ignoring nil values

Elixir version
1.14.2
Database and Version
PostgresSQL 14.2
Ecto Versions
3.9.2
Database Adapter and Versions (postgrex, myxql, etc)
0.16.5
Current behavior
The function docs states that a nil value would not append an error to the changeset:

Note that if the confirmation field is nil or missing, this does  not add a validation error.

If the confirmation key is missing, the error is not appended as expected. However, if the confirmation key is present and it has a nil value, the error is added:
data  = %{}
types = %{password: :string}
params = %{"password" => "asdf", "password_confirmation" => nil}

changeset =
  {data, types}
  |> Ecto.Changeset.cast(params, [:password])
  |> Ecto.Changeset.validate_confirmation(:password)

returns
#Ecto.Changeset<
  action: nil,
  changes: %{password: "asdf"},
  errors: [
    password_confirmation: {"does not match confirmation",
     [validation: :confirmation]}
  ],
  data: %{},
  valid?: false
>

Expected behavior
When the confirmation key is present and it has a nil value, no error should be added to the changeset. Either this, or the documentation should be updated to reflect the current behavior - I am not sure what was the original intent.

If the intent is to ignore nil values, I was wondering if it would make sense to add an empty_values option, just like the one on the cast function.
The reason is to be able to easily ignore an empty string on top of nil.


refactor(receiver): Split message types into separate file

TL;DR
Moved Signal API message types into a dedicated file and improved type organization
What changed?

Created new message.go file to house all Signal API message-related types
Extracted Message, Attachment, and related structs from client.go
Split nested message types into separate structs (ReceiptMessage, TypingMessage, DataMessage)
Added proper type references in the main Message struct

How to test?

Run existing tests to ensure message handling functionality remains intact
Verify Signal API messages are still properly parsed and processed
Confirm all message types (receipts, typing indicators, data messages) work as expected

Why make this change?
This reorganization improves code maintainability by:

Separating concerns between client functionality and message type definitions
Making message types easier to find and modify
Reducing the complexity of the client.go file
Creating a more logical structure for Signal API related types

#29
#28  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Dec 21, 6:42 PM EST: A user merged this pull request with Graphite.


How can we help?
I would like someone else to build the manifest.
Please read and ensure the following

[X] The installer meets the above requirements

Please provide the following information
Download Page Url: https://riseup.net/en/windows
Publisher: Riseup Collective
Package Name: RiseupVPN-installer-0.24.8.exe
Description: VPN Client
Package Version: 0.24.8
Installer URL: https://downloads.leap.se/RiseupVPN/windows/RiseupVPN-installer-0.24.8.exe

[!NOTE]
This is an installer wizard created with Qt Installer Framework.


404 error - Broken docs sub-pages links when opening from the version badge/button.

The version badge/button which provides options to view the docs for different release versions leads to a 404 error page, when used from any of the sub-topic pages (API, Performance etc).

The links are in the wrong format https://sharp.pixelplumbing.com/en/v0.19.0/api-input.html instead of https://sharp.pixelplumbing.com/en/v0.19.0/api-input. I guess the unnecessary .html is added causing this issue.
Browsers Tested

Mozilla Firefox 70.0.1 (64-bit)
Google Chrome Version 78.0.3904.97 (Official Build) (64-bit)

Hi, this looks like a bug somewhere deep inside readthedocs.
I've been meaning to replace it with something like Docusaurus for a while as there are other related problems such as #1451.

The replacement of readthedocs is being tracked at #1974.


Prompt fails to load and terminal session immedately exits

Intermittently I will get in this state where the prompt fails to load and I no longer can open terminals windows. They immediately exit with the below error. The only way to recover is to either reboot or remove the prompt line from my zshrc using TextEdit.
Last login: Thu Oct 12 16:14:38 on ttys001
.znap.prompt:20: process substitution failed: permission denied
zsh(37713,0x1f2f96080) malloc: *** error for object 0x105170cd8: pointer being freed was not allocated
zsh(37713,0x1f2f96080) malloc: *** set a breakpoint in malloc_error_break to debug

[Process completed]

my zshrc
#!/bin/zsh

# change directories without cd
setopt autocd

# source aliases
source ~/.aliases

# source env vars
source ~/.zshenv

# Download Znap, if it's not there yet.
[[ -f ~/.zsh_plugins/zsh-snap/znap.zsh ]] ||
    git clone --depth 1 -- \
        https://github.com/marlonrichert/zsh-snap.git ~/.zsh_plugins/zsh-snap

source ~/.zsh_plugins/zsh-snap/znap.zsh  # Start Znap

# `znap prompt` makes your prompt visible in just 15-40ms!
znap prompt sindresorhus/pure

# `znap source` automatically downloads and starts your plugins.
# znap source marlonrichert/zsh-autocomplete
znap source zsh-users/zsh-autosuggestions
znap source zsh-users/zsh-syntax-highlighting
znap source chriskempson/base16-shell

# `znap eval` caches and runs any kind of command output for you.
eval "$(zoxide init zsh)"

Environment:

OS: macOS
Terminal: Terminal.app, Kitty, iTerm
Zsh version: 5.89
Repo version: main 7741929 Fix handling of git@*:*.git URLs

It fails on this line: https://github.com/marlonrichert/zsh-snap/blob/755566ca73bfe3cc229fe90fcc0ba87d58325771/functions/.znap.prompt#L28
That means it's either a bug in Zsh or something failing on your file system. Please report to the official Zsh mailing list.


feat(rust): enroll adjustments

Change some messages shown to the user.
Refactor how we read the user input. Doing it manually with std::io is error prone and for some reason both stdout and stderr were printed out even if no error occurred.
Also, I've ignored a flaky test on the websocket crate. I'll look into that later on, but at least we won't have to retry jobs so often

This is a good example of something that should be a separate commit.

Also, I've ignored a flaky test on the websocket crate. I'll look into that later on, but at least we won't have to retry jobs so often

This should be a separate commit.

Also, I've ignored a flaky test on the websocket crate. I'll look into that later on, but at least we won't have to retry jobs so often

True, it's ready now!


chore(deps): update pnpm to v9.8.0

This PR contains the following updates:

Package
Type
Update
Change

pnpm (source)
packageManager
minor
9.7.1 -> 9.8.0

Release Notes

pnpm/pnpm (pnpm)
v9.8.0: pnpm 9.8
Compare Source
Minor Changes

Added a new command for upgrading pnpm itself when it isn't managed by Corepack: pnpm self-update. This command will work, when pnpm was installed via the standalone script from the pnpm installation page #8424.
When executed in a project that has a packageManager field in its package.json file, pnpm will update its version in the packageManager field.

Patch Changes

CLI tools installed in the root of the workspace should be added to the PATH, when running scripts and use-node-version is set.

pnpm setup should never switch to another version of pnpm.
This fixes installation with the standalone script from a directory that has a package.json with the packageManager field. pnpm was installing the version of pnpm specified in the packageManager field due to this issue.

Ignore non-string value in the os, cpu, libc fields, which checking optional dependencies #8431.

Remember the state of edit dir, allow running pnpm patch-commit the second time without having to re-run pnpm patch.

Platinum Sponsors

Gold Sponsors

Our Silver Sponsors

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Hywax Assistant.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (b559ec6) to head (7dd6272).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main       #60   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines          146       146
  Branches        26        26
=========================================
  Hits           146       146

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


DCS-925: Agency Notification and Licence Variation forms downladable …

…as Word docs
Previosuly, just like all the other forms, these forms were presented in pdf format.
However it is not clear whether the Licences teams want these word versions after all.
So have made the changes to provide word docs but have also retained the code for the pdf versions.
Will not request a PR until the Licences teams are sure of  what they want.
Ticket put back into the backlog in the meantime.

closed as too old


V10 Typings: update Dialog

resolves #2214

This changeset introduces the following major changes:

Add new disabled property to Dialog.Button
Remove static qualification of Dialog.title. From what I can tell, even in V9 this was not static.
Update Dialog.getData to always return an object and not a MaybePromise. This is the documented behavior in the V10 API docs and, as far as I can tell, also the implementation behavior. Referring back to V9 again, this was also the case back then, it just wasn't documented that way in the V9 API docs.
Add an event parameter to Dialog.submit. Interestingly enough, there seems to be an inconsistency between the V10 API doc and the actual implementation. According to the docs, Dialog.submit can receive an optional event parameter of type PointerEvent. However, the implementation will pass along the event received by Dialog._onClickButton. This parameter is of type MouseEvent, which is the super class of PointerEvent. Thus, in my opinion, we should declare the event parameter of Dialog.submit to be MouseEvent, since there is no obvious guarantee that the value passed to the parameter will always be a PointerEvent.
Add the wait factory which was introduced in V10. I'm not entirely happy with the typing of its return type. I chose Promise<unknown> since it essentially depends on the return types of the callbacks of the buttons. Promise<any> seemed to provide to much leeway in my opinion, and a user should explicitly check what actual types resulted in their use case.

Hi and thanks for the effort put in. I will try and review the code tomorrow.

I know this wasn't correctly done before, but can you please add the typedefs from 10.291 as interfaces in a declare global? (DialogOptions, DialogButton and DialogData)

I just fixed the compile errors unrelated to your changes. Once you rebase/merge the checks here should succeed.

I know this wasn't correctly done before, but can you please add the typedefs from 10.291 as interfaces in a declare global? (DialogOptions, DialogButton and DialogData)

I'm not entirely sure I understand how to do that. If I want to put those interfaces into a declare global, the type checker screams at me (I'm a bit of a TS noob).
Augmentations for the global scope can only be directly nested in external modules or ambient module declarations.ts(2669)

I looked around some other modules for how it is done there. av-config.d.ts start with an export {}; and then has the rest of the file inside a declare global. Would that be the correct way to do it (e.g. add the export {}; and have all of the interfaces and classes inside the declare global)?

I know this wasn't correctly done before, but can you please add the typedefs from 10.291 as interfaces in a declare global? (DialogOptions, DialogButton and DialogData)

I'm not entirely sure I understand how to do that. If I want to put those interfaces into a declare global, the type checker screams at me (I'm a bit of a TS noob).
Augmentations for the global scope can only be directly nested in external modules or ambient module declarations.ts(2669)

I looked around some other modules for how it is done there. av-config.d.ts start with an export {}; and then has the rest of the file inside a declare global. Would that be the correct way to do it (e.g. add the export {}; and have all of the interfaces and classes inside the declare global)?

Yes exactly. Either a single import or export statement turns the entire file into an Ecmascript module.
Since it's not a module now, you could also just write the interface without declare global and it would be globally available. But since the first potential import in the future would turn the file into a module anyway, better to do it now.

Yes exactly. Either a single import or export statement turns the entire file into an Ecmascript module.
Since it's not a module now, you could also just write the interface without declare global and it would be globally available. But since the first potential import in the future would turn the file into a module anyway, better to do it now.

Cool! Thanks for the explanation!

Because I'm seeing this just now: Please don't force push. It breaks Githubs workflow where I could look at just the changes that were made since I last reviewed. Now I have to review everything again.

Ah the tests are failing now. Probably because icon and label are missing from the buttons in the test setup.

Oh sorry for not checking the tests before my last changes, I was kind of in a hurry. I'll fix them ASAP!


Warnings when building multi-target projects

<Project Sdk="FSharp.NET.Sdk;Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFrameworks>net40;netstandard1.6</TargetFrameworks>
  </PropertyGroup>
  <ItemGroup>
    <Compile Include="Lib.fs" />
  </ItemGroup>
  <ItemGroup>
    <PackageReference Include="FSharp.NET.Sdk" Version="1.*" PrivateAssets="All" />
    <PackageReference Include="FSharp.Core" Version="4.*" />
  </ItemGroup>
</Project>

with a minimal library:
module Lib = let f x = f x

Gives the following warning:

C:\Program Files\dotnet\sdk\1.0.0-rc4-004842\Microsoft.Common.CrossTargeting.targets(116,3): warning MSB4011: "C:\Program Files\dotnet\sdk\1.0.0-rc4-004842\15.0\Microsoft.Common.targets\ImportAfter\Microsoft.NuGet.ImportAfter.targets" cannot be imported again. It was already imported at "C:\Program Files\dotnet\sdk\1.0.0-rc4-004842\Microsoft.Common.CurrentVersion.targets (5733,3)". This is most likely a build authoring error. This subsequent import will be ignored. [C:\dev\github.com\org\proj\src\Proj\Proj.fsproj]

C:\Program Files\dotnet\sdk\1.0.0-rc4-004842\Microsoft.Common.CrossTargeting.targets(145,3): warning MSB4011: "C:\dev\github.com\org\proj\src\Proj\obj\Proj.fsproj.nuget.g.targets" cannot be imported again. It was already imported at "C:\Program Files\dotnet\sdk\1.0.0-rc4-004842\Microsoft.Common.targets (127,3)". This is most likely a build authoring error. This subsequent import will be ignored. [C:\dev\github.com\org\proj\src\Proj\Proj.fsproj]

This is non-blocking, and only produces noise during builds. I am using SDK 1.0.0-rc4-004842.

Yes, is an old one after preview3, it really is a build authoring error as warning say.
Can be diagnosed with dotnet msbuild /pp who merge all imported targets/props in a single proj, so should be possibile to understand why. But afaik is annoying with how crossTargeting is done in FSharp.Sdk the part embedded in sdk, the Sdk="FSharp.NET.Sdk

As recommended, but this looks ominous:
> dotnet msbuild /pp:out.xml

Process is terminated due to StackOverflowException.

@neoeinstein well, that a msbuild bug, so please report to github.com/microsoft/msbuild
The command is just dotnet msbuild /pp.
You can save to file using console redirection as dotnet msbuild /pp > out.xml

That said, dont waste lot of time on that, probably it will require an update to fsharp sdk package embedded in cli. And cannot be done for rtm for sure

Ionide also doesn't work when having more than one build target. Logged it here.

For anyone coming to this with 1.0 tooling you can pass /warnasmessage:MSB4011 to suppress the warning.
dotnet build /warnasmessage:MSB4011

I don't however know how to make this work for dotnet run


Update "Use VSTS to Build and Publish to an Azure Web App with Continuous Deployment

We have an out of the box .NET Core task
Hosted Build pool supports project.json and there is a new VS2017 hosted pool image which supports csproj
We have also added a new .NET Core Build template

@damienpontifex would you be able to update? cc @azooinmyluggage

@Rick-Anderson yes I can update. Please assign to me.
I had thought before, but was waiting for the hosted build servers to be updated to 1.0.0 of the cli. Seeing as there are now VS2017 hosted servers, I think this will be alright to go.

@damienpontifex  OK, it's yours. I can't assign you in the UI since you're not a member of the repository.

@Rick-Anderson reading around and wondering whether this article should redirect to the Team Services article here https://www.visualstudio.com/en-us/docs/build/apps/aspnet/aspnetcore-to-azure
That article also needs updating to display the out of the box tasks. But would be better to have one version of the content?
Let me know thoughts and if we should go ahead with this article or pursue updating it on the Team Services doc site?

@damienpontifex  I agree.  @danroth27  @tdykstra  should we update Build and deploy your ASP.NET Core app to Azure

I tried searching to see whether those docs were also accepting contributions, but didn't find anything.

@damienpontifex  arg - the old MS. I'll find the owner.

should we update Build and deploy your ASP.NET Core app to Azure

Yes, and when that's done retire our version, redirect the URL of our version to the VSTS article, and change our TOC to link to the VSTS article.

@tdykstra  @danroth27  Build and deploy your ASP.NET Core app to Azure is in a private repo only MSFT FTE's can contribute. I'm asking them to retire their version and we should migrate it to our open repo.

@tdykstra  can you Remove this and redirect to https://www.visualstudio.com/docs/build/aspnet/core/quick-to-azure


node-sass 4.8.1 can't parse @extend %#{$loading-animation} !optional

Error: build/_css/clay/mixins/_buttons.scss
Error: Invalid CSS after "%": expected selector, was "% !optional"
on line 61 of build/_css/clay/mixins/_buttons.scss
The line:  @extend %#{$loading-animation} !optional;
When I change node-sass version to 4.7.2, this problem was gone.

Can you please provide a copy pastes let example I can use to reproduce
this error locally.
On 13 Mar. 2018 1:37 pm, "Joye Luo"<EMAIL_ADDRESS>wrote:

Error: build/_css/clay/mixins/_buttons.scss
Error: Invalid CSS after "%": expected selector, was "% !optional"
on line 61 of build/_css/clay/mixins/_buttons.scss
The line: @extend https://github.com/extend %#{$loading-animation}
!optional;
When I change node-sass version to 4.7.2, this problem was gone.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/sass/node-sass/issues/2283, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAjZWEL0zZ6_O1yNjj9m24i5b5ZYuspaks5tdzDagaJpZM4Sn_V_
.

This is the content of _buttons.scss
`@mixin clay-button-variant($map) {
$bg: map-get($map, bg);
$border-color: map-get($map, border-color);
$color: map-get($map, color);
$hover-bg: map-get($map, hover-bg);
$hover-border-color: map-get($map, hover-border-color);
$hover-color: map-get($map, hover-color);
$focus-bg: setter(map-get($map, focus-bg), $hover-bg);
$focus-border-color: setter(map-get($map, focus-border-color), $hover-border-color);
$focus-box-shadow: map-get($map, focus-box-shadow);
$focus-color: map-get($map, focus-color);
$disabled-bg: map-get($map, disabled-bg);
$disabled-border-color: map-get($map, disabled-border-color);
$disabled-color: map-get($map, disabled-color);
$active-bg: map-get($map, active-bg);
$active-border-color: map-get($map, active-border-color);
$active-box-shadow: map-get($map, active-box-shadow);
$active-color: map-get($map, active-color);
$active-focus-box-shadow: setter(map-get($map, active-focus-box-shadow), $focus-box-shadow);
$loading-animation: map-get($map, loading-animation);
background-color: $bg;
border-color: $border-color;
color: $color;

@include hover {
	background-color: $hover-bg;
	border-color: $hover-border-color;
	color: $hover-color;
}

&:focus,
&.focus {
	background-color: $focus-bg;
	border-color: $focus-border-color;
	box-shadow: $focus-box-shadow;
	color: $focus-color;
}

&:disabled,
&.disabled {
	background-color: $disabled-bg;
	border-color: $disabled-border-color;
	color: $disabled-color;
}

&:not([disabled]):not(.disabled):active,
&:not([disabled]):not(.disabled).active,
.show > &.dropdown-toggle {
	background-color: $active-bg;
	border-color: $active-border-color;
	box-shadow: $active-box-shadow;
	color: $active-color;

	&:focus {
		box-shadow: $active-focus-box-shadow;
	}
}

.loading-animation {
	@extend %#{$loading-animation} !optional;
}

}`

I simplified the case to
@mixin undelcared-variable-interpolation() {
	.loading-animation {
		@extend %#{$loading-animation} !optional;
	}
}

foo {
  @include undelcared-variable-interpolation()
}

Which still outputs an error in Ruby Sass and Libsass 3.5.0-beta2 (node-sass 4.7.2) "Undefined variable: "$loading-animation"."

This also produces the same message as the original error
$loading-animation: "";
@mixin undelcared-variable-interpolation() {
	.loading-animation {
		@extend %#{$loading-animation} !optional;
	}
}

foo {
  @include undelcared-variable-interpolation()
}

Which gave the same error with Ruby Sass, but not with 3.5.0-beta2 (node-sass 4.7.2).
I'm closing this as it appears the old behaviour in 4.7.2 was actually a bug

I have $loading-animation variable defined in another file.
And I don't know how to send u the whole project.

Please try to create a minimal reproduction if you think it is valid, but it appears that the variables is set to an empty string which is creating invalid placholder class. Previously node-sass didn't throw an error where it should have.
EX: if the viable is set to an empty string, it's equivalent to
	.loading-animation {
		@extend % !optional;
	}

So even though you have the !optional, it will still throw an error because of the invalid/empty placeholder

Thanks a lot. I finally got what you mean.

I probably have the same problem:
@-webkit-keyframes rcToolTipZoomIn {
  @extend .fnrcToolTipZoomIn;
}
@keyframes rcToolTipZoomIn {
  @extend .fnrcToolTipZoomIn;
}

ERROR in ./~/css-loader!./~/sass-loader/lib/loader.js?outputStyle=expanded!./app/style/entry/campulCourseEmpty.scss
Module build failed:
  @extend .fnrcToolTipZoomIn;
         ^
      Extend directives may only be used within rules.
      in /home/works/build/frontend/app/style/component/tooltip.scss (line 166, column 11)
 @ ./app/style/entry/campulCourseEmpty.scss 4:14-239
Warning: Task "webpack:campulCourseEmpty" failed. Use --force to continue.

Aborted due to warnings.

Extend directives may only be used within rules.

@cmal  your code isn't valid Sass


Headers are installed in /usr/local/lib on Linux

When doing a system-wide install some *.hpp and *.impl files are placed in /usr/local/lib. This directory should only be used for compiled libraries and the files are also placed correctly in /usr/local/include/rapidfuzz.
$ DESTDIR=root cmake --build . --target install
Install the project...
-- Install configuration: "Release"
-- Installing: root/usr/local/lib/distance.hpp
-- Installing: root/usr/local/lib/fuzz.hpp
-- Installing: root/usr/local/lib/fuzz.impl
-- Installing: root/usr/local/lib/rapidfuzz_all.hpp
-- Installing: root/usr/local/lib/Hamming.hpp
-- Installing: root/usr/local/lib/Hamming.impl
-- Installing: root/usr/local/lib/Indel.hpp
-- Installing: root/usr/local/lib/Indel.impl
-- Installing: root/usr/local/lib/LCSseq.hpp
-- Installing: root/usr/local/lib/LCSseq.impl
-- Installing: root/usr/local/lib/Levenshtein.hpp
-- Installing: root/usr/local/lib/Levenshtein.impl
-- Installing: root/usr/local/lib/cmake/rapidfuzz/rapidfuzzTargets.cmake
-- Installing: root/usr/local/include/rapidfuzz
-- Installing: root/usr/local/include/rapidfuzz/details
-- Installing: root/usr/local/include/rapidfuzz/details/SplittedSentenceView.hpp
-- Installing: root/usr/local/include/rapidfuzz/details/common.hpp
-- Installing: root/usr/local/include/rapidfuzz/details/common_impl.hpp
-- Installing: root/usr/local/include/rapidfuzz/details/intrinsics.hpp
-- Installing: root/usr/local/include/rapidfuzz/details/matching_blocks.hpp
-- Installing: root/usr/local/include/rapidfuzz/details/type_traits.hpp
-- Installing: root/usr/local/include/rapidfuzz/details/types.hpp
-- Installing: root/usr/local/include/rapidfuzz/distance.hpp
-- Installing: root/usr/local/include/rapidfuzz/distance
-- Installing: root/usr/local/include/rapidfuzz/distance/Hamming.hpp
-- Installing: root/usr/local/include/rapidfuzz/distance/Hamming.impl
-- Installing: root/usr/local/include/rapidfuzz/distance/Indel.hpp
-- Installing: root/usr/local/include/rapidfuzz/distance/Indel.impl
-- Installing: root/usr/local/include/rapidfuzz/distance/LCSseq.hpp
-- Installing: root/usr/local/include/rapidfuzz/distance/LCSseq.impl
-- Installing: root/usr/local/include/rapidfuzz/distance/Levenshtein.hpp
-- Installing: root/usr/local/include/rapidfuzz/distance/Levenshtein.impl
-- Installing: root/usr/local/include/rapidfuzz/fuzz.hpp
-- Installing: root/usr/local/include/rapidfuzz/fuzz.impl
-- Installing: root/usr/local/include/rapidfuzz/rapidfuzz_all.hpp
-- Installing: root/usr/local/lib/cmake/rapidfuzz/rapidfuzzConfig.cmake
-- Installing: root/usr/local/lib/cmake/rapidfuzz/rapidfuzzConfigVersion.cmake

These are the same headers that are specified in PUBLIC_HEADERS variable in CMakeLists.txt. Setting the PUBLIC_HEADER property in CMakeLists.txt line 58 seems to cause the issue and removing the line resolves this bug.
jarowinkler-cpp has a similar issue as it installs jaro_winkler.hpp to /usr/local/lib.

@pekkarr thanks for reporting. After reading the documentation: I am unsure why this was added. I assume I copied this from a different project at the time without understanding what I did :smile:
Removed this both in rapidfuzz-cpp and jarowinkler-cpp.


Daemon Refactoring

This Epic contains all issues related to any outstanding refactoring desired for the daemon portion of this application.

Closing Epic as all attributed issues are handled.
#209


Support custom CSS in forget page

The custom CSS already supports:

Signup: https://door.casdoor.com/signup
Signin: https://door.casdoor.com/login

But not:

Forget: https://door.casdoor.com/forget

@leo220yuyaodog

Fixed by: https://github.com/casdoor/casdoor/pull/1226


JSON variable substitution docs seems incorrect

According to the example JSON file DebugMode, DBAccess and FeatureFlags are all nested inside the Data field. However only the Data.DefaultConnection.ConnectionString variable has the 'Data.' prefix. Am I missing something or is this a mistake.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 315ff823-9992-9f9b-62a1-42ce622ed41c
Version Independent ID: 72ec3ffc-1dc9-b2dc-e3d4-4f14deae3720
Content: File transforms and variable substitution
Content Source: docs/pipelines/tasks/transforms-variable-substitution.md
Product: devops
GitHub Login: @alexhomer1
Microsoft Alias: ahomer

can  i change AppSettings_Dev  name to AppSettings

@chrissena - you are right, here is the updated example. Will get this fixed.
@Kunjahamed-P - No, you can change only the values not the key.
JSON variable substitution example
As an example, consider the task of overriding values in this JSON file:
{
  "Data": {
    "DefaultConnection": {
      "ConnectionString": "Data Source=(LocalDb)\MSDB;AttachDbFilename=aspcore-local.mdf;"
    },
    "DebugMode": "enabled",
    "DBAccess": {
      "Admininstrators": ["Admin-1", "Admin-2"],
      "Users": ["Vendor-1", "vendor-3"]
    },
    "FeatureFlags": {
      "Preview": [
        {
          "newUI": "AllAccounts"
        },
        {
          "NewWelcomeMessage": "Newusers"
        }
      ]
    }
  }
}

Define the required substitution values in release pipeline or stage variables.

Name
Value
Secure
Scope

Data.DebugMode
disabled
No
Release

Data.DefaultConnection.ConnectionString
Data Source=(prodDB)\MSDB;AttachDbFilename=prod.mdf;
No
Release

Data.DBAccess.Users.0
Admin-3
Yes
Release

Data.FeatureFlags.Preview.1.NewWelcomeMessage
AllAccounts
No
Release


search-using-keywords: searching using keywords crashes the app

Describe the bug
Related to #61
On search-using-keywords branch
The app returns you to the Main Activity when you search for an item (using keywords) in the Search Activity.
If you search for an item (using keywords again) in the SearchActivity; the app will crash.
To Reproduce
Steps to reproduce the behaviour:

Search for an item in SearchActivity
App will return you to main menu
Search for an item in SearchActivity again.
App crashes.

Expected behaviour
I expect that the app will make an API call to AllGoods, receive a successful response, update the SearchViewModel searchResponse to hold the response from AllGoods, and update the UI to show the items that have been searched for (and only those items).
Device (please complete the following information)

Device: Pixel 2
OS: API 29
App Version: HEAD of search-using-keywords

Additional context
The behaviour for the first 5 of 6 ticked boxes in #61 seems to be working fine.
Removing the following in SearchViewModel.applyFiltersAndSearch() will stop crashing, but could cause issues for other features.
searchListingsResponse = null

Crash exception
E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.sthoray.allright, PID: 5111
    kotlin.KotlinNullPointerException
        at com.sthoray.allright.ui.search.view.ResultsFragment$scrollListener$1.onScrolled(ResultsFragment.kt:121)
        at androidx.recyclerview.widget.RecyclerView.dispatchOnScrolled(RecyclerView.java:5173)
        at androidx.recyclerview.widget.RecyclerView.dispatchLayoutStep3(RecyclerView.java:4231)
        at androidx.recyclerview.widget.RecyclerView.dispatchLayout(RecyclerView.java:3862)
        at androidx.recyclerview.widget.RecyclerView.onLayout(RecyclerView.java:4404)
        at android.view.View.layout(View.java:22844)
        at android.view.ViewGroup.layout(ViewGroup.java:6389)
        at androidx.constraintlayout.widget.ConstraintLayout.onLayout(ConstraintLayout.java:1695)
        at android.view.View.layout(View.java:22844)
        at android.view.ViewGroup.layout(ViewGroup.java:6389)
        at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
        at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
        at android.view.View.layout(View.java:22844)
        at android.view.ViewGroup.layout(ViewGroup.java:6389)
        at androidx.constraintlayout.widget.ConstraintLayout.onLayout(ConstraintLayout.java:1695)
        at android.view.View.layout(View.java:22844)
        at android.view.ViewGroup.layout(ViewGroup.java:6389)
        at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
        at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
        at android.view.View.layout(View.java:22844)
        at android.view.ViewGroup.layout(ViewGroup.java:6389)
        at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1829)
        at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1673)
        at android.widget.LinearLayout.onLayout(LinearLayout.java:1582)
        at android.view.View.layout(View.java:22844)
        at android.view.ViewGroup.layout(ViewGroup.java:6389)
        at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
        at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
        at android.view.View.layout(View.java:22844)
        at android.view.ViewGroup.layout(ViewGroup.java:6389)
        at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1829)
        at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1673)
        at android.widget.LinearLayout.onLayout(LinearLayout.java:1582)
        at android.view.View.layout(View.java:22844)
        at android.view.ViewGroup.layout(ViewGroup.java:6389)
        at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
        at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
        at com.android.internal.policy.DecorView.onLayout(DecorView.java:784)
        at android.view.View.layout(View.java:22844)
        at android.view.ViewGroup.layout(ViewGroup.java:6389)
        at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:3470)
        at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2938)
        at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1952)
        at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:8171)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:972)
        at android.view.Choreographer.doCallbacks(Choreographer.java:796)
        at android.view.Choreographer.doFrame(Choreographer.java:731)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:957)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:223)
        at android.app.ActivityThread.main(ActivityThread.java:7656)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)

The crash is due to the not null assertion operator (!!) in the scrollListener. The listener may be called when the keyboard disappears after searching, at which stage searchListingsResponse is already set to null.
A solution would be to only perform the onScrolled function when searchListingsResponse is not null. Possibly creating a new local variable resultsPerPage inside ResultsFragment would work better. In which case resultsPerPage could be set when a successful resource is observed and remove pagings dependancy from a resource which would stop paging from working if only one request failed: e.g. user lost mobile connectivity.
Aside: the keywords branch looks to be significantly behind master with lots of potential conflicts. I would consider merging the changes into your branch or intergrate your changes onto a new branch from the latest master.


Update laravel-mix Peer Dependency to v5.0.0

This package's latest version has a peer dependency on laravel-mix": "^4.0.0. So npm always warns when using with laravel-mix >=v5.0.0. As far as I see everything is running fine, so you might just update the dependency.
Or are there any potential problems?

Thanks for letting me know. I'll run some tests and update the dependency if everything's OK.

The peer depencency has been updated in v1.1.1. Thanks.


Lazy loading reuses marker composables with the same ID

When using RenderingStrategy.LazyLoading, if I add a marker, let it be displayed for a while, then remove it and add another marker with the same ID, the composable from the removed marker appears on the specified coordinates instead of the new one.
This doesn't happen in any of the following cases:

If I use the default rendering strategy.
If I add and remove the first marker immediately.
If I add a delay between removing the old marker and adding the new one. The higher the delay, the less are the chances for this to happen, but it seems like it should be 10 ms at least.

I reproduced the bug in the demo app here -- on tap A should disappear and B should appear, but in reality, A appears again.

From my testing, this also happens using the default rendering strategy.
This is due to how the library considers a marker to be identical to another. Three parameters are compared: id, x, and y.
If a marker with id "id" is removed then added using the same id and position, it's not considered a different marker, even though the composable function associated with it is different. The behavior you observed using a delay can also be explained. When there's a delay between the removal and the addition of B, the compose machinery has the time so see to different values for the list of markers.
To my knowledge, there's no way to identify a composable function. Comparison must be done based on other parameters (here, the id and position).
My recommendation is: use a different id for the marker B. If needed, you could even ensure uniqueness for each newly created marker using UUID.randomUUID().

Thanks for the explaination, but I'm experiencing this even when the markers have different coordinates. I actually intended to show this in the demo, but copy-pasted the coordinates accidentally. If you run the demo from this commit, you can see that A and B have different coordinates but A appears instead of B again.

I could reproduce. For the moment, I can see that an assumption made in the lazy loading and clustering strategies is responsible for that particular behavior.
I have a fix, which would make B appear on tap. However, I'm not comfortable fixing that particular case while still requiring the user to provide a different id when the position doesn't change. It simply isn't consistent. So I'm working on a solution which works even when the id does not change.

I've created the branch try-fix-#71. Could you try it out and tell me if that also fixes issues for you?

Yep, now it updates the composable even when the same coordinates are used, thanks.


Upgrading from v3.0.3 to v4.0.1

I'm trying to update the bundle to latest version, since I'm having weird issues (sometimes password decryption takes longer than 30seconds and make the server not respond, or right now using form_widget(form.smtpPassword) has weird behavior where is includes another twig file.....I have no idea why).
The problem is it says halite v4.5.1 requires php 7.2 and I'm using php 7.1...Is there a way to use php7.1 ?
I have tried v4.0.0 but, it has the constructor not matching the interface.

halite uses libsodium, and libsodium is only available in php 7.2


Installation Instructions

I'd love to see slightly longer installation instructions. Maybe even in the Readme file, or in another file that the Readme links to?
Since writing stuff is a chore, I figured I'd write up one possible option:
Installation
Go to releases and download the latest noita-proxy-win.zip or noita-proxy-linux.zip, depending on your OS.
Unpack it, and launch the proxy. Proxy is able to download and install the mod automatically.

Then, start Noita, and enable the mod.

In the "Mods" menu, enable unsafe mods
Then, enable the "Quant's Entangled Worlds" mod.

Now you're ready to start a server and have fun!
Connect using Steam
In the Proxy window, click on "Create Lobby". Then, "Save lobby ID to clipboard". Send that ID to your friends, who can then copy it and press "Connect to lobby in clipboard".

After that, just start a new Noita game on everyone's PCs, and you should be in multiplayer mode :)

Also, thank you and everyone involved so much for this absolute masterpiece of a mod. This is a dream come true for me. <3

Thanks for providing detailed installation instructions, I've added them to readme.


Server Location Feature[BUG]

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
The See server location when joining a game feature doesn't work at all, And I don't know how to fix it.

i have problem that when i open bloxstrap my roblox shows error crash but roblox background is complete fine but when i try to join game it closes instantly??

Does rich presence work?

Does rich presence work
my fault I had to right click on bloxstrap for server details, I can see the region and all of that
Thanks!

Check your Windows notification settings to make sure that notifications aren't being suppressed (i.e. if you're on Do Not Disturb)


Make Argo CD admin in environments managed by kam

What type of PR is this?

/kind enhancement

What does this PR do / why we need it:
The Kam CLI should generate role bindings for each environment that makes argocd an admin in that environment. The rolebinding file argocd-admin.yaml will be generated during bootstrap and while adding environments
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
  creationTimestamp: null
  name: argocd-admin
  namespace: prod
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: admin
subjects:
- kind: ServiceAccount
  name: argocd-cluster-argocd-application-controller
  namespace: openshift-gitops

It also generates a cluster role that aggregates sealed secrets to the OpenShift admin cluster role. This should be removed once it's fixed in upstream sealed secrets operator,
Have you updated the necessary documentation?

[x] Documentation update is required by this PR.
[x] Documentation has been updated.

Which issue(s) this PR fixes:
Fixes https://issues.redhat.com/browse/GITOPS-500
How to test changes / Special notes to the reviewer:

Follow kam Day 1docs
Observe the following new files generated during bootstrap

config/cicd/base/02-rolebindings/argocd-admin.yaml # make argocd admin in cicd environment
config/cicd/base/02-rolebindings/sealed-secrets-aggregate-to-admin.yaml # add sealed secrets to admin cluster role
environments/dev/env/base/argocd-admin.yaml # make argocd admin in dev environment
environments/stage/env/base/argocd-admin.yaml # make argocd admin in stage environment

After applying resources, argocd should sync all the applications successfully without cluster-admin privileges

Looks good.  Let's hold until GitOps v1.0.1 is shipped.

/lgtm
/approve

/retest


USB backend: do not report IPP-USB printers when ippusbxd is available

@bitwombat reported issues printing to a Brother printer via USB: Apple Issue #5908
Basically, this is an AirPrint printer that supports IPP-USB. When connected, ippusbxd claims the endpoints used for IPP-USB, which happen to also be the endpoints needed for legacy USB printing. Therefore, the USB backend can see it but not access (claim) it.
We should hide such printers so that the IPP-USB listing gets used. And in particular that means the IPP Everywhere driver can be used instead of a vendor driver.
Possible solutions:

When we see that a USB printer supports protocol 4 (IPP-USB), see if that endpoint/device is already claimed and if so skip it. (not sure libusb offers this functionality)
When we see that a USB printer supports protocol 4 (IPP-USB), see if ippusbxd is present and if so skip it (might not work so well for snapped CUPS)
Add a configure option that enables code in the USB backend to skip IPP-USB printers ("--with-ipp-usb")

Option 1 is probably the best solution, then 3.

Actually, it would be better if ippusbxd did not claim the IPP-USB interfaces until a connection comes in.
Transferring this to the cups-filters project.


Change HTTP Links to HTTPS in /docs/build-instructions/

Description of the Change
Change HTTP links to HTTPS in /docs/build-instructions/ since the linked-to sites support SSL/TLS
Alternate Designs
The alternative would be leaving the links as HTTP ones. This leaves users less secure while having only marginal userexperience benefits.
Why Should This Be In Core?
The documentation changed is in Core.
Benefits
Makes user interaction more secure by default.
Possible Drawbacks
Marginal potential for devices not supporting SSL/TLS and marginal performance hits when accessing the links.
Applicable Issues
Similar to issue #16167 and PR #16173

Great work as usual @U8NWXD.


Avoid "sanity" terminology in OTBN UVM code

This relates to Cindy's PR #4143. Since things are moving around quite a bit in the OTBN tree, it seemed to make sense to apply the proposed changes just here. I also wanted to rename the "sanity" sequence to "single" anyway, so thought the history might look less confusing if I did that first.

Force-push rebases over recently merged changes.


Extend scrubbing for authorization and Bearer token

What does this PR do?
Extend scrubbing for authorization and Bearer token.
QA
Set in an integration configuration:
instances:
- something: Bearer 012-345-678
  something2: Bearer 2fe663014abcd1850076f6d68c0355666db98758262870811cace007cd4a62ba
  authorization: 38bdae31-f5fb-4e7d-bf2e-1d2c8fe78b81
  [...]

Run the configcheck CLI and check the fields are correctly scrubbed:
instances:
- something: Bearer  ********
  something2: Bearer ***********************************************************a62ba
  authorization: "********"`)
  [...]

/merge


Scene Refactor

Refactors the Scene's private executeCommands function. Separates primitive updates, framebuffer updates/clears, draw command executions, and framebuffer resolves.
Add ability to change the default viewport per pass. All commands will be executed in the default viewport unless overridden by the render state (e.g.  post-processing).

Just those minor comments.  Does this need new tests to have full coverage?

Does this need new tests to have full coverage?

It doesn't need any new tests. When there is a public API to change the viewport/camera/etc, new tests will be needed.
@pjcozzi This is ready.

Looks good.


Added support for innr puck light 115 and ecodim zigbee dimmer

Added support for:

innr puck light 115
ecodim zigbee dimmer

Thanks for the PR! At the same time, the plugin strategy for supporting new devices has been changed from supporting individual devices to support device classes (like light, switches, etc.) after releasing the exposes feature in zigbee2mqtt.
Support for all light devices has been added in the scope of #548 and now available in the master branch. That's why have to close this PR as all individual devices will be removed from the plugin soon.

Thanks for the PR! At the same time, the plugin strategy for supporting new devices has been changed from supporting individual devices to support device classes (like light, switches, etc.) after releasing the exposes feature in zigbee2mqtt.
Support for all light devices has been added in the scope of #548 and now available in the master branch. That's why have to close this PR as all individual devices will be removed from the plugin soon.


chore: release 0.38.1

Fixes

Fix handling of onMouseEnter prop in ChatMessage @layershifter (#1903)
Fix order of applying unhandled props and key handlers @jurokapsiar (#1901)
Fix focus styles for TreeItem and HierarchicalTreeItem @silviuavram (#1912)
Use more accurate positioning for actions in Chat.Message when is inside scrollable containers @layershifter (#1929)
Do not force focus inside focus trap zone on outside focus @sophieH29 (#1930)

Features

Add navigable List variant @jurokapsiar (#1904)
Add the SplitButton component @silviuavram (#1789)

Documentation

Fix broken code editor in some doc site examples and improve error experience @levithomason (#1906)
Add VirtualizedTree prototype @silviuavram (#1890)

Warnings

:warning:
Package (or peer) dependencies changed. Make sure you have approval before merging!

Changed dependencies are detected.
Changed dependencies in packages/code-sandbox/package.json

package
before
after

@stardust-ui/react
^0.38.0
^0.38.1

Changed dependencies are detected.
Changed dependencies in packages/react/package.json

package
before
after

downshift
~3.2.10
^3.2.10

  Generated by :no_entry_sign: dangerJS


Create branch for review

I have implemented the following:

Created a react app and set up the project with linters.
Chose the Quran API.
Rendered list of items on the homepage
Showed details about the item on the Details page.
Added test for the components.
Styled the project
Recorder a video walkthrough
Deployed the project in render.com

Hello @GedeonTS. I don't know why linter checks are not showing up, they are set up correctly, can you clarify what is the problem? As for the second change I don't know what you mean. This branch contains everything I made so far.

Hello @Davidosky007. Sorry but I am a little confused. Each of my item has a name right, so isn't it enough. Also they have name in two languages that I am getting from API. Can you please clarify what you mean.

@Davidosky007. Do you mean that I should have a search input?

@Davidosky007. Do you mean that I should have a search input?

Yes but it should work

@Davidosky007 Yeah but I don't think that is a requirement. The requirement says that on the homepage I should render a list of items that could be filtered by some parameters, which I already have. My items can be filtered by name, number, or englishName.  I think implementing that feature of searching them is optional as it is not stated in the requirements.


Workaround install firesass

Other source map / Sass plugins don't work for a legacy project I'm working on because I lack the necessary requirements.
I got this extension working again by using the github extension installer add on, which will let me complete my project.

I wish this worked for me. Hitting the install button just keeps it spinning and spinning. :(

What version of firefox are you using?

@RandTrawick 35.0.1.


Can't get llama-2 to use gpu on sagemaker

I'm trying to setup llama-2 to run on a notebook instance but I can't get it to use the gpu. Here are the steps I'm running:
conda create -n h2ogpt -y
source ~/anaconda3/etc/profile.d/conda.sh
conda activate h2ogpt
conda install python=3.10 -c conda-forge -y

cd Sagemaker/h2ogpt
pip uninstall -y pandoc pypandoc pypandoc-binary

GPU only:
pip install -r requirements.txt --extra-index https://download.pytorch.org/whl/cu117
Required for Doc Q/A: LangChain:
pip install -r reqs_optional/requirements_optional_langchain.txt
conda install cudatoolkit-dev -c conda-forge -y
export CUDA_HOME=$CONDA_PREFIX

pip uninstall -y llama-cpp-python llama-cpp-python-cuda
pip install https://github.com/jllllll/llama-cpp-python-cuBLAS-wheels/releases/download/textgen-webui/llama_cpp_python_cuda-0.1.73+cu117-cp310-cp310-linux_x86_64.whl

I run python generate.py --base_model='llama' --prompt_type=llama2 --cli=True --score_model=None --langchain_mode=UserData --user_path=user_path --temperature=0 --answer_with_sources=False
which will automatically download llama-2-7b by default.
At this point I get the error:

Could not load Llama model from path: llama-2-7b-chat.ggmlv3.q8_0.bin. Received error Failed to load shared library '/home/ec2-user/anaconda3/envs/JupyterSystemEnv/lib/python3.10/site-packages/llama_cpp_cuda/libllama.so': /lib64/libm.so.6: version `GLIBC_2.29' not found (required by /home/ec2-user/anaconda3/envs/JupyterSystemEnv/lib/python3.10/site-packages/llama_cpp_cuda/libllama.so) (type=value_error)

So next I tried to compile llama-cpp-python with CUDA support instead
pip uninstall -y llama-cpp-python llama-cpp-python-cuda
export LLAMA_CUBLAS=1
export CMAKE_ARGS=-DLLAMA_CUBLAS=on
export FORCE_CMAKE=1
CMAKE_ARGS="-DLLAMA_CUBLAS=on" FORCE_CMAKE=1 pip install llama-cpp-python==0.1.73 --no-cache-dir --verbose

However this gives me the error

ERROR: Failed building wheel for llama-cpp-python
Failed to build llama-cpp-python
ERROR: Could not build wheels for llama-cpp-python, which is required to install pyproject.toml-based projects

And when I try to run python generate.py again it says

ModuleNotFoundError: Could not import llama-cpp-python library. Please install the llama-cpp-python library to use this embedding model: pip install llama-cpp-python

So I run pip install llama-cpp-python which lets me actually run the model for the first time but there's no message saying that it found a gpu nor a message saying how many layers it offloaded like in https://github.com/h2oai/h2ogpt/blob/main/docs/README_GPU.md#exllama

Ya, the compiling of llama_cpp_python is not super trivial, and the binary wheels have specific requirements that may not be met on diverse systems.
The only solution is to try to resolve the compile issue on that specific system.  Your error fragment didn't show the actual error.  You can share and I can try to help.

The error after running CMAKE_ARGS="-DLLAMA_CUBLAS=on" FORCE_CMAKE=1 pip install llama-cpp-python==0.1.73 --no-cache-dir --verbose
  [4/8] Building C object vendor/llama.cpp/CMakeFiles/ggml.dir/ggml.c.o
  ninja: build stopped: subcommand failed.
  Traceback (most recent call last):
    File "/tmp/pip-build-env-v1z_is5y/overlay/lib/python3.10/site-packages/skbuild/setuptools_wrap.py", line 674, in setup
      cmkr.make(make_args, install_target=cmake_install_target, env=env)
    File "/tmp/pip-build-env-v1z_is5y/overlay/lib/python3.10/site-packages/skbuild/cmaker.py", line 697, in make
      self.make_impl(clargs=clargs, config=config, source_dir=source_dir, install_target=install_target, env=env)
    File "/tmp/pip-build-env-v1z_is5y/overlay/lib/python3.10/site-packages/skbuild/cmaker.py", line 742, in make_impl
      raise SKBuildError(msg)

  An error occurred while building with CMake.
    Command:
      /tmp/pip-build-env-v1z_is5y/overlay/lib/python3.10/site-packages/cmake/data/bin/cmake --build . --target install --config Release --
    Install target:
      install
    Source directory:
      /tmp/pip-install-_j2949n2/llama-cpp-python_6347bc7cb4ca4b618c3632ca038b47cf
    Working directory:
      /tmp/pip-install-_j2949n2/llama-cpp-python_6347bc7cb4ca4b618c3632ca038b47cf/_skbuild/linux-x86_64-3.10/cmake-build
  Please check the install target is valid and see CMake's output for more information.

  error: subprocess-exited-with-error

  × Building wheel for llama-cpp-python (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> See above for output.

  note: This error originates from a subprocess, and is likely not a problem with pip.
  full command: /home/ec2-user/anaconda3/envs/h2ogpt/bin/python3.10 /home/ec2-user/anaconda3/envs/h2ogpt/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py build_wheel /tmp/tmpluibla5c
  cwd: /tmp/pip-install-_j2949n2/llama-cpp-python_6347bc7cb4ca4b618c3632ca038b47cf
  Building wheel for llama-cpp-python (pyproject.toml) ... error
  ERROR: Failed building wheel for llama-cpp-python
Failed to build llama-cpp-python
ERROR: Could not build wheels for llama-cpp-python, which is required to install pyproject.toml-based projects

Unfortunately, still don't see an actual specific error here, maybe it was above that block?  E.g. ninja: build stopped: subcommand failed. is generic.
But at least you know it's probably ninja related.  But it's probably going to be something you or someone figures out how to get running, or use different OS type on sagemaker, etc.  Hopefully someone can contribute to this.

sagemaker is added explicitly as llm type now


stable/prometheus-operator - use root context within the loop for .Values.prometheus.prometheusSpec.portName

Signed-off-by: Eugene Brusilovsky<EMAIL_ADDRESS>
Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:
fixes Error: render error in "prometheus-operator/templates/prometheus/serviceperreplica.yaml": template: prometheus-operator/templates/prometheus/serviceperreplica.yaml:34:26: executing "prometheus-operator/templates/prometheus/serviceperreplica.yaml" at <.Values.prometheus.prometheusSpec.portName>: can't evaluate field Values in type int
when .Values.prometheus.servicePerReplica.enabled
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[ ] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @bismarck

/ok-to-test