Tests are failing

Describe the bug
The tests are failing since we changed the templates to the GitHub forms format.

fixed in ef03d57e805e3b9d78ea2d2d1165b4da2792964c.


Delete pub/media folder

Hi, i could integrate the media files with S3 and i saw on the frontend that the products images are loaded thought S3 but when i delete the web server pub/media folder the product move to show the placeholder default image of magento
Before delete pub/media:

After delete pub/media:

What am i doing wrong? i want to delete all web server local image storage

I think that if you delete entere media folder that happend but if you just delete the content of media folder it works!

Hi @mvaisberg,
Are you still having problems with this? My first question would be are you routing your images through pub/get.php?
Regards,
Thai

Closing the ticket due to no response.


Inheritance

Hey,
I have the following C++ classes:
class IComponent
{
virtual void Foo() = 0;
}

class ComponentA : public IComponent
{
void Foo() override;
}

class B
{
void AddComponent(IComponent*);
}

This is how I register the types:
aState.new_usertype<B>("B", &B::AddComponent);
aState.new_usertype<IComponent>("IComponent");
aState.new_usertype<ComponentA>("ComponentA", sol::base_classes, sol::bases<IComponent>());

However, when calling in Lua:
AnInstanceOfB:AddComponent(cp1)
it crashses:
_Container_proxy *_Parent_proxy = _Parent->_Myproxy;
(File: xutility, Error: parent was nullptr)
Seems like abstraction is not yet fully supported?

You must be doing something wrong, it does work for me. Are you using the latest release?
class A
{
public:
    virtual void a() = 0;
};

class B : public A
{
public:
    virtual void a() override { }
};

class C
{
public:
    void wtf(A* a)
    {
        std::cerr << "wtf";
    }
};

int main()
{
    sol::state state;
    state.new_usertype<C>("C", "wtf", &C::wtf);
    state.new_usertype<A>("A");
    state.new_usertype<B>("B", sol::base_classes, sol::bases<A>());
    state.set("b", new B());
    state.set("c", new C());
    state.script("c:wtf(b)");  //Works
}

Can confirm this code works for me. You're going to need to tell me build settings and stuff so I can try to repro properly and get to the root of it.

Checked in fixes for inheritance, so more complex code where you were seeing the issue should behave better. Sorry about that:
https://github.com/ThePhD/sol2/releases/tag/v2.14.2

Hi,
sorry for replying late.
I am currently using the latest version of Sol, which is v2.14.0.
The code was compiled using the visual studio 2015 c++ compiler.
Also sometimes (?) it breaks at std::string err = message ? message : "An unexpected error occurred and forced the lua state to call atpanic"; "Vector too long."

The latest version is 2.14.2, which you should get and try your code. A link is in my earlier comment.
If you still have trouble, post back here and I'll attempt to help you.

Unfortunately, the latest version does not fix the error.

Ah, those are important details. If a template definition like that can screw things up, I have to be careful! Let me try to report with the original typedef, to see if I can catch what's going on.

Still no-repro. I tried to mock up something close to what you were doing by trying the following:
#define SOL_CHECK_ARGUMENTS

#include <sol.hpp>
#include <iostream>
#include <cassert>

struct IComponent {

	virtual ~IComponent() = default;
};

struct FZGameObject {
	std::string mName = "Woof";

	void AddComponent(IComponent* ic) {

	}
};

template <typename C>
struct Component : IComponent {
	C component;
};

struct MeshRenderer {
	int data = 20;
};

typedef Component<MeshRenderer> FZMeshRendererComponent;

int main() {
	sol::state lua;

	lua.new_usertype<FZGameObject>("GameObject",
		"Name", &FZGameObject::mName,
		"AddComponent", &FZGameObject::AddComponent
	);

	lua.new_usertype<IComponent>("IComponent");
	lua.new_usertype<FZMeshRendererComponent>("MeshRendererComponent", sol::base_classes, sol::bases<IComponent>());

	lua.script(R"(
	local go = GameObject.new()
	local comp = MeshRendererComponent.new()
	go:AddComponent(comp)
)");
}

ic in add-component works out just fine. Not sure what could be going wrong for the templates, honestly. I'm glad you found a work-around though, so I guess all's well that ends well?


Try to fix watchdog tests again.

I have never been able to reproduce this locally. Maybe the control thread is getting starved.

This doesn't seem to help


lxd depends on the network to launch cached images

Even for images lxd already has on cache, the remote servers are being consulted. This was the outcome of trying to use lxd while on a plane this weekend (Ubuntu 16.04):
Creating ubuntu-16-04-64
error: Get https://cloud-images.ubuntu.com/releases/streams/v1/index.json: lookup cloud-images.ubuntu.com on <IP_ADDRESS>:53: server misbehaving

and:
Creating ubuntu-16-04-64
error: Get https://images.linuxcontainers.org/streams/v1/index.json: lookup images.linuxcontainers.org on <IP_ADDRESS>:53: server misbehaving

This apparently also means that when the remote image is updated, lxd downloads the new image instead of using the local cached one. This already caused me issues while attempting to use lxd on stage, as the logic would both go to the network, and also use the network heavily instead of using its local cache.
Besides those sporadic issues, this is also quite relevant on production use cases, as it turns these remote servers into single points of failure.

LXD 2.5 maintains its stream cache on disk rather than in memory, making such offline operation possible.
That commit will be part of LXD 2.0.6 so will be included in 16.04 "soon".
As for the fact that LXD will always grab the latest version of the image, that's done by design to ensure fast roll out of security fixes to users. That being said, we only actually hit the simplestreams server up to once per hour. If you want to start the particular image you have in your local cache, use its fingerprint (or one of its aliases if you have one set).
Marking as closed as this is effectively a duplicate of #2487

Thanks, that solves most of the problems. The only unfortunate detail left is the fact it will block a fast deployment of a container at an arbitrary point. This means production uses will need to implement fingerprint mapping locally if they don't want to pay the cost of an image update in flight.
It'd be nice to have a --cached flag or similar to prevent that behavior.


[native bridge smart contract 6/n] - add functions for processing system messages

Description
Describe the changes or additions included in this PR.
Test Plan
How did you test the new or updated feature?

If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)

[ ] protocol change
[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

this PR is ready for more review


Android MotoG9 discovery issue

Environment:
Sagemcom F@st 3865bProximus (b-box3)
Release: 8c.514A
GUI Version
<IP_ADDRESS>
The  Sagemcom  Client seems to have issues while discovering my Androids devices.
After further investigation the issue seems triggered by the 'hostname' and device type values seen into the router. By default in the router you don't have a friendly name so not sure if your application is expecting a value because in the HA entity you are mapping the same friendly name value.
Workaround is: change the device type from 'Generic' to 'Mobile phone' and assign a friendly name then reload the application
Action Taken:

Added the Sagemcom client integration

Reloaded home Assistant

the client doesn't discover the Motorola G9 Android
Sagemcom F@st
<IP_ADDRESS>
12 devices and 12 entities

Tried to reload either the application or HA but no luck

Changed the Motorola device type and the friendly name in the router

Reloaded the client and issue is fixed

Apologies but i cannot share the logs somehow HA didn't print any logs even though i added the required lines in the configuration file.

Currently there not much is logged from the integration, thus you won't see a lot indeed.
Currently we use the following definition for the name, so that shouldn't be the issue. Are you familiar with Python and are you able to try if it works with the Python client directly? (https://github.com/iMicknl/python-sagemcom-api)
    @property
    def name(self):
        """Return name of the device."""
        return self.user_host_name or self.host_name

Ok i will give it a try by using the client.

@cingolo could you have a look if it works with the latest version? :)

Oki, I will run few tests later today
Inviato da Yahoo Mail su Android
Il ven, 9 apr, 2021 alle 14:57, Mick @.***> ha scritto:
@cingolo could you have a look if it works with the latest version? :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


refactor: Use substring instead of substr

Danke Schön!
Feel free to tag me for any future things you run into at the JavaScript or the TypeScript repositories.


Removing tags from the search bar doesn't unselect them from the list

Screenshot
Steps to Reproduce

search for 4 tags
remove a tag from the search bar

Buggy behavior

The expanded list of tags still shows the removed tags selected

Expected Behavior

Removed tags are unselected from both the search bar + the full list.

Fixed in next build


Add black format check to ci

Type of changes

[ ] Bug fix
[ ] New feature
[ ] Documentation / docstrings
[ ] Tests
[X] Other

Checklist

[X] I've run the latest black with default args on new code.
[ ] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
[ ] I've added tests for new code.
[x] I accept that @willmcgugan may be pedantic in the code review.

Description
Added a check for black formatting to ensure only formatted code is merged to the master branch.

Thanks!


Leak

Hi Brow, thanks for sharing your projects .
I tested your project in a real device (Iphone4) with 12 more images in the Image Example mode and I think uncache you are doing is not sufficient, the images are kept in memory in another step. If you run Instruments/Allocations you can see how the liveBytes grow until you have gone throw all the images. You can see some info about this object's allocation, like Responsible Library = ImageIO or Responsible Caller = ImageIO_Malloc. However I cant fix it so far ... your help would be really appreciate it.
Thanks

Bump
I am seeing the same problem too.  When zooming in and out several times and flipping pages causes a huge memory leak or huge allocations.  I've tried running Instruments and cannot pinpoint where the leak is taking place... Anyone else have any thoughts or ideas?  BTW I'm using Hammerlyrodrigo's most recent version with zooming enabled.

matsumoto79, I had received a solution (test it and verify for yourself!) to fix the memory problem I was having from Rodrigo Hammerly, assuming you are using his version (September 2011).  For me it worked for the most part, I just had to tweak some of the tile settings.  I changed the level of detail down to 4 and the bias to 2, and it seemed to work fine.  The only time it didn't work was I had a higher detail and bias, which I think just took up too much memory to cache.
Add these two lines of code to -(void)getImages in the LeavesView.m file.
topPageZoomLayer.contents = nil;
topLeftPageZoomLayer.contents = nil;


H5 video stops after about 3 minutes

problem
without crosswalk the video works find, but after added this plugin, a 5 minutes video always stops after playing about 3 minuts.
Debug log
05-03 21:21:45.922  5686  5686 E chromium: [ERROR:xwalk_browser_context.cc(88)] Failed to read preference, error num: 0
05-03 21:21:46.136  5686  5933 E libEGL  : validate_display:255 error 3008 (EGL_BAD_DISPLAY)
05-03 21:27:55.143  9265  9273 E ProcessInjector: error while reportKillProcessEvent to system server!
05-03 21:27:55.148  9266  9268 E ProcessInjector: error while reportKillProcessEvent to system server!
05-03 21:28:08.949  9615  9615 E chromium: [ERROR:xwalk_browser_context.cc(88)] Failed to read preference, error num: 0
05-03 21:28:09.167  9615  9678 E libEGL  : validate_display:255 error 3008 (EGL_BAD_DISPLAY)
05-03 21:30:57.958   347 10189 E NuCachedSource2: source returned error -1010, 0 retries left
05-03 21:31:55.236   347 10200 E NuPlayerDecoder: Stream error for OMX.google.aac.decoder (err=-1004), EOS successfully queued
05-03 21:31:55.237   347 10186 E NuPlayer: received error(0xfffffc14) from audio decoder, flushing(0), now shutting down
05-03 21:31:55.238  9615 10062 E MediaPlayer: error (1, -1004)
05-03 21:31:55.565   347 10198 E NuPlayerDecoder: Stream error for OMX.qcom.video.decoder.avc (err=-1004), EOS successfully queued
05-03 21:31:55.565   347 10186 E NuPlayer: received error(0xfffffc14) from video decoder, flushing(0), now shutting down
05-03 21:31:55.565  9615  9631 E MediaPlayer: error (1, -1004)

Does anyone get the same issue?

I met the same problem as you.

@ligui-iOS i rmoved crosswalk, and it works fine.

[ ]

[ ]

[ ]

[ ]

[ ]


Remove fork of testtools internals for FullQiskitTestCase

Summary
In #3982 we forked a bunch of internals around results handling and
attachments from the testtools library to enable better stdout, stderr,
and pylogging handling when running with stestr (which is our default
runner in CI). This was necessary at the time because testtools relied
on unittest2 (which was a rolling backport package from unittest to
bring new features from newer python's unittest to older python
versions) that has gone unmaintained for years and was causing
incompatibilities with stdlib unittest on newer python versions. However
as of the testtools 2.5.0 release it no longer depends on unittest2 and
instead inherits directly from unittest fixing the compatibility issues
we were facing previously. This means our fork of the result and
attachment handling from testtools is no longer necessary and we can
just use their TestCase. However, since we do not want to require the
use of testtools outside of running with stestr this commit retains the
same spit logic around when we use it to ensure that we're only
opportunistically using the library if it's installed. This enables
people to no have testtools (which honestly isn't the best maintained
library anymore) taint their code path unless it's already installed.
Details and comments
Fixes #7307

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

6 of 8 (75.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 82.799%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit/test/base.py
6
8
75.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.05%

Covered Lines:
50023

Relevant Lines:
60415

💛  - Coveralls

This PR broke my local testing environment until I updated testtools, should we include that in our requirements-dev.txt?

testtools is meant to be an optional dependency for the tests, so we've historically not included it and let people install it if they want. I think the reasons for that are less important with testtools 2.5 now though, because it no longer uses unittest2.


Make disconnected portals generate a portal on the other side

Currently, traveling through a disconnected portal will just drop you out on the other side with no way of getting back to where you came from. There should be a config setting that makes it so that traveling through a disconnected portal will generate a portal on the opposite side for the player to use to get back to the original portal.
This is especially important because this update makes some major changes to how portal locations and connectivity work meaning that most portals in existing world will get disconnected.
There is a circumstance where attempting to travel through a portal will yield no output locations at all. In this case the input portal should just break or play a sound or something.

This is related to #7.


Possible review mode completion issues button program error

Actions before raising this issue

[X] I searched the existing issues and did not find anything similar.
[X] I read/searched the docs

Steps to Reproduce
1.Administrator users click on review mode to review problem descriptions
2.Then try reopening to complete the error update
3.Then a browser page crash occurred
Expected Behavior
No response
Possible Solution
No response
Context
https://github.com/opencv/cvat/assets/135221549/c78cf4f6-9dec-4b04-bb5e-2199ad8b4d80
Environment
-DockerDesktop latest version
-Deployment method   docker-compose -f docker-compose.yml -f components/serverless/docker-compose.serverless.yml up -d
- windows11
-i7  NVIDIA-3060

@KTXKIKI
The tool version?

@KTXKIKI
工具版本？

Server version: 2.8.0
Core version: 11.1.0
Canvas version: 2.17.6
UI version: 1.57.2

@KTXKIKI
Could you please check if this patch #6977 solves the issue for you?

That's awesome @bsekachev

@bsekachev hi  mogul  I don't know if it's a problem with my operation
Do I create a problem as an administrator and then click to solve it, or do I report an error
https://github.com/opencv/cvat/assets/135221549/abf5a30e-f080-4a0c-9f13-23cab3ebd228

I am using Edge's browser and there is no built-in translation for browser plugins

Server version: 2.8.0
Core version: 11.1.0
Canvas version: 2.17.6
UI version: 1.57.3
We have installed your repaired

I submit that it is reproducable with enabled Chrome translactor. I will take a look.

i try  it's all a matter of the browser's built-in translation


The release notes contain no information

The release notes of the last nine releases say the exact same thing which renders them close to useless in my opinion. I know it's additional work but still I would highly appreciate proper release notes. Even automatic release notes created from the pulled PRs and/or commits would be more helpful than how it is currently done.

Thanks for the feedback. I can share this internally with the team.
I'm going to close this issue because we are currently only accepting Github Issues for bug reports.
Please, for future feedback notice you can use our in-app feedback form, or feel free to open a discussion instead. Thanks.
Contributing guidelines


Output from the pycppad function is not being accepted by constraint function

Pycppad uses two functions independent and adfun in the following way
a_var = independent(np.hstack([x0, l0]))
jacobian = adfun(a_var, g(a_var[:dim_x], a_var[dim_x:])).jacobian

But when the g function is called, it calls ax2Rot and both of these are expecting float values whereas what they get looks like this
[<pycppad.cppad_.a_float object at 0x7f358ab170c8>
 <pycppad.cppad_.a_float object at 0x7f358ab17140>
 <pycppad.cppad_.a_float object at 0x7f358ab171b8>]

Attaching the screenshot of the error.

same problem

same problem,have you guys solved this?

Same problem.

run pip install -U numpy works for me.
see commit https://github.com/numpy/numpy/commit/e33b286755401d81a96bb2d847b46c3096ac9903

Are you guys using pycppad from here https://github.com/b45ch1/pycppad.git ?
Because from what I see it doesn't really compile on Ubuntu 18.04 or newer and I had to adapt it.
This one seems the newer still maintained version https://github.com/bradbell/cppad_py

Are you guys using pycppad from here https://github.com/b45ch1/pycppad.git ?
Because from what I see it doesn't really compile on Ubuntu 18.04 or newer and I had to adapt it.
This one seems the newer still maintained version https://github.com/bradbell/cppad_py


Adress sanitycheck for aes encrypted zip

Thanks for your pull request. In general it looks good, but several minor issues to fix.
As a first pass, please rebase these to atomic commits. Each commit should be tightly focussed on one thing. For example:

Update for Xcode 7.3.
Enable testing of OS X Framework.
Sanity check before any instantiation of data stream. (Can include the unit testing code as well.)
Validate CRC on WinZip AES-encrypted entries. (But see last point in general comments below.)

Merge or drop typos and bad commits. Split up @18d7f9c into two commits. You can use a git rebase -i to do this and then git push --force to update this pull request.
Other general comments:

Style nits:

Follow the existing code's bracket style i.e. { on a new line, } to match indentation.
Follow the existing code's pointer style i.e. ZZWinZipAESExtraField* winZipAESRecord instead of ZZWinZipAESExtraField *winZipAESRecord .
Objective-C uses YES and NO, not true and false.

I like how you've broken up the check: method into several separate methods! Do put the method declarations in the @interface ZZOldArchiveEntry() extension.
Drop checkEncryptionAndCompressionMode: and call checkEncryptionMode: and checkCompressionMode: directly. Looks cleaner and easier to reason about the logic.
getLocalEncryptionMode appears to only be used in checkLocalEncryptionMode and doesn't really make sense as a separate piece of code e.g. no need to be in public interface. Integrate that into checkLocalEncryptionMode.
checkCRC: method checks for versionNumber, use a switch statement instead of multiple if as this makes the code clearer.
validateCRC: method appears to always return true. This is a pre-existing problem! Best to drop that method entirely since I don't see how we could actually check CRC before decompressing and/or decrypting. You should leave intact the validation of zero CRC for version_AE2 though.

Hi thanks for your pertinent comments: i have just integrated those now.
Few comments on my side:

Please note that within the check of the local header (checkLocalHeader) I am now doing this check: _localFileHeader->compressionMethod != _centralFileHeader->compressionMethod instead of  _localFileHeader->compressionMethod != self.compressionMethod.

I believe i already asked but do you see a way to corrupt a local header by taking as ressource one of your encrypted AES file?

OK, a couple more minor edits and we should be done. Thanks for your work!

Please integrate the style nits with the original commit e.g. by splitting up @f1dbfc1 and then merging the style nits with @e9eac9c. This way I can actually see that the styles are being followed.
In ZZOldArchiveEntry.mm:306, use ZZRaiseErrorNo as an early return which is the convention.
Do put the checkXYZ: method declarations in the @interface ZZOldArchiveEntry() extension.

Please note that within the check of the local header (checkLocalHeader) I am now doing this check: _localFileHeader->compressionMethod != _centralFileHeader->compressionMethod instead of _localFileHeader->compressionMethod != self.compressionMethod.

That looks fine.

I believe i already asked but do you see a way to corrupt a local header by taking as ressource one of your encrypted AES file?

You can try corrupting a local header by open an NSData from the file, figuring what offset the zeroes have to be, writing some zeroes there and then open a ZZArchive with the data. If that's too finicky to work, I'm happy to accept the corrupted file in the test case.

I have integrated your last comments. I have managed also to corrupt the local header of your original small-test-encrypted-aes file by zeroing out some of the local header fields (versionNeededToExtract, generalPurposeBitFlag, compressionMethod, lastModFileName). This was feasible by identifying the local header signature in the file (504b 0304) and the offset for the next fields i wanted to zero out.
I hope this looks good to you now :-) - have a nice w.e!

I'm sorry for not getting back to you sooner -- had a busy month, both in life and work.
I really do appreciate the work you've put into this!
However, you'll need to be careful to respect the project style throughout. I see still quite a few bracket style exceptions. Please rebase to integrate any style fixes with the commits that originated them.
Also, where you've made certain methods part of the class extension, both the class extension methods and their implementation should be part of the same commit.
This is so that we can just inspect one commit and see everything that's needed to make it work there, rather than having to inspect multiple commits. Also helps git bisect and other automated debugging procedures.
Also, when I meant "corrupt the original test archive", I actually meant to do this in the test case e.g. in setUp and tearDown. This avoids having to include another zip file in the package, since we can copy the existing zip file and corrupt it for testing in setUp, then delete the copy in tearDown.


Differences in terraingen with new snapshot 162 ?

I just downloaded and installed the newest snapshot (Build #162)
And when i generated my world, it seems that the generation is
different from the old snapshot.
old and new terrain gen images
Dont look at the weird textures, i am experimenting with them :slight_smile:
Its the terraingeneration itself that is different. I didnt change anything to the
config files (instead i switched the plugins to make these images)
The biome you're looking at gets its settings from a generic mountain biome
(its extended), the biome config can be found here :
biome config file
Greets Sat

There are indeed some differences. Today, I reverted the code to how it was before March 9 of this year, so that the terrain should look like TerrainControl 2.7. If you still have a server on Minecraft 1.8 somewhere, you can verify that the old behaviour is restored.

I saw that on github. I recently started with MC again, so i dont have a 1.8 world. The reason i posted it this was that you might have missed some parts of the recode. Now that i know its intended i'll find a way
to work with it. Thanks for keeping terraincontrol alive i would be lost without it :)
greets Sat


Move LA crash to nolaR

Similar to #2 , move the functions from the LA_crash package into nolar https://github.com/nola-r/lacrash.

I've done a migration and made a pull request. Also, I have sent an email off with more info.
Let me know if there any issues with the pull request.


Overwrite object warning appears twice

This warning appears twice.

Demo repo: https://gitlab.com/christianguenter/test_package.git
Steps to reproduce:

clone master
pull
switch to subpackage
pull

The object is also deserialized twice.


actor_log_prob.transpose in MPO causes error

Hi,
Thanks so much for the clean implementation. In MPO, using actor_log_prob.transpose((0, 1)) causes error. https://github.com/henry-prior/jax-rl/blob/a2c606789b1e883785b46f5a73e5840220cc86b2/jax_rl/MPO.py#L236
TypeError: transpose permutation isn't a permutation of operand dimensions, got permutation (0, 1) for operand shape (256, 20, 1).
I checked the shape of actor_log_prob and weights, they are in the same shape. After removing this line, I can get the samilar performance in cartpole_swingup env as shown in README.md.
Best,
Yi

Looks like this line was unnecessary, removed it in #11


[backport] Fix flaky TestContrastive

Backport of #7747

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit 28477d89d10963a9b74db2de4fa1837a06b7bdf1, target branch v6) succeeded!

LGTM.


add string literals

Current dependencies on/for this PR:

main

PR #69   👈

This stack of pull requests is managed by Graphite.


Relative paths not supported

If I run 'yesiscan [dir]' I get errors, currently it has to be 'yesiscan /full/path/to/dir'. Would love to be able to do it locally.

I think we need to double check if this is still happening, and if do, we need to fix this for Lite MVP

This is fixed.

Tested with latest version and it's fixed. Please reopen if still happening


make search clearable after selecting

make async-select clearable. Clearing the async-select passes a null to the handleChange function.

so in Fragmentarium search is clearable which is better. But in ReferenceEditor it is not because there we can just delete it instead of Clearing it.

New PR for this:
https://github.com/ElectronicBabylonianLiterature/ebl-frontend/pull/41


It is not clear how to find api and permissions numbers

Describe the bug
This is more of a question or feature request to update the documentation.
The examples use alphanumerical strings for the api and permissions values rather than the human friendly names like "Graph API" and permissions of "Sign in and read user profile".  It is unclear how to convert these name to the values az cli is looking for.
To Reproduce
I want to grant an app API access to Microsoft Graph with the permissions of Sign in and read user profile and Read directory data.  I can find no information on the cli values for these things.
For example I want to use this command:
az ad app permission add --id (my app id here) --api (desired api) --api-permissions (desired permission)=Scope
How to I find the desired api and desired permissions that I need to enter into the command above?  I.e. in the example, how do you convert "Sign in and read user profile" to this "311a71cc-e848-46a1-bdf8-97ff7156d8e6".  It would be helpful to have this in the documentation.

For clarity here's the example I'm trying to use:
https://docs.microsoft.com/en-us/cli/azure/ad/app/permission?view=azure-cli-latest#examples

@spacekitty76, each permission is a uuid, and there is no reference doc you can get for all the values.
The recommended flow is you manually configure one in the Azure portal and click the manifest button in the application's tab which will show you the permission uuid that you can use it to do the same thing through CLI.

Closing, since I have answered the question


Allowing custom shim path to be used during Phantom creation

Proposed changes in this pull request
NOTE:
For some reason, I get the error:
Error: src/phantom.js:80
 80:     this.logger.debug(`Starting ${phantomPath} ${args.join(' ')}`);
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unused function argument
   75:       debug: logger.debug ? (...msg) => logger.debug(...msg) : () => undefined,
                                                                      ^^^^^^^^^^^^^^^ function expects no arguments

When I try to remove line 81, or:
 const pathToShim = path.normalize(`${__dirname}/shim/index.js`);  // eslint-disable-line

from the file src/phantom.js. Do you have any idea why this would be?
This PR allows users to pass in where their shim/index.js file is located. This is useful when this library is being used in contexts such as AWS lambda, where the location __dirname will lead the program to is not correct.
Checklist

[x]  New tests have been added
[x] npm test passes successfully
[x] Documentation has been updated

@amir20 to review

Nice. I’ll look tonight. Might be a bug with Babel.

Thanks @zachschultz. It turns out the problem was with () => undefined. I fixed it and updated packages to make sure flow is up to date.

Version 4.0.12 pushed. Should be up soon.


Exporting method for midpoint of a linestring

A method which returns a certain point of a linestring would be useful in many cases. There is already a function called "getFlatMidpoint" which returns the midpoint of the linestring.
I think this function should be exported and in addition it should provide a fraction as parameter in order to get any point on the linestring. For the midpoint i would call this method with "0.5" as argument.

Certainly it would be an useful resource.

+1


Fix cursor for disabled switch-field and radio-field

1. Why is this change necessary?
Right now the cursors on different togglable fields look like this:

field
icon cursor
label cursor

checkbox-field
forbidden
neutral

radio-field
action
forbidden

switch-field
neutral
action

2. What does this change do, exactly?
Now they look like this:

field
icon cursor
label cursor

checkbox-field
forbidden
neutral

radio-field
forbidden
forbidden

switch-field
forbidden
forbidden

I still did not fix the checkbox-field label because somehow changing it was not working for me. If someone else can do this, nice.
3. Checklist

[x] I have rebased my changes to remove merge conflicts
[ ] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-23693
Please use this issue to track the state of your pull request.

Hey @JoshuaBehrens thanks again for your contribution, your changes are merged! :tada: :blue_heart:

Thank you for merging :) woop woop


WIP: Unit tests

I'm learning this whole "writing rspec for types and providers" thing as I go, so this may be very, very wrong. Also, I shamelessly cribbed this example from our friends at Camptocamp.
We also need to load windows facts, apparently: No facts were found in the FacterDB for: [{:facterversion=>"/^2.4/", :operatingsystem=>"Windows", :hardwaremodel=>"x86_64"}]

#18 already has some spec tests written up; you might see about grabbing those (I never got around to running them myself).

Right on, thanks!

On Dec 11, 2016, at 10:34 AM, Eric Badger<EMAIL_ADDRESS>wrote:
#18 already has some spec tests written up; you might see about grabbing those (I never got around to running them myself).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Connection to ssh.lagoon.amazeeio.cloud closed by remote host

Describe the bug
When executing drush commands on Lagoon projects, I always receive a Connection to ssh.lagoon.amazeeio.cloud closed by remote host. error message. I do think the command runs successfully most of the time however.
To Reproduce
Following command for example:
drush @master sql-drop -y
Using Drush version 8.1.17, haven't tested on other versions.
Expected behavior
The error message to not appear.
Drush output
[wp-back-office]cli-drupal:/app/web$ drush @master sql-drop -y
Do you really want to drop all tables in the database drupal? (y/n): y
Connection to ssh.lagoon.amazeeio.cloud closed by remote host.

With -vvv
[wp-back-office]cli-drupal:/app/web$ drush -vvv @master sql-drop -y
LAGOON_PROJECT is set, using 'wp-back-office' as project [notice]
Finding Drupal Root [notice]
Starting to search for .lagoon.yml file to extract project name within '/app/web' and parent directories [notice]
Using .lagoon.yml file at: '/app/.lagoon.yml' [notice]
Using default SSH Endpoint 'ssh.lagoon.amazeeio.cloud:32222' [notice]
Using default API 'https://api.lagoon.amazeeio.cloud/graphql' [notice]
Hit lagoon project cache [notice]
LAGOON_PROJECT is set, using 'wp-back-office' as project [notice]
Finding Drupal Root [notice]
Starting to search for .lagoon.yml file to extract project name within '/app/web' and parent directories [notice]
Using .lagoon.yml file at: '/app/.lagoon.yml' [notice]
Using default SSH Endpoint 'ssh.lagoon.amazeeio.cloud:32222' [notice]
Using default API 'https://api.lagoon.amazeeio.cloud/graphql' [notice]
Hit lagoon project cache [notice]
Loaded alias @master from file /app/web/../drush/aliases.drushrc.php [notice]
Begin redispatch via drush_invoke_process(). [notice]
Calling proc_open(ssh -o LogLevel=ERROR -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no -p 32222<EMAIL_ADDRESS>'env COLUMNS=147  drush  --verbose --yes --root=/app/web --uri=bo.web-platform.docker.amazee.io  sql-drop 2>&1' 2>&1);
LAGOON_PROJECT is set, using 'wp-back-office' as project [notice]
Finding Drupal Root [notice]
Starting to search for .lagoon.yml file to extract project name within '/app/web' and parent directories [notice]
Could not find .lagoon.yml file. [notice]
Using default SSH Endpoint 'ssh.lagoon.amazeeio.cloud:32222' [notice]
Using default API 'https://api.lagoon.amazeeio.cloud/graphql' [notice]
Hit lagoon project cache [notice]
Do you really want to drop all tables in the database drupal? (y/n): y
Executing: mysql --defaults-extra-file=/tmp/drush_HIIPAB --database=drupal --host=mariadb --port=3306 --silent  < /tmp/drush_poEgMK
Executing: mysql --defaults-extra-file=/tmp/drush_jFNgOk --database=drupal --host=mariadb --port=3306 --silent  < /tmp/drush_CbLAGH
Connection to ssh.lagoon.amazeeio.cloud closed by remote host.
End redispatch via drush_invoke_process().

8.1.17 changes the way ssh commands are built, we will have the alias system take this into account, currently downgrading to 8.1.16 will resolve this issue. This was also reported in #521, closing.

I'm still receiving this error using drush 8.1.16.
For example, when I perform drush @master ssh, I successfully get SSH access & perform commands, but after some time (few minutes) the following occures:
Connection to ssh.lagoon.amazeeio.cloud closed by remote host.
Connection to ssh.lagoon.amazeeio.cloud closed.
An error 255 occurred while running the command `ssh -o LogLevel=ERROR -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no -p 32222 -t<EMAIL_ADDRESS>'cd /app/web && bash -l'`


Liquid Tags in Sass

Hey There,
First of all, thanks for making this. It seriously rocks. So glad to be free of all of the Slate limitations.
What's the best way to handle liquid tags in the SCSS files? Trying to reference a background image in my sass and can't get it to work.

@pjatx the way we handle those things is with a quick inline style directly in the liquid. The reason for that is that postcss freaks out hard with {{}} liquid syntax and sometimes also uglify so we decided to keep JS and SCSS out of liquid for the time being.
I've seen before how to circumvent this https://gist.github.com/tmslnz/1d025baaa7557a2d994032aa88fb61b3#file-gulpfile-js-L84-L88
But I've had issues in the past with it so most of the time I'd just go with the inline liquid style 😛

Ah, nice and simple. Thanks!

no problem 😄


Outline Commands Code

Outline Commands first transliteration 😂 Needs testing & debugging!

Completed 'outline editing' commands by finally implementing leoFileCommands.ts in whole and  the clipboard operations, which use the real system clipboard.


GEODE-5108: examples should only run gradle tasks

Thanks for the PR - sorry it took so long to get to.

@karensmolermiller are you ok with this change?

Thanks for the PR - sorry it took so long to get to.

Thanks! I asked in the mailing list because as this is a different repo than Geode, I didnt know if someone was monitoring it.

I’m not happy about this change. I’ve always been displeased by the amount of magic we do in scripts that the user should actually be aware of. We have now hidden away gfsh for simplicity but the user needs to understand gfsh when moving past these examples.


USD values missing for certain donors

Describe the bug
For certain donors, transaction_value_usd is 0. I noticed this for example for the following donors:

Reporting org ref
Reporting org name

44000
The World Bank

46002
African Development Bank

47122
Gavi, the vaccine alliance

CA-3
Global Affairs Canada

DE-1
Federal Ministry for Economic Cooperation and Development

FI-3
Finland - Ministry for Foreign Affairs

FR-3
Agence Française de Développement

FR-6
France - Ministry for Europe and Foreign Affairs

To Reproduce
Steps to reproduce the behavior:

Download CSV file from this URL (all transactions for Nigeria)
Add a pivot table on top

filters: transaction_type: 3 or 4
values: sum of transaction_value_usd; sum of transaction_value

Sort by transaction_value largest to smallest
See that in many cases, transaction_value_usd is 0 while transaction_value is > 0

Also: see one activity:
https://iatidatastore.iatistandard.org/search/transaction?q=iati_identifier:46002-P-MA-DC0-003&rows=1
Note that transaction_value_usd is 0.
I noticed in the above CSV output, default_currency is blank, although it appears to be consistently populated in that IATI XML -- I wonder if this is the root cause?
https://datastore.codeforiati.org/api/1/access/activity.xml?iati-identifier=46002-P-MA-DC0-003
Expected behavior
transaction_value_usd should be consistently filled out for all publishers.
Screenshots
Pivot table in Excel, following above steps:

Possibly relates to #2223 #2219

Another thing to note is that the currency conversion only works for IMF currencies. In these cases no value should be returned, rather than a conversion value of 0.

Another thing to note is that the currency conversion only works for IMF currencies. In these cases no value should be returned, rather than a conversion value of 0.

This item will go into investigation end of this week.

IMF available currencies are here: https://www.imf.org/external/np/fin/ert/GUI/Pages/Countries.aspx

tip: SDR is not included in the IMF rate tables, do look at the orgs mentioned and check if they use currencies listed in the IMF table.

This might be useful:
https://github.com/codeforIATI/imf-exchangerates
It includes IMF exchange rates to USD for 169 currencies, including SDR. It runs every night at 5am and you can get the compiled data here:
https://codeforiati.org/imf-exchangerates/imf_exchangerates.csv

Thanks @markbrough - what's the date range on that collection? Seems scattered from 1957-2021 but with many gaps I believe.

@amy-silcock we would like to start work on this once #2492 is processed as this is an important item to cover as we are now missing some USD converted values. Team expects this to be up a 1-3 days of work, depending on the complexities that may arise from this. So optimal scenario = 1 day, less optimal scenario = 3 days. Could this be approved so we can plan for this in our next Sprint cycle? Thanks.

Hi @markbrough - a PR has been made  at CodeforIATI - could you or someone else check that out :-) - this way iati.cloud will be in sync and less datagaps on conversion will be present. The provided exchange rates are not complete either, but more complete than the current data we use.

@sylvanr check the PR change request at https://github.com/codeforIATI/imf-exchangerates/pull/2


Change changelog style to keepchangelog.com

Pull Request Test Coverage Report for Build 259

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.827%

Totals

Change from base Build 255:
0.0%

Covered Lines:
220

Relevant Lines:
237

💛  - Coveralls


Store: strict mode

Vue

In strict mode, whenever Vuex state is mutated outside of mutation handlers, an error will be thrown. This ensures that all state mutations can be explicitly tracked by debugging tools.
-- https://vuex.vuejs.org/en/strict.html

Mobx

Usage: useStrict(boolean). Enables / disables strict mode globally. In strict mode, it is not allowed to change any state outside of an action. See also extras.allowStateChanges.
-- https://github.com/mobxjs/mobx/blob/gh-pages/docs/refguide/api.md#usestrict

Almin allow to mutate state inside of constructor and receivePayload.
This strict limitation provide as strict option?

Violation case:
export default class MyStore extends Store {
  constructor({myRepository}) {
    super();
    this.state = new MyState();
    myRepository.onChange(this._onChange.bind(this));
    this.onDispatch(this._onDispatch.bind(this));
  }

  getState() {
    return this.state;
  }

  _onChange(my) {
    const newState = this.state.update({ my });
    this.setState(newState);
  }

  _onDispatch(payload) {
    this.setState(this.state.reduce(payload));
  }

}


use static libphobos2.a as default

except for OSX where -Bstatic isn't available

Ping, I want to bundle the shared phobos library for freebsd with the next release.

Ping again.

Auto-merge toggled on

Auto-merge toggled off

Auto-merge toggled off

NVM wrong PR

I have some objections to this, as stated in the PR for Linux.

I have some objections to this, as stated in the PR for Linux.

This is needed to keep the static phobos lib default when shipping a shared phobos lib on FreeBSD.

Ping, this is needed to build shared libraries on FBSD.

worksforme after removing the casts. Can't wait to switch to D, that string manipulation is gnarly.

worksforme after removing the casts. Can't wait to switch to D, that string manipulation is gnarly.

Updated to use "abc".ptr instead.

FWIW the existing code used casts because it worked in both C++ and D.  You could also use slen > 3 + 2 && libname[0..3] == "lib"

FWIW the existing code used casts because it worked in both C++ and D. You could also use slen > 3 + 2 && libname[0..3] == "lib"

It works using memcmp, can we please move on with this.

Ping, still blocked.

Could someone please merge this?

sorry for the delay!

Auto-merge toggled on


Couple of suggestions for improving the project

I'm interested in using add-clear in my project, but there are a couple enhancements I'd need to have first before it would work for me.
First, the clear button competes with the clear button that already exists in IE11 and Edge, creating a wonky scenario with one 'x' on top of the other. I think it'd be great if your code could disable the built-in clear button automatically (just for those browsers), but if you'd rather make that an option that defaults to false, I'd be happy with that too. Some quick research turned this up:
https://developer.mozilla.org/en-US/docs/Web/CSS/::-ms-clear
Second, if you fill the field with text, the 'x' is displayed on top of the text, which, again, looks bad. Adding padding-right of 20px seems to fix the issue nicely. Again, I'll leave it up to you if you want to make this default behavior or an option that defaults to false. There could be some interaction between this option and the first one I suggested, as the Microsoft browsers automatically add padding so their built-in clear button doesn't run into this problem.
What do you think?

I think these are excellent suggestions, however my time is limited these
days so it's easier for me to just deal with pull requests. However if you
don't have the time yourself for a pull request or lack technical ability I
will try to add these suggestions myself but it will probably take a bit
longer. Thanks!
On Wed, Feb 3, 2016 at 2:14 PM, Kyle Getz<EMAIL_ADDRESS>wrote:

I'm interested in using add-clear in my project, but there are a couple
enhancements I'd need to have first before it would work for me
First, the clear button competes with the clear button that already exists
in IE11 and Edge, creating a wonky scenario with one 'x' on top of the
other I think it'd be great if your code could disable the built-in clear
button automatically (just for those browsers), but if you'd rather make
that an option that defaults to false, I'd be happy with that too Some
quick research turned this up:
https://developermozillaorg/en-US/docs/Web/CSS/::-ms-clear
Second, if you fill the field with text, the 'x' is displayed on top of
the text, which, again, looks bad Adding padding-right of 20px seems to fix
the issue nicely Again, I'll leave it up to you if you want to make this
default behavior or an option that defaults to false There could be some
interaction between this option and the first one I suggested, as the
Microsoft browsers automatically add padding so their built-in clear button
doesn't run into this problem
What do you think?
—
Reply to this email directly or view it on GitHub
https://github.com/skorecky/Add-Clear/issues/23.

Quite understandable, so I'll take a look and see what I can do. :smile:

It turns out the built-in clear button in the Microsoft browsers can't be disabled through JavaScript, only by using a proprietary, vendor-specific CSS pseudo-class, so I don't think there's anything we can do about that here. I'll have to add that pseudo-class to my project's stylesheets. I can add a blurb about that to the README file.
I added a new option (with a reasonable default value) for padding so the clear button doesn't sit on top of the entered text. I'll submit a pull request for all of this shortly.

Thanks for the pull request!

My pleasure! How often do you do releases?

Not super often, but I have a couple in there now so I should do one soon.
Maybe tomorrow :)
On Thu, Feb 4, 2016 at 2:06 PM, Kyle Getz<EMAIL_ADDRESS>wrote:

My pleasure! How often do you do releases?
—
Reply to this email directly or view it on GitHub
https://github.com/skorecky/Add-Clear/issues/23#issuecomment-180025603.

OK great, would love to see a new release so I can use this in my project. :smile:

Pushed the update


Create Esperanto locale for site

I did this up before I realized that all of the other content would probably have to be translated, too. Maybe this can serve as an inspiration for an Esperantist with more time on their hands!

[X] Have you followed the contributing guidelines?
[X] Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Hi @colindean
Cool that you want to introduce a new language like Esperanto :)
But preparing a new language is not just translating and creating a file.
You haven't done the tests locally, because you would have noticed that the file directory is missing.
I will complete these files and maybe you will give PR a DRAFT, then you or someone who knows Esperanto will send translation suggestions.

Thank you for the comment. I did the edits in the GitHub editor itself, not locally, so I couldn't run the tests before submitting it. It wasn't until immediately after I submitted it that I realized there's a whole lot more content to translate. I won't have the time to translate that content anytime soon. I'll move the pr to draft status.

I'm going to go ahead and close this since it's a long ways off, and is triggering our "stale PR needs attention" automation. @colindean if you decide to pick the work back up, feel free to rebase and reopen this PR or make a new one. Thanks!


cannot custom button on modals

can u make give props render custom buttton close ?. 💃

I agree, more control over the ModalHeader would be nice.

More control would be nice but I think I have a work around. I replaced the ModalHeader component with some jsx modeled after the regular Bootstrap 4 modal header. So far everything appears to work as expected. See example below.

Modal title

                 {. . . . .}

Merged via (#1168) (5f33a1a) . Released in 6.5.0


Fail to Convert Huggingface Llama3.1 with ollama create

What is the issue?
I downloaded the meta-llama-3.1-8b model from huggingface. [https://huggingface.co/meta-llama/Meta-Llama-3.1-8B-Instruct]
And I installed ollama-linux-amd64 (version==0.3.6) manually.
When I start the service with ollama serve &, it seems nothing goes wrong.
But after I build a Modelfile with only FROM . in the huggingface model directory and try to create a ollama model with ollama create my-llama-model, I got the following error message:
usr-yc@lm-machine:~/models/vanilla-llama-3.1-8b$ ollama create my-llama-model
[GIN] 2024/09/04 - 15:12:28 | 200 |      23.352µs |       <IP_ADDRESS> | HEAD     "/"
transferring model data ⠙ [GIN] 2024/09/04 - 15:13:00 | 200 |     168.198µs |       <IP_ADDRESS> | POST     "/api/blobs/sha256:xxxxxxx"
[GIN] 2024/09/04 - 15:13:00 | 200 |    5.022104ms |       <IP_ADDRESS> | POST     "/api/create"
transferring model data 100%
converting model
Error: proto: cannot parse invalid wire-format data

OS
Linux
GPU
Nvidia
CPU
Intel
Ollama version
0.3.6

I've tried to first convert the hf model checkpoint into a gguf file in bf16 and ollama create again.
This time I hit the following error:
usr-yc@lm-machine:~/models/vanilla-llama-3.1-8b-gguf$ ollama create my-llama-model
[GIN] 2024/09/04 - 16:35:30 | 200 |      32.033µs |       <IP_ADDRESS> | HEAD     "/"
transferring model data 99% ⠼ [GIN] 2024/09/04 - 16:36:15 | 201 | 28.804626423s |       <IP_ADDRESS> | POST     "/api/blobs/xxxxxxxx"
transferring model data 100% ⠦ [GIN] 2024/09/04 - 16:36:15 | 200 |   82.992457ms |       <IP_ADDRESS> | POST     "/api/create"
transferring model data 100%
Error: invalid file magic

Hey @YueChenkkk There's a bug here where Meta includes two copies of the weights, one in safetensors format and one in pytorch format which is sitting in the directory called original/. As a workaround for now, if you remove the original/ directory it should work.
The second error you got when trying to convert w/ llama.cpp's scripts is due to an invalid conversion. That one will be harder to debug.

Hey @YueChenkkk There's a bug here where Meta includes two copies of the weights, one in safetensors format and one in pytorch format which is sitting in the directory called original/. As a workaround for now, if you remove the original/ directory it should work.
The second error you got when trying to convert w/ llama.cpp's scripts is due to an invalid conversion. That one will be harder to debug.

Thank you so much for the reply!

@YueChenkkk this should be fixed as of 0.3.7. You'll need to update ollama and you can check ollama --version to make sure the the client is at least at 0.3.7 (but preferably just upgrade everything to 0.3.10 which is the current latest version).


Select Into fixed value

Hello, how are you? I'm trying to make the following queries. The Type field created in the table, should be fixed. It corresponds to the Historico, open1 and Open2 values.
query:
alasql('CREATE TABLE TacticalBuyer (BuyerName STRING , Cantidad  INT, Tipo STRING); ');
var sql3 = 'INSERT INTO TacticalBuyer (BuyerName, Cantidad, Tipo) select BuyerName, Cantidad,  "Historico" FROM ? resHistorico  UNION ALL select BuyerName, CantidadOpen AS Cantidad, "open1" FROM ? CantiBuyerOpen UNION ALL select BuyerName, CantidadWorking AS Cantidad, "open2" FROM ? CantiBuyerWorking'
var restotal = alasql(sql3 , [resHistorico, CantiBuyerOpen, CantiBuyerWorking ]);
The problem is that when you query the table created (below) does not bring me the fixed field (called Type), just bring me the BUYERNAME and Quantity fields. Could help me, I'm lost ... Thanks
var sql='select BuyerName, Cantidad, Tipo FROM TacticalBuyer WHERE BuyerName = "Victor Machado -c-"'
var pepe = alasql(sql) ;

Can you give an example of example data you would like to have and what you would like to get into the TacticalBuyer table?

I am closing sue to inactivity. Please reopen when you have inputs...


Added deployment config to broker template

 Add a deployment config to the Broker Template

Related PR: https://github.com/fusor/catasb/pull/98

ACK
I tested this and saw success with provision/bind of mediawiki and postgresql


Fixed Bug for PK´s FK´s etc

errors for correct display of rows.length == column.length have been fixed, furthermore correct display of sql rows, search method embellished

Thanks a lot! So clean :)

if it ok,
you can add me as contributor, have some great ideas for this lib :)
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
Am Dienstag, 3. September 2019 11:20 schrieb Mattia Crovero<EMAIL_ADDRESS>
Thanks a lot! So clean :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I like the idea! I'm adding you right now


encoding/json: MarshalIndent does not prefix first line

What version of Go are you using (go version)?

$ go version
go version go1.17.2 darwin/amd64

Does this issue reproduce with the latest release?
Yes, also gotip.
What did you do?

https://play.golang.org/p/jSVnZBwYiwr
x := map[string]interface{}{
	"field": "value",
}
data, err := json.MarshalIndent(x, "*** ", "  ")
if err != nil {
	log.Fatal(err)
}
fmt.Println(string(data))

What did you expect to see?
*** {
***   "field": "value"
*** }

What did you see instead?
{
***   "field": "value"
*** }

Never mind. Looking at encoding_test.go it seems this is intentional to support indentation in source code. The description for MarshalIdent could be made clearer.


[BEAM-5058] Parallelize Python Precommit and add basic ITs

According to https://beam.apache.org/contribute/testing/, we want to run lightweight e2e tests in Python Precommit.
This change adds precommitIT to Python precommit, which includes wordcount batch and streaming integration tests runs against DataflowRunner. Some changes are made to BeamModulePlugins in order to support large tests running in parallel by putting tests under a subproject of beam-sdks-python.
Note: this PR should merge after https://github.com/apache/beam/pull/6833 goes in.

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---

PreCommit passed.
@udim @aaltay Please take a look.

Interesting. PreCommit failed due to virtualenv of sdks-python-precommit-dataflow:precommitIT is not activated successfully. From Gradle failure log, new precommitIT use system package (/home/jenkins/.local/lib/python2.7/site-packages) instead of virtualenv in build directory.
Guess the reason may come from parallelization. Before each python command, we call . ${envdir}/bin/activate but this may not work if two virtualenv activate simultaneously. However, I cannot reproduce same error from local machine.
Two possible solutions:

Add --user to pip install as failure log suggested. Unfortunately, the gradle task will not work on my laptop.
Instead of calling . ${envdir}/bin/activate, we can directly use the Python interpreter or pip in virtualenv.

Any thoughts? @udim @aaltay

pip install --user isn't safe to use concurrently.
I'm not sure why you're getting the error you're currently seeing, but running virtualenv concurrently on the same path is not a good idea.
I don't agree with redefining the tasks setupVirtualenv, sdist, installGcpTest, and cleanPython for every sub-project. This allows for running them more than once. All 4 tasks above should only be run once during a gradle invocation, and some of them give undefined results if run concurrently.

setupVirtualenv is probably failing due to the path being too long: https://issues.apache.org/jira/browse/BEAM-4256

Use ${project.rootProject.buildDir}/${project.name}/gradleenv for virtualenv path. Let's see if it works on Jenkins.

I don't know why this PR have some many Pre/Post commit tests enabled. Will close it and create a cleaner one for future review.


Request only necessary resources from kube-api

Describe the feature request
My use case is quite simple: I have similar instances in different namespaces that need to be removed based on annotations.
In my case, it is common to place an annotation on the namespace itself, which I already do. Additionally, it is essential for the application to query the Kubernetes API only for namespaces. Currently, it queries all resources in the cluster, which creates unnecessary load on the API server (approximately 200 requests every 5 minutes).
To address this, I propose introducing a configuration file that allows specifying a list of kubernetes resources the controller should manage.
Why do you personally want this feature to be implemented?
No response
How long have you been using this project?
No response
Additional information
I can also take it :)

Sounds reasonable!


Adjust v.03 implementation to make use of canonical string representation

According to https://github.com/cloudevents/spec/pull/432 attribute values must be encoded in their canonical string representation. The SDK so far follows the old approach of JSON encoding  the value.

I never agreed with the spec and never implemented the json encoded quoted strings. I think I am using canonical string values in headers. But please point out where this SDK is not. I do want to follow the spec as closely as possible (when it is correct 😆)

There was a link to an example in my text above. It's in the toHeaders() function. Basically, for extensions encoded, err := json.Marshal(v)is called.

Ah, yes that is a bug.
Want to fix it? :D
I will get to it eventually if not.

I could help with that, I just a little bit lost. Any suggestion how to implement @n3wscott ?

I opened a PR with a fix for that...
Not sure if is the best way to implement it
https://github.com/cloudevents/sdk-go/pull/184

Looks like @diegomarangoni fixed this. Closing


onxxruntime error while installing ivadomed on compute canada

Issue description
Ivadomed installation fails due to error installing onxxruntime on Compute Canada.
Current behavior

Due to certain reasons, I decided to do fresh installation of ivadomed on compute canada (I had installed it previously if that helps). Ivadomed installation requires installation via requirements.txt or requirements_gpu.txt  as mentioned here. They are required to install various modules including onxxruntime==1.4.0. However, the installation fails on compute canada (but is successful on local system), probably due to version issue or unavailability on compute canada.
Snapshot of failed installation with requirements_gpu.txt

Snapshot of failed installation with requirements.txt

This installation is successful on local system (see the last lib in the snapshot below):

Expected behavior

onxxruntime should be successfully installed on Compute Canada for code to run. For example, various pytest are failing due to this lib requirements.
Steps to reproduce

All the steps in installation steps can be followed as it is : https://ivadomed.org/en/latest/installation.html , till Step 3 command pip install -r requirements_gpu.txt , to re-produce the error.
Environment
System description

Compute Canada
3.10.0-1160.36.2.el7.x86_64

Installed packages

 Output of pip freeze
appdirs==1.4.3
attrs==20.3.0
distlib==0.3.0
filelock==3.0.12
importlib-metadata==3.1.1
iniconfig==1.1.1
more-itertools==8.2.0
packaging==20.7
pluggy==0.13.1
py==1.9.0
pyparsing==2.4.7
pytest==6.1.2
pytest-mpi==0.4
setuptools-scm==3.5.0
six==1.14.0
toml==0.10.2
virtualenv==20.0.18
zipp==3.4.0

Paging @naga-karthik, I think he ran into similar issue on Compute Canada for this. Not sure how he got around it.

Thanks @dyt811 I believe last we discussed this on Slack, we discussed it because I wasn't successful in starting the model training and the work around was to comment out onnxruntime which did start the training eventually as mentioned in #918 . Any further suggestions would be appreciated.
I must add this is a fresh installation on compute canada (I had one previously which I removed including the virtual env). This issue so far in only on compute canada but works fine when testing on local system. However, since our documentation details the steps for its working on compute canada too, it would be great if we can resolve this issue. Thanks!

Thanks for reviving this issue @copperwiring! Below you can find the response from Compute Canada support regarding my request for installing onnxruntime on their clusters.

onnxruntime is not available as wheel in Compute Canada clusters. We had some issues
deploying it as a wheel previously.
An option could be to try to convert the docker image into a singularity and use it.
You can find how the docker files links here :
https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fonnxruntime%2Ftree%2Fmaster%2Fdockerfiles&data=04|01|muni-venkata-naga-karthik.enamundram.1%40ens.etsmtl.ca|f58706d0ab6b41a3f48e08d92ce0231c|70aae3b79f3b484d8f9549e8fbb783c0|0|0|637590163440252576|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=OJbuagzusltO5RJyiOzVvqRR6FMf%2F8mScOaUmwOrCdU%3D&reserved=0

And the process to convert it to a singularity image here:
https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.computecanada.ca%2Fwiki%2FSingularity&data=04|01|muni-venkata-naga-karthik.enamundram.1%40ens.etsmtl.ca|f58706d0ab6b41a3f48e08d92ce0231c|70aae3b79f3b484d8f9549e8fbb783c0|0|0|637590163440252576|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=UW1RF%2BuMLH9dIX%2FVVFQrSwji%2BRXYsH35v72TCDsIWo0%3D&reserved=0

Since we cannot install it, one option is to load it as a singularity image in the background (inside the shell) so that the typical import onnxruntime command works. Now, out of the two steps mentioned above, I could pull the docker image and convert it into a .sif singularity file but one problem I couldn't figure out was how to load the onnxruntime singularity file so that the import statement works. It would be great if you could make some progress on this front. Hope this helps!

Thank you @naga-karthik . I will try to go the same route as you: pull the docker image and convert it into a .sif singularity and later load this file in the background. I'll keep this thread updated with latest update.


inDrops barcode list

Hi!
I have an inDrops dataset to preprocess and I am trying to run it using the recent bustools for scRNAseq. Unlike 10xGenomics, InDrops library V3 provides two list of barcodes - inDrops barcode lists where the first one is the beginning nucleotide sequence and the second one is the end part of the nucleotide sequence. Each list has 384 "half"-barcodes and the way that other preprocessing tools manage this is by remaking all possible combinations between the two list so we would have 384*384 = 147,456 barcodes, which is exact the number of barcodes that the inDrops platform claims to have.
I couldn't succeed in use the two .txt lists (instead one like the 10xv2_whitelist.txt from 10x platform) as input in the step of correcting the barcodes in the busfile.
bustools correct -w ../gel_barcode1_list.txt gel_barcode2_list.txt -o output.correct.bus output.bus
How can me manage that?
Finally, thank you Pachter Lab for this amazing tool that was recently released! I really appreciate it!

Also, when I made the list of 147,456 barcodes, by making a new .txt file with all possible combinations of "half"-barcodes
barcodes_inDrops.txt
By doing this:
bustools correct -w ../barcodes_inDrops.txt -o output.correct.bus output.bus
I got the following error message:
Found 147456 barcodes in the whitelist
Number of hamming dist 1 barcodes = 7895424
Error: barcode length and whitelist length differ, barcodes = 19, whitelist = 18
check that your whitelist matches the technology used

Hi! Glad you like the tools.
Currently the "correct" command doesn't work with variable length barcodes so your best bet is to skip the correct step.  It is something we will work on in the future. All other steps should work just fine.
I will close this issue. If something else arises, feel free to open it back up.

Ok after discussing with Páll, we came up with a slight trick that may work:
Append an "A" to the beginning of each barcode until the length of the barcode is the length of the longest barcode, then do barcode error correction.
Here is the "whitelist" with the above modification:
inDrops_modified_whitelist.txt
Try out
bustools correct -w ../inDrops_modified_whitelist.txt -o output.correct.bus output.bus
I'm curious to know if this works!

Hi Sina!
I really appreciate the attention in this thread. So!
I tried the two ways: using the "A" appended trick and skipping the correction step.

Appending the "A"s and applying the correction, bustools gave me:

Found 147456 barcodes in the whitelist
Number of hamming dist 1 barcodes = 8292096
Processed 18141042 bus records
In whitelist = 2
Corrected = 21
Uncorrected = 18141019

My output for this was a dataset with very few barcodes passing correction (~20), and further analysis with BUSpaRse weren't possible.

I skipped the correction step, and not good but interestingly, I got a output with a enormous list of barcodes. I then compared the results with the other preprocessing pipeline that I was using, and further analysis with BUSpaRse (looking at the knee plot for example) showed me more then the double of barcodes simultaneously with half of the UMIs per barcode. I suspect that I have the same cell being counted as two, because the barcodes were not corrected, and the UMIs are split between them. To see this result, I had to mute the whitelist argument when make_sparse_matrix since the actual barcodes are uncorrected...

Thank you! I really appreciate all the tools developed in your lab!

Ok so I went through the kallisto bus code and currently kallisto bus will interpret the four fastq files associated with v3 inDrops as two separate sample files, as is the case for v1/v2. This will give you a BUS file with a huge number of barcodes and incorrect results.. this is not the desired behavior! So currently kallisto bus cannot be used for inDrops v3.
We will get working on v3 and will update the binaries when everything is functional.

Just to quickly give some input on this. I also have indrops v3 libraries and basically I had to join R2 and R4 in a single read of 22 bp using the following bash command :
join <(zcat  <  input_R4.fastq.gz | nl ) <(zcat < input_R2.fastq.gz | nl) | awk -F ' ' '{if ($2 ~ /^@SeqID/ ) {print $4" "$5;} else {print $2$3;}}' | gzip >  BarcodeUMI.fastq.gz
And I guess we would have to demultiplex on the R3.fastq.gz library tag to end-up with a R1.fastq.gz and a BarcodeUMI.fastq.gz  that is sample specific and can be used as an input for kallisto bus (I still need to do this).
Also, for the whitelist, in my indrops v3 platform both barcodes are 8 bp anyways (even if the indrops GitHub tool hints otherwise), so I would actually trim them down to 8bp.
I am still working on getting bus tools set-up as I have some cmake issues but would be nice to see how this progresses!

Hi Sina, sorry for the late response! I was trying to figure out library issues.
So, actually I was using a v2 of inDrops library preparation, with 2 runs per sample.
What was interesting and I didn't know was that the inDrops total barcode has an adaptor sequence (that is constant GAGTGATTGCTTGTGACGCCTT)  between the 2 "half"-barcode sequences (see image).

The length of barcodes vary between 38-41.
I added this adaptor sequence between the two half-barcodes as the following:
barcodes_inDrops.txt
And when I applied the correction step by:
kallisto index -i MouseIndex Mus_musculus.GRCm38.cdna.all.fa
kallisto bus -i MouseIndex -o bus_output_ear/ -x inDrops -t 20 ear_R.fastq.gz ear_F.fastq.gz
cd bus_output_ear/
bustools correct -w ../barcodes_inDrops.txt -o output.correct.bus output.bus

I got the following error:
Found 672 barcodes in the whitelist
Number of hamming dist 1 barcodes = 48828
Error: barcode length and whitelist length differ, barcodes = 19, whitelist = 40
       check that your whitelist matches the technology used

Does the whitelist has to necessarily have 19 nucleotides for the correction step?
Thank you!

Hi Camila, I would probably run kallisto bus as follows:
kallisto bus -i MouseIndex -o bus_output_ear/ -x 0,0,40:0,40,46:1,0,0 -t 20  ear_R.fastq.gz ear_F.fastq.gz
cd bus_output_ear/
I think the problem is that maybe the authors used fastq files where the bridging adaptor was already removed (I am probably wrong though) so they would expect the format of barcodes to be max 19 bp.
Let me know if this works

Hi! Actually these are fastq from my lab, and I am working on them as is from the sequencing. So the adaptors must be there still.
The thing is that we recently acquired a InDrops encapsulator, we had the sequencer, and we are using the pipeline developed by the company all in python, which I am not pro in (I am a R person). kallisto/bustools called my attention because it is in R and I use kalisto for a long time now to work in bulk RNAseq files and teach transcriptomics. Just recently I started to work with single-cell RNAseq.
I appreciate the reply! Thank you!

Hi, I just wanted to come back and see if the team was still actively developing an option for indrops v3 ? I am stuck unfortunately at the moment, I have tried to do the following:
Join R2 and R4 files:
join <(zcat  <  indrop_R2.fastq.gz | nl ) <(zcat < indrop_R4.fastq.gz  | nl) | awk -F ' ' '{if ($2 ~ /^@SeqID/ ) {print $4" "$5;} else {print $2" "$3;}}' | gzip >  indrop_R5.fastq.gz
Then custom demultiplex with barcode_splitter:
barcode_splitter --bcfile ../../../../Barcodes_indrop.txt indrop_R1.fastq.gz indrop_R3.fastq.gz indrop_R5.fastq.gz --idxread 2 --suffix .fastq
And then ran kallisto bus:
kallisto bus -o output -x 0,0,16:0,16,22:1,0,0 -t 4 -i Mus_musculus.GRCm38.cdna.all.*idx demux-indrop_read-3.fastq demux-indrop_read-1.fastq
but end up having very low counts per barcode :(, so i am not sure what is going on (i have tried the conventional indrops pipeline, and it works fine for my files in terms of UMIs). Would you perhaps be able to share some information  or help me out ??
Thanks !!

I'm having the exact same issue as Camila with our inDrops v2 chemistry after running the pseudoalignment step with kallisto bus using the "inDrops" argument for the technology.
Putting R1 first, as described by the tutorial, lead to a super low 100,000 reads aligned. So I swapped the order of R1 and R2 in the terminal command, due to R2 being the barcode and R1 being the transcript in the case of inDrops.
This resulted in a very impressive 100 million aligned reads of 150 million reads processed (on an i7-4790 with 16GB RAM in about 5 minutes), further tests proceeded with these 100 million alignments.
As I understand it, inDrops v2 barcode regions are structured as follows:
[variable length barcode1][22-bp W1 sequence][8-bp barcode2][6-bp UMI]
barcode 1 is taken from the pool found here and barcode 2 is taken from the pool found here.
Using just the second barcode file above lead to very few Continuing without the barcode correction step results in a huge number of detected "cells".
Attempting to correct with just the barcode2 whitelist leads to:
Error: barcode length and whitelist length differ, barcodes = 19, whitelist = 15
Attempting to correct with the modified inDrops whitelist that Sina linked leads to very few corrections, just like Camila.
Which inDrops barcode chemistries are directly supported by kallisto bus as well as the downstream correction steps?

We have now finalized the workflow for processing inDrops v3, and have wrapped it into kb.

Could I please ask if you might be able to help me to understand how to process inDrops v3? Specifically, I'm wondering if kb can process inDrops v3 with 4 fastq files.
Thank you for any advice!

I have 4 fastq files, as described on the indrops page:
   # For a V3 run with several parts, with several libraries that are not already demultiplexed
    fastq_path : "{library_prefix}_{split_affix}_{read}.fastq.gz" # Read with be replaced by R1, R2, R3, R4 as appropriate.
    split_affixes : ["L001", "L002", "L003", "L004"]
    libraries :  # The library index is what the expected index read sequence (on a NextSeq, this is the reverse complement of the index sequence)
      - {library_name: "test_lib3", library_index: "ATAGAG"}
      - {library_name: "test_lib4", library_index: "AGAGGA"}

From the indrops page, I can see:

v3 : summer 2016 redesign requiring manual demultiplexing. R1 is the biological read. R2 carries the first half of the gel barcode, R3 carries the library index and R4 the second half of the gel barcode, the UMI and a fraction of the polyA tail.

When I search for a relevant tutorial in the bus tools repo, this is what I find:
https://github.com/BUStools/BUS_notebooks_python/blob/master/dataset-notebooks/indrops_GSM2746895_python/indrops_brain_activity.ipynb
This tutorial expects 2 files (R1 R2), not 4 (R1 R2 R3 R4).
When I run kb --list, I see:
$ kb --list
List of supported single-cell technologies

name         whitelist provided    barcode (file #, start, stop)        umi (file #, start, stop)    read file #
---------    ------------------    ---------------------------------    -------------------------    -----------
10XV1        yes                   (2, 0, 0)                            (1, 0, 0)                    0
10XV2        yes                   (0, 0, 16)                           (0, 16, 26)                  1
10XV3        yes                   (0, 0, 16)                           (0, 16, 28)                  1
CELSEQ                             (0, 0, 8)                            (0, 8, 12)                   1
CELSEQ2                            (0, 6, 12)                           (0, 0, 6)                    1
DROPSEQ                            (0, 0, 12)                           (0, 12, 20)                  1
INDROPSV1                          (0, 0, 11) (0, 30, 38)               (0, 42, 48)                  1
INDROPSV2                          (1, 0, 11) (1, 30, 38)               (1, 42, 48)                  0
INDROPSV3    yes                   (0, 0, 8) (1, 0, 8)                  (1, 8, 14)                   2
SCRUBSEQ                           (0, 0, 6)                            (0, 6, 16)                   1
SURECELL                           (0, 0, 6) (0, 21, 27) (0, 42, 48)    (0, 51, 59)                  1

It looks to me like the INDROPSV3 technology is expecting 2 files, but I have 4 files, and they're split across many lanes.

@slowkow If I understand the setup correctly, bustools expects 3 files for inDrops version 3. You should have demultiplexed by the library index (i5) with bcl2fastq using --create-fastq-for-index-reads. This will give up separate FASTQ files for each "sample" index in I1.
File 0: this is the second index (i7) given by bcl2fastq as I2
File 1: this must contain the barcode and UMI and should be R1 (14 bp)
File 2: this contains the read from the transcript and should be R2 (61 bp)
So your "R3" is not needed as it is for which sample was sequenced, not the cell barcodes.

Can bustools now correct with variable barcode lengths for inDrops v2?

Just to echo what many people have talked about before, I am still having issue using the Kallisto Bus pipeline for inDrops v2 data. I am using Kallisto 0.46.2, which specifies a inDropsv2 option. This allowed input files R1 and R2 in that order with R1 being cDNA and R2 being CB+UMI. However, the barcode list generated from the pipeline is still only 19bp for all, which doesn't adjust for the variable length of barcode. Therefore, I am still getting many fold more cells than expected.
Thank you all for developing this amazing tool! Hope this issue can be resolved soon.

Ok so I went through the kallisto bus code and currently kallisto bus will interpret the four fastq files associated with v3 inDrops as two separate sample files, as is the case for v1/v2. This will give you a BUS file with a huge number of barcodes and incorrect results.. this is not the desired behavior! So currently kallisto bus cannot be used for inDrops v3.
We will get working on v3 and will update the binaries when everything is functional.

Hey there,
I was just wondering if kallisto bus producing bus files with higher number of barcodes were fixed!
Thanks


[ALBERT]HELP! results of do_eval and do_predict NOT SAME

Hi all,
I run one test data file with do_eval and do_predict(then do evaluation) respectively, but the results of evaluation (accuracy) are not same, could you guys give me some hints?

btw, I have fine-tuned a classifier (ckpt-1000 and ckpt-best)

somebody help me pls T_T

or how to save the probabilities used in do_eval?

i was thinking if the ckpts used for do_eval and do_predict are not same? or how to specify which ckpt will be used?


Adds ViewportSettings.Transparent

Fixes
For

#3691

We need the concept of a view that is transparent. In addition I've found that View.Draw has some errors in it regarding in how clipping is done.
This PR fixes those issues and adds the new capability.

Adds ViewportSettings.Transparent enabling see-through/click-through views
Adds ViewportSettingsEditor to Scenarios and expands AllViewsTester to utilize

Proposed Changes/Todos

[x] Add ViewportSettings.Transparent
[x] Add ViewportSettingsEditor to Scenarios and expand AllViewsTester to utilize
[ ] Upgrade ViewportSettings scenario to use ViewportSettingsEditor and illustrate transparency
[ ] Add ViewportSettings.Transparent unit tests

Pull Request checklist:

[x] I've named my PR in the form of "Fixes #issue. Terse description."
[x] My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
[x] My code follows the Terminal.Gui library design guidelines
[x] I ran dotnet test before commit
[x] I have made corresponding changes to the API documentation (using /// style comments)
[x] My changes generate no new warnings
[x] I have checked my code and corrected any poor grammar or misspellings
[x] I conducted basic QA to assure all features are working

Note, it's unlikely that this will support a transparent view with subviews that use transparent shadows.


:arrow_up: Test: update test to use accounts and update viem

Description
Concise description of proposed changes
Testing
Explain the quality checks that have been done on the code changes
Additional Information

[ ] I read the contributing docs (if this is your first contribution)

Your ENS/address:

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1251  👈
#1250
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @roninjin10 and the rest of your teammates on  Graphite


Cannot use DataFormat (enum Turtle, RDFXML, ...) with @okp4/cognitarium-schema

Here is an enum declaration we can find in the schema.d.ts file from @okp4/cogniatrium-schema:
export declare enum RDFXML {
    NQuads = "n_quads",
    NTriples = "n_triples",
    RDFXML = "rdf_xml",
    Turtle = "turtle"
}

When I import RDFXML within a frontend (import { RDFXML } from "@okp4/cognitarium-schema";), I got the following message:
SyntaxError: The requested module '/node_modules/.vite/deps/@okp4_cognitarium-schema.js?t=1695034170441&v=b1b30273' does not provide an export named 'RDFXML'
I am trying to figure out how I can use it. All the other imports work perfectly.
Note that according to the contracts repo, msg.rs from okp4-cognitarium declare DataFormat instead of RDFXML. Strange renaming, don't know if it's related.
Quicktype Issue submitted by @bdeneux: https://github.com/glideapps/quicktype/issues/2410
FYI @amimart @ccamel

@bdeneux What's your analysis of this (rather old) issue?

@ccamel An issue has been reported on the QuickType repository (#2410), and a response has been recently posted. However, there doesn't appear to be any further updates at this time.
I plan to investigate whether this issue also affects another language generation, specifically Go, and will provide feedback accordingly.
We may need to consider exploring other libraries that are more specifically designed for handling JSON schemas in smart contracts.

For TypeScript generation, we could potentially use this library, which is specifically designed for CosmWasm smart contracts: https://github.com/CosmWasm/ts-codegen. The major disadvantage is that this library does not support code generation for other languages.

@bdeneux Yes, great idea! It's a lib that we had already identified, but without going any further. To be assessed. 🤓


FIx: advance_internal should return error instead of using assert

Assert may evaluate to empty expression which means that an error removed
from call to extract_number may get missed. It is better to return it,
and let it be processed further.
Signed-off-by: Dominik Ermel<EMAIL_ADDRESS>

hi,  looks ok to me but you may have to rebase to fix CI issiues

Abandoned.


PR HDX-10162 Convincing alembic to not try and recreate existing Enums in postgres

Convincing alembic to not try and recreate existing Enums in postgres.
Key was to use postgres specific enums and specify create_type=False
Also printing version number in logs

Does this mean that we do not wish ENUMs to exist in the database, they are something that exists "outside"?
Or is it that these ENUMs have already been created for earlier datasets?

It's the latter. Alembic just doesn't realize that it doesn't need to recreate the Enums when generating automatic revisions. There's an entire discussion here: https://github.com/sqlalchemy/alembic/issues/1254


Question: setting default editor

Is it possible to set docx viewer as the default text opener/editor of docx documents in visual studio code? It is now only possible to view the file with the docx viewer by clicking with the left mouse button and then opening document in the docx viewer.

I have updated the extension to support direct opening of the docx files.
Do an update from the extension store.
Support the project by starring it.
Thank you.


Export User Space

I am trying to export the user space with the following Gazer command
gzr space export 2 --host HOST NAME --no-ssl --dir MY DIRECTORY
and I am getting the following error
/Library/Ruby/Gems/2.3.0/gems/gazer-0.2.8/lib/gzr/commands/space/export.rb:78:in process_space': undefined method gsub' for nil:NilClass (NoMethodError)
from /Library/Ruby/Gems/2.3.0/gems/gazer-0.2.8/lib/gzr/commands/space/export.rb:111:in block in process_space' 	from /Library/Ruby/Gems/2.3.0/gems/gazer-0.2.8/lib/gzr/commands/space/export.rb:110:in each'
from /Library/Ruby/Gems/2.3.0/gems/gazer-0.2.8/lib/gzr/commands/space/export.rb:110:in process_space' 	from /Library/Ruby/Gems/2.3.0/gems/gazer-0.2.8/lib/gzr/commands/space/export.rb:71:in block in execute'
from /Library/Ruby/Gems/2.3.0/gems/gazer-0.2.8/lib/gzr/modules/session.rb:193:in with_session' 	from /Library/Ruby/Gems/2.3.0/gems/gazer-0.2.8/lib/gzr/commands/space/export.rb:48:in execute'
from /Library/Ruby/Gems/2.3.0/gems/gazer-0.2.8/lib/gzr/commands/space.rb:76:in export' 	from /Library/Ruby/Gems/2.3.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /Library/Ruby/Gems/2.3.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' 	from /Library/Ruby/Gems/2.3.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /Library/Ruby/Gems/2.3.0/gems/thor-0.20.3/lib/thor/invocation.rb:115:in invoke' 	from /Library/Ruby/Gems/2.3.0/gems/thor-0.20.3/lib/thor.rb:238:in block in subcommand'
from /Library/Ruby/Gems/2.3.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run' 	from /Library/Ruby/Gems/2.3.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command'
from /Library/Ruby/Gems/2.3.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch' 	from /Library/Ruby/Gems/2.3.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start'
from /Library/Ruby/Gems/2.3.0/gems/gazer-0.2.8/exe/gzr:36:in <top (required)>' 	from /usr/local/bin/gzr:22:in load'
from /usr/local/bin/gzr:22:in `'
This hasn't been happening consistently, but has been happening more so since we have had a second page of users. However, it has worked with 2 pages before so I'm not sure if that is the issue.

This is very odd. The only way this could occur is if the space (or child
space) does not have a name. I'll research this more today.
On Wed, Mar 13, 2019 at 1:34 PM cfrandsen09<EMAIL_ADDRESS>wrote:

I am trying to export the user space with the following Gazer command
gzr space export 2 --host HOST NAME --no-ssl --dir MY DIRECTORY
and I am getting the following error
/Library/Ruby/Gems/2.3.0/gems/gazer-0.2.8/lib/gzr/commands/space/export.rb:78:in
process_space': undefined method gsub' for nil:NilClass (NoMethodError)
from
/Library/Ruby/Gems/2.3.0/gems/gazer-0.2.8/lib/gzr/commands/space/export.rb:111:in
block in process_space'
from
/Library/Ruby/Gems/2.3.0/gems/gazer-0.2.8/lib/gzr/commands/space/export.rb:110:in
each' from
/Library/Ruby/Gems/2.3.0/gems/gazer-0.2.8/lib/gzr/commands/space/export.rb:110:in
process_space'
from
/Library/Ruby/Gems/2.3.0/gems/gazer-0.2.8/lib/gzr/commands/space/export.rb:71:in
block in execute' from
/Library/Ruby/Gems/2.3.0/gems/gazer-0.2.8/lib/gzr/modules/session.rb:193:in
with_session'
from
/Library/Ruby/Gems/2.3.0/gems/gazer-0.2.8/lib/gzr/commands/space/export.rb:48:in
execute' from
/Library/Ruby/Gems/2.3.0/gems/gazer-0.2.8/lib/gzr/commands/space.rb:76:in
export'
from /Library/Ruby/Gems/2.3.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from
/Library/Ruby/Gems/2.3.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in
invoke_command'
from /Library/Ruby/Gems/2.3.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from
/Library/Ruby/Gems/2.3.0/gems/thor-0.20.3/lib/thor/invocation.rb:115:in
invoke'
from /Library/Ruby/Gems/2.3.0/gems/thor-0.20.3/lib/thor.rb:238:in block
in subcommand' from
/Library/Ruby/Gems/2.3.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from
/Library/Ruby/Gems/2.3.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command'
from /Library/Ruby/Gems/2.3.0/gems/thor-0.20.3/lib/thor.rb:387:in
dispatch'
from /Library/Ruby/Gems/2.3.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start'
from /Library/Ruby/Gems/2.3.0/gems/gazer-0.2.8/exe/gzr:36:in <top
(required)>'
from /usr/local/bin/gzr:22:in load' from /usr/local/bin/gzr:22:in
'
`
This hasn't been happening consistently, but has been happening more so
since we have had a second page of users. However, it has worked with 2
pages before so I'm not sure if that is the issue.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/deangelo-llooker/gzr/issues/25, or mute the thread
https://github.com/notifications/unsubscribe-auth/AKQyEZt0OuiIyLTg-11q7dQeJRl-LaZ0ks5vWTaRgaJpZM4bt8Bg
.

--
There are two hard things in computer science: cache invalidation, naming
things, and off-by-one errors. - Martin Fowler

I ran into this as well. It seems like if there are any users that have had their account created but have never logged in (where they will be prompted to enter first and last name) then their space will still exist but with a blank name.

This is a dupe of https://github.com/looker-open-source/gzr/issues/34. I'll close this and keep that one.