Generate static, object-focused documentation of types

Users should not have to read our go code to get documentation of the API types.  They could use swagger-ui.  But the swagger-ui is also not a good presentation because:

It presents too much info about REST that is not relevant to most users:

it talks about POST, etc.  However, people are mostly going to use either Kubectl or pkg/client.  Those don't use the word POST.  Kubectl uses "create" and pkg/client uses "Create()".
it talks about the URLs.  However several parts of the url (api version, namespace) are not things that users normally need to think about when they are using Kubectl.  Mostly they just want to know what fields can be used and what they mean.
you have to click several times to find the schema on the swagger-ui page.

It is not as accessible as markdown documentation

I don't think that the swagger-ui schema blurbs will be indexed in same way that github.com markdown docs are.
is is a different style than the markdown docs.
swagger inlines all subtypes in each object's schema.  This makes the schema overwhelming and defeats the grouping of related things that can be ignored as a group like SecurityContext or various volume plugins.  I'd rather there were links to subobjects.

Therefore, we should generate markdown docs for the API types (but not the REST endpoints).
We could maybe generate this using a go program that reflects the struct tags from all the types in pkg/api/v1/types.go.

I think this is related to #3060

cc @caesarxuchao

FWIW, if all we care about an API type is its description tag, then we can parse the files in api/swagger-spec.

yes let's do that for now.
On Mon, Jul 13, 2015 at 3:02 PM, Chao Xu<EMAIL_ADDRESS>wrote:

FWIW, if all we care about an API type is its description tag, then we can
parse the files in api/swagger-spec.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/10966#issuecomment-121075271
.

Proposal:
for each version in [v1, ...] do:
open api_obects_$VERSION.md
  for each key in "models":
    print subheading for key minus the $VERSION prefix.  this allows easy
linking from other .md
    for each key in properties:
      print "**$NAME**  *$TYPE* $DESCRIPTION\n"
      in case of $ref link to bookmark in this file.

On Mon, Jul 13, 2015 at 3:29 PM, Eric Tune<EMAIL_ADDRESS>wrote:

yes let's do that for now.
On Mon, Jul 13, 2015 at 3:02 PM, Chao Xu<EMAIL_ADDRESS>wrote:

FWIW, if all we care about an API type is its description tag, then we
can parse the files in api/swagger-spec.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/10966#issuecomment-121075271
.

SGTM. Do you want to code it up or shall I? I'd be happy to do it.

Oh, we can parse the model.description for easy API type as well. go-restful will generate model.description, but we have filled in content yet. #5331

Go for it.
On Mon, Jul 13, 2015 at 3:46 PM, Chao Xu<EMAIL_ADDRESS>wrote:

SGTM. Do you want to code it up or shall I? I'd be happy to do it.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/10966#issuecomment-121082848
.

I used json.Unmarshal to unmarshel the spec file to swagger.apiDeclaration. The only problem with this approach is that it doesn't preserve the order of the fields, which is a known problem :(

FWIW, go-restful/swagger.ModelList.UnmarshalJSON also mess the order. It looks like we need a customized UnmashalJSON.
ref #10311

Let's get the basic information in a doc first and then fix up the order in
a later PR.
On Mon, Jul 13, 2015 at 9:25 PM, Chao Xu<EMAIL_ADDRESS>wrote:

FWIW, go-restful/swagger.ModelList.UnmarshalJSON also mess the order. It
looks like we need a customized UnmashalJSON.
ref #10311
https://github.com/GoogleCloudPlatform/kubernetes/issues/10311
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/10966#issuecomment-121129644
.

#10933 is related. Once #10933 is in, we can adapt its WriteSwaggerDocFunc() to write the .md docs.

See also #9097

We have http://kubernetes.io/v1.0/docs/api-reference/definitions.html and http://kubernetes.io/v1.0/docs/api-reference/operations.html now. Close this issue.
Future improvements to those pages include: #11567


Add allowUnrecognizedKeys option

Fixes https://github.com/dart-lang/json_serializable/issues/184
Added on JsonSerializable annotation, defaults to true (old behavior). If false then it throws an UnrecognizedKeysException which contains all the information about the allowed keys, unrecognized keys, etc.
As a part of this I also migrated everything to use blocks instead of fat arrows to simplify the codegen (this requires adding in an additional method call).
@kevmoo not sure how crazy you want me to go with testing here - there is a single test right now in the yaml_test.dart file which is more of an e2e_test as its checking for the actual error output.

Updated @kevmoo PTAL (before you give me more merge conflicts lol)


npm ERR! 404 Not Found

npm ERR! 404 Not Found - GET https://registry.npmjs.org/es-abstract/-/es-abstract-1.14.0.tgz

Can you provide more context? When do you see this error?

I checked the versions of es-abstract, 1.14.0 isn't there. I just used 1.14.1 or 1.14.2 instead, and problem got fixed.

I have removed the package-lock.json file from the APM folder (assuming that is what you are installing?) Let me know if that helps as well.


Incorrect return value from $bits function

Version
Yosys 0.24+10 (git sha1 3ebc50dee, gcc 9.3.0-22 -fPIC -Os)
On which OS did this happen?
Linux
Reproduction Steps
While processing a single element of typedef struct packed by a $bits function, it returns size of a whole structure.
Example design:
module top(output int o);

	typedef struct packed {
		logic [1:0][15:0] v_2x16;
		logic [1:0] 	  v_2bit;
	} struct_2el;

	struct_2el array;

	assign o = $bits(array.v_2x16[0]);
endmodule

Executed commands:
$ yosys
yosys> read_verilog -sv -dump_vlog2 top.sv

It should return a size of single [15:0] element of v_2x16.
Expected Behavior
Yosys should inffer a value equal to a size of an expression passed to $bits:
assign o = 16;

Actual Behavior
Yosys inffers a value equal to the size of a whole structure:
assign o = 34;

I have a patch for this, which depends on #3661. Once that is merged, I'll make a pull request.


Disable Removal mode

Does leaflet.pm have any way of disabling Removal mode programmatically?
map.pm.toggleGlobalRemovalMode() allows it but I can't define does Removal mode active now.
Does leaflet.pm have something like disableGlobalRemovalMode() or method for checking Removal Mode state?

yes,
map.pm.globalRemovalEnabled();

returns true when global removal mode is enabled. It currently returns undefined or false when not. The next release will fix this and it always returns false when disabled. But you can check against true now already.


MHI-AC-Ctrl working MQTT communication with SRK 63 ZR, but MHI-AC-Ctrl-ESPHome does not show any communication

I tried first to run my SRK 63 ZR with the D1 Wemos with MHI-AC-Ctrl-ESPHome, this does nothing besides connecting with Wifi. I flashed this via the python interface from ESPHome.
Afterwards I tried to flash the D1 Wemos with the original MHI-AC-Ctrl project and then I can clearly see the MQTT communication working in the MQTT explorer.
What is going wrong? I saw somewhere in the files that it includes arduino.h, but I did not put that file in the directory, might that be the issue? Or anything else?
See attached the MQTT communication from the MHI-AC-Ctrl program.
Thanks!

Any feedback?

what is the content of your esphome yaml file? did you include:
esphome:
includes:
- mhi_ac_ctrl.h
- MHI-AC-Ctrl-core.h
- MHI-AC-Ctrl-core.cpp

Ok, thanks for your answer. I will check!


Add Image Search API Swagger

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[x] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[x] My spec meets the review criteria:

[x] The spec conforms to the Swagger 2.0 specification.
[x] The spec follows the guidelines described in the Swagger checklist document.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Please review and fix linter and model errors.
Linter: https://travis-ci.org/Azure/azure-rest-api-specs/jobs/309660037
Model: https://travis-ci.org/Azure/azure-rest-api-specs/jobs/309660038

No modification for AutorestCI/azure-sdk-for-python

No modification for AutorestCI/azure-sdk-for-node

No modification for AutorestCI/azure-sdk-for-ruby


Bug fixes for Yearn v2.1 site/SDK before launching

Feedback based on current state of site at https://pr-175.yearn.dev/vaults

This is an interim solution as I work to get the Trello and GitHub issues linked up. Please tick off items on the board as you complete them, and feel free to claim them in comments below as well so we avoid two people working on the same issue at once.

Need to have

[x] Instead of using monthly share price APY extrapolation, default to the higher of two values between monthly and weekly.
Reasoning: Almost always, with share price calculations, we are under-representing our APY.
Weekly APYs are preferable to monthly when a vault harvests frequently and the harvested asset has gone up in price recently, or if the vault is more active than it was in previous weeks.
Monthly APYs are preferable for vaults that harvest less frequently, and will give a smoother picture of APY (potentially lower percentage of days without a harvest).
[x] If gauge is zero, assume 2.5x boost, not a 1x boost. sUSD, HUSD, AAVE, RENBTC, TBTC, PBTC all currently have this problem.
[x] Truncate boost value on hover to two decimals, currently shows way too many
[x] Fix tooltip APY spacing (100%+ is too far over for USDN)
[x] Manually update displayed USDN APY for now since we're pulling 80% for backscratcher

[x] Add disclaimer in drop-down menu for USDN as well like we had for DAI after hack. Something like 80% of USDN CRV yield is deposited to yveCRV. APY of ~20% is accurate after accounting for this.

[x] Update APY calculations for crvSTETH vault. Currently this is being treated as a Curve vault, but it is not boosted, and should be treated as a normal v2 vault.
[x] For yveCRV, multiplier column should pull data from currentBoost in the API and Growth should pull from totalApy in the API
[x] Reorder the appearance of the data in the Curve vault hover so it reads:
Pool APY + CRV Boosted APY (blank line after this title)

Pool APY xx%
Base CRV APY xx%
Boost xx
Total APY xx%

[x] Copy for yveCRV hover could read as this:
yveCRV Admin Fees (blank line after this title)

veCRV APY xx%
Boost xx
Total APY xx%

Nice to have

[x] Calculate APY for non-Curve vaults (both v1 and v2) without fees subtracted. Since Curve vaults will be showing APY with and without fees, we should do the same for all other vaults and can extrapolate using our after-fee yield.

[x] For v1 vaults, the math is as follows: Gross APY = Net APY / (1 - sum of strategistFee, treasuryFee, fee, and/or performanceFee)
[x] For v2 vaults, the math is as follows: Gross APY = (Net APY / (1 - performanceFee)) + managementFee

[x] Create SDK endpoints for fees

[x] For v1 vaults, pull strategistReward, treasuryFee, withdrawalFee, fee, performanceFee from the strategy contract. strategistReward, treasuryFee, performanceFee can be summed as one fee in the endpoint since they are all performance fees, and withdrawalFee, fee can be put into the same endpoint since they are withdrawal fees.
[x] For v2 vaults, pull managementFee and performanceFee fields from the vault contract. These should be kept as separate endpoint since the management fee is calculated on TVL, whereas performance fee is only on earnings.
[x] For v1 Curve vaults, pull keepCRV as well (this is CRV reserved every harvest for boosting yield)

[x] Show Net APY somewhere in UI

[x] Easy option: add it to the bottom of the hover tooltip for each vault's APY
[x] Improved option: Reorder columns on vault page, removing version column and replacing it with fees column that sits right after growth. Fees column can have all fees listed above for each vault, as well as the Net APY displayed.
[x] Could also consider making this column NET APY instead, display the net APY, and then show fees on hover.
[x] For non-Curve vaults (and crvSTETH), Net APY is the APY that is currently calculated using share price. For Curve vaults, Net APY can be calculated from the current Curve APY as so:

[x] Curve Net APY = Boosted CRV APY * (1- keepCRV - totalPerformanceFee)
[x] Note that totalPerformanceFee in the formula above is simply the sum of a vault strategy's strategistReward, treasuryFee, and/or performanceFee values

[x] Add tooltip next to GROWTH that explains what it means
[x] If we add FEES, add tooltip next to it explaining it as well
[ ] If possible, would be great to get this issue knocked out as well to show dollar holdings instead of base asset holdings (https://github.com/iearn-finance/yearn-finance/issues/130)

everything except for linked issue (iearn-finance/yearn-finance#130) finished, closing


Maybe Breadcrumb should be called Beadcrumbs ?

We basically standardized around the singular version of the word for all the components - while agreed that Breadcrumbs in particular is probably a good candidate for the plural, for consistency we stuck with the singular.

We should update tabs to tab for consistency

I think the discussion around this was to keep Tabs plural because there will always be more than 1 tab, whereas with Breadcrumb, there could be an instance where there will only be one Breadcrumb.

I think Breadcrumbs with one item is a degenerate case (just like Tabs with one tab) and it should be pluralized, just like Tabs.

A single Breadcrumb is more common than a single Tab.
In our usage docs for Breadcrumb

Breadcrumbs enables users to quickly see their location within a path of navigation and move up to a parent level if desired. Each tier of the Breadcrumb should be clickable.

☝  In other words, we use Breadcrumbs for nested location paths in our navigation.
For example,
Navigating through a set of nested paths ensures that you're always going to hit the first Breadcrumb, which would exist as a single Breadcrumb.

Then, navigating deeper into the nested paths will result in multiple Breadcrumbs.

And so on, and so on.
Therefore, it should just be named Breadcrumb.

Breadcrumbs ~enables~ enable users to quickly see ...

I'll make that grammar fix 😄

I think there is always a collection of breadcrumbs tiers, even if there is one tier only, it still is a collection and should be called Breadcrumbs (plural).


Separate in two different controller the static resources and actuator operations

Currently, the "FlightRecorderEndpoint.java" file contains both the actuator operations and methods to get static resources.
It could be a great idea if we can separate them. I can help you if you are interested.
Basically, the solution is to create a RestController just in the management context.

Fix merged to master. Thank you for your contribution!

Fix merged to master. Thank you for your contribution!

Ok perfect! We can close this issue. Do you do it?

Ok perfect! We can close this issue. Do you do it?

This is done!

This is done!


Set up Google Cloud Storage Bucket

As a developer I want an Google Cloud Storage bucket set up inside the global climate strike GCP project so that I can upload files to it.
Acceptance Criteria:

Google Cloud Platform projects exists for Global Climate Strike
GCP Cloud Storage bucket created. It can be called "digital-climate-strike" or something similar if that name exists already.
It should be read only for now. We will make it writable in a separate issue.

Notes:

We ideally collaborate with 350.org who manage globalclimatestrike.net to set up GCP and GCS stuff. We might need to ask them for a credit card...
This might be hard as they are pretty busy, so we could pivot to doing it all ourselves.
Reach out to @dtoakley for collaborating with 350.org folks!

This has been completed just using my personal Google Cloud Account and a test GCS bucket. Once we speak with 350 about the approach, we can migrate to a new bucket that's production ready.

Closing this off -- we can do another issue if/when we get a production bucket.


Added Bungo Stray Dogs S5, Hataraku Maou-Sama S2, Spy Kyoushitsu S2

Subsplease subs (dont know how to do kitsu IDs)

Thanks, @SnipersLaww. Same rules were submitted in #134 and #136 earlier though, so I'm closing this pull request.
For Kitsu IDs, you can either use the response from the API endpoint (e.g. https://kitsu.io/api/edge/anime?filter[text]=Bungou Stray Dogs) or the URL of poster images (e.g. https://media.kitsu.io/anime/47258/poster_image/large-0b9473b509671edb02df885979461cab.jpeg).


chore: update .asyncapi-tool

Removed Java as a language form asyncapi-tool file
Followup for https://github.com/asyncapi/java-spring-template/pull/339

Hey @derberg, @Tenischev please take a look at this

Also @Tenischev and @derberg please take a look at these:
https://github.com/asyncapi/java-spring-cloud-stream-template/pull/342
https://github.com/asyncapi/java-template/pull/140
https://github.com/asyncapi/html-template/pull/452

/rtm


Memory Issue

Hi,
Thank you for sharing your code publicly, but I'm having some memory issues when running it on AWS.
I'm spinning a g2.2xlarge instance on AWS and try to run your code for only the first 1000 lines of news.2011.en.shuffled.
Have you ever got an error message like this one (see below)? And if so, is there a way to change the parameters to avoid or maybe should I select another type of AWS instance?
Just for completeness these are the parameters I was trying to test
NUMBER_OF_ITERATIONS = 20000
EPOCHS_PER_ITERATION = 5
RNN = recurrent.LSTM
INPUT_LAYERS = 2
OUTPUT_LAYERS = 2
AMOUNT_OF_DROPOUT = 0.3
BATCH_SIZE = 500
HIDDEN_SIZE = 700
INITIALIZATION = "he_normal" # : Gaussian initialization scaled by fan_in (He et al., 2014)
MAX_INPUT_LEN = 40
MIN_INPUT_LEN = 3
INVERTED = True
AMOUNT_OF_NOISE = 0.2 / MAX_INPUT_LEN
NUMBER_OF_CHARS = 100 # 75

And this is the error that I'm getting
Iteration 1
Train on 3376 samples, validate on 376 samples
Epoch 1/5
Traceback (most recent call last):
  File "/home/ubuntu/anaconda3/lib/python3.5/site-packages/theano/compile/function_module.py", line 884, in __call__
    self.fn() if output_subset is None else\
RuntimeError: Cuda error: GpuElemwise node_m71c627ae87c918771aac75471af66509_0 Add: out of memory.
    n_blocks=30 threads_per_block=256
   Call: kernel_Add_node_m71c627ae87c918771aac75471af66509_0_Ccontiguous<<<n_blocks, threads_per_block>>>(numEls, local_dims[0], local_dims[1], i0_data, local_str[0][0], local_str[0][1], i1_data, local_str[1][0], local_str[1][1], o0_data, local_ostr[0][0], local_ostr[0][1])

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<stdin>", line 10, in main_news
  File "<stdin>", line 8, in iterate_training
  File "/home/ubuntu/anaconda3/lib/python3.5/site-packages/keras/models.py", line 672, in fit
    initial_epoch=initial_epoch)
  File "/home/ubuntu/anaconda3/lib/python3.5/site-packages/keras/engine/training.py", line 1196, in fit
    initial_epoch=initial_epoch)
  File "/home/ubuntu/anaconda3/lib/python3.5/site-packages/keras/engine/training.py", line 891, in _fit_loop
    outs = f(ins_batch)
  File "/home/ubuntu/anaconda3/lib/python3.5/site-packages/keras/backend/theano_backend.py", line 959, in __call__
    return self.function(*inputs)
  File "/home/ubuntu/anaconda3/lib/python3.5/site-packages/theano/compile/function_module.py", line 898, in __call__
    storage_map=getattr(self.fn, 'storage_map', None))
  File "/home/ubuntu/anaconda3/lib/python3.5/site-packages/theano/gof/link.py", line 325, in raise_with_op
    reraise(exc_type, exc_value, exc_trace)
  File "/home/ubuntu/anaconda3/lib/python3.5/site-packages/six.py", line 685, in reraise
    raise value.with_traceback(tb)
  File "/home/ubuntu/anaconda3/lib/python3.5/site-packages/theano/compile/function_module.py", line 884, in __call__
    self.fn() if output_subset is None else\
RuntimeError: Cuda error: GpuElemwise node_m71c627ae87c918771aac75471af66509_0 Add: out of memory.
    n_blocks=30 threads_per_block=256
   Call: kernel_Add_node_m71c627ae87c918771aac75471af66509_0_Ccontiguous<<<n_blocks, threads_per_block>>>(numEls, local_dims[0], local_dims[1], i0_data, local_str[0][0], local_str[0][1], i1_data, local_str[1][0], local_str[1][1], o0_data, local_ostr[0][0], local_ostr[0][1])

Apply node that caused the error: GpuElemwise{add,no_inplace}(GpuDot22.0, GpuDimShuffle{x,0}.0)
Toposort index: 207
Inputs types: [CudaNdarrayType(float32, matrix), CudaNdarrayType(float32, row)]
Inputs shapes: [(20000, 700), (1, 700)]
Inputs strides: [(700, 1), (0, 1)]
Inputs values: ['not shown', 'not shown']
Outputs clients: [[GpuReshape{3}(GpuElemwise{add,no_inplace}.0, MakeVector{dtype='int64'}.0)]]

HINT: Re-running with most Theano optimization disabled could give you a back-trace of when this node was created. This can be done with by setting the Theano flag 'optimizer=fast_compile'. If that does not work, Theano optimizations can be disabled with 'optimizer=None'.
HINT: Use the Theano flag 'exception_verbosity=high' for a debugprint and storage map footprint of this apply node.

This is an out of memory issue
I believe reducing the batch size to 25-50 should solve it.

I changed the code to do iterative training with a generator. It now runs
nicely on my laptop without needing to limit the amount of data!
You might still need to limit the batch size to fit your specific memory
availability.
On Feb 28, 2017 1:53 AM, "Parth Mehta"<EMAIL_ADDRESS>wrote:

This is an out of memory issue
I believe reducing the batch size to 25-50 should solve it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/MajorTal/DeepSpell/issues/10#issuecomment-282896341,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA9lwTvjoq-ooLNhyzh1QRNh1XAuhqiCks5rg2HrgaJpZM4MHfwQ
.

thanks @parth126 and @MajorTal! I was wondering, based on your experience, what's the average running time I should expect for one epoch to train the entire news.2011.en.shuffled dataset?
My problem is that I ran the code for just one epoch and I extrapolate the time it should take to reach 20,000 iterations I'm left with years of training!

I just moved to the news.2013.en.shuffled (much larger) - I'll update the code to reflect that.
It is so large that I split the epochs to mini-epochs that cover about 1% of the data (because I save the model after each epoch and because it is taking so long...).
These mini-epochs are configured to run about 30 minutes.
After about 2 hours you already see meaningful results (about 85% accuracy).
I used this AMI to train the system: https://aws.amazon.com/marketplace/pp/B06VSPXKDX
On an AWS EC2 p2.xlarge instance (currently at $0.9 per Hour)

@MatteoTomassetti @MajorTal I was running this exact code with the default news.2013.en.shuffled dataset (changed almost nothing except to update Keras API calling to newer version and adapt the code to be python 3 compatible). After almost 2 days of training (on reasonable speed, was using Azure with K80) the accuracy is stuck at about 47-48%. I also noticed that while it had been able to fix many spelling mistakes, it always repeat the last character or just add trailing periods to the prediction and therefore marked as wrong. Do you have any idea what could be happening? I have been looking around and could not find good answer.

If I recall correctly, the trailing periods are how I used to signal the
end of the sequence and they should be stripped off.
Also - I don't remember if the hyperparameters are optimized in any way in
the latest code. I changed the data significantly so that I can open source
the code from the version we used internally.
Thanks,
Tal Weiss
+31-6-1165-8778
Skype: major.tal
https://twitter.com/majortal
On Thu, Nov 16, 2017 at 4:20 PM, FMFluke<EMAIL_ADDRESS>wrote:

@MatteoTomassetti https://github.com/matteotomassetti @MajorTal
https://github.com/majortal I was running this exact code with the
default news.2013.en.shuffled dataset (changed almost nothing except to
update Keras API calling to newer version and adapt the code to be python 3
compatible). After almost 2 days of training (on reasonable speed, was
using Azure with K80) the accuracy is stuck at about 47-48%. I also noticed
that while it had been able to fix many spelling mistakes, it always repeat
the last character or just add trailing periods to the prediction and
therefore marked as wrong. Do you have any idea what could be happening? I
have been looking around and could not find good answer.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MajorTal/DeepSpell/issues/10#issuecomment-344955007,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA9lwXa8tiAXnktUMMzpOe21hYhFTsAQks5s3FK4gaJpZM4MHfwQ
.

Ok, but then how did you make the model know to exclude those periods when calculating the accuracy? How exactly did you strip them off?


"make check" fails due to Test3 jobs

"make check" is failing on master.
It looks like the jobs being queued on Test3 (Job 13 at least) is somehow getting moved to Test2 when the job is started instead of doing a "remote" print from Test3 to Test2 using the IPP backend.
Test3 is a hardwired remote queue that points to Test2.

So the Create-Job request is going to Test2 but the Send-Document request is going to Test3. Problem is probably in _cupsConnectDest where we determine the resource path and URI for the queue.

but cupsd is returning printer-uri-supported = Test2...

and in cupsd we were incorrectly setting printer-uri-supported attribute for hardwired remote queues and then also returning the local queue (printer-uri-supported returned twice...)

[master d2f1a784c] Fix "make check" failure (Issue #5033)


Seeding/updating design docs into DBs post creation

So, during app life-cycle, design docs may be added/edited against private and shared DBs. Is there a mechanism in SL right now which can automatically update them into the existing DBs during app startup?
Why this is important?
The DBs are created and maintained by SL. It needs the design docs in a certain format (seed) and already has support to add them in the created DBs. However as the app develops further, there will be changes to these docs and it'd be tedious to have an update mechanism outside of SL.
As of now, my test app is in early stages of development, so it is trivial for me to reset the SL DBs and begin again, in case I need new design docs seeded, but this is not scale-able and I'd soon need to maintain new/changed design docs in both the CouchDB format as well as seed format and would need to come up with a process of updating these changes.

When you create a user or add a new database to an existing user, SuperLogin automatically seeds the design docs that you specify in your config. If you update the design docs later you will need to manually reseed them.
Maintaining DBs seeded with the correct design docs as they update is complex and outside the scope of SuperLogin. I would love to see an external plugin to help with the tedious tasks of managing userDBs.
SL uses pouchdb-seed-design behind the scenes.

So, while trying to solve this for my app, I went through the code of addUserDB and pouch-seed-design. Apparently, this flow is already taking care of -

Ignoring existing DBs.
Seeding only changed docs in the said DB.
For me, simply invoking superlogin.addUserDB in the login event should work, as it will not recreate the DB but still update only changed/new design docs.
However, I think with this minimal logic, Superlogin can internally take care of this need without much complication.
Please provide your thoughts. I can request a PR.

I've been giving some thought to this and we definitely need a user database manager. This is not only to keep the design docs up to date when they change, but also to add and remove user roles and change permissions.

We also have the need for this, if only to more easily develop a validate_doc_update function.
So I've started on a script we can run as util. A pitty is that most of it's logic is almost a direct copy of dbauth/index.js's addUserDB function. It currently only creates & updates shared databases and it doesn't update existing sessions. (See my question here: https://github.com/colinskow/superlogin/issues/152#issuecomment-299838523)
const SuperLogin = require('superlogin');
const superloginConfig = require('../superlogin.config.js');
const DBAuth = require('superlogin/lib/dbauth');
const PouchDB = require('pouchdb');
const seed = require('pouchdb-seed-design');
const util = require('superlogin/lib/util');

const superlogin = new SuperLogin(superloginConfig);
const { config } = superlogin;
const dbAuth = new DBAuth(config/* , userDB, couchAuthDB*/);

if (!config.getItem('userDBs.defaultDBs')) {
  console.log('no userDBs.defaultDBs defined');
  process.exit();
}

const cloudant = config.getItem('dbServer.cloudant');
let adapter;
if (cloudant) {
  adapter = require('superlogin/lib/dbauth/cloudant');
} else {
  throw new Error('CouchDB not supported');
}

let allDBs = [];
function addDBs(dbs, type) {
  if (!Array.isArray(dbs)) return;
  dbs.forEach(dbName => {
    const dbConfig = dbAuth.getDBConfig(dbName);
    dbConfig.type = type; // override type
    if (type !== 'shared') return; // private not supported yet
    allDBs.push(dbConfig);
  });
}
addDBs(config.getItem('userDBs.defaultDBs.private'), 'private');
addDBs(config.getItem('userDBs.defaultDBs.shared'), 'shared');

function updateDBs(dbs) {
  console.log('updateDBs: ', dbs);
  return asyncIterator(dbs, dbConfig => {
    console.log('dbConfig: ', dbConfig);
    const { name, adminRoles, memberRoles, designDocs } = dbConfig;
    console.log('updating: ', name);
    let newDB;
    return dbAuth.createDB(name)
      .then(response => {
        if (response !== false) console.log('Created db: ', name);
        newDB = new PouchDB(util.getDBURL(config.getItem('dbServer')) + '/' + name);
        return adapter.initSecurity(newDB, adminRoles, memberRoles);
      })
      .then(() => {
        // Seed the design docs
        if (designDocs && designDocs instanceof Array) {
          // designDocs.forEach(ddName => {
          console.log('designDocs: ', designDocs);
          return asyncIterator(designDocs, ddName => {
            console.log('ddName: ', ddName);
            const dDoc = dbAuth.getDesignDoc(ddName);
            console.log('dDoc: ', dDoc);
            if (dDoc) {
              return seed(newDB, dDoc);
            } else {
              console.warn('Failed to locate design doc: ' + ddName);
            }
          });
        }
      });
  });
}

updateDBs(allDBs).then(() => {
  process.exit();
});

function asyncIterator(args, callback) {
  return new Promise((resolve, reject) => {
    const results = [];
    if (args.length === 0) resolve(results);
    const clone = [...args];
    function loop(arg) {
      callback(arg).then(function (result) {
        results.push(result);
        if (clone.length > 0) {
          loop(clone.shift());
        } else {
          resolve(results);
        }
      });
    }
    loop(clone.shift());
  });
}

I think I've found a way to update current session API keys in databases and re-use the existing dbauth/index.js's addUserDB function. The following function should update all databases according to configuration. Because everything happens in series (not parallel) this should also work for bigger projects.
https://gist.github.com/peteruithoven/b8fd1f60ae526c849479e50a38709590#file-updatedbs-js
Curious what you guys think.

Would it be interesting to add this to the general API, just like removeExpiredKeys?


Exception: Expecting value Line 1 Col 1

{
	"primary": {
	    "host": "ftp.mywebsite.com",
	    "username": "johnsmith",
	    "password": "secretpassword",
	    "path": "/www/",
	    "upload_on_save": true,
	    "tls": true
	}
}

FFS! What is wrong here -- ? Someone please fix the wiki, its not even a proper JSON syntax, how can you put it up in the README file? -- Line 1 Col 1 is that first starting { what's wrong here?

According to http://jsonlint.com/ it's valid JSON.

Same issue. Maintainer, please fix this.

Hi,
the example is valid, I've found out that when this happens the content read is actually empty, hence the complaint about first character.
Unfortunately there never been any clear-cut "steps to reproduce" (it always worked on my end, multiple machines), so I'm working rather blind so far. I have added some checks and retry mechanism, hopefully it helps. If not, please try to enable debugJson in the global settings (accessible from Menu > Preferences > Package Settings)
Thank you


[PoC] Introduce approved task runs

This is a follow-up to this spike: https://docs.google.com/document/d/1cAhQ0WUnR7fc_xNHl_HWKebGXSQwyqp3fHUIeZIfb74/edit
This draft PoC introduces the concept of approved runs to the maintenance_tasks gem. Please note that this code is not at all production-ready and is a work in progress for the purpose of proof of concept.

Why isn't the approval to merge a task to the codebase enough as an approval workflow?

hey, I've answered this question in the doc that is linked in the description.

I'm closing this as it served its purpose for the time being. We will keep in touch on this as I want to revisit the topic on a different branch.


STORM-3862 HdfsBlobStoreImpl should check permission after mkdirs

STORM-3862 HdfsBlobStoreImpl should check permission after mkdirs
What is the purpose of the change
HdfsBlobStoreImpl and HdfsBlobStoreFile will create directory with 700 permission, we need to check if permission is set as expected. Because of the influence of settings such as umask, we need to check whether the permissions are set as expected. If not, we should give them the correct permissions to ensure subsequent normal operation.

Hi @bipinprasad .Could you take a look at this?Thanks

Is there a check to see if the directory already exists with more generous permission than requested?

Hi @bipinprasad ,thanks for your review. I added a permission check to compare the file's current permissions with the granted permissions. These operations are performed after mkdirs. It can be seen that the mkdirs before the patch are all mkdirs(path, permission), and in the DistributedFileSystem, mkdirs(path, permission) has two functions. If the path does not exist, create the path and its parent directory, and respond to the The directory applies a permission, this permission is not permission(the second parameter), but (permission & umask). If path exists, permissions (permission & umask) will be applied to the folder. So the patch here just conforms to the program's mdirs for permission checking. So if the file exists and there are generous permission, mkdirs here will re-give the desired permissions to the folder.

It would be nice to move this functionality into some helper for common code - something lik e createDirWithPermissions(). But it's ok as is.

Hi @agresch ,Thanks for your review. I think it's better to check permission after set special permission.But not all permission is special such as 644 or 755. So if we move this function into some helper for common code perhaps make some misuse for others.


if I add custom font with FontRepresentable protocol, I can not have 2 those types(Font, CutomFont) in one array

Because of error: Protocol can only be used as a generic constraint because it has Self or associated type requirements

@bizibizi Thanks for opening this issue! Im looking into it now!

That's exactly as it should be. FontRepresentable's only implementation is for `Strings, so you have two options if you want to put them in arrays:

Use an array of font names:

var fontNames = ["Lalalla", "Helvetica"]

And then use those strings to create your fonts:
let firstFont = fontNames[0].of(size: 20.0)

Use an array of fonts created from those names:

var fonts = ["Lalalla".of(size: 20.0), Font.americanTypewriter.of(size(20.0))]

As a side note, now that I see of(size:) being used with bare strings, it's entirely unclear what it's doing. I should have called it font(ofSize:).


After update Xcode to version Version 7.3 (7D175)

After updating Xcode I get the following error during compilation:
PhoneIdService.swift:445:50: Expression type 'NSArray' is ambiguous without more context
I have solved it using the following code:
 func abortCall() {
        urlSession.getTasksWithCompletionHandler({
            (dataTasks, uploadTasks, downloadTasks) -> Void in
            for tasksList: [NSURLSessionTask] in [dataTasks, uploadTasks, downloadTasks] **as [[NSURLSessionTask]]** {
                for task in tasksList {
                    task.cancel();
                }
            }
        });
    }

I haven't tested it yes.

Hi, sorry for inconvenience. Fix will be available soon.

fixed, tnx!


Please add me as a contributor to GenevaERS

Please add me as a contributor to GenevaERS

Will check tomorrow for the progress on this item and let you know!  Thanks for recommending Jeffrey.

Hi Fatima - you should receive an invite to the project.  Can you let me know if you do or not?
.invite @00fatima00

Hi Sandy, I haven't received any invite as yet

.invite @00fatima00

.invite @00fatima00

Joined.


Deletion of node in linked list

Hello, @rudrakshi99 @nakul-19 @plazzy99 , I am a GSSOC'21 participant.
I wish to contribute deletion of starting, end and specific position node from singly linked list , doubly linked list and circular linked list with proper comments and clear explanation-
Please assign me this issue ,my code will be in C++ with proper comments and test cases.

I am a GSSOC '21 participant.
I wish to contribute a JAVA code for this issue:
My code will have comment lines to make it explanatory and understandable to everyone.
I will be very happy if I am assigned this issue and allowed to work on this.

Hi!!
I am interested in this project . I wish to contribute C++ code for this issuePlease assign this project to me under GSSOC '21

issue is open at #152


Setup is missing log folder

The readme to explain how to setup works, but the log files in the example folder causes it to not start.
I had to:
mkdir ./example/logs
server git:(master) ✗ touch ./example/logs/listener-http-sys.log
server git:(master) ✗ touch ./example/logs/listener-https-sys.log

The fix seems to be to add this folder and files to: https://github.com/webability-go/xamboo-env/tree/master/example
This will prevent others hitting this same error.
Or change the code to automatically create the folders and files if they are missing.
I am on MAC and using go 1.18...

I just saw that it does create the logs files automatically, so the only change is to create the "logs" folder in that repo.
Manually or the engine does it..

I forgot to mention that i had to delete the go-mod override.
module github.com/webability-go/xamboo-env

go 1.15

require (
	github.com/tdewolff/test v1.0.6 // indirect
	github.com/webability-go/xamboo v1.6.6
	github.com/webability-go/xcore/v2 v2.0.8
)

// replace github.com/webability-go/xamboo => ../xamboo

replace example => ./example

Upgrading to go 1.8 and using the go workspaces would fix this for devs and non devs. It is explained here: https://zerokspot.com/weblog/2022/01/14/workspaces-in-go118/

localhost:82 is not loading the static content.   Any tips ??
➜  server git:(master) ✗ ./start.sh
Deletes all the old .so
Rebuild app.so (user application for site)
Rebuild box.so (user engine)
Run the xamboo
X[sys]: 2022/04/27 09:42:47 Logger starting...
X[sys]: 2022/04/27 09:42:47 Link Log X[errors] to stdout:
X[errors]: 2022/04/27 09:42:47 Logger starting...
X[sys]: 2022/04/27 09:42:47 Build Engines Containers native and external
X[sys]: 2022/04/27 09:42:53 Build Components Containers native and external
X[sys]: 2022/04/27 09:42:53 Stats cleaner launched. Clean every minute.
X[sys]: 2022/04/27 09:42:59 Build Applications External
External APP Main SO library initialized, VERSION = 1.0.0
External APP Main SO library started, HOST = developers VERSION = 1.0.0
External APP Main SO library started, HOST = devapi-for-cors-api VERSION = 1.0.0
X[sys]: 2022/04/27 09:43:06 Link Log L[http][sys] to file:./example/logs/listener-http-sys.log
X[sys]: 2022/04/27 09:43:06 Link Log L[https][sys] to file:./example/logs/listener-https-sys.log
X[sys]: 2022/04/27 09:43:06 Link Log H[developers][pages] to file:./example/logs/developers.log
X[sys]: 2022/04/27 09:43:06 Link Log H[developers][errors] to file:./example/logs/developers-error.log
X[sys]: 2022/04/27 09:43:06 Link Log H[developers][sys] to file:./example/logs/developers-sys.log
X[sys]: 2022/04/27 09:43:06 Link Log H[devapi-for-cors-api][pages] to file:./example/logs/developers.log
X[sys]: 2022/04/27 09:43:06 Link Log H[devapi-for-cors-api][errors] to file:./example/logs/developers-error.log
X[sys]: 2022/04/27 09:43:06 Link Log H[devapi-for-cors-api][sys] to file:./example/logs/developers-sys.log
X[sys]: 2022/04/27 09:43:06 Link Log H[devapi-for-cors-api][stats] to discard
X[sys]: 2022/04/27 09:43:06 Build Applications External
X[errors]: 2022/04/27 09:43:06 Failed to find stat call function: app LogStat <nil>
X[sys]: 2022/04/27 09:43:06 Scanning Listener: L[http].
X[sys]: 2022/04/27 09:43:06 Launching Listener: L[http].
X[sys]: 2022/04/27 09:43:06 Scanning Listener: L[https].
X[sys]: 2022/04/27 09:43:06 Launching Listener: L[https].
X[sys]: 2022/04/27 09:43:06 Link Host H[developers] to L[https] Done.
X[sys]: 2022/04/27 09:43:06 Link Host H[devapi-for-cors-api] to L[https] Done.
X[errors]: 2022/04/27 09:45:12 C[host] No host or site found: localhost 82 /
X[errors]: 2022/04/27 09:45:12 C[host] No host or site found: localhost 82 /favicon.ico
X[errors]: 2022/04/27 10:01:23 C[host] No host or site found: localhost 82 /static
X[errors]: 2022/04/27 10:01:23 C[host] No host or site found: localhost 82 /favicon.ico
X[errors]: 2022/04/27 10:01:28 C[host] No host or site found: localhost 82 /public
X[errors]: 2022/04/27 10:01:28 C[host] No host or site found: localhost 82 /favicon.ico

Going to publish new versions of anything. Huge amount of good changes. basically examples environment and master sites are totally out of sync of main xamboo.

I published the xamboo-env v0.1.0 , is now fully working on xamboo 1.6.6
Thanks

Thanks but did not see main beach change

You welcome. I am also on the process to publish last version of xamboo-master, xamboo-admin and dependent libraries xmodules and wajaf to have anything working like a charm

I was just now looking at some of those repos and realising they were using v1.
I wrote you a few emails, about ideas etc....

I have published the new versions of wajaf, xdominion, xdommask and xamboo-master to work fine with xamboo 1.6

Thanks, I will have another go


widgets help

Hello Wiki Chua
Tell me how to work with widgets..

sorry was busy these days. will get back to u very soon. sorry about this

@Khludev
btw, was thinking about the translation u added in. does it really making sense?
i was half way working on this actually. lol.. but i saw the objective of ur making. to try to generate the pre translated wordings into the stubs. i was thinking to make it more generalize so the localization could be done on demand. what do u think?

btw, was thinking about the translation u added in. does it really making sense?
i was half way working on this actually. lol.. but i saw the objective of ur making. to try to generate the pre translated wordings into the stubs. i was thinking to make it more generalize so the localization could be done on demand. what do u think? @Khludev

@ @Khludev
sorry bout this. but wondering if u have this problem?

Hello.
Everything works fine for me

@ @Khludev
sorry bout this. but wondering if u have this problem?

Hello.
Everything works fine for me

btw, was thinking about the translation u added in. does it really making sense?
i was half way working on this actually. lol.. but i saw the objective of ur making. to try to generate the pre translated wordings into the stubs. i was thinking to make it more generalize so the localization could be done on demand. what do u think? @Khludev

I also thought about localization on demand.
But I already did 3 projects and for each I had to do translations.
At first, I had the idea of creating separate stubs templates in the folder (/resources/stubs/crud/default_trats..)/ But in the future, when changing the stubs of a file in the / crud / default folder, also change it in the / crud / default_trans folder, which time consuming.
If localization is not required, you do not need to copy the translation folder. It is only necessary to pass the __l ($ key, $ default_text) function as the second parameter to the default text.

btw, was thinking about the translation u added in. does it really making sense?
i was half way working on this actually. lol.. but i saw the objective of ur making. to try to generate the pre translated wordings into the stubs. i was thinking to make it more generalize so the localization could be done on demand. what do u think? @Khludev

I also thought about localization on demand.
But I already did 3 projects and for each I had to do translations.
At first, I had the idea of creating separate stubs templates in the folder (/resources/stubs/crud/default_trats..)/ But in the future, when changing the stubs of a file in the / crud / default folder, also change it in the / crud / default_trans folder, which time consuming.
If localization is not required, you do not need to copy the translation folder. It is only necessary to pass the __l ($ key, $ default_text) function as the second parameter to the default text.

@wikichua  What are your ideas for translations?

i think ur solution should be works fine. just bit of tweak to allow change lang on demand. let figure out. as the widget. simply crud:widget. this will create a widget class in the app directory and also the widget  blade according to ur config. crud:widget Tag for example. however there is no charts implemented as i thought this could be various and depend on developer. simplest is just throw in the table. to call and use it. simply @widget(ClassName). note there is not single or double quote in ClassName. so i just leave as it is.

Thanks. @Widget(Menu) worked.
I recently switched to Laravel from Codeigniter.
Therefore, I do not know all the nuances so far.

@Khludev no worries. appreciated ur participate. we learn together.
actually there is alternative way, u will realize i don use npm in this project. in fact. most advise to use it so ur client scripts can be minified and much easier to manage, its like composer. but then, its fine, since this is admin panel.


[Hub Generated] Review request for SipRouting to add version stable/2023-03-01

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Data Plane API - Pull Request

API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your engagement record.

Link to engagement record issue:

Is this review for (select one):

[ ] a private preview
[ ] a public preview
[x] GA release

Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified. Please share a link to the design document for the new APIs, a link to the previous Open API document (swagger) if applicable, and the root paths that have been updated.

Design Document:
Previous Open API Doc:
Updated paths:

❔Got questions? Need additional info?? We are here to help!

 Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

💬 Teams Channel
💌 email

Click here for links to tools, specs, guidelines & other good stuff
Tooling

Open API validation tools were run on this PR. Go here to see how to fix errors
Spectral Linting
Open API Hub

Guidelines & Specifications

Azure REST API Guidelines
OpenAPI Style Guidelines
Azure Breaking Change Policy

Helpful Links

Azure DevTools Wiki

fix https://github.com/Azure/azure-rest-api-specs/issues/22678

API change check
APIView has identified API level changes in this PR and created following API reviews.
communication-data-plane-SipRouting

/azp run


fix(quorum): apiV1QuorumRunTransaction does not behave the same with different types of credentials

Function apiV1QuorumRunTransaction of cactus-plugin-ledger-connector-quorum does not behave the same with different types of credentials
Expected Behavior
We expect Quorum connector to accept the same arguments as a transaction to run apiV1QuorumRunTransaction function independently of the type of credential used for sign the transaction.
Current Behavior
Now, apiV1QuorumRunTransaction can run without gas argument of schema QuorumTransactionConfig only using authentication of type GethKeychainPassword.
Possible Solution
Look at the code for default values of transaction fields and remove them.
We might define required parameters in QuorumTransactionConfig schema (in openapi.json) and validate them with express-openapi-validator package at web services. Autogenerated QuorumTransactionConfig interface will be updated automatically.
Steps to Reproduce

Create a Web3SigningSchema of type CactusKeychainRef (linked to a keychain plugin) or PrivateKeyHex:
const cactusCredential = {
    type: Web3SigningCredentialType.CactusKeychainRef,
    ethAccount: testEthAccount1.address,
    keychainEntryKey,
    keychainId,
}
const privateKeyCredential = {
    type: Web3SigningCredentialType.PrivateKeyHex,
    ethAccount: testEthAccount2.address,
    secret: testEthAccount2.privateKey,
}

Call apiV1QuorumRunTransaction function with cactusCredential, without gas field:
const parameters = {
    web3SigningCredential: cactusCredential,
    transactionConfig: {
        from: cactusCredential.ethAccount,
        to: privateKeyCredential.ethAccount,
        value: 10e7,
    },
  };
const res = await apiClient.apiV1QuorumRunTransaction(
    parameters as RunTransactionRequest,
);

The previous code does not work.

Create a Web3SigningSchema of type GethKeychainPassword with a genesis account:
const gethCredential = {
    type: Web3SigningCredentialType.GethKeychainPassword,
    ethAccount: firstHighNetWorthAccount,
    secret: "",
}

Call apiV1QuorumRunTransaction function with gethCredential, without gas field:
const parameters = {
    web3SigningCredential: gethCredential,
    transactionConfig: {
        from: gethCredential.ethAccount,
        to: privateKeyCredential.ethAccount,
        value: 10e7,
    },
  };
const res = await apiClient.apiV1QuorumRunTransaction(
    parameters as RunTransactionRequest,
);

The previous code does work

Context (Environment)
This issue has appeared when trying different ways to authenticate against Quorum.
Is located at package cactus-plugin-ledger-quorum
Detailed Description
Now, apiV1QuorumRunTransaction can run without gas argument of QuorumTransactionConfig schema only using authentication of type GethKeychainPassword. With CactusKeychainRef and PrivateKeyHex authentication types does not work.
We might require all parameters that are mandatory for Quorum.

@elenaizaguirre Does Quorum support the geth keychain? I'm foggy on the details but I think I read somewhere that it doesn't allow it (could be 100% wrong)

@petermetz  I think that is not the problem because adding gas parameter it works:
const parameters = {
  web3SigningCredential: gethCredential,
  transactionConfig: {
    from: gethCredential.ethAccount,
    to: privateKeyCredential.ethAccount,
    value: 10e7,
    gas: 21000,
  },
};
const res = await apiClient.apiV1QuorumRunTransaction(
  parameters as RunTransactionRequest,
);

Furthermore, the error is not thrown only when using geth keychain, it happens with private key too.

@elenaizaguirre Oh my bad, I misunderstood then. Thank you for clalrifying!


Console.log behaviour

Does the plugin by design change the way the console.log messages are displayed even if the plugin is not activated in the Angular code? Before the plugin was installed, I could easily debug the console log because it would show the source file correctly. Now all log messages seem to originate from the index.js.
If this is the cause of the plugin, I would suggest a configuration option to bypass this mechanism in the development environment.

Hello, appreciate the suggestion. We'll take a look at this problem and try to make a better debugging experience. As for a workaround for Chrome DevTools, you can go to sources and find node_modules/@newrelic/newrelic-capacitor-plugin and add index.js to the ignore list. You should be able to see your source files after that.

Thanks for the advice, that fixed the source files issue. There are still other issues though, like not being able to drill down to logged objects, but hopefully the debugging experience will be improved in the future. Good luck!


Crash after opening multiple 600Mb files.

VSCode Version: 1.23.1
OS Version: Windows

Steps to Reproduce:

Open multiple 500+ Mb files simultaneously until it crashes.

@redknightlois Are you using VSCode 32bit or 64 bit? It can be possible that it crashes as it exceeds the memory limit of Chromium, can you try to run VSCode with a higher memory limit, for example, Code.cmd --max-memory=4096 to see if it mitigates the issue.

Mhh after the update to 1.24.0 I cannot even open a single one: Unable to open 'adhoc-2018.csv': Invalid string length.

I can reproduce this issue with single files with what I assume are weird line breaks (large, but at the 380MB mark) - thought I would mention that Wordpad has no issue opening them, which blew my mind.

Similar issue encountered here with vscode, "invalid string length" when opening one-line json file of 43~MB size.
Seems to be common across text editors, though, I had to resort to writing a python program to manipulate in chunks.

@chrmarti you should ping @rebornix

I can verify opening 2nd 500MB csv file freeze VS Code on my 16GB mem 2015 RMBP both in stable and insiders.
Don't think Electron 3 alone fixes this.

Closing it now as we have updated Electron from 3 to 6 with increased string len limit and better string mem management from v8. Large file can crash the renderer process when it has many lines or tons of non ASCII characters but if you think the file is normal and it crashes vs code for other reasons, feel free to open new issues.


SqsActiveJob doesn't need Rails

Thanks for creating SqsActiveJob! I've tested it and it seems to work well.
My feature request is to split SqsActiveJob into it's own gem and remove the dependency on Rails. The ActiveJob gem does not require Rails. Lambdas can run Ruby. A lightweight Lambda could have a few gems not including Rails and be very effective at background job processing.
I've tested the project after removing 3 Rails references:

Logger - A Rails logger is used. To fix this, check if Rails exists. If not, then use the standard Logger instead of the Rails logger.
Config - A configuration file existence is checked in the Rails root. Don't look for this file if Rails doesn't exist.
Polling - The Rails environment is loaded before polling. Don't do this. Instead start whatever environment is appropriate and then initiate polling.

I'd be happy to split this project out myself however not maintaining it in 2 places would be better.

This feature has been released as part of aws-activejob-1.0 - you can now run without rails! (See the readme for details).  Thanks for suggesting this!


Stops FFmpeg from flooding youtube-dl progress with excess download info

[X] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[X] Searched the bugtracker for similar pull requests
[X] Checked the code with flake8
[X] I am the original author of this code and I am willing to release it under Unlicense
[X] Bug fix

A while ago, FFmpeg started echoing every opened URL by default, thereby flooding the terminal and making the youtube-dl progress line unreadable when FFmpeg is used for getting HLS videos.
[http @ 0x7f825281b400] Opening 'http://...' for reading
frame=  258 fps=0.0 q=-1.0 size=    2816kB time=00:00:10.32 bitrate=2234.2kbits
frame=  474 fps=449 q=-1.0 size=    5376kB time=00:00:18.98 bitrate=2319.6kbits
[http @ 0x7f8252824e00] Opening 'http://...' for reading
frame=  732 fps=468 q=-1.0 size=    8192kB time=00:00:29.29 bitrate=2291.1kbits
[http @ 0x7f825281b400] Opening 'http://...' for reading

The commit makes youtube-dl call FFmpeg in a way that prevents the progress line from being flooded.
Closes #13551

Closed due to branch problems. Will create a new one.


[WIP]Changed code architecture in Environment handler to use interface

Signed-off-by: Punith nayak<EMAIL_ADDRESS>
Proposed changes
Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue
Types of changes
What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

[ ] New feature (non-breaking change which adds functionality)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices applies)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have read the CONTRIBUTING doc
[ ] I have signed the commit for DCO to be passed.
[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have added necessary documentation (if appropriate)

Dependency
#4121
Special notes for your reviewer:

Please check the DCO. You haven't signed your commits.

Hey @saranya-jena
Could you kindly confirm if this is what you wanted? If necessary, please provide any specific details or modifications to make it

Did you run the graphql server? I see there are no changes in files calling these functions.

@punithnayak, you will need to make necessary changes wherever these functions are being called. Previously, the functions weren't being implemented by any interface, and hence they could be directly called by importing the package (packageName.function()).
However, with the recent changes you have made in this PR, a struct of type EnvironmentHandler, which will be returned by the NewEnvHandler method you have added, needs to be created in the file where these functions are intended to be called using it. (my_struct_variable_name.function()).
You can probably checkout service.go in chaos-experiments or chaos-experiment-runs package as it has a similar interface-struct implementation.

Closing this PR due to inactivity


Developer' Guide

Crane need a Developer's Guide document to let new craner to know how to contribute code.
The document might include informations like:

How to clone the project.
How to build binary and images from code
How to prepare local environments (Optional)

related doc: https://github.com/gocrane/crane/tree/main/pkg/web

@qmhu Can you assign this issue to me . I would like to work on it .

@qmhu Can you assign this issue to me . I would like to work on it .

Done. Expect to see it soon 👍

Sure👍🏻

「weopen star」I would like to work on it, too~ THX😊

「weopen star」I would like to work on it, too~ THX😊

Also assign it to you. 👍


link: -> file: in package.json

Hello,
For compatibility with newer npm versions:
you might want to change:
"dependencies": {
"@tensorflow/tfjs-core": "link:src/tfjs-core",
"@tensorflow/tfjs-data": "link:src/tfjs-data",
"@tensorflow/tfjs-layers": "link:src/tfjs-layers",
"@tensorflow/tfjs-converter": "link:src/tfjs-converter",
"@tensorflow/tfjs-backend-cpu": "link:src/tfjs-backend-cpu",
"@tensorflow/tfjs-backend-wasm": "link:src/tfjs-backend-wasm",
"@tensorflow/tfjs-backend-webgl": "link:src/tfjs-backend-webgl",
"@tensorflow/tfjs-backend-webgpu": "link:src/tfjs-backend-webgpu"
}
to:
"dependencies": {
"@tensorflow/tfjs-core": "file:src/tfjs-core",
"@tensorflow/tfjs-data": "file:src/tfjs-data",
"@tensorflow/tfjs-layers": "file:src/tfjs-layers",
"@tensorflow/tfjs-converter": "file:src/tfjs-converter",
"@tensorflow/tfjs-backend-cpu": "file:src/tfjs-backend-cpu",
"@tensorflow/tfjs-backend-wasm": "file:src/tfjs-backend-wasm",
"@tensorflow/tfjs-backend-webgl": "file:src/tfjs-backend-webgl",
"@tensorflow/tfjs-backend-webgpu": "file:src/tfjs-backend-webgpu"
}

i'll check if its cross-tool as i use pnpm by default.

done.


stm32: clock_control: Fix flash common latency setting

Fixes #63133

I tested it on disco_l475_iot1, seems to work fine for me!


Where can I add ThreadContext.put to hit all pool threads for Log42j?

Hi,
I'm trying to add a custom parameter to syslog in Log42j. The problem is for this to work I must add ThreadContext.put("NAME", "VALUE") in all the threads that use the logger.
I've tried System.setProperty("isThreadContextMapInheritable", "true") and that doesn't seem to cover all the threads, namely in pools GMS_DB_POOL.pool.PendingConnections, GMS_DB_POOL.pool.ActiveConnections, and GMS_DB_POOL.pool.TotalConnections.
I've tried placing ThreadContext.put() in a few places to no avail.
Where would I place ThreadContext.put() to make sure all the pool threads have the correct value so when they log using log42j they'll have access to the custom value?
thanks

@ToddHoff Set a custom threadFactory.


New SOAR App Repository Request - Cisco SMA (ciscosma)

Name of the app
ciscosma
Integration
Cisco SMA API
About
App which will be able to take actions using Cisco SMA API.

The repo https://github.com/splunk-soar-connectors/ciscosma has been created.

@tonyc-phantom when I have your attention here, is it possible to build my another repo which I requested? I will be super grateful with this issue https://github.com/splunk-soar-connectors/.github/issues/114 🙏🏻


Setup deployment

We should be able to run Airseeker locally and have it deployed on AWS. This task involves choosing a deployment method (for example, serverless framework or AWS tools or other) and setting it up.
This task to be done after #12.

This will just be a container, the cloud deployment is out of scope

I'm just confirming, if cloud deployment is out of scope+this is a container, then this task is a duplicate of https://github.com/api3dao/airseeker-v2/issues/12 ?

Looks like it


fix notification clear button (#4692)

Pull request opened by the merge tool on behalf of #4692

Merged in 11e05ce846853b6d3da02ea7da630199be5b2b2c


Update scalacheck to 1.14.2

Updates org.scalacheck:scalacheck from 1.14.0 to 1.14.2.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalacheck", artifactId = "scalacheck" } ]

Applied Migrations

github:typelevel/scalacheck/v1_14_1?sha=3fc537dde9d8fdf951503a8d8b027a568d52d055

labels: semver-patch, scalafix-migrations

Skipping this version (waiting on https://github.com/typelevel/scalacheck/pull/569 to be released)


Categories failed to load after Nextcloud upgrade

Getting several errors most of the time. It does load occasionally, but I can always do a search.  On opening the app though I get the image attached.

@brusnak  I will try to have a look why this is happening.
Can you give me the version of your nextcloud instance + cookbook plugin version so i can try to reproduce it?

Currently at Nextcloud 22.2.3, however this has happened across my last 4-5
upgrades.  I honestly don't remember the first version of Nextcloud I
installed.
Cookbook plugin is at 0.9.8
On Mon, Jan 10, 2022, 6:01 AM Teifun2 @.***> wrote:

@brusnak https://github.com/brusnak I will try to have a look why this
is happening.
Can you give me the version of your nextcloud instance + cookbook plugin
version so i can try to reproduce it?
—
Reply to this email directly, view it on GitHub
https://github.com/Teifun2/nextcloud-cookbook-flutter/issues/104#issuecomment-1008807269,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAY4ABMQTA3ZHK2COBSOZXLUVLDCVANCNFSM5LTNAGJA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

@brusnak
I checked with the same cloud and plugin combination and everything works well for me.
Therefore i assume it is a problem with a recipe or a recipe category that breaks the load.
If you are logged into your cloud account in the browser can you try to open the following url:
YOUR-HOST/index.php/apps/cookbook/categories
This should show you a json list of all categories in your cookbook. If this is not working i might need a copy of your cookbook or access to a test account on your server to further investigate this :/

Thanks for your reply.  I am getting a json list.  Would the amount of
entries cause an error like this?  I've got about 370-380 entries.
On Mon, Jan 10, 2022, 5:05 PM Teifun2 @.***> wrote:

@brusnak https://github.com/brusnak
I checked with the same cloud and plugin combination and everything works
well for me.
Therefore i assume it is a problem with a recipe or a recipe category that
breaks the load.
If you are logged into your cloud account in the browser can you try to
open the following url:
YOUR-HOST/index.php/apps/cookbook/categories
This should show you a json list of all categories in your cookbook. If
this is not working i might need a copy of your cookbook or access to a
test account on your server to further investigate this :/
—
Reply to this email directly, view it on GitHub
https://github.com/Teifun2/nextcloud-cookbook-flutter/issues/104#issuecomment-1009432770,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAY4ABI374LYQJ7SCI5UAYLUVNQ4RANCNFSM5LTNAGJA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

@brusnak
Well this is weird. This should be the data that is also loaded by the app.
I dont think that this amount of data should result in any problems.
There are a few things that we could still try:

Logout and login to reset authentication
Reinstall the app
Send me a zip of your Recipe folder (so i can load it into my instance and double check if there is an issue). Be careful if you have any recipe / image that you don't want to share!
The part of the code that throws this exception was reworked recently and is not yet released. Maybe the problem just goes away 😞 ?
I get a test account on your instance and can debug directly against your server. (Could be weird issues with web server or web proxy)

Thanks again for all your help.  I went through my entries and deleted
about 10-15 of them that had some weird issues not allowing them to be
edited.  Had to delete through cli.  Anyway, I think this has fixed my
issue.  So far it's worked today.  I'll also update the review in google
play.
On Wed, Jan 12, 2022, 3:10 PM Teifun2 @.***> wrote:

@brusnak https://github.com/brusnak
Well this is weird. This should be the data that is also loaded by the app.
I dont think that this amount of data should result in any problems.
There are a few things that we could still try:

Logout and login to reset authentication
Reinstall the app
Send me a zip of your Recipe folder (so i can load it into my
instance and double check if there is an issue). Be careful if you have any
recipe / image that you don't want to share!
The part of the code that throws this exception was reworked
recently and is not yet released. Maybe the problem just goes away 😞 ?
I get a test account on your instance and can debug directly
against your server. (Could be weird issues with web server or web proxy)

—
Reply to this email directly, view it on GitHub
https://github.com/Teifun2/nextcloud-cookbook-flutter/issues/104#issuecomment-1011453974,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAY4ABIKXGMPKLXWPXPVUF3UVXU4RANCNFSM5LTNAGJA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

Im happy that it worked out for you! Sadly it is very hard to handle the data as so different recipe sites use different and sometimes "wrong" schemas to store the data. This can sometimes lead to this issue.


Fix typo in reference docs

Fix misspelled word in documentation reference page.

reference.html is generated file. Fixing typo in there is useless. I fixed it where it generated from.


[I18n] Add French Translation

Q
A

Bug fix?
no

New feature?
yes

BC breaks?
no

Deprecations?
no

Tests pass?
yes

License
MIT

Just add French Translation file.

Thanks! :+1:

v1.0.9


Indeterminism in shopping-admin best-seller report leads to very flaky eval

There's indeterminism in the shopping-admin website, in the best sellers report.
To recreate, visit this bestsellers report url and click "show report" several times. Each time it is clicked, there will be a random set of products shown.
This means that the for the tasks with ids 0-6 (e.g. "What is the top-1 best-selling product type in Quarter 1 2022"), there's a very high chance to get a different answer each time you execute, which will fail the current eval (more often than not).
A potential fix is to change the magneto configuration to allow for more then 5 rows per aggregate in the bestsellers report such that all items are shown. See this link.
Could you please advise?
Thanks,
Eyal

Thank you for pointing out this potential issue! We are looking into this!

Sorry for the late response. I failed to reproduce the randomness from my end. Can you give a more concrete example like what are values in the three fields, and what are the outputs each time? Thank you!

I tried recreating this as well, and I think the autput is deterministic - so I think there is no bug on the DB side.
I think what @moladeyal saw was that whenever "Order quantity" for multiple items is the same, their ordering is random which is not a bug.
However this example made me capture another bug/weakness of evaluation data. "0.json" says that correct answer is:  "Quest Lumaflex\u2122 Band" while there seem to be three correct answers:

Dash Digital Watch (order quantity == 3 in 1Q 2022)
Quest Lumaflex™ Band (order quantity == 3 in 1Q 2022)
or both as their order quantities are the same.


rolling back data to the previous version

https://github.com/iterative/dvc/issues/599

Also, this could be helpful - https://discuss.dvc.org/t/get-older-version-of-data-files/18

https://dvc.org/doc/get-started/older-versions along with example versioning and multiple mentions in different places, should be enough for now.


Support of Google Cloud Storage for cloud storage

Motivation and context

Add Google Cloud Storage support for cloud storage.
Also update Credentials class to include key_file_path and
add KEY_FILE_PATH as a new credential type which is required for using
google cloud storage.
It is expected to set the key_file_path to the Google cloud's service account key json file.
The specific_attributes for Google Cloud Storage includes:

prefix: key prefix for filtering blobs that going to fetch during initialize_content()
location: The location of bucket if we are going to create a bucket
project: The Google Cloud project id the bucket if we are going to create a bucket

All of the above attributes are optional.
How has this been tested?

Tested manually.
Tested sending HTTP POST to /api/v1/cloudstorages with following body
{
  "provider_type": "GOOGLE_CLOUD_STORAGE",
  "resource": "my_bucket",
  "display_name": "My Bucket",
  "credentials_type": "KEY_FILE_PATH",
  "key_file_path": "/credentials/gcs.json",
  "specific_attributes": "prefix=test"
}

and confirmed the cloudstorages record could be created on DB
To make this call works, we need to ensure /credentials/gcs.json exists on cvat server
and this service account key json file should has permission to access gs://my_bucket
Also tested creating new task data with using this newly created cloud storage
by sending HTTP POST to /api/v1/tasks/:task_id/data with following body
{
  "chunk_size": 1,
  "image_quality": 70,
  "server_files": [
     "test/img1.jpg",
     "test/img2.jpg",
     "test/manifest.jsonl"
  ],
  "cloud_storage_id": 1,
  "use_zip_chunks": true,
  "use_cache": true
}

and confirmed the task could be created, and the all the images could be loaded.
Checklist

[x] I submit my changes into the develop branch
[x] I have added description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[ ] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@jasonkit , thanks for the contribution. Please give us some time to review the PR. We are in the process of adding UI for the feature.
@Marishka17 , please review the PR next week.

@jasonkit , Hi. Thanks for the contribution, please give me some time to test the functionality of the PR.


polishing contig with Nanopore Q20 read?

Hi, may I ask whether you have a recommendation setting for the Nanopore Q20 reads? Something like --quality-threshold 20, --error-threshold 0.05?
Thanks in advance!!

Hello,
I think the default settings should be alright.
Best regards,
Robert


s3 cp copies most files into wrong collection

Sponsors SeaweedFS via Patreon https://www.patreon.com/seaweedfs
Describe the bug
when I create an s3 bucket and copy files to it with the below commands, most of the files get copied into the default collection.
# delete all collections (including default)
curl 'http://seaweed-master:9333/col/delete?collection='
curl 'http://seaweed-master:9333/col/delete?collection=test'
# create one bucket/collection
aws s3 mb s3://test/ --recursive --endpoint-url http://seaweed-s3:8333 --no-sign-request
# create one volume per server
curl 'http://seaweed-master:9333/vol/grow?collection=test&count=7'
# copy files
aws s3 cp /path/to/folder/ s3://test/ --recursive --endpoint-url http://seaweed-s3:8333 --no-sign-request

System Setup
master, filer, s3 running together on one server and volume running on 7 other servers
Expected behavior
all files go into test collection
Screenshots

Additional context
n/a

can not reproduce. Here are my steps. I removed your step to manually create the "test" collection, and removed "--recursive" when using "aws s3 mb"
chris$ aws s3 mb s3://test/ --endpoint-url http://localhost:8333 --no-sign-request
make_bucket: test
chris$ aws s3 cp /Users/chris/go/src/github.com/chrislusf/seaweedfs/weed s3://test/ --recursive --endpoint-url http://localhost:8333 --no-sign-request
upload: command/compact.go to s3://test/command/compact.go
upload: command/filer_copy.go to s3://test/command/filer_copy.go
upload: command/filer_export.go to s3://test/command/filer_export.go
upload: command/backup.go to s3://test/command/backup.go
...
upload: wdclient/masterclient.go to s3://test/wdclient/masterclient.go
upload: wdclient/vid_map.go to s3://test/wdclient/vid_map.go
upload: util/signal_handling_notsupported.go to s3://test/util/signal_handling_notsupported.go
upload: ./weed.iml to s3://test/weed.iml
upload: ./weed.go to s3://test/weed.go
chris-C02XM4FXJGH6:weed chris$ weed shell
> volume.list
Topology volume:7/50 active:7 free:43
  DataCenter DefaultDataCenter volume:7/50 active:7 free:43
    Rack DefaultRack volume:7/50 active:7 free:43
      DataNode localhost:8080 volume:7/50 active:7 free:43
        volume id:4 size:123048 collection:"test" file_count:39 version:3
        volume id:5 size:154040 collection:"test" file_count:29 version:3
        volume id:6 size:377816 collection:"test" file_count:56 version:3
        volume id:7 size:222072 collection:"test" file_count:40 version:3
        volume id:1 size:2408744 collection:"test" file_count:40 version:3
        volume id:2 size:87152 collection:"test" file_count:31 version:3
        volume id:3 size:198480 collection:"test" file_count:38 version:3
> exit

wait, let me check again.

Seems my local test is not using multipart upload somehow with the commands. And this seems a bug for multipart upload.


System tests

Change the travis flags to use -j 2 instead of -j
add a system_test directory and executable.
I will be adding another option to tweak the MSVC builds yet but I want to see if the PR passes

This one probably should be merged next since it fixes the travis gcc builds.  then hopefully the others will pass once develop is merged again.

@kdheepak @nightlark  this PR should go in next, because it should fix the issues in the other PR's.


Fix attachment_host method not being used as a replacement of heroku_attachment_host

Fix attachment_host method not being used as a replacement of heroku_attachment_host

@pjmartorell could you resolve merge conflicts then merge pls?


Update for new compilers

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

Recipe maintainers should be a json list.
Recipe maintainer "c" does not exist

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Best way to handle routing in multiple different places i.e. custom (non-view) classes

I'm currently stuck on looking for the best approach to handling routing within a number of different types of classes (e.g. custom views, data sources, list controllers etc) in my UIKit app.
From the docs and the example project, for most use cases (if not all) the router object is stored in the ViewController or in the ViewModel and passed down when the view is creating inside of the coordinator.
For most instances, this pattern works fine however, when it comes to dealing with something like a re-usable UITableView/CollectionView DataSource/Delegate where you want to visit a new screen on didSelectItemAt it gets quite confusing.
Given this example here, where the app simply displays a list of "products", and a section header for a "user". When a product is pressed, it should navigate to a detail product screen AppRoute.product and likewise for the user. The data source is extracted into a custom class that can be re-used wherever needed.
enum AppRoute: Route {
 case home
 case product
 case user
}

class AppCoordinator: NavigationCoordinator<AppRoute> {
 override func prepareTransition(for route: AppRoute) -> NavigationTransition {
   switch route {
   case .home:
     let home = HomeViewController()
     return .push(home)
   case .product:
     let product = ProductViewController()
     return .push(product)
   case .user:
     let user = UserViewController()
     return .present(user)
   }
 }
}

class ProductDataSource: UITableViewDataSource, UITableViewDelegate {
  // ... other implementation

  func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {
      print("Navigate the user to the detail product screen")
  }
}

So my question really is, how can I implement this functionality and make it re-usable between different views?
I thought possibly passing a reference to the unownedRouter object in the coordinator class to the view controller, then passing this to the dataSource might work but from my testing, the presented classes don't appear as they're just de-allocated. This also isn't the nicest solution IMO.
There are also instances where this would get kind of messy, say in a custom UIView subclass inside of a UICollectionViewCell wrapped in an IGListSectionController that's presented in a UIViewController. It would be a lot of passing down "props" between views or a bunch of delegate protocols.
A naive approach to this would be to just call presentViewController on the UIWindow.rootViewController but this of course would be an anti-pattern.
Is there any solution to sort of global invocating a route from any part of the application?
I'm sorry if I didn't explain my question well enough, I can clarify further if needed

How about using NotificationCenter, closures or reactive programming - would that work? You would need to make sure not to create reference cycles, but otherwise this should work around your issue.

Closing due to inactivity.


Remove preceding "-" if there was only one item in the commit message

On the message generated by git autocommit, maybe it's a good idea to remove "-" if there's only a single message in the commit message.

Please note that this issue does not happen all the time, so sometimes the preceding dash isn't there.


519: Generator for OptionalInt

Changes:

Added OptionalInt implementation to generate Optional<Integer> with invocation using Instancio.create
Added unit tests to verify non-null & random value is generated
Added test under OptionalGeneratorTest to test for nullability by ignoring the Optional type
Refactored existing test. Type definition not required under <> as it is inferred during instantiation

@armandino Here is the first draft for your review. Let me know what you think about this and we can iterate over this implementation based upon your feedback. Thanks 👍

Thanks @varunu28. Did you intend to check in the generator implementation? I was expecting to see a org.instancio.internal.generator.util.OptionalIntGenerator but seems like the PR contains only tests.

Sorry for the confusion @armandino and pointing me in the right direction . I originally referred the implementation of OptionalString and based this implementation upon that. I will start looking into the generator implementation.
I am planning to create an OptionalGeneratorSpec that can be used by other Optional implementations too such as Long or Double. Do you recommend extending the AbstractRandomComparableNumberGeneratorSpec for getting the randomization functionality.

@varunu28 no worries. I didn't provide a lot of details, so that's on me.
The implementation of OptionalIntGenerator will the same as TimeZoneGenerator. The only difference is it would delegate to IntegerGenerator.
It's also best not to modify unrelated classes. The will keep the PR self-contained, with changes related only to the new feature.

Thanks a ton for the helpful pointers @armandino . I have updated the commit based on your feedback. Let me know if you feel this is in line with what you are thinking.

@varunu28 looks good, thank you. Could you please also squash the commits into one?

Thank you @varunu28! Merged.


Adding .gitleaks for identifying test data secrets

Signed-off-by: Tim Walsh<EMAIL_ADDRESS>Red Hat Info Sec identified several embedded secrets in the test data.
This change identifies the files in .gitleaks.toml
Confirmation (test):
cd ~/envoy-source-dir
 docker run --rm -v ${PWD}:/my-repo zricethezav/gitleaks:latest --verbose --path="/my-repo"  --repo-config-path=.gitleaks.toml

The file paths are fully qualified deliberately as using wild cards (regexps) will potentially allow for missing secret files placed in the directory hierarchy.

/retest-required


Move is_data_available check to fork-choice on_block

Address #3170
Note: need to check again the confidence level of this change.

It might be good to upgtrade the fork-choice test format to include if a block is available. (and if not, be able to subsequently become available) but I'm not sure if we should do so here

We could do something like the way we hacked get_pow_block in on_merge_block tests: https://github.com/ethereum/consensus-specs/blob/e9a7a6d40ee853dc2ec3dbcf3b2e9d4f5c6b6c27/tests/core/pyspec/eth2spec/test/bellatrix/fork_choice/test_on_merge_block.py#L29-L50
I'll open a ticket, but probably add it in the next next release?


still show suggestions in string when disable string suggestion

Version:
Version: 1.63.0-insider (Universal)
Commit: 552af97a0170b43c9323bec62211feb184da9749
Date: 2021-11-05T05:15:13.016Z
Electron: 13.5.1
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 21.1.0

some config:
{
  "editor.lightbulb.enabled": false,
  "editor.linkedEditing": true,
  "editor.minimap.enabled": false,
  "editor.quickSuggestions": {
    "strings": false,
    "comments": false,
    "other": true
  },
  "editor.smoothScrolling": true,
  "editor.stickyTabStops": true,
  "editor.suggest.preview": true,
  "editor.suggest.shareSuggestSelections": true,
  "editor.suggest.snippetsPreventQuickSuggestions": false,
  "editor.suggestSelection": "first",
}

Steps to Reproduce:
1.reload VSCode with extension disable
2.open a ts file and type quote, the suggestions still display

Looks like ' is registered as trigger character... Unsure if there is anything from TS. What's unhappy is that snippets are also invoked and showing. I need to remember why that was done

Yes we register ' as a trigger character for import paths:
https://github.com/microsoft/vscode/blob/f1581dcad7b4282dda36b2504ef3721ad5c83a4f/extensions/typescript-language-features/src/languageFeatures/completions.ts#L642

What's unhappy is that snippets are also invoked and showing. I need to remember why that was done

Snippets are invoked with forgein trigger characters because of https://github.com/microsoft/vscode/issues/37166

Having the same issue
Commit: 552af97a0170b43c9323bec62211feb184da9749
Date: 2021-11-05T05:16:20.583Z
Electron: 13.5.1
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.22494

This just came up for Dart too:
https://github.com/Dart-Code/Dart-Code/issues/3670
Dart registers a bunch of trigger characters and because we can't make them conditional based on context, we check them on the server and return 0 completions if the context didn't make sense (for example, when / is the trigger, we won't return anything unless the location is within an import path).
The comments in https://github.com/microsoft/vscode/issues/37166 suggest that snippets should only be showing up if the snippet starts with the trigger character, but that doesn't seem to be what's happening here.

Yes we register ' as a trigger character for import paths:

But this still works in stable. Has there been a recent change here?

Yeah - there was a change in how prefixes to compare snippets against are determined. This is the PR: https://github.com/microsoft/vscode/pull/136210. The challenge with snippets is that their insert positions aren't as well defined as with language completions. I have relaxed the rules and now more unwanted snippets show, esp after trigger characters. I am planning to fix this for November


[Request]: Add zed

Title: Zed
Category: software
Source (.svg):
Website: https://zed.dev/

Checklist (required):

[x] #739

I added a PR with this logo request: https://github.com/pheralb/svgl/pull/451


Regular user does not have permission to add new page

Path:
http://codeforcroatia.org/pages
Problem:
Regular user does not have permission to add new page
Solution:
Remove "Add new page" button to regular users

Fixed by 2483fa9b


Update README.md with tiktok title colab link

Added auto tiktok video title generation demo colab link to Readme.md.

check your notebook carefully and pr again


Docs for 3.3.2

Hello, do you have the docs for this older version anywhere please ? I can't upgrade yet to the latest versions of dependencies

@cAstraea Sorry for this late reply, before version 4, documentation was in the main repo: https://github.com/DamienHarper/auditor-bundle/blob/3.x/doc/00-index.md


Visual test

Hi @BreimerR, could you explain your use case? I did a test here and seems that Compose default Modifier.size() has the same effect side by side.
I think your implementation is perfect to work with applying a base size to the SVG like 32dp is by default, but I think that the name in the Icon should be optional.

Boiler code reduction.
Referenced from here. Instead of using Modifier.size(). The commit resizes all the nodes. Thus no need for the Modifier.
@Composable
fun Icon(){
     Icon(Icons.SomeLargeIcon,modifier = Modifier.size(24.dp))
}

Becomes
@Composable
fun SomeLargeIcon(){
     Icon(Icons.SomeLargeIcon24)
}

I don't think this is a good solution for removing boilerplate, Icons generation generation alot alot alot of code generation that can ingress code size to just not use Modifier.size().
Compose is flexible, you can always create a custom icon function that was size pre defined. I will protype a function for that use case: something like AwesomeIcons.Something.size64

I still think your PR is awesome but generating multiple icons with difference only on the icon size is not a good a idea, but allowing to generate a icon with a specified size would be awesome and this PR also support that.
If you are able to open a new PR adding the scale/size functionality would be awesome.


Raymond/babbage support

Is this all that's needed?  Wouldn't we need a new Babbage / Vasil block here?
https://github.com/SundaeSwap-finance/ogmigo/blob/main/ouroboros/chainsync/types.go#L343-L349
Not to mention the collateral, inline datums, etc.
At the very least, make sure you find a block for the tests that's using the new features, so we can be sure that doesn't break us.


GUI - Interface to generate private, public e certificate for a device

need to use HTTPS

Test OK.

Tested in v0.5.0-alpha.1


README.md: repo was moved to https://github.com/moby/moby/tree/master/libnetwork

libnetwork has been merged to the main repo of Moby  (https://github.com/moby/moby/tree/master/libnetwork) since Docker 22.06.

@thaJeztah PTAL

Probably there should be also issue template saying same? Eventually issues feature can be also disabled in here but before that we need make sure that issues are either handle or moved to Moby.

@olljanat
done

LGTM


What if you want to use less than all of the files associated with a study for a new prep?

E.g. in 10146 I am  processing both the prep info for samples where they have metadata and where they don't have metadata.
So for one prep:
Lane 3, 4, 5, 6, 7, 8 for one:
and
Lane 3. 4, 7, 8 for the other.
Or can I select the 'Lane 3, 4, 5, 6, 7, 8' and it will only use what the processing needs?

This is something we notice before: you can not reuse/share part of a previously used raw file (going to rename the title so is clearer). The current solution is to upload twice. I think we should discuss during the next Qiita meeting so we can discuss the best way moving forward.

Data duplication seems sup-optimal; flagging for group input.

On 11/01/17, this will be on the filepath level and during creation via the GUI.


Adding Eyeglass support

It was removed, but the components used to have eyeglass support to allow easy importing of the sass files. What is Eyeglass?
Could eyeglass support please be added back in to Carbon? This will allow inclusion as a dependency in sass without the need to create a relative link to the specific file. With eyeglass a user would just need to use this in their sass vendor file:
@import 'carbon-components';
thank you!

I think this was removed accidentally when we migrated from GitHub Enterprise to Public, I can add this back in.

Here's the PR: https://github.com/carbon-design-system/carbon-components/pull/293
@scottnath, do you mind taking a look at the PR and see if this change works for you? I don't have too much experience with eyeglass setup.

reviewed. looks great!


⚠ ClamAV has degraded performance

In 6337045, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 237 ms

Resolved: ClamAV performance has improved in e6e5054 after 5 minutes.


Dump video list only

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[ ] Improvement
[ ] New extractor
[x] New feature

Description of your pull request and other information
Youtube-dl's capabilities of retrieving all the videos from a YouTube channel or playlist are excellent, but for very large channels (15k videos), scraping the channel with full downloads on one machine leads to problems, so we would like to distribute the download across multiple machines at various sites. For this, we simply need a list of all the videos in a channel or a playlist. Superficially, the current feature --get-id does this, but in fact it runs the full simulation with lots of requests, which makes it slow and again bears the risk of having the machine banned.
The new option --dump-video-list-only dumps the video list and is best used with -i and -q so the output is a parseable JSON Lines file. To this end, it simply goes through the ie_entries generator and prints every item from it. This has the effect of emptying the generator so that no further requests are done because the video list for processing is 0 elements long.

--flat-playlist --dump-json.

Thanks for the quick reply and sorry for bothering you with this. I can't believe I missed that option and spent quite some time trying to understand the code and adding a small feature that had been there all along...