Exclude tracing for particular service

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you expect to see?
I am looking for a possibility to propagate tracing for particular services.
My tracing config:
[tracing]
#  [tracing.zipkin]
#    httpEndpoint = "http://tempo-zipkin.service.consul:9411/api/v2/spans"
#    sameSpan = true
#    id128Bit = true
  [tracing.jaeger]
    samplingServerURL = "http://tempo-jaeger-http.service.consul:14268/sampling"
    propagation  = "jaeger"
    gen128Bit = true
  [tracing.jaeger.collector]
    endpoint = "http://tempo-jaeger-http.service.consul:14268/api/traces?format=jaeger.thrift"

My idea was that I delete the tracing headers with midelware:
[http.middlewares]
  [http.middlewares.exclude-trace]
    # Define the middleware to exclude tracing headers
    [http.middlewares.exclude-trace.headers]
      # Delete trace headers. See https://github.com/opentracing/specification/blob/master/rfc/trace_identifiers.md
      #  ["X-Request-Id", "X-B3-TraceId", "X-B3-SpanId", "X-B3-ParentSpanId", "X-B3-Sampled", "X-B3-Flags", "traceparent", "tracestate"]
       [http.middlewares.exclude-trace.headers.customRequestHeaders]
        X-Request-Id =""
        X-B3-TraceId =""
        X-B3-SpanId =""
        X-B3-ParentSpanId =""
        X-B3-Sampled =""
        X-B3-Flags =""
        traceparent =""
        tracestate =""
        uber-trace-id =""

Add this middleware to the service route
# Route to nomad ui
  [http.routers.nomad]
    entryPoints = ["https"]
    rule = "Host(`nomad.{{tls_san}}`) "
    service = "nomad"
     middlewares = ["traefik-forward-auth@consulcatalog","exclude-trace"]
    [[http.routers.nomad.tls.domains]]
      sans = ["nomad.{{tls_san}}"]

But that approach does not works. The trace is evertime captured.
Is it in principle possible to achive this ?

Hello @suikast42,
The trace forwarder middleware piece is executed after the user-defined middleware chain, which I think explains why it is not possible for a header middleware instance to stop the trace to be propagated.
Nonetheless, we could keep this issue as a proposal for a way to discard tracing for a particular service, WDYT?

Nonetheless, we could keep this issue as a proposal for a way to discard tracing for a particular service, WDYT?

I appreciate this

Unsubscribe me olease
On Wed, 5 Apr 2023, 23:22 Süleyman Vurucu, @.***> wrote:

Nonetheless, we could keep this issue as a proposal for a way to discard
tracing for a particular service, WDYT?
I appreciate this
—
Reply to this email directly, view it on GitHub
https://github.com/traefik/traefik/issues/9825#issuecomment-1498081310,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACDS5DBMZLRGFMX5BJBILKLW7XH7FANCNFSM6AAAAAAWSZF2BA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Hello @suikast42,
On #9831 the approach taken by @suikast42, to manipulate the request context with a plugin, is maybe a workaround to the middleware approach you wanted to achieve. WDYT?

Hello @suikast42,
On #9831 the approach taken by @caiuskong, to manipulate the request context with a plugin, is maybe a workaround to the middleware approach you wanted to achieve. WDYT?

There is already a an exsiting plugin for adding trace headers  https://github.com/trinnylondon/traefik-add-trace-id/tree/v0.1.5.
I don't have test it know. But if I define the plugin in static config and use it in dynamic configuration as labels should solve my problem I think.


[OTX/XAI] OTX XAI integration for class-wise, det and cls

Summary

Support explain mode for detection & classification
Integration of class-wise saliency map for cls, det

This PR includes
Add DetectionExplainer class to mpa/det/explainer.py
Support ReciproCAM and class-wise saliency map to detection case
Add explain stage
Test Codes
Can test with OTX CLI(please refer OTX cli support, link)

@goodsong81 Thank you for noticing. Resolved conflict and tested in the otx side.


Format & Upload does not work on Windows

the if predicate is vacuously true on Windows, since it uses forward slash instead of backslash
const FILE_DIR = "uploads/"; // line 10

const writePath = path.normalize(`${FILE_DIR}${req.body.filename}`); // line 28
if (!writePath.startsWith(FILE_DIR)) {
  return res.send("Invalid path");
}

one way to resolve this could be to normalize FILE_DIR
const FILE_DIR = path.normalize("uploads/");

Thanks for the notice!
Yes, like you just mentioned, the source code isn't compatible to Windows env.
Let me update the code based on your proposal.

Oh it wasn't actually a good suggestion actually, only meant to illustrate the problem.
I would actually rather just have
FILE_DIR = uploads

instead, then instead of
const writePath = path.normalize(`${FILE_DIR}${req.body.filename}`);

I would prefer to use path.join to obtain a platform-specific path
const writePath = path.join(FILE_DIR, req.body.filename);

https://nodejs.org/api/path.html#pathjoinpaths
Thank you for starting this interesting project, all the best with it 👍


airbnb.io/enzyme has certificate errors for https

Expected: should default to https.
Actual: gives a certificate error.

No github pages support https for custom domains: https://github.com/isaacs/github/issues/156
The URL must be HTTP to work properly.


HEC-DSS - update documentation for 64-bit working commands

The ReadHecDss and WriteHecDss commands need to be updated given fixes for 64-bit Java.

I updated the documentation.  Close this issue.

Actually close the issue.


ci: removed conventional-changelog as version script

I know you mentioned it eariler today but why did you have to remove the changelog?

Cangelog file isn't generated in the new release flow. It is instead added in each release object in GitHub

@enell Are you gonna merge this one?

:tada: This PR is included in version 2.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Bug]: security vulnerability in fast-xml-parser & axios

Is there an existing issue for this?

[X] I have searched for an existing issue

Describe the bug
I got some notifications from Github that there might be some security vulnerabilities in this repo. Please check.

Steps To Reproduce

Expected Behavior
No response
Actual Behavior
No response
Examples, Code Samples, or Screenshots
No response
Environment
No response
What browsers are you seeing the problem on?
No response

Dependency updated in https://github.com/JankariTech/web-app-presentation-viewer/pull/70


Add abstraction for System Modifier Key: ctrl+c on Windows equals cmd+c on macOS

What problem does this feature solve?
Different operating systems use different modifier keys to denominate keyboard shortcuts.

On Windows and Linux, the ctrl key is used. Example: ctrl+c, ctrl+a, ctrl+f etc.
On macOS, the command key is used. Example: cmd+c, cmd+a, cmd+f

However, the command key is mapped to the .meta system key modifier. This makes it very cumbersome to create applications that work correctly on any platform. Instead of using event modifiers, the distinction has to be made programmatically in the event callback.
@keydown.a="onAKey"

const shortcutKey = isMac ? 'metaKey' : 'ctrlKey'
function onAKey($event) {
  if ($event[shortcutKey]) {
    $event.preventDefault()
    selectAll()
  }
}

What does the proposed API look like?
Introduce a new abstract shortcut System Modifier Key that maps to the correct key modifier on each platform.
@keydown.shortcut.a.prevent="selectAll()"

I think we can refer to TipTap using mod instead of shortcut


Update CSS conventions doc

Issue: https://github.com/silverstripe/silverstripe-admin/issues/351

Merge on green.


update-report: migrate GCC recursive dependents

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

When GCC 12 ships (Homebrew/homebrew-core#106755) ships, most (all?)
Linux bottles that depend on GCC will break.
Let's fix that by using the same trick for handling divergent formula
revisions when migrating formulae from linuxbrew-core (#11982). We set
the recorded version_scheme to -1, which spoofs the formula being
outdated. When brew upgrade installs GCC 12, the broken formulae will
have their bottles reinstalled too.
This works because the reinstallation will also rewrite the existing
RPATHs to point to the new version of GCC instead (#13631). This should
handle most of the breakage.

Review period will end on 2022-08-03 at 16:03:14 UTC.

I still need to have a think about corner cases (and my rescues), but this should give you a rough idea.

Just realised: what happens if these formulae are built from source? I didn't think about that.

Review period ended.

Just realised: what happens if these formulae are built from source? I didn't think about that.

#13659


Coding comments

No idea what the current cpp files you have are doing, would be nice to see some commented lines.

Thank you for your feedback, we use UDP protocol to make sure the datagram can be send from client to server and then processes the information and returns a response.


review mc_att_control conversion to control lib

There's interest in resurrecting @jgoppert's mc_att_control conversion to control lib.
https://github.com/PX4/Firmware/pull/4148
https://github.com/jgoppert/Firmware/blob/c51a63daec68fbfae9da6f1c90a46e9abc0b744f/src/modules/mc_att_control/mc_att_control_main.cpp
TODO

get it building again
mc_att_control updates

use gyros directly
review other changes

add Subscription poll method (likely why the cpu usage increased)
update Blocks to preserve existing MC params

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 30 days. Feel free to reopen this issue if you deem it appropriate.
(This is an automated comment from GitMate.io.)


rename function to enable / disable nagle algorithm

Yes, but a getter function requires a new version of smoltcp (see smoltcp-rs/smoltcp/pull/642).

@mkroening Why does CI fail? Any idea?

@mkroening Why does CI fail? Any idea?

Seems to be quite strange indeed. I think we could disable the windows CI for now.

bors r+

bors r+

You also need to remove the job from bors.toml.

bors r+

bors r-

bors r+


non-blocking rate-limiting

Currently the only way get a tocken is calling wait(). I need a non-blocking version (maybe get()) that tries to get a token, but if none is available the method returns with an error instead of waiting
The use-case here is aborting operations if they are over their limit instead of waiting for new tokens.
Is this possible to implement?

Yes. This is already implemented. .try_wait() and .try_wait_for(). Looks like the doc coverage isn't there for these. Will leave this open to address that.

Awesome! I'll fix-up the documentation. Thanks for opening this!
On Sun, Apr 15, 2018, 10:18 AM ma1ko<EMAIL_ADDRESS>wrote:

Thanks! This is exactly what I need. I was just going through the
documantation and couldn't find anything
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/brayniac/ratelimit/issues/30#issuecomment-381422563,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJ_jlyiDZDNi-udZ2GWtj0IGmhr83awOks5to4DLgaJpZM4TVX9n
.


Bad hoisting of CheckSmi in _HashMap.[]=

With r35325 the type feedback signals all Smis to the key comparison in the loop here:
  void operator []=(K key, V value) {
    int hashCode = key.hashCode;
    List buckets = _buckets;
    int length = buckets.length;
    int index = hashCode & (length - 1);
    _HashMapEntry entry = buckets[index];
    while (entry != null) {
      if (hashCode == entry.hashCode && entry.key == key) {
        entry.value = value;
        return;
      }
      entry = entry.next;
    }
    _addEntry(buckets, index, length, key, value, hashCode);
  }
JSON handling regressed as we suffer repeated deoptimizations at this point until _HashMap.[]= switches to stay in unoptimized code.

@ErikCorryGoogle can you check if this work-around is still needed and maybe delete the work around if it is not needed?


"Contributing" document typo

On the last line of the "Contributing.md" document on Github, the command "yarn develop" doesn't work (develop is not defined in package.json). I guess it should be "yarn serve".

Updated. Thank you.


server: set network rate for additional public IPs

Description
This PR fixes #5669

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[x] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan package

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1690

@blueorangutan test centos7 vmware-70u1 keepEnv

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + vmware-70u1) has been kicked to run smoke tests

Trillian test result (tid-2548)
Environment: vmware-70u1 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33630 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5670-t2548-vmware-70u1.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

workaround for #5669 : create port group manually on destination host
for example
[root@ref-trl-2125-v-M7-wei-zhou-esxi1:~] esxcli network vswitch standard portgroup add -p clo
ud.public.668.200.1-vSwitch1 -v vSwitch1

[root@ref-trl-2125-v-M7-wei-zhou-esxi1:~] esxcli network vswitch standard portgroup set -p clo
ud.public.668.200.1-vSwitch1 --vlan-id 668


skipper-adapter-tests: aborting a file in progress should not crash the server Mocha error

From @theo4u on October 6, 2017 6:16
Having error with that part, as mocha don't allow error passed to done as done below in abort.test.js:51
Error returned in console:   Error: done() invoked with non-Error: The request should have returned an error!
from this code below
function (res) {
       return done("The request should have returned an error!");
}

if changed to
 function (res) {
        return done(); // it works , as mocha don't allow param in done callback which it would take as error
}

Copied from original issue: balderdashy/skipper-adapter-tests#3

From @sgress454 on October 6, 2017 14:40
Hi @theo4u -- I can see how this is confusing.  If you are seeing this message, the problem is with your adapter, not the test.  It means that the test is failing because the request should have returned an error, and so line 51 should never even run (see the comments on lines 48-49).
Mocha is fine with calling done without an Error object; it just lets you know that you did.  What we should probably do is replace the line with:
return done(new Error('The request should have returned an error!'));

in which case if the test fails, you'll see:
Error: The request should have returned an error!

From @theo4u on October 8, 2017 20:8
Thanks


Use existing ioexception for Disk::Open() error handling

@akuker I'm getting C/C++ CI workflow run again after each commit, but I don't find anything wrong.

@akuker I'm getting C/C++ CI workflow run again after each commit, but I don't find anything wrong.

Fixed it again.... I had to change the "default branch" to master instead of develop. We wanted all of the pull requests to go into develop by default, but the users to checkout master by default. Doesn't look like Github has a way to do that currently.
Switching to master seemed to re-enable the build job.


Module hiero-base miss tests for functionality of FileClientImpl.createFile

🆕🐥 First Timers Only
This issue is reserved for people who have never contributed to this project or any open source project in general.
We know that creating a pull request (PR) is a major barrier for new contributors.
The goal of this issue and all other issues labeled by 'good first issue' is to help you make your first contribution.
👾 Description of the issue
In the hiero-base module, the FileClientImpl class implements the createFile methods to create files with specified contents and an optional expiration time using the ProtocolLayerClient. However, these methods currently lack unit and integration tests.
Suggested solution
Create a new test class or extend the existing test suite for FileClientImpl to include tests for the createFile methods. Follow the established testing pattern using JUnit to validate both positive and negative scenarios for these methods.
📋 Step by step guide to do a contribution
If you have never contributed to an open source project at GitHub, the following step-by-step guide will introduce you to the workflow.
A more detailed general documentation of the GitHub PR workflow can be found here.

[ ] Claim this issue: Comment below that you are interested in working on the issue
[ ] Wait for assignment: A community member with the given rights will add you as an assignee of the issue
[ ] Fork the repository: You can do that in GitHub (by simply clicking the 'fork' button).
[ ] Check out the forked repository
[ ] Create a feature branch for the issue. We do not have a hard naming definition for branches but it is best practice to prefix the branch name with the issue id.
[ ] Solve the issue in your branch.
[ ] Commit your changes: to your branch. Here it is important to sign-off you commits to fullfill the Developer Certificate of Origin (DCO). More information can be found in our contribution guideline.
[ ] Start a Pull Request (PR): in the hedera-enterprise repository
[ ] Check GitHub Actions: Several GitHub Actions will be triggered automatically for each PR. If a GitHub Action fails and you do not understand the cause of that error do not hesitate to add a comment to the PR and ask the community for support.
[ ] Wait for reviews: Members of the community will review your PR. If a reviewer finds any missing pieces or a problem, he or she will start a discussion with you and describe the next steps for solving the problem.
[ ] You did it 🎉: We will merge the fix in the develop branch. Thanks for being part of our community as an open-source contributor ❤

🎉 Contribute to Hacktoberfest
Solve this issue as part of the Hacktoberfest event and get a chance to receive cool goodies like a T-Shirt. 🎽
🤔 Additional informantion
If you have any questions, just ask us directly in this issue by adding a comment. A general manual about open-source contributions can be found here.

Hi @hendrikebbers @Ndacyayisenga-droid,
I'm interested in working on this issue. Could you please assign it to me

@manishdait it's assigned to you


Add ReprEnum to auto generated models

Fixes #368
With the update of aenum, it seems that it breaks the formmating to enums.
Adding ReprEnum to these models so it format the string properly.
While regenerating the models, it did more changes than expected. I removed the non-related to ReprEnum changes.

Hi @bryanapellanes-okta,
I see you are the one that recently made multiple changes into this repository.
I would like to know if you plan to look at this PR ?
The main change is in openapi/templates/model.py.hbs. Other files are auto-generated from it.

@jbgosselin I apologize for the delay, apparently my notifications are not working :(.  We are in the process of updating our Python Sdk with new tooling and to align with the latest Okta Api specification.  We appreciate your patience while we continue this work.
We appreciate your engagement and thanks for using Okta!


Add async overloads of withLock for FS I/O

When converting parts of the SwiftPM codebase from callbacks to async/await I've stumbled upon uses of file system locking that have to work across an async closure call. This is an additive change and has no impact on the existing blocking non-async uses of FileLock.withLock.

@swift-ci test

@swift-ci test

@swift-ci test windows

@swift-ci test macos

@swift-ci test macos

@swift-ci test windows


WIP: use templated is_negative to avoid warning on some compilers

Related to #2676, #1390, #755, #2712
[Describe your pull request here. Please read the text below the line, and make sure you follow the checklist.]

Pull request checklist
Read the Contribution Guidelines for detailed information.

[ ]  Changes are described in the pull request, or an existing issue is referenced.
[ ]  The test suite compiles and runs without error.
[ ]  Code coverage is 100%. Test cases can be added by editing the test suite.
[ ]  The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header file single_include/nlohmann/json.hpp. The whole process is described here.

Please don't

The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
Specifically, I am aware of compilation problems with Microsoft Visual Studio (there even is an issue label for these kind of bugs). I understand that even in 2016, complete C++11 support isn't there yet. But please also understand that I do not want to drop features or uglify the code just to make Microsoft's sub-standard compiler happy. The past has shown that there are ways to express the functionality such that the code compiles with the most recent MSVC - unfortunately, this is not the main objective of the project.
Please refrain from proposing changes that would break JSON conformance. If you propose a conformant extension of JSON to be supported by the library, please motivate this extension.
Please do not open pull requests that address multiple issues.

Coverage increased (+1.0e-05%) to 99.982% when pulling c9e6028781be1108f5a68e17b1f7779f464e8df7 on nickaein:fix/check-is-negative into 9774e53cd6180c227b020c08298039f24d1c94ce on nlohmann:develop.

Thanks for the PR! I think it would be a good idea to also add the Intel compiler to the CI. Any proposal for this?

Sure! I wanted to play around and see what could be done for this issue.
Adding Intel Compiler(s) is great idea. I will look into it.

@nickaein If you can point me to instructions how to install it in Ubuntu, I can add it to the Docker image I'm using in the CI. I just wanted to make sure these warnings don't come back...

As an update, I installed Intel C++ compiler inside the existing json-ci docker image:
FROM nlohmann/json-ci

RUN wget https://apt.repos.intel.com/intel-gpg-keys/GPG-PUB-KEY-INTEL-SW-PRODUCTS.PUB && \
    APT_KEY_DONT_WARN_ON_DANGEROUS_USAGE=1 apt-key add GPG-PUB-KEY-INTEL-SW-PRODUCTS.PUB && \
    rm GPG-PUB-KEY-INTEL-SW-PRODUCTS.PUB && \
    add-apt-repository -y "deb https://apt.repos.intel.com/oneapi all main" && \
    apt-get update

RUN apt-get install -y --no-install-recommends \
        intel-oneapi-compiler-dpcpp-cpp-and-cpp-classic

And add it to the CI of my fork in this commit: https://github.com/nickaein/nlohmann-json/commit/7cc2c69e9378e270a18cd33ef3f01f550500e455. The pipline for this compiler passes without any issues (link).
Unfortunately, the infamous sign warning (e.g. https://github.com/nlohmann/json/issues/755) is not reproduced on this compiler version. I'm using icpx as the C++ compiler that seems to be Clang-based and is recently released by Intel. There is also an icpc (classic Intel C++ compiler), but I couldn't get it working after few attempts. It might worth the try in the hope that the issue will be reproduced.
Nevertheless, there are other environments that Intel compiler(s) can be installed (e.g. Windows/MacOS). The GitHub Workflow for their setup is available at: oneapi-ci project. While their setup is different from CI of this project, I think it might worth adapting it. This will bifurcate the current CI architecture, but that could be a plus to have these configuration isolated (e.g. not polluting json-ci, having a dedicated cmake/ci-intel.cmake).

Thanks for looking into it! I could reproduce your findings that everything works fine (i.e., without warning on develop) with icpx. (Note to self: do not forget
source /opt/intel/oneapi/setvars.sh

I tried icpc and learned the following:

Out of the box, cmake .. -DCMAKE_C_COMPILER=icc -DCMAKE_CXX_COMPILER=icpc does not work, because system headers are not found.
I could make it work by making gcc point to a system GCC (not the experimental/latest version) with export PATH=/usr/bin:$PATH.

Now I'm stuck with this error message:
/root/json/test/thirdparty/doctest/doctest.h(1238): internal error: assertion failed at: "exprutil.c", line 5535 in make_cast_rescan_operands

          DOCTEST_DO_BINARY_EXPRESSION_COMPARISON(==, " == ", DOCTEST_CMP_EQ) //!OCLINT bitwise operator in conditional
          ^

compilation aborted for /root/json/test/src/unit-user_defined_input.cpp (code 4)

Next, I will check if this may be a doctest issue.
Anyway, I'm thinking of adding the Intel compilers to my Docker.

@nickaein You are 2 hours ahead of me :-) https://github.com/onqtam/doctest/issues/502

Oops, I should've mentioned earlier that I'm going to continue working on this. My bad.
Yeah it was not a straightforward task to setup these compilers. I had to use the following weird compiler flags to get it working. Yours is easier to grasp.
icpc -std=c++11 -gnu-prefix=x86_64-linux-gnu- -gxx-name=g++-9 example.cpp

Having the experience on configuring these compilers, you probably can give your opinion on last point of my previous comment https://github.com/nlohmann/json/pull/2736#issuecomment-829717766. Basically, I think adapting oneapi-ci's Actions workflow may be a good approach as we can cover different variants of Intel compilers (LLVM-based, Classic, Data Parallel C++ aka. icx, icc, dpcpp) on Windows/MacOS/Linux platforms, without polluting json-ci image. Another plus is it would take less effort to adapt their changes in future.
A proof of concept is available on ci/intel-compilers branch of my fork. I copied the scripts from oneapi-ci project and a few changes which can be seen here: https://github.com/nickaein/nlohmann-json/pull/1. A lot of these codes can be easily removed though (e.g. jobs and scripts related to testing different compiler install methods).

Yes, I agree that it may be good to have all the Intel compilers combined at one place - especially since there are also Windows/macOS versions. I'll be happy about PRs!

@nickaein thanks, this solves the problem for me :+1:
I tried sth similar but without success, so kudos to you :)

Hey @nickaein, I took your changes and added them in #3227 together with a CI step for NVCC. I am currently also trying to add a CI step for ICPC. In any case, this PR can be closed now. Thanks a lot for the contribution!

That's awesome! Sorry I didn't have time to finalize this and integrate Intel compiler. Thanks for taking the torch and finishing this up :)


April and before 2024 Contributions - Giki

Tweet：
https://x.com/GikiRun/status/1783773871767945487
https://x.com/GikiRun/status/1784928333589094889
https://x.com/GikiRun/status/1762152902997737676
https://x.com/GikiRun/status/1745637641192919250
https://x.com/GikiRun/status/1745994192143393139
Video：
https://www.youtube.com/watch?v=UZySN9jSRqA
https://www.youtube.com/watch?v=4wvQxW8lTCs
Organized and Hosted the Twitter Space：
https://x.com/aiweb3dao/status/1745113727060586899
Offline Meetup in China and introduced the projects of Polkadot ecosystem
Introduced Neurolanche at 11'13''
https://youtu.be/ou_yPrXF2mA?si=SN6_aMZdT1xoHda8&t=676

To be eligible for the reward, please share your Astar native address.


feat(message): include member data in InteractionReference.user

Summary
Previously, message.interaction.user was just a User; the d["interaction"]["member"] data present in MESSAGE_CREATE/_EDIT is now used to turn this into a User | Member instead.
Fairly old apidocs change, seems like it was missed back then: https://github.com/discord/discord-api-docs/commit/56cea9462fae6a9b6399e5224b090dc2b68a77e0
Checklist

[x] If code changes were made, then they have been tested

[x] I have updated the documentation to reflect the changes
[x] I have formatted the code properly by running pdm lint
[x] I have type-checked the code by running pdm pyright

[ ] This PR fixes an issue
[x] This PR adds something new (e.g. new method or parameters)
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

It's worth mentioning that message["interaction"] has been deprecated in favor of message["interaction_metadata"].
Since interaction_metadata unfortunately doesn't include member data, and because the interaction code handles missing values no matter what, it's fine to implement this regardless for now.


Toolbar not appearing except for download in range bar chart

toolbar: {
show: true,
offsetX: 0,
offsetY: 0,
tools: {
download: true,
selection: true,
zoom: true,
zoomin: true,
zoomout: true,
pan: true,
reset: true | '',
customIcons: []
},
autoSelected: 'zoom'
},
does not show anything on the top right corner except for the download button when using the basic timeline example: https://apexcharts.com/angular-chart-demos/timeline-charts/basic/
I would like to be able to fix the window width using max and range and be able to pan left and right to go through the timeline, but I see no way to scroll horizontally

@junedchhipa, can you point me a little bit in the right direction where to configure this in the codebase?
I'd be happy to spend some time to hopefully come up with a PR :).

Is there any work in progress for this? I would be happy to give a hand and help with the PR


Adding Times Package

Moving logic to get atime and ctime to a package with more architecture support.

@deitch much cleaner and Lstat works well. Forgive me for the confusion.

Yes, quite nice. Thanks!


Profiler update for additional APs

Support AP by obj size for object detection. Will need implementation in zoo as well

implemented general secondary eval metric for ComputeEvalMetric with PR  #23


Feature request: Custom icon from file

I would like to be able to make custom icon from file like unplugin-icons.

Have you try to use also unplugin-icons with this module?

I was planning to create a feature request that is similar to yours, as the need to wrap custom icons in vue component is not that intuitive.
I think if we could change it to work as nuxt-icons module, which is the most intuitive way and the most similar to nuxt terminology in my opinion, it would be more enjoyable to use.

I forgot about nuxt-icons which is a great module. I also like the idea a lot, I usually create a Vue file with the SVG inside the <template> then I directly use the component name in <Icon name="MyCustomSVGIcon" />.
One thing which is bothering my here is about this import: https://github.com/gitFoxCode/nuxt-icons/blob/main/src/runtime/components/nuxt-icon.vue#L7
I am afraid that it might be quite big if it includes a lot of svg icons and is not leveraging tree-shaking.

This issue could be a solution, with this, I would love to find a way to merge those two packages together. WDYT @gitFoxCode ?

+1 This feature will make this the go-to module for icons

+1 This feature will make this the go-to module for icons

+1 As well, being able to to fetch icons on demand from the iconify framework and using custom local icons (assets/icons for example), would be essentially the complete and go-to package.

+1 As well, being able to to fetch icons on demand from the iconify framework and using custom local icons (assets/icons for example), would be essentially the complete and go-to package.

excatly. You can have a better DX by using unplugin icons with the module but it requires some config. Having these features out of the box would make our lifes better

Planned but will be after 3.0 release

Planned but will be after 3.0 release

This is great. Thanks for the amazing work from you and the whole team

Thank you for trusting us!

This issue could be a solution, with this, I would love to find a way to merge those two packages together. WDYT @gitFoxCode ?

Hi, sorry for the delay but the overlap of responsibilities at work and college do not allow me to deal with projects as I would like. I care about easy addition of icons to the site, you can combine the two modules into one. What I would like most is that the icons are imported only if they are used, so as not to serve the user a thousand icons where only three are used on a given page.  This type of module in general should be part of the core of nuxt itself, after all, every website uses icons. The nuxt-icons module itself is in the plans to be rebuilt, I'm limited by the Vite architecture, to make it so that it would be best for the end user I'd have to really dig deep into what's going on underneath the engine - I'm not at the level of experience as the nuxt-lab programmers who could handle this with due respect. The ability to configure a particular folder, icons on demand, etc.

i think that using @Atinux modules with unplugin-icons is a great addition or maybe a way to be able to use custom local json files ?

any update on this?

Could you tell us the steps required to ensure treeshaking and code quality?, I think we can help in our free time.

any update on this?


Intel config

Purpose
The intel config didn't work on Pleiades so I added the switch in the IDWarp intel config which did successfully build on the cluster and relevant pyGeo tests passed. I didn't refactor the rest of the config as it does work but if there are best practices to follow I can do so.
Also edited some Python files to address Black rules that are new since the last GeoGrad PR.
Expected time until merged
No rush
Type of change

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (non-backwards-compatible fix or feature)
[X] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Documentation update
[x] Maintenance update
[ ] Other (please describe)

Testing
Config runs on intel images
Checklist

[X] I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
[ ] I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
[x] I have run unit and regression tests which pass locally with my changes
[ ] I have added new tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation

bump @hajdik

bump @hajdik

I addressed @sseraj's comment and fixed the black check. I'll address the broader restructuring in #15 soon.

@hajdik changes are fine, but I think we should add support for the new intel compiler. See idwarp for reference. Can you add this? We can also add this in a separate PR.


Expense report - System message "randomly selected for review" displayed with markdown

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.5-5
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4703834
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-internal team
Action Performed:
Rrecondition: user A is set as admin-approver and user B is a member of a workspace, as a workspace admin set Randomly route reports for manual approval in OD to 50%. Also in Reports tab "How often  expenses submit :' choose "Weekly"

[user B] On secondary device submit 2 expense reports with the same expenses to trigger manual review system message
[user A] Open the app and log in
[user A] Navigate to the workspace chat
[user A] Open the first submitted report with the same expense

Expected Result:
The system message "This report was randomly selected for manual review" is displayed without markdown
Actual Result:
The system message is displayed with the markdown
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/b0655008-2563-4d80-872f-7c31c16e6d34

View all open jobs on GitHub

@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

Production
https://github.com/Expensify/App/assets/115492554/f3a99c36-7b51-45d9-9564-8c9c15ecf42f

Removing DeployBlocker from the backend since I don't think this is a backend issue

Damn. On second thoughts I think this should be a blocker 😭

After discussing here we are treating this as a non-blocker.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Randomly selected system message is shown in markdown.
What is the root cause of that problem?
The translation for randomly selected text is in link markdown form. It's an old dot action.
https://github.com/Expensify/App/blob/97b383144d6bff44ecd929c1e5b66b1aa965b03e/src/languages/en.ts#L3572
However, for the old dot action, we render the message with ReportActionItemBasicMessage which just shows plain text.
https://github.com/Expensify/App/blob/97b383144d6bff44ecd929c1e5b66b1aa965b03e/src/pages/home/report/ReportActionItem.tsx#L619-L621
What changes do you think we should make in order to solve the problem?

If we want to show the link, then we need to use ReportActionItemMessage. Here is the step:

Remove the ReportActionItemBasicMessage for old dot action usage here
https://github.com/Expensify/App/blob/97b383144d6bff44ecd929c1e5b66b1aa965b03e/src/pages/home/report/ReportActionItem.tsx#L619-L621
In ReportActionItemMessage, we can do the same for member change action by rendering TextCommentFragment directly,
https://github.com/Expensify/App/blob/97b383144d6bff44ecd929c1e5b66b1aa965b03e/src/pages/home/report/ReportActionItemMessage.tsx#L54-L68

but instead, we can set the fragments array for the old dot action case and let the rest of the code handle it.
if (isOldDotReportAction(action)) {
    const oldDotMessage = ReportActionsUtils.getMessageOfOldDotReportAction(action);
    fragments = [{text: oldDotMessage, html: `<muted-text>${Parser.replace(oldDotMessage)}</muted-text>`, type: 'COMMENT'}];
} else {
    if (Array.isArray(actionMessage)) {
        fragments = actionMessage.filter((item): item is Message => !!item);
    } else {
        fragments = actionMessage ? [actionMessage] : [];
    }
}

We use Parser.replace to convert the markdown to HTML. <muted-text> so the text is grayed out.
To keep it clean, we can update getMessageOfOldDotReportAction to return the fragment and only parse the randomly selected action (SELECTED_FOR_RANDOM_AUDIT)

Hey @Pujan92 we have a proposal on this already, can you please review when you get a chance?

Proposal
Please re-state the problem that we are trying to solve in this issue.
The system message is displayed with the markdown
What is the root cause of that problem?
The random selected action is an old dot action and the message is a markdown
https://github.com/Expensify/App/blob/b5f8bd36bbb9909a3b9682d41827856f43733eff/src/languages/en.ts#L3589
But we render the old dot action as a normal text component.
https://github.com/Expensify/App/blob/b5f8bd36bbb9909a3b9682d41827856f43733eff/src/pages/home/report/ReportActionItem.tsx#L636
What changes do you think we should make in order to solve the problem?

We can create a util to return the HTML message of old dot action. the muted-text tag is used to gray out the text

function getHtmlMessageOfOldDotReportAction(oldDotAction: PartialReportAction | OldDotReportAction): string {
    const messageText = getMessageOfOldDotReportAction(oldDotAction);
    const messageHtml = Parser.replace(messageText);
    return `<muted-text>${messageHtml}</muted-text>`;
}

And in ReportActionItem, we will use RenderHTML component to display the old dot message.

children = <RenderHTML html={ReportActionsUtils.getHtmlMessageOfOldDotReportAction(action)}/>;

https://github.com/Expensify/App/blob/b5f8bd36bbb9909a3b9682d41827856f43733eff/src/languages/en.ts#L3589
With this change we can make sure that this bug doesn't happen in the further for old dot action
What alternative solutions did you explore? (Optional)

I am not receiving this specific report action, @bernhardoj @nkdengineer are you able to get this action for the report?
https://github.com/user-attachments/assets/357ba0cc-4f4a-4a61-b099-6b119817307d

Both proposals solve the issue here, let's proceed with the first proposal which is from @bernhardoj and suggested generating fragments in the ReportActionItemMessage for the OldDotReportAction.
🎀👀🎀 C+ reviewed

PR is ready
cc: @Pujan92

Requested in ND.

Summarizing payment on this issue:

Contributor:  @Pujan92 $250, please request via NewDot
Contributor+: @bernhardoj $250, please request via NewDot

$250 approved for @Pujan92

$250 approved for @bernhardoj

Hey @Pujan92 this is just waiting for you to complete the BZ checklist!

Bump here @Pujan92, can you please complete the BZ checklist?

[X] [@Pujan92] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/43079
[X] [@Pujan92] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/43079/files#r1709608143
[X] [@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[X] [@Pujan92] Determine if we should create a regression test for this bug. - Yes
[X] [@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

[user A] Invite user B to the workspace
[user B] Submit two expenses in that workspace with the similar details to trigger a manual review system message
[user A] Navigate to the workspace chat
[user A] Open the submitted report
[user A] Verify the "randomly selected for review" message isn't rendered in markdown form

Issue created for new test case: https://github.com/Expensify/Expensify/issues/420217
All done here, thanks!


Back button in Firefox does not update the view

I often need to return to the Detail of the previous entity, and the browser's back button is now the only way to do it. However, when I press the button in Firefox, it does not refresh the view - the Back button itself works, i.e. when I press it and then refresh the browser manually with F5, I get the desired entity. However, I should get it already when pressing the Back button, without manually refreshing the window with F5.

This would also solve #767 .


Broke for PF2e in latest version (on Foundry 0.7.5 and PF2e <IP_ADDRESS>7)

Tried with and without sign, and tried changing the object path. Numbers just no longer show up.

Sorry about that! I can take a look tonight.
Just checking, are you sure you didn't toggle the visibility in the Combat Numbers toolbar? (The # button and then the eye with a slash through it?)

I can't find that setting. Where is the toolbar?

It's the vertical list of tools on the left-side of the canvas, to manipulate actors, put down templates, add tiles, etc.

Oh.. I don't have that. Maybe because I'm on 0.7.5 is the only thing I can think of

Oh weird! That may be. I'll take a peek tonight and get back to you. Thanks for flagging the specific versions.

If you're open to it, do you see anything fixed if you disable all other modules?

No. Tried 5e too.

I have fixed this in the latest release - v0.2.1. Updating the module in FoundryVTT should address your concerns. Thanks.

Thank you, works beautifully now!
Just FYI, there is some kind of interaction with the Token Drag Visibility mod when toggling the CN visibility button:
Uncaught TypeError: Cannot read property 'length' of undefined
at checkDragBegin (tokendragvisibility.js:38)
But everything looks to be working, so it's probably nothing.
https://foundryvtt.com/packages/token-drag-visibility/

Odd! I'm going to chalk it up to a Token Drag Visibility module issue as that it hasn't been updated for a long time and is supporting v0.6.2 max.
Thanks for reporting back that it's working now.


chore: restore tests disabled for @hope-ui

Root of the problem was a forgotten HopeProvider initialization for the test setup... 🐰
However, there are some problems with vitest module resolution of the scroll-lock dependency of @hope-ui/solid that require both packages to be inlined in the vitest config (just like solid-js itself).

👍🏻


Fix bug with the Copy button and proto documentation.

HTML generated from protos encode preformatted blocks with ,
while HTML generated through Jekyll's markdown converter wraps an extra  around the
block. The logic to insert the Copy button on preformatted was assuming the presence of this
DIV. If the DIV is not present on input, we now explicitly add one which makes things work.

Hover the mouse over any preformatted blocks here to see the problem: https://istio.io/docs/reference/config/istio.routing.v1alpha1.html
See here for staged fix: https://geeknoid.github.io/istio.github.io/docs/reference/config/istio.routing.v1alpha1.html

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
Assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Typescript Update

Update our packages to have better property and event types:

[x] @featherds/app
[x] @featherds/app-layout
[x] @featherds/autocomplete
[x] @featherds/back-button
[x] @featherds/badge
[x] @featherds/button
[x] @featherds/checkbox
[x] @featherds/chips
[x] @featherds/composables
[x] @featherds/date-input
[x] @featherds/dialog
[x] @featherds/drawer
[x] @featherds/dropdown
[x] @featherds/expansion
[x] @featherds/footer
[x] @featherds/icon
[x] @featherds/input-helper
[x] @featherds/input
[x] @featherds/list
[x] @featherds/megamenu
[x] @featherds/menu
[x] @featherds/navigation-rail
[x] @featherds/pagination
[x] @featherds/pdf-viewer
[x] @featherds/progress
[x] @featherds/protected
[x] @featherds/radio
[x] @featherds/ripple
[x] @featherds/select
[x] @featherds/styles
[x] @featherds/switch
[x] @featherds/table
[x] @featherds/tabs
[x] @featherds/textarea
[x] @featherds/utils

This has been merged


Release artifact for release v1.1.2

Release artifact for release v1.1.2
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/lgtm


7.x: fix clippy

Which issue does this PR close?
fix clippy
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

It was forgotten.
   --> datafusion/tests/merge_fuzz.rs:106:20
    |
106 |               .iter()
    |  ____________________^
107 | |             .map(|p| p.iter())
108 | |             .flatten()
    | |______________________^ help: try using `flat_map` instead: `.flat_map(|p| p.iter())`

It was forgotten

hi, my macOS have problem running with cargo clippy (similar to https://github.com/rust-lang/rust-clippy/issues/8470), so I just relies on CI for the checking (And CI didn't show all errors at once)
I will mark this PR as "Ready for review" once clippy pass

Thanks @jychen7!


UI router sref links don't work

Hi,
I'm using prerender with hashbang and ui router. The links that are using ui router's sref attribute are getting autogenerated href values. The problem is that the hrefs are something like href="#!/route1" and are not working (this will get concatenated to server/?escaped_fragment=route2/#!/route1) because of the missing / at the start of the link. And I cannot force the value for href. Is this is an prerendering issue or phantomjs?
Thanks a lot

You can close this, actually the href was generated by ui-router's ui-sref directive. This can be fixed by using absolute urls through ui-sref-opts directive.
Sorry :)

Great, let me know if there's anything I can do to help!


Add a note about using Chromium-based browser for dev

Wasted few hours on this one. Let's save others I guess? :thinking:

Thank you, I reckon that must be very useful to know before contributing! :)


Add test action

Awesome! In the future we'll probably just remove the remote package build things from the workspace, you probably saw that the Mac one just errors.
The Linux release needs to use an OS with an older version of glibc though (I think? or does rust linking handle this well?). Otherwise the binaries might not work on e.g., centos 7.

I think rust is smart about it but not sure.  Especially not sure what happens if a crate includes some C++...  I added an option to build with cross which handles the glibc issue as well as cross compiling.
Also, figured I might as well remove all of the remote portions with this PR.

Is there any concern of macos version compatibility (doesn't the macos linker add in a minimum OS version field of some sort)?

Doesn't look like there's any way to do it with cargo unfortunately (maybe with build.rs?)

As far as I've seen, no way to do it with build.rs.


<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS><0.13.0 but none was installed.

Installing bookshelf from npm throws a warning about knex versions:
$ npm install --save bookshelf

><EMAIL_ADDRESS>postinstall /home/me/myproj/server/node_modules/bookshelf
> node ./scripts/build.js lib "npm run build"

<EMAIL_ADDRESS>/home/me/myproj/server
├─┬<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ │ ├──<EMAIL_ADDRESS>│ │ └──<EMAIL_ADDRESS>│ ├──<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ │ ├──<EMAIL_ADDRESS>│ │ ├──<EMAIL_ADDRESS>│ │ ├─┬<EMAIL_ADDRESS>│ │ │ └──<EMAIL_ADDRESS>│ │ ├──<EMAIL_ADDRESS>│ │ └──<EMAIL_ADDRESS>│ ├──<EMAIL_ADDRESS>│ ├──<EMAIL_ADDRESS>│ ├──<EMAIL_ADDRESS>│ └──<EMAIL_ADDRESS>└── UNMET PEER DEPENDENCY<EMAIL_ADDRESS><0.13.0

npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS><0.13.0 but none was installed.

+1

+1

solved using
npm install<EMAIL_ADDRESS>--save-exact

I tried just reinstalling with<EMAIL_ADDRESS>but didn't work on my end, so I did this:

rm -rf node_modules
npm cache clean
Changed package.json<EMAIL_ADDRESS>to<EMAIL_ADDRESS>npm install

can the knex peer dependency version be updated? or will that break?
current:
"peerDependencies": {
    "knex": ">=0.6.10 <0.13.0"
  }

suggested:
"peerDependencies": {
    "knex": ">=0.6.10 <=0.13.0"
  }

haven't tested yet but may submit PR

Why not use 0.12.9?
If you already installed 0.13.0, uninstall it first
npm uninstall knex --save
npm install<EMAIL_ADDRESS>--save-exact

that doesn't support the documentation in README

@sgraham785
can you test your fix and in case submit a PR ? :)

Issues Solved with #1597 , thank you :)


When calling amplificationtester.py it returns an extra record in the output for csv and json

Basically on an internally accessible website I'm executing amplificationtester.py as the webserver's user (www-data).  I'm writing the results to a mysql table and outputting the information to the browser.
When I execute things using PHP there is some confusion and two lines are being returned instead of one for a single target.  The results are confused too (the target_ip is in one array element while the results are in another).  This happens with -o json and -o csv but not -o text (or without -o specified).

Execute with PHP with -o csv specified gives confused results
Execute with PHP with -o json specified gives confused results
Execute with PHP without -o specified gives normal results
Execute in a shell as the www-data user works properly every time regardless of the -o argument

I've tried going through the python script line by line trying to figure out if there's a bug with a python library when there's no TTY or something but I can't seem to figure out what could cause this strange behaviour.
PHP is executing it like this:
$check = "DNS";
$command = "/directory/to/site/tools/amplificationtester.py --$check --ip ".$_GET["target"]." -o json";
$output = shell_exec(escapeshellcmd($command));

PHP's var_dump() produces this strangeness on $output (before any json_decode() is done):
string(370) "[
  {
    "amplification_factor": 0,
    "bytes_received": 0,
    "bytes_sent": 0,
    "exploitable": false,
    "port": 123,
    "target_ip": "xxx.xxx.xxx.xxx",
    "type": "NTP"
  },
  {
    "amplification_factor": 46.0,
    "bytes_received": 368,
    "bytes_sent": 8,
    "exploitable": true,
    "port": 123,
    "target_ip": "",
    "type": "NTP"
  }
]
"

If I remove the "-o json" argument, PHP's var_dump() shows that it outputs normally:
string(146) "[*] Starting testing of 2 IPs
[*] Time estimate: 1.65 seconds
[NTP] xxx.xxx.xxx.xxx: 0
[NTP] : 46.0
[*] Finished in 1.53 seconds
"

Executing it with the "-o json" argument on the command line outputs properly too:
shell prompt# sudo -u www-data /directory/to/site/tools/amplificationtester.py --ntp -i <IP_ADDRESS> -o json
[
  {
    "amplification_factor": 0,
    "bytes_received": 0,
    "bytes_sent": 0,
    "exploitable": false,
    "port": 123,
    "target_ip": "xxx.xxx.xxx.xxx",
    "type": "NTP"
  }
]

Hi
Hm, strange result, and hard to see what could have caused this.
Is it possible that an empty target got snuck in somewhere in the PHP code? E.g:
$ ./amplificationtester.py -D -i "<IP_ADDRESS>" -i "" -o json
[
  {
    "amplification_factor": 0,
    "bytes_received": 0,
    "bytes_sent": 0,
    "exploitable": false,
    "port": 53,
    "target_ip": "",
    "type": "DNS"
  },
  {
    "amplification_factor": 0,
    "bytes_received": 0,
    "bytes_sent": 0,
    "exploitable": false,
    "port": 53,
    "target_ip": "<IP_ADDRESS>",
    "type": "DNS"
  }
]

I'll look more into it ASAP.

Hi BobuSumisu,
Thanks for replying so quickly. Since your idea so accurately replicated the results I'm seeing I've been trying to find ways to see if that's what's happening here but I cannot.  I've simplified things a little and I'm using var_dump() with and without the escapeshellcmd() function to compare the strings visually in case the escaping function was adding additional characters and causing an issue.  I cannot get it to show any additional targets anywhere so I'm sure that's not the case.
I wonder if you'd have the same results if you executed the PHP code against it like I am (/script.php?target=).
Executing this PHP code:
<?php
    $target = $_GET['target'];
    $command = "/directory/to/site/tools/amplificationtester.py -D --ip '$target' -o json";
    var_dump(escapeshellcmd($command));
    var_dump($command);
    $output = shell_exec(escapeshellcmd($command));
    var_dump($output);
?>

Does this:
string(73) "/directory/to/site/tools/amplificationtester.py -D --ip 'xxx.xxx.xxx.xxx' -o json"
string(73) "/directory/to/site/tools/amplificationtester.py -D --ip 'xxx.xxx.xxx.xxx' -o json"
string(369) "[
  {
    "amplification_factor": 0,
    "bytes_received": 0,
    "bytes_sent": 0,
    "exploitable": false,
    "port": 53,
    "target_ip": "",
    "type": "DNS"
  },
  {
    "amplification_factor": 5.21,
    "bytes_received": 146,
    "bytes_sent": 28,
    "exploitable": true,
    "port": 53,
    "target_ip": "xxx.xxx.xxx.xxx",
    "type": "DNS"
  }
]
"

Hi
I seem to get the right output:
<?php
    $target = "<IP_ADDRESS>";  /* $_GET["target"] */
    $command = "./amplificationtester.py -D --ip '$target' -o json";
    var_dump(escapeshellcmd($command));
    var_dump($command);
    $output = shell_exec(escapeshellcmd($command));
    var_dump($output);
?>

Output:
string(54) "./amplificationtester.py -D --ip '<IP_ADDRESS>' -o json"
string(54) "./amplificationtester.py -D --ip '<IP_ADDRESS>' -o json"
string(187) "[
  {
    "amplification_factor": 0,
    "bytes_received": 0,
    "bytes_sent": 0,
    "exploitable": false,
    "port": 53,
    "target_ip": "<IP_ADDRESS>",
    "type": "DNS"
  }
]
"

I ran it with PHP 5.6.20-1 (cli) and Python 2.7.
Do you get the same result if you change $_GET['target'] with an actual IP?

Hello,
Just now I even tried hardcoding the IP address into the $command but this didn't affect the output using a web browser.  When I used the PHP 5.5.9-1ubuntu4.16 (cli) however the output was correct.  My hunch is that it's related to executing amplificationtester.py without a controlling terminal but that's only a hunch.

Tried running through web (nginx and php-fpm). Still haven't been able to reproduce your result :/
Made this test file:
<!doctype html>
<html>
<body>
<textarea rows="40" cols="200">
<?php
    $target = $_GET["target"];
    $command = "./amplificationtester.py -D --ip '$target' -o json";
    var_dump(escapeshellcmd($command));
    var_dump($command);
    $output = shell_exec(escapeshellcmd($command));
    var_dump($output);
?>
</textarea>
</body>

And went to localhost/test.php?target=<IP_ADDRESS>:
string(101) "./amplificationtester/amplificationtester.py -D --ip '<IP_ADDRESS>' -o json"
string(101) "./amplificationtester/amplificationtester.py -D --ip '<IP_ADDRESS>' -o json"
string(187) "[
  {
    "amplification_factor": 0,
    "bytes_received": 0,
    "bytes_sent": 0,
    "exploitable": false,
    "port": 53,
    "target_ip": "<IP_ADDRESS>",
    "type": "DNS"
  }
]
"

Well - I don't know what to say.  I switched the HTTP service to use nginx+php-fpm instead of apache2+libapache2-mod-php5 and it works perfectly as expected!  Must be something related to the libapache2-mod-php5 implementation of PHP in Ubuntu but I don't know what and I double I'll ever know what.
Anyway - thanks for working with me on this!

Nice! Strange error indeed. But switching to nginx is an OK work-around at least :P
Have fun coding!


[sfc] Is there a solution in Vue3 similar to the http-Vue-loader in Vue2

What problem does this feature solve?
In Vue3, Vue SFC cannot be used in HTML, but it is possible in Vue2. Is there a solution
The following is a code example of the live server that needs to be used
dd.zip
What does the proposed API look like?
no

Do you mean this project? https://github.com/FranckFreiburger/http-vue-loader
According to its readme there's a successor project for Vue 2 and Vue 3

Do you mean this project? https://github.com/FranckFreiburger/http-vue-loader
According to its readme there's a successor project for Vue 2 and Vue 3
thanks for you reply.sure,this project can use.


Async recursive function produces StackOverflowException where as .Net doesn't.

Expected
run indefinitely.
Actual
Uncaught RangeError: maximum call stack exceeded
Steps To Reproduce
Live Bridge
Dot Net Fiddle
/// <summary>
/// Creates a simple class
/// </summary>
public class App
{
    // Use the [Ready] attribute to automatically
    // run this method when the page is ready.
    [Ready]
    public static async void Main()
    {
        Main();
    }
}

@michaelcheers,
The Dot Net Fiddle sample gives the same recursive problem:
[DotNetFiddle.Infrastructure.LimitExceededException: Execution time limit was exceeded]

Closes #1398.


Accordion item title

📥 Proposed changes
This pull request contains changes that will allow the title of accordion items to be React components, as well as strings.
Allowing these React components will let users style accordion item titles according to their needs.
☑ Submission checklist

[x] I have read the CONTRIBUTING doc
[x] yarn build works locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

There's an updated version of accordion on its way in #404, so I'll defer a proper review until you've had the chance to look at that/pull it in blush

Makes sense :+1:  Pull request #404 is now merged into this pull request, without conflicts or problems.


Data Race - Thread Sanitizer

Describe the bug
Seeing data race conditions
Steps To Reproduce
1) Enable Thread Sanitization in scheme setting
2) Setup Auth

Expected behavior
I should not be seeing data race conditions within the library
Amplify Framework Version
2.25.4
Amplify Categories
Auth
Dependency manager
Swift PM
Swift version
5.9
CLI version
12.10.3
Xcode version
15.3
Relevant log output
WARNING: ThreadSanitizer: data race (pid=4687)
  Write of size 1 at 0x0001473827f9 by thread T29:
    #0 ClientRuntime.HttpResponse.statusCode.setter : ClientRuntime.HttpStatusCode <null> (MyApp:arm64+0x105d7db0c)
    #1 closure #6 (Swift.Result<Swift.UInt32, AwsCommonRuntimeKit.CommonRunTimeError>) -> () in ClientRuntime.CRTClientEngine.(makeHttpRequestStreamOptions in _91B07933650E8EA49FB320ECA4DED537)(request: AwsCommonRuntimeKit.HTTPRequestBase, continuation: Swift.CheckedContinuation<ClientRuntime.HttpResponse, Swift.Error>, http2ManualDataWrites: Swift.Bool) -> AwsCommonRuntimeKit.HTTPRequestOptions <null> (MyApp:arm64+0x105d67298)
    #2 partial apply forwarder for closure #6 (Swift.Result<Swift.UInt32, AwsCommonRuntimeKit.CommonRunTimeError>) -> () in ClientRuntime.CRTClientEngine.(makeHttpRequestStreamOptions in _91B07933650E8EA49FB320ECA4DED537)(request: AwsCommonRuntimeKit.HTTPRequestBase, continuation: Swift.CheckedContinuation<ClientRuntime.HttpResponse, Swift.Error>, http2ManualDataWrites: Swift.Bool) -> AwsCommonRuntimeKit.HTTPRequestOptions <null> (MyApp:arm64+0x105d68600)
    #3 AwsCommonRuntimeKit.(onComplete in _BEB8F7D4C37A431780FEA5A42770A7B4)(stream: Swift.Optional<Swift.UnsafeMutablePointer<__C.aws_http_stream>>, errorCode: Swift.Int32, userData: Swift.Optional<Swift.UnsafeMutableRawPointer>) -> () <null> (MyApp:arm64+0x1056b9d4c)
    #4 @objc AwsCommonRuntimeKit.(onComplete in _BEB8F7D4C37A431780FEA5A42770A7B4)(stream: Swift.Optional<Swift.UnsafeMutablePointer<__C.aws_http_stream>>, errorCode: Swift.Int32, userData: Swift.Optional<Swift.UnsafeMutableRawPointer>) -> () <null> (MyApp:arm64+0x1056b99e4)
    #5 s_stream_complete <null> (MyApp:arm64+0x1058249f0)
    #6 s_decoder_on_done <null> (MyApp:arm64+0x10582d248)
    #7 s_mark_done <null> (MyApp:arm64+0x105833b48)
    #8 s_state_unchunked_body <null> (MyApp:arm64+0x10583468c)
    #9 aws_h1_decode <null> (MyApp:arm64+0x10582eacc)
    #10 s_try_process_next_stream_read_message <null> (MyApp:arm64+0x1058210b4)
    #11 aws_h1_connection_try_process_read_messages <null> (MyApp:arm64+0x10581f9ec)
    #12 s_handler_process_read_message <null> (MyApp:arm64+0x1058277c8)
    #13 aws_channel_handler_process_read_message <null> (MyApp:arm64+0x105798414)
    #14 aws_channel_slot_send_message <null> (MyApp:arm64+0x105797de0)
    #15 s_process_read_message <null> (MyApp:arm64+0x1057b0168)
    #16 aws_channel_handler_process_read_message <null> (MyApp:arm64+0x105798414)
    #17 aws_channel_slot_send_message <null> (MyApp:arm64+0x105797de0)
    #18 s_do_read <null> (MyApp:arm64+0x1057f90d8)
    #19 s_on_readable_notification <null> (MyApp:arm64+0x1057f75dc)
    #20 s_on_socket_io_event <null> (MyApp:arm64+0x1057f043c)
    #21 aws_event_loop_thread <null> (MyApp:arm64+0x105790614)
    #22 thread_fn <null> (MyApp:arm64+0x105753578)

  Previous read of size 1 at 0x0001473827f9 by thread T52:
    #0 ClientRuntime.HttpResponse.statusCode.getter : ClientRuntime.HttpStatusCode <null> (MyApp:arm64+0x105d7daa0)
    #1 (3) suspend resume partial function for ClientRuntime.DeserializeMiddleware.handle<A where A1: ClientRuntime.Handler, A1.Context == ClientRuntime.HttpContext, A1.Input == ClientRuntime.SdkHttpRequest, A1.Output == ClientRuntime.OperationOutput<A>>(context: ClientRuntime.HttpContext, input: ClientRuntime.SdkHttpRequest, next: A1) async throws -> ClientRuntime.OperationOutput<A> <null> (MyApp:arm64+0x105d895c8)
    #2 swift::runJobInEstablishedExecutorContext(swift::Job*) <null> (libswift_Concurrency.dylib:arm64+0x38108)

  Location is heap block of size 42 at 0x0001473827d0 allocated by thread T52:
    #0 malloc <null> (libclang_rt.tsan_iossim_dynamic.dylib:arm64+0x4fa48)
    #1 _malloc_type_malloc_outlined <null> (libsystem_malloc.dylib:arm64+0xf0d0)
    #2 ClientRuntime.CRTClientEngine.(makeHttpRequestStreamOptions in _91B07933650E8EA49FB320ECA4DED537)(request: AwsCommonRuntimeKit.HTTPRequestBase, continuation: Swift.CheckedContinuation<ClientRuntime.HttpResponse, Swift.Error>, http2ManualDataWrites: Swift.Bool) -> AwsCommonRuntimeKit.HTTPRequestOptions <null> (MyApp:arm64+0x105d65928)
    #3 closure #1 (Swift.CheckedContinuation<ClientRuntime.HttpResponse, Swift.Error>) -> () in ClientRuntime.CRTClientEngine.execute(request: ClientRuntime.SdkHttpRequest) async throws -> ClientRuntime.HttpResponse <null> (MyApp:arm64+0x105d61e24)
    #4 partial apply forwarder for closure #1 (Swift.CheckedContinuation<ClientRuntime.HttpResponse, Swift.Error>) -> () in ClientRuntime.CRTClientEngine.execute(request: ClientRuntime.SdkHttpRequest) async throws -> ClientRuntime.HttpResponse <null> (MyApp:arm64+0x105d6250c)
    #5 merged closure #1 (Swift.UnsafeContinuation<A, Swift.Never>) -> () in Swift.withCheckedContinuation<A>(function: Swift.String, _: (Swift.CheckedContinuation<A, Swift.Never>) -> ()) async -> A <null> (libswift_Concurrency.dylib:arm64+0x5740)

  Thread T29 (tid=62930512, running) created by thread T10 at:
    #0 pthread_create <null> (libclang_rt.tsan_iossim_dynamic.dylib:arm64+0x2bee4)
    #1 aws_thread_launch <null> (MyApp:arm64+0x105752d0c)
    #2 s_run <null> (MyApp:arm64+0x10578c474)
    #3 aws_event_loop_run <null> (MyApp:arm64+0x1057b71c0)
    #4 s_event_loop_group_new <null> (MyApp:arm64+0x1057b4f70)
    #5 aws_event_loop_group_new <null> (MyApp:arm64+0x1057b49d4)
    #6 aws_event_loop_group_new_default <null> (MyApp:arm64+0x1057b51c8)
    #7 closure #1 (Swift.UnsafePointer<__C.aws_shutdown_callback_options>) -> Swift.Optional<Swift.UnsafeMutablePointer<__C.aws_event_loop_group>> in closure #1 () -> Swift.Optional<Swift.UnsafeMutablePointer<__C.aws_event_loop_group>> in AwsCommonRuntimeKit.EventLoopGroup.init(threadCount: Swift.UInt16, shutdownCallback: Swift.Optional<() -> ()>) throws -> AwsCommonRuntimeKit.EventLoopGroup <null> (MyApp:arm64+0x1056bcbec)
    #8 partial apply forwarder for closure #1 (Swift.UnsafePointer<__C.aws_shutdown_callback_options>) -> Swift.Optional<Swift.UnsafeMutablePointer<__C.aws_event_loop_group>> in closure #1 () -> Swift.Optional<Swift.UnsafeMutablePointer<__C.aws_event_loop_group>> in AwsCommonRuntimeKit.EventLoopGroup.init(threadCount: Swift.UInt16, shutdownCallback: Swift.Optional<() -> ()>) throws -> AwsCommonRuntimeKit.EventLoopGroup <null> (MyApp:arm64+0x1056bcd9c)
    #9 Swift.withUnsafePointer<A, B>(to: A, _: (Swift.UnsafePointer<A>) throws -> B) throws -> B <null> (libswiftCore.dylib:arm64+0x116f24)
    #10 AwsCommonRuntimeKit.EventLoopGroup.init(threadCount: Swift.UInt16, shutdownCallback: Swift.Optional<() -> ()>) throws -> AwsCommonRuntimeKit.EventLoopGroup <null> (MyApp:arm64+0x1056bc780)
    #11 AwsCommonRuntimeKit.EventLoopGroup.__allocating_init(threadCount: Swift.UInt16, shutdownCallback: Swift.Optional<() -> ()>) throws -> AwsCommonRuntimeKit.EventLoopGroup <null> (MyApp:arm64+0x1056bc5c4)
    #12 ClientRuntime.SDKDefaultIO.() -> ClientRuntime.SDKDefaultIO(in _FE859A5DC63535809337AB8A60C1C338).init() -> ClientRuntime.SDKDefaultIO <null> (MyApp:arm64+0x105d6d564)
    #13 ClientRuntime.SDKDefaultIO.__allocating_init() -> ClientRuntime.SDKDefaultIO <null> (MyApp:arm64+0x105d6d310)
    #14 one-time initialization function for shared <null> (MyApp:arm64+0x105d6d288)
    #15 dispatch_once <null> (libclang_rt.tsan_iossim_dynamic.dylib:arm64+0x78d30)
    #16 dispatch_once_f <null> (libclang_rt.tsan_iossim_dynamic.dylib:arm64+0x78dcc)
    #17 ClientRuntime.SDKDefaultIO.shared.unsafeMutableAddressor : ClientRuntime.SDKDefaultIO <null> (MyApp:arm64+0x105d6d3bc)
    #18 AWSClientRuntime.DefaultChainCredentialsProvider.init(fileBasedConfig: AwsCommonRuntimeKit.FileBasedConfiguration) throws -> AWSClientRuntime.DefaultChainCredentialsProvider <null> (MyApp:arm64+0x105599738)
    #19 AWSClientRuntime.AWSClientConfiguration.__allocating_init(region: Swift.String, credentialsProvider: Swift.Optional<AWSClientRuntime.CredentialsProviding>, endpoint: Swift.Optional<Swift.String>, serviceSpecific: Swift.Optional<A>, signingRegion: Swift.Optional<Swift.String>, useDualStack: Swift.Optional<Swift.Bool>, useFIPS: Swift.Optional<Swift.Bool>, retryMode: Swift.Optional<AWSClientRuntime.AWSRetryMode>, maxAttempts: Swift.Optional<Swift.Int>, appID: Swift.Optional<Swift.String>, connectTimeoutMs: Swift.Optional<Swift.UInt32>) throws -> AWSClientRuntime.AWSClientConfiguration<A> <null> (MyApp:arm64+0x10559106c)
    #20 AWSCognitoAuthPlugin.AWSCognitoAuthPlugin.(makeUserPool in _8AB0DFBFCB62BEA0C3EE23AA1F6DBA04)() throws -> AWSCognitoAuthPlugin.CognitoUserPoolBehavior <null> (MyApp:arm64+0x104aee818)
    #21 implicit closure #4 () throws -> AWSCognitoAuthPlugin.CognitoUserPoolBehavior in implicit closure #3 (AWSCognitoAuthPlugin.AWSCognitoAuthPlugin) -> () throws -> AWSCognitoAuthPlugin.CognitoUserPoolBehavior in AWSCognitoAuthPlugin.AWSCognitoAuthPlugin.(authenticationEnvironment in _8AB0DFBFCB62BEA0C3EE23AA1F6DBA04)(userPoolConfigData: AWSCognitoAuthPlugin.UserPoolConfigurationData) -> AWSCognitoAuthPlugin.AuthenticationEnvironment <null> (MyApp:arm64+0x104af1814)
    #22 partial apply forwarder for implicit closure #4 () throws -> AWSCognitoAuthPlugin.CognitoUserPoolBehavior in implicit closure #3 (AWSCognitoAuthPlugin.AWSCognitoAuthPlugin) -> () throws -> AWSCognitoAuthPlugin.CognitoUserPoolBehavior in AWSCognitoAuthPlugin.AWSCognitoAuthPlugin.(authenticationEnvironment in _8AB0DFBFCB62BEA0C3EE23AA1F6DBA04)(userPoolConfigData: AWSCognitoAuthPlugin.UserPoolConfigurationData) -> AWSCognitoAuthPlugin.AuthenticationEnvironment <null> (MyApp:arm64+0x104af79a0)
    #23 (1) suspend resume partial function for AWSCognitoAuthPlugin.AWSAuthFetchUserAttributeTask.getUserAttributes(with: Swift.String) async throws -> Swift.Array<Amplify.AuthUserAttribute> <null> (MyApp:arm64+0x10523de3c)
    #24 swift::runJobInEstablishedExecutorContext(swift::Job*) <null> (libswift_Concurrency.dylib:arm64+0x38108)

  Thread T52 (tid=62931679, running) is a GCD worker thread

SUMMARY: ThreadSanitizer: data race (/Users/andersmelen/Library/Developer/CoreSimulator/Devices/26B50286-E86D-4C5E-BE5C-1B37155233DA/data/Containers/Bundle/Application/765655DB-80F2-4044-AB8F-EDA8230A137E/MyApp.app/MyApp:arm64+0x105d7db0c) in ClientRuntime.HttpResponse.statusCode.setter : ClientRuntime.HttpStatusCode+0x44
==================
ThreadSanitizer report breakpoint hit. Use 'thread info -s' to get extended information about the report.

Is this a regression?
No
Regression additional context
No response
Platforms
No response
OS Version
17.4
Device
iPhone 15 Pro
Specific to simulators
No response
Additional context
No response

Thank you posting this - our team will investigate and post updates to this ticket.

A pull request (https://github.com/smithy-lang/smithy-swift/pull/656) addressing this issue has already been submitted for the smithy-swift repository. We will track it progress.

We will try to upgrade to the latest version once it's released.


Add config file for templates + #46

#46

Yeah man 🚀 !!!
Very cool, I'll test and merge ASAP 🙁

Thanks man 🏅


Reading settings file from the solution

Hi,
It would be nice to be able to define the settings in the solution level and use it in the projects. I tried to put stylecop.json file in the solution but, the analyzer is not reading it.

What you can do is define the stylecop.json file in the solution folder and create a link to it from each project. That should work fine. I don't think that an other solution is currently possible, given that analyzers currently cannot access the MSBuild environment at all.

Yes, that would be possible. However, because you have to include the settings file inside of the csproj file, Visual Studio will have problems. Generally, it has issues when two projects in the same solution reference the same file.

For the original stylecop I currently generate project level settings.stylecop files to link to a solution level settings.stylecop file and automate copying this link file to all solution projects (regardless of folder nesting) (where they do not exist) using nuget init.ps1 scripts that run (but only when you open the package explorer). This ensures that even as projects are added and removed over time, the projects always link back to a solution level settings file. It's far more complex than it needs to be.
It would be much easier and more robust IMO to follow the conventions used by linting tools like jshint which use recursive parent lookups for locating settings files.
Just my two cents

@arashk1368 @wwwlicious Based on a meeting I had this week, it's almost certain that the method of including configuration will change (and be much more usable) in an upcoming release of Roslyn (I'm crossing my fingers for 1.2). Prior to that, I don't plan to make any changes based solely on usability (since it would just change again with the Roslyn update).
With Roslyn and our analyzers as portable class libraries, most of the file system APIs are not available, so we don't want to design an approach that requires us to use them (e.g. the jslint approach). That said, it might be possible to update the custom build target to locate and include the stylecop.json file from the solution directory if one doesn't already exist in the project.


Use sudo if possible for bird_ssh platform to execute Bird CLI queries

Feature Description
I would like to see bird_ssh platfrom to try to use sudo first, before failing back to using birdc commands directly with the provided credentials.
Is your feature request related to a problem? Please describe.
Related to the fact that you need to provide root credentials for Bird cli access
Environment & Use Case

Device type: EdgeRouter with Bird
Use case: Not wanting to provide root credentials directly, but to only allow birdc specifc commands via sudo configuration.

This would require a significant overhaul to the entirety of command execution logic. We would need to begin checking every response for platform-specific errors or output to indicate that a command failed but is eligible for retry during the same session. In my opinion, a better solution would be to simply override the bird_ssh commands to use sudo, or not, depending on the node's capabilities and/or configuration.
I'll leave this open for a little while for other users to comment.


Configure ClickHouse to write json formatted logs

Why are there no the json logs for ClickHouse in internal monitors yet?

@srikanthccv Updated clickhouse chart release is yet to be shipped.


Export picture from only one selected 3Dcomponent in Icepak

Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

Description of the bug
Hello,
I have a project in which I have several 3D components. I want to write a python script, that automatically exports a picture from each 3Dcomponent alone. So basically, I wanted to use the function export_model_picture(), and specify which 3Dcomponent I want to export. Unfortunately, it always exports the full view. Does someone have any idea how to solve this issue?
Thanks
Steps To Reproduce
icepak.post.export_model_picture(r"C:\tmp\image.jpg", 'False', 'False', 'False', 'False', 'None', field_selections = modeler.get_3d_component_object_list(components_list[1]), orientation='dimetric', width=1500,height=1500)
Which Operating System are you using?
Windows
Which Python version are you using?
3.10
Installed packages
pyaedt

Given ipk (the pyaedt.Icepak object), the string with the component_name, and a string with export_image_filepath, you have two options:
comp=ipk.modeler.user_defined_components[component_name].edit_definition()
comp.post.export_model_picture(export_image_filepath)

Or, if you want to use the script in non-graphical mode, you can use the integration with pyvista:
ipk.post.plot_model_obj([obj.name for obj in ipk.modeler.user_defined_components[component_name].parts.values()], export_path=export_image_filepath)


core as submodule?

Won't it cause compat issues over time?

You are correct, i will transform Core into a standalone project (Other projects will use its binary products instead).

Core is of now a standalone project, but for the due time SearchYa will continue to use it as submodule for the short term.


Added RationaleDialogCallback

RationaleDialogCallback is an extension of PermissionCallbacks and forwards the rationale
dialog buttons click events to the host that requesting a permission(s). RationaleDialogCallback is useful for events logging and is completely optional.
Check out RationaleFragment in the sample app folder for example.

Hi @ernestkamara.  Thanks for sending over a PR!
Can you explain the main use case for this callback?  What situation do you have in your app where you want to know if the rationale was denied versus the actual permissions request?

Hi @samtstern . We need this callback mainly for analytics logging to track how many denied the rationale dialog. We find this useful and might help us improve our rationale text and other UI states.

Ok. Thanks for your input. I will update it!

PR updated @samtstern!

Thanks @SUPERCILEX for the review and @ernestkamara for the patient updates.
This is good to go.  It also means the next release will be 1.2.0 since this is a new feature (woot!)

@samtstern Or not 😆, PR incoming.

Btw.. when is 1.2 scheduled?

@ernestkamara just happened! https://github.com/googlesamples/easypermissions/releases/tag/1.2.0


Add scheduler to full finetuning and adapter scripts

Adds learning rate schedulers to the full finetuning script as well as the Adapter scripts. It's similar to what I added to LoRA last week.

@awaelchli Would you like to review and land this?


COI: Building front-end (Employee Disclosure Statement - file attachments

After a form is approved by supervisor, we need to send the attachments to CRM
Acceptance Criteria

[ ] After form is approved, CRM ticket created has all files attached in the form (both by employee and supervisor)

[ ] pdf of the form named as Document Name  Employee #  Date (YYYYMMDD)  For e.g. Conflict of Interest<PHONE_NUMBER>0405.pdf
[ ] If attached, the Optional file in Employee Disclosure Statement for question 4, named as is uploaded
[ ] If attached, the Optional file in Employee Disclosure Statement for question 6, named as is uploaded
[ ] If attached, the Optional file in Supervisor Documentation and Decision, named as is uploaded

[x] File size and type restrictions are defined  (8MB for each file)
[x] Pdf of form should be attached in email to employee on supervisor approval
[ ] File name should be less than 40 characters. Show error is possible otherwise trim the name to 40 characters and upload
[ ] Max file limit is added to all file attachment fields

file upload needs to be handled before initial submission.
this need more work so we have upped the estimate to work on this

Tested with Bhumin - moving to PO.
The Conflict of Interest PDF is missing the logo and the title of the form - creating a new ticket for this.

Supervisor acknowledgements are missing

add the max file limit AC#5

@fazil-ey

Field on supervisor tab are hidden using custom script to support form validation. That point needs to handle separately which field we want to show in PDF and which we want to hide. Here I have only handle PDF creation and attach the same to CRM.

Added file size instruction along with supported formats, File size validation is already in place and display error like below

Filename on CRM,
We set fileName as it is, and display name will be trimmed to 40 characters and then upload to incident on CRM.
Display name will be name in attachment tab on incident,
FileName, that will be a name of file when someone download it to their local machine.

The error message for file validation is looking good!

@ayushdamani @fazil-ey
Andrew has address issue of supervisor acknowledgement issue and that is ready to test on TEST.
We are good with all points here to test and move if looks good.

The error message for file validation is looking good - tested this yesterday.
The supervisor acknowledgements are tested in #1761

@bhumin-fw can we make the file name like  "Conflict of Interest<PHONE_NUMBER>0405.pdf" with spaces

@fazil-ey Yes I guess it should work. I have updated it and worked for me. Please try again with new submission. I have updated changes on DEV and TEST.

No space between the words  Conflict of Interest

@fazil-ey
Updated name as "Conflict Of Interest<PHONE_NUMBER>0513.pdf".
It is ready to test on DEV and TEST environment.
cc: @ayushdamani

File name has been updated - thanks Bhumin!

looks good (assuming .pd is just a character limit in the name column and it is a proper pdf file in the screenshot)


[Core] add static analysis tools skeleton.

http://vincentbrison.com/2014/07/19/how-to-improve-quality-and-syntax-of-your-android-code/

CI failed!
https://travis-ci.org/literacyapp-org/shapi/builds/236443260?utm_source=github_status&utm_medium=notification
Could not find .travis.yml, using standard configuration.
That would be a good time to add our travis configuration that will assemble the project and run the static analysis check =)
See https://github.com/literacyapp-org/literacyapp-android/blob/master/.travis.yml for an example =)


How to add multiple bot controllers

I've looked at the things in the files and readme's but  I still can't figure out how to make 2 people able to control the bots like !resume, !pause, and just every feature. Please help.

You have to edit the permissions.ini file in your music bot master folder. Click the link to get a guide on how to configure the permissions.ini file: Click this blue text If you'r having any issues with the bot you can contact me on Discord, my name on discord is IceViper04#0970.


Improve USAGE.md Customization instructions

This PR makes a small change to the USAGE.md documentation.
The existing instructions improperly use a - before each yaml entry as if they are items in a list, when they are not and should actually be regular key:value pairs.
The documentation is also somewhat unspecific about where these entries should actually be added in the file. I specify the location by changing some of the documentation text and providing more lines of context for the yaml example.

Great catch! Thanks for your beautiful contribution.


Use console.error instead of console.dir

In the event the native module cannot be loaded, use console.error
instead of console.dir so the error gets prints to stderr instead of
stdout.

+1, stuffs up pipe connection for the RPC in my project when using smith js.
Commenting out the console.dir solves the problem.
So would compiling this of course, but I can't seem to on my machine. I might have to reinstall windows to do so. So it is a temporary/long term work around for me if I can't be bothered reinstalling.
Thanks.

Closing as this is no longer applicable. Fixed in 8d67d8edbf8d0e3233b485f3ef4338087f1ba065


Create a Perkeep package for Synology NAS

Synology NASes are popular and have a nice package app store thing.
Let's package Perkeep.
See https://developer.synology.com/developer-guide/getting_started/index.html
/cc @lindner @mpl

I'm about to jump on the Synology bandwagon

@edrex, does that mean you're about to buy a Synology NAS or you're going to package Perkeep? :)

Buying a Synology right after Christmas. I already committed to packaging Sandstorm for Synology, which is a bigger deal because sandboxes, so I can do Camlistore too.

Cross compiling for all the weird CPUs various Synology boxes contain seems like it could be a pain. Hopefully they have some automation to make it easier. I haven't looked into it. My box with be amd64.

Cross compiling for all the weird CPUs various Synology boxes contain seems like it could be a pain.

Well, the main Go compiler will do x86 and ARM cross-compilation trivially. The ppc (which I assume is 32-bit) isn't possible with the main Go compiler, though. We'd need to use gccgo there. Or could we ignore those two 2013 models? (DS213+, DS413)

It's worth noting that Synology now supports Docker pretty cleanly, so publishing images and instructions for generic Docker setups could cover this without necessarily having a custom Synology package. I've been poking at that direction a bit this week.

It's worth noting that Synology now supports Docker pretty cleanly, so publishing images and instructions for generic Docker setups could cover this without necessarily having a custom Synology package. I've been poking at that direction a bit this week.

@bpollack, keep us updated!

https://perkeep-review.googlesource.com/c/perkeep/+/17546


Linting

linting of the codebase to pass the test workflow

In this PR I tried solving all the linter issues. In particular for the typing issues, I had to rework some of the code. Please check the changes carefully, as I did not originally write much of the code myself, and might have changed some behavior unintentionally.


Python assertion failed on shutdown

We're seeing an assertion failure after we run our test suite:
E1026 14:30:30.842274624    9404 subchannel_index.c:70]      assertion failed: c != NULL

Program received signal SIGABRT, Aborted.
0x00007ffff68e0035 in raise () from /lib/x86_64-linux-gnu/libc.so.6
(gdb) bt
#0  0x00007ffff68e0035 in raise () from /lib/x86_64-linux-gnu/libc.so.6
#1  0x00007ffff68e379b in abort () from /lib/x86_64-linux-gnu/libc.so.6
#2  0x00007fffd6ade226 in current_ctx.part.0 () at src/core/ext/client_config/subchannel_index.c:70
#3  0x00007fffd6b52a8c in sck_avl_destroy () at src/core/ext/client_config/subchannel_index.c:136
#4  0x00007fffd6b044bf in unref_node () from /home/vagrant/python/local/lib/python2.7/site-packages/grpc/_cython/cygrpc.so
#5  0x00007fffd6b504a9 in grpc_client_config_shutdown () from /home/vagrant/python/local/lib/python2.7/site-packages/grpc/_cython/cygrpc.so
#6  0x00007fffd6b0a695 in grpc_shutdown () from /home/vagrant/python/local/lib/python2.7/site-packages/grpc/_cython/cygrpc.so
#7  0x00000000004bc6dc in Py_Finalize ()
#8  0x00000000004bc928 in Py_Exit ()
#9  0x00000000004bca5c in ?? ()
#10 0x00000000004998bd in PyRun_SimpleFileExFlags ()
#11 0x000000000049a9cf in Py_Main ()
#12 0x00007ffff68cb7ed in __libc_start_main () from /lib/x86_64-linux-gnu/libc.so.6
#13 0x000000000041bb31 in _start ()

Seems very similar too: https://github.com/grpc/grpc/issues/7090

Thank you for the report! How about some more detail? With what hardware platform(s), operating system(s), Python version(s), and gRPC Python version(s) are you observing the defect? Is it consistently reproducible? Are you able to share code that demonstrates the defect? How minimal are you able to make the code that demonstrates the defect?

Unfortunately it's going to be very difficult to provide much more detail than this. It doesn't always happen, and when it does its only in the context of our gitlab test machine, and only after running 20 minutes of python tests... tests that, for obvious reasons, I can't share the source code for here. Suffice it to say, it's a python application with a dozens of dependencies, and a convoluted build process.
I'm attempting to find a smaller example that might reproduce the issue. (though this is probably the kind of bug where finding a way to reproduce it consistently points directly to the solution)
We are using gRPC version 1.0.0. I tried upgrading to 1.0.1rc1, and that seems to have helped, but other engineers are telling me it still occasionally fails with the segfault. It's some sort of race condition on shutdown.
I realize this is not helpful; I put it up here in the hopes that it might be obvious what was wrong, or perhaps someone else had an easier reproduction. Feel free to close the issue if its not actionable in its current state, and I will open a new one if I can figure out something more concrete.

It's helpful that you've now shared with us why you weren't able to include much detail in your initial report. Let's leave this here and open for now; perhaps you'll be able to contribute more or perhaps someone else seeing the problem will find it and add their information to it.

@dgquintas: I realize there's not a lot here, but could you offer some hand-wavy speculation about the kinds of things that would cause E1026 14:30:30.842274624    9404 subchannel_index.c:70]      assertion failed: c != NULL?

After spending some time looking at the subchannel_index.c code, I have some ideas that I need to run through some people. I'll report with what I find, but there's nothing obviously wrong going on here.

Please ping if I haven't updated by Monday.

Thanks for taking the time to look into this. I've been pushing really hard for my team to switch to gRPC for all of our services, and your quick response and dedication in the face of an admittedly terrible bug report is exemplary.
After running gRPC 1.0.1 for the last week or so, I have not seen this issue re-occur. It never happened in production, though it did happen in our build environment. Not sure what changed between 1.0.0 and 1.0.1, but this may not be a bug anymore.

Thank you for your kind words @calebdoxsey. I'll put the investigation on hold, as the issue may indeed have been resolved in the 1.0.1 release. I'm closing the issue. Needless to say, please reopen if the issue resurfaces.
By the way, for future reference, you can get more logging by having the GRPC_VERBOSITY environment variable set to DEBUG prior to running your binary. There's also a collection of "tracers" for different part of the Core you may want to enable, even though it's a bit of a chicken-and-egg problem knowing which ones to enable. For maximum log spam action, you can set the GRPC_TRACE environment variable to all. See https://github.com/grpc/grpc/blob/1a62ec83b7af9c4437164d10fa23197c64542382/doc/environment_variables.md for more details.


OP failed to brake when lead car moved little bit

Describe the bug
OP was following the lead car properly. However, when the lead car creeped ahead little bit OP accelerated abruptly and failed to brake for the lead car.

OP was following the lead properly. However, as soon as the lead car creeped a bit, OP accelerated too abruptly resulting me in disengaging OP
How to reproduce or log data
N/A

N/A
Expected behavior
OP should start not accelerate too much when lead car creeps a bit

I also expect that OP should be braking sooner when following the lead car
Device/Version information (please complete the following information):

Device: [e.g. EON/EON Gold/comma two] (comma2)
Dongle ID: [e.g. 77611a1fac303767, can be found in Settings -> Device -> Dongle ID or my.comma.ai/useradmin]  (d2ef5aa690e849d0)
Route: [e.g. 77611a1fac303767|2020-05-11--16-37-07, can be found in my.comma.ai/useradmin] [d2ef5aa690e849d0|2021-06-14--22-35-13--4]
Timestamp: [When in the route the bug occurs (e.g. 4min 30s into the drive)] (7s-14s)
Version: [commit hash when on a non-release branch, or version number when on devel or release2 (e.g. 0.7.6)] (0.8.5)
Car make/model: [e.g. Toyota Prius 2016]  (2020 Toyota Rav4)

Additional context
Here's the youtube video of the segment. Timestamp (7-14secs)
https://youtu.be/vOOYIaejUoQ

Duplicate of https://github.com/commaai/openpilot/issues/2731

Any idea why the car is slow to respond to the braking command ? This is my second bug of the same issue and others with TSS2.0 have experienced the same issue.
If we don't know the reason for the car slow in responding to the braking command. Then the alternate way to mitigate the issue  is to not accelerate abruptly when the lead car creeps ahead. Would that work ?

We’re working on a complete overhaul of longitudinal control, so we are not making tweaks like that to the current implementation. Once the rewrite is done we’ll look more closely at these car specific quirks.


Fasta-O-Matic add fatal and non-fatal

Add the category of fatal and non-fatal to describe a FASTA format test. If fatal report error, destroy any FASTA output and die.

Added fatal and non-fatal


WIP: User doc on packaging and plugins. Drafts

First draft of pages about packaging dfdl schemas, and about plugins.
All applications using Daffodil, at least via Runtime1 should, ideally, be taking advantage of packaging DFDL schemas in Jar files, using 'sbt publish' and managed-dependencies for inter-schema dependencies, etc.

Replaced by PR https://github.com/apache/daffodil-site/pull/108


Run coverage for OTEL module too

Replaces #2504

PR updated.

Fixed the retry

@pavolloffay could you please rebase off master (not just merge)? Codecov is quite difficult to read when the base revision is not the latest.

@yurishkuro done, rebased

Still looks like it consistently pulls coverage down to 93%, below the threshold. Did you try to run coverage just for the OTEL pieces? Looks like it's what dragging down the overall level. If that's the case, I think we need to improve it first before merging, otherwise it will just lower the quality bar for everything.

rebased after @joe-elliott increased the coverage.


[Feature Request] Collapsible chapters in Updates tab

As per mockup on Discord

+1

Good

This will be awesome


Kubernetes platform training

following instructions in https://govuk-k8s-user-docs.publishing.service.gov.uk/get-started/tutorials/app-config-deploy-helm-chart/#update-an-application-39-s-environment-configuration

Setting this to draft just so that the Seal bot stops posting about it on Slack - feel free to merge any time though.


DBZ-6213 Adjust connector restart

Try to start the connector in BaseSourceTask::start(). This is the root cause of DBZ-6213 as EmbeddedEngine calls start() and assumes it really tries to start the connector.
Simplify the code by removing unnecessary checks and restartDelay.hasElapsed() call.

https://issues.redhat.com/browse/DBZ-6213

@vjuranek Applied, thanks a lot


Ability to avoid some subscriptions to document events.

Is it possible to opt out of some subscriptions in registerHandlers method of ContextMenu. It would be great to have more control over it with props, just to add flexibility in some tricky use cases.

Can you provide some examples?

For example, I had an issue with "contextmenu" subscription. For some reason, the menu was not opening in my app on Android because long touch would lead to "contextmenu" event (I assume it was being fired by 3rd party grid component I was using), which by default hides menu. I ended up fixing it with a hack, but it would be nice to have flexibility in such cases.

Can you open a PR with your proposed fix?


Report a Project

A Report Project functionality; similar to how you can Report Accounts on social media. The feature will enable volunteers to bring potentially unrelated projects/ projects that are misusing the platform to the notice of the moderators of HWC.
It doesn't have to be too complicated. It could be as simple as someone clicking a "Report" button on a project and the moderators getting some sort of notification so that they can gather more information; maybe contact the project owner and take appropriate action.

picking this up with @shen-sat

We've just been discussing this and wondering if it would be better to just leave this - there is a 'contact us' email address people can use, and adding a 'report this project' button to a project page changes the feel of the page. On social media such as instagram, the report/block user functionality is hidden in a drop down menu but the navigation on HWC doesn't have any of these. Thoughts? If you had a place in mind where it would be good to put it, let us know. Cheers.


Pass Message Format 2 WG defined tests

wg_test.go reads tests from MF2 WG and runs them.
Currently, most of them fail.

Closed by accident.