Remove database delivery for business and developer welcome notifications

Pull request checklist

[x] My code contains tests covering the code I modified
[x] I linted and tested the project with bin/check
[x] I added significant changes and product updates to the changelog

Remove database delivery method for notification we don't want them to appear on the UI but send with other delivery methods like email.
closes #789

@joemasilotti do you have some tests for checking an emails is enqueued after developer.save_and_notify

I wouldn't think so since they would be queued to run on a background job when creating the notification. We will want to add them in.

@joemasilotti without the database delivery method the record will be nil
https://github.com/joemasilotti/railsdevs.com/blob/2ce462409934bd423ad53a34b26d70d85db11f91/app/mailers/developer_mailer.rb#L17
Is there another simple way you can get the notification instance at this level?
Only the developer and recipient params will be available.
(byebug) params
{:developer=>#<Developer id: 1, name: "Concepcion Fritsch", available_on: "2022-02-25", hero: "Molestiae ut dolores vel.", bio: "Maiores ducimus repellendus. Et architecto iusto. ...", website: nil, github: nil, twitter: nil, created_at: "2022-03-12 07:23:39.500642000 +0000", updated_at: "2022-03-12 07:23:39.574053000 +0000", user_id: 1, linkedin: nil, search_status: "open", preferred_min_hourly_rate: nil, preferred_max_hourly_rate: nil, preferred_min_salary: nil, preferred_max_salary: nil, textsearchable_index_col: "'a':30 'architecto':9 'aut':27,31 'autem':32 'comm...", featured_at: nil, profile_reminder_notifications: true, stack_overflow: nil, public_profile_key: nil, source_contributor: false, mastodon: nil, availability_status: "now">, :recipient=>#<User id: 1, email<EMAIL_ADDRESS>created_at: "2022-03-12 07:23:36.732180000 +0000", updated_at: "2022-07-14 16:25:32.600803000 +0000", admin: false, authentication_token: [FILTERED], suspended: false, referral_code: nil>, :record=>nil}

Nice! So glad I have those mailer validators. They have caught so many potential issues.
There will no longer be a notification to reference. So the mailer will need to get the developer/business as a param directly. DeveloperMailer#celebration_promotion and BusinessesMailer#developer_profiles are using that pattern if it helps to model after something.

@joemasilotti i think we can get rid of @notification variable plus this link. Which other link url can we replace with https://railsdevs.com ?
https://github.com/joemasilotti/railsdevs.com/blob/2ce462409934bd423ad53a34b26d70d85db11f91/app/views/developer_mailer/welcome.html.erb#L2

https://railsdevs.com works.

Did something like this to get the subject. Check if it works well
  subject = Developers::WelcomeNotification.new.title

Did something like this to get the subject. Check if it works well
  subject = Developers::WelcomeNotification.new.title

Just remove it 4bc539fce2b3ea415ff7a2eaef6b844fba48b284 😄

Sorry for the rewrite... I realized we were doing too much working around Noticed. I ripped out the notifications and instead am using a good ol' mailer directly to send the email.
Thanks for your contribution, @gathuku!


Add a note about anonymizing IP addresses to the Stock Price Checker project

Recently we fixed an issue with saving a user's IP address to the database for calculating likes.
We also added some functionality to anonymize IP addresses before saving it to the db. The method we went with was to set the last octet of an IPv4 address to 0 (<IP_ADDRESS> --> <IP_ADDRESS>), or the last 32 bits of an IPv6 address to 0:0 (2001:db8:3333:4444:5555:6666:7777:8888 --> 2001:db8:3333:4444:5555:6666:0:0). This was done to remain compliant with GDPR data privacy regulations, which considers an IP address to be personal identifying information.
Picking up the conversation from https://github.com/freeCodeCamp/freeCodeCamp/issues/37700, we may want to add a note to the Stock Price Checker project about the privacy considerations that come with saving an IP address to the database. We can also mention different ways learners could anonymize an IP address (truncating part of it like we did, hashing it, and so on).

Should this be opened for help, or there is discussion to be had first on this?

I think we can open this up for help. It would make a good issue for first timers.
I'm not that familiar with GDPR and similar regulations, but I'm thinking a simple note at the end of the project page should be enough.
The note could mention the importance of complying with data privacy rules when it comes to processing personal data like IP addresses. There are different ways to comply with the rules, like getting permission from a user to collect their personal data, but the easiest way is to anonymize that data.
The note could mention that a good way to effectively anonymize IP addresses is to leave off the last octet of an IPv4 address, or the last chunk of an IPv6 address. Apparently this is better than hashing the whole address, which could potentially be cracked.

Thanks for opening this issue.
This looks something that can be fixed by "first time" code contributors to this repository. Here are the files that you should be looking at to work on a fix:
List of files:

https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/english/09-information-security/information-security-projects/stock-price-checker.md

Please make sure you read our guidelines for contributing, we prioritize contributors following the instructions in our guides. Join us in our chat room or the forum if you need help contributing, our moderators will guide you through this.
Sometimes we may get more than one pull requests. We typically accept the most quality contribution followed by the one that is made first.
Happy contributing.

I am interested to fix this issue.

Hey @sandipanpanda
An issue with the help wanted or first timers only label is open for contribution. The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors.
If you would like to contribute, and have not read the contributors docs, please do so here: https://contribute.freecodecamp.org/#/
If you have any issues with contributing, be sure to join us on the contributors channel, or on the contributors sub-forum

Is this issue still open?

@LilCthulu yes, but now there is a pr that will close this one


Update acorn to 5.6.2

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

audit for acorn: failed
 - download not possible: sha256 mismatch
Expected: 89b794eebbace2e81c6d1e4c9425f37d14f864e00fba30b1b4eb6f37ff635a8f
Actual: e67b96b07746b7bd9b23a100a8366954551467658da5f2178a7dd13d25090958
File: /Users/travis/Library/Caches/Homebrew/Cask/acorn--5.6.2.zip
To retry an incomplete download, remove the file above.
 - appcast checkpoint mismatch
Expected: 3362206a7a3a6b81d107918a92e606e99b3aa1b6cb2b38c0c73f3580b13220f0
Actual: 4a02b750dc74fd39954c1bba77f7fd977e9097a02c6f7a7e7431842356f2655e


How do I make v-line-clamp:20="2" the 20 and 2 come from data attribute

The title...

v-line-clamp:[lineHeight]="numberOfLines" did the trick


Failed getting response from http://<IP_ADDRESS>:4001/: cancelled

7 machines cluster, 3 mains etcd, 4 etcd proxies, all running on 4001 and 2379

etcd 2.0.10
fleet : 0.10.1
coreos : 681.0.0

On all machine I'm getting this
fleetd[24283]: INFO client.go:292: Failed getting response from http://<IP_ADDRESS>:4001/: cancelled

Fleet agent is working : reconcile, schedule ...
But fleetctl on many requests send :
Error retrieving list of units from repository: googleapi: Error 503: fleet server unable to communicate with etcd

OR
2015/06/15 14:29:50 WARN fleetctl.go:772: Error retrieving<EMAIL_ADDRESS>from Registry: Get http://domain-sock/fleet/v1/units/worker.collector%40x3.service?alt=json: forwarding request denied

Etcd is fine on all machines and answers fine when I query it during the request denied.
Any idea ?

I have same pb and when i put fleet in debug mode i have : https://gist.github.com/tclavier/3aa1cb84a229aedb53ab
And when i put value into key space with etcdctl that work fine.

I was getting a lot of the same messages, increasing the etcd_request_timeout made them go away for me.

@tclavier is it a timeout issue? Are you able to reproduce the error if you raise the etcd_request_timeout in both fleetctl and fleetd?

For last test i use

etcd v2.0.13
fleet master (with nativ etcd client library)
and etcd_request_timeout set to 2

Errors are same :
fleet server unable to communicate with etcd

Looks like I've got the same issue on my side. I keep on getting INFO client.go:292: Failed getting response from http://localhost:2379/: cancelled messages, and at some point Fleet randomly restarts units:
06:38:48 host fleetd[23463]: INFO client.go:292: Failed getting response from http://localhost:2379/: cancelled
06:38:48 host fleetd[23463]: INFO client.go:292: Failed getting response from http://localhost:2379/: cancelled
06:38:48 host fleetd[23463]: INFO client.go:292: Failed getting response from http://localhost:2379/: cancelled
06:38:48 host fleetd[23463]: INFO client.go:292: Failed getting response from http://localhost:2379/: cancelled
06:39:45 host fleetd[23463]: WARN job.go:272: No Unit found in Registry for Job(consul-registrator.service)
06:39:45 host fleetd[23463]: ERROR job.go:109: Failed to parse Unit from etcd: unable to parse Unit in Registry at key /_coreos.com/fleet/job/consul-registrator.service/object
06:39:45 host fleetd[23463]: INFO client.go:292: Failed getting response from http://localhost:2379/: cancelled
06:39:46 host fleetd[23463]: INFO manager.go:138: Triggered systemd unit consul-registrator.service stop: job=11845869
06:39:46 host fleetd[23463]: INFO manager.go:259: Removing systemd unit consul-registrator.service
06:39:47 host fleetd[23463]: INFO manager.go:182: Instructing systemd to reload units
06:39:52 host fleetd[23463]: INFO reconcile.go:330: AgentReconciler completed task: type=UnloadUnit job=consul-registrator.service reason="unit loaded but not scheduled here"
06:39:52 host fleetd[23463]: INFO reconcile.go:330: AgentReconciler completed task: type=ReloadUnitFiles job=N/A reason="always reload unit files"
06:39:52 host fleetd[23463]: WARN reconcile.go:59: AgentReconciler completed reconciliation in 8.692721762s
06:39:52 host fleetd[23463]: INFO manager.go:246: Writing systemd unit consul-registrator.service (618b)
06:39:52 host fleetd[23463]: INFO manager.go:182: Instructing systemd to reload units
06:39:55 host fleetd[23463]: INFO manager.go:127: Triggered systemd unit consul-registrator.service start: job=11846043
06:39:55 host fleetd[23463]: INFO reconcile.go:330: AgentReconciler completed task: type=LoadUnit job=consul-registrator.service reason="unit scheduled here but not loaded"
06:39:55 host fleetd[23463]: INFO reconcile.go:330: AgentReconciler completed task: type=ReloadUnitFiles job=N/A reason="always reload unit files"
06:39:55 host fleetd[23463]: INFO reconcile.go:330: AgentReconciler completed task: type=StartUnit job=consul-registrator.service reason="unit currently loaded but desired state is launched"
06:40:03 host fleetd[23463]: WARN reconcile.go:59: AgentReconciler completed reconciliation in 6.414672939s
06:40:30 host fleetd[23463]: INFO client.go:292: Failed getting response from http://localhost:2379/: cancelled
06:40:30 host fleetd[23463]: INFO client.go:292: Failed getting response from http://localhost:2379/: cancelled
06:40:30 host fleetd[23463]: INFO client.go:292: Failed getting response from http://localhost:2379/: cancelled
06:40:30 host fleetd[23463]: INFO client.go:292: Failed getting response from http://localhost:2379/: cancelled
06:40:45 host fleetd[23463]: INFO client.go:292: Failed getting response from http://localhost:2379/: cancelled
06:40:45 host fleetd[23463]: INFO client.go:292: Failed getting response from http://localhost:2379/: cancelled
06:40:45 host fleetd[23463]: INFO client.go:292: Failed getting response from http://localhost:2379/: cancelled

Running:

etcd Version: 2.0.12
fleetd version 0.10.2

Timeouts for etcd2:

heartbeat-interval: 200
election-timeout: 2000

And for fleet:

etcd_request_timeout: 3

Happens on just one out of three machines in the cluster.

Same here.

I got rid of the first error message of the original poster by fixing the dependencies in my unit files: I had made them dependent on etcd although etcd2 is running.
The second error message, for example,
2015/09/05 13:07:45 WARN fleetctl.go:797: Error retrieving Unit(memcached.service) from Registry: Get http://domain-sock/fleet/v1/units/memcached.service?alt=json: forwarding request denied

I get only if I try to start a new unit using fleetctl through a tunnel, with the unit file residing of the host system.  Executing it within the VM that's running CoreOS is fine.

I have the same issue as @bronger on Vagrant... Trying to load services via --tunnel leads to infinite hanging with these warnings :
Error retrieving<EMAIL_ADDRESS>from Registry: Get http://domain-sock/fleet/v1/units/es-data%401.service?alt=json: forwarding request denied

This is how I start up Vagrant : https://github.com/l15k4/coreos-es/blob/master/bin/start-vagrant.sh#L47
And then I'm just loading and starting services :
https://github.com/l15k4/coreos-es/blob/master/bin/start-vagrant.sh#L91
Using fleetctl --debug=true --strict-host-key-checking=false.

@bronger any update as to why you got that error? I'm getting a similar one too.
$ fleetctl start<EMAIL_ADDRESS>2016/01/21 10:29:12 WARN fleetctl.go:799: Error retrieving<EMAIL_ADDRESS>from Registry: Get http://domain-sock/fleet/v1/units/app-dashboard%401.service?alt=json: forwarding request denied
2016/01/21 10:29:13 WARN fleetctl.go:799: Error retrieving<EMAIL_ADDRESS>from Registry: Get http://domain-sock/fleet/v1/units/app-dashboard%402.service?alt=json: forwarding request denied
2016/01/21 10:29:13 WARN fleetctl.go:799: Error retrieving<EMAIL_ADDRESS>from Registry: Get http://domain-sock/fleet/v1/units/app-dashboard%401.service?alt=json: forwarding request denied
2016/01/21 10:29:13 WARN fleetctl.go:799: Error retrieving<EMAIL_ADDRESS>from Registry: Get http://domain-sock/fleet/v1/units/app-dashboard%403.service?alt=json: forwarding request denied
Unit<EMAIL_ADDRESS>inactive
Unit<EMAIL_ADDRESS>inactive
Unit<EMAIL_ADDRESS>inactive
Unit<EMAIL_ADDRESS>inactive
2016/01/21 10:29:14 WARN fleetctl.go:799: Error retrieving<EMAIL_ADDRESS>from Registry: Get http://domain-sock/fleet/v1/units/app-dashboard%402.service?alt=json: forwarding request denied
2016/01/21 10:29:14 WARN fleetctl.go:799: Error retrieving<EMAIL_ADDRESS>from Registry: Get http://domain-sock/fleet/v1/units/app-dashboard%403.service?alt=json: forwarding request denied
2016/01/21 10:29:14 WARN fleetctl.go:799: Error retrieving<EMAIL_ADDRESS>from Registry: Get http://domain-sock/fleet/v1/units/app-dashboard%404.service?alt=json: forwarding request denied

$ fleetctl -version
fleetctl version 0.11.5

I abandoned fleet for my workflow, so I cannot help on this.

@bweston92 We handled this by changing the timeout settings. See issue 1289 and specifically this comment: https://github.com/coreos/fleet/issues/1289#issuecomment-146424680


README.md has wrong version number information

The README's version numbers still refer to the old eureka project. Please update them, including the hyperlinks that are used to create the version number badges for maven central and the javadoc.

Fixed.


OLM collect-profiles job tries to access non existing volumes after upgrade from 4.8 to 4.9

Describe the bug
I noticed that the OLM collect-profiles job tries and fails to access some volumes.
MountVolume.SetUp failed for volume "config-volume" : object "openshift-operator-lifecycle-manager"/"collect-profiles-config" not registered
MountVolume.SetUp failed for volume "kube-api-access-d4kzh" : [object "openshift-operator-lifecycle-manager"/"kube-root-ca.crt" not registered, object "openshift-operator-lifecycle-manager"/"openshift-service-ca.crt" not registered]
MountVolume.SetUp failed for volume "secret-volume" : object "openshift-operator-lifecycle-manager"/"pprof-cert" not registered

I noticed, that the same log messages can be found here:
https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-ci-4.9-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade/1428509007814856704
Version
4.9.0-0.okd-2021-11-28-035710
How reproducible
Upgrade existing 4.8 okd cluster to 4.9
Log bundle
Could not pull "must-gather" image from quay.io. I still have to investigate why I ran into a back-off timeout here.

Seems to be affecting OCP as well, please re-file this as a bugzilla ticket

OCP Bugzilla Link: https://bugzilla.redhat.com/show_bug.cgi?id=2029836


Add Responsiveness To Header

💡 Description
Add responsiveness to header.
Bars need to resize
https://www.figma.com/design/QqXo2XsUrKVu7KVjOHVeHk/PDS-Design-Library?node-id=3919-92942&t=PjLMiN6Fl2q9rjdE-0
New menu must appear when small enough.

⚔ Parent Epic / Related Tickets
No response

Working on adding responsiveness to the header; it changes in sizes depending on how big the screen is. Node home pages completed. Mobile browsing FTW

Pull requests:
WDS https://github.com/NASA-PDS/wds/pull/38
WDS-React https://github.com/NASA-PDS/wds-react/pull/32

Awaiting review and merge.

Updated after review. Expecting new review.


Fix sql flattening logic when selecting windowing or data generator c…

…olumns
Please answer these questions before submitting your pull requests. Thanks!

What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #810566

Fill out the following pre-review checklist:

[x] I am adding a new automated test(s) to verify correctness of my new code
[ ] I am adding new logging messages
[ ] I am adding a new telemetry message
[ ] I am adding new credentials
[ ] I am adding a new dependency

Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.

@sfc-gh-yixie are we going to merge this pr?


Fix custom base URL handling in CLI / Runner

Fixes #248

Codecov Report

Merging #249 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 947d771...56d8309. Read the comment docs.


Kustomize op Patches cause a Panic

The kustomize op patches appear to cause a panic I believe because the patch "manifest" is consumed by the rust code, and, doesn't have a metadata top-level field. If I had to guess here (not a rust developer): https://github.com/dag-andersen/argocd-diff-preview/blob/4018a125bd1e4ffc7bbcb66953d6a712ee7f3a7c/src/parsing.rs#L130-L133
I suspect some logic could be added that understands that this is a patch file if the manifest is a yaml array?
Reproduction is here: https://github.com/seanturner026/argocd-applicationset/pull/16
thread 'main' panicked at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/serde_yaml-0.9.34+deprecated/src/value/index.rs:107:18:
cannot access key "metadata" in YAML sequence
stack backtrace:
   0:     0x55b689a195a5 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h1e1a1972118942ad
   1:     0x55b689a4232b - core::fmt::write::hc090a2ffd6b28c4a
   2:     0x55b689a1606f - std::io::Write::write_fmt::h8898bac6ff039a23
   3:     0x55b689a1937e - std::sys_common::backtrace::print::ha96650907276675e
   4:     0x55b689a1a639 - std::panicking::default_hook::{{closure}}::h215c2a0a8346e0e0
   5:     0x55b689a1a37d - std::panicking::default_hook::h207342be97478370
   6:     0x55b689a1aad3 - std::panicking::rust_panic_with_hook::hac8bdceee1e4fe2c
   7:     0x55b689a1a9b4 - std::panicking::begin_panic_handler::{{closure}}::h00d785e82757ce3c
   8:     0x55b689a19a69 - std::sys_common::backtrace::__rust_end_short_backtrace::h1628d957bcd06996
   9:     0x55b689a1a6e7 - rust_begin_unwind
  10:     0x55b689833503 - core::panicking::panic_fmt::hdc63834ffaaefae5
  11:     0x55b6898c72db - <str as serde_yaml::value::index::Index>::index_or_insert::hd6d0c1c95c13231b
  12:     0x55b68987c5a0 - <core::iter::adapters::map::Map<I,F> as core::iter::traits::iterator::Iterator>::try_fold::hff88f73c16dfea7b
  13:     0x55b689884c30 - alloc::vec::in_place_collect::from_iter_in_place::hdc2e306cc50df39d
  14:     0x55b68983b4bf - argocd_diff_preview::parsing::get_applications::{{closure}}::h5663ff95e448d371
  15:     0x55b6898430a7 - argocd_diff_preview::main::{{closure}}::hd46a67bf7e27a527
  16:     0x55b689837695 - tokio::runtime::park::CachedParkThread::block_on::heeaa189f831dfbc9
  17:     0x55b6898720ad - tokio::runtime::runtime::Runtime::block_on::h110d3d393288d378
  18:     0x55b68986d1bc - argocd_diff_preview::main::h27bd70ec1900b1c5
  19:     0x55b689885ef3 - std::sys_common::backtrace::__rust_begin_short_backtrace::h1d4959767a14ecdc
  20:     0x55b68987f489 - std::rt::lang_start::{{closure}}::h6dce2a7c30d504f8
  21:     0x55b689a0f6e0 - std::rt::lang_start_internal::h3ed4fe7b2f419135
  22:     0x55b68986d295 - main
  23:     0x7f25addbd24a - <unknown>
  24:     0x7f25addbd305 - __libc_start_main
  25:     0x55b689833c1a - _start
  26:                0x0 - <unknown>

Hi @seanturner026
Thank you for reporting this issue! 🚀
I have fixed it in version v0.0.13 (PR)
argocd-diff-preview It will now check if kind equals Application or ApplicationSet, before doing any patching.
 Definitely no more panic.
Are these patches examples of something that needs to be generated per the README.md?
    - name: Generate with kustomize
      run: kustomize build pull-request/some/path/my-kustomize > pull-request/rendered-apps.yaml

I’m not sure I understand the question! :)
However, the example seems to describe a scenario where some teams do not store any raw application YAML files in their repository. Instead, they use tools like Helm or Kustomize to generate all their applications. In these cases, they must manually generate or build the applications before running the tool.
I can see that you also generate your application with Kustomize: clusters/staging/kustomization.yaml
However, since your Kustomize template does not modify the ApplicationSet, you don’t need to manually build Kustomize.  The tool should find clusters/staging/argocd-appset.yaml without any problems :)

Yeah, I can see where the confusion came from 😅
Basically, after this change, that kustomization patch wasn't being picked up by the github action:
https://github.com/seanturner026/argocd-applicationset/pull/22
https://github.com/seanturner026/argocd-applicationset/pull/23
I thought there was maybe a regression where patching was broken in v0.13.0, but, that doesn't seem to be the case:
https://github.com/seanturner026/argocd-applicationset/pull/24
I guess 22 and 23 aren't being picked up because they're patching CRDs?
Either way, shall close this for now. Thanks again!

@seanturner026
No problem! 😄
I believe your karpenter-crds changes are not picked up because those files are not rendered by any of your argocd apps? That karpenter-folder does not seem to be captured by your argocd-appset.yaml
Anyway, feel free to open a new issue if you suspect you’ve found a problem! 🚀


Change taskbar network speed meter implementation to support windows 10 & 11.

Microsoft stopped officially supporting the deskband feature as of windows 7. The feature was still included in the following operating system releases up until windows 10 and finally removed in windows 11.
Due to this, the network speed meter will not officially work on windows 11.
Describe the solution you'd like
Instead of installing the speed meter to the taskbar as a deskband (the current implementation), implement the meter as a mini window which will always stay on top. the user can move this mini window to any position in the desktop, especially over the taskbar.

May be using a mini window is a good alternative implementation, showing an always on top window, if user move it to any side of screen, then show a very simple widget instead.

A small update on the mini window implementation i'm working on

this implementation still needs some refining.

This doesn't work nicely if you have small icons for the taskbar activated in Windows 10 and the miniwidget is not adjustable in size, so it's too big to nicely hover over the taskbar.


Cursor is visible on multiple input fields

Since updating to the new Atom 1.20 the cursor is visible on multiple input fields, I tried removing the compiled-cache to no avail. This seems to be a bug or compatibility issue.

Thanks for reaching out!
We require the template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.
Thanks for understanding and meeting us half way :grinning:


adds a regexp location path option on configmap

I would like to use regexp in Ingress path rules. like this:
    http:
      paths:
      - path: "/$"
        backend:
          serviceName: www
          servicePort: 80
      - path: "/index.html"
        backend:
          serviceName: www
          servicePort: 80
      - path: "/static_html"
        backend:
          serviceName: www
          servicePort: 80
      - path: "/.+"
        backend:
          serviceName: api
          servicePort: 80

This PR achieves the case using regex path for nginx location directive.

This change is

Coverage increased (+0.07%) to 47.167% when pulling 33af01d4d5f5b5916c3d5c49140bd13b61def004 on literalice:regexp into b6d11caef3795f4ee56ad124c531347292f696cc on kubernetes:master.

Coverage increased (+0.08%) to 46.582% when pulling 48419ed9d5fee460e5f7391b6b727aa19d04309b on literalice:regexp into 4c868cf62afa94dda6cc74a3fb92ed77b606eb7b on kubernetes:master.

This would be really useful to me too. But would it make more sense to have the annotation per ingress instead of a global config option?


fix: modify typo in cmake args for mac

I found a typo in my previous commit, so I fixed it.

@ahcorde I'm sorry, but I made a mistake in my previous commit. I appreciate it if you could take a look.


Update nsfw.json

Added a whole bunch of NSFW sites ;)

you may add newgrounds, reddit or deviantart since they also have nsfw stuff but arent mainly nsfw


Add CometLLM integration notebook example

I also added LANGCHAIN_COMET_TRACING to enable the CometLLM tracing integration similar to other tracing integrations. This is easier for end-users to enable it rather than importing the callback and pass it manually.

@hwchase17 I'm not sure where the lint error comes from: https://github.com/langchain-ai/langchain/actions/runs/7194744376/job/19595915961
When running the same command on the last commit on that branch, I get many errors but not on the files I touched:

Output of make lint_package
$ git rev-parse HEAD
57eacf3b81e1649676f15c7025d3f88b773d9280
$ make lint_package
poetry run ruff docs templates cookbook
poetry run ruff format docs templates cookbook --diff
1091 files left unchanged
poetry run ruff --select I docs templates cookbook
cookbook/Multi_modal_RAG.ipynb:cell 5:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/Multi_modal_RAG.ipynb:cell 7:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/Multi_modal_RAG.ipynb:cell 11:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/Semi_Structured_RAG.ipynb:cell 12:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/Semi_Structured_RAG.ipynb:cell 18:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/Semi_structured_and_multi_modal_RAG.ipynb:cell 9:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/Semi_structured_and_multi_modal_RAG.ipynb:cell 18:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/Semi_structured_multi_modal_RAG_LLaMA2.ipynb:cell 8:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/Semi_structured_multi_modal_RAG_LLaMA2.ipynb:cell 16:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/advanced_rag_eval.ipynb:cell 12:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/advanced_rag_eval.ipynb:cell 16:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/advanced_rag_eval.ipynb:cell 26:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/autogpt/autogpt.ipynb:cell 8:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/autogpt/marathon_times.ipynb:cell 3:2:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/autogpt/marathon_times.ipynb:cell 12:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/autogpt/marathon_times.ipynb:cell 15:2:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/baby_agi.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/baby_agi_with_agent.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/causal_program_aided_language_model.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/custom_agent_with_plugin_retrieval_using_plugnplai.ipynb:cell 5:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/docugami_xml_kg_rag.ipynb:cell 21:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/docugami_xml_kg_rag.ipynb:cell 26:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/elasticsearch_db_qa.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/extraction_openai_tools.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/generative_agents_interactive_simulacra_of_human_behavior.ipynb:cell 4:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/gymnasium_agent_simulation.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/hugginggpt.ipynb:cell 6:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/llm_bash.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/llm_bash.ipynb:cell 4:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/llm_symbolic_math.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/multi_modal_QA.ipynb:cell 5:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/multi_modal_RAG_chroma.ipynb:cell 9:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/multi_modal_RAG_chroma.ipynb:cell 13:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/multiagent_authoritarian.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/multiagent_bidding.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/myscale_vector_sql.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/myscale_vector_sql.ipynb:cell 4:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/myscale_vector_sql.ipynb:cell 5:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/myscale_vector_sql.ipynb:cell 7:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/openai_functions_retrieval_qa.ipynb:cell 25:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/openai_v1_cookbook.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/openai_v1_cookbook.ipynb:cell 28:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/petting_zoo.ipynb:cell 5:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/plan_and_execute_agent.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/program_aided_language_model.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/qianfan_baidu_elasticesearch_RAG.ipynb:cell 6:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/rag_fusion.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/rag_fusion.ipynb:cell 7:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/retrieval_in_sql.ipynb:cell 20:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/rewrite.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/sales_agent_with_context.ipynb:cell 3:8:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/selecting_llms_based_on_context_length.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/smart_llm.ipynb:cell 4:1:1: I001 [*] Import block is un-sorted or un-formatted
cookbook/stepback-qa.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/expression_language/cookbook/code_writing.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/expression_language/cookbook/embedding_router.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/expression_language/cookbook/memory.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/expression_language/cookbook/retrieval.ipynb:cell 4:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/expression_language/cookbook/retrieval.ipynb:cell 11:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/expression_language/cookbook/sql_db.ipynb:cell 9:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/expression_language/cookbook/tools.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/expression_language/get_started.ipynb:cell 4:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/expression_language/get_started.ipynb:cell 21:4:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/expression_language/how_to/binding.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/expression_language/how_to/configure.ipynb:cell 4:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/expression_language/how_to/configure.ipynb:cell 18:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/expression_language/how_to/functions.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/expression_language/how_to/generators.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/expression_language/how_to/map.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/expression_language/how_to/map.ipynb:cell 6:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/expression_language/how_to/map.ipynb:cell 8:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/expression_language/how_to/message_history.ipynb:cell 11:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/expression_language/how_to/passthrough.ipynb:cell 6:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/expression_language/how_to/routing.ipynb:cell 4:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/expression_language/interface.ipynb:cell 26:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/guides/evaluation/string/custom.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/guides/evaluation/trajectory/trajectory_eval.ipynb:cell 5:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/guides/privacy/presidio_data_anonymization/multi_language.ipynb:cell 19:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/guides/privacy/presidio_data_anonymization/qa_privacy_protection.ipynb:cell 36:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/guides/safety/amazon_comprehend_chain.ipynb:cell 8:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/adapters/openai-old.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/adapters/openai.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/callbacks/confident.ipynb:cell 18:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/callbacks/infino.ipynb:cell 4:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/callbacks/promptlayer.ipynb:cell 7:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/callbacks/promptlayer.ipynb:cell 9:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/callbacks/promptlayer.ipynb:cell 11:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/callbacks/sagemaker_tracking.ipynb:cell 6:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/chat/baidu_qianfan_endpoint.ipynb:cell 3:2:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/chat/fireworks.ipynb:cell 11:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/chat/llama2_chat.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/chat/pai_eas_chat_endpoint.ipynb:cell 4:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/chat_loaders/facebook.ipynb:cell 30:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/chat_loaders/imessage.ipynb:cell 22:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/chat_loaders/langsmith_llm_runs.ipynb:cell 6:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/document_loaders/airbyte_cdk.ipynb:cell 11:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/document_loaders/azure_ai_data.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/document_loaders/cube_semantic.ipynb:cell 8:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/document_loaders/docugami.ipynb:cell 30:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/document_loaders/geopandas.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/document_loaders/google_speech_to_text.ipynb:cell 14:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/document_loaders/psychic.ipynb:cell 4:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/document_loaders/rockset.ipynb:cell 5:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/document_loaders/rockset.ipynb:cell 12:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/document_loaders/snowflake.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/document_loaders/tencent_cos_directory.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/document_loaders/tencent_cos_file.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/document_loaders/unstructured_file.ipynb:cell 24:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/document_transformers/nuclia_transformer.ipynb:cell 7:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/llms/databricks.ipynb:cell 5:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/llms/huggingface_pipelines.ipynb:cell 7:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/llms/jsonformer_experimental.ipynb:cell 5:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/llms/jsonformer_experimental.ipynb:cell 7:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/llms/llm_caching.ipynb:cell 14:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/llms/llm_caching.ipynb:cell 19:3:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/llms/llm_caching.ipynb:cell 27:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/llms/llm_caching.ipynb:cell 31:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/llms/llm_caching.ipynb:cell 44:3:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/llms/lmformatenforcer_experimental.ipynb:cell 8:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/llms/manifest.ipynb:cell 4:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/llms/opaqueprompts.ipynb:cell 9:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/llms/promptlayer_openai.ipynb:cell 5:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/llms/rellm_experimental.ipynb:cell 5:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/llms/runhouse.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/llms/sagemaker.ipynb:cell 9:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/llms/volcengine_maas.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/memory/aws_dynamodb.ipynb:cell 14:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/memory/rockset_chat_message_history.ipynb:cell 6:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/memory/sql_chat_message_history.ipynb:cell 7:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/providers/rebuff.ipynb:cell 11:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/retrievers/Activeloop DeepMemory+LangChain.ipynb:cell 26:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/retrievers/Activeloop DeepMemory+LangChain.ipynb:cell 29:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/retrievers/bedrock.ipynb:cell 7:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/retrievers/cohere.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/retrievers/docarray_retriever.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/retrievers/docarray_retriever.ipynb:cell 25:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/retrievers/fleet_context.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/retrievers/fleet_context.ipynb:cell 12:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/retrievers/merger_retriever.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/retrievers/self_query/mongodb_atlas.ipynb:cell 6:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/retrievers/self_query/supabase_self_query.ipynb:cell 15:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/stores/upstash_redis.ipynb:cell 4:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/text_embedding/self-hosted.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/toolkits/airbyte_structured_qa.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/toolkits/csv.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/toolkits/document_comparison_toolkit.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/toolkits/github.ipynb:cell 14:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/toolkits/json.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/toolkits/openapi.ipynb:cell 9:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/toolkits/pandas.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/toolkits/pandas.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/toolkits/powerbi.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/toolkits/python.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/toolkits/spark.ipynb:cell 4:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/toolkits/xorbits.ipynb:cell 4:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/toolkits/xorbits.ipynb:cell 12:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/tools/gradio_tools.ipynb:cell 10:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/tools/lemonai.ipynb:cell 12:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/tools/metaphor_search.ipynb:cell 6:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/tools/metaphor_search.ipynb:cell 11:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/tools/python.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/vectorstores/annoy.ipynb:cell 33:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/vectorstores/astradb.ipynb:cell 6:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/vectorstores/meilisearch.ipynb:cell 19:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/vectorstores/supabase.ipynb:cell 10:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/integrations/vectorstores/vearch.ipynb:cell 5:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/agents/agent_types/openai_functions_agent.ipynb:cell 4:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/agents/agent_types/structured_chat.ipynb:cell 4:2:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/agents/how_to/add_memory_openai_functions.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/agents/how_to/agent_iter.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/agents/how_to/agent_structured.ipynb:cell 8:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/agents/how_to/custom-functions-with-openai-functions-agent.ipynb:cell 8:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/agents/tools/custom_tools.ipynb:cell 26:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/agents/tools/custom_tools.ipynb:cell 30:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/agents/tools/custom_tools.ipynb:cell 45:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/agents/tools/tool_input_validation.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/callbacks/filecallbackhandler.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/chains/document/map_reduce.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/chains/document/map_rerank.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/chains/document/refine.ipynb:cell 4:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/chains/document/stuff.ipynb:cell 4:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/chains/foundational/router.ipynb:cell 4:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/chains/foundational/router.ipynb:cell 6:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/chains/how_to/call_methods.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/chains/how_to/custom_chain.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/data_connection/retrievers/MultiQueryRetriever.ipynb:cell 8:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/data_connection/retrievers/index.ipynb:cell 7:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/data_connection/retrievers/multi_vector.ipynb:cell 15:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/data_connection/retrievers/web_research.ipynb:cell 13:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/memory/custom_memory.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/model_io/llms/custom_llm.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/model_io/output_parsers/index.ipynb:cell 3:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/model_io/output_parsers/pandas_dataframe.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/model_io/output_parsers/pydantic.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/model_io/output_parsers/retry.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/model_io/prompts/prompt_templates/connecting_to_a_feature_store.ipynb:cell 48:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/model_io/prompts/prompt_templates/custom_prompt_template.ipynb:cell 5:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/modules/model_io/prompts/prompt_templates/index.ipynb:cell 11:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/use_cases/data_generation.ipynb:cell 4:6:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/use_cases/data_generation.ipynb:cell 17:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/use_cases/data_generation.ipynb:cell 28:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/use_cases/extraction.ipynb:cell 17:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/use_cases/extraction.ipynb:cell 20:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/use_cases/extraction.ipynb:cell 22:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/use_cases/graph/graph_memgraph_qa.ipynb:cell 5:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/use_cases/qa_structured/sql.ipynb:cell 5:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/use_cases/qa_structured/sql.ipynb:cell 20:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/use_cases/qa_structured/sql.ipynb:cell 55:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/use_cases/question_answering/conversational_retrieval_agents.ipynb:cell 30:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/use_cases/question_answering/index.ipynb:cell 12:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/docs/use_cases/question_answering/index.ipynb:cell 44:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/scripts/model_feat_table.py:1:1: I001 [*] Import block is un-sorted or un-formatted
Found 212 errors.
[*] 212 fixable with the `--fix` option.
make: *** [Makefile:47: lint_package] Error 1

Looking at the commit that was checkout for this failing job, it seems to be an old merge commit that's not part of the branch anymore: https://github.com/langchain-ai/langchain/commit/6311c05465c81df26efbdeb95fad3ca215f08ab1
I'm not sure what happened here, could you try rerunning the failing job?


WebFlux: Data Access - Implement Actors DAO

Description:

Implement Functionality

GetAll, GetById, and Find
Reference dalActors.cs in the C# project

Implement Unit Tests

This was completed as part of #114


SEO display hidden pages default not working on Sitemap.aspx

Description of bug
The SEO page has a default option to not include hidden pages in the SiteMap.aspx file. The default option of off is still including these hidden pages in the sitemap.aspx
Steps to reproduce
List the precise steps to reproduce the bug:

Fresh install of DNN
Go to SEO Site Map settings page to confirm that hidden pages should not be included
View the Sitemap.aspx page and review the XML file returned. Hidden pages like http://localhost/Activity-Feed are included in the sitemap.

Expected behavior
If the default option to exclude hidden pages is checked, then these pages should not be shown in the Sitemap.aspx file.
Screenshots
SEO page setting default
https://bfb30d4aa283201c8ae6-fa4f287ec88b082f34d8962c0b5f36f7.ssl.cf2.rackcdn.com/assets/SEO.png
Example Sitemap.aspx return
https://bfb30d4aa283201c8ae6-fa4f287ec88b082f34d8962c0b5f36f7.ssl.cf2.rackcdn.com/assets/sitemap.png
Error information
Provide any error information (console errors, error logs, etc.) related to this bug.
Additional context
Provide any additional context that may be helpful in understanding and/or resolving the bug.
Affected version

[x ] 09.07 RC
[x ] 09.06.02

Affected browser

I have additional details on this that should help in debugging as well as provide a workaround. Since the workaround is easy, it is my very-humble opinion that this is minor and should not hold up the release of 9.07.00 (currently at RC2). These details/steps should make it fairly easy to devise a fix for this.
I am editing this message Fri afternoon 3:30pm US Central Time, so expect revisions to this within the next hour or three...
In brief:
After an install, PortalSettings does not have the 5 records for SiteMap* settings. In this state, Clear Cache and the SiteMap generator do not do their job, you just get a default spew of the 6 or so initial pages.
The workaround is to go to Settings, SEO, Sitemap Settings tab, change any setting under GENERAL SITEMAP SETTINGS and Save (then change it back and hit Save again). This writes the 5 settings to the PortalSettings table and after that, you must go to Settings, Servers and Restart Application (and wait a few seconds). Then everything works as expected.  e.g. change a setting on a page (set Display in Menu to false), go to SiteMap Settings and Clear Cache, then reload SiteMap.aspx and you should see changes and all page (and SiteMap) settings respected in the output.

I have confirmed the work around solves the issue on my production and test installs.

This is still an issue.  Exists in 9.8.

This really should not be closed.

I can confirm it's still an issue in 9.8.0

I'll take this one, just wanting to confirm @jeremy-farrance that after doing the above of saving settings all is good, it is simply the missing values that are the issue?


IUPAC::isValid(out[i]) failed error

On running nanopolish I seem to get following error:
govinda@shannon$ nanopolish eventalign -t 8 --sam -r reads.fa -b reads.sorted.bam -g draft.fa --models nanopolish_models.fofn | samtools view -Sb - | samtools sort -o reads.eventalign.sorted.bam
registering model t.007-base
registering model t.007-ONT
nanopolish: src/common/nanopolish_alphabet.h:173: virtual std::string Alphabet::disambiguate(const string&) const: Assertion `IUPAC::isValid(out[i])' failed.

I did make sure that both reads.fa and draft.fa have all bases in capitals (from issues #67 and #83). Do you know what I must do to get this working?

Hi,
Could you send me draft.fa so I can try to reproduce the problem locally?
Jared

I've attached the file
draft.fa.zip

could you try to grab a stack trace in gdb for me?


Improve UsePython to allow installation versions on-flight

Problem
Currently, UsePython task just switches versions that are pre-cached on image (example).
It works for the most of the use-cases, because image always contains latest patch version for every major.minor pair.
However, some customers prefer to specify exact version of Python and would like to control it by themselves / freeze specific version. Current implementation of UsePython doesn't allow it.
Proposal
Versions of Python can be installed on-flight from https://github.com/actions/python-versions. This repo distributes versions of Python via GH releases. Also it contains versions-manifest.json as an index of versions.
Installation on-flight is pretty quick and should cover those use-cases. Also it is not a breaking change because task will try to download version only in case if it is not found locally.
The same changes were already done for GitHub Actions task setup-python.
Related PRs:

https://github.com/actions/setup-python/pull/85
https://github.com/actions/toolkit/pull/382

This would be very useful for trying out versions of python without waiting for  deployment of a new image.

This would also be really nice for self-hosted agents
For example NuGetToolInstaller@1 will "find, download, and cache a specified version of NuGet." But UsePythonVersion@0 instead has a whole section in the documentation "How can I configure a self-hosted agent to use this task?" which describes a manual process setting up a very specific folder structure, which then needs to be performed again for each new version.

Still valid. Would be nice to have this in place for the Python 3.10 release in October.

Would be nice to have this in place for the Python 3.11 release in October 2022 :)

This feature will be released in the next few weeks in<EMAIL_ADDRESS>

@maxim-lobanov has noticed an error in the current implementation: https://github.com/microsoft/azure-pipelines-tasks/pull/15820#issuecomment-1059761030
We've prepared proposals to fix it, but I'll reopen this ticket for now

@maxim-lobanov has noticed an error in the current implementation: #15820 (comment) We've prepared proposals to fix it, but I'll reopen this ticket for now

@maxim-lobanov / @DaniilShmelev Did https://github.com/microsoft/azure-pipelines-tasks/pull/16217 fix the aforementioned error?

Awaiting confirmation.

Would be nice for confirmation for the Python 3.12 release in October 2023.

Would be nice for confirmation for the Python 3.13 release in October 2024.


Prevent deadlocks when a receiver is recycled

The guidance is to not managed the state of the processor through the message handler. When a receiver needs to be recycled due to an exception when processing a message, a deadlock will happen. CloseAsync calls StopProcessingAsync which waits for the message handler(s) to be completed.
This change removes the explicit await when shutting down.

@phatboyg This does address the deadlock that we saw as part of the investigation on the recent 7.3 discussion (https://github.com/MassTransit/MassTransit/discussions/2987).
I am not well-versed in the recycling implementation to know the best way to implement this while still be able to await the call to Close/StopProcessing. Any insights and guidance would be much appreciated!

I'll look closer, but I'm thinking that this should not be called within a message handler, makes me thing that something is dispatching into an async method that shouldn't.

So what I just changed, was to use Task.Run() to stop the receiver, outside of the receive loop exception handler.


Make file paths shorter to fix windows build

I verified that CI works with this change.
https://github.com/kdy1/turbo-windows-path-length/actions/runs/3889566103/jobs/6638025437

x-ref: https://github.com/vercel/next.js/pull/44760
x-ref: https://github.com/vercel/next.js/actions/runs/3888528533/jobs/6635975573
x-ref: https://github.com/vercel/next.js/actions/runs/3888528533/jobs/6635975680
x-ref: https://github.com/vercel/next.js/actions/runs/3888528533/jobs/6635976658

Maybe we can add some kind of CI check that check the path len for all files against a limit...


switch to c++17

change minimum required compiler to the following

gcc7
clang5

switch to c++17 after ubuntu 16.04 EOL (2021/04)

use newly added features

use from_chars for string to double conversion
replace result_of with invoke_result
add [[nodiscard]] attribute to parser function

gcc7 still lack from_chars for double


License and shared-drive

Hi, two questions:
Can I assume this is under BSD?
Also, Could we get sharred drive support added? If you give me pointers I can do it and push a PR
https://developers.google.com/drive/api/v3/enable-shareddrives?hl=en

License file added in #25 (BSD-2) . It should be references in setup.py, I suppose.
Yes please, do have a stab. I don't know much about shared drives, but I wouldn't expect it to be too tricky. You'd need to decide where there show up - the interface can already list drives (.drives property).


Success message

Please replace default Webflow submission success message to:
"Thanks! We'll be in touch soon."

Reported by: Adrien<EMAIL_ADDRESS>Source URL: https://na13-prezzee.webflow.io/en-us/contact
Issue details: Open in Marker.io
Device typedesktopBrowserChrome <IP_ADDRESS>Screen Size1728 x 1117OSOS X 15.0.1Viewport Size1728 x 992Pixel Ratio@2x

🤖 Marker.io bot - This issue was marked as ✅ Resolved in Marker.io


Different colors for string literals and method calls

First of all, I'd like to say that this theme is looking great! Keep up the good work!
My issue is that after using for a couple of days, I noticed that the fact that the string literals and method calls have the same greenish color can hinder readability, especially when string literals are passed as arguments to method calls.
Take a look at the below example, and notice that the method calls addAttribute and getValue have the same color as their  string literal arguments:

For comparison, this is how the same look like using the theme One Dark Vivid (notice that the colors are different):

Or when using the built-in theme Darcula:

Or when using the built-in theme IntelliJ Light:

Notice that in all of the other examples, the method calls and the string literals are colored differently.
Also note that in the theme Gruvbox Material Dark in Visual Studio Code also uses different colors:

@Vincent-P If you'd like, I can experiment with some colors and come back with a concrete proposal in the form of a pull request.

Sorry for the late answer, feel free to experiment!
I'll gladly merge any PR you have.

I personally really like how builtin themes handle this so I will try to do that in the next update.

With https://github.com/Vincent-P/gruvbox-intellij-theme/commit/110d50128f565de2e653383cd1e5feeb2882bbfb functions and method calls have no special colors like built-in themes.


STM32F7 Support

Hello,
I hope to know whether stlink can support STM32F7 discovery board?
I will get such board soon so I ask the question in advance.
Thanks
Best Regards

We added support for the STMF7 Discovery board a few weeks ago and I have used it to both flash the board from st-flash and debug and also flash from gdb using st-util.

Thanks, Mlu!


⚠ Processors has degraded performance

In e5a6078, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 45 ms

Resolved: Processors performance has improved in 8c2a47a.


ipam: add BelongsToPodCIDR method

Description
Adds an IPAM method to check if an IP belongs to the pod CIDR of the cluster. This is part of the address translation for the broker (see eg, https://github.com/liqotech/liqo/pull/840/files#diff-a53f831375f6d9f64b7bebc612fd9b0c20a98bfc434334944ce72dbaf6082f00R411).
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

[x] Unit tests

/test

/test

/test

/rebase test=true

/merge


Mocks for web app, including file view concepts

Here's some concept work for a web app version of nteract, including some different views on the content underneath. See the file view on this PR to see the PNGs exported from the Sketch.

This looks really cool, I am so excited for this work.


Make compatible with enzyme v3

to: @ayrton
This PR updates chai-enzyme to be compatible with the soon-to-be-released Enzyme 3.0. There were a couple of things being used in chai-enzyme that were "private" from enzyme, but you can use public APIs to achieve the same result. Most everything else should not break any of chai-enzyme's functionality.
The one caveat is that enzyme v3 pulls in the new 1.x version of cheerio, which appears to break a handful of the render tests in this repo.  I don't have a ton of context around 1) what changed in cheerio from 0.x => 1.x and 2) how chai and this repo really work, so I was really struggling on getting these tests to pass. I was hoping I could get a bit of guidance here.

@jugglinmike, any idea on these cheerio test failures and how to fix them?

@lelandrichardson Any chance you could kill that semi colon to get this merged? 😄

@cameronroe i'd be happy to, but that's not what's limiting this PR. All of the cheerio tests are failing.

@lelandrichardson Which build are you looking at? https://travis-ci.org/producthunt/chai-enzyme/jobs/276724493#L984

Closing in favour of #198 which is in a near finished state. Thanks for your contribution @lelandrichardson


get_cookies via Selenium for Edge

创建解决方案：
1：无需用户输入即可从edge获取cookie
2：通过selenium处理验证码
现在，这是我创建的（正在进行中）用于抓取 bing 聊天 cookie 的文件。
如果用户未登录 bing，我需要使用 QT 弹出窗口来应急
另外，我需要添加验证码处理程序。 现在，我希望用户不必自己抓取 cookies.json。
使用示例：
添加到 Cooking_checker.py 一个按钮：
creating a solution for:
1: get cookies without user input from edge
2: captcha handling via selenium
right now, this is a file Ive created (in progress) for grabbing bing chat cookies.
I need a contingency with QT popup if the user isnt logged into bing
also, I need to add the captcha handler. Right now, I want the user to be able to not have to grab cookies.json themselves.
before I continue, I wanted to get your thoughts
example of usage at bottom.
work in progressfile:
import time
# selenium 3
from selenium import webdriver
from webdriver_manager.microsoft import EdgeChromiumDriverManager
import jsons
from pathlib import Path

def hack_cookies(jfile):

    driver_path = EdgeChromiumDriverManager().install()
    driver = webdriver.Edge()
    driver.minimize_window()
    # Download the Edge driver
    # Create a new Edge browser instance in hidden mode
    # Navigate to the Bing chatbot
    driver.get("https://www.bing.com/chat/")
    # Export the browser cookies
    cookies = jsons.dumps(driver.get_cookies())
    print(cookies)
    with open(jfile, "w", encoding="utf-8", errors="ignore") as f:
        f.write(cookies)
    # Close the browser
    driver.close()

def get_cookies_loop(jfile):
    x = 0
    cookies = False
    while x < 2 and not cookies:
        x+=1
        try:
            hack_cookies(jfile)
        except Exception as e:
            print(str(e))
        if cookies:
            x = 3
            break

if __name__ == "__main__":
    get_cookies_loop(Path("cookies.json"))

considerations, 1) adding to cooking_checker.py a button:
        self.open_cookie_button = QPushButton('Open another cookies.json')
        self.generate_cookie_button = QPushButton('Generate cookies.json')
        self.open_cookie_button.clicked.connect(self.open_cookie)
        self.generate_cookie_button.clicked.connect(self.generate_cookie)
        asyncio.ensure_future(self.check_cookie('cookies.json'))

    def generate_cookie(self):
        get_cookies_loop(Path('cookies.json'))

consideration, 2) in main.py line 412:
        try:
            cookie_path = pathlib.Path('cookies.json')
            cookies = None
            if cookie_path.exists():
                cookies = json.loads(cookie_path.read_text(encoding='utf-8'))
            chatbot = await Chatbot.create(cookies=cookies, proxy=proxy if proxy != "" else None)
        except Exception as e:
            get_cookies_loop(cookie_path)
            traceback.print_exc()
            QErrorMessage(self).showMessage(str(e))
            self.update_status_text('Error: ' + str(e))
            self.set_responding(False)

I appreciate your contribution very much! Please take your time and let me know when you finish the work.

I appreciate your contribution very much! Please take your time and let me know when you finish the work.

great, I wanted to give you a heads up first. Ill make it headless as well. Are you already working on a solution to the Captcha process or should I add that as well?

I appreciate your contribution very much! Please take your time and let me know when you finish the work.

from selenium.webdriver.common.by import By
from selenium import webdriver
from webdriver_manager.microsoft import EdgeChromiumDriverManager
import jsons
from pathlib import Path
import time

options = webdriver.EdgeOptions()

def grab_cookies(json_file, url):
    options.add_argument("--headless")
    driver = EdgeChromiumDriverManager().install()
    driver = webdriver.Edge(options=options)
    cookies = None
    driver.get(url) # "https://www.bing.com/chat/"
    time.sleep(5)
    try:
        try_click_elements(driver)
    except Exception as e:
        print(str(f"{e}\n\nUnable to find chat button. Attempting to export cookies.\n"))
    cookies = jsons.dumps(driver.get_cookies()) # Personally, I use jsons but this can be changed
    with open(json_file, "w", encoding="utf-8", errors="ignore") as f:
        f.write(cookies)
        print(cookies) # Verbose print, can be removed
    driver.close()
    return cookies

def try_click_elements(driver):
    xpath = '//button[@id="bnp_btn_accept"]'
    driver.find_element(By.XPATH, xpath).click()
    time.sleep(2)
    xpath = '//a[@id="codexPrimaryButton"]'
    driver.find_element(By.XPATH, xpath).click()
    if path is None:
        path = Path("./bing_cookies__default.json")
    # Double underscore ensures this file is first when sorted

def get_cookies_loop(json_file, url):
    attempts = 0
    while attempts < 2:
        attempts += 1
        try:
            cookies = grab_cookies(json_file, url)
            if cookies != None:
                # Break the loop if cookies are successfully grabbed
                return cookies
        except Exception as e:
            print(str(e))

if __name__ == "__main__":
    # Start the loop to grab cookies and save them to "cookies.json"
    get_cookies_loop(Path("cookies.json"), "https://www.bing.com/chat/")


Manifest URL

The manifest URL is not working. :(

Oops, I forgot to do the 1.0.3 release.
Try this new 1.0.4 release!


Improved Travis CI config

Hi! I have improved Travis CI configuration file:

Added the latest versions of Golang for the test;
Added the latest development version of Golang with allowed failures;

It might be helpful with finding bugs with compatibility with newer versions of Golang.

Thanks!


Compiler doesn't produce pdb files with DebugType=full and latest SDK

Consider an SDK-based project targeting net451 with full DebugType switch. After some recent update I found that no pdb file is produced when I compile the project. No relevant changes has been made to the project so I think it may be something to do with the compiler bundled in the SDK.
A part of the project file:
<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFramework>net451</TargetFramework>
    <DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
    <RootNamespace>JetBrains.ReSharper.Plugins.FSharp.Common</RootNamespace>
    <AssemblyName>JetBrains.ReSharper.Plugins.FSharp.Common</AssemblyName>
    <DebugType>full</DebugType>
  </PropertyGroup>

<ItemGroup>
    <PackageReference Include="FSharp.Core" Version="4.1.18" />
    ...
  </ItemGroup>

...

Rebuild log: https://gist.github.com/auduchinok/a3ff17dbb830d78d44eb28a24a36250d
$ dotnet build log: https://gist.github.com/auduchinok/3ec2ab25e65f8c34c4e4ac071b99e37e

@auduchinok this is fixed here: https://github.com/Microsoft/visualfsharp/pull/4366

@KevinRansom Yeah, I've seen it. Thank you!


Some Control Type not auto translate when enable auto_translate

Godot version
v4.2.dev2.official [da81ca62a]
System information
window10 64bit
Issue description
I'm create a translate file like this:

And coding like this:

And enable all Control's Auto Translate property:

Then I found some Control Type (Tree, GraphNode) not translated.

Steps to reproduce
/
Minimal reproduction project
NewTest.zip

The translated controls are internal controls of the node. auto_translate only affects the main node, not its internal children.
We should make auto_translate propagate to internal nodes (probably by making it virtual and manually setting it).

@akien-mga The GraphEdit instance is fixed, but the Tree one isn't. Looking into the code, its items aren't taken into account on translation changes.


Provide a hack a script to run make in a Container

What this PR does / why we need it:
This just adds a simple hack/make.sh script to run make directives in a
Docker container.  This means you can run build, test, vet etc on a
repod checked out into any directory on any machine that has Docker.
You aren't required to have a Golang environment or dev environment
setup on your system.
Some may find this useful to simplify the development and test process.
It's not as useful for dev environments because you presumably will need
a proper Go env to do any dev work, but it's a very lightweight and easy
way to provide a testing environment or to generate builds without any
pre-requisites.

/assign flaper87

/approve

/lgtm


About the CUDA and torch version.

What is the required version of CUDA and torch?
I use CUDA12.1 and torch 2.1.2.
I could successfully run the ImageReward, but when I use ReLF to finetune, it raise the error in self.accelerator.backward(loss)
Steps:   0%|                                                                                | 0/100 [00:00<?, ?it/s]Could not load library libcudnn_cnn_train.so.8. Error: /usr/local/cuda-12.1/lib64/libcudnn_cnn_train.so.8: undefined symbol: _ZN5cudnn3cnn34layerNormFwd_execute_internal_implERKNS_7backend11VariantPackEP11CUstream_stRNS0_18LayerNormFwdParamsERKNS1_20NormForwardOperationEmb, version libcudnn_cnn_infer.so.8
RuntimeError: GET was unable to find an engine to execute this computation

How could I solve it?
thx.

CUDA12.1 and torch 2.1.2 satisfy the repo.
If u have the same bug, you should link the libcudnn_cnn_train.so.8. by ln -sf.


Support RimWorld version 1.4

RimWorld just came out with the new Biotech DLC and upgraded the version to 1.4. Zomebieland is still marked as compatible only with 1.3. (Love this mod by the way!)

I am currently testing a 1.4 version. Join my discord and the #zombieland channel and download the pre-release

https://discord.gg/MTpqYcPQd3


Participant specific file access control

Hi!
I would like to propose adding a feature for participant-specific file access control
A while ago I had a call with @lostintangent  and @fubaduba  about my educational use case for Live Share. I'm the guy behind code-workshop-kit which is a tool built on top of Live Share for facilitating remote code workshops.
For context, I use Live Share for my training sessions and I usually have a folder participants in my workspace, in which I automatically scaffold a folder for each of my Live Share participants, which they do the training inside of, with regards to exercises etc.
I remember that I was asked in the call about whether I need to change file access based on specific participants, for example if I don't want students to cheat on exercises by peeking into the code of their peers. I answered that for me it is not important because I mostly teach (young) professionals, who are responsible enough to "peek responsibly" 😉.
However, this changed, as there is now a lot more interest for code-workshop-kit and using Live Share for online education in universities and high schools, and by far the most common question I get from them is: How can I ensure my students don't see each others code and cheat on exercises?
Therefore, I think it would be really cool to add this feature. I would summarize the requirement as:
Live Share should support an option where participants see all files except those inside folders that belong to peers.

Or to make it more generic
Hosts should be able to restrict access to files based on which participant is looking.

Suggestion
I want to do more than just "request a feature", I'm very happy to collaborate and think about some solutions, perhaps even implement them with some help.
I think it makes sense to explore whether .vsls.json can be used to accomplish the use case; it seems like the right place in terms of "purpose", since it handles file access and visibility.
The basic assumptions for my suggestions are that, under the hood where the config is parsed and applied, we:

Have access to the name of the participant for which we are checking whether or not to show them the file in their file explorer
Have access to the filepath of the file (assuming unix-style paths for simplicity of this issue)

Examples with requirement "participants should see all files except those inside folders of their peers", assuming current user jorenbroekema:

/participants/jorenbroekema/index.html ✔
/participants/lostintangent/index.html ❌ (not inside participants/${currentUser})
/participants/jorenbroekema/secret.p12 ❌(excluded by excludeFiles, even though it is accessible from a participants-access perspective)
/index.html ✔ (not inside peer participants folders so we don't want to restrict)

So let's explore a hypothetical .js config file (.vsls.js or .vsls.config.js or something), where you can get a bit more fine-grained control. This is probably how I would prefer the API to be if I'm only looking at myself.
export default {
    $schema: "http://json.schemastore.org/vsls",
    gitignore: "none",
    fileIsExcluded: (participantName, filePath) => {
      // If the file is outside of the participants folder, show it.
      // If it's inside, only show it if the file is in the folder of the current participant
      // No peeking files from other students! >:)
      if (!filePath.startsWith(`/participants/`) || filePath.startsWith(`/participants/${participantName}`)) {
        return true;
      }
      return false;
    },
    // These rules apply on top and will override the above
    excludeFiles: [
        "*.p12",
        "*.cer",
        "token",
        ".gitignore"
    ],
}

This default export would be loaded by the config loader and it parses fileIsExcluded as a function and calls it with the participant name and the filepath of the file that it needs to consider to be shown or not shown.
I suppose VS Live Share would search for either .vsls.js or .vsls.json and prioritise the former if both are found.
This pattern is inspired by other tools inside the JavaScript ecosystem such as ESLint, standard-version, Prettier, lint-staged, husky and more. E.g. for ESLint you can pass .eslintrc.js or .eslintrc.json and even some others. It uses a priority ordering system in terms of which config it uses when presented with multiple.
In my opinion this is a very nice pattern in terms of dev experience because I can choose the level of control that I need.

So let's go back to JSON again, let's see if we can accomplish the same requirement.
Mostly we need to pass to Live Share where the folder is in which the participant-specific folders live, so for example participants, meaning that inside, we have folders named the same as the participants.
{
    "$schema": "http://json.schemastore.org/vsls",
    "folderWithRestrictedAccessToPeerFolders": "participants",
    "excludeFiles": [
        "*.p12",
    ],
}

Kinda verbose name.. which makes sense because the option is quite use-case specific 😄.
This restricts access to folders inside participants folder. For example, access to participants/jorenbroekema is restricted to user jorenbroekema.
It meets the first requirement but not the second, since it has the specific logic of the JS config suggestion example hard-coded under the hood. However, that's still good enough for my use case I believe 👍.

I think the JS config way is better to give people flexibility and allow them to specify their own participant-specific file access logic. Perhaps there's other use cases where a host may want to build in some custom file access control in their Live Share sessions 😄.
I'm sure there's more ideas, and perhaps you may feel like .vsls.json is not the right place to configure participant-specific file access. So of course, feel free to take a completely different approach or throw some other suggestions here :)! In the end, it doesn't matter much to me how it is implemented, as long as I can somehow handle file access on a per participant basis.

Hey! When we last spoke, I was pretty sure you were going to make this request soon 😁 It makes total sense for your use-case, and I'd definitely love to support it. Most of the team is out on holiday right now, so let us give this some thought, and get back to you.
In the meantime, I think your JS-based config proposal seems pretty compelling, and so I'll think through that a bit further. Thanks again for building such an awesome workshop experience around Live Share!

Hehe yeah I guess it was inevitable ;). Thanks for looking into this and happy holidays of course!

This is an awesome proposal!
I wonder if we'd be better off adding something to the extensibility API where extensions can register themselves as "access controllers," and they would provide a fileIsExcluded callback that Live Share would call.
It's very similar to your proposal, but is potentially more flexible and requires less work on Live Share's side 😊. However, the drawback is that you would have to provide an extension, not just a .vsls.js file, although this doesn't sound like it's an issue for your use-case (and probably most people that need such control need it because of an extension that integrates with Live Share?)

@daytonellwanger Yeah I was thinking the same thing over the weekend 😁 In @jorenbroekema's case, I think an extension will eventually make sense, and since this feature is somewhat domain-specific, I think an extensibility API is a simpler way for us to support this, without adding any complexity for end-users.

So correct me if I'm wrong, the extensibility API, with that you are referring to https://www.npmjs.com/package/vsls where https://github.com/vsls-contrib/whiteboard is an example of a VS Code extension that makes use of this API to hook into Live Share?
And the idea is that you guys would export some kind of callback that I can hook into for deciding whether a file should be accessible at the moment it is requested by a participant? That would definitely be great, and be plenty for me! I fully agree with @lostintangent  that it's simpler this way and not adding any complexity for end users.
I also see the extensibility gives you access to a list of the participants and you can listen to events when they join or leave, this is also great!! Just wondering, do you have any starter resources for creating a VS Code extension that hooks into the live share extensibility API? I'll probably figure things out with the example extensions I find from https://github.com/vsls-contrib/awesome-liveshare though any other resource suggestions are very welcome :)!

The Counter is our "hello world" sample, and then the whiteboard is the next simplest. Both of those show how to use the LS API, and in particular, how to expose custom RPC services. If you have any other questions about specific LS APIs, we might be able to point you at other extensions. Otherwise, feel free to ping us with any questions 😁
As we discussed in our last chat, I'd love to see if we can't drive the participants list from Live Share, and potentially auto-generate new workshop folders when guests join. That way, you wouldn't have to maintain a separate roster file. I also think you could host the "teacher dashboard" as a WebView in VS Code, and potentially streamline the management experience. In general, I'd love to have a "Live Share Workshop" extension, that folks could install and use to run/participant in workspaces 🤗

Yep that's the idea! I want to get to a point to where the host doesn't have to maintain a list of names because it just uses the list of "peers" I believe it's called in the LS API, this + the file access will be a good start of this plugin and then we can, over time, add more to integrate the workshop experience more with live share itself :)

Hey, just checking in, is this still planned for implementation? Is there any way to speed this up? The discussed timelines where aimed around a month or two, so I figured it would be a good time now after 6.5 months to nudge ;).
Also, let me know if I can be of assistance in implementing the feature, I don't know the live share extension source code, not sure where it lives or if it is actually public, I wouldn't mind diving in, I'd need a few pointers though to get going, e.g. where the code lives for file access that interacts with .vsls.json, I assume my proposed feature would use similar functionality already used by .vsls.json but exposing it through the hook we discussed.

Still needed :) I've kinda paused work on code-workshop-kit and have been thinking about a successor of it, this feature would still be quite important in both code-workshop-kit and its successor, for the potential clients I've talked to it was a dealbreaker to not be able to hide file access for participants dynamically (exam-mode is what we nicknamed the feature).

Hey Joren! Unfortunately, this work is not in our current priority list and roadmap. I'm closing it but will keep track of the feedback and rich discussion around this, in case we plan to revisit EDU in more depth later in the year. Thank you!


TypeError: doc.fromHTML is not a function, where to get debug library?

Hello there, I'm trying to use jsPDF to print some html code as if, not the text, but the code working exactly as it's displayed on my website, I tried multiple things, but I kept getting errors and errors. Finally I found a thread in stackoverflow describing the last of the issues I was facing and it provided a debug library for this.
With it, it works perfectly, however I'm a little worried because the library is quite old, back form 2017, I'm wondering where can I get the latest build, the project page here only provides the basic library, which does not have the fromHTML function.

Check #2992


Plotting bug: quantiles button ignores plotly selected curves when toggled

If I select one curve with plotly, and then toggle the "quantiles" button, it shows the quantiles of all curves, instead of only plotting the quantiles of selected curves.

If I later add/remove curves, it add/removes both the line and the quantiles (as expected), although not fixing the other unselected quantiles.

Side question: Wouldn't it be better to have the legend on the side of the plot, instead of below?

Hello,
The quantiles "ghosts" were reported in #301 and there's a proposed fix in #302. I've added a commit in the same PR to take care of the  dataset_selector cohesion.
Thanks

Fixed in #302


fix/functionaltests

based on the repo @lod started I tried to fix conflicts.
zuul might not be happy, though.

@tbugfinder Ping me once green, I will have to do a squash but ideally once you have it in right shape you should split it in several pull-requests, I will bypass CI for those if you do, so we endup with a better change history.

@tbugfinder please rebase or close if it no longer applies.

In fact I will close it because the last changes made to create makes this patch irrelevant. Reopen if needed and ping me on irc to get it reviewed faster.


Update m-lab/access version to use explicit access controller.Paths

This change should fix https://github.com/m-lab/ndt-server/issues/334 by separating the resources used to enforce the TxController on ndt7 download only.
Tested with a pre-build in mlab-sandbox cluster.

This change is

Pull Request Test Coverage Report for Build 1594

14 of 14 (100.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.4%) to 81.864%

Files with Coverage Reduction
New Missed Lines
%

ndt5/c2s/c2s.go
1
74.11%

Totals

Change from base Build 1592:
0.4%

Covered Lines:
1783

Relevant Lines:
2178

💛  - Coveralls


Not working on "native" ADO fields such as Iteration or Area

Hello team,
It would be very useful to be able to use the cascading picklist with Iteration or Area. Example if an item is associated to a specific Area pass (Team) then custom.values displayed are the ones defined for this specific team.
This would be really nice.

Thank you for your suggestion.


Seed Package Issue

https://www.berrycast.com/conversations/ca6fa355-21c5-59e9-9462-63b5d363965b

"note" html resetting fixed
Remove button for individual added Package is not possible

https://www.berrycast.com/conversations/b3b9574e-a850-5f63-84a1-a82ca12f4ca2


Bowser 0.6 from apple app store  cannot see remote video between iOS.

I have downloaded the latest boser 0.6 on two iphone 6s and one iphone 5. I load the page of http://demo.openwebrtc.org:38080.
I have tried to video call each other between ios, but I failed,    I cannot see the remote video frame, and sometimes I am luck I can see one remote video about 5s, then this one remote video didn't update again.
test steps:
1, download bowser 0.6 from apple app store;
2,  load page of http://demo.openwebrtc.org:38080/ in iphone.
3,  join one session and then call  between on iphone 5/6s and iphone 6s ;
Test result:
1, we cannot get remote real video.  sometime we can see about 5s one remote video.

Anybody  has pay attention  to this issus?

I get the same behaviour on between iPhone 6s and iPhone 5s on the same network. This is pretty bad and something we need to fix. Have you tried running NativeDemo recently?

@stefanalund    Sorry, I  never didn't try to run NativeDemo.

@bamboolsu no problem. The reason for asking is that the video rendering solution on Bowser is not always stable, meaning that lack of video sometimes is an rendering issue rather than a problem of not getting the video from A to B. NativeDemo uses a more robust rendering mechanism (based on OpenGL) that does not have those issues.
If you have time to test NativeDemo as well, that would be much appreciated.

@stefanalund   I will try later on NativeDemo.
"The reason for asking is that the video rendering solution on Bowser is not always stable, meaning that lack of video sometimes is an rendering issue rather than a problem of not getting the video from A to B."
Then for this issue,  when can we fix it ?

@bamboolsu overlay rendering makes use of the same (stable) OpenGL rendering.

@stefanalund   Whtat's mean for  "the same (stable) OpenGL rendering" ?
I have download https://github.com/EricssonResearch/openwebrtc-examples/tree/master/ios/NativeDemo and run 'pod update'. then I build the project.
Based on my test result,  I didn't successfully setup video call. and When I call from apple 6s to iphone 5, I got the following error:
"Error!      Error Domain=NSCocoaErrorDomain Code =3840  JSON text didn't start with array or object and option to allow fragments not set..........."

@stefanalund    For this issues, who is fixing it now?   and  when can we fix it?

@bamboolsu are the clients on the same network? If not, what is the setup?

Do you see any changes in Bowser 0.6.1?


Test Integrity: Ensure there are no disk I/O errors after running the test suite.

Check for I/O errors in the kernel dmesg at the end of the test suite. This allows us to ensure that our rig hardware does not have I/O errors.
To simulate a I/O error the following links are useful ->

https://lxadm.com/Using_fault_injection
https://www.kernel.org/doc/Documentation/fault-injection/fault-injection.txt

Fault injection isnt enabled in our builds so simulating this is hard - Pausing for now


Leftover Netwrok Interfaces after scaling down

Version

Karpenter: v0.5.4

Kubernetes: v1.21
Expected Behavior

Scale up and down and Karpenter provisions and cleans up resources correctly.
Actual Behavior

When scaling down there are some Network Interfaces left unattached from removed Pods/Nodes.
Steps to Reproduce the Problem

Deploy Karpenter and demo inflate Deployment. Scale it up and then down to 0. Not always there seems to be leftover Network Interfaces unattached after scaling down.
Resource Specs and Logs

n/a

Hmm -- this looks like it might be an AWS VPC CNI bug. Can you file an issue over there: https://github.com/aws/amazon-vpc-cni-k8s

@mbevc - were you able to file an issue against the VPC CNI? The CNI is responsible for attaching, detaching and deleting ENIs on worker nodes I'm going to resolve this unless there's something else we can help with

Sorry, just opened the issue upstream as well: https://github.com/aws/amazon-vpc-cni-k8s/issues/1825

Thanks for following up. Feel free to reopen if you identify anything remaining in karpenter.


CPU based inference !!!

Can models generated using this repository be deployed on a CPU based environment for inference on new images?
If yes can you provide a link on how it can be done?
Thanks,
Chandan

Currently it is not feasible since we have not implemented CPU ops for RoIAlign/RoIPool.

Thanks for the reply... Any plans of implementing it in the near future??

This is in our long-term plan, but may not be implemented in the near future.

OK thanks


REST Support

Add REST support, so all API requests can be made via REST requests.

With the last commits, the REST server side code should be complete. It only accepts JSON and primarily POST requests, with w few exceptions.

There seems to be a weird problem with the REST Services, as they result in the following error:
RESTEASY002005: Failed executing GET /version: org.jboss.resteasy.plugins.providers.jaxb.JAXBMarshalException: RESTEASY006555: A valid XmlRegistry could not be located.

With the latest commits, where the XmlRootElement was added, CWS seems to work correctly. The requests are logged as having been completed properly. But there is still problems with the Rest Client. Closing this issue for now, and re-opening the Client instead.


README - "Quickstart" instructions front and center?

When I am a developer
  and I have independently decided to try PRESTON
   and I come to the README
     then I want to see Quickstart instructions for installing PRESTON
       at the very top of the README

hey @mjy thanks for your feedback. I took some time to add quickstart instructions to the Preston readme at https://github.com/bio-guoda/preston#quickstart .
Please review and close this issue when the updates are as desired. If not, please suggest additional improvement.

Quickstart was added. Please re-open if you have additional comments / concerns.


refactor(CLI): GetResource => HasResource for clarity

The functionality of GetResource is more accurately defined as HasResource,
since the resource itself was never returned to the caller anyway. It is also
refactored to use the existing get method that it had duplicated, almost
entirely.
Depends on #3511

/test all

/approve

/lgtm


[Kube Downscaler] Create config block and use ConfigMap for it

Hi,
I discovered your Kube Downscaler chart recently and decided to use it.
I'd like to propose something like shown below for configuring downscaler, instead of relying in raw definition of keys in env block:
# values.yaml

config:
  # default empty values to avoid impact in a installations and be backward compatible with previous usage of env block
  defaultUptime: ""
  defaultDowntime: ""
  dowscalePeriod: ""
  namespace:
    activeIn: ""
    inactiveIn: ""

the fields namespace.activeIn and namespace.inactiveIn are inspired in this helm-chart: https://github.com/hahow/kube-downscaler, I found it easy to understand. Those values would be read from a ConfigMap and used in the deployment.
If you approve this idea, I can make a PR.

Sure, PRs welcome 🙂


Outdated documentation

In the topic Device Creation, the following form of creation is instructed:
let (device, mut queues) = {
    Device::new(physical, &Features::none(), &DeviceExtensions::none(),
                [(queue_family, 0.5)].iter().cloned()).expect("failed to create device")
};

However in the topic Compute pipelines it is necessary that the device contains the extension khr_storage_buffer_storage_class, being as follows:
let (device, mut queues) = Device::new(
        physical,
        &Features::none(),
        &DeviceExtensions {
            khr_storage_buffer_storage_class: true,
            ..DeviceExtensions::none()
        },
        [(queue_family, 0.5)].iter().cloned(),
    ).expect("failed to create device");

But this is not reported in the documentation

I see it was fixed here https://github.com/vulkano-rs/vulkano-www/pull/74.

As per the last comment this appears to be resolved.


Google api php client lib latest release(2.9.2) not downloading via composer.

Environment details

OS:Windows
PHP version:7.3
Package name and version:

Using composer  I downloaded Google api php client lib latest version(2.92), but still I am getting 2.9.1 version only. Please resolve my issue.
Thanks!

Google Plz most of the time after release a new version, We cant see the released version in Client.php.
Help us to solve, or at least put some comments in the release notes. We will understand.

The correct version is downloading, we just forgot to update the VERSION constant in Google\Client.
This will be fixed in https://github.com/googleapis/google-api-php-client/pull/2090 when we release v2.10.0


Retrieving the Azure Disk Name

I believe this line in the sample has an error;
$ az disk list --query '[].id | [?contains(@,pvc-faf0f176-8b8d-11e8-923b-deb28c58d242)]' -o tsv
It should have double quotes around the query portion;
$ az disk list --query "[].id | [?contains(@,pvc-faf0f176-8b8d-11e8-923b-deb28c58d242)]" -o tsv

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d1ac572f-c613-71fc-580a-2805b740b793
Version Independent ID: b4aeef15-7b0f-abc7-872e-28051e10d6ca
Content: Dynamically create a Disk volume for multiple pods in Azure Kubernetes Service (AKS)
Content Source: articles/aks/azure-disks-dynamic-pv.md
Service: container-service
GitHub Login: @iainfoulds
Microsoft Alias: iainfou

Thanks for the feedback! We are currently investigating and will update you shortly.

Just for information, I am running this at a command prompt using Windows 10.

That works for me. I did notice another comment about the same problem. I suspect they were using the on prem CLI also. Hopefully this comment will help the next person.

Yes, this isn't so much on-prem vs Cloud Shell, but the type of shell used. We try to write the docs such that they'll work across platforms, but there are some differences in escape characters like this or in line wrapping. Sorry for the problems, but glad you got it working. We're hoping to have a cleaner way to present these differences soon.