Fixed some Swift overlay link errors for Windows

This fixes the following two problems:

Linking fails because the swiftDispatch.obj file contains a /DEFAULTLIB:dispatch.lib directive. The underlying problem here is that the dispatch module map has link "dispatch" lines. That's in general okay but means that the Swift compiler ends up adding a /DEFAULTLIB:dispatch.lib directive to the generated .obj file. I think the simplest solution here is to tell the linker that it should ignore this reference when it builds the final DLL. Alternatively we could create and maintain a copy of the dispatch module map which would be used on Windows to build the dispatch.dll but we would then have to keep this in sync with the regular module map file.

The linker generates tons of warnings because the swiftDispatch.obj file references dispatch_* calls as library imports when we are actually statically linking everything together. To fix this we don't declare the dispatch_* functions as imports while we are building the Swift overlay. That's achieved by defining the __DISPATCH_BUILDING_SWIFT_DISPATCH__ macro.

This makes the Swift overlay mostly link. There is one remaining problem though where the linker spits out this error:
swiftDispatch.o : error LNK2001: unresolved external symbol $SBoWV.
src\dispatch.dll : fatal error LNK1120: 1 unresolved externals
which means that it can't resolve a reference to the witness table for Builtin.NativeObject.
I actually get the same link error when I try to compile a trivial .exe which defines an empty class:
public class TestObject {}
swiftc -o test.exe test.swift
results in:
test.o : error LNK2001: unresolved external symbol $SBoWV.
test.exe : fatal error LNK1120: 1 unresolved externals
So if someone has a good idea what might be wrong here then I'm all ears :)

cc @MadCoder @compnerd

I believe you're running into this issue. It's the last major issue for dynamic linking with Swift on Windows; I'm not sure how far @compnerd got in solving it.
One way to work around this issue in the meantime is to configure Swift to generate static libraries (e.g. no dllimport specifiers and with DLLImport disabled in IRGen), which then will successfully link (provided duplicate symbols are allowed) and run.

@troughton Thanks for the information!

I'm going to close this PR for now.  I believe that the problems here have been addressed, and the changes here no longer apply cleanly.


⚠ BeyondHD has degraded performance

In c1414fb, BeyondHD ($BHD) experienced degraded performance:

HTTP code: 200
Response time: 3921 ms

Resolved: BeyondHD performance has improved in 3cb9830 after 12 minutes.


Add Set.prototype.intersection

Ed.: once all Set methods are in place, I'll make another pass to deduplicate as much code as possible - but not yet.

Looking at the failures, the error.txt file is missing some updates?


Advantages over hoyon/mpv-mpris

Didn't see anything in readme, is there a reason to use this over hoyon/mpv-mpris?
Also why is this not in aur? https://github.com/eNV25/pkgs/blob/master/mpv-mpris2/PKGBUILD

I'm currently not working this actively, because I don't like this implementation and I'm not completely satisfied with the code. I'm currently working a version with C++ and QtCore. I'll finish it and release it next month after I'm finished with Advent of Code 2024.
One advantage is that it doesn't require any system libraries, like glib2 or QtCore.


A way to edit headers for HTTP requests?

Hello, thank you for making this code.  It is the only thing I've found to work on the TTGO T-call.
Is there a way to edit headers for the http requests using the modem.request method?  I need to add a key to my API call.
Thank you!

There is a way but requires some work. You have to edit the code to support the (Sicom proprietary) AT+SHAHEAD command. Something like it is done here (in this case to add support for setting APN username and password): https://github.com/pythings/Drivers/issues/9#issuecomment-825074289
See here for more info about the AT+SHAHEAD command: https://m2msupport.net/m2msupport/atshahead-set-up-http-headers-in-the-simcom-modules/
Disclaimer: haven't tried it!


Set /std:c11 ccflag for Windows in Rust bindings

This PR fixes our Windows issues. This is an alternative to #353.
See #353 for details about the problem. To be brief, if __STDC_VERSION__ isn't defined as c99 or greater, blst will typedef a bool as an int (this check is here btw). There is a bug in bindgen associated with this. MSVC doesn't define __STDC_VERSION__ by default, but we can use the /std flag to set it to c11, which is the earliest version it supports.
Fixes #318.
Fixes #331.
Big thanks to @pawanjay176 & @michaelsproul for identifying this.

Thanks!

@jtraglia @asn-d6 I think this is not a correct fix and causing issues when the toolchain is set to GNU
https://stackoverflow.com/questions/58226545/how-to-switch-between-rust-toolchains
GCC compiler is complaining that /std:c11 is a wrong flag, so I think the flag should be only added when the toolchain is MSVC
https://rust-lang.github.io/rustup/installation/windows.html

Tried to fix the issue by switching the toolchain to x86_64-pc-windows-gnu which seems to be a correct one and the one supported by jemalloc https://github.com/gnzlbg/jemallocator#platform-support

c-kzg bindings from EF complained about the wrong flag specified https://github.com/ethereum/c-kzg-4844/pull/354#issuecomment-1856355981

jemallocator bindings also complained that sh is missing. Since windows doesn't use shell script I think it should be fixed from the bindings as well.

Hey @kaliubuntu0206 👋 I'm okay with only setting it for MSVC, sounds like a mistake on my part. Would you like to make a PR for this? Also worth noting, blst appears to have fixed this problem (https://github.com/supranational/blst/commit/9c87d4a09d6648e933c818118a4418349804ce7f). I don't think we should update blst right now though, since we would prefer to use a stable release.


Support tools to build test net for demo apps

Is your feature request related to a problem? Please describe.
Providing sample application is important for demonstration purpose.
But it is also needed to keep separated such demo app from main framework.
Describe the solution you'd like
We should provide support tool to build test net for specific Ledger platform to work with sample web application build on top of Cactus SDK.
Describe alternatives you've considered
Providing test case on each Cactus components, but it is merely work for unit tests.
Additional context
I am considering to provide solution as docker-compose environment which is  easy to build and run without deep knowledge.

@sfuji822 Is it required in the scope of this issue to have the test nets run multiple nodes or is it okay to have single node test nets?
Just asking because for the integration tests we have single node test nets that you can pull up via code, like this one brings up a Besu test ledger that is then used for ledger testing:
packages/cactus-test-tooling/src/main/typescript/besu/besu-test-ledger.ts
And the limitation of this is that it single node ledger only, so if we need multiple nodes in the test net then it is not a good fit in it's current form (could be improved of course).

I think it is very relevant to us to be able to bootstrap both single node and multiple node test networks. Several features we are developing can be trivially tested with a single node network; but in production, many networks will have multiple nodes, and we want to test those interactions.

@petermetz , I did not any preference on the number of node since my expectation on this feature is simply tasks on trying Cactus at docker-based playground. takeutak or I will submit related PR soon.

@RafaelAPB , thanks for you comment. I like to implement this as minimal set at first, but I also agree with you on the potential needs on tricky configuration and we may extend it after first version.

@sfuji822, you're welcome! Are you planning to extend the test ledger classes, then? It does require new images to implement multi-node networks, is that correct?

Closing as per what was done and described in #240

@sfuji822, you're welcome! Are you planning to extend the test ledger classes, then? It does require new images to implement multi-node networks, is that correct?

@RafaelAPB Now I can answer this (after having seen the PR) This does not use/work with the FabricTestLedger class so we'll have to pick that up in a separate thread/issue.


Typed router.push/router.replace close #5

Codecov Report

Merging #12 into master will decrease coverage by 11.42%.
The diff coverage is 63.63%.

@@             Coverage Diff              @@
##            master      #12       +/-   ##
============================================
- Coverage   100.00%   88.57%   -11.43%
============================================
  Files            6        7        +1
  Lines           59       70       +11
  Branches         2        2
============================================
+ Hits            59       62        +3
- Misses           0        8        +8

Impacted Files
Coverage Δ

src/path.ts
100.00% <ø> (ø)

src/router.ts
11.11% <11.11%> (-88.89%)
:arrow_down:

src/createRoutider.ts
100.00% <100.00%> (ø)

src/index.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7b0584...668e565. Read the comment docs.


Can't accept a folder share unless already logged in

Sharing a folder seems to rely on already being logged in.  This should be fixed.  If you follow a folder-share URL without already being logged in, and choose to accept the folder, you should be prompted to log in at that point.

I wonder if it would be possible to have read-only access to a folder shared by someone else even when you are not logged in. It works for single files, and it is great.

I believe read-only logged out access already works if you share in gallery mode.  Implementing it in the development environment is just a matter of UI work.


MaterialCalendarView.setSelectedDate(Date date) is not working

MaterialCalendarView.setSelectedDate(Date date) is not working, it sets the date to 1970/1/1.
MaterialCalendarView.setSelectedDate(Calendar calendar) works fine.

Sorry about this. I'll get a fix for this released by the end of the day.

Thanks for the quick reply.
By the way, is there any way to change the text color of selected date?

@MinyoungJung you would have to supply a dateTextAppearance which has textColor set as a ColorStateList where you set the android:state_checked color to the custom color. This is a little convoluted and not really documented well. As an example, look at TextAppearance.MaterialCalendarWidget.Date style defined in the library.

Should be resolved in v0.2.2

@dandc87 Thanks, problem solved :+1:


scipy.sparse matrices can not handle sympy multiplication

The scipy.sparse matrix does not seem to support symbolic multiplications that work in numpy and scipy. Consider the following:
>>> from sympy.abc import a
>>> import scipy
>>> import scipy.sparse
>>> import numpy
>>>
>>> scipy.matrix(1) * a
1.0*a
>>> numpy.matrix(1) * a
1.0*a
>>> scipy.sparse.csr_matrix(1) * a
TypeError: unsupported operand type(s) for *: 'csr_matrix' and 'Symbol'
>>> scipy.sparse.csr_matrix(1)[0,0] * a
a

Now, that the others all work and the element-wise multiplication also works, could this be that there is a check that is a bit too stringent or that this multiplication is not working only because scipy.sparse whitelists data types? If so, can this be amended?
Anyway, it would be great if this was working.

The sparse matrices do not support arbitrary Python objects in them.
Extending this requires some nontrivial changes, as supporting that
would needs to account for refcounting etc.

@pv Would this really require that sparse matrices contain arbitrary Python objects? The element-wise multiplication creates a dense np.matrix output, so couldn't matrix multiplication do something similar?

I assume @mschubert wants to use sparse matrices to manipulate Sympy objects. Adding special cases for returning dense outputs is probably not very useful if this is the goal.

The scenario is the following: I have got a sparse coefficients matrix (20k x 20k, about 20k values != 0) that I multiply with a dense sympy matrix (20k x 1).
Thus, if the result returns a dense matrix of size (20k x 1) that would already help in my case, but not necessarily for others.

Matrix multiplication also requires dealing with refcounts of Python
objects (and dispatching to appropriate multiplication ops), so also
that is nontrivial.

Will something be done about this in the near future? I have resorted to converting the sparse matrix to dense before doing sympy multiplication. This works for me because my symbol matrix is small. But it is still an extra detail, and it would be nice if the library handled it. So since you said that this is non-trivial to implement, I am wondering if that means that it won't be done anytime soon.

As usual, features are added when someone works on them and when they
are ready. The information available on this topic including schedule is
written on this page.

Wouldn't it be easier to add a sparse matrix type to SymPy?

It's not clear we'd still want a PR for this. I think it'd be a lot of churn for little benefit. And new features would likely better be targeted at pydata/sparse. Or in this case, to SymPy itself.
Closing - if that's not quite right, then please reopen/comment.


Live Videos spread audio and video

There is a way for download the Live video in a single Mp4 file with audio and video? If not can you suggest me a software and settings for merge the 2 files into a single and fluid Mp4?

I'd like to join this issue, but meanwhile I had found a workaround. @CaliAlec @ilovepalmas
The audio part of the stream, that Instagram gives out as a .mp4 file, basically contains audio in an AAC mp4a audio format. So, renaming the audio file extension into filename.m4a gives us usable audio stream, and without any need to extracting and\or converting it!
After that, by simply using FFmpeg command line we can merge our audio and video together:
ffmpeg -i video.mp4 -i audio.m4a -acodec copy -vcodec copy output.mp4
This process called "muxing". Using these steps I got myself a great video without audio sync issues.
If anyone who reads this doesn't know how to install and use FFmpeg command line, search for How to Use FFmpeg and How to Install FFmpeg


html validation cleanup

Coverage remained the same at 86.088% when pulling acb8bee4b3f32cb8405aa457752f7d3de50e9f24 on peterbe:html-validation-cleanup into 107bbdeb90235182b8d94cd62d54665720bc6a1e on mozilla:master.


[Generators] Fix 'LamAbs' handling in 'fixupTerm_'

Before this PR running
cabal test plutus-ir-test --test-options "--pattern shrinkTermSound --quickcheck-replay=21373"

produces
plutus-ir/test/Driver.hs
  PlutusIR
    Generators.QuickCheck.Tests
      shrinkTermSound: FAIL (0.23s)
        *** Failed! Falsified (after 6 tests and 7 shrinks):
        ty,tm = ( all a5_17. a5_17 -> (all a4_19. a5_17)
        , let
          data (d8_8 :: * -> *) a10_10 | m6_6 where

        in
        /\a5_8 -> \(x13_13 : a5_8) -> /\a4_11 -> x13_13 )
        [ ( ( a5_8 -> (all a4_19. unit)
        , let
          data (d8_8 :: * -> *) a10_10 | m6_6 where

        in
        \(x13_13 : a5_8) -> error {all a4_19. unit} )
        , Error during PIR typechecking:
        Type-level name mismatch at (): d8 is in scope, but a5 having the same Unique 20 is attempted to be referenced ) ]
        Use --quickcheck-replay=21373 to reproduce.

After:
plutus-ir/test/Driver.hs
  PlutusIR
    Generators.QuickCheck.Tests
      shrinkTermSound: OK (0.08s)
        +++ OK, passed 10 tests.

I don't really understand what's going on here, but I'm willing to believe that you've fixed it.
Question: it says
d8 is in scope, but a5 having the same Unique 20 is attempted

In the code that it shows us it has things like
 all a5_17. a5_17 -> (all a4_19. a5_17)

What are the numbers after the underscores? I assumed they were the uniques, but I don't see 20 there anywhere (although it does have a5_8 later, under a /\).

I assumed they were the uniques, but I don't see 20 there anywhere (although it does have a5_8 later, under a /\).

They are uniques, it's just that the type checker performs renaming as a prepass and then we end up seeing the wrong uniques in the error message. In Zonk the renamer would allow the caller to unrename the thing back, which would allow us to get the original uniques, but we never bothered implementing anything like that in Plutus. We could simply preserve the old uniques in annotations or whatever, but again we never bothered to.


Feature: Make custom HTTP methods

Hi,
it would be super awesome to be able to create or have custom http verbs (methods) so I can be more flexible with my own storage handler (Storer).
Something like
curl -XOPEN /api/some/route/to/media/file
curl -XBAN /api/some/route/to/bridge/ip
curl -XDELEGATE /api/some/route/to/proxy/zone

can we implement this or any plans to make this happen?

Not really. The whole idea is to abstract the rest layer from the storage layer. Thanks to that you can swap the rest layer for the GraphQL layer with no change on your storage layer.
You can write a custom layer to replace rest and reuse the resource package with the same storers if you want.

I think most REST-APIs tend to be CRUD of CRUDL, like rest-layer.
That means that if you want to DELEGATE a proxy/zone, you do so with a -Xbox PATCH where you e.get. change the state and assign something, and install am appropriate hook.
I don't know what use case you are considering, but if you want custom methods (that perhaps even take parameters), perhaps you want too look into RPC frameworks, e.g. https://capnproto.org/ or http://www.grpc.io/?

yeah I could work with hooks, a custom layer and the like. I just thought it would be far easier to implement new features of my own rest API by defining new http methods and attach the appropriate function to them.
but you both are right, it's not the way rest should be used. in rest terms. that's why your suggestion with grpc makes sense to me.
I can work with queries and/or hooks. thanks guys.


Result

Thank you very much for your contribution to this work.
I follow your way and the final result is very poor, both pre and f1 are zero points, can you guide me？

Did you train the model?

Yes. First I run python run_e2e_span.py --data_dir data/BC5CDR/processed_data/ --model_type bert --model_name_or_path biobert --output_dir output --overwrite_output_dir --overwrite_cache --use_hard_and_random_negative --do_train
Then run python run_e2e_span.py --data_dir data/BC5CDR/processed_data/ --model_type bert --model_name_or_path biobert --output_dir output --use_all_candidates --do_eval.
Then put the generated .csv file in the BC5CDR-AllSpan directory, and then run neleval evaluate -g ./BC5CDR-AllSpan/gold.csv ./BC5CDR-AllSpan/pred.csv -m overlap-maxmax::span+kbid - m strong_all_match
But there is something wrong with the result I got, if I am missing something, can you help me look it up？Thank you very much！

While running the evaluation with --do_eval, you need to provide the path to the trained model in --model_name_or_path argument, which should have been saved in --output_dir at the end of training. Let me know if this helps.

Thank you for your reply！I saved the trained model in the ./out directory according to your method, and then ran python run_e2e_span.py --data_dir data/BC5CDR/processed_data/ --model_type bert --model_name_or_path out --output out -- use_all_candidates --do_eval
Then run neleval evaluate -g ./neleval/BC5CDR-AllSpan/gold.csv ./neleval/BC5CDR-AllSpan/pred.csv -m overlap-maxmax::span+kbid -m strong_all_match. But the results obtained were particularly poor,can you guide me again?

Hey, I am also facing same issue as above. I ran the code as explained above and still getting those issues. Can you tell if the above command is correct or not. Thanks.

@Stubborn-z @atulbunkar  For how many epochs did you run the training? It could be the case that the model is overfitting. Can you try with the --eval_all_checkpoints flag along with the --do_eval during the evaluation? Also, did you look into the tensorboard logs? What does the training loss look like?


Improve error messages

newtag now notifies users of which tags failed to be added
deletetag now notifies users of which tags failed to be deleted
renametag now notifies users of the type of error causing it to fail

LGTM


[10.x] Add forget recursive to Arr class

This PR adds a new method forgetRecursive() to the Arr class, which allows you to remove multiple keys from a multi-dimensional array. Sometimes you don't know what is the path to the key that you want to remove, or you don't want to specify the path to all keys with the same name.
So instead of this
$array = ['name' => 'John', 'password' => 'pass', 'second_level' => ['name' => 'Jane', 'password' => 'pass']];

Arr::forget($array, ['password', 'second_level.password']);

You can use this
$array = ['name' => 'John', 'password' => 'pass', 'second_level' => ['name' => 'Jane', 'password' => 'pass']];

Arr::forgetRecursive($array, 'password');

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


handleMentionTap and else won't works

Is anyone experience with my issue :(
Thanks

It's working when i tap for long time, but still not working for single tap

I solve it, my bad
there is UITapGestureRecognizer in my code.
let tapAnyWhere: UITapGestureRecognizer = UITapGestureRecognizer(target: self, action: #selector(closeKeyboard))
self.view.addGestureRecognizer(tapAnyWhere)

I just remove that line, but i lost hide keyboard feature when screen tap :(

Hi @black-lotus. Know it been a long time but you just need to add:
tapAnyWhere.cancelsTouchesInView = false


Raphael dependency not working

After installing react-raphael, when trying to use it, it does not find the module 'raphael'. I guess this is because it is specified as a 'devDependency' in package.json. It should be specified simply as a dependency instead.  This means that in 'raphael-react' project,  'raphael' module should have been installed using 'npm install --save raphael' instead of '--save-dev'

Yes, you are right ! It is specified as a 'devDependency' in package.json.
Please install 'raphael' in 'raphael-react' project using npm install --save raphael,
or specifying the externals in webpack config file.


Update css-what

This updates css-select to use a version of the transitive dependency css-what that isn't marked as vulnerable: https://www.npmjs.com/advisories/1754
As far as I can tell, the breaking changes don't affect svgo: https://github.com/fb55/css-select/releases

Why do you need to create a new request?
What's wrong with https://github.com/svg/svgo/pull/1485?

Whoops, I didn't check beforehand 🙈


Unregister the device

Hi @EddyVerbruggen, thanks for the plugin once more, your code makes our work much better. A quick question, is it possible to unregister using the plugin itself or do we have to use the pushy API to do so? Using the Rest API only unsubscribe the device from the topics, but it does not delete the device from receiving notifications.
If I uninstall the app and install it again and call getDevicePushToken, it fails. Shouldn't it send me the token again?
Thanks!

Hi!
There's no "unregister" function in the SDK so I guess that's not possible. Like with the REST API it only offers unsubscribes for channels.
Their docs also don't mention it, but do mention to always call "register" when the app starts (because the token may have changed).
I noticed that it may be possible on iOS to run getDevicePushToken before the token is received by the app from the Pushy server, so I've now changed the plugin logic to wait resolving the Promise of getDevicePushToken until it has received the token. That may be the problem you were seeing (although that's not too clear from your issue report). This will be part of 1.1.0 which I will release soon.


"New conversation" (Chat) loading spinner have incorrect size for mobile

EPAM AI DIAL chat version
0.22.0
What happened?
"New conversation" button loading spinner have incorrect size for mobile
Actual result

Expected result

Confidential information

[X] I confirm that do not share any confidential information

verified on staging successfully


exe flagged as malicious

Virustotal results:
https://www.virustotal.com/gui/file/1a67f2684feb7b99f88a7dde3a325d2a9f62b1975cc5154384acb2d7a63db6b2/detection
Could be a false positive but older versions are flagged as well

Weird. The exe is built using PyInstaller, which simply zips up the project with a python distribution and embeds it in an exe (the exe itself is simply a loader that extracts the other files temporarily and runs them). Perhaps there's a real malware that happens to be bundled by PyInstaller, and so these virus scanners will see anything built by PyInstaller and assume it's said malicious file, since they would share the same "loader" program. If I google this I find a few other people discussing similar things with their PyInstaller projects, so it doesn't seem limited to this one.
I've been meaning to include the scripts I use to build the exe, in case someone wants to do that themselves. Perhaps this is a good time.


Adding API key crashes Home Assistant / Supervisor issue

What happened?
Hi!
I just updated to the newest version of Smart Irrigation and wanted to add my API key.
That resulted in a frozen HA.
I tried to shutdown my virtual machine.
But I can't reboot. - Getting error message at startup:
"System in not ready with state: setup"
-> This boot issue can be fixed by the following commands:
supervisor repair
and
supervisor restart
How to reproduce

Download latest integration 2024.6.1
enter API key and click confirm
HA freezes with continues "spinner" -> crash
bebaut of HA ends in "System in not ready with state: setup"

Relevant log output
2024-06-06 10:08:50.001 DEBUG (MainThread) [custom_components.smart_irrigation] calling register start event from init
2024-06-06 10:08:50.033 INFO (MainThread) [custom_components.smart_irrigation] Scheduled auto calculate for 23:00
2024-06-06 10:08:50.033 INFO (MainThread) [custom_components.smart_irrigation] Scheduled auto clear of weatherdata for 23:59
2024-06-06 10:08:50.074 INFO (MainThread) [custom_components.smart_irrigation] Updating weather data for all automatic zones
2024-06-06 10:08:50.074 INFO (MainThread) [custom_components.smart_irrigation] Scheduled auto update time interval for each 1:00:00
2024-06-06 10:08:50.374 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry Smart Irrigation for smart_irrigation
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 594, in async_setup
    result = await component.async_setup_entry(hass, self)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/smart_irrigation/__init__.py", line 139, in async_setup_entry
    await store.set_up_factory_defaults()
  File "/config/custom_components/smart_irrigation/store.py", line 308, in set_up_factory_defaults
    await self.async_factory_default_modules()
  File "/config/custom_components/smart_irrigation/store.py", line 332, in async_factory_default_modules
    inst = m(self.hass, {})
           ^^^^^^^^^^^^^^^^
TypeError: Static.__init__() missing 1 required positional argument: 'config'

Which version are you running?
2024.6.1
Diagnostics file

[X] I have attached a diagnostics file

Additional information
Unfortunately I can't get the diagnostics file. There is not option to download.

should be fixed in v2024.6.3

Any quick hint how to download that version? Can't select it...

I'd avoid the betas and instead download https://github.com/jeroenterheerdt/HAsmartirrigation/blob/master/custom_components/smart_irrigation/OWMClient.py manually and overwrite the file in your install.

I tried option 1 and 2 and both were leading to the same crash.
Currently installed 2024.6.3 ...

go back to the one before 2024.6.1 to see if that helps sorry for the inconvenience

closing as likely fixed in https://github.com/jeroenterheerdt/HAsmartirrigation/releases/tag/v2024.6.11. Feel free re-open create a new issue if not fixed.

Tried 2024.6.12 and it is working now.


docs: Review Developer docs

Description
This PR reviews the development docs related to this new mono repo structure. I realized that some of those docs were outdated. These docs will be revisited in future PRs.
Type of change
(Remember to title the PR according to the type of change)

[ ] Documentation update

How Has This Been Tested
(Please describe the tests that you ran to verify your changes.)

[ ] sphinx-autobuild (read Developer Documentation for more details)

Checklist

[ ] I added relevant documentation
[ ] I followed the style guidelines of this project
[ ] I did a self-review of my code
[ ] I made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I filled out the contributor form (see text above)
[ ] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@nataliaElv @sdiazlor the changes are ready to review.


ETL package on the top of PyODBC

Hi Everyone,
I'm planning on building my own package on the top of PyODBC for performing Data Migration & ETL. But before I start this project I just want to ask if anyone knows any python ETL tool package that is built on the top of pyodbc? Or is pyodbc alone capable of doing this?

check for petl package.
https://pypi.org/project/petl/


Update ERC-1363 to follow EIP-1 recommendation

This PR wants to only update EIP content in order to follow the most updated recommendation from EIP-1.

Some texts have been updated to better explain the ERC-1363 behavior, after years of discussion. No changes in behavior.
Some texts have been moved from abstract or motivation to the dedicated rationale section.
References to EIPs have been moved to the EIP-N format.
Code specification have been indented and commented.
The creation date have been updated with the date of the first issue opening and the first commit into the reference implementation (erroneously it was the date of PR instead).

Former https://github.com/ethereum/EIPs/pull/7877

@SamWilsn moved the PR here.
It still continue fails ci but not for the code added by me.
Is there something I can do to solve that issue?

Still cannot understand how to fix that ci issue.
I've pointed internal links to ./erc-x.md but is still says that required files do not exist.
https://github.com/ethereum/ERCs/actions/runs/6677043725/job/18146675819?pr=31

@vittominacori the CI is still a bit broken from splitting the repositories. Not your fault. We can override the bots.

Final proposals cannot be edited, apart from errata (like the created date) or adding clarifications that don't change the behaviour of the standard. This pull request is changing a lot. Too much really.
If you'd like to update to the latest formatting guidelines, do that in a separate pull request from any content changes. If you do want to make any content changes (errata or clarifications), keep them as small and simple as possible.
For my own sanity, I'm going to be closing pull requests aggressively on this repository. Please don't take that to mean we don't value your contribution. Always feel free to re-open a pull request if you think it has been closed prematurely. Thanks!

Ok thanks. I know it could seem that the whole EIP was changed but the most are changes required by validator.
I will change one section at a time and PR also if it won't pass the CI (to pass I must edit all the sections again).


Wrong timing on first output of clock divider?

Output 1 from the clock divider seems to be divided by 16 when it should be the same rate as the clock.

This is intended; it is active on the first tick of the clock. If there is no reset input it will trigger after the 16th step/division. This was added way before the input override so there was no need to copy the clock.

There is a reason to want a divide by 1 output in a clock divider: So that it is subject to the same 1 sample delay of all the other outputs.  This normally doesn't matter, except for the specific use case that @jeremywen and I are looking for:  doing logic operations on clocks.

At any rate having an output on a clock divider labeled '1' producing the same output as the one labeled '16' doesn't make any sense.


[Dynamic Regions] resolved ts blocked after region merge

Bug Report

What version of TiKV are you using?

[2023/08/15 03:03:02.893 +00:00] [INFO] [lib.rs:93] ["Git Commit Hash:   09239a7ca87b592f01454686bad1a084bd067546"]
What operating system and CPU are you using?

Steps to reproduce

execute flashback during pitr
What did you expect?
pitr run normally ,flashback run normally
What did happened?
2023-08-15T06:41:35.501Z        FATAL   ./main.go:119   Br PiTR FLASHBACK DDL Comp failed       {"error": "Error 1105: cannot set flashback
 timestamp after min-resolved-ts(2023-08-15 04:20:59.992 +0000 UTC)", "errorVerbose": "Error 1105: cannot set flashback timestamp after min
-resolved-ts(2023-08-15 04:20:59.992 +0000<EMAIL_ADDRESS><EMAIL_ADDRESS>go:15\ngithub.com/pingcap/test-infra/caselib/pkg/steps.(*executeSqlStatements).Execute\n\tgithub.com/pingcap/test-infra/caselib/pkg/steps/d
atabase.go:367\ngithub.com/pingcap/test-infra/caselib/pkg/steps.(*Serial).Execute\n\tgithub.com/pingcap/test-infra/caselib/pkg/steps/step.g
o:31\nmain.main\n\t./main.go:118\nruntime.main\n\truntime/proc.go:250\nruntime.goexit\n\truntime/asm_amd64.s:1594"}
main.main

tikv0.log.gz

tikv1.log.gz

tikv2.log.gz

It's likely dup with https://github.com/tikv/tikv/issues/15198

@seiya-annie  Please use latest master to verify. The merge issue should be fixed.

Duplicate of #15258


Add mypy.ini

This PR fixes the following mypy error that happens when the available Polars version doesn't have polars.utils.udfs.
test/__init__.py:16: error: Cannot find implementation or library stub for module named "polars.utils.udfs"  [import-not-found]
test/__init__.py:16: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 1 error in 1 file (checked 5 source files)

thanks @apcamargo for your PR! I think not everyone uses mypy.ini and we shouldn't enforce it
can we just type: ignore that particular line?

closing in favour of #12


Adjustments to the Daily Pop up

Is it possible to make it such that the daily pop can be dragged from anywhere?
Currently, I am only able to drag the daily pop up when the title bar of the pop up is visible. However, when I increase the size of the daily pop up, sometimes the title bar goes outside the view of the window (especially, when the window (PWA) is not in full screen mode. It also happens with using Roam directly in Chrome). Resultantly, I am unable to drag the pop up. I currently just re-size and then move it around. However, this doesn’t work all the time.
Therefore, it would be nice if we could drag and drop the pop up from anywhere.

Roam42 Issue Log Audit - Not sure if possible with jsPanel


add impactive models and fix dbt extractor

Here's the dbt after running:
  Format exported Airbyte dbt to CTA structure

and choosing impactive and utils/config/ as the location of the extracted dbt

and choosing impactive and utils/config/ as the location of the extracted dbt

Is this operating as intended? Looks like the new Impactive dbt files ended up in dbt-cta/impactive/models (which is where they should ultimately end up) - did you move the files there by hand?

Can we please modify the script so that the filenames for the CTA base models (in 1_cta_*) have the _base suffix?

Ope, I see now that this is a separate option one can select when firing up the script, APPEND_BASE_TO_FILES. Not a big deal, would be cute to automatically run that after extracting the dbt, but not a blocker to merging this in... thus I approve

@emily-flambe I didn't do anything by hand, I just chose the options that Jesus had already put together. This was ultimately just subbing out the actual extraction piece.
I don't think that changing the options for the script are in-scope here, I wasn't intending to touch any of the other script features that already exist. Just getting it to parity.

Lol ok @emily-flambe I can see why you were asking about where the files went. This was deleting them:
https://github.com/community-tech-alliance/dbt-cta/pull/252/files#diff-7107c0b9edf473b2867bdfdb196193ccdf2d9644c28d35acacc554bfc9409c81L19
Whoops.


Should navigations be made more explicit?

I attempted to use the Recorder to achieve the following:

Navigate to pptr.dev
Enter in a search term ("screenshot")
In the results page, click on the word "selector"
Be navigated to the MDN page for CSS selectors

The recorder was able to do great at steps 1-3. It was not able to capture that a navigation from the results page occurred in the script generated. This may make future debugging of scripts trickier.
Script:
const {open, click, type, submit} = require('./lib/runner.js');
open('https://pptr.dev', {}, async () => {
  await click('aria/searchbox[name="start typing to search..."]');
  await type('aria/searchbox[name="start typing to search..."]', 'screenshot');
  await click('body > search-component > search-results > search-item.selected > search-item-title');
  await click('aria/link[name="selector"]');
});

If I redo the flow and once I get to MDN, continue interacting with the page, it appears to be able to replay events that happen on the MDN page. I was a little surprised here as in other Puppeteer recording projects, there are explicit URLs captured when navigations are performed, whilst Puppeteer's approach to using Aria selectors seems to make this less explicit.
const {open, click, type, submit} = require('./lib/runner.js');
open('https://pptr.dev', {}, async () => {
  await click('aria/searchbox[name="start typing to search..."]');
  await type('aria/searchbox[name="start typing to search..."]', 'screen');
  await click('body > search-component > search-results > search-item.selected');
  await click('body > content-component > pptr-api > content-box:nth-child(7) > api-method:nth-child(79) > ul > li:nth-child(1)');
  await click('aria/link[name="selector"]');
  await click('aria/button[name="Close banner"]');
  await click('aria/link[name="Universal selector"]');
});

I wonder if a good middle-ground here would be generating a comment when navigations to different URLs occur? (e.g `/* Navigated to https://.... */)

The output now includes expectations like:
expect(page.url()).resolves.toBe('https://google.com');

to make these more explicit.


Thanos Metrics across components

Hi Team
I am big fan of Thanos and using it all around in my frim and I wanted to thanks for all the work and craft in making up such an awesome product.
While we speak I am now focused on setting alarms via rules for all the Thanos components can someone route me to metric docs/alarms/dashboard json where I can set dashboard in grafana and creates alerts

@dinesh4747 Thanks for your kind words.
You can find example alert and dashboards definitions under thanos-mixin subproject.
Cheers.

@kakkoyun - Thanks for being humble and I see that in my thanos instance I don't see any metrics like thanos_querier-* and other thanos_objstore_bucket_failures_per_operation metric, Am I missing something here?
I am using thanos version - thanos-0.9.0
Does it require any exporters to be installed and or if I go with latest version then i would automatically start ingestion metrics across the components, any insights would be really helpful

some of the metric names changed over new versions

@dinesh4747 It doesn't require any exporter. I'd say make sure you actually scrape all the components.
And @spencergilbert has a point. Make sure the metrics that you're looking for actually exists in your version.

I ran into a similar thing - ended up just pulling an older version of the mixins at that time :+1:

Thanks @kakkoyun @spencergilbert for the quick response, will double check on scrapping metrics and switch over to latest version as well


torch-sparse can't install with pytorch1.1.0+cuda9.2

📚 Installation

Environment

OS: Ubuntu 18.04
Python version: 3.6
PyTorch version: 1.0
CUDA/cuDNN version: 9.2
GCC version: gcc (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0
How you tried to install PyTorch Geometric and its extensions (pip, source):
I successfully installed pytorch-geometric and all extension with pytorch0.4+cuda9.2. But I want to use pytorch1.0 with cuda9.2. So I first intall pytorch1.1.0 with cuda9.2 from github source, since originally pytorch1.0 can only be installed with cuda9.0.
Then:
$ pip install --verbose --no-cache-dir torch-scatter [succeeded]
$ pip install --verbose --no-cache-dir torch-sparse [failed]
Any other relevant information:

Checklist

[Yes] I followed the installation guide.
[Yes] I cannot find my error message in the FAQ.
[Yes] I set up CUDA correctly and can compile CUDA code via nvcc.
[Yes] I have cloned the repository and tried a manual installation from source.
[No] I do have multiple CUDA versions on my machine.

Additional context
pip install --no-cache-dir torch-sparse
Collecting torch-sparse
Downloading https://files.pythonhosted.org/packages/73/72/e374662f6f47d9ac0e082a6d5c18d14e15c52863e89c6bc6957a0d2ed026/torch_sparse-0.2.4.tar.gz
Requirement already satisfied: scipy in ./anaconda3/envs/torch1.0/lib/python3.6/site-packages (from torch-sparse) (1.2.1)
Requirement already satisfied: numpy>=1.8.2 in ./anaconda3/envs/torch1.0/lib/python3.6/site-packages (from scipy->torch-sparse) (1.16.2)
Installing collected packages: torch-sparse
Running setup.py install for torch-sparse ... error
Complete output from command /home/lingxiao/anaconda3/envs/torch1.0/bin/python -u -c "import setuptools, tokenize;file='/tmp/pip-install-oj5tmie/torch-sparse/setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" install --record /tmp/pip-record-kvljuamw/install-record.txt --single-version-externally-managed --compile:
running install
running build
running build_py
creating build
creating build/lib.linux-x86_64-3.6
creating build/lib.linux-x86_64-3.6/test
copying test/test_coalesce.py -> build/lib.linux-x86_64-3.6/test
copying test/utils.py -> build/lib.linux-x86_64-3.6/test
copying test/test_transpose.py -> build/lib.linux-x86_64-3.6/test
copying test/test_eye.py -> build/lib.linux-x86_64-3.6/test
copying test/test_spspmm.py -> build/lib.linux-x86_64-3.6/test
copying test/test_spmm.py -> build/lib.linux-x86_64-3.6/test
copying test/init.py -> build/lib.linux-x86_64-3.6/test
creating build/lib.linux-x86_64-3.6/torch_sparse
copying torch_sparse/spmm.py -> build/lib.linux-x86_64-3.6/torch_sparse
copying torch_sparse/transpose.py -> build/lib.linux-x86_64-3.6/torch_sparse
copying torch_sparse/coalesce.py -> build/lib.linux-x86_64-3.6/torch_sparse
copying torch_sparse/eye.py -> build/lib.linux-x86_64-3.6/torch_sparse
copying torch_sparse/spspmm.py -> build/lib.linux-x86_64-3.6/torch_sparse
copying torch_sparse/init.py -> build/lib.linux-x86_64-3.6/torch_sparse
creating build/lib.linux-x86_64-3.6/torch_sparse/utils
copying torch_sparse/utils/unique.py -> build/lib.linux-x86_64-3.6/torch_sparse/utils
copying torch_sparse/utils/init.py -> build/lib.linux-x86_64-3.6/torch_sparse/utils
running build_ext
building 'torch_sparse.spspmm_cuda' extension
creating build/temp.linux-x86_64-3.6
creating build/temp.linux-x86_64-3.6/cuda
gcc -pthread -B /home/lingxiao/anaconda3/envs/torch1.0/compiler_compat -Wl,--sysroot=/ -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I/home/lingxiao/anaconda3/envs/torch1.0/lib/python3.6/site-packages/torch/include -I/home/lingxiao/anaconda3/envs/torch1.0/lib/python3.6/site-packages/torch/include/torch/csrc/api/include -I/home/lingxiao/anaconda3/envs/torch1.0/lib/python3.6/site-packages/torch/include/TH -I/home/lingxiao/anaconda3/envs/torch1.0/lib/python3.6/site-packages/torch/include/THC -I/usr/local/cuda/include -I/home/lingxiao/anaconda3/envs/torch1.0/include/python3.6m -c cuda/spspmm.cpp -o build/temp.linux-x86_64-3.6/cuda/spspmm.o -DTORCH_API_INCLUDE_EXTENSION_H -DTORCH_EXTENSION_NAME=spspmm_cuda -D_GLIBCXX_USE_CXX11_ABI=1 -std=c++11
cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
/usr/local/cuda/bin/nvcc -I/home/lingxiao/anaconda3/envs/torch1.0/lib/python3.6/site-packages/torch/include -I/home/lingxiao/anaconda3/envs/torch1.0/lib/python3.6/site-packages/torch/include/torch/csrc/api/include -I/home/lingxiao/anaconda3/envs/torch1.0/lib/python3.6/site-packages/torch/include/TH -I/home/lingxiao/anaconda3/envs/torch1.0/lib/python3.6/site-packages/torch/include/THC -I/usr/local/cuda/include -I/home/lingxiao/anaconda3/envs/torch1.0/include/python3.6m -c cuda/spspmm_kernel.cu -o build/temp.linux-x86_64-3.6/cuda/spspmm_kernel.o -D__CUDA_NO_HALF_OPERATORS_ -D__CUDA_NO_HALF_CONVERSIONS__ -D__CUDA_NO_HALF2_OPERATORS__ --compiler-options '-fPIC' -DTORCH_API_INCLUDE_EXTENSION_H -DTORCH_EXTENSION_NAME=spspmm_cuda -D_GLIBCXX_USE_CXX11_ABI=1 -std=c++11
cuda/spspmm_kernel.cu(78): error: no suitable user-defined conversion from "at::DeprecatedTypeProperties" to "const at::Type" exists
1 error detected in the compilation of "/tmp/tmpxft_00002ac8_00000000-6_spspmm_kernel.cpp1.ii".
error: command '/usr/local/cuda/bin/nvcc' failed with exit status 1

----------------------------------------

Command "/anaconda3/envs/torch1.0/bin/python -u -c "import setuptools, tokenize;file='/tmp/pip-install-_oj5tmie/torch-sparse/setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" install --record /tmp/pip-record-kvljuamw/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /tmp/pip-install-_oj5tmie/torch-sparse/

Thank you for your detailed installation report. This is a very strange error and may be caused by internal ATen changes in PyTorch from v1.0 to v1.1. I generally try my best to keep all packages be installable with the stable PyTorch release, but can not guarantee that everything works smoothly  in current PyTorch master. I suggest you to simple skip the compilation of spspmm_kernel.cu (it is not needed for PyG):

Open setup.py in torch-sparse and remove the line 16-18.
Open torch-sparse/__init__.py and remove line 6 and 20.
Install the package by running: python setup.py install

Hi Matthias it works without spspmm, thank you for help!


Config passing via build options for post-nmt/hangfire refactor

See here for previous discussion.

This change is

Waiting on Matthew to publish the updates to machine and then I can test more properly. I believe buildOptions is being passed appropriately (just as it was in the previous PR).

src/SIL.Machine.AspNetCore/Services/NmtClearMLBuildJobFactory.cs line 46 at r1 (raw file):

                + $"    'shared_file_uri': '{_sharedFileService.GetBaseUri()}',\n"
                + $"    'buildOptions': '''{buildOptions}''',\n"
                + $"    'clearml': True\n"

Just to be clear and say it explicitly - if buildOptions is null, what exactly will happen?  I would think it would be preferable to not pass anything for build options if it is null (not even the arg) to be explicit that there are, in fact, no build options.

src/SIL.Machine.AspNetCore/Services/NmtTrainBuildJob.cs line 70 at r1 (raw file):

                        + $"    'trg_lang': '{ConvertLanguageTag(engine.TargetLanguage)}',\n"
                        + $"    'shared_file_uri': '{_sharedFileService.GetBaseUri()}',\n"
                        + $"    'buildOptions': '''{buildOptions}''',\n"

Same as other comment - shouldn't we just not send the arg buildOptions at all?

src/SIL.Machine.AspNetCore/Services/NmtClearMLBuildJobFactory.cs line 46 at r1 (raw file):

                + $"    'shared_file_uri': '{_sharedFileService.GetBaseUri()}',\n"
                + $"    'buildOptions': '''{buildOptions}''',\n"
                + $"    'clearml': True\n"

Just to be clear and say it explicitly - if buildOptions is null, what exactly will happen? I would think it would be preferable to not pass anything for build options if it is null (not even the arg) to be explicit that there are, in fact, no build options.

I think we ought to pass something because of this - unless you'd like to make a change there. Maybe passing empty braces would be ideal (???). What do you think?

src/SIL.Machine.AspNetCore/Services/NmtClearMLBuildJobFactory.cs line 46 at r1 (raw file):
Previously, Enkidu93 (Eli C. Lowry) wrote…
I think we ought to pass something because of this - unless you'd like to make a change there. Maybe passing empty braces would be ideal (???). What do you think?

Also, to answer your other question, it would currently evaluate to the empty string.

src/SIL.Machine.AspNetCore/Services/NmtClearMLBuildJobFactory.cs line 46 at r1 (raw file):
Previously, Enkidu93 (Eli C. Lowry) wrote…
Also, to answer your other question, it would currently evaluate to the empty string.

But also this: https://github.com/sillsdev/machine.py/blob/adf9bb9e31fc38427b51ccaf97b00872d36920a0/machine/jobs/build_nmt_engine.py#L79.  The default is {}.  Therefore, it is safer to pass nothing, have nothing be recorded in ClearML and have machine.py insert brackets for the default.

src/SIL.Machine.AspNetCore/Services/NmtClearMLBuildJobFactory.cs line 46 at r1 (raw file):
Previously, johnml1135 (John Lambert) wrote…
But also this: https://github.com/sillsdev/machine.py/blob/adf9bb9e31fc38427b51ccaf97b00872d36920a0/machine/jobs/build_nmt_engine.py#L79.  The default is {}.  Therefore, it is safer to pass nothing, have nothing be recorded in ClearML and have machine.py insert brackets for the default.

Oh, true - I see. OK, so remove it altogether? Or null will be fine then? Or will the empty string override the braces?

src/SIL.Machine.AspNetCore/Services/NmtClearMLBuildJobFactory.cs line 46 at r1 (raw file):
Previously, Enkidu93 (Eli C. Lowry) wrote…
Oh, true - I see. OK, so remove it altogether? Or null will be fine then? Or will the empty string override the braces?

I would remove it alltogether.

src/SIL.Machine.AspNetCore/Services/ClearMLHealthCheck.cs line 50 at r3 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
Why was this change made?

While I was debugging the bug that was introduced having to do with ClearML authentication, I edited both CallAsyncs. When I undid those changes, I made them consistent with each other (i.e. with the CallAsync in ClearMLService. See here.) But come to think of it, it's probably the version in ClearMLService that should be changed, correct?

src/SIL.Machine.AspNetCore/Services/ClearMLHealthCheck.cs line 50 at r3 (raw file):
Previously, Enkidu93 (Eli C. Lowry) wrote…
While I was debugging the bug that was introduced having to do with ClearML authentication, I edited both CallAsyncs. When I undid those changes, I made them consistent with each other (i.e. with the CallAsync in ClearMLService. See here.) But come to think of it, it's probably the version in ClearMLService that should be changed, correct?

I just went ahead and passed the token.

@ddaspit I went ahead and passed the token in both places assuming there was no reason not to. Is there anything else that needs to be addressed?


Having trouble using with React

Is there any documentation where i can use it with react.

Could you please elaborate what you are trying to do? Are you trying to use the Released embed in a React component?
Here is a basic example that might help: https://codepen.io/ohoj/pen/bGyWMrY


(Feature Request) Disable Authentication

It would be nice to see a setting in the options to disable authentication in the webUI. I've recently started setting up single sign-on and I would like to put oasis behind it but I can't figure out how to get around the double authentication (SSO, oasis login). Is it possible to disable built-in auth in the config files?

I'd like to have internal fileserver with easy uploading, so I don't need authentication, please make user auth optional.


dependency on outdated polyfill fork

"web-streams-polyfill": "git://github.com/gwicke/web-streams-polyfill#spec_performance_improvements"

The forked spec_performance_improvements branch is incredibly outdated and hasn't been touched in months. The upstream web-streams-polyfill repo that it was forked from is caught up with the massive spec changes since July and would probably make a better dependency.

The project seems quite unmaintained but just for history sake, this will no longer work with git:
See

https://github.com/vercel/vercel/discussions/7586
https://github.blog/2021-09-01-improving-git-protocol-security-github

Example
Arguments: ls-remote --tags --heads git://github.com/gwicke/web-streams-polyfill
fatal: remote error:
The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.


Feature request: serde support

I am using this awesome crate in my actual work to gather some useful information from open chats and bots.
I want to save the data to database or just simple json-string, like

grammers_client::types::chat::Chat
grammers_tl_types::types::Message
etc.

I found this project seems doesn't support serde, am I right? And if it really not support, why? I noticed that telegram has it's own bytecode ser&de function, but serde is the in-facts standard in rust language. Using serde framework will make this project more flexible.

Thanks for reply.
I didn't notice such structure is generated. Is that done by grammers-tl-gen? If so, could you please tell how the crate works?

How often does build.rs run? Is it just a oneshot task? Or does telegram official often change the tl schema?
So is it possible to simply add #[derive(Serialize, Deserialized)] in generated files?

build.rs runs when its crate or the dependencies of its crate change. So changing the api.tl, the generator, or the types package itself, should cause it to re-run.

build.rs runs when its crate or the dependencies of its crate change. So changing the api.tl, the generator, or the types package itself, should cause it to re-run.

telegram official often change the tl schema

Pretty regularly, yes. But grabbing the latest api.tl is a manual task.


Model versions are char strings

model_version_info.version is a string in
> new_model_version = max([model_version_info.version for model_version_info in model_version_infos])
In this case, for example,  max(['8', '9', '10', '11', '12']) returns 9
You should use
> new_model_version = max([int(model_version_info.version) for model_version_info in model_version_infos]) (tested on Python 3.6.2)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cf609d87-073e-f025-0d75-dab33df6b216
Version Independent ID: c0a623a9-28fd-dfb2-4d8d-8050fdc801b3
Content: MLflow Model Registry example - Azure Databricks
Content Source: databricks/applications/mlflow/model-registry-example.md
Service: azure-databricks
GitHub Login: @mamccrea
Microsoft Alias: mamccrea

@gintrona Thanks for the feedback. I have assigned the issue to the content owner to evaluate and update as appropriate.
@mamccrea Can you please take a look at this?

Thanks @gintrona! I've updated the doc. Please allow a few days for the changes to go live.
#please-close


Angular TS client Accept header is "text/plain" when using OAS3

We use NSwag Studio to generate TypeScript clients for our Angular applications.
When we switch from Swagger2 to OAS3 the generated Angular client uses a different Accept header.
Output from Swagger2 definition ("Accept": "application/json"):
let options_ : any = {
  observe: "response",
  responseType: "blob",
  headers: new HttpHeaders({
    "Accept": "application/json"
  })
};

Output from OAS3 definition ("Accept": "text/plain"):
let options_ : any = {
  observe: "response",
  responseType: "blob",
  headers: new HttpHeaders({
    "Accept": "text/plain"
  })
};

The related part of the definition looks of course a bit different, but I don't see a reason why it results in different output.
Swagger2:
  "produces": [
      "text/plain",
      "application/json",
      "text/json"
  ],

OAS3:
  "content": {
    "text/plain": {
      "schema": {
        "type": "array",
        "items": {
          "$ref": "#/components/schemas/Supplier"
        }
      }
    },
    "application/json": {
      "schema": {
        "type": "array",
        "items": {
          "$ref": "#/components/schemas/Supplier"
        }
      }
    },
    "text/json": {
      "schema": {
        "type": "array",
        "items": {
          "$ref": "#/components/schemas/Supplier"
        }
      }
    }
  }

As far as I understand the ASP.NET Core documentation, the Accept header is ignored if the request comes from a browser.
Are there any other side-effects?
Is there a way to configure which Accept header should be used?

It uses the first mime type from the “content” dictionary

Probably it should generate application/json if its a key in “content”

Not sure how it is implemented for Swagger2, but there it doesn't use the first element of "produces". Because as you can see in my sample the first element was also "text/plain".
Anyway, using application/json, if its a key in “content”, would be fine for me.


SOLR-10654: Introduce output of Prometheus metrics for Solr Core registry

https://issues.apache.org/jira/browse/SOLR-10654
Description
Introduce a new Prometheus response writer /solr/admin/metrics?wt=prometheus to output Dropwizards Solr Core registry metrics directly from Solr. Output looks similar to the prometheus exporter. This is only solr.core registry. Other registry planned to be outputted in future PRs.
Output example:
cloud.txt
standalone.txt
Solution
Currently, Solr metrics are collected by Dropwizard and differentiated by metric names. This is an anti-pattern to Prometheus. Manually export Dropwizard Solr core registry metrics to a new SolrPrometheusExporter class to parse out the labels from the metric name and output in a Prometheus readable format for the Prometheus Response writer. The exporter is just temporarily created to export a snapshot of what the current Dropwizard registry is at. These are not held in memory.
The solr.core registry can be categorized by its prefix. The exporter will categorize these metrics and export to prometheus format with labels depending on the category and metric names.
In standalone, all labels include core. In cloud mode, all metrics include core, collection, shard, replica
NOTE: Not all metrics are possible to convert to Prometheus such as Dropwizard string metrics. This is because Prometheus does not support non-numeric types
Tests
Added MetricsHandlerTest, SolrPrometheusExporterTest, TestPrometheusReponseWriter
Checklist
Please review the following and check all that apply:

[x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[x] I have created a Jira issue and added the issue ID to my pull request title.
[x] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
[x] I have developed this patch against the main branch.
[x] I have run ./gradlew check.
[x] I have added tests for my changes.
[ ] I have added documentation for the Reference Guide

Moving this out of draft for review

There are enough additional dependencies that I feel strongly this should be another module.

WDYT?

io.prometheus:prometheus-metrics-config:1.1.0 (1 constraints: 3e164ed8)
io.prometheus:prometheus-metrics-exposition-formats:1.1.0 (1 constraints: 0405f335)
io.prometheus:prometheus-metrics-model:1.1.0 (2 constraints: 411b133b)
io.prometheus:prometheus-metrics-shaded-protobuf:1.1.0 (1 constraints:

No, there are 4 dependencies.  Only the last one concerns me.  Why is protobuf needed at all?  Can it be excluded?  Can any of the others be excluded as well, while you're at it?

io.prometheus:prometheus-metrics-config:1.1.0 (1 constraints: 3e164ed8)
io.prometheus:prometheus-metrics-exposition-formats:1.1.0 (1 constraints: 0405f335)
io.prometheus:prometheus-metrics-model:1.1.0 (2 constraints: 411b133b)
io.prometheus:prometheus-metrics-shaded-protobuf:1.1.0 (1 constraints:

No, there are 4 dependencies. Only the last one concerns me. Why is protobuf needed at all? Can it be excluded? Can any of the others be excluded as well, while you're at it?

Ah ok you were correct. I went ahead and removed the transitive dependencies prometheus-metrics-shaded-protobuf and prometheus-metrics-config so there should now only be 2

@dsmiley or anyone else interested in reviewing. Was curious for more feedback on approach. Is this going in the correct direction or do some disagree if this is correct implementation path towards prometheus in Solr.

Much better. I know I've been a bit picky/detailed but I'm trying to achieve a level of clarity & conciseness here that will end up being repeated for the other metrics.
What do you think the next step should be? Totally completing the core metrics so that you have parity with the default Prometheus Exporter config?

No worries, I'd prefer you be picky than someone in the future seeing this and it makes no sense to them. I would say next steps are to export the other 3 registries solr.jetty, solr.jvm, solr.node and yes getting as close to the prometheus exporters config as possible. Luckily, in my opinion this was the hardest registry (hopefully I was right) and the ground work for this is already in place to do the rest.

What's here looks good to me.  Just need to add more; lots more metrics.  Maybe it'll evolve a little once you add another category.  My interest on this at-work is not the core metrics but all the other ones (Solr, JVM, Jetty).  I'd then be inclined to take this to our Solr fork to kick the tires for real world usage.

What's here looks good to me. Just need to add more; lots more metrics. Maybe it'll evolve a little once you add another category. My interest on this at-work is not the core metrics but all the other ones (Solr, JVM, Jetty). I'd then be inclined to take this to our Solr fork to kick the tires for real world usage.

Thanks. I've been caught up in some other things recently but plan on continuing on the other registries somewhat soon and it shouldn't be as bad to export. Would it be better for me to continue and commit them to this branch, or was this planned to be merged and export the other 3 registries in a separate PR?

It doesn't feel right to merge this PR right now.  Needs docs.  Also the choice of what metrics are done so far is inverted from the value that would make most sense for this whole approach -- OS/JVM/node issues are highest value.

It doesn't feel right to merge this PR right now. Needs docs. Also the choice of what metrics are done so far is inverted from the value that would make most sense for this whole approach -- OS/JVM/node issues are highest value.

@dsmiley Just finished up exporting solr.node solr.jvm and solr.jetty metrics to prometheus and is ready for another round of review whenever you are. I updated the description above and attached files if you want to see what the prometheus output looks like. Last thing I did not finish writing up is docs. I'm assuming the 2 places to update would be the metrics-api section and possibly Monitoring with Prometheus and Grafana?

Added ref-guide documentation on Prometheus endpoint

I'd like to suggest an integration test showing all the output (say to a file) stripped of numbers (to remove brittle/changing stuff) to show that we export what we mean to export. I could imagine someone renaming some metric and then forgetting to update the code here.

Thanks for reviewing again. Added in an integration test with a file stripped of values. Also the unit tests I wrote originally should catch if any changes that happen to the naming of the prometheus metric or labels.
Also thanks for catching missing javadocs. Made sure to add them in for each class and added sample values for what is being exported to prometheus.

I tried this PR locally using the "techproducts" example. I thing I noticed is that the metrics filtering appears to not work, which is a big problem. A test should be added for this, and it should work.
http://localhost:8983/solr/admin/metrics?category=solr.jetty&wt=prometheus

Filtering does work I think the parameter you are looking for is group. Try localhost:8983/solr/admin/metrics?group=jvm&wt=prometheus and you can change it with jetty node core for the corresponding registries
But still you are correct, I should have a test for this. Will add one in.
The only other thing I remember now about this is that regex, key, expr parameters for filtering will not work with this prometheus wt. I did that on purpose because those 3 parameters are for filtering based on the name of the metric while the others are kind of more generic such as registry or type filtering. I didn't think it made sense because prometheus naming is different from the dropwizard naming after exporting. For example: solr\.core\..*:QUERY\..*\.requestTimes:max_ms is not an output of prometheus but to allow expr filtering around that felt odd.
Even then if you need extensive filtering or trying to get some specific metric, maybe the Prometheus Exporter process with a custom config might be the better solution.

Oops; maybe I was hurried.  I'm glad the category works at least!  The other filtering options could be deferred to a future JIRA by matching the prometheus name.  It's a very useful capability; some metrics implemented as gauges are expensive to compute, and others are just excessive output that aren't needed for O(N) for N cores if N is for some users quite high.

Oops; maybe I was hurried. I'm glad the category works at least! The other filtering options could be deferred to a future JIRA by matching the prometheus name. It's a very useful capability; some metrics implemented as gauges are expensive to compute, and others are just excessive output that aren't needed for O(N) for N cores if N is for some users quite high.

Added in a test for the filtering. I'd be happy expand on this and add further filtering feature specific to prometheus after this is ready to be merged.

This is super close now. Can you propose a brief CHANGES.txt under 9.7 "New Features" (I think it's closer to this than an improvement).

Added entry into CHANGES.txt


Adds defaultSidebarWidth to readme

This property is important for rendering the sidebar in a 'docked' state without having it transition or 'pop in' after the page content is rendered.
Example of render without 'defaultSidebarWidth'

Example with 'defaultSidebarWidth=200'

Looks good!


Deprecate use_auth_token

What does this PR do?
This PR deprecates use_auth_token in favor of token

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

I tried to add warning at the beginning of every function/method that used to accept use_auth_token, then only pass token wich occasionally gets assigned use_auth_token's value. This works with transformers and hugingface_hub functions/methods but not diffusers (some still take use_auth_token only)

i added a test (that passes) but some cases still fail, like loading+exporting from a private repo, but it's an issue from optimum side.


[QUESTION] Module Hook?

I'm using this module in a project, and trying to use PyInstaller to turn it into a .exe
When I try compile it, for some reason chat-downloader isn't seen. Apologies for my lack of understanding here - does this module not have a hook that PyInstaller can find? I'm using terms out of my knowledge here, I don't know how it works but 30 minutes of google and stack overflow seems to point to the fact that PyInstaller just doesn't know cha-downloader exists. Any help?

Have you tried it with --collect-data chat_downloader ?


Change the folder structure and build

For now the folder structure following the Golang projects specs.
Changed the makefile build to save the output in build folder.
Updated the gorelease file for building the project into build folder.
Relates: #10

Merged another PR. Could you reintegrate the master @fabiorphp?

Uhm, hate to say it but I did it again. My fault. 😅 Could you reintegrate master a final time. I promise your PR will be merged next. Alternatively, I could also merge directly from CLI if that's more convenient for you.  Changes look good.


Modified SPEC for aarch64_linux

Signed-off-by: Yuehan-Lin<EMAIL_ADDRESS>

@smlambert for review
I modified the SPEC value for openjdk_aarch64_linux into linux_aarch64_cmprssptrs, since corresponding buildspec is enabled in https://github.com/eclipse/openj9/tree/master/buildspecs


pull request for e2e test at 12/02/2016 13:26:09

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Line breaks in XML file

Problem
The XML file provided by the Bundestag contains line breaks that get propagated to the CSV files. These line breaks might create problems for the people using CSV files.
Tests

Libreoffice seems to handle the line breaks well.
To import in Stata, the option bindquote(strict) is needed.
Importing in Excel is challenging. Not only are line breaks creating problems, encoding is also an issue.

Potential solutions

Remove line breaks in CSV files
Add Excel files, which better handle line breaks

This issue has been fixed with the release of v0.2.0.


Incorrectly formats bytes

<EMAIL_ADDRESS>numbro(1000000)
      .format({
        spaceSeparated: true,
        totalLength: 2,
        output: 'byte',
        base: 'binary'
      })

Output:
"1.0 kKiB"
Expected output:
"1 MiB"
Reproduction:
https://runkit.com/timfish/5ed8d491ede291001abed442

@all-contributors please add timfish for bug

thanks for the report :smile:

Also running into this bug, showing 1 kGiB instead of 1 TiB.

ok :smile: things are getting out of hand :smile:


[feature/hpc/ddr] MIG integration

Ingtegrate DDR MIG in HPC flow for Alveo U250.
for CDC refere to item https://github.com/users/MaistoV/projects/3/views/2?pane=issue&itemId=89678656
TODO: decide whether to merge the this task with CDC or not

For this task, the CDC is accomplished by simply using an AXI Clock Converter.
For now, we use one DDR channel, the one nearest to the XDMA (PCIe), to be checked.
For now, we can address only 4 GB of the 16 GB of the single DDR channel (we have just a 32-bit address).


Doesn't build for NetBSD

I installed the stdlib for NetBSD with rustup. nix compilation fails:
src/sys/signal.rs:32:17: 32:32 error: unresolved name `libc::SIGSTKFLT` [E0425]
src/sys/signal.rs:32     SIGSTKFLT = libc::SIGSTKFLT,
                                     ^~~~~~~~~~~~~~~
src/sys/signal.rs:32:17: 32:32 help: run `rustc --explain E0425` to see a detailed explanation
src/sys/signal.rs:47:14: 47:26 error: unresolved name `libc::SIGPWR` [E0425]
src/sys/signal.rs:47     SIGPWR = libc::SIGPWR,
                                  ^~~~~~~~~~~~
src/sys/signal.rs:47:14: 47:26 help: run `rustc --explain E0425` to see a detailed explanation
src/sys/mman.rs:135:38: 135:53 error: unresolved name `libc::MAP_STACK` [E0425]
src/sys/mman.rs:135             const MAP_STACK        = libc::MAP_STACK,
                                                         ^~~~~~~~~~~~~~~
<bitflags macros>:91:1: 93:63 note: in this expansion of bitflags! (defined in <bitflags macros>)
src/sys/mman.rs:125:5: 142:6 note: in this expansion of bitflags! (defined in <bitflags macros>)
src/sys/mman.rs:135:38: 135:53 help: run `rustc --explain E0425` to see a detailed explanation
src/sys/signal.rs:32:17: 32:32 error: constant evaluation error: non-constant path in constant expression [E0080]
src/sys/signal.rs:32     SIGSTKFLT = libc::SIGSTKFLT,
                                     ^~~~~~~~~~~~~~~
src/sys/signal.rs:32:17: 32:32 help: run `rustc --explain E0080` to see a detailed explanation
src/sys/signal.rs:47:14: 47:26 error: constant evaluation error: non-constant path in constant expression [E0080]
src/sys/signal.rs:47     SIGPWR = libc::SIGPWR,
                                  ^~~~~~~~~~~~
src/sys/signal.rs:47:14: 47:26 help: run `rustc --explain E0080` to see a detailed explanation
error: aborting due to 2 previous errors
error: Could not compile `nix`.

To learn more, run the command again with --verbose.

Maybe the CI could also check alternative platforms.

Hi @tbu-, I don't have any NetBSD experience but we would love to have contributions to fix NetBSD (part of that might be contributing changes to libc).  The CI infrastructure is pretty flexible and runs docker containers -- there might be some way to fit into that framework with some changes to support NetBSD (might want to look at what libc does).

Does #389 fix it? In that case we can close the issue.

It does.


update GoalBonded section of Mint.md

over / under

Good eye. Thanks James!

Hmm not sure why this wasn't merged!


Following documentation but using Blazor Server results in Identity.Name being Null

Following the linked document mostly works for Blazor Server however Once logged in,  The Identity.Name is null.
This is a similar issue to #17598 however using the default Blazor server project set it up using
services.AddAuthentication(AzureADB2CDefaults.AuthenticationScheme)                 .AddAzureADB2C(options => Configuration.Bind("AzureAdB2C", options));
and the fixes proposed are about either JWTBearerAuthentication or BearerAuthentication Schemes
The same with the proposed fixed from
https://docs.microsoft.com/en-us/aspnet/core/blazor/security/webassembly/hosted-with-azure-active-directory-b2c?view=aspnetcore-3.1#useridentityname
the standard AuthenticationScheme does not appear to have a TokenValidationParameters
I am very new to AAD B2C, and newer still to Blazor server authentication and have not been able to find a fix so far to suggest unfortunately.
If any additional information is I'm more than happy to help.
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 765e611b-a170-db1a-fa50-2771d79b2732
Version Independent ID: ef34ebdf-977a-b797-e263-cb32c1643272
Content: Cloud authentication with Azure Active Directory B2C in ASP.NET Core
Content Source: aspnetcore/security/authentication/azure-ad-b2c.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @CamSoper
Microsoft Alias: casoper

Noting here @CamSoper that this isn't really a "Blazor Server" issue. It's a general issue pertaining to any ASP.NET Core app. I don't have or recall the config for the name claim that pipes it through of the top of my head (and I'm off today 🏖, so I can't look for it right now). I thought it was the linked example in the WASM doc, but that's apparently not working for @DatenThielt.

I seemed to have found a fix for this, however I am not sure this is the correct process or just a new step that needs to be added.
I checked my B2C_1_SiUpIn applications claims,  And the only item that was selected was Identity Provider  (which I could see was being returned)
As a test I selected Display Name to be returned as well, and that seems to get picked up after logging in now?
Not sure if that's the correct fix however

HA! :smile: lol ..... I was just about to send you this message .............
@DatenThielt Make sure that in your app's signup/signin user flow that you have "Display Name" in the Application claims setting. I fired up my test app here, and that claim worked without any configuration at all in the app. Therefore, I think your problem is that Azure isn't sending it down. Also, you can read out the claims in the app and see if it's there.

Yes, we can close this now. You're good. This setting btw is actually covered in the Azure docs. We try not to carry detailed guidance for these sorts of things over here. We don't have the staffing to do it, and it would be a duplication of what they have over there.

Understood, yep can be closed! thank you!


Change timeout to sane default for long-running action

OMG. Ship this already.

:+1:

I'm still thinking how we could improve that - we have the same constant repeated on two places now which means it's just a matter of time when it will get out of sync again :/


RStudio Cloud

Hi Nam,
I'm facing some issues uploading files into my cloud directory; I receive an error message saying "Unexpected response from server". I've attempted to consult prof google and found tips to use either the wget or curl function, but alas, I am facing issues using them as well. Would appreciate your helP!!

I managed to load the data from PostgreSQL using this code:
install.packages(c('DBI', 'RPostgres')) #installing relevant packages if you haven't already

library(DBI) #calling the necessary packages
library(RPostgres)

con <- DBI::dbConnect(
  RPostgres::Postgres(),
  dbname = 'assignment 1', #input name of DB where the file was uploaded
  host = 'localhost',
  port = 5432,
  user = 'postgres', #input your username (it's probably postgres)
  password = 'Helopanda16!') #lol pls don't hack into my stuff

dbListTables(con) #shows all the different tables which were uploaded in DB
propertylisting <- dbReadTable(con, "propertylistings") #reads the specific table in the DB we want, and converts it into a data frame

Some pretty helpful documentation I referred to:

https://www.rstudio.com/blog/working-with-databases-and-sql-in-rstudio/
https://cran.r-project.org/web/packages/RPostgres/RPostgres.pdf
https://nceas.github.io/oss-lessons/sql-database-access-in-r/sql-database-access-in-r.html

let me know if this works!!

Another easier (in my opinion haha) method is to export the necessary files into a .csv format, then loading them into R!
To export the file (which our group already loaded into a database in DBeaver last week), right click the table > Export > select "CSV" as the Export target > Click next for everything (use the standard settings) > Click finish.
Then upload the .csv file into your working directory in R Studio cloud (in the bottom right box, click upload > Choose file to upload). And then input this code to read in the .csv file:
proplisting <- read.csv("propertylistings_202204011043.csv") #you can name the file sth other than proplisting of course

y

Thanks Shannon, but the second method doesn't work as well :):):) ;((((((

I managed to load the data from PostgreSQL using this code:
install.packages(c('DBI', 'RPostgres')) #installing relevant packages if you haven't already

library(DBI) #calling the necessary packages
library(RPostgres)

con <- DBI::dbConnect(
  RPostgres::Postgres(),
  dbname = 'assignment 1', #input name of DB where the file was uploaded
  host = 'localhost',
  port = 5432,
  user = 'postgres', #input your username (it's probably postgres)
  password = 'Helopanda16!') #lol pls don't hack into my stuff

dbListTables(con) #shows all the different tables which were uploaded in DB
propertylisting <- dbReadTable(con, "propertylistings") #reads the specific table in the DB we want, and converts it into a data frame

Some pretty helpful documentation I referred to:

https://www.rstudio.com/blog/working-with-databases-and-sql-in-rstudio/
https://cran.r-project.org/web/packages/RPostgres/RPostgres.pdf
https://nceas.github.io/oss-lessons/sql-database-access-in-r/sql-database-access-in-r.html

let me know if this works!!

@inesltt sorry for my late reply.
Best is that you can allow me to have a close look into the problem --> I am OK for 30 minutes one-to-one discussion if you still face the issue.
Note that in Rcloud, sometimes the issue is with the server.


Integrate Voice assistant feature on our website

Add voice assistant on the home page which can interact and respond to the user's queries regarding the weather. More query handling can also be seen.

@NoahCardoza kindly assign this issue to @drishtipeshwani and me. Thank You :)


[JS] Bump adaptivecards to 2.6.0

Related Issue
N/A
Description
Repo version is out of sync with npm. Cherry-picking version from release/20.12 back into main.
How Verified
Clean cherry-pick, no conflict
Microsoft Reviewers: Open in CodeFlow

I'll make sure this change gets reflected as part of the 21.01 version update PR (which I'll have up in a bit).

I'll make sure this change gets reflected as part of the 21.01 version update PR (which I'll have up in a bit).


Link Addition

Thanks!
Sincerely,
Nicholas.
On 13 April 2016, at 8:23 pm, Thomas Davis<EMAIL_ADDRESS>wrote:
Merged #21.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub￼


[HOLD for payment 2024-06-13] [$250] Split - Split menu RHP header does not show the updated scanning message

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.73-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:

Go to staging.new.expensify.com
Go to any chat
Submit a scan expense
Submit one more expense if there is only one expense
Go to transaction thread of the scan expense
Note that header shows the updated copy "Receipt scan in progress. Check back later or enter the details now."
Split expense with the same user
Click on the split preview

Expected Result:
The split menu RHP header should follow the same header copy in scan expense transaction thread
Actual Result:
The split menu RHP header does not follow the same header copy in scan expense transaction thread
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/66eeb8a9-40c2-4eeb-9d0d-1d0b72435ff6
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012fbf011aa919798f
Upwork Job ID:<PHONE_NUMBER>670882304
Last Price Increase: 2024-05-13
Automatic offers:

nkdengineer | Contributor | 0

Issue OwnerCurrent Issue Owner: @anmurali

@tgolen  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-split

@tgolen can you determine if this is something from the API or not? if not can you remove the DeployBlocker label?

Proposal
Please re-state the problem that we are trying to solve in this issue.
The split menu RHP header does not follow the same header copy in scan expense transaction thread
What is the root cause of that problem?
Here https://github.com/Expensify/App/blob/97097ff13b086c3d44d26d44335921323b211669/src/pages/iou/SplitBillDetailsPage.tsx#L104 we still use the outdated copy for scanning
What changes do you think we should make in order to solve the problem?

Here https://github.com/Expensify/App/blob/97097ff13b086c3d44d26d44335921323b211669/src/pages/iou/SplitBillDetailsPage.tsx#L104 we should use receiptScanInProgressDescription instead to be consistent
What alternative solutions did you explore? (Optional)
NA

Proposal
Please re-state the problem that we are trying to solve in this issue.
The split menu RHP header does not follow the same header copy in scan expense transaction thread
What is the root cause of that problem?
Here https://github.com/Expensify/App/blob/97097ff13b086c3d44d26d44335921323b211669/src/pages/iou/SplitBillDetailsPage.tsx#L104 we still use the outdated copy for scanning.
We made the UI update here, but we didn't update it for SplitBillDetailsPage.
What changes do you think we should make in order to solve the problem?

Here https://github.com/Expensify/App/blob/97097ff13b086c3d44d26d44335921323b211669/src/pages/iou/SplitBillDetailsPage.tsx#L104 we should use translate('iou.receiptScanInProgressDescription') instead to be consistent
We can update the title to use Icon too, like we did with the MoneyRequestHeader here
What alternative solutions did you explore? (Optional)
NA

Nope it's not a regression, the UI of SplitBillDetailsPage has always been that way. It's just another part we need to update to be consistent.

This does not sound like a bug. I think it is a design inconsistency but I do think it is worth fixing. Let's reuse the Receipt scan in progress. Check back later or enter the details now. language in both places.

Taking over!

Since this is a relatively straight forward change, we can go with @nkdengineer's proposal.
🎀 👀 🎀 C+ reviewed

@allroundexperts  this PR is ready for preview

@nkdengineer is paid. Waiting for @allroundexperts to complete the BZ checklist to approve his payment via ND

On the checklist now!

Checklist

I wasn't able to point to a single PR that caused this. It seems like this was the case since the beginning.
N/A
N/A
A regression test should be helpful here. The steps given in the OP are straightforward and can be used to create a regression test.

Payment summary approved

[x] @nkdengineer $250 on upwork
[ ] @allroundexperts $250 on ND

$250 approved for @allroundexperts


Add List Champions interviews page

It is exactly same as this issue:
https://github.com/manwar/theweeklychallenge/issues/163
but for list chanpions interviews.
For prototype, it would literally copy the same page.
Ideally we would have tiles with photo of champion, and clicking the tile would take to the interview page.

I would like to work on this issue as well...🚀


Actually returning encoded object instead of python object

Coverage decreased (-0.29%) to 78.25% when pulling 8c83d498a2875187189a4427ba61732d48f8c6f1 on serializer into fc306ee4a8cea98863156fa1cfb4dad2bb7068eb on master.

Coverage decreased (-0.29%) to 78.25% when pulling 8c83d498a2875187189a4427ba61732d48f8c6f1 on serializer into fc306ee4a8cea98863156fa1cfb4dad2bb7068eb on master.


(COURSE): Added the marathi langauge courses markdown file

What does this PR do?
Added free courses to the Marathi language playlists on youtube
For resources
YouTube
Description
Added some good playlists links to programming languages such as html,css, angular,python etc in marathi language
Why is this valuable (or not)?
Yes This is valuable as the marathi language courses was not added before and this is the new pr
How do we know it's really free?
You can test the links
For book lists, is it a book? For course lists, is it a course? etc.
It is a markdown file for courses
Checklist:

[ ✓] Read our contributing guidelines.
[ ✓] Search for duplicates.
[ ✓] Include author(s) and platform where appropriate.
[ ✓] Put lists in alphabetical order, correct spacing.
[ ✓] Add needed indications (PDF, access notes, under construction).
[✓ ] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

@eshellman please review this

@eshellman also please review the code of conduct

it is very difficult for the reviewers if you close the PR where the review comments have been made. Please use separate branches and separate PRs for the course list and the code of conduct, as different reviews are needed for each. Please remove code of conduct from this PR and create a fresh branch for it.

@eshellman mb. I will make sure next time

@eshellman  Is this okay?

Thank you!


Updated dead sample link

I would link to a specifick sample where options are actually being updated instead of the generic samples link. Now people still need to search through examples before they find one where options are updated

I like the Line Chart Datasets sample because it shows two update options.


ci: added workflow to verify artifacthub tags

CI workflow to verify cncf and official tags in artifacthub gadget configurations.
fixes #3604
Usage
This checks whether both the cncf and official tags are present and set to true.
The trigger events would be manual trigger via workflow_dispatch, a push event that affects any file in the gadgets directory, and a pull_request event that modifies files in the gadgets directory.
Testing done
successful run
fail run
run with zero gadgets

After following we can merge this:

Finalize the triggers (workflow_dispatch and schedule)
Sign the DCO e.g. by using git commit --amend --no-edit -s


add SPDX license identifier in pyproject.toml

:tada: This issue has been resolved in version 0.0.4 :tada:
The release is available on:

v0.0.4
GitHub release

Your semantic-release bot :package::rocket:


Failure to load model in Jupyter

Cool package! I was eager to see how it works with Shiny via shinywidgets, but it seems something in my Python environment is off. I get the following JS error when trying to render the Widget in Jupyter:

And here is more info about that error:

Happy to offer any more information you think might be relevant (or even pair on it, if you'd like)

This error usually comes up with widgets if you %pip or !pip install anywidget for the first time in a running jupyter environment. Please try shutting down the Jupyter server and restarting (not just restarting the kernel).

Hard to know for sure if this is the issue (expanding the Error: Script error for "anywidget" might provide more context).

I still get the same error after shutting down the server -- maybe it's because I have an old version of the notebook?
$ jupyter notebook --version
6.5.2

Good news though -- it does work with JupyterLab:
$ jupyter lab --version
3.5.3

And also the Python kernel that I'm using is 3.12.

Oh interesting, thanks for sharing. I'll have a look.

Can you share how you made the Python environment and the version of Python?

Closing as I haven't been able to reproduce. Please let me know if after creating a fresh environment you still have troubles!


Feature: binded binding

Sorry for a bit confusing title.
Feature is related to declarative combining of various elements together.
Hot it works for me now:
<template is="dom-bind">

One Two Three

    <button bind="[[modal]]" action="open" is="cs-button" type="button">Button</button>
</template>

In example above modal.open will be called on button click.
What I'd like to have is following:
<template is="dom-bind">

One Two Three

    <button on-tap="modal~open" type="button">Button</button>
</template>

or another way binding to arbitrary property:
<template is="dom-bind">

One Two Three

    <button action="[[modal~open]]" is="cs-button" type="button">Button</button>
</template>

modal~open is equivalent to passing modal.open.bind(modal). ~ symbol is taken from LiveScript, which might be familiar to some JavaScript developers and visually shows that open have some binding relation to modal. Also there is no need for special processing in target element, any method can be passes to regular events.

I am not sure if I understand your request correctly, but would #3259 also fix the problem?

It is kind of similar, but in my case it would be more generic and explicit: on-tap="$.ajax~generateRequest" (though, I haven't tried yet if dots are supported here at all, I was originally thinking about not only events listeners, but about generic binding to arbitrary property).
I've also corrected example above to remove brackets in on-tap.
It is not always the case that you have id on that element.
It should works exactly the same way as now, but call .bind(..) to preserve this inside that binded method.


Inclusion of Image compressor

What if this can also include image compressor without lossing quality this will save a lot of space and it could encourage storing small image files in onedrive

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 06e00ed6-a50f-1bf1-af7b-81879cb0338e
Version Independent ID: 7209e902-f8ec-2f25-a0e5-d557e6e18687
Content: Microsoft PowerToys
Content Source: hub/powertoys/index.md
Product: dev-environment
Technology: powertoys
GitHub Login: @mattwojo
Microsoft Alias: mattwoj

Hello and thanks for your message. First, this repository is about the documentation. Head over to https://github.com/microsoft/PowerToys/issues and look for an existing issue about this subject.

Hi @Mxcoded. Like @Jay-o-Way says, this feels not so much like feedback specifically about the documentation, but rather like a question, or feedback, about the PowerToys product. I don't have any additional content for your scenario, over and above what's in the documentation. So, it might be worth pursuing this as a question or feedback about the product. If you visit the PowerToys repository, then you'll be able to create an issue to leave product questions/feedback.


Project status

Alpha - awaiting port of StandardAnalyzer and QueryParser of Lucene.Net 4.8.0, as well as releases for .NET 3.5 and 4.0.

I think  StandardAnalyzer and QueryParser of Lucene.Net 4.8.0 are fine now in the latest 4.8 beta package. This might be alpha, but probably not for that reason

Correct, StandardAnalyzer and QueryParser were ported some time ago. However, I also discovered while working on Lucene.Net that bobo-browse never progressed past 4.0.2 because it has been superseded by the facet functionality of Lucene 4.0 (available in .NET as Lucene.Net.Facet).
While there could be a BoboBrowse.Net 4.0.2, it is unlikely that there will be a version after that. Lucene.Net will eventually move on and there won't be a BoboBrowse.Net that supports the latest version anymore. There are also some bug fixes that were committed to bobo-browse that were never released in Java that could be released in .NET. But whether there will be a BoboBrowse.Net 4.0.2 will depend on demand, and so far you are the first who has asked for it.
While I don't have an issue with completing the port, keep in mind that there will never be a version higher than 4.0.2. Eventually Lucene.Net will move on to a higher version that is incompatible with BoboBrowse.Net. Since in the Java world bobo-browse has been superseded by the facet package of lucene, I would recommend following the same upgrade path.

Thanks for your answer. I was already trying with the facets, but didnt get it to work yet. But its good to know that bobobrowse is superseeded, at least I know I have to try harder...


Can you add support for Firefox android?

Is your feature request related to a problem? Please describe.
Can you add support for Firefox android?

Okay. I will try to add support for firefox android.


Debian 8 Jessie - docker-engine (1.9.1-0~jessie) - DOCKER_OPTS ignored

I found that settings from /etc/default/docker file are ignored when service starts via systemd, making it really awkward to add/change parameters, for example where docker deamon listens for commands (required to enable clustering - default is -H fd://).
Currently the only option I found working is to manually edit the docker.service file, reload systemd and restart docker service for changes to take effect.
Version affected:
Package: docker-engine
Maintainer: Docker<EMAIL_ADDRESS>Version: 1.9.1-0~jessie

If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
For more information about reporting issues, see CONTRIBUTING.md.
You don't have to include this information if this is a feature request
(This is an automated, informational response)

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

check if this applies your needs
https://docs.docker.com/engine/articles/systemd/

Correct, systemd systems should be configured using "drop-in" files; note that you should never edit the service-file itself, because that may cause issues if you're upgrading an existing install, and there's an updated version of the service-file. Using drop-ins makes sure your changes are preserved, also when upgrading. See this section on the page that @HackToday mentioned to learn about using drop-in files; https://docs.docker.com/engine/articles/systemd/#custom-docker-daemon-options
I'm going to close this issue, because this works as expected, but feel free to comment here after I've closed this issue