Inquiry about file save function and dump function

hello. Thank you for creating a really great program.
The game I'm checking has many classes and functions, so if I use functions like "c() == list_classes", wouldn't it be possible to save the list locally as a file?
Also, if you look at the wiki, you don't see the dump function. Has it disappeared now?
The game I'm checking generates an error when using il2cppdumper, so I'm asking if I can use the dump function.

ReferenceError: 'showAsm' is not defined!
Did I do something wrong?

I don't quite understand what you're trying to express. I just retested using 'showAsm,' and it seemed quite normal.

dump function ？ You means "Il2Cpp.dump()" ?

It seems like there are no issues with this function call either.
As for the issue with il2cppdumper not producing output, you can manually search for 'codeRegistration' and 'metadataRegistration.'

metadataRegistration

I don't quite understand what you're trying to express. I just retested using 'showAsm,' and it seemed quite normal.
dump function ？ You means "Il2Cpp.dump()" ?   It seems like there are no issues with this function call either.
As for the issue with il2cppdumper not producing output, you can manually search for 'codeRegistration' and 'metadataRegistration.'

답변감사합니다.
제가 "frida -U -f com.android.xxx _Ufunc.js" 스크립트를 로드해서 사용해서 그런 것으로 의심됩니다.
이렇게 사용해도 i(), c(), m() 등이 정상적으로 사용되서, 이 상태가 정상인 것으로 착각한 것 같습니다.
내일 "fat -r com.android.xxx" 이 방식으로 해보겠습니다.
만약, 덤프를 한다고 가정하면 아래와 같이 사용하면 될까?

"far -r com.android.xxx"
"showAsm(0x0000,0x50)

덤프의 경우는 wiki>Contents>dumpSo>/dumpMem : dump So / dump mem 링크를 누르면, 다시 화면의 최상단으로 이동해서 물어봤습니다.
찾고자하는 내용은 il2cppdump가 맞습니다.
이것도 다시 해보겠습니다.
친절히 설명해 주셔서 감사합니다.

I don't quite understand what you're trying to express. I just retested using 'showAsm,' and it seemed quite normal.
dump function ？ You means "Il2Cpp.dump()" ?   It seems like there are no issues with this function call either.
As for the issue with il2cppdumper not producing output, you can manually search for 'codeRegistration' and 'metadataRegistration.'

Thank you for your kind response.
I apologize. I realized that I had not fully understood certain parts. My questions also seemed a bit unorganized, so I have arranged them below.
1. "showAsm" Issue
I misunderstood how to use it before. After trying again, I confirmed that "showAsm" works well. Thank you.
2. Query about dump
On the wiki (https://github.com/axhlzy/Il2CppHookScripts/wiki/API), clicking on the "dumpSo / dumpMem: dump So / dump mem" item does not lead to a description of dump. Instead, it redirects to the top of the page. Therefore, I was unable to obtain information about dump and am asking about it.
3. Query about Il2Cpp.dump
After seeing the example picture you provided, I tried using "Il2Cpp.dump()" but encountered an error as shown in the picture below. Can you help me understand what this error is? (It dumps normally in other games.) As additional information, il2CPPDUMPER also did not dump due to an error, and other dumpers also experienced errors.

4. Saving Function Information as an Alternative to Il2Cpp.dump
This part corresponds to the question I asked earlier about "wouldn't it be possible to save the list locally as a file?"
Although Il2Cpp.dumps results in an error, the class and function information obtained using i()/c()/m() seem accurate. Therefore, I plan to save the function information as a file using i()/c()/m() instead of dump. (It might take a long time.) If you have time, I would really appreciate any tips you could provide.
Since my knowledge of programming is limited, there may be some parts of my explanation that are hard to understand. Please consider this. Once again, I thank you for creating such a useful program.

Query about dump
你提到的这个我已经把超链接添加上去了
（ps:有一些比较直观简单的我就没有截图展示了，就直接去源码中搜 globalthis.xxx去简单查看一下如何使用就好了）
3/4
用不了的话可能是游戏有加密处理或者是什么的，或者是这个项目使用到的frida-il2cpp-bridge的版本太低了？可以去frida-il2cpp-bridge它的库下载它最新的源码进行编译得到的js，附加上去之后再使用Il2Cpp.dump。单纯说保存日志，还有一个比较笨的方法，使用frida -o 重定向输出日志

-> 2.Query about dump
"You mentioned this, and I have already added the hyperlink. (PS: For some more straightforward and simple ones, I didn't show screenshots. Just go directly to the source code and search for globalthis.xxx to quickly check how to use it.)
-> 3. Query about Il2Cpp.dump | 4. Saving Function Information as an Alternative to Il2Cpp.dump
If it doesn't work, it might be because the game has encryption processes, or maybe the version of frida-il2cpp-bridge used in this project is too old? You can go to the frida-il2cpp-bridge repository, download its latest source code, compile it to get the JS file, attach it, and then use Il2Cpp.dump. As for simply saving logs, there's another more basic method: use frida -o to redirect the output of the logs."

"Ah! Thank you very much for your kind response.
I will try to make good use of it.
I have already tried using frida-il2cpp-bridge, but the same issue was occurring.
It seems like I will have to complete it by logging during the time I spend searching for the tool."

I'm really grateful for your help, "axhlzy".
Thanks to you, I was able to obtain the entire list of functions.
However, my goal was to acquire the symbols of all functions in the il2cpp segment, but I only managed to obtain a portion of them (about a quarter).
The symbols I did acquire closely match the list obtained through ZygiskDump, confirming that l2cppHooker can be a useful tool for dealing with situations where il2cppdumper does not work (although I haven't verified this with other projects, I suspect it will have a similar effect).
I would like to express my sincere gratitude to the developer for creating such a useful tool.
I'm interested in other useful features and plan to use them as wel

:blush::blush::blush:


Health Check from LB to FAbio

Hello,
The health check in Fabio i used by consul and always returned OK.
We have Load balancer in front of fabio (like a lot of people i suppose) with a health check to Fabio.
We can not rely on Fabio Health check beacuse it's always return ok if Fabio is up, but imagine that the Consul Agent is down or the entire Consul cluster is not in a good shape. The health check provided by fabio is OK but you can not reach your services (and/or your are not sure of what you have in your routing table).
Is it possible to add a check of the consul agent (for example check the /v1/status/leader) to ensure that everything is OK on consul side. If not, the health page of Fabio must return a error code (> 200) to let the LB blacklist it to avoid returning error to client. With this, you will have a full chain of testing.
Same thing can be done with Vault (but i think it's let problematic, the older services will work but not the new one) as an optional check (like for consul).

What should fabio conclude when consul is down? Does that mean your services are gone as well? How often do you have issues with your consul cluster? fabio will continue to serve the last known good routing table. In the two years I've had this in prod we didn't have issues with it. Just as with fabio consul was one of the tools we simply forgot was there.
If you don't want to rely on fabio then check consul instead.

Ok cluster consul doesn't fail easily (we've issue but ok). Agent (client) consul can failed, and we are using it at localhost fot the HTTPS port (8543). So a LB can not have access to it to check the state ...
If we change that, we need to do a health check in HTTPS to consul agent and our load balancer do not handle HTTPS health check (need to have our root ca in it and/or certificates, and it's a nightmare to handle).
And yes, i prefer to disabled a fabio that can not access consul, because if a route is changed during the outage, the client will have error from fabio and it's rood because you have an another fabio instance that can respond correctly ... If the LB discard the fabio instance without consul, traffic will be redirected to the good one.
I can add a route or something like that, but a user can delete it and failed the fabio ... (and only in HTTPS) I dont want to open http and https (only https).

I have an example use case here as well. We have several thousand services and about 7k routes. When a fabio restart (or starts up in the case of a new VM), that fabio goes healthy in consul because /health begins responding immediately. Then, that fabio starts receiving production traffic and responds with 404s because the route table isn't populated yet. It takes about 60 seconds for the route table to populate it seems. It would be nice if /health responded ok once the full startup finished. @leprechau, wanted to see if you had some thoughts on this one. Thanks!


Doesn't support android API 22, version 5.1

My code works for Android API 23, version 6.0 emulator. And doesn't work for ex. android API 22, version 5.1
I get the following

Could you please add in your documentation which API level is supports your lib.

+1 same issue

+1 same issue

Yes, I believe that's the webview issue. I'll have to set up some time to test the different android versions.


Add verbose flag to extract-bitcode and make two levels of verbosity.

Adds diagnostic output on-demand to assist in debugging failure cases.

Obsolete: folded into #56 .


Front-end should provide warning after failing

The loading icon just goes infinitely. We should probably have some set amount of retries after which we surface an error message to users.
I have spent a few times accidentally staring at it waiting for it to work

Agreed... we should make sure the error handlers work correctly.

Closing because this seems to work for me - please reopen if there is a specific page that this breaks on.

@yifanmai to be more specific, this involves the error where fetching schema or something else in benchmark_output fails for some reason (i.e. the URL being wrong or something else). The front end doesn't say anything, and you have to go to developer console to see if something is wrong. In these cases, most pages just show a loading sign for a while.
I think this is fine for now, as developers should be able to figure out the issue, but it would be nice to show users/developers if something went wrong in fetching data.


PageView bug?

i tried more than 4 days now to fix the following problem: https://youtu.be/J1sbdWLG260
As you can see, the pageview has multiple sites with different images but the problem is that since I replaced the AssetImage there with a NetworkImage it starts to hide the next site (or the one before or both)... i really hat this and everything i tried didnt work, it cant be a problem with my code because i tried many different codes too or just the normal pageview but anyways here it is:

code sample
final pageController = PageController(initialPage: 0, viewportFraction: 0.7, keepPage: true);
PageView.builder(
          controller: pageController,
          scrollDirection: Axis.horizontal,
          itemCount: list.length,//latestItems.length,
          dragStartBehavior: DragStartBehavior.down,
          physics: const BouncingScrollPhysics(parent: AlwaysScrollableScrollPhysics()),
          itemBuilder: (context, index) {
            return AnimatedBuilder(
              animation: pageController,
              builder: (context, widget) {
                if (pageController.position.minScrollExtent == null ||
                    pageController.position.maxScrollExtent == null) {
                  Future.delayed(Duration(microseconds: 1), () {
                    setState(() {});
                  });
                  return Container();
                }
                double value = pageController.page - index;
                value = (1 - (value.abs() * 0.3)).clamp(0.0, 1.0);
                return Center(
                  child: NetworkImage(url[index]),);
              },
            );
          },
        )

https://i.stack.imgur.com/2Cy6g.jpg https://i.stack.imgur.com/FNV3p.jpg
I would love to get this working and would appreciate any help! :) Thank you (-> i can give you more details if needed)
Flutter doctor:
[√] Flutter (Channel stable, v1.9.1+hotfix.6, on Microsoft Windows [Version 10.0.18362.476], locale de-DE)
• Flutter version 1.9.1+hotfix.6 at C:\Users\besitzer\flutter
• Framework revision 68587a0916 (3 months ago), 2019-09-13 19:46:58 -0700
• Engine revision b863200c37
• Dart version 2.5.0
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at C:\Users\besitzer\AppData\Local\Android\sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 29.0.2
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
• All Android licenses accepted.
[√] Android Studio (version 3.5)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 41.1.2
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
[!] IntelliJ IDEA Community Edition (version 2017.2)
• IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2017.2.5
X Flutter plugin not installed; this adds Flutter specific functionality.
X Dart plugin not installed; this adds Dart specific functionality.
• For information about installing plugins, see
https://flutter.dev/intellij-setup/#installing-the-plugins
[√] VS Code (version 1.39.1)
• VS Code at C:\Users\besitzer\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.5.1
[√] Connected device (1 available)
• Android SDK built for x86 • emulator-5554 • android-x86 • Android 10 (API 29) (emulator)
! Doctor found issues in 1 category.

Hi @Kimonnn
I'm not sure that what you are describing is a bug related to PageView

sample code
import "package:flutter/material.dart";

void main()=> runApp(MyApp());

class MyApp extends StatelessWidget {

  @override
  Widget build(BuildContext context) => MaterialApp(home: HomePage(),);
}

class HomePage extends StatefulWidget {

  @override
  _HomePageState createState() => _HomePageState();
}

class _HomePageState extends State<HomePage> {
  static PageController _controller;
  static const String _url = 'https://flutter.dev/images/catalog-widget-placeholder.png';
  static List<Widget> get _widgets => [for (int i=0; i<10; ++i) PageWidget(url: _url)];

  @override
  void initState() {
    _controller = PageController(
      initialPage: 4,
      viewportFraction: 0.8,);
    super.initState();
  }

  @override
  void dispose() {
    _controller?.dispose();
    _controller=null;
    super.dispose();
  }

  @override
  Widget build(BuildContext context) => Scaffold(
    backgroundColor: Colors.blueAccent,
    body:PageView(
    controller: _controller,
    children: _widgets,
  ),);
}

class PageWidget extends StatefulWidget {
  final String url;
  PageWidget({this.url});

  @override
  _PageWidgetState createState() => _PageWidgetState();
}

class _PageWidgetState extends State<PageWidget> {
  static Image _image;

  @override
  void initState() {
    _image = Image.network(widget.url,);
    super.initState();
  }

  @override
  void dispose() {
    _image = null;
    super.dispose();
  }

  @override
  Widget build(BuildContext context) => Padding(
    padding: const EdgeInsets.only(right: 10),
    child: _image
  );
}

generally it's a good idea to "load" and dispose the images to free some memory
but if in want prioritize the "readiness" of the picture you might want to consider the AutomaticKeepAliveClientMixin

sample
...
class _PageWidgetState extends State<PageWidget> with AutomaticKeepAliveClientMixin {

  @override
  bool get wantKeepAlive => true;
...

does this solution fix the issue?
thank you

With your solution the images are not hiding that often as before but still in 2 of 4-5 swipes which is not good at all.. i understand that it is not bad to unload the pages but as you can see in the youtube video linked above, the whole app seems verrryy laggy and buggy because of this and it just looks not good :( i dont know what i should have done wrong but your example works fine.. maybe you can see what i did wrong: https://pastebin.com/bH2zmppf and the pageview widget: https://pastebin.com/9QftxrWi

@Kimonnn It is very much a problem with your code. Even though you say it's not.
It's a async / memory problem. The reason it works fine when you use local images is because they load almost instantly from disk.
You need to do a few things.

Prefetch at least 3 images. left, center, right. Possible more depending on how many you want to cache.
Prefetch more as the user swipes. For example you have 3 in ram. The user swipes to the right you will need to load the next right one into ram getting ready for them to swipe again.
Dispose of old images from ram if it gets too big.

Sorry to tell you PageView is working just fine. It's not going to manage all the memory for you automatically.

Hi @Kimonnn
I see you are not passing the slides as a widget but as a stream
this way the AutomaticKeepAliveClientMixin will help only marginally;
since you are using in a state that uses a streambuilder
I'm afraid those images are still rebuild, you may want to test with some print().
Regardless, this doesn't appear to be an issue with flutter itself
and this platform is not met for assistance on personal code.
Please see https://flutter.dev/community for resources for asking questions like this,
you may also get some help if you post it on Stack Overflow.
Closing, as this isn't an issue with Flutter itself,
if you disagree please write in the comments and I will reopen it
Thank you


Specify encoding when reading file. Otherwise fails if default encoding is set, for instance, to cp1251.

Python >=2.6 friendly.

Thanks, but what exactly fails?
read() is a general method returning a binary string, I don't see how encoding (text) comes into it?

Merging, thanks @kalaidin !

Thanks much!


Add brackets in list->items overrides

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind user-interface

/kind content

/kind translation

/kind event

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area blog

/area documentation

/area community

What this PR does / why we need it:
During my tune process I've noticed typos in the current Overriding document which missing brackets in the list definition.
- list: my_programs
  items: cp
  override:
    items: append

and here
- list: my_programs
  items: vi, vim, nano
  override:
    items: replace

That leads to issues on validation step related to LOAD_ERR_YAML_VALIDATE ... Value is not a sequence

The correct way is to wrap (even a single) argument in brackets. I've already test it with my custom rules and their work as expected.
- list: user_known_chmod_applications
  items: [containerd]
  override:
    items: append

Which issue(s) this PR fixes:

I don't aware about any Issues that this PR might close, since I don't open one and open this PR to fix it.
Special notes for your reviewer:

Welcome @loonydev! It looks like this is your first PR to falcosecurity/falco-website 🎉

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif, loonydev
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[BUG] Errors presented visually are not relayed programmatically.

Status Messages
Errors presented visually are not relayed programmatically.
DAC Accessibility Audit outcome:
https://ukho.sharepoint.com/sites/EXT_Data_Upload/Shared%20Documents/Forms/AllItems.aspx?OR=Teams%2DHL&CT=1711376954679&clickparams=eyJBcHBOYW1lIjoiVGVhbXMtRGVza3RvcCIsIkFwcFZlcnNpb24iOiIyNy8yNDAyMjkyMDYwMiIsIkhhc0ZlZGVyYXRlZFVzZXIiOmZhbHNlfQ%3D%3D&id=%2Fsites%2FEXT%5FData%5FUpload%2FShared%20Documents%2FGeneral%2FAccessibility%20Audit%2FPrivate%20Beta%2FDAC%20Accessibility%20Report%20WCAG%202%2E2%20UKHO%20UDU%20130324%20Final%20Version%2Epdf&viewid=8b1f0a9e%2D2897%2D4a4d%2D8283%2Dcc660e97e3e4&parent=%2Fsites%2FEXT%5FData%5FUpload%2FShared%20Documents%2FGeneral%2FAccessibility%20Audit%2FPrivate%20Beta
(Pages 44-46)
WCAG Reference:
4.1.3 Status Messages (Level AA)
Understanding Status Messages |How to Meet Status Messages
Issue ID: DAC_Status_Messages_01
URL: https://ukhodataupload.admiralty.co.uk/external/survey-details
Page title: Survey Details
Journey: 1.3
Live error messages and the error summary is not adequately relayed to screen reader
users. This instance can be found when causing errors on the page or attempting to
continue onto the next stage of the service with required feels left empty. Error messages
and the error summary can be viewed; however, an adequate role is missing from the
components to relay this information to screen reader users when they are displayed

Is this linked to #161 that @lstevens98 is working on?


bug: JavaScript heap out of memory on certain requests

Describe the bug:
Certain requests that worked on V4 are now causing JavaScript heap out of memory on V5.
For example this server.
"host": "play.minelatino.com",
"port": 25565,
On v4 i was able to ping upwards of 100 servers at one time without any issues, on v5 this was giving me this error and i was able to narrow it down to have it crash on just one server.
Im sure i could find more servers that are causing issues, this was just the first one i found.
Code:
// Example code

    return status("play.minelatino.com", 25565).catch((e) => {
      if (e === undefined) {
        return { error: 'Error is undefined.', request: host }
      }
      return { error: e, request: host }
    });

// Output
<--- Last few GCs --->

[26877:0x120008000]    15966 ms: Scavenge 4027.5 (4083.9) -> 4025.6 (4083.9) MB, 2.9 / 0.0 ms  (average mu = 0.168, current mu = 0.101) allocation failure
[26877:0x120008000]    15973 ms: Scavenge 4030.7 (4087.1) -> 4028.8 (4087.1) MB, 2.9 / 0.0 ms  (average mu = 0.168, current mu = 0.101) allocation failure
[26877:0x120008000]    16135 ms: Scavenge (reduce) 4034.2 (4090.6) -> 4032.2 (4087.6) MB, 1.2 / 0.0 ms  (average mu = 0.168, current mu = 0.101) allocation failure

<--- JS stacktrace --->

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x10044e36c node::Abort() [/usr/local/bin/node]
 2: 0x10044e4f4 node::errors::TryCatchScope::~TryCatchScope() [/usr/local/bin/node]
 3: 0x10059b378 v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [/usr/local/bin/node]
 4: 0x10059b30c v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [/usr/local/bin/node]
 5: 0x10071eafc v8::internal::Heap::GarbageCollectionReasonToString(v8::internal::GarbageCollectionReason) [/usr/local/bin/node]
 6: 0x100722104 v8::internal::Heap::CollectSharedGarbage(v8::internal::GarbageCollectionReason) [/usr/local/bin/node]
 7: 0x10071f2c4 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [/usr/local/bin/node]
 8: 0x10071cbec v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/usr/local/bin/node]
 9: 0x10071ba54 v8::internal::Heap::HandleGCRequest() [/usr/local/bin/node]
10: 0x1006d0ccc v8::internal::StackGuard::HandleInterrupts() [/usr/local/bin/node]
11: 0x100a302d4 v8::internal::Runtime_StackGuard(int, unsigned long*, v8::internal::Isolate*) [/usr/local/bin/node]
12: 0x100d4508c Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_NoBuiltinExit [/usr/local/bin/node]
13: 0x105037dbc
14: 0x100cd8d18 Builtins_InterpreterEntryTrampoline [/usr/local/bin/node]
15: 0x100cd8d18 Builtins_InterpreterEntryTrampoline [/usr/local/bin/node]
16: 0x100cd8d18 Builtins_InterpreterEntryTrampoline [/usr/local/bin/node]
17: 0x100d0a4ec Builtins_GeneratorPrototypeNext [/usr/local/bin/node]
18: 0x100cd8d18 Builtins_InterpreterEntryTrampoline [/usr/local/bin/node]
19: 0x100d8d1b8 Builtins_PromiseFulfillReactionJob [/usr/local/bin/node]
20: 0x100cfa6f4 Builtins_RunMicrotasks [/usr/local/bin/node]
21: 0x100cd69e4 Builtins_JSRunMicrotasksEntry [/usr/local/bin/node]
22: 0x1006ab1e8 v8::internal::(anonymous namespace)::Invoke(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) [/usr/local/bin/node]
23: 0x1006ab61c v8::internal::(anonymous namespace)::InvokeWithTryCatch(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) [/usr/local/bin/node]
24: 0x1006ab6e4 v8::internal::Execution::TryRunMicrotasks(v8::internal::Isolate*, v8::internal::MicrotaskQueue*, v8::internal::MaybeHandle<v8::internal::Object>*) [/usr/local/bin/node]
25: 0x1006ce48c v8::internal::MicrotaskQueue::RunMicrotasks(v8::internal::Isolate*) [/usr/local/bin/node]
26: 0x1006ced20 v8::internal::MicrotaskQueue::PerformCheckpoint(v8::Isolate*) [/usr/local/bin/node]
27: 0x10060832c v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo) [/usr/local/bin/node]
28: 0x100607e24 v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) [/usr/local/bin/node]
29: 0x1006076b0 v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [/usr/local/bin/node]
30: 0x100d451cc Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_BuiltinExit [/usr/local/bin/node]
31: 0x105021af8
32: 0x100cd6b0c Builtins_JSEntryTrampoline [/usr/local/bin/node]
33: 0x100cd67a4 Builtins_JSEntry [/usr/local/bin/node]
34: 0x1006ab220 v8::internal::(anonymous namespace)::Invoke(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) [/usr/local/bin/node]
35: 0x1006aa8b4 v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*) [/usr/local/bin/node]
36: 0x1005b7e70 v8::Function::Call(v8::Local<v8::Context>, v8::Local<v8::Value>, int, v8::Local<v8::Value>*) [/usr/local/bin/node]
37: 0x10039de40 node::InternalCallbackScope::Close() [/usr/local/bin/node]
38: 0x10039e36c node::InternalMakeCallback(node::Environment*, v8::Local<v8::Object>, v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*, node::async_context) [/usr/local/bin/node]
39: 0x1003b34ac node::AsyncWrap::MakeCallback(v8::Local<v8::Function>, int, v8::Local<v8::Value>*) [/usr/local/bin/node]
40: 0x1004f43dc node::StreamBase::CallJSOnreadMethod(long, v8::Local<v8::ArrayBuffer>, unsigned long, node::StreamBase::StreamBaseJSChecks) [/usr/local/bin/node]
41: 0x1004f6694 node::EmitToJSStreamListener::OnStreamRead(long, uv_buf_t const&) [/usr/local/bin/node]
42: 0x1004fad84 node::LibuvStreamWrap::OnUvRead(long, uv_buf_t const*) [/usr/local/bin/node]
43: 0x100cc4498 uv__stream_io [/usr/local/bin/node]
44: 0x100ccc5b8 uv__io_poll [/usr/local/bin/node]
45: 0x100cbad34 uv_run [/usr/local/bin/node]
46: 0x10039ee00 node::SpinEventLoop(node::Environment*) [/usr/local/bin/node]
47: 0x1004876f4 node::NodeMainInstance::Run(int*, node::Environment*) [/usr/local/bin/node]
48: 0x1004873c0 node::NodeMainInstance::Run(node::EnvSerializeInfo const*) [/usr/local/bin/node]
49: 0x1004202dc node::Start(int, char**) [/usr/local/bin/node]
50: 0x104e8d0f4

Expected behavior:
To get a response with the server status or an error message.
Additional context
Using Node.js version 16.13.0
Using minecraft-server-util version 5.2.1

I have been having this error for a while unfortunately. Updating to nodejs v17 will fix it 50% of the time

I have found a potential memory leak with the event emitter system used in the TCP/UDP classes. I just published version 5.2.2 which resolves this issue through extensive testing. Let me know if this solves the problem.

I'm still getting OOM crashes, now on this host and port for example:
"host": "join.mineheroes.org",
"port": 25565,
The server i used as an example above now seems to work, but i don't run that server so i can't say for sure if they maybe changed some setting.

I was able to reproduce the bug on my end with the second address you provided. I will let you know when I find anything.

I found the problem and narrowed it down to an infinite loop bug within the minecraft-motd-util dependency. This has been fixed in 1.1.9, so use npm install<EMAIL_ADDRESS>and confirm that this has been fixed.

It seems to be working for me with the new version of minecraft-motd-util.

Good news, I'll go ahead and close this.


Allow function for theme.overrides

It will be fine to have theme properties available when overriding component style.
Example of usage:
const theme = createMuiTheme({
  overrides: {
    MuiButton: theme => ({
      root: { backgroundColor: theme.palette.secondary  }
    })
  }
})

May I create PR? Solution is to add
if (typeof overrides == 'function') overrides = overrides(theme)

after line 14 in styles/getStylesCreator.js

@PavelPZ What's wrong with this solution?
const theme = createMuiTheme()

theme.overrides = {
  MuiButton: {
    root: {
      backgroundColor: theme.palette.secondary,
    }
  }
}

Short answer
We can have single pattern for component styling definition, e.g.
//component style definition module
const componentStyleSecondary = theme => {  root: {  backgroundColor: theme.palette.secondary } }
const componentStylePrimary = theme => {  root: {  backgroundColor: theme.palette.primary } }

//module with component code
const ComponentPrimary = withStyles(componentStylePrimary, { name: 'CompPrimary' })(component)
const ComponentSecondary = withStyles(componentStylePrimary, { name: 'CompSecondary' })(component)

//application with customized component
const theme = createMuiTheme({
  overrides: {
    CompPrimary: ComponentSecondary,
    CompSecondary: ComponentPrimary
  }
})

Long answer
I am working on porting MUI theming and component customization to version, compatible with react-native (I will release some proof of concept soon). There will be possible to customize component like this:
<Component classes={theme => {root: {backgroundColor: theme.palette.primary}}}/>
//or
<Component classes={ComponentPrimary}/>

For web, CSS sheet is generated (and its class name is cached) on the fly like Fela does (this dynamic stylesheet has huge index x specificity).
For native object merging result is assigned to style prop.

Does it make sense?

I think that I get the use case. We encourage people to wrap all our components for advanced use cases. This scale better. The overrides theme key is here so people can quickly hack things without having to write a wrapper.

Let me know when you have something compatible with react-native. I'm eager to know more about it :).

It would be great to have current theme in overrides also for another reason. Maybe eve better for it to look like that:
const theme = createMuiTheme({
  overrides:  theme => ({
    MuiButton: {
      root: { backgroundColor: theme.palette.secondary  }
    }
  })
})

The use case, is when you have nested dark theme inside a light theme, and if we're doing it like so:

const theme = createMuiTheme()
theme.overrides = {
MuiPaper: {
root: {
backgroundColor: theme.palette.background.level1,
}
}
}

Background will still be light. Therefore we have to create 2 themes (light and dark), and bloat the code with enormous amount of ternary operators, for each case where light and dark theme is differ, instead of restyling components for dark theme exactly where needed.

@ndeviant I don't get the problem. You can create a function to abstract the duplication/ternary operators.
It resonates a bit with option 2 in https://github.com/mui-org/material-ui/issues/26813#issuecomment-864615252 where the theme is also available as part of the props.


Barlow font...

This is of course just a subjective opinion, but I find the barlow font being used on napari.org to be less legible, and less attractive than the generic system-ui font-family stack used in the standard pydata sphinx theme.  Curious whether others feel like it's an improvement?  @DragaDoncila, @jni, @sofroniewn?

@codemonkey800

change the font for the docs specifically and keep Barlow for the theme default

What does this mean exactly? imho the point of the theme is that we use it "as-is". So this issue is by my reading more about changing the theme than about our docs specifically.

I find the barlow font being used on napari.org to be less legible,

I feel the same way. Attractiveness is definitely subjective and I can see the appeal of Barlow — it is at the very least distinctive — but legibility is not subjective. Unfortunately, I've never had an easy time finding actual legibility metrics for specific fonts, but I'd wager Barlow wouldn't score highly there. If my eyes don't deceive me, Barlow is more condensed than most fonts, which is probably not great for legibility. (?)
Perhaps a way to maintain the personality of the theme while improving legibility is to use Barlow for headings but a more standard sans font for body text?

generic system ui (pydata default):

Barlow (current napari.org theme):

I prefer Barlow overall but this is definitely on an aesthetic level, not a legibility level. I don't have a problem reading either but can see how the pydata defaults would be more legible - ultimately I'm happy with either

@alisterburt why is the PyData screenshot in dark mode :joy:

updated with light mode - pydata respects system theme but napari.org theme doesn't it seems!

Not yet, it's an issue: #22

got another outside perspective - pydata is 'cleaner' and 'prettier'. From this (small) sample it's already clear that it's subjective which is nicer but legibility is better on the pydata theme, that seems important enough to change it 🙂

Perhaps a way to maintain the personality of the theme while improving legibility is to use Barlow for headings but a more standard sans font for body text?

👍🏼 this sounds great

To clarify: I like a lot of aspects of our theme, and to me PyData is very "beige", and I dislike it for that reason. But I don't think the main text font is an improvement because I find it more noticeable (=distracting) and less easy to read.

To be clear comments above were only in relation to the fonts in the two screenshots above - I love the napari theme :)

I think there's call out here that readability on the .org might not be as good as we'd like it to be right now, but I'm not sure the issue is the just legibility of the Barlow font, which in my subjective opinion I find quite attractive.
I (and I wonder if others feel the same) probably find https://www.napari-hub.org/ slightly more readable than https://napari.org/. There are some differences here in font size and column width (maybe line height?) that could contribute to readability.
I know that in the first pass of the website things might not have been implemented to be pixel-perfect design-wise as we wanted to just start with PyData and get something quick that would work.
Maybe @liaprins-czi can take a closer look at the .org and the original designs and work with @codemonkey800 to make some readability improvements while keeping Barlow. If we can't get to a place which people find readable enough with Barlow then maybe @liaprins-czi could propose another font.

Maybe @liaprins-czi can take a closer look at the .org and the original designs and work with @codemonkey800 to make some readability improvements while keeping Barlow. If we can't get to a place which people find readable enough with Barlow then maybe @liaprins-czi could propose another font.

This sounds good to me. It is true that we were just trying to get out the first round of primary iterations for the theme, and there are smaller fixes left. We will see how we can make it better first, maybe including letter-spacing as well as the line-height, text length, and other attributes. Otherwise, I agree with the idea of keeping it for the display face (headings, etc) and finding a complimentary font for the main text.
It is interesting to me that others find Barlow to be less legible than the PyData default, but good to know. I do think legibility is subjective because there haven't been reproducible studies I've found (and also I happen to to find the PyData default less legible slightly, maybe because I peruse fonts regularly for my job as a designer and used to looking at all different ones, but that's just a guess! Also it looks more harsh to my eyes so maybe that affects my perception, too, who knows.)
(And just in case anyone is interested in more about how I chose Barlow, it was based on some principles I was working with when I made the initial napari.org redesign a while ago (before this Sphinx-themification). It felt like Barlow was fitting the concepts of being friendly and welcoming because it has round elements to most letters, even the dot for the "i", but the roundness is more geometric and precise. It also felt very clean and cohesive the way most of the letters had parallel vertical lines (e.g. the lowercase "e", "c", and "o" aren't perfectly round, but are more vertical / straight at their middles before rounding at top and bottom, if that makes sense . Lastly, it is slightly less generic than some other fonts, which made it seem more recognizable as an element specific to napari that others could subconsciously recognize and even tie across napari.org and the hub. If that all sounded very subjective to you, yes it is by definition, but there is a bit of rationale. And user don't consciously notice any of that (unless they are font designers lol), but subconsciously can affect how they "feel" about a site. However, legibility is extremely important, so again, if needed we can certainly find a complimentary font and keep Barlow for the more "branded" areas like headers!)

Thank you for your comment, Lia! I agree with everything you said. In terms of legibility, my thought is that this:

It also felt very clean and cohesive the way most of the letters had parallel vertical lines (e.g. the lowercase "e", "c", and "o" aren't perfectly round, but are more vertical / straight at their middles before rounding at top and bottom, if that makes sense)

encapsulates what I find less legible (and what I called more "condensed" above, though that might have been abusing terminology 😅). Although your point about the cohesion of the font makes sense, in my opinion, the extra vertical strokes make the letters less distinguishable from other letters with vertical strokes such as m, n, u.
Anyway, glad to have you confirm that it's hard to find legibility studies. I'm of half a mind to go do one so we can put the issue to rest! 😂

I'm open to including a different font for main areas of text (keeping Barlow for headers, etc), but would need to determine the design work priority relative to other work; I can follow up with @neuromusic about that.

but would need to determine the design work priority relative to other work

any opposition to the just using the same system-ui font stack?

any opposition to the just using the same system-ui font stack?

My opposition would be that typefaces should be carefully selected to go well together, in order to create a professional presence for a website, and the system-ui fonts don't look right with the Barlow font (which would still be used for much of the site). Design will also need to specify which text components get which typeface (Barlow or its to-be-determined companion typeface), and within the new typeface, which font, and also to consider line-height, tracking, etc.

ok I see.  yeah, I certainly agree (and wasn't suggesting) we shouldn't mix and match. :)   if we don't go fully to the stack used by pydata, then it shouldn't happen

Now that we have the new theme, what do we think about the fonts? I kept Barlow as the first choice to match the original look of the pages, but we can always reconsider.

I personally like the font and appreciate the thought-process by @liaprins-czi ( https://github.com/napari/napari-sphinx-theme/issues/88#issuecomment-1081133045 ). Maybe if there are specific issues we can identify, we should up-stream them: https://github.com/jpt/barlow ?

I also appreciate Lia's thought process but my opinion about the legibility of the straighter o/e/c's expressed in this comment hasn't changed. I wouldn't rush to change it and I appreciate the continuity provided by the new theme, but on the other hand 0.5 does seem like a good opportunity to go back to system font.
I dunno, maybe we can start a thread on the core dev Zulip to discuss and eventually vote? Other than that I don't see an easy way to resolve this since there are so many diverse opinions about fonts. 😅

(I don't think asking Barlow to update their whole vibe is a viable solution here, and it kind of defeats the purpose of keeping it.)


update with full list html5 self closing tags

html5 spec has a list of void elements (aka self closing tags)
https://www.w3.org/TR/html5/syntax.html#void-elements

Coverage remained the same at 94.622% when pulling e1a61e45c900e96e8ea0cc6cb2d32ac7ddbf548f on Cojad:master into 96634727ec973ee0a57c5060139bfd747f079b67 on paquettg:master.

Coverage remained the same at 94.622% when pulling e1a61e45c900e96e8ea0cc6cb2d32ac7ddbf548f on Cojad:master into 96634727ec973ee0a57c5060139bfd747f079b67 on paquettg:master.

I was having trouble while extracting audio tag. There maybe still some other self-closing tag in
Foreign elements. But this should avoid most common self closing tag. But I think it's better close the tag if tags actually does self closing with slash at the end.
ex: <audio src="test.way" />


DateTime::createFromFormat()  parameter incorrect

DateTime::createFromFormat() expects string, integer given
file: system/HTTP/Response.php
// line # 717
-  $this->setDate( \DateTime::createFromFormat('U', time() ) );
+  $this->setDate( \DateTime::createFromFormat('U', (string) time() ) );

\DateTime::createFromFormat expects a string in the second parameter, but if an integer is passed, internally converts that integer to a string and gives no error.

\DateTime::createFromFormat expects a string in the second parameter, but if an integer is passed, internally converts that integer to a string and gives no error.

The PHP 7 Manual expects a string and if it is not then has to test and convert for all possible parameter types.
Once the passed type is found ( array, bool, float, integer,  etc) then a nearest match conversion is used and hopefully is correct. The additional processing takes time and can be eliminated by passing the correct type or casting the passed parameter.
Currently this is neither an error or a warning but could change in the near future or if an option arises to have a compiled version then this would surely be an error.

Ok. You're right.
I thought the function was throwing an error.
My mistake.


Improve debugging

WHAT
A brief description of the pull request:
Some small fixes to enable better local debugging of cardid.
HOW
Steps to test or reproduce:
Fix env.sh's location of the .env file - it's in pay-scripts, not this directory.
Add some more logging for the data file loading process.
WHO
Who should review this pull request:

[X] Developers
[ ] WebOps

👍


Commas cause GPUDrivers throw ValueError

https://github.com/loherangrin/o3tanks/blob/dc7d7871bc06096905563f91ad996d3287e48a7e/recipes/o3tanks/globals/o3tanks.py#L71-L76
Lines 72, 74, 75
Removing them solves it and returns the expected values.

I added the fix within the implementation of #28 , which is going to be released.
I'll close this issue when I merge the PR.


Error when upgrading using Helm from 0.8.0 to 1.0.0

I first installed v0.8.0 and then tried an upgrade to 1.0 using release-1.0 with:
helm upgrade istio install/kubernetes/helm/istio --namespace istio-system

An error is being printed  by Helm:
Error: UPGRADE FAILED: ClusterRoleBinding.rbac.authorization.k8s.io "istio-ingress-istio-system" is invalid: roleRef: Invalid value: rbac.RoleRef{APIGroup:"rbac.authorization.k8s.io", Kind:"ClusterRole", Name:"istio-ingress-istio-system"}: cannot change roleRef

This was the error that I was worried about in the config.istio.io -> rbac.istio.io change.
Roleref immutable.

@ymesika are you fixing it?

I suggest rolling back the rename - we decided to not rename networking from alpha3 at this point, and do all renames with K8S 1.11 is available.

Guys, it's not related to the rename PR which didn't even get merged yet.
Just reported what I'm seeing when I upgrade to release-1.0 branch.

I can confirm that partially reverting #6390 and changing:
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: istio-ingress-{{ .Release.Namespace }}

back to:
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: istio-pilot-{{ .Release.Namespace }}

solves this and upgrade to current release-1.0 works fine.
It's a fix which brings back a typo but solves this issue.
@costinm @hklai your call whether to put the typo back.

Ok, let's not merge it then :-)
I remember something similar in 0.8 - it happens if any labels get changed. It might be related to the 0.8 labels that got converted to 1.0.

Yes please, put the typo back.

Fixed by #7062


Added support for setting domain (global.proxy.clusterDomain equivalent)

Q
A

Bug fix?
no

New feature?
yes

API breaks?
no

Deprecations?
no

Related tickets
fixes #101

License
Apache 2.0

What's in this PR?
Enables setting the equivalent of global.proxy.clusterDomain from the Istio Helm Chart. Chose to default to "cluster.local" as in upstream.
Checklist

[x] Implementation tested
[x] User guide and development docs updated (if needed)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for the PR @qvicksilver!
At first glance it looks fine, but I think we should use the clusterDomain every place where we currently use fixed cluster.local. For example: https://github.com/banzaicloud/istio-operator/blob/13af2d5006adac1b3b09281cb1e2bf16c536e4bd/pkg/resources/pilot/meshexpansion.go#L79

Thanks for the PR @qvicksilver!
At first glance it looks fine, but I think we should use the clusterDomain every place where we currently use fixed cluster.local. For example:
https://github.com/banzaicloud/istio-operator/blob/13af2d5006adac1b3b09281cb1e2bf16c536e4bd/pkg/resources/pilot/meshexpansion.go#L79

Sounds sane, I'll get on to it!

@qvicksilver,
can you please rebase?


refactor(Auth0Provider): Use @auth0/auth0-react instead of own Auth0Provider

Some users have had trouble with the login mechanism (unclear what exactly). This PR uses the @auth0/auth0-react package to manage login/logout/signup/etc instead of our own custom logic, hoping to bring more stability.

Our logic is also taken from auth0 but that package did not exist when we build that.

Sure thing! This is not a critique. It is just an attempt at bringing more stability. As we do not maintain this component, as well as the Auth0 team, should, I guess we should be better off by using theirs. :)


[Wallet] Handle back button when entering PIN

Description
This PR fixes a couple issues that all came from the fact that we were not handling the back button on the PIN screen. In some places we handled that as "Wrong PIN" and in others we just didn't handle it at all. This PR doesn't fix 100% of the cases, but the major ones that were reported and a few extras.

The most important change is the one on the packages/mobile/src/web3/saga.ts file. It used to handle the request PIN as a binary success/failure. Now it supports a third option which is 'canceled'.
The change on packages/mobile/src/navigator/DrawerNavigator.tsx is for the Account Key item in the drawer. If you pressed the back button when the PIN screen popped up it counted as a successful PIN and it redirected to the Account Key screen. If the account was already unlocked it showed the mnemonic, otherwise it asked for the PIN again. This change fixes all that and the only way to get to that screen is to input a correct PIN.
The change in packages/mobile/src/pincode/authentication.ts was because the function could end up in an infinite loop since we were not setting the lock as false if the function failed for whatever reason (for example, pressing the back button on the PIN screen). Surprised this didn't come up sooner. Also, it's now caching the result for a few ms so that the user is not prompted for the PIN several times in a row.
Changed a bunch of if-else for the use of the showErrorOrFallback function which does the same thing but better.
When exchanging or withdrawing CELO, if you press the back button on the PIN screen you can now try again. You couldn't before and just got an error.

Tested
Manually
Related issues

Fixes #4396 & #5863 & #5289 & #6229 & #6127

Backwards compatibility
N/A

@i1skn Thanks for reviewing!

Last time I remember logic was to always ask user for PIN independently of account being unlocked already or not, can you check this with @nityas?

Yes, that was the intended behaviour and that's how it works with this PR. Previously, you got prompted for the PIN but you were still redirected to the Account Key screen if you pressed on the back button, so if the PIN had been entered recently you could see the mnemonic. It should no longer be possible to ever arrive at the Account Key screen without inputting the PIN.

Have you tested the flow, when user sets in settings "Require PIN on app open", would we just exit the app if user press back?

That's a good catch, looks like there is no back button in that screen if that option is enabled, so we should be fine:

@jeanregisser I added tests for the getPincode method and some of the sagas. Surprising to see most of them not having any tests :(

Hi @nityas I have verified this issue using Play store build v1.6.0 & App store Build v1.6.0 and observed that 'Incorrect PIN' error message is displayed when user taps on < arrow on enter PIN screen.
Repro on devices: Samsung Galaxy A5(7.0) ,iPhone SE (14.2)

Looks like this wasn't included on the 1.6 branch :( https://github.com/celo-org/celo-monorepo/releases/tag/valora-v1.6.0

Thanks  @gnardini for the information. We will verify this issue when we receive 1.7 build.

Hi @gnardini  verified below issues using Android  internal build V1.7.2(1004294329) &Test Flight build V1.7.2(39) and updated the status in respective ticket :

https://github.com/celo-org/celo-monorepo/issues/6308 - Updated
https://github.com/celo-org/celo-monorepo/issues/6229 - Blocked updated ticket.
https://github.com/celo-org/celo-monorepo/issues/5289 -  Fixed
https://github.com/celo-org/celo-monorepo/issues/4393 - Fixed.
https://github.com/celo-org/celo-monorepo/issues/4396 - Reopened
https://github.com/celo-org/celo-monorepo/issues/5863 - Reopened.
https://github.com/celo-org/celo-monorepo/issues/6127 -  #4396 Duplicate

Device: iPhone SE 2 (14.2) , Google Pixel XL (8.1)
Please let me know if I need to verify thing anything else
Thanks!!


Delete the React example

#49 : 2  dependent PRs (#50 , #63 )
#48
#62  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @steveluscher and the rest of your teammates on  Graphite


Playgrounds: link to the master version of the changelog

The changelog should be append-only, so it should be okay to just send
people to the latest one.
This also removes another usage of the baked-in git revision.
(I'm not 100% sure this is a good idea, but I think it is.)

Although it is append only, users won't know which version they are using?

Well, ideally we'd have a real version number which we would display and which they could reference against.
At the moment the only releases are by date, so it's not too hard to work out.

ok, fair enough


/

http://localhost:3000/?error=redirect_uri_mismatch&error_description=The+redirect_uri+MUST+match+the+registered+callback+URL+for+this+application.&error_uri=https%3A%2F%2Fdeveloper.github.com%2Fapps%2Fmanaging-oauth-apps%2Ftroubleshooting-authorization-request-errors%2F%23redirect-uri-mismatch#/
developer web compontent

挺不错的


Dynamic Platform Location

Implement a custom PlatformLocation that can dynamically switch between pushing changes to window.history/window.location or keeping changes in memory
Hybrid between browser and server implementations

Browser version
Server version

Update all apps that use routing with an input for switching between the two modes

Implemented a more limited approach in which I simply patch PlatformLocation's history related methods to ignore certain errors


feat: Adds suggestion for a Warp Toast component

What?
Here you will find a suggestion for a Toast component matching what we have in the Warp design system.
Examples
Let's start with a couple  of images so you can see what we're working with here.

Usage
You need to consider the following options when using the Toast.
Title
You need to provide the toast with a title. For now we only support a simple String value but we could add support for View content if so needed.
Style
You have the option to style the toast as:

an Error toast
a Success toast
a Warning toast

by using the appropriate ToastStyle enum value
Location
Furthermore you can control the location of the toast. You can place it:

at the Top of the screen
at the Bottom of the screen

by using the appropriate ToastEdge enum value.
I have added a ToastView to the example app that illustrates how to use the toast view and how you can use a viewModifier to control showing/hiding of the toast.
Design
The Toast feature is located in "Sources/Toast" and is "wrapped" in the Warp namespace.
It contains of:

A Toast SwiftUI view where we render the actual component.
A ToastStyle enum to control the colors and icons of the various styles
A ToastEdge enum to control where to show the toast
A ToastViewModifier that allows the user to easily attach a Toast component to their View

I've tried to make the naming and file structure as close to the existing Alert feature as I could, just so there is consistency (I hope 😅)
Missing Features

The Toast will not automatically dismiss after a pre-defined time interval, I'm not sure that is something we need to support?
The Toast only supports appearing at the top or bottom of the view

What I Would Like Your Feedback On

What do you think about the format, is it what you would like from a Warp component?
How do we handle icons? Right now I've added new icons but is that how we want to solve this?
What do you think about the ViewModifier, should we go with a different name?

Preview Bug
I would love to be able to run my Toast view in preview as I build it, but I get an error when doing so...the same seems to be the case for the Alert view, it complains that Compiling failed: cannot find 'Typography' in scope. Is that something we can find a workaround for?
Have fun 😄

LGTM, thank you for helping out 🥳

LGTM, thank you for helping out

Of course. Making UI  components is fun, especially in SwiftUI 😄
I have a Callout like component as well that I'll see if I can get polished and added as well....to be continued!


New package: AMGX v0.1.0

Registering package: AMGX
Repository: https://github.com/JuliaGPU/AMGX.jl
Created by: @KristofferC
Version: v0.1.0
Commit: 5281f0220698eabf9fcc74a3ebe0f9a9c4113254
Reviewed by: @KristofferC
Reference: https://github.com/JuliaGPU/AMGX.jl/commit/5281f0220698eabf9fcc74a3ebe0f9a9c4113254#commitcomment-46160276

If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged.

The library it wraps is called AMGX

If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged.

The library it wraps is called AMGX


Question: Does this stepper do vertical orientation with tabs?

Can this stepper display numbers and tabs stacked vertically down the page when in vertical orientation? Like this:

Vertically is how steppers are portrayed in the first examples in the Material guidelines, but I notice the only vertical steppers shown in this repository's examples have a sideways movement not a vertical one. Does it do vertical too?

Hi,
This library supports only horizontal steppers. There were some open source libraries which support vertical ones though the last time I checked.

Okay, thanks for getting back to me so quickly!


added "created" field in query

Fixes #74 .

Changes proposed in this PR:

added 'created' field to query getHistory
WIP check response order

@jamiehewitt15 can you review this please.

Let's deploy on the test environment first to check that it's working as expected


Update release workflow

As needed in https://github.com/quarkiverse/quarkiverse-devops/issues/210

Sorry, I changed it because I was having an exception during build. Now we will have a release soon with Dashbuilder 0.32.0, which will be using this new workflow

Hello @gastaldi
After the merge the release fails with this:
Error: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.3.0:enforce (enforce-java-version) on project quarkus-dashbuilder-parent:
Error: [ERROR] Rule 1: org.apache.maven.enforcer.rules.version.RequireJavaVersion failed with message:
Error: [ERROR] To build this project JDK 17 (or greater) is required. Please install it.
Error: [ERROR] -> [Help 1]
Error: [ERROR]
Error: [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
Error: [ERROR] Re-run Maven using the -X switch to enable full debug logging.
Error: [ERROR]
Error: [ERROR] For more information about the errors and possible solutions, please read the following articles:
Error: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

Do you know if I should update somewhere else? I also modified the build to use Java 17.
Thanks!

@jesuino my bad, https://github.com/quarkiverse/quarkus-dashbuilder/commit/dac71e239c2d3126c7f5b5e8b2efe20d0592bfde fixes it

np at all, Thanks!


[Event Request] Codeunit 80 Sales Post - OnBeforeBalacount

Hi, in the Codeunit 80 Sales Post, would it be possible to get an event OnBeforeBalacount, like this :

Thanks

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


panic error after running 4 hours

haii I'm always getting error after running 4 hours and here I copy my log error
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x4016cf]

goroutine 1 [running]:
panic(0x68fce0, 0xc42000a080)
        /usr/local/go/src/runtime/panic.go:500 +0x1a1
main.crawlerdetik(0xc420704c60, 0x5e, 0xc42060bc00, 0x6a, 0xc420073170, 0x83, 0xc420b14b00, 0x36, 0xc4205$
        /opt/go/src/gitlab.com/getboards/getboards-scrapper/handlers/news.go:134 +0x21f
main.main()
        /opt/go/src/gitlab.com/getboards/getboards-scrapper/handlers/news.go:78 +0x328

and here my code error
if(docs.Find("meta").Length() > 0){
			docs.Find("meta").Each(func(i int, s *goquery.Selection) {
				if (i > 0){
					if images, _ := s.Attr("name"); strings.EqualFold(images, "twitter:image:src") {
			           imagess, _ := s.Attr("content")
			           image = strings.TrimSpace(imagess)
			        }else if articletypes, _ := s.Attr("name"); strings.EqualFold(articletypes, "articletype") {
			           articletype, _ = s.Attr("content")
			        }
				}
		    })
		}

please help me

Hello,
Can you provide the (exact same) news.go file? What's at line 134 and 78? Did you log what input it was processing when it panics?
Martin

thanks your respon
here my code looks like news.go

 import (
"github.com/PuerkitoBio/goquery"
)

 var(
 	desc string
 )
 func main() {
 	for {
 		crawlernews("link")
	}
 }
 func crawlernews(link string){
 	docs, _ := goquery.NewDocument(link)
 	if(docs.Find("meta").Length() > 0){
 		docs.Find("meta").Each(func(i int, s *goquery.Selection) {
 			if (i > 0){
 				if images, _ := s.Attr("name"); strings.EqualFold(images, "twitter:image:src") {
 					imagess, _ := s.Attr("content")
 					image = strings.TrimSpace(imagess)
 					}else if articletypes, _ := s.Attr("name"); strings.EqualFold(articletypes, "articletype") {
 						articletype, _ = s.Attr("content")
 					}
 				}
 				})
 	}
 }

crawlernews at line 78 and then if(docs.Find("meta").Length() > 0){ at line 134
hmmm I didn't log panic because already error at if docs

thanks your respon
here my code looks like news.go

 import (
"github.com/PuerkitoBio/goquery"
)

 var(
 	desc string
 )
 func main() {
 	for {
 		crawlernews("link")
	}
 }
 func crawlernews(link string){
 	docs, _ := goquery.NewDocument(link)
 	if(docs.Find("meta").Length() > 0){
 		docs.Find("meta").Each(func(i int, s *goquery.Selection) {
 			if (i > 0){
 				if images, _ := s.Attr("name"); strings.EqualFold(images, "twitter:image:src") {
 					imagess, _ := s.Attr("content")
 					image = strings.TrimSpace(imagess)
 					}else if articletypes, _ := s.Attr("name"); strings.EqualFold(articletypes, "articletype") {
 						articletype, _ = s.Attr("content")
 					}
 				}
 				})
 	}
 }

crawlernews at line 78 and then if(docs.Find("meta").Length() > 0){ at line 134
hmmm I didn't log panic because already error at if docs

Ok, you ignore the error at goquery.NewDocument. Don't do that, handle that error and return. That's very likely why you get a nil reference error on the next line (docs is nil).

okeeee martin.

hai @mna I have been add log if nil
and I get log net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
I have been added with goquery.NewDocumentFromReader(r) and use your package github.com/PuerkitoBio/rehttp but still get error
please help me

Not sure what you mean here, if the request fails there's nothing I can do for you. There are many reasons why a network request may fail, this is not a goquery bug so this is not the right place to discuss this. I suggest you try to curl the failing URL and see if that works, but regardless, your program should be able to handle failing requests, log it or save it to some failed requests table/queue/etc. and continue with other URLs.


Controller settings in var.env have no effect

[Build]
docker 17.7 2018/06/11
[Steps to reproduce]
var.env:
edit the "Controller settings" : CONTROLLER_ORG_ID. Do not user the default PLATTFORM_OPERATOR
stop docker container
start docker container
[Expected result]
I can see the changes in the bssapp db and in the APP Controller
[Observed result]
login to APP Controller. The CONTROLLER_ORG_ID is still "PLATTFORM_OPERATOR"

What are the exact steps you have taken regarding stop docker container and start docker container?
.env and var.env files are only used during the initial start of the application when using oscm-deployer container. In order to see the changes whole oscm instance should be stopped and restarted using oscm-deployer.

for start/stop I used this:
docker-compose -f docker-compose-oscm.yml stop
docker-compose -f docker-compose-oscm.yml up -d

In that case everything works as intended. All var.env variables that are stored in the DB are only picked up by the initdb container during initial database setup. Restart will not update the database.

okay


Add taint to failed ingress assemblies, don't attempt reconcile on them

Resolves #76.

Following repro steps in #76
Before
 controller.go:439] ingress backend successfully reloaded...
[ALB-INGRESS] [echoserver-echoserver] [INFO]: Start ELBV2 (ALB) deletion.  Request: elasticloadbalancing/&{DeleteLoadBalancer POST / %!s(*request.Paginator=<nil>) %!s(func(*request.Request) error=<nil>)}, Payload: { lasticloadbalancing:us-east-2:432733164488:loadbalancer/app/dev1-b0ce157a8814bda/26dda9c78b433f86"
[echoserver-echoserver] [ERROR]: Failed deletion of ELBV2 (ALB). Error: InvalidClientTokenId: The security token included in the request is invalid.  d: 9881cacb-2aa6-11e7-8ca5-179c5e02210e.
[echoserver-echoserver] [ERROR]: Sync stopped due to error. Error: InvalidClientTokenId: The security token included in the request is invalid.  d: 9881cacb-2aa6-11e7-8ca5-179c5e02210e
 controller.go:439] ingress backend successfully reloaded...

After
controller.go:439] ingress backend successfully reloaded...
Request: ec2/&{DescribeSubnets POST / %!s(*request.Paginator=<nil>) %!s(func(*request.Request) error=<nil>)}, Payload: { SubnetIds: ["subnet-38936075","subnet-c5a934ac"]
}
[ALB-INGRESS] [controller] [ERROR]: Error parsing annotations for ingress echoserver-echoserver. Error: AuthFailure: AWS was not able to validate the provided access credentials status code: 401, request id: 022ac6fa-24f5-4c79-b2dc-4c05b5fbd42e
controller.go:439] ingress backend successfully reloaded...
controller.go:439] ingress backend successfully reloaded...

nice find


python3Packages.monty: 1.0.4 -> 3.0.2

Motivation for this change
noticed it was out of date when reviewing another package
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @
could be a slight regression with python2Packages.monty
[4 built (2 failed), 13 copied (9.8 MiB), 1.9 MiB DL]
error: build of '/nix/store/nhqi7qbxa5dkrnxy389qjwfp5483bwjn-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/72841
2 package failed to build:
python27Packages.monty python37Packages.sumo

6 package were build:
python37Packages.dftfit python37Packages.lammps-cython python37Packages.monty python37Packages.pymatgen python37Packages.pymatgen-lammps python38Packages.monty

@GrahamcOfBorg build python37Packages.dftfit python37Packages.lammps-cython python37Packages.monty python37Packages.pymatgen python37Packages.pymatgen-lammps python38Packages.monty

been 2 weeks, merging
[7 built (2 failed), 116 copied (705.8 MiB), 126.8 MiB DL]
error: build of '/nix/store/qgglydfw6ql9yp9mg4chmcryqgc80zza-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/72841
2 package failed to build:
python27Packages.monty python37Packages.sumo

6 package were built:
python37Packages.dftfit python37Packages.lammps-cython python37Packages.monty python37Packages.pymatgen python37Packages.pymatgen-lammps python38Packages.monty


Updated User and Dev Guide for Find Command Enhancement

Coverage remained the same at 88.209% when pulling 5cd0443d8e1af630c64fcba187b88e964b41523a on edwinghy:User_and_Dev_Guide_for_find_command_enhancement into 3219c27eb4b67f0efc93f7671839bf4b174a6ea4 on CS2103AUG2017-W14-B1:master.


i cant install teletype. It kept giving errors and when i finally got to the install button i tried to click it but teletype still wouldn't install.

Prerequisites

[ ] Put an X between the brackets on this line if you have done all of the following:

Followed all applicable steps in the debugging guide
Checked the FAQs on the message board for common solutions
Checked that your issue isn't already filed?

Description
[Description of the issue]
Steps to Reproduce

[First Step]
[Second Step]
[and so on...]

Expected behavior:
[What did you expect to happen?]
Actual behavior:
[What actually happened instead?]
Reproduces how often:
[What percentage of the time does this happen?]
Versions
You can get this information from copy and pasting the output of atom --version and apm --version from the command line. Also, please include the OS and what version of the OS you're running.
Additional Information
Please include any additional information, configuration or data that might be necessary to reproduce the issue. Screenshots, if appropriate, are helpful as well.

Thanks for reaching out!
We require the template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.
Specifically we need to know what errors you were seeing and if you tried any of the steps in the debugging guide http://flight-manual.atom.io/hacking-atom/sections/debugging/. Don't hesitate to reach out with more information and we will be happy to reopen this issue.
Thanks for understanding and meeting us half way :grinning:


navitem: explore how to split out markup

Goal: Supply non-React projects/products with as much support through nav DS as possible.
Existing: They already have CSS separately built.  We can split out logic easily enough as needed.  There likely won't be a lot in the nav stuff, but who knows.
Current criticality: I think this would be good for the story of nav and DS overall.  Currently, it likely is not critical because both products will likely have a React implementation.  But, maybe not.  We still don't know how they'll plan to share it.
htm lib is a solution that has been pitched previously.
Is there a solution that would work in prism today (hyperapp)?

Giving myself until noon Wednesday 7/15/20 to prototype this.


Using Unix Makefile generator in Visual Studio Code

I have a Linux project that is usually build by set of commands
mkdir tmp && cd tmp
cmake ../ && make
I opened this project in Visual Studio Code with cmake plugin by Microsoft. Visual Studio Code uses by default Ninja build system but I need to use Unix Makefile because Ninja doesn't support some commands. Is any way to do that in Visual Studio Code?

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines.
Happy Coding!


[BugFix] Fix grants_to system table miss expand external table bug

Fix bug: database.getTables() cannot get the corresponding table information when using external tables
The timeout period of grants_to rpc is set to query timeout
Grants_to_users and grants_to_roles no longer display built-in user and role information
The priv type is no longer expanded, and it is displayed on a line separated by commas

What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

[FE PR Coverage Check]
:disappointed: fail : 45 / 76 (59.21%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/privilege/StorageVolumePEntryObject.java
0
1
00.00%
[78]

:large_blue_circle:
com/starrocks/connector/ConnectorMgr.java
1
2
50.00%
[38]

:large_blue_circle:
com/starrocks/catalog/system/starrocks/GrantsTo.java
44
73
60.27%
[141, 142, 143, 144, 145, 146, 147, 162, 163, 164, 165, 169, 206, 207, 208, 209, 213, 214, 220, 238, 267, 268, 395, 448, 466, 467, 473, 474, 475]

[FE PR Coverage Check]
:disappointed: fail : 47 / 81 (58.02%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/server/SharedDataStorageVolumeMgr.java
0
2
00.00%
[47, 62]

:large_blue_circle:
com/starrocks/privilege/StorageVolumePEntryObject.java
0
1
00.00%
[78]

:large_blue_circle:
com/starrocks/connector/ConnectorMgr.java
1
2
50.00%
[38]

:large_blue_circle:
com/starrocks/catalog/system/starrocks/GrantsTo.java
44
73
60.27%
[141, 142, 143, 144, 145, 146, 147, 162, 163, 164, 165, 169, 206, 207, 208, 209, 213, 214, 220, 238, 267, 268, 395, 448, 466, 467, 473, 474, 475]

:large_blue_circle:
com/starrocks/storagevolume/StorageVolume.java
2
3
66.67%
[94]

@Mergifyio backport branch-3.0


update qvalue

thanks @zq2209 ! a few comments:

#from qvalue import qvalue when it is something we surely don't use, don't feel bad to remove it. If you want this piece of code to be retrievable you can always give an informative commit message or to tag it so it lives in github history
#pairs_df.columns.values[13]  = "pvalue" + '_' + var_interaction + '_' + 'interaction' I prefer to make the change here, then remove this line: names(pairs_df)[which(colnames(pairs_df) == "pval_gi")] = paste0('pvalue_', var_interaction, '_interaction') you can achive this in SoS right? like $["pvalue_%s_interaction" % var_interaction] in place of pval_gi in your R codes.

  if ($['FALSE' if permutation and pval_threshold < 1.0 else 'TRUE']){
      pairs_df = pairs_df %>% group_by(molecular_trait_id) %>% mutate(qvalue = qvalue(pvalue)$qvalues)

too late to check it here. You should remove this if statement, but check it like:
stop_if(...)
R: expand= "$[ ]", stderr = f'{_output[0]}.stderr', stdout = f'{_output[0]}.stdout',container =container, entrypoint = entrypoint
...

we have used something like this logiic previoulsly right? Please learn from that and adopt.


Client generated from API does not contain FileResponse

I tried generating a C# Winx64 Client from API located at https://developer.allegro.pl/swagger.yaml using NSwag GUI. No matter which generation mode I choose, I always get code which references FileResponse in one of the methods but there's no FileResponse class generated in the output. The offending API method /sale/dispute-attachments/{attachmentId} is described as returning type */*.

Is this related to form data?

I'm not sure how I should respond to this. The API is provided by third party, it does not designate usage case limits, my use case is backend application and the problem is with generating client from Swagger YAML that I am using to access this API.
Here's the excerpt generating FileResponse reference:
paths:
  '/sale/dispute-attachments/{attachmentId}':
    put:
      tags:
        - Disputes
      summary: "Upload a dispute message attachment"
      description: >-
        Upload a dispute message attachment.

        This operation should be used after creating an attachment declaration with *POST /sale/dispute-attachments*

        **Important!** You can find the URL address to upload the file to our server in the *Location* response header of *POST /sale/dispute-attachments*.
        The URL is unique and one-time. As its format may change in time, you should always use the address from the header.
        Do not compose the address on your own.

      operationId: uploadDisputeAttachmentUsingPUT
      parameters:
        - name: attachmentId
          in: path
          required: true
          description: Attachment identifier.
          schema:
            type: string
            format: uuid
      servers:
        - url: https://upload.{environment}
          variables:
            environment:
              default: allegro.pl
              enum:
                - allegro.pl
                - allegro.pl.allegrosandbox.pl
      responses:
        '201':
          description: File uploaded correctly
        '400':
          description: Syntactically incorrect request
        '401':
          description: Invalid or missing bearer token
        '413':
          description: File is too big
        '415':
          description: Unsupported media type
      requestBody:
        required: true
        content:
          image/png:
            schema:
              type: string
              format: binary
              description: File in a binary format
          image/gif:
            schema:
              type: string
              format: binary
              description: File in a binary format
          image/bmp:
            schema:
              type: string
              format: binary
              description: File in a binary format
          image/tiff:
            schema:
              type: string
              format: binary
              description: File in a binary format
          image/jpeg:
            schema:
              type: string
              format: binary
              description: File in a binary format
          application/pdf:
            schema:
              type: string
              format: binary
              description: File in a binary format
    get:
      tags:
        - Disputes
      summary: "Get an attachment"
      description: >-
        Use this resource to get an attachment. Read more.
      operationId: getAttachmentUsingGET
      parameters:
        - name: attachmentId
          in: path
          description: Attachment identifier.
          required: true
          schema:
            type: string
            format: uuid
      responses:
        '200':
          description: OK
          content:
            '*/*':
              schema:
                type: string
                format: binary
        '401':
          description: Unauthorized
        '403':
          description: Forbidden
        '404':
          description: Not Found

NSwag config
{
  "runtime": "WinX64",
  "defaultVariables": null,
  "documentGenerator": {
    "fromDocument": {
      "json": "...",
      "url": "https://developer.allegro.pl/swagger.yaml",
      "output": null
    }
  },
  "codeGenerators": {
    "openApiToCSharpClient": {
      "clientBaseClass": "BaseAllegroClient",
      "configurationClass": null,
      "generateClientClasses": true,
      "generateClientInterfaces": false,
      "clientBaseInterface": null,
      "injectHttpClient": true,
      "disposeHttpClient": true,
      "protectedMethods": [],
      "generateExceptionClasses": true,
      "exceptionClass": "{controller}ApiException",
      "wrapDtoExceptions": true,
      "useHttpClientCreationMethod": false,
      "httpClientType": "System.Net.Http.HttpClient",
      "useHttpRequestMessageCreationMethod": true,
      "useBaseUrl": false,
      "generateBaseUrlProperty": true,
      "generateSyncMethods": false,
      "exposeJsonSerializerSettings": true,
      "clientClassAccessModifier": "public",
      "typeAccessModifier": "public",
      "generateContractsOutput": false,
      "contractsNamespace": null,
      "contractsOutputFilePath": null,
      "parameterDateTimeFormat": "s",
      "parameterDateFormat": "yyyy-MM-dd",
      "generateUpdateJsonSerializerSettingsMethod": true,
      "useRequestAndResponseSerializationSettings": false,
      "serializeTypeInformation": false,
      "queryNullValue": "",
      "className": "Allegro{controller}Client",
      "operationGenerationMode": "SingleClientFromOperationId",
      "additionalNamespaceUsages": [],
      "additionalContractNamespaceUsages": [],
      "generateOptionalParameters": true,
      "generateJsonMethods": false,
      "enforceFlagEnums": false,
      "parameterArrayType": "System.Collections.Generic.IEnumerable",
      "parameterDictionaryType": "System.Collections.Generic.IDictionary",
      "responseArrayType": "System.Collections.Generic.ICollection",
      "responseDictionaryType": "System.Collections.Generic.IDictionary",
      "wrapResponses": true,
      "wrapResponseMethods": [],
      "generateResponseClasses": true,
      "responseClass": "{controller}Response",
      "namespace": "Allegro_Payout.Clients",
      "requiredPropertiesMustBeDefined": true,
      "dateType": "System.DateTimeOffset",
      "jsonConverters": null,
      "anyType": "object",
      "dateTimeType": "System.DateTimeOffset",
      "timeType": "System.TimeSpan",
      "timeSpanType": "System.TimeSpan",
      "arrayType": "System.Collections.Generic.ICollection",
      "arrayInstanceType": "System.Collections.ObjectModel.Collection",
      "dictionaryType": "System.Collections.Generic.IDictionary",
      "dictionaryInstanceType": "System.Collections.Generic.Dictionary",
      "arrayBaseType": "System.Collections.ObjectModel.Collection",
      "dictionaryBaseType": "System.Collections.Generic.Dictionary",
      "classStyle": "Poco",
      "generateDefaultValues": true,
      "generateDataAnnotations": true,
      "excludedTypeNames": [],
      "excludedParameterNames": [],
      "handleReferences": false,
      "generateImmutableArrayProperties": true,
      "generateImmutableDictionaryProperties": true,
      "jsonSerializerSettingsTransformationMethod": null,
      "inlineNamedArrays": false,
      "inlineNamedDictionaries": false,
      "inlineNamedTuples": true,
      "inlineNamedAny": false,
      "generateDtoTypes": true,
      "generateOptionalPropertiesAsNullable": true,
      "templateDirectory": null,
      "typeNameGeneratorType": null,
      "propertyNameGeneratorType": null,
      "enumNameGeneratorType": null,
      "serviceHost": null,
      "serviceSchemes": null,
      "output": "AllegroClient.cs"
    }
  }
}

Method generated from above request:
public async System.Threading.Tasks.Task<FileResponse> GetAttachmentUsingGETAsync(System.Guid attachmentId, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken))

I encountered the same error, but for Typescript client

I had the same issue when used UseOneOfForPolymorphism method.

Any news on this?


Layout not working

The Floating Action Button Layout corrupts the layout of the first child.

Fixed by laying out the Sliding Up Panel every time and by changing LayoutParams.


[NEW] GitHub Component Kit

[x] I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
[x] I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works (if applicable)
[x] I have added necessary documentation (if applicable)
[x] Any dependent changes have been merged and published in downstream modules

Issues
Mentioned in the issue #90
Proposed changes (including videos or screenshots)

Improved database schema for re-usability of component for different repositories.
Improved data fetching method in cms (can be re-used when switching from strapi) to provide a better experience for community builders. All data fetching for  the github kit for a repository will be done by a a single githubKit() function.
Replacing individual component tags with a <Github ... > tag which can be used to fetch different components of the kit depending on props/parameters. <Github type={'contributors'} githubData={props.githubData} />
Improve github helper functions (which fetch data from the cms into our application) into a single githubKitData(owner ,name ,[..needs]) function which can fetch relevant data based on the components we wish to use on a particular page.
New Pull Request Component

New Repository overview component

Updated  Documentation  . P.S. Refer to the documentation for changes in usability.

@Sing-Li I have made some changes and removed the unnecessary code, it would be great if you could review the pull request.

@Sing-Li I have made the requested changed :

Removed the changes to the index.js file.
Created a demo page for  the Github Component Kit which can be accessed on the route /github .
Removed .package-lock.json file .


Debug codecov issues

Debugging GitHub actions for uploading codecov report. Unittest actions have been failing since switching to using the codecov-action v4 in #758 .
Codecov uploads have sporadically been failing due to rate-limiting of 'tokenless' uploads.  It is not actually tokenless, see explanation below.

If Codecov detects that reports are being uploaded from a fork of an open source repository, Codecov will automatically switch to tokenless uploading...Token-less uploads still use a token to upload to Codecov - just that it's Codecov's Github token instead of the project's own. As such, uploading to Codecov via tokenless (whether it's via forks, or by an older version of the Codecov action) ends up consuming from the shared request pool of a lot of Codecov users, instead of your own. Therefore, there may be cases when uploading to Codecov via tokenless fails because Codecov is being rate limited. Source

This issue has been documented by others:
https://github.com/codecov/feedback/issues/358
https://github.com/codecov/feedback/issues/301
https://github.com/codecov/feedback/issues/112

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.21%. Comparing base (d28ddb7) to head (c084c47).
 Consider uploading reports for the commit dec481a to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #759       +/-   ##
===========================================
- Coverage   92.67%   60.21%   -32.47%
===========================================
  Files          27       27
  Lines        4928     4969       +41
===========================================
- Hits         4567     2992     -1575
- Misses        361     1977     +1616

Flag
Coverage Δ

unittests
60.21% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

One option is changing the setting fail_ci_if_error = false. This will not fail the test if the coverage isn't uploaded. There just won't get a coverage report.

Bash implementation doesn't fail. I don't think it generated a new report though.
Bash uploader is being deprecated, though there has been no indication on when they are fully deprecating it.
https://docs.codecov.com/docs/about-the-codecov-bash-uploader

Closing because this was just used to debug workflows.


BUG: lambertw returns nan's on small values

Describe your issue.
For very small values (i.e. between 1e-323 and 1e-316), scipy.special.lambertw returns nans on the default branch (k=0) with the default tolerance (tol=1e-8).
Reproducing Code Example
import scipy.special
print(scipy.special.lambertw(1e-316))

Error message
When the above is run, it outputs the following:

(nan+nanj)

SciPy/NumPy/Python version information
1.8.0 1.21.5 sys.version_info(major=3, minor=9, micro=12, releaselevel='final', serial=0)

Hi @cjtosh, thank you for reporting. Isn't this past float precision?

A proposed fix: https://github.com/scipy/scipy/pull/17545


MSG200 cannot hide garage doors on inactive ports

I am using MSG200 in combination with Homebridge to enable HomeKit control of my garage door openers. Everything is set up and working fine, but the MSG200 device supports 3 garage door openers and I only have 2. Unfortunately, when I connect this plugin (homebridge-meross v10.0.0) to HomeKit, all 3 garage door openers populate within the Apple Home app even though I have marked the 3rd door as "Inactive" within the Meross app. Is there a setting in the Homebridge plugin that would allow me to prevent the unused 3rd door from being exposed to HomeKit?
Not being able to hide this 3rd "door" is an issue because although I have removed it from the Home View and put it in an unused room of the Home app, Siri regularly surfaces it as a recommended device on my CarPlay interface and on widgets because it is recognized as an open door.
============================
Details of your setup.
Do you use (1) Homebridge UI-X (2) Homebridge CLI or (3) HOOBS?
Homebridge UI-X
Which version of Homebridge/HOOBS do you have?
v4.52.3
Which platform do you run Homebridge/HOOBS on (e.g. Raspberry Pi/Windows/HOOBS Box)? Please also mention your version of Node.js/NPM if known.
Docker container on my Synology NAS
Node.js v20.9.0
Which version of this plugin (homebridge-meross) do you have? Has the issue started since upgrading from a previous version?
v10.0.0, no present from initial setup
Which Meross devices do you have that are causing issues? Please include product models if applicable.
MSG200 (not MSG200HK which has native HK compatibility)
Hardware Version 2.0.0
Firmware Version 2.1.3

I have this issue as well.  A 3rd "Smart Garage Door Opener" device is added to Homebridge when Meross is connected when I only have 2 garage doors enabled on the MSG200.  3rd device does not appear in Alexa app, only the 2 garage doors that are enabled in the Meross app.

After installing the MSG200 to operate both my garage doors, I have found that the Meross to Homebridge translation is off more than just acknowledging the 3rd door is disabled.
Here are the issues I see:
The MSG200 has 3 ports, labeled 1, 2, and 3 on the unit.  In the Meross app, these match up to Garage Door 1, Garage Door 2, and Garage Door 3, respectively, as default names.
When I installed the MSG200 in the garage and hooked up the port 2 garage door first, which is Garage Door 2 in the Meross app,  HomeKit reported that Garage Door 1 was closed.  Garage Door 2 in HomeKit did not open/close the door and did not see the sensor state.  When I got to hooking up the wiring for port 1, which is Garage Door 1 in the Meross app, HomeKit reported that "Smart Garage Door Opener" was closed.  There is no door named "Smart Garage Door Opener" in the Meross app, and I had assumed this name in HomeKit is what it was showing for the disabled Garage Door 3, but apparently not. When I tap "Smart Garage Door Opener" in HomeKit, Garage Door 1 opens/closes and sensor state is seen.  And no, I did not change the names in the HomeKit app, just used what Homebridge assigned.
So in summary, the mapping from Meross to HomeKit is out of whack as follows:
Meross app Port 1/Garage Door 1 ----> HomeKit Smart Garage Door Opener
Meross app Port 2/Garage Door 2 ----> HomeKit Garage Door 1
Meross app Port 3/Garage Door 3 ----> HomeKit Garage Door 2
I have disabled the Meross plugin and removed the cached garage doors just to see if anything changed, but it went back  to the same wrong mapping.

Yeah I had the same confusion with the inconsistent garage door naming scheme between Homebridge and the Meross app but came to the same conclusion after a little bit of trial and error.

Hi all,
Specific channels of the garage opener can be ignored/removed via the plugin settings

As for the strange naming schema, could be an issue with how the plugin gets the channel names, will get back to you

Hi all,
Specific channels of the garage opener can be ignored/removed via the plugin settings

As for the strange naming schema, could be an issue with how the plugin gets the channel names, will get back to you

Thank you! This seemed to fix the problem. I have the connection type set to Hybrid up top. Should I set the same here or just leave as default None?

You can leave that as 'None'.
Could you do me a favour and update to the beta version of the plugin?
https://github.com/homebridge/homebridge/wiki/How-to-Install-Alternate-Plugin-Versions
Once installed and restarted, check the homebridge logs, you should see a big red section of text (its not an error, its info about your MSG200).
Would you be happy to copy and paste this here? You can remove any device IDs / IPs etc.
Just want to see the structure to be able to correctly parse the channel names.

[12/3/2023, 5:44:03 PM] [Meross] {"uuid":"[REDACTED]","onlineStatus":1,"devName":"Smart Garage Door Opener","devIconId":"ms_device_gdo_sel_close","bindTime":1699825586,"deviceType":"msg200","subType":"un","channels":[{},{"type":"GarageDoor","devName":"Garage Door 1","devIconId":"device061_un"},{"type":"GarageDoor","devName":"Garage Door 2","devIconId":"device061_un"},{"type":"GarageDoor","devName":"Garage Door 3","devIconId":"device061_un"}],"region":"us","fmwareVersion":"2.1.3","hdwareVersion":"2.0.0","userDevIcon":"","iconType":1,"domain":"mqtt-us-2.meross.com","reservedDomain":"mqtt-us-2.meross.com","hardwareCapabilities":[],"firmware":"2.1.3","hbDeviceId":"[REDACTED]","model":"MSG200"}

This worked for a while but after the recent API update, I am again unable to hide "Garage Door 2" in Homekit (which corresponds to Port 3 in the Meross app).
Please see Homebridge Logs below:
[12/24/2023, 11:11:47 PM] [Meross] Restarting Process...
[12/24/2023, 11:11:47 PM] [Meross] Launched child bridge with PID REDACTED
[12/24/2023, 11:11:48 PM] Registering platform 'homebridge-meross.Meross'
[12/24/2023, 11:11:48 PM] [Meross] Loaded homebridge-meross v10.2.3 child bridge successfully
[12/24/2023, 11:11:48 PM] Loaded 3 cached accessories from cachedAccessories.0EDF51C9AEE6.
[12/24/2023, 11:11:48 PM] [Meross] Initialising plugin v10.2.3 | System linux | Node v20.10.0 | HB v1.7.0 | HAPNodeJS v0.11.1...
[12/24/2023, 11:11:48 PM] [Meross] Config entry [garageDevices] has an invalid entry which will be ignored.
[12/24/2023, 11:11:48 PM] [Meross] Plugin initialised. Setting up accessories....
[12/24/2023, 11:11:48 PM] Homebridge v1.7.0 (HAP v0.11.1) (Meross) is running on port REDACTED.
[12/24/2023, 11:11:48 PM] [Meross] [Smart Garage Door Opener] initialising with options {"connection":"hybrid","garageDoorOpeningTime":20}.
[12/24/2023, 11:11:48 PM] [Meross] [Garage Door 1] initialising with options {"connection":"hybrid","garageDoorOpeningTime":20}.
[12/24/2023, 11:11:48 PM] [Meross] [Garage Door 2] initialising with options {"connection":"hybrid","garageDoorOpeningTime":20}.
[12/24/2023, 11:11:48 PM] [Meross] [Smart Garage Door Opener] initialised with id [REDACTED}].
[12/24/2023, 11:11:48 PM] [Meross] ✓ Setup complete. This plugin has been made with ♥ by bwp91, please consider a ☆ on GitHub if you are finding it useful!

This worked for a while but after the recent API update, I am again unable to hide "Garage Door 2" in Homekit (which corresponds to Port 3 in the Meross app).
Please see Homebridge Logs below:
[12/24/2023, 11:11:47 PM] [Meross] Restarting Process... [12/24/2023, 11:11:47 PM] [Meross] Launched child bridge with PID REDACTED [12/24/2023, 11:11:48 PM] Registering platform 'homebridge-meross.Meross' [12/24/2023, 11:11:48 PM] [Meross] Loaded homebridge-meross v10.2.3 child bridge successfully [12/24/2023, 11:11:48 PM] Loaded 3 cached accessories from cachedAccessories.0EDF51C9AEE6. [12/24/2023, 11:11:48 PM] [Meross] Initialising plugin v10.2.3 | System linux | Node v20.10.0 | HB v1.7.0 | HAPNodeJS v0.11.1... [12/24/2023, 11:11:48 PM] [Meross] Config entry [garageDevices] has an invalid entry which will be ignored. [12/24/2023, 11:11:48 PM] [Meross] Plugin initialised. Setting up accessories.... [12/24/2023, 11:11:48 PM] Homebridge v1.7.0 (HAP v0.11.1) (Meross) is running on port REDACTED. [12/24/2023, 11:11:48 PM] [Meross] [Smart Garage Door Opener] initialising with options {"connection":"hybrid","garageDoorOpeningTime":20}. [12/24/2023, 11:11:48 PM] [Meross] [Garage Door 1] initialising with options {"connection":"hybrid","garageDoorOpeningTime":20}. [12/24/2023, 11:11:48 PM] [Meross] [Garage Door 2] initialising with options {"connection":"hybrid","garageDoorOpeningTime":20}. [12/24/2023, 11:11:48 PM] [Meross] [Smart Garage Door Opener] initialised with id [REDACTED}]. [12/24/2023, 11:11:48 PM] [Meross] ✓ Setup complete. This plugin has been made with ♥ by bwp91, please consider a ☆ on GitHub if you are finding it useful!

Disregard... fixed after updating to v10.3.0
Thanks to the devs for quickly addressing these API changes!


Consolidated ValueAccessor implementations

Signed-off-by: Nick Avramoussis<EMAIL_ADDRESS>

I deployed this on our build farm and all of our current tool compilers successfully compiled it....  So that's a pretty good sign.


Support for aria on SvgIcon

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔
I have created a button with an icon, which is basically:
<Button>
  <SignUpIcon />

Sign up to MyWebsite

</Button>

where <SignUpIcon /> is an SVG icon created using MUI's <SvgIcon> component.
Since the icon is purely presentational and is described by the button text, I would like to add aria attributes to the SvgIcon component to reflect this, such as aria-labelledby or aria-hidden.
Current Behavior 😯
This is currently unsupported in MUI v4.0.0-beta.0
Examples 🌈
https://next--material-ui.netlify.com/api/svg-icon/

Nevermind, I see in the implementation that this is handled automatically depending on whether or not the titleAccess prop is defined.


Data fetching from WIFI take extremely large time.

Details
I was building an app that fetch data from Node||MongoDb sever (implement JWT token also). I have notice that when I am running my app in real device using WIFI my data fetching take lot of time but when I switch back to Phone internet (decent 4g network) it work extremely fast.
My wifi speed is good and also when i am using emulator into my system data load faster on same wifi.

Target Platform:
Android
Target OS version/browser:
Android 12
Devices:
Realme Narzo 50 && One plus 7
Logs
So while checking the issue I encounter one warnging when ever data take more time to laod but didnot understand what make this happen.

time difference on wifi vs 4g network is pretty much. on 4g network it take around 100 to 400 milisecond max but on wifi its like 10000 to 12000 millisecond.

@AyushTripathi28
The difference could most probably due to ipv4 and ipv6 requests.
See this comment for your reference and make sure your app is using the suitable internet protocol version which should resolve the issue.
With that being said, I am going ahead and closing it. If you disagree, write in comments and I'll reopen it.