Checked out PRs are not preloaded in VS Code desktop when using GitHub Repositories

This works as expected in web provided you're looking at a url like https://insiders.vscode.dev/github/microsoft/vscode/pull/163305, because the id 163305 gets passed in correctly. On desktop the id ends up being the branch name which is not correct, and that causes GitHub Repositories to not run the preload command to focus GHPRI's review mode. This is possibly an issue in GitHub Repositories, still investigating...

This appears to work correctly for PRs from forks, but not for PRs where the branch exists on the current repository.

Interestingly, this works correctly if I use Open Remote Repository > Open Pull Request from GitHub but doesn't work if I right click on a PR from the GitHub tree view and select Checkout Pull Request.

@joyceerhl do you mean that github.api.preloadPullRequest is not executed? I tried this out on desktop and that's what I see (github.api.preloadPullRequest isn't executed).
I don't think there's anything I can do from the GHPRI side to make the preload command call happen.
What I can do:

When a PR is checked out I can persist some state about the intended branch.
On extension activation I can check for that state and do the "preload".
On every extension activation/branch change I can delete that state.

@joyceerhl before I make this change: is there any plan to remove the window reload when checking a branch on desktop, since that would also solve this issue?

I discovered that github.api.preloadPullRequest is executed for PRs across forks e.g. https://github.com/microsoft/vscode/pull/168273, because with remote PRs, GHPRI calls checkout with a branch of the format pr/<remote>/<pr ID>, and RemoteHub does the right thing with that.
But for PRs on the current repo, GHPRI calls checkout passing just the branch name, and in that case RemoteHub's impl of checkout just checks out the branch without setting the workspace to indicate that the PR should be checked out. Since Checkout Pull Request indicates a clear intent to focus the PR and not just check out the branch, could GHPRI pass pr/origin/<PR number> to the checkout call (which I verified does fix the problem), or would this be a breaking change for desktop?
Alternatively, does GHPRI have code to check whether there is a PR associated with the current branch so it can independently decide to open the PR view even if RemoteHub isn't calling github.api.preloadPullRequest?

is there any plan to remove the window reload when checking a branch on desktop

This cannot happen without https://github.com/microsoft/vscode/issues/35109 (though I'm unsure what blockers exist for that now).

Alternatively, does GHPRI have code to check whether there is a PR associated with the current branch so it can independently decide to open the PR view even if RemoteHub isn't calling github.api.preloadPullRequest?

We already detect this, but we can't use it to open the view on reload as it would be overly eager and open on reload even when not checking out a PR.

could GHPRI pass pr/origin/ to the checkout call (which I verified does fix the problem), or would this be a breaking change for desktop?

I'll try it out and see.

Passing pr/origin/<PR branch> to the checkout call would be a breaking change since that wouldn't be referencing a branch that exists on desktop. I'll try the proposal outlined in https://github.com/microsoft/vscode-pull-request-github/issues/4047#issuecomment-1344058790


404 Not Found after using the library

Hello,
I added the library to the project, called the method, and also set the base href on index.html.
main method
setPathUrlStrategy();
and
 <base href="/">
after it was added when the user wanted to redirect or open a URL before this it works but now
I face this issue

Hey @AliKarimiENT
This issue is outside of our control.
It looks like your webserver doesn't properly rewrite all URL paths to the index.html.
Only when this is done the internal routing of the Flutter engine is used.


Consider Moving to mysql-connector

The current dependency "mysqlclient==1.4.2" relies on C libraries to compile the Python byte code.  The mysql-connector-python library doesn't have an C library dependencies: https://pypi.org/project/mysql-connector-python/

@kevensen Can you add some context how this benefits us in a GKE deployment? IIRC relying on the C lib means you had to make some considerations for this dependacy.

I think this would benefit both the GCE and GKE deployments.  The fewer dependencies you install in a host or container, the smaller the surface of attack.
In the case of GKE, it's one less package installed resulting in a smaller container image (every MB makes a difference :-) ).  It's shorter time building the images as well.

If opting for BigQuery as a data store, this is moot.

If I understand correctly, Forseti will continue to use MySQL as a data store.  I think we should continue to  consider this.

This will enable us to use distroless containers.

We implemented PyMySQL.  This can be closed.


export all types in typescript declaration file and work around the fact typescript can't handle union of promise type

Export all types in typescript declaration file.
So they can be imported into applications.
Work around the fact typescript can't handle union of promise type.
Because typescript can't figure out Promise<void | string> equals Promise<void> | Promise<string>

Thanks, it will be released as soon as I check all the dependencies up-to-date.


⚠ Bofrost.at has degraded performance

In 4176c31, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2374 ms

Resolved: Bofrost.at performance has improved in 3447130 after 10 minutes.


cargo-fmt: don't return zero on failure

Previously cargo-fmt always returned 0 exit status. Now it returns 1 if command line flags are wrong and forwards status code of rustfmt oherwise

Thanks for the PR! Looks good, r+ with the style nit addressed.

wait a moment, there is an unused variable left!

wait a moment, there is an unused variable left!

Fixed and slapped #[deny(warnings)] to avoid future embarrassments.

Thanks for the changes!


Swap time.clock to time.monotonic

time.clock is deprecated and has been removed in Python3.8.
This changes all references to time.monotonic, which is equivalent
Related issue: #274

@fmneto thanks -- as it turns out I just noticed that yesterday myself!  I was thinking that time.monotonic was probably the better alternative, but I'm not sure I have a strong preference.

That does sound like a better alternative; I've updated things to make the proper changes.

@fmneto thanks!! That looks great. Merging...

Glad to help.
To contextualize, this came up while preparing larch for packaging in Debian.


php.buildEnv: Don't inherit dev from the original php

Motivation for this change
mkDerivation uses the dev output in buildInputs if it exits, hence the php-with-extensions package was never built or put into the path of packages dependent on it during build.
With this fix, the php packages built with buildEnv or withExtensions don't have any dev outputs; packages which need the dev output can refer to the phpXXbase packages instead.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

awesome, thanks!


Transports and excludeCredentials

[IOS] Is there any way to specify available transports for a key and sort keys by excludecredentials ?

anyone working on this?

Will be released in the next update.


Autocomplete keyboard doesn't persist when you click item on list

💬 Question
I am facing this similar issue as this, where the keyboard gets dismissed when I click an item in the autocomplete list, or an icon within the textinput field. Is there a prop that I can use to persist the keyboard open when you click on the popover or textinput? I read all documentation and read inside code, but it looks like such functionality is not exposed to the component.
UI Kitten and Eva version

Package
Version

@eva-design/eva
2.0.0

@ui-kitten/components
5.0.0

@naegahyung thanks for the interest and pointing on the related issue.
I guess it's not possible in current version, here is what's blocking it.
I think adding keyboardShouldPersistTaps is a good idea for components like this.

I just had the same issue.   And a positioning issue.
Would love for these this to be fixed/added.

@GantMan

And a positioning issue

Please see #743

Position issue fixed!  Thanks for the link.

+1 to adding keyboardShouldPersistTaps

keyboardShouldPersistTaps='always' was added within https://github.com/akveo/react-native-ui-kitten/pull/1423
and released with the v5.1.1


Don't "break" from selection constructs.

If seems like at least 1 driver does not like a condition jump to the end
of a selection construct.  We are generating these in the merge return
pass.  This change stops merge return from generating this sequence.
Part of #1861.

@dnovillo Done.


use pkg config on macos too

previously:
error: failed to run custom build command for `ac-ffmpeg-features v0.1.0`

Caused by:
  process didn't exit successfully: `[...snip...]/target/debug/build/ac-ffmpeg-features-61bfed659e0637da/build-script-build` (exit status: 101)
  --- stdout
  cargo:rerun-if-env-changed=FFMPEG_INCLUDE_DIR_X86_64_APPLE_DARWIN
  cargo:rerun-if-env-changed=FFMPEG_INCLUDE_DIR

  --- stderr
  thread 'main' panicked at 'Unable to find FFmpeg include dir. You can specify it explicitly by setting the FFMPEG_INCLUDE_DIR environment variable.', [...snip...]/ac-ffmpeg-build/src/lib.rs:16:10
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

with this change it correctly finds ffmpeg

cc @operutka

Hi @bavardage and thank you for your PR. No objections here. I'm merging it.


Add NO_PROXY environment variable to Blazor Debugging Troubleshooting section

In a corporate environment, users may have a HTTP proxy server set via the HTTP_PROXY and/or HTTPS_PROXY environment variables. We have found that if localhost has not been added as a value to the NO_PROXY environment variable, the Blazor debugger may fail to start, especially if the HTTP proxy server requires authentication.
Can this information be added to the Troubleshooting section of the Blazor Debugging documentation?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ec2f61c7-9f51-6735-e328-3c7b495d70c3
Version Independent ID: 4d06e565-282d-6387-aa90-cb2c2986d35a
Content: Debug ASP.NET Core Blazor WebAssembly
Content Source: aspnetcore/blazor/debug.md
Product: aspnet-core
Technology: aspnetcore-blazor
GitHub Login: @guardrex
Microsoft Alias: riande

It's sounds a bit edgy-ish to me :smile:, but let's ask @captainsafia about it.

I agree its a bit edgy-ish but due to the unhelpful error message thrown when the debugger fails to start:

One or more errors occurred.
Failed to launch debug adapter. Additional information may be available in the output window.
Exception of type 'Microsoft.VisualStudio.Shared.VSCodeDebugProtocol.ProtocolException`

With not much more useful information included in the VS debugger log file to indicate what was happening, I feel some troubleshooting hints to check HTTP proxy settings would be helpful. We spent 2 days bagging our heads against the wall trying figure out what was causing the debugger to not start, not realizing that the debugger requests were being erroneously redirected to the HTTP proxy.

Thanks for bringing this up, @AdrianSanguineti!
Agree this is a little edgy-ish. However, I'm actually in favor of adding these docs to the debugging page. I think we've had a few users report this issue over on the aspnetcore repo so it'll help reduce our triage burden if we have it documented somewhere.

@AdrianSanguineti ... Do you want to open a PR against the doc and add the base content?

Thanks,

I think we've had a few users report this issue over on the aspnetcore repo so it'll help reduce our triage burden if we have it documented somewhere.

Those reports are exactly what made us realize our mistake, which is why I'm suggesting this. So good to see you agree!
@guardrex, unfortunately for the same reasons why I'm behind a HTTP proxy (corporate environment), I unable to clone a github repository right now. Our organisation's security only lets us access github from workstation that we can't use any DEV tools on, but only from the browser, which is why I can raise this issue.
I know it's stupid, but unfortunately that the situation I'm in, with the result being that all .NET Core development has been 20 times harder than it should be due to poor handling of HTTP proxy at the framework level since the sockets code was made cross platform, especially when it comes to proxies that uses Windows Authentication.
It therefore might be a couple of days before I'm in a position where I'm in a location where I can clone the repo to make the change and have the time to do so.

You don't need to do that. Select the pencil icon link on the live topic. You can edit the topic directly on a branch created for you and submit the PR that way.

Just provide a few sentences in a new bullet point in that section that you think would've saved you in this scenario. We'll edit it from there.

@guardrex, thanks - I did not know that was possible now, (or haven't really paid attention enough). I've add some base content.


Fix Cargo.toml ark-relations branch setting

Remove Cargo.toml setting that sources ark-relations from an old deleted branch. A one line change that was supposed to be included in previous commit.

awesome, thanks!


Typo-squatted aks[.]ms domain input by mistake

Correct to aka.ms: https://aka.ms/appservice-vnet-service-endpoint

@timwarner-msft
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

The change indicated in this PR is consistent with other links in the article, and the edit changes a nonworking link to a working link. I'll merge the PR.


WIP: Refactor and strip down Aries transport abstraction

Develops on commits from #1029
Hence WIP, otherwise it's ready for review.

We're currently processing your upload.  This comment will be updated when the results are available.

Hi Naian, indeed as you sugggested, if you base this on https://github.com/hyperledger/aries-vcx/pull/1029 I can do review for this before 1029 is merged


My Deck disappeared after updating the game

After updating the game, I opened deck menu and nothing appear and the game was broken.
So I deleted the Build folder and extracted the zip one, I can play it again.
Any tips if something like this happen again after updating the game?
Thank you

The user data files are located here:
/Build/Data/Player.json
/Build/Data/Decks/*.json
Creating a backup of these and copying them over to the updated folder should work. I may consider saving the user data to a separate location in the future as I could see this being a bit annoying.

I already backup those files, so its good. Should I close this issue?

If copying those over solves the issue then it can be closed, yea. If that doesn't work then you could zip up your player.json / decks folder and I could take a look to see what's wrong.

Thank you


make sure CLI works for namespaced knex packages as well

by passing and extra property to liftoff. Without this change when using a namespaced knex like @capaj/knex CLI won't run

@elhigu Is anything missing here?

I really don't know / understand this change from top of my head :) I suppose it works, but problem with cli changes currently is that we don't have any tests that cli doesn't get broken because of the change. I've been postponing merging any of the cli related PRs, until there are some tests in place.

@elhigu would be nice to have at least a single happy path test, even if it only calls the CLI without any arguments and asserts that it exited with
  Usage: knex [options] [command]

  Options:

    -V, --version                  output the version number
    --debug                        Run with debugging.
    --knexfile [path]              Specify the knexfile path.
    --cwd [path]                   Specify the working directory.
    --env [name]                   environment, default: process.env.NODE_ENV || development
    -h, --help                     output usage information

  Commands:

    init [options]                         Create a fresh knexfile.
    migrate:make [options] <name>          Create a named migration file.
    migrate:latest                         Run all migrations that have not yet been run.
    migrate:rollback                       Rollback the last set of migrations performed.
    migrate:currentVersion                 View the current version for the migration.
    seed:make [options] <name>             Create a named seed file.
    seed:run                               Run seed files.
Unknown command-line options, exiting

I have nothing against of this change. Its good to support that use case.
Only that I really like to have some test for this (at least that official knex still works fine). I still haven't got time to think how exactly commandline client testsuite should be implemented... there are maybe 3 PRs on hold waiting for those tests...

@capaj Considering that we have system for CLI integration tests in place now, do you think it is possible to create some for this PR?

@kibertoad Sure. Let me see if I can get to it this week.

@capaj Any updates on this :)?

@capaj Status update?

@capaj To think about it, it's unlikely that tests are necessary here, so this can be merged after rebasement.

@capaj Any chance you could rebase this?

@kibertoad you've got it.

Thanks!

Released in 0.20.3


Add faster vline and hline functions

These new functions are much faster than the older line implementations. The native runtime's hline is slightly more efficient because it tries to update all the byte-aligned pixels directly with memset. We could definitely do this slightly better using Sink::set_item_at (or a new Sink::fill_range?), but I was unable to get it working today. Regardless, these new implementations are much better.

Okay I've included those changes, hline fills the individual bytes now. remap_draw_color was also refactored. Now, instead of (u8, true), it returns Option<u8>, which is much closer to the way that the result is actually used and the code it creates is much cleaner.

I've finished your requested changes on hline and it seems to work correctly. I'm going to merge this pull request for the sake of brevity so we can move forward, if you disagree with the changes I'm definitely open to discussion.


Users Not Getting Points when Live

I have configured this bot exactly as outlined in the Wiki, and everything seems to be functioning (overlay, modules, etc), except users are not gaining points when the streamer is live.
Is there additional steps to enable the point system?
Let me know if I can provide anything else. Thanks.
Version: 2.8.1 DEV (master, 80c77670, commit 1480)

Hey, I had to disable the point-system when running too many bots so I built another tool for it.
To enable points again, just remove the return on line 30 in pajbot/modules/chatters.py
https://github.com/pajlada/pajbot/blob/eed0584a91662192f1d8f8f96e7c9d5f5fb6304b/pajbot/modules/chatters.py#L30
The tool I use to update points and stuff is https://github.com/pajlada/chatters but it doesn't make much sense to use unless you run a lot of bots
Let me know if this works as expected!

So, this seems to give the expected results. :+1:
Do you recommend I configure pajlada/chatters to do this for me?

If you run more than one bot on one machine I suggest you set up
pajlada/chatters, otherwise just stick with pajbot
On Sep 17, 2016 22:14, "smashedr"<EMAIL_ADDRESS>wrote:

So, this seems to give the expected results. 👍
Do you recommend I configure pajlada/chatters to do this for me?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/pajlada/pajbot/issues/315#issuecomment-247804785, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA6xraMHh0SEG2WX-92SWIwmV1dSHbiEks5qrEoKgaJpZM4J_dup
.


R134a media - differentiation problems

Reported by johan.windahl on 26 Sep 2014 16:25 UTC
Hello,
I noted that the implementation of Modelica.Media.R134a.R134a_ph.setState_phX is not using the same structure as in most of the other Modelica.Media setState_XXX implementations where the state is calculated in one line.
Implementing the expression in one line has the advantage that a tool (Dymola) can differentiate even that the function itself do not specify an derivative annotation (which is not possible due to the record contains both reals and non-reals), see example below:
model TestDifferentiation
  // This example will not work with R134a due to the code in setState_phX is not written in one row
  // but it will work with Medium=Modelica.Media.Water.WaterIF97_ph
   package Medium=Modelica.Media.R134a.R134a_ph;
   Medium.ThermodynamicState state;
   Modelica.SIunits.Density d;
   Modelica.SIunits.Mass m;
   Modelica.SIunits.Pressure p(stateSelect=StateSelect.always);
   Modelica.SIunits.SpecificInternalEnergy u;
   Modelica.SIunits.SpecificEnthalpy h(stateSelect=StateSelect.always);
   parameter Modelica.SIunits.Volume V=1;

equation
   m=V*d;
   state=Medium.setState_phX(p,h,Medium.reference_X);
   u=Medium.specificInternalEnergy(state);
   d=Medium.density(state);
   der(m)=time;
   der(m*u)=time;
end TestDifferentiation;

In general I see a problem with that the Modelica.Media structure relies on several undocumented special constructs that are needed by the tool for an efficient implementation.

Migrated-From: https://trac.modelica.org/Modelica/ticket/1575

Comment by wischhusen on 3 Dec 2014 11:53 UTC
There is a general problem behind:
There is no finite derivative for Integer phase contained in the state record which might be essentially the problem from the numerical point of view. In the water medium model phase is set to be always 0 (not known) which helps to solve the problem, but does not deliver the result the user would expect.

Comment by hubertus on 7 Dec 2015 14:00 UTC
I don't think that this is the issue,afaik this can be fixed by using the noDerivative annotation on the Integer phase. Also: I don't see how the phase can be known in any arbitrary function call, so what is wrong about the handling in the water properties?

Modified by hubertus on 7 Dec 2015 14:03 UTC

Comment by wischhusen on 23 Dec 2015 09:55 UTC
It requires some more features to enable inverse use of setState functions.

Though the prerequisites have changed with the Modelica specification v3.4 allowing mixed
Real and non-Real record derivatives (MCP-0028), this issue with TestDifferentiation failing to simulate still is apparent in current MSL (both maint/3.2.3 and master) and current Modelica tools.
@hubertus65 @thorade @wischhusen @jwindahlModelon Do you think you can fix it for MSL v4.0.0?

Here's what I tried so far.
Changing Modelica.Media.R134a.R134a_ph.setState_phX to
diff --git a/Modelica/Media/R134a.mo b/Modelica/Media/R134a.mo
index e1f2434c6..41778bde9 100644
--- a/Modelica/Media/R134a.mo
+++ b/Modelica/Media/R134a.mo
@@ -289,15 +289,17 @@ package R134a "R134a: Medium model for R134a"
       Modelica.SIunits.SpecificEnthalpy hv=dewEnthalpy(sat) "Vapor enthalpy";

     algorithm
-      state.p := p;
-      state.h := h;
-
-      state.phase := if ((state.h < hl) or (state.h > hv) or (state.p >
-        R134aData.data.FPCRIT)) then 1 else 2;
-
-      state.d := density_ph(p, h);
-      state.T := temperature_ph(p, h);
-      annotation (Documentation(info="
+      state := ThermodynamicState(
+          d=density_ph(
+            p,
+            h),
+          T=temperature_ph(
+            p,
+            h),
+          phase=if ((h < hl) or (h > hv) or (p > R134aData.data.FPCRIT)) then 1 else 2,
+          h=h,
+          p=p);
+      annotation (Inline=true, Documentation(info="

This function should be used by default in order to calculate the thermodynamic state record used as input by many functions.

 Example:

does neither help to simulate the TestDifferentiation model in Dymola 2020 or SimulationX 4.0.
However, changing state.phase to always be zero leads to successful simulating model in SimulationX 4.0, whereas Dymola 2020 still gives the same error as before.

I tried to define a dummy derivative function getPhase_ph_der (always returning 0) of getPhase_ph as a test. Dymola always warns about incompatible types for the outputs (which is Integer in both cases). Changing the output type of phase and phase_der to Real is accepted. Would it not make sense to symbolically substract Integer inputs from the list of derivatives (when differantiating functions) in any case?

These are the functions:
function getPhase_ph "Number of phases by pressure and specific enthalpy"
  extends Modelica.Icons.Function;
  input AbsolutePressure p "Pressure";
  input SpecificEnthalpy h "Specific enthalpy";

  output Integer phase "Number of phases";

protected
  SaturationProperties sat(psat=p, Tsat=0)
    "Saturation temperature and pressure";
  Modelica.SIunits.SpecificEnthalpy hl=bubbleEnthalpy(sat)
    "Liquid enthalpy";
  Modelica.SIunits.SpecificEnthalpy hv=dewEnthalpy(sat) "Vapor enthalpy";

algorithm
  //phase :=0;
  phase := if ((h < hl) or (h > hv) or (p > R134aData.data.FPCRIT)) then 1 else 2;

  annotation (derivative=getPhase_ph_der, Documentation(info="
This function computes the number of phases for R134a depending on the inputs for absolute pressure and specific enthalpy. It makes use of cubic spline functions for liquid and vapor specific enthalpy.
"));
end getPhase_ph;

function getPhase_ph_der
  "Derivative of number of phases by pressure and specific enthalpy"
  extends Modelica.Icons.Function;
  input AbsolutePressure p "Pressure";
  input SpecificEnthalpy h "Specific enthalpy";
  input Real p_der "Pressure derivative";
  input Real h_der "Specific enthalpy derivative";

  output Integer phase_der "Derivative of number of phases";

algorithm
  phase_der := 0;

end getPhase_ph_der;

The error message received from Dymola 2020 is:
Check of Modelica.Media.R134a.R134a_ph.getPhase_ph:

 function Modelica.Media.R134a.R134a_ph.getPhase_ph specified derivative Modelica.Media.R134a.R134a_ph.getPhase_ph_der, but the outputs did not match.

Check of Modelica.Media.R134a.R134a_ph.getPhase_ph successful.

WARNINGS have been issued.

I tried to define a dummy derivative function getPhase_ph_der (always returning 0) of getPhase_ph as a test. Dymola always warns about incompatible types for the outputs (which is Integer in both cases). Changing the output type of phase and phase_der to Real is accepted. Would it not make sense to symbolically substract Integer inputs from the list of derivatives (when differantiating functions) in any case?

The underlying problem are expressions that are differentiated as part of index reduction that also have discontinuities (in the original expression). For these cases an integer-expression can only change discontinuously and since it is the phase it seems likely that it actually changes.
So, having getPhase_ph_der does not seem good.
However, it may be that the original problem can be avoided - but it requires a bit more investigation, and e.g. using noDerivative does make sense since phase-changes are connected to having phX at phase-boundaries - you don't change phase away from phase-boundaries, right?

but it requires a bit more investigation

Who can do it? @HansOlsson @wischhusen @hubertus65 @thorade ?

@HansOlsson For calculating the derivatives of the states we do not need the derivative of "phase". I did not find a better way to introduce the dummy function to make it clear.
And yes, the number of phases only change on the phase boundaries.
Well, the solution could be to introduce function setState_phX_der? And use noDerivative on state.phase, right?

Here is what I tried to do:
function setState_phX_der
"Set state for pressure and specific enthalpy (X not used since single substance)"
input AbsolutePressure p "Pressure";
input SpecificEnthalpy h "Specific enthalpy";
input MassFraction X[:]=reference_X "Mass fractions";
input FixedPhase phase=0
"2 for two-phase, 1 for one-phase, 0 if not known";
input Real p_der;
input Real h_der;
output ThermodynamicStateDerivatives state_der "Thermodynamic state record";
algorithm
state_der.p_der := p_der;
state_der.h_der := h_der;
state_der.d_der := rho_ph_der(p, h, derivsOf_ph(
p,
h,
getPhase_ph(p, h)), p_der, h_der);
state_der.T_der := T_ph_der(p, h, derivsOf_ph(
p,
h,
getPhase_ph(p, h)), p_der, h_der);
end setState_phX_der;
record ThermodynamicStateDerivatives
Real p_der;
Real h_der;
Real d_der;
Real T_der;
// phase and X is skipped here!
end ThermodynamicStateDerivatives;
redeclare function extends setState_phX
"Set state for pressure and specific enthalpy (X not used since single substance)"
protected
SaturationProperties sat(psat=p, Tsat=0)
"Saturation temperature and pressure";
Modelica.SIunits.SpecificEnthalpy hl=bubbleEnthalpy(sat)
"Liquid enthalpy";
Modelica.SIunits.SpecificEnthalpy hv=dewEnthalpy(sat) "Vapor enthalpy";
algorithm
state.p := p;
state.h := h;
state.phase := if ((state.h < hl) or (state.h > hv) or (state.p >
R134aData.data.FPCRIT)) then 1 else 2;
state.d := density_ph(p, h);
state.T := temperature_ph(p, h);
annotation (derivative(noDerivative=phase, noDerivative=X) = setState_phX_der);
end setState_phX;
The tool throughs a warning that the outputs of both functions do not match.

First a general observation: writing smoothOrder in the setState-function should ideally suffice. There should not be a need for the user to write derivatives if they can be auto-generated. That could fairly easily be supported (well, at least in updated tools), but it uncovers a worse problem.
The worse problem is that:
The phase-handling in the Media-libraries doesn't really work in Modelica, since state.phase is sort of a non-discrete integer variables and those shouldn't exist in Modelica (since 1.3?)
However, in many cases this is avoided in one of the following ways:

The phase is just 0 (meaning don't know), and thus doesn't change.
There is no explicit state-variable (and thus no state.phase) in the model and instead the state is directly sent to a function.
E.g., I did barely see any references to state.phase in R134a.

I think there is no essential reason, why we see phase in the state record. Actually, it is just an informational output. In contrast to the other thermodynamic states it can not be used to calculated other state variables from it. Thus it would be sufficient to place and calculated it in the BaseProperties model. But this change would be non-backward-compatible.
Funny side finding:
state.phase := if ((state.h < hl) or (state.h > hv) or (state.p >
R134aData.data.FPCRIT)) then 1 else 2;
The state record does not contain phase according to my investigations but just p,h,d,T ...

I think there is no essential reason, why we see phase in the state record. Actually, it is just an informational output. In contrast to the other thermodynamic states it can not be used to calculated other state variables from it. Thus it would be sufficient to place and calculated it in the BaseProperties model. But this change would be non-backward-compatible.

Even if non-backward-compatible it may be the best solution. The question is how large impact it would have, i.e. whether users use phase from this record.
BTW: I noticed that phase seem different for this media compared to how I thought 2-phase water operated, and I would say that it is number of phases - not the phase.

Good question ... . I think, most users would use the functions and not the record. Thus, we need to convert these calls.
From the developers point of view we could substitute state.phase by evaluating input states like p, h, d, T in order to find out wether one is in one-phase or two-phase. I think that the idea was to get rid of these evaluations requiring some calls of saturation property functions (e.g. h_liq and h_vap) in the underlying function calls again and again. Perhaps, we will sacrifize computation speed when removing phase as an input at all.
Probably it would be better to have an additional input variable piped through from the top-level functions or models, right? In such a case we could use the noDerivative attribute and tools could do the index reduction. Would that be worth a try?
For a quick change, we could use the workaround of having a single line in the setState functions.

Removing milestone.

The following model can only be translated if I change R134a.R134a_ph.setState_phX in the following way:
redeclare function extends setState_phX
"Set state for pressure and specific enthalpy (X not used since single substance)"
algorithm
state := ThermodynamicState(phase=0, p=p, h=h, d=density_ph(p, h), T=temperature_ph(p, h));
end setState_phX;
model R134aTest
package SI=Modelica.Units.SI;
extends Modelica.Icons.Example;
replaceable package Medium = Modelica.Media.R134a.R134a_ph "Medium model";
SI.SpecificEnthalpy h = 420e3;
SI.Pressure p = 1e5;
Medium.ThermodynamicState state = Medium.setState_phX(p, h);
SI.SpecificEnthalpy h_dew = Medium.dewEnthalpy(Medium.SaturationProperties(Tsat=Medium.saturationTemperature(state.p), psat=Medium.pressure(state)));
end ;
The change still resolves for the previous differentiation problem stated above. Nevertheless, it is not optimal.

Just since I see this. Please do not use this construct:

package SI=Modelica.Units.SI;

The proper way is:
import Modelica.Units.SI;


[Feature] Support function FORMAT

Why I'm doing:
Support function FORMAT
What I'm doing:
Fixes #13304
What type of PR is this:

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[x] This pr needs user documentation (for new or modified features or behaviors)

[x] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

Hi @wangsimo0 Could you please help review this?

Hi @imay @wangsimo0 Could you please help review this?

Can anyone help re-run the BE UT pipeline? It seems like an irrelevant error.

Can anyone help re-run the BE UT pipeline? It seems like an irrelevant error.

ok, I can help you

Can anyone help re-run the BE UT pipeline? It seems like an irrelevant error.

ok, I can help you

Hi @silverbullet233 It failed again, due to TIME OUT, could you please help re-run it again? The BE UT is somehow running much slower than before, maybe due to the environment issues.

Hi @satanson @silverbullet233 Could you please review this again?

sorry for my late reply, some suggestions:
there are too many redundant code for different types, actually, you can use some template functions to simplify your code, plz refer to the implementations of mod function to get more details.


Added retries in pre-upgrade.yml and retries while applying kube-dns.yml

This change has been added to add retries while deleting master containers during upgrade and also while setting up kube-dns on existing clusters.

ci check this


Plug soundness hold around mem::forgetting MoveRefs

The Pin drop invariant requires that pinned data be properly destroyed
before its memory be re-used. This is a problem: MoveRef is responsible
for running the destructor of storage it generally does not own. This
means we must leak the storage of a forgotten MoveRef.
In the case of stack-pinned MoveRefs via slot, we can get into
situations (such as if a constructor panics) where we cannot properly
destroy the pointee. For now, we double-panic to force an abort, but we
may be able to handle this better in the future.

Here's a relatively reduced counterexample (run in release):
use core::mem;
use moveit::{DerefMove, MoveRef, move_ref::DropFlag, slot};

struct Foo(u32);

impl Drop for Foo {
    fn drop(&mut self) {
        println!("Drop");
    }
}

fn oh_no() {
    slot!(slot: Foo);
    let bar = slot.put(Foo(1));
    println!("{:p}", &*bar);
    let mut deinit = DerefMove::deinit(bar);
    *deinit.ptrs().1 = DropFlag::Dead;
    let bar = unsafe {
        // SAFETY: this is called on the return value from `deinit` and is only called once
        MoveRef::<'_, Foo>::deref_move(&mut deinit)
    };
    let baz = MoveRef::into_pin(baz);
    mem::forget(baz);
}

fn main() {
    for _ in 0..10 {
        oh_no();
    }
}

Soundness: the same address for Foo will be used multiple times, but the destructor is never run and the memory for the variables is pinned.
To plug this soundness hole, you either need to escalate the DropFlag checks to asserts (so they run in release) or remove/modify the public ptrs() function to make manual drop flag manipulation impossible.

So I fundamentally think this code is wrong, because it's violating this invariant of MoveRef:
  /// `drop_flag`'s value *must* be [`DropFlag::Alive`], and must be a drop
  /// flag governing the destruction of `*ptr`.

I think the problem is that I would like for deinit to not be touchable between when deinit() is called and when deref_move() is called, but the language doesn't give us a way to avoid that. In fact, even this is unsound:
fn oh_no() {
    slot!(slot: Foo);
    let bar = slot.put(Foo(1));
    println!("{:p}", &*bar);
    let mut deinit = DerefMove::deinit(bar);
}

This will fail to call Foo's dtor, but free the storage. Oops! I think the observation here is that deinit needs to be unsafe and have the caveat that it cannot be called unless you can guarantee that you will call deref_move with no intermediate operations. These two operations should really be one function, but they can't be... so we wind up working around the language here.

That said, there may be another option. Fundamentally what we want out of DerefMove is to stick the storage somewhere. So maybe we need to redefine the trait to look like this:
unsafe trait DerefMove: DerefMut {
  type Uninit: Sized;
  fn deref_move<'frame>(self, storage: Slot<'frame, Self::Uninit>) -> MoveRef<'frame, Self::Target>;
}

We can then implement this thus for e.g. Box:
unsafe impl<T> DerefMove for Box<T> {
  type Uninit = ForgetIfForgotten<Box<MaybeUninit<T>>>;
  fn deref_move<'frame>(self, storage: Slot<'frame, Self::Uninit>) -> MoveRef<'frame, Self::Target> {
    // 1. Get the deinit'd version of `self` into `storage` without arming the forget() trap.
    // 2. Convert the FiF<Box> into a MoveRef as before.
  }
}

It's important to not arm the trap in storage, since we want to silently leak the data. Alternatively, we could not do that, and just always make forgetting a MoveRef be a crash... not sure what the best option is. I may need to sleep on this to design a clearer API.

The code is intentionally malicious, but it's following all the required safety documentation. It should be sufficient to make deinit unsafe and add conditions requiring a specific pattern of use. I think it may be harder for users to verify "no intermediate operations" than it sounds, but it's impossible to conjecture until there's something to poke at.
In the smaller example you gave, I don't actually think there's any unsoundness. I don't think there's any guarantee that objects will be dropped before their memory is freed except when those objects are pinned, and nothing gets pinned in that code.

I think the newer formulation of DerefMove seems more coherent and leaves fewer openings for soundness issues. Nice! I can poke at this some more if you switch the impls over.

@djkoloski I've implemented this in https://github.com/google/moveit/pull/25. Please LMK if you can poke holes in it. >:)

(#25 closes this)


Create Implementation.c

Related Issue

Info about the related issue

Closes: #[issue number that will be closed through this PR]
Describe the changes you've made
Added code of stack implementation using array
Type of change
What sort of change have you made:

[x] New feature (non-breaking change which adds functionality)

Screenshots(optional)

Original
Updated

original screenshot
updated screenshot

Thanks for your contribution 🚀 Try writing code by taking runtime inputs from user

Can i change it now


Additional nicknames and name variants to add

traci = tracy (which you already have), tracie
falon = fallon, Fal, Fall, Fallie, Fally, Falcon, Lon, Lonnie (https://momlovesbest.com/fallon-name-meaning)
hillary = hilary
toni = tony, antonia, etc.
lindsay = lindsey, lindsie, lindsy
garrett = Barrett, Gare, Garrison, Gars, Gary, Jerry, Rhett, Variations: Garratt, Garret, Garrod, Jarrett, Jared, Jarratt, Jerrold (https://momlovesbest.com/garrett-name-meaning)
gareth = gary, gare
dacia = Daycia, Daisha, Dacya
marc = mark, marcus, etc.
sheri = sherry, sherryl, sheryl, sherri, cheri, cherie, etc.
dianne = diane, dian
angelika = angelica
miguel = Miguell, Miguael, Miguaell, Miguail, Miguaill, Miguayl, Miguayll = michael/mick (spanish version)
monika = monica, monique
michele = michelle
shelley = sheley, michelle, shellie, etc.
hayley = hailey, haylee, etc.
karl = carl
rosemary = rosemarie, marie, mary, rose, etc.
jalen = Jay, Jaye, Len, Lenny, Lennie, Jaylin, Alen, Al, Jaylen, Jaelen, Jaelin, Jaelyn, Jailyn, Jaylyn
rachael = rachel
kellie = kelli, kelly, kelley
kalli = kali, cali
jodi = jody
lori = lorrie, laurie, lorelei, etc.
shawn = shaun
allen = allan, alan, al
erika = erica
marcia = marcie, marsha
dona = donna
kristi = kristy, Christy, christine, christina, krista, etc.
norman = norm
chelsie = chelsey
stephine = stephanie, stephany, stephani
audree = audrey
kerri = kerry
fiona = fionna
savanna = savannah
bryanna = brianna, bri, briana, etc.
jaine = jane, jayne
leilani = lani
jesse = jessica, jess, jessie
abby = abbie
glenn = glen
carri = carrie, kari, kara
donn = don, donald
kym = kymberly, kim, kimberly, kimberli
gerri, geri = geraldine
nichole = nicky, nicki, nicholette, nicci, nicole
jamey = jaime, jamie
tami = tammie, tammy
derek = derick, derrick, derrek, rick, etc.
jenni = jennie, jenny
karin = karen
gabriela = gabriella
marni = marnie
dena = deena, dina, adina, adena
brittnie = brittany
juston = justin
lesli = leslie, lesley, les
kev = kevin
aga = athaga
carla = karla, carly
tiffanee = tiffany
staci = stacy, stacey, stacie
sara = sarah
katia = kate, katie
terri = teri, terrie, terry
ashly = ashley
jeanie = jeannie
matt = matthew, matthews
jillian = jill
laurel = laurie
(these all came from a registration list I'm working on)

Hi! Thanks for opening this! A few things:

The relationship between canonical and nickname is not symmetrical. So Matt is a nickname for Matthew, but not vice versa. matt and Matthew are already present in the data, are you just not using this library correctly?
I want to be conservative with what links are added, so that there aren't false positives. For instance, I'm skeptical of how common Barrett-Garrett is. 95% of your suggestions look good, but I want to leave out a few of the weirder ones.
I can add these cases to the code, but only if you help me with the grunt work of formatting for me, putting these in the form CANONICAL,NICK0,NICK1,NICK2, etc

Let me know what you'd like to do!

I'm unclear on the file structure and how to decide whether something is a name or nickname (e.g, is Kari a real name or a nickname for Carrie?).  Would need more info to help with this.
I'm ok if stuff gets left out, the point of my issue report was to try to close some of the holes.  Some of the names I'd never seen before either, but then looked up and found they were common in other countries (e.g., Garrett is big in Ireland).

The file structure is CANONICAL,NICK0,NICK1,NICK2, NICK3,etc as you can see in the csv. Does that make sense?
Yeah the Kari/Carrie case is ambiguous. I would lean towards Carrie being the longer one and therefore the canonical one. But for the Sara/Sarah case, I think that is symmetrical, so you should have a line sarah,sara as well as sara,sarah. Just try your best and I can go through and give my 2 cents and we should be able to find something. Just trying to make it better than how it currently is, it doesn't need to be perfect.

names.csv
This is close, maybe not all the possible canonicals, but enough that code could look in the nicknames to find related nicknames as canonical names too.

Thank you @afeibus ! I made a few adjustments, but most of them looked great. Thank you very much, your work is very much appreciated!

Closing as done, but if you find any problems with the tweaks I made please raise a new issue ( and link to this one)


Add ability to turn on or off annotations

Add the ability to toggle on or off annotations from the plug-in menu

Blocked until we can get up some examples of annotations.


Queues?

Would you be open to a PR that adds support for queues similar to my sentry package: https://github.com/twineis/raven-php or is that something you would like to keep out of the official package?

@pulkitjalan absolutely. I saw your package when I was creating this, but my goal at the time was the simplest solution we could get.

Great, fair enough, Glad to see official support for Laravel and Lumen :)
Ill submit a PR soon.

Did queues make it in? Or is this now part of #90?


docs: PowerShell Install Directions

Description

Testing

Additional context

actually, maybe we dont really require python3.11, i have to verify this....


Add easier install instructions

No need to compile it anymore.
(Please make a release and add this as a unzipped executable for this to work)
$.zip

No, I don't want a compiled binary.
I might add a 1-liner script to compile however I will not be distributing binaries I don't people to have to trust me, I'd rather them read the code and see themselves.
If you would like to make the 1-liner I would be happy to accept a PR


Detect and account for repeated choices

There's a number of examples of overestimated entropies for passwords like these:
"ekekekekek", " . . . . . " (#39). Also space seperated passwords ("dark and stormy night") get quite a high entropy(#21).
I think this is because the algorithm does not detect higher level repetition patterns. For space separated strings it's okay that it does not take into account that there is a repetition of (dictionaryword)(bruteforce) because the algorithm ignores the entropy in that information anyway. The problem is that it does not recognize that always the same selection is picked within a given searchspace. To illustrate this... you get an even higher entropy for "dark dark dark dark".
So when calculating the entropy a selection that occures n times should add ln(n) plus the entropy of the selection itself instead of n times the entropy of the selection itself. This should probably be applied before picking the lowest entropy.

thanks for reporting -- multi-character repeats are fixed in 3.5.0.
overestimating extra entropy for spaced passwords "dark and stormy night" is coming soon in another release -- a noted flaw for sure! to address that problem currently what i'm thinking is: when spaces are present, run zxcvbn on spaced and non-spaced variants, and return the minimum entropy.  something along those lines. similar treatment for dash- and underscore-separated patterns.

How about returning the average? My thinking is that adding separators does increase entropy over not having them.


[Bug] - MidiQOL hook error triggered when some module is not active

Hooks.on('midi-qol.RollComplete', (workflow) => {

    let chatMessage = workflow.chatCard;

    if (!game.settings.get('critic-message', 'disablemodule')) {

        detectroll(chatMessage);
    }
});

Not sure which module critic-message is, but this will always trigger an error if that is not active when checking for its setting.
You'd better do something like
if (game.modules.get('critic-message')?.active && !game.settings.get('critic-message', 'disablemodule')) {
//do stuff
}

I just realised I didn't provide the actual error but it's just a common Hook error message, about This is not a registered game setting

thanks for the report, the other module is not needed, I just copy pasted some code from other module and I did not notice that line...

Fixed, please update and test.
Please let me know of any other issue you find.


gvcfGenotyper taking too much time for MT chromosome

I am genotyping 760 vcf files splitted across all chromsomes chr1...22,X,Y and MT in the cluster. The vcf files were obtained using accredited Illumina pipeline. Run for all chromosome finished successfully approx 3-4 hours. But for chrMT, it is taking endless time. The log points out that it is stucked for one of the sample. However after deleting that sample from the input list it gets stucked at some other sample and this goes on.
Example log :
...
...
[Fri Feb 22 18:43:34 2019] [info] Opened Sample1.genome.vcf.gz 751/759
[Fri Feb 22 18:43:34 2019] [warning] WARNING: Sample1.genome.vcf.gz has no FORMAT/ADF tag
[Fri Feb 22 18:43:34 2019] [warning] WARNING: Sample1.genome.vcf.gz has no FORMAT/ADR tag
[Fri Feb 22 18:43:34 2019] [warning] WARNING: Sample1.genome.vcf.gz has
It gets stucked at the last line for more than 10+ hours.
Please help me regarding this.

I am sorry to hear that!
I cannot reproduce this error on our side. Using 150 gVCF files from a recent run of the Illumina variant caller, I can merge MT in seconds.
One potential problem that comes to my mind is that gvcfgenotyper assumes diploidy. Recent versions of the Illumina variant caller should follow the diploid convention even for calls on MT but it is worth checking.
Another option is the remove the comments from this line:
https://github.com/Illumina/gvcfgenotyper/blob/b95ae4af6be29b72357ab8a0b2a5c0daa74e2116/src/cpp/lib/GVCFMerger.cpp#L12
recompile, and run again. This will tell you where on MT gvcfgenotyper stalls.
If you find out where gvcfgenotyper stalls I can debug further and help to fix the issue.

Hi,
As per your advice, I uncommented line 12, compiled again and re-ran the analysis. It got stuck again with following output on the screen:
MT:6:C:G
And the logs are:
[Thu Mar 7 16:29:25 2019] [info] Opened /SampleXYZ.genome.vcf.gz 755/759
[Thu Mar 7 16:29:25 2019] [warning] WARNING: /SampleXYZ.genome.vcf.gz has no FORMAT/ADF tag
[Thu Mar 7 16:29:25 2019] [warning] WARNING: /

What reference genome is this?
Could you post the full command line you used?

The reference genome used is: GRCh37.74 and here is the exact command issued:
/gvcfgenotyper-master/bin/gvcfgenotyper
-l /759_samples_final.txt
-Ob -o /gvcfGT_tmp_chrMT.bcf
-f /Homo_sapiens.GRCh37.74.dna.fasta
-r MT
-L gvcfGT_tmp_chrMT.log

hmmm okay. Illumina pipelines usually use hg19 which is slightly different to grch37
If you do:
bcftools norm -r MT -f /Homo_sapiens.GRCh37.74.dna.fasta Sample1.genome.vcf.gz

does it run without error?

Hi,
I tried this command:
bcftools norm
-r MT
-f Homo_sapiens.GRCh37.74.dna.fasta Sample1.genome.vcf.gz
-Ob -o OutSample1.bcf
It was successful and had following screen output:
Lines   total/split/realigned/skipped:  2687/0/1/0
Also I can access/view the OutSample1.bcf using bcftools.

So you're convinced that you're using that correct reference for your gvcf files?
If yes, could you extract a mini-gvcf containing only MT for one of your samples and upload it somewhere (ftp?) where I could take a look at it?
I have no other idea how we could debug this.

I'm closing this now, feel free to open another issue if there are any other questions.


Mac Install Support

Restructures Install-UnitySetupInstance to better support the needs for mac package installs.
Separates downloading packages from installing packages.
Handles proper PowerShell piping for commands.
Converts WebClient to be Async and gives a progress bar for status of download.
Fixes caching issue with WebClient downloads.
Enables filtering of installers and instances based off directory paths.

TODO: (non-blocking)

Error handling (enhancements?)
Support for upgrading previous installs.
Investigate Unity Hub (beta) on Mac to inspect how they're getting packages installed into other directories. This is resolved using sparsebundles

PS /Users/Ziugy/Source/unitysetup.powershell> $installers = Find-UnitySetupInstaller -Version 2018.2.3f1 -Components Mac, Vuforia
PS /Users/Ziugy/Source/unitysetup.powershell> $installers | Install-UnitySetupInstance -Verbose
VERBOSE: Mounting sparse bundle disk.
/dev/disk2              GUID_partition_scheme
/dev/disk2s1            EFI
/dev/disk2s2        	Apple_HFS                      	/Volumes/UnitySetup
VERBOSE: Skipping download because it's already in the cache: https://download.unity3d.com/download_unity/1431a7d2ced7/MacEditorInstaller/Unity-2018.2.3f1.pkg
VERBOSE: Skipping download because it's already in the cache: https://download.unity3d.com/download_unity/1431a7d2ced7/MacEditorTargetInstaller/UnitySetup-Vuforia-AR-Support-for-Editor-2018.2.3f1.pkg
VERBOSE: Installing Mac
VERBOSE: 09/19/2018 20:25:45: Installing Mac to /Volumes/UnitySetup/.
Password:
installer: Package name is Unity
installer: Installing at base path /Volumes/UnitySetup
installer: The install was successful.
VERBOSE: 09/19/2018 20:26:12: Succeeded.
VERBOSE: Installing Vuforia
VERBOSE: 09/19/2018 20:26:12: Installing Vuforia to /Volumes/UnitySetup/.
installer: Package name is VuforiaSupport
installer: Installing at base path /Volumes/UnitySetup
installer: The install was successful.
VERBOSE: 09/19/2018 20:26:14: Succeeded.
VERBOSE: Copying install to /Applications/Unity-2018.2.3f1/.
VERBOSE: Freeing sparse bundle disk space and unmounting.
"disk2" unmounted.
"disk2" ejected.
Starting to compact…
Reclaiming free space…
.............................................................................................................................................................
Finishing compaction…
Reclaimed 2.4 GB out of 31.6 GB possible.
PS /Users/Ziugy/Source/unitysetup.powershell> $installers = Find-UnitySetupInstaller -Version 2018.2.3f1 -Components Linux
PS /Users/Ziugy/Source/unitysetup.powershell> $installers | Install-UnitySetupInstance -Verbose
VERBOSE: Mounting sparse bundle disk.
/dev/disk2              GUID_partition_scheme
/dev/disk2s1            EFI
/dev/disk2s2        	Apple_HFS                      	/Volumes/UnitySetup
VERBOSE: Copying /Applications/Unity-2018.2.3f1/ to /Volumes/UnitySetup/Applications/Unity/
VERBOSE: Skipping download because it's already in the cache: https://download.unity3d.com/download_unity/1431a7d2ced7/MacEditorTargetInstaller/UnitySetup-Linux-Support-for-Editor-2018.2.3f1.pkg
VERBOSE: Installing Linux
VERBOSE: 09/19/2018 20:27:32: Installing Linux to /Volumes/UnitySetup/.
installer: Package name is LinuxStandaloneSupport
installer: Installing at base path /Volumes/UnitySetup
installer: The install was successful.
VERBOSE: 09/19/2018 20:27:37: Succeeded.
VERBOSE: Copying install to /Applications/Unity-2018.2.3f1/.
VERBOSE: Freeing sparse bundle disk space and unmounting.
"disk2" unmounted.
"disk2" ejected.
Starting to compact…
Reclaiming free space…
.............................................................................................................................................................
Finishing compaction…
Reclaimed 3.0 GB out of 31.6 GB possible.
PS /Users/Ziugy/Source/unitysetup.powershell> $installers = Find-UnitySetupInstaller -Version 2018.2.3f1 -Components AppleTV
PS /Users/Ziugy/Source/unitysetup.powershell> $installers = Find-UnitySetupInstaller -Version 2018.2.3f1 -Components iOS, Android
PS /Users/Ziugy/Source/unitysetup.powershell> $installers | Install-UnitySetupInstance -Verbose
VERBOSE: Mounting sparse bundle disk.
/dev/disk2              GUID_partition_scheme
/dev/disk2s1            EFI
/dev/disk2s2        	Apple_HFS                      	/Volumes/UnitySetup
VERBOSE: Copying /Applications/Unity-2018.2.3f1/ to /Volumes/UnitySetup/Applications/Unity/
VERBOSE: Skipping download because it's already in the cache: https://download.unity3d.com/download_unity/1431a7d2ced7/MacEditorTargetInstaller/UnitySetup-Android-Support-for-Editor-2018.2.3f1.pkg
VERBOSE: Skipping download because it's already in the cache: https://download.unity3d.com/download_unity/1431a7d2ced7/MacEditorTargetInstaller/UnitySetup-iOS-Support-for-Editor-2018.2.3f1.pkg
VERBOSE: Installing Android
VERBOSE: 09/19/2018 20:29:29: Installing Android to /Volumes/UnitySetup/.
installer: Package name is AndroidPlayer
installer: Installing at base path /Volumes/UnitySetup
installer: The install was successful.
VERBOSE: 09/19/2018 20:29:37: Succeeded.
VERBOSE: Installing iOS
VERBOSE: 09/19/2018 20:29:37: Installing iOS to /Volumes/UnitySetup/.
installer: Package name is iOSSupport
installer: Installing at base path /Volumes/UnitySetup
installer: The install was successful.
VERBOSE: 09/19/2018 20:30:03: Succeeded.
VERBOSE: Copying install to /Applications/Unity-2018.2.3f1/.
VERBOSE: Freeing sparse bundle disk space and unmounting.
"disk2" unmounted.
"disk2" ejected.
Starting to compact…
Reclaiming free space…
.............................................................................................................................................................
Finishing compaction…
Reclaimed 7.3 GB out of 31.6 GB possible.

@Ziugy question about Test-UnitySetupInstance - unlike gusi it is returning false for me unless I am in the exact path to the editor or i specify that path to pwsh; in which case I obviously know if it's installed since i can look directly at the path. Am i using this as intended or am i missing the point?
For example, gusi will just list every version installed and the path to it. @jwittner

Test-UnitySetupInstance was written to be the equivalent of Test-Path for installs. Yes, gsui shows them; I needed something to branch when one exists / doesn't exist.
I also expect we would extend Test-UnitySetupInstance to also include testing for Components too.

@awolowiecki720  - sounds like this is working now. Can you accept the changes and approve the PR? I can merge it after that. =)

CI still fails for me: Logs


[WIP] Implement MPNN model

I add MPNN (https://arxiv.org/abs/1704.01212) model.
Ref. #300
Progress

[ ] Update layer

[ ] Edge Network

[x] Readout layer

[x] Set2Set layer

[ ] Model
[ ] Inputsize invariant

Codecov Report

Merging #312 into master will decrease coverage by 5.59%.
The diff coverage is 89.76%.

@@            Coverage Diff            @@
##           master     #312     +/-   ##
=========================================
- Coverage   89.59%   83.99%   -5.6%
=========================================
  Files         182      188      +6
  Lines        8272     8565    +293
=========================================
- Hits         7411     7194    -217
- Misses        861     1371    +510

Done.
Please confirm.

LGTM!


[Bug][Backend] The devlake backend started with error: chdir /app/python/plugins: no such file or directory

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
The devlake backend started with error: chdir /app/python/plugins: no such file or directory
time="2023-03-24 17:31:25" level=info msg="endpoint GET /plugins/bamboo/connections/:connectionId/remote-scopes github.com/apache/incubator-devlake/server/api.handlePluginCall.func1 5"
[GIN-debug] [WARNING] You trusted all proxies, this is NOT safe. We recommend you to set a value.
Please check https://pkg.go.dev/github.com/gin-gonic/gin#readme-don-t-trust-all-proxies for details.
[GIN-debug] Listening and serving HTTP on <IP_ADDRESS>:8080
time="2023-03-24 17:31:25" level=error msg="chdir /app/python/plugins: no such file or directory
 Wraps: (2) chdir /app/python/plugins
 Wraps: (3) no such file or directory
 Error types: (1) *hintdetail.withDetail (2) *fs.PathError (3) syscall.Errno"
[GIN] 2023/03/24 - 17:31:44 | 200 |    3.560415ms |   <IP_ADDRESS> | GET      "/blueprints"
[GIN] 2023/03/24 - 17:31:51 | 200 |     217.623µs |    <IP_ADDRESS> | GET      "/version"

What do you expect to happen
The devlake backend start  successfully without error~
How to reproduce
Using devlake helm chart v0.16.0-beta10 to deploy devlake with build-in mysql database on k8s
Anything else
No response
Version
main
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thanks for reporting the issue,we will take a look at it.

This is a benign error message that doesn't disrupt the server's operation. It's been fixed in #4734 which will be in v0.17. @hezyin should we patch it back to v0.16?


Add missing cloaking mask patterns

Need to identify what's missing first. :)

See #15 for handling text boxes.

Credit card?  Phone number?  Adress?


Netatmo Welcome camera motion sensors are missing.

Home Assistant release with the issue:
0.97.0
Last working Home Assistant release (if known):
0.96.5
Operating environment (Hass.io/Docker/Windows/etc.):
Hass.io
Component/platform:
https://www.home-assistant.io/components/netatmo/
Description of problem:
Netatmo Welcome camera is working, but motion sensors are missing.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
netatmo:
  api_key: !secret netatmo_api_key
  secret_key: !secret netatmo_secret_key
  username: !secret netatmo_username
  password: !secret netatmo_password
  discovery: false
  webhooks: true

camera:
  - platform: netatmo

binary_sensor:
  - platform: netatmo
    home: kodu
    timeout: 90
    cameras:
      - Koducam
    welcome_sensors:
      - Someone known
      - Someone unknown
      - Motion

Traceback (if applicable):
2019-08-08 10:04:39 ERROR (MainThread) [homeassistant.components.binary_sensor] Error while setting up platform netatmo
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 149, in _async_setup_platform
    await asyncio.wait_for(asyncio.shield(task), SLOW_SETUP_MAX_WAIT)
  File "/usr/local/lib/python3.7/asyncio/tasks.py", line 442, in wait_for
    return fut.result()
  File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/homeassistant/homeassistant/components/netatmo/binary_sensor.py", line 67, in setup_platform
    if not data.get_camera_names():
  File "/usr/src/homeassistant/homeassistant/components/netatmo/__init__.py", line 228, in get_camera_names
    for camera in self.camera_data.cameras[self.home].values():
KeyError: 'kodu'

Additional information:

Upgraded HA to 0.98, but still motion sensors are missing.

same to 0.98.1

I cannot reproduce this behaviour locally as my motion sensors work just fine.

You can selftest the values provided by the Netatmo API by running this script with --mode=long.
You can run the script as follows:
python gen_test_data.py --CLIENT_ID <YOUR_CLIENT_ID> --CLIENT_SECRET <YOUR_CLIENT_SECRET> --USERNAME<EMAIL_ADDRESS>--PASSWORD <YOUR_SECRET_PASSWORD> --mode=long --modules Camera

The script should be run separately, either within your HA environment or elsewhere with pyatmo installed (pip install pyatmo).

If I ssh to my hassio and run these commands I get zsh: command not found: python and zsh: command not found: pip

@e6on the script doesn't need to run on the same machine than HA.

I get this error if I run it on raspbian.
  File "gen_test_data.py", line 202
SyntaxError: Non-ASCII character '\xc2' in file gen_test_data.py on line 202, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details

Not sure how you got the script, but try to wget https://gist.githubusercontent.com/cgtobi/c27d4e3bb0e3b812f75582b41f7ff41d/raw/a3a5a598413100f9f84801a94b2fad6123ca1acb/gen_test_data.py.

I updated the gist and removed the ° symbol which was causing the trouble.

Now I get this:
Traceback (most recent call last):   File "gen_test_data.py", line 3, in <module>     import pyatmo   File "/usr/local/lib/python2.7/dist-packages/pyatmo.py", line 14, in <module>     from smart_home import _BASE_URL, postRequest   File "/usr/local/lib/python2.7/dist-packages/smart_home/__init__.py", line 4, in <module>     import requests ImportError: No module named requests

For some reason the dependencies are not ok in the pyatmo package, please run pip install requests to fix this. I'll get that fixed upstream.

pip install requests successfully installed certifi-2019.9.11 chardet-3.0.4 idna-2.8 requests-2.22.0 urllib3-1.25.3 and now when I run the script I get:
Traceback (most recent call last):   File "gen_test_data.py", line 3, in <module>     import pyatmo   File "/usr/local/lib/python2.7/dist-packages/pyatmo.py", line 15, in <module>     from smart_home.Camera import CameraData   File "/usr/local/lib/python2.7/dist-packages/smart_home/Camera.py", line 4, in <module>     from urllib.error import URLError ImportError: No module named error

You are using python 2.7 instead of 3+. Please use a more recent version of python (e.g. 3.6 or greater).


GH-14809: [Dev] Add created GitHub issues to<EMAIL_ADDRESS>

Closes: #14809

In addition to julia, should we do the same for the other arrow-.. repos? i.e. arrow-adbc, arrow-nanoarrow (and maybe also the different rust repos)

I think so.


fix: Add more definitions to built .a

Add more C files as dependencies, along with several more defines, to define more symbols in the built result.
Tested by building and running a rust binary that uses diesel with this as the dependency, on a mac, with

no --platforms
a linux-x86_64 platform
a linux-arm64 platform

Fixes #2.

@aran Sorry for the delay. We tested your changes on a couple of internal repositories and it seems to work just fine. Thanks!

OK, fixed up that commit verification issue.
I also removed the MODULE.bazel.lock change, not sure if you wanted that included. If so, I figure you can decide that and commit it, since it's not strictly related to this.
With respect to the changes in this PR, it's been working for me without issue so far, but just want to be clear it is a bit concerning to me on several aspects:

I don't understand how you had things working without something like it, which makes me feel like I don't understand something about the overall build environment
I don't understand the implications of blanking out getpeereid, or why the postgres source doesn't work out of the box with the configured options
It seems reasonable that FRONTEND is right but don't understand the implications of the STRERROR defines.

OK, fixed up that commit verification issue.
I also removed the MODULE.bazel.lock change, not sure if you wanted that included. If so, I figure you can decide that and commit it, since it's not strictly related to this.

Check! Let me know if it works for you on the main branch (without the MODULE.bazel.lock change). If not I'll add it anyways.

With respect to the changes in this PR, it's been working for me without issue so far, but just want to be clear it is a bit concerning to me on several aspects:
1. I don't understand how you had things working without something like it, which makes me feel like I don't understand something about the overall build environment

I can say with confidence that I have a very poor understanding of how all of this works in the first place. It has been a matter of making changes, testing, verifying, etc. I still don't get why the original version worked (it might be due to some magic happening in pq-sys or with our toolchain not being fully hermetic). But it works and passes all of our tests so I guess it should be fine :-)

2. I don't understand the implications of blanking out `getpeereid`, or why the postgres source doesn't work out of the box with the configured options
3. It seems reasonable that `FRONTEND` is right but don't understand the implications of the `STRERROR` defines.

Me neither. If I have some time in the upcoming weeks I'll look further into this. I also wanted to add support for more architectures.


Feature/tx query graph

This would close #269 and #278. The failing specs in CI call out a pre-existing issue with RDF::Graph's Queryable support that needs to be resolved before merge.
This changes the Transaction semantics to behave like Graph. Queryable is somewhat opinionated that inserting triples to a queryable should result in those triples being accessible through query. In light of this, the answer to #278 seems to be that graph scope must be symmetrical for read and write operations. That interpretation is implemented in the PR.
The remaining blocker is: Queryable's shared examples require a query pattern's graph name to be retained when querying, but Graph overwrites it.
My inclination is to change the specs (skip when #graph_name is defined), keeping the existing behavior. Thoughts, @gkellogg?

That seems reasonable to me. Please be sure SPARQL specs pass with this change, though.

A local run of SPARQL with these branches passes.


Add Guzzle 6 adapter docs

Oops wait, I forgot to add an installation section. :lol:

Installation notes added. Now ready for merging.

Updated according to feedback.

thanks a lot!


Merge dev to test 230721

Contains:

Use whitenoise and gunicorn (#206)
Fix bundling of static files. (#204 , #213)
Update ProcessQueue to new package dependency and structure including data dictionaries (#208)
Fixed JSON output bug (#211)
Lots of tidying of unused code and imports, and move make_dag() into the code to remove dependence on co-connect-tools. (#214 , #209)
Add queries to ScanReportValueSerializer (#210)
Fix error caused by invalid concept (#212)

Note that this required the creation of scan-reports container in test storage account. I have created that there, and another scan-reports in the prod system as well ahead of merging there.


Trigger autograding automatically after every assessment is due

Currently, assessments that close are graded at 1201 every night. Would be optimal to find a way to trigger a auto grading job immediately after every assessment is due.

While ideal, i think this is non-trivial. We will have to schedule non-recurring tasks, and store those task references so that we can cancel/modify the tasks if necessary (for example changing the assessment due date)


<EMAIL_ADDRESS>Fix autoupdate

Fix autoupdate (looks like version hard-coded by accident in dfd8544).

Relates to #12514.

[x] I have read the Contributing Guide.

/verify


Add Custom .NET CLI support to OmniSharp

Add a configuration mechanism to allow users to point OmniSharp to a custom .NET CLI, with a fallback to the DOTNET_ROOT environment variable before falling back to the PATH.
I've updated the tests to use this functionality for locating the .NET CLI instead of using the old test-only code-path.
As this is my first contribution to Omnisharp, I'm not quite sure how this exposes the new setting through to omnisharp.json, so if anyone has any pointers on that, they would be well appreciated.
cc: @333fred

FWIW, it kind of looks like this runs before the omnisharp.json files are loaded. ☹


Crash on boot

2023-04-08-7.log

You're using a mod for Minecraft 1.19.2 (cyanide-3.0.1) on Minecraft 1.19.4. Don't do that.

Ah, sorry. For some reason Prism Launcher install 3.0.1. Sorry for wasting your time


Hash in url disapear at first render if SSR

Hi,
Since the release 6.3.2 it is not possible anymore to use a hash in the url (simply to scroll down until an anchor) at the first render if you do server side rendering :

The hash is not present server side in the initial state
At first render the reducer of LOCATION_CHANGE action will not merge the "server" router state with the actual payload of the action (where we have our hash), but will just return the state has it is.

So we have a difference between the hashInHistory and the hashInStore and this causes the hash is simply removed from the url, as it enter in the inTimeTravelling condition.
I understand the isFirstRendering is here to avoid a useless re-render but in my case I need it...

I worked around this by doing patching the initial state before passing it into createStore()...
if (isServer && initialState.router && initialState.router.location) {
      initialState.router.location.hash = window.location.hash;
}

I worked around this by patching the initial state before passing it into createStore()...
if (isServer && initialState.router && initialState.router.location) {
      initialState.router.location.hash = window.location.hash;
}

I think is
if (!isServer && initialState.router && initialState.router.location) {
initialState.router.location.hash = window.location.hash;
}
Because you cannot get window instance in server side.
Regards.


Move machineDeploymentsToDelete out of provider code

Issue #, if available:
currently MachineDeploymentsToDelete method is within each provider code, but the logic is provider agnostic.
Description of changes:
Moved the code to cluster manager. Use single method to generate machinedeployment name.
Testing (if applicable):
Unit tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm


exporter/stats/prometheus: java.lang.NoSuchFieldError: timestampMs

While running a demo for "OpenCensus for Java developers" https://github.com/orijtech/opencensus-for-grpc-java-developers, on enabling Prometheus
by
diff --git a/src/main/java/io/ocgrpc/capitalize/CapitalizeServer.java b/src/main/java/io/ocgrpc/capitalize/CapitalizeServer.java
index 9f2f851..f0ff7ac 100644
--- a/src/main/java/io/ocgrpc/capitalize/CapitalizeServer.java
+++ b/src/main/java/io/ocgrpc/capitalize/CapitalizeServer.java
@@ -142,7 +142,7 @@ public class CapitalizeServer {
             .setProjectId(gcpProjectId)
             .build());

-        if (false) {
+        if (true) {
             // And then the Prometheus exporter too
             PrometheusStatsCollector.createAndRegister();
             // Start the Prometheus server

and then running it by
$ GOOGLE_APPLICATION_CREDENTIALS=~/Downloads/census-demos-237a8e1e41df.json mvn exec:java -Dexec.mainClass=io.ocgrpc.capitalize.CapitalizeServer

and running prometheus with this config file
global:
  scrape_interval: 10s

  external_labels:
    monitor: 'ocgrpc-java'

scrape_configs:
  - job_name: 'ocgrpc-java'

    scrape_interval: 10s

    static_configs:
      - targets: ['localhost:9821']

$ prometheus --config.file=prometheus.yml

I get a bunch of error logs and seeming crashes
[WARNING]
java.lang.NoSuchFieldError: timestampMs
    at io.prometheus.client.exporter.common.TextFormat.write004 (TextFormat.java:49)
    at io.prometheus.client.exporter.HTTPServer$HTTPMetricHandler.handle (HTTPServer.java:59)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:77)
    at sun.net.httpserver.AuthFilter.doFilter (AuthFilter.java:82)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:80)
    at sun.net.httpserver.ServerImpl$Exchange$LinkHandler.handle (ServerImpl.java:685)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:77)
    at sun.net.httpserver.ServerImpl$Exchange.run (ServerImpl.java:657)
    at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1167)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:641)
    at java.lang.Thread.run (Thread.java:844)
[WARNING]
java.lang.NoSuchFieldError: timestampMs
    at io.prometheus.client.exporter.common.TextFormat.write004 (TextFormat.java:49)
    at io.prometheus.client.exporter.HTTPServer$HTTPMetricHandler.handle (HTTPServer.java:59)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:77)
    at sun.net.httpserver.AuthFilter.doFilter (AuthFilter.java:82)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:80)
    at sun.net.httpserver.ServerImpl$Exchange$LinkHandler.handle (ServerImpl.java:685)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:77)
    at sun.net.httpserver.ServerImpl$Exchange.run (ServerImpl.java:657)
    at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1167)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:641)
    at java.lang.Thread.run (Thread.java:844)
[WARNING]
java.lang.NoSuchFieldError: timestampMs
    at io.prometheus.client.exporter.common.TextFormat.write004 (TextFormat.java:49)
    at io.prometheus.client.exporter.HTTPServer$HTTPMetricHandler.handle (HTTPServer.java:59)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:77)
    at sun.net.httpserver.AuthFilter.doFilter (AuthFilter.java:82)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:80)
    at sun.net.httpserver.ServerImpl$Exchange$LinkHandler.handle (ServerImpl.java:685)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:77)
    at sun.net.httpserver.ServerImpl$Exchange.run (ServerImpl.java:657)
    at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1167)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:641)
    at java.lang.Thread.run (Thread.java:844)
[WARNING]
java.lang.NoSuchFieldError: timestampMs
    at io.prometheus.client.exporter.common.TextFormat.write004 (TextFormat.java:49)
    at io.prometheus.client.exporter.HTTPServer$HTTPMetricHandler.handle (HTTPServer.java:59)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:77)
    at sun.net.httpserver.AuthFilter.doFilter (AuthFilter.java:82)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:80)
    at sun.net.httpserver.ServerImpl$Exchange$LinkHandler.handle (ServerImpl.java:685)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:77)
    at sun.net.httpserver.ServerImpl$Exchange.run (ServerImpl.java:657)
    at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1167)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:641)
    at java.lang.Thread.run (Thread.java:844)
[WARNING]
java.lang.NoSuchFieldError: timestampMs
    at io.prometheus.client.exporter.common.TextFormat.write004 (TextFormat.java:49)
    at io.prometheus.client.exporter.HTTPServer$HTTPMetricHandler.handle (HTTPServer.java:59)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:77)
    at sun.net.httpserver.AuthFilter.doFilter (AuthFilter.java:82)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:80)
    at sun.net.httpserver.ServerImpl$Exchange$LinkHandler.handle (ServerImpl.java:685)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:77)
    at sun.net.httpserver.ServerImpl$Exchange.run (ServerImpl.java:657)
    at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1167)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:641)
    at java.lang.Thread.run (Thread.java:844)
[WARNING]
java.lang.NoSuchFieldError: timestampMs
    at io.prometheus.client.exporter.common.TextFormat.write004 (TextFormat.java:49)
    at io.prometheus.client.exporter.HTTPServer$HTTPMetricHandler.handle (HTTPServer.java:59)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:77)
    at sun.net.httpserver.AuthFilter.doFilter (AuthFilter.java:82)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:80)
    at sun.net.httpserver.ServerImpl$Exchange$LinkHandler.handle (ServerImpl.java:685)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:77)
    at sun.net.httpserver.ServerImpl$Exchange.run (ServerImpl.java:657)
    at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1167)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:641)
    at java.lang.Thread.run (Thread.java:844)
[WARNING]
java.lang.NoSuchFieldError: timestampMs
    at io.prometheus.client.exporter.common.TextFormat.write004 (TextFormat.java:49)
    at io.prometheus.client.exporter.HTTPServer$HTTPMetricHandler.handle (HTTPServer.java:59)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:77)
    at sun.net.httpserver.AuthFilter.doFilter (AuthFilter.java:82)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:80)
    at sun.net.httpserver.ServerImpl$Exchange$LinkHandler.handle (ServerImpl.java:685)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:77)
    at sun.net.httpserver.ServerImpl$Exchange.run (ServerImpl.java:657)
    at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1167)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:641)
    at java.lang.Thread.run (Thread.java:844)
[WARNING]
java.lang.NoSuchFieldError: timestampMs
    at io.prometheus.client.exporter.common.TextFormat.write004 (TextFormat.java:49)
    at io.prometheus.client.exporter.HTTPServer$HTTPMetricHandler.handle (HTTPServer.java:59)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:77)
    at sun.net.httpserver.AuthFilter.doFilter (AuthFilter.java:82)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:80)
    at sun.net.httpserver.ServerImpl$Exchange$LinkHandler.handle (ServerImpl.java:685)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:77)
    at sun.net.httpserver.ServerImpl$Exchange.run (ServerImpl.java:657)
    at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1167)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:641)
    at java.lang.Thread.run (Thread.java:844)
[WARNING]
java.lang.NoSuchFieldError: timestampMs
    at io.prometheus.client.exporter.common.TextFormat.write004 (TextFormat.java:49)
    at io.prometheus.client.exporter.HTTPServer$HTTPMetricHandler.handle (HTTPServer.java:59)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:77)
    at sun.net.httpserver.AuthFilter.doFilter (AuthFilter.java:82)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:80)
    at sun.net.httpserver.ServerImpl$Exchange$LinkHandler.handle (ServerImpl.java:685)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:77)
    at sun.net.httpserver.ServerImpl$Exchange.run (ServerImpl.java:657)
    at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1167)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:641)
    at java.lang.Thread.run (Thread.java:844)

/cc @songy23

This seems to be related to https://github.com/prometheus/client_java/pull/337. Prometheus added the optional timestamp field recently this year, and the Prometheus exporter doesn't set this field.
However, since Prometheus specified timestamp as an optional field, I would not expect to see so many warnings when timestamp is unset. I'll create an issue to Prometheus to follow up.

Filed https://github.com/prometheus/client_java/issues/384 to follow up.

Hi @odeke-em , the Prometheus team thought recompiling the project should resolve this:

That warning is not coming from us, it's from Java. From a quick search it sounds like your users need to recompile their projects from scratch.

Could you try this?

Maybe you dependency simpleclient_common-0.3.0.jar, which simple-client:0.2.0 does not support, especially in TextFormat.java:49, it should really throw NoSuchFieldError: timestampMs

Hi @odeke-em I just made a 0.14.0-SNAPSHOT release of OC-Java that upgraded to the latest Prometheus version. I made a PR to update the dependencies in your demo code: https://github.com/orijtech/opencensus-for-grpc-java-developers/pull/1. Could you try running the demo application with the updated dependencies and see how it works?

Hi @odeke-em , the Prometheus team thought recompiling the project should resolve this:

Thank you for the followup @songy23! Oh yes, I have done that quite a number of times, recompiling from scratch. Perhaps they mean something else? Does running the repro that I produced work alright on your side? With Prometheus also started too?

Maybe you dependency simpleclient_common-0.3.0.jar, which simple-client:0.2.0 does not support, especially in TextFormat.java:49, it should really throw NoSuchFieldError: timestampMs

Thank you @seedily for the recommendation. @songy23 what do you think?

Hi @odeke-em I just made a 0.14.0-SNAPSHOT release of OC-Java that upgraded to the latest Prometheus version. I made a PR to update the dependencies in your demo code: orijtech/opencensus-for-grpc-java-developers#1. Could you try running the demo application with the updated dependencies and see how it works?

Cool, but unfortunately I just tried again and it still crashes
java.lang.NoSuchFieldError: timestampMs
    at io.prometheus.client.exporter.common.TextFormat.write004 (TextFormat.java:49)
    at io.prometheus.client.exporter.HTTPServer$HTTPMetricHandler.handle (HTTPServer.java:59)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:77)
    at sun.net.httpserver.AuthFilter.doFilter (AuthFilter.java:82)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:80)
    at sun.net.httpserver.ServerImpl$Exchange$LinkHandler.handle (ServerImpl.java:685)
    at com.sun.net.httpserver.Filter$Chain.doFilter (Filter.java:77)
    at sun.net.httpserver.ServerImpl$Exchange.run (ServerImpl.java:657)
    at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1167)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:641)
    at java.lang.Thread.run (Thread.java:844)

Hmmm I did exactly what @seedily suggested in 0.14.0-SNAPSHOT release, and now the Prometheus versions in your demo should be consistent after https://github.com/prometheus/client_java/issues/384.
I'll try to reproduce this error later today. If I cannot find anything wrong on OC side, I'll turn to Prometheus for help.

Closing - now that we published the v0.14.0 release, please use v0.14.0 OC-Java and 0.4.0 Prometheus simpleclient, the Prometheus versions should be consistent now. Please reopen if updating the versions doesn't resolve this issue.


e2e test: gen1 cluster: linked updates (bundle, profile, clusterspec change)

closing this since gen 1 is being deprecated.


Update the Commit Badage Instead of monthly to ----> all

As i have seen the monthly commit where not shown on your site i have change it -----> all .
and only the monthly commits was showing error and all others where working .

|
changes to
|

Better to patch the monthly badge than just hiding it ..


Player improvement

Checklist

[X] I have filled out the template to the best of my ability.
[X] This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
[X] This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.
It's actually no problem
Describe the solution you'd like
I would like, if possible, to improve the experience with the player with these requests, it's actually more than one:

Add playlist name in main Playing section, as info
Add “LIKE/(+) BUTTON” in the Play/next... section of the player, to add the track to favorites/followed track
Inside the Playlist or Album, Artist tracklist’s section , when clicking on the track, instead of play just that track (so a tracklist with 1 element), start to play the tracklist from that one, like it happens in the mobile Spotify app
back button pressed go back to beginning if time from track begin is < 2-3 secs, else go to previous track. Now it goes directly to previous track

Describe alternatives you've considered
Use the player as it is.
Additional context
no screenshot

Add playlist name in main Playing section, as info
You can use the following title formatter options to add the playlist name (and many other things) to the main playing section.  See the link above for all of the available options.

{player.sp_playlist_name} Playlist name being played, if the current context is a playlist (e.g. "Daily Mix 1").
{player.sp_playlist_name_title} Playlist name being played along with a "Playlist: " prefix, if the current context is a
Like so:

Add “LIKE/(+) BUTTON” in the Play/next... section of the player, to add the track to favorites/followed track
I'm torn on this one, as the favorite functionality is already included in the "information" popup - it's just an extra click to get there, but it gives you all 3 favorite settings in one place (track, artist, album).  Let me think about it
Inside the Playlist or Album, Artist tracklist’s section , when clicking on the track, instead of play just that track (so a tracklist with 1 element), start to play the tracklist from that one, like it happens in the mobile Spotify app
I can probably get this added in the next release.
Back button pressed go back to beginning if time from track begin is < 2-3 secs, else go to previous track.  Now it goes directly to previous track
I can probably get this added in the next release.

Inside the Playlist or Album, Artist tracklist’s section , when clicking on the track, instead of play just that track (so a tracklist with 1 element), start to play the tracklist from that one, like it happens in the mobile Spotify app
This behavior was changed in the latest version of the card to add the selected item to the play queue (instead of playing the track immediately).  Based on the behavior that I have observed with the Spotify desktop player, it will play queue items immediately after the current song ends, then resume play in the selected playlist.  Can you verify that you have the latest card version installed?
Note that the older version of the card simply started playing the selected track and stopping play after that.

Released v1.0.19 of the card.
[ 1.0.19 ] - 2024/12/15

Added favorite indicator to the player section form for track, show episode, and audiobook items.  The heart icon will be displayed to the right of the item name.  A solid red heart indicates the item is a favorite; a transparent heart indicates the item is not a favorite.
Added "Play All Track Favorites" action to the track favorites section actions.  This will get a list of the tracks saved in the current Spotify user's 'Your Library' and starts playing them, with shuffle enabled..
Added logic to player PREVIOUS_TRACK control so that if more than 8 seconds have passed the currently playing track is just restarted from the beginning; otherwise, the previous track is selected if progress is past the 8 second point.

Request complete.

Sorry but I have been very busy in the last weeks and didn't play much with the card, I will check the requests.
Happy holidays!


Add kPa from start

I am very much not a fan of all this data output, but this is an improvement over what we have now, at least.


There should be instructions for manual installation

In my project I can't run react-native link <package-name> because it just hangs and re-links already linked packages.
So there should be instructions for linking this package manually.

Has anyone come around with this already? react-native link doesn't play well with multi targets and android flavors.

@mcchrish I recommend you to try the following:

Create a new project
Commit any changes
Then link the library
Finally, with git check what are the changes after linking and apply them manually
I know this is tedius but it's the best way to avoid any issues due to linking

It would be great if anybody could put what's required for manual installation. If I can get it working I'll post back here but any help would be appreciated.

On iOS,
if you are using Cocoapods, add the following to the Podfile.

pod 'RNGestureHandler', :git => 'https://github.com/kmagiera/react-native-gesture-handler', :tag => '1.3.0'
Note- values to :tag (or you may want to specify a branch) could vary according to your need or/and the time you are doing the linking. Best way would possibly be to look at the podspec file within your /node_modules/react-native-gesture-handler/RNGestureHandler.podspec

Run pod install on the native side

You're good to go.
If you are not using Cocoapods, you will have to follow this and link it manually.
These instructions probably apply to most, if not all, of the libraries that has native dependencies.

What about Android, though?

About Android- In the process of figuring out. Any help there appreciated.

I was able to install it on a clean React Native app so I’ll try to compile the instructions and add them here and create a PR for the README.
On Jun 19, 2019, 4:33 AM -0600, MadhuvanthGopalan<EMAIL_ADDRESS>wrote:

About Android- In the process of figuring out. Any help there appreciated.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

This issue was not active for some time so I'm closing it.
If you need further help please reply.


Added _mm_unpacklo_ps, _mm_movehl_ps, _mm_movelh_ps and _mm_shuffle_ps

Squashing commits from #39 .
@alexcrichton The shuffle intrinsic involves a macro that expands for each shuffle mask (8 bits -> 256 cases). Thus I have removed the probably_only_one_instruction flag from the assert-instr macro. Let me know if this is fine or whether we should find another solution.

@mohanrajendran shouldn't _mm_shuffle_ps be corresponding to just one instruction? I figured it may be either a bug in the code or our own codegen if it's generating a whole lot more

@alexcrichton : Because the simd_shuffle4 requires constant values as its selector parameter, I am using @BurntSushi 's macros sse2.rs to expand each possible input mask to its own call of simd_shuffle4. This is generating many repeating instructions at disassembly(8 bit => 256 cases). Maybe there is a better way to do this?

Maybe in this case it's too many layers of indirection for LLVM to see through? It may be the case that a different macro expansion would work here?

@mohanrajendran LLVM should optimize through that. Are you checking the disassembly produced when optimizations are enabled? But yeah, I certainly could have made a mistake. I'll try to look into this myself and double check that other uses of the macro are correct.

Oh so actually what I think is happening is that the instruction itself must take an immediate. When we take the function pointer where one of the arguments is still a variable then LLVM has no choice to but to generate a ton of instructions (a jump table). Typically though with inlining LLVM will eliminate all other branches and just take one of them.
In that sense @mohanrajendran I think you're right, removing the limit on instructions here sounds like the best way to go.

I think one of the failures on AppVeyor is legitimate:
---- x86::sse::assert_instr__mm_movehl_ps stdout ----
        disassembly for stdsimd::x86::sse::_mm_movehl_ps:
         0: push rbp
         1: mov rbp,rsp
         2: movapd xmm0,xmmword ptr [rdx]
         3: unpckhpd xmm0,xmmword ptr [rcx]
         4: pop rbp
         5: ret
         6: ��
thread 'x86::sse::assert_instr__mm_movehl_ps' panicked at 'failed to find instruction `movhlps` in the disassembly', assert-instr\src\lib.rs:288:8
note: Run with `RUST_BACKTRACE=1` for a backtrace.

as for the others, I can't reproduce locally :(

When we take the function pointer where one of the arguments is still a variable then LLVM has no choice to but to generate a ton of instructions (a jump table). Typically though with inlining LLVM will eliminate all other branches and just take one of them.

Oh man, that's nasty... Is there a way to fix assert-instr to account for this?

@BurntSushi now that I actually think about this, how about...
pub fn the_intrinsic(...) -> R {
}

#[cfg(test)]
#[assert_instr(foo)]
fn the_test(a: T, b: T) -> R {
    the_intrinsic(a, b, 1)
}

@mohanrajendran does that make sense for testing this?

Alright @mohanrajendran looks like that last strategy worked for fixing up the test while keeping the length assertions, so I've merged. Thanks so much again!


bug: memory leak when sending high tps

Memory just keeps climbing without going down

We are aware of this, happens with high tps. Let us know if you identify anything that could be causing it!

resolved by #12


BTPlayer::restart() crashes if behavior tree is missing

Godot version
4.2.2
LimboAI version
v1.1.0
LimboAI variant
GDExtension / AssetLib
Issue description
When BTPlayer::restart() is called while there is no behavior tree, game crashes. The offending line seems to be this one:

Quick fix would be:

How to reproduce

Create an empty (no behavior tree) BTPlayer node
Invoke its restart() from code

Thanks for reporting


Calling viewWillAppear of main controller on drawer opening and closing

@varunmehta77 can you please describe this issue, or close it. An issue with nothing but a title is no help to maintainers.

I have another issue.. I think similar to this...I have close then view will appear called. I want View as it is nothing want refresh..any method for this or delegate for this ?


Synapse fix aad devops and github repos parameters

Issue-686
PR Checklist

[ ] I have added example(s) inside the [./examples/] folder
[ ] I have added the example(s) to the integration test list for normal (~30 minutes) or long runner >30 minutes
[x] I have checked the coding conventions as per the wiki
[x] I have checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

[ ] YES
[x] NO

Testing

thanks for your contribution to CAF @SimonSouli!