there is no scroll up button at the landing page

allow me to add the scroll up button over the landing by doing some major changes like css and javscript
please assign me this under gssoc extd 24, hactober fest , please make it level 2 please  mam .....
@arushi2610

Closing the issue, kindly raise a PR when you're done.

why
so i should do it without getting assigned

whatever i am raising the pr

@arushi2610 I believe this Issue was closed by mistake. Kindly revert

@arushi2610 you do not close an issue when you want someone to work on it. Kindly assign @2004pra and open this issue again. Otherwise it will not be counted.


staticCache doesn't set max-age

I'll probably fix this myself at some point and submit the changes, but in case I don't...
connect.static() lets you specify maxAge as a parameter, for cache control. This is great for the client. :)
However the moment you use connect.staticCache() maxAge doesn't get set at all, and images are no longer cached by the client. So what you gain in speed on the server, the client takes away by generating more requests. :/

This is very likely something I missed. I will find time over the next few days to fix it.

Hmmm, ok so I did some more investigation and I apologise, I don't think its a fault with your work at all! :/
I think it's related to connect-gzip, which I am also using. I suspect I'm not passing maxage to that so it isn't getting passed through properly.
Sorry to waste your time!


Merge release commits

Purpose
$Subject

Merged with https://github.com/ballerinax/kubernetes/pull/323


chore: Add features of cargo

Description
This PR enables user to enable cargo's features such as vendored-libgit2, vendored-openssl.
Why
cargo-docs depends on cargo crate, and it depends on git2 crate.
git2 uses library named libgit2, and give us options:

compile and statically link to a copy of libgit2 (vendored-libgit2 feature)
use installed libgit2 on system

But, we cannot use libgit2 on system in some environment, such as WSL2.
At least on my environment, I did cargo install cargo-docs and run cargo-docs, but I got following error:
target/debug/cargo-docs: error while loading shared libraries: libgit2.so.1.7: cannot open shared object file: No such file or directory

So I had to enable vendored-libgit2 feature.
(I'm Japanese student learning English so please forgive me if my English includes any mistakes ;)

Awesome! I'll publish a new release today with your patch, hope it fixes the issue :)


Issue 61: Add Method for MacOS (caffeinate) using new API

Basically the same method as in previous versions of wakepy, but now as subclass of wakepy.Method.
Adds support for MacOS for wakepy 0.8.0

I could not test this fully as I have no access to Macs, but this should do exactly the same as in previous versions of wakepy. Although, the args were previously
ARGS = [
    "-d",  # Prevent the display from sleeping.
    "-u",  # Create an assertion to declare that user is active. If the dis-
    # play is off, this option turns the display on and prevents the
    # display from going into idle sleep.
    "-t 2592000",  # Set timeout to 1-month
    # (default is 5 seconds for -u option)
]

in keep.presenting mode, and now they're just ["-d"].


Support multiple climate devices of the same code

My house has two 'BRC4C156' installations, each with its own remote.  The remote for one installation will not work for the other so I'm pretty sure they're emitting different IR codes.  I know the code files support multiple "operation modes" and multiple "fan modes".  Would it be possible to have code file support multiple installations of the same climate device as well?  Thanks.

in configuration.yaml

climate: !include my_climate.yaml

in my_climate.yaml
- platform: smartir
  name: Livingroom_smartir
  unique_id: smartirclimatelivingroom
  device_code: 2700
  controller_data: remote.rm_pro_livingroom_remote
  temperature_sensor: sensor.lywsd02_temp
  humidity_sensor: sensor.lywsd02_hum
  power_sensor: binary_sensor.0x00158d0002767720_contact

- platform: smartir
  name: MasterBedroom_smartir
  unique_id: smartirclimatemasterbedroom
  device_code: 2700
  controller_data: remote.rm_mini3_masterbedroom_remote
  temperature_sensor: sensor.0x00158d0001e6d867_temperature
  humidity_sensor: sensor.0x00158d0001e6d867_humidity
  power_sensor: binary_sensor.0x00158d00024653b1_contact

Works fine for me.

Maybe Kolin devices are different from Daikin?  I believe having two Daikin units means that the remotes pair to each unit emit different IR codes.  For example, I can't use my Daikin #1 remote to control my Daikin #2 unit.  Can you use your Kolin livingroom remote to control your Kolin masterbedroom unit?
-Eric
---- On Sat, 17 Jul 2021 03:07:48 -0700 CY @.***> wrote ----
in configuration.yaml
climate: !include my_climate.yaml
in my_climate.yaml

platform: smartir
name: Livingroom_smartir
unique_id: smartirclimatelivingroom
device_code: 2700
controller_data: remote.rm_pro_livingroom_remote
temperature_sensor: sensor.lywsd02_temp
humidity_sensor: sensor.lywsd02_hum
power_sensor: binary_sensor.0x00158d0002767720_contact

platform: smartir
name: MasterBedroom_smartir
unique_id: smartirclimatemasterbedroom
device_code: 2700
controller_data: remote.rm_mini3_masterbedroom_remote
temperature_sensor: sensor.0x00158d0001e6d867_temperature
humidity_sensor: sensor.0x00158d0001e6d867_humidity
power_sensor: binary_sensor.0x00158d00024653b1_contact

Works fine for me.
—
You are receiving this because you authored the thread.
Reply to this email directly, https://github.com/smartHomeHub/SmartIR/issues/655#issuecomment-881871458, or https://github.com/notifications/unsubscribe-auth/AKHV23J4R24N5QY5HRI7A6DTYFI7JANCNFSM47K2IK3Q.
Eric Lin
408-781-5399


Refactor code style

Pull Request Test Coverage Report for Build 975

18 of 29 (62.07%)  changed or added relevant lines in 17 files are covered.
10 unchanged lines in 7 files lost coverage.
Overall coverage decreased (-0.003%) to 68.788%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/core/execute/metadata/TableMetaDataInitializer.java
0
1
0.0%

sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/core/execute/metadata/TableMetaDataLoader.java
0
1
0.0%

sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/LogicSchema.java
0
1
0.0%

sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/sctl/utils/SCTLUtils.java
0
1
0.0%

sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/datasource/dialect/MariaDBDataSourceMetaData.java
0
2
0.0%

sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/core/execute/sql/execute/SQLExecuteCallback.java
0
2
0.0%

sharding-core/sharding-core-api/src/main/java/org/apache/shardingsphere/spi/database/DataSourceInfo.java
0
3
0.0%

Files with Coverage Reduction
New Missed Lines
%

sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/datasource/dialect/MariaDBDataSourceMetaData.java
1
0.0%

sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/spi/database/H2DatabaseType.java
1
80.0%

sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/spi/database/OracleDatabaseType.java
1
75.0%

sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/spi/database/PostgreSQLDatabaseType.java
1
75.0%

sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/spi/database/SQL92DatabaseType.java
1
75.0%

sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/spi/database/SQLServerDatabaseType.java
1
75.0%

sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/core/execute/metadata/TableMetaDataLoader.java
4
0.0%

Totals

Change from base Build 570:
-0.003%

Covered Lines:
11676

Relevant Lines:
16974

💛  - Coveralls


Game crashes when crafting on a pyre or fey crafter

General Information
At the start of crafting items on a pyre or fey crafter the game crashes with a server connection error (I'm playing single player)
But the last time it issued such an error with a crash log (attached)
crash-2021-10-06_23.42.06-client.txt
you put all the necessary items on the pyre, set it on fire - the game crashes
also with fey crafter

Can you try updating to 3.1.3?

Can you try 3.1.4? I released 3.1.3 but it had a dependency issue, so it's been archived. The latest is now 3.1.4, which requires MysticalLib 1.13.


add tag support for repository

when developing a project across platforms, we may need to create a separated project for each platform, and we want them to share the same project name, then things will become confusing when we browse them in Gogs. Of course we can use prefix to distinguish them instead, but I'm not sure that is the best practice,  like we have a network library for both android and ios platforms, we may not want to create an 'android_network' and 'ios_network' projects. As a simple solution, I believe a tag on project will work, show tags in project list and tag filter on the top, that will be enough. Does anyone has the same thoughts?

+1

Duplicated to https://github.com/gogits/gogs/issues/1253?

Yes, same with the first part of it, applying labels and label filter to repositories. Sorry I didn't find it using keyword 'tag'.


Add the first iteration of the Zinc API 1.0

This is just the first iteration of the Zinc API.
This iteration's goal is to make safe functionality of Zinc public to allow Scala and Java parties (Gradle, Pants, Maven, et cetera) use Zinc with binary compatibility guarantees. This task needs another iteration given:

The big surface of the API; and,
The fact that the whole Zinc API was made private for 1.0 (!).

The last iteration will happen before RC1 (end of June - beginning of July).
The new public API makes it easier to:

Get a compiled bridge for a given scala instance (via ivy).
Get a scala instance (via ivy).
Instantiate a Zinc compiler.
Provide utilities for both Java and Scala users to get default implementations that do not expose the internals, placed in sbt.internal.inc.

Aside from these, this API also addresses some issues that have arisen in the past:

It makes it easier to customize the classfile manager, as required by Scalajs and Scala Native. https://github.com/sbt/zinc/issues/125
It replaces any instance of Maybe with Optional. https://github.com/sbt/zinc/issues/302

I find that in general, these commits make Zinc easier to use and improve the consistency of the whole API. The most remarkable change is the CompileAnalysis API, which now provides useful information for build tools like file stamps, compilations and source infos.
Note that all the utilities made public only expose functionality that is a product of the incremental compiler. No internal details of the incremental analysis are exposed to the users.
There are some Java files that have been moved out of the compiler interface because they required static method implementations in the projects on which the implementations of certain classes were provided.
In the future, I feel that these are the things that should be worked on to finish off the Zinc API:

Reorder project structure. Simplify it and make it more granular and easier to test. https://github.com/sbt/zinc/issues/286
Decide what and how to use to persist analysis files with appropriate benchmarking. https://github.com/sbt/zinc/issues/268 (protobuf is not possible, so we need to find a way to either use sbinary or a similar solution that does not harm (or even improve!) speed of compiler iterations).
Create utilities to instantiate:
3.1. Empty Analysis.
3.2. DefinesClass.
3.3. AnalysisStore (up to discussion for next iteration).
3.4. JavaTool et al, necessary to create Compilers.
3.5. PerClasspathLookupEntry.
Make analysis content machine-independent: #218

I have more ideas, but those will be discussed when time's up.
The breaking changes are documented in every commit. I suggest that reviewers go through the commits one by one, though I don't expect them to do so (given the big diff size). As this is just the first iteration of the redesign and targets a milestone, I am not writing any migration notes for now. I'll wait until everything is finished in our first RC to write the migration notes so that other build tools (other than sbt) can start using it.
As a reminder, the public API is xsbti. Scala implementations live in sbt.internal.inc.
This is a good time to gather feedback. So that's very much welcome.

As a test, could we put zinc/src/test/scala/sbt/inc/*Spec.scala into another package name like com.example, and see if it's able to initialize everything without invoking the internals?
While I agree with getting rid of Maybe and using Optional it's a bit distracting to review it because it spans across everywhere. How difficult do you think it would be to split Maybe change into a another PR that precedes this?

As a test, could we put zinc/src/test/scala/sbt/inc/*Spec.scala into another package name like com.example, and see if it's able to initialize everything without invoking the internals?

This is a good idea. I'ld like to do this in the second iteration, since there are still some things that must be got from internal. Those I specify in the PR description, but I may be missing more.

While I agree with getting rid of Maybe and using Optional it's a bit distracting to review it because it spans across everywhere. How difficult do you think it would be to split Maybe change into a another PR that precedes this?

The diff for the maybe migration is small, see https://github.com/sbt/zinc/pull/304/commits/686b6bb174fe76390646a7e7770914906fefc2f1. For time-consuming reasons, I would prefer to get it merged in this PR.

Feedback has been addressed @eed3si9n.

Tests are green.

Thanks for all the work on this.

With regard to additional private/internal APIs that are currently in use, can browse through https://github.com/pantsbuild/pants/tree/master/src/scala/org/pantsbuild/zinc (as of zinc 1.0.0-X7) ... I'm currently working on updating to include this patch.

@stuhood I've been browsing through that for a while, but thanks for the heads up. Are you in a hurry to do this? I'll be tackling the second iteration of the API soon before the release candidate and the API freeze, so maybe you want to wait until that's out?

The change I made to sbt is https://github.com/sbt/sbt/pull/3228

@jvican : It would probably make sense for me to continue to attempt this, just in order to find any additional issues that you might not have seen. As an example, yesterday I noticed that it's not currently possible to extend LoggerReporter in a useful way, because various methods were made private. So https://github.com/pantsbuild/pants/blob/master/src/scala/org/pantsbuild/zinc/logging/Reporters.scala#L28 is no longer possible.

So https://github.com/pantsbuild/pants/blob/master/src/scala/org/pantsbuild/zinc/logging/Reporters.scala#L28 is no longer possible. A theoretical FilteredReporter wrapper might make more sense anyway though.

Great, I'll make this (or something similar, I have to look into the details) happen to unblock that implementation.

@jvican: A few more details here:

the Reporter API seems to require a ManagedLogger, but it's not clear how (or whether it would be a good idea) to create one of those, versus passing in an xsbti.Logger or sbt.util.Logger
Because a Reporter is a required parameter for IncrementalCompilerImpl.compile (and there doesn't appear to be a way to create a LoggerReporter without a ManagerLogger), it does not currently seem to possible to compile using the 18 arg form.

I'm going to try porting to usage of xsbti.Inputs instead.

Alright, I ported to xsbti.compile.Inputs, and it cleared things up considerably. But the above issue with LoggerReporter and ManagedLogger is still an issue.
Also, it doesn't look like it's possible to use a "default" Reporter (as it is with Progress, which is Optional)... it's conceivable that at some point in the future we'll move the log filtering out of the Reporter, at which point being able to use the default would be good.

@stuhood: Yes, it seems that the entanglement between LoggerReporter and ManagedLogger is due to sbt. It's an API where sbt's design decisions leak too much.
To overcome this issue, some of Zinc's test suites create a ConsoleReporter that is a direct subclass of Reporter and just printlns, but that's far from desirable. I think I am going to create a ManagedLogger for Zinc and expose it somewhere, or at least make it trivial to create a Zinc reporter. I am working on it as we speak.
With regards to making the reporter Optional, I have my doubts this is the best choice. It's such a key component of the compilation that I would prefer that users explicitly pass it. Also, depending on the use case, it's likely to be changed. What is a safe assumption for the user? Will Zinc output to my console? Since it's not obvious, I believe users may be better off being more explicit about what they want. I guess that you need for this would disappear if we add methods to instantiate zinc reporters that you can pass in. WDYT?

For the record, if you want to move forward and need a ManagedLogger, you can do sbt.util.LoggerExchange.logger(...).

What is a safe assumption for the user? Will Zinc output to my console? Since it's not obvious, I believe users may be better off being more explicit about what they want. I guess that you need for this would disappear if we add methods to instantiate zinc reporters that you can pass in. WDYT?

Yea, that makes sense. I'm still thinking of zinc as a CLI tool, but in the context of a library, being explicit about output location is important... ditto logging.

Hey @stuhood, I've been fixing all the issues you've reported regarding logging. I think I have come up with some elegant solutions you may want to have a look at.
This is the most important change: https://github.com/scalacenter/zinc/commit/a9a9c2faf3b511c0f95b19fab87eea2e67346408.
All the changes are in this branch: https://github.com/sbt/zinc/compare/1.0...scalacenter:fix-loggers.
I can release these changes as part of a temporary scalacenter/zinc release to unblock you and get more feedback. These changes will need, of course, to be merged upstream in sbt/zinc.
In the new interface, I have added a filtered reporter in Zinc and the normal LoggerReporter (now renamed to LoggedReporter, see https://github.com/scalacenter/zinc/commit/cac014918ec6d4ff20b257d8363256739d5645e1). LoggedReporter now accepts xsbti.Logger, meaning that you can pass in whatever logging mechanism you want so long as it extends that interface. These reporter implementations are internal, but you can get a reporter backed up by a logger via the public ReporterUtil: https://github.com/scalacenter/zinc/commit/60820b18b7d56f0b7c9e9a9ae267c2e5bc50b59c.
Let me know if this public API works for you.

Thanks @jvican . The API looks great (with one exception mentioned below): thanks for incorporating file/msg based filtering.
I should be able to sanity check incremental compile before the end of Monday.
There is a bit of inconsistency between java.util.function.Function and xsbti.F1 for positionMappers in ReporterUtil and CompileOptions. pants currently only requires JDK7, but I'm floating the idea of switching to JDK8 now... Function should be fine, but consistency would be good.

@stuhood Happy that you mention that, I opened a PR in sbt/util to address that issue three days ago. The idea is to remember any trace of the old Java-friendly classes for bincompat (F0, F1 and Maybe) and replace them by the default Java ones (Supplier, Function and Optional).
https://github.com/sbt/util/pull/84

The new API looks good from a logging/usability perspective (other than #317). I have things working well enough to have reproduced https://github.com/pantsbuild/pants/issues/4477, so I will begin debugging that tomorrow.

@jvican : If you have a PR for the Reporters/Logger change, I'd shipit. I'm getting close to needing an X17 release to move forward.

Shipping it tomorrow morning. It's ready but kept it local because I'm changing more things in the API.


cannot make directory "C:/Program Files/bsf/bin//Data": No such file or directory

When running cmake --build . --config Release --target install (after building with VS2017)
where the error happens :
setlocal                                                                                "C:\Program Files\CMake\bin\cmake.exe" -DBUILD_TYPE=Release -P cmake_install.cmake                                              if %errorlevel% neq 0 goto :cmEnd                                                                                :cmEnd                                                                                endlocal & call :cmErrorLevel %errorlevel% & goto :cmDone                                                                       :cmErrorLevel                                                                                exit /b %1                                                                                :cmDone                                                                                if %errorlevel% neq 0 goto :VCEnd                                                                                :VCEnd                                                                                -- Install configuration: "Release"                                                                                -- Installing: C:/Program Files/bsf/bin//Data                                                                                CMake Error at Source/cmake_install.cmake:36 (file):                                                                              file INSTALL cannot make directory "C:/Program Files/bsf/bin//Data": No                                                         such file or directory                                                                                Call Stack (most recent call first):                                                                                cmake_install.cmake:37 (include)

It should work if you run the command with administrator permissions, or change the install folder somewhere off the system drive.

Is the default install configurable through CMake or in the makefiles themselves ?

You can set the CMAKE_INSTALL_PREFIX through CMake. With makefiles you should also be able to set DESTDIR, but I don't think there is such an option for a VS build.

Thanks !!


[rcamera] Added missing CAMERA_CUSTOM check in  UpdateCamera(Camera *camera, int mode) function

rcamera.h states that if UpdateCamera() is passed CAMERA_CUSTOM as an argument; the function  will do nothing. Source: https://github.com/raysan5/raylib/blob/master/src/rcamera.h#L120
However, the implementation of UpdateCamera(), has no checks to see if the mode passed is CAMERA_CUSTOM.
https://github.com/raysan5/raylib/blob/master/src/rcamera.h#L438C6-L464
If UpdateCamera receives CAMERA_CUSTOM as argument; it will execute all the camera updating functions from lines 458 to 463.
This has the following effect:
https://github.com/raysan5/raylib/assets/65001595/a853549f-bb17-47af-b79b-ef2021d2ef12
After the patch is applied; this behavior changes:
https://github.com/raysan5/raylib/assets/65001595/121953c7-779c-4e41-9cbe-89f61abd9b00
Now UpdateCamera() won't modify the camera regardless of Mouse movement or keyboard movement (Which, is the intended behavior; right?)
This is the code that is used in the video:
Camera3D camera {
    {0, 0, 5},
    {0, 0, 0},
    {0, 1, 0},
    90,
    CAMERA_PERSPECTIVE,
};

CameraMode mode = CAMERA_FREE;

int main(void)
{
    // Initialization
    //--------------------------------------------------------------------------------------
    const int screenWidth = 800;
    const int screenHeight = 450;

    InitWindow(screenWidth, screenHeight, "raylib CAMERA_CUSTOM");

    SetTargetFPS(60);   // Set our game to run at 60 frames-per-second
    //--------------------------------------------------------------------------------------

    // Main game loop
    while (!WindowShouldClose())    // Detect window close button or ESC key
    {
        UpdateCamera(&camera, mode);

        BeginDrawing();

	  BeginMode3D(camera);

	  ClearBackground(RAYWHITE);
	  if (IsKeyPressed(KEY_T)) {
	      printf("\n");
	      printf("I am teleporting the camera and setting it to custom mode\n");
	      printf("\n");
	      mode = CAMERA_CUSTOM;
	      camera.position.x = 0;
	      camera.position.y = 5;
	      camera.position.z = 0;
	  }
	  DrawText(TextFormat("Score: %08i", 999), 200, 80, 20, RED);

	  DrawCube({0,0,0}, 4, 4, 4, BLUE);

	  EndMode3D();
        EndDrawing();
    }

    // De-Initialization
    //--------------------------------------------------------------------------------------
    CloseWindow();        // Close window and OpenGL context
    //--------------------------------------------------------------------------------------

    return 0;

}

PS: I am not mistaken; this would be the only/first use of CAMERA_CUSTOM in raylib.
PS2: There's a difference in the comments in between raylib.h and rcamera.h. Is this intentional? Should I add another commit making them the same?
Rcamera (comment is slightly more verbose): https://github.com/raysan5/raylib/blob/master/src/rcamera.h#L120
Raylib (comment is more bare bones):  https://github.com/raysan5/raylib/blob/master/src/raylib.h#L916

You don't need to call UpdateCamera when using CAMERA_CUSTOM though I guess you can use UpdateCameraPro if you need it.

You don't need to call UpdateCamera when using CAMERA_CUSTOM though I guess you can use UpdateCameraPro if you need it.

Hi @justgo97 ! If I am not mistaken, the header file that I pointed to in the PR states that if UpdateCamera() is called with CAMERA_CUSTOM as an argument; the function "Will do nothing"
Wouldn't that mean that calling UpdateCamera with CAMERA_CUSTOM as an argument is an intended feature/something the function should handle?

Best regards

You don't need to call UpdateCamera when using CAMERA_CUSTOM though I guess you can use UpdateCameraPro if you need it.

Hi @justgo97 ! If I am not mistaken, the header file that I pointed to in the PR states that if UpdateCamera() is called with CAMERA_CUSTOM as an argument; the function "Will do nothing"
Wouldn't that mean that calling UpdateCamera with CAMERA_CUSTOM as an argument is an intended feature/something the function should handle?

Best regards

Yes you are correct about the comment in the header not matching how the actual code works, Your PR would fix that.
Till this gets patched users need to do the check manually
    if (mode != CAMERA_CUSTOM) {
        UpdateCamera(&camera, mode);
    }

You don't need to call UpdateCamera when using CAMERA_CUSTOM though I guess you can use UpdateCameraPro if you need it.

Hi @justgo97 ! If I am not mistaken, the header file that I pointed to in the PR states that if UpdateCamera() is called with CAMERA_CUSTOM as an argument; the function "Will do nothing"
Wouldn't that mean that calling UpdateCamera with CAMERA_CUSTOM as an argument is an intended feature/something the function should handle?

Best regards

Yes you are correct about the comment in the header not matching how the actual code works, Your PR would fix that. Till this gets patched users need to do the check manually
    if (mode != CAMERA_CUSTOM) {
        UpdateCamera(&camera, mode);
    }

Oh; okey noted!  I see what you mean!
As an aside; do yo have any comments regarding the patch? I know it isn't much! :sweat_smile:

Oh; okey noted! I see what you mean!
As an aside; do yo have any comments regarding the patch? I know it isn't much! 😅

I don't know much about the coding style conventions in this repo so probably a maintainer can comment on this.
I personally avoid empty braces and would do something like this:
void UpdateCamera(Camera *camera, int mode)
{
    if (mode == CAMERA_CUSTOM) {
        return;
    }

    // The rest of the function code

}

but again this is just a preference, it will still get the job done in it's current format.

@lima-limon-inc Thanks for the patch! Personally I prefer that approach than an early return, I try to minimize/avoid early-returns in raylib as much as possible.

Hello @raysan5 ! Thank you very much!
I decided against using the early return in order to follow the style of the surrounding code.
As I side note, may I ask why you chose against them? Do they complicate compiler optimizations? Is it a style decision?
Side note 2: Raylib is a joy to use! Thank you so much for all of your work!

As I side note, may I ask why you chose against them? Do they complicate compiler optimizations? Is it a style decision?

It's just a style and organization decision, I prefer to know that all function return at the end (despite I use some early returns in some functions, mostly for security checks).

As I side note, may I ask why you chose against them? Do they complicate compiler optimizations? Is it a style decision?

It's just a style and organization decision, I prefer to know that all function return at the end (despite I use some early returns in some functions, mostly for security checks).

Great! Thanks for the insight. I made a follow up PR regarding the "PS2" I made. It only changes the comments in raylib.h so that they match the comments in rcamera.h
Here's the PR: https://github.com/raysan5/raylib/pull/3942
Have a good day!


stuff

Awesome. @viktor76525 Can you add some bits to README.md show-casing how you fixed the perspective issue with tilt options? How many hours do you want to bill?

Update README.md. A day as discussed is fine. Have you tested it? I ran into some issues with CPT files missing from the resources package.

Awesome. @viktor76525 Can you add some bits to README.md show-casing how you fixed the perspective issue with tilt options? How many hours do you want to bill?

Update README.md. A day as discussed is fine. Have you tested it? I ran into some issues with CPT files missing from the resources package.

Gosh, I never received an alert for your reply. Sorry about delayed response. Will test it. Thanks


Better auto complete suggestions and scrollbars on graph pages

I think our auto complete suggestions could be improved. Searching for win.mem should rank ^win.mem higher than *win.mem. RIght now I have to type most of the metric name out before I get an auto complete suggestion that is close to what I want.
Also, the list should support scrolling.

That is missing 4 metrics, which could be displayed with scrollbars or better matching

I would add to this that autocomplete would likely be a lot more pleasant if it worked like code intellisense. We use the dots in metric names to describe a hierarchy, the same way the dot (access operator) is used in code to navigate a hierarchy. If win were an object, and I typed win. into an IDE, it would only show me mem once, without any of its subproperties. This allows you to navigate where you want to without nearly as much noise. It also helps with discovery because, instead of seeing the same thing dozens of time, I see all of the unique items in the next level of the hierarchy, and I can follow the paths which interest me, while easily ignoring the ones which don't.
I realize what I'm suggesting is likely more difficult to implement than whay Greg is suggesting, but I thought I would throw it out as a direction we might want to consider.

Bret, I'm going to close this issue to fix Greg's comment. I've opened another with your suggestion.


ALL THE MODDED MOONS ARE FREE

I have confirmed that this mod is causing it and that it has made all modded moons using this and NOT using this free
this means legit any moon added became free even thes ones from magic wesley who does not use this mod for moons (like infernis, etern, or asteroid 13)

okay im just gonna use 1.12 until it is fixed


!#1 instead of #!1 to remove spaces

Seems like #1 creates a space. Don't get why to be honest but to remove the space the correct syntax seems to be !#1 and not #!1.

the space is necessary when resolving chains of commands and avoiding ambiguities; basically the whitespace is irrelevant in most cases apart when you're using it as a literal string (e.g. as a link or path etc).
And yes !#1 is the right syntax, thanks


Buffer overflow serializing proving key

Description
Aim
Generate a proof
Expected behavior
Proof is generated
Bug
I get the error:
Buffer overflow serializing proving key.
[1]    3369733 abort (core dumped)  cargo run --release prove p

To reproduce
Try to generate a proof for the test: poseidonsponge_x5_254, in the https://github.com/ax0/noir repo.
Environment
Use noir from the provided repository

This error also happens on master with this program:
use dep::std;
fn append_leafs(a: [u8], b: [u8], start_a: comptime Field, start_b: comptime Field) -> [u8;64] {
let mut res = [0 as u8,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0];
for i in 0..32 {
res[i] = a[i + start_a];
}
for i in 0..32 {
res[i + 32] = b[i + start_b];
}
res
}
fn compute_root_from_leaf_sha256(leaf : [u8;32], index : [u8], hash_path: [u8]) -> [u8;32] {
let n = index.len();
let mut current = leaf;
let mut newLeaf = leaf;
for i in 0..n {
if index[i] == 1 {
newLeaf = dep::std::hash::sha256(append_leafs(hash_path, current, i * 32, 0));
} else {
newLeaf = dep::std::hash::sha256(append_leafs(current, hash_path, 0, i * 32));
}
current = newLeaf;
}
current
}
fn main(root: pub [u8;32], leaf : pub [u8;32], index : [u8;20], hash_path: [u8;640]) -> pub bool {
root == compute_root_from_leaf_sha256(leaf, index, hash_path)
}
Prover.toml:
root = [
"0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0"
]
leaf = [
"0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0"
]
index = [
"1", "2", "1", "2", "1", "1", "2", "1", "2", "1", "1", "2", "1", "2", "1", "1", "2", "1", "2", "1"
]
hash_path = [
"0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0",
"0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0",
"0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0",
"0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0",
"0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0",
"0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0",
"0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0",
"0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0",
"0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0",
"0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0",
"0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0",
"0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0",
"0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0",
"0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0",
"0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0",
"0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0",
"0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0",
"0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0",
"0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0",
"0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0","0"
]


envoy: Update image for Envoy CVEs 2019-10-08

[ upstream commit 6f60b4fd8fdb61c29ff1ece6126c0f1cb3eb00f9 ]
signed-off-by: Jarno Rajahalme<EMAIL_ADDRESS>Envoy has been updated to address CVE-2019-15226

This change is

test-me-please


npm link doesn't work between webpack 5 and webpack 4 builds

Bug report

Gitter seems dead, I've placed questions there and nobody answers. It's just a posting questions place with no answers.

What is the current behavior?
When trying to link a library built with webpack 4 in development mode into a project that consumes that library and it's built with webpack 5, also in development mode, I get the following error.

If the current behavior is a bug, please provide the steps to reproduce.
Just link a package built with webpack 4 in development mode into an app that's built with webpack 5 in development mode and that's pretty much it.

The gist with the configs example

What is the expected behavior?
The expected behavior would be to be able to link the library into the app so that I can develop in a more dynamic way without having to deploy the library package.

Other relevant information:
webpack version:  5.6.0 vs 4.43.0
Node.js version: 12 lts
Operating System: OSX Mojave
Additional tools:

If I remove the modules: commonjs from the webpack config I get another error now (more friendly I guess):

Depending on what your linking. Resolutions will not work correctly since the linked package likely has dev dependencies causing code inside that package to resolve to its own modules folder.
This isn’t uncommon. Yarn pack or npm pack the file / just cp it works pretty well

Answer above

Sorry, I must reopen it. I've removed all of the modules resolution and now I get the following issue.
The dependency I need to link has a peer dependency of react. And removed all module resolves from the "shell" app that loads this linked dependency.

@testacode What your expected from webpack here? Answer is right

Finally it was the sourcemaps generations.


Samsung AQV12PWD support

Hi. How can I add support for Samsung AQV12PWD to this repo?
Here is file with commands

I've found out how to do that )))


Add gitignore

This commit introduces a gitignore file into the repo, adding *.log
for files such as npm-debug.log as well as the node_modules/
directory.

any feedback on this?

I generally leave out .gitignore, .npmignore, and other such files from my repos, so I'm +0 on it really...

I generally leave out .gitignore, .npmignore, and other such files from my repos

But: social coding. Isn't it generally a good idea to make it easier for others who also work in [forks of] your repo? They don't want to see node_modules and *.log files in their git diff or git status output. That's why the default node repos (generated by GitHub) include a .gitignore.

This would be a sensible thing to merge. Leaving out .gitignore from the repo is... unusual

This would be a sensible thing to merge. Leaving out .gitignore from the repo is... unusual

Definitely

That's why the default node repos (generated by GitHub) include a .gitignore.

Exactly

You forgot .DS_Store ;-)


fix: remove update-notifier from package

The update-notifier package in its latest version is ESM-only and
is not compatible with the validator in its current state. Additionally,
previous versions of the package contain vulnerabilities.
If we migrate to ESM in the future, we may add the package back in but
for now, we are removing it completely (we had some other trouble with
it as well).

:tada: This PR is included in version 0.81.1 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 0.30.1 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


GraphQL deferred execution failed to complete Error

For instance say you are resolving a field as None and it is defined in schema as Non Null ( ! ). Now because of the below screenshot.
=> GraphQL deferred execution failed to complete Error
Upon investigating the flow of execution of SyncFuture i noticed the below

callback() here throws the error seen below

Now im not sure why SyncFuture below is in Pending State though

Thanks for the bug report @e-lobo . I thought that we might be able to avoid having to capture exceptions in futures (like promises do) but it I don't think it's avoidable. Will update here when it's working.

@jkimbo basically any error getting raised inside our dataloader throws this error instead of the actual error..


java.lang.IllegalArgumentException: x + width must be <= bitmap.width()

I try to test getID at tablet but get exception when try to take a photo. This bug was reproduced at Galaxy Tab A7 and emulator Nexus 10, but at phone - everything OK. Please fix this ASAP.

@vadikk Thanks for the bug report. We'll fix it in the next release.

@vadikk We've fixed this issue in version 2.3.2.


add kwargs to init of CSVData

add kwargs to init() of CSVData, so that this class could use features of it's parent class, DenseDesignMatrix.
For example, the view_converter of  DenseDesignMatrix could not be initialized without this change.

Thanks!


help

my taskbar icon disappeared and I cannot enter keybase, I restarted the computer many times and installed it again but it was useless. there is no Keybase icon in my system tray.HELP ME ... WHAT TO DO?

GpG

what is the GpG?


create workflow to update thin-edge.io version automatically

Add a new workflow/script which will automatically update the checksums of the latest thin-edge.io version in the yocto layer

Resolved by https://github.com/thin-edge/meta-tedge-bin/pull/20


Fixed #945 Selenide automatically takes screenshots on any test failure with junit5 runner

Selenide automatically takes screenshots on any test failure with junit5 runner
refactor for using TestWatcher class
add SelenideLogger for listeners.

Proposed changes
#945
Checklist

[x] Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Add tests to proof your changes working as exptected

Hi, any plans to finish this pull request?
Selenide logger usage in ScreenShooterExtension extension will be a great help to Allure

Yes, I am going to review this PR.
Sorry for the delay.

@Artem034 Your fix is generally ok, but I see one problem: we take 2 screenshots.

This extensions takes a screenshot (and just logs it),
Then extension triggers Allure listener (via SelenideLogger.commitStep) which also takes a screenshot.

It would be nice to avoid taking 2 screenshots.

Closing the issue because the same job was done by commit https://github.com/selenide/selenide/commit/5414bc743469d0624e6f5efc.
But we still have an issue with 2 screenshots. Registered an issue https://github.com/selenide/selenide/issues/1002.


Help please embedding into CSS

I'm trying to make a grammar that embeds XML and XSL into CSS used in a private document editor, but I do not understand why I can not use:
htmlgrammar.generate_symbol('style_value')

I created another section:
<cssurl> = url(<xmlelement_xml>)

Error:
...
...
  File "/Users/agarcia/domato/grammar.py", line 347, in _select_creator
    raise GrammarError('No creators for type ' + symbol)
grammar.GrammarError: No creators for type xmlelement_xml

Result should be:
cssurl = URL(data:mimetype;<xml.....>)

Hey there,
The error you are getting means that the grammar generator doesn't know how to generate the <xmlelement_xml> symbol. Somewhere in the current grammar (or the included grammars) you should have a rule that starts with
<xmlelement_xml> =

I have a xml.txt and xmlattrb.txt included in the bottom of xml.txt. But doesn't work. As example I used  = url(<svgelement_svg>) and I got same error

The error is always in this line
<xml_style_value> = <import from=cssgrammar symbol=declaration5>
Adding css.txt and cssproperties doesn't work, and I think there are some files including others that ends in a loop. Tried to fix it, but still getting this error because the import declaration.

Hey, sorry for not replying sooner (I was away for a couple of days), did you resolve the issue? If not, I can take a look at your grammar files. You can either attach it here or mail it to<EMAIL_ADDRESS>


Added University of the Gambia

@C-Jalloh I am sorry, the domain utg.edu.gm is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).

Thanks @philipto


Provide upgrade guidance

The current release notes are quite overwhelming for users who merely want to upgrade their installation to the latest version of weave and have it Just Work As Before. Such users would benefit from upgrade guidance, which could range from a simple 'No changes in default behaviour from previous version; upgrade via rolling restart' to dealing with protocol version incompatibility and changed defaults.

Such users would benefit from upgrade guidance, which could range from a simple 'No changes in default behaviour from previous version; upgrade via rolling restart' to dealing with protocol version incompatibility and changed defaults.

That's something that would go into the release notes. We don't need an issue for it. Except perhaps to document the requirement in the release process?
The other thing we could do is write generic upgrade documentation, e.g. explain in more detail how to perform a rolling and non-rolling upgrade.

CC @abuehrle


Image Paths

Imgit with Astro fetches the file from the public directory. But there are many instances where I want to fetch images from the /src/assets directory instead (since I use Astro's image optimization tool as well). Is it possible to remove the /public?
Example
// Passed in value
const test = await import('imgit:/asset/image.png')

// Path used now
// /absolute-path-to-project/public/src/asset/image.png

// Preferred path
// /absolute-path-to-project/src/asset/image.png

Sure, you can set the preferred root directory in the options:
https://github.com/elringus/imgit/blob/46f5765eb5fe5dcb4c5ba75322193fb4f7aecbb5/src/server/config/options.ts#L4-L7


🐛 [cloud_firestore_odm] Update method doesn't have enum properties

Bug report
Describe the bug
Defining an enum property on a model works just fine, except it doesn't allow updating the value from the auto-generated .update method.
Steps to reproduce
Create a firestore model with one property that is an enum.
enum BookType {
  thriller
  mystery
}

@immutable
@firestoreSerializable
class Book {
  final String name;
  final BookType type;
}

@Collection<Book >('books')
final bookRef = BookCollectionRegerence();

await godaSensorRef.doc(docId).update(
  type: BookType.thriller, // ERROR Analyzer shows error - The named parameter 'type' isn't defined.
);

If you look at the generated code BookType is correctly added to the JsonSerializableGenerator but is missing from the update method
Expected behavior
I would expect to be able to update enum typed values using the generated update method
Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
[✓] Flutter (Channel stable, 3.3.8, on Microsoft Windows [Version 10.0.22621.819], locale en-US)
[!] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses
[✗] Chrome - develop for the web (Cannot find Chrome executable at .\Google\Chrome\Application\chrome.exe)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.
[✗] Visual Studio - develop for Windows
    ✗ Visual Studio not installed; this is necessary for Windows development.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components
[✓] Android Studio (version 2021.3)
[✓] VS Code (version 1.73.1)
[✓] VS Code (version 1.74.0-insider)
[✓] Connected device (3 available)
[✓] HTTP Host Availability

! Doctor found issues in 3 categories.

/cc @rrousselGit

Closing in favour of https://github.com/firebase/flutterfire/issues/9428 / https://github.com/firebase/flutterfire/issues/8338


For/stable/joshua s brown fix abs

The wrong abs function was being used. Somewhere a c header was being included that was converting a double to int when calling abs. This was mitigated by using fabs.
The bug was discovered as a result in the lammps data reader in csg: https://github.com/votca/csg/issues/537

Heyho I am not convinced. I do not see how that should happen, std::abs is templated.

I think replacing abs() by std::abs() should be enough.

Ok, std::abs then, we should just be careful when using abs though. @JensWehner which part are you not convinced about?

And can we add a test to csg, comparing the output of csg_dump.

works for me

we should try to remove all using namespace std;

And can we add a test to csg, comparing the output of csg_dump.

I don't think this is necessary, this errors is actually caught in the tools unit element test as it is.

I think we should not allows using namspace std;. CLang-tidy flags it as well.

I think we should not allows using namspace std;. CLang-tidy flags it as well.

This is for stable, let's fix it in master.


upgrade(fleet): Report Fleet policies applied

What does this PR do?
Following https://github.com/DataDog/datadog-agent/pull/28234, we now write the layers of policies that have been applied in the configuration. This PR sends them in the inventories so we can access them back in FA.
Motivation
Closing the Fleet Policies loop in the UI
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes

Set the __fleet_layers key manually in your config
Run the agent with log_level: DEBUG
Check that the key fleet_policies_applied exists in the inventory payload

/merge


Clean up of guide-rest-openshift instructions

My bad, it's changes for guide-rest-openshift but it uses code from guide-rest-intro why I got confused.


Fix enablement of backends accidentally

enabled_backends and default_backend use broken logic. These should be
unset by default and we should check for None instead of 'is defined'.

+1
Don't think it is necessary to backport to HAVANA branch.


feat(compose): Support depends_on property

Prerequisite checklist

[x] Read the contribution guidelines regarding submitting new changes to the project;
[x] Tested your changes against relevant architectures and platforms;
[x] Ran make fmt on your commit series before opening this PR;
[x] Updated relevant documentation.

Description of changes
The depends_on property allows specifying dependencies between services. The services will always be started in the order of the dependencies and always be stopped in the opposite order. At the moment we cannot do healthchecks in krafkit, so the condition of the dependency is ignored.
E.g.
services:
  a:
    image: nginx:1.15
    depends_on:
      - b
  b:
    image: nginx:1.15

kraft compose up -d
 i  creating network test_default...
 i  creating service b...
 i  creating service a..

kraft compose down
 i  removing service a...
 i  removing service b...
 i  removing network test_default..

Nice! Can you split this into two commits, one which introduces ServicesOrderedByDependencies and ServicesOrderedByDependencies into the compose package and another which utilizes these new methods across the internal/cli/kraft/compose subcommands? Thanks!


Hangs after clicking "Remove OneDrive folder"

Hello,
I was relieved and excited to find this project.   OneDrive has been making my life hell for so long and the other day I discovered it wasn't done yet.  I've performed the registry edits suggested in other articles, disabled the service and renamed the folder but my system still thinks those files need a cloud provider and the associate exception is thrown when I try to access them.
The {CIS}.DAT file was loaded successfully and whenI realised the utility isn't going to be able to copy the contents of the files, I right-clicked ont he top level of the tree-view and selected "Remove".   The hourglass appeared and it's been like that ever since, the window fading in that familiar way when a program is not responding.
I know that the files do have content - they were never cloud-only files.  It's just 1D doing things without asking that has put that folder structure in an inconsistent state.  Surely this utility doesn't require OneDrive to be running in order to remove the folder?
Either way, if you can offer any help as to how I can bypass this interference so that my C# application attempting to move these files can work, it'd be very much appreciated, even if this issue cannot constructively be addressed.
Cheers,
.pd.

I haven’t been able to reproduce the behavior yet. Couple of questions. What version are you running? Are you using the exe or the python script.
I don’t think this tool is going to do what you want it to. If you are trying to remove OneDrive, this will not work. OneDriveExplorer is a forensics tool to parse OneDrive artifacts from an endpoint and present them in a human readable format.

Thanks for getting back to me.   I ran the python gui script from the latest zip.  I guess I thought "remove from OneDrive" would unlink the folder for me.
Background: OneDrive has made my life a misery.  I tried unlinking the account and following all the recommended procedures but it would hang indefinitely when I tried switching off on-demand, unlinking folders etc.  Up until on-demand, I was quite happy to let 1D make cloud copies of my files.  But, it seems they weren't content with 50% of my trust and just decided to delete my content and devour 100% of my system resouces maintaining connections that shouldn't have existed in the first place.
OneDrive is the most evil combo of Trojan Horse and RansomWare in the history of computing.
So what I was really looking for was either a way to bypass the cloud provision check on the command line, a registry hack or even a bit of code.   Failing that, a low-level sub-file i/o method of bypassing the check for cloud provision as "rd /s" seems to be able to do, but instead of deleting the files, I just wanted grab the fragments via whatever on-disk bitmap exists on NTFS and put the files back together in a safe haven far from the intefering clutches of this sickeningly incompetent and unprofessional algorithmic doggeril.
I've found a C reinvention of rawcopy that I'm investigating, but in the meantime, I've reasoned that since these files in their last accessible state were consistent with the cloud copies, I might as well delete the lot with rd and download anything missing directly from my onedrive account.   That in itself poses a challenge  cuz the download function is cynically unreliable - they don't want you getting hold of your own data and they'll use any dark and sinister means at their disposal to hold your data hostage until you reinstall their amateur excuse for a software product.
So, now I'm trawling thru onedrive projects on here, looking for functions I can shoplift to get my files via whatever direct API exists - tho, I shudder to think how monumentally awful it'll be when I do find it.
Apologies for the rant.  I really am my wits end.  This has cost me so many days of productivity loss..  If I had the money, I'd sue them.


bug: java.util.concurrent.ExecutionException: org.eclipse.lsp4j.jsonrpc.ResponseErrorException: accessing Sourcegraph Grap (...)

Plugin version: 5.3.3914
IDE version: WS-233.13135.92
Stacktrace:
java.util.concurrent.ExecutionException: org.eclipse.lsp4j.jsonrpc.ResponseErrorException: accessing Sourcegraph GraphQL API: FetchError: request to https://sourcegraph.com/.api/graphql?CurrentUserCodyProEnabled failed, reason: getaddrinfo ENOTFOUND sourcegraph.com (https://sourcegraph.com/.api/graphql?CurrentUserCodyProEnabled)

Error: accessing Sourcegraph GraphQL API: FetchError: request to https://sourcegraph.com/.api/graphql?CurrentUserCodyProEnabled failed, reason: getaddrinfo ENOTFOUND sourcegraph.com (https://sourcegraph.com/.api/graphql?CurrentUserCodyProEnabled)
    at C:\snapshot\dist\agent.js
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async C:\snapshot\dist\agent.js
	at java.base/java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:396)
	at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2073)
	at com.sourcegraph.cody.chat.ui.LLMDropdown.fetchAndUpdateModels$lambda$1(LLMDropdown.kt:49)
	at com.sourcegraph.cody.agent.CodyAgentService$Companion.withAgent$lambda$0(CodyAgentService.kt:125)
	at com.intellij.openapi.application.impl.ApplicationImpl$2.run(ApplicationImpl.java:249)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:702)
	at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:699)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
	at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1.run(Executors.java:699)
	at java.base/java.lang.Thread.run(Thread.java:840)
Caused by: org.eclipse.lsp4j.jsonrpc.ResponseErrorException: accessing Sourcegraph GraphQL API: FetchError: request to https://sourcegraph.com/.api/graphql?CurrentUserCodyProEnabled failed, reason: getaddrinfo ENOTFOUND sourcegraph.com (https://sourcegraph.com/.api/graphql?CurrentUserCodyProEnabled)

Error: accessing Sourcegraph GraphQL API: FetchError: request to https://sourcegraph.com/.api/graphql?CurrentUserCodyProEnabled failed, reason: getaddrinfo ENOTFOUND sourcegraph.com (https://sourcegraph.com/.api/graphql?CurrentUserCodyProEnabled)
    at C:\snapshot\dist\agent.js
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async C:\snapshot\dist\agent.js
	at org.eclipse.lsp4j.jsonrpc.RemoteEndpoint.handleResponse(RemoteEndpoint.java:209)
	at org.eclipse.lsp4j.jsonrpc.RemoteEndpoint.consume(RemoteEndpoint.java:193)
	at org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.handleMessage(StreamMessageProducer.java:194)
	at org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.listen(StreamMessageProducer.java:94)
	at org.eclipse.lsp4j.jsonrpc.json.ConcurrentMessageProcessor.run(ConcurrentMessageProcessor.java:113)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	... 1 more

Hello @12haa 👋 we are sorry you see this one 🙇
the first thing I suggest - please try to update the plugin 🙏
let us know if you it fixes the issue for you

This seems to be a duplicate of #1195.


feat: make the ? navigable with tab

As described by @juergrinaldi a user of ZITADEL should be able to navigate the ? help button using the tab key

[X] I can navigate to the "?" button to open the keyboard shortcuts with my keyboard (tab)

This video shows new behavior:
https://user-images.githubusercontent.com/30386061/221948005-17e72dde-6e2f-4c04-8c74-1c5a95103ed6.mp4
Closes #4797
Acceptance Criteria
### Definition of Ready
- [X] I am happy with the code
- [X] Short description of the feature/issue is added in the pr description
- [X] PR is linked to the corresponding user story
- [X] Acceptance criteria are met
- [ ] All open todos and follow ups are defined in a new ticket and justified
- [ ] Deviations from the acceptance criteria and design are agreed with the PO and documented.
- [X] No debug or dead code
- [ ] Critical parts are tested automatically
- [ ] Where possible E2E tests are implemented
- [ ] Documentation/examples are up-to-date
- [ ] All non-functional requirements are met
- [X] Functionality of the acceptance criteria is checked manually on the dev system.

@peintnermax can you have a look at this?


[Bug]: Branding - 503 error is thrown and the app crashes on uploading specific images for logo

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Branding - 503 error is thrown and the app crashes on uploading specific images for logo
Image used:

Previously raised issue: https://github.com/appsmithorg/appsmith/issues/26576
Steps To Reproduce

Go to Admin Settings, and select the Branding section
Here select an image for logo
Click Submit.
Application crashes and 503 error is thrown

Public Sample App
https://ee-2411.dp.appsmith.com/
Environment
Release
Issue video log
https://www.loom.com/share/96a8f39e1bc04ceb8234f429e783180e?sid=1e33c3ca-7134-4683-a0b7-0246780cb8bb
Version
Release


Org members?

Does this limit the "owners" of code to org members? We have a lot of code that was written by people who no longer work here.

It does not. It pings whoever has the blame. I was actually pretty surprised on react-native as it pinged a lot of people not working at Facebook.
Do you have a suggestion on how to fix that?

You could take in an list of "valid organizations" as an environment variable, ping the org api and filter based on that.
Feels like the use cases might be different depending on if the project is private or public - not sure what happens if you mention someone who doesn't have access on a private project. Maybe for private repos, it could hit the org api and filter on members automatically.

It'd also be nice to filter out specific people. For a long time at our company there was just one/two people so they have their names on everything. Now we're at 8 engineers, so it'd be more appropriate to ping the next-best candidate.

Right now the bot doesn't work on private repos because it hits the website and is not authenticated by the way.

How hard would it be to implement a whitelist or blacklist?

Or check the blame, and only tag them if the last "blame commit" was x days/weeks/months ago

Would be pretty easy. Pull requests are welcome :)
Also, one great thing is that you can run it on existing pull requests and just output the list of names. This way you can iterate over the algorithm to get what you are hoping for.

I've started implementing user blacklisting and requiring of organization membership on my fork. I haven't worked with the GitHub API before so any help is appreciated!
I'd be interested to hear from @vjeux if you have any ideas about how to allow repos to have their own configuration settings that the bot can parse? Or if that's even a direction you would want to take this.

We're using a completely different implementation at Facebook so this is pretty much only for the community. If you want to add configurations, I'm all for it :)

How are repo-specific configurations usually done for these bots? A config file in the repo source that the bot parses?

@jgardella That seems like the most straightforward way to me - also similar to how you'd configure Travis, CircleCI, etc.
Add a .mentionbot file in the root (yaml, json, or ini-style?) which the bot could check before running when a PR is created.

So, my PR  that just got merged adds support for a config file .mention-bot, and a config property for blacklisting users, so they never get mentioned.
The other option brought up in this issue, setting required organizations, is a bit more complicated. The wrapper we're using for the GitHub API makes async calls, but the way the bot is currently structured, it does everything synchronously (downloading the blame, downloading the diff, etc). To my mind, we can either rewrite the bot to work entirely async, or write our own sync function that retrieves a user's organizations from the API. Interested to hear others' thoughts.

It seems like a great idea to make it async especially because its an http
server. It also seems like it needs to be all sync or all async. It seems
like a solid chunk of work, but I'd be happy to take a stab over
thanksgiving
On Sun, Nov 22, 2015 at 7:13 PM, Jason Gardella<EMAIL_ADDRESS>wrote:

So, my PR that just got merged adds support for a config file .mention-bot,
and a config property for blacklisting users, so they never get mentioned.
The other option brought up in this issue, setting required organizations,
is a bit more complicated. The wrapper we're using for the GitHub API makes
async calls, but the way the bot is currently structured, it does
everything synchronously (downloading the blame, downloading the diff,
etc). To my mind, we can either rewrite the bot to work entirely async, or
write our own sync function that retrieves a user's organizations from the
API. Interested to hear others' thoughts.
—
Reply to this email directly or view it on GitHub
https://github.com/facebook/mention-bot/issues/5#issuecomment-158824856.

If you are going the async route, please use async/await with babel. This makes the code look like it is synchronous

Never done that before but doesn't that require something like Koa instead of express?
Sent from my iPhone

On Nov 22, 2015, at 10:19 PM, Christopher Chedeau<EMAIL_ADDRESS>wrote:
If you are going the async route, please use async/await with babel. This makes the code look like it is synchronous
—
Reply to this email directly or view it on GitHub.

Express requires you to manually call res.end(); So you can write the code as
async function doWork() {
  var org = await queryOrg();
  // ...
}

req.pipe(bl(function(err, body) {
  doWork().then(function() { res.end(); })
}));

would it be better to just use promises heavily?
On Mon, Nov 23, 2015 at 11:36 AM, Christopher Chedeau <
<EMAIL_ADDRESS>wrote:

Express requires you to manually call res.end(); So you can write the code
as
async function doWork() {
var org = await queryOrg();
// ...
}
req.pipe(bl(function(err, body) {
doWork().then(function() { res.end(); })
}));
—
Reply to this email directly or view it on GitHub
https://github.com/facebook/mention-bot/issues/5#issuecomment-159006099.

Async await is using promises under the hood. It's just a 100x better way to write async code. Just try it and I promise you won't want to go back to raw promises ;)

The express server isn't doing too much... I'm kind of into trying koa... would you be open to that?

Sure, have fun with it.

https://github.com/facebook/mention-bot/commit/3bfcc0a6187e1788d154ce809b20acbf77aa5351 added a blacklist. Closing this issue. If you want more configuration, please open up another issue :)

@zekenie Have you put any work into the async? I'd like to give it a shot if not.


StorageConnectionString doesn't do a UrlDecode

This forbids using paths with ";" or "=" in the name.

are you happy to raise a PR for this?

done, will be released in the next version


release 1.2

I did a lot of fixes and enhancements over the last few weeks. I think we are ready for a release, but I need help with #61, I ignored the test and it keeps failing

When oh when?

#61 is closed

I included 7.5 which fixes most (all?) issues with the webapp except the security issue #88. So I would say: lets go!

👍🏻

Am 09.06.2016 um 00:02 schrieb Jan Galinski<EMAIL_ADDRESS>I included 7.5 which fixes most (all?) issues with the webapp except the security issue #88. So I would say: lets go!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Done.

👍🏻

Am 10.06.2016 um 15:20 schrieb hawky-4s-<EMAIL_ADDRESS>Done.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/camunda/camunda-bpm-spring-boot-starter/issues/85#issuecomment-225180007, or mute the thread https://github.com/notifications/unsubscribe/AMTszds6olF8LiQLsH6NBmwcj94IUOQHks5qKWSygaJpZM4IZumE.

@osteinhauer , @jangalinski : Anyone wants to write a blogpost for camunda.org?
See https://github.com/camunda/blog.camunda.org on how to do it.

I might, but I'm using it in a novel way :).
On Fri, Jun 10, 2016 at 9:54 AM hawky-4s-<EMAIL_ADDRESS>wrote:

@osteinhauer https://github.com/osteinhauer , @jangalinski
https://github.com/jangalinski : Anyone wants to write a blogpost for
camunda.org?
See https://github.com/camunda/blog.camunda.org on how to do it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/camunda/camunda-bpm-spring-boot-starter/issues/85#issuecomment-225187987,
or mute the thread
https://github.com/notifications/unsubscribe/AAiTc63rXuhA0Sf6osMD4CKPAKwcqNMKks5qKWyDgaJpZM4IZumE
.

--

Robert Moskal
Most Media
Brooklyn, USA

Can write blogpost but not til sunday

Its not on central yet ....

issue for blog post: #95

Yeah, sorry. Forgot to publish the staging repository. Done.


[Appbar] display title not updating

Problem description
The appbar's title won't update to the new value when the underlying prop has changed.
Steps to reproduce
These are two different methods that I tried (the numbers are not steps but methods)
1.
const someTitle = 'initial title' //this is declared outside the class
<AppBar title={someTitle}  />

Expected: the value of someTitle is changed and the title which is displayed is updated
Actual: No change in the displayed title

<AppBar ref="AppBar"  />

tried to update it using
this.refs.AppBar.props.title = 'new title'

Expected: the value of someTitle is changed and the title which is displayed is updated
Actual: No change in the displayed title
Versions

Material-UI: 0.15.0
React: 15.0.2
Browser: Chrome Version 50.0.2661.102 m

Fixed as react was not updated


Build failing during linking on "RNS3TransferUtility.h"

While setting up react-native-s3, I followed all the steps under Setup -> iOS. When I went to build, the linker failed on the following line in AppDelegate.m:
#import "RNS3TransferUtility.h"

I added node_modules/react-native-s3/ios/RNS3/RNS3TransferUtility.h to Build Phases -> Compile Sourcesand then my project compiled. However, given all the steps in the setup instructions in the readme, I'm not sure this step is / should be required? Is there something else I missed?

Oh, it's less a step. Add $(SRCROOT)/../node_modules/react-native-s3/ios to Header Search Paths, and mark it as recursive. I'll fix readme. :)

Thanks, seems like that works!


have questions in step:In[1]

This is due to python 2 using a single slash '/' between integers to return an integer where python 3 requires double slashes '//'. So since the code was written in python 2, python 3 is returning a float instead of an integer. There's a few forks of RITSAR that have this fixed to use '//' now.


Adding MAINTAINERS.md

As per our TSC mailing list discussion

What are the roles of maintainers?

@rouming https://wiki.lfedge.org/display/EVE/Community#Committers
@eriknordmark sounds like a good idea -- I'll do PRs for other repos shortly

@eriknordmark can you either approve or merge yourself since there doesn't seem to be much else here (and I need a file in the repo to link to in other PRs)

LGTM


Decrypt using absolute path is not working

Hi!
When I try to encrypt using full absolute path I'm getting following error.
$ stego encrypt --file /home/andrea/Workspace/stegosecrets/mysecret.txt --parts 5 --threshold 3
Encrypting '/home/andrea/Workspace/stegosecrets/mysecret.txt'
Error: open out//home/andrea/Workspace/stegosecrets/mysecret.txt.enc.key: no such file or directory
Usage:
  stego encrypt [flags]

Flags:
  -f, --file string     file
  -h, --help            help for encrypt
  -o, --output string   output dir
  -p, --parts int       parts
  -t, --threshold int   threshold

Global Flags:
  -v, --verbose   verbose output

open out//home/andrea/Workspace/stegosecrets/mysecret.txt.enc.key: no such file or directory

I built (and execute) the code on Arch linux (6.0.2-arch1-1) with go at version go1.19.2

Thanks @andreaSilv, it seems that there is the out dir hardcoded somewhere!


replaced old license header by new one

+1 to merge.

6.4.x: 5c95ecce3504e7a22d0d2fe9f39bc517072576e4


#11207: Make Device type opaque

Ticket
https://github.com/tenstorrent/tt-metal/issues/11207
Problem description
In order to formalize the TT Metal API, Metal API types should be opaque.
What's changed
Add formal API methods for member methods of tt_metal::Device so that it can be an incomplete/opaque type.
Checklist

[ ] Post commit CI passes
[ ] Blackhole Post commit (if applicable)
[ ] Model regression CI testing passes (if applicable)
[ ] Device performance regression CI testing passes (if applicable)
[ ] New/Existing tests provide coverage for changes

This is currently failing because pybind11 can't get the typeid of Device unless it's a complete type... will look into this later.

FYI. @namhyeong-kim

Lots of work! Thank you, Patrick!
The change affects important public facing API. Plans for such changes must be communicated to users/customers via github discussions / discord / private channels ahead of time.
@davorchap , @eyonland is anyone working on the community announcement?

This is a draft PR intended for internal discussions only at this point.  Please allow us time to review this impact and plan our approach.


Rework wire protocol data processing

Sorry github puts the main repo in the list, was meant to be internal for now.

no worries, would be interested to know more about specific issue you are working to address

There are random crashes in drachtio related to the SRF/wire protocol, I have a fix in the C++ that you will see soon, but that isn't enough, so I thought we wanted to create a more concise version of the protocol that will make easier to debug and potentially also fix other issues we have identified.


Finish porting tests to 1.4

While we have ported all server tests (i.e. PFS tests) and integration tests (i.e. PPS tests), there are still some tests from 1.3 that haven't been ported to 1.4.  FUSE tests notably come to mind.

Other suites that we're not running are:

pretest (linter, go vet)
test-client (coverage for users of our API)
test-local (which does a go list under /src/server omitting fuse and vendoring, but getting all other packages) ... so we might be missing some there

Fairly sure linter is getting run.

I believe everything that can be ported has been. Closing.


Error on client connection (GC overhead limit exceeded)

Hi,
Today our OrientDB Server started to get this error:

java.lang.OutOfMemoryError: GC overhead limit exceeded
{db=ilang} Exception during commit of active transaction.
com.orientechnologies.orient.core.exception.ODatabaseException: Database 'plocal:D:/orientdb-community-2.1-SNAPSHOT/databases/ilang' is closed
at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.checkOpeness(ODatabaseDocumentTx.java:2703)
at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.commit(ODatabaseDocumentTx.java:2464)
at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.close(ODatabaseDocumentTx.java:1107)
at com.orientechnologies.orient.server.OClientConnection.close(OClientConnection.java:50)
at com.orientechnologies.orient.server.OClientConnectionManager.cleanExpiredConnections(OClientConnectionManager.java:103)
at com.orientechnologies.orient.server.OClientConnectionManager$1.run(OClientConnectionManager.java:62)
at java.util.TimerThread.mainLoop(Timer.java:555)
at java.util.TimerThread.run(Timer.java:505)

Questions:

Do you know why it happens? Is it a memory leak or Should I increase the max heap size? (today is 512mb)

When it happened, it locked the web server because it is no returning an error, is holding the connection/thread.
There is a timeout for Open connection?

We are using 2.1 SNAPSHOT.
Thank You,

From the traces look like it was going in out of memory while cleaning pending connections, it's really probable that was just a moment of overhead and you need to increase the heap size to handle your load.
What was doing the server while this happened?
the client has a quite long timeout for wait that the all request is complete, and it will receive an answer from the server in any case.

Our UserOnline service was running. On the OrientDB is basically a class where we keep online users with a connection (edge) to the Academic graph.
We insert and delete online Users, Update lastAction and query all user academic conections (friends) are online. This class is our cache of users online, constantly changed.
About heap size, I increased it to 1024 mb. After 6 hour it was totally allocated and average of 700mb used, then maintained well.

Ok, so I'm closing this issue. In case please reopen/comment it.

Luca, I got this error again right now using 1024 mb of max heap size.
I'm sending you some info...

Do you know what's happened on 5:34pm?

Nothing special...
I'm sending the dump in<EMAIL_ADDRESS>ok?

Ok.

Fixed in email.

I have seen similar GC behaviour in my application.
How did you resolve this problem and what was the cause?


Set the python3.7 as default version is necessary on ios?

I wanna to run mediapipe on my iphone though xcode. I have read the document about how to run it on ios platform .
But the Step3 in the document said that "Set Python 3.7 as the default Python version and install the Python "six" library". I have to  change my default python2.7 version and set python3.7  as default on macos. I don't think it is a safe operation because other system tools may need python2.7.
So does it is necessary to use python3.7 to run the demo successfully?

Python is used to configure MediaPipe's TensorFlow dependency during the build process.
Last time when we built MediaPipe with Python 2.7, Bazel reported an error. So, we recommend using Python 3.7 to avoid such Python incompatibility issues.  It's possible that TensorFlow solved this issue recently. Feel free to stay with Python 2.7 and let us know if you face any issue. Thanks.

@jiuqiant
Thanks for your answer. It has no problem to use python2.7.  The mediapipe demos have run successfully on my iphone.
And I have another question. The following function 'ParseFromArray' has been used by several demos, but I can't find its declare and defination.
  // Parse the graph config resource into mediapipe::CalculatorGraphConfig proto object.   mediapipe::CalculatorGraphConfig config;     config.ParseFromArray(data.bytes, data.length);

Thanks for the verification!
Regarding your question:
CalculatorGraphConfig is a Google Protobuf  message. ParseFromArray() is a Google Protobuf Message/MessageLite API: https://developers.google.com/protocol-buffers/docs/reference/cpp/google.protobuf.message_lite. In MediaPipe, you can find the proto and cc proto build rules of CalculatorGraphConfig at https://github.com/google/mediapipe/blob/master/mediapipe/framework/BUILD#L36 and https://github.com/google/mediapipe/blob/master/mediapipe/framework/BUILD#L128.


COCO panoptic version of KITTI

Needed for inst. segm. and panoptic segm. remapping/consolidation

downloading new panoptic version of KITTI GT ;
added remapping parts for KITTI in both tasks


Add staged CABLE driver for advanced configurations

This driver is intended to facilitate spin-up CABLE configurations, which involve usually many stages with differing science configurations. An example experiment exists here, with some documentation: Staged_CABLE

Hello @Whyborn! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file payu/models/cablepop.py:

Line 24:1: E302 expected 2 blank lines, found 1
Line 32:80: E501 line too long (101 > 79 characters)
Line 41:73: E251 unexpected spaces around keyword / parameter equals
Line 41:75: E251 unexpected spaces around keyword / parameter equals
Line 41:80: E501 line too long (80 > 79 characters)
Line 42:76: E251 unexpected spaces around keyword / parameter equals
Line 42:78: E251 unexpected spaces around keyword / parameter equals
Line 42:80: E501 line too long (83 > 79 characters)
Line 43:76: E251 unexpected spaces around keyword / parameter equals
Line 43:78: E251 unexpected spaces around keyword / parameter equals
Line 43:80: E501 line too long (83 > 79 characters)
Line 50:80: E501 line too long (118 > 79 characters)
Line 59:13: E116 unexpected indentation (comment)
Line 62:13: E116 unexpected indentation (comment)
Line 63:13: E116 unexpected indentation (comment)
Line 63:80: E501 line too long (91 > 79 characters)
Line 64:13: E116 unexpected indentation (comment)
Line 64:80: E501 line too long (91 > 79 characters)
Line 65:13: E116 unexpected indentation (comment)
Line 65:80: E501 line too long (140 > 79 characters)
Line 66:1: W293 blank line contains whitespace
Line 68:13: E116 unexpected indentation (comment)
Line 68:80: E501 line too long (84 > 79 characters)
Line 72:1: W293 blank line contains whitespace
Line 79:1: W391 blank line at end of file

I'll add some tests before requesting another review.

Are you ready for another review @Whyborn?

I had requested another one, but I have been doing some thinking since the Payu workshop session to improve the handling of restarts. I'll cancel the current request and add a new one after I make (or not make) some changes.

I've made some adjustments to the way we retrieve the restarts, see the unresolved conversation. I've added tests to capture most of the desired functionality, but I was struggling to build a good test for retrieving restarts.

I think I'm at the end of my utility as a reviewer. I see @ccarouge has a few more suggestions, but after that probably best to merge it and start using it and iterate if there are problems, or improvements required. You're not touching any other drivers, so it's fairly side-effect free and you can test it, as can others.


more clean up, remove unused version properties

ok to test

[merge]

add to whitelist

ok to test

thx @jstrachan


Unable to find constructure w/ JDK11-OpenJ9

Describe the bug
Unable to create NPCs. Reflection is unable to locate the correct constructor.
NPCLib usage option
3
NPCLib JAR name
2.4.1 Plugin shaded into JAR
Server version
PaperSpigot-4c7641d (aka; paper-443 for 1.8.8)
To Reproduce
Create an NPC using any of the create methods.
Expected behavior
n/a
Screenshots
> [06:07:18 ERROR]: [ACF] Caused by: java.lang.IllegalStateException: Unable to find constructor for class net.minecraft.server.v1_8_R3.EntityArmorStand ([class net.minecraft.server.v1_8_R3.WorldServer]).
> [06:07:18 ERROR]: [ACF] at com.comphenix.tinyprotocol.Reflection.getConstructor(Reflection.java:279)
> [06:07:18 ERROR]: [ACF] at net.jitse.npclib.hologram.Hologram.createPackets(Hologram.java:117)
> [06:07:18 ERROR]: [ACF] at net.jitse.npclib.hologram.Hologram.<init>(Hologram.java:92)
> [06:07:18 ERROR]: [ACF] at net.jitse.npclib.nms.v1_8_R3.NPC_v1_8_R3.createPackets(NPC_v1_8_R3.java:39)
> [06:07:18 ERROR]: [ACF] at net.jitse.npclib.internal.NPCBase.create(NPCBase.java:132)
> [06:07:18 ERROR]: [ACF] at net.gravitas.gravitasapi.npcs.CustomNPC.build(CustomNPC.java:201)

Additional context
We're using Java 11-OpenJ9.
The issue also appeared on our 1.14.4 instances, but was fixed as it was a custom Spigot build, simply by adding a new constructure using WorldServer instead of World (see below).
    // custom constructure to allow NPCLib to correctly target a constructor
    public EntityArmorStand(WorldServer world, double d0, double d1, double d2) {
        this(EntityTypes.ARMOR_STAND, world);
        this.setPosition(d0, d1, d2);
    }

    public EntityArmorStand(World world, double d0, double d1, double d2) {
        this(EntityTypes.ARMOR_STAND, world);
        this.setPosition(d0, d1, d2);
    }

I expect this issue is due to Java 11 and the Reflection class not accepting superclasses as a valid option.

Upon further research, the issue seems to be due to SlimeWorldManager as it creates a new World object ( example )
Not sure if this is something that is fixable on your end.

I've forked NPCLib and attempted to fix it.
Reflection.ConstructorInvoker entityArmorStandConstructor = null;
        try{
            System.out.println("Method 1 Attempt " + worldClass.getName());
            entityArmorStandConstructor = (version.isAboveOrEqual(MinecraftVersion.V1_14_R1) ?
                    Reflection.getConstructor(ENTITY_ARMOR_STAND_CLAZZ, worldClass, double.class, double.class, double.class) :
                    Reflection.getConstructor(ENTITY_ARMOR_STAND_CLAZZ, worldClass));
            System.out.println("Method 1");
        }catch (Exception e){
            System.out.println("Method 1 Failed");
            try {
                worldClass = worldClass.getSuperclass();

                System.out.println("Method 2 Attempt " + worldClass.getName());

                entityArmorStandConstructor = (version.isAboveOrEqual(MinecraftVersion.V1_14_R1) ?
                        Reflection.getConstructor(ENTITY_ARMOR_STAND_CLAZZ, worldClass, double.class, double.class, double.class) :
                        Reflection.getConstructor(ENTITY_ARMOR_STAND_CLAZZ, worldClass));

                System.out.println("Method 2");
            }catch (Exception e2){

                System.out.println("Method 2 Failed");
                if (Bukkit.getPluginManager().getPlugin("SlimeWorldManager") != null){

                    try {
                        worldClass = Reflection.getUntypedClass("com.grinderwolf.swm.nms." + NPCLib.getVersionName() + ".CustomWorldServer");

                        worldClass = worldClass.getSuperclass().getSuperclass();

                        System.out.println("Method 3 Attempt " + worldClass.getName());

                        entityArmorStandConstructor = (version.isAboveOrEqual(MinecraftVersion.V1_14_R1) ?
                                Reflection.getConstructor(ENTITY_ARMOR_STAND_CLAZZ, worldClass, double.class, double.class, double.class) :
                                Reflection.getConstructor(ENTITY_ARMOR_STAND_CLAZZ, worldClass));

                        System.out.println("Method 3");
                    }catch (Exception e3){
                        System.out.println("Failing silently... or not");
                    }
                }
            }
        }

Using the following code I was able to get the NPCs' to spawn with SlimeWorldManager. The main portion of the code is getting the SuperClass of the WorldServer object thats retrieved.
        Reflection.ConstructorInvoker entityArmorStandConstructor = null;
        try{
            entityArmorStandConstructor = (version.isAboveOrEqual(MinecraftVersion.V1_14_R1) ?
                    Reflection.getConstructor(ENTITY_ARMOR_STAND_CLAZZ, worldClass, double.class, double.class, double.class) :
                    Reflection.getConstructor(ENTITY_ARMOR_STAND_CLAZZ, worldClass));
        }catch (Exception e){
            try {
                worldClass = worldClass.getSuperclass();

                entityArmorStandConstructor = (version.isAboveOrEqual(MinecraftVersion.V1_14_R1) ?
                        Reflection.getConstructor(ENTITY_ARMOR_STAND_CLAZZ, worldClass, double.class, double.class, double.class) :
                        Reflection.getConstructor(ENTITY_ARMOR_STAND_CLAZZ, worldClass));
}

Should fix the issue.
Now I'm getting a new issue with non 1.8 clients on a 1.8 server; they get kicked with an ArrayIndexOutOfBoundsException: 6 error.
Currently investigating that issue.

I'll see what I can do about this. With your fix it should be the same issue as found in #58.
Are you using any sort of server proxy? E.g. BungeeCord?

We're running Waterfall w/ ViaVersion on the Proxy & locally on the 1.8 servers.
If you go onto the server w/ a 1.8 client it works fine, but on any other version it crashes with that error. I don't know enough about packets to properly diagnose the issue myself

Issue #58 has been solved. I'll add your additions to the library so you can use your JDK of choice.
Hopefully I'll have an update posted by the end of the day.

Solved. Will soon post a release with the fix.

https://github.com/JitseB/NPCLib/releases/tag/2.4.2-SNAPSHOT


Update providers versions in terraform lock files

Why is this needed?
To be able to update providers to the latest version.
What does this do?
Nothing yet. It adds a test that reproduces the desired outcome.
Type of change

[X] New feature (non-breaking change which adds functionality)

@xlgmokha I think we can build off of this PR for our implementation after a rebase? The code and approach overall looks good to me!


jsx strings are garbled（jsx字符串乱码问题）

When writing JSX,
Chinese strings inside double quotes ("") may appear as garbled text, for example, alert("哈哈") displays as alert("鍝堝搱").
However, using template strings with backticks (``) will display correctly, for example, alert(哈哈) remains as alert(哈哈).

Check the file encoding If you are using Windows and ensure it is set to utf-8.

Solved
cep.config.ts
build: {
jsxBin: 'replace',
sourceMap: false,
},


[WIP] Data augmentation search

Hello guys!
I built this little tutorial demonstrating how to look for the search data augmentation given a dataset. Based on this paper: Data augmentation for learning predictive models on EEG: a systematic comparison.

here is a rendered doc https://output.circle-artifacts.com/output/job/e59b998e-6813-4ae2-a340-a558a64ddf63/artifacts/0/dev/auto_examples/plot_data_augmentation_search.html
does it look as expected for you @bruAristimunha ?

Yes!

Hm in general this is quite nice, but this will make our doc building running time go up to almost 100 minutes... Do you think there is some way to make this example much faster, even if it makes it not an example of how you would do it in practice? I think it is already that way with n_epochs=4. So maybe you could also reduce further (range of hyperparams, even simpler model etc.), and also put notes/commented out code how a practical example would look like? @bruAristimunha or what would you suggest @agramfort ?

Hello @robintibor,
I can reduce it without any problems, but I still think it will be a very time consuming example.

I reduced the number of executions from 10 to 3, it took half an hour. However, it is pointing out an error that I don't understand. Locally it works.

I reduced the values and changed some options to work.
However, I'm getting this error from Sphinx-Gallery:
TypeError: unsupported format string passed to Series.format.
I can't find this in the code.  Locally it works perfectly. Has anyone had this error? @agramfort, @cedricrommel or @robintibor?

@agramfort, for me it's fine.
But I think you will need to change the arxiv link in the future.

No problems, @agramfort. It is my great pleasure to contribute to the library!
Meanwhile, I keep thinking a new contributions and learn how to be more efficient in this process. If there are any suggestions, it is welcome.

Okay, this is challenging! I will do something along these lines.

@agramfort and @cedricrommel, many thanks for the reply!
I liked this article and found it an efficient paper with a fundamental question for EEG augmentation.

thx @bruAristimunha and especially for your patience 🙏

No problems at all @agramfort. Btw, I'm still trying to think of something to improve how to optimize and streamline the loading and streaming of minimally processed data.


TabNavigator - Searching a way to pass a callback between tabs

Hi, first of all thank you for your great job!
I'm experiencing a problem: i did a simple app with two tab ('Tab1' and 'Tab2'). When i switch to Tab1 from Tab2 i need to call a function inside Tab1 (in particular to refresh a Flat List inside it), but i don't find any 'onFocus' function or a way to pass callback from Tab1 to Tab2 with my simple code:
const MyTabs = TabNavigator({
    Tab1: {screen: ContactList},
    Tab2: {screen: AddNewContact}
  }
);
export default MyTabs;

Could you help me?
Thank you!
Regards, Luca

@Luca4k4 This is not an issue. I don't even thing it's related to react-navigation. You're better off posting this on stack overflow.
That being said, maybe you're looking for the componentDidMount.

Hi, thank you for the answer.
It's related to the impossibilities to find a way to pass callback between tabs using react-navigation. It isn't a very issue but a lack of documentation and/or code of react-navigation.
Anyway, is not componentDidMount called only at start? When i switch between Tabs, the components isn't re-mounted. I will try to post on StackOverflow too, thanks

passing a callback between tabs is, in my opinion, a weird thing to want. If you navigate from within the screen, you can pass in params. Otherwise, when using redux, you can just dispatch an action. I don't know if componentDidMount is called between navigating, you can try it.
Otherwise, there's also this method: https://reactnavigation.org/docs/navigators/#onNavigationStateChange-prevState-newState-action

I've not a lot of experience of react-native: i want to change a state of Tab1 when i press a button on Tab2 and i don't know what is the best way to do this. I've tryed all componentsomething**something without success :(

Otherwise, there's also this method: https://reactnavigation.org/docs/navigators/#onNavigationStateChange-prevState-newState-action

This could be helpfull, i will try. Thank you so much


make example simplifier to copy and paste

Small changes to example, make it easier to copy and paste it.

Good catch @ehmkah, we should probably enable doctests to make sure those errors don't appear again. Anyways, thanks a lot! Good documentation is crucial.


Integration of 2D Network View

Will separate into separate tasks:

Color Links By Functionality - on change of individual
Color Nodes By Functionality - on change of individual
Add Reveal Functionality
Apply Style
Filtering Panel Testing


Wallets: Catch errors during cleanup

Leads to ugly stack traces when the cleanup routine is called while paid_invoice_stream is still streaming.
Example:

can you actually only catch that specific error, RuntimeError and print its message as a warning? i think its more accurate  and we and we don't swallow any other error that could happen.

Codecov Report

Merging #1829 (c7b6a1d) into main (963fd5d) will decrease coverage by 6.77%.
The diff coverage is 0.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main    #1829      +/-   ##
==========================================
- Coverage   55.48%   48.71%   -6.77%
==========================================
  Files          47       47
  Lines        7271     7292      +21
==========================================
- Hits         4034     3552     -482
- Misses       3237     3740     +503

Impacted Files
Coverage Δ

lnbits/wallets/eclair.py
18.89% <0.00%> (-53.69%)
:arrow_down:

lnbits/wallets/lnbits.py
17.20% <0.00%> (-62.80%)
:arrow_down:

lnbits/wallets/lndrest.py
15.32% <0.00%> (-59.06%)
:arrow_down:

lnbits/wallets/lnpay.py
21.73% <0.00%> (-0.74%)
:arrow_down:

lnbits/wallets/lntips.py
16.98% <0.00%> (-0.50%)
:arrow_down:

lnbits/wallets/opennode.py
22.35% <0.00%> (-0.82%)
:arrow_down:

lnbits/wallets/spark.py
15.86% <0.00%> (-0.34%)
:arrow_down:

... and 14 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

https://github.com/lnbits/lnbits/pull/1793 solves the same problem, but in a more clean manner


[FLINK-14440][tests] Annotate BatchFineGrainedRecoveryITCase to enable scheduler NG testing for it

What is the purpose of the change
This change is based on #10043 which fixes FLINK-14439.
With that fix, BatchFineGrainedRecoveryITCase can pass scheduler NG test.
This PR is to annotate it with AlsoRunWithSchedulerNG to enable scheduler NG testing for it.
Brief change log

Annotate BatchFineGrainedRecoveryITCase with AlsoRunWithSchedulerNG

Verifying this change
This change is already covered by itself*.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Rebased onto master

Merging.