BytesMut should impl IntoBuf

See: https://github.com/tokio-rs/tokio-io/issues/72

It looks like this is already the case in 0.4.x. Should it still return a Cursor<BytesMut>? Or should BytesMut implement Buf directly instead?

BytesMut should impl Buf directly. Maybe it does already? Either way, it has the capability to do so.

I ran into problems with impl Buf for BytesMut. Specifically when removing advance from BytesMut and using the Buf's impl reveals that there are conflicting take methods on Buf and BytesMut.
BytesMut::take takes everything and passes ownership into a new BytesBuf, while Buf::take allows configuring how much is taken, but during the transferring ownership instead portion of its act, it consumes self, basically acting like truncate (without changing the underlying storage).
Can someone here give me more background information about the use case for the two different functions? I do not think the functionality of the two can be merged because they are doing fundamentally different things with ownership.
The simplest solution I can think of is just renaming the functions. I think that BytesMut::take should keep the name, and Buf::take should be renamed to something like Buf::prefix (and Take to Prefix).

I, too, was confused with the disparate take methods. But my solution for this would be to replace BytesMut::take with a trait API that would work on both Bytes and BytesMut (and their UTF-8 counterparts StrChunk/StrChunkMut being incubated in that crate) and allow the user to specify a range to take. So received_bytes.take() would be received_bytes.take_range(..).

So received_bytes.take() would be received_bytes.take_range(..).

I have now distilled that into crate range-split.


[BEAM-4790] Add Prow-style OWNERS files.

Things to do (in another PR):

Add a short doc about these files and reviewer selection in the contribution guide.
Point https://s.apache.org/beam-owners to said doc.

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---
---

CC: @aaltay @akedin @amaliujia @angoenka @apilloud @aromanenko-dev @chamikaramj @charlesccychen @echauchot @herohde @jasonkuster @jbonofre @kennknowles @kkucharc @lgajowy @lukecwik @melap @pabloem @robertwb @swegner @timrobertson100 @udim @XuMingmin @xumingming

Thanks @udim
I can’t add to this branch. Can you please add me on the new io/kudu? Thank you

@timrobertson100 done!

R: @charlesccychen

Thanks! This LGTM.


Improve performance of StreamActiveComputations query.

Reorder index columns to actually be useful for query.
Apply clauses to Measurements table before other joins.

This change is

Sample queries from halo-cmm-dev:

original-query.sql.txt
updated-query.sql.txt

The updated query appears to halve the CPU time.


Updated Sen. Feinstein's issue list

Hi @BananaNeil, we usually don't put things like the Intern option in the yamls, as that's not related to advocacy and often sends folks to another page with a different form when folks select it. Would you remind removing that one, then I can merge?

@j-ro: No problem. I removed it in a separate commit. I hope that's okay. 😅


Update minimum requirements for the Operator

The Operator SDK v0.4 requires Kubernetes 1.11+ (hence OCP 3.11+ as well.)
See: https://github.com/operator-framework/operator-sdk/blob/v0.4.x/doc/user-guide.md#prerequisites

We should provide something like a table, with the supported versions.
There is high chance, that certain breaking changes will be introduced, making it easier for our users to know which Operator version for which Kubernetes / Openshift version.

But why? Works great on OCP 3.9.

On OCP 3.10, if you delete the Operator pod, the leadership lock (a configmap) doesn't get removed automatically. Once the pod is recreated, the Operator will wait until such lock gets deleted to do anything, and the user would need to do it manually to make it work.
On my testing, the automatic deletion worked on Kubernetes 1.11+/OCP 3.11.
Since the Operator SDK 0.4 dependency already requires Kubernetes 1.11+-based environments, it's probably better to just limit ourselves to that.

A build on master currently creates an image with tag snapshot. Suggest to change the image tag to master as  it would streamline terms in documentation and manifests.

A build on master currently creates an image with tag snapshot. Suggest to change the image tag to master as it would streamline terms in documentation and manifests.

Makes sense to me. Will handle it.


exclude fields from admin change page

The base EXCLUDE, which is used in most of our other admin panels, was not included in the source admin. I suspect this happened when source_status was added as an exclude field in #1116. For reference:
EXCLUDE = (
    "created_by",
    "last_updated_by",
    "json_info",
)

This might also be a good time to consider having the created_by and last_updated_by fields as readonly instead of excluded. This information might still be useful to view on the admin change pages. @jacobdgm, let me know if I should make this change as well.
Fixes #1181

Now, created_by and last_updated_by fields are readonly_fields


ValueWarning: A date index has been provided, but it has no associated frequency information and so will be ignored when e.g. forecasting.

When i run the pycryptobot.py in my machine with "granularity" : "60", then it show me value warnings and not predicting values

I understand that we have to install the latest version of python

The PR to fix this has been merged, closing.


Controlled drawer with modal={false} does not work because of bug in useControllableState

This took me a while to trace down, but basically a Drawer that is controlled and has modal false e.g.:
const [open, setOpen] = useState(false);

return (
  <>
    <Drawer open={open} onOpenChange={setOpen} modal={false}>
      {/* ... */}
    </Drawer>
    {/* Button somewhere else outside */}
    <Button onClick={() => setOpen(true)}>Open</Button>
  </>
);

and open is set from somewhere outside, it does not get to this line to hack the pointerEvents:
https://github.com/emilkowalski/vaul/blob/504102918ed53d5037c694b2f3300825b4e2f3fb/src/index.tsx#L187
because if the prop changes it does not get to this line to call the handleChange function here:
https://github.com/emilkowalski/vaul/blob/504102918ed53d5037c694b2f3300825b4e2f3fb/src/use-controllable-state.ts#L50
So to conclude, under these circumstances it will not remove the pointerEvents = "none" :cry:
Also I am curious why these awful hacks with the pointerEvents are necessary instead of just setting modal={false} on the DialogPrimitive.Root? Maybe this would break something else?

Actually, I think the useControllableState works as expected. Its probably not great if the changing of the prop would cause the handleChange to be called (which would probably cause a loop).
So I guess the handleChange function should not contain any code with side effects meaning the current logic would have to be moved to a useEffect :thinking:

Currently I'm doing this:
<Drawer.Root
      open={isOpen}
      onOpenChange={(v) => {
        setIsOpen(v)
        document.body.style.pointerEvents = "auto"
      }}
      modal={false}
    >
</Drawer.Root>

Feels like a hack to undo a hack. 🤷

body {
  pointer-events: all !important;
}

this worked great! thank you!

if a global css override isn't an option, this seems to work pretty well, and is how it's handled in vaul here here
useEffect(() => {
  if (!open) return;

  const originalPointerEvents = document.body.style.pointerEvents;

  const raf = window.requestAnimationFrame(() => {
	  document.body.style.pointerEvents = 'auto';
  });

  return () => {
	  window.cancelAnimationFrame(raf);
	  document.body.style.pointerEvents = originalPointerEvents;
  };
}, [open]);


Paste and Upload Image from clipboard

Somebody already created a working Paste and Upload Image from clipboard for SimpleMDE, which this project forked from.
Required code may be right here:
https://github.com/gautiermichelin/simplemde-markdown-editor
User created this in response to sparksuite#328
PS: Generating and saving a real image file in the background is essential to keep massive amounts of base64 image data out of your database tables.

Stumbled about this issue here after creating my own workaround for this. I'm using EasyMDE in a notes AddOn for Roundcube. I have created a onPaste event for the editor and use my own code for receiving the clipboard and send this to the backend. Maybe this is what you need? Please have a look over here: https://github.com/Offerel/roundcube_primitivenotes/blob/87836391516ac8f6e5d106d2f605247b74233a89/js/notes.js#L199


Capacity Planning ratio is using vCPUs not pCPUs

It's recommended to calculate the vCPU/pCPU ratio using pCPU cores for ratio calculations, not vCPU threads. (https://communities.vmware.com/thread/572025)
Submitted a fix for this: #677

Submitted a fix for this: #677

Just a random passerby but: as #677 was merged, I think is fixed & can be closed.


Wrong Compliance Status provided to Security Hub

Prowler version: 2.3.0RC0
When sending an event to Security Hub, Prowler uses a wrong JSON for failed checks what causes SH to error. The reason for that is that currently, Prowler uses FAIL as Compliance -> Status, but should use FAILED per documentation: https://docs.aws.amazon.com/securityhub/1.0/APIReference/API_Compliance.html#securityhub-Type-Compliance-Status

This has been fixed in #592 but you'll need to use the master branch of prowler until 2.3.0 (or another release candidate) is released

Sorry!


Error logging is synchronous/blocking

We use evented I/O with fibers sharing a single main thread. However currently we just use fprintf for logging. I don't think this is a big deal but we should look into it at some point.
Note that Linux supports fopencookie and BSD supports something similar but different, so we could write a non-blocking wrapper around stderr and keep using the existing fprintfs. Might have portability problems though.
Tagging this security since in theory it could result in a denial of service attack.

Fixed partially, except see #100.


feat: approval

Summary by CodeRabbit

New Features

Automatically adds an "approved" label to pull requests when a review is approved.

@coderrabbitbot review

/approve


Update AcceptConditionFormPlugin

The API has changed in djangocms-text-ckeditor 3.2.1
This should fix #504.

closing, because everything has already been added to version 0.10


mysql creation instruction does not specify resource group which means cleanup instructions won't remove mysql

The instruction az mysql flexible-server create --public-access <YOUR-IP-ADDRESS> does not include the resource group, which means it creates a new resource group for the deployment. In the cleanup section of this tutorial, az group delete --name wordpress-project --yes --no-wait will only delete the AKS resources and not the mysql resources deployed.
I imagine the easy solution is to add the resource-group option to the az mysql flexible-server create instructions?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 70948431-95aa-5d2c-20f9-30796f4687bf
Version Independent ID: 422d5d9a-e2a2-916c-52ba-892793b413a6
Content: Tutorial: Deploy WordPress on AKS cluster with MySQL Flexible Server by using Azure CLI
Content Source: articles/mysql/flexible-server/tutorial-deploy-wordpress-on-aks.md
Service: mysql
GitHub Login: @mksuni
Microsoft Alias: sumuth

@jeanfrancoislarente Thank you for the feedback. We are actively investigating and will get back to you soon.

@jeanfrancoislarente Thanks for your patience. The commands which are mentioned run in local context of resource group that we created in the steps mentioned in the document. In this specific cases, we need not to provide the resource group at the time of creating the server, and then when we delete the resource group the resources including MySQL server will be deleted as well.
Please let us know if this helps.

All other commands specify the resource group in them and I've never seen an az command run in context of a resource group before, so I'm not sure exactly what that means.
After the group creation in the instructions, you need to create a cluster, connect to it and eventually connect your cluster to the ACR, all in which you need to specify the resource group.
It would be easy, prudent and reasonable to add the --resource-group flag to the az mysql flexible-server create to the instructions. When I ran those instructions from my local computer's Windows Terminal, it created a completely new resource group - it did not create it in the same resource group.
It would also be nice to add --name to the the flexible-server mysql example and give it a nice example name, otherwise you're left with an automatically generated name serverxxxxxx. Finally I'd go so far to say it would be nice if you specified a --database-name. It's easy to do and would make it more intuitive to follow. "wordpress" as an example database name for a WordPress tutorial makes sense, as opposed to the default "flexibleserverdb".
Aside from the resource group thing, the other suggestions are far from critical but are feedback based on my experience of having freshly gone through the tutorial.

@jeanfrancoislarente Thanks for responding back and I understand your concern. This is being assigned to the content author to evaluate and update as appropriate.

#re-assign @shreyaaithal

We sincerely apologize for the delayed response to this issue. I collaborate with the owners of the GitHub Issues related to PostgreSQL to help either get them resolved or determine how to update our documentation.
As such, is this GitHub Issue still a concern for you? If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion, and we will reopen the issue.
Due to the age of this issue, we will continue to close this issue.
Please visit https://docs.microsoft.com/en-us/answers/support/ for more information on asking questions about the product or service.
Thank you.
#please-close


Issue 6255 - Add support for different base conversions in std.conv

http://d.puremagic.com/issues/show_bug.cgi?id=6255
Now Phobos has following conversion functions:

to!string(int, radix)
parse!int(string, radix)

but doesn't have

to!int(string, radix)

Updated, and removed some conversions marked as unnecessary by the "removing top const" feature,

Merged.


Commented Application and Test files

I have used  because I started with it. I think it should be right now.


Crash with split layout

When using a split layout (for me 2 columns) and having the cursor in a column without any open file, ST3 crashes once I call TodoReview.

Dupe #76


logmux - smush many log streams to one logstash

In our app.iced docker environment, we're getting logs from
a bunch of different places and want to output them all to a single
logstash service running locally.
The program: (1) opens a TCP connection to such a logstash; and (2)
mux'es multiple incoming log streams into that TCP connection. It
furthermore adds a "tag" to each logline so we know where it's coming
from on the ELK side.

@mmaxim can you take a look?


PLUGIN-514 fix spanner source getSchema and correctly fix PLUGIN-251

We shouldn't enforce the schema in configure time, instead we should get the actual schema at runtime if it is not provided

/gcbrun


Small change to make debugging file parse errors easier

Now when ast.parse() encounters a file that cannot be parsed due to syntax errors it will report that filename in it's traceback.

Codecov Report

Merging #277 (4799ecb) into next (e7571ea) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             next     #277   +/-   ##
=======================================
  Coverage   87.50%   87.50%
=======================================
  Files           2        2
  Lines         256      256
=======================================
  Hits          224      224
  Misses         32       32

Impacted Files
Coverage Δ

pipreqs/pipreqs.py
87.35% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7571ea...4799ecb. Read the comment docs.

hi @abrahamw88, thank you for your contribution and welcome to pipreqs!

Now when ast.parse() encounters a file that cannot be parsed due to syntax errors it will report that filename in it's traceback.

Could you update your commit message with this? update pipreqs.py doesn´t speak much about what the commit does.


Improve rules and borders with slightly more complicated CSS selectors

https://practicaltypography.com/rules-and-borders.html use the solid gold tip to get the right rules

I did this on the bugs table that really wanted it. I decided to leave menus alone as they work fine with first-child and last-child. But I have the trick in my pocket now.


IPSEC: add upsert logs in debug mode

Always log IPsec upserts in debug mode (simplifies debugging a lot to identify the source of an additional route/policy/state).
Example output:
level=debug msg="IPsec enable succeeded" local-ip=<IP_ADDRESS>/0 reason="CNI Out IPv4" remote-ip=<IP_ADDRESS>/18 spi=1 subsys=linux-datapath
level=debug msg="IPsec enable succeeded" local-ip=<IP_ADDRESS>/0 reason="CNI Out IPv4" remote-ip=<IP_ADDRESS>/18 spi=1 subsys=linux-datapath
level=debug msg="IPsec enable succeeded" local-ip=<IP_ADDRESS>/32 reason="EncryptNode IPv4" remote-ip=<IP_ADDRESS>/32 spi=1 subsys=linux-datapath
level=debug msg="IPsec enable succeeded" local-ip=<IP_ADDRESS>/32 reason="EncryptNode IPv4" remote-ip=<IP_ADDRESS>/32 spi=1 subsys=linux-datapath

cc @jrfastab

This change is

Coverage decreased (-0.04%) to 45.591% when pulling 6b10815a1037f2e638763fb244bb796941c73639 on DataDog:lbernail/ipsec-debug into cf342e193cfb191def6bc46a46947251c23d7ccb on cilium:master.

test-me-please

@ianvernon could we get this backported this to 1.6?
Thank you!
(sorry for all the pings, I don't think I can add the label)


Error: Unknown provider: $uploadProvider <- $upload     at Error ()

I'm trying to inject this module into a controller but when the controller is initialised I get the following error:
Error: Unknown provider: $uploadProvider <- $upload at Error (<anonymous>)

I've included the module (after angular.js).
<script src="/app/components/angularjs-file-upload/angular-file-upload.js"></script>

And injected it into my app:
angular.module('App',  ['ngResource', 'ngSanitize', 'ui.state', 'ui.compat', 'ngCookies', 'ui.bootstrap', 'angularFileUpload'])

And then in my controller:
angular.module('App').controller('FeaturedImageCtrl', ['$scope', '$rootScope', '$state', '$stateParams', 'dialog', '$upload', 'img_src', 'entity_id', 'entity', 'media', function ($scope, $rootScope, $state, $stateParams, dialog, $upload, img_src, entity_id, entity, media) {

However it seems to be the controller which throws the error.
Have I forgotten to do something?

I had the same problem after upgrading to version 4.x , caused by the different name of the service 'Upload' (prev. named $upload)
https://github.com/danialfarid/ng-file-upload/releases/tag/4.0.0

I had the same problem. Was calling:
MyCtrl.$inject = ['ngFileUpload'];

Needed to call
MyCtrl.$inject = ['Upload'];

I'm going through the same problem. I'm using Typescript + Angular.
Error: [$injector:unpr] Unknown provider: $uploadProvider <- $upload <- RemessaBancariaCtrl
http://errors.angularjs.org/1.4.7/$injector/unpr?p0=%24uploadProvider <- %24upload <- RemessaBancariaCtrl

<script src="/.build/vendors/angular.js"></script>
<script src="/.build/vendors/angular-route.js"></script>
<script src="/.build/vendors/ng-file-upload-shim.js"></script>
<script src="/.build/vendors/ng-file-upload.js"></script>
<script src="/.build/vendors/bootstrap.js"></script>
<script src="/.build/vendors/angular-animate.js"></script>
<script src="/.build/vendors/loading-bar.js"></script>

app.ts:
var mainApp = angular.module('arrecadacaoWebApp', ['ngFileUpload', 'ngRoute', 'angular-loading-bar', 'ngAnimate'])
My Controller:
    static $inject = ['$http', '$location', '$scope', '$upload', '$timeout'];

    constructor(private $http: ng.IHttpService,
                private $location: ng.ILocationService,
                private $scope: ng.IScope,
                private $upload: ng.angularFileUpload.IUploadService,
                private $timeout: ng.ITimeoutService
    )
    {
        /*.......*/
    }

AngularJS v1.4.7
ng-file-upload @version 9.1.1
Help me please, do two days I'm with this problem without soluçõa. I thank you.

@oliveheide it is `Upload' not '$upload'.

Thanks ... It worked... I'm from Brazil, it is difficult to write post in English... But I think now it will... Thanks @danialfarid

Thanks a lot, this saved my time.


Quick suggestions don't work in comments and strings

Type: Bug
I get the usual quick suggestions in the code, but not in comments or strings. There, I just get "No suggestions" when I trigger suggestions with ctrl+space.
I did the extension bisect process and the pylance extension was left as the culprit.
When I disable the pylance extension and restart vscode, suggestions work also in strings and comments.
(When I re-enable the pylance extension, suggestions no longer work in strings and comments.)
My user settings contain the following:
  "editor.quickSuggestions": {
    "other": true,
    "comments": true,
    "strings": true
  },

Any ideas what could be the problem here and what else I can check or try?
Extension version: 2022.8.30
VS Code version: Code 1.70.1 (6d9b74a70ca9c7733b29f0456fd8195364076dda, 2022-08-10T06:08:33.642Z)
OS version: Windows_NT x64 10.0.19044
Modes:

System Info

Item
Value

CPUs
11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz (8 x 2803)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.73GB (4.33GB free)

Process Argv
. --crash-reporter-id 0d55e927-a53b-41b8-93d2-a1b33aa4e103

Screen Reader
no

VM
0%

Any ideas anybody?

can you provide a simple example?

I don't believe we support suggestions in comments.
but we do support suggestions in f-strings.

If you disable Pylance and enable the comments and strings settings under editor.quickSuggestions, someone (VS Code? Python?) provides suggestions in comments and strings:

But with Pylance enabled, this functionality goes away.
It's not clear to me how useful these suggestions are. They seem to only include words that appear elsewhere in the current document. I guess that could be useful for completing function names, parameter names, and the like in doc strings.

we disable word based suggestion in python code with pylance. if you want that, we need to explicitly turn it on in settings.json
put this in settings.json
"[python]": {
                "editor.wordBasedSuggestions": true
            }

Thanks, @heejaechang !
@debonte Re "It's not clear to me how useful these suggestions are. They seem to only include words that appear elsewhere in the current document. I guess that could be useful for completing function names, parameter names, and the like in doc strings." – Indeed I find this very useful in docstrings and comments when I'd like to mention a function name or other symbol; especially when that symbol is not on the current viewport. It would be even more useful (esp. when writing longer documentation) if symbols in general could be suggested.


Remove "HB" prefix

Also renamed some symbols to avoid clashes

Responder -> HTTPResponder
ResponderBuilder -> HTTPResponderBuilder
ChildChannel -> ServerChildChannel
MiddlewareProtocol -> RouterMiddleware
URL -> URI
Client -> ClientConnection

I'd prefer "HTTPResponder" over "RequestResponder"

I'd prefer "HTTPResponder" over "RequestResponder"

I'm happy to go with that. Was just looking for something a little less generic that Responder

I'd prefer "HTTPResponder" over "RequestResponder"

I'm happy to go with that. Was just looking for something a little less generic that Responder

@Joannis and done!

I agree with @MahdiBM 's remark here. We'd remove that in the next beta or on release, but I think it's a good idea for sure.

Quick question / suggestion: how about renaming application to server?

We are already using Server for the actual server. Application is the server plus glue code that connects it to the router, any additional services attached and the date cache. I'm not enamoured with the name Application either, but can't think of an alternative I'm happy with.

Quick question / suggestion: how about renaming application to server?

We are already using Server for the actual server. Application is the server plus glue code that connects it to the router, any additional services attached and the date cache. I'm not enamoured with the name Application either, but can't think of an alternative I'm happy with.

Is that underlying server the HTTPServer? Maybe we could differentiate that layer by using the HTTP prefix there and simply use Server for HBApp? 🤔

Server is a generic type with a generic parameter ChildChannel that defines the protocol the server supports. It be could HTTP1.1 but doesn't have to be. So calling it HTTPServer doesn't make sense.

I see, how about (Generic)NIOServer or something related to network? 🤔

I see, how about (Generic)NIOServer or something related to network? 🤔

Sorry Tibor we've decided to stick with Application. It reflect prior art and the symbol Server is already used in a more applicable situation


Replace UKTS and synonyms to UKIMS equivalents

Branch name has the wrong jira ticket
Jira link
HOTT-3937
What?
I have added/removed/altered:

[ ] Change wording for the 'UK Trader Scheme' to 'UK Internal Market Scheme'
[ ]  Change links to the new links for the UKIMS application and info pages

Im going to close this branch as a the code will be included in https://github.com/trade-tariff/trade-tariff-duty-calculator/pull/695


CockroachDB: Query Engine panics when attempting to atomically update a BigInt ID value

Bug description
When attempting to atomically increment a BigInt field, the Query Engine will panic.
As far as I can tell I've tracked the cause of the issue down to this line: https://github.com/prisma/prisma-engines/blob/367cade6e458212277bcb5d5579acb639587ded5/libs/prisma-value/src/arithmetic.rs#L26 which is missing handling for the BigInt case.
How to reproduce

Setup database using provided schema
Run the provided script

Expected behavior
The Query Engine should not panic.
Prisma information

generator client {
  provider = "prisma-client-js"
}

datasource client {
  provider = "cockroachdb"
  url      = env("DB_URL")
}

model Types {
  id     BigInt  @id @default(sequence())
}

import { PrismaClient } from "@prisma/client";

const prisma = new PrismaClient({ log: ["query", "info", "error", "warn"] });

async function main() {
  const record = await prisma.types.create({ data: {} });
  const updated = await prisma.types.update({
    where: { id: record.id },
    data: { id: { increment: 500 } },
  });
  console.log(updated);
}

main()
  .catch((e) => {
    throw e;
  })
  .finally(async () => {
    await prisma.$disconnect();
  });

Environment & setup

OS:  MacOS
Database:  CockroachDB
Node.js version:  v16.14.2

Prisma Version
prisma                  : 4.7.1
@prisma/client          : 4.7.1
Current platform        : darwin-arm64
Query Engine (Node-API) : libquery-engine 272861e07ab64f234d3ffc4094e32bd61775599c (at<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli 272861e07ab64f234d3ffc4094e32bd61775599c (at node_modules/@prisma/engines/migration-engine-darwin-arm64)
Introspection Engine    : introspection-core 272861e07ab64f234d3ffc4094e32bd61775599c (at node_modules/@prisma/engines/introspection-engine-darwin-arm64)
Format Binary           : prisma-fmt 272861e07ab64f234d3ffc4094e32bd61775599c (at node_modules/@prisma/engines/prisma-fmt-darwin-arm64)
Format Wasm             : @prisma/prisma-fmt-wasm 4.7.1-1.272861e07ab64f234d3ffc4094e32bd61775599c
Default Engines Hash    : 272861e07ab64f234d3ffc4094e32bd61775599c
Studio                  : 0.477.0

Thank you for reporting the issue, @RobertCraigie! Unfortunately, I was not able to reproduce it on Prisma 5.11.0. Can you please confirm if the issue is still relevant on the latest version?

Hey @RobertCraigie, we are going to close this issue for now, as we are not able to reproduce it. If you continue experiencing the same problem, please feel free to open a new issue.


default is cpu mode?

Hi, it's me again. I realized if using tf serving should be used python27 for tensorflow and tf serving .
In your docker image , I see the tensorflow was installed with pypi and it is cpu mode.  When I run CNN model such as resnet_50 , it is so slow for predicting!.  Then I uninstall tensorflow and install tensorflow-gpu==1.10.1 with pip.  anything is not change !! it is still slow!!.
My question is : Does the default mode is CPU?  how can I run my model with GPU mode in your docker

I'm using your new docker image . I'm very happy to look at the update .
I run the image is tobegit3hub/simple_tensorflow_serving:latest-gpu
When I load my model(resnet_50) like :

I think my model is ok ,and your serving is no error:

Then , using your demo to generate client file:
curl http://localhost:8500/v1/models/ __resnet_50__ /gen/client?language=python > client.py
The __client.py __ was generated!!
But When I run python client.py  it cost a lot of time and nothing output.So I check the my GPU memory usage  it is not increase!!!!
It means  the model  not use GPU, would you please  check it and provide a GPU model for test? Thank you

The answer is No and you can use GPU with tobegit3hub/simple_tensorflow_serving:latest-gpu.
It would be the problem of the docker command if you want to use GPUs in docker container. You can run simple_tensorflow_serving without docker or run with these parameters to mount gpu devices.
export CUDA_SO=$(\ls /usr/lib/x86_64-linux-gnu/libcuda.* | xargs -I{} echo '-v {}:{}')
export DEVICES=$(\ls /dev/nvidia* | xargs -I{} echo '--device {}:{}')
docker run -it -p 8500:8500 $CUDA_SO $DEVICES tobegit3hub/simple_tensorflow_serving:latest-gpu

@tobegit3hub  Maybe I forget mount gpu device , I will try this . Thank you

I have updated the README and test successfully in our environment.
You can put all CUDA files in /usr/cuda_files/ and test with these commands. Otherwise, you can put your environments variables and make sure the docker image can access GPU and CUDA.
export CUDA_SO="-v /usr/cuda_files/:/usr/cuda_files/"
export DEVICES=$(\ls /dev/nvidia* | xargs -I{} echo '--device {}:{}')
export LIBRARY_ENV="-e LD_LIBRARY_PATH=/usr/local/cuda/extras/CUPTI/lib64:/usr/local/nvidia/lib:/usr/local/nvidia/lib64:/usr/cuda_files"

docker run -it -p 8500:8500 $CUDA_SO $DEVICES $LIBRARY_ENV tobegit3hub/simple_tensorflow_serving:latest-gpu

@tobegit3hub I update your docker image : tobegit3hub/simple_tensorflow_serving:latest-gpu.  It work but there are some bugs :

tf-serving -gpu  default is allocation ALL GPU Memory it was so terrible!!! look here  , and luckly some have fixed it fixed code, Can you add  these config and re-compile the TF-Serving. By the way , the method is per_process_gpu_memory_fraction but I think  allow_growth=True  but I do not know how to do it.

I test the half_plus_one model it is demo in tf-serving docker, it is work fine in tf-serving:latest-gpu docker image but, it is not working in your docker image(latest-gpu),  My way is :

copy saved_model_half_plus_two_gpu into /simple_tensorflow_serving/models/
/simple_tensorflow_serving/models/
|  00000123
|   -----        |  saved_model.pb
|   -------      |  variables
|  -----------| variables.data-00000-of-00001
|  -----------| variables.index
I run simple_tensorflow_serving --model_base_path="./models/saved_model_half_plus_two_gpu/"
ERROR : IOError: SavedModel file does not exist at: ./models/saved_model_half_plus_two_gpu/123/{saved_model.pbtxt|saved_model.pb}
why???

Do you limited model format??


Integrate GitHub Actions

Changes made:

Removed husky pre-commit hooks and commit convention linting due to compatibility issues.
Added 2 GitHub Actions workflows

Workflows:

For api/:

Run cargo build & cargo test (feel free to suggest additional workflows)

For client/:

Refactoring client/app/ and client/components/ (linting/formatting)
Exporting Rust types to TypeScript via rust-types-to-json project

These workflows activate on every PR. If additional commits are made to an existing PR, a new job will begin on the branches' latest commit.
Note: The two TypeScript workflows have the ability to push new commits to the PR.

@QUT-IT-Chads/admin
Please squash and merge this PR. The intermediate commits are not important.


RazorEngine fails to remove temp files when site is stopped

Engine fails to remove temp files.
Start site, use and dispose razor service, then modify i.e. web.config - site stops and you will see the following message:
Could not delete C:\Users\xxxx\AppData\Local\Temp\RazorEngine_uz5e0cpn.xq2: System.UnauthorizedAccessException: Access to the path 'CompiledRazorTemplates.Dynamic.RazorEngine_ef82206d6bce4850a84d4690f2120
7e6.dll' is denied.
   at System.IO.Directory.DeleteHelper(String fullPath, String userPath, Boolean recursive, Boolean throwOnTopLevelDirectoryNotFound, WIN32_FIND_DATA& data)
   at System.IO.Directory.Delete(String fullPath, String userPath, Boolean recursive, Boolean checkHost)
   at System.IO.Directory.Delete(String path, Boolean recursive)
   at RazorEngine.Compilation.CrossAppDomainCleanUp.CleanupHelper.DoCleanUp()

It looks like they are eventually removed, my fault.


Update Failure not recognized by updater

Type: Feature Request
Today I can't start working as normal, found out the VScode wasn't on default directory and couldn't find how to fix it.
I don't have any events at that time on Event Viwer > System (event log at the end of report). When I tried to shutdown Windows at 07/05/2024 23:54:50 it notified me VScode was trying to update, I cancelled the shutdown, waited and then turned off my pc. Today I opened _/Code.exe, tried to update it through "... > Help > Check for Updates ..."  and it says it's up to date.
Is this expected behavior? I will copy the whole thing back to expected directory.
My current Vs Code instalation is in:
C:\Users\zike_\AppData\Local\Programs\Microsoft VS Code_
"C:\Users\zike_\AppData\Local\Programs\Microsoft VS Code_\Code.exe"
Witch broke my cmd and shortcuts to VSCode.
My update log in:
"C:\Users\zike_\AppData\Local\Temp\vscode-inno-updater-1715110292.log"
$ head "C:\Users\zike_\AppData\Local\Temp\vscode-inno-updater-1715110292.log"
May 07 19:31:32.710 INFO Starting: C:\Users\zike_\AppData\Local\Programs\Microsoft VS Code\Code.exe, false, Updating Visual Studio Code... May 07 19:31:32.711 INFO Checking for running Code.exe processes... (attempt 1) May 07 19:31:32.736 INFO Code.exe is running, wait a bit May 07 19:31:33.237 INFO Checking for running Code.exe processes... (attempt 2) May 07 19:31:33.257 INFO Code.exe is running, wait a bit May 07 19:31:33.758 INFO Checking for running Code.exe processes... (attempt 3) May 07 19:31:33.775 INFO Code.exe is running, wait a bit May 07 19:31:34.276 INFO Checking for running Code.exe processes... (attempt 4) May 07 19:31:34.297 INFO Code.exe is running, wait a bit May 07 19:31:34.797 INFO Checking for running Code.exe processes... (attempt 5)
$ Tail "C:\Users\zike_\AppData\Local\Temp\vscode-inno-updater-1715110292.log"
May 07 19:31:37.079 INFO Reading directory: "C:\\Users\\zike_\\AppData\\Local\\Programs\\Microsoft VS Code\\resources\\app\\out\\vs\\workbench\\contrib\\terminal\\browser\\media\\fish_xdg_data\\fish" May 07 19:31:37.079 INFO Reading directory: "C:\\Users\\zike_\\AppData\\Local\\Programs\\Microsoft VS Code\\resources\\app\\out\\vs\\workbench\\contrib\\terminal\\browser\\media\\fish_xdg_data\\fish\\vendor_conf.d" May 07 19:31:37.080 INFO Get file handle: "C:\\Users\\zike_\\AppData\\Local\\Programs\\Microsoft VS Code\\resources\\app\\out\\vs\\workbench\\contrib\\terminal\\browser\\media\\fish_xdg_data\\fish\\vendor_conf.d\\shellIntegration.fish" (attempt 1) May 07 19:31:37.080 INFO Collected all directories and file handles May 07 19:31:37.302 INFO All file handles marked for deletion May 07 19:31:37.555 INFO All files deleted May 07 19:31:37.555 INFO Delete directory recursively: "C:\\Users\\zike_\\AppData\\Local\\Programs\\Microsoft VS Code\\bin" (attempt 1) May 07 19:31:37.556 INFO Delete directory recursively: "C:\\Users\\zike_\\AppData\\Local\\Programs\\Microsoft VS Code\\locales" (attempt 1) May 07 19:31:37.557 INFO Delete directory recursively: "C:\\Users\\zike_\\AppData\\Local\\Programs\\Microsoft VS Code\\policies" (attempt 1) May 07 19:31:37.565 INFO Delete directory recursively: "C:\\Users\\zike_\\AppData\\Local\\Programs\\Microsoft VS Code\\resources" (attempt 1)
Event Log Windows
``
Level	Date and Time	Source	Event ID	Task Category
Information	07/05/2024 23:55:54	Microsoft-Windows-Kernel-Power	107	(102)	The system has resumed from sleep.
Information	07/05/2024 23:55:53	VfpExt	7036	None	The  service entered the Filter detach complete state.
Information	07/05/2024 23:55:53	VfpExt	7036	None	The  service entered the Filter detach start state.
Information	07/05/2024 23:55:53	VfpExt	7036	None	The  service entered the Filter pause complete state.
Information	07/05/2024 23:55:53	VfpExt	7036	None	The  service entered the Filter pause start state.
Information	07/05/2024 23:55:51	Microsoft-Windows-Kernel-Power	42	(64)	"The system is entering sleep.
Sleep Reason: Application API"
Information	07/05/2024 23:55:51	Microsoft-Windows-Kernel-Power	566	(268)	"The system session has transitioned from 172 to 173.
Reason InputPoUserPresent
BootId: 35"
Information	07/05/2024 23:55:51	Microsoft-Windows-Kernel-Power	187	(243)	User-mode process attempted to change the system state by calling SetSuspendState or SetSystemPowerState APIs.
Information	07/05/2024 23:55:50	Win32k	267	None	Touch/Touchpad Hardware Quality Assurance verification succeeded.
Information	07/05/2024 23:55:50	Microsoft-Windows-Winlogon	7002	(1102)	User Logoff Notification for Customer Experience Improvement Program
Warning	07/05/2024 23:55:33	User32	1073	None	The attempt by user LAPTOP-1LO1NTMO\zike_ to restart/shutdown computer LAPTOP-1LO1NTMO failed
Error	07/05/2024 23:55:29	Microsoft-Windows-DistributedCOM	10010	None	The server MicrosoftWindows.Client.CBS_1000.22688.1000.0_x64__cw5n1h2txyewy!Global.DesktopSpotlight.AppXmakp9w4re9tj70pp8mcdrt273xajen0x.mca did not register with DCOM within the required timeout.
Error	07/05/2024 23:54:59	Microsoft-Windows-DistributedCOM	10010	None	The server {8CFC164F-4BE5-4FDD-94E9-E2AF73ED4A19} did not register with DCOM within the required timeout.
Error	07/05/2024 23:54:51	Microsoft-Windows-DistributedCOM	10010	None	The server {08728914-3F57-4D52-9E31-49DAECA5A80A} did not register with DCOM within the required timeout.
Error	07/05/2024 23:54:51	Microsoft-Windows-DistributedCOM	10010	None	The server {08728914-3F57-4D52-9E31-49DAECA5A80A} did not register with DCOM within the required timeout.
Information	07/05/2024 23:54:50	User32	1074	None	"The process Explorer.EXE has initiated the power off of computer LAPTOP-1LO1NTMO on behalf of user LAPTOP-1LO1NTMO\zike_ for the following reason: Other (Unplanned)
Reason Code: 0x0
Shutdown Type: power off
Comment: "
Information	07/05/2024 23:54:25	Microsoft-Windows-Kernel-Power	566	(268)	"The system session has transitioned from 170 to 172.
Reason InputPoUserPresent
BootId: 35"
``
VS Code version: Code 1.89.0 (b58957e67ee1e712cebf466b995adf4c5307b2bd, 2024-05-01T02:09:22.859Z)
OS version: Windows_NT x64 10.0.22631
Modes:

Update:
Cut and paste of all files from "AppData\Local\Programs\Microsoft VS Code_" to "AppData\Local\Programs\Microsoft VS Code"
Seems to have solved my issue.


Allow expanding environment variables in image name

Add a new configuration option, expand-image-vars, that, when set to true, evals the image name to expand environment variables.
In particular, my main use case is that we have agents running in multiple AWS regions, and we configure ECR replication such that all our images should always be available on the same region that the agents are running. In this setup, it is desired to specify an image URI from the same region as the agent is running at. However, this is currently not possible to achieve without knowing, beforehand, the region where the agent that will pick up the job is running, as the region needs to be explicitly encoded in the image URI.
This PR makes it possible to do that by allowing the image name to contain environment variables, and hence allows it to reference AWS_DEFAULT_REGION.

while I am not against the spirit of the PR (specially because the code looks quite good and complete). I believe that its current form can be too complicated and narrow-minded as the same logic could be applied to a plethora of other registries and would overcomplicate the code of the plugin.
An alternative solution would be to add a single (unsafe) boolean option that would have the image string as specified via de existing plugin configuration go through eval 'echo $image' or something like that allowing for arbitrary variable interpolation at runtime. Such a feature should not only resolve your particular scenario but also any other provider current and future with minimal intervention on the plugin code.
What do you think?

Just to be sure, is the suggestion here that I should be able to specify something like:
  image:<PHONE_NUMBER>12.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com/image:tag

And the plugin should eval the env var?
If it is, I have actually tried that before, and the main problem is that buildkite-agent pipeline upload also evals env vars. So the result is that you end up with the region of the agent that uploaded the steps rather than the region that is running the step, which is quite confusing...
It can be worked around by either using more escaping ($$) or disabling variable interpolation (buildkite-agent pipeline upload --no-interpolation). I think both solutions would be pretty confusing for users, though I am willing to implement it if you believe this would make sense.

Just to be sure, is the suggestion here that I should be able to specify something like:
  image:<PHONE_NUMBER>12.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com/image:tag

And the plugin should eval the env var?

Yup, taking into account that the variable reference needs to be escaped to prevent interpolation when the pipeline is uploaded.

If it is, I have actually tried that before, and the main problem is that buildkite-agent pipeline upload also evals env vars. So the result is that you end up with the region of the agent that uploaded the steps rather than the region that is running the step, which is quite confusing...

I agree it is kind of cumbersome, but it is already being done for volumes and appropriate clarifications are added in the documentation.

It can be worked around by either using more escaping ($$) or disabling variable interpolation (buildkite-agent pipeline upload --no-interpolation). I think both solutions would be pretty confusing for users, though I am willing to implement it if you believe this would make sense.

I believe that it is both a solution to the issue you are presenting as well as something that is not only simpler to implement but also future-proof. The plugin will not need changing every time someones needs a similar support for a new provider or different data that needs changing in the URL itself.

I agree it is kind of cumbersome, but it is already being done for volumes and appropriate clarifications are added in the documentation.

Sounds good! Since this is an established pattern, it makes sense to follow.
PTAL: Re-implemented the PR via a new expand-image-vars config. I copied most of the wording from expand-volume-vars for this; let me know if you want me to format in some different way.

Sorry for the delay; I was traveling.
Re-ordered the added entries; note that neither lists are currently fully in alphabetical ordering, but I moved the new entries to where roughly they would be.


Rename package

pint-pandas recently renamed its main package from pintpandas to pint_pandas. I think we should also rename since this is easier to read.

you're right, PEP-8 does say that this is discouraged. However, there is already a significant amount of widely-used packages that simply ignore this rule, e.g. setuptools_scm, prompt_toolkit or more_itertools. I guess that guideline / convention changed a bit since the time the PEP was written (initial post was 2001, last update seems to have been 2013)?


[MAINT] Upate links to starter kit website

This updates links but doesn't address wording/formatting issues that make it harder to find.
cc @arokem

Yes. Thanks for doing this!

Probably for a separate PR (and with high potential for bike-shedding, I guess) is whether the language on this page could be amended a bit. In particular, whether the first sentence could be made less formal and a bit more explanatory. Would a PR on that be welcome or of low priority at this time?

Suggestions for improved text are always welcome, AFAIC.


Sonar reports 6 bugs (2 rated blocker, 4 rated critical)

Is it worth doing anything about this? https://sonarcloud.io/project/issues?id=dropwizard_dropwizard&resolved=false&types=BUG
I've raised a few MRs to address sonar issues in the past where there were clear ways to both improve the code and also quieten the Sonar report, but the remaining group of 6 issues I'm either not sure about or seem like false positives.
I don't think having sonar grumbling is necessarily a bad thing, but if it's configured it would be nice if it had a clean report.
The issues:

dropwizard-auth ChainedAuthFilter can potentially throw an exception which can potentially be null. I'm not sure what the correct thing to do here is.
dropwizard-db TimeBoundHealthCheck could potentially swallow an InterruptedException. This is possibly bad - should an extra catch clause be added? I'm not sure and threads scare me.
dropwizard-lifecycle ExecutorServiceBuilder ignores the result of String.format, but intentionally so as it's using the call to check that the format string is valid. Sonar will stop complaining if it's wrapped in an explicit try-catch, but adding unnecessary code just to please Sonar isn't great. @SuppressWarnings("ResultOfMethodCallIgnored") doesn't seem to appease Sonar - is there anything else which will?
dropwizard-logging LoggingUtil - another potential swallowing of an InterruptedException. I have no idea what the right thing to do is here and messing with threads and logging frameworks doubly scares me.
dropwizard-logging ResilientSocketOutputStream creates a Socket but doesn't close it. This is entirely intentional as the method returns an active connection.
dropwizard-logging DropwizardUdpSocketAppender creates a DatagramSocket but doesn't close it. This is entirely intentional as the method returns an active connection.

I'm not convinced any of these are real issues, although I admit to not being very confident about the thread-related ones.
What to do? Close this issue and let Sonar carry on grumbling to nobody in particular, add some suppression magic somewhere or make some code changes?
Mostly I'm raising this to say "I've looked at all the issues Sonar reported as major and I'm left with these. Is there anything I can do to clean stuff up further?"

An established pattern to handle a caught InterruptedException is this:
try {
   ...
} catch (InterruptedException e) { // implicitly clears interrupted state
   // do something
   ...
   Thread.currentThread().interrupt(); // restore interrupted state
}

Here is a brief explanation: https://stackoverflow.com/a/4906814

An established pattern to not swallow a caught InterruptedException is this:

Yes, that is one of the things sonar suggests doing, but I don't know enough about the context in which the exception is swallowed to know whether it is intentional or not.

Since the interrupt flag was swallowed for the last 6 years (if sonar is right) the suggested solution should be fine. It will achieve the same thing as before but more safely. I assume the only time it is called is upon shutdown of the application or the JVM.

Also does calling interrupt() on the current thread cause another InterruptedException to be thrown?

No. Restoring the interrupt state on the current thread won't (at least not directly) cause another InterruptException. There are two ways to deal with an InterruptException:

Abort your work and rethrow it (if you can)
Abort your work and restore interrupt state (without throwing it) - which seems to be your case

More thorough answers than mine seem to distinguish 3 cases (https://github.com/code-review-checklists/java-concurrency#thread-interruption-and-future-cancellation, https://stackoverflow.com/a/3976527), but so far I have only encountered the first two.

2. Abort your work and restore interrupt state (without throwing it) - which seems to be your case

Alright, I've raised this for consideration:
https://github.com/dropwizard/dropwizard/pull/4239

dropwizard-lifecycle ExecutorServiceBuilder

The JavaDoc of String.format references java.util.Formatter. Maybe one could refactor the code to something like
new Formatter().format(...).close(), as this would be a void call then.

dropwizard-logging ResilientSocketOutputStream

Since the Socket is a local variable, it cannot be closed. Maybe it would be a good idea, to assign the Socket to a class field and close it in a call to an overridden close method. I don't know, it this makes Sonar happy, but the Socket handling would get improved anyway.

dropwizard-auth ChainedAuthFilter

The predefined AuthFilter implementations either set a new SeciurityContext through the authenticate method or throw a WebApplicationException. Therefore such a case cannot happen there.
Since calling the authenticate method to override the current SecurityContext of the ContainerRequestContext is not forced, one could provide a valid implementation, in which a user is authenticated as long as no exception is thrown.
Then the firstException should only be thrown, if it is not null.

dropwizard-lifecycle ExecutorServiceBuilder

The JavaDoc of String.format references java.util.Formatter. Maybe one could refactor the code to something like
new Formatter().format(...).close(), as this would be a void call then.

This looks viable. PR here: https://github.com/dropwizard/dropwizard/pull/4277

dropwizard-logging ResilientSocketOutputStream creates a Socket but doesn't close it. This is entirely intentional as the method returns an active connection.
dropwizard-logging DropwizardUdpSocketAppender creates a DatagramSocket but doesn't close it. This is entirely intentional as the method returns an active connection.

@rhowe I've raised a PR for these: #4278

dropwizard-auth ChainedAuthFilter

The predefined AuthFilter implementations either set a new SeciurityContext through the authenticate method or throw a WebApplicationException. Therefore such a case cannot happen there.
Since calling the authenticate method to override the current SecurityContext of the ContainerRequestContext is not forced, one could provide a valid implementation, in which a user is authenticated as long as no exception is thrown.
Then the firstException should only be thrown, if it is not null.

@joschi what do you think about this? Should a null check happen here or should a new WebApplicationException with status 401 be thrown?


Test Redis cluster resource

We need to test all Redis spec fields, and settings, check their workability, create/update/delete operations, add/remove data centers, etc.
Create separate issues for all bugs found during the test process. If not, add your comment on what was tested and the results in this issue.

I've found the following issues:

operator allows changing the name of the DC (!). This is very important to fix because if we change the name of the DC the operator allows changing the value of any field of the DC
if we change the value of masterNodes to not allowed value (e.a. from 3 to 4) the operator allows it, but the Instaclustr API returns an error about the unsupported masterNodes count. However, if we want to change the value back the validating webhook doesn't allow us to decrease the amount of master nodes.
when updating nodesNumber the API returns the following error: status code: 500, message: {"errors":[{"message":"Null or invalid data encountered","name":"Unknown error"}]}
when updating replicationFactor it doesn't send API call
when adding additional DC to the cluster with the private link enabled the operator allows changing the resource spec, but the API returns an error multi datacentre is unsupported. However, if we try to change it back the validating webhook denies an updating request
the operator allows creating cluster with the privateLink enabled for the clusters with AZURE_AZ and GC cloud providers.

tested. all is working


Update MessageQueueConsumer gem

Adds test case for message queue consumer rake task

Part of: https://trello.com/c/eP2CdnrC/590-fix-rabbitmq-queue-binding

Can we add Statsd support as well here?

I believe I've addressed your concerns @tijmenb
Will add a card for Statsd to be added in Panopticon.


WIP: Add tvOS support

Adding tvOS support with Xcode 8.3

Not sure what goes wrong, but it says that
Tests/Support/objc-build-scripts/cibuild: line 110:  1360 Abort trap: 6           xctool -project "$XCODEPROJ" $XCTOOL_OPTIONS "$@" 2>&1
ERROR: Unexpected action: test

I'm also not sure why to use Rakefile while we can go with .travis.yml similar to what Alamofire has.

Last time this was attempted it got stopped at some weird code signing issues - https://github.com/specta/expecta/pull/175
I think switching to a similar .travis.yml as Alamofire may be simpler than the Rakefile approach WRT testing too.

@orta Sorry, it took me longer than I would expect :)
So far I've added tvOS framework as well as setup unit tests execution for all of the supported targets in Debug + Release.
The only thing I'm not quite sure about is whether I need to add libExpecta-tvOS and do we need to run tests for iOS 8 and 9? I've skipped tests for iOS 8 / 9 due to the Travis CI issue https://github.com/travis-ci/travis-ci/issues/7638.

Never worry about your time WRT shipping OSS.
I think as long as there is the ability to generate a library that can be consumed by others (@tonyarnold has been shipping those with releases) then I think that's really the only responsibility left in the Rakefile or the build scripts.

I ran
carthage build --no-current-skip
carthage archive

and got the following output (similar to what Tony Arnold did)
Expecta.framework.zip


Expandable Service Info

When a service has a long blurb of text associated, hide the end, but allow the user to expand it.

I'm mapping these to the functionality in the MSD word doc. I can't work out which this one is. Can you give a bit more info?

text label "show more"


Fix cleanup of stale conntrack entires to make UDP NodePort services work properly

This should fix the e2e test [It] should be able to preserve UDP traffic when server pod cycles for a NodePort service for nft backend and help close #174

/lgtm

/retest

@gauravkghildiyal /restest does not work here, so I need a rebase please :) Thanks!

/lgtm
/approve

Thanks for the reviews @mcluseau :)

you're welcome @gauravkghildiyal, thanks for taking the time to check this fix :)


[Bug] Build fails on the Homebrew formulae

Describe the bug
While trying to update the Homebrew formulae (which allows Linux/macOS users to install your software easily), the tests ran into a couple of issues. I got the error message java.lang.NullPointerException: Cannot read the array length because "$this" is null (a link to the full log with context is at the bottom of this issue). Here is a link to the pull request for context: Homebrew/homebrew-core#195610.
To Reproduce
Steps to reproduce the behavior:

Try to compile the project on macOS/Linux with the specifications noted in https://github.com/eleanordoesntcode/homebrew-core/blob/bump-joern-4.0.120/Formula/j/joern.rb
Notice that the build doesn't complete

Expected behavior
I expected the project to build correctly.
Desktop (please complete the following information):

Linux (seems to be Ubuntu 22.04)/macOS 13
Joern 4.0.120
OpenJDK 23 or 21 (both tried)

Additional context
Here is a direct link to the error, with the full log: https://github.com/Homebrew/homebrew-core/actions/runs/11524054403/job/32083491897#step:4:622

I have seen this in the past already. It might be due to a broken download of the astgen binary (joern/astgen). Try rerunning it.

It already ran twice with the same errors, but I can try locally.

I can confirm I'm getting the same error locally after running sbt stage. I ran the command 3 times to check if it wasn't some bad download.

Well, Joern PR, master, and release builds do the same (sbt stage) and they are fine.
Maybe @mpollmeier can help.
Did you run sbt clean in between your local stage runs to delete anything that might be broken?

I did

You may want to test the following branch: https://github.com/joernio/joern/pull/5033

(which is now on master)
Another thing to try is delete the local cache in the joern repo root .local.

I'll try rerunning the tests with the next tag. Thanks for the help!

I can confirm the bug has been fixed on my machine, and it should work on the GitHub runners. Thanks for the help!


Android wallet - Next button overlapping recovery phrase

Android 1.0.0.?
Device OUKITEL K-10
Android 7.1.1
Screen resolution 2160x1080

See attached screen

checked


[Cloud] Gateways integration

This is now updated according to the initial implementation and discussions we had. Not everything is implemented at the moment, but for the features that work, I added examples of how to configure it with drg client.

Merging this. We can make further changes later on.


Update react-docgen dependency to latest version in terra-props-table

Issue Description
Currently we use react-docgen ^2.15.0
The latest version is 4.1.0
react-docgen release notes

This could potentially require a major version bump of terra-props-table

Planning to hold off on this change until around the end of Q2/beginning of Q3 to minimize major version bumps in the Terra UI ecosystem.


chore: bdd-nh-1577379760 to 0.0.1

chore: Promote bdd-nh-1577379760 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


bundleMDX returns

Thanks for this awesome library!
I have a question. Currently bundleMDX return frontmatter, code, and matter, but it would be really useful in some cases to have access to the parsed objects from remark and rehype. If I need those objects now, it seems the only way is run remark and rehype again outside of  bundleMDX.
Could you guys add these parsed objects ?
Thanks!

I don't think we can. the mdx compiling is done inside the xdm esbuild plugin and our only interaction is with the completed bundle.
What are you trying to access? would it be possible to throw in your own remark/rehype plugin to extract the data?

I see... Yes, that's what I'm trying to do, just writing a rehype plugin to extract some document data that I need.
Thanks!


SCOPE_ASSERT_EQUAL() accepts initialization lists as parameters

e.g.:
std::vector foo;
foo.push_back(1);
foo.push_back(2);
SCOPE_ASSERT_EQUAL({1, 2}, foo);
Requires C++11, natch.

This is done for expected parameters. I suppose I should get it to work for the actual parameter, too. That's going to require some boilerplate. /cc @uckelman

And ultimately closed for initializer lists in either/both positions in 005bc21a9e915827f6e81b07a38e60a76fc721ff.


[FIX] Syntonization of click on touch devices + startingIndex < 0 when bouncing

Fixes the click not synthesized for non-fields elements on touch devices when touch didn't end-up scrolling
Fixed JS errors due to negative values returned by _startingIndex() when bouncing

I'm sorry we didn't get back to this previously, but at this point this repo is essentially unmaintained.  Please use @html-next/vertical-collection or ember-collection for similar functionality.
Closing...


French translation update

Hi guys, I'm very happy to contribute again for a french PrimeLocale translation :-) Have a nice day, and an happy new year ! ;-)
For "am" and "pm" translation, it's ok for french people to use "am" and "pm". If you write "du matin" or "de l'apres midi" in your forms, french people will be very surprised because they don't use to see these "accademic" terms. Note that in France, hours are displayed from 00h00 to 23h59 included, so am / pm is not a casual usage.
For term "filter", there are two meanings : the common noun (example : please use this filter) and the verb (please filter all these stuff). French translation differs : common noun is "filtre" and verb "filtrer". I guess you need the verb, but in case I'm wrong, you are the 2 translations.
See you ;-)

I would use the Noun for "filter".  Thanks!!

Also remove "prevPageLabel" the correct one is "previousPageLabel"

Asked adjustments done. Thanks for this great framework :-)

Thank you for contributing!!!


rosdistro sync, Mon Jun 17 17:30:37 2019

Superflore yocto generator began regeneration of package(s) ['action_msgs'] from ROS distribution(s) dashing on Meta-ROS from commit fac1280676138b333bc34b8802b3147c4820c174.
To reproduce this PR, run the following command.
superflore-gen-oe-recipes --upstream-repo https://github.com/herb-kuta-lge/meta-ros2 --upstream-branch thud-draft-superflore-test --ros-distro dashing --only action_msgs

Regenerated: '['action_msgs']'

Draft; closing it.


Allow python3 to be used in vim_configurable

Should be a simple matter of using variables for the --enable-pythoninterp stuff.

closing because of #6865


Implement support for identifying a sidebar by a unique id value on page.

See: https://github.com/parameter1/base-imports/pull/56

 Links broken in body of Article

 For formulas and figures make it more obvious which is clicked on in-body.

Replaced by: https://github.com/parameter1/base-cms/pull/268


Question about the model size

Hi,
I am trying to build a Hyena model using hyperparameters from Table A4 (the 4th row). I am using the implementation of a standalone model:
layer2 = HyenaOperator(         d_model=1024,          l_max=19072,          order=36,          filter_order=64,         num_inner_mlps=4,         emb_dim=17,         w=14     )
However, when I check the number of parameters, I get ~42M instead of 355M as stated in the paper. Is it because I am using the standalone implementation? But even then how come the difference is so big? Or maybe I am missing something?
`def count_parameters(model):
return sum(p.numel() for p in model.parameters() if p.requires_grad)
count_parameters(layer)`

HyenaOperator is a single layer. “Order 36” refers to the number of
convolutions in the single layer, not the number of layers. To match the
models in the paper, you would want to use order 2, and use 36 of these
layers, along with MLPs and an embedding head (going from vocab size to
embedding dimension).
This is an example of a full language model:
https://github.com/HazyResearch/safari/blob/main/src/models/sequence/long_conv_lm.py
The HyenaOperator functions as the “mixer” in that language model.
On Fri, Apr 21, 2023 at 11:44 PM fransilvionGenomica <
@.***> wrote:

Hi,
I am trying to build a Hyena model using hyperparameters from Table A4
(the 4th row). I am using the implementation of a standalone model:
layer2 = HyenaOperator( d_model=1024, l_max=19072, order=36,
filter_order=64, num_inner_mlps=4, emb_dim=17, w=14 )
However, when I check the number of parameters, I get ~42M instead of 355M
as stated in the paper. Is it because I am using the standalone
implementation? But if that, how come the difference is so big? Or maybe I
am missing something?
`def count_parameters(model):
return sum(p.numel() for p in model.parameters() if p.requires_grad)
count_parameters(layer)`
—
Reply to this email directly, view it on GitHub
https://github.com/HazyResearch/safari/issues/12, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABDDIITAIMYR24KBFWE7IULXCN43PANCNFSM6AAAAAAXHURWMY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thank you for clarification!


Add blocking iterator style api on top of ServerStreamingCallables

Currently gax relies on grpc-stub to make this conversion, which makes it hard to compose ServerStreamingCallables. By pulling the implementation into gax, it allows for ServerStreamingCallables to be composed using simple call(Request, ResponseObserver, Context) chaining.  Furthermore, this adds the ability to cleanly cancel partially consumed streams.

Codecov Report

Merging #439 into master will increase coverage by 0.26%.
The diff coverage is 78.33%.

@@             Coverage Diff              @@
##             master     #439      +/-   ##
============================================
+ Coverage     69.65%   69.91%   +0.26%
- Complexity      645      672      +27
============================================
  Files           139      142       +3
  Lines          3032     3085      +53
  Branches        235      237       +2
============================================
+ Hits           2112     2157      +45
- Misses          831      837       +6
- Partials         89       91       +2

Impacted Files
Coverage Δ
Complexity Δ

...pi/gax/grpc/GrpcDirectServerStreamingCallable.java
100% <ø> (ø)
2 <0> (-1)
:arrow_down:

.../grpc/GrpcServerStreamingRequestParamCallable.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...a/com/google/api/gax/rpc/ServerStreamIterator.java
59.09% <59.09%> (ø)
8 <8> (?)

...om/google/api/gax/rpc/ServerStreamingCallable.java
40.74% <80%> (-0.93%)
5 <2> (+1)

...main/java/com/google/api/gax/rpc/ServerStream.java
81.81% <81.81%> (ø)
5 <5> (?)

...om/google/api/gax/rpc/QueuingResponseObserver.java
95.45% <95.45%> (ø)
12 <12> (?)

...oogle/api/gax/grpc/GrpcDirectStreamController.java
94.59% <0%> (+10.81%)
8% <0%> (+2%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7322ad1...439b539. Read the comment docs.

@pongad could you take a look too?

rebased

All suggestions applied. PTAL and if it looks good, please merge


Set version_id on a file after writiting

Ensure that we set the version_id after closing a file.

You actually make use of this file attribute?
Is there any way to test this, or is it outside of moto's capabilities?

So i have an external to s3 metadata store that having this attribute exist would make updating a lot simpler.
We can probably test it with moto.


Test case of SVG plot from Mathematica which does not render

Dear fuzhenn,
Thanks for this nice tool. I'm trying to convert .svg plots from Mathematica (our system renders on the screen in .svg, so this is convenient for us) and export them .png files to feed into LaTeX to produce PDF outputs and LaTeX.  Attached is a simple 2D plot that does not render correctly; it draws the axes but the curve does not appear visibly. The input .svg in in the attched .zip file.  I used your sample code to convert it (Case 3, file to file conversion.)

foo_svg.zip

Sorry, I haven't noticed this until now. Any luck to resolve this?
I think it's a bug of upstream canvg.


⚠ Cioos National CKAN has degraded performance

In b37e973, Cioos National CKAN (https://catalogue.cioos.ca/) experienced degraded performance:

HTTP code: 200
Response time: 14726 ms

Resolved: Cioos National CKAN performance has improved in 5130586 after 8 minutes.


Figure out how we can integrate ATAC-seq

The high level:
Derive a boolean vector over genes from an ATAC-seq dataset. Use this binary information in the production rates of RNAs.


the build instructions do not work

go get github.com/itsyouonline/caddy
rm -f $GOPATH/bin/caddy
cd $GOPATH/src/github.com/itsyouonline/caddy/caddy/
bash build.bash
cp caddy $GOPATH/bin/caddy

see last commit on the itsyouonline/code clone
it should have the required plugins registered, but it doesn't

https://github.com/itsyouonline/caddy/commit/b806c6f626a2184d5e7e4b4a7a1754a639b185fd
this is what I thought I had to do but no luck, when I build the binary and try the caddy I get

there are typo's in the import
also I see on the
https://github.com/itsyouonline/caddy/blob/master/caddy/caddymain/run.go
there is type not itsyou... but tsyou...
also shouldn't we github.com/mholt/caddy" also link to our cloned repo?
I did all of this no luck though

changed import paths to the forked repo
https://github.com/itsyouonline/caddy/commit/f4dfcc94f907b4580458f195f4c026278edca5de
https://github.com/itsyouonline/caddy-integration/commit/04f7d671f20cd853aeb8cd9b81b9c3286371f94b

Added "_" before import path of oauth plugin as stated in caddy documentation:

does not work

i've added go get ... to the build instructions to get the missing dependencies
that resolves one thing

now still it doesn't seem to work, was this ever tested?
i've just used the config file from the readme.md

It seems that you are using the oauth block as the whole config file without stating the host it will serve. You can just use the Caddyfile.example

I took the one from home page, please fix & make more clear

Fixed:
https://github.com/itsyouonline/caddy-integration/commit/fafcbd91bc3f7d6cdb1a542bce896fd251bea1b6


Unclear augmentation strategy

Hi, it is not very clear to me how the 240k augmented pairs are created. Could you please add more details and share any script that can help reproduce the process? Thank you!

any update on this issue?


How to let the after_node_run hook start after the output of the node is written?

What are you trying to do?
I have a node that creates a reporting string that will be written to txt file as output. I also have reporting hooks that start and stop mlflow runs. But I want the hook after_node_run to log  the report file as artifact but this file is then still in progress and can't be found.
I assume that the hook is called as the node is stopped but that the process for storing the output is running in parallel and not part of the node run time.
In short how can I make the hook start when the output of the node is saved?
Preferred channel
We will do our best to help you with your query but in future, head to Stack Overflow for questions like this. Tag your questions with kedro and we'll get a notification.

@widovanheemstra While there isn't an after_dataset_save in the currently-implemented set of hooks, you could use transformers to modify save operations. Said transformer could then be registered in the after_catalog_created hook (see https://kedro.readthedocs.io/en/stable/04_user_guide/04_data_catalog.html#applying-built-in-transformers).

@deepyaman thanks for this great solution. I will try this soon as I'm not able to code it now. But from the docs I think this will work.


Remove version: Sejda.PDFDesktop version 7.3.4

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://sejda-cdn.com/downloads/sejda-desktop_7.3.4_x64.msi
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 910)


Swap arrow direction in List->SortHeader

The arrow orientation should be:

ascending: up arrow
descending: down arrow

This change fixes that for the List SortHeader component

Ascending => UP

Descending => DOWN


Performance difference between -r option and babel-tape-runner

I am seeing a big difference in performance between using the -r option to load babel polyfills and using babel-tape-runner, which basically requires the same 2 libraries. What does -r do differently from require()?
$ babel-tape-runner tests/**/*.js
passed: 1128  failed: 0  of 1128 tests  (9.7s)

$ tape -r babel-register -r babel-polyfill tests/**/*.js
passed: 1128  failed: 0  of 1128 tests  (27.9s)

babel-tape-runner

Never mind, seems like it was a glitch in my computer that caused that spike.


DropdownButtonFormField is not re-rendered after value is changed programmatically

I just created a simple app in order to see what am I doing wrong
The code:
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key key, this.title}) : super(key: key);

  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;
  List<int> myList = [1, 2, 3, 4, 5, 6, 7, 8, 9, 0];
  int currentNumber = 1;
  int anotherNumber = 9;

  void _incrementCounter() {
    setState(() {
      _counter++;
      anotherNumber = _counter;
      currentNumber = _counter;
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            Text(
              'You have pushed the button this many times:',
            ),
            Text(
              '$_counter',
              style: Theme.of(context).textTheme.headline4,
            ),
            DropdownButtonFormField<int>(
              value: currentNumber,
              items: myList.map((int value) {
                return DropdownMenuItem<int>(
                  value: value,
                  child: Container(
                    width: 200,
                    child: Text(
                      value.toString(),
                    ),
                  ),
                );
              }).toList(),
              onChanged: (int newValue) {
                setState(() {
                  anotherNumber = newValue;
                  currentNumber = newValue;
                });
              },
            ),
            DropdownButtonFormField<int>(
              value: anotherNumber,
              items: myList.map((int value) {
                return DropdownMenuItem<int>(
                  value: value,
                  child: Container(
                    width: 200,
                    child: Text(
                      value.toString(),
                    ),
                  ),
                );
              }).toList(),
              onChanged: (int newValue) {
                setState(() {
                  anotherNumber = newValue;
                });
              },
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: Icon(Icons.add),
      ),
    );
  }
}

The flutter doctor -v:
$ flutter doctor -v
[✓] Flutter (Channel stable, v1.17.0, on Mac OS X 10.15.4 19E287, locale en-RS)
    • Flutter version 1.17.0 at /Users/lazarjovicic/flutter
    • Framework revision e6b34c2b5c (9 days ago), 2020-05-02 11:39:18 -0700
    • Engine revision 540786dd51
    • Dart version 2.8.1

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/lazarjovicic/Library/Android/sdk
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.4.1, Build version 11E503a
    • CocoaPods version 1.8.4

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)

[✓] VS Code (version 1.44.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.10.1

[✓] Connected device (1 available)
    • SM G970F • RF8M728WTMP • android-arm64 • Android 10 (API 29)

• No issues found!

The demonstration with code above:
https://streamable.com/fwwd46
EDIT:
The Expectation:
Update the first dropdown filed -> the second dropdown field will be updated automatically
The Result:
Update the first dropdown field -> the second dropdown field remains unchanged.
Please let me know if you need additional information or any further explanation regarding the problem.
Thanks

I check version 1.13.4 and this actually works
$ flutter doctor -v
[✓] Flutter (Channel unknown, v1.13.4, on Mac OS X 10.15.4 19E287, locale en-RS)
• Flutter version 1.13.4 at /Users/lazarjovicic/flutter
• Framework revision bd25f70c66 (5 months ago), 2019-12-19 09:45:02 -0800
• Engine revision 0f90e6546b
• Dart version 2.8.0 (build 2.8.0-dev.0.0 aa6709974d)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at /Users/lazarjovicic/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 29.0.2
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.4.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.4.1, Build version 11E503a
• CocoaPods version 1.8.4
[✓] Android Studio (version 3.6)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 45.1.1
• Dart plugin version 192.7761
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
[✓] VS Code (version 1.44.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.10.1
[✓] Connected device (2 available)
• SM G970F • RF8M728WTMP                          • android-arm64 • Android 10 (API 29)
• iPhone 6 • B56B92F3-A2D9-4F91-A161-E2761F80C51C • ios           • com.apple.CoreSimulator.SimRuntime.iOS-12-4 (simulator)
• No issues found!

Reproduces with current dev 1.19.0-0.0.pre as well.
But yes, 1.13.4 is working as intended

I changed the title, because new values are set by setState, but second DropdownButtonFormField is not updated
  @override
  Widget build(BuildContext context) {

    print(currentNumber);
    print(anotherNumber);

    return Scaffold(

DropdownButtonFormField widget is really using  badly the value param. I just found a related issue here https://github.com/flutter/flutter/issues/56929
You can reproduce it by tapping FAB button 10 times using the example code in this issue!

CC @shihaohong

I can confirm @pedromassango PR fixes my issue: #57006
Pretty sure it fixes this one as well

Thanks. I'm just adding tests, before opening the PR for review

PR moved to https://github.com/flutter/flutter/issues/56898

I've marked this issue as a candidate for cherry-picking into the stable branch since this is a regression that has resulted in multiple open issues over the last few days (https://github.com/flutter/flutter/issues/57006, https://github.com/flutter/flutter/issues/56983) and revived an older DropdownButtonFormField issue (https://github.com/flutter/flutter/issues/27821#issuecomment-627939210), presumably from devs trying to find an answer to their problem.
See https://github.com/flutter/flutter/wiki/Flutter-Cherrypick-Process for more information on how the process works.

@shihaohong Can you confirm that this is not a regretion too: https://github.com/flutter/flutter/pull/56365? Or it always behave that way?!

@pedromassango I don't know since I haven't looked at that issue yet. However, since that issue is unrelated to this one, let's discuss that one in #56365 and not here.

Maybe include the cp: 1.18 label as well??

When we can expect this issue to be solved?
Thanks

This was already solved. We're just waiting to have it in the next Flutter beta release!

This was already solved. We're just waiting to have it in the next Flutter beta release!

Sorry, I wasn't clear, when we can expect this issue to be in stable release?
thanks

Ok. Can take time for stable channel to be released. So if you really want this, you may want to use the beta channel, once this lands to beta

Ok. Can take time for stable channel to be released. So if you really want this, you may want to use the beta channel, once this lands to beta

Thanks, but that is a bad idea for production app... thanks

Please note that I never know when a stable version will be released. I just say that because this PR is not even in a beta release, so it can take time to go to stable.

@shihaohong which commit(s) are needed for the 1.17 branch if we cherrypick this?

@pcsosinski This is the commit needed for the cherrypick: https://github.com/flutter/flutter/commit/1aaf73fad0fa3e4921e4edcf693ff61d6cbf0e1b

eng approval for cp of https://github.com/flutter/flutter/pull/57037 into 1.17

@lazarvgd This has landed to 1.17.2

removed 1.18 label as we're going to 1.19 for beta soon.


[KARAF-3303] "keyStoreAvailabilityTimeout" is treated as boolean in J…

…MX configuration
Hi all,
This PR is related to:
https://issues.apache.org/jira/browse/KARAF-3303
Andrea

Rebase to test Jenkins pull request validation


pritunl-client: command not found

Good afternoon, a question, I have been using githubaction: nathanielvarona/pritunl-client-github-action@v1, and everything had been working correctly, but until today it gave me this error, is there something I need?

This is mi definition :

name: Setup Pritunl Profile and Start VPN Connection
uses: nathanielvarona/pritunl-client-github-action@v1
with:
profile-file: ${{ secrets.PRITUNL_PROFILE_FILE }}
profile-pin: ${{ secrets.PRITUNL_PROFILE_PIN }}

I'm getting the same error across all my actions that use this step:
      - name: Setup Pritunl Profile and Start VPN Connection
        uses: nathanielvarona/pritunl-client-github-action@v1
        with:
          profile-file: ${{ secrets.PRITUNL_PROFILE_FILE }}
          profile-pin: ${{ secrets.PRITUNL_PROFILE_PIN }}

Hello @JosueCL11 and @Alex-Munro, thank you for reporting the issue.
This issue is related to the GitHub Actions Apt Repositories List and Cache.
This is solely from the GitHub Actions Virtual Environment Images releases issue.
There is a fix for this, however, I need to validate and fully test it.
(As much as possible I won't touch anything in the GitHub action Virtual Environment to maintain the integrity of this action)
For now, I would suggest using a specific client installation. This method obtains the pritunl-client package from the https://github.com/pritunl/pritunl-client-electron/releases instead of the https://repo.pritunl.com/stable/apt/dists/jammy/.
Here is an example:
- name: Setup Pritunl Profile
  id: pritunl-connection
  uses: nathanielvarona/pritunl-client-github-action@v1
  with:
    profile-file: ${{ secrets.PRITUNL_PROFILE_FILE }}
    profile-pin: ${{ secrets.PRITUNL_PROFILE_PIN }}
    client-version: 1.3.3883.60 # <-- PLEASE ADD THIS INPUT IN YOUR ACTION

My tests earlier:
Test # 1: Failed - Installation using Apt Registry
Test # 2: Passing - Specify the Client Version
https://github.com/nathanielvarona/gha-pub-test-repo/actions/workflows/connection-tests-manual-install-only.yml
Let me know if this fixes the issue on your side.
Again good day and have a nice weekend.

UPDATES:
Installation Test
As of this moment testing, the Packager Manager (Apt Repo) Based installation is now working https://github.com/nathanielvarona/gha-pub-test-repo/actions/runs/10122164747.
I haven't changed anything in our code, the issues you might experiencing could either be from the GitHub Actions Virtual Environment https://github.com/actions/runner-images or from the Pritul Apt Repo https://repo.pritunl.com/stable/apt/.
Recommendation
Still, I would suggest using the Action input client-version and specifying the later/latest version of desired. To install the pritunl-client from the Pritunl Client GitHub Releases https://github.com/pritunl/pritunl-client-electron/releases.
Thanks,
Nil

Thanks @nathanielvarona!
Adding the client-version worked for me

I updated the README for other or future GitHub Action users.
Documentation Section: Noticeable Issues and Solutions
Release: https://github.com/nathanielvarona/pritunl-client-github-action/releases/tag/v1.6.12


Fix __get_pydantic_core_schema__ for Enum

Fixes #5999

please review

Clearly an in depth refactor is needed here to organize the flow in GenerateSchema. We've got several boolean arguments like the one I'm adding here and it's not immediately clear what calls what. But this is a small change for now that fixes this particular bug. I think we should target this refactor for after the v2 release when we will undoubtedly get more bugs reported.

@adriangb This place is a can of horrors. I tried to make a check for __get_pydantic_core_schema__ in a slightly different place (in enum_prepare_pydantic_annotations), but then I noticed that other standard types may also be prone to this problem. Indeed, this place requires deep refactoring.

This only applies to enums. We don’t produce schemas for subclasess of other standard types.


Terragrunt doesn't appear to clear cache properly when branches are updated.

When using Terragrunt ref's to branch names (not tagged versions) for modules like this:
terraform {
  source = "github.com/firehawkvfx/firehawk-main.git//modules/vault?ref=test-pull-request-236"

I've noticed that if I update referenced branches and ensure my working tree is updated, terragrunt doesn't appear to correctly recognise this and the Terragrunt cache folder needs to be removed.

A terragrunt apply before this removal of the cache will not work properly (the module wont be redownloaded).
Removal of the cache will fix the problem.

I suspect this is because Terragrunt is assuming a ref is to a tagged version, and might just be comparing the cached tag string to the current working tree, which would be fine for those cases.  But if the ref is to a branch name the commit hash in the working tree would have to be used to determine if the cache is invalid, not just the tag name.
Thats just a guess, but it would explain the behaviour I observe.
For now when I update branches, I must always remove the terragrunt cache before any apply operations for updates to work smoothly.

I suspect this is because Terragrunt is assuming a ref is to a tagged version, and might just be comparing the cached tag string to the current working tree, which would be fine for those cases.

This is exactly right. The code assumes that if you're using ref, it's pointing to something immutable, and doesn't bother to re-download. In general, pointing at a branch is an anti-pattern, as you never know what you'll end up deploying or what was deployed previously.
The alternative would be to try to re-download the code for every single apply, plan, output, destroy, etc, which would be very slow.
Feedback/ideas are welcome.

Terraform does support the use of branches which is useful for dev, could Terragrunt also do that for coherence?
I'm also curious what your dev workflow looks like, and how you test if you are committing to a branch many times per day.  tagging each one uniquely and updating the refs would not be nice!

Terraform does support the use of branches which is useful for dev, could Terragrunt also do that for coherence?

Terraform requires you to run init manually when you update the source URL. You can do the same workflow with Terragrunt.

I'm also curious what your dev workflow looks like, and how you test if you are committing to a branch many times per day. tagging each one uniquely and updating the refs would not be nice!
I guess I would like to suggest that if the commit hash were used, then versioned tags would still be immutable, but branches would be an option for those that want it.

For local dev, we use a local check out via --terragrunt-source. So there's no need to keep pushing branches and re-downloading code, as you just run it directly from the latest on your file system.

I tried terragrunt run-all init, but this didn't end up redownloading the modules to the latest commits on the branches.
My dev workflow is a little different to how you describe, because I code locally in vscode, and then pull any changes into a cloud 9 instance and test from there - it helps provide a more consistent environment for others (but the code editor is not nice compared to vscode, so I don't edit there really).

Why run-all init instead of just init?

Oh, actually, I'm not sure init will help as this is about downloading the code, which is before init.
Given that this doesn't seem to be a common use case, I think the best workaround may be to run with the --terragrunt-source-update flag. That will force Terragrunt to redownload everything every time.

This change to my workflow has helped when testing out single modules, thankyou.  One thing I haven't been able to improve in the workflow is if I have a repo with many modules, and then to test before a release, there may be many modules that reference the other repo with version refs.  Sometimes I can miss updating some of these refs to branches to test.
If there is an update that needs to be tested, is there a way to force multiple/many module refs that might point at a repo to use a particular branch to test?  Sometimes I have found I might forget to update some of the refs, and this introduces more human error than I'd like when I test updates.  It's probably just I haven't grasped the proper workflow in some way.

Take a look at --terragrunt-source-map.

Thanks @brikis98 that looks excellent.

OK, great. Closing this issue!

I was perhaps mistaken because this is an example:
source = "github.com/firehawkvfx/firehawk-main.git//modules/vault?ref=v0.0.20"
source = "github.com/firehawkvfx/firehawk-main.git//modules/vault-kv-init?ref=v0.0.20"
source = "github.com/firehawkvfx/firehawk-main.git//modules/vault-policies?ref=v0.0.20"

It doesn't appear --terragrunt-source-map would retarget the github.com/firehawkvfx/firehawk-main.git to some local path and handle correction of the immutable ?ref=v0.0.20 suffix.


Set DB connection error level to error

Codecov Report

Merging #7724 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #7724      +/-   ##
==========================================
+ Coverage   41.28%   41.29%   +<.01%
==========================================
  Files         472      472
  Lines       63833    63833
==========================================
+ Hits        26356    26361       +5
+ Misses      34039    34034       -5
  Partials     3438     3438

Impacted Files
Coverage Δ

routers/init.go
65.33% <0%> (ø)
:arrow_up:

modules/log/event.go
64.61% <0%> (-1.03%)
:arrow_down:

models/repo_list.go
72.08% <0%> (-1.02%)
:arrow_down:

routers/repo/view.go
43.25% <0%> (+1.01%)
:arrow_up:

modules/process/manager.go
81.15% <0%> (+4.34%)
:arrow_up:

models/unit.go
67.56% <0%> (+5.4%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76408d5...5034bfd. Read the comment docs.


Fragment#onActivityResult() don't called when Fragment added in FragmentActivity

add Fragment in FragmentActivity:
getSupportFragmentManager()                         .beginTransaction()                         .add(R.id.fragment_container,                                 Fragment.instantiate(this, fName))                         .commitAllowingStateLoss();
I find the code in FragmentPermissionsDispatcher :
Intent intent = new Intent(Settings.ACTION_MANAGE_OVERLAY_PERMISSION, Uri.parse("package:" +     target.getActivity().getPackageName()));   target.getActivity().startActivityForResult(intent, REQUEST_ADDVIEWTOWINDOW);
target.getActivity() return the FragmentActivity.if  FragmentActivity#startActivityForResult() be called, there are only FragmentActivity#onActivityResult() be called.
so i try to use 'target.startActivityForResult(intent, REQUEST_ADDVIEWTOWINDOW);'   instead of  'target.getActivity().startActivityForResult(intent, REQUEST_ADDVIEWTOWINDOW);` in MyFragmentPermissionsDispatcher(copy from FragmentPermissionsDispatcher ). it works, Fragment#onActivityResult() is be called.
But ,  it's not a good way. so i want know how to use the PermissionsDispatcher in Fragment which added in FragmentActivity.

Are you asking the best way to integrate PermissionsDispatcher in Fragment which is added in FragmentActivity?

yes @shiraji

Yea. I think this is a bug. I will fix this.
https://github.com/hotchemi/PermissionsDispatcher/blob/master/processor/src/main/kotlin/permissions/dispatcher/processor/impl/helper/SystemAlertWindowHelper.kt#L19 this generates
target.getActivity().startActivityForResult(intent, REQUEST_ADDVIEWTOWINDOW);

It should use Fragment#startActivityForResult not Activity#startActivityForResult

This is what you report, right? @S-MILE-S

yes，it‘s working.


feature changes for issue #18543

Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[ ] All your commits have a Signed-off-by line in the message. (more info)

Hi @theparthshukla, can you maybe flip this to Draft while we work out the details on this in the issue? Also, can you update the title so it's something more descriptive? That really helps when looking at the list of PRs to review 👍