Portfolio mobile

Added  a popup on see project button click

Hi @Favourezeugwa ,
thank you for the review
Im facing two problems when I put my html in js all the images on the page are not working

and no one seems to be able to understand my problem I have tried everything I can
can u help me please

Hello I'm not quite sure how to do everything in js can you help me out
please
On Wed, 08 Feb 2023, 13:12 Favour Ezeugwa, @.***> wrote:

@.**** requested changes on this pull request.
STATUS: REQUIRES CHANGES 🚦 ⚠ ♻
Hi Team 👋🏽 ,
Good job so far!
There are some issues that you still need to work on to go to the next
project but you are almost there!
[image: close lady]
https://user-images.githubusercontent.com/99246359/207367678-ef4e9b86-75b7-4d8e-b9b5-899f2e87c934.gif
Highlights 💯

No Linter errors ✔
Descriptive Pull request summary✔
Good commit messages ✔
Professional Readme file ✔

Required Changes ♻
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop
the approval of this PR. However, I strongly recommend you to take them
into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something
is not 100% clear.
Please, remember to tag me in your question so I can receive the
notification.
Please, do not open a new Pull Request for re-reviews. You should use the
same Pull Request submitted for the first review, either valid or invalid
unless it is requested otherwise.
As described in the Code reviews limits policy
https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a
limited number of reviews per project (check the exact number in your
Dashboard). If you think that the code review was not fair, you can request
a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
In index.js
https://github.com/Munyabelden/munyabelden.github.io/pull/17#discussion_r1099974573
:

+const popUpCard = document.querySelectorAll('[data-modal-target]');

+const closeCard = document.querySelectorAll('[data-close]');

Great job implementing the popup modal 💪🏽
I believe this project requires us to do it differently, from the
way you have done yours.
Here is the requirement 👇🏽

[image: Screenshot 2023-02-08 at 04 51 58]
https://user-images.githubusercontent.com/99246359/217509932-4413ef50-1932-4155-b91a-f6dd0316f9f4.png

The JavaScript code should be implemented as an array of objects to
store JavaScript objects containing the information for each project.
Each object should contain at least the following information about
the project: name, description, featured image, technologies, link to live
version, and link to the project source code.

Something like this 👇🏽
const projects = [{
name: "Submarine game",

description: "A Phaser3 platform game built as part of the Microverse JavaScript program.",

image: "link_to_image.jpg",

technologies: ["Phaser3", "JavaScript", "Jest"],

link: "link_to_live_version.com",

},
{
name: "Submarine game",

description: "A Phaser3 platform game built as part of the Microverse JavaScript program.",

image: "link_to_image.jpg",

technologies: ["Phaser3", "JavaScript", "Jest"],

link: "link_to_live_version.com",

}
]

Your project card should also be in the js file too. No Project card
should be on your HTML file. 🌸

In style.css
https://github.com/Munyabelden/munyabelden.github.io/pull/17#discussion_r1099987048
:

+.card-details {

position: fixed;

display: flex;

flex-direction: column;

align-items: center;

justify-content: center;

z-index: 100;

background: #fff;

border-radius: 10px;

box-shadow: 0 0 0 1000px rgba(193, 199, 208, 0.9);

margin: 0 auto;

pointer-events: all;

max-width: 400px;

padding-block: 3%;

padding-inline: 4%;

text-align: start;

+}

I think it will be better if we added some margins to the sides of
your card details so that it looks like that of Figma.

Here is what I can see compared to Figma 👇🏽
⚠ Kindly ignore the blank image from my Figma screenshot 😉
Your Design Figma Design
[image: Screenshot 2023-02-08 at 05 00 15]
https://user-images.githubusercontent.com/99246359/217512622-d5f4312a-f629-4a3d-8d64-904da7a53f52.png
![image: Screenshot 2023-02-08 at 05 08 39]
https://user-images.githubusercontent.com/99246359/217513241-855eefeb-cc80-4f21-b3de-d35886bd1ad8.png
—
Reply to this email directly, view it on GitHub
https://github.com/Munyabelden/munyabelden.github.io/pull/17#pullrequestreview-1288934187,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A32THZHH4UVX5GD5B2WXG23WWN5TRANCNFSM6AAAAAAUVBTLBU
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hello how do I create everything in js
On Thu, 09 Feb 2023, 08:32 Kalolo Chola Lemba, @.***>
wrote:

@.**** requested changes on this pull request.
Hi @Munyabelden https://github.com/Munyabelden 👋
Good job so far working on the project requirements!
There are some issues that you still need to work on to go to the next
project but you are almost there!
To Highlight 🎉
No linter errors. ✔
GitHub flow is followed. ✔
Required Changes ♻
Check the comments under the review in the inline comments.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the
approval of this PR. However, I strongly recommend you to take them into
account as they can make your code better.
You can also consider:
N/A
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something
is not 100% clear.
Please, remember to tag me in your question so I can receive the
notification.
Please, do not open a new Pull Request for re-reviews. You should use the
same Pull Request submitted for the first review, either valid or invalid
unless it is requested otherwise.
As described in the Code reviews limits policy
https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have
a limited number of reviews per project (check the exact number in your
Dashboard). If you think that the code review was not fair, you can request
a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
In index.js
https://github.com/Munyabelden/munyabelden.github.io/pull/17#discussion_r1101029606
:

+const popUpCard = document.querySelectorAll('[data-modal-target]');
+const cardElement = document.querySelector('.card');

+const cardArray =  [

{

id: 'card-1',

title: 'Tonic',

list: {

 title: 'canopy',

 dev: 'Backend-dev',

 year: '2015'

},

images: {

 large: './images/Portfolio3x.png',

 small: './images/Portfolio.jpg'

},

information: 'Experimental content creation feature that allows users to add to an existing story over the course of a day without spamming their friends.',

technologies: {

 html: 'html',

 css: 'css',

 javascript: 'javascript',

 ruby: 'ruby on rails',

 github: 'github',

 bootstrap: 'bootstrap'

},

live: 'https://munyabelden.github.io/',

source: 'https://github.com/Munyabelden/munyabelden.github.io'

},

{

id: 'card-2',

title: 'Multi-post Stories',

list: {

 title: 'canopy',

 dev: 'Backend-dev',

 year: '2015'

},

images: {

 large: './images/Portfolio3x.png',

 small: './images/Portfolio.jpg'

},

information: 'Experimental content creation feature that allows users to add to an existing story over the course of a day without spamming their friends.',

technologies: {

 html: 'html',

 css: 'css',

 javascript: 'javascript',

 ruby: 'ruby on rails',

 github: 'github',

 bootstrap: 'bootstrap'

},

live: 'https://munyabelden.github.io/',

source: 'https://github.com/Munyabelden/munyabelden.github.io'

},

{

id: 'card-1',

title: 'Tonic',

list: {

 title: 'canopy',

 dev: 'Backend-dev',

Good job trying to implement this but as suggested by the previous code
reviewer your cards should be displayed dynamically using javascript DOM
manipulation so all your code in your card section of your index.html file
should be deleted and the cards should be rendered dynamically.
I also noticed your pop-up is only working on one card in your desktop
version and not working in the last 3 cards and also in your mobile view
your card are not popping up please kindly fix this issue for you to
proceed to the next project both pop up windows for desktop and mobile view
shouls be fully functional
—
Reply to this email directly, view it on GitHub
https://github.com/Munyabelden/munyabelden.github.io/pull/17#pullrequestreview-1290501810,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A32THZBTUSBAD6QHR22DHQ3WWSFPHANCNFSM6AAAAAAUVBTLBU
.
You are receiving this because you were mentioned.Message ID:
@.***>

This might be the last review you guys have. If you need any assistance you can reach out to me on slack by searching my name Hammas in full-time-students channel :+1:


Created Shipping page of vigybag

Fixes Issue  #2077

Closes #2077
Changes proposed

Screenshots

Note to reviewers

Summary by CodeRabbit

New Features

Added a new routing option for direct access to the Shipping information page.
Introduced animated GIFs in the feedback modal to enhance user engagement.
Expanded the footer with an additional link to the Shipping page.

Bug Fixes

Updated the "Our Services" link for consistency with the routing structure.

Style

Reformatted code for improved readability and consistency in the application.

check once code rabbit code

hello @codervivek5
done the code rabbit work.
please review this PR and merge it

check once code rabbit code

done


Nextjs v14.1 support

Hello,
In my project, I have updated my Nextjs version to 14.1. However, due to definition of i18nRouter accepting request: NextRequest, which comes from Nextjs v14.0.4, it is not working anymore.
Do you plan to bump your Nextjs version? Thanks!

Thanks! Just released in v5.2.1... We'll get this automated

Hey @i18nexus, thanks for the update, but I still can't get it working tho.
Here you can see I have installed the latest version of the package:

But NextRequest is being still imported from Nextjs v14.0.4.

Any idea? I have tried to delete node modules, remove package, add package again, still not working. Thanks.

Hmm, can you try deleting your node_modules as well as package.json and running npm install again?
Also run npm update on your react and react typings. If I recall correctly, I believe I had to update these on our example project.

It looks like deleting pnpm-lock.yaml and then installing helped. Thanks!

Great!


Pecking when parting

I was making this today:
UNITS MM
STOCK D12
TOOL RECT R0.2 L2
DEPTH CUT0.5 FINISH0.2
L0.5
L5.5 DS0 DE4
L0.2 DS7.8 DE8
L1.3 D8
L0.2 DS10.3 DE10.5
L0.7 D10.5
L0.2 DS10.5 DE10.3
L2
Its a stainless steel cone. And it was all going great until I went to part it. Then my whole lathe shook to pieces! I had to slow the RPM right down to like 250 and manually peck away.
Is there a way we can define a pecking routine for parting or deep grooves?
Also notice that the fillet at the back edge doesnt get cut, but if you do:
UNITS MM
STOCK D12
TOOL RECT R0.2 L2
DEPTH CUT0.5 FINISH0.2
L0.5
L5.5 DS0 DE4
L0.2 DS7.8 DE8
L1.3 D8
L0.2 DS10.3 DE10.5
L0.7 D10.5
L0.2 DS10.5 DE10.3
L2 D5
Then it does cut it.

Hi @Festivejelly, nice model. Yes, looks like there was a problem when the last few mm width of the finish layer wouldn't be cut if it was on the left edge of the part - requiring the tool to travel into the to-be-parted area of the part.

That piece of material should now be removed during parting.

Might be of interest to you as I saw you had NC viewer open which I couldnt get on with so i hacked my own together:
https://festivejelly.github.io/LatheGcodeVisualiser/
If you paste the below in the simulate section and click simulate you can use the slider to step over the cuts and travels etc.
; UNITS MM
; STOCK D12
;
; TOOL RECT R0.2 L2
; DEPTH CUT0.5 FINISH0.2
;
; L0.5
; L5.5 DS0 DE4
; L0.1 DS7.8 DE8
; L1.4 D8
; L0.1 DS10.3 DE10.5
; L0.8 D10.5
; L0.1 DS10.5 DE10.3
; L2 D9
; Run time 2.5 min, cutting 77% of time
; Working area 10.50 by 6.14 mm
G21 ; metric
G18 ; ZX plane
G90 ; absolute positioning
F200
X-6 ; zero your tool X on centerline
Z0 ; zero your tool Z at the right edge of the stock
G91 ; relative positioning
Z0.5
F50
X6.14 ; cut 3 mm2
F200
X-6.14
Z0.5
F50
X5.87 ; cut 2.9232 mm2
Z-0.31 X0.12 ; cut 0.0217 mm2 at -68.84°
F200
X-5.99
Z0.81
F50
X5.69 ; cut 2.8329 mm2
Z-0.43 X0.16 ; cut 0.024 mm2 at -69.59°
F200
X-5.85
Z0.93
F50
X5.51 ; cut 2.7429 mm2
Z-0.4 X0.15 ; cut 0.0231 mm2 at -69.44°
F200
X-5.66
Z0.9
F50
X5.33 ; cut 2.6526 mm2
Z-0.44 X0.16 ; cut 0.0225 mm2 at -70.02°
F200
X-5.49
Z0.94
F50
X5.15 ; cut 2.5626 mm2
Z-0.41 X0.15 ; cut 0.0217 mm2 at -69.90°
F200
X-5.3
Z0.91
F50
X4.97 ; cut 2.4723 mm2
Z-0.39 X0.14 ; cut 0.021 mm2 at -70.25°
F200
X-5.11
Z0.89
F50
X4.78 ; cut 2.3781 mm2
Z-0.4 X0.15 ; cut 0.0236 mm2 at -69.44°
F200
X-4.93
Z0.9
F50
X4.6 ; cut 2.2879 mm2
Z-0.4 X0.15 ; cut 0.0236 mm2 at -69.44°
F200
X-4.75
Z0.9
F50
X4.42 ; cut 2.1978 mm2
Z-0.41 X0.15 ; cut 0.0227 mm2 at -69.90°
F200
X-4.57
Z0.91
F50
X4.24 ; cut 2.1076 mm2
Z-0.41 X0.15 ; cut 0.0221 mm2 at -69.90°
F200
X-4.39
Z0.91
F50
X4.06 ; cut 2.0175 mm2
Z-0.42 X0.15 ; cut 0.0213 mm2 at -70.35°
F200
X-4.21
Z0.92
F50
X2 ; cut 0.9917 mm2
F200
Z-0.28 X0.01 ; cut 0.0009 mm2 at -87.95°
F50
Z-0.06 X0.04 ; cut 0.0024 mm2 at -56.31°
Z-0.11 X0.11 ; cut 0.0012 mm2 at -45.00°
F200
X-2.16
Z0.95
F50
X2 ; cut 1 mm2
F200
X-2
Z0.5
F50
X2 ; cut 1 mm2
F200
X-2
Z0.5
F50
X0.75 ; cut 0.3667 mm2
F200
Z-0.28 X0.01 ; cut 0.0009 mm2 at -87.95°
F50
Z-0.06 X0.04 ; cut 0.0024 mm2 at -56.31°
Z-0.11 X0.11 ; cut 0.0012 mm2 at -45.00°
F200
X-0.91
Z0.95
F50
X0.75 ; cut 0.3741 mm2
F200
X-0.75
Z0.5
F50
X0.75 ; cut 0.3749 mm2
F200
X-0.75
Z0.5
F50
X0.75 ; cut 0.375 mm2
F200
X-0.75
Z0.5
F50
X0.75 ; cut 0.375 mm2
F200
X-0.75
Z0.5
F10
X1.3 ; cut 1.4677 mm2
F200
X-1.3
Z-10.49
X6.14
F50
Z0.52 ; cut 0.0052 mm2
F200
Z0.02 X-0.05 ; cut 0.0005 mm2 at -21.80°
Z0.05 X-0.05 ; cut 0.0006 mm2 at -45.00°
Z0.09 X-0.05 ; cut 0.0009 mm2 at -60.95°
F50
Z5.31 X-1.93 ; cut 0.0531 mm2 at -70.03°
X-1.81 ; cut 0.0181 mm2
F200
Z0.02 X-0.05 ; cut 0.0005 mm2 at -21.80°
F50
Z0.15 X-0.15 ; cut 0.0016 mm2 at -45.00°
F200
Z0.08 X-0.05 ; cut 0.0008 mm2 at -57.99°
F50
Z1.25 ; cut 0.0125 mm2
X-1 ; cut 0.01 mm2
F200
Z0.02 X-0.05 ; cut 0.0005 mm2 at -21.80°
F50
Z0.15 X-0.15 ; cut 0.0016 mm2 at -45.00°
F200
Z0.08 X-0.05 ; cut 0.0008 mm2 at -57.99°
F50
Z2.5 ; cut 0.025 mm2
Z0.05 X0.02 ; cut 0.0019 mm2 at 68.20°
Z0.15 X0.15 ; cut 0.0036 mm2 at 45.00°
F200
Z0.05 X0.08 ; cut 0.0008 mm2 at 32.01°
;peck parting
F10
X1 ; cut
F100
X-1 ; retract
X1 ; travel
F10
X1 ; cut
F100
X-1 ; retract
X1 ; travel
F10
X1 ; cut
F100
X-1 ; retract
X1 ; travel
F10
X1 ; cut
F100
X-1 ; retract
X1 ; travel
F10
X1 ; cut
F200
X-6; retract
F200
Z-10.5

Very nice GCode visualization in your tool! Love that you show the next move with the dashed line. It's a little hard to see black on grey text though 😄

Did you try different speeds for parting, perhaps a combination of very fast spindle and medium speed cutter advance could get you a good result in 1 parting pass?

Oops CSS bug, I think its to do with system colours etc ill need to look at that!
I think a big part of the problem is that I was machining 304. I have 303 so im going to try that.
It was cutting everything else fine, maybe ill swap to my 1.5mm parting tool.


improve:GetCharsetDesc

What problem does this PR solve?
pingcap/tidb#9635
What is changed and how it works?
GetCharsetDesc  now get desc from inited variable descs.
Check List
Tests

Unit test

Code changes

Has exported function/method change

Related changes

Need to update go.mod in tidb

Benchmark GetCharsetDesc.
Before:
GO111MODULE=on go test -run GetCharsetDesc   -bench Benchmark  github.com/pingcap/parser/charset
goos: darwin
goarch: amd64
pkg: github.com/pingcap/parser/charset
BenchmarkGetCharsetDesc-8       20000000                54.5 ns/op
PASS
ok      github.com/pingcap/parser/charset       1.160s

After:
GO111MODULE=on go test -run GetCharsetDesc   -bench Benchmark  github.c
om/pingcap/parser/charset
goos: darwin
goarch: amd64
pkg: github.com/pingcap/parser/charset
BenchmarkGetCharsetDesc-8       100000000               13.4 ns/op
PASS
ok      github.com/pingcap/parser/charset       1.361s

@ngaut PTAL

LGTM

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: lysu:x: hhxccYou have signed the CLA already but the status is still pending? Let us recheck it.

Thank you @hhxcc
Please sign the CLA.

@ngaut  ok, done.

@kennytm please sign the CLA too o.o~


The overview tab should only show advantages that the character has taken.

I just noticed that the overview tab is showing all advantages, not just the ones the character has taken. Much as I would like to blame that on the recent changes, I checked back and saw that it was happening on my watch too. I don't know if you can selectively turn off a line of a grid. If not, the fix may be to have a single div that holds everything and is display: content, and has its content selectively displayed.

I think we can do this in similar ways to the weapon notes css.
I'll take a look.
On Wed, Jan 4, 2023, 11:14 AM John Lamping @.***> wrote:

I just noticed that the overview tab is showing all advantages, not just
the ones the character has taken. Much as I would like to blame that on the
recent changes, I checked back and saw that it was happening on my watch
too. I don't know if you can selectively turn off a line of a grid. If not,
the fix may be to have a single div that holds everything and is display:
content, and has its content selectively displayed.
—
Reply to this email directly, view it on GitHub
https://github.com/epic-power-rpg/roll20/issues/46, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABK6O2ESDAX4AMGTZJALA3TWQXDZVANCNFSM6AAAAAATRD7SOM
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Fixed in #47


Register 0.2.0

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/13625
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.0 -m "<description of version>" b26f7ab81b80104d92c96c88af12bf4fdfb1c691
git push origin v0.2.0


API Validation crashes (Submodel Repository Service)

With our API, the validation crashes with the following output:
> aas_test_engines check_server http://localhost:4102/api/v1 https://admin-shell.io/aas/API/3/0/SubmodelRepositoryServiceSpecification/SSP-002
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "C:\python\python3_11_6\Scripts\aas_test_engines.exe\__main__.py", line 7, in <module>
  File "C:\python\python3_11_6\Lib\site-packages\aas_test_engines\__main__.py", line 163, in main
    commands[command](remaining_args)
  File "C:\python\python3_11_6\Lib\site-packages\aas_test_engines\__main__.py", line 111, in run_api_test
    result, mat = api.execute_tests(exec_conf, suite, args.version)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\python\python3_11_6\Lib\site-packages\aas_test_engines\api.py", line 23, in execute_tests
    return v3_0.execute_tests(conf, suite)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\python\python3_11_6\Lib\site-packages\aas_test_engines\test_cases\v3_0\api.py", line 1699, in execute_tests
    sub_mat = test_suite.execute()
              ^^^^^^^^^^^^^^^^^^^^
  File "C:\python\python3_11_6\Lib\site-packages\aas_test_engines\test_cases\v3_0\api.py", line 574, in execute
    self.execute_semantic_tests()
  File "C:\python\python3_11_6\Lib\site-packages\aas_test_engines\test_cases\v3_0\api.py", line 565, in execute_semantic_tests
    test_fn()
  File "C:\python\python3_11_6\Lib\site-packages\aas_test_engines\test_cases\v3_0\api.py", line 1460, in test_include_concept_descriptions
    _assert('conceptDescriptions' in data, 'contains conceptDescriptions', Level.WARNING)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: argument of type 'NoneType' is not iterable

it started going well so far, I could successfully use the validation to detect and fix several bugs in our API and received usable results.
But after fixing the most recently detected bug, I am no longer able to use the validator and just receiving this error instead.

I also had the same issue, https://github.com/admin-shell-io/aas-test-engines/issues/78 here you can see how I was able to get it working for now.


PDF Fill form issue, cannot find form field error

What were you trying to do?
I am trying to fill form fields on a fillable PDF
How did you attempt to do it?
I retrieved the form field name by inspecting the element:

![image](https://github.com/Hopding/pdf-lib/assets/33523990/d6561c1d-b93e-4c18-934c-4091f8d83f5e)
const mergedPdf = await PDFLib.PDFDocument.create();
const pdfBytes = new Uint8Array(await result.arrayBuffer());
        const pdfDoc = await PDFLib.PDFDocument.load(pdfBytes);
        const form = pdfDoc.getForm()
        const nameField = form.getTextField('Insert Preparer Name');
        const nameField2 = form.getTextField('Text Field 49');

        nameField.setText('My Test');
        nameField2.setText('My Test1234');

What actually happened?
I receive the following error

What did you expect to happen?
I expected it to find and fill the field with the text provided
How can we reproduce the issue?
I can provide the document privately if needed
Version
Latest
What environment are you running pdf-lib in?
Browser
Checklist

[X] My report includes a Short, Self Contained, Correct (Compilable) Example.
[X] I have attached all PDFs, images, and other files needed to run my SSCCE.

Additional Notes
No response

For any others that hit something similar, the name and Id tags were not resolving in my case.  I ran the following code to get a list of fields and save them in the form so I could reference them...kind of like a mapping.  Then I was able to see what pdf-lib saw the fields as:
https://pdf-lib.js.org/docs/api/classes/pdfform#getfields
const pdfDoc = await PDFLib.PDFDocument.load(pdfBytes);
        const mergedPdf = await PDFLib.PDFDocument.create();

        const form = pdfDoc.getForm()
        const fields = form.getFields()
        var i = 0;
        fields.forEach(field => {
            const type = field.constructor.name
            const name = field.getName()
            const inputField = form.getTextField(name);
            inputField.setText(i.toString());
            console.log(`${type}: ${name}`)
            console.log(i);
            i++;
        })

const mergedPdfFile = await mergedPdf.save();
this.saveByteArray("My PDF", mergedPdfFile);


Need a development & production branch

why is that ? You can develop on your fork and send pr's , We just need a master and a release branch

Our app is too simple for having a canary and development branch. I don't see how having a staging branch will prevent your use case.

Yep, we will definitely not use the master branch as the main production branch. Our plan is to use a release branch for production purposes, so that contributors don't have to switch to development branch and keep track of the branch while submitting pull requests. I hope this clears the doubt? Do share your point of view though.

@Rohanhacker as i explained the new feature X may break things on different env, that the contributor would not necessarily catch.Dev branch may break while the master(STABLE) would still work without that feature.

Mods! where are we hosting the app? how will people access the landing page?
Would it be gh-pages?
If yes, what branch does gh-pages use for deployment?
Is it master alone? or can you use another branch?

Our plan is to develop a prototype with minimal functionalities and full PWA. Focusing now on production, since we are just starting, seems too early. Lets first focus on making a basic working app. Please do feel free to share your opinions here.

gh-pages typically resides in gh-pages branch itself. Though we are still discussing how to proceed with the deployment. If you gave any suggestion, feel free to start a new thread and we can discuss this there :)

@skyshader  If I may, I thing github changed that feature long back. Only master is the branch github uses to deploy the app as of 2017. correct me if Iam mistaken.
Hence, the need for a prototype branch, so that master always is functional

We have a backend so we can not deploy on gh-pages. We can use something like heroku for backend and gh-pages for frontend

I Just have one last point to make. Handling Contributions and handling branches (one dev and one deployment ideally not a branch more , not a branch less)  would be headache free and time efficient
If we could decide on how the app is presented to the world.
And identifying which branch is which, depends on how we host the app.
And that is an initial pre contribution consideration which If the moderators can decide now, can lead to a chaos free deployment and development of the prototype.
I assumed it might be a github hosted app, but If you guys have anything else in mind, do consider firmly categorising branches based on how the app is made available.
Arbitrary assumptions of identifying a development branch, could lead to utter discomfort for the deployment team at a later date

@retrocausal I totally understand your point. And, that's the reason we are thinking of creating a release branch which will be stable always and will be used for deployment purposes.
Though I'd like to hear what other mod's thoughts are on this. @twishasaraiya what's your take on:

master and release
dev and master

IMO, keeping master as production makes more sense but considering master is the default branch and during submitting a pull request and cloning the repository, there are a high chances the contributors have to change the branch everytime and might forget to do so sometimes. Do we have any way to change the default branch of a repository (I think we don't have the permission for that)?.
But if we go with master and release branch approach, it would be on us to as to when to merge with release. The contributors as usual will work with master and submit PRs there.
@retrocausal your thoughts are appreciated as well. Please chip in. :)

So, Per me, the names you have mentioned are not an issue. we can name the branches however we wish to.
What I wondered was,
Suppose we have two branches
branch 1 and master
If we use gh-pages , when we deploy, github would automatically choose the master as the deployable branch.
I am guessing
https://Udacitymobilewebscholarship.github.io/guess-quote/
would then be the landing page.
In the above scenario, we do not have any option but to make branch-1 the production branch, and master the deployable /release branch.
However, If we choose to host it elsewhere,
say a digital ocean droplet / GCP / anywhere else,
then, the branch master, can be the production branch, and release / whatever name we choose, can be the deployment branch.
I am guessing in this scenario, the landing page would be up to us. We would need to have a custom domain?
All we would need to do, is log in with suitable permissions, and do a
git checkout <release-branch-name> on the server

@skyshader I think we should go with dev and mater branch. We should keep master as the production-ready branch and we could do our feature development on dev branch. Also, it would make it easier to deploy on GitHub Pages.

@retrocausal The name is not the concern for me as well.. However the default branch is.
Btw it makes sense to keep master stable and a dev branch for contributions. Let's finalize this. Later, we can branch out from master into release if required.
@twishasaraiya we also need to update the Contribution docs accordingly.

Okay @skyshader, I will update the contribution docs. Are we keeping the name of the development branch as dev or something else?

@twishasaraiya what do you suggest? You can create dev or development branch and update that in docs. Let me know if you want me to create the branch and also your preferred name.

I'm really confused with the situation now. We are supposed to be adding new features in develop right? But right now I see the pull requests that are opened are for the master branch...


[FEATURE REQ] Add more logs about ServiceBusProcessorClient restarting

Is your feature request related to a problem? Please describe.
When the ServiceBusProcessorClient starts, a scheduled task will monitor the asyncClient's connectivity and try to restart the client when the connection is lost. But there's no log info about whether the client is being restarted or not. Should we add some log info about this behavior? If we have such information, we could infer whether the restart is working as expected from the log.
Describe the solution you'd like
Add more logs about processor restarting.
Describe alternatives you've considered
N/A
Additional context
We ran into issues when the processor client stopped consuming messages. We ended with restarting the application every one hour. It's hard to tell whether the daemon thread to restart the client is working.
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Description Added
[x] Expected solution specified

@saragluna: Today when the restart code is called - there should be a log line that prints "Removing receiver links." as part of the client close() call.  This is the only place where this message would come from. I agree, it is not obvious form the log that the client is undergoing a restart though.
We are redo-ing the log verbosity as unique work track as part of the next cycle. We should reconsider this in that scope as well.

Closing this issue out as we are tracking updates in #20836. Please feel free to reopen if necessary


numbers only branch ref not handled

If a branch ref looks like a PR ref and there's no PR ref it should fallback to the branch ref
e.g
https://use.docs.page/~123

This is working as expected now.


ArrayDisplay has some redundant code

Describe the bug
Calling ArrayDisplay.set_vector_hillas() requires a dict of hillas parameter containers, but doesn't actually use them anywhere... Instead the CoreParametersContainer is the only thing actually used.
Also  it is missing a lot of convenience functions related to coordinate transforms, like the ability to add points correctly similar to CameraDisplay.
To Reproduce
inspection

I'll try to open a PR to clean up  ArrayDisplay soon.   If there are features you think are useful, list them here


Don't attempt calling JavaScript interop during prerendering/static rendering

Bug type
Other
Component name
No response
What happened?
Using .NET 8 preview 5, The following exception occurs during prerendering:
fail: Microsoft.AspNetCore.Server.Kestrel[13]
      Connection id "0HMRSDOJDF8PM", Request id "0HMRSDOJDF8PM:00000001": An unhandled exception was thrown by the application.
      System.InvalidOperationException: JavaScript interop calls cannot be issued during server-side static rendering, because the page has not yet loaded in the browser. Statically-rendered components must wrap any JavaScript interop calls in conditional logic to ensure those interop calls are not attempted during static rendering.
         at Microsoft.AspNetCore.Components.Endpoints.UnsupportedJavaScriptRuntime.Microsoft.JSInterop.IJSRuntime.InvokeAsync[TValue](String identifier, Object[] args)
         at Microsoft.JSInterop.JSRuntimeExtensions.InvokeVoidAsync(IJSRuntime jsRuntime, String identifier, Object[] args)
         at MudBlazor.IIJSRuntimeExtentions.InvokeVoidAsyncIgnoreErrors(IJSRuntime jsRuntime, String identifier, Object[] args)
         at Microsoft.AspNetCore.Components.RenderTree.Renderer.<>c__DisplayClass81_0.<<Dispose>g__HandleAsyncExceptions|1>d.MoveNext()
      --- End of stack trace from previous location ---
         at Microsoft.AspNetCore.Components.RenderTree.Renderer.<>c__DisplayClass81_0.<<Dispose>g__HandleAsyncExceptions|1>d.MoveNext()
      --- End of stack trace from previous location ---
         at Microsoft.AspNetCore.Components.RenderTree.Renderer.DisposeAsync()
         at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngineScope.<DisposeAsync>g__Await|22_0(Int32 i, ValueTask vt, List`1 toDispose)
         at Microsoft.AspNetCore.Http.Features.RequestServicesFeature.<DisposeAsync>g__Awaited|9_0(RequestServicesFeature servicesFeature, ValueTask vt)
         at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.<FireOnCompleted>g__ProcessEvents|242_0(HttpProtocol protocol, Stack`1 events)

In IIJSRuntimeExtensions, the various methods try ignoring the errors thrown during JS interop, with special cases for handling server side rendering scenarios, like:
catch (InvalidOperationException ex) when (ex.Message.Contains("prerender", StringComparison.InvariantCultureIgnoreCase))
{
    return false;
}

It seems the error message has changed in .NET 8, resulting in the error not being caught at all in certain cases, which gets surfaced to the user as well and results in undesired behavior.
However, as is indicated by the message as well, this is not the intended way in supporting interop, and the current way for checking is error-prone as well (it can also silently suppress unintended, user thrown exceptions that contain the word "prerender").
Although not visible from the stacktrace, the exception originates from MudOverlay.DisposeAsync referenced from a MudDrawer instance.
Expected behavior
Calling JavaScript on server side during static rendering or prerendering should be avoided altogether. Materializing exceptions instead of doing a prerequisite check is more expensive.
Calls should be instead wrapped in conditional logic, if at all possible. Unfortunately, the concrete type that could be checked for is at the moment internal (UnsupportedJavaScriptRuntime).
Maybe the problem should be delegated to the Blazor or .NET Runtime teams as well, because there should be a check available at runtime that doesn't involve hacking the message or the type to check if a viable JavaScript runtime is available at all.
A very easy fix would be to check for some other message, but that would still be problematic for the above reasons.
Reproduction link
https://github.com/yugabe/MudJSInteropExceptionHandling
Reproduction steps

New Blazor Hosted WASM project
Enable prerendering as per Prerender and integrate ASP.NET Core Razor components | Microsoft Learn
Add MudBlazor support as per Installation - MudBlazor
Add wireframe content named "Drawer left + top appbar" from Wireframes - MudBlazor

Upon starting the project, the exception appears on the server side logs.
Relevant log output
fail: Microsoft.AspNetCore.Server.Kestrel[13]
      Connection id "0HMRSJ6APDHSH", Request id "0HMRSJ6APDHSH:00000001": An unhandled exception was thrown by the application.
      System.InvalidOperationException: JavaScript interop calls cannot be issued during server-side static rendering, because the page has not yet loaded in the browser. Statically-rendered components must wrap any JavaScript interop calls in conditional logic to ensure those interop calls are not attempted during static rendering.
         at Microsoft.AspNetCore.Components.Endpoints.UnsupportedJavaScriptRuntime.Microsoft.JSInterop.IJSRuntime.InvokeAsync[TValue](String identifier, Object[] args)
         at Microsoft.JSInterop.JSRuntimeExtensions.InvokeVoidAsync(IJSRuntime jsRuntime, String identifier, Object[] args)
         at MudBlazor.IIJSRuntimeExtentions.InvokeVoidAsyncIgnoreErrors(IJSRuntime jsRuntime, String identifier, Object[] args)
         at Microsoft.AspNetCore.Components.RenderTree.Renderer.<>c__DisplayClass81_0.<<Dispose>g__HandleAsyncExceptions|1>d.MoveNext()
      --- End of stack trace from previous location ---
         at Microsoft.AspNetCore.Components.RenderTree.Renderer.<>c__DisplayClass81_0.<<Dispose>g__HandleAsyncExceptions|1>d.MoveNext()
      --- End of stack trace from previous location ---
         at Microsoft.AspNetCore.Components.RenderTree.Renderer.DisposeAsync()
         at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngineScope.<DisposeAsync>g__Await|22_0(Int32 i, ValueTask vt, List`1 toDispose)
         at Microsoft.AspNetCore.Http.Features.RequestServicesFeature.<DisposeAsync>g__Awaited|9_0(RequestServicesFeature servicesFeature, ValueTask vt)
         at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.<FireOnCompleted>g__ProcessEvents|242_0(HttpProtocol protocol, Stack`1 events)

Version (bug)
6.6.0
Version (working)
No response
What browsers are you seeing the problem on?
Other
On what operating system are you experiencing the issue?
Other
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hello,
Firstly, I would kindly request that you follow the proper initialization process for MudBlazor as outlined in the guide available at: MudBlazor Installation Guide.
Currently, I notice that you have only added AddMudServices and MudDrawer in the App.razor file. However, it is crucial to include additional components and resources for MudBlazor to function correctly. Specifically, you need to add the JavaScript file _content/MudBlazor/MudBlazor.min.js, CSS stylesheets, and the following components in the MainLayout.razor file:
<MudThemeProvider/>
<MudDialogProvider/>
<MudSnackbarProvider/>

These components are important for MudDrawer. I would also highly recommend including MudDrawer in the MainLayout instead of App.

Hi @ScarletKuro. Thanks, but I intentionally only made the relevant changes required to reproduce the error. MudDrawer isn't required, nor is it directly related to the issue, it's just the simplest way to make the exception appear. You could simply call the extension method directly from wherever I outlined on server side to see the error as well.

I guess I understand what you are trying to say, but currently, I don't think we are going to address this issue. We mainly wait the final release of .NET 8 before taking any action. Also the current .NET 8 requires to use a preview version of Visual Studio. Furthermore, we have plans to explicitly include .NET 8 in the next major version, where it will receive official support.

I understand, I was just attempting to upgrade a rather large project to .NET 8 myself to see if anything would break (as it did). This is maybe more of a heads-up to consider. This triggered I had to dive deeper to see what was wrong, and the current solution is demonstrably not future-proof.

I guess my main idea would be to add to MudComponentBase something like this:
protected bool IsJsInteropAvailable { get; private set; }

protected override void OnAfterRender(bool firstRender)
{
	base.OnAfterRender(firstRender);
	if (firstRender)
	{
		IsJsInteropAvailable = true;
	}
}

and then in components add a condition:
public async ValueTask DisposeAsync()
{
	if (IsJsInteropAvailable)
	{
		await UnblockScrollAsync();
	}
}

Since we DO need sometimes to call JS during Dispose for a proper cleanup like for components that use popoverservice, browser size change lister etc we need to unsubscribe which involved JS, we can't use JS only in OnAfterRenderAsync.

Yes, I don't question it is needed to sometimes do custom cleanup on disposing. Also, I'm not sure how you usually feel about breaking changes but modifying the API surface of MudBlazor.IIJSRuntimeExtentions could technically be a breaking change, as the methods defined there are public and consumers/users might have depended on them.
Unfortunately, I believe the approach you outlined above won't work as intended, or have major drawbacks for a few reasons:

The user cannot be expected to call base.OnAfterRender(firstRender) when overriding OnAfterRender; and failing to do so will, in cases, result in critical JavaScript not silently running at all (like in you example, DisposeAsync).
It would be great if one could use the same approach in services as well. The original issue stems exactly because MudBlazor.IIJSRuntimeExtentions.InvokeVoidAsyncIgnoreErrors is static and can be called from wherever in the codebase.
Technically it is not invalid to call into JavaScript from other places than OnAfterRender, but that is currently the only place I know is recommended. However, calling into JS from say, an OnInitialized is all good and well if you are in a browser. In my project, I use a globally defined guard I can access from anywhere in the codebase to check if interop is available at all. This is not viable for MudBlazor however, because you support Blazor Server as well.[SupportedOSPlatformGuard("browser")]
public static bool IsBrowser { get; } = OperatingSystem.IsBrowser();
[UnsupportedOSPlatformGuard("browser")]
public static bool IsServer { get; } = !OperatingSystem.IsBrowser();

In the .NET codebase it's not so straightforward either to check as far as I know. In WASM you simply call WebAssemblyHostBuilder.CreateDefault and that doesn't do any checks either. I think the IJSRuntime interface itself should define a property IsJSSupported, or similar. But that would be a request to the .NET team. The only IJSRuntime implementations that are "fake" that I know of are internal:

Microsoft.AspNetCore.Components.Endpoints.UnsupportedJavaScriptRuntime in .NET 8,
Microsoft.AspNetCore.Mvc.ViewFeatures.UnsupportedJavaScriptRuntime in .NET 7 (I haven't checked .NET 6 and earlier, but probably the same).

All that said, I believe an architecturally viable and "correct" way would be to obsolete/deprecate the extensions class and update usages throughout the codebase to the approach you outlined above, but not in MudComponentBase. I'm not sure swallowing the exceptions are especially beneficial, because as far as I know, neither of those cases should happen in normal operation, but you probably know about this more than I do.
An easier, not bulletproof and way more hacky way would be to just add to the extensions a check at the beginning:
if (jsRuntime.GetType().Name is "UnsupportedJavaScriptRuntime")
    return;

The user cannot be expected to call base.OnAfterRender(firstRender) when overriding OnAfterRender; and failing to do so will, in cases, result in critical JavaScript not silently running at all (like in you example, DisposeAsync).

In most cases, users do not need to utilize MudComponentBase for their custom components. However, if they do choose to inherit from the MudComponentBase or Mud Component for specific reasons, it is expected that they call the base method. Failing to do so would be considered as user code mistake. Currently, we already override OnAfterRenderAsync in numerous components, and moving forward, we plan to override OnParametersSet and SetParameters as well, to remove logic from getters and setters in components parameters.

Technically it is not invalid to call into JavaScript from other places than OnAfterRender.

The Microsoft documentation or aspnetcore repository does not explicitly state that calling JavaScript from places other than OnAfterRender is invalid. It rather emphasizes that OnAfterRender is the recommended and safest location for such calls. The documentation states:
"The OnAfterRender{Async} lifecycle event isn't called during the prerendering process on the server. Override the OnAfterRender{Async} method to delay JS interop calls until after the component is rendered and interactive on the client after prerendering."
This implies that when OnAfterRender is fired, it is reasonable to assume that the browser is connected, meaning that when Dispose is called next time after OnAfterRender it is safe to call JS. The error message suggests using "conditional logic to ensure those interop calls are not attempted during static rendering," which aligns with the code I provided above.

services as well

Most of our services are initialized during OnAfterRender, we just need to add condition for dispose. If users decide to use our services independently and employ the prerender functionality, it becomes their responsibility to ensure proper usage.

I use a globally defined guard I can access from anywhere in the codebase to check if interop is available at all. This is not viable for MudBlazor however, because you support Blazor Server as well.

As you mentioned it's not viable for us. Unfortunately, the framework does not provide a mechanism to determine the availability of JS interop. Although early proposals on GitHub suggested incorporating this feature at either on the JSRuntime or Components level, but it was not implemented in the final version.
I have seen other creative ways how people solve it, but it's all workarounds.

However, calling into JS from say, an OnInitialized is all good and well if you are in a browser

Well, it's not safe. The key point is "if you are in the browser." Based on my understanding, in prerender mode, the event will fire twice—once before OnAfterRender and once after the browser is connected. This behavior has been observed and documented on Stack Overflow, GitHub, and MS documentation. Therefore, it is still necessary to include a conditional statement, similar to the one I proposed earlier.

Thanks for engaging and elaborating. In general, your view is the same as mine, maybe I couldn't clearly formulate my views, but you elaborated on them as I could have. Some points I'd mention though.

if they do choose to inherit from the MudComponentBase or Mud Component for specific reasons, it is expected that they call the base method

I disagree on this point. In .NET in general, when a library defines a virtual or abstract member, the library author defines whether you have to or not call the base implementation. In this case, OnAfterRender is defined by the Blazor base class library, not MudBlazor. A special case is overridable methods that start with On, which suggest event hooks. The base class implementation in these cases are generally empty. Doing work in mid-hierarchy is unintuitive. Even if you say it's a user error to not call the base, the problem is that there will be no immediate effects at all: the problem will only happen in certain edge cases, like when certain components' event handlers don't get unregistered. Putting this logic into MudComponentBase is very error-prone. However, this could still be okay regardless.

services as well
If users decide to use our services independently and employ the prerender functionality, it becomes their responsibility to ensure proper usage.

I was talking about custom user services that can currently depend on the functionality of MudBlazor.IIJSRuntimeExtentions, because it is currently public (and making it anything else would be a breaking change).
Also on this point, the issue I opened is exactly because MudBlazor throws an exception currently in certain cases when using prerendering - in "normal" operation, so it's not possible to prevent it without hacks.
I'm going to mention this in a new issue in aspnetcore because I believe checking for if any sort of (non-fake/stub) JavaScript runtime is available should be in the framework.

I disagree on this point. In .NET in general, when a library defines a virtual or abstract member, the library author defines whether you have to or not call the base implementation. In this case, OnAfterRender is defined by the Blazor base class library, not MudBlazor. A special case is overridable methods that start with On, which suggest event hooks. The base class implementation in these cases are generally empty. Doing work in mid-hierarchy is unintuitive.

If developers choose to inherit our MudComponentBase, they should expect that we have implemented certain shared logic within it inluding the logic in OnAfterRender, OnParametersSet etc to eliminates the need for repetitive copying and pasting of code in each individual component. If they don't want any unexpected side effects, they are free to use the "naked" `ComponentBase".
For instance, take Raidzen's RadzenComponent, which serves a similar purpose as our MudComponentBase. Raidzen also incorporates custom logic in their OnAfterRenderAsync and SetParametersAsync methods. Interestingly, they employ the same technique with IsJSRuntimeAvailable that I previously offered. I hadn't delved deeply into their library prior to this so I had no idea they have it, but this similarity in the idea suggests that we are on the right track, considering that Raidzen is a well-established and mature library.

I agree, I wasn't trying to be overly critical of the idea, just something to consider. I hope there will be a solution in the framework that would let this work elegantly and efficiently, and even though I think it would be an easy feature to implement as I outline it in https://github.com/dotnet/aspnetcore/issues/49225, it possibly would only appear in .NET 8 the earliest. That would still require multitargeting and compile time conditional checking (and not be backported). So a forward-facing solution like the one you described seems pretty good.


Update Pages “home”

Automatically generated by Netlify CMS

👷 Deploy Preview for parsimony-dev processing.
🔨 Explore the source changes: f569402abd7156f8c332fa876c2e5cff790c75d1
🔍 Inspect the deploy log: https://app.netlify.com/sites/parsimony-dev/deploys/6190beac3fa2290007cc16e4


Zend\Db\Adapter\Driver\Pdo\Connection Transaction errors

Class Zend\Db\Adapter\Driver\Pdo\Connection not have the method inTransaction()
The metod beginTransaction() have a error. This code is not correct:

public function beginTransaction()
{
    if (!$this->isConnected()) {
        $this->connect();
    }
    $this->resource->beginTransaction();
    $this->inTransaction = true; // FIXME: error!
    return $this;
}

If the developer uses MyISAM, this code does not cause an error. The method PDO::beginTransaction() returns 'true' if transaction successful started and 'false' on failure. The code should look like this:
public function beginTransaction()
{
    if (!$this->isConnected()) {
        $this->connect();
    }
    $this->inTransaction = $this->resource->beginTransaction(); // @todo
    return $this;
}

This issue has been closed as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.html


[SPARK-22882][ML][TESTS] ML test for structured streaming: ml.classification

What changes were proposed in this pull request?
adding Structured Streaming tests for all Models/Transformers in spark.ml.classification
How was this patch tested?
N/A

Test build #85541 has started for PR 20121 at commit dbb04f6.

Test build #85541 has finished for PR 20121 at commit dbb04f6.

This patch fails to build.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class DecisionTreeClassifierSuite extends MLTest with DefaultReadWriteTest
class GBTClassifierSuite extends MLTest with DefaultReadWriteTest
class LinearSVCSuite extends MLTest with DefaultReadWriteTest
class LogisticRegressionSuite extends MLTest with DefaultReadWriteTest
class MultilayerPerceptronClassifierSuite extends MLTest with DefaultReadWriteTest
class NaiveBayesSuite extends MLTest with DefaultReadWriteTest
class OneVsRestSuite extends MLTest with DefaultReadWriteTest
class RandomForestClassifierSuite extends MLTest with DefaultReadWriteTest

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85541/
Test FAILed.

Test build #85543 has started for PR 20121 at commit daedd8b.

Test build #85543 has finished for PR 20121 at commit daedd8b.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class DecisionTreeClassifierSuite extends MLTest with DefaultReadWriteTest
class GBTClassifierSuite extends MLTest with DefaultReadWriteTest
class LinearSVCSuite extends MLTest with DefaultReadWriteTest
class LogisticRegressionSuite extends MLTest with DefaultReadWriteTest
class MultilayerPerceptronClassifierSuite extends MLTest with DefaultReadWriteTest
class NaiveBayesSuite extends MLTest with DefaultReadWriteTest
class OneVsRestSuite extends MLTest with DefaultReadWriteTest
class RandomForestClassifierSuite extends MLTest with DefaultReadWriteTest

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85543/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/853/
Test PASSed.

@smurakozi Address your comments. Thanks!

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1225/
Test PASSed.

Test build #87884 has started for PR 20121 at commit 6d59c5b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87884/
Test PASSed.

LGTM
Merging with master and branch-2.3
Thanks!


Added new component for social buttons

PR Title

The purpose of this Pull Request is to fix #134
Description

How you solved
As discussed added new component in components folder and place it below Home Page Banner.
Screenshots

Checklist

[x] I have Made this contribution as per the CONTRIBUTING guide in this repo
[x] I have tested in local Environment.
[x] I have made the fix as per issue converstaion
[x] I have starred the repository ⭐

@javamultiplex ,
Can you please make social buttons to 2 rows each having 3 icons for mobile view alone (less than 900px)
Other than that everything looks perfect

Great work @javamultiplex , merging your changes
Please look at other issues too!


feat: adds the heading and hp view transitions

Depends on https://github.com/Roma-JS/roma-js-on-astro/pull/49
Having fun adding more view transitions 😄
Changes:

Added a view transition on the page title
Added a view transition when switching from it/en on the homepage

Core implementation in https://github.com/Roma-JS/roma-js-on-astro/pull/54/commits/9d7fe56b30f3e2710df5e5905b67989132c7bb4e

While testing I've found out that is too much and the view transition becomes slower

While testing I've found out that is too much and the view transition becomes slower

Let's verify if the issue still occurs in 8 months a year, the chrome implementation of this spec will definitely improve.


dblClickEdit.plugin.js not working anymore

i loved how i could just dubbelclick on something to edit it, but that is not working anymore.
is it just for me or do others have this problem to?

Still working for me.

in the last couple days i tryed it on fresh installed discord(with betterdiscord and that enabled of cours), on canary and on PTB
none work for me, what could be the problem?


Confounding variables affecting our main covariate?

@tung_patrick, @mru4913:
Hey, the new proposal draft looks good!
Question: is there a reason that we are talking about our confounding variables affecting our main covariate?  For example: “mathematical abilities may affect their level of programming experience”, and “if a MDS student has friends or family who work for IT companies, they are more likely to be affected and tend to have programming experience before the program”.
I think that for confounding variables, we would only be interested in their effect on our dependent variable (difficulty) that is not already captured by our main covariate (programming experience).  Does that make sense, or am I not understanding things correctly?

I think the whole point of confounding variables is that is affects both the dependent and independent variables.

Very good question!! Correct me if I am wrong.
For condounding variables, it is a common cause for of both independent variable and dependent variable.

Thanks, I overlooked that.  I'll make sure the proposal aligns with this.


should ignore device files

I guess no one has actually attempted to take a fingerprint of a full system! But we'll want to ignore unusual file types like those in /dev:
/usr/local/Cellar/ruby/2.4.1_2/lib/ruby/2.4.0/find.rb:51:in `lstat': Bad file descriptor @ rb_file_s_lstat - /dev/fd/8 (Errno::EBADF)

And since there's no documented way to exclude files or file trees, I don't have a simple workaround either.

What would make the most sense?

I've always only taken a fingerprint of specific directories, e.g. /etc or /srv or specific directories that are being backed up - so you are right no one has tried to fingerprint / :D

Yeah, I have been fighting a really strange issue that feels like an operating system bug. It doesn't present immediately after a clean wipe and re-install, nor immediately after I run my normal install scripts. But it remains when I remove all the things my install scripts are supposed in put in place. Crucially, it definitely isn't in any places a Reasonable Person would fingerprint: $HOME, /usr/local, /opt.  So I'm literally trying to debug this issue by comparing the entire file system!
I think an "exclude directory" setting is probably the least obnoxious thing to maintain, especially across platforms. I'm hoping that looks like just exposing Build::Files::Path#rm.

Fingerprint was never designed to handle exclusion directories unfortunately, simply because it was always designed to fingerprint a specific directory completely. If you don't when you analyse it, it will mention that there are files which appear to be added.
Probably what makes the most sense is for fingerprint to actually handle device files correctly.
I'm not sure exactly what this should look like, but it probably wouldn't be too complicated.


applyFilter method in yii.gridView.js cuts off all vars with the same name and left only the last in order

As I described in #10284 I have faced an important issue that brokes url upon filtering grid view. This PR brings fix to this issue. Description of the bug:
My url:
http://domain.com/product/index?ProductSearch%5Bname%5D=test&page=1&per-page=2&sel%5B%5D=8&sel%5B%5D=9&sel%5B%5D=10
After it filtered with applyFilter method of yii.gridView.js it lost all sel vars except last one and becomes like:
http://domain.com/product/index?ProductSearch%5Bname%5D=test&page=1&per-page=2&sel%5B%5D=10
So filtering cuts all vars with the same name and left only the last in order.
This happens due to getQueryParams method in yii.js. Here is the result of console.log(yii.getQueryParams(settings.filterUrl)); in applyFilter method:
{
    ProductSearch[name]: "test",
    page: "1",
    per-page: "2",
    sel[]: "10"
}

As you can see yii.getQueryParams didn't respect multiple veriables with the same name. With the PR yii.getQueryParams returns now object like:
{
    ProductSearch[name]: "test",
    page: "1",
    per-page: "2",
    sel[]: [
        "8",
        "9",
        "10"
    ]
}

?name=alex&name=jack => { name: ['alex', 'jack'] }
It's not a valid behavior, since it will be encoded back to ?name[]=alex&name[]=jack, which is inconsistent.

Which case do you mean?
If you are talking about something like $.param({name: ['alex', 'jack'] }) - yes, it encodes back to name%5B%5D=alex&name%5B%5D=jack. But this is not a problem of implementation of yii.getQueryParams, you will get the same result using $.deparam plugin as I suggested in #10284, or any other. I am not sure is this a problem in fact, one should pass correct query params to get correct result, isn't it?

Well, agree.

Merged https://github.com/yiisoft/yii2/commit/b6b2befb00145e693935b4a523c854168d53c976

Thank you!


1,3,5-Triphenylcyclohexane (CHEBI:79936)

Please annotate 1,3,5-Triphenylcyclohexane (CHEBI:79936)
CAS 17342-60-8
https://chem.nlm.nih.gov/chemidplus/rn/17342-60-8
It has stereochemistry undefined.
There are two geometrical isomers which I'd appreciate to be added to ChEBI:
cis,trans-1,3,5-triphenylcyclohexane (CAS 28336-57-4, https://chem.nlm.nih.gov/chemidplus/rn/28336-57-4) is a 1,3,5-triphenylcyclohexane (CHEBI:79936)
cis,cis-1,3,5-triphenylcyclohexane (CAS 234079-32-4, https://chem.nlm.nih.gov/chemidplus/rn/234079-32-4) is a 1,3,5-triphenylcyclohexane (CHEBI:79936)

now added. thanks


Code Clean Up-PI 6

Context

Only for UI Work
[ ] Increase code coverage to at least 70%
[ ] Clean Up Unnecessary Commented Code
[ ] Remove Unused Import Statements
[ ] Remove unused functions from the redux action for filter criteria
[ ] Remove unused components
[ ] Clean up console warning messages (ex. warning messages on the custom data download)

Modified multiselect combo-box component to break iteration when the component is no longer mounted. Modified tooltip component to clear timeout and not display tooltip information when component is no longer mounted. Deleted the selectable card component and its styling since they are no longer used. Added tests to the manage data download component and the filter criteria menu component  to improve test coverage. Modified filter criteria test to reflect changes to the code. Changed default state for datatype and day subtype to empty strings instead of null since the datatype for those states are always strings.


500 Second GetTimeAsTicks Wrap

For the nrf52840 board, the gettimeasticks function timer wraps at ~511 seconds.
Sampling getimeasticks every second yields the following:
Time: 509s
Time: 510s
Time: 511s
Time: 0s
Time: 1s
Time: 2s

(@atar13 and @Samir-Rashid have found this to not be a bug, but expected behavior given the nrf52x rtc implementation -- further discussion to be posted by them as an issue in the main Tock repo).
The inconvenience of gettimeasticks wrapping can be resolved through additional logic, but a timer wrapping every 511 seconds seems somewhat cumbersome.

I'm guessing from https://github.com/tock/tock/issues/3938 that this is a kernel issue. This issue should be closed

Just to be clear. Are you saying that in userspace (libtock-c) the time in seconds is wrapping or the ticks return from the kernel are wrapping?

We verified the ticks being returned from the kernel were wrapping by printing out the value every second. So yes, this concerns the implementation in the kernel.


Added deleteDeprecated in ElasticView

From nexus-kg created by umbreak : BlueBrain/nexus-kg#541
deleteDeprecated: Boolean could be an interesting field to add to the ElasticView.
This will delete a Document from ElasticSearch whenever the latest version of the resource in the platform is deprecated

Requested by @kenjinp


Fix PolyUtil distanceToLine function. Close #11

Now, test from googlemaps/android-maps-utils library is passed successfully

Thank you @gistrec !


Update location of Lighthouse "Open in Viewer"

@dandv - would you mind fixing the build errors please?
https://travis-ci.org/google/WebFundamentals/builds/202843542

"always leave the code behind in a better state than you found it"


Long Standing Issue: Add Data to Existing Categories

Long Standing Issue: Add values to the existing qual-id categories
Note: Any number of people can work on this issue, so it will remain open and won't be assigned. If you'd like to comment with what category you're going to work on, that would be helpful to stop people doing the same thing.
This involves adding strings to a list in a python class. It will be a very simple, yet impactful enhancement.
Contributions from beginners are very welcome!

HI, I'd like to work on this for Hacktoberfest 😃

Hi, I'd like to contribute to it

Hey @gabrielbarker, I would like to contribute on this, can you please assign this to me?

Hey @gabrielbarker, I would like to contribute on this, can you please assign this to me?

@chouhanaryan @tanya4067 @mephi007
I've updated the issue description to say that basically this issue will never be 'closed', and so all of you are encouraged to contribute. I won't assign anyone to this so as not to discourage others
Thank you guys for being interested in this, I can't wait to see what you contribute!
Also if you have any suggestions on a better way to manage this project then I'm all ears

hey @gabrielbarker raised PR #7 for issue #2.

Hey @gabrielbarker, this is my first Hackathon and I was wondering if I could contribute to this issue ?

Closing this issue and reopening with a clone so that people can continue to find this repo during Hacktoberfest


fix(kafkajs): update docs

:tada: This PR is included in version 1.23.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


wasm?

Could this potentially be compiled to WebAssembly? This would allow full interop with the existing Babel packages, and would truly thrust this project into the spotlight.

You may want to check out https://github.com/swc-project/swc/issues/87

@kdy1 Continuing https://github.com/swc-project/swc/issues/87#issuecomment-563009276... So what are those cfgs to build a wasm binary? I've tried to build only the Parser for WASM and got this error I am not sure if it relates to SWC or to Rust. Do you have any clues?

@anurbol

So what are those cfgs to build a wasm binary?
#[cfg] should be placed on some structs in swc_common. Other codes do not use os-specific features.

got this error I am not sure if it relates to SWC or to Rust. Do you have any clues?
I think it's rustc's bug related to wasm target. I'm not sure about the way to fix it.

@kdy1 Hey, I've managed to compile the Parser (nothing more) with --target wasm32-unknown-unknown! It turns out that dependency renaming is broken for the Wasm target. Therefore I did this...
In ecmascript\parser\Cargo.toml
Changed this:
ast = { package = "swc_ecma_ast", version = "0.10.0", path ="../ast" }
parser_macros = { package = "swc_ecma_parser_macros", version = "0.4", path ="./macros" }

...to this...
swc_ecma_ast = { version = "0.10.0", path ="../ast" }
swc_ecma_parser_macros = { package = "swc_ecma_parser_macros", version = "0.4", path ="./macros" }

...and minor things, including replacements throughout the swc_ecma_parser crate.
Is it OK? Are the new names OK? Can I make a pull request?
BTW this project is incredible, I am your fan, are you even a human? Because humans can't do such amount of work 😄

@anurbol I'll be happy with a such PR. Thank you for the interest on swc!

Hey people, SWC Parser can be built for Wasm! If someone needs, I think, you could make the whole SWC project Wasm-compatible easy enough. So when you build for Wasm you'd likely see the inconsistent resolution for an import error. To fix that, you should get rid of dependency renaming in Cargo.toml files across the whole SWC project. Example is here

Came here to further express my interest in a wasm release. If the performance is roughly similar, then I believe going wasm would be a tremendous boost to the reach and usage of swc because it suddenly works on every modern browser, every modern version of node and on every operating system that v8 supports - without needing to configure a build system or pre-building binaries.
Personally, I think a great way to continue the discussion would be for @anurbol to contribute his work as a PR and then discuss the feasibility of the changes and measure the performance impact. Happy to help out!

@alubbe I have already contributed a very simple PR that restored Wasm support for SWC Parser. Yes, SWC is WASM-ready, mostly, just some configuration files should be fixed. Regarding performance impact, in my case WASM was 2 to 3 times slower than native binary, but still this is like x50 times faster than JS.

Ah awesome, I hadn't seen that! So the next step would be a for a second PR to rename the dependencies and then possibly a third PR to introduce wasm building to the CI process, so that it doesn't get broken going forward?

@alubbe Yep, seems so! Currently I don't have time for this, but this is simple enough so if you have time you could try.

I've implemented transformSync and transformFileSync. It seems like wasm is 3 ~ 4 times slower than native binary.
Please tell me if is it ok. If it's ok, I'll implement other methods for wasm and make it fallback for the swc.
I uploaded the benchmark result at:: https://github.com/swc-project/swc/pull/691

Out of interest, could you include babel or other pure JS alternatives in your benchmark?

@alubbe I included babel, but I didn't benchmark tsc because it does much more work than swc. It will be very slow, but it's expected as it does much more work.
For the same reason, I didn't include sucrase because it cannot compile to es3 / es2015.

Ah you're right, it's at the end of the benchmark. So for es2015, the WASM version is around 4-5 times faster and the native one is around 9 times faster than babel, right?

@alubbe Oh. I made a mistake. es2015 in swc is equivalent with es5 because there's no es2015 -> es5 pass.
So the native version is 17 times faster than babel.

#691 Is merged. Closing. Please comment or file a new issue if it's not enough.


chore(demo): reduce server bundle size

I was surprised by 1.4 MB and it turned it includes "development", "legacy" etc... build from react.
todo

[x] minify?
[x]  exclude react ~legacy~, development build?
[x] node-fetch-native polyfill shouldn't be necessary?

esbuild metafile
Just loading it on https://esbuild.github.io/analyze/

before

after

This is obsolete after

https://github.com/hi-ogawa/vite-plugins/pull/28


Jitsi not in default App List / Not registering tel urls

I've installed the latest jitsi on Win 10 x64.

I noticed thats not possible to associate jitsi wirth tel links. It is not in the list of possible programs if you select tel in the setting "default apps".
I think most user would expect that jitsi is associated with tel urls during installation (but maybe this fails because of 1.)

Looks same as https://github.com/jitsi/jitsi/issues/252 but its not fixed for Win 10

has been fixed in #252, I have no idea why it doesn't show up four you. On a Windows 10 install here it looks like in the screenshot.

is not possible, Windows prevents changes to the default apps. The user must select it.

Found and fixed, i think.
according to this document https://docs.microsoft.com/en-us/windows/desktop/shell/default-programs
there must be two entries in the registry and one of them was missing:
HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\RegisteredApplications
Name: jitsi
Type: REG_SZ
Value: SOFTWARE\WOW6432Node\Jitsi\Capabilities
after adding this it showed up in the application list.

It might not work if you install 32bit Jitsi on Windows x64. But that combination is nonsense.

In stable build line on the webpage the link "Microsoft Windows installers" is linked to only an x86 version, thats why i thought there is only this one.

@damencho Can you please add an x64 link to the downloads page?

Should I change it to x64 only? Are there any x86 available around ... ?

Changed it to x64 and added a linkn to the 32bit one

Still needs to be done for the nightlies section, and what about the new download site https://jitsi.org/downloads/ (stable & nightly)?

Oh, I just edited old website, I will do it on the new. Nightlies there is no need to, as they are just links to the folder ....

Second round and should be fixed all now.

I just installed x86_64 jitsi today (jitsi-2.10.5550-x64.exe) on Win10 64 and this registry key was not created (had to manually add it)

I just installed x86_64 jitsi today (jitsi-2.10.5550-x64.exe) on Win10 64 and this registry key was not created (had to manually add it)

I also had to manually add the registry key mentioned above, in order to make jitsi show up in the "choose default app" dialog for "tel" links. (Jitsi 2.10.5550, Windows 11 64bit)
Now clicking a link to start a call works great! But I guess this issue should be reopened.

Just installed jitsi desktop newly per download on Win 10. Still had to repair registry according to th am instructions.


Distribute auth tokens to pods

Before allowing pods to make changes to the cluster state, we need to check their identity and verify that they're permitted to make changes.
An idea for checking identity: suppose we generate a token when a BoundPod is created. Kubelet passes this token into the pod via an ENV var. apiserver can then look up this token to verify identity.
Clearly there's some security implications; if the wrong actor is able to read the BoundPods endpoint, they could impersonate another pod.

What's left to do here, now that Secret is in?

I think with Jordan's latest change to allow keys and certs to be embedded in KUBECONFIG this is possible.  Further work should be tracked as part of automatic enablement via service accounts and token generation.

Current state:

we have a secrets resource.
we have a way to create "service accounts" at cluster startup, which is in use.
upcoming PRs by @liggitt will add a "service account" field to a pod and an automated way to create users, tokens, and to attach those to a pod's volumes based on that field.

Docs are a bit stale.
This is the closest thing we have.
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/docs/design/service_accounts.md
https://github.com/GoogleCloudPlatform/kubernetes/4126
Closing this issue, as I think it is no longer useful.


compile pulsar 2.5.0 meet a question

Failed to execute goal on project pulsar-io-flume: Could not resolve dependencies for project org.apache.pulsar:pulsar-io-flume:jar:2.5.0: Failed to collect dependencies at com.github.stefanbirkner:system-rules:jar:1.17.0 -> junit:junit-dep:jar:4.9.1-SNAPSHOT: Failed to read artifact descriptor for junit:junit-dep:jar:4.9.1-SNAPSHOT: Could not transfer artifact junit:junit-dep:pom:4.9.1-SNAPSHOT from/to mirrorId (http://repo1.maven.org/maven2/): Failed to transfer file http://repo1.maven.org/maven2/junit/junit-dep/4.9.1-SNAPSHOT/junit-dep-4.9.1-SNAPSHOT.pom with status code 501
someone met this question???

@chengchampion  Would you please try "mvn clean install -DskipTests"?

Closed as no response and 2.5.0 is end of life.


The manifests in the v2.4.0 release artifact reference the rc1 for calico-node and the docs.

Expected Behavior
The artifacts should reference/use the v2.4.0 versions.
Current Behavior
The manifests in the v2.4.0 release artifact reference the rc1 for calico-node and the docs.
Possible Solution
Either fix the artifact (which feels counter productive to the purpose of the artifact) or do a new release (v2.4.1) and ensure the artifact is correct.
Steps to Reproduce (for bugs)

Download Artifact
Extract contents
Look in manifests

Context
v2.4.0 release of projectalico/calio

Good spot - I've updated the release archive.
This was because the Makefile doesn't ensure a clean build, and the old artifacts were still laying around and thus got picked up in the build.

Thanks @bradbeam for pointing it out to me. :+1:


ImportError: Error loading 'src.models.sequence.dna_embedding.DNAEmbeddingModel':

When running the code as instructed (quick entry "python -m train wandb=null experiment=hg38/genomic_benchmark_scratch"), there was an error: "ImportError: Error loading 'src.models.sequence.dna_embedding.DNAEmbeddingModel':". Can you please look into it? Thanks!

Can you describe more details of your setup and steps?  What you described can be from many things.  eg, what environments and versions are you using?  If all else fails, try the Docker image.

Hi. The issue has been solved, after the re-installation of flash-attention. Thanks!


Tact v1.3.0 release checklist

[x] Improve the changelog for v1.3.0: grammar, wording, polishing (PR #281)
[ ] Make sure there are no open issues for the v1.3.0 milestone (except for the current one, of course)
[ ] Bump Tact version (see the analogous PR for v1.2.0: https://github.com/tact-lang/tact/pull/159)
[ ] Tag a new release in git
[ ] Create the new release on GitHub: https://github.com/tact-lang/tact/releases
[ ] Update tact-docs with the most recent Tact features
[ ] Publish the package on NPM
[ ] Request or perform the plugins/parsers/tools updates:

[ ] https://github.com/tact-lang/tact-vscode (+ a new release on the marketplace)
[ ] https://github.com/tact-lang/tact.vim
[ ] https://github.com/tact-lang/tree-sitter-tact
[ ] https://github.com/ton-blockchain/intellij-ton
[ ] https://github.com/tact-lang/tact-template
[ ] https://github.com/ton-org/blueprint, tracked in: https://github.com/ton-org/blueprint/pull/96
[ ] https://github.com/nujan-io/nujan-ide

[ ] TON Dev News Telegram channel announcement
[ ] Accumulate TON dev chats feedback

Added Nujan to that update list

Updated tact.vim and tree-sitter-tact to match Tact 1.3.0, except for the upcoming map traversing functionality #106

@0kenx published on NPM<EMAIL_ADDRESS>

❤❤❤❤

https://github.com/tact-lang/tact/issues/375 supersedes this now


Tokenizer's nb_words not taking effect when fit_on_texts is run

Hello, I can't figure out if I'm doing something wrong, but Tokenizer always seems to ignore the nb_words parameter I provide it and tokenize ALL words rather than just the top nb_words.
I'm running Python 2.7. Note that I ran into this issue while working on a dataset with over 1000 unique words, and any lower value I set for nb_words (e.g. 10, 100, 500..) was ignored.  Below is a simple example to illustrate quickly what I'm getting.   Thank you.
from keras.preprocessing.text import Tokenizer
tokenizer = Tokenizer(nb_words=10)
tokenizer.fit_on_texts(['apple book car dog egg fries girl ham inside jam knife leg monkey nod open pear question rough stone tree umbrella voice wax xylophone year zoo'])
print(len(tokenizer.word_index))
# comes out as 26 rather than 10

I have the same issue when fitting on char level

I have the same issue

Any solution to this?

Same question here! For word level.

I`m running Python 3.6 and keras with TensorFlow backend, have the same issue.

I'm also having this issue with Python 3.6 and TensorFlow. My Tokenizer looks like this:
tokenize = text.Tokenizer(num_words=5000,
                          lower=True, split=" ", char_level=False,
                          filters='!"#$%&()*+,-./:;<=>?@[\\]^_`{|}~\t\n')

It works, it just doesn't take into account the num_words param.

Same problem here. Any news on this issue?

I found this thread that explains how Tokenizer apparently correctly interprets num_words:
https://github.com/fchollet/keras/issues/7551

Is this behavior intended? If yes, it would be very useful to have a parameter to only get the word_index for the top nb_words

same issue...

@shafy To get the top nb_words, you can simply use index under nb_words, since the word_index is created by https://github.com/keras-team/keras/blob/018af47bc87b6a48e64c2fc9cfacf595e0f36287/keras/preprocessing/text.py#L191

@hsiaoyi0504 what do you mean by "under"?

@shafy I mean you can pass the word to word_index and check if the mapping index is under the nb_words. It's not a hard task. If the word_index dictionary is large enough, you may want generate a filtered version rather than doing this on the fly.


CHANGELOG updates

The Changelog of the most recent version (viya-ark 1.12 does not seem to have the latest updates.
Could they be added?

@AddeGroot , you are confusing https://github.com/sassoftware/viya-ark (Viya ARK for Viya 3.5) and this repo https://github.com/sassoftware/viya4-ark (Viya 4 ARK for Viya 4).   These are two different projects in github.  The https://github.com/sassoftware/viya-ark/blob/master/CHANGELOG.md is updated with changes for Viya35-ark-1.12.   There is not CHANGELOG file in viya4-ark (this repo).


Cannot read property '0' of undefined

Error in Shape Shifter
TypeError in /
Cannot read property '0' of undefined
View on Bugsnag
Stacktrace
webpack:///node_modules/polylabel/index.js:126 -

View full stacktrace
Created by Alex Lockwood via Bugsnag

An error linked to this issue has been marked as fixed in Bugsnag
TypeError in /


Update Set-CsTeamsCallingPolicy.md

Making the changes to the note for clarity.

@nitinjaitely Gentle reminder.

@nitinjaitely kindly implement the suggested changes, else we may proceed to close this PR. Thanks

@dariomws

@nitinjaitely Closing as it is same as #10460


@MarcPow you can do this with the JSON output and jq or some other tool that speaks JSON. As an example:

          @MarcPow you can do this with the JSON output and `jq` or some other tool that speaks JSON. As an example:

gh projects item-list --org <YOUR_ORG> <PROJECT_NUMBER> --format=json | jq '.items[] | select(.status=="In Progress"  and .content.type == "Issue")’

Originally posted by @mntlty in https://github.com/github/gh-projects/issues/93#issuecomment-1577165339

Me podrías apoyar con la trasferencia Paypal  $6,700  gracias


User loses sight of the app during  sharing

First, choose your Android phone's Gallery app and launch it. Okay now find a photo and push Share. Okay now from all the sharing applications pick the Commons application. Okay fill in the  forms as usual and when we finally get to the last screen we touch the Submit button. All is okay so far except now we are switched back to the gallery app looking at the original photo!
( Yes, somewhere in the background in Android the Commons app is actually uploading the  photo but wouldn't it be more pleasant to have a progress bar on the screen and when we finally succeed have a message that it completed and then be sure to have the user touch it before it'll disappear or whatever.)

My point is all through the process the user should never lose sight of the Commons app. Not even for one second.  And only then should the app disappear.

And yes, temporary toast messages aren't good enough.  So be sure to have a confirm button. I guess you would call it an okay button.

And yes, I reported this bug when a picture was still uploading in the background so I'm not sure what was going to happen next. However the app shouldn't have switched back to the gallery even for one second anyway.

@nicolas-raoul  @4D17Y4 we have this feature now in our app so we can close this issue now

This is still happening, but I think it is working as intended.
Same happens with the Gmail app.


[Haskell] Make sure GHCUP_INSTALL_BASE_PREFIX is set

We use it during installation and add it to PATH, but then don't instruct ghcup to actually use this directory at runtime.
This leads to:

ghcup is in /usr/local/.ghcup/bin/
ghcup install cabal latest will actually install into ~/.ghcup/bin/
since ~/.ghcup/bin/ is not in PATH, but /usr/local/.ghcup/bin/ is, the new binary is not visible to the user

This issues does not exist on darwin, because there we use ~/.ghcup/bin/.

An alternative approach is matching the macOS install way and use the default ~/.ghcup. Why was /usr/local/.ghcup chosen for linux?

@al-cheb @mikhailkoliada

/azp run ubuntu1804,ubuntu2004,ubuntu2204

Good to go?

@hasufell yes, sorry for the delay!


Adding Image Build/Push Role + Recipe for MLPerf SSD Image

WIP
Adding role for building images and pushing to quay, and a recipe for building/pushing mlperf ssd image
TODO:

Add trigger to latest commit message: test-path: recipes publish_mlperf_ssd_image
Add comment: /test test-commit

thanks for the PR @Maxusmusti,
as @omertuc mentioned, this isn't related to the GPU Operator [CI], so let's move it out of the gpu_operator, but I'm not sure where to have it. cluster? but it's not cluster related ... utils?
I was going to add that podman isn't available in the image (this still stands), but it seems to be available without entitlement in UBI, so seems we'll be good with podman package installed in the Dockerfile. IIRC, it required RHEL entitlement until recently, but I've just installed it in a non-entitled cluster

/test ?

/test test-commit

 FATAL: Unknown entrypoint 'recipe' | publish_mlperf_ssd_image

in test-path: recipe publish_mlperf_ssd_image it should be recipes, as in the dir name ;-)

/test test-commit

/test test-commit

<stderr> time="2021-12-08T14:51:35Z" level=warning msg="\"/\" is not a shared mount, this could cause issues or missing mounts with rootless containers"
<stderr> time="2021-12-08T14:51:35Z" level=error msg="cannot find UID/GID for user psap-ci-runner: No subuid ranges found for user \"psap-ci-runner\" in /etc/subuid - check rootless mode in man pages."
<stderr> time="2021-12-08T14:51:35Z" level=warning msg="using rootless single mapping into the namespace. This might break some images. Check /etc/subuid and /etc/subgid for adding sub*ids"
<stderr> Error: context must be a directory: "/NVIDIA/benchmarks/ssd/implementations"
----- FAILED ----

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift-psap_ci-artifacts/292/pull-ci-openshift-psap-ci-artifacts-master-test-commit/1468592601027317760/artifacts/test-commit/test-commit/artifacts/recipes_publish_mlperf_ssd_image/test-log.txt
doesn't smell good :'(
could you add a set -x at the beginning of the script to better understand which step fails?

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

\test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

/test test-commit

thanks @Maxusmusti looks good,
last thing, Run ansible-lint on the playbooks and roles / build (pull_request)  --> this Action is broken, could you run this manually and try to fix whatever it reports?
ansible-lint -c ./config/ansible-lint.yml roles playbooks

(we're trying to follow Ansible best/recommended practises, one of them is "every task should have a name" ... including block/always/rescue 🙃 Just put a description of the block there)

/test test-commit

Made all necessary changes to remove all warnings/suggestions from ansible-lint and comply with best practices

thanks for the effort @Maxusmusti, LGTM
/lgtm
/approve
/override ci/prow/gpu-operator-e2e

just some ideas maybe for a follow up update of this role:
image_buildconfig.yml
helper-image-push-pod.yml
helper.yml

these files are the one doing the job, they could be named with 000n_<name>.yaml to make it easier to reproduce outside of the CI (see there for an example)
and also for reproducibility, remove namespace: utils-ci from the yaml template, add create with oc create -f ... -n utils-ci


config.js file

i get this error. Erorr detected on config.js file
The number of tile sources (16 in aIMG) and the tile delay (16 in tile delay) arrays should  match the number of items each one contains and the number of tiles used on the layout specified (12)
what do i need to look for to fix this

As explained on the instructions here:
https://github.com/VA3HDL/hamdashboard?tab=readme-ov-file#20241113-changelog
You should add these lines to your config.js file with the appropriate number of columns and rows you desire.
// Grid layout for 16 tiles
var layout_cols = 4;
var layout_rows = 4;

Ok thank youSent from my iPhoneHank Watkins On Nov 26, 2024, at 4:00 PM, Pablo @.***> wrote:
As explained on the instructions here:
https://github.com/VA3HDL/hamdashboard?tab=readme-ov-file#20241113-changelog
You should add these lines to your config.js file with the appropriate number of columns and rows you desire.
// Grid layout for 16 tiles
var layout_cols = 4;
var layout_rows = 4;
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>


Cannot find Slack installation

It stopped rendering math so I tried to reinstall. I get the error message "Cannot find Slack installation".
Windows 64-bit
Slack version: 2.7.1 64-bit Beta Channel

The script is not made to automatically find beta versions of slack, so you'll need to specify the installation yourself.
There will be a folder something like "AppData\Local\slack\2.7.1-beta\resources\app.asar.unpacked\src\static" in your user profile folder, call the script with that as a provided parameter. E.g.:
math_with_slack.bat %gauss256%\AppData\Local\slack\%2.7.1-beta%\resources\app.asar.unpacked\src\static

where you need to change %gauss256% and %2.7.1-beta% to the appropriate values.
Please let me know if this work.

OK, I've figured it out. For some reason the installation .bat file stopped working. Fixing it required the use of delayed expansion.
I'll do a pull request.

@fsavje Our comments crossed. Fortunately, finding the beta version was not a problem. (How did I get on the beta channel anyway??)
Not only is the installation working again in my fork, but the math is rendering properly too.

This should be addressed with version 0.2.2. Please let me know if it isn't.

Works here.


WIP: Remove obsolete deps and clean up blast damage

Coverage increased (+0.007%) to 98.188% when pulling c3ade47d4cdef03a129df14f8a98bea35e902d0f on CyberiaResurrection:DepCleanup into<PHONE_NUMBER>acad3199e91cb9ebe9ac096d534cf9 on Algo-Web:master.

Coverage increased (+0.007%) to 98.188% when pulling c3ade47d4cdef03a129df14f8a98bea35e902d0f on CyberiaResurrection:DepCleanup into<PHONE_NUMBER>acad3199e91cb9ebe9ac096d534cf9 on Algo-Web:master.


Schemas/gameversion: Document denoting Live versus Legacy for CAPI data

With Update 14 there are now two CAPI servers:

Live remains as https://companion.orerve.net/
Legacy is https://legacy-companion.orerve.net/

As such any EDDN Sender using CAPI-sourced data can know which galaxy it is for.
Thus it is proposed to update the documentation for gameversion to mandate that CAPI-sourced data use a string of the form CAPI-<galaxy>-<endpoint>, e.g.:

CAPI-Live-market - CAPI-sourced data for the Live galaxy, from the /market endpoint.
CAPI-Legacy-market - CAPI-sourced data for the Legacy galaxy, from the /market endpoint.

This format allows Listeners to, for example:

Check for leading CAPI-, and if found.
Split the string on - and utilise the 2nd and 3rd components.

If you have a good reason why your code wouldn't be able to keep track of the galaxy it queried data from, and thus you need to continue with CAPI-<endpoint> make your case now.  Obviously listeners will at least need to cope with such enough to discard the data if they so choose.

Why not keep the gameversion like it is and define the Live/Legacy with the gamebuild?

Why not keep the gameversion like it is and define the Live/Legacy with the gamebuild? ... "gameversion": "CAPI-market", "gamebuild": "Live" ...

Given gamebuild doesn't carry any useful information for CAPI-sourced data I can see why that seems a good suggestion.
Listeners, do you have any preference?  You might be parsing into gameversion anyway if it starts CAPI-, but on the other hand a quick check on if gamebuild == "Live" ... might be easier ?

I'm happy with the gameversion only "CAPI-Live-market" format.

My preference would be to leave the live data string as is, e.g.
CAPI-market - CAPI-sourced data for the Live galaxy, from the /market endpoint.
CAPI-Legacy-market - CAPI-sourced data for the Legacy galaxy, from the /market endpoint.
Changing the live string adds an unnecessary complication in my opinion. And may leave us a little less prepared for any future additional galaxy splits.

My preference would be to leave the live gameversion data string as is, e.g.
CAPI-market - CAPI-sourced data for the Live galaxy, from the /market endpoint.
CAPI-Legacy-market - CAPI-sourced data for the Legacy galaxy, from the /market endpoint.
Changing the live string adds an unnecessary complication in my opinion. And may leave us a little less prepared for any future additional galaxy splits.

The problem with that is then a Listener can't tell if CAPI-market is because a Sender had set that up before the change and just not thought to change it after adding support for the Legacy CAPI server.  A wholesale change for Live versus Legacy makes it crystal clear if they have or not.

CAPI-market - an initial implementation, not updated.  Could possibly be either galaxy, if the Sender added support for the alternate Legacy host.
CAPI-Live-market - updated for this change, Live galaxy.
CAPI-Legacy-market - updated for this change, Legacy galaxy.

Yes, it's a corner case, but one worth keeping in mind.
Always denoting the source galaxy also means no ambiguity if quickly looking at this (unlike the game launcher where I see some people are confused as to which "Elite Dangerous: Horizons" is due to the UI/UX not necessarily also showing "Legacy Horizons" at the same time).

From Discord:

Anthor (EDSM/SCIM): I'll say that enforcing Live makes sure that it's not a default old value
Anthor (EDSM/SCIM): So I'm up for CAPI-{Live|Legacy}-{Market|Shipyard}

Artie (Inara): same here, up for CAPI-Live and CAPI-Legacy

Athanasius (EDMC, EDDN): I don't envisage Spansh or themroc differing in their assessment, but they have until tomorrow to pipe up (they haven't on the github issue yet either).
Spansh: I'm good with it

So that leaves only @themroc5 out of the major Listeners.  Unless there's a justified objection by tomorrow morning I'll start work then on a PR to update the documentation for the CAPI-<Live|Legacy>-<endpoint> scheme.

TL;DR - I'm 99.9% confident that the CAPI split is functioning as intended.  Only Legacy data on the legacy host, only Live data on the live host.
I've just updated https://github.com/Athanasius/fd-api to support the legacy server, and testing with that (where I know there's a difference for me after making some changes in-game for Legacy) shows that indeed the correct servers are showing the correct data.

/profile shows I've moved and have a different credit balance, along with showing all my ships now in a different location (moved from FC to a station).
/shipyard shows the data for the different station I'm now docked in (both normal 'large' stations, not my FC).
'/market' shows the data for the different stations as well.

I've not explicitly checked that where, e.g. a station has different state in-game between galaxy versions, that definitely shows up correctly in CAPI data.  Might be possible to 'easily' do with a station that's still dockable but is affected by the Thargoid invasion, but otherwise it'd take running two game clients and being very fast to ensure an observed in-game difference should be in CAPI data, and confirming it is.

Updated doc currently available at https://github.com/EDCD/EDDN/blob/fix/201/eddn-capi-denote-live-vs-legacy/docs/Developers.md#gameversions-and-gamebuild
I'll merge that through to live in about an hour unless anyone has suggested edits.

Merged -> develop -> master -> live.


Battleship (again) in Java

Added battleship once again, but this time with code!

@AlternateWalls
Actually this repo is now been excluded from hactoberfest I was fearing that it will happen eventually their can be any reason like a lot of spam PR’s so it can’t be helped but yeah it’s a one month long program so their is a lot of time to do more PR’s on many different repo’s. So, yeah Happy Hactoberfest


Performance: GitLab API Detection

When querying GitLab to determine API version the query to version 3 takes a full minute (fetching owned projects).
Hopefully there's a more efficient way to detect API version - https://gitlab.com/gitlab-org/gitlab-ce/issues/35685

Yes, I had noticed when running against the public API that it still took around 5 seconds for my 2 owned repositories.

@hbetts I plan to start implementing breaking changes for renovate@v10 once node.js v8 reaches LTS (and drop support for babel/transpilation). What do you think about removing GitLab APIv3 support at that time too?

@rarkins that would be fine with me. Technically GitLab had planned on removing v3 API support last month, but because of continued use of that API endpoint, they extended the deadline by some unspecified amount of time.
I would assume the GitLab team would appreciate you removing v3 support. :smile:
There may still be a few users out there maintaining a sufficiently old enough version of GitLab that v3 is the only option, or for some other reason haven't made the transition.
So perhaps a patch on Renovate v9 with a warning that v3 GitLab support is going to be dropped?
Also, I read on one of the GitLab sites that they plan on a v5 endpoint in the mid-future. (Originally a REST gateway on top of GraphQL, but looks like they recently dropped that plan)
(On a related note, v4 for GitLab.com works just fine - https://gitlab.com/hyper-expanse/generator-python-lib/merge_requests/6)


Some fixes

Wanted to use the plugin, and stumbled upon some assorted little issues. This PR handles all of them; please let me know if you prefer single PRs for each of them.

 You should sign our Contributor License Agreement in order to get your pull request merged.


qutebrowser: fix license

Nice catch. Where do you get the info? SPDX  says that gpl3plus is deprecated

Jascha Geerds writes:

Nice catch. Where do you get the info?

At the bottom of the home
page.

SPDX says that gpl3plus is
deprecated

Yes, but look at the bottom of the license list:

This new syntax supports the ability to use a simple “+” operator
after a license short identifier to indicate “or later version”
(e.g. GPL-2.0+).

Reply to this email directly or view it on GitHub:
https://github.com/NixOS/nixpkgs/pull/8475#issuecomment-114676555

--