Patching main.m fails on projects that uses swift

The file main.m doesn't exist anymore when using swift, so the plugin injector fails when trying to patch it (see error below)
Note how in cocoa touch the entry point is directly the AppDelegate.swift that is marked with @UIApplicationMain, while in cocoa the entry point is the main.swift file.
Patching project contained in: myProject/
Could not match project’s main.(m|mm) at ~/Library/Application Support/Developer/Shared/Xcode/Plug-ins/InjectionPlugin.xcplugin/Contents/Resources/common.pm line 51.
	main::error(‘Could not match projectÉmain.(m|mm)’) called at ~/Library/Application Support/Developer/Shared/Xcode/Plug-ins/InjectionPlugin.xcplugin/Contents/Resources/patchProject.pl line 65
*** Bundle build failed ***
Check Bundle project.

Hi Danny,
I've attached an installer package for a new version of injection we are working on
offline which it is probably best to get working.  After installing you'll need to
enter the license key "INJECTION_DANNY" to have it continue to work using
the Product/Injection menu.
Let me know if this doesn't get you up and running.
Cheers,
John
----- Original Message -----
From: danydev
To: johnno1962/injectionforxcode
Cc: John Holdsworth
Sent: Wednesday, December 31, 2014 2:33 PM
Subject: Re: [injectionforxcode] Patching main.m fails on projects that uses swift (#36)
Ok, I just sent you an email at support (at) injectionforxcode.com, so that we can try with remote control, let me know if you didn't receive it.
—
Reply to this email directly or view it on GitHub.

Hi Danny,
I've attached an installer package for a new version of injection we are working on
offline which it is probably best to get working.  After installing you'll need to
enter the license key "INJECTION_DANNY" to have it continue to work using
the Product/Injection menu.
Let me know if this doesn't get you up and running.
Cheers,
John
----- Original Message -----
From: danydev
To: johnno1962/injectionforxcode
Cc: John Holdsworth
Sent: Wednesday, December 31, 2014 2:33 PM
Subject: Re: [injectionforxcode] Patching main.m fails on projects that uses swift (#36)
Ok, I just sent you an email at support (at) injectionforxcode.com, so that we can try with remote control, let me know if you didn't receive it.
—
Reply to this email directly or view it on GitHub.

Hi,
I just removed the plugin and then installed the package, when I inject the
source I have this error
thanks again for your support.
Connection from:

/Users/myUser/Library/Developer/CoreSimulator/Devices/43EFBC4C-53BE-4603-B5B8-7A83E8C78A2A/data/Containers/Bundle/Application/60CABAFE-601C-4C48-9A12-25EC1542CE70/TestProject.app/TestProject
x86_64 (60)
start 0.097 seconds
setup 0.003 seconds
2015-01-01 15:30:41.214 xcodebuild[85212:3489466] [MT] IDELogStore: Log
record’s backing file
(“/Users/myUser/Library/Developer/Xcode/DerivedData/TestProject-becldnbsvktxascvgkdmotcgelnn/Logs/Build/A8D1C28E-410E-4E50-8F00-54B830008725.xcactivitylog”)
is missing. Skipping.
2015-01-01 15:30:41.743 xcodebuild[85212:3489497]  DeveloperPortal: Using
pre-existing current store at URL
(file:///Users/myUser/Library/Developer/Xcode/DeveloperPortal%206.1.1.db).
Use of uninitialized value in concatenation (.) or string at
/Users/myUser/Library/Application
Support/Developer/Shared/Xcode/Plug-ins/InjectionPlugin.xcplugin/Contents/Resources/injectSource.pl
line 125.
patched 1.111 seconds
sh: -c: line 0: syntax error near unexpected token (‘ sh: -c: line 0: ls -t (null)/../Logs/Build/*.xcactivitylog’
logged 0.003 seconds
Could not locate compile command for
/Users/myUser/Desktop/TestProject/TestProject/ViewController.swift at
/Users/myUser/Library/Application
Support/Developer/Shared/Xcode/Plug-ins/InjectionPlugin.xcplugin/Contents/Resources/
common.pm line 49.
main::error(‘Could not locate compile command for /Users/myUser/Deskt…’)
called at /Users/myUser/Library/Application
Support/Developer/Shared/Xcode/Plug-ins/InjectionPlugin.xcplugin/Contents/Resources/injectSource.pl
line 239
*** Bundle build failed ***
Check Bundle project.

2015-01-01 10:44 GMT+01:00 John Holdsworth<EMAIL_ADDRESS>
Hi Danny,
I've attached an installer package for a new version of injection we are
working on
offline which it is probably best to get working. After installing you'll
need to
enter the license key "INJECTION_DANNY" to have it continue to work using
the Product/Injection menu.
Let me know if this doesn't get you up and running.
Cheers,
John
----- Original Message -----
From: danydev
To: johnno1962/injectionforxcode
Cc: John Holdsworth
Sent: Wednesday, December 31, 2014 2:33 PM
Subject: Re: [injectionforxcode] Patching main.m fails on projects that
uses swift (#36)
Ok, I just sent you an email at support (at) injectionforxcode.com, so
that we can try with remote control, let me know if you didn't receive it.
—
Reply to this email directly or view it on GitHub.
—
Reply to this email directly or view it on GitHub
https://github.com/johnno1962/injectionforxcode/issues/36#issuecomment-68483282
.

Hi,
I just removed the plugin and then installed the package, when I inject the
source I have this error
thanks again for your support.
Connection from:

/Users/myUser/Library/Developer/CoreSimulator/Devices/43EFBC4C-53BE-4603-B5B8-7A83E8C78A2A/data/Containers/Bundle/Application/60CABAFE-601C-4C48-9A12-25EC1542CE70/TestProject.app/TestProject
x86_64 (60)
start 0.097 seconds
setup 0.003 seconds
2015-01-01 15:30:41.214 xcodebuild[85212:3489466] [MT] IDELogStore: Log
record’s backing file
(“/Users/myUser/Library/Developer/Xcode/DerivedData/TestProject-becldnbsvktxascvgkdmotcgelnn/Logs/Build/A8D1C28E-410E-4E50-8F00-54B830008725.xcactivitylog”)
is missing. Skipping.
2015-01-01 15:30:41.743 xcodebuild[85212:3489497]  DeveloperPortal: Using
pre-existing current store at URL
(file:///Users/myUser/Library/Developer/Xcode/DeveloperPortal%206.1.1.db).
Use of uninitialized value in concatenation (.) or string at
/Users/myUser/Library/Application
Support/Developer/Shared/Xcode/Plug-ins/InjectionPlugin.xcplugin/Contents/Resources/injectSource.pl
line 125.
patched 1.111 seconds
sh: -c: line 0: syntax error near unexpected token (‘ sh: -c: line 0: ls -t (null)/../Logs/Build/*.xcactivitylog’
logged 0.003 seconds
Could not locate compile command for
/Users/myUser/Desktop/TestProject/TestProject/ViewController.swift at
/Users/myUser/Library/Application
Support/Developer/Shared/Xcode/Plug-ins/InjectionPlugin.xcplugin/Contents/Resources/
common.pm line 49.
main::error(‘Could not locate compile command for /Users/myUser/Deskt…’)
called at /Users/myUser/Library/Application
Support/Developer/Shared/Xcode/Plug-ins/InjectionPlugin.xcplugin/Contents/Resources/injectSource.pl
line 239
*** Bundle build failed ***
Check Bundle project.

2015-01-01 10:44 GMT+01:00 John Holdsworth<EMAIL_ADDRESS>
Hi Danny,
I've attached an installer package for a new version of injection we are
working on
offline which it is probably best to get working. After installing you'll
need to
enter the license key "INJECTION_DANNY" to have it continue to work using
the Product/Injection menu.
Let me know if this doesn't get you up and running.
Cheers,
John
----- Original Message -----
From: danydev
To: johnno1962/injectionforxcode
Cc: John Holdsworth
Sent: Wednesday, December 31, 2014 2:33 PM
Subject: Re: [injectionforxcode] Patching main.m fails on projects that
uses swift (#36)
Ok, I just sent you an email at support (at) injectionforxcode.com, so
that we can try with remote control, let me know if you didn't receive it.
—
Reply to this email directly or view it on GitHub.
—
Reply to this email directly or view it on GitHub
https://github.com/johnno1962/injectionforxcode/issues/36#issuecomment-68483282
.

After a bit of pair debugging we found that the issue was in the Derived Data location path.
Currently injectionforxcode assumes the "Unique" settings mode (that's the default setting), so to solve the issue I needed to change back the derived data path back to Unique.
To do that, just open Xcode \ Preferences \ Locations \ Advanced and select Unique

After a bit of pair debugging we found that the issue was in the Derived Data location path.
Currently injectionforxcode assumes the "Unique" settings mode (that's the default setting), so to solve the issue I needed to change back the derived data path back to Unique.
To do that, just open Xcode \ Preferences \ Locations \ Advanced and select Unique

Thank god I found your post, adding the fake main.m + reseting the Derived Data location to "Unique" solved it for me. Thank you so much :)


Where do I need to buy the hardware?

What is the name of the hardware and where can I purchase it?

hi, currently only support the Taobao UWB Dongle Sniffer


ARROW-1029: [Python] Fixes for building pyarrow with Parquet support on MSVC. Add to appveyor build

Miscellaneous fixes to build with --with-parquet and pass the test suite. We still have a bunch of compiler warnings; not blocking for 0.4.0, but after PARQUET-991 is resolved we should fix the MSVC compiler warnings in pyarrow

Rebased after #698

Appveyor build: https://ci.appveyor.com/project/wesm/arrow/build/1.0.454


Is there any chance of including gvfs-nfs?

I use NFS to fetch ROMs from my NAS. Currently, I have to mount it using mount (or add it to /etc/fstab), but it would be more convenient to just use Nautilus for this. Today, I tried unfreezing the system and installing this library, and I can simply use it through Nautilus. Could this library be included by default?
Sorry if something doesn't make sense, English is not my first language.

@mjsf12 thanks for your feedback. Can you create a PR about this and provide info about how much space the new packages takes up?

I tried unfreezing the system and installing this library

Which library?

I don't know what methodology you use to measure package size, but it would only install two packages:
libnfs -> 757.5 KB
gvfs-nfs -> 50.2 KB
So it would be around 807.7 KB.
If you have your own methodology, please explain it to me.

I tried unfreezing the system and installing this library

Which library?

gvfs-nfs

I don't know what methodology you use to measure package size, but it would only install two packages: libnfs -> 757.5 KB gvfs-nfs -> 50.2 KB So it would be around 807.7 KB. If you have your own methodology, please explain it to me.

Answering for future reference: exactly what you did.
PR merged: thank you.


Update PaaS VCAP_SERVICES config load for new environment

New PaaS environment has a different name for the postgres service compared to the trial one, so we need to update the config code that parses the VCAP_SERVICES JSON.

:+1:


Update package lodash

Security vulnerability in transient dependency lodash.

Coverage remained the same at 94.595% when pulling ab03b53d7f53a1508484733ac80ffb0723c9c992 on security/lodash into e9d6e53708d2b397a5e2d502b0c1a182069a2427 on master.


Generate Attributes using Scaffolder

It should generate an Entity with Attributes instead of Annotations
php app.php create:entity post -f id:primary -f title:string

Done by: https://github.com/spiral/cycle-bridge/pull/36


Add OpenFunction katacoda scenarios

Signed-off-by: x893675<EMAIL_ADDRESS>OpenFunction Issue#167
Preview OpenFunction Scenario

Many thanks to @x893675 !
I validated this scenario on Katacode and the results met our expectations, that is, demonstrating the installation process of OpenFunction on Kubernetes.
However, there is a small problem, the following step causes an exception (it seems doesn't really matter)

controlplane $ ssh node01 "apt-get install -y kubelet=1.19.0-00 kubectl=1.19.0-00"
Warning: Permanently added 'node01,<IP_ADDRESS>' (ECDSA) to the list of known hosts.
E: Could not get lock /var/lib/dpkg/lock-frontend - open (11: Resource temporarily unavailable)
E: Unable to acquire the dpkg frontend lock (/var/lib/dpkg/lock-frontend), is another process using it?
controlplane $ ssh node01 "apt-get install -y kubelet=1.19.0-00 kubectl=1.19.0-00"
E: Could not get lock /var/lib/dpkg/lock-frontend - open (11: Resource temporarily unavailable)
E: Unable to acquire the dpkg frontend lock (/var/lib/dpkg/lock-frontend), is another process using it?
controlplane $ ssh node01 "apt-get install -y kubelet=1.19.0-00 kubectl=1.19.0-00"
E: Could not get lock /var/lib/dpkg/lock-frontend - open (11: Resource temporarily unavailable)
E: Unable to acquire the dpkg frontend lock (/var/lib/dpkg/lock-frontend), is another process using it?
controlplane $ ssh node01 "apt-get install -y kubelet=1.19.0-00 kubectl=1.19.0-00"
E: Could not get lock /var/lib/dpkg/lock-frontend - open (11: Resource temporarily unavailable)
E: Unable to acquire the dpkg frontend lock (/var/lib/dpkg/lock-frontend), is another process using it?
controlplane $ ssh node01 "apt-get install -y kubelet=1.19.0-00 kubectl=1.19.0-00"
Reading package lists...
Building dependency tree...
Reading state information...
kubectl is already the newest version (1.19.0-00).
kubelet is already the newest version (1.19.0-00).
The following packages were automatically installed and are no longer required:
  libc-ares2 libhttp-parser2.7.1 libnetplan0 libuv1 nodejs-doc
  python3-netifaces
Use 'apt autoremove' to remove them.
0 upgraded, 0 newly installed, 0 to remove and 199 not upgraded.

@tpiperatgod
It really doesn't matter.  I think the cause of this problem is not this command.
And I verified it many times and found that this problem does not occur 100% .

@x893675 @tpiperatgod there is a fix for this
https://askubuntu.com/questions/1109982/e-could-not-get-lock-var-lib-dpkg-lock-frontend-open-11-resource-temporari

@benjaminhuo @tpiperatgod
Add additional explanation for step4

Approved

Thanks for the contribution, It'll be great if more function sample demos can be added @x893675


meet error in build javascript into main.js

failed:  js/build.json doesn't exist

fixed, try 2.7.4


Create lecture page

The lecture page is where all the chapter contents from the backend are displayed to the user. Here is what I was thinking.

Create copy of dashboard.ejs file.
Modify styles so that there is a space to display content on page next to the sidebar.
Use internal APIs to grab chapter titles and display them to the user.
When a chapter is clicked, it should open the first page of the chapter.
Use internal APIs to grab pages individually from server or grab all the chapter contents in one go.
Use marked.js to convert markdown page content to html and then insert that html on the page along with the title.
Display pages one at a time with back and forward buttons which display next page or go back to chapter list depending upon the point in the chapter.

The question that I have is should we split the chapter table of contents page and the content pages into two separate .ejs files with different routes. Also, the internal APIs are documented in the app.js file on the get /chapters and get /pages routes.
Now that I think about it a little more it might be easier to have a sort of table of contents page with links that send a get request to the same route and provide the chapter_id as a parameter so that the chapter contents page can be displayed.

Jeannie just finished this up so this issue has been closed.


Adding update command to DocumentDB

Adding support for updating documentdb accounts through the Azure CLI

Please fix the Pylint issue. It looks like you have a dangerous default (using empty list as a default value)

@tjprescott Pylint seems to be alright, couldn't determine what the build failure was related to


[Xaml] Invalid resource type: expected type is 'DataTemplate', actual type is 'DataTypeTemplateSelector'.

Release Type: GitHub
Version: master
https://github.com/stride3d/stride/blob/c6fd21b1bc974fd3fed0f6089df31bb356b3e574/sources/editor/Stride.Core.Assets.Editor/Components/TemplateDescriptions/Views/TemplateBrowserUserControl.xaml#L60C95-L60C95
Guess type should be changed to DataTypeTemplateSelector in
https://github.com/stride3d/stride/blob/c6fd21b1bc974fd3fed0f6089df31bb356b3e574/sources/editor/Stride.Core.Assets.Editor/Components/TemplateDescriptions/Views/ObjectBrowserUserControl.xaml.cs#L56

Fixed through #1822


Update Contributors.md (#71918)

Evgeneus75

https://github.com/Evgenius75/first-contributions/pull/2.diff


Question: What to use in async server where the receive order must be strictly kept?

Hello, I would like to use pyzmq as core part in my project, and I have some questions regarding using pyzmq DEALER and ROUTER pattern.
To simply explain my project, there is one server and multiple workers (around 500-1000) processes. After getting messages from workers, the server has to distribute messages to other workers one by one in sequence. For example, if server sends (msgA to proc1) -> (msgB to proc2) -> (msgC to proc1)  -> (msgD to proc1) -> (msgE to proc2) -> (msgF to proc3),
Then proc1 should receive messages msgA -> msgC -> msgD in order, and this order should be strictly followed.
Also I want the server and worker runs asynchronously, in order to make my program faster and use less threads.
I read the zmq guide docs, and found out that async server-client pattern would fit into my case, so I implemented the code using DEALER and ROUTER pattern like below.
class Server:
    def __init__(self):
        self.sender = self._zmq_context.socket(zmq.ROUTER)
        self.sender.bind("tcp://*:" + str(MASTER_SEND_PORT))

        # dummy
        for _ in range(master_rank):
            _, msg = self.sender.recv_multipart()
            assert msg == b"alive"

    def send_msg(self, msg):
        target = _id(msg.to_rank)
        self.sender.send(target, zmq.SNDMORE)
        self.sender.send_pyobj(msg)

class SocketDealer(BaseSocket):
    def __init__(self, rank, master_addr):
        self._rank = rank
        self._zmq_context = zmq.Context()
        self._running = False

        self.sender = self._zmq_context.socket(zmq.DEALER)
        self.sender.setsockopt(zmq.IDENTITY, _id(self._rank))
        self.sender.connect("tcp://" + master_addr + ":" + str(MASTER_RECV_PORT))

    def _loop(self):
        while True:
            msg = self.recver.recv_pyobj()
            assert msg.to_rank == self._rank
            yield msg
        except ZMQError as e:
            return Message(mtype=MessageType.TERMINATE)

def _id(rank):
    return bytes(f"w{rank}_", "utf-8")

In fact I initially implemented my project in REP-REQ sockets but it was slow due to its lockstep pattern, so I changed it with DEALER-ROUTER. The code seems to work correctly, but I still wonder to it is okay to use ROUTER as sender socket, and DEALER` as receiver socket.
Do you think that above code is valid? What is the best practice to  do in my case?
Thanks in advance.

I think it's fine to do it this way. Message order is guaranteed within a given socket pair.


Log a warning when the user register a null value as localStream (opentera-webrtc-web-client)

When the user instantiate a new StreamClient he can pass a null value in the attribute localStream of the streamConfiguration parameters of the constructor:
const StreamConfiguration = {
    localStream: nullSrcVideoElement.srcObject, // Where nullSrcVideoElement.srcObject = null
    isSendOnly: false
};
streamClient = new openteraWebrtcWebClient.StreamClient(SignalingServerConfiguration, StreamConfiguration, RtcConfiguration, logger);

If the user expect that he had pass a valid value to localStream it can be really hard for him to figure it out what's wrong in his code without any warning.

@mamaheux, could we just write a warning message on the console when null is passed as a localStream?

@mamaheux, could we just write a warning message on the console when null is passed as a localStream?

If the StreamClient doesn't need to send a video stream, localStream should be null or undefined. So, I don't think the warning is a good idea.

If the StreamClient doesn't need to send a video stream, localStream should be null or undefined. So, I don't think the warning is a good idea.


feature request: allow loading ./src/my-tokens.json file using relative path

currently, tokens config only allows to load from npm package
it's a common use case to load from local file

oh, I had a wrong filename. It already supports


Android: UnifiedPush subscription not using saved user credentials

Using Ntfy server 1.27.2, Android Ntfy app 1.13.0, and Android Element 1.4.32
ACL is enabled on the server, and auth-default-access set to 'deny-all'
The subscription that Element sets up for UnifiedPush use does not use the saved user credentials in the ntfy app. The user is an admin, and the "Managed users" page does say the user is being used for this topic. The only error I see in the server log is a "unauthorized: unauthorized" message
In order to get Element to pass the "Test Push" test, I have to give anonymous read-write access to the topic that's created by Element
Android log:
https://nopaste.net/PFREHjyS0Q

Just ran into the same issue, the workaround for now is using the ntfy.sh server for unified push and your own for other things but that's no real workaround as you are not using your server

This is not a bug in ntfy, but rather a design limitation of UnifiedPush (UP). In UP, the URL is the secret, user/password cannot be used in the spec.
This explains this in more detail: https://unifiedpush.org/users/distributors/ntfy/#limit-access-to-some-users
Specifically this section:

Pushers still need to be able to write to UnifiedPush topics to send push notifications. Add a rule to make UnifiedPush topics (they all start with “up”) world-writeable: ntfy access '*' 'up*' write-only

For more questions about UP, please check out the UP Matrix room(s)

Gotcha. To get around this limitation in a more user-friendly way, could we add a ACL sub-option in the config file or a toggle in the 'ntfy access' command?

@ryester19 Any suggestions?

Let me know if you have any suggestions. For now I'll close this issue.


emscripten: 3.1.41 -> 3.1.42

Description of changes

Updated from 3.1.41 to 3.1.42.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[X] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 240227 run on aarch64-darwin 1

6 packages marked as broken and skipped:

faust2alqt
faust2alsa
faust2jack
faust2jaqt
faust2sc
open-music-kontrollers.mephisto

7 packages built:

emscripten
faust (faust2)
faust2csound
faust2firefox
faust2jackrust
faust2ladspa
faust2lv2

@drupol tests look good!


blake2: fix a typo in a specification

This MR fixes a typo in the Blake2b specification.
When hashing with a key, the maximum message length should still be less than 2^128 but without one block (for a key), i.e., 2^128 - 128.
Let's wait for the CI to see if this change breaks things or not.

Good catch, thanks Marina!


Condense NodeConfiguration and NodeOptions

Proposed change
The two structs are almost identical
Use case
This will allow us to drop a config at preflight
Contribution
No response

@kthomas did you're node refactor close this?

@kthomas did you're node refactor close this?

Just about. I am going to axe one of the parameters provided to NewNode in a small PR and then we can close this.


Document Jaeger tracing on the Diagnostics page

Document Jaeger tracing on the Diagnostics page
Description
In 20.1, we're getting additional capability for self-service analysis of statements. There's an option to spin up a Jaeger instance in a Docker container and run tracing analysis of the SQL statements. This will be a welcome addition to our docs.
Outline
Expected Audience

note this was added in v20.1.1 and is not available in v20.1.0

@piyush-singh, was this on the 20.1 roadmap?

@dbist @andreimatei Could one of you point me to the Jaeger demo?

@jseldess this wasn't planned for 20.1, I think Andrei managed to squeeze this in as a follow up for 20.1.1. @taroface there are some instructions Andrei added to the trace file itself, and I think the SE team has a recording of the meeting although I can't seem to find it. We can reach out to Keith or Tim to grab a copy. I can also spin up a test cluster using master so that we can try this out.

Thanks, @piyush-singh.
Also cc @vy-ton, as this is another form of third-party tooling we may want to call out.

I did a little demo at the Eng Team Meeting on 04/30. @isaactwong said the recording will be here sometime today: https://drive.google.com/drive/folders/1unZIXZIBB1drC7qGlgfkGjUkHUappRsY

Mentioned in the 20.1.1 release notes:
PR: https://github.com/cockroachdb/cockroach/pull/47432
From release notes:

The statement diagnostics bundle now contains a new file, trace-jaeger.json, that can be manually imported in Jaeger for visualization. [#47432][#47432] {% comment %}doc{% endcomment %}

@piyush-singh @taroface I'm about to merge a revamp of the Third-Party Database Tools page to include a summary of supported appdev tooling and their recommended versions.
Going forward, thoughts on adding observability tools as a new section? Could the Observability team add this section after the initial PR merges?

@vy-ton I think a new section on Observability tool would be great - I think we can include tools and integrations for monitoring/alerting, distributed tracing, and logging. I think having that added as a follow on PR makes sense on my end, but will defer to @taroface on the logistics.

Yes, a new PR for Observability tools makes sense to me. @vy-ton is there a GitHub issue attached to your PR? If so, we could use the same.

Yes, its #7279


PHPLIB-722: Ignore writeConcern option for read-only aggregations

Fix PHPLIB-722
This does not change anything functionally, but cleanup $options in the constructor instead of picking the writeOption conditionally in executeCommand(). There is no impact on getCommandDocument() which already ignores writeConcern.

Failing test:
1) MongoDB\Tests\Collection\CollectionFunctionalTest::testMethodInTransactionWithWriteConcernOption with data set #0 (Closure Object (...), 'rw')
Failed asserting that exception of type "MongoDB\Exception\UnsupportedException" is thrown.

Ignoring the writeConcern in the constructor skips the exception thrown in Aggregate::execute()

collectionMethodClosures() includes the following aggregate() call, which is classified as a read and write:
[
    function ($collection, $session, $options = []): void {
        $collection->aggregate(
            [['$match' => ['_id' => ['$lt' => 3]]]],
            ['session' => $session] + $options
        );
    }, 'rw',
],

Can you try changing "rw" there to "r" and creating a second copy with an actual write stage (e.g. $out) with "rw" changed to "w"? That might overcome the unsetting of writeConcern and allow the actual exception to be triggered.


Add threads options.

Coverage increased (+0.05%) to 81.808% when pulling ad23c2b4dee1cd1146a46c8c324ba37fee60f434 on waitingHao:master into 5cdeedbf9a88bc55fc50214c3b9d7d79ca1be705 on bramp:master.

Is there a reason this PR was never merged? Would be helpful to be able to use threads with this library

@bramp on the above

ability to specify threads is very useful

Looks good other than one minor change.


增加了对文件MD5校验

增加了对文件MD5校验
create_github_issue兼容Python3

Pull Request Test Coverage Report for Build 484

9 of 52 (17.31%)  changed or added relevant lines in 3 files are covered.
21 unchanged lines in 7 files lost coverage.
Overall coverage decreased (-0.8%) to 40.753%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

cobra/init.py
1
7
14.29%

cobra/config.py
4
13
30.77%

cobra/utils.py
4
32
12.5%

Files with Coverage Reduction
New Missed Lines
%

cobra/templite.py
1
0.0%

cobra/init.py
1
27.38%

cobra/config.py
2
57.47%

cobra/utils.py
2
33.58%

cobra/log.py
3
44.93%

cobra/api.py
4
12.68%

cobra/cve.py
8
80.49%

Totals

Change from base Build 483:
-0.8%

Covered Lines:
1677

Relevant Lines:
4115

💛  - Coveralls


[Net] Fix ENet 'connect_to_host' creating only one channel.

Passing 0 to enet_host_create will allow the maximum amount of channel supported by ENet.
For some reasons, connect_to_host will instead only create 1 channel when passed 0.
This commit normalize the behaviour to always allocate the maximum allowed channels when passing 0.

Thanks!


Organize a tf_record dataset

What do you think of using a dataset fromat?
This is an example for the Mscoco object detection but could be also very similar for keypoints

Another example https://github.com/visipedia/tfrecords

Yes I undestrand but probably a tfrecords generator like this one could be quite easy to adapt on different dataset to have an unique input format.


Make DataProtection follow the Options model

This repo requires some cleanup to adapt it to the pattern we follow on other parts of the framework

@javiercn ... friendly reminder from those of us in production with bits like ...
services.AddSingleton<IXmlRepository, CustomXmlRepository>();
services.AddSingleton<IXmlEncryptor, CustomXmlEncryptor>();
services.AddSingleton<IXmlDecryptor, CustomXmlDecryptor>();

... let us know if "follow the Options model" means something is about to break (i.e., Announcements repo). Everything here is staged, but surprises can be unsettling.

@GuardRex indeed, we'll post announcements about any significant changes - and if we push this change through, it'll count as significant.

@Eilon Cool. I have several apps in production now using these bits. Although everything is staged and tested, it still puts a scare on you :skull: when something unexpectedly goes :boom:.


Boogie: update to 2018-05-28

The package failed. I fixed it and updated.

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

@GrahamcOfBorg build boogie

Failure on aarch64-linux (full log)
Attempted: boogie
Partial log (click to expand)
make[1]: *** [Makefile:374: all-recursive] Error 1
make[1]: Leaving directory '/build/libgdiplus-2.10.9'
make: *** [Makefile:279: all] Error 2
builder for '/nix/store/wzf9bkwxpjapah449vdidix247p7nk5h-libgdiplus-2.10.9.drv' failed with exit code 2
cannot build derivation '/nix/store/k0qqm5bvmb6m72lrviv1kmcwn3pdjl6j-mono-<IP_ADDRESS>.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/87l2nbh6d4frz2cb68kvixylzkgnh6kh-dotnetbuildhelpers.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/w2845c7yf7vcd47r9m1siqn5zz0x39d0-NUnit-2.6.4.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/ppk6cv7fzza4zkzyvzd3czq8rmsaxbn5-NUnit.Runners-2.6.4.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/vbc2zn9w3kjc0nb71ir52g463s938b4d-Boogie-unstable-2018-05-28.drv': 4 dependencies couldn't be built
error: build of '/nix/store/vbc2zn9w3kjc0nb71ir52g463s938b4d-Boogie-unstable-2018-05-28.drv' failed

Failure on x86_64-linux (full log)
Attempted: boogie
Partial log (click to expand)
make[1]: *** [Makefile:374: all-recursive] Error 1
make[1]: Leaving directory '/build/libgdiplus-2.10.9'
make: *** [Makefile:279: all] Error 2
builder for '/nix/store/97h8sqa3jfxxkqk1yda1gigmsyigf62x-libgdiplus-2.10.9.drv' failed with exit code 2
cannot build derivation '/nix/store/jly54xn8r41b94saiw3hq04bivygyyyv-mono-<IP_ADDRESS>.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/x5hxmdczlkc1xqzihmcpr6kfwkcwwkl6-dotnetbuildhelpers.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/11741y3r73hff5q902fhc004wjmkc2h5-NUnit-2.6.4.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/wranlr0gz8d76l1b3r22g20mvscz8yan-NUnit.Runners-2.6.4.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/p636iiamdzk69l2fkaj7y9ijnxnmy4a9-Boogie-unstable-2018-05-28.drv': 4 dependencies couldn't be built
error: build of '/nix/store/p636iiamdzk69l2fkaj7y9ijnxnmy4a9-Boogie-unstable-2018-05-28.drv' failed

Success on x86_64-darwin (full log)
Attempted: boogie
Partial log (click to expand)
Created /nix/store/pxvbjvnwch11n7gwnhss13r8paqad9pv-Boogie-unstable-2018-05-28/lib/pkgconfig/BoogieParserHelper.pc
Created /nix/store/pxvbjvnwch11n7gwnhss13r8paqad9pv-Boogie-unstable-2018-05-28/lib/pkgconfig/BoogiePredication.pc
Created /nix/store/pxvbjvnwch11n7gwnhss13r8paqad9pv-Boogie-unstable-2018-05-28/lib/pkgconfig/BoogieVCExpr.pc
Created /nix/store/pxvbjvnwch11n7gwnhss13r8paqad9pv-Boogie-unstable-2018-05-28/lib/pkgconfig/BoogieVCGeneration.pc
Created /nix/store/pxvbjvnwch11n7gwnhss13r8paqad9pv-Boogie-unstable-2018-05-28/lib/pkgconfig/Provers.SMTLib.pc
'/nix/store/pxvbjvnwch11n7gwnhss13r8paqad9pv-Boogie-unstable-2018-05-28/lib/dotnet/Boogie/z3.exe' -> '/nix/store/qd8ph6bf2d5fcl4d849q9f1pyshfwsnb-z3-4.6.0/bin/z3'
glibPreFixupPhase
post-installation fixup
patching script interpreter paths in /nix/store/pxvbjvnwch11n7gwnhss13r8paqad9pv-Boogie-unstable-2018-05-28
/nix/store/pxvbjvnwch11n7gwnhss13r8paqad9pv-Boogie-unstable-2018-05-28

#41187 should fix the failing dependencies.

@GrahamcOfBorg build boogie

Success on x86_64-linux (full log)
Attempted: boogie
Partial log (click to expand)
Created /nix/store/pxnhgibql28y0nfffgmpq7s324s6g5b0-Boogie-unstable-2018-05-28/lib/pkgconfig/BoogieVCExpr.pc
Created /nix/store/pxnhgibql28y0nfffgmpq7s324s6g5b0-Boogie-unstable-2018-05-28/lib/pkgconfig/BoogieVCGeneration.pc
Created /nix/store/pxnhgibql28y0nfffgmpq7s324s6g5b0-Boogie-unstable-2018-05-28/lib/pkgconfig/Provers.SMTLib.pc
'/nix/store/pxnhgibql28y0nfffgmpq7s324s6g5b0-Boogie-unstable-2018-05-28/lib/dotnet/Boogie/z3.exe' -> '/nix/store/y65qiharylqvvqjklv8bh1bcbwm74j5i-z3-4.6.0/bin/z3'
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/pxnhgibql28y0nfffgmpq7s324s6g5b0-Boogie-unstable-2018-05-28
patching script interpreter paths in /nix/store/pxnhgibql28y0nfffgmpq7s324s6g5b0-Boogie-unstable-2018-05-28
checking for references to /build in /nix/store/pxnhgibql28y0nfffgmpq7s324s6g5b0-Boogie-unstable-2018-05-28...
/nix/store/pxnhgibql28y0nfffgmpq7s324s6g5b0-Boogie-unstable-2018-05-28

Success on x86_64-darwin (full log)
Attempted: boogie
Partial log (click to expand)
Created /nix/store/rh9jrj51v0d18pjgdn055b55ca4v3nlq-Boogie-unstable-2018-05-28/lib/pkgconfig/BoogieParserHelper.pc
Created /nix/store/rh9jrj51v0d18pjgdn055b55ca4v3nlq-Boogie-unstable-2018-05-28/lib/pkgconfig/BoogiePredication.pc
Created /nix/store/rh9jrj51v0d18pjgdn055b55ca4v3nlq-Boogie-unstable-2018-05-28/lib/pkgconfig/BoogieVCExpr.pc
Created /nix/store/rh9jrj51v0d18pjgdn055b55ca4v3nlq-Boogie-unstable-2018-05-28/lib/pkgconfig/BoogieVCGeneration.pc
Created /nix/store/rh9jrj51v0d18pjgdn055b55ca4v3nlq-Boogie-unstable-2018-05-28/lib/pkgconfig/Provers.SMTLib.pc
'/nix/store/rh9jrj51v0d18pjgdn055b55ca4v3nlq-Boogie-unstable-2018-05-28/lib/dotnet/Boogie/z3.exe' -> '/nix/store/qd8ph6bf2d5fcl4d849q9f1pyshfwsnb-z3-4.6.0/bin/z3'
glibPreFixupPhase
post-installation fixup
patching script interpreter paths in /nix/store/rh9jrj51v0d18pjgdn055b55ca4v3nlq-Boogie-unstable-2018-05-28
/nix/store/rh9jrj51v0d18pjgdn055b55ca4v3nlq-Boogie-unstable-2018-05-28

Failure on aarch64-linux (full log)
Attempted: boogie
Partial log (click to expand)
make[2]: Leaving directory '/build/mono-<IP_ADDRESS>/runtime'
make[1]: *** [Makefile:549: all-recursive] Error 1
make[1]: Leaving directory '/build/mono-<IP_ADDRESS>'
make: *** [Makefile:479: all] Error 2
builder for '/nix/store/zxm7bilfqp4yx159cvfg154mki9lv5bf-mono-<IP_ADDRESS>.drv' failed with exit code 2
cannot build derivation '/nix/store/wspq7jhw0wbiwj6qbpzg22y4b0rgcnmz-dotnetbuildhelpers.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/01fmm7hqp7xmvg3mc1wn4gf8k1sa78dj-NUnit-2.6.4.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/lpfpfkwa31bdw0pizfxv5slpfwxdflv8-NUnit.Runners-2.6.4.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/sj24irawn7ga3i6qmjwb5ymfn4fyhp2i-Boogie-unstable-2018-05-28.drv': 4 dependencies couldn't be built
error: build of '/nix/store/sj24irawn7ga3i6qmjwb5ymfn4fyhp2i-Boogie-unstable-2018-05-28.drv' failed

Thanks !


fix: dynamic memoization calls

Related to https://github.com/Safe-DS/DSL/issues/1013

introduces a new memoized_dynamic_call function, that fetches the callable from the provided instance (receiver), calculates a new fully qualified function name for the dynamic call and forwards everything to the memoization map

:tada: This PR is included in version 0.8.1 :tada:
The release is available on:

v0.8.1
GitHub release

Your semantic-release bot :package::rocket:


Add .gitignore for apropriate files

The .gitignore file might help unclutter this repository of redundant and useless files.
I suggest adding:
# Byte-compiled
__pycache__/

# Jupyter Notebook
.ipynb_checkpoints

# Environments
.env
.venv
env/
venv/
ENV/
env.bak/
venv.bak/
.vscode/

And deleting all already existing files from the repository (they can stay at your local clone, but will no longer be synchronized when committing).
Not all listed things are present, but might be accidentally committed in the future. This list was inspired by this. If you have any suggestions, please comment.

Perfect! Just add the gitignore and close the issue.

I cleaned the repo of useless files and added the .gitignore file. From now on, if you create some of the files indexed in .gitignore, they will not be synchronized with the repo.
In case some files that do not belong to the repository appear in your commit, add corresponding file or folder name to the .gitignore (or ask someone to do it if you are not sure how). In GitHub Desktop, you can each time uncheck any changes that you do not want to commit, so use this feature on those files until the .gitignore file is updated.


⚠ St. Lawrence Global Observatory CKAN has degraded performance

In a83c6b4, St. Lawrence Global Observatory CKAN (https://catalogue.ogsl.ca/en/) experienced degraded performance:

HTTP code: 200
Response time: 9013 ms

Resolved: St. Lawrence Global Observatory CKAN performance has improved in dacc71b after 17 minutes.


Support for last refresh date of a flow

Is there an end point to get the last refresh date time for a prep flow?
Trying to build code for automatic triggering flow refresh if data source data is updated after last refresh time for flow

Support for pulling information about flow runs in #884

This change was in https://github.com/tableau/server-client-python/releases/tag/v0.17.0


Update 00-n4m-intro.md

Removed internal links that may contain private data or are not relevant for public, changed others to public sources. #180 Homogenized links to partners. Clarified the difference between Partner and Member.

#224


[Question] - Is it possible to add some more details about this service in the readme file?

I am trying to evaluate if we need this service for NS Gov. (On a side note - We are building an issuer kit for Nova Scotia with a slightly different architecture so trying to understand if we can leverage this service.)
I was wondering if it is possible to add the following details to the readme file.

Overview of this service in the broader context. (If possible some architecture diagram) 😀
API docs for utilizing this service.

The reason for the question is, I am curious if this service is actually used for video verification as shown in the youtube video

Thank you!

The visual verifier does not provide video verification as depicted in the video above, I provides a very simplified view of a persons presented credentials for visual verification and approval (screenshot below).  It is part of the Safe Entry BC Demo.  You can see it in action by walking through the demo; https://digital.gov.bc.ca/digital-trust/projects-and-initiatives/safe-entry-bc-demo/
A list of components that go into the Safe Entry BC Demo can be found here; https://github.com/bcgov/essential-services-delivery

Ahh that makes sense! Thank you so much for the thorough explanation. 🙏


⚠ AVS (kty) has degraded performance

In fa7ec11, AVS (kty) (https://avus.com.br) experienced degraded performance:

HTTP code: 200
Response time: 8081 ms

Resolved: AVS (kty) performance has improved in 508076d.


Force Jenkins to run tests [WIP]

This commit is simply to see if Jenkins breaks GitHub builds on test
failures or not, and should never end up on the master branch.

This failed, which means the test passed successfully :boom:


Basic tests for TaskQueue features

I think this might be a better way to do the second test, though please let me know if my test tests things differently from what you were testing.
  it("will execute tasks in the correct order", done => {
    let task1HasRun = false;
    let task1 = () => {
      task1HasRun = true;
    };
    let task2 = () => {
      if(task1HasRun === true){
        done();
      }
    };

    let queue = new TaskQueue();
    queue.queueTask(task1);
    queue.queueTask(task2);
  });

Thoughts?

Sounds good - I wasn't sure if this behavior was guaranteed, but it is good to know the ordering is enforced.

Could you update your commit messages to follow the preferred format for the project, please. It's located here: https://github.com/DurandalProject/about/blob/master/CONTRIBUTING.md#commit
In your case, test(task-queue): basic tests for task-queue features would likely suffice.
Thanks, it's great to work with you!

Updated correctly, I believe. I won't let that happen again. :)

No problem :) Great to see you here Scott. Thanks for the contribution. I'll take a look at it shortly.

@AshleyGrant The way your test is written, if the tasks dont execute in the right order, the test will fail only when it times out. I think it would be better to use
let task2 = () => {
   expect(tast1HasRun).toEqual(true);
   done();
};

so that the test will fail immediately if false.

Good point. I missed that.

@OdeToCode Just to notify you of the above comments, so that you can update the tests.

Thanks, @tyrsius, squished it in.

@OdeToCode Thanks for getting the ball rolling with some tests on this!


Fixes issue #240 - Locks down bower ionicons to stable 2.0.1

Locks down ionicons to stable 2.0.1 as per issue #240 comments.
See this:
https://github.com/avanzu/AdminThemeBundle/issues/240
https://github.com/ionic-team/ionicons/releases?after=v4.0.0-10

@xmontero thanks for your PR!


using angle function and pi

Problem
You all know
sin(pi) = 0
cos(pi/2) = 0
tan(pi/4) = 1
I know it is a rounding problem but the result will be only close to the values above. That could lead to problems in calculations.
Real output right now:
sin(pi) = 122..E-16
cos(pi/2) = 6.12...E-17
tan(pi/4) = 0.999999
Possible solution:
Add a rounding option to the build ExpressionBuilder for angle functions. So i can say round the result of  sin/cos/tan to a given numbers after the comma.

As a matter of fact sin(pi) is calculating exactly Math.sin(Math.PI) which is what the IEEE 754 (and therefore Java) specify as output.
The thing is: exp4j is used in numerical calculations, so changing the output (like rounding) to accommodate the result to a "politically correct" value can be very damaging (results need to be reproducible).
There are several options to show the "expected" results (you should use them regardless of exp4j when displaying floats):

wrap the expression in a round(...)
use String.format("%5.2f", exp.evaluate()) //Or the combination you prefer
use NumberFormatter
round the value to the number of digits you consider good enough like:
Math.round(num * 100) / 100. //<-2 decimal places rounding

Regards!

@swalesch:
Since these rounding errors are due to the floating point representation in the memory I do feel reluctant to add this as a feature. But it is certainly possible to add your own trigonometric function to exp4j using the custom function feature.
Something like this should work:
        Expression e = new ExpressionBuilder(("rndsin(pi, 5)"))
                .function(new Function("rndsin", 2) {
                    @Override
                    public double apply(double... args) {
                        double scale=Math.pow(10,args[1]);
                        return Math.round(Math.sin(args[0]) * scale) / scale;
                    }
                })
                .build();
        System.out.printf("Result: %f", e.evaluate());

Hope this helps,
Frank

oh well i did not see that option, of cause that will solve the problem!
so i will just overwrite the function for sin/cos/tan ... that worked for me
thanks! You can close this issue


Feature request: dry run functionality

For my CI pipeline, I would like to be able to dry run migrations so that I can show what migrations will run, then request approval from the user, then run them (not withstanding that there might be some change in between). The simplest form of this would be just a boolean config option  passed to migrate called dryRun. If true, then instead of running the migrations we would just log a list of the migrations that will be run like the below. I guess ideally the migrations would be validated properly too but this isn's essential for my use case.
It could either output something like this
Migrations to be run:
003-some_migration.sql
004-some_other_migration.sql

or concatenate the file contents and output the actual sql.
I'm happy to raise a PR for this if there is an appetite for it...

@MatthewBurstein, I have an appetite for it as I have the same use cases as yours.


Display notification with details about yellow errors in modal window

When a yellow error happen in the modal window (See details), a notification could be shown stating the actual reason for the error.
The main challenge is for me to find such an item in Canada to code the solution.

I'll keep a look out here in the US for a yellow error item... There have however been 2 RED errors recently and I thought it was just me, but a reddit thread said it wound up being everyone that tried it.

Seems those errors mainly happen to item that were just removed from enrollment. Have yet to capture one.


Styling

Hello,
Can you please tell me how to apply my own styling on this component?

Use this for styling
import 'react-add-to-calendar/dist/react-add-to-calendar.css'


Moving the sort_by parameter specification as an OpenAPI deep object.

Moving the sort_by parameter specification as an OpenAPI deep object.

This is to get around an issue with the OpenAPI Client Generator not properly
handling the OneOf spec directive.

Needed to move the validation of the sort_by parameter into the PaginatedResponse
class where it is used.

Solves: TPINVTRY-864
Related PRs:

https://github.com/RedHatInsights/topological_inventory-api/pull/282
https://github.com/RedHatInsights/sources-api/pull/188

/cc @mkanoor for you.

👍 Looks good
went from
opts = {
  limit: 100, # Integer | The numbers of items to return per page.
  offset: 0, # Integer | The number of items to skip before starting to collect the result set.
  filter: nil, # Object | Filter for querying collections.
  sort_by: TopologicalInventoryApiClient::OneOfstringarray.new # OneOfstringarray | The list of attribute and order to sort the result set by.
}

to
opts = {
  limit: 100, # Integer | The numbers of items to return per page.
  offset: 0, # Integer | The number of items to skip before starting to collect the result set.
  filter: nil, # Object | Filter for querying collections.
  sort_by: nil # Object | The list of attribute and order to sort the result set by.
}

Closing in preference for #165


Cannot run config file

Hi
Following the compilation instructions I've installed verything (msys2 yasm etc..), set up the environment variables, checked with "which" where the cl command was pointing at, check my PATH but nothing worked. I keep on getting
WARNING: pkg-config not found, library detection may fail.
mktemp -u XXXXXX
ZYw84V
WARNING: Unknown C compiler cl, unable to select optimal CFLAGS
check_ld cc
check_cc
BEGIN ./ffconf.oc8wxDOw.c
1	int main(void){ return 0; }
END ./ffconf.oc8wxDOw.c
cl -MD -DWINAPI_FAMILY=WINAPI_FAMILY_PC_APP -D_WIN32_WINNT=0x0603 -c -o ./ffconf.T0zVIMc6.o ./ffconf.oc8wxDOw.c
../../../configure: line 822: cl: command not found
C compiler test failed.
I just want to compile ffmpeg without even the interop part as I don't really need it. Could you please give me any hint on what could be going on ?
Thanks

Before you run configure in your MSYS2 shell, what is the output of which cl in the same shell?
Could you also share your Visual Studio and Windows 10 SDK/tools version?


sys.dm_cdc_log_scan_sessions is not linked from System Dynamic Management Views

https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/relational-databases/system-dynamic-management-views/change-data-capture-sys-dm-cdc-log-scan-sessions.md
sys.dm_cdc_log_scan_sessions is not linked from https://docs.microsoft.com/en-us/sql/relational-databases/system-dynamic-management-views/system-dynamic-management-views.
I think a page like https://docs.microsoft.com/en-us/sql/relational-databases/system-dynamic-management-views/common-language-runtime-related-dynamic-management-views-transact-sql is also needed for Change Data Capture.

@tcna Hello, we are no longer in favor of articles that have lists of links that the Table Of Contents (TOC) already supplies.    So we will not be making the update suggested in this Issue 1836.
But I certainly see why you suggested it, your suggestion is logical.
Thanks.  Closing now.

Oops, Closing now.


Remove 'withNavigationFallback.js' HOC

Details

Initially, this PR was related to the migration of 'withNavigationFallback.js' HOC to TypeScript. During review the discussion was raised, and as a result, we came up with removing the withNavigationFallback HOC.
Fixed Issues

$ https://github.com/Expensify/App/issues/24953
PROPOSAL: N/A
Tests

[x] Verify that no errors appear in the JS console

First case: Button component. It uses isFocused param in the keypress handler for pressing the button with the Enter key. You can test that it works as expected:

In the sidebar, press the Add (plus) button -> Request Money.
Select the Manual tab.
Enter the amount of money and press the Enter key -> you should be navigated to the next step.
Select the user to split the request with -> the next step will be opened.
Press Enter -> Money Request should be created.

Second case: Button component in Storybook:

Open Storybook
Select Button -> Press On Enter
Press Enter key and make sure the button works

Third case: Composer component in Storybook:

Open Storybook
Select Composer -> Default
Make sure there are no errors about the navigation container

Offline tests

N/A
QA Steps

[x] Verify that no errors appear in the JS console

First case: Button component. It uses isFocused param in the keypress handler for pressing the button with the Enter key. You can test that it works as expected:

In the sidebar, press the Add (plus) button -> Request Money.
Select the Manual tab.
Enter the amount of money and press the Enter key -> you should be navigated to the next step.
Select the user to split the request with -> the next step will be opened.
Press Enter -> Money Request should be created.

Second case: Button component in Storybook:

Open Storybook
Select Button -> Press On Enter
Press Enter key and make sure the button works

Third case: Composer component in Storybook:

Open Storybook
Select Composer -> Default
Make sure there are no errors about the navigation container

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Storybook
https://github.com/Expensify/App/assets/23176449/2a6d49c7-2271-446d-8a85-2bc9460ff4e4

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/23176449/3d45558b-66eb-463d-9ccf-8c1b9e88a0d1
https://github.com/Expensify/App/assets/23176449/c3af1571-364b-49d2-9534-21c6c237f85f

MacOS: Desktop

https://github.com/Expensify/App/assets/23176449/bcc237c0-2d71-4dc3-b0a7-0cc73da07e1d

This HOC looks like a workaround to me, imo the best would be to remove it from the codebase completely. Raised a discussion on the open source channel here

@blazejkustra I've updated the PR, let me know what you think, please

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/4160319/4cf3353f-2684-4ede-8ec3-7dcc4f023d96
https://github.com/Expensify/App/assets/4160319/ff1c6fae-f18a-4c7e-8fd2-fc8f50759601
https://github.com/Expensify/App/assets/4160319/40328eb1-d27e-464b-8627-8aa22358eafb

Mobile Web - Chrome

Mobile Web - Safari

Desktop
https://github.com/Expensify/App/assets/4160319/e74c2f70-7e58-4178-b6ea-9b4cae4ed515

iOS

Android

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/techievivek in version: 1.3.86-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.86-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Move corefx to latest release/2.0.0 commit

Remove unnecessary patch and update another patch to align with the move.
This will enable corefx to build on windows and should fix https://github.com/dotnet/source-build/issues/106.

Looks like my move of corefx fixed the windows build for that project but broke the update dependencies on the other OS's. I will investigate further and update the other steps.


Failed to install Brackets.Release.1.12.64-bit on Ubuntu 18.10 x64

Well, I failed to install Brackets.Release.1.12.64-bit
Att. log’s and some information.
`smartwebdev@smartwebdev-notebook-ubuntu:~$ sudo -i
root@smartwebdev-notebook-ubuntu:~# dpkg -i '/home/smartwebdev/Downloads/Brackets.Release.1.13.64-bit.deb'
Selecting previously unselected package brackets.
(Reading database ... 167945 files and directories currently installed.)
Preparing to unpack .../Brackets.Release.1.13.64-bit.deb ...
Unpacking brackets (1.13.0-17696) ...
dpkg: dependency problems prevent configuration of brackets:
brackets depends on gconf-service; however:
Package gconf-service is not installed.
brackets depends on libgconf-2-4 (>= 2.31.1); however:
Package libgconf-2-4 is not installed.
brackets depends on libgtk2.0-0 (>= 2.24.0); however:
Package libgtk2.0-0 is not installed.
brackets depends on libpango1.0-0 (>= 1.22.0); however:
Package libpango1.0-0 is not installed.
brackets depends on libcurl3; however:
Package libcurl3 is not installed.
dpkg: error processing package brackets (--install):
dependency problems - leaving unconfigured
Processing triggers for hicolor-icon-theme (0.17-2) ...
Errors were encountered while processing:
brackets
Well, it can be resolve via install folloing components :gconf-service, libgconf-2-4, libgtk2.0-0, libpango1.0-0, libcurl3.`
For installing this compomnents first – I switch to previligated user to run shell commands as auper user
sudo -i
After I have run following commands :
sudo apt install gconf-service sudo apt install libgconf-2-4 sudo apt install libgtk2.0-0 sudo apt install libpango1.0-0 sudo apt install libcurl3
All of components, EXCEPTing libcurl3 was installed.
Well, in Ubuntu 18.10 imposible install libcurl3 as I can see.
I think this problemm will be mass for beginers as me, and I will be realy helpfuel to get support from community or software developer.
Appreciated. Peter.

I have libcurl4 installed but to no avail. Bracket.io doesn't seem to be compatiable with libcurl4
Package libcurl3 is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source
However the following packages replace it:
libcurl4:i386 libcurl4
E: Package 'libcurl3' has no installation candidate
someone@caslab-:/$ sudo apt install libcurl4
Reading package lists... Done
Building dependency tree
Reading state information... Done
libcurl4 is already the newest version (7.61.0-1ubuntu2.2).
someone@caslab:/$ sudo dpkg -i ~/Downloads/Brackets.Release.1.13.64-bit.deb
(Reading database ... 335581 files and directories currently installed.)
Preparing to unpack .../Brackets.Release.1.13.64-bit.deb ...
Unpacking brackets (1.13.0-17696) over (1.13.0-17696) ...
dpkg: dependency problems prevent configuration of brackets:
brackets depends on libcurl3; however:
Package libcurl3 is not installed.
dpkg: error processing package brackets (--install):
dependency problems - leaving unconfigured
Processing triggers for hicolor-icon-theme (0.17-2) ...
Errors were encountered while processing:
brackets

The same happens to me on Ubuntu 18.04.

@smartwebdever , @carolsand , @Qik000
The Brackets build requires libcurl3, while Ubuntu & Mint switched to libcurl4.
Until they fix the Brackets build (which is taking an absurdly long time), you need to unpack the Brackets build, change dependency and repack.
Instructions here: https://github.com/adobe/brackets/issues/14338#issuecomment-400378169


feat: stabilized generics

Closes #583

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.004%) to 89.909%

Totals

Change from base Build<PHONE_NUMBER>2:
-0.004%

Covered Lines:
3000

Relevant Lines:
3218

💛  - Coveralls


Change path-name convention shredder uses to be same as needed by filtering (no need to de-shred)

Originally super-shredder path names were thought to be needed to allow "de-shredding" -- re-building of the source document from shredded paths.  This is why path to value '5' in:
{ "array" : [ 5 ] }

would become array.[0], escaped so that path is never ambiguous, even if property name contained . (allowed in later Mongo versions) or opening bracket (likewise legal).
But Mongo filtering clauses use simpler, potentially ambiguous notation: array.0.
Although we could of course convert from array.0 into array.[0] it makes more sense to simplify shredded paths because:

There is no need to "de-shred" (we store the full document)
Avoiding conversion is not only more efficient but also removes possible error modes.

Question to explore is can SAI index search of wild card for map key, if so we may not need the array_contains.
Like query_xxx_values['array.*] = 5
@amorton Can we check if this is a possibility?

It would not be possible, maybe something to add later if / when we create a full JSON type in C*


django-static try overwrite target of symlink

I have set my deployment this way: the code is in /usr/local/src/$project.
Gunicorn is running under a non-root user.
the path are set that the source where django-static get it's static file is in a different directory than slimmed, compiled or simply symlinked file.
It can only create new content and never write original files.
But, I have this weird behavior I've seed 5-6 times, where django-static try to open a symlink as a regular file
and write data into it.
It might be caused by some manipulation I made. Sometimes I replace:
{% slimall %}
<script src="file1.js"></script>
<script src="file2.js"></script>
{% endslimall %}

by:
<script src="{% staticfile "file1.js" %}"></script>
<script src="{% staticfile "file1.js" %}"></script>

so I get unmodified .js and can troubleshoot javascript errors easily.
when the problem happens this is raised exception:
Traceback (most recent call last):

 File "/usr/local/src/radiopirate/eggs/Django-1.2.7-py2.7.egg/django/core/handlers/base.py", line 100, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/usr/local/src/radiopirate/horfunk/radiopirate/views/__init__.py", line 20, in index
   return render_to_response(template, context)

 File "/usr/local/src/radiopirate/eggs/Django-1.2.7-py2.7.egg/django/shortcuts/__init__.py", line 20, in render_to_response
   return HttpResponse(loader.render_to_string(*args, **kwargs), **httpresponse_kwargs)

 File "/usr/local/src/radiopirate/eggs/Django-1.2.7-py2.7.egg/django/template/loader.py", line 183, in render_to_string
   return t.render(Context(dictionary))

 File "/usr/local/src/radiopirate/eggs/Django-1.2.7-py2.7.egg/django/template/__init__.py", line 173, in render
   return self._render(context)

 File "/usr/local/src/radiopirate/eggs/Django-1.2.7-py2.7.egg/django/template/__init__.py", line 167, in _render
   return self.nodelist.render(context)

 File "/usr/local/src/radiopirate/eggs/Django-1.2.7-py2.7.egg/django/template/__init__.py", line 796, in render
   bits.append(self.render_node(node, context))

 File "/usr/local/src/radiopirate/eggs/Django-1.2.7-py2.7.egg/django/template/__init__.py", line 809, in render_node
   return node.render(context)

 File "/usr/local/src/radiopirate/eggs/Django-1.2.7-py2.7.egg/django/template/loader_tags.py", line 125, in render
   return compiled_parent._render(context)

 File "/usr/local/src/radiopirate/eggs/Django-1.2.7-py2.7.egg/django/template/__init__.py", line 167, in _render
   return self.nodelist.render(context)

 File "/usr/local/src/radiopirate/eggs/Django-1.2.7-py2.7.egg/django/template/__init__.py", line 796, in render
   bits.append(self.render_node(node, context))

 File "/usr/local/src/radiopirate/eggs/Django-1.2.7-py2.7.egg/django/template/__init__.py", line 809, in render_node
   return node.render(context)

 File "/usr/local/src/radiopirate/lib/python2.7/site-packages/django_static-1.5.5-py2.7.egg/django_static/templatetags/django_static.py", line 208, in render
   symlink_if_possible=self.symlink_if_possible)

 File "/usr/local/src/radiopirate/lib/python2.7/site-packages/django_static-1.5.5-py2.7.egg/django_static/templatetags/django_static.py", line 555, in _static_file
   codecs.open(new_filepath, 'w', 'utf-8').write(content)

 File "/usr/local/src/radiopirate/lib/python2.7/codecs.py", line 881, in open
   file = __builtin__.open(filename, mode, buffering)

IOError: [Errno 13] Permission denied: u'/var/lib/radiopirate/cache/css/blueprint/screen.1318293843.css'

the symlink point to elsewhere and is not writable by gunicorn user

I found it, it is caused when you first have this:
{% staticfile "abc.js" %}
and replace it after template had been rendered by:
{% slimfile "abc.js" %}
fix:
https://github.com/bclermont/django-static/commit/fb21cb00b167cb7d5ee1d70e8e6229e356639638


Fail to build C API with clang

src/bvh/v2/bvh.h:173:21: error: no member named 'make_tuple' in namespace 'std'
  173 |         return std::make_tuple(
      |                ~~~~~^
src/bvh/v2/c_api/bvh_impl.h:31:32: error: missing 'typename' prior to dependent type name 'bvh::v2::DefaultBuilder<bvh::v2::Node<T, Dim>>::Quality'
            return static_cast<bvh::v2::DefaultBuilder<bvh::v2::Node<T, Dim>>::Quality>(quality);
                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                               typename

Seems adding #include <tuple> and typename would help

Thank you for the bug report. Strangely enough, I could not reproduce this issue on my local machine, nor on GitHub's CI. I have nevertheless added the corresponding #include and typename in commit 77a08ca. If that does not solve the problem, please re-open this issue.


Josharias' Survival In-Game Help "Items" tab crashes Terasology

"NoSuchMethodError org.terasology.gestalt.assets.ResourceUrn"
What you were trying to do
Click on the "Items" tab in the Josharias' Survival in-game help screen.
What actually happened
Terasology crashed
How to reproduce

Start Terasology preview alpha 20+271 (20210615)
Start Josharias' Survival
Open the in-game help screen (P)
Click on the "Items" tab

Log details and game version
Version: preview alpha 20+271 (20210615)
Logs:
19:46:21.326 [main] ERROR o.t.engine.core.TerasologyEngine - Uncaught exception, attempting clean game shutdown
java.lang.NoSuchMethodError: 'org.terasology.gestalt.assets.ResourceUrn org.terasology.engine.rendering.assets.texture.TextureUtil.getTextureUriForColor(org.terasology.nui.Color)'
    at org.terasology.irlCorp.systems.MechanicalPowerToolClientSystem.drawPowerToolPowerBar(MechanicalPowerToolClientSystem.java:67)

Discord user wolfsujiyama reported this today.

For some reason it seems that org.terasology.gestalt.assets.ResourceUrn is not known in IRLCorp::MechanicalPowerToolClientSystem or engine::TextureUtil :thinking:

Seems this was a mismatch on binary level.
Rebuilding IRLCorp and triggering another preview release resolved this.

Also happens if you use a bucket in Josharias' Survival in 5.1.1.
java.lang.NoSuchMethodError: 'org.terasology.gestalt.assets.ResourceUrn org.terasology.engine.rendering.assets.texture.TextureUtil.getTextureUriForColor(org.terasology.nui.Color)'
	at org.terasology.fluid.system.FluidClientSystem.drawFillingBarForFluidContainerItem(FluidClientSystem.java:147)
	at org.terasology.fluid.system.FluidClientSystemMethodAccess.invoke(Unknown Source)

Also happens if you use a bucket in Josharias' Survival in 5.1.1.
java.lang.NoSuchMethodError: 'org.terasology.gestalt.assets.ResourceUrn org.terasology.engine.rendering.assets.texture.TextureUtil.getTextureUriForColor(org.terasology.nui.Color)'
	at org.terasology.fluid.system.FluidClientSystem.drawFillingBarForFluidContainerItem(FluidClientSystem.java:147)
	at org.terasology.fluid.system.FluidClientSystemMethodAccess.invoke(Unknown Source)

Based on the earlier occurrence, I'm guessing the Fluid module needed rebuilding :thinking:

Open a separate issue or just use this one?

Open a separate issue or just use this one?

Good question. Theoretically, re-opening this one would be fine. I don't expect us to do a 5.1.2 to fix that as we still do not really support reproducible builds, so I'd like to target the 5.2.0 milestone. We could adjust the milestone linked on this issue, but maybe then it's better to just create a new one.
In the end, I don't think it matters much. Reason being that I'd rather see this as an issue that needs verifying on whether it's present in the release candidate we'll do this weekend and if so, re-build the module and check if it's still there (expectation: it won't). Ideally I guess we might want to build all omega modules freshly whenever we release omega - currently afaik we only take the latest releases we find in the artifactory, right @Cervator @keturn ?

I'll go ahead and open a new one for those very good points.


Detect that cert-manager is installed and fail kudo init if not

What would you like to be added:
Current webhook implementation relies on cert-manager as a dependency. It had to be installed in the cluster otherwise the webhook won't work. We should check that cert-manager is installed when running kudo init with --enable-validation and fail init if the dependency is missing (be sure to check also that it's cert-manager in the right version).
Why is this needed:

Is it enough to validate the existence and apiVersion of the "Certificate" and "Issuer" CRDs, i.e. the ones that we try to install? Or do we have to validate the actual cert-manager version?
I would assume a check of the CRDs should be enough, right?

I think we need to check both CRDs installed and cert-manager pods are running, as crds by itself are not enough

Hmmmm. Checking if the cert-manager pods are running would probably require for us to know the namespace in which the cert-manager controller is running, which would require an additional cmd-line parameter just for the check.
I would argue that the installed CRDs should provide evidence that the cert-manager is installed in the cluster, and it's not really the responsibility of the KUDO installation process to verify that cert-manager is working correctly.

I think cert-manager by default goes into cert-manager namespace, we can check that. If people use some custom namespace, I guess we can provide something like --skip-check for kudo init to be able just proceed because "they know what they are doing" :D WDYT?

I'd rather introduce optional checks, I think, in the same vein as the package verify command has errors and warnings. I'm not sure it makes sense to add a --skip-checks, at least in this case, as if the CRDs for cert-manager are not installed, we will fail the installation in any case.
If the cert manager CRDs are installed, but the controller is not running, we can finish the installation, but KUDO will not work (or at least the webhook part).
I do agree that it would be kind of nice to have a check for the running cert-manager, but I don't know if it's worth the effort. At some point users still have to debug their installation if something is not working.

oh yeah, I was kind of thinking this would be part of the "check" command. And I think in that case we should check exhaustively, I mean saying everything is good and then kudo not working is almost worse than not saying anything.
Unfortunately here if installed with webhook, when cert-manager is not present, kudo won't work at all, because all instance CRD requests will be denied and that would harm the experience for anyone trying kudo A LOT. And since we want to have webhook mandatory SOON, I think we should do our best really verifying KUDO will work otherwise they will blame KUDO because it's very poor first experience.

Yeah, providing a poor first experience is something we certainly should avoid.
What do you think about the split into errors and warnings on the setup checks? That would allow us the avoid the --skip-checks (at least for now) and still provide meaningful information if we can't verify that the cert-manager is running

yeah, I like that. I guess we should then:

fail init if crds are not installed
fail init if there's cert-manager namespace but the pods are not in running state
fail init if cert-manager is of wrong version
warn if we cannot verify version/pods for cert-manager

I guess in the future we should also provide a way to start webhook installation without cert-manager - I mean you can provide the cert even in a different way, but that's definitely a different issue :)

👍 Sounds good to me, i'll work on that tomorrow.

Oh, one thing though: I don't know if we can really check the cert-manager version: We can check:

The CRD apiVersion,
We could check the pod-image, but that could be a bit too specific.

I'll try to find out if we can get some other kind of version somehow.

Yeah I guess we would have to read that from the image, they seem to be versioning them nicely


RichText embedding Nodes

It's been needed for Kepler's Laws to be able to embed Nodes within a RichText.
I'm adding <node id="..."/> support to RichText. In addition, it will support an additional align="..." to vertically align the Node within the text.

Implemented above, with some additional RichText cleanup and features. @zepumph are you available to review?
Additionally, @AgustinVallejo, let's look into using this for the Kepler's Laws readouts.

Example: http://localhost/scenery/tests/sandbox.html?script=const rect %3D new Rectangle( 0%2C 0%2C 50%2C 50%2C { fill%3A 'red' } )%3B

const richText %3D new RichText( 'Center a node%3A <node id%3D"rect" align%3D"center"%2F>%2C DAG it to top%3A <node id%3D"rect" align%3D"top"%2F> or use origin%3A <node id%3D"rect" align%3D"origin">'%2C {
  nodes%3A {
    rect%3A rect
  }
} )%3B

scene.addChild( richText )%3B

There are 7 classes in RichText, do you think that they should be factored out into separate files? Perhaps all under nodes/rich-text?

Would that move RichText itself? It currently seems a bit cleaner to have it in one file to me, but I'm also fine to separate it out. We'd also need some files for things like RichTextCleanable.

Not a huge deal, but it would have been nice if the initialization refactor wasn't in the same commit.

Sorry about that!

Why can _links be of type true?

Updated docs above (moving the docs from setLinks to the links option). It allows literal HREFs to be specified (and will be rendered), instead of placeholders.

Do you still agree that we should not turn this lint rule on (grouped-accessor-pairs)?

It's a bit nice to be able to modify the order, I forget original decisions on this.

Can you say a few words about why it is better to have links and nodes be graceful if that value isn't provided via an option? That feels like a prime place for an assertion to me.

Would it go both ways, where an option in either would be an assertion failure? We need to make sure it's not an error (so that translators can't prevent the sim from running).
I'll look into it.

Assertions added above.

There are 7 classes in RichText, do you think that they should be factored out into separate files? Perhaps all under nodes/rich-text?

Actually, it makes sense to me for these to be split for usability (reversing my preference earlier). I'll handle this, but I'll probably put the other bits under util, and leave RichText where it is.

It seems confusing why RichTextNode needs leftSpacing and rightSpacing when RichTextLink does not. Why can't this feature be part of some supertype so that RichTextNode doesn't need to "stub" it like this.

Added docs about this. Basically RichTextLink isn't participating in the layout, so it doesn't need to store that information.

Split RichText up above. Can you review comments and commits?

Oh also, could you make a separate issue for the investigation you'd like to do in sim-specific code with @AgustinVallejo?

Is it weird that half of the items in RichTextUtils are top level exports, but some are under RichTextUtils?

I have to add/modify lines in imports.js for all top-level exports. This is needed for types. I think for now I'll leave as-is?
Thanks!


Fragment battery service

Refactored all battery related code into a fragment. That way we can just implement a different fragment for each device. Most of the changes are chunks of code being moved around. The only new logic is the logic to create a fragment. Please review @jyasskin @scheib

fragment_battery.xml reads awkwardly to me, but it matches activity_* and if it's how it's done, then this all LGTM.


List index out of range when running inference on multiple cases

Hi @YixingHuang, I am trying to run predictions on multiple scans. However whenever I put more than two files in configs I am getting this error. Do you have any idea how it could be solved?
========== Done with printing session's parameters ==========
=============================================================
CONFIG: The configuration file for the [session] was loaded from: /home/kucharsd/Documents/Git/DeepMedicPlus/DeepMedicPlus/examples/configFiles/deepMedicPlus/test/testConfig.cfg

ERROR: Caught exception from main process: list index out of range
Traceback (most recent call last):
  File "/home/kucharsd/Documents/Git/DeepMedicPlus/DeepMedicPlus/deepMedicRun", line 175, in <module>
    _ = session.compile_session_params_from_cfg(model_params)
  File "/home/kucharsd/Documents/Git/DeepMedicPlus/DeepMedicPlus/deepmedic/frontEnd/testSession.py", line 43, in compile_session_params_from_cfg
    self._params = TestSessionParameters(self._log,
  File "/home/kucharsd/Documents/Git/DeepMedicPlus/DeepMedicPlus/deepmedic/frontEnd/configParsing/testSessionParams.py", line 127, in __init__
    self._make_fpaths_for_preds_and_fms(out_folder_preds, out_folder_fms)
  File "/home/kucharsd/Documents/Git/DeepMedicPlus/DeepMedicPlus/deepmedic/frontEnd/configParsing/testSessionParams.py", line 135, in _make_fpaths_for_preds_and_fms
    fpaths_for_case_pred = out_folder_preds + "/" + self.out_preds_fnames[case_i]
IndexError: list index out of range

Finished.

I fixed the problem on my side.


OmniFocus 2

Hello,
I really like your themes guys, and use it on all editors that i have. (:
It would be good if someone can create theme for OmniFocus, i really will appreciate it.
Cheers,

Hey @hivearts! That would be awesome.
Have you seen this? https://github.com/dracula/dracula-theme#are-you-going-to-support-editor-x
Basically, all themes are submitted by the community, so feel free to create a pull request ;)

@zenorocha Going to open this back up with a new label so people who might be interested in creating these can see there is interest.

Ohh sorry about that ;)

I actually createda theme for OmniFocus for myself but I wasn't a big enough fan of it to share it. It doesn't match the quality of the other available app themes because Omni Focus forces a black or white main UI depending on the other colors used.

I actually createda theme for OmniFocus for myself but I wasn't a big enough fan of it to share it. It doesn't match the quality of the other available app themes because Omni Focus forces a black or white main UI depending on the other colors used.

I actually created a theme for OmniFocus for myself but I wasn't a big enough fan of it to share it. It doesn't match the quality of the other available app themes because Omni Focus forces a black or white main UI depending on the other colors used.

I actually created a theme for OmniFocus for myself but I wasn't a big enough fan of it to share it. It doesn't match the quality of the other available app themes because Omni Focus forces a black or white main UI depending on the other colors used.

Yes, black color sucks, but it's still the best theme for omnifocus that i have seen on internet.
Can you please upload a style somewhere?

@neurohacked Any chance of sharing that theme? I've recently switched over to Dracula for my universal theme and would love this.

I'm closing this issue for now due to its inactivity, but if @neurohacked is interested in sharing his theme we would love to highlight it for other people to use :)


Fix: Ignore read-only headers in DedupeResponseHeaderGatewayFilterFactory

This pull request includes one change to the DedupeResponseHeaderGatewayFilterFactory class which now ignores the headers if they are read-only.
Reason:
If the headers are read-only, the dedupe method throws UnsupportedOperationException
Solve:
If the headers are read-only, ignore it.
if (headers.getClass().getName().equals("org.springframework.http.ReadOnlyHttpHeaders")) {
    return;
}

A try-catch block may be more suitable...

Upcoming versions of framework and boot should fix the read only headers problem, so this shouldn't be needed. And you should compare classes with .class not a string compare.

Upcoming versions of framework and boot should fix the read only headers problem, so this shouldn't be needed. And you should compare classes with .class not a string compare.

I Agree but, org.springframework.http.ReadOnlyHttpHeaders is not public, it's package-private

Either way, this shouldn't be needed at all


Fix jq

Coverage remained the same at 99.196% when pulling 5acca586b542f0bb219fbc2d93f8179145ad3f91 on fix_jq into 0603329b9fa1ea4a0820f8e49ae7c28ee5aa6949 on master.


mypy (as of 0.780) doesn't like passing a Union to parse_obj_as

Bug
Output of python -c "import pydantic.utils; print(pydantic.utils.version_info())":
             pydantic version: 1.6.1
            pydantic compiled: True
                 install path: /home/.../venv/lib/python3.6/site-packages/pydantic
               python version: 3.6.9 (default, Jul 17 2020, 12:50:27)  [GCC 8.4.0]
                     platform: Linux-4.15.0-112-generic-x86_64-with-Ubuntu-18.04-bionic
     optional deps. installed: ['typing-extensions', 'email-validator']

contents of test.py:
from typing import Union

from pydantic import parse_obj_as

parse_obj_as(Union[float, int], 3.14)

$ mypy test.py
test.py:5: error: Argument 1 to "parse_obj_as" has incompatible type "object"; expected "Type[<nothing>]"
Found 1 error in 1 file (checked 1 source file)

I don't know if this is a problem with the type annotation on parse_obj_as (maybe the generic type of the first argument) or maybe with the pydantic mypy plugin.
It doesn't happen with mypy 0.770, maybe it is caused by this change in mypy 0.780. Apparently before that change Union was of type Any in a runtime context, but now it is of type object.

Things are starting to move on mypy side https://github.com/python/mypy/issues/9773 :)

I am also running into this issue. Is there a recommended way around it?

I believe this is fixed by AnalysedType (might be renamed, see #5580).

More explicitly, the right way to do this with AnalyzedType is the following:
from typing import Union

from pydantic import AnalyzedType

my_analyzed_type: AnalyzedType[Union[float, int]] = AnalyzedType(Union[float, int])
my_analyzed_type.validate_python(3.14)

Note in particular that you still awkwardly need the annotation my_analyzed_type: AnalyzedType[Union[float, int]] — this is for precisely the same reasons that parse_obj_as raised a mypy error. Instead, we do a catch-all when attempting to infer the generic parameter (Union[float, int]) that causes it to be treated as Any, but explicitly specifying the annotation will ensure it is treated by typecheckers properly.


Support updated versions of MetadataRequest

pykafka currently only supports MetadataRequest and MetadataResponse v0. It needs to handle requests from later versions of the protocol. #750 is blocked by this.

Blocked by #754


Update rust-miniscript to 8fcbeb12 (right before bitcoin 0.29 update)

This is already a nontrivial amount of work which needs to be done prior to updating rust-bitcoin and rust-elements.
I think, before doing the next step, we should port the new Locktime and Sequence data structures from rust-bitcoin to rust-elements, and do a rust-elements 0.21 release. That way we can keep all the elements-miniscript code consistent with the rust-miniscript code (which very heavily makes use of locktimes).

Merging this first. Other PRs are easy to rebase.


when i run pass_bookmarks_example.py ,i got the following error, what am i doing wrong?

D:\PythonWorkspace\test\venv\Scripts\python.exe D:/PythonWorkspace/test/pass_bookmarks_example.py
Traceback (most recent call last):
File "D:\PythonWorkspace\test\venv\lib\site-packages\neo4j\v1\api.py", line 56, in last_bookmark
n[i] = int(n[i])
ValueError: invalid literal for int() with base 10: 'tx46'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "D:/PythonWorkspace/test/pass_bookmarks_example.py", line 68, in
exam.main()
File "D:/PythonWorkspace/test/pass_bookmarks_example.py", line 62, in main
session_c.write_transaction(self.create_friendship, "Alice", "Bob")
File "D:\PythonWorkspace\test\venv\lib\site-packages\neo4j\v1\api.py", line 497, in write_transaction
return self._run_transaction(WRITE_ACCESS, unit_of_work, *args, **kwargs)
File "D:\PythonWorkspace\test\venv\lib\site-packages\neo4j\v1\api.py", line 462, in _run_transaction
self.begin()
File "D:\PythonWorkspace\test\venv\lib\site-packages\neo4j\v1\api.py", line 522, in begin
parameters = {"bookmark": self.last_bookmark(), "bookmarks": self._bookmarks}
File "D:\PythonWorkspace\test\venv\lib\site-packages\neo4j\v1\api.py", line 384, in last_bookmark
last = last_bookmark(last, bookmark)
File "D:\PythonWorkspace\test\venv\lib\site-packages\neo4j\v1\api.py", line 58, in last_bookmark
raise ValueError("Invalid bookmark: {}".format(b0))
ValueError: Invalid bookmark: neo4j:bookmark:v1:tx46
Process finished with exit code 1

Hi @pangguoming
The bookmark format looks correct and our bookmark tests seems working as normal too.
Which neo4j version that you are using to run this test against? Are you running this test direct with the latest source code?
Regards,
Zhen

Seems a bug. Thanks for reporting. We will have a deeper look at it.

i use latest  version 1.6.0


chore(husky and lint-staged): add husky and lint-staged

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Debugging performances Testing Issue with Shreya and Omkar

Description
We are encountering performance issues during our testing phase. Shreya and Omkar will collaborate to debug and resolve these issues. The focus will be on identifying bottlenecks, optimizing performance, and ensuring the Jenkins node is functioning correctly.
Goals

Identify the root cause of the performance issues.
Collaborate with Shreya and Omkar to implement a fix.
Optimize the performance of the Jenkins node.
Ensure smooth execution of performance tests.

Expected Outcome
A stable and optimized Jenkins node with resolved performance issues, ensuring reliable performance testing.
Acceptance Criteria

[ ] Reproduce the performance issue in a controlled environment.
[ ] Identify the root cause of the performance issue.
[ ] Implement a fix for the identified issue.
[ ] Verify the fix resolves the issue without introducing new problems.
[ ] Document the debugging process, findings, and resolution steps.

Mockups / Wireframes
N/A (This section can be added if there are specific UI requirements.)
Product Name
Beckn
Domain
DevOps
Tech Skills Needed

Jenkins node management
Performance testing
Debugging and troubleshooting
Collaboration and communication

Complexity
High
Category
Bug Fix
Sub Category
Performance Testing

Connected Shreya and Omkar to debug the K8s deployment which we have created for the performance testing.