[Image Lab React]:Added preload scripts to use ipcRenderer.

Description
I have added preload scripts to fix the error window.require is not a function.
The preload script initialize the renderer process  environment i.e,ipcRenderer before the actual web page content is loaded.

Fixes #177

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality not to work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Initially it was giving this error,

After adding preload scripts,

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[ ] I have commented on my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@achyutagupta everything seems good! The maintainers will review and merge the PR accordingly.
Thank you for contributing!

@abdullahranginwala Your Welcome!
Looking forward to do more similar contributions in future.


Enable tests to run in GitHub actions

GitHub workflows need updating to allow for backend tests to be run through GitHub Actions

Tests were configured to run on each pull request.  Changes were merged in pull request #9


thunderbird, thunderbird-bin: 91.0.1 -> 91.0.2

Motivation for this change

UI updates.
Other fixes.

https://www.thunderbird.net/en-US/thunderbird/91.0.2/releasenotes/
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

We should backport this.


Mixed Datasource multiples querys Mapping

I have mixed datasource but in the mapping I cannot use two or more querys, the mapping just use the first one.

you need to select one or enter a regex in "apply tometrics"

https://github.com/algenty/grafana-flowcharting/issues/232


Have a visual indocator when a new team request is present

I created a team and some people requested access to this team. However neither the Linux commandline version nor the Linux GUI version showed any kind of indication that there are open requests. It would be nice that I as team owner get some iformation that people want to join.

Right now we only send e-mails but expanding notification system for cases like the one you described is also planned (and top priority). Thanks!


Should use "HEAD" method for HttpUrlSource.fetchContentInfo() instead of "GET"

For some devices,the HttpURLConnection.disconnect() method could cost too much time,see this:
http://stackoverflow.com/questions/25423546/httpurlconnection-slow-to-disconnect-java-android
The HttpUrlSource.fetchContentInfo() method only get the length and mime which is just in the http response`s header,not the body,so "HEAD" would be a better choice.

@liyzay Some servers doesn't response to HEAD requests. What is why I removed HEAD requests


Make BlobUndeleted not an error in router and more tests

BlobAlreadyUndeleted is not an error response in router from this PR on.
There are several ways ambry server might return BlobAlreadyUndeleted.

Frontend makes several attempts to undelete a blob
Frontend and replication concurrently undelete a blob (this happens a lot)

In both cases, we can ignore the BlobAlreadyUndeleted error and just treat it as an NoError.
Also more integration tests are added.

Codecov Report

Merging #1514 into master will decrease coverage by 0.02%.
The diff coverage is 79.06%.

@@             Coverage Diff              @@
##             master    #1514      +/-   ##
============================================
- Coverage     73.75%   73.72%   -0.03%
+ Complexity     8062     8059       -3
============================================
  Files           565      565
  Lines         44229    44248      +19
  Branches       5590     5591       +1
============================================
+ Hits          32621    32624       +3
- Misses         9971     9984      +13
- Partials       1637     1640       +3

Impacted Files
Coverage Δ
Complexity Δ

.../java/com/github/ambry/router/UndeleteManager.java
82.47% <ø> (ø)
16.00 <0.00> (ø)

.../java/com/github/ambry/protocol/AmbryRequests.java
85.18% <68.75%> (-0.62%)
85.00 <0.00> (+1.00)
:arrow_down:

...rc/main/java/com/github/ambry/store/BlobStore.java
90.10% <80.00%> (-0.43%)
121.00 <0.00> (+1.00)
:arrow_down:

...va/com/github/ambry/protocol/UndeleteResponse.java
76.08% <87.50%> (-2.18%)
13.00 <2.00> (-2.00)

...ava/com/github/ambry/router/UndeleteOperation.java
82.60% <100.00%> (-1.15%)
40.00 <0.00> (-1.00)

...n/java/com/github/ambry/clustermap/MockDiskId.java
80.00% <0.00%> (-5.72%)
12.00% <0.00%> (-1.00%)

.../ambry/clustermap/DynamicClusterChangeHandler.java
89.88% <0.00%> (-1.17%)
60.00% <0.00%> (-2.00%)

...ain/java/com/github/ambry/router/PutOperation.java
92.45% <0.00%> (-0.50%)
124.00% <0.00%> (-1.00%)

...n/java/com/github/ambry/store/PersistentIndex.java
91.11% <0.00%> (-0.11%)
252.00% <0.00%> (-1.00%)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fbf41b...9f253c0. Read the comment docs.

Codecov Report

Merging #1514 into master will decrease coverage by 0.00%.
The diff coverage is 82.35%.

@@             Coverage Diff              @@
##             master    #1514      +/-   ##
============================================
- Coverage     73.74%   73.74%   -0.01%
- Complexity     8079     8085       +6
============================================
  Files           566      567       +1
  Lines         44346    44367      +21
  Branches       5609     5613       +4
============================================
+ Hits          32703    32717      +14
- Misses         9998    10001       +3
- Partials       1645     1649       +4

Impacted Files
Coverage Δ
Complexity Δ

.../java/com/github/ambry/router/UndeleteManager.java
82.47% <ø> (ø)
16.00 <0.00> (ø)

...n/java/com/github/ambry/store/PersistentIndex.java
91.01% <71.42%> (-0.10%)
254.00 <0.00> (+2.00)
:arrow_down:

...ava/com/github/ambry/router/UndeleteOperation.java
82.09% <80.00%> (-1.66%)
40.00 <0.00> (-1.00)

...rc/main/java/com/github/ambry/store/BlobStore.java
90.01% <81.25%> (-0.59%)
120.00 <0.00> (ø)

.../java/com/github/ambry/protocol/AmbryRequests.java
85.60% <81.81%> (-0.19%)
85.00 <0.00> (+1.00)
:arrow_down:

...va/com/github/ambry/protocol/UndeleteResponse.java
76.08% <87.50%> (-2.18%)
13.00 <2.00> (-2.00)

.../github/ambry/store/IdUndeletedStoreException.java
100.00% <100.00%> (ø)
2.00 <2.00> (?)

...github/ambry/rest/AsyncRequestResponseHandler.java
87.87% <0.00%> (-2.36%)
21.00% <0.00%> (ø%)

.../github/ambry/clustermap/StaticClusterManager.java
68.57% <0.00%> (-1.64%)
82.00% <0.00%> (-1.00%)

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44ff5f8...f159f15. Read the comment docs.


Documenting Js.Undefined

There are some official Belt functions that use Js.Undefined, but it's not documented on the Reason or BuckleScript docs. The page on option mentions how to use Js.Nullable for interoperability, but not Undefined.
Some questions I have about Js.Undefined.t:

Is it obsolete now that option is unboxed?
Can you nest it?
Can you annotate externals with it as polymorphic instead of a concrete type? (Js.Undefined.t('a))

I had long assumed it was deprecated, but it’s been referenced in a recent BuckleScript blog post. I think that as long as it’s still being officially used on the BuckleScript site, it should be explained in the docs.
I know its API has basic documentation but there’s no explanation as to how it works or what its purpose is.
I would submit a PR myself, but I don't understand the type enough to adequately write about it.

There are some official Belt functions that use Js.Undefined

The reason is that nested Undefined is flattened which is contrary to option so that the generated code is slightly better than the option.

Is it obsolete now that option is unboxed?

It's less used when you don't care about perf or code size or in non-polymorphic code

Can you nest it?

Undefined is flattened contrary to option

Can you annotate externals with it as polymorphic instead of a concrete type? (Js.Undefined.t('a))

I am not sure I fully get the question, why it is problematic here?

Can you annotate externals with it as polymorphic instead of a concrete type? (Js.Undefined.t('a))

I am not sure I fully get the question, why it is problematic here?

I think that such a binding can be unsound precisely because of flattening. Or, just with "surprising behaviour".

Can you annotate externals with it as polymorphic instead of a concrete type? (Js.Undefined.t('a))

I am not sure I fully get the question, why it is problematic here?

I’m thinking of the caveats listed on the Reason docs for option:

Never, EVER, pass a nested option value (e.g. Some(Some(Some(5)))) into the JS side.
Never, EVER, annotate a value coming from JS as option('a). Always give the concrete, non-polymorphic type.

The second one in particular. Do these apply to Js.undefined the same way?

On Mon, May 4, 2020 at 8:59 PM John Jackson<EMAIL_ADDRESS>wrote:

Can you annotate externals with it as polymorphic instead of a concrete
type? (Js.Undefined.t('a))
I am not sure I fully get the question, why it is problematic here?
I’m thinking of the caveats listed on the Reason docs for option
https://reasonml.github.io/docs/en/null-undefined-option#caveat-1:

Never, EVER, pass a nested option value (e.g. Some(Some(Some(5))))
into the JS side.

That's not exact. Some (Some (Some (5)))) is just 5 which is fine. It is
problematic when you pass Some None or (Some (Some (Some (None)))))

Never, EVER, annotate a value coming from JS as option('a). Always
give the concrete, non-polymorphic type.

The second one in particular. Do these apply to Js.undefined the same way?

Monomorphic is always preferred to polymorphic -- you get better
performance and more safety check. If you really want bind to polymorphic
optional, 'a Js.undefined is safer here since it is a JS thing, while 'a option is not

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/reason-association/reasonml.org/issues/165#issuecomment-623448355,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFWMK2VM2K2U357CGPQB2LRP23ZZANCNFSM4MHCWBAA
.

--
Regards
-- Hongbo Zhang


systemd unit fixes

Description:

Removed the %h argument.
%h points to the home directory of the user running  systemd, not the user running the service.
In most cases (i'm using ArchLinux), systemd is ran by root, so %h will default to /root, and therefore fail to locate the user's config path.
It's easier to omit this entire config location argument, since HA will pick it up from the User parameter.

Added an optional step to sleep for one minute before starting HA during boot.
In my system, the After=network.target is not enough of a condition, because network interfaces could be up, but resolv.conf may not be ready to serve yet, and as a result network discovery will fail at boot.
The UI will only show the statically defined components, until HA is restarted.
"network-online.target" does not help either.
The easiest, and most generic solution, for all different systems and behaviours would just be to wait a while until all targets are up, and then start HA, at the cost of a small startup delay.
I have therefore added an optional sleep statement, for systems that may need it, to be enabled and configured where appropriate.

 And it seems that we diverged from the docs.
Thanks for your time to investigate the issue.


ja: Make docs/concepts/workloads/controllers/replicaset.md follow v1.19 of the original text

This is a Feature Request

What would you like to be added
Update docs/concepts/workloads/controllers/replicaset.md to follow v1.19 of the original (English) text.
Why is this needed
content/ja/docs/concepts/workloads/controllers/replicaset.md is outdated.
Comments
/language ja
/good-first-issue
File to update
https://github.com/kubernetes/website/tree/dev-1.19-ja.1/content/ja/docs/concepts/workloads/controllers/replicaset.md
Original
https://github.com/kubernetes/website/tree/release-1.19/content/en/docs/concepts/workloads/controllers/replicaset.md
diff between translated and v1.19
https://gist.github.com/6459e80d098841669aba9191684d13af
Note
Currently, we use dev-1.19-ja.1 branch. Please open a PR targeting the branch.
ref
https://kubernetes.io/ja/docs/contribute/localization/
If you have a question, feel free to ask us at slack.k8s.io #kubernetes-docs-ja channel.

/triage accepted

/assign

/close


Don't JSON-encode the work ID sent by the merger

Closes https://github.com/wellcomecollection/platform/issues/4850

I’m going to merge this so I can deploy it to staging, but please comment if you think there are things I should change or fix, and I’ll sort them out in a separate PR.


[Payment history] add "Request refund" menu item

Details

Pre-requisite for the Payment/Subscription testing:
Have a create collect policy.
To access the subscription page, paste the following link into the browser
https://dev.new.expensify.com:8082/settings/subscription
or add this effect to InitialSettingsPage.tsx
useEffect(() => {
    Navigation.navigate(ROUTES.SETTINGS_SUBSCRIPTION)
}, []);

Have an Account with isEligibleForRefund: true. If you don't have the account then use the following command to populate the Onxy keys
import Onyx from 'react-native-onyx';

useEffect(() => {
       Onyx.merge(ONYXKEYS.ACCOUNT, { isEligibleForRefund: true});
   }, []);

Fixed Issues

$ https://github.com/Expensify/App/issues/43283
Tests

[x] Verify that no errors appear in the JS console

Go to Subscription page
Click on Request refund button
Verify that modal shown
Next click Downgrade...
Verify that modal got closed and your account is downgraded

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

Go to Subscription page
Click on Request refund button
Verify that modal shown
Next click Downgrade...
Verify that modal got closed and your account is downgraded

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@mananjadhav comments resolved

@blimpich @kubabutkiewicz The button text is getting cut off in the modal with Spanish translation.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/3069065/4f98a86e-9c30-4e09-a925-22f19db93a9d

MacOS: Desktop

@Expensify/design @blimpich Could we have Request refund, without having View payment history. When I play around with dummy data and this is true, the spacing is an issue. If this case can't exist then nothing needs to be fixed here.  But if this is true, @kubabutkiewicz we'll have to fix the padding.

Hmm I'm not sure if you can have "Request refund" yet not have a payment card.

Can you show me what the :hover style looks like for that row? Thanks!

Could we have Request refund, without having View payment history?

No, not possible. In order to request a refund you must have a purchase, and if you have a purchase then that means "view payment history" should be visible.

Can you show me what the :hover style looks like for that row? Thanks!

@shawnborton Can you check the Mac Chrome/Safari video added ?

Could we have Request refund, without having View payment history?

No, not possible. In order to request a refund you must have a purchase, and if you have a purchase then that means "view payment history" should be visible.

Thanks for confirming.

Awesome, just checked and the styles look correct to me. Thanks!

Posting screenshots with new Spanish translations

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/blimpich in version: 9.0.4-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/tgolen in version: 9.0.4-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


feat: style mobile listing cards

Pull Request Template
Description

Change location of "See details" button for desktop vs mobile
Update margins and padding for mobile listing card as well as desktop where needed
Round the corners of the image card
Update font sizes and colors according to Figma specs
Add border to the bottom of each listing card
Center listing card content to the left for mobile

Mobile before:

Mobile after:

Desktop before:

Desktop after:

iPad before:

iPad after:

How Can This Be Tested/Reviewed?
Go to the listings page and try using different devices with the chrome developer tools device emulator

@ifranch awesome!! It's looking so good! Great job!!!
I did run into this error when on mobile in map only view, when clicking on a pin. Nothing happened...so no card pop-up and the listings drawer didn't move up either. This might be a different PR and unrelated to this.

Yep the fix for that is coming in a different PR. This PR didn't introduce it, it's from https://github.com/metrotranscom/doorway/pull/149


Bug report

Bug report: Farming mysterious seeds. So I began farming max amount of mysterious seeds 2 days ago and noticed a difference in yield and wasn't sure if it was due to different yields or if it was a bug but now I am sure it is a bug. First noticed when I increased seeds planted from 1 to 8. Then tested 8 to 8, then 8 to 1, then nothing, which I got boxes for with no seeds planted. And reconfirmed again with 1 to 8. Attached are all the necessary screenshots.

Oops, uploaded 2 non necessary screenshots XD

Working as intended. You get 1 - 4 boxes per seed planted, and 1 - 6 boxes for tree harvested.


How to use Brain in logging pipeline?

How to use the parser?
This is more of a "conversation thread" rather than a bug-report.
I posted these questions on the "logpai" issue but will post them here again.
1: Drain3 has persistence with File/redis/kafka. How to set persistence up with brain? Is it possible?
2: Drain3 also has livestream inputs with sdin. I cannot find any documentation on this for Brain. Is it possible to do with Brain? . According to the documentation Brain only parses entire log-files once. But how to set up an actual pipeline so that json objects are sent to other API's (for db, analysis, visualization etc)?
3: It is common standard in the industry to use a collector such as Vector or logstash/fluent or similar. How can Brain be used with these?
Are we supposed to containerize python/brain in a deployment or what?
I am not sure how to actually set this up so that things (log lines) go through the "brain parsing processor", but I am sure that a really good way would be something similar to the way Drain3 is setup with kafka (so that it can easily scale and be persistent).
TLDR?;
How to setup brain in an existing infrastructure?

Thank you for your interest in my work. Similar to Drain, Brain is a research project. Drain3 is more practical and tailored for industry. Therefore, Brain might lack some documentation to guide practitioners in deploying it in the industry, and we apologize for that. As mentioned in our paper, Brain supports BATCH PROCESSING rather than real-time parsing. Although we have some ideas for real-time parsing with Brain (the longest common pattern), they have not been validated yet.

Ok thank you for the reply! No need to apologize friend. Your work is really impressive and I am extremely impressed by how far you cave gotten so far and I am looking forward to more auto-parsing tech!! Now, please forgive me for the long comment below but I think these architectural considerations might be useful for you when you develop Brain/Drain/Logparser features.
In my investigations I've managed to discover some things and have these ideas:
Lets assume that drain3 is used. First question is: how do you personally suggest that the template parsing is done (from architectural point of view)? Do we re-deploy the entire "Drain3 stack" for every app? This way the templates won't get inter-mingled? Is this useful or Is it avoidable with your "longest pattern" strategy? In the case its useful to separate formats, it might  be a good idea to implement some kind of "namespace" or "label" for each format.
Usually the formats are following an extremely consistent template "within the app itself". So you only need to separate them "per app". (provided the template isn't ruined by multi-line logs). But lets ignore multiline logs for now, they can be ignored since they are a separate issue. (And by the way, there are other more specific technologies for handling multiline logs such as autoinstrumentation and OTEL-tracing, which we won't get into here). Ignore multiline-logs for now. Therefore: Assume that, every log is a nice "one-liner".
idea1: Opensearch
I was thinking of saving the state in an index in opensearch (which is where all the parsed data will go to as well), since this would simplify the scaling, retention, generalization, anomalydetection, visualization, and so on. And then "sync with state every 10 minutes or so".
Setting up the "state location" has been a little difficult and complicated. I tried to to create a new "OpensearchPersistence" but failed. A similar idea would perhaps be to set up an opensearch plugin on the opensearch java application itself. This way a "Drain3 GUI" would integrate with the rest of the analytics for free! Building plugins for opensearch is however a monolithic design-pattern which will depend heavily on the stability on opensarch.
idea2: Kafka
Since the documentation is using Kafka at the moment, I have a simpler question: Is it possible to do a unique kafka topic (for each log-source)? As it seems, for now, I would need a completely new kafka DB for every application in that case. Could that be a problem? Or is redis the recommended way?
Lets say I have logs coming from nginx (And logs coming from windows, and sshd and some other apps).  How to set this up? The demos only demonstrate how to handle a single format at the time (a single app). Handling multiple apps is an important piece of this puzzle.
Idea3: Cron
Maybe a cron job could be in order to simply run brain on specific "log-files" every x minutes? And then let it tail certain log files? In this case Drain would need to remember the line position it tailed for every new logline.
.
idea4: Namespace
Consider this: In the documentation: drain3 parses like this:
...
result = template_miner.add_log_message(line)
...

But what if we could simply add a namespace/label like this, and keep all the app formats in one state, while separating them by namespace?:
...
    result = template_miner.add_log_message(line, namespace="nginx") # returns a function here ! not a dictionary!. If namespace is not provided it will use the "default" namespace.

    #try getting params
    template = result("template_mined", "nginx")
    template_miner.extract_parameters(template, line)
...

Please let me know if you think these are bad ideas, because these are the paths and ideas I'm considering when moving forward with drain3! And forgive me for the long post!
Thank you!

Apologies for my late response. I took some time to understand the issues you mentioned, because I really lack some practical experience and do not know much about Drain3. Here are my thoughts on the questions you raised; please feel free to point out my any misunderstandings, as I am very willing to discuss this further with you:
All your concerns are about persistence, right? As I understand it, the background of this issue is about real-time parsers because they continuously update the established model, such as Drain's tree. If you can persistently store the tree, it will save the overhead of parsing each time and might improve accuracy. Are you facing the issue of mixed logs from different apps now? I think the batch processing Brain does not encounter this problem,  because Brain builds an independent model for each batch, completes the parsing, and there is no correlation between batches.  For real-time parsing, as you mentioned, I think the namespace is a good solution, provided the log formats of different apps are known. You can use regex to determine which log format the input log matches, and then fill in the corresponding parameters in parse(line, namespace="nginx") to get and update the corresponding model.
After briefly reading the Drain3 documentation, I think Drain3 would need a completely new Kafka DB for every application in that case. I believe creating different models for logs from different apps is inevitable since the log templates of different apps are likely completely different. For Brain's "Longest pattern," it is also entirely different, and there is no need to intermingle them, as intermingling would increase search time and reduce efficiency.  For the models of Drain and Drain3, it's also unnecessary to intermingle the models of different apps, as I think it would increase search time and reduce accuracy.


Yi 1080p Home RFUS

Hello everyone,
I recently bought some cameras from Yi and am looking for an alternative firmware for them.
The problem is I'm not finding a compatible version or I don't know which version to use.

Camera: Yi 1080p Home RFUS
Firmware: <IP_ADDRESS>
Model: YYS.2016

I appreciate if anyone can tell me the correct version.

Hi @fernandolcardoso, you need y211ga from here


bug: Ignore cond when lazy loaded by command

Did you check docs and existing issues?

[X] I have read all the lazy.nvim docs
[X] I have searched the existing issues of lazy.nvim
[X] I have searched the exsiting issues of plugins related to this issue

Neovim version (nvim -v)
0.9
Operating system/version
Windows 11
Describe the bug
{
    'rmagatti/auto-session',
    cmd = 'SaveSession',
    cond = function()
        return vim.fn.filereadable(vim.fn.stdpath "data" .. "\\sessions\\" .. vim.fn.getcwd():gsub("\\", "%%"):gsub(":", "++") .. ".vim") == 1
    end,
}

My config above checks for session file in cond and loads plugin if sessions exists or load when SaveSession is executed.
But when I entered the command it didn't load the plugin. Reason: it ignored loading as cond was false.
I found the fix location: https://github.com/folke/lazy.nvim/blob/1ca3f101c888b0cf5085bc12446061792e8ee024/lua/lazy/core/loader.lua#L191
and the change
  if plugin.cond ~= nil and not (opts and opts.force) and not reason.cmd then

Steps To Reproduce
use the config pasted above
Expected Behavior
cmd should take preference and should load plugin.
Repro
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

That's not how it works. cond() is evaluated whenever it tries to load. And if it's false it won't load.
So in your example, the cmd will try loading the plugin, see that cond() is false and decide not to load the plugin

remove all issues

close all issues

@folke okay then any parameter to pass to condition to decide itself whether to load on or not

Have not tested it, but the below should do what you want.
{
    'rmagatti/auto-session',
    cmd = 'SaveSession',
    init = function()
        if vim.fn.filereadable(vim.fn.stdpath "data" .. "\\sessions\\" .. vim.fn.getcwd():gsub("\\", "%%"):gsub(":", "++") .. ".vim") == 1 then
          require("auto-session")
        end
    end,
}


Symbol not getting removed when item is removed from tree

When items are repeatedly added to and removed from new trees, the symbols stay and start clogging up the memory. Don't know if this is necessary by design or not.
My simple test:
const SymbolTree = require('symbol-tree');

const base = [];
for(let i=0; i<100; i++) {
	base.push({ content: i });
}

for(let i=0; i<1000; i++) {
	let tree = new SymbolTree();
	let root = { root: true };
	base.forEach(obj => {
		tree.appendChild(root, obj);
	});

	let it = tree.childrenIterator(root);
	for( child of it ){
		tree.remove(child);
	}
	console.log(JSON.stringify(process.memoryUsage()));

}

This was indeed by design because it was the fastest solution for jsdom's use case. In jsdom objects are often removed from the SymbolTree and then added back a little while later. (Also note that jsdom uses a finite amount of SymbolTree instances). Deleting and then adding back the property would be slower, and also delete may cause deopts in v8.
Would it help if I added an option to the constructor?
const tree = new SymbolTree({cleanup: true});
tree.remove(someObj); // which would then trigger `delete someObj[this.symbol]`

And then jsdom could continue to use the {cleanup: false} behaviour.

That would be a good solution, yes. If delete is bad in these cases, I'd just recommend setting it to null if that makes a difference.
But if it's by design, don't feel pressured on my part. Turns out I can't use this awesome lib anyway, unfortunately, since it can't allow the same object multiple times. Just thought I'd mention the problem since I already wrote the test and thought somebody might one day run into the problem ;)


fix: Stop tox precommit modifying files

Description

Original bug reported by @MVrachev:

if precommit is not updated to latest versions of linters locally it will fail.

Some context:

Do we have a GitHub automated pr

Yes, we do have in https://github.com/repository-service-tuf/repository-service-tuf-cli/blob/main/.github%2Fworkflows%2Fupdate-pre-commit-hooks.yml.

Asking as currently, if precommit is not updated to latest versions of linters locally it will fail.

This should not be happening, it is supposed to only be a warning message. If that's not happening then it's a bug.

If we have the same automated pr updating the CLI precommit hooks we would be able to remove this requirement.

With the same reasoning we should remove also the requirements check, since we also have an automated PR for that (which I'm fine with)
For more information on the original idea of this hook: https://github.com/repository-service-tuf/repository-service-tuf-cli/pull/383#issuecomment-1734517873

Fix
This tox step showed a warning (zero exit code) if the .pre-commit-config.yaml file was out-of-date and also updated it. When a file is updated pre-commit hooks exit with a non-zero code, whereas we only
wanted to print a warning with this hook.

Fixes #(issue)
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality not to work as expected)

Additional requirements

[ ] Tests have been added for the bug fix or new feature
[ ] Docs have been added for the bug fix or new feature

Code of Conduct
By submitting this PR, you agree to follow our Code of Conduct.

[x] I agree to follow this project's Code of Conduct

@KAUTH shall we apply it to the other repos?

@KAUTH shall we apply it to the other repos?

Yes, now that it's approved and merged I can apply it to other repos


[CP] relax conditions for SkRRect.isSimple conversion

Issue Link
flutter/flutter#148412
Target
stable
PR Link
https://github.com/flutter/engine/pull/53208
Changelog Description

Fixes potential flickering when translating a blurred rounded rectangle.

Impacted Users
Impeller / iOS
Impact Description
Incorrect rendering / flickering in certain applications.
Workaround
Use Skia
Risk
low
Test Coverage
yes
Validation Steps
Run attached tests.

cp lgtm

https://github.com/flutter/engine/pull/53208 merged.


Sort out composer-installability

cc @ptarjan @daniel15 @rdewilde @Swahvay
Thoughts:

https://packagist.org/packages/hhvm/xhp should die in favor of https://packagist.org/packages/facebook/xhp as XHP isn't HHVM-specific - and people shouldn't have to modify their composer.json to switch from PHP5 to HHVM
Facebook and/or the XHP maintainers should have admin access to https://packagist.org/packages/facebook/xhp
it should be backed by the facebook/xhp repository, not a fork. This means that we need to add a composer.json here, and that composer will be downloading the full tree, not just php-lib. Alternatively, the php-lib could be removed from this repository, and another repository becomes the canonical source for it.
if we end up with a separate canonical source for php-lib, it needs to retain history, including tags. The current forks appear to be a copy of the files, without full history. It should either be a fork with everything else removed, or a fork with git-filter-branch done to remove it.

Almost ready to go:
https://github.com/facebookarchive/xhp-php5-extension
https://github.com/fredemmott/xhp-lib
Plan is:

test composer installability of xhp-lib
rename this repository to xhp-lib (so that the issues are preserved)
push fredemmott/xhp-lib's changes here

Still agree with the splitting of xhp-lib and xhp-php5-extension, though still not a huge fan of archiving the extension.

In practice, Facebook already doesn't support the PHP5 extension, and hasn't for some time. Archiving it is just making this clear, not really changing anything.

My observation has been that the facebookarchive account is essentially where already-dead projects go to become more dead; I couldn't find a single one that had any commits since being moved there, and the ones I looked at hadn't had any commits in over a year prior to being archived. On the other hand, I have contributed a number of fixes to the extension in the past few months, and have been working on adding support for PHP 5.6 syntax.
Obviously I can just fork the repo and go from there (yay open source), but the biggest issue at play is discoverability. I do think XHP has value outside of its use in HHVM.

Long-term, XHP is dead outside of HHVM unless there's sufficient interest and commitment to both maintain the PHP5 extension, and to create a PHP7 extension; this commitment isn't going to come from Facebook, and we want to make this clear.
We'll be happy to link to a canonical fork if there's a consensus.

Done, and composer.json added. Composer package is 'facebook/xhp-lib'.


feat: add backmerge feature

🎉 This issue has been resolved in version v1.0.0-alpha.1 🎉

🎉 This issue has been resolved in version v1.0.0-beta.1 🎉

🎉 This issue has been resolved in version v1.0.0 🎉


Micropyramid CRM

Hi there. Is there any way to have table structures used in CRM because i have to create them in MSSQL? Thanks in advnace.

you connect db in settings.py and do a migrate. it will create those tables automatically
reference: https://learn.microsoft.com/en-us/samples/azure-samples/mssql-django-samples/mssql-django-samples/


SystemSound.play(SystemSoundType.click) not working

The below code is not working
static Future<void> play(SystemSoundType type) async {
    await SystemChannels.platform.invokeMethod<void>(
      'SystemSound.play',
      type.toString(),
    );
play(SystemSoundType.click);

Also it is not showing any errors. Please help. Let me know if you need more information.
Thanks,
Vishnu.

@nagarjunvv
Does it work this way?
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';

void main() => runApp(MaterialApp(home: MyApp()));

class MyApp extends StatefulWidget {

  @override
  _MyAppState createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {

  @override
  Widget build(BuildContext context) {
    return SafeArea(
      child: Scaffold(
        body: Center(
          child: RaisedButton(
            child: Text("button"),
            onPressed: () {
              SystemSound.play(SystemSoundType.click);
            },
          ),
        ),
      ),
    );
  }
}

Could you provide your flutter doctor -v and mention with what device you are testing?

@VladyslavBondarenko
Thanks for your response.
The above code did not work.
Here is the flutter doctor -v and i am not using VS studio and i am using android studio.
C:\src\flutter\flutter\bin\flutter.bat doctor --verbose
Checking Dart SDK version...
Flutter requires PowerShell 5.0 or newer.
See https://flutter.dev/docs/get-started/install/windows for more.
Building flutter tool...
Running pub upgrade...
[√] Flutter (Channel stable, v1.12.13+hotfix.8, on Microsoft Windows [Version 6.3.9600], locale en-MY)
• Flutter version 1.12.13+hotfix.8 at C:\src\flutter\flutter
• Framework revision 0b8abb4724 (3 months ago), 2020-02-11 11:44:36 -0800
• Engine revision e1e6ced81d
• Dart version 2.7.0
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
• Android SDK at C:\Users\Saritha\AppData\Local\Android\sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 29.0.3
• Java binary at: C:\Program Files\AdoptOpenJDK\jdk-<IP_ADDRESS>-hotspot\bin\java
• Java version OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_212-b04)
• All Android licenses accepted.
[!] Android Studio (version 3.6)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 45.1.1
• Dart plugin version 192.8052
X Unable to find bundled Java version.
• Try updating or re-installing Android Studio.
[!] VS Code (version 1.41.1)
• VS Code at C:\Users\Saritha\AppData\Local\Programs\Microsoft VS Code
X Flutter extension not installed; install from
https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter
[√] Connected device (1 available)
• Redmi 6 • 05d5dcd37d28 • android-arm • Android 9 (API 28)
! Doctor found issues in 2 categories.
Please suggest if i miss something.

The device I am using is Redmi 6 (mi 6).

With dev 1.19.0-1.0.pre I can hear sound when running on Android 10 (API 29) (emulator) and iOS-13-4 (simulator) mentioned code in new project.
But not when running on Redmi Note 7 Android 9 (API 28).
@TahaTesser said that he can't hear sound with any (Android API 29) (emulator), iPhone XR 13.4.1, Samsung Galaxy M30 Android 10

Any suggestions to make it work for me?

If it is a known bug and no resolution , please let me know.

Can some one help me here? I am struggling to do this for more than a week, does anyone have similar issues? How did you resolve it?

Platform iOS label is removed , it means it is working fine in iOS please let me know.

@nagarjunvv yes, I needed to comment this.
When I tested the first time - I tested with iOS 13.4 and there was no sound on real device. But yesterday I tested again with the same iPhone 7, but this time I already have updated to iOS 13.5 and I can hear the click sound (with the same dev 1.19.0-1.0.pre)

Oh ok, then iOS there is no issue, but is there a way to make it work for android, as I am planning to release my app next week. Before that I want to have a permanent solution for this. For now I am playing click sound with audio player plugin, which I don’t want to use.
Thanks,
Vishnu.

Same here in Android I cant hear the sound tested in Redmi Note 4 and Samasung S7

Hey everyone, this doesn't on iOS or Android

code sample
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';

void main() => runApp(MaterialApp(home: MyApp()));

class MyApp extends StatefulWidget {
  @override
  _MyAppState createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  @override
  Widget build(BuildContext context) {
    return SafeArea(
      child: Scaffold(
        body: Center(
          child: RaisedButton(
            child: Text("button"),
            onPressed: () {
              SystemSound.play(SystemSoundType.click);
            },
          ),
        ),
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.5, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.22.5 at /Users/tahatesser/Code/flutter_stable
    • Framework revision<PHONE_NUMBER> (5 weeks ago), 2020-12-10 11:54:40 -0800
    • Engine revision ae90085a84
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (1 available)
    • IN2011 (mobile) • c9d8ee0c • android-arm64 • Android 11 (API 30)

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 1.26.0-2.0.pre.313, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.26.0-2.0.pre.313 at /Users/tahatesser/Code/flutter_master
    • Framework revision 1cb0a24a46 (8 hours ago), 2021-01-12 21:39:27 -0800
    • Engine revision 10cee6abcb
    • Dart version 2.12.0 (build 2.12.0-214.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (3 available)
    • IN2011 (mobile) • c9d8ee0c • android-arm64  • Android 11 (API 30)
    • macOS (desktop) • macos    • darwin-x64     • macOS 11.1 20C69 darwin-x64
    • Chrome (web)    • chrome   • web-javascript • Google Chrome 87.0.4280.141

• No issues found!

Hey everyone, this doesn't on iOS or Android

code sample
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';

void main() => runApp(MaterialApp(home: MyApp()));

class MyApp extends StatefulWidget {
  @override
  _MyAppState createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  @override
  Widget build(BuildContext context) {
    return SafeArea(
      child: Scaffold(
        body: Center(
          child: RaisedButton(
            child: Text("button"),
            onPressed: () {
              SystemSound.play(SystemSoundType.click);
            },
          ),
        ),
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.5, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.22.5 at /Users/tahatesser/Code/flutter_stable
    • Framework revision<PHONE_NUMBER> (5 weeks ago), 2020-12-10 11:54:40 -0800
    • Engine revision ae90085a84
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (1 available)
    • IN2011 (mobile) • c9d8ee0c • android-arm64 • Android 11 (API 30)

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 1.26.0-2.0.pre.313, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.26.0-2.0.pre.313 at /Users/tahatesser/Code/flutter_master
    • Framework revision 1cb0a24a46 (8 hours ago), 2021-01-12 21:39:27 -0800
    • Engine revision 10cee6abcb
    • Dart version 2.12.0 (build 2.12.0-214.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (3 available)
    • IN2011 (mobile) • c9d8ee0c • android-arm64  • Android 11 (API 30)
    • macOS (desktop) • macos    • darwin-x64     • macOS 11.1 20C69 darwin-x64
    • Chrome (web)    • chrome   • web-javascript • Google Chrome 87.0.4280.141

• No issues found!

I also have this issue.

I also have this issue.

Does not work on Pixel 4 API 30 Emu and real Xiaomi Mi Note 2

Does not work on ios 14

Does not work for me on Pixel 3a (does for iPhone SE 12).
Henkkas-MacBook-Pro:nemosyke egaga$ flutter doctor -v
[✓] Flutter (Channel stable, 2.5.1, on macOS 11.5.2 20G95 darwin-x64, locale en-FI)
    • Flutter version 2.5.1 at /Users/egaga/dev/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ffb2ecea52 (3 weeks ago), 2021-09-17 15:26:33 -0400
    • Engine revision b3af521a05
    • Dart version 2.14.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/egaga/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/egaga/Library/Android/sdk
    • Java binary at: /Library/Java/JavaVirtualMachines/adoptopenjdk-14.jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment AdoptOpenJDK (build 14.0.2+12)
    • All Android licenses accepted.

[✓] Connected device (4 available)
    • Pixel 3a (mobile) • <redacted>                • android-arm64  • Android 11 (API 30)
    • macOS (desktop)   • macos                     • darwin-x64     • macOS 11.5.2 20G95 darwin-x64
    • Chrome (web)      • chrome                    • web-javascript • Google Chrome 94.0.4606.71

• No issues found!

It still not working

Flutter 3.0.5. still not working. I'm testing on iPhone X & Samsung s10e.  :(

On iOS, a hard coded value 1306 is used to represent the click sound: https://github.com/flutter/engine/blob/main/shell/platform/darwin/ios/framework/Source/FlutterPlatformPlugin.mm#L18
I couldn't find this value in any Apple documentation. Apple suggests to use AudioServicesCreateSystemSoundID  to get a sound ID from a file. It is possible that Apple removed the support of using 1306 as default system sounds, or a new value is used instead.
This article mentioned a way to get the system sound file, this could be a workaround to get the system click sounds.
IMHO, since there is no official documentation for how to get the default click sound, a plugin should be used to support this using the workaround mentioned in the article, because plugins can be updated fairly quickly in case Apple changed the system sound file location on new phones.

I can hear the click on an iOS simulator running iOS 16.2 but not an API 33 Android one. Updating labels as this is still reproducible

I'm also encountering this issue. The sound works on iOS simulator 16.2 but not on an Android device with SDK 31.

Also not working on android, Huawei Mediapad T5, flutter version 3.3.9 stable.

Same issue not working on XIAOMI note 10 pro

same issue not working on oneplus 8t

Same issue (sound DOES NOT WORK) on Android Emulator (API 33) which plays other sounds without problems.

Sample code:
```dart
	void _incrementCounter() async {
		SystemSound.play(SystemSoundType.alert);
		setState(() {
		// This call to setState tells the Flutter framework that something has
		// changed in this State, which causes it to rerun the build method below
		// so that the display can reflect the updated values. If we changed
		// _counter without calling setState(), then the build method would not be
		// called again, and so nothing would appear to happen.
		_counter++;
		});
	}
```

Flutter doctor -v:
```
[√] Flutter (Channel stable, 3.10.1, on Microsoft Windows [Versione 10.0.19045.2965], locale it-IT)
    • Flutter version 3.10.1 on channel stable at C:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision d3d8effc68 (9 days ago), 2023-05-16 17:59:05 -0700
    • Engine revision b4fb11214d
    • Dart version 3.0.1
    • DevTools version 2.23.1
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
• Android SDK at c:\users\Rober\AppData\Local\Android\Sdk
• Platform android-33, build-tools 32.1.0-rc1
• ANDROID_HOME = c:\users\Rober\AppData\Local\Android\Sdk
• ANDROID_SDK_ROOT = c:\users\Rober\AppData\Local\Android\Sdk
• Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
• Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-9505619)
• All Android licenses accepted.
[√] Visual Studio - develop for Windows (Visual Studio Community 2022 17.6.1)
• Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
• Visual Studio Community 2022 version 17.6.33717.318
• Windows 10 SDK version 10.0.22000.0
[√] Android Studio (version 2022.1)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-9505619)
[√] VS Code (version 1.78.2)
• VS Code at C:\Users\rober\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.64.0
[√] Connected device (2 available)
• sdk gphone64 x86 64 (mobile) • emulator-5554 • android-x64 • Android 13 (API 33) (emulator)
• Windows (desktop)            • windows       • windows-x64 • Microsoft Windows [Versione 10.0.19045.2965]
[√] Network resources
• All expected network resources are available.
• No issues found!
</details>

Same issue.
Works in emulator, all quiet on an actual device.
Devices tested: OnePlus 10T & 6

I'm facing the same issue.
It works on the IOS simulator.

IPhone SE ( 3rd Generation ) & IOS 16.4

It does not work on a real Android Device. The device has Touch Sound and Touch Vibration enabled.

Samsung A13 & Android 13

Sample Code
onPressed: () {
            SystemSound.play(SystemSoundType.click);
             return handleNum(label.keys.first);
                       }

flutter doctor -v
[✓] Flutter (Channel stable, 3.16.2, on macOS 13.5.2 22G91 darwin-x64, locale en-PK)
    • Flutter version 3.16.2 on channel stable at /Users/asadamatic/fvm/versions/3.16.2
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 9e1c857886 (10 days ago), 2023-11-30 11:51:18 -0600
    • Engine revision cf7a9d0800
    • Dart version 3.2.2
    • DevTools version 2.28.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/asadamatic/Library/Android/sdk
    • Platform android-33, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E300c
    • CocoaPods version 1.14.3

[✓] Chrome - develop for the web
    • CHROME_EXECUTABLE = /Applications/Brave Browser.app/Contents/MacOS/Brave Browser

[✓] Android Studio (version 2022.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] VS Code (version 1.85.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.78.0

[✓] Connected device (4 available)
    • SM A135F (mobile)                   • R58W1176XGD                          • android-arm    • Android 13 (API 33)
    • iPhone SE (3rd generation) (mobile) • 74C9BF31-D225-433F-8117-FF011FFD4A09 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-4 (simulator)
    • macOS (desktop)                     • macos                                • darwin-x64     • macOS 13.5.2 22G91 darwin-x64
    • Chrome (web)                        • chrome                               • web-javascript • Brave Browser <IP_ADDRESS>

[✓] Network resources
    • All expected network resources are available.

• No issues found!

same issue facing

Is there any workaround for this?


Update graphics/cameras/index.md

Fixed inconsistency with near plane example.
A near plane of 7 is higher than the default value of 0.1, not lower.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Use --client-id and --client-secret in bot commands

coverage: 93.979% (-0.07%) from 94.049% when pulling ce8b07250419c1b28cc8bd3a763a90590671e7f0 on cody-cli-auth-and-bot-commands into 7b96084478e4a79cbe9a86a0e0e16594f6036c60 on main.


Decide on Greenfoot or Processing

I vote for greenfoot

My vote goes to Greenfoot

Greenfoot

I too vote for Greenfoot!