Windows 10 Issues Installing

Hello! Thanks so much for an amazing code base!
Basically, I've run the following in my git bash on my Windows 10 machine (version 10.0.14393 Build 14393, x64-based PC):
This to clone (which seems to work fine):
git clone https://github.com/chentsulin/electron-react-boilerplate.git my-app
Cloning into 'my-app'...
remote: Counting objects: 3790, done.
remote: Compressing objects: 100% (22/22), done.
remote: Total 3790 (delta 14), reused 16 (delta 7), pack-reused 3761
Receiving objects: 100% (3790/3790), 5.15 MiB | 1.11 MiB/s, done.
Resolving deltas: 100% (2403/2403), done.

Then I cd into my-app/ and run npm install and get the following:
npm WARN engine<EMAIL_ADDRESS>wanted: {"node":">=4.x","npm":">=3.x"} (current: {"node":"4.5.0","npm":"2.15.9"})
npm WARN engine<EMAIL_ADDRESS>wanted: {"node":">=4.x","npm":">=3.x"} (current: {"node":"4.5.0","npm":"2.15.9"})
npm WARN engine<EMAIL_ADDRESS>wanted: {"node":">=4.7"} (current: {"node":"4.5.0","npm":"2.15.9"})
npm WARN engine<EMAIL_ADDRESS>wanted: {"node":">=4.6"} (current: {"node":"4.5.0","npm":"2.15.9"})
npm WARN optional dep failed, continuing<EMAIL_ADDRESS>npm WARN optional dep failed, continuing<EMAIL_ADDRESS>npm WARN optional dep failed, continuing<EMAIL_ADDRESS>
><EMAIL_ADDRESS>install D:\Private Documents\Projects\my-app\my-app V3\my-app\node_modules\spectron\node_modules\electron-chromedriver
> node ./download-chromedriver.js

><EMAIL_ADDRESS>postinstall D:\Private Documents\Projects\my-app\my-app V3\my-app\node_modules\electron
> node install.js

npm WARN optional dep failed, continuing<EMAIL_ADDRESS>
><EMAIL_ADDRESS>install D:\Private Documents\Projects\my-app\my-app V3\my-app\node_modules\node-sass
> node scripts/install.js

Cached binary found at C:\Users\User Name\AppData\Roaming\npm-cache\node-sass\4.5.3\win32-x64-46_binding.node

><EMAIL_ADDRESS>postinstall D:\Private Documents\Projects\my-app\my-app V3\my-app\node_modules\node-sass
> node scripts/build.js

Binary found at D:\Private Documents\Projects\my-app\my-app V3\my-app\node_modules\node-sass\vendor\win32-x64-46\binding.node
Testing binary
Binary is fine

><EMAIL_ADDRESS>postinstall D:\Private Documents\Projects\my-app\my-app V3\my-app
> concurrently "npm run flow-typed" "npm run build" "npm run build-dll" "install-app-deps" "node node_modules/fbjs-scripts/node/check-dev-engines.js package.json"

[4]
[4] assert.js:89
[4]   throw new assert.AssertionError({
[4]   ^
[4] AssertionError: Current node version is not supported for development, expected "4.5.0" to satisfy ">=6.x".
[4]     at Object.<anonymous> (D:\Private Documents\Projects\my-app\my-app V3\my-app\node_modules\fbjs-scripts\node\check-dev-engines.js:39:3)
[4]     at Module._compile (module.js:409:26)
[4]     at Object.Module._extensions..js (module.js:416:10)
[4]     at Module.load (module.js:343:32)
[4]     at Function.Module._load (module.js:300:12)
[4]     at Function.Module.runMain (module.js:441:10)
[4]     at startup (node.js:139:18)
[4]     at node.js:974:3
[4] node node_modules/fbjs-scripts/node/check-dev-engines.js package.json exited with code 1
[3] Installing app dependencies for arch x64 to D:\Private Documents\Projects\my-app\my-app V3\my-app\app
[1]
[1] ><EMAIL_ADDRESS>build D:\Private Documents\Projects\my-app\my-app V3\my-app
[1] > concurrently "npm run build-main" "npm run build-renderer"
[1]
[0]
[0] ><EMAIL_ADDRESS>flow-typed D:\Private Documents\Projects\my-app\my-app V3\my-app
[0] > rimraf flow-typed/npm && flow-typed install --overwrite || true
[0]
[2]
[2] ><EMAIL_ADDRESS>build-dll D:\Private Documents\Projects\my-app\my-app V3\my-app
[2] > cross-env NODE_ENV=development node --trace-warnings -r babel-register ./node_modules/webpack/bin/webpack --config webpack.config.renderer.dev.dll.js --progress --profile --colors
[2]
[2] node: bad option: --trace-warnings
[2]
[2] npm
[2]  ERR!
[2]  Windows_NT 10.0.14393
[2] npm
[2]  ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "run" "build-dll"
[2] npm
[2]  ERR!
[2] node v4.5.0
[2] npm
[2]  ERR! npm  v2.15.9
[2] npm
[2] ERR! code ELIFECYCLE
[2] npm
[2] ERR<EMAIL_ADDRESS>build-dll: `cross-env NODE_ENV=development node --trace-warnings -r babel-register ./node_modules/webpack/bin/webpack --config webpack.config.renderer.dev.dll.js --progress --profile --colors`
[2] npm ERR!
[2]  Exit status 9
[2] npm ERR!
[2] npm ERR! Failed at the<EMAIL_ADDRESS>build-dll script 'cross-env NODE_ENV=development node --trace-warnings -r babel-register ./node_modules/webpack/bin/webpack --config webpack.config.renderer.dev.dll.js --progress --profile --colors'.
[2] npm ERR! This is most likely a problem with the electron-react-boilerplate package,
[2] npm
[2]  ERR! not with npm itself.
[2] npm ERR! Tell the author that this fails on your system:
[2] npm ERR!     cross-env NODE_ENV=development node --trace-warnings -r babel-register ./node_modules/webpack/bin/webpack --config webpack.config.renderer.dev.dll.js --progress --profile --colors
[2] npm
[2] ERR! You can get information on how to open an issue for this project with:
[2] npm ERR!     npm bugs electron-react-boilerplate
[2] npm ERR! Or if that isn't available, you can get their info via:
[2] npm
[2] ERR!
[2] npm ERR!
[2]      npm owner ls electron-react-boilerplate
[2] npm ERR! There is likely additional logging output above.
[2]
[2] npm ERR! Please include the following file with any support request:
[2] npm ERR!
[2]      D:\Private Documents\Projects\my-app\my-app V3\my-app\npm-debug.log
[2] npm run build-dll exited with code 1
[0] • Found 84 dependencies in package.json to install libdefs for. Searching...
[3] install-app-deps exited with code 0
[0] • rebasing flow-typed cache...
[1] [1]
[1] [1] ><EMAIL_ADDRESS>build-renderer D:\Private Documents\Projects\my-app\my-app V3\my-app
[1] [1] > cross-env NODE_ENV=production node --trace-warnings -r babel-register ./node_modules/webpack/bin/webpack --config webpack.config.renderer.prod.js --progress --profile --colors
[1] [1]
[1] [0]
[1] [0] ><EMAIL_ADDRESS>build-main D:\Private Documents\Projects\my-app\my-app V3\my-app
[1] [0] > cross-env NODE_ENV=production node --trace-warnings -r babel-register ./node_modules/webpack/bin/webpack --config webpack.config.main.prod.js --progress --profile --colors
[1] [0]
[1] [0] node: bad option: --trace-warnings
[1] [1] node: bad option: --trace-warnings
[1] [1]
[1] [0]
[1] [1] npm
[1] [0] npm ERR!
[1] [1]  ERR! Windows_NT 10.0.14393
[1] [1] npm
[1] [0]  Windows_NT 10.0.14393
[1] [0] npm ERR! argv
[1] [1]  ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "run" "build-renderer"
[1] [0]  "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "run" "build-main"
[1] [1] npm ERR!
[1] [1]  node v4.5.0
[1] [1] npm
[1] [0] npm ERR! node v4.5.0
[1] [1]  ERR! npm  v2.15.9
[1] [0] npm ERR! npm  v2.15.9
[1] [0] npm ERR! code ELIFECYCLE
[1] [0] npm ERR<EMAIL_ADDRESS>build-main: `cross-env NODE_ENV=production node --trace-warnings -r babel-register ./node_modules/webpack/bin/webpack --config webpack.config.main.prod.js --progress --profile --colors`
[1] [0] npm ERR! Exit status 9
[1] [0] npm ERR!
[1] [0] npm ERR! Failed at the<EMAIL_ADDRESS>build-main script 'cross-env NODE_ENV=production node --trace-warnings -r babel-register ./node_modules/webpack/bin/webpack --config webpack.config.main.prod.js --progress --profile --colors'.
[1] [0] npm
[1] [1] npm ERR! code ELIFECYCLE
[1] [1] npm ERR<EMAIL_ADDRESS>build-renderer: `cross-env NODE_ENV=production node --trace-warnings -r babel-register ./node_modules/webpack/bin/webpack --config webpack.config.renderer.prod.js --progress --profile --colors`
[1] [1] npm ERR! Exit status 9
[1] [1] npm ERR!
[1] [1] npm ERR! Failed at the<EMAIL_ADDRESS>build-renderer script 'cross-env NODE_ENV=production node --trace-warnings -r babel-register ./node_modules/webpack/bin/webpack --config webpack.config.renderer.prod.js --progress --profile --colors'.
[1] [0]  ERR! This is most likely a problem with the electron-react-boilerplate package,
[1] [0] npm ERR! not with npm itself.
[1] [0] npm ERR! Tell the author that this fails on your system:
[1] [0] npm ERR!     cross-env NODE_ENV=production node --trace-warnings -r babel-register ./node_modules/webpack/bin/webpack --config webpack.config.main.prod.js --progress --profile --colors
[1] [0] npm ERR! You can get information on how to open an issue for this project with:
[1] [0] npm ERR!     npm bugs electron-react-boilerplate
[1] [0] npm ERR! Or if that isn't available, you can get their info via:
[1] [0] npm ERR!
[1] [0] npm ERR!     npm owner ls electron-react-boilerplate
[1] [0] npm ERR! There is likely additional logging output above.
[1] [1] npm ERR! This is most likely a problem with the electron-react-boilerplate package,
[1] [1] npm ERR! not with npm itself.
[1] [1] npm ERR! Tell the author that this fails on your system:
[1] [1] npm ERR!     cross-env NODE_ENV=production node --trace-warnings -r babel-register ./node_modules/webpack/bin/webpack --config webpack.config.renderer.prod.js --progress --profile --colors
[1] [1] npm ERR! You can get information on how to open an issue for this project with:
[1] [1] npm ERR!     npm bugs electron-react-boilerplate
[1] [1] npm ERR!
[1] [1]  Or if that isn't available, you can get their info via:
[1] [1] npm ERR!
[1] [1] npm ERR!     npm owner ls electron-react-boilerplate
[1] [1] npm
[1] [1]  ERR! There is likely additional logging output above.
[1] [0]
[1] [0] npm ERR! Please include the following file with any support request:
[1] [0] npm ERR!     D:\Private Documents\Projects\my-app\my-app V3\my-app\npm-debug.log
[1] [1]
[1] [1] npm ERR! Please include the following file with any support request:
[1] [1] npm ERR!     D:\Private Documents\Projects\my-app\my-app V3\my-app\npm-debug.log
[1] [1] npm run build-renderer exited with code 1
[1] [0] npm run build-main exited with code 1
[1]
[1] npm
[1]  ERR! Windows_NT 10.0.14393
[1] npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "run" "build"
[1] npm ERR! node
[1]  v4.5.0
[1] npm ERR! npm  v2.15.9
[1] npm ERR! code ELIFECYCLE
[1] npm ERR<EMAIL_ADDRESS>build: `concurrently "npm run build-main" "npm run build-renderer"`
[1] npm ERR! Exit status 1
[1] npm ERR!
[1]
[1] npm ERR! Failed at the<EMAIL_ADDRESS>build script 'concurrently "npm run build-main" "npm run build-renderer"'.
[1] npm ERR! This is most likely a problem with the electron-react-boilerplate package,
[1] npm ERR!
[1]  not with npm itself.
[1] npm ERR! Tell the author that this fails on your system:
[1] npm ERR!     concurrently "npm run build-main" "npm run build-renderer"
[1] npm ERR! You can get information on how to open an issue for this project with:
[1] npm ERR!     npm bugs electron-react-boilerplate
[1] npm ERR! Or if that isn't available, you can get their info via:
[1] npm ERR!
[1] npm ERR!
[1]      npm owner ls electron-react-boilerplate
[1] npm ERR! There is likely additional logging output above.
[1]
[1] npm ERR! Please include the following file with any support request:
[1] npm ERR!     D:\Private Documents\Projects\my-app\my-app V3\my-app\npm-debug.log
[1] npm run build exited with code 1
[0] • Installing 11 libDefs...
[0]   • react-router_v4.x.x.js
[0]     └> .\flow-typed\npm\react-router_v4.x.x.js
[0]   • react-router-dom_v4.x.x.js
[0]     └> .\flow-typed\npm\react-router-dom_v4.x.x.js
[0]   • redux_v3.x.x.js
[0]     └> .\flow-typed\npm\redux_v3.x.x.js
[0]   • chalk_v1.x.x.js
[0]     └> .\flow-typed\npm\chalk_v1.x.x.js
[0]   • enzyme_v2.3.x.js
[0]     └> .\flow-typed\npm\enzyme_v2.3.x.js
[0]   • react-redux_v5.x.x.js
[0]     └> .\flow-typed\npm\react-redux_v5.x.x.js
[0]   • express_v4.x.x.js
[0]     └> .\flow-typed\npm\express_v4.x.x.js
[0]   • minimist_v1.x.x.js
[0]     └> .\flow-typed\npm\minimist_v1.x.x.js
[0]   • jest_v20.x.x.js
[0]     └> .\flow-typed\npm\jest_v20.x.x.js
[0]   • flow-bin_v0.x.x.js
[0]     └> .\flow-typed\npm\flow-bin_v0.x.x.js
[0]   • react-addons-test-utils_v15.x.x.js
[0]     └> .\flow-typed\npm\react-addons-test-utils_v15.x.x.js
[0] • Generating stubs for untyped dependencies...
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\babel-plugin-dev-expression_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\eslint-formatter-pretty_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\file-loader_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\electron-debug_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\source-map-support_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\rimraf_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\eslint-import-resolver-webpack_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\stylelint-config-standard_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\style-loader_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\url-loader_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\font-awesome_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\react-router-redux_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\babel-eslint_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\history_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\babel-jest_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\babel-plugin-dynamic-import-webpack_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\babel-plugin-transform-class-properties_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\redux-thunk_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\babel-preset-react-hmre_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\babel-preset-env_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\babel-plugin-add-module-exports_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\babel-polyfill_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\asar_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\babel-preset-react-optimize_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\babel-preset-react_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\babel-preset-stage-0_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\css-loader_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\babili-webpack-plugin_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\babel-register_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\enzyme-to-json_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\electron-devtools-installer_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\eslint-config-airbnb_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\redux-logger_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\extract-text-webpack-plugin_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\eslint-plugin-flowtype-errors_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\sass-loader_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\stylefmt_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\html-webpack-plugin_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\spectron_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\webpack-merge_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\cross-spawn_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\cross-env_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\babel-plugin-transform-es2015-classes_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\concurrently_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\electron_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\eslint-plugin-compat_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\react-hot-loader_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\babel-loader_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\eslint-plugin-import_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\eslint-plugin-jest_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\eslint-plugin-react_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\eslint-plugin-promise_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\identity-obj-proxy_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\fbjs-scripts_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\webpack_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\react-test-renderer_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\webpack-bundle-analyzer_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\devtron_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\flow-typed_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\eslint_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\eslint-plugin-flowtype_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\eslint-plugin-jsx-a11y_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\webpack-dev-server_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\stylelint_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\sinon_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\babel-core_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\flow-runtime_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\jsdom_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\electron-builder_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\node-sass_vx.x.x.js
[0]   •<EMAIL_ADDRESS>[0]     └> flow-typed\npm\babel-plugin-flow-runtime_vx.x.x.js
[0]
[0] !! No<EMAIL_ADDRESS>libdefs found in flow-typed for the above untyped dependencies !!
[0]
[0] I've generated `any`-typed stubs for these packages, but consider submitting
[0] libdefs for them to https://github.com/flowtype/flow-typed/
[0]
[0] npm run flow-typed exited with code 0

npm ERR!  Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script 'concurrently "npm run flow-typed" "npm run build" "npm run build-dll" "install-app-deps" "node node_modules/fbjs-scripts/node/check-dev-engines.js package.json"'.
npm ERR! This is most likely a problem with the electron-react-boilerplate package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     concurrently "npm run flow-typed" "npm run build" "npm run build-dll" "install-app-deps" "node node_modules/fbjs-scripts/node/check-dev-engines.js package.json"
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs electron-react-boilerplate
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls electron-react-boilerplate
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     D:\Private Documents\Projects\my-app\my-app V3\my-app\npm-debug.log

User Name@LAPTOP-O4CEJQSE MINGW64 /d/Private Documents/Projects/my-app/my-app V3/my-app (master)
$ npm run hot-server
npm ERR! Windows_NT 10.0.14393
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "run" "hot-server"
npm ERR! node v4.5.0
npm ERR! npm  v2.15.9

npm ERR! missing script: hot-server
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     D:\Private Documents\Projects\my-app\my-app V3\my-app\npm-debug.log

The npm-debug.log is as follows:
0 info it worked if it ends with ok
1 verbose cli [ 'C:\\Program Files\\nodejs\\node.exe',
1 verbose cli   'C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js',
1 verbose cli   'run',
1 verbose cli   'hot-server' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose stack Error: missing script: hot-server
4 verbose stack     at run (C:\Program Files\nodejs\node_modules\npm\lib\run-script.js:142:19)
4 verbose stack     at C:\Program Files\nodejs\node_modules\npm\lib\run-script.js:58:5
4 verbose stack     at C:\Program Files\nodejs\node_modules\npm\node_modules\read-package-json\read-json.js:356:5
4 verbose stack     at checkBinReferences_ (C:\Program Files\nodejs\node_modules\npm\node_modules\read-package-json\read-json.js:320:45)
4 verbose stack     at final (C:\Program Files\nodejs\node_modules\npm\node_modules\read-package-json\read-json.js:354:3)
4 verbose stack     at then (C:\Program Files\nodejs\node_modules\npm\node_modules\read-package-json\read-json.js:124:5)
4 verbose stack     at C:\Program Files\nodejs\node_modules\npm\node_modules\read-package-json\read-json.js:311:12
4 verbose stack     at C:\Program Files\nodejs\node_modules\npm\node_modules\graceful-fs\graceful-fs.js:78:16
4 verbose stack     at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:380:3)
5 verbose cwd D:\Private Documents\Projects\my-app\my-app V3\my-app
6 error Windows_NT 10.0.14393
7 error argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "run" "hot-server"
8 error node v4.5.0
9 error npm  v2.15.9
10 error missing script: hot-server
11 error If you need help, you may report this error at:
11 error     <https://github.com/npm/npm/issues>
12 verbose exit [ 1, true ]

If I can provide anything else, please let me know! (I'm a total newbie, so any help is much appreciated!)

The error message says AssertionError: Current node version is not supported for development, expected "4.5.0" to satisfy ">=6.x".. I think it would help a lot of the errors were more minimal and readable. Probably going to PR for this soon. The solution is to install node 6 or any version greater than it. I recommend node 7.

Oh... Wow, duh. Okay! Thanks so much! Just tested and everything works!!!!


[dvm] List installer packages starting at 1 not 0

Other parts of the installer selection code assume that the user
gave us a number starting from 1.

:+1:


gig.js create gig function

Need to fix this so when someone submits the gig the system stores it.

Error: Failed to create project

Users are able to submit gigs.


docs: Clarify instructions for bumping K8s to avoid forks

Opening a PR against a branch on a fork won't properly test all of the
changes in the PR because parts of the CI suite don't pick up the
changes in the workflows for security reasons.
Signed-off-by: Chris Tarazi<EMAIL_ADDRESS>

/test

/test


"switch" command in terminal goes to moons catalogue

When viewing the monitor on the terminal, the "switch" command should change the currently monitored player to the next player in the cycle. Currently the "switch" command doesn't do that and instead brings up the exomoons catalogue. This makes it harder/slower to change the monitor. Interestingly typing "switch [player_name]" still works and changes the monitor to view that player.

+1 here.
It is not just limited to switch but also affects commands from other mods that are non-confirmation and also have a terminalEvent set

It's not just the latest version of the mod that has this problem. The problem seems to have been around since version 1.1.0. And it can happen in games where only this mod is installed

+1
The stock command added by the StockOverview mod also redirects to the Moons screen of the terminal instead of showing the intended stock screen:
https://github.com/IAmBatby/LethalLevelLoader/assets/3759901/4ca6d965-ac90-419d-ab31-0039379ecbb4

Will be fixed in the forthcoming update. Apologies on the delay as I've been unwell. Thank you all for the report and apologies for the inconvenience.

Will the update fix ALL of them? I recently found that the "Slots" commands from the gamba mod also does the same thing.

It seems like the "Simulate" command doesn't work either.

Will be fixed in the forthcoming update. Apologies on the delay as I've been unwell. Thank you all for the report and apologies for the inconvenience.

Get well soon.
Let it be known you are a special hard working altruistic dev. 🥺

Resolved in future versions of the project.


Fix Odb.RemoveRoutingObstructions failing with non-integer coordinates

When specifying non integer coordinates in ROUTING_OBSTRUCTIONS, the Odb.RemoveRoutingObstructions would fail as it would truncate the decimal part before trying to match the coordinate.
For example, the following config would fail on any project (due to 16.5 appearing in the coordinate list):
  "ROUTING_OBSTRUCTIONS": [
    "met1 10 10 20 16.5"
  ],

Why are we converting dbus to microns just to convert them back to DBUs? @kareefardi

Why are we converting dbus to microns just to convert them back to DBUs? @kareefardi

add_obstructions:

takes microns
convert to dbus
creates an obstruction using dbu

remove_obstructions:

takes microns
iterates over existing obstructions (in dbu)
converts to microns for comparison
removes if match

There is no redundancy here. The input should be in microns

why not convert both to dbus and compare in integer space where things are more reliable?

@kareefardi I updated the code to not use floats. Please review.


Update dependencies

Fixes https://github.com/ga4gh/gh-openapi-docs/issues/75
Fixes https://github.com/ga4gh/gh-openapi-docs/issues/56
Changelogs

Update npm and github-actions dependencies
Remove deprecated dependency mocha-webpack (last updated 3 years ago)

This breaks the npm script npm run test, which should be fixed in a separated PR (need to find an alternative to mocha-webpack)

Made early preparation for future release 0.3.0

$ ncu -u
Upgrading /home/tschaffter/dev2/tschaffter/gh-openapi-docs/package.json
[====================] 36/36 100%

 @babel/runtime                     ^7.6.3  →   ^7.14.0
 @redocly/openapi-cli                0.8.4  →   0.12.16
 chalk                               2.4.2  →     4.1.1
 is-ci                              ^2.0.0  →    ^3.0.0
 loader-utils                       ^1.4.0  →    ^2.0.0
 lodash                           ^4.17.19  →  ^4.17.21
 oas-linter                         ^3.0.2  →    ^3.2.1
 oas-resolver                       ^2.2.7  →    ^2.5.4
 oas-validator                      ^3.3.3  →    ^5.0.5
 redoc-cli                          ^0.9.7  →   ^0.11.4
 shelljs                            ^0.7.0  →    ^0.8.4
 swagger-ui-dist                    3.24.0  →    3.48.0
 update-notifier                     3.0.1  →     5.1.0
 yargs-parser                      ^19.0.4  →   ^20.2.7
 @babel/cli                        ^7.10.1  →  ^7.13.16
 @babel/compat-data                ^7.10.1  →   ^7.14.0
 @babel/core                       ^7.10.2  →   ^7.14.0
 @babel/node                       ^7.10.1  →  ^7.13.13
 @babel/plugin-transform-runtime    ^7.8.3  →  ^7.13.15
 @babel/preset-env                  ^7.8.7  →   ^7.14.1
 @babel/register                    ^7.9.0  →  ^7.13.16
 babel-loader                       ^8.0.6  →    ^8.2.2
 cross-env                          ^7.0.2  →    ^7.0.3
 mocha                              ^7.1.1  →    ^8.4.0
 nyc                               ^15.0.1  →   ^15.1.0
 pkg                                ^4.4.4  →    ^5.1.0
 webpack                           ^4.42.0  →   ^5.37.0
 webpack-cli                       ^3.3.11  →    ^4.7.0
 webpack-node-externals             ^1.7.2  →    ^3.0.0

Run npm install to install new versions.

After ncu -u and npm install, there are still a few messages about deprecated dependencies:
$ npm install
npm WARN deprecated<EMAIL_ADDRESS>🚨 This package has been deprecated in favor of separate inclusion of a polyfill and regenerator-runtime (when needed). See the @babel/polyfill docs (https://babeljs.io/docs/en/babel-polyfill) for more information.
npm WARN deprecated<EMAIL_ADDRESS>core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.
npm WARN deprecated<EMAIL_ADDRESS>Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
npm WARN deprecated<EMAIL_ADDRESS>fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
npm WARN deprecated<EMAIL_ADDRESS>https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>Please see https://github.com/lydell/urix#deprecated
...
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/mocha-webpack/node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN<EMAIL_ADDRESS>requires a peer of mocha@>=4 <=5 but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^3.0.0 || ^4.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/redoc-cli/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 1264 packages from 491 contributors and audited 1266 packages in 22.551s

98 packages are looking for funding
  run `npm fund` for details

found 17 vulnerabilities (1 low, 2 moderate, 13 high, 1 critical)
  run `npm audit fix` to fix them, or `npm audit` for details

The output seems correctly generated now that I have created .spec-docs.json.
$ node ./dist/bundle.js
Preparing docs for API spec at 'test/test-spec/combined/openapi.yaml' (75-update-dependencies)

Cloning 'gh-pages' branch into '/home/tschaffter/dev2/tschaffter/gh-openapi-docs/.ghpages-tmp'
Cloning into '.'...
cp: no such file or directory: preview

Branch folder:
/home/tschaffter/dev2/tschaffter/gh-openapi-docs/preview/75-update-dependencies/

API spec (root) location:
/home/tschaffter/dev2/tschaffter/gh-openapi-docs/test/test-spec/combined/openapi.yaml

Bundling API spec...

Storing bundled 'openapi.json' and 'openapi.yaml' in:
/home/tschaffter/dev2/tschaffter/gh-openapi-docs/preview/75-update-dependencies/

Generating standalone ReDoc HTML:
/home/tschaffter/dev2/tschaffter/gh-openapi-docs/preview/75-update-dependencies/docs/index.html

Done (in 2s.)

Output:
$ ls -alR preview/75-update-dependencies/
preview/75-update-dependencies/:
total 36
drwxr-xr-x 3 tschaffter tschaffter  4096 May 11 21:48 .
drwxr-xr-x 3 tschaffter tschaffter  4096 May 11 21:43 ..
drwxr-xr-x 2 tschaffter tschaffter  4096 May 11 21:48 docs
-rw-r--r-- 1 tschaffter tschaffter 10892 May 11 21:48 openapi.json
-rw-r--r-- 1 tschaffter tschaffter  8603 May 11 21:48 openapi.yaml

preview/75-update-dependencies/docs:
total 1308
drwxr-xr-x 2 tschaffter tschaffter    4096 May 11 21:48 .
drwxr-xr-x 3 tschaffter tschaffter    4096 May 11 21:48 ..
-rw-r--r-- 1 tschaffter tschaffter 1329941 May 11 21:48 index.html

TODO
Investigate why running the tool without the config file - which I think is optional? - does not generate files.
Note: This is likely because the the tool didn't know where to find the file openapi.yaml. Yet the tool didn't report an error and the output of echo $? after running the tool is 0, which indicates that the tool exited successfully. Probably linked to https://github.com/ga4gh/gh-openapi-docs/issues/60.


Refactor access request UI flow to avoid draft shares

From our experience users who are using data.all for the first time find it very confusing/unintuitive that when they request access to a dataset that this creates a draft share which needs to be further filled out and then submitted. There are a few text notices for this but most folks just don't see them.
I propose that we completely get rid of access request modal and create a new page form where a user has to additionally specify what he wants to be shared with them and submitting this form actually submits the share to the dataset owner. This will ensure that it is impossible to think that a share was created and sent to another team while in fact it is still in draft mode.
I would also use this to make another improvement. From my experience a lot of new users get confused with the optional field of consumer role. They often submit an access request to their team role rather than consumer role. They then think that somehow their environment now has access and becuse they registered the roles on their environment they have access too which is obviously not the case. People don't understand what requesting access for a team means. We should make this explicit and make people choose what they want to share for - a team role or their own iam role... The change is basically making people make a conscious decision vs having an optional field which can be ignored. We want users to actively think - what should I be choosing here?

@noah-paige @dlpzx I would put a lot of priority on this one.. This one is currently causing a lot of issues where people reach out to us because they think sharing does not work when in fact the issue is because they don't understand the UI...

Hi @zsaltys thanks for the issue. There is definitely room for potential in the sharing UX. I will tag this item ans high priority and we will try to work on it as soon as possible.

Completed


Update ocicni to my fork.

Update ocicni to include https://github.com/cri-o/ocicni/pull/17, https://github.com/cri-o/ocicni/pull/13 and https://github.com/cri-o/ocicni/pull/16.
Fixes https://github.com/containerd/cri-containerd/issues/580, https://github.com/containerd/cri-containerd/issues/573, https://github.com/containerd/cri-containerd/issues/545.
I'll point the vendor back to cri-o/ocicni after pending PRs are merged.
Signed-off-by: Lantao Liu<EMAIL_ADDRESS>

LGTM


Plugin author can write static analyzer plugins for native code

Native developers often rely on various static analyzers. These analyzers need access to the argument used during compilation. Some compiler options aren't accessible to the plugin author as they are handled by the tool chain as opposed to the compile task.
Expected Behavior
Gradle native model should expose enough public APIs to enable users to write static analyzer plugins support for Gradle.
Test Cases
Please comment on this epic static analyzers to consider in this work.

I am currently trying to integrate 'clang-tidy' which requires a compilation database with the full compiler command.  Here is an example of the compilation database:
Here is an example compile database for clang-tidy. This is what I would like to generate.
[
{
"directory": "/root/gradle_clang_test",
"command": "/usr/bin/clang++ -x c++ -c -I /root/gradle_clang_test/src/hello/headers clang_test.cpp",
"file": "/root/gradle_clang_test/clang_test.cpp",
},
{
"directory": "/root/gradle_clang_test",
"command": "/usr/bin/clang++ -x c++ -c -DFOO -I /root/gradle_clang_test/src/hello/headers clang_test2.cpp",
"file": "/root/gradle_clang_test/clang_test2.cpp",
}
]


WindowOptions.Position is not respected

Summary
Setting the Position in the WindowOptions used to create a window does not change anything.
Other Options work fine.
Steps to reproduce

Platform: Desktop (Win 10)
Framework Version: .NET6

It's 100% reproducible for me using this code in the Program.cs of a ConsoleApplication referencing the current NuGet (2.16.0) of Silk.NET
using Silk.NET.Maths;
using Silk.NET.Windowing;

WindowOptions options = WindowOptions.Default;
options.Position = new Vector2D<int>(1000, 0);

// These two work as expected (they don't have any impact on the problem)
options.Size = new Vector2D<int>(1280, 1440);
options.WindowBorder = WindowBorder.Hidden;

Window.Create(options).Run();

Comments
A borderless window appears always in the top left (0,0), the position of windows with border seems to be somehow dependant of the mouse position on startup.
Checking the Position of the Window in the debugger before running it returns the expected value:

This also happens to me on Linux with a regular window. If I want to center the window, I have to do it after Initialize(), but then there'll be a brief moment where it appears in the "wrong" place - one of the corners of my monitor.

Ohh, that's a good hint. Indeed this works:
using Silk.NET.Maths;
using Silk.NET.Windowing;

WindowOptions options = WindowOptions.Default;
//options.Position = new Vector2D<int>(2000, 0);
options.Size = new Vector2D<int>(1280, 1440);
options.WindowBorder = WindowBorder.Hidden;

IWindow window = Window.Create(options);
window.Initialize();
window.Position = new Vector2D<int>(2000, 0);
window.Run();

without the Initialize setting the position does not work for me (even after it's running).

Alternatively, instead of calling Initialize yourself, you can set the position in the Load event.

I tried to set it in the Load event and it does not work.


GithubMediaStore#delete & sha issue

If the file doesn't exist then no sha is found. In this case it should throw an error.

note: if the media folder is empty, the MediaManager crashes in an ugly fashion

Woah! Thanks a lot!
@all-contributors please add @CodeItQuick for bugs


someone is using reCAPTCHA (I'm trying but it doesn't works)?

I've registered my site and get the private code and site cote

I'ìve edited the appsettings.json:
"AppSettings": {
"RecaptchaPrivateKey": "put here my private key",
"PasswordChangeOptions": {
"UseAutomaticContext": true,
"LdapHostname": "",
"LdapPort": 389,
"LdapUsername": "",
"LdapPassword": ""
},
"ClientSettings": {
"ShowPasswordMeter": true,
"Recaptcha": {
"IsEnabled": true,
"SiteKey": "put here my prite key",
"LanguageCode": "en"

after restarting the webserver , I see the recaptcha option (I'm not a robot) on the change password screen;

clicking on I'm not a robot I see the selection window (select all the the square with ....)

after the square selection the recaptcha verification work fine and the browser returns on the change password;
6)then, if I submit the form (with correct username, old password and new password) the the change password task doesn't works wits a recaptcha verification problem

I've registered my site and get the private code and site cote

I'ìve edited the appsettings.json:
"AppSettings": {
"RecaptchaPrivateKey": "put here my private key",
"PasswordChangeOptions": {
"UseAutomaticContext": true,
"LdapHostname": "",
"LdapPort": 389,
"LdapUsername": "",
"LdapPassword": ""
},
"ClientSettings": {
"ShowPasswordMeter": true,
"Recaptcha": {
"IsEnabled": true,
"SiteKey": "put here my prite key",
"LanguageCode": "en"

after restarting the webserver , I see the recaptcha option (I'm not a robot) on the change password screen;

clicking on I'm not a robot I see the selection window (select all the the square with ....)

after the square selection the recaptcha verification work fine and the browser returns on the change password;
6)then, if I submit the form (with correct username, old password and new password) the the change password task doesn't works wits a recaptcha problem.

It's working to someone?
(I would like to use because increase the security ... and is very nice! )
Thanks in advance to all!

Yes, all working perfect.
look:
"RecaptchaPrivateKey": "put here my private key"  - ok, Secret key
"SiteKey": "put here my private key",  - no, put here you Site key

@merocle Thanks!

Hi, I had the same issue on IIS 10 and reCAPTCHA v2 , the message was: could not verify you are not a robot. I put the right "Recaptcha": {
"SiteKey": "...",
"PrivateKey": ".."


Enable linters also on Jupyter notebooks

When we work with *.py files, we can select a Linter (e.g. flake8) and it will support us to be PEP8 complaint. Hence, I'm asking for the same functionality, but in the *.ipynb files.
Is there any chance this feature will be included in future releases?

Thanks for the feature request! We are going to give the community 60 days from when this issue was created to provide 5 👍 upvotes on the opening comment to gauge general interest in this idea. If there's enough upvotes then we will consider this feature request in our future planning. If there's unfortunately not enough upvotes then we will close this issue.

While this didn't meet our upvote threshold, LSP is looking at adding notebook support and thus we can look at supporting it when we redo linting support as separate extensions using LSP.

Just want to mention, regarding upvote threshold, that I've personally been interested ipn this feature for more than a year, but it's REALLY difficult to track this issue, as it's floated around to so many places.
Really hope the LSP thing brings support for this, I'm sure a lot of people would like this, but just can't find it.

@MarthinusBosman The LSP specification 3.17 which adds the Notebook support was published recently. The Python LSP implementation that we depend on pygls (an external project) is working on updating to the LSP 3.17 spec. Once that is done, we can start enabling this in the tools specific extensions, like pylint here https://github.com/microsoft/vscode-pylint/issues/20 and flake8 here https://github.com/microsoft/vscode-flake8/issues/31

@karthiknadig That's great news!

There's a lot more interest in this today, going by the latest comments and upvotes on microsoft/vscode-jupyter#1231 in the last year alone.
For those interested who can't wait, there's a workaround that exists today to get pygls working with notebooks detailed in openlawlibrary/pygls#311 and an issue to track 3.17 progress (nearly there!) in openlawlibrary/pygls#346.
There's even more relevant discussion that can be found at openlawlibrary/pygls#356 and openlawlibrary/pygls#357.

It seems like Microsoft gave up on VS Code Jupyter Notebook Linting (as the microsoft/vscode-jupyter/issues/1231 has been closed?

The linting support will be handled by individual linter extensions, and not in the Jupyter Extension.
FYI, https://github.com/openlawlibrary/pygls/issues/311 just merged last week. Once that is released we can begin the work to add this support in the linter extensions.

For reference, I've a working implementation for Ruff at https://github.com/astral-sh/ruff-lsp/pull/264

@dhruvmanila I have left some minor comments.

This is now tracked in linter specific extension repos:
pylint: https://github.com/microsoft/vscode-pylint/issues/20
flake8: https://github.com/microsoft/vscode-flake8/issues/31


Add GA and cookie consent to the Prototype Kit website

What
Add Google Analytics and Cookie consent to the Prototype Kit website
Why
To collect analytics consistently with other GOV.UK product sites
Who
Developers
Done when

[x] There is a standard cookie consent banner
[ ] GA collects data only when consent is given via the banner
[x] Cookies page is updated

from meeting with Data services the recommendation is to wait for the new 'lightweight tracking schema' which will be available in April. Alternatively we can go ahead with the old tracking code

@nataliecarey tracking code:
<!-- Google tag (gtag.js) -->
<script async src="https://www.googletagmanager.com/gtag/js?id=UA-26179049-11"></script>
<script>
  window.dataLayer = window.dataLayer || [];
  function gtag(){dataLayer.push(arguments);}
  gtag('js', new Date());

  gtag('config', 'UA-26179049-11');
</script>

Data doesn't seem to be stored.


CosmosClient creation through CosmosClientOptions

CosmosClient creation through ComsosClientOptions
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Closing issues
closes #314

@kirankumarkolli Has this change shipped in nuget? Which version of SDK has this change?


Performance improvement

If you have any suggestions to improve the performance of the library (and still working with all kinds of route constraints), please let me know with a comment or pull request.

Expression field resolving improved the performance as maximum as possible.


Replace validation banners

https://trello.com/c/x5aacZhG/282-1-replace-validation-banner-with-govuk-frontend-error-summary-component-in-the-brief-responses-frontend
It was a bit tricky to know where to bound this ticket, as there were a few issues with boolean type questions (https://github.com/alphagov/digitalmarketplace-content-loader/pull/119) and with the focus of Error Summary links.
Since the content loader ticket (https://trello.com/c/13tOvxuu/285-2-replace-content-loader-form-macros-in-brief-responses-frontend) should take care of the focus issues for most questions, my strategy is to keep this a separate concern and not fix the focus issues (specifically, that clicking on a link in the Error Summary can pull focus to the question but not show the question title, since it's been separately set as the page header).
Then we can handle those in the other ticket and release both PRs together.
digitalmarketplace-frameworks
This PR relies on some content changes to the frameworks repo, for validation messages: https://github.com/alphagov/digitalmarketplace-frameworks/pull/656

My review checklist
I've:

[ ] looked at the code
[ ] tested locally
[ ] run functional tests locally


feat: Edge support more platform

Currently cookies are stored in the same way as the Chrome browser stores them.
so, reuse chrome's code
Platform:

[x] Mac
[x] Win

Hope this submission can be merged
This repo only implemented windows version and did not support MacOs.

Sorry, I don't know why GitHub never notified this PR to me, sorry for the delay! Will take a look as soon as possible, thank you.

Sorry, I don't know why GitHub never notified this PR to me, sorry for the delay! Will take a look as soon as possible, thank you.

It doesn't matter. I hope some of the problems can be solved.

Hi @kalifun, thank you very much for your work.
I made some modifications based on your commits, but for some reason, GitHub does not allow me to add a commit to your branch.

Therefore, I have created a new pull request based on your work #4. Would you please be able to review it?

Hi @kalifun, thank you very much for your work.
I made some modifications based on your commits, but for some reason, GitHub does not allow me to add a commit to your branch.
Therefore, I have created a new pull request based on your work #4. Would you please be able to review it?

I'm very sorry. Working overtime today. I'll deal with it tomorrow.

Thanks, #4 has been merged, I'll create a PR on https://github.com/j178/leetgo to bump the version. I'll close this as completed.


Fix adding 1 day when picking dates

Fixes #120  .
Changes proposed in this pull request:
remove + 1 from here:
 formatDate(year, month, day) {
      return new Date(year, month, day + 1).toISOString().split('T')[0];
    },

@surfer77 Thanks for your PR! This is a known issue #120 some users get an extra days for some reason. I've never been able to reproduce that issue. When i test your fix, it doesn't work for me, it giving me 1 day earlier than what i select. Can you reproduce that issue on others devices?

@surfer77 Thanks for your PR! This is a known issue #120 some users get an extra days for some reason. I've never been able to reproduce that issue. When i test your fix, it doesn't work for me, it giving me 1 day earlier than what i select. Can you reproduce that issue on others devices?

I get the +1 day issue on my mac osx on chrome.
Will try to find time this week to keep checking on it

I get the +1 day issue on my mac osx on chrome.
Will try to find time this week to keep checking on it

Closing this PR this was fixed in another PR


Esp 8266 (AEGHB-40)

I am trying to have a duplex communication with an esp32 and an esp8266-01.
Is it supported? Or just communications between esp32s?

ESP8266 supports esp-now basic APIs like in https://docs.espressif.com/projects/esp-idf/en/latest/esp32c3/api-reference/network/esp_now.html. This project is developed based on these basic APIs, but haven't been ported on ESP8266. Refer to the project, you may develop your own esp-now project on ESP8266.

@renanmbs Any update about this?

I was able to send some bytes to xFFFF, and the esp32 received it. But I wasn’t able to do a duplex communication as I was intending

@renanmbs Thanks for your feedback, i'll check it again.

@renanmbs The master branch of ESP8266 has fix the issue, please update and try again.

@renanmbs Closing this issue since there has been no update on this. Please feel free to reopen if required.


Ambiguity in spec: should root info be updated when package download fails?

Section 5.1 starts with "If it any point in the following process there is a problem ... the root file is downloaded and the process starts over". But it isn't entirely clear to me "the following process" refers to just the check for updates, or whether it also covers actually downloading a target file. I am assuming (and have implemented) the former, but I'm not sure.

The former is correct, the root file is downloaded and the process starts over if any of the other top-level metadata cannot be successfully updated.
Here is the client application workflow, as outlined in section 5.1 of tuf-spec.txt, implemented in Python:
https://github.com/theupdateframework/tuf/blob/develop/tuf/client/updater.py#L563-L669
I'll try to remove the ambiguity from the specification.

We fixed it in the specification by making updating the root the first thing


Use arguments when running bot

Hi,
can we give some parameters to a bot when running?
It is useful for easy switching of parameters in the bot.
For example, what I want is like the below (I know this doesn't work)
bot = Bot()
bot.run(port=23456, emotion="angry", max_timeout=10)

This would be the correct way to handle configuration. Currently, the slackbot_settings module is hardcoded to load dynamically, but if you have a build system that puts things in non-standard places (as I do) then this will break.
In fact I'm currently patching the slackbot.settings module to load slackbot_settings from our namespace (our build system prefixes modules with the company name, like Company.Project.slackbot_settings).


Single level usage as planned 1.1.0

Description
We need to update this Aspect to include all Part versions and validity (asPlanned) to cover the versioning of components and vehicles.
Added

optional validity period for child-parent relation

Changed

descriptions to more explicitly describe handling of versions of child parts
updated reference for SAMM Unit Catalog to a more stable one
all characteristics, entities, and constraints now have proper names, preferred names and descriptions
fixed some typos in preferred names and descriptions

-->
Closes #74

MS2 Criteria
(to be filled out by PR reviewer)

[ ] the model validates with the BAMM SDS SDK in the version specified in the Readme.md of this repository by the time of the MS2 check  (e.g., 'java -jar bamm-cli.jar -i <path-to-aspect-model> -v ). The  BAMM CLI is available here and in GitHub
[ ] use Camel-Case (e.g., "MyModelElement" or "TimeDifferenceGmtId", when in doubt follow https://google.github.io/styleguide/javaguide.html#s5.3-camel-case)
[ ] the identifiers for all model elements start with a capital letter except for properties
[ ] the identifier for properties starts with a small letter
[ ] all model elements at least contain the fields "name" and "description" in English language.
[ ] no duplicate names or preferredNames within an Aspect (e.g. a Property and the referenced Characteristic should not have the same name)
[ ] the versioning in the URN follows semantic versioning, where minor version bumps are backwards compatible and major version bumps are not backwards compatible.
[ ] use abbreviations only when necessary and if these are sufficiently common
[ ] avoid redundant prefixes in property names (consider adding properties to an enclosing Entity or even adapt the namespace of the model elements, e.g., instead of having two properties DismantlerId and DismantlerName use an Entity Dismantler with the properties name and id or use a URN like io.catenax.dismantler:0.0.1)
[ ] fields preferredName and description are not the same
[ ] preferredName should be human readable and follow normal orthography (e.g., no camel case but normal word separation)
[ ] name of aspect is singular except if it only has one property which is a Collection, List or Set. In theses cases, the aspect name is plural.
[ ] units are referenced from the BAMM unit catalog whenever possible
[ ] use constraints to make known constraints from the use case explicit in the aspect model
[ ] when relying on external standards, they are referenced through a "see" element
[ ] all properties with an simple type have an example value
[ ] metadata.json exists with status "release"
[ ] file RELEASE_NOTES.md exists and contains entries for proposed model changes

MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)

[ ] All required reviewers have approved this PR (see reviewers section)
[ ] The new aspect (version) will be implemented by at least one data provider
[ ] The new aspect (version) will be consumed by at least one data consumer
[ ] There exists valid test data
[ ] In case of a new (incompatible) major version to an existing version, a migration strategy has been developed
[ ] The model has at least version '1.0.0'

modeling_team

camel case and pascal case is ok
release notes and metadata.json ok
not all property have examples
missing name for :CatenaXIdTraitCharacteristic, :NumberOfObjects, :Quantity, :QuantityCharacteristic, :measurementUnit
missing description for :ValidityPeriodCharacteristic
pascal case in name 'SingleLevelUsageAsPlanned'

fixed MS2 findings
@ZazraltMagic: please review the changes and apply MS2 label accordingly

@bs-jokri now all good, please approve MS2.


Bug: When launching an application with the "createHashFiles" argument, if another instance was already open, the application passed arguments to it, instead of creating hash files for itself

Fixed by f327796 commit


已经安装完依赖和下载model了，为啥启动会报错ModuleNotFoundError: No module named 'sentencepiece'

谢谢，错误如下
================ Loading model ================
Traceback (most recent call last):
File "", line 719, in _load
File "", line 688, in _load_unlocked
File "", line 883, in exec_module
File "", line 241, in _call_with_frames_removed
File "C:\Users\kaka.cache\huggingface\modules\transformers_modules\internlminternlm2-chat-20b\tokenization_internlm2_fast.py", line 35, in
from .tokenization_internlm2 import InternLM2Tokenizer
File "C:\Users\kaka.cache\huggingface\modules\transformers_modules\internlminternlm2-chat-20b\tokenization_internlm2.py", line 23, in
import sentencepiece as spm
ModuleNotFoundError: No module named 'sentencepiece'
python-BaseException

那就"pip install sentencepiece"


WinJS - azure mobile app

MobileServices.min.js (2.0 beta) & MobileServices.min.js(1.2.5) support azure mobile app ( not mobile service )  ?
I tried use connect facebook auth , but have error , can't show login page .
If use azure mobile service , the  MobileServices.min.js(1.2.5)  is work .  MobileServices.min.js(2.0 beta) not work fine , the error is " Unexpected error " .

For WinJS / Native, the 1.* is for services, the 2 - betas are for mobile apps.  For WinJS you should be using the nupkg (http://www.nuget.org/packages/WindowsAzure.MobileServices.WinJS/1.2.5) not the native JS version on the CDN.

Yes, I tried use 2-* beta from nupkg , but it not work , always throw exception  " Unexpected error " .
My project :

use visutal studio 2015 javascript uwp blank project template
winjs 4.0
use nuget install MobileServices.min.js 2-*

not work fine for azure mobile app .
if use MobileServices.min.js 1.2.5 , that work for azure mobile service .

Transitioning to azure-mobile-apps-js-client.


Unification results get lost in REPL

It seems that all unification results are lost in REPL, e.g.:
Trealla v0.1alpha, 64-bits (int=128-bits), Dec 12 2016
?- A = 1.

(0.000 s) yes
?- halt.
Halted
WARN: orphaned=1

Results are shown up now, but an orphaned warning is left, e.g.:
Trealla v0.1alpha, 64-bits (int=128-bits), Dec 12 2016
?- A = 1.
 A: 1
(0.000 s) yes
?- halt.
Halted
WARN: orphaned=1


[FLOC-3077] Automatic retry on certain Docker failures

Fixes https://clusterhq.atlassian.net/browse/FLOC-3077
This adds a retrying layer on top of docker.Client and uses that layer in the container agent, the functional tests, and the acceptance tests (most places, at least).  There's a remaining use of docker.Client without the retry layer in flocker/testtools/__init__.py that I'm not fixing because of a dependency direction problem (probably need to move the docker retry stuff to flocker/common/?).
The layer retries two Docker 500 errors which we know are helped by retrying (ie, they go away if you try again).  It's easy to add detection for more cases as we discover them.
This should solve both tracebacks on the linked JIRA issue (one in the description, one in a comment).  It also supersedes retry logic that was added to the run_registry helper in test_docker.py which added retries for any APIError on a particular DockerClient.list call.  Since that code should now be using the retrying layer, retries should already be applied to that case (and, happily, many others).
Note this doesn't appear to solve the problem I was hoping it would also solve, the acceptance test failures for FLOC-3199 / #2191.
Submitting anyway because hopefully it solves some other problems.
http://ci-live.clusterhq.com:8080/job/ClusterHQ-flocker/job/no-such-device-FLOC-3077/job/__main_multijob/

Local testing produces good results but master has moved on in a way that breaks one of the new test cases.  I think I need to port failureResultOf to make it work again.  Apart from that this seems mergeable now.

Thanks.
A few suggestions, please address & merge.

Merging as we actually got a green run of the tests.
Side note, the few tests that are red if you go to the jenkins page for this branch are both:

No longer run by main_multijob.
Clearly Jenkins errors, erroring out before they really start.


Allow empty request path in AbstractHttpRequestBuilder

Motivation:
As describe in  https://github.com/line/armeria/issues/3824.
A client build with  WebClient.of("http://localhost/test/issues")
would be able to send request to  both http://localhost/test/issues and http://localhost/test/issues/1
Result:

You can now specify an empty path for the request path.

Thanks, @eisig! 👍


Enum case names

All caps Snakecase enum cases are not properly formatted. An enum with the value of PAYMENT_REQUEST gets generated as:
case paymentrequest = "PAYMENT_REQUEST"

When it should be
case paymentRequest = "PAYMENT_REQUEST"

Fixed in 3.0


Adding social media handles  to the footer.

Is your feature request related to a problem? Please describe.
If anyone wants to follow us on any social media platform it should be easy to access it.
Describe the solution you'd like
we can add the social media handles' link in the footer section.
Describe alternatives you've considered
An alternative way is to create an about us page so anyone can reach out to us

@TusharKesarwani please assign this issue to me under ssoc'23 program so that i can start working on it.

Is your feature request related to a problem? Please describe.
Currently the website doesn't have any social media handles in the footer .so I can work on this issue to make it look more user friendly . Would be Happy to work on it.
Describe the solution you'd like
we can add social media links with their respective logos in the footer section.

Is your feature request related to a problem? Please describe.
Every website needs a good footer for a Better user experience which should've social media links and a contact us button (optional but better to take the user to email directly by clicking the contact us button), So we should make it good looking and easy to navigate.
Describe the solution you'd like
I'd like to make a footer that has a left and a right part where the left part contains some text about the website and contact us button and the right part contains all social media icons which navigate users to social profiles accordingly.
Describe alternatives you've considered
there are many alternative ways like first one is keeping the footer part simple with less text and making a separate section for social links that contains good-looking cards(showing some glimpse of our profile) which on click navigate users to our social profile, second one is to create about us page as you also described we can make about us page and put a hug details about our website along with all social links. here we have the flexibility to add more details as we're not limited by a small footer.
I already have done footer parts mostly for many personal projects and even recently for my personal portfolio website which is still in the development phase.

Not required


[az resource tag] command change casing for ApplicationInsights name

Related command
az resource tag
Describe the bug
Calling az resource tag --ids “.../microsoft.insights/components/appinsightname” with a different casing than the AppInsights component currently have will change the casing to the called one.
To Reproduce
Having an Application Insights resource with

id: “/subscriptions/…/resourcegroups/ResourceGroup/providers/microsoft.insights/components/AppInsightName”
name: “AppInsightName”
applicationId: “AppInsightName”
tags: {}

and calling
az resource tag --ids “/subscriptions/…/resourcegroups/resourcegroup/providers/microsoft.insights/components/appinsightname” --tags tagName=tagValue (note the lower casing)
will cause the following change

id: “/subscriptions/…/resourcegroups/ResourceGroup/providers/microsoft.insights/components/AppInsightName”
name: “appInsightname”
applicationId: “appInsightname”
tags: {“tagName”:”tagValue”}

The change of the tags is OK, but there is one unexpected change and that is the change in casing of the applicaiton insights component name and applicationId. It is not described in the documentation and IMHO a bug.
Expected behavior
There are basically 2 options how to handle it IMHO:

not changing the name+applicationId properties
or throwing “not found” (exception/http404) as the resourceId casing differs.

Environment summary
azure-cli                         2.37.0 *

core                              2.37.0 *
telemetry                          1.0.6 *

Extensions:
account                            0.2.3
azure-devops                      0.25.0
costmanagement                     0.2.1
dataprotection                     0.3.0
log-analytics                      0.2.2
managementpartner                  0.1.3
portal                             0.1.2
resource-graph                     2.1.0
scheduled-query                    0.5.0
storage-preview                    0.8.3

Dependencies:
msal                            1.18.0b1
azure-mgmt-resource             21.1.0b1

Python location 'C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\python.exe'
Extensions directory 'C:\Users\JVilimek\.azure\cliextensions'

Python (Windows) 3.10.4 (tags/v3.10.4:9d38120, Mar 23 2022, 22:57:10) [MSC v.1929 32 bit (Intel)]

route to CXP team

@josephkwchan, @jennyhunter-msft Please help us out here. The PUT operation used to update appinsights is causing the issue.

This is by design.
From our public documentation:
"When using various APIs to retrieve the name for a resource or resource group, the returned value may have different casing than what you originally specified for the name... Always perform a case-insensitive comparison of names."
This is because we preserve the most recently specified casing by the user. We will look into updating the documentation to be clearer on that.

This is by design.
From our public documentation: "When using various APIs to retrieve the name for a resource or resource group, the returned value may have different casing ...

@jennyhunter-msft thanks for the answer. I am a bit confused, can you please explain more? The documentation you mentioned is related to resource name  (or resource group name). Now the bug I have described is about Application Insights properties.name and ApplicationId. When I check the Azure portal, the resource itself has still the name with the old casing, but when we run the kusto query, the casing of AppName was changed.
The bug manifests by calling az resource tag over an application insights resource. If you call the very same on some other resource type (sql server, virtual machine,...) the casing of the name of the resource is not affected. Thus the bug is related to App Insights resource.
I have updated the description to be more specific. Hope this helps.
PS: And more specifically the bug is about the fact, that calling az resource tag should affect only tags and should not change any other name, property, whatever.

That's interesting. I don't see a properties.name in the REST API schema for that resource type. Only the top-level "name" property which should be the resource name.

@jennyhunter-msft thanks for comment. Yes, I found this interesting too. Is it interesting enough to re-open the bug? Would be much appreciated!

@jennyhunter-msft  maybe it's a low priority bug but still it would be great to keep it open, WDYT?

@jvilimek - Just to confirm, is the main problem here that the casing for the name property doesn't match the stored URI? Given that the APIs are explicitly case insensitive, is there a specific aspect of this that is causing issues with your logic?

@jennyhunter-msft sorry for not reaching you earlier. The main issue here is, that an az cli command that should chnage just the tag is changing also other properties. As you can see in the screenshot from kusto query this change affects data from AppInsights (the appName):

(for query see the original description of the bug)


Enum support?

I'm not sure if I'm missing something, but does Transcrypt support the enum module in the standard library?
I'm getting this error when trying to compile a package that uses enum.Enum:
Parsing module: /usr/lib/python3.8/enum.py
Generating code for module: /home/dophin2009/files/lfs/programming/stogacs/stogacs.club/__target__/enum.js
Parsing module: /home/dophin2009/.cache/pypoetry/virtualenvs/stogacs.club-55z-L0OC-py3.8/lib/python3.8/site-packages/transcrypt/modules/warnings/__init__.py
Generating code for module: /home/dophin2009/files/lfs/programming/stogacs/stogacs.club/__target__/warnings.js
Saving source map in: /home/dophin2009/files/lfs/programming/stogacs/stogacs.club/__target__/warnings.map
Saving target code in: /home/dophin2009/files/lfs/programming/stogacs/stogacs.club/__target__/warnings.js
Parsing module: /usr/lib/python3.8/types.py
Generating code for module: /home/dophin2009/files/lfs/programming/stogacs/stogacs.club/__target__/types.js
Parsing module: /usr/lib/python3.8/_collections_abc.py
Generating code for module: /home/dophin2009/files/lfs/programming/stogacs/stogacs.club/__target__/_collections_abc.js

Error while compiling (offending file last):
        File '/home/dophin2009/files/lfs/programming/stogacs/stogacs.club/src/components/MSTQuery/mstquery.py', line 6, at import of:
        File '/home/dophin2009/.cache/pypoetry/virtualenvs/stogacs.club-55z-L0OC-py3.8/src/mstat/mstat/__init__.py', line 7, at import of:
        File '/home/dophin2009/.cache/pypoetry/virtualenvs/stogacs.club-55z-L0OC-py3.8/src/mstat/mstat/record.py', line 3, at import of:
        File '/usr/lib/python3.8/enum.py', line 2, at import of:
        File '/usr/lib/python3.8/types.py', line 275, at import of:
        File '_collections_abc', line 56, namely:

        Can't import module '_collections_abc'

Aborted

Enum isn't supported yet.
Although it shouldn't be to hard to do, for now the accent is on moving to 3.9.
Thanks!

Sorry tried latest version this wasn't supported.

Still same in April 2023

+1 on this. I'd love enum.Enum support as well. as of 15-Aug-2024 still not supported.


As a trestle user I would like to be able to use 'semantic release' to automatically update my document versions.

Issue description / feature objectives
A devops pipeline can easily semantically version a trestle repo, however, this does not carry into the files.
Allow oscal files to also be sematically released through the use of moustache of similar.

Closing to consolidate functionality interacting with git / github to a future problem


How to Run JAX on multi-host GPU platforms

Hi, Currently I found the step to JAX on multi-host TPU Cloud, but I do not find the step to Run JAX on multi-host GPU platforms. Does anyone can help?

see also #2731

Closing as a duplicate of #2731
(The current state is: this actually works, but we don't yet expose a Python API for it, and we don't yet overlap communication with compute, which limits scalability.)


Expose the interval in IntervalSystem

This change makes it possible for subclasses to access the interval
directly.
Also fixes the example on the wiki, where the private field interval is used.

If you only need to read the interval, could you please add a getInterval() method to IntervalSystem and keep it private?
In such case, could you also make a unit test for it? It should be trivial.

ok to test

I changed it. Shall I update the wiki too?

retest this please

I will do it, no worries, thanks a lot for the contribution!


[MXNET-703] Update onnx-tensorrt for int8/fp16 support

Description
Update onnx-tensorrt with new support for different data types, including (importantly for v100) fp16.  This will not fully enable int8/fp16 inference yet, but lays the groundwork for further updates.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

18 days, no review, closing.

@Roshrini @vandanavk ping for review!

@KellenSunderland can you please elaborate on how this enables fp16 inference, and the changes involved? and why the change in the dockerfile build

@KellenSunderland  can you please address the review comments?
@Roshrini @vandanavk Can you please review it?
Thanks!

@vandanavk @Roshrini Could you please help review? Thanks

@vandanavk @Roshrini Ping...


Make minimum of pareto distribution 23/24

Leaving this issue open since I didn't change any settings for @ismael-mendoza's paper in #516


Library shows a lot of errors

Hello there, when I tried to write this code
#include <iostream>
#include "VKA/src/api.h"

int main(int argc, char *argv[]) {
    VK::Client api;
    return 0;
}

I got an error
"C:/TDM-GCC-64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\ncinsli\AppData\Local\Temp\ccuocYco.o:main.cpp:(.text+0xa9): undefined reference to `VK::Client::Client(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > (*)(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > (*)())'
C:/TDM-GCC-64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\ncinsli\AppData\Local\Temp\ccuocYco.o:main.cpp:(.rdata$.refptr._ZTVN2VK10Attachment4UserE[.refptr._ZTVN2VK10Attachment4UserE]+0x0): undefined reference to `vtable for VK::Attachment::User'
collect2.exe: error: ld returned 1 exit status"

The more functionality of library I use, the more errors I get. What do I need to do?

You get undefined references to library functionality because you don't link specified libraries (which must be built from VKA sources or downloaded from Releases page as a prebuilt binaries) to your application. You should definitely check out this video or this article explaining what are library linking is about. You can write me directly for further explanations if you want to.

You get undefined references to library functionality because you don't link specified libraries (which must be built from VKA sources or downloaded from Releases page as a prebuilt binaries) to your application. You should definitely check out this video or this article explaining what are library linking is about. You can write me directly for further explanations if you want to.

Thanks!

Thanks!


Search function

The search command should return the link to a google search query with the given search term.
Eg: "!search Knight of Academia" should link to a google search for Knights of Academia.

Mind if I take this one?

Mind if I take this one?

Go for it! Thanks for contributing


Manual counting of five functions

Add results in the report
This fix #4
This fix #5
This fix #7
This fix #8
This fix #9

It actually fixes #4, #5, #7, #8, #9.

Codecov Report

Merging #17 into lab3 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             lab3      #17   +/-   ##
=======================================
  Coverage   68.31%   68.31%
=======================================
  Files         107      107
  Lines        7334     7334
  Branches     1388     1388
=======================================
  Hits         5010     5010
  Misses       1868     1868
  Partials      456      456

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f14744...fb871b4. Read the comment docs.


training

请问如何不通过命令行运行train.py?目前我直接在运行test.py 可以，但是直接运行train.py:
File "/home/public/anaconda3/lib/python3.6/os.py", line 669, in getitem
raise KeyError(key) from None
KeyError: 'RANK'
请问如何在代码中设置：
CUDA_VISIBLE_DEVICES=0,1,2,3,4,5,6,7
python -m torch.distributed.launch
--nproc_per_node=8
--master_port=2333
../../tools/train.py --cfg config.yaml
中的值，使得可以直接在pycharm运行train.py，
谢谢您的回复。

It seems you have to set some environment variables, see: https://pytorch.org/docs/0.3.0/distributed.html#environment-variable-initialization

I have a same problem with you.
I also have a difficulty with @serycjon 's proposal.
@chenbolinstudent is this proposal working for you?
But, I success to run the evaluation and it works very well in evaluation.

@serycjon
can you give the detail?

I don't have the training data ready, so haven't really tested it, but running the script with:
WORLD_SIZE=1 RANK=0 PYTHONPATH=./:$PYTHONPATH python tools/train.py --cfg experiments/siamrpn_r50_l234_dwxcorr/config.yaml got me past that rank error.

if I :
WORLD_SIZE=1 RANK=0 PYTHONPATH=./:$PYTHONPATH python tools/train.py --cfg experiments/siamrpn_r50_l234_dwxcorr/config.yaml
then:
Traceback (most recent call last):
File "train.py", line 24, in
from pysot.utils.lr_scheduler import build_lr_scheduler
ModuleNotFoundError: No module named 'pysot'

@chenbolinstudent ,可以发下解决了RANK问题的修改的代码的截图吗， PYTHONPATH=./:$PYTHONPATH python tools/train.py，这个不是命令行语句吗，怎样在代码中修改呢

@serycjon

@chenbolinstudent Well, you have to install pysot correctly first (see install.md).
@Hevans123 It is a correct BASH command. You have to check how to set environment variables on your system if this does not work.

I found a problem, the training time is very long, if the training process is interrupted midway, then you need to start training from the beginning, is there a solution to continue training in the interrupted position，just like SiamFC‘s training process？

I found a problem, the training time is very long, if the training process is interrupted midway, then you need to start training from the beginning, is there a solution to continue training in the interrupted position，just like SiamFC‘s training process？

Try to use TRAIN.RESUME to resume your training.

I found a problem, the training time is very long, if the training process is interrupted midway, then you need to start training from the beginning, is there a solution to continue training in the interrupted position，just like SiamFC‘s training process？

Try to use TRAIN.RESUME to resume your training.

I followed what you said,but i met with those problem:
epoch: 15
[2019-06-22 09:28:08,844-rk0-model_load.py# 42] remove prefix 'module.'
[2019-06-22 09:28:08,844-rk0-model_load.py# 33] used keys:75
[2019-06-22 09:28:08,845-rk0-model_load.py# 33] used keys:2
Traceback (most recent call last):
File "../../tools/train.py", line 319, in
main()
File "../../tools/train.py", line 307, in main
restore_from(model, optimizer, cfg.TRAIN.RESUME)
File "/home/db/Subject/pysot/pysot/utils/model_load.py", line 89, in restore_from
optimizer.load_state_dict(ckpt['optimizer'])
File "/home/db/anaconda3/envs/pysot/lib/python3.7/site-packages/torch/optim/optimizer.py", line 107, in load_state_dict
raise ValueError("loaded state dict contains a parameter group "
ValueError: loaded state dict contains a parameter group that doesn't match the size of optimizer's group

请问如何不通过命令行运行train.py?目前我直接在运行test.py 可以，但是直接运行train.py:
File "/home/public/anaconda3/lib/python3.6/os.py", line 669, in getitem
raise KeyError(key) from None
KeyError: 'RANK'
请问如何在代码中设置：
CUDA_VISIBLE_DEVICES=0,1,2,3,4,5,6,7
python -m torch.distributed.launch
--nproc_per_node=8
--master_port=2333
../../tools/train.py --cfg config.yaml
中的值，使得可以直接在pycharm运行train.py，
谢谢您的回复。

I can debug training code on pycharm，you can refer to this blog，https://oldpan.me/archives/pytorch-to-use-multiple-gpus，but follow his configuration，you would receive an error： no module train.py，you just change 'train.py' to 'train',and it works

@ZZXin
can you give  the detail?
thanks

but this blog do not say how to set the nproc_per_node master_port

but this blog do not say how to set the nproc_per_node master_port

I train this code on single GPU,I think it doesn't matter,you can set  '--nproc_per_node master_port = 1'

在哪个.py文件设置？
which .py file to set?

which .py file to set
--nproc_per_node
--master_port ?

which .py file to set
--nproc_per_node
--master_port ?

train.py

@ZZXin
can you offer the youtubebb of badu wangpan link ?

--nproc_per_node
--master_port
is not exist in train.py

@ZZXin
can you offer the youtubebb of badu wangpan link ?

I don't have it, I am waiting for pysot‘s downloading link

how do you debug training code on pycharm
https://oldpan.me/archives/pytorch-to-use-multiple-gpus  do not say how to set
can you say the detail?

how do you debug training code on pycharm
https://oldpan.me/archives/pytorch-to-use-multiple-gpus do not say how to set
can you say the detail?
refer to
https://image.oldpan.me/TIM截图20190306182352.jpg
Take a good look at this picture.

how do you debug training code on pycharm
https://oldpan.me/archives/pytorch-to-use-multiple-gpus do not say how to set
can you say the detail?
refer to
https://image.oldpan.me/TIM截图20190306182352.jpg
Take a good look at this picture.

can I ask where the configs in the picture is?   I cann't find the window.

follow https://image.oldpan.me/TIM截图20190306182352.jpg
but print:
python with name distributed already exists

scipts:
torch.distributed.launch
scipts.paramters:
--nproc_per_node=1  --master_port=2333 /home/ty/PycharmProjects/pysot-master/tools/train.py
still KeyError: 'RANK'

Has the issue been solved? I have the same issue.

I found a problem, the training time is very long, if the training process is interrupted midway, then you need to start training from the beginning, is there a solution to continue training in the interrupted position，just like SiamFC‘s training process？

Try to use TRAIN.RESUME to resume your training.
@lb1100
I followed what you said,but i met with those problem:

[2019-06-22 09:28:08,844-rk0-model_load.py# 42] remove prefix 'module.'
[2019-06-22 09:28:08,844-rk0-model_load.py# 33] used keys:75
[2019-06-22 09:28:08,845-rk0-model_load.py# 33] used keys:2
Traceback (most recent call last):
File "../../tools/train.py", line 319, in
main()
File "../../tools/train.py", line 307, in main
restore_from(model, optimizer, cfg.TRAIN.RESUME)
File "/home/db/Subject/pysot/pysot/utils/model_load.py", line 89, in restore_from
optimizer.load_state_dict(ckpt['optimizer'])
File "/home/db/anaconda3/envs/pysot/lib/python3.7/site-packages/torch/optim/optimizer.py", line 107, in load_state_dict
raise ValueError("loaded state dict contains a parameter group "
ValueError: loaded state dict contains a parameter group that doesn't match the size of optimizer's group

Have you solved this problem?

pycharm Run->Import configurations->Configuration->module name :(torch .distributed.launch)
Ps: defalt is Script path ,you should click the list button .

@ZZXin
train.py do not have  "  --nproc_per_node--master_port  "

@chenbolinstudent module name ! not scipts path .have a try

@xiaotian3
what? please say the in detail

scipts:
torch.distributed.launch
scipts.paramters:
--nproc_per_node=1 --master_port=2333 /home/ty/PycharmProjects/pysot-master/tools/train.py
still KeyError: 'RANK'
you use the script path ,but it should ues module name 。
refer to
https://image.oldpan.me/TIM截图20190306182352.jpg

@ZZXin
train.py do not have " --nproc_per_node--master_port "
I think " --nproc_per_node--master_port " is related to the distributed training of torch.

@ZZXin
那我要修改train.py中的代码吗？
还是只要修改configure 文件就行

I set it and do not change the train.py scipt,but  still KeyError: 'RANK'
xiaotian3

I set it and do not change the train.py scipt,but still KeyError: 'RANK'
xiaotian3

I set it and do not change the train.py scipt,but still KeyError: 'RANK'
@xiaotian3

I have a question whether to run train or distributed in pycharm?
second,
It is ok when I run distribued .
but if I  debug with distribued ,it occurs 'no moule named ./tools/train.py'
I have modified the path of train.py, but I  still get an error
@ZZXin  I just change 'train.py' to 'train',and it does not works

I set it and do not change the train.py scipt,but still KeyError: 'RANK'
@xiaotian3

@xiaotian3
1.Do you configure it with ubuntu or Windows？
2.can you debug with pycharm?

@xiaotian3
1.Do you configure it with ubuntu or Windows？
2.can you debug with pycharm?

ubuntu
I can debug with pycharm

@xiaotian3
当我 debug时，总报错，
No module named /media/wyl/01937159-8963-47f6-b239-efe7b18f2e8b/wyl/data/project/pysot/pysot-master/tools/train.py

@xiaotian3
麻烦指导一下，搞了一个下午了。
非常感谢

@xiaotian3
麻烦指导一下，搞了一个下午了。
非常感谢

直接用train,前面的路径，可以参考我的图片

@xiaotian3  麻烦把你pycharm  中配置的parameters点开让我看一下
我把.py去掉之后，连运行都会报错
/media/wyl/01937159-8963-47f6-b239-efe7b18f2e8b/wyl/data/software/conda/envs/pysot/bin/python3.7 -m torch.distributed.launch --nproc_per_node 1 --master_port=2333 /media/wyl/01937159-8963-47f6-b239-efe7b18f2e8b/wyl/data/project/pysot/pysot-master/tools/train --cfg /media/wyl/01937159-8963-47f6-b239-efe7b18f2e8b/wyl/data/project/pysot/pysot-master/experiments/siamrpn_r50_l234_dwxcorr_8gpu/config.yaml
/media/wyl/01937159-8963-47f6-b239-efe7b18f2e8b/wyl/data/software/conda/envs/pysot/bin/python3.7: can't open file '/media/wyl/01937159-8963-47f6-b239-efe7b18f2e8b/wyl/data/project/pysot/pysot-master/tools/train': [Errno 2] No such file or directory
Process finished with exit code 0

@xiaotian3 期待你的回复，谢谢！

@xiaotian3 期待你的回复，谢谢！

只留train,前面的路径都去掉就好 了

非常感谢你的回复，除了配置train,还有其他需要配置的吗？
配置完，是直接运行train，而不是运行train.py?
我按照如下的配置，还是不行，
can't open file 'train': [Errno 2] No such file or directory
我有点摸不着头脑

非常感谢你的回复，除了配置train,还有其他需要配置的吗？
配置完，是直接运行train，而不是运行train.py?
我按照如下的配置，还是不行，
can't open file 'train': [Errno 2] No such file or directory
我有点摸不着头脑

不行的话，你加我qq：809078075

好的

@Programmerwyl
我找不到module name 模块，
你是用pycharm专业版吗?

@chenbolinstudent 我的是专业版的。
我不知道，普通版，是不是没有module name?
在我的版本中，点击configuration下面的第一个列表，可以选择module name

summarize：
if you want to train it with pycharm ,you need click run >  Edit Configurations
you need to config module name  and Parameters
note:train scrpts should be full path  As is shown in the picture

if  you want to debug it with pycharm ,you need click run >  Edit Configurations
you need to config module name  and Parameters
note the different thing is that you only need train,but you need to config Working diretory

Thanks @Programmerwyl ,I make it . When debugging，use train , Not train.py .

十分感谢，我也做到了

由于本issue没有得到更进一步的提问，我现在将其关闭。
如有新的问题，请重新打开它或者创建一个新的issue。

summarize：
if you want to train it with pycharm ,you need click run > Edit Configurations
you need to config module name and Parameters
note:train scrpts should be full path As is shown in the picture

if you want to debug it with pycharm ,you need click run > Edit Configurations
you need to config module name and Parameters
note the different thing is that you only need train,but you need to config Working diretory

请问你的distribution是怎么生成的?


Shoulder redesign for more structural integrity

The blue object should be made of metal and welded to the shaft of the green stepper motor
We should reconsider welding the blue stepper motor bracket directly to the shaft of the green stepper motor. My biggest concern is the amount of horizontal stress the shaft will receive as a result of  supporting the entire shoulder, arm, and load of the arm (what the arm is holding/carrying).
Instead, we could separate the load of the arm from the actuation of the arm by implementing a drive shaft which connects to the chassis, then a gearing mechanism between the shoulder and the stepper motor for forward and backward motion.

That sounds like a good idea! I'll try to implement that when I'm done with some other things


[SPARK-19891][SS] Await Batch Lock notified on stream execution exit

What changes were proposed in this pull request?
We need to notify the await batch lock when the stream exits early e.g., when an exception has been thrown.
How was this patch tested?
Current tests that throw exceptions at runtime will finish faster as a result of this update.
@zsxwing
Please review http://spark.apache.org/contributing.html before opening a pull request.

Test build #74287 has started for PR 17231 at commit b6f1bb0.

Could you just submit one commit, please?  That's totally not necessary for such minor fix.

Test build #74287 has finished for PR 17231 at commit b6f1bb0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74287/
Test PASSed.

Test build #74292 has started for PR 17231 at commit a23162a.

Test build #74293 has started for PR 17231 at commit c49e183.

Test build #74294 has started for PR 17231 at commit 8170792.

Test build #74292 has finished for PR 17231 at commit a23162a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74292/
Test PASSed.

Merged build finished. Test PASSed.

Test build #74294 has finished for PR 17231 at commit 8170792.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #74293 has finished for PR 17231 at commit c49e183.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74294/
Test PASSed.

Merged build finished. Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74293/
Test PASSed.

LGTM. Merging to master and 2.1.


Logical OR for version specifiers

According to PEP 440,

The comma (",") is equivalent to a logical and operator: a candidate version must match all given version clauses in order to match the specifier as a whole.

There does not seem to be an equivalent for logical or.
For example, if slash ("/") was used for this,
>=2.7,!=3.0.*,!=3.1.*,!=3.2.*

could be simplified using compatible release operators:
~=2.7/~=3.3

We need PEP for this, since it affects the wheel standard.

If you're up for this, then submit a PR on python/peps and join distutils-sig. It's not for the faint of heart though.

@dmtucker
I would have said your example resolve to:
~=2.7/>=3.3
?
but what about using | for the OR operator ? if it's usable / not restricted..

@gst Ah, good point! This is exactly why the OR is desirable... I was going for "compatible with 2.7 or compatible with 3.3". Using AND, I (and pip) forgot to add "and less than 4.0".
So really, this should be the example:
>=2.7,!=3.0.*,!=3.1.*,!=3.2.*,<4.0

~=2.7/~=3.3

@xoviat I'm usually up for a new Python challenge :) I will look into this further.

@dmtucker
On second thought, I have a better idea for implementation. Since proposing
and implementing a PEP will take at the very minimum a month, a better idea
would be implement a logical-equivalent generator (De Morgan's laws) that
translates the "or" expression into an equivalent "and" expression. That is
something that could be implemented and tested within an hour. I would
recommend hooking the translator into the Distribution class.

@xoviat I spent some time with this last night, and there are a couple problems with that.
One is that operators can't apply to specifiers, only clauses (e.g. !(!A,!B) - !() isn't a thing AFAIK).
Another is negating the compatible release operator. ~= V.N is the same as >= V.N, == V.*, which can technically be negated, but De Morgan re-introduces the OR: !(< V.N | != V.*).

~= V.N is the same as >= V.N, == V.*.

I'm sorry, but I don't understand this. That means that a version that specified ~3.3 would require 3.3 as the major version because of ==V.*. That seems to contradict the fact that 3.6 is compatible with 3.3. Am I reading this correctly?

After some more consideration, I don't think that we need to go that far. Because version specifiers don't have parentheses, we should just be able to "walk the version number line" and exclude/include major versions. The transition points to check (similar to limit graphs in calculus) should be the root versions at and above, and the major versions in the expression.
For example, ~=2.7/~=3.3 has transition points at 2.0, 2.7, 3.0, 3.3, and 4.0. At each transition point, we can check slightly above/below whether the version is excluded. This approach works for parentheses too, if you are proposing them?

Here's some scrappy "solution" that I put together that doesn't yet work.
It somewhat illustrates what I was describing, but the solution is slightly
more difficult to implement than I thought it would be:
TEST_VERSION_STRING = "~=2.7/~=3.3"

import math

from typing import List
from pkg_resources import Requirement, Distribution

# Note: this doesn't work because versions cannot be represented
# by floats. That will be resolved in the future.

def find_critical_points(version_string: str) -> List[float]:
"""Find all of the critical points in a version string

A "critical version" is a version at which a higher
or lower distribution version will not satisfy
the requirement. For example, "~2.7" has critical
versions at "2.0", "2.7", and "3.0". We need to exclude
or include ranges between these critical points
"""

# Filter out characters we don't care about
for c in ['<', '>', '=', '~']:
version_string = version_string.replace(c, '')

# Split the string along and/or operators
substrings = version_string.replace('/', ',').split(',')
critical_points = [float(version) for version in substrings]
# Add the root versions
upper_bound = math.ciel(max(critical_points))
lower_bound = math.floor(min(critical_points))
critical_points += list(range(lower_bound, upper_bound))
return list(sorted(set(critical_points)))

def get_or_expressions(version_string: str) -> List[str]:
"""Split the version string by the "or" delimeter
Note that we assume here that that a version_string with
"or" expression cannot have "and" expressions because parentheses
are not allowed at this time.
"""
assert ',' not in version_string
return version_string.split('/')

def convert_version_string(version_string: str) -> str:
"""Convert a version_string with "or" expressions to "and"
Note that the expression cannot have "or" and "and"
"""

critical_points = find_critical_points(version_string)
or_expressions = get_or_expressions(version_string)
and_expressions = []
or_requirements = [Requirement.parse(e) for e in or_expressions]

root_version_floor = 0
major_version_floor = 0
for critical_point in critical_points:
# First, test slightly below
test_point = critical_point - 0.1
for or_expression in or_expressions:
if test_point in or_expression:
break
else:  # elif?
# Exclude the root versions from major_version_floor
if root_version_floor < test_point_major_version:
and_expressions += [
"!={}.*".format(v) for v in range(
major_version_floor,
test_point_major_version)]

A little better:
TEST_VERSION_STRING = "~=2.7/~=3.3"

from typing import List, Tuple
from operator import itemgetter
from pkg_resources import Requirement, Distribution

def get_version_tuple(version_string: str) -> Tuple[int, int, int]:
root, major, minor = version_string.split('.')
return (root, major, minor)

def find_critical_points(version_string: str) -> List[Tuple[int, int, int]]:
"""Find all of the critical points in a version string

A "critical version" is a version at which a higher
or lower distribution version will not satisfy
the requirement. For example, "~2.7" has critical
versions at "2.0", "2.7", and "3.0". We need to exclude
or include ranges between these critical points
"""

# Filter out characters we don't care about
for c in ['<', '>', '=', '~']:
version_string = version_string.replace(c, '')

# Split the string along and/or operators
substrings = version_string.replace('/', ',').split(',')
critical_points = [get_version_tuple(v) for v in substrings]
# Add the root versions
upper_bound = max(critical_points, key=itemgetter(1))[0] + 1
lower_bound = min(critical_points, key=itemgetter(1))[0]
critical_points += [
(v, 0, 0) for v in range(lower_bound, upper_bound)]
return list(sorted(set(critical_points), key=itemgetter(1)))

def get_or_expressions(version_string: str) -> List[str]:
"""Split the version string by the "or" delimeter
Note that we assume here that that a version_string with
"or" expression cannot have "and" expressions because parentheses
are not allowed at this time.
"""
assert ',' not in version_string
return version_string.split('/')

def get_version_below(version: Tuple[int, int, int]) -> Tuple[int, int,
int]:
"""Get the version slightly below the given verion"""
root, major, minor = version

if minor != 0:
return (root, major, minor - 1)
elif major != 0:
return (root, major - 1, 99)
elif root != 0:
return (root - 1, 99, 99)
else:
raise NotImplementedError()
def generate_exclusions_for(
lower: Tuple[int, int, int], upper: Tuple[int, int, int]) -> List[str]:
"""
Generate "and" expressions to exclude all versions between
the lower and upper bound
"""
expressions = []
lower_root, lower_major, lower_minor = lower
upper_root, upper_major, upper_minor = upper
for root in range(lower_root, upper_root):
expressions += ["!={}.*".format(lower)]
# We should technically cover major versions under
# the lower root version, but I will leave that out
# for now, as that has ill-defined behavior
for major in range(0, upper_major):
expressions += ["!={}.{}.*".format(upper_root, major)]

# And we won't even touch minor versions at this points
return expressions

def convert_version_string(version_string: str) -> str:
"""Convert a version_string with "or" expressions to "and"
Note that the expression cannot have "or" and "and"
"""

critical_points = find_critical_points(version_string)
or_expressions = get_or_expressions(version_string)
and_expressions = []
or_requirements = [Requirement.parse(e) for e in or_expressions]

version_floor = (0, 0, 0)
for critical_point in critical_points:
# First, test slightly below
test_point = get_version_below(critical_point)
for or_expression in or_expressions:
if test_point in or_expression:
break
else:  # elif?
# Exclude the root versions from major_version_floor
if root_version_floor < test_point_major_version:
and_expressions += generate_exclusions_for(
version_floor, test_point)

Actually this idea is not possible because the requirement specifier is
not a logically complete system (parentheses are not supported). So a PEP
will be required; I would recommend that you join distutils-sig and propose
this idea there.

Thanks both for the discussion. Feel free to come back here if a concrete implementation can be devised that fits in with accepted designs (PEPs or similar).

I've run into this now too.  We do need an OR operator in order to properly support libraries that support Python 2.7 and some combination (but not all of) Python 3 versions.

Why don't you create a PEP then?

On Dec 13, 2017, at 20:59, xoviat<EMAIL_ADDRESS>wrote:

Why don't you create a PEP then?

Why wouldn’t PEP 566, which is still in Draft status, suffice?

I don't think the json metadata is moving forward.


improvements for "stop remote recording"

Superseded by https://github.com/getappmap/appmap-intellij-plugin/pull/195


ARROW-18018: [C++] Potential segmentation fault in unit tests due to usage of AllComplete instead of AllFinished

@westonpace should we check the release CIs here?