Struggling to get expected results

Hi there,
I have been running several visual odometry systems and measuring their trajectory errors. I have been attempting to use COLMAP as a "baseline" to compare the results of the real-time VO systems to. Then I discovered GLOMAP, and have been using it due to its faster runtime, but I am struggling to get results that beat the real time systems with both colmap and glomap.
For example when running them on EuRoC's MH_01 sequence, I get the following results:
COLMAP trajectory RMSE: 0.00195m after running for 35823.9 seconds
GLOMAP trajectory RMSE: 0.00196m after running for 22299.0 seconds
What has been confusing me is when I compare this to real-time systems like DSO.
DSO trajectory RMSE: 0.00163m when running in real time
I would think colmap and glomap would blow any real-time system out of the water because they do not have the real time constraint, which leads me to think that I must be running colmap and glomap incorrectly.
I have been running colmap and glomap from a python script, here is the important snippet. I am getting the camera model and camera parameters from the datasets I have been running it on.
    print("Running feature extraction...")
    common_start_time = time.time()
    feature_extractor_cmd = [
        "colmap", "feature_extractor",
        "--database_path", database_path,
        "--image_path", image_dir,
        "--ImageReader.camera_model", camera_model,
        "--ImageReader.camera_params", camera_params,
        "--ImageReader.single_camera", "1",
        "--SiftExtraction.use_gpu", "1"
    ]
    subprocess.run(feature_extractor_cmd, check=True)

    print("Running sequential feature matching...")
    sequential_matcher_cmd = [
        "colmap", "sequential_matcher",
        "--database_path", database_path,
        "--SiftMatching.max_num_trials", "1000000",
        "--SiftMatching.use_gpu", "1"
    ]
    subprocess.run(sequential_matcher_cmd, check=True)
    common_end_time = time.time()
    colmap_mapper_ba_start_time = time.time()
    print("Running mapper...")
    mapper_cmd = [
        "colmap", "mapper",
        "--database_path", database_path,
        "--image_path", image_dir,
        "--output_path", colmap_output_dir,
        "--Mapper.ba_refine_focal_length", "0",
        "--Mapper.ba_refine_principal_point", "0",
        "--Mapper.ba_refine_extra_params", "0",
        "--Mapper.extract_colors", "0"
    ]
    subprocess.run(mapper_cmd, check=True)
    colmap_output_dir = os.path.join(colmap_output_dir, "0") # Colmap forces output into this '0' directory
    print("Running bundle adjustment...")
    bundle_adjust_cmd = [
        "colmap", "bundle_adjuster",
        "--input_path", colmap_output_dir,
        "--output_path", colmap_output_dir,
        "--BundleAdjustment.refine_focal_length", "0",
        "--BundleAdjustment.refine_principal_point", "0",
        "--BundleAdjustment.refine_extra_params", "0",
        "--BundleAdjustment.refine_extrinsics", "1"
    ]
    subprocess.run(bundle_adjust_cmd, check=True)
    colmap_mapper_ba_end_time = time.time()

    print("Running glomap bundle adjustment...")
    glomap_mapper_ba_start_time = time.time()
    glomap_mapper_cmd = [
        "glomap", "mapper",
        "--database_path", database_path,
        "--image_path", image_dir,
        "--output_path", glomap_output_dir,
        "--BundleAdjustment.optimize_intrinsics", "0",
    ]
    subprocess.run(glomap_mapper_cmd, check=True)
    glomap_mapper_ba_end_time = time.time()

Do you have any advice on how I can improve the colmap and glomap trajectory errors?
Thank you so much for your time and for developing these awesome systems!!

Hi @carsoncramer, thanks for your question. I am a bit surprise that GLOMAP takes such a long time to finish, but apart from that, I think the result is reasonable. For this particular scene, the error is already quite small (<0.2cm?), so I don't think COLMAP or GLOMAP can do much better there. However, for more difficult cases, the difference might be larger. One thing I notice from your code is that you do not have loop_closure when do image matching (you can do so by changing --SequentialMatching.loop_detection=1 and provide --SequentialMatching.vocab_tree_path), and this might provide you with some extra accuracy. If you still have the logging information, do you mind sharing the detailed runtime information on GLOMAP so we can understand better why it is slow?

Ah apologies for reopening this!! We decided we want to log the runtimes for the systems, so I want to make sure that I get the runtime correct for GLOMAP. What runtime information you looking for? I have the shell output from the system, the files "cameras.bin  cameras.txt  images.bin  images.txt  points3D.bin  points3D.txt" that are the output from the mapper, and then also the database for the run.

Hi, the raw shell output would tell how long each part of the system takes to finish, and the overall running time is logged at the end. For us, the detailed runtime information would be interesting (as we want to understand the performance of every part), but if you only want to put a single entry for GLOMAP, then the overall runtime would be more relevant.

Here is the beginning of the glomap output for EuRoC_MH03_Medium:
`Running glomap bundle adjustment...
Loading Images 2700 / 2700
Loading Image Pair 36580 / 36580
I1021 15:55:56.724975 357716 colmap_converter.cc:303] Pairs read done. 2132 / 36580 are invalid
I1021 15:55:56.728158 357716 global_mapper.cc:80] Loaded database
Running preprocessing ...
I1021 15:55:56.733162 357716 view_graph_manipulation.cc:249] Decompose relative pose for 34448 pairs
I1021 15:55:56.778054 357716 view_graph_manipulation.cc:303] Decompose relative pose done. 14142 pairs are pure rotation
I1021 15:55:56.778398 357716 timer.cc:87] Elapsed time: 0.05023 [seconds]
Running view graph calibration ...
I1021 15:55:56.778426 357716 view_graph_calibration.cc:16] Start ViewGraphCalibrator
I1021 15:55:56.784759 357716 view_graph_calibration.cc:33] No cameras to optimize
Running relative pose estimation ...
I1021 15:55:56.788542 357716 image_undistorter.cc:20] Undistorting images..
I1021 15:55:56.830986 357716 image_undistorter.cc:41] Image undistortion done
I1021 15:55:56.835500 357716 relpose_estimation.cc:26] Estimating relative pose for 34448 pairs
Estimating relative pose: 100%
I1021 15:57:17.446753 357716 relpose_estimation.cc:86] Estimating relative pose done
I1021 15:57:18.066210 357716 relpose_filter.cc:46] Filtered 1464 relative poses with inlier number < 30
I1021 15:57:18.067431 357716 relpose_filter.cc:63] Filtered 62 relative poses with inlier ratio < 0.25
I1021 15:57:18.074391 357716 timer.cc:87] Elapsed time: 81.28679 [seconds]
Running rotation averaging ...
I1021 15:57:18.721763 357716 relpose_filter.cc:31] Filtered 35 relative rotation with angle > 10 degrees
I1021 15:57:19.355590 357716 relpose_filter.cc:31] Filtered 0 relative rotation with angle > 10 degrees
I1021 15:57:19.365832 357716 global_mapper.cc:105] 2700 / 2700 images are within the connected component.
I1021 15:57:19.365842 357716 timer.cc:87] Elapsed time: 1.29143 [seconds]
Running track establishment ...

I1021 15:57:32.867395 357716 image_undistorter.cc:20] Undistorting images..
I1021 15:57:32.867404 357716 image_undistorter.cc:41] Image undistortion done
I1021 15:57:32.867741 357716 global_positioning.cc:43] Setting up the global positioner problem
I1021 15:57:37.152731 357716 global_positioning.cc:68] Solving the global positioner problem
I1021 16:10:17.387715 357716 global_positioning.cc:77] Ceres Solver Report: Iterations: 68, Initial cost: 5.356735e+07, Final cost: 2.601072e+01, Termination: CONVERGENCE
I1021 16:10:17.574951 357716 track_filter.cc:86] Filtered 2026 / 327598 tracks by angle error
I1021 16:10:17.574962 357716 timer.cc:87] Elapsed time: 764.70844 [seconds]
Running bundle adjustment ...
I1021 16:10:18.891165 357716 global_mapper.cc:177] Bundle adjustment start
I1021 16:12:59.077392 357716 bundle_adjustment.cc:48] Ceres Solver Report: Iterations: 33, Initial cost: 1.483930e+06, Final cost: 1.266535e+06, Termination: CONVERGENCE
I1021 16:12:59.077435 357716 global_mapper.cc:193] Global bundle adjustment iteration 1 / 3, stage 1 finished (position only)
I1021 16:12:59.077437 357716 timer.cc:87] Elapsed time: 160.18626 [seconds]
I1021 16:20:21.513185 357716 bundle_adjustment.cc:48] Ceres Solver Report: Iterations: 16, Initial cost: 1.266535e+06, Final cost: 1.186973e+06, Termination: CONVERGENCE
I1021 16:20:21.513233 357716 global_mapper.cc:205] Global bundle adjustment iteration 1 / 3, stage 2 finished
I1021 16:20:21.513235 357716 timer.cc:87] Elapsed time: 602.62206 [seconds]
I1021 16:20:21.514170 357716 image_undistorter.cc:20] Undistorting images..
I1021 16:20:21.553661 357716 image_undistorter.cc:41] Image undistortion done
I1021 16:20:21.554220 357716 global_mapper.cc:216] Filtering tracks by reprojection ...
I1021 16:20:21.725302 357716 track_filter.cc:48] Filtered 706 / 327598 tracks by reprojection error
I1021 16:21:10.932077 357716 bundle_adjustment.cc:48] Ceres Solver Report: Iterations: 8, Initial cost: 1.179295e+06, Final cost: 1.178338e+06, Termination: CONVERGENCE
I1021 16:21:10.932123 357716 global_mapper.cc:193] Global bundle adjustment iteration 2 / 3, stage 1 finished (position only)
I1021 16:21:10.932125 357716 timer.cc:87] Elapsed time: 652.04095 [seconds]
I1021 16:22:25.426796 357716 bundle_adjustment.cc:48] Ceres Solver Report: Iterations: 2, Initial cost: 1.178338e+06, Final cost: 1.178242e+06, Termination: CONVERGENCE
I1021 16:22:25.426843 357716 global_mapper.cc:205] Global bundle adjustment iteration 2 / 3, stage 2 finished
I1021 16:22:25.426846 357716 timer.cc:87] Elapsed time: 726.53567 [seconds]
I1021 16:22:25.427783 357716 image_undistorter.cc:20] Undistorting images..
I1021 16:22:25.468055 357716 image_undistorter.cc:41] Image undistortion done
I1021 16:22:25.468926 357716 global_mapper.cc:216] Filtering tracks by reprojection ...
I1021 16:22:25.639928 357716 track_filter.cc:48] Filtered 2485 / 327598 tracks by reprojection error
I1021 16:23:05.647286 357716 bundle_adjustment.cc:48] Ceres Solver Report: Iterations: 6, Initial cost: 1.143247e+06, Final cost: 1.141178e+06, Termination: CONVERGENCE
I1021 16:23:05.647328 357716 global_mapper.cc:193] Global bundle adjustment iteration 3 / 3, stage 1 finished (position only)
I1021 16:23:05.647330 357716 timer.cc:87] Elapsed time: 766.75616 [seconds]
I1021 16:24:19.418749 357716 bundle_adjustment.cc:48] Ceres Solver Report: Iterations: 2, Initial cost: 1.141178e+06, Final cost: 1.141150e+06, Termination: CONVERGENCE
I1021 16:24:19.418782 357716 global_mapper.cc:205] Global bundle adjustment iteration 3 / 3, stage 2 finished
I1021 16:24:19.419760 357716 image_undistorter.cc:20] Undistorting images..
I1021 16:24:19.460049 357716 image_undistorter.cc:41] Image undistortion done
I1021 16:24:19.460683 357716 global_mapper.cc:216] Filtering tracks by reprojection ...
I1021 16:24:19.633450 357716 track_filter.cc:48] Filtered 15623 / 327598 tracks by reprojection error
I1021 16:24:20.423748 357716 image_undistorter.cc:20] Undistorting images..
I1021 16:24:20.463219 357716 image_undistorter.cc:41] Image undistortion done
I1021 16:24:20.466074 357716 global_mapper.cc:242] Filtering tracks by reprojection ...
I1021 16:24:20.638327 357716 track_filter.cc:48] Filtered 0 / 327598 tracks by reprojection error
I1021 16:24:20.741349 357716 track_filter.cc:123] Filtered 56397 / 327598 tracks by too small triangulation angle
I1021 16:24:20.741358 357716 timer.cc:87] Elapsed time: 841.85019 [seconds]
Running retriangulation ...
I1021 16:24:20.741371 357716 database_cache.cc:65] Loading cameras...
I1021 16:24:20.741396 357716 database_cache.cc:75]  1 in 0.000s
I1021 16:24:20.741400 357716 database_cache.cc:83] Loading matches...
I1021 16:24:20.837239 357716 database_cache.cc:89]  34484 in 0.096s
I1021 16:24:20.837253 357716 database_cache.cc:105] Loading images...
I1021 16:24:20.933269 357716 database_cache.cc:155]  2700 in 0.096s (connected 2700)
I1021 16:24:20.933501 357716 database_cache.cc:166] Building correspondence graph...
I1021 16:24:23.050115 357716 database_cache.cc:195]  in 2.117s (ignored 0)
Triangulating image 2700 / 2700
Global bundle adjustment iteration 5 / 5
I1021 16:30:30.869962 357716 timer.cc:87] Elapsed time: 370.12860 [seconds]
Running bundle adjustment ...
I1021 16:30:30.870013 357716 global_mapper.cc:273] Bundle adjustment start
`
I don't have the end of the bundle adjustment yet, I will update this comment with the end time when I get it. Is there anything in this that hints to why the runtime is higher than expected?

Thanks for sharing your log. For the steps so far, the run time is about ~(80 + 10 + 760 + 840 + 370 < 2100s). This number is normal for a scene with ~2000 images. In this case, it is strange that MH_01 takes ~20k s. Maybe the number of constructed points is very large, which can be slow. You can potentially speed it up by capping the allowed number of tracks.

Will capping the allowed number of tracks reduce the accuracy?

This would unfortunately be the case. However, when the cap is high enough (for example, 1000 x num_img), the difference would not be large and should still be accurate.

I added the rest of the BA output above. For the last two runs that I have data on for colmap and glomap, the times look like this.
MH_01_easy:

Colmap: 28507s
Glomap: 27908s

MH_03_medium:

Colmap: 22988s
Glomap: 3431s

So for MH03, it seems like the glomap is performing as expected. I am not sure what's happening with MH01. I'll post again once I get some more results on other datasets, maybe MH01 is just an outlier.


Transformer compliance logging

This adds compliance logging to transformer.

One thing to note is that https://github.com/mlperf/training/pull/153 pulled in nearly all of the changes to the compliance/ dir (except for making the timestamp report decimals). So you may find it easier to branch from mlperf/training HEAD rather than the ResNet PR branch to avoid lots of extraneous files in your PR. Or if its easier feel free to leave it as is since a lot of it will simplify once the ResNet PR is merged.

Hi @robieta I think this is ready for review. Please let me know if i missed anything. Thanks!


design conditional binding

e.g. When()

at first step we need to have a Request and BindingConfiguration classes, because we need some subject data to be processed in When.

we need a tests now

TIP: conditional binding make resolvation slower! use carefully!

we need one more additional test: test that checks for child context exists if name has changed.
other words: if child name converts to parent name by its tree we need to create new child context.

probably we need more tests, but I can't create them at this time.


[Discussion] using Apollo Client's queryPreloader in TanStack router loaders

Please don't merge, this is just a PR because it allows me to easily highlight code changes to the default example :)
We talked about support for Apollo Client's queryPreloader in TanStack router loaders yesterday, and I promised you a write-up what we need.
Having created this example, I'm not even sure if we need anything more at this point 😅
Generally, we need these things:

Hook into serialization of loader function return values
Hook into deserialization of loader function values as soon as possible

Best would be directly after the loader data made it over the wire, but at the latest when useLoaderData is called
This deserialization needs access to the current Apollo Client instance and deserialzation triggers a side effect
This could be done by closing over client in createRouter, but it would be even better if the transformer had access to the current context in some way - this way, router.update could change the client instance without things breaking.

So, this is much less of a feature request than I initially imagined - more of a bunch of questions at this point:

Can transformer return objects that contain Promise intances?
What about streams? That would allow us to support GraphQL features like @defer, where the response arrives in chunks, so this would be really cool!
When does deserialization happen? Immediately when data arrives?
Do you see any chance of exposing context to the transformer?
A bit of a quality-of-life thing: could you imagine to allow an array of transformers in transformer? Could be useful if more libraries start shipping transformers :)

Adding @jerelmiller to the discussion, too :)

Things I believe to be true from reading the source code:

AFAIK transformer can return Promise/Stream objects should the transformer support it. It must be able to hydrate/dehydrate them. Examples of transformers that can do this is i.e. seroval. If the promises are suspended in a React component then React takes care of the serialization/deserialization - see the source code for defer() and useAwaited() where they throw a promise (but add some additional state to aid with keeping track of whether their state is pending/errored/success).
Same goes for streams.
Happens inside of  where there is a  which calls the provided transformer. Basically while rendering the client.
If Apollo has its own transformer for hydration/dehydration, the router provides hydrate and dehydrate options. You have access to the context while constructing the router.
The types for "piping" transformers isn't that nice so I don't think it would be implemented.

Also looking at the changes in the PR:

To wrap the router tree with context providers, the router provides InnerWrap and Wrap options.

I'm not too familiar with how Apollo Client handles hydration/dehydration, but from a quick cursory look at the docs:
Server-side:
// Add this import to the top of the file
import { getDataFromTree } from "@apollo/client/react/ssr";

// Replace the TODO with this
getDataFromTree(App).then((content) => {
  // Extract the entirety of the Apollo Client cache's current state
  const initialState = client.extract();

  // Add both the page content and the cache state to a top-level component
  const html = <Html content={content} state={initialState} />;

  // Render the component to static markup and return it
  res.status(200);
  res.send(`<!doctype html>\n${ReactDOM.renderToStaticMarkup(html)}`);
  res.end();
});

Client-side:
const client = new ApolloClient({
  cache: new InMemoryCache().restore(window.__APOLLO_STATE__),
  uri: 'https://example.com/graphql'
});

If this method also dehydrates the client's cache to support streaming as well, you could call client.extract() in hydrate() { ... } and new InMemoryCache.restore(stringFromHydrate) in dehydrate() { ... }.
Otherwise, could you link to any docs or some source code on how to get hydration via. streaming working with Apollo Client?

Otherwise, could you link to any docs or some source code on how to get hydration via. streaming working with Apollo Client?

There is no extra hydration beyond what I showed here - hydration would be a side effect of the queryRef parsing, only hydrating that small part of the store - it would all be hidden inside transform.parse.
These old patterns of "dehydrate the full store" and "hydrate the full store" don't work in renderToStream scenarios anymore, since the store is already created (and interactive) in the browser long before it will be filled on the server - so instead we have to selectively hydrate pieces as they make it over, in this case in the form of a QueryRef object.
We have alternative transport mechanisms for the suspenseful useSuspenseQuery/useBackgroundQuery/useReadQuery hooks, but these are quite complex to set up if not directly supported by a framework, so in a first step I'd try to concentrate on the loader scenario, before we get into that with TanStack Start :)


SoapUI test validation not working

Having followed the Testing Instructions and executed the AddManufacturer Soap test, I'm getting the following validation error.
<SOAP-ENV:Envelope xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/">
   <SOAP-ENV:Header/>
   <SOAP-ENV:Body>
      <SOAP-ENV:Fault>
         <faultcode>SOAP-ENV:Client</faultcode>
         <faultstring xml:lang="en">Validation error</faultstring>
         <detail>
            <spring-ws:ValidationError xmlns:spring-ws="http://springframework.org/spring-ws">cvc-complex-type.2.4.a: Invalid content was found starting with element 'ns1:Name'. One of '{"http://www.alliander.com/schemas/osgp/common/firmwaremanagement/2014/10":Id}' is expected.</spring-ws:ValidationError>
         </detail>
      </SOAP-ENV:Fault>
   </SOAP-ENV:Body>
</SOAP-ENV:Envelope>

The link of the error message is also broken http://www.alliander.com/schemas/osgp/common/firmwaremanagement/2014/10

other errors I'm getting
Tue Mar 13 09:07:14 PYST 2018:ERROR:Could not load keystore/truststore
Tue Mar 13 09:07:14 PYST 2018:ERROR:java.io.FileNotFoundException: /home/dev/Sources/OSGP/Integration-Tests/platform-tests/certificates/test-org.pfx (No such file or directory)

I've tried it both ways, by adding the project files of the documentation and by creating a new project from scratch and adding the test-org.pfx certificate. Getting errors either way

Did you install the VM by following the documentation?:
http://documentation.opensmartgridplatform.org/Userguide/Installation/Setup-VM-Vagrant.html
The application is looking for files in:
/home/dev/Sources/OSGP/Integration-Tests/platform-tests/certificates/test-org.pfx
Does that file exist?
Have you cloned all the sources from git?

Yes I used vagrant to install the VM.
There is no such directory, the directory containing the test-org.pfx file as specified in the documentation is:
/home/dev/Sources/OSGP/Config/certificates/osgp-ca/certs/test-org.pfx
I'm wondering why the app is trying to access the wrong location? Should I update the code and make a pull request?

Hmm..
https://github.com/OSGP/Config should be cloned into /home/dev/Sources/OSGP
cd /home/dev/Sources/OSGP
git clone https://github.com/OSGP/Config.git
This should do the trick.

I think the puppet scripts did not finished successfully.
As I can see in the source: https://github.com/OSGP/Config/blob/development/puppet/manifests/clone-repositories.pp
All repositories should be cloned on VM installation.

I just cloned Integration-Tests.git because it was missing. But still I get the error and I can see why. The directory where the file is located is
/home/dev/Sources/OSGP/Integration-Tests/certificates/test-org.pfx
not
/home/dev/Sources/OSGP/Integration-Tests/platform-tests/certificates/test-org.pfx
Ok so I created a folder named platform-tests and put in the certificates folder to match the location url. That solved the issue but I'm still getting this error:
<SOAP-ENV:Envelope xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/">
   <SOAP-ENV:Header/>
   <SOAP-ENV:Body>
      <SOAP-ENV:Fault>
         <faultcode>SOAP-ENV:Client</faultcode>
         <faultstring xml:lang="en">Validation error</faultstring>
         <detail>
            <spring-ws:ValidationError xmlns:spring-ws="http://springframework.org/spring-ws">cvc-complex-type.2.4.a: Invalid content was found starting with element 'ns1:Name'. One of '{"http://www.alliander.com/schemas/osgp/common/firmwaremanagement/2014/10":Id}' is expected.</spring-ws:ValidationError>
         </detail>
      </SOAP-ENV:Fault>
   </SOAP-ENV:Body>
</SOAP-ENV:Envelope>

I feel like something is terribly wrong as nothing seems to work like intended. Maybe there is another respository which vagrant didn't clone, let me check

All the other repositories are present.

The link of the error message is also broken http://www.alliander.com/schemas/osgp/common/firmwaremanagement/2014/10

Thank you for reporting this, however, the URL is only used as a namespace. We don't actually own the domain and we don't host the XSDs.


chore: Update envd lsp automatically

Description

Message from the maintainers:
Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

/assign

I will update the dependecy of envd at envd-lsp to v0.1.0, v0.2.0, v0.2.1, v0.2.2, v0.2.3, v0.2.4 at several PR, and push a tag for each. Then use a dependabot to keep the version up to date.
Steps

[ ] Update? envd dependecy to v0.1.0
[ ] Update envd dependecy to v0.2.0
[ ] Update envd dependecy to v0.2.2
[ ] Update envd dependecy to v0.2.3
[ ] Update envd dependecy to v0.2.4
[ ] deploy an dependabot
[ ] Github action for auto push tag


Bump V8 version to 8.1.3

The version was grabbed from here: https://omahaproxy.appspot.com/ (via v8 doc: https://v8.dev/docs/version-numbers)

@microsoftopensource could I get this reviewed / merged? Thanks


Incorrect call description header for PUT /studies/{studyDbId}/layout

https://app.swaggerhub.com/apis/PlantBreedingAPI/BrAPI/1.2#/Studies/put_studies__studyDbId__layout
"Retrieve plot layout details" should be "Modify plot layout details"

Also applies to PUT /studies/{studyDbId}/observations
https://app.swaggerhub.com/apis/PlantBreedingAPI/BrAPI/1.2#/Studies/put_studies__studyDbId__observations


Unhandled dispatcher exception: Root element missing

Trying to install Uploader on Windows 10 (.NETFramework 4.6.2+ installed) with HotsApiUploaderSetup.exe (<IP_ADDRESS>) crashes on run with below exception:

After 'OK', another exception is created:

I get this all the time, regardless of internet connection status. You have made we wonder though whether it's an issue with my security/firewall blocking a connection.


Remote Debug - need to change network/debug/remote_port each time using remote debug deploy to Android to get remote print statement/crash point to console

Tested versions
v4.2.1-stable_win64
System information
Godot v4.2.1.stable - Windows 10.0.22631 - Vulkan (Mobile) - dedicated NVIDIA GeForce RTX 3050 6GB Laptop GPU () - 12th Gen Intel(R) Core(TM) i7-12650H (16 Threads)
Issue description
When deploying to Android, with each deploy I must change the port network/debug/remote_port in order for print statements/crash points to appear in my PC's Godot console/code. The deploy works fine, just no printing through to the console unless its the first deploy or I change port each time.
Please note I am using the Poing Admob Plugin (latest).
I'm not sure if its related (but different) to this bug https://github.com/godotengine/godot/issues/58486, where in this scenario its using an old connection that has ended?
Steps to reproduce
Install JDK / SDK as per command line tool docs: https://docs.godotengine.org/en/4.2/tutorials/export/exporting_for_android.html#install-openjdk-17
[Potentially] install Admob Poing Studios v3.1.0 and follow instructions
Create basic scene with a print statement
Remote deploy to Android device
see print statement in console
Remote deploy again to android device
no print statement in console
Change port #  network/debug/remote_port to 6009+
Remote deploy again to android device
see print statement in console
From reading online (which I can't find now) it sounded like this used to be an issue in Godot but it was since updated to automatically try a new port if comms were lost. I'm wondering if either A) its something to do on my end, or B) potentially a regression. This is my first time reporting a bug so I appologise in advance if I missed something. I have found at least one other person in the Godot Discord server having the same issue.
Minimal reproduction project (MRP)
N/A

Found a previous issue, apologies this may be a doubleup https://github.com/godotengine/godot/issues/41650

Thanks for the report! Consolidating in https://github.com/godotengine/godot/issues/41650.


Introduce LATEST_INDEX_IMG env var to fix next CI build

Signed-off-by: Josh Pinkney<EMAIL_ADDRESS>What does this PR do?
This cherry-picks that last change from master that we need to be in v1.0.x branch
What issues does this PR fix or reference?
https://issues.redhat.com/projects/WTO/issues/WTO-49?filter=allissues
Is it tested? How?

Ah nvm, it was already in the v1.0.x branch. I just didn't have that branch updated.


NetTcp features and fixes

@BetsyRT try

:lock: Merge conflict

Trying to resolve the merge conflict offline


Finer grained timestamp queries

Currently all timestamp queries in the same command buffer are getting the same time set to them. While digging around in the metal docs i found this https://developer.apple.com/documentation/metal/mtlcommandbuffer/1639924-gpustarttime?language=objc
In my setup i have one query at the start of a command buffer and then one query at the end. I use this to figure out how long that command buffer took on the gpu. Currently on macOS it reports a duration of 0 due to the identical timestamps.
Would it be possible to get access to this other timestamp through mvk? For example get the start time in the first query and end time in the second?

Are you running on a tile-based GPU (Apple Silicon, iOS, etc)?
And what's inside your command buffer?
Tile-based GPU's can't timestamp a the draw-call level, and only timestamp at the end of each encoder (render pass, BLIT, or compute). If you're running a single-render-pass command buffer, then all timestamps will be taken at the end. If you're running multiple render passes, or dispatches, etc, then you should see differing timestamps within a command buffer run.
However, if you put the first timestamp before and outside of a render pass, it should have a different timestamp than a query at the end of, or after, the render pass.
We could conceivably use GPUStartTime for a timestamp query posted before any work on a command buffer, but that seems like a special case compared to the general handling of what are possibly many timestamp queries in a command buffer.

I'm running on macOS 12.6 mbp early 2015 which contains an Intel Iris Graphics 6100.
I was ment to link this instead, but you got the point anyhow. Just leaving it here for reference.
Xcode metal capture doesn't show all vulkan commands so i've captured the same app on windows with renderdoc instead:
queries.zip
In short:
BeginCommandBuffer
	WriteTimestamp A
	BeginRenderPass
		WriteTimestamp 0
		DrawIndexed
		WriteTimestamp 1
		DrawIndexed
		WriteTimestamp 2
		DrawIndexed
		WriteTimestamp 3
		Draw
		Draw
		WriteTimestamp 4
	EndRenderPass
	WriteTimestamp B
EndCommandBuffer

Now both Timestamp B - Timestamp A results in 0 as does Timestamp 4 - Timestamp 0.
Having Timestamp 4 - Timestamp 0 be valid would be kind of nice but not required. Timestamp 0 is written before any work is being sent to the gpu so i think it would make sense if that receives the GPUStartTime as well?
Realistically i only need B - A to be valid, what i understand from your message this should be working?
The timestamps do contain values, it's just that they're the same.


fix controller-gen version to v0.4.0 and update the copyright

Signed-off-by: uxchen<EMAIL_ADDRESS>

Thank you for your contribution


[suggestion] Landing in a void

Hi... one thing I am not sure how to solve. When I have a void, or mostly void dimension like Sky Islands I have a big chance to loose my rocket on landing and there is nothing I can o with it. Also when it is a Lava Ocean dimension etc.
Is there some way you can deal with such thing using AdvRocketry? I don't think there is one now, but here are possibiities I am thinking about:

Emergency return - When you see you are landing in something bad, you can do a fast emergency reignition of the engine, returning back to your place of origin.
Forward base deployment - You can send a space station to any dimension and it will be placed on the first surface/liquid it will meet or it will be placed in a hardcoded height in the target dimension.

Howabout a deployable "float"?

Spacex: Just Read the Instructions

?? @ZexMaxwell001 ?? Yes... like that, why not. But right now this is not possible, right? You can deploy base only in the 'SpaceBase' dimension, right?

I have this issue as well. It is highly unfortunate when your rocket falls into the void. I have a modpack where the end is actually a planet and often the rocket doesn't land on one of the islands :(


findLastTransactionByHash does not work as expected

Only first transaction in txList for out message checked:

		for i, transaction := range txList {
			if i == 0 {
				// get previous of the oldest tx, in case if we need to scan deeper
				lastLt, lastHash = txList[0].PrevTxLT, txList[0].PrevTxHash
			}

			if isOut {
				if transaction.IO.Out == nil {
					continue
				}

				list, err := transaction.IO.Out.ToSlice()
				if err != nil {
					return nil, fmt.Errorf("cannot list out messages: %w", err)
				}

				for _, m := range list {
					if bytes.Equal(m.Msg.Payload().Hash(), msgHash) {
						return transaction, nil
					}
				}
                  // TODO: continue required for other transactions check
                 // TODO: return transaction, nil at the end of range txList { also should be fixed
...

m.Msg.Payload().Hash() calculation seems wrong. It calculates hash different than what is displayed in ton explorer. Transaction hash remains correct.

Yes

As i see in master branch, it checks all transactions until limit, not just one.

This is the hash of payload, it is used for data comparing, explorers probably shows full external message hash, but it changes after commit and could not be used to find transaction since it is not known on moment of external push.

Fixed in dev branch


Inconsistent behaviour of Dynamic Links on App Open

Xcode version: 9.2
Firebase SDK version: 4.9.0
Firebase Component: Dynamic Links
Component version: 2.3.2

Have setup dynamic links for my project for both iOS and Android apps and all is working well expect for the following:
On iOS 10 device (10.3.2) I can observe:

When app is first opened after user receives a dynamic link, AppDelgate's application:open:options: function is called with the expected link
When app is in background and user hits dynamic link AppDelegate's application:continue:restorationHandler as expected
When app is closed and opened normally (no dynamic link) neither of the above functions is called.
This is all as expected from the docs

However on iOS 11 device (11.2.6):

When app is first opened after user receives a dynamic link, AppDelgate's application:open:options: function is called with the expected link
When app is closed and opened normally (no dynamic link) application:open:options: is always called with a url:  "my_custom_scheme://google/link/?dismiss=1&is_weak_match=1"

According to documentation call to  application:open:options: should happen only after 1st time open after install.
Now my code can handle this by ignoring the nil url returned by dynamicLink(fromCustomSchemeURL: url) but this is unexpected behaviour and I'm concerned about the predictability of user experience across devices and use cases as it is inconsistent.
Important to note that my dynamic link is configured with efr=1 as its used primary on web landing pages.
Any insight would be appreciated. I don't know if this is an iOS compatibility problem, a device fingerprinting problem or otherwise

This looks like a bug on our end, but even if it's not, it's probably something we should be documenting.

Sounds like your app had a pending DL. Am not able to repro it atm on 11.2.6. Is this always repro for you? Please reopen if still happening.

Hi,
This issue is happening with me on iOS 11.4.2 and also iOS 10. I'm always getting "my_custom_scheme://google/link/?dismiss=1&is_weak_match=1" when the App is killed and I open it via dynamic link. How can we know where's the problem?


Remove ReDigi, MonteCarlo and MonteCarloFromGEN specs

Fixes #8918
And let's see how badly the tests will fail...

test this please

This is looking good in my VM tests. Merging it to cut a new release and test again.


Very old, preview version of Microsoft.Azure.Services.AppAuthentication

In the 'Modify ASP.NET code' section, it is written to use an old, preview version of Microsoft.Azure.Services.AppAuthentication package (1.1.0-preview, published 2 years ago: 16/11/2017).
Is it safe to use the latest stable version (1.0.3, from 13/06/2018) in order to get the token, in .NET 4.7.2?
(when using Azure AD managed identities to authenticate to Azure SQL Managed Instance from an Azure app service)
Do you know when the next stable version (1.2.0?) will be released?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 31b0d33c-f88e-d50c-2926-7933940f3b92
Version Independent ID: 4aaef906-f501-6947-5d23-1b704470f09d
Content: Secure SQL Database connection with managed identity - Azure App Service
Content Source: articles/app-service/app-service-web-tutorial-connect-msi.md
Service: app-service-web
GitHub Login: @cephalin
Microsoft Alias: cephalin

@tudort-iquest Thanks for the question! We are investigating and will update you shortly.

@tudort-iquest Thanks again for the feedback! We are working on it and will be published soon. I have assigned the issue to the content author to review further and update the document as appropriate.

Thanks! As far as I can see, the final/stable 1.2.0 version of Microsoft.Azure.Services.AppAuthentication package has just been published a few days ago ( https://www.nuget.org/packages/Microsoft.Azure.Services.AppAuthentication/1.2.0 )

@tudort-iquest Thanks. This doc has been updated. #please-close


Add documentation about generics

Description
Specifically with regards to the action() method, if generics aren't used you'll receive TypeScript errors. This relates to #251 and #252. We should document the use of generics, possibly in a TypeScript-specific guide.
What type of issue is this? (place an x in one of the [ ])

[ ] bug
[ ] enhancement (feature request)
[ ] question
[x] documentation related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Closing this but certainly will be taking into consideration as @slack/types and bolt-js new major versions come out that will likely more fully employ generics.


Inheritance screen Alignment

[x] Alignment from top to Bottom
[ ] Swiping of screen is also not correct wherever we have 3 screen

Completed


Fix parsing of animated emoji from Discord

(Fixes #384.)
On the Discord side of things, the new animated emoji get a prefixed to their identifier string, so that instead of the normal emoji string:
<:test:330064465703862273>
you instead get:
<a:test:330064465703862273>
This commit fixes parseText to also process the animated form into :test: (as we currently do for non-animated emoji).

Coverage remained the same at 98.48% when pulling 0bb58a5344fbe2b916f867ced825b3a7ba1c24bd on Throne3d:fix/384-animated-emoji into 22e3bece3cfa15f60aa28ff1e317ec2512952ee2 on reactiflux:master.

Coverage remained the same at 98.48% when pulling 0bb58a5344fbe2b916f867ced825b3a7ba1c24bd on Throne3d:fix/384-animated-emoji into 22e3bece3cfa15f60aa28ff1e317ec2512952ee2 on reactiflux:master.

Great!


How to build for wasm32-wasi?

Not sure of the steps to do this?

This is how far we get after cloning repo and submodule.
Set up the include environment variable.
export C_INCLUDE_PATH=/usr/include/:/usr/include/x86_64-linux-gnu
Add the following to lib.rs.
.arg("no-ui");
if target.contains("wasi") {
configure.arg("no-asm");
configure.arg("no-sock");
configure.arg("no-afalgeng");
}
configure.arg("-DOPENSSL_NO_SOCK");
configure.arg("-DOPENSSL_NO_DGRAM");
configure.arg("-DNO_SYSLOG");  // not supposed to be set externally
Run the following command from the root.
cargo run --manifest-path ./testcrate/Cargo.toml --target wasm32-wasi --features="package"
We get the following errors.
--- stderr
***** Deprecated options: no-ui
apps/apps.c:2707:5: error: invalid output constraint '=c' in asm
FD_ZERO(&asyncfds);
^
/usr/include/sys/select.h:88:26: note: expanded from macro 'FD_ZERO'
#define FD_ZERO(fdsetp)         __FD_ZERO (fdsetp)
^
/usr/include/bits/select.h:37:8: note: expanded from macro '__FD_ZERO'
: "=c" (__d0), "=D" (__d1)
^
1 error generated.
make[1]: *** [Makefile:688: apps/apps.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:177: build_libs] Error 2
thread 'main' panicked at '
Error building OpenSSL:
Command: "make" "build_libs"
Exit status: exit code: 2

Able to get it to build with --target wasm32-wasi:

Installed lib6
Installed http://ports.ubuntu.com/pool/universe/w/wasi-libc/wasi-libc_0.0~git20200319.9efc2f4-2_all.deb
Set export C_INCLUDE_PATH=/usr/include/wasm32-wasi:/usr/include/:/usr/include/x86_64-linux-gnu

Set in  src/lib.rs
        configure.arg("-DOPENSSL_NO_SOCK");
        configure.arg("-D_WASI_EMULATED_MMAN");
        configure.arg("-DOPENSSL_NO_DGRAM");
        configure.arg("-DNO_SYSLOG");  // not supposed to be set externally


Bug: list index out of range

Hi, I'm trying to put a list of dictionaries inside a collection, running this python code:

collection = client.get_collection(name="slack_test_collection")
collection.add(
    documents = [item['text'] for item in messages],
    metadatas = [{"channel": item['channel'], "user": item['user'], "date": item['date']} for item in messages],
    # ids = [item['channel'] + " " + item['date'] for item in messages]
    ids = [str(i) for i in range(len(messages))]
)

Getting this error
IndexError                                Traceback (most recent call last)
Cell In [47], line 2
      1 collection = client.get_collection(name="slack_test_collection")
----> 2 collection.add(
      3     documents = [item['text'] for item in messages],
      4     metadatas = [{"channel": item['channel'], "user": item['user'], "date": item['date']} for item in messages],
      5     # ids = [item['channel'] + " " + item['date'] for item in messages]
      6     ids = [str(i) for i in range(len(messages))]
      7 )

File c:\Users\User\AppData\Local\Programs\Python\Python39\lib\site-packages\chromadb\api\models\Collection.py:102, in Collection.add(self, ids, embeddings, metadatas, documents, increment_index)
     99         raise ValueError("You must provide embeddings or a function to compute them")
    100     embeddings = self._embedding_function(documents)
--> 102 self._client._add(ids, self.name, embeddings, metadatas, documents, increment_index)

File c:\Users\User\AppData\Local\Programs\Python\Python39\lib\site-packages\chromadb\api\local.py:93, in LocalAPI._add(self, ids, collection_name, embeddings, metadatas, documents, increment_index)
     84 def _add(
     85     self,
     86     ids,
   (...)
     91     increment_index=True,
     92 ):
---> 93     collection_uuid = self._db.get_collection_uuid_from_name(collection_name)
     94     added_uuids = self._db.add(
...
---> 72     return self._conn.execute(
     73         f"""SELECT uuid FROM collections WHERE name = ?""", [name]
     74     ).fetchall()[0][0]

IndexError: list index out of range

Please assist

Hi - have you already client.create_collection()? Before calling get or adding?

Yes of course

Ok apparently I did not call client.create_collection() and this what caused the bug.
Now the problem I see is that
collection = chroma_client.create_collection(name="slack_test_collection")
did not raise an error even though the collection slack_test_collection does not exist

Yes, client.get_collection() should error if the collection does not exist. Sorry for this ! I have opened #170 and we will remedy it :)

One note to this that I struggled with: do not use ids with special characters. I had ":" in my id name and got the error mentioned here.


Meteor swarm abuse

Description

Meteor swarm can be defeated with any sized puddle or flying items. Banana peels throw or soap that flew out of the destroyed cabinet from the maints

Dupe of #29069! Thanks for the report 🫡


Feature - Improve UI of Gallery section, Map section and Contact Us section

@Gaurav-Verma07 Would like to work on the improvement of Gallery section which allow automatic image transition removing the labor cost of adding buttons. Also would like to customize Contact Us section and make is center aligned and enhanced. Would also like to work on Map and make it horizontal.
Please assign me the issue.

Already opened


Remote Assistance (with file invitation.msrcIncident) over proxy

Remote Assistance by invitation file does not work via proxy.
Tested with xfreerdp as RDP client on Fedora 30 with FreeRDP from git repo, master branch of Nov. 7th.
Target system for assistance was Windows 10.
For testing, start Remote Assistance under Windows 10, with invitation by file :

msra.exe /saveasfile invitation test-password

Copy the resulting file invitation.msrcincident to a Linux PC which can reach the Windows PC only via a proxy (in below example a SOCKS5 proxy at proxy.test.org, port 1080).
Start xfreerdp on the Linux PC, with proxy settings:

xfreerdp invitation.msrcincident /proxy:socks5://proxy.test.org:1080 /assistance:test-password

This does not work (at least in my case it does not use the proxy).
And this patch should fix this: FreeRDP.patch.txt
Basically the patch moves code that tries the multiple destinations given in an invitation file (AFAIK at least IPv4, IPv6 and DNS name of the Windows PC) from a lower layer to a higher layer. This makes proxies work, because they are handled in an intermediate layer which now is used for each destination from the invitation file that is tried.
"higher layer" is nego_tcp_connect() in nego.c
"intermediate layer" is transport_connect() in transport.c
"lower layer" is freerdp_tcp_connect_multi() in tcp.c

@boom1 so, does proxy_prepare not return true in your case?

From my memory: proxy_prepare() does return true and returns the proxy settings from the command line (because I have no environment variables for proxy set).

@boom1 checked it, looks like the glue is not correct for your use case.
The part with connecting to the proxy is lacking the alternative addresses.
the patch you provided is a nice start, but will fail for other cases (everything non NLA).
Mark it as todo.

I agree, the patch still fails for other cases (I did not test it, but gateways seems not to go through the proxy as well).
Thank you for marking it as todo.

@boom1 did some fixes in https://github.com/akallabeth/FreeRDP/tree/proxy_cleanup
does that start working for you?

I have Fedora 30 with openssl 1.1 and can't compile this version (which seems to rely on OpenSSL 1.0 includes).
It fails at winpr/libwinpr/crypto/crypto.h, lines 44/45 (incomplete type of EVP_CIPHER_CTX enc and EVP_CIPHER_CTX dec).
If I change them to be pointers, it goes a bit further but stops at winpr/libwinpr/sspi/NTLM/ntlm.c:887:11

@boom1 start from a clean checkout (and the correct branch). Theseare patches on master.

Sorry, I still had the master branch, but switched to proxy_cleanup now.
I get an segfault, but that seems to be an independent issue, which I had also in master with my patch. I solved it by disabling the free() in stream.c:129.
[...]
10:26:58:232] [20973:20979] [INFO][com.freerdp.gdi] - Local framebuffer format  PIXEL_FORMAT_BGRX32
[10:26:58:232] [20973:20979] [INFO][com.freerdp.gdi] - Remote framebuffer format PIXEL_FORMAT_RGB16
[10:26:58:240] [20973:20979] [INFO][com.winpr.clipboard] - initialized POSIX local file subsystem
[New Thread 0x7fffdd38b700 (LWP 20984)]
[New Thread 0x7fffdcb8a700 (LWP 20985)]
[New Thread 0x7fffd7fff700 (LWP 20986)]
[New Thread 0x7fffd77fe700 (LWP 20987)]
[10:26:58:255] [20973:20987] [INFO][com.freerdp.channels.rdpsnd.client] - Loaded fake backend for rdpsnd
[New Thread 0x7fffd6ffd700 (LWP 20988)]

Thread 2 "xfreerdp" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffe532c700 (LWP 20979)]
0x00007ffff7ba21d0 in free () from /lib64/libc.so.6
[...removed complaint about missing debug info...]
(gdb) bt
#0  0x00007ffff7ba21d0 in free () from /lib64/libc.so.6
#1  0x00007ffff7d68ddf in Stream_Free (s=0x7fffe0000f10, bFreeBuffer=1) at winpr/libwinpr/utils/stream.c:129
#2  0x00007ffff7ea66ce in remdesk_virtual_channel_open_event_ex (lpUserParam=0x7fffe0000f10, openHandle=4, event=11, pData=0x7fffc8000b40, dataLength=58, totalLength=58, dataFlags=0) at channels/remdesk/client/remdesk_main.c:796
#3  0x00007ffff783ebc5 in freerdp_channels_process_message_free (message=0x7fffe532b3d0, type=11) at libfreerdp/core/client.c:471
#4  0x00007ffff783ec94 in freerdp_channels_process_message (instance=0x442ec0, message=0x7fffe532b3d0) at libfreerdp/core/client.c:504
#5  0x00007ffff783ecf0 in freerdp_channels_process_sync (channels=0x476c80, instance=0x442ec0) at libfreerdp/core/client.c:521
#6  0x00007ffff783eec2 in freerdp_channels_check_fds (channels=0x476c80, instance=0x442ec0) at libfreerdp/core/client.c:586
#7  0x00007ffff783b9ac in freerdp_check_event_handles (context=0x443150) at libfreerdp/core/freerdp.c:393
#8  0x00007ffff7f3df98 in xf_client_thread (param=0x442ec0) at client/X11/xf_client.c:1598
#9  0x00007ffff7d9b334 in thread_launcher (arg=0x4b1df0) at winpr/libwinpr/thread/thread.c:327
#10 0x00007ffff76334c0 in start_thread () from /lib64/libpthread.so.0
#11 0x00007ffff7c17553 in clone () from /lib64/libc.so.6
(gdb)

To avoid the segfault I use below hack.
The proxy then works fine, thanks!
diff --git a/channels/remdesk/client/remdesk_main.c b/channels/remdesk/client/remdesk_main.c
index c950d458f..4431d42df 100644
--- a/channels/remdesk/client/remdesk_main.c
+++ b/channels/remdesk/client/remdesk_main.c
@@ -793,7 +793,7 @@ static VOID VCAPITYPE remdesk_virtual_channel_open_event_ex(LPVOID lpUserParam,
                case CHANNEL_EVENT_WRITE_COMPLETE:
                {
                        wStream* s = (wStream*)lpUserParam;
-                       Stream_Free(s, TRUE);
+//                     Stream_Free(s, TRUE);
                }
                break;

By the way, is there a  command line option to immediately request control over the remote assistance session (like pressing Ctrl-Alt-C)?

@boom1 ok, good to know the proxy now works.
the stream free fix you propose is a huge memory leak ;)

Yes, it's a memory leak. The patch was just meant as a quick hack to be able to continue working.
Am I the only one where this Stream_Free() crashes?
I had hoped that would have been solved in the meantime. I don't see any obvious errors, but I also don't really understand the event code (especially not where the message is created).
lpUserParam simply seems not to be a Stream sometimes.

@boom1 fix is in #5718

@boom1 better report such issues immediately (if you find them with nightlies / on a build from current master) as the library can not be tested automatically for every situation (there is some user interaction required, so this is only done case by case)

@akallabeth I was not so confident that this segfault wasn't my fault (because I did local changes and never had touched this project before).

@boom1 no worries, that one was mentioned by you first.
Most rely on downstream packages and there such stuff is usually recognized and fixed.


Use canonical URLs for Maven deploy repositories

This fixes/workarounds the current issues with deploying SNAPSHOTs.

+1

I will send PRs for other branches as well (later today hopefully).


Window powershell

https://github.com/PowerShell/PowerShell/releases/tag/v7.2.4

Come and support  github works globally


Deployment

Deployment
User Story
As a boot camp student,
I want the prework notes to be structured on a webpage,
So that I can easily find and read the information.

GIVEN a Prework Study Guide website,
WHEN I visit the website using the URL,
THEN I can access my website from any browser

deployed webpage and played around with different code to see how it interacted with my repo.


Handle right parens in join comma builder

Summary
The JoinCommaSeparatedBuilder only tested if the first token after the node is a ,.
However, this always fails for expressions with parentheses, because the parentheses are not part of the expression's range.
This PR changes the JoinCommaSeparatedBuilder to skip right parens. However, we need to be careful, because nested(call(arg),) only the outer call has a trailing comma
in this example, not the inner arg. The way this is implemented is by also passing an approxiamted end of the sequence (normally the end of the enclosing node, but we don't always know precisely), and only search between the end of the last node and the end of the sequence.
I further went along and also fixed an issue where single argument call expressions were always parenthesized because is_expression_parenthesized doesn't know that the parens from the arguments belong to the call. The way to solve this is by handling parentheses
manually inside of FormatCallExpr if the call only has a single argument.

Test Plan
See updated snapshot tests.

Current dependencies on/for this PR:

main

PR #5711   👈

This comment was auto-generated by Graphite.


The generated DDL of Adding column is wrong

If trying to add a column,right ddl must be
ALTER TABLE table ADD COLUMNS (newColumn String COMMENT 'comments')

but dbeaver will generate
ALTER TABLE test.table ADD newColumn VARCHAR(100);

What database? Different databases have different syntax.

hive

Unfortunately DBeaver doesn't support Hive-specific DDL (yet, maybe).
Generated DDL conforms SQL-92 standard.
To generate Hive-specific DDL we'll need to make new driver extension, at the moment there are no plans to make it for Hive (or there are too many other more prioritized databases to support).
You can make feature request for Hive extension. But I can't say when I'll have a time to work on it...

I think if you don't remove hive support,this bug should be kept open

If I will keep all not-implemented features for all unsupported databases open then there will be zillions of open issues with blurry status. It is hard to manage big number of open issues.
I think it's better to reopen them or create new ones when it will make sense.


marcin

Name
marcin
Description
g
Addresses
0x5eEE5eB8E26bbD7B7D7d83A0664f0b60dd013a10
Meta Article URLs
g

Hey, thank you for opening this issue. This specific repository is only for smart contract exploits, not for phishing websites or compromised wallets. If you want to figure out what happened to your wallet I would recommend looking at this flowchart. If you need more help I recommend reaching out in our Discord.


term: viewport is incorrectly defined

The current insertion point is calculated incorrectly. VT cursor positioning commands do not work as expected.

Introduce new concept for terminal text layout
During resize, text lines that have the wrap attribute enabled are wrapped over the underlying ones.
rods

It is curious whether this approach is compatible with terminal reality.

That is an interesting effect if the context in the screen doesn’t wrap.  What would happen if you were editing something in the window, say with vim, and had line wrap on in the editor.  As you change the size of the screen  would vim be the first to wrap, hence leaving nothing to wrap by the terminal?
Sent from my iPad

On Feb 3, 2021, at 3:11 AM, Dmitry Sapozhnikov<EMAIL_ADDRESS>wrote:

Introduce new concept for terminal text layout
During resize, text lines that have the wrap attribute enabled are wrapped over the underlying ones.
rods
It is curious whether this approach is compatible with terminal reality.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

As you change the size of the screen  would vim be the first to wrap, hence leaving nothing to wrap by the terminal?

Almost all full-screen terminal applications do their own wrapping by inserting \n or \e[y;xH  at the end. These applications keep track of the terminal size changes and redraw the entire screen when resizing.
For example vim

When emitting long lines, terminal applications can rely on the terminal, but there is no single approach to wrap lines in terminals:

Terminals can calculate the length of a string in cells using a different algorithm than the application, and as a result, they do wrapping in a different place where the application suggests
There is no standard approach to dissecting ligatures and wide characters (Emoji, CJK) at the edge of the screen, although most wraps these characters entirely on a new line, the application cannot know about it in advance

For example vim adds > + \e[2;1H if a wide character is encountered at the end

VTM built-in terminal reserves additional screen lines under the long lines when outputting a file with long lines directly

The most important advantage of such a text layout in the terminal is the correct support for characters larger than one cell

Ultimately, this is required to support the following functionality

It is important to note that the process of overlaying lines is reversible, i.e. when overlaid, the lines themselves are not mangled, they are only drawn overlaid.

You can control whether the line is wrapped or not using private VT-commands

CSI 12 : 0 p disable wrapping (\e[12:0p)
CSI 12 : 1 p enable wrapping (\e[12:1p)

Apparently, the rods concept is quite compatible with the terminal reality.
This can be tested with v0.2.9 release.


Automatically determine the best incumbent

Use the EPM to determine which of all possible incumbents should be best.
This avoids the necessity for a user to specify the trajectory file from which an incumbent should be read.

@robintibor I mentioned in our last mail that I was working on that. Now it's done and in the master branch :)

ok cool

Should be part of SMAC


[UI] Filter metadata by error message

use checkboxes to filter by error message

https://github.com/ebi-ait/ingest-ui/pull/71


IEnumerable Option ignores duplicate values

Passing the following -s "one" "two" "three" "three" "three" to an option that's an IEnumerable<string> will yield only the first 3 strings and ignore the last 2.

A bugfix for this issue has been merged into the develop branch, and will eventually be released in version 2.9.0. That release was delayed by several months by an outdated NuGet API key, but #733 takes care of that problem, so hopefully the release with that bugfix will be available soon.


Reverse me command doesn't preserve captials

Currently if Lisa reverse text like this !tooW then she responds with woot!
Should find a way to retain raw text so capitals can be maintained.

I screwed up and merged this directly to master. I have since added branch protections to hopefully prevent that from happening. Here's the commit https://github.com/Splyth/slack_bot/commit/5f5a7e6431a8101815028d35672cf6a325da52ab


Run go mod tidy on fips-server

What does this PR do?
Run go mod tidy on fips-server
Which scenarios this will impact?
Motivation
My IDE complains about it
Additional Notes

/merge


create polymer/mirrors_used.dart

 Issue by sigmundch
Originally opened as dart-lang/sdk#17924

Similar to what we have in observe/mirrors_used.dart, we might want to create a similar library in case we need a fallback.
If codegen don't work as expected, then users could write:
import 'package:polymer/mirrors_used.dart'; // for smaller code
import 'package:polymer/polymer.dart';
import 'package:smoke/mirrors.dart';
main() {
  useMirrors();
  initPolymer().run(...);
}

 Comment by jmesserly

Removed Area-Polymer label.
Added Pkg-Polymer, Area-Pkg labels.

 Comment by sigmundch

seems that we haven't have the need for it.

Added NotPlanned label.


Add keyboard shortcut to trigger full-screen snapshotting

Prior to this commit, the full page screen capture extension had no
extension specified hotkey to trigger a full page screen capture.
Now, we’ve specified to use “ctrl+shift+F” (“F” for “full screen”, or
“fun”) to launch the browser action.
Note that existing users will need to remove and re-load the extension
for this to take place, otherwise they need to go to the extensions tab
and set the keyboard shortcuts for themselves.

Cool, thanks @BSierakowski !  I just got back from a vacation, so looking now.
Do you have much exposure to what other extensions use for combinations? The only extension I actively use that has a default keyboard shortcut is “Markdown here”, which uses ctrl + option + m. In my own toggling of the keyboard shortcut, using the optional feature (at the bottom of the extensions screen in chrome), I had it set as cmd + p, but that might seem too risky for a collision as a suggested default. And in the PR you are suggesting crl+shift+F. The “F” felt a bit weird to me at first, but maybe it’s actually fine and a nice level of consistency to match the first letter of the extension’s name. Any thoughts on shift vs option though?

+1 for this issue. But there's some problems @mrcoles is suggesting.
Then, how about implementing Timer function?
It might solve @BSierakowski 's and my problem. maybe.


Design: Explore tab

Designs:
https://www.figma.com/design/cvV48t0f7O2znT6QBxK0Zj/Tonomy-ID?node-id=9187-8548&t=3oNnqTePFfT6mA0P-1

has this comment been actioned? https://www.figma.com/design/cvV48t0f7O2znT6QBxK0Zj?node-id=9187-8548#911389214

I dont see any changes since our last discussion


Update Eureka Server's service-urls upon EnvironmentChangeEvent.

Fixes gh-2421

@ryanjbaxter I would like to request a rebuild, because the test failure is from FormZuulServletProxyApplicationTests and most unlikely due to my check-in. I've run all the tests on my branch however could not observe any test failures. Is it possible to share the surefire outputs?

Codecov Report

Merging #2455 into master will increase coverage by 0.08%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2455      +/-   ##
==========================================
+ Coverage   68.27%   68.35%   +0.08%
==========================================
  Files         236      236
  Lines        8308     8312       +4
  Branches     1031     1031
==========================================
+ Hits         5672     5682      +10
+ Misses       2248     2241       -7
- Partials      388      389       +1

Impacted Files
Coverage Δ

...x/eureka/server/EurekaServerAutoConfiguration.java
93.54% <100%> (+0.44%)
:arrow_up:

...lix/turbine/stream/TurbineStreamConfiguration.java
86.36% <0%> (+13.63%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e3b4fd...ac7da13. Read the comment docs.

I would only update if specific keys are changed

Thanks @ryanjbaxter @spencergibb.
Yeah, that makes sense and hope change to either availability-zone,region or service-urls should trigger the update.

@spencergibb @ryanjbaxter Checked-in and rebased.
I've avoided String.matches() / regex due to readability and performance. Also changedKeys.contains("eureka.client.region") is checked first since it's a O(1) operation. Kindly have a look.

I've addressed the review comments. Will rebase once you reviewed it.

@spencergibb I've addressed the review comments. Please have a look. Will rebase once you reviewed.

@spencergibb I've addressed the review comments. Please have a look. Will rebase once you reviewed.

@spencergibb @ryanjbaxter Appreciate if you could review and let me know if anything needs to be addressed.

@ryanjbaxter I've rebased it. Kindly let me know if anything is pending from my-side to proceed with merging.

@fahimfarookme thanks.  The only outstanding thing from my side was my comment https://github.com/spring-cloud/spring-cloud-netflix/pull/2455#discussion_r153247584.  I think this might make sense to do

Thanks @ryanjbaxter for the review. I did a quick micro-benchmark with JMH since it looks like the submitted PR could perform better than the suggestion.
In the benchmark results below:

BenchmarkRunner.submitted - is my PR
BenchmarkRunner.suggested - is what you have suggested. i.e.

for (final String key : changedKeys) {
	if (key.startsWith("eureka.client.service-url.") ||
		key.startsWith("eureka.client.availability-zones.") ||
		changedKeys.contains("eureka.client.region")) {
		return true;
	}
}

BenchmarkRunner.possibleSuggestion - I also tried another version along the lines of what you've suggested. i.e.

for (final String key : changedKeys) {
	if (key.startsWith("eureka.client.service-url.") ||
		key.startsWith("eureka.client.availability-zones.") ||
		"eureka.client.region".equals(key)) {
		return true;
	}
}

Here's the JMH results.
1. Throughput (higher the better)

Benchmark
Mode
Cnt
Score
Error
Units

BenchmarkRunner.possibleSuggestion
thrpt
20
5267629.307
±  571685.517
ops/s

BenchmarkRunner.submitted
thrpt
20
8492321.724
± 2838354.868
ops/s

BenchmarkRunner.suggested
thrpt
20
3019842.359
±  796130.173
ops/s

2. Average time (lower the better)

Benchmark
Mode
Cnt
Score
Error
Units

BenchmarkRunner.possibleSuggestion
avgt
20
≈ 10⁻⁷

s/op

BenchmarkRunner.submitted
avgt
20
≈ 10⁻⁷

s/op

BenchmarkRunner.suggested
avgt
20
≈ 10⁻⁶

s/op

Based on the results above the submitted PR is already the optimized version. Your thoughts please...


Allow ignoring review requests

Unfortunately, sometimes I am added as a reviewer or tagged on PRs in repositories I didn't even know existed, and they linger on Mergeable:

I'm not really sure how this got here, it's under "Incoming reviews", but I am not actually a reviewer (and I don't know the repository): https://github.com/ullashb/opensource.guide/pull/10

Ignoring pull requests would definitely be a useful feature!
In this instance though, it's puzzling me why you would see it in the "Incoming reviews" section. If you are using the default section, it means this PR is surfaced by one of the following search requests: either is:pr is:open -author:@me review-requested:@me or is:pr is:open -author:@me involves:@me. Could you try those in GitHub's UI and see which one fetches the PR (if any)?

It's involves:@me, most likely a spam bot tagged me in one of the comments that were hidden


Remove Wiki

In efforts to streamline documentation, I would like to remove the github wiki pages and link to the wikijs site we are building. Any concerns?
https://wiki.printnc.info/en/home

That seems reasonable to me. I think the wiki here is hard to find for many people. Having it linked from the main github page would help that, but if the new one is easier to design and contribute to, I'm all for it.

The new wiki should be much easier to work with. It allows for Discord and site-specific logins, has a WYSIWYG editor, and has local image hosting.
The only barrier to get started is obtaining 'contributor' status. Anyone who has made an account thus far is already a contributor.
If you would like to contribute but have not yet made an account, that's the first step.
From there, we can edit your privileges.
This wiki should be gone by this weekend unless anyone has any hesitations.

Maybe wait until the external wiki has at least some level of content organisation? It seems pretty bare at the moment, unless there's something I'm missing? The current wiki home page has at least a good starting point: https://github.com/threedesigns/printNC/wiki
Whereas the new one has "test test" https://wiki.printnc.info/en/home

Also:
Drivers
Drivers!
asdasdasdasd

Everything is already in the wiki, the pages just need to be added to the navigation bar.. should take me a few minutes

File contents are now fully migrated


Fix googlenet and inception docstring for transform_input parameter

Fixes https://github.com/pytorch/vision/issues/4136
Default isn't always False, it depends on pretrained

comment on https://github.com/pytorch/vision/issues/4136

You're right, thanks, I updated the comment to be Default: True if ``pretrained=True``, else False

Sorry, I messed up the confict merge - I'll merge https://github.com/pytorch/vision/pull/5089 with the same changes instead instead


Confusing error for multiple ellipses

The program in this gist gives the error "unrecognized meta-variable in language L  in: ..."
https://gist.github.com/schuster/2ce5886e5f1c8c31558e
I assume Nanopass must only support at most one ellipsis per list. If that's the case, can we get a better error message here?

Yup, your assumption is correct. You can only have one ellipses per level in Nanopass. I will fix the error message to say that.

0f233ab03554f331b8ed0c2c1e639baed0cdbd87 fixes this issue.
Thanks again for submitting it.


Fixed minor typos in the "Understanding Optics" section

In the section "Prism" section some references to "product type" were left behind, when "sum type" is the relevant one.

This is most definitely a duplication of pull request #54.


Feature - API Embed

Meetups, grants, translations, and some Contributor Teams Use air table for applications. It would be super snazzy to have embed form.
Beyond just form embed, It would be nice to explore "write to an air table database." ( I think they're called blocks) The example were thinking of for governance communicationsIs to collect emails In an air table for eventual email distribution. We need to keep special consideration for privacy. And we should look at this one next week to decide before implementing anything more advanced than just forms (at least).

Just to clarify, Airtable is not the set platform, but likely. Would be good to know if we have to be platform specific for embeds (Google Forms,Airtable, etc)

@twblack88 I spoke about this with @amy-jung on Friday, but to ensure parts of our conversation have been documented:
I need to know how we plan to use this feature. Would we prefer we build individual components that support the unique features of iframe embed for Airtable, Google Forms ect.
ie. We'd have components like <GoogleForm/> and <Airtable/> in MDX with props that can be passed to specific data we'd use to identify individual forms (ie. urls to the embeds for example).
OR
Do we want to have widespread support for iframe embeds? We currently support youtube playlists with the Video component in in this way, but we could expect a component in MDX like <Embed/> where the props you write are what would go directly on the iframe.
There are benefits and detriments to each implementation, but for the sake of doing it once and leaving the more advanced features in your hands I would vote for the latter <Embed/> spec.

As the resident legolas, I would 🗳  for option 2. Robust embedding would allow us to leverage notion as they release their API in the future, along with a myriad of other services (Airtable, google etc.)
The other consideration is: robust embeds would allow us to tinker on props well into the future. Giving a robust set of data to write, test, break, and fix once the portal launches.

I also vote for Option 2 as widespread support for iframe embeds would be highly desired for many reasons!

Sounds like a plan then team. We can put this in action.
Would it be good to test with Airtable and Google forms as the initial test cases for this component?


Lazy load images

Hi, and thank you for this excellent project.
Would it be possible to modify it to lazy load images, and if so how would you go about it? I'm ready to give it a try and open a PR.
In one of my projects I'm using it to insert emojis, but on page load my 1,000+ emojis are all loaded one by one, which is of course not ideal.

how are you currently loading emojis? I'm using emojis too but I'm initializing the plugin on focus event of the input/textarea and using emojify plugin.
Anyway, feel free to submit your PR and I'll have a look. :)

I was using code that looks like this :
    map: function (emoji) {
      if (emoji && emoji.hasOwnProperty('code') && emoji.hasOwnProperty('img')) {
        return {
          value: emoji.code,
          text: ' :'+emoji.code+''
        };
      }
    },

And it tried to download them all at once on page load.
I change my code to make the onShow and onLookup populate the src field, thus loading emojis on demand instead of on page load.


stripped StyleSheet react360.js

stripped StyleSheet and added styles direct on the View and Text components on the react360.js file.

See https://github.com/leachim6/hello-world/pull/772


deps: Updated linter and gonum

Description of Changes

Updated revive to 1.2.0 and fixed issues
Updated gonum to 0.11.0 to allow go1.18 compatbility.

Please check that the PR fulfills these requirements

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] CI passes

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Allow direct link to any form field so that providers can have direct links with some values pre-filled

Right now, the search form is required to be fully filled out such that trying to pass just a partial set of params is invisibly returning an error and resetting the form. For example:
https://ccsearch.creativecommons.org/?search=cat&search_fields=title&search_fields=tags&providers=500px
Shows only 500px results, as expected, but omitting the search query resets the form:
https://ccsearch.creativecommons.org/?search_fields=title&search_fields=tags&providers=500px
If "search" is blank, we should still allow the form to be preset by the query params.

This now works as it should.


angular2-modal dynamic component view

IMPORTANT: Please provide a sample using:

I'm submitting a ...
[x ] bug report
[ ] feature request
[ ] question about the decisions made in the repository

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
Giving a component in the .component() function of angular2-modal alert() throws error . I am following this syntax
this.modal.alert()
.component(ChartComponent)
.size('lg')
.showClose(true)
.open();

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via
https://plnkr.co or similar (you can use one of the templates above as a starting point).

What is the expected behavior?
component should be reflected on the modal

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Angular version: 4.0.0
Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

@ansuman273
Currently this is the way to render a custom component.
However, I also noticed:

The existence of the component default property as part of the FluentAssign. Although it exists, it does throw an error because of type mismatch, as you mentioned. Implementation seems off.
it does work (partially), even though it's types do not match. It renders the custom component, but lacks the context (which, of course, is necessary).

@shlomiassaf

What is the intention with / roadmap regarding the .component() ? Will this be an easier way to implement a custom component?
If the .component() is not being developed in the near future; how can I use the fluent assign method (for convenience) of, for instance, size/isblocking/ etc. ?


Define "lastmod" on "queueURL"

Do you want to request a feature or report a bug?
I would like to know if it's possible (or if it can be implemented) to specify the lastmod property on queueURL.
What is the current behavior?
Currently queueURL only adds the URL without specifying a lastmod date different from the global one.
What is the expected behavior?
Ideally, when queuing a URL you could pass the datemod as a parameter, such as:
                generator.queueURL(url, datemod);

Not sure if queueURL is the right place to specify lastmod. It's just a hint to what the crawler should look for and the sitemap is generated afterwards.
Maybe we could add some kind of map to map lastmod dates to URLs.

Keep in mind that not all sites support/provide lastmod  data.

I'm fully aware of this. Anyway there is no easy way to provide data like this for a crawler.

Generally I'm open for a good solution to provide lastmod data, but your proposed one doesn't seem like a good fit. If you have a better idea please reopen or create a new issue.
Closing this issues.


Multi selected

Hi
I use Viager.
I have made a table for the city and a table for the provinces, which are connected
I also made a column for products. I plan to make a product available in several cities. Now I can make a product available in a city. But I could not do anything to be available in several cities. please guide me.

Please read the very first sentence of the issue template.


After PR #1808: Segfault when loading RViz config with RobotModel display using non-default parameter name

Your environment

OS Version: Ubuntu 20.04
ROS Distro: Noetic
RViz, Qt, OGRE, OpenGl version as printed by rviz:

[ INFO] [1715256147.602104886] [ros.rviz]: rviz version 1.14.22
[ INFO] [1715256147.602171601] [ros.rviz]: compiled against Qt version 5.12.8
[ INFO] [1715256147.602181139] [ros.rviz]: compiled against OGRE version 1.9.0 (Ghadamon)
[ INFO] [1715256147.615263427] [ros.rviz]: Forcing OpenGl version 0.
[ INFO] [1715256147.923097661] [ros.rviz]: Stereo is NOT SUPPORTED
[ INFO] [1715256147.923240298] [ros.rviz]: OpenGL device: AMD Radeon Graphics (radeonsi, renoir, LLVM 15.0.7, DRM 3.57, 6.8.0-060800-generic)
[ INFO] [1715256147.923289680] [ros.rviz]: OpenGl version: 4,6 (GLSL 4,6) limited to GLSL 1.4 on Mesa system.

If source build, which git commit? Tag 1.14.22
System locale, i.e. the output of echo "$LANG $LC_NUMERIC": cs_CZ.UTF-8
Before reporting a rendering issue, try running RViz with LANG=C rviz! - no effect

Description
Commit df72fce669683e01a67156bec3f847f6449b30a7 from #1808 broke loading rviz with a config that contains RobotModel display configured for non-default parameter name (e.g. robot_description2). This only happens when robot_description also contains something, which is very weird, because I'd say that if the config only contains RobotModel with robot_description2, it should not touch robot_description at all. But it does and it leads to segfault.
Repro
a.urdf:
<?xml version="1.0" ?>
<robot name="robot1">
  <link name="base" />
</robot>

c.urdf:
<?xml version="1.0" ?>
<robot name="robot2">
  <link name="base" />
  <joint name="base_to_base_inertia" type="fixed">
    <parent link="base"/>
    <child link="base_inertia"/>
  </joint>
  <link name="base_inertia" />
</robot>

b.rviz:
Panels:
  - Class: rviz/Displays
    Name: Displays
Visualization Manager:
  Class: ""
  Displays:
    - Alpha: 1
      Class: rviz/RobotModel
      Collision Enabled: false
      Enabled: true
      Links:
        All Links Enabled: true
        Expand Joint Details: false
        Expand Link Details: false
        Expand Tree: false
        Link Tree Style: Links in Alphabetic Order
      Name: RobotModel
      Robot Description: robot_description2
      TF Prefix: ""
      Update Interval: 0
      Value: true
      Visual Enabled: true
  Enabled: true
  Name: root
  Value: true
Window Geometry:
  QMainWindow State: 000000ff00000000fd000000040000000000000156000002b0fc0200000008fb0000001200530065006c0065006300740069006f006e00000001e10000009b0000005c00fffffffb0000001e0054006f006f006c002000500072006f007000650072007400690065007302000001ed000001df00000185000000a3fb000000120056006900650077007300200054006f006f02000001df000002110000018500000122fb000000200054006f006f006c002000500072006f0070006500720074006900650073003203000002880000011d000002210000017afb000000100044006900730070006c006100790073010000003d000002b0000000c900fffffffb0000002000730065006c0065006300740069006f006e00200062007500660066006500720200000138000000aa0000023a00000294fb00000014005700690064006500530074006500720065006f02000000e6000000d2000003ee0000030bfb0000000c004b0069006e0065006300740200000186000001060000030c00000261000000010000010f000002c4fc0200000003fb0000001e0054006f006f006c002000500072006f00700065007200740069006500730100000041000000780000000000000000fb0000000a005600690065007700730000000028000002c4000000a400fffffffb0000001200530065006c0065006300740069006f006e010000025a000000b200000000000000000000000200000490000000a9fc0100000001fb0000000a00560069006500770073030000004e00000080000002e10000019700000003000004b00000003efc0100000002fb0000000800540069006d00650100000000000004b0000003bc00fffffffb0000000800540069006d0065010000000000000450000000000000000000000354000002b000000004000000040000000800000008fc0000000100000002000000010000000a0054006f006f006c00730100000000ffffffff0000000000000000

bug.launch:
<launch>
    <arg name="bug" default="true" />
    <param name="robot_description" textfile="$(dirname)/a.urdf" if="$(arg bug)" />
    <param name="robot_description2" textfile="$(dirname)/c.urdf" />
    <node name="rviz" pkg="rviz" type="rviz" args="-d $(dirname)/b.rviz" />
</launch>

When you launch roslaunch ./bug.launch, rviz 1.14.22 segfaults. When you launch roslaunch ./bug.launch bug:=false, it launches correctly (that corresponds to not setting robot_description). Be sure to let roslaunch create its own rosmaster when doing these tests.
GDB backtrace
Thread 1 "rviz" received signal SIGSEGV, Segmentation fault.
0x00007ffff6eb1a2e in QMetaObject::activate(QObject*, int, int, void**) () from /lib/x86_64-linux-gnu/libQt5Core.so.5
(gdb) bt
#0  0x00007ffff6eb1a2e in QMetaObject::activate(QObject*, int, int, void**) () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#1  0x00007ffff7d0e9ca in rviz::PropertyTreeModel::propertyHiddenChanged(rviz::Property const*) (this=0x0, _t1=0x555556cea890)
    at /tmp/ws/build/rviz/src/rviz/rviz_autogen/BW4I5L4EMK/moc_property_tree_model.cpp:169
#2  0x00007ffff7def741 in rviz::PropertyTreeModel::emitPropertyHiddenChanged(rviz::Property const*) (this=0x0, property=0x555556cea890) at /tmp/ws/src/rviz/src/rviz/properties/property_tree_model.h:137
#3  0x00007ffff7dee4fb in rviz::Property::<lambda()>::operator()(void) const (__closure=0x555556c20f40) at /tmp/ws/src/rviz/src/rviz/properties/property.cpp:401
#4  0x00007ffff7def5f4 in QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, rviz::Property::setModel(rviz::PropertyTreeModel*)::<lambda()> >::call(rviz::Property::<lambda()> &, void **)
    (f=..., arg=0x7fffffffc8d0) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qobjectdefs_impl.h:146
#5  0x00007ffff7def5c6 in QtPrivate::Functor<rviz::Property::setModel(rviz::PropertyTreeModel*)::<lambda()>, 0>::call<QtPrivate::List<>, void>(rviz::Property::<lambda()> &, void *, void **)
    (f=..., arg=0x7fffffffc8d0) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qobjectdefs_impl.h:256
#6  0x00007ffff7def594 in QtPrivate::QFunctorSlotObject<rviz::Property::setModel(rviz::PropertyTreeModel*)::<lambda()>, 0, QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase *, QObject *, void **, bool *) (which=1, this_=0x555556c20f30, r=0x555556c28e30, a=0x7fffffffc8d0, ret=0x0) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qobjectdefs_impl.h:439
#7  0x00007ffff6ebf486 in  () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#8  0x00007ffff6eb2bc5 in QObject::event(QEvent*) () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#9  0x00007ffff736aa66 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () at /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#10 0x00007ffff73740f0 in QApplication::notify(QObject*, QEvent*) () at /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#11 0x00007ffff6e8680a in QCoreApplication::notifyInternal2(QObject*, QEvent*) () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#12 0x00007ffff6edd780 in QTimerInfoList::activateTimers() () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#13 0x00007ffff6ede06c in  () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#14 0x00007ffff414217d in g_main_context_dispatch () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#15 0x00007ffff4142400 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#16 0x00007ffff41424a3 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#17 0x00007ffff6ede4b4 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#18 0x00007ffff7e65e99 in rviz::VisualizationFrame::initialize(QString const&) (this=0x5555557f3800, display_config_file=...) at /tmp/ws/src/rviz/src/rviz/visualization_frame.cpp:367
#19 0x00007ffff7e85723 in rviz::VisualizerApp::init(int, char**) (this=0x7fffffffd3e0, argc=5, argv=0x7fffffffd568) at /tmp/ws/src/rviz/src/rviz/visualizer_app.cpp:213
#20 0x000055555555e6a3 in main(int, char**) (argc=5, argv=0x7fffffffd568) at /tmp/ws/src/rviz/src/rviz/main.cpp:39

Analysis
Git blame pointed at commit df72fce669683e01a67156bec3f847f6449b30a7. When I revert it, the bug does not manifest.
If I start an empty RViz and add the RobotModel display to it, no segfaults happen. But when I save it and rerun RViz with this config, and robot_description is set, the segfault happens.

This issue has been mentioned on ROS Discourse. There might be relevant details there:
https://discourse.ros.org/t/preparing-for-noetic-sync-2024-05-09/37602/2

Fixed via e0ec5f6b5d4b06042c51501c20fb6f6a1c5d4f0d

Oh, great, thanks a lot for the quick action, @rhaschke ! I really didn't know what the culprit could be...

Thanks a lot, Martin, for your excellent bug report. That helped a lot to pinpoint the issue quickly.

I am still getting this issue (or at least very similar) on latest noetic-devel (2db2c5394a4f1fcf5fecfb8d0952d4f913c04aee).
Renaming a rviz/RobotModel display and relaunching causes RViz to crash. Reverting to version 1.14.20 makes it work again with the issue being introduced in 1.14.21. I cannot reproduce with the example provided by @peci1 so this might be a different issue. I will try to create a minimally reproducible example and post here or create a new issue but my guess is that I've found an edge case that's not solved by @rhaschke's fix.

@Achllle: I cannot reproduce your issue. As you complain about renaming the display (from RobotModel) and not about renaming the topic, I guess that's a different issue. Please open a new issue report and provide a detailed description how to reproduce the error. If you have an rviz config reproducing it, please upload that file.


V8.0.0

Description

Added 5 new themes based on various new characters!

High School DxD:

Rias Gremory (Dark Theme)

Sword Art Online:

Yuuki Asuna (Light Theme)

Lucky Star:

Izumi Konata (Light Theme/2 Stickers)

KonoSuba:

Darkness (Light/Dark Theme)

New users will be given Rem as their first theme now.

Motivation and Context

I don't know when to stop. I have a problem.
I am also not going to release this just yet. I need to spend a while driving these themes. I also plan on re-doing all of the syntax highlighting for all the themes. So expect a public 8.X.X release and not 8.0.0.

I have a canary release channel that you can set up to get 8.X.X before it is public!
How Has This Been Tested?

Well It works on my dev box for right now. More to come on that...
Screenshots (if appropriate):
Here is a small preview of what's to come :) (Probably not the final results)
Sword Art Online: Yuuki Asuna

KonoSuba: Darkness

KonoSuba: Darkness

High School DxD: Rias Gremory

Lucky Star: Izumi Konata (Secondary Sticker)

Types of changes

[X] New feature (non-breaking change which adds functionality)

Checklist:

[X] My code follows the code style of this project (./gradlew check passes clean).

Tip: If you have lint issues just run ./gradlew :ktlintMainSourceSetFormat.

[X] I updated the version.
[X] I updated the changelog with the new functionality.

[ ] Works on Windows

[ ] Works on MacOS


Allow multiple Print Areas per worksheet

I would like to add the ability to save multiple print areas per worksheet to exceljs.
As seen in this Microsoft Excel documentation, excel sheets can have multiple print areas, but the pageSetup of a sheet currently only accepts a single print area. Or rather, printArea accepts a string, but the workbook-xform assumes that this string has only a single print area and parses it accordingly.
I see two straightforward solutions -

allow printArea to contain multiple print areas with a separator. Something like printArea:= B2:C5&&B7:C9 would specify two rectangles to print.
add an additional property printAreas that contains an array of print area strings.

I think the first one is better. A separator isn't super clean, but it's better than duplicating the property and is backwards compatible. I'll see if I can get an example PR up sometime soon.

#1042


preprocess fails on sample data

python preprocess.py --srcfile data/src-train.txt --targetfile data/targ-train.txt
fails with the following output:
Number of sentences in training: 10000
Traceback (most recent call last):
File "preprocess.py", line 343, in
sys.exit(main(sys.argv[1:]))
File "preprocess.py", line 340, in main
get_data(args)
File "preprocess.py", line 257, in get_data
args.seqlength, max_word_l, args.chars)
File "preprocess.py", line 79, in make_vocab
enumerate(itertools.izip(open(srcfile,'r'), open(targetfile,'r'))):
TypeError: coercing to Unicode: need string or buffer, NoneType found

hi, it seems like you are not specificing the srcvalfile and targetvalfiles?

Yoon, let's have this fail in a nicer way. You should be able to add required=True to those args.

yep, made those changes--closing now


Moved some components out of internal

This commit moves two processors and an error helper outside the
internal package so they can be imported and used by OT service
derivatives.

Codecov Report

Merging #191 into master will not change coverage.
The diff coverage is 89.47%.

@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   72.74%   72.74%
=======================================
  Files         104      105    +1
  Lines        6094     6094
=======================================
  Hits         4433     4433
  Misses       1435     1435
  Partials      226      226

Impacted Files
Coverage Δ

processor/nodebatcher/options.go
100% <ø> (ø)

processor/queued/queued_processor.go
47.61% <ø> (ø)

processor/nodebatcher/metrics.go
0% <ø> (ø)

processor/queued/options.go
60.52% <ø> (ø)

service/telemetry.go
72.97% <ø> (ø)
:arrow_up:

processor/nodebatcher/factory.go
95.12% <ø> (ø)

processor/nodebatcher/node_batcher.go
93.83% <ø> (ø)

processor/queued/factory.go
90.9% <ø> (ø)

internal/internal.go
71.42% <ø> (-16.81%)
:arrow_down:

receiver/vmmetricsreceiver/vm_metrics_collector.go
13.86% <0%> (ø)
:arrow_up:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9233b6c...cd1e28f. Read the comment docs.

I don't have any other ideas either. I took the oterr package name idea from awserr https://docs.aws.amazon.com/sdk-for-go/api/aws/awserr/

We can rename later if a good idea comes to mind...


Cluster: keys(*)  just get one node keys

I want to get all keys from redis cluster,so i do this:
keysCmd := redisClusterClient.Keys("*")
fmt.Println(len(keysCmd.Val()))
but I found,this just get one node keys.

That is how Redis Cluster works - it returns keys for the node. To get all keys you should use ForEachMaster and https://godoc.org/github.com/go-redis/redis#example-ScanIterator to iterate over keys.

oh!


Design Query

SQL Operations Studio Version: 0.26.6

I would like to seen the option Design Query in Editor like in SSMS or Access.
It's a powerfull tool for beginners.
Tks

Not only a powerful tool for beginners, when designing complex queries with multiple sub queries or complex joins it is an extremely handy tool for all users.

@ric3ca @WouterLeenders We're investigating adding this capability to Azure Data Studio. I'm looking to learn more about your top scenarios.
a. What types of statements do you use the query designer for - SELECT, INSERT, UPDATE, DELETE?
b. What are your most-used features of the query designer in SSMS/Access - joining, sorting, filtering?
c. How do you decide if the query you've created will perform well?


chore(deps): update react-select from 3.0.4 to 4.3.0

Update react-select library

:rocket: PR was released in v1.19.7 :rocket:


Optimizing the permission tree loading for the first time.

Currently, when the identity server starts and the user login and the load the permissions for a role it loads the permissions from the database. We have analyzed the correlation log and found that there are nearly 1500 queries running but none of the queries didn't take more than 10ms. However, it is possible to observe a slowness with the number of queries executing. This actually depends on the database performance. We need to investigate for the possibilities for improvements.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Convert model to rk3288 encountered problems

When I converted the model to the RK3288 platform, the prediction ran into problems and all the images were predicted as spoofing faces. My conversion process is pth - >onnx->rknn, and the onnx model prediction has been verified to be correct. Please remind me of the points that need to be paid attention to during the conversion process. I look forward to hearing from you. Thank you.

Resolved, look at the author's transform.to_tensor() function and see that 255 is not changed to 1. So, the scale does not need to be set to 255

The output from the converted onnx model is vastly different from that of the original model. can you suggest how you did the conversion correctly


Added preloading configuration and tree parsing + refactor Doctor file

Fixes #911 by adding preloading configuration and tree parsing + refactor Doctor file
Test Plan

How do we know the code works?

Running command firebase test android|ios doctor or flank android|ios doctor will show issue when cannot parse
.yml configuration (invalid example in root task).
Previously doctor validates only basic .yml parsing, now it pre-load configuration and validate tree to catch more errors
Checklist

[x] Documented
[x] Unit tested
[x] release_notes.md updated

This is awesome! Great idea to preload the entire config.


Update storage-premium-storage-preview-portal.md

XIO GA

Hi @siriusk-MSFT, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

This looks good to me.


Database dependency injection in planner

While working on https://github.com/penumbra-zone/web/pull/1426, it became evident that the state of testing in the wasm code is quite rough given the dependency on the indexeddb global.
This PR adds a database interface that storage.rs gets passed upon initialization. This allows us to use a mock database that can be used in tests, making our goals around test coverage much more attainable.

reviewing the PR now 👍


Crash on Firefox

The module seems to crash on Firefox lately. Probably an update to the browser? I've a large map 15k x 10k and it seems to crash when it wants to load the fog image (or when I try to move around). The console doesn't show any errors before it.
Failed to allocate internal command buffer.
WebGL context was lost.
Failed to create WebGL context: SendPWebGLConstructor failed
Failed to allocate internal command buffer.
WebGL context was lost.
Failed to allocate internal command buffer.
WebGL context was lost.

This is usually because your GPU is struggling with the texture size involved in rendering the fog. The fog uses an image texture and 15kx10k is a fairly large map. With the buffer region the 15k dimension may exceed 16k which is a common limitation point on GPUs. Does it only happen on large maps? If so you may need to scale your map down somewhat in an image editor.
Simplefog does attempt to scale down the fog resolution when approaching a limit, but it's not the smartest about it and sometimes will still fail. I may be able to improve this in a future version.

It started to happen suddenly, worked before and it works normally on Chrome. I got the crashes too and I've got a GTX3090.

Probably not much we can do with this, so closing, but will keep it on our list to investigate.