display property in docs not working

The docs describe a display property to make the color pickers work like a popup. Adding this property as described here http://casesandberg.github.io/react-color/#api-display didn't work for me. When I looked through the code, I could not find anywhere where this display property gets used. Are the docs out of date or am I missing something?

Experienced the same issue here. I rollbacked to the 1.3.0 version and it worked as expected.

Hey, thanks for react-color. It's really nice.
Regarding the issue: IMO this component should not concern itself with display and position. React have booth built-in and third party solutions for that. E.g. one can easily wrap color picker in a div and set it's style (display, postiion) depending on state / props / whatever. Even better one can render the picker conditionally.
What I mean is that maybe instead of making display, position and positionCSS props work again, they should be removed from docs and the popup example should be updated.
What do you think of that?

@lzrski I see one issue for color-picker not concerning itself with display and position; it's make difficult to close the color picker when you click outside it (the behavior that I use with 1.3.x).

@slestang that's a concern of a modal component. Try https://github.com/reactjs/react-modal for example. You can put react-color component inside modal to get the functionality you are describing. To close modal when user picked a color just close it inside onChangeComplete handler of react-color.

Fair to say there are arguments for both sides of this debate. Regardless, I'd suggest removing things from the docs that aren't supported and/or contain incomplete sample code.

Does anyone know why version 2.0, which is the release version, lost a bunch of features?  What's the status of the project and the 2.X version?

If the features are removed it only makes sense to increment major version: http://semver.org/#spec-item-8.

@lzrski: I agree, whether or not it's the right thing to keep this feature, it should not be in the docs and version should change. I ended up forking the repo and adding in the feature myself for it not to break my implementation.

Sorry everyone, I just found out that when I released 2.0.0 I forgot the push the new documentation to the github pages. It has been updated now and can be found here: http://casesandberg.github.io/react-color/
TL;DR Display prop has been deprecated, either use state and onClick to show and hide it or use another component


application-load-balanced-fargate-service: No Fargate configuration exists for given values: 512 CPU , 512 memory

Hi,
While trying to deploy the application-load-balanced-fargate-service examples, CDK fails with the following error:
13:47:44 | CREATE_FAILED        | AWS::ECS::TaskDefinition                  | amazon-ecs-sample/TaskDef
Resource handler returned message: "Invalid request provided: Create TaskDefinition: No Fargate configuration exists for given values: 512 CPU
, 512 memory. See the Amazon ECS documentation for the valid values. (Service: AmazonECS; Status Code: 400; Error Code: ClientException; Reque

Created a #2 to fix this issue of memoryLimitMiB defaulting to 512. This is not a supported task configuration in Fargate (at least anymore).

Thanks for the PR ;)


No module named 'scipy._lib.six'

Hi, I tried to run the demo like
import deeprobust.image.netmodels.train_model as trainmodel
trainmodel.train('CNN', 'MNIST', 'cuda', 20)
on the Readme but it just showed the following error report:
Traceback (most recent call last):
File "/home/ubuntu/codew/untitled0.py", line 9, in
import deeprobust.image.netmodels.train_model as trainmodel
File "/home/ubuntu/anaconda3/lib/python3.8/site-packages/deeprobust/image/init.py", line 3, in
from deeprobust.image import attack
File "/home/ubuntu/anaconda3/lib/python3.8/site-packages/deeprobust/image/attack/init.py", line 9, in
from deeprobust.image.attack import cw
File "/home/ubuntu/anaconda3/lib/python3.8/site-packages/deeprobust/image/attack/cw.py", line 9, in
from deeprobust.image.optimizer import AdamOptimizer
File "/home/ubuntu/anaconda3/lib/python3.8/site-packages/deeprobust/image/optimizer.py", line 19, in
from scipy._lib.six import xrange, string_types
ModuleNotFoundError: No module named 'scipy._lib.six'
The current version of my Scipy is 1.5.2, and it seems that the subpackage "scipy._lib.six"
has been removed from the newest Scipy, so I wanna know how to solve the problem.
Many Thx :)

Thanks for posting this question!
I've update the code and replaced the functions in scipy._lib.six with the current ones.
Welcome to try again.


New map: Enne-san Board 37

Can you please take the time to complete this form: https://forms.gle/T3qqNMqPAbHut3pk7


Open external links in web browser by default

Description
This PR slightly changes the behavior when clicking links. Now new-window events with dispositions background-tab and foreground-tab will open links in the default browser while those with new-window actually cause a new ferdi popup to open. So left clicking an external link will open in the browser by default.
I tested these changes on Windows 10 20H2 with the Gmail, Telegram, WhatsApp and Discord services.
Motivation and Context
After reading through the referenced issues in #1474 I feel like most people expect clicking an external link to open in the default web browser rather than a ferdi popup window.
If this is not the intended behavior feel free to close this PR.
Also if there are different opinions regarding this it might be worth thinking about adding a setting to toggle the behavior.
Checklist:

[x] My pull request is properly named
[x] The changes respect the code style of the project ($ npm run lint)
[x] I tested/previewed my changes locally

thanks for the PR @stnkl - Let me review this quickly! 👍

Maybe I'm in the weird minority, but Ferdi trying to open links in the external browser annoys me a lot (specifically because I run Ferdi in a sandbox where there's no external browser at all, so just nothing happens). 😃
Anyways, feel free to go on and merge this. When I'll have some free time, I think I'll go ahead and add a setting to open external links in 1. in the external browser 2. inside Ferdi 3. not open them at all, but copy the URL to the clipboard (the third one useful is heavily sandboxed environments).

Thanks @kris7t - I agree that this might reduce the number of asks - so, lets merge this.
And we can do the preferences bit next.


Coal Spawn Rate Too Low

Description

I've seen rounds where salv still hasn't found any coal nearly an hour into the shift, leaving them with piles of unprocessed ore.

Weird, when I was testing, I was getting gobs of it. Granted it's rng. Never hurts to test some more though.


How to transmit data through Uart with a range of above 300 bytes to 1024 bytes through uart in esp-idf 3.3 (IDFGH-2739)

I am unable to transfer data above 120bytes through uart through esp-idf using esp-wroom 32 module .
please suggest a solution or any code reference to send large data through uart using esp

Hi, @manojsai17
int uart_write_bytes(uart_port_t uart_num, const char* src, size_t size)  can send the data of the specified byte. Under what circumstances can you not send more than 120 bytes of data? Can you provide your test code?
thanks !!

Hi,
This issue is the same as the other two:
https://github.com/espressif/esp-idf/issues/4820
https://github.com/espressif/esp-idf/issues/4719
please close this one, we will reply you here: https://github.com/espressif/esp-idf/issues/4820
thanks !!

@koobest Thanks for notes. @manojsai17 Will close this one. Thanks.


CORE-15350 Fix check for locally-hosted identities

Changes the check for locally-hosted identities to include session key matching, to guard against scenarios in which a duplicate holding identity from another cluster attempts to register, but the MGM's decline message is instead routed to a matching holding identity which is hosted locally.
Also changes the creation of locally-hosted identities in static networks to use the actual session key from MemberInfo, instead of a dummy key.
E2E test:
https://github.com/corda/corda-e2e-tests/pull/188
Manual test:

Onboarded MGM and member ("O=Alice, L=London, C=GB") on cluster-A
Create vnode with same name "O=Alice, L=London, C=GB" on cluster-B, and attempt to register with MGM (cluster-A)

Cluster-B Alice receives declined message as expected.

Lookup performed by cluster-A Alice:

Multi-cluster pipeline with new test added in https://github.com/corda/corda-e2e-tests/pull/188: https://ci02.dev.r3.com/blue/organizations/jenkins/Corda5%2Fcorda-e2e-tests-multi-cluster-tests/detail/PR-188/4/pipeline


Support configuring multiple event endpoints, mappings, and sinks

At present we support a single event endpoint, with a single mapping, and optional Kafka & HDFS sinks.
In order to support multiple types of endpoint, we plan to change the way configuration works. This will, unfortunately, be a breaking change: existing configurations will need to be updated. The benefit will be that this change enables future work.
The changes are that:

Multiple event sources can be defined. Each source will be named. They will remain on the same HTTP listener, but at runtime will be distinguished by path.
Multiple sinks can be defined. Each sink will be named, and either HDFS or Kafka.
Multiple mappings can be defined. Each mapping has a single groovy definition and will produce Avro records that conform to the same schema.
Each mapping can be linked to multiple event sources, and multiple event sinks.
All mappings that produce records for a sink must use the same schema.

Some things will remain globally configured:

Kafka producer properties.
HDFS client properties.
Settings for the user-agent parsing.
HTTP interface/port settings.
Various buffer sizes and thread counts.

These changes are a prerequisite for supporting non-browser events.

This was implemented and merged as part of #115.


Is Description Data Set Available to Research Community?

Hi,
May I please if the descriptions data set you have used for this project is available for research community for use of research and study work? If you can make it available we will be really grateful.
Thank you in advance!

@reedscot ?

Here https://drive.google.com/file/d/0B0ywwgffWnLLcms2WWJQRFNSWXM/view


RFC: Array operations: Avoid duplicating arguments with (stop := as.size)

The issue
I have just stumbed over the fact that many Array operations (foldl etc.) have a parameter
stop with a default argument (stop := as.size), and this duplicates the array argument, which may be large:
def foo : Bool := Array.any #[1,2,3,4] (fun _ => true)
#print foo

prints
def foo : Bool :=
Array.any #[1, 2, 3, 4] (fun x => true) 0 (Array.size #[1, 2, 3, 4])

This duplication also shows up in other places, e.g. in well-founded recursive definitions (which, unsurprisingly, is how I noticed this) a recursive call in the array will cause the tactic to be invoked multiple times:
def rec : Nat → Bool
 | 0 => true
 | n+1 =>  Array.any #[rec n, rec n, rec n, rec n] id
decreasing_by trace "Tactic is run"; decreasing_tactic -- called 8 times

Worse, nesting these innocent looking funcitons now lead to a combinatoric explosion:
def rec2 : Nat → Bool
 | 0 => true
 | n+1 =>
    Array.any #[
      Array.any #[rec2 n, rec2 n, rec2 n, rec2 n] id,
      Array.any #[rec2 n, rec2 n, rec2 n, rec2 n] id,
      Array.any #[rec2 n, rec2 n, rec2 n, rec2 n] id,
      Array.any #[rec2 n, rec2 n, rec2 n, rec2 n] id
    ] id
decreasing_by trace "Tactic is run"; decreasing_tactic -- called 64 times

Proposal
A possible fix is to update all these functions as follows:
Change
unsafe def foldlMUnsafe {α : Type u} {β : Type v} {m : Type v → Type w} [Monad m] (f : β → α → m β) (init : β) (as : Array α) (start := 0) (stop := as.size) : m β :=

to
unsafe def foldlMUnsafe {α : Type u} {β : Type v} {m : Type v → Type w} [Monad m] (f : β → α → m β) (init : β) (as : Array α) (start := 0) (stop := Option as.size) : m β :=
  let stop := stop.getD as.size

Many of the ~19 affected functions just pass stop on, so they only change the type, not the implementation.
Alternative
The only alternative I see is to change how optional arguments are elaborated, and if they mention earlier parameters, that parameter is let-bound instead of duplicated.
I do not know if there are users who actually rely on default paramters being able to refer not just to the value of an earlier argument, but actually need the argument syntax to be replicated.
Impact
Add :+1: to issues you consider important. If others benefit from the changes in this proposal being added, please ask them to add :+1: to it.

This is borderline between a RFC (because the current code works as specified) and a bug (because the current code shows some clearly bad behaviour).

Oh, that is an interesting issue resulting from term duplication. I assume there are many other ways to trigger it, for example dependent arguments. Many components of Lean, but not all, can deal with duplication well by caching by expression hash. Not sure whether deduplication in the derecursifier would be a realistic/easier solution here.

I see, so you are saying that such effects are simply unavoidable, all compiler code should be prepared to deal with it, and changing the Array signatures would be undesirable here?

Doesn't seem to be too hard actually…

Ah, it was only meant as an vague suggestion at this point, I'm still not familiar enough with the component to evaluate it from all angles. We do have to be careful about not deduplicating e.g. across different local contexts which your PR failure might point at but I haven't taken a look at the code.

But I think you are right that duplication is common place and passes should be able to cope with then.
We can reopen this if the array function arguments cause more trouble elsewhere.

These function arguments do in fact cause trouble, I've thought about opening a similar RFC myself. The problem is that even though 95% of the time you don't want to pass non-default values for the arguments, you can't quite pretend they don't exist in simp lemmas and the like because the as.size input can be simplified differently from as, after which a lemma which only works for the default values no longer applies. This would be solved by simply having an extra wrapper function where Array.foldl has no extra arguments but calls Array.foldl' which has the extra arguments.

Ok, reopening, as there may be something to be done here.
I started a patch with changes like
-def forM {α : Type u} {m : Type v → Type w} [Monad m] (f : α → m PUnit) (as : Array α) (start := 0) (stop := as.size) : m PUnit :=
+def forM {α : Type u} {m : Type v → Type w} [Monad m] (f : α → m PUnit) (as : Array α) (start := 0)
+    (stop : Option Nat := none) : m PUnit :=

Would this, but without having separate functions, already help with the simp problem you are describing?

@nomeata The additional function seems better than an Option Nat because Option Nat introduces potential boxing overhead for the Nat.

I know, although I doubt it matters much relative to the cost of an array operation. Nevertheless the extra function has the benefit of a simpler signature - good for docs

Boxing can also be addressed through inlining, e.g. making foldl an inlinable wrapper for an internal function with the foldl' signature. Naming things with primes always seems like a confession of failure to me, not good for docs either.

Not to mention that foldl' is a well known function from Haskell and the distinction here is not at all related to that one.

@Kha, @digama0 In that case, it seems like the answer is just better naming. For example, foldRangel for the start/stop variant. Alternatively, the range-based ones could be moved to Subarray as auxiliary methods to implement the equivalent functions there and the standard Array ones could always us the full array.

Oh, I like that: Restricting these operations onto ranges is much more naturally expressed by just subarrays. This would simplify the Array operations a lot, and thanks to splice syntax,
xs[3:4].mapM …

is actually nicer than
xs.mapM (start := 3) (end := 4) …


@Key @ManyToOne(cascade = CascadeAction.NONE) being ignored?

Currently using 1.0.0-rc2.
@Entity
public interface Things extends Persistable {

    @Key
    @ManyToOne(cascade = CascadeAction.NONE)
    Bucket getBucket();

    @Key
    @Convert(MyEnumConverter.class)
    MyEnum getNumber();

// non-key fields

@Entity
public interface Bucket extends Persistable {

    @Key
    String getId();

// non-key fields

I have an "INSERT OR REPLACE" statement I run on the above Bucket table during onUpgrade(SQLiteDatabase db, int oldVersion, int newVersion).  To my surprise, after running that insert/replace statement, all the rows in the Things table were dropped.  When I opened up a backup of the SQLite database file in SQLiteSpy, it said that the create table statement contained this:
foreign key (bucket) references Bucket(id) on delete cascade on update cascade
It seems that CascadeAction.NONE is being ignored?

Hi the CascadeAction only controls the way the value is cascaded during entity operations. You should use @ForeignKey(delete = NO_ACTION) to control how the table schema is generated.

Thanks, by adding @ForeignKey(delete = ReferentialAction.NO_ACTION), I see in the result of a newly created database file foreign key (bucket) references Bucket (id) on delete no action on update cascade


Bug: Click events coordinates not happening where they should in retina screens

There seems to be an issue where the events don't propagate to the layer that one would expect.
It might be related to the coordinates and pixelRatio conversion in retina screens.
In the gif below, I'm clicking on the Click Me button which should increase the counter, but the events end up reaching the logo image:

@bryphe It might be an issue upstream in glfw, I wasn't sure so for now opening it here where the Bin example is 🙂

@bryphe Happy to take a look at this  👀  Any pointers to the potential cause of the issue are more than welcome of course! :)

I can confirm the coords from the mousemove event in Revery_Ui have half the range than the coords in the dimensions in Node.re.
It seems the calculation of layout is taking pixelRatio into account:
https://github.com/bryphe/revery/blob/d05c343e67c90b81fdc19da74fbf59b5e6a87536/src/UI/Layout.re#L36
While the event handler doesn't account for that ratio:
https://github.com/bryphe/revery/blob/d05c343e67c90b81fdc19da74fbf59b5e6a87536/src/UI/Revery_UI.re#L55-L64
One option could be to dispatch the mouse events at the adjusted size (i.e. multiplying by the ratio) but I don't think that's what users would expect. I'll try to modify the hitTest function to account for it.


Add server argument to specify custom PAA root certificate location

Add a new server argument --paa-root-cert-dir to allow a custom location for PAA root certificates. This allows to store them in a location which is preserved.

one lint issue


Form conversion is slow on form with lots of blank rows and columns

Software and hardware versions
pyxform v1.9
Problem description
UCL_Biomass_Plot_Form.xlsx when converted with pyxform-http (running in Docker on my computer) takes 27 seconds.
The form has lots of blank columns and rows and seems to be corrupt in some way.
I re-saved the form as XLSX in Excel 16.59 for Mac and that seems to have cleaned things up. Conversion speed went from to 27 seconds to .43 seconds.
Other information
https://forum.getodk.org/t/the-xlsform-conversion-service-could-not-be-contacted/37315/ is the forum thread with the original issue.
This sounds a lot like https://github.com/XLSForm/pyxform/pull/596, but I have confirmed I'm running 1.9. It's hard to verify directly with xls2xform because my computer is really fast :(
https://github.com/getodk/pyxform-http/blob/master/app/main.py#L40 is the specific pyxform-http function call.
My guess is that the form in question has the wrong dimensions. This script points to that.
from openpyxl import load_workbook
wb = load_workbook(filename='UCL_Biomass_Plot_Form.xlsx', read_only=True)
ws = wb['survey']
print(ws.calculate_dimension()) # A1:AMJ1048576
ws.reset_dimensions()
print(ws.calculate_dimension(force=True)) # A1:AMJ91

Maybe if we see a survey sheet with more than 50 columns (2x what we'd expect) or 5000 rows, we should reset the dimensions?
https://openpyxl.readthedocs.io/en/2.5.14/optimized.html#worksheet-dimensions

Hi. I am experiencing the same issue but with a form that does not have (I think) empty columns or rows, however, it has colors across columns.
The slow file (143,961 bytes): www.qlands.com/other_files/spanish_english_slow.xlsx
Converting to XML: 65.300415 seconds
Converting to JSON: 61.0054
The fast file without any colors (182,741 bytes): http://www.qlands.com/other_files/spanish_english_fast.xlsx
Converting to XML: 5.888324 seconds
Converting to JSON: 0.522944 seconds

I noticed I was getting OOM on my 1GB Central instance errors (forcing me to power cycle to get it working again) when uploading a form I created in Libre Office. @lognaturel thought that sounds related to this issue and suggested I try creating a fresh version in Google Docs to compare, and it indeed seems to work fine. This zip contains the Libre Office and Google Docs XLSX files for comparison.

@qlands were your files created with LibreOffice as well? So far all reports of misbehaving files seem to be related to LibreOffice.


S5 keys

Estimated activation with a 2min blocktime please review

Closing the request as we have updated the code base quite alot in the branch AYAv3.0 , which will be merged in master . The changes are present there already.


PFC reverting to FC

The program should not be overwriting PFCs, since it's the "best" lamp you can get, even though Infinitas doesn't support them.

Fixed in version 1.10


Using Github App to trigger CI on backport PRs

Signed-off-by: Vacha Shah<EMAIL_ADDRESS>Description
Using Github App token in the auto-backport workflow to trigger CI on auto-backport PRs since events created by secrets.GITHUB_TOKEN cannot trigger other workflows. Reference: https://github.community/t/triggering-a-new-workflow-from-another-workflow/16250
Issues Resolved
[List any issues this PR will resolve]
Check List

[X] Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #288 (0e1a587) into main (9c64451) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #288   +/-   ##
=========================================
  Coverage     83.38%   83.38%
  Complexity      885      885
=========================================
  Files           127      127
  Lines          3834     3834
  Branches        361      361
=========================================
  Hits           3197     3197
  Misses          475      475
  Partials        162      162

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c64451...0e1a587. Read the comment docs.


installed

sgpt fails upon fresh installation (no errors during installation)
$ sgpt "what are the colors of a rainbow"
Traceback (most recent call last):
  File "/Users/f.yalcin/.pyenv/versions/3.11.2/bin/sgpt", line 5, in <module>
    from sgpt import cli
  File "/Users/f.yalcin/.pyenv/versions/3.11.2/lib/python3.11/site-packages/sgpt/__init__.py", line 1, in <module>
    from .app import main as main
  File "/Users/f.yalcin/.pyenv/versions/3.11.2/lib/python3.11/site-packages/sgpt/app.py", line 15, in <module>
    from sgpt.client import OpenAIClient
  File "/Users/f.yalcin/.pyenv/versions/3.11.2/lib/python3.11/site-packages/sgpt/client.py", line 8, in <module>
    from .config import cfg
  File "/Users/f.yalcin/.pyenv/versions/3.11.2/lib/python3.11/site-packages/sgpt/config.py", line 82, in <module>
    cfg = Config(SHELL_GPT_CONFIG_PATH, **DEFAULT_CONFIG)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/f.yalcin/.pyenv/versions/3.11.2/lib/python3.11/site-packages/sgpt/config.py", line 40, in __init__
    self._read()
  File "/Users/f.yalcin/.pyenv/versions/3.11.2/lib/python3.11/site-packages/sgpt/config.py", line 71, in _read
    key, value = line.strip().split("=")
    ^^^^^^^^^^
ValueError: not enough values to unpack (expected 2, got 1)

My Python version (installed through `pyenv):
$ python --version
Python 3.11.2
Config ( ~/.config/shell_gpt/.sgptrc)
# API key, also it is possible to define OPENAI_API_KEY env.
OPENAI_API_KEY=**************************************************
# OpenAI host, useful if you would like to use proxy.
OPENAI_API_HOST=https://api.openai.com
# Max amount of cached message per chat session.
CHAT_CACHE_LENGTH=100
# Chat cache folder.
CHAT_CACHE_PATH=/tmp/shell_gpt/chat_cache
# Request cache length (amount).
CACHE_LENGTH=100
# Request cache folder.
CACHE_PATH=/tmp/shell_gpt/cache
# Request timeout in seconds.
REQUEST_TIMEOUT=60
# Default OpenAI model to use.
DEFAULT_MODEL=gpt-3.5-turbo
# Default color for OpenAI completions.
DEFAULT_COLOR=magenta
# Force use system role messages (not recommended).
SYSTEM_ROLES=false

Could you let me know if you support only specific python versions?

Looks like if I remove the config file and enter the OpenAI key into the prompt, it works. So, is the default config wrong? (the one on your README.md):
$ sgpt "what are the colors of a rainbow"
Please enter your OpenAI API key:

The colors of a rainbow are red, orange, yellow, green, blue, indigo, and violet.

I may have entered a typo, I will close it for now!


Should we remove the canonical link?

Google says:
https://sites.google.com/site/webmasterhelpforum/en/faq-internationalisation
Q: Can I use “rel=canonical” together with “rel-alternate-hreflang”?
A: We recommend not using rel=canonical across different language or country versions. Using it within the same language/country version is fine and one of the recommended ways of handling canonicalization.

So when we added:
<link rel="alternate" href="https://www.coinshero.io/he/" hreflang="he">
<link rel="alternate" href="https://www.coinshero.io" hreflang="en">

Maybe it's not needed anymore..

https://dejanseo.com.au/canonical-vs-hreflang/

https://www.rebelytics.com/hreflang-canonical/


Lazy load rois

Geometries are already lazy loaded but during creation of the object the list of ROIs is loaded.

Before we tackle this in the api-client, I'd like to profile the database query first. I'd be nice if you have the information without much of a delay. If improving the request handling time is only marginal, then I think we can make the loading optional, but that requires some changes in the way that requests are submitted.


Make changes to error verifier to catch new null-related error conditions

Notes from our discussion on Jan 4:

E.g. catch the user trying to invoke through nullable
Maybe start with some simple checks?
Maybe port over some of the void-related errors?

Lots of work was done, I'm going to close this catch-them-all issue.


ROR Integration - Identifier Visualization

Please note that this development has been funded by the University of California - California Digital Library.
References

Requires DSpace/DSpace#9238

Description
This PR introduces i18n-labels and visualization of the ROR identifier inside the organization page, as suggested by the ROR-ID guidelines
Instructions for Reviewers
Just import a new Organization using the ROR live-import feature and check that all the labels are correctly shown, and also that inside the organization page the ROR identifier is correctly shown.

List of changes in this PR:

Introduces new en labels
Introduces ROR identifier visualization for the Orgunit component
Adds new ROR image to the assets folder

Checklist

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes ESLint validation using yarn lint
[x] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
[x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[x] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
[x] If my PR fixes an issue ticket, I've linked them together.

Thank you, @vins01-4science, for this contribution! I think it will be very useful. The only thing I would like your feedback on is whether you considered creating a new specific component that extends ItemPageFieldComponent instead of changing the default generic component, enabling it to support images.

@vins01-4science : Overall this works. I tested it with the backend PR and didn't find any obvious major bugs. That said, I did find some missing i18n keys and some other small issues in the code itself. See inline comments below.

Thank you @paulo-graca  and @tdonohue for the review,
all the changes have been addressed now.
Let me know if you find something else!

I've flagged this as needs documentation just because we need to add ROR to the list of external sources for 8.0 here: https://wiki.lyrasis.org/pages/viewpage.action?pageId=315720684#ImportingItemsviabasicbibliographicformats(Endnote,BibTex,RIS,CSV,etc)andonlineservices(arXiv,PubMed,CrossRef,CiNii,etc)-SupportedExternalSources
Once it is added, we can remove this label

I've flagged this as needs documentation just because we need to add ROR to the list of external sources for 8.0 here: https://wiki.lyrasis.org/pages/viewpage.action?pageId=315720684#ImportingItemsviabasicbibliographicformats(Endnote,BibTex,RIS,CSV,etc)andonlineservices(arXiv,PubMed,CrossRef,CiNii,etc)-SupportedExternalSources
Once it is added, we can remove this label

Thank you @tdonohue,
I have updated the documentation just like you told me.
You can find all my changes here: ROR-Integration.
Let me know if you need something else.

Thanks @vins01-4science !  I'll remove the `needs documentation label.


instructions for using -m are incorrect

Using -m"SQLCMD" does not work. You have to use -mSQLCMD without the quotes. These incorrect instructions on that page had me running in circles for hours. This post solved my problem https://serverfault.com/a/338294

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d41367fc-38cf-0c73-3ea8-93bff726f421
Version Independent ID: 07b2d0b3-2013-a133-9d1e-ee2d249740d5
Content: Connect to SQL Server when system administrators are locked out - SQL Server
Content Source: docs/database-engine/configure-windows/connect-to-sql-server-when-system-administrators-are-locked-out.md
Product: sql
Technology: configuration
GitHub Login: @markingmyname
Microsoft Alias: maghan

@TokenRing -- thank you for your feedback.  I am looking into this issue.

@markingmyname -- Mark, please review private PR 16615.