Azure Mobile should accept the new Google issuer in the tokens

I'm using client side login, thus passing the token to the login method:
JsonObject loginBody = new JsonObject();
loginBody.addProperty("id_token", idToken);
ListenableFuture<MobileServiceUser> mLogin = mActivity.getmClient().login(MobileServiceAuthenticationProvider.Google, loginBody);

This works fine for idTokens issued by the , now deprecating, Google+ APIs on Android.
The JWT token issuer is accounts.google.com
{
  "iss": "accounts.google.com",
...

But when using the new and by Google recommended way to do application sign-in on Android apps, the idToken now (Since Google Play Service v8.3 or newer) the issuer field is https://accounts.google.com

// If you retrieved the token on Android using the Play Services 8.3 API or newer, set
// the issuer to "https://accounts.google.com". Otherwise, set the issuer to
// "accounts.google.com". If you need to verify tokens from multiple sources, build
// a GoogleIdTokenVerifier for each issuer and try them both.

Ref: https://developers.google.com/identity/sign-in/android/backend-auth#calling-the-tokeninfo-endpoint
{
  "iss": "https://accounts.google.com",
...

And sure enough,  now the Azure Mobile Service servers barfs this exception at me:
Error while authenticating user. {"code":401,"error":"Error: The id_token issuer is invalid."}
Please change the token validator on the Azure Mobile backend to accept these new tokens.

Has there been any updates on this? I keep getting token issuer is invalid. How can I solve this problem with the Google Services v9.0 and newer?

Are you using the more recent Azure Mobile Apps (part of Azure App Service) or the older Azure Mobile Services?  This error message is not familiar to me, so I'm guessing it comes from the older Azure Mobile Service. The more recent Azure Mobile Apps backend should be using the correct issue for Google logins.
Adding @adrianhall to comment on whether we are still making updates to Mobile Services.

Thank you for responding. I am using mobile services android sdk 2.0.3. I want to migrate to Azure App services but it will take some effort for me to change my client side code so trying to put that extra effort on the side right now. If you are still updates Mobile Services then that would be perfect.

We are not updating Mobile Services any more. Ref: https://github.com/azure/azure-mobile-services
The recommendation is to transition your app to App Service Mobile Apps, using the latest capabilities.  I'm going to close this as a result.  See https://docs.microsoft.com/en-us/azure/app-service-mobile/app-service-mobile-node-backend-upgrading-from-mobile-services


Get-AzureRmStorageAccountKey syntax

modified the -name parameter as well as how to extract the key value. Perhaps it's a question of PS version...?

Hi @omartin2010, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (omartin). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

Looks like it depends on which version of the cmdlet you are running. This change works for me as well. I will keep and eye out for any reports of it failing after this change.


Error

I am getting this error when running a query : Give Feedback / Get Help: https://github.com/BerriAI/litellm/issues/new
LiteLLM.Info: If you need to debug this error, use `litellm.set_verbose=True'.
in router_cooldown_event_callback but _deployment is None for deployment_id=81388564bb5ba0d80f710f39aea9f71baec4b680b19885ea00285e9362f63918. Doing nothing

Hi @Litreviewing yep I have hit this too, it's an outstanding bug in our upstream dependency litellm: https://github.com/BerriAI/litellm/issues/5933
It's why we added the ability to bypass the litellm.Router in https://github.com/Future-House/paper-qa/pull/563
This is sort of an area of active development, so we don't have docs on it yet

Got it, also is there a way to change the settings such that it can conduct a literature review? I tried changing the config files to add longer length answers but still getting short  summary responses.
Additionally, is there a way to change the citation format? I've noticed it can inaccurately cite a document, so even if it's able to cite the filename at least from there I can manually adjust.
Thanks!


openssl engine -t  -c -vvvv qat:  DSO support routines:dlfcn_load:could not load the shared library:crypto/dso/dso_dlfcn.c:118:filename(/usr/local/ssl/lib/engines-1.1/qat.so): /usr/local/ssl/lib/engines-1.1/qat.so: undefined symbol: qat_ioctl

CentOS Linux release 7.2.1511 (Core)
qatmux.l.2.6.0-60 with QAT.L.R2.6.0-60.patch , QAT1.6
There is 4 acceleration device(s) in the system:
icp_dev0 - type=dh895xcc, inst_id=0, node_id=0,  bdf=3d:00:0, #accel=6, #engines=12, state=up
icp_dev1 - type=dh895xcc, inst_id=1, node_id=1,  bdf=88:00:0, #accel=6, #engines=12, state=up
icp_dev2 - type=dh895xcc, inst_id=2, node_id=1,  bdf=b1:00:0, #accel=6, #engines=12, state=up
icp_dev3 - type=dh895xcc, inst_id=3, node_id=1,  bdf=da:00:0, #accel=6, #engines=12, state=up
openssl-1.1.1d , ./config --prefix=/usr/local/ssl -Wl,-rpath,/usr/local/ssl/lib
QAT Engine 0.5.42 , ./configure --with-qat_dir=/root/hecong/qatmux.l.2.6.0-60/QAT1.6 --with-openssl_dir=/root/hecong/openssl-1.1.1d --with-openssl_install_dir=/usr/local/ssl --enable-multi_thread --with-qat_install_dir=/usr/lib64
./openssl engine -t -c -vvvv qat, get errors below:
140391366149952:error:25066067:DSO support routines:dlfcn_load:could not load the shared library:crypto/dso/dso_dlfcn.c:118:filename(/usr/local/ssl/lib/engines-1.1/qat.so): /usr/local/ssl/lib/engines-1.1/qat.so: undefined symbol: qat_ioctl
140391366149952:error:25070067:DSO support routines:DSO_load:could not load the shared library:crypto/dso/dso_lib.c:162:
140391366149952:error:260B6084:engine routines:dynamic_load:dso not found:crypto/engine/eng_dyn.c:414:
140391366149952:error:2606A074:engine routines:ENGINE_by_id:no such engine:crypto/engine/eng_list.c:334:id=qat
if build QAT Engine without '--enable-multi_thread', ./openssl engine -t -c -vvvv qat can run without error

Hi
I cannot say I have run the QAT engine with the --enable-multi_thread option.  I will try and reproduce the problem next week at which point I may be more helpful.  I have noted  that the README.md file says that this option : -
is an alternative way of managing within userspace the pinned
contiguous memory allocated by the qat_contig_mem driver.
In the meantime here are some checkpoints: -
The qat contig mem driver kernel module is definitely loaded?
Have you tried this with an older version of OpenSSL, suggest 1.1.1c?

I'm pretty sure qat_contig_mem module has been loaded.
I donot have tried openssl-1.1.1c, the problem seems more likely that functions in qat_sys_call.c have not been defined.
when i use system calls rather then the packaging functions defined in qat_sys_call.c, everything seems fine.

@jxhecong, would you mind sharing a diff with how you used system calls rather than packaging functions as I run into the same problem?
Cheers


[Docs] Colour modes for individual elements

I wanted a light theme with some dark elements, so I applied data-bs-theme="dark" to those elements.
However that didn't change anything. So I also added either class="text-bg-dark" or class="bg-dark text-light", which worked - but I knew that was a hack.
Only after looking at the source for that "blue example" did I realise that one must do this:
<div data-bs-theme="dark" class="text-body bg-body">
  ...
</div>

That should probably be in the docs, it is fundamental.

Hi there,
I want to contribute to this project and take on this issue as my first task. Could you please assign it to me? I am excited to work towards resolving it and will keep the team updated on my progress.
Thanks


Prevent Firefox from using apple-touch-icon

The opaque background does not work well in Firefox which uses the icon as a "rich icon". Prevent this by not specifying it in HTML. Real Apple devices will still request the icon on the static path.
Fixes: https://github.com/go-gitea/gitea/issues/10394
Not using Macaron because it sets useless HTTP headers.

Codecov Report

Merging #10402 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #10402      +/-   ##
==========================================
- Coverage   43.74%   43.74%   -0.01%
==========================================
  Files         586      586
  Lines       81113    81118       +5
==========================================
+ Hits        35481    35482       +1
- Misses      41243    41246       +3
- Partials     4389     4390       +1

Impacted Files
Coverage Δ

routers/routes/routes.go
86.05% <0%> (-0.52%)
:arrow_down:

services/pull/check.go
32.92% <0%> (-3.05%)
:arrow_down:

modules/git/command.go
86.95% <0%> (-2.61%)
:arrow_down:

services/pull/pull.go
32.43% <0%> (-1.51%)
:arrow_down:

modules/git/repo.go
47.7% <0%> (+0.91%)
:arrow_up:

modules/process/manager.go
78.31% <0%> (+3.61%)
:arrow_up:

modules/git/utils.go
70.14% <0%> (+4.47%)
:arrow_up:

modules/indexer/stats/db.go
50% <0%> (+9.37%)
:arrow_up:

modules/indexer/stats/queue.go
81.25% <0%> (+18.75%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfcd8e4...2ce24ca. Read the comment docs.

Maybe you should change appsuburl to StaticUrlPrefix so that it's possible to be serve by CDN.

What's the difference between AppSubUrl and StaticUrlPrefix exactly? On a default installation, both are empty string and on gitea.com StaticUrlPrefix is on a second domain. Both seem to serve assets fine.

@silverwind on gitea.com StaticUrlPrefix == s.gitea.com will be served by CDN, but AppSubUrl == gitea.com will be served by original site.

Ok using StaticUrlPrefix.
Pushed two additional tweaks:

Remove custom/conf/app.ini.sample from .gitignore as that file is tracked in git which makes it searchable via tools like ag.
Fixed wrong variable name in app.ini.sample

gitignore fixed, it needs to be a bit verbose to work (taken from https://stackoverflow.com/a/16318111/808699).

I would say ready for merge?


Update Meshery to Layer5

Signed-off-by: Ruth-ikegah<EMAIL_ADDRESS>Description
This PR fixes #1248
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

Excellent. Thank you, @Ruth-ikegah 👍

My pleasure! I got better with time and practice. My experience blog post should be dropping soon!


Visualizor malfuntion? pls halp?

The Bug
The visualizer bar doesn't react to the current song playing. Everything else works perfectly, even customization of the visualization bar. Did I do something wrong? Also tested multiple songs, messed with the customization, refreshed the skin and restarted Spotify
To Reproduce
Problem was present from first launch; have no idea how to reproduce
Screenshots

System information
Rainmeter Version: <IP_ADDRESS>32 65bit
OS Version: Windows 10 Home 2009 64-bit (build 19043)
Skin Version: Version: 2.1.0
Spotify Version: 9.1. 57

Also tested multiple songs, messed with the customization, refreshed the skin and restarted Spotify

So I found out that having Razer's THX Audio set as my default device for output (which uses Razer's software to make your audio sound better) PREVENTS the visualizer from interacting with the sound. >:(
So setting it to the speakers themselves restores the functionality. WTF >:( Sorry for posting an Issue, just found the solution.


[Feature] Support source/sink connectors on EventMesh

Search before asking

[X] I had searched in the issues and found no similar issues.

Feature Request
Through eventmesh's source/sink connector, we can connect data to heterogeneous data storage, we hope that the community can provide source/sink connector capabilities, such as connecting rocketmq data to different rocketmq clusters or kafka clusters.
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

RocketMQ connectors completed and sink/source connectors will keep developing.


Add guide to caddyserver/examples

Great idea with this repo :+1:
Would someone be willing to contribute this Caddy guide to caddyserver/examples?
All it would take is the Caddyfile and an explanation of what it does, and why it works. Thanks!

Sure @mholt we will do so. Thanks for the suggestion.

Closing the issue, merged upstream https://github.com/caddyserver/examples/tree/master/minio


Add tvOS to deployment target list.

Tested it, seems to work just fine on tvOS.

Ahh dup: https://github.com/mattt/Ono/pull/59


Update note on UWP 6.0 support on .NET implementations page (#482)

Improved text for UWP 6.0 RTM.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

entity-framework/core/platforms/index.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat(*) accept kong-prefix instead of socket name

This commit replaces the -socket flag with -kong-prefix and
hardcodes the socket name, which is expected by Kong to be in the Kong
prefix.

neat. of course, we'll need a similar change on the Lua side

On the Lua side we are already assuming this socket name and location, so no change needed there  :)


Corrected import typo by added double quotes

Just correcting a minor typo in the import a dependency example:
go fmt
expected 'STRING', found '/' (and 1 more errors)

:+1:


chore: check npm lockfile version does not change

running npm install with a different version of npm will result in
the lockfileVersion being changes in package-lock.json
This checks for that change in PRs, since we don't want that to happen.

I think v9 but unsure


Add file_system_locations

what

Add file_system_locations
Add build_image_pull_credentials_type
Add s3_cache_bucket_name
Add encryption_key (bridgecrew)

why

Newer inputs

references

Closes https://github.com/cloudposse/terraform-aws-codebuild/issues/110
Closes https://github.com/cloudposse/terraform-aws-codebuild/issues/107
Closes https://github.com/cloudposse/terraform-aws-codebuild/issues/95
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/codebuild_project

/test all


Issue When there is no video

Activiity indicator keeps spinning when there is no video.

Same issue for photos too.

You have resolved the issue. But a good solution would be to add a Camera button if there is no Photo or Media.


Created Navigation Drawer for Vritant App

@bhattabhi013 .  About and Contact us page is subject to change, please review it and tell if anything is required to add.

Hi @Utkarsh4517,
It looks amazing, however, there are some changes that I'll like to request.

Revert the changes in pubspec.lock file.
Add some content on the pages. Empty pages don't look good, you can use readme.md file for this purpose.


Required v0.18 Release Checks

Complete required release checks.

Checklist:

[ ] run validation on master
[ ] create release-0.18 branch
[ ] make set-version TAG=0.18.0 + commit
[ ] make lock-images + commit
[ ] draft release notes, review
[ ] update master README for supported versions
[ ] final validation
[ ] publish release


Gamma: fix consumer overrides

Builds on https://github.com/istio/istio/pull/45058
Fixes https://github.com/istio/istio/issues/45057

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Concerned this is a breaking change


Upgrade wrapper to Gradle 8.2

@bot-gradle test and merge

I've triggered a build for you. Click here to see all failures if there's any.

Pre-tested commit build failed. Click here to see all build failures.

I've triggered a build for you. Click here to see all failures if there's any.


Open files are not reopened when closing/opening the app

Type: Bug

Close VS Code with various saved/non-saved files open.
Reopen VS Code
Not everything is reopened

I had over a dozen files open, closed the app and reopened it (no update occurred that I saw), and only five non-saved files are open. I would expect it to restore to the state it was in when it closed. Additionally, and I guess I'll create a separate bug for this, but I can't open any new files.
VS Code version: Code 1.85.2 (8b3775030ed1a69b13e4f4c628c612102e30a681, 2024-01-18T06:40:10.514Z)
OS version: Windows_NT x64 10.0.19044
Modes:
Extensions (2)

Extension
Author (truncated)
Version

powershell
ms-
2024.0.0

vscode-yaml
red
1.14.0

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
vscorecescf:30445987
vscod805:30301674
binariesv615:30325510
vsaa593:30376534
py29gd2263:30899288
vscaat:30438848
c4g48928:30535728
azure-dev_surveyonecf:30548226
0bi6i642:30933247
pythongtdpath:30769146
welcomedialog:30910333
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
pythontbext0:30879054
accentitlementsc:30887149
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
3ef8e399:30949928

Configure: window.restoreWindows to preserve. Then it should be fine.

Hmmm I may have had a workspace opened originally, I don't remember. If I did, I definitely had files from other folders open also. It was set to the default "all" so this might have been the issue. What a bizarre default behavior (and poorly named IMHO).


A splice where can.List ends up exactly the same should not produce any events.

Contrary to #1277, a splice that ends up looking the exact same should not produce add and remove events.  This will make can.List work very similar to can.Map.  If you set an attribute to its existing value, no events are fired.
#1277 was confused because "add" events were fired without "remove" events.  Instead, no events should have been fired.

Closed via #1400


preserve array attributes when duplicating them

This fixes #1108 (it's what is described as the "quicker fix" in the issue)

This looks good to me - and I find the solution with Object.assign elegant. Thanks!


Vue 3 Composition API Notifcation - Utility File

Overview of the problem
Oruga version: "^0.5.10"
Vuejs version: "^3.2.45"
OS/Browser: Chrome
Description
I'm using a Vue 3 app with Vite, and the composition API. I'm able to do oruga.notifcation.open() inside of my <script setup></script> components, but not in utility files:
Steps to reproduce
New codebase with any component. Using the Composition API. Create a utility class for oruga notifcations, and try to use it in a component:
// Toast.ts
import { useProgrammatic } from '@oruga-ui/oruga-next';

export function orugaToast(message: string, closable: boolean, variant?: string): void {
	const { oruga } = useProgrammatic;

	oruga.notification.open({
		message: message,
		closable: closable,
		variant: variant === undefined ? 'success' : variant,
	});
}

// Component.ts
import { orugaToast } from '@/utils/toast';

onMounted(() => {
   orugaToast('Hello', true);
});

Expected behavior
It should be able to open a notification like normal.
Actual behavior
oruga.notification isn't defined

Using https://github.com/oruga-ui/oruga/issues/256 for reference

It's a function useProgrammatic()


Wrong Font Variants: Noto Sans SC on Windows

Description
similar to #576, but is an issue about another font.
Environment

Windows
typst-x86_64-pc-windows-msvc 0.11.1

Reproduce Steps

download Noto Sans Simplified Chinese from Google Fonts, it provides these variants (in static folder):

static\NotoSansSC-Black.ttf
static\NotoSansSC-Bold.ttf
static\NotoSansSC-ExtraBold.ttf
static\NotoSansSC-ExtraLight.ttf
static\NotoSansSC-Light.ttf
static\NotoSansSC-Medium.ttf
static\NotoSansSC-Regular.ttf
static\NotoSansSC-SemiBold.ttf
static\NotoSansSC-Thin.ttf

write a typst file like below, and compile:

#set text(
  font: "Noto Sans SC"
)
#text(style: "normal", weight: "thin")[你好] \
#text(style: "normal", weight: "regular")[你好] \
#text(style: "normal", weight: "bold")[你好]

The result is as shown below. The rendering font is using NotoSansSC-Thin.ttf.

typst.exe fonts --variants gives following information about Noto Sans SC:

Noto Sans SC
- Style: Normal, Weight: 100, Stretch: FontStretch(1000)

Thank you for any investigations and comments in advance.
Reproduction URL
No response
Operating system
Windows
Typst version

[X] I am using the latest version of Typst

Did you use --font-path static to specify the static folder?

Did you use --font-path static to specify the static folder?

Sorry for possible misunderstanding. I installed the fonts in the static folder extarcted from original google font archive. the fonts were finally installed into Windows Fonts folder, which is C:\Windows\Fonts.

Could you run typst.exe fonts --font-path /path/to/static --variants and check if the variants are found? If they can be found via specifying font-path, maybe it is the issue about installation.

Thank you! It works. I've appended the extracted path (not the system font folder, which I think maybe unneeded to do so), and typst have found the fonts varying by weights.


Metrics views for CloudStack UI

FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Metrics+Views+for+CloudStack+UI
JIRA: https://issues.apache.org/jira/browse/CLOUDSTACK-9020

For screenshots, please see the FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Metrics+Views+for+CloudStack+UI

@bhaisaab the sprites seem not to have changed. Should the sprite.png be in this change?

@DaanHoogland see the capture

@DaanHoogland yes, the metrics view brings in new state icons that can be used in other places;
orange for alert, migrate etc. yellow for allocated, in transition etc. See metrics.js for state string to icon translations.

thanks guys, missed that. Should I do anything more then just run with this change? an option some where? I am not seeing the metrix bottun in the zone view.

@DaanHoogland this is an admin only feature, just do a clean install and you should see this logged in as an admin

@bhaisaab haven't got it working yet. I am trying as admin.

@DaanHoogland I build the branch today from scratch, it seems to be working for me; see the screenshot:

@wido I've included instance count on the host view page now
@NuxRo the container width has been increased by 200px now, no more horizontal scrolls and more wider space in general for all UI, and logos has 'cloudmonkey' now - booyah!

yeah baby!

@bhaisaab trying anew and still don't get the metrics button. I destroyed the vm on which the test cloud is running, checked out the pr 1038 as bracnh compiled and started it. I started Safari (not my default browser), deleted all history and opened the page.

I am now investigating the page source to see if I can recognise code from the pr in there.

The ui does not contain the metric button even hidden:

I am sure I need some extra tweeking or an extra commit not in the PR.

@DaanHoogland thanks for taking time to review this, on my system I'm still able to get the metrics button on Chrome/Firefox/Safari. Can you simply take the shapeblue:metrics-master repo/branch which is where the PR is created form, there is no hidden or missing commit. In the html source (of index.jsp being rendered) can you find metrics.js and metricsView.js included somewhere? Can you confirm if you're building and running mgmt server with mvn or testing using an rpm? It might be an environment issue, or browser caching issue or that your test branch is missing commits from the PR (something went wrong with applying the PR?)
See, I'm able to see the metrics button/views and note that UI is wider than before:

Another place you can check is to go see if you see a viewMetrics codeblock in instances.js (or system.js, or storage.js) in scripts/, like this: (this code is like an API for rendering the metrics button, navigation, setting up view etc)

Also, is anyone else able to reproduce the issue Daan is facing? cc @wido @wilderrodrigues @abhinandanprateek @NuxRo and others?

@bhaisaab I saw you added four new commits, so I'll restart the test in a minute.
I am running in a bubble which does a jetty run from mvn. (mvn -pl :cloud-client-ui jetty:run)
view page source does show metrics.js and metricsView.js!
I have tried chrome and safari with cleared cache and firefox with private browser window. As the pge source from the browser shows the scripts and the labels, I don't think it is a caching issue.

@DaanHoogland thanks, the new commits are nothing but some squashed commits (found minor issues with sorting logic and another view/model issue). If this still does not work for you, share with me your OS/browser/java/maven versions. After you pull back, do a mvn clean install -pl client and then, mvn -pl client jetty:run.

@bhaisaab I am doing a fresh checkout (this time) to ensure no remnants of older code/tests is there. Update in a few...

@DaanHoogland thanks, we can merge this once master is unfrozen and 4.6 branch is cut.

Nice logo @bhaisaab :-)

Deployed this to our employee cloud to give it a test drive.

I've run this for some time and it is really cool, thanks @bhaisaab LGTM
If you consider back porting this to 4.5.3, then I think we should also include it in 4.6.1, shouldn't we? Ping @karuturi.
In that case, can you make a PR against the 4.6 branch so we can merge it there and then fwd-merge it to master (so it will be in 4.7 and onwards as well).

@remibergsma this is a very cool feature. why do you suggest it be put in 4.6?

@DaanHoogland Because @bhaisaab wants it in 4.5.3. Otherwise people will upgrade from 4.5.3 to say 4.6.2 and lose a feature.

hm, this is breaking our policy hard. I have some things of Wei's laying around....

Right, so what now?
Can't we just postpone this till 6.7 and perhaps provide some easy patches in the meanwhile for whoever wants to use in 4.5 and 4.6?
--
Sent from the Delta quadrant using Borg technology!
Nux!
www.nux.ro
----- Original Message -----

From: "Daan Hoogland"<EMAIL_ADDRESS>To: "apache/cloudstack"<EMAIL_ADDRESS>Cc: "NuxRo"<EMAIL_ADDRESS>Sent: Tuesday, 17 November, 2015 16:43:56
Subject: Re: [cloudstack] Metrics views for CloudStack UI (#1038)

hm, this is breaking our policy hard. I have some things of Wei's laying
around....

Reply to this email directly or view it on GitHub:
https://github.com/apache/cloudstack/pull/1038#issuecomment-157426767

Guys can we get some +1s on this, so let's at least merge on master? cc @wilderrodrigues @DaanHoogland @NuxRo @wido @abhinandanprateek and others
@DaanHoogland I'm interested in getting some of the commits related to UI width, sorting of tables etc. on 4.5 (we can remove the metrics view related commits). The reasoning here is that this does not change existing mgmt server core code, nor the schema. It's UI changes that improve existing experience for users.

+1 to merge on master

I would like to give a LGTM, but my JavaScript skills aren't that good.
The small Java changes look good to me.

+1 have tried the feature and used bits of it in revamped quota UI.

@remibergsma rebased again the branch against latest master, created PRs;
4.6: #1090
4.5: #1091

Hi @bhaisaab
you should create PRs for (4.5 and 4.6) OR (master). Not for all the branches.
Based on the discussion and votes above I think the decision was to include in master only(4.7). So the PRs for other branches(4.5 and 4.6) are not necessary.

@karuturi Remi asked for a 4.6 based PR. Given some votes and if we don't have an objections should I go ahead and merge on master?

@bhaisaab I'm OK with merging this to master now, but that will also mean it will not end up in 4.6. I think @DaanHoogland already said that no new features should go into 4.6 (as we agreed before) so merging to master is fine with me. I like your idea about porting back some of the patches to 4.5 and 4.6 to make the UI wider and such.
I asked for 4.6 version because I thought we wanted to back port all of the metrics thing to 4.5 and then I find it weird to not have it in 4.6. But let's stick to what we said, let's merge it to master and move on.
It is a great feature!
All agree to merge on master and back port only some of the UI tweaks?

@remibergsma Agree.

@remibergsma alright, merging on master now. If there is no objection, I would like to merge this on 4.5 as whole, if that's not acceptable at least the other useful commits minus the metrics features. Comments?

+1, please merge
On 11/18/15 11:03 PM, Rohit Yadav wrote:

Guys can we get some +1s on this, so let's at least merge on master? cc
@wilderrodrigues https://github.com/wilderrodrigues @DaanHoogland
https://github.com/DaanHoogland @NuxRo https://github.com/NuxRo
@wido https://github.com/wido @abhinandanprateek
https://github.com/abhinandanprateek and others
@DaanHoogland https://github.com/DaanHoogland I'm interested in
getting some of the commits related to UI width, sorting of tables etc.
on 4.5 (we can remove the metrics view related commits). The reasoning
here is that this does not change existing mgmt server core code, nor
the schema. It's UI changes that improve existing experience for users.
—
Reply to this email directly or view it on GitHub
https://github.com/apache/cloudstack/pull/1038#issuecomment-157971218.

The metrics UI is not really a major feature in my opinion. We are not changing the core and any apis.
All we are doing is re-presenting already presented data in UI in slightly different and much better manner.
I've tried it extensively in fairly large environments on back ported 4.5, i can attest it works as expected.
It would certainly help the project and new folks trying out ACS. I'm supporting the back port into 4.6 - as i'd consider this UI enhancement and not new major feature..


Animation speed

Is your feature request related to a problem? Please describe.
Hi Kiarash, Thanks for awesome project. I feel animation on change month or year is a bit slow.
Describe the solution you'd like
If that's fine I can make a PR and fix this, then you can check it out and if that was fine merge it.

Hi Mohammadreza,
There's no official prop available for changing the animation speed yet, but because I have used a CSS variable for animation speed, you can easily change it as below:
<Calendar calendarClassName="custom"/>

.custom {
  --animation-duration: 1s;
}

Here's a sample on CodeSandbox
I think the animation duration is good for now. I would consider adding a prop for changing its value in later versions though. You can work on a slideAnimationDuration prop if you wish 😊

That's cool, I'll work on that. Thanks again.


Unity missing from dropdown

Unity missing from dropdown

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4f2add0f-2806-8bfa-92d5-cc3fdd1e1055
Version Independent ID: c572b535-a780-fba3-0845-f5127d98d7d6
Content: UWP, WPF, and WinForms SDK Troubleshooting - Visual Studio App Center
Content Source: docs/sdk/troubleshooting/uwp.md
Service: vs-appcenter-sdk
Sub-service: app-center-general
GitHub Login: @elamalani
Microsoft Alias: emalani

Closing this issue as I do see Unity in the portal. Feel free to open the request if you still can't find the Unity Platform.

Its present now


Issues with Chrome and camera capture

I am not sure if this is a bug in CLOWDR or Chrome, but when entering and leaving a room Chrome continues capturing webcam input. In fact, I was actually able to join two rooms at once (from two tabs) even though I was only seeing one room. I have no idea if this can be easily replicated, but here's what I did:

Join room in one tab (1).
Join a room from another tab (2) and then quickly leave.
I experienced the (unsettling) situation where tab 1 showed me in a room, tab 2 showed me on a neutral page (lobby?), but people in both rooms could hear and see me.

Might some of this be related to the fix in #172 ?

It might be related, although I saw this issue yesterday so there must still be something going on.

As I understood it, at least, the multiple-camera part of what you describe might be intended behavior.

Being in multiple tabs seems intended. Continuing to be recorded after leaving a room isn't intended - you can repro that using just a single tab under the right circumstances (join, quickly leave. Or join on a slow connection and leave (Chrome/FF can artificially slow down connections)). This is probably caused by something like: "if you leave before the connection has been formed then the 'leave' event thinks there is no connection, even if it is currently being set up". This seems like a JS sequencing issue - that's what I'd go hunting for (async functions having a race condition).


Fix travis builds

At first the I updated go to 1.8 because gopherjs requires it. Now there's a gomobile and mgl32 issue here.

Have you tried running go generate in mgl32, as the code is generated from mgl64.

I have not @coderconvoy, I'll give it a shot soon

Partially fixed in #409 . Gomobile isn't building on Go 1.8 on travis (builds locally) but Gopherjs requires latest go version (1.8). In the meantime, so it doesn't block other issues, gopherjs testing is removed. I will leave the issue open since it's still relevant to fix it properly.

Mostly fixed. Everything builds and the normal tests all pass, but I want to make sure that the gopherjs tests are in working order before closing this

Fixed in #551


feat: add cardinality check on arbitrary set generation

#130  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pevisscher and the rest of your teammates on  Graphite


Support for hot code upgrade in production

If an app in production is hot upgraded to a new version, Drab rises an alert with
"An error occured. Please contact the System Administrator" error message each time the user will try to interact with a Drab powered template.
This because in Drab.Config.drab_extension() the function Application.fetch_env(:phoenix, :compiled_template_engines) is used to retrieve the Drab custom engine, but this function returns nil after a hot code upgrade, so Drab will fail.
  def drab_extension() do
    {drab_ext, Drab.Live.Engine} =
      :phoenix
      |> Application.get_env(:compiled_template_engines)
      |> Enum.find(fn {_, v} -> v == Drab.Live.Engine end)

    "." <> to_string(drab_ext)
  end

To safely get the list of compiled engines, the officially available API Phoenix.Template.engines/0 should be used instead. Internally, it dynamically rebuilds the list when necessary, and makes it statically available to the subsequent calls through Application.fetch_env(:phoenix, :compiled_template_engines).
  def drab_extension() do
    {drab_ext, Drab.Live.Engine} =
     Phoenix.Template.engines()
     |> Enum.find(fn {_, v} -> v == Drab.Live.Engine end)

    "." <> to_string(drab_ext)
  end

PR #190  apply the suggested patch.

Looks great and simple, #190 closes this.  :-)


feat: advance without target

Description
Advance without target.
Pins kona to https://github.com/anton-rs/kona/pull/848

Codecov Report
Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 24.0%. Comparing base (349fcf4) to head (8eff3c3).

Files with missing lines
Patch %
Lines

crates/driver/src/driver.rs
0.0%
6 Missing :warning:

Additional details and impacted files

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add CodeQL security scanning

Hi, I'm a PM on the GitHub security team. This repository is eligible to try the new GitHub Advanced Security code scanning beta.
Code scanning runs a static analysis tool called CodeQL which scans your code at build time to find any potential security issues. We've tuned the set of queries to be only the most severe, most precise issues. We'll show alerts in the security tab, and we'll show alerts for any net new vulnerabilities on pull requests as well. We've tried to make this super developer friendly, but we'd love your feedback as we work through the beta.
If you're interested in trying it out, you can merge this pull request to set up the Actions workflow.

The build is working and didn't find any security issues. So if you're happy with this, it's ready to go.


fix(types): should wrap the original type with Reactive in DistributeRef

re-fix #12095
Expose IsShallowReactive to enable type determination in language tools.
In non-strict mode, undefined extends ShallowRef<infer V, unknown> will be inferred as true, causing UnwrapRef<undefined> to be inferred as unknown.


Setting fen of a chessboard does not work sometimes

It seems like using let x = board.fen() to get the chessboard and then setting it back with board.fen(x) does not work if two pieces have moved already, and only if two pieces have moved already.
I have code like this to send a request to my server to see if the move is valid or not, and if it isn't then don't show the move:
function onDrop (source, target) {
  // Get current board to snap back to if move is invalid
  var cur_board = board.fen()

  axios.post('/', {
    source: source.source,
    target: source.target
  })
  .then(function (response) {
    // If move is invalid, set board back to the original board
    if(response.data.processed == false){
      board.fen(cur_board)
    }
  })
  .catch(function (error) {
    console.log(error);
  });
}

The funny thing is this works totally fine up until two pieces are changed on the board. Then it doesn't work at all. Am I overlooking something? If you console.log the fen before and after doing the changes, they're not any different, but if you log cur_board it is different.
Adding onto that, an example of a fen string that board.fen() does not work on is rnbqkbnr/pppppppp/3P5/8/4P3/8/PPP3PPP/RNBQKBNR, but that fen string was generated with board.fen() itself, so it should work.

I cannot tell from your issue exactly what the bug is here. My hunch is that this is a timing / state bug with your program. Can you recreate the minimal code that shows a bug with chessboard2?

Adding onto that, an example of a fen string that board.fen() does not work on is rnbqkbnr/pppppppp/3P5/8/4P3/8/PPP3PPP/RNBQKBNR, but that fen string was generated with board.fen() itself, so it should work.

rnbqkbnr/pppppppp/3P5/8/4P3/8/PPP3PPP/RNBQKBNR is not a legal FEN string (3P5 is 9 squares, PPP3PPP is also 9 squares). Can you reproduce the code that caused chessboard2 to create it?

I will recreate an example later, but that fen string directly was created with board.fen() so it should be a legal fen string.

It seems like just making some certain illegal moves causes board.fen() to return an invalid fen string, such as playing e4, d4, and then moving the d4 pawn to d7, 'capturing' the pawn. (not an actual legal move, obviously). This specific sequence returns rnbqkbnr/pppppppp/8/8/3PP3/8/PPP3PPP/RNBQKBNR as the fen string when checking board.fen().
Quick example where you can try this: https://chessboard-test.noelb33.repl.co/

Thank you for following up on this :+1:
I found a one-character bug with the position->fen function that I am pretty sure is the root cause here :upside_down_face:
Sorry for the trouble! I can imagine this would be quite frustrating to debug. This should be fixed with v0.5.0.


Permission error copying files

Hello,
I had permission errors like this "Uncaught Error: EACCES: permission denied, open" or like this "Uncaught Error: EACCES: permission denied, mkdir".
And for this reason, I use this npm module (sudo-prompt)
My code is ..
var toExec = "chown -R $(whoami) "+ pathToCopy;
sudo.exec(toExec, options, function (error, stdout, stderr) {
startCopying();
});
But I receive "command failed"
What am I doing badly?
Thanks

I tried the following on macOS 10.12.2 and it worked fine:
var sudo = require('sudo-prompt');
var command = "chown -R $(whoami) testdirectory";
sudo.exec(command, {}, console.log);

What does which whoami return?
Are you sure that pathToCopy exists?
What platform are you on?
Do you know that whoami when run under sudo will probably return root? You may want to get the user name outside of the sudo session first.

Yes path exists, I am in darwin and win32, crossplatform app.
Maybe I should reformulate the question:
I am doing an installer and I want to give permissions to user to make various directories and copy files.
Do you know how I can execute a javascript function with privileges?
Thanks!

Yes path exists, I am in darwin and win32, crossplatform app.

Your command as you gave it above will most likely not work on win32, since win32 does not have chown
You can use sudo-prompt to execute any shell command within a sudo session. For instance, if you need to execute a javascript function with privileges as you say then you could use sudo-prompt to launch node script.js. But from there, the rest is up to you.
Some suggestions:

Do the simplest thing possible first, then build from there.
Test your command in the terminal first on all platforms to make sure it works. If it does not work in the terminal then it will not work in sudo-prompt.
Make sure you do not rely on any environment variables or current working directory when executing your command. Use absolute paths.

Hi,
I'm sorry but I'm little lost:
Now, I have node script (js) that copy all files.
This script is called by sudo-prompt like this:
    var command = 'node ' + path.resolve(__dirname, '../vendor/installer/installationsudo.js') + ' "' + parameter + '"';

    sudo.exec(command, options, function (error, stdout, stderr) {
        if (error) {
            console.log(error)
            self.set('installationResults', error);
            self.set('installationFinished', true);
        } else {
            console.log(stdout)
            console.log(stderr)
            self.set('installationResults', "Installation done.");
            self.set('installationFinished', true);
        }
    });

This code works in debug mode, but not compiled with electron.
I am using electron v1.5.0 (with node v7.4.0), I thought that was for something wrong in my script, but if I execute this, also fails:
var command = 'node -v'';
sudo.exec(command, options, function (error, stdout, stderr) {
if (error) {
console.log(error)
} else {
console.log(stdout)
console.log(stderr)
}
});
And I have same problem, in debug mode all is ok but once compiled no works.
I know that is not a problem with sudo-prompt, but I hope that you can help me, thanks!

Your second example var command = 'node -v''; has an extra single quote at the end of the line which would not compile.
It may also be that when Electron runs, it runs using a different environment, so you need to reference the node binary using an absolute path. Probably /usr/local/bin/node instead of just node.


fix: Example recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices

polyType enum value is capitalized

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

Automation for azure-sdk-for-js

Automation for azure-sdk-for-java

Automation for azure-sdk-for-node

Automation for azure-sdk-for-ruby

Can one of the admins verify this patch?


Use cilium/team-manager for config-file based GH Org Member/Team management

It seems the Cilium team has built and open sourced a tool we've wished for a number of times, to enable config-file based management of our GitHub Organization's Members and Teams.
https://github.com/cilium/team-manager
Investigate using it for Submariner, build consensus, and add the tool.

bump


Update CONTRIBUTORS.rst

@TimmyPy Sorry, but I can't find your contributions. Can you, please, create new PR?

@TimmyPy Ping.


ofxBox2dPolygonUtil simplifyContour fix

when building ofxBox2d with the latest 0.9.0 master and VS 2015,
i was getting a compiler error when initialising mk[n] since n is a variable and it needs to be static const.
but what i realised was that the simplifyContour code was added to ofPolyline a while ago,
so instead of having the same code in two different places, ive made it so the simplifyContour method uses ofPolyline to do these calculations instead.
everything else is the same...

thanks!


Make admin observers lizars.

Change your aghost sprite yourself lazyass


Can't restore RNG state properly

Godot version: 3.2.3 & current master (ba51af7)
OS/device including version: not graphics-related.
Issue description:
RNG state is not restored after calling RandomNumberGenerator.set_seed with a seed saved from RandomNumberGenerator.get_seed.
The issue is caused by get_seed returning the current RNG state, while set_seed takes a seed, not state.
PR #35764 tries to resolve this problem by making the interface more intuitive, but seems inactive.
PR #27171 introduced this behavior.
A workaround is, maybe, reseeding manually after generating a number, sacrificing randomness.
Steps to reproduce:
Run the following script with Godot.
extends SceneTree

func _init():
	var rng = RandomNumberGenerator.new()

	# let the seed change
	rng.randomize()
	rng.randi()
	rng.randi()

	var saved = rng.seed
	print('Current seed: ', saved)

	print('This seed produces:')
	print(rng.randf())
	print(rng.randf())

	rng.seed = saved
	print('Resetting the seed produces:')
	print(rng.randf())
	print(rng.randf())

Actual output:
Current seed:<PHONE_NUMBER>791200068
This seed produces:
0.823806
0.514134
Resetting the seed produces:
0.028601
0.02974

Expected output:
Current seed:<PHONE_NUMBER>791200068
This seed produces:
0.823806
0.514134
Resetting the seed produces:
0.823806
0.514134

Minimal reproduction project: N/A

PR #27171 introduced this behavior.

I thought that was reverted.  b5d9099626c4c180403baf0b75bd286a6b65c981

It's only reverted on the 3.1 branch. 😂

Oh right, it was left in the master, and 3.2 was the master back then.  Yeah, reverting it solves the issue.


Segmentation Faults 2017-05-16

Hello,
I was using American Fuzzy Lop (afl-fuzz) to fuzz input to the 8cc program on Linux. Is fixing the crashes from these input files something you're interested in? The input files can be found here: https://github.com/rwhitworth/8cc-fuzz.
The files can be executed as ./8cc -c id_filename to cause seg faults.
Let me know if I can provide any more information to help narrow down this issue.

Example valgrind output of a few items:
==1308769== Memcheck, a memory error detector
==1308769== Copyright (C) 2002-2013, and GNU GPL'd, by Julian Seward et al.
==1308769== Using Valgrind-3.10.0 and LibVEX; rerun with -h for copyright info
==1308769== Command: /root/8cc/8cc -c id:000000,sig:11,src:000000,op:flip1,pos:12
==1308769==
==1308769== Invalid read of size 8
==1308769==    at 0x44AA89: read_unary_deref (parse.c:1078)
==1308769==    by 0x44AA89: read_unary_expr (parse.c:1117)
==1308769==    by 0x44CEAC: read_cast_expr (parse.c:1152)
==1308769==    by 0x44D1D2: read_multiplicative_expr (parse.c:1156)
==1308769==    by 0x44D8A2: read_additive_expr (parse.c:1166)
==1308769==    by 0x44DDDD: read_shift_expr (parse.c:1175)
==1308769==    by 0x44E452: read_relational_expr (parse.c:1193)
==1308769==    by 0x44E452: read_equality_expr (parse.c:1205)
==1308769==    by 0x44EE62: read_bitand_expr (parse.c:1219)
==1308769==    by 0x44F1A2: read_bitxor_expr (parse.c:1226)
==1308769==    by 0x44F4E2: read_bitor_expr (parse.c:1233)
==1308769==    by 0x44F829: read_logand_expr (parse.c:1240)
==1308769==    by 0x44FBC9: read_logor_expr (parse.c:1247)
==1308769==    by 0x44FF6E: read_assignment_expr (parse.c:1277)
==1308769==  Address 0x8 is not stack'd, malloc'd or (recently) free'd
==1308769==
==1308769==
==1308769== Process terminating with default action of signal 11 (SIGSEGV)
==1308769==  Access not within mapped region at address 0x8
==1308769==    at 0x44AA89: read_unary_deref (parse.c:1078)
==1308769==    by 0x44AA89: read_unary_expr (parse.c:1117)
==1308769==    by 0x44CEAC: read_cast_expr (parse.c:1152)
==1308769==    by 0x44D1D2: read_multiplicative_expr (parse.c:1156)
==1308769==    by 0x44D8A2: read_additive_expr (parse.c:1166)
==1308769==    by 0x44DDDD: read_shift_expr (parse.c:1175)
==1308769==    by 0x44E452: read_relational_expr (parse.c:1193)
==1308769==    by 0x44E452: read_equality_expr (parse.c:1205)
==1308769==    by 0x44EE62: read_bitand_expr (parse.c:1219)
==1308769==    by 0x44F1A2: read_bitxor_expr (parse.c:1226)
==1308769==    by 0x44F4E2: read_bitor_expr (parse.c:1233)
==1308769==    by 0x44F829: read_logand_expr (parse.c:1240)
==1308769==    by 0x44FBC9: read_logor_expr (parse.c:1247)
==1308769==    by 0x44FF6E: read_assignment_expr (parse.c:1277)
==1308769==  If you believe this happened as a result of a stack
==1308769==  overflow in your program's main thread (unlikely but
==1308769==  possible), you can try to increase the size of the
==1308769==  main thread stack using the --main-stacksize= flag.
==1308769==  The main thread stack size used in this run was 8388608.
==1308769==
==1308769== HEAP SUMMARY:
==1308769==     in use at exit: 35,736 bytes in 779 blocks
==1308769==   total heap usage: 788 allocs, 9 frees, 39,242 bytes allocated
==1308769==
==1308769== LEAK SUMMARY:
==1308769==    definitely lost: 15,496 bytes in 373 blocks
==1308769==    indirectly lost: 1,472 bytes in 68 blocks
==1308769==      possibly lost: 0 bytes in 0 blocks
==1308769==    still reachable: 18,768 bytes in 338 blocks
==1308769==         suppressed: 0 bytes in 0 blocks
==1308769== Rerun with --leak-check=full to see details of leaked memory
==1308769==
==1308769== For counts of detected and suppressed errors, rerun with: -v
==1308769== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)

==1389328== Memcheck, a memory error detector
==1389328== Copyright (C) 2002-2013, and GNU GPL'd, by Julian Seward et al.
==1389328== Using Valgrind-3.10.0 and LibVEX; rerun with -h for copyright info
==1389328== Command: /root/8cc/8cc -c id:000001,sig:11,src:000000,op:flip1,pos:23
==1389328==
==1389328== Invalid read of size 8
==1389328==    at 0x44672C: binop (parse.c:577)
==1389328==    by 0x44DA29: read_additive_expr (parse.c:1168)
==1389328==    by 0x44DDDD: read_shift_expr (parse.c:1175)
==1389328==    by 0x44E452: read_relational_expr (parse.c:1193)
==1389328==    by 0x44E452: read_equality_expr (parse.c:1205)
==1389328==    by 0x44EE62: read_bitand_expr (parse.c:1219)
==1389328==    by 0x44F1A2: read_bitxor_expr (parse.c:1226)
==1389328==    by 0x44F4E2: read_bitor_expr (parse.c:1233)
==1389328==    by 0x44F829: read_logand_expr (parse.c:1240)
==1389328==    by 0x44FBC9: read_logor_expr (parse.c:1247)
==1389328==    by 0x44FF6E: read_assignment_expr (parse.c:1277)
==1389328==    by 0x4508E9: read_comma_expr (parse.c:1298)
==1389328==    by 0x4614E4: read_expr_opt (parse.c:1315)
==1389328==    by 0x4614E4: read_return_stmt (parse.c:2605)
==1389328==    by 0x4614E4: read_stmt (parse.c:2652)
==1389328==  Address 0x8 is not stack'd, malloc'd or (recently) free'd
==1389328==
==1389328==
==1389328== Process terminating with default action of signal 11 (SIGSEGV)
==1389328==  Access not within mapped region at address 0x8
==1389328==    at 0x44672C: binop (parse.c:577)
==1389328==    by 0x44DA29: read_additive_expr (parse.c:1168)
==1389328==    by 0x44DDDD: read_shift_expr (parse.c:1175)
==1389328==    by 0x44E452: read_relational_expr (parse.c:1193)
==1389328==    by 0x44E452: read_equality_expr (parse.c:1205)
==1389328==    by 0x44EE62: read_bitand_expr (parse.c:1219)
==1389328==    by 0x44F1A2: read_bitxor_expr (parse.c:1226)
==1389328==    by 0x44F4E2: read_bitor_expr (parse.c:1233)
==1389328==    by 0x44F829: read_logand_expr (parse.c:1240)
==1389328==    by 0x44FBC9: read_logor_expr (parse.c:1247)
==1389328==    by 0x44FF6E: read_assignment_expr (parse.c:1277)
==1389328==    by 0x4508E9: read_comma_expr (parse.c:1298)
==1389328==    by 0x4614E4: read_expr_opt (parse.c:1315)
==1389328==    by 0x4614E4: read_return_stmt (parse.c:2605)
==1389328==    by 0x4614E4: read_stmt (parse.c:2652)
==1389328==  If you believe this happened as a result of a stack
==1389328==  overflow in your program's main thread (unlikely but
==1389328==  possible), you can try to increase the size of the
==1389328==  main thread stack using the --main-stacksize= flag.
==1389328==  The main thread stack size used in this run was 8388608.
==1389328==
==1389328== HEAP SUMMARY:
==1389328==     in use at exit: 35,968 bytes in 784 blocks
==1389328==   total heap usage: 793 allocs, 9 frees, 39,474 bytes allocated
==1389328==
==1389328== LEAK SUMMARY:
==1389328==    definitely lost: 15,640 bytes in 376 blocks
==1389328==    indirectly lost: 1,480 bytes in 69 blocks
==1389328==      possibly lost: 0 bytes in 0 blocks
==1389328==    still reachable: 18,848 bytes in 339 blocks
==1389328==         suppressed: 0 bytes in 0 blocks
==1389328== Rerun with --leak-check=full to see details of leaked memory
==1389328==
==1389328== For counts of detected and suppressed errors, rerun with: -v
==1389328== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)

==1419017== Memcheck, a memory error detector
==1419017== Copyright (C) 2002-2013, and GNU GPL'd, by Julian Seward et al.
==1419017== Using Valgrind-3.10.0 and LibVEX; rerun with -h for copyright info
==1419017== Command: /root/8cc/8cc -c id:000003,sig:11,src:000000,op:flip2,pos:13
==1419017==
==1419017== Invalid read of size 8
==1419017==    at 0x4508F5: read_comma_expr (parse.c:1301)
==1419017==    by 0x461254: read_expr_opt (parse.c:1315)
==1419017==    by 0x461254: read_stmt (parse.c:2664)
==1419017==    by 0x46510C: read_decl_or_stmt (parse.c:2692)
==1419017==    by 0x465717: read_compound_stmt (parse.c:2676)
==1419017==    by 0x4662F1: read_func_body (parse.c:2263)
==1419017==    by 0x4662F1: read_funcdef (parse.c:2351)
==1419017==    by 0x4662F1: read_toplevels (parse.c:2708)
==1419017==    by 0x402940: main (main.c:182)
==1419017==  Address 0x8 is not stack'd, malloc'd or (recently) free'd
==1419017==
==1419017==
==1419017== Process terminating with default action of signal 11 (SIGSEGV)
==1419017==  Access not within mapped region at address 0x8
==1419017==    at 0x4508F5: read_comma_expr (parse.c:1301)
==1419017==    by 0x461254: read_expr_opt (parse.c:1315)
==1419017==    by 0x461254: read_stmt (parse.c:2664)
==1419017==    by 0x46510C: read_decl_or_stmt (parse.c:2692)
==1419017==    by 0x465717: read_compound_stmt (parse.c:2676)
==1419017==    by 0x4662F1: read_func_body (parse.c:2263)
==1419017==    by 0x4662F1: read_funcdef (parse.c:2351)
==1419017==    by 0x4662F1: read_toplevels (parse.c:2708)
==1419017==    by 0x402940: main (main.c:182)
==1419017==  If you believe this happened as a result of a stack
==1419017==  overflow in your program's main thread (unlikely but
==1419017==  possible), you can try to increase the size of the
==1419017==  main thread stack using the --main-stacksize= flag.
==1419017==  The main thread stack size used in this run was 8388608.
==1419017==
==1419017== HEAP SUMMARY:
==1419017==     in use at exit: 35,736 bytes in 779 blocks
==1419017==   total heap usage: 788 allocs, 9 frees, 39,242 bytes allocated
==1419017==
==1419017== LEAK SUMMARY:
==1419017==    definitely lost: 15,496 bytes in 373 blocks
==1419017==    indirectly lost: 1,472 bytes in 68 blocks
==1419017==      possibly lost: 0 bytes in 0 blocks
==1419017==    still reachable: 18,768 bytes in 338 blocks
==1419017==         suppressed: 0 bytes in 0 blocks
==1419017== Rerun with --leak-check=full to see details of leaked memory
==1419017==
==1419017== For counts of detected and suppressed errors, rerun with: -v
==1419017== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)

in case you feel bored: https://github.com/sabotage-linux/gettext-tiny/issues/11 ... i still dont have gcc with asan working on musl libc, and without asan fuzzing doesnt work too well.


UNKNOWN in rs2_get_stream_profiles(sensor:00000219E1CD0980): MFGetAttributeRatio(pMediaType, MF_MT_FRAME_RATE_RANGE_MIN, &frameRateMin.numerator, &frameRateMin.denominator) returned: HResult 0xc00d36e6: "无法找到请求的属性。

librealsense
2.55.1 RELEASE

OS
Windows

Name
Platform Camera

Serial Number
10400b6

Usb Type Descriptor
2.01

When I try to use our camera with realsense viewer, some errors occured. And I can view the RGB image with Window's camera setting. It  proves our camera is connected and the computer recognizes the camera. I want to know how to solve this problem.
UNKNOWN in rs2_get_stream_profiles(sensor:00000219E1CD0980):
MFGetAttributeRatio(pMediaType, MF_MT_FRAME_RATE_RANGE_MIN,
&frameRateMin.numerator, &frameRateMin.denominator) returned: HResult
0xc00d36e6: "无法找到请求的属性。"

Hi @LeaMaps  The Platform Camera is a non-RealSense RGB camera, typically a USB webcam or the built-in webcam of a laptop.  Such a camera may be viewed in the 'Camera' app of Windows but the Platform Camera mode of the RealSense Viewer will not work with all cameras.
For example, the built-in webcam of one laptop might work fine with it but the webcam on another laptop of a different make / model will not.  There is not a solution available if a particular webcam cannot be accessed by the Viewer as a Platform Camera, unfortunately.

I note that the bottom of your image says '515'.  It looks as though you are attempting to access a RealSense L515 camera in the Viewer but it is not being detected.  This is because support for L515 was removed from the current latest 2.55.1 version because it is a retired camera model.  If you use the previous 2.54.2 version then your L515 should be able to work with it.
https://github.com/IntelRealSense/librealsense/releases/tag/v2.54.2

Hi @LeaMaps The Platform Camera is a non-RealSense RGB camera, typically a USB webcam or the built-in webcam of a laptop. Such a camera may be viewed in the 'Camera' app of Windows but the Platform Camera mode of the RealSense Viewer will not work with all cameras.嗨，平台摄像头是非实感 RGB 摄像头，通常是 USB 网络摄像头或笔记本电脑的内置网络摄像头。可以在 Windows 的“相机”应用程序中查看此类相机，但实感查看器的平台相机模式不适用于所有相机。
For example, the built-in webcam of one laptop might work fine with it but the webcam on another laptop of a different make / model will not. There is not a solution available if a particular webcam cannot be accessed by the Viewer as a Platform Camera, unfortunately.例如，一台笔记本电脑的内置网络摄像头可能工作正常，但另一台不同品牌/型号的笔记本电脑上的网络摄像头则不行。不幸的是，如果查看器无法将特定网络摄像头作为平台摄像机访问，则没有可用的解决方案。
I note that the bottom of your image says '515'. It looks as though you are attempting to access a RealSense L515 camera in the Viewer but it is not being detected. This is because support for L515 was removed from the current latest 2.55.1 version because it is a retired camera model. If you use the previous 2.54.2 version then your L515 should be able to work with it.我注意到您图像的底部写着“515”。您似乎正在尝试访问查看器中的实感 L515 摄像头，但未检测到该摄像头。这是因为对 L515 的支持已从当前最新的 2.55.1 版本中删除，因为它是已停用的相机型号。如果您使用以前的 2.54.2 版本，那么您的 L515 应该能够使用它。
https://github.com/IntelRealSense/librealsense/releases/tag/v2.54.2

I have solved my problem, thanks for your help.

You are very welcome.  :)

Case closed due to solution achieved and no further comments received.


Missing pg_config causes installation failure when using pip

Issue description:
Installation fails for pip install singer-target-postgres when installing the dependency psycopg2 in an environment that doesn't have pg_config in the path.
Proposed solution:
Conditionally install the binary distribution (psycopg2-binary) if pg_config isn't found in the path.

After some more research it's clear that regardless of installation issues, we should only be using the sdist.
From the psycopg2 docs:

Note The psycopg2-binary package is meant for beginners to start playing with Python and PostgreSQL without the need to meet the build requirements.
If you are the maintainer of a published package depending on psycopg2 you shouldn’t use psycopg2-binary as a module dependency. For production use you are advised to use the source distribution.

Closing Issue

After some more research it's clear that regardless of installation issues, we should only be using the sdist.
From the psycopg2 docs:

Note The psycopg2-binary package is meant for beginners to start playing with Python and PostgreSQL without the need to meet the build requirements.
If you are the maintainer of a published package depending on psycopg2 you shouldn’t use psycopg2-binary as a module dependency. For production use you are advised to use the source distribution.

Hello, how did you solve it?

@INGCRENGIFO You need to ensure you have the postgres client installed.
If you're using a Mac you can use Brew: brew install postgres

on ubuntu, sudo apt install libpq-dev

How do we get this working on windows? I am getting this error when I try to pip install this package in windows.
Error: pg_config executable not found.


add csv or Google Sheets

I have that with privateGPT already, but it's not very good with csv files and is a bit slow perhaps. Can you beat it?
twitter: https://twitter.com/vagero4/status/1676978801383821312

@taranjeet in #161


offChain State does not update internal state

For a few weeks I have been doing on chain testing in my application that uses offChain state api. I use services in my app that send and settle the proofs I receive from users to Mina and this services work consistently.
However, after updating on offchain state, I realized that the api was not working correctly. When I tried to update again it after the updates were done, I was getting a root mismatch error and the only way to solve it was to restart the service.
I thought the problem might be that it was not settling and tested for that. After sending the update, I waited for it to settle completely, but the problem was the same. Then I console logged the states in some places on offchain-state.js and got the following results.
19127837625513839750015801518488884205754193410383643610887852957945537699566
first check false second check false
action state<PHONE_NUMBER>7403596221185729134339335640005846451227827507499404664500316550112
merkle map<PHONE_NUMBER>302605685996191473523237511494367078661562577361822805082477390442
map root<PHONE_NUMBER>302605685996191473523237511494367078661562577361822805082477390442 state root<PHONE_NUMBER>302605685996191473523237511494367078661562577361822805082477390442
first check true second check true
returning internal
Current session<PHONE_NUMBER>
2009824360  -><PHONE_NUMBER>
Generating proof
Transaction sent

## I waited for update and settlement here ##

19127837625513839750015801518488884205754193410383643610887852957945537699566
first check true second check true
returning internal
map root<PHONE_NUMBER>302605685996191473523237511494367078661562577361822805082477390442 state root<PHONE_NUMBER>4789886366259936965517333313478084681883682142698168018525779052913
Error: root mismatch
Field.assertEquals():<PHONE_NUMBER>302605685996191473523237511494367078661562577361822805082477390442 !=<PHONE_NUMBER>4789886366259936965517333313478084681883682142698168018525779052913

in the part
    let map = await Provable.witnessAsync(
      IndexedMerkleMapN,
      async () => (await merkleMaps()).merkleMap
    );

returns old map state and this causes root mismatch error, also I cannot figure out how to update this internal merkleMap.
the condition inside
       if (
        internal.merkleMap.root.toString() !== emptyMerkleMapRoot.toString() ||
        internal.valueMap.size > 0
      )

gives true || true despite of actual tree is updated.

@45930 we might want a method to explicitly fetch and build the latest merkle map

@kadirchan do you want to try a PR that exposes the behavior you want?
I think we need a public function that fetches the latest state and sets the internal state on the offchain state instance.
let { merkleMap, valueMap } = await fetchMerkleMap(
    height,
    internal.contract,
    actionState
  );
  internal.merkleMap = merkleMap;
  internal.valueMap = valueMap;

Something like ^^ but called on-demand by the developer.

@45930 yes of course. Something like explicitly callable fetchMerkleMap function will solve current problem.


[AutoPR billing/resource-manager] Swagger for Tenant Properties API (Do

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/5038

Will redo PR manually


bonsai sdk is using blocking reqwest which makes it panic in tokio runtime

Cannot drop a runtime in a context where blocking is not allowed. This happens when a runtime is dropped from within an asynchronous context.

We have a work around at: https://github.com/risc0/risc0/blob/main/bonsai/sdk/src/lib.rs#L22 you can enable the async flag. Would that be a reasonable workaround?

yes thanks @mothran I found that after raising the issue


chore: testing benchmark

Signed-off-by: Jaydip Gabani<EMAIL_ADDRESS>What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

/benchmark

/benchmark


Missing docs: exception.bugsnag_meta_data

This gem has undocumented way of adding tabs to exceptions which I found really useful and think deserves spotlight in official documentation.
Namely, you can create an bugsnag_meta_data method on any exception object, which will be used by bugsnag to create additional tabs, similar to how #add_tab works. This comes in handy in situations where Bugsnag.notify is called automatically, for example when using delayed_job.
Example:
class MyCustomError < StandardError
  attr_reader :metadata
  def initialize(message, metadata)
    super(message)
    @metadata = metadata
  end

  def bugsnag_meta_data
    {tabname: metadata}
  end
end

Bugsnag.notify(MyCustomError.new("Error message", value1: '1', value2: {nested: 3}))

Will create a tab named tabname with value1 and value2 listed in it.

Thanks for the report, @macobo! That's definitely something we should document.

Hi  @macobo, we've added some documentation for customising error reports as you've described that can be found here!

Perfect, thank you! :+1:


Update package.json

Updating compiler version to be the latest

This bumps the current version, but of course this isn't optimal...
Unfortunately, as I remember, the solc compile as a WASM module wasn't working with VSCode back then, otherwise this would be a way better option instead of having to bump it manually

@arthurshoppy Yeah, I saw that it's possible to install various npm modules for solidity compiler, and then import all of them and create a List to choose, but for now it solves a problem with latest solidity version


Update various deps to their latest commits.

Keeping dependencies up to date is generally useful, and I'm curious if this could help with CI flakes like those on https://github.com/iree-org/iree/actions/runs/9140881506/job/25134689319?pr=17425:
Cloning into '/runner-root/actions-runner/_work/iree/iree/third_party/flatcc'...
error: RPC failed; curl 16 Error in the HTTP2 framing layer
fatal: expected flush after ref listing
fatal: clone of 'https://github.com/dvidelabs/flatcc.git' into submodule path '/runner-root/actions-runner/_work/iree/iree/third_party/flatcc' failed
Failed to clone 'third_party/flatcc'. Retry scheduled
Cloning into '/runner-root/actions-runner/_work/iree/iree/third_party/flatcc'...
From https://github.com/google/benchmark
 * branch            1e96bb0ab5e758861f5bbbd4edbd0a8d9a2a7cae -> FETCH_HEAD
Submodule path 'third_party/benchmark': checked out '1e96bb0ab5e758861f5bbbd4edbd0a8d9a2a7cae'
From https://github.com/pytorch/cpuinfo
 * branch            b8b29a164e7704b75ad66b072aa2db[40](https://github.com/iree-org/iree/actions/runs/9140881506/job/25134689319?pr=17425#step:4:41)9cc941fd -> FETCH_HEAD
Submodule path 'third_party/cpuinfo': checked out 'b8b29a164e7704b75ad66b072aa2db409cc9[41](https://github.com/iree-org/iree/actions/runs/9140881506/job/25134689319?pr=17425#step:4:42)fd'
error: RPC failed; curl 16 Error in the HTTP2 framing layer
fatal: error reading section header 'acknowledgments'
fatal: Fetched in submodule path 'third_party/flatcc', but it did not contain 354a5f905162cf5ae3bdfbfbc9d6c57411ec3404. Direct fetching of that commit failed.

Reverted the updates to third_party/benchmark due to a new warning as error on riscv: https://github.com/iree-org/iree/actions/runs/9161931244/job/25188194861#step:7:533
FAILED: third_party/benchmark/src/CMakeFiles/benchmark.dir/sysinfo.cc.o
/usr/src/toolchain_iree/bin/clang++ --sysroot=/usr/src/toolchain_iree/sysroot -DBENCHMARK_HAS_PTHREAD_AFFINITY -DBENCHMARK_STATIC_DEFINE -DHAVE_POSIX_REGEX -DHAVE_PTHREAD_AFFINITY -DHAVE_STD_REGEX -DHAVE_STEADY_CLOCK -DHAVE_THREAD_SAFETY_ATTRIBUTES -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -I/work/third_party/benchmark/include -I/work/third_party/benchmark/src -O3       -march=rv64i2p1ma2p1f2p2d2p2c2p0 -mabi=lp64d    -Wall  -Wextra  -Wshadow  -Wfloat-equal  -Wold-style-cast  -Wconversion  -Werror  -Wsuggest-override  -pedantic  -pedantic-errors  -Wshorten-64-to-32  -fstrict-aliasing  -Wno-deprecated-declarations  -Wno-deprecated  -Wstrict-aliasing  -Wthread-safety -O2 -g  -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -std=c++11 -MD -MT third_party/benchmark/src/CMakeFiles/benchmark.dir/sysinfo.cc.o -MF third_party/benchmark/src/CMakeFiles/benchmark.dir/sysinfo.cc.o.d -o third_party/benchmark/src/CMakeFiles/benchmark.dir/sysinfo.cc.o -c /work/third_party/benchmark/src/sysinfo.cc
In file included from /work/third_party/benchmark/src/sysinfo.cc:78:
/work/third_party/benchmark/src/cycleclock.h:212:10: error: implicit conversion changes signedness: 'uint64_t' (aka 'unsigned long') to 'int64_t' (aka 'long') [-Werror,-Wsign-conversion]
  212 |   return cycles;
      |   ~~~~~~ ^~~~~~

and to third_party/pybind11 due to an error I don't understand: https://github.com/iree-org/iree/actions/runs/9162128475/job/25188773229#step:6:288
==================================== ERRORS ====================================
_____ ERROR collecting bindings/python/test/tools/compiler_tflite_test.py ______
ImportError while importing test module '/home/runner/work/iree/iree/compiler/bindings/python/test/tools/compiler_tflite_test.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
compiler/bindings/python/test/tools/compiler_tflite_test.py:13: in <module>
    from iree.compiler.tools.ir_tool import __main__ as ir_tool
.venv/lib/python3.11/site-packages/iree/compiler/tools/ir_tool/__main__.py:11: in <module>
    from ...api import Invocation, Session, Source, Output
.venv/lib/python3.11/site-packages/iree/compiler/api/__init__.py:26: in <module>
    from .ctypes_dl import (
.venv/lib/python3.11/site-packages/iree/compiler/api/ctypes_dl.py:513: in <module>
    _global_init = _GlobalInit()
.venv/lib/python3.11/site-packages/iree/compiler/api/ctypes_dl.py:501: in __init__
    _init_dylib()
.venv/lib/python3.11/site-packages/iree/compiler/api/ctypes_dl.py:40: in _init_dylib
    dylib_path = _probe_iree_compiler_dylib()
.venv/lib/python3.11/site-packages/iree/compiler/api/ctypes_dl.py:447: in _probe_iree_compiler_dylib
    from .. import _mlir_libs
.venv/lib/python3.11/site-packages/iree/compiler/_mlir_libs/__init__.py:180: in <module>
    _site_initialize()
.venv/lib/python3.11/site-packages/iree/compiler/_mlir_libs/__init__.py:78: in _site_initialize
    from ._mlir import ir
E   ImportError: cannot import name 'ir' from 'iree.compiler._mlir_libs._mlir' (unknown location)


Egress for data messages?

Hey! I'm building a web-app that uses the data messages bit quite heavily (along with audio conferencing). Although Egress for Audio was made pretty clear in the docs, I wanted to know if there's a way to listen to data messages published? I tried but couldn't find any documentation regarding it and it's something that would help me a lot.
I want to save the data messages being published asynchronously in my database so just wanted to know if there's a way to listen to them because if not, then the only way would be to set up a separate websocket server which would otherwise seem redundant.

Currently Egress does not export data messages separately. Your best bet is to connect to LiveKit as a server-side participant and save the messages that way.


Extension issue

Issue Type: Bug
Extension Name: gitlens
Extension Version: 11.0.0
OS Version: Linux x64 4.15.0-123-generic
VSCode version: 1.51.1

:warning: We have written the needed data into your clipboard. Please paste! :warning:
{
	"messages": [],
	"activationTimes": {
		"codeLoadingTime": 73,
		"activateCallTime": 1,
		"activateResolvedTime": 63,
		"activationReason": {
			"startup": false,
			"extensionId": {
				"value": "eamodio.gitlens",
				"_lower": "eamodio.gitlens"
			},
			"activationEvent": "onStartupFinished"
		}
	},
	"runtimeErrors": [
		{
			"name": "Error",
			"message": "No diff tool found"
		},
		{
			"name": "Error",
			"message": "No diff tool found"
		}
	]
}

I'm not sure what this issue is about.

It turned out to be some one-time problem and it didn't happen again.
Sorry for bothering you.


Extend Rack-Group Listing on Rack-View

Environment

Python version: 3.6
NetBox version: 2.5.2

Proposed Functionality
Extend the distinguish Rack-Group List Name with the SiteName on
dcim/racks/
dcim/rack-elevations/
for the Search-Box (Right Sidebar)

Use Case
If you build the same Rack-Group-Names per Site and want to Filter by the dcim/racks/ Site on the Right Side (Search-Bar) you see the Names of the Rack-Groups duplicated which is correct, since each site has the rack group name of the same name. With this Extension you could see the Parent-Side-Name of your assigned Rack-Group.

Database Changes
No.

External Dependencies
No.

Rack group is already available as a separate filter field. If selected, the rack field will be limited to racks assigned to the selected group.

This feature request is for build Distinguishable name inside the filter field.
Its not that I want to build something new.
Sry if my request isn't clear understanding.


Allow 'ArrayAccess' objects as secret.

The underlying JWT library can use ArrayAccess objects as
secrets. This patch relaxes the input validation so it is possible to
use this feature.

Quickly thinking I do not see any BC issues with this. So I guess this should be ok.

This can be merged?


SVG files not loading in dev environment

Hey all I'm having a problem loading svg files in a development environment.

When running in dev the webpack dll builds and emits the svg files (from a library) correctly with hashed names -> d6e2427c77ddcccb6d7a72d3b7431ffb.svg 4.33 kB [emitted]
When the file is requested in browser it returns with a 200 OK but the type is text/html and there is no data in the response
However when I run with production (npm run start:production) the correct type is returned from the request along with the right data and the image loads correctly.

I have not made any webpack changes that affect svg IE it is still uses file-loader:
{
	  test: /\.(eot|svg|ttf|woff|woff2)$/,
	  loader: 'file-loader',
}

What am I doing wrong here?
Versions

React-Boilerplate: 3.4.0 (modified)
Node/NPM: 6.11.1/5.3.0
Browser: Chrome 64

Im pretty sure that webpack is expecting an SVG font, if its an svg image (like anything other than a font), try and move svg to image loader
test: /\.(jpg|png|gif|svg|ico)$/,
use: [
  {
    loader: 'file-loader',
    options: {
      name: 'assets/images/[hash].[ext]',
    },
  },

hope this helps!


fix: karma.loaded() started too early (#2955)

Fix bug #2955 :

start karma.loaded() when modules are loaded
add a test for module based tests

I signed it!

The PR is blocked because it runs on old versions of chrome and nodejs, which i don't expected.

Do I need to remove the test just because it can only run on recent browser?
Could someone help me configure my "module" test for running only on latest Chrome?

It seems to me that this failing is not related to my developpement. Could someone check that?

It is working with firefox 58, but not anymore with firefox 59. Could some one trigger a build on the master to see if the problem is linked to my work or more general?

Waiting for #2957 to be confirmed or not, and to be fixed or not...

I have to stop this pull request because I used a wrong email in one of my commits. I will create a new one, referencing this one.
Sorry for inconvenience


Adjust selected text contrast in dark mode

Currently it is hard to detect which text is selected in input controls like OnyxInput, OnyxTextarea, OnyxSelect when darkmode is active:

The currently used token is --onyx-color-base-neutral-200
Info: text color as well as background color can be adjusted however you like.
https://developer.mozilla.org/en-US/docs/Web/CSS/::selection

In the figma library the default color 500 is used with an opacity of .30 (in darkmode) and .20 (in light mode).
Do we have to alignhere? Or what works best for dev?

Update: After a discussion in the onyx daily we detected, that this problem is only in read-only and disabled state. We decided to use the same marking color like with the default state (primary). Screenshot below.


Replay not responsive

Traceback (most recent call last):
  File "/nfs/xf11id/mc/envs/ophyd/lib/python2.7/site-packages/enaml/qt/qt_abstract_button.py", line 76, in on_clicked
    self.declaration.clicked(checked)
  File "/nfs/xf11id/mc/envs/ophyd/lib/python2.7/site-packages/enaml/core/declarative_meta.py", line 68, in declarative_change_handler
    engine.write(owner, change['name'], change)
  File "/nfs/xf11id/mc/envs/ophyd/lib/python2.7/site-packages/enaml/core/expression_engine.py", line 210, in write
    pair.writer(owner, name, change)
  File "/nfs/xf11id/mc/envs/ophyd/lib/python2.7/site-packages/enaml/core/standard_handlers.py", line 82, in __call__
    call_func(func, (), {}, scope)
  File "/home/xf11id/Repos/replay/replay/search/view.enaml", line 67, in <module>
    search_model.header = loop_item
  File "/home/xf11id/Repos/replay/replay/search/model.py", line 83, in new_run_header
    self.header = changed['value']
  File "/home/xf11id/Repos/replay/replay/search/model.py", line 108, in header_changed
    self.header_keys = header_keys
  File "/nfs/xf11id/mc/envs/ophyd/lib/python2.7/site-packages/enaml/core/standard_tracer.py", line 55, in __call__
    engine.update(owner, self.name)
  File "/nfs/xf11id/mc/envs/ophyd/lib/python2.7/site-packages/enaml/core/expression_engine.py", line 241, in update
    setattr(owner, name, pair.reader(owner, name))
  File "/nfs/xf11id/mc/envs/ophyd/lib/python2.7/site-packages/enaml/core/standard_handlers.py", line 101, in __call__
    return call_func(func, (tr,), {}, scope)
  File "/home/xf11id/Repos/replay/replay/search/view.enaml", line 142, in <module>
    objects << gen_objects(display_header_model.header_keys)
  File "/home/xf11id/Repos/replay/replay/search/view.enaml", line 154, in gen_objects
    objs.append(Label(text = key[1]))
  File "/nfs/xf11id/mc/envs/ophyd/lib/python2.7/site-packages/enaml/core/object.py", line 98, in __init__
    super(Object, self).__init__(**kwargs)
TypeError: The 'text' member on the 'Label' object must be of type 'unicode'. Got object of type 'NoneType' instead.

@afluerasu is this still a problem?


The pin definition of Wire.begin in M5Core2.cpp is in conflict

I think the wire.begin pin definition should have been PA_SDA/PA_SCL because of Unit's sketch compatibility, but it has the same pins as Wire1 that are in conflict.
I think the following pins are correct.
`
void M5Core2::begin(bool LCDEnable, bool SDEnable, bool SerialEnable, bool I2CEnable) {
.....
// I2C init
if (I2CEnable == true) {
//    Wire.begin(21, 22);
Wire.begin(32, 33);
}
`

Thank you for your help, we have fixed the problem.


Improve support for WMS  server 1.1.1

Improved the support for WMS 1.1.1 servers.
Three main changes:

In 1.1.1 and prior, 'SRS' must be used instead of 'CRS'. This is applicable for the following 2 cases:
a. GetMap request parameter
b. When reading the GetCapabilities response, the JSON contains the 'SRS' key instead of 'CRS'
The axis order in 1.1.1 is always x/longitude y/latitude.  In 1.3.0 it depends on the coord. sys. definition, for EPSG:4326, it must be x/latitude y/longitude.
The cursor position parameters passed to the 'GetFeatureInfo' request must be i/j for 1.3.0 and x/y for 1.1.1.

@Mergifyio backport release/3.1.x


README import typo

There was a typo on the README when specified to import the Hello.tsx file in the index.tsx file. It is not necessary to put the file extension .tsx when importing making it enough to have './components/Hello'

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Thanks!


Is it possible to generate Diagrams from FSM code?

Hello @eram, I really like the API design of your "typescript-fsm" library. It looks simple, yet powerful. I was wondering if it would be possible to generate the diagram of your "Basic Example" from the code?

@bennycode something like teaching chatGPT to generate a state-changing mermaid diagram?

for example, i ask chat:
pls create a mermaid state diagram for the following state machine:
// these are the states and events for the door
enum States { closing = 0, closed, opening, opened, broken };
enum Events { open = 100, openComplete, close, closeComplete, break };

// lets define the transitions that will govern the state-machine
const transitions = [
  /* fromState        event                 toState         callback */
  t(States.closed,    Events.opened,        States.opening, onOpen),
  t(States.opening,   Events.openComplete,  States.opened,  justLog),
  t(States.opened,    Events.close,         States.closing, onClose),
  t(States.closing,   Events.closeComplete, States.closed,  justLog),
  t(States.closed,    Events.break,         States.broken,  justLog),
  t(States.opened,    Events.break,         States.broken,  justLog),
  t(States.opening,   Events.break,         States.broken,  justLog),
  t(States.closing,   Events.break,         States.broken,  justLog),
];

and i get an correct answer:
stateDiagram
    [*] --> closed
    closed --> opening : open
    opening --> opened : openComplete
    opened --> closing : close
    closing --> closed : closeComplete
    closed --> broken : break
    opened --> broken : break
    opening --> broken : break
    closing --> broken : break

That's cool! Preferably I would like to get Markdown code (using Mermaid syntax) directly from your library. With using TypeScript for code analysis this should be possible and would be a kick-ass feature for this lib! :D
stateDiagram
    [*] --> closed
    closed --> opening : open
    opening --> opened : openComplete
    opened --> closing : close
    closing --> closed : closeComplete
    closed --> broken : break
    opened --> broken : break
    opening --> broken : break
    closing --> broken : break

more than happy for you to send a PR with a toMermaid() function that outputs the Mermaid state diagram as a string.

What do we think of something like this?
// Function to generate the Mermaid.js diagram code
export function generateMermaidDiagram(
  transitions: ITransition<States, Events, () => void>[],
  title?: string
) {
  let diagram = "stateDiagram-v2\n";

  if (title) {
    diagram = `---\ntitle: ${title}\n---\n${diagram}`;
  }

  diagram += `  [*] --> ${transitions[0].fromState}\n`;

  // Loop over transitions and generate the appropriate Mermaid code
  transitions.forEach(transition => {
    const fromState = States[transition.fromState];
    const toState = States[transition.toState];
    const event = Events[transition.event];

    diagram += `  ${fromState} --> ${toState}: ${event}\n`;
  });

  diagram += `  ${transitions[transitions.length - 1].toState} --> [*]\n`;

  return diagram;
}

It's also important to label your enums with strings instead of numbers like the example shows

cool >> send a PR.

make diagram an array and join it with "\n" in the end: diagram.join("\n");
in typescript you don't need those strings added to the enum. it's built-in the language (look at the generated JS code)

But when I had the enum as numbers then when an error throws for an invalid transition, it shows an un-helpful message

When I switched to using strings, then I got an error message that helped me find the problem.

Of course, I don't mind you adding strings to enums in your code just inside this repo.

Do you mean, you would like:

The README to stay with integer enums?
Just have my the test door class use the strings so the toMermaid tests work?


Allow an option to only show courses with room available

Sometimes, when people are looking for courses to take, they only want to see ones that have space in one of the sections. Should be relatively easy to implement.

I'll take a look at this!


Contribute Python script update

Related PR: https://github.com/Itseez/opencv/pull/3887

Merged: https://github.com/Itseez/opencv/pull/3887#issuecomment-88409654

:+1:


Issue found on page 'Unnesting': typos in max depth section

Page URL: https://duckdb.org/docs/sql/query_syntax/unnest#seeting-the-maximum-depth-of-unnesting
Typo in the heading.  Seeting -> Setting
Also the second sentence has a typo: unnestig-> unnesting

Thanks!


commits outputting incorrect data

I'm getting strange data out of the series of commits thats difficult to describe, so I'll just pastebucket the command history.

@JonathanFraser sorry you ran into this, that is some strange output. I'm going to take a crack at reporting this locally and see if I can figure out what's going on. Will report back.

and it just go weirder, I did a cat again on the file, without any additional commits and got a larger output
jfraser@ubunutVirt:/pfs/test$ cat a01f9e808b41461c9516fb29637a3f49/a 1 2 3 2 4 2 3 2 5 2 3 2 4 2 3 2

What happens if you do pachctl get-file test a01f9e808b41461c9516fb29637a3f49 a? I'm wondering if maybe the fuse layer is doing something weird.

@jdoliner same output

Alright I got this working locally, I think what's going on here is that the semantics of the > operator in shell don't quite play nice with our fuse layer. The command echo 3 > ... sends the PutFile request to pachd with the data 3\n2\n... very strange.
@tv42 any ideas why we'd see this behavior? My guess is that we might need to make our fuse layer open files in a non seekable mode but that's just a guess.

For the time being, I think the easiest way to sidestep this problem would be to just use pachctl for loading data.

Shell echo a >f is just a Setattr for truncating and then Write at offfset 0. Seekability doesn't really enter that picture.. perhaps you're not handling the truncate right?
That you're getting a write error there means your fuse handlers are returning errors. What, why? Is this because of the write-only nature of your open commits? Is it actually write-once?
The data being corrupted, especially the repeating 2 in 1232, almost must be something in the storage backend (the handling of the sharded blocks?).
You can see tons more debug by enabling debug in https://godoc.org/bazil.org/fuse/fs#Config or https://godoc.org/bazil.org/fuse#Debug

@jdoliner sure, but for the containers running partial jobs how does that work?

I'm also getting this error is a decrease the pachd replicas down to 1.

@tv42 I'm pretty sure this is in fuse and has to do with the reusing of the message buffers, these strange values are being handed directly to the files Write method.

@JonathanFraser Show me.

For containers using pachctl isn't a great option, we're going to try to get these fuse bugs worked out asap.

I'm also getting this error is a decrease the pachd replicas down to 1.

Little confused by what this means, would you mind clarifying?
@tv42 Yup seekability doesn't come into this, my mistake. I think it's likely we're not handling the truncate properly. I've got a test that exposes this error and I'm going to turn on debugging to see if it shows what we want it to.

This could be a misinterpretation of what I understand should happen but I put a log entry followed by a panic into the Write which is called directly by the fuse bindings
data
This report is in response to echo 5 > file
Although its entirely possible I might be missing something.

Alright here's the output:
out.txt
This is from a test that does:
StartCommit
echo 1 >
echo 2 >
FinishCommit
StartCommit
echo 3 >

the weird part is the second write has the data 3\n2\n rather than the expected 3\n.
This test is available in the issue_270 branch (there's enough overlap between this issue and 270 that I'm working on both in the same place). It's called Test296.

Looking into fuse.go when generating the Write request there is an explicit check that the buffer is not less than in.Size but it doesn't seem to care that it might be larger.

@jdoliner Looks like the file wasn't truncated, only overwritten. The 3\n goes on top of the 1\n.

And the 2\n goes after the 1\n, not overwriting, because at that point the kernel still knows the file contents; the FinishCommit thing probably flushes that out.

@tv42 I'm kind of confused I think you're saying that the kernel is storing the contents of the file and thinks that the echo 3 >... should result in the file having the contents 3\n2\n but that seems weird because isn't the expect after that command that the file will just contain 3\n.
Is there anything we can do to get it so that the kernel sends us that write 3\n instead of what we're getting now?

The kernel holding on to it also seems weird because from the perspective of the file-system I'm writing to a new distinct file each time (as seen here).

Okay now there's multiple scenarios in flight, this gets confusing.

Here are the facts:

you are using page cache backed files (no fuse.OpenDirectIO visible); that means kernel writes a page at a time
file.Setattr is not implemented, hence truncation does not do anything
your file.Write does not pass request.Offset to the pfsclient.Putfile, hence the storage backend thinks all writes are appends

This combination results in the kernel page cache contents differing from what your storage backend thinks they are.

What's the correct way to set fuse.OpenDirectIO I'm noticing that in my Open callback the response object is nil I feel like I must be missing something kind of obvious here.

resp is nil in your Open handler? I find that very hard to believe. Show me.
Here's an example using fuse.OpenDirectIO:
func (f *myFile) Open(ctx context.Context, req *fuse.OpenRequest, resp *fuse.OpenResponse) (fs.Handle, error) {
        resp.Flags |= fuse.OpenDirectIO
        ...
}

Whoops, I figured it out I was doing something pretty silly.
I just tried setting fuse.OpenDirectIO and that seems to fix the problem.

@jdoliner does it also fix it for test script.

@JonathanFraser yup!! just ran it

@jdoliner huh, ok because at no point was I writing to same file twice and yet DirectIO fixed it. Glad it's fixed but damned if I understand why.

Update on this. We have a PR fixing this in review.
We've also added a regression test for this issue: Test296

Fix for this has been merged into master.
Thanks for bearing with us while we got it dealt with and don't hesitate to reopen if there are other unexpected quirks in the behavior.


Where primitives

Related to Issue #26. I added intersect (slice vs slice compare), and a few where functions that utilize it to match.

:+1:

@dataferret just saw your comment on #26. I just pushed an old commit I had locally for using Where from hugolib, but I think just implementing it directly like you did is better.

This is nice.  What do you think about some slightly different names?

whereSomeMatch -> whereAny
whereRequires -> whereAll

Those names sound good.  You want to do it your end or should I resubmit the PR?

Merged w/ bcddaab30.  Thanks!


GB country code not supported

It seems that you have individual codes for Scotland, England, Wales and Northern Ireland, which is nice, but the overall "United Kingdom of Great Britain and Northern Ireland" country code you're  using is GB-UKM or rather the overall code for GB doesn't seem to be supported as listed under ISO 3166-1 alpha-2, see here: https://www.iban.com/country-codes
Please check all that apply

[ ] visual bug
[x] functional bug
[x] able to consistently reproduce

Expected Behavior

Using GB as the country code should result in the United Kingdom of Great Britain and Northern Ireland flag to be shown.
Current Behavior

Currently, using GB-UKM is the closest match.
Possible Solution

Change the country code to reflect the ISO standard.
Steps to Reproduce

1 Go here: https://flagpack.xyz/docs/flag-index/
2 Search for GB
3 Find GB-* instead of GB.
Context

I'm getting the country codes from a database according to the ISO standard. Therefore a specific hack for GB isn't something that I'd want to add.
Your Environment

Version used: 1.1.2
Browser Name and version: Chrome 91.0.4472.114
Operating System and version (desktop or mobile): Windows

In addition the Alpha 3 variant GBR is also not supported.

Using GBR-UKM and it's variants were are solution to both support the flag for United Kingdom aswell as England, Scotland, Wales and Northern Ireland. These are part of the ISO 3166 subset, ISO 3166-2:GB which we are planning to continue to support in our release of Flagpack. However I do concede that given our ISO 3166 policy we should definitely support both the ISO 3166 alongside the 3166-2:GB to cover all bases. This is especially true now that we're working on having Flagpack treeshakable. You can expect these changes to be part of the next major release of Flagpack.


The command line args for dotnet.exe should be flexible and extensible.

For example, the /log option should be available for all compilation targets and the required ordering of arguments should be less strict.

This is done.


ResetLastError method does not work

https://github.com/microsoft/PowerPlatform-DataverseServiceClient/blob/07b3400f94af784f12e488038222a2ef538321ab/src/GeneralTools/DataverseClient/Client/DataverseTraceLogger.cs#L96-L102
String is immutable. When you delete the LastError field, it is not deleted, but a new line is created in which there are no characters, that is, an empty string. To fix this, you must return the result of the Remove method in the LastError field.
base.LastError = base.LastError.Remove(0, LastError.Length - 1);

This has been fixed by the team and will be in the next drop/.


⚠ ClamAV has degraded performance

In bce1cfd, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 79 ms

Resolved: ClamAV performance has improved in 629ecdf.


custom cni (disable flannel)

According to https://docs.k3s.io/installation/network-options#custom-cni if we want to install a custom CNI, we need to pass --flannel-backend=none.
In order to do that, we need to surface the config in K3sServerConfig and in the relevant CRDs
type K3sServerConfig struct {
	DisableCloudController    bool     `json:"disable-cloud-controller,omitempty"`
	KubeAPIServerArgs         []string `json:"kube-apiserver-arg,omitempty"`
	KubeControllerManagerArgs []string `json:"kube-controller-manager-arg,omitempty"`
	TLSSan                    []string `json:"tls-san,omitempty"`
....
}

sgtm

You can do this via the files section pretty easily:
    files:
    - content: |
        flannel-backend: none
      owner: root:root
      path: /etc/rancher/k3s/config.yaml.d/disable-flannel.yaml

I think we could probably simplify this though with a property  so that we can drive these things a bit easier then having to hack it together via the files section.
flannelBackend: None
disableNetworkPolicy: true
disableKubeProxy: true

is it possible to disable flannel on an already existing k3s cluster ? and then install another plugin, like calico ?