replace pegdown to markdown zeppelin interpreter

What is this PR for?
I was change markdown render librarry for Jupyter note convertor.
currently, we can got a same result for markdown.
What type of PR is it?
Improvement
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2824
How should this be tested?

build jupyter module
mvn clean package -DskipTests -pl 'zeppelin-jupyter' --am
cd zeppelin-jupyter/target
java -classpath zeppelin-jupyter-0.8.0-SNAPSHOT.jar org.apache.zeppelin.jupyter.JupyterUtil -i {your ipynb note file path!/getting_started.ipynb
(good sample : go to sample
get a note.json and import to zeppelin on frontend!
enjoy

Screenshots (if appropriate)
problem

after

Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

@cloverhearts Thanks the the improvement!
@felixcheung I think title of this PR little bit misleading. This does not change parser of existing markdown interpreter, but change Jupyter notebook converter use Zeppelin-Interpreter module to parse markdown, instead of directly call pegdown parser.

ah yes, jupyter converter doesn't have doc.

Is there any plan to integrate jupyter converter into zeppelin UI (like import from jupyter note) ? Otherwise I will doubt how many people will use this feature.

BTW, it seems pegdown is duplicated according its official github repo. https://github.com/sirthias/pegdown
We need to switch to flexmark-java which pegdown suggests for users.

Is there any plan to integrate jupyter converter into zeppelin UI (like import from jupyter note) ? Otherwise I will doubt how many people will use this feature.

Right, this can be the next step

BTW, it seems pegdown is duplicated according its official github repo. https://github.com/sirthias/pegdown

Good to know!

@cloverhearts Test fails with
Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.714 sec <<< FAILURE! - in org.apache.zeppelin.jupyter.nbformat.JupyterUtilTest
getNoteAndVerifyData(org.apache.zeppelin.jupyter.nbformat.JupyterUtilTest)  Time elapsed: 0.141 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.apache.zeppelin.jupyter.nbformat.JupyterUtilTest.getNoteAndVerifyData(JupyterUtilTest.java:89)

Results :

Failed tests:
  JupyterUtilTest.getNoteAndVerifyData:89 null

Tests run: 3, Failures: 1, Errors: 0, Skipped: 0

Could you take a look?

Sorry for the delay.
@Leemoonsoo I will fix it.

https://travis-ci.org/cloverhearts/zeppelin
ci pass :)

CI went green https://travis-ci.org/cloverhearts/zeppelin/builds/262539649.
LGTM and merge to master if no further comment.


feat(pixels): add my new pixel (16, 39)

Checklist

[x] I ran npm test locally and it passed without errors.

[x] I only edited the _data/pixels.json file.

[x] I entered the username in the pixels.json that I'm also using to create this pull request.
[x] I acknowledge that all my contributions will be made under the project's license.

@dkundel


[BEAM-4833][WIP] Add support for user req.txt for portable python

Attempts to make it easier for folks to add their own custom requirements for use with Python and the portable runners. Some alternative options exist that could also make it easier, e.g. adding a python or shell script which generates a docker file based on the "vanilla" one as the starting point (or similar gradle target), or not doing this at all.

Follow this checklist to help us incorporate your contribution quickly and easily:

[ X ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[  ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---
---

SUCCESS
--none--

I am skipping the review for now since it is tagged WIP. Please ping when it is ready.

re-ping, sorry for the WIP title, was for the first draft (now that it's refactored into 2 files ready for review).

Gentle ping @aaltay ?

and @charlesccychen


semaphore / concurrency

php-solid-server is failing the new concurrency tests that were added in solid-crud-tests v5.1.0.
What these tests do is send 10 PUT requests for the same resource at the same time, with If-None-Match: * header.
This means only 1 of them should return a 201 and the other 9 should return 412 Precondition Failed.
Looking at the code, it does a has check first and then a write. Does FlySystem support something like an atomic WriteIfNotExists or something like Lock?

Hm, doesn't seem like it does - https://github.com/thephpleague/flysystem/search?q=atomic&type=issues

There is the ability to use locks with the Local adapter which is what we currently use.
That might cause problems later, if/when we ever decide to (also?) support other adapters, but for now it should not cause trouble...

Looks like we are still using FlySystem v1, which does seem to have a put method. In v2, this has been changed to deterministic writes. We might be able to change the logic as to not use has and allow FlySystem to handle the fallout? :thinking:  Still feel like I'm missing something, though...


Using .perform() on Actions in Node.js causes "Unrecognized command: actions"

I’m trying to automate MS Word with WinAppDriver, so far I’ve been able to proceed with the most of the test flow but double clicking just doesn’t seem to work. Is Actions even implemented in WinAppDriver? How can I perform Double Click?
I’m using Node.js with Appium and trying to Double Click with Actions:

let e = await driver.findElement(By2.nativeName("This PC"));
await driver.actions().doubleClick(e).perform();

..but it produces error: (node:21168) UnhandledPromiseRejectionWarning: UnknownCommandError: Unrecognized command: actions
Which is odd because Actions object is obtained ok with this line:

let a = driver.actions();

However trying to actually perform the action:

await a. doubleClick (e).perform();

causes the error:
(node:4232) UnhandledPromiseRejectionWarning: UnknownCommandError: Unrecognized command: actions
at buildRequest (c:\Testing\WinApp\node_modules\selenium-webdriver\lib\http.js:477:9)

at Executor.execute (c:\Testing\WinApp\node_modules\selenium-webdriver\lib\http.js:555:19)

at WebDriver.execute (c:\Testing\WinApp\node_modules\selenium-webdriver\lib\webdriver.js:731:38)

at processTicksAndRejections (internal/process/task_queues.js:93:5)

at async Actions.perform (c:\Testing\WinApp\node_modules\selenium-webdriver\lib\input.js:886:7)

at async c:\Testing\WinApp\Test.js:33:5

Thank you, Tree55Topz, however the code you provided is in C# and as I stated before I'm using Node.js
I don't even have session, but anyway I tried this:

let e = await driver.findElement(By2.nativeName("This PC"));
driver.Mouse.MouseMove(e.coordinates);
driver.Mouse.DoubleClick(null);

and it gave me:

(node:26508) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'MouseMove' of undefined

So my question still remains: how can I achieve this with Node.js and selenium-appium ?

const { driver, By2, windowsAppDriverCapabilities } = require("selenium-appium");
How can I import this session ?
...and what I was doing wrong in my original code that it complained about
(node:4232) UnhandledPromiseRejectionWarning: UnknownCommandError: Unrecognized command: actions

We automated a Legacy Win32 app successfully using C# and Windriver App. Everything was ok till we had to port our solution to Node.js using Typescript. Initial setup was ok but at this point we are also stuck.
await driver.actions({ async: true, bridge: true }).move({ x: 10, y: 10, origin: element }).perform();
The exeption we are facing is
C:\workspace\node_modules\selenium-webdriver\lib\http.js:477   throw new error.UnknownCommandError(         ^ UnknownCommandError: Unrecognized command: actions     at buildRequest (C:\workspace\node_modules\selenium-webdriver\lib\http.js:477:9)     at Executor.execute (C:\workspace\node_modules\selenium-webdriver\lib\http.js:556:19)     at WebDriver.execute (C:\workspace\node_modules\selenium-webdriver\lib\webdriver.js:731:38)     at processTicksAndRejections (node:internal/process/task_queues:96:5)     at async Actions.perform (C:\workspace\node_modules\selenium-webdriver\lib\input.js:878:5)     at async Test.mainFormWindow (C:\workspace\src\Test.ts:49:11)     at async Test.test (C:\workspace\src\Test.ts:27:7) {   remoteStacktrace: '''
our package.json looks like this
{   "name": "workspace",   "version": "1.0.0",   "description": "",   "main": "index.js",   "scripts": {     "test": "echo \"Error: no test specified\" && exit 1"   },   "keywords": [],   "author": "",   "license": "ISC",   "devDependencies": {     "@babel/cli": "^7.15.7",     "@babel/core": "^7.15.5",     "@babel/preset-env": "^7.15.6",     "@types/node": "^16.10.1",     "@types/selenium-webdriver": "^4.0.15",     "@typescript-eslint/parser": "^4.32.0",     "eslint": "^7.32.0",     "selenium-appium": "^1.0.2",     "selenium-webdriver": "^4.0.0-rc-1",     "ts-node": "^10.2.1",     "tslib": "^2.3.1",     "typescript": "^4.4.3"   } }
any suggestion? pls.


Memory-mapped dromajo checkpoint

This requires work in both dromajo and BP.
Essentially, we have a memory-mapped register which causes dromajo to drop a checkpoint and terminate. We could use this to automatically checkpoint at Linux boot, so we can run benchmarks in sim starting immediately afterwards, etc.

Great feature!
On Fri, Dec 4, 2020 at 1:03 PM Dan Petrisko<EMAIL_ADDRESS>wrote:

This requires work in both dromajo and BP.
Essentially, we have a memory-mapped register which causes dromajo to drop
a checkpoint and terminate. We could use this to automatically checkpoint
at Linux boot, so we can run benchmarks in sim starting immediately
afterwards, etc.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/black-parrot/black-parrot/issues/698, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEFG5AGS5ZXNJJUHS7FFA43STFFCHANCNFSM4UN6OMDQ
.


Bug: Continuous logging of This plugin generated a warning from the characteristic 'Current Ambient Light Level': characteristic was supplied illegal value

Describe the Bug
My homebridge generates the following warning message every second. When I go the the provided url https://homebridge.io/w/JtMGR. It says this is slowing down my homebridge and I should inform the plugin developer for this. Disabling logging did not work for the plugin. Please advise on how to stop this warning...
[21/10/2024, 10:14:03] [@switchbot/homebridge-switchbot] This plugin generated a warning from the characteristic 'Current Ambient Light Level': characteristic was supplied illegal value: number 18000000 exceeded maximum of 100000. See https://homebridge.io/w/JtMGR for more info.
To Reproduce
It started happening after I installed the Switchbot plugin to my homebridge
Expected Behavior
switchbot plugin should not generate that frequent warning message or if there is an issue with the sensor it can be fixed.
Relevant Log Output
[21/10/2024, 10:14:03] [@switchbot/homebridge-switchbot] This plugin generated a warning from the characteristic 'Current Ambient Light Level': characteristic was supplied illegal value: number 18000000 exceeded maximum of 100000. See https://homebridge.io/w/JtMGR for more info.
[21/10/2024, 10:14:03] [@switchbot/homebridge-switchbot] Error:
    at CurrentAmbientLightLevel.Characteristic.characteristicWarning (/var/lib/homebridge/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Characteristic.ts:3016:105)
    at CurrentAmbientLightLevel.Characteristic.validateUserInput (/var/lib/homebridge/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Characteristic.ts:2932:14)
    at CurrentAmbientLightLevel.Characteristic.updateValue (/var/lib/homebridge/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Characteristic.ts:2333:20)
    at LightSensor.Service.updateCharacteristic (/var/lib/homebridge/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Service.ts:804:35)
    at Motion.updateCharacteristic (file:///var/lib/homebridge/node_modules/@switchbot/homebridge-switchbot/src/device/device.ts:420:15)
    at Motion.updateHomeKitCharacteristics (file:///var/lib/homebridge/node_modules/@switchbot/homebridge-switchbot/src/device/motion.ts:355:7)
    at Object.platform.bleEventHandler.<computed> [as d9:76:2a:ec:38:b2] (file:///var/lib/homebridge/node_modules/@switchbot/homebridge-switchbot/src/device/motion.ts:291:13)
[21/10/2024, 10:14:03] [SwitchBot] Motion Sensor: Hareket updateCharacteristic CurrentAmbientLightLevel: 18000000
[21/10/2024, 10:14:03] [SwitchBot] [DEBUG] Motion Sensor: Hareket CurrentAmbientLightLevel context before: 18000000
[21/10/2024, 10:14:03] [SwitchBot] [DEBUG] Motion Sensor: Hareket CurrentAmbientLightLevel context after: 18000000

Config for homebridge-switchbot
{
            "name": "SwitchBot",
            "credentials": {
                "token": "blahblah",
                "secret": "blahblahblah",
                "notice": "Keep your Token & Secret a secret!"
            },
            "options": {
                "BLE": true,
                "discoverBLE": true,
                "disableLogsforBLE": true,
                "disableLogsforOpenAPI": true,
                "logging": "none"
            },
            "platform": "SwitchBot"
        }

Screenshots
No response
Device and Model
Raspberry Pi4 for Homebridge, Apparently the issue looks on Switchbot Motion Sensor
Node.js Version
v20.18.0
NPM Version
v20.18.0
Homebridge Version
v1.8.4
Homebridge Switchbot Plugin Version
v4.0.0
Homebridge Config UI X Plugin Version
v4.62.0
Operating System
Debian GNU/Linux Bookworm (12)

Closing the bugs since changing the battery of the Motion Detector sensor has fixed the problem.

Reopened the issue since after replacing the battery after a while logs came back again...


Feature/logging

Create a static logger to add some information
Configurable debug mode.
Really not perfect but it can help to see what's going on when refresh tickets.

Thank you for this. Hope to use it soon to finally solve the problems in #26

Hi @lonix1,
I create I release on my fork for a new version with this fix and some new features (Markdown render, Labels views, etc.) here : https://github.com/MaxenceG2M/Gitea-VSCode/releases/tag/2.0.0-a
Maybe, waiting for IJustDev, you can download an install manually the vsix file?
HtH

Awesome, thanks!
I hope IJustDev can merge it one day soon.

This day is today! Sorry for letting this rest that long


wasm: scheduling of JavaScript callbacks is not fair

What version of Go are you using (go version)?
go version go1.11 linux/amd64
Does this issue reproduce with the latest release?
yes
Description
I ran the webassembly benchmark in https://djhworld.github.io/post/2018/09/21/i-ported-my-gameboy-color-emulator-to-webassembly/ and as also noted on that page, the benchmark does not properly process keyboard input on chrome. See https://bugs.chromium.org/p/v8/issues/detail?id=8227 for the v8 tracking bug.
Due to a performance issue in v8, the compiled go code runs slower in v8 than firefox. As a consequence, there is more pressure on the go scheduler. In particular, there is nearly always a go-routine ready to be executed with very few idle pauses. Looking at the scheduler implementation at
https://github.com/golang/go/blob/eae5fc88c13d6902a7fe9c595fb02155eb037cbe/src/runtime/proc.go#L2368
this leads to starvation of the go-routines that are waiting for a callback from java-script. In case of the gameboy emulator, this means that no more I/O events are being processed.

This is in some way related to https://github.com/golang/go/issues/26045?

Possibly. But I am not very clear on what exactly this issue tries to resolve. Does pauseSchedulerUntilCallback performs a STW-like action where unless the callback hasn't happened, no other goroutine can execute ?
Otherwise, I don't see a reason other goroutines will still wait for a callback from js.

The issue I am seeing here is not that go-routines cannot run while we wait for a callback, but that callbacks do not happen until no other go-routine runs. I just briefly looked at the runtime and might have missed something. But this is how I understand it:
Go (running on top of WebAssembly) can only receive callbacks from JavaScript if the WebAssembly runtime returns to the event loop. This is facilitated by pauseSchedulerUntilCallback, which in the go-runtime for JavaScript calls pause if any callbacks from JavaScript are potentially pending, that is a callback handler has been registered before. I looked at
https://github.com/golang/go/blob/50bd1c4d4eb4fac8ddeb5f063c099daccfb71b26/src/runtime/lock_js.go#L148
The call to pause will fully unwind the stack and return from WebAssembly back to JavaScript land.
https://github.com/golang/go/blob/50bd1c4d4eb4fac8ddeb5f063c099daccfb71b26/src/runtime/rt0_js_wasm.s#L72
Is there another path to fully unwind and return to JavaScript that I have missed?

/cc @neelance

Yes, giving back execution from Go (WebAssembly) to JavaScript is a "stop the world" action for Go. No goroutine will run until a callback invokes Go code (user action, timer, etc.). Since we want all Go code to run which is not waiting for such callbacks, we give back execution to JS only if ALL goroutines are asleep. If your Go code always has something to do, execution will never be passed back to JS, so user events will not be processed.
This is the current situation. Maybe we could extend the scheduler so it periodically gives back execution to JS, even if there are still runnable goroutines.
This somewhat depends on #26045.

@neelance - Just wanted to check in on this. Now that #26045 is resolved, has this situation improved, or it still needs further work ?

I think this needs further work. Most likely it will get resolved when we add WebAssembly threads.

@neelance I think I'm running into this same issue, but I'm a bit confused by your explanation. How are goroutines scheduled in the browser environment? If there are 3 pending goroutines, does this equate to 3 pending events in the event queue? If it does, shouldn't an I/O event simply take its place in the event queue after the pending goroutines?

No, goroutines are not mapped to the event queue. If there are still goroutines awake, then the event queue will not get processed.

Thanks for responding!
What constitutes "awake"? If one goroutine is blocked on a channel read and another is sleeping via time.Sleep, will Go immediately relinquish control to JavaScript to process pending events?


blocked by CORS policy

When I try to watch the demo https://webclient.prismarine.js.org/ I get an error in the console
connecting to <IP_ADDRESS> 10000 with lastuniverse

index.js?d62517f731b9fdfdf7c8:1520 using proxy pproxy.rom1504.fr 443

Access to XMLHttpRequest at 'https://pproxy.rom1504.fr/api/vm/net/connect' from origin 'https://webclient.prismarine.js.org' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource.

looks like that server is down

host own proxy

or create your page

Proxy seems to be back up; closing this issue. If it's not ping me and I'll re-open it


Implement automatic version number increments by setting the "minor" part of the version number equal to the build number in the git hub actions.

Right now, we need to manually increment the version in the projects from "1.12.3" to "1.12.4", etc. I want the ".3" and ".4" to come from the build number inside the actions so we don't need to worry about this except when we change from a "1.12" to "1.13" or "1.12" to "2.0", etc.

This has been completed.


Issue with tone-analyzer api endpoint

Hi,
I have seen this configuration of the tone analyzer demo here:
// Create the service wrapper
      this.analyzer = watson.tone_analyzer({
        url: 'https://gateway.watsonplatform.net/tone-analyzer/api/',
        username: '<username>',
        password: '<password>',
        version_date: '2016-05-19',
        version: 'v3'
      });

But in the credential panel I see
    "credentials": {
        "url": "https://gateway.watsonplatform.net/tone-analyzer-beta/api",
        "password": "<password>",
        "username": "<username>"
    }
}

The demo app returns a whole set of meta data like sentences_tone, tone_categories ,that is the first endpoint, the last endpoint (the beta) has no sentence_tone. Is that correct?
Problem is that with the same developer account, I cannot login on the first endpoint, that is the one coming from the credentials, it seems like the demo app I have deployed is using the other endpoint, while with same credentials I cannot use this one programmatically.

[UPDATE]
I have created a brand new tone-analyzer service just to be sure, that it was some wrong configuration, now Bluemix gives me back these credentials
{
  "credentials": {
    "url": "https://gateway.watsonplatform.net/tone-analyzer/api",
    "password": "<password>",
    "username": "<username>"
  }
}

So I have the production url, not the beta. By the way, using the same credentials of the demo app I have deployed, for some weird reason gives me back no sentences_tone like before...

The credentials panel shows the URL and user/password for the service you have instantiated (and bound to the app). The demo app needs to make sure it requests the same service you have bound the app to.
The first snippet above shows your app requests version: "v3" which searches for the production version. The second snippet suggests your app is still bound to a Beta service. Your update, or third snippet, shows that once you deleted the old service instance (beta) created a new one from production. This is all ok -- does the app work in the current form?
The confusion may come from having started this app earlier than 2016-05-19 when the new production version was published. Since May 19th, you are unable to create more Beta instances. Tone Analyer is now GA (not Beta), and note that you can still do 1000 API calls for free, for evaluation purposes.
Closing the issue now. Please reopen if you are still having trouble.

@herchu it makes sense, that's why I have a created a standard version of the tone-analyzer so paid account. The problem is that I get the same response with this configuration as well:
{
  "credentials": {
    "url": "https://gateway.watsonplatform.net/tone-analyzer/api",
    "password": "<password>",
    "username": "<username>"
  }
}

I'm in the us region, just to know.

I am sorry I am confused now.

I am sorry I am confused now: What is "the same response" ? No sentences_tone element?
In that case, can you share the input (text) you are analyzing?

@herchu yes the missing response is the sentence_tone.
This is the example:
/**
* @author Loreto Parisi (loretoparisi at gmail dot com)
*/
(function() {

  var watson  = require('watson-developer-cloud');

  var ToneAnalyzer;
  ToneAnalyzer = (function() {

    function ToneAnalyzer(options) {

      // default options
      this._options = {

      };
      //override
      for (var attrname in options) { this._options[attrname] = options[attrname]; }

      // Create the service wrapper
      this.analyzer = watson.tone_analyzer({
        url : 'https://gateway.watsonplatform.net/tone-analyzer/api',
        username: '#####',
        password: '#######',
        version_date: '2016-05-19',
        version: 'v3'
      });

    }

    /**
     * Get Text tone
     * @param options Object Api parameters: { text := string }
     * @param callback Function Result callback
     */
    ToneAnalyzer.prototype.GetTone = function(options, callback) {
      var self=this;

      var extras={};
      for (var attrname in options) { extras[attrname] = options[attrname]; }

      this.analyzer.tone(extras, function(err, data) {
        if (err)
          return callback(null,err);
        else
          return callback( data );
      });
    }

    return ToneAnalyzer;

  })();

  module.exports = ToneAnalyzer;

}).call(this);

and the example is
toneAnalyzer = new ToneAnalyzer({});

  var lyricsBody = "Baby I like your style\nGrips on your waist\nFront way, back way\nYou know that I don't play\nStreets not safe\nBut I never run away\nEven when I'm away";

  var parameters = { text : lyricsBody };

  console.log( JSON.stringify(parameters,null,2) );

  toneAnalyzer.GetTone( parameters
  , function(results, error) {
      if(results) {
        console.log( JSON.stringify(results,null,2) );
      }
      else {
        console.error( error );
      }
  });

Ok, the problem is that your text is seen as a single sentence, so the sentences_tone output is just skipped. This is because there are (single) end-of-line chars, with no period, so text is taken as single sentence as a whole.
Lyrics and poetry trick the sentence parser in Tone Analyzer. You will need to add a period to forcefully end each sentence and the end-of-line, or alternatively leave a blank line between sentences. These two versions work when replacing the second line of your example:
  // Use periods
  var parameters = { text : lyricsBody.replace(/\n/g, ".\n") };
  // Or use double EOLs
  var parameters = { text : lyricsBody.replace(/\n/g, "\n\n") };

Looking forward to seeing the outcome of your analysis... or any new feature in musixmatch ;)

@herchu great it makes sense thank you!
I have updated resulting json here.
Absolutely we will, Watson makes a lot of sense for us ;)


Whole screen slides down when keyboard is dismissed in iOS

Environment
Library version: ^2.4.6
OS version: iPhone 11 iOS 15.5, also faced this issue on many other iOS devices as well
Affected platforms

[ ] Android
[X] iOS

Current behavior
When keyboard is closed, the whole screen shifts to bottom, the exact height is same as keyboard.
Please find the attached video:
https://user-images.githubusercontent.com/13475617/221155199-3524a626-de08-4aa8-91f8-2b0926d0302b.MP4
Expected behavior
When the keyboard is dismissed, the screen should not be scrolled down.
Reproduction
Private repo

👋 @talhauzair-28 unfortunately I'm not able to start investigating the issue without a minimal reproduction repository (I see incorrect behavior on the video, but it doesn't tell me how you use this module and with which UI elements it may interact).
Please do not put "private repo" in the reproduction link field, but instead take your time, and prepare a minimal example on github/gitlab/etc. showcasing the error and link it into the issue description - this is the only way for me, to properly investigate if/why the incorrect behavior is happening

Closing as there's no repro provided


Please correct npm maintainers configuration.

ioBroker adapter checker for npm access
Access right check for adapter discord returned the following issue:
Bluefox was not found in the collaborators on NPM!.
Please execute in adapter directory: "npm owner add bluefox iobroker.discord"
Current maintainers are
crycode<EMAIL_ADDRESS>Please fix the above error as soon as possible.
All adapters listed at ioBroker repositories must have 'bluefox' added as maintainer.
Future version updates at the repositories will be suspended until this problem is fixed.

Done


useHover not working in FF version 52 and less

According to MDN, pointer events not available before FF 59
https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/pointerenter_event

Where you find FF 59 version? This release was 5 year ago, and current version is 97.


UI Improvement: Move traits next to Category

Before

After

Group traits with the category
Inspect details / information on the right side

the metadata for each anata ID is found in https://github.com/M3-org/anata in the metadata/json folder

this UI has been recently implemented


[BEAM-5866] Override structuralValue in ListCoder and MapCoder

use underlying coders in consistentWithEquals
allocate objects if needed instead of relying on serialization in structruralValue

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
 I thought certainly that StructuredCoder already contained this logic.


Unify use_tls usage in interop tests

All languages now understand the --use_tls=true argument, so making its usage language agnostic.

Let's see the interop test results first.

The interop tests look ok. The ruby server and python auth errors that's known.

Changes LGTM. yay to removing code!


Download interrupt.

In latest version 1.5.15.
There will be interrupt When I download a dataset for some time. Try five times, always interrupt, and cant recover.
such as :dataset url

Sorry. This problem be solved since download change by dynamic in some time. There will help download url.....


Dream and Selection - Resource Manager Interaction and Selected Area saving

Allows for selections and dreams to be sent to the resource manager, allows resource deselection when clicking on the currently selected item, put some extra comments and allow saving of a selected canvas area

oh oh oh i love the dream resource adder so much, this is fantastic, this makes batches so much more instantly useful


remove timeout from constructor parameter

I am wondering why 'timeout' is a separate parameter for the constructor (in Python and Ruby).
It's defined in the client-config, and the parameter can be configurable by #70, possibly we can simply remove 'timeout' parameter, the 'default_timeout' constant, and some other related code?

@geigerj @tbetbetbe, thoughts?

Adding @chrisdunelm too, for him to follow timeout-related conversations

I don't think timeout is actually defined in the client config, but perhaps it should be.

I would propose:

Add per-method timeout configuration to the GAPIC config, and propagate to the JSON client config
Remove the timeout parameter and default_timeout constant from the generated API objects


Cannot checkout/browse robotium source code

From<EMAIL_ADDRESS>on September 29, 2013 10:05:00
What steps will reproduce the problem? 1. Go to the checkout source page: https://code.google.com/p/robotium/source/checkout 2. Checkout the code using SVN on Mac What is the expected output? What do you see instead? Expected: source code checked out.
Actual: trunk folder is empty, only documents are checked out.
svn --version:
svn, version 1.7.10 ( r1485443 )
compiled Aug 13 2013, 15:31:22 What version of the product are you using? On what operating system? Please provide any additional information below.
Original issue: http://code.google.com/p/robotium/issues/detail?id=526

From<EMAIL_ADDRESS>on September 29, 2013 22:47:38
The source code is located on github. https://github.com/jayway/robotium
Status: Invalid
Owner<EMAIL_ADDRESS>


Allow to set a boundary to the codedeploy role

Is your request related to a problem? Please describe.
In some cases, for security reasons, it may be prohibited to create roles without boundary.
The lambda module allows to assign a boundary to the role it will create. However, this is not yet possible with the role created by the deploy submodule.
This forces to write the whole codedeploy role and create it outside the module just to set an existing boundary.
Describe the solution you'd like.
Add a codedeploy_role_permissions_boundary input to the submodule deploy, in order to assign a boundary to the codedeploy_role created by the module (as for role_permissions_boundary input of the module lambda).

Hey, I was looking for simple things to contribute to. I will tackle on this one, better late than ever


Issue with ControlNet

Hey!
I guess it's not an issue of this extension.
But something going on with ControlNet extension enabled with yours also.
Maybe you can tell me why THIS is an issue, or bring some light to it, bcuz I am clueless what to do since I need/like both extensions.

I cant reproduce this with latest versions of SD, ControlNet and Image browser... Is there some message in the browser console (JS) ?


rotate secret due to expiration

Summary

rotate secret due to expiration

looks like need to import rekor-search-ui :) will import and open another PR


Multiple images upload panel

This is a new panel that allows creation of new InlinePanel rows by drag-and-drop of a bunch of images. When creating the new rows, the specified image field is populated with the uploaded images.
This is still a WIP and is dependent on PR #4382 for its functionality.

@thibaudcolas This is the Pull Request for the changes we discussed. I still haven't refactored it acc. to our discussion, but will do that soon.

This is outstanding. Thanks so much for this, Rajeev!

:+1:

@rajeev i think you have to change the module names, don't forget: now each module has not the wagtail prefix.

@SalahAdDin It all looks correct to me. Only the dotted module paths (as used in import lines and INSTALLED_APPS) have changed - there are still various other places such as template / static file paths that keep the wagtail prefix.

@gasman @SalahAdDin Thank you for your comments and review. I'm continuing to work on this PR and should be done soon. Thank you!

@thibaudcolas @BertrandBordage Could you review this PR and let me know what's missing or needs to fix?

@rajeev I don't have time to look into this at the moment, sorry.

@tomdyson @gasman @thibaudcolas Thank you

Hello, do you have any plans to finish this? Seems to be like almost done for quite a long time.

Hello, for anybody that really needs this functionality and until this PR is merged with wagtail core (considering that it's already 2 years old this may take some time) you can actually allow your editors to upload multiple related images through this package: https://github.com/spapas/wagtail-multi-upload
Notice that this is just a "repackaging" of @rajeev 's work in order to be properly and immediately used in your project.

@spapas Thank you for providing an easy alternative to those who need such functionality.
However, given that the original comitter isn't contributing anymore, I believe your time would be better used picking up this PR, implementing @gasman feedback and opening a new PR superseding this one. In any case, good luck.

Hello @loicteixeira yes I agree that submitting a proper PR is the way to go for implementing the multi image upload but I really needed this functionality ASAP so I chose the add-on solution to avoid waiting for a new wagtail release (and the whole PR merge cycle).
I'll definitely try to give some love to this PR when I am able to schedule the needed time - unless of course somebody else does it first :)

The MultipleChooserPanel work currently under way and documented on #2203 can serve as a basis for a new implementation of this feature, based on stable documented APIs and avoiding the potential maintenance burden of hooking into InlinePanel internals that has blocked this PR from being merged. As such, I'm closing this in favour of a new tracking issue #9774.


Dev test: Ohms Law 1.4.0-dev.26

@emily-phet, @terracoda, @jbphet, @zepumph, Ohms Law 1.4.0-dev.26 is ready for dev testing. Document issues in https://github.com/phetsims/ohms-law/issues and link to this issue.
This sim includes accessibility features, so please test those as part of this dev test. This sim
includes support for a new screen reader, VoiceOver with mobile Safari. VoiceOver with mobile safari works differently than other screen readers. I have included information about how to use it in https://phet-dev.colorado.edu/html/jg-tests/reader-intro.html, but let me know if you have any other questions. Before testing the simulation with VoiceOver, please read through that document and make sure that you can interact with all of the sliders and buttons on that page.
Assigning @ariel-phet for prioritization.
Thank you!

General Dev Test

What to Test

Click every single button.
If there is sound, make sure it works.
Make sure you can't lose anything.
Play with the sim normally.
Try to break the sim.

Focus and Special Instructions
[Provide further instructions here. If you have any further tests you want done or specific platforms you want tested, list them here. Any behaviors you want QA to pay special attention to should be listed here.]

General Dev Test Platforms

[ ] Latest macOS, Chrome and Safari
[ ] Latest iOS, Safari
[ ] Windows 10, all browsers
[ ] Latest Chrome OS, Chrome

Link(s)

Simulation

Accessibility (a11y) Dev Test

What to Test

Specific instructions can be found below.
Make sure the a11y feature doesn't negatively affect the sim in any way.

Focus and Special Instructions
[Provide further instructions here. If you have any further tests you want done or specific platforms you want tested, list them here. Any behaviors you want QA to pay special attention to should be listed here.]

Link(s)

a11y View
Simulation

Screen Readers
This sim supports screen readers. If you are unfamiliar with screen readers, please ask Katie to introduce you to screen readers. If you simply need a refresher on screen readers, please consult the QA Book, which should have all of the information you need as well as a link to a screen reader tutorial made by Jesse. Otherwise, look over the a11y view before opening the simulation. Once you've done that, open the simulation and make sure alerts and descriptions work as intended.

Platforms and Screen Readers to Be Tested

[ ] Windows 10 + Latest Chrome + Latest JAWS
[ ] Windows 10 + Latest Firefox + Latest NVDA
[ ] macOS + Safari + VoiceOver
[ ] iOS + Safari + VoiceOver (only if specified in testing issue)

Critical Screen Reader Information
We are tracking known screen reader bugs in this Google Document. If you find a screen reader bug, please check it against this list.

Keyboard Navigation
This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a screen reader.

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

And just a heads up, we are already aware of some mobile VoiceOver quirks! Beware of #21 on this list as you test. https://docs.google.com/document/d/12kTs-g-iKEIH1dyG7Q41_W_oNL4gUKbkW-IQgZjMUBw/edit

Goal is to publish this sim by end of March, so good to have the dev test take high priority

QA is done

Thanks very much @KatieWoe, thats great.


Using Mobilenet

Hey Andre, I had a doubt regarding Model Conversion. I am trying to use Mobile net trained model, which is already based on Tensorflow, Do I need to undergo model conversion for that? I dont think I should , under that case what could be my next step? Should I move to quantization?
So do you know where I can refer to scripts for quantization? or atleast I can get Idea how to quantize my mobilenet model?

Hi!
If your model is already in tensorflow, you can move to the quantization process directly. I assume you have MobileNet model in a ".pb" format, so, you should move that file to the quantization folder.
Important note: DNNDKv3.1 is the quantization and compilation tool of Xilinx and that version supports **Tensoflow 1.12**! The model has to respect that version otherwise it will not work. There might be a way to downgrade the model if it is in Tensorflow 2 as most of the implementations. This is maybe the biggest limitation of the deployment of neural networks on the PYNQ-Z2 with this tool.
If you will be using MobileNet for image classification and not object detection, you have most of the quantizatization process like I describe on the tutorial. Follow everything correctly but you will need to change the calibration script. I don't think that task is too hard so you can try to use chatGPT for that. On the other hand there might be some work done on that regard before. Just try to look up for implementations of MobileNet or other similar classification models but implemented on simillar hardware, like the Ultra96 board. Also, the DNNDK packages you download has some examples that might be useful!
I hope this helps. Fell free to ask any questions if you find further problems! :D

Hey Andre,
Okay I will check that process myself. Also, if I plan to implement object detection using mobilenet what do I have to do differently? What could possibly change?

If you are talking about MobileNet, it is a classification model. It just tells you what is on the image. There is SSD MobileNet which is a model for object detection which has a base on MobileNet. SSD will later require a script in c++ that might be considerably different from the one I have for YOLO. In any case, there are certainly pre-made example scripts from other people or from Xilinx. When I have time I can looks into that.
Good luck!

Hey Andre,
I was setting up the DNNDK and was installing the necessary packages : pip install numpy opencv-python==<IP_ADDRESS> scikit-learn==0.24.2 scipy progressbar2 keras==2.2.4 and this happened :

Hi!
I have PTSD of that first error because I spent more than two weeks trying to deal with it haha. But whan that happens is due to incompatibilities of the packages. In this case, I went and checked the opencv-python package and aparently it deprecated:

What you need to do now is change the version to what they suggest there <IP_ADDRESS>.
pip install numpy opencv-python==<IP_ADDRESS> scikit-learn==0.24.2 scipy progressbar2 keras==2.2.4
If it does not work, experiment with the version before that, which is <IP_ADDRESS>.
If that does not work too, you will have to try and downgrade or upgrade the rest of the packages.
Give it a try and then update me if it worked so I can change the tutorial.
Thank you!
The second problem is because you are not running the script convert.py on the same folder as the picture. You first have to access the directory of the python scrip like this:
cd /home/aryan/Desktop/YOLO-on-PYNQ-Z2/DNNDK/model_conversion
And then you do the conversion:
python convert.py yolov3.cfg yolov3.weights /home/aryan/Desktop/YOLO-on-PYNQ-Z2/DNNDK/model_conversion/model_data/yolo.h5
I hope this helps. Good luck!

so apparently the version <IP_ADDRESS> is working for now , I tired  versions from 4.7 to 4.10 none of them worked but this one is wokring as you can see :

aryan@aryan-X510UAR:~/Downloads/xilinx_dnndk_v3.1/host_x86/decent-tf/ubuntu18.04$ pip install numpy opencv-python==<IP_ADDRESS> scikit-learn==0.24.2 scipy progressbar2 keras==2.2.4
Requirement already satisfied: numpy in /home/aryan/anaconda3/envs/decent/lib/python3.6/site-packages (1.19.5)
Collecting opencv-python==<IP_ADDRESS>
Downloading opencv_python-<IP_ADDRESS>-cp36-abi3-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (60.9 MB)
|████████████████████████████████| 60.9 MB 54 kB/s
Collecting scikit-learn==0.24.2
Using cached scikit_learn-0.24.2-cp36-cp36m-manylinux2010_x86_64.whl (22.2 MB)
Collecting scipy
Using cached scipy-1.5.4-cp36-cp36m-manylinux1_x86_64.whl (25.9 MB)
Collecting progressbar2
Using cached progressbar2-3.55.0-py2.py3-none-any.whl (26 kB)
Collecting keras==2.2.4
Using cached Keras-2.2.4-py2.py3-none-any.whl (312 kB)
Collecting joblib>=0.11
Using cached joblib-1.1.1-py2.py3-none-any.whl (309 kB)
Collecting threadpoolctl>=2.0.0
Using cached threadpoolctl-3.1.0-py3-none-any.whl (14 kB)
Requirement already satisfied: six>=1.9.0 in /home/aryan/anaconda3/envs/decent/lib/python3.6/site-packages (from keras==2.2.4) (1.16.0)
Requirement already satisfied: keras-applications>=1.0.6 in /home/aryan/anaconda3/envs/decent/lib/python3.6/site-packages (from keras==2.2.4) (1.0.8)
Requirement already satisfied: h5py in /home/aryan/anaconda3/envs/decent/lib/python3.6/site-packages (from keras==2.2.4) (3.1.0)
Collecting pyyaml
Using cached PyYAML-6.0.1-cp36-cp36m-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (677 kB)
Requirement already satisfied: keras-preprocessing>=1.0.5 in /home/aryan/anaconda3/envs/decent/lib/python3.6/site-packages (from keras==2.2.4) (1.1.2)
Collecting python-utils>=2.3.0
Using cached python_utils-3.5.2-py2.py3-none-any.whl (24 kB)
Requirement already satisfied: typing-extensions in /home/aryan/anaconda3/envs/decent/lib/python3.6/site-packages (from python-utils>=2.3.0->progressbar2) (4.1.1)
Requirement already satisfied: cached-property in /home/aryan/anaconda3/envs/decent/lib/python3.6/site-packages (from h5py->keras==2.2.4) (1.5.2)
Installing collected packages: threadpoolctl, scipy, pyyaml, python-utils, joblib, scikit-learn, progressbar2, opencv-python, keras
Successfully installed joblib-1.1.1 keras-2.2.4 opencv-python-<IP_ADDRESS> progressbar2-3.55.0 python-utils-3.5.2 pyyaml-6.0.1 scikit-learn-0.24.2 scipy-1.5.4 threadpoolctl-3.1.0

Alright, thank you!
I will update the tutorial with that information. I hope everything will work accordingly for now on!
Good luck!

Hey Andre, I need to unzip the COCO dataset, right? It's taking forever to extract, so I just wanted to confirm.
Also you mentioned in the tutorial that :

by "Images" you mean the 17GB folder right?
And what do I have to do with the quantization script given in the tutorial ? cause you have mentioned "before executing the quntization" and what and where is this "calibration function" ?

Hey, It showed Quantization ended only after 3/100

A folder anmed Quantization result is made but is empty:

And a pycache named folder is created which included a .pyc file:

Hello Aryan.
Sorry for the late response. I think you should first do this command to see the input nodes, output nodes and shape: decent_q inspect --input_frozen_graph=model_data/yolo.pb. I mention this on the tutorial and it is important, especially because you are using a different model. Complete the quant.sh script with the informations displayed by the command.
The COCO dataset shpuld be uncompressed. It takes some time, yes haha. The images are the 17GB I think.
Try to see if the names of the inputs and outputs of the network with the command and complete the script with the information. Then let me know everyting!
I am sorry if I take some time to answer but for now I tend to be a little more busy. I will do my best! :)
Good luck!

So I had ran that and I had updated the output nodes accordingly in the quant.sh, input nodes , output nodes everything is fine and right(here). The problem is the quantization isn't getting completed, it stops at 1,2 or 3 (out of 100). Is it possible that my Computer isn't capable of doing that? (here)
It's okay take your time, I can understand you can be busy and I appreciate you for still helping out.

It might be because of computational power. I am not sure but still, try to reduce the "calib_iter" to a lower number like 50 or even 10. Reducing the batch size generaly helps. You are also using the cpu so it is expected to be more demanding.
I hope this helps!

I have access to a better system but it runs on Ubuntu v20.04 , is it okay?
or should I install v18.04 on that system as well?

Message ID: @.***>

Yes, reducing the size of the batch helps reduce computational load. Normally computers with more computational power can use bigger batches, specialy with a GPU.
Unfortunatly, for DNNDK you can only work with Ubuntu 14.04, 16.04 or 18.04. Not Ubuntu 20.04. It says on the documentation here (page 8):

Good luck!

F okay. About the Batch size I reduced it to 10 instead of 50 and calib_iter as 20 and It worked, does it mean it takes 10 photos and then another 10 and so on, till 20, am I understanding this right or am I making a mistake?
Also I got on the step on compilation just to know the process but I ran into error as always :

Hi!
You are understanding it right. What you said is correct.
About the issue on compilation, it is a library that you need to install but I forgot to include it on the tutorial.
Install it like this: sudo apt install libgoogle-glog-dev
I will now update the tutorial for that. I am sorry for all the problems you are encountering.
Good job!

Hardly any problems I encountered are on you, all of them are mostly on me
and to be honest upon our discussions from past 2-3 weeks all of them has
been solved so don't take it on yourself. When I encountered this error
today , First thing that came to my mind was what the heck did I do wrong
again haha.  Thank you so much Andre, you're the best.
On Wed, Jul 10, 2024, 8:37 PM André Araújo @.***> wrote:

Hi!
You are understanding it right. What you said is correct.
About the issue on compilation, it is a library that you need to install
but I forgot to include it on the tutorial.
Install it like this: sudo apt install libgoogle-glog-dev
I will now update the tutorial for that. I am sorry for all the problems
you are encountering.
Good job!
—
Reply to this email directly, view it on GitHub
https://github.com/andre1araujo/YOLO-on-PYNQ-Z2/issues/7#issuecomment-2220762311,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5RZEIXUDYKQSRMJK35ZX3LZLVE2BAVCNFSM6AAAAABKG42TVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRQG43DEMZRGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

No problem haha.
This error in particular, somehow I still remember it and I quickly checked it on my notes and there it was.
Keep pushing and any problem just tell me because you are helping a lot here.

Hey, is this warning serious? Or I should ignore it?

The warning you got is not very important. After all you just get a image with the DPU kernel. I don't know exactly how it is useful but maybe in some applications it might be. In any case, I will add that command. Thank you!
The rest of the process is on Windows indeed. Copy the files from the compilation to the Windows system and do the rest there.
I hope there are not much problems now!
Good luck!

without that library you won't get a .jpg file. I checked after the warning , and mine wasn't converted to .jpg file. After downloading that library, .jpg was generated.

Okay, thank you! Already updated the tutorials!

@andre1araujo Hello Andre, I hope you are doing well :). I have a problem, I kindly need your help.
When I run "yasin@yasin-VirtualBox:~/Desktop/YOLO-on-PYNQ-Z2/DNNDK/model_conversion$ python3 convert.py yolov3.cfg yolov3.weights /home/yasin/Desktop/YOLO-on-PYNQ-Z2/DNNDK/model_conversion/model_data/yolo.h5" this command, it gives the error below. Thank you very much Andre.
None
Traceback (most recent call last):
File "convert.py", line 262, in
_main(parser.parse_args())
File "convert.py", line 245, in _main
model.save('{}'.format(output_path))
File "/home/yasin/.local/lib/python3.6/site-packages/keras/engine/topology.py", line 2556, in save
save_model(self, filepath, overwrite, include_optimizer)
File "/home/yasin/.local/lib/python3.6/site-packages/keras/models.py", line 103, in save_model
with h5py.File(filepath, mode='w') as f:
File "/home/yasin/.local/lib/python3.6/site-packages/h5py/_hl/files.py", line 427, in init
swmr=swmr)
File "/home/yasin/.local/lib/python3.6/site-packages/h5py/_hl/files.py", line 196, in make_fid
fid = h5f.create(name, h5f.ACC_TRUNC, fapl=fapl, fcpl=fcpl)
File "h5py/_objects.pyx", line 54, in h5py._objects.with_phil.wrapper
File "h5py/_objects.pyx", line 55, in h5py._objects.with_phil.wrapper
File "h5py/h5f.pyx", line 116, in h5py.h5f.create
OSError: Unable to create file (unable to open file: name = '/home/yasin/Desktop/YOLO-on-PYNQ-Z2/DNNDK/model_conversion/model_data/yolo.h5', errno = 2, error message = 'No such file or directory', flags = 13, o_flags = 242)

Hello Andre, I hope you are doing well :). I kindly need your help please. I get this error?
command --- yasin@yasin-VirtualBox:~/Desktop/YOLO-on-PYNQ-Z2/DNNDK/model_conversion$ python3 keras_to_tensorflow.py --input_model=/home/yasin/Desktop/YOLO-on-PYNQ-Z2/DNNDK/model_conversion/model_data/yolo.h5 --output_model=/home/yasin/Desktop/YOLO-on-PYNQ-Z2/DNNDK/model_conversion/model_data/yolo.pb
/home/yasin/.local/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:493: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint8 = np.dtype([("qint8", np.int8, 1)])
/home/yasin/.local/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:494: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint8 = np.dtype([("quint8", np.uint8, 1)])
/home/yasin/.local/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:495: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint16 = np.dtype([("qint16", np.int16, 1)])
/home/yasin/.local/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:496: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint16 = np.dtype([("quint16", np.uint16, 1)])
/home/yasin/.local/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:497: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint32 = np.dtype([("qint32", np.int32, 1)])
/home/yasin/.local/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:502: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
np_resource = np.dtype([("resource", np.ubyte, 1)])
Using TensorFlow backend.
Traceback (most recent call last):
File "keras_to_tensorflow.py", line 181, in
app.run(main)
File "/home/yasin/.local/lib/python3.6/site-packages/absl/app.py", line 308, in run
_run_main(main, args)
File "/home/yasin/.local/lib/python3.6/site-packages/absl/app.py", line 254, in _run_main
sys.exit(main(argv))
File "keras_to_tensorflow.py", line 127, in main
model = load_model(FLAGS.input_model, FLAGS.input_model_json, FLAGS.input_model_yaml)
File "keras_to_tensorflow.py", line 62, in load_model
model = keras.models.load_model(input_model_path)
File "/home/yasin/.local/lib/python3.6/site-packages/keras/models.py", line 239, in load_model
model_config = json.loads(model_config.decode('utf-8'))
AttributeError: 'str' object has no attribute 'decode'

I changed python3 to python. this error rises:
yasin@yasin-VirtualBox:~/Desktop/YOLO-on-PYNQ-Z2/DNNDK/model_conversion$ python keras_to_tensorflow.py --input_model=/home/yasin/Desktop/YOLO-on-PYNQ-Z2/DNNDK/model_conversion/model_data/yolo.h5 --output_model=/home/yasin/Desktop/YOLO-on-PYNQ-Z2/DNNDK/model_conversion/model_data/yolo.pb
Traceback (most recent call last):
File "keras_to_tensorflow.py", line 11, in
import tensorflow as tf
ImportError: No module named tensorflow
Thank you Andre.

Hello!
I am sorry for the delay on the response.
I came across that error before and I documented it on the GitBook tutorial. Here is what you need to do:
pip install pillow
pip install 'h5py==2.10.0' --force-reinstall
sudo apt install libgoogle-glog-dev
sudo apt-get install graphviz

It was a problem with the compatibility of Pillow and h5py packages.
Try doing this and then tell me if it worked! Thank you! :D
NOTE: I noticed you are using VirtualBox for that part but it will not work when you will use DNNDKv3.1 because it uses Tensorflow. You will need to use a computer with Ubuntu 16.04 or 18.04 installed. Sorry for the inconvenience. But if you really need I can help!

Thank you @andre1araujo , it works now. I have another problem,
(decent) yasin@yasin-VirtualBox:~/Desktop/YOLO-on-PYNQ-Z2/DNNDK/model_conversion$ decent_q inspect --input_frozen_graph=model_data/yolo.pb
/home/yasin/.local/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:493: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint8 = np.dtype([("qint8", np.int8, 1)])
/home/yasin/.local/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:494: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint8 = np.dtype([("quint8", np.uint8, 1)])
/home/yasin/.local/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:495: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint16 = np.dtype([("qint16", np.int16, 1)])
/home/yasin/.local/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:496: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint16 = np.dtype([("quint16", np.uint16, 1)])
/home/yasin/.local/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:497: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint32 = np.dtype([("qint32", np.int32, 1)])
/home/yasin/.local/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:502: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
np_resource = np.dtype([("resource", np.ubyte, 1)])
Traceback (most recent call last):
File "/home/yasin/anaconda3/envs/decent/bin/decent_q", line 5, in
from tensorflow.contrib.decent_q.python.decent_q import run_main
ModuleNotFoundError: No module named 'tensorflow.contrib.decent_q'
Could you help please @andre1araujo

Again hello @andre1araujo , because of errors, I restarted the Optimization and Compilation chapter. I have this error now:
(decent) yasin@yasin-VirtualBox:~/Downloads/xilinx_dnndk_v3.1/host_x86/decent-tf/ubuntu18.04$ pip install ./tensorflow-1.12.0-cp36-cp36m-linux_x86_64.whl
Processing ./tensorflow-1.12.0-cp36-cp36m-linux_x86_64.whl
Requirement already satisfied: numpy>=1.13.3 in /home/yasin/.local/lib/python3.6/site-packages (from tensorflow==1.12.0) (1.19.5)
Requirement already satisfied: grpcio>=1.8.6 in /home/yasin/.local/lib/python3.6/site-packages (from tensorflow==1.12.0) (1.48.2)
Requirement already satisfied: astor>=0.6.0 in /home/yasin/anaconda3/envs/decent/lib/python3.6/site-packages (from tensorflow==1.12.0) (0.8.1)
Requirement already satisfied: six>=1.10.0 in /home/yasin/.local/lib/python3.6/site-packages (from tensorflow==1.12.0) (1.17.0)
Collecting tensorboard<1.13.0,>=1.12.0
Using cached tensorboard-1.12.2-py3-none-any.whl (3.0 MB)
Requirement already satisfied: absl-py>=0.1.6 in /home/yasin/.local/lib/python3.6/site-packages (from tensorflow==1.12.0) (1.4.0)
Requirement already satisfied: termcolor>=1.1.0 in /home/yasin/.local/lib/python3.6/site-packages (from tensorflow==1.12.0) (1.1.0)
Requirement already satisfied: wheel>=0.26 in /home/yasin/.local/lib/python3.6/site-packages (from tensorflow==1.12.0) (0.37.1)
Requirement already satisfied: keras-preprocessing>=1.0.5 in /home/yasin/.local/lib/python3.6/site-packages (from tensorflow==1.12.0) (1.1.2)
Requirement already satisfied: keras-applications>=1.0.6 in /home/yasin/anaconda3/envs/decent/lib/python3.6/site-packages (from tensorflow==1.12.0) (1.0.8)
Requirement already satisfied: gast>=0.2.0 in /home/yasin/.local/lib/python3.6/site-packages (from tensorflow==1.12.0) (0.4.0)
Requirement already satisfied: protobuf>=3.6.1 in /home/yasin/.local/lib/python3.6/site-packages (from tensorflow==1.12.0) (3.19.6)
Requirement already satisfied: h5py in /home/yasin/anaconda3/envs/decent/lib/python3.6/site-packages (from keras-applications>=1.0.6->tensorflow==1.12.0) (2.10.0)
ERROR: Could not install packages due to an OSError: [Errno 2] No such file or directory: '/home/yasin/.local/lib/python3.6/site-packages/numpy-1.19.5.dist-info/METADATA'

Thank you @andre1araujo , I made a mistake and had to restart. This time I get this error, could you please help?
(decent) yasin@yasin-VirtualBox:~/Desktop/YOLO-on-PYNQ-Z2/DNNDK/model_conversion$ python3 convert.py yolov3.cfg yolov3.weights /home/yasin/Desktop/YOLO-on-PYNQ-Z2/DNNDK/model_conversion/model_data/yolo.h5Using TensorFlow backend.
Illegal instruction (core dumped)

Hi!
Sorry again for the delay. The problem you are having now is likely related to the Tensorflow you are using. Try to make sure is Tensorflow 1.12 installed. But I don't think you can do this in Virtual Box. I mentioned on the tutorial that this needs to be done on a Ubuntu operating system and that VirtualBox does not emulate all CPU instructions (some of which Tensorflow uses).
In summary, I think the problem is that you are using a virtual machine and because it does not emulate the AVX instructions of the CPU you cannot proceed. You need to do that command on a Operating System not virtualized.
Sorry for the inconvenience :(
If you really need, I still have the Operating System on my computer and I might be able to do that part of the work for you.

Hi!
Thanks @andre1araujo, I tried tf 1.15 and it worked! But i have this problem now :(
(decent) yasin@yasin-VirtualBox:~/Desktop/YOLO-on-PYNQ-Z2/DNNDK/model_conversion$ decent_q inspect --input_frozen_graph=model_data/yolo.pb
decent_q: command not found
Could you help please?

Hi!
Because you are no longer using Tensorflow 1.12 from the DNNDK application, you cannot use the "decent" tool. You have to install the wheel file like this:
cd Downloads/xilinx_dnndk_v3.1/host_x86/decent-tf/ubuntu18.04
pip install ./tensorflow-1.12.0-cp36-cp36m-linux_x86_64.whl

If it works let me know!

Hi @andre1araujo, I used your commands above and get the "Illegal instruction (core dumped)" error. This project will be running on zedboard and my term project. I need it absolutely, could you please help? I am grateful to you!

Hi!
Yes, I could help. Your problem is simply that you are using a Virtual Machine. You cannot do with a Virtual Machine.
I can do the process for you when I have the time. I will need your model (.cfg and .weights) file and also the dataset you trained the model on. If you could also provide as much details as possible I would appreciate it. For example, what is the aim of your project? Will you use YOLOv3 or YOLOv3-Tiny?
Good luck!

Hi!I am a beginner at FPGA. I saw your project and wanted to give it a try and have an experience. Also, I will make a presentation of this project at a school course. I want to use your YOLO model, is it possible? Thanks Andre!On 31 Dec 2024, at 17:50, André Araújo @.***> wrote:
Hi!
Yes, I could help. Your problem is simply that you are using a Virtual Machine. You cannot do with a Virtual Machine.
I can do the process for you when I have the time. I will need your model (.cfg and .weights) file and also the dataset you trained the model on. If you could also provide as much details as possible I would appreciate it. For example, what is the aim of your project? Will you use YOLOv3 or YOLOv3-Tiny?
Good luck!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

Yes, you can use the model and averything. This project is public!
I see you are encountering some problems, so I can try and help you. If you could have a computer with Ubuntu 18.04, most of the problems will be solved but if not I can do that part for you. I need your model and training dataset!

Hi @andre1araujo, https://drive.google.com/drive/folders/1nUFkqvQK3zJCe2LYI6lUcLSqzE3osVOl?usp=sharing
I get these .cfg and .weights from https://pjreddie.com/darknet/yolo/ yolov3-416 as you mentioned earlier in the tutorial. I need a pretrained model, not trying to train. I dont have dataset. This model is trained by coco dataset. Purpose is to run yolov3 on Zedboard. Thank you for your support!

Ah, that is a lot simpler then! I already made all of that so you will only have to flash my SD card image on yours, insert it on your ZedBoard and do some aditional steps.

First, you follow this part to have the micro SD card image.
Then you follow the deployment chapter. Everything here is the same for the ZedBoard. You just have to do the procedure for the ZedBoard.

If you come across any problem, just tell me and I will help. For now, just forget about the part you were doing and just follow the steps I told you here!
Good luck! :D


Gatherer's Cape doesn't give +100% like farming master cape

🐛 Bug Report
After the update the Gatherer's Cape doesn't give +100% like farming master cape does. See screenshot below. Extra proof that I have it on can be seen in that I saved 50% seeds.

Fixed in next update. Thank you for reporting.


List observables by category in inline forms plus other admin tweaks

Resolves Notion ticket.
This also dynamically uses the correct input widget for Observation.observable_value based on Observation.observable.value_class.

@amitschang Hey, I'm not quite sure what's going on with the codecov diff because when I run the tests locally, only 8 lines are missing and not 13 as reported here.

I'm gonna investigate this in another PR, so have re-requested your review, please.

@amitschang Thanks for the review.
@glemson Are you still looking at this or am I ok to merge?

@jamienoss let me finish my review this morning


list object has no attribute strip, line 80 in cli.py

Getting the above error when running --pmidsfile="/path/to/file.txt". The pmids are separated by lines in the file. Seems to be triggered by "line.strip().split().strip()" and fixed by deleting .strip() at the end. Not sure if this is a bug or a simple workaround for my incorrect usage lol. Thanks!

Should be fixed now with the PR


replace JUnitParams with junit-dataprovider

see discussion at: https://github.com/joel-costigliola/assertj-core/pull/535

Is this PR waiting for a release of JUnit DataProvider with the fix ?

The PR is ready for merging. I will submit a new PR which removes the ´format="%m[%i]"´ workaround once there is a new release of junit-dataprovider (should happen in a few weeks).

:+1:

Integrated, thanks


Remove cupy.cupy

There was an alias of cupy: cupy.cupy. Make cupy._core.fusion available when cupy._core is loaded, instead of direct access from cupy/__init__.py.

Thanks! I'll remove TODOs in docs after merging this.
https://raw.githubusercontent.com/cupy/cupy/6668d362c1c99ac0e9c787f5502af1417e6e8a75/docs/source/reference/ext.rst

Jenkins, test this please.

Jenkins CI test (for commit c7fb9de12a28a0f225f7a568a4f13d59a97fad29, target branch master) failed with status FAILURE.

Jenkins, test this please.

Jenkins CI test (for commit 47687f512283093ba8bc6c3798c00570601f7bbe, target branch master) succeeded!


unsaved changes dialog showing too often

why do you shortcut the function, skipping the generation of mark attributes when the node attribute is not null?

confirmed to not solve the problem (it sidesteps it by disabling important functionality)


IDTP-451 добавление AsyncIterator

Что сделал

Добавил AsyncIterator и тесты для него

Codecov Report

Merging #95 into master will increase coverage by 0.25%.
The diff coverage is 72.07%.

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   66.63%   66.89%   +0.25%
==========================================
  Files          98      101       +3
  Lines        2227     2338     +111
==========================================
+ Hits         1484     1564      +80
- Misses        743      774      +31

Impacted Files
Coverage Δ

NodeKit/Utils/AsyncIterator/AnyAsyncIterator.swift
0.00% <0.00%> (ø)

NodeKit/Utils/AsyncIterator/OffsetAsyncPager.swift
62.50% <62.50%> (ø)

...nitTests/AsyncIterator/OffsetAsyncPagerTests.swift
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7de814a...faa1f17. Read the comment docs.


Add CL withdrawals search in the address page

For ots alpha 2.1 there will be a new API for search for consensus layer withdrawals for a certain address.
So let's add one more tab like we had added for erc20/721 search results in the address page, but now for withdrawals.
The methods are called ots2_getWithdrawalsCount and ots2_getWithdrawalsList, and they work like the erc20/er721 counterparts.
Also, let's try to reuse/retrofit/adapt the search result components I've made for them so we can have a more generic UI results component.
For reference, those are the method signatures/return using a random address I got on mainnet:
$ curl -v -H "Content-Type: application/json" --data '{"jsonrpc": "2.0", "method": "ots2_getWithdrawalsCount", "params": ["0x4493CB639c54317ABD3b432aefa90108B77DcE02"], "id":1}' <rpc-url> | jq -C
{
  "jsonrpc": "2.0",
  "id": 1,
  "result": 3075
}

$ curl -v -H "Content-Type: application/json" --data '{"jsonrpc": "2.0", "method": "ots2_getWithdrawalsList", "params": ["0x4493CB639c54317ABD3b432aefa90108B77DcE02", 3065, 25], "id":1}' <rpc-url> | jq -C
{
  "jsonrpc": "2.0",
  "id": 1,
  "result": {
    "blocksSummary": {
      "0x1161e64": {
        "blockNumber": "0x1161e64",
        "timestamp":<PHONE_NUMBER>
      }
    },
    "results": [
      {
        "index": "0x122f938",
        "blockNumber": "0x1161e64",
        "validatorIndex": "0x7aeda",
        "amount": "0xf8305a"
      },
      {
        "index": "0x122f939",
        "blockNumber": "0x1161e64",
        "validatorIndex": "0x7aedb",
        "amount": "0xf7faaf"
      },
      {
        "index": "0x122f93a",
        "blockNumber": "0x1161e64",
        "validatorIndex": "0x7aedc",
        "amount": "0xf80b40"
      },
      {
        "index": "0x122f93b",
        "blockNumber": "0x1161e64",
        "validatorIndex": "0x7aedd",
        "amount": "0x35ca19b"
      },
      {
        "index": "0x122f93c",
        "blockNumber": "0x1161e64",
        "validatorIndex": "0x7aede",
        "amount": "0xf803e5"
      },
      {
        "index": "0x122f93d",
        "blockNumber": "0x1161e64",
        "validatorIndex": "0x7aedf",
        "amount": "0xf79011"
      },
      {
        "index": "0x122f93e",
        "blockNumber": "0x1161e64",
        "validatorIndex": "0x7aee0",
        "amount": "0xf7cff6"
      },
      {
        "index": "0x122f93f",
        "blockNumber": "0x1161e64",
        "validatorIndex": "0x7aee1",
        "amount": "0xf83ec7"
      },
      {
        "index": "0x122f940",
        "blockNumber": "0x1161e64",
        "validatorIndex": "0x7aee2",
        "amount": "0xf8846f"
      },
      {
        "index": "0x122f941",
        "blockNumber": "0x1161e64",
        "validatorIndex": "0x7aee3",
        "amount": "0xf8504a"
      }
    ]
  }
}

adding to the prioritized queue @sealer3 :)
the API is already enabled and working for mainnet in our test server.

#853 goes nicely with this one, so that validators can be mapped back to their withdrawal address.


make: add recipes to build wasm in debug

closes anoma/namada#51, closes anoma/namada#52
This PR adds recipe make debug-wasm-scripts in the root that can be used to enable debug_log! expressions in WASM. In the wasm/wasm_source, one can debug build an individual tx or VP with e.g. make debug_tx_transfer.
Additionally, the debug_log! get printed to stdout in non-WASM build, which is handy for testing.

moved to https://github.com/anoma/namada/pull/255


[ISSUE #3375] Add shenyu-register-instance-consul Test

// Describe your PR here; eg. Fixes #3375

Make sure that:

[ ] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #3376 (d2015e9) into master (24b299b) will decrease coverage by 0.31%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3376      +/-   ##
============================================
- Coverage     65.23%   64.92%   -0.32%
+ Complexity     5240     5238       -2
============================================
  Files           760      761       +1
  Lines         21224    21250      +26
  Branches       1932     1932
============================================
- Hits          13846    13797      -49
- Misses         6090     6159      +69
- Partials       1288     1294       +6

Impacted Files
Coverage Δ

...plugin/logging/rocketmq/LoggingRocketMQPlugin.java
22.72% <0.00%> (-72.73%)
:arrow_down:

...ogging/rocketmq/body/LoggingServerHttpRequest.java
0.00% <0.00%> (-20.00%)
:arrow_down:

...che/shenyu/sync/data/http/HttpSyncDataService.java
69.10% <0.00%> (-14.64%)
:arrow_down:

...yu/sync/data/http/refresh/AbstractDataRefresh.java
70.00% <0.00%> (-13.34%)
:arrow_down:

...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java
87.50% <0.00%> (-12.50%)
:arrow_down:

...a/org/apache/shenyu/common/utils/VersionUtils.java
67.85% <0.00%> (-10.72%)
:arrow_down:

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
54.25% <0.00%> (-8.52%)
:arrow_down:

...rg/apache/shenyu/plugin/rewrite/RewritePlugin.java
66.66% <0.00%> (-5.56%)
:arrow_down:

.../logging/rocketmq/utils/LogCollectConfigUtils.java
71.11% <0.00%> (-4.45%)
:arrow_down:

...in/response/strategy/NettyClientMessageWriter.java
69.56% <0.00%> (-4.35%)
:arrow_down:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24b299b...d2015e9. Read the comment docs.


resolves #25 - use undefined date when date picker first opens

My initial commit commented out whole $scope.$watch("date", function (newValue, oldValue) { block, so the date value was not cleared with createTaskCtrl.clearFields function. I fixed it and did git commit --amend.


Updated Bitwarden publisher, offer id's and solution description

Required items, please complete
Change(s):

Updated solutions: publisher id, offer id, description

Reason for Change(s):

Consistency with the yet to be published offer

Version Updated:

No

Testing Completed:

No

Checked that the validations are passing and have addressed any issues that are present:

No

Guidance <- remove section before submitting

Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR.  Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process.  Providing associated Issues that this resolves also easily connects the reason.

Change(s):

Updated syntax for XYZ.yaml

Reason for Change(s):

New schema used for XYZ.yaml
Resolves ISSUE #1234

Version updated:

Yes
Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly.  If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:

Guidance for Detection checks
General contribution guidance
PR validation troubleshooting

Hi @mzieniukbw,
Please update the publisher ID in the SolutionMetadata file as mentioned in Partner Center. In Partner Center, you have mentioned 8bit-solutions-llc, but in the SolutionMetadata file, it is bitwarden-inc.
Also, please confirm that you mentioned the category as Security - Threat Protection in the SolutionMetadata file, but you haven't selected this security category in Partner Center.

Note: please repackage the solution again after all these changes.

@v-shukore I have updated the domain categories.
We have also updated the publisher id and categories in Partner Center, which should now match this PR.

@v-shukore Apologies, it looks like we updated publisher name, not id, which does not seem to be editable in Partner Center.
Since it's not possible to update publisher id, we will have to start the process in Partner Center from scratch - i will let you know when finished.

@v-shukore I have updated the domain categories and publisher id.
We decided not to change the publisher id in Partner Center, since we already offer other Microsoft solutions under that id.


[RHBRMS-2447] avoid WARNing in the log in case asset-mgmt-project is …

…not yet deployed
Depends on:
https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/pull/216
https://github.com/droolsjbpm/guvnor/pull/322
@manstis, @Salaboy, @nmirasch could one of you please review this?

+1 to merge.

DO NOT MERGE YET


Swap test nib to test bundle

Changes in this pull request
IGTestNibCell.xib was in the wrong bundle after imported internally (moved it to Assets dir)
Pull request checklist

[x] All tests pass. Demo project builds and runs.
[x] I have reviewed the contributing guide

iOS 9.* all tests passing


Added a failing test for #423

Current coverage is 92.85%

Merging #424 into master will increase coverage by +1.72% as of c7af8a6

@@            master    #424   diff @@
======================================
  Files           16      16
  Stmts         1173    1077    -96
  Branches       259       0   -259
  Methods        143       0   -143
======================================
- Hit           1069    1000    -69
+ Partial         25       0    -25
+ Missed          79      77     -2

Review entire Coverage Diff as of c7af8a6

Uncovered Suggestions

+0.65% via ...tives/formly-form.js#245...251
+0.56% via .../formlyCustomTags.js#9...14
+0.56% via ...tives/formly-form.js#264...269
See 7 more...

Powered by Codecov. Updated on successful CI builds.

Thanks a ton for doing this @koenweyn! This is super cool! If you could just address the one thing that I mentioned then I think we're good.

Thanks a ton!


Adapt Day1 feature to support init container in worker pod

PR Details
Today, KMM has an init container in the worker pod. This means that the init container copies all of the .ko files to the shared volume, which will be loaded into the kernel by the worker container.
This commit adds this flow to the Day1 feature.

Note
I've loaded a simple module into the kernel in a test cluster.
/assign @yevgeny-shnaidman
/cc @ybettan

/assign @yevgeny-shnaidman
/cc @ybettan

/retest

retest

/retest

/retest

/retest

/unhold


Improve designer handling of font sizes in label and button text

Recreation of pull request #212
@halatmit @jisqyv

@osmidy @jisqyv @afmckinney
The button height in the designer doesn't change when you change the fontsize, unlike with labels, where the height does change.   Also unlike the real phone, where the height changes.  You don't need to make what's shown in the designer exactly match the real phone, but it should be a reasonable approximation.  See if you can make the button height in the designer closer to what's on the phone.

@halatmit I've fixed the issue of the Button actually resizing, but now when the font size is less than 10, the button drops out of it's proper position (see border and button positions in attached image). I've tried seeing the problem but can't find it.

@osmidy @afmckinney @jisqyv
I won't get a chance to look at this quickly, but we need to bring closure to this since it's been hanging on so long.   I suggest you see how it works if you simply don't try to make the size in the designer less than 10.  If that works ok, but a comment in the code, and file the desired change as a new issue.   I assume that by now there a lot of merge conflict that need to be fixed.   The key thing is to get this out of the queue.

@halatmit @afmckinney @jisqyv
Haven't seen any conflicts; I've pulled from upstream master without issue.  Should this be closed before filing the new bug?
Other than that, I'm moving on to another ticket.

@afmckinney https://github.com/afmckinney @jisqyv
https://github.com/jisqyv
You can't close it until it's reviewed.   But I'd treat the small font
thing as a separate issue, unless the review can pick up what's wrong.  Are
you going to take my advice and force a minimum font size (in the designer
only) to avoid the errors.
Andre of Jeff should review this.
== Hal Abelson
<EMAIL_ADDRESS>Prof. of Comp. Sci. and Eng.
MIT Dept. of Elec. Eng. and Comp. Sci.
MIT Media Lab, Second Class Faculty
On Sun, Mar 15, 2015 at 5:41 PM, osmidy<EMAIL_ADDRESS>wrote:

@halatmit https://github.com/halatmit @afmckinney
https://github.com/afmckinney @jisqyv https://github.com/jisqyv
Haven't seen any conflicts; I've pulled from upstream master without
issue. Should this be closed before filing the new bug?
Other than that, I'm moving on to another ticket.
—
Reply to this email directly or view it on GitHub
https://github.com/mit-cml/appinventor-sources/pull/246#issuecomment-81253680
.

@halatmit I've added the forced font size, I'm looking at this issue: https://github.com/mit-cml/appinventor-sources/issues/180. I am open to others or different projects.

@halatmit This still needs to be opened up for review.

@afmckinney @jisqyv
Please review this.

@osmidy
This looks fine and works for buttons (also DatePicker).
Could you make a similar fix for checkbox?  Right now, if you increase the font size on a checkbox the green "frame" on the designer doesn't change, and width for the field that holds the label does not expand.  See image below:

@halatmit I don't see an immediate fix (the problems are related, but not exactly the same); it can be made a separate issue.

OK.   I'll file it as a separate issue.
== Hal Abelson
<EMAIL_ADDRESS>Prof. of Comp. Sci. and Eng.
MIT Dept. of Elec. Eng. and Comp. Sci.
MIT Media Lab, Second Class Faculty
On Mon, Apr 27, 2015 at 12:36 PM, osmidy<EMAIL_ADDRESS>wrote:

@halatmit https://github.com/halatmit I don't see an immediate fix (the
problems are related, but not exactly the same); it can be made a separate
issue.
—
Reply to this email directly or view it on GitHub
https://github.com/mit-cml/appinventor-sources/pull/246#issuecomment-96733349
.

LGTM
There's still more that can be done here, for example, when the font gets so large that the text cannot display on one line.
Also, we need to make the analogous fix for checkboxes.
But we can save that for a separate issue.

@osmidy When I do my testing, a "normal" button (i.e., one where the font size is the default) appears different int he designer. Before this change there is a 3d-ish shadow effect around the button. With this change that is missing.

@jisqyv @halatmit I was attempting to debug the shadow effect, but something is wrong with my machine.  Ant refuses to build my local appinventor with changes to my code; it seems to stick to the initial build made in the directory. I've tried different OS installs and git clones, and ant clean doesn't help either. I've been trying to debug for hours to no avail. I'll be in Monday to fix this ASAP.

@jisqyv @halatmit So my "ant bug" was really just me needing to clear my cache.  The closest I can get to proper button appearance is given by changing line 55 to "buttonWidget.setStylePrimaryName("ode-SimpleMockButton");", which shows up as seen below.

Also, I've gained some insight on the issue for sizes less than 10:  the Deckpanel contains the button, and for some reason when the font size for the button is under 10, it changes it's position . The DeckPanel stays put.

@halatmit @jisqyv Jeff, the shadow is back, but the button still looks a bit different than it does in the current version. Otherwise, functionality seems fine from my testing.

@afmckinney I'm going to look at this again.

@jisqyv did you have any look into this?

@moliata Turns out I have a simpler fix which will be pushed up as a new PR shortly.

@jisqyv that means, this pr will be closed.

This change is superseded by #929.


How to apply DIffusion-GAN to StyleGAN3

Hi, I want to ask what change I need to make to apply Diffusion-GAN to the StyleGAN3 repo ?

Hi there,
Thanks for your interest. The change could be quite simple. You could copy the diffusion.py from our file to replace the original augment.py and also replace the discriminator in StyleGAN3 with our discriminator. These are the two main steps for the move. You also need to modify some argument names and input timestep into the discriminator, but I think they can be easily debugged :).

Hi, I m looking to use your diffusion process to improve an existing GAN using the plugin approach . I don't see diffusion.py in the repo here? Perhaps it has a different name? Thanks

https://github.com/Zhendong-Wang/Diffusion-GAN/blob/main/diffusion-stylegan2/training/diffusion.py

Hello there! Just wondering how to replace the discriminator in StyleGAN3 with your discriminator ? It would be grateful if you could tell me! Thx a lot!!!


[docs] Add links to official material design spec

As many of the components are regularly readjusted to fit the official and changing material design spec, I am sometimes visiting the spec to understand it better and in more detail.
I don't know how well this idea fits with the vision for this repo, but I think it'd be useful to have a link to the relevant part in the material design spec on every component documentation that implements a part of it.
This would make it clearer why things are the way they are (mostly design-wise/visually), and why some components diverge-from/enhance google's spec.
Cons:

Official spec changes may make the components look outdated before they can be changed
More 'liberal' implementation of the spec in this library's components may have to be explained

@Floriferous Where do you want to add it? I believe we are already doing what you are suggesting. For instance with the AppBar:

How unlucky of me.. I went to the v1 website, checked Avatars and Badges (literally the only ones without a link), and then went to Component API, before creating this issue thinking it didn't exist.
😭


Improving the user experience by adding a loading state, and improving performance by updating the local state instead of re-fetching the entire cart.

Is your feature request related to a problem? Please describe.
Yes, the feature request is related to two problems. First, when fetching cart products, there's no loading state, which can lead to a poor user experience if the fetch operation takes a long time. Second, the deleteCartItem and deleteAllCartItems functions both delete items and then re-fetch the entire cart, which could be a performance issue if the cart has a lot of items.
Describe the solution you'd like
I would like two solutions to be implemented. First, add a loading state that's displayed while the fetch operation is in progress. This can be done by using a useState hook to manage the loading state. Second, instead of re-fetching the entire cart, update the local state to reflect the changes. This can be done by filtering out the deleted item from the cartItems state in the deleteCartItem function, and setting cartItems to an empty array in the deleteAllCartItems function.
Additional context
The current implementation can lead to a poor user experience and potential performance issues, especially when the cart has a lot of items. By implementing these solutions, we can improve the user experience and the performance of the application.

@SamFusedBits okay go ahead, I will mark the level after seeing your PR


Re-enable xitted tests

There are 2 tests currently xitted in the codebase:

Behavior of qualified_cop_name when 2 cops have the same name in different namespaces

Re-enabling this one by adding test cops matching this condition

One about ConfigObsoletion behavior for extracted cops which had been disabled because of random failures.

I was able to reproduce by running rspec ./spec/rubocop/config_obsoletion_spec.rb[1:1:2:3:1,1:1:3:1] --seed 47550 -fd and tracked it down to pollution of the RuboCop::ConfigObsoletion.files class variables, fixed by setting a cleanup after block for all tests in that file.
I also re-ordered values of some expect to have the expected order expect(value).to eq expected_value for the failure messages to be accurate.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[ ] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Nicely done!


What does the # token mean?

In the ohm grammar it has this:
  Modifier
    = "#" Base  -- lex
    | "$" Base  -- val
    | Base

Which seems to me to imply it is a lexical modifier!
And in the es5 grammar it has this:
ReturnStatement = return (#(spacesNoNL ~space) Expression<withIn>)? #(sc)

Where sc is, I believe, semi-colon. So I'm wondering what the # operator means. I tried digging deeper into the ohm grammar semantics but I lost the thread somewhere.

Hi Justin,
The # is Ohm's "lexification" operator -- it can be used inside a syntactic rule to prevent the implicit skipping of whitespace. Without it, the application of sc in ReturnStatement would not get a chance to inspect any whitespace. This would be problematic because in JS, a newline character can be interpreted as a logical semicolon.
Not closing this issue b/c we should document this feature.
Cheers,
Alex

While we're at it, what is the $ also?

$ was undocumented because we were planning to remove it, and it is gone now :-)


x/website: download button only knows about macOS and Windows

What is the URL of the page with the issue?
https://go.dev/, for example
What is your user agent?
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.45 Safari/537.36

Screenshot

What did you do?
Clicked the download button on the front page using a Linux machine
What did you expect to see?
A Linux tarball
What did you see instead?
A Windows MSI
Reported on Twitter by @dominikh.

I can reproduce. How was the new website tested against the old site for regressions? There's also https://github.com/golang/go/issues/49754, for example.

This is not a regression.
This part of https://go.dev/ has been like this for a very long time.
People are just paying more attention to it now.
Will fix.

I meant regression as in: new users navigating to golang.org on Linux no longer get a Linux download button by default :)

Indeed. It's much worse that go.dev has always been like that!


SurplusGuildMinter rework & other feedbacks

This PR addresses some points raised during Elliot's review (marked by their [number] below), as well as other issues discovered over the last weeks :
Elliot's review:

[1] In the repay function in LendingTerm, if interest rate is 0, or a user repaid all of their interest in the same block they call repay, then when they fully repay their loan, the issuance of credit will not decrease, and the principal will stay in the lending term

[x] Fix loan principal burn in LendingTerm._repay() (491a6be)

[5] [6] In Surplus Guild Minter, a user can only stake one time per term. If they want to increase their staked amount, they cannot do this with a single function call. Currently, the unstake function does not follow checks-effects-interactions.

[x] Rework SurplusGuildMinter to allow increasing stakes & decreasing stakes. Also add a checkpointing function getRewards. New function updateMintRatio allows both increases & decreases of positions after a CREDIT/GUILD mint ratio update. (db6f2d5)

[7] In the Proposal_0 deployment script, the timelock is incorrectly set to address 0 in the LendingTermOnBoarding contract

[x] Fix Proposal_0 deployment parameter timelock on LendingTermOnboarding, used to provide address(0) (e8b065b)

[8] Users Can Front Run a Bad Debt Markdown via the PSM

[x] Add pause redemption feature to SimplePSM (only GOVERNOR role) (eff53d56)
[x] LendingTermOffboarding: pause PSM redemptions between offboard() and cleanup() (Pause PSM redemptions when at least one term is being onboarded) (fca371c)

[9] Onboarding Contract Lacks Nonce For Terms (duplicate proposal revert error)

[x] Add salt in proposal description in LendingTermOnboarding to allow re-onboarding of a term (used to have a "duplicate proposal" error because the hashed proposalId was the same) (0922382)

[12] Issuance Cannot Revert

[x] Remove issuance() trycatch in GuildToken (ac1096a)

[13] The _proposals variable in VoltVetoGovernor is unused anywhere in the contract.

[x] Remove unused variable _proposals  in VoltVetoGovernor (63564ab)

[14] Bid Can Be Called At Auction End

[x] Fix: bid could be called at auction end (use forgive() instead) (d214f17)

[15] [17] Credit Buffer Incorrectly Updated On Bad Debt & Credit Rate Limit Replenishment Incorrect in Lending Term Multiplier on Repay

[x] RLCM replenishBuffer fixes (7517cf9)

[19] When a user calls unstake, there is no check that the resulting staked amount is either 0, or greater than or equal to the minimum staked amount.

[x] sgm.unstake check that left stake is above min (db3d652)

[20] SurplusGuildMinter: Governance Ratio Functions Do Not Emit Events

[x] Emit events on SurplusGuildMinter ratio updates (798b754)

Other issues:

Griefing of interests : before calling onBid, or before repaying a loan, a user could mint a large amount of CREDIT in the PSM, enterRebase, and pocket a large share of the interest they pay (this can be done with a flashloan with very large amounts of USDC). To mitigate this issue, we refactored the ERC20RebaseDistributor to interpolate rewards distributed over a period of 24h. This forces anyone willing to grief the interests to stay within the system for at least 24h, during which their USDC can be redeemed against and the debt ceiling of all terms is increased.

[x] Spread distributions over time in ERC20RebaseDistributor (600e524)

SurplusGuildMinter's CREDIT stakes are not isolated per-terms. A loss in term A could consume the surplus buffer above first-loss capital provided in term A, and it creates a race to exit for first loss capital staked in term B.

[x] Add per-term surplus buffer in ProfitManager, that allows the SurplusGuildMinter's CREDIT stake & unstake to only risk capital on a single term (f0280ce)

The GAUGE_CAP_TOLERANCE in LendingTerms is useless because gauge allocation is computed on post-borrow issuance. The debt ceiling of lending terms can be computed as 2 * preBorrowCreditTotalSupply * gaugeWeight / totalWeight.

[x] Remove LendingTerm.GAUGE_CAP_TOLERANCE() (c8fb932)

It is not convenient to have to provide an amount of CREDIT during borrow() for terms that have an openingFee and forces borrowers to do another approval on CREDIT during borrow for terms that have an opening fee. Another way to charge the openingFee could be to just add it to the interest owed (like an interest percentage that would accrue instantly after borrowing).

[x] LendingTerm.openingFee rework (cf6b41e)

It is not possible to open a loan on behalf of someone else (and provide the collateral for them), so it is not possible to write helper contracts that open loans on behalf of users with added features on top of the basic LendingTerm (e.g. do actions via signed messages, group borrow/repay with a PSM interaction, etc)

[x] Add 'borrower' param to LendingTerm.borrow (4716009)

Open issues closed by this PR:

Commit 0922382 closes #30
Commit db6f2d5 closes #24
Commit db6f2d5 closes #25
Commit db6f2d5 closes #26
Commit db6f2d5 closes #27

I'm going to revert commit 4716009 (that adds the borrower parameter), run prettier, and merge to main