chore: better e2e logging

Overview

Checklist

[ ] New and updated code has appropriate documentation
[ ] New and updated code has new and/or updated testing
[ ] Required CI checks are passing
[ ] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

Codecov Report

Merging #260 (74e418a) into main (e2d0f17) will increase coverage by 16.23%.
The diff coverage is 42.82%.

@@             Coverage Diff             @@
##             main     #260       +/-   ##
===========================================
+ Coverage   33.02%   49.26%   +16.23%
===========================================
  Files          22       24        +2
  Lines        2065     1626      -439
===========================================
+ Hits          682      801      +119
+ Misses       1308      723      -585
- Partials       75      102       +27

Impacted Files
Coverage Δ

orchestrator/orchestrator.go
11.74% <0.00%> (-1.37%)
:arrow_down:

relayer/relayer.go
26.80% <3.38%> (-1.85%)
:arrow_down:

rpc/tm_querier.go
28.57% <13.33%> (-28.58%)
:arrow_down:

store/fslock/locker.go
37.50% <37.50%> (ø)

store/fslock/lock_unix.go
48.27% <48.27%> (ø)

store/init.go
50.81% <50.81%> (ø)

store/store.go
52.50% <52.50%> (ø)

p2p/querier.go
75.00% <67.00%> (-5.24%)
:arrow_down:

rpc/app_querier.go
50.81% <88.46%> (+1.71%)
:arrow_up:

p2p/dht.go
72.04% <91.66%> (+3.36%)
:arrow_up:

... and 2 more

... and 3 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Initial pass at using brains for shared code

#145627521

          1 Warning

:warning:
Big PR

          1 Message

:book:
Nice, more deletions than insertions :red_circle:

  Generated by :no_entry_sign: danger


small suggestion here

https://github.com/travitch/whole-program-llvm/blob/a66eb59e0b863e38eabc1c24130dee4170edb9fd/wllvm/compilers.py#L272
remarkable work bro!
while configuring my wllvm, I get the invalid compiler err msg, after a whole bunch of searching, I found your source code here.
In user's view the String method is really not satisfying, cause when we have new versions of
clang like clang-6.0，I have to link it to another name "clang" to match your string, and if haven't found your source code, I could still stuck in this "invalid compiler" err msg.
So maybe add a few more options like more strings "clang-6.0", "clang-5.0", or consider using the path instead of matching a string.
Thanks

I just have the same problem, it really bothers me a long time. Plz fix it.

Read the README.md more carefully. Pay attention to things like LLVM_CC_NAME.

Thx for your explanation.

Appologize for my rudeness.
The LLVM_CC_NAME truly worked.

Usually it is not needed. Most installs of llvm that use a version suffix also put non-suffixed versions in an directory like
.../llvm-version/bin


Line align

Information:

Prism version: 1.28, latest from the download page
Plugins: Line Highlight, Line Numbers
Environment: Browser

Description
It's my first ride with Prism, so I do not know if this is by design, if with previous version is correct or not. Aniway, the text is not vertical aligned, the issue is more visible if data-line is set, all seems ok if line-numbers is off..
html snip:

Tested on Chrome and Firefox.
Example

It's not a whitespace issue (sorry for that, I entered the whitespace by mistake when I copied )
Take a look here: https://prismjs.com/plugins/line-numbers/ the issue is present in home page too.
I think is a theme issue, only funky and coy have a proper alignment.

Take a look here: https://prismjs.com/plugins/line-numbers/

This is the most extreme I see:

What I see (literally, I mean the screenshot) is a known issue. Due to the way line numbers are positioned, they are 2~3px too far down. The problem is that we can't fix this right now, because the fix is a breaking change.

This is the most extreme I see:

This is not so extreme, but it is annoying:

For me the numbers are ok, the code line is stick to the top.
The coy theme seem to be ok, so I thinks there is something we can do without breaking.

Just a css trick or something like that.


Update README.md

fixed typo

Thanks, I didn't notice that, can you fix also the component/react readme file?


Fix collections.deque

Could we get some context on why this is needed given the presence of from collections import deque in the file?

Traceback (most recent call last):
  File "ptftests/fib_test.py", line 232, in runTest
    self.check_ipv4_route(src_port, ip_range.get_first_ip(), exp_port_list)
  File "ptftests/fib_test.py", line 131, in check_ipv4_route
    return verify_packet_any_port(self, masked_exp_pkt, destination_port_list)
  File "/usr/lib/python2.7/dist-packages/ptf/testutils.py", line 2343, in verify_packet_any_port
    result = dp_poll(test, device_number=device_number, exp_pkt=pkt, timeout=1)
  File "/usr/lib/python2.7/dist-packages/ptf/testutils.py", line 2209, in dp_poll
    timeout=timeout, exp_pkt=exp_pkt, filters=FILTERS
  File "/usr/lib/python2.7/dist-packages/ptf/dataplane.py", line 850, in poll
    'recent_packets': collections.deque(maxlen=DataPlane.POLL_MAX_RECENT_PACKETS),
NameError: global name 'collections' is not defined

oh my bad I misread the diff :)


chore(e2e): add delete boards test case

Summary

Added MM-T4274 (functional) test for Duplicating and deleting a board

None

@yasserfaraazkhan Said PR has been merged. Please rebase then I'll take a look.

@yasserfaraazkhan Said PR has been merged. Please rebase then I'll take a look.

Sure @saturninoabril
I've rebased it. I'll cross check merge conflicts are correctly resoled. Please let know if anything I missed

Just need to remove the commits not belong to this PR

@yasserfaraazkhan I'll help clean up if you don't mind.

Apologies @saturninoabril ,
I messed up this branch locally while conflicts and ended up creating another PR. https://github.com/mattermost/mattermost-webapp/pull/12321
this has the above suggestion implemented

closing this as other PR covered review suggestions and new test cases
https://github.com/mattermost/mattermost-webapp/pull/12321


Removes null and undefined values from objects

…nd responses

lgtm

Thanks
On Mon, Feb 15, 2016 at 6:13 PM, Stelios Savva<EMAIL_ADDRESS>wrote:

lgtm
—
Reply to this email directly or view it on GitHub
https://github.com/Avocarrot/openrtb/pull/34#issuecomment-184276589.

--
George Eracleous | Co-Founder
Avocarrot http://www.avocarrot.com/ on TNW
http://thenextweb.com/insider/2015/09/10/avocarrots-new-h-e-r-o-tool-automates-native-ad-performance-for-ios-and-android-developers/
| VentureBeat
http://venturebeat.com/2015/05/19/avocarrot-takes-2m-on-its-march-to-become-the-mopub-for-native-mobile-ads/
| Forbes
http://www.forbes.com/sites/ilyapozin/2014/12/31/how-to-monetize-your-app-banner-ads-vs-native-ads-vs-in-app-purchases/2/
| TechCrunch
http://techcrunch.com/2015/02/22/and-the-best-native-ad-award-goes-to/
| AdExchanger
http://adexchanger.com/mobile/avocarrot-tool-takes-banners-and-turns-them-into-native-units/


openssl command in examples doesn't output full certificate chain (IDFGH-1300)

Environment

IDF version (run git describe --tags to find it):
// v4.0-dev-728-g826ff7186

Problem Description
The openssl command to get certificates from a server doesn't retrieve full certificate chain.
This then causes an ssl error when connecting through e.g. mqtts, https.
Expected Behavior
Command should retrieve full certificate chain.
Actual Behavior
Command only retrieves first certificate.
Steps to reproduce

HOST=letsencrypt.org
openssl s_client -showcerts -connect $HOST </dev/null 2>/dev/null|openssl x509 -outform PEM > cert.pem -> only outputs first certificate

Unfortunately I can't find a one liner which gives the correct behaviour but the following command shows the full chain which can then be extracted and copied into a file:
openssl s_client -showcerts -connect $HOST -servername $HOST
This also fixes issue #2867 for servers using SNI.

Hi @will-emmerson
Thanks for raising this issue, indeed there's a problem with some openssl commands in README.md for mqtt examples (the reason
is that iot.eclipse.org updated their certificates) and documentation for examples has to be updated, too.
In general, I do not think there is a universal openssl oneliner to output ROOT certificate. The example command you've provided
openssl s_client -showcerts -connect $HOST -servername $HOST should work in most cases, however there's no guarantee for the chain
to contain the root certificate (In that case one needs to find it by other means, usually in CA's webpage).
I will update the command in README files for the specific hosts used in examples.


Default entrypointVCLFileContent issues

Varnish by default appends its builtin.vcl to custom logic
Right now, default entrypointVCLFileContent contains several calls to return preventing builtin.vcl execution this could cause several issues or weird behaviors.
IMHO, entrypointVCLFileContent should better stick to what is needed and improve its documentation
Issues/weirdness encountered with current entrypointVCLFileContent:

All request are transformed to GET: Varnish by default only deals with GET & HEAD, see https://github.com/varnishcache/varnish-cache/blob/6.5/bin/varnishd/builtin.vcl#L65, but currently entrypointVCLFileContent includes an insensitive return (hash); preventing built-in logic to kick in. AFAIK it's not documented
Only url is used for request hashing: This makes the config unsafe when backends varying responses upon host header. Imaging a PHP application listening to both api.my.app/node/1 and www.my.app/node/1. AFAIK it's not documented
Stale objects are never used: AFAIK it's not documented

I'll suggest to remove unneeded returns from entrypointVCLFileContent, it may both limit weirdness and ease maintanibility
Best regards

Hey @NITEMAN, thanks for the issue and PR. There are a few things I need to check up on with our devops folks before proceeding. I think the returns on some of the functions are to explicitly not run the built-in VCL. The vcl_init and vcl_fini are essentially NOOPs, right (bc all the built-in functions simply return)? In regard to the hashing and vcl_recv changes, I think this change would break a lot of our existing use cases. I will double check on that. Additionally, I think the logic there is the bare minimum required for most use cases and letting that extra logic run would only slow varnish down. We are dealing with systems that are taking in tens of thousands of requests per second, so every call needs to be as responsive as possible.
I think you've pointed out some places on which we should at least update the documentation to avoid confusion. I'll get back with you in regard to the other topics discussed above.

Hello @cin  , thanks for the blazing fast feedback!
I'm pretty sure your devops folks will find out the changes to be almost neutral (unless you are relying upon the transparent method change). I didn't touch any return that could avoid builtin collisions ;)
Talking about pure performance, I'll admit we've only seen an order of magnitude less (sustained ~800req/s)... but in my experience ~20 lines of VCL logic will be hardly noticeable (over bare metal / virtualized, this will be our very first containerized setup) and should be very easy to benchmark.
Anyway a mere doc update will be great for newcomers like me! Please tell me if I can help anyhow


Explicitly configure unix socket

Resolves https://github.com/whatyouhide/redix/issues/64
Versions affected: redis_pubsub 0.2.0 with redix 0.5.2 and 0.6.0.
Fix verified as working with redix versions: 0.5.0, 0.5.1, 0.5.2 and 0.6.0.
Changes:

Update mix.exs and mix.lock to bump tiny version of redix dependency, from 0.5.0 to 0.5.2.
Explicitly call :inet.setopts/2 to configure the new socket.

Tested locally on macOS 10.12.3 with:
$ elixir -v
Erlang/OTP 19 [erts-8.3] [source] [64-bit] [smp:8:8] [async-threads:10] [hipe] [kernel-poll:false] [dtrace]
Elixir 1.4.2

Thanks @tompave. We need to bump the Redix dependency to ~> 0.5.2 in mix.exs though, mix deps.update it's not enough.

Done 👍

Let's skip the spec for the private fun because of the reasons lexmag pointed out.
On Mar 26, 2017, 1:15 PM -0700, Aleksei Magusev<EMAIL_ADDRESS>wrote:

@lexmag commented on this pull request.
In lib/redix/pubsub/connection.ex (https://github.com/whatyouhide/redix_pubsub/pull/8#discussion_r108067621):

@@ -162,6 +162,18 @@ defmodule Redix.PubSub.Connection do end end + + # Ask Redix.Utils to setup a connection, then configure the returned + # socket with http://erlang.org/doc/man/inet.html#setopts-2 + # + @spec establish_connection(Keyword.t) :: {:ok, :gen_tcp.socket} | {:error, term} | {:stop, term}

Let's see what @whatyouhide (https://github.com/whatyouhide) will say. I'd personally remove it. Without Dialyzer usage specs for private function are less useful, and tend to go out of sync with actual return.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (https://github.com/whatyouhide/redix_pubsub/pull/8#discussion_r108067621), or mute the thread (https://github.com/notifications/unsubscribe-auth/ADtcSseeF9IxvKtMk7bLYS9815cYy4j1ks5rprECgaJpZM4Mpdj5).

Ok, thank you both for the feedback.
I've removed the redundant comment and the spec.
I've been amending the same commit to keep things compact.

Thanks a lot @tompave, I'll merge this and release a new version of redix_pubsub as soon as I have some time (I'm on vacation so it could mean a few days). 💟

Thanks! Have a good time.

Hello Andrea!
Any chance you could approve this PR soon? This is causing quite of few of our apps to fail in dev, and I'd rather not have to hardcode the version for our next deployments.
Thanks a lot (for the libs and this PR :-) )

Thanks @tompave! 💟

I also released 0.3.0 of redix_pubsub.

🎉 Thanks!
0.3.0 declares redix ~> 0.5.2 as a dependency.
Are you going to release one that targets 0.6.0 too?

Yep but that will be 0.4.0 since that should have further breaking changes regarding how errors are handled. :)

👍 cheers

Thanks @whatyouhide !! Much appreciated


Add Command.options property, and make it and Command.commands readonly

Pull Request
Problem
Add Command.options, which was added to Commander in https://github.com/tj/commander.js/pull/1827
See: #46
Solution
Simple change to match Commander.
For Commander, we landed this in a major release as could break some clients. For same reason I suggest we postpone landing this until Commander 12 (having missed it until now).
ChangeLog

add: add Command.options property
change: make Command.commands a readonly property

Forgot about this and have done on 11.x! #48 #50


How

How u learn malbolge?? Very cool.

I don't think you can learn it, lol. But there's algorithms out there to generate Malbolge programs and I would guess this is a super powered version of that.

I wonder why it's all in 7z.
Would be better to put these files in Github Releases instead. And in some more supported format, maybe .tar.gz


Template management in dashboard

Adds more info to templates section
Publish/unpublish templates
Delete templates
Requires latest infra backend to test

Good to go.


header on ontology.json

curl -v -I http://buda1.bdrc.io:13280/ontology.json

gives me
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to buda1.bdrc.io (<IP_ADDRESS>) port 13280 (#0)
> HEAD /ontology.json HTTP/1.1
> Host: buda1.bdrc.io:13280
> User-Agent: curl/7.60.0
> Accept: */*
>
< HTTP/1.1 200 OK
HTTP/1.1 200 OK
< Server: Apache-Coyote/1.1
Server: Apache-Coyote/1.1
< Access-Control-Allow-Origin: *
Access-Control-Allow-Origin: *
< Access-Control-Allow-Headers: origin, content-type, accept, authorization
Access-Control-Allow-Headers: origin, content-type, accept, authorization
< Access-Control-Allow-Credentials: true
Access-Control-Allow-Credentials: true
< Access-Control-Allow-Methods: GET, POST, PUT, DELETE, OPTIONS, HEAD
Access-Control-Allow-Methods: GET, POST, PUT, DELETE, OPTIONS, HEAD
< Content-Type: text/turtle;charset=utf-8
Content-Type: text/turtle;charset=utf-8
< Transfer-Encoding: chunked
Transfer-Encoding: chunked
< Date: Fri, 25 May 2018 12:46:14 GMT
Date: Fri, 25 May 2018 12:46:14 GMT

which has several problems:

[ ] we don't want to accept PUT or DELETE methods
[ ] the content is not text/turtle

fixed as of commit 40e5f0f


Requires unknown system CONTAINER-DYNAMIC-CLASSES

I'm trying to build this library on SBCL, and I get this error:
:CONTAINER-DYNAMIC-CLASSES not found, required by #<SYSTEM "cl-markdown">

What should I do?

Any updates on this?

If you have asdf-system-connections available on your ASDF path you won't need the mysterious container-dynamic-classes package anymore. It seems the latter is obsolete, so I probably should just make asdf-system-connections a hard requirement, tbh.


The dependency safety_gym can't be found!

Hi! it seens the dependency: " safety_gym @ https://github.com/yardenas/safety-gym/tarball/dm_hack' "  can't be found!
what is the different between the safety-gym you used and the primal  safety-gym?
Thanks!

Hi @hdadong!
Can you write here the error you get?
running pip install . works on my end, so not sure what exactly the issue. Also,  https://github.com/yardenas/safety-gym/tarball/dm_hack seems to download the tarball.
You can view the code here and git diff against master branch. The main difference is running deepmind-control as backend, instead of mujoco-py (more details here). I didn't observe any changes in results by using deepmind-control, the only difference was not being able to render correctly on cluster compute while using mujoco-py (which is crucial for LAMBDA).
Let me know if that answers your question. In any case, I'm happy to help with the tarball issue.

Closing this for now, feel free to reopen if the issue persists


Pipeline workspaces not accessible in embedded Tasks

Expected Behavior
Content of Tekton Workspaces to be accessible in embedded Tasks.
Cloned github.com repo should be available through a shared workspace to Tasks subsequent to the git-clone task.
git-clone is a standalone Tektone task that clones successfully a github.com repository, and stores its content into a shared Pipeline workspace to make it available to subsequent Pipeline tasks.
Other Pipeline tasks should be able to access the contents of the shared Pipeline workspace.
Actual Behavior
Embedded Tasks cannot access Pipeline workspaces with the following error:
task show-dockerfile has failed: workspace binding "source" does not match any declared workspace

This error doesn't occur if tasks are standalone and referred to from the Pipeline. This is the case with git-clone task.
Steps to Reproduce the Problem
Deploy the attached Pipeline and PipelineRun. The logic of the Pipeline is simple - clone a public GitHub repository and then print into the logs the contents of the Dockerfile managed by the github repository.

kubectl create -f p-embedded.yaml
kubectl create -f pr-embedded.yaml
tkn p logs embedded-tasks

Additional Info

Kubernetes version:

Server Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.5+012e945", GitCommit:"3c28e7a79b58e78b4c1dc1ab7e5f6c6c2d3aedd3", GitTreeState:"clean", BuildDate:"2022-07-13T08:38:41Z", GoVersion:"go1.17.12", Compiler:"gc", Platform:"linux/amd64"}

Output of kubectl version:
(paste your output here)

Tekton Pipeline version:

Pipeline version: v0.37.4

Output of tkn version or kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'

Logs output
 $ tkn p logs embedded-tasks
+ CHECKOUT_DIR=/workspace/output/
+ '[[' true '==' true ]]
+ cleandir
+ '[[' -d /workspace/output/ ]]
+ rm -rf /workspace/output//lost+found
+ rm -rf '/workspace/output//.[!.]*'
+ rm -rf '/workspace/output//..?*'
+ test -z
+ test -z
+ test -z
+ /ko-app/git-init -url https://github.com/stefanprodan/podinfo.git -revision  -refspec  -path /workspace/output/ '-sslVerify=true' '-submodules=true' -depth 1 -sparseCheckoutDirectories
{"level":"info","ts":1667933051.8927941,"caller":"git/git.go:169","msg":"Successfully cloned https://github.com/stefanprodan/podinfo.git @ 1cf228c67b8f8102db1a6966f81a95c09954b3e8 (grafted, HEAD) in path /workspace/output/"}
{"level":"info","ts":1667933051.9264257,"caller":"git/git.go:207","msg":"Successfully initialized and updated submodules in path /workspace/output/"}
+ cd /workspace/output/
+ git rev-parse HEAD
+ RESULT_SHA=1cf228c67b8f8102db1a6966f81a95c09954b3e8
+ EXIT_CODE=0
+ '[' 0 '!=' 0 ]
+ echo -n 1cf228c67b8f8102db1a6966f81a95c09954b3e8
+ echo -n https://github.com/stefanprodan/podinfo.git

task show-dockerfile has failed: workspace binding "source" does not match any declared workspace

Pipeline p-embedded.yaml
apiVersion: tekton.dev/v1beta1
kind: Pipeline
metadata:
  name: embedded-tasks
spec:
  description: |
    This pipeline clones a git repo, then echoes the README file to the stout.
  params:
  - name: repo-url
    type: string
    description: The git repo URL to clone from.
  workspaces:
  - name: shared-data
    description: |
      This workspace contains the cloned repo files, so they can be read by the
      next task.
  tasks:
  - name: fetch-source
    taskRef:
      name: git-clone
    workspaces:
    - name: output
      workspace: shared-data
    params:
    - name: url
      value: $(params.repo-url)
  - name: show-dockerfile
    runAfter: ["fetch-source"]
    taskSpec:
      steps:
        - image: docker.io/library/golang:1.18
          script: |
            cat Dockerfile
    workspaces:
    - name: source
      workspace: shared-data

PipelineRun pr-embedded.yaml
apiVersion: tekton.dev/v1beta1
kind: PipelineRun
metadata:
  generateName: embedded-tasks-
  labels:
    pln: embedded-tasks
spec:
  pipelineRef:
    name: embedded-tasks
  workspaces:
  - name: shared-data
    volumeClaimTemplate:
      spec:
        accessModes:
        - ReadWriteOnce
        resources:
          requests:
            storage: 100Mi
  params:
  - name: repo-url
    value: https://github.com/stefanprodan/podinfo.git

Hey @dgeorgievski,
The embedded task need to define the workspace as well, in the taskSpec. The error state that "does not match any declared workspace", which means in the embedded task spec, there is not "declared" workspace named source.
apiVersion: tekton.dev/v1beta1
kind: Pipeline
metadata:
  name: embedded-tasks
spec:
  description: |
    This pipeline clones a git repo, then echoes the README file to the stout.
  params:
  - name: repo-url
    type: string
    description: The git repo URL to clone from.
  workspaces:
  - name: shared-data
    description: |
      This workspace contains the cloned repo files, so they can be read by the
      next task.
  tasks:
  - name: fetch-source
    taskRef:
      name: git-clone
    workspaces:
    - name: output
      workspace: shared-data
    params:
    - name: url
      value: $(params.repo-url)
  - name: show-dockerfile
    runAfter: ["fetch-source"]
    taskSpec:
      workspaces:
        - name: source
      steps:
        - image: docker.io/library/golang:1.18
          script: |
            cat Dockerfile
    workspaces:
    - name: source
      workspace: shared-data

Behind the enable-api-fields: alpha feature-flag, there is a way to not "declare"/repeat those as documented here, but it is not enabled by default.

Thanks @vdemeester , that resolved the issue.
I looked at the docs again to check if I missed the taskSpec.workspaces setting and couldn't find it.

https://tekton.dev/docs/pipelines/workspaces/
https://tekton.dev/docs/how-to-guides/clone-repository/

Some other people I work with had the same issue with referencing workspaces in embedded tasks. It would help others if the documentation is updated  with this requirement for embedded tasks.


Add system fields to data_entity table

We have created_at and updated_at fields in data_entity table, which are holding values, which came from collectors. However, in all other tables these fields are system fields and holding info about when row appears in our database.
Need to add additional fields, e.g. external_created_at and external_updated_at at fill them with external values and use created_at and updated_at fields for internal updates

@DementevNikita let me take it


Modifier -> SwiftUI Updated -> Lists: badgeProminence(_:) [BETA]

Doc: https://developer.apple.com/documentation/SwiftUI/View/badgeProminence(_:)

This is supported


Add documentatio for PR 156

Add docs for @deprecated commends, introduced in #156

If possible, @eakoli please have a look
(I invited you into the github organization so I can request a review from you)

Thanks for the feedback! updated the unclear parts


nan when converting neox and opt models  with AutoGPTQ-triton

Will test default cuda version next but encountering nan for all conversions using 'AutoGPTQ-triton'
Using ubuntu 22.04, python3.10, transformers 4.28(dev), 64 gigs ram, 2x RTX 24 gig cards.
Installed successfully with all dependencies.
Am I missing a particular package version?
python basic_usage.py
pretrained_model_dir = "models/gpt-neox-20b"
quantized_model_dir = "4bit_converted"
2023-04-22 13:29:42 INFO [auto_gptq.modeling._base] Quantizing attention.query_key_value in layer 1/44...
2023-04-22 13:29:47 INFO [auto_gptq.quantization.gptq] duration: 5.032277584075928
2023-04-22 13:29:47 INFO [auto_gptq.quantization.gptq] avg loss: 17.77143669128418
2023-04-22 13:29:47 INFO [auto_gptq.modeling._base] Quantizing attention.dense in layer 1/44...
2023-04-22 13:29:48 INFO [auto_gptq.quantization.gptq] duration: 1.7948594093322754
2023-04-22 13:29:48 INFO [auto_gptq.quantization.gptq] avg loss: 1.888306736946106
2023-04-22 13:29:49 INFO [auto_gptq.modeling._base] Quantizing mlp.dense_h_to_4h in layer 1/44...
2023-04-22 13:29:50 INFO [auto_gptq.quantization.gptq] duration: 1.8883254528045654
2023-04-22 13:29:50 INFO [auto_gptq.quantization.gptq] avg loss: 28.566619873046875
2023-04-22 13:29:50 INFO [auto_gptq.modeling._base] Quantizing mlp.dense_4h_to_h in layer 1/44...
2023-04-22 13:30:02 INFO [auto_gptq.quantization.gptq] duration: 11.343331575393677
2023-04-22 13:30:02 INFO [auto_gptq.quantization.gptq] avg loss: nan
2023-04-22 13:30:02 INFO [auto_gptq.modeling._base] Start quantizing layer 2/44
2023-04-22 13:30:02 INFO [auto_gptq.modeling._base] Quantizing attention.query_key_value in layer 2/44...
2023-04-22 13:30:04 INFO [auto_gptq.quantization.gptq] duration: 1.9044442176818848
2023-04-22 13:30:04 INFO [auto_gptq.quantization.gptq] avg loss: nan
etc. stopped
Similar results with opt-30b:
Same results with opt:
pretrained_model_dir = "models/opt-30b"
quantized_model_dir = "4bit_converted"
Loading checkpoint shards: 100%|██████████████| 267/267 [13:52<00:00,  3.12s/it]
2023-04-22 13:55:41 INFO [auto_gptq.modeling._base] Start quantizing layer 1/44
2023-04-22 13:55:46 INFO [auto_gptq.modeling._base] Quantizing attention.query_key_value in layer 1/44...
2023-04-22 13:55:51 INFO [auto_gptq.quantization.gptq] duration: 4.748894453048706
2023-04-22 13:55:51 INFO [auto_gptq.quantization.gptq] avg loss: 17.623794555664062
2023-04-22 13:55:51 INFO [auto_gptq.modeling._base] Quantizing attention.dense in layer 1/44...
2023-04-22 13:55:53 INFO [auto_gptq.quantization.gptq] duration: 1.8472576141357422
2023-04-22 13:55:53 INFO [auto_gptq.quantization.gptq] avg loss: 1.9249645471572876
2023-04-22 13:55:53 INFO [auto_gptq.modeling._base] Quantizing mlp.dense_h_to_4h in layer 1/44...
2023-04-22 13:55:55 INFO [auto_gptq.quantization.gptq] duration: 1.9470229148864746
2023-04-22 13:55:55 INFO [auto_gptq.quantization.gptq] avg loss: 28.64271354675293
2023-04-22 13:55:55 INFO [auto_gptq.modeling._base] Quantizing mlp.dense_4h_to_h in layer 1/44...
2023-04-22 13:56:06 INFO [auto_gptq.quantization.gptq] duration: 11.630852222442627
2023-04-22 13:56:06 INFO [auto_gptq.quantization.gptq] avg loss: nan
2023-04-22 13:56:07 INFO [auto_gptq.modeling._base] Start quantizing layer 2/44
2023-04-22 13:56:07 INFO [auto_gptq.modeling._base] Quantizing attention.query_key_value in layer 2/44...
2023-04-22 13:56:09 INFO [auto_gptq.quantization.gptq] duration: 1.975161075592041
2023-04-22 13:56:09 INFO [auto_gptq.quantization.gptq] avg loss: nan
etc. stopped

Confirming similar nan results above for main cuda branch using same models plus additional neox-20b.

I saw you were using basic_usage.py, which just using one-shot quantization(one sample) to show case the usage of basic apis, and it may encounter into 'nan' when quantize big model with such few samples. I would suggest to try quantize_with_alpaca.py which uses many instruction-following samples to quantize LLMs.
Please let me know if the same problem still occurs when using quantize_with_alpaca.py

Tested above 'quantize_with_alpaca.py' with latest 0.3 version.
Needed to change the following:
parser.add_argument("--fast_tokenizer", action="store_true")
ValueError: Tokenizer class GPTNeoXTokenizer does not exist or is not currently imported.
changed to:
parser.add_argument("--fast_tokenizer", action="store_false")
CUDA_VISIBLE_DEVICES="0" python quant_with_alpaca.py --pretrained_model_dir models/gpt-neox-20b  --quantized_model_dir 4bit_converted/neox20b-4bit.safetensor
After change the quantization proceeded without error complete with final examples from script printed to terminal.
Unfortunately, the quantized model isn't saved to  --quantized_model_dir 4bit_converted/neox20b-4bit.safetensor
2023-04-24 15:03:20 INFO [auto_gptq.modeling._utils] Model packed.
The model 'GPTNeoXGPTQForCausalLM' is not supported for .
Supported models are ['BartForCausalLM', 'BertLMHeadModel', 'BertGenerationDecoder', 'BigBirdForCausalLM', 'BigBirdPegasusForCausalLM', 'BioGptForCausalLM', 'BlenderbotForCausalLM', 'BlenderbotSmallForCausalLM', 'BloomForCausalLM', 'CamembertForCausalLM', 'CodeGenForCausalLM', 'CTRLLMHeadModel', 'Data2VecTextForCausalLM', 'ElectraForCausalLM', 'ErnieForCausalLM', 'GitForCausalLM', 'GPT2LMHeadModel', 'GPT2LMHeadModel', 'GPTNeoForCausalLM', 'GPTNeoXForCausalLM', 'GPTNeoXJapaneseForCausalLM', 'GPTJForCausalLM', 'LlamaForCausalLM', 'MarianForCausalLM', 'MBartForCausalLM', 'MegaForCausalLM', 'MegatronBertForCausalLM', 'MvpForCausalLM', 'OpenAIGPTLMHeadModel', 'OPTForCausalLM', 'PegasusForCausalLM', 'PLBartForCausalLM', 'ProphetNetForCausalLM', 'QDQBertLMHeadModel', 'ReformerModelWithLMHead', 'RemBertForCausalLM', 'RobertaForCausalLM', 'RobertaPreLayerNormForCausalLM', 'RoCBertForCausalLM', 'RoFormerForCausalLM', 'Speech2Text2ForCausalLM', 'TransfoXLLMHeadModel', 'TrOCRForCausalLM', 'XGLMForCausalLM', 'XLMWithLMHeadModel', 'XLMProphetNetForCausalLM', 'XLMRobertaForCausalLM', 'XLMRobertaXLForCausalLM', 'XLNetLMHeadModel', 'XmodForCausalLM'].
prompt: Instruction:
Name three characteristics commonly associated with a strong leader.
Output:
etc.
Tested 3x. '4bit_converted' folder exists at same level as scripts and models
Am I missing a command to save the model to a local folder or has it been saved to another default location?
Thanks

There are two things you should be aware of, maybe it's my bad that don't make it clear in example's README:

there is not need to change the original command line flag's functionality, you can just enable --fast_tokenizer in command when using gpt_neox type models for it only have GPTNeoXTokenizerFast
value for --quantized_model_dir should be a path to local directory, not a file, but you can check if the quantized model save into a dir named 4bit_converted/neox20b-4bit.safetensor

Thanks for the update. Model saved in '4bit_converted' in .bin format.
The model 'GPTNeoXGPTQForCausalLM' is not supported for . is still generated but not a big deal.
How to save as safetensors? Will run again using:
model.save_quantized(args.quantized_model_dir, use_safetensors=True)
Also, is there a simple inference script to use with the generated model above?
Cheers

The model 'GPTNeoXGPTQForCausalLM' is not supported for
this is a warning throw by Hugging Face transformers, you can just ignore it, I will find a way to bypass it in the future.

is there a simple inference script to use with the generated model above
I would consider to write one as soon as possible in examples, for now you can reference to this code snip:

from auto_gptq import AutoGPTQForCausalLM
from transformers import AutoTokenizer, TextGenerationPipeline

text = "Hello, World!"

tokenizer = AutoTokenizer.from_pretrained(tokenizer_dir)
model = AutoGPTQForCausalLM.from_quantized(quantized_model_dir, device="cuda:0")
pipeline = TextGenerationPipeline(model=model, tokenizer=tokenizer, device="cuda:0")
generated_text = pipeline(text, return_full_text=False, num_beams=1, max_new_tokens=128)[0]['generated_text']
print(generated_text)


Add some emojis in a dummy PR

Details
dummy PR as part of testing https://github.com/Expensify/Expensify.cash/pull/1745
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/155208
Tests
Merge to test

Stealing this review as @roryabraham and I are testing the new deploy process in https://github.com/Expensify/Expensify.cash/pull/1745

@AndrewGable looks like this was merged without passing tests. Please add a note explaining why this was done or remove the Emergency label if this is not an emergency.

@botify - Merged to unblock deploys as this test is blocking any future PRs from being deployed.


Write too fast result in lost data

Main.zip
Bug Report
Current Behavior
I use RedisClusterAsyncCommands<String, String> to hset datas.Then the part of the data will be lost.When you add a Thread ,in the thread do a empty while,will not be lost data.
I use lettuce-core-5.1.6.jar.
No Stack trace

Stack trace
// your stack trace here;

Input Code

Input Code
// your code here;

Expected behavior/code

Environment

Lettuce version(s): [e.g. 5.1.16.RELEASE.jar]
Redis version: [e.g. 4.0.9]

Possible Solution

Additional context

Can you provide us with a reproducer, ideally a GitHub repository that is able to demonstrate the issue? Right, we have a hard time understanding the issue.

    CountDownLatch latch = new CountDownLatch(1);
    latch.await();
    add the two line code can resolve the problem.beacuse all Thrad run down.part of  the data not write to the tcp connect.

Sorry!


Prepare for the next release

crossbeam-channel 0.5.4 -> 0.5.5

Replace Spinlock with Mutex. (#835)

crossbeam-epoch 0.9.8 -> 0.9.9

Replace lazy_static with once_cell. (#817)

crossbeam-utils 0.8.8 -> 0.8.9

Replace lazy_static with once_cell. (#817)

bors r+


Create fully automated kit build

Currently the kit build process is a mix of automated (./refine dist 3.4) and manual steps (tag, edit, upload, etc).
Proposed solution
Integrate as many steps as possible into the automated procedure, including:

checking prerequisites: Apple & Google credentials, other?
setting release version string
tagging release in git
injecting Google credentials
downloading/caching Windows & Mac JREs to be bundled
building all 4 kits - Windows (x2), Mac, Linux
compressing .dmg
signing release artifacts
creating Github release & uploading artefacts (marked as draft until manually reviewed/published)

Alternatives considered
We could keep our current mix of manual and automated steps, but the higher the number of manual steps, the more error-prone it will be.

I have made quite some progress in this direction, by scripting the release process in a Github action and in the Maven configuration. What is currently left is:

setting release version string
tagging release in git
creating Github release
uploading artifacts from Maven Central to the Github release

It is already much better than before in my opinion, but still not perfect!

I am satisfied with the current process for now, so unassigning myself.

I would even argue that the rest ought to stay manual - I don't think we should really expect to have a script that creates and pushes a git tag and the corresponding GitHub release - those are administrative steps that we can expect of maintainers, I would say.
More automation can go into updating the download page (so that it always displays the latest release without us needing to update the Markdown source every time), but that's not for this repository. We also have another issue (#2359) to automate the writing of the changelog.


Update HIP-904: AccountUpdateTransaction to allow maxAutomaticTokenAssociations value to support -1 as a valid value

This change is being introduced in Services 0.51

No change required to SDK to support -1 value. Integration tests need to be implemented.


Update the organisation to optics.dev

Apparently It is a bad idea to change the organization without changing the package name
https://gitter.im/typelevel/general?at=5fa531d7f2fd4f60fc58fc19


Fix compare where portal elements are different instance to main window

Fixes an issue where if you use the react portals with a window.open, the HTMLElement in the window is a different instance to the one in the main window, meaning you would always get an error.

Great catch, thanks.


Make it clear that OPRI is not actually a register that is usable from a normal cartridge game/rom

The current description of OPRI does not make it clear that changing it outside of the boot rom has no effect.
While maybe there will be a way found in the future to effect the mode, as long as we don't know, it's better not to word this so as if this register actually does something.

Thanks @daid ! I've just put the warning in a "to be verified" box.

As mentioned in another commit, writing to OPRI has an effect if a PGB value (0xX8, 0xXC) is written to KEY0 but STOP hasn't been executed yet, and the write takes effect instantly. It does not have an effect, at least not an instant effect, if written to during CGB or DMG mode after the boot ROM has been unmapped. It is not known if triggering a PSM NMI, which remaps the boot ROM, has an effect on this register's behavior.

Thanks @LIJI32 . I'll add this information to the box


Automatically remove old gitfs locks

👍

Have we had chance to test this? ( to verify that it fixes the problem we're after )

Yes, I used kill -9 to get Hubble to leave a lockfile and then tested to make sure this code removes it and that Hubble goes back to running fine.


Move info on contributing to docs out of toplevel readme

I remove the part on "finding docs-archive". Figured enough time has passed that we can get rid of that.

ping @caseydavenport , I rebased this and applied your suggestions.


”Vorța” is listed in the drop-down menu

Description:
"Vorța" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "Vorța" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Vorța, HUNEDOARA".


Fix invalid ZoneId test on Scala.js

This test intermittently fails on Scala.js with scala-java-time (running sbt validateJS):
[info] Decoder[ZoneId]
[info] - should fail for invalid ZoneId *** FAILED ***
[info]   TestFailedException was thrown during property evaluation.
[info]     Message: decodingResult.swap.exists(((x$6: io.circe.DecodingFailure) => x$6.message.contains(scala.StringContext.apply(", invalid format: ", ")").s(s)))) was false
[info]     Location: (JavaTimeCodecSuite.scala:143)
[info]     Occurred when passed generated values (
[info]       arg0 = "" // 13 shrinks
[info]     )

This is because of scala-java-time's error messages for ZoneId, which is arguably a bug there. We don't run validateJS in CI, so it's not a big deal, but it would be nicer for contributors who are running the Scala.js tests if we could work around the scala-java-time bug until it's fixed.

This issue has been fixed by the upgrade of scala-java-time to 2.0.0 in #1448. The corresponding scala-java-time PR is https://github.com/cquiroz/scala-java-time/pull/133.


Update find section screenshot in UG

Closes #377, closes #352
Also adds spacing between Back to Table of Contents for some sections. Deleted alternative class diagram for tag.

Codecov Report
Base: 56.77% // Head: 56.74% // Decreases project coverage by -0.03% :warning:

Coverage data is based on head (3cf7963) compared to base (a629d4c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #439      +/-   ##
============================================
- Coverage     56.77%   56.74%   -0.04%
- Complexity      933      935       +2
============================================
  Files           186      186
  Lines          4097     4108      +11
  Branches        546      551       +5
============================================
+ Hits           2326     2331       +5
- Misses         1642     1646       +4
- Partials        129      131       +2

Impacted Files
Coverage Δ

...seedu/uninurse/logic/parser/FindCommandParser.java
76.92% <0.00%> (-23.08%)
:arrow_down:

...ninurse/logic/parser/ViewPatientCommandParser.java
90.00% <0.00%> (-10.00%)
:arrow_down:

...ain/java/seedu/uninurse/ui/UpdatedPatientCard.java
0.00% <0.00%> (ø)

...ava/seedu/uninurse/logic/commands/FindCommand.java
90.00% <0.00%> (ø)

...logic/parser/DisplayTasksGenericCommandParser.java
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


engine token and syntax grammatic

Commit  6e745d9

https://github.com/tonnytg/42_minishell/pull/74

Only can run command and node token it is WORD


Update readme

Coverage remained the same at 99.405% when pulling 3945fb84683b6a8ad8a1ff2996eb99b52502bc08 on NathanSpeidel:update-readme into 58968370a40f309c5c31e44816238efeb7abaad2 on bullet-db:master.


Spanish Language Support

[x] Release beta version
[x] Clean up keys
[ ] Collect missing keys from test users

Please leave comments here for missing spanish translations!

Clean up keys task completed: https://github.com/fh-fvtt/zweihander/pull/180

Step 3 of the project I think is already done with: https://github.com/fh-fvtt/zweihander/pull/181
Now bugfixes, I think this issue can stay opened in case someone reports something related to localization

Closing. Issues with translations can be reported over at the Discord.


Bump AWS account limit

This PR bumps the AWS account limit in the account controller.

:+1:

/lgtm

+1


Please re-write examples to use with ... as request: style

The examples, at least simpletest, use code structured like this:
print("Fetching text from %s" % TEXT_URL)
response = requests.get(TEXT_URL)
print("-" * 40)

print("Text Response: ", response.text)
print("-" * 40)
response.close()

In modern Python, using a with statement is idomatic and provides the best resource management, because the need to manually call close (including in exception cases) is removed:
print("Fetching text from %s" % TEXT_URL)
with requests.get(TEXT_URL) as response:
    print("-" * 40)
    print("Text Response: ", response.text)
    print("-" * 40)

@justmobilize thanks!

@jepler you are quite welcome


Try more places for validation data; workaround CMake FindCUDA bug.

Fixes #232.

Try NMC_DATADIR environment variable for validation data path, or else if the #defined NMC_DATADIR does not point to a directory, try ./validation/data and ../validation/data.
Don't define NMC_DATADIR if CMake version 3.7 or 3.8.
Extend C++17 filesystem emulation with (POSIX) implementation of is_directory and supporting classes, functions and enums filesystem_error, file_status, status(..), file_type and perms.

The meat (i.e. interface to the OS function) is required anyway; the extra lines are interface fluff to make it align with the C++17 way of doing things. Should we ever want to support Windows, we get to keep the interface, but will have to substitute a Windows-specific implementation regardless.
The stat equivalents for Windows will likely be the straightforward ones, while making a path class for Windows will be more work, especially if we want to be good citizens and handle UTF-16 paths correctly.

The compilation error on OS X is due to my misuse of _POSIX_C_SOURCE. Will fix.

Updated with commit that omits preprocessor test and fixes _POSIX_C_SOURCE usage.

Additional fix to make test_cuda.exe build with CMake 3.7/3.8.

Updated with comments + clearer implementation for find_datadir().


Welcome text not well readable in dark mode

The welcome text is middle-grey and purple on black in dark mode. Especially the purple text is super hard to read. Also the grey text is not well readable due to the low(er) contrast.
Also grey on white may not offer the best contrast.
#a11y

Thank you for the feedback.

Here's an example of how the new purple text looks in dark mode:

Here's an example of how the new purple text looks in dark mode: Screenshot_20230113-212638 (1).

Color choices were based on https://m2.material.io/design/color/dark-theme.html
Would the following changes be suitable to address the UX accessibility problems ?
For dark mode, use a lighter purple color for the purple text on black.
For light mode, change grey text on white background to black text on white background.
PRs are also welcome.


Replace the magic numbers in profiler automation with something saner

Currently this is hardcoded pixel values matching the resolution and density of a PixelXL I used for tests. Might be able to calculate this from density with something like
adb shell wm size | grep -o -E '[0-9]+' and
adb shell wm density | grep -o -E '[0-9]+'

Another option is to pass arguments with intent parameters or using react-native deep link url then handle them in the profiler app


Execute all operations by pressing enter button

Right now application to run counts needs to click combination Ctrl+E. An Enter button must be setted to run count operation.

Enter is a current key to run calculations.


Catch Class not registered exception in case of missing Media Player/…

…Media Features
Updated the docs accordingly
This fixes #367

LGTM


Twilioquest branch

Checklist

[x] I ran npm test locally and it passed without errors.

[x] I only edited the _data/pixels.json file.

[x] I entered the username in the pixels.json that I'm also using to create this pull request.
[x] I acknowledge that all my contributions will be made under the project's license.

The mergify bot is incorrectly labelling users' pixels after my entry as having been deleted. However, it's not possible to add a new pixel to the end of the JSON object and maintain the sorted order as the last pixel has already been taken-- hence the need to add a row a little further up from the end.


Add Racetrack logo icon

I expect you've read all 5k lines of XML in the SVG. There could be bugs.


StackOverflowException with PyMySQL==0.7.11

The language server raises StackOverflowException and won't start up, if my code imports pymysql. The code itself runs well, just the language server keep crashes.

Environment: macOS Mojave 10.14.4
Python: 2.7.15 with pyenv and virtualenv
VSCode: 1.34.0 (1.34.0) a622c65b2c713c890fcf4fbf07cf34049d5fe758
Microsoft Python Language Server version <IP_ADDRESS>
Installed PyMySQL==0.7.11 and import it from code.

Debug info from python outputs:
[Info  - 11:42:33 AM] Microsoft Python Language Server version <IP_ADDRESS>
[Info  - 11:42:33 AM] Initializing for /Users/xxxx/.pyenv/versions/2.7.15/bin/python
Process is terminating due to StackOverflowException.

Any specific code fragment you can provide?

Any specific code fragment you can provide? Or just import pymysql reproes it?

yeah, just import pymysql reproes it.


Update IMPLEMENTATION_COVERAGE.md

ec2 run_instances() seems to be implemented here and should be marked as such

Coverage decreased (-0.3%) to 94.141% when pulling 4f9c7aae5eeca0072338c71ce1dbb3963924638b on Ellynas:patch-1 into 3bc18455a2dad70148dc095435a55b2a43eaeac1 on spulec:master.


[v2] rust: Write to .cargo/config.toml instead of .cargo/config

Description of changes
Changes the rust infra to write cargo config to .cargo/config.toml insted of .cargo/config since the latter is deprecated (since 1.38?) and is now warning on stderr.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Changes since v1:

Avoid changing cargoHash for FOD
Build/fixup more packages

This time I've verified that no cargoHash changes to FOD happens:
[18:14:12]-[~/c/g/n/nixpkgs]-[manny@c3mv18nix]
git status
On branch rust-write-config.toml-not-config
nothing to commit, working tree clean
[18:14:18]-[~/c/g/n/nixpkgs]-[manny@c3mv18nix]
git rev-parse HEAD
c935d4b1ba9800c06629b7d3c39f156d52c32c9d
[18:14:20]-[~/c/g/n/nixpkgs]-[manny@c3mv18nix]
git grep cargoHash pkgs/by-name/co/commitmsgfmt/package.nix
pkgs/by-name/co/commitmsgfmt/package.nix:  cargoHash = "sha256-jTRB9ogFQGVC4C9xpGxsJYV3cnWydAJLMcjhzUPULTE=";
[18:14:24]-[~/c/g/n/nixpkgs]-[manny@c3mv18nix]
sed -i '/cargoHash/ s|".*"|""|' pkgs/by-name/co/commitmsgfmt/package.nix
[18:14:53]-[~/c/g/n/nixpkgs]-[manny@c3mv18nix]
nix-build -A commitmsgfmt 2>&1 | tail -n 5
calling 'postFixup' function hook '_multioutPropagateDev'
error: hash mismatch in fixed-output derivation '/nix/store/k0sfjvbjx1binzpm5b36n02a030rzdy9-commitmsgfmt-1.6.0-vendor.tar.gz.drv':
         specified: sha256-AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=
            got:    sha256-jTRB9ogFQGVC4C9xpGxsJYV3cnWydAJLMcjhzUPULTE=
error: 1 dependencies of derivation '/nix/store/x925hf14jii50vzlniamja7yb2726dzd-commitmsgfmt-1.6.0.drv' failed to build
[--:--:--]-[~/c/g/n/nixpkgs]-[manny@c3mv18nix]

This should be the proper fix to close https://github.com/NixOS/nixpkgs/issues/320294

And same steps to verify no change to cargoHash now off of staging:
[20:23:02]-[~/c/g/n/nixpkgs]-[manny@c3mv18nix]
git status
On branch rust-write-config.toml-not-config
nothing to commit, working tree clean
[20:23:04]-[~/c/g/n/nixpkgs]-[manny@c3mv18nix]
git rev-parse HEAD
4d384b1cf0afb65a5b1c3e7ecb4754a292662bcb
[20:23:08]-[~/c/g/n/nixpkgs]-[manny@c3mv18nix]
git grep cargoHash pkgs/by-name/co/commitmsgfmt/package.nix
pkgs/by-name/co/commitmsgfmt/package.nix:  cargoHash = "sha256-jTRB9ogFQGVC4C9xpGxsJYV3cnWydAJLMcjhzUPULTE=";
[20:23:10]-[~/c/g/n/nixpkgs]-[manny@c3mv18nix]
sed -i '/cargoHash/ s|".*"|""|' pkgs/by-name/co/commitmsgfmt/package.nix
[20:23:14]-[~/c/g/n/nixpkgs]-[manny@c3mv18nix]
nix-build -A commitmsgfmt 2>&1 | tail -n 5
calling 'postFixup' function hook '_multioutPropagateDev'
error: hash mismatch in fixed-output derivation '/nix/store/y58pyqfr0ad4pwwkwn4mlnr1bvn7xzsf-commitmsgfmt-1.6.0-vendor.tar.gz.drv':
         specified: sha256-AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=
            got:    sha256-jTRB9ogFQGVC4C9xpGxsJYV3cnWydAJLMcjhzUPULTE=
error: 1 dependencies of derivation '/nix/store/vxhj2yakd59ciqip8my6zz39pahj83vd-commitmsgfmt-1.6.0.drv' failed to build

I'm not sure if this will just time out or not, but let's see.
@ofborg build fd

@winterqt looks like it succeeded (FOD being FOD, its not much a signal though... right?). Any other worries? Also ping ping @zowoq  @figsoda @Mic92 @mbalatsko

This is an improvement over the status quo either way, but: this doesn’t adjust the fetchCargoTarball behaviour, which is good, but that means it’s still writing to the deprecated location. Doesn’t that mean we’ll still get warnings if we don’t mv or ln it in the build hooks? Do we not use those files at all somehow?

Would we want to symlink ln -s .cargo/config.toml .cargo/config  for compatibility to cargo 1.38 and earlier proactively, or should we wait for some occurrence?
Closes #334857

From discussion on Matrix I think we decided that we don’t need to support 5+ year old compilers in Nixpkgs.

From discussion on Matrix I think we decided that we don’t need to support 5+ year old compilers in Nixpkgs.

Fair enough. And if there would be a package that could absolutely not be built on a newer rust, they could create the symlink in their derivation anyways.

This is an improvement over the status quo either way, but: this doesn’t adjust the fetchCargoTarball behaviour, which is good, but that means it’s still writing to the deprecated location. Doesn’t that mean we’ll still get warnings if we don’t mv or ln it in the build hooks? Do we not use those files at all somehow?

code comments say this only applies when depending on a git repo. I'm not sure if I built one of those explicitly, let me check (currently rebuilding everything as I ran a gc and did not cache any of this remotely ...)

Rebased on latest staging to handle the conflict, looks like I'm rebuilding the world ...

commitmsgfmt FOD hash checks out as no changes after rebase.


why is user_info_size limited to 32 bit?

I don't see any reason why the user info size should be limited to 32 bits...

see also issue #9

You are right. The limitation is reverted.


remove toString() for compatability with DJ5

Here is the patch, do with it what you want.
I removed toString() in all places it was followed by a toInt or toDouble (for times).
times and contest data can be seen correctly.
the live view does not work.

You are a hero, thanks!

No problem :smile:
Thanks to my last minute effort we had a great prize ceremony. It turned out to be quite an exciting final hour.


Crashes on start, have tried recreating the container and changed the /config directory

I am not sure how to fix this but this is what happens everytime I start it. I've changed the config directory with no luck.  How can it be solved?

Looks like the files permissions are incorrect with the image...
Are you sure the image has been removed ?  You should be able to run the following command and see the image downloaded again:
docker rmi jlesage/jdownloader-2 && docker run --rm jlesage/jdownloader-2

It's related to Synology update Version 7.1.1-42962 Update 5. My NAS installed it on April 18. Same day since JDownloader is broken.
Your proposal didn't work:
root@DiskStation:~# docker rmi jlesage/jdownloader-2 && docker run --rm jlesage/jdownloader-2
The specified image is depended by container jlesage-jdownloader-21.
[init        ] container is starting...
[cont-env    ] loading container environment variables...
[cont-env    ] APP_NAME: executing...
[cont-env    ] APP_NAME: /etc/cont-env.d/APP_NAME: line 1: JDownloader: not found
[cont-env    ] APP_NAME: terminated successfully.
[cont-env    ] APP_NAME: loading...
[cont-env    ] DISPLAY: executing...
[cont-env    ] DISPLAY: terminated successfully.
[cont-env    ] DISPLAY: loading...
[cont-env    ] DOCKER_IMAGE_PLATFORM: executing...
[cont-env    ] DOCKER_IMAGE_PLATFORM: /etc/cont-env.d/DOCKER_IMAGE_PLATFORM: line 1: linux/amd64: not found
[cont-env    ] DOCKER_IMAGE_PLATFORM: terminated successfully.
[cont-env    ] DOCKER_IMAGE_PLATFORM: loading...
[cont-env    ] DOCKER_IMAGE_VERSION: executing...
[cont-env    ] DOCKER_IMAGE_VERSION: /etc/cont-env.d/DOCKER_IMAGE_VERSION: line 1: 23.03.1: not found
[cont-env    ] DOCKER_IMAGE_VERSION: terminated successfully.
[cont-env    ] DOCKER_IMAGE_VERSION: loading...
[cont-env    ] GTK2_RC_FILES: executing...
[cont-env    ] GTK2_RC_FILES: terminated successfully.
[cont-env    ] GTK2_RC_FILES: loading...
[cont-env    ] GTK_THEME: executing...
[cont-env    ] GTK_THEME: terminated successfully.
[cont-env    ] GTK_THEME: loading...
[cont-env    ] HOME: executing...
[cont-env    ] HOME: terminated successfully.
[cont-env    ] HOME: loading...
[cont-env    ] INSTALL_PACKAGES_INTERNAL: executing...
[cont-env    ] INSTALL_PACKAGES_INTERNAL: terminated successfully.
[cont-env    ] INSTALL_PACKAGES_INTERNAL: loading...
[cont-env    ] QT_STYLE_OVERRIDE: executing...
[cont-env    ] QT_STYLE_OVERRIDE: terminated successfully.
[cont-env    ] QT_STYLE_OVERRIDE: loading...
[cont-env    ] TAKE_CONFIG_OWNERSHIP: executing...
[cont-env    ] TAKE_CONFIG_OWNERSHIP: /etc/cont-env.d/TAKE_CONFIG_OWNERSHIP: line 1: 1: not found
[cont-env    ] TAKE_CONFIG_OWNERSHIP: terminated successfully.
[cont-env    ] TAKE_CONFIG_OWNERSHIP: loading...
[cont-env    ] XDG_CACHE_HOME: executing...
[cont-env    ] XDG_CACHE_HOME: /etc/cont-env.d/XDG_CACHE_HOME: line 1: /config/xdg/cache: not found
[cont-env    ] XDG_CACHE_HOME: terminated successfully.
[cont-env    ] XDG_CACHE_HOME: loading...
[cont-env    ] XDG_CONFIG_HOME: executing...
[cont-env    ] XDG_CONFIG_HOME: /etc/cont-env.d/XDG_CONFIG_HOME: line 1: /config /xdg/config: not found
[cont-env    ] XDG_CONFIG_HOME: terminated successfully.
[cont-env    ] XDG_CONFIG_HOME: loading...
[cont-env    ] XDG_DATA_HOME: executing...
[cont-env    ] XDG_DATA_HOME: /etc/cont-env.d/XDG_DATA_HOME: line 1: /config/xdg/data: not found
[cont-env    ] XDG_DATA_HOME: terminated successfully.
[cont-env    ] XDG_DATA_HOME: loading...
[cont-env    ] XDG_RUNTIME_DIR: executing...
[cont-env    ] XDG_RUNTIME_DIR: /etc/cont-env.d/XDG_RUNTIME_DIR: line 1: /tmp/run/user/app: not found
[cont-env    ] XDG_RUNTIME_DIR: terminated successfully.
[cont-env    ] XDG_RUNTIME_DIR: loading...
[cont-env    ] XDG_STATE_HOME: executing...
[cont-env    ] XDG_STATE_HOME: /etc/cont-env.d/XDG_STATE_HOME: line 1: /config/xdg/state: not found
[cont-env    ] XDG_STATE_HOME: terminated successfully.
[cont-env    ] XDG_STATE_HOME: loading...
[cont-env    ] container environment variables initialized.
[cont-secrets] loading container secrets...
[cont-secrets] container secrets loaded.
[cont-init   ] executing container initialization scripts...
[cont-init   ] 10-certs.sh: executing...
[cont-init   ] 10-certs.sh: terminated successfully.
[cont-init   ] 10-check-app-niceness.sh: executing...
[cont-init   ] 10-check-app-niceness.sh: terminated successfully.
[cont-init   ] 10-cjk-font.sh: executing...
[cont-init   ] 10-cjk-font.sh: terminated successfully.
[cont-init   ] 10-clean-logmonitor-states.sh: executing...
[cont-init   ] 10-clean-logmonitor-states.sh: terminated successfully.
[cont-init   ] 10-clean-tmp-dir.sh: executing...
[cont-init   ] 10-clean-tmp-dir.sh: terminated successfully.
[cont-init   ] 10-fontconfig-cache-dir.sh: executing...
[cont-init   ] 10-fontconfig-cache-dir.sh: terminated successfully.
[cont-init   ] 10-init-users.sh: executing...
[cont-init   ] 10-init-users.sh: terminated successfully.
[cont-init   ] 10-nginx.sh: executing...
[cont-init   ] 10-nginx.sh: terminated successfully.
[cont-init   ] 10-openbox.sh: executing...
[cont-init   ] 10-openbox.sh: terminated successfully.
[cont-init   ] 10-set-tmp-dir-perms.sh: executing...
[cont-init   ] 10-set-tmp-dir-perms.sh: terminated successfully.
[cont-init   ] 10-vnc-password.sh: executing...
[cont-init   ] 10-vnc-password.sh: terminated successfully.
[cont-init   ] 10-web-data.sh: executing...
[cont-init   ] 10-web-data.sh: terminated successfully.
[cont-init   ] 10-x11-unix.sh: executing...
[cont-init   ] 10-x11-unix.sh: terminated successfully.
[cont-init   ] 10-xdg-runtime-dir.sh: executing...
[cont-init   ] 10-xdg-runtime-dir.sh: mkdir: can't create directory '': No such file or directory
[cont-init   ] 10-xdg-runtime-dir.sh: terminated with error 1.

Looks like the files permissions are incorrect with the image...
Are you sure the image has been removed ? You should be able to run the following command and see the image downloaded again:
docker rmi jlesage/jdownloader-2 && docker run --rm jlesage/jdownloader-2

100% it's been removed

I removed JDownloader container and JDownloader Image in Docker and removed JDownloader folder in docker folder on HDD, too.
After complete full installation it works now.

I am not sure why I can't just use the latest tag and it will work

I removed JDownloader container and JDownloader Image in Docker and removed JDownloader folder in docker folder on HDD, too.
After complete full installation it works now.

Does this mean that the image was not removed in what you reported in https://github.com/jlesage/docker-jdownloader-2/issues/150#issuecomment-1518350832 ?

@twist3dimages, what version of unRAID are you using ?  What kind of Docker data-root did you setup (btrfs, ifs, directory) ?

Also, note that when the image is really removed, you should see an output similar to this one:
$ docker rmi jlesage/jdownloader-2 && docker run --rm jlesage/jdownloader-2
Untagged: jlesage/jdownloader-2:latest
Deleted: sha256:30b706f7ad844329564f0d7c6ba881824b53fbee8f3d321bb252f5a2c3efe333
Deleted: sha256:9d9dec59622365642437ddfa41a6b947ba6a9d85acec4c17caf48f8b3eae2ce4
Deleted: sha256:d3f2cae69a6c59f3620c401b3fcae3be30147d22595d0c6c3855aee7725e1486
Deleted: sha256:e818c2d80617becbfce482c2211dfe362e8f7335d052475cf7d991b016d69c95
Deleted: sha256:269a2b3d1d08533421596c4af4a1de0f0ea08cc5fc369f5b584f9c377f86a150
Deleted: sha256:8d48e64e47199319b0893bc2a8aaefbaaeca9ce7e9737ec3e80f8bd356993499
Deleted: sha256:78611eb354c10097222df265db85885e0c96e5971a0e235ac22666b890b69765
Deleted: sha256:56a3a1aa7b8aaf13e63bdd72504baf7dcd1a84eb5f339fcffecdc7348090d44c
Deleted: sha256:d86edcb00387af76be8bbc346b091c95b6ee5054c03069c20259d2df06a3b0c8
Deleted: sha256:87afa386cb544580c7da5374e5e383574289044fa2c1d549b41cf90331f562d3
Deleted: sha256:948da14168eddbd66599916f5b0135a2141ac416826c9b43aa78be93cd8b061a
Deleted: sha256:bcc29a2cf20365bf04841a63866b7a86bdaf1d5bbb2a18cefd11ff1578a00b72
Deleted: sha256:627da07a9512f5a74a3131d33b9634c27c06e6ad37a5d8575173c194fe448f85
Deleted: sha256:b06032a360deea994fd30a64411c181a5ebf2fea4019511381960969813559f5
Deleted: sha256:a743c7d077d59e49402f55379e1ae9d74971d70ce0265e56a53a7c3162b0a802
Deleted: sha256:275b9f8a1fa0848766bfc044eff405446532d2ae19f21c826c18f78311a87785
Deleted: sha256:ab9f76565b27c3ecf0c3ee71c8ce1c089e40b02ce94faf44ea99435611c0d4d4
Deleted: sha256:28e10db42fbaf314b91702e730d8ed7274524375efe5191be58cd031b9c3d3e3
Deleted: sha256:0b25846d2bca93ba8edbda323fc9630acc7d641829ba1912cf03fe0a7d9ee714
Deleted: sha256:3da9171d4fef537ad2b2e6dadd4919981c309a66b86db433c4759e12a760cb52
Deleted: sha256:cae435f27d3728b66a9b0e3d15f7138d03a82a69a353a90ed15350db76431664
Deleted: sha256:0cc40a14cf954804450920f2c5e10aee9c4f478c0aa063c8b4609f766e4dbe8b
Deleted: sha256:58c0800f8fa35f0bb370ddbde6d85d059ca1c627f4b9d12d2b469139461c2c46
Deleted: sha256:e589d691f1507ef4e9cedc475f469d04a90649882a9f422397eba188b7b81555
Deleted: sha256:d71a7ae7bd6ec2543293131c942d95e4cedcb0a66c4958c1e7ce83c69ed20a1a
Deleted: sha256:a5caf0c64d196bb8d4fe06f57c41d94bf7e9af1635f9a78a8f947fb06cace95c
Deleted: sha256:edb18acb0b38b3b221e213fdc51116d59e040bb130549b02b987e79ca8c195e2
Deleted: sha256:0f3412e76d9413d94e33109e67b248924a4c081e7acaa43eb6f56b85dd2da5eb
Deleted: sha256:bb9eba3bd3ac4b5844d2bcd3dc62ad1a2b9a6c44ee36e9f090b8d29066f5e684
Deleted: sha256:e37891ae1cd22c9eefbd506c9c27eae7150b0ab4162b6bdd55d74c7d83a3b8f7
Deleted: sha256:b89ef6edb634a3cb62f8b592c8030aeeb385f58ace76bea0a001e5f5098a0869
Unable to find image 'jlesage/jdownloader-2:latest' locally
latest: Pulling from jlesage/jdownloader-2
ef5531b6e74e: Already exists
4f4fb700ef54: Already exists
84e5e0a543c2: Already exists
ca8059c6dc96: Already exists
f71b9399bd0c: Already exists
e933e7e0c508: Already exists
017a64d4a562: Already exists
7507c5a91d58: Already exists
275cabea4fa3: Already exists
cc9a6af94887: Already exists
9c93353b9182: Already exists
5ffadc28ac33: Already exists
9061467774c7: Already exists
c19d7ce880de: Already exists
4b0a0ccbd8e8: Already exists
afca5f79c8b5: Already exists
aea5ab45c2b6: Already exists
66daa3b211b1: Already exists
b688ed704bec: Already exists
da0711d06005: Already exists
8c21c9190299: Already exists
f21d914b0fbe: Already exists
ae6155fa0c42: Already exists
8ba21cba318e: Already exists
18c22aa3d8bc: Already exists
e6c955f5f8bc: Already exists
2dcf0fd17c81: Pull complete
5e39f9162ac9: Pull complete
4883b2140c83: Pull complete
09149295e8cc: Pull complete
f4488e1a2d3d: Pull complete
Digest: sha256:756ecb628ad3fb629480fd5781f3f0b08126581d2daa2e6ae1472579dc7915e7
Status: Downloaded newer image for jlesage/jdownloader-2:latest
[init        ] container is starting...
[cont-env    ] loading container environment variables...
[cont-env    ] APP_NAME: loading...
[cont-env    ] DISPLAY: executing...
[cont-env    ] DISPLAY: terminated successfully.
[cont-env    ] DISPLAY: loading...
[cont-env    ] DOCKER_IMAGE_PLATFORM: loading...
[cont-env    ] DOCKER_IMAGE_VERSION: loading...
[cont-env    ] GTK2_RC_FILES: executing...
[cont-env    ] GTK2_RC_FILES: terminated successfully.
[cont-env    ] GTK2_RC_FILES: loading...
[cont-env    ] GTK_THEME: executing...
[cont-env    ] GTK_THEME: terminated successfully.
[cont-env    ] GTK_THEME: loading...
[cont-env    ] HOME: loading...
[cont-env    ] INSTALL_PACKAGES_INTERNAL: executing...
[cont-env    ] INSTALL_PACKAGES_INTERNAL: terminated successfully.
[cont-env    ] INSTALL_PACKAGES_INTERNAL: loading...
[cont-env    ] QT_STYLE_OVERRIDE: executing...
[cont-env    ] QT_STYLE_OVERRIDE: terminated successfully.
[cont-env    ] QT_STYLE_OVERRIDE: loading...
[cont-env    ] TAKE_CONFIG_OWNERSHIP: loading...
[cont-env    ] XDG_CACHE_HOME: loading...
[cont-env    ] XDG_CONFIG_HOME: loading...
[cont-env    ] XDG_DATA_HOME: loading...
[cont-env    ] XDG_RUNTIME_DIR: loading...
[cont-env    ] XDG_STATE_HOME: loading...
[cont-env    ] container environment variables initialized.
[cont-secrets] loading container secrets...
[cont-secrets] container secrets loaded.
[cont-init   ] executing container initialization scripts...
[cont-init   ] 10-certs.sh: executing...
[cont-init   ] 10-certs.sh: terminated successfully.
[cont-init   ] 10-check-app-niceness.sh: executing...
[cont-init   ] 10-check-app-niceness.sh: terminated successfully.
[cont-init   ] 10-cjk-font.sh: executing...
[cont-init   ] 10-cjk-font.sh: terminated successfully.
[cont-init   ] 10-clean-logmonitor-states.sh: executing...
[cont-init   ] 10-clean-logmonitor-states.sh: terminated successfully.
[cont-init   ] 10-clean-tmp-dir.sh: executing...
[cont-init   ] 10-clean-tmp-dir.sh: terminated successfully.
[cont-init   ] 10-fontconfig-cache-dir.sh: executing...
[cont-init   ] 10-fontconfig-cache-dir.sh: terminated successfully.
[cont-init   ] 10-init-users.sh: executing...
[cont-init   ] 10-init-users.sh: terminated successfully.
[cont-init   ] 10-nginx.sh: executing...
[cont-init   ] 10-nginx.sh: terminated successfully.
[cont-init   ] 10-openbox.sh: executing...
[cont-init   ] 10-openbox.sh: terminated successfully.
[cont-init   ] 10-set-tmp-dir-perms.sh: executing...
[cont-init   ] 10-set-tmp-dir-perms.sh: terminated successfully.
[cont-init   ] 10-vnc-password.sh: executing...
[cont-init   ] 10-vnc-password.sh: terminated successfully.
[cont-init   ] 10-web-data.sh: executing...
[cont-init   ] 10-web-data.sh: terminated successfully.
[cont-init   ] 10-x11-unix.sh: executing...
[cont-init   ] 10-x11-unix.sh: terminated successfully.
[cont-init   ] 10-xdg-runtime-dir.sh: executing...
[cont-init   ] 10-xdg-runtime-dir.sh: terminated successfully.
[cont-init   ] 15-install-pkgs.sh: executing...
[cont-init   ] 15-install-pkgs.sh: terminated successfully.
[cont-init   ] 55-jdownloader2.sh: executing...
[cont-init   ] 55-jdownloader2.sh: terminated successfully.
[cont-init   ] 85-take-config-ownership.sh: executing...
[cont-init   ] 85-take-config-ownership.sh: terminated successfully.
[cont-init   ] 89-info.sh: executing...
    ╭――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――╮
    │                                                                      │
    │ Application:           JDownloader 2                                 │
    │ Application Version:   n/a                                           │
    │ Docker Image Version:  23.03.1                                       │
    │ Docker Image Platform: linux/amd64                                   │
    │                                                                      │
    ╰――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――╯
[cont-init   ] 89-info.sh: terminated successfully.
[cont-init   ] all container initialization scripts executed.
[init        ] giving control to process supervisor.
[supervisor  ] loading services...
[supervisor  ] loading service 'default'...
[supervisor  ] loading service 'app'...
[supervisor  ] loading service 'gui'...
[supervisor  ] loading service 'xvnc'...
[supervisor  ] loading service 'openbox'...
[supervisor  ] loading service 'nginx'...
[supervisor  ] loading service 'certsmonitor'...
[supervisor  ] service 'certsmonitor' is disabled.
[supervisor  ] loading service 'logmonitor'...
[supervisor  ] service 'logmonitor' is disabled.
[supervisor  ] loading service 'logrotate'...
[supervisor  ] all services loaded.
[supervisor  ] starting services...
[supervisor  ] starting service 'xvnc'...
[xvnc        ] Xvnc TigerVNC 1.13.0 - built Mar  4 2023 01:15:35
[xvnc        ] Copyright (C) 1999-2022 TigerVNC Team and many others (see README.rst)
[xvnc        ] See https://www.tigervnc.org for information on TigerVNC.
[xvnc        ] Underlying X server release 12013000
[xvnc        ] Tue Apr 25 19:00:42 2023
[xvnc        ]  vncext:      VNC extension running!
[xvnc        ]  vncext:      Listening for VNC connections on /tmp/vnc.sock (mode 0660)
[xvnc        ]  vncext:      Listening for VNC connections on all interface(s), port 5900
[xvnc        ]  vncext:      created VNC server for screen 0
[supervisor  ] starting service 'openbox'...
[supervisor  ] starting service 'nginx'...
[nginx       ] Listening for HTTP connections on port 5800.
[supervisor  ] starting service 'app'...
[supervisor  ] all services started.

If removing the image doesn't fix the problem, you might have other images that use the same baseimage.  All images that depends on it should also be removed.

Did you try to remove all containers and images that depend on the same baseimage (see my previous comment)?

Did you try to remove all containers and images that depend on the same baseimage (see my previous comment)?

Yes, I've made sure there are no dangling images, still have the previous jdownloader2 installed which may be why you're not seeing the untagging part. Previously I have removed all containers and started from scratch with the same results
what directory is this part of the log trying to create?

10-xdg-runtime-dir.sh: mkdir: can't create directory '': No such file or directory

what directory is this part of the log trying to create?

The directory is defined by the XDG_RUNTIME_DIR internal environment variable.  The variable is not defined because of previous errors.

Previously I have removed all containers and started from scratch with the same results

During the Docker image pull, you should not see messages like these ones, indicating that layers already exist:
84e5e0a543c2: Already exists
ca8059c6dc96: Already exists
f71b9399bd0c: Already exists
e933e7e0c508: Already exists
017a64d4a562: Already exists

It's related to Synology update Version 7.1.1-42962 Update 5. My NAS installed it on April 18. Same day since JDownloader is broken.

I'm not sure if you still have an issue. I'm also on a Synology NAS with the same version, I had a different log behaviour but I think that the workaround I found might work for you.
It seems that JDOWNLOADER user APP (1000,1000) needs the config folder to have the umask 022 (755) (it's even on the environment. However the files on the volume have been create with umask 000 (777)
Let me know if this works for you or if you need further assistance, I can provide all the steps from the creation if you need it.
Cheers.


Cirrus segfault on Ubuntu when compiled statically

Consistent with old bug reported in multiple places, including here: https://sourceware.org/bugzilla/show_bug.cgi?id=10652

The best way is probably to do normal (i.e., non-static) compilation on Ubuntu machines.

Closing since we don't need static compilation on Ubuntu.


blas issue compile issue

hi all,
I am encountering the blas compile issue on EI Capitan. I searched and found similar questions about it, saying reason might be bias not installed. So I installed openblas thru brew, changed config file as "USE_BLAS = openblas". No luck. And I also tried to export LIBRARY_PATH=/usr/local/Cellar/openblas/0.2.15/include/, still got the exactly same error as below.
Anyone shed some light?
In file included from include/mxnet/base.h:13:
In file included from ./mshadow/mshadow/tensor.h:16:
./mshadow/mshadow/./base.h:120:14: fatal error: 'cblas.h' file not found
#include <cblas.h>
^
In file included from src/c_api/c_predict_api.cc:9:
In file included from include/mxnet/symbolic.h:17:
In file included from include/mxnet/./base.h:13:
In file included from ./mshadow/mshadow/tensor.h:16:
./mshadow/mshadow/./base.h:120:14: fatal error: 'cblas.h' file not found
#include <cblas.h>
^
In file included from src/c_api/c_api.cc:11:
In file included from include/mxnet/base.h:13:
In file included from ./mshadow/mshadow/tensor.h:16:
./mshadow/mshadow/./base.h:120:14: fatal error: 'cblas.h' file not found
#include <cblas.h>
^
In file included from src/common/tblob_op_registry.cc:6:
In file included from include/mxnet/ndarray.h:17:
In file included from include/mxnet/./base.h:13:
In file included from ./mshadow/mshadow/tensor.h:16:
./mshadow/mshadow/./base.h:120:14: fatal error: 'cblas.h' file not found
#include <cblas.h>
^
1 error generated.
1 error generated.
1 error generated.
1 errormake: *** [build/common/tblob_op_registry.o] Error 1 generated.
make: *** Waiting for unfinished jobs....
make: *** [build/c_api/c_predict_api.o] Error 1
make: *** [build/resource.o] Error 1
make: *** [build/c_api/c_api.o] Error 1

An easier option is just to use the built-in BLAS of OS X:
USE_BLAS = apple

as in make/osx.mk

actually, I used "USE_BLAS = apple" at the very beginning, but encounter the same build failure. Then I thought my bias was not installed correctly, then I tried open blas....

You want to add the path to CPLUS_INCLUDE_PATH and C_INCLUDE_PATH. Or add them in -I flag in the ADD_CFLAGS

Add modify the config.mk like this
ADD_LDFLAGS = -I/usr/local/opt/openblas/lib
ADD_CFLAGS =  -I/usr/local/opt/openblas/include

I had the exact similar issue before and my solution was: adding /usr/local/include and /usr/local/lib to the PATH, and USE_BLAS = apple

thanks, the issue was resolved by adding ADD_LDFLAGS and ADD_CFLAGS

Had same issue, fixed it with same flags, but compilation stopped here:
/usr/bin/ld: cannot find -lopenblas
collect2: error: ld returned 1 exit status
Makefile:122: recipe for target 'lib/libmxnet.so' failed
make: *** [lib/libmxnet.so] Error 1
make: *** Waiting for unfinished jobs....
/usr/bin/ld: cannot find -lopenblas
collect2: error: ld returned 1 exit status
Makefile:136: recipe for target 'bin/im2rec' failed
make: *** [bin/im2rec] Error 1
/usr/bin/ld: cannot find -lopenblas
collect2: error: ld returned 1 exit status
Makefile:122: recipe for target 'lib/libmxnet.so' failed
make: *** [lib/libmxnet.so] Error 1
make: *** Waiting for unfinished jobs....
/usr/bin/ld: cannot find -lopenblas
collect2: error: ld returned 1 exit status
Makefile:136: recipe for target 'bin/im2rec' failed
make: *** [bin/im2rec] Error 1

As a reference, if those 2 lines are added to make/osx.mk, then the bash command in the docs remain the same:
cd mxnet; cp make/osx.mk ./config.mk; make -j$(sysctl -n hw.ncpu)

For ADD_LDFLAGS, it should be -L

First install openblas
$ brew install --fresh -vd openblas
......
macOS already provides this software and installing another version in
parallel can cause all kinds of trouble.

Generally there are no consequences of this for you. If you build your
own software and it requires this formula, you'll need to add to your
build variables:

    LDFLAGS:  -L/usr/local/opt/openblas/lib
    CPPFLAGS: -I/usr/local/opt/openblas/include

==> Summary
🍺  /usr/local/Cellar/openblas/0.2.18_2: 20 files, 41.8M, built in 12 minutes 33 seconds

Then Add ADD_LDFLAGS and ADD_CFLAGS  to config.mk:
USE_BLAS = apple
ADD_LDFLAGS = -I/usr/local/opt/openblas/lib
ADD_CFLAGS =  -I/usr/local/opt/openblas/include

I also meet this error:
/data/apps/mxnet/mshadow/mshadow/./base.h:136:23: fatal error: cblas.h: No such file or directory #include <cblas.h>
my environment:
centos 7
gcc  4.8.5
glibc 2.17
opencv 2.4.13
openblas 0.2.19
set config.mk
ADD_LDFLAGS = -L/opt/OpenBLAS -L/opt/OpenBLAS/lib
ADD_CFLAGS = -L/opt/OpenBLAS -L/opt/OpenBLAS/lib
USE_BLAS = openblas
Thanks very much!

First install openblas
$ brew install --fresh -vd openblas
......
macOS already provides this software and installing another version in
parallel can cause all kinds of trouble.

Generally there are no consequences of this for you. If you build your
own software and it requires this formula, you'll need to add to your
build variables:

    LDFLAGS:  -L/usr/local/opt/openblas/lib
    CPPFLAGS: -I/usr/local/opt/openblas/include

==> Summary
🍺  /usr/local/Cellar/openblas/0.2.18_2: 20 files, 41.8M, built in 12 minutes 33 seconds

Then Add ADD_LDFLAGS and ADD_CFLAGS to config.mk:
USE_BLAS = apple
ADD_LDFLAGS = -I/usr/local/opt/openblas/lib
ADD_CFLAGS =  -I/usr/local/opt/openblas/include

OS used : MacOS
I am sorry ,
But where is this config.mk or osx.mk file?

OS used : MacOS
I am sorry ,
But where is this config.mk or osx.mk file?

cp make/osx.mk ./config.mk
then, find “USE_BLAS = apple” line
add


docs: get_string>aa_string

It looks like this is the CPP name but not the Python name - sorry if I'm wrong

BTW really loving BTE - so fast!

get_string is a C++ function declared in the .pxd, being a class function of the Mutation struct, which represents each nucleotide mutation on the tree in memory. You can't access it from Python directly.
aa_string() is a Python class function of the AAChange class. If you wanted to get a string version of mutations on a node in BTE, you just use the .mutations property and it converts nucleotide mutations to a string (A243G etc) for exposure to Python. aa_string() only applies if you've created AAChange class objects by running .translate().
Therefore, this documentation is correct as it stands.
However, I do want to say I've appreciated your positive feedback and raising of issues today! I can't take much credit for the speed- BTE just wraps the highly optimized functions Yatish Turakhia and the rest of the UShER development group wrote for UShER and matUtils. My goal was to make that fantastic library available in Python, both for my own and for other researcher's purposes. I'm glad you're finding it useful! Please, continue to post feedback or contribute to the development of this little package as it suits you.

Thanks -- sorry I know you know much more about this than me but the docs currently read:

A string representation of an amino acid change, such as "S:N501Y", can be generated with AAChange.get_string().

which seems in contradiction to your post above:

get_string is a C++ function [..] you can't access it from Python directly.

aa_string() is a Python class function of the AAChange class

but probably I'm missing something and anyway it doesn't matter at all, it just tripped me up for a few secs :)

Oh wow, yeah I got turned around on which was which here. Sorry, it's been a long day. What I said above is correct- but the current documentation does in fact read get_string(). My bad! It does describe the actual aa_string() in the actual class description directly below it, fortunately.


[ci][R-package] run R CRAN checks on Solaris by optional workflow

Refer to #3740.
How it looks like: https://github.com/StrikerRUS/LightGBM/pull/5#issuecomment-773700926.

Looks fine, please @ me whenever CI is passing and you'd like another review

@jameslamb I hope I addressed all your comments from previous review in 5e034a0d1f9473dd9cc2277596753e55de30a844 or gave my comment in the corresponding thread above.


Exposed and more customisable golang generator

What do you want to change?
Recently I had to write a plugin for slight alterations of the default behavior of the golang generator for postgres.
To build the plugin, I needed to

copy over some of the source files from the internals of sqlc and adapt the imports

      internal
      ├── codegen
      │   ├── golang
      │   │   ├── driver.go
      │   │   ├── enum.go
      │   │   ├── field.go
      │   │   ├── gen.go
      │   │   ├── go_type.go
      │   │   ├── imports.go
      │   │   ├── mysql_type.go
      │   │   ├── postgresql_type.go
      │   │   ├── query.go
      │   │   ├── result.go
      │   │   ├── sqlite_type.go
      │   │   ├── struct.go
      │   │   ├── template.go
      │   │   └── templates
      │   │       ├── pgx
      │   │       │   ├── batchCode.tmpl
      │   │       │   ├── copyfromCopy.tmpl
      │   │       │   ├── dbCode.tmpl
      │   │       │   ├── interfaceCode.tmpl
      │   │       │   └── queryCode.tmpl
      │   │       ├── stdlib
      │   │       │   ├── dbCode.tmpl
      │   │       │   ├── interfaceCode.tmpl
      │   │       │   └── queryCode.tmpl
      │   │       └── template.tmpl
      │   └── sdk
      │       ├── sdk.go
      │       ├── utils.go
      │       └── utils_test.go
      ├── debug
      │   └── dump.go
      ├── inflection
      │   └── singular.go
      ├── metadata
      │   └── meta.go
      ├── opts
      │   ├── debug.go
      │   └── parser.go
      └── pattern
          └── match.go

modify the internal/codegen/golang/templates/pgx/queryCode.tmpl to suit my needs
add some code to insert some extra imports that I needed for the additional template code

In my opinion, although this works, it would be great if the sqlc's generators would be

exported (not under internal/, which renders themt inaccessible) so that one could use them in their plugins
more configurable - receive GeneratorOpts

e.g. func Generate(ctx context.Context, req *plugin.CodeGenRequest) (*plugin.CodeGenResponse, error)
would become func Generate(ctx context.Context, req *plugin.CodeGenRequest, opts ...plugin.GenerateOption) (*plugin.CodeGenResponse, error)
some useful options, at least for me, would be

override one of the templates (queryCode, dbCode, etc.)
pass custom template functions, to be used by one's custom template
pass custom imports

I'd be more than happy to implement this if it was to be selected.
I need it for golang/pg, but I'd be willing to look into the rest of the combinations too.
Thanks!
What database engines need to be changed?
PostgreSQL
What programming language backends need to be changed?
Go

Do you mean something like this? https://github.com/kyleconroy/sqlc/pull/2302

The majority of the code is kept in the internal package so that it's easy for us to change the internals of sqlc without causing backwards incompatible changes. Plugins have been supported for a few versions now. You can learn how to author a plugin and see two of our plugins here:

https://github.com/sqlc-dev/sqlc-gen-kotlin
https://github.com/sqlc-dev/sqlc-gen-python

I'm very hesitant to expose the templates publicly, as they're really difficult to maintain. There was little to no thought into how they're structured. I've talked to @jwc-clinnection about creating a plugin that makes it easy to bring your own templates, and it sounds like that would be helpful for you.

I am eager to get started on it

The majority of the code is kept in the internal package so that it's easy for us to change the internals of sqlc without causing backwards incompatible changes. Plugins have been supported for a few versions now. You can learn how to author a plugin and see two of our plugins here:

https://github.com/sqlc-dev/sqlc-gen-kotlin
https://github.com/sqlc-dev/sqlc-gen-python

I'm very hesitant to expose the templates publicly, as they're really difficult to maintain. There was little to no thought into how they're structured. I've talked to @jwc-clinnection about creating a plugin that makes it easy to bring your own templates, and it sounds like that would be helpful for you.

Makes sense. I checked the plugin section, but  from what I could see the generator has to be written entirely for each plugin. Which in my case means implementing the default sqlc behavior with slight alterations. But I think the plugin you are mentioning would be perfect for my use case, looking forward to it.

Do you mean something like this? #2302

Yes seems to be similar.

I would find this useful as well.
My use-case is putting metric emission for timings into the generated code. This allows me to see db query timings easily on my operations dashboard.
Example:
func (c *Client) GetCatalogEntry(ctx context.Context, componentID string) (CatalogEntry, error) {
	var entry CatalogEntry

	defer instrument.NewMetricTimer("db.get-catalog-entry").Record()
	result := c.db.QueryRowContext(ctx, queryGetCatalogEntry, componentID)

	err := result.Scan(&entry.ProjectID, &entry.Active, &entry.CreatedAt)
	if err != nil {
		return CatalogEntry{}, errors.Wrap(err)
	}

	return entry, nil
}

The defer line starts a timer, then records it when this function completes. A workaround exists: give instrumentation responsibility to the callers, but I've been bitten before by forgetting to instrument every single call. The other workaround is to add a wrapper function for all of the generated functions which handles the metric emission and then calls the generated function, but this is also less than ideal.

I just created a plugin to support custom templates: https://github.com/fdietze/sqlc-gen-from-template


DCJ-645: Add Data Submitter to API roles

Addresses
https://broadworkbench.atlassian.net/browse/DCJ-645
Summary
Updates to studies require access to getting the study's create user id. Currently, a user without admin, chair, or member roles will instead get a 403 response when the page tries to populate the study data, thereby preventing the page from rendering correctly.

Have you read CONTRIBUTING.md lately? If not, do that first.

Label PR with a Jira ticket number and include a link to the ticket
Label PR with a security risk modifier [no, low, medium, high]
PR describes scope of changes
Get a minimum of one thumbs worth of review, preferably two if enough team members are available
Get PO sign-off for all non-trivial UI or workflow changes
Verify all tests go green
Test this change deployed correctly and works on dev environment after deployment

Looks good -- is there any precedent for unit testing to verify allowed roles for Consent endpoints?

Unfortunately, no, we don't. To do so would be a different approach to testing that we haven't explored. We would need to spin up a version of the app with this specific resource class and then try to hit it with different user role combinations. I'm sure we could do that - it's just hasn't been a priority for us.


Space dashboard (Analyze), width of Codebases too narrow, vertical too short

From @burrsutter on June 6, 2017 15:2
https://screencast.com/t/eLrhN87RCJ
My codebase list is too narrow and too short, it should also be sorted by last accessed date descending (most recent up top).
The current UI widget is essentially useless
Copied from original issue: openshiftio/openshift.io#197

@catrobson @mindreeper2420 can you look at the design for this?


Add selectors to ServiceMonitor, PodMonitor and Probe objects

Add label selector for PodMonitor, ServiceMonitor and Probe objects to limit the scraping to only certain targets.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Adding folder to workspace closes Interactive window and data viewer

Issue Type: Bug
Adding a folder to the explorer window should not have this behaviour. If unavoidable, a warning should be given before executing.
VS Code version: Code 1.53.2 (622cb03f7e070a9670c94bae1a45d78d7181fbd4, 2021-02-11T11:48:04.245Z)
OS version: Windows_NT x64 10.0.19041
Remote OS version: Linux x64 4.15.0-76-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz (8 x 1992)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: enabledrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.87GB (5.01GB free)

Process Argv
--crash-reporter-id f792cfdc-235a-4add-9b1f-33640b4a8ae6

Screen Reader
no

VM
0%

Item
Value

Remote
SSH: osgiliath

OS
Linux x64 4.15.0-76-generic

CPUs
Intel Core Processor (Haswell, no TSX) (12 x 2294)

Memory (System)
47.16GB (15.12GB free)

VM
0%

Extensions (19)

Extension
Author (truncated)
Version

remote-containers
ms-
0.158.0

remote-ssh
ms-
0.64.0

remote-ssh-edit
ms-
0.64.0

remote-wsl
ms-
0.53.4

vscode-remote-extensionpack
ms-
0.20.0

file-properties-viewer
bru
0.5.0

path-intellisense
chr
2.3.0

r
Iku
1.6.4

vscode-edit-csv
jan
0.5.4

kite
kit
0.138.0

rainbow-csv
mec
1.8.1

python
ms-
2021.1.502429796

vscode-pylance
ms-
2021.2.2

jupyter
ms-
2020.12.414227025

vscode-data-preview
Ran
2.2.0

rewrap
stk
1.13.0

code-spell-checker
str
1.10.2

pdf
tom
1.1.0

markdown-all-in-one
yzh
3.4.0

(10 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstry244:30256636
pythonvsdeb440:30248342
pythonvsded773:30248341
pythonvspyt875:30251590

Please file to the extesnion that adds the interactive window and data viewer
VS Code is not closing this views when new folder is added to the explorer window

Thanks for this? If you've managed to isolate the problem as stemming from an extension, wouldn't it make sense for you to write your message above as an issue to that extension rather than reply to me on this thread telling me to do it? I can already read to the bot's message. I'm not even sure which extension you are referring to: Jupyter? Python?


checkInternet() is broken in some countries.

Issue Label:

[x] Bug
[ ] New feature
[ ] Enhancement
[ ] New component

Description:
Bash-Snippets use httpGet google.com in checkInternet().
People have been unable to access certain Google products and services at some point in more than 30 countries.
See more: https://www.google.com/transparencyreport/traffic/#expand=CG

Will use a webservice that works worldwide, possibly thinking github itself?

Seems like github was banned but is has been removed from the great red firewall. Will make this switch for the next release.

Should be fixed in a5fdff610c2e1bcd067ab498bf83e8635da67745

Fixed in v1.17.3


feat: unexpander for abs notation

Pretty prints abs a as |a|. It adds discretionary parentheses in known unparseable cases, like |(|x|)| rather than ||x||. It also uses discretionary parentheses in|(-x)| since currently |-x| does not parse.

Aren't we going to revert this soon once |-a| is parseable? (At least, I expect that will be soon)

@fpvandoorn No, it won't be reverted. Once |-a| is parseable, then we can just delete | `(-$_).

bors merge


Multiple headers with same name

Is setting multiple headers with same name not allowed when using the legacy server?
Currently, when we set multiple headers with same name, an exception is raised.
Is there a way to overcome this?

Can you provide the full stack trace please?

Traceback (most recent call last):
  File "D:\ProgramData\Anaconda3\envs\uvicorn\lib\site-packages\websockets\legacy\server.py", line 165, in handler
    await self.handshake(
  File "D:\ProgramData\Anaconda3\envs\uvicorn\lib\site-packages\websockets\legacy\server.py", line 643, in handshake
    response_headers.setdefault("Server", self.server_header)
  File "D:\ProgramData\Anaconda3\envs\uvicorn\lib\_collections_abc.py", line 1007, in setdefault
    return self[key]
  File "D:\ProgramData\Anaconda3\envs\uvicorn\lib\site-packages\websockets\datastructures.py", line 119, in __getitem__
    raise MultipleValuesError(key)

It looks like Headers.setdefault doesn't work when a key already has multiples values. That would be a bug.
(Out of curiosity, what is the use case for setting multiple Server headers? I've never seen that.)

Thanks for the reply.

It looks like Headers.setdefault doesn't work when a key already has multiples values. That would be a bug.

Oh, if that's the case, can we fix this with a PR? I can try to help.

(Out of curiosity, what is the use case for setting multiple Server headers? I've never seen that.)

Well, this emerged while working on a PR in Uvicorn. Uvicorn allows users to specify their own headers. This is to cover a scenario where they might add Server header.
I personally don't think of, or have seen, any real any benefit in setting multiple Server header.

As mentioned in the merge request, the current behavior of Headers.setdefault is correct. We cannot change it because it returns the current value when present and we don't want to do this when there are multiple values.
Given that there's no use case for multiple Server or User-Agent headers, I don't see any reason for spending more time on this.


#1: Added Immutable support

This resolves my question from #1.

Current coverage is 84.05% (diff: 20.00%)

Merging #2 into master will increase coverage by 0.07%

@@             master         #2   diff @@
==========================================
  Files             5          5
  Lines           206        207     +1
  Methods          37         37
  Messages          0          0
  Branches         42         44     +2
==========================================
+ Hits            173        174     +1
  Misses           33         33
  Partials          0          0

Powered by Codecov. Last update 87555df...d2a2485

Woah, thanks for the PR @RamonGebben ! I think what I'd prefer to do is solve this issue more generically, probably with customEncode/customDecode hooks when submitting a bug and playing the bug back, and adding documentation for Immutable specifically and a more generic case. This would also mean this package wouldn't depend on a specific immutable implementation in case another library gains popularity as well.
If I'm understanding your PR correctly the bug would still file incorrectly, because the redux store state would still be an immutable object instead of JSON. I'll try to get a PR up in the next few days with the approach described above and tag you in it to see if it suits your needs. Thanks for the contribution!

@RamonGebben Not quite ready to merge (still need to add documentation, unit tests and a little cleanup), but this is what I was thinking https://github.com/dtschust/redux-bug-reporter/commit/1927bc4bbf883de85a6859bd81d18d03635332ce#diff-0e1416c3630b13806b2a322907ec4f3e . All you would need to do for immutable is add a customDecode function similar to this:
const customDecode = (state) => {
  return { input: fromJS(state.input) }
}

@dtschust Indeed that would suffice and an elegant solution. When would this be ready to merge?

I'll try and get it done this weekend, if you want to play with it beforehand feel free to point to that branch directly in your package.json, i'd love any feedback!

Just merged a fix, will publish to npm later today!

Hey guys, I had the same issue, using immutable stores.
My solution was to have a local copy of redux-bug-reporter.js and added a new prop "storeWork", which I would pass when initialising the .
Now, inside the bugReporterPlayback method, I use that callback in order to "set my store straight", like so:
    if(this.props.storeWork) {
      initialState = this.props.storeWork(initialState)
      finalState = this.props.storeWork(finalState)
    }

and parse those inside the actual storeWork method.
Otherwise, I wouldn't be able to use the data received from the bug reporter in my app.
This way, you can use any kind of store alteration you want, not only immutatability.

sorry, just seen that that's what customDecode does as well... switched to using that and passing my storeWork method to it
const storeWork = store => {
  if(!Immutable.Iterable.isIterable(store.myStore))
    store.myStore = Immutable.Map(store.myStore)

  return store
}

Glad to hear that customDecode worked for your needs @kriskate , thanks for sharing!


feat(CategoryTheory/Enriched): Add eHomCongr and related lemmas

Recall that when C is both a category and a V-enriched category, we say it is an EnrichedOrdinaryCategory if it comes equipped with an equivalence between morphisms X ⟶ Y in C  and morphisms 𝟙_ V ⟶ (X ⟶[V] Y) in V that preserves identities and composition in C.
In such a V-enriched ordinary category C, isomorphisms in C induce isomorphisms between hom-objects in V. We define this isomorphism, CategoryTheory.Iso.eHomCongr, and prove that it behaves nicely with respect to composition in C.
The lemmas here parallel those for unenriched categories in Mathlib/CategoryTheory/HomCongr.lean and those for sorts in Mathlib/Logic/Equiv/Defs.lean (cf. Equiv.arrowCongr). Note, however, that they construct equivalences between Types and Sorts, respectively, while in this PR we construct isomorphisms between objects in V.

Thanks!
bors merge