5.1.x fix principal dn

Using a fixed name for principal's DN attribute name (principalDnAttributeName) solves the following issues:

if user's id (i.e<EMAIL_ADDRESS>contains illegal (for xml naming) characters, the following exception occurs when validating ST tickets (CAS3.0 protocol):
org.xml.sax.SAXParseException: Element type "cas:LdapAuthenticationHandler.user" must be followed by either attribute specifications, ">" or "/>".

principal's DN attribute can be referenced, easier, in attribute filtering
policies.

Thanks for the pull request, but this is not the way you should handle this. This functionality is covered in master, with the help of a boolean property. I recommend you review what is done in master and backport as needed.

The collectDnAttribute that exists in master is supplementary to this PR. If collectDnAttribute is true and a "username" is of the form of<EMAIL_ADDRESS>then the problem is still there<EMAIL_ADDRESS>is an illegal (xml terms) name, so ST validation will still fail, with the above SAX parse exception.

The problem should be fixed given attributes with special characters are encoded. Or should be. See the attribute encoder for details.

Ok, I shall test with the master branch to see if this is fixed and backport it to 5.1.x.
If there is no principalAttributeId definition, then the "id/username" is what the user entered in login form, correct? I don't think that at this point "id/username" is properly encoded...
Moreover, what is the reason that this "attribute" does not have a fixed/well defined name? How could someone, let's say through the cas-management application, release only specific attributes and this one or everything but this attribute to a service?

It's not meant to be released. It's used for extensions.

Thinking a bit more about this, I realized that I was very wrong here. You are totally in the right that we should "fix" the attribute name. The strategies that I had used in the past were done in poor health and I am not sure why I never thought of just designating a fixed attribute name for the Dn. We should definitely do that.

Glad to hear that we are on the same page :-)
I have to say that after your comment, that this attribute is for internal use (in general) and not meant to be released, perhaps all these changes are unnecessary. Using a "fixed" name when adding in the attributeMap, may be enough...
Any thoughts?

Excellent. Sorry to lead you down a wrong path.
I'd say you are right; but the following changes are possibly in order:

fixate the attribute name to a predefined value. Do this for both 5.1 and master. No need for an option there.
add a Boolean allowing the capture of dn as a fixed attribute. Just like master, this would be done for 5.1
finally, the attribute 'can' be released if they policy says release all in which case we still need to make sure it's encoded correctly in the format is xml. I think master is fine but 5.1 might need the change. As you note this only applied to xml and the json format should handle this fine.

No worries :-)
So, just to summarize and to be sure that we are on the same path:

If you agree, the predefined value of this attribute will be set to "principalLdapDN" (There is no such attribute in any well known ldap schema, so there will be no conflicts...).
To be more ... bulletproof, the option for changing this value should remain in case of a conflict with a custom schema that contains this attribute... If not, most of the changes in the original PR will be removed (no option for setting/changing the name of the attribute) and "principalLdapDN" will be added in the attributeMap in LdapAuthenticationHandler.java. (Also for master).
Encoding won't be an issue anymore, as "principalLdapDN" does not contain any forbidden character (for xml name element).
All collectDnAttribute related changes will be backported from master. Should this be done in this PR or in a new one?

Thanks

Oh, I forgot to ask, is this attribute referenced/used anywhere else in the code? If yes, please show me where, in order to do the update for the new name.
Thanks again

If you agree, the predefined value of this attribute will be set to "principalLdapDN" (There is no such attribute in any well known ldap schema, so there will be no conflicts...).

principalLdapDn, but yes.

To be more ... bulletproof, the option for changing this value should remain in case of a conflict with a custom schema that contains this attribute... If not, most of the changes in the original PR will be removed (no option for setting/changing the name of the attribute) and "principalLdapDN" will be added in the attributeMap in LdapAuthenticationHandler.java. (Also for master).

Sure.

Encoding won't be an issue anymore, as "principalLdapDN" does not contain any forbidden character (for xml name element).

Excellent.

All collectDnAttribute related changes will be backported from master. Should this be done in this PR or in a new one?

Same is fine. Choose whatever is easiest for you.
And the attribute is not referenced anywhere else. It's only made available should extensions at the time of custom deployments need it.
Thanks again.

Ok so,

principalLdapDn will be the default attributeName
The option to change it will remain.
Not an issue anymore with the default configuration. In any case, IMHO, encoding issues (if any) should be addressed in Cas30ResponseView as for any other attribute...
To be more self-contained, all collectDnAttribute related changes will be backported from master in a new PR, after this one is merged.

Yes all good.
I am not particularly excited about #2, because I simply can't think of a reason to why anyone would want to change that name but if you want to add an option, that's perfectly fine.

Just to be sure that if there is some conflict with a custom schema, which includes principalLdapDn attribute, there is an option to change this attribute's name...

OK. Sounds good.

Excellent. Let's do the same for master and then we can surely merge. Thanks again.


Remove manual creation of routes-controller manifest

this removes the code marked to be removed after crc 2.24 since the bundles now have the routes controller pod yaml file already

/lgtm
/approve


Change (id) to instancetype

https://github.com/MobileAppTracking/segment-integration-ios/blob/master/Segment-Tune/Classes/SEGTuneIntegrationFactory.h#L6
as seen here https://github.com/segment-integrations/analytics-ios-integration-mixpanel/blob/master/Pod/Classes/SEGMixpanelIntegrationFactory.h#L7

Thanks!


Set Up SAP Mobile Cards

Tutorial URL: https://developers.sap.com/tutorials/cp-mobile-cards-setup.html
Please specify the step you are referring to
Step 4: Configure SAP Mobile Cards Client
Actual Result : In android mobile, the attached  screenshot for "SAP cloud platform login Page" is different from actual result i got in device.
Please change the screenshot in the document.

Hi @mounikat987,
Thank you for raising the issue. I will update the screenshot.

Thank you for your feedback. The issue seems to be resolved, so I am closing the issue.
If you still have questions, feel free to reopen the issue.


Convert Jira formatted descriptions on migration

there was an issue about it already that was closed but it still doesn't work as expected for me.
first, it maps the description to both "Repro steps" and "Description".
second, the formatting works only in what was mapped to "Repro steps" even though it has the same value as in "description".

@AmitNaveh23 which version are you using?

@MOlausson  latest version currently : 2.2.59

@AmitNaveh23 we have released a new version that should have fixed this issue you have reported. With the new release, we have introduced a new mapping "MapRendred". If you want the rendered output of description or comment field to be migrated you will need to add a new mapping in your config file like so:
 {         "source": "description",         "target": "System.Description",         "mapper":"MapRendered"  }
I will close this issue, but if you still have problems feel free to reach out.

Works like magic 💯
Thanks! @madkoo


Properly defer resolution of mapped types with generic as clauses

This PR properly defers resolution of mapped types with as clauses that reference other type parameters than the iteration type parameter. The PR furthermore improves normalization of template literal and string mapping types (see baseline changes for examples).
Fixes #50558.

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster
@typescript-bot test top100

FWIW we probably won't see regressions in the perf suite because as clauses are pretty new.

Tests and performance all look good. I think this is ready to merge.


Coral Dev Board Micro USB is not recognized

Description
Hi,
Would like to seek help for an issue with Coral Dev Board Micro. I am using Arduino IDE to flashing Coral Micro, but suddenly after flashing the USB board is not recognized anymore. I tried to solve it by following this https://coral.ai/docs/dev-board-micro/get-started#serial-downloader, but this solution is not working. Basically I perform Serial Downloader mode but the orange led is never turn on.
any Idea to solve this issue?

Thanks
Click to expand!
Issue Type
Build/Install
Operating System
Windows 10
Coral Device
Dev Board Micro
Other Devices
No response
Programming Language
C++
Relevant Log Output
No response

I had similar problem on Win an Linux, I replaced with a thicker and shorter usb cable and is working now

Hi @bogdannedelcu
Thanks for your response, may I know the usb cable brand that you use?. I tried multiple cable but not working

No brand name written. It came with a SanDisk. As you may see it is thicker
than the other one which did not work.
În sâm., 14 oct. 2023 la 12:38 dadanugm @.***> a scris:

Hi @bogdannedelcu https://github.com/bogdannedelcu
Thanks for your response, may I know the usb cable brand that you use?. I
tried multiple cable but not working
—
Reply to this email directly, view it on GitHub
https://github.com/google-coral/coralmicro/issues/73#issuecomment-1762777648,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACAJSJBUYZSLUH55CHK7MPTX7JMRNANCNFSM6AAAAAA5NKYMV4
.
You are receiving this because you were mentioned.Message ID:
@.***>


[MM-38770] Show a copy button when hovering over code blocks

Summary

A copy button is now shown when hovering over a text block. Upon clicking it the code block gets copied into the clipboard and transitions into a checkmark to show copying the text was a success.
Ticket Link

Jira ticket: https://mattermost.atlassian.net/browse/MM-38770
Fixes https://github.com/mattermost/mattermost-server/issues/18851
Related Pull Requests

Has server changes (please link here)
Has mobile changes (please link here)

Screenshots

Release Note

Added copy button when hovering over code blocks

Hello @cleferman,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Hey guys, I created this PR as a draft because some features from the figma mockups are missing:

the tooltip while hovering over the button
the context menu

Now, I'd be more than happy to add those if I can get react to do the heavy lifting.
Please let me know if you have any idea on how to use react for this task. I had to update the html-to-react package to the latest version so onclick handlers are parsed properly. And as you can see I had to do some black voodoo with strings to get functions to work because I didn't want to just add them to the window object.

/update-branch

Error trying to update the PR.
Please do it manually.

@cleferman Can you please resolve the conflicts? Thanks 🙂

Thank you @cleferman
I ran E2Es, see report here when compared to master run, 30 more tests failed on the PR. Can you please take a look? We should fix all the related cypress failures here in this PR. Thanks 🙂
Copy code block icon button fill is present on post hover, but it's missing on mouse hover over the icon ( also on click) see image

@devinbinnie I updated the PR 6 days ago but I forgot to notify you that I've done the changes you asked.
@jgilliam17 I'm not sure where these errors are coming from, they don't seem to be from my changes, but I am really not sure. Maybe it's something from the merge? Could someone assist me? I am unable to run cypress tests locally because I'm developing on windows with wsl and something just doesn't work with cypress it fails at npm install with the error:
flow.exe: unexpected argument 'test'.
also, does the master branch build for you? It also fails at npm install because of an integrity check. I'm unable to fix the conflicts atm.

Thank you @cleferman Can you please fix conflicts and update branch? I'll re-run the E2Es in case failures were cypress related. Thanks 🙂

/update-branch

Error trying to update the PR.
Please do it manually.

/update-branch

@cleferman I've updated your branch to the latest master, but it appears we're still getting a build error:
ERROR in ./sass/styles.scss
Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
ModuleBuildError: Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
SassError: Undefined mixin.
    ╷
182 │         @include opacity(1);
    │         ^^^^^^^^^^^^^^^^^^^
    ╵
  sass/layout/_markdown.scss 182:9  @import
  sass/layout/_module.scss 5:9      @import
  sass/styles.scss 12:9             root stylesheet
    at processResult (/root/mattermost/mattermost-webapp/node_modules/webpack/lib/NormalModule.js:751:19)
    at /root/mattermost/mattermost-webapp/node_modules/webpack/lib/NormalModule.js:853:5
    at /root/mattermost/mattermost-webapp/node_modules/webpack/node_modules/loader-runner/lib/LoaderRunner.js:399:11
    at /root/mattermost/mattermost-webapp/node_modules/webpack/node_modules/loader-runner/lib/LoaderRunner.js:251:18
    at context.callback (/root/mattermost/mattermost-webapp/node_modules/webpack/node_modules/loader-runner/lib/LoaderRunner.js:124:13)
    at /root/mattermost/mattermost-webapp/node_modules/sass-loader/dist/index.js:54:7
    at Function.call$2 (/root/mattermost/mattermost-webapp/node_modules/sass/sass.dart.js:93417:16)
    at _render_closure1.call$2 (/root/mattermost/mattermost-webapp/node_modules/sass/sass.dart.js:81775:12)
    at _RootZone.runBinary$3$3 (/root/mattermost/mattermost-webapp/node_modules/sass/sass.dart.js:27547:18)
    at _FutureListener.handleError$1 (/root/mattermost/mattermost-webapp/node_modules/sass/sass.dart.js:26096:19)
 @ ./root.jsx 8:0-26

@devinbinnie I'm unable to run npm install due to the same EINTEGRITY error
I tried:

removing node_modules
removing package-lock.json (different error when doing this)
npm cache clean --force
npm cache verify
npm install

Everytime (except when removing package-lock also) I get the same error:
4068 timing reify:rollback:createSparse Completed in 22619ms
4069 timing reify:rollback:retireShallow Completed in 0ms
4071 verbose stack Error: sha512-m13+PofIcB7Oy9cVps149ZqTsIRWchKok8A+3bXD0J4lMEyakSKG1YUxqrgtGW1AtOGROzHbQWgoEMLVUelpPA== integrity checksum failed when using sha512: wanted sha512-m13+PofIcB7Oy9cVps149ZqTsIRWchKok8A+3bXD0J4lMEyakSKG1YUxqrgtGW1AtOGROzHbQWgoEMLVUelpPA== but got sha512-Ql0SFw3R5x+UfKv0XbdIuCQXNrQIGaYg2llDDtcjM5Aj0PFo+eJVw9rNv9Use4wB6ddny0XdvzUk9yRURFhHOw==. (23091 bytes)
4071 verbose stack     at IntegrityStream.[_onEnd] (C:\Users\cosmin.leferman\AppData\Roaming\nvm\v16.13.1\node_modules\npm\node_modules\ssri\index.js:94:19)
4071 verbose stack     at IntegrityStream.emit (C:\Users\cosmin.leferman\AppData\Roaming\nvm\v16.13.1\node_modules\npm\node_modules\ssri\index.js:67:35)
4071 verbose stack     at IntegrityStream.[maybeEmitEnd] (C:\Users\cosmin.leferman\AppData\Roaming\nvm\v16.13.1\node_modules\npm\node_modules\minipass\index.js:365:12)
4071 verbose stack     at IntegrityStream.emit (C:\Users\cosmin.leferman\AppData\Roaming\nvm\v16.13.1\node_modules\npm\node_modules\minipass\index.js:429:29)
4071 verbose stack     at IntegrityStream.emit (C:\Users\cosmin.leferman\AppData\Roaming\nvm\v16.13.1\node_modules\npm\node_modules\ssri\index.js:68:18)
4071 verbose stack     at IntegrityStream.[resume] (C:\Users\cosmin.leferman\AppData\Roaming\nvm\v16.13.1\node_modules\npm\node_modules\minipass\index.js:254:10)
4071 verbose stack     at Unpack.ondrain (C:\Users\cosmin.leferman\AppData\Roaming\nvm\v16.13.1\node_modules\npm\node_modules\minipass\index.js:324:67)
4071 verbose stack     at Unpack.emit (node:events:390:28)
4071 verbose stack     at Unpack.[nextEntry] (C:\Users\cosmin.leferman\AppData\Roaming\nvm\v16.13.1\node_modules\npm\node_modules\tar\lib\parse.js:248:16)
4071 verbose stack     at ReadEntry.<anonymous> (C:\Users\cosmin.leferman\AppData\Roaming\nvm\v16.13.1\node_modules\npm\node_modules\tar\lib\parse.js:225:45)
4072 verbose cwd C:\Projects\OpenSource\mattermost-webapp
4073 verbose Windows_NT 10.0.18363
4074 verbose argv "C:\\Users\\cosmin.leferman\\AppData\\Roaming\\nvm\\v16.13.1\\node.exe" "C:\\Users\\cosmin.leferman\\AppData\\Roaming\\nvm\\v16.13.1\\node_modules\\npm\\bin\\npm-cli.js" "install"
4075 verbose node v16.13.1
4076 verbose npm  v8.1.2
4077 error code EINTEGRITY
4078 error sha512-m13+PofIcB7Oy9cVps149ZqTsIRWchKok8A+3bXD0J4lMEyakSKG1YUxqrgtGW1AtOGROzHbQWgoEMLVUelpPA== integrity checksum failed when using sha512: wanted sha512-m13+PofIcB7Oy9cVps149ZqTsIRWchKok8A+3bXD0J4lMEyakSKG1YUxqrgtGW1AtOGROzHbQWgoEMLVUelpPA== but got sha512-Ql0SFw3R5x+UfKv0XbdIuCQXNrQIGaYg2llDDtcjM5Aj0PFo+eJVw9rNv9Use4wB6ddny0XdvzUk9yRURFhHOw==. (23091 bytes)
4079 verbose exit 1

@devinbinnie I'm unable to run npm install due to the same EINTEGRITY error I tried:

removing node_modules
removing package-lock.json (different error when doing this)
npm cache clean --force
npm cache verify
npm install

Everytime (except when removing package-lock also) I get the same error:
4068 timing reify:rollback:createSparse Completed in 22619ms
4069 timing reify:rollback:retireShallow Completed in 0ms
4071 verbose stack Error: sha512-m13+PofIcB7Oy9cVps149ZqTsIRWchKok8A+3bXD0J4lMEyakSKG1YUxqrgtGW1AtOGROzHbQWgoEMLVUelpPA== integrity checksum failed when using sha512: wanted sha512-m13+PofIcB7Oy9cVps149ZqTsIRWchKok8A+3bXD0J4lMEyakSKG1YUxqrgtGW1AtOGROzHbQWgoEMLVUelpPA== but got sha512-Ql0SFw3R5x+UfKv0XbdIuCQXNrQIGaYg2llDDtcjM5Aj0PFo+eJVw9rNv9Use4wB6ddny0XdvzUk9yRURFhHOw==. (23091 bytes)
4071 verbose stack     at IntegrityStream.[_onEnd] (C:\Users\cosmin.leferman\AppData\Roaming\nvm\v16.13.1\node_modules\npm\node_modules\ssri\index.js:94:19)
4071 verbose stack     at IntegrityStream.emit (C:\Users\cosmin.leferman\AppData\Roaming\nvm\v16.13.1\node_modules\npm\node_modules\ssri\index.js:67:35)
4071 verbose stack     at IntegrityStream.[maybeEmitEnd] (C:\Users\cosmin.leferman\AppData\Roaming\nvm\v16.13.1\node_modules\npm\node_modules\minipass\index.js:365:12)
4071 verbose stack     at IntegrityStream.emit (C:\Users\cosmin.leferman\AppData\Roaming\nvm\v16.13.1\node_modules\npm\node_modules\minipass\index.js:429:29)
4071 verbose stack     at IntegrityStream.emit (C:\Users\cosmin.leferman\AppData\Roaming\nvm\v16.13.1\node_modules\npm\node_modules\ssri\index.js:68:18)
4071 verbose stack     at IntegrityStream.[resume] (C:\Users\cosmin.leferman\AppData\Roaming\nvm\v16.13.1\node_modules\npm\node_modules\minipass\index.js:254:10)
4071 verbose stack     at Unpack.ondrain (C:\Users\cosmin.leferman\AppData\Roaming\nvm\v16.13.1\node_modules\npm\node_modules\minipass\index.js:324:67)
4071 verbose stack     at Unpack.emit (node:events:390:28)
4071 verbose stack     at Unpack.[nextEntry] (C:\Users\cosmin.leferman\AppData\Roaming\nvm\v16.13.1\node_modules\npm\node_modules\tar\lib\parse.js:248:16)
4071 verbose stack     at ReadEntry.<anonymous> (C:\Users\cosmin.leferman\AppData\Roaming\nvm\v16.13.1\node_modules\npm\node_modules\tar\lib\parse.js:225:45)
4072 verbose cwd C:\Projects\OpenSource\mattermost-webapp
4073 verbose Windows_NT 10.0.18363
4074 verbose argv "C:\\Users\\cosmin.leferman\\AppData\\Roaming\\nvm\\v16.13.1\\node.exe" "C:\\Users\\cosmin.leferman\\AppData\\Roaming\\nvm\\v16.13.1\\node_modules\\npm\\bin\\npm-cli.js" "install"
4075 verbose node v16.13.1
4076 verbose npm  v8.1.2
4077 error code EINTEGRITY
4078 error sha512-m13+PofIcB7Oy9cVps149ZqTsIRWchKok8A+3bXD0J4lMEyakSKG1YUxqrgtGW1AtOGROzHbQWgoEMLVUelpPA== integrity checksum failed when using sha512: wanted sha512-m13+PofIcB7Oy9cVps149ZqTsIRWchKok8A+3bXD0J4lMEyakSKG1YUxqrgtGW1AtOGROzHbQWgoEMLVUelpPA== but got sha512-Ql0SFw3R5x+UfKv0XbdIuCQXNrQIGaYg2llDDtcjM5Aj0PFo+eJVw9rNv9Use4wB6ddny0XdvzUk9yRURFhHOw==. (23091 bytes)
4079 verbose exit 1

Any chance you have a different machine to try this on? It also might be worth reinstalling Node, looks like your install could be corrupted or something.

@devinbinnie seems to work on a different machine. I'll have a look in the following days at the error. Basically the mixins were removed as part of some other PR and now I have to replace the mixins I was still using with some other CSS.

Which version of npm and node do you have? That error sounds like you might be on a different version than whoever last updated the package-lock.json. These are the ones I have
mattermost-webapp harrison$ npm --version
node7.18.1
mattermost-webapp harrison$ node --version
v16.4.0

As for the mixins, you should be able to just replace them with the standard CSS property names. If that doesn't work, you might be able to look at the PR that removed them for suitable replacements

@hmhealey that was it, installing the right versions did the job, but once again, the plot thickens.
Now the make command is not successful, same thing happening on two different machines I'm afraid.
ERROR in ./images/webhook_icon.jpg
Module build failed (from ./node_modules/image-webpack-loader/index.js):
Error: Command failed with ENOENT: /mnt/c/Projects/OpenSource/mattermost-webapp/mattermost-webapp/node_modules/mozjpeg/vendor/cjpeg
spawn /mnt/c/Projects/OpenSource/mattermost-webapp/mattermost-webapp/node_modules/mozjpeg/vendor/cjpeg ENOENT

    at Process.ChildProcess._handle.onexit (node:internal/child_process:282:19)
    at onErrorNT (node:internal/child_process:480:16)
    at processTicksAndRejections (node:internal/process/task_queues:83:21)
 @ ./utils/constants.jsx 34:0-50 1563:24-35
 @ ./utils/utils.jsx 50:0-91 100:24-55 123:33-57 181:35-55 181:76-96 262:33-57 272:6-34 273:11-25 276:6-35 277:11-26 280:6-35 281:11-26 284:6-35 285:11-26 288:6-41 289:11-32 292:6-34 293:11-25 296:6-34 297:11-25 300:6-42 301:11-33 304:6-33 305:11-24 308:6-35 309:11-26 312:6-33 313:11-24 316:9-24 322:18-42 323:11-35 325:11-41 333:18-47 334:11-40 515:22-50 678:2-34 887:9-46 896:78-113 898:24-46 931:10-44 933:27-56 933:74-103 935:10-41 939:10-45 944:10-50 947:27-55 950:14-44 968:10-49 1103:65-85 1104:65-85 1264:24-72 1264:74-103 1308:23-52 1355:56-85 1357:59-88 1401:13-42 1511:44-69 1711:20-43 1711:61-84 1713:27-50 1735:20-43 1737:27-50
 @ ./root.jsx 20:0-59 39:8-17 47:2-19

webpack 5.64.2 compiled with 53 errors and 5 warnings in 184184 ms (fff1fbff5a753a3ae786)
Watchpack Error (initial scan): Error: EACCES: permission denied, lstat '/mnt/c/hiberfil.sys'
Watchpack Error (initial scan): Error: EACCES: permission denied, lstat '/mnt/c/pagefile.sys'
Watchpack Error (initial scan): Error: EACCES: permission denied, lstat '/mnt/c/swapfile.sys'

running as root user gets rid of the permission denied errors but I get a webpack-cli error:
[webpack-cli] HookWebpackError: Not supported                                                                               at makeWebpackError (/mnt/c/Projects/OpenSource/mattermost-webapp/mattermost-webapp/node_modules/webpack/lib/HookWebpackError.js:48:9)                                                                                at hooks.processAssets.callAsync.err (/mnt/c/Projects/OpenSource/mattermost-webapp/mattermost-webapp/node_modules/webpack/lib/Compilation.js:3055:12)                                                                                at eval (eval at create (/mnt/c/Projects/OpenSource/mattermost-webapp/mattermost-webapp/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:43:1)                                                              at err (/mnt/c/Projects/OpenSource/mattermost-webapp/mattermost-webapp/node_modules/webpack/lib/Compilation.js:508:26)                                                                                at compilation.hooks.processAssets.tapAsync (/mnt/c/Projects/OpenSource/mattermost-webapp/mattermost-webapp/node_modules/copy-webpack-plugin/dist/index.js:485:13)                                                                              at process._tickCallback (internal/process/next_tick.js:68:7)                                                       -- inner error --                                                                                Error: Not supported                                                                                at compilation.hooks.processAssets.tapAsync (/mnt/c/Projects/OpenSource/mattermost-webapp/mattermost-webapp/node_modules/copy-webpack-plugin/dist/index.js:481:13)                                                                              at fn (/mnt/c/Projects/OpenSource/mattermost-webapp/mattermost-webapp/node_modules/webpack/lib/Compilation.js:507:9)    at Hook.eval [as callAsync] (eval at create (/mnt/c/Projects/OpenSource/mattermost-webapp/mattermost-webapp/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:40:1)                                          at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/mnt/c/Projects/OpenSource/mattermost-webapp/mattermost-webapp/node_modules/webpack/node_modules/tapable/lib/Hook.js:18:14)                                                                        at cont (/mnt/c/Projects/OpenSource/mattermost-webapp/mattermost-webapp/node_modules/webpack/lib/Compilation.js:3052:34)                                                                                at createChunkAssets.err (/mnt/c/Projects/OpenSource/mattermost-webapp/mattermost-webapp/node_modules/webpack/lib/Compilation.js:3100:10)                                                                                at symbolIterator (/mnt/c/Projects/OpenSource/mattermost-webapp/mattermost-webapp/node_modules/neo-async/async.js:3485:9)                                                                                at done (/mnt/c/Projects/OpenSource/mattermost-webapp/mattermost-webapp/node_modules/neo-async/async.js:3527:9)         at /mnt/c/Projects/OpenSource/mattermost-webapp/mattermost-webapp/node_modules/neo-async/async.js:2830:7                at done (/mnt/c/Projects/OpenSource/mattermost-webapp/mattermost-webapp/node_modules/neo-async/async.js:2865:11)    caused by plugins in Compilation.hooks.processAssets                                                                    Error: Not supported                                                                                at compilation.hooks.processAssets.tapAsync (/mnt/c/Projects/OpenSource/mattermost-webapp/mattermost-webapp/node_modules/copy-webpack-plugin/dist/index.js:481:13)                                                                              at fn (/mnt/c/Projects/OpenSource/mattermost-webapp/mattermost-webapp/node_modules/webpack/lib/Compilation.js:507:9)    at Hook.eval [as callAsync] (eval at create (/mnt/c/Projects/OpenSource/mattermost-webapp/mattermost-webapp/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:40:1)                                          at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/mnt/c/Projects/OpenSource/mattermost-webapp/mattermost-webapp/node_modules/webpack/node_modules/tapable/lib/Hook.js:18:14)                                                                        at cont (/mnt/c/Projects/OpenSource/mattermost-webapp/mattermost-webapp/node_modules/webpack/lib/Compilation.js:3052:34)                                                                                at createChunkAssets.err (/mnt/c/Projects/OpenSource/mattermost-webapp/mattermost-webapp/node_modules/webpack/lib/Compilation.js:3100:10)                                                                                at symbolIterator (/mnt/c/Projects/OpenSource/mattermost-webapp/mattermost-webapp/node_modules/neo-async/async.js:3485:9)                                                                                at done (/mnt/c/Projects/OpenSource/mattermost-webapp/mattermost-webapp/node_modules/neo-async/async.js:3527:9)         at /mnt/c/Projects/OpenSource/mattermost-webapp/mattermost-webapp/node_modules/neo-async/async.js:2830:7                at done (/mnt/c/Projects/OpenSource/mattermost-webapp/mattermost-webapp/node_modules/neo-async/async.js:2865:11)

Sorry it's been taking so long but I'm not sure how to proceed

No worries. NPM can be a real pain sometimes.
For the ENOENT error, that's something we had happening a bit because the package-lock.json wasn't telling NPM to properly set up that dependency after we upgraded versions of NPM a while back. Is your package-lock.json file perhaps modified from what's on master? You haven't checked in any changes to it, but it might have changed when you were trying to get everything working.
For those permission errors, I have no idea where those could be coming from. I'm not sure why webpack would be trying to access system files like that. You shouldn't have to run npm as root at all when working on Mattermost anyway. If you've tried that though, some of the permissions could be messed up on node_modules, so I'd recommend running a make clean to delete that before trying a fresh npm install.

@hmhealey @devinbinnie @jgilliam17 finally got this to work! It's an Xmas miracle :)

Thanks @cleferman
Copy code block icon button fill is present on post hover and now also on mouse hover over the icon - this is fixed 🎉
I am seeing few issues

Not able to add any random text using triple backquote e.g.
``` test ```
but if I specify the type of code e.g.  ``` ts or  ```postgres after the first set of backticks, then it works
This is causing a lot of cypress tests to fail too; the change is preventing webhook posts from displaying, also some integrations, markdowns etc. See full report here

In mobile webview, the copy button knocks the code type label down a bit. If it's one line of code then the label is almost all the way obscured by the next post or the textbox.

Currently (in versions esr+), in mobile webview label is displayed as below.
I am deferring to @matthewbirtch for UX advice here
Personally, I would expect the button in mobile to always be visible, maybe in line with the type (see red outline for placement example) and not on hover, as hover option in mobile is not practical.

@jgilliam17 managed to fix the first two points. Regarding the 3rd one, could you give me some more details on where it appears like that? On mobile (using Edge chromium, tried with Firefox as well) I see what you see in the 2nd and 3rd screenshot.
For me in mobile view the copy button and the language indicator appear when I click/touch the message.

Thank you @cleferman - the last screenshot, mobile view where language indicator forms a header, is what we currently have on the community-daily server ( screenshot taken in Chrome).
Let me know if that answers your question.

The language label in mobile is no longer obscured for me, not reproducing.
Icon fill is missing again.

@matthewbirtch I've managed to edit all of the above (thanks for the color variables!). Three things though:

.post-code__overlay: should it have top: 0px or top: 5px ? I left it with 5px because it's the last statement
because of padding and top positioning it looks like this when there's a oneliner snip:

I think we need to have a background color on the icon when we hover because of this scenario:

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @aspleenic

@cleferman would you mind committing and pushing your updates to this PR? I don't see the changes in the test server yet. Once that's up I can take a closer look at your questions

@matthewbirtch you can check now, I wanted to get everything into a single commit :)

Thanks @cleferman. In order to resolve the one-line code issue, I think we'll need to modify the padding on the following classes. This should make the code block container tall enough to house the buttons and give a little more breathing room to the code blocks:
.post-code code {
    padding: 4px;
}

.post-code .post-code__line-numbers {
    padding: 4px;
}

To solve the background issue, let's add a background to the .post-code__overlay element rather than the copy button itself. And a few other adjustments are needed (noted below). Then we'll have to only show this entire element on hover:
 .post-code__overlay {
    background: var(--center-channel-bg);
    top: 6px;
    right: 1px;
    border-radius: 4px;
    padding: 6px;
}

One other thing I noticed is that the copy and checkmark icons don't look like they are centered within the button container. I think if we adjust the padding on this to the below it should resolve it:
.post-code__overlay>span {
    padding: 4px;
}

Finally, the fade animation on the copy checkmark feels a bit slow, can we cut the animation duration in half on that?
Hopefully the above makes sense - it's just the result of me playing in the inspector, so let me know if this doesn't work in the actual code.

@matthewbirtch I've added the .post-code__overlay part under .post-code's hover. I took out the bottom padding because it was going over the container in the one liner case.
I also shortened the animation to 0.3s.
Can you try now?

Looks better @cleferman. However it looks like the .post-code__clipboard icon button lost its hover state. It should have the following on hover:
.post-code .post-code__clipboard:hover {
    background: rgba(var(--center-channel-color-rgb),.08);
}

.post-code .post-code__clipboard:hover .icon {
    color: rgba(var(--center-channel-color-rgb),.72);
}

The icon within this button still looks like it's sitting 1px too far to the right. Can we move to the left by 1px?

@matthewbirtch I readded that on the last commit, did you check before the test server was recreated?

@matthewbirtch I readded that on the last commit, did you check before the test server was recreated?

That's possible. Looks like the test server failed

I just checked again now though and all looks good. Thank you for all the back and forth!

No worries, glad we sorted it out!

/e2e-test

Triggering e2e testing with options:
<nil>

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/103631

/update-branch

Error trying to update the PR.
Please do it manually.

@cleferman Can you please fix the conflicts. I'd like to re-run the E2Es, last run had an unusually high number of failed tests. Thanks
Report - https://automation-dashboard.vercel.app/cycles/db5bc8aa-32a7-4c0f-ae1b-53d1b1c5a697

@devinbinnie @hmhealey any idea why the build failed? I see nothing in the checks (or don't know where to look). I just merged master (replaced package-lock and package.json from the upstream)

The file Makefile is in the blocklist for external contributors. Hence, these changes are not tested by the CI pipeline active until the build is re-triggered by a core committer or the PR is merged. Please be careful when reviewing it.
/cc @mattermost/core-security @mattermost/core-build-engineers

That error on CI looks like it just might be an intermittent failure. I'd re-run the CI, but it looks like something on your branch got mangled with one of those merges since your PR is now rewriting a bunch of unrelated files which now look seemingly identical. Maybe the line endings got changed somehow? It seems like at least the latest two merge commits did a bunch of rewriting they shouldn't have. Would you be able to fix that?
Worst case scenario though, we could always make a new branch and copy the changes that you actually want onto it

@hmhealey @jgilliam17 I opened up a new PR only with my files. It became a pain to merge. Since I didn't modify the package.json anymore it should be. You can check it out here #9655

Closing this in favour of the new PR


Buttons and ButtonGroups: floated='right' makes buttons to take no veritcal space

Buttons and ButtonGroups are working incorrectly with floated={'right'} prop (screenshot), source code:
<Segment>
	<Button floated={'right'}>
		Sample
	</Button>
</Segment>

You need to use <Divider clearing /> in this case:
  <Segment>
    <Button floated={'right'}>Sample</Button>
    <Divider clearing hidden />
  </Segment>

https://react.semantic-ui.com/elements/divider/#variations-clearing
https://codesandbox.io/s/ybgbx?module=/example.js

Not a code issue, I agree, but I think that it needs to be noticed in docs somewhere arount floating buttons, 'cause my solution was to add not floated hidden button near floated one :) Anyway, thanks for anwer.


rust: 1.39.0 -> 1.40.0

Motivation for this change
Update rustc stable to be 1.40.0.
Things done
firefox and thunderbird still lock on rust 1.38.0, which are not affected.
Not sure whether the version of llvm matches.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)

rustc: 796,307,712 -> 419,829,488 (rlibs of dependent crates in lib/rustlib/{triple}/lib/ now no longer exists)

[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @edolstra

Dups of #76100


[TIR] Add preserve-unit-iters

Follow-up of #11578, which enforces structural stability of TIR by
avoiding over-simplification in affine analysis. On the other hand, it
is possible that over-simplification could be desirable behavior.
Therefore, following the precedent of preserve-unit-loops in
Compute-At, this PR introduces preserve-unit-iters in block binding
for cases where users don't need structural stability (which is
admittedly rare).
This PR does not affect any existing functionalities.
Example:
# The original TIR
for i in T.serial(2):
    with T.block("C"):
        k = T.axis.reduce(2, i)

# Our operation is:
Split(i, [1, 2], preserve-unit-iters=True/False)

# preserve-unit-iters = True
for i_0, i_1 in T.grid(1, 2):
    with T.block("C"):
        k = T.axis.reduce(2, i_0 * 2 + i_1)

# preserve-unit-iters = False
for i_0, i_1 in T.grid(1, 2):
    with T.block("C"):
        k = T.axis.reduce(2, i_1)

Per discussion with @spectrometerHBH. CC: @wrongtest @Hzfengsy @jinhongyii would you guys like to review this PR? Thanks a lot!

Can you add unittests for it? Then we can merge it quickly

Per discussion with @Hzfengsy: we are going to use True as default given it's not gonna to affect existing functionalities. I'm going to update the PR later this week :-)

Script to upgrade tuning record database:
import argparse
import json

def _parse_args():
    parser = argparse.ArgumentParser()
    parser.add_argument(
        "--json-tuning-record",
        type=str,
        help="path to the json tuning record file",
        required=True,
    )
    parser.add_argument(
        "--updated-json-tuning-record",
        type=str,
        help="path to the new json tuning record file after upgrade",
        required=True,
    )
    return parser.parse_args()

ARGS = _parse_args()

def main():
    with open(ARGS.json_tuning_record, "r", encoding="utf-8") as i_f:
        lines = [json.loads(line) for line in i_f]
    for line in lines:
        for inst in line[1][0][0]:
            if inst[0] in ["Split", "Fuse"]:
                inst[2] = [1]
    with open(ARGS.updated_json_tuning_record, "w", encoding="utf-8") as o_f:
        for line in lines:
            o_f.write(json.dumps(line) + "\n")

if __name__ == "__main__":
    main()


[firebase_auth] Fix reauthenticateWithCredential

Fixes reauthenticateWithCredential.

It looks like this is fixed by https://github.com/FirebaseExtended/flutterfire/pull/237 so I'm going to move the integration test into that PR and land that one.


HBASE-24768 Clear cached service kerberos ticket in case of SASL fail…

…ures thrown from server side

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
10m  2s
branch-1 passed

+1 :green_heart:
compile
0m 21s
branch-1 passed with JDK v1.8.0_262

+1 :green_heart:
compile
0m 28s
branch-1 passed with JDK v1.7.0_272

+1 :green_heart:
checkstyle
0m 58s
branch-1 passed

+1 :green_heart:
shadedjars
4m 12s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
branch-1 passed with JDK v1.8.0_262

+1 :green_heart:
javadoc
0m 27s
branch-1 passed with JDK v1.7.0_272

+0 :ok:
spotbugs
2m 15s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 11s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 40s
the patch passed

+1 :green_heart:
compile
0m 25s
the patch passed with JDK v1.8.0_262

+1 :green_heart:
javac
0m 25s
the patch passed

+1 :green_heart:
compile
0m 27s
the patch passed with JDK v1.7.0_272

+1 :green_heart:
javac
0m 27s
the patch passed

-1 :x:
checkstyle
0m 47s
hbase-client: The patch generated 2 new + 1 unchanged - 0 fixed = 3 total (was 1)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m 50s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
6m  7s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 24s
the patch passed with JDK v1.8.0_262

+1 :green_heart:
javadoc
0m 31s
the patch passed with JDK v1.7.0_272

+1 :green_heart:
findbugs
1m 59s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 56s
hbase-client in the patch passed.

+1 :green_heart:
asflicense
0m 21s
The patch does not generate ASF License warnings.

45m 33s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2578/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2578

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 0a3fdc61440c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2578/out/precommit/personality/provided.sh

git revision
branch-1 / 8e387e9

Default Java
1.7.0_272

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2578/1/artifact/out/diff-checkstyle-hbase-client.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2578/1/testReport/

Max. process+thread count
138 (vs. ulimit of 10000)

modules
C: hbase-client U: hbase-client

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2578/1/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@apurtell  @abhishek-chouhan  Please review

Testing scenarios with behavior on new code:

Hadoop forceful methods not present in UGI - It would revert to the default behavior of using the non-forceful logouts based on time interval gap in UGI
Force relogin flag enabled and SASL login failure - It would do a force logout and login to clear the service tickets provided the previous relogin attempt is less than the configured relogin backoff
Forceful relogin flag is disabled and SASL login failure -  It would revert to the default behavior of using the non-forceful logouts based on time interval gap in UGI

@apurtell  Incorporated the comments, please review

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
11m 52s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

+0 :ok:
mvndep
2m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
8m  0s
branch-1 passed

+1 :green_heart:
compile
0m 39s
branch-1 passed with JDK v1.8.0_262

+1 :green_heart:
compile
0m 46s
branch-1 passed with JDK v1.7.0_272

+1 :green_heart:
checkstyle
1m 14s
branch-1 passed

+1 :green_heart:
shadedjars
3m 17s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 46s
branch-1 passed with JDK v1.8.0_262

+1 :green_heart:
javadoc
0m 49s
branch-1 passed with JDK v1.7.0_272

+0 :ok:
spotbugs
1m  5s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 49s
branch-1 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  8s
the patch passed

+1 :green_heart:
compile
0m 37s
the patch passed with JDK v1.8.0_262

+1 :green_heart:
javac
0m 37s
the patch passed

+1 :green_heart:
compile
0m 47s
the patch passed with JDK v1.7.0_272

+1 :green_heart:
javac
0m 47s
the patch passed

+1 :green_heart:
checkstyle
1m  6s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m  4s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
4m 54s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 37s
the patch passed with JDK v1.8.0_262

+1 :green_heart:
javadoc
0m 52s
the patch passed with JDK v1.7.0_272

+1 :green_heart:
findbugs
2m 58s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 35s
hbase-common in the patch passed.

+1 :green_heart:
unit
2m 41s
hbase-client in the patch passed.

+1 :green_heart:
asflicense
0m 24s
The patch does not generate ASF License warnings.

59m 22s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2578/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2578

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 7fd1a91d0c07 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2578/out/precommit/personality/provided.sh

git revision
branch-1 / b30d1d1

Default Java
1.7.0_272

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2578/2/testReport/

Max. process+thread count
138 (vs. ulimit of 10000)

modules
C: hbase-common hbase-client U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2578/2/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Fix typos

Fix typos

Thank you for your feedback! We’ll look into it and come back to you if we have any questions.

Hi @omahs
Most of the non-ABAP topics are fixed for the October 3rd release. I've contacted the ABAP colleagues to fix their topics too as soon as possible.
Thanks for the valueable feedabck!
Sincerely,
Nikola


Update scalafmt-core to 3.7.17

About this PR
📦 Updates org.scalameta:scalafmt-core from 3.7.15 to 3.7.17
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scalameta", artifactId = "scalafmt-core" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Let's wait for the 3.8.x PR


Poor Results finetuning with your dataset.

Hi, I got poor results finetuning your dataset on LLaVA1.5, I used the default training setting of LLaVA1.5, why is that? Could you please provide your setting?
only use LVIS-INSTRUCT4V:
MME: perception 915, cognition 244
gqa: 0.6% very low
pope: 0.73
sqa: 42.1%
textvqa:2.84% very low
llava1.5-7b reproduction:
MME: perception 1490, cognition 309
gqa: 62.5%
pope: 0.85
sqa: 68.57%
textvqa: 58.82%
setting:
default finetune.sh setting

Same question.  To achieve satisfactory results on the QA benchmarks, you should mix our LVIS-INSTRUCT4V with the data from academic tasks (see Table 1 & 7 of LLaVA 1.5 paper). Note that the results in our paper are all trained on a mixture of LVIS-INSTRUCT4V and these data, as clarified in Sec. 4.1.
We also provide the mixed data here.

Hi thank you for your reply! Another question is that, I mix your dataset LVIS-INSTRUCT4V-220k with llava_v1_5_mix665k which I got total 885k samples, then the finetuning results are not better than only using llava_v1_5_mix665k(baseline) and also not good as your report. need help~
LVIS-INSTRUCT4V-220k+llava_v1_5_mix665k:
MME: perception 1458, cognition 314
MMB: 0.658
MMB-cn: 0.606
gqa: 59%
pope: 0.849
sqa: 69%
textvqa: 57.7%
llava1.5-7b reproduction:
MME: perception 1490, cognition 309
MMB: 0.658
MMB-cn: 0.606
gqa: 62.5%
pope: 0.85
sqa: 68.57%
textvqa: 58.82%
setting:
default finetune.sh setting

Hi, the results are weird. Could you please share your experiment settings (e.g., pytorch version, GPUs) and loss curve with us? In addition, I think there are two possible ways to debug your problem efficiently (1) evaluate the results on these benchmarks with our provided checkpoint first (2) train on the data split that we released today (mixture of LVIS-INSTRUCT4V and academic data, you can also mix the LLaVA-150K, during our experiments, we append the LLaVA-150K after our LVIS-INSTRUCT4V and before academic data).

I finetune LLaVA-v1.5-7b with your LVIS-INSTRUCT4V_mix730k, and I got MME perception score 1525, which is consistent with your result, but MM-VET score is 30.6, which is much less than your result (34.6).  It's really weird :(

Hi, the results are weird. Could you please share your experiment settings (e.g., pytorch version, GPUs) and loss curve with us? In addition, I think there are two possible ways to debug your problem efficiently (1) evaluate the results on these benchmarks with our provided checkpoint first (2) train on the data split that we released today (mixture of LVIS-INSTRUCT4V and academic data, you can also mix the LLaVA-150K, during our experiments, we append the LLaVA-150K after our LVIS-INSTRUCT4V and before academic data).

Hi, thank you for your advice, I've tried the ways you suggested. Regarding the evaluation, I used the LVIS-Instruct4v-7b checkpoint, and the results almost matched the ones you provided: MME 1469.3 (yours 1472.9), MMB 67.9 (yours 67.1), gqa 62.6 (yours 62.6), pope 84.6 (yours 84), sqa 68.3 (yours 70.3), textvqa 57.5 (yours 57.6). This indicates that my evaluation pipeline is working correctly.
Furthermore, I compared fine-tuning with your dataset and the llava_mix665k dataset, and the results were nearly equivalent:

Fine-tuned on the llava_mix665k dataset: MME 1490.8, MMB 65.8, gqa 62.6, pope 85.5, sqa 68.5, textvqa 58.8.
Fine-tuned on your lvis_instruct4v_mix730k dataset: MME 1496.4, MMB 68.2, gqa 58.8, pope 84.5, sqa 68.6, textvqa 56.55.

Also I attempted fine-tuning on lvis_instruct4v_mix730k + llava150k, but the results were not satisfactory. Here are the results: MME 1502.5, MMB 65.8, gqa 58.8, pope 85.1, sqa 69.3, textvqa 57.23.


[v2.7] Azure node driver rke2/k3s nodes get recreated post rancher server upgrade

Information about the Cluster
Rancher Server Setup

Rancher version: v2.6.10 upgraded to v2.6.11-rc7 and v2.7.0 upgraded to v2.7-head
Installation option (Docker install/Helm Chart): Helm Chart

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): RKE1, v1.24.4 , 1.3.15

Proxy/Cert Details: Self-signed

Information about the Cluster

Kubernetes version: v1.24.9+rke2r2
Cluster Type (Local/Downstream): RKE2 node driver -  1 worker, 1 etcd, 1 cp

Describe the bug
On a rancher server upgrade, azure rke2 and k3s node driver cluster nodes are re created.
To Reproduce

Create a rancher server on v2.6.10
Create an azure rke2/k3s node driver cluster as a standard user with the spec mentioned in information about the cluster
Upgrade rancher server to v2.6.11-rc7
Notice the cluster goes into updating state.

Result
If we check the azure portal and also from rancher cluster management page >> cluster >> machine pools, all the nodes are recreated.
Expected Result
Expected the nodes were not re created.
Screenshots

Additional context
Ran a few tests as follows:

On an upgrade from 2.6.10 >> 2.7.0, the issue doesn't seen happening
On an upgrade from 2.7.0 >> 2.7-head, the issue happens on both k3s/rke2 cluster
The issue doesn't happen on:

aws node driver rke2 cluster
aws node driver rke1 cluster
azure node driver rke1 cluster

A related issue seen while the nodes are re created is the etcd node is stuck in reconciling/deleting state as mentioned here:
https://github.com/rancher/rancher/issues/40588

/backport v2.6.11

Needs rc

Sending back for QA test template

Root cause
When rancher is upgraded and the embedded version of rancher machine upgrades (as well as all third party node drivers), the dynamic schema objects are regenerated (if and only if the list of available flags for that particular driver has changed). When the schema objects are regenerated, the v2 provisioning config, infrastructure machine, and infrastructure machine template CRDs are redefined which previously included defaults for these values. Once the default values were added, CAPI would recognize that the machine-template-hash for the machine templates has changed, causing the entire cluster to reprovision.
What was fixed, or what changes have occurred
Store the machine driver's spec as a field on the machine pool.
YOU WILL NO LONGER BE ABLE TO EDIT A CLUSTER TO ENABLE NEW FEATURES AND HAVE THIS APPLY TO EXISTING MACHINE POOLS. YOU WILL NEED TO PROVISION A NEW NODE POOL, OR REMOVE THE dynamicSchemaSpec FROM THE MACHINE POOL
Areas or cases that should be tested
Test all supported node drivers

Updating rancher does not reprovision node pools
Updating cluster does not reprovision node pools
Adding node pools works
Removing dynamic schema field will cause all machines in pool to be reprovisioned if the node config has changed (i.e., if you upgraded from 2.7.1 -> this version with azure node driver).

What areas could experience regressions?
RKE2/K3S etcd restore (should still work but I abstracted out the base64+gzip compression and decompression which is used by restore)
Are the repro steps accurate/minimal?
:heavy_check_mark:

Test Environment:
Rancher version: v2.7-head 2b2ed44
Rancher cluster type: HA
Docker version: 20.10
Downstream cluster type: rke2

Testing:
Tested this issue with the following steps:

Create a rancher server on v2.7.0
Create an azure rke2/k3s node driver cluster as a standard user with the spec mentioned in information about the cluster
Upgrade rancher server to v2.7-head
Verify the machine pool is preserved

Result
After upgrading, the nodes in the machine pools were preserved

Full test plan regarding relevant issue can be found here 40628

RELEASE NOTE PLACEHOLDER


How to read HingeConstraint angle

Hello,
Is there an equivalent to ammo.js function getHingeAngle on HingeConstraint ?

Hi.  I'm right with you, gballanger.  I need this, too.
https://playground.babylonjs.com/#7YV8E0#140
Lines 265-277... I'm diving deep into the pertinent hinge equations, but I just don't know what I am doing and I suffer from bad math disease.
I need to get the angle from the hinge itself, and as you can see by refs to mesh2.rotationQuaternion in that area of code, I am currently NOT getting everything from the hinge equations.  I'd HIGHLY prefer to NOT use the Quats on the rotated mesh... to derive hinge angle.
265        this.jacY = joint1.physicsJoint.equationX.jacobianElementB.rotational.y;
266        this.jacZ = joint1.physicsJoint.equationX.jacobianElementB.rotational.z;
equationX.jacobianElementB.rotational.x and .z are giving me some good "live" values as the hinge swings... but I just don't know what to do with them... to get classic angle in degrees.
I've talked about here:  https://forum.babylonjs.com/t/calc-current-hinge-angle-of-running-motorized-joints-cannonjs/5720
Some talk here, too... about my custom motor: https://forum.babylonjs.com/t/motorizing-the-cannon-hinge-joint/5833
Cannon native motors have weak power, no matter the maxForce... when motor speeds are extremely slow, like those needed for this landing gear retract/deploy activity. My custom motor class uses continuously-set angular velocity on shapeB (leg1)... to give me a more consistent motor-speed/force.  Still, it runs faster when pushed by mass, but not as much as native motor.
ANY help from ANYONE... is highly welcomed.  Thank you!  I have SOME funding to donate... but not much.  Got solves/ideas?  Feel free to contact me here, or at BabylonJS forum, or at wingthing at charter dot net.  Thanks again!  (hug)

Hi @Wingnutt i've seen you in a few threads regarding HingeConstraints and i'm facing the same problems - I was wondering did you ever find a solution to this?


save_dvc_exp: warn and continue if save fails

Right now, if there is a problem with saving the experiment (like an invalid dvc.yaml), the script fails with an error. Instead, it should succeed and warn that the experiment failed to save.

It turns out that save_dvc_exp=True when combined with dvc repro also fails because of a lock error.
Addressing this issue would make it to just not save the experiment but I don't know if that's enough or we should try to do something else for that case (try to make it work, a more explicit warning, make it ignore save_dvc_exp like dvc exp run does)

Addressing this issue would make it to just not save the experiment but I don't know if that's enough or should we try to do something else for that case (try to make it work, a more explicit warning, make it ignore save_dvc_exp like dvc exp run does)

This should be enough until we know better whether there are valid workflows for dvc repro + dvc_exp_save.


Gulp task stopped working with Powershell

After updating to the version 0.5.4 of the Gulp task it has stopped working for us on Windows build agents.
It exits with the following error:
A parameter cannot be found that matches parameter name 'gulpjs'.
It seems commit 01289943e0701f1cf33826ae977dfa6805308fe9 introduced a new parameter 'gulpjs' for the task's js implementation but the parameter is not recognised by the Powershell script.

What do you mean you updated to the version?  You should not upload tasks in the repo to your own accounts or servers as they may not be compatible.
Ting, you should have updated the minimum agent version when you added a parameter for the node implementation and didn’t add the same parameter to the deprecated powershell implementation.
From: Kim Fiedler Vestergaard<EMAIL_ADDRESS>Sent: Friday, December 4, 2015 3:30 AM
To: Microsoft/vso-agent-tasks<EMAIL_ADDRESS>Subject: [vso-agent-tasks] Gulp task stopped working with Powershell (#923)
After updating to the version 0.5.4 of the Gulp task it has stopped working for us on Windows build agents.
It exits with the following error:
A parameter cannot be found that matches parameter name 'gulpjs'.
It seems commit 0128994https://github.com/Microsoft/vso-agent-tasks/commit/01289943e0701f1cf33826ae977dfa6805308fe9 introduced a new parameter 'gulpjs' for the task's js implementation but the parameter is not recognised by the Powershell script.
—
Reply to this email directly or view it on GitHubhttps://github.com/Microsoft/vso-agent-tasks/issues/923.

Noted here: https://github.com/Microsoft/vso-agent-tasks/blob/master/docs/contribute.md
@fiedler  - These are in the box tasks that we own deploying to the service and you will get in future Quaterly on-prem updates.  They are open sourced as reference examples of how to write tasks and help you debug.  You cannot take future tasks (master branch hasn't shipped) which is code a sprint or multiple sprints (onprem) ahead and expect it to work.  Just as you can't take a binary from a future version of a box product and just drop it into another version and expect it to work.  That's unsupported.
The upload tool is to upload your custom tasks or a patched task that the product may hand out (we have release branches that correspond to each release).

@fiedler - can you confirm if you updated the task?
Or, are you saying you got the new sprint and now it's broken?  In that case, does updating the agent, restarting fix it?  Or are you using hosted pool?

Sorry I should have been more clear.
We have the problem on a on-premise setup of TFS. I believe someone here updated the task manually and I can understand from your comments that they shouldn't have.
I think they did it to get a fix for arguments in 0c40691e5c2f25ad2960eca737ced8c3bcbd02e9.

OK - if they wanted to patch gulp with a fix for arguments then the right thing to do is patch the proper release branch.
releases/83 is RTM
releases/89 is QU1
If they do a pull request against either of those with whatever patches they need, I'll approve then it's OK to patch with those.

I need a map of branch to on-prem release on the main page

closing - PR one of the release branches if you want


Fix str tokens causing a crash

@FuegoFro you're right, I just tried that test again without the change and it was still working, maybe I should revert this change, sorry I'm not sure why I committed this then 🤔


I2c pullup enable/disable option

I2C default is internal pullup enabled.
Disable internal pullup option is needed for external pull up

We reviewed other boards's I2C statue and agree that it does not need to have I2C pull-up enable / disable options.
It's better to use internal pull-up for the low speed I2C interface and give detailed guide of I2C pull-up register in the document.


Update opentelemetry-api, ... to 1.25.0

About this PR
📦 Updates

io.opentelemetry:opentelemetry-api
io.opentelemetry:opentelemetry-exporter-jaeger
io.opentelemetry:opentelemetry-exporter-otlp
io.opentelemetry:opentelemetry-sdk
io.opentelemetry:opentelemetry-sdk-testing

from 1.16.0 to 1.25.0
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.opentelemetry" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "io.opentelemetry" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Codecov Report
Patch coverage has no change and project coverage change: -0.07 :warning:

Comparison is base (73ed185) 59.77% compared to head (a07f1ac) 59.71%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
- Coverage   59.77%   59.71%   -0.07%
==========================================
  Files         152      152
  Lines        3254     3254
  Branches       92       92
==========================================
- Hits         1945     1943       -2
- Misses       1309     1311       +2

see 3 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Superseded by #361.


Remove deprecated dependency. TS Update. Fix tslint warnings

This PR includes the following changes:

Remove deprecated dependency(@types/es6-promise - was added in PR SyncTasks/17).
Fix tslint warnings
Fix npm run test command (does not work in master branch)
Update TS to the latest stable version (2.8.3)

@deregtd @boguscoder are there any issues in the PR which should be fixed?

@boguscoder You most recently dealt with the es6-promise addition.  Can you verify this is fine and if so I can merge?

let me test this with Skype, will report soon ;)
@deregtd @a-tarasyuk we may want to bump minor ver?

I don't think we need to change it, it doesn't actually change the interface for customers, right?


Show placeholder if there is no object title

Ticket: https://github.com/colonial-heritage/sprints/issues/334

@Doppen This pull request will add a placeholder text if no title exists. I have added you as a reviewer so you can check the design.

Nice! Zou je bij geen titel de class text-sm text-consortiumBlue-100 mee kunnen geven?


MIECD Dashboard Performance

[ ] The dashboard is slow and has performance issues, we need to make it load the pages faster.

Closing this with an aim of looking at this at a later stage.


Uninstall packages.

I tried to uninstall a package and give me a error.

There are few steps that need to be taken to support uninstallation.
First off, I think we really need to get back to the dedicated package format from 1.2.x. We're most of the way there since 2.0 is using only compressed tarballs.
Second, we need to store a manifest of all of all files owned by installed packages. This is how we find what to remove, and as far as I know it's how systems like dpkg work. It's also a useful feature even without uninstallation: Knowing what file a package belongs to is super helpful for all sorts of other tasks.
Sadly, I don't really have capacity in the roadmap for any of this to make it into 2.0, but it might happen for 2.1. I am also working on setting up automated pipelines for building packages for all of our ports. It'll also help potential distributions of ToaruOS (or would they be distributions of Misaka now?) manage their own package repositories.


Add priority to existing icons.

Problem Description:
Icon priority was not set for new icon additions in: https://github.com/project-lux/lux-frontend/issues/40. This causes issues for records with multiple classifications as they are not prioritized correctly.
Expected Behavior/Solution:
Set priority for icons to ensure records will be classified based on its hierarchy.
Requirements:

Records with multiple priorities will display the icon that has the highest priority.
Priority must be set as the following order below:

Scores and Notation
Photographs
Furniture
Journals & Newspapers
Clothing
Numismatics
Cartography
Video
Audio
Software & Electronic Media
Visual Works
Textual Works
Objects
Specimens
Collections

Needed for promotion:
If an item on the list is not needed, it should be crossed off but not removed.

[ ] Wireframe/Mockup - Mike
[ ] Committee discussions - Sarah
[ ] Feasibility/Team discussion - Sarah
[ ] Backend requirements - TBD
[ ] Frontend requirements- TBD
[ ] Are new regression tests required for QA - Amy
[ ] Questions
List of questions for discussions. Answers should be documented within the issue.

UAT/LUX Examples:
Should have an icon of musical notations rather than textual works:

https://lux-front-tst.collections.yale.edu/view/object/ab5f42b8-5a18-4581-b89f-c362db317bf2
PRD: https://lux.collections.yale.edu/view/object/ab5f42b8-5a18-4581-b89f-c362db317bf2

Dependencies/Blocks:
N/A
Related Github Issues:

https://github.com/project-lux/lux-frontend/issues/40

Related links:

Bugherd: https://www.bugherd.com/projects/284041/tasks/2606

Wireframe/Mockup:
Current:

Expected:

@miketullo95 - can you please create a mockup that includes the musical notation icon rather than the book icon currently listed in the URL under UAT example. Thank you.

@roamye wireframe uploaded, is that what was expected?

@miketullo95 yes, thanks!

Approved by UAT

this looks good in prod. Closng.

Sorry accidently closed this after lookin at it in tst.

Closing looks good in PROD.


Use .pypirc for authentication

Twine can use a .pypirc (for example ~/.pypirc) to authenticate against the repository. It would be nice if poetry used it.

References:

Python documentation, section 6.2.4
“Using .pypirc“, Flit documentation

Counter-arguments:

it’s a plain-text (unencrypted) file in the home directory
not always created with permissions that only allow user to read it
multiple config files (.pydistutils.cfg and .pypirc) are confusing for users

The argument is compatibility vs. clean break.
I wonder what PyPA folks would recommend for this (@ncoghlan @dstufft).

Adding something like the following to poetry/poetry/masonry/publishing/publisher.py should do the trick:
# at the top
import os
from configparser import ConfigParser

# inside Publisher.publish:
cfg = configparser.ConfigParser()
try:
    cfg.read(os.path.expanduser('~/.pypirc'))
    username = username or cfg.get('pypi', 'username', fallback=None)
    password = password or cfg.get('pypi', 'password', fallback=None)
except FileNotFoundError:
    pass

I'll come back and assign this to myself if ever get around to setting up a Poetry development environment and try to make this work. Otherwise, it's unclaimed.
From looking at that file and the README, it looks like there's some way to use poetry config to persist the username and password too, but I couldn't figure out how to make it work.
It would also be cool to save the username either to .pypirc or to the Poetry config store, and/or to read the password from and save it to Keyring, like Flit does.

@osteele currently it is possible to save the credentials with these two files:

~/.config/pypoetry/config.toml

[repositories]
pypi = {url = "https://upload.pypi.org/legacy/"}
testpypi = {url = "https://test.pypi.org/legacy/"}

~/.config/pypoetry/auth.toml

[http-basic]
pypi = {username = "myuser", password = "topsecret"}
testpypi = {username = "myuser", password = "topsecret"}

It can be done through the CLI, but i don't remember how…
I didn't know it was possible when i opened this issue. So now i can do without it. But i leave the issue open because it could be nice to have compatibility accross the different tools.

Counter-arguments:

Yeah, maybe asking users to put plaintext passwords in a file should be considered a legacy behavior that shouldn't be pushed forwards.
I like what Flit does: read and write the username to and from .pypirc; read the password from .pypirc if it's there, but otherwise read and write it to Keyring.
I'll open another issue for the use of Keyring for storing the password. It's related to this one, but requires different implementation steps (that could supplement this one), and may raise a different set of concerns.
Here's a code sketch that only uses the password from .pypirc if that file is protected . This matches the behavior of ssh with regards to the private key files in ~/.ssh.
PYPIRC_PERMISSIONS_WARNING = r"""Warning: unprotected PyPI configuration file!
Permissions 0{:o} for {!r} are too open.
It is required that your password is NOT accessible by others.
The password will be ignored.
"""

pyprc_path = os.path.expanduser('~/.pypirc')
if os.path.exists(pyprc_path):
    cfg.read(pyprc_path)
    cfg = configparser.ConfigParser()
    username = username or cfg.get('pypi', 'username', fallback=None)
    if not password:
        password = cfg.get('pypi', 'password', fallback=None)
        mode = os.stat(pyprc_path).st_mode
        if mode & (stat.S_IRWXG | stat.S_IROTH):
            sys.stderr.write(PYPIRC_PERMISSIONS_WARNING.format(os.stat(pyprc_path).st_mode & (stat.S_IRWXU | stat.S_IRWXG | stat.S_IROTH), pyprc_path))
            password = None

It can be done through the CLI, but i don't remember how…

It's documented in Repositories > Configuring Credentials on the web site:
poetry config http-basic.pypi username password

(It actually took me a while to find it, because I didn't realize the website had additional information about poetry config that wasn't in the README. I'm hesitant to submit an issue or PR, since I don't know if that's an issue with the README or just with me…)

Since poetry already reads and stores credentials in a plaintext file, can we get .pypirc support? Or is it considered redundant?

(It actually took me a while to find it, because I didn't realize the website had additional information about poetry config that wasn't in the README. I'm hesitant to submit an issue or PR, since I don't know if that's an issue with the README or just with me…)

I only found this now. In fact I missed the link at the top of the GitHub repository. It would nice to add a big "Documentation" link in the README because it's what I always and immediately search in a README.

This is not something that is planned. I prefer Poetry to be self sufficient and not to depend on other configuration files than its own.

Using this file feels even more helpful, as it now seems that Poetry cannot cache the password in a file anymore. The default keyring usage is not helpful, as it brings the user out of the terminal, and often into a program they don't understand.

Token is better for automation than password.


Update elm/http and elm/json dependencies

Hello! This is the only change required after the changes in the latestelm/http package. I believe this change should be good to go.
Thanks for the awesome package!

I'd suggest that the comments be updated as well. sendRequest is mentioned in quite a few places.

I'm just running some fixes on the CI build. I think it's just that elm-test has been updated. If they pass I'll merge.

Published as v6.0.0. Thanks very much for your help @dillonkearns & @ringvold. :-)

Hey Kris, thank you so much for the quick publish! Sorry we didn't catch the typo in the getNews example, glad it's fixed now 👍


Update app-oracle.yml

1.tablespace监控项queryType改为multiRow显示全部列表。
2.新增慢sql展示
What's changed?

Checklist

[ ]  I have read the Contributing Guide
[ ]  I have written the necessary doc or comment.
[ ]  I have added the necessary unit tests and all cases have passed.

@all-contributors please add @ChenXiangxxxxx for code


Merging two CommonModels can overwrite unwanted properties

Describe issue
With the current implementation of the merging of CommonModels we hardcode that the CommonModel being merged into another overwrites the following properties:

$id
$ref
extend
originalSchema

How to solve
I am not entirely sure how to solve this unless we allow those properties to contain multiple values, but that does not make sense from the generator's perspective.
Could we maybe add an option for the user to decide the merge option they want? 🤔

@jonaslagoni this is even more complex after I intruduced this issue.

Still relevant, as #365 should solve this by providing both models, time will tell.

As I have yet to find an example that can be tested for where we don't see an expected behavior it's almost impossible to ponder in which scenarios it won't work...
Lets go by each use-case and see where it does not work.


Updated vpm.bat for usage in 'PATH'

Updated vpm.bat to be used in when the containing directory is in the PATH variable

awesome thanks!


Tidying up readability in Breonna section

Just a few small changes to phrasing etc. to make the explanations more consumable, as well as some minor grammar/spelling corrections.

Please re-check, think I fixed the issues :)


Offer EXTRA_UNHANDLED_RECEIVER

(along with equivalent builder methods)
This extra would have a ResultReceiver. If an unexpected condition occurs (e.g., various camera issues that we can't handle, JPEGWriter can't write the image), send information in a well-documented Bundle to the ResultReceiver before finishing the activity.

Addressed in v0.5.8.


Change CultureCode to Language Code

As soon as https://github.com/digdir/dialogporten/issues/863 is merged, cultureCode must be replaced with languageCode from queries.
Expected locales relevant for us: en, nb, nn.

Fixed in PR: https://github.com/digdir/dialogporten-frontend/pull/794


(If yes, list here)
Screenshot
(Link above will always be the most up-to-date version.)

@saravanpa-aot I need an estimate on this


v1.6.4: Gdx.input.isKeyPressed() for Keys.ALT_LEFT and Keys.ALT_RIGHT always true

It is as the title states, doing this check always returns true, even when another key is pressed. I don't know which version it crept in, because it was working properly before.

SSCCE please

I tried it with 1.6.4 on windows with both isKeyJustPressed and isKeyPressed and both return true only when the key is really pressed.

sorry for not seeing this right away. I'll have to check again. I may have been mistaken about what version I'm using. I forgot I set it up on Gradle to use the latest snapshot, which is at 1.6.6 as of this writing.

It maybe an issue with the (Razr) keyboards we're using, along with some other environmental issues that's making the report for ALT erratic.
Thanks for looking in on this.

Sorry to reopen this, I think I found out what the issue was. My dev environment is in Windows 7 64-bit, so I use Alt+Tab to switch between windows. When I return to running application, the check for ALT, will then always be true.

I've got Windows 7 64bit as well and tried this. Cannot confirm.

ah. I see. I apologize, it was a long day when I reopened this. After seeing your comment, I looked into it some more and found that the issue is caused by a backend I'm using. I'll take it up with the authors there. Closing this one again.


[BUG] Careamics fresh install broken, installed Zarr alpha version

Describe the bug
careamics installed latest alpha version of zarr>=3.0.* which breaks when running example notebooks.
To Reproduce

Install careamics following wiki instructions (link).
Pypi package was installed as pip install --pre "careamics[examples, wandb, tensorboard]"
Run example notebook SEM_Noise2Void.ipynb
error in first cell when importing Zarr: ImportError: cannot import core from zarr

Expected behavior
To run the example notebook without problems.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Ubuntu
Version 22.04

Environment:
Packages attached as text file.
careamics_env.txt
Additional context
Downgrading zarr to version 2.18.2 makes everything work again.

Hi Nuno!
Thanks! Indeed, the latest pre-release still has that problem. It is fixed in main since https://github.com/CAREamics/careamics/pull/149 and will be in the next pre-release!
Hopefully, this week! I leave this open until it is released.

The new pre-release should have fixed that.


[sorted-map] Insert function?

Package sorted-map has a set function to add a key/value to an existing map:
set<K, V, U> (key: K, value: V, map: SortedMapStructure<K, V, U>): SortedMapStructure<K, V, U>
But I cannot find a function to insert a value somewhere in the middle of the map. Something like:
insert<K, V, U> (index: number, key: K, value: V, map: SortedMapStructure<K, V, U>): SortedMapStructure<K, V, U>
Am I missing something? Thanks.

Hey, yep you're missing something :-)
The sorted map is self-sorting - that is, you define the sorting criteria when you construct the map, and it sorts items according to those criteria. If you could just insert items into any index, it wouldn't necessarily be sorted.
You have two options:

You could use a list and a map; use the map to store an index, then insert the item into the associated index in the list.

Store the index as a field in the object you're adding to the map, then specify the index field as the sorting criteria, like so:

import { empty, set } from '@collectable/sorted-map';

const comparator = (a, b) => a.value.index - b.value.index;
const sortedMap = empty(comparator);
const updatedMap = set('key', { id: 1, index: 10 }, sortedMap);

To change the index, just remove the item and re-insert it.

Somehow, I expected that, even though the map uses order-of-insertion by the default, I could still insert a value anywhere in the tree without too much hassle. Tbh I did not check the code details :) Option no 1 I had already considered, no 2 it's an approach I hadn't thought of, I'll check how it works. Thanks for the detailed answer!

No worries! Also, note that you'll experience unexpected behaviour if you mutate any fields that are used as sorting criteria before removing the associated object from the map. If you intend to be able to modify your object without having to remove it from the map first, I'd suggest using a wrapper object, e.g.: const objectToInsert = { index: 10, value: myObject }


🎵 demo: AI powered MUSIC lyrics fetcher/finder!

What does this PR do?

Adding a new demo application in the community/demos directory
Music lyrics finder with beautiful UI powered by AI

Checklist

[x] I have read read the Contribution Guide
[x] If the PR changes or adds functionality, I have updated the relevant documentation

Nice @ArnavK-09!


Need a formal way to register element resources

Currently there is no formal way for custom elements to register their resources (scripts and styles). Instead, the module would need to implement IShapeTableProvider and attach a callback for the OnDisplaying event of the EditorTemplate shape. This works when the layout editor is being rendered by the LayoutPartDriver, but fails when custom modules reuse the layout editor by rendering the LayoutEditor view model directly using the Html.Editor HTML helper.
One suggestion is to turn the LayoutEditor view model into a shape and implement a default shape table provider that itself triggers an event on a formalized event handler, which custom modules can implement to register element resources.
Another approach could be to automatically include resources based on a convention, similar to the way Workflows is doing that. the downside is that we would get a lot of 404s, since not all elements will need to provide resources.
So the ultimate solution I think is to enable element classes / descriptors to specify the resources they want included. These resources need to be rendered at the same time the layout editor is rendered, since the elements themselves are rendered using AJAX.

Also wanted to add that this is the same issue as with Workflows and the Workflows solution that blindly includes files is far from ideal.

Yeah, true. Could be solved with the same suggested approach (the one I labeled to be the ultimate one ;))


feat(bigtable): Remove deprecated Bytes from BigEndianBytesEncoding

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)
[ ] Rollback plan is reviewed and LGTMed
[ ] All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕
If you write sample code, please follow the samples format.

/gcbrun

similar to my comment on the go side, I'm fine with an API breaking change here:

This is still @BetaAPI (we should remove that though)
It has only existed for ~a week
Its unlikely anyone is using the more complicated builder API that we changed here anyways

/gcbrun


Fix firefly-tokens-erc1155 with evmconnect

I think these are the relevant PR's:
https://github.com/hyperledger/firefly-tokens-erc1155/pull/92
https://github.com/hyperledger/firefly-transaction-manager/pull/20
https://github.com/hyperledger/firefly-cli/pull/204


[Merged by Bors] - chore: remove useless include and omit porting notes

bors r+

cf leanprover/lean4#2452


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-yml-archive-non-versioning-archive/pull/274 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-yml-archive-non-versioning-archive.git

Docs Build status updates of commit 64fdbeb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/TOC.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-3.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-3.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


updating htmllint version

The current one is out of date

Please merge this PR

@mlochbaum @coalman Hey guys don't mean to be a bother but could you get this merged in?

Hate to beat a dead horse, but is there any way we can get this updated?

I love beating dead horses - please update as we're still getting error [ local htmllint version is not supported: 0.8.0 != ^0.7.2 ]


[feature] Improve "Try Again" logic on ios when deeplink is canceled

What problem does this new feature solve?
When users cancel native ios prompt for deeplink, ios goes into state where all further prompts are invalid until user refreshes the browser. We could improve on handling this.
Describe the solution you'd like

Checking if user left the dapp or not (flag on window visibility event changes)
If user has left the dapp, we assume that they wen't to wallet successfully, in which case "Try Again" remains as a deeplink
If user has not left the dapp, we assume that user canceled native deeplink prompt and should reload the window

Hey team, the problem persists on IOS with the latest library v5.1.6. Any updates?  I see this has been closed as completed.


tree : fix the cursor css

Issues : https://github.com/ElemeFE/element/issues/16830

[x] Make sure you follow Element's contributing guide (中文 | English | Español | Français).
[x] Make sure you are merging your commits to dev branch.
[x] Add some descriptions and refer relative issues for you PR.

before :

after :

Sorry, we have no plan to support this.


Items are hidden with no way of changing that

So I uploaded a map with the tool and when my friend went to subscribe to the map it told him that the item was hidden.
(v His screenschot v)

I went to change the visibility but the button was just gone.

I went into the tool and it said that the visibility was set to public but it obviously wasn't.

I'll look into it.

 I am incredibly confused and it's not cooperating.

So what now?

now, I'll have to wait, I am attempting to contact a Valve contractor in the hopes they can shed light on the issue, I will try to fix this issue to the best of my abilities, even if I have to take Portal 2's original uploader apart  to fix the issue. This may take a while tho, I am sorry for the inconvenience.

A workaround currently is to create a dummy item with Portal 2's original uploader and editing it with mine, I'll have to snoop around what Portal 2's does differently, but without it's source code I can only guess.

Good luck

Should be fixed in next release (in a few minutes.)

https://github.com/Trico-Everfire/p2-publishing-tool/releases/tag/v2.0.6-beta

As soon as someone confirms it works for them, I'll close this issue.

Issue has been confirmed to be fixed in newest release, if this reoccurs reopen issue.