The ability to get scripts from vim.org

Continued from #202 (closed).
Since vim-scripts is no longer maintained, there is no way to fetch the latest versions of scripts that do not have their own git repos (e.g. IndentConsistencyCop).
It would be awesome if we could continue to be able to update these scripts using vim-plug. Do you see supporting the downloading of scripts directly from vim.org anywhere on the horizon?

Allow me to interject, why they don't have git repositories? Are they believe version control system is a sin?

I know Ingo maintains his plugins on github. Oh quoting from your link:

INSTALLATION
The code is hosted in a Git repo at     https://github.com/inkarkat/vim-IndentConsistencyCop You can use your favorite plugin manager, or "git clone" into a directory used for Vim packages. Releases are on the "stable" branch, the latest unstable development snapshot on "master".

Came here to ask the same.  YankRing was updated recently (after almost 4 years) https://www.vim.org/scripts/script.php?script_id=1234 but the https://github.com/vim-scripts/YankRing.vim mirror will probably never get updated.

freq+ ; this is now out of sync too:
https://www.vim.org/scripts/script.php?script_id=2140
https://github.com/vim-scripts/xoria256.vim

vim-plug heavily relies on git (one can even say that it's basically a git wrapper for Vim plugins) and I don't think we're ever going to support different mechanisms.


THRIFT-5581: java lib to upgrade to gradle 7 and migrate from maven to maven-publish plugin

relies on https://github.com/apache/thrift/pull/2561 to be merged first

[x] Did you create an Apache Jira ticket?  (not required for trivial changes)
[x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
[x] Did you squash your changes to a single commit?  (not required, but preferred)
[x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
[x] If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

move off maven
because ...

move off maven

because ...

I had to correct my typing, sorry for the confusion... @Jens-G

This is put to draft state because on xenial JDK 8 is used but somehow gradle 7.4+ does not quite work with Java 8. It'll at least require Java 11, which makes sense because it's the LTS version that's not at its end of life now.

move off maven

because ...

@Jens-G "maven" is the name of the Gradle plugin used for the publishing of the libthrift.jar. That Gradle plugin was deprecated and replaced by a plugin called "maven-publish". Gradle 7 does not support the old plugin, so this transition needs to happen in order to support Gradle 7.

This is put to draft state because on xenial JDK 8 is used but somehow gradle 7.4+ does not quite work with Java 8. It'll at least require Java 11, which makes sense because it's the LTS version that's not at its end of life now.

My personal preference would be to migrate the build to use JDK 11 at a minimum. The resulting libthrift.jar could still be used with Java 8, if the appropriate --release 8 flag is placed on javac. In my experience, JDK 11 is even better than JDK 8 at enforcing the Java 8 language rules and results in byte code that more reliably runs on a variety of Java 8 runtimes anyway. But, I don't know if you'd get resistance to this, because some people don't like building and testing with a different JDK version than the Java runtime the jar is targeting. I don't know how to set --release 8 for Gradle, but it can't be too hard.

Looking at this changeset makes me just hate Gradle so much. There's just so much tooling that I don't understand, and some of it seems pretty low-level. I prefer Maven over Gradle. I know XML sucks, but I think its lifecycle concept is simpler, and the conventions are more concise. The direction these changes are going is fine, though. I'm learning Gradle by reviewing these. Maybe I won't hate it as much as I understand it more. But, I understand Makefiles, and I still hate them... so maybe I still will. :shrug: :smiley_cat:

Looking at this changeset makes me just hate Gradle so much. There's just so much tooling that I don't understand, and some of it seems pretty low-level. I prefer Maven over Gradle. I know XML sucks, but I think its lifecycle concept is simpler, and the conventions are more concise. The direction these changes are going is fine, though. I'm learning Gradle by reviewing these. Maybe I won't hate it as much as I understand it more. But, I understand Makefiles, and I still hate them... so maybe I still will. 🤷 😺

I'm totally with you on e.g. the unencessity of breaking changes needed to upgrade from 6.x to 7.x and all the migration from maven to maven-publish are just friction with no obvious gain. on the other hand there are good chances happening in gradle land, e.g. using .kts i.e. kotlin which has better tooling and typing support than groovy. Nowadays i don't use maven as much but it's a more mature and popular choice so i'm okay with learning and using either one. currently libthrift uses gradle so be it (unless someone wants to make a chance).

I saw Travis fail with:
BUILD SUCCESSFUL in 45s
6 actionable tasks: 6 executed
ninja: build stopped: subcommand failed.
The command "build/docker/run.sh" exited with 1.

No idea what the problem is.

I saw Travis fail with:
BUILD SUCCESSFUL in 45s
6 actionable tasks: 6 executed
ninja: build stopped: subcommand failed.
The command "build/docker/run.sh" exited with 1.

No idea what the problem is.

the error was further above. search for ECONNRESET - it's a flaky download connection reset, i guess rebuilding would help. but that's only limited to nodejs which i haven't touched in this pull request.

@Jimexist This looks good to me, but I'm curious what the user experience is when trying to build with JDK 8. Will it fail in incomprehensible ways, or will the requirement to use JDK 11 be made obvious? For Maven, the maven-enforcer-plugin can provide a meaningful error message when the minimum Java version is not used.

@Jimexist This looks good to me, but I'm curious what the user experience is when trying to build with JDK 8. Will it fail in incomprehensible ways, or will the requirement to use JDK 11 be made obvious? For Maven, the maven-enforcer-plugin can provide a meaningful error message when the minimum Java version is not used.

In that case gradle will complain saying that gradle 7.4.2 needs Java 11.
I also put a step in https://github.com/apache/thrift/pull/2602/files where the Java 11 built artifact is run using Java 8 during cross test to make sure

FYI i think JDK 8 support is still with Gradle 7:

build log
root@5ec15a799389:/opt/thrift/src/lib/java# ./gradlew
bash: ./gradlew: No such file or directory
root@5ec15a799389:/opt/thrift/src/lib/java# java -version
openjdk version "1.8.0_332"
OpenJDK Runtime Environment (build 1.8.0_332-b09)
OpenJDK 64-Bit Server VM (build 25.332-b09, mixed mode)
root@5ec15a799389:/opt/thrift/src/lib/java# ./gradlew assemble
Downloading https://services.gradle.org/distributions/gradle-7.4.2-bin.zip
...........10%...........20%...........30%...........40%...........50%...........60%...........70%...........80%...........90%...........100%

Welcome to Gradle 7.4.2!

Here are the highlights of this release:
 - Aggregated test and JaCoCo reports
 - Marking additional test source directories as tests in IntelliJ
 - Support for Adoptium JDKs in Java toolchains

For more details see https://docs.gradle.org/7.4.2/release-notes.html

Starting a Gradle Daemon (subsequent builds will be faster)

> Task :compileJava
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

> Task :javadoc
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/EnumCache.java:51: warning: no @return
  public TEnum get(Class<? extends TEnum> enumClass, int value) {
               ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/ThriftMetadata.java:112: warning: no @param for level
    protected String getIndent(int level) {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/ThriftMetadata.java:112: warning: no @return
    protected String getIndent(int level) {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/ThriftMetadata.java:117: warning: no @param for sb
    protected void append(StringBuilder sb, String format, Object... args) {
                   ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/ThriftMetadata.java:117: warning: no @param for format
    protected void append(StringBuilder sb, String format, Object... args) {
                   ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/ThriftMetadata.java:117: warning: no @param for args
    protected void append(StringBuilder sb, String format, Object... args) {
                   ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/ThriftMetadata.java:122: warning: no @return
    protected String getName() {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:37: warning: no @param for obj
  public static void checkNotNull(Object obj, String argName) {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:37: warning: no @param for argName
  public static void checkNotNull(Object obj, String argName) {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:42: warning: no @param for value
  public static void checkPositiveInteger(long value, String argName) {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:42: warning: no @param for argName
  public static void checkPositiveInteger(long value, String argName) {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:47: warning: no @param for value
  public static void checkNotNegative(long value, String argName) {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:47: warning: no @param for argName
  public static void checkNotNegative(long value, String argName) {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:59: warning: no @param for isValid
  public static void checkValid(boolean isValid, String argName) {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:59: warning: no @param for argName
  public static void checkValid(boolean isValid, String argName) {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:64: warning: no @param for isValid
  public static void checkValid(boolean isValid, String argName, String validValues) {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:64: warning: no @param for argName
  public static void checkValid(boolean isValid, String argName, String validValues) {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:64: warning: no @param for validValues
  public static void checkValid(boolean isValid, String argName, String validValues) {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:69: warning: no @param for arg
  public static void checkNotNullAndNotEmpty(String arg, String argName) {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:69: warning: no @param for argName
  public static void checkNotNullAndNotEmpty(String arg, String argName) {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:75: warning: no @param for <T>
  public static <T> void checkNotNullAndNotEmpty(T[] array, String argName) {
                         ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:75: warning: no @param for array
  public static <T> void checkNotNullAndNotEmpty(T[] array, String argName) {
                         ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:75: warning: no @param for argName
  public static <T> void checkNotNullAndNotEmpty(T[] array, String argName) {
                         ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:81: warning: no @param for array
  public static void checkNotNullAndNotEmpty(byte[] array, String argName) {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:81: warning: no @param for argName
  public static void checkNotNullAndNotEmpty(byte[] array, String argName) {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:87: warning: no @param for array
  public static void checkNotNullAndNotEmpty(short[] array, String argName) {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:87: warning: no @param for argName
  public static void checkNotNullAndNotEmpty(short[] array, String argName) {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:93: warning: no @param for array
  public static void checkNotNullAndNotEmpty(int[] array, String argName) {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:93: warning: no @param for argName
  public static void checkNotNullAndNotEmpty(int[] array, String argName) {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:99: warning: no @param for array
  public static void checkNotNullAndNotEmpty(long[] array, String argName) {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:99: warning: no @param for argName
  public static void checkNotNullAndNotEmpty(long[] array, String argName) {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:105: warning: no @param for <T>
  public static <T> void checkNotNullAndNotEmpty(Iterable<T> iter, String argName) {
                         ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:105: warning: no @param for iter
  public static <T> void checkNotNullAndNotEmpty(Iterable<T> iter, String argName) {
                         ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:105: warning: no @param for argName
  public static <T> void checkNotNullAndNotEmpty(Iterable<T> iter, String argName) {
                         ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:112: warning: no @param for <T>
  public static <T> void checkNotNullAndNumberOfElements(
                         ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:112: warning: no @param for collection
  public static <T> void checkNotNullAndNumberOfElements(
                         ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:112: warning: no @param for numElements
  public static <T> void checkNotNullAndNumberOfElements(
                         ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:112: warning: no @param for argName
  public static <T> void checkNotNullAndNumberOfElements(
                         ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:124: warning: no @param for value1
  public static void checkValuesEqual(
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:124: warning: no @param for value1Name
  public static void checkValuesEqual(
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:124: warning: no @param for value2
  public static void checkValuesEqual(
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:124: warning: no @param for value2Name
  public static void checkValuesEqual(
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:136: warning: no @param for value1
  public static void checkIntegerMultiple(
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:136: warning: no @param for value1Name
  public static void checkIntegerMultiple(
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:136: warning: no @param for value2
  public static void checkIntegerMultiple(
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:136: warning: no @param for value2Name
  public static void checkIntegerMultiple(
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:148: warning: no @param for value1
  public static void checkGreater(long value1, String value1Name, long value2, String value2Name) {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:148: warning: no @param for value1Name
  public static void checkGreater(long value1, String value1Name, long value2, String value2Name) {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:148: warning: no @param for value2
  public static void checkGreater(long value1, String value1Name, long value2, String value2Name) {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:148: warning: no @param for value2Name
  public static void checkGreater(long value1, String value1Name, long value2, String value2Name) {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:159: warning: no @param for value1
  public static void checkGreaterOrEqual(
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:159: warning: no @param for value1Name
  public static void checkGreaterOrEqual(
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:159: warning: no @param for value2
  public static void checkGreaterOrEqual(
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:159: warning: no @param for value2Name
  public static void checkGreaterOrEqual(
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:171: warning: no @param for value1
  public static void checkLessOrEqual(
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:171: warning: no @param for value1Name
  public static void checkLessOrEqual(
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:171: warning: no @param for value2
  public static void checkLessOrEqual(
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:171: warning: no @param for value2Name
  public static void checkLessOrEqual(
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:183: warning: no @param for value
  public static void checkWithinRange(
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:183: warning: no @param for valueName
  public static void checkWithinRange(
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:183: warning: no @param for minValueInclusive
  public static void checkWithinRange(
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:183: warning: no @param for maxValueInclusive
  public static void checkWithinRange(
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:195: warning: no @param for value
  public static void checkWithinRange(
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:195: warning: no @param for valueName
  public static void checkWithinRange(
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:195: warning: no @param for minValueInclusive
  public static void checkWithinRange(
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:195: warning: no @param for maxValueInclusive
  public static void checkWithinRange(
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/TDeserializer.java:85: warning: no @throws for org.apache.thrift.transport.TTransportException
  public TDeserializer(
         ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/TDeserializer.java:109: warning: no @throws for org.apache.thrift.transport.TTransportException
  public TDeserializer(
         ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TEndpointTransport.java:56: warning: no description for @param
   * @param newSize
     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TEndpointTransport.java:58: warning: no @throws for org.apache.thrift.transport.TTransportException
  protected void resetConsumedMessageSize(long newSize) throws TTransportException {
                 ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TEndpointTransport.java:78: warning: no description for @param
   * @param size
     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TEndpointTransport.java:90: warning: no description for @param
   * @param numBytes
     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TEndpointTransport.java:100: warning: no description for @param
   * @param numBytes
     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TEndpointTransport.java:102: warning: no @throws for org.apache.thrift.transport.TTransportException
  protected void countConsumedMessageBytes(long numBytes) throws TTransportException {
                 ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/AutoExpandingBufferWriteTransport.java:42: warning: no @throws for org.apache.thrift.transport.TTransportException
  public AutoExpandingBufferWriteTransport(
         ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TFileTransport.java:572: warning: no @param for args
  public static void main(String[] args) throws Exception {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TFileTransport.java:572: warning: no @throws for java.lang.Exception
  public static void main(String[] args) throws Exception {
                     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TTransportFactory.java:35: warning: no @throws for org.apache.thrift.transport.TTransportException
  public TTransport getTransport(TTransport trans) throws TTransportException {
                    ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java:57: warning: no @throws for org.apache.thrift.transport.TTransportException
  protected TIOStreamTransport() throws TTransportException {
            ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java:76: warning: no @throws for org.apache.thrift.transport.TTransportException
  public TIOStreamTransport(InputStream is) throws TTransportException {
         ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java:122: warning: no @throws for org.apache.thrift.transport.TTransportException
  public TIOStreamTransport(InputStream is, OutputStream os) throws TTransportException {
         ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java:97: warning: no @throws for org.apache.thrift.transport.TTransportException
  public TIOStreamTransport(OutputStream os) throws TTransportException {
         ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java:49: warning: no @param for config
  protected TIOStreamTransport(TConfiguration config) throws TTransportException {
            ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java:49: warning: no @throws for org.apache.thrift.transport.TTransportException
  protected TIOStreamTransport(TConfiguration config) throws TTransportException {
            ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java:64: warning: no description for @param
   * @param config
     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java:67: warning: no @throws for org.apache.thrift.transport.TTransportException
  public TIOStreamTransport(TConfiguration config, InputStream is) throws TTransportException {
         ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java:105: warning: no description for @param
   * @param config
     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java:109: warning: no @throws for org.apache.thrift.transport.TTransportException
  public TIOStreamTransport(TConfiguration config, InputStream is, OutputStream os)
         ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java:84: warning: no description for @param
   * @param config
     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java:87: warning: no @throws for org.apache.thrift.transport.TTransportException
  public TIOStreamTransport(TConfiguration config, OutputStream os) throws TTransportException {
         ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TNonblockingServerSocket.java:56: warning: no @param for port
  public TNonblockingServerSocket(int port) throws TTransportException {
         ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TNonblockingServerSocket.java:56: warning: no @throws for org.apache.thrift.transport.TTransportException
  public TNonblockingServerSocket(int port) throws TTransportException {
         ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TNonblockingServerSocket.java:61: warning: no @param for port
  public TNonblockingServerSocket(int port, int clientTimeout) throws TTransportException {
         ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TNonblockingServerSocket.java:61: warning: no @param for clientTimeout
  public TNonblockingServerSocket(int port, int clientTimeout) throws TTransportException {
         ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TNonblockingServerSocket.java:61: warning: no @throws for org.apache.thrift.transport.TTransportException
  public TNonblockingServerSocket(int port, int clientTimeout) throws TTransportException {
         ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TNonblockingSocket.java:99: warning: no description for @param
   * @param selector
     ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TNonblockingSocket.java:121: warning: no @return
  public SocketChannel getSocketChannel() {
                       ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TNonblockingTransport.java:39: warning: no @return
  public abstract boolean startConnect() throws IOException;
                          ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TNonblockingTransport.java:39: warning: no @throws for java.io.IOException
  public abstract boolean startConnect() throws IOException;
                          ^
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TNonblockingTransport.java:46: warning: no @return
  public abstract boolean finishConnect() throws IOException;
                          ^
100 warnings

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.4.2/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 1m 27s
6 actionable tasks: 6 executed

FYI i think JDK 8 support is still with Gradle 7:
build log

the need for java 8 is possibly due to kotlin's unspecified dependencies, for which i've pinned down in https://github.com/apache/thrift/pull/2602/files#diff-fac297e377f3c9d2ebbc3e82419e0c9d7a6d15e741acdfaf62c4485b8e228b83R37-R42
maybe after merging that i'll try to revert the upgrade of xenial's java 8 => 11 changes (maybe in later PR), or not, since xenial is a bit old.
i'm trying to add focal in:

#2528 or even jammy but maybe not today

confirmed that the build failure in Java 8 was due to kolin:

build log
root@5ec15a799389:/opt/thrift/src/lib/kotlin# ../java/gradlew assemble

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'libthrift-kotlin'.
> Could not determine the dependencies of null.
   > Could not resolve all task dependencies for configuration ':classpath'.
      > Could not resolve com.ncorti.ktfmt.gradle:plugin:0.8.0.
        Required by:
            project : > com.ncorti.ktfmt.gradle:com.ncorti.ktfmt.gradle.gradle.plugin:0.8.0
         > No matching variant of com.ncorti.ktfmt.gradle:plugin:0.8.0 was found. The consumer was configured to find a runtime of a library compatible with Java 8, packaged as a jar, and its dependencies declared externally, as well as attribute 'org.gradle.plugin.api-version' with value '7.4.2' but:
             - Variant 'apiElements' capability com.ncorti.ktfmt.gradle:plugin:0.8.0 declares a library, packaged as a jar, and its dependencies declared externally:
                 - Incompatible because this component declares an API of a component compatible with Java 11 and the consumer needed a runtime of a component compatible with Java 8
                 - Other compatible attribute:
                     - Doesn't say anything about org.gradle.plugin.api-version (required '7.4.2')
             - Variant 'runtimeElements' capability com.ncorti.ktfmt.gradle:plugin:0.8.0 declares a runtime of a library, packaged as a jar, and its dependencies declared externally:
                 - Incompatible because this component declares a component compatible with Java 11 and the consumer needed a component compatible with Java 8
                 - Other compatible attribute:
                     - Doesn't say anything about org.gradle.plugin.api-version (required '7.4.2')

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.4.2/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 37s

@Jimexist I fixed the merge conflicts, and also bumped the spotless version, and formatted the kotlin and java files using Gradle 7.4.2. I'll let CI finish its checks, but I did notice that:

there are some deprecated stuff in use here that will be removed in Gradle 8 (which is not out yet, but will be nice to be prepared for) -- could be fixed as part of this PR,
some Gradle plugins use banned APIs that are removed/hidden in Java 17 (this might require waiting on upstream plugin developers, or disabling some plugins if Java 17 is used) -- could be a follow-on PR, and
there's a lot of warnings spamming the console for both lib/java and lib/kotlin -- could be a follow-on PR.

As a side note: I'm really happy to be helping review your changes. I'm learning a lot from the exercise, and I'm impressed with the quality and pace of your contributions. I've been feeling guilty about being added as a committer, but not really having much time to contribute. But, all your work has kept me interested, and contributing to the project, even if it's limited to the Java and CI changes. So, thanks for contributing so that I can contribute. :smiley_cat:

confirmed that the build failure in Java 8 was due to kolin's ktfmt which depends on gradle api that's Java 11+ only:

Maybe using that plugin can be wrapped around a conditional? If so, then could go ahead and revert the Xenial changes here.
it'd be nice to make the choice to require JDK 11 a conscious decision for later, rather than as a side-effect of the Gradle update now.

confirmed that the build failure in Java 8 was due to kolin's ktfmt which depends on gradle api that's Java 11+ only:

Maybe using that plugin can be wrapped around a conditional? If so, then could go ahead and revert the Xenial changes here. it'd be nice to make the choice to require JDK 11 a conscious decision for later, rather than as a side-effect of the Gradle update now.

yes let me try to put a if guard around ktfmt and revert the changes of upgrading java to xenial docker image

@Jimexist I fixed the merge conflicts, and also bumped the spotless version, and formatted the kotlin and java files using Gradle 7.4.2. I'll let CI finish its checks, but I did notice that:

there are some deprecated stuff in use here that will be removed in Gradle 8 (which is not out yet, but will be nice to be prepared for) -- could be fixed as part of this PR,
some Gradle plugins use banned APIs that are removed/hidden in Java 17 (this might require waiting on upstream plugin developers, or disabling some plugins if Java 17 is used) -- could be a follow-on PR, and
there's a lot of warnings spamming the console for both lib/java and lib/kotlin -- could be a follow-on PR.

As a side note: I'm really happy to be helping review your changes. I'm learning a lot from the exercise, and I'm impressed with the quality and pace of your contributions. I've been feeling guilty about being added as a committer, but not really having much time to contribute. But, all your work has kept me interested, and contributing to the project, even if it's limited to the Java and CI changes. So, thanks for contributing so that I can contribute. 😺

thanks for reviewing my pull request and helping with formatting!

i've fixed the deprecations
i guess we can wait a bit for gradle 7.5 to be out for which they will possibly fix them
i think you meant javadoc warnings?

thanks for the kind words as well and i'm also learning a lot along the way. i think there's no shame and pressure on being a committer and the amount of actual contributions you make, as long as it's net positive then it's all good, also i totally agree that reviewing code and commenting is also very good part of contributions. also a side note - i don't even know how to become a committer (there's no documented process yet) but that won't stop me from committing code either way.

i don't even know how to become a committer (there's no documented process yet) but that won't stop me from committing code either way.

At the ASF, each project's PMC nominates and votes on new committers (and new PMC members) in secret on their private mailing lists. Each project is different, and each PMC member might be different in their criteria for nominating somebody. I'm not a PMC member for this project, so I don't know how it typically happens here. Personally, I think you're probably doing all the right things to warrant consideration, but it's up to the PMC.

3. i think you meant javadoc warnings?

Mostly, yes. Most of the javadoc warnings can probably be taken care of with -Xdoclint:all,-missing (it's not really a problem if an unimportant method is missing a javadoc, but if one exists, then all checks should be enabled).
I thought I saw a few warnings on the kotlin side, but I don't remember what they were.
In any case, these don't have to be part of this PR.

It looks like the conditional configuration isn't working. When the plugin isn't applied, then the type safe ktfmt configuration block that calls kotlinLangStyle() fails with a compilation error. I can't figure out how to conditionally apply the configuration... I don't think any type-safe way will work, and I don't understand the non-type-safe ways discussed in the docs.

It looks like the conditional configuration isn't working. When the plugin isn't applied, then the type safe ktfmt configuration block that calls kotlinLangStyle() fails with a compilation error. I can't figure out how to conditionally apply the configuration... I don't think any type-safe way will work, and I don't understand the non-type-safe ways discussed in the docs.

for now i'm just configuring the plugin in both versions but only conditionally apply it with Java 11+ so there's no conflict. hopefully this can solve the issue.

Another Travis thing is failing. This time, it's because it couldn't download something from NuGet, unrelated to these changes. I look forward to more things being done in GH Actions. It will be much easier to re-run only the failed CI tasks that way, and in only a few minutes, instead of having it queued for hours and hours. All the relevant CI checks related to these checks seem to be passing just fine, though.
So, I think this is ready to merge.
@Jens-G since you made a comment earlier, did you want to take another look, or express any comments or objections before this is merged?

It will be much easier to re-run only the failed CI tasks that way, and in only a few minutes, instead of having it queued for hours and hours. All the relevant CI checks related to these checks seem to be passing just fine, though.

for anyone interested in reviewing GitHub action related pull requests:

#2595
#2594
#2596

did you want to take another look, or express any comments or objections before this is merged?

one thing i didn't test myself, or on CI, is actual publishing, because my lack of access. but i've tested publishing locally and the content seems fine:

.jar
-sources.jar
-javadoc.jar
pom file
without the shadow jar

#2601

hi @mitumaruto i'm not sure i understand your comment nor suggested changes, can you elaborate?


Call endpoint to mark upload status as completed

@techncl @MancunianSam Could we maybe have a quick call today to tidy up the git history for this branch? There are WIP commits, commits with duplicate names, and some of Rooha's commits that have already been merged, so I'm not sure what's going on.
I'm happy to do to the git wrangling if you tell me what the changes should be!

@techncl @MancunianSam Could we maybe have a quick call today to tidy up the git history for this branch? There are WIP commits, commits with duplicate names, and some of Rooha's commits that have already been merged, so I'm not sure what's going on.
I'm happy to do to the git wrangling if you tell me what the changes should be!

Sure. It's weird, I rebased the "WIP" commit and then this happened.


Creation of devices

Hello Stas,
yesterday i updated domoticz to the latest beta 4.11337. Immediately afterwards I tried to connect a new Xiaomi motion detector . In Devices I see only one (Zigbee2MQTT - 0x00158d0004141b55 (Link Quality) )device and nothing more. It actually 4 devices must be created. The following errors occur in Log. What could that be? thanks
Log:
2019-09-28 17:20:53.631 Error: Device creation failed, Device object is not associated with a plugin.
2019-09-28 17:20:55.650 Error: Expected: myVar = Domoticz.Device(Name="myDevice", Unit=0, TypeName="", Type=0, Subtype=0, Switchtype=0, Image=0, Options={}, Used=1)
2019-09-28 17:20:55.650 Error: (Zigbee2MQTT) 'CDevice_init' failed 'TypeError':'an integer is required (got type NoneType)'.
2019-09-28 17:20:55.650 Error: Device creation failed, Device object is not associated with a plugin.
2019-09-28 17:20:55.651 Error: Expected: myVar = Domoticz.Device(Name="myDevice", Unit=0, TypeName="", Type=0, Subtype=0, Switchtype=0, Image=0, Options={}, Used=1)
2019-09-28 17:20:55.651 Error: (Zigbee2MQTT) 'CDevice_init' failed 'TypeError':'an integer is required (got type NoneType)'.
2019-09-28 17:20:55.651 Error: Device creation failed, Device object is not associated with a plugin.
2019-09-28 17:20:55.651 Error: Expected: myVar = Domoticz.Device(Name="myDevice", Unit=0, TypeName="", Type=0, Subtype=0, Switchtype=0, Image=0, Options={}, Used=1)
2019-09-28 17:20:55.651 Error: (Zigbee2MQTT) 'CDevice_init' failed 'TypeError':'an integer is required (got type NoneType)'.

Thanks for the help Stas.  For all others.  The error was that Domoticz only supports 255 devices in the Plagin system.


Decide what to do about automatic translation of text to latex

Split from #88
Currently, when using the latex printer, code like the following gets promoted to LaTeX, via the _texify function, and some post-processing in printer.tex looking for the LHS of equals signs:
print('grad | a =', grad | a)
print((grad | a).Fmt(title='grad | a ='))

Right now, this post-processing does not apply to Jupyter notebooks.
In his branch, @abrombo removed support for this. From slack:

Eric Wieser Yesterday at 11:57 AM
@Brombo, was it your intent to remove the texification support from the printer? (edited)
9 replies
Eric Wieser  1 day ago
Namely, the current behavior of translating a | grad ^ grad * b to a \cdot \boldsymbol{\nabla} \W \boldsymbol{\nabla} b (edited)
Eric Wieser  1 day ago
I ask because all of your attempts at a "new printer" appear to remove it, and I wanted to check this was a deliberate decision
Brombo  23 hours ago
I think you are referring to my removing the using of special symbols for standard latex macros that is ^ instead of \wedge etc.  Since we can have a set of latex macros I would rather have all annotation in pure latex and define latex macros to make annotation easier rather than having a special post processor for the 'latex' annotations so that the user would use \W instead of ^ to represent \wedge and all the other special symbols that I had defined for latex annotations.  Let latex do all the processing and simplify the code.
Eric Wieser  23 hours ago
I think we're talking about the same thing, yes.
The advantage of the old style is that you get nice plaintext output too, when print("grad | a = ", g) really is just a regular print statement (edited)
Brombo  23 hours ago
I forgot about plain text since I am so enamored of latex.  Which symbols if any in plain text would have to be escaped to print correctly?  I forget.  Is the point to have the plain tex annotation look as much like the latex annotation as possible?  They would only be the same for very simple annotations.
Brombo  22 hours ago
I though my post processing code for the annotations was really ugly and I don't know how robust it was.  Could you suggest a better way.  Do you know how the use the regular expression parser (are you a grepmeister) to accomplish what my ugly code did in both plain text and latex. (edited)
Eric Wieser  21 hours ago

Is the point to have the plain tex annotation look as much like the latex annotation as possible?

The point is to have one piece of code produce either LaTeX or plaintext output, without having to change anything
Eric Wieser  21 hours ago

I though my post processing code for the annotations was really ugly and I don't know how robust it was.  Could you suggest a better way?

Yes, i rewrote that a few days ago. Have a look at the _texify function in master. It's still a little fragile, but I fixed the obvious robustness issues (edited)
Eric Wieser  21 hours ago
The source for _texify is here: https://github.com/pygae/galgebra/blob/master/galgebra/printer.py#L772-L794

We should either:

Commit to removing it entirely
Add support to it in jupyter too, by adding a class like:

class MaybeTex:
    def __init__(self, value):
        self.value = value
    def _latex(self, printer):
        return _texify(self.value)
    def __str__(self):
        return self.value

The point is to have one piece of code produce either LaTeX or plaintext output, without having to change anything

Yes, I strongly agree that this is the core reason for us to keep this functionality. I'm OK with the MaybeTex idea.


Wallet Encription

Describe the issue
Encrypted the wallet using only a password, left the phrase empty.
When I try to decrypt the wallet it asks for the phrase, but i didn't define it, the Ok button is deactivated and only turns on if you insert words in the phrase. Tried to insert the password in the phrase, I get incorrect.
Expected behaviour
There should be to 2 inputs in the decrypt form, phrase and password. Like there was in the form to encrypt
Actual behaviour
My wallet is blocked
What version of Raptoreum Core are you using?
Raptoreum Core versão v<IP_ADDRESS>-g473165aab (64-bit)
Machine specs:

OS: Windows
CPU:
RAM:
Disk size:
Disk Type (HD/SDD):

Unless you have launched the wallet specifically in HD mode, there is only a single encryption password.
Encrypting in regular wallet mode requires the same password to be entered twice or it will not encrypt the wallet.

You may have backup wallets saved on your PC as it saves previous wallets you've used to open the program. I was able to go back to an earlier unencrypted wallet when I had an issue.


EKS Anywhere cluster registration on AWS portal

What happened:   After adding cluster to portal the error displays:  Error loading Namespaces
users "arn:aws:iam::496586270756:user/aws__admin" is forbidden: User "system:serviceaccount:eks-connector:eks-connector" cannot impersonate resource "users" in API group "" at the cluster scope.
what does it mean? Should I customize additional user and where?

EKS Connector is not an EKS Anywhere specific feature. It is know to work with EKS Anywhere but please see the support page for EKS Connector or contact support for assistance.


No coverage

I was using mocha + istanbul!! Everything was fine, but I tried to switch to AVA because @sindresorhus is awesome!
I took a look in the GOT
But my coverage still returns empty! :sob:

You have to use nyc as AVA spawns the test files.

a code coverage tool built on istanbul that works for applications that spawn subprocesses. - nyc

I've been meaning to document this, but I wanted to ensure it works correctly with nyc before doing so.

Oh, I just noticed you are using nyc. Do note that got is using master: https://github.com/sindresorhus/got/blob/f4cf6c7b44d047d505ed1fdf3a4e361b743bdfc2/package.json#L64 Try that.
We plan on doing another release in a few days.

I've tried that before open this issue, but ran using ES6 code. :bug:
And now, I run with transpiled files and works almost fine!! :smile:
The coverage file is created apparently right in output folder, but the report appears empty when I run the test. Like the image above in the first post.
Well, I will waiting the new release.
Thanks for reply!

Keeping this open so I don't forget to document it after the new release.

Fine!
Just a small feedback! In Travis, the report output worked!

I seem to be still having the issue... im currently using<EMAIL_ADDRESS>with nyc and my coverage is blank...
Is the<EMAIL_ADDRESS>you the release that was suppose to happen? i also tried with ava from the gihub master branch and same results

@davidchase Can you share something I can test?

It seems like it was an issue how my nyc config was setup sorry about the previous comment... @sindresorhus do you know how fine tuned we can instrument excludes in nyc?
the setup below seems to include a lot more files than i need covered... maybe this is a better question for the nyc repo sorry to bug
"config": {
    "nyc": {
      "exclude": [
        "node_modules/utils"
      ]
    }
  }

@davidchase nyc supports the Istanbul config. Like: https://github.com/vesln/todo/blob/master/.istanbul.yml (I couldn't find the actual docs for that).

hmm it seems like that .istanbul.yml does not work for me as i get no coverage and using the above json config i get too much :disappointed: cant find that happy medium...

@davidchase Open an issue on nyc. I'm sure they'll happy to receive feedback on what needs improving ;)

"node_modules/utils"

Why are you excluding just node_modules/utils? Usually you exclude all of node_modules.

@Qix- so i have some files that live the node_modules/utils folder and i understood from excluding-files setting up just the following config:
"config": {
    "nyc": {
      "exclude": [
        "node_modules"
      ]
    }
  }

results in empty coverage ...
however specifying the exact folder node_modules/utils produces too many results... seemingly pull from other npm packages that live in node_modules

Then yes, this is a bug within nyc.


Update sbt-header to 5.2.0

Updates de.heikoseeberger:sbt-header from 5.1.0 to 5.2.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a nice day!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [{ groupId = "de.heikoseeberger", artifactId = "sbt-header" }]

Codecov Report

Merging #137 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #137   +/-   ##
=======================================
  Coverage   91.49%   91.49%
=======================================
  Files          67       67
  Lines        1140     1140
  Branches       44       44
=======================================
  Hits         1043     1043
  Misses         97       97

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f08270...b06ea81. Read the comment docs.


Properly indent pub fns in extern blocks

Closes https://github.com/nrc/rustfmt/issues/466.
I cannot reproduce the issue with inline modules..

Wait, this needs a test.

Thanks!


Add --rerun-fails to gotestsum

What does this PR do?

Add --rerun-fails flag
Bump to latest stable version

Motivation

Reduce flakiness of Go unit tests

Additional Notes

Docs say you need to use the --packages flag when using --rerun-fails.

Describe your test plan

Pipeline passes and runs the same tests as before

Should we explicitly set the number of reruns with --rerun-fails=n in the command, to not rely on the default value (which may change over time)?

Makes sense to do it explicitly. I am also wondering if we should do this everywhere or just on the CI or even just on master/deploy branches. We don't want to encourage people writing more flaky tests. What do you think?

Out of curiosity, do the test logs show when a job is retried?

Yes, see e.g. https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/61629845/raw for pkg/util/cloudfroundry. Initially it failed but after re-running it passed. It's a bit confusing because the initial failures are shown after re-running.


On: http://demo.almighty.io/ - cannot add a link to a workitem

See screencast:
https://dl.dropboxusercontent.com/u/12067552/Screencasts/Screencast from 12-02-2016 05%3A39%3A18 PM.webm

@ldimaggi please do not assign people to issues to do that work. The person should assign themselves when they are ready to do it. This allows anyone to take on a task that is not yet assigned. If you want someone to know about this issue you can reference them in the comments.
I think this specific bug has to do with trying to link 2 things that are not allowed to be linked using the "blocks" link. We do not yet have anything that limits the list to only what is able to be used. The search returns all the items even if you can't use them.

Hey Josh,
+1 - I'll not assign bugs in the future.
I actually was not able to link those workitems using any type of link - so
there may be some additional issues lurking here...   ;-)
-- Len
On Mon, Dec 5, 2016 at 12:29 AM, Joshua Wilson<EMAIL_ADDRESS>wrote:

@ldimaggi https://github.com/ldimaggi please do not assign people to
issues to do that work. The person should assign themselves when they are
ready to do it. This allows anyone to take on a task that is not yet
assigned. If you want someone to know about this issue you can reference
them in the comments.
I think this specific bug has to do with trying to link 2 things that are
not allowed to be linked using the "blocks" link. We do not yet have
anything that limits the list to only what is able to be used. The search
returns all the items even if you can't use them.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/almighty/almighty-ui/issues/417#issuecomment-264771204,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAnOPcUwDHuzE5i0e6AXTSZZoxWjszspks5rE6FOgaJpZM4LDEVd
.

--
Len DiMaggio<EMAIL_ADDRESS>JBoss by Red Hat
314 Littleton Road
Westford, MA 01886  USA
tel:<PHONE_NUMBER>
cell:<PHONE_NUMBER>
http://www.redhat.com
http://community.jboss.org/people/ldimaggio

Closing this as a duplicate of:
https://github.com/almighty/almighty-ui/issues/431


When subscribing to Oracles, logs for invalid oracle populate the terminal with out an option to ignore them

Looks like this:
Invalid Spot 0 Oracle: Confidence Too Large (is_conf_too_large=1175)
Invalid Spot 0 Oracle: Stale (oracle_delay=22)
Invalid Spot 1 Oracle: Confidence Too Large (is_conf_too_large=1038)
Invalid Spot 6 Oracle: Confidence Too Large (is_conf_too_large=3062)
Invalid Spot 6 Oracle: Stale (oracle_delay=22)

yeah this is side affect of running the program code.
will see if we can compile it away for sdk use


CellMeasurer does not create dynamic column widths for Grid

Expected
I want to have a Grid with dynamic widths, like this example: https://bvaughn.github.io/react-virtualized/#/components/CellMeasurer
Bug
I looked at the example and tried to implement it, but it does not work.  I don't understand what is wrong.
cache.columnWidth did not work when I just passed it to the prop columnWidth={cache.columnWidth}, it only started to work when I made a custom function that returns cache.columnWidth(index), and it always returns the defaultWidth I declared in the cache. Nothing about it is dynamic.
I also tried to have useRef and without useRef to create the cache, both have the same result.
This is the demo
https://codesandbox.io/s/dynamic-width-table-with-grid-instead-95mrg?file=/src/App.js
Which versions of React and react-virtualized, and which browser / OS are affected by this issue? Did this work in previous versions of react-virtualized?

Browser
Chrome

OS
Windows 10

React
17.0.2

React DOM
17.0.2

react-virtualized
9.22.3

It now works, and I cannot tell you why, so I am closing this issue, but with no real solution to the problem I was facing.


Kernel flow graph is built out of order

The initial DebugStepCheckInstr and the sequence for the saving the current async stack trace are built after the function body and then appended to the beginning of the entry block. They manually save and restore the context level to account for this. The sequences should instead be built when needed and appended to the end of the entry block and not mess with the context level.
Also, the entry sequences vary between the VM flow graph builder and the kernel flow graph builder.
VM:
DebugStepCheckInstr
save async stacktrace
CheckStackOverflowInstr
build context
Kernel:
build context
save async stacktrace
DebugStepCheckInstr
CheckStackOverflowInstr

@kmillikin @mraleph

I need more context for this issue.
We shouldn't consider it a bug that the graph is built out of order, where we take the behavior of the classic builder as the definition of what it means to be built in order.
The order in which instructions are created seems like an implementation detail so long as they are correct and occur in the correct order in the graph.
The classic flow graph builder and the Kernel flow graph builder put instructions together in a different way and use the state of the visitor in a different way, so it's natural that they might sometimes be different.  The only advantage of sticking to the "classic" order is that it makes it easy to compare the two implementations side-by-side, but that seems minor.
There does seem to be an issue with the way we call _asyncStackTraceHelper in the Kernel flow graph, I'll file a separate issue to track that.
For the second point, I observe a different order than you do.    That is, the first two are switched:
B0[graph]:2
B1[target]:0
    DebugStepCheck()

    t0 <- LoadLocal(:current_context_var @-7)
    t0 <- LoadField(t0, 24, immutable=0)
    PushArgument(t0)
    StaticCall:56( _setAsyncThreadStackTrace@7048458 t0)

    t0 <- LoadLocal(:current_context_var @-7)
    t0 <- LoadField(t0, 64, immutable=0)
    StoreLocal(:switch_expr @-8, t0)
    t0 <- LoadLocal(:switch_expr @-8)
    t1 <- Constant(#0)
    Branch if StrictCompare:48(===, t0, t1) goto (7, 8)

B7[target]:52
    CheckStackOverflow:4()
    t0 <- LoadLocal(:current_context_var @-7)
    t1 <- LoadLocal(:current_context_var @-7)
    t2 <- LoadLocal(:temp0 @-13)
    StoreInstanceField({80}, t1, t2)
    DropTemps(1)
    goto:8 B2

B2[join try_idx 0]:6 pred(B7)
    t0 <- AllocateContext(2)
    t1 <- LoadLocal(:temp0 @-13)
    t2 <- LoadLocal(:current_context_var @-7)
    StoreInstanceField({16}, t1, t2)
    StoreLocal(:current_context_var @-7, t0)

Is it observable (and correct) to have _setAsyncThreadStackTrace before DebugStepCheck?  Can we commit a test case that requires the correct order?

Filed https://github.com/dart-lang/sdk/issues/29771 to track the issue with _asyncStackTraceHelper.

I'm more concerned about the context level getting out of sync if the flow graph builder doesn't build fragments in order, since this can sometimes affect only the debugger and not normal program execution.
The ordering of _setAsyncThreadStackTrace and DebugStepCheck/StackOverflowCheck should be observable in the stack trace you get evaluating an expression in the debugger. I don't think one can step to this particular DebugStepCheck because the debugger would normally try to skip through the switch, though it might be possible to stay stopped there if it is reached as a breakpoint instead of via stepping.

Assumed stale.

This is being addressed in https://dart-review.googlesource.com/c/sdk/+/67345, as part of breaking up untangling the spaghetti-code that has piled up in BuildGraphOfFunction.


Fix for #17942

Fix for #17942.
Don't use cache if it's DbSchema to avoid loop.

Q
A

Is bugfix?
✔

Breaks BC?
❌

Tests pass?
✔

Fixed issues
#17942

Thank you!

Fix for #17942.
Don't use cache if it's DbSchema to avoid loop.
Q	A
Is bugfix?
Breaks BC?
Tests pass?
Fixed issues	#17942

Does this fix mean to never set enableSchemaCache to true?

To avoid a loop this fix just means this function QueryBuilder::supportsFractionalSeconds() can't use the cache if it's an instance of DbCache.
It doesn't affect anything else.


Enqueued Entries count

[ ] Entries Enqueued count will remain at 1, even though the job completed (and sidekiq has no enqueued jobs remaining) Sample data created 2 works and 1 collection, 1 work in 1 collection.

Screenshot

When I try a larger sample (2 collections, 4 works, 1 work in one collection, 3 in the other), the status remains as "pending" and entries enqueued remains at 2, even though the job completed.

@ShanaLMoore is this resolved? Can it be closed?

@ShanaLMoore is this resolved? Can it be closed?

part of this issue appears to have been resolved. When the job is complete, the count is showing 0 now correctly.
Pending status still looks incorrect. These jobs aren't actually running or enqueued.

Screenshot updated after re running importers to capture a more up to date status. I believe this is still an issue.

Retracting my previous statement as the example I pulled was v4.3.0 PALS staging which is going through a hyku upgrade. I think a better example would be to reference PALS' production. Doing more testing. I'll report back soon.


Change _rez_fwd to _rez-fwd as the entry point was renamed in 2.38.0

Fixes #671
As the code prior to 2.38.0 already had a TODO to rename the executable i assume it was done on purpose. This fixes the reference in util.py to match the new name.

Ah crap actually I think we need to revert the bin name instead.. the change in 2.38.0 wasn't intentional. Changing the name of _rez_fwd will break existing suites when they upgrade rez :/
Closing in lieu of my own PR to revert this regression.


Seeking help from a native English speaker

I think the documentation and demo app text content would benefit from a native English speaker going over it and fix things. :-)

I'll be happy to contribute when I have a better understanding of the package.

Not sure how much help I can be on English syntax, human languages baffle me, but class methods docs could be cleaned up:
#from
componentChildren: ([nameOrComponent]) ->
#to
@componentChildren([nameOrComponent])

The current docs took me a minute to realize it was a function that exists and I could call, and I use coffee daily. At first I though it was some strange injection/mixin magic.

OK, this should really go into a separate ticket. But OK. :-)
Please propose the whole syntax. Because you have both the class methods and instance methods. Currently class methods have the @ prefix. Instance do not.
But isn't the above the CoffeeScript syntax for methods?

I would help but I am still digesting this package.

No problem. :-) This is why they are tickets. So that we have a list of things that has to be done. :-)
Also, at this stage it is useful to learn what things are not yet explained good enough.

If it's just grammatical, spelling and sense-checking of the docs that you want, I'd be more than happy to go over it?

Any help would be welcome. :-)


Does brave has HBASE instrument?

I want to trace habse requests to zipkin.
Does brave has HBASE instrument already?

not here. if it were it would be in the instrumentation directory. possibly
somewhere else has it. you can try github search for hbase tracing maybe?

ok


How to handle Laravel   Routing for web and API

In Laravel 5.4 and 5.5, routes are defined in routes folder (web.php,api.php etc). When we use this package it only generates routes.php which is like web.php. How we can separate web routes and API routes per module and how we can use Eloquent API resources per module

Hello,
The default routes file is just an example. You can call the command module:route-provider that will generate a service provider to more easily load more route files.
Of course this is optional and you may choose to load your routes files as you want.

I tried to run the above-mentioned command got following error
php artisan module:route-provider admin
[Symfony\Component\Debug\Exception\FatalThrowableError]
Class 'Modules\Admin\Providers\AdminServiceProvider' not found
AdminServiceProvider is there so can you guide me with an example if possible
                                                              4

9m

That means you didn't autoload your modules probably. Look that up in the docs.

Thanks a lot for support. I am able to create different route files for web and API for each module.


Update remote depedency hdrhistogram

This PR updates the remote repo of hdrhistogram from https://github.com/filipecosta90/hdrhistogram to the now official https://github.com/HdrHistogram/hdrhistogram-go/ repo.
The PercentilesPrint usage has been adjusted accordingly.

Codecov Report

Merging #136 into master will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   69.73%   69.62%   -0.12%
==========================================
  Files         110      110
  Lines        5984     5158     -826
==========================================
- Hits         4173     3591     -582
+ Misses       1722     1479     -243
+ Partials       89       88       -1

Impacted Files
Coverage Δ

query/stat_processor.go
10.22% <0.00%> (-5.91%)
:arrow_down:

query/stats.go
100.00% <ø> (ø)

internal/inputs/utils.go
72.22% <0.00%> (-6.04%)
:arrow_down:

cmd/tsbs_load_victoriametrics/processor.go
68.42% <0.00%> (-5.50%)
:arrow_down:

cmd/tsbs_load_victoriametrics/scan.go
70.00% <0.00%> (-5.00%)
:arrow_down:

cmd/tsbs_generate_data/serialize/MongoTag.go
63.15% <0.00%> (-4.70%)
:arrow_down:

cmd/tsbs_load_siridb/scan.go
22.00% <0.00%> (-3.87%)
:arrow_down:

...d/tsbs_generate_queries/databases/siridb/common.go
83.33% <0.00%> (-3.34%)
:arrow_down:

...s_generate_queries/databases/timescaledb/common.go
80.00% <0.00%> (-3.34%)
:arrow_down:

... and 101 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7508b34...1560e53. Read the comment docs.

@RobAtticus can you check this one? The used dependency has now a proper remote org and we should move it

Looks good!
Just fix the conflicts with master and we can merge

thank you @blagojts , just resolved the conflicts. can you please revise?


For v1.0.29. Use ImGui Push/PopID to allow more icons to be combined and just flip using UVs (eg Next/Prev icons).

This was a completed task from the board view. Closing as complete.


Wrapping Swiper in a Flexbox displays all slides, ignoring slidesPerView

Hi there,
Great job with react-id-swiper! 👍
Let me start by saying that this might be a Swiper issue, rather than a react-id-swiper issue, but I'm not sure, as I've only tested with react-id-swiper.
In brief, I've created a component as shown below.
This all works really nice, as can be seen here (second section, where it says, "False Positives").
My issue is that I want to center the entire conents of the component in the background container, and set that container's height to the full height of the viewport.
At present, I've got it sitting in a regular div set to full height.
Like I've done with the rest of the site, I wrap components in a Flexbox container with the height set to 100vh and set the Flexbox to align-items: center (or justify-content: center if I'm working with a Flexbox column).
The problem is that when I wrap the Swiper component in a Flexbox (row or column doesn't matter), all slides are displayed, rather than what is set in the slidesPerView parameter.
I've tried nesting the Swiper Container deeper within another div, but that didn't any effect.
The repo is here, if you wanna take a look.
I could center things with other, more conventional methods; however, I am curious to understand why wrapping things in a Flexbox messes stuff up.
Any thoughts you might have or suggestions of things to try would be much appreciated.
Swiper Component
import React from "react";
import styled from "react-emotion";
import Anchor from "../components/anchor_button";
import Scrollchor from "../utils/scrollchor-item";
import Swiper from "react-id-swiper";
import Title from "../components/title";
import "swiper/dist/css/swiper.css";
import "typeface-sanchez";

const Container = styled.div`
  color: white;
  font-family: "Sanchez", serif;
  text-align: center;
  text-shadow: 2px 2px black;
  padding: 3rem 1rem;
`;

const SwiperContainer = styled.div`
  background-color: rgba(0, 0, 0, 0.5);
  border-radius: 0.75rem;
  margin: 1rem 0rem 2rem 0rem;
  @media (min-width: 576px) {
    margin: 2rem 2rem 3rem 2rem;
    padding: 0rem 2rem;
  }
`;
class Reviews extends React.Component {
  render() {
    const params = {
      loop: true,
      slidesPerView: 3,
      spaceBetween: 30,
      speed: 600,
      pagination: { el: ".swiper-pagination", clickable: true },
      breakpoints: {
        1024: {
          slidesPerView: 3,
          spaceBetween: 30,
        },
        768: {
          slidesPerView: 2,
        },
        576: {
          slidesPerView: 1,
        },
      },
    };
    return (

        <Container>
          <Title fontSize={[5, 6, 6, 7]} my={[0, 3]}>
            False Positives
          </Title>

            A Washington D.C. based techno-thriller with action taking place in
            Bangkok, Teheran, and Saigon.

          <SwiperContainer>
            <Swiper {...params}>

                  "A well-paced and imaginative page turner that will appeal not
                  only to techno-junkies but to anyone who likes a well-spun
                  yarn... Try it, you'll have fun."

— The Kindle Book Review

                  "From the sweltering streets of Thailand to the corridors of
                  power in the U.S., the action builds to a frantic climax that
                  leaves the reader gasping."

— Russell Blake Author of THE GERONIMO BREACH

                  "I can't say enough good things about this book. Once I
                  started reading it, I literally couldn't put it down."

— GoodReads Review

                  "Kim Aleksander's "False Positives was a page turner. I found
                  it absolutely captivating..."

— The TBR Pile

                  "Kim Alexander has created some memorable characters and
                  pretty much thrown the book at them. The story races along to
                  a thrilling and satisfying climax."

— Amazon Reviewer

                  "Well thought out plot line and interesting characters. Highly
                  recommended. Waiting for the next one."

                  — Amazon Reviewer

            </Swiper>
          </SwiperContainer>
          <Anchor fontSize={[2, 2, 3]} mt={[1, 3]} px={[3, 3]} py={[2, 3]}>
            <Scrollchor to="#get-fp" animate={{ offset: 1, duration: 500 }}>
              get it now
            </Scrollchor>
          </Anchor>
        </Container>

    );
  }
}
export default Reviews;

I wound up resolving this, after a bunch of trial and error.
In brief, I isolated the SwiperContainer component by wrapping it in it's own div, thus nesting it far enough down so that it it's innards were not affected by the Flexbox two levels up.


Modal blur has glitches on firefox

I noticed that when I set {blurring: true} on a modal, one panel below the modal moved about 100px on the top. I had to refresh, to put it back where it was.I tested it in firefox v47.It works well in chrome though.
After setting {blurring:false} everything works fine on all browsers.
If you want any more info (images etc) I cann provide it.Thanks!

Blurring uses filter which is GPU dependent, which unfortunately varies based by browser and can sometimes have rendering issues.
I'd recommend avoiding blur unless you are comfortable with the risks in rendering incorrectly. You might also experiment with using will-change: transform; to narrow down the rendering context.


AST nodes' repr unhelpful during debugging

A lot of the AST nodes have unhelpful __repr__ implementations. __str__ is meant to be human readable while __repr__ is meant to be unambiguous, and preferably include the class information. (see docs). I did not dare fix these on the fly because I was afraid it might cause fallout, hence this ticket.
The list below is a non-exhaustive list of AST nodes with unhelpful representations:

Literal
ExecutionUnit
AttributeReference
BinaryOperator and everything below it
If

Added discussion label because there were some concerns regarding how this would affect functionality.

Be very careful when making changes to repr! See https://github.com/inmanta/inmanta-core/issues/6526#issuecomment-1725424739


ADD visible_to_students field in Course.jsx, FIX tooltip feature for assignments that are visible to students

A visible_to_students variable was added to Course.jsx to ensure that the visibility shows up correctly under an AssignmentItem component. A tooltip was added for visible assignments under AssignmentItem.jsx

Looks good, could you just attach a screenshot to your description with it working so we can see?


Compact: thanos 0.1.0 compact only PUT got 403

Thanos, Prometheus and Golang version used

thanos: 0.1.0
prometheus: 2.4.3
go: 1.10

What happened
We have deployed the v0.1.0 on production environment.
The compact instance with the error log:
level=error ts=2018-12-14T10:14:32.502344017Z caller=compact.go:212 msg="retriable error" err="compaction failed: compaction: upload of 01CYP3B47YFVX7K8A4Y2DTGRJ2 failed: upload chunks: upload file /var/thanos/store/compact/0@{prometheus=\"thanos/po-prometheus-operator-prometheus\",prometheus_replica=\"prometheus-po-prometheus-operator-prometheus-0\"}/01CYP1T9QT8G7T9B6DXN6NBR7Y/chunks/000001 as 01CYP1T9QT8G7T9B6DXN6NBR7Y/chunks/000001: upload s3 object: The request signature we calculated does not match the signature you provided. Check your key and signing method."

 How can I make sure the compcat is working?
I am reading the source codes, any clues? Thank you!
the project thanos helps a lot!
How to reproduce it (as minimally and precisely as possible):
Full logs to relevant components

Anything else we need to know

This looks like a configuration issue. Have you tried different signature options?
Also I would suggest moving to config file and Thanos v0.2.0 for better support.
Also communication with minio might help here, in terms of minio <-> ceph integration.

I have tried different signature, same error.
Can I upgrade the compactor to v0.2.0 only(store/sidecar are still v0.1.0), is that compatible? It seems there are only fews changes on compactor

Can I upgrade the compactor to v0.2.0 only(store/sidecar are still v0.1.0), is that compatible? It seems there are only fews changes on compactor

Yes, it is gRPC and the way we write it all components are compatible.
SignatureDoesNotMatch.. What signature it has in mind? Checksum? Or auth signature like here? https://docs.aws.amazon.com/general/latest/gr/signature-version-4.html

the sidecars are ok to upload chunks from the prometheus
the compactor PUT 403 while uploading the chunks after compacted
list the dir in the container
sidecar

the compact with namespace=thanos, because the prometheus instance name withe a /, so the path is split into two dir(odd....)

It seems the strange dir path is ok for the compact.
The another different is the chunks from compact (400+) are bigger than the chunks from sidecar(<60M).

Update:
Entered the compact container, 01CZ2J82W09K6RNVMXQ7W82AHQ.tmp dir which is compacting,
echo "" > chunks/000001
echo "" > chunks/000002

result
level=debug ts=2018-12-19T06:26:35.974116309Z caller=compact.go:758 compactionGroup="0...." msg="uploaded block" result_block=01CZ2J82W09K6RNVMXQ7W82AHQ duration=5.692986549s

I found that the 403 happens when the chunk size is large(512.5M chunk/000001), but not failed each time the size is 512.5M.
So, the chunk size or content maybe matters. will test later.
Close the issue.
Thanks!

https://github.com/improbable-eng/thanos/blob/v0.1.0/pkg/compact/compact.go#L255
The sort for groups will case the compactor stuck when the first one compact failed.
I wonder why not remove the sort, process one of the group randomly?

The another different is the chunks from compact (400M+) are bigger than the chunks from sidecar(<60M).

Because compactor is compacting blocks together. (:

I found that the 403 happens when the chunk size is large(512.5M chunk/000001), but not failed each time the size is 512.5M.

If that is the case then it's bad, as 99% blocks will have chunk files exactly 512MB. This is because we split chunk files by this arbitrary 0.5GB. But at least we know root cause I guess (: So if you do create even artiificial file and do upload to ceph (via our minio library) it will always return 503?

The sort for groups will case the compactor stuck when the first one compact failed.

Why? How this sort will cause compactor to be stuck? This sort is for making sure we determinstially process each group one by one fairly.

Let's close this issue only when we found the workaround, configuration problem or implementation fix (: Maybe someone else will hit the same?

So if you do create even artiificial file and do upload to ceph (via our minio library) it will always return 503

If the file created by compactor, part of them will return 503, but not always.
If I change the file after compact before upload(to zero, or truncate to <512.5M), always return 200

So,  I think the reason is the file content. I will check the ceph radosgw, use the raw minio-go sdk.

The sort for groups will case the compactor stuck when the first one compact failed.
Because the chunk which cases the 503 is always the first one of the groups. so the compact will be stuck there.
Now, before I figure out the reason of 503, I changed the codes there to skip the failure(which will break the loop and wait for next compat, which will take < 5min), and process the rest of groups.

Chunks will be quite often 512MB, and ignoring the upload error will cause compactor to be stuck on every block sources, so I would really fix the upload first. (:

I see you're on Ceph, can you check exactly the upload flow with something like https://mitmproxy.org/ ? This should help you identifying what's being uploaded with the corresponding signatures and which part of Thanos/Ceph/Rados is the issue
Also, we recently merged (#617) multipart support for S3 as I also had an issue with Ceph here. Can you try latest master ?
Lastly, what Ceph version are you running ? Have you configured anything fancy ?

thanks @adrien-f
I think I should figure out the response detail of the 403 first(set the radosgw  loglevel to debug but did not get any useful log).
BTW, the ceph version is 10.2.9.

Do you use a LB in front of the radosgw? I remember having nginx changing something to the request invalidating the signature. This is why you should look into the complete flow between thanos->nginx->ceph with something like mitm or wireshark to see if anything was modified in transit.
I don't remember exactly what changed though, something like an ending slash. Will check next week at work.

Have tested with LB and without LB before, same error. So I think there must be something wrong with our ceph cluster.

When I downgrade AWS signature from version 4 to version 2, the compact can do PUT without any errors.
But the AWS4 authentication protocol is supported from ceph 10.2.0(release log)
Will check the ceph.

I have checked that. It's ok after downgrade AWS signature from version 4 to version 2.(signature_version2:true)


REQ: Global image prefix

Describe the feature you would like and why you want it
Due to the rate limiting that docker.io has implemented, I would like to be able to add a prefix to all docker images that kuberhealthy runs. I could modify several images, but I would like a "global" setting where I could prefix all images with something like artifactory.company.com.
Additional context
Thanks in advance!?

Actually, if we could split the image registry from the repository like this:
image:
  registry: docker.io
  repository: kuberhealthy/kuberhealthy
  tag: 2.3.1

.. that would probably simplify adding a global override:
global:
  imageRegistry: artifactory.company.com

At the risk of adding too many options to the helm chart, I think this would be useful - even for us in our internal clusters.
I will leave this feature request open for anyone who feels up to the task.  Feel free to create a PR with this change in it if you get the time.


Crash on updating (regex) after commit 0cbddf7

Describe the bug

https://github.com/Chatterino/chatterino2/commit/0cbddf7e9bad60da4af73a762f59f3cd05f04724 changed the way regexes are stored in the settings. Thus updating chatterino to this version or later might cause chatterino to stop working when it's trying to run certain regexes.
Old:
"pattern": "alien([a-zA-Z0-9]{1,10})+",
New:
"pattern": "alien[A-z1-9]+",
To reproduce

(I'm not sure which regex broke it, but some regexes should not work properly)
https://pastebin.com/3X6nxViC
Screenshots

Chatterino version

Chatterino Nightly 2.2.2 (commit 3be62c929, )
Operating system

Windows 10
Additional information

This is really strange, even after removing the old regex things and writing them new again it still crashes sometimes (on startup).

I'm unable to reproduce - if you figure out a proper way to reproduce it feel free to re-open the issue


Server now closes socket when connection is dropped by client ( Fix #19 )

Server now closes socket when connection is dropped by client to avoid sockets hanging in CLOSE_WAIT state.
This aims at solving issue #19 as discussed. I changed the solution a bit from what was proposed at first to follow the pattern already existent in Client. I'm not sure however about the best reason and message for the disconnection.
I'm not sure about the testing rules for this branch, I tested this case has best I could manually. If I should do something else, like updating automatic tests, please do say.
Also took the liberty to fix a couple of typos in comments, hope you don't mind.
Thank you

Codecov Report

Merging #20 (633dbab) into main (271f8fc) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #20   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines          195       200    +5
  Branches        41        42    +1
=========================================
+ Hits           195       200    +5

Impacted Files
Coverage Δ

src/simple_websocket/ws.py
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

This is now merged. I have simplified the closing logic a bit, and also added a missing close for the selector, which is used when the optional pings are enabled. Thanks!

Thanks for your work!


Need a web designer who worked with Netlify CMS or with an analog

@fialka36 This is not the proper location for advertisements/requests. We welcome you to use our Gitter channel: https://gitter.im/netlify/NetlifyCMS. See you there!


dev server with an extra route

Hi,
I have a problem with the dev server.
I'm using jsonServer in my development build to simulate a server on json data. So, what I want is to access my app (Angular) with http://localhost:4444 and my api with http://localhost:4444/api.
If I try this
use.dev(server => {
  const app = server.httpServer.app;
  app.use('/api', jsonServer.router('db.json'));
});

my app works but my /api doesn´t.
If I try this
use.dev({ root: false}, server => {
  const app = server.httpServer.app;
  app.use('/api', jsonServer.router('db.json'));
});

then my /api works but my app doesn´t.
I also tried
fuse.dev({ root: false }, server => {
  const dist = path.resolve('./dist');
  const app = server.httpServer.app;
  app.use('/api', jsonServer.router('db.json'));
  app.get('/', function(req, res) {
    res.sendFile(path.join(dist, 'index.html'));
  });
});

so trying to define both my base root and the api, but it also does not work.
Am I doing something wrong? How am I supposed to configure this?
Thanks

hi @davidanaya and welcome to the community!
To begin with, that's just an express server
So technically you could wire up any functionality or even create your own server in java or any other language. Make sure your setup works without dev server in fusebox and then you can easily port it to fusebox, or simply you use your own

Hi @nchanged, thanks for your reply and sorry I know this is not the place for this question but there's still not much support out there.
This is the setup I'm using at the moment in webpack and it works nicely.
devServer: {
  historyApiFallback: true,
  setup: function (app) {
    app.use('/api', jsonServer.router('db.json'));
  }
}

But it's like something with { root: false } is not doing what I expected :(

Ok, I got it.
It seems that when you define a route you also HAVE to define the root. I thought that would be done automatically.
So I tried this
fuse.dev({ root: 'dist' }, server => {
  const app = server.httpServer.app;
  app.use('/api', jsonServer.router('db.json'));
});

and it works! 👍


How to prevent lsp from including header files automatically when I press Enter to choose the suggestion?

Hi, how can I prevent lsp from including header files automatically when I press Enter to choose the suggestion?
I'd like to include these header files manually instead of depending on lsp (or clangd maybe?).
Thank you very much！

It's easy, just a file called clangd.lua under user/configs/lsp-servers/ and fill it like:
local function get_binary_path_list(binaries)
	local path_list = {}
	for _, binary in ipairs(binaries) do
		local path = vim.fn.exepath(binary)
		if path ~= "" then
			table.insert(path_list, path)
		end
	end
	return table.concat(path_list, ",")
end

return function(options)
	require("lspconfig").clangd.setup({
		on_attach = options.on_attach,
		capabilities = vim.tbl_deep_extend("keep", { offsetEncoding = { "utf-16", "utf-8" } }, options.capabilities),
		single_file_support = true,
		cmd = {
			"clangd",
			"-j=12",
			"--enable-config",
			"--background-index",
			"--pch-storage=memory",
			-- You MUST set this arg ↓ to your c/cpp compiler location (if not included)!
			"--query-driver=" .. get_binary_path_list({ "clang++", "clang", "gcc", "g++"}),
			"--clang-tidy",
			"--all-scopes-completion",
			"--completion-style=detailed",
			"--header-insertion-decorators",
			"--header-insertion=never",
			"--limit-references=3000",
			"--limit-results=350",
		},
	})
end

The point is --header-insertion=never

Thanks. It works well.


[WIP] Homepage

What: Home page design according to #8
Why: Because #8 design is awesome :)

I went ahead and merged. Could you rebase? I'm afraid there will probably be a handful of merge conflicts.

Really looking forward to trying this out. I'm going to set up stage.now.sh so we can get a preview in PRs. Also, let's add yarn-error.log to the gitignore and get that file deleted. And it looks like there are still some conflicts. Sorry!
Thanks for working on this!!!

Cool ! @kentcdodds when tryint to lint the entire project, I'm running into this current issue :
Cannot find module 'eslint-config-kentcdodds/prettier'
Referenced from: /Users/Stephane/Projects/glamorous-website/.eslintrc
Error: Cannot find module 'eslint-config-kentcdodds/prettier'
Referenced from: /Users/Stephane/Projects/glamorous-website/.eslintrc

Have you installed dependencies? I added/updated a few in the most recent commits.

@bulby97 Some other general things:

I'd love if the main logo were full width. Maybe we want to remove the maxWidth?
I'm thinking the installation instructions can go right above the placeholder black box, and then when we replace that placeholder with a react-live thing it'll flow nicely like "Install like this, write code like this". See https://github.com/kentcdodds/glamorous-website/issues/8#issuecomment-304769614
I think the bottom separator above the footer should be on all the pages. It might be worth including it in footer.js so that it's always separating the footer.
If we move the installation instructions up, I'm not sure what would be in the big white space below "Used by peeps at". :thinking: We can just ditch that white area or fill it with a couple of things we'd like to highlight, such as theming, using props, and extending components.

Again, this is looking awesome!

@kentcdodds Thank you for all of the feedback !
My day is ending, so I gotta go, will surely continue tomorrow.

Thanks so much for the work!

Oh, the nav has styles with an active class. I had started working on this last night and the gist of it is to grab the pathname on each page and pass it down through the Layout into the Nav, then check if the pathname matches the href.
See here in the next README about grabbing pathname: https://github.com/zeit/next.js#fetching-data-and-component-lifecycle

Codecov Report

Merging #17 into master will decrease coverage by 0.55%.
The diff coverage is 97.05%.

@@           Coverage Diff           @@
##           master   #17      +/-   ##
=======================================
- Coverage   95.55%   95%   -0.56%
=======================================
  Files          13    15       +2
  Lines          45    60      +15
  Branches        3     5       +2
=======================================
+ Hits           43    57      +14
- Misses          2     3       +1

Impacted Files
Coverage Δ

pages/docs.js
80% <ø> (-3.34%)
:arrow_down:

styles/base.js
100% <ø> (ø)
:arrow_up:

components/lipstick-icon.js
100% <ø> (ø)
:arrow_up:

components/styled-links.js
100% <100%> (ø)
:arrow_up:

components/footer.js
100% <100%> (ø)
:arrow_up:

components/nav.js
100% <100%> (ø)
:arrow_up:

components/markdown-wrapper.js
100% <100%> (ø)

components/separator.js
100% <100%> (ø)

components/layout.js
85.71% <100%> (+2.38%)
:arrow_up:

styles/global-styles.js
100% <100%> (ø)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c620d68...270da29. Read the comment docs.

@kentcdodds can I ask how you pushed to @bulby97's PR? Do you just have write access to the forked repo?

Isn't this just totally awesome!?

😎

Oh, the nav has styles with an active class. I had started working on this last night and the gist of it is to grab the pathname on each page and pass it down through the Layout into the Nav, then check if the pathname matches the href.
See here in the next README about grabbing pathname: https://github.com/zeit/next.js#fetching-data-and-component-lifecycle
LMK if you want me to post a sample of what I've done.

I went ahead and committed what I did. I'll leave it to @bulby97 to take it from here. I just did the legwork for passing the pathname along properly.

Logs for the stage-ci stuff can be found here.
> Deploying kentcdodds/glamorous-website@homepage#df13595259f8a622fd6bded646126958309f9b04 to https://glamorous-website-homepage.now.sh
> Setting GitHub status to "pending"...
05/30 11:28 AM (6m)
> Fetching homepage...
05/30 11:28 AM (5m)
> Checking out<EMAIL_ADDRESS>05/30 11:28 AM (5m)
fatal: reference is not a tree: df13595259f8a622fd6bded646126958309f9b04
05/30 11:28 AM (5m)

Error: fatal: reference is not a tree: df13595259f8a622fd6bded646126958309f9b04

    at /stage-ci/node_modules/simple-git/promise.js:21:26
    at Git.<anonymous> (/stage-ci/node_modules/simple-git/src/git.js:473:18)
    at Git.<anonymous> (/stage-ci/node_modules/simple-git/src/git.js:1272:21)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:194:7)
    at maybeClose (internal/child_process.js:899:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
05/30 11:28 AM (5m)
> Setting GitHub status to "error"...
05/30 11:28 AM (5m)
> Done!

The issue is probably all of the git stuff that's been going on I guess. I'm not sure. I wonder if we rebased this branch 🤔

Logs for the stage-ci stuff can be found here.

I get a 403, so I am guessing it's only accessible to the account owner or team members.
It's possible that this PR is borked because of the merging or multiple contributors. I honestly don't know.
Maybe before we merge we should manually deploy to now just so we can all look at the same thing?

Honestly might not be a bad idea to just merge it when it's in an "Ok" state and fail forward. We can be pretty sloppy until we officially release this :)

Actually, when we're ready to release this officially, I think I could switch us to https://github.com/eliperelman/now-travis which will give us both autodeploy of master as well as autodeploy of PRs which is pretty cool :+1:

That sounds good to me. Let's give @bulby97 some more time to match the designs at least. Then we can merge and do things like the react live examples.

Sounds great!

@kentcdodds @paulmolluzzo Guys, I think I'm done with this PR. Can you merge it ? Even if it's an Ok state I think we could iterate over it :).

Yup, let's merge it. Thanks!

This looks so great! Thanks @bulby97! 🙌


Error when running App: "environment_creation_failed"

I'm using the example code and getting the following error when running a Windows app:

I have WebView2 Runtime installed:

Flutter doctor
[√] Flutter (Channel stable, 2.10.3, on Microsoft Windows [Version 10.0.19043.1586], locale en-ZA)
• Flutter version 2.10.3 at C:\flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 7e9793dee1 (3 weeks ago), 2022-03-02 11:23:12 -0600
• Engine revision bd539267b4
• Dart version 2.16.1
• DevTools version 2.9.2
[√] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
• Android SDK at C:\Users\user\AppData\Local\Android\sdk
• Platform android-31, build-tools 31.0.0
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 11.0.11+9-b60-7590822)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe
[√] Visual Studio - develop for Windows (Visual Studio Enterprise 2022 17.0.0)
• Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Enterprise
• Visual Studio Enterprise 2022 version 17.0.31903.59
• Windows 10 SDK version 10.0.20348.0
[√] Android Studio (version 2021.1)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.11+9-b60-7590822)
[√] VS Code
• VS Code at C:\Users\user\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.36.0
[√] VS Code, 64-bit edition (version 1.64.2)
• VS Code at C:\Program Files\Microsoft VS Code
• Flutter extension version 3.36.0
[√] Connected device (3 available)
• Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19043.1586]
• Chrome (web)      • chrome  • web-javascript • Google Chrome 99.0.4844.74
• Edge (web)        • edge    • web-javascript • Microsoft Edge 99.0.1150.46
[√] HTTP Host Availability
• All required HTTP hosts are available
Plugin version

Version: 0.1.6
I tried Version 0.1.7-dev.2 as well

Desktop OS:

OS:  Windows 10 Pro, Version: 21H1, OS Build: 19043.1586

I think that problem is the build of Windows 10.
I had this erorr one time but fixed installing WebView2, so i don't understand why for you didn't worked

I got this message once if fixed it installing the "Evergreen Standalone Installer" from https://developer.microsoft.com/en-us/microsoft-edge/webview2/


Change all uses of Span::def_site to Span::mixed_site

Span::def_site and Span::mixed_site do similar things, but the latter is stable. See the stabilization report for background.
After this change, we should be able to remove #![feature(proc_macro_def_site)] as well.

Hi, first time here, I did as asked here and on #193, and it looks that all tests pass (at least those which passed before the change), anything I'm missing? anything else I should check?

@vim-zz I think #193 is all that needs to be done :slightly_smiling_face:


Document HL7 data feed from PHIN MS into DEX

This is currently in progress. I am basically rewriting some of the original documentation that was produced and updating it. There will also be an O&M document on some of the basic things to check and typical remediations for problems.

I have made changes to the basic process. There is now a Databrick added to run 'Step 3'. Step 3 is the process that moves each row of data that is moved over in the previous steps when coping the raw data from PHINMS, in to individual file with metadata wrapped around each. This should be done by the end of today.


remove 运行包的chalk

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #20   +/-   ##
=======================================
  Coverage   91.02%   91.02%
=======================================
  Files          82       82
  Lines        2072     2072
  Branches      493      493
=======================================
  Hits         1886     1886
  Misses        179      179
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1480a6...bf28099. Read the comment docs.


Does not handle CTEs (WITH keyword)

dblite does not handle CTEs
https://www.sqlite.org/lang_with.html
The verify select method needs to be modified to include WITH|with.
An example of a CTE:
WITH test(name) AS (
SELECT "JOHN"
)
SELECT name
FROM test;

you mean here ? https://github.com/WebReflection/dblite/blob/master/src/dblite.js#L45


Button "Add offer" on mouseover barely legible

Describe the Bug

The "Add offer" button in the "My Offers" view is barely readable.
Steps to Reproduce

Login as offer provider
Go to "My Offers"
Mouseover effect on "Add offer" button
See that the text is in yellow and therefore barely legible

Expected Behavior

Also on mouseover effect the text should be legible
Actual Behavior

Text on mouseover effect is barely legible
Additional Information

Use text-gray-700 instead of text-primary as the hover effect for this button

Traceback

Maybe this is a good issue for @amikable-tech?

hello, I am a beginners and I like your project. powers try to contribute in this!

Hello @paoloevan, thank you for your interest in our project. Please feel free to tackle this issue if you like :)