Remove YamlEqual method to remove duplicate work and bash commands

Description of changes:
Remove yaml equality check from util.go as it is not necessary if we check the spec like we check the status. This will also remove the usage of bash commands such as sed, diff, and cat.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/test sagemaker-kind-e2e

/test sagemaker-kind-e2e


Vesta Finance Arbitrum QA

Review Info

Description
Info

Subgraph Reviewed
https://subgraphs.messari.io/subgraph?endpoint=https://api.thegraph.com/subgraphs/name/corerouter/vesta-finance&tab=protocol

Schema Version
1.3.0

Subgraph Version
1.0.1

Methodology Version
1.0.0

Evidence Spreadsheet
https://docs.google.com/spreadsheets/d/1sOxW5_8NPQKHJKbw0OJQBKQuWA3BR20V/edit?usp=sharing&ouid=104027705798814439445&rtpof=true&sd=true

Metric to Review
Revenue

We did computations for the supply side revenue, protocol side revenue, and daily total revenue using data from Dune and the results show a large discrepancy ranging from 21% to 177% with subgraph data. This may be due to the reason liquidation events and its subsequent USD values are not captured correctly
The queries are:

https://dune.com/queries/1290422
https://dune.com/queries/1286749

Refer to the sheet 'Protocol' under the respective items for details.

Subgraph Daily Supply Side Revenue
Dune Analytics
Absolute Difference
% Difference

156.95
110
46
42.68%

Subgraph Daily Protocol Side Revenue
Dune Analytics
Absolute Difference
% Difference

1,149
946.90
202
21.34%

Subgraph Total Daily Revenue
Dune Analytics
Absolute Difference
% Difference

1306
1056
246
23.57%

Max LTV of gOHM pool
This should be 66.7% instead of 90.1%.

Thank you very much for your test. Please find my feedback and questions on these issues raised.

For Daily Supply Side Revenue, would you please let me know how the dollar value of 110 was computed?
The Dune dashboard only provide asset number and debtUSD and doesn't have any asset price info from https://dune.com/queries/1290422. It is important for me to find the root cause for the dollar value difference as I find the asset value is right.
For Daily Protocol Side Revenue and Total Daily Revenue, I fixed a constant in the subgraph and now the data is more in line with Dune dashboard at https://dune.com/queries/1286749. I also noticed in Dune the redemptions revenue for GMX and gOHM is not included as there are not price info for them as shown below, so it is also a reason for data difference in some day.

The maxLTV data error for some markets such as gOHM have been fixed.

@corerouter

I double checked the revenue using: https://dune.com/queries/1286749. The dates available on the the dune dashboard match the subgraph. There are revenue dates on the dune that is not on the subgraph. is that because there is no block data?
Would it be possible to get GMX and gOHM oracle price? @dmelotik do you know if this is possible?
Max LTV looks fixed.

Would it be possible to get GMX and gOHM oracle price? @dmelotik do you know if this is possible?

Like on the subgraph? I think @corerouter is saying the dune dashboard doesn't have the gOHM and GMX price

Ah ok my bad

@ishraq8 Thank you very much for your kind response.

For the revenue data, I compared the subgraph with Dune and didn't find any revenue dates missing on the subgraph. As shown below, the latest 150 entries for protocol revenue on subgraph dates back to May 2 while Dune dates back to May 1 as the subgraph show the real time date on Sep 28 while Dune didn't. So I don't think there is any missing days for the revenue data in the subgraph so far.

For the GMX and gOHM prices, the subgraph gets them from Vesta internal oracle. I think Dune dashboard try to get them from Dune internal prices database but find there are not prices for the two tokens so far.

Thanks!

@ishraq8 what's the status on this?

My mistake this subgraph is done and ready for prod.
Thank you @dmelotik @corerouter
Version QAed was: https://thegraph.com/hosted-service/subgraph/corerouter/vesta-finance

One last change needs to be made then deploying to prod!


[react] fix hooks

I fixed a few things in the hooks while working on the example app:

Add missing import
Fix evt -> event variable name
Fix warning of invalid types and avoid filtering in production, since subscribing to a non-existing event is not going to throw any errors. Add information about which event was invalid.
Fix double const in useTrackPlayerProgress and just return the state, since we can control interval by what is passed into it
only set progress interval when the player is either playing or buffering
remove catching of player errors, since these functions should not be throwing errors (and if they do, we should fix the underlying cause)

@matthamil perhaps you would like to take a look?

@puckey hey thanks for fixing my bad code :)
I'll take a look at this tonight or tomorrow. Please do not hesitate to ping me again if I don't remember to do so!

On an unrelated note, I see that you helped create tonite.dance. I remember seeing that when it made its way around the Twitterverse. Love it, super cool project 😄

On an unrelated note, I see that you helped create tonite.dance. I remember seeing that when it made its way around the Twitterverse. Love it, super cool project 😄

Thanks - it was fun to work on!


Sharpen dashboard charts

update color pallet from the use of pastels
speed up chart introductory animations
adjust chart font

font normalized, animations sped up, colors globalized.
if groovy, I'll pr and jive on.

No, let's discuss.

Ooh please do! Would love some precise direction especially with the colors (what I am betting is up, previously lib colors were being used, the ones requested changed).


fuzz: fix filesystem crash

Possible fix for filesystem crash in server fuzz test due to https://github.com/envoyproxy/envoy/pull/7339
Testing: Add corpus entry
Issue
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=15414
Signed-off-by: Asra Ali<EMAIL_ADDRESS>

/review htuch
Verification that this is the fix is unfortunately difficult. Reproducing the fuzz bug in the oss-fuzz docker image comes up as no error, while running the test either locally with bazel and asan, or using envoy's docker build and bazel.asan brings up unrelated asan issues.

Update: Minijail on the production environment for OSS-Fuzz prohibits mkdir from going through, which causes the crash in production, but not in the OSS-Fuzz docker image environments. It turns out that the mkdir branch was being taken after #7339, and this should fix that issue.


add document-deletion feature

Is this issue fixed?

Created, and now being updated and worked on.


List of URLs that returns unrelated results

Link: https://mui.com/

Interesting. The HN API is somehow accepting mui.com for all mi.com links, and reddit also is not doing an exact search. I can't find a way to get it to an exact search.
Possible solution: we may have to

filter the results after we receive them to only include exact matches
ask for more pages of results from HN/reddit

https://en.wikipedia.org/wiki/Tenkasi
HN returns https://en.wikipedia.org/wiki/Tenkasi (Tensile strength).
Lol

usefriz.com gets links for usefyi.com from HN API

This exact issue is no longer relevant because of our ML filtering


Enlarging Icon causing overlapping text

Hi,
Does anyone have tips for screen responsiveness when using large material-ui icon (basically from laptop down to mobile screen)?
I was planning create a banner by using Grid + Material-ui Icon and messages besides it like shown below but on a much larger size:

When I tried reduce the screen size, the text overlaps with the icon.
This is actually not causing issue if I swap the text with the Icon position..
https://codesandbox.io/s/material-demo-forked-ddczt?file=/demo.js
Any help would be appreciated.
Thanks,
Santo

See this implementation example for the Banner https://github.com/mui-org/material-ui/issues/13100#issuecomment-427463834

Thanks @oliviertassinari , but I think that Stack is not available on the current stable release..
If I swap out the grid with stack, it would overlap..

The result:

https://codesandbox.io/s/hook-forked-b15iw?file=/demo.js
Could this be a potential bug?
Thanks,


pod styles?

Is it possible to configure with stylesheets in both the styles directory and also in pods?
e.g.
app/
  styles/
    some-styles.scss
  pods/
    components/
      my-component/
        template.hs
        component.js
        style.scss      // currently ignored

are you using https://github.com/justtal/ember-cli-sass-pods ?

Nope.
My ember-cli-build.js looks like this:
// ...
sassOptions: {
  includePaths: [
    '../assets/css',
    'app/pods',
    'bower_components/bourbon/app/assets/stylesheets'
  ]
}

app.scss
// Component styles...
@import 'app/pods/components/foo-bar/style';
// Route specific styles...
@import 'app/pods/foo/style';

Were you able to re-create?

this works in 0.5.0


Copying articles in the article list not working

See the discussion at #1526
Copying one or more articles in the article list throws an exception. The cause is ArticleListView’s ‑copyTableSelection:toPasteboard: method which expects an NSIndexPath, but is handed an NSArray by MessageListView’s ‑copy: method.
It might be worthwhile to refactor the code with the NSPasteboardWriting protocol. The Folder and Article classes could both adopt this protocol and reuse the code in ‑copyTableSelection:toPasteboard:. NSTableView and NSOutlineView both use deprecated methods (‑tableView:writeRowsWithIndexes:toPasteboard: and ‑outlineView:writeItems:toPasteboard:) that ought to be replaced with ‑tableView:pasteboardWriterForRow: and ‑outlineView:pasteboardWriterForItem:.

As Xcode does not emit warnings, I prefer limiting myself to minimalist fixes …

It does not with the current deployment target, but starting with 10.15 it does. You never know what happens on newer systems… (there were issues with this before, e.g. ). Regardless, an easy fix is fine for now.


Template provisioning works but throws sometimes « vti_mastercssfilecache » does not exist.

If you provision a new site collection and then run the following template, you will get an issue « vti_mastercssfilecache » does not exist. This is an on and off issue.

Here's a the full stack trace:
Microsoft.SharePoint.Client.ServerException was unhandled
HResult=-2146233088
Message=Le champ ou la propriété « vti_mastercssfilecache » n’existe pas.
ServerErrorCode=-1
ServerErrorTraceCorrelationId=445a2c9d-50cc-2000-09f4-9f469bd16f9e
ServerErrorTypeName=Microsoft.SharePoint.Client.InvalidClientQueryException
ServerStackTrace=""
Source=Microsoft.SharePoint.Client.Runtime
StackTrace:
at Microsoft.SharePoint.Client.ClientRequest.ProcessResponseStream(Stream responseStream)
at Microsoft.SharePoint.Client.ClientRequest.ProcessResponse()
at Microsoft.SharePoint.Client.ClientRequest.ExecuteQueryToServer(ChunkStringBuilder sb)
at Microsoft.SharePoint.Client.ClientRequest.ExecuteQuery()
at Microsoft.SharePoint.Client.ClientRuntimeContext.ExecuteQuery()
at Microsoft.SharePoint.Client.ClientContext.ExecuteQuery()
at Microsoft.SharePoint.Client.ClientContextExtensions.ExecuteQueryImplementation(ClientRuntimeContext clientContext, Int32 retryCount, Int32 delay) in C:\Git\Repos\PnP-Sites-Core\Core\OfficeDevPnP.Core\AppModelExtensions\ClientContextExtensions.cs:line 54
at Microsoft.SharePoint.Client.ClientContextExtensions.ExecuteQueryRetry(ClientRuntimeContext clientContext, Int32 retryCount, Int32 delay) in C:\Git\Repos\PnP-Sites-Core\Core\OfficeDevPnP.Core\AppModelExtensions\ClientContextExtensions.cs:line 36
at Microsoft.SharePoint.Client.WebExtensions.PropertyBagContainsKey(Web web, String key) in C:\Git\Repos\PnP-Sites-Core\Core\OfficeDevPnP.Core\AppModelExtensions\WebExtensions.cs:line 771
at Microsoft.SharePoint.Client.WebExtensions.GetIndexedPropertyBagKeys(Web web) in C:\Git\Repos\PnP-Sites-Core\Core\OfficeDevPnP.Core\AppModelExtensions\WebExtensions.cs:line 807
at Microsoft.SharePoint.Client.WebExtensions.AddIndexedPropertyBagKey(Web web, String key) in C:\Git\Repos\PnP-Sites-Core\Core\OfficeDevPnP.Core\AppModelExtensions\WebExtensions.cs:line 828
at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectPersistTemplateInfo.ProvisionObjects(Web web, ProvisioningTemplate template, TokenParser parser, ProvisioningTemplateApplyingInformation applyingInformation) in C:\Git\Repos\PnP-Sites-Core\Core\OfficeDevPnP.Core\Framework\Provisioning\ObjectHandlers\ObjectPersistTemplateInfo.cs:line 26
at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.SiteToTemplateConversion.ApplyRemoteTemplate(Web web, ProvisioningTemplate template, ProvisioningTemplateApplyingInformation provisioningInfo) in C:\Git\Repos\PnP-Sites-Core\Core\OfficeDevPnP.Core\Framework\Provisioning\ObjectHandlers\SiteToTemplateConversion.cs:line 177
at Microsoft.SharePoint.Client.WebExtensions.ApplyProvisioningTemplate(Web web, ProvisioningTemplate template, ProvisioningTemplateApplyingInformation applyingInformation) in C:\Git\Repos\PnP-Sites-Core\Core\OfficeDevPnP.Core\AppModelExtensions\WebExtensions.cs:line 1037
at CDP.SharePoint.Provisioning.Program.Main(String[] args) in C:\DEVLC\CDP.SharePoint.RAC\Dev_RacOnline\CDP.SharePoint.RAC\CDP.SharePoint.Provisioning\Program.cs:line 83
at System.AppDomain._nExecuteAssembly(RuntimeAssembly assembly, String[] args)
at System.AppDomain.ExecuteAssembly(String assemblyFile, Evidence assemblySecurity, String[] args)
at Microsoft.VisualStudio.HostingProcess.HostProc.RunUsersAssembly()
at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Threading.ThreadHelper.ThreadStart()
InnerException:

I'm experiencing the same issue on OfficeDevPnP.Core version 1.6.915.0.

We are aware of the issue, and what is causing it. We contacted Microsoft about this (as it's not related to our code) but we also came up with a solution that we will implement very soon in the engine.

What is the temporary workaround for this issue.  Is it deleting the "vti_mastercssfilecache" property?

The vti_mastercssfilecache property is temporarily set by the server the moment you apply a composed look/theme. It removes that value but CSOM still caches it.
If you use the latest build (or at least one later than the September release), we have fixed the issue in the core library. It has to do with the way the server removes the property bag value while CSOM still retains a cached reference to a value that is already removed from the property bag. Our Core library property bag methods are aware of this now and handle the propertybag calls a bit differently, skipping the cached values of CSOM.

Closing the issue. If you feel that this issue still occurs using the latest builds, please do no hesitate to open it again.


[addr-move-function] Wire up closure operands to the caller global data flow.

In #40775, I forgot to wire up closure operands to the caller global data flow. I do that in one of the attached commits, fix a few bugs, and more tests for partial apply, casts, and defers.

@swift-ci test

@swift-ci test

Build failed
Swift Test Linux Platform
Git Sha - cfdfff3a22cccc36a0071c09567eb1b3a0faa777

Linux failure is I think unrelated to my PR. Its in the driver.

@swift-ci test linux platform


Error on running forward function in TextEmbedder and GTrendEmbedder

Dear @joppichristian and @geriskenderi,
I get the error "RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cuda:1!" when running the model.
Upon deactivating TextEmbedder and GTrendEmbedder, the entire run succeeds, regarding updating validation_epoch_end to on_validation_epoch_end, but with these two parts, the error occurs.
On TextEmbedder, the error is caused on self.fc(word_embeddings). For both word_embeddings and the FC model, I used ".to('cuda:'+str(self.gpu_num))", but it didn't work.
torch:  2.0.1+cu117
pytorch_lightning:  2.0.3
With two GPU, NVIDIA V100

Hi @baghishani,
try installing version 1.9 (or versions less than 2.0) of torch.
Christian

Thanks, @joppichristian.
It worked. I also had to consider the compatible version of pytorch_lightning, in case it happens to someone else :)


Support QBits kernel for CPU device

Based on the suggestion of https://github.com/AutoGPTQ/AutoGPTQ/issues/597, we have implemented the inference of GPTQ model on the CPU device. This PR will support Weight-Only quantization on CPU devices and infernce with QBbits backend. QBits backend has a 'bestla' kernel for CPU gemm op. And QBits is a module of intel-extension-for-transformers package.

@PenghuiCheng  Awesome.  Does Qbits support any x86_64 including amd and non-validated intel? Also is this limited to only some recent gen chips? I only see that two classes of intel cpu validated. Obviously Intel may not validate non-intel such as amd but are the instructions tested also on amd?

ntel Xeon Scalable Processors
✔
✔
✔ (INT8, FP8)
✔ (INT4, FP4, NF4)

Intel Xeon CPU Max Series
✔
✔
✔ (INT8, FP8)
✔ (INT4, FP4, NF4)

@PenghuiCheng Awesome. Does Qbits support any x86_64 including amd and non-validated intel? Also is this limited to only some recent gen chips? I only see that two classes of intel cpu validated. Obviously Intel may not validate non-intel such as amd but are the instructions tested also on amd?
ntel Xeon Scalable Processors	✔	✔	✔ (INT8, FP8)	✔ (INT4, FP4, NF4)
Intel Xeon CPU Max Series	✔	✔	✔ (INT8, FP8)	✔ (INT4, FP4, NF4)

For non-intel devices, we believe the code would work well as long as the instructions are compliant to Intel CPU ISAs.

@Qubitium ,  Hi, we are not sure if we have done everything appropriately, but we expect your review. Please let us know if there's anything we can do to improve it 😄

@PenghuiCheng Thank you for your patience. I do not have the authority to approve this PR. Both @PanQiWei and @fxmarty Are extremely busy at the moment so I am not sure about timeline.
There is discussion in issues about completely replacing the stagnant qigen code with qbit code. It will be of great benefit to the gptq community to have Intel come on board to actively support x86_64 cpu kernels.
Can you test the state of the qigen code in autogptq main? I have a tingly it is in a semi-inoperable state. If qigen is not fully functional, my suggestion is to modify the pr and have qbit completely take over all cpu paths (remove and replace all qigen code).


Custom Struct

Situation
Wrong initialiser used when I was using this struct:
struct CurrencyPair: Hashable, Identifiable, Codable {
    var id: String { description }

    var base: String
    var quote: String
    var enabled: Bool

    var description: String {
        "\(base)/\(quote)"
    }
}

with this code:
@State private var currencyPairSelection: Set<CurrencyPair>
@State private var currencyPairOptions: [CurrencyPair]

var settings: Settings

init(settings: Settings) {
    self.settings = settings
    _currencyPairOptions = State(initialValue: settings.currencyPairs)

    let set =  Set(settings.currencyPairs.filter { $0.enabled })
    _currencyPairSelection = State(initialValue: set)
}

            MultiPicker(selection: $currencyPairSelection, content: {
                ForEach(currencyPairOptions, id: \.self) { option in
                    Text(option.description).mpTag(option)
                }
            }, label: {
                Text("Enabled Currencies")
            })
            .mpPickerStyle(.navigationLink)

`
I wanted a Multiple option picker, but could not find the reason this was not working. So I CMD + Clicked on the MultiPicker to see what Initialiser was being used, turns out the selection property was set to single.
After I commented out the other intialisers except for the Binding<Set<>> one, Xcode finally gave the error that my struct needed to conform to CustomStringConvertible.
Finally, after adding this to the struct like this:
 struct CurrencyPair: Hashable, Identifiable, Codable, CustomStringConvertible {
    var id: String { description }

    var base: String
    var quote: String
    var enabled: Bool

    var description: String {
        "\(base)/\(quote)"
    }
}

it works perfectly!
Solution
Either add to the documentation that a custom struct must conform to CustomStringConvertible, or some kind of extra check to get the correct initialiser. Thanks!!

@jan-martenn Thanks for reporting on your experience. That's a fair point. I think the requirement for conforming to CustomStringConvertable can be removed, and I'll also add a note to the documentation about conforming to CustomStringConvertable if people want to customize the plain style representation.

Confirmed working, thanks for the quick response! 🫡📈


fixes for travis golint upgrade

golint has updated and has exciting new requirements for us. Remove all newlines and punctuation from error strings.

Coverage increased (+0.06%) to 65.133% when pulling 30d6a86c242740086bbd6a8301d8f850ee8fe5e2 on kaccardi:topic/fix-travis into 38752a17b25d59e8965b677d8999b52934a914a0 on 01org:master.


Option to keep inventory items with zero counts.

@zyro can we add the new parameter to the schemas and definitions files? 🙏

Done. 👍


Use a dark titlebar when we've requested dark theme

targets #14497
This applies to "showTabsInTitlebar": false,. We literally never set that for the IslandWindow before, only ever the NCIW.
Closes #11589

For a dramatic example - here's the IW with mica enabled, in dark mode:

Theme json:
        {
            "name": "chonk",
            "tab":
            {
                "background": "#00000000",
                "unfocusedBackground": "#00000000",
                "showCloseButton": "never"
            },
            "tabRow":
            {
                "background": "#00000000",
                "unfocusedBackground": "#00000000",
            },
            "window":
            {
                "applicationTheme": "dark",
                "useMica": true
            }
        },

@zadjii-msft the bot trashed your branch; i've tried to re-push and re-open

your branch is fixed, from a git/github POV. now it just needs to be fixed from a "comments" POV! :D

/azp run

@msftbot merge this in 5 minutes

@msftbot forget everything I just told you

(It might seem weird, but this is what i intended. 0 minutes instead of 5!)


Unittests

Travis can build and test if the tests interact directly with the CLI command instead of through fio.

Done.


[1.12.2] Crash via Forge Fluid Handler at Cold Igniter

Issue Description:
Custom Pack loads okay (check mod list in log file), but on world boot that previously worked with EnderIO, the server side shuts down.
What happens:
Forge/EnderIO error says fluid isn't registered, checked the configs and it seems to be that vapor one.
What you expected to happen:
World boots okay with Ex Nihilo: Creatio and BetterQuesting freshly added.
Steps to reproduce:
1.Load up modpack (ask if you want download, not public available yet)
2.Load Up world previously created
3.Wait + check log if forge/ world worked
...

Affected Versions (Do not use "latest"):

EnderIO: 5.0.20
EnderCore:0.5.18
Minecraft: 1.12.2
Forge:<IP_ADDRESS>53-2654

Your most recent log file where the issue was present:
https://pastebin.com/cJ9eB6Xx

Attempted deleting the configs for PE, got into the world. Thanks for the stacktrace help.

Verry carefuly :wink:

lol

Like what do you mean

Code organization; trying to learn how they programmed this. Kinda a java/modding newbie


npm scripts don't appear to update test/_30s.js

Description
I believe I followed contrib guidelines for #889, including running npm run tagger, npm run tester, and npm run test. However, my tests did not pass until I manually updated test_30s.js. Is one of the scripts supposed to update this file?

Yeah, I think the guidelines are a bit out of date. I think it's the packager's job. I'll update them asap.

Resolved in bd11d03. Waiting for @fejes713 to update the image at the top and resolve #892 as well.


Fix for "@swc/types@workspace:^: Workspace not found"

Hey, I just made a Pull Request!
Fix for broken E2E tests across different PRs with problem "YN0001: Error: @swc/types@workspace:^: Workspace not found (@swc/types@workspace:^)". Example: https://github.com/backstage/backstage/actions/runs/9268681348/job/25521798051?pr=24081
The applied solution is taken from this thread: https://github.com/vitejs/vite-plugin-react-swc/issues/211
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

I think that we ended up fixing this with #24966. Closing for now :pray:


Feat/rpc support

Usage related changes

Added a /rpc endpoint that allows for making RPC calls according to the starknet rpc specs

Development related changes
None
Checklist:

[x] Performed a self-review of the code
[ ] Rebased to the base branch
[x] Documented the changes
[x] Updated the tests

Additional details
I didn't want to modify the internals of devnet much while implementing this feature and relied on the methods already present in starknet_wrapper. Because of that I had to do some "hacks" in few methods. If you think it would be better to instead make modifications/add methods to wrapper and use them instead I'm open for any suggestions.
Also lint checks will fail with this PR because of two FIXME in tests and rpc, they will have to be removed later (especially after #100 is closed).

#100 has been merged. Does this change what you wrote in the PR description?
What about the rebasing to the target branch? I see it's marked as TODO in your PR description. Also, just before merging your PR, I will probably change the target branch to something other than master (but on the same commit), to see how testing goes.

I'm currently updating PR because it is missing changes introduced by wrapper refactor.

In my comments I may identified at least some of the hacks you are mentioning. Did I identify all of them?

Most of them, I would also consider what i did in get_transaction_by_block_hash_and_index, and get_transaction_by_block_number_and_index a hacks.

You could consider adding an e2e test with the run_devnet_in_background annotation (see other tests for example)

I considered that but I though these endpoint tests covered most of the use cases. I may try adding a test based on "general_workflow" tests but I'm not sure how that will go.

Endpoints not tested:

getStateUpdateByHash
blockNumber

Those will need to be added

Regarding RPC endpoints not implemented due to Devnet limitations:

Not saying you should do it, but have you considered making them return a Not Implemented response?

I think we could do something like that. Maybe throw a custom RPC error so they have consistent returns with other methods?

Couldn't chainId endpoint be implemented?

I wasn't sure what value to return there. I see pathfinder now added this parameter to their full node, so I'll look how they do this endpoint and maybe implement it.

I've implemented improvements based on most of the comments.
I've also introduced better typing to the rpc methods: there're now using TypedDicts. I think it will allow for less mistakes in the future.
ChainId endpoint has been implemented, as well as the protocol version.
I've added missing test, not e2e test though, do you think we should have them for rpc endpoint?
Not implemented endpoints now raise NotImplementedError()

I think we're getting closer to being merge-ready but we're still not quite there yet: there are 3 FIXMEs in the code that will need to be discussed, I will add comments for them. I've marked as resolved some of the most obvious discussions, but there are still some that need to be addressed.
I've also uncovered something that I think is a minor bug in devnet that is causing one of my tests to fail: I will open an issue with steps to reproduce soon.
Also, unfortunately RPC changes faster than I implement new stuff 😅 and 0.9.0 of the rpc released yesterday (and i see 0.10.0 is already in the works). Most of the changes brought by this version are related to starknet 0.9.0 which is not out as of writing this message, so it shouldn't block a merge this PR, but it might anytime soon (not saying we should hurry though, as these changes will need to be supported anyway).
tl;dr i did some fixes, but we're not 100% done yet

Instead of importing DEFAULT_GENERAL_CONFIG, do you think it would be better to use the general_config property of state.starknet_wrapper.get_state()?

I didn't realise this was exposed though starknet_wrapper. It's definitely better to used that

You don't have to introduce an e2e test.

👍  I think they aren't needed that much here since wrapper is tested anyway through e2e tests that already exists, and RPC is just another layer on that


Big Sur Upgrade - It's Blue!

For questions or tech support, please start with the users’ group. If you know the problem is in Quicksilver itself, report it here.

Describe the bug
Quicksilver is mostly bright blue (and some black), making it hard to see/use.
To Reproduce
Steps to reproduce the behavior:

Upgrade to Big Sur
Open Quicksilver
Everything is blue (well, some black)
Changing settings, uninstalling/reinstalling yield no improvement.

Expected behavior
After upgrading to Big Sur, Quicksilver is now Blue. (some black)
Screenshots
Please see attached screenshots

.
What version of macOS?
11.0.1
What version of Quicksilver?
1.6.1

Was hoping for a Turkey day surprise! Well, Happy Thanksgiving everyone! Hope to figure out what's going on...I  mean I like blue, but whoaaaa....that's blue-blue.

I don’t see this in dark or light mode with any accent color. The only weird thing I see is the black background on the sidebar.

Well, I'm going to do a clean install later today or tomorrow - nothing to
do with Quicksilver. I've even ditched the prefs and uninstalled and
reinstalled the app completely, no change.
I'll ping back once the clean install is done.
On Fri, Nov 27, 2020 at 8:23 AM Rob McBroom<EMAIL_ADDRESS>wrote:

I don’t see this in dark or light mode with any accent color. The only
weird thing I see is the black background on the sidebar.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/quicksilver/Quicksilver/issues/2537#issuecomment-734858813,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG7ULHLNUZQU7QLHWZOWSVTSR6Y77ANCNFSM4TXNIS7Q
.

Well, clean install 100%. The first software to install was Quicksilver.
1.6.1. No data transferred, zero - completely fresh.
I had hoped it would alleviate the blue...alas:
Any thoughts?
On Fri, Nov 27, 2020 at 1:45 PM Dennis<EMAIL_ADDRESS>wrote:

Well, I'm going to do a clean install later today or tomorrow - nothing to
do with Quicksilver. I've even ditched the prefs and uninstalled and
reinstalled the app completely, no change.
I'll ping back once the clean install is done.
On Fri, Nov 27, 2020 at 8:23 AM Rob McBroom<EMAIL_ADDRESS>wrote:

I don’t see this in dark or light mode with any accent color. The only
weird thing I see is the black background on the sidebar.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/quicksilver/Quicksilver/issues/2537#issuecomment-734858813,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG7ULHLNUZQU7QLHWZOWSVTSR6Y77ANCNFSM4TXNIS7Q
.

[image: Screen Shot 2020-11-27 at 6.04.36 PM.png][image: Screen Shot
2020-11-27 at 6.02.29 PM.png][image: Screen Shot 2020-11-27 at 6.02.18
PM.png][image: Screen Shot 2020-11-27 at 6.02.11 PM.png][image: Screen Shot
2020-11-27 at 6.02.05 PM.png][image: Screen Shot 2020-11-27 at 6.01.43
PM.png]
On Fri, Nov 27, 2020 at 6:13 PM Dennis<EMAIL_ADDRESS>wrote:

Well, clean install 100%. The first software to install was Quicksilver.
1.6.1. No data transferred, zero - completely fresh.
I had hoped it would alleviate the blue...alas:
Any thoughts?
On Fri, Nov 27, 2020 at 1:45 PM Dennis<EMAIL_ADDRESS>wrote:

Well, I'm going to do a clean install later today or tomorrow - nothing
to do with Quicksilver. I've even ditched the prefs and uninstalled and
reinstalled the app completely, no change.
I'll ping back once the clean install is done.
On Fri, Nov 27, 2020 at 8:23 AM Rob McBroom<EMAIL_ADDRESS>wrote:

I don’t see this in dark or light mode with any accent color. The only
weird thing I see is the black background on the sidebar.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/quicksilver/Quicksilver/issues/2537#issuecomment-734858813,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG7ULHLNUZQU7QLHWZOWSVTSR6Y77ANCNFSM4TXNIS7Q
.

I have a new M1 Machine and see exactly what Dent13 sees. It was a clean install on a new M1 machine. The purple color for this older fellow (ME) is quite difficult to read. I have tried various plugins but none have this primer view which I like and use. Hope there is a new plugin or something to allow this to change.

Mine is an Intel-based MacPro trash can. This happened with the upgrade and
then I installed a new SSD and did a full and complete fresh install of
everything - quick silver was literally first and that's the screenshot.
Blue...there's no mistaking it's QS, but I'd love to get the intended color
scheme back.
On Sat, Dec 19, 2020 at 1:14 PM thecraw<EMAIL_ADDRESS>wrote:

I have a new M1 Machine and see exactly what Dent13 sees. It was a clean
install on a new M1 machine. The purple color for this older fellow (ME) is
quite difficult to read. I have tried various plugins but none have this
primer view which I like and use. Hope there is a new plugin or something
to allow this to change.
[image: Screen Shot 2020-12-19 at 12 13 31 PM]
https://user-images.githubusercontent.com/8144489/102697530-9f46ae80-41f3-11eb-9fd9-02c0a4118685.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/quicksilver/Quicksilver/issues/2537#issuecomment-748513525,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG7ULHJ363S5GO7HNGVYBJLSVT3QZANCNFSM4TXNIS7Q
.

Same, here… blue… Keyboard triggers work (ufff), but it sounds like a kind of corona side effect

I just spit my coffee out!! Lol!!
On Sun, Dec 20, 2020 at 4:00 PM juanfal<EMAIL_ADDRESS>wrote:

Same, here… blue… Keyboard triggers work (ufff), but it sounds like a kind
of corona side effect
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/quicksilver/Quicksilver/issues/2537#issuecomment-748676720,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG7ULHJS3Y6QOQAHZIUT5RDSVZXYZANCNFSM4TXNIS7Q
.

Same here. Clean install Quicksilver version 1.6.1 on M1 MBP. Hope there is new update :)

hi! blue on my M1 Mac mini too.

I was able to fix this by toggling the Accent Color in System Preferences -> General. ¯_(ツ)_/¯

I've tried everything....
On Thu, Dec 31, 2020 at 12:56 PM J. Greg Williams<EMAIL_ADDRESS>wrote:

I was able to fix this by toggling the Accent Color in System Preferences
-> General. ¯_(ツ)_/¯
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/quicksilver/Quicksilver/issues/2537#issuecomment-753027015,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG7ULHMSGNNIGXG5X5IEFPDSXTCPRANCNFSM4TXNIS7Q
.

I've tried everything....
On Thu, Dec 31, 2020 at 12:56 PM J. Greg Williams<EMAIL_ADDRESS>wrote:

I was able to fix this by toggling the Accent Color in System Preferences
-> General. ¯_(ツ)_/¯
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/quicksilver/Quicksilver/issues/2537#issuecomment-753027015,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG7ULHMSGNNIGXG5X5IEFPDSXTCPRANCNFSM4TXNIS7Q
.

Same problem here. Accent color switch did nothing.

I keep trying other apps, and coming back to Quicksilver ... but this is upsetting. It feels like lame thing to keep me from using it ... but ... I hope someone can figure it out.
But yeah, on my new M1 MacBook Pro ... all blue all the time :(

I was not a real power user of it but did like it and textexpander so I
just bought Alfred with the powerpack and it works perfect for me. Will on
some older machines still use Quicksilver but for a launcher Alfred works
great and works fine on an M1 as well.
On Sun, Mar 7, 2021 at 7:42 AM Rob Cherny<EMAIL_ADDRESS>wrote:

I keep trying other apps, and coming back to Quicksilver ... but this is
upsetting. It feels like lame thing to keep me from using it ... but ... I
hope someone can figure it out.
But yeah, on my new M1 MacBook Pro ... all blue all the time :(
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/quicksilver/Quicksilver/issues/2537#issuecomment-792289947,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB6EM2LGA42LDTX6BD6KHVLTCOGGNANCNFSM4TXNIS7Q
.

--
Regards
Tom Wilkinson<PHONE_NUMBER>

I have found that using the "White Bezel" interface and turning off "Bezels are glass" makes the interface mostly useable (i.e. not blue). The main configuration window (Preferences/Catalog/Trigger/Plugins) is still a challenge to use, but do able. The Clipboard History plugin is mostly useable as well, although the top and bottom has a blue rectangle.

The Nostromo interface is unaffected as well (except for the Results List occasionally, but I usually have that set to show manually because the first result is almost always right).

Here's some screenshots. Currently on macOS Monterey V12.0.1. Whenever I select different headings, the color will change to either black or blue. On the Catalog side specifically, other headings get highlighted as well.

@TurtleDino -- Can you give even more details?

What hardware are you running?
What quicksilver version are you running?
What interface are you using?

Noticed the same (and wanted to give fixing it a try): MacBook Pro (14-inch, 2021), macOS Monterey 12.0.1 (21A559)

,

My prefs are fine, but like @DivineDominion I have a funky color in the filtering and status rows of the bezel:

Repeatable color changes after a QS reset
BigSur 12.1 (21C52), QS 1.6.1 (4026)
After a QS reset (it had become slow) the blue and more are still there. So… pinning this down menu-by-menu:

Guide: fine
General: fine on the first submenu that appears, BLUE on clicking the second submenu, then no more blue after that for any submenu
Triggers: all BLUE, with unpredictable orange menu backgrounds (behaves like a broken toggle)
Catalog: all BLUE, with unpredictable pale blue menu backgrounds (behaves like a broken toggle), plus occasional and unpredictable (so sorry, the worst kinda bug) BLACK background but only occurring when swapping back to QS after using another app for a few seconds (Safari in this case)
Plugins: all BLUE, with unpredictable purple menu backgrounds (behaves like a broken toggle)

Hope that helps narrow this down. Seems like two, possibly three issues:

menu pane background (blue) on app and section swapping/redrawing?
menu item background toggle (showing orange, pale blue, purple)
Catalog menu pane background (black) on app swapping

but OFC I'm only guessing!

I still on Mojave so can't debug, but perhaps a couple of things you could check @n8henrie if possible:

Try increasing the deployment target to macOS 12.1 and test - does it fix the problem?

Check the 'Builds for' option for the xibs (E.g. Primer.xib) - if you update that to a higher version, does it fix the problem?

Try the last option/steps in this thread

Update Xcode to the latest version and re-build, as per suggestions in this thread

Can those in this thread who are facing this issue please try to toggle the various 'Appearance' preferences here, to try and pinpoint exactly which setting is causing this issue. If toggling one of those fixes the blue for either the prefs/QS interface, then please share:

Bezels are glass definitely messes up the bezel interface, so i've had it turned off. But the prefs sidebar pane is still blue for me.

 But the prefs sidebar pane is still blue for me.

So are you saying that if you turn off 'Bezels are glass', then the Bezel interface works fine, without issue? Let's focus on the Bezel interface first, then we can look at the prefs afterwards.

I tried toggling all of those, no effect for me on Monterey:

I have no issues in the prefs (dark mode here though):

With it on:

With it off:

Same problem here. Clean installation on M1 Mac Mini. Accent color switch did nothing.

Can report that I'm now on M1 Air with Big Sur and have zero issues with QS except when switching to Bezels and turning on Bezels are glass – then the Bezels interface turns blue.

On M1 MBP, Monterey, the Bezel/Primer UI itself looks fine, but the fold-out window has broken headers and footers
Screenshots without window shadow (make it rather hard to see where the windows end, sorry):

Nothing fancy turned on:

Bezels are glass definitely messes up the bezel interface

@Proggie What gets messed up? I reset to "Defaults" for colors, enabled glass, and restarted QS.

I have some issues with overwriting letters this way:

But the catalog looks like this either way:

@n8henrie It's not supposed to look so transparent. It's been a long time since I've seen it look how it's supposed to, so don't recall exactly how it's supposed to look, but I believe it's supposed to be more grey, like the one with the setting turned off, but more shiny.

@pjrobertson

Try increasing the deployment target to macOS 12.1 and test - does it fix the problem?

No change for me, catalog sidebar still black (see above).

Check the 'Builds for' option for the xibs (E.g. Primer.xib) - if you update that to a higher version, does it fix the problem?

Interestingly, one of the xibs is crashing XCode for me (just selecting it). That seems bad.

Update Xcode to the latest version and re-build, as per suggestions in this thread

I'm on 13.2.1

Try the last option/steps in this thread

Will look at this next.

“QSHelpersPrefPane.xib” uses an older format that is potentially insecure when decoded.

Choosing to go ahead and upgrade it (it prompts you automatically) completely crashes Xcode.
Changed all of the other xibs to MacOS 12.0 and later  -- catalog sidebar still black.

I’m pretty sure this is the fault of some code in [QSBackgroundView drawRect], but it’s over my head. I’d be fine to just rip it out and replace the background view with something more standard, but I’m not sure what that is.

you could try commenting-out QSFillRectWithGradientFromEdge calls to see if the gradient is the culprit. The NSRectFill calls look rather standard. To start, I suggest trying a plain color to see if this is indeed the problem:
- (void)drawRect:(NSRect)rect {
    [[NSColor yellowColor] set];
    NSRectFill(rect);
    return;
    // ... rest of the  original implementation is bypassed ...
}

I would do this myself but I'm still having trouble building the project, so this is probably easier :)

you could try commenting-out QSFillRectWithGradientFromEdge calls

No change

To start, I suggest trying a plain color to see if this is indeed the problem:

Makes the main area yellow, but the triggers and catalog sidebar are still like this.

The crash with QSHelpersPrefPane.xib is bugging me. Can anyone else reproduce it? That's the only one I can't examine to see if it looks familiar.

Does the view debugger reveal anything useful? The "exploded" 3D view could be helpfu

That's kind of cool, but I get "Unable to capture the view hierarchy." It just points me to QSFancyOutlineView as the most superficial layer.
I've been focusing on QSPlugInsPrefPane.xib; if I delete the sidebar completely, it deletes the problematic view in Preferences -> Triggers, so I think this is the right component to look at (for starters). However, changing all of the colors I see in this view or its children show no difference in what I see (after stop -> clean -> run).
OK QSFillRectWithGradientFromEdge does seem to do something; plugging in the "fill with yellow and early return" code from above into its definition in QSShading.m does fill even the sidebars with yellow.
But looking back as QSFancyOutlineView in QSFancyTableView.m, commenting it out at #90 or changing lighterColor or backgroundColor doesn't seem to do anything.
Cleaning up a few deprecated color-related calls also didn't help.
Pre-night-shift nap time.

Now that QSBackgroundView and QSGlossyBar have been stripped, @skurfer or @n8henrie  - can you try building a new release and sharing it here for people to test this issue?

Better -- sidebar is still black, but I can see the text now (as opposed to above).
The horizontal lines are intense and unattractive though.

Should be able to use the artifact from https://github.com/quicksilver/Quicksilver/actions/runs/1837022099

OK, so blue colour is fixed? I think the issue you are referring to here with colours for the Dark Interface. This is an issue, but unrelated to the 'Blue' issue above.
That should go in a new issue called 'Dark Mode' and is easy enough to fix. I can do that. Issue is here: #2638
@DivineDominion @palpha @Proggie  - are you able to download the latest build of Quicksilver from here and test it and report back?

Mine was blue initially (about a year ago), but then turned to black (@TurtleDino's right below mine looks similar). At some point I reset the default color palette (in Appearance), which is what I thought changed it.
So I guess you're right, I'd been assuming this was the same issue, but it be that the blue resolved itself, and a few of us are mixing it up with a second issue.
This is with light mode on, the sidebar background looks unchanged (but your changed made it so the text is visible).

OK, so blue colour is fixed?

I think @Proggie is the most recent screenshot with Blue. I haven't been able to reproduce the blue in a while.

Will try testing tonight/tomorrow

@Proggie @n8henrie  - please try testing this version, when you get a chance: https://github.com/quicksilver/Quicksilver/suites/5324782081/artifacts/165906056
It's the build from this pull request, which fixes dark colours

That's it!
General / Triggers / Catalog look great, Plugins is a shade darker than the others. Definitely not black anymore though.

.

Yeah I see that plugins slightly darker thing. Will take another look

Yes, blue is gone for me!

The Looks pretty good! Since I'm late, I then also tested the latest build product form the actions overview: https://github.com/quicksilver/Quicksilver/actions/runs/1851338163
Blue is gone in the QS action window:

Also gone from the main prefs:

Black sidebar with black text still present in triggers, catalog, plugins:

Great to hear and thanks all for your updates!
@DivineDominion  - I think those screenshots are of the old version of Quicksilver. Double check which version you're running! I say so because the Triggers highlight colour should no longer be yellow, but blue.
Please try the latest build over at https://github.com/quicksilver/Quicksilver/actions/runs/1852250098 and confirm.
I am going to close this issue now, and mark the "It's blue!" issue as fixed. Most likely fixed by #2601

If the 'blue' issue still occurs, then please re-open this.
However, for black/white colour issues, then please post them over on #2638

Thank you @pjrobertson - much appreciated.

Blue bars also disappeared for me. Thank you!

I'm guessing the "Bezels are glass" setting issue is a separate bug?

I'm guessing the "Bezels are glass" setting issue is a separate bug?

Thanks for bringing that up. Are you saying that it's still an issue if you enable 'Bezels are glass', even with the latest build? If so, please open another issue and post screenshots there of the problem.
Thanks

Thanks for the update @codeanpeace - I believe this is the same issue as listed in #2668
@skurfer  - perhaps we should merge into 2.0.0 after all.


karpenter cannot delete nodes it creates

Description
Working from the provided examples, karpenter is not authorized to terminate nodes that it creates:
{"level":"ERROR","time":"2023-12-29T02:30:04.633Z","logger":"controller","message":"Reconciler error","commit":"1072d3b","controller":"nodeclaim.termination","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","NodeClaim":{"name":"apps-286mm"},"namespace":"","name":"apps-286mm","reconcileID":"a1b3e582-59ff-4a45-8028-353d9a8f4a60","error":"terminating cloudprovider instance, terminating instance, UnauthorizedOperation: You are not authorized to perform this operation. User: arn:aws-us-gov:sts::010101010101:assumed-role/karpenter-2023122816191916920000002a/1703816478897385861 is not authorized to perform: ec2:TerminateInstances on resource: arn:aws-us-gov:ec2:us-gov-east-1:010101010101:instance/i-0259489c08f5f6091 because no identity-based policy allows the ec2:TerminateInstances action. Encoded authorization failure message: ..."}

I found the policy, added the ec2:TerminateInstances to it and a few minutes later the node was terminated.
Terraform wanted to restore the config, of course:
  # module.eks_blueprints_addons.module.karpenter.aws_iam_policy.this[0] will be updated in-place
  ~ resource "aws_iam_policy" "this" {
        id          = "arn:aws-us-gov:iam::010101010101:policy/karpenter-20231228161917140000000022"
        name        = "karpenter-20231228161917140000000022"
      ~ policy      = jsonencode(
          ~ {
              ~ Statement = [
                  ~ {
                      ~ Action   = [
                            # (8 unchanged elements hidden)
                            "ec2:DescribeAvailabilityZones",
                          - "ec2:TerminateInstances",
                        ]
                        # (2 unchanged attributes hidden)
                    },
                    {
                        Action   = [
                            "ec2:RunInstances",
                            "ec2:DeleteLaunchTemplate",
                            "ec2:CreateTags",
                            "ec2:CreateLaunchTemplate",
                            "ec2:CreateFleet",
                        ]
                        Effect   = "Allow"
                        Resource = [
                            "arn:aws-us-gov:ec2:us-gov-east-1::image/*",
                            "arn:aws-us-gov:ec2:us-gov-east-1:010101010101:*",
                        ]
                    },
                    # (7 unchanged elements hidden)
                ]
                # (1 unchanged attribute hidden)
            }
        )
        tags        = {}
        # (6 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Please add ec2:TerminateInstances to the policy.
⚠ Note
Removed the local .terraform directory and re-initialized.
Versions
% terraform version
Terraform v1.6.3
on darwin_arm64
+ provider registry.terraform.io/hashicorp/aws v5.25.0
+ provider registry.terraform.io/hashicorp/cloudinit v2.3.3
+ provider registry.terraform.io/hashicorp/helm v2.12.1
+ provider registry.terraform.io/hashicorp/kubernetes v2.24.0
+ provider registry.terraform.io/hashicorp/time v0.10.0
+ provider registry.terraform.io/hashicorp/tls v4.0.5

Module version [Required]:

  source  = "aws-ia/eks-blueprints-addons/aws"
  version = "~> 1.12.0"

Reproduction Code [Required]
module "eks_blueprints_addons" {
  source  = "aws-ia/eks-blueprints-addons/aws"
  version = "~> 1.12.0" #ensure to update this to the latest/desired version

  # Any addon from this page can be added to the below block
  # https://docs.aws.amazon.com/eks/latest/userguide/eks-add-ons.html#workloads-add-ons-available-eks
  eks_addons = {
    aws-ebs-csi-driver = {
      most_recent                 = true
      service_account_role_arn    = module.ebs_csi_driver_irsa.iam_role_arn
      resolve_conflicts_on_create = "OVERWRITE"
    }
    coredns = {
      most_recent                 = true
      resolve_conflicts_on_create = "OVERWRITE"
    }
    kube-proxy = {
      most_recent                 = true
      resolve_conflicts_on_create = "OVERWRITE"
    }
    vpc-cni = {
      most_recent              = true
      service_account_role_arn = module.vpc_cni_irsa.iam_role_arn
      before_compute           = true
      configuration_values = jsonencode({
        env = {
          ENABLE_PREFIX_DELEGATION = "true"
          WARM_PREFIX_TARGET       = "1"
        }
      })
    }
    snapshot-controller = {
      most_recent                 = true
      resolve_conflicts_on_create = "OVERWRITE"
    }
  }

  eks_addons_timeouts = {
    create = "6m"
    update = "1m"
    delete = "1m"
  }

  # --------------------------------------------------------------------------------------------------------------------
  # Auto-Scaling
  # karpenter: https://aws-ia.github.io/terraform-aws-eks-blueprints/patterns/karpenter/
  # --------------------------------------------------------------------------------------------------------------------
  enable_karpenter                           = true
  karpenter_enable_spot_termination          = true
  karpenter_enable_instance_profile_creation = true
  #enable_cluster_proportional_autoscaler = false # horizontal "pod" autoscaler

  # --------------------------------------------------------------------------------------------------------------------
  # Observability Support
  # --------------------------------------------------------------------------------------------------------------------
  enable_metrics_server = true

  # --------------------------------------------------------------------------------------------------------------------
  # Storage: Secrets and Volumes
  # --------------------------------------------------------------------------------------------------------------------
  # Adding support for Lustre Volumes
  enable_aws_fsx_csi_driver = true
  # Adding support for Kubernetes Secrets Management
  enable_secrets_store_csi_driver              = true
  enable_secrets_store_csi_driver_provider_aws = true # see docs/storage for more configuration support
  # Further configuration support is here:
  # https://github.com/aws-ia/terraform-aws-eks-blueprints-addons/blob/99520ae0125df7b24163e14cf4eba2c96fcf14bd/docs/addons/secrets-store-csi-driver-provider-aws.md

  # --------------------------------------------------------------------------------------------------------------------
  # Load Balancing Support for EKS
  # --------------------------------------------------------------------------------------------------------------------
  enable_aws_load_balancer_controller = true

  # --------------------------------------------------------------------------------------------------------------------
  # cert-manager
  # tf state show data.aws_route53_zone.selected (for details)
  # --------------------------------------------------------------------------------------------------------------------
  #enable_cert_manager                   = true
  #cert_manager_route53_hosted_zone_arns = [data.aws_route53_zone.selected.arn]

  # Cluster COMMs
  cluster_name      = module.eks.cluster_name
  cluster_endpoint  = module.eks.cluster_endpoint
  cluster_version   = module.eks.cluster_version
  oidc_provider_arn = module.eks.oidc_provider_arn
}

Steps to reproduce the behavior:

Not using workspaces.

The local cache has been cleared.

Expected behavior
The expectation is that the policy attached should ultimately be granted access to ec2:TerminateInstances, by some means.

Actual behaviour
Karpenter can find/provision nodes, albeit slowly. When it comes time to scale down the logs are filled with complaints about how ec2:TerminateInstances is required.

Terminal Output Screenshot(s)

Additional context

I've pivoted the same TF code to a commercial account: success; the karpenter blueprint works in non-government accounts.
Now, to solve for government accounts...

karpenter is not authorized to terminate nodes that it creates

Just looking over the policy, I'd recommend setting up the TerminateInstance policy to reference the kubernetes.io/cluster/<cluster-name> tags rather than using the name of the instance. A good example of doing this is found in the official Karpenter policy that's associated with the CloudFormation template in the Getting Started Guide.
The reason why using the Name tag is so problematic is because it requires the nodes to always join. Karpenter changes the name of the Name tag to match the node name as soon as a node joins the cluster; however, if the node never joins, Karpenter will never get permission to terminate the instance. On top of this, the other issue is that the current blueprint defaults don't scope the policy to only allow the karpenter controller to terminate instances associated with its cluster. Right now, it's possible to delete any instance across all clusters that karpenter has tagged.
@bryantbiggs and I have discussed a bit on how this could be changed. I know that there was some cautiousness around changing this right now since it would be a breaking change for users, but given the fact that the current defaults for the policy don't work correctly in all scenarios, I wonder if we just bit the bullet and change the defaults now so that users get something closer to the official policy.

@jonathan-innis it's really as simple as this
  enable_karpenter                           = true
  karpenter_enable_spot_termination          = true
  karpenter_enable_instance_profile_creation = true

I don't have any control over it after that AFAIK. If there's an example of how to do this I'll code it up.

@vstthomas I believe this does what Jonathan is describing:
  enable_karpenter                           = true
  karpenter_enable_spot_termination          = true
  karpenter_enable_instance_profile_creation = true

  karpenter = {
    irsa_tag_key   = "aws:ResourceTag/kubernetes.io/cluster/<cluster-name>"
    irsa_tag_value = "*"
  }

Note: you will need to replace <cluster-name> with the name of your cluster

@bryantbiggs this must have been for https://github.com/aws/karpenter-provider-aws/issues/5432. We've been juggling a few; confusing, I know.
Anyway, the above solution fixes the token issue; case closed.
However, this one persists.

I manually added "ec2:TerminateInstances" to the below policy and the node was killed:
{
    "Statement": [
        {
            "Action": [
                "ec2:DescribeSubnets",
                "ec2:DescribeSpotPriceHistory",
                "ec2:DescribeSecurityGroups",
                "ec2:DescribeLaunchTemplates",
                "ec2:DescribeInstances",
                "ec2:DescribeInstanceTypes",
                "ec2:DescribeInstanceTypeOfferings",
                "ec2:DescribeImages",
                "ec2:DescribeAvailabilityZones",
                "ec2:TerminateInstances" <-  How does this get injected into the policy?
            ],
            "Effect": "Allow",
            "Resource": "*"
        },
        {
            "Action": [
                "ec2:RunInstances",
                "ec2:DeleteLaunchTemplate",
                "ec2:CreateTags",
                "ec2:CreateLaunchTemplate",
                "ec2:CreateFleet"
            ],
            "Effect": "Allow",
            "Resource": [
                "arn:aws-us-gov:ec2:us-gov-east-1::image/*",
                "arn:aws-us-gov:ec2:us-gov-east-1:367652197469:*"
            ]
        },
        {
            "Action": "iam:PassRole",
            "Effect": "Allow",
            "Resource": "arn:aws-us-gov:iam::367652197469:role/karpenter-gitops-demo-stage"
        },
        {
            "Action": "pricing:GetProducts",
            "Effect": "Allow",
            "Resource": "*"
        },
        {
            "Action": "ssm:GetParameter",
            "Effect": "Allow",
            "Resource": "arn:aws-us-gov:ssm:us-gov-east-1::parameter/*"
        },
        {
            "Action": "eks:DescribeCluster",
            "Effect": "Allow",
            "Resource": "arn:aws-us-gov:eks:*:367652197469:cluster/gitops-demo-stage"
        },
        {
            "Action": "ec2:TerminateInstances",
            "Condition": {
                "StringLike": {
                    "ec2:ResourceTag/aws:ResourceTag/kubernetes.io/cluster/gitops-demo-stage": [
                        "*karpenter*",
                        "*compute.internal",
                        "*ec2.internal"
                    ]
                }
            },
            "Effect": "Allow",
            "Resource": "arn:aws-us-gov:ec2:us-gov-east-1:367652197469:instance/*"
        },
        {
            "Action": [
                "sqs:ReceiveMessage",
                "sqs:GetQueueUrl",
                "sqs:GetQueueAttributes",
                "sqs:DeleteMessage"
            ],
            "Effect": "Allow",
            "Resource": "arn:aws-us-gov:sqs:us-gov-east-1:367652197469:karpenter-gitops-demo-stage"
        },
        {
            "Action": [
                "iam:TagInstanceProfile",
                "iam:RemoveRoleFromInstanceProfile",
                "iam:GetInstanceProfile",
                "iam:DeleteInstanceProfile",
                "iam:CreateInstanceProfile",
                "iam:AddRoleToInstanceProfile"
            ],
            "Effect": "Allow",
            "Resource": "*"
        }
    ],
    "Version": "2012-10-17"
}

Please advise how to update this policy with "ec2:TerminateInstances".

Apologies, I provided you the wrong syntax. Below is the correct syntax:
  enable_karpenter                           = true
  karpenter_enable_spot_termination          = true
  karpenter_enable_instance_profile_creation = true

  karpenter = {
    irsa_tag_key   = "aws:ResourceTag/kubernetes.io/cluster/<cluster-name>"
    irsa_tag_values = ["*"]
  }

Once you utilize that, you do not need to manually add the "ec2:TerminateInstances" as you have shown directly above

The suggested config nets this effect:
        {
            "Action": "ec2:TerminateInstances",
            "Condition": {
                "StringLike": {
                    "ec2:ResourceTag/aws:ResourceTag/kubernetes.io/cluster/gitops-demo-stage": [
                        "*karpenter*",
                        "*compute.internal",
                        "*ec2.internal"
                    ]
                }
            },
            "Effect": "Allow",
            "Resource": "arn:aws-us-gov:ec2:us-gov-east-1:<PHONE_NUMBER>01:instance/*"
        },

We should be matching on 2 of the 3 StringLike tags:
% aws ec2 describe-instances --instance-ids i-005e9045bd50eeea7 | jq -r '.Reservations[].Instances[].Tags'
[
  {
    "Key": "aws:ec2launchtemplate:id",
    "Value": "lt-055f1400d72882e80"
  },
  {
    "Key": "karpenter.k8s.aws/ec2nodeclass",
    "Value": "apps"
  },
  {
    "Key": "aws:eks:cluster-name",
    "Value": "gitops-demo-stage"
  },
  {
    "Key": "karpenter.sh/managed-by",
    "Value": "gitops-demo-stage"
  },
  {
    "Key": "aws:ec2:fleet-id",
    "Value": "fleet-6d1f3705-a2af-6616-a49a-8780952927f0"
  },
  {
    "Key": "karpenter.sh/nodeclaim",
    "Value": "apps-ntlfx"
  },
  {
    "Key": "kubernetes.io/cluster/gitops-demo-stage",
    "Value": "owned"
  },
  {
    "Key": "Name",
    "Value": "ip-10-101-42-249.us-gov-east-1.compute.internal"
  },
  {
    "Key": "karpenter.sh/nodepool",
    "Value": "apps"
  },
  {
    "Key": "aws:ec2launchtemplate:version",
    "Value": "1"
  }
]

So we're clear, this is the module address where I'm seeing the change:
tf state show module.eks_blueprints_addons.module.karpenter.aws_iam_policy.this\[0\]
it's just not proc'ing for some reason.

Can you provide a reproduction? Here is the config I just deployed, which represents the default/out of box config:
module "eks_blueprints_addons" {
  source = "aws-ia/eks-blueprints-addons/aws"
  version = "~> 1.12"

  cluster_name      = module.eks.cluster_name
  cluster_endpoint  = module.eks.cluster_endpoint
  cluster_version   = module.eks.cluster_version
  oidc_provider_arn = module.eks.oidc_provider_arn

  enable_karpenter                           = true
  karpenter_enable_instance_profile_creation = true
}

And changing to the guidance provided above:
module "eks_blueprints_addons" {
  source = "aws-ia/eks-blueprints-addons/aws"
  version = "~> 1.12"

  cluster_name      = module.eks.cluster_name
  cluster_endpoint  = module.eks.cluster_endpoint
  cluster_version   = module.eks.cluster_version
  oidc_provider_arn = module.eks.oidc_provider_arn

  enable_karpenter                           = true
  karpenter_enable_instance_profile_creation = true
  # Added configuration show below
  karpenter = {
    irsa_tag_key    = "aws:ResourceTag/kubernetes.io/cluster/gitops-demo-stage"
    irsa_tag_values = ["*"]
  }
}

Now yields this diff which is the expected outcome
 ~ {
    ~ Condition = {
        ~ StringLike = {
            - "ec2:ResourceTag/Name"                                           = [
                - "*karpenter*",
                - "*compute.internal",
                - "*ec2.internal",
              ] -> null
            + "ec2:ResourceTag/aws:ResourceTag/kubernetes.io/cluster/gitops-demo-stage" = "*"
          }
      }
      # (3 unchanged elements hidden)
  },


how can  I lock horizontal swipe?

I need to lock the horizontal swipe ,or I need to find a way such that the draggable panel will not disappear when I swipe left or right.

Comment out the clampViewPositionHorizontal override method.


Fixed bug when resolving a project root directory when there's no global.json file.

Environment

Operating system: Windows 7 Enterprise 64-bit.
Node: v4.2.2
yo: 1.5.0
generator-aspnet: 0.0.90
.NET environment: 1.0.0-rc1-final coreclr x64 win
dnx-watch: 1.0.0-rc1-final

Steps to reproduce

Create a test directory and restore packages

mkdir test
cd test

Create a class library

yo aspnet
cd ClassLibrary
dnu restore
cd ..

Edit ~/test/ConsoleApplication/project.json as follows:

{
  (...)

  "dependencies": {
    "ClassLibrary": ""
  },

  (...)
}

Restore packages.

dnu restore

Attempt to run dnx-watch

dnx-watch run

You will get an error similar to the following:

System.ArgumentException: The directory name C:\test\ClassLibrary\project.json is invalid.
Parameter name: path
   at System.IO.FileSystemWatcher..ctor(String path, String filter)
   at Microsoft.Dnx.Watcher.Core.FileWatcher.AddWatcher(String path)
   at Microsoft.Dnx.Watcher.Core.DnxWatcher.AddProjectAndDependeciesToWatcher(IProject project, IFileWatcher fileWatcher)
   at Microsoft.Dnx.Watcher.Core.DnxWatcher.AddProjectAndDependeciesToWatcher(IProject project, IFileWatcher fileWatcher)
   at Microsoft.Dnx.Watcher.Core.DnxWatcher.<WaitForProjectFileToChangeAsync>d__7.MoveNext()

Create a ~/test/global.json file:

{
  "projects": [
    "ClassLibrary",
    "ConsoleApplication"
  ]
}

Attempt to run dnx-watch again.

Hi @marcogrcr, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@victorhurdugaci Could you have a look?

Any update, @victorhurdugaci?

Sorry for delaying this. We're in the process of converting dnx-watch to dotnet-watch and I will take a look at this as part of that work.

No problem. I fixed the issue by moving my global.json, but a "proper" fix would certainly be good.

@mariusschulz  thanks for the contribution but after the migration to dotnet and the big rewrite the I have as PR, this bug will not happen anymore. I will close this issue.


[T2A2][F11-A1] Louie Tan Yi Jie

T2A2-L0-Refactor
Allegedly improves code quality.

Ready for review.

Great Job refactoring and especially focusing on Constants extraction! Though more refactoring could be done as shared during the tutorial (e.g. Violations on more Java Coding standards, using switches etc.) Feel free to add more changes and create another pull request if you want and I can review it again :)


Removed self.versions from kytos/of_core

Removed the attribute versions from kytos/of_core/main.py to
kytos/of_core/settings.py
Fix #257

@diraol @macartur Is this a refact or is this breaking something ?

I'm accepting this... please check if #257 persists. If yes, please reopen the issue.


make diagnostics and other convenience make targets

Closes #1112
Overview
Add a few convenience make targets for docker-compose usage and diagnostics
Changes
Added:

make docker-nuke: wipe docker clean
make docker-remote-watcher: remote console into the watcher application
make docker-remote-childchain remote console into the childchain application
make diagnostics: generate all diagnostics info for troubleshooting

Testing
Try the 4 commands above. make diagnostics look like this:
$ make diagnostics
---------- START OF DIAGNOSTICS REPORT ----------

---------- CHILDCHAIN LOGS ----------
Attaching to elixir-omg_childchain_1
childchain_1        | [services.d] starting services
childchain_1        | [services.d] done.
childchain_1        | 2019-11-08 06:44:18.749 [warn] module=OMG.DB.ReleaseTasks.InitKeyValueDB function=process/1 ⋅Creating database at "/app/.omg/data/child_chain"⋅
...
childchain_1        | [cont-finish.d] executing container finish scripts...
childchain_1        | [cont-finish.d] done.
childchain_1        | [s6-finish] syncing disks.
childchain_1        | [s6-finish] sending all processes the TERM signal.
childchain_1        | [s6-finish] sending all processes the KILL signal and exiting.

---------- WATCHER LOGS ----------
Attaching to elixir-omg_watcher_1
watcher_1           | [services.d] starting services
watcher_1           | [services.d] done.
watcher_1           | The database for OMG.Watcher.DB.Repo has already been created
watcher_1           | Running migration for OMG.Watcher.DB.Repo...
watcher_1           | 2019-11-08 06:44:50.537 [info] module=Ecto.Migration.Runner function=log/2 ⋅== Running<PHONE_NUMBER>1000 OMG.Watcher.Repo.Migrations.CreateBlockTable.change/0 forward⋅
...
watcher_1           | [cont-finish.d] executing container finish scripts...
watcher_1           | [cont-finish.d] done.
watcher_1           | [s6-finish] syncing disks.
watcher_1           | [s6-finish] sending all processes the TERM signal.
watcher_1           | [s6-finish] sending all processes the KILL signal and exiting.

---------- PLASMA CONTRACTS ----------
Could not retrieve the deployed plasma contracts.

---------- GIT ----------
Git commit: 623c8f44ef3a2532928781cb53d03bd159da2ccd
On branch 1112-diagnostics-report
Your branch is up to date with 'origin/1112-diagnostics-report'.

nothing to commit, working tree clean

---------- DOCKER-COMPOSE CONTAINERS ----------
            Name                           Command                State     Ports
---------------------------------------------------------------------------------
elixir-omg_childchain_1         /init /child_chain_entrypo ...   Exit 0
elixir-omg_geth_1               /bin/sh -c apk add --updat ...   Exit 137
elixir-omg_plasma-contracts_1   docker-entrypoint.sh /bin/ ...   Exit 137
elixir-omg_postgres_1           docker-entrypoint.sh postgres    Exit 0
elixir-omg_watcher_1            /init /watcher_entrypoint  ...   Exit 0

---------- DOCKER CONTAINERS ----------
CONTAINER ID        IMAGE               COMMAND             CREATED             STATUS              PORTS               NAMES

---------- DOCKER IMAGES ----------
REPOSITORY                                        TAG                 IMAGE ID            CREATED             SIZE
omisego/watcher                                   latest              93a111bef9d4        18 hours ago        107MB
omisego/child_chain                               latest              a11bfda22404        18 hours ago        100MB
omisegoimages/elixir-omg-tester-plasma-deployer   dev-247d0e3         b63b2896bea1        2 days ago          827MB
postgres                                          9.6.13-alpine       3a287cde9b3b        5 months ago        37.7MB
ethereum/client-go                                v1.8.27             0a164fe762ba        6 months ago        39.9MB

 ---------- END OF DIAGNOSTICS REPORT ----------

Coverage remained the same at ?% when pulling 6c2cfe1ec052f816e30c79e5ea8fce00ea096c68 on 1112-diagnostics-report into 288326bb487189453df2bb561f01289e156ee190 on master.


update classrooms struct to api specification

Ticket: https://seng499-b01-company2.atlassian.net/jira/software/projects/C2/boards/1?selectedIssue=C2-47
This PR introduces the following changes:

Adds Token based authentication will access to All classrooms endpoints
Adds role-based access using jwt to admins for PUT, POST and DELETE.
Updates the classroom's struct to meet the API specification.

Hey Vibhu, I think all you need to do to pass the tests is just update the classroom_test file so that it no longer expects the equipment field.

@jakecomp done. I have fixed the tests.

Good to go!


look for slots from today

Few of the hospitals offer their slots early in the morning for the same day. The current script starts looking for slots from tomorrow, so we will need to change "check_calendar_by_district" and "check_calendar_by_pincode" to "today" instead of "tomorrow".

FYI: to make it work for now until @pallupz gets a chance to change, here are the steps to make it work:
in the functions "check_calendar_by_district" and "check_calendar_by_pincode", create a new variable:
now = (today + datetime.timedelta(days=0)).strftime("%d-%m-%Y")
Replace "today" to "now" in this line in both the function mentioned above:
resp = requests.get(base_url.format(location['district_id'], now), headers=request_header)
and if you prefer, you change it in the print statement too.

did it work?

@bitshiftr if i am using a windows exe, how can i make it to work with new code.
the exe was built using the old code that was released. any ideas?

You will need to make the code changes and recompile it as an exe. I don't
use Windows, so can't help you with that.
On Thu, May 6, 2021 at 10:37 AM, sixfooter @.***> wrote:

@bitshiftr https://github.com/bitshiftr if i am using a windows exe,
how can i make it to work with new code.
the exe was built using the old code that was released. any ideas?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pallupz/covid-vaccine-booking/issues/58#issuecomment-833227681,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMPUEBUCIBS7HOEUF2IL7WTTMIPXLANCNFSM44GBY7IA
.

sure, thanks, i did the changes but not sure how to recompile it. @pallupz , could you please list it for new users like me.

@sixfooter you'd need pyinstaller package and run ```pyinstaller --onfile <yourfile.py>

thanks @pallupz , could you please ack if this is correct  :

I could also use this in windows as well?
In case of unix, i wouldnt then need to do a sudo [ as the co. policies may come in the way ] and still get the exe to compile?

I use windows and it runs

@bitshiftr I have implemented date selection feature if you're still looking for it

is this in the latest push? For the auto-booking branch, I am still seeing that last push was 14 hours ago

main branch

all updates from now on will be on main. its difficult to maintain two branches


Small visual nit-pick - nested groups missing padding

Bug Report
Nested groups show no padding between each other.
The structure on the image is:
group (Social Media Section) {
  - group (Facebook)
  // missing padding here :P
  - group (Instagram)
}

Steps to Reproduce

Create a group that consists of two groups.
Miss padding between the nested groups
in the Admin UI. :'(

Other Details

Hey @STR1234 — this is actually working as intended, because the top-level group spacing is quite large and can get unwieldy when you have multiple levels of groups all nested within one another.
But, what is it exactly that you'd like to see here? More top + bottom spacing? You can add that via custom styles on your group config, but there's always a chance we can tweak our internal default styles to align more closely with your expectations.
As this is not something actionable at the moment, I'll convert this to a Discussion and we can keep the conversation going there. 👍


feat: enable log filtering by severity level

Enable log filtering by severity level
Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] I have read the CONTRIBUTING document
[x] My code follows the code style of this project (npm run lint produces no warnings/errors)
[x] Any required documentation has been added
[x] I have added tests to cover my changes

This is still a draft because it would be cleaner to use the LogLevel enum exported from live-logging.ts. However, I can't get it to import correctly into either logcat.ts or logcat.test.ts.  I've created a duplicate const object in logcat.ts for now.

:tada: This PR is included in version 1.15.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Update to 1.0.128 not possible

Hello, I just wanted to install the update to 1.0.128. Unfortunately this is not possible. It aborts the installation with the following errors.

Fails for me too.

looks like i didn't understand how the postinstall was supposed to work. i'll get a fix going, since i unintentionally broke all my other packages as well...

1.0.129 fixes this

Seems good to me. Thank you!

Thx!


apt-get appears missing from the latest (and lts) tags

I have a jenkins build that uses apt-get to include some packages I need for my environment. This was working this morning but I'm having issues with it now. Whenever I try to run apt-get in my Dockerfile I get:
bash-4.3$ apt-get
bash: apt-get: command not found

Docker commands that you execute
sh-4.3# docker run -it --rm jenkins/jenkins:latest apt-get

Actual result
/usr/local/bin/jenkins.sh: line 26: exec: apt-get: not found

Expected outcome
Apt-get help message
Have you tried a non-dockerized Jenkins and get the expected outcome?
Issue isn't related to Jenkins, just the docker image for jenkins.
Output of docker version
Client:
 Version:      17.06.2-ce
 API version:  1.30
 Go version:   go1.8.3
 Git commit:   cec0b72
 Built:        Tue Sep  5 19:57:19 2017
 OS/Arch:      windows/amd64

Server:
 Version:      17.06.2-ce
 API version:  1.30 (minimum version 1.12)
 Go version:   go1.8.3
 Git commit:   cec0b72
 Built:        Tue Sep  5 19:59:19 2017
 OS/Arch:      linux/amd64
 Experimental: true

Other relevant information
I've tried this on 2 docker hosts, one windows and another a linux variant. Both have the same result.
After cloning this repo and building my own version this works fine so I suspect it was the most recent docker deploy to docker hub that somehow removed apt and possibly other utilities?
Example:
$ docker run -it --rm --user root jenkins/jenkins:lts apt-get update
/usr/local/bin/jenkins.sh: line 26: exec: apt-get: not found

$ git clone https://github.com/jenkinsci/docker.git
Cloning into 'docker'...
remote: Counting objects: 1830, done.
remote: Compressing objects: 100% (6/6), done.
remote: Total 1830 (delta 1), reused 3 (delta 0), pack-reused 1824
Receiving objects: 100% (1830/1830), 341.82 KiB | 0 bytes/s, done.
Resolving deltas: 100% (961/961), done.

$ docker build -t jenkins/jenkins:personal-test .

Reading package lists...
Building dependency tree...
Reading state information...
curl is already the newest version (7.52.1-5).
git is already the newest version (1:2.11.0-3+deb9u1).
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
 ---> e5764fefcadf
Removing intermediate container 4ec55f7558ef
Step 3/34 : ARG user=jenkins
 ---> Running in 236973d9d276
 ---> 37c7c8a4deda
Removing intermediate container 236973d9d276
Step 4/34 : ARG group=jenkins
 ---> Running in edef8673ec1b
 ---> e7de613a1f77
Removing intermediate container edef8673ec1b
Step 5/34 : ARG uid=1000
 ---> Running in 2987b638fe74
 ---> de589fad7662
Removing intermediate container 2987b638fe74
Step 6/34 : ARG gid=1000
 ---> Running in dfbb5fff2eb9
 ---> 322e6f3161d0
Removing intermediate container dfbb5fff2eb9
Step 7/34 : ARG http_port=8080
 ---> Running in 8e51aaa8e001
 ---> c955124e66cd
Removing intermediate container 8e51aaa8e001
Step 8/34 : ARG agent_port=50000
 ---> Running in f416994ea3a7
 ---> 001ecfbf7cf5
Removing intermediate container f416994ea3a7
Step 9/34 : ENV JENKINS_HOME /var/jenkins_home
 ---> Running in 34274bcd3c3b
 ---> b5a4942f4828
Removing intermediate container 34274bcd3c3b
Step 10/34 : ENV JENKINS_SLAVE_AGENT_PORT ${agent_port}
 ---> Running in 0b8d8cebf3fa
 ---> 81f60add019e
Removing intermediate container 0b8d8cebf3fa
Step 11/34 : RUN groupadd -g ${gid} ${group}     && useradd -d "$JENKINS_HOME" -u ${uid} -g ${gid} -m -s /bin/bash ${user}
 ---> Running in 9de73c218036
 ---> 9a2705eb9a51
Removing intermediate container 9de73c218036
Step 12/34 : VOLUME /var/jenkins_home
 ---> Running in 9617fa6f400d
 ---> f5c2ffb85429
Removing intermediate container 9617fa6f400d
Step 13/34 : RUN mkdir -p /usr/share/jenkins/ref/init.groovy.d
 ---> Running in cd01a7bed1b5
 ---> 68afe2523db2
Removing intermediate container cd01a7bed1b5
Step 14/34 : ENV TINI_VERSION 0.14.0
 ---> Running in b50f9a5d6b20
 ---> 95a5431d9cff
Removing intermediate container b50f9a5d6b20
Step 15/34 : ENV TINI_SHA 6c41ec7d33e857d4779f14d9c74924cab0c7973485d2972419a3b7c7620ff5fd
 ---> Running in 7eee9ce65c81
 ---> 9ffeb0f74eda
Removing intermediate container 7eee9ce65c81
Step 16/34 : RUN curl -fsSL https://github.com/krallin/tini/releases/download/v${TINI_VERSION}/tini-static-amd64 -o /bin/tini && chmod +x /bin/tini   && echo "$TINI_SHA  /bin/tini" | sha256sum -c -
 ---> Running in 19290b9d223f
/bin/tini: OK
 ---> f8774f06b5c9
Removing intermediate container 19290b9d223f
Step 17/34 : COPY init.groovy /usr/share/jenkins/ref/init.groovy.d/tcp-slave-agent-port.groovy
 ---> 80e5232cfb47
Removing intermediate container f5601fc869b2
Step 18/34 : ARG JENKINS_VERSION
 ---> Running in 2492f2da2e15
 ---> 2c7372032349
Removing intermediate container 2492f2da2e15
Step 19/34 : ENV JENKINS_VERSION ${JENKINS_VERSION:-2.60.3}
 ---> Running in 4ecc18606e8b
 ---> 7b1114fc3823
Removing intermediate container 4ecc18606e8b
Step 20/34 : ARG JENKINS_SHA=2d71b8f87c8417f9303a73d52901a59678ee6c0eefcf7325efed6035ff39372a
 ---> Running in d891e648adea
 ---> 37f6e139e98e
Removing intermediate container d891e648adea
Step 21/34 : ARG JENKINS_URL=https://repo.jenkins-ci.org/public/org/jenkins-ci/main/jenkins-war/${JENKINS_VERSION}/jenkins-war-${JENKINS_VERSION}.war
 ---> Running in f803ca3d7bde
 ---> 838838cced36
Removing intermediate container f803ca3d7bde
Step 22/34 : RUN curl -fsSL ${JENKINS_URL} -o /usr/share/jenkins/jenkins.war   && echo "${JENKINS_SHA}  /usr/share/jenkins/jenkins.war" | sha256sum -c -
 ---> Running in 6913ee8045c0
/usr/share/jenkins/jenkins.war: OK
 ---> 3fc95ba6216a
Removing intermediate container 6913ee8045c0
Step 23/34 : ENV JENKINS_UC https://updates.jenkins.io
 ---> Running in 0e5cc0fc2a13
 ---> cf8f55f01685
Removing intermediate container 0e5cc0fc2a13
Step 24/34 : ENV JENKINS_UC_EXPERIMENTAL https://updates.jenkins.io/experimental
 ---> Running in bfea22de1c09
 ---> ac17c8f3a220
Removing intermediate container bfea22de1c09
Step 25/34 : RUN chown -R ${user} "$JENKINS_HOME" /usr/share/jenkins/ref
 ---> Running in de4fe7efbaaa
 ---> 8237053f430a
Removing intermediate container de4fe7efbaaa
Step 26/34 : EXPOSE ${http_port}
 ---> Running in d69eb4a65ea4
 ---> 2ce0c0c2be8f
Removing intermediate container d69eb4a65ea4
Step 27/34 : EXPOSE ${agent_port}
 ---> Running in 831d7cb61746
 ---> f1e3ab2eff5e
Removing intermediate container 831d7cb61746
Step 28/34 : ENV COPY_REFERENCE_FILE_LOG $JENKINS_HOME/copy_reference_file.log
 ---> Running in fc5a73a2ede2
 ---> 5d0c46b98a89
Removing intermediate container fc5a73a2ede2
Step 29/34 : USER ${user}
 ---> Running in 7f2c0e775fa1
 ---> 0296c5a8de13
Removing intermediate container 7f2c0e775fa1
Step 30/34 : COPY jenkins-support /usr/local/bin/jenkins-support
 ---> 677d8010ebde
Removing intermediate container b3c5653d5f7a
Step 31/34 : COPY jenkins.sh /usr/local/bin/jenkins.sh
 ---> b5d6c6dd14be
Removing intermediate container caf8e7563645
Step 32/34 : ENTRYPOINT /bin/tini -- /usr/local/bin/jenkins.sh
 ---> Running in 0011ab2ec244
 ---> bf8c20e7fd1c
Removing intermediate container 0011ab2ec244
Step 33/34 : COPY plugins.sh /usr/local/bin/plugins.sh
 ---> 2807ec70b8c8
Removing intermediate container 8f9457b2c363
Step 34/34 : COPY install-plugins.sh /usr/local/bin/install-plugins.sh
 ---> c33eb51e3991
Removing intermediate container 4dad892957d8
Successfully built c33eb51e3991
Successfully tagged jenkins/jenkins:personal-test
SECURITY WARNING: You are building a Docker image from Windows against a non-Windows Docker host. All files and directories added to build context will have '-rwxr-xr-x' permissions. It is recommended to double check and reset permissions for sensitive files and directories.

$ docker run -it --rm jenkins/jenkins:personal-test apt-get
apt 1.4.7 (amd64)
Usage: apt-get [options] command
       apt-get [options] install|remove pkg1 [pkg2 ...]
       apt-get [options] source pkg1 [pkg2 ...]

apt-get is a command line interface for retrieval of packages
and information about them from authenticated sources and
for installation, upgrade and removal of packages together
with their dependencies.

Most used commands:
  update - Retrieve new lists of packages
  upgrade - Perform an upgrade
  install - Install new packages (pkg is libc6 not libc6.deb)
  remove - Remove packages
  purge - Remove packages and config files
  autoremove - Remove automatically all unused packages
  dist-upgrade - Distribution upgrade, see apt-get(8)
  dselect-upgrade - Follow dselect selections
  build-dep - Configure build-dependencies for source packages
  clean - Erase downloaded archive files
  autoclean - Erase old downloaded archive files
  check - Verify that there are no broken dependencies
  source - Download source archives
  download - Download the binary package into the current directory
  changelog - Download and display the changelog for the given package

See apt-get(8) for more information about the available commands.
Configuration options and syntax is detailed in apt.conf(5).
Information about how to configure sources can be found in sources.list(5).
Package and version choices can be expressed via apt_preferences(5).
Security details are available in apt-secure(8).
                                        This APT has Super Cow Powers.

cant reproduce
$ docker pull jenkins/jenkins:latest
latest: Pulling from jenkins/jenkins
Digest: sha256:1cbbf440eab4b02f2eb86f08d6c004f0322be2b0fae86599da8fd4716d421f61
Status: Image is up to date for jenkins/jenkins:latest
$ docker run -it --rm jenkins/jenkins:latest apt-get
apt 1.4.7 (amd64)
Usage: apt-get [options] command
       apt-get [options] install|remove pkg1 [pkg2 ...]
       apt-get [options] source pkg1 [pkg2 ...]

I can reproduce! Instead, I can find 'apk' in PATH. It seems that now default is alpine instead of debian? Are those breaking changes documented somewhere? Or can we expect such decisions in the future as well?

It seems that now default is alpine instead of debian? Are those breaking changes documented somewhere? Or can we expect such decisions in the future as well?

I am pretty sure there was no such decision. CC @carlossg @ndeloof @rtyler
I'd guess there is a defect in the build logic somewhere. There repository seems to be fine.

 Shouldn't such things not happen when there is no need of "pushing"?

@mindrunner because we rely on build args passed to a general purpose Dockerfile, so we don't have to push a commit every week to publish latest. This has been working well for 1 year for now, not sure what caused this tag mismatch.

Agent images are being built automatically on DockerHub.
I am not sure what is the justification for the master image now. I am pretty sure custom build is required for image signing, but AFAIK we do not do that. There may be other reasons in the delivery pipeline though.

@ndeloof Thank you for clarification. Is there any chance to get insight to the build process? Where does it happen?

I have a similar issue. I have an automated build of an image that uses jenkins/jenkins:lts as its parent, and as of a few days ago, there are intermittent build failures due to the groupadd command not being found. The first such build failure occurred on 2017-09-09T18:55:59.744Z. There are subsequent builds that succeed, so the problem does "fix" itself some point down the line, but then recurs.
Today I added some debug logging to my Dockerfile, and it seems that an Alpine-based image is getting pushed with the lts tag. Here's a build log that shows that:
https://hub.docker.com/r/jjlin/jenkins-docker/builds/bhbst5qplrrwiazmzanaauh/

looks like the docker hub authentication has changed and the curl calls we use are returning 401 now at https://github.com/jenkinsci/docker/blob/master/publish.sh#L47

It is very annoying, I'm trying to build my docker container, basically apply some configuration on top of jenkins/jenkins:2.60.3 and installing some plugins automatically and now I cannot build it anymore.
I cannot just run apk as I had to add custom sources for apt-get to install google-chrome to run my javascript tests.
What I cannot understand is why are tagged images with a specific version modified. I specifically used 2.60.3 instead of the generic tag lts to make sure my docker build would always be constant.

if you want full reproducibility you need to use SHA, not tags

We were checking in the wrong place, the old jenkinsci/jenkins repo, and that's why all tags were getting rewritten

But we still have alpine images where debian should be
$ docker pull jenkins/jenkins:2.78
2.78: Pulling from jenkins/jenkins
Digest: sha256:30ed535c233e49b8acafe4e3b86c697f506814322cce30fbdf129fccf75d8e9a
Status: Downloaded newer image for jenkins/jenkins:2.78
$ docker run -it --rm jenkins/jenkins:2.78 cat /proc/version
Linux version 4.9.41-moby (root@11fbdc1f630f) (gcc version 6.2.1 20160822 (Alpine 6.2.1) ) #1 SMP Wed Sep 6 00:05:16 UTC 2017

Actually even though /proc/version returns Alpine they are not alpine images but debian (don't ask me why). apt-get is installed
So I can't reproduce
$ docker pull jenkins/jenkins:latest
latest: Pulling from jenkins/jenkins
Digest: sha256:30ed535c233e49b8acafe4e3b86c697f506814322cce30fbdf129fccf75d8e9a
Status: Image is up to date for jenkins/jenkins:latest
$ docker run -it --rm jenkins/jenkins:latest which apt-get
/usr/bin/apt-get

/proc/version comes from the Docker host kernel. You might consider cat /etc/os-release instead. My most recent automated builds are working, so at least the lts image is fine at the moment. I'll add another comment if the issue returns...

My automated build based on the lts tag just failed again with the same issue, so looks like it's not quite fixed...

For example jenkins/jenkins:2.60.1 is correct (has apt-get),. but recent tags are not.
I'm going to manually delete recent tags which look suspiciously too small, and rebuild in trusted-ci.

I run into this issue as well, my CI job failed to build the Jenkins worker from jenkins/jenkins:2.60.3, sad to see the tagged version is being updated. I didn't expect such failure from Jenkinsci also not being caught by CI/CD. It is okay to fail but where is the iteration to fix it fast and roll forward? or rollback?
Lead by example, please.

@hasKidanekal The Jenkins project is open source and benefits from contributions from new-comers like yourself. I also am not thrilled that this issue has cropped up in our release infrastructure, so I welcome more help to prevent this from happening in the future.

@carlossg Interestingly enough deleting tags in Docker Hub doesn't do what I expect with their APIs. Fetching the jenkins/jenkins/manifests/$tag URL after deleting a tag, results in a valid 200 response, which isn't quite what I expected :man_facepalming: :
{
   "schemaVersion": 2,
   "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
   "config": {
      "mediaType": "application/vnd.docker.container.image.v1+json",
      "size": 10883,
      "digest": "sha256:899bc8c6af1fd0baa77f4df10d654a2532c36ade1e09af77faa3848b69ecb3f0"
   },
   "layers": [
      {
         "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
         "size": 1967906,
         "digest": "sha256:cfc728c1c5584d8e0ae69368fc9c34d54d72651355573ba42554c2469a0a6299"
      },
      {
         "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
         "size": 231,
         "digest": "sha256:5b12b87f0a0e1bc0a163558cc56861b86355598153fb9e35273ece1dabe81cae"
      },
      {
         "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
         "size": 70004148,
         "digest": "sha256:b7d6497a92f9de7c9b828962ad09a648e1d72687dda6bb986a72e95c61bb3dad"
      },
      {
         "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
         "size": 25252864,
         "digest": "sha256:c1fa663ef0e6efe47fae47c3794d5942347415471c847dd3ca22acd5baf5a97d"
      },
      {
         "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
         "size": 1256,
         "digest": "sha256:2033e289ce6f255504bd08c04844220b573246e5b3b2ab64f6ff72a611fbb223"
      },
      {
         "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
         "size": 176,
         "digest": "sha256:7d90c343b32d9aacd303b5a73f771e9f7dd88b9a89bc0a4926d56c9f61a0ead6"
      },
      {
         "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
         "size": 354771,
         "digest": "sha256:dbe7ed8f05a6420cb08d72abf3ee7a4aa48d885bda4e93e89c8a4bd06f6bec5e"
      },
      {
         "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
         "size": 426,
         "digest": "sha256:5cb69b396db307ee4a5eaa447befca93bd0148248b522018f2b20af8c8832378"
      },
      {
         "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
         "size": 70402667,
         "digest": "sha256:30f0a00e8071ff25cfb4ef1f6e66e8bab7addbe8a6d0009cdf4d6663d5ddb85a"
      },
      {
         "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
         "size": 428,
         "digest": "sha256:0f6fee8c11b148dce985e2025d4d29438d94c1d7ff24928cc782a4c068cddbd6"
      },
      {
         "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
         "size": 1424,
         "digest": "sha256:e9539218c4ee5c02b7eea6c9f4fd149b0089a47c820a32937f2731b1d0b07f7b"
      },
      {
         "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
         "size": 822,
         "digest": "sha256:94d0b6e0e73daa5ef1eca05de2186c2e35e5a3b866eafe85ee2ab8ff3935c0b4"
      },
      {
         "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
         "size": 1538,
         "digest": "sha256:e230cd133f304421d91c5792803908b8dc403ddeda641009d7b48ac97b26a114"
      },
      {
         "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
         "size": 2612,
         "digest": "sha256:d0854ad4f34b0f681c71707e821c8fc2cfc7e3de46779c2302b3169dbef53a84"
      }
   ]
}

Of course, I can still one of the deleted tags, so Docker Hub is clearly broken in that regard.
I'm thinking an improvement would be to pull the list of tags rather than pulling the image manifest data
In the meantime, i think I'll change the script at least temporarily, to repush the tags which were overwritten with alpine images.

The lts tag is now correct, and I believe since the alpine branch is no longer running its Jenkinsfile, that this issue is corrected.


Not redirecting to quiz.html after successful sign up

i would like to work on the issue.

@jugeshraghav Any update? If you face issue in the code let me know with your problem I am here to help you out.

i would like to work on this

I would like to work on this

Under DCP or LGMSoC?

I would like to work on this

Under DCP or LGMSoC?

dcp


Provide an option to select a device, when multiple devices are connected

Often I have connected multiple emulators and phones to my computer. I have to open separate terminal, list the devices via adb devices and then copy each serial number and run scrcpy with -s argument. Or often I just launch scrcpy without arguments, and I get an error adb: error: failed to get feature set: more than one device/emulator.
It would be helpful, to provide an option to choose a specific device and continue instead of error "more than one device/emulator".
It could looks like this:
Multiple devices detected. To continue, please type the order of device you want to launch:
1. emulator-5554
2.<PHONE_NUMBER>abcdef

Then I could just type "2" to continue and open scrcpy with selected device.

[x] I have checked that a similar feature request does not already exist.

I agree with adding this feature, this also occurred while enabled wifi adb connection in one device.
But there are several applications that provide a user friendly UI such as QtScrcpy you can try: https://github.com/barry-ran/QtScrcpy
It is enough for developing android apk though some bugs in listing devices on my desktop.
I prefer this software AnLink https://anl.ink which seems use same technology from scrcpy, it is more convenient than QtScrcpy but not open source software, so choose your favorite.
Wish scrcpy could add an UI to choose devices.

Would love to see something like this implemented. Another option (that mimics adb behavior) would be to add -d and -e flags to indicate a device vs. emulator?

Oh, I forgot this feature request.
I implemented such a feature this week-end: please review #3005.

Fixed by #3005.