zstd --test returns zero on non-archives.

Lets assume a random file, of a non-zero length, with the .zst filename extension. When trying to decompress it (using -d), an error message is given (as expected): zstd: <file>: not in zstd format
But, when calling zstd --test <file>, zstd returns a zero value, and no warning or error is given, indicating that the test was successful.
Thus a sufficiently corrupted zstd-file could theoretically pass the test, even thought it can't be decompressed. It would also be beneficial when writing scripts, if files not in zstd-format returned a non-zero value.

Thanks for report @amnilsson .
Indeed, it should exit with a non-zero return code.
I'm surprised, this use case is supposed to be checked by test script.
Will look into it ....

I'm able to reproduce the bug with v0.7.4, but not with latest dev branch.
I guess it was solved by one intermediate patch, although I'm unsure which one.
I'm nonetheless surprised such a bug could get through.
It was supposed to be tested :
https://github.com/Cyan4973/zstd/blob/master/programs/playTests.sh#L208
I suspect that's because * expanded to a list containing a directory, which properly failed,
thus masking the other cases which did not.
Hence it means the test must be strengthened a bit ...

Happy to help! :-)
I tried the dev08 branch. Non-archive files are now recognized, and the return value now seems to correspond to the number of input files containing errors, and is thus always non-zero in case of error(s). Thank you!
Regarding files of zero length. These pass the test, and can be "decompressed" (if they have a .zst filename extension). Is this really correct?
The test of a zero length file should IMHO fail. This would help detect errors where the file content has disappeared (like failed or erroneous I/O redirection in the shell).
Are files of zero length technically of the zstd format? IMHO they should not be, and decompression attempts should result in error, or at least a warning, to help detect data corruption. Is there a use case of zero length .zst files that I'm missing?

You are totally right @amnilsson , 0 sized file should not pass the test.
I'll look into it, and add this test to the CI suite.

0-sized files are reported as bad files in latest update of dev08 branch.
Tests updated to include this use case.

Nice! Thank you!


phylo: implement mjoin variant of neighbour joining algorithm

Need to check the attached draft implementation thoroughly. (Original paper link.)
mjoin-1.ipynb.zip

Have moved this issue to another project.


Update desription for ocdev create

Updates the description for ocdev create with a bit more information.

Thanks @kadel I've updated it and added one more line with regards to using Python, but that's it. You're right, since OpenShift is constantly adding new containers / build images, it'd be hard to maintain.

Thx! Rebased :+1:


Add location to "Scheduled" lectures on course page

Describe the solution you'd like
Add a clickable link to the location (e.g. HS2) of "Scheduled" lectures on the course page referring to NavigaTUM.

Do normally classes provide the location with the stream ? cause I have some classes with no info about location (just time).
Indeed, I can start working on this

Classes without locations associated to them are usually self streams. (using OBS, etc.)

I would like to work on this issue, if no one actively is.


Is this repo dead? no merges since Jan, and things are breaking as things are getting old?

what happened to the maintainer??

I've recently been given the ability to merge and release new version (and my first release added node v6 support a couple of min ago).
I'll try to help maintain the project as much as I can. Like always, PRs will be preferred over bug reports =).

@mdlavin If there is only node v6 support can we put that on the documentation? Ive been trying to use node v8 with zombie and it seems to be failing

I haven't had time to do any development in this project for a while. I'd
be ok with stepping down as a maintainer and putting somebody in my place
if anybody is interested. I think I've seen assaf do some merging in the
not too distant past.
On Wed, Dec 13, 2017 at 3:19 PM slauyama<EMAIL_ADDRESS>wrote:

@mdlavin https://github.com/mdlavin If there is only node v6 support
can we put that on the documentation? Ive been trying to use node v8 with
zombie and it seems to be failing
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/assaf/zombie/issues/1077#issuecomment-351510018, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAGhl--sfrHkY0P9eJQ4LMOPlniBe6ALks5tADFCgaJpZM4KH02r
.

I think I'll just make a change to the README saying that this is only maintained up to node 6 that way people can see it.


Scenes and sprites aren't displaying.

I have come across a strange bug, in that my project scenes and sprites do not display whatsoever.
I have tried different things, such as multiple installations and trying both 32-bit and 64-bit, installer and standalone variants, and yet any project file I create, there is simply no display of my assets, and thus I have to guess where my collisions are going. Even in the sections other than the main editor, the assets aren't visible, and yet when the game is run through the built-in emulator, they are displayed.
I have no idea how I can help reproduce this error, as I haven't seen any other case of this, I don't know if it is my current computer :/. This has only happened recently, and when I updated to 1.2.1, it was initially fine, with that only happening when I wasn't connected to the internet, however it now happens regardless of an internet connection or not, and I am confused as to why. Again, it could be an error with the hardware I'm running, but this isn't a long-standing issue with the program, and I am hoping there is some solution to my issue.
Screenshots:

The OS and Application Version are as follows:

OS: Windows 10
App version 1.2.1

Looks like missing files, is your project in a drop box and synced on demand?
Try copying the project folder and opening that/checking the assets inside.
If the assets look fine outside of gbstudio, we'd need a zip of your project folder to test.

Looks like missing files, is your project in a drop box and synced on demand?
Try copying the project folder and opening that/checking the assets inside.
If the assets look fine outside of gbstudio, we'd need a zip of your project folder to test.

Thanks for commenting! I saved my project folder into a 'Game Projects' folder, and the assets are present are viewable perfectly fine outside of gbstudio, previews and in Photos.

As mentioned in my last statement, when running the game in the built-in emulator, everything is visible as it should be too, this display error is just in the editor itself:

So concerning the backgrounds and sprite assets, they're all viewable outside of the editor. I'll upload my project folder for you to test and try and find a solution. And thanks again for seeing to this issue :)
Jerry.zip

A quick update:
I started a new project file, and the editor is now refusing to show that I have any sprites/background that aren't pre-made.
Here are the folders, to which I was starting a Legend of Zelda-inspired game. First is the Sprites folder:

Next is from the Background folder:

And then here are the respective sections in the actual program:

That is very odd, i've just opened your jerry.zip project and everything shows fine in the editor, tested on 1.2.1 and a dev build.
Perhaps try grab a dev build from https://github.com/chrismaltby/gb-studio#development-builds just to double check.
Also, curious if you used a zip or the installer for gbstudio, if they were working earlier, perhaps it's somehow corrupted and needs re downloading?
All your files are being compressed on disk (the 2 arrows on the icons), but i wouldn't expect that to be the issue, perhaps something more odd, like free disk space, or simply too long of a file path/weird characters in your user?
They Shouldn't be the issue, but you never know... i'd try copying the project folder somewhere lower level and opening it from there if a fresh copy doesn't work.

That is very odd, i've just opened your jerry.zip project and everything shows fine in the editor, tested on 1.2.1 and a dev build.
Perhaps try grab a dev build from https://github.com/chrismaltby/gb-studio#development-builds just to double check.
Also, curious if you used a zip or the installer for gbstudio, if they were working earlier, perhaps it's somehow corrupted and needs re downloading?
All your files are being compressed on disk (the 2 arrows on the icons), but i wouldn't expect that to be the issue, perhaps something more odd, like free disk space, or simply too long of a file path/weird characters in your user?
They Shouldn't be the issue, but you never know... i'd try copying the project folder somewhere lower level and opening it from there if a fresh copy doesn't work.

I legit moved it to the desktop where the shortcut is and it seems to be working again! I'm so confused, but thank you Richard for your help and advice...although I can't believe something so minor fixed my problem |:/

So you moved the project to the desktop and that solved the editor issues?
Would you be able to experiment with moving it back or renaming folders to reproduce the issue?
Seems like the [ ] characters or length of file path might be the issue, can't be username if it worked on the desktop, if we can find the cause we might be able to add a warning.

I will try experimenting with it a little, I'll let you know the results :)
On Wed, 24 Jun 2020 at 06:54, Richard Ziegler<EMAIL_ADDRESS>wrote:

So you moved the project to the desktop and that solved the editor issues?
Would you be able to experiment with moving it back or renaming folders to
reproduce the issue?
Seems like the [ ] characters or length of file path might be the issue,
can't be username if it worked on the desktop, if we can find the cause we
might be able to add a warning.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/chrismaltby/gb-studio/issues/434#issuecomment-648606659,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AP6BBWZDP6XLBBFVYQB5GHDRYGIJHANCNFSM4N4WE3RQ
.

Jeez, I haven't commented in a while xD
Yeah, as it seems, it was a folder structure and naming issue. Thanks for the advice @RichardULZ


Removed more APIs

Removed Result
Removed AsyncSemaphore
Moved TaskExtensions to test project
Did some random clean up of argument validaton

Hold off for a day, I'm in the middle of renaming Backends and this is going to conflict.

Rebased!

@Tratcher can you review please? 😄


Artist and song name not detected

Description
The skin doesn't detect the artist and song name while spotify is launched
Versions

Rainmeter Version: 4.2  - r3111
OS Version: Windows 10 Home - Version: 1607
Skin Version: 2.02
Spotify Version: <IP_ADDRESS>0

Additional notes/images

Same issue here.

Duplicate of #191.


HDFS checks run by workers need to be keyed per host

Today, running on a suitably large cluster I keep having Chef run failures due to races between testing existence of a file to verify HDFS is okay and trying to clean it up. E.g.:
  * bash[tez-remove-check-file] action run
================================================================================
Error executing action `run` on resource 'bash[tez-remove-check-file]'
================================================================================

Mixlib::ShellOut::ShellCommandFailed
------------------------------------
Expected process to exit with [0], but received '1'
---- Begin output of "bash"  "/tmp/chef-script20170224-56656-17zmquj" ----
STDOUT:
STDERR: rm: `/user/hdfs/chef-tez-test': No such file or directory
---- End output of "bash"  "/tmp/chef-script20170224-56656-17zmquj" ----
Ran "bash"  "/tmp/chef-script20170224-56656-17zmquj" returned 1

This is part of tez.rb and runs on all worker nodes. But since the file name is the same, there is a race between the file being tested for existence and -- another node -- first deleting the file, that machine being at the same point in its Chef run.

Fixed in #797


chalkduster font

Great theme, many thanks for sharing !
May I suggest you the Chalkduster font to your theme, you could like it it's a great font forthose kind of theme.
https://www.cufonfonts.com/font/chalkduster
Have fun, thanks again.

This is great, thanks for the suggestion!


Add Https Listener traffic test, Test framework improvement

Changes

Further Test Framework imporvement, add more properly resource clean up logic:

In BeforeSuite() do CleanServiceNetworkVpcAssociationForCurrentK8sClusterVpc()
In AfterEach() Clean up previous running test case created k8s resources, in case this test case failed-in-the-middle
In AfterSuite (), DeleteAllFrameworkTracedServiceNetworks(), Clean all test cases created serviceNetwork's VPC association

Use a more generic interface client.Object to create HttpRoute, so that backendRefObjects could be either Service or Service Import for future use
Add a [load_env_variables.sh] to make golang IDE config easier (https://github.com/aws/aws-application-networking-k8s/compare/main...zijun726911:https-test?expand=1#diff-0921758188af1018497f76b4373865caa0295c375a72b2e7d64cf01d13146912)

Test
make e2etest pass
Ran 3 of 3 Specs in 808.077 seconds
SUCCESS! -- 3 Passed | 0 Failed | 0 Pending | 0 Skipped

Update removed https traffic test in the new revision now it only have 2 test case
Full log: https://gist.github.com/zijun726911/7c8ed592b02f4f9911632c8c6a439a3d

Update: removed https traffic test in the new revision now it only have 2 test case

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 31.824%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3169

Relevant Lines:
9958

💛  - Coveralls

New test result, make e2etest still passed https://gist.github.com/zijun726911/3240c8e9a6990db894237015a31753bb


Run slow tests in CI

This change is

#534  👈
dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spapinistarkware and the rest of your teammates on  Graphite

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.92%. Comparing base (bcb5732) to head (70c7b99).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #534      +/-   ##
==========================================
- Coverage   95.09%   94.92%   -0.18%
==========================================
  Files          63       63
  Lines        9195     9195
  Branches     9195     9195
==========================================
- Hits         8744     8728      -16
- Misses        393      409      +16
  Partials       58       58

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Improve test for RFC 6487

Found a certificate with the pointer to a signed ROA, so I added a test case.

Codecov Report

Merging #92 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   99.34%   99.34%
=======================================
  Files          81       81
  Lines        5664     5664
=======================================
  Hits         5627     5627
  Misses         37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3c4725...7b5dee8. Read the comment docs.


glTF rendering error

Before we are using CesiumJS 1.93 and it works, after upgraded to 1.105 it fails, error show in below:
RuntimeError: Fragment shader failed to compile.  Compile log: WARNING: 0:2: 'GL_OES_standard_derivatives' : extension is not supported
ERROR: 0:326: 'v_texCoord_0' : undeclared identifier
ERROR: 0:326: '=' : dimension mismatch
ERROR: 0:326: '=' : cannot convert from 'const highp float' to 'highp 2-component vector of float'
Error
at new RuntimeError (http://localhost:8080/Build/CesiumUnminified/index.js:15434:11)
at createAndLinkProgram (http://localhost:8080/Build/CesiumUnminified/index.js:36538:9)
at reinitialize (http://localhost:8080/Build/CesiumUnminified/index.js:36691:19)
at initialize2 (http://localhost:8080/Build/CesiumUnminified/index.js:36686:3)
at ShaderProgram._bind (http://localhost:8080/Build/CesiumUnminified/index.js:36745:3)
at beginDraw (http://localhost:8080/Build/CesiumUnminified/index.js:182260:17)
at Context.draw (http://localhost:8080/Build/CesiumUnminified/index.js:182346:3)
at DrawCommand.execute (http://localhost:8080/Build/CesiumUnminified/index.js:33512:11)
at executeCommand (http://localhost:8080/Build/CesiumUnminified/index.js:231039:52)
at executeCommands2 (http://localhost:8080/Build/CesiumUnminified/index.js:231345:7)
I have tried the latest gltf-pipeline to remove the unsupported extension, but still no hope ...

Extensions of the model which working in 1.93: (named a.gltf)
"CESIUM_RTC",
"WEB3D_quantized_attributes",
"KHR_techniques_webgl"

Extensions of the model after gltf-pipeline: (named b.gltf)
"CESIUM_RTC",
"WEB3D_quantized_attributes"

both a and b glTF having the same error when import to 1.105, and only a.gltf in 1.93 is working.

can anyone please help?

Hi @chun8933, Are you using a Custom Shader?
Can you share a Sandcastle link that replicates the issue? Here is how to do it:

Go to https://sandcastle.cesium.com/
Edit the "JavaScript code" tab with your JavaScript code
Edit the "HTML body & CSS" tab (if needed)
Click on the "Share" button and copy the provided URL

Thanks!

Dear @jjhembd,
Thx for the reply
Sorry i am new to the project, dont really know does Custom shader is using or not, but after having tests with different version of Cesium, seems 1.9x are all working, can i say that no Custom Sader is used? as i just pass the model url to every cesium version and without any code dependence work.
I have uploaded 2 gltf files to the drive, and embeded them to sandcastle, same script is working in my local env but not in the public cesium env... sorry for that, still share the link with you and hope you will spend time to have a look.
On the other hand, please let me know what can i do for easily problem tracking and solving.
Requested link:
https://sandcastle.cesium.com/#c=xVXbbtw2EP2VgZ7kQKZ2vXbSbNdGbSdACtStG7vtQ1UElDRaEqFIlaT20sD/3qEu3kvcl7x0gcWu5nLmnJkhlaacLZWv4BSE942bp2lp5QpZIbjUHgtR4ooVpk4LZdoyvf3w289pSBjyMp2mjwLBWLmUmivowNbGfnawll5AgU62NazQOmk0TNnbTQJ560EbDzIYppMN22Q6IOXfyCV/5nJdebRg0SG3hUjAIdYOvECLwOmLG4+6YxLqu7ZpjPVYBiYUBBrXz1RNNZAPuM6AhMJocvq0bZaWl9hlHApvndTL7u9pIxtUUiPEe6AnwHUJgq/65JF3qHBDPXFeKkXMQJgGGaC1xkKNzvElghNm7UaiRMUZRTE13+Y9WGNNrrAG6Ui/4kGVN5BFf7y/mb379HfLtZf/YPmJe28lTQBdFoXC9wq5QxComo5dzfWWADfBB69eDWzRBUC+pEkkXblhb6hamHaQ3c07DDgIynSg6GElcU0Tuexae9v1k/3e2eIs6vt7a7QnWLRZlMCXTAOJrMyN2cyh4sphEkwOFRaeWvijLmXBvbEHXsFL6s4cvG1Hi2lVea1lTZ3o7Zl+Ovk+MKta3UFBYZG8d6ZEFbdWJdQEuRT+pGfRU2dIffMSHbNYmxVeKxX3MAC9xMY42cFdjgJvOS2Vk1zPWGVN/Q6XFtHFIQXgdHo2Y5M35+evp2+T3nR+ziYXk9mbyevB0PMI/0OpsZBAXoZGP9e5414wbz6SmWsXT2cX++GN9IWg4MmezRpasEOTaI7G86Evcx/SP1J8PNRNesSkA9kvRGeAmsQPe/BoiVJlbO2YOAL8taWuW03hQ0vGDo7qGztK3xXpxrAl/OOx8LKMvxzizI8R9xjO9x8Gdx02YA4DCkBr5RzCQoyGWtIitfW93KB6oFM0h+nZdzsv3wTvQ8EVec4m9Bl8T93vU9+sgbi3vPiM5ftRTy+MIp52p8Y0gZ0j758hcyDm6faa04kert5oFKf7w0EHYlzs+GQnZn/JRxsQyrfd91Gyw7ggoWwyPvcinzUnLxDP/w/i+dfEpxf/zTvTf3V790B3YcGdp0uWNuzRGJVze4e6jYfhhLwoiRbObxVejWg/yDq8UsL2xIylHusm3MUuzVuaumeFc2PBRbqfuijlCmR5+cKtCIXizpGnalW3fll0tUgp/qtUZbqT9gu9bhTfhjAxvfqpNzLGFik9vpzpe4FHyP8C
Many Thx!
Chun.

@jjhembd Is this related to https://github.com/CesiumGS/cesium/pull/11308 at all?

Thanks for the update @chun8933! The Sandcastle is failing because of CORS errors, but I downloaded your file locally and was able to reproduce the bug.
@ggetz #11308 will take care of the first "WARNING":
WARNING: 0:2: 'GL_OES_standard_derivatives' : extension is not supported

But the real error here is the next line:
ERROR: 0:326: 'v_texCoord_0' : undeclared identifier

This is a bug in MaterialPipelineStage. The processTexture function adds the define #define TEXCOORD_BASE_COLOR v_texCoord_0 but does not verify that v_texCoord_0 was ever declared.
As a quick hack, I tried adding a ShaderBuilder.addVarying call to processTexture. This fixes the above error, but then there is another error:
RuntimeError: Fragment shader failed to compile.  Compile log: ERROR: 0:241: '=' : dimension mismatch
ERROR: 0:241: 'assign' : cannot convert from 'highp 2-component vector of float' to 'highp 3-component vector of float'
ERROR: 0:15: 'return' : function return is not matching type:

These errors are all because v_normalEC is declared as a vec2, when we were expecting a vec3.
@chun8933 is there any chance the glTF can be re-generated with 3-component normals?

Ths for the reply @jjhembd, tbh, i have no idea to re-generate the glTF with 3-componet normals, as the model has been passed to us for few years ago, cant reach the vendor out now...
As told with the team, the model should be a 2D mesh model, i think that why it has only vec2 for the normal and do not have the 3rd axises.
but, is there any ways for me the manual fix the issue? or any suggestions?
many thx..

The glTF contains an extension, namely, WEB3D_quantized_attributes, which is actually a glTF 1.0 extension, and it's not really widely supported.
Beyond that, it contains some inconsistencies in the input - for example, it appears to be missing texture coordinates. It could be possible to salvage some of the data. This would involve decoding the quantized attributes (probably with OCT-encoded normals) in a manual process. There almost certainly is no tool that can do this out-of-the-box. But it might be doable, with a ~"a few" hours of implementation work. But even then, it may be difficult to handle the remaining inconsistencies...
Here is a version of the file with the WEB3D_quantized_attributes extension being removed:
cesiumIssue11280.zip
This STILL contains errors, because there is no obvious way of how to fix the missing texture coordinates (and the normals are not decoded yet). It can be rendered in https://gltf-viewer.donmccurdy.com/ ...

... but polishing it in a way so that it passes validation and can be rendered in every viewer may require more work...


Error when running Gui applications

I installed nvidia-ros-kinetic , but I get this message when I run docker container also I am not able to load the Gui apps.
Gtk-Message: Failed to load module "canberra-gtk-module"
PluginRegistry::load_plugins: Importing plugin __init__.py failed: 'module' object has no attribute 'AVAILABLE'

Hello Jovian, I am building it right now to see if I am also getting it.
In the meantime a few questions that might shed some light:
I guess you checked that nvidia-docker is running fine as explained here: https://github.com/turlucode/ros-docker-gui#install-nvidia-docker-plugin ? E.g. is nvidia-smi producing the correct output within docker?
What do you get if you run in your host:
glxinfo|egrep "OpenGL vendor|OpenGL renderer"

Just finished building make nvidia_ros_kinetic. It works fine for me. If I run glxgears the window with the moving gears pops-up.

Thanks @atasoglou  , glxgears is working . I got it to work after running  this in the docker instance
sudo apt install libcanberra-gtk0 libcanberra-gtk-module


For CSS EDs, auto-generate "This version" link to dated URL

… dated URL like https://drafts.csswg.org/date/2015-10-25T20:04:10/css-variables/
See https://lists.w3.org/Archives/Public/www-style/2015Nov/0165.html

Hmmmmmmm. I can't just auto-gen the URL with the current time at time of generation, because that'll be before the draft is committed.  I could use some JS to generate the link at view-time; I'd have to observe the URL it's loaded from to see if it's already a dated version (so I could reuse the URL rather than generating a fresh incorrect URL).
Would that be ok?

Oh! Best would be to do this in Shepherd - when generating the archived docs, pass a custom metadata with the desired url.  @plinss ?

The date is that of the commit, right? If you’re willing to integrate with hg (and maybe git) we could use the date of the current commit if the source file is "clean" (unchanged since that commit), which should always be the case for server-side bikeshedding. If it’s not, warn and don’t generate the link.
How does this sound?

Yeah, a custom URL during generation would be best, what do you want to call it?

"This Version", apparently.  Pass in like bikeshed --md-\!This-Version="whatever" spec (assuming your calling convention has problems with ! like shell does; otherwise don't escape it).


gradle task build is failed

Hi.
After run this command
gradlew.bat build -Dorg.gradle.java.home="C:\Program Files\AdoptOpenJDK\jdk-<IP_ADDRESS>-hotspot" I get follow output in Windows CMD console:

I use Gradle Wrapper (gradlew.bat, currently is used Gradle 6.5), Java is AdoptOpenJDK <IP_ADDRESS>, OS is Windows 10.
Problem at generating JavaDoc.

If you pull the latest sources it should work again.

Thanks. It is ok now. Thank you for quick reaction.


No match for an empty string

Hello!
I have happened to notice that TRegExpr doesn't work with empty input strings anymore.
RegExp's like "^$" or "^ *$" are perfectly valid patterns and should match an empty string in first case and empty or string of spaces in second. However, due to the check
  if fInputString = '' then
  begin
    //Error(reeNoInputStringSpecified); // better don't raise error, breaks some apps
    Exit;
  end;

empty string isn't welcome.
In older versions, it used to check for pchar pointer, which worked fine, because empty string would still have a valid pointer, leading to "\0":
  if not Assigned (fInputString) then begin
    Error (reeNoInpitStringSpecified);
    EXIT;
   end;

This change in behaviour breaks some regexps :) Just removing the check for an empty string seems to fix it, but I'm not sure it won't backfire somewhere deep in the code.

fixed in my fork, patch is linked above this comment.

Thank you!


Update tablets invalidation logic

Invalidation on events

On SCHEMA_CHANGE, for target keyspace + table, for all change types: UPDATED or DROPPED drop related tablet records.
On TOPOLOGY_CHANGE, for REMOVED_NODE (and probably MOVED_NODE) change type, all tablet records that contains this node, to be removed.

Possible optimizations:

On SCHEMA_CHANGE change types: UPDATED driver can look at what have changed and if nothing that can trigger tablet migration (say, ks replication factor and tablet feature on the table) is touched, then invalidation to be voided

Invalidation on control connection reconnect
When cc is lost, driver can miss some of the events.
So we need some logic to catch up:

Read keyspace and table descriptions to find if any keyspace or table was removed or updated, doing exactly the same what should be done for SCHEMA_CHANGE event.
Read system.peers to find if any node was removed and do the same what should be done for TOPOLOGY_CHANGE event.

Note: the only thing that is not already handle is updating (not dropping!) keyspace / table (SCHEMA_CHANGE UPDATED event).


SDK_VERSION: Use Zephyr SDK 0.16.5

This series updates the CI workflows and documentation to point to the Zephyr SDK 0.16.5 release.
This synchronises the module and toolchain Picolibc version (Picolibc version 1.8.6).

Tested in https://github.com/zephyrproject-rtos/zephyr-testing/actions/runs/7735479454

The CI failures are due to the workflows running in the base branch context (pull_request_target) and should be ignored.
Tested in https://github.com/zephyrproject-rtos/zephyr-testing/actions/runs/7735479454


Improve artist speech & header styles on smaller screens

Fixes #39
Fixes #67

5 cards per row on wider screens
Constrain speech bubble on small screens

NOTE: raised #70  for future potential tidy

Thanks. I'm gonna merge as it is and make a ticket for improvements.


gitea: preStart fails when there are users with a space in their username

Describe the bug
When there are users with a space in their name, who have at least one repository with hooks, the hook pre-processing code in the preStart script will break, because the resulting paths are interpreted as space-delimited sets of arguments by sed, leading to the following kind of failure:
Nov 14 20:27:19 nixos gitea-pre-start[16073]: sed: can't read /var/lib/repositories/susan: No such file or directory
Nov 14 20:27:19 nixos gitea-pre-start[16073]: sed: can't read matthew/technicalsupport.git/hooks/update.d/gitea: No such file or directory

(The original repository path here was /var/lib/repositories/susan matthew/technicalsupport.git.)
To Reproduce
Steps to reproduce the behavior:

Create a user with a space in their username
Create a repository
Somehow have it contain hooks (not sure if this is the case by default, or requires pushing a commit)
Restart Gitea service

Expected behavior
Not breaking :)
Additional context
I don't know whether Gitea allows usernames with a space in them, but Gogs did, so this can be an issue when migrating to Gitea.
Notify maintainers

@srhb
Metadata

system: "x86_64-linux"
host os: Linux 5.4.77, NixOS, 20.09.1758.3090c650411 (Nightingale)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.7
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module: gitea

ping @Ma27 @etu @dasJ as well, just in case.

Trying to create a user with a space in their username results in:
2020/11/15 09:08:10 main.go:111:main() [F] Failed to run app with [/nix/store/x8w3x414dc20v1m9qjnpjbsgqh0dbylq-gitea-1.12.5/bin/gitea admin create-user --username test user --password test --email foo@localhost]: CreateUser: User name is invalid [test user]: must be valid alpha or numeric or dash(-_) or dot characters

Maybe making the preStart more robust is still a good idea.

I'm guessing it's only relevant for people who at some point used an old Gogs or Gitea version that does allow it then. I'm probably not the only one to ever do that, though :)

It seems this might do the trick:
diff --git a/nixos/modules/services/misc/gitea.nix b/nixos/modules/services/misc/gitea.nix
index af80e99746b..bb306ae1ae1 100644
--- a/nixos/modules/services/misc/gitea.nix
+++ b/nixos/modules/services/misc/gitea.nix
@@ -462,19 +462,19 @@ in
       in ''
         # copy custom configuration and generate a random secret key if needed
         ${optionalString (cfg.useWizard == false) ''
-          cp -f ${configFile} ${runConfig}
+          cp -f ${configFile} "${runConfig}"

-          if [ ! -e ${secretKey} ]; then
-              ${gitea}/bin/gitea generate secret SECRET_KEY > ${secretKey}
+          if [ ! -e "${secretKey}" ]; then
+              ${gitea}/bin/gitea generate secret SECRET_KEY > "${secretKey}"
           fi

-          if [ ! -e ${jwtSecret} ]; then
-              ${gitea}/bin/gitea generate secret LFS_JWT_SECRET > ${jwtSecret}
+          if [ ! -e "${jwtSecret}" ]; then
+              ${gitea}/bin/gitea generate secret LFS_JWT_SECRET > "${jwtSecret}"
           fi

-          KEY="$(head -n1 ${secretKey})"
+          KEY=$(head -n1 "${secretKey}")
           DBPASS="$(head -n1 ${cfg.database.passwordFile})"
-          JWTSECRET="$(head -n1 ${jwtSecret})"
+          JWTSECRET=$(head -n1 "${jwtSecret}")
           ${if (cfg.mailerPasswordFile == null) then ''
             MAILERPASSWORD="#mailerpass#"
           '' else ''
@@ -484,8 +484,8 @@ in
               -e "s,#dbpass#,$DBPASS,g" \
               -e "s,#jwtsecret#,$JWTSECRET,g" \
               -e "s,#mailerpass#,$MAILERPASSWORD,g" \
-              -i ${runConfig}
-          chmod 640 ${runConfig} ${secretKey} ${jwtSecret}
+              -i "${runConfig}"
+          chmod 640 "${runConfig}" "${secretKey}" "${jwtSecret}"
         ''}

         # update all hooks' binary paths
@@ -499,9 +499,9 @@ in
         fi

         # update command option in authorized_keys
-        if [ -r ${cfg.stateDir}/.ssh/authorized_keys ]
+        if [ -r "${cfg.stateDir}/.ssh/authorized_keys" ]
         then
-          sed -ri 's,/nix/store/[a-z0-9.-]+/bin/gitea,${gitea}/bin/gitea,g' ${cfg.stateDir}/.ssh/authorized_keys
+          sed -ri 's,/nix/store/[a-z0-9.-]+/bin/gitea,${gitea}/bin/gitea,g' "${cfg.stateDir}/.ssh/authorized_keys"
         fi
       '';


can't Clean cache on <IP_ADDRESS>

where is .vs\Highlights.xml ? search by everything, whithout any result.

This file is made only when SolutionTags options are used. Otherwise the options are stored in Visual Studios' options in the registry or local VS settings file based on your version.只有当选项被使用时，这个文件才会被创建。否则，这些选项将存储在注册表中的Visual Studio选项中，或者基于你的版本，存储在本地VS设置文件中。
Do you want to reset the settings?你想要重置设置吗？

Yes, I created a branch and found that the generated extension conflicted with the previous extension after installation.
Currently, the conflict was resolved after I deleted the tag list.


 Likely due to recent Spanner service rollout.
java.lang.AssertionError:
Expected: (stack trace contains string 'SpannerException' and stack trace contains string 'DEADLINE_EXCEEDED')
     but: stack trace contains string 'SpannerException' was <java.lang.RuntimeException: This message was redacted. Please
search the job logs in Cloud Logging for the entry with unique prefix: OutputMessage[5844617984962013488] for work item
1120611541754862560This message was redacted. Please search the job logs in Cloud Logging for the entry with unique
prefix: OutputMessage[9250666589450804496] for work item<PHONE_NUMBER>297128187This message was redacted. Please
search the job logs in Cloud Logging for the entry with unique prefix: OutputMessage[5844617984962011739] for work item
6016024597067538899This message was redacted. Please search the job logs in Cloud Logging for the entry with unique
prefix: OutputMessage[9250666589450803181] for work item<PHONE_NUMBER>335299829Workflow failed. Causes: S13:read
db/Execute query/Reshuffle/Reshuffle/GroupByKey/Read+read db/Execute query/Reshuffle/Reshuffle/GroupByKey/GroupByWindow+read db/Execute
...

Issue Failure
Failure: Test is continually failing
Issue Priority
Priority: 1 (unhealthy code / failing or flaky postcommit so we cannot be sure the product is healthy)
Issue Components

[ ] Component: Python SDK
[X] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[X] Component: IO connector
[ ] Component: Beam examples
[ ] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

Still one test failing:
21:28:54 org.apache.beam.sdk.io.gcp.spanner.SpannerReadIT > testReadWithDataBoost FAILED
21:28:54     java.lang.RuntimeException at SpannerReadIT.java:214

And the test suite timing out consistently since May 15th


Add multiple prop to FinalFormAutocomplete

Please target main as this is a non-breaking change. And I'd change it to Fix multiple prop in FinalFormAutocomplete as it is actually a fix, not an addition


Calc ind

Proposed changes

Removes references to Landsat Collection 1 from calculate_indices, including the actual functionality to process C1 data. Reason: no C1 data in DE Africa database
Adds band renaming to C2 datasets processed by calculate_indices. Reason: this should allow natively-loaded C2 data to be instantly processed by calculate_indices instead of the data-loading process requiring a measurements parameter
Updates Calculating_band_indices notebook to match the list of indices available in the Tools scripts. Reason: new ones have been added to the script
Removes files from /Scripts that have a corresponding function in /Tools

@fangfy  the /Scripts folder still contains two script files which are linked to the Crop health and Change filmstrips real-world-examples. Can we move those to /Tools? I think putting them in /Real world examples would look messy. However, the Tools folder seems to be for files related to the package only.
An alternative might be moving the /Scripts folder to /Real world examples as only real world examples have extra scripting, /Frequently used code are generally simpler/shorter


[Bug]: Test bug report

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
current test behavior
Expected Behavior
expected test behavior
Steps To Reproduce
in cmsis-toolbox the driver test is run
I cannot use it
No workaround available.
Blocker

[X] blocker

Hi, sorry, but can you please share more details on how to reproduce the issue? Thanks.


How to override methods from extended UserAdmin model?

I am currently using the method described in the Django 1.4 docs for extending the user admin with extra properties and methods in a Django 1.8 setup, and I am not able to make use of advanced features of django-import-export.
(This documentation is not available in newer versions. Is this not the preferred way to extend the user model, anymore?)
E.g. any attempt to override a method (e.g. before_import()) simply fails. Here is an excerpt of my code:
from django.contrib.auth.models import User
from django.contrib.auth.admin import UserAdmin

from import_export import resources
from import_export.admin import ImportExportMixin

class UserProfileResource(resources.ModelResource):
  def before_import(self, dataset, dry_run):
    print 123

  class Meta:
    model = UserProfile

class UserProfileAdmin(ImportExportMixin, UserAdmin):
  …

admin.site.unregister(User)
admin.site.register(User, UserProfileAdmin)

(Please let me know if you think details of UserProfileAdmin might be important to solve the issue.)
I’d expect to see 123 in the log output whenever I import user data but this is not the case.
Digging a little bit deeper in the django-import-export code I found that the actual resource class seems to be not the one I desire.
This is the output when I log its value and the corresponding model from within the method get_resource_class() in line 117 of admin.py
def get_resource_class(self):
  print self.model
  print modelresource_factory(self.model)
  …

<class 'django.contrib.auth.models.User'
<class 'import_export.resources.UserResource'>

IMHO it should be UserProfile and UserProfileResource instead.
Of course, I simply tried to rename my resource class to UserResource but it did not help.
Is there a work-around for this issue? I am aware that this could be unrelated to django-import-export and rather lie in the nature of Django mixins but I would be glad about any help, anyway.
Cheers,
tobi

Could it be that overriding the resource methods is generally broken? I just file another issue, #315.

It seems you forgot to set resource_class = UserProfileResource in your admin class.
Please reopen if problems persists.

Thanks, adding resource_class to admin class solved the issue.


liftM2 is not working with IO monads

Hi @widmogrod I've noticed that the implementation I proposed in #100 throws a type error with IO monads.
This PR consists in two commits.

the test to highlight the problem
the fix

Thanks

I see that there is an issue with similar blocks of code, this is linter issue, so I would like you add code comments that instrument linter that this is OK for those two methods to have the same signatures.

I realized now that liftM2 could simply call liftA2 behind the scenes.
I've never understood why there are two functions doing almost the same thing. Then I discover that liftM2 is much older than liftA2


Fix compatibility issues with Featuretools

Fix compatibility issues with Featuretools
fixes #39

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Popover opens in the browser but not in testing

Describe the bug
The Popover element renders correctly and opens in the browser, but it fails to open when using vitest and testing-library.
To Reproduce
See this repo for a reproduction. I made it by taking the following steps:

Create a new solid-js project
Install Kobalte, vitest, @solid-js/testing-library, @testing-library/jest-dom, @testing-library/user-event, add vitest.config.ts.
Add a simple Popover to App.tsx:

import logo from "./logo.svg";
import styles from "./App.module.css";

const App: Component = () => {
  return (

        <Popover.Root>
          <Popover.Trigger>open</Popover.Trigger>
          <Popover.Portal>
            <Popover.Content>

hello

            </Popover.Content>
          </Popover.Portal>
        </Popover.Root>

  );
};

export default App;

Add a App.test.tsx file with the following:

import { render, screen } from "@solidjs/testing-library";
import userEvent from "@testing-library/user-event";
import { test, expect, beforeEach } from "vitest";
import "@testing-library/jest-dom";

import App from "./App";

test("Clicking 'open' sets aria-expanded to true", async () => {
  const user = userEvent.setup();
  render(() => <App />);
  const open = screen.getByRole("button", { name: "open" });
  await user.click(open);
  expect(open).toHaveAttribute("aria-expanded", "true");
});

test("Clicking 'open' opens a dialog", async () => {
  const user = userEvent.setup();
  render(() => <App />);
  const open = screen.getByRole("button", { name: "open" });
  await user.click(open);
  expect(screen.getByRole("dialog"));
});

Expected behavior
The popover opens in the browser and the tests pass. Instead, the tests fail on their expect lines.
Desktop (please complete the following information):

OS: macOS
Browser chrome, firefox

I'm running into the same issue. Calling the debug() function prints out the HTML as expected with the popover open, but queries don't return the popover contents.


ROX-19459: Add CVE status tabs to workload CVE list page

Description
Adds Observed/Deferred/FP Tabs to the Workload CVE list page and scopes queries of the data to the correct status.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Create and approve a deferral and false positive via the VM 1.0 UI.

View the Workload CVE page with feature flag off, filtered to the approved CVEs. This view shows all instances of the CVEs, regardless of exception status.

Turn the feature flag on and view the same page. One CVE is absent (deferred across all affected images), the other CVE has a reduced affected images count.

Deferral tab:

FP tab:

Current dependencies on/for this PR:

master

PR #7954

PR #7959   👈

This comment was auto-generated by Graphite.

/test ocp-4-13-ui-e2e-tests


Update latest official Image to 2018.04

Could @hoelzro  or someone update latest official Image to 2018.04?
cf https://github.com/perl6/docker/issues/14#issuecomment-361771304

Thanks @skaji! I didn't even realize there had been a release!
@jstuder-gh If you update the Dockerfile in the future, could you ping me so I can submit the change to the Docker library?  Alternatively, I could walk you through the process if you want to do it yourself!

PR made: https://github.com/docker-library/official-images/pull/4352

@hoelzro, sorry about that! I will be sure to ping you in the future.

@hoelzro, for 2018.06, I updated this Dockerfile and submitted a PR to docker-library (here). Is there anything else that needs to be done in order to update the official image? Thanks.

@jstuder-gh Yeah, looks good to me!


Add Aspire component

It would be amazing, if we can have Flagsmith Aspire component.
I can provide some help in development of this aspire component.
Why?

There are such requests from the community dotnet/aspire#1570
It's the easiest way to start using Flagsmith with .NET
Improves Flagsmith adoption across community
Adds support for automatic DI registration

How it should look like
// AppHost.Program.cs

var builder = DistributedApplication.CreateBuilder(args);

var flagsmith = builder.AddFlagsmith();

var apiService = builder.AddProject<My_WebApi>("apiservice")
	.WithEnvironment(flagsmith); // Pupulates URL and EnvironmentKey

// ServiceDefaults.Extensions.cs

public static TBuilder AddServiceDefaults<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
{
      builder.AddFlagsmithClient(); // Registers FlagsmithClient into DI with URL and EnvironmentKey
}

Example of configuration with database
// AppHost.Program.cs

var builder = DistributedApplication.CreateBuilder(args);

var postgresServer = builder.AddPostgres("postgresserver")
	// Mount the SQL scripts directory into the container.
	// Init script would create a flagsmith database, becuase Aspire doesn't create DB by default yet.
	.WithContainerName("postgresserver")
	.WithBindMount("../Postgres", "/docker-entrypoint-initdb.d");

var flagsmithDatabase = postgresServer.AddDatabase("flagsmithDatabase", databaseName: "flagsmithdb");

var flagsmith = builder.AddFlagsmith()
	.WithReference(flagsmithDatabase) // Populates DATABASE_URL
	.WaitFor(flagsmithDatabase)

var apiService = builder.AddProject<My_WebApi>("apiservice")
	.WithEnvironment(flagsmith);

Hi @LeftTwixWand, thanks for raising this and for sharing the code snippets.
I'm interested to know what this would look like without an official Flagsmith component? Is there an option to, for example, add generic components? Something like builder.AddGenericComponent(MyComponent); ?
Being completely frank here, it's not something that we have the bandwidth to develop or maintain in house, but if you want to submit a PR, or create your own repository to hold the code than of course we'd be more than happy to review / endorse it.


Suggestion: follow the "Arrange Act Assert" style for tests

Currently our tests follow the clumsy Four-Phase Test style to describe the test body. I don't like that at all, as it looks like some old-school stuff which doesn't play nice with xUnit. My concerns:

The // Teardown phase is always empty in xUnit tests as it creates a sut per test, without need to restore it.
The // Fixture setup,  // Exercise System and // Verify Outcome looks too verbose, while // arrange, // act and // assert are more laconic. If you don't create test from a template, it's much simpler to write those words (it's always hard to write exercise without typos 😅).

Therefore, @moodmosaic if you don't have any strong objections (I hope you don't), I would like to switch us to 3 phase tests and use it all our the tests. It will allow me to feel satisfaction during the test creation, rather than pain 😖

Go for it. But I'd prefer to have the first letter capital, that is
// Arrange
// Act
// Assert

instead of
// arrange
// act
// assert

Do you have strong reasons to prefer the second case?

No, uppercase is fine to me - it's enough that we use AAA :blush:

You can also separate each phase with a blank line, which is the formatting I use nowadays. Then, the test-reader can assume it's Given/When/Then, or Arrange/Act/Assert, or even (the four-phase one goes here).
You can read more about this in the section "Simple tests with more than three lines of code" here.

I strongly dislike usage of empty lines instead of comments in OSS and disagree with that Marks idea. See my comment here.

Comments on top of each test-phase are, basically, comments. And in this particular case, they are apologies, because they explain how —instead of why.

Now, back to AutoFixture, since all tests are decorated with comments, and since the fixture teardown phase is almost all the times empty, we can go ahead and change them to AAA.

And in this particular case, they are apologies

Well, I also refer to this rule often, however in this particular case I prefer to keep those "apologizes" 😄 They make structure of the test more obvious and strict. Personally I find it more easier to read "labeled" tests, but probably that is simply a matter of habit 😉

but probably that is simply a matter of habit

This; and perhaps also a matter of who actually wrote the test.

Hello, I'd like to tackle this. I'm a big fan of Autofixture and use it in my work all the time and it would be a good way of giving back.
So basically you guys want to change the following in all the test files:
// Fixture setup to // Arrange
// Exercise System to // Act
// Verify Outcome to // Assert
and finally // Teardown to nothing.

Yes, but keep in mind that doing a 'find and replace' might not work as some phases are joined together in some tests. That is, you might come across Exercise system & verify outcome and similar, IIRC.

@moodmosaic I understand, I'm planning to do file by file not a full 'find and replace' but I might still use it in the more obvious/simpler cases.
Thank you,
Eissa

@moodmosaic for // Exercise system and verify outcome it should it be replaced with
// Act and Assert
Or you guys thinking of something different?

Usually I use // Act & Assert as it looks more concise and cool 😎 Unless @moodmosaic has concerns, I'd prefer to follow that style 😉

Either way is OK :neckbeard:

So I'm trying to start on this and after I load the All.sln in VS 2017 two F# projects
( AutoFoq,AutoFoqUnitTest ) are failing to open. I have zeor experience with F# so any help would be appreciated

@micheleissa Ensure that you use latest version of VS (15.5.1 or later), otherwise project will not open (MS applied changes to their F# SDK). Also ensure to run git clean -fdx . being in root with closed VS. That is to cleanup the temporary files in case you checked out the project earlier.
Both those steps should help. Let me know if they didn't 😉

@zvirja I have upgraded to latest version of VS 2017 15.5.2 and still facing the same issue 😞

Have you tried the second part?

Close VS
Go to root and run git clean -fdx .
Open VS again?

It seems that you simply have leftovers from the previous installation.
Also ensure that F# tooling is installed on your machine:

Yea, I forgot the second one sorry :)
I'll try it now

One more question, how do I associate the branch i'm working on in my forked repo to this ticket?

Great that it worked! 👍

how do I associate the branch i'm working on in my forked repo to this ticket?

I'd suggest to look at this article, the workflow is well described there: https://github.com/sevntu-checkstyle/sevntu.checkstyle/wiki/Development-workflow-with-Git:-Fork,-Branching,-Commits,-and-Pull-Request
Basically, you don't need to associate a branch with this issue. Rather, you create a Pull Request and simply mention this issue in the body.

Ok, got it. Thank you! I'm gonna create the pull request while I'm working on the issue so you guys can monitor the progress and give feedback according to what mentioned in the contributing guidelines.


Minor Fixes

Given Correct Title to notebook in  2-Regression/1-Tools/solution/notebook.ipynb .
Given some more clarity to NLP Introduction

Thank you @jlooper


autoload.el deprecated in newest Emacs development version

This is just a heads up that autoload.el seems to be in the process of being replaced by loaddefs-gen.el, which was introduced in the last months (starting from Emacs commit 1d4e9034178)
For straight.el this would probably involve invoking loaddefs-generate (introduced in loaddefs-gen.el) instead of make-directory-autoloads or update-directory-autoloads in straight--build-autoloads. Maybe a check for (fboundp 'loaddefs-generate) and calling that instead would be enough, but I am not sure whether it is a drop in replacement.

I will try out my changes in #986.

Thanks for bringing this to our attention.
Was there a discussion of this on emacs-devel? I'm curious to learn more about this change.

I actually didn’t find anything on emacs-devel, may be in some bug report, otherwise most information I found was in the commits from Lars and notes in NEWS.

11 aug. 2022 kl. 23:26 skrev Nicholas Vollmer @.***>:

Thanks for bringing this to our attention.
Was there a discussion of this on emacs-devel? I'm curious to learn more about this change.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.

Considering this closed as #986 was merged. Thanks again, @andersjohansson.


Popover related touch/view-hierarchy problem

(this is not an urgent issue for me as there's a workaround noted below and my app development is currently against a stable branch)
Some of the recent view/layer work has broken popover dismisses (via touch on a clear overlay view outside the bounds of the popover content view controller).
Steps to reproduce:

Open WOCCatalog app
Enable tablet mode in display mode view controller, press back
Load Controls View Controller
Touch a popover button
Dismiss popover via touch outside the popover content

Expected:
The popover is dismissed
Actual:
The touch passes through to the table below; popover is not dismissed
I've been able to bisect the commits and I believe the problem was introduced by ec804795a924609eb975a6518475a6371c871b14
The last good version (where popover is dismissed) is b52a219eba2093a3c273ecee10e0a81242072979
The relevant WYPopoverController code is here:
https://github.com/Microsoft/WinObjC/blob/812d6636036a8d2eaeaaf7b92aa0c7b76252e190/Frameworks/UIKit/WYPopoverController.m#L1937
        overlayView = [[WYPopoverOverlayView alloc] initWithFrame:inView.window.bounds];
        overlayView.autoresizesSubviews = NO;
        overlayView.isAccessibilityElement = YES;
        overlayView.accessibilityTraits = UIAccessibilityTraitNone;
        overlayView.delegate = self;
        overlayView.passthroughViews = passthroughViews;

        backgroundView = [[WYPopoverBackgroundView alloc] initWithContentSize:contentViewSize];
        backgroundView.appearing = YES;
        backgroundView.isAccessibilityElement = YES;
        backgroundView.accessibilityTraits = UIAccessibilityTraitNone;

        backgroundView.delegate = self;
        backgroundView.hidden = YES;

        [inView.window addSubview:backgroundView];
        [inView.window insertSubview:overlayView belowSubview:backgroundView];

Something is going wrong with overlayView here.
A few other notes:

This problem can be bypassed by selecting the legacy hit test operation mode.
However I don't believe this is a "legacy hit test" issue - though overlayView does implement hitTest it doesn't request to participate in hit testing outside it's bounds.
I suspect something is funny with the view hierarchy at the point the background and overlay views are added to the window of the inView (which corresponds to the UIPopoverPresentationController sourceView)
I have not yet attempted to dump a description of the view hierarchy at the time the above code is executed. This could be enlightening.

I found an additional view in my app that needs legacy hit testing enabled against the latest revisions. It's a UITableViewCell (no popovers involved). Will post if I find out more.

Thanks, @ehren - I'm hoping to take a look this week.  I think it's a bit odd that you need to use legacy hit testing though; are there any tweaks to setUserInteractionEnabled(true/false) that alleviate the issue?    If you inspect the UIElements in the live UIElement tree viewer in the VS debugger, and look for 'isHitTestVisible', you may find that toggling that value will fix the issue.  Any more details you can provide would be helpful.

@jaredhms toggling isHitTestVisible in the tree viewer fixed the issue for the UITableView cell (this view does have a few disabled UIImageViews as subviews - may be related - will look further). Haven't tested if this is the case for overlayView yet.

Thanks, @ehren.  We internally map the setUserInteractionEnabled(true/false) values to Xaml isHitTestable values, so you should be able to fine-tune your subviews via setUserInteractionEnabled to get this to work reliably in your app.
Any more details you can provide would be helpful though (another self-contained repro, etc.).  It's possible that we're not setting a userInteractionEnabled value correctly somewhere, but it's also possible that this is by design, and we may always require a bit more fine-tuning of hit testability on our platform.

@jaredhms I'm going to try recursively applying setUserInteractionEnabled for that problematic cell mentioned above (I'm also debugging a possibly unrelated issue where a control seems to require a long press? don't have details yet).
No rush in any case - this particular issue really isn't a blocker.
fyi, I was able to modify WOCCatalog to highlight some interesting issues (one of them reproduces the WYPopoverController overlay problem)
diff --git a/samples/WOCCatalog/WOCCatalog/ControlsViewController.m b/samples/WOCCatalog/WOCCatalog/ControlsViewController.m
index 8dc431f..a1bfc11 100644
--- a/samples/WOCCatalog/WOCCatalog/ControlsViewController.m
+++ b/samples/WOCCatalog/WOCCatalog/ControlsViewController.m
@@ -66,6 +66,11 @@ static const int MULTIPLEPRESENTDISMISS_ROW = 5;
     [self.rightPopoverButton setFrame:CGRectMake(self.view.bounds.size.width - originOffset - buttonWidth, originOffset, buttonWidth, buttonHeight)];
     [self.rightPopoverButton addTarget:self action:@selector(pressedPopoverButton:) forControlEvents:UIControlEventTouchUpInside];
     [self.view addSubview:self.rightPopoverButton];
+
+    // this blocks touches
+    UIView *blah = [[UIView alloc] initWithFrame:self.view.bounds];
+    blah.alpha = 0.0;
+    [self.view addSubview:blah];
 }

 - (void)viewDidDisappear:(BOOL)animated {
diff --git a/samples/WOCCatalog/WOCCatalog/MenuTableViewController.m b/samples/WOCCatalog/WOCCatalog/MenuTableViewController.m
index 988c857..8d56ce2 100644
--- a/samples/WOCCatalog/WOCCatalog/MenuTableViewController.m
+++ b/samples/WOCCatalog/WOCCatalog/MenuTableViewController.m
@@ -39,6 +39,18 @@ static NSString* viewTitleKeyName = @"ViewName";
     [self.menuItems addObject:[NSDictionary dictionaryWithObjectsAndKeys:title, viewTitleKeyName, controllerClass, controllerKeyName, nil]];
 }
 - (void)viewDidLoad {
+    // this doesn't even show up (same issue as WYPopoverController _overlayView)
+    UIView* red = [[UIView alloc] initWithFrame:self.view.bounds];
+    red.backgroundColor = [UIColor redColor];
+    red.alpha = 0.5;
+    [self.view.window addSubview:red];
+
+    // this shows up but touches on menu table aren't blocked
+    UIView* green = [[UIView alloc] initWithFrame:self.view.bounds];
+    green.backgroundColor = [UIColor greenColor];
+    green.alpha = 0.5; // none of these alpha values matter for these tests
+    [self.view addSubview:green];
+
     [super viewDidLoad];
 }

It's weird that the same code in the pushed view controller blocks touches while in the root touches aren't blocked (and adding directly to the window reproduces the WYPopover issue).

Thanks for the added details.  FYI that I'll be out for the holidays, so we likely won't be able to investigate futher until early 2017.  Please let us know if this becomes a blocking issue though.

@jaredhms no prob, thanks for the assistance (with the autolayout stuff too!). I may file a few more bugs before going on break but my current app dev isn't blocked.

Note: I mentioned above some other problems with UITableViewCells and other misc views behaving strangely or not responding to touches. These issues have all been fixed against the latest develop (that contains the #1685 pull).

Awesome - thanks for letting us know.


Wrong image selection with camera

When choose use camera and take photo, it is showing 2 selected images.
After, If I open an image preview and then close it, It will add +1.
It will keep adding +1 even if I don't check the image preview.
Clicking in DONE btn send me back to previous activity with N times the camera image.

I also had this problem with android 7.0. I don't have duplicate selection problems when I use debug breakpoints, so I think it has something to do with that broadcast.
Can you talk about your solution?

I have the same question with SAMSUNG s7 & SAMSUNG s 8.
I solved it this way.
In ImagePickActivity :
private boolean findAndAddTakenImage(List<ImageFile> list) {
    for (ImageFile imageFile : list) {
        if (imageFile.getPath().equals(mAdapter.mImagePath)) {
            boolean contains = mSelectedList.contains(imageFile);
            if (contains) {
                return true;
            }
            mSelectedList.add(imageFile);
            mCurrentNumber++;
            mAdapter.setCurrentNumber(mCurrentNumber);
            tv_count.setText(mCurrentNumber + "/" + mMaxNumber);

            return true;   // taken image was found and added
        }
    }
    return false;    // taken image wasn't found
}


Add support for trailing line in lines

Fix #12 - make trailing line optional
By default the server and the client do not send a trailing line, but it can be enabled using the added options.

@vietj @pmlopes ready for review

:+1:


Disable adding tags when max-tags has been reached

Issue #225
Input to add more tags is hidden when max-tags limit has been reached

Coverage remained the same at 99.777% when pulling d0f00ee7d00b5fa9291184f7eae0368735e5a935 on matteoferigo:patch-1 into af9feb709f7c4ba03dca90e6a51b574f3a3e4fbc on mbenford:master.

+1


Copy link to clipboard

I imagine that the user wants the link copied to clipboard in most usecases
On linux, when xclip is installed the alias can be adjusted to:
"nc termbin.com 9999 | xclip -selection c"
That way the link is copied to clipboard. I do not know how this could be done on other platforms but it might be a useful hint to include on the website.

Great idea, we might add this. Btw, I'm thinking of creating a new website so this may take a while. Thanks!

For OS/X, it's pbcopy, e.g. echo foo | nc termbin.com 9999 | pbcopy

For linux you can pipe into xclip -selection c. On my machine I have an alias for it and termbin like so:
alias termbin='netcat termbin.com 9999'
alias setclip='xclip -selection c'

So then I can do somecommand | termbin | setclip.

I've added some of these command to our Readme file. Thank you!

For linux you can pipe into xclip -selection c. On my machine I have an alias for it and termbin like so:
alias termbin='netcat termbin.com 9999'
alias setclip='xclip -selection c'

So then I can do somecommand | termbin | setclip.

Nice - I actually had already previously created two scripts, xcopy.sh and xpaste.sh (I always use tab-key to auto-complete them, so I decided to leave the .sh suffix so one can see from filename that it's a shell script).
Difference in mine is that because the clipboard names (primary/selection) confuse me, I wrote my scripts so that it accepts -clipboard and -selection, where -selection really means the one where you paint a text with mouse to copy and middle-click to paste, and -clipboard means the usual copy/paste. Yeah, it also works with -c and -s. I had to recheck xclip man page too many times because I wasn't sure what I should use again ;p
Lately I also wrote scripts to copy whatever is in 'screen' pastebuffer with xcopy, or paste into the pastebuffer of screen session.


podman and buildah reporting different sizes for the same image

/kind bug
# podman images
REPOSITORY                 TAG      IMAGE ID       CREATED       SIZE
docker.io/library/fedora   latest   9110ae7f579f   5 weeks ago   246MB
docker.io/library/centos   7        e934aafc2206   10 days ago   207MB

# buildah images
IMAGE ID             IMAGE NAME                                               CREATED AT             SIZE
9110ae7f579f         docker.io/library/fedora:latest                          Mar 7, 2018 17:51      234.7 MB
e934aafc2206         docker.io/library/centos:7                               Apr 6, 2018 18:01      197.6 MB

Output of podman version:
Version:       0.4.1
Go Version:    go1.9.4
OS/Arch:       linux/amd64

Output of podman info:
host:
  MemFree:<PHONE_NUMBER>
  MemTotal:<PHONE_NUMBER>8
  SwapFree:<PHONE_NUMBER>
  SwapTotal:<PHONE_NUMBER>
  arch: amd64
  cpus: 4
  hostname: jw-laptop
  kernel: 4.15.16-300.fc27.x86_64
  os: linux
  uptime: 9h 43m 47.23s (Approximately 0.38 days)
insecure registries:
  registries: []
registries:
  registries:
  - docker.io
  - registry.fedoraproject.org
  - registry.access.redhat.com
store:
  ContainerStore:
    number: 4
  GraphDriverName: overlay
  GraphOptions:
  - overlay.override_kernel_check=true
  GraphRoot: /var/lib/containers/storage
  GraphStatus:
    Backing Filesystem: extfs
    Native Overlay Diff: "true"
    Supports d_type: "true"
  ImageStore:
    number: 2
  RunRoot: /var/run/containers/storage

Additional environment details (AWS, VirtualBox, physical, etc.):
# buildah version
Version:       0.16
Go Version:    go1.9.4
Image Spec:    1.0.0
Runtime Spec:  1.0.0
Git Commit:    82529cd
Built:         Wed Apr  4 11:22:14 2018
OS/Arch:       linux/amd64

Being fixed in Buildah, turns out they use the wrong size for units (1024 vs 1000)

This is a lot more work then I was thinking. I was thinking more that you would just add a one liner to the secrets patch if /etc/fips-mode then create it in the secrets directory.

@rhatdan Wrong issue?

oops.

Fixed on the buildah side


ubootNanoPCT6: init at 2024.01

Description of changes
Add U-Boot package for the FriendlyELEC NanoPC-T6.

Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Minor update, removed the SPI image config "override" with a force push because it doesn't seem to work. The board panics when booting from SPI. It might work with 2024.04, further citation needed.


Please cut a 0.12 release

Thanks for maintaining this crate.
I discovered it when I went hunting for GECOS support in the upstream crate. I was then pleasantly surprised to find uzers and that @apognu had already implemented it (nice one! :+1:).
It'd be great if that support ended up in a tagged release so I don't have to pull this crate from git. Thanks in advance!
P.S: given that the users crate has been abandoned for quite a while, I wonder if ya'll have reached out to<EMAIL_ADDRESS>to take over ownership yet?

Will do! Thanks for bringing it up.

Done

Thanks kindly! :tada:


Fix scroll by arrow navigator not work + Fix focus on previous selected item

Fix #678.
Fix previous selected item not focused when select component again.

+1


Double password visibility toggles

When using com.firebaseui:firebase-ui-auth:0.6.0 with Android Support Library, revision 24.2.0. I get two icons to toggle password visibility because this feature is now built-in.
As temporary fix I have downgraded my Android Support Library to 24.1.0.

@nicbell thanks for the report!  We're actually using 23.x for all our testing for other reasons, so we hadn't seen this yet.

I noticed this issue before, but never bothered to do extensive research on it because I thought it was an isolated issue. I did however notice that if you don't set the eye drawable it still shows up which is weird. Since somebody else noticed this issue on the same version of the support lib that I'm using, I decided to check the release notes and indeed in v24.2.0 they added the password visibly toggle as the default. I'll submit a PR upgrading us to 24.2.1 unless somebody else wants to.

@SUPERCILEX the reason we're not on 24.x is because Robolectric still only has support for API <= 23, so if we go to 24 we lose testing (or we're testing strange zombie code, which is just as bad).

Mockito 2.x came out. Doesn't it support api 24?

It's Robolectric, not Mockito.
We can try specifying sdk = 23 in the @Config annotation in all of our tests and then upgrading to support 24.x.x and SDK 24, if that works I'd be OK with it.

My bad, I'll try getting Robolectric to play nice tonight.

Thanks to #349 by @SUPERCILEX I was able to push version 0.6.1 which has all the latest dependencies and should no longer have this issue!


AMD Adrenalin Software reports incorrect display resolution

I'm using the Vitual Display Driver as part of a headless game streming host (with Sunshine and Moonlight), streaming to an iPad Pro 12.9 inch at native resolution - 60fps.
I am looking to leveage global FSR scaling for one particular game via AMD Adrenalin software. To enable FSR you must set the in-game resolution to a lower value than native resolution, FSR wil then automatically upscale.
The issue I'm facing is the AMD Adrenalin Software is identifying my monior resolution as 640x480, which is incorrect (windows display settings reports the correct resolution). With AMD Adrenalin unable to identify the correct resolution, I'm unable to enable the global FSR feature.
I suspect this is due to the exclusive use of the IDD driver (i.e no physical monitor connected to the host) perhaps?
Does anyone know of a fix?

Can you try removing all unneeded resolutions from options.txt so that it defaults to the correct resolution? Unless of course you use more than one. Be sure to leave the space at the end of the options.txt file as well.
We have a solution in the source (and upcoming built driver) that allows directly attaching to a GPU.

@itsmikethetech - thanks for the reply and appologise for the delay in mine.
I've edited the options.txt file to contain only one resolution 2732 x 1960 @60Hz. Unfortunately AMD Adrenaline still reports a display resolution of 640 x 480.

We have a solution in the source (and upcoming built driver) that allows directly attaching to a GPU

When are you expecting to do a release with this fix?

Whenever I'm finished with code optimisations hopefully!

@itsmikethetech Directly attaching to GPU sounds great. By source you mean on one of the available branches or is it private?
I would love to try it out, if possible 😄

Beta HDR version with GPU switching out now. First time public, so there could be bugs. https://github.com/itsmikethetech/Virtual-Display-Driver/releases/tag/24.7.18HDR

We have a solution in the source (and upcoming built driver) that allows directly attaching to a GPU.

@itsmikethetech - do we belive this will fix the issue with AMD Adrenaline not detecting the correct resolution of the virtual display?
Keen to leverage system wide FSR, but will likely hold off 'till a stable release as this is my primary gaming rig 

@jnahumphreys Did you actually get VDD listed as a display in Adrenaline, or are you getting the resolution value from somewhere else?
Adrenaline only lists the physical monitors on my end. Never VDD, so I'm missing Monitor features.

Is there something to do to even have the virtual display show up in Adrenalin? I have the beta release with the xml config files, I manually set the gpu in the config, I had to update to Windows 11 24H2 to even have hdr working.

Just dropping in to leave my two sense. Unfortunate if you can not get FSR working. I have not been able to get the display to detect in AMD Adrenaline, I think that is by design as it is a Virtual Display Adapter; by design it is not attached to the GPU so it is not available to set custom resolutions ETC within Adrenaline.
I particularly am entering the chat to perhaps suggest a solution in relation to a separate issue I encountered and was able to resolve after investigating. When playing most games they would have no issue rendering at the resolution I have set in windows and the game itself. Immortals Fenyx Rising however, did not cooperate. It would have black bars at the top and bottom of the screen and a weird effect on the sides. In the Video settings it showed my native resolution as 1024 x 768 and aspect ratio as 4:3 in troubleshooting I suspected this was my #1 clue to resolving the issue. I determined that in the options.txt 1024 x 768 was the first resolution entry as I had it sorted by resolution. I shifted my preferred resolution to be the first entry and reloaded the Virtual Display Driver and sure enough my scaling was resolved. If the offending game intended to use FSR on has similar backend it may resolve your issue to try this. I have no issues with HDR and I did not have to use the Beta driver with adapter.txt, I tried it but after finding the solution I reverted and still have no issue.
I am also including my workstation guide you can review briefly that includes some additional info that explains everything I have done. http://sh.uni2.cc/28JLJ

Yes, the since the display doesn't take a physical port, applications which control these will struggle to interface with these virtual displays, and as for the order of displays, yes that's correct, the "recommended" resolution will always be the first resolution inputted


fix: cypress snapshot types

Description
Fix the typing for matchImageSnapshot method.
Change the method of comparing screenshots to ssim, since there should be less false positives with this method. More info here.
Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!CAUTION]
🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9777944732
Commit: 76936b5e8652c6211f373b499529b86f105c86e7
Cypress dashboard.
Tags: @tag.Anvil
The following are new failures, please fix them before merging the PR:
cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts
cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts
cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts
cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts
cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts
List of identified flaky tests.

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[x] No

Summary by CodeRabbit

New Features

Enhanced snapshot comparison accuracy using the ssim method for different snapshot types in the AnvilSnapshot tool.
Updated generate:anvil-snapshots script with enhanced reporting.

Dependencies

Added @types/cypress-image-snapshot for improved type definitions.

Style

Adjusted padding for medium-sized buttons in the design system for better alignment and spacing.

/build-deploy-preview skip-tests=true


FRONTEND WITH FRAMEWORK: VueJS-3.2 => Class Binding

Description
Contributors are required to explain about Inline style manipulation using Bindings in Vue.js, which should cover questions like:-
What is Class Bindings in Vue.js?
How does this work?
What are the advantages to use it?
How to implement this with code (also give theory explanation of code)?
You can take 2-3 examples with codes of different types to explain this.
etc....
Note:
Plagiarism is strictly prohibited.
Changes should be made inside the Frontend_Web_Development_React_Angular_Vue/ dir inside Frontend_Web_Development_React_Angular_Vue branch.
Files need to be added into the Week3 folder only.
Domain
Frontend Dev React/Angular/Vue
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign


Fix typo

Oops

Your GH Refined extension is broken again … or was it from mobile?

no no wait, this was done on another computer without the extension.

although, thanks for manually doing the supposed-to-be-automated-thing


Why is the setting for transparency not working?

Have you tried the equivalent settings in Foxglove Studio?


JavaScript

JavaScript
As a boot camp student
I want the prework notes to be structured on a webpage
So that I can easily find and read the information
GIVEN a Prework Study Guide website
WHEN I view the study guide
THEN I can see the four topics I learned listed along with a suggestion on what I should study first

learning how to use js learning about arrays how to use this feature to be able to easily use my website and find the information that I'm looking for


[CapitalTVCy] Add Capital TV Cyprus extractor

Description of your pull request and other information
This pull request adds a new extractor for Capital TV Cyprus (CapitalTVCy). The extractor handles the extraction of YouTube video URLs embedded in the web pages of Capital TV Cyprus. This implementation ensures that users can download videos hosted on capitaltv.cy, which are embedded from YouTube.
The extractor parses the webpage to find the YouTube URL in the data-settings attribute of the video element and then delegates the actual video downloading to the YouTube extractor.
Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Fix or improvement to an extractor (Make sure to add/update tests)
[x] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

Nothing is needed from you right now. The PR looks good from my side, but to be merged, a maintainer will also need to review it. They may raise additional things, I didn't catch. This will happen as time permits.


Reactive version of ResponseUtil

This is needed for https://github.com/jhipster/generator-jhipster/pull/11416 and https://github.com/jhipster/generator-jhipster/issues/11404

@murdos Why create a specific ResponseUtil reactive classe and not reuse the existing?

@DanielFran : a non reactive JHipster project can't use an utility class that depends on Reactor, because it doesn't have the dependency. Thus it was necessary to use a distinct class.

Yes i saw it 😅😂🥱😴

I plan to do a new release of jhipster dependencies (3.6.0)
Do you want to merge this @murdos ?

Yes, that would be nice, if there's no objection!


(onAddressChange) not fired with Angular10

I used ngx-google-places-autocomplete without troubles. But since I updated to Angular10, the event (onAddressChange) is not fired any more. Any solution ?

I just ran into the same problem, for me adding 'place_id' into the fields parameter of the options works as a workaround. Not a soltution to the problem but better than always having to request all items.

It is because of this line btw:
https://github.com/skynet2/ngx-google-places-autocomplete/blob/707ddd9bfc58c5e3135e2d5dd3cba6e647cfc7a5/src/ngx-google-places-autocomplete.directive.ts#L94

Fixed in 2.0.5, please update. (#47 )


Implementation of Network Slimming

Hi,
Is it possible to release the code for your network slimming implementation which is reported in the paper. The original code seems to have problems with large pruning ratio.
Thanks.

Hi,
You can use the mask-impl from https://github.com/Eric-mingjie/network-slimming  for larger pruning ratio.
Thanks

Thank you, we will give it a try.
Regards


[Extractor] Deploying multiple extracted apis: PessimisticConcurrencyConflict,  Operation on the API is in progress

Context
We have organized our apim arm template project according to the proposed structure

We are using the extractor, and then have an additional tool slightly manipulating and inserting the extracted templates into our arm template solution. We have this folder structure in our arm template project (*.deployproj):
.
├── master.template.json
├── master.parameters.json
├── named-values.template.json          # linked to from master
├── tags.template.json                  # linked to from master
├── Api/
    ├── apis.template.json              # linked to from master, sub-master links to all apis
    ├── petstore/
        ├── petstore.template.json
        ├── petstore-apiPolicy.xml
        ├── get-pet-operationPolicy.xml
    ├── another-api/
        ├── another-api.template.json
        ├── another-api-apiPolicy.xml
    └── ...
├── Product/
    ├── products.template.json          # linked to from master, sub-master links to all products
    ├── unlimited.json
    ├── unlimited-productPolicy.xml
    ├── starter.json
    ├── petstore.json
    ├── petstore-productPolicy.xml
    └── ...
└── ...

In the master template we have dependencies between the "sub-master"s like this (excluding a lot of properties and parameters):
{
    "name": "apisTemplate",
    "type": "Microsoft.Resources/deployments",
    "dependsOn": [
        "namedValuesTemplate",
        "apiVersionSetListTemplate",
        "productsTemplate"
    ]
}, {
    "name": "namedValuesTemplate",
    "type": "Microsoft.Resources/deployments",
    "dependsOn": []
}, {
    "name": "productsTemplate",
    "type": "Microsoft.Resources/deployments",
    "dependsOn": []
}, {
    "name": "tagsTemplate",
    "type": "Microsoft.Resources/deployments",
    "dependsOn": []
}

When using the extractor it adds the product<->api binding in the bottom of the api templates, and that resource looks like this:
{
    "name": "[concat(parameters('ApimServiceName'), '/unlimited/petstore')]",
    "type": "Microsoft.ApiManagement/service/products/apis",
    "apiVersion": "2019-01-01",
    "dependsOn": [
        "[resourceId('Microsoft.ApiManagement/service/apis', parameters('ApimServiceName'), 'petstore')]"
    ]
}

Problem
We currently have ~40 apis and ~30 products. When deploying this to the azure resource manager we have gotten more and more errors like this. It is not consistent on which template it fails, or even how many templates fails. Deployment fails 60-70% of the time, and we just have to redeploy until it works.
"properties": {
    "statusCode": "Conflict",
    "statusMessage": "{\"error\":{\"code\":\"PessimisticConcurrencyConflict\",\"message\":\"Operation on the API is in progress\",\"details\":null}}"
}

In the activity log it either fails with this message on either "Create API or Update API" or "Add API to product".
Azure support
An issue with support was raised, #120012721000749 for those of you with access, and we got the feedback that there was a lock/race situation going on. When asking further it seems like the resource type Microsoft.ApiManagement/service/products/apis places a lock on both the api and product.
Solution?
We tried to flip the situation and did a quick POC where we moved the product<->api binding to the product file (and also reversed the master dependsOn between apisTemplate and productsTemplate). We did this because it seemed like the resource Microsoft.ApiManagement/service/products/apis belongs to product. This seems to work 100% of the time. However, I'm unsure if this is a long term solution since support said that the lock is on both api and product. If that's true, it means that we are just "lucky". Because the products are deployed in parallel and several of them has bindings to the same api.
Help
Any thoughts..? Asking here since the extractor currently adds the api<->product binding in the api template file.

Hi @bremnes , I checked with the APIM backend team, the deployment failure is caused by adding the same api to different products at the same time. When adding apis to product, will in fact create new revision of the Api, if it's running concurrently, the write to the same api will cause a race, and currently this situation will not change. So you are right about creating dependencies for a series of api-product relation templates, but what's different is that we should create the dependencies within each apiTemplate, since we only need to make sure that adding api to multiple products happens sequentially.

Hi again @RupengLiu,
I revisited this again and tried your suggest approach - I ran a script on all our api templates where I created a dependsOn "chain" so that the product<->api bindings were deployed sequentially for each api.
Here's the result of deploying 15 times:

4 failure with PessimisticConcurrencyConflict Operation on the API is in progress
1 timed out/failed. Ran for 45 minutes before I killed the deployment (it usually runs in 2-5 minutes when successfully).
1 failed with PessimisticConcurrencyConflict Operation on repositories is in progress (never seen this before)
9 ran OK

So it seems like it's some kind of racing condition on both the apis and the products - meaning we can't deploy api-product bindings in parallell at all.
I tested one final thing where I introduced a productApiBindingsTemplate linked to from master which has a dependency to productsTemplate and apisTemplate. I moved all api-product bindings inside that file and then made them run sequentially by chaining the dependsOn attribute. This works and deploys successfully 14 of 15 times, but to be honest I'm not a big fan of this solution..
On to more exploring. Perhaps I'll try deploying the apis sequentially or something.

I'm running into this same issue.
@bremnes, did you have any luck with deploying apis sequentially? I'm considering the same strategy.

Hi @awnugent,
I tried several approaches, but it all comes down to this locking situation where the possibility of failure increases exponentially the more apis you try to deploy in parallel. We talked with Microsoft as well, and they confirmed our thoughts and advised to use dependsOn as well. So what I ended up with was to deploy sequentially in our apis.template.json. It takes longer, but at least it works every time. (Sidenote: we will probably split the apis into smaller deployable units.)
So basically something like this. As mentioned earlier we've created a wrapper around the extractor which does additional things like organizing the extracted templates into our arm template project, and now also chain the dependsOn attribute:
...
{
	"apiVersion": "2017-05-10",
	"name": "petstoreTemplate",
	"type": "Microsoft.Resources/deployments",
	"properties": {
		"mode": "Incremental",
		"templateLink": {
			"uri": "[concat(parameters('_artifactsLocation'), '/Api/petstore/petstore.template.json', parameters('_artifactsLocationSasToken'))]",
			"contentVersion": "<IP_ADDRESS>"
		},
		"parameters": {
			"url, artifacts location, sas token and apim instance name"
		}
	},
	"dependsOn": [
	]
}, {
	"apiVersion": "2017-05-10",
	"name": "echoTemplate",
	"type": "Microsoft.Resources/deployments",
	"properties": {
		"mode": "Incremental",
		"templateLink": {
			"uri": "[concat(parameters('_artifactsLocation'), '/Api/echo/echo.template.json', parameters('_artifactsLocationSasToken'))]",
			"contentVersion": "<IP_ADDRESS>"
		},
		"parameters": {
			"url, artifacts location, sas token and apim instance name"
		}
	},
	"dependsOn": [
		"petstoreTemplate"
	]
}, {
	"apiVersion": "2017-05-10",
	"name": "wikiTemplate",
	"type": "Microsoft.Resources/deployments",
	"properties": {
		"mode": "Incremental",
		"templateLink": {
			"uri": "[concat(parameters('_artifactsLocation'), '/Api/wiki/wiki.template.json', parameters('_artifactsLocationSasToken'))]",
			"contentVersion": "<IP_ADDRESS>"
		},
		"parameters": {
			"url, artifacts location, sas token and apim instance name"
		}
	},
	"dependsOn": [
		"echoTemplate"
	]
}
...

When it comes to building support for this scenario into the extractor tool, I'm not so sure. Currently the extractor doesn't really deal with existing files and a project structure, so at least some work is required.

@bremnes - did you have any work around or suggestion for this.
Am using creator tool, there also am facing the same issue.

I am also facing same issue. any solution to avoid Operation on the API is in progress error

@SSanjeevi, we ended up doing what I've commented earlier. If you look at my first post, then we have a custom tool wrapped around this resource kit. In that tool we add/manipulate the order of apis in apis.template.json. In that file we're adding a "dependsOn" on all the individual APIs so that we deploy them sequentially like described in my last comment. Unfortunately that means the deployment will take a bit longer, but at least it's working 100% of the time.

Hi @bremnes, We just hit this same issue. Do you have any more information you could share on the custom tool that wraps the resource kit? We'll likely need to implement something similar, unless there has been further updates on the support ticket.  Thanks!

Taking a look at this since we just ran into the same issue.
Sounds to me like this could be fixed in the resource kit with the following steps:

Move the product/api resources to their own template, which depends upon the product template and all API templates
Create an arbitrary dependency chain, so each product/api resource depends upon the previous one

This will force all the product/api resources to be deployed in series, after the products and APIs.
I'd like to take a crack at implementing this fix. Any concerns with the approach outlined above?

While testing this, it looks like the issue also occurs if the APIs have a common tag resource. The tags are deployed before the APIs, but the APIs can still experience the issue if two APIs have a shared tag in the OpenAPI definitions.
Since the definition is contained in the API resource itself, I don't think there's a resolution for this except to deploy the APIs sequentially, rather than in parallel.

Figured I'd post it here, in case it may help. Here's the powershell script we came up with to loop through the api folders (SplitAPIs = true), and add the "dependsOn" for each one...generating the sequential deployment.
`
$templatePath = "..\APIM";
$ApiFolderList = Get-ChildItem -Directory $templatePath | Select-Object -Property Name;
$templatePath += "\master.template.json";
$armTemplate = Get-Content -Path $templatePath -Raw | ConvertFrom-Json;
$previousFolder = "First";
$index = 7;
$ApiFolderList = $ApiFolderList | ? { $_.Name -ne "policies" };
for ($i = 0; $i -lt 7; $i++) {
$armTemplate.resources[$i].properties.parameters.PolicyXMLBaseUrl.value = "[concat(parameters('PolicyXMLBaseUrl'), '/policies')]";
}
foreach ($folder in $ApiFolderList) {
#for ($folderIndex = 0; $folderIndex -lt $ApiFolderList.Count; $folderIndex++) {
#$output = "'/" + $folder.Name + "/master.template.json'rn";
#$output;
if ($armTemplate.resources.Length -lt $index + 1) {
    #append new row here
    $tempRow = $armTemplate.resources[$index - 1];
    $armTemplate.resources += ConvertFrom-Json -InputObject (ConvertTo-Json -Depth 100 -InputObject $tempRow)
}

#update templateLink in resources/properties
$armTemplate.resources[$index].properties.templateLink.uri = "[concat(parameters('LinkedTemplatesBaseUrl'), '/$($folder.Name)/master.template.json')]"

#add LinkedTemplatesBaseUrl in resources/propertes/parameters
if ($previousFolder.Equals("First")) {
    #$tempLinkedTemplatesBaseUrl = $armTemplate.resources[$index].properties.parameters.PolicyXMLBaseUrl;
    #$tempLinkedTemplatesBaseUrl.value = "[concat(parameters('LinkedTemplatesBaseUrl'), '/$($folder.Name)')]";

    $temp = "
        {
            ""value"":""[concat(parameters('LinkedTemplatesBaseUrl'), '/$($folder.Name)')]""
        }
    ";

    $tempLinkedTemplatesBaseUrl = ConvertFrom-Json -InputObject $temp;

    $armTemplate.resources[$index].properties.parameters | Add-Member -MemberType NoteProperty -Name "LinkedTemplatesBaseUrl" -Value $tempLinkedTemplatesBaseUrl;
} else {
    $armTemplate.resources[$index].properties.parameters.LinkedTemplatesBaseUrl.value = "[concat(parameters('LinkedTemplatesBaseUrl'), '/$($folder.Name)')]";
}

#modify PolicyXMLBaseUrl in resources/properties/parameters
$armTemplate.resources[$index].properties.parameters.PolicyXMLBaseUrl.value = "[concat(parameters('PolicyXMLBaseUrl'), '/$($folder.Name)/policies')]";

#update name in resources
$tempName = $folder.Name + "Template";
$armTemplate.resources[$index].Name = $tempName

#modify dependsOn if not first api record
if (!$previousFolder.Equals("First")) {
    $tempString = $previousFolder + "Template"
    $temp = @($tempString);
    $armTemplate.resources[$index].dependsOn = $temp;
}

$previousFolder = $folder.Name;
$index++;

}
$armTemplate | ConvertTo-Json -Depth 100 | foreach { [System.Text.RegularExpressions.Regex]::Unescape($_) } | Set-Content -Path $templatePath
`

As part of our clean-up on old issues, we are closing this issue.  If the problem persists with the 1.0.0-beta releases, please open a new issue and provide all the required information.


add regex support

A few minor comments.

regex_objects.py in the hyperon root doesn't look nice. I'd just put its code into stdlib.py for now, and wouldn't introduce a separate regex_atom just for one token. There are text_ops, where regex can be put for now. If regex-related functionality becomes richer (or united with other string-processing tools), then we can either have a subfolder (stdlib or whatever) with this and possibly other larger parts of stdlib in separate files, or move it to its own module.
Regarding [[, etc., you can take a look how String is implemented in stdlib (with "\"[^\"]*\""). Something like "r\"[^\"]*\"" (like in Python, or "regex:... if we want to be more verbose) may work
regex_matcher_test.metta is not added as a unit test, and scripts folder is organized in a certain way. So, this test/example should either be put at some place in the other scripts, or should be just a Python test. But I can sort it out later, so maybe no actions should be taken regarding this point.


Header and footer links adjusted

Header and footer links adjusted

Changes 👷♀

- Header and footer links adjusted
How to test 🧪

- locally / heroku
Definition of done ✔

[ ] Acceptance criteria for each issue met
[ ] Unit tests written where needed and passing
[ ] End-to-end tests for happy path
[ ] Documentation updated
[ ] Project builds without errors
[ ] Non-functional requirements met
[ ] Code reviewed and functionality tested by the reviewer (locally, Heroku, etc.)
[ ] Feature verified and accepted by Product Owner
[ ] Project deployed to production environment

I think you left redirect to home page from borrow, or did @sennett already removed it in some PR?

I think you left redirect to home page from borrow, or did @sennett already removed it in some PR?

Redirecting from oasis.app/borrow to oasis.app/ was removed a while back.  oasis.app/borrow/slug -> oasis.app/slug was left and still works.


inline-asm on nightly

Hello,
With new asm! macro merged, it's impossible to use cotrex-m crate with inline-asm on nightly, because latest released version (0.6.2) still uses old asm!.
At the same time it's impossible to use cortex-m from git, because it then conflicts with cortex-m brough by other deps (rtfm, cortex-m-log, etc):
error: failed to select a version for `cortex-m`.
    ... required by package `cortex-m-log v0.6.1`
    ... which is depended on by `fcfs-rtfm v0.1.0 (/Users/r/prj/p/copterust/fcfs-rtfm)`
versions that meet the requirements `= 0.6.2` are: 0.6.2

the package `cortex-m` links to the native library `cortex-m`, but it conflicts with a previous package which links to `cortex-m` as well:
package `cortex-m v0.6.2 (https://github.com/rust-embedded/cortex-m?rev=c9c7539233954822a6132f4bc13e5763371b5cb2#c9c75392)`
    ... which is depended on by `fcfs-rtfm v0.1.0 (/Users/r/prj/p/copterust/fcfs-rtfm)`

What's the recommended course of action, besides not using inline-asm?  (refs #217).

@little-arhat did using patch work OK for you?

@adamgreig yes, thanks! is there ETA for a proper fix?

The next release will have a fix; see #217 for updates but hopefully soon.