Multiple points are highlighted when hovering over them

Testcase: http://jsbin.com/mufehi/1/edit?html,js,output
Screenshot:

I wouldn't say this was necessarily this is a bug more a setup issue.
By default the hit radius on a point is 20, where as the point radius is 4, once the points get too close together that hit radius overlaps even when the points do not.
It might make sense to keep this values the same in the default configuration or to make people aware of the option to pass pointHitDetectionRadius in the docs.
here is a fiddle showing this doesn't happen that option is set
http://fiddle.jshell.net/leighking2/zwgzz4yo/

Hello,
I tried out to pointHitDetectionRadios: 1 but in my graph there are a lot of points, so is impossible only to select one. I'm trying get the point.label througth the getPointsAtEvent(evt) but I never know what is the exactly point that I clicked on due I get an array of points (two by serie, I'd like to get one by serie)

I really appreciate any help you can provide.

Hello, today I am closing all issues that are only affecting version 1 of Chart.js as WONTFIX.
If this issue does affect version 2 as well, I apologize for the error. Please create a test case against Chart.js 2 using on of the below websites and we will be happy to reopen the issue and update its classification:

http://jsbin.com/
http://jsfiddle.net/
http://codepen.io/pen/
Premade template: http://codepen.io/pen?template=JXVYzq


Need a Dockerfile or Procfile

can you please add the docker support or Heroku support

OK, will add it today.

I'm working on add a Dockerfile to this project, if that is Ok.

I'm working on add a Dockerfile to this project, if that is Ok.

It's ok

Done


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-yml-archive-non-versioning-archive/pull/428 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-yml-archive-non-versioning-archive.git

Docs Build status updates of commit 632b6b3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/TOC.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-3.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-3.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Cannot connect with client-go

Issue Report Template
Tectonic Version
1.5.5
Environment
AWS
Steps to reproduce
I have setup a tectonics cluster on AWS and downloaded the kubeconfig file from the dashboard.
the config looks like the following and works like a charm with kubetctl:
apiVersion: v1
clusters:
- cluster:
    certificate-authority-data: <data>
    server: https://myurl:443
  name: tectonic
contexts:
- context:
    cluster: tectonic
    user: tectonic-oidc
  name: tectonic
current-context: tectonic
kind: Config
preferences: {}
users:
- name: tectonic-oidc
  user:
    auth-provider:
      name: "oidc"
      config:
        client-id: tectonic-kubectl
        client-secret: <data>
        id-token: <data>
        idp-certificate-authority-data: <data>
        idp-issuer-url: https://myurl/identity
        refresh-token:  <data>

Now, when I try to connect with a go program from outside
func main() {
	kubeconfig := flag.String("kubeconfig", "config-tectonic.yaml", "absolute path to the kubeconfig file")
	flag.Parse()

	cfg, err := clientcmd.BuildConfigFromFlags("", *kubeconfig)
	if err != nil {
		log.Printf("Error configuring the Kube client (%s)", err)
		panic(err.Error())
	}

	cl, err := kubernetes.NewForConfig(cfg)
	if err != nil {
		log.Printf("Error creating a new Kube client (%s)", err)
		os.Exit(1)
	}
...

I get an error No Auth Provider found for name "oidc" in cl, err := kubernetes.NewForConfig(cfg).
I would have expected the standard login procedure to also work with the auth provider oidc.
Well, at least kubectl is doing something additional to work properly and I can't find it documented prominently. Maybe this issue is only a documentation issue ...

Hey @vasu1124 thanks for filing this issue. I've let @IvanCherepov know, and he'll followup with you shortly.

Client-go no longer imports OpenID Connect packages by default[1]. I believe you need to import "k8s.io/client-go/plugin/pkg/client/auth/oidc".
[1] https://github.com/kubernetes/kubernetes/pull/41532

Thanks a lot for this hint. Works now.
I was not able to google the solution myself. And you normally don't fall in this trap with minikube or kube-solo setups. => docu improvement suggested.


opt in to telemetry collection for CI

@PoiScript let me know if you would prefer otherwise, but it seems sensible to allow telemetry collection for dotnet in CI.
This should hopefully disable the noise: https://travis-ci.org/PoiScript/docx-rs/builds/636260111#L398
You can read about what they collect here

Nevermind actually. We would need to disable telemetry altogether to avoid the initial warning: https://travis-ci.org/PoiScript/docx-rs/builds/646979835#L379

Thanks for the pr. To be honest, traivs-ci is not the best choice for project using multiple programming languages. I will take a look at GitHub Actions and see how to switch to it.


test: Add secret-role crds, Role and BindingRole with Pending test of both

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Issue ticket number and link
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:

[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have updated labels (if needed)

/retest

How do you delete the Role and the BindingRole, manually?
Maybe it should be put in the code

Hi @kasemAlem   ,
the CI configuration in main branch of e2e-tests repository was recently updated and it no longer uses pre-kcp branch of infra-deployments for bootstrapping appstudio on OCP cluster. Now it uses main branch, which leverages kcp.
Since appstudio/hacbs services are not fully integrated with kcp yet, lots of tests implemented in this repo can't be run successfully against it.
To address this, a branch "pre-kcp" was created in e2e-tests repo and can be used for adding/updating tests that can be run against "pre-kcp" version of appstudio.
Once we are able to run e2e tests for all appstudio/hacbs services successfully, the plan is to merge back all changes done in pre-kcp branch back to main.
If your PR is intended to update test used for "pre-kcp" version of appstudio, please update the base branch in your PR like this:

Thanks!


Authenticate via POST

Is it currently possible to authenticate solely via POST? I'd like to make the rclone web UI available on our HPC cluster as an Open OnDemand Interactive App. The user will already be authenticated via the Open OnDemand when they launch an interactive app, and shouldn't have to authenticate again with a different username / password.
An approach used for an RStudio Server OOD interactive app is to generate a temporary password (which the user never sees) and set an environment variable that RStudio Server will use to determine the password when it launches. The user is presented a form with this password in a hidden field; when the user clicks the "Connect" button in this form, they are logged in without needing to authenticate again. Similarly for Jupyter Lab (except in this example, the temporary password is written to a config file).
It would be great if a similar approach could be used for the rclone web UI.

Similarly, could an option be added to disable the HTTP Basic authentication in the rclone web ui? The Open OnDemand web portal already uses basic auth, and the additional authorization header from the rclone web ui appears to be conflicting with the authorization header for OOD.

Similarly, could an option be added to disable the HTTP Basic authentication in the rclone web ui? The Open OnDemand web portal already uses basic auth, and the additional authorization header from the rclone web ui appears to be conflicting with the authorization header for OOD.

Yes. We can add an option to disable the HTTP authentication. Rclone rcd already supports --rc-no-auth flag to achieve that, it needs to be enabled in the web ui as well. I think it will be great to include that. I will add the commit as soon as possible.

Is it currently possible to authenticate solely via POST? I'd like to make the rclone web UI available on our HPC cluster as an Open OnDemand Interactive App. The user will already be authenticated via the Open OnDemand when they launch an interactive app, and shouldn't have to authenticate again with a different username / password.
An approach used for an RStudio Server OOD interactive app is to generate a temporary password (which the user never sees) and set an environment variable that RStudio Server will use to determine the password when it launches. The user is presented a form with this password in a hidden field; when the user clicks the "Connect" button in this form, they are logged in without needing to authenticate again. Similarly for Jupyter Lab (except in this example, the temporary password is written to a config file).
It would be great if a similar approach could be used for the rclone web UI.

I think using your custom authentication, instead of the one provided by rclone will solve your problem. What do you think?

I think using your custom authentication, instead of the one provided by rclone will solve your problem. What do you think?

By default, the Open OnDemand portal uses HTTP Basic auth. But the interactive apps that are launched on a cluster compute node by a resource manager may be accessible to anyone who has SSH access to the cluster login node (using SSH port forwarding). So there should be some additional authentication mechanism to protect unauthorized access to the the rclone web UI (not HTTP Basic auth, unless it can be made to play nice with Open OnDemand's HTTP basic auth, which looks difficult?)
Currently, when I build an rclone Docker image from the nascent rclone Dockerfile and run it; e.g.:
docker run -it --rm -p 8080:8080 rclone:16e7da2 rcd --rc-web-gui --rc-addr :8080 --rc-user myuser --rc-pass mypass

I'm first greeted by an HTTP basic authentication dialog box, and then after entering myuser/mypass, I'm greeted by a web-form-based authentication that then prompts me to enter the same credentials, click "verify", and then click "Login". I'm not a web front-end developer, and might be way off, but I'd guess this form is sending the user name & password via POST, and setting a cookie with a session ID? If so, could
form be "overridden" to allow authentication via POST from an Open OnDemand view connection form using well-defined POST variables like the aforementioned RStudio Server example?
FWIW, since rclone seems to be commonly used in HPC environments, and Open OnDemand seems to be an increasingly-popular platform for running graphical & web-based applications on HPC clusters, I think this would be a really cool use case. In some cases, it might be an alternative to Globus.


METABASE - migrate existing metabase data to new instance

Describe the task

Card # 247 investigated the migration of metabase data to a new instance: https://app.zenhub.com/workspaces/low-carbon-fuel-standard-644c2db3be098a001977ad0b/issues/gh/bcgov/lcfs/247
From the investigation work, we identified a method for migrating all the sqls, models, and dashboards from the existing instance of Metabase to the new instance

Migration of Metabase:
Following observations have been made from local setup of Metabase and migration to new instance.
By copying the pg_dump of metabase data to the new instance we can retrieve all the sqls, models and dashboards.
New instance should be connected to the new db or existing tfrs db where the pg_dump has been copied to.
metabase: image: metabase/metabase:latest ports: - 3001:3000 environment: - MB_DB_TYPE=postgres - MB_DB_DBNAME=tfrs - MB_DB_PORT=5432 - MB_DB_USER=user - MB_DB_PASS=password - MB_DB_HOST=db
After copying the data ensure to reset the database connection and delete the ZEVA, ITVR and other unwanted collections and database connections.
New instance will continue to have all the users from the old instance while retaining the passwords too. Ensure deleting them as an Admin user.
Acceptance Criteria

[ ] first
[ ] second
[ ] third

Additional context

Add any other context about the task here.
Or here

Hey team! Please add your planning poker estimate with Zenhub @hamed-valiollahi @kevin-hashimoto @prv-proton


cannon-es and  physx-js

Hey,
do you have any plans to add this two physics?

Hi
cannon no i already try but i have perf issue with many body
physx ;)

you know https://github.com/pmndrs/cannon-es ? works fine for me from performance side
but physx could be awesome

yes cannon is great engine but conversion is difficult
and basic demo like 'start ' or 'basic' are slow
maybe i don't use the best option, and is possible i add in future

Almost all these samples run much slower than almost all the cannon-es samples on Android and IOS.

ok is done


mixRelease: improve the implementation

Description of changes
This PR includes lots of changes for improving mixRelease.

Currently, I'm implementing them as separated commits, which is helpful to review by others. But, if necessary, I can squash them into one single commit.

Every commit is self-explanatory. You can get more details by reading the description of commits.
Highlights:

investigate the reason why erlang is always referrenced.
add new option - removeCookie (default to true, which is for backward compatibility).
wrap programs in $out/bin with their runtime deps.
format the code and comments in a more consistent way.

Feel free to comment, and I can improve this PR as needed.

@happysalada , I found that you are the primary maintainer of this file, so I @ you. Hope that I'm not disturbing you.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

The general cleanup looks good to me.
Just one comment, be careful when formatting a file. Right now there is an RFC in nixpkgs to decide exactly of the formatting, and the formatter still hasn't been chosen.
Usually formatting commits are not accepted. (that RFC should finish at some point, but it could easily take another 6 months - 1 year.
As to the commits, they are very detailed which is really nice for the review. If you don't mind though, I'll squash them upon merging.
I'm leaving this open for another 24 hours just in case more people want to have a look at it.

Thank you for enlightening me about the background knowledge related to format.
And, I have committed what you suggest.

forgot to tag @NixOS/beam
I'm going to wait for 24h more just to give people who want time to review.


DataSet.batches() collection and Batch.rename(, ..., refs=True)

probably we need to undo the batch.rename(...refs=True) adjustment, as the project_spec keys are not connected with the batch-name. the project_spec itself is YG-specific and the keys are stored in Batch.build_info


Failed to fetch index

Hi! I'm trying to get full-text search on my gatsby js site working with your plugin. I updated my gatsby config and created a Search.js component with the code in your readme. Then I'm trying to import that component into my site index.js so that it is always with the site navigation. I get the error Failed to fetch index in the console and the search doesn't appear to do anything.
Can you let me know what I'm doing wrong?
Gatsby Config for the plugin:
{
      resolve: `gatsby-plugin-lunr`,
      options: {
        // ISO 639-1 language codes. See https://lunrjs.com/guides/language_support.html for details
        languages: ['en'],
        // Fields to index. If store === true value will be stored in index file.
        // Attributes for custom indexing logic. See https://lunrjs.com/docs/lunr.Builder.html for details
        fields: [
          { name: 'title', store: true, attributes: { boost: 20 } },
          { name: 'tags', store: true },
          { name: 'categories', store: true },
          { name: 'content' },
          { name: 'path', store: true },
      ],
        // A function for filtering nodes. () => true by default
        filterNodes: node => node.frontmatter !== undefined,
        // How to resolve each field's value for a supported node type
        resolvers: {
            // For any node of type MarkdownRemark, list how to resolve the fields' values
            MarkdownRemark: {
                title: node => node.frontmatter.title,
                tags: node => node.frontmatter.tags,
                categories: node => node.frontmatter.categories,
                content: node => node.rawMarkdownBody,
                path: node => node.frontmatter.path,
            },
        },
      },
    },

Search.js component
import React, { Component } from 'react';

// Search component
export default class Search extends Component {
    constructor(props) {
        super(props)
        this.state = {
            query: ``,
            results: [],
        }
    }

    render() {
        return (

                <input type="text" value={this.state.query} onChange={this.search} />

{this.state.results.map(page =>
{page.title}
)}

        )
    }

    getSearchResults(query) {
        if (!query || !window.__LUNR__) return []
        const results = window.__LUNR__.index.search(query)
        return results.map(({ ref }) => window.__LUNR__.store[ref])
    }

    search = event => {
        const query = event.target.value
        const results = this.getSearchResults(query)
        this.setState(s => {
            return {
                results,
                query,
            }
        })
    }
}

After build of the site, do you have search_index.json in your 'public' directory? what will be the result if you go to yourdomain/search_index.json in browser?

@deemaagog Gatsby build errors out with the below:
success Building static HTML for pages — 8.173 s
error UNHANDLED EXCEPTION

  TypeError: Cannot read property 'apply' of undefined

  - lunr.js:2673 lunr.Builder.use
    [portfolio-site]/[lunr]/lunr.js:2673:6

  - gatsby-node.js:57 lunr.Builder.<anonymous>
    [portfolio-site]/[gatsby-plugin-lunr]/gatsby-node.js:57:12

  - lunr.js:53 lunr
    [portfolio-site]/[lunr]/lunr.js:53:10

  - gatsby-node.js:53 Object.exports.onPostBuild
    [portfolio-site]/[gatsby-plugin-lunr]/gatsby-node.js:53:15

  - api-runner-node.js:110 runAPI
    [portfolio-site]/[gatsby]/dist/utils/api-runner-node.js:110:36

  - api-runner-node.js:187
    [portfolio-site]/[gatsby]/dist/utils/api-runner-node.js:187:33

  - map.js:27
    [portfolio-site]/[async]/internal/map.js:27:9

  - eachOfLimit.js:66 replenish
    [portfolio-site]/[async]/internal/eachOfLimit.js:66:17

  - eachOfLimit.js:50 iterateeCallback
    [portfolio-site]/[async]/internal/eachOfLimit.js:50:17

  - onlyOnce.js:12
    [portfolio-site]/[async]/internal/onlyOnce.js:12:16

  - map.js:29
    [portfolio-site]/[async]/internal/map.js:29:13

  - util.js:16 tryCatcher
    [portfolio-site]/[bluebird]/js/release/util.js:16:23

  - nodeify.js:23 Promise.successAdapter
    [portfolio-site]/[bluebird]/js/release/nodeify.js:23:30

  - promise.js:566 Promise._settlePromise
    [portfolio-site]/[bluebird]/js/release/promise.js:566:21

  - promise.js:606 Promise._settlePromiseCtx
    [portfolio-site]/[bluebird]/js/release/promise.js:606:10

  - async.js:138 Async._drainQueue
    [portfolio-site]/[bluebird]/js/release/async.js:138:12

  - async.js:143 Async._drainQueues
    [portfolio-site]/[bluebird]/js/release/async.js:143:10

  - async.js:17 Immediate.Async.drainQueues
    [portfolio-site]/[bluebird]/js/release/async.js:17:14

Gatsby develop serves up the site but /search_index.json doesn't show anything. I don't see search_index.json in my public directory.
Thanks for your help!

There was a bug. Please update package to the latest version and let me know if still doesn't work

Okay! So, I'm now on version 0.1.10. gatsby develop doesn't create the index but gatsby build does. When I search a bulleted list appears on the top of the page. So things appear to be mostly working. Do you have an exemplar that shows creating a separate results page?

@deemaagog Nevermind, I got it working. Thanks so much for your help!


Integration test definitions should be public

We have clear definitions for the various integration tests, but the document isn't publicly available. We need to figure out where to put it.

Is this covered by #1219?

@murgatroid99, yes. Resolved by #1219.


[Docs]: Replace "Setup with Create React App" section

Page(s)
https://jestjs.io/docs/tutorial-react#setup-with-create-react-app
Description
The React Tutorial page currently says:

Setup with Create React App
If you are new to React, we recommend using Create React App. It is ready to use and ships with Jest!

The React website changed its recommendation to frameworks like Next.js. However, it also mentions non-framework tools like Vite and Parcel.
Altough those tool don't have such nice documentation regarding unit tests and Jest, I think it would be good to change to them since Create React App is all but deprecated (last release in 2022.)
I would recommend cross linking to the Jest docs for Using Vite and Using Parcel.
Thanks!

Remove stale


Please remove macos-10.14 docs

Description
The docs at https://github.com/actions/virtual-environments/blob/main/images/macos/macos-10.14-Readme.md come up in a Google search for "GitHub Actions macOS 10.14".  There's nothing there that says the image has been removed, so I was misled into thinking that 10.14 was still available.  And the workflow I ran with runs-on: macos-10.14 didn't fail, so it took me a while to realize that I didn't do that test I thought I was doing.
I would suggest either removing the doc for macos-10.14 (and macos-10.13, for that matter) so that people aren't misled by search results, or perhaps adding notes to the top of the doc making it very clear that these environments are no longer available for GitHub Actions.
Virtual environments affected

[ ] Ubuntu 16.04
[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[X] macOS 10.15
[ ] macOS 11
[ ] Windows Server 2016
[ ] Windows Server 2019

Image version and build link
N/A
Is it regression?
No
Expected behavior
No response
Actual behavior
No response
Repro steps

search Google for "GitHub Actions macOS 10.14"
See that the docs at images/macos/macos-10.14-Readme.md come up at the top of the results
Note that the docs make no mention of the fact that the environment is not available for GitHub Actions

Hey, @joeyparrish
macos-10.14 agents are available in Azure Pipelines  -https://docs.microsoft.com/en-us/azure/devops/pipelines/agents/hosted?view=azure-devops&tabs=yaml , that's why we don't have any plans to remove the docs from the repo. The About GitHub-hosted runners is already updated and doesn't include mention about macos-10.14


Add commit hash to blame result

Signed-off-by: Shane Da Silva<EMAIL_ADDRESS>

@shanedasilva I don't know, we'll have to wait for maintainers to check it.
cc @mcuadros @strib @orirawlings


Updating the Wiki

We need some folks to help us update the wiki inside github. This is a great place for new user resources, set up guidelines, etc. I'd like to keep these kinds of materials out of the open issues as much as possible, because I think it detracts from the workflow.
If this interests you, comment here in this particular issue. Once we get a couple of people, I'll close this and we can start opening issues for specific Wiki needs. Thanks!

I'm up for doing some wiki-writing. : )
(just want to mention that it made it easier for me to step into thinking about doing something through posting a comment here in the working repo. The wiki is "something else" and more static, while here that's the place where things are happening, where people come by (and also respond) etc.  - I understand that's not the point of the Issues and might make them too convoluted. However, some of us are beginners in this type of collaborative work, so I think it's important to try to make the step across easier.
Just as a thought to consider - maybe there's another way to achieve something like this without filling up the Issues with conversation. Like me now. Ah...)

lol, @martin-martin. Issues are for conversation, so don't worry about that. I think we can make the wiki the source of truth for things like code conventions etc. They're criminally underutilized in a lot of projects, and the issues board tends to get clogged just like this.
My thought is that the README should contain a link to the wiki for common things. We just need to be diligent about keeping it updated.

I am interested in updating the wiki too, but I am still learning so I don't know if I will be able to solve the wiki issues, or just write as I go along to explain things from the perspective of someone who is new to collaboration, and tools like grommet, generators, etc.
Also, a silly question - do you update the wiki in the browser? I don't see a way to do a pull request updating the wiki in the browser.

Whoa! Yes @kellim !! : D
I just had the same question: https://udacityalumni.slack.com/archives/alumni-web-app/p1475739823000905
Okay @forbiddenvoid, ha! : )
It just seems easier with all the notification and people responding and such. I understand that it happens here more than in a wiki. (e.g. much easier to just post something here, as accidentally just exemplified by kellim and me)

@martin-martin : GitHub doesn't support pull requests for the wiki repository.
There are solutions around it. But I think they are to complicated.
I think we can give push permission to people willing to take care of the wiki.  I don't have admin permissions for the repo. But I will ask @RyanCCollins  to give you and @kellim push permission.

I just do it all in the browser!!

Hei Ryan - I think I don't have edit rights in the general wiki (udacityalumni/resources)
Couldn't find an edit button there.


fix(deps): missing matplotlib and mpmath

The non-GPU version also imports matplotlib and mpmath, found in

time_delay_estimation module
parameter_estimation_ECF.CF_bounded_Pareto() function

A clean install of the project result in:
$ poetry install --only main
$ python -c "import fppanalysis"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/een023/Documents/work/projects/fpp-analysis-tools/fppanalysis/__init__.py", line 13, in <module>
    from .time_delay_estimation import (
  File "/home/een023/Documents/work/projects/fpp-analysis-tools/fppanalysis/time_delay_estimation.py", line 4, in <module>
    import matplotlib
ModuleNotFoundError: No module named 'matplotlib'

Hmm, having some issues still, pointing to this.
Seems like matplotlib.axis does not exist? Maybe the intended code is matplotlib.pyplot.axis?
But then it used to work before? A bit confusing this.

Seems like fppanalysis version 0.1.2 isn't affected, and that commit 02c0b87fdb00d9efa7a944d20770b60f32de5d1d and b11ad645a598b08e7c5240a8b79224d14426920f may have introduced a bug.


{"error":"TypeError: Cannot read property 'api' of undefined"}

hi - I am now receiving this same error after no changes and the system was running fine until 12ET today. did the recent runtime upgrade affect this? here is the log output:
2021-10-12 18:46:36        RPC-CORE: getMetadata(at?: BlockHash): Metadata:: createType(Metadata):: decodeU8a: failed at 0x0e010b000c1c7370… on metadata:: decodeU8a: failed at 0xcc1853797374656d… on pallets: Vec:: decodeU8a: failed at 0x1853797374656d01… on : {"name":"Text","storage":"Option","calls":"Option","events":"Option","constants":"Vec","errors":"Option","index":"u8"}:: decodeU8a: failed at 0x011853797374656d… on storage: Option:: decodeU8a: failed at 0x401c4163636f756e… on items: Vec:: decodeU8a: failed at 0x04e8205468652066… on : {"name":"Text","modifier":"StorageEntryModifierV14","type":"StorageEntryTypeV14","fallback":"Bytes","docs":"Vec"}:: decodeU8a: failed at 0x68652066756c6c20… on modifier: {"_enum":{"Optional":0,"Default":1,"Required":2}}:: Unable to create Enum via index 104, in Optional, Default, Required
2021-10-12 18:46:36        API/INIT: Error: FATAL: Unable to initialize the API: createType(Metadata):: decodeU8a: failed at 0x0e010b000c1c7370… on metadata:: decodeU8a: failed at 0xcc1853797374656d… on pallets: Vec:: decodeU8a: failed at 0x1853797374656d01… on : {"name":"Text","storage":"Option","calls":"Option","events":"Option","constants":"Vec","errors":"Option","index":"u8"}:: decodeU8a: failed at 0x011853797374656d… on storage: Option:: decodeU8a: failed at 0x401c4163636f756e… on items: Vec:: decodeU8a: failed at 0x04e8205468652066… on : {"name":"Text","modifier":"StorageEntryModifierV14","type":"StorageEntryTypeV14","fallback":"Bytes","docs":"Vec"}:: decodeU8a: failed at 0x68652066756c6c20… on modifier: {"_enum":{"Optional":0,"Default":1,"Required":2}}:: Unable to create Enum via index 104, in Optional, Default, Required
at EventEmitter.value (/home/[removed]/polkadot_api_server/node_modules/@polkadot/api/base/Init.cjs:84:25)
at processTicksAndRejections (internal/process/task_queues.js:97:5)
Originally posted by @sekoyalabs in https://github.com/SimplyVC/polkadot_api_server/issues/23#issuecomment-941288329

Hi @dillu24
Any update on this? The API server is currently not working (giving {"error":"TypeError: Cannot read property 'api' of undefined"}) , at least with SORA validators.
From the docker logs I am just getting  API-WS: disconnected from ws://localhost:9944: 1006:: connection failed multiple times every minute. Pretty sure the node is configured correctly as I can curl the node directly and get a response.
Dont hesitate to ask if you need any help testing or want logs/config files
Thanks


Pressable within FlatList requires two presses when TextInput has focus (on Android and iOS)

Description
I have a screen with a TextInput that has focus when the screen is rendered. On Android and iOS, the keyboard is showing.
I have a list of Pressable items within a FlatList.
The first time I press one of the Pressable items in the FlatList, the keyboard disappears, but the onPress isn't executed. The second time I press on the Pressable, the onPress is executed. I would expect the Pressable onPress function to execute on the first press.
A Pressable outside of the FlatList (or ScrollView) fires the onPress on the first press.
Steps to reproduce
See https://snack.expo.dev/@lukertaylor/input-pressable-test
(issue is present on Android and iOS).
React Native Version
0.74.5
Affected Platforms
Runtime - Android, Runtime - iOS
Output of npx react-native info
info Fetching system and libraries information...
System:
  OS: macOS 15.1
  CPU: (8) arm64 Apple M1
  Memory: 2.54 GB / 16.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 20.11.0
    path: ~/.nvm/versions/node/v20.11.0/bin/node
  Yarn:
    version: 1.22.21
    path: ~/.nvm/versions/node/v20.11.0/bin/yarn
  npm:
    version: 10.8.3
    path: ~/.nvm/versions/node/v20.11.0/bin/npm
  Watchman:
    version: 2<IP_ADDRESS>
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods: Not Found
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 24.1
      - iOS 18.1
      - macOS 15.1
      - tvOS 18.1
      - visionOS 2.1
      - watchOS 11.1
  Android SDK:
    API Levels:
      - "31"
      - "33"
      - "34"
    Build Tools:
      - 30.0.2
      - 30.0.3
      - 33.0.0
      - 33.0.1
      - 34.0.0
    System Images:
      - android-33 | Google APIs ARM 64 v8a
      - android-34 | Google Play ARM 64 v8a
      - android-S | Google Play ARM 64 v8a
    Android NDK: Not Found
IDEs:
  Android Studio: 2022.3 AI-223.8836.35.2231.10406996
  Xcode:
    version: 16.1/16B40
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 23.0.1
    path: /opt/homebrew/opt/openjdk/bin/javac
  Ruby:
    version: 3.3.5
    path: /opt/homebrew/opt/ruby/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.74.5
    wanted: 0.74.5
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: Not found
  newArchEnabled: Not found
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found

Stacktrace or Logs
Not applicable.

Reproducer
https://snack.expo.dev/@lukertaylor/input-pressable-test
Screenshots and Videos
https://github.com/user-attachments/assets/1eda9280-af44-4984-a73c-30115fb4995d

hi! try this
import { useState } from "react";
import {
  FlatList,
  Keyboard,
  Pressable,
  StyleSheet,
  Text,
  TextInput,
  View,
} from "react-native";
const HomePage = () => {
  const [text, setText] = useState("");

  const handlePress = () => {
    Keyboard.dismiss(); // Esconde o teclado
    setText("pressed");
  };

  const items = [
    <Pressable onPress={handlePress}>
      <Text> You have to press me twice! </Text>{" "}
    </Pressable>,
  ];
  return (
    <View style={styles.container}>
      <TextInput
        style={styles.input}
        autoFocus={true}
        value={text}
        onChangeText={setText}
      />{" "}
      <Pressable onPress={handlePress}>
        <Text
          style={{
            marginVertical: 20,
          }}
        >
          {" "}
          Only have to press me once.{" "}
        </Text>{" "}
      </Pressable>{" "}
      <FlatList
        keyboardShouldPersistTaps="always"
        data={items}
        renderItem={({ item }) => item}
      />{" "}
    </View>
  );
};
export default HomePage;
const styles = StyleSheet.create({
  container: {
    flex: 1,
    alignItems: "center",
  },
  input: {
    borderWidth: 1,
    flexDirection: "row",
    alignSelf: "stretch",
    margin: 20,
  },
});

https://reactnative.dev/docs/scrollview#keyboardshouldpersisttaps

Thank you Emerson (@mensonones), that has solved my problem.
Apologies for raising the issue. I wasn't aware of:
keyboardShouldPersistTaps="always"
I will close the issue now.


Add windows back to CI

We should run at least one windows build, theres two here only because of my uncertainty of 3.3 support where as I know 2.7 worked.

Merged in 3b8dfa8b6fbffb0cb45effe79c072b937af325b9


coq: default to version 8.19

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Do we want NixOS 24.05 to ship Coq 8.19 by default? (And also, if there's any release blocker for Coq or OCaml)

Do we want NixOS 24.05 to ship Coq 8.19 by default?

Sounds like a good idea, to me at least.

And also, if there's any release blocker for Coq or OCaml

I’m not aware of any such release blocker.

Result of nixpkgs-review pr 307816 run on x86_64-linux 1

72 packages built:

compcert (coqPackages.compcert)
compcert.doc (coqPackages.compcert.doc)
compcert.lib (coqPackages.compcert.lib)
compcert.man (coqPackages.compcert.man)
coq (coqPackages.coq)
coqPackages.Cheerios
coqPackages.CoLoR
coqPackages.HoTT
coqPackages.ITree
coqPackages.InfSeqExt
coqPackages.LibHyps
coqPackages.QuickChick
coqPackages.StructTact
coqPackages.VST
coqPackages.aac-tactics
coqPackages.bignums
coqPackages.ceres
coqPackages.coq-elpi
coqPackages.coq-ext-lib
coqPackages.coq-lsp
coqPackages.coq-record-update
coqPackages.coqide
coqPackages.coqprime
coqPackages.coquelicot
coqPackages.corn
coqPackages.deriving
coqPackages.dpdgraph
coqPackages.equations
coqPackages.extructures
coqPackages.flocq
coqPackages.fourcolor
coqPackages.gappalib
coqPackages.hierarchy-builder
coqPackages.interval
coqPackages.iris
coqPackages.iris-named-props
coqPackages.itauto
coqPackages.math-classes
coqPackages.mathcomp
coqPackages.mathcomp-algebra
coqPackages.mathcomp-algebra-tactics
coqPackages.mathcomp-analysis
coqPackages.mathcomp-bigenough
coqPackages.mathcomp-character
coqPackages.mathcomp-classical
coqPackages.mathcomp-field
coqPackages.mathcomp-fingroup
coqPackages.mathcomp-finmap
coqPackages.mathcomp-infotheo
coqPackages.mathcomp-real-closed
coqPackages.mathcomp-solvable
coqPackages.ssreflect (coqPackages.mathcomp-ssreflect)
coqPackages.mathcomp-word
coqPackages.mathcomp-zify
coqPackages.metacoq
coqPackages.metacoq-erasure
coqPackages.metacoq-pcuic
coqPackages.metacoq-safechecker
coqPackages.metacoq-template-coq
coqPackages.multinomials
coqPackages.paco
coqPackages.paramcoq
coqPackages.parsec
coqPackages.reglang
coqPackages.serapi
coqPackages.simple-io
coqPackages.stdpp
coqPackages.vcfloat
coqPackages.vscoq-language-server
coqPackages.zorns-lemma
framac
satallax


Failed to load driver after Windows Update.

Blackbone was working fine last night, then I got a Windows Update, now I'm getting this:
BlackBone: Failed to load driver D:\Blackbone\build\Win32\Debug\BlackBoneDrv10.sys. Status 0xC0000034
I put the driver in the same folder, however, now I get this:
Mapping failed with error 0xc0000428. Windows cannot verify the digital signature for this file. A recent hardware or software change might have installed a file that is signed incorrectly or damaged, or that might be malicious software from an unknown source.

PEBKAC


[NO-ISSUE] Updated documents after install feedback

Removed empty "arrays" section as it conflicts with commented example

@sdodsley I'd like some feedback on if you think this is correct or not. I can see valid reasons for commenting it out (like if you're the type of person to uncomment examples and change them), and valid reasons to keep the empty arrays entries (like if you're the kind of person to copy from examples but leave them commented).

Added debugging info for taints and tolerations
Fixed incorrect NFSEndpoint capitalization in examples
Added an example install command to the basic install section

Whoops, dunno how I missed that. Lemme do a deeper search for lowercase NFS endpoint and catch all of them.

@sdodsley the rest of the NFS endpoints have been fixed

@Pure-AdamuKaapan I don't think so... values.yaml - line 32

Heads up, I did a quick test and removing the arrays default is making a bit easier to mess up the install (it'll complain if you don't add both the FlashArray and FlashBlade keys), so I'll probably add it back in.


htmlformatter.xslt missing

Just found this repo and it looks good!
Looks like the file htmlformatter.xslt is missing though.
https://github.com/Shoobx/xmldiff/blame/16df07461bb068fd080a97ce81be13fec1c124d5/docs/source/advanced.rst#L113
https://github.com/Shoobx/xmldiff/blob/e416303981f3424b0a2383d3edb25c405cac9dea/xmldiff/formatting.py#L15

Indeed, yes, I moved it to the documentation, as it's not a complete HTML differ by any means.
https://github.com/Shoobx/xmldiff/blob/master/docs/source/static/htmlformatter.xslt
Apparently I missed removing that reference, I've fixed that. Thanks!


Add Authentication

Hey Mam @vidhichadha2507 ,I want to Work on this task,Please assign it to me

Hey Vidhi,
I want to work on this issue, could you please assign it to me?

Hey Mam @vidhichadha2507 ,I want to Work on this task,Please assign it to me

Sure.

You guys can do this issue.

hey mam @vidhichadha2507 ,
I want to work on this issue


KVM volume snapshots are not full snapshots anymore

Hit a regression/bug when creating template from a KVM volume snapshot, I think potentially the regression was introduced in https://github.com/apache/cloudstack/pull/5297/files#diff-4f8be8d5f205bb11975c14fa213c5d733abbe5da2a4c3c6bcd829d9688ebcff2L229
KVM volume snapshots are full snapshots historically but recently with above change, it seems this has been changed and is causing regressions. Steps to reproduce the issue: (My env is 4.18.1 + Ubuntu 22.04 KVM + local storage)

Create snapshot of a VM's volume, check in secondary storage that the snapshot file isn't full snapshot and has a backing file (this is potentially dangerous if somebody force deletes a template which is its backing file).
Create template out of that snapshot, the template also has a backing file.
Deploy a VM to a host where the template isn't seeded, VM launch fails with the following in agent logs:

2023-10-04 11:51:02,039 DEBUG [utils.script.Script] (agentRequest-Handler-5:null) (logid:4a9b3711) Executing: qemu-img info -U /var/lib/libvirt/images/1834712a-5eae-4d0b-a907-cc5a908a8a14
2023-10-04 11:51:02,039 DEBUG [utils.script.Script] (agentRequest-Handler-5:null) (logid:4a9b3711) Executing while with timeout : 3600000
2023-10-04 11:51:02,042 DEBUG [utils.script.Script] (agentRequest-Handler-5:null) (logid:4a9b3711) Execution is successful.
2023-10-04 11:51:02,042 DEBUG [kvm.resource.LibvirtConnection] (agentRequest-Handler-5:null) (logid:4a9b3711) Looking for libvirtd connection at: qemu:///system
2023-10-04 11:51:02,042 DEBUG [utils.script.Script] (agentRequest-Handler-5:null) (logid:4a9b3711) Executing: qemu-img info -U /mnt/0b2466e8-6a2f-3f26-8112-64206ad57fa9/9cf98a00-4699-4a99-9c96-9438f3853a18.qcow2
2023-10-04 11:51:02,043 DEBUG [utils.script.Script] (agentRequest-Handler-5:null) (logid:4a9b3711) Executing while with timeout : 3600000
2023-10-04 11:51:02,046 DEBUG [utils.script.Script] (agentRequest-Handler-5:null) (logid:4a9b3711) Execution is successful.
2023-10-04 11:51:02,046 DEBUG [utils.script.Script] (agentRequest-Handler-5:null) (logid:4a9b3711) Executing: qemu-img convert -O qcow2 -U --image-opts driver=qcow2,file.filename=/mnt/0b2466e8-6a2f-3f26-8112-64206ad57fa9/9cf98a00-4699-4a99-9c96-9438f3853a18.qcow2 /var/lib/libvirt/images/1834712a-5eae-4d0b-a907-cc5a908a8a14
2023-10-04 11:51:02,047 DEBUG [utils.script.Script] (agentRequest-Handler-5:null) (logid:4a9b3711) Executing while with timeout : 10800000
2023-10-04 11:51:02,049 DEBUG [utils.script.Script] (agentRequest-Handler-5:null) (logid:4a9b3711) Exit value is 1
2023-10-04 11:51:02,049 DEBUG [utils.script.Script] (agentRequest-Handler-5:null) (logid:4a9b3711) qemu-img: Could not open 'driver=qcow2,file.filename=/mnt/0b2466e8-6a2f-3f26-8112-64206ad57fa9/9cf98a00-4699-4a99-9c96-9438f3853a18.qcow2': Could not open backing file: Could not open '/var/lib/libvirt/images/08d5308d-d571-4568-ba21-fde17053c2f9': No such file or directory
2023-10-04 11:51:02,050 ERROR [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-5:null) (logid:4a9b3711) Failed to convert /mnt/0b2466e8-6a2f-3f26-8112-64206ad57fa9/9cf98a00-4699-4a99-9c96-9438f3853a18.qcow2 to /var/lib/libvirt/images/1834712a-5eae-4d0b-a907-cc5a908a8a14 the error was: qemu-img: Could not open 'driver=qcow2,file.filename=/mnt/0b2466e8-6a2f-3f26-8112-64206ad57fa9/9cf98a00-4699-4a99-9c96-9438f3853a18.qcow2': Could not open backing file: Could not open '/var/lib/libvirt/images/08d5308d-d571-4568-ba21-fde17053c2f9': No such file or directory
2023-10-04 11:51:02,050 INFO  [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-5:null) (logid:4a9b3711) Attempting to remove storage pool 0b2466e8-6a2f-3f26-8112-64206ad57fa9 from libvirt
2023-10-04 11:51:02,050 DEBUG [kvm.resource.LibvirtConnection] (agentRequest-Handler-5:null) (logid:4a9b3711) Looking for libvirtd connection at: qemu:///system
2023-10-04 11:51:02,050 INFO  [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-5:null) (logid:4a9b3711) Storage pool 0b2466e8-6a2f-3f26-8112-64206ad57fa9 has no corresponding secret. Not removing any secret.
2023-10-04 11:51:02,054 INFO  [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-5:null) (logid:4a9b3711) Storage pool 0b2466e8-6a2f-3f26-8112-64206ad57fa9 was successfully removed from libvirt.
2023-10-04 11:51:02,055 DEBUG [cloud.agent.Agent] (agentRequest-Handler-5:null) (logid:4a9b3711) Seq 26-8586957114512086823:  { Ans: , MgmtId:<PHONE_NUMBER>768, via: 26, Ver: v1, Flags: 110, [{"org.apache.cloudstack.storage.command.CopyCmdAnswer":{"result":"false","details":"com.cloud.utils.exception.CloudRuntimeException: Failed to copy /mnt/0b2466e8-6a2f-3f26-8112-64206ad57fa9/9cf98a00-4699-4a99-9c96-9438f3853a18.qcow2 to 1834712a-5eae-4d0b-a907-cc5a908a8a14","wait":"0","bypassHostMaintenance":"false"}}] }
2023-10-04 11:51:02,151 DEBUG [cloud.agent.Agent] (agentRequest-Handler-3:null) (logid:4a9b3711) Request:Seq 26-8586957114512086824:  { Cmd , MgmtId:<PHONE_NUMBER>768, via: 26, Ver: v1, Flags: 100011, [{"com.cloud.agent.api.StopCommand":{"isProxy":"false","checkBeforeCleanup":"false","forceStop":"false","vlanToPersistenceMap":{"10":"true"},"volumesToDisconnect":[],"vmName":"i-2-505-VM","executeInSequence":"false","wait":"0","bypassHostMaintenance":"false"}}] }

ISSUE TYPE

Bug Report

COMPONENT NAME

KVM

CLOUDSTACK VERSION

4.18.1

CONFIGURATION

ACS 4.18.1 Adv zone with local storage and NFS secondary storage, adv networking

cc @shwstppr @DaanHoogland @GutoVeronezi @weizhouapache @harikrishna-patnala

I would have preferred at least a global setting to allow selecting between full snapshots (historical/expected behaviour) or the new approach which has broken snapshots in my env (possibly for other users). I force deleted an older template which I couldn't find any references for assuming we do full snapshots, and ended up breaking all (recurring) snapshots since the 4.17/4.18 upgrade in my homelab env (I'm hoping wife doesn't find this out, who'll be super pissed if any backup/data was lost).

if this issue is confirmed, I think it is a blocker.
the volume snapshot should be a full clone of the vm.

I checked the docs, we don't say we do incremental/linked snapshots for KVM or have any other information for users - https://docs.cloudstack.apache.org/en/<IP_ADDRESS>/adminguide/storage.html#incremental-snapshots-and-backup
I think full snapshots were slow but really effective, we need to revert the changes or at least make it configurable via some global setting (default set to full snapshots without any backing file for KVM volume snapshots).
@weizhouapache yes, agree - I've confirmed with my testing above against ACS <IP_ADDRESS> and Ubuntu 22.04 + local storage, welcome anybody to test/confirm the same with nfs and other storages (the behaviour is storage agnostic and may affect wide user community, and potential data loss like I incurred).

I'm able to reproduce this behviour and problem with snapshots having backing_files.

Deployed a test VM. Stopped it. Took ROOT volume snapshot
Deleted the VM. This deleted cached template files on the primary store when storage GC ran.
Created a new template from the snapshot  <- This got created successfully
Tried deploying a VM with the new template <- This failed

2023-10-04 07:57:28,675 ERROR [o.a.c.e.o.VolumeOrchestrator] (Work-Job-Executor-19:ctx-9609c044 job-129/job-131 ctx-a74d034e) (logid:84378832) Unable to create volume [{"name":"ROOT-11","uuid":"62662375-984a-4ad2-be79-49e4a156133d"}] due to [com.cloud.utils.exception.CloudRuntimeException: Failed to copy /mnt/99ceb614-2662-38a9-843c-53b0d26b3515/f7f32a7d-5170-472a-9ca4-51556ff7d0f5.qcow2 to c57053ea-ea69-4c2c-846b-39e7a8dc2248].
2023-10-04 07:57:28,675 WARN  [c.c.v.VirtualMachineManagerImpl] (Work-Job-Executor-19:ctx-9609c044 job-129/job-131 ctx-a74d034e) (logid:84378832) Unable to contact resource.
com.cloud.exception.StorageUnavailableException: Resource [StoragePool:1] is unreachable: Unable to create volume [{"name":"ROOT-11","uuid":"62662375-984a-4ad2-be79-49e4a156133d"}] due to [com.cloud.utils.exception.CloudRuntimeException: Failed to copy /mnt/99ceb614-2662-38a9-843c-53b0d26b3515/f7f32a7d-5170-472a-9ca4-51556ff7d0f5.qcow2 to c57053ea-ea69-4c2c-846b-39e7a8dc2248].
	at org.apache.cloudstack.engine.orchestration.VolumeOrchestrator.recreateVolume(VolumeOrchestrator.java:1814)
	at org.apache.cloudstack.engine.orchestration.VolumeOrchestrator.prepare(VolumeOrchestrator.java:1923)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
	at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
	at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)
	at com.sun.proxy.$Proxy227.prepare(Unknown Source)
	at com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:1266)
	at com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:5412)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at com.cloud.vm.VmWorkJobHandlerProxy.handleVmWorkJob(VmWorkJobHandlerProxy.java:107)
	at com.cloud.vm.VirtualMachineManagerImpl.handleVmWorkJob(VirtualMachineManagerImpl.java:5536)
	at com.cloud.vm.VmWorkJobDispatcher.runJob(VmWorkJobDispatcher.java:102)
	at org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:620)
	at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:48)
	at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:55)
	at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:102)
	at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:52)
	at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:45)
	at org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:568)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)

Agent logs from host
2023-10-04 07:57:28,560 DEBUG [kvm.storage.KVMStorageProcessor] (agentRequest-Handler-1:null) (logid:84378832) Copying template to primary storage, template format is qcow2
2023-10-04 07:57:28,560 INFO  [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-1:null) (logid:84378832) Trying to fetch storage pool 74659b4e-12be-388d-9877-2c992e20b732 from libvirt
2023-10-04 07:57:28,560 DEBUG [kvm.resource.LibvirtConnection] (agentRequest-Handler-1:null) (logid:84378832) Looking for libvirtd connection at: qemu:///system
2023-10-04 07:57:28,562 DEBUG [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-1:null) (logid:84378832) Successfully refreshed pool 74659b4e-12be-388d-9877-2c992e20b732 Capacity: (1.9685 TB)<PHONE_NUMBER>056 Used: (253.98 GB)<PHONE_NUMBER>76 Available: (1.7205 TB)<PHONE_NUMBER>280
2023-10-04 07:57:28,562 INFO  [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-1:null) (logid:84378832) Trying to fetch storage pool 74659b4e-12be-388d-9877-2c992e20b732 from libvirt
2023-10-04 07:57:28,562 DEBUG [kvm.resource.LibvirtConnection] (agentRequest-Handler-1:null) (logid:84378832) Looking for libvirtd connection at: qemu:///system
2023-10-04 07:57:28,564 DEBUG [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-1:null) (logid:84378832) Successfully refreshed pool 74659b4e-12be-388d-9877-2c992e20b732 Capacity: (1.9685 TB)<PHONE_NUMBER>056 Used: (253.98 GB)<PHONE_NUMBER>76 Available: (1.7205 TB)<PHONE_NUMBER>280
2023-10-04 07:57:28,564 DEBUG [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-1:null) (logid:84378832) copyPhysicalDisk: disk size:(1.00 MB) 1048576, virtualsize:(50.00 MB) 52428800 format:qcow2
2023-10-04 07:57:28,564 INFO  [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-1:null) (logid:84378832) Attempting to create volume c57053ea-ea69-4c2c-846b-39e7a8dc2248 (NetworkFilesystem) in pool 74659b4e-12be-388d-9877-2c992e20b732 with size (50.00 MB) 52428800
2023-10-04 07:57:28,564 DEBUG [kvm.resource.LibvirtConnection] (agentRequest-Handler-1:null) (logid:84378832) Looking for libvirtd connection at: qemu:///system
2023-10-04 07:57:28,565 DEBUG [utils.script.Script] (agentRequest-Handler-1:null) (logid:84378832) Executing: qemu-img create -o preallocation=off -f qcow2 /mnt/74659b4e-12be-388d-9877-2c992e20b732/c57053ea-ea69-4c2c-846b-39e7a8dc2248 52428800
2023-10-04 07:57:28,566 DEBUG [utils.script.Script] (agentRequest-Handler-1:null) (logid:84378832) Executing while with timeout : 3600000
2023-10-04 07:57:28,590 DEBUG [utils.script.Script] (agentRequest-Handler-1:null) (logid:84378832) Execution is successful.
2023-10-04 07:57:28,590 DEBUG [utils.script.Script] (agentRequest-Handler-1:null) (logid:84378832) Formatting '/mnt/74659b4e-12be-388d-9877-2c992e20b732/c57053ea-ea69-4c2c-846b-39e7a8dc2248', fmt=qcow2 size=52428800 encryption=off cluster_size=65536 preallocation='off' lazy_refcounts=off

2023-10-04 07:57:28,590 DEBUG [utils.script.Script] (agentRequest-Handler-1:null) (logid:84378832) Executing: qemu-img info /mnt/74659b4e-12be-388d-9877-2c992e20b732/c57053ea-ea69-4c2c-846b-39e7a8dc2248
2023-10-04 07:57:28,591 DEBUG [utils.script.Script] (agentRequest-Handler-1:null) (logid:84378832) Executing while with timeout : 3600000
2023-10-04 07:57:28,604 DEBUG [utils.script.Script] (agentRequest-Handler-1:null) (logid:84378832) Execution is successful.
2023-10-04 07:57:28,604 DEBUG [kvm.resource.LibvirtConnection] (agentRequest-Handler-1:null) (logid:84378832) Looking for libvirtd connection at: qemu:///system
2023-10-04 07:57:28,605 DEBUG [utils.script.Script] (agentRequest-Handler-1:null) (logid:84378832) Executing: qemu-img info /mnt/99ceb614-2662-38a9-843c-53b0d26b3515/f7f32a7d-5170-472a-9ca4-51556ff7d0f5.qcow2
2023-10-04 07:57:28,607 DEBUG [utils.script.Script] (agentRequest-Handler-1:null) (logid:84378832) Executing while with timeout : 3600000
2023-10-04 07:57:28,624 DEBUG [utils.script.Script] (agentRequest-Handler-1:null) (logid:84378832) Execution is successful.
2023-10-04 07:57:28,625 DEBUG [utils.script.Script] (agentRequest-Handler-1:null) (logid:84378832) Executing: qemu-img convert -O qcow2 /mnt/99ceb614-2662-38a9-843c-53b0d26b3515/f7f32a7d-5170-472a-9ca4-51556ff7d0f5.qcow2 /mnt/74659b4e-12be-388d-9877-2c992e20b732/c57053ea-ea69-4c2c-846b-39e7a8dc2248
2023-10-04 07:57:28,626 DEBUG [utils.script.Script] (agentRequest-Handler-1:null) (logid:84378832) Executing while with timeout : 10800000
2023-10-04 07:57:28,644 DEBUG [utils.script.Script] (agentRequest-Handler-1:null) (logid:84378832) Exit value is 1
2023-10-04 07:57:28,644 DEBUG [utils.script.Script] (agentRequest-Handler-1:null) (logid:84378832) qemu-img: Could not open '/mnt/99ceb614-2662-38a9-843c-53b0d26b3515/f7f32a7d-5170-472a-9ca4-51556ff7d0f5.qcow2': Could not open backing file: Could not open '/mnt/760626fb-2450-3276-ad82-8a4cc91110b5/a9388628-b90d-41ec-917a-6008011e779c': No such file or directoryqemu-img: Could not open '/mnt/99ceb614-2662-38a9-843c-53b0d26b3515/f7f32a7d-5170-472a-9ca4-51556ff7d0f5.qcow2'

I did not see the problem if the snapshot file on secondary store is rebased while backing up,
diff --git a/scripts/storage/qcow2/managesnapshot.sh b/scripts/storage/qcow2/managesnapshot.sh
index 2daa768347..1c840d34d2 100755
--- a/scripts/storage/qcow2/managesnapshot.sh
+++ b/scripts/storage/qcow2/managesnapshot.sh
@@ -230,7 +230,12 @@ backup_snapshot() {
       #Backup volume snapshot
       cp "$disk" "${destPath}/${destName}"
       ret_code=$?
-
+      if [ $ret_code -gt 0 ]
+      then
+        printf "Failed to copy $snapshotname for disk $disk to $destPath\n" >&2
+        return 2
+      fi
+      qemuimg_ret=$($qemu_img rebase -b "" "${destPath}/${destName}" 2>&1)
       if [ $ret_code -gt 0 ]
       then
         printf "Failed to backup $snapshotname for disk $disk to $destPath\n" >&2

Thanks @shwstppr - but wouldn't that (potentially) cause regression is what #5297 tried to do, maybe @GutoVeronezi you can review and suggest.
Since #5297 has been there since ACS 4.17, reverting the behaviour would cause (potential) regression for newer users/env, but not fixing this issue is causing issues for older env/users who expect full volume snapshots (even docs don't advise this). We need to find some middle ground solution.
/cc @weizhouapache @DaanHoogland @harikrishna-patnala @nvazquez @shwstppr @GutoVeronezi

@rohityadavcloud @shwstppr (cc @GutoVeronezi ) I think @shwstppr 's solution should be default and be disabled by a flag (old behaviour takes precedence)

@rohityadavcloud @shwstppr (cc @GutoVeronezi ) I think @shwstppr 's solution should be default and be disabled by a flag (old behaviour takes precedence)

+1 on this. The old behaviour has always been rock solid and I'm against changing it. Don't mind the new way as long as it's an opt-in setting.

All, here are some proposed actions, pl review and advise your thoughts:

Explore original PR #5297 that introduced the change to figure out minimal changes to revert or improve surgically (not entire PR), so as to not have backing file in the snapshot files
(optional) If possible and if it's not a lot of work, introduce a global setting with default behaviour set to full-snapshot (without any backing file) and allow admins/operators to have linked-snapshots if they want. However, in such a case this bug would persist; my opinion is it's not worth it but not supporting that would cause regressions to env that want the intentions of #5297. Perhaps one way to support the new behaviour is - when creating template from a linked-snapshot, colease/merge/rebase it against the snapshot's template?
Add in release notes about this change in behaviour for 4.19/4.18.2 for users; review/update the docs if required on what users should expect
Add smoketests around failure scenarios (vm -> volume snasphot -> create template -> deploy vm from snapshot) so we can catch any potential regressions/issues
(optional) Review template delete operation/API handling, I think the UI should warn users who may be deleting templates for which linked-snapshots may exist. Force deletion may not be allowed for such cases.

Hello guys, there is no need to revert the functionally or workaround it; we just have to understand what is happening and fix it.
The problem here is that while taking the volume snapshot, we call method copySnapshotToPrimaryStorageDir. This method copies the base file to another directory, to allow the block commit the delta right after taking the snapshot and avoid creating chains in the primary storage. However, copying a file with backing store will also copy the reference; therefore, it is causing the observed problem when the volume is not consolidated yet (process that is done in volume migration, for instance). If we create a template from the snapshot, and the deployment destination does not have access to the backing store, a problem will happen. A simple approach here would be to use qemu-img convert, to consolidate the volume instead of copying it with the reference. I am already working on the fix for this one.
Smoke and integrations tests indeed are needed.

Guys, I created PR #8041 to address this situation; could you have a look?

The whole idea of having Primary and Secondary storage - is to decouple data on those 2, otherwise, we would have just 1 huge storage.
From the conceptual and architecture POV, the data on Secondary storage should not/may not be linked (dependent) on the data on Primary storage - that is why even XenServer incremental snapshots have the full file on the secondary storage, then chained delta files to this full one - they are still NOT dependant on the Primary Storage.
Whatever is the solution implemented, we must ensure that we do not break these basic principles - otherwise, I don't see a point of having Primary and Secondary storage as separate entities.
Also worth noting, these kinds of changes should never come without a global setting - we have introduced a change (and a serious one) which changes how something worked for 10 years, and we have not kept the backward compatibility - these kinds of changes should be implemented as optional (controllable via Global setting) and always default to the old behaviour, for backward compatibility and safety reasons.

Fixed by #8041

@shwstppr cc @DaanHoogland @GutoVeronezi thanks for getting the issue fixed and PR merged, could you review if we must do the following:

Add in release notes about this change in behaviour for 4.19/4.18.2 for users; review/update the docs if required on what users should expect
Add smoketests around failure scenarios (vm -> volume snasphot -> create template -> deploy vm from snapshot) so we can catch any potential regressions/issues
(optional) Review template delete operation/API handling, I think the UI should warn users who may be deleting templates for which linked-snapshots may exist. Force deletion may not be allowed for such cases that can potentially cause data loss (or invalid linked snapshots).

I think even with the issue fixed, there might be many users with affected snapshots which may have backing file in prod.

+1 with @rohityadavcloud , especially on 2 (add smoke tests)
do we need to create new patch release (e.g. <IP_ADDRESS>  or <IP_ADDRESS>) ?

Please also consider documenting how to fix problematic snapshots created in 4.17 and 4.18 (those which might be broken)

@rohityadavcloud @andrijapanicsb
Users will have a backing store in their volume snapshots in the following cases:

the snapshots are from a ROOT volume created from template[^migrated];

Users will not have a backing store in their volume snapshots in the following cases:

the snapshots are from ROOT volumes created with ISO;
the snapshots are from DATADISK volumes;

Following there are two queries to help users identify snapshots with a backing store:

Identify snapshots that were not removed yet and were created from a volume that was created from a template:
SELECT  s.uuid AS "Snapshot ID",
        s.name AS "Snapshot Name",
        s.created AS "Snapshot creation datetime",
        img_s.uuid AS "Sec Storage ID",
        img_s.name AS "Sec Storage Name",
        ssr.install_path AS "Snapshot path on Sec Storage",
        v.uuid AS "Volume ID",
        v.name AS "Volume Name"
FROM    cloud.snapshots s
INNER   JOIN cloud.volumes v ON (v.id = s.volume_id)
INNER   JOIN cloud.snapshot_store_ref ssr ON (ssr.snapshot_id = s.id
                                          AND ssr.store_role = 'Image')
INNER   JOIN cloud.image_store img_s  ON (img_s.id = ssr.store_id)
WHERE   s.removed IS NULL
AND   v.template_id IS NOT NULL;

With that, one can use qemu-img info in the snapshot file to check if they have a backing store.

For those snapshots that have a backing store, one can use the following query to check which template is it and in which storage pool it is:
SELECT  vt.uuid AS "Template ID",
        vt.name AS "Template Name",
        tsr.install_path AS "Template file on Pri Storage",
        sp.uuid AS "Pri Storage ID",
        sp.name AS "Pri Storage Name",
        sp.`path` AS "Pri Storage Path",
        sp.pool_type as "Pri Storage type"
FROM    cloud.template_spool_ref tsr
INNER   JOIN cloud.storage_pool sp ON (sp.id = tsr.pool_id AND sp.removed IS NULL)
INNER   JOIN cloud.vm_template vt ON (vt.id = tsr.template_id)
WHERE   tsr.install_path = "<template file in the snapshot backing store>";

After identifying the snapshots with a backing store and the related templates, one can mount the secondary storage on a host that has access to the template and use qemu-img convert on the snapshot to consolidate it:
qemu-img convert -O qcow2 -U --image-opts driver=qcow2,file.filename=<path to snapshot on secondary storage> <path to snapshot on secondary storage>-converted

Then, one can use qemu-img info to check the information of the consolidated file. After validating the consolidated file (e.g.: if it is booting), one can replace the original snapshot file with the consolidated file. These processes should be done carefully, in order to guarantee the health of the environment.
[^migrated]: while migrating a volume, ACS consolidates the volume. However, it depends on the type and protocol of the source and destination storage. For instance, a NFS to NFS migration will not consolidate the volume; on the other hand, a NFS to SharedMountPoint migration will consolidate the volume. Therefore, users might not see the problem with snapshots from ROOT volumes created from templates and migrated, in some cases.

@GutoVeronezi are you looking into adding a smoke test?
@rohityadavcloud @GutoVeronezi @DaanHoogland @harikrishna-patnala should we keep this open till we can have a smoke test added and a release note change/PR?

(By all means, yes, we can not just close the issue without proper smoke tests that will ensure we don't have this critical issue that we had)

@GutoVeronezi are you looking into adding a smoke test?
@rohityadavcloud @GutoVeronezi @DaanHoogland @harikrishna-patnala should we keep this open till we can have a smoke test added and a release note change/PR?

(+1)

@GutoVeronezi are you looking into adding a smoke test?
@rohityadavcloud @GutoVeronezi @DaanHoogland @harikrishna-patnala should we keep this open till we can have a smoke test added and a release note change/PR?

@shwstppr I am planning to add them this week.

Excellent, thanks @GutoVeronezi @weizhouapache @shwstppr @andrijapanicsb for moving this forward.

@GutoVeronezi are you looking into adding a smoke test?
@rohityadavcloud @GutoVeronezi @DaanHoogland @harikrishna-patnala should we keep this open till we can have a smoke test added and a release note change/PR?

Update:
@shwstppr I am quite swamped with some other activities and I might not be able to fully work on them this week; feel free to work on them if it is your will.

PR #8104 that adds smoke test has been merged.
@harikrishna-patnala cc @DaanHoogland can you please look into adding documentation so we can close this ticket?

This got closed (again :facepalm: ) with smoke test PR merge. Documentation work is remaining

Thanks @shwstppr feel free to close it if there's a doc PR etc ready.

@harikrishna-patnala were you going to compose a doc PR?

created a doc PR to add note, https://github.com/apache/cloudstack-documentation/pull/367

@shwstppr , with the doc PR open we can close this, can we?

Closing this now,
#8041 to fix the issue
#8104 to add smoke test
https://github.com/apache/cloudstack-documentation/pull/367 to add documentation note

@GutoVeronezi , I saw this mitigation procedures in the release note, when we have hundreds VM affected by this linked snapshot issue, I'd like to ask rather than converting them, shall we just left it as it and just told the user do not delete any affected template instead. Any potential issue if we just keep it as is?

@GutoVeronezi , I saw this mitigation procedures from the release note, when we have hundreds VM affected by this linked snapshot issue, I'd like to ask rather than converting them, shall we just left it as it and just told the user do not delete any affected template instead. Any potential issue if we just keep it as is and proceed the 4.19 upgrade?

Hello @levindecaro
If you will keep the snapshots as they are (so they get replaced over time), you have to bear in mind 2 points:

not delete the template (as you already proposed);
and, when reverting a snapshot, the host where the VM is running must have access to the primary storage referenced in the snapshots's backing store[^cluster-wide]. This is also valid for deploying VMs from templates created from snapshots [^cluster-wide].

With that, your snapshots should work fine until they get replaced with new and consistent snapshots (on 4.19).
If you have any other doubt, just ping me.
[^cluster-wide]: for instance, if you have a snapshot of a volume in a cluster primary storage, create a template from it, and try to deploy it in another cluster, you will face errors.

@GutoVeronezi thank you for your explanation


Add withdrawals to core transaction data-type

Context

In order to correctly report an history of all withdrawals made by a user, we need to be able to filter the transaction history based on whether or not they included withdrawals.
Decision

Add a new database table to store withdrawals alongside input and output
Wire down everything from the block discovery so that withdrawals are correctly inserted into the database for transactions.

Acceptance Criteria

The API must now return a list of withdrawals with each transactions
Withdrawals should be represented as a key:value map of chimeric account mapping to a quantity of lovelace
Withdrawals belonging to a wallet must be correctly reported in the API

Development

#1892

QA

Transactions now have a "withdrawals" field documented in the API, reflecting a new field added to the core transaction type. Withdrawals are only present in Shelley, and they are simply defaulted to an empty map for Byron and Jormungandr.

Withdrawals are made of a stake address (hashed reward account, with network discrimination, bech32 encoded). I've tested the encoding / decoding using a classical roundtrip property:
https://github.com/input-output-hk/cardano-wallet/blob/26064b21e3dd26fef71913ab8a248ba5ad2f5051/lib/shelley/test/unit/Cardano/Wallet/Shelley/CompatibilitySpec.hs#L127-L136

There's a new table in the database for storing withdrawals. This doesn't require any manual migration since persistent will create the new table automatically. There's one 'gotcha' however, and it is that pre-existing wallet with withdrawals will not "sync back", so it is possible that they have missed withdrawals that have already happened. Restoring the wallet from scratch would solve this. This shouldn't be a problem for end-users since withdrawals haven't yet been introduced to them.

I made sure to adjust our Arbitrary generators to generate transactions with withdrawals, so that every existing unit tests and state-machine tests for the database functions could be tested. They pass.
https://github.com/input-output-hk/cardano-wallet/blob/26064b21e3dd26fef71913ab8a248ba5ad2f5051/lib/core/test/unit/Cardano/Wallet/DB/Arbitrary.hs#L378-L400

lgtm


Attribute pwdReset

Could I use pwdReset attribute to user reset password on next login?

I'm sorry, i just noticed this.  I am unfamiliar with that.  If the UnboundID server supports it then it should work. I'll look into it.

Thank's @trevershick

I'm not sure what you're trying to do here. It looks like this is something not really supported by the unboundid server.  Are wanting the test utils to 'mock out' this sort of behavior?

no more info. closing...


Control the GoogleMap options with widget parameters.

The current Google Maps API was completely controller based (it was
designed before the platform views support).
Now that the GoogleMap is a widget, we are re-designing the API
around the GoogleMap widget.
This PR removes the public GoogleMapOptions class, and moves the map
options to be widget parameters. When the widget is rebuilt we compute
the options delta and send an update over the method channel.
The initialCameraPosition parameter was moved out of the
GoogleMapOptions Android and iOS implementations as we do not update
it when the map options are updated.
Additional API tweaks in this change:

Make initialCameraPosition a required parameter for the GoogleMap
widget.
Don't require an onMapCreated parameter for GoogleMap.

cc @kf6gpe

Apologies for the big change - many lines in the PR are a test (we didn't have tests before) and updating the examples.

Thanks!
Will land on green.


Authentication: implement a means for automatic testing against deployment

There is currently not a way to programmatically authenticate to portal or explorer, for use in end to end tests.
Authentication is a manual process.
This task involves investigating best practices, and consulting with teams that have implemented this, such as IDSeq or Meta.
Definition of Done:
[ ] a mechanism to programmatically authenticate to portal is implemented
[ ] a mechanism to programmatically authenticate to explorer is implemented
[ ] a least one test case using this is written for both apps to verify it works, and keeps working.

Closed per conversation with @maniarathi


Fix required Github permissions during authrisation

From the authorization process, we only store email and nickname and email on db

so we shouldn't ask for the full access to the profile and public repos but the information strictly neccessary.

@tajchumber this sounds reasonable, would you like to update the perms?


Add a function to find lines in files matching a pattern.

This replaces simple-grep, which does not concat the stdout buffer from multiple callbacks.
Fixes #32.

:tada: This PR is included in version 4.1.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


🐛 [firebase_core] iOS "fatal error: could not build module 'firebase_core'" after upgrading to Flutter 2.0.1

Bug report
Describe the bug
Upgraded to Flutter 2.0 and received the error "include of non-modular header inside framework module"
Steps to reproduce
Steps to reproduce the behavior:

Create a new flutter project (with Objective-C iOS?)

  firebase_core: ^1.0.0
  firebase_auth: ^1.0.1
  firebase_auth_web: ^1.0.0
  firebase_database: ^6.1.0
  firebase_analytics: ^7.1.1
  firebase_messaging: ^9.0.0
  firebase_analytics_web: ^0.2.0
  http_parser: ^4.0.0

Run the application on iOS Simulator
The following error appears:

...flutter/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-9.0.0/ios/Classes/FLTFirebaseMes
    sagingPlugin.m:6:9: fatal error: could not build module 'firebase_core'
    #import <firebase_core/FLTFirebasePluginRegistry.h>

Expected behavior
A successful build for the iOS simulator

Additional context
I created a Swift file in Xcode that generated a Runner-Bridging-Header.h. Is this causing the CompileSwift error?
Full Error
    2 warnings generated.
    Command CompileSwift failed with a nonzero exit code
    Command CompileSwift failed with a nonzero exit code
    While building module 'firebase_core' imported from
    /Users/danielmartel/development/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-9.0.0/ios/Classes/FLTFirebaseMes
    sagingPlugin.m:6:
    In file included from <module-includes>:1:
    In file included from /Users/danielmartel/Documents/MantaPoolThermometer/mobile/ios/Pods/Target Support
    Files/firebase_core/firebase_core-umbrella.h:13:
    In file included from
    /Users/danielmartel/development/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_core-1.0.0/ios/Classes/FLTFirebaseCorePlug
    in.h:11:
    /Users/danielmartel/development/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_core-1.0.0/ios/Classes/FLTFirebasePlugin.h
    :9:9: error: include of non-modular header inside framework module 'firebase_core.FLTFirebasePlugin':
    '/Users/danielmartel/Documents/MantaPoolThermometer/mobile/ios/Pods/Headers/Public/FirebaseCore/FirebaseCore.h'
    [-Werror,-Wnon-modular-include-in-framework-module]
    #import <FirebaseCore/FirebaseCore.h>
            ^
    1 error generated.
    /Users/danielmartel/development/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-9.0.0/ios/Classes/FLTFirebaseMes
    sagingPlugin.m:6:9: fatal error: could not build module 'firebase_core'
    #import <firebase_core/FLTFirebasePluginRegistry.h>
     ~~~~~~~^
    2 errors generated.
    note: Using new build system
    note: Building targets in parallel
    note: Planning build
    note: Constructing build description

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
[✓] Flutter (Channel stable, 2.0.1, on Mac OS X 10.15.7 19H524 darwin-x64, locale en-US)
    • Flutter version 2.0.1 at /Users/danielmartel/development/flutter
    • Framework revision c5a4b4029c (5 days ago), 2021-03-04 09:47:48 -0800
    • Engine revision 40441def69
    • Dart version 2.12.0

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at /Users/danielmartel/Library/Android/sdk
    • Platform android-30, build-tools 30.0.1
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] IntelliJ IDEA Community Edition (version 2019.3.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.54.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.20.0

[✓] Connected device (2 available)
    • iPhone 12 Pro Max (mobile) • 1DD66FAA-1AE3-463C-AEDB-8102455B0267 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-4 (simulator)
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 89.0.4389.82

• No issues found!

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 2.12.0
Flutter SDK 2.0.1
manta 1.0.0+1

dependencies:
- camera 0.5.8+17 [flutter]
- characters 1.1.0
- charts_flutter 0.9.1 [charts_common collection flutter intl logging meta]
- cupertino_icons 0.1.2
- firebase_analytics 7.1.1 [firebase_analytics_platform_interface firebase_analytics_web firebase_core flutter meta]
- firebase_analytics_web 0.2.0+1 [firebase firebase_analytics_platform_interface flutter flutter_web_plugins meta]
- firebase_auth 1.0.1 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta]
- firebase_auth_web 1.0.1 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_parser intl js meta]
- firebase_core 1.0.0 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_database 6.1.0 [flutter firebase_core]
- firebase_messaging 9.0.0 [firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web flutter meta]
- flutter 0.0.0 [characters collection meta typed_data vector_math sky_engine]
- flutter_facebook_auth 1.0.2+2 [flutter]
- google_sign_in 4.5.9 [google_sign_in_platform_interface flutter meta google_sign_in_web]
- http_parser 4.0.0 [charcode collection source_span string_scanner typed_data]
- intl 0.17.0 [clock path]
- permission_handler 6.0.1 [flutter meta permission_handler_platform_interface]
- qr_code_scanner 0.3.5 [flutter]
- rxdart 0.22.4

dev dependencies:
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher meta source_span stream_channel string_scanner term_glyph typed_data]

transitive dependencies:
- async 2.5.0 [collection]
- boolean_selector 2.1.0 [source_span string_scanner]
- charcode 1.2.0
- charts_common 0.9.1 [collection intl logging meta vector_math]
- clock 1.1.0
- collection 1.15.0
- fake_async 1.2.0 [clock collection]
- firebase 9.0.0 [http http_parser js]
- firebase_analytics_platform_interface 1.1.0 [flutter meta]
- firebase_auth_platform_interface 4.0.0 [firebase_core flutter meta plugin_platform_interface]
- firebase_core_platform_interface 4.0.0 [flutter meta plugin_platform_interface]
- firebase_core_web 1.0.0 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- firebase_messaging_platform_interface 2.0.0 [firebase_core flutter meta plugin_platform_interface]
- firebase_messaging_web 1.0.0 [firebase_core firebase_core_web firebase_messaging_platform_interface flutter flutter_web_plugins js meta]
- flutter_web_plugins 0.0.0 [flutter js characters collection meta typed_data vector_math]
- google_sign_in_platform_interface 1.1.2 [flutter meta quiver]
- google_sign_in_web 0.9.2 [google_sign_in_platform_interface flutter flutter_web_plugins meta js]
- http 0.13.0 [http_parser meta path pedantic]
- js 0.6.3
- logging 0.11.3+2
- matcher 0.12.10 [stack_trace]
- meta 1.3.0
- path 1.8.0
- pedantic 1.11.0
- permission_handler_platform_interface 3.0.0+1 [flutter meta plugin_platform_interface]
- plugin_platform_interface 2.0.0 [meta]
- quiver 2.1.5 [matcher meta]
- sky_engine 0.0.99
- source_span 1.8.0 [charcode collection path term_glyph]
- stack_trace 1.10.0 [path]
- stream_channel 2.1.0 [async]
- string_scanner 1.1.0 [charcode source_span]
- term_glyph 1.2.0
- test_api 0.2.19 [async boolean_selector collection meta path source_span stack_trace stream_channel string_scanner term_glyph matcher]
- typed_data 1.3.0 [collection]
- vector_math 2.1.0

Hard to say, if you just create a new flutter project using only swift (flutter create -i swift) and try to use the dependencies does it work?

@markusaksli-nc I just did this and it built fine. I'm going to migrate my iOS folder to Swift and see if this fixes it in my real app.

Adding back the wait label for that

So I started moving things over 1 by 1 and found the issue seems to be related to my Podfile but I'm not really sure what specifically. Does anything stand out as incorrect? If I remove all of the pods at the bottom the new project runs fine, but I think that is because my code isn't using them yet.
`# Uncomment this line to define a global platform for your project
platform :ios, '12.0'
CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'
project 'Runner', {
'Debug' => :debug,
'Profile' => :release,
'Release' => :release,
}
def flutter_root
generated_xcode_build_settings_path = File.expand_path(File.join('..', 'Flutter', 'Generated.xcconfig'), FILE)
unless File.exist?(generated_xcode_build_settings_path)
raise "#{generated_xcode_build_settings_path} must exist. If you're running pod install manually, make sure flutter pub get is executed first"
end
File.foreach(generated_xcode_build_settings_path) do |line|
matches = line.match(/FLUTTER_ROOT=(.*)/)
return matches[1].strip if matches
end
raise "FLUTTER_ROOT not found in #{generated_xcode_build_settings_path}. Try deleting Generated.xcconfig, then run flutter pub get"
end
require File.expand_path(File.join('packages', 'flutter_tools', 'bin', 'podhelper'), flutter_root)
flutter_ios_podfile_setup
target 'Runner' do
use_frameworks!
use_modular_headers!
flutter_install_all_ios_pods File.dirname(File.realpath(FILE))
end
post_install do |installer|
installer.pods_project.targets.each do |target|
flutter_additional_ios_build_settings(target)
target.build_configurations.each do |config|
config.build_settings.delete 'IPHONEOS_DEPLOYMENT_TARGET'
config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] ||= [
'$(inherited)',
    ## dart: PermissionGroup.calendar
    'PERMISSION_EVENTS=0',

    ## dart: PermissionGroup.reminders
    'PERMISSION_REMINDERS=0',

    ## dart: PermissionGroup.contacts
    'PERMISSION_CONTACTS=0',

    ## dart: PermissionGroup.camera
    # 'PERMISSION_CAMERA=0',

    ## dart: PermissionGroup.microphone
    'PERMISSION_MICROPHONE=0',

    ## dart: PermissionGroup.speech
    'PERMISSION_SPEECH_RECOGNIZER=0',

    ## dart: PermissionGroup.photos
    'PERMISSION_PHOTOS=0',

    ## dart: [PermissionGroup.location, PermissionGroup.locationAlways, PermissionGroup.locationWhenInUse]
    'PERMISSION_LOCATION=0',

    ## dart: PermissionGroup.notification
    # 'PERMISSION_NOTIFICATIONS=0',

    ## dart: PermissionGroup.mediaLibrary
    'PERMISSION_MEDIA_LIBRARY=0',

    ## dart: PermissionGroup.sensors
    'PERMISSION_SENSORS=0'
  ]
end

end
end
pod 'GoogleUtilities/AppDelegateSwizzler'
pod 'GoogleUtilities/MethodSwizzler'
pod 'GoogleUtilities/Network'
pod 'GoogleUtilities/NSData+zlib'
pod 'GoogleUtilities/AppDelegateSwizzler'
pod 'GoogleUtilities/Environment'
pod 'GoogleUtilities/Logger'
pod 'GoogleUtilities/UserDefaults'
pod 'GoogleUtilities/Reachability'
pod 'FirebaseAuth'`

Why do you have these lines?
      config.build_settings.delete 'IPHONEOS_DEPLOYMENT_TARGET'
      config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] ||= [

Also you mentioned you added pod 'FirebaseAuth' because of an error but it should not be necessary, as it only imports it on the native side. If you've added firebase_auth to podspec.yaml it should already work.

I ended up just moving forward with removing my iOS directory and creating a new one with Swift and it fixed my issues. Not really sure why/how but I'll take it.


support for json configuration

I will check this tomorrow (I hope at least).

I will check this tomorrow (I hope at least).

Hi, could you please check the pull request today?

@SeppPenner Could you also push a new package to nuget ?

@artiomponkratov I've already merged your pull request and will create a new nuget package today. I was a bit busy before, but now I will take a look at it in detail :) I will give you a short update here once the package is available.

Nice idea with the SqlTypeHelper class. I have just adjusted the code style and documentation a bit, but the rest looks really good :)

So, the NuGet package will be available soon (Within the next hour) :) Just tell me if you find anything else in the package. One more thing: I have adjusted your Id field from "Id": "IdAutoincrement", to "Id": "IdAutoIncrement",. After changing this in your configuration, it should work as expected. If not, please tell me. And thank you for your time and this pull request.

And another thing just to mention it: You had the ; char in the wrong position in the documentation for the database connection string (But I guess that was just a copy paste error). :)


Config changes to reflect the default branch from master to main. Please merge to complete the default branch renaming job.

Auto branch renaming content.

Docs Build status updates of commit 93e8744:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch f3e00bb7-b8cb-44ea-b9eb-87263555b46b has been deleted or has been force pushed

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


HTTP1: Add DumpState support for HTTP1.

Signed-off-by: Kevin Baichoo<EMAIL_ADDRESS>
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: HTTP1: Add DumpState support for HTTP1.
Additional Description: While dispatching, the HTTP1 Connection object registers itself as a scopetrackedobject. If we crash during parsing pipeline, we'll dump information such as the partial headers parsed, current buffer, headermap, etc.
Risk Level: medium
Testing: unit tests
Docs Changes: N/A
Release Notes: Included
Platform Specific Features: N/A
Related Issue #14249
/assign @antoniovicente

/retest

/retest

grpc errors during build?
/retest

grpc errors during build?
/retest

Not sure if that restarted it; did run clang-tidy in docker locally no issue...
/retest

Not sure if that restarted it; did run clang-tidy in docker locally no issue...
/retest

grpc issue seems to be due to some loadshedding that some service is performing -- maybe too much going on for CI.
Will re-kick this in a bit, perhaps we should get some other reviewing eyes on it in the mean time?

grpc issue seems to be due to some loadshedding that some service is performing -- maybe too much going on for CI.
Will re-kick this in a bit, perhaps we should get some other reviewing eyes on it in the mean time?

/retest

/retest

PTAL @envoyproxy/senior-maintainers; seems like it was LGTM from @antoniovicente, but he's OOO.

PTAL @envoyproxy/senior-maintainers; seems like it was LGTM from @antoniovicente, but he's OOO.

needs main merge.

/retest

PTAL @ggreenway since you're the maintainer on-call this week. Thanks!

/retest
Flaky integration test.


gha: Remove manual device setting

This is in favour of recent work on auto device detection.
Please ensure your pull request adheres to the following guidelines:

[ ] For first time contributors, read Submitting a pull request
[ ] All code is covered by unit and/or runtime tests where feasible.
[ ] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[ ] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
[ ] All commits are signed off. See the section Developer’s Certificate of Origin
[ ] Provide a title or release-note blurb suitable for the release notes.
[ ] Are you a user of Cilium? Please add yourself to the Users doc
[ ] Thanks for contributing!

Fixes: #issue-number
<!-- Enter the release note text here if needed or remove this section! -->

/ci-gateway-api

/ci-gateway-api

/ci-ingress


Make sorted and reversed constexpr

Otherwise I am running into multiple definitions error on g++ 10.2.0 (Gentoo 10.2.0-r5 p6).

Ok, turns out a lambda can be used in constexpr only starting c++17...

Do we have a way to make it inline if we don't have c++17, and constexpr if we do? Or just make it inline?

The solution is normally to turn them into proper function objects (a struct), there are a few examples elsewhere in the code-base. I dunno why these two in particular where never turned into such...

I think I've done it but that also makes it too tedious...

Codecov Report

Merging #25 (f1f2e43) into master (c580d6b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   98.94%   98.94%
=======================================
  Files         122      122
  Lines        1802     1802
=======================================
  Hits         1783     1783
  Misses         19       19

Impacted Files
Coverage Δ

zug/transducer/eager.hpp
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c580d6b...f1f2e43. Read the comment docs.

Maybe something else to consider: The original implementation did not move algo, nor forward step. Is it desireable to do those as well?

Note, this will currently only be inlined with C++17, where constexpr
implies inline. We would need to use the inline constexpr macro to support
C++14:
https://github.com/arximboldi/zug/blob/master/zug/detail/inline_constexpr.hpp
On Tue 23. Mar 2021 at 09:41, Juanpe Bolívar @.***>
wrote:

@.**** commented on this pull request.
Really good work! Thanks for putting in the effort to turn into structs...
I think the code could be slightly simplified (see the inline comments) but
otherwise it looks good to me!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/arximboldi/zug/pull/25#pullrequestreview-618324981,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB4WLBWAAMDTR6Z7CBDULF3TFBH2FANCNFSM4ZQWMEGQ
.

Oh thanks for chiming in @CJBussey! For reference @tusooa Carl did all the great work of ensuring things stay C++14 compatible and he is the expert in this area.

Thanks a lot for the great work @tusooa !


feat: add docker file

Image size about ~22 mb.
Run like this:
docker run -p 19132:19132/udp \
  -v "$PWD/world:/opt/app/world" \
  -v "$PWD/resources:/opt/app/resources" \
  dragonfly-image

I'm not really a Docker expert myself. To what extent is this going to be useful for people? Of course usually you'd have your own project importing dragonfly, rather than running the dragonfly main.go as-is. Maybe it'd be an idea to have this in a separate repo or in the template repo?

I have added your Dockerfile to https://github.com/df-mc/template/commit/358b9c81c478f060e5ab7873da7c97b4da346e50. Thank you for the PR!


Check for Console Window before allocating one

gets rid of that annoying
[*] Failed to create a console window, maybe a console already exists?
when launching via NorthstarLauncher.exe

Merging based on review