ignore_attributes in readWQPdata

I've added a GitHub Action yaml, and then did my best to get rid of notes/warnings. Ideally you'll want to make sure each pull request doesn't add any new notes/warnings/errors, so this GH Action check could do that automatically.
If you want to speed up the checks, you can do fewer (I can put an in-line note where I'm talking about). If you want to automatically deploy to a github page, you could try using something like this:
https://github.com/USGS-R/dataRetrieval/blob/main/.github/workflows/pkgdown.yaml
ANYWAY,
The point I wanted to make with this PR is just to add ignore_attributes=TRUE to any readWQPdata calls. Normally, if you did something like this:
df <- readWQPdata(siteid = c("USGS-054064785",
                                        "USGS-430305089260600"),
                             characteristicName = "Phosphorus")

dataRetrieval will go out and get the data, but ALSO go get the site information via whatWQPsites. You can access that via the "siteInfo" attribute:
siteInfo <- attr(df, "siteInfo")
nrow(siteInfo)
[1] 2

Since you are doing that independently, and joining that site information directly to the data, you can potentially save a lot of time by dropping the attributes (and therefore not calling whatWQPsites twice):
df2 <- readWQPdata(siteid = c("USGS-054064785",
                                        "USGS-430305089260600"),
                                 characteristicName = "Phosphorus",
                                 ignore_attributes = TRUE)
siteInfo2 <- attr(df2, "siteInfo")
nrow(siteInfo2)
NULL

Alternatively you could keep the attributes, and drop the lines like this:
sites.DR <- dataRetrieval::whatWQPsites(WQPquery)

instead:
sites.DR <- attr(WQPquery, "siteInfo")

Ideally you'd be able to set this repo up that the GitHub Actions can automatically run without any review. You can check it from my fork:
https://github.com/ldecicco-USGS/TADA/actions/runs/3093018055
To see that all the checks passed, but ideally you'd see that in this pull-request stream.


Cannot deploy any 3bot instance on https://deploy3bot2.testnet.grid.tf/threebot_deployer/#/

Cannot deploy any 3bot instance on https://deploy3bot2.testnet.grid.tf/threebot_deployer/#/


Build and publish wheels for UCXX

We're getting close to making the move from UCX-Py to UCXX, PRs such as https://github.com/rapidsai/raft/pull/1983 and https://github.com/rapidsai/cuml/pull/5697 are integrating UCXX to run tests in CI. The plan is, time permitting, to have RAPIDS projects running UCXX tests in CI for 24.02 and possibly switching to UCXX as the default in 24.04 (still pending approval). However, we cannot make that move without also publishing wheels.
@vyasr would you be able to work on wheels for UCXX sometime before 24.02? I'll be OOO until early January, so if you don't have the bandwidth to work on it I may need your help then, unless @charlesbluca or @wence- have some bandwidth, more importantly, want to give it a go at this. 🙂

I don't think I'll be able to work on this any time in the near future, but I am happy to advise if someone else wants to get it started! The process has gotten a lot simpler so hopefully modeling after other repos should get us most of the way there (obviously some extra complexity around bundling ucx libraries but hopefully the code in ucx-py helps explain how we do that well enough).


.NET WinForms: Setup project: Cannot find Dependencies for .NET 8/6

Hello.
Visual Studio 2022 17.9.1 Community
.NET SDK 8.0.2, installed (from https://dotnet.microsoft.com/en-us/download/dotnet/8.0 ... SDK 8.0.201 ... Windows x64)
Both LLamaSharp & Backend.CPU: 0.10.0
WinForms application, on .NET 6.0 (the behavior below, including the Dependencies, is the same for: 1) .NET 8.0 and 2) Console App)
The application works as expected, so:
I've Added a Setup project to the solution, in order to deploy the working application to another computer which may not have .NET 8/6 on it.
In Solution Explorer:

WinForms App:
-- Packages:
--- LLamaSharp (0.10.0)
--- LLamaSharp.Backend.CPU (0.10.0)

Setup1:
-- View... File System... Application Folder:
--- Added: as Project Output: the Primary Output of the WinForms app
--- No Detected Dependencies were listed
--- Added: Assembly:  AppFolder\bin\Debug\net8.0-windows\LLamaSharp.dll
--- Detected Dependencies:
---- Microsoft. Extensions.DependencyInjection.Abstractions.dll
---- Microsoft. Extensions.Logging.Abstractions.dll

-> Rebuild Solution (2 projects: the WinForms App and Setup1):
in the Output Window:
------ Starting pre-build validation for project 'Setup1' ------
WARNING: Unable to find dependency 'SYSTEM.RUNTIME' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.DependencyInjection.Abstractions.dll'
WARNING: Unable to find dependency 'SYSTEM.RUNTIME' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.DependencyInjection.Abstractions.dll'
WARNING: Unable to find dependency 'SYSTEM.LINQ.EXPRESSIONS' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.DependencyInjection.Abstractions.dll'
WARNING: Unable to find dependency 'SYSTEM.LINQ.EXPRESSIONS' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.DependencyInjection.Abstractions.dll'
WARNING: Unable to find dependency 'SYSTEM.COLLECTIONS.CONCURRENT' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.DependencyInjection.Abstractions.dll'
WARNING: Unable to find dependency 'SYSTEM.COLLECTIONS.CONCURRENT' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.DependencyInjection.Abstractions.dll'
WARNING: Unable to find dependency 'SYSTEM.RUNTIME.INTEROPSERVICES' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.DependencyInjection.Abstractions.dll'
WARNING: Unable to find dependency 'SYSTEM.RUNTIME.INTEROPSERVICES' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.DependencyInjection.Abstractions.dll'
WARNING: Unable to find dependency 'SYSTEM.RUNTIME.LOADER' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.DependencyInjection.Abstractions.dll'
WARNING: Unable to find dependency 'SYSTEM.RUNTIME.LOADER' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.DependencyInjection.Abstractions.dll'
WARNING: Unable to find dependency 'SYSTEM.COLLECTIONS' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.DependencyInjection.Abstractions.dll'
WARNING: Unable to find dependency 'SYSTEM.COLLECTIONS' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.DependencyInjection.Abstractions.dll'
WARNING: Unable to find dependency 'SYSTEM.COMPONENTMODEL' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.DependencyInjection.Abstractions.dll'
WARNING: Unable to find dependency 'SYSTEM.COMPONENTMODEL' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.DependencyInjection.Abstractions.dll'
WARNING: Unable to find dependency 'SYSTEM.IO.MEMORYMAPPEDFILES' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'LLamaSharp.dll'
WARNING: Unable to find dependency 'SYSTEM.IO.MEMORYMAPPEDFILES' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'LLamaSharp.dll'
WARNING: Unable to find dependency 'SYSTEM.LINQ' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'LLamaSharp.dll'
WARNING: Unable to find dependency 'SYSTEM.LINQ' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'LLamaSharp.dll'
WARNING: Unable to find dependency 'SYSTEM.CONSOLE' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'LLamaSharp.dll'
WARNING: Unable to find dependency 'SYSTEM.CONSOLE' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'LLamaSharp.dll'
WARNING: Unable to find dependency 'SYSTEM.RUNTIME.COMPILERSERVICES.UNSAFE' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'LLamaSharp.dll'
WARNING: Unable to find dependency 'SYSTEM.RUNTIME.COMPILERSERVICES.UNSAFE' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'LLamaSharp.dll'
WARNING: Unable to find dependency 'SYSTEM.MEMORY' (Signature='CC7B13FFCD2DDD51' Version='<IP_ADDRESS>') of assembly 'LLamaSharp.dll'
WARNING: Unable to find dependency 'SYSTEM.MEMORY' (Signature='CC7B13FFCD2DDD51' Version='<IP_ADDRESS>') of assembly 'LLamaSharp.dll'
WARNING: Unable to find dependency 'SYSTEM.RUNTIME.INTEROPSERVICES' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'LLamaSharp.dll'
WARNING: Unable to find dependency 'SYSTEM.RUNTIME.INTEROPSERVICES' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'LLamaSharp.dll'
WARNING: Unable to find dependency 'SYSTEM.COLLECTIONS' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'LLamaSharp.dll'
WARNING: Unable to find dependency 'SYSTEM.COLLECTIONS' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'LLamaSharp.dll'
WARNING: Unable to find dependency 'SYSTEM.TEXT.JSON' (Signature='CC7B13FFCD2DDD51' Version='<IP_ADDRESS>') of assembly 'LLamaSharp.dll'
WARNING: Unable to find dependency 'SYSTEM.TEXT.JSON' (Signature='CC7B13FFCD2DDD51' Version='<IP_ADDRESS>') of assembly 'LLamaSharp.dll'
WARNING: Unable to find dependency 'SYSTEM.RUNTIME' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'LLamaSharp.dll'
WARNING: Unable to find dependency 'SYSTEM.RUNTIME' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'LLamaSharp.dll'
WARNING: Unable to find dependency 'SYSTEM.COMPONENTMODEL.PRIMITIVES' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'LLamaSharp.dll'
WARNING: Unable to find dependency 'SYSTEM.COMPONENTMODEL.PRIMITIVES' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'LLamaSharp.dll'
WARNING: Unable to find dependency 'SYSTEM.RUNTIME.INTRINSICS' (Signature='CC7B13FFCD2DDD51' Version='<IP_ADDRESS>') of assembly 'LLamaSharp.dll'
WARNING: Unable to find dependency 'SYSTEM.RUNTIME.INTRINSICS' (Signature='CC7B13FFCD2DDD51' Version='<IP_ADDRESS>') of assembly 'LLamaSharp.dll'
WARNING: Unable to find dependency 'SYSTEM.RUNTIME.INTEROPSERVICES.RUNTIMEINFORMATION' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'LLamaSharp.dll'
WARNING: Unable to find dependency 'SYSTEM.RUNTIME.INTEROPSERVICES.RUNTIMEINFORMATION' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'LLamaSharp.dll'
WARNING: Unable to find dependency 'SYSTEM.RUNTIME.INTEROPSERVICES' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.Logging.Abstractions.dll'
WARNING: Unable to find dependency 'SYSTEM.RUNTIME.INTEROPSERVICES' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.Logging.Abstractions.dll'
WARNING: Unable to find dependency 'SYSTEM.THREADING' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.Logging.Abstractions.dll'
WARNING: Unable to find dependency 'SYSTEM.THREADING' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.Logging.Abstractions.dll'
WARNING: Unable to find dependency 'SYSTEM.RUNTIME' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.Logging.Abstractions.dll'
WARNING: Unable to find dependency 'SYSTEM.RUNTIME' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.Logging.Abstractions.dll'
WARNING: Unable to find dependency 'SYSTEM.COLLECTIONS' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.Logging.Abstractions.dll'
WARNING: Unable to find dependency 'SYSTEM.COLLECTIONS' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.Logging.Abstractions.dll'
WARNING: Unable to find dependency 'SYSTEM.MEMORY' (Signature='CC7B13FFCD2DDD51' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.Logging.Abstractions.dll'
WARNING: Unable to find dependency 'SYSTEM.MEMORY' (Signature='CC7B13FFCD2DDD51' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.Logging.Abstractions.dll'
WARNING: Unable to find dependency 'SYSTEM.COLLECTIONS.CONCURRENT' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.Logging.Abstractions.dll'
WARNING: Unable to find dependency 'SYSTEM.COLLECTIONS.CONCURRENT' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.Logging.Abstractions.dll'
------ Pre-build validation for project 'Setup1' completed ------
------ Pre-build validation for project 'Setup1' completed ------
2>------ Rebuild All started: Project: Setup1, Configuration: Debug ------
2>------ Rebuild All started: Project: Setup1, Configuration: Debug ------
Building file 'H:\programs2022_desktop\Setup1\Debug\Setup1.msi'...
Building file 'H:\programs2022_desktop\Setup1\Debug\Setup1.msi'...
Building file 'H:\programs2022_desktop\Setup1\Debug\Setup1.msi'...
Building file 'H:\programs2022_desktop\Setup1\Debug\Setup1.msi'...
WARNING: Including primary output of project 'WinFormsApp1.csproj' with target framework '.NETCoreApp v6.0' may result in incomplete content. See here: https://go.microsoft.com/fwlink/?linkid=2112157
WARNING: Including primary output of project 'WinFormsApp1.csproj' with target framework '.NETCoreApp v6.0' may result in incomplete content. See here: https://go.microsoft.com/fwlink/?linkid=2112157
WARNING: Including primary output of project 'WinFormsApp1.csproj' with target framework '.NETCoreApp v6.0' may result in incomplete content. See here: https://go.microsoft.com/fwlink/?linkid=2112157
WARNING: Including primary output of project 'WinFormsApp1.csproj' with target framework '.NETCoreApp v6.0' may result in incomplete content. See here: https://go.microsoft.com/fwlink/?linkid=2112157
Packaging file 'WinFormsApp1.dll'...
Packaging file 'WinFormsApp1.dll'...
Packaging file 'WinFormsApp1.dll'...
Packaging file 'WinFormsApp1.dll'...
Packaging file 'Microsoft.Extensions.DependencyInjection.Abstractions.dll'...
Packaging file 'Microsoft.Extensions.DependencyInjection.Abstractions.dll'...
Packaging file 'Microsoft.Extensions.DependencyInjection.Abstractions.dll'...
Packaging file 'Microsoft.Extensions.DependencyInjection.Abstractions.dll'...
Packaging file 'WinFormsApp1.runtimeconfig.json'...
Packaging file 'WinFormsApp1.runtimeconfig.json'...
Packaging file 'WinFormsApp1.runtimeconfig.json'...
Packaging file 'WinFormsApp1.runtimeconfig.json'...
Packaging file 'LLamaSharp.dll'...
Packaging file 'LLamaSharp.dll'...
Packaging file 'LLamaSharp.dll'...
Packaging file 'LLamaSharp.dll'...
Packaging file 'Microsoft.Extensions.Logging.Abstractions.dll'...
Packaging file 'Microsoft.Extensions.Logging.Abstractions.dll'...
Packaging file 'Microsoft.Extensions.Logging.Abstractions.dll'...
Packaging file 'Microsoft.Extensions.Logging.Abstractions.dll'...
========== Rebuild All: 2 succeeded, 0 failed, 0 skipped ==========
If the LLamaSharp.dll is Not added as Assembly/File, its two Dependencies also are not being added, and the Rebuild of the Setup package completes without /severe errors:
[...]
WARNING: Including primary output of project 'WinFormsApp1.csproj' with target framework '.NETCoreApp v8.0' may result in incomplete content. See here: https://go.microsoft.com/fwlink/?linkid=2112157
10:31:45:173	Packaging file 'WinFormsApp1.dll'...
10:31:45:182	Packaging file 'WinFormsApp1.runtimeconfig.json'...
10:31:45:496	========== Rebuild All: 2 succeeded, 0 failed, 0 skipped ==========
... incomplete indeed: in the folder where the App was installed there are these files only:

WinFormsApp1.dll
WinFormsApp1.runtimeconfig.json
(although the Properties of the App told it that it is a Windows Forms one, instead of a Class Library)

What could be done in this case? How to deploy the application? I think that the LLamaSharp.dll should be deployed along with the .exe, but its Dependencies via Abstractions cannot be resolved.
Looks like the Setup will not start, even if .NET 8/6 is present, and (probably normal) If LLamaSharp.dll is placed in the Application Folder -> the only DLLs are the two referring the Abstractions...

Hi, will be building succeed if you remove LLamaSharp and add microsoft semantic-kernel as dependency for example?

I've Added a Setup project to the solution, in order to deploy the working application to another computer which may not have .NET 8/6 on it.

Sorry but I know little about the distribution of .NET applications. Could you please tell more about what the Setup project is?

Hello.
Thank you.
Let's try it thatta way then.
All I do with LLamaSharp (regardless of its version) is in Microsoft Visual Studio 2022 Community >= 17.9.1
I have installed the MS Semantic Kernel as per the instructions here:
https://github.com/microsoft/semantic-kernel/blob/main/dotnet/README.md

open the Solution using LLamaSharp
(re)build the Solution in order to create the .exe or .dll
View... Solution Explorer... (Ctrl Alt L)
right-click on the name of Solution -> Add -> New Project... Setup Project: Create a Windows Installer project to which files can be added
right-click on the name of Setup project -> View -> File System
right-click on Application Folder -> Add -> Projct Output... Primary Output
in Solution Explorer, under the name of Setup Project, appears: "Detected Dependencies" and "Primsry output from [name of Solution]
The "Detected Dependencies" folder is empty
right-click again on "Application Folder" - to add LLamaSharp.dll
Add -> Assembly...
Browse... to file LLamaSharp.dll
I use the LLamaSharp.dll in [Solution name]\bin\Release"net 8.0-windows"
Visual Studio crashes
restart it
rebuild the Solution using LLamaSharp
repeat steps 7 (add the Primary Output = no dependencies) to 11 (add LLamaSharp.dll)
in Solution Explorer, under the name of Setup Project, in the folder "Detected Dependencies" appear "Microsoft.Extensions.DependencyInjection.Abstractions.dll" and "Microsoft.Extensions.Logging.Abstractions.dll"
build the entire solution: the Solution using LLamaSharp.dll and the Setup project:
in Solution Explorer: righ-click on the name of the whole solution ("2 of 2 projects"): Rebuild Solution
in the Output window, the same announcements appear:
------ Starting pre-build validation for project 'sinforma_setup' ------
WARNING: Unable to find dependency 'SYSTEM.COLLECTIONS' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.Logging.Abstractions.dll'
WARNING: Unable to find dependency 'SYSTEM.THREADING' (Signature='B03F5F7F11D50A3A' Version='<IP_ADDRESS>') of assembly 'Microsoft.Extensions.Logging.Abstractions.dll'
WARNING: Unable
[...]
Building file 'H:... ...\sinforma_setup.msi'...
WARNING: Including primary output of project 'blabla.csproj' with target framework '.NETCoreApp v8.0' may result in incomplete content. See here: https://go.microsoft.com/fwlink/?linkid=2112157
Packaging file 'Microsoft.Extensions.Logging.Abstractions.dll'...
Packaging file 'Microsoft.Extensions.DependencyInjection.Abstractions.dll'...
Packaging file 'sinforma.runtimeconfig.json'...
Packaging file 'LLamaSharp.dll'...
Packaging file 'blabla.dll'...
========== Rebuild All: 2 succeeded, 0 failed, 0 skipped ==========

The .exe is not there. Nor the other expected Dependencies of Abstractions...

(sorry - the many Edits were mostly for misspelled words)

Now - adding the Microsoft.SemanticKernel.Abstractions.dll as an Assembly:
Solution Explorer -> File System -> Application Folder
right-click -> Add -> Assembly
Browse... to file
C;... ...\nuget\packages\microsoft.semantickernel.abstractions\1.5.0\lib\netstandard2.0
choose the file:
Microsoft.SemanticKernel.Abstractions.dll
This is being Added to the "Application FoldeR" along with

seemingly all its Dependencies
which appear to be sufficient for the Setup Solution to be Built:
(although with Warnings that the files are under File Protection)

Packaging file 'netstandard.dll'...
Packaging file 'System.Security.SecureString.dll'...
Packaging file 'Microsoft.Extensions.Logging.Abstractions.dll'...
Packaging file 'Microsoft.SemanticKernel.Abstractions.dll'...
Packaging file 'System.Xml.XPath.XDocument.dll'...
Packaging file 'System.Runtime.InteropServices.RuntimeInformation.dll'...
Packaging file 'System.ValueTuple.dll'...
Packaging file 'System.Net.Http.dll'...
Packaging file 'System.Net.Sockets.dll'...
Packaging file 'Microsoft.Extensions.DependencyInjection.Abstractions.dll'...
Packaging file 'System.Runtime.Serialization.Primitives.dll'...
Packaging file 'System.Data.Common.dll'...
Packaging file 'sinforma.runtimeconfig.json'...
Packaging file 'System.Security.Cryptography.Algorithms.dll'...
Packaging file 'System.Threading.Overlapped.dll'...
Packaging file 'System.Diagnostics.StackTrace.dll'...
Packaging file 'System.IO.Compression.FileSystem.dll'...
Packaging file 'System.IO.Compression.dll'...
Packaging file 'LLamaSharp.dll'...
Packaging file 'System.Runtime.Serialization.Xml.dll'...
Packaging file 'sinforma.dll'...
Packaging file 'System.Diagnostics.Tracing.dll'...
Packaging file 'System.Globalization.Extensions.dll'...
========== Rebuild All: 2 succeeded, 0 failed, 0 skipped ==========

The issue was SOLVED this way:
Thank you! to AsakusaRinne] here.
To create a Setup project resulting in a .msi file which can be used to install the (WinForms) App (onto another computer with .NET 8.0/6.0):
Visual Studio Community 2022 17.9.1:

install the Microsoft.SemanticKernel as indicated at:
https://github.com/microsoft/semantic-kernel/blob/main/dotnet/README.md
build the Solution that is using LLamaSharp.dll
create a Setup Project ->
View -> File System
to the "Application Folder":
Add -> Assembly -> the EXECUTABLE file of the LLamaSharp solution: blabla.exe
7  Add -> Assembly: Browse... to the
Microsoft.SemanticKernel.Abstractions.dll as an Assembly
(it usually is in the C:\Users\username.nuget\packages\microsoft.semantickernel\1.5.0\lib\

then, possibly in:
\netstandard2.0\
as the file:
Microsoft.SemanticKernel.Abstractions.dll

the Dependencies of this^ .dll are being detected and Added to the "Application Folder" as well.
rebuild the entire Solution: the (WinForms) App and the Setup Project
run the .msi installer on the (other) computer
in the folder where it was installed, check on the presence of all packaged^ .dlls - they should be there
launch the App.exe - it should start

Thank you for so much detailed information! I'll try to reproduce this issue.
Two more questions please. Which files should be existed if all things go well? And is console program able to reproduce it?

There's a delay of message so plz ignore my last comment. Thank you for providing the solution!

All's well that ends well... Well... the "issue" remains with Documenting the creation of such a Setup file - candidly, I say that I was very interested in this because I want to install such a conversation program in the workplace... kinda showoff, yep.
I've tried both with

WinForms App
-- a simple dialog with
--- one Button for Browsing for the .gguf file of the LLM of interest
--- one Label to show this filename
--- one Button for sending the Prompt to the LLM,
--- two TextBoxes - one for the Prompt, the other for the Response
--- a timer/30sec and a statusbar with a label that would show the datetime
--- the .exe for this should be around 100 KB

In this case, I expected that the Primary Output to be the .exe.
However, the Setup Project considered that the Primary Output was a DLL.
So, in order for the necessary files (the exe and LLamaSharp.dll) to be deployed with the resulting .msi:

added manually to the "Application Folder": the .exe of the WinForms App
added manually to the "Application Folder": LLamaSharp.dll
added manually to the "Application Folder": Microsoft.SemanticKernel and the Microsoft.SemanticKernel.Abstractions
added automatically to the "Application Folder", by VS2022: the DLLs of the Dependencies of .Abstractions, after adding the SemanticKernel^

The .msi will deply these files and the .exe should run.

Console App
-- the process is the same as for a WinForms App.

Now then... you've deleted the comment... what was the second question? :)
I intend to write a tutorial of sorts about all this

in a PDF
and as a post on Medium
I'll post the links here, so that you/the users do with it as you see fit.

Thank you heartil;y!

Strike that...
You might as well delete the posts above.
It does not work.
wtx
The Dependencies are packaged and deployed, but
The messages are still there. Didn't see them :(
Back to square 1.5

only a part of Dependencies are resolved,
not those to components of .NET

The .exe

will open/run/launch when /double-clicked on the computer where it has been built/installed
will open/run/launch when /double-clicked on the computer where it has been built and deployed/installed
will not open/run/launch when /double-clicked on a computer where it has been deployed/installed

.NET 8 SDK is installed on both computers.
Beats me.

I've COPIED the contents of the bin/Release folder onto another computer
where the program WILL run.
Beats me a-gin.

I need /some fresh air.
Air Antarcica, or Mars even.
At least it works again.
I shall delete the steps above, about the deployment via setup program, and insert them below this post.
In Visual Studio:

to the setup package in the "Application Folder":
-- aside from the .exe of the Application, the .dll named the same MUST be Added too
the setup .msi
-- will be built WITH THE SAME WARNINGS about the impossiblity to resolve dependencies to Collections, Json and the rest in .NET 8.0
-- but it will deploy the .dll along with the .exe, this DLL being essential for the .exe to run, Forrest, run.

So I guess this issue may be Closed a-gin.
This HAS TO be tested to deth, some feedback from the community would do a whole lotta good...

It seems that we had misunderstandings at the beginning, sorry for the confusion. :)
Let's clear it together. You had a winform app depending on LLamaSharp and you find it unable to be distributed correctly because some files/dependencies are not dealt with correctly when building the project.

will the building succeed if you remove LLamaSharp and add microsoft semantic-kernel as dependency for example?

I meant that you could try building without LLamaSharp but with another arbitrary library to see if it's a problem due to LLamaSharp. Installing semantic-kernel is not expected to fix anything.
If it's indeed a problem related to LLamaSharp, then please put the log and output files list here, which will help us to fix the problem.

As far as I'm concerned, it is you! who provided the solution.
All's well that ends well... the "issue" remains with Documenting the creation of such a Setup file.
In order for an App which is using LLamaSharp to be packaged and deployed/installed on any computer with .NET 8.0/6.0, at this moment - it would be useful if results of tests by the community would be shown here - the steps to build such a setup .msi are:
In Visual Studio 2022 (Community  17.9.1)

Build the App - as an EXE, presumably
Add a Setup Project to its Solution
wherein the Setup project:
-- to the "Application Folder":  add manually LLamaSharp.dll (it should be in the Release or the Debug folder of the program)
-- to the "Application Folder": add manually the EXE of the program
-- to the "Application Folder": add manually the DLL with the same name as the EXE
-- to the "Application Folder": add manually: Microsoft.SemanticKernel
-- to the "Application Folder": add manually: Microsoft.SemanticKernel.Abstractions
-- to the "Application Folder", added automatically by VS2022: the DLLs of the Dependencies of .Abstractions, after adding the SemanticKernel^

The .msi will deploy these files and the .exe should run; repeat,

.NET 8.0/6.0 must exist on the computer
the DLL named the same as the EXE must be in the folder with the EXE and the other DLLs-Dependencies.

Sheesh.
Thank you heartily!

Though I'm still a bit confused by why adding semantic-kernel makes everything okay, I'm happy that your project finally works!
If there's any other related problem in the future, please feel free to reopen this issue or open a new issue. :)

It is possible, I daresay probable, that the program would be deployed as functional if someone, without installing the Semantic Kernel, only Adds to the setup project the EXE as an Assembly/File along with the Primary Output which seems to be the DLL.
This is why some more testing is needed. Afterwards, a proper guide; not a statistics on 2 computers configured the same...
Perhaps someone will indeed run a test under these conditions:

absence of Semantic Kernel
to the setup package -> File System -> Add -> Assembly/File: the .exe of the program and the .dll both named the same
build, deploy /somewhere, launch the .exe, see if it works

it works that^ way, too:

in the setup project -> File System -> ONLY ADDED:
LLamaSharp.dll
programname.DLL
programname.EXE
Rebult the setup project
installed on another computer
launched the EXE, it worked
For what it's worth, an image with the contents of the folder where the program was installed:

Looks like the Problem may be very simple: the addition of the EXE to the setup package.
Usually, by Primary Output of a /WinForms application, VS means the EXE - not in this case, though, where it took the DLL as Primary Output (it may be a .NET 8 thing), whereas the EXE had to be added manually, although it is the sine-qua-non part of the plot.
More testing is still welcome; LLamaSharp programs will be deployed all around.


implement multiline strings

Closes #17

Codecov Report

Merging #21 into master will decrease coverage by 0.25%.
The diff coverage is 67.44%.

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   77.73%   77.48%   -0.26%
==========================================
  Files          21       21
  Lines        2614     2647      +33
==========================================
+ Hits         2032     2051      +19
- Misses        468      475       +7
- Partials      114      121       +7

Impacted Files
Coverage Δ

scanner/scanner.go
73.17% <67.44%> (-1.32%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5262db8...c9d9c2f. Read the comment docs.


fix(logger): fix winston setImmediate issue in web export for logger

This is a winston issue, so by default use the console in the browser as opposed to some custom logger.

:tada: This PR is included in version 1.10.0-alpha.2 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.10.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Column size should be increased

In [1] point c should be changed. We should increase the column size to 2048 for REFRESH_TOKEN,ACCESS_TOKEN, AUTHORIZATION_CODE and CONSUMER_SECRET.
For example, H2/oracle/mysql should be as follows:-
ALTER TABLE IDN_OAUTH2_ACCESS_TOKEN modify REFRESH_TOKEN VARCHAR(2048);
ALTER TABLE IDN_OAUTH2_ACCESS_TOKEN modify ACCESS_TOKEN VARCHAR(2048);
ALTER TABLE IDN_OAUTH2_AUTHORIZATION_CODE modify AUTHORIZATION_CODE VARCHAR(2048);
ALTER TABLE IDN_OAUTH_CONSUMER_APPS modify CONSUMER_SECRET VARCHAR(2048);
[1] https://docs.wso2.com/display/IS530/Setting+Up+OAuth+Token+Encryption

Edited the commands for all tabs in point c. @nilasini could you please check and verify if they are correct? Please re-open if anything is wrong.
[1] https://docs.wso2.com/display/IS530/Setting+Up+OAuth+Token+Encryption

@sherenewso2 shall we make all capital? I mean only "modify" is in small letter

Fixed [1]
[1] https://docs.wso2.com/display/IS530/Setting+Up+OAuth+Token+Encryption

@emswbandara This change only needed in 5.3.0 doc.


Extension methods in TimeStamp raise warnings when loading in Pharo 5.0

Not sure how important is this issue, but we could fix it.
*** Warning: Warning: This package depends on the following classes:   TimeStamp You must resolve these dependencies before you will be able to load these definitions:    TimeStamp>>#bsonTypeCode   TimeStamp>>#writeBSONOn:

yes, we need to fix it (for Pharo5).
With Norbert, was just to add a class called MongoTimeStamp and make him the receipt of... Mongo time stamps :P
That has to be enough to fix it :)

Ok.
This extension to TimeStamp belongs to Mongo-Squeak, a small package with another extension method plus the class GratuitousIncompatibilities, which holds many convenience methods.
I think we can:

create a package Mongo-Pharo (or -Pharo50), and make Metacello load the proper package.
rename GratuitousIncompatibilities to MongoPlatform and subclass MongoSqueakPlatform and MongoPharo50Platform. This hierarchy will encapsulate the differences between platforms/versions.

For example, MongoPlatform can provide an abstract method newTimeStampFrom:aDateAndTime, and MongoSqueakPlatform returns TimeStamp while MongoPharo50Platform returns a MongoTimeStamp.
Does this sound good? do you know the users of Mongo package? in fact we should discuss this in some mailing list since the code is versioned in Smaltlalkhub... Well, maybe I just implement this idea and then send a mail to discuss it.

well, I do not think so.
a TimeStamp in MongoDB is not a type of date time.
For me, I would not create any Mongo-Pharo package because this is not a platform compatibility stuff. Otherwise you will need to do a Mongo-X package for placing the extensions to TimeStamp.
So… since a timestamp is not a date-time, I would:

create a class MongoTimeStamp, who holds a number.
make the read and write there, with this number.

We do not need any translation also because this timestamp is used internally in mongo, look here: https://docs.mongodb.org/manual/reference/bson-types/#timestamps
in case we need a conversion, we can add specific conversion methods to MongoTimeStamp, but I would not lose time mapping a type that is not supposed we use.
Esteban

On 11 Mar 2016, at 23:25, Martín Dias<EMAIL_ADDRESS>wrote:
Ok.
This extension to TimeStamp belongs to Mongo-Squeak, a small package with another extension method plus the class GratuitousIncompatibilities, which holds many convenience methods.
I think we can:
create a package Mongo-Pharo (or -Pharo50), and make Metacello load the proper package.
rename GratuitousIncompatibilities to MongoPlatform and subclass MongoSqueakPlatform and MongoPharo50Platform. This hierarchy will encapsulate the differences between platforms/versions.
For example, MongoPlatform can provide an abstract method newTimeStampFrom:aDateAndTime, and MongoSqueakPlatform returns TimeStamp while MongoPharo50Platform returns a MongoTimeStamp.
Does this sound good? do you know the users of Mongo package? in fact we should discuss this in some mailing list since the code is versioned in Smaltlalkhub... Well, maybe I just implement this idea and then send a mail to discuss it.
—
Reply to this email directly or view it on GitHub https://github.com/estebanlm/voyage/issues/11#issuecomment-195579099.

Ok, now I learnt more of Timestamp. Thanks! Before I just read the code and it really looks like MongoTimestamp=DateAndTime. See the marshaling methods:
BSON>>nextTimestamp
	^self nextDateAndTime asTimeStamp

BSON>>nextTimestampPut: aTimestamp
	self nextDateAndTimePut: aTimestamp

However, now I see:
nextDateAndTime
	^(GratuitousIncompatibilities intToDateAndTime: stream nextInt64)

Then, you propose to rewrite Timestamp reading to:
BSON>>nextTimestamp
	^ MongoTimestamp fromValue: stream nextInt64

similar to writing method.

yes, it was an historical error in MongoTalk :P

On 14 Mar 2016, at 20:25, Martín Dias<EMAIL_ADDRESS>wrote:
Ok, now I learnt more of Timestamp. Thanks! Before I just read the code and it really looks like MongoTimestamp=DateAndTime. See the marshaling methods:
BSON>>nextTimestamp
^self nextDateAndTime asTimeStamp
BSON>>nextTimestampPut: aTimestamp
self nextDateAndTimePut: aTimestamp
However, now I see:
nextDateAndTime
^(GratuitousIncompatibilities intToDateAndTime: stream nextInt64)
Then, you propose to rewrite Timestamp reading to:
BSON>>nextTimestamp
^ MongoTimestamp fromValue: stream nextInt64
similar to writing method.
—
Reply to this email directly or view it on GitHub https://github.com/estebanlm/voyage/issues/11#issuecomment-196485709.

I commit to http://smalltalkhub.com/#!/~MongoTalkTeam/mongotalk.

Done, but I should release a new stable version so that Voyage uses the changes. I'll wait a bit to see if somebody answers my email in pharo-users.

included in 1.9.2 of mongotalk; stable is 1.9.3.


[BotBuilder] TestFlow class does not match C# counterpart

Versions
What package version of the SDK are you using<EMAIL_ADDRESS>What nodejs version are you using v12.16.1
What browser version are you using
What os are you using Windows 10 Pro
Describe the bug
The JavaScript implementation of TestFlow does not offer the same capabilities of its C# implementation.
Attempting to implement some functionalities based on the C# implementation of TestFlow is not possible to use the JavaScript version, especially those that rely on the BotCallbackhandler since its missing from JavaScript.
To Reproduce

Clone BotBuilder-DotNet.
Navigate to /libraries/Microsoft.Bot.Builder/Adapters/
Open TestFlow.cs
Clone BotBuilder-JS.
Navigate to /libraries/botbuilder-core/src/
Open testAdapter.ts, scroll down to line 537.
Compare both implementations of TestFlow

Expected behavior
I expect TestFlow in JavaScript to use the same implementation as in C#.
Screenshots
TestFlow C# vs TestFlow JavaScript

Additional context
While migrating bot-solution from the botframework-solutions repository tests, we found that C# uses the callback's context to set the userProfileState, however, that is not possible to do it with the current implementation of TestFlow in JavaScript.
At the moment we rely on using TestAdapter, but neither uses the BotCallbackHandler.
[bug]

@dmvtech, please work with @gabog as needed to iterate on this.

@VictorGrycuk, thank you for bringing this to our attention. We'll begin bringing the two SDKs into parity. Please feel free to check back here for updates as work progresses.

@stevkan what's the status on this?

@stevengum, PR is near to being submitted for review. Working on writing tests and running, then will submit.

Removing customer tags as this was opened by Southworks

@stevkan, any update on this?  Was the PR submitted?  If so, could you close this?  Thanks!

Working on finalizing PR for submission.

@stevkan are there any updates on this issue?

Needing assistance on completing the TestFlow/TestAdapter tests. Set up time with @joshgummersall for help.

An error in the build process, when attempting to build a local copy, has been a roadblock for several weeks. However, I have finally gotten around the issue and will be moving forward on finalizing development of this.

An error in the build process, when attempting to build a local copy, has been a roadblock for several weeks. However, I have finally gotten around the issue and will be moving forward on finalizing development of this.

Both the TestFlow and TestAdapter constructors provide a callback parameter, so this is resolved.


ChangeDataHolderEvent implementation progress

Is the ChangeDataHolderEvent being worked on somewhere? 🍰

Potential answer, https://github.com/SpongePowered/SpongeCommon/issues/742#issuecomment-262993173

No, don't put issues just askking about the progress of them. As they're added to the API, they will be implemented.


Docs: Added Tabular Custom Model tutorial

Issue #, if available:
#1214
Description of changes:

Added custom model tutorial to Tabular docs

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-1238-1 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1238/1/index.html

Job PR-1238-2 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1238/2/index.html

Job PR-1238-3 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1238/3/index.html


Point our domain name "cleanslate.com" to the github site so that users are able to easily find us without knowing about github.

We haven't bought the domain yet. If you are interested working on this, let me know!

Here's what is necessary: https://help.github.com/articles/adding-a-cname-file-to-your-repository/.
In this case, that would mean:

Create a CNAME file in the repo root with the contents cleanslate.com.
Add DNS entries for the new domain (through the registrar's website, not GitHub). Create two CNAME records, one for @ and one for www, both pointing at codefordc.github.io.

The GitHub documentation itself is confusing, so I also referenced http://stackoverflow.com/questions/9082499/custom-domain-for-github-project-pages.

@brianek If you like I can take care of this or walk someone through it. I've done this sort of thing for github sites before (see my Israel blog repo for an example)
By the way which domain do we want? I just looked and cleanslate.com and .org are taken, and the .net is very expensive but cleanslatedc.com (as suggested by @ParentJA ) and .net are available, or we can look at other options. Possibly information overload, but there are also lots more TLD options than just a .com or .org

@DavidGinzberg yes if you could take care of it that would be great. Just an fyi that stvrlly would then like us to change it to https and he is willing to advise on that. I think cleanslatedc.com will work just fine. Let me just countact our legal partner and confirm! She should respond soon!

@DavidGinzberg yup we can move forward with cleanslatedc.org!!!

All set. The site is now visible at cleanslatedc.com thanks to the hard work of @brianek -- and HTTPS is >90% there


Revert keyspaces

Revert keyspaces and qualified persistence ids.

Update SBT and sbt-nexus plugin.

Silence some warnings.

Codecov Report

Merging #17 into master will increase coverage by 1.54%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   94.79%   96.34%   +1.54%
==========================================
  Files          11       10       -1
  Lines         173      164       -9
  Branches        1        1
==========================================
- Hits          164      158       -6
+ Misses          9        6       -3

Impacted Files
Coverage Δ

.../bluebrain/nexus/sourcing/akka/EventLogError.scala
0% <ø> (ø)
:arrow_up:

...bluebrain/nexus/sourcing/mem/MemoryAggregate.scala
96.42% <100%> (ø)
:arrow_up:

...ebrain/nexus/sourcing/akka/ShardingAggregate.scala
100% <100%> (+1.69%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd693ba...9c7ab29. Read the comment docs.


Disable steamvr's safe mode???

For 2 days when opening the Steamvr I get a sign that indicates that Steamvr is working in "safe mode" and gives me the options to "discard" or "disable safe mode". Until 2 days ago I chose the latter, "deactivate safe mode" and everything started to work correctly, but now, when I give it, I get a new "Steamvr settings" window in which it only tells me to connect the vr viewer and therefore does not let me disable safe mode, nor touch any settings. I use "Alvr" to connect my Oculus Go to the pc, and the problem is that in order for Steamvr to recognize the Oculus Go I need to deactivate the safe mode, but to deactivate the safe mode I need to have the Oculus Go connected ...... ..... any ideas or solutions ???
Or maybe I have no idea what's wrong :)
Thanks for any help.

Turn on advanced settings then go to the Startup / Shutdown tab and choose manage add-ons and disable or enable "alvr_server".
Then try to disable everything but the alvr_server then try it after a restart.


Add missing method call examples for some funcs, fix sign_unplacelist argcount

Maybe not exhaustive. Ref: neovim/neovim#16194.

And in the example at :help matchlist(), the first argument is a string:
echo matchlist('acd', '\(a\)\?\(b\)\?\(c\)\?\(.*\)')
               ^---^

So I would replace GetList() with GetText():
diff --git a/runtime/doc/eval.txt b/runtime/doc/eval.txt
index 418aee9ce..9df12952c 100644
--- a/runtime/doc/eval.txt
+++ b/runtime/doc/eval.txt
@@ -7920,7 +7920,7 @@ matchlist({expr}, {pat} [, {start} [, {count}]])		*matchlist()*
 		When there is no match an empty list is returned.

 		Can also be used as a |method|: >
-			GetList()->matchlist('word')
+			GetText()->matchlist('word')

 matchstr({expr}, {pat} [, {start} [, {count}]])			*matchstr()*
 		Same as |match()|, but return the matched string.  Example: >

Also, not sure why matchlist() accepts a list as first argument; all the items beyond the first one are ignored:
                v-------------------v                                              v-----v
:echo matchlist(['acd', 'abc', 'acb'], '\(a\)\?\(b\)\?\(c\)\?\(.*\)') == matchlist(['acd'], '\(a\)\?\(b\)\?\(c\)\?\(.*\)')
1

In Vim9, during type checking, maybe an error should be given if we pass a list instead of a string, so that the user does not get the wrong impression that the rest of the list matters, while in reality it does not; that could lead to issues which are hard to debug later in the code.

And in the example at :help matchlist(), the first argument is a string:
echo matchlist('acd', '\(a\)\?\(b\)\?\(c\)\?\(.*\)')
               ^---^

So I would replace GetList() with GetText():
diff --git a/runtime/doc/eval.txt b/runtime/doc/eval.txt
index 418aee9ce..9df12952c 100644
--- a/runtime/doc/eval.txt
+++ b/runtime/doc/eval.txt
@@ -7920,7 +7920,7 @@ matchlist({expr}, {pat} [, {start} [, {count}]])		*matchlist()*
 		When there is no match an empty list is returned.

 		Can also be used as a |method|: >
-			GetList()->matchlist('word')
+			GetText()->matchlist('word')

 matchstr({expr}, {pat} [, {start} [, {count}]])			*matchstr()*
 		Same as |match()|, but return the matched string.  Example: >

Also, not sure why matchlist() accepts a list as first argument; all the items beyond the first one are ignored:
                v-------------------v                                              v-----v
:echo matchlist(['acd', 'abc', 'acb'], '\(a\)\?\(b\)\?\(c\)\?\(.*\)') == matchlist(['acd'], '\(a\)\?\(b\)\?\(c\)\?\(.*\)')
1

It is possible to pass a List and it will find the list item with the
first match, but it's less useful.

In Vim9, during type checking, maybe an error should be given if we
pass a list instead of a string, so that the user does not get the
wrong impression that the rest of the list matters, while in reality
it does not; that could lead to issues which are hard to debug later
in the code.

It can be useful to see the submatches when matching an item in a list.
--
GALAHAD: No look, really, this isn't nescess ...
PIGLET:  We must examine you.
GALAHAD: There's nothing wrong with ... that.
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///


Incorrect text styles in metadata information

Fixes

Fixes #1587 by @panchovm
Check PR #1611 for more info
Description

Adds the correct meta-element styles.

Testing Instructions

Select Audio, Search any title and check the meta elements
Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[x] I added or updated tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

I am seeing the following styles

Tag pill label: Font size 14px and line-height 18px.
Metadata category: Font size 16px and line-height 32px.
Metadata value: Font size 14px and line-height 21px.

Tag pill label and metadata value should follow description bold style, whereas Metadata category should follow description regular style. Both text styles are font-size 14px and line-height 18px, but the font-weight changes.
You can see all text styles in the Design Library's page.

Tag pill label and metadata value should follow description bold style, whereas Metadata category should follow description regular style. Both text styles are font-size 14px and line-height 18px, but the font-weight changes.

The closest line-height i can find in the tailwind utility page is 1rem 16px (leading 4).
Should we update tailwind classes to match line-heights from the FIGMA document?

I also capitalized each word in the Genre category to match the Audio Release Figma Files

I just noticed my previous comment was completely miswritten.
I wanted to say that between both labels, category and value, there should be a 8px spacing, like this mockup. On the other hand, the capital feature looks excellent; great idea.
Sorry for the mistake 🤦♂

Sorry for the mistake man_facepalming

My bad, i was only checking the individual text styles in css without looking at the whole object's properties. Should be fixed.

@panchovm what should the line-height be when the album title is multiple lines long? I think currently it might be too large, here's an example:
https://search.openverse.engineering/audio/7e063ee6-343f-48e4-a4a5-f436393730f6
Might want to fix that in this PR too.

Might want to fix that in this PR too.

Even for larger titles, the title doesn't wrap. Mind detaling on what multiple lines means

Apologies @ramadanomar, referring to the album title in this section, the "I love my dog..." pink text next to the album art:

Example: https://search.openverse.engineering/audio/7e063ee6-343f-48e4-a4a5-f436393730f6

Oh, you’re right. It looks kind of weird.
On Tue, 23 Aug 2022 at 19:14, Zack Krida @.***> wrote:

Apologies @ramadanomar https://github.com/ramadanomar, referring to the
album title in this section, the "I love my dog..." pink text next to
the album art:
[image: CleanShot 2022-08-23 at 12 13 @.***
https://user-images.githubusercontent.com/6351754/186208958-88d3575c-66d1-448a-8d24-b32482927711.png
Example:
https://search.openverse.engineering/audio/7e063ee6-343f-48e4-a4a5-f436393730f6
—
Reply to this email directly, view it on GitHub
https://github.com/WordPress/openverse-frontend/pull/1645#issuecomment-1224294015,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANKBAJRANUK4OZNV7GERMDTV2T2HRANCNFSM56IQSN2Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

Both Description regular and Description bold styles have the same line height.

And here is how looks @zackkrida's example in a Figma mockup.

Great, so we should fix that line height in this PR as well. Thank you @panchovm !

Turns out it is fixed with this PR


Tests failing on travis

https://travis-ci.org/opensistemas-hub/osbrain/jobs/427931967
It's a weird error, so it's probably a Travis thing. I also launched the test suite locally and everything works flawlessly.
Just opening an issue so we remember to investigate this if it keeps happening in the future.
Edit: raw log.

@ocaballeror Can you rm -rf .tox && reset && tox -e py36? Just to make sure Tox is not using any outdated package version.
I can reproduce the error. It seems downgrading pytest to 3.7.4 fixes this issue.

Opened an issue in: https://github.com/pytest-dev/pytest/issues/3973

This is no longer a problem, I think. Closing...


Add e2e tests into Travis CI

Some regression tests have been put in place. Need to clean up the tests then add to a CI build.

Tests are in repo now, need to hook them up to the CI


Add alternative Calculus course

The MIT OCW Calculus courses don't have the limitation that come with EdX with the free license, they are also recorded in a university classroom, which should engage learners more and make them less bored.

Good idea, I've been a victim of edX's time limit one too many times. However I have a mixed experience with lectures recorded in classrooms. It can be distracting, harder to see/hear, and too long/boring. But some might find it more engaging, so it should be an alternative at least. I support this change.

Good idea, I've been a victim of edX's time limit one too many times. However I have a mixed experience with lectures recorded in classrooms. It can be distracting, harder to see/hear, and too long/boring. But some might find it more engaging, so it should be an alternative at least. All three courses together (32 weeks!) might look daunting to some, but I support this change regardless. Learners might want to take some breaks in between 1/3rds of the single long course.

32 weeks in only theoretical. Personally I finished it in less than 10 weeks. Really great course with a great professor!

OK if you already finished it and recommend it, then there's no problem.

This is a substantive change, so an issue should be opened to give contributors the chance to comment. Can you write up an RFC and post it in the issues. Including a link to this pull request will be helpful to show others exactly the change you envision.


Remove useless angular-cli package

The reference was useless and caused some warnings.
FYI: the package "angular-cli" has been replaced a long time ago by "@angular/cli".

The tests were  / are run with ng - that's also why now the build server fails:
sh: 1: ng: not found
npm ERR! Test failed.  See above for more details.
The command "npm test" exited with 1.

I have no time to look at it for now, but the "ng" command uses the angular cli package installed globally on a computer. It works with "angular-cli" and "@angular/cli".
So on my local computer it works fine, have to see what happens with travis...

Well yes if you have it globally installed it works. But you can also only have it as an npm package, then it's in node_modules\bin and when you run an npm script command it uses the one from there :)


VAD VadOptions unexpected keyword argument 'window_size_samples'

Which OS are you using?

OS: Linux Mint

Which Whisper Version?

faster-whisper==1.0.3

Hello thanks for the further improvements since I tested your software with my AMD GPU 580. In the meantime I bought a NVidia Card 3060ti and now I wanted to test the new features for faster-whisper.
Since I had hallucinations with german language I wanted to test with VAD activated.
But setting VAD Option to true in gradio leads to following error, after starting "Generate Subtitle File":
Console Output:
To create a public link, set `share=True` in `launch()`.
Error transcribing file: VadOptions.__new__() got an unexpected keyword argument 'window_size_samples'
Traceback (most recent call last):
  File "................software/whisper-webui/Whisper-WebUI/venv/lib/python3.10/site-packages/gradio/queueing.py", line 527, in process_events
    response = await route_utils.call_process_api(
  File "................software/whisper-webui/Whisper-WebUI/venv/lib/python3.10/site-packages/gradio/route_utils.py", line 270, in call_process_api
    output = await app.get_blocks().process_api(
  File "................software/whisper-webui/Whisper-WebUI/venv/lib/python3.10/site-packages/gradio/blocks.py", line 1856, in process_api
    data = await self.postprocess_data(fn_index, result["prediction"], state)
  File "................software/whisper-webui/Whisper-WebUI/venv/lib/python3.10/site-packages/gradio/blocks.py", line 1634, in postprocess_data
    self.validate_outputs(fn_index, predictions)  # type: ignore
  File "................software/whisper-webui/Whisper-WebUI/venv/lib/python3.10/site-packages/gradio/blocks.py", line 1610, in validate_outputs
    raise ValueError(
ValueError: An event handler (transcribe_file) didn't receive enough output values (needed: 2, received: 1).
Wanted outputs:
    [<gradio.components.textbox.Textbox object at 0x7f376b941210>, <gradio.templates.Files object at 0x7f376b9412a0>]
Received outputs:
    [None]

Additional Info
Maybe I should mention that I had problems with different cuda libs. I could solve these problems with the hints in issues for LD_LIBRARY_PATH and with installing
pip3 install torch==2.1.0+cu121 torchvision==0.16.0+cu121 torchaudio==2.1.0 torchtext==0.16.0+cpu torchdata==0.7.0 --index-url https://download.pytorch.org/whl/cu121

Hi. It seems that window_size_samples is deprecated in faster-whisper 1.0.3.
I'll work on a migration from 1.0.2 to 1.0.3 in faster-whisper!

thanks a lot :)

Migration has done in #198.
Please feel free to re-open if you face any error!

Wow really incredible fast update. Everything has worked. Thank you!!!
Only one question in faster_whisper I found an option: hallucination_silence_threshold how is this called in gradio?

@viebrix Parameters are cherry-picked to include only those common to different Whisper implementations (e.g., faster-whisper, insanely-fast-whisper).
I've moved the issue to #199!


Update install_ansible.sh to install python3-venv and be compatible with Debian 12

This change is a precursor to the Debian 12 update to CRD, which will be updated to be rebased off this branch.
This change is necessary because Debian 12's python environment is externally managed and using pip to install virtualenv breaks during the startup scripts.  Instead, I've moved to installing python3-venv through apt and updating pip from within the virtual environment.
Additionally, at least on the Ubuntu image, python3-venv isn't immediately available with the apt list, so an apt-update is required before installing any packages.

I am reassigning to @tpdownes who has much more context on the python environment we setup up for ansible. I will stay on as I am interested interested in the review.


Improve RBAC guide

Improve https://kubernetes.io/docs/reference/access-authn-authz/rbac/ (preview)
Relevant issues:

https://github.com/kubernetes/website/issues/2792
https://github.com/kubernetes/website/issues/15722

These changes don't cover all of what's needed; for example, the split into Concept and Task is left for another time.

/sig auth

I'll have time to review this after kubecon

/retitle [WIP] Improve RBAC guide

@liggitt thank you for a very comprehensive, clear and helpful review!
How's this looking now? Please have a look when you get a moment.

/retitle Improve RBAC guide

Really good feedback, thanks @liggitt

@sftim, Checking on the status of this pull request. @liggitt do you have further comments or request more changes?

it doesn't look like the last round of comments were addressed

/retitle [WIP] Improve RBAC guide

/retitle Improve RBAC guide
There might be some remaining concerns; in my view, these changes make the page better without any important regressions, and I recommend them for merging.

I just saw a bunch more feedbackthat GitHub had folded (it's a long page).
/retitle [WIP] Improve RBAC guide

OK, I hope this is better.
/retitle Improve RBAC guide

just one comment at https://github.com/kubernetes/website/pull/17538/files#r384134057, then lgtm

@kbhawkey thanks for spotting many details small & large on the journey to this point.
Do you see anything else I ought to revise?

Technical content lgtm.

@sftm, @liggitt . I read through the page. Here is some feedback:
There are a number of very small nits -- places where the sentences could be shortened or reworded for clarity. There is a lot of great information too.
The page has six main headings. I think the page could use a few more main headings, specifically to break up the [RBAC] API objects section. This section can be tedious to read and sometimes I found the explanations hard to follow.
The Command-line utilities section (generic title, could be renamed) almost belongs as a separate reference (kubectl RBAC commands).
Instead of listing all of the controller roles in , Roles for built-in controllers, is there another way to look up these roles? Does the cluster admin. need to do something with this list,
it runs all control loops using its own credential, which must be granted all the relevant roles.?

Can we iterate on that additional feedback in a follow up? This has made a significant number of changes already and has just gotten to the point where I'm comfortable with the technical content to merge.

In your view @kbhawkey, would merging this PR make the website / page overall better than how things stand?
I'm wondering about getting this merged and then starting on a new PR to do further tidying, as per https://github.com/kubernetes/website/pull/17538#issuecomment-552649806.

Yes, I think it makes sense to consume these changes now.
/lgtm

/approve

Rebased

/lgtm

Thank @liggitt, that was commendably fast.


ObservationServiceImpl.cancelObservation leads to duplicated calls to cancelObservation

Version(s)
fa38111cf1d4787ead04bd04002c2df7cccc8dc1
Which components
leshan server core
Tested With
No response
What happened
It happens during the Cancel Observation use case.
https://github.com/eclipse/leshan/blob/fa38111cf1d4787ead04bd04002c2df7cccc8dc1/leshan-server-core/src/main/java/org/eclipse/leshan/server/observation/ObservationServiceImpl.java#L124-L141
The way LwM2mServerEndpoint are built, they share the RegistrationStore and ObservationListener with ObservationServiceImpl (it is built in LeshanServer).
This method starts by removing observation from the store; then calling each endpoint to do the same with their own 'cancelObservation' method. It leads to this call :
https://github.com/eclipse/leshan/blob/fa38111cf1d4787ead04bd04002c2df7cccc8dc1/leshan-server-cf/src/main/java/org/eclipse/leshan/server/californium/observation/LwM2mObservationStore.java#L87-L91
But as the observation has already been deleted, it leads to removedObservation = null. And listeners are called with this 'null' observation.
The same listeners will then be called again in ObservationServiceImpl (line 139, this time with a non-null observation).
How to reproduce
Create a Leshan server with Coap and Coaps endpoints; setup with an ObservationListener :
leshanServer.getObservationService().addListener(observationListener);
With leshan-client, create an observation, then cancel it : your ObservationListener will receive 2 times the cancelled(Observation observation) callback with 'null' observation (1 for Coap endpoint, 1 for Coaps endpoint); then a last callback with the actual cancelled observation (from ObservationServiceImpl).
Relevant Output
No response

Great more issue to fix ! :yum:
@cyril2maq Thx again :pray: that really helps !
I will work on it now.

Not really done on purpose but I think that #1388 fix this too :thinking:
About adding test for multiple call. I think I will maybe do it after #1381 and I will probably give a try using mockito

I agree, in #1388 , with the GET then REMOVE mechanism you did add a null check after the GET which will skip the 'listener.cancelled' call.
https://github.com/eclipse/leshan/blob/c93c16de4761211494f0af4b0ada2e8585584586/leshan-server-cf/src/main/java/org/eclipse/leshan/server/californium/observation/LwM2mObservationStore.java#L87-L100
So no more duplicated calls to the cancelled callback !

About adding test for multiple call. I think I will maybe do it after https://github.com/eclipse/leshan/issues/1381 and I will probably give a try using mockito

I created an issue #1390.

I guess we can close this one as #1388 is now integrated in master.
Feel free to reopen, if I'm wrong.
Do not hesitate to provide more feedback or bugs reports ! We really appreciate this !


Revert "Added Flappy Bird Game"

What type of PR is this? (check all applicable)

[ ] 🍕 New feature/project
[ ] 🐛 Bug fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Related Issues & Documents

Related Issue #

Screenshots (optional)

@sadiul-hakim bhai, one another thing to update.. this project description in the data.json file is missing.  It's required for this project to be seen on the home page, could you add the project detail on the data.json and let me know..


Can we have page number data to use for dynamically rendering blocks of HTML?

I see that there is a way to inject page number information in the header and footer by way of an html element/classname, but I'd like to have access to that info in the form of an integer.
Use case: I am using this library to generate PDF invoices for customers and I have a footer that I only need to show up on the last page. The line items that are displayed on the invoice are always changing thus there are endless combinations of an invoice so having that information is the only way for us to correctly format the invoice

Hello @danielopatich
Gotenberg is "just" an API in front of Google Chrome, so this is unfortunately a limitation of the browser. There might be a workaround might with some JavaScript libraries though.


fix(test): timeout on windows, maybe fixes #636

Fixes the timeout on basic Windows (no WSL). Didn't do extensive testing but passed my small number of tests:

[x] I have read CONTRIBUTING.md
[x] I have read CODE_OF_CONDUCT.md

Thanks for the PR and the link with useful info!
I'll test this with 'mini.nvim' in GitHub Actions.

Thanks again for the PR!
It indeed seems to make 'mini.test' work on Windows. Finally!
However, this leaves me no excuse to enable Windows CI, which has ~350 fails out of ~4050 :( Most of them seem to be related to path differences and that Windows CI is slower. So I'll try to plough through fixing those before merging this change. Which may take a while :(

After a lot of trial and error using the infamous "CI debugging" approach, 'mini.nvim' is now automatically tested on Windows. All thanks to the solution from this PR which should be now part of main branch.
@cameronr, thanks again for this small in size but huge in consequences Windows pipe solution!


Restore Menu Highlighting Removed in #2172

PR #2172 removed some highlighting functionality that should be restored, but with a more global scope to highlight any menu item with a matching route.

A highlight that does more to accent the current page would also be preferred (such as changing the background color).

First timer but I'm interested in taking this!

Hi,
I am new to helping out on Open Source project and spoke with the .NetRocks guys at Progressive.Net and they said find an issue and dive in so here I am.  Happy to start with this one as it looks simple enough and learn the ropes from there.
Have forked the project and looking over the code while I await a reply.
Cliff.

@CliffAgius That's great. Go for it and let us know if you have any questions or issues. Are you on the slack channel?
@misterjames should be able to invite you.

@CliffAgius I started to look into this issue, and I found this blog post that might be helpful. Thought I'd pass it along.

@jonparker I am not on the slack channel any chance of an invite please @MisterJames
@dylanwooters did you get anywhere other than research I don't want to step on anyone's toes or repeat any work that may already have been done.

@CliffAgius I didn't get any farther than research. Feel free to take it! I'll grab another one.

@jonparker @dylanwooters Ok so I have finally found some time (Work sim check got in the way!) and built the solution locally to have a good look around the project. The problem is that looking on my local build the menu highlighting is working so I can't see what the issue is and believe this should be closed unless I am missing something...

As I tested this issue on local and azurewebsite, issue looks to be fixed.

Still seems to be an issue for me locally and on azure

I implemented the solution @jonparker suggested.


Fabo/eslint pretty

Fixed the compatibility between eslint and prettier
Missing:

[x] fix linting issues from updated packages
[x] add Karolys rules
[x] add eslint --fix to yarn lint:fix

unit tests failing


REM keyword in batch files is no longer displayed as comment

V 0.10.7

V 0.10.6

That's what pull request #1678 intended. Correct @dpodder?

@aeschli it looks like I missed this case. Problem is 'REM' is highlighted as a keyword in addition to being part of the comment line. I have a fix in 6d05f15, shall I submit a PR into master and/or release/0.10.7?

I'd say master, I don't see it as critical.

PR submitted: #2740


[heise] Support videos embedded in any article.

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[x] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Videos on heise.de are always embedded the same way, therefore supporting them in a uniform way is pretty easy. The tests show an example for the same video available under 3 different URLs and another article which has just an embedded video.

Just as a note: this would fix #6037, after applying this I'm able to download the example from the site-support-request.

Rebased to make sure it still works on the current master...

Rebased to fix merge conflict.


Update teams_discussion_comments with ByID and BySlug endpoints

Update endpoints for:
https://developer.github.com/v3/teams/discussion_comments/
All endpoints in "Team Discussion Endpoints" now have two ways to call
them: ByID and BySlug.
Fixes #1423.

Thank you, @ayzu!
Just a couple tweaks please, and then I think we will be ready for another LGTM before merging.

Thank you for the review, @gmlewis. I have updated the code.

Thank you, @wesleimp!
Merging.


Add error_retries parameter. Let the failure to be retry 3 times.

We noticed occasional DRPAI errors causing the GStreamer to stop. In this pull request, we retry the driver 3 times until we decide that GStreamer should stop.

We noticed occasional DRPAI errors causing the GStreamer to stop. In this pull request, we retry the driver 3 times until we decide that GStreamer should stop.

How did you determine that 3 is the right number? How did you test or verify that it works as expected?

How did you determine that 3 is the right number?

I just felt like 2 is not enough. It was a decision without any specific reason. It just felt good.

How did you test or verify that it works as expected?

The honeycomb dashboard is showing zero gstreamer container restarts since the update
Troubleshooting logs also show occasional errors but the inference is still running.


eslint-import-resolver-webpack and import-first

eslint-import-resolver-webpack is integrated into react-boilerplate, nonetheless, we got a bunch of Absolute imports should come before relative imports errors for imports like 'containers/LanguageProvider' that are actually local, as they're resolved with webpack.
Is this an expected behavior or a bug?

Is this related to: https://github.com/benmosher/eslint-plugin-import/issues/645?

@Dattaya is this no longer an issue when using the webpack resolver?

@Dattaya is this no longer an issue when using the webpack resolver?

--fix automatically re-arranges the imports, so it's less of a problem, I don't mind having imports like this 'containers/LanguageProvider' come first and everything else after it.
No one else is complaining, so I thought it's time to put it to rest, but if you consider it's worth keeping it open, please re-open it.

I think it's still worth fixing properly. If you could submit a PR with a failing test case, that would be most helpful.


Graphical differentiation between kinds of edges

When selecting a node, all the edges are highlighted equally, but some edges might be different than others:

There's inbound edges, which means, files that depend on the highlighted node
There's outbound edges, for files in which the highlighted node depends on
There's cycle edges, which are dependencies that introduce a dependency cycle

It would be nice to give the option to differentiate those somehow

The edges are actually highlighted differently. There's a particle effect where small dots flow either:

from the selected node to the outer nodes (outbound edge)
from the outer nodes to the selected node (inbound edge)

I played around with rendering edges that introduce cycles in red, but it makes the visualization more confusing, as the rules to determine which edge introduced the cycle are relatively arbitrary.
It also greatly depends on the language. For example, Go or Rust is going to be full of cycles just because of how the languages are made, whether JS tends to introduce less cycles.
I don't think this should change right now, maybe in the future


Move out static store implementation from TIR to utils

tir: parameterise store macros with store_source
tir: rename global_stores() to tir_stores()
tir: make stores! macro use a parameterised name
utils: remove append-only-store variant
utils(store): split up various stores into their own modules
tir: rename tir_sequence_* macros to static_sequence_*
utils(store): move static store implementation into hash_utils::store

Whilst we're at it, we could move everything here into hash-storage or rename hash-alloc into hash-storage and move things there?
closes #900

GG, looks great. I think moving to alloc and renaming to storage is a good idea.

should I do this in the current PR?

Yes I think so

Yes I think so
Done!


[event-hubs] fix version test

#6744 Changed the integration-test:node script to pull test files from dist-esm instead of dist. This caused the test that validates that the version constant matches the package.json to fail since it used a relative path to get the package.json.
For now I'm just updating the relative path in the test to unblock our live tests.
I'm a little worried that our script no longer uses the same (bundled) version of the SDK that node.js users would use when running the tests. Getting our samples run in an automated fashion will help with this, and we manually run the samples now before releasing, but would like to make sure we don't miss this going forward.

/azp run js - eventhubs-client - tests


[Docs]: Replace all occurances of https://ag2ai.github.io

Describe the issue
No response
Steps to reproduce
No response
Screenshots and logs
No response
Additional Information
No response

229 occurrences:


TimeoutWaitGroup - Wait Group w/ Timeout

This aims to be a drop in replacement for sync.WaitGroup.  The only difference is Wait() expects a duration parameter and returns the number of active workers if it times out.  It was originally designed to replace a common pattern in tests, but could also be useful in some production circumstances.  For example, on timeout it can be retried, which could be useful for a pattern like.
var twg timeoutwg.TimeoutWaitGroup
... // workers do twg.Add(1)
for workers := twg.Wait(2*time.Second) {
    ctx.Logf("Waiting for %d workers to complete", workers)
}

@jcodybaker have you checked https://godoc.org/golang.org/x/sync/errgroup#example-Group--Parallel  sounds a bit familiar in terms of functionality, sharing just in case might be helpful too :)

@wallyqs - Thanks for suggesting that.  That's interesting, though I'm not certain it addresses the same problem.  It looks like the errorgroup triggers (wait returns and the context is canceled) when one of the workers returns an error.  My main concern is detecting non-erroring deadlocks.  If I'm missing the point on that, let me know.
I wrote it to simplify/clairify this pattern in tests.  I've seen variants that use a unique channel for each test and avoid the i on the loop.
done := make(chan struct{})
go func() {
    defer func() { done <- struct{}{} }()
    // do work that should return, but could block
}
go func() {
    defer func() { done <- struct{}{} }()
    // do work that should return, but could block
}
go func() {
    defer func() { done <- struct{}{} }()
    // do work that should return, but could block
}
timeout := time.After(10*time.Second)
for i = 0; i < 3; {
    select {
    case <-done:
        i++
    timeout:
        t.Fatal("Test timed out")
    }
}

@jpoler - In general I'm not a fan of panics either.  That said, I was trying to design this as a drop in replacement for the existing sync.WaitGroup.  It has these assertions and panics as well as a few more obscure ones.  Since it's clearly there to help diagnose some otherwise tricky to spot bugs, I thought it would be worth including at least a subset of that behavior.
sync/waitgroup.go:77:func (wg *WaitGroup) Add(delta int)
sync/waitgroup.go:133:func (wg *WaitGroup) Wait().


Convert strings to int in intConverter

Try to be more lax and allow strings as parameters to prepered statements expecting ints.
Should fix #16

Unrelated to the open issue


Fix bug due to iterator invalidation

Hi,
I came across a strange bug in Mitsuba this week. Somehow during optimization, at a seemingly arbitrary (but not random) iteration, the LLVM backend would emit an error
drjit_f04142c9302e9174a3dbe2f6a84e85d3:1755:23: error: use of undefined value '%f0'
    store <8 x float> %f0, ptr %f0_p5, align 32, !noalias !2, !nontemporal !3
                      ^

Weirdly enough, this happened without any particular change of the code. The kernel was identical for all iterations of the optimization, except for this one extra line. And depending on the code in my program, it would happen at different iterations or not at all. But it was not random - for a fixed code, it would happen exactly at the same point across machines.
The variable it was trying to store here came from a VCall's creation, which didn't make any sense (as confirmed by @njroussel).
Some further debugging showed: in the beginning of the loop in jitc_llvm_assemble, the variable v had the correct state, most importantly kind was different from ParamType::Output. The code in the loop body doesn't seem to overwrite the original state either, as jit_var(index) always returned the correct result. However, I think what's happening is that the pointer v gets invalidated due to updates to the hash map state.variable when emitting the vcall code. So by the end of the loop iteration jit_var(index) is still fine, but v isn't valid anymore. This would also explain why the issue seems deterministic and why running it with sanitizers (address and UB etc) didn't reveal anything.
This PR contains a simple fix that seems to work. It simply fetches the variable pointer again before the final part of the loop body. This is a bit of a bandaid though, as it doesn't really guarantee much except that the last part of the loop body will execute correctly (where the problematic statement was emitted in the first place)
Here is a minimal Mitsuba reproducer that shows the bug when running using the latest Mitsuba master (on Linux).
import numpy as np
import drjit as dr

import mitsuba as mi
mi.set_variant('llvm_ad_rgb')

scene = mi.load_dict({
    'type': 'scene',
    'integrator': {'type': 'direct', 'bsdf_samples': 0},
    'emitter': {'type': 'point'},
    'object': {
        'type': 'cube',
        'bsdf': {
          'type': 'diffuse',
          'reflectance': {
              'type': 'bitmap',
              'bitmap': mi.Bitmap(np.ones((512, 512, 3), dtype=np.float32)),
          },
    }}
})
n_iter = 1024
n_sensors = 3

sensors = []
for _ in range(n_sensors):
  sensors.append( mi.load_dict({
      'type': 'perspective',
      'film': {'type': 'hdrfilm','height': 512,'width': 512},
  }))
params = mi.traverse(scene)
key = 'object.bsdf.reflectance.data'

opt = mi.ad.Adam(lr=2e-2)
params[key] = mi.TensorXf(np.ones((512, 512, 3)))
opt[key] = params[key]
opt.set_learning_rate({key: 2e-2})
params.update(opt)

# Initialize sensor resolutions
for sensor in sensors:
  sensor_params = mi.traverse(sensor)
  sensor_params['film.size'] = mi.ScalarVector2i(64, 64)
  sensor_params.update()

seed = 0
for i in range(n_iter):
  print(f'Iter {i}')
  for sensor in sensors:
    img = mi.render(scene, sensor=sensor, spp=2, params=params)
    loss = dr.mean(img**2)
    dr.backward(loss)

  opt.step()
  params.update(opt)

Good job tracking this down!
We've already had a few of these bugs where we need to call jitc_var again. I'm not that surprised we're still finding some...
I found the missing piece of the explanation: during the Vcall assembly, we call clear_side_effects() which will reduce reference counts of some JIT variables and thus might free a variable which can change the state.variable map.
This explanation also matches the example: the gather from the texture will become a scatter in the backward(), hence producing a side-effect in the BSDF::eval_pdf_ad_bwd vcall.
Somehow, this magically doesn't break anything else critical for ~100 iterations in your example :man_shrugging: .
Your fix is fine, we could eventually relocate it right after jitc_llvm_render_var.

Okay I see, thanks for taking another look. Good to know that this limitation of the jit_var function is known. This makes me more confident in the fix as well. I will merge as is and we could at a later point iterate on this.


Feature request: Add codelens support

Adding codelens in the default editor to run readme commands in the vscode terminal would be less disruptive than switching to the full blown notebooks.

@pomdtr we shipped codelense support in Runme v1.2.0. Any feedback would be much appreciated.
@sourishkrout I suggest to close this issue. We don't have any documentation around codelense yet, I will raise a PR for it.

Seems like we have it documented, added a little tweak to make it easier discoverable: https://github.com/stateful/docs.runme.dev/pull/208

Hi, @pomdtr! It seems like this has been resolved and documented. If you encounter any issues please do let us know by opening an issue. Thanks for reporting it!


chore: bdd-nh-1584525774 to 0.0.1

chore: Promote bdd-nh-1584525774 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Build wheels for abi3-manylinux_2_31_aarch64

As the title say, we should generate wheels for abi3-manylinux_2_31_aarch64

Replaces #2355

Related to https://github.com/rerun-io/rerun/issues/2628

This keeps coming up and we also have the first asks for a C++ arm64 linux version! (https://discord.com/channels/1062300748202921994/1169763840607653910/1169763840607653910)

Related to

#4136

We should be able to do this pretty easy with cross-compilation

This is also very relevant for Android

Would also like to express the interests on arm64 linux pre-build!
Before it happens, is there anyway to get it working? Say compiling natively on an arm64 platform?

Yes, checking out the repository and compiling it yourself should work. I believe @abey79 has experimented with this.

Yes, I have successfully done it! On x11 gui it works, but on wayland it crashes. Good enough

Resolved in #5543


validate compatibility between connector type and row format

For example:
create materialized source s1 (
    v1 int,
    v2 float,
    primary key (v1)
) with (
    connector = 'datagen',
    fields.v1.kind = 'sequence',
    fields.v1.start = '1',
    fields.v1.end  = '10',
    fields.v2.kind = 'sequence',
    fields.v2.start = '11',
    fields.v2.end = '20',
    datagen.rows.per.second='15',
    datagen.split.num = '1'
) row format debezium_json;

The create source succeeds but warning for every row in the log.
Probably validating as early as possible is better?
Or the current approach is intentional?
It's a two-dimensional matrix, isn't it?
connector type X row format type.

related https://github.com/risingwavelabs/risingwave/issues/6948

datagen connector, after #7032 , will directly produce datachunks and ignore the row format properties.

#7612 introduces native as datagen's default row format. But we still accept row format json for test use.
We will ban other row formats from creating source with datagen connector.


Out of date image in documentation

http://docs.godotengine.org/en/2.1/learning/step_by_step/singletons_autoload.html
On the above page the autoloader's parameter order has changed.
Current doc image:

Current screenshot from Godot:

Notice that the path and the node name params have switched place, which was annoying as I was following along

Hey!
This belongs to godot-docs, could you open this issue there?

Opened new issue in docs repo: https://github.com/godotengine/godot-docs/issues/1328


Doesn't work on some roms

RT

What do you mean by RT?

Whatever,It doesn't work on LG G5,Nubia Z9 max,Sony Z5p etc

What exactly doesn't work? It would help if you could describe the issue or
even provide a screenshot or recording.
Em 03/05/2016 5:31 da manhã, "Dalvik"<EMAIL_ADDRESS>escreveu:

Whatever,It doesn't work on LG G5,Nubia Z9 max,Sony Z5p etc
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/rubensousa/FloatingToolbar/issues/8#issuecomment-216432977

Just no response after pressing the fab.

Sorry I can't record , It works well on my device , it is my user reported that to me.

Can you send the sample code of your FloatingToolbar setup? Are you setting another click listener to the FAB?

Thanks for your patient ! But I didn't set any other listener to the fab.

If there's no response after pressing the FAB, it could be because:

Animations aren't starting for some weird reason. What I could do is force the start with .start() of the ViewPropertyAnimator, but I don't know if this would still fix it.
FAB is not attached to the FloatingToolbar.

Please, copy a sample of your layout and java code so I can try to reproduce this.

Sure.But I can't get touch with programmer this time. How about Friday?

Just post it here when you can. I'll take a look when I have time.

Yes,thank you very much.

Hi, these are my code:
@Override
protected void onCreate(Bundle savedInstanceState)
{
super.onCreate(savedInstanceState);
getWindow().addFlags(WindowManager.LayoutParams.FLAG_SECURE);
setContentView(R.layout.main);
ArrayList<Map<String,String[]>> al = new ArrayList<>();
final Map<String,String[]> map_main = new HashMap<>();
map_main.put(SQLHelper.TABLE,new String[]{"password"});
map_main.put(SQLHelper.FIELD,new String[]{"name","host","user","pw","time"});
al.add(map_main);
sql = new SQLHelper(this,"passwords",al,0);
getSupportActionBar().setSubtitle(getString(R.string.passwords));
	if (sql.select().getCount() > 0)
	{
		findViewById(R.id.mainLinearLayout).setVisibility(View.GONE);
		rv = (RecyclerView) findViewById(R.id.main_rv);
        final FloatingToolbar ftb = (FloatingToolbar) findViewById(R.id.floatingToolbar);
        assert rv != null;
        rv.setVisibility(View.VISIBLE);
		rv.setLayoutManager(new LinearLayoutManager(this));
		rv.setAdapter(new PasswordAdapter(sql.select()));
		rv.addItemDecoration(new RecyclerView.ItemDecoration(){
				@Override
				public void getItemOffsets(Rect rect, int position, RecyclerView rv)
				{
					//rect.bottom += 10;
				}
			});
		rv.setOnScrollListener(new RecyclerView.OnScrollListener(){
				@Override
				public void onScrolled(RecyclerView rv, int p1, int p2)
				{
					if (p1 < p2)
					{
						((FloatingActionButton) findViewById(R.id.fab)).hide();
					}
					else
					{
						((FloatingActionButton) findViewById(R.id.fab)).show();
					}
				}
			});
        rv.setOnTouchListener(new View.OnTouchListener() {
            @Override
            public boolean onTouch(View v, MotionEvent event) {
                ftb.hide();
                return false;
            }
        });
        rv.addOnItemTouchListener(new RecyclerView.OnItemTouchListener() {
            @Override
            public boolean onInterceptTouchEvent(RecyclerView rv, MotionEvent e) {
                ftb.hide();
                return false;
            }

            @Override
            public void onTouchEvent(RecyclerView rv, MotionEvent e) {
                ftb.hide();
            }

            @Override
            public void onRequestDisallowInterceptTouchEvent(boolean disallowIntercept) {
            }
        });
        ftb.attachFab((FloatingActionButton) findViewById(R.id.fab));
        ftb.setClickListener(new FloatingToolbar.ItemClickListener() {
            Toast toast;
            @Override
            public void onItemClick(MenuItem menuItem) {
                switch(menuItem.getItemId()){
                    case R.id.generater:
                        showNewPassword();
                        break;

                    case R.id.instert:
                        insert(null);
                        break;
                }
            }

            @Override
            public void onItemLongClick(MenuItem menuItem) {
                if(toast != null) toast.cancel();
                (toast = Toast.makeText(MainApplication.getApplication(),menuItem.getTitle(),Toast.LENGTH_LONG)).show();
            }
        });
	}
}

And this is the xml file:
`
<android.support.design.widget.CoordinatorLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_height="match_parent"
xmlns:app="http://schemas.android.com/apk/res-auto">
<RelativeLayout
	android:layout_height="match_parent"
	android:layout_width="match_parent">

	<android.support.v7.widget.RecyclerView
		android:layout_width="match_parent"
		android:visibility="gone"
		android:layout_height="match_parent"
		android:id="@+id/main_rv"/>

	<LinearLayout
		android:layout_width="match_parent"
		android:id="@+id/mainLinearLayout"
		android:gravity="center"
		android:orientation="vertical"
		android:layout_height="match_parent">

		<TextView
			android:layout_height="wrap_content"
			android:layout_width="wrap_content"
			android:text="添加您的第一个密码"
			android:textAppearance="?android:attr/textAppearanceLarge"
			android:paddingBottom="5dp"/>

		<TextView
			android:layout_height="wrap_content"
			android:layout_width="wrap_content"
			android:text="点击右下角的浮动按钮来添加"
			android:textAppearance="?android:attr/textAppearanceMedium"
			android:paddingBottom="5dp"/>

		<Button
			android:layout_height="wrap_content"
			android:layout_width="wrap_content"
			android:onClick="how"
			android:text="使用必读"/>

	</LinearLayout>

</RelativeLayout>

<com.github.rubensousa.floatingtoolbar.FloatingToolbar
	android:id="@+id/floatingToolbar"
	android:layout_width="match_parent"
	android:layout_height="?attr/actionBarSize"
	android:layout_gravity="bottom"
	app:floatingMenu="@menu/menu_bar" />

<android.support.design.widget.FloatingActionButton
	android:layout_width="wrap_content"
	android:layout_height="wrap_content"
	android:layout_alignParentBottom="true"
	android:layout_alignParentEnd="true"
	android:layout_marginEnd="20dp"
	android:layout_gravity="end|bottom"
	android:id="@+id/fab"
	android:src="@drawable/ic_expand_more_white_24dp"
	android:layout_marginBottom="20dp"/>

</android.support.design.widget.CoordinatorLayout>
`

Why did you close this? Did you fix something?

Oh god. I wanted to comment but clicked close...
Yes I think I fixed it. Sorry to touble you, it is my fault.
But there is still a problem, which is the restored FAB's position.

Is it the same as issue 6?

Yes. But the different is my incorrect position is center left.

Did you fix this or just gave up using the library? I haven't been able to reproduce this with your layout.

Well I'm still using it and I'm looking at issue 6, It u can't reproduce it , this may help you:
screenshot

Ok, I'll take a look at this again. But I'll close this issue in favor of #6


grad_diff.backward()

On line 93 in main.py, when doing the back propagation, did you freeze the model parameters so that it would only update the dummy inputs?

Never mind, just saw you only passed the dummy inputs and outputs to the optimiser.


Find (or select) split metastore API?

I've noticed this pattern a few times in the codebase:
metastore.list_all_splits().iter().find()

In the short-term, we could expose a new find_split(index_id, split_id) -> Option<Split> metatore API. In the long-term, we probably want select_splits(index_id, expression) -> Vec<Split> where expression can express arbitrary filters.

Closed via #2152.


Update to Ruby 2.6.1

This keeps us on the upgrade treadmill and doesn't seem to have caused obvious breakage. Changes:

Upgraded from unpinned toolchain with patched binaryen to Emscripten 1.38.28 and matching binaryen (since our patch is now upstream)
Upgraded from Ruby 2.6.0 to 2.6.1, revising documentation and home page to match
Rebuilt Ruby assets

🎉 thank you, Will! ❤


[Feature][Connector-V2][File] Fix filesystem get error

Purpose of this pull request
Fix the logic error of getting filesystem.
If we use new File(path).toURI() it will generate URI with file schema, so that FileSystem will always instantiate LocalFileSystem

Check list

[x] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs

@ashulin @EricJoy2048 PTAL.


xlnet问题

跑xlnet百度数据集分类任务时，初始化graph时出现
ValueError: Was asked to retrieve layer at index 247 but model only has 129 layers.
怎么解决

已修复，之前写死了提取的层数，默认只支持xlnet-mid


ARC-267 Updated the app descriptor so the app will add an item in the…

In this PR I've changed the app descriptor to add another item in the navigation bar, so GitHub App configuration will be easily accessible from the Apps configuration pages:

Declined, created a new PR for the micros branch  https://github.com/integrations/jira/pull/499


Major refactor

Move to the following project structurre
controllers (Pretty much routes)
main.go
db
models (For all db related stuff)
public
templates
translations
utils

https://github.com/jinzhu/configor
https://github.com/tdewolff/minify
LRU cache for db results
External package for form validation?
Optimize queries
Possibly use gin to reduce needed code further?
Write api documentation

I don't know though. I like services, they are really useful to use in controllers. It helps to not have duplicated codes in it and separe them from other pieces of code by being in their own packages. I think of them as the link between a controller and its model.
Why I didn't put everything in model then? Which should be the the link in MVC architecture, it is due to import cyclic error of golang. Golang tends to have packages really huge. But that makes code less maintenable and less understandable, since you might lose time to find where is the function. you search. Just try on gin-gonic repo to find the allocateContext function.
Anyway between too large packages which you have to import each time for only one or two files in it and small packages with services, I would rather go for the latter.
However, we can try to make fuse utils and services and rename it as utils or something else.
By the way, I already tried to seperate models in directory for each model and import the services in those directory.  However we have then an import cyclic thing between the models. For example, Comments import torrents which import comments...