Issue-Memoisation where possible

Automated Review Comments
Issues in src/components/App.tsx:

(2, 'Hardcoded string found')
(3, 'Hardcoded string found')
(19, 'Line exceeds 80 characters')
(23, 'Hardcoded string found')
Issues in src/components/Footer.tsx:
(2, 'Hardcoded string found')
(3, 'Hardcoded string found')
Issues in src/components/Header.tsx:
(2, 'Hardcoded string found')
(3, 'Hardcoded string found')
Issues in src/components/coins/CoinListItem.tsx:
(5, 'TODO found')
(7, 'Hardcoded string found')
(9, 'Line exceeds 80 characters')
(13, 'TODO found')
Issues in src/components/news/NewsItem.tsx:
(2, 'Hardcoded string found')
(3, 'Hardcoded string found')
(7, 'Line exceeds 80 characters')

I got it.


Login/Singup Design #11

I have created a better looking login sign up form have a look using tailwind css->
BEFORE->

AFTER->
LIGHT MODE

IN DARK MODE

@varruunnn Awesome work! Pul request accepted!


Support I/O on behalf of a different request

See https://github.com/cloudflare/workerd/discussions/420#discussioncomment-5211643.
User signals to connect to Native Messaging host from arbitrary Web page => QuickJS Native Messaging host sends data to browser extension ServiceWorker => Chromium browser extension ServiceWorker POST to workerd => workerd throws when ReadableStream is passed to Response to send data back to Web page.
I couldn't locate any documentation about how to use I/O (stdin/stdout) or launch a subprocess, if either are possible in workerd, so I used the above flow
Cannot perform I/O on behalf of a different request.
I/O objects (such as streams, request/response bodies, and others) created
in the context of one request handler cannot be accessed from a different
request's handler. This is a limitation of Cloudflare Workers which allows us
to improve overall performance.

This issue isn't directly related to the @cloudflare/workers-types package, which just contains the TypeScript definitions for Cloudflare Workers, so I've removed the types label.

Your automation pinned that label, not me.

I think it's unlikely we'll be able to lift this restriction though.

Kindly explain why you can't lift that restriction.
It is no different from a user uploading a file, writing to disk, then fetching the file and serving the contents in subsequent requests.
Further, streams are per specification transferable. The application should not be imposing arbitrary restrictions which should be user-defined options.
workerd authors might consider one capability not suitable for "performance" reasons, the user might think that capability is useful, in spite of what workd authors claim.
Thus, that should be exposed as a user option. Why should you care what the user does in their own environment with your gear?

currently cannot read stdin or launch subprocesses.

Technically you can read stdin, via requests. And write stdout via responses.

From reading the discussion, I'm still a little confused what you're trying to do. Are you trying to stream video into workerd and then broadcast this to other clients? I'm not sure if workerd is the best option for this at the moment.

I mainly experiment with browser extensions and Native Messaging https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Native_messaging, https://developer.chrome.com/docs/apps/nativeMessaging/. I have successfully streamed real-time audio I capture ("What-U-Hear", audio output to speakers and headphones) from the Native Messaging host to arbitrary Web pages the user is visiting, that stream can be shared with other peers via WebRTC or streams (fetch(), WebSocketStream, WebTransport).
Native Messaging using IPC and JSON for communication.
While Chromium MV3 extensions do have a ServiceWorker, that ServiceWorker cannot set arbitrary Web pages as a WindowClient, or Client (Worker, SharedWorker, Worklet). We can write the stream directly to the Web page using scripting; open an iframe or use window.open() and use Transferable Streams to transfer a ReadableStream to the client via postMessage().
What I am ultimately trying to do is test streaming JSON versus streaming using Streams standard or implementations thereof outside of Chromium.
So far, no application I have tested (there have been many similar to your application; from Dune to Deno, to Bun, to vmware-wasm-workers-server, to WasmEdge) comes anywhere close to the Streams Standard implementation in Chromium - nor the ServiceWorker implementation. Some due to restrictive philosophies, "it's my application, and I'm doing it my way"; to Deno HTTPS server running CPU at 90% when streaming! At least in Deno I can pass a stream from one request to a different response. Streams are per specification transferable objects.
I was referred here via this https://groups.google.com/a/chromium.org/g/chromium-dev/c/oYfjtQwt9AA/m/84WdUvnlAAAJ.
Testing your claims, and finding what is broken technically, and what is broken in management culture, seeing if your team is open to constructive feedback; or already know it all, and write perfect code and have perfect concepts users should be happy you decide to share with the public.
What I'm doing is testing your gear, in general, and for my own use cases - following this principal:

von Braun believed in testing. I cannot
emphasize that term enough – test, test,
test. Test to the point it breaks.

Ed Buckbee, NASA Public Affairs Officer, Chasing the Moon

I'm not sure if workerd is the best option for this at the moment.

I'm not sure either. That's why I ask questions. To get answers, and an idea if the maintainers are open to constructive feedback, and exposing user-defined options instead of imposing their own arbitrary restrictions as defaults, without exposing options to adjust the application in the field - where such restrictions are really just preference of the maintainers.


[Feature]

Description
I think there we can add a new file in JSON for PHP language. It can be very help full.
Screenshots
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)
[X] I am participating in Hacktoberfest 2023

@Alisha-786
I have assigned you the issue. Please proceed with it, and don't hesitate to tag me @Anmol-Baranwal or @CBID2 if you require any assistance.
It should be in languages category, and also update the title of this issue.


Why can not load a sklearn model by the request for Flask

I saved a sklearn model by joblib.load()。
    model = RandomForestClassifier(n_estimators=100)
    model.fit(feature_train, target_train)
    joblib.dump(model, "%s/%s" % (model_path,"RandomForest.pkl"))

And I want to load the model through sending a request。
@app.route('/getClassification/',methods=['GET','POST'])
def classify():
    load_model = joblib.load( "%s/%s" % (model_path,"RandomForest.pkl"))
    return  "test"

try:
    reponse = requests.post(monitor_url, data=params, timeout=60)
    print reponse.content
except Exception, e:
    print e

But the request never responded  until it Read timed out。
I dont save a sklearn model ，instead I save a string for testing。
joblib.dump("111222", "%s/%s" % (model_path,"RandomForest.pkl"))

It loaded successfully。
If I load the model alone，no use request for Flask，It can also load successfully.
Why can not load  a sklearn model by the request for Flask
Environment

Python version: 2.7.14
Flask version:0.12.2

Please use Stack Overflow for questions about your own code. This tracker is for issues related to the project itself. Be sure to include a minimal, complete, and verifiable example.


Avoid network change on MetaMask

Hello, I'm approaching to zkSync for the first time, and I have a question:
Is it possible to invoke write methods of a contract without changing the active network, and using directly the Ethereum Mainnet, on MetaMask?
In the greeter-tutorial-starter I can see this:
https://github.com/matter-labs/greeter-tutorial-starter/blob/master/src/App.vue#L163
This makes me believe that it isn't supported and if so, why?
Thank you

One cannot submit a normal zksync transaction without changing the active network in Metamask. However, you can submit so-called "priority" operation this way: it will be stored in zksync L1 contract, our server will pick it up from there and execute. However, this is much more expensive, as you need to pay for L1 gas.


Updated sources section according to Figma design

Fixes #279

Now error message is a bit broken

But it looks great!

Hey @dartpain I've took into consideration error state, could you review it once. Thanks.

@holopin-bot @siiddhantt  Thank you!


Forgot a period and misspelled several words.

Small grammar changes.
Signed-off-by: Kewbish<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Action link on Manage data planes view does not work (yet)

Same for Manage APIs view:

We didn't have dataplane and API monitoring page for the beta release. It will be enabled in GA Release.


Update IDMap to use uint64

https://github.com/grafana/jfr-parser/pull/39

As far as I searched, IDMap is only used in MethodList. MethodRef already uses uint64 which would be used as key for the IDMap. So I don't see a need to change anything further.

ok I'm wrong.  Sorry for confusion.


Updates for ol-mapbox-style v9.2

Updates the tests for background, because the underlying implementation in ol-mapbox-style has changed.

Ok, thanks for spotting this, @tschaub. I'm going to investigate this.

Actually this branch fixes the appearance of the land areas. See https://github.com/openlayers/ol-mapbox-style/pull/671. The latest release suffered from a problem with the changed background rendering. For comparison, see https://openlayers.org/en/v6.15.1/examples/mapbox-style.html.

I see.  Thanks for confirming.


Cloning kconfig from github if necessary

This pull request replaces #442 because a rebase became necessary.
This pull request is an attempt to fix issue #438 by cloning a standalone kconfig support from github if the Linux kernel sources are not installed.
Note: If menuconfig does not work due to missing ncurses support, oldconfig may be used instead.
In this case oldconfig should be the first target to be addressed in the make process.
I.e. instead of calling make image (or make model) you should call make oldconfig image or make oldconfig model.

works in Simulation with the whole set of configurations

We did decide not to use the standalone kconfig support but to require the existence of the Linux kernel sources as pre-requisite for the configuration process.


kitti evaluation tool update

Hi! BIchen, thanks for sharing your work, I'm wondering if the evaluation tool you use in the repo is the latest eval tool of kitti as there is an update on 2017/04/25, according to the official site:
All methods are ranked based on the moderately difficult results. Note that for the hard evaluation ~2 % of the provided bounding boxes have not been recognized by humans, thereby upper bounding recall at 98 %. Hence, the hard evaluation is only given for reference.
Note 1: On 25.04.2017, we have fixed a bug in the object detection evaluation script. As of now, the submitted detections are filtered based on the min. bounding box height for the respective category which we have been done before only for the ground truth detections, thus leading to false positives for the category "Easy" when bounding boxes of height 25-39 Px were submitted (and to false positives for all categories if bounding boxes smaller than 25 Px were submitted).

kitti

Have you figured it out if it has been updated in this repository ?


[Bug]  RPC load_module failed because of file path

case1: pass
mod.save(temp.relpath("gemm.o"))
f = remote.load_module(temp.relpath("gemm.o"))
case2: failed
mod.save("/home/ubuntu/gemm.o")
f = remote.load_module("/home/ubuntu/gemm.o")
log:
TVMError:
An error occurred during the execution of TVM.
For more information, please see: https://tvm.apache.org/docs/errors.html
Check failed: ecode.value() == 0 (2 vs. 0) : Cannot open file: /home/ubuntu/gemm.o No such file or directory
Expected behavior
case2 pass
What you were expecting
  def load_module(file_name):         """Load module from remote side."""         path = temp.relpath(file_name)         m = _load_module(path)         logger.info("load_module %s", path)         return m
In file tvm/rpc/server.py, file_name will be changed to be with temp_path prefix, it is weired.

mistake


Enable the distributed tracing instrumentation by default

As asked by @stayallive, this PR enables all the tracing instrumentation by default. Since the traces_sample_rate option can be configured using an environment variable, we have no way to know ahead of time if the tracing will be enabled or not: this has the consequence that we have to keep all services registered in the container and active with the negative note that the performance of the application will be slightly affected. I don't know how much loss we we're talking about, but some instrumentation is deeply integrated with low-level things like the driver's connection of the DBAL so I expect at least a bit.

I'm not familiar enough with how Symfony "boots" but in Laravel we register with the container (just registering classes no actual newing classes) and in the boot sequence of Laravel we inject our middleware and other changes to inject tracing into the framework.

https://github.com/getsentry/sentry-laravel/blob/0c932f2ba38acca9988d2585dc60dd358cd15ab1/src/Sentry/Laravel/Tracing/ServiceProvider.php#L16-L34

For Laravel this is "just in time" and we have access to the config (merged with .env and whatnot) to check if we should enable tracing.
In various places we make sure we do as little as possible when there is no current span set:

https://github.com/getsentry/sentry-laravel/blob/0c932f2ba38acca9988d2585dc60dd358cd15ab1/src/Sentry/Laravel/Tracing/EventHandler.php#L65-L70

The few bits and bobs we do register (although tracing might be disabled or sampled out) are very lean and add little to no overhead to the request.
I'm not sure if this helps or is useless info but this is how we handle it in Laravel to be ready for tracing but do as little when tracing turns out to be disabled.
The reason I asked for a change like this is because if the user enables tracing all "integrations" (DBAL, HTTP requests etc.) should be enabled by default (it is of course still fine to have a config option to disable them) so there is minimal config to tweak to start with tracing.

The reason I asked for a change like this is because if the user enables tracing all "integrations" (DBAL, HTTP requests etc.) should be enabled by default (it is of course still fine to have a config option to disable them) so there is minimal config to tweak to start with tracing.

I agree with this approach, but I'm not sure if what this PR is accomplishing right now is this. IMHO, the end user should obtain the bundle config with these default values:
sentry:
  tracing:
    enabled: false
    dbal:
      enabled: true
    twig:
      enabled: true

In this way, simply by doing
sentry:
  tracing:
    enabled: true

all the instrumentation would be ready to go.
Right now this sentry.tracing.enabled options is missing, and IMHO we can't enable all this stuff with that option present and defaulted to false.

In various places we make sure we do as little as possible when there is no current span set:

We do the same here

The few bits and bobs we do register (although tracing might be disabled or sampled out) are very lean and add little to no overhead to the request

That's what I was saying: I have honestly no clue (I didn't profile a sample app) about how much performance loss people will have with the tracing features enabled, I expect at least a small bit because of more things running and more abstractions (mainly in the DBAL) but it could very well be unnoticeable, considering that PHP itself is not the best language when talking about performances 😃

The reason I asked for a change like this is because if the user enables tracing all "integrations" (DBAL, HTTP requests etc.) should be enabled by default

I think we all agree that this makes totally sense

Right now this sentry.tracing.enabled options is missing, and IMHO we can't enable all this stuff with that option present and defaulted to false

It doesn't make any sense to add one more option to control if tracing is enabled or not because by definition it is enabled as soon as traces_sample_rate is a value greater than 0. This is why there isn't another global switch 😅 If we want to introduce a flag specifically for that, people will have to handle two options to enable the tracing which I'm pretty sure is not something that we want. But as I tried to explain, since this kind of configuration is likely to be tuned using environment variables, we cannot know at compile time what the value will be, so we have to register all services and enable all of them, and then just do nothing when they run if at runtime we see that tracing is disabled. How it's done right now will also make it possible to enable tracing on the fly, which would not if no service was instantiated. Of course, if people decide that they want to disable a certain instrumentation, then they cannot complain to have it working should they enable tracing later at runtime
TL;DR: it's working like in Laravel: all services are registered in the DI container by default, but they are basically noop if tracing is disabled. Still, they are there so there may be some performance hit in some critical paths like the connection of Doctrine

But there's a profound difference between how Laravel handles this noops and how we're doing it, as @stayallive correctly pointed out:

[...] in Laravel we register with the container (just registering classes no actual newing classes) [...]

In Symfony instead we have a compiled DI container, so we're injecting at least 3 listeners and a decoration of the DB connections just out the door, without the user asking for it. That's why I think it is necessary to add a switch on top of the traces_sample_rate: I want to be able to remove all those injected services because I don't want them!
Profiling has a non negligible impact on performance because it lies in all the hot paths of the applications, and I don't want this bundle to be blamed for slowing down the user's app. Profiling is an optional feature of Sentry, I don't expect our userbase to use it in more than 10% of their time, so I'm still :-1: and for adding the sentry.tracing.enabled main switch.
If you think that having two settings is wrong, we could make the configuration bail if no traces_sample_rate (even with 0) is set when sentry.tracing.enabled is set to true, so we could guide the user in the best possible way.

I absolutely agree with you, but I can already see users setting sample_traces_rate to a value greater than 0 and then complaining because it doesn't work just because they didn't set sentry.tracing.enabled to true. Keeping in sync the two options would be even more complicated, and in reality we have the same exact problem of environment variables with the latter. As I assume that users will probably want to decide at runtime if tracing must be enabled, if we don't register the services it will not work

Can't you just add the tracing option and not have it in the template supplied to the users?
This way you can easily set tracing.enabled = false but you don't have to remember to turn it on?
This way you can completely disable tracing but have the default being it enabled. In Laravel we have a seperate "service provider" you can de-register to completely remove all Tracing bindings, if that is not an EZ option in Symfony having a "hidden" (but documented) option is maybe a good compromise?

@stayallive so you mean putting sentry.tracing.enabled by default to true, so it's useful only in the case of wanting to strip everything? That could be an interesting solution...

Yeah, you can then "disable" (more de-activate) tracing by setting traces_sample_rate to 0.0 or return 0.0 from traces_sampler and if you really don't want any of it running in your app you can set sentry.tracing_enabled (or maybe even sentry.tracing_activated or tracing_loaded) which defaults to true to completely strip any tracing code from being initialized/registered or whatever.
This sounds like it could be a nice middle ground to allow removing tracing code if you really wanted?

This way you can easily set tracing.enabled = false but you don't have to remember to turn it on?

If we want to go this way, we have to mention in the docs will be that this bundle is gonna hook the instrumentation things by default and so it's likely that there will be a performance penalty right after the installation: if people are not interested to this feature, it's better to set the sentry.tracing.enabled option to false as first thing

Yes, but I don't mind it: if we already have the solution ready, we can point anyone to that easy fix, and be blameless.
I would preferred not turning it on by default, but I can understand Sentry wanting to make the feature adoption smoother.

Superseded by #467


30 seconds instead of 0.5 minutes

As demonstrated here: http://jsfiddle.net/o3fkjtfL/
The humanize for 30*1000 milliseconds is 0.5 minutes. It looks strange. Especially since the output is, on an incremental counter:
...
27 seconds
28 seconds
29 seconds
0.5 minutes
31 seconds
32 seconds
33 seconds
...

I'm going to remove this in version 3.0.0.


Not entirely preventing body scroll on iOS 12.x

Even with the provided demo, one can still scroll the body in iOS 12 if you touch at the bottom of the page when the browser controls are hidden.
To be absolutely clear, when you first load the demo (as with any page on iOS) the browser address bar at the top and the controls down at the bottom are visible.  If you proceed to press the "Disable Body Scroll" button with the browser controls still visible then everything appears to work correctly (you can scroll within the target element but not the body).
However, if you first scroll the body enough so that Mobile Safari hides the controls at the bottom of the page and then press the "Disable Body Scroll" button you can scroll the body if you start touching at the bottom of the page.  It would seem that some different touch behavior occurs where the hidden browser controls would normally be shown.  This is a serious bug.  Not sure if the bug is in your library or in Webkit/iOS, but I'd be interested to hear feedback from others.
Again, this faulty behavior shows up even with the provided demo at https://bodyscrolllock.now.sh.

I’m having exactly the same issue.

:+1:

Same problem

Same here !

The same problem.... there is no need to use this package if it doesn't work for ios(safari)

It remains to be seen if it will affect this specific issue, but it looks like a patch just landed in webkit that fixes the longstanding problematic behavior where the body is still scrollable with overflow: hidden.  If I'm reading this right then any browsers using webkit (including mobile Safari) will finally work the same as all the other major browsers.  However, I don't know how long it typically takes for a change in webkit source to land in an iOS release.

Found the issue why it is not working in 12.*, there is an issue with declaring the event listener form within a event listener. If you first declare the listener and use a flag in the other function to indicate if it should prevent the event, it should work.
See the following link for more information.
Also a small note for ios it is only working for me if i attach the event listener to the window instead of the document.

@babobski I'm not sure I follow what you are saying.  Maybe you have a related issue, but this bug occurs even if body-scroll-lock is used without any other event listeners.  And looking at the code of body-scroll-lock there is never an event listener declared within an event listener.
Can you clarify what you are stating?  Have you been able to modify the body-scroll-lock code so that the demo code does not exhibit this issue?

To be more clear about the issue I ran in to.
Today I had the request to make it work, when you slide in a Owl Carousel, that the page could not be scrolled vertically. After some tries of my one, I could not make it work on a iPhone.
If I set a overflow hidden on the body I was still able to scroll on a iPhone, it was driving me mad.
So after some searching, I landed at you're plugin.
It was almost working for me, only the first time I was still able to scroll the body on the iPhone, but on a older iPad it was working correctly.
Did some more searching so I landed at this issue and after some more at the other I linked to.
To make the idea work I used you're plugin in the onDrag event to block the body scroll and removed it on the onDragged event. It was working everywhere but not on the latest iPhone.
In the issue I linked, there is a link to a bug that event.preventDefault is not working in a nested event listener as in my situation in combination with the owlCarousel.
The prevent default at this line was not working correctly for me. I ended not up not using you're plugin only a small bit of it to see if passive events are supported.
I'm currently not at work, but ended up using a solution something like this (id not tested the code below):
var isBlocked = false;

var hasPassiveEvents = false;
if (typeof window !== 'undefined') {
    var passiveTestOptions = {
        get passive() {
            hasPassiveEvents = true;
            return undefined;
        }
    };
    window.addEventListener('testPassive', null, passiveTestOptions);
    window.removeEventListener('testPassive', null, passiveTestOptions);
}

document.addEventListener('touchmove', function(e) {
    if (isBlocked) {
        e.preventDefault();
    }
}, hasPassiveEvents ? {
    passive: false
} : undefined);

$(document).ready(function() {
    $(".owl-carousel").owlCarousel({
        onDrag: function() {
            isBlocked = true;
        },
        onDragged: function() {
            isBlocked = false;
        }
    });
});


Test and fix reference leak causing test_float to fail

The failure can be narrowed down to this example:
    def test_fast_overload(self):
        a = "12345"

        def x(a):
            a = a[1:]
        before = sys.getrefcount(a)
        x(a)
        self.assertEqual(before, sys.getrefcount(a))

The failure can be narrowed down to this example:
    def test_fast_overload(self):
        a = "12345"

        def x(a):
            a = a[1:]
        before = sys.getrefcount(a)
        x(a)
        self.assertEqual(before, sys.getrefcount(a))

This also fails:
    def test_fast_overload(self):
        a = "12345"

        def x(a):
            a += a
        before = sys.getrefcount(a)
        x(a)
        self.assertEqual(before, sys.getrefcount(a))

This also fails:
    def test_fast_overload(self):
        a = "12345"

        def x(a):
            a += a
        before = sys.getrefcount(a)
        x(a)
        self.assertEqual(before, sys.getrefcount(a))

The root cause of this is the inline locals optimization. With this disabled, all of the smoke tests pass (which is a first)

The root cause of this is the inline locals optimization. With this disabled, all of the smoke tests pass (which is a first)

@tetsuo-cpp I think this is the root of many of the crashes. This PR doesn't fix the issue, it just disabled the optimisation that caused it. But if you update to 0.7.0 things should be running pretty smoothly now

@tetsuo-cpp I think this is the root of many of the crashes. This PR doesn't fix the issue, it just disabled the optimisation that caused it. But if you update to 0.7.0 things should be running pretty smoothly now


Baseqnode construct fix

Context:
Attempts to fix the recent regression in QNode behavior re: mutable circuits, while retaining the full circuit drawer functionality.
Description of the Change:

Changes the logic in BaseQNode._construct and BaseQNode._make_variables.
Adds tests for the formerly failing cases.
Docstring updates.

Benefits:

Seems to solve the current issues with mutable circuits.

Possible Drawbacks:
Related GitHub Issues:
Eventually should fix https://github.com/XanaduAI/pennylane/issues/507, https://github.com/XanaduAI/qml/issues/36, and replace the regression fix #505

Thanks @smite. Is this PR making the work in #505 by @antalszava obsolete? If so, it would be a nice courtesy to let us know you want to tackle it in advance, so we can avoid duplicate effort.

Thanks @smite. Is this PR making the work in #505 by @antalszava obsolete? If so, it would be a nice courtesy to let us know you want to tackle it in advance, so we can avoid duplicate effort.

I wasn't sure how long it would take to get this working (it still isn't 100% done but at least the solution seems to satisfy all the tests), #505 is a quick regression fix.

What's the status of this PR?

[ch323]

This PR has become somewhat stale, and out of date with other changes and refactors that have occurred. As the current QNode + Variable system is marked for potential deprecation, I'm closing it for now.


raft doc improvement

some feedback

My only feedback is I wonder if it would be worth including a few lines at the start explaining what a censensus protocol is, what kind of problems it solves, and what it can be used to build. I guess it all depends on what type of person arrives at the page - someone who knows what it is all about and needs an implementation, or someone who just heard about something called etcd's Raft and that it is "cool".

Another feedback I got is that we should document how to do reconfiguration. It is not super clear right now.

I started writing a didatic blog post about Raft in my language (Portuguese).
I would be happy translate it to english and send a pull request

@vmattos About etcd/raft? Or about raft in general?

About raft in general, for folks who don't want to read the whole paper

@vmattos I would love to help on the blog post. But we are talking about etcd's raft implementation here.

I think https://github.com/coreos/rkt/blob/master/Documentation/devel/architecture.md is a good example.  I am interested in this as well. Where would be the good place to put this? Documentation/dev? Thanks!

I have been learning raft and etcd keeping logs in my personal repository.
https://github.com/gyuho/learn/tree/master/doc/etcd_architecture


Set mail get mail updates

new types introdues following jmap specification (https://jmap.io/spec.html):

IEmailSetProperties
IEmailSetResponse
ISetArguments
IGetEmailArguments

Add method for Email/set in the client

Thanks for this pull request
can you remove package-lock.json in your commit or add a .gitignore if not already added

Thanks for this pull request
can you remove package-lock.json in your commit or add a .gitignore if not already added

I think ignoring or deleting the package-lock.json is a bad idea.
You can also read this readme for Angular that can help understand how it can be useful (yarn.lock is like package-lock.json but for yarn instead of npm) https://github.com/angular/angular/blob/master/yarn.lock.readme.md

I think it depends on project type. what works for project maintainers/ CI systems might not work when the project is used as a dependency.
https://github.com/npm/npm/issues/20603

I think it depends on project type. what works for project maintainers/ CI systems might not work when the project is used as a dependency.
npm/npm#20603

This one really convinced me. Anyway we can remove it in a separate pull request since it was already present.


How to test a resource protected with @Auth?

From the documentation it's unclear how to by pass the authentication. What I read here doesn't work because the methods used are simply not there (e.g: client.addFilter(new HTTPBasicAuthFilter(“user”, “secret")); - seems to be from jersey). If I can make this work I would update the documentation to make it easier for others to do testing.
Here is my class rule
@ClassRule
	public static final ResourceTestRule resources = ResourceTestRule
			.builder()
			.addProvider(
					AuthFactory.binder(new BasicAuthFactory<User>(
							new TokenAuthenticator(userDAO),
							"SUPER SECRET STUFF", User.class)))
			.addResource(new ShopResource(shopDAO, userDAO)).build();

where TokenAuthenticator is a derivation of a username/password scheme. I want to basically have the username:password send to BasicAuthentication to the specified realm. However when I send my request
Builder builder = resources
				.client()
				.register(
						HttpAuthenticationFeature
<EMAIL_ADDRESS>"test"))
				.target(R.URL_SHOPS).request();
		Response response = builder.post(Entity.json(shop));
		System.out.println(response.getStringHeaders());

my authenticator simple doesn't get called at all.
For more details, here is my token validator
public class TokenAuthenticator implements
		Authenticator<BasicCredentials, User> {
	UserDAO userDAO;

	public TokenAuthenticator(UserDAO userDAO) {
		super();
		this.userDAO = userDAO;
	}

	/**
	 * Need to send in email:auth_token
	 */
	@Override
	public Optional<User> authenticate(BasicCredentials credentials)
			throws AuthenticationException {
		Optional<User> userOptional = userDAO.findByEmail(credentials
				.getUsername());
		if (!userOptional.isPresent()
				|| userOptional.get().getAuthToken() != credentials
						.getPassword())
			return Optional.absent();
		return userOptional;
	}

}

and here is my resource
	@POST
	public Response create(@Auth User user, Shop shop) {
		if (shopDAO.findByName(shop.getName()).isPresent()) {
			return Response.status(Status.NOT_ACCEPTABLE).entity("Name existed").build();
		}

		if (!userDAO.findById(shop.getUserId()).isPresent()) {
			return Response.status(Status.NOT_FOUND).entity("User id not found").build();
		}

		long shopId = shopDAO.create(shop);
		return Response.status(Status.CREATED).entity(shopId).build();
	}

can anybody take a look?

Please don't open issues to ask questions. Use the mailing the list.
With that said, there are tests that use the authentication. See this:
https://github.com/dropwizard/dropwizard/blob/master/dropwizard-auth/src/test/java/io/dropwizard/auth/basic/BasicAuthProviderTest.java

@carlo-rtr thank you for your pointer, but it's still not clear how to do it properly. I created a discussion here and it turns out I'm not the only one with this problem. I'm surprised the documentation doesn't mention anything about this matter, at all.


[BUG] - HTTPS Self Links Broken for Ports Other than 443

When using HTTPS with a port other than 443, the self links returned remain HTTP.
Please see: https://github.com/zendframework/zend-view/blob/master/src/Helper/ServerUrl.php#L149
There are plenty of use cases where people will use ports other than 443 for their HTTPS needs. I believe this needs to be refactored to be less strict.
I'm happy to make the PR contribution, but I wanted to submit the issue first to make sure this doesn't break some standard.

:+1: for a PR for this!

Great. I'll work on doing that within the next two days. I have some other tasks in queue.

This repository has been closed and moved to laminas/laminas-view; a new issue has been opened at https://github.com/laminas/laminas-view/issues/3.


Product/Variant images 60x60 not loading in cart and checkout

What I'm trying to achieve
Show variant/product image in cart and checkout
Steps to reproduce the problem

Add image to your product and set it to variant as well
Go to storefront and add product to cart
Image in cart doesn't load, only shows placeholder 60x60

Stacktrace:
Traceback (most recent call last):
  File "....\saleor\product\templatetags\product_images.py", line 90, in get_thumbnail
    thumbnail = getattr(image_file, method)[used_size]
AttributeError: 'ProductImage' object has no attribute 'thumbnail'
ERROR saleor.product.templatetags.product_images Thumbnail fetch failed [PID:14208:Thread-4]

What I expected to happen
Should show variant image
Screenshots
Checkout

Cart

System information
Operating system:
Browser: Windows 10, Linux, Mac

Is this resolved? From the traceback it looks like some recent changes  with the get_thumbnail function broke something

Its resolved. Seems to be due to some merging conflicts.


Modify tt_tensors_to_torch_tensors utility function to untilize on device instead of cpu

Modify tt_tensors_to_torch_tensors utility function to untilize on device instead of cpu
Modify Falcon7b perf test to use tt_tensors_to_torch_tensors instead of tt2torch_tensor
Improvements in single-chip e2e performance for Falcon7b demo (perf mode): +13% for prefill, +4% for decode
Improvements in multi-chip (8 chips) e2e performance for Falcon7b demo (perf mode): +45% for prefill, +12% for decode

Post-commit models tests: https://github.com/tenstorrent/tt-metal/actions/runs/9024337178
Single-chip perf tests: https://github.com/tenstorrent/tt-metal/actions/runs/9024314252
Multi-chip perf tests: https://github.com/tenstorrent/tt-metal/actions/runs/9024320349

@cglagovichTT Would you be able to check if this change works for llama2 and yields any e2e improvement since tt_tensors_to_torch_tensors is used in llama_generation.py?

great!

I'm experimenting with multidevice tensors so my llama_generation.py now uses this pattern
        logits = ttnn.to_torch(
            tt_logits, device=self.device_mesh, mesh_composer=ConcatMeshToTensor(self.device_mesh, dim=3)
        )

Maybe I can explicitly untilize before composing?


Create stripd version of shared library during build

What does this PR do?
Changes ffi-build.sh to create two versions of the shared library: one that has been stripd, and another which hasn't.
Motivation
By having the build generate both a stripd and an unstrip'd version of the shared library, we make it easier to package a stripd libddprof without needing access to all architectures and OS's used to build the binaries.
In particular for Ruby, it allows the Ruby packaging process to be just a straightforward unpacking + uploading to rubygems.org, without any kind of changes to the libddprof files.
It also makes it easier to validate the resulting libddprof distribution: it should match the exact files present in the release page on GitHub.
Finally, there was a bit of discussion if we should ship both stripd and unstrip'd, or only ship the stripd version but I like having both since it makes it easy to package a version with full debug info if we need to investigate an issue. (Totally open to switching to the other option)
How to test the change?
Exercise the stripd version of libddprof shared library by linking to, and using it.

Why does Ruby need a stripped and unstripped version? I don't understand.

As @sanchda pointed out, it's kinda weird but even on elf systems the strip seems to be platform-specific. The amd64 strip from Ubuntu refuses to strip the arm64 binary.

Another idea is to ship split debuginfo, which would be my personal preference, but I won't claim to have a strong position on that preference.

This is a very good point. I'll look into it, and possibly create a PR with it so we can evaluate which option we prefer.

Maybe we can approve this and also approve a move away from alpine/glibc-tagged builds? :)

One can dream ;D

Why does Ruby need a stripped and unstripped version? I don't understand.

You're right, it doesn't!
My thinking is that shipping both in the release tarball enables us to easily switch between the stripd version and  one with debug info without needing to reproduce the build for a given/specific libddprof version. Otherwise, we may risk one of those "once I rebuilt it, the issue went away" issues.
Of course, the Ruby packaging would only include one or the other. I'm thinking if a customer runs into an issue, I can just repackage the version with debug info and ask them to switch.
I agree it's a heavy-handed approach. I'll look into David's suggestion of splitting the debuginfo instead and report back :)

Replaced with #29, closing!


Not clear exception message

Having next configuration:
            <plugin>
                <groupId>org.jolokia</groupId>
                <artifactId>docker-maven-plugin</artifactId>
                <version>0.13.6</version>

                <configuration>
                    <skip>${skip-integration-test-data-creation}</skip>
                    <images>
                        <image>
                            <external>
                                <type>compose</type>
                                <config>${basedir}/src/test/docker/docker-compose.yml</config>
                            </external>
                            <run>
                                <wait>
                                    <log>Started XXX</log>
                                    <time>250000</time>
                                </wait>
                            </run>
                        </image>
                    </images>
                </configuration>

                <executions>
                    <execution>
                        <id>start</id>
                        <phase>pre-integration-test</phase>
                        <goals>
                            <goal>stop</goal>
                            <goal>build</goal>
                            <goal>start</goal>
                        </goals>
                    </execution>
                    <execution>
                        <id>stop</id>
                        <phase>post-integration-test</phase>
                        <goals>
                            <goal>stop</goal>
                        </goals>
                    </execution>
                </executions>
            </plugin>

Getting the next exception message:
Failed to execute goal org.jolokia:docker-maven-plugin:0.13.6:stop (start) on project integration-test: Execution start of goal org.jolokia:docker-maven-plugin:0.13.6:stop failed: [null] : No handler for type compose given -> [Help 1]

Sry,
Seems I missed that the feature is not completed yet.
Very sad.

can you provide me w/ the docker-compose.yml file you are using above, or something that is more or less equivalent?

i'm actually going to close this as a dup of #57 so could you please post the compose file over there?


Update check_refusal_utils.py for completions only

Pull Request: Fix for check_refusal_completions Error
Description
When check_refusal_completions is used on completions only, the function throws an error due to the uninitialized variable fixed_generation_batch_size.
Error Details
File "/lustre/home/apanfilov/jailbreak_filter/baseline-defense-ppl/baselines/check_refusal_utils.py", line 58, in check_refusal_completions
    return is_refusal, completions, fixed_generation_batch_size
UnboundLocalError: local variable 'fixed_generation_batch_size' referenced before assignment

Thanks for the catch!


Better documentation on how to rename a field

Passing a :name option to field or association will rename the field. This feature exists, but it should be better documented. This stems from #87

resolved by #89


Adap the code to PSR-2

We have to set the coding standard of psr-2:
https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md
And add the correct rules to our sniffer.

I've just tried a little bit php-cs-fixer. Looks promising but:

I still don't see a way to warn me to skip using underscores on private properties. But this is not so much important because I do not tend to use them.
I don't see a way to warn me to put docblocks on my source code. PSR-2 do not specifies this as it says on its conclusion (https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md#7-conclusion), but I really believe it is important.

I think we may switch from phpcs to php-cs-fixer but we must find a way to ask us to put docblocks ( and maybe more things ) and block all pull requests if the code do not follow this guidelines.
Probably we need to research a little bit more.

Right now changes following PSR-2 can be viewed here: https://github.com/repejota/phpnats/compare/feature/php-cs-fixer

This can help a lot:
http://stackoverflow.com/questions/13767550/is-there-a-phpcs-standard-targeting-php-docblocks
Totally thinking on using a mix between php-cs-fixer and php-code-sniffer :smile:

After a few tests, i'm not gonna use potencier's fixer. I will continue using php code sniffer using the PS2 standard.

It has better support for PSR2
It shows also errors about docblocks
It is all installable throught composer


Rendering child views fails

I have not found a way of passing a view to a template and rendering it using the {{view childViewName}} helper. In fact I'm quite sure that somehow helpers are broken for me (?) as I get the same error whenever I try to use other kinds of helpers (e.g. {{collection someCollection}})
The error:
Uncaught TypeError: Cannot read property '_helperName' of undefined
StackOverflow to reproduce

With the version that is referenced in this generator, this bug has not been fixed like it has been in the Thorax library. Please see https://github.com/walmartlabs/generator-thorax/pull/149 for some more info. You can do this in Thorax proper (especially in IE11) but the fix has not been pulled downstream to this project @ChadMartinson


NIFI-2963 FetchHDFS should support Compression Codec property

Reviewing. . .

duh... I must admit I did copy/paste the logic from the GetHDFS processor and didn't catch the loop over files in the GetHDFS processor. Anyway, this should now make much more sense. Thanks for catching that Oleg!

@pvillard31 much cleaner, thx. merging.


Missing the most obvious instructions for Bookings with me!

The current Bookings with me information page is completely missing the most obvious instructions for setting up Bookings with me.  It does not tell us how users can create a Bookings with me page!
I followed the instructions on the page and it looks like you have to enable Bookings with me using Powershell.  So I went through the process of connecting to Powershell, and learning that whole process ... only to run the commands and find that it was already enabled! So frustrating.
Nowhere on the page does it tell us how to create a Bookings with me page.
I Googled for more answers and found a YouTube video that explained it:

Go to Outlook online
Click on your calendar
Click "Create bookings page"

If these instructions were added to this Bookings with me page, it would have saved me a lot of time, and I'm sure would be helpful for many other users too.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7bad8864-5f08-90ae-a6d1-a23e58fc1843
Version Independent ID: 7bad8864-5f08-90ae-a6d1-a23e58fc1843
Content: Bookings with me
Content Source: microsoft-365/bookings/bookings-in-outlook.md
Service: bookings
GitHub Login: @kwekuako
Microsoft Alias: kwekua

@jodamo5 Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/9690
Once the author approves the changes will be live.
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @jodamo5 Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


UnicodeDecodeError: 'utf-8' codec can't decode byte 0xba in position 109

What happened?
When I try to add k3s>extraArgs># with arg: --bind-address I get:
[DEBUG] Traceback (most recent call last):
  File "getdeck.provider.utility_provider", line 102, in _create
  File "getdeck.utils", line 131, in _execute
  File "codecs", line 322, in decode
    (result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xba in position 109: invalid start byte

Traceback (most recent call last):
  File "getdeck.__main__", line 175, in main
  File "getdeck.api.utils", line 10, in wrapper
  File "getdeck.api.get", line 50, in run_deck
  File "getdeck.provider.k3d", line 64, in create
  File "getdeck.provider.utility_provider", line 116, in _create
  File "getdeck.provider.utility_provider", line 102, in _create
  File "getdeck.utils", line 131, in _execute
  File "codecs", line 322, in decode
    (result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xba in position 109: invalid start byte
[CRITICAL] There was an error running deck: 'utf-8' codec can't decode byte 0xba in position 109: invalid start byte

I thought it was something in my file but that doesn't look to be so.
What did you expect to happen?
It passes the command without error.
How can we reproduce it (as minimally and precisely as possible)?
cluster:
  provider: k3d
  minVersion: 4.0.0
  nativeConfig:
    apiVersion: k3d.io/v1alpha4
    kind: Simple
    servers: 1
    options:
      k3s:
        extraArgs:
          - arg: --bind-address=some ip
            nodeFilters:
            - server:*

What is the content of the Deckfile you are using?
cluster:
provider: k3d
minVersion: 4.0.0
nativeConfig:
apiVersion: k3d.io/v1alpha4
kind: Simple
servers: 1
options:
k3s:
extraArgs:
- arg: --bind-address=some ip possibly an invalid one
nodeFilters:
- server:*
OS version
NAME=Slackware
VERSION="15.0"
ID=slackware
VERSION_ID=15.0
PRETTY_NAME="Slackware 15.0 x86_64 (post 15.0 -current)"
ANSI_COLOR="0;34"
CPE_NAME="cpe:/o:slackware:slackware_linux:15.0"
HOME_URL="http://slackware.com/"
SUPPORT_URL="http://www.linuxquestions.org/questions/slackware-14/"
BUG_REPORT_URL="http://www.linuxquestions.org/questions/slackware-14/"
VERSION_CODENAME=current
Anything else we need to know?
I am still trying to see if it's something wrong with my input. My goal is to set the IP to be different then the host IP but on the same subnet. I think it's quite possible that the error is just not being caught and crashing here, something like the IP I set is wrong but that output is getting lost.

I wonder how you managed to bypass the Deckfile validation for the cluster.name attribute. That is missing in your Deckfile.
When running your Deckfile with a recent version of deck I see the following error:
> deck get deck.yaml
[INFO] Reading Deckfile: deck.yaml
[CRITICAL] There was an error running deck: 1 validation error for Deckfile_1_0
cluster -> name
  field required (type=value_error.missing)

@buschNT any idea?

@buschNT any idea?

@Schille No, currently not. It should always throw the validation error from above when the cluster name is missing.

The UnicodeDecodeError is raised by the following part in the code:
            if print_output:
                for stdout_line in iter(process.stdout.readline, ""):
                    print(stdout_line, end="", flush=True)

This is "only" some output printing which is coupled to the logging.DEBUG level (print_output=True if logger.level == logging.DEBUG else False,). @Z02X I guess you used the "-d" flag when running the get command. Maybe it works without the debug output? Nevertheless, even without knowing the exact cause of the UnicodeDecodeError, this part of the code should not raise an error.

@Schille #112 this is a small fix which should prevent getdeck from crashing at this point.

I wonder how you managed to bypass the Deckfile validation for the cluster.name attribute. It is missing in your Deckfile.
When running your Deckfile with a recent version of deck I see the following error:
> deck get deck.yaml
[INFO] Reading Deckfile: deck.yaml
[CRITICAL] There was an error running deck: 1 validation error for Deckfile_1_0
cluster -> name
  field required (type=value_error.missing)

@buschNT any idea?

Sorry I think I cut down the deck file a little to much. I will run a test on a less striped down one.

The fix https://github.com/Getdeck/getdeck/pull/112 got me to a state where I can see what's going on now instead of crashing so I consider this fixed.


[activation] Derivative for activation

The derivative of softmax has been handcrafted to be different from others
Refer to https://github.com/nnstreamer/nntrainer/blob/2a650512813db6ce3bba828b5790066fbc655f14/nntrainer/src/fc_layer.cpp#L265 for the original implementation
Softmax requires softmax(x) as input for derivative while other activations require x as input for derivative
Signed-off-by: Parichay Kapoor<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.4.20191203. Thank you for submitting PR #223. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

@zhoonit Please verify once.


[stable/consul] readme does not match values.yaml

README.md does not match values.yaml
values.yaml as of Aug 18th offers
    Gossip:
      Encrypt: true
      Create: true
    GossipKey: key

But README.md of Aug 18th describes

Parameter
Description
Default

EncryptGossip
Whether or not gossip is encrypted
true

GossipKey
Gossip-key to use by all members
nil

Version of Helm and Kubernetes:
irrelevant
Which chart:
stable/consul
What happened:
README.md does not match values.yaml
What you expected to happen:
README.md matches values.yaml
How to reproduce it (as minimally and precisely as possible):
Read README.md, then read values.yaml

I thought I could infer the meaning from just reading values.yaml, but turns out there is ambiguity that needs to be spelled out in the README.md -- I was stymied because it looked like .Gossip.Create meant "helm will create a random value for you" but reading consul/templates/gossip-secret.yaml I can see .Gossip.Create means it will create the resource of kind "Secret" named {{template "consul.fullname" . }}-gossip-key in the cluster for you.
Since the template above can only be derived by running the helm chart, I struggle to see when someone would correctly guess what that Secret's name could possibly be if they intentionally set "Gossip.Create: false"

Should also mention that GossipKey must be the base64 decoded version of what usually goes into the "encrypt" config setting for consul's *.json config files.

GossipKey variable wanting the b64decoded value is super odd imo. Should expect the value as would be output by consul keygen.

Do I have to make nonsense comments on this issue to keep it from going "stale"?

Thanks for your patience. Readme has been updated to reflect values.yaml


[WIP] Exclude files matching pattern listed in .clang-format-ignore

Closes #427
TODO: Update make rule

Codecov Report

Merging #428 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #428      +/-   ##
==========================================
+ Coverage   96.55%   96.56%   +<.01%
==========================================
  Files         109      109
  Lines        7877     7878       +1
==========================================
+ Hits         7606     7607       +1
  Misses        271      271

Impacted Files
Coverage Δ

...es/Search/src/details/DTK_DetailsTreeTraversal.hpp
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26c8293...23e26ce. Read the comment docs.


Make GetSuperfluidLockByLockId more cleary indicate if its found or not

Followup to #5831 , make the API more clearly indicate the problem of this needs to return found.
I do think later on we may just want to make !found => error, but that would be state breaking.
So for now making the API add found, and marking TODO's for us to clean up in a follow-up state breaking update.
Please verify that all queries adjusted are not in the stargate whitelist.

Merging for now, going to check state machine compat


Client instantiation loses (default) config options

PHP version: 8.0.14
Description
When using the Client it happened that I got a 301 redirect response. So not the response from the uri where it redirected to but an actual response object with status code 301. The guzzle default should be to allow and automatically follow redirects and it also did then when I tried with guzzle directly.
I then also tried the createWithConfig() static method of the Client and explicitly gave it the config (allow_redirects as in the docs), but with the same outcome.
How to reproduce
Make a Client and request a uri that redirects to somewhere else.
Possible Solution
The private static buildClient() method creates a handler stack and passes it along with the config over to the new guzzle client. When the guzzle client doesn't get a handler stack it creates one by calling HandlerStack::create(). I think the buildClient() method should either use this method or even better, just don't create a handler stack itself but just leave this to guzzle itself?
I'll prepare a PR for this.

🤔 OK, the tests from https://github.com/php-http/client-integration-tests expect a request that gets a 30x response to actually get that response, which makes sense when you don't assume any default configuration of the underlying client.
But as this is a guzzle adapter, I'd expect it to have the guzzle defaults.
If it shouldn't use the guzzle defaults, there's still the problem that also explicitly passing a config doesn't work.

Also just found that the implementation of PSR-18 sendRequest method in the guzzle client itself (https://github.com/guzzle/guzzle/blob/master/src/Client.php#L134) sets allow_redirects to false in any case, so is it actually not possible/allowed to automatically follow redirects with a PSR-18 client?
Somehow it makes sense to me, as the PSR-7 response object doesn't have any option to get what uri was actually delivered (or also redirect steps in between). I just wondered as I previously didn't really find anything about redirects in the PSR-18 document. Just found something in the Meta document. I guess it just presumes that not automatically following redirects is standard.
So does that mean, that every library supporting a PSR-18 http client has to implement redirects themselves?

i just re-read our PSR-18, and notice that redirects are not explicitly mentioned. when we wrote the PSR, the intention was that the PSR-18 compliant client does not follow redirects (*). The important thing is that all clients behave the same way, otherwise you can't replace one client with another. Therefore it is by design that the guzzle adapter aims to have that behaviour.
If you want to use PSR-18 and decided that you don't need to know about redirects: wrap the client in a plugin client and use the redirect plugin - that will then work with all clients, should you chose to switch from guzzle to something else.
If you want to only use guzzle and have your application rely on guzzle behaviour, i would recommend to use it directly and not use the PSR-18 abstraction.
I was not aware that guzzle client overwrites the options. I find that a bit unfortunate, because as you say, it makes createWithConfig do unexpected things. To me, the PSR-18 meta implies that it should be possible to configure a client to "misbehave" according to the spec:

It is temping to allow configuration or add middleware to an HTTP client so it could i.e. follow redirects or throw exceptions. If that is a decision from an application developer, they have specifically said they want to break the specification. That is an issue (or feature) the application developer should handle. Third party libraries MUST NOT assume that a HTTP client breaks the specification.

But this is in the guzzle repository, you would have to take that up with the maintainers there. (and changing it right away would not be possible as it would be quite the BC break)
(*) Why not follow redirects: If you write an API client, you at least want to log a warning, or in test systems probably throw an error when getting redirected, because the overhead of doing every API call twice would be really bad.

Thank you for the detailed answer!
I understand that it totally makes sense to not automatically follow redirects 👍🏻 and actually I need to know about the redirects in my use case, so I just implemented handling redirects manually because I still want to support using different PSR-18 client implementations.

I was not aware that guzzle client overwrites the options. I find that a bit unfortunate, because as you say, it makes createWithConfig do unexpected things.

I think only guzzle's own PSR-18 implementation, the sendRequest method in the guzzle client itself resets some configs. The sendAsync method this package uses, doesn't I think. I think the reason passing configs to createWithConfig doesn't work is, that the private buildClient method passes a handler stack with only the prepare_body middleware to the guzzle client.
Maybe building the client should work differently when called via the createWithConfig method.

async

async is not part of PSR-18, so that makes sense. there is also the send method in the guzzle client that does not overwrite the options. sendRequest is the only PSR-18 method.
@Nyholm wdyt about adapter createWithConfig not working as would be expected because guzzles sendRequest overwrites the follow redirect option on the request?

The sendAsync method this package uses

With that i meant: both methods sendRequest and sendAsyncRequest from the Client implementation of this package in the end call guzzle's sendAsync method, which doesn't overrule client config as far as I can see. So no problem there.
As mentioned I think the problem is how the guzzle client is built when using createWithConfig.

ah, so createWithConfig works as expected, when you use this adapter?

No, if it should allow to make the client automatically redirect when providing the guzzle allow_redirect config.
This still returns a 301 response:

And as mentioned I think it's because of how the underlying guzzle client is created in the private buildClient method:

Because in guzzle it then looks like this:

and the HandlerStack create method:

So, as the adapter buildClient method provides the constructor with a handler only containing the prepare_body handler, it'll never add the redirect handler even if you provide the allow_redirect config.

we create the custom handler to not have the middlewares. would the correct overwriteable behaviour be to create the client without handler (so that the handler is autocreated as normal) but have default options for each default middleware to disable that middleware? is that how guzzle itself works when you would do new Client(['allow_redirects' => false])?

but just as default options, overwriteable in createWithConfig?

I'd say yes. At least I think that should work 👍🏻

@Nyholm do you have an opinion on this?
my thinking is that we should copy the HandlerStack::create method (to be sure changes in guzzle do not throw us off) and set all four middleware options to false by default, so that they can be overwritten in createWithConfig.


Added Wire Triggers and removed BIDIRARRAY uses

Wire Triggers are practically 3D Rangers. They output how many entities
are inside of them and an array of the entities inside. Players can
change the size, the offsets, and the conditions of these triggers.
However, I can't figure out how to rotate them with the receivers (that
output the trigger stuff), and believe me I've tried, so they're only
perpendicular to the world's axes.
BIDIRARRAY is only used in the 8x Table Duplexer and nowhere else. Not
only is it useless (at the moment), but it also takes out the usage of
using the duplexer with an ARRAY type.

@Divran in future can you please leave pull requests with new features open for discussion a bit longer before merging them?

I think "Wire Trigger" is a somewhat confusing name. Something like "Wire Trigger Volume" would make it clearer what this does.
This offers a large amount of feature overlap with target finders. Target finders have a lot of historical cruft and so I think it's good to move beyond it, but it seems that this does pretty much the job of a target finder but with a cuboid rather than a sphere.

@Divran in future can you please leave pull requests with new features open for discussion a bit longer before merging them?

Sorry, I promise to do that next time

sorry about all of those problems. especially the GLua syntax. it's a coding habit i have.

@mitterdoo There's no reason to use C-Style syntax in Lua. I've spoken to Garry about this, he won't remove them because it will 'break' all addons. @Divran Still needing to learn git etiquette eh? @AbigailBuccaneer Good job! You did a lot of extra work there to point out the problems for @Divran, very scrupulous.

@Divran Still needing to learn git etiquette eh?

well sometimes I just do stuff too quickly


UnrolledList -Wstringop-overflow

GDC (but not DMD or LDC) gives the following warning:
/home/james/.dub/packages/emsi_containers-0.8.0-alpha.13/emsi_containers/src/containers/unrolledlist.d: In function ‘mergeNodes’:
/home/james/.dub/packages/emsi_containers-0.8.0-alpha.13/emsi_containers/src/containers/unrolledlist.d:553:3: warning: ‘__builtin_memcpy’ reading 64 bytes from a region of size 32 [-Wstringop-overflow=]
   first.items[0 .. i] = temp[0 .. i];

(corresponds to line 557 in current version)
I instantiated the UnrolledList as:
new UnrolledList!(myType *);
That's about as far as I can go. HTH.

Does adding assert(i < nodeCapacity); before that line help?

GDC is currently in a bit of a rut, and supporting it is currently somewhat onerous. Let's reopen this when it becomes clear that this is still an actionable issue. Thanks!


enh: clarify file size limit on upload doc page

https://github.com/dust-tt/tasks/issues/208

A bit skeptical about the "copy paste content".
User can also just write something right?

This copy pre-dates this change


Fix 232 and 731

@henn, responded to your comments.

(also, I apparently forgot to push my fix for #731, so that's new as well).

This has two signoffs, megring.


Option for "Clear history on quit" to not store history on disk

Before Submitting Your Feature Request

[X] Check that there isn't already a similar feature request to avoid creating a duplicate.
[X] I have seen the FAQ.

Problem
Currently Maccy writes history to ~/Library/Containers/org.p0deje.Maccy/Data/Library/Application Support/Maccy/Storage.sqlite stores history when "Clear history on quit" is checkmarked.
Coming from KDE's Klipper, I assumed Maccy would only store history in memory with this option. I didn't really think twice about it until I noticed the wording and decided to double check
Solution
A sub-option for "Clear history on quit" that doesn't write history to disk

Thank you for the feedback! This is not something I had on my mind, can you please provide more details about why you'd want this added?
Even though it might be possible to implement this via Core Data, I'm not sure how practical this would be. There are already multiple issues related to memory bloat (#384, #726) and the desire to keep unlimited history (#310) so I wonder how this would complicate the implementation, supporting simultaneously both disk/memory storage backends.

can you please provide more details about why you'd want this added?

Short answer, because when I copy something sensitive into my clipboard I don't want to rely on checking if Maccy has been temporarily disabled

unlimited history

I'd think enabling it would be mutually exclusive with in-memory-only, but maybe not?

so I wonder how this would complicate the implementation, supporting simultaneously both disk/memory storage backends.

I think the most complicated thing would be migrating items between stores and exposing the "when" to users.
There's also the question of what to do about pinned items as there's merits to both persisting and not persisting them

I generally wouldn't mind supporting that so PRs are welcome, but I won't be able to implement this myself.

Is this implemented in v2. I see 2 options in Advanced settings:

Clear history on quit
Clear the system clipboard too


[question] how to set select2  to work with son data

Hi, how to set select2  to work with json data in format:
[{
"fields": {
"sku": "8"
},
"model": "catalog.product",
"pk": 8
},{
"fields": {
"sku": "9"
},
"model": "catalog.product",
"pk": 9
}]
I use the example https://select2.github.io/examples.html#data-ajax

You are going to need to re-map your results to have id and text keys.
https://select2.github.io/announcements-4.0.html#changed-id

This appears to be more of a usage question than a bug report or common feature request.  As we continue to keep the Select2 issue tracker geared towards these two areas, bug reports and common feature requests, we are redirecting usage questions to other communities such as the mailing list, IRC, or Stack Overflow.


build sets e in catch(e) to argument name

The current uglify job generates the following code:
_setOpacityIE:function(t,e){var i=!1,n="DXImageTransform.Microsoft.Alpha";try{i=t.filters.item(n)}catch(t){if(1===e)return}e=Math.round(100*e),i?(i.Enabled=100!==e,i.Opacity=e):t.style.filter+=" progid:"+n+"(opacity="+e+")"}
The catch(t) statement might not return (if value != 1), which changes the argument t to the caught error. I tried alternatives to catch(e) eg. catch(me), catch(you) catch(acold), but only testing for the error to have happened helps.
I get this error when I click on a cluster from the markercluster module.

Hhhmmm, I see. uglifyjs is overwriting the el parameter with the caught exception.
I'm partial to submitting a bug report upstream to uglify (or at the very least try updating the dependencies) before implementing a workaround.

Updating to uglify 2.8 doesn't help. I've tried to create a minimal case which makes uglify reuse variable names, with no avail. :-(

Fair point. I updated to:
├─┬<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ │ └──<EMAIL_ADDRESS>│ ├──<EMAIL_ADDRESS>│ ├──<EMAIL_ADDRESS>│ ├──<EMAIL_ADDRESS>│ └──<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>│ └──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>

The result is very similar:
function yt(t, i) {   var e = !1,     n = "DXImageTransform.Microsoft.Alpha";   try {     e = t.filters.item(n)   } catch (t) {     if (1 === i)       return   }   i = Math.round(100 * i), e ? (e.Enabled = 100 !== i, e.Opacity = i) : "Error" === !t.name && (t.style.filter +=     " progid:" + n + "(opacity=" + i + ")") }

@batje
Is it reproducible with current Leaflet?
I cannot find _setOpacityIE in uglified code anymore.

I would say that if you can't find _setOpacityIE anymore, this issue has become irrelevant.


[testing] noop whitespace change to CHANGELOG.md

Thank You!
Your contribution to the DSO Repo1 has been mirrored to https://repo1.dso.mil/big-bang/apps/sandbox/podinfo/-/merge_requests/72
Current features

Comments will be mirrored to the associated GitLab Merge Request.
Quote Replies will mirror to Gitlab as a Thread
Updates to code will be pushed to the associated GitLab Merge Request.
Closing the PR will close the associated GitLab Merge Request.

Features not available yet

Comments on code will not be mirrored


Is the original video available?

Thanks for releasing your nice work.
I am wondering where I can find the original unenhanced video?
Thank you very much!

I just added the download link for the demo video in the README.md. Hope it is suitable for you. Thanks.

Thanks!


ndk-build: Include libc++_shared in the APK

Closes #19
libc++_shared is not available on-device, and has to be provided in the
APK when used.
See the NDK guide:
https://developer.android.com/ndk/guides/cpp-support#libc

Thanks!


In "README.md", "簡" should be “简”.

In "README.md", "簡中版" means simplified chinese version, but "簡" is a traditional chinese character, it should be "简".

Just make a PR directly.

Good catch. :-)

In anyone wants to review: https://github.com/shieldfy/API-Security-Checklist/pull/121


PPTP-2264 | replace submit button with content

Description of Work carried through
Brief description of what/why/how.
Content is still to be confirmed;
The toggle on the chnge links is to ensure that a suse rcan fix what ever they broke through the GUI, even though they had to url hop to break it
The button has not been greyed out but removed to try and be more accessable, as disbaled buttons are frowned upon

Closing in favour of clean branch PPTP-2264


make config files' rules take precedence over defaults

make the rules from config files (set in prettyPrintAST.js) take precedence over the defaults (set in /bin/marko-prettyprint.js)
update tests by adding a test.js setting indent but checking that the .editorconfig and .marko-prettyprint config files rule apply
add a .editorconfig in test/ with root = true to override all the rules from the .editorconfig in the root of the project

Ideally I feel, the precedence of rules should be set in one location instead of at 2 places and the precedence should be like so:
default rules < .editorconfig < .marko-prettyprint < CLI arguments
This will need additional work but this PR is a small step in that process.

Thanks for the PR, released in 1.5.1. Sorry for the delay!


chore: updating motoko doc to 0.9.3, matching dfx 0.14.2

Thank you for your contribution to the IC Developer Portal.
Before submitting your Pull Request, please make sure that:

[x] You have updated the .github/CODEOWNERS file according to your changes.
[x] You have registered new documents to /sidebars.js if any.

Preview looks good to me.


fix #77

removed turbine-labs details from home.yml

@phoenixking25 LGTM. Approved pending DCO signature (feel free to force push).

@lucperkins i dont have write access!

@lucperkins done

Thanks a lot!


Add version to nav

Related issue: #50
⚠ This is a WIP. Feedback is appreciated but please don't review this with the idea I'm comfortable merging to master just yet. ⚠
What changed

Write reducer and action to handle getting the version info from rclone into the redux store
Update <RCloneDashboard  /> to make use of action and store for version information
Updated failing snapshots

What's remaining

Need to wire up the nav to use the store info

Good work! Let me know when you are ready to merge :)

Hey, any progress?

Apologies @negative0 I've had some setbacks here due to various personal matters and this virus outbreak. I'm hoping to close this issue this week.


x265: only disable assembly on riscv-cross builds

Description of changes

https://github.com/NixOS/nixpkgs/pull/204118
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Well, probably.  The rebuilds aren't too pleasant, but hundreds of regressed builds are probably worse and I'm not sure about some ugly in-between workaround.

Target staging-next, please. (I'd change it myself, but it needs force-pushing in this case.)

feel free to force push.

Well, probably. The rebuilds aren't too pleasant, but hundreds of regressed builds are probably worse and I'm not sure about some ugly in-between workaround.

It would rebuild already working non-darwin packages, but I think this might be acceptable.

OK, so a workaround for the current staging-next (mainly to avoid rebuilds on x86_64-darwin) and this PR as proper solution since the next iteration.


Drawing complex meshes is not supported

We have a case where a triangulated plane containing a quite large amount of vertices is created and it should be rendered with XML3D.js.
However, because WebGL cannot handle so many vertices in a single draw call and XML3D seems to try to draw the whole mesh at once, the drawing will fail. One solution would automatically splitting the mesh  in smaller chunks of max 65535 vertices and then drawing the chunks one by one.
I checked out the code in mesh.js and it seems that you have sketched some code there related to segmented meshes, but it seems unfinished. It would be nice if you could finish this feature so we can render larger meshes with XML3D.js more effortlessly.

Fixed in 4.8


Will ESP NOW Mesh Support 1000 nodes Connected in a line(Street Light) each 50-100 meter apart

The 10km line formation has not been tested. Theoretically, there are no restrictions. You will have to proportionally increase the waiting time for a response.
ZHNetwork was tested on 10 devices in an area of approximately 120 square metres with 3 levels of forwarding maximum. The library is deprecated and is no longer supported.
zh_network was tested on 20 devices over an area of approximately 1 square kilometre with 5 forwarding levels maximum. About 130 devices are currently running smoothly.

https://github.com/aZholtikov/zh_network/issues/5#issuecomment-2137297347


Apply design system to documentation site

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/357
Originally created by @bencodezen on 2019-02-04 17:33:06

design.gitlab.com as a source of inspiration

View 4 previous comments from the original issue on GitLab


Invariant Violation: requireNativeComponent: "SRSRadialGradient" was not found in the UIManager

Invariant Violation: requireNativeComponent: "SRSRadialGradient" was not found in the UIManager
"react": "^18.0.0",
"react-native": "^0.69.3",
"react-native-radial-gradient": "^1.1.2",

I'm also facing this issue since I've upgraded React Native to the 0.69.3 version.
Invariant Violation: requireNativeComponent: "SRSRadialGradient" was not found in the UIManager
Also latest versions of react-native-radial-gradient. Any updates?
"react": "^18.0.0",
"react-native": "^0.69.3",
"react-native-radial-gradient": "^1.1.2",

Have run into the same issue, on RN 0.69.4 on iOS, with Hermes disabled and use_frameworks! enabled in the Podfile

Added in Podfile
pod 'SRSRadialGradient', :path => '../node_modules/react-native-radial-gradient/ios'
worked for me

Still no fix?

Bump

Bump

Any fix for this? I'm facing the same issue.
"react": "^18.0.0",
"react-native": "^0.69.3",
"react-native-radial-gradient": "^1.1.2",

wait for https://github.com/surajitsarkar19/react-native-radial-gradient/pull/48 file doesn't include in npm package


Log

Adding options to change log level in command line and fix a bug in logging

merged using log imported from mavlink-router.


setFilters with array values merges values - would prefer it replace values

When I call setFilters with an array of (new) values, the new values are merged with the old values.  Old/obsolete values are never removed.
For example, if I set a filter foo: [1, 2], then call setFilter with foo: [1], I see a network call with the parameters foo[]=1&foo[]=1.
Then, if I set foo: [3], the network call is foo[]=3&foo[]=1.  Preferred behavior would be a network call with foo[]=3.
I think this can be resolved by using mergeDeepWith (https://facebook.github.io/immutable-js/docs/#/Map/mergeDeepWith) instead of mergeDeep within setFilters

@drewjohnson10 submitted #6 to address this issue. I think the unit test proves that it solves your problem, but before I merge, do you want to try it locally by pulling down the branch and using npm link?

Published in 1.8.4


Error creating river networks for routing

I am running into a tibble error when I run river_network function. The error "! The validate argument of as_tibble() was deprecated in tibble 2.0.0 and is now
defunct.
ℹ Please use the .name_repair argument instead."
How can I resolve this?

Thank you for highlighting this issue! The issue should now have been corrected.


Selectable color themes

(I wrote this to get acquainted with your project.)
This pull request adds the ability to use different color themes for the passkey. Currently this can only be set via the PASSKEY_THEME build flag in the platformio.ini file (available options are described therein). Setting the theme to random will choose a different theme each time the passkey starts up.
Additionally this implementation added a few additions and bugfixes to get everything  working:

Bugfix: unset gnu++11 flag so that the C++17 standard is actually used
Addition: a stringization macro that was necessary for the build flags to work

This is a nice addition ... take it


move topic links

if my language is not English then there are no links only text

$txt['movetopic_auto_board'] = '[BOARD]';
$txt['movetopic_auto_topic'] = '[TOPIC LINK]';

These two shall be the same as the ones in:
$txt['movetopic_default'] = 'This topic has been moved to [BOARD]

[TOPIC LINK]';

thanks!


Failed Sass/CSS Beautification, preserve_newlines ignored

Description
Beautification seems to be ignoring supplied settings, specifically preserve_newlines and max_preserve_newlines, for my Sass (SCSS) and CSS code (using prettydiff). Received expected results when testing on prettydiff.com, however.
Empty single-line comments in Sass are also being shuttled to the preceding line, while commented lines with content are collapsed. The empty single-line comment issue was not reproduced automatically in debug.md, but occurs when I enable Beautify on save.
Results
Expected:
// Colors
$color: red;

//
// Variables
// Don't include this comment in my output!
$myvar: 'iable';

/* Imports */
@import "imports/_variables";

/* Source */
.content {
  background-color: $color;
}

.text {
  color: black;

  a {
    text-align: center;
  }
}

Received:
// Colors
$color: red; //
// Variables
// Don't include this comment in my output!
$myvar: 'iable';
/* Imports */
@import "imports/_variables";
/* Source */
.content {
  background-color: $color;
}

.text {
  color: black;

  a {
    text-align: center;
  }
}

Steps to Reproduce

Reproducible on my machine in fresh project (with new Atom install)
Attempted using settings in both config.cson and .jsbeautifyrc

Debug
debug.md gist: https://gist.github.com/mattalat/4aacf3c12db63ee15120

There was a very recent change in Pretty Diff to how empty lines are preserved, see https://github.com/prettydiff/prettydiff/issues/275
I can completely reproduce the defect.  I can reproduce the defect $color: red; //  outside Atom, but not the collapsed lines above the block comments.  I am investigating.

The noted defect of this line: $color: red; //, require a patch to Pretty Diff.  I resolved the rest by checking the option CSS - Preserve newlines in the Atom Beautify settings.

Thank you for the quick response. I have a question, though: I've checked the CSS - Preserve newlines in the Atom Beautify settings, and I've redundantly enabled the setting using my project's .jsbeautifyrc, but I still don't see Atom Beautify preserving newlines in either my CSS or SCSS files. This is likely not an issue with prettydiff, as I can't recreate it online, should I open a new issue?
The odd thing is that checking the HTML - Preserve newlines seems to work just fine. However, for CSS/SCSS, the option is ignored.

No, please don't open an additional issue.  I will continue investigating and noting my findings here.  Let me update to the recently published .25 version and play around some more.  I will publish a resolution to the noted Pretty Diff defect in the next few hours.

I can confirm that I can reproduce the error in Atom on version .25 even with the option checked.

This is all a Pretty Diff defect.  Resolution published as v1.16.26.


Change the position of the y and x axis titles

Is it possible to change the position of y and x axis titles?

so right now, the y axis title  is shown at the end, I want to move it to the middle before the count numbers. Same for the x axis, so the title should be in the middle before the count numbers.
I tried using css but the position changes based on the data and it is messed up

realized this is related to c3 library


Resque::NoQueueError: Jobs must be placed onto a queue.

Getting this error while trying to run specs using resque_spec. The error is pretty clear what is going on, however from what I understand, the queue is defined in the job that's specified in enqueue. I have a queue defined in the job, but for some reason it isn't detecting it?
Fairly new to resque in general so it could possibly be something I'm doing wrong, however, here is my simple job and the method I'm trying to test, hopefully there's something I can do:
jobs/MakeChange.rb:
class MakeChange
	def self.queue
		:notification
	end

	def self.perform(change_id)
		puts 'job started'
		puts 'change is made to ' + change_id.to_s if NotificationManager::Manager.notify(change_id)
		puts 'job finished'
	end
end

services/notification_manager/manager.rb:
module NotificationManager
	class Manager
		def self.notification(owner, change_type, context, target)
			change_id = Notification.new_notification(owner, change_type, context, target)
			Resque.enqueue(MakeChange, change_id)
			# Resque.enqueue_in(
			# 	30.seconds,
			# 	MakeChange,
			# 	change_id
			# 	)
                        notification = Notification.find(change_id)
		end

		# run populate_test_data from console
		def self.notify(change_id)
			puts 'the notify method was called'
			unless NotificationManager::Notification.find(change_id).cancelled?
				change = Notification.find(change_id)
				byebug
				similar_changes = group_similar_changes(change.owner, change.target, change.change_type)
				puts 'group_similar_changes finished. size: ' + similar_changes.length.to_s
				mailer = NotificationManager::NotificationMailer
				if mailer.send_email(mailer.construct_email(similar_changes))
					puts 'the email sent'
				end
			end
		end
        end

spec/services/notification_manager/manager_spec.rb:
require 'spec_helper'

module NotificationManager
	describe Manager do
		describe '#notify' do
			before do
				ResqueSpec.reset!
			end
			let(:notification) { NotificationManager::Manager.notification('kyle', 'removed_as_delegate', 'work_id1'<EMAIL_ADDRESS>}
			it 'adds notification.notify to the notification queue' do
				expect(Manager).to have_queued(notification.id, :notify)
			end
		end
	end
end

Thanks for the gem, by the way, it it exactly what I needed, only I hope I can get it working :D

I'm trying to get the formatting right in the issue... Sorry ^^

update: I'm using rspec-rails as I'm working with a Rails application. I read through the readme once more and saw that support for rspec < 3.0 was iffy, so I ran bundle update rspec-rails rspec-core which put me on the latest releases for both, but to no avail.
I just noticed that the readme makes no mention of actual Rails. I'm hoping this Gem can be used with Rails?

Hi @lawhorkl,
Sorry to be late in replying. Yes, the gem will work with Rails.
In the snippets, the use of the have_queued matcher is possibly incorrect. The spec is checking the Manager class while the queue is on the MakeChange class. Does that help?


[TestOnly] Additional Decred signing tests.

Description
Additional Decred signing tests.
Testing instructions
Unit tests, coverage.
Types of changes

New tests.

Checklist

[x] Prefix PR title with [WIP] if necessary.
[x] Add tests to cover changes as needed.
[x] Update documentation as needed.

This coverage looks not impressive 0.07%, should we continue or just close it?

This coverage looks not impressive 0.07%, should we continue or just close it?

Yes, the added tests did not increase the coverage much.  There are many combinations of various script usage cases, and I just added two, several still missing.  Also, existing tests do not follow the real usage pattern, scripts are not built the way they are normally built, so I plan to rework these tests.  BTW, I have added some Decred tests in other PR, #872 .

Closing, see comment above.


Port TypedExpressionVariant::FunctionApplication to the declaration engine.

This ports the FunctionApplication expression variant to the declaration engine.
The first commit adds some error handling paths to the const evaluator that is used later for handling DE errors. Not 100% happy with removing the functional style code but couldn't really come up with a decent alternative that kept the existing style.
The next commit fixes a newly-exposed bug in the copy types implementation, special thanks to @emilyaherbert for her help in dealing with that.
Closes https://github.com/FuelLabs/sway/issues/2786.

LGTM! Nice.


Update for 2.02 doesn't seem to be working

I installed version from github and prerequisites, but Mod settings menu doesn't show in main menu and in-world navigation also won't work. I checked log and there is no error in any of them, it simply just doesn't work.

I get a redscript compilation error  (from log)
F:\GOG Galaxy\Games\Cyberpunk 2077\red4ext\plugins\in_world_navigation\module.reds
[WARN - Wed, 8 Nov 2023 20:30:47 -0800] At F:\GOG Galaxy\Games\Cyberpunk 2077\r6\scripts\Codeware\Codeware.Global.reds:1948:1:
@addField(inkScrollArea)
^^^
field with this name is already defined in the class, this will have no effect
[WARN - Wed, 8 Nov 2023 20:30:47 -0800] At F:\GOG Galaxy\Games\Cyberpunk 2077\r6\scripts\backgroundScanner\Util\String.reds:15:12:
return Equals(GetLocalizedText(locKey), null);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
comparing unrelated types, this is will not be allowed in the future
[ERROR - Wed, 8 Nov 2023 20:30:47 -0800] [UNRESOLVED_REF] At F:\GOG Galaxy\Games\Cyberpunk 2077\red4ext\plugins\in_world_navigation\packed.reds:94:5:
ModSettings.RegisterListenerToClass(this);
^^^^^^^^^^^
unresolved reference ModSettings
[ERROR - Wed, 8 Nov 2023 20:31:45 -0800] Compilation error: REDScript compilation failed. The game will start, but none of the scripts will take effect. This is caused by errors in:
You can try updating or removing these scripts to resolve the issue. If you need more information, consult the logs.

I have no errors, checking logs and it seems like it should be working fine, it just doesn't, here are my logs.
in_world_navigation.log
[2023-11-09 05:44:48.877] [info] Starting up In-World Navigation 0.1.13
[2023-11-09 05:44:48.877] [info] Attaching UpdateNavPath at 0x3301FC
[2023-11-09 05:44:50.225] [info] Registering members & functions
[2023-11-09 05:45:35.879] [info] [RED4ext] New InWorldNavigation Instance
[2023-11-09 05:45:56.865] [info] Shutting down

red4ext.log
[2023-11-09 05:44:47.354] [RED4ext] [info] RED4ext (v1.18.0) is initializing...
[2023-11-09 05:44:47.354] [RED4ext] [info] Game patch: 2.02
[2023-11-09 05:44:47.354] [RED4ext] [info] Product version: 2.02
[2023-11-09 05:44:47.354] [RED4ext] [info] File version: <IP_ADDRESS>22
[2023-11-09 05:44:47.371] [RED4ext] [info] RED4ext has been successfully initialized
[2023-11-09 05:44:47.403] [RED4ext] [info] RED4ext is starting up...
[2023-11-09 05:44:47.403] [RED4ext] [info] Loading plugins...
[2023-11-09 05:44:47.403] [RED4ext] [info] Loading plugin from 'M:\games\Cyberpunk 2077\red4ext\plugins\ArchiveXL\ArchiveXL.dll'...
[2023-11-09 05:44:48.389] [RED4ext] [info] ArchiveXL (version: 1.8.1, author(s): psiberx) has been loaded
[2023-11-09 05:44:48.389] [RED4ext] [info] Loading plugin from 'M:\games\Cyberpunk 2077\red4ext\plugins\in_world_navigation\in_world_navigation.dll'...
[2023-11-09 05:44:48.910] [RED4ext] [info] In-World Navigation (version: 0.1.13, author(s): Jack Humbert) has been loaded
[2023-11-09 05:44:48.910] [RED4ext] [info] Loading plugin from 'M:\games\Cyberpunk 2077\red4ext\plugins\mod_settings\mod_settings.dll'...
[2023-11-09 05:44:49.816] [RED4ext] [info] Mod Settings (version: 0.1.13, author(s): Jack Humbert) has been loaded
[2023-11-09 05:44:49.816] [RED4ext] [info] 3 plugin(s) loaded
[2023-11-09 05:44:49.816] [RED4ext] [info] RED4ext has been started
[2023-11-09 05:44:51.751] [RED4ext] [info] Adding paths to redscript compilation:
[2023-11-09 05:44:51.751] [RED4ext] [info] In-World Navigation: 'M:\games\Cyberpunk 2077\red4ext\plugins\in_world_navigation\packed.reds'
[2023-11-09 05:44:51.751] [RED4ext] [info] In-World Navigation: 'M:\games\Cyberpunk 2077\red4ext\plugins\in_world_navigation\module.reds'
[2023-11-09 05:44:51.751] [RED4ext] [info] Mod Settings: 'M:\games\Cyberpunk 2077\red4ext\plugins\mod_settings\packed.reds'
[2023-11-09 05:44:51.751] [RED4ext] [info] Mod Settings: 'M:\games\Cyberpunk 2077\red4ext\plugins\mod_settings\module.reds'
[2023-11-09 05:44:51.751] [RED4ext] [info] Paths written to: 'M:\games\Cyberpunk 2077\red4ext\redscript_paths.txt'
[2023-11-09 05:44:51.751] [RED4ext] [info] Final redscript compilation arg string: '-compile "M:\games\Cyberpunk 2077\r6\scripts\" "M:\games\Cyberpunk 2077\r6\cache\final.redscripts" -Wnone -threads 4 -no-testonly -no-breakpoint -no-exec -no-debug -profile=off -optimize  -compilePathsFile "M:\games\Cyberpunk 2077\red4ext\redscript_paths.txt"'
[2023-11-09 05:45:54.686] [RED4ext] [info] RED4ext is shutting down...
[2023-11-09 05:45:56.864] [RED4ext] [info] ArchiveXL has been unloaded
[2023-11-09 05:45:56.925] [RED4ext] [info] In-World Navigation has been unloaded
[2023-11-09 05:45:56.995] [RED4ext] [info] Mod Settings has been unloaded
[2023-11-09 05:45:56.995] [RED4ext] [info] 3 plugin(s) unloaded
[2023-11-09 05:45:57.065] [RED4ext] [info] RED4ext has been shut down

mod_settings.log
[2023-11-09 05:44:49.782] [Mod Settings] [info] Starting up Mod Settings 0.1.13
[2023-11-09 05:44:49.782] [Mod Settings] [info] Base address: 00007FF7904C0000
[2023-11-09 05:45:56.925] [Mod Settings] [info] Shutting down


[2.0] Document Creation Process for Ignite Plugins

We will be using https://github.com/ArnaudRinquin/react-native-radio-buttons as an example to document how to create a new ignite plugin from an existing library.

Done with https://github.com/infinitered/ignite/pull/692


What is the number of points used in the PointMLP pretraining?

Thanks for the paper and look forward to your code! In your paper, you said 1024, 2048 and 8192 points are used for different backbones. What is the number of points for PointMLP pretraining?

hi, thanks for the kind words! For modelnet40, we used 1024 points, for scanobjectnn, we reported results on both 1024 and 2048 points.

Thanks for the info! The learning rate schedule for pretraining is not mentioned in the paper. Did you fix it at 1e-3?

we use a classic cosine schedule, lr_start=1e-6, lr_end=1e-5

Maybe I wasn't clear enough. What is the learning rate schedule for pretraining? The paper says it's 1e-3 but does not specify a schedule, which seems different than 1e-6 to 1e-5.


chore(deps): upgrade dependencies

What: Updates dependencies and re-generates the all-contributors table and stuff

Why: Because the table got out of whack somehow and some deps were outdated

How: yarn 😻

Codecov Report

Merging #62 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #62   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           5      5
  Lines         102    102
  Branches       26     26
=====================================
  Hits          102    102

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6df4bee...cd4a485. Read the comment docs.


Add RequestRetryClient and Get Rarest Achievement function

Adding new logic to request retry using the request library.
Added new function for returning the rarest achievement name and percentage of a game give a game id.
(Function will need more work for proper formatting)

Manually tested and confirmed all functions operate as expected.


Azure.Cosmos Version=4.x

System.Reflection.ReflectionTypeLoadException:“Unable to load one or more of the requested types.
Method 'RecordRequest' in type 'Microsoft.Azure.Cosmos.CosmosClientSideRequestStatistics' from assembly 'Azure.Cosmos, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' does not have an implementation.
Method 'UpdateAsync' in type 'Microsoft.Azure.Cosmos.Routing.GlobalAddressResolver' from assembly 'Azure.Cosmos, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' does not have an implementation.
Method 'UpdateAsync' in type 'Azure.Cosmos.AddressResolver' from assembly 'Azure.Cosmos, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' does not have an implementation.
Method 'UpdateAsync' in type 'Azure.Cosmos.AddressResolver' from assembly 'Azure.Cosmos, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' does not have an implementation.
Method 'UpdateAsync' in type 'Azure.Cosmos.AddressResolver' from assembly 'Azure.Cosmos, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' does not have an implementation.
Method 'UpdateAsync' in type 'Azure.Cosmos.AddressResolver' from assembly 'Azure.Cosmos, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' does not have an implementation.
Method 'UpdateAsync' in type 'Azure.Cosmos.AddressResolver' from assembly 'Azure.Cosmos, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' does not have an implementation.”

Can you explain a bit more what is "Scan" and what does it do?
Are you using Nuget references or are you manually referencing DLLs?
Do you have project references and are you using the same Nuget version across all of them?

Closing, please reopen with the requested information to help troubleshoot.