Remove USE_LONG_FNAME

The USE_LONG_FNAME macro was used in DJGPP, however it is not used anymore.
We can remove it now.

Codecov Report

Merging #3938 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3938      +/-   ##
==========================================
- Coverage   78.88%   78.85%   -0.04%
==========================================
  Files         105      105
  Lines      142102   142101       -1
==========================================
- Hits       112096   112051      -45
- Misses      30006    30050      +44

Impacted Files
Coverage Δ

src/buffer.c
80.55% <ø> (ø)
:arrow_up:

src/ex_cmds.c
81.48% <ø> (+0.24%)
:arrow_up:

src/fileio.c
75.19% <100%> (-0.01%)
:arrow_down:

src/gui_beval.c
55.02% <0%> (-7.43%)
:arrow_down:

src/gui.c
57.48% <0%> (-0.63%)
:arrow_down:

src/window.c
82.79% <0%> (-0.61%)
:arrow_down:

src/message.c
76.26% <0%> (-0.25%)
:arrow_down:

src/term.c
60.41% <0%> (-0.16%)
:arrow_down:

src/screen.c
80.05% <0%> (-0.07%)
:arrow_down:

src/channel.c
83.16% <0%> (+0.07%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05c00c0...9a8c38a. Read the comment docs.


Post-v0.0.1 PR

Making this PR to add a few things I noticed were missing. Will be shipped in v0.0.2

@plotly/dash-core Wanted to have your thoughts on the .npmignore part; I noticed that dash core components only publish the JS files to npm.

But the components built with the boilerplate seems to also publish a bunch of irrelevant files when I run npm publish:

Should we just manually add all the files to npmignore, or would it be better to use some "include" scripts (similar to manifest.in)?

@plotly/dash-core Wanted to have your thoughts on the .npmignore part; I noticed that dash core components only publish the JS files to npm.

But the components built with the boilerplate seems to also publish a bunch of irrelevant files when I run npm publish:

Should we just manually add all the files to npmignore, or would it be better to use some "include" scripts (similar to manifest.in)?

Yes update .npmignore to only push the generated + src of the JS with the .map file as well.

Yes update .npmignore to only push the generated + src of the JS with the .map file as well.

@jourdain Just realized the utils directory is not included (since we didn't specify it in setup packages). I'd like to merge this PR and release v0.0.2 asap so we can have the utils. Let me know if there's anything I should change first.

@jourdain Just realized the utils directory is not included (since we didn't specify it in setup packages). I'd like to merge this PR and release v0.0.2 asap so we can have the utils. Let me know if there's anything I should change first.


[AIRFLOW-3528] handle socket exception with SFTPOperator

Jira

[ ] My PR addresses the following Airflow Jira

Description
add try/exception to catch socket exceptions

Can one of the committers please restart the last test?

Codecov Report

Merging #4325 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4325   +/-   ##
======================================
  Coverage    78.1%   78.1%
======================================
  Files         201     201
  Lines       16471   16471
======================================
  Hits        12864   12864
  Misses       3607    3607

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1023e8c...c83a4e5. Read the comment docs.

This fix I don't think will do what we want, as I think now this will end up ultimately logging this as a message:

Error while transferring None, error: Error while connecting client, error: socket timed out

(I took a guess at what might be in the OSError).
Which means we probably need to add some tests, via mocking, that makes open_sftp fail with an exception. And then once we have tests we can be sure the error is reported right in this case.

I guessed at what error it might report. The main thing is you have try-inside-try, so this won't do what you expect.
Additionally the error that was reporting was 'NoneType' object has no attribute 'open_sftp' which means no exception is being thrown, instead self.ssh_hook.get_conn() as ssh_client is returning None.
So the except you added (capturing OSError) won't ever get triggered.
Tests :)

Agree with @ashb on the exception type to catch. Based on the exception/log shared in the Slack thread, it's an AttributeError instead of OSError. This PR can not (completely) handle the issue shared in the Slack thread.

OK. Got it.
In this case I'll leave this to @XD-DENG or whoever wants to pick this up. From what was reported regardless of the error handling the operator doesn't seem to work. This exceed from the scope of what I can help with at this point.

Okay, thanks for trying though!


Be able to provide arguments and a constructor

Hi,
First of all, many thanks for mantaining this project. I would like to know if this feature is currently supported. Imagine I have the following:
class ClassAView(FlaskView):
def init(self, pagename):
self.pagename = pagename
def index():
return 'Welcome to ' + self.pagename
Now, I would like to be able to instantiate an object of class ClassAView, register the Flask app to it, and give it a name as an argument to its constructor:
app = Flask(name)
instanceA = ClassAView('my page')
instanceA.register(app, route_base='/')
app.run()
I face some errors when doing something like this, so I tried to instantiate the object with an empty constructor, and then trying to define a setter method in order to provide "pagename". However, pagename is not stored and not displayed when requesting the index.
If not supported, I think it would be really nice to be able to interact with the REST facade with setter methods, or a constructor admitting arguments.
Many thanks for your help!

@jsubirat sorry, your case is not supported as it's not the way how flask-classful works.


Update dependency cocoapods to v1.14.0

This PR contains the following updates:

Package
Update
Change

cocoapods
minor
"1.13.0" -> "1.14.0"

Release Notes

CocoaPods/CocoaPods (cocoapods)
v1.14.0
Compare Source
Enhancements

None.

Bug Fixes

Fix a crash when running with activesupport 7.1.0.
MCanhisares
#12081

Fix another crash when running with activesupport 7.1.0.
movila
#12089

Other

Drop support for bazaar SCM.

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: Gemfile.lock
Fetching gem metadata from https://rubygems.org/.......
Resolving dependencies...

Bundler could not find compatible versions for gem "cocoapods":
  In Gemfile:
    cocoapods (= 1.14.0)
Bundler could not find compatible versions for gem "cocoapods-downloader":
  In Gemfile:
    cocoapods (= 1.14.0) was resolved to 1.14.0, which depends on
      cocoapods-downloader (>= 2.0)

Could not find gem 'cocoapods-downloader (>= 2.0)' with platform 'ruby', which
is required by gem 'cocoapods (= 1.14.0)', in rubygems repository
https://rubygems.org/ or installed locally.

The source contains the following gems matching 'cocoapods-downloader (>= 2.0)':
  * cocoapods-downloader-2.0


[INFRA] Have a pipeline to mirror support-bundle-kit to longhornio

What's the test to develop? Please describe
We are regularly updating the support-bundle-kit to resolve CVE fixes. It will improve the workflow to have a pipeline that enables self-triggering the mirroring from rancher/support-bundle-kit to longhornio.
Describe the items of the test development (DoD, definition of done) you'd like

[ ] A pipeline for support-bundle-kit mirroring

Additional context
None

@yangchiu aren't we able to do it right now?


Improved Docs

An ordered list tells the user it is done is it is in unordered list then the user may be confused to see only 1's and 1's

An ordered list tells the user it is done if it is in unordered list then the user may be confused to see only 1's and 1's

If you read the README, you'll see that it's rendered as an ordered list.


License and further development

I was wondering if you can provide a license for this repo, so that others can continue working on it. Because right now, this is impossible and I'm considering creating my own serverless-worker for RunPod, so that we can use ollama there. But I would rather help out here or fork it instead of starting from scratch.
What are your thoughts @pooyahrtn?

Hey @TimPietrusky!
Great idea, thanks. I added an MIT license 0bba88d.
I'd definitely appreciate any contribution.

@pooyahrtn thank you very much! Then let's get this going.


Cannot draw shapes in IE 10 and 11 on Windows 8

I am having trouble getting the demo working on IE 10 and 11.
I am using a MacBook Pro Retina and VMWare Fusion to run IE 10 and 11. I cannot draw circles or polygons. msMaxTouchPoints is being reported as 8.
Is this related to all the other touch issues on here? Should Leaflet.draw work on Windows 8? I realize there are a lot of new complications with pointer events and mixing touch and mouse input that it looks like leaflet draw isn't handling.

For anyone else like me who is stuck on an older version of Leaflet, I fixed this by overwriting Leaflet's touch feature detection with Modernizr's:
L.Browser.touch = Modernizr.touchevents;


Scaffold tree: structure part containing H atom is replaced with '?' in some cases

v1.17.10, chem 1.8.7
Steps to reproduce:

Open a table containing molecules column (e.g. SPGI)
Add a scaffold tree standalone viewer OR add scaffold tree as a filter to filters panel
Open editor and draw a structure with H atom added explicitly
Add it as a scaffold

Expected results: structure is displayed in scaffold tree viewer/filter as drawn in the editor.
Actual results: part with H atom is replaced with '?':

Chem 1.8.9


Update ASB Docker Credentials

The Ansible Service Broker now requires base64 encoded values for
Docker Credentials. This converts the values before using them in
the template.

@maleck13 Would you mind taking a look? Based on the changes in this commit of the Ansible Service Broker, which requires base64 values for the DockerHub credentials. https://github.com/openshift/ansible-service-broker/commit/d083f9a26250ed51dc247763792b280e8522eeb7


[bug] SiWe as safe app does not call the authenticate function

Is there an existing issue for this?

[X] I have searched the existing issues

RainbowKit Version
0.12.4
wagmi Version
0.12.4
Current Behavior
What works: Connecting (formerly gnosis) safe with WalletConnect
On connect modal select WalletConnect -> Official Modal -> copy link -> paste into app.safe.global WalletConnect app -> connection established -> sign login message -> approve in app.safe.global -> custom logic in pages/api/auth/[...nextauth].ts verifies the multisig has approved this message hash on-chain
What doesn't work: The same workflow as safe app
Rainbowkit support usage as (custom) safe app since version 0.12.4, so this is still brand new. We are excited about it, because we had been working on this very functionality for our dapp!
But when I try the workflow above as safe app, I get stuck with an open modal claiming to be "Verifying signature ...", without ever calling the backend.

So the non-working flow is:
Open app.safe.global -> open custom app -> paste dapp url -> accept disclaimers etc -> connect wallet (very smooth and nice!) -> sign message -> approve in safe -> get stuck at "Verifying signature ...", backend is never called.
Expected Behavior
Sign in workflow with safe app calls backend with 0x as signature, just as sign in workflow with WalletConnect does.
Steps To Reproduce
Not tested: enable an app to become a safe app by adding a manifest.json and configuring cors to allow loading of the same. Try signing the login message with WalletConnect and as safe app. Both should fail (unless the backend was modified to verify EIP1271), but only WalletConnect does fail whereas safe app gets stuck without ever proceeding to check the signature in the first place.
Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
No response
Anything else?
No response

Thanks for looking into this, @DanielSinclair. We are very interested in gasless signatures, too, and happy to help exploring how it can be done.
Fixing the on-chain signature should be much easier though, so I recommend doing that first. And I agree that it sounds like the return value of signMessage is not forwarded properly - possibly because it contains "0x" as signature (which is expected).

After some digging I have to challenge our assumption that the bug starts with signMessageAsync.
As the screenshot in the issue shows, I get stuck at "Verifying signature", which is only shown after the signature has been received.
This suggests the problem starts in authAdapter.verify(). Which is weird because I log any call to authorize in [...nextauth].ts and don't see that it is executed.

@malteish Yes, you're right. Was able to isolate the issue to next-auth session handling. const { status } = useSession() is not updating to authenticated in the Safe environment. Still hunting down the exact reason, but it might be related to the iframe. It looks like the RainbowKit side is working as expected, so a custom authentication adapter that doesn't rely on next-auth sessions should continue to work.

So we found out that CSRF and the nonce in the SiWe message were equal when using Metamask or WalletConnect, but different when using safe app. This is because next-auth enforces sameSite by default (which is a good choice!).
After updating cookie policy for testing, signing messages and authenticating them in the backend works. Added this to [...nextauth].ts:
cookies: {
      // WARNING: This disables the default cross-site protection for cookies!
      // These options were added to explore use of our app in a safe iframe.
      // https://www.npmjs.com/package/cookies-next
      // https://datatracker.ietf.org/doc/html/draft-ietf-httpbis-rfc6265bis-03#section-<IP_ADDRESS>
      csrfToken: {
        name: `__Host-next-auth.csrf-token`,
        options: {
          httpOnly: true,
          sameSite: 'none', //'lax',
          path: '/',
          secure: true,
        },
      },
      sessionToken: {
        name: `__Secure-next-auth.session-token`,
        options: {
          httpOnly: true,
          sameSite: 'none',
          path: '/',
          secure: true,
        },
      },
    },

** WARNING: THESE SETTINGS ARE A VERY BAD CHOICE FOR PRODUCTION** in my opinion. Maybe someone with deeper knowledge in this area of expertise can chime in to either proof me wrong or suggest a better configuration.
Background:
https://github.com/nextauthjs/next-auth/issues/7051
https://github.com/nextauthjs/next-auth/issues/7077
https://next-auth.js.org/configuration/options#usesecurecookies

@malteish Will keep this issue open to see if a better solution is presented. I'll also relay to the Safe team to see if there is guidance on how to handle sessions/cookies in the Safe browser environment.

We're also interested on this. We wanted to add support not only for Safe, but also for AA in general.
Do you know of other session manager (e.g. iron-session) that is able to properly handle sessions within an iframe?
@DanielSinclair , did the Safe team gave a proper answer? It may be something recurrent for them for the way they work with apps as iframes.

@nfts2me Our team is looking at this issue. We'll report back once we have a solution 🙏

@nfts2me Yes. We're working on this right now, please bear with us 👍


rustc: wrap llvmPackages when using LLVM with callPackage

Description of changes
CC @trofi
Use callPackage with pkgsLLVM.rustc.llvmPackages so it fixes eval with Firefox, Betterbird, etc.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

How did you test the eval? Maybe I'm doing it wrong. It fails for me as:
$ nix eval github:NixOS/nixpkgs/pull/330754/head#pkgsLLVM.betterbird-unwrapped
error:
       … while calling a functor (an attribute set with a '__functor' attribute)
         at /nix/store/7fzm97kg6m5nh0623wx1b5h45n6g05g0-source/lib/customisation.nix:264:13:
          263|     in if missingArgs == {}
          264|        then makeOverridable f allArgs
             |             ^
          265|        # This needs to be an abort so it can't be caught with `builtins.tryEval`,

       … while evaluating a branch condition
         at /nix/store/7fzm97kg6m5nh0623wx1b5h45n6g05g0-source/lib/customisation.nix:148:7:
          147|     in
          148|       if isAttrs result then
             |       ^
          149|         result // {

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: attribute 'stdenv' missing
       at /nix/store/7fzm97kg6m5nh0623wx1b5h45n6g05g0-source/pkgs/applications/networking/browsers/firefox/common.nix:177:28:
          176|   # LTO requires LLVM bintools including ld.lld and llvm-ar.
          177|   buildStdenv = overrideCC llvmPackages.stdenv (llvmPackages.stdenv.cc.override {
             |                            ^
          178|     bintools = if ltoSupport then buildPackages.rustc.llvmPackages.bintools else stdenv.cc.bintools;

$ nix eval github:NixOS/nixpkgs/pull/330754/merge#pkgsLLVM.betterbird-unwrapped
error:
       … while calling a functor (an attribute set with a '__functor' attribute)
         at /nix/store/7fzm97kg6m5nh0623wx1b5h45n6g05g0-source/lib/customisation.nix:264:13:
          263|     in if missingArgs == {}
          264|        then makeOverridable f allArgs
             |             ^
          265|        # This needs to be an abort so it can't be caught with `builtins.tryEval`,

       … while evaluating a branch condition
         at /nix/store/7fzm97kg6m5nh0623wx1b5h45n6g05g0-source/lib/customisation.nix:148:7:
          147|     in
          148|       if isAttrs result then
             |       ^
          149|         result // {

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: attribute 'stdenv' missing
       at /nix/store/7fzm97kg6m5nh0623wx1b5h45n6g05g0-source/pkgs/applications/networking/browsers/firefox/common.nix:177:28:
          176|   # LTO requires LLVM bintools including ld.lld and llvm-ar.
          177|   buildStdenv = overrideCC llvmPackages.stdenv (llvmPackages.stdenv.cc.override {
             |                            ^
          178|     bintools = if ltoSupport then buildPackages.rustc.llvmPackages.bintools else stdenv.cc.bintools;

Moving formatting changes to a separate commit might get it a bit easier to review what the PR changes WRT evaluation.

How did you test the eval?

nix repl. I just looked at my repl history and it seemed I wrongfully assumed the fix worked fully because I am used to the Nixpkgs LLVM WS flake automatically using pkgsLLVM with legacyPackages. I can finish up this fix easily.

Ok, it works now.

The pkgsLLVM.betterbird-unwrapped eval succeeds now. Thank you!

Only the manual rebuilds on x86_64-linux for some reason but it looks like this is ready and we probably should get it in before #332153, I'll merge if there's no objections.


noImplicitAny is a great way to migrate a large code base, but allow per type override

We migrated a large codebase and we are gradually typing the entire codebase. This is a feature request to build a way to disallow implicitAny for a given type or a set of types so that we can make new code strict while keeping legacy code implicitAny, so that we can make things strict one type at a time instead of files or classes.

This isn't the first time we've gotten a request like this - for example, there's #8855. As we start to tinker with the idea of error suppression, maybe it's time we revisit this.

Yes, that would be helpful. Is the idea of error suppression slated for planned 2.6 ?

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.

@mhegazy can you link to the bug where it is addressed?

@mhegazy can you link to the bug where it is addressed? Or indicate why it is unactionable. As a user who is not privy to typescript team discussions, it is really confusing

This issue has been discussed in https://github.com/Microsoft/TypeScript/issues/8855. We like to keep the discussion of a topic to one issue. feel free to add your comment/vote to https://github.com/Microsoft/TypeScript/issues/8855. We intentionally do not lock closed issues to allow users to voice their opinions on closed issues, and we do revisit our decisions based on these comments/discussions.

That bug is related but not necessarily a duplicate. Issue #8855 is talking about using it on a per-file basis, but given the way the compilation works, it may be better to do it on a per-type basis. Maybe the distinction was not clear.
If you believe that is still a duplicate, I can stop pushing for it.

Could you clarify what you mean by

you already have index signatures to turn off implicit any errors for accessing

Here I mean if we can annotate a type say with a strict mode
/* @strict */
interface MyType {
....
}
Then we can be sure that type will never be cast into any type or back implicitly, which happens now with --noImplicitAny=false, I would like to manually annotate types which will never respect noImplicitAny

well.. interfaces/types are really not the ones you get the implicit any errors on; usually you do not write a type declaration and leave off the type of its members, e.g. type X = { a; }. it is function/properties/variable declarations. and i would personally find it annoying to go on ever function i have and add @strict. again, i see the per-file option, like some modules have been audited for implicit-any and do not want them to regress, but have no time to do it for all files.


chore: handle more duplicate insert errors

Checklist

[ ] Affected Issues have been mentioned in the Closing issues section
[ ] Documentation has been written/updated
[ ] PR title is ready for inclusion in changelog

One idea for handling duplicate inserts. There are probably other places this needs to be done.
It could probably be done better with transactions or try/catch?
Happy if anyone else wants to take this on though, just planting this as a seed

@CGoodwin90 to resuscitate, rebase and update


Fix for lotus/lotus issue 185 - Performance issue with rendering a partial view

This is a potential fix for https://github.com/lotus/lotus/issues/185
Partial templates are loaded on start-up and cached in the framework configuration object - Lotus::View.configuration and pulled from there by the PartialFinder at runtime.
I'm not too sure about the cache structure. It's a two-level hash at the moment, so that you can lookup the templates for a given path and then pick the one with the required format.
I have left the old implementation as a fallback for now. Are there any good reasons not to remove it completely (other than the fact that there are a few tests I would need to fix)?

@stevehook thanks for the PR. Some remarks/questions:

did you check the effect of caching partials, performance wise?
what about reloading modified partials (in development mode)?
what do you think about loading all templates (layouts, partials, templates) the same way?

@stevehook great work, would you be able to provide a benchmark too?

Thanks for the comments @pascalbetz.

I must admit I haven't run any proper performance tests, I should be able to do that tomorrow.
Reloading I'll need to check on also, I thought that the whole framework got reloaded but I'm not sure about that.
I think it would be a good idea to load all the templates in the same way, for consistency mainly, as there isn't really a performance issue with non-partials. To be honest I didn't want to attempt too big a change to begin with, but I'd be happy to follow it up when you are happy with the direction it's going in.

@stevehook i think it's a good start and its good to start small.

@stevehook
I made a small example to test this, my findings:
i never had a cache hit, the @partials instance was not the same when loading the partials vs. when looking them up. Hence no performance gain as it always finds/instantiates the template anew. Did not investigate further though.
Can you check again? Or perhaps share your sample app?
About the "unified" mechanism for template loading: i think this is something that @jodosha, @joneslee85, @AlfonsoUceda would need to chime in. What do you guys think?
Currently Templates/Layouts/Partials are preloaded differently. I think that mechanism should be unified so that the 'only' difference is the lookup (partials by :partials argument on the render call, templates by action/controller name, layout by layout config).
Not sure how code reloading would work? Would the cache need to deal with that (mtime, if file system) or would shotgun/entr handle this?
Also i think the template loading mechanism should be able to handle templates stored somewhere else than file system (quite useful for CMS applications). Not that it need to be provided by lotus (at this time) but a clean/simple extension point/interface would be great.

@pascalbetz I'll check my sample app as soon as I get chance. One thing I did have to do was run it with the --no-code-reloading option to get any kind of caching working but it sounds like you are hitting a different issue.

@stevehook Thank you for this PR. It will give an perf boost to Lotus apps!! :+1:
We probably need to add an integration test to prove that the whole stack works as expected. We have Store and CardDeck fixtures (see test/fixtures.rb) that can be expanded a bit to prove that:

One application (eg. Store) is able to render its own partial.
Referencing a partial that belongs to another application, will raise an error.

@stevehook The next version of lotus-view is v0.5.0, that will be released on Jan 12th. However, I see this new logic to be merged later that date.
Can you please replace all the @since 0.6.0 with @since x.x.x? This is our convention for master branch. Thank you!

I've updated the PR and addressed some of the comments. I still need to get some performance figures and look at the integration tests among other things.

@stevehook i'll try and unify template loading on top of your changes.

@stevehook can you run a benchmark with/without partials, with/without your changes so we can be sure that the change has the desired effect?

I've done some rough benchmarks, using the technique that @smt116 used to diagnose the original problem. The test is hitting a very simple test application (that renders a single partial - https://github.com/stevehook/lotus-test).
Seems to me there is a measurable difference especially with Puma.
branch master with Webbrick:
$  wrk --connections 4 --duration 5 --threads 4 http://localhost:2300/books
Running 5s test @ http://localhost:2300/books
  4 threads and 4 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     9.68ms    3.51ms  25.93ms   69.77%
    Req/Sec   103.76     16.02   141.00     61.50%
  2072 requests in 5.02s, 0.92MB read
Requests/sec:    413.13
Transfer/sec:    187.20KB

branch issue_185 with Webbrick:
$  wrk --connections 4 --duration 5 --threads 4 http://localhost:2300/books
Running 5s test @ http://localhost:2300/books
  4 threads and 4 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     6.28ms    2.65ms  31.21ms   69.31%
    Req/Sec   160.58     19.74   232.00     73.50%
  3206 requests in 5.01s, 1.42MB read
Requests/sec:    639.34
Transfer/sec:    289.77KB

branch master with Puma:
$ wrk --connections 4 --duration 5 --threads 4 http://localhost:2300/books
Running 5s test @ http://localhost:2300/books
  4 threads and 4 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     6.50ms    2.06ms  19.05ms   72.06%
    Req/Sec   154.54     16.84   191.00     78.00%
  3083 requests in 5.01s, 1.10MB read
Requests/sec:    615.32
Transfer/sec:    224.31KB

branch issue_185 with Puma:
$ wrk --connections 4 --duration 5 --threads 4 http://localhost:2300/books
Running 5s test @ http://localhost:2300/books
  4 threads and 4 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     3.88ms    1.30ms  19.90ms   76.02%
    Req/Sec   259.65     25.51   320.00     67.50%
  5177 requests in 5.01s, 1.84MB read
Requests/sec:   1033.85
Transfer/sec:    376.73KB

nice, I love what I am seeing :+1:

@stevehook :100: Thank you very much! I just need some more time to review the entire PR. I want to merge this after we'll release v0.6.0 (next Tue).

Thanks @jodosha - I didn't get change to add those integration tests yet. I can try to do that over the next few days.

@stevehook Please do :smile:

@jodosha I was having some trouble with those integration tests.
My first attempt was to extend the existing fixtures as you suggested.  https://github.com/stevehook/view/compare/issue_185...stevehook:issue_185_integration_tests
I extended the fixtures for CardDeck and Store apps so that each has a view with a partial in their own app, added tests for those together with a test to verify that an exception is raised when attempting to include a partial from the other app. These work fine in isolation but not when running the full test suite because there are other tests that unload these apps. A simple reload doesn't restore the original configuration; the root attribute is reset in the unload! but not restored in load!.
I needed to add a layout template file to render CardDeck views - test/fixtures/templates/card_deck/app/templates/application.html.erb. This change broke a couple of other tests that render the Articles::Index view I think because this new layout file was getting used instead of test/fixtures/templates/application.html.erb.
So to avoid these side-effects I ended up creating two new small apps in fixtures (App1 and App2) just to test partials. These seem to work but there may be a simpler way to do this that I'm not seeing at the moment.

@stevehook

So to avoid these side-effects I ended up creating two new small apps in fixtures (App1 and App2) just to test partials.

You took the right decision then. :+1:

These problems for our builds are due to global state (CardDeck or Lotus::View), being (un)loaded. We need to fix those, but after Lotus 1.0 will be out.

I've rerun the simple performance benchmark using latest master and issue_185 branches, results below.
It looks like the results are pretty consistent with the original measurements I took before the latest changes, neither master or this branch have got any better or worse.
branch master with Webrick:
wrk --connections 4 --duration 5 --threads 4 http://localhost:2300/books
Running 5s test @ http://localhost:2300/books
  4 threads and 4 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     9.20ms    3.08ms  21.89ms   70.32%
    Req/Sec   108.93     13.61   141.00     73.00%
  2180 requests in 5.03s, 0.96MB read
Requests/sec:    433.63
Transfer/sec:    196.56KB

branch issue_185 with Webrick:
wrk --connections 4 --duration 5 --threads 4 http://localhost:2300/books
Running 5s test @ http://localhost:2300/books
  4 threads and 4 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     6.25ms    2.54ms  19.51ms   66.78%
    Req/Sec   161.29     17.80   202.00     59.50%
  3225 requests in 5.02s, 1.43MB read
Requests/sec:    642.17
Transfer/sec:    291.12KB

branch master with Puma:
wrk --connections 4 --duration 5 --threads 4 http://localhost:2300/books
Running 5s test @ http://localhost:2300/books
  4 threads and 4 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     6.67ms    1.78ms  16.38ms   71.65%
    Req/Sec   150.43     13.40   200.00     80.50%
  3003 requests in 5.01s, 1.07MB read
Requests/sec:    599.08
Transfer/sec:    218.27KB

branch issue_185 with Puma:
wrk --connections 4 --duration 5 --threads 4 http://localhost:2300/books
Running 5s test @ http://localhost:2300/books
  4 threads and 4 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     3.94ms    1.15ms  10.36ms   73.10%
    Req/Sec   254.18     17.33   373.00     79.00%
  5068 requests in 5.01s, 1.80MB read
Requests/sec:   1011.78
Transfer/sec:    368.67KB

@stevehook I've finally merged this. Thank you very much! :+1:

thank you @jodosha and love the new project name by the way!


[-wATCH-]— Sophie Rain Spiderman Video Original Video Link Sophie Rain Spiderman Video Viral On Social Media X Trending Now

28 seconds ago James Charles L𝚎aked Video Viral On Social Media. Θ(ＷＡＴＣＨ VIDEO𝕊) James Charles Viral ᴠɪᴅᴇᴏ ʟᴇᴀᴋᴇᴅ Update Files Trending On Social Media X Telegram
𝖶𝖺𝗍𝖼𝗁 🟢 ➤ ➤ ➤ 🌐 𝖢𝗅𝗂𝖼𝗄 𝖧𝖾𝗋𝖾 𝖳𝗈 𝗅𝗂𝗇𝗄 (𝖥𝗎𝗅 𝗅 𝖵𝗂𝗋𝖺𝗅 𝖵𝗂𝖽𝖾𝗈 𝖫𝗂𝗇𝗄)
🔴 ➤► 𝖣𝖮𝖶𝖭𝖫𝖮𝖠𝖣👉👉 (𝖥𝗎𝗅𝗅 𝖵𝗂𝗋𝖺𝗅 𝖵𝗂𝖽𝖾𝗈 𝖫𝗂𝗇 𝗄) 𝖶𝖺𝗍𝖼𝗁
🟢 ➤ ➤ ➤ 🌐 𝖢𝗅𝗂𝖼𝗄 𝖧𝖾𝗋𝖾 𝖳𝗈 𝗅𝗂𝗇𝗄 (𝖥𝗎𝗅𝗅 𝖵𝗂𝗋𝖺 𝗅 𝖵𝗂𝖽𝖾𝗈 𝖫𝗂𝗇𝗄)
🔴 ➤► 𝖣𝖮𝖶𝖭𝖫𝖮𝖠𝖣👉👉 (𝖥𝗎𝗅𝗅 𝖵𝗂𝗋𝖺𝗅 𝖵𝗂𝖽𝖾𝗈 𝖫𝗂𝗇 𝗄)
L𝚎aked Video James Charles Original Video Viral Video L𝚎aked on X Twitter Telegram
James Charles Dark Video Female James Charles Dark Video Link Viral On Social Media X TikTok Trending Now
James Charles Original Video video took the internet by storm and amazed viewers on various social media platforms. James Charles , a young and talented digital creator, recently became famous thanks to this interesting video.
L𝚎aked Video James Charles Original Video Viral Video L𝚎aked on X Twitter
James Charles Original Video video oficial twitter
L𝚎aked Video James Charles Original Video Viral Video L𝚎aked on X Twitter.
.
.
.
.
.
James Charles's latest video has taken the internet by storm, sparking lively discussions across various social media platforms. The rising digital influencer, known for her captivating content—especially her recent Spiderman-themed video—has experienced a massive surge in popularity. Fans are eagerly awaiting the full version, while audiences flock to Instagram, X (formerly Twitter), and Discord to engage with her latest creation.
As excitement continues to grow, fans are actively sharing their thoughts online, highlighting the crucial role social media plays in propelling creators like James Charles into the spotlight. With her unique style and creative approach, she has made a significant impact on the digital scene, leaving fans excited for what’s to come next. The viral success of her video further underscores the power of social media in boosting visibility and fostering stronger connections between creators and their audiences.
.
..
In the digital age, content spreads at an unprecedented speed. Social media has transformed how we communicate, share, and consume information. From trending topics to viral videos, platforms like Twitter, TikTok, Instagram, and Facebook have become central to modern discourse. Amid this environment, the name "James Charles" has gained significant attention following the leak of a controversial video. The so-called "James Charles Leaked video" became viral, making waves on various social media platforms and sparking a debate on privacy, online safety, and the implications of going viral.
This article aims to delve into the phenomenon of the James Charles Leaked video, examining its origins, how it became viral, and the broader implications of such content in the age of social media virality.


register_device action asks for team selection although I defined team_id

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
Hey,
I use register_devices to automatically add a device to the developer center. I pass the team_id as a parameter but still the command line prompts me for a team selection.
Am I doing something wrong here or is this maybe a bug?
Thanks guys!!!
Command executed
    module Fastlane
      module Actions
        class RegisterConnectedDeviceAction < Action
          def self.run(params)
            [...]

            Fastlane::Actions::RegisterDeviceAction.run(
              name: registered_device_name,
              udid: selected_device_uuid,
              team_id: "E23DE1CDR1"
            )
          end

          [...]

      end
    end

Complete output when running fastlane, including the stack trace and command used
Multiple teams found on the Developer Portal, please enter the number of the team you want to use:

E23DE1CDR1 "CompanyName" (In-House)
...

Environment
fastlane v 2.130.0

The register_device action converts the team_id option to the environment variable FASTLANE_TEAM_ID:
https://github.com/fastlane/fastlane/blob/1a50a980c3999c74669355d4fe74338169327b9e/fastlane/lib/fastlane/actions/register_device.rb#L46-L55
I guess that since you are calling the run method directly this code is never executed.
Could you try setting the environment variable before the call to run?
ENV["FASTLANE_TEAM_ID"] = "YOUR_TEAM_ID"

Thanks for your answer! I think you're right. I changed the call to
other_action.register_device(           [...]         )
and it works properly. Thanks again!


Code Refactor [FEATURE]

Is your feature request related to a problem? Please describe.
The code is getting a bit messy.
Describe the solution you'd like
Now that we have a working prototype and a better idea of how the software will work, it might be a good idea to go through and refactor code.
It might also be good to class out some of the widgets into custom widgets and proper object oriented hierarchy.

Look at this when doing the canvas zoom https://stackoverflow.com/a/48137257


Update Blog Post “2020-05-code-mil-an-open-source-initiative-at-the-pentagon”

Automatically generated by Netlify CMS

Deploy preview for dds-mil ready!
Built with commit fd3f7acd4e8df5cfab0219a9e0279635bdc19769
https://deploy-preview-196--dds-mil.netlify.app


plugin type="azure-vnet" failed (add): Failed to initialize key-value store of network plugin: timed out locking store

What happened:
Intermittently, hours after a node in k8s was under load and all load was removed, a node will begin failing to create pods due to the issue: Failed to create pod sandbox: rpc error: code = Unknown desc = failed to setup network for sandbox "d321c69cd17621b4e34c044e14a05acde6854f356fb856567c9f7a034ba4ee11": plugin type="azure-vnet" failed (add): Failed to initialize key-value store of network plugin: timed out locking store
When viewing the logs from azure-vnet.log I see entries like this:
2022/04/27 21:57:06 [37520] CNI_COMMAND environment variable set to ADD
2022/04/27 21:57:06 [37520] [Azure-Utils] ver
2022/04/27 21:57:06 [37520] Formatted Boot time: 2022-04-20T09:20:14Z
2022/04/27 21:57:06 [37520] Acquiring process lock
2022/04/27 21:57:08 [76172] CNI_COMMAND environment variable set to ADD
2022/04/27 21:57:08 [76172] [Azure-Utils] ver
2022/04/27 21:57:08 [76172] Formatted Boot time: 2022-04-20T09:20:14Z
2022/04/27 21:57:08 [76172] Acquiring process lock
2022/04/27 21:57:10 [84620] CNI_COMMAND environment variable set to ADD
2022/04/27 21:57:10 [84620] [Azure-Utils] ver
2022/04/27 21:57:10 [84620] Formatted Boot time: 2022-04-20T09:20:14Z
2022/04/27 21:57:10 [84620] Acquiring process lock
2022/04/27 21:57:14 [45604] CNI_COMMAND environment variable set to ADD
2022/04/27 21:57:14 [45604] [Azure-Utils] ver
2022/04/27 21:57:14 [45604] Formatted Boot time: 2022-04-20T09:20:14Z
2022/04/27 21:57:14 [45604] Acquiring process lock
2022/04/27 21:57:16 [37520] [cni] Failed to lock store: timed out locking store.
2022/04/27 21:57:16 [37520] Failed to initialize key-value store of network plugin: timed out locking store
2022/04/27 21:57:16 [37520] Report plugin error

What you expected to happen:
A pod can be created after a load test.
How to reproduce it:
Load a windows node with many pods as fast as possible and delete them. Then attempt to create a single pod on that node. Repeat ad nauseum since this is intermittent.
Orchestrator and Version (e.g. Kubernetes, Docker):
Kubernetes, 1.21.7
Containerd, 1.6.1
Operating System (Linux/Windows):
Windows
Kernel (e.g. uanme -a for Linux or $(Get-ItemProperty -Path "C:\windows\system32\hal.dll").VersionInfo.FileVersion for Windows):
10.0.17763.2686 (WinBuild.160101.0800)
Anything else we need to know?:
[Miscellaneous information that will assist in solving the issue.]
It seems like something has the file lock indefinitely. During a normal time frame the log Released process lock happens all the time but, before this issue happens, I don't see Released process lock at then end of some requests (particularly CNI_COMMAND set to DEL). This may be a red herring (follow [78164] below):
2022/04/27 21:46:02 [78164] CNI_COMMAND environment variable set to DEL
2022/04/27 21:46:02 [78164] [Azure-Utils] ver
2022/04/27 21:46:02 [78164] Formatted Boot time: 2022-04-20T09:20:14Z
2022/04/27 21:46:02 [78164] Acquiring process lock
2022/04/27 21:46:02 [78164] Acquired process lock
2022/04/27 21:46:02 [78164] Connected to telemetry service
2022/04/27 21:46:02 [78164] [cni-net] Plugin azure-vnet version v1.4.22.
2022/04/27 21:46:02 [78164] [cni-net] Running on windows
2022/04/27 21:46:02 [78164] [net] Network interface: {Index:5 MTU:1500 Name:vEthernet (Ethernet 2) HardwareAddr:00:0d:3a:22:93:5b Flags:up|broadcast|multicast} with IP: [fe80::5026:2a15:7716:180e/64 <IP_ADDRESS>/22]
2022/04/27 21:46:02 [78164] [net] Network interface: {Index:1 MTU:-1 Name:Loopback Pseudo-Interface 1 HardwareAddr: Flags:up|loopback|multicast} with IP: [::1/128 <IP_ADDRESS>/8]
2022/04/27 21:46:02 [78164] [net] Restored state, &{Version:v1.4.22 TimeStamp:2022-04-27 21:45:51.1786315 +0000 UTC ExternalInterfaces:map[vEthernet (Ethernet 2):0xc00004a100] store:0xc000142940 netlink:0x2246b20 netio:0x2246b20 plClient:0x2246b20 Mutex:{state:0 sema:0}}
2022/04/27 21:46:02 [78164] External Interface &{Name:vEthernet (Ethernet 2) Networks:map[azure:0xc000107520] Subnets:[<IP_ADDRESS>/22] BridgeName: DNSInfo:{Suffix: Servers:[] Options:[]} MacAddress:00:0d:3a:22:93:5b IPAddresses:[] Routes:[] IPv4Gateway:<IP_ADDRESS> IPv6Gateway:::}
2022/04/27 21:46:02 [78164] Number of endpoints: 43
2022/04/27 21:46:02 [78164] [cni-net] Plugin started.
2022/04/27 21:46:02 [78164] [cni-net] Processing DEL command with args {ContainerID:205288a5f9183f171ab50bf5560eb2ee5fb0b050e1a8848a4b443c83597adc9c Netns:b4ae0496-fb36-41df-81e2-f16016f3d546 IfName:eth0 Args:K8S_POD_NAMESPACE=laserprocloud-default-tmp973ae381pr41663;K8S_POD_NAME=b6f89650-b71b-4bb8-8f90-dc5f33e029b2-76d69f94d9-tnwl2;K8S_POD_INFRA_CONTAINER_ID=205288a5f9183f171ab50bf5560eb2ee5fb0b050e1a8848a4b443c83597adc9c;K8S_POD_UID=5c059fa1-66cc-4faf-8318-fa4a1ac0a649;IgnoreUnknown=1 Path:c:/k/azurecni/bin, StdinData:{"AdditionalArgs":[{"Name":"EndpointPolicy","Value":{"ExceptionList":["<IP_ADDRESS>/22","<IP_ADDRESS>/18"],"Type":"OutBoundNAT"}},{"Name":"EndpointPolicy","Value":{"DestinationPrefix":"<IP_ADDRESS>/16","NeedEncap":true,"Type":"ROUTE"}},{"Name":"EndpointPolicy","Value":{"Action":"Block","Direction":"Out","Priority":200,"Protocols":"6","RemoteAddresses":"<IP_ADDRESS>/32","RemotePorts":"80","RuleType":"Switch","Type":"ACL"}},{"Name":"EndpointPolicy","Value":{"Action":"Allow","Direction":"In","Priority":65500,"Type":"ACL"}},{"Name":"EndpointPolicy","Value":{"Action":"Allow","Direction":"Out","Priority":65500,"Type":"ACL"}}],"bridge":"azure0","capabilities":{"dns":true,"portMappings":true},"cniVersion":"0.3.0","dns":{"Nameservers":["<IP_ADDRESS>","<IP_ADDRESS>"],"Search":["svc.cluster.local"]},"ipam":{"type":"azure-vnet-ipam"},"mode":"bridge","name":"azure","runtimeConfig":{"dns":{"Servers":["<IP_ADDRESS>"],"Searches":["laserprocloud-default-tmp973ae381pr41663.svc.cluster.local","svc.cluster.local","cluster.local"],"Options":["ndots:5"]}},"type":"azure-vnet","windowsSettings":{"enableLoopbackDSR":true}}}.
2022/04/27 21:46:02 [78164] [cni-net] Read network configuration &{CNIVersion:0.3.0 Name:azure Type:azure-vnet Mode:bridge Master: AdapterName: Bridge:azure0 LogLevel: LogTarget: InfraVnetAddressSpace: IPV6Mode: ServiceCidrs: VnetCidrs: PodNamespaceForDualNetwork:[] IPsToRouteViaHost:[] MultiTenancy:false EnableSnatOnHost:false EnableExactMatchForPodName:false DisableHairpinOnHostInterface:false DisableIPTableLock:false CNSUrl: ExecutionMode: Ipam:{Type:azure-vnet-ipam Environment: AddrSpace: Subnet: Address: QueryInterval:} DNS:{Nameservers:[<IP_ADDRESS> <IP_ADDRESS>] Domain: Search:[svc.cluster.local] Options:[]} RuntimeConfig:{PortMappings:[] DNS:{Servers:[<IP_ADDRESS>] Searches:[laserprocloud-default-tmp973ae381pr41663.svc.cluster.local svc.cluster.local cluster.local] Options:[ndots:5]}} WindowsSettings:{EnableLoopbackDSR:true} AdditionalArgs:[{Name:EndpointPolicy Value:[123 34 69 120 99 101 112 116 105 111 110 76 105 115 116 34 58 91 34 49 48 46 50 48 54 46 51 54 46 48 47 50 50 34 44 34 49 48 46 50 48 54 46 48 46 48 47 49 56 34 93 44 34 84 121 112 101 34 58 34 79 117 116 66 111 117 110 100 78 65 84 34 125]} {Name:EndpointPolicy Value:[123 34 68 101 115 116 105 110 97 116 105 111 110 80 114 101 102 105 120 34 58 34 49 48 48 46 57 49 46 48 46 48 47 49 54 34 44 34 78 101 101 100 69 110 99 97 112 34 58 116 114 117 101 44 34 84 121 112 101 34 58 34 82 79 85 84 69 34 125]} {Name:EndpointPolicy Value:[123 34 65 99 116 105 111 110 34 58 34 66 108 111 99 107 34 44 34 68 105 114 101 99 116 105 111 110 34 58 34 79 117 116 34 44 34 80 114 105 111 114 105 116 121 34 58 50 48 48 44 34 80 114 111 116 111 99 111 108 115 34 58 34 54 34 44 34 82 101 109 111 116 101 65 100 100 114 101 115 115 101 115 34 58 34 49 54 56 46 54 51 46 49 50 57 46 49 54 47 51 50 34 44 34 82 101 109 111 116 101 80 111 114 116 115 34 58 34 56 48 34 44 34 82 117 108 101 84 121 112 101 34 58 34 83 119 105 116 99 104 34 44 34 84 121 112 101 34 58 34 65 67 76 34 125]} {Name:EndpointPolicy Value:[123 34 65 99 116 105 111 110 34 58 34 65 108 108 111 119 34 44 34 68 105 114 101 99 116 105 111 110 34 58 34 73 110 34 44 34 80 114 105 111 114 105 116 121 34 58 54 53 53 48 48 44 34 84 121 112 101 34 58 34 65 67 76 34 125]} {Name:EndpointPolicy Value:[123 34 65 99 116 105 111 110 34 58 34 65 108 108 111 119 34 44 34 68 105 114 101 99 116 105 111 110 34 58 34 79 117 116 34 44 34 80 114 105 111 114 105 116 121 34 58 54 53 53 48 48 44 34 84 121 112 101 34 58 34 65 67 76 34 125]}]}.
2022/04/27 21:46:02 [78164] Get number of endpoints for ifname vEthernet (Ethernet 2) network azure
2022/04/27 21:46:02 [78164] Execution mode :
2022/04/27 21:46:02 [78164] Trying to retrieve endpoint id 205288a5-eth0
2022/04/27 21:46:02 [78164] Deleting endpoint:205288a5-eth0
2022/04/27 21:46:02 [78164] [net] Deleting endpoint 205288a5-eth0 from network azure.
2022/04/27 21:46:02 [78164] Trying to retrieve endpoint id 205288a5-eth0
2022/04/27 21:46:02 [78164] [net] Deleting hcn endpoint with id: b224a8c0-e093-4104-b397-4b8208c238b1
2022/04/27 21:46:11 [59832] CNI_COMMAND environment variable set to ADD
2022/04/27 21:46:11 [59832] [Azure-Utils] ver
2022/04/27 21:46:11 [59832] Formatted Boot time: 2022-04-20T09:20:14Z
2022/04/27 21:46:11 [59832] Acquiring process lock
2022/04/27 21:46:20 [65268] CNI_COMMAND environment variable set to DEL
2022/04/27 21:46:20 [65268] [Azure-Utils] ver
2022/04/27 21:46:20 [65268] Formatted Boot time: 2022-04-20T09:20:14Z
2022/04/27 21:46:20 [65268] Acquiring process lock
2022/04/27 21:46:20 [66304] CNI_COMMAND environment variable set to DEL
2022/04/27 21:46:20 [66304] [Azure-Utils] ver
2022/04/27 21:46:20 [66304] Formatted Boot time: 2022-04-20T09:20:14Z
2022/04/27 21:46:20 [66304] Acquiring process lock
2022/04/27 21:46:21 [84160] CNI_COMMAND environment variable set to DEL
2022/04/27 21:46:21 [84160] [Azure-Utils] ver
2022/04/27 21:46:21 [59832] [cni] Failed to lock store: timed out locking store.
2022/04/27 21:46:21 [59832] Failed to initialize key-value store of network plugin: timed out locking store
2022/04/27 21:46:21 [59832] Report plugin error

@michaeltison-dh can you check your CNI version?  $ azure-vnet version
I am expecting that you have < v1.4.16, which is the version that we fixed this issue in. During high system load, it was possible that the CNI did not cleanly release the lock, and the dangling lock prevents subsequent invocations of the CNI from proceeding.
v1.4.22 is rolling out to AKS as we speak, is that where you are encountering this issue?

@rbtr Based on the azure-vnet.log & azure-vnet.json I believe it is version v1.4.22 that is in use for this cluster:

@michaeltison-dh Looks like hns got stuck in delete endpoint. @daschott can you involve appropriate members to look into this. issue. we have been seeing many hns hung issues lately

I am facing same issue too,  cni stuck in delete endpoint.

@Rohit-MSFT fyi..this is another issue where hns stuck in delete endpoint

Any update? It is a big problem for us, we have to restart windows nodes to recover frequently.

@zhiweiv, Microsoft product group is looking into it still with no answer to why hns is stuck in deleting an endpoint. We are currently using Windows Server 2019 images and hopefully the next update resolves it: https://github.com/Azure/azure-container-networking/issues/774#issuecomment-1143886411
The issue is very intermittent and I haven't seen it for about a week now.

We currently have the Windows image that was specified here, was released for windows server 2019 on 7/25: https://github.com/Azure/azure-container-networking/issues/774#issuecomment-1143886411
We are monitoring right now.

Still seeing timed out locking store with Windows version 10.0.17763.3232, seems it is not fully fixed per  https://github.com/Azure/azure-container-networking/issues/774#issuecomment-1217003488.

Still experiencing these failures in AKSWindows-2022-containerd-20348.1249.221202

Also getting this issue in Windows 2022, are their any updates to this issue? We are almost 8 months since it has been reported

@MugzyMoreno Apologies for the delay.. I will follow up internally with another team to debug this..

@MugzyMoreno when it repro again, can you please run this c:\k\azurecni\debug\collectlogs.ps1 from powershell and upload the zip here. Also leave VM untouched(don't reboot)

Can do @tamilmani1989

Issue is still reproduced in our AKS with windows nodes.


Landing page: nav link to hop to an anchor

Link "What's Oma.helsinki?" in navigation should point to an anchor on the same page.
Anchor after hero. As specified in early consepts.

This issue is obsolite. Closing.


Fix deepsource

Description
Address: https://github.com/astronomer/astro-sdk/pull/1555#issuecomment-1377189333
What is the current behavior?
Fix some deepsource issues
Does this introduce a breaking change?
No
Checklist

[ ] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

codecov is failing - please check it

https://github.com/astronomer/astro-sdk/pull/1568

I'm merging this if need a test for below will add in a separate PR
if new_cluster_specs:
        log.debug("creating new spark cluster with spec %s", new_cluster_specs)


No need to consume a ref at the end of a recover block

Currently the compiler requires the "consume" at the end of this recover block:
let a: String iso = recover

  let b: String ref = String

  consume b

end

However, since any ref inside a recover block was declared inside the block and that all its aliases will be destroyed when leaving the block, there is no need to explicitly consume.

@jemc would this case be covered by auto-recover?

No, I think this counts as a separate enhancement.


[BUG] Can't get all changed files after pushing new commit

Is there an existing issue for this?

[X] I have searched the existing issues

Does this issue exist in the latest version?

[X] I'm using the latest release

Describe the bug?
I want to get all changed files over entire PR after each push event (after adding new commit as well). But i always get changed files from the last commit only. I guess, that i am doing something wrong, so, could you please direct me in a right way
To Reproduce
name: Echo Pull Request
on:
push:
pull_request:
jobs:
echo:
runs-on: ubuntu-latest
name: Echo Changed Files
steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
  - name: Get changed files
    id: changed-files
    uses: tj-actions/changed-files@v29

  - name: List all changed files
    run: |
      for file in ${{ steps.changed-files.outputs.all_changed_files }}; do
        echo "$file was changed"
      done

What OS are you seeing the problem on?
ubuntu-latest or ubuntu-20.04
Expected behavior?
Expect to iterate over all changed files in a PR
Relevant log output
No response
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@okorepanov To achieve that you’ll need to use.
name: CI

on:
  pull_request:
    branches:
      - main

jobs:
  build:
    runs-on: ubuntu-latest
    name: Test changed-files
    steps:
      - uses: actions/checkout@v3
        with:
          fetch-depth: 0

      - name: Get changed files
        id: changed-files
        uses: tj-actions/changed-files@v29

      - name: List all changed files
        run: |
          for file in ${{ steps.changed-files.outputs.all_changed_files }}; do
            echo "$file was changed"
          done

You can also checkout the examples for more information on each input

@jackton1 Could you please explain how did this work before in v29 for pull requests, without the need to fetch the entire repo's history?

@alpeb This worked previously because the target branch history was also pulled.
See: https://github.com/tj-actions/changed-files/pull/654
I've decided to add this back since the checkout action doesn't have first-class support.

@alpeb The fix has been deployed

That's cool, thanks a lot!


Fix the webflux-r2dbc sample

Do not merge - needs clarification for trigger h2 setup!
The first of the two commits fixes the issue with the ReactiveCrudRepository not being picked up due to failing checks for reactive adapters in the ReactiveAdapterRegistry, which is checking for Flux where the Hint for _r2dbconly providesMono`.
The 2nd commit adds hints for setting up the required embedded h2 instance. All the changes in here should move to a dedicated place and not reside in the Hints for r2dbc.

Merged and polished via https://github.com/spring-projects-experimental/spring-graalvm-native/commit/9f5208bb6af15c4105f021848e6b1364d7ff4740. Thanks!


x/vuln:

What version of Go are you using (go version)?

$ go version

Does this issue reproduce at the latest version of golang.org/x/vuln?
What operating system and processor architecture are you using (go env)?
go env Output
$ go env

What did you do?

What did you expect to see?
What did you see instead?

go env


Create sign up screen

This PR adds a signup form when clicking 'sign up' on the home page. This will create a user that is associated with a new author in the backend.
There are tests to ensure that registration will log you in as this new user and enforces a user can't create a user with an existing display name.

Might be better to use a built-in Django form for user creation? In particular the UserCreationForm from django.contrib.auth.forms. This automatically adds a validation field and hides the password as it is typed (see image)

On a more inconsequential note: there is still print statement on line 68 in views.py

Might be better to use a built-in Django form for user creation? In particular the UserCreationForm from django.contrib.auth.forms. This automatically adds a validation field and hides the password as it is typed (see image). This would necessitate a change in the register tests to add the password verification field.
On a more inconsequential note: there is still print statement on line 68 in views.py. Other than that looks good to merge👍

Good catch on the print statement!
It'll be easier if the form gets updated on my next PR since I had to add in some logic for the auth control in the view. I'll go update that branch now! If nobody else sees any issues with the PR can they merge it in please?


API Not Working

We have it said to highest security / process time.
We have it set so that it goes to pending payment immediately, and then when the payment is completed it should go to the Processing status in WooCommerce.
However this never happens - it gets stuck in pending payment unless you manually update it.
Any idea why?
Thanks

Hey Shawaj,
Sorry we overlooked this issue. Does your problem still persist or should we still take a look into it? Looks like it's a problem with the IPN handling code.
If you still do have a problem, can you tell me the plugin version and woocommerce version?


Base64 encode request and response bodies if not valid UTF-8

This is done to avoid marshalling errors that occur during calls to PutMock and GetMocks methods on Keploy GRPC service due to request and/or response bodies containing characters that are not valid UTF-8.

@slayerjain can you please take a look at this?

@thunderboltsid now that I think of this. We could do this in the keploy server. It'll fix the issue for other SDKs too.
WDYT?

Also, the body type is currently string. We modelled it as a string because I thought the HTTP body would always be a string.

Also, the body type is currently string. We modelled it as a string because I thought the HTTP body would always be a string.

That would require you to change the type of the field in the message (potentially backward-incompatible change) or add a new field and deprecate the old one.

you're right. What do you suggest?
IMO keeping the body string is not going to be scalable.

Just a byte array (bytes) is probably a better choice. Same max-length requirement as a string.

Thanks for the PR. Closing this one as it makes more sense to directly add to keploy.


Bug: /route-plans endpoint returns static 'ID' instead of dynamically generated plan ID

Describe the bug
The /route-plans endpoint always returns the string "ID" instead of a unique identifier for the created route plan. This makes it impossible to track or query the created route plan properly.
Expected behavior
The endpoint should return a dynamically generated unique identifier for each created route plan, allowing clients to use the ID to track or query the plan.
Actual behavior
The endpoint always returns "ID" as a literal string, which is not a valid or useful identifier.
To Reproduce
Send a POST request to http://localhost:8080/route-plans with a JSON file, like the example in the demo ui guide:
curl -X POST -H 'Content-Type:application/json' http://localhost:8080/route-plans<EMAIL_ADDRESS>
Observe that the response is "ID".
Environment
Timefold Solver Version or Git ref: Commit e71f1793277391beb91b75515adfc9d6cd9e30f0 (on branch main)
Output of java -version:
openjdk 23 2024-09-17
OpenJDK Runtime Environment (build 23)
OpenJDK 64-Bit Server VM (build 23, mixed mode, sharing)

Additional information
This issue appears to be caused by the solve_route function in the server code, which returns a hardcoded string "ID" instead of generating a unique identifier. The relevant part of the code is:
@app.post("/route-plans")
async def solve_route(route: Annotated[VehicleRoutePlan, Depends(setup_context)]) -> str:
    data_sets['ID'] = route
    solver_manager.solve_and_listen('ID', route,
                                    lambda solution: update_route('ID', solution))
    return 'ID'

Suggested fix: Replace the hardcoded "ID" with a dynamically generated unique ID.

The Java quickstarts originally also used a static ID to simplify the model (don't need to worry about cleaning up a database/map entries if there is only one problem/solution that can exist).
The Python quickstart was originally developed as a copy of said old model.
However, looking at the current Java quickstart code, they now generate a UUID, so the Python quickstart should change to match.
(that being said, it would have the same issue of eventually running out of memory without cleanup).

Thanks for the fix, @Christopher-Chianelli!
That said, @CatonTheRoRo, the quickstarts exist to show you the basics of using the solver, and to get you started quickly. Please keep in mind that it has never been the goal to cover all cases of all possible production use cases - we ignore a lot of concerns for the sake of brevity and simplicity.


Refactor using Js classes

This branch updates the previous feature (add and remove books from list/local storage) by using JavaScript classes.
-Refactored previos JavaScript code
-Updated styles to match medium wireframe

Hi @mckent05,
I hope you're doing well. I'm writing to ask for some additional guidance on how to fix the "Missing script: start" error that I encountered when running the "npm run" command.
I'm not sure what specifically needs to be added or changed in the file to fix this error.
Could you please provide me with more detailed guidance on how to fix this error? Any additional information you can provide would be greatly appreciated.
Thank you for your help!


"Bad CPU type in executable" with macOS Catalina

After upgrading to macOS Catalina, I'm not able to run commands like dcos kubernetes cluster create.
Here is what I get when I try to create a cluster:
dcos -vv kubernetes cluster create --yes --options="cluster-options.json" --package-version="2.3.0-1.14.1"

Loading plugin 'dcos-core-cli'...
Loading plugin 'kubernetes'...
fork/exec /Users/theo/.dcos/clusters/<UUID>/subcommands/kubernetes/env/bin/dcos-kubernetes: bad CPU type in executable

I suspect the upgrade to Catalina to be the issue 💥

The CLI was updated in v2.4.4-1.15.5. Please try installing it first with:
dcos package install --cli kubernetes --package-version="2.4.4-1.15.4"

Thanks!

@Falydoor can we close this?


Get-WinEvent on Linux/Ubuntu 16.04

Installed Powershell via the suggested commands however I don't seem to have access to Get-WinEvent. The functionality I'm looking for is to take a EVTX file and output to JSON, probably using ConvertTo-Json. Happy to hear of another way to convert EVTX. TIA!
> Get-WinEvent
Get-WinEvent : The term 'Get-WinEvent' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1
+ Get-WinEvent
+ ~~~~~~~~~~~~
+ CategoryInfo          : ObjectNotFound: (Get-WinEvent:String) [], CommandNotFoundException
+ FullyQualifiedErrorId : CommandNotFoundException

> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      6.0.0-rc.2
PSEdition                      Core
GitCommitId                    v6.0.0-rc.2
OS                             Linux 4.4.0-31-generic #50-Ubuntu SMP Wed Jul 13 00:07:12 UTC 2016
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Perhaps we get it with WindowsPowerShellCompatibilityPack

Any update on this functionality?

Any update on this functionality?

@defensivedepth The API is Windows-only.

ah, ok, thanks!


strange ".O" (dot-O) files appearing in /etc/cups/

At first I thought these files were created by my package manager, but then I saw that they only appear in /etc/cups and no other places in /etc. Are they being created by CUPS? Where is it documented?
One time I noticed that /etc/cups/cupsd.conf had been replaced by a version with no comments - nothing like the package default, not anything I had created by hand. Is this a bug in CUPS?

The .O files are backup files after cupsd replaces an existing configuration file. This is an implementation-specific detail and not something we have documented (nor shall we).
(but I will note that the use of .O, .bck, ~, and other suffixes on backup files is extremely common)

Thanks. I take it that cupsd edits printers.conf, classes.conf, subscriptions.conf, ppd/*.ppd -- but never cupsd.conf? So my issue with finding a strangely modified cupsd.conf must be unrelated?

It also writes cupsd.conf, based on what a client sends in a PUT request. cupsctl and the web interface use the cupsAdminGet/SetServerSettings API which parses the cupsd.conf file and writes a new one. This (necessarily) causes the loss of any comments in the original file.

Thank you, that helps clarify some mysteries.
Can I make two suggestions:

cupsd.conf(5), at the bottom of DESCRIPTION add:
This file can be edited manually, but you must restart cupsd
before changes take effect. This file is also regenerated by the
server when cupsctl is invoked, removing any comments in the
process.

conf/cupsd.conf.in, after the initial comments
# Configuration file for the CUPS scheduler.  See "man cupsd.conf" for a
# complete description of this file.

I would add a warning:
# Note that certain invocations of cupsctl cause this file to
# be parsed and regenerated by the server. Please be aware that
# comments are lost in the process.

Wherever cupsd/cupsctl regenerates cupsd.conf, the regenerated file
should start with the above comment text, as well as a timestamp like
I see in printers.conf:
# Written by cupsd on 2018-09-25 04:25

I hope this seems reasonable? Let me know if you want a pull request for these changes.


Using Admission Controllers

Can we add documentation that explains the order in which Mutating Admission Controllers will be called if there exists multiple?

That seems like a useful thing to make clear!
/kind feature
/triage accepted
/sig auth
for https://kubernetes.io/docs/reference/access-authn-authz/admission-controllers/

/remove-lifecycle stale

/remove-lifecycle stale

/remove-sig auth
/sig api-machinery

@kubernetes/sig-api-machinery-misc would anyone from the SIG be willing to pick this one up?

I agree this is useful to document, I've wanted to refer people to this documentation before 😅
@roycaihw, @yliaog, or @caesarxuchao, perhaps?
@sftim sorry, we haven't seen this issue because it's not in the repo that we triage.

(no worries @lavalamp - thanks for coming back promptly when nudged!)

IIUC admission plugins (if enabled) follow the order in this list. Mutating webhooks within one mutatingwebhookconfiguration follow the use-specified order, different mutatingwebhookconfigurations are sorted by name. For example:
kind: MutatingWebhookConfiguration
metadata:
  name: b
webhooks:
- name: d
- name: e
---
kind: MutatingWebhookConfiguration
metadata:
  name: a
webhooks:
- name: g
- name: f

The order will be g -> f -> d -> e.


Link between stack and resources

https://bugzilla.redhat.com/show_bug.cgi?id=1212534
During openstack refresh, stack and its resources, namely instances, networks, and security groups, were not associated.
With this fix, stacks are refreshed before other resources, and a hash from stack's resource id to stack stores the mapping. When refresh the resources, they are connected to theirs stack based on the hash.

@Fryguy Please review


Add old Gradle Icon

Add old Gradle Icon
Changes proposed:

[ X] Add
[ ] Delete
[ ] Fix
[ ] Prepare

File an issue first, please.

I have created the issue a while ago

Thank you. We will look into it in time.


3.20

A team of developers at your company plans to deploy, and then remove, 50 customized virtual
machines each week. Thirty of the virtual machines run Windows Server 2016 and 20 of the
virtual machines run Ubuntu Linux.
You need to recommend which Azure service will minimize the administrative effort required to
deploy and remove the virtual machines.
What should you recommend?
A. Azure Reserved Virtual Machines (VM) Instances
B. Azure virtual machine scale sets
C. Azure DevTest Labs
D. Microsoft Managed Desktop

C


Not considering multiline strings

The line jumps within CDATA elements should transformed into "\n" before being returned, since JSON doesn't accept line jumps.
For instance, when you consider the following element:
cisco", leap=0, stratum=2, rootdelay=1.11, rootdispersion=0.38,
peer=57920, refid=<IP_ADDRESS>, reftime=0xDA9BAF12.99028193, poll=6,
clock=0xALF9B2186.B8101444, phase=0.069, freq=59.98, error=0.02
It is transformed to:
"cisco", leap=0, stratum=2, rootdelay=1.11, rootdispersion=0.38,
peer=57920, refid=<IP_ADDRESS>, reftime=0xDA9BAF12.99028193, poll=6,
clock=0xALF9B2186.B8101444, phase=0.069, freq=59.98, error=0.02"
Which is not readable from json, it should be this instead:
"cisco", leap=0, stratum=2, rootdelay=1.11, rootdispersion=0.38,\npeer=57920, refid=<IP_ADDRESS>, reftime=0xDA9BAF12.99028193, poll=6,\nclock=0xALF9B2186.B8101444, phase=0.069, freq=59.98, error=0.02"

Thanks! Fixed.
P.S. the problem was also in multi-line strings in xml attributes.

Thank you so much! This library is very unique and extremely useful!


Expected more than 1 value per channel when training, input size torch.Size([1, 128])

Hi all!!
I'm having a similar issue as the ones reported here: https://github.com/scverse/scvi-tools/issues/221 and here: https://github.com/scverse/scvi-tools/issues/426.
In my case I'm trying to predict doublets and I have an issue at the very beginning with one of the samples with the following code:

SEED = 35

sc.pp.filter_genes(adata,  min_cells=10)
sc.pp.highly_variable_genes(adata, n_top_genes=2000, subset=True, flavor='seurat_v3')

scvi.settings.seed = SEED

scvi.model.SCVI.setup_anndata(adata)

vae = scvi.model.SCVI(adata)

vae.train()

The dataset size after the filtering steps is: (4409, 2000) and I've seen that the default value for batch_size = 128.
So as others have reported before, I get the following error (there are 45 collapsed lines that I can also show if you believe are needed to understand the problem):
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
[<ipython-input-33-8f71af99b8f8>](https://localhost:8080/#) in <cell line: 10>()
      8
--->  9 vae.train()

45 frames
[/usr/local/lib/python3.10/dist-packages/torch/nn/functional.py](https://localhost:8080/#) in _verify_batch_size(size)
   2414         size_prods *= size[i + 2]
   2415     if size_prods == 1:
-> 2416         raise ValueError("Expected more than 1 value per channel when training, got input size {}".format(size))
   2417
   2418

ValueError: Expected more than 1 value per channel when training, got input size torch.Size([1, 128])

So, when I divide 4409%128 = 57, clearly shows that the last batch shouldn't be of size = 1 and still, I get this error. When I remove on row of the adata object so the size now is (4408, 2000) or if I instead change the batch_size to batch_size!=128 for example:
vae.train(batch_size = 129)

In both cases it works just fine. So could you let me know why it is failing in this case with the original batch_size = 128?
I'm trying to understand the problem but I can't grasp it.
Thanks so much for your time and help!
Josu

Hi Josu, thanks for bringing up this issue. This is occurring because we have a default train-validation split with train_size=0.9. Thus, the number of training observations is computed as train_n_obs = ceil(n_obs * train_size) = ceil(4409 * 0.9) = ceil(3968.1) = 3969 and therefore train_n_obs % 128 = 1. Hope this makes sense!

Hi @martinkim0! That makes perfect sense and I should have thought about this 😅. Thanks so much.
If you have the time and it's not too much of a bother, could you share with me where I can this part of the code in the GitHub repo? You guys have created an amazing library for scRNAseq analysis but, for me at least, is quite difficult and complex to navigate to the code I want to understand. Trying to walk through the steps/functions called in the background when I run, ie vae.train(), isn't that easy for me yet.
Thanks for your answer and help! Really appreciate it.

Hi, sure I can provide some pointers on walking through the traceback. Apologies that the code is not always easy to follow, we could definitely do some work on simplifying the codebase.
SCVI inherits its train method from UnsupervisedTrainingMixin. In this method, we create a DataSplitter instance, where you'll see the default train_size=0.9 being passed in during initialization. If you're already familiar with Lightning, DataSplitter is just a subclass of LightningDataModule with our custom setup.
DataSplitter then validates train_size and computes the actual number of training observations here. We then have a method for creating a train dataloader that samples mini-batches from our subsampled training set.
From there, we're back in the train method, where this DataSplitter is passed into Lightning's Trainer. After that, Lightning handles all training procedures. Hope this helps!

Not your fault at all! It's just that I definitely need some more experience tracing down processes that involve nested code and class inheritance, and I'm not there yet. Your post has been of great help indeed! Thank you so much for taking the time and effort. I do really appreciate it @martinkim0!


Enable resetting config values to default value

Description

Provide reset button to zone,cluster,domain,account,
primary and secondary storage so that config values
can be reset to the default value
Depends on https://github.com/apache/cloudstack/pull/4215
Types of changes

[X] Enhancement (improves an existing feature and functionality)

Screenshots (if appropriate):
Reset button has been provided under zone,cluster, domain, account, primary storage and secondary storage level

How Has This Been Tested?

Tested throguh cmk also
(local) mgt01 > list configurations name=allow.user.expunge.recover.vm accountid=4048bfec-c28e-11ea-9a43-0617bc003377
{
  "configuration": [
    {
      "category": "Advanced",
      "description": "Determines whether users can expunge or recover their vm",
      "isdynamic": true,
      "name": "allow.user.expunge.recover.vm",
      "scope": "account",
      "value": "false"
    }
  ],
  "count": 1
}
(local) mgt01 > update configuration name=allow.user.expunge.recover.vm accountid=4048bfec-c28e-11ea-9a43-0617bc003377 value=true
{
  "configuration": {
    "category": "Advanced",
    "description": "Determines whether users can expunge or recover their vm",
    "isdynamic": true,
    "name": "allow.user.expunge.recover.vm",
    "scope": "account",
    "value": "true"
  }
}

(local) mgt01 > reset configuration name=allow.user.expunge.recover.vm accountid=4048bfec-c28e-11ea-9a43-0617bc003377
{
  "configuration": {
    "category": "Advanced",
    "description": "Determines whether users can expunge or recover their vm",
    "isdynamic": true,
    "name": "allow.user.expunge.recover.vm",
    "scope": "account",
    "value": "false"
  }
}
(local) mgt01 > list configurations name=allow.user.expunge.recover.vm accountid=4048bfec-c28e-11ea-9a43-0617bc003377
{
  "configuration": [
    {
      "category": "Advanced",
      "description": "Determines whether users can expunge or recover their vm",
      "isdynamic": true,
      "name": "allow.user.expunge.recover.vm",
      "scope": "account",
      "value": "false"
    }
  ],
  "count": 1
}

Run integration test case using
nosetests --with-marvin --marvin-config=<cfg file> test_reset_configuration_settings.py

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos7 ✖debian. JID-1655

@rhtyd dont merge this as this depends on #4215

@ravening is this ready for review? (PR still in draft)

@rhtyd yes it's ready for review. It's marked as draft because it can't be merged unless other is merged

@ravening can you check Travis failures

@ravening can you check Travis failures

@rhtyd the build will fail since some functions are missing.
Those functions are defined in another pr

@ravening marking this 4.16 as it is waiting on dependencies. please argue if you disagree.

@ravening marking this 4.16 as it is waiting on dependencies. please argue if you disagree.

I prefer if it can go in 4.15.

@ravening marking this 4.16 as it is waiting on dependencies. please argue if you disagree.

I prefer if it can go in 4.15.

I assumed as much but than can you push for any prerequisite work as well, please? ( I want/prefer is not the argument I was hoping for ;)

@ravening is this still in progress, opened as a draft?

@ravening is this still in progress, opened as a draft?

@rhtyd yes ready for review but depends on #4215

@ravening is this still in progress, opened as a draft?

@rhtyd yes ready for review but depends on #4215

@ravening is the code depending on #4215 or you use-case?

@ravening is this still in progress, opened as a draft?

@rhtyd yes ready for review but depends on #4215

@ravening is the code depending on #4215 or you use-case?

@DaanHoogland yes it depends on other pr as some functions are defined there

@ravening can you fix conflicts, re-send for latest master with changes in the UI (not legacy UI)

@ravening this will need changes in new UI for merge in master

@ravening can you fix conflicts, re-send for latest master with changes in the UI (not legacy UI)

@ravening pl fix the conflicts. Really like the idea of this feature, kindly rebase update to latest main and check the UI changes too, thanks.

ping @ravening can you please resolve the outstanding comments, and fix the code conflicts?

@sureshanaparti @rhtyd please review again

lease review again

@ravening please fix build failures.

lease review again

@ravening please fix build failures.

@ravening since this depends on #4215, can you include #4215 in this pr ?

Ping @ravening

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 1159

Ping @ravening can you fix build failure? I like this feature, would be really useful for users.

Ping @ravening can you fix build failure? I like this feature, would be really useful for users.

@rhtyd this depends on #4215 and thats builds are failing. As @weizhouapache mentioned, shall i merge that pr to this or should I keep it separate?

@ravening if possible can we split the work? So that this PR is simply adding capability in UI/API (for ex. pass the default value in the list API, and let a UI button replace the default value in the text input box when a button is clicked?) to get the default value for the global setting and allow admins to reset to the default value.

@ravening if possible can we split the work? So that this PR is simply adding capability in UI/API (for ex. pass the default value in the list API, and let a UI button replace the default value in the text input box when a button is clicked?) to get the default value for the global setting and allow admins to reset to the default value.

@rhtyd this pr only has the functionality to reset the values to default values. Since the scope involves account, domain and global setting level, some part of the code is present in another pr which has to be merged first to fix the build errors

@ravening is it possible for you to pick those changes from the other PR to this? The other PR has conflicts.

ping @ravening can you close the outstanding comments on this PR.

@ravening
comparing with #4215, I think this had less risk and is more acceptable.
I suggest to remove #4215 from this pr. let's work on this pr and merge it at first.
what's your opinion ? @nvazquez  @sureshanaparti

@ravening
comparing with #4215, I think this had less risk and is more acceptable.
I suggest to remove #4215 from this pr. let's work on this pr and merge it at first.
what's your opinion ? @nvazquez @sureshanaparti

@weizhouapache agree with the riskier part as this introduces new API and no much changes in the existing config code/flow.

I agree with @weizhouapache's proposal. @ravening can you please address that?

@blueorangutan package

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan package

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 1377

Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 1376

@blueorangutan package

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1381

@blueorangutan test

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Ping @ravening is this ready?

@blueorangutan package

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1392

@blueorangutan test

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-2207)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31860 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4230-t2207-kvm-centos7.zip
Smoke tests completed. 90 look OK, 0 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

@ravening Tested reset configuration from API (using cmk) / UI, it is working fine. Noticed the following issues with UI, Can you please check. Thanks.

Global settings UI doesn't have reset configuration button

Scope-level UI shows extra icon/button

Settings @ Primary Storage =>

Settings @ Accounts =>

@weizhouapache i see you have committed two changes. how can i get that? i did rebase but i dont see those commits

@ravening Tested reset configuration from API (using cmk) / UI, it is working fine. Noticed the following issues with UI, Can you please check. Thanks.

Global settings UI doesn't have reset configuration button

Scope-level UI shows extra icon/button

Settings @ Primary Storage =>

Settings @ Accounts =>

@sureshanaparti looks like something messed up.. i will look into it

@weizhouapache i see you have committed two changes. how can i get that? i did rebase but i dont see those commits

@ravening
cannot you fetch the latest commits by "git fetch origin", then checkout to local branch "reset_cfg" and rebase it by "git rebase origin/reset_cfg" ?
(assume 'origin' is the name of repository of github/ravening)

@weizhouapache i see you have committed two changes. how can i get that? i did rebase but i dont see those commits

@ravening
cannot you fetch the latest commits by "git fetch origin", then checkout to local branch "reset_cfg" and rebase it by "git rebase origin/reset_cfg" ?
(assume 'origin' is the name of repository of github/ravening)

@weizhouapache i did
git fetch upstream
git rebase upstream/main
git checkout reset_cfg
git rebase main

after this i didnt get your commits

@weizhouapache i see you have committed two changes. how can i get that? i did rebase but i dont see those commits

@ravening
cannot you fetch the latest commits by "git fetch origin", then checkout to local branch "reset_cfg" and rebase it by "git rebase origin/reset_cfg" ?
(assume 'origin' is the name of repository of github/ravening)

@weizhouapache i did
git fetch upstream
git rebase upstream/main
git checkout reset_cfg
git rebase main

after this i didnt get your commits

git rebase upstream/reset_cfg
not main

@weizhouapache i see you have committed two changes. how can i get that? i did rebase but i dont see those commits

@ravening
cannot you fetch the latest commits by "git fetch origin", then checkout to local branch "reset_cfg" and rebase it by "git rebase origin/reset_cfg" ?
(assume 'origin' is the name of repository of github/ravening)

@weizhouapache i did
git fetch upstream
git rebase upstream/main
git checkout reset_cfg
git rebase main

after this i didnt get your commits

git rebase upstream/reset_cfg
not main

@weizhouapache getting error
git rebase upstream/reset_cfg                                                                                ─╯
fatal: invalid upstream 'upstream/reset_cfg'

git remote -v                                                                                ─╯
origin	https://github.com/ravening/cloudstack.git (fetch)
origin	https://github.com/ravening/cloudstack.git (push)
upstream	https://github.com/apache/cloudstack.git (fetch)
upstream	https://github.com/apache/cloudstack.git (push)

@weizhouapache i see you have committed two changes. how can i get that? i did rebase but i dont see those commits

@ravening
cannot you fetch the latest commits by "git fetch origin", then checkout to local branch "reset_cfg" and rebase it by "git rebase origin/reset_cfg" ?
(assume 'origin' is the name of repository of github/ravening)

@weizhouapache i did
git fetch upstream
git rebase upstream/main
git checkout reset_cfg
git rebase main

after this i didnt get your commits

git rebase upstream/reset_cfg
not main

@weizhouapache getting error
git rebase upstream/reset_cfg                                                                                ─╯
fatal: invalid upstream 'upstream/reset_cfg'

git remote -v                                                                                ─╯
origin	https://github.com/ravening/cloudstack.git (fetch)
origin	https://github.com/ravening/cloudstack.git (push)
upstream	https://github.com/apache/cloudstack.git (fetch)
upstream	https://github.com/apache/cloudstack.git (push)

@ravening please see my previous reply.
cannot you fetch the latest commits by "git fetch origin", then checkout to local branch "reset_cfg" and rebase it by "git rebase origin/reset_cfg" ?
(assume 'origin' is the name of repository of github/ravening)

@weizhouapache i see you have committed two changes. how can i get that? i did rebase but i dont see those commits

@ravening

cannot you fetch the latest commits by "git fetch origin", then checkout to local branch "reset_cfg" and rebase it by "git rebase origin/reset_cfg" ?

(assume 'origin' is the name of repository of github/ravening)

@weizhouapache i did

git fetch upstream

git rebase upstream/main

git checkout reset_cfg

git rebase main

after this i didnt get your commits

git rebase upstream/reset_cfg

not main

@weizhouapache getting error

git rebase upstream/reset_cfg                                                                                ─╯

fatal: invalid upstream 'upstream/reset_cfg'

git remote -v                                                                                ─╯

origin	https://github.com/ravening/cloudstack.git (fetch)

origin	https://github.com/ravening/cloudstack.git (push)

upstream	https://github.com/apache/cloudstack.git (fetch)

upstream	https://github.com/apache/cloudstack.git (push)

@ravening please see my previous reply.

fetch the latest commits by "git fetch origin", then checkout to local branch "reset_cfg" and rebase it by "git rebase origin/reset_cfg"

(assume 'origin' is the name of repository of github/ravening)

@weizhouapache  that is resulting in conflict in unrelated files

@weizhouapache that is resulting in conflict in unrelated files

@ravening
it might be cause your directory is not clean, for example there are some untracked file, uncommitted changes, etc
you can remove local branch reset-cfg, then checkout it again.

@weizhouapache that is resulting in conflict in unrelated files

@ravening
it might be cause your directory is not clean, for example there are some untracked file, uncommitted changes, etc
you can remove local branch reset_cfg, then checkout it again.

yes, @weizhouapache is right,
I think you better remove local branches reset_cfg and main. next
git fetch origin
git fetch upstream
git checkout -b main upstream/main
git checkout -b reset_cfg origin/reset_cfg
git rebase main

your original plan to,
git fetch upstream
git rebase upstream/main
git checkout reset_cfg
git rebase main

, should have worked unless you had leftovers that were in the way, or not the latest of either repo, which might have caused a conflict.
Have a look at git rebase --help, it is easy to mess up a bit, but hard to cause real damage, don't worry(, be happy).

@sureshanaparti I pushed the new ui changes. you can test it again

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1423

@blueorangutan ui

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4230 (SL-JID-705)

@ravening
when I reset a global setting account.cleanup.interval, it does not work
2021-09-28 15:02:49,981 WARN  [c.c.c.ConfigurationManagerImpl] (qtp1840903588-16:ctx-b50154f5 ctx-d20a74f0) (logid:3ee4ec69) Probably the component manager where configuration variable account.cleanup.interval is defined needs to implement Configurable interface
2021-09-28 15:02:49,993 INFO  [c.c.a.ApiServer] (qtp1840903588-16:ctx-b50154f5 ctx-d20a74f0) (logid:3ee4ec69) Config parameter with name account.cleanup.interval doesn't exist

There are some configurations which are defined in Config.java, we need to take a look at these configurations.

@ravening when I reset a global setting account.cleanup.interval, it does not work
2021-09-28 15:02:49,981 WARN  [c.c.c.ConfigurationManagerImpl] (qtp1840903588-16:ctx-b50154f5 ctx-d20a74f0) (logid:3ee4ec69) Probably the component manager where configuration variable account.cleanup.interval is defined needs to implement Configurable interface
2021-09-28 15:02:49,993 INFO  [c.c.a.ApiServer] (qtp1840903588-16:ctx-b50154f5 ctx-d20a74f0) (logid:3ee4ec69) Config parameter with name account.cleanup.interval doesn't exist

There are some configurations which are defined in Config.java, we need to take a look at these configurations.

@weizhouapache even I saw that.. some settings are not found in config store and they cant be reset but there are some others in config depot and we can reset them

@ravening when I reset a global setting account.cleanup.interval, it does not work
2021-09-28 15:02:49,981 WARN  [c.c.c.ConfigurationManagerImpl] (qtp1840903588-16:ctx-b50154f5 ctx-d20a74f0) (logid:3ee4ec69) Probably the component manager where configuration variable account.cleanup.interval is defined needs to implement Configurable interface
2021-09-28 15:02:49,993 INFO  [c.c.a.ApiServer] (qtp1840903588-16:ctx-b50154f5 ctx-d20a74f0) (logid:3ee4ec69) Config parameter with name account.cleanup.interval doesn't exist

There are some configurations which are defined in Config.java, we need to take a look at these configurations.

@weizhouapache even I saw that.. some settings are not found in config store and they cant be reset but there are some others in config depot and we can reset them

@ravening I think, it is better to have the reset operation for all the configuration settings, irrespective of where they are.

@weizhouapache @sureshanaparti @ravening , maybe this is a good time to phase out the old config conpletely and move the remaining config items to appropriate modules? I'm not sure how big an effort it will still be, but it will be a good cleanup.

@ravening
since #4215 has been merged into master, you need to rebase this PR with main branch, and make some necessary changes.

@ravening when I reset a global setting account.cleanup.interval, it does not work
2021-09-28 15:02:49,981 WARN  [c.c.c.ConfigurationManagerImpl] (qtp1840903588-16:ctx-b50154f5 ctx-d20a74f0) (logid:3ee4ec69) Probably the component manager where configuration variable account.cleanup.interval is defined needs to implement Configurable interface
2021-09-28 15:02:49,993 INFO  [c.c.a.ApiServer] (qtp1840903588-16:ctx-b50154f5 ctx-d20a74f0) (logid:3ee4ec69) Config parameter with name account.cleanup.interval doesn't exist

There are some configurations which are defined in Config.java, we need to take a look at these configurations.

@weizhouapache even I saw that.. some settings are not found in config store and they cant be reset but there are some others in config depot and we can reset them

@ravening I think, it is better to have the reset operation for all the configuration settings, irrespective of where they are.

@sureshanaparti the reset option is available under domain/account/global scope

@ravening can you plase rebase against latest main branch?

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1506

@blueorangutan package

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1511

@blueorangutan package

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1513

@ravening
I think you need to revert https://github.com/apache/cloudstack/commit/5c188736ea09ecd04c26e2992b8da8bb1ac07f4b, and part of https://github.com/apache/cloudstack/commit/8bff4888183db43283ecc2dc985165da2b1b4d2b, right ?

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 1731

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1760

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1761

@blueorangutan test

Trillian test result (tid-2574)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31189 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4230-t2574-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

@ravening @sureshanaparti is this ready for merge now?

@blueorangutan package

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1952

@blueorangutan test

Ping @ravening is this ready for review/testing, needs any rebasing or fixing?
@blueorangutan package

@rohityadavcloud a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 2043

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2054

@blueorangutan test

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-2760)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31687 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4230-t2760-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

@blueorangutan package

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2064

@blueorangutan test

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-2767)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31131 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4230-t2767-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File