Why doesn't gitleaks find my committed secrets?

So I recently added a secret to on of our repos by accident. To prevent this from happening in the future I found this repo. I downloaded the linux binary and I tested it but it doesn't seem to find the secret I comitted at all.
The password I committed is in the README.md and was formed as follows:
export OURCOMPANYNAME_OBJECTSTORE_PASSWORD=16_character_random_string

I added the binary to the root of my repo and then tried the following command (the README.md in which I committed the password is also in the root dir of the repo):
$ ./gitleaks-linux-amd64 --repo-path=.
INFO[2019-10-16T16:01:58+02:00] opening .
INFO[2019-10-16T16:02:39+02:00] No leaks detected. 141 commits inspected in 40 seconds 622 milliseconds

The name of the constant I committed even includes the word PASSWORD in there so I presumed that would be the simplest thing to find.
Am I doing something wrong? Am I misunderstanding what this project should be doing? Or is this some kind of extremely rare exception that it can't find it?
All tips are welcome!

The name of the constant I committed even includes the word PASSWORD in there so I presumed that would be the simplest thing to find.
...
Am I doing something wrong? Am I misunderstanding what this project should be doing?

Finding secrets is harder than just searching for "password"—if the rules are too general you will get a significant number of false-positives, and the results won't be useful.
The default search rules look for patterns of known secrets like API keys, private keys, etc. However, you can provide a custom rule configuration to search for more stuff.
I've been compiling my own set of patterns, and plan to open a PR with them soon.

What @rgmz said, finding a general secret is tricky. Check out the example configs: https://github.com/zricethezav/gitleaks/tree/master/examples. Here's an example of a rule that looks for a "key" which defines a regex and an entropy range. Use both entropy and regex to get the best results.


Page 5901 Service Order Subform/Page 5905 Service Lines - make local functions external

Thanks.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Update to ungoogled-chromium-112.0.5615.49 + CI maintenance

Notes:

Chromium changes:

Removed fix-python-path.patch, since the issue was fixed upstream.

CI changes:

Updated actions/checkout, actions/download-artifact and actions/upload-artifact.

This makes uploads slower for some reason, so I've given each job an additional 20 minutes to finish uploading and added an extra job to make up for the lost time.

Replaced actions/create-release with softprops/action-gh-release, since create-release is unmaintained. I'm not too happy about using a third-party action, but it seems to be at least somewhat maintained and relatively widely used.

In other news, it seems that LLVM has ceased to provide x86_64-apple-darwin binaries, since they are missing from all post-15.0.7 releases. I guess that's because all the binaries hosted there are currently volunteer-provided. I've set up my own buildbot to provide LLVM binaries here, but I didn't use those in this PR since that build violate the repo-management standards, though I guess the current situation does as well.

LGTM!
I was thinking about a sweep through all repositories, tagging actions with the commit hashes in order to avoid third party manipulation as a whole later but I think using the create-release one is fine for now.
When will those LLVM builds be required for releases here?

uh I don't quite follow? I meant that the third party release action is fine to use if that was unclear

Is it supposed to build for pull_request?

Shouldn't #103 prevent this?


Window::get_mouse_pos with mode set to MouseMode::Discard returns last obtained location instead of None

This occurs on Fedora 39 running Wayland 1.22. I get the feeling that this is not unexpected from the few other Wayland related issues. I just wanted to document the situation.

Thanks! Yeah, there are many Wayland issues currently :/ I will need to tackle them one day


ng g app name --routing does not create routing module

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)
- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [x] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

node: v8.11.4
npm: 6.4.1
ng: 6.1.2
Repro steps

create-nx-workspace test (not sure it does matter, but this was my path)
cd test
ng g app core --routing

The log given by the failure

CREATE apps/core-e2e/protractor.conf.js (752 bytes)
CREATE apps/core-e2e/tsconfig.e2e.json (235 bytes)
CREATE apps/core-e2e/src/app.e2e-spec.ts (300 bytes)
CREATE apps/core-e2e/src/app.po.ts (207 bytes)
CREATE apps/core/browserslist (375 bytes)
CREATE apps/core/karma.conf.js (481 bytes)
CREATE apps/core/tsconfig.app.json (221 bytes)
CREATE apps/core/tsconfig.spec.json (280 bytes)
CREATE apps/core/tslint.json (245 bytes)
CREATE apps/core/src/favicon.ico (5430 bytes)
CREATE apps/core/src/index.html (289 bytes)
CREATE apps/core/src/main.ts (370 bytes)
CREATE apps/core/src/polyfills.ts (3194 bytes)
CREATE apps/core/src/test.ts (642 bytes)
CREATE apps/core/src/styles.scss (80 bytes)
CREATE apps/core/src/assets/.gitkeep (0 bytes)
CREATE apps/core/src/environments/environment.prod.ts (51 bytes)
CREATE apps/core/src/environments/environment.ts (631 bytes)
CREATE apps/core/src/app/app.module.ts (485 bytes)
CREATE apps/core/src/app/app.component.scss (0 bytes)
CREATE apps/core/src/app/app.component.html (602 bytes)
CREATE apps/core/src/app/app.component.spec.ts (1084 bytes)
CREATE apps/core/src/app/app.component.ts (208 bytes)
UPDATE angular.json (3979 bytes)
UPDATE package.json (2462 bytes)
UPDATE nx.json (277 bytes)

Desired functionality

Expected result: should also see CREATE apps/core/src/app/app-routing.module.ts
and have this module imported into core app module
CLI offers --routing option when you run ng g app --help, so my assumption is that the expected result is legit.
Mention any other details that might be useful

Hi, can you please provide the output of ng version, Also is this reproducible using angular cli directly?

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/

Angular CLI: 6.1.2
Node: 8.11.4
OS: darwin x64
Angular: 6.1.7
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.7.5
@angular-devkit/build-angular     0.7.5
@angular-devkit/build-optimizer   0.7.5
@angular-devkit/build-webpack     0.7.5
@angular-devkit/core              0.7.5
@angular-devkit/schematics        0.7.2
@angular/cli                      6.1.2
@ngtools/webpack                  6.1.5
@schematics/angular               0.7.2
@schematics/update                0.7.2
rxjs                              6.3.2
typescript                        2.7.2
webpack                           4.9.2

Nope, within  non-nx project, the routing module does get created.

@moniuch This is not an issue with @angular/cli. The routing configuration is found within your main app.module.ts.

I'm sorry, but this issue is not caused by Angular CLI as when generating an application with --routing it does get created.
Please contact the author(s) of the NX project or file an issue on their issue tracker.

I can confirm issue, if I understand documentation correctly.

I am making a following call:
1.1 ng generate application sub-app --routing=true --minimal=true
I am expecting to see new application under /projects
2.1 New application is present
2.2 No *-routing.module.ts though for this application

Cli information:
> ng --version

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/

Angular CLI: 7.0.7
Node: 10.14.2
OS: win32 x64
Angular: 7.2.14


Easier way to find the emergency reason

Currently we manage emerngey with diagnostics, and we can see its reasons on rqt_robot/runtime_monitor.
However, we do not always run rqt_robot/runtime_monitor, so if the emergency occurrs, we have to run rqt_robot/runtime_monitor and reprocude the emergency again to find the reason.
IMO, it's better to output emergency reason when it occurrs in standart output log with RCLCPP_WARN/ERR_THROTTLE (WARN for latent fault, and ERROR for single point fault), in order to easily find the emergency reason.
It's also very helpful to find the emergency reason of scenario test, which was run on CI since we have standard output log for each scenario test.

@kenji-miyake What do you think? If you agree, I'll implement this output.

@takayuki5168 As a tentative way, I think it is acceptable.
But ideally, we should define the interface for notifying the emergency reason from Autoware to the simulator because the console log isn't a good UI for everyone.
Then the simulator catches the notification and shows it on the result page.
Also, could you show me a screenshot of the result page for reference?
@yukkysaito @mitsudome-r @isamu-takagi @xmfcx Any ideas?

@kenji-miyake

Then the simulator catches the notification and shows it on the result page.
What I mentioned is not only for the scenario test analysis but also for running autoware with simple planning simulator or on the physical vehicle. I don't think it's not good to output the emergency reason on the standard output log for those cases.

Could I talk about how the scenario simulator gets the information of emergency reasons from Autoware in another issue since it's different from what I wanted to discuss :pray:

@takayuki5168 I'm sorry, I couldn't understand that well. :cry:
What you want to do seems to me just adding a hacky interface.
For simple_planning_simulator, it's the same.
The console log isn't a good interface because we cannot get it programmatically.
People have to look into the logs and try to find out the reason, it's not efficient or scalable. It's just supplemental information.

Could I talk about how the scenario simulator gets the information of emergency reasons from Autoware in another issue

Yes, of course, it's fine.

I've talked with Miyake-san.
In summary, we first implement just standard output of the emergency reasons, and see whether it works good for debugging from the point of view of development and product service (So far we don't even have a clear requirement). Then we may be able to think about the better idea based on how the current one works.
For the scenario simulator, I'll create another issue as I said.
Any comment would be welcome if you have.


unable to process empty project due to commonBasePath error

In my windows installation, after updating from gulp-typescript 2.6 to 2.7.5 the project where I work is not able to an app.d.ts file (with empty contents).
C:\projects\app-proj\node_modules\gulp-typescript\release\input.js:121
                .reduce(getCommonBasePath);
                 ^
TypeError: Reduce of empty array with no initial value
    at Array.reduce (native)
    at FileDictionary.Object.defineProperty.get [as commonBasePath] (C:\projects\app-proj\node_modules\gulp-typescript\release\input.js:121:18)
    at FileCache.Object.defineProperty.get [as commonBasePath] (C:\projects\app-proj\node_modules\gulp-typescript\release\input.js:206:32)
    at ProjectCompiler.inputDone (C:\projects\app-proj\node_modules\gulp-typescript\release\compiler.js:41:38)
    at CompileStream.end (C:\projects\app-proj\node_modules\gulp-typescript\release\main.js:52:31)
    at DestroyableTransform.onend (C:\projects\app-proj\node_modules\gulp-sourcemaps\node_modules\through2\node_modules\readable-stream\lib\_stream_readable.js:523:10)
    at DestroyableTransform.g (events.js:199:16)
    at DestroyableTransform.emit (events.js:129:20)
    at C:\projects\app-proj\node_modules\gulp-sourcemaps\node_modules\through2\node_modules\readable-stream\lib\_stream_readable.js:965:16
    at process._tickCallback (node.js:355:11)

In that property commonBasePath definition the variable fileNames string contains a single file,
'C:\projects\app-proj\typings\app.d.ts'
its contents is empty, because there is no files to add there yet.
Although unusual, It should work I think.

Wow, that was amazingly fast!   +100


Bug that may had my server crashed

Bug on Quests-3.3.4
I don't reeally know how the error happened but just four seconds later my server crashed and it is the only error that could have caused the crash. Here is the error : https://pastebin.com/bvWCjgce

Likely fixed in https://github.com/FlyingPikachu/Quests/commit/87edb98c3e815a7e8b23446d217477dfff7c8c64 so try using the latest dev build. Once installed, post the new error here if it happens again. Thanks!


Is it possible to have multiple data points per day, use month as the dataKey?

I was looking to do something like this where the x axis shows the month, and the tooltip shows the hour as well as the population growth rate, is it possible?
const chartdata = [
  {
    month: "Oct",
    hour: "8th 01:00"
    "Population growth rate": 1.74,
  },
  {
    month: "Oct",
    hour: "8th 02:00"
    "Population growth rate": 1.93,
  },
  {
    month: "Oct",
    hour: "8th 03:00"
    "Population growth rate": 1.9,
  },
  {
    month: "Oct",
    hour: "8th 04:00"
    "Population growth rate": 1.98,
  },
  {
    month: "Oct",
    hour: "8th 05:00"
    "Population growth rate": 2,
  },
];

Hey @j2is, the datakey property can only take one input. The tooltip depends on the dataKey property as well. Everything that should be displayed in the Chart (i.e. Line and Tooltip) has to be passed as a single reference into the dataKey propery.
One way to get both the date and the time into the chart is to create a timestamp like this:
const chartdata = [
    {
        name: 'Oct 23rd 01:00',
        'Population growth rate': 1.74,
    },
    {
        name: 'Oct 23rd 02:00',
        'Population growth rate': 1.93,
    },
    {
        name: 'Oct 23rd 03:00',
        'Population growth rate': 1.9,
    },
    {
        name: 'Oct 23rd 04:00',
        'Population growth rate': 1.98,
    },
//...

Which results in  a chart like this:

Hey, nice thank you

On 23 Oct 2022, at 14:51, Severin Landolt @.***> wrote:
Hey @j2is https://github.com/j2is, the datakey property https://www.tremor.so/docs/components/line-chart can only take one input. The tooltip depends on the dataKey property as well. Everything that should be displayed in the Chart (i.e. Line and Tooltip) has to be passed as a single reference into the dataKey propery.
One way to get both the date and the time into the chart is to create a timestamp like this:
const chartdata = [
{
name: 'Oct 23rd 01:00',
'Population growth rate': 1.74,
},
{
name: 'Oct 23rd 02:00',
'Population growth rate': 1.93,
},
{
name: 'Oct 23rd 03:00',
'Population growth rate': 1.9,
},
{
name: 'Oct 23rd 04:00',
'Population growth rate': 1.98,
},
//...
Which results in a chart like this:
https://user-images.githubusercontent.com/41927988/197395821-425934bc-9dd6-43ae-bd98-7d85b3e46b35.png
—
Reply to this email directly, view it on GitHub https://github.com/tremorlabs/tremor/issues/143#issuecomment-1288117891, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTFBZSS7S5XYNDOWQF4MLDWEU7HVANCNFSM6AAAAAARMJKNGQ.
You are receiving this because you were mentioned.


[SQL Editor][Database Navigator]: table declaration is always opening in default schema

System information:

Operating system (distribution) and version: Windows 10 Ent x64 LTSC (version 1809)
DBeaver version: <IP_ADDRESS>104181339
Additional extensions: None

Connection specification:

Database name and version: PostgreSQL 12.5 x64
Driver name: PostgreSQL JDBC Driver 42.2.18.jre7
Do you use tunnels or proxies (SSH, SOCKS, etc)? No

Describe the problem you're observing:
Table Declaration is always opening in the default schema, not in the one you've selected in Database Navigator or SQL Editor. Reconnecting after changing the schema in SQL Editor doesn't help.
The same problem was raised a long time ago on the forum and should be fixed, but it still persists in the latest version.
Steps to reproduce, if exist:

Set a default schema in DB connection via Driver Properites → currentSchema;
Open SQL Editor and set the non-default schema in Active catalog/schema;
Open the declaration of some table via F4 or Open Declaraion in right mouse button menu;
Repeat the same by selecting table in non-default schema via Database Navigator

Probably, it should help if you disable those options:


Providing different prompts per model always takes arguments of last provider

Since version 0.69.1 (up to 0.70.0), providing different prompts per model is broken, if the same provider id is used. It will always take the prompt arguments that are configured for the last provider.
Here is a reproducing example:
promptfooconfig.yaml:
prompts:
    - prompt1
    - prompt2

providers:
    - id: 'python:provider.py'
      label: 'Provider 1'
      prompts:
          - prompt1
    - id: 'python:provider.py'
      label: 'Provider 2'
      prompts:
          - prompt2

tests:
    - description: 'Assert equals'
      assert:
          - type: equals
            value: 'output'

provider.py:
def call_api(prompt: str, options: dict, context: dict):
    print(f"Prompt: {prompt}")
    return { "output": "output" }

When you run LOG_LEVEL=debug promptfoo evaluate, you can see that it will print out Prompt: prompt2 two times, instead of Prompt: prompt1 for the first provider, and Prompt: prompt2 for the second. Note that this is a regression from 0.69.0, where this case worked without problems. Note also that when there is no label provided for the providers, then it also didn't work in older versions (e.g. 0.67.0).
The issue is maybe caused by https://github.com/promptfoo/promptfoo/pull/1106, removing the code commented with Hack(ian): Override id with label.
My use case is: I have always the same custom provider, but depending on the prompt, I will do different things. My current workaround is to create separate providers for each prompt, but this is an overhead I want to avoid in the future.

Thanks for flagging this. I think you're probably right that the id/label
override was necessary in that code. We'll get a fix out quickly.
On Wed, Jul 10, 2024, 2:43 AM yakuhzi @.***> wrote:

Since version 0.69.1 (up to 0.70.0), providing different prompts per
model is broken, if the same provider id is used. It will always take the
prompt arguments that are configured for the last provider.
Here is a reproducing example:
promptfooconfig.yaml:
prompts:
- prompt1
- prompt2
providers:
- id: 'python:provider.py'
label: 'Provider 1'
prompts:
- prompt1
- id: 'python:provider.py'
label: 'Provider 2'
prompts:
- prompt2
tests:
- description: 'Assert equals'
assert:
- type: equals
value: 'output'
provider.py:
def call_api(prompt: str, options: dict, context: dict):
print(f"Prompt: {prompt}")
return { "output": "output" }
When you run LOG_LEVEL=debug promptfoo evaluate, you can see that it will
print out Prompt: prompt2 two times, instead of Prompt: prompt1 for the
first provider, and Prompt: prompt2 for the second. Note that this is a
regression from 0.69.0, where this case worked without problems. Note
also that when there is no label provided for the providers, then it also
didn't work in older versions (e.g. 0.67.0).
The issue is maybe caused by #1106
https://github.com/promptfoo/promptfoo/pull/1106, removing the code
commented with Hack(ian): Override id with label.
My use case is: I have always the same custom provider, but depending on
the prompt, I will do different things. My current workaround is to create
separate providers for each prompt, but this is an overhead I want to avoid
in the future.
—
Reply to this email directly, view it on GitHub
https://github.com/promptfoo/promptfoo/issues/1127, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACLYJWIX24HMYU4D4KHT63ZLT63NAVCNFSM6AAAAABKUQ2CCCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQYDAMRVHE4DCMI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Node restart

WIP node restart mechanism.

ockam node start [node_name] exists and works
but only when re-starting a base node with no additional configuration.

In theory other configuration commands should be supported (for transport & portals), though for some reason the commands hang when run from the startup sequence

@spacekookie this introduces an MPL licensed dependency. We can use that. https://github.com/build-trust/ockam/runs/7727728134?check_suite_focus=true

Rebased again against current develop @build-trust/approvers please review and get this merged today


Run Summary

Summary
Introduce a short summary that is emitted at the end of Terragrunt runs to give high level information about Terragrunt runs.
In addition to emitting a short summary, introduce a flag to allow for a serialized format of a detailed report that can be parsed and acted upon when the run is completed.
Motivation
When running in the context of a run-all or when operating on an individual unit with dependencies, Terragrunt can run multiple units in one command.
In that scenario, users have to parse logs to determine what happened to individual units and determine the overall status of a Terragrunt run.
When an individual unit fails to run successfully or is taking longer than the rest, users have to rely on parsing logs of the entire run to determine this.
In the context of CI, this can be useful as well, as automated reasoning regarding the success/failure of unit runs can enrich notifications emitted to user on pull requests.
Proposal
Introduce a short summary of every run at the end of every Terragrunt command involving a wrapped binary (e.g. plan or run-all plan) providing a summary of the run.
That summary will include the following:

Total Units
Total Duration
Units Succeeded Count
Units Failed Count
Descendants of Failed Unit Count (Early exit)
Excluded Count

These would be color coded to help folks quickly discover relevant information (red for failed, green for succeeded, etc).
The counts would be hidden for any zero values.
e.g. Don't display 0 excludes every time if no unit is ever excluded.
What it would look like:
$ terragrunt run-all plan
...

❯❯ Run Summary
Units:      8
Duration:   600s
Succeeded:  3
Failed:     1
Early Exit: 3
Excluded:   1

In addition, introduce a flag named --terragrunt-report-file that can also write a report to a specified file.
This file would receive a detailed report of the run with the following for each unit:

Name of unit (string)
Time started (timestamp)
Time ended (timestamp)
Result (One of succeeded, failed, early exit, excluded)
Failed Ancestor (Name of failed unit)

What it would look like:
This is a contrived example to show all the fields being used:
Report of a run involving a VPC with a dependent subnet, with two EC2 instances that are dependent.
The first instance is manually deployed , and is excluded, and the second is deployed with Terragrunt. An apply failed during the updates to the subnet.
(Extra whitespace included to make the CSV legible)
name,       started,          ended,            result,     failed ancestor
vpc,        2024-09-16 14:20, 2024-09-16 14:30, succeeded,  N/A
subnet,     2024-09-16 14:30, 2024-09-16 14:40, failed,     N/A
manual ec2, 2024-09-16 14:40, 2024-09-16 14:40, excluded,   N/A
TG ec2,     2024-09-16 14:40, 2024-09-16 14:40, early exit, subnet

The report file here would output maximal information for a run, instead of the minimal information made available in the summary.
To control the format of this report, use the following additional flag --terragrunt-report-file-format, which will control the format of the summary file.
The two initial values will be:

csv (default)
json

This should allow users to parse the summary as they see fit and aggregate information accordingly.
Finally, introduce the flag --terragrunt-summary-disable. This will disable the emission of the final summary to stdout by Terragrunt, as the emission of the summary will be the default behavior. The summary file will not be written by default, however, so this flag will not prevent that file creation.
While not part of this proposal, another feature that can be provided is the availability of a --terragrunt-summary-only  flag. This would disable all logs except the summary. This feature wouldn't be part of this proposal, as the availability of a run summary would need to be battle tested before making it the only information emitted by Terragrunt. The advantage of such a flag is that it would allow for the majority of noise emitted by Terragrunt to be ignored.
A corresponding feature that could be added is to also include a --terragrunt-log-file to sink the logs into a file instead of being emitted to stoud in this case. By doing this, users would still be able to revisit the logs of the run while only emitting the summary to stdout. Again, not something to be tackled as part of this RFC.
Technical Details
An execution report will have to be tracked for the duration of Terragrunt runs in order to determine when units start executing, when they complete their executions and what the outcomes of their runs are.
Terragrunt will also need to detect the completion of all runs and emit a final short summary to stdout.
The detailed summary will need to be serialized according to the specifications of the user, and provide the high-level information that users expect.
Flags added:

--terragrunt-summary-disable
--terragrunt-report-file
--terragrunt-report-file-format

Press Release
Announcing Terragrunt Run Summaries!
Visual demonstration of run summaries
Terragrunt has long been a tool that supported operating over multiple Units, providing a simple abstraction for running them with a single command.
Terragrunt will now emit a short summary when performing runs that gives high level information about the run. This summary will give quick at-a-glance information about every run instead of requiring analysis of log output.
Drawbacks
This change will require a small, potentially undesirable, change in that the stdout of Terragrunt will be altered by default. Users will have to explicitly opt-out of emitting a summary via the --terragrunt-disable-summary flag in order to prevent this behavior.
The advantages of this change should outweigh the negatives, however. Users will get access to more data without any additional configuration when making updates to Terragrunt units, and many will benefit heavily from this.
Alternatives
Don't do it
Some users don’t like UI/UX changes, however small, and they may rely on Terragrunt emitting logs in the exact format they are today.
Only support summary file
Users may be able to acquire all the same benefits from opting into this functionality via a summary file with no change to the stdout emitted by Terragrunt.
The trade-off here is that the short summary is very useful information. Users shouldn't have to learn a new flag or change configurations to receive that data.
Migration Strategy
If you currently rely on parsing Terragrunt logs, you will likely want to be aware of this change and adjust your scripts accordingly.
Unresolved Questions

Would users prefer any of the alternates?
Is there any data users would prefer removed from the summary?
What about the report?
Are there any other formats users would really like supported out of the box?
Do users like the format of the short summary? How should it be styled?

References
No response
Proof of Concept Pull Request
No response
Support Level

[ ] I have Terragrunt Enterprise Support
[ ] I am a paying Gruntwork customer

Customer Name
No response

I really like the summary! A few thoughts:

it would be great if the summary could also be pushed via otel metrics, if that isn’t already being done

I understand the intent is to display the summary only at the end of the run, but perhaps in the future, you might consider introducing a "live feed" or "refresh status" feature. This could be useful outside of CI, especially for more complex projects where it's challenging to assess progress in real-time

regarding the flags, shouldn't we use a summary prefix for report file and report file format? For example: --terragrunt-summary-report-file and --terragrunt-summary-report-file-format

In order:

That's a great idea! I'll add it as a requirement to the technical details. It might not necessarily be a single summary event/span, but there should definitely be events emitted that give you equivalent information to the summary. Maybe both.

We have thoughts about this, but delivering anything like this would not be something we'd focus on in the short term.

The thought there was that the summary and the report are really two different things that interact with the same data. It's not a report on the summary, but on the run.
Maybe run-report-file/format and run-summary are better?


Run 1.0 phosim results

In this issue we'll track the results that we get from PhoSim for Run 1.0, carried out on protoDC2. This can also be a stepping stone towards the more formal validation of the image files that we need to do. Tom is collecting the outputs here: /global/projecta/projectdirs/lsst/production/DC2/DC2-phoSim-2-r/output

@johnrpeterson Hi John, I looked at a random centroid_lsst_e_195452_f2_R43_S20_E000.txt file from the phosim and there are lots of nans in there:
SourceID Photons AvgX AvgY
1125435218948 7769 3400.425151 3898.067061
1125434880004 62 3242.483871 3976.145161
1125434145796 0 -nan -nan
1125433789444 0 -nan -nan
838460647428 39615 3074.290471 4066.973167
1125436257284 0 -nan -nan
Is this expected? Where do they come from? Thanks a lot (I have obviously no good idea what should be in there and appreciate your help for me to get up to speed on better understanding the outputs!)

I have peeked at some of the output files from the phosim runs that Tom is producing and thought I would share the results here. From this very limited inspection, things look good -- no speckles or anything. I show below just a zoom in and a contour plot with the associated histogram. The experts should look more carefully though the run is obviously not complete yet.

@katrinheitmann The nans are listed for (faint) sources that generated no detected photons, so no centroid can be calculated.  The AvgX and AvgY are pixel coordinates in the output images.

Unfortunately, I have to bring not-so glad tidings about the current phosim runs.  Here is part of a field from the current runs in the r band, visit 889352:

and here is a visit from DC1, imsim dithered, r band, visit 40337:

In contrast to the DC1 era image, in the protoDC2 image there are almost no galaxies evident.
It seems that the reason for the apparent lack of extended objects is that the sersic major and minor axes for the protoDC2 instance catalogs are being written in radians instead of arcseconds (as required by phosim).
Here are histograms comparing the major axis ratios for DC1 and DC2 for representative samples:

Clearly multiplying the DC2 values by the factor to convert from radians to arcsec makes the distributions agree better.
For reference, here are comparisons of the axis ratios (major/minor) and r magnitudes:

I think I know what changes to make to get the protoDC2 catalogs have the right galaxy major/minor axis units, but I need to check with Scott.  Until there is a fix, I guess we should stop the phosim production at NERSC.

Here's a plot showing the centers of the completed sensor visits, as of an hour or so ago.  It looks like the system for selecting the sensor visits to simulate for a given pointing is working.  I highlighted the positions of the sensor visits for obsHistID = 151687, which has the most (186) of any; I have not looked into why three sensor visits are missing from that pointing.

The completed sensor visits had 566 unique obsHistIDs, with an average of about 37 sensor visits per obsHistID.  You can see a gradient of density with RA.  I don't think that there's necessarily a problem, but I might look into it a bit more.  Each sensor visit covers a region about 0.22x0.22 deg.

@sethdigel The three missing sensors from visit 151687 (which is, in fact, the very first visit in the r-band) are simply queued and waiting to execute.   (And production was shut down a few hours ago.)

Here are couple of simulations of visit 450581 showing the middle of the central chip:

on the left, using my kluge here to get seemingly reasonable galaxy major/minor axis values (and simulated via imsim), and
on the right, the same field from the phosim protodc2 runs using the production instance catalog (i.e., without my kluge).

Here's a plot of median electrons/pixel vs. Moon altitude for the 20928 sensor visits in the DC-phoSim-2-r run.  These are all r-band observations.

The vertical banding occurs because the sensor visits were accumulated over 566 visits, and so many sensor visits have the same metadata.  There's at least a suggestion of a dependence with moon altitude (which in the Twinkles era was the most important predictor of CPU time) and the typical value seems about right based on the estimates of @fjaviersanchez; this is probably the most important consideration right now.  I don't know what to expect but the scatter seems a bit large, and some sensor visits seem to have unusually low median electrons/pixel; this was also the case for DC2-phoSim-1. (The minimum is 30, which occurs for obsHistID 889352.)  I've posted a csv file with a wider variety of observing metadata for these sensor visits here; the last column ('med') has the median electrons/pixel.

I don't know what to expect but the scatter seems a bit large, and some sensor visits seem to have unusually low median electrons/pixel;

At some level, I am more surprised by the high median cases.  The low cases could in principle be caused by clouds, but what causes twice the expected sky level when the moon is 70 degrees below the horizon? Is the sky glow that much in the model?
Could we make the figure with more of a density plot like approach (or as a profile histogram) so we can better see the trend of the distribution?

Thanks for the data @sethdigel. I am showing here some plots similar to what you did but color-coding with other quantities.
I thought that these high-background images might be due to twilight observations but it doesn't look like it:

Then I checked if it was just close to the Moon:

Some of these are indeed due to being close to the Moon. And then I checked the Moon phase:

And it looks like there's a correlation between the phase and the vertical stripe at ~0 deg.

Oh... didn't notice the link to the CSV file that Seth made. That's great thanks.  Javier, can you remake this with very small dots so we can see how they are distributed and if the ones on the edges are really outliers?

Beautiful plots, @fjaviersanchez.  I had looked at some of the potential correlations, but nothing really jumped out at me.  I guess that I see the point @cwwalter made about clouds = dark sky.  (I came from mm-wave astronomy where clouds = water vapor = bright sky.)  Maybe it would be interesting to look at the variations in median sky counts across the focal plane for a given visit, to see how systematic they are.  I don't think that the OpSim database has metadata about clouds, and I am not sure how much detail is available in the phoSim output about the clouds, including angular structure, for a given visit.

At good sites the clouds are darker than the sky in the optical (not true in Princeton or SLAC) even then the moon isn't up.  This should be a bigger effect in the red (e.g. i, z, y) than the blue (u, g).

John will need to confirm but I thought I was told (I can't remember by who) that in PhoSim the clouds extinct light but don't reflect moonlight etc.  But in any case we see cases in the plots with twice the expected level when the moon is at -70.  I think it would be good to just look at one of those cases in ds9 and see what is really going on.

At least part of the answer is vignetting.  Here's a visit (obsHistID = 1678834) with a large number of sensor visits simulated and one of the larger ranges of median electrons/pixel in the sensor visits, including 6 sensor visits with much lower medians than the rest of the distribution.

(The gaps in the assembled image are presumably sensor visits that were in progress when the pipeline was stopped.). The scaling in the assembled image above is linear.  I'll update the csv file of metadata to include the CCD locations in the focal plane.

I've updated the csv file to add columns with the locations of the sensors in the focal plane.  The new columns are rx, ry, sx, and sy, extracted from the R##_S## parts of the file names.  rx is the x-coordinate of the raft, ry is the y-coordinate, and sx and sy are the coordinates of the CCDs in the rafts, in the mapping scheme defined in LCA-13381.  I also added a column 'radius' with the approximate angular distance of the CCD from the center of the focal plane, in units of CCD widths.  Roughly speaking, vignetting starts to look important for radius > 7.
Here's a quick plot showing the median electrons/pixel vs. moon altitude including only the sensor visits with radius <= 6.  The amount of scatter remaining in individual visits is difficult to judge in this plot, but it is certainly reduced.

Considering only sensor visits with radius <=6, visit 1678834 (assembled image shown above) has the largest range of median electrons/pixel among its sensor visits.  For the 89 sensor visits, the full range is 251, the standard deviation is 58, and the average of the medians is 1699.   For other visits, the full range for radius <=6 sensor visits is typically ~100 or less.  So the sensor-to-sensor scatter in a given visit (presumably due to cloud variations) does not seem particularly extreme.  The correlation of the median electrons/pixel to the altitude of the Moon is not particularly striking but does seem to be positive.

Given that Run 1.0 has concluded, I am closing this issue.


noImplicitAny regression in 1.3

Pre 1.3, with --noImplicitAny flag on, having the following:
interface Object {
  [key: string]: any;
}

would enable this type of scenario:
var element = document.querySelector("#something");
element["foo"] = { ... };

However, now this results in an implicit-any error. The winjs/winjs team uses this pattern a lot to add and access members on various objects and this is blocking us from moving to 1.3.

I've an Angular2 related Issue:
myData is defined as: myData:any = {'foo': 'bar'}; in the component and I've the following method:
private whatever (param:string) {
  console.log (this[param]); // param = 'myData'
}

It actually works properly but the TypeScript-Compiler outputs an error:
TS7017:Index signature of object type implicitly has an 'any' type.
I've tried to suppress this error by switching off the following flags in the tsconfig.json (compilerOptions):
"noImplicitAny": false,
"noImplicitThis": false,
"suppressImplicitAnyIndexErrors": true,

It did not work. Can someone help me further?
Second question:
Is it possible to suppress certain errors (e.g. TS7017) in tsconfig.json? If yes, how? I would like to achieve something like (e.g. in the compilerOptions in tsconfig.json):
    // ATTENTION PSEUDO CODE
    suppressErrors: ['TS7017', ....]

p.s. TS7017: Index signature of object type implicitly has an 'any' type.
thank you very much!

@webia1, this is a year old issue. it is not related to the question you posted. In the future we would appreciate it if you can start new tickets instead of commenting on closed issues. also SO or the ts gitter room would be better venues for such questions. this issue tracker is mainly for TS compiler and tools bugs.
As for your question. The containing class (refereed to in this context using this) does not have an index signature, so indexing into it results into the any type. i.e. the compiler does not know statically what value param can have, it can be toString and get you a function, or it can be a property, and get you a number or string for instance. Since indexing with strings is allowed in JS, the compiler let's it pass, but gives you the error in noImplicitAny errors.
Setting noImplicitAny to false should suppress the error. the fact that it did not suggests that you have an issue in your project setup or how you call the compiler. to be able to help you further i will need to look at your setup and how you are invoking the compiler. The most common issue ppl run into is calling the compiler with no configuration and assuming it will pick up the tsconfig.json. if you have a tsconfig.json call the compiler as tsc --p <path to tsconfig.json> and not just tsc file.ts.
see http://www.typescriptlang.org/docs/handbook/interfaces.html#indexable-types for more details.

Thank you, that helps completely,..


cant install tf_addons in edit mode

I can not run pip install -e . with tf.addons.
I am on Mac and using conda, python 3.6 with fresh git checkout of tf.addons.
Is there a workaround? Edit mode would be nice for development / tests.
I get this error:
  Running setup.py develop for tensorflow-addons
    ERROR: Command errored out with exit status 1:
     command: /usr/local/miniconda3/envs/tf2/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/Users/mike/develop/git/addons/setup.py'"'"'; __file__='"'"'/Users/mike/develop/git/addons/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps
         cwd: /Users/mike/develop/git/addons/
    Complete output (16 lines):
    running develop
    running egg_info
    writing tensorflow_addons.egg-info/PKG-INFO
    writing dependency_links to tensorflow_addons.egg-info/dependency_links.txt
    writing requirements to tensorflow_addons.egg-info/requires.txt
    writing top-level names to tensorflow_addons.egg-info/top_level.txt
    reading manifest file 'tensorflow_addons.egg-info/SOURCES.txt'
    reading manifest template 'MANIFEST.in'
    /usr/local/miniconda3/envs/tf2/lib/python3.6/site-packages/setuptools/dist.py:472: UserWarning: Normalizing '0.6.0-dev' to '0.6.0.dev0'
      normalized_version,
    warning: no files found matching '*.so' under directory 'tensorflow_addons/'
    writing manifest file 'tensorflow_addons.egg-info/SOURCES.txt'
    running build_ext
    building '_foo' extension
    creating build
    error: could not create 'build': File exists
    ----------------------------------------
ERROR: Command errored out with exit status 1: /usr/local/miniconda3/envs/tf2/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/Users/mike/develop/git/addons/setup.py'"'"'; __file__='"'"'/Users/mike/develop/git/addons/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps Check the logs for full command output.

Hi,
I ran into similar issues when I try to build tf_addons in Mac OS.
You may found those flags helpful
sudo CFLAGS=-stdlib=libc++ MACOSX_DEPLOYMENT_TARGET=10.14

when you trying to update the package after making some change, if it doesn't work for you. The way I re-build the package after making developmental changes in the package in macOS env is
sudo CFLAGS=-stdlib=libc++ MACOSX_DEPLOYMENT_TARGET=10.14 bazel-bin/build_pip_pkg artifacts

pip install --upgrade artifacts/tensorflow_addons-*.whl

I hope this helps!

Thanks for the help. Perhaps we should add something like this for the documentation (should verify this on linux envs as well).
Closing... but happy to re-open if there is more discussion needed.


figure out what to do with the message dispatcher.

I feel like passing the instance around everywhere is messy... :-(

factories!


Add jsdoc support for eslint

We want to remove @param and @returns tags that don't add information.
We also make all warnings into errors so that CI fails.
WHY are these changes introduced?
I recently noticed that we have some duplicate information between jsdoc comments and typescript type signatures. So in this PR i've added an eslint plugin to detect @param and @returns annotations that don't add information.
WHAT is this pull request doing?

add jsdoc support for eslint
remove offending lines to get the CI back to 🍏
turn all eslint warnings into errors so they can fail the CI

How to test your changes?

run yarn lint

Measuring impact
How do we know this change was effective? Please choose one:

[x] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

[x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[x] I've considered possible documentation changes
[x] I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

turn all eslint warnings into errors so they can fail the CI

Where is that? 🤔

I added that eslint-plugin-only-error but then realized it's not necessary :)


Pass Object type to bigint shl, shr, pow fn signatures

What
Pass in bigint objects to bigint_shl/shr/pow fn signatures, and provide sign and overflow checks within these functions.
Why
The num_bigint api of shl, shr, pow has internal checks for sign and overflow, which may panic if the inputs do not fit. Instead of restricting our hostfn api (e.g taking a u32 as the exponent in bigint_pow), we should still pass those parameters as BigInt and check their validity from within the host functions. This makes the bigint hostfn apis more uniform and easier to maintain.
Known limitations
[TODO or N/A]

What's the actual valid range for these values?

What's the actual valid range for these values?

There is no explicit range limits on these values. Limits come from memory and pointer size. The bigint is stored as an array of u64 and array size cannot exceed usize::MAX.

This needs to be well defined as part of the CAP that introduces the type, rather than implementation defined.

I note in the description of this PR:

Pass in bigint objects to bigint_shl/shr/pow

I note in the CAP that the following comments are being made:

The operand of the left and right shift operations (bigint_shl and bigint_shr cannot be negative and cannot exceed size of u64.
The exponent in bigint_pow cannot be negative and cannot exceed size of u64.

If the limit for these is U64, why not use the U64 object type instead of the BigInt object type?


Optimize compose large images (>=10MB each images)

Compose images feature
My problem
Currently, I'm doing compose 4-5 images into solid background (fixed size), each image size is >= 10MB. I force it run in 1 CPU. As a result, it spend 4-5s even 7s completing.
My expectation is 1-2s.
Dependencies

Node version: 14.20.1
OS: Ubuntu 20.04
Sharp version: 0.32.0
Sample code:

    /**
     * Merge all images together
     *
     * @param {CompositeImagesArgs} args
     * @returns {Promise<CompositeImagesOutput>}
     */
    async compositeImages(args) {
        const { background, images, format = ImageProcessor.PNG } = args
        const file = await FileHelpers.createTemporaryFile(format)
        const { height, size, width } = await sharp(background).composite(images).toFile(file)
        return { file, height, size, width, mime_type: `image/${format}` }
    }

Example

Here is some logs:

Please can you provide complete code and sample images that allows someone else to reproduce, perhaps as a standalone repo.

@lovell
Here is full example code: https://gitlab.com/datht3/sharp-compose-images
Here is my test images: https://drive.google.com/drive/folders/19-3NW93ubUfh3M6WM_I_xCm4Sp9-YxUX?usp=share_link

@lovell Here is full example code: https://gitlab.com/datht3/sharp-compose-images Here is my test images: https://drive.google.com/drive/folders/19-3NW93ubUfh3M6WM_I_xCm4Sp9-YxUX?usp=share_link

In this code, I'm running with full CPU cores with dependencies:

OS: Ubuntu 20.04
CPU: Intel® Core™ i3-9100 CPU @ 3.60GHz × 4
Sharp version: 0.32.0
Node version: 14.20.1
And result is approximately 2.5s

Thanks, I see ~3.1s when run locally on an ageing i7-7500U.
Given you're using Ubuntu, did you see https://sharp.pixelplumbing.com/install#linux-memory-allocator ?

For this reason, by default, sharp will limit the use of thread-based concurrency when the glibc allocator is detected at runtime.

If I add sharp.concurrency(4) I see the time reduce by ~10% to ~2.8s.
Removing the composite() operation to provide a "baseline" PNG roundtrip time, i.e. only decoding the background and encoding the output:
 await sharp(backgroundPath).toFile(outPath)

I see ~1.1s for this, so the addition of a 7-image RGBA composition takes about ~1.7s.
Are you able to provide code using alternative tooling that performs the same operation more quickly? It's possible there might be scope for improvement within libvips using callgrind profiling or similar.

@lovell If I using code like this, it takes ~1.8s
async function main() {
    console.time('compose images')
    await sharp({
        create: {
            width: 12289,
            height: 5096,
            channels: 3,
            background: '#ffffff'
        }
    }).composite(images).png().toFile(outPath)
    console.timeEnd('compose images')
}

If the background is always a solid colour then yes, avoiding the largest PNG decode of this example will definitely help.
PNG decoding speed is often a function of image width, especially when this increases to a level where decompressed regions of the image may no longer fit in the CPU cache.

@lovell yes, I change the out format to JPG and it downs to <1s if aslo increasing UV_THREADPOOL_SIZE.
Thanks for your support


Update README.md

@sagarp0810
Thanks for the PR.
I am merging your PR.
Hope to see more contribution from you in future.


Enable LoRAs to patch the text_encoder as well as the unet

Load LoRAs during compel's text embedding encode pass in case there are requested LoRAs which also want to patch the text encoder.
Also generally cleanup the attention processor patching stuff. It's still a mess, but at least now it's a stateless mess.

@GreggHelt2 and @blessedcoolant  Could one of you have a look at this PR? It fixes LoRA issues and I'm hoping to put it into a 2.3.5 release.

Yep. Quite a bit of work involved here, but I'll have it in in time for 3.0
L


Updates to "technology choices" articles

Add compute decision tree
Add Container Instances to compute comparison tables

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/guide/images/compute-decision-tree.svg
:white_check_mark:Succeeded
View

docs/guide/index.md
:white_check_mark:Succeeded
View

docs/guide/technology-choices/compute-comparison.md
:white_check_mark:Succeeded
View

docs/guide/technology-choices/compute-decision-tree.md
:white_check_mark:Succeeded
View

docs/guide/technology-choices/compute-overview.md
:white_check_mark:Succeeded
View

docs/guide/technology-choices/index.md
:white_check_mark:Succeeded

docs/guide/toc.yml
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/guide/images/compute-decision-tree.svg
:white_check_mark:Succeeded
View

docs/guide/index.md
:white_check_mark:Succeeded
View

docs/guide/technology-choices/compute-comparison.md
:white_check_mark:Succeeded
View

docs/guide/technology-choices/compute-decision-tree.md
:white_check_mark:Succeeded
View

docs/guide/technology-choices/compute-overview.md
:white_check_mark:Succeeded
View

docs/guide/technology-choices/index.md
:white_check_mark:Succeeded

docs/guide/toc.yml
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/guide/images/compute-decision-tree.svg
:white_check_mark:Succeeded
View

docs/guide/index.md
:white_check_mark:Succeeded
View

docs/guide/technology-choices/compute-comparison.md
:white_check_mark:Succeeded
View

docs/guide/technology-choices/compute-decision-tree.md
:white_check_mark:Succeeded
View

docs/guide/technology-choices/compute-overview.md
:white_check_mark:Succeeded
View

docs/guide/technology-choices/index.md
:white_check_mark:Succeeded

docs/guide/toc.yml
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Animation buttons Added to Scroll

Related Issue

Mention issue for which this pull request is a part of ( issue number #629  )

Proposed Changes

Change 1 channged normal buttons to animation buttons
Chnage 2 added easy way to select buttons

Additional Info

Any additional information or context

Checklist

[x] ✅ My code follows the code style of this project.
[x] 📝 My change requires a change to the documentation.
[x] 🎀 I have updated the documentation accordingly.
[x] 🌟 ed the repo

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Output Screenshots

It's not matching with the theme, also having issues with the alignment and bot scrolling in mobile view

It's not matching with the theme, also having issues with the alignment and bot scrolling in mobile view
Can I change the code and I will do my best


Codeberg seems to start experiencing issues search not as many results as expected

For instance: prodezarts.com Benjamin_Loison/Improve_websites_thanks_to_open_source#18.
Same issue with https://codeberg.org/api/swagger#/issue/issueListIssues.
Establishing a workaround based on download everything seems to make sense.
As I do not find, even with DuckDuckGo and Google search engines, a solution to export repository issues. Let us try to import on my own Gitea instance. Maybe it is a Codeberg intended limitation.

Maybe incorrect scopes, as there are two interesting ones: issue and repository.
Is there a dedicated option in Gitea for importing from Forgejo instance? As it seems to be such one on Codeberg.
With above both scopes (they are both required), I am able to import from Codeberg to Codeberg and then there is no issue anymore searching prodezarts.com for instance.
Are issue ids kept? I do not have this feeling at least with Improve_websites_thanks_to_open_source_issues/issues/300.
Description
For instance: https://codeberg.org/Benjamin_Loison/Improve_websites_thanks_to_open_source/issues?type=all&state=open&labels=&milestone=0&project=0&assignee=0&poster=0&q=github.com
+76
Gitea Version
Not read.
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
Not read.
Database
None

import requests
import json
from tqdm import tqdm

GIT_INSTANCE_URL = 'https://codeberg.org'
# With `read:issue` scopes.
TOKEN = 'CENSORED'
REPOSITORY_FULL_NAME = 'Benjamin_Loison/Improve_websites_thanks_to_open_source'

headers = {
    'Authorization': f'token {TOKEN}'
}

def getApi(url, params):
    response = requests.get(f'{GIT_INSTANCE_URL}/api/v1/{url}', headers = headers, params = params)
    return response.json()

repositoryIssueParams = {
    'state': 'all',
    'limit': 50,
}
repositoryIssues = []
page = 1
while True:
    print(f'{page=}')
    repositoryIssueParams['page'] = page
    repositoryIssuePage = getApi(f'repos/{REPOSITORY_FULL_NAME}/issues', repositoryIssueParams)
    if repositoryIssuePage == []:
        break
    repositoryIssues += repositoryIssuePage
    page += 1

print(json.dumps(repositoryIssues, indent = 4))

Above script does not seem to copy to clipboard on Debian 12 GNOME at least in Pyzo but seems to work fine when run in a gnome-terminal.

Would help Community_detection_in_graphs/issues/10.

Related to Improve_websites_thanks_to_open_source/issues/680.

Note the new enum Exact and Fuzzy:

What about attachments not mentioned in the body? Can we deduce to what issue comment they were uploaded to?

Related to Benjamin_Loison/gitlab/-/issues/21.

paste | wc -c

2688495

shows that currently for Improve_websites_thanks_to_open_source/issues each time I download 2.7 MB.

Would be nice to search among comments as well.

Benjamin_Loison/pyperclip/issues/4 would help.


Get-AzureStorageTableRowByCustomFilter throws error when the element exists.

When executing the command Get-AzureStorageTableRowByCustomFilter, I get the folowwing error :
Add-Member : Cannot add a member with the name "RowKey" because a member with that name already exists. To overwrite the member anyway, add the Force parameter to your command.
Here the executed command:
$filter = [Microsoft.WindowsAzure.Storage.Table.TableQuery]::CombineFilters( `
     [Microsoft.WindowsAzure.Storage.Table.TableQuery]::GenerateFilterCondition("PartitionKey", [Microsoft.WindowsAzure.Storage.Table.QueryComparisons]::Equal,"$($element.partitionKey)"), `
     [Microsoft.WindowsAzure.Storage.Table.TableOperators]::And, `
     [Microsoft.WindowsAzure.Storage.Table.TableQuery]::GenerateFilterCondition("RowKey", [Microsoft.WindowsAzure.Storage.Table.QueryComparisons]::Equal,"$($element.rowKey)"))

$tableElement = Get-AzureStorageTableRowByCustomFilter -table $storageTable -customFilter $filter

@EhRom please provide us with the link to the documentation you are referring to so we can better assist.

@EhRom any update on this?

@EhRom I will close this for now. When ready, please provide me with the link to the document you are referring to and we can reopen and investigate.


Added docs for how to produce a custom Linux OS image

This is the first documentation cut of the custom OS image build instructions for the Linux Hyper-V container on Windows.

@soccerGB,
Thanks for your contribution.  To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
The agreement will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot


Fcitx input method support

Thank you very much for developing this helpful software. It really saved me a lot of time. I just noticed that I could not switch to my fcitx input method in this whatsapp program. I'm wondering if it's possible to add the Fcitx input method support to this program?
Thanks again for your efforts.

this has been discussed in https://github.com/keshavbhatt/whatsie/issues/15

Thanks for referring to #15. I tried snap refresh qt513 --edge, but the problem stayed the same. Do you have any suggestions to check on my system?
Thanks in advance.
Distributor ID:	Ubuntu
Description:	Ubuntu 20.04.1 LTS (fossa-squirtle X48)
Release:	20.04
Codename:	focal

fcitx version: <IP_ADDRESS>

I have these lines in my ~/.profile
export GTK_IM_MODULE=fcitx
export QT_IM_MODULE=fcitx
export XMODIFIERS=@im=fcitx

I have to give it a try on 20.04 when i will get my hand on system with the version of ubuntu installed. Thanks for reporting.

It would be great. Thanks a lot.

The issue is fixed in 0483b030043f13fe048f575882ffb78d4177b479
You can refresh whatsie with snap refresh whatsie --stable to get the changes.
Feel free to reopen for further assistance.


usb_modeswitch-data and udev rules missing

According to that: https://github.com/NixOS/nixpkgs/issues/11197
I found that usb-modeswitch is provided with usb-modeswitch-data  (on http://www.draisberghof.de/usb_modeswitch/). usb-modeswitch-data package contains data for modems and udev rules as well to activate modems (switch usb from usb-storage mode to modem-mode).
usb-modeswitch-data package is missing from nixos. I think would be nice to add this :-)

I create pull request with udev rules for modems https://github.com/NixOS/nixpkgs/pull/14133.
But there is one issue there, I have no idea how to expose udev rules from a package.
Do I need to create some system glue/system service/system module in nixos to do that? Or there is a way to expose those rules from a package level?

Once master goes to nixpkgs-unstable you will be able to use services.udev.packages = with pkgs; [ usb-modeswitch-data ];. It will install the udev rules on the next nixos-rebuild switch.

huh, interesting. Do you think it's better to do it that way rather than create let's say "modem" service which inject this package to udev.packages?

Not necessarily but it's one available option.
Do you know if this package cover all the modems ?
Adding more abstraction always has a cost and I don't understand the specific modem domain space enough to know what is the best option to be honest.

Definitely not cover all, but it's what debian is using, I think ubuntu may use this + they add some extra stuff usually to cover corner cases. I think this package should cover most stuff.

Before building a module around this I think it would be worth testing the udev rules to see if they work with nixos properly. Do you have any modems at hand you could use for that ?

@zimbatm yes, I have one which requires that (that's why I started that). I'll test over the weekend to make sure it works properly and report here.

Okay great. Feel free to ping me on irc if you hit any snag. I might be there but not guaranteed :)

triage: any updates?

Unfortunately not, I left that topic. I don't know if that was fixed by someone else.

cc @zimbatm

Looks like that is done and now you can enable udev rules with hardware.usbWwan.enable=true;.

Hello, the rules doesn't seems to work. I am using a Logitech G920 which is configured by usb_modeswitch.
I added usb-modeswitch-data to the udev rules, it shows up in /etc/udev but nothing gets applied.
It look like the package is missing something


refactor: removed has dependency

Also fixed LF errors on test in index.js file

This is a duplicate of #5, and makes the code worse, not better. Why remove this robust, widely used, and useful dependency?

(also i don't see any line ending changes)


ModuleNotFoundError: No module named 'dynamicprompts.wildcards'

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behaviour, include the prompt you used if applicable:

Go to 'stable-diffusion-webui'
Click on 'webui.bat(Python 3.10.8)'
Scroll down to 'Running on local URL:  http://<IP_ADDRESS>:7860'
See error

Also mention which checkboxes have been set.
Are you using a local install or a colab?

a local webui install
Installing sd-dynamic-prompts requirements.txt

If a colab, which one?
Expected behaviour

Unable to use dynamic prompts due to an error
Want to be able to use dynamic prompts

Additional context
Add any other context about the problem here.

trying running python -m pip install dynamicprompts==0.20.1 and let me know if that fixes it

same issue here.
Try installing 0.20.1, but it reports this

Try python -m pip install dynamicprompts==0.20.1  instead

any directory python -m pip install dynamicprompts==0.21.0
Problems remain

Have a look in the Need Help? accordion for the version of dynamicprompts you have installed. If it's lower than 0.21.0 then it is too old. Try completely restarting webui, i.e. stop the progam entirely and then start it again

Thank you for your reply, I'm sorry to trouble you.
"I don't know how to program, so I don't understand the problem. It may be a problem with computer hardware compatibility, etc. I just hope that in the future I can use the" Dynamic Prompt "extension.
I just tried again and the problem remains:

c:\ 'python -m pip install dynamicprompts==0.21.0'

Install the "Dynamic Prompt" extension in the Web UI

Restart the Web UI result Error

Your webui may be using a separate virtualenv than the base Python 3.10 you're using.
If it's the default configuration, you can try
cd f:\ai\stable-diffusion-webui-aki-v3
venv\scripts\activate
pip install -U dynamicprompts

to upgrade the copy of dynamicprompts within that venv.

It has something to do with your mirror, you can

download the whl file from pypi, then install it:

{python environment path}\python.exe -m pip install  {file directory}\dynamicprompts-0.21.2-py3-none-any.whl

try other mirror

{python environment path}\python.exe -m pip install dynamicprompts==0.21.2 -i https://mirrors.aliyun.com/pypi/simple/

great ,it works thank you

@charliesxia can we close this issue?

Closing.

Your webui may be using a separate virtualenv than the base Python 3.10 you're using.
If it's the default configuration, you can try
cd f:\ai\stable-diffusion-webui-aki-v3
venv\scripts\activate
pip install -U dynamicprompts

to upgrade the copy of dynamicprompts within that venv.

i do not fain this file,why?
thanks

It has something to do with your mirror, you can

download the whl file from pypi, then install it:

{python environment path}\python.exe -m pip install  {file directory}\dynamicprompts-0.21.2-py3-none-any.whl

try other mirror

{python environment path}\python.exe -m pip install dynamicprompts==0.21.2 -i https://mirrors.aliyun.com/pypi/simple/

i have a question
how to install the whl file,input the whl to which file
please help

I would guess that you download the file from this link
then in  your terminal write python -m pip install dynamicprompts-0.25.2-py3-none-any.whl
if you still get an error message, you might  not be using the correct python.exe. You can find the path to the right one in the error message  you get in the webui terminal. It will look something like C:\Users\(Your logged in User)\AppData\Local\Programs\Python\Python310 (but not that necessarily).
[Note for anyone in future seeing this issue - the link to the current version 0.25.2 is current as of now, but will almost certainly be different in future].


Terminal - Can't skip shell commands that are bound to some F keys

OSX. Add to settings -
"terminal.integrated.commandsToSkipShell": [
    "workbench.action.debug.run"
]

When I press F5, which should start debugging, it inserts 5~ into the shell. But if I bind that command to F3, then it works. Is it possible to make this work?

@roblourens weird, I actually do this and it works fine for me.

I just launched with --disable-extensions and a user-data-dir so my settings/keybindings aren't applied.
Then created one keybinding like
    {
        "key": "f5",
        "command": "workbench.action.quickOpen",
        "when": "editorTextFocus"
    }

Same result

"when": "editorTextFocus" would stop it from working in the terminal

Ugh there are a couple problems...
First, I was using workbench.action.debug.run when I wanted workbench.action.debug.start. Second I didn't notice the when above, apologies, that just came from the 'add keybinding' snippet.
But also, a change to the commandsToSkipShell setting doesn't take effect until I collapse and show the terminal. Can that be fixed?

@roblourens the config change should happen immediately, are you sure it doesn't work? Works fine for me.

Oh I see the problem, this throws when I set commandsToSkipShell to be an empty array, so the change isn't applied. "TypeError: Reduce of empty array with no initial value"
	public setCommandsToSkipShell(commands: string[]): void {
		this._skipTerminalKeybindings = commands.map((c) => {
			return this._keybindingService.lookupKeybindings(c);
		}).reduce((prev, curr) => {
			return prev.concat(curr);
		});
	}

Actually, if I start vscode with that setting as an empty array, then the terminal pane is blank.


MultipartFile.fromFile end with error

My code:
try{
var mpart = MultipartFile.fromFileSync("/storage/emulated/0/SFLink/1582254336015.png",);
}
catch (e){
print(e);
}

And it end with:
RangeError (index): Invalid value: Only valid value is 0: 1
And value of e is :
#0      List.[] (dart:core-patch/growable_array.dart:149:60)
#1      FileUploader.uploadFile (package:xxxxxx/helper/file_upload.dart:25:58)
.....
Issue Info

Info
Value

Platform Name
flutter / ios / android

Platform Version
v1.12.13+hotfix.8/ / 10.0

Dio Version
3.0.8

Android Studio / Xcode Version
e.g. Android Studio 3.3.2 /

Repro rate
e.g. all the time (100%)

Issue Description and Steps
Please fill in the detailed description of the issue (full output of any stack trace, compiler error, ...) and the steps to reproduce the issue.

@shpy2001 how do you solved this


Feat: Search functionality to search repositories

Type of feature
🍕 Feature
Current behavior

Currently the search on repositories is not working, we need to be able to search for repositories.
Try searching for any repository in the search field, it should show the searched repository info.

Suggested solution
The way we can make it work is use the GitHub GraphQL or REST api to search for the repo, then once the user clicks on it, it would filter the search results.
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[X] I agree to follow this project's Contribution Docs

@0-vortex The specific search functionality seems to have been already present. Ref PR: #580
But since there is no visual cue to add org/repo name, users will not be aware of this.
I was thinking if we can add a placeholder like org/repo or something, it will help users to search. Please share your suggestions on this?

Add a placeholder in the input for a full repo name, such as open-sauced/insights is a good idea

Not advocating for Algolia usage, but they have an excellent example of this working.
https://codesandbox.io/s/github/algolia/autocomplete/tree/next/examples/github-repositories-custom-plugin

Not advocating for Algolia (they are expensive) usage, but they have an excellent example of this working.
https://codesandbox.io/s/github/algolia/autocomplete/tree/next/examples/github-repositories-custom-plugin https://www.algolia.com/developers/code-exchange/frontend-tools/autocomplete-to-retrieve-github-repositories/

GitHub search API !!! :D

@SimranjitKaurMaan going to get design to assist on the visual for this.

Search results must be related to the chosen topic though right? Like not just showing any repository

Wouldn't this limit apply to all of the unsigned insights users? Like 10 per minute shared across any users active simultaneously.

Wouldn't this limit apply to all of the unsigned insights users? Like 10 per minute shared across any users active simultaneously.

That is correct, however the rate limit is per request, not per result, so we could likely get all the search results in 1 request, the user would have to complete a search every 5 seconds to actually trigger a rate limit and that is not accounting for server delays; a properly implemented type-ahead like in hot open sauced would do the trick! 🍕

That is correct, however the rate limit is per request, not per result, so we could likely get all the search results in 1 request, the user would have to complete a search every 5 seconds to actually trigger a rate limit and that is not accounting for server delays; a properly implemented type-ahead like in hot open sauced would do the trick! 🍕

but if we had for example 30 users using the website at once, if they all try to search, only 10 of them would get results, and would be just 1 time per minute.

Does this still not work as desired?

Does this still not work as desired? @bdougie Everything seems to be working though I'm wondering if you're seeing something I'm not.

Display-wise it's good, the data is just not fetched from the correct endpoints :D

Do we have a component that shows suggestions for a text input? We need to implement such feature in the Search component to show up the suggestions. @bdougie

Do we have a component that shows suggestions for a text input? We need to implement such feature in the Search component to show up the suggestions. @bdougie

Currently being worked on by @getaheaddev.

Do we have a component that shows suggestions for a text input? We need to implement such feature in the Search component to show up the suggestions. @bdougie

Copy from https://hot.opensauced.pizza

@getaheaddev is working on this

Saw the figma template, the search functionality is very on point even in the github API: https://docs.github.com/en/search-github/searching-on-github/searching-for-repositories#search-by-when-a-repository-was-created-or-last-updated
We can improve the dropdown by making repo details bigger or more visible in the dropdown, but the way we granulate it is pretty fixed :D

Bumping this @bdougie @brandonroberts. Says it has been resolved but we are still having the same issues with our search function.

We just need a better search UI. We are fetching the wrong data when searching.
This is something we can potentially solve with Elastic or similar https://github.com/open-sauced/ops-backend/issues/32


check for mock location

Is it possible to check if the location is mock location ?

Mock location like one of the Apple examples? Not that I know of.


ArmDeploy failure

OK, I'm way out of my depth here but I'm trying to follow the deployment guide. I got to step 3a (ARM template) and it deployed OK the first time I tried it from VS2019, but the web app name I chose the first time was wrong so I needed to change the name and redeploy from scratch. I thought I could do this by deleting the resource group that I created for the SignService app and deploying again from Visual Studio, but every time I try to deploy I get this error:
17:29:58 - New-AzureRmResourceGroupDeployment : 17:29:58 - Resource Microsoft.Web/sites/siteextensions
17:29:58 - '<siteName>/Microsoft.ApplicationInsights.AzureWebSites' failed with message '{
17:29:58 -   "status": "Canceled",
17:29:58 -   "error": {
17:29:58 -     "code": "ResourceDeploymentFailure",
17:29:58 -     "message": "The resource operation completed with terminal provisioning state 'Canceled'."
17:29:58 -   }
17:29:58 - }'

Any help would be gratefully received :)

I'm not sure.... are things completely deleted in Azure? Might take some time for things to finish deleting.

Thanks Claire. I tried leaving it a couple of hours between deleting the resource group and deploying again, and still got the error. I've deleted the RG again now so I'll leave it over the weekend and try again on Monday :)

Happy to jump on a call early next week if it's still not working. Getting things deployed for this is unfortunately the hardest part.

That's extremely kind of you - I'll let you know if I'm still stuck on Monday.

Yep, it seems it just needed to be left for a while after deleting the RG. All good now, thanks :)


fix: Ops require their own extensions

The "fix" here is about three lines in op_def.rs. The rest is basically just updating tests to reflect the extra extension requirements, although there is a two-line fix in infer.rs, see here. I've also done this as a followup to #733, it may be applicable without.
WIP: the fixes here to sibling_subgraph do not look great, I have to say. If we agree this PR is indeed the way forward then we should discuss with @lmondada what to do here.
The test updates are straightforward, but massive, and rather painful. I see at least three options:

Accept this is necessary because of the requirement for lift nodes. But, we can make this a bit less painful in the builder - for example, we could add a lift helper to the builder which just takes wires, and calculates the necessary type-row for them. (Another possibility: with_extension_delta could have variants that take single Extensions rather than a set.)
Live with it for the time being, but reprioritize higher finding an alternative to lift nodes. (Perhaps automatic/automagic lift node "insertion".)
Decide this is too painful for the time being, so hold off merging this to ease other work for the moment (this PR basically makes every test harder to write), and design an alternative.

I guess I'm arguing against doing (1) temporarily and then dropping lift nodes (and removing all those utilities) in the future...
closes #388

Discussion with @ss2165 on 5th Jan - agreed Lift nodes like this are too painful. Hoping to switch to a subset constraint (at validation time) - inference algorithm details TBC...

Superceded by #1226


Add BIP152 (Compact Blocks) structures

Adds the basic structures for BIP152 and a method to create a compact block from a full block.
Depends on https://github.com/rust-bitcoin/bitcoin_hashes/pull/46.

So I understand we don't want a siphasher dependency, but rather a bitcoin_hashes::siphash impl?

yes, siphash is also used in BIP158. It would be better included into bitcoin_hashes

yes, siphash is also used in BIP158. It would be better included into bitcoin_hashes

@tamasblummer
I added a siphash24 module in bitcoin_hashes: https://github.com/rust-bitcoin/bitcoin_hashes/pull/46
Could you check if that suits your need for BIP 158 usage? I'm actually very interested in BIP-158 implementation in rust-bitcoin. Are you planning to do them?

@stevenroose will review tomorrow. I already implemented and using BIP158 in murmel: https://github.com/rust-bitcoin/murmel/blob/master/src/blockfilter.rs

I already implemented and using BIP158 in murmel: https://github.com/rust-bitcoin/murmel/blob/master/src/blockfilter.rs

@tamasblummer would you mind upstreaming that to rust-bitcoin? Into src/util/bip185.rs f.e.?

@tamasblummer I made 2 changes:

HeaderAndShortIds::from_block now takes a version number instead of the use_wtxid bool. It returns an error if the version is not 1 or 2. This is probably better for backwards compatibility when we add support for other versions.
HeaderAndShortIds::from_block now takes an additional &[bool] argument to indicate which transactions to prefill. It must be of length one less than the nb of txs in the block because the coinbase is always prefilled. This is quite rudimentary support for arbitrary fillings. I thought about a closure argument Fn(&sha256d::Hash) -> bool. One could pass a HashSet::contains or HashMap::contains_key into that argument, f.e., as well as a custom method. Would that be a better solution? Thought? @apoelstra @dongcarl

This is rebased and ready to be reviewed. Uses the new bitcoin_hashes siphash impl.

rebased

fixed silly rebasing issue

This PR is passing the tests (except for the one that also fails on master).

Codecov Report

Merging #249 into master will decrease coverage by 1.13%.
The diff coverage is 40.67%.

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
- Coverage   81.89%   80.76%   -1.14%
==========================================
  Files          38       40       +2
  Lines        7169     7209      +40
==========================================
- Hits         5871     5822      -49
- Misses       1298     1387      +89

Impacted Files
Coverage Δ

src/network/mod.rs
0% <ø> (ø)
:arrow_up:

src/consensus/encode.rs
76.77% <ø> (ø)
:arrow_up:

src/util/mod.rs
0% <ø> (ø)
:arrow_up:

src/network/message_blockdata.rs
35.29% <0%> (-1.07%)
:arrow_down:

src/network/message_compact_blocks.rs
0% <0%> (ø)

src/network/message.rs
58.84% <25%> (-9.75%)
:arrow_down:

src/util/bip152.rs
45.33% <45.33%> (ø)

src/network/message_network.rs
25% <0%> (-10%)
:arrow_down:

src/network/stream_reader.rs
95.62% <0%> (-2.06%)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ac252...65cc14e. Read the comment docs.

K I rebased this and updated it to use the new hash newtypes for BlockHash. In one method it expects a "txid" that can be either Txid or Wtxid, so I parametrized that as T: AsRef<[u8]>. Is that to broad? I think it's fine.

Looks like the previous travis failure was a legitimate addition-overflow crash:
thread 'tests::duplicate_crash' panicked at 'attempt to add with overflow', /home/matt/Documents/Projects/Bitcoin/rust-bitcoin/src/util/bip152.rs:284:21
stack backtrace:
...
  14: core::panicking::panic
             at src/libcore/panicking.rs:52
  15: <bitcoin::util::bip152::BlockTransactionsRequest as bitcoin::consensus::encode::Decodable>::consensus_decode
             at /home/matt/Documents/Projects/Bitcoin/rust-bitcoin/src/util/bip152.rs:284
  16: <bitcoin::network::message_compact_blocks::GetBlockTxn as bitcoin::consensus::encode::Decodable>::consensus_decode
             at /home/matt/Documents/Projects/Bitcoin/rust-bitcoin/src/internal_macros.rs:39
  17: <bitcoin::network::message::RawNetworkMessage as bitcoin::consensus::encode::Decodable>::consensus_decode
             at /home/matt/Documents/Projects/Bitcoin/rust-bitcoin/src/network/message.rs:340
  18: bitcoin::consensus::encode::deserialize_partial
             at /home/matt/Documents/Projects/Bitcoin/rust-bitcoin/src/consensus/encode.rs:184
  19: bitcoin::consensus::encode::deserialize
             at /home/matt/Documents/Projects/Bitcoin/rust-bitcoin/src/consensus/encode.rs:168
  20: deser_net_msg::do_test
             at fuzz_targets/deser_net_msg.rs:4

Yeah there was a potential overflow. Amazing!
Fixed that now, also verified that the specific fuzz input no longer causes a panic.

Btw, do you agree with the Core naming of HeaderAndShortId instead of something like CompactBlock?

Yeah, the name is a bit silly, but I prefer following the BIP/Core, less confusing imo than doing our own thing.

Rebased.

@apoelstra @stevenroose I'd like to get this into 0.27, it has been open for far too long and afaik the last iterations were only changing minor things. I hope the CI break is easy to fix.

@apoelstra @stevenroose I'd like to get this into 0.27, it has been open for far too long and afaik the last iterations were only changing minor things. I hope the CI break is easy to fix.

Yeah it looks super easy to fix

Fixed nits and rebased. I couldn't test with 1.29 myself, let's see if CI could.

Needs rebase

Rebased.

@dr-orlovsky Addressed all your derives, had to derive PartialOrd, Ord, Hash on BlockHeader (which tbh I think makes more sense than on most of the compact block types), I did that in a separate commit.

Done review of 1d519df2b300fe5c5c31b5134ffce0a82a501914
ACK except for the thing about witness stripping.
I think this PR beats Carl's PSBT PR for "longest open PR" :)

Nice, was looking for the BIP152 network messages in rust-bitcoin and was about to implement them myself. Will test against Bitcoin Core's network messages and review!

Hey mate, this PR is currently marked as part of the 0.29 milestone, would you like to get this functionality in before the 0.29 release?

I'm interested in seeing this in 0.29. I've rebased this branch on current master: https://github.com/0xB10C/rust-bitcoin/tree/compact-blocks - maybe this helps speed things up. I've been using  68760f50446553de085e2ed320a36e6ff5c1a071 to deserialize Bitcoin Core's compact block P2P messages for more than a month now without problems.

Legend @0xB10C, thanks. Perhaps if @stevenroose does not pick this up in a week or so you could create a PR and just mention that its Steven's work and it supersedes this one [0].  I can do it if you either don't have time or don't feel comfortable doing so.
I'm totally speaking for @stevenroose here, Steven you can go right ahead and slap me if I'm out of place :)
[0]: When doing so I typically add a co-authored-by tag to any commit if I make any non-trivial changes.

Superseded by https://github.com/rust-bitcoin/rust-bitcoin/pull/1088
I've messaged @stevenroose via text also to make sure he is aware of this.


fix: 4056 - fixed List syntax for offline data

What

Fixes a bug about how to modify a List created from an existing const one.

Fixes bug(s)

Fixes: #4056

Codecov Report

Merging #4059 (89e7e4e) into develop (a007367) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4059      +/-   ##
===========================================
- Coverage    11.00%   10.96%   -0.04%
===========================================
  Files          270      270
  Lines        13369    13416      +47
===========================================
  Hits          1471     1471
- Misses       11898    11945      +47

Impacted Files
Coverage Δ

.../smooth_app/lib/query/products_preload_helper.dart
0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

There's one more place which needs the same change

Indeed! I've just committed the additional fix.
Too bad the lint check doesn't detect that error.

@AshAman999 @monsieurtanuki merging


Dont work npm command: npm install ccnet2

Hi!
I tried install plugin from npm repo and received an error:
npm ERR! 404 Not Found: ccnet2
npm ERR! 404
npm ERR! 404 'ccnet2' is not in the npm registry.

Hi!
I'm sorry for this fail, but I never publish this project to npm and forgot about it. I've fixed and published project to npm. Please, be carefully to use this module because it's first version.


Recover middleware

This adds a middleware, middleware::recover::recover_panics, that catches panic! and return 500 instead of crashing.
Some possible enhancements :

Logging the error. Currently, the panic is printed, but it doesn't abort the program.

Also @mehcode, I have a problem because the previous gist (and your modification) isn't currently buildable, because Middleware is implemented for Fn, and the lazy closure is FnOnce only. Do you have an idea for working around the problem ?

@Meralis40 I moved to using cargo workspace and made the changes here to keep it compiling. In doing so I seem to have collapsed the review comments I left. Be sure to expand them and take a look when you have a chance.

@mehcode Thank for correcting the lifetime issue (I totally forgot Arc). I rebased the PR & I also take care of your comments. Maybe we should provide a way to the user to customize the panic case (that currently send back a 500) before merging ?

@Meralis40 Awesome. I switched to using handler::default_catch (added recently) instead of returning 500. The default_catch logs and returns 500.
General error "catching" should probably be implemented but I'd rather leave that to a separate task/PR.
See https://github.com/mehcode/shio-rs/blob/master/lib/src/handler.rs#L13-L23

@mehcode I've rebase the PR & made the requested changed.

Thanks for getting this done @Meralis40 🎉

@Meralis40 As "recovering from panics" is arguably pretty important I went and included this in the default middleware stack.


Add missing toString methods to PlaceRequest sub types

Add test to ensure onSelectPlaceEvent sets focus on correct presenter

+1 thanks @csadilek

@mcimbora this fix the project explorer file select issue. Thanks for pointing out

@ederign @csadilek Works like a charm now, thanks for a quick reaction!


Roll Engine from 7bf74069a5cd to d05d681a841e (8 revisions)

https://github.com/flutter/engine/compare/7bf74069a5cd...d05d681a841e
2022-02-08<EMAIL_ADDRESS>[fuchsia] Allow multiple vsync requests before the first Present (flutter/engine#31316)
2022-02-08<EMAIL_ADDRESS>Roll Skia from 8e7c2ae4f78e to 1048287b5dce (7 revisions) (flutter/engine#31330)
2022-02-08<EMAIL_ADDRESS>Enable DisplayList benchmarks to be built on Android (flutter/engine#31268)
2022-02-08<EMAIL_ADDRESS>Roll Skia from 8d646c127a7b to 8e7c2ae4f78e (10 revisions) (flutter/engine#31329)
2022-02-08<EMAIL_ADDRESS>Roll Skia from 26e128593295 to 8d646c127a7b (5 revisions) (flutter/engine#31328)
2022-02-08<EMAIL_ADDRESS>Roll Dart SDK from 55c93c732da9 to 2c49460fac88 (1 revision) (flutter/engine#31327)
2022-02-08<EMAIL_ADDRESS>Roll Skia from 507b6dd516b5 to 26e128593295 (1 revision) (flutter/engine#31326)
2022-02-08<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from yR4db-Xiv... to Ba1d6e-yV... (flutter/engine#31325)
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from yR4db-XivYmx to Ba1d6e-yVf1k
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Set the default language trying to get it from the browser, or from the system locale (Node.js).

The module could try to get the language from navigator.language, or from the system local when running on Node.js, to set it as the default language. Instead of having 'en' hardcoded.

I'm pretty hesitant to do this for a few reasons.

This would be a breaking change and certainly a big feature—something larger than I am willing to take on as a maintainer (see #120).
We'll always need to have a fallback anyway.
We'll need to have pretty significantly different code paths for Node and the browser. And what about other, more obscure JS environments like Rhino?
Will there be problems reliably detecting Node in environments like Browserify?
The code for determining locale in Node is pretty significant. We could include that as a dependency in Node only, but that gets hairy in part because of the previous point and in part because

That being said, I think this is a great candidate for something that should be documented as an example.
What do you think?

@EvanHahn, ok, but do you think it would be really useful to have a snippet for that as an example? My initial idea was to reduce the code needed to accomplish that, as I believe this is a common case and people are probably already doing it by hand.

I'm not sure how many other people have this issue. If lots of other people do this, I think the snippet is helpful. We could put it lower down in the readme or even in the GitHub wiki.
Or what about a companion library that grabs the language? Something like this:
const humanize = humanizeDuration.humanizer({
  language: getLanguage(navigator.language)
})

Neither of these require code changes to the library.

"I'm not sure how many other people have this issue. If lots of other people do this..."
I believe this is probably a very common use of this library. I can think quickly about some scenarios:
A app with i18n is being created (front-end)
The goal would be to show it using the same language as the user (supposing that the whole app in case has support for the user language). Guessing from the user's environment will be needed.
Creating a program for use internally, by one and his team (back-end)
The goal would be to have it using the same language as the people from the team, and they are not from some country with English as the main english. A language setup will be needed, and if it could get from their own environment, everything would be already set.
A app without i18n is being created (front-end)
The goal would be to have it using one unique language. Even if we think that, for example, an app in portuguese would be probably be used only on portuguese countries, so guessing from the user could also work well In this case. I believe that would be better to harcoded it. Just to maintain an integrity if someone from another language would end up using the app.
But I'm bringing these just to explain about why i have thought about that. I got your point. Maybe examples could solve better at this time.

I think you're totally right.
Do you want to make a pull request to add an example to the readme? You
could also comment below and I could add it myself.

I'll find some time to do that.

Hi @EvanHahn. Sorry, I'm currently having just a bit of free time per day and I'm using it to finish a new module that I've been creating. The idea is to release it soon. So after that maybe I can get back to this issue, ok?

I'm going to close this issue because this module is in maintenance mode (see #120). Feel free to continue discussion here and we can see about adding something to the readme or endorsing a fork.


Fix codegen_atomic_binop for atomic_ptr

Fetch functions of atomic_ptr calls atomic intrinsic functions with pointer-type arguments (invalid_mut), which will cause typecheck failures. The change in this commit add support of pointer-type arguments into codegen_atomic_binop to fix the issue. The new codegen_atomic_binop will cast pointer arguments to size_t, apply op on them, and then cast the op result back to the pointer type.
The new test include all fetch functions of atomic_ptr except for fetch_ptr_add and fetch_ptr_sub, which do not call intrinsic functions.
Resolves #3042.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

Partially resolve #25. The benchmarks included in this PR test atomic intrinsic with type of *mut i64.


install fails on windows

Any further input? Like a Screenshot or something...
Which Windows Version?
Which Node.JS Version?
Which NPM Version?
It looks for me as it might be relevant to missing CSHARP Libs that are required for Windows in order to compile native libs.


World not showing up

Error occuring when putting world in, it imports perfectly fine but world does not show up at all and works fine when I delete all data and let xbox cloud sync it

Closing the issue, found a fix for anyone having a struggle with version mismatch etc...
Import the save file WHEN Palworld is open

can you teach us how to use it? I couldn't manage

can you teach us how to use it? I couldn't manage

Make sure the name of your save file you exported originally is renamed, or it will already exist in your Xbox cloud and will return an error saying it already exists.
For example, my folder was called "1CF68C534659F73A3D3841BE8B615C59" which returns an error. Simply rename the folder, either change the name completely or add/remove a couple letters or numbers.
Once done, open Palworld on Xbox and wait until your cloud has synced, once done you can then drag your folder into the .exe and it will add the save file.
Reboot Palworld and see if the world has appeared, if not try repeating again with administrator on the .exe
If it has shown up, make sure you let the cloud sync once closing before trying to access on another Xbox device, if you are playing on your PC version then go ahead and play the world

but where I should put the exe? In the saves folder?

I extracted the folder, it came in .rar, I edited what I want, and I'm trying to convert the .rar back to the save files, it is not working here

I extracted the folder, it came in .rar, I edited what I want, and I'm trying to convert the .rar back to the save files, it is not working here

Are you trying to import the .rar file?
Needs to be the folder, it should just be a singular folder with a long string of text

yes i'm lol
The extractor creates the folder and a .sav file, I dont need the .sav file?

thank you very much, it worked :)

thank you very much, it worked :)

Glad it worked, was just about to reply, yeah you only need the folder


Update EntityGenerator.php

orm:generate:entities genrates 2 blank lines
PSR2: All PHP files MUST end with a single blank line.
this worked for me

first blank line because:
`protected static $classTemplate =
'<?php

{

}
';`
second because method generateEntityClass()

Not requiring a test for this one, since the EntityGenerator is far from critical, but please do submit PRs with tests next time.


Usability of IFE-related endpoints in the Watcher

List of recognized issues:

[ ] When calling status.get available piggybacks are reported as byzantine events
[ ] IFE's that are never piggybacked, don't have a notion of being finalized. Will always show up in in_flight_exits and available_piggybacks

Thanks! closing in favor of the other bucket-issue #811, that one has more intel


Custom resolution support?

I have no idea what is the correct place to ask and what piece from SPICE mess does handle resolution, but anyway.
In the spice documentation there is described ability to adjust vm resolution to host spice client window size, however, this have not worked at all, ever.  (Even on Windows 7 VMs)
So hence the question, is there a way to actually force a custom resolution? I'm up for any ways (console command with magic numbers, magic numbers + device guid's in registry, you name it)

For SPICE related question you can try asking spice developers at spice-devel list - http://lists.freedesktop.org/mailman/listinfo/spice-devel
From my own experience - arbitrary resolutions feature works flawlessly on Windows 7.
Do you have virtio-serial device driver and vdagent service installed and running on your system?

Hm, I tired with spicy and it does adjust it, but only to resolutions that are available by Change Resolution screen, and not really making custom resolution with the side of the window.

Win7 or 8 ? Can you confirm that vdagent is up and running on your system?

Server 2012 r2, effectivly its win8. Spicy is in status bar is telling: Cursor: Server, Agent: yes

Probably not yet supported by vdagent. For more information please visit the following link - https://bugzilla.redhat.com/show_bug.cgi?id=895356#c93

Thanks for clarification!


Adding Unit Tests

Related to #1

Coverage increased (+2.05%) to 63.688% when pulling 797eee168bee78c1ee5b3aeea7c1eb65edb6f6e3 on improve-tests into 6293c37fe1580a678a1739c81e1e73ca323667f5 on master.

Coverage increased (+3.9%) to 65.557% when pulling da7ace74b59cb107061d9ae916ea0092c295dabb on improve-tests into 6293c37fe1580a678a1739c81e1e73ca323667f5 on master.

Coverage increased (+3.9%) to 65.557% when pulling c72765ee4dbd5e991dbc6ec23a4477523044bd1f on improve-tests into 6293c37fe1580a678a1739c81e1e73ca323667f5 on master.