Add support for Scalajs 1.x.x

This PR adds support for Scalajs 1.x.x (note that Scalajs 0.6.x is no longer maintained nor supported). Since Scalajs 1.x.x doesn't support Scala 2.11.x, its support was dropped.

Note that I haven't bumped the version in this PR although I believe that 0.3.0 is appropriate.

Note that I haven't bumped the version in this PR although I believe that 0.3.0 is appropriate.

I'll try reversion and publish later today if time permits.

I'll try reversion and publish later today if time permits.

Perfect, thank you!

Perfect, thank you!

Sorry it took so long, should show up on Maven central shortly.  If not please ping back.

Sorry it took so long, should show up on Maven central shortly.  If not please ping back.


[core] Fix duplicate primary keys in query results

Purpose

Linked issue: #3157

Because the same builder is used in the for loop of generateSplits in SnapshotReaderImpl, if rawConvertible is true the last time, it will affect the value of the next Datasplit rawFiles. The ultimate result is the need for MergeRedier's Datasplit, as rawFiles were mistakenly set and NoMergeReader was created, resulting in duplicate data during reading

Tests

API and Format

Documentation

Thanks for pointing it out!

+1


Added dependencies.yml action

Description
Added a github action to build flow-cli from main with flow-emulator dependency replaced by sources in this commit. This step makes sure that the current update to emulator doesn't break the flow-cli

For contributor use:

[ ] Targeted PR against master branch
[ ] Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
[ ] Code follows the standards mentioned here
[ ] Updated relevant documentation
[ ] Re-reviewed Files changed in the GitHub PR explorer
[ ] Added appropriate labels

Is this the correct approach? Shouldn't the emulator sometimes break flow-cli?
I feel like, it will end up with a 'die hard' situation[0] as currently we have with flow-go and flow-emulator.

update emulator ( oh it breaks cli cant merge )
go to cli, update cli dependency to commit hash of this emulator PR, fix changes
go to emulator, make a release
go to cli, update cli dependency to release

[0] https://www.youtube.com/watch?v=BVtQNK_ZUJg

Is this the correct approach? Shouldn't the emulator sometimes break flow-cli?
I feel like, it will end up with a 'die hard' situation[0] as currently we have with flow-go and flow-emulator.

update emulator ( oh it breaks cli cant merge )
go to cli, update cli dependency to commit hash of this emulator PR, fix changes
go to emulator, make a release
go to cli, update cli dependency to release

[0] https://www.youtube.com/watch?v=BVtQNK_ZUJg

If we have a situation where the emulator has to break cli for a long time it means that we in fact managing two active versions of both. In this case the solution is to open a new branch on both repos and manage them in parallel testing the dependency chains separately in each branch.

The main goal is to identify PRs that break CLI. What we do with this is a matter of policy and should be adjusted based on the frequency and availability. At this stage there is not intent to block PRs due to failure of this test.
In the next step I will add slack notification when the test fails and will be monitoring it with the goal to coordinate CLI update that will fix the build.
I think we all can agree on two things:

The sooner we address the breaking change on the CLI side, the less effort it will require
It is better to know that the build fails rather than being surprised by it when we need to release the next CLI version

I am Github noob but I think solution for your problem is Dependabot and semver @gpavlov2016. PR hook is a really bad idea for what you are trying to do.
You should define Dependabot action (or some similar action) on CLI repo, which will watch Releases ( you can set interval ) from flow-emulator. Then alert you if something breaks.

The sooner we address the breaking change on the CLI side, the less effort it will require
Yeah totally agreed

It is better to know that the build fails rather than being surprised by it when we need to release the next CLI version
I think best is to auto create an issue on flow-cli repository ( with Dependabot on similar )  on new Emulator release.

I am Github noob but I think solution for your problem is Dependabot and semver @gpavlov2016. PR hook is a really bad idea for what you are trying to do.
You should define Dependabot action (or some similar action) on CLI repo, which will watch Releases ( you can set interval ) from flow-emulator. Then alert you if something breaks.

The sooner we address the breaking change on the CLI side, the less effort it will require

Yeah totally agreed

It is better to know that the build fails rather than being surprised by it when we need to release the next CLI version

I think best is to auto create an issue on flow-cli repository ( with Dependabot on similar ) on new Emulator release.

Unfortunately, detecting breaking changes when emulator is being released is too late. By that time the build might have been broken for several weeks, and the person that made the changes is unavailable to help. Moreover, usually when emulator is released, the CLI needs to be released as well which will not be possible due to breaking changes.
I can't find any significant problem with adding additional non-blocking check to the CI, would you mind elaborating why do you think it's a bad idea?

Unfortunately, detecting breaking changes when emulator is being released is too late.

But if the change isn't yet released how would we make the PR on the dependant tool? I think dependabot actually waits for a release because at that point you can act and that's intentionally by design it's not because they didn't think of this. Doing that sooner would require targeting a specific commit has as a version in that branch which is not a good practice. Or we will be forced to have PRs that will sit there for several weeks (like you said it can take) and might get outdated during that time as changes will be done on other parts. I think if merged PRs sit there for weeks then the core problem is we should be doing more smaller releases, which we can also automate.

rather than being surprised by it when we need to release the next CLI version

We are not surprised by the new version of the emulator breaking the CLI during release. That is a natural process when updating a dependency, you make a PR to update the version of the emulator and do any changes that potentially broke APIs. The only "surprises" that came were platform-specific issues that were only detected on that platform.

I can't find any significant problem with adding additional non-blocking check to the CI, would you mind elaborating why do you think it's a bad idea?

I think the issue is it will force us to ignore failed CI actions.


Using SpecFlowStepDefinitionReport on my macOS I receive the following error:
NConsoler.NConsolerException: Could not find file "/Users/cosminstirbu/xamarin-continuous-integration/UITests/Features\AddItem.feature" ---> System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.IO.FileNotFoundException: Could not find file "/Users/cosminstirbu/xamarin-continuous-integration/UITests/Features\AddItem.feature"
  at System.IO.FileStream..ctor (System.String path, System.IO.FileMode mode, System.IO.FileAccess access, System.IO.FileShare share, System.Int32 bufferSize, System.Boolean anonymous, System.IO.FileOptions options) [0x0019e] in <4fdc5ed61a074cafb49fa42deb20d521>:0
  at System.IO.FileStream..ctor (System.String path, System.IO.FileMode mode, System.IO.FileAccess access, System.IO.FileShare share, System.Int32 bufferSize, System.IO.FileOptions options, System.String msgPath, System.Boolean bFromProxy, System.Boolean useLongPath, System.Boolean checkHost) [0x00000] in <4fdc5ed61a074cafb49fa42deb20d521>:0
  at (wrapper remoting-invoke-with-check) System.IO.FileStream:.ctor (string,System.IO.FileMode,System.IO.FileAccess,System.IO.FileShare,int,System.IO.FileOptions,string,bool,bool,bool)
  at System.IO.StreamReader..ctor (System.String path, System.Text.Encoding encoding, System.Boolean detectEncodingFromByteOrderMarks, System.Int32 bufferSize, System.Boolean checkHost) [0x00067] in <4fdc5ed61a074cafb49fa42deb20d521>:0
  at System.IO.StreamReader..ctor (System.String path, System.Text.Encoding encoding, System.Boolean detectEncodingFromByteOrderMarks, System.Int32 bufferSize) [0x00000] in <4fdc5ed61a074cafb49fa42deb20d521>:0
  at System.IO.StreamReader..ctor (System.String path, System.Boolean detectEncodingFromByteOrderMarks) [0x0000d] in <4fdc5ed61a074cafb49fa42deb20d521>:0
  at System.IO.StreamReader..ctor (System.String path) [0x00000] in <4fdc5ed61a074cafb49fa42deb20d521>:0
  at (wrapper remoting-invoke-with-check) System.IO.StreamReader:.ctor (string)
  at TechTalk.SpecFlow.Reporting.ParserHelper.GetParsedFeatures (System.Collections.Generic.IEnumerable`1[T] featureFiles, System.Globalization.CultureInfo featureLanguage) [0x0001d] in <dd68423b6b61475aaa5190469901b762>:0
  at TechTalk.SpecFlow.Reporting.ParserHelper.GetParsedFeatures (TechTalk.SpecFlow.Generator.Project.SpecFlowProject specFlowProject) [0x0003e] in <dd68423b6b61475aaa5190469901b762>:0
  at TechTalk.SpecFlow.Reporting.StepDefinitionReport.StepDefinitionReportGenerator..ctor (TechTalk.SpecFlow.Reporting.StepDefinitionReport.StepDefinitionReportParameters reportParameters) [0x00029] in <dd68423b6b61475aaa5190469901b762>:0
  at TechTalk.SpecFlow.Tools.Program.StepDefinitionReport (System.String projectFile, System.String xsltFile, System.String binFolder, System.String outputFile, System.Boolean verboseOutput, System.Boolean requestDebuggerToAttach) [0x00014] in <5cf3c66ae7b342aea3d8fc469832c24d>:0
  at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (System.Reflection.MonoMethod,object,object[],System.Exception&)
  at System.Reflection.MonoMethod.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00032] in <4fdc5ed61a074cafb49fa42deb20d521>:0
   --- End of inner exception stack trace ---
  at System.Reflection.MonoMethod.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00048] in <4fdc5ed61a074cafb49fa42deb20d521>:0
  at System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) [0x00000] in <4fdc5ed61a074cafb49fa42deb20d521>:0
  at NConsoler.Consolery.InvokeMethod (System.Reflection.MethodInfo method) [0x00009] in <5cf3c66ae7b342aea3d8fc469832c24d>:0
   --- End of inner exception stack trace ---
  at NConsoler.Consolery.InvokeMethod (System.Reflection.MethodInfo method) [0x0002b] in <5cf3c66ae7b342aea3d8fc469832c24d>:0
  at NConsoler.Consolery.RunAction () [0x0004e] in <5cf3c66ae7b342aea3d8fc469832c24d>:0
  at NConsoler.Consolery.Run (System.Type targetType, System.String[] args, NConsoler.IMessenger messenger) [0x00008] in <5cf3c66ae7b342aea3d8fc469832c24d>:0

I think the issues comes from ** being appended instead of / in /Users/cosminstirbu/xamarin-continuous-integration/UITests/Features\AddItem.feature
What is Expected?
SpecFlowStepDefinitionReport should not throw exception
What version of Cake are you using?
0.23.0
Are you running on a 32 or 64 bit system?
64
What environment are you running on?  Windows? Linux? Mac?
macOS 10.12.6
Are you running on a CI Server?  If so, which one?
No. I'm running it on my local macOS 10.12.6 machine
How Did You Get This To Happen? (Steps to Reproduce)
Checkout https://github.com/FortechRomania/xamarin-continuous-integration/tree/SpecFlowStepDefinitionReport and run
./build.sh --settings_skipverification=true --target=SpecFlowDefinitionCheck
Output Log
https://gist.github.com/cosminstirbu/3c810ddfcb12a3e1d9e39a070a9f8558

It seems like this is a issue with SpecFlow itself. When running a StepDefinitionReport you just give the path to thecsproj containing your .feature files. SpecFlow seems to create the path incorrectly (using \ instead of / as the last directory separator).
Can you reproduce same issue without Cake by running mono tools/specflow/SpecFlow/tools/specflow.exe stepdefinitionreport "/Users/cosminstirbu/xamarin-continuous-integration/UITests/Jenkins.UITests.csproj"?

Hi @mholo65
You are right, the issue reproduces even if I use specflow.exe directly.
I've even updated to the latest Specflow version 2.2.1 and it still reproduces.
I'll create a ticket on the Specflow project, you can close this one.
Thank you!

Thanks for testing. Closing this as issue is in SpecFlow.

Just for reference, in case anyone hits this issue - this is the Specflow corresponding issue: https://github.com/techtalk/SpecFlow/issues/975


chore: update data

Going to commit today's change here too in a bit.

sounds good

I made quests parser fallback to Wikia Japanese strings so that more quests are translated.


PDF Generation Issues

See http://www.box.com/s/m77src0dlakrulnoahcu
Overall the layout is not sufficiently high resolution, consistent or polished to qualify as "publication ready"
We may need to do a set of mockups to find an acceptable presentation.
Specific issues:

District Builder is mispelled.
DistrictBuilder logo should appear in footer, along with plan information -- author, date (same as plan chooser)
Need proper layout with a header legend, image, footer frame that would be acceptable for publication in a newspaper.
Superflous open layers logo nees to be removed
Transparency settings on layers should be honored
Font sizes types, and legend element sizes are inconsistent
Fonts are bitmapped and pixellated
Image is low res, pixellated, not well cropped
Excessive white space in portrait layout, use landscape layout.

additional issue: Note that PDF generation fails if choro layers are set to "none"


Control animations/duration

TL;DR - can we have photo display animations configurable?
Currently we have nice animations on delete, move. Also nice "blackout" effect on next/prev. photo.
It's ok when we have few hundreds pix. But when there are thousands of them, effects don't add much value.
I tried to find where lychee.animate function gets it's delay but no luck (spent not so much time, i will debug more).
Maybe we can have simple/no animation effects, like fancybox "none" or something like that? Currently if you just move trough photos forward/back it's blinking ("zooming") a lot and i already know at least two ppl who won't watch because they are very sensitive to such blinking.

@SerenaButler might have some hint for you.
Also this should work: https://github.com/LycheeOrg/Lychee/wiki/FAQ#how-to-disable-the-zoom-animation-while-browsing-pictures

Additionally having a setting for that is quite difficult to set up. :/

Thank you! Was looking for FAQ on link which is bottom of this page: https://github.com/LycheeOrg/Lychee-Laravel - but it points to non-existing page, so i decided that FAQ does not exists - and should be checking Lychee FAQ for that.
Looks good, without animations it's much better, thanks!
(1000+ photos and growing fast, should import ~1K more photos, will see how it's going ;-)

I'm running Lychee-Laravel with 4000 pictures :+1:  :smile:


Stream output while subprocess is running

Feedback Welcome
This PR reimplements Bkt::execute_subprocess() and its callers to support streaming the subprocess' output while it's running, rather than blocking silently until the subprocess finishes.
I'm positing this as a PR to solicit feedback before merging, so please feel free to weigh in on any parts of this change you think could be improved. Some areas for potential feedback:

The signatures and ergonomics of the affected and new methods

In particular the impl Write+Send trait bound (which prevents us from using StdoutLock/StderrLock because they are not Send)

The use of scoped threads to avoid the 'static trait bound
Error handling and Result propagation

Notably, currently the .join() calls are .expect()-ed because they don't seem to be compatible with ?

The DisregardBrokenPipe behavior, and whether it should be moved into the library core

Fixes #31

Moving this out of the PR description before merging:

I'm positing this as a PR to solicit feedback before merging, so please feel free to weigh in on any parts of this change you think could be improved. Some areas for potential feedback:

The signatures and ergonomics of the affected and new methods

In particular the impl Write+Send trait bound (which prevents us from using StdoutLock/StderrLock because they are not Send)

The use of scoped threads to avoid the 'static trait bound
Error handling and Result propagation

Notably, currently the .join() calls are .expect()-ed because they don't seem to be compatible with ?

The DisregardBrokenPipe behavior, and whether it should be moved into the library core


Add parcel data for Macomb County, Michigan

homepage: https://gis.macombgov.org/portal1/home/
probable ArcGis layer: http://gis.macombgov.org/arcgis1/rest/services/Hosted/SAW_Parcels/FeatureServer/0

Can be closed - this is addressed (har) by https://github.com/openaddresses/openaddresses/pull/1409


Bump Quarkus to 2.8.2.Final

Failing due to missing quarkus maven plugin artifact for the version 2.8.2.Final: https://mvnrepository.com/artifact/io.quarkus/quarkus-maven-plugin


Segmentation fault

code does not run as stated in readme document

A running code is available  : https://github.com/simpyparveen/TinyDTLS


Prevent logging all the JSDOM internal errors.

Summary

Fixes #5266

Test plan
Not sure what to do for this.

@kentcdodds I was going over this again while writing testcases, I began to wonder.
My code that I have written is expected to run on latest browsers (Firefox/Chrome) which have these sort of functionality. So I shouldn't be changing my code just to make it run on jest.
Thoughts?

I agree with you philosophically, but the fact of the matter is that those APIs are not supported by jsdom. You could try to implement them yourself if you like. I do that with localStorage and sessionStorage. The reason jsdom doesn't implement all APIs is because some of them are not possible to implement with 100% spec compliance. But most of the time you don't need to worry about edge cases so providing your own implementation isn't a big deal (and often isn't terribly difficult).
Good luck!

Where is jest-env-chrome when we want it!! :P
PS: I've mocked localStorage and sessionStorage too.

There is a jest-env-webdriver 😉

Cool I'll try it out!!

If you don't want to change your code to use location.assign - this seems to work with JSDom 11 (though there's a chance JSDom might break it in the future...)
delete window.location;
window.location = {}; // or stub/spy etc.

I'm pretty sure that JSDOM 12 added support for localStorage and sessionStorage. I've removed my polyfils.


fix: Rename defaultContentType to differentiate between request & response

Describe the feature
Right now we hardcode defaultContentType to always be "application/x-www-form-urlencoded". While this is correct for requests, it is incorrect for responses which should have a defaultContentType = "text/xml". This issue is mentioned in the following comment:
// TODO: Rename defaultContentType to differentiate between request & response
Include looking at the Smithy 2.0 docs to ensure that our implementation of awsquery follows the protocol specification properly.
Use Case
We should correctly set the content type of responses to text/xml
Proposed Solution
Refactor this code to correctly differentiate between request/response and set the content type accordingly.
Other Information
Related Issue: #710
Acknowledgements

[ ] I may be able to implement this feature request
[ ] This feature might incur a breaking change

After investigation, reached conclusion that the mentioned TODO item isn't referring to renaming the value of the variable but rather the name of the variable itself. The value of the variable is supposed to be fixed at "application/x-www-form-urlencoded" and no change is needed. TODO item is likely referring to renaming defaultContentType variable to something like defaultRequestContentType to erase possible confusion arising from different default content types of response and request of AWS query protocol (response content type is text/xml).
Confirmed that the SDK works correctly currently, using STS::GetCallerIdentity which uses AWS query protocol. The returned content type is text/xml as expected and response is correctly deserialized.
System works correctly already, and the original thought process behind adding this TODO doesn't really make sense given the SDK obviously only sets content type of requests. Will proceed with just deleting TODO item and submitting PR.

https://github.com/awslabs/aws-sdk-swift/pull/1288

Shipped in AWS SDK for Swift 0.34.0


HTTP Host Availability (the doctor check crashed)    - Android Studio - flutter doctor -v

Cant Build app, while try to run flutter doctor -v command below message i am getting.
Let me know if there is any solution for this.
I have disabled firewall and antivirus still the same issue is there.

 C:\Windows\System32>flutter doctor -v
[√] Flutter (Channel stable, 2.10.3, on Microsoft Windows [Version 10.0.19043.1586], locale en-IN)
    • Flutter version 2.10.3 at C:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 7e9793dee1 (3 weeks ago), 2022-03-02 11:23:12 -0600
    • Engine revision bd539267b4
    • Dart version 2.16.1
    • DevTools version 2.9.2

[√] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc1)
    • Android SDK at D:\JAY DATA\MyProjects\Android\android-sdk\
    • Platform android-32, build-tools 33.0.0-rc1
    • ANDROID_HOME = D:\JAY DATA\MyProjects\Android\android-sdk\
    • ANDROID_SDK_ROOT = D:\JAY DATA\MyProjects\Android\android-sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.11+9-b60-7590822)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[X] Visual Studio - develop for Windows
    X Visual Studio not installed; this is necessary for Windows development.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[√] Android Studio (version 2021.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+9-b60-7590822)

[√] VS Code (version 1.64.2)
    • VS Code at C:\Users\jay\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.34.0

[√] VS Code, 64-bit edition (version 1.54.2)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.34.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19043.1586]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 99.0.4844.82
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 96.0.1054.53

[☠] HTTP Host Availability (the doctor check crashed)
    X Due to an error, the doctor check did not complete. If the error message below is not helpful, please let us know
      about this issue at https://github.com/flutter/flutter/issues.
    X HandshakeException: Handshake error in client (OS Error:
        BLOCK_TYPE_IS_NOT_01(../../third_party/boringssl/src/crypto/fipsmodule/rsa/padding.c:108)
        PADDING_CHECK_FAILED(../../third_party/boringssl/src/crypto/fipsmodule/rsa/rsa_impl.c:676)
        public key routines(../../third_party/boringssl/src/crypto/x509/a_verify.c:108)
        CERTIFICATE_VERIFY_FAILED: certificate signature failure(../../third_party/boringssl/src/ssl/handshake.cc:393))
    • #0      _SecureFilterImpl._handshake (dart:io-patch/secure_socket_patch.dart:104:46)
      #1      _SecureFilterImpl.handshake (dart:io-patch/secure_socket_patch.dart:147:25)
      #2      _RawSecureSocket._secureHandshake (dart:io/secure_socket.dart:803:54)
      #3      _RawSecureSocket._tryFilter (dart:io/secure_socket.dart:933:19)
      <asynchronous suspension>

! Doctor found issues in 2 categories.

2. while run the app / build apk from android studio getting below error:
Please give any solution for this...

Downloading android-arm-profile/windows-x64 tools...                3.5s
Downloading android-arm-profile/windows-x64 tools...               110ms
Failed to download https://storage.googleapis.com/flutter_infra_release/flutter/bd539267b42051b0da3d16ffa8f48949dce8aa8f/android-arm-profile/windows-x64.zip. Ensure you have network connectivity and then try again.
HandshakeException: Handshake error in client (OS Error:
	BLOCK_TYPE_IS_NOT_01(../../third_party/boringssl/src/crypto/fipsmodule/rsa/padding.c:108)
	PADDING_CHECK_FAILED(../../third_party/boringssl/src/crypto/fipsmodule/rsa/rsa_impl.c:676)
	public key routines(../../third_party/boringssl/src/crypto/x509/a_verify.c:108)
	CERTIFICATE_VERIFY_FAILED: certificate signature failure(../../third_party/boringssl/src/ssl/handshake.cc:393))

I am unable to replicate this behavior after running flutter doctor on Windows machine.
[√] Flutter (Channel stable, 2.10.1, on Microsoft Windows [Version 10.0.19042.1526], locale en-US)
[√] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
[√] Chrome - develop for the web
[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.11.2)
[√] Android Studio (version 2021.1)
[√] VS Code (version 1.62.3)
[√] Connected device (3 available)
[√] HTTP Host Availability

Keeping it open and labeling for further insights from the team.

/cc @christopherfujino


Not able to create a notebook

Hello, trying to follow this tutorial to deploy Kubeflow on top of CDK. Everything seems to be deployed but I'm not able to create a new notebook:
The output of "kubectl get pods -A":
https://paste.ubuntu.com/p/BzTnJX8Y76/
The output of "kubectl logs --tail 1000 --all-containers -l juju-app=jupyter-controller -n kubeflow" :
https://paste.ubuntu.com/p/sBCpb3txjD/

A potential workaround is:
Create a yaml file that contains: https://paste.ubuntu.com/p/9ScsWQdNqp/
Then kubectl apply -n kubeflow -f


Fix agent version in release pipeline yml

Failing pipeline url: https://dev.azure.com/ms/azure-devops-cli-extension/_build?definitionId=36&_a=summary

Just for information though.. Why do we have the tests running on release branch? They are not live tests so when would they fail?

Just for information though.. Why do we have the tests running on release branch? They are not live tests so when would they fail?

When there is some issue with env:
example: latest azure cli is not working with our released whl
or anything like that where existing whl breaks due to some change in some other thing which we depend on
other example is
we have dependency on package "X" (with latest) then we did a release
then we remove dependency on package "X"
now if somehow "X" screws up (like msrest did earlier) then we will not now that released wheel is broken


fix: caching

See #73

[x] Explicit caching strategies (@MattIPv4 's comment)
[x] Only cache 2XX responses, and if they're get Requests (explicit cache) (already true)
[x] Our default responses (on the constants) should have explicit headers for no-cache/no-store
[x] 5XX responses also should not have cache (already true)
[x] We should extract many other implicit constants ... to proper constant files

Quick question, do we need to also add CACHE_HEADERS.failure to our 5XX responses? (the try/catch on the worker.ts?)

That is also a part of this pr

Quick question, do we need to also add CACHE_HEADERS.failure to our 5XX responses? (the try/catch on the worker.ts?)

That is also a part of this pr

Oh I somehow didnt see this, still not seeing it 🤔 can you point me to the diff?

Oh I somehow didnt see this, still not seeing it 🤔 can you point me to the diff?

https://github.com/nodejs/release-cloudflare-worker/pull/75/files#diff-1245a5bbc4ca0684dff978efcae118b08f62d2afc05812df22d0627985b4273aR51


Android App denied: "Your app is not compliant with Google Play Policies"

I use background_locator and the App was denied. I have to show a Pop-Up with some Infos.
Has anyone already had the same problem and can tell me how and where I can install the PopUp?

Prominent disclosure not found
Your app must display a prominent disclosure through a pop-up alert before your app’s location runtime permission. Based on our review, a prominent disclosure did not appear before the runtime permission.
Please add a prominent disclosure before the runtime permission.
Remember, your prominent disclosure must:
Appear before your app’s location runtime permission.
Include at least the following sentence, adapted to include all the relevant features requesting access to location in the background in the app that are readily visible to the user: “This app collects location data to enable ["feature"], ["feature"], & ["feature"] even when the app is closed or not in use.” If you extend permitted usage to ads, please also include: “This data is also used to provide ads/support advertising/support ads.”
Include any other details necessary to make it clear to the user how and why you are using location in the background. While additional content is permitted, it should not cause the required content to not be immediately visible.

Hi @marcoheine
Thank you for opening an issue.
I think it would be nice to show that dialog before asking location permission.

Hi @marcoheine
Thank you for opening an issue.
I think it would be nice to show that dialog before asking location permission.

@marcoheine
This is a new policy of Google and you need to show a dialog warning user that you are going to use background location.
You also need to record the screen of the app the moment this dialog appears, upload the video at YouTube for example and post it on PlayStore (location permission topic).

@marcoheine
This is a new policy of Google and you need to show a dialog warning user that you are going to use background location.
You also need to record the screen of the app the moment this dialog appears, upload the video at YouTube for example and post it on PlayStore (location permission topic).


Add temporary option for Guoba swirl onto Sucrose E

Un-needed with the refactor.

implementation added in #122


Null result when Eager loading with specified field

Laravel Version: 5.6.5
PHP Version: 7.2.0-1
Database Driver & Version: Mysql 5.6

Description:
I've got a null result in relation when trying to eager loading with select
Steps To Reproduce:
in CartController.php
$cart = $this->cart->list($id);
in model Cart.php
`
public function scopeList($query, $user_id)
{
    return $query->select( 'id','product_id','quantity','information','branch')
            ->with('product:name,price,photo_list,photo')
            ->where('user_id',$user_id)->orderBy('created_at','desc');

}

`
and the result

but if eager loading without select
the relations is working

You must select the product id
->with('product:id,name,price,photo_list,photo')

Now its work..
its weird why do I need to add foregin key field?
While in the documentation No need to add

When you do ->with('product:name,price ...') you are explicitly telling eloquent what columns to select, as you can see the id field isn't included.
This is from the docs


Fix git-diff with mnemonicprefix option

With diff.mnemonicprefix, the prefixes would not be just a and b,
and therefore the regexp would not match.
This also refactors _execute into _run_diff.
This could be improved further by making git not use any user
configuration, e.g. by setting $HOME to /dev/null.

Tests need to be fixed, but I'll wait for feedback on if this is the right way to go.

@blueyed looks reasonable Once the tests are happy I can give it a second look and merge/release
Thanks!

What do you think about skipping Git's config altogether?  That is more likely to not break in the future then for similar cases.
Regarding the tests, there appear to be a lot of unrelated(?) issues.  I am seeing 11 errors on master with py34 locally.

I am seeing 11 errors on master with py34 locally.

Fixed by downgrading tox.

ill have to make a note to look into the upgraded tox issues.
Im not sure how to skip a users git configuration. Though it sounds like a good plan

@blueyed you still around? Master still builds fine for me. Are you going to be able to look into the failing tests?

Closing, have not heard anything back and parts of the codebase have had major refactoring since this PR

Re-submitted (done from scratch) in https://github.com/Bachmann1234/diff-cover/pull/43.


Update release notes to add network throttle steps

Surely we should just change the endpoints to point somewhere that doesnt exist?

You'd get a quick connection fail in that case, right? But the point of this check (I believe) is to see if a slow request occupies the UI/main thread and makes the app seem unresponsive.

https://httpstat.us/ use that?

The point of this step is to simulate a slow network connection to ensure that no ANRs/watchdogs are observed.
Attempting to reach a non-existent endpoint would test that the client fails gracefully and caches a request if the server isn't available. I can add that in as an additional step if you feel that's something we need to test manually on each release.

I would prefer it was deterministic. Thats why putting a delay on https://httpstat.us/ is preferable in my mind.

@snmaynard I've updated the instructions to use httpstat.us, if you're happy with the approach + wording I'll update the other PRs.

That seems good to me


Need help with App

Hi,
I can't figure out how to turn off the heart rate animation using the "styles" notepad. Can you help me make the image static?
Hardware/Software

iPhone: ex: 10 XS
iOS: 14.0.1
Apple Watch: ex: Series 4 40mm
watchOS: 6.2.8
Windows: Windows 10

You have to disable it in the config file
{
"animateHeartRateImage": "false"
}

I just released an iOS app that has a config file generator. You can get it from the iOS App Store. It should make it a lot easier to make config files.


Unrecognized Python objects shouldn't be pytrees

It appears that jax.tree_util treats unrecognized objects as pytrees, e.g.,
class X:
  pass

xs, tree_def = jax.tree_util.tree_flatten(X)
jax.tree_util.tree_unflatten(tree_def, xs)

The same is true for various other types, e.g., flattening/unflattening a function works just fine.
This strikes me as very error prone.

Nevermind, I was confused here...


Ignore / Capture Terminals in Parser

Usually it is desirable just to ignore certain not so important tokens such as spaces, comments, etc.  But sometimes it is useful to get those information for programs such as beautifiers.
I am not exactly sure how useful it is in general, although I do have some such uses in mind.
Parser also needs to do a better job of reporting terminals not specified in the grammar.

See 502df50dac960c96e5987f3da9c611b04a9d03de


NEW: NotificationBadge

LiveURL: https://orbit-components-notification-badge.surge.sh

@honzatmn @tomashapl Please guys, how this is going to be used?
I think it would be good idea to support aria tags to reflect notification behaviour. Minimum I would say would be to support aria-label, but more advanced solution for inspiration is here. Containing aria-live, aria-atomic and role


Update attribution in license header

Woah, dude. Please close all the duplicates and don't do that again.

My mistake. I asked @StevenAyr to do this without realizing he was editing directly from the GH interface. I'll clean this up.

Many thanks @mikesherov, and apologies to all for the flood of PRs.


Feature request: make "in" operator supporting subsets

Hello @jwadhams ,
I've got some difficulties trying to implement subset expression.
Currently it's possible to check whether a string is a part of another string
Example from site: {"in":["Spring", "Springfield"]}
I'd like to see a logic that will also work for expression {"in":[ [1, 2], [0, 1, 2, 3]]} - in this case I would expect to have "true" value in the result.
If that looks confusing, then it might be a good idea to have a new operator for this?
May I also ask you to help me to compose subset logic with existing operators?
Currently I'm using a logic like this:
{ "and": [ "in":[ 1, [0, 1, 2, 3]], "in":[ 2, [0, 1, 2, 3]] ] }
Is there a better way of writing this expression?

Could you rewrite it to use all?
{"all":[
    [1,2],
    {"in":[{"var":""}, [0,1,2,3]]}
]}

Otherwise you could add an operation:
jsonLogic.add_operation('containsAll', function(needles, haystack){
    return needles
        .map((needle) => haystack.indexOf(needle) !== -1)
        .reduce((includes, carry) => {return carry && includes;}, true);
})

jsonLogic.apply({"containsAll":[[1,2],[0,1,2,3]]}) // true

Hello @jwadhams
Thanks for your reply.
Yes I tried that way using "all", but in my case collection [0,1,2,3] was supposed to be given from state object like this:
{"all":[
    [1,2],
    {"in":[{"var":""}, {"var":"collection"}]}
]}
// (note: the example doesn't work, because context object changes in operations "some", "all" and "none")

Thanks for the provided example, that's what our team is going to use.


Implement the bootc provision plugin

This creates a new provision plugin that is built on top of the existing TestCloud (virtual) plugin. It adds new parameters to pass a Containerfile or container image. The plugin will then build a container image (if necessary) then build a bootc disk image from the container image using bootc image builder. Currently, bootc requires podman to be run as root when building a disk image. This is typically handled by running a podman machine as root.
An additional parameter "add-deps" toggles building a derived container image with the tmt test requirements.
Resolves #3013
Pull Request Checklist

[X] implement the feature
[x] write the documentation
[x] extend the test coverage
[x] adjust plugin docstring
[x] modify the json schema
[ ] mention the version
[x] include a release note

This is a work in progress. I'm opening this PR early to get feedback on the high level design. I will add tests, docs, etc. after we solidify the higher level design.
If you want to try running the code here is an example fmf plan:
provision:
  how: bootc
  containerimage: quay.io/centos-bootc/centos-bootc:stream9
  disk: 20
summary: Testing bootc plugin
execute:
  how: tmt
  script: |
    echo "ok"

@cgwalters fyi

@cgwalters fyi

LGTM, I like the reuse of existing plugins, that's very nice.
Would it also make sense to support the container plugin? IIUIC, the image produced by podman can be run both with podman run, or, converted to qcow2, as a VM. I could imagine both ways being available to use, maybe through some runtime-plugin: container|virtual switch. Is it a bad idea?
I will have more low-level comments related to the actual implementation, but I won't bother you now till you receive the high-level review. Just ping when you're ready for the boring stuff :)

I'm still trying to speedrun reading/learning all things bootc (and tmt provisioning plugins), but fwiw, looks cool to me.
@happz about the container plugin support - Fedora docs says:

for fully-fledged tests it is not recommended to run a bootable container via, for instance, podman-run. One reason among others is that the filesystem is writable when being executed as an OCI container while most of the filesystem is mounted read-only on a deployed bootc system. That means the running container behaves differently than a deployed system. Yet, if you desire to run some quick tests it is recommended to run the container in detached mode.

From what I understand, podman-bootc could be pretty cool to use, once available.

I agree, it's not a perfect 1:1 substitution, but, exactly: for quick tests or basic test development, it may give me results faster than VM. I for one work on binutils and C/C++ toolchain in general, and my area of focus is fairly simple - compile this, run objdump on that, grep for expected section names, this kind of stuff. Learning about a typo in my reproducer quickly is very valuable, and once I'm done, I can always use full VM. I do it today already: I develop tests with container, then I switch to beaker or 1minutetip to get a more real environment before committing the new test to git. So, podman-run, for my trivial component, would be very welcome, even with caveats like the one you mentioned :)

I agree, it's not a perfect 1:1 substitution, but, exactly: for quick tests or basic test development, it may give me results faster than VM. I for one work on binutils and C/C++ toolchain in general, and my area of focus is fairly simple - compile this, run objdump on that, grep for expected section names, this kind of stuff. Learning about a typo in my reproducer quickly is very valuable, and once I'm done, I can always use full VM. I do it today already: I develop tests with container, then I switch to beaker or 1minutetip to get a more real environment before committing the new test to git. So, podman-run, for my trivial component, would be very welcome, even with caveats like the one you mentioned :)

Thank you for the insight in your development process. I hope I can see it in more detail one day.

Would it also make sense to support the container plugin? IIUIC, the image produced by podman can be run both with podman run, or, converted to qcow2, as a VM. I could imagine both ways being available to use, maybe through some runtime-plugin: container|virtual switch. Is it a bad idea?

I think the existing container plugin will handle this case without any additional code. The bootc image is just another container that can be run like a typical image.

@happz thanks for the review! I believe I addressed all your suggestions.

@happz let's rebase and run the pipeline here?

We agreed to focus on getting this in 1.38, the due date for finishing is 24th October.

thanks for looking at this and planning for 1.38. Is there anything I can do to help move it along?

thanks for looking at this and planning for 1.38. Is there anything I can do to help move it along?

@ckyrouac not really, the team is overhelmed with reviews.
I am getting validation errors, I assume the jsonschema needs an update for the new provision plugin:
❯ pwd
/var/home/mvadkert/git/github.com/teemtee/tmt/tests/provision/bootc/data

❯ tmt lint
    warn: /containerfile_includes_deps:provision - {'how': 'bootc', 'add-deps': False, 'containerfile': '$TMT_BOOTC_CONTAINERFILE_RUNDIR/includes_deps.containerfile', 'containerfile-workdir': '.', 'disk': 20} is not valid under any of the given schemas
    warn: /containerfile_needs_deps:provision - {'how': 'bootc', 'add-deps': True, 'containerfile': '$TMT_BOOTC_CONTAINERFILE_RUNDIR/needs_deps.containerfile', 'containerfile-workdir': '.', 'disk': 20} is not valid under any of the given schemas
    warn: /image_includes_deps:provision - {'how': 'bootc', 'add-deps': False, 'containerimage': 'localhost/tmt-bootc-includes-deps', 'disk': 20} is not valid under any of the given schemas
    warn: /image_needs_deps:provision - {'how': 'bootc', 'add-deps': True, 'containerimage': 'localhost/tmt-bootc-needs-deps', 'disk': 20} is not valid under any of the given schemas
/containerfile_includes_deps
warn C000 key "add-deps" not recognized by schema /schemas/provision/container
warn C000 key "containerfile" not recognized by schema /schemas/provision/container
warn C000 key "containerfile-workdir" not recognized by schema /schemas/provision/container
warn C000 key "disk" not recognized by schema /schemas/provision/container
warn C000 value of "how" is not "container"
warn C000 key "add-deps" not recognized by schema /schemas/provision/mrack
warn C000 key "containerfile" not recognized by schema /schemas/provision/mrack
warn C000 key "containerfile-workdir" not recognized by schema /schemas/provision/mrack
warn C000 key "disk" not recognized by schema /schemas/provision/mrack
warn C000 value of "how" is not "beaker"
warn C000 key "add-deps" not recognized by schema /schemas/provision/virtual
warn C000 key "containerfile" not recognized by schema /schemas/provision/virtual
warn C000 key "containerfile-workdir" not recognized by schema /schemas/provision/virtual
warn C000 value of "how" is not "virtual"
warn C000 key "add-deps" not recognized by schema /schemas/provision/artemis
warn C000 key "containerfile" not recognized by schema /schemas/provision/artemis
warn C000 key "containerfile-workdir" not recognized by schema /schemas/provision/artemis
warn C000 key "disk" not recognized by schema /schemas/provision/artemis
warn C000 value of "how" is not "artemis"
warn C000 key "add-deps" not recognized by schema /schemas/provision/minute
warn C000 key "containerfile" not recognized by schema /schemas/provision/minute
warn C000 key "containerfile-workdir" not recognized by schema /schemas/provision/minute
warn C000 key "disk" not recognized by schema /schemas/provision/minute
warn C000 value of "how" is not "minute"
warn C000 key "add-deps" not recognized by schema /schemas/provision/connect
warn C000 key "containerfile" not recognized by schema /schemas/provision/connect
warn C000 key "containerfile-workdir" not recognized by schema /schemas/provision/connect
warn C000 key "disk" not recognized by schema /schemas/provision/connect
warn C000 value of "how" is not "connect"
warn C000 key "add-deps" not recognized by schema /schemas/provision/local
warn C000 key "containerfile" not recognized by schema /schemas/provision/local
warn C000 key "containerfile-workdir" not recognized by schema /schemas/provision/local
warn C000 key "disk" not recognized by schema /schemas/provision/local
warn C000 value of "how" is not "local"
warn C000 fmf node failed schema validation
warn C001 summary key is missing
pass P001 correct keys are used
pass P002 execute step defined with "how"
pass P003 execute step methods are all known
pass P004 discover step methods are all known
skip P005 no remote fmf ids defined
pass P006 phases have unique names
pass P007 execute phase 'default-0' does not require specific guest

/containerfile_needs_deps
warn C000 key "add-deps" not recognized by schema /schemas/provision/container
warn C000 key "containerfile" not recognized by schema /schemas/provision/container
warn C000 key "containerfile-workdir" not recognized by schema /schemas/provision/container
warn C000 key "disk" not recognized by schema /schemas/provision/container
warn C000 value of "how" is not "container"
warn C000 key "add-deps" not recognized by schema /schemas/provision/mrack
warn C000 key "containerfile" not recognized by schema /schemas/provision/mrack
warn C000 key "containerfile-workdir" not recognized by schema /schemas/provision/mrack
warn C000 key "disk" not recognized by schema /schemas/provision/mrack
warn C000 value of "how" is not "beaker"
warn C000 key "add-deps" not recognized by schema /schemas/provision/virtual
warn C000 key "containerfile" not recognized by schema /schemas/provision/virtual
warn C000 key "containerfile-workdir" not recognized by schema /schemas/provision/virtual
warn C000 value of "how" is not "virtual"
warn C000 key "add-deps" not recognized by schema /schemas/provision/artemis
warn C000 key "containerfile" not recognized by schema /schemas/provision/artemis
warn C000 key "containerfile-workdir" not recognized by schema /schemas/provision/artemis
warn C000 key "disk" not recognized by schema /schemas/provision/artemis
warn C000 value of "how" is not "artemis"
warn C000 key "add-deps" not recognized by schema /schemas/provision/minute
warn C000 key "containerfile" not recognized by schema /schemas/provision/minute
warn C000 key "containerfile-workdir" not recognized by schema /schemas/provision/minute
warn C000 key "disk" not recognized by schema /schemas/provision/minute
warn C000 value of "how" is not "minute"
warn C000 key "add-deps" not recognized by schema /schemas/provision/connect
warn C000 key "containerfile" not recognized by schema /schemas/provision/connect
warn C000 key "containerfile-workdir" not recognized by schema /schemas/provision/connect
warn C000 key "disk" not recognized by schema /schemas/provision/connect
warn C000 value of "how" is not "connect"
warn C000 key "add-deps" not recognized by schema /schemas/provision/local
warn C000 key "containerfile" not recognized by schema /schemas/provision/local
warn C000 key "containerfile-workdir" not recognized by schema /schemas/provision/local
warn C000 key "disk" not recognized by schema /schemas/provision/local
warn C000 value of "how" is not "local"
warn C000 fmf node failed schema validation
warn C001 summary key is missing
pass P001 correct keys are used
pass P002 execute step defined with "how"
pass P003 execute step methods are all known
pass P004 discover step methods are all known
skip P005 no remote fmf ids defined
pass P006 phases have unique names
pass P007 execute phase 'default-0' does not require specific guest

/image_includes_deps
warn C000 key "add-deps" not recognized by schema /schemas/provision/container
warn C000 key "containerimage" not recognized by schema /schemas/provision/container
warn C000 key "disk" not recognized by schema /schemas/provision/container
warn C000 value of "how" is not "container"
warn C000 key "add-deps" not recognized by schema /schemas/provision/mrack
warn C000 key "containerimage" not recognized by schema /schemas/provision/mrack
warn C000 key "disk" not recognized by schema /schemas/provision/mrack
warn C000 value of "how" is not "beaker"
warn C000 key "add-deps" not recognized by schema /schemas/provision/virtual
warn C000 key "containerimage" not recognized by schema /schemas/provision/virtual
warn C000 value of "how" is not "virtual"
warn C000 key "add-deps" not recognized by schema /schemas/provision/artemis
warn C000 key "containerimage" not recognized by schema /schemas/provision/artemis
warn C000 key "disk" not recognized by schema /schemas/provision/artemis
warn C000 value of "how" is not "artemis"
warn C000 key "add-deps" not recognized by schema /schemas/provision/minute
warn C000 key "containerimage" not recognized by schema /schemas/provision/minute
warn C000 key "disk" not recognized by schema /schemas/provision/minute
warn C000 value of "how" is not "minute"
warn C000 key "add-deps" not recognized by schema /schemas/provision/connect
warn C000 key "containerimage" not recognized by schema /schemas/provision/connect
warn C000 key "disk" not recognized by schema /schemas/provision/connect
warn C000 value of "how" is not "connect"
warn C000 key "add-deps" not recognized by schema /schemas/provision/local
warn C000 key "containerimage" not recognized by schema /schemas/provision/local
warn C000 key "disk" not recognized by schema /schemas/provision/local
warn C000 value of "how" is not "local"
warn C000 fmf node failed schema validation
warn C001 summary key is missing
pass P001 correct keys are used
pass P002 execute step defined with "how"
pass P003 execute step methods are all known
pass P004 discover step methods are all known
skip P005 no remote fmf ids defined
pass P006 phases have unique names
pass P007 execute phase 'default-0' does not require specific guest

/image_needs_deps
warn C000 key "add-deps" not recognized by schema /schemas/provision/container
warn C000 key "containerimage" not recognized by schema /schemas/provision/container
warn C000 key "disk" not recognized by schema /schemas/provision/container
warn C000 value of "how" is not "container"
warn C000 key "add-deps" not recognized by schema /schemas/provision/mrack
warn C000 key "containerimage" not recognized by schema /schemas/provision/mrack
warn C000 key "disk" not recognized by schema /schemas/provision/mrack
warn C000 value of "how" is not "beaker"
warn C000 key "add-deps" not recognized by schema /schemas/provision/virtual
warn C000 key "containerimage" not recognized by schema /schemas/provision/virtual
warn C000 value of "how" is not "virtual"
warn C000 key "add-deps" not recognized by schema /schemas/provision/artemis
warn C000 key "containerimage" not recognized by schema /schemas/provision/artemis
warn C000 key "disk" not recognized by schema /schemas/provision/artemis
warn C000 value of "how" is not "artemis"
warn C000 key "add-deps" not recognized by schema /schemas/provision/minute
warn C000 key "containerimage" not recognized by schema /schemas/provision/minute
warn C000 key "disk" not recognized by schema /schemas/provision/minute
warn C000 value of "how" is not "minute"
warn C000 key "add-deps" not recognized by schema /schemas/provision/connect
warn C000 key "containerimage" not recognized by schema /schemas/provision/connect
warn C000 key "disk" not recognized by schema /schemas/provision/connect
warn C000 value of "how" is not "connect"
warn C000 key "add-deps" not recognized by schema /schemas/provision/local
warn C000 key "containerimage" not recognized by schema /schemas/provision/local
warn C000 key "disk" not recognized by schema /schemas/provision/local
warn C000 value of "how" is not "local"
warn C000 fmf node failed schema validation
warn C001 summary key is missing
pass P001 correct keys are used
pass P002 execute step defined with "how"
pass P003 execute step methods are all known
pass P004 discover step methods are all known
skip P005 no remote fmf ids defined
pass P006 phases have unique names
pass P007 execute phase 'default-0' does not require specific guest

    warn: /containerfile_includes_deps:provision - {'how': 'bootc', 'add-deps': False, 'containerfile': '$TMT_BOOTC_CONTAINERFILE_RUNDIR/includes_deps.containerfile', 'containerfile-workdir': '.', 'disk': 20, 'name': 'default-0'} is not valid under any of the given schemas
    warn: /containerfile_needs_deps:provision - {'how': 'bootc', 'add-deps': True, 'containerfile': '$TMT_BOOTC_CONTAINERFILE_RUNDIR/needs_deps.containerfile', 'containerfile-workdir': '.', 'disk': 20, 'name': 'default-0'} is not valid under any of the given schemas
    warn: /image_includes_deps:provision - {'how': 'bootc', 'add-deps': False, 'containerimage': 'localhost/tmt-bootc-includes-deps', 'disk': 20, 'name': 'default-0'} is not valid under any of the given schemas
    warn: /image_needs_deps:provision - {'how': 'bootc', 'add-deps': True, 'containerimage': 'localhost/tmt-bootc-needs-deps', 'disk': 20, 'name': 'default-0'} is not valid under any of the given schemas
Lint checks on all
pass G001 no duplicate ids detected

/packit build

I am getting validation errors, I assume the jsonschema needs an update for the new provision plugin:
❯ pwd
/var/home/mvadkert/git/github.com/teemtee/tmt/tests/provision/bootc/data

❯ tmt lint
    warn: /containerfile_includes_deps:provision - {'how': 'bootc', 'add-deps': False, 'containerfile': '$TMT_BOOTC_CONTAINERFILE_RUNDIR/includes_deps.containerfile', 'containerfile-workdir': '.', 'disk': 20} is not valid under any of the given schemas
    warn: /containerfile_needs_deps:provision - {'how': 'bootc', 'add-deps': True, 'containerfile': '$TMT_BOOTC_CONTAINERFILE_RUNDIR/needs_deps.containerfile', 'containerfile-workdir': '.', 'disk': 20} is not valid under any of the given schemas
    warn: /image_includes_deps:provision - {'how': 'bootc', 'add-deps': False, 'containerimage': 'localhost/tmt-bootc-includes-deps', 'disk': 20} is not valid under any of the given schemas
    warn: /image_needs_deps:provision - {'how': 'bootc', 'add-deps': True, 'containerimage': 'localhost/tmt-bootc-needs-deps', 'disk': 20} is not valid under any of the given schemas
/containerfile_includes_deps
warn C000 key "add-deps" not recognized by schema /schemas/provision/container
warn C000 key "containerfile" not recognized by schema /schemas/provision/container
warn C000 key "containerfile-workdir" not recognized by schema /schemas/provision/container
warn C000 key "disk" not recognized by schema /schemas/provision/container
warn C000 value of "how" is not "container"
... snip ....

@ckyrouac FTR the respective schemas are in https://github.com/teemtee/tmt/tree/bc64a2fd569c2d1179cb63bd50dbefff429d4f14/tmt/schemas/provision, you will need to add one for this new provision plugin

Bumping to 1.39: we decided to shorten the 1.38 release cycle and ship it tomorrow to deliver two important features. 1.39 should be also shortened, taking just 2 weeks.

@ckyrouac Let us know if you would need any help and I promise I will be more timely on the reviews. Thanks for bringing this feature to tmt and sorry this took so long.

@thrix no worries. I pushed all the requested changes in a few commits to make it easier to review. I can squash after review if you want.

/packit build

force pushed updates addressing all the suggestions.
I had broken out the podman-machine cpu/mem parameters into environment variables with the idea that the podman-machine would be spun up once for multiple tests. With the current code, a new machine is created and destroyed for each test run. That's mostly because I'm not sure where/how to hook into the higher level run code. Although, the more I think about it, I guess allowing each test to specify the podman-machine cpu/mem requirements makes sense because some tests might require significantly more resources than other tests.

please, install and enable pre-commit in your repo

hmm, I have it installed but it didn't run on one of those commits for some reason.

/packit build

hmm, looking into the test failures

not sure why the CI tests were failing. The tests are passing locally, in CI the setup was failing to create the /var/tmp/tmt/test-XXXX directory. I can't find the previous run results to get the exact error after I pushed the latest updates.

One of the old jobs is here. There seems to be a problem with tmt init at the beginning:
:: [ 09:08:32 ] :: [  BEGIN   ] :: Running 'tmt init'
Path '/var/ARTIFACTS/work-bootcdy90p5cu/plans/provision/bootc/discover/default-0/tests/tests/provision/bootc' already has a parent fmf tree root '/var/ARTIFACTS/work-bootcdy90p5cu/plans/provision/bootc/discover/default-0/tests/.fmf'.
Do you really want to initialize a nested tree? [y/N]: Aborted!
:: [ 09:08:33 ] :: [   FAIL   ] :: Command 'tmt init' (Expected 0, got 1)

Using tmt init --force should help.

ah, thanks for the link. The latest commit should fix it. Not sure if you need to trigger another test run or not.

/packit build

/packit build

/packit build

/packit build

The tests are failing with Failed to connect socket to '/var/run/libvirt/virtqemud-sock': No such file or directory. Any ideas why?

The tests are failing with Failed to connect socket to '/var/run/libvirt/virtqemud-sock': No such file or directory. Any ideas why?

I ran into this before locally, I solved it with systemctl enable virtqemud.socket

The tests are failing with Failed to connect socket to '/var/run/libvirt/virtqemud-sock': No such file or directory. Any ideas why?

Tests depend on additional setup, shouldn't we add a dedicated plan & let it run in the provision check? IIUIC, that's what we did with provision-virtual tests, they are now grouped under /plans/provision/virtual which tasks care of the necessary setup, starting libvirt is exactly one of the steps in plans/provision/virtual.fmf, and since bootc provisioning plugin depends on an extra setup as well, we should isolate them in the same manner.
@psss does it make sense? It does look like another provision-foo plan is needed, and I think we can add it to the same Github check as virtual tests.

@happz added a prepare step to the bootc plan. Could you trigger another test run?

/packit build

@psss does it make sense? It does look like another provision-foo plan is needed, and I think we can add it to the same Github check as virtual tests.

Yes, this definitely makes sense. Let's have this handled in a consistent way.

If I understand this right, I believe this was already in place. The prepare step just wasn’t in place yet but is now.
Now the bootc tests pass but there is an avc failure that I don’t understand. Any ideas?

If I understand this right, I believe this was already in place. The prepare step just wasn’t in place yet but is now.
Now the bootc tests pass but there is an avc failure that I don’t understand. Any ideas?

A rebase should help, the problem has been addressed in https://github.com/teemtee/tmt/pull/3355

/packit build

If I understand this right, I believe this was already in place. The prepare step just wasn’t in place yet but is now.
Now the bootc tests pass but there is an avc failure that I don’t understand. Any ideas?

I'm guessing it's the usage of /var, nosuid transition:
https://danwalsh.livejournal.com/78312.html
I can see container-selinux package being installed in the log btw. Maybe a bug there on in podman-machine package? Not sure how to solve this. @psss @happz

If I understand this right, I believe this was already in place. The prepare step just wasn’t in place yet but is now.
Now the bootc tests pass but there is an avc failure that I don’t understand. Any ideas?

I'm guessing it's the usage of /var, nosuid transition: https://danwalsh.livejournal.com/78312.html
I can see container-selinux package being installed in the log btw. Maybe a bug there on in podman-machine package? Not sure how to solve this. @psss @happz

It has been reported for bootc image builder, see https://github.com/osbuild/bootc-image-builder/issues/645. It does look like something bootc either should not do, or ask selinux-policy maintainers to allow.

Hmm that probably relates to our initialization of containers/storage at bootc install time. But I am confused as to why we may only be seeing this here. It may relate somehow to the host policy? We do have some coverage for this in other CI tests… Long story short if this theory is right then we need to suppress the domain transition or maybe just switch to skopeo which we probably want to do anyways.

Thanks,
@cgwalters @ckyrouac Would you prefer merging it "as is", perhaps like a tech preview or addressing the selinux issue first, most likely sliding to the next release cycle?

I will be afk on paternity leave soon (most likely in a week), so I won't be able to work on this much for a few months. So, unless someone else can pick up the work, I think merging as-is makes the most sense.

I will be afk on paternity leave soon (most likely in a week)

Congratulations in advance sir!

So, unless someone else can pick up the work, I think merging as-is makes the most sense.

Ok, then I suggest to mark the avc failure as expected for now and include this in 1.39 as a tech preview. I've added a short release not in 44b0cd38. Does it look ok?

/packit build

@psss I addressed most of your suggestions in recent pushes. I probably won’t have time to refactor the tests per your suggestions though.
@happz I think I removed your commit via a force push, sorry. I’m done pushing now :-)

/packit build

/packit build

I've added a bunch of changes in f781e34b, mainly to fix & simplify tests:

Make sure that all test cases are actually executed.
Run tests directly in the data directory.
Simplify plans using inheritance.
Plus some minor adjustments.

Last remaining problem is the avc check. I guess we should just disable it if we cannot xfail it?

/packit build

/packit build

/packit build

/packit build

/packit build


introduce qualified parse events and link to generation/download events

Currently, download/generation events are explicitly linked to crawl events by the "usedBy" relationship ship .
We'd like introduce a uuid to reference a parse event (e.g., RSS reader) to the downloading of the content referenced resulting from the parsed RSS .

Pseudo rdf/nquads
<some parse event uuid> <wasInformedBy> <some RSS download event uuid> .
<some parse event uuid> <used> <some content hash> .
....
<some content hash> <hasMember> <some url> .
<some url> <hasVersion> <hash://sha256/abc...> .
<some download event uuid> <generated> <hash://sha256/abc...> .
<some download event uuid> <wasInformedBy> <some parse event uuid>

We need a way for parsers (aka statement listeners) to register their parse events so that the archiver (aka downloader/dereferencer) can related specific download events to the events that triggered them (or were informed by them).
<_:blank> <http://www.w3.org/ns/prov#qualifiedGeneration> <285cef08-fcfc-4acd-bf51-c1f73d283f72> .
<285cef08-fcfc-4acd-bf51-c1f73d283f72> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <http://www.w3.org/ns/prov#Generation> .
<285cef08-fcfc-4acd-bf51-c1f73d283f72> <http://www.w3.org/ns/prov#wasInformedBy> <parse event uuid> .
<285cef08-fcfc-4acd-bf51-c1f73d283f72> <http://www.w3.org/ns/prov#used> <https://example.org/data> .
<https://example.org/data> <http://purl.org/pav/hasVersion> <_:blank> .

solution - let the parse submit a batch of statement so that the archiver can handle them send this along to next parser. The next parse now has the information about the event that generated the content so it can related it's parsing event to that.

Waiting for #41 before introducing parse events

@jhpoelen I'm wondering what your thoughts are on how verbose activity provenance needs to be. At a minimum, only <activity> <type> <Activity> needs to be said, and when a source activity exists, we should include <newActivity> <wasInformedBy> <sourceActivity>. Should we also include startedAtTime and endedAtTime statements? I can understand their use for debugging and things, but they don't seem useful all the time, especially for activities that operate on fixed data (referenced by hash). Also, do you know of any other types of statements we should emit?
Should registry readers log an activity even when parsing produces no results? Again, useful for debugging, maybe, but not much value otherwise.

To clarify, logging the start/end times for things like download events are great. Just not sure if we always need to include those times for all activities.

@mielliott good point about the logging verbosity. I'd suggest to start with the most minimal solution. We can always move verbose logging later.

Feature added in dcfa07c031595af428a43019614602eb66d7cf2c


Please add watch mode in filesystem

Please add watch mode in filesystem as soon as the file system change or update in contents of file the user can immediately know.

Hey! This is tracked in #988. I'm going to close this issue. Feel free to comment there if you have any specific requirements :+1:


Make openssl-sys always vendored and add windows support

Closes #79.

Very nice. a minor nit. also can you see if you can update changelog as well?

Done.

bors r+

approved


[Feature Request] ontology source references

v0.4.0-osx.x64
Is your feature request related to a problem? Please describe.
Hope not having overseen this:
I am missing an option to pass ontology source references to isa.investiagtion.
Describe the solution you'd like
Add an option to pass the respective arguments.
Describe alternatives you've considered
Adding these manually in the file which is only a workaround.
It would be good if the arcCommander could support in filling all fields via command line.

We're planning on working on this in an automated way. E.g. getting the ontology source info when collecting terms using SWATE and ARCitect.
Don't expect anything user-facing soon though.

How about that: If new source references are added, e.g.
arc study factor register --study-identifier my-study --typetermaccessionnumber something --typertermsourceref somethingelse

the ontology source reference in the isa.investigation file ist updated automatically.


Considering to download and unzip when VC-LTL and YY-Thunks not found

Currently, in order to use thunk-rs, one needs to download VC-LTL and YY-Thunks and add them to system environment. This can be improved by integrating downloading process from GitHub.
There are two basic thoughts:

One is always downloading the latest release. This may cause some unexcepted situation.
Two is downloading a specific release. This will cause the thunk-rs version increasing but benefit from testing by me.

I decide to achieve it the second way. As the rust programming language now officially support Windows 10 above in Tier 1, I suppose the users are using Windows 10 above. So, the downloading process will be achieved by calling curl command, and the compressed binary will be uncompressed by calling tar command. I will check if these two work later.
The next version will be 0.x.y: x is to fix thunk-rs, and y is to catch up on VC-LTL and YY-Thunks.

Currently, I find if support downloading, thunk-rs should be achieved as a dependency not a build dependency. Because in a dependency the program will have to download every time, which is not acceptable.  What's more, the tar command does not support lzma, so 7z command line tool needs to be set in path.

thunk-rs v0.3.0 as build dependencies should work now.


Introduces zooming towards/away from mouse

Thanks for the PR!
Sorry about the lack of feedback, I will have a look before the weekend.

Is there anything that I need to adjust before this can be merged?

Sorry about the lack of feedback, I will have a look before the weekend.

6 months later ... "Nice job, Julian" :/
Sorry again. So I did test your PR, and it does improve the behavior. But I still had one issue with it. It "feels" wrong if you start zooming while the canvas is zoomed out enough so that the lightgrey borders are displayed:

This is not directly related to your implementation here. Since the canvas is always centered when it is zoomed out, the relative position of my mouse cursor in the canvas will change between the moment I start zooming and the moment we can start offsetting the canvas.
That being said this is the behaviour of other image editing software, so maybe it's OK to leave it as is.

Alrighty, I'll get to it. Thank you!

Let me know if there's a better way in terms of style to put this together; I just kind of tweaked everywhere in the file to try and make the feature work.

The code change looks good! Merging. Thanks again for the PR and sorry about the review delay :)


fix: add helpPresenter to viewContext.ui

Coverage remained the same at 93.658% when pulling 7b28262d0ea833be430faff15d425565f7f10c32 on view-context into 3cc7626991ec8bff9164a41e2f4d35a76e0920b4 on master.


Prevent multiple send email clicks + fix content event logging

Error occurs when "Send" email is clicked multiple times. Fixed issue by show page progress modal after form submission.
Event logging error occurs when editing an action and the content exceeds 65536 characters. This happens frequently when there are text conditions added to the action out.

The latest version of OnTask has changed significantly how the emails are sent. The task is now simply queued for execution and happens asynchronously to the web request, thus reducing the time the user waits for a response. Please, reassess if this is needed in the presence of  this new functionality.


path should be string, bytes, os.PathLike or integer, not list

Hi, when trying to inference I get this message:
Attempting to load assets/audios\speaker0.wav....
2023-11-08 08:58:20 | WARNING | lib.infer.modules.vc.modules | Traceback (most recent call last):
  File "C:\Users\Admin\Downloads\Applio-RVC-Fork\lib\infer\modules\vc\modules.py", line 375, in vc_single
    audio_opt = self.pipeline.pipeline(
  File "C:\Users\Admin\Downloads\Applio-RVC-Fork\lib\infer\modules\vc\pipeline.py", line 637, in pipeline
    and os.path.exists(file_index)
  File "genericpath.py", line 19, in exists
TypeError: stat: path should be string, bytes, os.PathLike or integer, not list

Traceback (most recent call last):
  File "C:\Users\Admin\Downloads\Applio-RVC-Fork\runtime\lib\site-packages\gradio\routes.py", line 437, in run_predict
    output = await app.get_blocks().process_api(
  File "C:\Users\Admin\Downloads\Applio-RVC-Fork\runtime\lib\site-packages\gradio\blocks.py", line 1349, in process_api
    data = self.postprocess_data(fn_index, result["prediction"], state)
  File "C:\Users\Admin\Downloads\Applio-RVC-Fork\runtime\lib\site-packages\gradio\blocks.py", line 1283, in postprocess_data
    prediction_value = block.postprocess(prediction_value)
  File "C:\Users\Admin\Downloads\Applio-RVC-Fork\runtime\lib\site-packages\gradio\components.py", line 2586, in postprocess
    file_path = self.audio_to_temp_file(
  File "C:\Users\Admin\Downloads\Applio-RVC-Fork\runtime\lib\site-packages\gradio\components.py", line 360, in audio_to_temp_file
    temp_dir = Path(dir) / self.hash_bytes(data.tobytes())
AttributeError: 'NoneType' object has no attribute 'tobytes'

Restarting as suggested in #83 did not help.
It is "Attempting to load assets/audios\speaker0.wav....", shouldn't it be assets\audios\speaker0.wav?

update your applio , I think I have already corrected it. https://github.com/IAHispano/Applio-RVC-Fork/commit/258f114c49fe72932603ff6cc9ef46e0a5e296f7


JS code being revised

Does the JS processing in the build routine sometimes revise JS code? I have the following in a custom JS file:
almComplete = function(alm){ 	console.log("ALM load is complete"); };
and it ends up in app.js as:
almComplete = function almComplete(alm) { 	console.log("ALM load is complete"); };

Yes, FP is using babel to transpile into old school JS.


Exchange Template Incorrectly references SNAT Pool

Environment

FAST RPM Version: 1.17.0
BIG-IP Version: 15.1.5

Summary
Exchange template produces invalid declaration when selecting existing SNAT pool
Steps To Reproduce
List the steps to reproduce the behavior:

SNAT - checked
SNAT Automap - unchecked
FAST-Generated SNAT Pool - Unchecked
BIG-IP SNAT Pool - select existing pool defined by AS3 /Common/Shared/default_snat

Note, the BIG-IP SNAT Pool is a dropdown selection and not free-form text.

Expected Behavior
Template should produce a valid declaration
Actual Behavior
the following text is visible in Debug view:
"snat": {
    "bigip": {
        "bigip": "/Common/Shared/default_snat"
      }
},

nested bigip keys are invalid

Thanks for reporting this issue. We are now tracking this internally with ID MYSTIQUE-649.


Image Id is not set to zero after avatar is deleted.

Describe the Bug
After resetting the avatar should be in the table image_id set to 0.
// BookStack\Http\Controllers\UserController
if ($request->has('profile_image_reset')) {
    $this->imageRepo->destroyImage($user->avatar);
    $user->image_id = 0; // added
    $user->save(); // added
}

Steps to Reproduce
Delete the avatar and check the users table.
Expected Behaviour
Zero in column image_id
Screenshots or Additional Context
No response
Browser Details
No response
Exact BookStack Version
22.11.1
PHP Version
No response
Hosting Environment
does not matter

Thanks for reporting @ondrej-pazourek,
this has been addressed in 03ad288aaa55a0bd0aa143711aa07d0f1801d604, and will be part of the next feature release.


Ukab ana tagging

Hi Aldo,
I have my hands full with an event for 100-150 people on Sept. 14, so I will look at this the week after that. Sorry for the delay and thanks so much for your awesome work!
Allison
Allison Margaret Bigelow
Department of Spanish, Italian, and Portuguese
University of Virginia, en la tierra del pueblo Monacanhttps://native-land.ca/maps/territories/monacan/
http://spanitalport.as.virginia.edu/people/profile/amb8fk
Schedule a meeting/Programar una @.***/bookings/>
I often reply to email at strange times because there are no rules with babies and toddlers. I respect your time, and your sanity, and I do not expect a response during your non-working hours.

From: Aldo Ismael Barriente @.>
Sent: Monday, September 4, 2023 11:15 PM
To: Multepal/popolwuj-colop-poetica-kiche @.>
Cc: Bigelow, Allison Margaret (amb8fk) @.>; Review requested @.>
Subject: Re: [Multepal/popolwuj-colop-poetica-kiche] Ukab ana tagging (PR #34)
@aldobarrientehttps://github.com/aldobarriente requested your review on: #34https://github.com/Multepal/popolwuj-colop-poetica-kiche/pull/34 Ukab ana tagging.
—
Reply to this email directly, view it on GitHubhttps://github.com/Multepal/popolwuj-colop-poetica-kiche/pull/34#event-10278381607, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGCPQH3VTVUYFNL4UK3P6WTXY2KNBANCNFSM6AAAAAA4LDO234.
You are receiving this because your review was requested.Message ID: @.***>


redirect_after_save fix

Updating excluded input items on the update and store functions so the redirect_after_save button doesn't cause issues.

Hi @jmancusi ,
Thanks for the PR! (1) Does this issue happen to you in a project you updated from Backpack\CRUD 3.1.x to 3.2.x?
I'm wondering because I've searched the current CRUD project for redirect_after_save, and I can't find it anywhere - I believe it has been completely renamed into save_actions in 3.2. (2) Is it possible this happens in an EntityCrudController where you overwrote the store() or update() methods?
Thanks, cheers!

I found the issue. I had upgraded to 3.2.x but the published views were still from 3.1 which contained the redirect_after_save input.
Thank you for your quick response!


Remove the unique index and validate uniqueness on model

Unique index didn't account for larger values of name+description+code. Changed it up to do the validation on the model instead

fixes #15


perf_indicator and best_perf update problem

Hi！
I doubt the train.py:
line 258:
perf_indicator = epoch
but in the line 251:
for epoch in range(begin_epoch, cfg.TRAIN.END_EPOCH)
Do you mean that after training, no test is performed to select the best model and the latest model defaults as the best model?

Yes, we just use the latest model as the best model.


[Update Request]: JetBrains.PyCharm.Professional update to 2023.1.4

What type of update are you requesting?
A new version of an existing package
Current Package Identifier
JetBrains.PyCharm.Professional
Package Version
2023.1.4
Please describe the changes you would like to see
New version available (2023.1.4):
Download URL: https://www.jetbrains.com/pycharm/download/?section=windows
Direct Download URL: https://download.jetbrains.com/python/pycharm-professional-2023.1.4.exe
SHA-256 URL: https://download.jetbrains.com/python/pycharm-professional-2023.1.4.exe.sha256
SHA-256: 354540d3e6aeae459319fa4f9db362dfe9c0049f1a0002a47c3cf5e5a8a0cb00 *pycharm-professional-2023.1.4.exe

@egerlach

#112152


ZFS MMP support

This change is

This is @tanabarr code that I pushed.
As such I can't review it, but will leave an old-school 👍  here.


feat(recommend): Ensures Security Filtering of Recommendations

Please Review:
@seenusuvarna
@skhtet
@J-Fid
@lsemesky
Added Securty Filtering for Recommendations

:+1:


Network Trace - Create new widget no save cancel icons

@MikeMillerGIS
When the widget is create, there are no save or cancel buttons, they appear only when the user begins to type in the Task URL text box. By default all other widgets in WAB have these right when the widget in created.

@clareprice @MikeMillerGIS We have resolved this issue and included the fix in last release.

@CTLocalGovTeam @MikeMillerGIS Verified this issue. Closing


db.push takes forever without internet and doesn't throw an error

Operating System version: Raspbian GNU/Linux 10 (buster)
Firebase SDK version:  4.3.0
Library version:
Firebase Product: database

I'm writing an app that writes data to firebase whenever internet is available. Otherwise it writes to a file for later upload. But when I cut internet for test purposes, the push() function never finishes.
[...]
with open('readings.csv', 'w', newline='') as csv_file:
                csv_writer = csv.DictWriter(csv_file, fieldnames=fieldnames, delimiter=',')
                try:
                    print("read file")
                    for row in table:
                        print("push row")
                        ref.push({
                            'time': row['timestamp'],
                            'humidity': float(row['DHT_humidity']),
                            'temp': float(row['DHT_temperature'])
                        })
                        print("pushed row")
                except FirebaseError as err:
                    print("error")
                    for row in table:
                        csv_writer.writerow(row)
                except Exception:
                    print("error")
                finally:
                    print("the end")
[...]

This means that "pushed row" never appears in the terminal without internet, yet with internet it does. There's also no exception thrown.

Set a timeout by passing the httpTimeout option when initializing the app. The default is 2 minutes.


Rewrite of social sharing

Hi there,
I had a problem with sharing on twitter (wrong/old url).
Sadly I saw no possibility to fix this with a plugin.
While coding I noticed a few other things

tweet-limit in PHP was 140 (in PHP), now 280 everywhere
enable/disable individual services (With fallback)
instead only url, also text is posted to facebook (thats why I renamed "tweet_text" to "share_text"
rewrote js: New url is only generated/written on click, not on every text-change (template in data-attribute). Url in href as non-js-fallback.

With the new js it is also more easy for plugin-devs to add other services. Just add a link with the href, the template and add the onclick.
Minimal example
<a href="https://example.com/?t=<?php echo $text; ?>"
data-shareurl="https://example.com/?t=#share#"
onclick="share(this);return false;">TEST

Hello there, thanks for proposing that enhancement!
Looks good to me, except for the new global var added to user config : if anything, we're more prone to remove options that add ones. Those global vars are bad practice actually (difficult regarding to unit tests for instance)
It would be better to had filters and actions where needed to custom behavior (for the few who need it) can be set via plugin, instead of adding vars for everyone. For instance here, simply have the array of sharing services in an array hooked to a filter

Hi,
I later saw you pushed the PHP minimum-requirement to 5.6.
As of 5.6 supports arrays as constants. Maybe that would be a simple solution for defining new config-options?

Hi,
now I understand whar you mean.
I will remove the 2 default sharings (twitter, facebook) and build plugins for every single service. So every user can activate that sharings he want to use as a plugin. (Or none)

Example plugins (FB, Twitter): https://github.com/muellerlukas/yourls-socialshare

I think you went further than I thought, sorry if I wasn't clear enough. I think out of the box things should be just as now : twitter and facebook sharing enabled. This will work for 99% of people. Plus, it's best practice not to hide things that were there for years, that will lead to dozens of issues and mails "why is the twitter thingy gone??"
But then there are some people who will want to add a network, and a few folks who will want to hide one or two. For those, having a plugin to add a sharing option (eg Tumblr, by mail, etc...) or hide one will be the best.
So the update to current sharing feature should enhance/fix things but not break what already works for people (ie people who already have a plugin, or people who just want things as default)

Ah, sorry. My fault. I misunderstood this.
Made some commits that includes fb/twitter again, removes the social-config and renames the field back to "tweet_body".
Other changes like the 280-limit and the new js usable for plugins remains.
I also added in the repo linked above 2 plugins to remove fb, twitter and some for adding new services

Back on this, sorry for the delay.
Doesn't work for me: when I click on a Share icon, I just get empty links for Twitter and FB, eg https://twitter.com/intent/tweet?text= with no parameter.
This said, the PHP needs indeed a couple tweaks.


Add hint to resolve certificate error

Setting sslVerify = false could resolve the invalid certificate problem (for Linux users)
Example (Fetch All):

Added 2 actions:

Disabling ssl verification for this repository only
Disabling ssl verification global for al git repositories

Action 'for all repositories' shows:

looks fine

Please create a new issue for this


Bug Report: Compile Issue

C:/HaxeToolkit/haxe/lib/polymod/git/polymod/format/XMLMerge.hx:189: characters 10-23 : Warning : This typedef is deprecated in favor of haxe.xml.Access
C:/HaxeToolkit/haxe/lib/polymod/git/polymod/format/XMLMerge.hx:189: characters 30-43 : Warning : This typedef is deprecated in favor of haxe.xml.Access
source/LuaClass.hx:35: characters 46-58 : Type not found : StatePointer
source/Replay.hx:55: lines 55-145 : Defined in this class
source/LuaClass.hx:1669: characters 42-54 : Type not found : StatePointer
source/Replay.hx:55: lines 55-145 : Defined in this class
source/LuaClass.hx:1469: characters 42-54 : Type not found : StatePointer
source/Replay.hx:55: lines 55-145 : Defined in this class
source/LuaClass.hx:1144: characters 42-54 : Type not found : StatePointer
source/Replay.hx:55: lines 55-145 : Defined in this class
source/LuaClass.hx:855: characters 41-53 : Type not found : StatePointer
source/Replay.hx:55: lines 55-145 : Defined in this class
source/LuaClass.hx:635: characters 40-52 : Type not found : StatePointer
source/Replay.hx:55: lines 55-145 : Defined in this class
source/LuaClass.hx:370: characters 42-54 : Type not found : StatePointer
please help

building.md

building.md

I've just done that
I'm still having the issue
Should i try reinstall Haxe?

building.md

I've just done that
I'm still having the issue
Should i try reinstall Haxe?

ok reinstalling haxe fixed the issue

building.md

I've just done that
I'm still having the issue
Should i try reinstall Haxe?

ok reinstalling haxe fixed the issue
thank you dude

building.md

I've just done that
I'm still having the issue
Should i try reinstall Haxe?

ok reinstalling haxe fixed the issue

thank you so much dude you are awesome


Select default 1D model interpolation setting

Based on config file settings, the current 1D background model is returned to users as layers, without interpolating values between layers. LA Basin model is returned using interpolation between layers.
First, Show evidence of these default values.
Then, ask the science group what the default settings should be for UCVMC.

./plot_elevation_profile.py -s 32.7567,-115.576 -b 0 -e -40000 -d vs,vp,density -v -250 -c 1d -o 1d.png
./plot_elevation_cross_section.py -b 32.7567,-115.852 -u 32.7567,-115.3 -h 1000 -v -100 -d vs  -c 1d -a d -s 100 -e -40000 -o 1d_vs.png

./plot_elevation_profile.py -s 32.7567,-115.576 -b 0 -e -40000 -d vs,vp,density -v -250 -c bbp1d -o ppb1d.png

./plot_elevation_cross_section.py -b 32.7567,-115.852 -u 32.7567,-115.3 -h 1000 -v -100 -d vs  -c bbp1d -a d -s 100 -e -40000 -o bbp1d_vs.png


Add links to tutorials

Describe the bug
Tutorial links are not set
To Reproduce
Go to https://nft.kodadot.xyz/tutorials
Expected behavior
Tutorials link should redirect to proper pages

@yangwao please provide proper links and I'll update them:

Create polkadot JS account
Get KSM
Minting

https://virtugrana.substack.com/p/kodadotoverview
https://stakenode.medium.com/dont-panic-and-mint-your-nft-s-on-kodadot-kusama-polkadot-first-nft-explorer-4273f789e585
https://nft.kodadot.xyz/rmrk/collection/10D77F8B699437BB50-KODA
Portuguese:
Getting KSM
https://virtugranapt.substack.com/p/comprando-ksm-com-fiat

https://nft.kodadot.xyz/tutorials
Spanish:

Create a Polkadot JS Account | Crear una cartera Polkadot JS : https://www.youtube.com/watch?v=iG8iQrONnYo&t=21s
Get KSM | Obtener Kusama: https://www.youtube.com/watch?v=cYaZWDzU1Yc
Minting: Crear un NFT: https://www.youtube.com/watch?v=pPsbQyJRGVQ&t=1s

@yangwao @vikiival let me fix the about issues.

Now I am working to fix this current issue.

@archnomics let's take care of this one, I guess you are able to handle it! :)
Probably sort out content accordingly

Can we live-link GH to Gitbook? That needs authentication on the repository tho.

why is that needed? or what will be benefits, I may not understand it clearly. To be a repository on GH so anyone can contribute?

Main Docs: https://kodadot.gitbook.io/knowledgebase/

Now let's link that knowledge base.
How user can find them apart from this issue?

This is already done by this https://kodadot.xyz/tutorials
But I guess we should revisit and add more tutorials there

@yangwao if you liked what i made, i'm open to making more tutorials ^^

I guess, hence we have https://docs.kodadot.xyz I would probably remove this page?
It's not even linked in landing anyway
📟  @cryptodamsky


Navigation Largest Contentful Paint

Ok it is a terrible name, but I would like to experiment on a way to use the FCP and LCP fundamentals to determine the quality of rendering Hero Elements when navigate from one view to another.

Implemented as Navigation Total Blocking Time instead.


View rect/scissor and framebuffer validation

This PR adds two related changes:

The view rect and scissor (if set) are cropped to the framebuffer size. If the view rect ends up entirely outside the framebuffer bounds, an assert fires.

More debug validation checks during framebuffer creation:

attachment mip is valid
attachment layer range is valid
attachment layer count matches across all attachments
attachment size matches across all attachments

If the view rect ends up entirely outside the framebuffer bounds, an assert fires.

I'm not quite sure about this part, but don't have better idea.
The main issue is that will happen deferred, at which point it would be better to not do anything, and let user figure out that setup is wrong. On other hand it might be better to warn because this case is not useful at all (it's bug anyhow).


Add comment for NTP and DNS in vsphere/opsman-upgrade

It's not clear what format the NTP and DNS servers
are specified. This comment attempts to clarify that.

Updated with examples instead of text


🚀✨ Support nightly-builds

Problem

when running a nightly pipeline, just sequencing all the steps. The pipeline does not continue if a stage is skipped due to default behavior.
Some lifecycle ignore tags where removed and are forcing redeploys on each run

Solution

Adding a nightly.yml to the boilerplate + description
Adding conditions on each first stage of the pipelines
re-adding the ignore tags
Added the parameter to force a template to get the latest version from a branch instead of the sha it started on. (when ever a pipeline starts it will execute all checkouts based on the SHA it started on. When running everything in 1 pipeline for the nightly you need the sap-parameters.yml in the 05 when it was added in the 03. So you need to force a latest pull)

Tests
Run the nightly
Notes

Going away present 🎁


Unexpected behavior when removing a duplicated song in play queue

Should use ID of song.

Closed by #38


Danger-swift in iOS projects

Hi @orta! Thanks for great contribution!!👏
Is there some way for to use danger-swift in ios projects same only in simple example? I make some tests but I could not make it work. Can you give me some hint or idea of how I can get started?

This is now usable, you  can find instructions inside the project README 👍


python312Packages.aiocoap: 0.4.10 -> 0.4.11

Diff: https://github.com/chrysn/aiocoap/compare/refs/tags/0.4.10...0.4.11
Changelog: https://github.com/chrysn/aiocoap/blob/0.4.11/NEWS

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 351651

x86_64-linux

:fast_forward: 4 packages marked as broken and skipped:

python311Packages.pytradfri
python311Packages.pytradfri.dist
python312Packages.pytradfri
python312Packages.pytradfri.dist

:white_check_mark: 12 packages built:

expliot
expliot.dist
home-assistant-component-tests.homekit_controller
home-assistant-component-tests.tradfri
python311Packages.aiocoap
python311Packages.aiocoap.dist
python311Packages.aiohomekit
python311Packages.aiohomekit.dist
python312Packages.aiocoap
python312Packages.aiocoap.dist
python312Packages.aiohomekit
python312Packages.aiohomekit.dist


feat: Tidy 5e Sheet rewrite compatibility

Hello, I am working on the Tidy 5e Sheet rewrite, and I recently released an API for adding tabs to the new sheets. I was wondering if we could collaborate on adding compatibility for the new sheets to this module.
The main reason things are likely not to be working is that my sheets have a different approach to tabs, in that I am offering the user tab selection. So, for these sheets, a module registers a tab, and the user / GM can choose which tabs to include or exclude on actor sheets. This is in addition to the sheet class being different from the original Tidy and is subject to change when the sheets leave alpha.
The API for registering tabs begins here: https://kgar.github.io/foundry-vtt-tidy-5e-sheets/classes/Tidy5eSheetsApi.html#registerCharacterTab
Would you be open to some discussion on how to get your and my module working together?

My apologies for not reacting to this sooner, but with the help of your documentation I was able to get it working (as far as I can tell). Please check out the branch feature/EDT-90-tidy5e-rewrite and let me know if you can break anything.

Ethck, this is truly awesome. Thank you!
I will test this tonight (in my CST time zone).
I really appreciate your understanding. These sheets are a different beast, but I am hoping it will be worth the trouble to do this intentional integrating.

I was able to test early. I have one recommendation on the tab registration code after testing.
I also have some CSS to release on my side where I was missing compatibility styles. That will go out tomorrow evening.

After thinking more about the default sheet listeners topic, I'm going to default activating default sheet listeners to false on my side and require opt-in for those who need it. With that, I think your branch looks good to go.

Let me know if there's any other info I can provide. Last I looked, it looked good to go.

I merged and released this today as version 0.7.4.


Device tracker RT-N56U not working

Helo, I just tried the ASUSWRT device tracker, but I'm getting this error:
INFO:homeassistant.loader:Loaded device_tracker.asuswrt from homeassistant.components.device_tracker.asuswrt
ERROR:homeassistant.components.device_tracker:Error setting up platform asuswrt
Traceback (most recent call last):
  File "/usr/local/lib/python3.4/dist-packages/homeassistant/components/device_tracker/__init__.py", line 124, in setup_platform
    scanner = platform.get_scanner(hass, {DOMAIN: p_config})
  File "/usr/local/lib/python3.4/dist-packages/homeassistant/components/device_tracker/asuswrt.py", line 48, in get_scanner
    scanner = AsusWrtDeviceScanner(config[DOMAIN])
  File "/usr/local/lib/python3.4/dist-packages/homeassistant/components/device_tracker/asuswrt.py", line 69, in __init__
    data = self.get_asuswrt_data()
  File "/usr/local/lib/python3.4/dist-packages/homeassistant/components/device_tracker/asuswrt.py", line 118, in get_asuswrt_data
    telnet.write((self.password + '\n').encode('ascii'))
TypeError: unsupported operand type(s) for +: 'int' and 'str'

I enable the telnet access, and to teste ir I ran this commands:
ip neigh

That returned:
<IP_ADDRESS> dev br0 lladdr <redacted> REACHABLE
<IP_ADDRESS> dev br0 lladdr<redacted> REACHABLE
<IP_ADDRESS> dev br0  FAILED
<IP_ADDRESS> dev br0 lladdr <redacted> REACHABLE
<IP_ADDRESS> dev br0 lladdr <redacted> REACHABLE
<IP_ADDRESS> dev br0  INCOMPLETE
<IP_ADDRESS> dev br0 lladdr <redacted> REACHABLE
<IP_ADDRESS> dev br0 lladdr <redacted> REACHABLE

And:
cat /var/lib/misc/dnsmasq.leases

That returned:
14400 <redacted> <IP_ADDRESS> * 01:08:00:28:5a:42:2f
86335 <redacted> <IP_ADDRESS> android-b47b2ff030f3e0e8 01:64:b3:10:67:7c:96
83971 <redacted> <IP_ADDRESS> * 01:74:c2:46:7b:9c:83
84753 <redacted> <IP_ADDRESS> IRAMAR 01:1c:65:9d:da:2b:85
78064 <redacted> <IP_ADDRESS> iPhonedeIramar 01:84:85:06:3c:6f:1b
82128 <redacted> <IP_ADDRESS> Microsoft-PC 01:c0:18:85:25:d1:aa
83089 <redacted> <IP_ADDRESS> carmolim-6 01:f0:24:75:a0:98:06
83212 <redacted> <IP_ADDRESS> Augustos-Mini 01:a8:86:dd:aa:90:d7
59880 <redacted> <IP_ADDRESS> raspberrypi *

I think the problem isn't in the router...
Any clues?

I just figure it out... My password was only numeric, I changed to another one using just letters and it worked.
Some could fix it?

Try modifying this line to this.
telnet.write((str(self.password) + '\n').encode('ascii'))

Adding quotes around your password in your configuration.yaml will also do
the trick.
On Tue, Jan 12, 2016 at 6:04 PM, @bradarndt<EMAIL_ADDRESS>wrote:

Try modifying this line to this.
telnet.write((str(self.password) + '\n').encode('ascii'))
—
Reply to this email directly or view it on GitHub
https://github.com/balloob/home-assistant/issues/886#issuecomment-171129758
.

--
PaulusSchoutsen.nl
It's nice to be important but it's more important to be nice.

The quotes solved the problem @balloob!
Didn't teste the @digdugg modification.
Thanks!