Revisit REQUIRE

I still think the REQUIRE is way too large. As a machine learning package I think you shouldn't be depending on (for instance)
~Atom~
~BenchmarkTools~
CSVFiles
CUDAapi
ClassImbalance
Combinatorics
DecisionTree
~Documenter~
FluxJS
GLM
GPUArrays
JLD2
Knet
LIBSVM
~Literate~
MLBase
~MLDatasets~
~Metalhead~
~NBInclude~
NumericalIntegration
PGFPlots
PGFPlotsX
~ProgressMeter~
~RDatasets~
ROCAnalysis
~Requires~
ValueHistories
~Weave~
Many of these should be required only by the examples and tests (which can be moved out of main REQUIERE)
And maybe the Plotting packages can be handled asbackends as in Plots.jl
https://github.com/JuliaPlots/Plots.jl/blob/f2e2ffa17033145d06166db217b39ce3a45a02a1/src/backends.jl#L154

If Atom is not in REQUIRE, then the build breaks. Here’s the reason: one of
the upstream dependencies requires Juno. A different upstream dependency
has a conditional block where if Juno is available, then it loads all the
other Atom packages. If Juno is available but the other Atom dependencies
are not, then the package breaks. But Juno must be available because that
first dependency requires Juno. The net result is that we must require Atom
or everything breaks.
Requires is needed for conditional code loading. For example, CuArrays is
not in the PredictMD REQUIRE. But I can load GPU code conditionally if the
user imports CuArrays by using Requires. There’s no mechanism for lazy code
loading in Julia except with Requires.
RDatasets is required for the examples- if we don’t install it with
PredictMD, then users have to install it manually before they run an
example. This has a pretty severe impact on user experience. I want users
to be able to run the full examples as soon as they install PredictMD. So
we have to keep RDatasets in REQUIRE. And it’s the same argument for
MLDatasets.
It’s worth noting that there is precedence for machine learning packages
including datasets. For example, Knet includes code for downloading MNIST.
Metalhead provides computer vision models for Flux. Once we implement flux
support, users will be able to include Metalhead models as layers in their
flux nets.
Literate and Documenter could be moved to be test-only dependencies. BUT
the mechanism for specifying test-only dependencies is changing drastically
in Julia 0.7/1.0. I don’t want to create a test/REQUIRE file only to have
to delete it in Julia 0.7/1.0. I’d rather leave those packages in REQUIRE,
and then we will make them test dependencies when we transition to Julia
1.0.
ProgressMeter is there for showing a progress bar while training models.
It’s not implemented yet, but the plan is that for training neural
networks, instead of printing the loss every N epochs, the user could
choose to see a progress bar. I’d like to leave ProgressMeter in REQUIRE so
that when I implement this feature, I don’t have to worry about adding a
new package to Stronghold.
I once used Plots.jl as a plotting package. I will never do so again.
Eventually, once PGFPlotsX is stable, we’ll switch all of our plotting code
to PGFPlotsX, and then we can remove PGFPlots from REQUIRE.
The following packages are no longer necessary, and I will remove them from
REQUIRE: BenchmarkTools, NBInclude, Weave.
On Thu, Jun 21, 2018 at 15:25 Maria Isabel Restrepo <
<EMAIL_ADDRESS>wrote:

I still think the REQUIERE is way too large. As a machine learning package
I think you shouldn't be depending on (for instance)
Atom
BenchmarkTools
CSVFiles
CUDAapi
ClassImbalance
Combinatorics
DecisionTree
Documenter
FluxJS
GLM
GPUArrays
JLD2
Knet
LIBSVM
Literate
MLBase
MLDatasets
Metalhead
NBInclude
NumericalIntegration
PGFPlots
PGFPlotsX
ProgressMeter
RDatasets
ROCAnalysis
Requires
ValueHistories
Weave
Many of these should be required only by the examples and tests (which can
be moved out of main REQUIERE)
And maybe the Plotting packages can be handled asbackends as in Plots.jl
https://github.com/JuliaPlots/Plots.jl/blob/f2e2ffa17033145d06166db217b39ce3a45a02a1/src/backends.jl#L154
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bcbi/PredictMD.jl/issues/206, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFXArdetib6D7MJYacK8wUQV-C9v0ck6ks5t-_MUgaJpZM4Uyomj
.

--
Dilum Aluthge
<EMAIL_ADDRESS><EMAIL_ADDRESS>https://www.aluthge.com https://www.aluthge.com

Actually, disregard my statement about making Documenter and Literate
test-only dependencies. The whole point of test-only dependencies is that
when you run Pkg.test(), the test-only dependencies are downloaded and
installed, and then after the test suite is done running, the test-only
dependencies are deleted.
But on Stronghold, you can’t download packages! So how can a user run
Pkg.test(PredictMD) if they can’t download the test-only dependencies? It’s
very important to me that users are able to successfully run
Pkg.test(PredictMD) on any platform that they use, including Stronghold.
This is how they know that PredictMD will work.
So for users to be able to run the package tests on Stronghold, we cannot
have any test-only dependencies. So Documenter and Literate, which are
necessary for the test suite (part of the test suite is to generate
examples with Literate and execute the markdown examples with Documenter),
have to stay in REQUIRE.
On Thu, Jun 21, 2018 at 15:59 Dilum Aluthge<EMAIL_ADDRESS>wrote:

If Atom is not in REQUIRE, then the build breaks. Here’s the reason: one of
the upstream dependencies requires Juno. A different upstream dependency
has a conditional block where if Juno is available, then it loads all the
other Atom packages. If Juno is available but the other Atom dependencies
are not, then the package breaks. But Juno must be available because that
first dependency requires Juno. The net result is that we must require Atom
or everything breaks.
Requires is needed for conditional code loading. For example, CuArrays is
not in the PredictMD REQUIRE. But I can load GPU code conditionally if the
user imports CuArrays by using Requires. There’s no mechanism for lazy code
loading in Julia except with Requires.
RDatasets is required for the examples- if we don’t install it with
PredictMD, then users have to install it manually before they run an
example. This has a pretty severe impact on user experience. I want users
to be able to run the full examples as soon as they install PredictMD. So
we have to keep RDatasets in REQUIRE. And it’s the same argument for
MLDatasets.
It’s worth noting that there is precedence for machine learning packages
including datasets. For example, Knet includes code for downloading MNIST.
Metalhead provides computer vision models for Flux. Once we implement flux
support, users will be able to include Metalhead models as layers in their
flux nets.
Literate and Documenter could be moved to be test-only dependencies. BUT
the mechanism for specifying test-only dependencies is changing drastically
in Julia 0.7/1.0. I don’t want to create a test/REQUIRE file only to have
to delete it in Julia 0.7/1.0. I’d rather leave those packages in REQUIRE,
and then we will make them test dependencies when we transition to Julia
1.0.
ProgressMeter is there for showing a progress bar while training models.
It’s not implemented yet, but the plan is that for training neural
networks, instead of printing the loss every N epochs, the user could
choose to see a progress bar. I’d like to leave ProgressMeter in REQUIRE so
that when I implement this feature, I don’t have to worry about adding a
new package to Stronghold.
I once used Plots.jl as a plotting package. I will never do so again.
Eventually, once PGFPlotsX is stable, we’ll switch all of our plotting code
to PGFPlotsX, and then we can remove PGFPlots from REQUIRE.
The following packages are no longer necessary, and I will remove them from
REQUIRE: BenchmarkTools, NBInclude, Weave.
On Thu, Jun 21, 2018 at 15:25 Maria Isabel Restrepo <
<EMAIL_ADDRESS>wrote:

I still think the REQUIERE is way too large. As a machine learning
package
I think you shouldn't be depending on (for instance)
Atom
BenchmarkTools
CSVFiles
CUDAapi
ClassImbalance
Combinatorics
DecisionTree
Documenter
FluxJS
GLM
GPUArrays
JLD2
Knet
LIBSVM
Literate
MLBase
MLDatasets
Metalhead
NBInclude
NumericalIntegration
PGFPlots
PGFPlotsX
ProgressMeter
RDatasets
ROCAnalysis
Requires
ValueHistories
Weave
Many of these should be required only by the examples and tests (which
can
be moved out of main REQUIERE)
And maybe the Plotting packages can be handled asbackends as in Plots.jl

https://github.com/JuliaPlots/Plots.jl/blob/f2e2ffa17033145d06166db217b39ce3a45a02a1/src/backends.jl#L154

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bcbi/PredictMD.jl/issues/206, or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AFXArdetib6D7MJYacK8wUQV-C9v0ck6ks5t-_MUgaJpZM4Uyomj
.

--
Dilum Aluthge
<EMAIL_ADDRESS><EMAIL_ADDRESS>https://www.aluthge.com https://www.aluthge.com
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bcbi/PredictMD.jl/issues/206#issuecomment-399224336,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFXArWDeSY5BuelS1iKCZRd6nwYeF61hks5t-_sIgaJpZM4Uyomj
.

--
Dilum Aluthge
<EMAIL_ADDRESS><EMAIL_ADDRESS>https://www.aluthge.com https://www.aluthge.com

PR #207 removes BenchmarkTools, NBInclude, and Weave from REQUIRE. I’ll merge it as soon as all the checks pass.

@mirestrepo PR #207 has been merged, so BenchmarkTools, NBInclude, and Weave have been removed from REQUIRE.
In my opinion, all of the remaining packages need to stay in REQUIRE. Removing any of those packages from REQUIRE will either (a) break the package or (b) substantially degrade the end-user experience. I really want this package to be as easy as possible for users to use. Once a user does Pkg.clone("https://github.com/bcbi/PredictMD.jl"), they shouldn't have to do anything else in order to be able to use the package.
Please let me know if I can help you get the Julia dependencies working on the build server, I'm more than happy to help.

I also feel compelled to point out that there are several other Julia packages out there that have REQUIRE files of similar (or greater) length to ours. So certainly our REQUIRE is on the longer side, but there is definitely precedent for having Julia packages with long REQUIRE files.
The PredictMD REQUIRE file has 25 required packages. Here is a list of Julia packages registered in METADATA.jl that have at least 20 required packages:

Caesar - 23 required packages

https://github.com/JuliaRobotics/Caesar.jl/blob/master/REQUIRE

Celeste - 20 required packages

https://github.com/jeff-regier/Celeste.jl/blob/master/REQUIRE

DifferentialEquations - 24 required packages

https://github.com/JuliaDiffEq/DifferentialEquations.jl/blob/master/REQUIRE

GLVisualize - 23 required packages

https://github.com/JuliaGL/GLVisualize.jl/blob/master/REQUIRE

Gadfly - 20 required packages

https://github.com/GiovineItalia/Gadfly.jl/blob/master/REQUIRE

Images - 22 required packages

https://github.com/JuliaImages/Images.jl/blob/master/REQUIRE

Mads - 34 required packages

https://github.com/madsjulia/Mads.jl/blob/master/REQUIRE

This list only includes packages registered in METADATA.jl. I would not be surprised if there are some additional unregistered packages that have long REQUIRE files.

The bash script I used to search METADATA.jl for these packages:
for f1 in $( ls . )
do
    if [ -d "./$f1/versions" ]
    then
        for f2 in $( ls ./$f1/versions )
        do
            num_lines=`wc -l ./$f1/versions/$f2/requires | awk '{ print $1 }'`
            if (( num_lines > 20 ))
            then
                echo $f1
            fi
        done
    fi
done

I general, having so many dependencies adds a barrier (and even deterrent)  to the usage of the package. If for instance, users can't install/build Metalhead.jl (e.g right now the case in Stronghold) that shouldn't stop people from using the package. Or if and user is only interested in comparing regression and svm, why do they need to have all of the DeepLearning requirements? SO I could imagine going as far as having "Knet", "FluxJS" as optional "backends" - but it's okay not to do that for now since there aren't that many "backends" yet
More specifically, to address some of your comments

Literate and Documenter: I don't think you should have testsets for generating examples and documentation. That should only be done by travis. The tests should simply be unit tests about the code.
MLDatasets, MetalHead and others. When running the examples, the code could check if the Package is installed if not, then it installs it. For stronghold, I can separately install them and if any of them don't build, then there may only be a couple of examples that are not available inside Stronghold, but at least the package and most other examples can be available.
The good example of DifferentialEquations - 24 required packages
https://github.com/JuliaDiffEq/DifferentialEquations.jl/blob/master/REQUIRE
If you look at it, all requires are related to Differential equations, not to datasets, plotting, performance tools
Which dependencies requieres Juno/Atom?
I feel strongly that if a package is not directly and currently being used inside src/ then it should not be in the REQUIRE. Don't worry about having to installed then later or separately in stronghold - you can give me a list of those that you'd like to have

I general, having so many dependencies adds a barrier (and even deterrent) to the usage of the package.

I completely disagree. PredictMD is targeted at users whose primary domain is clinical medicine, not data science. Clinicians could not care less how many dependencies a package needs, as long as they are able to install it. (And I just had the entire Julia summer class successfully install PredictMD, so I believe that clinicians will indeed be able to install PredictMD.)

If for instance, users can't install/build Metalhead.jl (e.g right now the case in Stronghold) that shouldn't stop people from using the package.

I have yet to find someone who was not able to build Metalhead when installing PredictMD on their personal computer. Furthermore, Travis and AppVeyor logs reveal that Metalhead builds without error on Linux, Mac, and Windows. I believe that any PredictMD user with a sane computational environment should be able to install Metalhead without any problem.
If Metalhead does not build in Stronghold, then the problem is not with Metalhead, it is with Stronghold. If Stronghold is not able to build Metalhead (a relatively simple Julia package, with relatively few Julia dependencies, and no heavy duty binary dependencies), then I don't care how secure it is - no physician is going to use a secure environment if they can't actually do useful things in it.
If you can give me access to the Stronghold build server, I would love to work on figuring out why Metalhead is not building successfully.

Or if and user is only interested in comparing regression and svm, why do they need to have all of the DeepLearning requirements?

What cost is there to installing Knet even if the user never uses Knet model? A little extra time during installation? A little extra disk space to store the code? Such a minor cost that it's not even worth considering. On the other hand, suppose you didn't install Knet when you installed PredictMD. On Monday, a user is comparing regression vs svm. On Tuesday, she decides to compare regression vs svm vs neural network. But not so fast! Before she can do neural networks, she has to install Knet. But she says, "I already installed PredictMD, why do I have to install additional packages." This majorly degrades the user experience. In my opinion, it is absolutely better to spend a little extra time and disk space installing those packages up front when the user installs PredictMD, instead of putting users through the hassle of having to install more packages when they want more features. To borrow from the Python community, PredictMD comes "batteries included."

SO I could imagine going as far as having "Knet", "FluxJS" as optional "backends" - but it's okay not to do that for now since there aren't that many "backends" yet

I can definitely imagine a world in which some of the backends are optional. But we won't do that with core backends like GLM, LIBSVM, Knet, Flux. Maybe if we add things like lasso regression, etc., then MAYBE those packages can be optional backends. But even then, refer to my previous argument - the cost of installing these packages is so low; it just takes a little extra time, and costs more disk space. These packages are easy to install on all platforms, and any user with a reasonable computing set-up should not have trouble installing them.

More specifically, to address some of your comments

Literate and Documenter: I don't think you should have testsets for generating examples and documentation. That should only be done by travis. The tests should simply be unit tests about the code.

I strongly disagree. A synonym for "examples" is "integration/functional tests." The unit tests are great for testing individual pieces of code, but you can't test how the different parts of PredictMD work together without integration testing. The quoted statement above essentially says, "The tests should simply be unit tests, no functional or integration testing". I could not disagree more. Integration and functional testing is just as important as unit testing.

MLDatasets, MetalHead and others. When running the examples, the code could check if the Package is installed if not, then it installs it. For stronghold, I can separately install them and if any of them don't build, then there may only be a couple of examples that are not available inside Stronghold, but at least the package and most other examples can be available.

Again, this is incredibly inconvenient for the user. Suppose a user installs PredictMD, and then later, while on an airplane, opens Julia and decides to work on some machine learning models. She installed PredictMD and ran the test suite successfully, she should be all set, right? But oh no! She doesn't have internet access on the airplane. And she wants to write a computer vision model using some layers from Metalhead. Unfortunately she is out of luck because she has to download and install Metalhead. Why was that package not installed when she installed PredictMD??? User experience is the name of the game. Once you install PredictMD, you should have everything you need to be productive in machine learning.

The good example of DifferentialEquations - 24 required packages
https://github.com/JuliaDiffEq/DifferentialEquations.jl/blob/master/REQUIRE
If you look at it, all requires are related to Differential equations, not to datasets, plotting, performance tools

I mentioned DifferentialEquations mainly as an example of another package with a long REQUIRE. But since you bring it up - how is "DimensionalPlotRecipes" not related to plotting???

Which dependencies requieres Juno/Atom?

That's a good question, and I don't remember off the top of my head. This weekend, I'll make a branch that removes Atom from REQUIRE. Then, we can look at the Travis logs - the package build that breaks in the Travis log will be the trouble package to which I am referring. I would love to remove both Atom and Juno from REQUIRE. We just have to figure out this weird bug.

I feel strongly that if a package is not directly and currently being used inside src/ then it should not be in the REQUIRE. Don't worry about having to installed then later or separately in stronghold - you can give me a list of those that you'd like to have

Again, I disagree because of the purpose of PredictMD. It is targeted at users that want to get from "clinical question" to "comparison of machine learning models" as quickly as possible. An important part of that is having all of the components they need (including Julia packages) installed up front. Essentially, once a user types Pkg.clone("https://github.com/bcbi/PredictMD.jl") and allows the installation to complete, she should never again have to think about packages or dependencies.

Alright!


Webpack peer dependecy version

I think there is no need to lock on Webpack v1. It works on Webpack v2 (Tested with 2.4.1)
Please allow as peer dependency Webpack v2 also.

I will do a quick test (and maybe create an example) myself and change it if I don't run into any problems. Should be in the next update.

Version 0.3.0 should now be wbepack2 compatible

:+1: Thanks guy. By this closure-loader i was able to convert 5 year old project without npm and manual script compiling to Webpack and npm dependencies. :slightly_smiling_face:

That's what I created it for, good look with your project :)


[Snyk] Upgrade @loopback/core from 6.0.2 to 6.1.4

Snyk has created this PR to upgrade @loopback/core from 6.0.2 to 6.1.4.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 5 versions ahead of your current version.

The recommended version was released on 2 months ago.

Release notes

Package name: @loopback/core

6.1.4 - 2024-10-15

6.1.3 - 2024-09-12

6.1.2 - 2024-08-14

6.1.1 - 2024-07-09

6.1.0 - 2024-06-11

6.0.2 - 2024-05-17

    from @loopback/core GitHub release notes

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:

🧐 View latest project report
📜 Customise PR templates
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Done in https://github.com/sourcefuse/loopback4-ratelimiter/pull/202


Documentation for custom document models

The WAGTAILDOCS_DOCUMENT_MODEL setting that allows developers to define a custom document model has been introduced in Wagtail v1.4, but it's not properly documented. The only mention about this feature can be found in the release notes for Wagtail v1.4.
For examples, see:

Custom image models
Settings Variables -> Images
Custom user models
Stackoverflow answer: how to define a custom document model

#2001 is about documentation for for the whole documents app. I think we can start from documenting custom models.

I just did this a couple times the other week so I'll submit a PR for this today.

For posterity: this doc will need to be updated again if/when #3539 is fixed.

Fixed in #3789


Add sendx5c parameter to Certificate factory class

#minor
Description
This PR adds the sendx5c parameter to the CertificateServiceClientCredentialsFactory and MsalAppCredentials classes.
Specific Changes

Added  sendx5c parameter to the CertificateServiceClientCredentialsFactory class into a new constructor.
Added  sendx5c parameter to the MsalAppCredentials  class into a new constructor.
Updated CertificateServiceClientCredentialsFactoryTests to cover the new constructor.
Added MsalServiceClientCredentialsFactoryTests  test class.

Testing
This image shows the new tests passing.

Converting to draft while reviewing #6694

Pull Request Test Coverage Report for Build 372229

0 of 0   changed or added relevant lines in 0 files are covered.
47 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.05%) to 73.501%

Files with Coverage Reduction
New Missed Lines
%

/libraries/Microsoft.Bot.Connector/Authentication/CertificateAppCredentials.cs
2
17.95%

/libraries/Microsoft.Bot.Connector/Authentication/MsalAppCredentials.cs
45
12.22%

Totals

Change from base Build 371560:
0.05%

Covered Lines:
24173

Relevant Lines:
32888

💛  - Coveralls

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll

Hi @tracyboehrer , we reverted the changes to CertificateServiceClientCredentialsFactory as they were addressed in #6694. We kept the changes to MsalAppCredentials and the new unit tests.


Confusing/erroneous instructions, plus sign-in loop

In the section where it asks to use the Office 365 app registration tool, the parameters for the tool do not match the parameters in the instructions.  For example, the properties on the main page for a registered app in Azure AD only show:

Display Name
Application Type
Home Page
Application ID
Object ID

The bigger problem though is that the instructions state to "copy and store the returned Client ID and Client Secret values".  Where is Client Secret?  Is it Object ID?  Does Client ID = Application ID?  Those are the values I've used for the keys in the web.config file.  However, when I run the app I get a repeating loop: Create Registration -> Signin -> Create Registration, etc.  It never gets to the stage that displays the 'Watch for notifications' button.  I am using ngrok and have edited web.config accordingly:
<add key="ida:NotificationUrl" value="https://4ca0d7a8.ngrok.io:44300/notification/listen" />

Does that URL have to be used in the app registration parameters? What am I doing wrong?
Also, is it not required that permissions to Microsoft Graph be added to the app via the registration page in Azure?  Wouldn't "Read mail in all mailboxes" be required?

I tried creating the app via the App Registration Portal instead (which does have a client secret) and I at least got a little further and can authenticate.  I also fixed the problem with my NotificationUrl key containing the port number (44300), so I removed that.  However now when I login via Firefox, it simply returns to the login screen instead of the main app page.  With other browsers I can login, but clicking the "Create subscription" button attempts to navigate to the below URL but it never gets reached and is always "Working...":
https://login.microsoftonline.com/common/oauth2/authorize?client_id=12346328-22fd-42d2-9b6b-b353b9403136&response_mode=form_post&response_type=code+id_token&scope=openid+profile&state=OpenIdConnect.AuthenticationProperties%3DVvxlwBTtDLgte622W2jVkBOZXj9xsCA318ZiHFnazwR_9R0LQxUlGqwbRHaOP4UK2-5f-GNON_kX_WPI5Uhg71aQIjc0Rbzlf7-WM-4-_75CI2mw5RK-lQ1r7qduU6UwN8G8SPgwAGvN8-Y5ABqhrmfQx_jTDHuz10ih2l7_FFg&nonce=636152919460533729.MDgzNzY3MDUtYjhkZS00MzE2LThjNWUtMDBiYmQ4MzdhOTI2OWI1NjA0YmQtOTQ3My00NDZhLTg1ODctZWRlZDIyYTQzNjRj&redirect_uri=https%3A%2F%2Flocalhost%3A44300%2F&post_logout_redirect_uri=https%3A%2F%2Flocalhost%3A44300
FYI, my http port is 54089, my https port is 44300. So I ran ngrok with:
ngrok http 54089 -host-header=localhost:44300
Is only localhost and the https port number used in the manifest/app keys?  Not the ngrok url and tunnel?
BTW: the screenshot in step 6 has the wrong port number (51825), it should be 21942 according to the two previous screenshots.

My apologies - I was testing the URL with /common/v2.0 as I thought that was an omissions It works fine now after I stuck with the default URL, and also after I revoked the app permissions and re-authed it since I added Mail.Read permissions after the fact.    :-)

Hi @elegault . Thanks for your feedback! Sorry--I started updating the instructions for the new portal last week, but not in time for your run. I think I addressed all the issues you describe here. Thanks again for the detailed report!


Scheduling

Added support for send scheduled message event

Hey there and thanks for another PR.
I haven't tested the code in question, but apart from that everything else looks clean.
One question though: What's the correlation between send_message and send_scheduled_message? If I send a scheduled message which event(s) should I expect, and in what order?
Due to the nature of the code in question, I can't tell without experimenting, so this really needs to be spelled out somewhere. It would IMO be beneficial to add to the documentation.
Could you add a little extra to cover that topic?

Hey
There is no connection between these events.
send_message will work only for usual sending.
send_scheduled_message will work only for scheduled sending.
I decided to separate these two events, since the scheduling is not the actual sending.
Please let me know what do you think about it.

Do you know if you schedule something 5 minutes from now... And keep the window open.
Will send_message fire 5 minutes later, or is that done completely in the dark?

when you scheduled a message the compose window automatically closes and the message goes into the scheduled label, without the possibility of editing (this is not a draft), user can only cancel sending
video with scheduling flow

Looks legit. Thanks for putting in the effort in demonstrating it.
Looking at it that way, I would probably like to phrase it somewhat differently in the documentation:

send_message - When a message is sent (except scheduled messages)
send_scheduled_message - When a message is scheduled for sending (but not actually sent)

Unless I misunderstood how things work, I think that might be more descriptive and understandable for people reading the documentation and wanting to know what these events represents.
Could you touch those bits up too?

Done

Great stuff. Thanks for the PR.
Consider it merged!

@josteink hi,
just found out that there are no PR changes in npm repository
https://registry.npmjs.org/gmail-js/-/gmail-js-0.9.5.tgz
can you clarify it?
thanks

That seems to be correct.
We need to bump the version and update the changelog, and then we can publish a new version with the changes from your PR.
Sorry about the delay.

0.9.6 is out now. Thanks for your PRs!


Help with hcsr04 sensor

I need to use the BBB with ultrasonic hcsr04 sensor. For this, its necesary to measure the duration of the pulse.. can anyone help me?

You must use the PRU or switch to a real-time operating system to precisely measure the duration of the pulse.

This issue was moved to beagleboard/bonescript#32


How to use PowerShell to apply custom template?

Hi,
I want to know the whole process of creating sitecollection and applying custom template through PowerShell. And what commands are used.
Thanks

@officedocsbot assign @yogkumgit

Hello @7angjinhao
This issue system is intended to report issues in documentation, besides that, you can start looking here
Hope this info helps you

@get-itips Thank you so much

@get-itips  Thank you very much for the contribution and sharing this explanation. @7angjinhao
Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Use github.com/vpp-dev/vpp/tree/stable-1801-contiv as the base code for VPP

This MR migrates the code base for VPP to github.com/vpp-dev/vpp/tree/stable-1801-contiv
It also contains update of the ligato/vpp-agent, which is now compatible with that version of VPP.
This version of VPP contains new NAT fixes, that should resolve some issues with STN deployment with SNAT.

Coverage remained the same at 75.349% when pulling a9b22a6b12db88e7fc18c3a9450bdb14e2323e9e on rastislavszabo:master into 1ef26bba372208bfc28406d22effbe7f407c54dd on contiv:master.


On the fly ocelot.json configuration merging

We are trying to merge multiple ocelot.json files without restarting the application with below code. However we are successfully able to merge on starting the application, but still application restart is required to merge multiple ocelot.*.json files changes. Even we updated latest ocelot version 23.2.2.
Please guide if we are missing any reference or any mistake in below mentioned code.
webBuilder.ConfigureAppConfiguration((context, config) =>
{
    var folder = Path.Combine(AppDomain.CurrentDomain.BaseDirectory);
    var path = Path.Combine(folder, "My\\folder");
    config.AddOcelot(path, context.HostingEnvironment, MergeOcelotJson.ToFile, optional: false, reloadOnChange: true); // with folder, environment and merging type
})

Our ocelot.json file structure is like:

ocelot.common.json
ocelot.mfcommon.json

Hi @SheruGaur
The Q 1

still application restart is required to merge multiple ocelot.*.json files changes.

Correct! If you have partial config files, they will be merged only during Ocelot app start. And the same configuration will be available during Docker container life time.
The Q 2

On the fly ocelot.json configuration merging

This feature is not implemented for partial config files, ocelot.*.json!
Ocelot is able to track ocelot.json on the fly if you use Administration feature or copy the ocelot.json file to app folder manually.
Merging partial files on the fly requires a lot of development.

I have a question for you.
Why do you need to update partial config files so often ?
What's your user scenario?
What's your deployment environment: self-contained, IIS, Docker, K8s, cloud?
If your environment is Docker and/or K8s then why not to manage Ocelot app version and its configuration ocelot.json by Docker image version, and create/kill Docker containers?
This is more easy DevOps approach than juggling multiple partial files for long living Ocelot app instance.


[Platform] linux

Reproduction steps
Hi please share  a list of all the python packages and versions used to build the example codes.
Platform
python, other
Platform Version(s)
No response
Type
Manually tested with SDK, Platform validated
(Optional) If manually tested please explain why this is only manually tested
No response
Anything else?
No response

@andy31415

An exact list may not be easily built. I would suggest to run a build that you need and then run pip list to fetch the list of installed packages.

I get an error related to psutils package, I tried every article out there but just cant get through the issue, Can you have a look at the log and revert back to me.
Building wheels for collected packages: mobly, psutil, pyperclip
Building wheel for mobly (setup.py): started
Building wheel for mobly (setup.py): finished with status 'done'
Created wheel for mobly: filename=mobly-1.12.1-py3-none-any.whl size=160690 sha256=8f4af6380d5b45b0f351e92e186c332f878d1e0f192370a90e02c081a0404c6d
Stored in directory: /root/.cache/pip/wheels/63/bb/6f/5332fa07292cfad692d273db4b9d6b140d50913113a03922bf
Building wheel for psutil (pyproject.toml): started
error: subprocess-exited-with-error
�× Building wheel for psutil (pyproject.toml) did not run successfully.
�│ exit code: 1
�╰�─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.
Building wheel for psutil (pyproject.toml): finished with status 'error'
ERROR: Failed building wheel for psutil
Building wheel for pyperclip (setup.py): started
Building wheel for pyperclip (setup.py): finished with status 'done'
Created wheel for pyperclip: filename=pyperclip-1.9.0-py3-none-any.whl size=11002 sha256=5b8ccaf3cb807f548de558f1b977e1c4e07efaeb26324ff0caec6fe5f6eb687e
Stored in directory: /root/.cache/pip/wheels/6d/a5/02/e801d8db207899213bc1e564f861696b03cb9598c2817b2b62
Successfully built mobly pyperclip
Failed to build psutil
ERROR: Could not build wheels for psutil, which is required to install pyproject.toml-based projects
ninja: build stopped: subcommand failed.
['ninja', '-C', '/run/media/mmcblk1p1/edge3ConnectedIp/.environment/gn_out', '-v', ':python_packages.install']
Traceback (most recent call last):
File "/run/media/mmcblk1p1/edge3ConnectedIp/third_party/pigweed/repo/pw_env_setup/py/pw_env_setup/virtualenv_setup/install.py", line 421, in install_packages
subprocess.check_call(ninja_cmd, stdout=outs, stderr=outs)
File "/usr/lib/python3.8/subprocess.py", line 364, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['ninja', '-C', '/run/media/mmcblk1p1/edge3ConnectedIp/.environment/gn_out', '-v', ':python_packages.install']' returned non-zero exit status 1.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/run/media/mmcblk1p1/edge3ConnectedIp/third_party/pigweed/repo/pw_env_setup/py/pw_env_setup/env_setup.py", line 995, in
sys.exit(main())
File "/run/media/mmcblk1p1/edge3ConnectedIp/third_party/pigweed/repo/pw_env_setup/py/pw_env_setup/env_setup.py", line 987, in main
return EnvSetup(**vars(parse())).setup()
File "/run/media/mmcblk1p1/edge3ConnectedIp/third_party/pigweed/repo/pw_env_setup/py/pw_env_setup/env_setup.py", line 577, in setup
result = step(spin)
File "/run/media/mmcblk1p1/edge3ConnectedIp/third_party/pigweed/repo/pw_env_setup/py/pw_env_setup/env_setup.py", line 766, in virtualenv
if not virtualenv_setup.install(
File "/run/media/mmcblk1p1/edge3ConnectedIp/third_party/pigweed/repo/pw_env_setup/py/pw_env_setup/virtualenv_setup/install.py", line 443, in install
install_packages(gn_target)
File "/run/media/mmcblk1p1/edge3ConnectedIp/third_party/pigweed/repo/pw_env_setup/py/pw_env_setup/virtualenv_setup/install.py", line 424, in install_packages
raise subprocess.CalledProcessError(
subprocess.CalledProcessError: Command '['ninja', '-C', '/run/media/mmcblk1p1/edge3ConnectedIp/.environment/gn_out', '-v', ':python_packages.install']' returned non-zero exit status 1.
root@se-704a0efeee54:/run/media/mmcblk1p1/edge3ConnectedIp#

I don't seem to see the undelying error from the logs. Try a pip install psutil==5.9.4 and see if that fails out with a clearer error message.


Ability to include custom modules during upload

https://github.com/morgen-so/morgen-cw-sdk/blob/main/src/index.ts#L92-L116
I think being able to accept "extra=" in the upload function, and adding to this list would allow for flexibility of reusable and sharable code.
I am willing to make a PR for this.

I can certainly see the advantage of user-specified utility functions supported by the SDK, and thanks for offering to make a PR - that would be very appreciated. 🥳
In terms of the implementation, I think a parameter here makes sense, and I think we should follow the pattern of having an options parameter with TypeScript documented fields, so in this case:
async upload(options:{
    /** something **/
    userUtilityFunctions: Function[]
   }) { ... }

And then the array can be union-ed with a default array of functions.
The specified functions can't access anything global or imported (unless it's taken from the sandbox import). In the workflow script they can be imported and used as any other import (I think). This should probably be mentioned in the docs.
Wdyt? 😄

That is pretty much what I had in mind.


Cannot be run on Android

The famous Cannot Add a child that doesn't have a YogaNode to a parent with out a measure function error occurred after clicking on the Getting Started button.
[text: 0]

Same here

+1

Already fixed, If you suddenly repeat, reopen issue again


2d FFTs

I hope your To-Do list includes at least 2d FFTs?

Nd FFTs are on the list, yes. Getting non power of 2 length support was a prerequisite to this. It is now trivial to support 2d and Nd FFTs.

2d FFTs got done at 7f0f379


Wrong Katakana Range

The official range for Katakana goes from U+30A0-U+30FF, but it seems to be U+30A1-U+30FA in KanaAppraiser.java

Yea you're right.
The characters outside the range I've defined in KanaAppraiser.java are symbols and not actually "kana" per say, but there should be a way to indicate they are Japanese text at least.  Let me look into addressing this.

Hi @stephenmac7 ,
I'd like to note that the Unicode Block for Katakana and Hiragana is not the official definition of what is and is not actually Katakana and Hiragana (A Japanese dictionary or textbook is a much better authority on that matter).  Unicode blocks must be 16-chars long, so they tend to have extra chars lumped in, and both the hiragana and katakana blocks have some punctuation marks in them.
What I've done is include a new set of functions in KanaAppraiser to identify Japanese punctuation marks or kutoten, on their own as separate entities from hiragana/katakana.  These new functions are isZenkakuKutoten and isHankakuKutoten.  This now covers those extra chars in the Hiragana and Katakana Unicode blocks, as well as a few others from around the Unicode spectrum.
Please see the pull request mentioned above for the diff.
This issue has been addressed in v1.3.0 so I am considering it now closed.
Thanks for the contact.

Okay, thanks. I understand that you want the Katakana range to only include actual Katakana instead of just the whole Katakana unicode block. At least now it's possible to detect them, so thank you!


[Safari] "Add to Reading List" command opens Safari unexpectedly

Extension
https://www.raycast.com/loris/safari
Description
When I execute the command "Add to Reading List" while the Safari app is closed, the command opens the Safari app but doesn't close it afterwards. I assume that the command needs to open Safari to be able to add an item to its reading list but I'd expect the command to close Safari in case it wasn't open already.
Steps To Reproduce

Make sure Safari app is closed
Execute "Add to Reading List" with valid URL
Safari stays open after command finished

Current Behaviour
Safari app stays open after command
Expected Behaviour
Safari app stays open if it was open before but closes if it wasn't open before the command.

By the way not sure whether this is a bug report or a feature request. 😅

This is kind of expected because the extension relies on AppleScript to interact with Safari. Unfortunately, these interaction is only possible while the receiving app is open, in this case Safari. I'm clsoing the issue because there isn't an easy workaround for this.


Simplify migrator creation and usage

Summary of changes

Update migration_recursion.py to always use the dictionary returned by the transformer (instead of assuming the transformer modifies the dictionary in place, which may not always be the case).
Rename all migrator classes from Migrator_from_... to Migrator and update all references accordingly.
Now that all migrators have the same class name, update migration_recursion.py to expect the CLI option to be a migrator module name instead of a class name.
Add the "from" and "to" versions as class attributes (to enable consumers to read them programmatically).
Make each migrator's agenda attribute be a "pseudo-private" variable (i.e. use Python's _varname naming convention) and update all references accordingly.
Implement a CLI command (i.e. click function) that generates a migrator skeleton (which is already a valid "no-op" migrator). Add a make target (i.e. make migrator) that invokes it. The CLI command will prompt the user for the two version numbers if not provided via CLI options.
Update the migrator docs to address "no-op" migrators. Also add a link to the version numbering guide (i.e. CHANGELOG.md).

Details are in Issue https://github.com/microbiomedata/nmdc-schema/issues/1456

Here's what it looks like when I run $ make migrator:
$ make migrator
poetry run python nmdc_schema/migrators/cli/create_migrator.py
From schema version: 1.2.4
To schema version: 2.6
Created 'migrator_from_1_2_4_to_2_6.py' successfully.

FYI @Shalsh23: Here's the final version of the branch we looked at on 12/5. Since then, I added a CLI command that generates a migrator.

FYI @Shalsh23: Here's the final version of the branch we looked at on 12/5. Since then, I added a CLI command that generates a migrator.

Thanks, Eric.

@eecavanna @brynnz22 what's the next step for this? Who needs to review?

I expect @turbomam to be the person that ultimately reviews and merges this. I had added @brynnz22 as a reviewer as a way of bringing these upcoming changes to her attention, since she also works with this part of the code base.

Moving to current sprint for @turbomam to review

@turbomam, here's a direct link to the diff between the branch when we "pair reviewed" it during a migration squad meeting a couple weeks ago; and its latest commit. In other words, it shows the changes we haven't reviewed together yet.
https://github.com/microbiomedata/nmdc-schema/compare/9fccb15..7ef4571

I'll look into adding an entry to tool.poetry.scripts for the create_migrator.py script.

I added a create-migrator Poetry script, and updated the make target to use it.

Thanks, @turbomam. I'm comfortable with this being merged into main as is.


App icon

Added icons for all iPhone and iPad devices, iOS 7-9.
Attached screenshot shows before-and-after home screen icons.

Where did you get the icons? Please copy them from the Traccar Client project and make naming consistent.

There were some icons already in the project in the logo asset group. I just scaled them down to appropriate sizes and copied them across to the icon asset group.
I've just updated the PR with a copy of the icon files from the Traccar Client project.

Merged. Thanks.


Consider adding content-type:  'application/x-www-form-urlencoded' for every XHR POST request

Hi,
Now I have to set this header every time I'm doing post request. Prototype for example always (even for get requests) add this header. Thanks to this it works with e.g. PHP's $_POST variable.

Fixed in 454bd6d. Didn't tag it as I didn't think it was necessary, but yeah, it's there anyways


Tilemaps do not scale properly when the window is resized

Version

Phaser Version: 3.17.0
Operating system: MacOS 10.14.4
Browser: Latest version of Chrome

Description
I want to make a game that fills 100% of the screen space (ignoring aspect ratio). I want the game to have a render width of 256.
I think I have this working, however the tilemaps do not scale properly when the browser is resized/ mobile device is rotated.
Example Test Code
You can see a demo here.
https://codepen.io/BinaryMoon/full/WBRbvX
If you open the inspector and drag the width to make the game narrower you will see the tilemap proportions change a lot.
I added a scaled down version of the phaser logo to show the issue is specific to tilemaps. The logo seems to display fine.
Additional Info
I have seen one instance of the logo image being cropped but I can't reproduce it so I don't know if it's related to this or not. I image it's a separate problem but thought I would mention it in case there's a connection.

Heya - pretty sure this is working properly now. Could you please test it against a build from the master branch? Here is my modified code, I'm using different tiles / image so it's much easier to see if they go out of scale:
let currentMaze = null;
let vx = 1, vy = 1;

function preload() {

    // this.load.image( 'maze1', 'assets/tilemaps/tiles/ground_1x1.png' );

    this.load.image( 'maze1', 'assets/tilemaps/tiles/gridtiles.png' );

    this.load.image( 'logo', 'assets/sprites/128x128.png' );

}

function create() {

    let maze = [
        [ 1, 5, 3, 1, 2, 3, 4, 5, 6, 8, 9, 7, 6, 1, 2, 3, 4, 5, 6, 7, 8, 9 ],
        [ 2, 3, 5, 6, 2, 3, 7, 5, 3, 5, 8, 9, 0, 3, 1, 2, 6, 8, 5, 3, 5, 6 ],
        [ 4, 5, 7, 3, 5, 8, 6, 4, 8, 0, 7, 4, 6, 3, 4, 5, 7, 2, 4, 6, 8, 9 ],
        [ 3, 2, 5, 6, 7, 8, 4, 3, 2, 5, 6, 4, 2, 2, 3, 5, 7, 9, 3, 1, 2, 4 ],
        [ 1, 5, 3, 1, 2, 3, 4, 5, 6, 8, 9, 7, 6, 5, 7, 3, 5, 7, 2, 4, 7, 9 ],
        [ 2, 3, 5, 6, 2, 3, 7, 5, 3, 5, 8, 9, 0, 2, 4, 6, 8, 9, 4, 2, 6, 8 ],
        [ 4, 5, 7, 3, 5, 8, 6, 4, 8, 0, 7, 4, 6, 3, 5, 6, 9, 0, 5, 2, 5, 7 ],
        [ 3, 2, 5, 6, 7, 8, 4, 3, 2, 5, 6, 4, 2, 3, 5, 7, 8, 9, 0, 3, 5, 7 ],
        [ 1, 5, 3, 1, 2, 3, 4, 5, 6, 8, 9, 7, 6, 1, 2, 3, 4, 5, 6, 7, 8, 9 ],
        [ 2, 3, 5, 6, 2, 3, 7, 5, 3, 5, 8, 9, 0, 3, 1, 2, 6, 8, 5, 3, 5, 6 ],
        [ 4, 5, 7, 3, 5, 8, 6, 4, 8, 0, 7, 4, 6, 3, 4, 5, 7, 2, 4, 6, 8, 9 ],
        [ 3, 2, 5, 6, 7, 8, 4, 3, 2, 5, 6, 4, 2, 2, 3, 5, 7, 9, 3, 1, 2, 4 ],
        [ 1, 5, 3, 1, 2, 3, 4, 5, 6, 8, 9, 7, 6, 5, 7, 3, 5, 7, 2, 4, 7, 9 ],
        [ 2, 3, 5, 6, 2, 3, 7, 5, 3, 5, 8, 9, 0, 2, 4, 6, 8, 9, 4, 2, 6, 8 ],
        [ 4, 5, 7, 3, 5, 8, 6, 4, 8, 0, 7, 4, 6, 3, 5, 6, 9, 0, 5, 2, 5, 7 ],
        [ 3, 2, 5, 6, 7, 8, 4, 3, 2, 5, 6, 4, 2, 3, 5, 7, 8, 9, 0, 3, 5, 7 ],
        [ 3, 2, 5, 6, 7, 8, 4, 3, 2, 5, 6, 4, 2, 2, 3, 5, 7, 9, 3, 1, 2, 4 ],
        [ 1, 5, 3, 1, 2, 3, 4, 5, 6, 8, 9, 7, 6, 5, 7, 3, 5, 7, 2, 4, 7, 9 ],
        [ 2, 3, 5, 6, 2, 3, 7, 5, 3, 5, 8, 9, 0, 2, 4, 6, 8, 9, 4, 2, 6, 8 ],
        [ 4, 5, 7, 3, 5, 8, 6, 4, 8, 0, 7, 4, 6, 3, 5, 6, 9, 0, 5, 2, 5, 7 ],
        [ 3, 2, 5, 6, 7, 8, 4, 3, 2, 5, 6, 4, 2, 3, 5, 7, 8, 9, 0, 3, 5, 7 ],
        [ 1, 5, 3, 1, 2, 3, 4, 5, 6, 8, 9, 7, 6, 1, 2, 3, 4, 5, 6, 7, 8, 9 ],
        [ 2, 3, 5, 6, 2, 3, 7, 5, 3, 5, 8, 9, 0, 3, 1, 2, 6, 8, 5, 3, 5, 6 ],
        [ 4, 5, 7, 3, 5, 8, 6, 4, 8, 0, 7, 4, 6, 3, 4, 5, 7, 2, 4, 6, 8, 9 ]
    ];

    // When loading from an array, make sure to specify the tileWidth and tileHeight
    let tilemap = this.make.tilemap(
        {
            key: 'maze',
            data: maze,
            tileWidth: 16,
            tileHeight: 16
        }
    );

    let tiles = tilemap.addTilesetImage( 'maze1' );

    currentMaze = tilemap.createStaticLayer( 0, tiles, 0, 0 );
    // currentMaze = tilemap.createDynamicLayer( 0, tiles, 0, 0 );

    let logo = this.add.sprite( 16, 16, 'logo' );
    logo.setOrigin( 0 );

}

const get_game_size = () => {

    let game_width_ratio = window.innerWidth;
    let game_height_ratio = window.innerHeight;

    let game_width = 256;
    let game_height = ( game_width / game_width_ratio ) * game_height_ratio;

    return {
        width: game_width,
        height: game_height
    };

};

const resize_game = () => {

    let game_size = get_game_size();
    // game.scale.resize( game_size.width, game_size.height );
    game.scale.setGameSize( game_size.width, game_size.height );

};

window.addEventListener( 'resize', resize_game );

let game_size = get_game_size();

const sceneProperties = {
    preload,
    create
};

const config = {
    parent: 'phaser-example',
    title: 'MazeMazeMaze',
    url: 'https://mazemazemaze.com',
    type: Phaser.AUTO,
    backgroundColor: 0xff0000,
    scale: {
        mode: Phaser.Scale.NO_SCALE,
        width: game_size.width,
        height: game_size.height
    },
    scene: sceneProperties,
    pixelArt: true,
    roundPixels: true
};

const game = new Phaser.Game( config );

Thanks Rich. I can confirm it works as expected in the latest version! :)


[BUG] debug_traceBlockByNumber returns empty tx traces

Seid version
Show us output of seid version --long | head
name: sei
server_name: <appd>
version: v5.6.2
commit: 6bad61226f092fadad126d78f52e1cbab3b13d7a
build_tags: netgo,
go: go version go1.21.10 linux/amd64
build_deps:
-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>
Chain ID
Sei Pacific - 1329
Describe the bug
A clear and concise description of what the bug is.
debug_traceBlockByNumber returns
{"jsonrpc":"2.0","id":1,"result":[{"txHash":"0x8b258dc91cf176806ac9791ac713f2ab55501eb122b6ca326bea335cdfa64e0e","result":{}}]}

This happens on the following blocks
debug_traceBlockByNumber 87557016 (0x5380398):
{"jsonrpc":"2.0","id":1,"result":[{"txHash":"0x8b258dc91cf176806ac9791ac713f2ab55501eb122b6ca326bea335cdfa64e0e","result":{}}]}

debug_traceBlockByNumber 89468641 (0x5552ee1):
{"jsonrpc":"2.0","id":1,"result":[{"txHash":"0xc72961d5940ea49a0564e4bf5f2d12bb007f3f0234fd88b7453ca76530d4f55b","result":{}}]}

debug_traceBlockByNumber 81772251 (0x4dfbedb):
{"jsonrpc":"2.0","id":1,"result":[{"txHash":"0x2253b31fdefa86fcee046209e78e573f34254592be3424fb7ccdc02271d7e96e","result":{}}]}

hi @quick-pawiromitchel which rpc endpoint are you using? it could be a result of some min gas prices set by the rpc provider - you can try other providers

Closing for now, feel free to reopen if you're still seeing issues


Modifications to click activation & panel styling

New option to start with panel open.

Move button outside of panel when using click activation (see examples)

Changes to layer & group name alignment (when wrapping align with beginning of name).

Minor editing to README.md

Do you have a link to an example that demonstrates the changes?

Alignment changes
Before:

After:

Sorry to be a pain, can the format changes could be split out into a separate PR? It's making it very difficult to see the functional changes.

I've rolled back a couple of changes that were just muddying the water and merged upstream master.

@devsupportman I've a bunch of tests ready to commit tomorrow morning then I think we're good 👍
There are a few other changes such as improving the names of options and CSS classes but I think we should roll those into the next major version.

Looks good to me


auditbeat7: init

Description of changes
rebase from #137661
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 251515 run on x86_64-linux 1

1 package built:

auditbeat (auditbeat7)


Vue warn after upgrading from 0.1.10 to 0.1.13

Hello
I've got this error
vue.esm.js?efeb:1717 TypeError: this.$options.events[key].bind is not a function     at VueComponent.beforeCreate (index.js?119a:121)     at callHook (vue.esm.js?efeb:2895)     at VueComponent.Vue._init (vue.esm.js?efeb:4556)     at new VueComponent (vue.esm.js?efeb:4728)     at createComponentInstanceForVnode (vue.esm.js?efeb:4242)     at init (vue.esm.js?efeb:4059)     at createComponent (vue.esm.js?efeb:5512)     at createElm (vue.esm.js?efeb:5460)     at createChildren (vue.esm.js?efeb:5586)     at createElm (vue.esm.js?efeb:5488)
In SuiButton, SuiDropdown and SuiDropdownitem component after upgrading version of Semantic-UI-Vue. After that warn, most of the components doesn't work properly.

And why you're updating to such old version of Sui-Vue?

I'm having a similar problem ... when I use some component of semantic ui vue, I get the following message on the console:
TypeError: this. $ Options.events [key] .bind is not a function
Battery Tracking:
beforeCreate @ webpack-internal: /// 16: 121: 25
callHook @ webpack-internal: /// 1: 2919: 9 ....
Thanks to anyone who can help.

@rabello98 it's hard to give you an answer without a code. Please try to reproduce the error here so we can give you support.
@roophieini Closing this as it concerns an old version of Semantic UI Vue. We'll reopen it if you still have problems after upgrading to the latest version (0.2.6)

I've the same issue with semantic-ui-vue 0.8.1.
You can see it in action here : https://codesandbox.io/s/7m0q4w7zqq
This problème is similar in #161


ldc: 1.36.0 -> 1.38.0, clean up

Description of changes
https://github.com/ldc-developers/ldc/releases/tag/v1.37.0
(edit 2024/05/12) https://github.com/ldc-developers/ldc/releases/tag/v1.38.0
Also migrate to pkgs/by-name and clean up the package a bit (see commits).
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Waiting on #288841

Just a heads up: the other PRs have been merged

Thanks. 1.38.0 is almost ready, I'll wait for that first.

Updated to 1.38.0

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3920

Result of nixpkgs-review pr 293417 run on x86_64-linux 1

4 packages failed to build:

gtkd
inochi-creator
inochi-session
tilix

14 packages built:

Literate
btdu
cheesecutter
dstep
dtools
dub
ldc
luneta
onedrive
onedrivegui
onedrivegui.dist
rund
sambamba
serve-d

Tilix fails to build because gtkd fails to build, and gtkd fails to build because
of something I'm guessing is in the fixup phase:
Running phase: fixupPhase
shrinking RPATHs of ELF executables and libraries in /nix/store/h69b9p2x7kfv6ijc5cxy8kkbifpdcgif-gtkd-3.10.0
checking for references to /tmp/nix-build-gtkd-3.10.0.drv-0/ in /nix/store/h69b9p2x7kfv6ijc5cxy8kkbifpdcgif-gtkd-3.10.0...
patching script interpreter paths in /nix/store/h69b9p2x7kfv6ijc5cxy8kkbifpdcgif-gtkd-3.10.0
stripping (with command strip and flags -S -p) in  /nix/store/h69b9p2x7kfv6ijc5cxy8kkbifpdcgif-gtkd-3.10.0/lib
chmod: changing permissions of '/lib/pkgconfig/atk-bridge-2.0.pc': Operation not permitted
/nix/store/558iw5j1bk7z6wrg8cp96q2rx03jqj1v-stdenv-linux/setup: line 131: pop_var_context: head of shell_variables not a function context

Inochi fails because the json library attempts to throw an immutable exception:
../.dub/packages/fghj/1.0.2/fghj/source/fghj/fghj.d(244,19): Deprecation: cannot throw object of qualified type `immutable(EmptyFghjException)`

fghj.d(244)
I can't find anything in the changelogs for 2.107-2.108 about this either...

If you look at the inochi logs, the errors are earlier.
And are results of this being fixed: https://issues.dlang.org/show_bug.cgi?id=24387 in dmd, which is in the ldc release

Ah I didn't see that error, that makes a lot more sense now.

Okay, so I came up with a fix for inochi stuff
This should go in the postConfigure of pkgs/applications/misc/inochi2d/generic.nix
inochi2d_dir=("$DUB_HOME"/packages/inochi2d/*/inochi2d)
patch -p1 -d "$inochi2d_dir" < ${./ldc-1.38.0-compat.patch}

Where ldc-1.38.0-compat.patch is the following:
diff --git a/source/inochi2d/core/nodes/drivers/package.d b/source/inochi2d/core/nodes/drivers/package.d
index 9a46846..01046b6 100644
--- a/source/inochi2d/core/nodes/drivers/package.d
+++ b/source/inochi2d/core/nodes/drivers/package.d
@@ -17,10 +17,8 @@ public import inochi2d.core.nodes.drivers.simplephysics;
 */
 @TypeId("Driver")
 abstract class Driver : Node {
-private:
-    this() { }
-
 protected:
+    this() { }
     /**
         Constructs a new Driver node
     */
diff --git a/source/inochi2d/core/nodes/package.d b/source/inochi2d/core/nodes/package.d
index 6090355..5045361 100644
--- a/source/inochi2d/core/nodes/package.d
+++ b/source/inochi2d/core/nodes/package.d
@@ -74,8 +74,6 @@ void inClearUUIDs() {
 @TypeId("Node")
 class Node : ISerializable {
 private:
-    this() { }
-
     @Ignore
     Puppet puppet_;

@@ -98,6 +96,8 @@ private:
     string nodePath_;

 protected:
+    this() { }
+
     bool preProcessed  = false;
     bool postProcessed = false;

Awesome thanks! I put it in a separate commit with you set as the author if that's alright.

I've found that the gtkd build failure is caused by the call substituteInPlace in the postFixup hook. substituteInPlace invokes chmod here and that's where it fails. Weird because this hasn't happened before...
I've tried reverting 9453650, which causes a new "cyclic reference" error.

I've found that the gtkd build failure is caused by the substituteInPlace call in the postFixup hook. substituteInPlace invokes chmod here and that's where it fails. Weird because this hasn't happened before...
I've tried reverting 9453650, which causes a new "cyclic reference" error.

What's weird is that I didn't have any issues compiling it. I'll try on my laptop as well, to see if that also works.

I wouldn't be surprised if it's only failing on my system, this setup has a bit pretty problematic in the past. So much for reproduciblity :\

Yeah the build succeeds on my NixOS box, I think this is good to go now.

By the way, you should probably remove the draft status.

Ah that's right. Thanks for all your help <3

By the way, what was/is the reason behind extracting the version and hash into a different file?
If it was a multi-versioned package it would be understandable, however it is not.

Good point, the dmd package does the same. I can change it back.

@lionello is there any reason for the package versions to be in separate files?

Now that https://github.com/NixOS/nixpkgs/pull/314953 is merged, the inochi patches can probably be dropped

Yep, everything builds now:
18 packages built:
Literate btdu cheesecutter dstep dtools dub gtkd inochi-creator inochi-session ldc luneta onedrive onedrivegui onedrivegui.dist rund sambamba serve-d tilix

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4038

Result of nixpkgs-review pr 293417 run on aarch64-linux 1

1 package marked as broken and skipped:

inochi-session

15 packages built:

Literate
btdu
dstep
dtools
dub
gtkd
inochi-creator
ldc
luneta
onedrive
onedrivegui
onedrivegui.dist
rund
serve-d
tilix

Result of nixpkgs-review pr 293417 run on aarch64-linux 1

1 package marked as broken and skipped:

inochi-session

15 packages built:

Literate
btdu
dstep
dtools
dub
gtkd
inochi-creator
ldc
luneta
onedrive
onedrivegui
onedrivegui.dist
rund
serve-d
tilix

I read something about aarch64 support being dropped for inochi, but thought it would be only for next major release.
One of the two was already failing for aarch64 so it was already marked as broken.
Perhaps the supported platforms should be narrowed instead. I'll look into it later.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4050

I read something about aarch64 support being dropped for inochi

Asahi Lina would never let that happen ;)

Thank you!


The latest version is not uploaded on NuGet

Hi, I checked the manual to install oneVPL, and I am trying it according this doc below.
https://www.intel.com/content/www/us/en/develop/documentation/installation-guide-for-intel-oneapi-toolkits-windows/top/installation/install-using-package-managers/nuget.html
But I noticed the latest version of the package have not been uploaded yet.
https://www.nuget.org/packages/onevpl.devel.win-x64
https://www.nuget.org/packages/onevpl.devel.linux-x64
I assume that NuGet hosting is not maintained frequently.
I would like to know the best way to install the oneVPL package. Should we check out from this repository?

Hi
Is where there is confusion. The packages on Nuget are published as part of Intel's OneAPI project which releases quarterly. The long release cycle allows many components to be tested together and published to a variety of locations.
This repo is directly managed by the OneVPL team and it is where we publish all of our regular releases. This includes the code that will be in OneAPI releases, as well as releases that will be packaged with graphics drivers, and any other public release.
If you want the latest OneVPL release please take the most recent release version tagged in this repository. The INSTALL.md file should provide instructions on building and installing OneVPL. If you have questions or problems following them please reach out here so we can help you, and improve our documentation.
I hope this helps.

All right. Thank you for explaing the detail.
I closed this issue.


SemanticKernel: Correcting non-standard way of working with PromptExecutionSettings

The extension of PromptExecutionSettings is not only for ChatCompletion, but also for text completion and text embedding.

Sorry for the list of commits. Until one is not merged it keeps listing all former ones... only the last commit is active here:
Correcting non-standard way of working with PromptExecutionSettings
ab8dd0d

If you work in a separate branch in your fork and then PR just that branch you won't get a messy commit log like that. For this one, we'll just make sure to squash-and-merge so it all becomes on commit :)


Control not loading in Google Chrome

The control was loading correctly last week.  It will now not load in Google Chrome.  It does load in Internet Explorer.

multivalue.js:21 Uncaught (in promise) Objectmessage: "n.forEach is not a function"name: "TypeError"stack: "TypeError: n.forEach is not a function↵    at https://cdn.vsassets.io/bundles/vss-bundle-async-vgrBFOTCnCQbqogxx_eDjPQBMql065ZSL-B4-Nb6M6U0=:9:5942"proto: Object

Same issue here as well.

I met the same issue today, Control is missing in Edge, but there is no issue in IE browser, when page first load in Google Chrome, on issue occurred, but then try reload the page I've got below exception:

Same issue here

Same issue here. We reset cookie and it works one time. But same problem after.
Thanks for your help

If I change something in the work item process settings, such as add or remove a field, it shows up for one refresh as well, then breaks again.

This is not just Chrome by the way, it behaves the same in all browsers including IE.

Confirmed I am seeing it in all browsers.  It just happened to work once in IE.

Thanks for letting us know. It doesnt look like an issue in the extension since we havent changed anything in it lately. So it looks like a bug in Azure devops product code. We are investigating and will send an update and an ETA for the fix soon

The issue should be fixed now.

Can anyone verify?

It is now fixed for me.  Thank you!

Working for us as well.

Thanks. Closing the issue.


Service crashes very easily with a tiny load

Hi, im currently testing ASR running with 2 units in serverless mode. A function handles the negotiation.
Connecting 300-500 clients over 10 seconds takes the service down 99% of the time. And if it was to handle all connections, alla clients gets disconnected after a minute, when they reconnect they take it down again.
Im running a simple console app to create the connections.
The errors im getting are
"SignalR connection failed to connect: Unable to connect to the server with any of the available transports. (WebSockets failed: The server returned status code '404' when status code '101' was expected.) (ServerSentEvents failed: Response status code does not indicate success: 404 (Not Found).) (LongPolling failed: Response status code does not indicate success: 404 (Not Found).)"
and
"SignalR connection failed to connect: Response status code does not indicate success: 503 (Service Temporarily Unavailable)."
My Function that handles negotiations barely even raises its cpu, and responds instantly on all requests.
tell me what you need to investigate in this issue.

To the left: My Console app
To The right: live from function that negotiates

@bentmar Can you send me your ResourceId and the issue happening time via email? I can get more details for you.

@zackliu thanks!

Already discussed in email. Close the issue.

It would be nice to know what the resolution to this was.

This is the only google result for the error. I too think that it would be nice to know something about the resolution.

there was no resolution from what i remember. I ended up handling negotiations and publishing messages on an app hosted in an app service plan.


updated redis scripts and reorganized them

Created new folder under scripts for Dynomite, Redis and Florida;
Moved scripts in the proper folder;
Changed the name of the new Redis scripts to depict the correct action;
Added new script for bgrewriteaof.

should the test scripts be moved as well to a test folder?


Add Swift PM Support

Description
Add support for the Swift Package Manager (Swift PM).
Notes

At the time of writing this ticket, Swift PM does not support explicitly including Apple modules as dependencies. This ticket should be blocked until we can specify both Foundation and UIKit.
Swift PM also does not support including resources, which we use for our localized violation strings. See SR-2866: Need a way to include resources with targets.

SR-2866: Need a way to include resources with targets is still an open issue with SwiftPM.

SR-2866: Need a way to include resources with targets is still an open issue with SwiftPM.

There is now a Draft Proposal: Package Resources for SwiftPM. Still early days though!


[TorchBench] Performance Signal Detected

TorchBench CI has detected a performance signal.
Affected Tests:

eval-cuda-fp32:

hf_Bert[dynamo-blade (latency)] 7.727 -> 6.719, +13.0452%
hf_Bert[dynamo-disc (latency)] 8.056 -> 6.862, +14.8213%

eval-cuda-fp16:

hf_Bert[dynamo-blade (latency)] 4.466 -> 3.207, +28.1908%
hf_Bert[dynamo-disc (latency)] 4.482 -> 3.335, +25.5913%

detail data can be seen in oss://bladedisc-ci/TorchBench/gpu/tiny/20230522-19
created by TorchBench CI automatically

Related to torch version changes, refer to https://github.com/alibaba/BladeDISC/pull/1150


Fix: Handle SSL failures

fixes #653

Codecov Report

Merging #654 (c5b273e) into main (1587237) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
- Coverage   58.60%   58.45%   -0.15%
==========================================
  Files          59       59
  Lines        1401     1401
  Branches       55       58       +3
==========================================
- Hits          821      819       -2
- Misses        580      582       +2

Impacted Files
Coverage Δ

...la/zhttp/service/client/ClientInboundHandler.scala
100.00% <100.00%> (+25.00%)
:arrow_up:

.../scala/zhttp/service/server/ServerSSLHandler.scala
16.66% <0.00%> (-66.67%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1587237...c5b273e. Read the comment docs.

🚀🚀🚀 Benchmark Results
Concurrency: 256
Requests/sec: 431224.84

🚀🚀🚀 Benchmark Results
Concurrency: 256
Requests/sec: 432370.46

🚀🚀🚀 Benchmark Results
Concurrency: 256
Requests/sec: 430425.47

Oh, nice! Would this possibly fix the failure on #645?

No this will fix the ignored test : fail with SSLHandshakeException when client doesn't have the server certificate


type is wrong This expression is not constructable

https://github.com/microsoft/TypeScript/issues/54166
just a quick fix
$ ln -rsf node_modules/magic-string/index.d.{ts,mts}

diff --git a/node_modules/magic-string/package.json b/node_modules/magic-string/package.json
index 42c2a99..3842bfe 100644
--- a/node_modules/magic-string/package.json
+++ b/node_modules/magic-string/package.json
@@ -19,7 +19,7 @@
   "exports": {
     "./package.json": "./package.json",
     ".": {
-      "types": "./index.d.ts",
+      "types": "./index.d.mts",
       "import": "./dist/magic-string.es.mjs",
       "require": "./dist/magic-string.cjs.js"
     }

@loynoir Did you try to replace the line export default class MagicString { by  export = class MagicString { ?
With commonjs, the current behavior maps the MagicString class to module.exports.default.
Using  export = instead of  export default will map the MagicString  class to module.exports.
You'll find a more detailed explanation of  the export = syntax here.


Fill in the blank type question?

Hi expert,
Is it possible to do some kind of fill in the blank type question?
e.g
I acting on behalf of _______ (your company name) to perform _______ (e.g. action)

@lewisw71 Unfortunately not.
Thank you,
Andrew


integrate peer.js distributed version with new UI

both are now separate folders inside `mobile-
once merged, it's enough to only have one folder
as a fallback, if the UI finds no peers we can also just let it do local training

done in #40 , except fall-back to local training if p2p is not available still needs some polishing as in #38


Fix #16

In reference to issue #16, I have fixed the issue of Content overflows.

In reference to issue #16, I have fixed the issue of Content overflows.

You should let the person who created the issue have a chance atleast :)


*.teams.microsoft.com and teams.microsoft.com out of date?

nslookup for shifts.teams.microsoft.com resolves to <IP_ADDRESS> which is not in *.teams.microsoft.com
teams.microsoft.com resolves to <IP_ADDRESS> which is not in teams.microsft.com above.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 077406d8-bff1-496e-3ea2-b38558fd9355
Version Independent ID: 57db3dec-2250-2dee-fd1a-ec6656911798
Content: Office 365 URLs and IP address ranges
Content Source: Enterprise/urls-and-ip-address-ranges.md
Service: o365-administration
GitHub Login: @JoeDavies-MSFT
Microsoft Alias: josephd

CLose this.


Regression: adapter-static build fails if url contains comma in srcset attribute on image tag

Describe the bug
When building with adapter-static, if the srcset attribute on an image tag contains a comma, the build fails trying to fetch not the external url pointing to the image but whatever follows the comma as an internal url.
This results in a 404 and the build failing.
Example:
not https://res.cloudinary.com/demo/image/upload/q_auto:best,w_864/sample.jpg is fetched but /w_864/sample.jpg
I am pretty sure this bug was introduced by #3288 , since it doesn't occur on 1.0.0-next.223 or lower and also seems to fit the changes.
Reproduction
Super simple reproduction of the problem: https://github.com/Theo-Steiner/crawling-external-srcset
Logs
https://app.warp.dev/block/kmoZl6fbECWcw8hKUKyzIp

System Info
System:
    OS: macOS 11.6
    CPU: (8) arm64 Apple M1
    Memory: 97.00 MB / 8.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.5.0 - /opt/homebrew/bin/node
    npm: 7.19.1 - /opt/homebrew/bin/npm
    Watchman: 4.9.0 - /opt/homebrew/bin/watchman
  Browsers:
    Chrome: 97.0.4692.71
    Firefox Developer Edition: 91.0
    Safari: 14.1.2
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.10
    @sveltejs/adapter-static: ^1.0.0-next.26 => 1.0.0-next.26
    @sveltejs/kit: next => 1.0.0-next.225
    svelte: ^3.44.0 => 3.46.0

Severity
blocking upgrade
Additional Information
Many image hosts use a comma in their URLs as an api for enumerating multiple transformations. Since commas are legal in URLs, we should fix this.

This could be fixed relatively easily by reverting (just) the logic for separating image candidates of a srcset back to how it was before #3288 . (https://github.com/sveltejs/kit/blob/984746649170f6619dff3751727464e16b918ee3/packages/kit/src/core/adapt/prerender/crawl.js)
...
} else if (name === 'srcset') {
  const candidates = value.split(',');
  for (const candidate of candidates) {
    const src = candidate.trim().split(WHITESPACE)[0];
    hrefs.push(src);
  }
}
...

^ this approach is sadly doesn't fit to the specifications of the srcset attribute:

If present, its value must consist of one or more image candidate strings, each separated from the next by a U+002C COMMA character (,). If an image candidate string contains no descriptors and no ASCII whitespace after the URL, the following image candidate string, if there is one, must begin with one or more ASCII whitespace.

} else if (name === 'srcset') {
const candidates = [];
  // Parse the content of the srcset attribute.
  // The regexp is modelled after the srcset specs (https://html.spec.whatwg.org/multipage/images.html#srcset-attribute)
  // and should cover most reasonable cases.
  const regex = /\s*([^\s,]\S+[^\s,])\s*((?:\d+w)|(?:-?\d+(?:\.\d+)?(?:[eE]-?\d+)?x))?/gm;
  let sub_matches;
  while ((sub_matches = regex.exec(value))) {
    candidates.push(sub_matches[1]);
  }
  for (const candidate of candidates) {
    hrefs.push(candidate);
  }
}

I am not sure if this should be how we proceed though, since @Rich-Harris explicitly named the issue "Crawl prerendered pages without regex hackery" and this would reintroduce a bunch of regex witchcraft.
Moreover, since according to the specification the meaning of a comma changes based on the preceding symbols, Regexes might be the wrong tool for this job altogether anyways, since this would render it an irregular language. (? I have no clue what I'm talking about here, if this is wrong please correct me) Maybe a State Machine would be the better tool for this?

@Rich-Harris is this really fixed?
I'm not sure if this is truly solved. Since upgrading from a beta version of SvelteKit, this code:
<img
    srcset="/order_thumbnail_400px.png,
            /order_thumbnail_800px.png 1.5x"
    src="/order_thumbnail_400px.png"
    alt={title} />

...will generate this error when building:

Error: Not found: /order_thumbnail_400px.png,/order_thumbnail_800px.png
at resolve (file:///C:/work/hublinwebsite/.svelte-kit/output/server/index.js:2711:18)
at resolve (file:///C:/work/hublinwebsite/.svelte-kit/output/server/index.js:2586:34)
at #options.hooks.handle (file:///C:/work/hublinwebsite/.svelte-kit/output/server/index.js:2755:59)
at respond (file:///C:/work/hublinwebsite/.svelte-kit/output/server/index.js:2584:43)
file:///C:/work/hublinwebsite/node_modules/@sveltejs/kit/src/core/postbuild/prerender.js:53
throw new Error(format(details));
^
Error: 404 /order_thumbnail_400px.png,/order_thumbnail_800px.png (linked from /)
at file:///C:/work/hublinwebsite/node_modules/@sveltejs/kit/src/core/postbuild/prerender.js:53:12
at save (file:///C:/work/hublinwebsite/node_modules/@sveltejs/kit/src/core/postbuild/prerender.js:355:4)
at visit (file:///C:/work/hublinwebsite/node_modules/@sveltejs/kit/src/core/postbuild/prerender.js:204:3)

Whereas if I leave out the srcset attribute:
<img src="/order_thumbnail_400px.png"
alt={title} />

...then it builds successfully.


incompatible with idea 2.2

Plugin Error
Problems found loading plugins:
The following plugins are incompatible with the current IDE build: .ignore

.ignore 2.0.4

IntelliJ IDEA 2017.2.2
Build #IU-172.3757.52, built on August 15, 2017
JRE: 1.8.0_152-release-915-b10 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Mac OS X 10.12.6

Duplicate of #408


How to configure settings from within Emacs?

I have a 'monorepo', a git repository containing multiple subdirectories, each with a project in a different programming language. One of them is an Elixir project.
LSP is complaining that it cannot find the mix-file in such a situation:

LSP :: No mixfile found in project. To use a subdirectory, set elixirLS.projectDir in your settings

The README talks about a settings.json but this seems to be VSCode-specific. I am using (Spac)emacs. Where should I create a settings.json? Or should this setting be set somewhere else when using Emacs?

Are you using lsp-mode? If so then then I would remove teh top-level directory from lsp-mode's project list, and initialize lsp-mode with the specific subdirectory (by pressing I to choose it interactively). I wrote a little bit on partially similar issue here: https://github.com/elixir-lsp/elixir-ls/issues/364#issuecomment-829589139

Thank you! Removing the project and re-initializing it interactively worked perfectly :blush:

Great! Glad to hear you got it all sorted out.


Revert "Simplify arithmetic operation in logical lines checker (#11346)"

Summary
I merged this, but I think it might not be the same behavior? See my comment at: https://github.com/astral-sh/ruff/pull/11346#discussion_r1594848224

Ya makes sense, sorry about that

Np.


[Feature Request] Switch to uv and ruff

Overview
Use uv as a package and project manager and ruff as a linter and code formatter.
Details

Replace Poetry with uv as the package and project manager since it's written in Rust and thus way faster.
Replace Black with ruff as a linter and code formatter since it's also written in Rust and way faster.
Update workflows to use uv and ruff

Why would this feature be useful?
To improve the speed for installing dependencies, and linting and formatting code.
Additional Notes
No response

yes 🤝


Add option to select steps with equal value

When SHIFT + a step key is double tapped, add all steps that have the same value (on the selected layer) as the selected key to the step selection. This allows to quickly select groups of "equal steps" for editing.

Will be part of 0.1.29 release.


Pruning Not Working in Pytorch

I am trying to use Optuna to tune some hyperparameters for a deepAR model. I'm using the DeepAREstimator published by gluonTS that uses pytorch (info here). Additionally, I have built the objective function according to the gluonTS tutorial (here).
I've done various tests, including some with 10 or 20 trials, and in none of my tests have any trials been pruned. Optuna appears to work in that trials are completed and hyperparameter values are returned. It's just that none of the trials are ever pruned.
I have tried two ways of getting pruning to work. In the first I use the pruner argument within create_study{}. I call the line of code to define 'pruner' before calling optuna.create_study().
pruner = optuna.pruners.MedianPruner()
study = optuna.create_study(direction = "minimize", pruner = pruner)

In the second, I use the optuna.integration.PyTorchLightningPruningCallback() in the objective function. It gets defined before the deepAREstimator and then the callback is used in the trainer_kwards{} argument, which passes onto the py.lighning trainer. I have also tried with both these approaches simultaneously.
class DeepARTuningObjective:
#... for brevity sake I'm excluding here everything in this class definition above def __call__, but you can find it in the link from above

def __call__(self, trial):
     params = self.get_params(trial)
     pruning_callback = optuna.integration.PyTorchLightningPruningCallback(trial, "val_loss")
     estimator = DeepAREstimator(

           #Basic Parameters
           freq = self.freq
           prediction_length = self.prediction_length,
           context_length = self.prediction_length,

           #Hyperparameters to be tuned
           num_layers  = params["num_layers"],
           hidden_size  = params["hidden_size"],
           lr = params["learning_rate"],
           weight_decay = params["weight_decay"],
           dropout_rate = params["dropout_rate"],
           batch_size = params["batch_size"],
           lags_seq = self.lag_options[params["lag_options_index"]],

           #Exogenous Variables
           num_feat_dynamic_real = self.valid_pickle.num_feat_dynamic_real,
           num_feat_static_cat   = self.valid_pickle.num_feat_static_cat,
           cardinality = self.valid_pickle.static_cardinalities.tolist(),

           #Additional call to pl.Trainer with hyperparameter to be tuned
           trainer_kwargs ={
               "max_epochs": params["max_epochs"]+1,
               "deterministic": True,
               "callbacks": [pruning_callback]
           },
         )
         predictor   = estimator.train(self.train, cache_data=True)
         forecast_it = predictor.predict(self.validation_input)
         forecasts   = list(forecast_it)
         evaluator   = Evaluator(quantiles=[0.1, 0.5, 0.9])
         agg_metrics, item_metrics = evaluator(
                self.validation_label, forecasts, num_series=len(self.valid_pickle)
         )
         return agg_metrics[self.metric_type] #else agg_metrics is a dict and code errors

Expected behavior
In calls to optimize() that have numerous trials, I would expect at least some trials to be pruned. Because I'm not seeing this I'm left wondering how to get pruning to work in this case.
If someone could troubleshoot this and/or tell me where I am going wrong, I would really appreciate it! I would very much like to be able to take advantage of the pruning functionality within optuna
Environment

Optuna version: 3.4.0
Python version: 3.11.5
OS: Windows 10 Enterprise
gluonTS version: 0.13.7
lighning version: 2.1.0
pytorch-lightning version: 2.1.0
torch version: 2.1.0

Steps to reproduce

Create the objective function as per the gluonTS tutorial. I replaced 'dataset' with 'valid_pickle' because I have my dataset saved as a pickle, and my prediction_length is 1, but otherwise it's basically the same.

Approach 1
2. In an interactive environment, create pruner() as shown above. Then create the study as shown above. Then call study.optimize() with n_trials >3
Approach 2
2. Modify the class from step 1. Create call_back as per the example code above. Pass a call to 'call_back' in trainer_kwards{} within the estimator
3. Create the study and call study.otpimize with n_trials >3

Since optuna/optuna#5068  is self-containing, let me close this one. Pruning & Pytorch (Possible Bug)


Support to skip corrupt journal entry when recovering from backup

Support to skip corrupt journal entry when recovering from backup, similar to the implementation in alluxio.master.journal.raft.BufferedJournalApplier#applyToMaster.
We can configure alluxio.master.journal.tolerate.corruption to control whether it is enabled or not.
Fix https://github.com/Alluxio/alluxio/issues/12959

Codecov Report

Merging #12958 (2c9f387) into master (797ece1) will decrease coverage by 12.65%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 797ece1...2c9f387. Read the comment docs.

@smallx
can you add the flag alluxio.master.skip.corrupted.journal.enabled into PropertyKey.java to enable this PR?

thanks @apc999
In HA mode, when recovering from backup file and there is a corrupt journal entry in backup file, both leader master and standby master will exit abnormally by default.
In alluxio.master.journal.raft.BufferedJournalApplier#applyToMaster, it is supported to control whether to skip the corrupt journal entry through flag alluxio.master.journal.tolerate.corruption when the standby master replaying journal.
This modification is used to support that the leader master can also skip the corrupt journal entry through flag alluxio.master.journal.tolerate.corruption when recovering from backup file.
I just updated the description of the flag alluxio.master.journal.tolerate.corruption.

alluxio-bot, merge this please

thanks @smallx  for your contribution!

@apc999 Does this PR a bug fix and need to be cherry-picked to branch-2.5?


Run Pipelines from Extension

Ability to run the pipelines from the extension. Use execa

fixed via #12


Add view for registering an order

This view may only take the POST method.

The OrderItems must be created from cookies
Customer from the session
price from the OrderItems
discount is zero as of now
date_submit from now()
table from Table.get_available_table()
is_approved be False

Then it should redirect to the order_list url

completed in #88


Segmentation Fault with coverage report on ARM instance

Describe the bug
In my cicd I implement some tests using pytest and coverage, when running on an ARM instance with python 3.7.3 and coverage 4.5.2 the cicd crashes with a Segmentation Fault.
To Reproduce
How can we reproduce the problem?  Please be specific. Don't link to a failing CI job. Answer the questions below:

What version of Python are you using?  3.7.3
What version of coverage.py shows the problem? The output of coverage debug sys is helpful. 4.5.2
What versions of what packages do you have installed? The output of pip freeze is helpful.

aiohttp==3.8.6
aiohttp-cors==0.7.0
aiosignal==1.3.1
amqp==2.6.1
argon2-cffi==19.1.0
asgiref==3.7.2
async-timeout==4.0.3
asynctest==0.13.0
atomicwrites==1.4.1
attrs==23.1.0
backports.zoneinfo==0.2.1
billiard==<IP_ADDRESS>
boto3==1.28.65
botocore==1.31.65
celery==4.4.7
certifi==2023.7.22
cffi==1.15.1
charset-normalizer==3.3.0
click==7.1.2
Collectfast==0.6.2
colorclass==2.2.2
colorlog==6.7.0
coreapi==2.3.3
coreschema==0.0.4
coverage==4.5.2
croniter==1.4.1
cryptography==41.0.4
datadog==0.29.3
ddtrace==0.49.1
decorator==5.1.1
defusedxml==0.7.1
diff-match-patch==20230430
Django==3.2
django-allauth==0.50.0
django-anymail==6.0.1
django-celery-beat==1.5.0
django-cors-headers==3.3.0
django-coverage-plugin==1.6.0
django-crispy-forms==1.14.0
django-debug-toolbar==3.2.4
django-easy-health-check==1.0.1
django-environ==0.4.5
django-extensions==2.1.9
django-filter==2.4.0
django-import-export==2.5.0
django-lrucache-backend==4.0.0
django-model-utils==3.2.0
django-redis==4.10.0
django-solo==1.1.5
django-storages==1.7.1
django-timezone-field==5.1
django-utils-six==2.0
djangorestframework==3.12.4
drf-yasg==1.20.0
entrypoints==0.3
et-xmlfile==1.1.0
factory-boy==2.11.1
Faker==0.9.1
faust==1.10.4
flake8==3.7.3
flower==0.9.5
freezegun==0.3.12
frozenlist==1.3.3
fuzzywuzzy==0.18.0
gevent==1.4.0
greenlet==0.4.16
gunicorn==19.9.0
httpretty==0.9.6
humanize==4.6.0
idna==3.4
importlib-metadata==4.13.0
inflection==0.5.1
itypes==1.2.0
Jinja2==3.1.2
jmespath==1.0.1
kafka-python==1.4.7
kombu==4.6.11
MarkupPy==1.14
MarkupSafe==2.1.3
mccabe==0.6.1
mixer==6.1.3
mode==4.3.2
more-itertools==9.1.0
multidict==6.0.4
mypy-extensions==1.0.0
ndg-httpsclient==0.5.1
oauthlib==3.2.2
odfpy==1.4.1
openpyxl==3.1.2
opentracing==1.3.0
packaging==23.2
Pillow==8.0.0
pluggy==0.13.1
pretend==1.0.9
prometheus-client==0.8.0
protobuf==4.24.4
psycopg2==2.8.3
pusher==2.1.4
py==1.11.0
pyasn1==0.5.0
pycodestyle==2.5.0
pycparser==2.21
pyflakes==2.1.1
PyJWT==2.8.0
PyNaCl==1.5.0
pyOpenSSL==23.2.0
pytest==5.2.0
pytest-cov==2.6.1
pytest-django==3.4.5
pytest-env==0.6.2
pytest-sugar==0.9.2
python-crontab==3.0.0
python-dateutil==2.8.2
python-Levenshtein==0.12.2
python-slugify==3.0.2
python3-openid==3.2.0
pytz==2019.1
PyYAML==6.0.1
redis==3.2.1
requests==2.31.0
requests-oauthlib==1.3.1
robinhood-aiokafka==1.1.6
ruamel.yaml==0.17.35
ruamel.yaml.clib==0.2.8
s3transfer==0.7.0
sentry-sdk==0.16.1
six==1.16.0
sqlparse==0.4.4
tablib==3.4.0
tenacity==8.2.3
termcolor==2.3.0
terminaltables==3.1.10
text-unidecode==1.2
tornado==6.2
typing_extensions==4.7.1
unicodecsv==0.14.1
uritemplate==4.1.1
urllib3==1.26.18
vcrpy==2.0.1
venusian==1.2.0
vine==1.3.0
wcwidth==0.2.8
wrapt==1.15.0
xlrd==2.0.1
xlwt==1.3.0
yarl==1.9.2
zipp==3.15.0

What code shows the problem?  Give us a specific commit of a specific repo that we can check out. If you've already worked around the problem, please provide a commit before that fix.
What commands should we run to reproduce the problem? Be specific. Include everything, even git clone, pip install, and so on. Explain like we're five! coverage report

Expected behavior
No Segmentation Fault
Additional context
Add any other context about the problem here.

I'm not sure how to help without details of the segfault.  Also, coverage.py 4.5.2 is almost five years old. Have you considered using a more recent version?

Closing as stale.


JSON Support : Investigate and update the conversion matrix used by smi and make sure that warning in the code is satisfied

Investigate and update the conversion matrix used by smi and make sure that this warning in the code is satisfied
https://github.com/dotnet/SqlClient/blob/0c4519871c9b69f7e05fe90f59d224d5f9ab3e3e/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Server/ValueUtilsSmi.cs#L2698-L2704
The CI runs on Release builds so the CI will not save you from violating assertions in this project.
You will probably need the sql server team to define the extensions to the conversion operations tables that start at https://github.com/dotnet/SqlClient/blob/0c4519871c9b69f7e05fe90f59d224d5f9ab3e3e/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Server/ValueUtilsSmi.cs#L2920
I suspect that json to binary might be the only conversion but someone needs to make that decision.
Originally posted by @Wraith2 in https://github.com/dotnet/SqlClient/issues/2722#issuecomment-2253665811

Given the plan to remove Context Connection and SMI related codebase in https://github.com/dotnet/SqlClient/issues/2838#issuecomment-2465838258, I believe this may no longer be applicable. Please reopen if needed.


[CU-86871rdah] Makes the HomeContentToggle sticky and visible in more places

Probably shouldn't show this arrow if there is no scrolling


Provide country codes with file list in datasets

Pain Point? Please describe.
The list of files returned with a dataset details request needs country codes for a new UI element.
Desired Solution
return country codes within the file details

Closed via #1833


The Great Event Refactor

This issue will serve as the hub of updates as I go through and correct our events in preparation for them to be mass implemented.
/**
 * The Sponge Event Structure is easy to understand if you think of base events as being
 * "sources".
 *
 * Their names are composed as Source|Action|Target.
 *
 * ie. BlockInteractEntityEvent is when a source (block) interacts (verb) a target (entity).
 *
 * Source: {@link org.spongepowered.api.block.BlockState} or "Block"
 * Action: Interact or some verb (Use, Break, etc)
 * Target: {@link org.spongepowered.api.entity.Entity} or "Entity"
 *
 */

@bloodmc
PlayerBreakBlockEvent vs. PlayerHarvestBlockEvent
In Forge, what is the difference between these two?


Optional callable args for and_then

Using the Do notation, I can have a series of functions called that do not accept arguments, and only return Result[None, str]. That's works great!
result: Result[None, str] = do(
    Ok(None)
    for a in my_object.prepare()
    for b in my_object.run()
    for c in my_object.cleanup()
)

If I want to use the and_then helper though, the op Result is always passed to the Callable.
For and_then to work for this case, I need to define a none: None = None parameter on every receiver.
Should it be possible to use and_then calls without passing an argument?
In Rust, it would look like:
let result = perform_action_one()
        .and_then(|_| perform_action_two())
        .and_then(|_| perform_action_three());

Haven't touched rust in a while, so someone can correct me if I'm mistaken here:
In that rust example you've given, the anonymous function passed to and_then is discarding (technically ignoring) the passed in value.
The direct translation into Python would look like,
result: Result[T, E] = (perform_action_one()  # replace T and E with actual types
    .and_then(lambda _: perform_action_two())
    .and_then(lambda _: perform_action_three())

Should it be possible to use and_then calls without passing an argument?

Could it be possible, yes. Should it? Not as it's currently defined. This matches the Rust API, which also gets the value, as well as Haskell' 'bind' operator (>>=). Hopefully I haven't confused myself and stated something incorrect, especially in regards to Haskell.
With do-notation you can however do something like this,
result = do(
    Ok(a)
    for a in run_a()
    for _ in run_b()
    for _ in run_c()
)

Which I believe matches the semantics of something like this in Haskell
do
   line <- run_a
   run_b
   run_c

In that rust example you've given, the anonymous function passed to and_then is discarding (technically ignoring) the passed in value.

Correct AFAIK

The direct translation into Python would look like,
result: Result[T, E] = (perform_action_one()  # replace T and E with actual types
    .and_then(lambda _: perform_action_two())
    .and_then(lambda _: perform_action_three())
)

Yep, this is what I would like to have available.

With do-notation you can however do something like this,
result = do(
    Ok(a)
    for a in run_a()
    for _ in run_b()
    for _ in run_c()
)

Yep, I can use this, I just find the and_then syntax clearer.


[Bug]: Menu options scroll beyond table/container/tabs/form widget area when scroll horizontally/Vertically

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior

Steps To Reproduce

Drag and drop a Table widget
Bind with query
Add a column with menu widget type
Add few options in menu widget
Now click on menu widget and open the option drop-down
Scroll the table data horizontally

Environment
Production
Version
Cloud

Amazing find 😆

@Tooluloope the suggested fix can be the following, but I think there can be a better suggestion.

Close the menu options when scrolling starts.
Contain the pop-up in the parent widget.

Please assign someone to investigate.

@techbhavin will find out if 2. is possible

Tested in Release. As per the fix (https://github.com/appsmithorg/appsmith/pull/12199), the behaviour is fine.
https://www.loom.com/share/33c5c15a2c5142dfab396cc8b81ac330
Only after the menu option is closed, scrolling is allowed.


feat: make entity not found page responsive

Hey, I just made a Pull Request!
The changes are around EntitytNotFound component

Make entity not found page responsive
Convert Illo.jsx to Illo.tsx
Give value to alt attribute of image using in Illo component
Add test case for EntityNotFound component

Screenshots
Before

After

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)

😍our mobile users love you 😬

That motivates me to make them more happy ⚡ ⚡ ⚡ ⚡ ⚡
Thank you


⚠ Fortnite has degraded performance

In f862eab, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1642 ms

Resolved: Fortnite performance has improved in d92e222.