Dynamic light fallback doesn't work

For GL drivers lacking a certain extension, there is a fallback implementation of dynamic lights, which can be tested by replacing the line in sdl_glimp.cpp
glConfig2.uniformBufferObjectAvailable = LOAD_EXTENSION_WITH_TEST( ExtFlag_CORE, ARB_uniform_buffer_object, r_arb_uniform_buffer_object->value );

with glConfig2.uniformBufferObjectAvailable = false.
However, this implementation produces no visible effect for me. It seems to be the same as setting /r_dynamicLight 0.

On Linux with Mesa drivers, it's expected to be possible to test the missing extension without modifying code, by using this environement variable:
export MESA_EXTENSION_OVERRIDE='-GL_ARB_uniform_buffer_object'

My suggestion to disable it by deleting a line was bad as it misses the part which sets shader defines. A right way to test with the extension disabled is /r_arb_uniform_buffer_object 0.
I found that in the 0.51 release, the fallback code path works correctly, but only if you have r_dynamicLight 1 (the deprecated option). As of the latest 0.52/sync (including #453), the fallback code is broken even if you try to use the deprecated rendering path with  /r_dynamicLight -1, so there's a regression there.

My commit turning deprecated renderer as -1 value was broken and then there was no way to re-enable the deprecated renderer.
This PR re-enables the deprecated renderer:

https://github.com/DaemonEngine/Daemon/pull/1045

Once the deprecated renderer is working again and enabled, setting r_arb_uniform_buffer_object to 0  makes a difference, the screen turn into black when there is a light in scene, meaning it uses an alternate code path but this code path is buggy.
If the fallback is only usable on the deprecated renderer, this is a good reason to keep the deprecated renderer as fallback itself.

If the fallback is only usable on the deprecated renderer, this is a good reason to keep the deprecated renderer as a fallback itself.

That fallback is meant to be a fallback for the tiled lighting renderer, so having the option messing with the legacy lighting renderer is very suspicious. That fallback is part of the tiled lighting renderer.
The GLSL define used to select fallback code path when ARB_uniform_buffer_object is missing or disabled was inconsistent, but cleaning things up in #1182 doesnt help:

https://github.com/DaemonEngine/Daemon/pull/1182

I propose just nuking that code-path. Virtually any hardware nowadays supports the extension, and ones that don't probably won't want to run with real-time lights enabled due to performance reasons.

Yeah nuke it

Fixed by NUKING the culprit with extreme prejudice in #1333.


Can command aliases "world" removed ? : /world command name conflict with essentialsx

ess has a /world command too, when use, it tp player. very handy, but by now due to name conflict i have to set false permission of /ess:world for my player, force them to use /world rejoin <world_name>
can the code in myworlds be changed to register command in a different name? like /mw <create|rejoin|...> .
i can do a pr if your say yes but dont have time, just pure string replace after all.

But /mw alias should already exist

But /mw alias should already exist

sorry,now it should looks meaningful

@bergerkiller   rename "world" to "worlds" solve my problem,too. And I thought it would make more sense.
Player can teleport to a "world" , and then manage "worlds".

@bergerkiller  rename "world" to "worlds" solve my problem,too. And I thought it would make more sense.
Player can teleport to a "world" , and then manage "worlds".

Well I cant really go change that and get rid of /world as it would break it for people. In general I recommend people stick with /mw to avoid ess-ex conflicts

to people who came here, luckily in this paricular case , a (not) perfect solution easier(?) than fork and compile plugin do exists
you can disable or rename /world by modify plugin.yml,which remain the same after compile,
so you can

unzip the jar file
modify plugin.yml ,rename every node contain world to worlds
zip it back (without compress)

after this tab complete will still confronting, however thx/due to how myworlds tab complete is written by now,when taping "\world ",only essx 's tab completing will responding
problem sovled , BUT

myworlds "short" command (gen diff i ...) completion got messd up
when update ,you need do again.

hope this helps


CSHARP-2875: Fix race condition in TestStreamFactory CreateStream method.

Evergreen patch build:
https://evergreen.mongodb.com/version/5dfa9a1657e85a2f1ca0e8ff

I'm postponing further work on this pull request until we close:
https://github.com/rstam/mongo-csharp-driver/pull/137
to avoid discussing similar issues in two places.

Ready for re-review.

I'm actually concerned that the refactoring has introduced bugs. I have to keep thinking about this.
Are you sure you want these kind of changes made?

The bug I'm concerned about is that we won't necessarily always end up in the catch clause.
I'll refactor again.

Ready for re-review.

Ready for re-review.

New Evergreen patch build:
https://evergreen.mongodb.com/version/5e18e5ef0305b93d3106a147

Squashed, rebased and merge to master.


Error failed to fetch http://deb.debian.org/debian/dists/jessie/InRelease

Hi,
since yesterday 14.12. I cannot build any of my docker build files FROM jessie:latest anymore (which were just fine previously), as they always exit with the below. It seems quite independent of the packages I try to apt-get. I checked the net which suggests looking into DNS, VPN, firewall ... but I have neither changed anything, nor am I running VPN or a firewall.
Is it possible that the issue is due to DSA-3733-1 apt -- security update
If so could you please update the jessie:latest image or help me understand how I can fix it myself?
Step 2 : RUN apt-get update     && apt-get install -y --no-install-recommends           bzip2           ca-certificates                 libffi-dev              libgdbm3 libssl-dev              libyaml-dev             procps          zlib1g-dev      && rm -rf /var/lib/apt/lists/*
 ---> Running in c88dd90c6d06
Err http://deb.debian.org jessie InRelease

Err http://security.debian.org jessie/updates InRelease

Err http://deb.debian.org jessie-updates InRelease

Err http://security.debian.org jessie/updates Release.gpg
  Could not resolve 'security.debian.org'
Err http://deb.debian.org jessie Release.gpg
  Could not resolve 'deb.debian.org'
Err http://deb.debian.org jessie-updates Release.gpg
  Could not resolve 'deb.debian.org'
Reading package lists...
W: Failed to fetch http://deb.debian.org/debian/dists/jessie/InRelease

W: Failed to fetch http://deb.debian.org/debian/dists/jessie-updates/InRelease

W: Failed to fetch http://security.debian.org/dists/jessie/updates/InRelease

W: Failed to fetch http://deb.debian.org/debian/dists/jessie/Release.gpg  Could not resolve 'deb.debian.org'

W: Failed to fetch http://security.debian.org/dists/jessie/updates/Release.gpg  Could not resolve 'security.debian.org'

W: Failed to fetch http://deb.debian.org/debian/dists/jessie-updates/Release.gpg  Could not resolve 'deb.debian.org'

W: Some index files failed to download. They have been ignored, or old ones used instead.
Reading package lists...
Building dependency tree...
Reading state information...
Package bzip2 is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Package 'bzip2' has no installation candidate
E: Unable to locate package ca-certificates
E: Unable to locate package libffi-dev
E: Unable to locate package libgdbm3
E: Unable to locate package libssl-dev
E: Unable to locate package libyaml-dev
E: Unable to locate package zlib1g-dev
ERROR: Service 'ruby' failed to build: The command '/bin/sh -c apt-get update   && apt-get install -y --no-install-recommends           bzip2           ca-certificates libffi-dev               libgdbm3                libssl-dev              libyaml-dev             procps          zlib1g-dev      && rm -rf /var/lib/apt/lists/*' returned a non-zero code: 100

That really looks like a networking problem. "could not resolve" points to not getting a DNS response.  Can you ping an IP from a container?  What about a host like "google.com" or "security.debian.org"?  Perhaps you need to restart docker or the VM/machine it is running on?

i did the following without any error messages (restarted fine and pulled images)

sudo /etc/init.d/docker restart

 sudo docker pull debian:8.6

sudo powerdown -P now

hardware restart

but as soon as I start building on the pulled image, I get the above errors.
I did also try as @yosifkit suggested. It works perfectly fine directly from my machine, but it just returns with ping: unknown host when used from within a docker container.
Yet the docker image is an nginx server with PHP and my pages running on that server are reachable from the outside without any issues. Any other suggestion for me to try?
Now remembering, I did have a "no local networks" error a day or two back, where I read that I have to delete a few unused networks sudo docker network ls. Could I have screwed something up? And if so any suggestions how to get it up and running again? It now has a bridge, host, none, data_default and various of my own build names.

Found an article on /etc/default/docker and had some strange stuff in there. After correcting that I am up and running. Thank you for your time!


Snippets sorting order first variables, then methods in classes

I wonder if it is possible to change the order of displayed elements in snippet.
By default, they are sorted by name ascending.
It would be easier if they were sorted first by type, then alphabetically.
First the attributes of the object, and then the methods.
Thanks

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

Unless it is possible to change the sorting method by writing a module that would enable it? Then I could write it.

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


About Datasets and Utterance Feature

Hello.
I noticed that there were many files like dev_data_roberta.json.feature. How can I construct these Utterance Feature by myself？
Thank you so much.

I think you can use json.dump() to generate this feature file.


Add DomU and fix ATF

This patch series enables back DomU build, fixes ARM trusted firmware, so it don't interfere with Xen operation and enables back all 4 cores + OP-TEE.

Reviewed-by: Oleksandr Andrushchenko<EMAIL_ADDRESS>with the nit fixed in the commit message


Deleted emails prevent other emails from showing up (using IMAP)

I'm sorry for the convoluted explanation :)
I'm using K9-Mail to read my emails on my own mailserver, with IMAP. I have the app configured to show the last 10 emails (Local folder size = 10 messages, Sync messages from = any time).
When I delete one or more emails from a folder (INBOX, or other folders), the emails disappear from the list, but the number of emails seens does not equal to 10 anymore, no matter how many times I press refresh. Only after I do an "Expunge" and then press Sync, I'm getting the list populated with 10 emails.
Expected behavior
After deleting the emails, the list should populate with other emails, up to the set limit (10 in my case). You should not have to expunge first.
Actual behavior
There are only 10-X emails shown (where X is the number of deleted emails)
Steps to reproduce

see 10 emails in Inbox (say email1, email2, ... email10)
delete 2 emails (say email5 and email6)
now you see email1,2,3,4,7,8,9,10 (8 emails)
you need to "Expunge" the deleted emails if you want to see 10 emails

This is especially annoying when you have say a lot of automated emails coming in. Say you get 20 emails, from which only the latest 10 are shown. You delete these 10, they disappear from the list and now the list is empty, and you have to expunge these 10 deleted ones first, before seeing the next 10.
The deleted emails are not really deleted, they are just marked as deleted on the server (checking with Thunderbird there are clearly there), but they occupy "slots" from the list of 10 emails but they are not shown anymore.
Environment
K-9 Mail version: 5.403
Android version: 8.0.0
Account type (IMAP, POP3, WebDAV/Exchange): IMAP
Thank you for a great app, I'm really loving it!

I had the same experience on the same version of K-9 mail with a Dovecot-hosted inbox, on Android 7.1.

I have version 5.600 and don't see an option to manipulate the "deleted" flag.  I would like to expand on the expected behavior stated above.
Expected Behavior:
If "Hide Deleted Messages" is toggled on, then K9 should continue to download headers until it can populate the list with visible headers up to the set limit or there are no more messages on the server.
If "Hide Deleted Messages" is toggled off, then K9 should populate the list as it does now but with the messages visible along with an indication that the "deleted" flag is set.
Thank you for the best Android email application.

Being able to mark a message as deleted and then undelete it is an IMAP oddity that we are unlikely to add support for. It's also what's causing the issue described by the OP.
You should set 'Account settings > Fetching mail > Erase deleted messages on server' to 'Immediately' to avoid having to manually expunge messages.
We have plans to change sync to be more reliable/predictable when loading more messages. See #1327

I'm reading my emails on my desktop, and my phone, and ocasional also through webmail. I don't want to expunge immediately, because it can happen that I delete an email by accident on the phone, it's very easy, and I like the option to bring it back (on the desktop for example).
I don't necessarily want to undelete it with K9, that's OK that that's not supported, I just wish it would ignore marked messages, and load the rest, without counting deleted ones towards the limit of 10, 25, whatever.
Thanks for a really great app!
-------- Original Message --------
From: cketti<EMAIL_ADDRESS>Sent: March 1, 2019 4:50:38 PM GMT+02:00
To: k9mail/k-9<EMAIL_ADDRESS>Cc: gergelyimre<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [k9mail/k-9] Deleted emails prevent other emails from showing up (using IMAP) (#3561)
Being able to mark a message as deleted and then undelete it is an IMAP oddity that we are unlikely to add support for. It's also what's causing the issue described by the OP.
You should set 'Account settings > Fetching mail > Erase deleted messages on server' to 'Immediately' to avoid having to manually expunge messages.
We have plans to change sync to be more reliable/predictable when loading more messages. See #1327
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/k9mail/k-9/issues/3561#issuecomment-468689709
http://havaz.net
gpg --keyserver subkeys.pgp.net --recv-keys 0x34525305


functional-tester: add short lived leases checking

lease stresser now generates short lived leases that will expire before invariant checking.
this addition verifies that the expired leases are indeed being deleted on the sever side.

Let's keep this pending until we figure out why the current lease testing failing?

@xiang90 will do

One question. Other than that LGTM

LGTM


HHH-18150 Fix for Informix float and double precision in decimal digits

I propose using float precision 8 since the documentation smallfoat documentation states that the SMALLFLOAT data type stores single-precision floating-point numbers with approximately nine significant digits.

https://hibernate.atlassian.net/browse/HHH-18150

Have you tested this?

Have you tested this?

Yes, with Informix 14 and Informix 11

OK, great, LGTM, thanks.

A much simpler solution would be to change the registration from CapacityDependentDdlType.builder( FLOAT, "float($p)", this ) to CapacityDependentDdlType.builder( FLOAT, "float", this ) since the documentation clearly states that the precision is ignored anyway.

A much simpler solution would be to change the registration from CapacityDependentDdlType.builder( FLOAT, "float($p)", this ) to CapacityDependentDdlType.builder( FLOAT, "float", this ) since the documentation clearly states that the precision is ignored anyway.

I think the point is that smallfloat -> single precision, float -> double precision.
I don't think small float is the same type as float.

A much simpler solution would be to change the registration from CapacityDependentDdlType.builder( FLOAT, "float($p)", this ) to CapacityDependentDdlType.builder( FLOAT, "float", this ) since the documentation clearly states that the precision is ignored anyway.

I think the point is that smallfloat -> single precision, float -> double precision.
I don't think small float is the same type as float.

Correct, but I didn't doubt this, so not sure what you mean.
AFAIU, the users problem is that we currently pass binary digits as precision value when creating DDL for double precision and produce e.g. float(52). According to the docs, this is invalid, because the value range is 1 - 14 which I guess stands for decimal digits. Ultimately, it's not worth bothering though, because the docs say the DB ignores the value passed, and the DDL type float always means 8 byte floating point number, hence my suggestion to just remove the ($p) from the registration.

We could do the same simplification for e.g. PostgreSQL since the parametrizations of float are essentially just aliases as well according to its documentation.

What I'm saying is that we should produce smallfloat when the requested precision is InformixDialect.getFloatPrecision(), and float when it is InformixDialect.getDoublePrecision().
Otherwise we will be unnecessarily creating float columns when smallfloat columns would suffice.

Actually perhaps you were merely suggesting to just change that one line of the fix, and leave everything else the same. If that's the case, I agree.
It sounded like you were suggesting that one-line change as an alternative simpler solution instead of the whole patch. But I probably misunderstood your comment.

It sounded like you were suggesting that one-line change as an alternative simpler solution instead of the whole patch. But I probably misunderstood your comment.

I am suggesting to that instead. The PR as it is right now will emit float(16) for double, which will also fail according to the docs, because the maximum allowed value for this database is 14. The thing is, why not just drop the value since it has no meaning anyway as long as it is in range?

The documentation states a range of 1-14, but the error message says "Maximum precision value for FLOAT data type must be between 1 and 16." I have tested that an error occurs even at 17.

Please rebase the PR, then we can merge it.

Please rebase the PR, then we can merge it.

I've done a rebase, can you merge it?

Thanks, @VladoKuruc!


[Bug] Customized cost function

I'm using Ansor to tune kernels, but I want to customize some policies to generate the kernels I want. How should I modify the cost function, or which part of the code does it correspond to?

Please use https://discuss.tvm.apache.org/


Bulk creation/deletion of groups

Added support for bulk creation/deletion which was added in Apollo https://github.com/GMOD/Apollo/pull/2130
I think we could release the 3.1 version after that, I'm done with what I wanted to do (though this patch won't work with Apollo < not-yet-released-2.4)

Guess it raises a philosophical issue, do we want to support older apollos as well? In which case I'd say move into a separate function. Or do we just have the energy/time to support recent versions?

oops, forgot about this PR!
I'm tempted to say "we just have the energy/time to support recent versions". In this case it's not breaking something that worked with older apollo, it's just new options that won't be understood by older apollo


Dedicated requirements.txt  for the examples

It will alleviate the installation process.

I agree that creating a dedicated requirements.txt file for the examples would alleviate the installation process. #58


Updated configuration for BOLT

HI @metaflow ,
I created an initial configuration based on the discussion around supporting BOLT in #364. Can you please take a look if that covers all the changes we need?
Re-deploying the Debian docker image (with the additional library) is optional.
Thx,
Christian

I will try to rebuild docker with an updated image.
Note that at the moment we will NOT be running bolt checks. I will add this separately.

I'm not sure but I think this may be causing an error when submitting patches on Phabricator ?
Im getting an error:
https://buildkite.com/llvm-project/premerge-checks/builds/70409#acbd9cab-3a33-42bd-9e24-aeb485181552
CMake Error at CMakeLists.txt:76 (MESSAGE):
--
  | bolt isn't a known project:
  | clang;clang-tools-extra;compiler-rt;cross-project-tests;libc;libclc;libcxx;libcxxabi;libunwind;lld;lldb;mlir;openmp;polly;pstl;flang
  |

@malharjajoo Sorry for that, I have not realized that previous patch would cause failures if BOLT has not landed yet. Reverted.

Hi @malharjajoo ,
yes, you're right, this patch broke the build as BOLT has not yet landed in the monorepo. It's planned to land end of the week and we were preparing the pre-merge testing already.
I just reverted the patch.
@metaflow
Can you please re-submit the changes once BOLT has landed?

Thank you !


Baseline in Text-to-Code task

Text-to-Code reports 2 results (i.e. CodeGPT, and CodeGPT-adapted). Can you give me details (or refer me to the relevant description) of these two models?
The information that I want to know about these models

Are these the original GPT model adapted for the code? Is there any architectural changes from the GPT?
How are these models pretrained?
What is the difference between CodeGPT and CodeGPT-adapted?

Thanks in advance.

Hi, thanks for your attention.
Here is the introduction to CodeGPT and CodeGPT-adapted. You can refer to it for details.
The answers to your questions:

The model architecture is as same as GPT-2 (12 layers). CodeGPT-adapted is the original GPT model adapted for the code while CodeGPT is trained from scratch.
They are pre-trained on Java and Python corpus from CodeSearchNet dataset. The training object is also same as GPT-2, i.e. casual language model. And they are both monolingual models.
The difference between the two models is that CodeGPT is pre-trained from scratch, in a way that the BPE (byte pair encoder) vocabulary is newly obtained on code corpus and that model parameters are randomly initialized. CodeGPT-adapted is a domain-adaptive one, which uses GPT-2 model as the starting point and is continually trained on code corpus.

CodeGPT and CodeGPT-adapted models are available here. Model names are CodeGPT-small-py, CodeGPT-small-java, CodeGPT-small-py-adaptedGPT2, CodeGPT-small-java-adaptedGPT2. And you could easily try it by huggingface transformers.

Thanks for your reply, appreciate it.


Add gxhash in bench

Not meant to be merged

#487

:umbrella: The latest upstream changes (presumably #554) made this pull request unmergeable. Please resolve the merge conflicts.


Logitech G502 proteus spectrum no lighting effects

I have a razer blackwidow chroma, razer firefly, logitech g633 headset and logitech G502 proteus spectrum mouse. When i open aurora to unify the lighting every device but the mouse will change. The mouse itself stays with whatever profile was selected withing the logitech software. Is there some way to have the software change the lighting on my mouse?

Nevermind, upon uninstalling and reinstalling the logitech gaming software it has fixed itself. Epic program btw keep up the awesome work :)


Containers sharing --net should take their DNS configuration from dependency

Is this a BUG REPORT or FEATURE REQUEST?:
Bug
Description
If I start two containers in Docker, one with custom DNS, the second using that container's network namespace, the second container will also share the first container's DNS config. The same is not true of Podman.
Further, Docker also makes DNS configuration conflict with network namespace sharing. I don't think this is a hard requirement in our case, but it might make things easier to understand.
Steps to reproduce the issue:

Terminal 1: podman run -t -i --rm --name test --dns <IP_ADDRESS> fedora bash

Terminal 2: podman run -t -i --rm --net container:test fedora bash

Terminal 2: cat /etc/resolv.conf

Describe the results you received:
Same resolv.conf as any other container - same nameservers as the host
Describe the results you expected:
Resolv.conf from the first container - only one nameserver, <IP_ADDRESS>
Additional information you deem important (e.g. issue happens only occasionally):
Output of podman version:
Latest master

@mheon, can you provide a reproducer for Docker? I don't seem able to find one.


Refine prompt informing users of errors

Use a warning as some issues may be transient. Also suggest
checking settings as we've seen some issues are due to
misconfiguration of the extension. Lastly, direct users to a
search of existing issues with the same error message to
discourage filing duplicates.
Example:

Generally, LGTM.
One suggestion would be to narrow down the relevant settings for that specific error with more filter terms if possible.  I'm thinking something like this:

Also as an FYI, I was having trouble getting openInEditor working in Canary.  Getting this error:

Uncaught (in promise) TypeError: Failed to fetch dynamically imported module<EMAIL_ADDRESS>Could you see if you're hitting this as well?

I'd like to hold-off on error-specific scoped settings search for now. Not sure the incremental gain is worth the additional work at the moment (curious to see if folks have trouble finding the correct settings once we put this out there).


upgrade grafana to  latest version

Organization Name:

Short summary about the issue/question:
Brief what process you are following:

How to reproduce it:

OpenPAI Environment:

OpenPAI version:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Hardware (e.g. core number, memory size, storage size, GPU type etc.):
Others:

Anything else we need to know:

@satoshinakamora1995 - the issue does not have any detail info about the problem or ask or background, I'm closing it for now. May you add more info and reopen it? thanks.


fix typo

Why:

What's being changed:

Check off the following:

[ ] All of the tests are passing.
[ ] I have reviewed my changes in staging.
[ ] For content changes, I have reviewed the localization checklist
[ ] For content changes, I have reviewed the Content style guide for GitHub Docs.

@petemounce - thanks so much for helping us improve our docs, and for spotting and correcting this typo 😱 🎉

Think this was part of #733


Can't change endpoint name - error

Error after click on "Update endpoint" button

Hi @Haxy89
Can you share the logs of the Portainer container with us?

Hi @deviantony
I will attach logs and more info later today :)

@deviantony
Log:
2018/08/07 14:52:57 http error: Unable to register HTTP proxy for the endpoint (err=open /data/tls/1/cert.pem: no such file or directory) (code=500)
Portainer run command:
sudo docker run -d -p 9000:9000 --name Portainer --restart always  -v /home/pi/portainer/certs:/certs -v /home/pi/portainer/data:/data portainer/portainer  -H tcp://<IP_ADDRESS>:2376 --tlsverify
Certs are in /home/pi/portainer/certs but after I checked /data/tls folder is empty so this is why error occurs.

Thanks for the information, it seems that to reproduce the bug we should follow these instructions:

Create a TLS secured endpoint via the -H and --tls* flags.
Update the endpoint via the UI

@deviantony
I think problem is in this part:

Update endpoint action sends null values in certs paths:

Still occurs in newest Portainer.
Can anyone take care of it?
Thanks

Unable to reproduce on 1.23.2

Haha two years...

Yes I went through the backlog of unconfirmed and tried to reproduce as much as I could :laughing:


RuntimeError: Cuda Out of Memory

Hi, when I run the demo, I get the following error message: RuntimeError: CUDA out of memory. Tried to allocate 20.00 MiB.
After looking up this error online, I've tried reducing the batch size from the command line and added "torch.cuda.empty_cache()" to my code. However, I don't think the second solution would work because my device simply doesn't have enough GPU storage.
I was wondering if anyone else has had this error, and if so, whether they've found some sort of fix.

What is the available GPU memory you have?
We recently updated the option for body detection in the demo (body_detector argument). When you use the option regnety, the code should run with less than 7GB of GPU memory. You might observe some small drop in accuracy when it comes to the hand detection aspect.

I am running into a similar OOM error trying to run demo on an Ubuntu desktop with ~8GB of GPU memory. I am using a conda environment with python 3.10, pytorch 2.2.0, and cuda 11.8. I have tried reducing the batch size down to 1 and enabling regnety without success. Below is the error log:
(vitpose) katmai@ARVR-lab1:~/Desktop/hamer$ python demo.py --img_folder example_data --out_folder demo_out --batch_size=1
/home/katmai/anaconda3/envs/vitpose/lib/python3.10/site-packages/mmcv/cnn/bricks/transformer.py:27: UserWarning: Fail to import ``MultiScaleDeformableAttention`` from ``mmcv.ops.multi_scale_deform_attn``, You should install ``mmcv-full`` if you need this module.
  warnings.warn('Fail to import ``MultiScaleDeformableAttention`` from '
WARNING: You are using a MANO model, with only 10 shape coefficients.
Use load_from_local loader
The model and loaded state dict do not match exactly

unexpected key in source state_dict: backbone.blocks.0.mlp.experts.0.weight, backbone.blocks.0.mlp.experts.0.bias, backbone.blocks.0.mlp.experts.1.weight, backbone.blocks.0.mlp.experts.1.bias, backbone.blocks.0.mlp.experts.2.weight, backbone.blocks.0.mlp.experts.2.bias, backbone.blocks.0.mlp.experts.3.weight, backbone.blocks.0.mlp.experts.3.bias, backbone.blocks.0.mlp.experts.4.weight, backbone.blocks.0.mlp.experts.4.bias, backbone.blocks.0.mlp.experts.5.weight, backbone.blocks.0.mlp.experts.5.bias, backbone.blocks.1.mlp.experts.0.weight, backbone.blocks.1.mlp.experts.0.bias, backbone.blocks.1.mlp.experts.1.weight, backbone.blocks.1.mlp.experts.1.bias, backbone.blocks.1.mlp.experts.2.weight, backbone.blocks.1.mlp.experts.2.bias, backbone.blocks.1.mlp.experts.3.weight, backbone.blocks.1.mlp.experts.3.bias, backbone.blocks.1.mlp.experts.4.weight, backbone.blocks.1.mlp.experts.4.bias, backbone.blocks.1.mlp.experts.5.weight, backbone.blocks.1.mlp.experts.5.bias, backbone.blocks.2.mlp.experts.0.weight, backbone.blocks.2.mlp.experts.0.bias, backbone.blocks.2.mlp.experts.1.weight, backbone.blocks.2.mlp.experts.1.bias, backbone.blocks.2.mlp.experts.2.weight, backbone.blocks.2.mlp.experts.2.bias, backbone.blocks.2.mlp.experts.3.weight, backbone.blocks.2.mlp.experts.3.bias, backbone.blocks.2.mlp.experts.4.weight, backbone.blocks.2.mlp.experts.4.bias, backbone.blocks.2.mlp.experts.5.weight, backbone.blocks.2.mlp.experts.5.bias, backbone.blocks.3.mlp.experts.0.weight, backbone.blocks.3.mlp.experts.0.bias, backbone.blocks.3.mlp.experts.1.weight, backbone.blocks.3.mlp.experts.1.bias, backbone.blocks.3.mlp.experts.2.weight, backbone.blocks.3.mlp.experts.2.bias, backbone.blocks.3.mlp.experts.3.weight, backbone.blocks.3.mlp.experts.3.bias, backbone.blocks.3.mlp.experts.4.weight, backbone.blocks.3.mlp.experts.4.bias, backbone.blocks.3.mlp.experts.5.weight, backbone.blocks.3.mlp.experts.5.bias, backbone.blocks.4.mlp.experts.0.weight, backbone.blocks.4.mlp.experts.0.bias, backbone.blocks.4.mlp.experts.1.weight, backbone.blocks.4.mlp.experts.1.bias, backbone.blocks.4.mlp.experts.2.weight, backbone.blocks.4.mlp.experts.2.bias, backbone.blocks.4.mlp.experts.3.weight, backbone.blocks.4.mlp.experts.3.bias, backbone.blocks.4.mlp.experts.4.weight, backbone.blocks.4.mlp.experts.4.bias, backbone.blocks.4.mlp.experts.5.weight, backbone.blocks.4.mlp.experts.5.bias, backbone.blocks.5.mlp.experts.0.weight, backbone.blocks.5.mlp.experts.0.bias, backbone.blocks.5.mlp.experts.1.weight, backbone.blocks.5.mlp.experts.1.bias, backbone.blocks.5.mlp.experts.2.weight, backbone.blocks.5.mlp.experts.2.bias, backbone.blocks.5.mlp.experts.3.weight, backbone.blocks.5.mlp.experts.3.bias, backbone.blocks.5.mlp.experts.4.weight, backbone.blocks.5.mlp.experts.4.bias, backbone.blocks.5.mlp.experts.5.weight, backbone.blocks.5.mlp.experts.5.bias, backbone.blocks.6.mlp.experts.0.weight, backbone.blocks.6.mlp.experts.0.bias, backbone.blocks.6.mlp.experts.1.weight, backbone.blocks.6.mlp.experts.1.bias, backbone.blocks.6.mlp.experts.2.weight, backbone.blocks.6.mlp.experts.2.bias, backbone.blocks.6.mlp.experts.3.weight, backbone.blocks.6.mlp.experts.3.bias, backbone.blocks.6.mlp.experts.4.weight, backbone.blocks.6.mlp.experts.4.bias, backbone.blocks.6.mlp.experts.5.weight, backbone.blocks.6.mlp.experts.5.bias, backbone.blocks.7.mlp.experts.0.weight, backbone.blocks.7.mlp.experts.0.bias, backbone.blocks.7.mlp.experts.1.weight, backbone.blocks.7.mlp.experts.1.bias, backbone.blocks.7.mlp.experts.2.weight, backbone.blocks.7.mlp.experts.2.bias, backbone.blocks.7.mlp.experts.3.weight, backbone.blocks.7.mlp.experts.3.bias, backbone.blocks.7.mlp.experts.4.weight, backbone.blocks.7.mlp.experts.4.bias, backbone.blocks.7.mlp.experts.5.weight, backbone.blocks.7.mlp.experts.5.bias, backbone.blocks.8.mlp.experts.0.weight, backbone.blocks.8.mlp.experts.0.bias, backbone.blocks.8.mlp.experts.1.weight, backbone.blocks.8.mlp.experts.1.bias, backbone.blocks.8.mlp.experts.2.weight, backbone.blocks.8.mlp.experts.2.bias, backbone.blocks.8.mlp.experts.3.weight, backbone.blocks.8.mlp.experts.3.bias, backbone.blocks.8.mlp.experts.4.weight, backbone.blocks.8.mlp.experts.4.bias, backbone.blocks.8.mlp.experts.5.weight, backbone.blocks.8.mlp.experts.5.bias, backbone.blocks.9.mlp.experts.0.weight, backbone.blocks.9.mlp.experts.0.bias, backbone.blocks.9.mlp.experts.1.weight, backbone.blocks.9.mlp.experts.1.bias, backbone.blocks.9.mlp.experts.2.weight, backbone.blocks.9.mlp.experts.2.bias, backbone.blocks.9.mlp.experts.3.weight, backbone.blocks.9.mlp.experts.3.bias, backbone.blocks.9.mlp.experts.4.weight, backbone.blocks.9.mlp.experts.4.bias, backbone.blocks.9.mlp.experts.5.weight, backbone.blocks.9.mlp.experts.5.bias, backbone.blocks.10.mlp.experts.0.weight, backbone.blocks.10.mlp.experts.0.bias, backbone.blocks.10.mlp.experts.1.weight, backbone.blocks.10.mlp.experts.1.bias, backbone.blocks.10.mlp.experts.2.weight, backbone.blocks.10.mlp.experts.2.bias, backbone.blocks.10.mlp.experts.3.weight, backbone.blocks.10.mlp.experts.3.bias, backbone.blocks.10.mlp.experts.4.weight, backbone.blocks.10.mlp.experts.4.bias, backbone.blocks.10.mlp.experts.5.weight, backbone.blocks.10.mlp.experts.5.bias, backbone.blocks.11.mlp.experts.0.weight, backbone.blocks.11.mlp.experts.0.bias, backbone.blocks.11.mlp.experts.1.weight, backbone.blocks.11.mlp.experts.1.bias, backbone.blocks.11.mlp.experts.2.weight, backbone.blocks.11.mlp.experts.2.bias, backbone.blocks.11.mlp.experts.3.weight, backbone.blocks.11.mlp.experts.3.bias, backbone.blocks.11.mlp.experts.4.weight, backbone.blocks.11.mlp.experts.4.bias, backbone.blocks.11.mlp.experts.5.weight, backbone.blocks.11.mlp.experts.5.bias, backbone.blocks.12.mlp.experts.0.weight, backbone.blocks.12.mlp.experts.0.bias, backbone.blocks.12.mlp.experts.1.weight, backbone.blocks.12.mlp.experts.1.bias, backbone.blocks.12.mlp.experts.2.weight, backbone.blocks.12.mlp.experts.2.bias, backbone.blocks.12.mlp.experts.3.weight, backbone.blocks.12.mlp.experts.3.bias, backbone.blocks.12.mlp.experts.4.weight, backbone.blocks.12.mlp.experts.4.bias, backbone.blocks.12.mlp.experts.5.weight, backbone.blocks.12.mlp.experts.5.bias, backbone.blocks.13.mlp.experts.0.weight, backbone.blocks.13.mlp.experts.0.bias, backbone.blocks.13.mlp.experts.1.weight, backbone.blocks.13.mlp.experts.1.bias, backbone.blocks.13.mlp.experts.2.weight, backbone.blocks.13.mlp.experts.2.bias, backbone.blocks.13.mlp.experts.3.weight, backbone.blocks.13.mlp.experts.3.bias, backbone.blocks.13.mlp.experts.4.weight, backbone.blocks.13.mlp.experts.4.bias, backbone.blocks.13.mlp.experts.5.weight, backbone.blocks.13.mlp.experts.5.bias, backbone.blocks.14.mlp.experts.0.weight, backbone.blocks.14.mlp.experts.0.bias, backbone.blocks.14.mlp.experts.1.weight, backbone.blocks.14.mlp.experts.1.bias, backbone.blocks.14.mlp.experts.2.weight, backbone.blocks.14.mlp.experts.2.bias, backbone.blocks.14.mlp.experts.3.weight, backbone.blocks.14.mlp.experts.3.bias, backbone.blocks.14.mlp.experts.4.weight, backbone.blocks.14.mlp.experts.4.bias, backbone.blocks.14.mlp.experts.5.weight, backbone.blocks.14.mlp.experts.5.bias, backbone.blocks.15.mlp.experts.0.weight, backbone.blocks.15.mlp.experts.0.bias, backbone.blocks.15.mlp.experts.1.weight, backbone.blocks.15.mlp.experts.1.bias, backbone.blocks.15.mlp.experts.2.weight, backbone.blocks.15.mlp.experts.2.bias, backbone.blocks.15.mlp.experts.3.weight, backbone.blocks.15.mlp.experts.3.bias, backbone.blocks.15.mlp.experts.4.weight, backbone.blocks.15.mlp.experts.4.bias, backbone.blocks.15.mlp.experts.5.weight, backbone.blocks.15.mlp.experts.5.bias, backbone.blocks.16.mlp.experts.0.weight, backbone.blocks.16.mlp.experts.0.bias, backbone.blocks.16.mlp.experts.1.weight, backbone.blocks.16.mlp.experts.1.bias, backbone.blocks.16.mlp.experts.2.weight, backbone.blocks.16.mlp.experts.2.bias, backbone.blocks.16.mlp.experts.3.weight, backbone.blocks.16.mlp.experts.3.bias, backbone.blocks.16.mlp.experts.4.weight, backbone.blocks.16.mlp.experts.4.bias, backbone.blocks.16.mlp.experts.5.weight, backbone.blocks.16.mlp.experts.5.bias, backbone.blocks.17.mlp.experts.0.weight, backbone.blocks.17.mlp.experts.0.bias, backbone.blocks.17.mlp.experts.1.weight, backbone.blocks.17.mlp.experts.1.bias, backbone.blocks.17.mlp.experts.2.weight, backbone.blocks.17.mlp.experts.2.bias, backbone.blocks.17.mlp.experts.3.weight, backbone.blocks.17.mlp.experts.3.bias, backbone.blocks.17.mlp.experts.4.weight, backbone.blocks.17.mlp.experts.4.bias, backbone.blocks.17.mlp.experts.5.weight, backbone.blocks.17.mlp.experts.5.bias, backbone.blocks.18.mlp.experts.0.weight, backbone.blocks.18.mlp.experts.0.bias, backbone.blocks.18.mlp.experts.1.weight, backbone.blocks.18.mlp.experts.1.bias, backbone.blocks.18.mlp.experts.2.weight, backbone.blocks.18.mlp.experts.2.bias, backbone.blocks.18.mlp.experts.3.weight, backbone.blocks.18.mlp.experts.3.bias, backbone.blocks.18.mlp.experts.4.weight, backbone.blocks.18.mlp.experts.4.bias, backbone.blocks.18.mlp.experts.5.weight, backbone.blocks.18.mlp.experts.5.bias, backbone.blocks.19.mlp.experts.0.weight, backbone.blocks.19.mlp.experts.0.bias, backbone.blocks.19.mlp.experts.1.weight, backbone.blocks.19.mlp.experts.1.bias, backbone.blocks.19.mlp.experts.2.weight, backbone.blocks.19.mlp.experts.2.bias, backbone.blocks.19.mlp.experts.3.weight, backbone.blocks.19.mlp.experts.3.bias, backbone.blocks.19.mlp.experts.4.weight, backbone.blocks.19.mlp.experts.4.bias, backbone.blocks.19.mlp.experts.5.weight, backbone.blocks.19.mlp.experts.5.bias, backbone.blocks.20.mlp.experts.0.weight, backbone.blocks.20.mlp.experts.0.bias, backbone.blocks.20.mlp.experts.1.weight, backbone.blocks.20.mlp.experts.1.bias, backbone.blocks.20.mlp.experts.2.weight, backbone.blocks.20.mlp.experts.2.bias, backbone.blocks.20.mlp.experts.3.weight, backbone.blocks.20.mlp.experts.3.bias, backbone.blocks.20.mlp.experts.4.weight, backbone.blocks.20.mlp.experts.4.bias, backbone.blocks.20.mlp.experts.5.weight, backbone.blocks.20.mlp.experts.5.bias, backbone.blocks.21.mlp.experts.0.weight, backbone.blocks.21.mlp.experts.0.bias, backbone.blocks.21.mlp.experts.1.weight, backbone.blocks.21.mlp.experts.1.bias, backbone.blocks.21.mlp.experts.2.weight, backbone.blocks.21.mlp.experts.2.bias, backbone.blocks.21.mlp.experts.3.weight, backbone.blocks.21.mlp.experts.3.bias, backbone.blocks.21.mlp.experts.4.weight, backbone.blocks.21.mlp.experts.4.bias, backbone.blocks.21.mlp.experts.5.weight, backbone.blocks.21.mlp.experts.5.bias, backbone.blocks.22.mlp.experts.0.weight, backbone.blocks.22.mlp.experts.0.bias, backbone.blocks.22.mlp.experts.1.weight, backbone.blocks.22.mlp.experts.1.bias, backbone.blocks.22.mlp.experts.2.weight, backbone.blocks.22.mlp.experts.2.bias, backbone.blocks.22.mlp.experts.3.weight, backbone.blocks.22.mlp.experts.3.bias, backbone.blocks.22.mlp.experts.4.weight, backbone.blocks.22.mlp.experts.4.bias, backbone.blocks.22.mlp.experts.5.weight, backbone.blocks.22.mlp.experts.5.bias, backbone.blocks.23.mlp.experts.0.weight, backbone.blocks.23.mlp.experts.0.bias, backbone.blocks.23.mlp.experts.1.weight, backbone.blocks.23.mlp.experts.1.bias, backbone.blocks.23.mlp.experts.2.weight, backbone.blocks.23.mlp.experts.2.bias, backbone.blocks.23.mlp.experts.3.weight, backbone.blocks.23.mlp.experts.3.bias, backbone.blocks.23.mlp.experts.4.weight, backbone.blocks.23.mlp.experts.4.bias, backbone.blocks.23.mlp.experts.5.weight, backbone.blocks.23.mlp.experts.5.bias, backbone.blocks.24.mlp.experts.0.weight, backbone.blocks.24.mlp.experts.0.bias, backbone.blocks.24.mlp.experts.1.weight, backbone.blocks.24.mlp.experts.1.bias, backbone.blocks.24.mlp.experts.2.weight, backbone.blocks.24.mlp.experts.2.bias, backbone.blocks.24.mlp.experts.3.weight, backbone.blocks.24.mlp.experts.3.bias, backbone.blocks.24.mlp.experts.4.weight, backbone.blocks.24.mlp.experts.4.bias, backbone.blocks.24.mlp.experts.5.weight, backbone.blocks.24.mlp.experts.5.bias, backbone.blocks.25.mlp.experts.0.weight, backbone.blocks.25.mlp.experts.0.bias, backbone.blocks.25.mlp.experts.1.weight, backbone.blocks.25.mlp.experts.1.bias, backbone.blocks.25.mlp.experts.2.weight, backbone.blocks.25.mlp.experts.2.bias, backbone.blocks.25.mlp.experts.3.weight, backbone.blocks.25.mlp.experts.3.bias, backbone.blocks.25.mlp.experts.4.weight, backbone.blocks.25.mlp.experts.4.bias, backbone.blocks.25.mlp.experts.5.weight, backbone.blocks.25.mlp.experts.5.bias, backbone.blocks.26.mlp.experts.0.weight, backbone.blocks.26.mlp.experts.0.bias, backbone.blocks.26.mlp.experts.1.weight, backbone.blocks.26.mlp.experts.1.bias, backbone.blocks.26.mlp.experts.2.weight, backbone.blocks.26.mlp.experts.2.bias, backbone.blocks.26.mlp.experts.3.weight, backbone.blocks.26.mlp.experts.3.bias, backbone.blocks.26.mlp.experts.4.weight, backbone.blocks.26.mlp.experts.4.bias, backbone.blocks.26.mlp.experts.5.weight, backbone.blocks.26.mlp.experts.5.bias, backbone.blocks.27.mlp.experts.0.weight, backbone.blocks.27.mlp.experts.0.bias, backbone.blocks.27.mlp.experts.1.weight, backbone.blocks.27.mlp.experts.1.bias, backbone.blocks.27.mlp.experts.2.weight, backbone.blocks.27.mlp.experts.2.bias, backbone.blocks.27.mlp.experts.3.weight, backbone.blocks.27.mlp.experts.3.bias, backbone.blocks.27.mlp.experts.4.weight, backbone.blocks.27.mlp.experts.4.bias, backbone.blocks.27.mlp.experts.5.weight, backbone.blocks.27.mlp.experts.5.bias, backbone.blocks.28.mlp.experts.0.weight, backbone.blocks.28.mlp.experts.0.bias, backbone.blocks.28.mlp.experts.1.weight, backbone.blocks.28.mlp.experts.1.bias, backbone.blocks.28.mlp.experts.2.weight, backbone.blocks.28.mlp.experts.2.bias, backbone.blocks.28.mlp.experts.3.weight, backbone.blocks.28.mlp.experts.3.bias, backbone.blocks.28.mlp.experts.4.weight, backbone.blocks.28.mlp.experts.4.bias, backbone.blocks.28.mlp.experts.5.weight, backbone.blocks.28.mlp.experts.5.bias, backbone.blocks.29.mlp.experts.0.weight, backbone.blocks.29.mlp.experts.0.bias, backbone.blocks.29.mlp.experts.1.weight, backbone.blocks.29.mlp.experts.1.bias, backbone.blocks.29.mlp.experts.2.weight, backbone.blocks.29.mlp.experts.2.bias, backbone.blocks.29.mlp.experts.3.weight, backbone.blocks.29.mlp.experts.3.bias, backbone.blocks.29.mlp.experts.4.weight, backbone.blocks.29.mlp.experts.4.bias, backbone.blocks.29.mlp.experts.5.weight, backbone.blocks.29.mlp.experts.5.bias, backbone.blocks.30.mlp.experts.0.weight, backbone.blocks.30.mlp.experts.0.bias, backbone.blocks.30.mlp.experts.1.weight, backbone.blocks.30.mlp.experts.1.bias, backbone.blocks.30.mlp.experts.2.weight, backbone.blocks.30.mlp.experts.2.bias, backbone.blocks.30.mlp.experts.3.weight, backbone.blocks.30.mlp.experts.3.bias, backbone.blocks.30.mlp.experts.4.weight, backbone.blocks.30.mlp.experts.4.bias, backbone.blocks.30.mlp.experts.5.weight, backbone.blocks.30.mlp.experts.5.bias, backbone.blocks.31.mlp.experts.0.weight, backbone.blocks.31.mlp.experts.0.bias, backbone.blocks.31.mlp.experts.1.weight, backbone.blocks.31.mlp.experts.1.bias, backbone.blocks.31.mlp.experts.2.weight, backbone.blocks.31.mlp.experts.2.bias, backbone.blocks.31.mlp.experts.3.weight, backbone.blocks.31.mlp.experts.3.bias, backbone.blocks.31.mlp.experts.4.weight, backbone.blocks.31.mlp.experts.4.bias, backbone.blocks.31.mlp.experts.5.weight, backbone.blocks.31.mlp.experts.5.bias

Traceback (most recent call last):
  File "/home/katmai/Desktop/hamer/demo.py", line 208, in <module>
    main()
  File "/home/katmai/Desktop/hamer/demo.py", line 65, in main
    cpm = ViTPoseModel(device)
  File "/home/katmai/Desktop/hamer/vitpose_model.py", line 28, in __init__
    self.model = self._load_model(self.model_name)
  File "/home/katmai/Desktop/hamer/vitpose_model.py", line 37, in _load_model
    model = init_pose_model(dic['config'], ckpt_path, device=self.device)
  File "/home/katmai/Desktop/hamer/third-party/ViTPose/mmpose/apis/inference.py", line 45, in init_pose_model
    model.to(device)
  File "/home/katmai/anaconda3/envs/vitpose/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1152, in to
    return self._apply(convert)
  File "/home/katmai/anaconda3/envs/vitpose/lib/python3.10/site-packages/torch/nn/modules/module.py", line 802, in _apply
    module._apply(fn)
  File "/home/katmai/anaconda3/envs/vitpose/lib/python3.10/site-packages/torch/nn/modules/module.py", line 802, in _apply
    module._apply(fn)
  File "/home/katmai/anaconda3/envs/vitpose/lib/python3.10/site-packages/torch/nn/modules/module.py", line 802, in _apply
    module._apply(fn)
  [Previous line repeated 2 more times]
  File "/home/katmai/anaconda3/envs/vitpose/lib/python3.10/site-packages/torch/nn/modules/module.py", line 825, in _apply
    param_applied = fn(param)
  File "/home/katmai/anaconda3/envs/vitpose/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1150, in convert
    return t.to(device, dtype if t.is_floating_point() or t.is_complex() else None, non_blocking)
torch.cuda.OutOfMemoryError: CUDA out of memory. Tried to allocate 26.00 MiB. GPU 0 has a total capacity of 7.77 GiB of which 21.06 MiB is free. Including non-PyTorch memory, this process has 7.52 GiB memory in use. Of the allocated memory 7.20 GiB is allocated by PyTorch, and 172.24 MiB is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting PYTORCH_CUDA_ALLOC_CONF=expandable_segments:True to avoid fragmentation.  See documentation for Memory Management  (https://pytorch.org/docs/stable/notes/cuda.html#environment-variables)


Bugfix/2691 Shipping costs not updated in Checkout

Related issues
#2691
closes #2691
Short description and why it's useful
Using change.native triggers changeCountry() function as intended.
Which environment this relates to
Check your case. In case of any doubts please read about Release Cycle

[ ] Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
[x] RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
[ ] Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

[x] No upgrade steps required (100% backward compatibility and no breaking changes)
[ ] I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change
Contribution and currently important rules acceptance

[x] I read and followed contribution rules
[x] I read the TypeScript Action Plan and adjusted my PR according to it
[x] I read about Vue Storefront Modules and I am aware that every new feature should be a module

Could You please update the Changelog, please?
If You like to have this feature published in 1.9.0 (which would be great) - please close this PR and apply changes starting from release/1.9 instead?


Resolve of vkGetImageMemoryRequirements2 failed (Linux)

I was trying the examples but none of them work, they compile but crash at line 45 in src/renderer/skia_support.rs
let context = skia_safe::gpu::Context::new_vulkan(&backend_context).unwrap();

VkSkiaContext {
     context
}

I was expecting some king of error message, I have up to date vulkan drivers and I run Manjaro (Linux 5.3.6-1 kernel) with a Nvidia GTX1050 Ti.
This is the crashlog: https://pastebin.com/7aHgHjMa

Thanks for taking the time to report this. Looks a lot like #13 (skia is asking for vulkan 1.1 APIs), so it’s very useful to know someone else is hitting it, and on a different platform. There’s some info in a comment I added last night that might be relevant.

Does this change help by chance? Unfortunately since I can't reproduce this, I don't have a good way to know if this fix works or not. https://github.com/aclysma/skulpin/commit/e6869f22c0c7d2ee8797ec01761e2ecf5efcb3f6

I tested it and now it crashes in another way, this is the log https://pastebin.com/u7eMt01C
The program itself doesn't crash, I have to manually kill it because freezes the screen for a few seconds, then stops for 1 seconds and the freezes again.
Also Calculated physical dimensions: 1350x900 is wrong, my display is 2560x1440, and I have 2 monitors, both with the same resolution.

Nice, thanks for checking! The resolution is expected because the examples should be 900x600 logical size and the app detected a 1.5x dpi factor. I see a lot of validation errors in the log you pasted which is very helpful. Hopefully can have a fix for this very soon.

Thanks again for the info. I think https://github.com/aclysma/skulpin/commit/fb01ea685414ba698b81f80315bcda4daa6f1616 will help out. I had bad logic in the queue family selection. I suspect that your hardware looks like this https://vulkan.gpuinfo.org/displayreport.php?id=6772#queuefamilies and it picked QF 0 for graphics and QF 2 for presentation. It needed to use QF 0 for both.
I also added more logging for queue family handling so if it still isn't working for you, there will hopefully be more info on the next try.
Again, huge thanks!

It works perfectly now, thanks for fixing the bug.
I have plans to use this library for a project, but I need to finish other projects first and that will take weeks or months.
Anyway thanks for your hard work, keep it going!


Need more definition for issuer when configuring.

[Enter feedback here]
https://docs.microsoft.com/en-us/azure/vpn-gateway/openvpn-azure-ad-tenant
Need to specify in the documentation that item need is the tenant ID
http://sts.windows.net/tenantid/
Further for multi application VPN the audience needs to be changed to the application ID.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 186c0697-792a-a913-1baa-0af86f7ef6de
Version Independent ID: 330e7927-57fd-75e2-26b1-05bd2e8f30c1
Content: VPN Gateway: Azure AD tenant for P2S VPN connections: Azure AD authentication
Content Source: articles/vpn-gateway/openvpn-azure-ad-tenant.md
Service: vpn-gateway
GitHub Login: @cherylmc
Microsoft Alias: alzam

@D4-AzIdentity , thank you for your feedback. We'll review this and get back to you shortly.

@D4-AzIdentity ,  at the end of this article, there is a link in Next Steps to configure a VPN client for P2S connections which shows the steps on how to download the VPN client and create client profiles and that article refers to the link where you can find the instructions on how to export a client profile to obtain information that is necessary to configure a VPN connection such as Audience, Issuer, Tenant, FQDN & ServerSecret.

How to configure a VPN client for P2S OpenVPN protocol connections with Azure Active Directory authentication: https://docs.microsoft.com/en-us/azure/vpn-gateway/openvpn-azure-ad-client
How to get information that is necessary to configure a VPN connection :
https://docs.microsoft.com/en-us/azure/vpn-gateway/about-vpn-profile-download
We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.


Wiki link is broken

https://github.com/fintech-to-ynab/fintech-to-ynab/wiki/import:-Monzo links to https://github.com/scottrobertson/fintech-to-ynab/wiki/YNAB-Account-ID, which doesn't exist. It should be https://github.com/fintech-to-ynab/fintech-to-ynab/wiki/YNAB-Account-ID

Fixed, thanks.


Move repository to formal methods org

to make sure everyone has write access, can be requested as reviewer etc. I move the repo to formal-methods-mpi. Hope that is ok.

closes #74


Split rr_graph generation and patching from the test running

Currently the rr_graph generation and patching steps are down as part of running a test.
It would be nicer if this was a totally separate process.

The CMake system separates the rr_graph generation and patching (see add_device target https://github.com/SymbiFlow/symbiflow-arch-defs/blob/master/make/devices.cmake#L307) from the particular FPGA target.  All FPGA targets that use the same device will leverage the same rr_graph output.


No license specified in repo

Hi, really like your fSelect project and want to use it, but was unable to find a license in the repo. Is this intended to be shared under MIT license?

@nicksw1 Yes, it's MIT. License file just added :)

Great thank you!


Doc page: Edit on Github link broken

Takes me to a 404  page.

problem in readthedocs for some pages


Update python3Packages.{markupsafe,jinja2,itsdangerous,werkzeug,flask,click}

Motivation for this change
Palletsproject's recent releases dropped Python 2 support. When do we?
Flask:

https://github.com/pallets/flask/releases/tag/2.0.1
https://github.com/pallets/flask/releases/tag/2.0.0

Jinja2

https://github.com/pallets/jinja/releases/tag/3.0.1
https://github.com/pallets/jinja/releases/tag/3.0.0

Werkzeug

https://github.com/pallets/werkzeug/releases/tag/2.0.1
https://github.com/pallets/werkzeug/releases/tag/2.0.0

Click

https://github.com/pallets/click/releases/tag/8.0.1
https://github.com/pallets/click/releases/tag/8.0.0

itsdangerous

https://github.com/pallets/itsdangerous/releases/tag/2.0.1
https://github.com/pallets/itsdangerous/releases/tag/2.0.0

markupsafe

https://github.com/pallets/markupsafe/releases/tag/2.0.1
https://github.com/pallets/markupsafe/releases/tag/2.0.0

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[x] Fits CONTRIBUTING.md.

Werkzeug optionally depends on watchdog, which requires https://developer.apple.com/documentation/coreservices/1455361-fseventstreameventflags/kfseventstreameventflagitemcloned, which requires macos-sdk 10.13+, we have 10.12 right now, so I made it conditional on stdenv.isDarwin.
@NixOS/darwin-maintainers

Pushed the python2 package required to make nixops work again. Talked to @adisbladis who was confident that we can drop NixOps 1.7 before 21.11.

Merged into my local working tree for python-unstable.

@mweinelt What is the timeline for the Python batch upgrade? I might want to override click for the maestral packages if it will take a while.

@SFrijters Will start in an hour or so.


Rename metric tags

Bring tag names inline with prometheus naming conventions and go sdk/dashboards.

Hi i still see 1.0.4 in sona type and maven publish repositories. will an updated version of client/sdk be released in maven oss repos?

Hi i still see 1.0.4 in sona type and maven publish repositories. will an updated version of client/sdk be released in maven oss repos?


Improve experience of contributors

I think the experience of the contributors could be improved by adding a few things.

[x] Add CI
[x] Add CONTRIBUTING guidelines.

Thanks Teo! I hope your Christmas Airtable hacking went well. I've added Travis and rough guidelines for contributions.


update~ play

add secondary outlet (ban when finished)
about @loop / @loopinterp & @interptime
so, when you enable "interpolation around the start and end points for a loop" with @loopinterp [int], you "interpolate" with a "crossfade"...
@loopinterp only happens if you have the loop on - set with the @loop attrinbute
the default crossfad time for @loopinterp is 50ms, but you can change it with @interptime [float]
So... you have a loop section into the file! Say it's 5 seconds long, but you loop from 1 sec to 3 seconds... then, what it does at the loop point, is that it "fades in" starting from 1 second, but it will fade out from 3 seconds and on as long as the interptime, for a maximum of 2 seconds.

is this a linear crossfade? meaning, the gain of loop 1 is g, the fading in one is 1-g?
also in our example,.. loop is 1 -3 seconds,.. let's say loop 1 is the one fading in,.. so at sec 1,.. g = 0? and this goes for the 50 ms  = .05 s, so by sec 1.05, g is at 1 and loop 2 would've faded out since 1-g = 0 at that point. and then at 3 seconds, g starts declining again right? so from 3 to 3.05 seconds, g for loop 1 goes from 1 to 0 and 1-g (for loop 2) goes from 0 to 1, starting wtih the samples at sec 1. so in effect the loop is actually 1 to 3.05 seconds (ie, loopstart to loopend + xfade). What if say,.. your sample is 5 seconds long,.. and your loop is from 3 to 5 seconds? theres' no extra bit at the end to allow the xfading. so i suppose the only valid values for loopend go up to (end of sample - xfade)?

also i dunno what the extra outlet play~ has does, as noted in my pull for cybuffing =)

I'm yet to test if it's linear, but seems like it
and yes, your cross fade can't meaningly go over the end sample range. It's my idea that the end of a sample fades out anyway. So say I have a file 5 sec long and I do loop it to start at 2 seconds (range 2-5) with a crossfade of 2.5 seconds long. All we hear is the file fading in till 4.5 seconds and then dying away, in a loop...
2nd outlet is bang when reaching end of play


Can't compile rust-rocksdb

Followed the instructions but had the following error when compiling:
$ cargo build
   Compiling rocksdb v0.0.8
/home/ferris/.cargo/registry/src/github.com-1ecc6299db9ec823/rocksdb-0.0.8/src/merge_operator.rs:168:27: 168:36 error: type mismatch resolving `<&[u8] as core::iter::IntoIterator>::Item == u8`:
 expected &-ptr,
    found u8 [E0271]
/home/ferris/.cargo/registry/src/github.com-1ecc6299db9ec823/rocksdb-0.0.8/src/merge_operator.rs:168         Some(v) => result.extend(v),
                                                                                ^~~~~~~~~
/home/ferris/.cargo/registry/src/github.com-1ecc6299db9ec823/rocksdb-0.0.8/src/merge_operator.rs:168:27: 168:36 help: run `rustc --explain E0271` to see a detailed explanation
/home/ferris/.cargo/registry/src/github.com-1ecc6299db9ec823/rocksdb-0.0.8/src/merge_operator.rs:172:16: 172:26 error: type mismatch resolving `<&[u8] as core::iter::IntoIterator>::Item == u8`:
 expected &-ptr,
    found u8 [E0271]
/home/ferris/.cargo/registry/src/github.com-1ecc6299db9ec823/rocksdb-0.0.8/src/merge_operator.rs:172         result.extend(op);
                                                                                ^~~~~~~~~~
note: in expansion of for loop expansion
/home/ferris/.cargo/registry/src/github.com-1ecc6299db9ec823/rocksdb-0.0.8/src/merge_operator.rs:171:5: 173:6 note: expansion site
/home/ferris/.cargo/registry/src/github.com-1ecc6299db9ec823/rocksdb-0.0.8/src/merge_operator.rs:172:16: 172:26 help: run `rustc --explain E0271` to see a detailed explanation
error: aborting due to 2 previous errors
Could not compile `rocksdb`.

Any idea what the issue is? I'm happy to do a PR and fix it if needed :)

Hey @code-ape!  Are you building using a recent nightly rustc?  Currently the library is only targeting the unstable nightly releases, although I would love to get a version that targets the 1.1.0 release if it's doable without significant work.  I was just able to compile it using today's nightly on Linux and OSX, but it's totally possible I'm assuming something that isn't true about my setup, and if you're not having luck with the nightly then there's almost certainly a bug.

No, it was a bug in my setup! I reloaded the nightly build at it worked fine haha. I'll take a look at seeing how hard it is to port to 1.1.0 though!

Awesome, glad you got it working!  Feel free to open a PR even for small things that you move away from unstable dependencies, as every bit helps.


Test could be defined as not-implemented

At the moment you've the possibility to use the ignore element to specify that a test should not be run. But, anyway the test should be valid from a syntax point of view. This new option will let you the opportunity to specify that a test should exist but has not been implemented at all (so the system-under-test and assert are not expected).
<test name="...">
  <description>...</description>
  <category>...</category>
  <not-implemented>
     <reason>This kind of test is not supported by NBi</reason>
  </not-implemented>
</test>

A not-implemented test will be ignored and a category will automatically be added (not_implemented)

Hi @Seddryck ,
would it make sense to directly write the reason into the element not-implemented instead of having an extra reason-element within?
<test name="...">
  <description>...</description>
  <category>...</category>
  <not-implemented>
       This kind of test is not supported by NBi
  </not-implemented>
</test>

This would be consistent with the ignore-element, which directly contains the ignore-reason.
    <ignore>
         my reason
    <ignore>

Cheers

Yes should also be supported.

On 3 Dec 2017, at 10:54, Tilo Sommerwerk<EMAIL_ADDRESS>wrote:
Hi @Seddryck ,
would it make sense to directly write the reason into the element not-implemented instead of having an extra reason-element within?

...
...

       This kind of test is not supported by NBi

This would be consistent with the ignore-element, which directly contains the ignore-reason.
<ignore>
     my reason
<ignore>

Cheers
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Final syntax:
<test name="...">
  <description>...</description>
  <category>...</category>
  <not-implemented>This kind of test is not supported by NBi</not-implemented>
  <any-tag>
      <any-child-tag/>
  </any-tag>
</test>

Alpha version available at: https://ci.appveyor.com/project/Seddryck/nbi/build/1.17.0-beta.110.build.234
This won't be included in 1.17 but in 1.18

would the reason for not-implemented be returned in the result-xml as well?

Yes, it is. If a test is not-implemented then it will be ignored and the reason if non-implementation will be reported in the ignore message.

On 6 Dec 2017, at 10:31, Tilo Sommerwerk<EMAIL_ADDRESS>wrote:
would the reason for not-implemented be returned in the result-xml as well?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Security report

Hi, @pfrazee ! Thanks for unblocking me from /beakerbrowser org on GitHub.
I've never before described issues here, what made you wanting to block.
I forgive our disagreement, and I'm now here to do support and describe this issue.
The most sensible kind of Electron app is a browser, which is the case of Beaker.
I'm doing security audit on lots of Electron apps, and Beaker were special because of being a browser. And it showed vulnerabilities, and more than the other apps.
Attached to this issue is the HTML file of the report.
beaker-security_report.html.zip

So, I talked with Tara about what happened. I know your intentions are good! but you do make a lot of issues and sometimes they're not super helpful.
I appreciate you running a security audit on the browser, but are any of these results important? I scanned through them and didn't see anything I don't already know about.

So, I talked with Tara about what happened. I know your intentions are good! but you do make a lot of issues and sometimes they're not super helpful.

Thanks.
Well, in lots of projects I post only the title, and they are correctly interpreted. But it depends, and I'll remember to describe in anything related to Dat and Beaker.

I appreciate you running a security audit on the browser, but are any of these results important? I scanned through them and didn't see anything I don't already know about.

If Electronegativity, as a security auditor and not a JS-best-practices program, I think these results are important.
Well, you already knew about?


pushing discovered disk to etcd

apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
  name: disks.openebs.io
spec:
  group: openebs.io
  version: v1alpha1
  scope: Cluster
  names:
    plural: disks
    singular: disk
    kind: Disk
    shortNames:
    - disk

$ ndm start --kubeconfig=$HOME/.kube/config
E0329 00:40:15.252388   29860 ctrl_main.go:36] failed to get k8s Incluster config. unable to load in-cluster configuration, KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT must be defined
I0329 00:40:15.258952   29860 ctrl.go:61] Started the controller
I0329 00:40:15.397065   29860 ctrl.go:125] disk object already exist : sda
I0329 00:40:15.400448   29860 ctrl.go:127] pushing disk object : sdb
I0329 00:40:15.406694   29860 ctrl.go:80] Created disk object : disk-b3f828db7cd829ac237e90ccf433bd17

$ kubectl get disk
NAME                                    AGE
disk-0x500003949d304e06                 45s
disk-b3f828db7cd829ac237e90ccf433bd17   5s

$ kubectl describe disks
Name:         disk-0x500003949d304e06
Namespace:
Labels:       <none>
Annotations:  <none>
API Version:  openebs.io/v1alpha1
Kind:         Disk
Metadata:
  Cluster Name:
  Creation Timestamp:             2018-03-28T19:09:35Z
  Deletion Grace Period Seconds:  <nil>
  Deletion Timestamp:             <nil>
  Initializers:                   <nil>
  Resource Version:               2150111
  Self Link:                      /apis/openebs.io/v1alpha1/disk-0x500003949d304e06
  UID:                            8e008a5b-32bb-11e8-bab3-e4115b2f5dfc
Spec:
  Capacity:
    Storage:<PHONE_NUMBER>16
  Details:
    Model:   TOSHIBA MK5061GS
    Serial:  23FCYE2IF
    Vendor:  ATA
  Path:      /dev/sda
Events:      <none>

Name:         disk-b3f828db7cd829ac237e90ccf433bd17
Namespace:
Labels:       <none>
Annotations:  <none>
API Version:  openebs.io/v1alpha1
Kind:         Disk
Metadata:
  Cluster Name:
  Creation Timestamp:             2018-03-28T19:10:15Z
  Deletion Grace Period Seconds:  <nil>
  Deletion Timestamp:             <nil>
  Initializers:                   <nil>
  Resource Version:               2150156
  Self Link:                      /apis/openebs.io/v1alpha1/disk-b3f828db7cd829ac237e90ccf433bd17
  UID:                            a5a36f0e-32bb-11e8-bab3-e4115b2f5dfc
Spec:
  Capacity:
    Storage:<PHONE_NUMBER>0
  Details:
    Model:   Ultra
    Serial:  SanDisk.Ultra...........4C531001520618104171
    Vendor:  SanDisk
  Path:      /dev/sdb
Events:      <none>

@pawanpraka1 : Few comments to keep this in sync with the design:

Can you modify the DiskObjects to Disk Resources as mentioned in this example : https://github.com/openebs/node-disk-manager/pull/1/files#diff-33325f0c9f4b7b398ce37179dc3e6db5
The types should reflect the example or vice versa: https://github.com/openebs/node-disk-manager/pull/1/files#diff-af33dcbe18ed6c8fbd2db0825dbf6b8a

@kmova, made the spec in sync with the design doc.

The review comments related to uuid, and other attributes will be addressed via design discussion. This PR is merged to have the code (disk objects) available for building the metrics/monitoring capabilities.

fixes - https://github.com/openebs/node-disk-manager/issues/10


Add non-TLS connection over raw tcp to suppor Minecraft

Well, I am not a friend from templates so I'll write it simply:
Traefik is a nice tool but it has no support for redirecting raw tcp traffic to MC-Server, which are using domains instead of IP connections.
Normaly, it is done over SRV records, to joine over an url, without the port, but using HostSNI('*') it works with url:port which is also fine but not wanted, because it is no longer limited to that domain it should be limited.
Means, in the TCP part of traefik it is important to implement the non-TLS Host() methode, which is available in e. g. http or add a symple URL() to parse it and redirect it to the correct service.
But for now, it is horrible to setup Minecraft (with/wtihout bungeecord).
Thanks and Cheers
Chaoschaot232

Hi! I'm Træfiker :robot: the bot in charge of communication regulation.
Thanks for your interest in Traefik!
We dedicate the issue tracker to bug reports and feature requests only. My advanced AI has spotted that your issue might be a configuration problem or relates to something that doesn't look like a bug.
To confirm this, please join our Community Forum and reach out to us on the Traefik section.
In case I'm wrong (well, that would be embarrassing :sweat_smile:), my developers will re-open the issue and fix me!
In the meantime, you can double check Traefik's documentation.

This is a nice bot and a nice response ^^
Well, after all, it isn't a bug, it is a problem within traefik, that it isn't realy possible, to have one static domain for multiply MC servers, because the doc states, that only HostSNI is available for domains.
The problem here is SNI, which is part of TLS and this can't be handled by MC which isn't realy good. So my request is to add a non-SNI-methode, like Host()/URL(), instead of using HostSNI('*'), which isn't that, what I want to use ^^
Would be nice, if this could be looked up :)

Hello @Chaoschaot232,
I figured I would give you some more insight here.
Minecraft uses a custom TCP protocol, and is not encapsulated in an HTTP request.
TCP connections contain only IP and port information of the source and destination. They do not carry any other information:
https://en.wikipedia.org/wiki/Transmission_Control_Protocol#TCP_segment_structure
There is no Host, there is no URL, there is no Path.
When you connect to mc.yourdomain.minecraft.com, DNS is used to resolve this to an IP, and then a TCP connection is opened to this server.
This is why for TCP, Traefik only allows SNI to be used to route hosts, because the SNI extension does carry the request host as part of the handshake.
Therefore this request isn't a problem with Traefik, the problem is that minecraft does not use a modern communication medium that is easily routable on the web.
You can combine your SRV records to use different ports on Traefik, and configure Traefik to have multiple entrypoints that listen on those ports.
Then you can use those entrypoints to forward to your servers.
Hope this helps.

Hi @dtomcej ,
thank you for your exntended response. Didn't knew, that MC has it's own TCP protocol.
Well, then this would be the best solution I would say. Do you mind giving me an example how an entrypoint would look like, when the SRV points to the default MC-Port?
Also, modded MC has smth called Dynmap which comes with his own mini webserver, which listens on port 8123 (default).
We used the same config for our gitlab installtion over traefik and it works just fine, but when we try to add any http-nodes/entrypoints for the dynmap, nothing is recognized by traefik. Maybe because MC's log tells every time, that dynmap couldn't create the internal webserver?
If so, then we can easily use the work arround and put the dynmap in a gitlab repro and let a pipeline handle the stuff which wouldn't need dynmap's internal webserver ^^
Have a nice day/nigth :)


Greter or equal sign ">=" changed to ">"

Submitting code that involves ">=" changed to >=. HTML problem?

Can you please provide some additional information so we can figure out the source of the issue.

which version of MarkUs does this occur on?
which page does it occur on?
what type of code are you submitting? (java, python, c?)
what browser do you use? Does this problem occur in other browsers as well?
any additional information that would help.

Thanks

Version: 1.14.0.DEV
Page: Submission
Lang: Haskell
Browser: chrome, did not test on other browsers


Remove yarn files

Currently, we are not using yarn as the main dependency manager so instead of keeping two lock files by npm and yarn both, we should keep only npm one for now until we decide to switch to yarn completely. Therefore, both yarn files need to be removed from the database and to be added into .gitignore.

I'll fix this one.

Sure


Animation stutters

https://user-images.githubusercontent.com/1586725/109475175-ac92db80-7a75-11eb-8fa2-63302f2998c6.MP4
Description
When I'm dragging the panel from tip to half the animation stutters in the end
Expected behavior
Animation should be fluent
Actual behavior
Animation stutters/jumps
Steps to reproduce
Code example that reproduces the issue
extension PSSProductDetailViewController: FloatingPanelControllerDelegate, FloatingPanelLayout {

    var position: FloatingPanelPosition { .bottom }

    var initialState: FloatingPanelState { .tip }

    func backdropAlpha(for state: FloatingPanelState) -> CGFloat {
        return 0.7
    }

    var anchors: [FloatingPanelState: FloatingPanelLayoutAnchoring] {
        let padding = (self.panel?.surfaceView.grabberHandlePadding ?? 0)
        return [
            .full: FloatingPanelLayoutAnchor(absoluteInset: 15.0, edge: .top, referenceGuide: .safeArea),
            .half: FloatingPanelLayoutAnchor(absoluteInset: self.addProductView.frame.maxY + 34 + padding, edge: .bottom, referenceGuide: .superview),
            .tip: FloatingPanelLayoutAnchor(absoluteInset: 110.0, edge: .bottom, referenceGuide: .safeArea),

        ]
    }

    public func floatingPanelDidChangePosition(_ fpc: FloatingPanelController) {
        self.addMoreButton.isHidden = !(fpc.state == .tip)
        self.closeButton.isHidden = (fpc.state == .tip)
        self.productSubTitleLabel.text = (fpc.state == .tip) ? Strings.Localizable.shoppingAddedItem : self.productSubTitleLabel.accessibilityLabel
    }

    public func floatingPanelDidRemove(_ fpc: FloatingPanelController) {
        self.viewModel.rxScannedBarcode.onNext(nil)
    }

    public func floatingPanelDidMove(_ fpc: FloatingPanelController) {

        let currentY = fpc.surfaceLocation.y

        let tipY = fpc.surfaceLocation(for: .tip).y
        let halfY = fpc.surfaceLocation(for: .half).y

        let distanceToHalf = max(0, currentY - halfY)
        let totalDistance = tipY - halfY
        let percentage = (0.0...1.0).clamp((totalDistance - distanceToHalf) / totalDistance)

        self.updatePanelLayout(percentage: percentage)

        print("currentY: \(currentY) tipY: \(tipY) halfY: \(halfY) percentage: \(percentage)")
    }
}

fileprivate func updatePanelLayout(percentage: CGFloat) {

        let imageSize: CGFloat = 70 + (130 * percentage)
        let imageLeft: CGFloat = 20 + (((self.view.frame.width / 2) - (imageSize / 2)) * percentage)
        let labelTop: CGFloat = 20 + ((self.assortmentsStackView.frame.maxY) * percentage)
        let labelLeft: CGFloat = 90 - (90 * percentage) + 20

        self.imageSizeConstraint.constant = imageSize
        self.imageLeftConstraint.constant = imageLeft
        self.labelTopConstraint.constant = labelTop
        self.labelLeftConstraint.constant = labelLeft

        self.scrollContainerView.setNeedsLayout()
        self.scrollContainerView.layoutIfNeeded()
}

How do you display panel(s)?

Present modally

How many panels do you displays?

1

Environment
Library version
2.1.0
Installation method

Swift Package Manager

iOS version(s)
14.4
Xcode version
12.4

It seems that target positions for half state calculated from the following code before/after the animation are deferent. self.addProdctView and padding might affect the animation.
.half: FloatingPanelLayoutAnchor(absoluteInset: self.addProductView.frame.maxY + 34 + padding, edge: .bottom, referenceGuide: .superview)

I have the same problem. Animating around the half state seems to mmentarily jump to 50% before it goes to what I want it to be.
      .half: FloatingPanelLayoutAnchor(absoluteInset: 100, edge: .bottom, referenceGuide: .superview)

causes stuttering when animating around the half state.

having same issue on 2.8.6


No mjml-Container only rows and colums ?

mjml-container seems to not exist annymore.

As stated in the doc:
 mj-body replaces the couple mj-body and mj-container of MJML v3.


Add weekly highlights for the week ending April 1, 2022

Please add your contributions until Friday, April 1, 14:00 CEST (12:00 UTC)

nothing from honeybadger this week


[SPARK-15698][SQL][Streaming] Add the ability to remove the old MetadataLog in FileStreamSource

What changes were proposed in this pull request?
Current metadataLog in FileStreamSource will add a checkpoint file in each batch but do not have the ability to remove/compact, which will lead to large number of small files when running for a long time. So here propose to compact the old logs into one file. This method is quite similar to FileStreamSinkLog but simpler.
How was this patch tested?
Unit test added.

Test build #60000 has started for PR 13513 at commit 2ed1115.

Test build #60000 has finished for PR 13513 at commit 2ed1115.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class FileStreamSourceLog(sparkSession: SparkSession, path: String)

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60000/
Test FAILed.

Jenkins, retest this please.

Test build #60060 has started for PR 13513 at commit 2ed1115.

Test build #60060 has finished for PR 13513 at commit 2ed1115.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class FileStreamSourceLog(sparkSession: SparkSession, path: String)

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60060/
Test FAILed.

Test build #60071 has started for PR 13513 at commit 798c450.

Test build #60071 has finished for PR 13513 at commit 798c450.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60071/
Test PASSed.

@tdas @zsxwing , what is your comment about this PR? Thanks a lot.

@jerryshao the approach seems good to me. Could you refactor the codes to avoid copying codes from FileStreamSinkLog? It's hard to maintain duplicated codes.

Sure, I will change the code.

Test build #65244 has started for PR 13513 at commit c2aad87.

Test build #65244 has finished for PR 13513 at commit c2aad87.

This patch fails to build.
This patch merges cleanly.
This patch adds the following public classes (experimental):
  case class FileEntry(path: String, timestamp: Timestamp, action: String = ADD_ACTION)
  class FileStreamSourceLog(sparkSession: SparkSession, path: String)

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65244/
Test FAILed.

Merged build finished. Test FAILed.

@zsxwing , thanks a lot for your comments, I did several refactorings:

Abstract and consolidate FileStreamSinkLog and FileStreamSourceLog, now they share same code path to do compaction.
Change FileStreamSourceLog to use json format instead of binary coding, to add the compatibility and flexibility for future extension.
Improve the logics to fetch all metadata logs, now if compact log is existed, only scan compact log.

Please help to review again, thanks a lot.

Test build #65245 has started for PR 13513 at commit f179349.

Test build #65246 has started for PR 13513 at commit 31340b5.

Test build #65245 has finished for PR 13513 at commit f179349.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class CompactibleFileStreamLog[T: ClassTag](

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65245/
Test PASSed.

Test build #65246 has finished for PR 13513 at commit 31340b5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65246/
Test PASSed.

Merged build finished. Test PASSed.

Just noticed that FileStreamSource.getBatch(start: Option[Offset], end: Offset) is broken in this PR. start could be an arbitrary offset.
I think we need to store batchId with its file paths together in the metadata log. FileStreamSource.getBatch(start: Option[Offset], end: Offset) could be very slow when all batches are in the same file because we need to parse the whole file to get the mapping from batchId to files. However, in most cases, FileStreamSource.getBatch only queries the latest batch, so if we don't compact the latest metadata file, we can make it pretty fast by reading one small file for most of cases. When recovering from failure, the performance of FileStreamSource.getBatch doesn't really matter.

You could just move the metadata deletion logic from FileStreamSinkLog into CompactibleFileStreamLog. Then FileStreamSource could issue DELETE log records for files that are older than FileStreamSource.lastPurgeTimestamp.

@zsxwing @frreiss thanks a lot for your comments.
I think  the semantics of FileStreamSource.getBatch(start: Option[Offset], end: Offset) still keeps the same, since I overrided the get method in FileStreamSourceLog and filter out some compacted data.
Yes it could be slow to get  a batch where it happens to be a compact batch. I think we could have 2 solutions:

doing compact on the next of latest metadata file (as what I did before), then this will help most of the scenarios in FileStreamSource.
We could put the data in this patch at beginning when doing compaction, so we don't need to scan the whole file to get this batch's metadata.

Both two solutions need extra works, what do you think?

Ah, now I fully understand @zsxwing's earlier comment about the semantics of the semantics of Source.getBatch(). Those semantics have a design flaw; see the email thread I started at http://apache-spark-developers-list.1001551.n3.nabble.com/Source-API-requires-unbounded-distributed-storage-tt18551.html. Basically, it's impossible to implement a Source to the written API spec without keeping unbounded state. I have an open PR to fix this problem at https://github.com/apache/spark/pull/14553.
In the short run, I think that @jerryshao's changes here are ok with respect to Source.getBatch. The approach in this PR will work as long as the internal structure of the StreamExecution class doesn't change and as long as Spark does not have to recover from an outage longer than the compaction interval. The recent changes to FileInputStream under SPARK-17165 (https://github.com/apache/spark/pull/14728) have the same problem, and those changes are already committed.

Still saw the following errors in the unit-test log:
16/09/13 07:41:18.817 shuffle-server-466-7 WARN TransportChannelHandler: Exception in connection from /<IP_ADDRESS>:36871
io.netty.util.internal.OutOfDirectMemoryError: failed to allocate 16777216 byte(s) of direct memory (used:<PHONE_NUMBER>, max:<PHONE_NUMBER>)
	at io.netty.util.internal.PlatformDependent.incrementMemoryCounter(PlatformDependent.java:528)
	at io.netty.util.internal.PlatformDependent.allocateDirectNoCleaner(PlatformDependent.java:482)
	at io.netty.buffer.PoolArena$DirectArena.allocateDirect(PoolArena.java:688)
	at io.netty.buffer.PoolArena$DirectArena.newChunk(PoolArena.java:677)
	at io.netty.buffer.PoolArena.allocateNormal(PoolArena.java:237)
	at io.netty.buffer.PoolArena.allocate(PoolArena.java:213)
	at io.netty.buffer.PoolArena.allocate(PoolArena.java:141)
	at io.netty.buffer.PooledByteBufAllocator.newDirectBuffer(PooledByteBufAllocator.java:271)
	at io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:177)
	at io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:168)
	at io.netty.buffer.AbstractByteBufAllocator.ioBuffer(AbstractByteBufAllocator.java:129)
	at io.netty.channel.AdaptiveRecvByteBufAllocator$HandleImpl.allocate(AdaptiveRecvByteBufAllocator.java:104)
	at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:117)
	at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:611)
	at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:552)
	at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:466)
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:438)
	at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:140)
	at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144)
	at java.lang.Thread.run(Thread.java:745)

Seems the error cannot be reported correctly in Jenkins.

Sorry. Replied a wrong PR. Deleting.

@frreiss SPARK-17165 (#14728) uses SeenFilesMap.lastPurgeTimestamp to ignore files. when recovering from failure, SeenFilesMap.lastPurgeTimestamp will be set via the files in the metadata log. File paths not stored in the memory but older than SeenFilesMap.lastPurgeTimestamp won't be processed. Therefore, it doesn't need to store unbounded state.

@jerryshao here is a test case to show the issue about getBatch:
  test("getBatch") {
    withTempDirs { case (src, tmp) =>
      withSQLConf(
        SQLConf.FILE_SOURCE_LOG_COMPACT_INTERVAL.key -> "2",
        // Force deleting the old logs
        SQLConf.FILE_SOURCE_LOG_CLEANUP_DELAY.key -> "1"
      ) {
        val fileStream = createFileStream("text", src.getCanonicalPath)
        val filtered = fileStream.filter($"value" contains "keep")

        testStream(filtered)(
          AddTextFileData("keep1", src, tmp),
          CheckAnswer("keep1"),
          AddTextFileData("keep2", src, tmp),
          CheckAnswer("keep1", "keep2"),
          AddTextFileData("keep3", src, tmp),
          CheckAnswer("keep1", "keep2", "keep3"),
          AssertOnQuery("check getBatch") { execution: StreamExecution =>
            val _sources = PrivateMethod[Seq[Source]]('sources)
            val fileSource =
              (execution invokePrivate _sources()).head.asInstanceOf[FileStreamSource]
            assert(fileSource.getBatch(None, LongOffset(2)).as[String].collect() ===
              List("keep1", "keep2", "keep3"))
            assert(fileSource.getBatch(Some(LongOffset(0)), LongOffset(2)).as[String].collect() ===
              List("keep2", "keep3"))
            assert(fileSource.getBatch(Some(LongOffset(1)), LongOffset(2)).as[String].collect() ===
              List("keep3"))
          }
        )
      }
    }
  }

Test build #65365 has started for PR 13513 at commit f9a4bcb.

Thanks a lot @zsxwing and @frreiss  for your comments.
For the slow scan problem of compact batch. Originally I planned to to not merge the latest batch as I did before, also suggested above. but with several different tries it is hard to implement with small changes. So for now I still choose the same implementation with a simple cache layer to overcome this problem, the basic compaction algorithm is still the same as FileStreamSinkLog. I think it is easier to maintain.
For the problem of semantics broken. I realized that it is really a problem, but current code didn't touch it. So I changed to scan the compacted batch files to retrieve missing batches. It is a little time-consuming, and the current logic of FileStreamSource will not touch this part.

Test build #65368 has started for PR 13513 at commit cb4194e.

Test build #65365 has finished for PR 13513 at commit f9a4bcb.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class FileStreamSinkLog(
  case class FileEntry(path: String, timestamp: Timestamp, batchId: Long = NOT_SET)
class FileStreamSourceLog(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65365/
Test PASSed.

Test build #65368 has finished for PR 13513 at commit cb4194e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65368/
Test PASSed.

Test build #65547 has started for PR 13513 at commit be1abfa.

Test build #65547 has finished for PR 13513 at commit be1abfa.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65547/
Test PASSed.

Test build #65628 has started for PR 13513 at commit bddbc7f.

Test build #65628 has finished for PR 13513 at commit bddbc7f.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65628/
Test FAILed.

Test build #65631 has started for PR 13513 at commit 84d3d27.

Test build #65631 has finished for PR 13513 at commit 84d3d27.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65631/
Test PASSed.

LGTM. Thanks! Merging to master and 2.0.


feat: Added dropdown button

:tada: This PR is included in version 1.0.0-fix-doc-release.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Separate GPAC and consensus

Some tests check only in one peer from peerset if a change is applied. Instead, we should check if all peers from peerset have applied this change. Let's change it in this PR.

Let me know if there are other tests which have to be changed


Cognitive Services: Custom Vision - Unclear documentation - GetIterationPerformance RestAPI

Is your feature request related to a problem? Please describe.
There's no explanation of the possible/default values of the parameters used in GetIterationPerformance, in particular threshold and overlapThreshold.
For example:
threshold (optional)    number    Format - float. The threshold used to determine true predictions.

What's the range of the threshold 0-100, 0-1?
This issue where there's no description of the default and accepted values for parameters seems to be an issue seen across the whole Python SDK/API documentation, e.g. this example.
Describe the solution you'd like
A clear and concise description of the default and accepted values for GetIterationPerformance and ideally for all optional parameters across the several versions of the documentation Python SDK/Rest API, etc....
ps.- After double-checking I fear that this might not be the best place for this ticket as it refers to the RestAPI instead of the Python SDK. Please do feel free to push me in the right direction.

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Cognitive Services:0.12460461,Docs:0.06039851,KeyVault:0.05489946'

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Docs:0.18423106,Cognitive Services:0.13722889,KeyVault:0.026460405'

@agonzalez-mob thank you for your inquiry. Someone from the CXP team will route your question to the appropriate service team.

@agonzalez-mob Thank you for reaching out, we are looking into it.

@RakeshMohanMSFT thank you. I just modified the question a bit to include overlapThreshold in the example given in the original question.


Material 3 navigation drawer

issue: #103551
created from #113894 to avoid a CLA check issue.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

https://user-images.githubusercontent.com/108393416/199583485-06d81d18-9cfa-44d8-8462-07f19b85f602.mov
If you need help, consider asking for advice on the #hackers-new channel on Discord.

is it possible to have the Badge label


start refactor

this begins a refactor that:

renames the data module to io
renames the data_store to datasets
moves the Community class and datasets to the top-level

todo:

[ ] redo test suite
[ ] update docs

because i dont want them to show up in tab completion

(otherwise e.g. you'd get both geosnap.community and geosnap.Community when you tab)

i want to trigger a travis build, so i'll do the docs in a separate PR

tests pass locally but i cant get the build to trigger on travis...

.travis.yml https://github.com/knaaptime/geosnap/blob/refactor_data/.travis.yml#L39 also needs to be changed to accommodate the API change

The travis CI seems to have not been triggered for the past three months. The last CI build on the master branch was from PR https://github.com/spatialucr/geosnap/pull/130

good catch. Looks like @suhanmappingideas got one to trigger from the vizsu branch and that seems to have gotten things moving. how strange

I reworked the tests and CI config so that as long as you have the LTDB and NCDB environment variables set, tests should pass on forks
(everything is passing on mine) this should be ready to go


About pairwise cosface loss  ?

Hi, is there any references(e.g. paper) about pairwise cosface loss ?  The difference between cosface loss and circle loss is just discarding alpha_p/alpha_n?

Check circle loss paper.


Fix principal direction extent

Fixes #1007

@lidakanari , could you please check that with these changes you get the expected results?

Codecov Report

Merging #1008 (b13e977) into master (fdf9f78) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Current head b13e977 differs from pull request most recent head def17d2. Consider uploading reports for the commit def17d2 to get more accurate results

@@            Coverage Diff            @@
##            master     #1008   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           36        36
  Lines         2355      2349    -6
=========================================
- Hits          2355      2349    -6

The function seems to return correct values for the tested cases. However, the signature of what it returns changes with respect to the previous one, as it now returns a vector of the same dimension as the input data. i.e. 2d point cloud returned 3d vector before, now it returns 2d.

Indeed, the dimension of the extents depends on the dimension of the points. Therefore, for 2D points it would return a 2D vector of extents, and for 3D a 3D respectively. For NeuroM purposes, only 3D points are used, so this is not really an issue.

Ok, that should be good. Also something to keep in mind, currently the extents are not sorted (i.e. largest to smallest). If this is by choice, it would be good to mention in documentation because it might be confusing.

That's true indeed. There was no requirement that they are sorted from max to min, which imho renders the direction argument a bit useless in the respective feature.
Should I order them?