Helm chart change in dnsPolicy might be breaking for AWS Fargate users

Description
How can the docs be improved?
Hi I would like to ask maintainers to improve installation / upgrade guide about recent change in v0.34.0 to dnsPolicy in Helm chart (https://github.com/aws/karpenter-provider-aws/issues/4947). This change is breaking for anyone running AWS EKS cluster with Fargate profile to host only Karpenter controller. In this scenario Karpenter will end up in crash looping state with following error:
{"level":"FATAL","time":"2024-03-08T22:41:14.975Z","logger":"controller","message":"Checking EC2 API connectivity, WebIdentityErr: failed to retrieve credentials\ncaused by: RequestError: send request failed\ncaused by: Post \"https://sts.us-east-1.amazonaws.com/\": dial tcp: lookup sts.us-east-1.amazonaws.com: i/o timeout","commit":"cd02bab"}

I would say use of Fargate is quite common for operators who don't want to have special process for upgrading initial node pool and use of dnsPolicy: Default option should be really well documented as Karpenter will no longer start with current Helm chart compared to previously released versions. Issue happens in scenario when Karpenter starts on EKS cluster without nodes and should provision initial EC2 instances for kube-system so core-dns and other controllers starts after Karpenter. This is usually the case when your kube-system contains other privileged containers (cilium, metrics-server, etc.) and it's unfeasible to create & manage individual Fargate profiles for each component.
Proposed improvements:

Include error above in troubleshooting guide with dnsPolicy: Default fix
Include note in installation guide for users who wants to use AWS Fargate that this option must be set if you plan to host only Karpenter controller on AWS Fargate without core-dns. This prevents confusion for new adopters that follow installation guide and gets crashlooping container at the end.
Include note in upgrade guide that this is breaking for AWS Fargate users who use Fargate only to host Karpenter controller (current statement about dual-stack clusters / service meshes is completely misleading and seems harmless as most operators do not explicitly set injection label for service mesh to kube-system or similar namespaces and AWS EKS clusters doesn't support dual-stack at this moment). Karpenter will be in CrashLooping state even if core-dns is already hosted on EC2 instance and available.
Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

and it's unfeasible to create & manage individual Fargate profiles for each component

Just curious about this. Couldn't you create a Fargate profile that just selected on the core DNS application so that core DNS was up when you started Karpenter? You shouldn't need a different Fargate profile for all of the components.

should be really well documented as Karpenter will no longer start with current Helm chart compared to previously released versions

We went back and forth and ultimately decided to go with the Kubernetes default ClusterFirst as the default installation for Karpenter since we believed that this would be the least surprising configuration for users (#4947). As you can see there's been a lot of back-and-forth discussion on which one is the "right" configuration from Karpenter, but ultimately we decided that users who were using ServiceMeshes with Karpenter were more surprised by this change

Include error above in troubleshooting guide

Noted. We'll open a PR to add some more verbose lingo to the TS guide

Include note in installation guide for users who wants to use AWS Fargate that this option must be set if you plan to host only Karpenter controller on AWS Fargate without core-dns

I'd agree that we may also want to callout the case where you aren't running any cluster DNS at all (though I'd imagine that this kind of setup is incredibly uncommon since you are eventually going to want to run something that is going to reach out to a Kubernetes service and is going to need cluster DNS; I'd imagine the much more common setup is the one already called out in the docs, where the DNS is just not running when Karpenter starts up). If you think that we should expand on our existing wording, there is currently a callout made here. We'd happily accept a docs PR if you had ideas around how to improve this wording.

Karpenter will be in CrashLooping state even if core-dns is already hosted on EC2 instance and available

This isn't true as far as I'm aware. Assuming that the core-dns pods are already up and running, Karpenter can run with a ClusterFirst DNS policy on Fargate and this should be the default setup unless you are planning to have Karpenter manage your cluster DNS capacity under-the-hood.

Include note in upgrade guide that this is breaking for AWS Fargate

Noted, the PR that updates the documentation for the TS item will also include this.

Hi @jonathan-innis thanks for reply.

Just curious about this. Couldn't you create a Fargate profile that just selected on the core DNS application so that core DNS was up when you started Karpenter? You shouldn't need a different Fargate profile for all of the components.

You are right that I can technically create second Fargate profile that selects core-dns. For my use case it also means going through security exception process as pods running on Fargate bypass security scanners and this is hard to sell to security team as we have commercial and FedRAMP environments. So far Karpenter is only deployment that got security approval to do this on commercial setups as benefits were too hard to ignore.

We went back and forth and ultimately decided to go with the Kubernetes default ClusterFirst as the default installation for Karpenter since we believed that this would be the least surprising configuration for users (https://github.com/aws/karpenter-provider-aws/issues/4947). As you can see there's been a lot of back-and-forth discussion on which one is the "right" configuration from Karpenter, but ultimately we decided that users who were using ServiceMeshes with Karpenter were more surprised by this change

I'm fine with the change. I just pointing out that upgrade guide for 0.34.x should call this out as breaking for this setup.

If you think that we should expand on our existing wording, there is currently a callout made here. We'd happily accept a docs PR if you had ideas around how to improve this wording.

Thanks for pointing out this is already done and I just haven't noticed this.

This isn't true as far as I'm aware. Assuming that the core-dns pods are already up and running, Karpenter can run with a ClusterFirst DNS policy on Fargate and this should be the default setup unless you are planning to have Karpenter manage your cluster DNS capacity under-the-hood.

I've bumped into this when attempting to upgrade existing cluster that was in healthy state. I can try to investigate more today to check if this is related to running core-dns on EC2 and Karpenter on Fargate.

@jonathan-innis - I've managed to test both setups today with following results:

coredns runnning on EC2 + Karpenter on Fargate
This setup works only with Default dns policy. If ClusterFirst is used Karpenter will end up in crashlooping state.

coredns & karpenter both running on Fargate
This setup works with ClusterFirst policy and both components start fine.

Based on AWS steps to reconfigure coredns for Fargate it feels like there is some kind of isolation explaining why mixed setup works only with Default policy.


Need to keep function  PollLongRunningOperation, in common place for InstanceAdmin and TableAdmin

Need to keep function  PollLongRunningOperation, in common place for InstanceAdmin and TableAdmin

Tried to find any existing file where I can fit this API, accessible for both table admin and instance admin, but did not find that, then I started writing new header file with this API as below signature.
template <typename ResultType, ClientType>
ResultType PollLongRunningOperation(std::shared_ptr client, std::unique_ptr polling_policy ,MetadataUpdatePolicy metadata_update_policy_, google::longrunning::Operation& operation,
char const* error_message,
grpc::Status& status) {
}
But  when I use to call above API from bigtable table admin, I am facing compilation error as below, when client  try to access  GetOperation()  , I tried few approaches but did not get any luck.
error: ‘virtual grpc::Status google::cloud::bigtable::v0::AdminClient::GetOperation(grpc::ClientContext*, const google::longrunning::GetOperationRequest&, google::longrunning::Operation*)’ is protected
may be I am going in wrong direction or missing some small thing, So if  you can suggest something,

error: ‘virtual grpc::Status google:cloud:bigtable::v0::AdminClient::GetOperation(grpc::ClientContext*, const google::longrunning::GetOperationRequest&, google::longrunning::Operation*)’ is protected

I think we fixed those with a suitable application of friend in some places.


AverageTFR.apply_baseline return self

Is there a reason for AverageTFR.apply_baseline not to return self, like all other instance methods that modify the instance? If not, this makes it return self.

Current coverage is 87.29% (diff: 100%)

Merging #3559 into master will decrease coverage by <.01%

@@             master      #3559   diff @@
==========================================
  Files           341        341
  Lines         60067      60068     +1
  Methods           0          0
  Messages          0          0
  Branches       9174       9174
==========================================
- Hits          52439      52437     -2
- Misses         4884       4887     +3
  Partials       2744       2744

Powered by Codecov. Last update 8ea7206...419ac46

thx @jona-sassenhagen

thanks @agramfort


User Login is needed after checkout 03-database-and-backend

where:
i am in this Tutorial:
https://vaadin.com/learn/tutorials/modern-web-apps-with-spring-boot-and-vaadin/vaadin-grid-adding-data-and-configuring-columns
i checked out the crm-tutorial and run it from the master branch
later i checked out 03-database-and-backend
in the video i can start the app without credentials
on my machine it is redirected to /login but the known combination from final demo user/password is not  working here :(
is there some caching between the branch checkouts?
i did also a mvn clean but there was still the login screen when i started the app (but in sources there was no login screen available):

work around - starting over from scratch:

delete directory
git clone again from github
change branch to 03-database-and-backend
it runs without the login screen

is there some 'magic' caching?
in this case it would be nice to have the tutorial not say:

check out the github without mention to checkout the 01-xxx branch

otherwise i try to checkout and let the app running at first before i continue with the tutorial to have all in place


Using internal or external link, not working

Defining an internal link as such:
            [
                'title'     => 'Menu Item',
                'expanded'  => false,
                'resources' => [
                   'Item Name' => '/item'
                ]
            ],

This causes the menu category to not show up at all. Same thing happens if I change it to
'Item Name' => 'https://www.foo.com'
Am I not understanding the internal / external functionality?

Just tried and yeah its a regression, the way it should work
[
    'title'     => 'Menu Item',
    'expanded'  => false,
    'resources' => [
        'Internal' => '/item', // this opens on the same tab, and no icon is added
        'External' => 'https://...' // this add an extra icon beside the link and opens in a new tab
    ]
],

I will look into it see what went wrong on the latest version

@fbingha fixed on version v0.1.9

Okay it is working now but one more request. I want to use the link to a Nova tool, so I put the path and it works but it browser page reloads since it isn't using the vue route to open the tool. Can you add an option to use a vue route so the single page app isn't broken when following the link?

Looking at the code, going to be a bit more complicated to add links to tools as they will also need to respect permissions. The goal is to remove the links that tools add and just have navbar entries from this tool. If the config could support (a) being told what permission(s) to check and (b) what vue route to load then I think it could be done without knowing anything specific about the tool being linked to.

Another way to do this requires changing nothing in the config.
I created resources for each of my tools so that permissions and uriKey could be utilized. The only issue is in ResourceList.vue. When a resource is found, it is assumed the the 'index' route is to be used for the resource.route. So just need away to have the :to{} params name and params links be read from the resource object.
:to="{ name: resource.link , params: resource.params  }

I made some quick hacks to my branch https://github.com/fbingha/collapsible-resource-manager
Here, I already had "fake" resources for my Tools as I was already putting them into the sidebar along with other resources that they grouped with. I use view overrides to remove the normal navigation links that tools put into the sidebar.
So in my "fake" resources, I added a two class variables:
public static $nonIndex = true;

public static $params = [];

The first tells your tool not to use the index route, instead use the urikey as the route and second a params in the event the route has params, which some of mine do.
With this, I now have all of the tools in the menu where they belong.
Using the fake resource also allows me to use the existing permissions check.
I still think it would probably be easier for you to adjust your config so that with the resource group one could provide the route name, the params, and the permissions to check and not create a fake resource as I have done.

@fbingha Im looking into your fork, I am not sure why you changed this if condition with index/params: https://github.com/fbingha/collapsible-resource-manager/blob/master/src/CollapsibleResourceManager.php#L111
The way im seeing it working would be something along this line:
'resources' => [
    \App\Nova\Page::class,
    'Internal Link' => '/custom/route',
    'Tool' => [
        'params' => [ 'a' => '123'] ,
        'name' => 'yyy'
     ]
],

which would then be given to the route-link like this:
<router-link :to="{ name: resource.name, params: resource.params }"/>

But what im unsure is how a user would know the route name/params of a tool without digging up the package and figuring it out on their own?

And the permission could also be solved by perhaps sending the tool class itself to the config:
'resources' => [
    \App\Nova\Page::class,
    'Internal Link' => '/custom/route',
    'Tool Label' => [
        'tool' => ToolName::class,
        'params' => [ 'a' => '123'] ,
        'name' => 'yyy'
     ]
],

With this approach would also allow users to create internal links that don't go to index listing page but perhaps detail, or edit.
'resources' => [
    \App\Nova\Page::class,
    'Internal Link' => '/custom/route',
    'Resource Label' => [
        'resource' => ResourceName::class,
        'params' => [ 'resourceName' => ResourceName::uriKey(), 'id' => 3 ] ,
        'name' => 'detail'
     ]
],

It`s a bit verbose and requires the user knowing all the underlying params but given enough examples one could find a way around it ...

Looks good to me

@fbingha the new version supports everything you were trying to do on your branch v1.0.0 🎉


'no props' component factory doesn't seem to work

For instance, i'm using semantic ui react.
...
(:require ["semantic-ui-react" :as sui-react]
....

(def Button (uc/component-factory-simple sui-react/Button))

; in my component
 (sui/Button {} "Hi") ; is fine
 (sui/Button "Hi") ; doesn't render the button content

Please use the slack channel for support :)

Confirmed.  The no-args version should pass empty props, but still pass children.

Didn't you patch this back in August?


Tag  Breaks HTML component

I'm on version 4.2.2-beta.2 and if you pass a paragraph in the follwing format

"He said hello"

the whole things breaks on Android, saying that old Yoganode problem like the link below shows on S.O.
https://stackoverflow.com/questions/46605376/react-native-cannot-add-a-child-that-doesnt-have-a-yoganode-or-parent-node
Here is a snippet for a component that you can create to reproduce, the HTML variable content is the paragraph code above
The renderer is not an issue in the case, I tested and I can provide if you want to check, but I tested this extensively and nailed it down to the  tag
Is there a workaround for this? I'm going to fix this case by manually removing the unsuported tag with string.replace
Also, would be great to know about more compatibility restrictions like this case of mine.
return (     <View style={{ paddingTop: 16 }}>        {           return <Text textBreakStrategy="simple">{content}</Text>;         }}       />     </View>   );
PS: sorry about the indentation above, not sure why it did not work.

@gabriel-tentaculo Next versions will be much better regarding this kind of issue:

We will document an exhaustive list of supported tags;
We will warn the user of unsupported tags, unless he provides a list of stripped tags or chooses to remove warnings altogether.

I would need a full reproduction to investigate your issue more closely. I tried the following code, and it didn't crash:
import * as React from 'react';
import {ScrollView, StyleSheet} from 'react-native';
import HTML from 'react-native-render-html';

const html = '
"He said hello"
';

export default function App() {
  return (
    <ScrollView contentContainerStyle={styles.container}>

    </ScrollView>
  );
}

const styles = StyleSheet.create({
  container: {
    flexGrow: 1,
  },
});

Note: Latest version is 4.2.4, but I don't think that would make a difference.

@gabriel-tentaculo In the meantime, you can create a block custom renderer for cite tag.

Hi @jsamr thank you for the fast response and the suggestion to use the custom render, it actually makes a lot of sense to use that approach, but I wonder what is it that I would have to fix to make that YogaNode error go away since I could not see any output on that page because the page component itself (parent component to the HTML component) did not render.
Do you have any suggestion maybe for a common case when custom tags are used and there is no custom render to display it?
Also, when I get back to fixing this during this week, I'll get more details for you to reproduce and I'll also try the latest version...

Quick update on this, updating from ^4.2.2-beta.2 to 2.2.4 did not solve the issue.
I'll get back when I have more details

@gabriel-tentaculo I'll be happy to take a look when you find the time for a repro :-)

Sure thing @jsamr
In the meantime, more feedback and a question for you.
So, I was not able to make a custom renderer for this cite tag to start working.
Since I did not figure out a way to view what exactly is going to be the output of the html that contains that tag ( cite is actually nested in a h3 tag in this context) I could not guess what has to be done to create the custom renderer... I tried wrapping the children of the cite tag in a text component and also in a view but the error is the same

cite: (htmlAttribs, children, convertedCSSStyles, passProps) => {
return {children};
},

Now to my question,
I have tried also using IGNORED_TAGS but what happened in this case was that the entire paragraph where the tag is gor removed or if it did render I could not see it.
Whats the intended behaviour for the ignored tags?

This issue has been fixed in the Foundry release. Try it out now! See #430 for instructions.


option to make training more deterministic

#114 #140
I have been trying to make it more deterministic, here I share some of my experiences.

replace these lines with

torch.backends.cudnn.deterministic = True
torch.backends.cudnn.benchmark = False # this should be False instead of True(current code)
torch.use_deterministic_algorithms(True) # will raise an error when nondeterministic functions are used.

check https://pytorch.org/docs/stable/notes/randomness.html#cuda-convolution-benchmarking for more details

you may need to run the program with flag CUBLAS_WORKSPACE_CONFIG=:4096:8, if some error is raised after doing 1, check here for details

replace the bilinear F.interpolate here with the implementation below, as it is nondeterministic, check here fore details.

class Interpolate(nn.Module):

    def __init__(self, channel: int, scale_factor: int):
        super().__init__()
        # assert 'mode' not in kwargs and 'align_corners' not in kwargs and 'size' not in kwargs
        assert isinstance(scale_factor, int) and scale_factor > 1 and scale_factor % 2 == 0
        self.scale_factor = scale_factor
        kernel_size = scale_factor + 1  # keep kernel size being odd
        self.weight = nn.Parameter(
            torch.empty((1, 1, kernel_size, kernel_size), dtype=torch.float32).expand(channel, -1, -1, -1)
        )
        self.conv = functools.partial(
            F.conv2d, weight=self.weight, bias=None, padding=scale_factor // 2, groups=channel
        )
        with torch.no_grad():
            self.weight.fill_(1 / (kernel_size * kernel_size))

    def forward(self, t):
        if t is None:
            return t
        return self.conv(F.interpolate(t, scale_factor=self.scale_factor, mode='nearest'))

    @staticmethod
    def naive(t: torch.Tensor, size: Tuple[int, int], **kwargs):
        if t is None or t.shape[2:] == size:
            return t
        else:
            assert 'mode' not in kwargs and 'align_corners' not in kwargs
            return F.interpolate(t, size, mode='nearest', **kwargs)

However, the training is still non-deterministic
As the raymarching_train here is non-deterministic, I am not familiar with CUDA extension, thus I don't know how to solve it, you might want to look at it, the rays outputted by the function is non-deterministic.
Here I provide a bash script test.sh to run deterministic experiments for  debugging
gpu_id=$1
echo "Running on GPU $gpu_id"
rm -rf "results/squirrel_seed0_size64_deterministic_run$gpu_id"
rm deterministic_run_$gpu_id.txt

CUDA_LAUNCH_BLOCKING=1 CUDA_VISIBLE_DEVICES=$gpu_id python main.py \
--text "A DSLR photo of a squirrel" \
--cuda_ray \
--fp16 \
--dir_text \
--sd_version "2.0" \
--eval_interval 1 \
--seed 0 \
--iters 20 \
--workspace "results/squirrel_seed0_size64_deterministic_run$gpu_id" > deterministic_run_$gpu_id.txt

run bash test.sh 0 and bash test.sh 1 to run on GPU 0 and GPU 1, and compare the output in deterministic_run_0.txt ,deterministic_run_1.txt ,

Thanks for your efforts! Making it deterministic must be quite hard...
For the ray marching extension, it involves race conditions for each ray to be written to the output, but the overall outcome should be the same. i.e., the point-wise results are different, but ray-wise results are the same:
# run 1
xyzs: [ray1's points] [ray2's points] [ray3's points] (point-wise, order of rays may vary)
colors: [ray1's color] [ray2's color] [ray3's color] (ray-wise, always ordered)
# run 2
xyzs: [ray3's points] [ray1's points] [ray2's points]
colors: [ray1's color] [ray2's color] [ray3's color]

So I guess there may be some other reasons. Also, you could first check if the non-cuda-ray mode can be deterministic.
Currently I'm not having enough resources to test, but I may help to check it later.


system-container: change repo for CentOS

update the repository used by the system container to find the RPM for CentOS.
Signed-off-by: Giuseppe Scrivano<EMAIL_ADDRESS>

@lsm5 it seems we still need to add the runc, skopeo and skopeo-containers rpms, otherwise the correct versions needed by CRI-O are not found.

@lsm5 Can you confirm that it looks good?

@lsm5 argh obviously, it was some copy&pasta.  Not sure why the centos cbs build is failing with the previous verison, but I've tried to build locally the updated version and all the .rpm are coming from https://buildlogs.centos.org/centos/7/virt/x86_64/container, also the outdated cri-o

@giuseppe Are you going to combine those two lines?

@lsm5 I've pushed a new version with only one repo, as we don't install cri-tools

@giuseppe Still failing travis? Do we need to run E2E tests on this?

looks like a flake, restarted.  This PR should not make any difference both for Travis and E2E tests

LGTM


Feature Request: Customizable keyboard shortcuts

It would be great if you could provide a method to modify keyboard shortcuts. I'd prefer to set "Close window" to Ctrl + W as an example.

Yes, I can understand where that would be useful but I am not necessarily sure its practical. It would be quite a lot of work and might be awkward looking up a table every time a key is pressed in case its mentioned in the current shortcut table.  I'll have a think about it but I am a bit worried it might just be too hard to do without slowing us down more than I care to permit.
Davo

I have looked over my code and, sorry, I really cannot justify the performance penalty that this would involve. I might revisit it if I find a better way to handle the problem but afaid, right now, its a "no".
Davo


Fix newly found issues due to latest changes

Change summary:

Fix circular node module loading issue
Fix start node script argument number issue

Related issues:

https://github.com/ainblockchain/ain-blockchain/issues/1216
https://github.com/ainblockchain/ain-blockchain/issues/1217

Thanks for the review! @jiyoung-an Now merging..


No radio button, checkbox or icon is visible

Hi there, this theme is really good, but I dunno why it's working not well on my computer. pls see the screenshot below and tell me what's possibly wrong? I uninstalled and reinstalled but still no luck.
thx!

Sorry for the late reply.
I think this issue relate #35.
If you are using a qt version lower than 5.12 try updating.

Hi. I got the same problem with qt 6.4.1, PySide6, python3.7.
I checked svg urls in the translated stylesheet and they do exist in cache folder.
BTW qdarkstyle's icons works correctly.
Thanks.

@MrkKSen
Thank you for the report.
Can you show me how to install python and PySide6?
I could not replicate this issue on my Windows 11.
qdarkstyle uses png. qdarktheme uses SVG, so I think there is a problem with the use of SVG.

Also, what is your qdarktheme version?

Thank you for response.
I am using conda envrinment, and install PySide6 with pip. qdarktheme version is 2.0.0.
I just created a new conda env, install PySide6 and qtdarktheme and ran demo, and icons just appeared!
So there maybe something wrong with the former env. (Although I had reinstalled Pyside6 and qtdartheme...)
I'm going to install other packages I need, if the same issue came up at some point, I would report again.
Sorry to bother you, and thanks for the wonderfull theme!

Thanks for this theme @5yutan5
I also have a problem with radio buttons not rendering, but only in Linux Gnome. In Windows 10, the radio buttons render correctly.
The solution from PySide6.QtSvg import * from #35 does not help.
pyqtdarktheme             2.1.0         Flat dark theme for PySide and PyQt.
pyside6                   <IP_ADDRESS>       Python bindings for the Qt cross-pl...
pyside6-addons            <IP_ADDRESS>       Python bindings for the Qt cross-pl...
pyside6-essentials        <IP_ADDRESS>       Python bindings for the Qt cross-pl...


Breaking change in 3.1.5, profiles with periods no longer work when label not specified

Describe the bug
Version 3.1.5 introduces a breaking change: profiles with periods in them are no longer accepted when label is not specified
This commit is likely the cause: https://github.com/spring-cloud/spring-cloud-config/commit/10546f52ab5ae9a4c7017d57dce8a5ec509cfc32
After this, the defaultLabel() endpoint is no longer hit, and 404 is returned
Sample
This can be replicated by making any call with a period in the profile and not supplying a label, for instance:
http://localhost:8100/project/my_profile.com

fyi @woshikid

Yes, that commit caused this problem.  But my_profile.com is more like a file name. The regex [^\\.]* excluded profiles with file extensions because we didn't expect a . in the profiles. Although we can rollback this commit to fix this issue, but I think it's risky to use . in profile names. Many logics depends on code like String.indexOf(), that will cause unexpected problems.

Thanks for the info @woshikid ! Since this is breaking backwards compatibility for certain behavior however, could this change be reverted in version 3, and wait until in version 4?  It is currently blocking us from any future updates. Thanks

The @GetMapping regex expression used to exclude profile names with -. After some fixes we can now support - but unfortunately the . is no longer supported. I understand your situation, but in my opinion, it's easier and safer to change the profile names than update the dependences. Because some bug fixes in these releases also causing incompatibilities. Another reason is that it is difficult to support both - and . in profile names. As I mentioned above, if this change if reverted, some urls or file paths can cause ambiguity. So, at this moment, we have to find some workaround instead of rolling back.

@woshikid thank you very much for the responses to this ticket, I worked with @bencelsi-okta and our team is in charge of the CCS deployment at Okta. I understand that CCS needs to make a compromise on what it can support, at our team we have been hit with both breaking issues. Once we updated to a version that remove the support for dashes in the name - so to be able to take the version we made sure no dashes are set in our profile names. Now with the latest update we found out that . dots are not longer supported, we had to revert to upgrade to the latest library due to this issue, our worry is if this version is maintained and gets a security update of any sort we won't be able to get it and instead we will have to fork since the number of profiles to update to be compliant with the new version is massive and affects many teams.
The ask would be if possible to remove this breaking change from this version and instead bring it in a major version (4.x), we will plan the 4.x upgrade with this in mind but in the meantime we will continue be able to leverage 3.1.x updates.
Let us know if this is something that can be done. Thank you again!

I am going to revert the breaking change.  . are valid characters in profile names.  I understand that profile names with both - and . will cause some ambiguity in the controller, but that is going to be more rare than containing either a . or a -.

I think it's OK to revert the change. Now we need to be more careful dealing with profile names. BTW, do . also valid in application names?

Thank you!


Update web platform tests

This is an automated pull request for updating the WPT

Is this correct? There is a reference to a README file... and it seems to move all the about:blank to null.
If it is correct, then please merge, but it looks a bit strange.

@lemire This is the relevant change: https://github.com/web-platform-tests/wpt/commit/6d461b4ddb2f1b8d226ca6ae92e14bbd464731a5. I will take a look at it in depth.

I think you are concerned about these lines, right?

I expect that the null bases are not much of a problem... we can do if(element["base"].is_null()) {, so that's fine.

I'm working on updating the web platform test script to work with this change. I'll commit shortly...

I'm closing this to trigger a new branch for the script.


Cleanup documentation HTML structure

Cleanup documentation HTML structure, fixing invalid element nesting etc.

Started from wrong branch


Get rid of cart-after-itemchanged event

What is the motivation / use case for changing the behavior or adding new feature?
We are slowly moving to more reliable and easier to debug architecture which includes removing event-based scenarios.

The task here is to rewrite all cart-after-itemchanged event-based functionalities to ones relying on Vue reactivity system and Vuex. The cart object should only change in Vuex and components (like product.js) should be just displaying the Vuex state.
These are the files that are relying on this event (may be some more)

Acceptance criteria

[ ] Remove cart-after-itemchanged event-based behavior
[ ] Use native vue reactivity instead

The main reason for having this event is to update the microcart information adding info about stock etc and were emitting this event to do forceUpdate on the micro art product item. So maybe just using Vue.set instead would have solved the initial issue which caused adding this event

@vaggelisk, are you still working on this issue? I'd like to work on it.

@diboy2  after a discussion with a main contributor, he informed me that the issue is quite difficult, so I started to work with another.


Adding ability to configure the minimum width/height of image container

I've been working on a little app that uses cropper multiple times on small thumbnails on a page (250 x 375) and so I needed to be able to change these values. I'm not sure if this is the way you'd go about it, but at the moment you can't use cropper successfully on anything smaller than 300px height or 150px width.

Thank you very much!

That's OK, :+1:


GUVNOR-2342: added tests

Hello, license needs updating and IMO the test would be better if it verified after each view.set call - otherwise we're not verifying which call set the footer to which value.

@manstis you are right, I will fix it today.

+1 to merge.

master: d64d8f6e51da915cc359685bc360ba6901646dfa


feat: generate starter checkfile based on provided wasm module

One side-effect of the yaml serializer is that sequences are always written out to their own lines, vs in-line such as [I32, I32].
@zshipko - maybe you could take a look at this and see if there's something we can do as far as a custom Serialize impl somewhere? I tried to do one on a newtype for Vec<ValType> but realized there would be some significant re-typing of the ImportItem etc to use this type instead.
It's not the end of the world, but I think it clashes a bit with the "recommended" way we are demonstrating checkfiles in vendors... plus, it kind of diminishes the time savings of generating the file if end-users have to reformat their yaml... idk.
There is a example generated file in test/generated.spidermonkey.mod.yaml

After giving it some thought, this is a file meant for computers to check...ideally a human spends hardly any time in it at all. So, for the time being I think it's worth more to make it available, and less to optimize for this formatting concern.
:shipit:


[python-package] ignore some mypy errors in _DaskLGBMModel

Contributes to #3867.
Resolves the following mypy errors.
python-package/lightgbm/dask.py:1037: error: "_DaskLGBMModel" has no attribute "_other_params"  [attr-defined]
python-package/lightgbm/dask.py:1066: error: "_DaskLGBMModel" has no attribute "get_params"  [attr-defined]
python-package/lightgbm/dask.py:1089: error: "_DaskLGBMModel" has no attribute "set_params"  [attr-defined]
python-package/lightgbm/dask.py:1095: error: "_DaskLGBMModel" has no attribute "get_params"  [attr-defined]
python-package/lightgbm/dask.py:1104: error: Item "_DaskLGBMModel" of "Union[_DaskLGBMModel, LGBMModel]" has no attribute "get_params"  [union-attr]

Those errors all come from the fact that _DaskLGBMModel is used as a mixin alongside lightgbm.sklearn.LGBMModel...
https://github.com/microsoft/LightGBM/blob/1585ee1566631fca55cd3a391074f807b21bf9b5/python-package/lightgbm/dask.py#L1111
... and references methods and attributes that it expects to come from lightgbm.sklearn.LGBMModel
https://github.com/microsoft/LightGBM/blob/1585ee1566631fca55cd3a391074f807b21bf9b5/python-package/lightgbm/dask.py#L1098
There is in theory a way to handle this situation with typing.Protocol (https://mypy.readthedocs.io/en/stable/more_types.html#mixin-classes), but I couldn't figure it out tonight. So for now, given that these methods are all covered well by the many unit tests, this PR proposes just ignoring these errors from mypy.

thanks for the reviews on all these @jmoralez ! I swear we're getting closer to having everything type-annotated and fully enabling mypy 😅


Logo

add a nice new logo!!

update Readme & docs
use a new theme for GitHub Pages

Codecov Report

Merging #48 (5a640df) into dev (55d9494) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev      #48   +/-   ##
=======================================
  Coverage   84.23%   84.23%
=======================================
  Files           9        9
  Lines        3667     3667
=======================================
  Hits         3089     3089
  Misses        578      578

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55d9494...5a640df. Read the comment docs.


ApiManagement: Add support for Backend Entity

Add support in Swagger for Backend Entity.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[x] My spec meets the review criteria:

[x] The spec conforms to the Swagger 2.0 specification.
[x] Validation errors from the Linter extension for VS Code have all been fixed for this spec. (Note: for large, previously checked in specs, there will likely be many errors shown. Please contact our team so we can set a timeframe for fixing these errors if your PR is not going to address them).
[x] The spec follows the patterns described in the Swagger good patterns document unless the service API makes this impossible.

This change is

      "default": "true"

value must be true instead of "true"!

Refers to: arm-apimanagement/2016-07-07/swagger/apimmanagement.json:4941 in e42d614. [](commit_id = e42d614b82944dc54cdc4a2d6ee6c4172b529df0, deletion_comment = False)

      "default": "true"

#fixed

In reply to: 261625613 [](ancestors = 261625613)

Refers to: arm-apimanagement/2016-07-07/swagger/apimmanagement.json:4941 in e42d614. [](commit_id = e42d614b82944dc54cdc4a2d6ee6c4172b529df0, deletion_comment = False)

please also fix the file name (see #684)

Fixed issue https://github.com/Azure/azure-rest-api-specs/issues/684

@fearthecowboy  @olydis can you take a look?

No modification for Python

No modification for NodeJS

No modification for Ruby


Enable move semantics for socket types

Description
This one wasn't entirely trivial because I had to write custom move operations for sf::Socket to ensure that a socket isn't closed after it's moved-from. The move operations ensure that the moved-from socket is given an invalid socket handle so that when close is called nothing happens. Enabling move semantics for sf::Socket had the downstream affect of enabling move semantics for 3 different derived classes. It's great how the type trait tests so easily detect and confirm that fact.
As a prerequisite I wrote up some sf::Socket tests since this class was lacking any.

I included the Clang CI fix in this PR because other CI is guaranteed to fail. See #2661 for more information.

I included the Clang CI fix in this PR because

You can edit this PR base branch to clang_ci_workaround to make the changes more specific. It will become master again automatically once clang_ci_workaround gets merged.

I removed the CI failure workarounds from this PR since it appears that GitHub has fixed the issues.


[IMPROVEMENT] Area for long-press context-menu too small

Your Rocket.Chat.Android version: 2.0.0-rc1
Mobile device model: Xiaomi Redmi Note 3 (kate)
OS version: Lineage OS 14.1, latest nightly
Description (screenshot below description)
Right now the context menu for long-pressing a message (e.g. to react with an emoji or to "reply") is only working for the green area. If I long-press the red area I would expect the same to happen, but it's just not happening anything (except for the light grey which indicates I'm pressing)
Especially with one-line messages the green area is pretty hard to "hit" (at least with my "sausage-fingers", as we say in Germany).
Concerning the blue area (which seems to be a quote, right) I'm not quite sure whether the user would expect that his long-press refers to the post containing the quote or the original quote...
Screenshot

BTW: The mattermost Android App has this issue, too, so this is the time to leave them behind ;)

Closed by #1227

Ahhhh... finally possible :tada: :)


Cancel an upload request

Hello,
I used Dropbox Javascript API, for uploading files. Here is my code :
let promise = this.dropbox.filesUpload({path: path + file.name, contents: file})
                .then(function(result)
                {
                     // Success workflow goes here ...
                })
                .catch(function(error) {});

I would like to implements a cancel button. When I clicked it, I would like to my promise request above was aborted.
I read this trick #159 but how can implement it directly with Dropbox JS SDK ?
I also find this way for cancelling fetch request with the AbortController.abort() : https://stackoverflow.com/questions/31061838/how-do-i-cancel-an-http-fetch-request
but it's not possible pass fetchOptions in Dropbox.filesUpload() method.
Does anyone have a solution for this issue ?
Thanks you in advance !

The Dropbox JavaScript SDK doesn't offer a way to cancel uploads like this, but I've sent it along as a feature request.

Maybe wrap the whole call in a worker?

There may be ways to do this outside the SDK itself, but I'm afraid I don't have any information to offer on unofficial methods like that.

Hey @greg-db - It looks like current support for AbortController (https://caniuse.com/#search=AbortController) is pretty good - if there were some way to pass a signal as fetchOptions it seems this could work.

@elsigh Thanks for the information! I'll pass this along.

I think this is an important issue, It's mandatory to cancel a request, Hope to get some news soon.

@ImSolitude Thanks for the feedback. I don't have any news on this right now, but I'll follow up here if/when I do. I can't make any promises or offer a timeline though.


[BUG] Device.isClosed() not Returning True for Oak1 PoE device when pulling network cable.

Check if issue already exists
I have not been able to find related results on google.
Erik on the Discord channel requested I make a bug report here.
Describe the bug
The isClosed() method does not provide the desired results when testing with a Oak PoE network camera.  When I pull the network cable while it is running this method does not return true.  Performing the same test with an Oak1 USB camera returns True as expected.
Minimal Reproducible Example
import time
import depthai as dai  # depthai - access the camera and its data packets

def connect_and_process():
    with dai.Device(dai.Pipeline()) as device:

        while True:
            if device.isClosed():
                print("Camera Disconnected!")
                quit()

            print("Camera Connected...")
            time.sleep(1)

connect_and_process()

Expected behavior
Print out "Camera Connected..." until you physically pull the network cable from the camera, at which point it prints "Camera Disconnected!".
Screenshots
The following screenshot demonstrates the issue.  You can see the point the network camera was disconnected by the depthai log stating a ping was missed.

The following is the same code running with a USB camera connected:
/home/andrew/code/PythonEnvs/DepthAI/bin/python /home/andrew/code/IsConnectedTest.py
Camera Connected...
Camera Connected...
Camera Connected...
Camera Connected...
Camera Connected...
Camera Disconnected!

Process finished with exit code 0

@a3dbox thanks for the writeup
This missed ping should indeed teardown the device and the connection. I'll take a look at this.

@a3dbox
Camera Connected...
Camera Connected...
Camera Connected...
[2023-01-26 19:21:45.303] [warning] Monitor thread (device: 14442C105183A7D200 [<IP_ADDRESS>]) - ping was missed, closing the device connection
Camera Disconnected!

This is on v2.19.1 /w OAK-D PoE - do you mind updating to this version and retesting?

Thanks for looking into this, I will double check versions when I'm back at the office tomorrow.

@themarpe , thanks for you time and I am embarrassed to say although I was working with the latest version on my laptop the testing rig was running from v2.17.  Updating to the latest fixes the issue.
Thanks very much for you time spent, its much appreciated.


[question] LogHandler implementation based on Microsoft.Extensions.Logging

Hi, KafkaFlow deps
Are you interested in a contribution of ILogHandler implementation based on Microsoft.Extensions.Logging ?

Yes, it would be nice.

Sorry, I am still working on the implementation of this.

@filipeesch created PR #258


Code coverage reports for integration tests

When running integration tests, we cannot automatically extract code-coverage statistics, as we do in unit tests.
However, most extensive testing on FSC is performed with integration tests rather than unit tests.
We want to be able to generate (manually for the time being) reports on code coverage of integration tests.

@alexandrosfilios , how can we do this?


bump milvus to 2.0.1, unify chart & operator version to 0.3.6

Signed-off-by: shaoyue.chen<EMAIL_ADDRESS>/cc @zwd1208

/lgtm


Why Listview.builder(itemCount: ?) is nullable and not required?

Proposal

import 'package:flutter/material.dart';
import 'package:turkmenportal/models/rubrica.dart';
import 'package:turkmenportal/presentation/widgets/cat_carousel.dart';
import 'package:turkmenportal/provider/content_list.dart';

class HomePage extends StatelessWidget {
  final Rubrica rubrica;
  const HomePage({Key? key, required this.rubrica}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    PostList post = PostList(rubrica);
    return Column(
      children: [
        CategoryCarousel(
          categories: rubrica.categories,
          selected: post.catIndex,
          changeCat: (int index) {
            PostList(rubrica).changeCatIndex(index);
          },
        ),
        Expanded(
          child: ListView.builder(
            itemBuilder: (context, index) {
              return Container();
            },
          ),
        )
      ],
    );
  }
}

This widget is in the bottom of my Widget tree. When I debuged it didn't showed any warning, error or linting. My phone screen was blank and wasn't any detections or answer. I have searched all widget tree, even I have not felt suspecious for it. I have passed my 5 hour time for it.
If anyone have same problem like this just put itemCount or make it only Listview(childreen: []);
For my opinion it has problem with builder return item doesn't have height and it infinitly build Container() with no height. I suggest for some API comment for warning or throwing Exception('Builder return widget height not specified').
I'm so thankfull 🙌 for Flutter team and controbuters for this open source great framework 🚀.

Hi @MerdanDev, Thanks for filing the issue. Because ListView.builder builds children on demand and can take infinite listItems so item count is nullable and not required.

The ListView.builder constructor takes an IndexedWidgetBuilder, which builds the children on demand. This constructor is appropriate for list views with a large (or infinite) number of children because the builder is called only for those children that are actually visible.

In your code sample, you have a listView of infinite containers, And Container does not have any dimensions specified so a blank white screen is expected.
Closing as this is neither a bug nor a feature request. In case you disagree feel free to write in the comments and we will reopen it.
Thank you

Even I weren't able to hotrestart or hotreload and I has been to flutter run again.

If hot restart and hot reload doesn't work when you made a relevant change in code, then that should be a bug and it should be filed separately with reproducible steps.

if someone has, how to know problem is itemCount specified and Listview.builder is building infinity heightles Container.
I'm just suggessting have little warning or exception in this case!🤷♂

I don't really understand what kind of warning should be shown for a code that is working as intended. Imagine if that is a desired output for someone else and he sees a warning in the console.

If hot restart and hot reload doesn't work when you made a relevant change in code, then that should be a bug and it should be filed separately with reproducible steps.

Actually it's definitely from Listview.builder() without itemCount. I can provide you some example:
import 'package:flutter/material.dart';

const Color darkBlue = Color.fromARGB(255, 18, 32, 47);

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData.dark().copyWith(
        scaffoldBackgroundColor: darkBlue,
      ),
      home: Scaffold(
        appBar: AppBar(
          title: Text('Listview builder without child!'),
        ),
        body: MyWidget(),
      ),
    );
  }
}

class MyWidget extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return ListView.builder(
      itemBuilder: (context, index) {
        return Container();
      },
      // itemCount: 10,
    );
  }
}

In this example itemCount was not set, I suggest you to try it by yourself, it will show blank white splash screen in this case. After that set value to itemCount, and you will understand me. But in my I used provider consumer before MaterialApp() and for that it showed blank black screen.

I don't really understand what kind of warning should be shown for a code that is working as intended. Imagine if that is a desired output for someone else and he sees a warning in the console.

I mean about documentation dartdoc comments. It's just for case as I mentioned before.

Please file this as a separate issue


Fixed #6165 -- Don't leak context to aliased plugins

Fixed #6165

Coverage remained the same at 79.105% when pulling ccc0c8db529292bf0ae95d99bb682d441e198916 on czpython:fixes/3.5.x/6165 into df1edc14b5388ed923c36623cd5e8f13047bb9bb on divio:develop.

Coverage remained the same at 79.105% when pulling<PHONE_NUMBER>f872b96d5925a88cd02affb90a0a0a on czpython:fixes/3.5.x/6165 into df1edc14b5388ed923c36623cd5e8f13047bb9bb on divio:develop.


DCOS-28735: Adjust Jest setup to work with Typescript

While working on https://jira.mesosphere.com/browse/DCOS-21930 I spend days trying to fix our Jest setup.
First, I had to enable Typescript processing. When that was done it turned out that Typescript doesn't like when we use setMock, so I removed all usages that don't make sense and replaced other with mock which is a recommended way.
unMockStores uses setMock under the hood and is going to be removed. First, it doesn't in fact unmock. It actually sets a mock and mocks stores with an empty object. ¯\_(ツ)_/¯
Dependencies

Please merge this first: https://github.com/mesosphere/dcos-ui-plugins-private/pull/794

Checklist

[x] Did you add a JIRA issue in a commit message or as part of the branch name?
[ ] Did you add new unit tests?
[ ] Did you add new integration tests?
[ ] If this is a regression, did you write a test to catch this in the future?

Closes DCOS-28735

This repo has @mesosphere-mergebot integration. You can interact with the following commands.
@mesosphere-mergebot ship-it
@mesosphere-mergebot test
@mesosphere-mergebot integrate


Pre-select Dropdown option

Would love to see, if it doesn't exist already, a way to pre-select a value from a Dropdown. My use case being, we're trying to make an easy GUI for users to change their office location when they move offices. So it would be nice to grab the current values from Jamf (or where ever), and have that set as the current Dropdown value.
I was thinking just sorting that to the top of the list, but it looks like Dropdowns just default to no selection.
Thanks!

You can do this actually. From the Accessory View Payloads page for drop downs
/selected INDEX integer index (first item is 0) which will select the related item from the passed array;

The parameters that define your drop down menu can use the above to "select" one of the items by default. You do have to know the array index value of what you want to be selected by default when the popup appears though.

That's awesome... Thank you sir!


[transfer-to-object] Allow calling some additional functions

Description
Adds the ability to call a function to determine the object ID to be received
Test Plan
Added additional tests for this.

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[X] protocol change
[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes
Added additional functionality to determine the object ID of a receiving object.

Is this adding a new native Move function?


select2, v. 4.0.1, get search text (term) if nothing found

Trying to show custom html in case when nothing found. But there is no way to retrieve current search text.
language:
{
    noResults: function (term) {
        return '<div>' + term + '</dev>';
    }
}

term is undefined always.
Please fix it.

This appears to be more of a usage question than a bug report or common feature request.  As we continue to keep the Select2 issue tracker geared towards these two areas, bug reports and common feature requests, we are redirecting usage questions to other communities such as the mailing list, IRC, or Stack Overflow.


Use class name instead of this in static methods

this operator was used within static methods to call other static methods from the same class. Looks like this does not work in conjunction with newer typescript versions (or with specific typescript configurations). This PR addresses that problem. Furthermore the qunit dependency was updated and the minimum node version was "set" to 10.

Not exactly sure why using this within static context led to an error in typescript but it works now. So this PR is not needed because it does not fix anything.


Table vs Value types

@qorrect raises an interesting point on a Discord thread.
Something I find frustrating about SQL is that a query result can have three types:

a table
a column
a value — one column, one row

Some queries implicitly require one type. For example, in:
SELECT name
FROM facts
WHERE population = (SELECT MIN(population) FROM facts);

...the subquery SELECT MIN(population) FROM facts has to be a Value. But it's difficult to know that before running the query

Here it's a full aggregation, so it is possible to statically check that, but it could be select population where country = "USA" which is ambiguous. And I'm not aware of live feedback on SQL tools to show that error even in the unambiguous case

Here's the PRQL of that query, separated into a table for effect:
table min_pop = (
  facts
  aggregate [min population]
)

from facts
select name
filter population = min_pop

We could make this be statically checked, by defining a value type:
-table min_pop = (
+value min_pop = (
   facts
   aggregate [min population]
 )

...and then having aggregate [min population, max population] would fail at "compile time".
Ambiguous subqueries such as filter country = "USA" could require a take 1 to guarantee it's a single value.

Love the idea, and I if we can error out at compile time on things like if the select contains more than one field ( for value types ) that would be great.  Really liking the compile time checks.

Reflecting on #478, there may be a 4th type — a "Row" type — with multiple columns but only one row. Modifying the example from above:
SELECT name
FROM facts
WHERE population = (SELECT population FROM min_population);

...here min_population needs to be a single row, but doesn't need to be a scalar.


import backend only when available in the environment

@alanlujan91 I haven't tested this, but you would need to do something like this to make sure you don't trip up the cupy jax imports in the backend files.

Ah this makes sense. I have to do this every time I import an optional dependency.


Fix sorting

Does this PR close any open issues?
Depends on #391
Closes #259
Closes #260
Give a longer description of what this PR addresses and why it's needed
Fixes matrix sorting. You can now sort by node, cluster, etc.
Provide pictures/videos of the behavior before and after these changes (optional)
Are there any additional TODOs before this PR is ready to go?
TODOs:

[x] Fix lineup sorting. I need to figure out how to make the lineup order change and how to get changes from lineup back to the store. (#260, might close after)
[x] Check that sorting twice causes reset
[x] Check if this fixes #294 (it does not)
[x] Fix lineup highlighting and selection (needs translation through the sortOrder array)

Added pointer CSS to make it clear that the sorting icons act as buttons.

Looks and works well.
A couple of things I noticed, neither of which are critical:
* It's not intuitive what the sort should do in cases where there is aggregation

This is tracked in #294

* The sort treats all row labels as strings which gets funky with numbers

I'll fix this before merge


Function on_floor() in KinematicBody no longer working

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Fedora 25, master branch
Issue description:
Using on_floor() in KinematicBody is no longer working as it seems the body is always suspended in air and doesn't touch the floor.
Steps to reproduce:
Run the 3D Platformer demo. You can't move properly because the player is never on_floor() now
Link to minimal example project:

3D Platformer Demo

May be related to the recent migration to the Bullet physics engine. Does the method still not work if you set the physics engine to Godot internal in the project settings?

Yes the method works properly when using old Godot physics.

I noticed it, but in my tests the problem was the shadow of cube, the cube
was attached perfectly to the floor.
I'll test it soon, in the meanwhile can you assert it please?
On Nov 13, 2017 11:29 AM, "Timo Schwarzer"<EMAIL_ADDRESS>wrote:

@AndreaCatania https://github.com/andreacatania
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/12853#issuecomment-343876965,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH9MR0U_raa8HmmZ4jKp0UAzwbrzPTkkks5s2BoEgaJpZM4Qay9G
.

@AndreaCatania I don't mean that the cube is not touching the floor visually, I mean that I cannot use the function on_floor() for collision detection e.g. for moving the cube only when it is on the floor.

Oh.. I'll fix it soon. Thanks for report

@AndreaCatania I added a print() function and I can confirm that is_on_floor() is always reporting false.

Fixed: https://github.com/godotengine/godot/pull/13046

Thank you!


GrapheneOS: Weather not showing & Disappearing widget text

Describe the bug
The weather doesn't show even though it says the key is configured correctly. Also the the text on the widget stops showing after a while.
To Reproduce
Steps to reproduce the behavior:

Setup as you normally would and enter weather key.

Expected behavior
The weather should show on the widget.
The text shouldn't disappear on the widget.
Screenshots

Smartphone (please complete the following information):

Device: Google Pixel 3 XL
OS Version: GrapheneOS (Build QQ3A.200605.001.2<IP_ADDRESS>)
App Version: 2.0.12

Additional context
This app was downloaded through the Aurora Store. No Google services are present on this device. All permissions have been granted to the app.

Hi @Kartereo I'm afraid that Google services are mandatory.


[WIP] Add CTC API

Can you do a PR with just your changes? For some reason it shows mostly my changes in your PR...

Address comments
Update python API
Add docs

Followups (in a separate PR)

benchmarks

I'm merging this PR (although there are some merge conflicts). Will send a follow up PR soon to fix those conflicts.


Using ppx_import instead of cppo, basic port to sexlex 2.0.

Now uses ppx_import instead of cppo as suggested in #3. sedlex 2.0 now uses Uchar.t instead of int, so it adapts some functions for this.
This closes #3.

Very nice, thanks for the PR!


Sun Platform causing servers startup to hang in 0.30.1

Home Assistant release (hass --version):
0.30.1
Python release (python3 --version):
Python 3.5.2
Component/platform:
automation
Description of problem:
With the latest version any automation rule I have that involves the sun platform, it causes homeassistant to hang during startup
Expected:
Home assistant should start
Problem-relevant configuration.yaml entries and steps to reproduce:
- alias: 'Lights on in the evening'
  trigger:
    - platform: sun
      event: sunset
      offset: "-00:10:00"
  action:
    - service: homeassistant.turn_on
      entity_id: scene.night_lights_on

Additional info:
Have downgraded to 0.29.7 and confirmed the above configuration works perfectly. When on 0.30.1 and I enable the above configuration home assistant hangs. When I disable it home assistant starts. From the logs it seems like when the sun platform is loaded is when the server hangs.

I have the same problem, my automations were gone after restarting with 0.30.1. When removing the automation with the sun platform, the other automations were active again.
I also downgraded to 0.29.7 to keep everything working.

I confirm the same on the latest docker image

I don't seem to have any problems with version 0.30.1, despite having the following automation:
- alias: "Turn on scene before sunset"
  trigger:
    - platform: sun
      event: sunset
      offset: '-00:45:00'
  condition:
    - condition: state
      entity_id: group.living_area_lights
      state: 'off'
  action:
    - service: script.living_area_lights

Woeps, it was my own fault. I still used platform: sun in a condition in one of my automation scripts. Still learning to understand the error messages with the check_config option.
trigger:
  - platform: state
    entity_id: media_player.atv4woonkamer
    from: 'playing'
condition:
  - platform: sun

Fixed it with the correct syntax:
trigger:
  - platform: state
    entity_id: media_player.atv4woonkamer
    from: 'playing'
condition:
  condition: sun

I had the same and added "sun:" to configuration.yaml. This solved my problem. My automation was like this:
alias: Turn off outside lamps
trigger:
  - platform: sun
    event: sunrise
action:
  service: homeassistant.turn_off
  entity_id: group.outside

Can confirm that adding sun: to configuration.yaml installs the needed libraries and then automation works. This is just different behavior than was present in previous versions.


rosdep: Add libgeographic-dev for Zesty

Required for releasing mavros for Lunar.

@vooon can you please add ubuntu artful as well?
The debian rule should be updated as well:

only wheezy has libgeographiclib-dev
jessie, stretch and buster have libgeographic-dev

@mikaelarguedas done.

Note for reviewer: should be "squash and merge"d

retriggering travis...


Unknown error (0x80092012) - The revocation function was unable to check revocation for the certificate.

Hi, I try input command "py build.py" and get error : curl: (35) schannel: next InitializeSecurityContext failed: Unknown error (0x80092012) - The revocation function was unable to check revocation for the certificate.
ERROR: curl failed. Re-run the download command to resume downloading.
How to fix it??
H:\chromium-ungoogle\ungoogled-chromium-windows>py build.py
INFO: Downloading required files...
INFO: Downloading "chromium" to "chromium-109.0.5414.120.tar.xz" ...
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (35) schannel: next InitializeSecurityContext failed: Unknown error (0x80092012) - The revocation function was unable to check revocation for the certificate.
ERROR: curl failed. Re-run the download command to resume downloading.
Traceback (most recent call last):
File "H:\chromium-ungoogle\ungoogled-chromium-windows\build.py", line 240, in
main()
File "H:\chromium-ungoogle\ungoogled-chromium-windows\build.py", line 158, in main
downloads.retrieve_downloads(download_info, downloads_cache, True,
File "H:\chromium-ungoogle\ungoogled-chromium-windows\ungoogled-chromium\utils\downloads.py", line 282, in retrieve_downloads
_download_if_needed(download_path, download_properties.url, show_progress,
File "H:\chromium-ungoogle\ungoogled-chromium-windows\ungoogled-chromium\utils\downloads.py", line 229, in _download_if_needed
raise exc
File "H:\chromium-ungoogle\ungoogled-chromium-windows\ungoogled-chromium\utils\downloads.py", line 226, in _download_if_needed
subprocess.run(['curl', '-L', '-o', str(tmp_file_path), '-C', '-', url], check=True)
File "C:\Users\cuong\AppData\Local\Programs\Python\Python311\Lib\subprocess.py", line 569, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['curl', '-L', '-o', 'H:\chromium-ungoogle\ungoogled-chromium-windows\build\download_cache\chromium-109.0.5414.120.tar.xz.partial', '-C', '-', 'https://commondatastorage.googleapis.com/chromium-browser-official/chromium-109.0.5414.120.tar.xz']' returned non-zero exit status 35.
Thank!!

Sounds like an issue with certificates on your system. Does rerunning the command produce the same error?

I also got the same error, I have re-run it many times but still the error.
INFO: Verifying hashes for "nodejs" ...
INFO: Unpacking downloads...
INFO: Unpacking "chromium" to ./ ...
ERROR: Temporary unpacking directory already exists: E:\chromium\ungoogled-chromium-windows\build\src\chromium-110.0.5481.100
Traceback (most recent call last):
File "E:\chromium\ungoogled-chromium-windows\build.py", line 240, in
main()
File "E:\chromium\ungoogled-chromium-windows\build.py", line 172, in main
downloads.unpack_downloads(download_info, downloads_cache, source_tree, extractors)
File "E:\chromium\ungoogled-chromium-windows\ungoogled-chromium\utils\downloads.py", line 343, in unpack_downloads
extractor_func(
File "E:\chromium\ungoogled-chromium-windows\ungoogled-chromium\utils_extraction.py", line 225, in extract_tar_file
_extract_tar_with_7z(sevenzip_bin, archive_path, output_dir, relative_to)
File "E:\chromium\ungoogled-chromium-windows\ungoogled-chromium\utils_extraction.py", line 103, in _extract_tar_with_7z
raise ExtractionError()
_extraction.ExtractionError

I added extractor = winrar to ungoogled-chromium/downloads.ini to fixed it.


Add full support for HybridSystem

Add supertype StaticInjectionSubystem.
Add support for time series at the subcomponent level.
Add serialization support.

This will allow construction of a HybridSystem with subcomponents that are either attached or not attached to the system. If they are attached, they are removed. If they have time series, those are moved to the HybridSystem.
There are a number of time series methods implemented on component that I did not yet implement HybridSystem + subcomponent. Basically, all of them would have to have forwarding based on the time series name. I would like feedback on what is required. All?

get_time_series_array
get_time_series_values
copy_time_series!
has_time_series
ForecastCache
StaticTimeSeriesCache

Add supertype StaticInjectionSubystem.
Add support for time series at the subcomponent level.
Add serialization support.

This will allow construction of a HybridSystem with subcomponents that are either attached or not attached to the system. If they are attached, they are removed. If they have time series, those are moved to the HybridSystem.
There are a number of time series methods implemented on component that I did not yet implement HybridSystem + subcomponent. Basically, all of them would have to have forwarding based on the time series name. I would like feedback on what is required. All?

get_time_series_array
get_time_series_values
copy_time_series!
has_time_series
ForecastCache
StaticTimeSeriesCache

All of them are needed (with probably the exception of copy), specially the cache one for simulation.


Python virtualenv installs no longer reproducible

brew doctor output
Your system is ready to brew.

Verification

[X] My "brew doctor output" above says Your system is ready to brew. and am still able to reproduce my issue.
[X] I ran brew update twice and am still able to reproduce my issue.
[X] This issue's title and/or description do not reference a single formula e.g. brew install wget. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.

brew config output
(from CI that reproduced the issue)

HOMEBREW_VERSION: 4.1.11-25-gc953076
ORIGIN: https://github.com/Homebrew/brew
HEAD: c9530766096e692d5031750a14b4d1d42f1dc655
Last commit: 7 hours ago
Core tap origin: https://github.com/Homebrew/homebrew-core
Core tap HEAD: e2981ddc6460ff77f8543099ac3046c836ef9828
Core tap last commit: 18 minutes ago
Core tap branch: master
Core tap JSON: 13 Sep 20:15 UTC
HOMEBREW_PREFIX: /usr/local
HOMEBREW_BOOTSNAP: set
HOMEBREW_CACHE: /Users/brew/Library/Caches/Homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_COLOR: set
HOMEBREW_CURL_PATH: /usr/bin/curl
HOMEBREW_DEVELOPER: set
HOMEBREW_FAIL_LOG_LINES: 150
HOMEBREW_GIT_EMAIL<EMAIL_ADDRESS>HOMEBREW_GIT_NAME: BrewTestBot
HOMEBREW_GIT_PATH: /usr/bin/git
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_LOGS: /Users/brew/actions-runner/_work/homebrew-core/homebrew-core/logs
HOMEBREW_MAKE_JOBS: 6
HOMEBREW_NO_AUTO_UPDATE: set
HOMEBREW_NO_COLOR: set
HOMEBREW_NO_EMOJI: set
HOMEBREW_NO_ENV_HINTS: set
HOMEBREW_NO_INSTALL_FROM_API: set
HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK: set
HOMEBREW_SORBET_RUNTIME: set
Homebrew Ruby: 2.6.10 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: hexa-core 64-bit penryn
Clang: 15.0.0 build 1500
Git: 2.39.3 => /usr/bin/git
Curl: 8.1.2 => /usr/bin/curl
macOS: 14.0-x86_64
CLT: <IP_ADDRESS>.1.1694021235
Xcode: 15.0

What were you trying to do (and why)?
Produce a reproducible bottle for a package containing a Python virtualenv.
What happened (include all command output)?
The package is no longer reproducible after a recent change:
$ cat $(brew --prefix asciidoc)/libexec/lib/python3.11/site-packages/asciidoc-10.2.0.dist-info/direct_url.json
{"dir_info": {}, "url": "file:///private/tmp/asciidoc-20230913-6340-1d0mrm3/asciidoc-10.2.0"}

What did you expect to happen?
References to the temp directory are not included.
Deleting or modifying this file is not sufficient on its own as it is hashed in RECORD. There's a few alternative solutions discussed in https://github.com/pypa/pip/issues/11424.
It's possible this issue also extends to regular non-venv std_pip_args installs but I have not tested this.
Step-by-step reproduction instructions (by running brew commands)
(Example)
brew install -s asciidoc

Good catch, thanks @Bo98!

It's possible this issue also extends to regular non-venv std_pip_args installs but I have not tested this.

I believe this does. CC @branchvincent since I think you may have had a look at this.

Deleting or modifying this file is not sufficient on its own as it is hashed in RECORD. There's a few alternative solutions discussed in pypa/pip#11424.

From quick glance, it looks like most official options for local directory would require splitting up wheel build and wheel install, e.g.

python3 -m pip wheel <args> . + python3 -m pip install <args> --no-index --find-links=./some/path <name>
python3 -m build --wheel ... + python3 -m installer <wheel>

Alternative official option would require removing resources and letting pip fetch tarballs, e.g.

python3 -m pip install six==1.16.0

The hack would be to patching up direct_url.json and overwrite hash in RECORD perhaps via a pip shim.

The hack would be to patching up direct_url.json and overwrite hash in RECORD perhaps via a pip shim.

Something like this would work for me 👍🏻

Trying on asciidoc (https://github.com/Homebrew/homebrew-core/pull/165497), it looks like per platform (e.g. Apple Silicon) the bottle is identical so probably reproducible, but still missing all bottle as it has some recorded sha difference on the bin script:
--- /Users/cho-m/Library/Caches/Homebrew/downloads/0dc87f8a307fb752c8a06de20d603793dcd2d4a2aab76dcbf6085012327a2507--asciidoc--10.2.0.arm64_sonoma.bottle.6.tar.gz
+++ /Users/cho-m/Library/Caches/Homebrew/downloads/581f6cea5fa1a51516e60c91c78ee4cc1545d2e1a8dbd6a6c607cb0bb91cb542--asciidoc--10.2.0.sonoma.bottle.6.tar.gz
│   --- 0dc87f8a307fb752c8a06de20d603793dcd2d4a2aab76dcbf6085012327a2507--asciidoc--10.2.0.arm64_sonoma.bottle.6.tar
├── +++ 581f6cea5fa1a51516e60c91c78ee4cc1545d2e1a8dbd6a6c607cb0bb91cb542--asciidoc--10.2.0.sonoma.bottle.6.tar
│ ├── asciidoc/10.2.0/libexec/lib/python3.12/site-packages/asciidoc-10.2.0.dist-info/RECORD
│ │ @@ -1,9 +1,9 @@
│ │ -../../../bin/a2x,sha256=fUHfht_0WrUAbZS6OYXl2eFJJyRIB7ifIma9OIdKKHQ,248
│ │ -../../../bin/asciidoc,sha256=jM0HujAKip0JkiUIYj8afLlQeIJCUYVUbSS6KFdnU4g,253
│ │ +../../../bin/a2x,sha256=ufhgOjlHOfDxSfLCKkoyteRH4Zz6IXUAyFKDyjSwbBw,245
│ │ +../../../bin/asciidoc,sha256=1ras2JOqlg1UEVWBFctQLiuhwbeLWSLYYdxx1yvzw8A,250

Could be that it is using absolute (i.e. HOMEBREW_PREFIX) path during this metadata generation?

Also, not a regression, but when Python package builds shared library it stores path into binary. Our old setup_install_args behaves the same way.
Only way around this would be using a stable directory path. I'm guessing we don't do this for /tmp to avoid potential conflict. One option could be source unpack within prefix.

Do we do a @@HOMEBREW_PREFIX@@ in those files? That probably explains it as the sha256 will be before that happens.

Also, not a regression, but when Python package builds shared library it stores path into binary

Will see where this happens

Do we do a @@HOMEBREW_PREFIX@@ in those files? That probably explains it as the sha256 will be before that happens.

Yes. Easiest way is probably purging those entries if we want to get an all bottle. Maybe something like:
s.gsub! %r{^(#{Regexp.escape("../../../bin/")}[^/,\n]*),sha256=.*,.*$}, "\\1,,", false

Also, not a regression, but when Python package builds shared library it stores path into binary

Will check and see where this happens

At least I was getting difference locally on back-to-back builds of cffi and running brew bottle --verbose --json --only-json-tab cffi.
I wanted to check if CI behaves the same but our bottle cache skips the 2nd build.
│ ├── cffi/1.16.0_1/lib/python3.12/site-packages/_cffi_backend.cpython-312-darwin.so
│ │ ├── arm64
│ │ │┄ Format-specific differences are supported for this file format but no file-specific differences were detected; falling back to a binary diff. file(1) reports: Mach-O 64-bit arm64 bundle, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|HAS_TLV_DESCRIPTORS>
│ │ │ @@ -13162,21 +13162,21 @@
│ │ │  00033690: 6765 745f 696e 7465 7270 7374 6174 655f  get_interpstate_
│ │ │  000336a0: 6469 6374 2e61 7474 725f 6e61 6d65 005f  dict.attr_name._
│ │ │  000336b0: 6666 695f 696e 7465 726e 616c 5f6e 6577  ffi_internal_new
│ │ │  000336c0: 2e69 6e74 6572 6e61 6c5f 6f75 7470 7574  .internal_output
│ │ │  000336d0: 005f 5f74 6573 7466 756e 6336 2e79 005f  .__testfunc6.y._
│ │ │  000336e0: 5f4d 6572 6765 6447 6c6f 6261 6c73 2e36  _MergedGlobals.6
│ │ │  000336f0: 3737 002f 7072 6976 6174 652f 746d 702f  77./private/tmp/
│ │ │ -00033700: 6366 6669 2d32 3032 3430 3330 382d 3331  cffi-20240308-31
│ │ │ -00033710: 3933 342d 3937 7668 3475 2f63 6666 692d  934-97vh4u/cffi-
│ │ │ +00033700: 6366 6669 2d32 3032 3430 3330 382d 3333  cffi-20240308-33
│ │ │ +00033710: 3133 392d 776c 3473 3665 2f63 6666 692d  139-wl4s6e/cffi-
...
│ ├── cffi/1.16.0_1/lib/python3.12/site-packages/cffi-1.16.0.dist-info/RECORD
│ │ @@ -1,8 +1,8 @@
│ │ -_cffi_backend.cpython-312-darwin.so,sha256=cY4QovyRC4Z0fRE8WkxBI9Ldf8iWUxXCP4GdsJxZ2Sc,212688
│ │ +_cffi_backend.cpython-312-darwin.so,sha256=GfMRY0xdUvDfgzqy_kNQvayCwPdXXlN3pXGhSyuJjts,212688

Ok that's more of a compiler thing. I know how to fix that: it's -ffile-prefix-map=#{buildpath}=/tmp/homebrew-build/cffi. I'll look into integrating this into brew somehow.

Oh right didn't realise there was two paths. What I said covers the .c one.

Oh right didn't realise there was two paths. What I said covers the .c one.

The other path is just for checksum of first path. Diff should go away once .c path is fixed.

I see what you mean. The build/temp.macosx-14.0-arm64-cpython-312/src/c/_cffi_backend.o._init_cffi_tls

Please try with https://github.com/Homebrew/brew/pull/16860.

I don't necessarily expect same checksums across different compiler/linker versions, but I would at least expect a repeated build with the same environment to produce the same result.

Please try with #16860.

Works for cffi example.
Do we know if there are any potential scenarios this may need to be disabled? At least Debian has enabled -ffile-prefix-map as default so there is good chance of stability for -fdebug-prefix-map
Ref: https://git.dpkg.org/git/dpkg/dpkg.git/commit/?id=b60c243ba99b8483202a6f6a814476275204fdff

I don't necessarily expect same checksums across different compiler/linker versions so we won't get an all bottle there, but I would at least expect a repeated build with the same environment to produce the same result.

That's what I expect. The all bottle discussion was for pure python code, which should be possible like asciidoc. Though larger virtualenvs probably will have some C/C++ code making all bottles unlikely.

Do we know if there are any potential scenarios this may need to be disabled? At least Debian has enabled -ffile-prefix-map as default so there is good chance of stability for -fdebug-prefix-map

It should be at least safe enough to not worry about it until there's evidence that something breaks.
I don't envision any particular issue

Is there anything left here?
Only thing left I can think of is doing version detection to enable -ffile-prefix-map. There are probably some formulae this will help (e.g. I think csound is impacted, though it is also impacted by a CMake JAR reproducibility issue).


Fixed "No response from service" for videogrid

The videogrid operation would sometimes fail for many videos (more than ~50).
This was due to the WOH sending all the ffmpeg commands to the service as a single job argument, which broke the service if it became to long/large.
This commit changes the WOH and the service in a way that instead of sending all commands in a single job, each command is now send as its own job.
Resolves #2137.
How to test:

Have a distributed Opencast installation (seperate admin and worker nodes)
Create a workflow with the Videogrid Operation (An example: https://github.com/elan-ev/opencast-bigbluebutton-integration/blob/master/post-archive/bbb-upload-9-2.xml)
Use the Ingest Service to create a mediapackage, use "AddPartialTrack" to add a couple of presenter tracks and then start your workflow
If you've got (processing) time, try to test with a lot (more than ~50) presenter tracks that all have different start times when added with "AddPartialTrack"

Your pull request should…

[x] have a concise title
[x] close an accompanying issue if one exists
[x] be against the correct branch (features can only go into develop)
[x] include migration scripts and documentation, if appropriate
[x] pass automated tests
[x] have a clean commit history
[x] have proper commit messages (title and body) for all commits

This reviews so much better with the ?w=1 query parameter


Fix for issue #332

When running acceptance tests on Windows, you must specify "java.exe"
instead of "java" in the Path.resolve(...) call.

Thanks! It seems like this PR got out of sync with master, could you please sync it up?
J

Hmm. The HEAD~1 commit hash on this PR matches the master branch. Attempting to pull master into the branch results in "Already up-to-date."
I updated the bracing style to 1TBS for consistency. The PR appears to me to be in sync, and mergeable.

Hmm, maybe a mistake on my side then, let me check.

Does it appear in sync to you now?

Yup, all good, thanks for your contribution!


Api connection

On this Pull Request, we:

Add a component to handle calls to the API
MAde sure functionality is kept.
Books are now stored on the API at reload.

thank you, @VICTOR-CHUKWU !
Ill merge it right away


Many Vcpkg ports are not usable in ROS on Windows installation.

Many Vcpkg ports are not usable in ROS on Windows installation. It failed at the following errors:
downloading bash-5.1.004-1-x86_64.pkg.tar.zst...
downloading filesystem-2021.01-1-x86_64.pkg.tar.zst...
downloading mintty-1~3.4.4-1-x86_64.pkg.tar.zst...
downloading msys2-runtime-3.1.7-4-x86_64.pkg.tar.xz...
downloading pacman-mirrors-20210127-1-any.pkg.tar.zst...
checking keyring...
checking package integrity...
loading package files...
error: could not open file /var/cache/pacman/pkg/bash-5.1.004-1-x86_64.pkg.tar.zst: Child process exited with status 127
error: could not open file /var/cache/pacman/pkg/filesystem-2021.01-1-x86_64.pkg.tar.zst: Child process exited with status 127
error: could not open file /var/cache/pacman/pkg/mintty-1~3.4.4-1-x86_64.pkg.tar.zst: Child process exited with status 127
error: could not open file /var/cache/pacman/pkg/pacman-mirrors-20210127-1-any.pkg.tar.zst: Child process exited with status 127
error: could not open file /var/cache/pacman/pkg/libzstd-1.4.8-1-x86_64.pkg.tar.zst: Child process exited with status 127
error: could not open file /var/cache/pacman/pkg/zstd-1.4.8-1-x86_64.pkg.tar.zst: Child process exited with status 127
error: could not open file /var/cache/pacman/pkg/pacman-5.2.2-11-x86_64.pkg.tar.zst: Child process exited with status 127
error: failed to commit transaction (cannot open package file)

The same failures can be reproducible when using the upstream Vcpkg 2020.07.

Vcpkg 2020.11 and above doesn't have this problem. Most likely we need to upgrade Vcpkg to fix this issue...

I am trying to get rtabmap and/or cartographer_ros building on windows 10.  I see cartographer in the ROS share directory but can't build it from there.  Manual port from github repo is going better - so will probably continue there.


[QUESTION] engine image pods trying to be deployed on no longer existing nodes

Hello,
From where we can check why longhorn trying to create pods on non existing nodes ?
We get some crash on cluster, broken nodes was removed, but longhorn still trying to use them.
From web manager this nodes are mising now.
$ kubectl get nodes
NAME           STATUS   ROLES                  AGE     VERSION
brixone        Ready    control-plane,master   29d     v1.20.5+k3s1
kube1-worker   Ready                     4h53m   v1.20.6+k3s1
kube2-worker   Ready                     4h48m   v1.20.6+k3s1
corosync       Ready    control-plane,master   29d     v1.20.5+k3s1
msi55          Ready    control-plane,master   29h     v1.20.6+k3s1
$ kubectl -n longhorn-system get pods -o wide|grep prox
engine-image-ei-deb8b464-wj75x              0/1     Pending    0          3m12s           prox2
engine-image-ei-deb8b464-tmrr4              0/1     Pending    0          3m12s           prox3
engine-image-ei-817782be-5dltx              0/1     Pending    0          3m12s           prox2
engine-image-ei-817782be-7t5s6              0/1     Pending    0          3m12s           prox3
Best regards
Environment:

Longhorn version: 1.1.100
Kubernetes version: 1.20.5
Node config

OS type and version Debian 10
CPU per node: 4
Memory per node: 4G
Disk type - ssd
Network bandwidth and latency between the nodes: 1G

Underlying Infrastructure KVM / baremetal

Additional context
Add any other context about the problem here.

Can you run the following commands and post their output
kubectl get nodes.longhorn.io -n longhorn-system
kubectl get engineimages.longhorn.io ei-817782be -o yaml -n longhorn-system
kubectl get engineimages.longhorn.io ei-deb8b464 -o yaml -n longhorn-system

Hello,
in those engine those old nodes are still listed.
psobota@msiapache2ssd ~ $  kubectl get nodes.longhorn.io -n longhorn-system
NAME           READY   ALLOWSCHEDULING   SCHEDULABLE   AGE
msi55          True    true              True          29d
brixone        True    true              True          29d
corosync       True    true              True          29d
kube2-worker   True    false             True          171m
kube1-worker   True    false             True          172m
psobota@msiapache2ssd ~ $  kubectl get engineimages.longhorn.io ei-817782be -o yaml -n longhorn-system
apiVersion: longhorn.io/v1beta1
kind: EngineImage
metadata:
creationTimestamp: "2021-05-07T08:55:20Z"
finalizers:

longhorn.io
generation: 1
labels:
longhorn.io/component: engine-image
longhorn.io/engine-image: ei-817782be
longhorn.io/managed-by: longhorn-manager
managedFields:
apiVersion: longhorn.io/v1beta1
fieldsType: FieldsV1
fieldsV1:
f:metadata:
f:finalizers:
.: {}
v:"longhorn.io": {}
f:labels:
.: {}
f:longhorn.io/component: {}
f:longhorn.io/engine-image: {}
f:longhorn.io/managed-by: {}
f:spec: {}
f:status: {}
manager: longhorn-manager
operation: Update
time: "2021-05-07T08:55:20Z"
name: ei-817782be
namespace: longhorn-system
resourceVersion: "42657095"
uid: e16ac97b-d1a0-4f99-9ced-3c31c31284e1
spec:
image: rancher/mirrored-longhornio-longhorn-engine:v1.1.1
status:
buildDate: "2021-04-23T02:29:18+00:00"
cliAPIMinVersion: 3
cliAPIVersion: 4
conditions:
ready:
lastProbeTime: ""
lastTransitionTime: "2021-05-07T09:32:19Z"
message: Engine image ei-817782be (rancher/mirrored-longhornio-longhorn-engine:v1.1.1)
is fully deployed on all ready nodes
reason: ""
status: "True"
type: ready
controllerAPIMinVersion: 3
controllerAPIVersion: 3
dataFormatMinVersion: 1
dataFormatVersion: 1
gitCommit: 3cc56fd7c02269718bbe276f78fe7257e46c6c1a
noRefSince: "2021-05-07T08:55:22Z"
nodeDeploymentMap:
brixone: true
corosync: true
kube1-worker: true
kube2-worker: true
msi55: true
prox2: true
prox3: true
ownerID: brixone
refCount: 0
state: deployed
version: v1.1.1
psobota@msiapache2ssd ~ $  kubectl get engineimages.longhorn.io ei-deb8b464 -o yaml -n longhorn-system
apiVersion: longhorn.io/v1beta1
kind: EngineImage
metadata:
creationTimestamp: "2021-04-08T08:58:33Z"
finalizers:
longhorn.io
generation: 1
labels:
longhorn.io/component: engine-image
longhorn.io/engine-image: ei-deb8b464
longhorn.io/managed-by: longhorn-manager
managedFields:
apiVersion: longhorn.io/v1beta1
fieldsType: FieldsV1
fieldsV1:
f:metadata:
f:finalizers:
.: {}
v:"longhorn.io": {}
f:labels:
.: {}
f:longhorn.io/component: {}
f:longhorn.io/engine-image: {}
f:longhorn.io/managed-by: {}
f:spec: {}
f:status: {}
manager: longhorn-manager
operation: Update
time: "2021-05-07T08:55:09Z"
name: ei-deb8b464
namespace: longhorn-system
resourceVersion: "42697016"
uid: 34167443-b637-4385-b44a-80c2fa11c7ee
spec:
image: rancher/mirrored-longhornio-longhorn-engine:v1.1.0
status:
buildDate: "2020-12-18T00:38:19+00:00"
cliAPIMinVersion: 3
cliAPIVersion: 4
conditions:
ready:
lastProbeTime: ""
lastTransitionTime: "2021-05-07T10:04:17Z"
message: Engine image ei-deb8b464 (rancher/mirrored-longhornio-longhorn-engine:v1.1.0)
is fully deployed on all ready nodes
reason: ""
status: "True"
type: ready
controllerAPIMinVersion: 3
controllerAPIVersion: 3
dataFormatMinVersion: 1
dataFormatVersion: 1
gitCommit: b9e072eb19cfcc27894e10a8e60794c66ca918f8
noRefSince: ""
nodeDeploymentMap:
brixone: true
corosync: false
kube1-worker: true
kube2-worker: true
msi55: true
prox1: false
prox2: true
prox3: true
ownerID: msi55
refCount: 9
state: deployed
version: v1.1.0

cc @PhanLe1010 looks like we are not removing deleted nodes from the engine-image deployment maps.

any possiblity to edit it manualy to get rid of it on working cluster?


Fix repl style

FIx #733

Pull Request Test Coverage Report for Build 2254

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 34.301%

Totals

Change from base Build 2207:
0.0%

Covered Lines:
1777

Relevant Lines:
4562

💛  - Coveralls


Capacitor 4.0 support

I think #38 is missing the podspec and gradle changes
Additional if you want to install this early in your project you can run npm i ProteanSoftware/capacitor-filesharer#master

@AshleyMedway: Did you have any troubles with this Branch, Capacitor 4 and Android so far?
I keep getting the following error:
E/DatabaseUtils: Writing exception to parcel
    java.lang.SecurityException: Permission Denial: reading com.byteowls.capacitor.filesharer.FileSharerProvider uri content://com..... from pid=27862, uid=1000 requires the provider be exported, or grantUriPermission()
        at android.content.ContentProvider.enforceReadPermissionInner(ContentProvider.java:912)
        at android.content.ContentProvider.semEnforceReadPermission(ContentProvider.java:830)
        at android.content.ContentProvider$Transport.enforceReadPermission(ContentProvider.java:708)
        at android.content.ContentProvider$Transport.query(ContentProvider.java:247)
        at android.content.ContentProviderNative.onTransact(ContentProviderNative.java:107)
        at android.os.Binder.execTransactInternal(Binder.java:1215)
        at android.os.Binder.execTransact(Binder.java:1179)

If you are confident that this works I'm happy to merge and release a new version asap, but I do not have the time to test it myself. BR

Let me do some further testing today. I've got to do a regression of our app in Capacitor 4 today. Will report back :)

I've tested the branch with a few devices (iOS and Android) and everything looks good so far. The error I mentioned above is still happening on Android as soon as a file gets shared, but it doesn't seem to have any negative consequences.

@hermitdemschoenenleben Did you install the PR with npm i ProteanSoftware/capacitor-filesharer#master as mentioned in the first post? The description is a bit misleading and actually doesn't work. You need to install the #v4 branch in order to get the latest version, which fixes the ActivityResult.

@tho-masn you're right, I was indeed misled by the description and checked out the wrong branch, sorry for that! With the v4 branch, it works fine. Thank you very much for your work and quick response!

When will this be launched? Waiting for it.

The import in the component now still gives 'cannot find module'
import { FileSharer } from '@byteowls/capacitor-filesharer';
It did install successfully

I'm in the middle of releasing. Which version did you try. 4.0.0 is not released yet.

@sander-spruit One more thing: I have no connection to ProteanSoftware. I have planned to do the release this weekend so your rather disrespectful behavior is for sure not the reason I'm releasing. Such comments are not motivating me to spend my spare time in providing open source software.

@moberwasserlechner no harm intended.


Is there a way to check if each sample in the dataset is correct or incorrect?

Thank you in advance

Hi!, you can use --log_samples flag on the big_refactor branch to save the model outputs to file. Think there is an analogous option on the main branch as well but not sure.

The option on the main branch only logs inputs not completions unless there's been a PR I've missed.


NTS-1 mkII: Cannot use additional parameters for modfx and revfx

I built all the dummy projects and found that the extended parameters are only available on dummy-osc and dummy-delfx.
Turning the Type knob while holding down the delay button shows "Param4", but I can't see this with dummy-mod, and I see "Mix" with dummy-revfx.

I tested firmware v1.2 and can confirm that this issue has been fixed.


Fix a small spell mistake

Fix a spell mistake.
Modifications:
Change 'treshold' to 'threshold'
Result:
The spellchecker warnings of the IDE disappeared.

Cherry-picked into 4.0 (8d04c43cb6ab240266a47b722572263893690e21) and 4.1 (b354868dd83fa720a1956e3366b5931f7f5f1885)

@liuzhengyang thanks :)


Support for ServiceMonitor

[ ] For the operator itself. The operator-sdk scaffolding already created one file which contains a ServiceMonitor object. We would need to update the operator itself so we can use it, and then include the ServiceMonitor in our Helm chart which can be enabled when installing the operator.
[ ] For Humio pods. It might be fine to assume a user would want to use ServiceMonitor for Humio pods if they are enabling it for the operator itself.

I have the following for the operator:
apiVersion: v1
kind: Service
metadata:
  name: humio-operator-metrics
  namespace: logging
  labels:
    app.kubernetes.io/instance: humio-operator-metrics
    app.kubernetes.io/name: humio-operator-metrics
spec:
  ports:
  - name: metrics
    port: 8080
    protocol: TCP
    targetPort: 8080
  selector:
    app.kubernetes.io/instance: humio
  sessionAffinity: None
  type: ClusterIP
---
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: humio-oprtator-servicemonitor
  namespace: monitoring
  labels:
    release: kube-prometheus-stack
spec:
  selector:
    matchLabels:
      app.kubernetes.io/instance: humio-operator-metrics
  endpoints:
  - port: metrics
    path: /metrics
  namespaceSelector:
    matchNames:
    - logging

And the following for humioc-cluster:
apiVersion: v1
kind: Service
metadata:
  name: humio-quickstart-metrics
  namespace: logging
  labels:
    app.kubernetes.io/instance: humio-quickstart-metrics
    app.kubernetes.io/name: humio
spec:
  ports:
  - name: metrics
    port: 8081
    protocol: TCP
    targetPort: 8081
  selector:
    app.kubernetes.io/instance: humio-quickstart
  sessionAffinity: None
  type: ClusterIP
---
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: humio-quickstart-servicemonitor
  namespace: monitoring
  labels:
    release: kube-prometheus-stack
spec:
  selector:
    matchLabels:
      app.kubernetes.io/instance: humio-quickstart-metrics
  endpoints:
  - port: metrics
    path: /metrics
  namespaceSelector:
    matchNames:
    - logging

Are there any dashboard.json you can share ?

@SaaldjorMike It would be great to have [PrometheusRule](https://docs.openshift.com/container-platform/4.4/rest_api/monitoring_apis/prometheusrule-monitoring-coreos-com-v1.html)  predefined as well. Would you prefer a separate issue for this?

@hagzag Thanks for sharing the ServiceMonitor objects, that is very helpful. I assume you are asking for a dashboard.json file for Grafana? If yes, then no, we do not internally use Grafana at this point and I am not aware of us having such a file available. That is also outside the scope of the humio-operator project.
@estahn I think we should keep that separate.


Fix relaunch command

Uses the endpoint /workflow/<workflow_id>/launch to get the launch to relaunch instead of /launch/<launch_id>
Allows to set a run name when relaunching with tw runs relaunch --name ...
Fixes #244

@abhi18av @drpatelh @gwright99 can you help me, before doing a new release, check that this fixes the relaunch/resume?
To get the binaries of this branch you should go to the "Artifacts" sections (bottom right) of this page https://github.com/seqeralabs/tower-cli/actions/runs/2884122728

Downloaded the artifact and tried to relaunch. Took me a few tries (see screenshot 1).
I assume that error about the session_id already being in use is expected? Got the same behaviour when I tried relaunching from the console (I tried relaunching the source a 2nd time while the 1st relaunched instance was still in flight).

Thanks @gwright99! Those the 'Missing launch revision ID' error also happens from the web?

Thanks @gwright99! Does the 'Missing launch revision ID' error also happens from the web?

Nope. When I resume from the UI, the revision shows up as master:
Original Run

Resume from UI

Resumed Run

I've fixed the discrepancy when relaunching a cancelled run that was not possible to resume. Now is doing like the website UI and it is relaunching it without trying to resume it. Still if it's possible to resume it, it will resume.