Verify i18n support for Carbon Components

We should make sure that all of our components lends themselves to i18n, not only for strings that are rendered to the screen but also for attributes like ARIA labels, and have a documented example for each component in Storybook.
This issue is for the following:

[ ] Identifying components that can't follow common i18n patterns
[ ] Updating these components
[ ] Adding stories for components for i18n

@joshblack should we move this to carbon/issue to make sure it gets tracked in future sprint planning?

Yupp! Definitely makes sense to me 👍


update: jq

Name: jq
CVEs: CVE-2023-50246, CVE-2023-50268
CVSSs: 5.5, 5.5
Action Needed: update to >= 1.7.1
Summary:

CVE-2023-50246: jq is a command-line JSON processor. Version 1.7 is vulnerable to heap-based buffer overflow. Version 1.7.1 contains a patch for this issue.
CVE-2023-50268: jq is a command-line JSON processor. Version 1.7 is vulnerable to stack-based buffer overflow in builds using decNumber. Version 1.7.1 contains a patch for this issue.

Note: Flatcar releases are still not affected by the CVEs, because the PR for jq 1.7, https://github.com/flatcar/scripts/pull/1470 is still not merged. If jq was update to 1.7.1 before the next release, we can close this issue without having to add CVE entries.
refmap.gentoo: https://bugs.gentoo.org/920064

PR https://github.com/flatcar/scripts/pull/1544

PR merged


examples: add beer-stars example.

Note that this is setup to use the latest main typescript client, so will fail to run until the new auth #353 and tab #358 changes are included in a client release.

@thruflo The new auth anad tab changes are included in the latest client release.


WebService target: added support for custom SOAPAction property (Soap11+Soap12 protocol)

Fixes #3081
Processing of existing header SoapAction has been added.
Unit tests for default SoapAction and custom SoapAction have been added.

Thanks for the changes. It's OK to me to tweak a bit further on this PR

Created new PR #3100 as followup.


files: available storage header is broken

When the "Storage available" header is overflowing the component is broken. See:

We should fix the header to remain in the same line or continue in the next one altogether.

A quick fix can be applied for devices >=994px. See

For smaller devices, bigger changes are required. My question is: Do we want to start fixing responsiveness for screens like tablets and mobiles at this moment or currently the fix applying to the screenshot is good enough?

oh I thought a quick fix like Mojib did here: https://github.com/inveniosoftware/invenio-app-rdm/pull/519/files would have done it.

In general I think we should integrate the SUI regarding responsiveness https://react.semantic-ui.com/collections/grid/#responsive-variations-responsive-width


[flutter_releases] Flutter stable 2.10.2 Framework Cherrypicks

Flutter stable 2.10.2 Framework
Scheduled Cherrypicks

commit: 73fb2e653
commit: e9b8a6efb

Gold has detected about 2 new digest(s) on patchset 5.
View them at https://flutter-gold.skia.org/cl/github/98750


luci-base: menu item with uci depends doesn't update

Steps to reproduce:

Add a uci dependency to a JSON menu item (e.g. "depends": {"uci": {"system": {"foo": 1}})
Logout and login to LuCI in your browser (to force it to regenerate and cache the new menu).
Modify that configuration option.
Reload the page.

Actual behavior:
The menu won't change due to UCI changes unless you logout (to clear the session) and remove /tmp/luci-indexcache*
Expected behavior:
When saving UCI items from the frontend, the frontend should automatically regenerate the menu.
Additional Information:
Custom build of 22.03.5.

Not sure we really want to flush the menu on every single uci change. The menu depends mechanism was not really meant for that level of dynamic usage. Primary use case was masking features (such as hiding wifi or switch config if the relevant sections are not present).

I looked into this because we were using it to show log file pages only in certain situations (i.e. when particular options are enabled).
I'd argue that this makes it behave in a less surprising way, the cost of rebuilding the menu is not that high and that uci confirm is already a somewhat slow process. But I can understand that it's less than elegant given that most of the time it wouldn't change.
Alternatively, if the idea is that it should really only be for entire sections, perhaps the individual options dependency support could be removed. Do you see a use case for this when from a user perspective the device has to be rebooted for changes to 'take'?

@jow- I have notice that, too. After wifi module auto config, menu not shown "Wireless". Same issue appears on Docker, if I open luci on browser on boot, Docker maybe not start on that time, menu will not show Docker menu even after docker started.


tables flash "Processing..." #3671

add Processing indicator only if table has more than 500 items

:+1:


Easy way to create long-form text?

Great project! I'm looking into integration possibilities for my static site generator primarily as a way to spin up placeholder content. I've pretty much got how to create simple strings with dictionary substitutions, but is there an easy/recommended way to generate entire paragraphs of text (or even longer) without relying on some sort of string template? I'm guessing there are ways of doing this with the scripting language, but is there an easier method I've missed?

:+1:
The one thing I haven't seen Rant do is generate believable English.

The project that started Rant, "Moist Banana Deluxe", was a long-form text generator. I think it worked by having a bunch of different sentence patterns and choosing randomly from each. Berkin might know of a better way.
Berkin & I were talking about a new project that's more natural language focused and less pattern-based. I don't think it's even past the idea stage yet though.

Rant is essentially a templating language at its core, so some usage of templates is practically unavoidable. However, there are ways to generate believable long-form text. The appropriate technique for doing so depends entirely on how detailed the concepts are which you want to communicate through the generated text.
Of course, Rant isn't perfect and it's easier to generate complete nonsense than something that makes sense. I am considering some new features for improving that.

At least for my case, I'm not too interested in believability (though I can certainly see other use cases where that would be important). Since I'll mainly be using it to generate appropriately sized text for layout and testing purposes, the content can be total nonsense as long as it "looks" like real text (long and short sentences with a mixture of long and short words, good distribution of letters, etc.)
Given that, lets say I want to generate 3 paragraphs with 7 sentences each (of varying lengths). What would be the easiest way to do that? Would I need to write out each paragraphs as a template?

In that case, the pattern is quite straightforward. Here's one that uses simple alphabetical nonsense:
[case:sentence]
[rs:3;\2,N]
{
	[rs:7;\s]
    {
    	[rs:[n:5;16];\s]{[r:[n:1;8]]{\c}}.
    }
}

Sandbox link

That is fantastic - exactly what I was looking for. Thanks a lot!


Fix for btrace print for memory leaks

Thanks, fun fact: looks like clang converts va_varg to pointer (wondered why I overlooked this).


Add support for path dependencies in crates.io uploads

Hi,
I have the following error when I run cargo package:
> cargo publish
    Updating registry `https://github.com/rust-lang/crates.io-index`
   Packaging glib v0.0.1 (file:///home/imperio/rust/glib)
   Verifying glib v0.0.1 (file:///home/imperio/rust/glib)
    Updating registry `https://github.com/rust-lang/crates.io-index`
failed to verify package tarball

Caused by:
  no matching package named `glib-sys` found (required by `glib`)
location searched: registry https://github.com/rust-lang/crates.io-index
version required: ^0.1.0

The problem is that I have this sublib path in the cargo.toml file:
[dependencies.glib-sys]
path = "./glib-sys"
version = "0.1.0"

No problem with the cargo build however. So I changed the line to:
[dependencies.glib-sys]
git = "https://github.com/rust-gnome/glib"
version = "0.1.0"

(which is also the link to the library).
But when I run cargo publish:
all dependencies must come from the same source.
dependency `glib-sys` comes from https://github.com/rust-gnome/glib instead

When reading the tutorial to publish library, it says that path is supported. However it seems not. Is it a bug ?
PS: Here is the link to the glib repository.

So like Dabo proposed, I think it would be nice to add path dependencies support for crates.io uploads. In the case of all rust-gnome repositories, it would be very helpful.
What do you think of it ?

Right now you'll have to publish each component of a crate independently (e.g. publish glib-sys first), and otherwise I think this falls under https://github.com/rust-lang/cargo/issues/1169 (where it would publish both at once), so I'm going to close in favor of that. Thanks for the issue though!

But #1169 is a totally different issue. It is not about uploading a different package but includes sub-crates into a package.
I do not see how path dependencies should be harmful as long as they get uploaded to crates.io like any other file in the package.

I agree, #1169 is different.
@alexcrichton Can you reconsider re-opening this issue? It may not be a good idea in the end but it's worth discussing.

@real-or-random what do you see the outcome of this issue being? How would this get resolved?

The idea is to allow packages with path dependencies to be uploaded to crates.io. This could be achieved by simply packaging the path dependencies along with the main crate.
A possible motivation for this could be splitting up a project into separate crates for better compilation performance/etc., or using a private fork of some other library temporarily.

Such a feature is basically entirely incompatible with all of Cargo right now, and would require a significant rewrite from the ground up to support unfortunately.

Looking at projects such as imag, which is [spread over > 30 crates] (https://crates.io/search?q=imag), I had the feeling that packaging path dependencies will be a very useful feature and that #1169 is the wrong reason to close it. I don't have any specific outcome in mind.
I'm new to rust and I'm probably the wrong person to judge the effort to build this but even some notion of a group (just on crates.io, independently of cargo) will help in certain scenarios (this will be closer to #1169 then).
On the other hand, there was a deliberate decision to use a flat namespace, and it's possible to create "meta-crates" which do nothing but depending on other crates if you want groups.

It sounds like the requested feature, in terms of cargo internals, would be to support packages that have multiple library crates. That feature is quite large and is explicitly not supported by Cargo today, but it sounds like it would solve the use case here I believe. If you'd like to open a dedicated issue for that, please feel free to do so!

@alexcrichton we can't release stdsimd on crates.io anymore without publishing stdsimd-test :/

@alexcrichton Hi, my idea is that sub crates with package.publish = false should be uploaded.

This is hitting us with noria as well. Specifically, I'd like to publish the sub-crate noria-server, but it internally contains three relatively large (private) sub-crates (dataflow, mir, and common). While it would be possible to turn all those sub-crates into modules, it makes compilation painfully slow.

This just bit me. I think it should definitely be fixed, though in the mean time it could at least be made less annoying. First, the error message I got is not great:
error: all dependencies must have a version specified when publishing.
dependency `my_internal_crate` does not specify a version
Note: The published dependency will use the version from crates.io,
the `path` specification will be removed from the dependency declaration.

Confusing - why is it complaining about versions? I only got a clue that this was the problem from the very last line. I suggest something like this:
error: all dependencies must be specified by version when publishing but
dependency `my_internal_crate` is only specified by path.
Note: If you specify both `path` and `version` for a dependency then
`path` will be used locally but `version` will be used when published.

Second none of the documentation on path mentions this pretty big limitation!
I would add a comment in this section saying something vaguely like

Note: path is ignored when publishing on crates.io. Crates.io does not support internal crate dependencies - all of your path dependencies must be published as separate crates and referenced by version.

On this page it does at least tell you:

If you publish the crates in the workspace to crates.io, each crate in the workspace will need to be published separately. The cargo publish command does not have an --all flag or a -p flag, so you must change to each crate’s directory and run cargo publish on each crate in the workspace to publish the crates.

But it's right at the bottom! I'd suggest moving it higher or making it into a yellow warning box (assuming you can do that).

I also think this issue should be reconsidered and fixed. We want to be able to separate the project in different crates to improve the project organization, but we don't want them to get published.

One way this could at least be improved is to have an "internal" flag in Cargo.toml to prevent the crates showing up on crates.io.

+1 for this feature

This really needs to be addressed. This makes it so hard to maintain proc macro crates

+1 for this issue making proc macro crates even more of a nightmare to deal with than they already are

I created a crate for this:

create an armory.toml in your Cargo Workspace with a version = "your_current_version" field
Run cargo install cargo-armory
Run cargo armory -> select whether you want to release as a patch, minor or major

https://docs.rs/crate/cargo-armory/0.4.1


Crisper ignores crossorigin attribute on script tag

Running crisper --source file.html --html c.html --js c.js over a file that contains script with crossorigin attribute produces html code without crossorigin attribute.
Source:
<html>
  <body>
    <script crossorigin="anonymous">
      (function() {
          'use strict';
          console.log('foo');
      });
    </script>
  </body>
</html>

Resulting html:
<html><head><script src="c.js" defer=""></script>
    <meta charset="UTF-8">

We can try to get a fix in for this soon, but Cripser is going to be deprecated in favor of the Polymer CLI, and likely a build option to externalize scripts. cc @FredKSchott for context

Thanks, I'll check if Polymer CLI behavior is different in this aspect and file a feature request if needed.

We're still working on getting the CLI to do exactly what Cripser does, so it may be fast to fix this in the short term. Just a heads up for longer term.


Image Command is a Blank Line in Commands.sql

While setting up a LocalBooru, I noticed the image part of the commands setting is not showing up in the generated commands.sql file. I'm using:
INSERT INTO posts(creation_date, hash, image, height, width, ext, rating, tags, directory, active_date) VALUES(NOW(), "%md5%", "%md5%.%ext%", %height%, %width%, ".%ext%", "%rating%", " %all% ", "1", "20110619");
The tags and the file update command are all there. Just the INSERT INTO posts is a blank line instead of writing the command.

Indeed, I also get
SQL execution of "."

Instead of the normal command that should come up. I'll investigate and come back here ASAP when I know the reason (and upload an update if necessary).

It should have been fixed by that last commit.
Note that the wiki also missed one of the commands you have to set (in the "Commands > Image" setting):
copy "%path%" "/your/path/to/gelbooru/images/1/%md5%.%ext%"

Awesome, thanks so much. It's working now. It's all running flawlessly. No crashing at all.


style issues

style issues in the notebooks: size pictures and color titles

and

1. Jupyter Notebook

seems to work


UTF8

Does this lib support utf8 ??

Yes, the JSON5Parser constructor accepts a TextReader, so you could do the following.
var reader = new StreamReader(@"C:\test.json", Encoding.UTF8);
var parser = new JSON5Parser(reader);


Proper kind for exit nodes.

Give exit nodes the kind 'exit', as that's a bit easier to understand than a point with kind 'minor_road'.
Connects to mapzen/vector-datasource#160.
@rmarianski could you review, please?

:+1:


Prelease QA Pass

Website

[x] User creation
[x] User Login in website
[x] Check all the important URLs route on the site, navigating between them and confirming that login is respected

[x] Verify that all tabs in the main page load correctly: GPS Traces, User Diaries, Copyright, Help, About
[x] Verify that all URLs in the breakdown of user name work correctly: My Dashboard, My Messages, My Profile, My Settings, My Preferences

[x] Verify that enhanced inspector is loading. For example, this Way should load a slideshow with photos. If it does not, that usually means we need to adjust our injection code to target changed HTML in the upstream code.
[ ] Search for a location using the search bar
[x] User logout

iD

[x] Make edition for each object (Edit, Update and Remove): node, way, relations in  dates start_date=1800  and  end_date=2023 and make sure to add a name name=<uniq> , because name is gong to be used to test in nominatim

Make an edit with something we know is symbolized clearly on the map
Examples: Landuse, Buildings, highways, POI

- [ ] Upload changesets
- [ ] View the changeset and note if session persists

JOSM

[ ]  Edit in JOSM and confirm we can push to right place: staging or production

https://staging.openhistoricalmap.org/api
https://www.openhistoricalmap.org/api

[ ] Check authentication in JOSM
[ ] Make some random editions with range of date
[ ] Upload changesets

Minute replication reflects  the changesets

[ ] http://planet.openhistoricalmap.org/
[ ] http://planet-staging.openhistoricalmap.org/

Tiler

[ ] Confirm that the edit is appearing in the vector tiles in a timely manner (10 min)
[ ] Play with the range dates in the website, according the start_date  and  end_date tags of the features.

Nominatim

[x]  Test searches on Nominatim, for a known working thing.
[ ] Add something new to OHM that Nominatim will search, then confirm it is searchable

https://nominatim-staging.openhistoricalmap.org/
https://nominatim.openhistoricalmap.org/

Overpass

[ ]  Use overpass turbo to query Overpass to confirm that new edits are showing up

https://overpass-turbo-staging.openhistoricalmap.org/
https://overpass-turbo.openhistoricalmap.org/

Taginfo
Note: taginfo is been updating every week, so it may not be necessary to test.

[ ]  Confirm TagInfo is consuming and updating diffs

https://taginfo-staging.openhistoricalmap.org/keys
https://taginfo.openhistoricalmap.org/keys

Test items added via iD:
https://staging.openhistoricalmap.org/changeset/99355#map=19/37.90603/-122.54691&layers=D

Search from website is failing:

Search on nominatim is fine:
https://nominatim.openhistoricalmap.org/search.html?q=oakland
Staging tiler is down:

Staging Overpass Turbo is failing:

This could be because the Staging Overpass API has been down for a few days it turns out:

Staging taginfo is disabled at the moment. NOt sure we need to worry about that since we've not made changes there

@Rub21 found that

because of the amount of data that we are processing, weeks ago we exported all production data into staging, and maybe also mismatched data that is happening. to solve that we need to re-export the dat into empty EBS

So we did that.
But we still have the status monitor showing Staging Overpass offline, and it does seem to be showing 503 https://overpass-api-staging.openhistoricalmap.org/api/status
On the plus side, I see staging tiles at https://vtiles-staging.openhistoricalmap.org/#2/29.9/-77.08

And searching on the staging website now works:
https://staging.openhistoricalmap.org/search?query=oakland#map=9/42.6633/-83.3862&layers=O&date=1923-01-01&daterange=1923-01-01,2023-12-31


Align UserType

UserType enum should be advisor instead of adviser

Hey @amhudson was this completed in 3.6.0 or will it be done in 3.6.1?

3.6.0


chore: updated prompts to latest demo.js

it resolves #33
It would be good to have a script for auto-gen README.md to make sure it's up-to-date, but I'll leave it as future work

accepted your request! thanks!


compact: Add a first pass of retention at the start of the compactor loop.

This PR tries to address issue #1708, with the fixes discussed there.
We cannot totally move the retention policy apply at the start of the compact loop, but we can add a first pass than only apply a retention that is safe, in that it'll enable us to downsample the other resolution levels.
Tested : actually I've stumbled upon the problem in a real-world scenario :

[x] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes

Verification

@obiesmans Could you please rebase this PR? I promise I'll personally pay my attention to it


Add custom buttons on Amundsen UI and allow configurable actions upon clicking

Expected Behavior or Use Case
Amundsen currently surfaces high watermark and low watermark for partitioned tables. However, our data warehouse solution does not partition tables and we want to get realtime high watermark for tables. Databuilder that runs at fixed schedules for batch data is not a good fit for this purpose. We would like to have a button sitting together with Tags, Owners on the left side of the table detail page, so that upon clicking, it queries metadata service to fetch the real time high watermark and display it on the page. I can imagine this is very useful for non partitioned tables and ETL tasks that run frequently, for example, every 3 hours.

Service or Ingestion ETL
Frontend, Metadata
Possible Implementation
As the first section says
Example Screenshots (if appropriate):
Context

Getting something working locally with fake data as a POC.
https://github.com/youngyjd/amundsen/pull/11
I think this is very useful.
The cadence of Amundsen databuilder job and etl jobs are not always the same. For people who care about the freshness of the data, we can have some kind of fetch mechanism to fetch freshness, like data preview.
What do you think? @feng-tao @Golodhros @danwom

the questions would be: 1. which metadata will be refreshed (e.g how to make refresh generic); 2. UX; 3. how to handle different DW.
Also if we support push pattern (e.g instead of send the metadata to graph db, send it to kafka/pub sub with stream pipeline and persist into graph db) will it solve the use case?


Cant install DBEAVER exe on windows 10

Operating system (distribution) and version: windows 10
DBeaver version: 21.1.0
Java version 11
Additional extensions

Describe the problem you're observing:
when i tried to install windows enterprise edition it shows installing but never complete.

plz suggest how to fix this error.

Maybe the installer was corrupted during download. Or some local software blocks further installation.
Did you try to download another version? (e.g. 21.0)


[CT-2557] [PR Tracking] add negative part number test case for split part cross db util #7200

Tracking for:

PR #7200
Original issue https://github.com/dbt-labs/dbt-bigquery/issues/615

Re-creating in dbt-bigquery for simpler logistics


Added in functionality again.

Saw you removed this functionality when you updated to support Delphi 11. Was that intentional or?

No, I removed it by error...


luci-app-dockerman: fix stats page always blank

I have never saw stats page has any 'stats', maybe dockerd call ps -aux or ps -ef on openwrt host, which not supported.
CPU usage and Memory usage does not depends on docker:top, always show on container running (docker:top status code is not 409).

Merged, thanks!


Change teaser image of the Volunteering proposal blog post

I have changed the previous teaser image with the new suggested teaser image.

Please use the .webp format for our images to keep the maximum quality and the minimum size.
Thank you very much!

I have changed the image format : )

Thank you very much for the update!


Getting an error related with options in MultiSelect

OS: Manjaro | Browser: Microsoft Edge Version: 132.0.2917.0
I'm getting an error related with the CoreUI MultiSelect. First of all I have an array of items with data charged from an API. This is important because I can load static data, but dynamically nope (coming from the API).
The point is I'm getting the following error, knowing that my array loads correctly the data and other similar components like react-multi-select-component work perfectly fine.
Waiting a response!

@paskibiorem for PRO components, we have dedicated support. Please use this form - https://coreui.io/support/

That would be wonderful c:

Please send it to<EMAIL_ADDRESS>


Support for .srt transcript

Hi, thanks for this plugin !
Would it be possible to add support for the standard .srt format ?
The json format you use doesn't seem to be standard, which makes it less future-proof I guess ?

Hey glad you like it. Do you have a link to the .srt format docs? The json is nice because it's what OpenAI Whisper outputs and you can put any additional information in it. I'm guessing the .srt format only supports words and timestamps, but it might work for now.

Hi, thanks for your reply !
The .srt is also a standard Whisper output (in fact, the default one along with .txt. and .vtt if you run whisper yourfile.mp3).
You'll find information here : https://en.wikipedia.org/wiki/SubRip
What information does your plugin need, other than a timestamp and associated text ?

Ahh I didn't know that, thanks. Right now it just needs those two. It may not need anything else in the future, but it could make sense to store other info about the audio file, such as its title/name, the current playback position, etc in the "transcript" file. Right now that file only contains the transcript, but since the file is specific to a given audio file / podcast it may make sense to add other info specific to the audio file to the json in the future.

On one hand, I agree. On the other hand, you may also want to expand your plugin from a strict audio -> text workflow to a audio <-> text double sided workflow, where you can for instance have a specific text view (based on a .srt file ?) and you can click on each sentence to launch the audio file at the right moment.
Here is an example, not based on your plugin (yet!). In that case, I guess you could imagine adding other information but still remaining within the .srt format and still be more human readable than a json
https://user-images.githubusercontent.com/24638389/211782286-7de9ccc6-b553-4e62-af08-c8d313ecd6f0.mov

I just added support for .srt files as transcripts in the latest version (0.2.7). If you update the plugin, you should be able to use your .srt file directly in the transcript: ... attribute.

Wow that's great, thanks !

On one hand, I agree. On the other hand, you may also want to expand your plugin from a strict audio -> text workflow to a audio <-> text double sided workflow, where you can for instance have a specific text view (based on a .srt file ?) and you can click on each sentence to launch the audio file at the right moment. Here is an example, not based on your plugin (yet!). In that case, I guess you could imagine adding other information but still remaining within the .srt format and still be more human readable than a json
demoTranscript-480.mov

Hi, @Limezy!
How did you achieved that behaviour that clicking on timestamps moves audio player to that moment?


NFS options incompatibility with Git

Hi,
If you try to run « git add README.md » inside a network_dir, there is a permission denied error, caused in theory of a disk full or a wrong permissions.
The permissions are correctly set, owned by gonano user, the disk isn't full, and a « git init » works correctly ( folder .git created )
If you try without the network_dirs option, this works correctly. This seems to be a bug in the NFS options, surely something to tweak to prevent this.
Currently, our company can't uses nanobox to host our Git repositories.
After some researches and help from @danhunsaker we've discovered the problem come from incompatibility of NFS options with Git.
We've found this article from GitLab and this is a problem that could be solved from server/client options with NFSv4.
They recommend to use NFS v4 and the server options no_root_squash and sync, and the client options defaults,soft,rsize=1048576,wsize=1048576,noatime,nobootwait,lookupcache=positive
Could you please upgrade to NFSv4 and permit to use EVAR to customize server/clients options?
run.config:
    engine: nodejs
    extra_packages:
        - git

data.storage:
    image: nanobox/unfs:0.9

web.site:
    start: sleep 365d
    network_dirs:
        data.storage:
            - storage

Logs:
$ git add README.md
fatal: error when closing sha1 file: Permission denied

Regards,

Unfortunately the unfs project doesn't support nfs v4.


add rclone_flg to check if upload to gdrive.

add rclone_flg to check if upload to gdrive.

Thanks


[explore] Certified metric icons are various sizes on Metric control

Screenshot

Description
The 1st metric on the metric control has the certification icon as a little dot - circled in red on the image. The other metric later in the list has a normal sized icon.
Both icons should be the same size (the 1st icon should be same size as the later metric)

Similar issue in the past (but on search left tab) https://github.com/apache/superset/pull/12690

@junlincc Can you assign this to me? I'm working on it.

Thank you Michael, noted!


Change GetWebSectionPageResponse to add teaser headlines

Change GetWebSectionPageResponse to meet requirements for BUZZ-169 (Get headlines for the Schlagzeilenbox)

My proposal is to mutate the WebArticle for the SectionPageResponse to exchange the headline with the short headline, if present (see Schlagzeilen)


[rule:no-redeclare] not working in babel-eslint

I am using eslint v1.9.0, node v5.0.0 and babel-eslint v4.1.5.
I was trying to use no-redeclare rule in eslintrc file.
{
    "parser": "babel-eslint",
    "rules": {
        "no-redeclare": [2, { "builtinGlobals": true }]
    }
}

And code as:
let mine = 23;
let mine = 34;

console.log(mine);

Ideally this should give me no-redeclare error but it didn't.
When I removed the parser configuration from eslintrc and replaced let with var it gives me the expected error.

Can you check eslint 1.10.2 and babel-eslint v5.0.0-beta4?

@hzoo  Tried it. Still not working with latest eslint and babel-eslint

I have same issue.
I am using eslint v2.5.3, node v5.9.1, babel-eslint v6.0.0.

This should be fixed in 6.0.4. Can anyone of you confirm for your usecase?

Yup this seems to work fine with<EMAIL_ADDRESS><EMAIL_ADDRESS>and<EMAIL_ADDRESS>

@danez Thanks! It works fine with<EMAIL_ADDRESS><EMAIL_ADDRESS>and node v6.2.0.


/logs does not handle log rotation correctly

The winston logger rotates logs by appending a number to the end of the normal log file, resulting in the newest log file being called (for example) mb3.log.  The /logs file only reads mb.log.

Incorrect bug - the newest file is always mb.log AFAICT


urlSync change window.location.pathname

I want change window.location.pathname with category slug. I need this for two reasons

New path will be tracked by Google Analytics using ga('set', 'page', '/new-page.html');
Sharing a beautiful url is always better than a dirty long url.

Is there a way to define a custom getFullURL function?

Hey Hi! I am not sure to completely understand your usecase. Maybe you could have /categories landing pages that would instantiate instantsearch.js instances on their own with some default parameters? That way the pathname would already be the right one.

I have already done that @vvo. For example at category page (/women-clothes) if I click on a sub category (dresses) in hierarchicalMenu widget I want pathname to be /dresses.
My current configuration:
var locationPath = window.location.pathname;
var searchParameters = {
    hierarchicalFacetsRefinements : {category: ['Women > Clothes']}
}
var defaultParams = {
    appId: 'XXXXXX',
    apiKey: 'XXXXXX',
    indexName: 'XXXXXX',
    searchParameters: searchParameters,
    urlSync:{
        useHash: false,
        trackedParameters:['query','page','facetsRefinements','disjunctiveFacetsRefinements','numericRefinements']
    }
}
var search = instantsearch(defaultParams);
var firstTime = true;
search.on('render', function() {
    $('#categories a').click(function(){
        locationPath =  '/'+$(this).data('slug');
    });
    if(!firstTime){
        ga('set', 'page', locationPath);
        ga('send', 'pageview');
    }
    firstTime = false;
});

Then I downloaded instantsearch.js and edited that line;
function getFullURL(relative) {
    //return getLocationOrigin() + window.location.pathname + relative;
    return getLocationOrigin() + locationPath + relative;
}

So I will need to check new versions of instantsearch.js, download again and update :confounded:
But such a solution would be great:
var defaultParams = {
    appId: 'XXXXXX',
    apiKey: 'XXXXXX',
    indexName: 'XXXXXX',
    locationPath: window.location.pathname,
    searchParameters: searchParameters,
    urlSync:{
        useHash: false,
        trackedParameters:['query','page','facetsRefinements','disjunctiveFacetsRefinements','numericRefinements']
    }
}
var search = instantsearch(defaultParams);
search.on('render', function() {
    $('#categories a').click(function(){
        search.helper.setLocationPath('/'+$(this).data('slug'));
    });
}

If your website is able to show a webpage when /dresses is loaded (so that link can be copy pasted/refresh) then I am down thinking about providing the feature you are talking about.
Basically it would mean provide an API option in urlSync like urlSync.computeURL that would be called:

before updating the url bar
for each widget asking to create a URL (so that the generated URLS for hierarchical menu can also be using /dress)

And allow you to change it. We should be careful about the back button => it should still work.
 Since you can issue google analytics tracking hits programmatically.

Yes my website shows a webpage for each item in hierarchical menu. I can configure google analytics for all urls but that has some disadvantages.

Google likes clean and simple urls
Sending google a url like .../...?q=w&p=0&dFR[brand][0]=XX&dFR[brand][1]=YY&.... does not seem a good opinion. This will also increase page views because this will send 5 views for a search like "q=white"

Maybe turbolinks can be a solution for this?

Do you have any plans for this issue @vvo ?

@tecmusti Revisiting this issue I will try to get it right:

You want to have pages like /dresses, when accessed should display dresses
You want the links in your hierarchicalRefinementList(s) to go through /dresses/red

To solve this, you would only need to be able to provide a hook (function) here: https://github.com/algolia/instantsearch.js/blob/6291bfc47e9b91a0c8ea947355c9f68851187d20/src/lib/url-sync.js#L79
If this is all you need then why not submit a pull request? As an example, I recently added a way to provide a different History.state at each url render (urlbar/refinementList urls): https://github.com/algolia/instantsearch.js/commit/989856cb12c797c881301963c118e2d2b10aa63b
Otherwise I will try to have a go at it. Please confirm to me that this is the only need that would be required to you.

@vvo Providing a hook for getFullURL function will solve my issue for now. Sorry but I don't know how to submit a pull request :(

This issue is very old, I hope @tecmusti you managed to solve it somehow, if not please open a new one (you will see there's a new issue template for you to easily create an example jsfiddle).
If you can get a precise feature proposal then we should be able to implement it.

confounded


Where can I find some documentation about URL parameter?

Hi,
when I apply a filter I see something like:
?filename=dati%2Fsomministrazioni-vaccini-latest.csv
&filters=fornitore%3DJanssen
&sha=9e6a9f4a150e6b96ef52827e0e2692274d68701e
&sort=data_somministrazione%2Cdesc
&stickyColumnName=data_somministrazione

For some I can deduce the meaning. Is there a page with documentation?
What's a stickyColumnName, what is it for?
What's the date format I must use for date fields? etc.
Thank you

I second that request. Your flat data viewer has some nifty params to pull data from commits, etc. Would be good if they were documented in this repo for us to explore data files with different url params to create and share custom data URL views.
Thanks!

The url params mirror the current state of the table, for example the "stickyColumnName" represents the leftmost-column, which sticks when you scroll right. For creating and sharing URLs, you should be able to just filter and sort as you please, then share the current url - way easier than URL hacking.
I'd love to hear about any use cases where that's not an option, though!

yeah, but I think you can create a simple md table in docs to document those parts.

I'd love to hear about any use cases where that's not an option, though!

A simple one: use fully the filters.
An example. Here I would like to filter date from 2021-03-21 to 2021-04-05. Using only the GUI I'm not able to do it. But using and understanding URL parameters, having a URL parameters README I could build a right URL, the URL I need, using unixtimestamp &filters=<myfield>=<start>,<stop>.
The same using filter on codice_regione_ISTAT. I'm not able via GUI to filter only the 19 region. Once again having a documentation I could write &filters=codice_regione_ISTAT=19,19.

Thank you

@aborruso that's a perfect example. I was also looking for something like that param line example you provided but in md table that describes each param function and uses similar syntax for examples in description column.
does not have to be fancy

Parameter Name
Parameter Values
Description

filters
<field1>,<field2>
Filter to apply to the flat data view

...

Yes @RandomFractals . I think it would be very useful to add the value type: in example for field mapped as date it's necessary to use Unix timestamp, etc.

right, so, I think supported data types and filter data formats should be listed too. good point!

Since this isn't supported functionality, it's important to be careful how we document "url-hacking". However, I can see that documentation being useful, if either of you wants to take a stab at it.
The relevant code lives in these two places:
https://github.com/githubocto/flat-viewer/blob/main/src/components/repo-detail.tsx#L39-L40
https://github.com/githubocto/flat-viewer/blob/main/src/components/json-detail-container.tsx#L24-L30

I'll let @aborruso take a stab at it. Good to know where to look tho. Thanks for those code links.
btw, I was going over your open requests. Added this bit for folks looking for charts for now: https://github.com/githubocto/flat-viewer/issues/17#issuecomment-852998337


x/pkgsite: package removal request for github.com/anonie-muss/configurature

Hello,
Please remove this package and all references to it. Let me know if you need me to provide any more information.
Thanks!
-A

Why is a retract insufficient?

I am moving repos and I believe that duplicate entries will be confusing.

*to a different github account

Done, and should take effect within the next few hours. Please comment if not.


User creation to check unique email and prompt error

Currently no check.

Need to add "unique" to validation.

Fixed on both version 0.2 and 0.3.


Fix deprecation with next version of League\OAuth2

This PR fixes deprecations triggered by the SymfonyConnect:

Method "League\OAuth2\Client\Provider\AbstractProvider::getBaseAuthorizationUrl()" might add "string" as a native return type declaration in the future. Do the same in child class "Qdequippe\OAuth2\Client\Provider\SymfonyConnect" now to avoid errors or add an explicit @return annotation to suppress this message.

The composer's file of this project does not contain a minimal version for PHP, I assume, that all versions are supported.
But their is the league/oauth2-client: ^2.0 constraint that implicitly requires the minimal version of league/oauth2-client 2.0 which is PHP >=5.6.0.
The scalar return type was introduced in PHP 7.0, That's why, I couldn't add a proper return type in this PR, and I had to use a doc bloc + annotation

Thanks @jderusse 👍


[BUG] "error: no matching function for call to 'hipblasHgemm'" when compiling for Rocm.

Describe the bug
For some reason I can't compile AutoGPTQ for my RX 7900 XTX.
Seems like it fails at:
/path/to/AutoGPTQ/autogptq_hip/exllama/hip_func/q4_matmul.hip:260:5: error: no matching function for call to 'hipblasHgemm'
but I have attached the entire log below.
Hardware details

CPU: AMD Ryzen 7 5800X (16) @ 3.800GHz
GPU: AMD Radeon RX 7900 XTX

Software version

Arch Linux
Rocm: 5.6.0-1

To Reproduce
Steps to reproduce the behavior:

Make a venv.
Clone the repo and cd to it.
Run PYTORCH_ROCM_ARCH=gfx1100 ROCM_VERSION=5.6 pip install .
Build fails with https://gist.github.com/xGigaa/88d631672dc6f2a665682390d2b095e6

Expected behavior
AutoGPTQ compiles successfully.

Closing, had a bad venv environment.
Made a new venv from scratched and it compiled successfully.

I'm currently having this issue with gfx1030 and a new venv environment did not fix it for me.  Still looking for an answer, just leaving this breadcrumb for others searching for this hipblasHgemm error.

I tried a bunch of other stuff as well in addition to this so it might be that those things fixed it instead of just a bad venv.
Here are a few things i tried:

Made a 3.10 python venv environment.
python3.10 -m venv venv

Did an export of hip bin and lib directories
export LB_LIBRARY_PATH=$LD_LIBRARY_PATH:/opt/rocm/hip/lib
export PATH=/opt/rocm/bin:$PATH

Did a reinstall of torch where I tested the newest nightly torch install with rocm.

Hope this helps in some way.

In case anyone else finds this:
diff --git a/autogptq_cuda/exllama/hip_compat.cuh b/autogptq_cuda/exllama/hip_compat.cuh
index 5cd2e85..c4afc41 100644
--- a/autogptq_cuda/exllama/hip_compat.cuh
+++ b/autogptq_cuda/exllama/hip_compat.cuh
@@ -45,5 +45,6 @@ __host__ __forceinline__ hipblasStatus_t __compat_hipblasHgemm(hipblasHandle_t
 #define rocblas_get_stream hipblasGetStream
 #define rocblas_set_stream hipblasSetStream
 #define rocblas_hgemm __compat_hipblasHgemm
+#define hipblasHgemm __compat_hipblasHgemm

 #endif

Worked for me.  Found via https://are-we-gfx1100-yet.github.io/post/text-gen-webui/

Thank you, I can reproduce the issue with RoCm 5.6 (working with 5.4.2). Will fix.

Fixed in https://github.com/PanQiWei/AutoGPTQ/pull/382


feat: android pressKey - power button

Proposed Changes
add new pressKey: power command.
Testing
appId: com.google.android.youtube
---
- launchApp
- tapOn: Subscriptions
- pressKey: power #lock screen
- pressKey: power #unlock screen

https://github.com/mobile-dev-inc/maestro/assets/6134774/44f60ed2-1744-447a-87cc-a1c7a2206b14
Issues Fixed
fix https://github.com/mobile-dev-inc/maestro/issues/1167

Hey @depapp thank you very much for this PR 🙌  The Android part looks good, but we need to also support iOS. Would you be able to expand the PR to make that?

hi @felipevolpone thanks for the feedback.
since I couldn't find any APIs for the physical power button on iOS, I think it's not supported

i would need support for the menu button (keycode: 82) - probably also only available on Android.
Would be great if we could have support for keys which are android only 🙏

@depapp Sorry for such a long delay in answering you back. Given that iOS doesn't support that, we can move forward with this PR. Could you please update with the latest main branch so we can run the tests again? As soon it's green I'll merge it.

done @felipevolpone
could you please help to recheck 🙇🏻

Awesome work @depapp! Thanks for your contribution.
We are planning a Maestro release later this or early next week, either way in the next one this PR will be there

Awesome work @depapp! Thanks for your contribution.
We are planning a Maestro release later this or early next week, either way in the next one this PR will be there

thanks @felipevolpone 🙇🏻


Jupyter Books should be collapsed/expanded using keyboard shortcuts

With multiple Books showing up its cumbersome to navigate to the root of each book to to collapse/expand levels when the books contains thousands of notebooks.
There should be keyboard shortcuts and/or menu items to do just that. Below is an example from a popular editor which has this feature.

This is a vscode issue if you don't like the existing keyboard shortcut. But items can be collapsed/expanded using the spacebar.


Airgap - workload coredns does not pull from the private registry

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):

prepare a private registry for Rancher's images
run Rancher v2.5.0-alpha2 single install in airgap environment with the option -e CATTLE_SYSTEM_CATALOG=bundled in the docker command
Rancher is deployed successfully
go to local cluster -> system project

Result:

Workload coredns does not pull from the private registry

Only affects local docker cluster

The bugfix is validated on rancher: v2.5.0-alpha3, docker install in airgap env

The image is included in the Rancher image, so it does not need to pull from the private registry.


Better networking

Change the server architecture to a more traditional pub-sub mechanism, keep track of changes in the Docker API response and only publish new changes when the response changes.
This should avoid excessive data transfers between the dashboard server and the client app, also avoiding unnecessary re-renders when nothing is happening.

Turns out docker API 1.30 supports swarm events in the stream API, which means we can get rid of the server-side polling too.
I'll do that in a separate PR though.


AWS: Support IMDSv2 on aws_instance

Currently, our AMI fails to start scylla-image-setup when the instance
configured as "Metadata version: V2 only".
To fix this we need to implement IMDSv2 support on aws_instance class.
Fixes scylladb/scylla#9987

@yaronkaikov Ah, it is because test_aws_instance.py has metadata server mock, and it only supports IMDSv1 so all metadata access test failing.
I will fix that.

Test fixed.

@syuu1228 How can we verify it's working? is there a special instance type?
in any case please run https://jenkins.scylladb.com/view/master/job/scylla-master/job/releng-testing/job/next-machine-image/ based on your branch and let's make sure it is passing. Also please run https://jenkins.scylladb.com/view/master/job/scylla-master/job/releng-testing/job/ami/ so can verify we didn't break arm as well

@syuu1228 How can we verify it's working? is there a special instance type?

There is an option to disable IMDSv1 and force use IMDSv2 (force use http token).
In Web UI it's "Metadata version: V2 only" in "Advanced details", in CLI it's like this:
aws ec2 run-instances
    --image-id ami-0abcdef1234567890
    --instance-type c3.large
	...
    --metadata-options "HttpEndpoint=enabled,HttpTokens=required"

see: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/configuring-instance-metadata-options.html
I guess we can do same in our tests on Jenkins.

Tests successed.

@syuu1228 How can we verify it's working? is there a special instance type?

There is an option to disable IMDSv1 and force use IMDSv2 (force use http token).
In Web UI it's "Metadata version: V2 only" in "Advanced details", in CLI it's like this:

aws ec2 run-instances

    --image-id ami-0abcdef1234567890

    --instance-type c3.large

	...

    --metadata-options "HttpEndpoint=enabled,HttpTokens=required"

see: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/configuring-instance-metadata-options.html
I guess we can do same in our tests on Jenkins.

I fogot describing, I manually tested the patch with "V2 only" mode and it worked.


can't go to /ghost

Hi,
I don't know why I can't access to http://localhost:2368/ghost/, it's a blank page, my vendors are not loaded...
Steps to Reproduce
git clone git@github.com:TryGhost/Ghost.git && cd Ghost
yarn global add knex-migrator grunt-cli ember-cli bower
yarn setup
yarn dev
# http://localhost:2368 is working, not  http://localhost:2368/ghost

@mlescaudron that's not the correct way to install Ghost. Follow the install docs for a production or local theme dev install, or the contributing guide for a core dev install.
If you need support please head over to our Slack channel - we use GitHub solely for bug tracking and on-going feature work, any issues asking for support/help will be closed.

Just throwing this out there - I think this is ye olde ember hasn't finished building problem? There's no indication in the CLI that it's still happening & no mention in the docs of the need to wait.


Don't display deadline including grace tokens until the group has been created

Before this, the modified deadline would always be the same as the original deadline regardless of the number of grace tokens the student currently has.
Since the minimum of the grace tokens of the members of the grouping is what counts it doesn't make sense to display this information until the grouping is created.

I'd prefer to keep the header there but give a message like "Form a group to determine how many grace tokens you have remaining" or something.


Topic request: statechains by Ruben Somsen

Whoops, this never got closed when we added https://bitcoinops.org/en/topics/statechains/


A Kafka Extensions library

Hello Confluent!
I wanted to share a project I've been working on. Our company was using RdKafka before but we have switched over to use the Confluent dotnet library because we like how raw and expose the API surface is. As a result, I've been working on an extensions library and I wanted to share it with you! The project page is:
https://github.com/wmccullough/Kafka.Extensions
The goal for me is to provide a series of extensions to help ease implementation and speed adoption of the Confluent.Kafka library. I'm not sure at which level Confluent intends to add features to your own library, but I hope I can help bridge the gap. The library is .NET Standard 1.3, so it should easily cross compile to .NET core or .NET FX.
Just wanted to introduce myself and let you know that you have a fan!

I like the fluent API style of configuring your consumers. If you put out a NuGet package I would be interested in integrating with my application that is using Confluent DotNet

cool - very interesting.
There is absolutely scope for a layer on top of the Confluent.Kafka Consumer - the API is verbose and it's pretty easy to abstract a lot of this away (I also do this in my own projects). I hadn't considered System.Reactive, will give that some thought. Note that in Confluent.Kafka we believed it was important to provide an API close to the one provided by librdkafka for full flexibility.
Ultimately we want to have a Kafka Streams implementation across languages (the streams API is currently Java only). I'm particularly excited about C# here as we have some wonderful language constructs to play with.
Please keep posting updates here - we will likely link out to your project from the main readme if it continues looking good.
Also, if there is anyone else out there with other ideas for a higher level API, also please post - i'm excited to see what people come up with.

@mhowlett Thanks for the nod! I will definitely keep adding to it. I totally get trying to maintain some manner of congruency between Confluent.Kafka and librdkafka. I've seen firsthand how one change in an underlying implementation causes ripple effects that can be hard to reconcile across abstractions. That said, I'm certainly happy to keep building extensions on top when it doesn't make sense for Confluent to adopt a specific design in the Confluent.Kafka library.
I'm thinking that next, I may add support for Microsoft.Logging.Extensions so that dotnet users can easily hook their favorite logging frameworks right on top of the reactive subscriber. I'm also not enabling multiple topics per consumer, and I know that someone will want that, so I need to modify the builder to enable that too.
Keep up the good work!

IObservable<T> would change the consumer from a pull to push model, which I don't think is what we want. I think what we probably ideally want is async streams coming in C# 8 (async enumerables).


fix docz

Removing checklist since this does not impact components.
This fixes Rollbar output so it no longer compiles runtimes that have prop-types stripped. In the long run... trying to use a config that works the same as react-scripts for the runtimes in Rollbar might not actually be the best path forward since our needs are different as a package library. We might need to have our own config that we maintain ourselves for building runtimes of components. This will mean we also needs some tests on making sure these components also work in other environments on their own. Lots of testing work to be done on the runtimes themselves separate from the unit testing.
Once this PR gets merged and we make another merge to main from develop... I think this will also deploy correctly on Netlify.

Love that you can see who reviewed and when in the timeline too.

@lordpixel this is okay to review now. No more pushes coming with builds. config updates worked.


Bump framework version

Purpose
$subject
Related Issues

https://github.com/wso2-enterprise/asgardeo-product/issues/27603

PR builder was run for the framework PR
https://github.com/wso2/carbon-identity-framework/pull/6158


QuickBooks command line tool

Add a command line tool called quickbooks-cli to automate the process of getting the access token and secret

Coverage decreased (-2.9%) to 93.823% when pulling ff5c28cc85d94f804f7a3d85c402bd4b7e396d4d on humrochagf:master into 756032f4d61c549a1c81b8b5ad1047f54e1eec97 on sidecars:master.

Coverage decreased (-2.9%) to 93.823% when pulling ff5c28cc85d94f804f7a3d85c402bd4b7e396d4d on humrochagf:master into 756032f4d61c549a1c81b8b5ad1047f54e1eec97 on sidecars:master.

Coverage decreased (-2.9%) to 93.823% when pulling ff5c28cc85d94f804f7a3d85c402bd4b7e396d4d on humrochagf:master into 756032f4d61c549a1c81b8b5ad1047f54e1eec97 on sidecars:master.

Coverage decreased (-2.9%) to 93.823% when pulling ff5c28cc85d94f804f7a3d85c402bd4b7e396d4d on humrochagf:master into 756032f4d61c549a1c81b8b5ad1047f54e1eec97 on sidecars:master.

Coverage decreased (-2.9%) to 93.823% when pulling ff5c28cc85d94f804f7a3d85c402bd4b7e396d4d on humrochagf:master into 756032f4d61c549a1c81b8b5ad1047f54e1eec97 on sidecars:master.

Coverage decreased (-3.0%) to 93.732% when pulling c4749078ce16b966c1c65c26acae9f776a41adab on humrochagf:master into 756032f4d61c549a1c81b8b5ad1047f54e1eec97 on sidecars:master.

Coverage decreased (-2.08%) to 94.609% when pulling 35c96510b21c0c72dae3846cefb351322d9ba3c0 on humrochagf:master into 756032f4d61c549a1c81b8b5ad1047f54e1eec97 on sidecars:master.

Coverage decreased (-2.08%) to 94.609% when pulling ae58262755be79f6b7749a3d9209ba522f233192 on humrochagf:master into 756032f4d61c549a1c81b8b5ad1047f54e1eec97 on sidecars:master.

Coverage decreased (-2.08%) to 94.609% when pulling ae58262755be79f6b7749a3d9209ba522f233192 on humrochagf:master into 756032f4d61c549a1c81b8b5ad1047f54e1eec97 on sidecars:master.

Coverage decreased (-2.08%) to 94.609% when pulling ae58262755be79f6b7749a3d9209ba522f233192 on humrochagf:master into 756032f4d61c549a1c81b8b5ad1047f54e1eec97 on sidecars:master.

Coverage decreased (-2.08%) to 94.609% when pulling 305d037202a2d88d8f82db2915b932b825e5e1eb on humrochagf:master into 756032f4d61c549a1c81b8b5ad1047f54e1eec97 on sidecars:master.

Coverage decreased (-2.5%) to 94.22% when pulling 5e4c127eb53465b099f08c88af60da12d9f83800 on humrochagf:master into 756032f4d61c549a1c81b8b5ad1047f54e1eec97 on sidecars:master.

Coverage decreased (-2.08%) to 94.609% when pulling 3a0c02911a61bf68ecd6734f7ac916de00d7b811 on humrochagf:master into 756032f4d61c549a1c81b8b5ad1047f54e1eec97 on sidecars:master.

Coverage decreased (-2.08%) to 94.609% when pulling 3a0c02911a61bf68ecd6734f7ac916de00d7b811 on humrochagf:master into 756032f4d61c549a1c81b8b5ad1047f54e1eec97 on sidecars:master.

Coverage decreased (-2.08%) to 94.609% when pulling 3a0c02911a61bf68ecd6734f7ac916de00d7b811 on humrochagf:master into 756032f4d61c549a1c81b8b5ad1047f54e1eec97 on sidecars:master.


Vfemail.net isn't a supported email domain

Steps to Reproduce

Go to Settings.
Try to change the email address to one that uses the vfemail,net domain.

Attachments
No response
What platform(s) does this occur on?
iOS, Android, Web (Desktop), Web (Mobile)
Device Info
No response
What version of the app are you using?
1.92.1
Additional Information
No response

What error message are you seeing? I just tried to reproduce this (by entering a nonsense email address ending in @vfemail.net) and I got to the next step fine.

This email address is not supported, please use a different email.

This email address is not supported, please use a different email.

Out of interest, do you see that error message as soon as you've typed in your email address and tapped Request Change, or only after you've typed in the confirmation code?
In any case, from what I can tell I think you're right that vfemail.net isn't a supported email domain. (But to be clear, you'll have to email support or wait for one of the team to respond here for an official answer.)
The error message you're seeing comes from here:
https://github.com/bluesky-social/atproto/blob/main/packages/pds/src/api/com/atproto/server/updateEmail.ts#L19
and it looks like the email address is not being validated because it's considered to be 'disposable'. Bluesky seems to use this package to screen out some email domains, and unfortunately vfemail.net seems to be considered disposable by that package as it's on this list (⚠ warning, large file):
https://raw.githubusercontent.com/disposable/disposable-email-domains/master/domains.txt
So I'm afraid it looks like you'll have to use another email address.

VFEmail isn't disposable though since it costs money to have a decent amount of storage and features.

I made an issue on that list's repository. It can be found at https://github.com/disposable/disposable/issues/196.

My pull request to fix it (https://github.com/disposable/disposable/pull/197) has been merged. Now to wait for the domains.txt to be updated (which will no longer have vfemail.net in it once it is updated).

Weird, the domain is removed from that list but Bluesky is still refusing it. I guess Bluesky is using an outdated list.

What can be done to have it use the latest domains.txt?

Hmm?

What can be done to have it use the latest domains.txt?

I think the issue might be that Bluesky seems to be using the npm package rather than the raw list of domains, and the npm package hasn't been updated for 8 years... 😬

That needs fixing then.

I just noticed that this has been merged: https://github.com/bluesky-social/atproto/pull/3092 which changes the packages used to validate email addresses. So when that has been rolled out – this is just a guess, but it could be anywhere from a few days to a week, but it could be longer, of course – you might want to try again, as it's possible vfemail.net will be supported 🤞
(Note that I haven't looked into the new packages being used to check, the info is in that PR if you want to check for yourself :)

I made a new PR on the repository that has the list that the PR is having Bluesky use. It is at https://github.com/disposable-email-domains/disposable-email-domains/pull/538.

How can I know if it has been rolled out?

The only way I know – there may be an easier way of course – is to look at what version the Bluesky PDSes are running here:
https://github.com/mary-ext/atproto-scraping
And then look at that git commit.
But because vfemail.net is in the disposable-email-domains package, I wouldn't get your hopes up 🤷🏻♂

The vfemail.net domain should be removed from the list the package uses soon. Just need to wait for the guy who can commit the PR I made to see the screenshots I replied with in the issue I made regarding it.

Weird, the change has been rolled out and the PR I made has been merged but the domain is still being blocked.

I think it is because it is using an outdated blocklist. So, it is going to have to be updated when a new version of that package is available. I told the guy who develops it to update its blocklist and made an issue for getting it to always using the latest one.

I made a PR to update the package version used since it was updated to use the latest .conf file. It can be found at https://github.com/bluesky-social/atproto/pull/3138. Merging it should get this issue to be fixed after the scraper shows that it has been updated.


Type guards don’t always narrow generic types

Bug Report

🔎 Search Terms

generics, narrowing, type guards
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about generics and type guards

⏯ Playground Link

This is nearly exactly how I discovered this bug.
💻 Code

/** Maps event names to an optional array of event listeners. */
type EventListeners<EventMap> = {
  [EventType in keyof EventMap]?: Array<(event: EventMap[EventType]) => void>;
};

/**
 * Given an EventListeners mapping, dispatches the given payload to event
 * listeners of the given type.
 */
function emit<EventType extends keyof EventMap, EventMap>(
  listenersByType: EventListeners<EventMap>,
  type: EventType,
  payload: EventMap[EventType],
) {
  const listeners = listenersByType[type];
  if (listeners !== undefined) {
    // This works...
    listeners.forEach((listener) => listener(payload));

    // But this doesn't?!
    for (const listener of listeners) {
      listener(payload);
    }
  }
}

🙁 Actual behavior
There’s an error on the word listeners on the line:
for (const listener of listeners) {

The error differs between target versions.
Targeting ES2015 or higher:
Type 'EventListeners<EventMap>[EventType]' must have a '[Symbol.iterator]()' method that returns an iterator.

Targeting ES5 or lower:
Type 'EventListeners<EventMap>[EventType]' is not an array type or a string type.

In context, the generic type EventListeners<EventMap>[EventType] is equivalent to Array<(event: EventMap[EventType]) => void> | undefined.
Since undefined is not an array type, TypeScript is right to complain… except that I already checked that listeners !== undefined.
🙂 Expected behavior
TypeScript should narrow EventListeners<EventMap>[EventType] to Array<(event: EventMap[EventType]) => void>, as it does when I call listeners.forEach(…).
Other findings
After some investigation, I’ve discovered the following.
Type narrowing with intersection types
With a type guard with return type obj is GuardedType, type narrowing for generics works correctly because TypeScript narrows the generic type T to an intersection type T & GuardedType.
For instance:
function isArray(obj: any): obj is unknown[] { … }
// …
if (isArray(listeners)) {
  // Now, listeners has type EventListeners<EventMap>[EventType] & unknown[].
  for (const listener of listeners) {
    listener(payload);
  }
}

(Interestingly, using Array.isArray(…) on its own narrows the type to any[] instead of EventListeners<EventMap>[EventType] & any[]. Is this expected or its own bug?)
However, if I use a type guard with return type obj is undefined and negate the result, then I see the behavior described in the issue.
function isUndefined(obj: any): obj is undefined { … }
// …
if (!isUndefined(listeners)) {
  // Still broken.
  for (const listener of listeners) {
    listener(payload);
  }
}

So, I’m guessing this means that this kind of type narrowing only works for “positive” type guards, i.e. those where the narrowed type can be an intersection type.
Type narrowing by constraint position
But then, why does listeners.forEach(…) work in both cases? Digging into the TypeScript source code and using a debugger, I found that the type of listeners differs between the listeners.forEach(…) call and the for (const listener of listeners) loop according to the following function:
// Lines 24166–24178 of src/compiler/checker.ts at 8e1bf08
function getNarrowableTypeForReference(type: Type, reference: Node, checkMode?: CheckMode) {
    // When the type of a reference is or contains an instantiable type with a union type constraint, and
    // when the reference is in a constraint position (where it is known we'll obtain the apparent type) or
    // has a contextual type containing no top-level instantiables (meaning constraints will determine
    // assignability), we substitute constraints for all instantiables in the type of the reference to give
    // control flow analysis an opportunity to narrow it further. For example, for a reference of a type
    // parameter type 'T extends string | undefined' with a contextual type 'string', we substitute
    // 'string | undefined' to give control flow analysis the opportunity to narrow to type 'string'.
    const substituteConstraints = !(checkMode && checkMode & CheckMode.Inferential) &&
        someType(type, isGenericTypeWithUnionConstraint) &&
        (isConstraintPosition(reference) || hasNonBindingPatternContextualTypeWithNoGenericTypes(reference));
    return substituteConstraints ? mapType(type, t => t.flags & TypeFlags.Instantiable ? getBaseConstraintOrType(t) : t) : type;
}

Because isConstraintPosition(…) is defined as:
// Lines 24138–24147 of src/compiler/checker.ts at 8e1bf08
function isConstraintPosition(node: Node) {
    const parent = node.parent;
    // In an element access obj[x], we consider obj to be in a constraint position only when x is not
    // of a generic type. This is because when both obj and x are of generic types T and K, we want
    // the resulting type to be T[K].
    return parent.kind === SyntaxKind.PropertyAccessExpression ||
        parent.kind === SyntaxKind.CallExpression && (parent as CallExpression).expression === node ||
        parent.kind === SyntaxKind.ElementAccessExpression && (parent as ElementAccessExpression).expression === node &&
            !isGenericIndexType(getTypeOfExpression((parent as ElementAccessExpression).argumentExpression));
}

Therefore:

When checking listeners in listeners.forEach(…):

parent.kind === SyntaxKind.PropertyAccessExpression
So isConstraintPosition(…) === true
So substituteConstraints === true
So getNarrowableTypeForReference(…) returns the type ((event: EventMap[EventType]) => void)[] | undefined
Which gets narrowed to ((event: EventMap[EventType]) => void)[] according to control flow

When checking listeners in for (const listener of listeners):

parent.kind === SyntaxKind.ForOfStatement
So isConstraintPosition(…) === false
So substituteConstraints === false
So getNarrowableTypeForReference(…) returns the type EventListeners<EventMap>[EventType]
Which cannot be narrowed any further

Straightforward solution
I believe the straightforward solution is to add a check for parent.kind === SyntaxKind.ForOfStatement in the definition of isConstraintPosition(node: Node) so that it would be defined as follows:
function isConstraintPosition(node: Node) {
    const parent = node.parent;
    // In an element access obj[x], we consider obj to be in a constraint position only when x is not
    // of a generic type. This is because when both obj and x are of generic types T and K, we want
    // the resulting type to be T[K].
    return parent.kind === SyntaxKind.PropertyAccessExpression ||
        parent.kind === SyntaxKind.CallExpression && (parent as CallExpression).expression === node ||
        parent.kind === SyntaxKind.ElementAccessExpression && (parent as ElementAccessExpression).expression === node &&
            !isGenericIndexType(getTypeOfExpression((parent as ElementAccessExpression).argumentExpression)) ||
        parent.kind === SyntaxKind.ForOfStatement;
}

However, this isConstraintPosition(…) check feels like a special case for just a few specific contexts. I can think of several examples that would cause such a check to fail:
function f1<T extends string | undefined>(x: T) {
  if (x) {
    // This works because x is considered to be in a constraint position...
    x.length;

    // But adding parentheses breaks it.
    (x).length;

    // Assigning it to a new variable breaks it.
    const y = x;
    y.length;

    // Returning it from a function breaks it.
    const getX = () => x;
    getX().length;
  }
}

But patching it to include a check for SyntaxKind.ForOfStatement would be a quick and easy fix for my use case.
More general solution
I found that if I manually cast listeners to type Exclude<typeof listeners, undefined>, then this fixes my example:
if (listeners !== undefined) {
  const listeners_ = listeners as Exclude<typeof listeners, undefined>;

  // This works...
  listeners_.forEach((listener) => listener(payload));

  // And so does this.
  for (const listener of listeners_) {
    listener(payload);
  }
}

A similar kind of cast fixes the other example I presented showing failures of isConstraintPosition(…):
type Falsy = false | '' | 0 | 0n | null | undefined;

function f1<T extends string | undefined>(x: T) {
  if (x) {
    const x_ = x as Exclude<typeof x, Falsy>;

    // This worked without the cast...
    x_.length;

    // But these didn't, and now do.
    (x_).length;

    const y = x_;
    y.length;

    const getX = () => x_;
    getX().length;
  }
}

So, I feel like the general solution would be: when a type guard cannot narrow a generic type T to an intersection type, it should instead narrow the type T to Exclude<T, …>. (Is there a situation where this wouldn’t work?)
Let me know what you all think, and thanks for creating my favorite programming language!

As you saw, type-guarding generics is done via intersections.  Negating the result of an undefined guard would therefore require https://github.com/microsoft/TypeScript/issues/4196.

My proposal in the “More general solution” is to use Exclude<T, undefined> for such a scenario instead of an intersection. Would this not work?

I'm thinking this is the same issue - if it's not, will create a new issue:
function isDefined(value: unknown): asserts value {
  throw new Error();
}

interface Tx {
  v1: string[];
}

interface Mx<TOptions extends readonly unknown[]> {
  settings: Tx;
  options: TOptions;
}

const getOptionValue = <TOption extends keyof Tx>(
  context: Mx<readonly [Partial<Pick<Tx, TOption>>]>,
  key: TOption,
): Tx[TOption] => {
  const optionValue = context.options[0][key];

  if (optionValue) {
    isDefined(optionValue);

    // TS2322: Type 'Tx[TOption] | undefined' is not assignable to type 'Tx[TOption]'.
    //  Type 'undefined' is not assignable to type 'Tx[TOption]'.
    //    Type 'undefined' is not assignable to type 'string[]'.
    return optionValue;
  }

  return context.settings[key];
};

I can make TS happy in a few ways:

use !: return optionValue!
add ?? undefined to the assignment: context.options[0][key] ?? undefined
add ?? context.settings[key] to the assignment.

Ah, it seems like this issue might be a duplicate of #22137, which will hopefully be fixed by #22348.

Not sure if this is the same, but there is something similar:
class Gen<T extends string | undefined = string | undefined> {
    isUndefined(): this is Gen<undefined> { ... }
}
const g = new Gen();
if (g.isUndefined())
    throw new Error(); // correctly narrowed to Gen<undefined>
// but undefined isn't excluded here


Automated screenshot generation

For template upload, we currently screenshots are manually taken and uploaded to s3 bucket. With this task we want to automate this process with minimal human intervention.
PRD: Notion doc

Moving this to CS


Fix issues with port definitions

Caravel fails to build with recent Icarus Verilog versions because some of the port definitions are not valid.

If the ports are specified in parenthesis (called ANSI-style) after the module name this is not valid. If the ports are specified inside the module body (called non-ANSI style) it is valid.
// Invalid
module test(input i);
  wire i;
endmodule

// Valid
module test;
  input i;
  wire i;
endmodule

Both the Verilog and SystemVerilog reference manuals explicitly call this out.

Each port declaration provides the complete information about the port. The port’s direction, width, net or
variable type, and signedness are completely described. The port identifier shall not be redeclared, in part or
in full, inside the module body.

But considering that there is code that uses this, it might make sense to add a switch to iverilog to allow this as an anachronism.

@RTimothyEdwards

But I've been using the original syntax for years---there's nothing wrong with it, and it has no errors with other tools that read verilog. The problem is in iverilog. Version 13 has broken something.

This syntax also fails on Verilator, so it makes sense to merge this regardless of if iverilog adds a flag.

@jeffdi :  Please merge this.

Is anyone still hitting this? It still seems to be an issue.
`When you change to the test directory: verilog/dv/io_ports
and run make
You get the following error when you are using the latest version of iverilog (as distributed with the  OSS_CAD_Suite
Icarus Verilog version 13.0)
/root/eda//caravel_user_project/verilog/rtl/user_proj_example.v:74: error: 'io_in' has already been declared in this scope.
/root/eda//caravel_user_project/verilog/rtl/user_proj_example.v:64:      : It was declared here as a net.
/root/eda//caravel_user_project/verilog/rtl/user_proj_example.v:75: error: 'io_out' has already been declared in this scope.
/root/eda//caravel_user_project/verilog/rtl/user_proj_example.v:65:      : It was declared here as a net.
/root/eda//caravel_user_project/verilog/rtl/user_proj_example.v:76: error: 'io_oeb' has already been declared in this scope.
/root/eda//caravel_user_project/verilog/rtl/user_proj_example.v:66:      : It was declared here as a net.
/root/eda//caravel_user_project/verilog/rtl/user_proj_example.v:138: error: 'ready' has already been declared in this scope.
/root/eda//caravel_user_project/verilog/rtl/user_proj_example.v:134:      : It was declared here as a net.
/root/eda//caravel_user_project/verilog/rtl/user_proj_example.v:139: error: 'count' has already been declared in this scope.
/root/eda//caravel_user_project/verilog/rtl/user_proj_example.v:136:      : It was declared here as a net.
/root/eda//caravel_user_project/verilog/rtl/user_proj_example.v:140: error: 'rdata' has already been declared in this scope.
/root/eda//caravel_user_project/verilog/rtl/user_proj_example.v:135:      : It was declared here as a net.`


[Question] limitations of Python script

Question
Hi, I’m interested in getting an EuroPi but I have some questions about it. In particular:

is there a size limit for a Python script to be suitable for EuroPi?
must the whole Python script be written as a single file or can it use local modules and packages?
can the script make use of locally saved files, e.g. a .csv file?
does it support scripts that use Python's Standard Library?

Many thanks in advance!

is there a size limit for a Python script to be suitable for EuroPi?

The Pico has 264kB of SRAM, and 2MB of on-board flash memory, however Micropython leaves you with about 1MB flash memory. The EuroPi + ssd1306 libraries takes about 30k, so those are your memory constraints.

must the whole Python script be written as a single file or can it use local modules and packages?

The firmware uses MicroPython which behaves just like Python and allows importing of packages.

can the script make use of locally saved files, e.g. a .csv file?

Yep! We use this functionality in our  Save/Load State functionality [docs | code]

does it support scripts that use Python's Standard Library?

Yes, anything that MicroPython supports can be used in your script.

MicroPython is a lean and efficient implementation of the Python 3 programming language that includes a small subset of the Python standard library and is optimised to run on microcontrollers and in constrained environments.

I would suggest taking a look at the user contributed scripts to get a sense of what can be done with the EuroPi: https://github.com/Allen-Synthesis/EuroPi/tree/main/software/contrib

@awonak Thank you so much for your detailed answer, this is super useful! I really appreciate it.

Closed?


GPS tracker fix (to draw the polygon for your record)

[ ] ensure that the GPS on the ipad is communicating accurately with InvasivesBC
[ ] enable the "track polygon" using the GPS on the forms to work (ask @micheal-w-wells  how to do this)
ONLY IF DONE IN ONE DAY.

@plasticviking if you have throughput you can snag this one, I'm out of here until Tues so won't have time.  Check out the capacitor geolocation plugin that handles background gps and look at swapping it out.   take a peek at the pr that was merged / reverted for the branch with the most complete code.


[Feature] Improve the user experience of Backspace button

Step to reproduce

Enter /
Select Heading from the command list
Enter a few words
Then keep clicking Backspace until all text is deleted
Double click Backspace, then enter /

Expected behavior
The / command triggered again.
Actual behavior
Stuck in Heading state.
Describe the solution you'd like
After double Backspace in step 5, the state of the current line should reset to default plaintext.
Additional context
I tried a few times, after [step 2], there is no easy way back to the original state, which is empty plaintext with / command ready.

https://github.com/ProseMirror/prosemirror/issues/1018


fix: skip prettier if no files are found

:tada: This PR is included in version 1.0.4 :tada:
The release is available on:

v1.0.4
npm package (@latest dist-tag)
GitHub release
v1.0.4
v1.0.4

Your semantic-release bot :package::rocket:


May I ask if there are ViT-Adapter and BEiTAdapter in the network trained in Cityscapes, is there any difference?

Hi, I only trained BEiTAdapter using BEiT pre-trained weights on Cityscapes. The network architecture of ViTAdapter and BEiTAdapter are the same, except BEiT uses relative position encoding.


Donut chart available?

Hi all. I was wondering if this kind of pie chart is possible with this library? If yes, how does one go about creating this?

Is there any update on this?

hi there, any update ?

What about this is 2024?

hi there, any update ?

hi there, any update ?

My solution for Donut chart + label inside is use WebView like https://github.com/dpwiese/react-native-canvas-charts but use original article https://danielwiese.com/posts/react-native-canvas-charts/ for create my component with last version v.4 chartjs.

I think placing a round view with white background over pie chart can do the trick.

https://github.com/dpwiese/react-native-canvas-charts

hi there, any update ?

Yes. I'm still dead curious with this..


How to have Datatable scroll horizontally

On the Tables page, we want to avoid having Responsive feature of having columns hidden. So we disabled following,
$(document).ready(function() {
    $('#dataTables-example').DataTable({
        //responsive: true -- Commented this line
    });
});

The only issue when page size reduces then table columns are going outside panel.
Instead we want to have Datatable show horizontal scroll bar, and page should not have horizontal scroll bar.
Can you please suggest what changes we need to make on HTML page to have only table scroll and not the atual page.
Thanks

Another screen capture showing the issue.

Any solution to this will be appreciated.
Thanks

Found solution. Need to wrap table in

@dendihandian Did you find the answer to this?

@dendihandian Did you find the answer to this?

I did, but I can't remember because the code is in a company's private repo. I think it solved as someone stated above about wrapping it in a div.

I had tried a whole bunch of things, including copying/pasting an example that should work... after a few hours, out of desperation I just restarted Chrome, and the problem was gone :-\
Thanks for the reply!
On Apr 11, 2022, at 12:56 AM, Dendi Handian @.***> wrote:
@dendihandian https://github.com/dendihandian Did you find the answer to this?
I did, but I can't remember because the code is in a company's private repo. I think it solved as someone stated above about wrapping it in a div.
—
Reply to this email directly, view it on GitHub https://github.com/StartBootstrap/startbootstrap-sb-admin-2/issues/148#issuecomment-1094580807, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGEIQUMNFFH2PMPDPHBAX3LVEO5KRANCNFSM4CPFFYUA.
You are receiving this because you commented.

@codeplotter be careful of browser cache. If your css code aren't versioned everytime you change a style, make sure to hard refresh the page.

Yep, I was doing that - and CSS changes were made inline.  Hard to say what happened.
On Apr 11, 2022, at 11:57 AM, Dendi Handian @.***> wrote:
@codeplotter https://github.com/codeplotter be careful of browser cache. If your css code aren't versioned everytime you change a style, make sure to hard refresh the page.
—
Reply to this email directly, view it on GitHub https://github.com/StartBootstrap/startbootstrap-sb-admin-2/issues/148#issuecomment-1095302906, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGEIQUOAAJEOXQZHXUTOL53VERKYRANCNFSM4CPFFYUA.
You are receiving this because you were mentioned.


fix order of parameters in implode method

Although the implode method accept parameters in either order, this order is deprecated.
https://www.php.net/manual/en/function.implode.php : Note section

Thank you! this is the kind of thing we could miss that could bite us when PHP versions upgrade


Update 02_classification.ipynb

Error loading dataset "emotion". Corrected namespace to "dair-ai/emotion"

Error loading dataset "emotion". Corrected namespace to "dair-ai/emotion"

This seems to be a huge PR for this correction only. Did you tried upgrading datasets to 2.9.0 instead? This did the trick for me. This can then be fixed with a change in the install.py script

This seems to be a huge PR for this correction only

You can see the diff in GitNotebooks: https://gitnotebooks.com/nlp-with-transformers/notebooks/pull/103
ReviewNB has a hard time when the underlying JSON has spurious changes. In reality the change is quite small!


Bug: The loading grid can sometimes be hidden by another element because it doesn't have the maximum ZIndex value

Fixed by f4d8748 commit


PhantomJS does not support Function.bind

It should be mentioned somewhere that PhantomJS may not support certain JavaScript features. I found that some of my tests failed due to PhantomJS (1.9.17) not supporting Function.prototype.bind() causing a timeout error.
Maybe there could be an error handler that prints such messages to the CLI since all my timeout issues were due to an uncaught JavaScript error.

Use https://github.com/kdimatteo/bind-polyfill
Just include index.js into your html file with unit tests.

Deeplink in above thread to where they say issue is resolved: https://github.com/ariya/phantomjs/issues/10522#issuecomment-72705658

Update to the 1.0.0 release of this and you get PhantomJS 2.x.


refactor: Sync source code with external modules

Pull Request
Description
Current PR includes changes caused by code sync with the internal module.
After completion of the internal test, a new tag, v1.4.1, will be assigned.
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] Code cleanup/refactoring
[ ] Documentation update
[ ] This change requires a documentation update
[ ] CI system update
[X] Test Coverage update

Checklist:

[X] My code follows the style guidelines of this project
[X] My code meets the required code coverage for lines (90% and above)
[X] My code meets the required code coverage for branches (80% and above)
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4e5ccdf) 90.90% compared to head (576a0bf) 90.93%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #420      +/-   ##
============================================
+ Coverage     90.90%   90.93%   +0.03%
- Complexity      486      489       +3
============================================
  Files            47       47
  Lines          1737     1743       +6
  Branches        209      210       +1
============================================
+ Hits           1579     1585       +6
  Misses           94       94
  Partials         64       64

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Issues installing NuGet package on Mono

Installation of the package fails with the NullReference exception when it's installed on Mono (Mac).
It seams that the problem is caused by https://github.com/whyleee/nogit package that uses PowerShell scripts.
Besides that the package depends on the Windows version of Node.js and adds windows CMD files to the project.

Use a newer (0.5) version from npm. NuGet packages are outdated and they doesn't support Mac/Mono.


Investigate bad YAIL generation

Describe the bug

From the forum: Connecting to companion gives an error "Source and target classes must match". Looking at the project structure, the $Name property on the screen is different from the .scm/.bky file name.
Affects

[ ] Designer
[ ] Blocks editor
[x] Companion
[ ] Compiled apps
[ ] Buildserver
[ ] Debugging
[ ] Other... (please describe)

Expected behavior

The names should match and no error should occur.
Steps to reproduce

A sample project is included in the post. Not sure yet of the steps needed to reproduce the state.

Sir @ewpatton, please assign this issue to me. I want to work on it.

@abhinavs1920 Please take a look.


All files required are added

Game folder is added along with necessary changes in the Data.js and AllRoutes.js file.

issue no.  #834  was labelled as level-2. So why it's labeled here as level 1 ??

issue no.  #834  was labelled as level-2. So why it's labeled here as level 1 ??


Wrong behavior of color palette when color set to #FF0000

When setting default color to red (#FF0000), and start picking red tone from palette, color changes very unexpectedly, please check jsfiddle below
http://jsfiddle.net/sb665dph/1/

hi @rio2311 I can't reproduce the issue. Can you be more specific? Which OS and Browser are you using?

Sorry for incomplete description, @mjolnic .
Browser/OS - Ubuntu12.04+Firefox(Latest), MacOSX + Safari(Latest).
In jsfiddle above try to drag picker from upper right to bottom left.
I expect, that only picked color should be changed, but instead, whole color palette changes from red to black.
If you will change initial color value from #FF0000 to #FF0001, the issue will not appear. Looks like something wrong with value parser?

@rio2311 oh I see now the problem, definitely something might be wrong with the pure red palette

This also happens when there is no initial value. Check the "enable/disable" example on https://mjolnic.com/bootstrap-colorpicker/

This has been fixed


Use the new query fields in the search API

For https://github.com/wellcomecollection/platform/issues/5550; accompanies https://github.com/wellcomecollection/catalogue-pipeline/pull/2107
This is a much smaller change than the diff implies; most of it is copying across autogenerated test documents. All the interesting stuff is in the final commit.
This repo is now totally divorced from WorkState.Indexed; it no longer uses it. We can't get rid of it quite yet because it's used for some copyTo in the Elasticsearch mapping, but we're getting closer to removing it.

I've kicked off a reindex to populate the index with the fields this is looking at, but I can't merge it until that's done.


Error is displayed when i execute 'wasm-pack build' command

Describe the Bug
Error is displayed when i execute 'wasm-pack build' command
Steps to Reproduce

Firstly ,i want to re-line code from https://github.com/paritytech/stateless-blockchain
When i execute wasm-pack build on package accumulator-client
Error displayed"the legacy llvm-style asm syntax is no longer supported"

Expected Behavior
Execute command wasm-pack build will be successful
Actual Behavior
Error displayed
If applicable, add screenshots to help explain your problem.

i tried to download llvm, but i did not successfully, it's too slowly.so i want to know how to migrate to the new asm!

The new syntax is outlined here. This isn't a bug, but rather how the language is developing over time.


link on addErrorBadge not working

Using:
    addErrorBadge (
        text: "Unit tests failed for ${project.Name}",
        link: "${env.BUILD_URL}testReport"
    )

will not produce clickable badge,
Using workaround
    addBadge(
        icon: "error.gif",
         text: "Unit tests failed for ${project.Name}",
        link: "${env.BUILD_URL}testReport"
    )

Hi
I could extend the behavior of the status icons. They support now links as well.

Thanks

Released wit version 1.7


Missing URL to check communication with Azure

Hi,
It seems a URL is missing from this section.
Verify the port
Verify that Azure is listening on port 443 and that your agent can communicate with it.
This test verifies that your agents can communicate with Azure over port 443. Open a browser, and go to the previous URL from the server where the agent is installed.
Thanks
Stewart

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2b231c00-1094-b822-0870-032d28fe0c05
Version Independent ID: 1b95f0e4-fdbe-1128-2e15-184f8aeb496b
Content: Azure AD Connect cloud sync troubleshooting
Content Source: articles/active-directory/cloud-sync/how-to-troubleshoot.md
Product: windows-server-threshold
Technology: identity-adfs
GitHub Login: @billmath
Microsoft Alias: billmath

Thanks for the feedback! I have assigned the issue to the doc author to update appropriately.

After reviewing, no missing URL was found.
@please-close

The following issue is being closed due to the age.  If this is still an issue please re-submit this.  Thank you.
#please-close


Point annotation marker offsetX/Y

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
As with the general markers setting, I'd like to be able to set an offsetX and/or Y with point annotation markers e.g.
    points: [
      {
        x: new Date("27 Nov 2017").getTime(),
        y: 8500.9,
        marker: {
          size: 6,
          fillColor: "#fff",
          strokeColor: "#2698FF",
          radius: 2,
          offsetY: -10 // <== Offset
        },
       ...
      }
    ]

Describe alternatives you've considered

Using annotation text with some whitespace character (but no way to make circle)
Using another series with just the annotation point (but then the markers offset is applied globally, discrete offsetX/Y is also ignored). Would also be nice to assign markers settings per series.

Additional context
Going for something like this ultimately:

Thanks for making a great lib, esp with Vue integration 😍

Sure, just added it.
Wait for the next release to use it :)

Hell yeah! I'll watch for the next release.


Docker project create docker image icon too small

Initially reported in https://github.com/wso2/product-ei/issues/4696
Description:
Docker project create docker image icon is too small and is positioned to the top righthand corner and hence difficult to locate.
Suggested Labels:

Suggested Assignees:

Affected Product Version:
Integration Studio 7.0.0
Steps to reproduce:
Related Issues:

Fixed with https://github.com/wso2/devstudio-tooling-ei/issues/1202


Update dataloaders.md Github example urls

The DataLoader example project moved to another location, so the linked needed to be updated

thank you for your contributions.


add enum_attribute and message_attribute to tonic-build

Feature Request
Crates

tonic-build

Motivation
prost-build v0.11.6 added new enum_attribute and message_attribute methods to the builder for setting attributes on only enum (proto enums or oneofs) and message types (see https://github.com/tokio-rs/prost/pull/784). However, tonic-build's builder currently only exposes the type_attribute and field_attribute methods from prost-build.
Proposal
We should add new builder methods corresponding to those prost-build methods.
Alternatives
Not do this?

Oh, whoops, I see that this just merged in #1234. My bad!


chore: fix post-upgrade job when it is set to null

If a cert is null, this should still process and work. Here we add checks against that possibility.

chore: fix post-upgrade job when it is set to null

NIT: It's not chore change in my opinion as @vuldin needs a Redpanda deployment that can be achieved without cert manager.
I would like to suggest that any occurrence of
{{- $cert := get .Values.tls.certs .Values.listeners.kafka.tls.cert }}

is a place to address entire problem.

chore: fix post-upgrade job when it is set to null

NIT: It's not chore change in my opinion as @vuldin needs a Redpanda deployment that can be achieved without cert manager.
I would like to suggest that any occurrence of
{{- $cert := get .Values.tls.certs .Values.listeners.kafka.tls.cert }}

is a place to address entire problem.

🤔 but the null issue only appears in the operator. If i understand correctly, you are ok with the solution, but you want to be holistic and take care of each instance. Could I open an issue and do so for your findings in another PR?


Ability to use a central s3 bucket for audit logs when using a multi account organization

We could use an option to provide a bucket ARN instead of a name which would enable this module to have multiple accounts send audit logs to a single s3 bucket when in a multiple account organization.

@DevBOFH
Thanks for proposing! I agree allowing to use the centralized log bucket would be useful.
Working on it in #51, which should be released shortly :)

Just released v0.14.0, which adds use_external_audit_log_bucket variable.
When it sets to true, the module use the bucket with the name equals to audit_log_bucket_name instead of creating a new bucket.
Please check external-bucket example as well!

Thanks @nozaq! I really appreciate it!


cli,server: make quit/drain more friendly to clusters with many ranges

PR: https://github.com/cockroachdb/cockroach/pull/45149
From release notes:

Prior to this patch, the phase of server shutdown responsible for range lease transfers to other nodes would give up after 10000 attempts of transferring replica leases away, regardless of the value of server.shutdown.lease_transfer_wait. The limit of 10000 attempts has been removed, so that now only the maximum duration server.shutdown.lease_transfer_wait applies. [#45149][#45149] {% comment %}doc{% endcomment %}

Dup of https://github.com/cockroachdb/docs/issues/7558


Fix failing smoke tests

The depends_on portion of the transaction processor service
definition is necessary because they reference a service
with a particular container that the docker dns gives
an address.
The sleeps on integration_test service is necessary until we have a way to get the rest_api status of if the validator is ready. The other sleeps are necessary for unknown reasons that hopefully will be solved in my work this sprint, but if not we should figure out why they are necessary.
Signed-off-by: Boyd Johnson<EMAIL_ADDRESS>

I can increase the sleeps. I think they are consistent between xo and intkey smoke. It ran again and passed. If you have time run it locally and see how many times it passes. I have only seen 1 fail in ~20 runs locally, but also the fail on the server.


Internationalization

It could be nice to have multiple languages (german and french?) as well with this considering the content is way smaller than the website.
https://tex.stackexchange.com/a/504130/179728 seems like a good way to do this.
Either way, this should happen after a first version was done so we have a common starting place. This also will require at least 2 people per language to ensure that we don't end up with quality issues.

Sign me up for the Portuguese translation, when this is ready


Bump up dependencies to k8s v1.21

What type of PR is this?

/kind cleanup
What this PR does / why we need it:
Bumps up k8s to v1.21, cleans up dependency tree a little bit.
Also bumped up controller-runtime related libs.
Which issue(s) this PR fixes:

None
Does this PR introduce a user-facing change?:

NONE

Thanks!
/lgtm


FIX: Repair search for precomputed transforms

Changes proposed in this pull request

Closes #3368
This required massaging several kinks from collect_derivatives, so careful review of that would be appreciated.
Documentation that should be reviewed

For remaining issues, ruff check --fix && ruff format