generatejsonschematypes fails on linux \ WSL

I am using a schema that references other schema files in the same directory.
I can generate the code files running this command:
generatejsonschematypes --rootNamespace app.Infrastructure my-schema.json --outputRootTypeName MyType --outputPath ..\Data
Generating: Node
Generating: IdEntity
Generating: UnitEntity
Generating: MyType
...

When I copy the project to WSL and rerun the same command I get this error:
generatejsonschematypes --rootNamespace stow.Infrastructure my-schema.json --outputRootTypeName MyType --outputPath ..\Data
Unable to locate the root document at 'home/myuser/repos/myproject/src/app.Infrastructure/Schema/node-schema.json'

Thanks for this. We'll investigate.

How are you formatting the $ref in your schema? We support UNIX-style paths on both windows and UNIX but Windows-style paths only work on Windows.
e.g.
Create a file baseschema.json
{
    "$schema": "https://json-schema.org/draft/2020-12/schema",
    "allOf": [
        {
            "$ref": "./schema.json#"
        },
        {
            "type": "object",
            "properties": {
                "foo": {
                    "type": "number",
                    "minimum": 5
                }
            }
        }
    ]
}

Create a file schema.json
{
    "$schema": "https://json-schema.org/draft/2020-12/schema",
    "properties": {
        "foo": {
            "type": "number",
            "minimum": 0
        }
    }
}

Running the type generator
generatejsonschematypes.exe --rootNamespace Example --outputPath Generated ./baseschema.json

Emits the results:
Generating: BaseschemaJson
Generating: FooEntity
Generating: AllOf1Entity
Generating: FooEntity
Generating: SchemaJson

@mrt181 - Have you had a chance to verify this issue?

This looks like an issue with using Windows style paths on the WSL command-line.
The original repro has the following --outputPath ..\Data
I can repro the original error in WSL using the sample from @mwadams with the following:
generatejsonschematypes.exe --rootNamespace Example --outputPath Generated .\baseschema.json

As I say, we don't support Windows-style paths on UNIX. But we support both path styles in Windows.

I am closing this as "by design". Feel free to re-open if we have misunderstood your issue.


Eloquent isDirty not checking properly numbers

Hi,
I found this issue with Eloquent's isDirty method:
Checking a numeric field MySQL DECIMAL(12,2) where the original value is dumped as:
STRING(5) "14.00"
and the dirty value is
INT(14)
The field is marked as Dirty, but it is not dirty, since 14.00 is same numerically that 14.
I didn't verified yet, but found the problem may be on originalIsNumericallyEquivalent method, that does a cast to string and compare the both values using strcmp.
Using Laravel 5.1.35 (LTS)

This does not look the same issue as #8972, isn't a eloquent casting problem. It's a problem when checking originalIsNumericallyEquivalent.
I've made a workarroud by overriding the method on my Model by this one:
    protected function originalIsNumericallyEquivalent($key)
    {
        $current = $this->attributes[$key];
        $original = $this->original[$key];
        return is_numeric($current) && is_numeric($original) && (float) $current == (float) $original;
    }

This is a bit opinionated, if the original value was 14 and I want to change it to 14.00 in some cases I expect this attribute to be considered as dirty, same with 14.0 => 14.00, 14.1 => 14.10

Thanks for the report, but our current behaviour is correct I think. It's better to be slightly oversensitive here, than the reverse.

Hi @themsaid, I also came across this today where I only want to create a new (replicate) row + change, if anything changed on the existing row. Hence when I have a number value in there it compares a number with a string, which is problematic. A use case for this would be e.g. a rates table, which should only add a new row if the rate really changed:
           //fill new data into the model
            $current_rate->fill($data);

            //test if anything changed
            if ($current_rate->isDirty()) {
                  //if anything changed create a new rate row
            }

here the output. The DB column is a decimal(10,3) hence the .000 decimal places.
 #attributes: array:17 [
    "id" => 8
    "valid_from" => "2018-07-31 17:37:18"
    "valid_until" => null
    "commission_percent" => 4
    "created_at" => "2018-07-31 17:37:18"
    "updated_at" => "2018-07-31 17:37:18"
    "deleted_at" => null
  ]
  #original: array:17 [
    "id" => 8
    "valid_from" => "2018-07-31 17:37:18"
    "valid_until" => null
    "commission_percent" => "4.000"
    "created_at" => "2018-07-31 17:37:18"
    "updated_at" => "2018-07-31 17:37:18"
    "deleted_at" => null
  ]

Maybe we can just have a look at this again, because even if it is an opinionated thing, it does however created an exclusion of values e.g numbers.
Thanks!


Add NotNullWhen attribute to Microsoft.IdentityModel.Tokens.CollectionUtilities.IsNullOrEmpty extension method

Added NotNullWhen attribute to indicate that the parameter is not null when the method returns false.

@fabriziobagala i am wondering how this helps.
the return value is bool, which is not nullable.

@brentschmaltz The NotNullWhen attribute is used to provide hints to the C# compiler about the nullability of a reference type when a specific condition is met. This attribute is typically used in combination with nullable reference types to help the compiler understand when a variable or expression is guaranteed to be non-null based on a condition.
Considering:
using System.Diagnostics.CodeAnalysis;

string? input = Console.ReadLine();
if (!IsNullOrEmpty(input))
{
    // At this point, the compiler knows that 'input' is not null thanks to NotNullWhen attribute.
    // So you can safely use it without triggering nullability warnings.
    Console.WriteLine(input.Length);
}

static bool IsNullOrEmpty([NotNullWhen(false)]string? input)
{
    return string.IsNullOrEmpty(input);
}

In this example, we apply NotNullWhen(false) to indicate that when the method returns false, input is guaranteed to be non-null. So the compiler will not trigger any nullability warnings. Otherwise, a CS8602 Dereference of a possibly null reference is triggered when accessing the Length property because the compiler doesn't know that you've validated the input just before.

@brentschmaltz using the NotNullWhen(false) attribute means that when the method returns false, the enumerable parameter is not null. This allows you to write subsequent code that relies on this guarantee without the need for additional nullity checks.

@fabriziobagala what happens if IEnumerable is null when passed in?

@brentschmaltz this happens:
IEnumerable<string> collection = default!;
Console.WriteLine(collection.IsNullOrEmpty()); // Prints 'true'

collection = Enumerable.Repeat("a", 3);
Console.WriteLine(collection.IsNullOrEmpty()); // Prints 'false'

@brentschmaltz the goal of this MR is only to prevent the code from being filled with CS8602 warnings.

The feedback from the community was to make CollectionUtilities internal in the latest major release.


tutorials/first-web-api.rst "Building Your First Web API with ASP.NET Core MVC and Visual Studio"

Replaces CreatedAtRoute by CreatedAtAction call, as we use action name in arguments.
By the way, action name from HttpGet attribute ("GetTodo") is not working for me. I get same error: InvalidOperationException: No route matches the supplied values.. Using action method name "GetById" fixes this error. Maybe this is a bug in MVC.

Hi @whyleee, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

Thanks Whylee, merged! 2a6ca10aeefc1f73d4b1b171e804e753dc51dd81


Powershell script - variables declared are unused

This page's script declares variables that are unused in the rest of the script.  See the code block below which is lines 1-15:
# Declare variables
  $VNetName  = "VNet1"
  $FESubName = "FrontEnd"
  $BESubName = "Backend"
  $GWSubName = "GatewaySubnet"
  $VNetPrefix1 = "<IP_ADDRESS>/16"
  $FESubPrefix = "<IP_ADDRESS>/24"
  $BESubPrefix = "<IP_ADDRESS>/24"
  $GWSubPrefix = "<IP_ADDRESS>/27"
  $VPNClientAddressPool = "<IP_ADDRESS>/24"
  $RG = "TestRG1"
  $Location = "East US"
  $GWName = "VNet1GW"
  $GWIPName = "VNet1GWIP"
  $GWIPconfName = "gwipconf"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4f266e52-5aa4-f099-6246-77671e6fe4af
Version Independent ID: 105d681c-5bd2-fae0-af69-ac2c06abcdaa
Content: Azure PowerShell script sample - Configure a Site-to-Site VPN
Content Source: articles/vpn-gateway/scripts/vpn-gateway-sample-site-to-site-powershell.md
Service: vpn-gateway
GitHub Login: @anzaman
Microsoft Alias: alzam

@jaydarius , Thanks for reaching out. We will investigate and update this thread.

Thank you for you dedication to our documentation.
Unfortunately, we have been unable to review this issue in a timely manner. We sincerely apologize for the delayed response. We are closing this issue. If you feel that the problem persists, please respond to this issue with additional information.
Please continue to provide feedback about the documentation. We appreciate your contributions to our community.
#please-close


ARC A310 QSV extremely unreliable?

Ubuntu 22.04, finding QSV is extremely unreliable for wolf with an ARC A310, note this is a VM with the GPU passed through so that could be impacting things.
Tried updating opencl but doesn't seem to help.
It looks like something might be crashing when trying to setup the stream as I can see some dump files in /etc/wolf/cfg, very occasionally (probably less than 1 in 10 attempts) it will work.
I removed the QSV sections from config.toml and fell back to vaapi and that seems a lot more consistent.

Can you share some logs?   Unfortunately, I dont have an Intel GPU to test it out properly, quicksync is all based on user reports and the community..

@ABeltramo - I dont think I have the output from the docker console anymore, I did however (hopefully) send you over the backtrace files that got dumped in the /etc/wolf/cfg folder as well as the steam log from my session folder.

After a bit of debugging I can reproduce the issue on my Intel ARC, seems to be the same as https://github.com/intel/media-driver/issues/1800
Replacing vapostproc with videoconvert completely fixes it for me, see the change here.


[docs] SEO fixes

Goes hand in hand with https://github.com/mui/mui-x/pull/4711

Fix one regression from https://github.com/mui/material-ui/pull/31878/files#r862370331

Just realized that we missed the link updates for x-license and x/license present in #32464.


Is inlining styles not working?

Environment

Operating System: Darwin
Node Version:     v20.10.0
Nuxt Version:     3.12.3
CLI Version:      3.12.0
Nitro Version:    2.9.7
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      telemetry, compatibilityDate, runtimeConfig, modules, future, sourcemap, devtools, site, app, vite, nitro, css, postcss, eslint, image, content, colorMode, icon, plausible, ogImage, linkChecker, sitemap
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
This is from nuxt.com

Describe the bug
With<EMAIL_ADDRESS>and
future: {
    compatibilityVersion: 4,
}

it seems like inlineStyles should be enabled by default (I also tested with explicitly setting it in future), but I still get stylesheets linked on my landing page (Promptmetheus) and Google Pagespeed complains about it.

Additional context
No response
Logs
No response

Duplicate of https://github.com/nuxt/nuxt/issues/21821


Evaluation for WGS

Copy number only.
This issue is to do an evaluation of the performance (sensitivity, precision, etc) of the WGS pipeline.

Closing, will refile more specific issues for WGS evaluation.


Browserified Bundle name not consistent

https://wzrd.in/standalone/eventemitter3@latest
The browserified bundle actually doesn't seems to export that function name properly.
This works: var a = new eventemitter3()
this doesn't: var a = new EventEmitter()
neither: var a = require('eventemitter3') being a standalone module, no require is needed.

I guess wzrd.in uses the package name as --standalone option for browserify. I think there isn't anything actionable from our side.


Scroll slicks in IE

Hi,
There is a bug in IE that the scroll slicks:
http://plnkr.co/edit/vJjyq8JeUFLD1fzM2LRj?p=preview
As I read, there was an open issue concerning this bug:
https://github.com/noraesae/perfect-scrollbar/issues/160
I am not sure but I think you uploaded two fixes for that.
Unfortunately, I didn't see that you push it to master.
Please let me know if I'm right.
Thank you,
Alon.
Make sure these boxes are checked before submitting your issue -- thank you!

[x] Check FAQ
[x] Search if there's already one reported in Issues
[x] Prepare a JSFiddle reproducing the issue

Perfect Scrollbar JSFiddle: https://jsfiddle.net/DanielApt/xv0rrxv3/
With jQuery: https://jsfiddle.net/DanielApt/gbfLazpx/

[x] Provide a page or source code where the issue can be checked

Looking forward for a fix to this issue too, I really like perfect scrollbar but this issue really compromises my ux

I haven't tried this but what about using translate instead of top. I have nothing to back this up but maybe it's jumping around because of top/right/bottom/left lack of sub pixel animation.
Also, TRBL uses more paint frames than translate.
I could do a PR but I have no way to test on IE atm. :crying_cat_face:

Maybe something like
default-settings.js
{
  ...
  userCss3: true
}

update-geometry.js line ~48
if (i.settings.useCss3) {
  dom.css(i.scrollbarX, {transform: 'translateX(' + i.scrollbarXLeft + 'px)', width: i.scrollbarXWidth - i.railBorderXWidth});
  dom.css(i.scrollbarY, {transform: 'translateY(' + i.scrollbarYTop + 'px)', height: i.scrollbarYHeight - i.railBorderYWidth});
} else {
  dom.css(i.scrollbarX, {left: i.scrollbarXLeft, width: i.scrollbarXWidth - i.railBorderXWidth});
  dom.css(i.scrollbarY, {top: i.scrollbarYTop, height: i.scrollbarYHeight - i.railBorderYWidth});
}

It's basically because of IE bug concerning synchronous update on scroll properties. IE renders scroll properties asynchronously, even though it's updated in sync with other styles.
I think using CSS transform only for IE is not a way to go, as it must result in more branch and eventually implementation issues. As I mentioned in the original issue, I may close this. This time I will add some info in README and Wiki too.


[Question] nvic::set_priority against NVIC_SetPriority

Hi,
It's me again :)
I'm looking at the code of ncvic::set_priority and comparing it to the C impl that I got from my supplier and they are quite different:
__STATIC_INLINE void __NVIC_SetPriority(IRQn_Type IRQn, uint32_t priority)
{
  if ((int32_t)(IRQn) >= 0)
  {
    NVIC->IP[((uint32_t)IRQn)] = (uint8_t)((priority << (8U - __NVIC_PRIO_BITS)) & (uint32_t)0xFFUL);
  }
  else
  {
    SCB->SHP[(((uint32_t)IRQn) & 0xFUL)-4UL] = (uint8_t)((priority << (8U - __NVIC_PRIO_BITS)) & (uint32_t)0xFFUL);
  }
}

Writing even in different peripherical. Why are they so different?

They do the same, only that the Rust implementation had split SCB and NVIC properties.
See here: https://docs.rs/cortex-m/0.6.1/cortex_m/?search=set_prio

I see, so if priority is < 0, I call SCB::set_priority. Thank you !

If you have the cortex core interrupts use SCB, device interrupts use NVIC :) priority works the same for both

As you can see, the SDK I'm using encode the core one in negative int32_t and to some C trick to convert them into proper index. I need to convert these into SystemHandler but I got the idea, thank you very much!

Last question on this matter: I can see that NonMaskableInt and HardFault are commented out because priority is fixed.
What happen in C code then if somebody tries to set their priority anyway?
Asking because they are declared in the enum of the SDK:
NonMaskableInt_IRQn   = -14,              /*!< 2  Cortex-M4 Non Maskable Interrupt      */
  HardFault_IRQn        = -13,              /*!< 3  Cortex-M4 Hard Fault Interrupt        */

There is a good chance it would hardfault or just cause UB, not sure though.


plugin sends update to new version message but its already up to date

Closed in https://github.com/WiIIiam278/DesertWell/commit/aea4520277e9c9665caf9af9b55fc0f151e99231


Allow newer Pydantic patch versions

Started from this discussion.
This allows newer Pydantic patch versions on 2.7.x so as not to conflict with other libraries that may have more specific requirements, e.g. ^2.7.1.

:rocket: This description was created by Ellipsis for commit b886aa42a92bd336078d20ed6f580dbd02ccb199

Summary:
Updated pydantic version constraint in pyproject.toml to allow newer patch versions, enhancing compatibility with other libraries.
Key points:

Updated pydantic version constraint in pyproject.toml from 2.7.0 to ^2.7.0.
Allows newer patch versions of pydantic to avoid dependency conflicts.

Generated with :heart: by ellipsis.dev

mind pumping the version so i can publish right after


Mismatched types at src/partition/mod.rs

Describe the bug
There is an error at src/partition/mod/rs: 432
Should modify return type or return
self.tree.approximate_len() as usize

Currently using rust nightly

Is this on the main branch? If so, that is expected because it is in flux right now, as I prepare the v2 release.


documentation enhancements

Hey,
I addressed the following issues:

add documentation to setToken.
add documentation to the new options param in constructor.
fix class name in angular client - jsdoc didn't understand the previous one.
method's param type with one curly brackets instead of two - jsdoc expects one curly brackets wrapper in order to understand the type.

@borisirota Cool :) Thanks a lot!


Fixed an issue with OneHotEncoderOp when computing categorySizes

The spark feature org.apache.spark.ml.feature.OneHotEncoderModel has two mixins for the input columns: inputCol and inputCols. We need to check which param is set and use that correct one to compute categorySizes.

Ok I will add new tests


[BUG] add-bid transaction fails due to exceeding Block Gas Limit/high Gas cost

Auction add-bid transaction fails due to high gas cost exceeding the network's block gas limit.
An add-bid transaction using casper-client fails with an error indicating that the transaction exceeds the network's block gas limit. The issue arises during execution with the following parameters:
The transaction fails with an error message, despite the gas parameters appearing valid on the surface. The network's block gas limit (block_gas_limit = 3_300_000_000_000) is exceeded.
Reported by : @thamps-casp
casper-client put-transaction add-bid \
  --node-address http://<IP_ADDRESS>:7777 \
  --chain-name casper-ajith-dev-small \
  --payment-amount<PHONE_NUMBER>0 \
  --secret-key /tmp/ajith-dev-small/cluster/pre-validator/<IP_ADDRESS>/secret_key.pem \
  --delegation-rate 33 \
  --minimum-delegation-amount<PHONE_NUMBER>00 \
  --maximum-delegation-amount<PHONE_NUMBER>000 \
  --public-key 01b16a56d07107ae9882685440813aeb3b0e1c8317602000ffa7017714582a2590 \
  --transaction-amount<PHONE_NUMBER>00 \
  --gas-price-tolerance 5 \
  --pricing-mode fixed

Error returned;
{
  "code": -32016,
  "message": "Invalid transaction",
  "data": "the transaction was invalid: The transaction sent to the network exceeds the network's block gas limit"
}

Here with attaching the chainspec.toml used for test run.
chainspec.zip


fix(netlify-cms-backend-git-gateway): content-type may have charset

Summary
Git gateway Content-Type header check does not allow for extra elements such as charset=utf-8, which may be added by some proxies.
In particular, I have seen the Cypress.io e2e testing tool proxy requests and add charset, causing this piece of the authentication check to fail unnecessarily/unexpectedly.
This is somewhat related to e2e testing issue #1013.
Test plan
For regression testing, simply login to a Netlify CMS site with config.yml configured for:
backend:
  name: git-gateway

and confirm that it continues to work as before.
For unit testing, you can create a Cypress.io e2e test to verify the before/after of this change.

Yum, tasty little one-line fix!

Deploy preview for netlify-cms-www ready!
Built with commit 954aa68a6df7873606e8d200e09354ae93c79ff2
https://deploy-preview-1951--netlify-cms-www.netlify.com

Deploy preview for cms-demo ready!
Built with commit 954aa68a6df7873606e8d200e09354ae93c79ff2
https://deploy-preview-1951--cms-demo.netlify.com


save settings after clicking ok

from what I can tell this is what saves all the preferences correctly, seems to work after clicking Ok and closing client abruptly (kill, turn off computer etc)

seems good


Pass selenium-server, chromedriver and phantomjs information into plugin

Some thoughts:
My first instinct is that we should do this in the magellan-nightwatch plugin instead, since these aspects don't apply to magellan itself but the way nightwatch test suites work, and in particular the way nightwatch includes modules by path.
One problem with my suggestion is that the nightwatch plugin doesn't have access to the modules loaded at the magellan level, so we would have to pass special information about loaded modules during initialization.
Hmmmmm

Exactly, at plugin level we don't have such information, it has to be passed in from magellan.
But since these information is bound to specific plugin, maybe we can do
new TestRunClass(options, pluginOption /*where all extra options live*/);

and expose a function fetchPluginOptions(args) in each plugin repo to get such?
Or we don't need this PR at all, let user to maintain all the necessary repos in their nightwatch.json.

Some ideas:

Instead of passing this information in test_runner , I suggest we hand this to the plugin as part of magellan's settings object.
Instead of passing isFixing*******, we should indicate whether it is present by naming it `******isPresent. It's possible other plugins may be interested in this info for reasons other than fixing the integration point.

BTW this PR requires
https://github.com/TestArmada/magellan-nightwatch/pull/38
and
https://github.com/TestArmada/magellan-nightwatch-plugin/pull/6

LGTM and ready to merge


Unexpected API Response: {"detail":"Not Found"}

Please help me. The Stable Diffusion is working very-well on my (URL): http://XXX:$PORT. But, the Discord bot showing that error. It says not found, does that mean the location has been changed?
Thanks.

Issue has been solved.

What was the solution for this?

Issue has been solved.

What was the solution?


Git Branches menu should open near the current branch label

Issue Type: Feature Request
When you click on the branch label in the lower left corner, a menu opens at the middle top of the window. This is disorienting and disjointed. It would be nice if when that menu was opened by clicking on the branch label (rather than by navigating there with ctrl+shift+P) it would appear close to the branch label.
VS Code version: Code 1.22.1 (950b8b0d37a9b7061b6f0d291837ccc4015f5ecd, 2018-04-06T02:26:57.615Z)
OS version: Windows_NT x64 10.0.14393

Duplicate of https://github.com/Microsoft/vscode/issues/29193


Change the notification event name for custom actions

https://github.com/DivanteLtd/vue-storefront/blob/9a98265b0e014f450b30095fceb64f4f3b762252/core/components/Notification.vue#L27
It should be changed to: notification-after-
We should include some additional data/arguments as an option for custom actions.
For example:
          this.$bus.$emit('notification', {
            type: 'error',
            message: i18n.t(result.result),
            action1: { label: i18n.t('OK'), action: 'close' }
            action2: { label: i18n.t('Continue'), action: 'customAction', payload: { someCustom: 'attributes' } }
          })

The payload should be included in the $emit call of the "notification-after-" + action event
Add the default action "link" which is just for opening the URLs:
          this.$bus.$emit('notification', {
            type: 'error',
            message: i18n.t(result.result),
            action1: { label: i18n.t('OK'), action: 'close' }
            action2: { label: i18n.t('Continue'), action: 'link', href: 'http://example.com' }
          })

Closing as the notification event name was changed accordingly to the task
PR: https://github.com/DivanteLtd/vue-storefront/pull/1159


No validation when linked item is deleted

There should be validation for such cases

Link Planner item to Bug , And delete the Bug : It should show the validation message to Unlink the Bug first from planner item , then delete the Bug.
Vice verse , if some thing is linked and we want to delete it , it should be validated at API level , to unlink first and then delete

Verified


Add tb shimmer entry nodes & snapshot source

Description
Please include a summary of the change. Include the motivation for the change.
Fixes #(issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Fix

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have tested my code extensively
[ ] I have selected the develop branch as the target branch

Hey!
This PR can be closed, we added your changes to the node-docker-setup instead, see here:
https://github.com/iotaledger/node-docker-setup/commit/f95d8d6e4106241eb3c11ea572577f1217078be5
And I guess you are shipping modified config files with SWARM yourself anyway. This way we don't need to release new hornet versions for config changes everytime.


Need to update libstdc++ min version in run_exports

It's at 12 right now

I just want to cross reference https://github.com/conda-forge/ctng-compilers-feedstock/pull/113#issuecomment-1712859191


testDismissedFlutterViewControllerNotRespondingToApplicationLifecycle is flaky

/cc @xster
test in question: AppLifecycleTests.m#L43
logs:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8901930194060398832/+/steps/Scenario_App_Unit_Tests/0/stdout
and
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8901925738100649952/+/steps/Scenario_App_Unit_Tests/0/stdout
Both of these happened on changes completely unrelated to ios, and passed on subsequent changes also unrelated to ios.

lol, the output just straight up says test crashed. I haven't seen this one before. Skipping SG

The test is still marked as skipped.
/cc @xster @gaaclarke Any chance you can take a look at this flake?

From triage: @dnfield were you able to find out anything more about this test? I see it is still skipped.

I'm not very familiar with this test.

I did find a problem in the tests that was causing some tests to flake.  I fixed it here: https://github.com/flutter/engine/commit/27bf114b861e3bf7a95aef5b90e14e0206d78146
After that landed there are potentially things that are marked as flakey that shouldn't be flakey anymore.  TLDR a test was leaking an object because of OCMock weirdness that was responding to notifications still.

@gaaclarke Could you take a quick pass over the skipped tests that are related to the fix, and re-enable them, or file issues to re-enable them?

There is no quick pass probably since there is no clear way to know if that leak was causing the flake that caused a given test to be disabled.  Someone would have to disable them one by one and run the tests ~1000 times to make sure it doesn't flake anymore.  I'm willing to do it but I'll have to find some time in my schedule for probably a half day of mind numbing tedium... unless we find a way to automate it, hmm that isn't a bad idea.  It would even be cool if it ran automatically as part of CI and issued an error if a test is marked skip but it passes and isn't flakey.

If we think it's fixed, can we just re-enable it and re-skip it if it starts flaking again?

The problem is I don't think it's fixed, I think it's possible that it's fixed because the thing I changed had wild unintended consequences that leaked into other tests and since the test order is randomized its impossible to say without testing it out wether it is fixed or not.

Testing this one test isn't a problem, it just becomes a problem if we want to ferret out all the potential issues that got fixed from that one change.

Is this problem just limited to the Scenario tests, or could other tests have been affected as well?

Ugh, I didn't realize this was a scenario app test.  Ignore everything I said, my fix was for the unit tests.  They look similar, sorry.

@gaaclarke To clarify, you're saying the fix you landed in https://github.com/flutter/engine/commit/27bf114b861e3bf7a95aef5b90e14e0206d78146 probably doesn't affect the disabled test that this issue is about?

@zanderso That's correct.

Closing as duplicate of https://github.com/flutter/flutter/issues/69438


fix: reduce usage of pointers to cope with race conditions

At least one occurrence of race conditions was observed: when running myks sync for a number of applications, generated vendir.yaml files get mixed up. The following lines of logs demonstrate the issue:
3:15PM DBG [phoenix-platform-production > httpbingo > sync] Running ytt to: creating vendir config
ytt --file=lib --file=.myks/tmp/data-schema.ytt.yaml --file=.myks/tmp/myks-data.ytt.yaml --file=prototypes/monitoring/vendir

Notice that this log output is printed for the httpbingo application, but the ytt command gets --file=prototypes/monitoring/vendir as one of the arguments.
This happens in this function: https://github.com/mykso/myks/blob/215ccd3f51231c20a07c92350eb7d0379dfd0784/internal/myks/util.go#L275-L287
Somehow the paths value is changed outside. Sometimes it might be correct at the beginning of the function but wrong some lines later. Sometimes it is wrong at the beginning, but correct in the caller function.
I didn't understand the exact mechanism behind this issue, but I was able to reproduce it. Switching from pointers to normal values solves the problem.

Nah, it breaks in other places without pointers. I have to find the core issue.


tmuxPlugins.vim-tmux-focus-events: init at unstable 2010-10-06

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.


[shardformer] fix bert and gpt downstream with new api

📌 Checklist before creating the PR

[x] I have created an issue for this PR for traceability
[x] The title follows the standard format: [doc/gemini/tensor/...]: A concise description
[x] I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge
e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?
fix bert and gpt downstream with new api
💥 Checklist before requesting a review

[x] I have linked my PR to an issue (instruction)
[x] My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
[x] I have performed a self-review of my code
[x] I have added thorough tests.
[x] I have added docstrings for all the functions/methods I implemented

⭐ Do you enjoy contributing to Colossal-AI?

[x] 🌝 Yes, I do.
[ ] 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.


Remove CMC reference

Change description
CMC reference sneaked in within my previous change. This PR removes it.
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[X] No

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #23   +/-   ##
=========================================
  Coverage     87.09%   87.09%
  Complexity       23       23
=========================================
  Files             9        9
  Lines            62       62
=========================================
  Hits             54       54
  Misses            8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d329cd...892ab49. Read the comment docs.


Consider enabling -Wextra

I enable -Wextra in all of my projects. While the warnings that it generates aren't quite as dangerous to ignore as -Wall, resolving those warnings tends to result in a codebase that's quite a bit more robust to hard to solve problems.

It probably wouldn't hurt.
I do believe I've tried it at some point, but felt it resulted in adding extra lines to just fix the warning messages, in code that isn't really wrong in any way (e.g. unused parameters which are actually used in an #if), without many, or any actual problems reported. If there are other similar situations and a lot of such extra code needs to be added, or significant amount of code needs to be made larger/less clearer just to silence the compiler, I'd avoid it. But I haven't explored the reported warnings enough to know how much of a problem that would be.


HTTPS connection issue

Problem/Motivation
Upon setting ssl": true, install with Hass.io Plugin DuckDNS Version 1.1 (w/ working LetsEncrypt via that same plugin), the connection to the URL for the IDE is refused.
Expected behavior

The IDE to show up and work via HTTPS.

Actual behavior
Existing open tab will not reconnect.
Cloud 9 IDE / Plugin Log Error ~ Existing Tab:
2018/02/27 12:05:27 [info] 666#666: *122 client closed connection while waiting for request, client: LOCALSUBNETIP, server: <IP_ADDRESS>:8321

New browser tabs provoke the error below.
Cloud 9 IDE / Plugin Log Error ~ New Tab:
2018/02/27 12:06:27 [warn] 666#666: no resolver defined to resolve ocsp.int-x3.letsencrypt.org while requesting certificate status, responder: ocsp.int-x3.letsencrypt.org, certificate: "/ssl/fullchain.pem"

Steps to reproduce
Here is some background / environmental information below...
No other Nginx plugin or running.
Environmental Info

Cloud 9 IDE Version 0.1.0
HA Version 64.0
Hass.io Version 1.21
Supervisor Version 0.95
Raspberry Pi 3
Ethernet connection, router DHCP reserved "static" IP.
Configuration.yaml setting:

http:
  api_password: !secret http_password
  ssl_certificate: !secret http_ssl_certificate
  ssl_key: !secret http_ssl_key
  base_url: sitename.duckdns.org

Secrets.yaml

http_password:<PHONE_NUMBER>ABC
http_ssl_certificate: '/ssl/fullchain.pem'
http_ssl_key: '/ssl/privkey.pem'

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

I cannot reproduce the issue.
SSL seems to work fine.
Only thing I can see, is the /ssl/ in the variable used for SSL certs. Like all add-ons in Hass.io, don't specify the /ssl/ path, since it assumes that already, causing it to look for it in /ssl/ssl/privkey.pem.


local only config

is there a config file i can put in some configurations that will be ignored by git and will overwrite any of the other shared config files. As i have a few configs i want different on my local machine to what my other devs use for development.

Fist of all: You shouldn't do this :-)   All Devs in a team should use the same config as far as possible (maybe exept for some local ip adress settings, but even that is normally just
"localhost")
But If you really need this, then you can introducee your own  config/local.env.js  file and then tell the dev-server.js to use these settings.


The Authorization header is missing. It must use the bearer authorization method.

MeiliSearchApiError: The Authorization header is missing. It must use the bearer authorization method.
code: missing_authorization_header
type: auth
link: Optional("https://docs.meilisearch.com/errors#missing_authorization_header")
status: 401

MeiliSearch (0.12.0)

Hey @mdotadil , this issue will be fixed once this PR has been merged #243
Meanwhile the package is compatible with meilisearch v0.24.0


updated screenshots of lab guide

Module: 00
Lab/Demo: 00
Fixes # .
Changes proposed in this pull request:

Thank you so much for taking the time to contribute to our project! I appreciate the effort you put into it.
However, I noticed that the pull request contains a lot of changes that cover multiple modules and exercises. In order to make the review process more efficient and easier to manage, it would be great if you could consider breaking down your changes into smaller, more focused pull requests that correspond to specific modules or exercises.
I appreciate your continuous support.


outdated package.json

Hi, when create a fresh new nuxt app via
yarn create nuxt-app <project-name>

the package json seems to show the wrong version of the packages.
For instance:
"dependencies": {
    "nuxt": "^2.0.0"
  },

Which currently is 2.8.1

Hello @tiagomatosweb.
I don't think it's a problem because the ^ is there to ensure you get the latest minor version.

Certainly @jpsc but it is annoying see the wrong version of packages, not just for nuxt.
Anyway ...

Constraints in package.json !== actual version number.


feat: reset meta widgets

Description
The introduction of metaWidgets requires that when resetting a widget alongside its children, we also reset metaWidgets it generates.
This PR introduces the reset functionality for metaWidgets.
Fixes # (issue)

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.
Delete anything that is not important

Manual
Jest
Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/ok-to-test sha=92ac4a2

/ok-to-test sha=5840619

Tested this PR and LGTM

Tested reset functionality on List v2
Tested reset functionality on child and parent widgets
Tested reset functionality with List inside List widget


feat(core): CW-22062 add se version 341

Checklist:

README.md includes:

[ ] The details of signing data and transaction data, this includes parameters.
[ ] Official docs or white paper.
[ ] Website or api can query assets and broadcast transaction.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Task linked: CW-22062 DOT在340的卡片會發送失敗


[T2] security 2020 11 10

https://github.com/Azure/sdk-release-request/issues/947

/azp run prepare-pipelines

/azp run python - securityinsight - ci

/azp run prepare-pipelines

/azp run python - securityinsight - ci


Add gcloud JSON output de-serialization classes

AppEngineDeployResult for the gcloud app deploy stdout, which contains the info about deployed apps.
GcloudStructuredLog for structured log entries from gcloud

@etanshaul how do you feel about this?

After discussion with @elharo, I am going to remove the semantic checks. Any missing fields will just be null, and clients will decide what to do with them.

please include @loosebazooka on these PRs.
@loosebazooka is there a way to setup the PR template to always include you as reviewer?

@chanseokoh also we need more context on what problem this change is solving, how it's supposed to be used, and why and how it integrates with the core library APIs.

agree with @patflynn; decoupling this from the consumption makes it difficult to follow without more explanation

AppEngineDeployResult is a class with 1-to-1 correspondence to the JSON that a successful gcloud app deploy outputs. The JSON looks like this:
{
  'configs': [],
  'versions': [
    {
      'id': '20160429t112518',
      'last_deployed_time': null,
      'project': 'bizarre-project',
      'service': 'display-service',
      'traffic_split': null,
      'version': null
    }
  ]
}

As a de-serialization of JSON to a Java class, it allows clients of appengine-plugins-core to get the values of the JSON in Java language. The primary usage in our plugin context is to found out the app version generated by gcloud (as well as the service and the project), so that we can open a browser pointing to the deployed app with the right URL.
AFAIK, Eclipse and IntelliJ both have this class in duplication. I am pushing this to appengine-plugins-core. As a Java representation of JSON output by gcloud, I think this fits into appengine-plugins-core.
Similarly, GcloudStructuredLog is a 1-to-1 de-serialization of JSON that gcloud outputs in the recently proposed structured log format. (I believe you all know what this structured log format is.) The primary usage in our plugin context is to reliably recognize and extract deploy error messages that are mixed together with normal gcloud app deploy output.

Codecov Report

Merging #440 into master will increase coverage by 0.49%.
The diff coverage is 96.55%.

@@            Coverage Diff            @@
##           master    #440      +/-   ##
=========================================
+ Coverage   65.81%   66.3%   +0.49%
=========================================
  Files          64      66       +2
  Lines        1790    1819      +29
  Branches      281     285       +4
=========================================
+ Hits         1178    1206      +28
  Misses        489     489
- Partials      123     124       +1

Impacted Files
Coverage Δ

...ne/cloudsdk/serialization/GcloudStructuredLog.java
100% <100%> (ø)

.../cloudsdk/serialization/AppEngineDeployResult.java
92.85% <92.85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 713bff4...7f5d352. Read the comment docs.

For the deployment output, what are the proposed changes to the deploy API to support this? Returning an AppEngineDeployResult from AppEngineDeployment#deploy?
For the structured output part I'm less clear on how you plan on supporting this. Currently, the stdout is sent line by line using a ProcessOutputLineListener. Could you elaborate on how GcloudStructuredLog will be used in this context?

They are just standalone de-serialization classes correspond to the said JSON outputs. Nothing more than that. They are on their own, and they are not coupled in any way with other existing APIs.
So, clients have responsibility to capture the relevant JSON first. Then, they will simply call .parse(jsonString) to de-serialize it into Java. That said, clients still need to use ProcessOutputLineListener and do whatever is needed to get the JSON portion. We could add more supporting and convenience APIs to cover this portion in appengine-plugins-core too, but I'm not tempted to go this way until we complete migration to use Future.

Aha I see. I didn't realize that the scope of this was just to encapsulate these value classes in the core-lib so that the clients don't have to duplicate them. Makes sense.

@loosebazooka are you good with this?

Yeah sorry I didn't get to see this. Do we have a guarantee from the cloud SDK team that the format wont change? How can we break fast when the cloud sdk makes a breaking change? Will that just manifest itself in integration tests from the IDEs?

There is no such a guarantee of course (anything can change hypothetically), though it will be very unusual for them to change the deploy output JSON format. CT4E for example will already break now if the format changes. However, for the logging message format, this is quite new in Cloud SDK. This is mainly for extracting an error message, so I expect IDEs will fall back to a default canned message if it fails to extract a message for any reason (including JSON format change or missing JSON properties).


Force config file setting to expanded path in chef-client

I attempted to fix this previously in https://github.com/chef/chef/pull/3963 but it regressed; I wasn't able to track down the commit that broke it, but in any case that fix wasn't very stable because quite a few config paths are evaluated relative to the config file path, which is expanded relative to cwd, and chef-client chdirs to root right after the config file is read.
@chef/client-core

Travis issue is incompatible gems in the tests that use poise, Noah is on the case there.

:+1:

:+1:


clock: bump test version in stub file

After reworking clock tests in 0c4961d test version in stub file was not upgraded. This PR fixes that.

Right you are. Thanks.


Use draw_idle instead of draw in remake_ticks

Description
xija_gui_fit is prone to crashing, often without error messages, or only cryptic error messages such as this one:
(ska) acis-110: xija_gui_fit ./dpa_spec_PROD.json --days 365 --stop 2022:105:00:00:00.00 &
Fetching msid: 1dpamzt over 2021:104:23:37:10.816 to 2022:105:00:19:02.816
info:numexpr.utils:NumExpr defaulting to 4 threads.
Fetching msid: sim_z over 2021:104:23:37:10.816 to 2022:105:00:19:02.816
Fetching msid: pitch over 2021:104:23:37:10.816 to 2022:105:00:19:02.816
Fetching msid: roll over 2021:104:23:37:10.816 to 2022:105:00:19:02.816
Fetching msid: aoeclips over 2021:104:23:37:10.816 to 2022:105:00:19:02.816
Getting kadi commanded states over 2021:105:00:04:30.816 to 2022:104:23:51:42.816
Fetching msid: dp_dpa_power over 2021:104:23:37:10.816 to 2022:105:00:19:02.816
Adding plot  1dpamzt data__time
Adding plot  1dpamzt resid__time
Traceback (most recent call last):
  File "/data/acis/miniconda3/envs/ska/lib/python3.8/site-packages/matplotlib/backend_bases.py", line 3031, in _wait_cursor_for_draw_cm
    yield
  File "/data/acis/miniconda3/envs/ska/lib/python3.8/site-packages/matplotlib/backends/backend_agg.py", line 439, in draw
    super().draw()
  File "/data/acis/miniconda3/envs/ska/lib/python3.8/site-packages/matplotlib/backends/backend_qt.py", line 424, in draw
    self.update()
RuntimeError: wrapped C/C++ object of type MplCanvas has been deleted

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/data/acis/miniconda3/envs/ska/lib/python3.8/site-packages/matplotlib/cbook/__init__.py", line 287, in process
    func(*args, **kwargs)
  File "/data/acis/miniconda3/envs/ska/lib/python3.8/site-packages/Ska/Matplotlib/core.py", line 97, in remake_ticks
    ax.figure.canvas.draw()
  File "/data/acis/miniconda3/envs/ska/lib/python3.8/site-packages/matplotlib/backends/backend_agg.py", line 439, in draw
    super().draw()
  File "/data/acis/miniconda3/envs/ska/lib/python3.8/contextlib.py", line 131, in __exit__
    self.gen.throw(type, value, traceback)
  File "/data/acis/miniconda3/envs/ska/lib/python3.8/site-packages/matplotlib/backend_bases.py", line 3033, in _wait_cursor_for_draw_cm
    self.canvas.set_cursor(self._lastCursor)
  File "/data/acis/miniconda3/envs/ska/lib/python3.8/site-packages/matplotlib/backends/backend_qt.py", line 259, in set_cursor
    self.setCursor(_api.check_getitem(cursord, cursor=cursor))
RuntimeError: wrapped C/C++ object of type MplCanvas has been deleted
Traceback (most recent call last):
  File "/data/acis/miniconda3/envs/ska/lib/python3.8/site-packages/matplotlib/cbook/__init__.py", line 287, in process
    func(*args, **kwargs)
  File "/data/acis/miniconda3/envs/ska/lib/python3.8/site-packages/matplotlib/backend_bases.py", line 3077, in _zoom_pan_handler
    self.release_zoom(event)
  File "/data/acis/miniconda3/envs/ska/lib/python3.8/site-packages/matplotlib/backend_bases.py", line 3232, in release_zoom
    self.push_current()
  File "/data/acis/miniconda3/envs/ska/lib/python3.8/site-packages/matplotlib/backend_bases.py", line 3243, in push_current
    self.set_history_buttons()
  File "/data/acis/miniconda3/envs/ska/lib/python3.8/site-packages/matplotlib/backends/backend_qt.py", line 797, in set_history_buttons
    self._actions['back'].setEnabled(can_backward)
RuntimeError: wrapped C/C++ object of type QAction has been deleted

This can be resolved if the call to ax.figure.canvas.draw is changed to ax.figure.canvas.draw_idle in remake_ticks, which is what this PR does.
From the Matplotlib documentation:
"In almost all cases, we recommend using backend_bases.FigureCanvasBase.draw_idle over backend_bases.FigureCanvasBase.draw. draw forces a rendering of the figure whereas draw_idle schedules a rendering the next time the GUI window is going to re-paint the screen."
Testing

Changing this line fixes crashes in xija_gui_fit.
I checked that the iplot functionality in cheta works correctly with this change.

@jzuhone - thanks, looks reasonable. This probably also needs some testing of the original standalone functionality when running interactively in an IPython terminal session.

@taldcroft good call--I did check and the interactive plotting does work correctly.

any reason not to merge this PR?


Hidden comment thread requires double click to reveal the first time

Open a pull request that has comments made already
Open the changed file with the comment
When the comment thread is hidden by default, first click on the comment icon doesn't reveal it. The second does.

@rebornix I'm not able to reproduce this. Do you know why the comment was hidden by default?

@alexr00 I don't know, it seems they are often hidden for me. I thought we had heuristics (a feature but not bug). But now I think it's probably a state out of sync. The widget is not visible, but the state says it is, so the first click hide it again.

@alexr00 I don't know, it seems they are often hidden for me. I thought we had heuristics (a feature but not bug). But now I think it's probably a state out of sync. The widget is not visible, but the state says it is, so the first click hide it again.

I met the same issue with my own extension.
It seems that if I set the default collapseState to Expanded, then I have to click the comment thread twice to expand it.
Set to Collapse with code or don't set anything, the behavior is correct -> Show up comments thread collapsed by default and expand it by click it once.

@rebornix I'm not able to reproduce this. Do you know why the comment was hidden by default?

From my side, if I set vscode.CommentThreadCollapsibleState.Expanded to thread.collapsibleState, this case happens.
It works well if I set vscode.CommentThreadCollapsibleState.Collapsed or set nothing to thread.

Any progress on this issue?

I can reproduce the issue in web but not in desktop.

I can reproduce the issue in web but not in desktop.

yes, happened in web.

Any progress?

Now I'm not able to reproduce this at all. @KrabsWong are you able to reproduce this in insiders.vscode.dev?

Now I'm not able to reproduce this at all. @KrabsWong are you able to reproduce this in insiders.vscode.dev, and if so, can you share the pull request you saw the issue with?

Test from my side with github.dev (vscode version 1.73.1), expanded by default works well.
Test repo: https://github.com/KrabsWong/comments-expanded-verification
Test extension: https://marketplace.visualstudio.com/items?itemName=t-codespaces.comments-expand-verification
Step

Open any file
Execute command "Insert demo comments"

Then there are two comments added to line 2 and 4 with expanded by default

@KrabsWong thanks for confirming that it works as expected for you now. Closing as this appears to have been fixed in the time since the issue was filed.

@alexr00
In what version was this issue fixed? I'm 1:1 reproducing it on 1.74 version (desktop). For example with GitHub Pull Requests and Issues plugin:

Configure "githubPullRequests.commentExpandState": "expandUnresolved" in settings json.
Open PR and file  with unresolved comments.
Unresolved comments appear as collapsed and 2 clicks are required to expand the thread

@sergei-dyshel those of us who saw this work actually just got lucky. It is actually fixed only in insiders (1.75) right now.

Should be this one: https://github.com/microsoft/vscode/commit/65462a0974c14bde44b88d7a772160dd680e80f2


Error: Undefined attribute level operator 0

Issue Description
When making a request to the Strapi plugin with the $location[coords] parameter, I've observed an issue where if I set the radius to a value greater than 406, it results in an error: Error: Undefined attribute level operator 0. Upon further investigation, it seems that this error is related to a change in the data type of the variable when the array of IDs contains a large number of elements.
Steps to Reproduce

Make a request with the following parameters: ?$location[coords]=40.848557,14.255131,406.
Observe the error: Error: Undefined attribute level operator 0.

Expected Behavior
The plugin should handle requests with a radius greater than 406 without producing an error.
Additional Information
I noticed that when the array of IDs becomes large, the data type of the variable appears to change from an array of numbers to an array of objects. This transition in data types may be the root cause of the issue.
Environment

Node.js version: 18.16.1
Strapi version: 4.9.1
Plugin version: 1.1.4
Operating system: Ubuntu

Please let me know if you need any more information or if there are specific steps to reproduce the issue.
Screenshots

Hi @Ademboussetha, thank you for reporting this issue you have encountered. Unfortunately, I have not been able to reproduce it.
I created 26 entries (default response length is 25 entries) and performed a request with a perimeter of 5000. See screenshot.

Everything worked as expected with no error. Could you please provide more info how I could reproduce the behaviour you are enctoutering?
Thank You :)

@Ademboussetha Just FYI I have discussed this with our senior Strapi developer and even he was not able to solve it so we will contact someone from Strapi.

@omikulcik I've come up with a solution, but it's more of a workaround that involves processing the array in chunks of 100 at a time.

@Ademboussetha You can submit a PR with the solution if you want. We have discussed this with Strapi and the are unsure why this might be happening. They think it might be a bug in Koa which is a dependency of Strapi.


raidemulator: Update job fields to use Job type

I feel like there's a better way to handle CombatantJobSearch but I can't see it?
This is in prep for converting PopupTextAnalysis to typescript. I'll probably visit the JobDetail type next since that's also causing some annoyances with conversion.

I feel like there's a better way to handle CombatantJobSearch but I can't see it?

You could spend the upfront time to create a map of <abilityId, Job>; seems kind of unreasonable, but it might not be given that you could have the map registered before loading any fights. Otherwise, you could have the abilityIds be a Set so you could .has(), or you could make all the abilityIds strings and use a Trie 👀. Alternatively, you could store a local variable, run through everything, and return foundJob ?? 'NONE';, which might help any !job checks.

I like this suggestion a lot more than what I have. The only difference is that it shouldn't return 'NONE', because that breaks the downstream logic.
Performance for this function isn't that important, it's more important that the map of jobs to ability IDs is maintainable. This function gets called at most 40 times per encounter but most likely it won't get called at all. This function is primarily used to determine the job of a player if they don't fire a line event that includes job ID during the encounter, and it'll only be called if a job hasn't been determined yet (using this function or a line that includes a job ID).

I like this suggestion a lot more than what I have. The only difference is that it shouldn't return 'NONE', because that breaks the downstream logic.

That's fair; I wasn't sure if there was a reason to have it be undefined or if it made more sense for it to always return a Job, even if that job is none.
(Also sorry for the bug!)


Snapshotter status report structure update and support for http IPFS URL

Includes changes from #34, #35 and #37
Checklist

[x] My branch is up-to-date with upstream/main branch.
[x] Everything works and tested for major version of Python/NodeJS/Go and above.
[x] I ran pre-commit checks against my changes.

Summary

Snapshotter status report now has valid reason for failure and snapshot data for better tracing
Support for http IPFS URL has been added, eg. http://localhost:5001 or https://ipfs.infura.io:5001 are now valid URLs
Signature deadline has been increased from 10 to 30 in settings.example.com
Payload commit service now publishes snapshot submmited event. For more info refer #37

Deployment Instructions
Increase Signature deadline (settings.signer.deadlineBuffer key) to 30

Noticed these errors upon running it for some time. Please take a look

Issue has been addressed in the PR #38


Reserved words

header
impl

See https://stackoverflow.com/questions/44217331/what-does-impl-mean-in-kotlin

Now they're
expect
actual

@Jonatino @nishtahir @francis36012 @mathiasfrohlich :smiley:

This should be pretty easy to update.


Show path for pypi source dependencies in pixi list

Problem description

We could add the path there.

And maybe an editable identifier? for example -> .

Yes, totally, should be relatively straight-forward.


Update IdP-Initiate Login / Logout URL for Keeper

References: https://docs.keeper.io/sso-connect-cloud/identity-provider-setup/azure-o365-keeper

@jeevansd

Can you review this PR?

IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@Jak-MS @MicrosoftDocs/public-repo-pr-review-team Can you review this pull request?

@shao1555, creating a separate PR for your changes in our private repo.
#please-close


Fixes #212: Updates tf install to use cuda

Fixes #212 on tensorflow install by updating requirements file.
Relates to icenet-ai/icenet-pipeline#28

Refer to comment by James on wanting to stick with Python 3.8, which uses tf 2.13.1 - doesn't use tensorflow[use-cuda] syntax yet. Hence, PR closed.
https://github.com/icenet-ai/icenet-pipeline/issues/28#issuecomment-1895493876


[WIP] Remove SMQTK classification from core

This moves all of the weapon classification specific JS/UI elements from the core to the weapons plugin.
The server-side code is still a WIP, but at least other domains won't have the eyesore of revolver classification checkboxes.

LGTM 👍


GitHub action for closing linked issue on PR merged into release

We want a linked issue to be closed when the PR is merged to not only master but release. There seems to be an action doing this: https://github.com/ldez/gha-mjolnir

I have squashed this PR as ab71ae528108354122e72337f26f01c875ab85db


Relative PRISMA_QUERY_ENGINE_BINARY does not work in both CLI and Client

If you use a relative path for PRISMA_QUERY_ENGINE_BINARY (like e.g. just the file name) it will either work in the CLI or the Client, but not in both:

Create folder, go into it, npm init -y, npm install -D prisma, npm install @prisma/client
npx prisma -v
Copy query engine into the project directly (e.g. cp<EMAIL_ADDRESS>query-engine-windows.exe)
npx prisma init
npx prisma generate, add suggested model to schema file, npx prisma generate again
Set PRISMA_QUERY_ENGINE_BINARY to filename where you copied the file to (not absolute path)
Run npx prisma -v again to confirm CLI can use the binary
Create script.js:const PrismaClient = require('@prisma/client').PrismaClient
async function main() {
  const prisma = new PrismaClient()
  await prisma.$connect()
}
main()

Set DEBUG=*
Run node script.js
Observe how the CLI tries to resolve the binary relative to the prisma subfolder and fails:λ node script.js
  prisma:tryLoadEnv Environment variables loaded from C:\Users\Jan\Documents\throwaway\relativeRepro\.env +0ms
  ...
  prisma:client clientVersion: 2.25.0 +0ms
  prisma:engine { cwd: 'C:\\Users\\Jan\\Documents\\throwaway\\relativeRepro\\prisma' } +0ms
  prisma:engine { flags: [ '--enable-raw-queries', '--port', '61969' ] } +129ms
(node:7604) UnhandledPromiseRejectionWarning: Error: spawn query-engine-windows.exe ENOENT
    at Process.ChildProcess._handle.onexit (internal/child_process.js:269:19)
    at onErrorNT (internal/child_process.js:465:16)
    at processTicksAndRejections (internal/process/task_queues.js:80:21)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:7604) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:7604) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

The cwd is set to the prisma folder, but for the CLI the actual folder where you are running the command is used as the starting point to find the query engine binary.

I can reproduce this on a Mac.

Thanks for the quick repro, while you did that I figured out that relative paths do not seem to work at all in Client for this env var :(
https://github.com/prisma/prisma/issues/7780
I am closing this here then as the other one seems to be the underlying reason.


[ENHANCEMENT] Update readme.md

Description
The current README lacks visual appeal and comprehensive information, making it challenging for users to quickly grasp the project's technology stack, and structure.I propose updating the README by adding tech stack logos to visually represent the technologies used and include a table of contents for easy navigation.
Actual Behavior
I observed no visualization of tech stack logos and table of contents(clickable) is missing
Expected Behavior
A well-structured and informative README is crucial for users to quickly understand the project's technology stack, structure, and key features.
Steps to Reproduce (if applicable)

Step 1
Step 2
Step 3

Screenshots (if applicable)
Actual:
(screenshot)
Expected (highlight the part that requires changes):

@itsmohit097 please assign this work to me

Hello there,
There is no need for a readme enhancement .
the current readme file is fine and well structured, explaining the project efficiently.
Please close the Issue,


chore(dashboard): temporarily remove fontFamily from public api

Overview
remove fontFamily from public api
Legal
This project is available under the Apache 2.0 License.

not a chore, chores are things like 'fixing linting errors'. This would be better indicated as a refactor

not a chore, chores are things like 'fixing linting errors'. This would be better indicated as a refactor

udpated.


Replace ACE for newest version.

I want to do this for 3.3, shouldn't be a big deal in theory but hopefully will reduce some of the warnings in AMO because of it.

Oh I just did this.


[WIP] feat: replace the current 'Admin Tools' tab (based on a flex-grid of …

…app launchers) with the  Web Component

Checklist

[x] the individual contributor license agreement is signed
[x] commit message follows commit guidelines

Description of change

This is a very significant cosmetic improvement to the Admin Tools tab -- thanks @jgribonvald!

These request won't be a terrible effort ;)
It's easy to add a property to set the filter on a category and in this case why not showing directly the category name ? The title is an i18n, It may be great to extend the component by providing a custom i18n maybe.
on an other way do you need the filtering area ? It could be disabled by a property too, or automatically when a category is applied by default.
Also we can disable the title and the filtered area depending on a property.

+1 for "uPortal Administration Tools"

🤔 we need to find a newer set of icons... don't you think @ChristianMurphy ?

thinking we need to find a newer set of icons... don't you think @ChristianMurphy ?

Newer icons could refresh the look of the admin console. :+1:
A few ideas for sources of new icons:

https://undraw.co/illustrations
https://fontawesome.com/icons?d=gallery&m=free
https://materialdesignicons.com/

I can share our set of icons, we planned to create a repository shared between some ESUP members but we can do it on up-contrib.

thinking we need to find a newer set of icons... don't you think @ChristianMurphy ?

Newer icons could refresh the look of the admin console. 👍
A few ideas for sources of new icons:

https://undraw.co/illustrations
https://fontawesome.com/icons?d=gallery&m=free
https://materialdesignicons.com/

undraw is impressive also... 👁


Metrics support

Describe the feature request
Hi,
I have noticed that Swift proxy client does not currently report metrics. Do you plan to add metrics support as per https://docs.getunleash.io/api/client/metrics?
Background
JS Client already supports it, so getting this to work on iOS would be a nice feature.
Solution suggestions
No response

Hey @thedotedge 👋
Thanks for sharing this feature request. I'll check with the team for a quick status and if there are no immediate plans, would you like to help out and contribute to the project?

Thanks @sighphyre! Swift is not really my cup of tea though 😅 @loongman would it be something interesting for you?

@thedotedge Completely understand, you and me both!
I'm going to pin this for now so it doesn't get closed by our bot or forgotten about

Metrics support added in https://github.com/Unleash/unleash-proxy-client-swift/releases/tag/0.0.7


zero os rebooted for unknown reasons

Issue migrated from https://api.github.com/repos/zero-os/0-core/issues/685, opened by @LeeSmet
Last night a zero os node suddenly rebooted. Crash log is empty
kernel params: debug, development, log-sync. No jwt

*commented by @muhamadazmy
Without the crash report we can't really tell what happened. I remember checking the logs of this machine but it did not have anything useful.
We couldn't also reproduce this issue. @LeeSmet were u able to reproduce this issue

NOTE: log-sync flag is not needed, we had it for a very short time and we dropped it. *

commented by @LeeSmet
I haven't had the issue on another node so far. Since this is a production env, I'm not to keen on trying to reproduce this though.


Symfony 6 support

Hi!
Any plans for Symfony 6 support?

Hi @thomask 👋 This is on our radar, but we do not currently have a timeline I can share on this.


Improve addition of www redirect to Traefik

Note: Ouch, I deleted the PR template stuff accidentally and a hard refresh won't reload it in the editor.
Description
PR #2524 adds an additional www.{{ cookiecutter.domain_name }} to the traefik route. However, this helpful redirect may not be useful if the domain_name itself is a subdomain, e.g. api.example.com. In this case an additional www.api.example.com route is added to traefik. This PR provides a best effort check for detecting subdomain usage and conditionally adds www.{{ cookiecutter.domain_name }} to the traefik route.
Rationale
As per this discussion

There exists a python package for getting the TLDs/STLDs: tldextract , but this adds a pip dependency which I think is out of question?
I am fine with reverting #2524 , or if we want to add the www route on best effort basis, we can merge this in.
@sorasful : thoughts?

External dependency is out of question yes, it would be needed when running the cookiecutter CLI.
I see your point, we'll default to the old behaviour if we're not sure. In this case I think we can just go with the most naive approach and add the www only if we have only one dot as you initially suggested.
IMO we should either treat all special second level TLDs or none.

Sounds good, I will add another commit that'll add www route if there's just one dot in the domain_name variable.

Not sure why the Labeler fails, I am not familiar with this project's CI/CD setup. Let me know if there's something wrong in my commits and I will be happy to fix it.

Yes, you may ignore this. There was some syntax errors in the CI config file initially. If you merge merge master in you branch it'll be fixed.

Hi, I've read all your messages. I didn't think about the cases you mentionned, yep I agree with you with keeping things simple, even if that means reverting. The option to count 1 dot is cool IMO.

@browniebroke I rebased my branch off upstream/master but the labeler still chokes. I am going to ignore it and be happy that Travis-CI doesn't break.
I thought about adding tests and all, but this project is unusual in it's goal that writing tests for these things is rather impractical if not downright impossible. I mean really "testing" if www domain resolves in a test environment is a long yak shaving process that leads into lets encrypt's testing facilities (I am not digging into pebble ) with custom /etc/hosts to ensure some variations of curl https://www.fake.root resolves and so on and so forth. Ugh, no thanks right now 😝
On other hand, those tests could be nice infra tests for the resulting project. So maybe there's another PR in the making (someday, soon, hopefully, 😃 )

Hum, odd, yes the error was different this time, I might just remove it actually. It looks like it's broken...
Anyway, thanks for the fix!


[Fix] order: fix alphabetical sorting

Fixes #2064
Added a new test for the broken scenario.

Coverage increased (+0.9%) to 82.372% when pulling 389a37f8efc4e8ed9492e659ca79f26f7994824d on grit96:fix-2064 into 821354381f3e1108bca7670cb8d84a95769d035b on benmosher:master.

Coverage increased (+0.9%) to 82.372% when pulling 389a37f8efc4e8ed9492e659ca79f26f7994824d on grit96:fix-2064 into 821354381f3e1108bca7670cb8d84a95769d035b on benmosher:master.

Coverage increased (+0.9%) to 82.372% when pulling 389a37f8efc4e8ed9492e659ca79f26f7994824d on grit96:fix-2064 into 821354381f3e1108bca7670cb8d84a95769d035b on benmosher:master.


fix: update image path

Description

How Has This Been Tested?

Merge criteria:

[ ] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

@zdtsw is this good for now?
@astefanutti  I'll create an issue to update this var as part of the release process

Update to use quay.io/opendatahub/codeflare-operator instead of quay.io/project-codeflare/codeflare-operator can done later on.

/approve


tests: cargo test-bpf example

There should be an educational example using cargo test-bpf and program-test in Rust.

Do you mean cargo build-bpf?

@armaniferrante i'm tackling this in my own project, how can I contribute back? Example as in example in the wiki or an example in generated code?

Is this issue closed? If not can I work on it.


Delayed acks impl

Motivation
This PR is based on top of #1450. I'll rebase once first one is merged.
The processing of acknowledgments constitutes is broker a big chunk of CPU work. Even then, we throttle the persistence of acks to BK (default is once per sec).
In addition to that, acknowledgments generates a large number of very small IP packets and these are most expensive to process by OS/NIC (compared to fewer bigger packets).
This change introduces client side batching for acknowledgments. By default client, will group the acks and send out a single protobuf command every 100ms. Consumer can configure the delay, or set it to 0 to fall back to original behavior.

Rebase to master

retest this please

can we add  CommandAckDeprecated in proto-schema which can be used by client if broker-verison is < V12 ?

@rdhabalia The code should already be sending 1 single ack if the broker is < 2.0 :
https://github.com/apache/incubator-pulsar/blob/233c77fca1ac1bfbc439c2246a45673ff366bfc3/pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java#L171 with the check validating for v12 : https://github.com/apache/incubator-pulsar/blob/1893323bc2f22001b63ea0d310ec47e88889e3e0/pulsar-common/src/main/java/org/apache/pulsar/common/api/Commands.java#L1073
Let me verify that the repeated field, when 1 single entity is present, is equivalent to the "required" type.

@rdhabalia  I did the test by using :

Broker 1.22.1
Producer 1.22 (perf-producer)
Consumer from master (2.2-SNAPSHOT) (perf-consumer)

I could no reproduce the issue. There are no unacked messages. Do you have a better way to reproduce?


Optimize DB size

Right now our testnet DB consist of following columns:
dag_blocks has size: 11 802 796 806
dag_blocks_index has size: 860 430 486
dag_blocks_state has size: 875
dag_finalized_blocks has size: 428 291 313
transactions has size: 6 297 607 802
trx_status has size: 1 542 491 759
status has size: 2 723
pbft_mgr_round_step has size: 4 177
pbft_round_2t_plus_1 has size: 7 903 736
pbft_mgr_status has size: 4 282
pbft_mgr_voted_value has size: 4 427
pbft_cert_voted_block_hash has size: 13 322 582
pbft_cert_voted_block has size: 49 643 163
pbft_head has size: 2 324
pbft_blocks has size: 50 429 981
unverified_votes has size: 22 125 398
verified_votes has size: 11 054 047
soft_votes has size: 137 844
cert_votes has size: 4 952 054 286
next_votes has size: 231 148
period_pbft_block has size: 13 423 304
dag_block_period has size: 620 841 300
dpos_proposal_period_levels_status has size: 4 179
proposal_period_levels_map has size: 8 201 836
final_chain_meta has size: 4119
final_chain_transaction_location_by_hash has size: 1 671 311 590
final_chain_replay_protection has size: 0
final_chain_transaction_hashes_by_blk_number has size: 1 136 738 974
final_chain_transaction_count_by_blk_number has size: 6 924 552
final_chain_blk_by_number has size: 132 925 947
final_chain_blk_hash_by_number has size: 13 429 413
final_chain_blk_number_by_hash has size: 13 422 931
final_chain_receipt_by_trx_hash has size: 1 840 893 436
final_chain_log_blooms_index has size: 75 798 299

We should check if there is no place for improvements e.g. removing data from trx_status as when trx is part of pbft block does not make any sense ...

also final_chain_blk_hash_by_number looks almost same as period_pbft_block


Feature/shorthand commands

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix (non-breaking change which fixes an issue)
[x] Feature (non-breaking change which adds functionality)
[ ] Code style update
[ ] Refactor (refactoring or adding test which isn't a fix or add a feature)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

Did you test your solution?

[x] I lightly tested it
[ ] I deeply tested it
[ ] I wrote tests around it (unit tests, integration tests, E2E tests)

Problem Description
Add shorthand commands for all available commands
Solution Description
Add shorthands for --verbose, --debug, --init, --quiet. Update the exisiting shorthand for --version
Side Effects, Risks, Impact
N/A

I resolved the conflicts and made some vulnerabilities updates, I think this one is good to go


Update tutorial workspace setup documentation

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues in the following format: Resolves issue1, issue2, etc.
Tutorial workspace mentions that the Integration Studio should be extracted which is not the case for MacOS.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Browser support?

Need to know what browsers we need to support.  As of now we are looking at IE9+, FF 10+, Chrome?

IE8???

Note: The Openlayers 3 .js library does not work out of the box with Internet Explorer 8

Need to check with AGC on version of IE on deployed laptops.
(mpg to take on for Sprint 3)

entered issue 102 in omar-agc-pm, to replace this one


Cannot access API via https AND / OR etherpad is embedded via http instead of https (which breaks the editor)

Hi there,
I got some issue which prevent me from acutally using the notes module in combination with etherpad.
My setup:
HumHub 1.3.9 up and running on a debian stretch server via apache on port 80 / plain http.
I've got a reverse proxy set up with SSL/TLS which is securing the transport to the outside while proxying the unsecured http-datastream on the inside.
On the same server, etherpad is running (current master from GitHub) and working with a MySQL-Setup. It listens on the default port 9001 (SSL disabled, so that "internally" everything is plain http) and if accessed directly from within the network over http works just fine.
I followed the provided instructions from the module docs-folder very closely, added the rewrite rules to the apache conf and set up the apache reverse proxy part of the configuration.
If I access etherpad from the outside via https://HumHub-URL/pad/ it just works.
But when I activate the Notes Module and configure it, I have to enter the URL with http instead of https, as the "internal" communication between HumHub and Etherpad is of course "unsecure".
Now, as soon as one creates a new note and clicks on the edit button (in a modern browser), the default note is shown but absolutely no edit-elements are there. You cannot do anything.
When accessed with the IE (just for testing, i promise ;) ) I see the problem: IE warns about mixed / unsecure content, which shows me that even if I requested the site from the outside, so that my request was https:// and the reverse proxy in front of the webserver "translated" it correctly, the embedded etherpad somehow still gets delivered with http:// instead of https:// (and modern browsers just block that stuff, with only the IE at least showing some message).
As IE does give you the option to also load the unsecure content, the editor loads in and all works well.
I already tried running etherpad internally with SSL support by editing its settings.json and verifying that it does SSL (systemctl status etherpad and accessing it via https directly from an internasystem), in hope that I could bring HumHub to load etherpad via https, but to no avail. I couldn't even get the module API configuration to accept the URL with a https in front of it - even when etherpad definitely listens on port 9001 with SSL enabled (verified as mentioned above) i had to enter the URL with a plain http:// (without the s) to successfully connect to the API...
Any help / thought would be appreciated. Thanks in advance. :)

fixed.
as dumb as it sounds, the problem just being an entry in /etc/hosts to the external fqdn that referred to the local ip address.
as soon as this was removed, i could use https://... for the API URL and now everythin works, etherpad loads without mixed content warning just fine...


Support renaming of relationships

This PR introduces the ability to rename relationships in the JSONAPI View.
Other changes in this PR are mostly to rename a few variables local to functions where I felt that it served clarity (like view -> parent_view).
Similar results can be achieved for attributes by writing custom functions of the same name as the attribute being exposed. I considered adding relationship renaming in a similar fashion, but I believe that with relationships you gain more by not needing to dig into the model and produce the relationship yourself than with attributes and at the same time there is less benefit to writing an entire function (I am not aware of use-cases beyond renaming the relationship that would benefit from this other than fabricating relationships that are not represented in the underlying data-source).
As a side note, fabricating relationships is supported as-is with the feature this PR provides, but it feels like an unusual enough desire to not document explicitly in the readme.

Thanks for the PR @mattpolzin! I'll spend some time today reviewing this but at a quick glance this looks good and has test coverage 🎉

I think I'll merge this soon and start working on release notes for a new release (there will have been a solid chunk of changes, not just this PR) if no one comments to say they are going to leave a review in the near future.


Connection is closed with Promise.all

I'm finding rampant "Connection is Closed" errors when attempting to paralellize multiple requests using the native Promise.all.
For example if I try to run 4 queries in parallel to SELECT from the same table, the first Request in the Promise.all reports the error.
If I try to run 4 INSERTs requests in parallel into the same table (yes I'm familiar with bulk), the first Request in the Promise.all array reports the error, but the last Request succeeds with insertion (as verified by direct SQL calls to the server).
I believe this bug is related to the Tedious Bug.

I receive this error as well. I only have two requests in my Promise.all but it throws an error saying the connection is closed. This is for a web server but this is my code:
    Promise.all([
      fetch(url + 'costCenters'), // The first SELECT query run on the server
      fetch(url + 'travelPlans') // The seond SELECT query run on the server
    ]).then(function(responses){
      Promise.all(responses.map(function(r){
        return r.json();
      })).then(function(jsons){
        // continue...
      });
    });

But it throws this error:
 { ConnectionError: Connection is closed.
    at D:\home\site\wwwroot\node_modules\mssql\lib\main.js:1569:17
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)
  name: 'ConnectionError',
  message: 'Connection is closed.',
  code: 'ECONNCLOSED' }

Same happening here

@jmartinez-jobsity I do pass the connection object into the Request constructor, as  https://github.com/patriksimek/node-mssql/issues/138#issuecomment-274626433 suggests.
My issue is doing multiple requests using Promise.all as the title of the issue suggests.
I can't do Promise.all with my wrapper function:
function _connectToDatabase(execute) {
  return new Promise((resolve, reject) => {
    connectionManager.getDatabaseConnection()
    .then(connection => (new sql.Request(connection)))
    .then(execute)
    .then(resolve)
    .catch(error => reject(_sqlErrorParser(error)));
  });
}

Weird, cause we are also using Promise.all with a similar approach and it is working

Will you provide code samples?

closing as outdated


Hypergeometric Functions documentation is lacking

The hypergeometric functions scipy.special.hyp1f1(a, b, x), scipy.special.hyp2f1(a, b, x), are very poorly documented here.
Specifically, all the hypxfx functions don't take complex arguments and don't cite the algorithm they are using.

don't cite the algorithm they are using

You might not want to know; the algorithm they're using isn't very good. ;-)

More seriously, for complex values the reference is Zhang, Jin, "Computation of Special Functions". (Code is just the code from their book + some comments. Note that I'm not trying to criticize them; IIRC the book discusses the limitations of their implementations. That discussion should probably be in the documentation.)

(And while we're here, hyp2f0 isn't really an implementation; it's just the asymptotic series. That should be in the documentation too.)

More seriously, for complex values the reference [...]

None of the hypxfx functions seem to take complex arguments... am I missing something?

And while we're here, hyp2f0 isn't really an implementation [...]

That should definitely be in the documentation.

None of the hypxfx functions seem to take complex arguments... am I missing something?

In [5]: hyp1f1(1, 2, 3j)
Out[5]: (0.047040002686622402+0.66333083220014843j)

For complex parameters, uhm, well, not sure if there actually is a good algorithm.

That should definitely be in the documentation.

Pull requests welcome!
For both documentation and actual maths (of which Josh is a resident expert BTW).

For complex parameters, uhm, well, not sure if there actually is a good algorithm

Heck, AFAIK there isn't even a good algorithm for complex arguments. (That only uses double precision.)

For complex parameters, uhm, well, not sure if there actually is a good algorithm.

Huh, for at least some complex parameters, the answer is well defined...
I'm mostly interested in these as a method for calculating the coulomb wavefunctions, which use Kummer's function with a complex a parameter.  I know there are decent algorithms out there for that: https://arxiv.org/abs/physics/0702051v1 , but I haven't looked into one for the hypergeometric functions on their own.

(That only uses double precision.)

Do you know of one that uses extended precision?  Or is it an arbitrary precision algorithm...

Do you know of one that uses extended precision? Or is it an arbitrary precision algorithm...

All the ones I know of are arbitrary precision.

Many of the scipy special functions have better documentation in the C or Fortran source files than in the Python wrapper docstrings, and hyp1f1 is no exception here (see https://github.com/scipy/scipy/blob/master/scipy/special/cephes/hyperg.c for much more than a sentence).
About a year ago I did some work on transplanting the documentation to Python (#5632, #5804), but proceeded in the order the functions are defined in https://docs.scipy.org/doc/scipy/reference/special.html and only made it to ncfdtridfn or so.

Have added the easy-fix label for the documentation enhancement for hopefully someone to continue improving the python-level docs.

I would like to work on it. Documentations of hyp2f1 and hyp1f1 needs to changed so that it includes some explanation also , right?

I think the documentations of all the hyp functions needs to be changed to
give the following information:

What the function is that they are calculating.  A citation to Abramowitz and Stegun or similar would be appreciated.
How they are calculating it: Ideally a citation to a paper describing which method is being used.
For what range of values for the parameters does the function produce valid results?  Real, complex, positive/negative, integer, etc.

Any of the above would be great to have, but I wouldn't consider the
documentation complete unless all of the above is included.
Anyone else have any opinions about what would be good to have here?
![](https://link.nylas.com/open/7jb644ayj7g8reyyd308m4kxa/local-cc42b2f3-0837?
r=cmVwbHkrMDAwMGQwMjQ4NjVmMjVlOTI0NzYzYjczZDQ0YzI3ODQ3MDdlNDQ4MGM5MDc0YzRmOTJj
ZjAwMDAwMDAxMTRiNmFmZGY5MmExNjljZTBjMDI0MWNhQHJlcGx5LmdpdGh1Yi5jb20=)
On Feb 11 2017, at 3:56 am, ashwinpathak20<EMAIL_ADDRESS>wrote:

I would like to work on it. Documentations of hyp2f1 and hyp1f1 needs to
changed so that it includes some explanation also , right?

—
You are receiving this because you authored the thread.
Reply to this email directly, [view it on GitHub](https://github.com/scipy/sci
py/issues/6966#issuecomment-279136605&r=cmVwbHkrMDAwMGQwMjQ4NjVmMjVlOTI0NzYzYj
czZDQ0YzI3ODQ3MDdlNDQ4MGM5MDc0YzRmOTJjZjAwMDAwMDAxMTRiNmFmZGY5MmExNjljZTBjMDI0
MWNhQHJlcGx5LmdpdGh1Yi5jb20=), or [mute the
thread](https://github.com/notifications/unsubscribe-auth/AADQJKrgyoKlxJXhlMKP
JQefDK0wQGO7ks5rbZPfgaJpZM4LmdUk&r=cmVwbHkrMDAwMGQwMjQ4NjVmMjVlOTI0NzYzYjczZDQ
0YzI3ODQ3MDdlNDQ4MGM5MDc0YzRmOTJjZjAwMDAwMDAxMTRiNmFmZGY5MmExNjljZTBjMDI0MWNhQ
HJlcGx5LmdpdGh1Yi5jb20=).![](https://github.com/notifications/beacon/AADQJJD1u
aq8z56F1AXOoFjixbp_72SUks5rbZPfgaJpZM4LmdUk.gif)


change the legacy to slm

PR types
Breaking changes
PR changes
Others
Description
change the legacy to slm

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.wawltor seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Steam Deck Usage Unclear

In your instructions for use on the Steam deck, you say to set the Steam launch options to

WINEDLLOVERRIDES="winmm.dll=n,b" %command%.

Is this in the launch options for the Epic store or is there some way to add the Star Trek Resurgence Executable to the Steam library?

So I should preface this by saying that I haven't actually tried this out on the Deck yet. The instructions are just generic for making sure that Ultimate ASI loader is correctly injected when playing the game on Linux.
I believe you should be able to either add it add a non-steam game and use launch options there. Or you could use something like Heroic Launcher and edit the launch options through that.
When I get a chance tomorrow I'll break out my own Deck and see if I can get the game running. After that I'll post more correct/detailed instructions here.

Just wanted to second this issue. I installed via heroic and then run via steam game mode by having heroic add the game to steam. Game actually runs pretty well stock after increasing swap size and vram. However, I'm not sure how  to specify the winedlloverride. I added it to game options in heroic but it doesn't seem to take when opening from steam game mode (which calls the game via heroic command). At least I don't think it's working. Field of view is disabled in the .ini file but background is still blurry in cutscenes.

Okay, sorry for the delay. Here is a rough guide on how to get it working:

Install Heroic Launcher. You can get this through the discover app store in desktop mode on the Steam Deck.
Login to your Epic account on Heroic.
Install the game.
Find the game in your library and click on the settings icon.
Go down to and expand the "Other" section.
Look for "Environment Variables".
Enter on the left side WINEDLLOVERRIDES.
Enter on the right side winmm.dll=n,b
Click the plus on the right side to add it.
Click on the "WINETRICKS" button.
Click ok to select the default winetricks.
Select "Install a Windows DLL or component" and click OK.
Scroll down and tick "vcrun2022" then click OK.
Once you are back at the winetricks menu click cancel to close it.
Add the game to Steam by clicking the 3 dots menu and choosing "Add to Steam".
Play the game.

Unfortunately you'll only know if it worked by checking in-game. For some reason the log files do not get generated on Linux, perhaps some sort of issue with writing files.

@Lyall this worked. Thank you!


How to throttle upload bandwidth for S3?

I have this sample code to upload the files to S3 bucket. When multiple file uploads are going on, it occupies the whole bandwidth and leaves nothing for the remaining applications. I see there is max_bandwidth parameter in aws-cli. I was wondering how can we throttle the bandwidth here. Appreciate your help. Thanks!
var transferUtility = new TransferUtility(AccessKey, SecretKey, RegionEndpoint.GetBySystemName(Region));
var uploadRequest = new TransferUtilityUploadRequest()
{
    BucketName = bucketName,
    FilePath = path,
    Key = keyName
};

await transferUtility.UploadAsync(uploadRequest);

Environment
SDK Version: AWSSDK.Core 3.7.6
Package Version: AWSSDK.S3 <IP_ADDRESS>

Hi @NJ261,
Good morning.
Thanks for opening guidance question. I do not see parameter such as max_bandwidth supported in the SDK. You may refer StackOverflow post https://stackoverflow.com/questions/20852423/bandwidth-throttling-for-s3-upload-using-aws-sdk for a workaround (not sure if it would work for your need), however, it uses PutObjectRequest instead. The TransferUtilityUploadRequest supports multipart upload and should optimize bandwidth throttling automatically.
Thanks,
Ashish

Okay you mean TransferUtilityUploadRequest automatically splits the upload to multiple parts?

Okay you mean TransferUtilityUploadRequest automatically splits the upload to multiple parts?

@NJ261 It depends on the PartSize property. Default value is 8MB. Refer https://docs.aws.amazon.com/AmazonS3/latest/userguide/mpu-upload-object.html for an example.


Implement a lint script

Implement a a lint script to be run from the root folder with https://turbo.build/
We should be able to run npm run lint or turbo lint to lint all files based on our prettier config.

If this issue is still open, please assign it to me. @brunobuddy

npm packages are giving error while installing @brunobuddy .

Hi @nitesh2920 as of today we did not make it compatible with Windows, only with Mac and Linux.
I will check that soon.

@brunobuddy okay

Installed Husky on PR #232 with auto linting for several packages:

[ ] add-manifest
[ ] core/admin
[x] core/helpers
[x] core/json-schema
[x] core/types
[ ] core/manifest
[ ] js-sdk


Suggested revision

After going through the whole file, I suggest some revises, e.g.,

backup_download_tooltip: "下载应用程序的所有数据，又名主题、歌曲、文件夹"
changes into
backup_download_tooltip: "下载应用程序的所有数据，即主题、歌曲、文件夹"
where "aka"/also known as, could be interpreted as "即“ which indicates detailed explanation/list, rather than "又名" which literally means ”I am going to introduce another name for it“.

delete_songs_and_folders_tooltip: "在这里您可以删除所有主题"
changes into
delete_songs_and_folders_tooltip: "在这里您可以删除所有歌曲和文件夹"
where "songs" is ”歌曲“ while ”主题“ means ”theme“.

Other changes are mostly adding missing periods for complete sentences, where periods (or question marks) already appear in the middle and maybe it is better to end the last sentence with a period. Those may not be a big deal, though.
When to merge is up to the release plan.

Sure! I'll merge this, I was thinking of publishing the new version tomorrow, do you think the translation is good enough to be released for now?

I think it's okay for what I have seen.
I haven't checked some of the "hidden" descriptions, prompts, or messages in the web app. I am not sure if they are correct or appropriate for their context without viewing them "at live".
Further exploration may be conducted, and I will update as soon as there are some findings.

Not sure if you saw but those changes are published in the beta here:
https://beta.sky-music.specy.app/
I'll merge those in the meanwhile

Yeah I am checking this demo, also the https://beta.genshin-music.specy.app/ to see if everything goes well.

Yes, It's a minor detail but would be really annoying to implement, I need to change how the settings work to add it, I don't have time to work on that now. After releasing the new version I'll have to work on adding sustained instruments, which will be hard and take a long time to add, and I'm not sure I can work on it yet