Added the aggregate-add-third-party-mojo plugin

The build passes now (locally) with the template file path set to ${session.executionRootDirectory}/third-party-template.ftl instead of ${project.basedir}/third-party-template.ftl, but this only works when building from the root directory, if I try to build only a submodule, the build fails not finding the .ftl file.
I couldn't find a simple way to make this work, without either modifying all the submodules' pom files (to define a basedir property in each module that references the root path) or by modifying the plugin's code on how it loads the template file.

To me, it would seem like the correct solution would be for the plugin to support loading the ftl from a dependency via the class path.   You could then publish the ftl as an artifact and add it to a dependency to the plugin.
I've seen several plugins add this support in modern implementations, and I would bet the code change would be fairly straightforward and likely to be accepted as a contribution back to the project.
One plugin that recently added this was the com.mycilia license plugin for the file that defines the header.  Example of our use case for this is here, summarized as

                <plugin>
                    <!-- To update the license, do: -->
                    <!--     mvn com.mycila:license-maven-plugin:format -->
                    <groupId>com.mycila</groupId>
                    <artifactId>license-maven-plugin</artifactId>
                    <version>2.11</version>
                    <configuration>
                        <!-- this defines the classpath location of the dependency below -->
                        <header>org/kaazing/community/license/COPYRIGHT</header>
                          ...
                    </configuration>
                    <dependencies>
                        <dependency>
                            <!--
                               this dependency includes common copyright headers for sources
                               specifically org/kaazing/community/license/COPYRIGHT
                             -->
                            <groupId>org.kaazing</groupId>
                            <artifactId>community.license</artifactId>
                            <type>jar</type>
                             <version>develop-SNAPSHOT</version>
                        </dependency>
                    </dependencies>
                </plugin>

I would suggest submitting a patch to the open source project with this and explaining that this adds support for multi-module a distributed projects that share the same parent pom.

I created a PR in the community repository, where I added a module with the .ftl file.
I added the module as a dependecy for the license plugin, with the develop-SNAPSHOT version, but I see that the Travis build fails with the following error:

[ERROR] Failed to execute goal org.codehaus.mojo:license-maven-plugin:1.10:add-third-party (add-third-party) on project gateway: Execution add-third-party of goal org.codehaus.mojo:license-maven-plugin:1.10:add-third-party failed: Plugin org.codehaus.mojo:license-maven-plugin:1.10 or one of its dependencies could not be resolved: Could not find artifact org.kaazing:community.notice:jar:develop-SNAPSHOT in ossrh-snapshots (http://oss.sonatype.org/content/repositories/snapshots)

The Travis build is failing because when the maven-license-plugin is trying to create the Notice.txt from the parent module, it forks all the submodules and looks for their dependencies. Since they depend on each other, errors such as the one below appear.

Could not transfer artifact org.kaazing:gateway.service.turn.rest:jar:develop-SNAPSHOT from/to codehaus-snapshots (https://nexus.codehaus.org/snapshots/): nexus.codehaus.org: Unknown host nexus.codehaus.org

I found the same issue referenced here.
Locally, the build passed because the .m2 repo already contained the Kaazing modules develop-SNAPSHOT versions, but if I delete all the dependencies, the issue also reproduces locally.
I am not sure how to proceed with this.

As a workaround for the issue above, I created a different module with all the gateway submodules as dependencies and configured the maven-license-plugin there, instead of the parent pom.
However, just by adding all the submodules does not generate the same Notice.txt file that would be generated running the aggregate-add-third-party goal from the parent pom. The generated file from the newly created submodule doesn't include optional or provided dependencies. All these should be added manually in the submodule's pom and checked at every build if they are up to date.
This is if the Notice.txt file from the root directory needs to contain all the dependencies that are not included in the distribution. If it is enough to be the same as the one in the distribution, then the license plugin can only be configured in the distribution module.

@dpwspoon According to the table from this link, for the dependencies with provided and test scope, their transitive dependencies will be omitted when running either the dependency:tree or the add-third-party commands from the newly created sub-module.
To workaround this, I manually added these dependencies in the generate.notice pom file and also the dependencies that were declared as optional. This resulted in generating a Notice.txt file similar to the one generated with running aggregate-add-third-party from the parent pom.
The differences between the files are mostly related to duplicate dependencies being either omitted or repeated.
The issue with this approach is that the pom file from this sub-module should always be checked if it is up-to-date. This would probably need to be done by implementing a parser that should go through all the poms from the other sub-modules and check if all the provided, test and optional dependencies are added in this pom.
I have pushed my changes for this in a separate branch.
This is how the generated Notice from the distribution looks like and this is the one generated from the generate.notice sub-module.
Do we want to continue with this approach or is it enough to have the file generate from the distribution module in both distribution/src/main/gateway and the root directory ?

@mgherghe I'm ok with this PR, other than the constant changes to kaazing in the notice.txt.  That needs to be fixed

Created PR with changes to exclude Kaazing dependencies. I will update this PR after that one is merged.

I implemented the feedback changes.
However, the Travis build is failing at the enforcer rules when checking if the Notice.txt file is up-to-date.
This is because the file generated on Travis does not include the shaded dependencies from the mina.netty module.
Locally, this happens when building only the distribution module, but when building the whole project, the Notice.txt file is generated with the shaded dependencies.
I am not clear on why this is happening and I will continue with the investigation.

The different behaviour between the two builds (the local one and the one from Travis) is because of different versions of Maven.
When runing the maven-license-plugin, versions of maven <3.3.x generate the Notice.txt file without the shaded dependencies from the mina.netty module.
However, this only happens from the package phase and higher. The lower phases have the same behaviour.
Also, when running the build with maven 3.2.5, in the target folder from the mina.netty module there is a mina.netty-develop-SNAPSHOT-shaded.jar generated, that isn't generated with newer versions of maven.
I will continue with the investigation tomorrow.
As a fix for this issue, maybe the enforcer rules that check if the Notice files are the same could be ignored for a maven version < 3.3.1 or change the maven version from the Travis build (currently, it is 3.1.1)

We should specify the plugin version here: https://github.com/kaazing/community/blob/e6a890fa8fe322028d4b12e799933a7fefbd1fe3/community.main/pom.xml

That is the license plugin used to check the license headers.
I am using license-maven-plugin from org.codehaus.mojo, and I am specifying the version here.
However, this seems to behave differently depending on the system's default maven version.

If the maven shade plugin does not generate a dependency-reduced-pom.xml file, then building the project with any version of maven has the same behavior in generating the Notice.txt file.
Setting the createDependencyReducedPom to false fixes the Travis build failure. This is consistent with how the maven shade plugin is configured in other projects

Thanks @mgherghe, please remove all
                <groupId>org.kaazing</groupId>
                <artifactId>license-maven-plugin</artifactId>

as this is effectively replacing that logic

The notice.txt is missing SNMP4j.  This is perhaps because we had to package it up in maven ourselves so it falls under the kaazing namespace: https://github.com/kaazing/snmp4j.  Please figure out how to include those dependencies in the notice.txt

I believe antlr4 and treelayout are only pulled in by k3po.lang.  And k3po.lang should be able to be at scope test for all modules, thereby removing them
Please try to change all instances of
        <dependency>
            <groupId>org.kaazing</groupId>
            <artifactId>k3po.lang</artifactId>
            <version>${k3po.version}</version>
        </dependency>

to
        <dependency>
            <groupId>org.kaazing</groupId>
            <artifactId>k3po.lang</artifactId>
            <version>${k3po.version}</version>
            <scope>test</scope>
        </dependency>

Regarding the SNMP4j dependency, I found them on the maven repository, here is the snmp4j-agent and here the snmp4j. The build passed locally with the last commit, in which I changed the snmp dependencies from org.kaazing to org.snmp.
However, the Travis build is failing, since it is looking for the dependencies on http://repo.maven.apache.org/maven2, where the versions currently used are not uploaded. (http://repo.maven.apache.org/maven2/org/snmp4j/)

@dpwspoon I updated the PR after synchronizing with the changes for #1036


Add universal widget state

Things like hovered, focused, selected, enabled, and disabled should be universal properties that can be used for styling.

Also, all of those should be signals as well.

Actually, it might make more sense to build on the already existing flags.

done in new v2


bug/DNN-7765 - Added logic to update the selected option onclick of a…

…dd & edit.

Update: Found more bugs with this, will update with new PR at some point.


PENDING action is gone from sagas

Hello. Please help. I faced with problem when i move my project to module with redux-dynamic-modules and redux-dynamic-modules-saga. Actions from sagas starts to work differently. Now actions not including PENDING prefix. Maybe someone came across this?
redux-promise-middleware - stopped working yet I don't know why

Please provide a codesandbox demo

Please provide a codesandbox demo

https://github.com/microsoft/redux-dynamic-modules/pull/172

It's not a demo 🙃

It's not a demo 🙃

Fix problem it's the best demo. ;) In fact, it was just that external middleware such as redux-promise and etc. were not included in the extension for sagas.

You can pass middlewares for modules, isn't it enough?

You can pass middlewares for modules, isn't it enough?

nope, b/c inside to saga extension they are not passed


Duplicate headers for overloaded methods

URL to the relevant documentation
https://docs.quantum-computing.ibm.com/api/qiskit/qiskit.circuit.QuantumCircuit
Please describe the UI problem.
For example, look at the right sidebar:

Each Example and Notes section should have the most indentation, but they have the least. Also, there are duplicates like if_test that show up with the same indentation.

@frankharkins fixed the bad Example headers in https://github.com/Qiskit/documentation/pull/683. But the issue with duplicate headers remains. This is specifically when methods are overloaded, and probably also when functions or exceptions are overloaded; like they have multiple signatures. https://docs.quantum.ibm.com/api/qiskit/qiskit.circuit.QuantumCircuit#if_test is a good example
I renamed the issue title to focus on that problem.


Added example to empty an AdvancedSettings value

Docs Build status updates of commit b8a5dcf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Set-Label.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Set-LabelPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


chore: allow manual dependency workflow trigger

:tada: This PR is included in version 1.1.5 :tada:
The release is available on:

GitHub release
v1.1.5

Your semantic-release bot :package::rocket:


2.20 did not get published to Maven central repository

Description
Version 2.20 was released four days days ago, and documentation gives Maven coordinates for version 2.20. However the newest version available on Maven central repository is still 2.19.
Configuration
Version: 2.20
Reproduction
Check available version for log4j on Maven Central Repository.

@xzel23,
Releasing an Apache project is a long process; version 2.20.0 hasn't been officially released yet:

the voting procedure began on February 18th UTC: https://lists.apache.org/thread/l3ftyl9r2cfsp49dksdvddv12pfhtskt
on February 21st UTC the vote passed: https://lists.apache.org/thread/xw7k9prf22vx5dsjk0xtdnsf1y3hdsz5

The release process ends with an announcement mail on the<EMAIL_ADDRESS>list.

OK, thank you. So the website and downloads page are a bit ahead of events. When you just open the project page right below the logo the text "Last Published: 2023-02-17|  Version: 2.20.0" is displayed and the downloads also already show the 2.20 version. I assumed the "Last Published" meant released.

@xzel23,
The dates are generated together with the static website. I guess the same is true for those on Maven Central (you can find them on Sonatype), but I don't know how Sonatype Nexus Manager deals with dates.
If you have an idea how to modify our Maven config to use dates 72 hours in the future, feel free to reopen this issue.

Normally, Maven Central is updated within a few hours. dist.apache.org normally takes many hours to sync with all its mirrors. Our policy is to not publish the release announcement for 24 hours after the artifacts are published due to these delays.
Note that the release build ran on Feb 17, but the release process requires 72 hours (3 days) at a minimum for PMC members to approve the release. So generally, the artifacts are available 3.5 to 4 days after the release vote email goes out.


Users can't delete default allocations on closed/lost opportunities.

Tracking W-017010

Tracking W-017012

Tracking W-017013

Customer reporting this in the Hub.

Salesforce has determined that this issue will not be explored further.


Test OSS CI

Summary: Run OSS CI.
Differential Revision: D51940660

@mbasmanova Sure, no problem. Thanks:)


Kalaiselvi email

Ok.
On Fri, May 28, 2021 at 2:53 PM gpl-git @.***> wrote:

Closed #204 https://github.com/gpl-git/assessment-control/pull/204.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/gpl-git/assessment-control/pull/204#event-4814958821,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUF3OOOORUXGA5NM2XGJGM3TQAGFNANCNFSM45XHFWRQ
.

I will try to use different types xpath .
Thank you!
On Fri, May 28, 2021 at 3:05 PM kalaiselvi @.***> wrote:

Ok.
On Fri, May 28, 2021 at 2:53 PM gpl-git @.***> wrote:

Closed #204 https://github.com/gpl-git/assessment-control/pull/204.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/gpl-git/assessment-control/pull/204#event-4814958821,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUF3OOOORUXGA5NM2XGJGM3TQAGFNANCNFSM45XHFWRQ
.


bulk-extractor: misc fixup, add support for version 1

Description of changes

This pr renames the attribute name of the bulk_extractor package to bulk-extractor as a side effect of renaming the directory, due to the file organisation guidelines.
It also adds support for extra features, by linking against a bunch of extra optional libraries.
In addition, I've added v1.6.0, since it's still the only version of the program that still supports BEViewer. I've added you to the maintainerlist for v1 @D3vil0p3r, are you okay with this?
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Drafting until I figure out how to best deal with the by-name check


Heroku Support

Can You Port This To A Supported Minimal Language that is support by heroku ? like python or node js
only need programming mode, so definitely can run on cloud 24*7
i already donated you many times, if this is possible  let me know i will send few $$ for trouble

Nope, sorry. You also probably shouldn't be running a gambling bot 24/7, it'll eat up all of your money.
The bot is being rewritten in .net core, so it should be able to run on linux soon, and there will be a console version of it. won't be able to run on heroku, but heroku isn't the only cloud platform out there.

understand i was .NET programmer for years, i understand !
anyways i be working on node js version of your bot !
thanks for reply


App name [App serial]

App summary

App name: ?
App serial: ?
App version: ?

Vita3K summary

Version: v?
Build number: ?
Commit hash: https://github.com/vita3k/vita3k/commit/[commit]
CPU backend:
GPU backend:

Test environment summary

Tested by: ?
OS: Windows/macOS/Linux Distro, Kernel Version?
CPU: AMD/Intel?
GPU: AMD/NVIDIA/Intel?
RAM: ? GB

Issues

Screenshots

Log

Recommended labels

A?
B?
C?

7

how can i download mortal kombat for vita 3k pleas ????


[Gssoc23] C project

Describe the project you want to add with tech stack
this C project is a matrix calculator

Expected behavior
this menu-driven project is for performing basic matrix operations

Screenshots (optional)

Additional context (optional )

@TusharKesarwani @MohitGupta121 Kindly assign this issue.


Share results with timeline viewer

Thought:

Submit results from lighthouse into gist/gdrive/whatever
Share it with timeline viewer

I dunno if it has to be a part of pwmetrics, maybe lighthouse
@paulirish thoughts?

Yup love this general idea. :)
Timelines are like 5-100mb so i dont think gist will work. but gdrive should be fine.

👍
I hope we can reuse outh stuff which we already have :)

Question, how would this feature work for multiple runs?

Just store data to gdrive and open timeline viewer for each run.


UI: OpenStack cloud validation no longer changes state of credentials

There is no way I can re-validate the credentials of cloud now (tested on OpenStack). Nor by validate button nor by refresh
Before, when the credentials were unreachable/error state, the state changed when I did 'edit provider' and 'validate'. That might got broken moving into the angular form? It works on OpenStack Infra which is using the old form.

@dclarizio @himdel any ideas about this?

@AparnaKarve seems like this was caused by your patch here https://github.com/ManageIQ/manageiq/blob/e4a1f3da9035c96dae670cc9cb2a6c81ab61a391/app/controllers/ems_cloud_controller.rb#L78
now there is hardcoded false, so validate doesn't update status. Is this bug or credentials are update eleshewhere?


feat(cache): allow async getKey option in cache utils

🔗 Linked issue

#875
❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[x] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Example:
export default defineCachedEventHandler(async () => {
  await new Promise((resolve) => setTimeout(resolve, 1000));
  console.log("event called")
  return `Response generated at ${new Date().toISOString()} (took 1 second)`;
}, {
  maxAge: 600,
  getKey: async (e) => {
    await new Promise((resolve) => setTimeout(resolve, 500));
    console.log("getKey called")
    return e.node.req.url
  }
});

usecase further explained in #875
I am not sure where this could be mentioned in the docs, should be obvious by the typing that promises/async are allowed?
📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Thanks!

thank you for the awesome project and speed reviews! 🚀


Is there a way to obtain the current zoom level?

I need to base a few styles on the current zoom level, but I can't figure out if that's exposed.

you can get the xExtents by this.chartCanvasRef.getDataInfo().xScale.domain()


Is there a way I can stop dependabot from spamming my repository?

Every released PR in sweetalert2 repository looks like this:

Example: https://github.com/sweetalert2/sweetalert2/pull/2169
It's annoying and counterproductive. and I'd like to stop it. Is there a way I can prevent relating PRs in my repository from closed dependabot PRs?

@limonte sorry about this! This issue has been fixed but quite a few PRs came through before it landed.

@limonte sorry about this! This issue has been fixed but quite a few PRs came through before it landed.

Thank you @feelepxyz!


Implementation Plan: Bulk moderation actions

Fixes

Fixes #1967 by @sarayourfriend
Description

I've chosen @obulat and @sarayourfriend as reviewers. In particular I'd like to call out to @sarayourfriend (as I do in the document itself) that this plan build on and makes some slight change to the work in #3494 that should be carefully reviewed.
This discussion is following the Openverse decision-making process. Information about this process can be found on the Openverse documentation site.
Requested reviewers or participants will be following this process. If you are being asked to give input on a specific detail, you do not need to familiarise yourself with the process and follow it.
Current round
This discussion is currently in the Decision round.
The deadline for review of this round is 19 February 2024.
Checklist

[ ] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[ ] My pull request targets the default branch of the repository (main) or a parent feature branch.
[ ] My commit messages follow best practices.
[ ] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend I'm very happy to extend the deadline for review given your schedule, please just let me know! 🙂

5 Feb should be fine but I will let you know by Thursday if I am going to be late on this.

whether to https://github.com/WordPress/openverse/pull/3719#discussion_r1484700003 to only remove records from Elasticsearch, to give a 'safety window' for reindexing

To clarify my answer from the comment thread, my vote is a strong "no", it is not worth making a change for this. My reasons are in the thread.

Re-requesting reviews as this has entered the Decision Round :)

@obulat are you able to review the implementation plan soon? It would be great to get this approved soon (with any changes needed, of course, if you have blockers to share) so that we can update the issues from the previous implementation plan with the new ModerationDecision model and other modifications to the existing plan.

I've just realized (prompted by @dhruvkb 's comment above) that I may need to clarify the specifics of the implementation for the many to many relationship. I likely do not have time to do so today so I'm going to draft this briefly.

@obulat Can you confirm you've seen the request to review this? Will you confirm if you will approve with the change Staci is making or if you'll require other changes?

I was briefly concerned that there would be an issue with using the ManyToManyField as designed, due to the requirement that the record ids be non-constrained. TL;DR I had forgotten that this is possible using the db_constrained argument as we already do elsewhere in the code (for example, in the implementation of the MediaReports). I thought it was worth adding a specific mention of that argument to the IP and will also do so in the issues when they are updated/created. This should not require more work and I am undrafting now, apologies -- better to be safe 😅

I've created issues under this milestone, and updated the relevant issue from the related IP.


Overlapping content on the Pull Requests and How to review code pages

https://gds-way.cloudapps.digital/standards/pull-requests.html#reviewing-a-request
and
https://gds-way.cloudapps.digital/manuals/code-review-guidelines.html
We need to consolidate or at least cross-reference these pages

After the merging of PR #400, the 'How to review code page' is no longer linked to. This is sad as the content is great. As mentioned above, both pages need a quick review and merging or cross linking


Fix a few typos in documentation

"functionlity" → "functionality"
"transation" → "transaction"

Coverage remained the same at 95.8% when pulling 2eb44098bce48045e81f4512d04b316d9fafa9f3 on squarejaw:patch-2 into e1c12069717b890c009fd4e2193bfc98d464c124 on Vincit:master.

Coverage remained the same at 95.8% when pulling 2eb44098bce48045e81f4512d04b316d9fafa9f3 on squarejaw:patch-2 into e1c12069717b890c009fd4e2193bfc98d464c124 on Vincit:master.

Thanks!


merge package from arlac77/npm-package-template-esm-only

package.json

chore(package<EMAIL_ADDRESS>chore(scripts): cover@#overwrite c8 --temp-directory build/coverage ava && c8 report -r lcov --temp-directory build/coverage
chore(scripts): posttest@markdown-doctest

Codecov Report

Merging #481 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #481   +/-   ##
=======================================
  Coverage   74.36%   74.36%
=======================================
  Files           2        2
  Lines         476      476
=======================================
  Hits          354      354
  Misses        122      122

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcc2ca9...8e71ec3. Read the comment docs.

Coverage remained the same at 71.972% when pulling 8e71ec387c7a50bf10663b2918c7be1f7f6655fb on template-sync-1 into fcc2ca905c7c70b2be64a6e55246bc0580dfb4ce on master.

:tada: This PR is included in version 3.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


remove slonik, insert postgres.js

I'm surprised it's not a larger diff! It's nice that there are a few similarities between postgres.js and Slonik.

I just followed the repro steps in #482 in order to see whether #604 fixed that issue. However, I forgot to checkout #604 first, so I ended up running the repro steps against this PR. 😅 The result was interesting though, so I thought I'd note what I saw.
In good news, I'm no longer observing a database connection leak. 🎉 After I followed the repro steps, the pg_stat_activity count did not increase.
I ran the repro steps several times. Every time that I checked the number of successful requests, 8/10 requests were successful. That's interesting to me, because with Slonik today, it's 9/10. From a quick look, it seems like postgres.js defaults to allowing up to 10 database connections, the same as Slonik, so that doesn't seem to explain the difference.
I queried pg_stat_activity during the repro steps, running select count(*) from pg_stat_activity where state <> 'idle'. From what I can tell, the count spikes to 9, quickly decreases to 8, then continues to decrease. I'm surprised not to see a count of more like 10 or 11, which is what I'd expect if postgres.js were using 10 connections.
The requests that don't succeed return with a variety of errors. Usually it's a 500 or a 504, but I've also seen some 502s. When it's a 500, Backend is returning an error response whose message property starts with "Completely unhandled exception". All the 504s and 502s I checked were HTML responses from nginx.
The specific error details also varied. For 500s, those details showed up in the error response. In other cases, they showed up in Sentry. The two most common errors were:

portal "" does not exist (Sentry [1][2][3])
RangeError: The value of "offset" is out of range. … (Sentry [1][2])

I also saw these 1 or 2 times:

TypeError: query.cursorFn is not a function (Sentry)
TypeError: constructors[k] is not a function (Sentry)
SyntaxError: Unexpected number in JSON at position 4 (Sentry)

(5) happened when I tried the repro steps with 20 concurrent requests instead of 10. I'm pretty sure that's true of (3) as well, and that might also be true of (4). Interestingly, when I tried 20 requests, there was also one time when I received a 404.1 Problem response ("Could not find the resource you were looking for."). There were also times when curl exited with an exit code of 6, displaying the message "Could not resolve host: test.getodk.cloud". That said, sending 20 concurrent requests resulted in more successful responses than sending 10 requests. (The count of successful requests seemed to vary. I saw 10 once.)
I have a theory about when a 500 is returned vs. a 504. Errors (1) and (2) above were thrown for stream, maybeOne, and oneFirst. I think I'm seeing a pattern that when maybeOne and oneFirst throw the error, it's a 500, while when it's stream, it's a 504.

@lognaturel also noted on Slack:

For what it's worth, I was disrupted at least once right when Sentry got that portal error. I was attempting to publish a form draft in one tab and had another form’s submission page open in another. The publish request seemed to hang. I got a spinner on the modal. I got impatient and killed the window. When I came back the publish had succeeded.

I think this would be expected if the publish request was sent while all available database connections were in use by the stream requests. With Slonik, a connection attempt times out in 5 seconds, so you wouldn't expect the request to hang, but with postgres.js, it looks like the timeout is 30 seconds.

postgres.js branch that we could try to see if it fixes the issues we were seeing: https://github.com/porsager/postgres/tree/concurrent-cursors

no, it doesn’t, don’t bother, it won’t. this is shared as a possible starting point for us implementing this ourselves. On Aug 15, 2023, at 16:04, Matthew White @.***> wrote:
postgres.js branch that we could try to see if it fixes the issues we were seeing: https://github.com/porsager/postgres/tree/concurrent-cursors
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Closing in favor of tracking issue at https://github.com/getodk/central/issues/614


Add support for setting job constraints

On DAS-5, to get a node with a GPU, you need to set a constraint when submitting the job, as in sbatch -C gpunode. It doesn't look like that is supported by Xenon 1 at least. It would be nice if constraints support could be added.
Note that this is different from the queue name (partition in slurm terms), which is selected using sbatch -p name, and can be set through Xenon via JobDescription.setQueueName().
It seems that qsub -hard -l resource=value is a reasonable equivalent for SGE, and that qsub -l resource=value will get you there on Torque. I'd suggest just letting the Xenon user specify the string to add after -C or -l, rather than some complicated key-value mechanism.
Edit: For 2.1 please, I'd rather have a 2.0 release first.

We should use the JobDescription.addJobOption()
For example:
job.addJobOption("-C", "gpunode");

should result in a sbatch script with
#SBATCH -C gpunode

At the moment no job options are not passed to the sbatch command.

The thought had crossed my mind that we'd keep adding things like this, but I hadn't thought of addJobOption(). Good idea!

Has the jobOption already been included in Xenon? I have run into the same issue while trying to test a simulation in DAS5.

Nope, not yet

Will include this in the next release

In issue #556 it was suggested that the jobOptions map is not suitable for passing arguments to Slurm because it has to have unique keys. Slurm allows passing of multiple constraints in a -C [TitanX&intel]|amd way. It's not nice limiting the use of jobOptions like that, but it would be a start. Eventually I guess there should be an additional member of JobDescription for command-line arguments to the scheduler.

We decided on JobDescription.setSchedulerArguments, JobDescription.addSchedulerArgument and JobDescription.getSchedulerArguments which allows you to add any number of scheduler specific options that will be inserted into the scripts by the adaptors.

schedulerArguments has been implemented in Xenon v2.6.0

Fixed


gitlab: 14.4.2 -> 14.5.0

Motivation for this change
https://about.gitlab.com/releases/2021/11/22/gitlab-14-5-released/
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

The nixos test failed with exit code 1.
mak@build-worker-01:~/nixpkgs $ nix build -f nixos/tests/gitlab.nix
error: builder for '/nix/store/51gfinfcc61k8qg561q91p7zk2iv9cz9-gitaly-14.5.0.drv' failed with exit code 1;
       last 10 log lines:
       > gitlab.com/gitlab-org/gitaly/v14/internal/blackbox
       > gitlab.com/gitlab-org/gitaly/v14/cmd/gitaly-blackbox
       > Building subPackage ./cmd/gitaly-debug
       > gitlab.com/gitlab-org/gitaly/v14/cmd/gitaly-debug
       > Building subPackage ./cmd/gitaly-git2go
       > github.com/libgit2/git2go/v32
       > # github.com/libgit2/git2go/v32
       > vendor/github.com/libgit2/git2go/v32/Build_system_static.go:12:3: error: #error "Invalid libgit2 version; this git2go supports libgit2 between v1.2.0 and v1.2.0"
       >    12 | # error "Invalid libgit2 version; this git2go supports libgit2 between v1.2.0 and v1.2.0"
       >       |   ^~~~~
       For full logs, run 'nix log /nix/store/51gfinfcc61k8qg561q91p7zk2iv9cz9-gitaly-14.5.0.drv'.
error: 1 dependencies of derivation '/nix/store/7kk5y5bn8xcgd9n1qnzx6zbh9l6k8f4d-gitlab-config.drv' failed to build
error: 1 dependencies of derivation '/nix/store/q4y948fhv8mw2bzwf0gckddhgv89r9p6-unit-gitaly.service.drv' failed to build
error: 1 dependencies of derivation '/nix/store/b88crm9683vb8sqfbqhw3l2wrlgprfn0-system-units.drv' failed to build
error: 1 dependencies of derivation '/nix/store/m7aknchyafbq8jkrm3f0y0y2v7yjilwd-etc.drv' failed to build
error: 1 dependencies of derivation '/nix/store/b47f9wn692mdfakyh2937w6bpgpwp00j-nixos-system-gitlab-22.05pre-git.drv' failed to build
error: 1 dependencies of derivation '/nix/store/df70kfjjg256ysql5ll0b67yk086dh2d-nixos-vm.drv' failed to build
error: 1 dependencies of derivation '/nix/store/cac8cig3qf1m8fqq8dvszmb8q03xqcib-nixos-test-driver-gitlab.drv' failed to build
error: 1 dependencies of derivation '/nix/store/0r0pzwidb05l6w57j6sb5lfjjz7kjvij-vm-test-run-gitlab.drv' failed to build

Converting to draft. Contributions welcome! :)

Thanks @yu-re-ka, re-running the NixOS tests...

Result of nixpkgs-review pr 147848 run on x86_64-linux 1

5 packages built:

gitaly
gitlab
gitlab-ee
gitlab-shell
gitlab-workhorse

The tests do pass.

Oh, I was on a different branch, nevermind. But anyway, now I ran into this,
mak@build-worker-01:~/nixpkgs $ nix-build nixos/tests/gitlab.nix
[--CUT--]
copying path '/nix/store/fkx7kgqi9yqjig6nmyiqja7fpf7n8jld-etc' to 'local'...
copying path '/nix/store/a1gcwcbb9dc2hqsd3biix0ha7m71qsdp-nixos-system-gitlab-22.05pre-git' to 'local'...
installation finished!
error: experimental Nix feature 'nix-command' is disabled; use '--extra-experimental-features nix-command' to override
error: builder for '/nix/store/bwas640rcbk505mn8chbzxsi66f33k99-nixos-disk-image.drv' failed with exit code 1;
       last 10 log lines:
       > copying path '/nix/store/0a17862zc1d89b2ciplcdr0a6m9gyj45-unit-serial-getty-.service' to 'local'...
       > copying path '/nix/store/ya5m1zj0gagab1462nbd7cl99wzd0nkb-unit-nixos-activation.service' to 'local'...
       > copying path '/nix/store/195wahpfbl1ixkpcpdiir8a4xnxx7lgq-unit-systemd-fsck-.service' to 'local'...
       > copying path '/nix/store/pj2k4yvzhqjgs44j3lfy944vqk085ks3-unit-systemd-udevd.service' to 'local'...
       > copying path '/nix/store/7ll79d9wvkcafvjcwqyp6gs8gxx1x9sm-user-units' to 'local'...
       > copying path '/nix/store/0vxkygivwrdfvkxv532lpgfr52hm6axp-system-units' to 'local'...
       > copying path '/nix/store/fkx7kgqi9yqjig6nmyiqja7fpf7n8jld-etc' to 'local'...
       > copying path '/nix/store/a1gcwcbb9dc2hqsd3biix0ha7m71qsdp-nixos-system-gitlab-22.05pre-git' to 'local'...
       > installation finished!
       > error: experimental Nix feature 'nix-command' is disabled; use '--extra-experimental-features nix-command' to override
       For full logs, run 'nix log /nix/store/bwas640rcbk505mn8chbzxsi66f33k99-nixos-disk-image.drv'.
error: 1 dependencies of derivation '/nix/store/j5kyva5y3pvbnh2ngc01mvjzlhrf6vxx-run-nixos-vm.drv' failed to build
error: 1 dependencies of derivation '/nix/store/2mssxfdcf806sd66000w6162anlhh8ky-nixos-vm.drv' failed to build
error: 1 dependencies of derivation '/nix/store/0pvprcx64p5fshwbmaajhpimlsbajdi8-nixos-test-driver-gitlab.drv' failed to build
error: 1 dependencies of derivation '/nix/store/wjvfv891lx76qn2qxzwazz356ynpz2na-vm-test-run-gitlab.drv' failed to build

which is a bit weird since I am using nix-build to build the test. I recently updated my machine to the release-21.11 channel which includes Nix 2.4 per default. I do have enabled
nix.extraOptions = ''
    experimental-features = nix-command
  '';

in my system configuration, though.

@yayayayaka How long took the "building offline (buildPhase)" which downloads lots of yarn packages and then is just silent?

@yayayayaka How long took the "building offline (buildPhase)" which downloads lots of yarn packages and then is just silent?

I did not measure the exact time but it did not take longer than usual.

@yayayayaka That's because of the update to Nix 2.4. I have a fix in #147506 (https://github.com/NixOS/nixpkgs/pull/147506/commits/252fcd3eab4bcbc906542f14075794749951fa77), but maybe I should just split that out into its own PR.

The issue can be resolved with
diff --git a/nixos/lib/make-disk-image.nix b/nixos/lib/make-disk-image.nix
index 0a4a71fadc4..15302ae8241 100644
--- a/nixos/lib/make-disk-image.nix
+++ b/nixos/lib/make-disk-image.nix
@@ -281,7 +281,7 @@ let format' = format; in let
       --substituters ""

     ${optionalString (additionalPaths' != []) ''
-      nix copy --to $root --no-check-sigs ${concatStringsSep " " additionalPaths'}
+      nix --extra-experimental-features nix-command copy --to $root --no-check-sigs ${concatStringsSep " " additionalPaths'}
     ''}

     diskImage=nixos.raw

This is worth opening a bug report.

but maybe I should just split that out into its own PR.

Yeah, that would be great.

The NixOS tests now do pass for real. :)

Opened  #147933 to solve the test issue :)

Didn't find any issues in manual testing. Thanks!


Is incremental sync supported or not?

Just wanted to check if elasticsearch-dump supports incremental sync or not?
Because my use-case is I have a production ES cluster running which has around 1 TB of data.
I want to replicate this cluster.
The first time it will take a lot of time to sync but later on, if I try to sync will that sync be incremental or will it take the same amount of time it took for the first sync?

Your question ? no
does ES supports incremental syncs ? no.
Fairly simple to achieve this by adding a timestamp to your data-set on upsert, but if you don't have it then, no


smoothing out grammar

There is always more to improve - I have allowed edits by maintainers :)

Thanks for the PR!


The pod_push action is failing with "Could not find a ios simulator" error

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description

The pod_push action began failing with a "Could not find a ios simulator error" after updating to Xcode 10.2.1 and the latest Fastlane. It fails with the same error from both a Fastfile and command line, and was working prior to the upgrades. I confirmed the iOS simulators are installed and visible to Xcode, per the error. Also, running the pod push command directly outside of Fastlane works as expected.
Command executed

Complete output when running fastlane, including the stack trace and command used

 Allogy-Mac-Build-Server:com.allogy.Rucksack ios$ fastlane run pod_push path:Rucksack.podspec repo:allogy
[22:01:45]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
[22:01:46]: ----------------------
[22:01:46]: --- Step: pod_push ---
[22:01:46]: ----------------------
[22:01:46]: $ pod repo push allogy 'Rucksack.podspec'
[22:01:48]: ▸ Validating spec
[22:02:06]: ▸  -> Rucksack (0.8.3)
[22:02:06]: ▸ - ERROR | [iOS] unknown: Encountered an unknown error (Could not find a `ios` simulator (valid values: com.apple.coresimulator.simruntime.ios-12-2, com.apple.coresimulator.simruntime.tvos-12-2, com.apple.coresimulator.simruntime.watchos-5-2). Ensure that Xcode -> Window -> Devices has at least one `ios` simulator listed or otherwise add one.) during validation.
[22:02:06]: ▸ [!] The `Rucksack.podspec` specification does not validate.
Looking for related GitHub issues on fastlane/fastlane...
/Users/ios/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.125.2/fastlane_core/lib/fastlane_core/ui/interface.rb:153:in `shell_error!': [!] Exit status of command 'pod repo push allogy 'Rucksack.podspec'' was 1 instead of 0. (FastlaneCore::Interface::FastlaneShellError)
Validating spec
-> Rucksack (0.8.3)
- ERROR | [iOS] unknown: Encountered an unknown error (Could not find a ios simulator (valid values: com.apple.coresimulator.simruntime.ios-12-2, com.apple.coresimulator.simruntime.tvos-12-2, com.apple.coresimulator.simruntime.watchos-5-2). Ensure that Xcode -> Window -> Devices has at least one ios simulator listed or otherwise add one.) during validation.
[!] The Rucksack.podspec specification does not validate.
from /Users/ios/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.125.2/fastlane_core/lib/fastlane_core/ui/ui.rb:17:in `method_missing'
from /Users/ios/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.125.2/fastlane/lib/fastlane/helper/sh_helper.rb:80:in `sh_control_output'
from /Users/ios/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.125.2/fastlane/lib/fastlane/helper/sh_helper.rb:12:in `sh'
from /Users/ios/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.125.2/fastlane/lib/fastlane/actions/pod_push.rb:50:in `run'
from /Users/ios/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.125.2/fastlane/lib/fastlane/runner.rb:256:in `block (2 levels) in execute_action'
from /Users/ios/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.125.2/fastlane/lib/fastlane/actions/actions_helper.rb:50:in `execute_action'
from /Users/ios/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.125.2/fastlane/lib/fastlane/runner.rb:235:in `block in execute_action'
from /Users/ios/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.125.2/fastlane/lib/fastlane/runner.rb:227:in `chdir'
from /Users/ios/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.125.2/fastlane/lib/fastlane/runner.rb:227:in `execute_action'
from /Users/ios/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.125.2/fastlane/lib/fastlane/one_off.rb:42:in `run'
from /Users/ios/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.125.2/fastlane/lib/fastlane/one_off.rb:22:in `execute'
from /Users/ios/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.125.2/fastlane/lib/fastlane/commands_generator.rb:221:in `block (2 levels) in run'
from /Users/ios/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:178:in `call'
from /Users/ios/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:178:in `call'
from /Users/ios/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:153:in `run'
from /Users/ios/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/commander-fastlane-4.4.6/lib/commander/runner.rb:476:in `run_active_command'
from /Users/ios/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.125.2/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:76:in `run!'
from /Users/ios/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/commander-fastlane-4.4.6/lib/commander/delegates.rb:15:in `run!'
from /Users/ios/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.125.2/fastlane/lib/fastlane/commands_generator.rb:333:in `run'
from /Users/ios/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.125.2/fastlane/lib/fastlane/commands_generator.rb:41:in `start'
from /Users/ios/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.125.2/fastlane/lib/fastlane/cli_tools_distributor.rb:119:in `take_off'
from /Users/ios/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/fastlane-2.125.2/bin/fastlane:23:in `<top (required)>'
from /Users/ios/.fastlane/bin/bundle/bin/fastlane:22:in `load'
from /Users/ios/.fastlane/bin/bundle/bin/fastlane:22:in `<main>'</pre>

Environment

 ✅ fastlane environment ✅
Stack

Key
Value

OS
10.14.5

Ruby
2.2.4

Bundler?
false

Git
git version 2.20.1 (Apple Git-117)

Installation Source
~/.fastlane/bin/bundle/bin/fastlane

Host
Mac OS X 10.14.5 (18F132)

Ruby Lib Dir
~/.fastlane/bin/bundle/lib

OpenSSL Version
OpenSSL 1.0.2g  1 Mar 2016

Is contained
false

Is homebrew
true

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
10.2.1

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL
en_US.UTF-8
✅

LANGUAGE
en_US.UTF-8
✅

fastlane files:
`./fastlane/Fastfile`
# Customise this file, documentation can be found here:
# https://github.com/fastlane/fastlane/tree/master/fastlane/docs
# All available actions: https://docs.fastlane.tools/actions
# can also be listed using the `fastlane actions` command

# Change the syntax highlighting to Ruby
# All lines starting with a # are ignored when running `fastlane`

# If you want to automatically update fastlane if a new version is available:
# update_fastlane

# This is the minimum version number required.
# Update this, if you use features of a newer version
fastlane_version "2.45.0"

default_platform :ios

platform :ios do

  before_all do

    ENV["SLACK_URL"] = REDACTED

    setup_jenkins

  end

  desc "Runs all the tests"

  lane :test do

    scan

  end

  desc "Build the framework and update/push podspec with a _patch_ version level."

  lane :podspec_patch do

    # Build normally first to ensure it succeeds before incrementing the version.
    gym(
	scheme: "Rucksack",
        skip_package_ipa: true
    )

    increment_version_number
    increment_build_number
    commit_version_bump(
	force: true
    )
    push_to_git_remote

    version_number = get_version_number
    build_number = get_build_number

    add_git_tag(
	tag: "#{version_number}"
    )
    push_git_tags

    version_bump_podspec(
	path: "Rucksack.podspec",
	version_number: "#{version_number}"
    )

    pod_push(
       path: "Rucksack.podspec",
       repo: "allogy",
       allow_warnings: true
    )

    sh "echo APP_VERSION_NUMBER=#{version_number} > version.properties"

  end

  desc "Build the framework and update/push podspec with a _minor_ version level."

  lane :podspec_minor do

    # Build normally first to ensure it succeeds before incrementing the version.
    gym(
	scheme: "Rucksack",
        skip_package_ipa: true
    )

    increment_version_number(
	bump_type: 'minor'
    )
    increment_build_number
    commit_version_bump(
	force: true
    )
    push_to_git_remote

    version_number = get_version_number
    build_number = get_build_number

    add_git_tag(
	tag: "#{version_number}"
    )
    push_git_tags

    version_bump_podspec(
	path: "Rucksack.podspec",
	version_number: "#{version_number}"
    )

    pod_push(
       path: "Rucksack.podspec",
       repo: "allogy",
       allow_warnings: true
    )

    sh "echo APP_VERSION_NUMBER=#{version_number} > version.properties"

  end

  desc "Build the framework and update/push podspec with a _major_ version level."

  lane :podspec_major do

    # Build normally first to ensure it succeeds before incrementing the version.
    gym(
	scheme: "Rucksack",
        skip_package_ipa: true
    )

    increment_version_number(
	bump_type: 'major'
    )
    increment_build_number
    commit_version_bump(
	force: true
    )
    push_to_git_remote

    version_number = get_version_number
    build_number = get_build_number

    add_git_tag(
	tag: "#{version_number}"
    )
    push_git_tags

    version_bump_podspec(
	path: "Rucksack.podspec",
	version_number: "#{version_number}"
    )

    pod_push(
       path: "Rucksack.podspec",
       repo: "allogy",
       allow_warnings: true
    )

    sh "echo APP_VERSION_NUMBER=#{version_number} > version.properties"

  end

  lane :build_universal do

    sh "cd .. && ./build.sh ios-dynamic"

  end

  lane :podspec_universal do

    version_number = get_version_number
    build_number = get_build_number

    version_bump_podspec(
	path: "Rucksack-framework.podspec",
	version_number: "#{version_number}"
    )

    pod_push(
       path: "Rucksack-framework.podspec",
       repo: "allogy-precompiled",
       allow_warnings: true
    )

    slack_message = "Successfully released [Rucksack framework v#{version_number} (#{build_number})] :rocket:"
    slack(
        message: slack_message
    )

  end

  after_all do |lane|
    # This block is called, only if the executed lane was successful

#    version_number = get_version_number
#    build_number = get_build_number

#    slack_message = "Successfully released [Rucksack framework v#{version_number} (#{build_number})] :rocket:"
#    slack(
#        message: slack_message
#    )

  end

  error do |lane, exception|

     slack_message = "Failure releasing Rucksack framework: #{exception.message}"
     slack(
       message: slack_message,
       success: false
     )
  end

end

# More information about multiple platforms in fastlane: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Platforms.md
# All available actions: https://docs.fastlane.tools/actions

# fastlane reports which actions are used
# No personal data is recorded. Learn more at https://github.com/fastlane/enhancer

No Appfile found
fastlane gems

Gem
Version
Update-Status

fastlane
2.125.2
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

slack-notifier
2.3.2

atomos
0.1.3

CFPropertyList
2.3.5

claide
1.0.2

colored2
3.1.2

nanaimo
0.2.6

xcodeproj
1.8.2

rouge
2.0.7

xcpretty
0.3.0

terminal-notifier
2.0.0

unicode-display_width
1.1.3

terminal-table
1.7.3

plist
3.2.0

public_suffix
2.0.5

addressable
2.5.1

multipart-post
2.0.0

word_wrap
1.0.0

tty-screen
0.6.4

tty-cursor
0.5.0

tty-spinner
0.8.0

babosa
1.0.2

colored
1.2

highline
1.7.8

commander-fastlane
4.4.6

excon
0.55.0

faraday
0.12.1

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20170404

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

fastimage
2.1.0

gh_inspector
1.1.3

json
1.8.1

mini_magick
4.5.1

multi_xml
0.6.0

rubyzip
1.2.2

security
0.1.3

xcpretty-travis-formatter
0.0.4

dotenv
2.2.0

bundler
1.14.6

faraday_middleware
<IP_ADDRESS>

naturally
2.1.0

simctl
1.6.4

jwt
2.1.0

uber
0.0.15

declarative
0.0.10

declarative-option
0.1.0

representable
3.0.4

retriable
2.1.0

mime-types-data
3.2016.0521

mime-types
3.1

multi_json
1.12.1

signet
0.11.0

memoist
0.16.0

os
0.9.6

googleauth
0.6.7

httpclient
2.8.3

google-api-client
0.23.9

google-cloud-env
1.0.5

google-cloud-core
1.2.7

digest-crc
0.4.1

google-cloud-storage
1.15.0

emoji_regex
0.1.1

libxml-ruby
3.0.0

psych
2.0.8

generated on: 2019-06-11

It appears the issue is with the version of Cocoapods that Fastlane is using. I was able to get around this by using a Gemfile with the following:
source "https://rubygems.org"
gem 'fastlane'
gem 'cocoapods', '1.7.1'

Uhh, I feel pretty dumb right now but I couldn't really find where fastlane currently defines the version of cocoapods that should be used. Can you help?


zap[logging/zap]: modify set span status

modify set span status

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.zl seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

please sign the cla

please sign the cla

Signed on cla


makeLinkEnabler does not allow marking specific links as "normal" links

In the the EDPOP vre, we have certain internal links in the UI that are not handled by the SPA but instead by the backend. There are also a number of  elements that act like buttons (they have # as their anchor and they include the role="button" property). I don't see a way in makeLinkEnabler to exclude specific links. I would propose the following:

Exclude  elements with class="backbone-util-no-spa" (better suggestions welcome)
Exclude  elements with role="button", because they should never act as links

@jgonggrijp : if you agree, I will create a pull request for these changes.

Regarding links that should be handled by the backend rather than the SPA, I think it will suffice if you include the domain and a scheme in the URL. For example, change  into .
As for an , I agree that it should not be intercepted by the link enabler. But what if the href is something more elaborate? Is there really such a strict semantic that anything with role=button should never lead to route changes?

As for an , I agree that it should not be intercepted by the link enabler. But what if the href is something more elaborate? Is there really such a strict semantic that anything with role=button should never lead to route changes?

Now I think of it more carefully: I think you are right. Take GrETEL, where the application state can be very carefully reproduced from the URL. This application also tracks the configuration, which is set using buttons, in the URL. These buttons are clearly not links, but they do change the URL.
Would you rather make an exception for ?

Yes, I think an exception for href="#" (also with <area> elements) would be useful.


Consider switching from Closure Compiler to UglifyJS

For something of knockout.mapping's relatively-small size and complexity, I think Google Closure compiler is causing too much pain for not enough gain. The whole ko.exportSymbol business is unfriendly to new developers, and buys nothing since we are keeping private all non-exported functions. Only simple optimizations are used anyway.
UglifyJS is more or less the gold standard among people not using Closure's advanced optimizations. It's easy to use on Node, which is now cross-platform.
The relative sizes are:
Compiler         | minified | gzipped
-------------------------------------
UglifyJS         | 9667     | 3006
Closure Compiler | 8827     | 2940

Just something to think about :)

As always, you are certainly welcome to submit a pull request :)
Seriously though, I have zero problems with switching to UglifyJS, but it's fairly low-priority now since everything is working fine as it currently stands.


Module addresses all set to 00000000 when debugging remote target

Describe the bug
When debugging a remote target, module Base Address and Max Address values are all set to zero. In some cases, the modules list does not populate at all. This causes module mapping to be incorrect which affects breakpoint addresses, cursor sync, etc.
To Reproduce
Steps to reproduce the behavior:

Open a .so in the debugger
Start an IN-VM gdb-multiarch session
Issue the target remote command to connect
Open the Modules tab and see that the binaries libraries either have not populated or all have 0 for a base address

Expected behavior
Module base address should reflect the address it is currently loaded to in memory.
Environment (please complete the following information):

OS: Ubuntu 20.04
Java Version: 11.0.13
Ghidra Version: 10.1.3
Ghidra Origin: Official GitHub distro

Additional context
Remote target is correctly identified as an ARMv7 binary.

On the host Ghidra is running on is gdb-multiarch 9.2. On the remote I'm running gdbserver 8.0.1. The addresses in the Objects tree are non-zero and correctly match the running program.
info proc mappings sample line:
        0xb6a47000 0xb6a65000    0x1e000        0x0 /lib/libz.so.1.2.11

maintenance info:
Exec file:
    `/path/to/executable', file type elf32littlearm.

I'll give 10.1.4 a try and get back to you about whether it solves the problem.

In 10.1.4, after disconnecting from the running target and reconnecting (no restart of the target process) with sysroot properly set, the modules seem to load at the correct addresses. If I set a breakpoint to a symbol in the gdb interpreter, the dynamic and static listings are synced when the breakpoint is hit. However, if I try to set a breakpoint in the static listing or decompiler, the breakpoint address is the static listing address, not the correctly mapped address where the module is loaded in memory.

OK - progress (I think).  Appreciate your slogging through all this and providing us with feedback.  Let us know if you hit further problems.

@d-millar,
I'm sorry to write in this issue, but I think it would be better this way, since the problem is similar to mine.
As I said, I have the same problems. But I have a different context: modules that are loaded from the very beginning of execution are determined without problems, but modules that are loaded using the dlopen function have a zero Base/Max addresses. I tried to solve it using the proposed method - it didn't work.

OS: ArchLinux

Java Version: 20.0.1

Ghidra Version: ce5f6b44

Guest OS: Android x86_64

gdb Version: 13.1

gdbserver Version: 8.3 x86_64-linux-android

info proc mappings:
      0x555555554000     0x555555555000     0x1000        0x0  r--p   /data/local/tmp/harness
      0x555555555000     0x555555557000     0x2000        0x0  r-xp   /data/local/tmp/harness
      0x555555557000     0x555555558000     0x1000     0x1000  r--p   /data/local/tmp/harness
      0x555555558000     0x555555559000     0x1000     0x1000  rw-p   /data/local/tmp/harness
      0x7ffd67553000     0x7ffd6765a000   0x107000        0x0  r-xp   /data/local/tmp/liblinkparser.so
      0x7ffd6765a000     0x7ffd6765e000     0x4000   0x106000  r--p   /data/local/tmp/liblinkparser.so
      0x7ffd6765e000     0x7ffd6765f000     0x1000   0x10a000  rw-p   /data/local/tmp/liblinkparser.so

Objects:

Modules:

Try expanding/refreshing the Sections node within the affected module(s).

Try expanding/refreshing the Sections node within the affected module(s).

It didn't work.
I found a solution, or rather understood what I was doing wrong. When I manually set the module address, I forgot to trim the 0x at the beginning of the address. That is, if you manually set the address of the module, then everything works. However, the problem remains: newly loaded modules have zero addresses.

BTW the regions are working properly.

OK, we're able to reproduce the problem (and found another, which is sucking up memory) and are working on a solution.  Will let you know if and when we have a fix.

You will need to refresh the Modules node in the Objects window. We disabled doing this automatically on module load events for efficiency reasons some time ago. There may be a smarter way to go about it, but we haven't tried it out, yet. Something like setting a flag on LOAD/UNLOAD, and then re-syncing modules at the next STOPPED event if that flag is set.

My mistake: when I updated the node, I had the cursor at the position of one of the modules, and not on Modules in general. Thank you!

Something like setting a flag on LOAD/UNLOAD, and then re-syncing modules at the next STOPPED event if that flag is set.

That would be great! Because now I need to set several breakpoints to catch the moment when libraries are loaded, update Modules, and only then the breakpoint that I need will work.
In IDA, everything happens automatically: every time a new module is loaded, breakpoints are checked, if there are any in the module space, then the breakpoint is translated to new addresses. In addition, it is possible to set a flag to automatically stop execution every time a new module is loaded.

Thank you for such a detailed description of the solutions to my problems.
I'm using gdb and gdbserver (see above) and I can't find the nodes Processes->[x]->Debug->Events->Load module in the Objects Tree in any way. I think it is because I am using GDB IN-VM (I need remote debugging).

Obviously, you can do this from the Interpreter using the normal windbg commands

I tried to do it this way, but I regularly got a NullPointerException every time the debugger stopped. I used set stop-on-solib-events 1 as I usually do.
java.lang.NullPointerException: Cannot invoke "ghidra.app.services.DebuggerModelService.getTarget(ghidra.trace.model.Trace)" because "this.modelService" is null
	at ghidra.app.plugin.core.debug.gui.objects.DebuggerObjectsProvider.setTrace(DebuggerObjectsProvider.java:413)
	at ghidra.app.plugin.core.debug.gui.objects.DebuggerObjectsProvider.traceActivated(DebuggerObjectsProvider.java:408)
	at ghidra.app.plugin.core.debug.gui.objects.DebuggerObjectsPlugin.processEvent(DebuggerObjectsPlugin.java:118)
	at ghidra.framework.plugintool.Plugin.eventSent(Plugin.java:293)
	at ghidra.framework.plugintool.mgr.EventManager.sendEvents(EventManager.java:286)
	at ghidra.framework.plugintool.mgr.EventManager.lambda$new$3(EventManager.java:49)
	at ghidra.util.Swing.doRun(Swing.java:292)
	at ghidra.util.Swing.runNow(Swing.java:208)
	at ghidra.util.Swing.runNow(Swing.java:163)
	at ghidra.framework.plugintool.mgr.EventManager.fireEvent(EventManager.java:216)
	at ghidra.framework.plugintool.PluginTool.firePluginEvent(PluginTool.java:536)
	at ghidra.framework.plugintool.Plugin.firePluginEvent(Plugin.java:456)
	at ghidra.app.plugin.core.debug.service.tracemgr.DebuggerTraceManagerServicePlugin.fireLocationEvent(DebuggerTraceManagerServicePlugin.java:824)
	at ghidra.app.plugin.core.debug.service.tracemgr.DebuggerTraceManagerServicePlugin.lambda$prepareViewAndFireEvent$12(DebuggerTraceManagerServicePlugin.java:817)
	at java.base/java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:718)
	at java.base/java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:482)
	at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:318)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:773)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:720)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:714)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:87)
	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:742)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

If you'd like, I can put a ticket in for that (probably not a lot of work)

I would be very grateful to you, because I think this function is useful for debugging. At least in my practice, I often have to deal with this and so far I can't fully use the Ghidra Debugger, because every time I restart the target (I do this very often), I need to do a lot of operations in order to get to the right destination (my goal is not an executable file, but a shared library).

@saruman9 Big apologies, I apparently have confused issues!  I somehow thought you were using the dbgeng agent, not the gdb agent!
We haven't implemented the Events/Exceptions nodes on gdb - will put in a ticket for that - which means for now you're stuck with what you can do with the command line.  I believe @nsadeveloper789 has already put in a ticket for some form of auto-refresh for the modules.
Again, apologies.


Heatmaps ramps arent there on the aggregation per pixel.

cc/ @makella

@saleiva which map type?
I see the two palettes showing in the drop-down for hexbins, rectangles, torque heatmap, and pixel. They aren't available in the Aggregation None option.

I don't get it, do we have specific ramps for the heatmap style?

@xavijam yes, we have two ramps specifically for aggregation (hexbin, rectangle, torque>heatmap, and pixel)
ag_sunset: https://github.com/CartoDB/CartoColor/blob/master/cartocolor.js#L836-L879
ag_GrnYl: https://github.com/CartoDB/CartoColor/blob/master/cartocolor.js#L444-L486

yeah, the rest of the ramps doesnt make so much sense


The set-keymap function is not working as intended

I am unsure as to why, but selecting the es keymap from the prompt does not apply the spanish layout. I have looked through the scripts but I have found no reason/cause as to why it does not work.

Hey, please provide some more information like if there is any desktop environment you are using? some detailed information will help


Axiox NPM

https://www.npmjs.com/package/axios
https://stackoverflow.com/questions/48681126/axios-all-spread-and-catch-all

Convert Ajax call for API calls to AXios.

Convert Ajax call for API calls to AXios.

https://www.storyblok.com/tp/how-to-send-multiple-requests-using-axios

https://www.storyblok.com/tp/how-to-send-multiple-requests-using-axios

axios.getAll() and axios.()spread are deprecated.  Instead do two separate axios call and .then.
https://github.com/axios/axios#concurrency-deprecated

axios.getAll() and axios.()spread are deprecated.  Instead do two separate axios call and .then.
https://github.com/axios/axios#concurrency-deprecated

https://www.freecodecamp.org/news/private-api-keys/

https://www.freecodecamp.org/news/private-api-keys/

https://stackoverflow.com/questions/57410131/make-get-request-to-third-party-api-with-api-key-using-express-router

https://stackoverflow.com/questions/57410131/make-get-request-to-third-party-api-with-api-key-using-express-router

https://stackoverflow.com/questions/63024229/how-to-request-apikey-from-backend-api-using-node-js

https://stackoverflow.com/questions/63024229/how-to-request-apikey-from-backend-api-using-node-js


Remove EmitZipkinBatch([]*zipkincore.Span) from agent reporter

Copied from See https://github.com/jaegertracing/jaeger/pull/1181#discussion_r234053131
Right now we have this flow:
udp server jaeger.thrift -> reporter::SubmitBatch
udp server zipkin.thrift -> reporter::SubmitZipkinSpans

tchannel reporter::SubmitBatch -> pass through to collector
tchannel reporter::SubmitZipkinSpans -> pass through to collector

grpc reporter::SubmitBatch -> convert to domain and send to collector
grpc reporter::SubmitZipkinSpans -> convert to jaeger.thrift, then to domain and send to collector

What I am proposing, is to eliminate reporter::SubmitZipkinSpans completely and have this:
udp server jaeger.thrift -> reporter::SubmitBatch
    tchannel reporter::SubmitBatch -> pass through to collector
    grpc reporter::SubmitBatch -> convert to domain and send to collector
udp server zipking.thrift -> convert to jaeger.thrift -> reporter::SubmitBatch

This way the Reporter only has a single method for Jaeger spans (in Thrift, for now).
Once we remove tchannel completely, we can push thrift->domain conversion into UDP servers as well, and Reporter interface effectively becomes == Collector service from proto IDL.

Also remove duplicated metrics in reporter
jaeger_agent_tchannel_reporter_batches_submitted{format="jaeger"} 0
jaeger_agent_tchannel_reporter_batches_submitted{format="zipkin"} 0

Also update changelog per https://github.com/jaegertracing/jaeger/pull/1180#discussion_r234311418

@yurishkuro do you want why this has a list of batches? https://github.com/jaegertracing/jaeger/blob/master/thrift-gen/jaeger/tchan-jaeger.go#L39

I would like to clarify the scope of this issue. Do we want to remove zipkin.thrift reporting on the agent plus collecting on the collector side?
https://github.com/jaegertracing/jaeger/issues/1186 would be simpler and more straight forward, otherwise, we will have to keep some parts of the zipkin path.
Also there is no direct converter from zipkin thrift to jaeger. We might go through model converter as workaround...

@yurishkuro do you want why this has a list of batches?

Looks like a list: https://github.com/jaegertracing/jaeger-idl/blob/23730e3f90bf592e6518060c437171093dd3a1e4/thrift/jaeger.thrift#L83-L85
As to why - the thinking was that agent did not have to proxy batches 1-1, it could have pre-aggregated them. In order to support sending batches from multiple services we needed a list.
You're correct that if we do #1186 we can simply remove zipkin handling from the agent altogether. Maybe we can punt on it for now, as we will need time to move that code into internal repo, to maintain backwards compatibility (and it might be tricky to incorporate a whole new path like that without changes in the core).

oh for some reason I was looking at agent.thrift where it is defined as a single object.
Just comment when we can go forward and remove it. If you can upgrade all agents we could just remove the submitbatches from zipkin.thrift, keep it on agent with empty impl. you would just implement it with sanitizers like in grpc path.

I think that was my original proposal - still allow agent to accept zipkin over udp, but internally convert to jaeger before sending to collectors. Then it is still backwards compatible with legacy clients.


Ruby 1.9.3 compat?

Any plan to get this compatible with 1.9.3? After (finally) getting the server to run, I have the following error:
undefined method 'run=' for Test::Unit:Module
/usr/local/rvm/gems/ruby-1.9.3-p0/gems/Roman2K-rails-test-serving-<IP_ADDRESS>/lib/rails_test_serving/client.rb:20:in 'tests_on_exit='
This is because Test:Unit no longer has run= method which existed in ruby 1.8. I commented out that line and hit another snag:
undefined method 'reload_application' for #ActionController::Dispatcher:0x007fafdf0afed8
(drbunix:tmp/sockets/test_server.sock) /usr/local/rvm/gems/ruby-1.9.3-p0/gems/Roman2K-rails-test-serving-<IP_ADDRESS>/lib/rails_test_serving/cleaner.rb:76:in 'reload_app'
I tried to work through these issues but eventually gave up. Any advice would be great, it currently takes a horrendous 2m30s just to load my test environment to the point where the tests actually start running.

No plans to get this to work with Ruby >= 1.9.3 and / or Rails >= 3.0.
I hear you about the pain of running tests when they take more than 1s to even start running, let alone 2m30s!
If I were you, I'd look into other solutions like snailgun or, better, decoupling your models from the "web" part (controllers, views) and test them separately. Your tests will run instantly, no magic, no workarounds.

Thanks Roman I'm trying to work out what exactly is happening with the slow startup but I thought I'd give a pre-packaged solution a shot first. I'll look into the snailgun, thanks again.


Add LTRIM to lists

See https://redis.io/commands/ltrim/

+1 - this would serve us well in a current migration to Kredis that I'm working!


expandRow - Load data in specific columns instead of entire row

Hi @AllenFang,
This is regarding expand row feature of react-bootstrap-table2.
When expanded a row, currently it shows the data in entire row.
Is it possible to display data in specific columns when expanding the row?
In runtime, expanded row is like this.

Is it possible to override this colspan or load data in specific columns?
Appreciate any support on this.
Thank you.

@dilushi currently, we don't support this feature, so PR is welcome, thanks


Thanks again for your help. Whether the resize /crop operation is for mri/norm.mgz or mri/brain.mgz?

Thank you for a job well done. : )

I guess you are talking about the OASIS dataset (the Freesurfer version). In my own experience, I first apply the affine normalization on norm.mgz and then check the orientation of each brain scan. Finally, I crop the normalized brain scan using NiBabel and Numpy. For details, you may refer to the documentation in the Freesurfer wiki here: https://surfer.nmr.mgh.harvard.edu/fswiki/FreeSurferWiki. They provide plenty of examples and you may want to look at it.

Thanks for your help. I'm mostly confused by affine normalization. Because I didn't find it in Freesurfer's recon-all command. I only saw the following similar information. Can it be understood that tools such as FSL or ANT are used for affine registration of images.

The Talairach transform computation is used for affine normalization in my pre-processing pipeline. I didn't use FSL or ANT in my pre-processing pipeline. Also, if you would have difficulties in affine normalization, I suggest you also look at this repository: https://github.com/cwmok/LapIRN. We proposed a large deformation image registration method that can overcome large initial misalignment. You can use your raw data and give it a try.

Ok, I understand. Thank you for your help and your excellent work.

Sorry to bother you again. Previously I thought affine regularization(the Talairach transform) was used by default for norm.mgz and aseg.mgz on the OASIS dataset (the Freesurfer version).  So now I should use mri/talairach.xfm to transform norm.mgz and aseg.mgz, right?

Yes.

Thank you for your quick reply. We used the following command (mri_convert norm.mgz --apply_transform talairach.xfm norm_affine.nii.mgz)
But the size of the image was reduced to 172, 220, 156. And it's going to rotate. Has this ever happened to you?

I think it is normal. You can compare your preprocessed data with the testing scans I uploaded in this repository.


Add twitter share and fix linkedin share btn

Description
The linkedin share button is not working and it take the user to an abrupt url on linkedin. I want to fix this bug and also add twitter share button as well.
Steps to reproduce

Click on share button on a post
Click on linkeding
You will not be sharing post instead on a wrong url.

Screenshots

Desktop (please complete the following information)
No response
Smartphone (please complete the following information)
No response
Additional information
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I have checked the existing issues
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

Sure you can go ahead!


.cc links no longer work

vreddit cc links is blacklisted by Reddit. Please update the bot.

Thanks for the info, I stopped using it


[Draft] Refactor tests by functional block

Tests are organized as -
$MORPHEUS_ROOT/tests/morpheus/
$MORPHEUS_ROOT/tests/morpheus_llm/

This PR has fallen terribly out of sync. It will be easier to start a new one at this point.


Java MVM and async in default web.xml? Should we do it?

From a customer:
The main problem is in Google Filters. They do not support asyncRequest attribute. It prevents async feature of Servlet 3.0. Default web.xml should looks like:
<filter>
    <filter-name>AbandonedTransactionDetector</filter-name>
    <filter-class>
        com.google.apphosting.utils.servlet.TransactionCleanupFilter
    </filter-class>
    <async-supported>true</async-supported>
</filter>

<filter-mapping>
    <filter-name>AbandonedTransactionDetector</filter-name>
    <url-pattern>/*</url-pattern>
</filter-mapping>

<!-- ==================================================================== -->
<!-- By default, the SaveSessionFilter filter is mapped to all servlets.  -->
<!-- This filter saves any dirty sessions to the datastore and memcache.  -->
<!-- ==================================================================== -->
<filter>
    <filter-name>SaveSessionFilter</filter-name>
    <filter-class>
        com.google.apphosting.runtime.jetty9.SaveSessionFilter
    </filter-class>
    <async-supported>true</async-supported>
</filter>

<filter-mapping>
    <filter-name>SaveSessionFilter</filter-name>
    <url-pattern>/*</url-pattern>
</filter-mapping>

<filter>
    <filter-name>_ah_ParseBlobUploadFilter</filter-name>
    <filter-class>
        com.google.apphosting.utils.servlet.ParseBlobUploadFilter
    </filter-class>
    <async-supported>true</async-supported>
</filter>

<filter-mapping>
    <filter-name>_ah_ParseBlobUploadFilter</filter-name>
    <url-pattern>/*</url-pattern>
</filter-mapping>

From Jeremy:
The filters in particular need to support async so that the servlets they wrap can as well. This changes the design pattern as the old
try {
// prepare
chain.doFilter();
} finally {
// clean up
}
pattern can't be used. Instead, the filter needs to detect if async has been started in the return path and/or whether this is an async dispatch in the prepare part. It may also need to add listeners to the AsyncContext in case the request gets completed in the background.
It's all quite messy. It may be easier to convert some of the Filters to ServletRequestListeners.
The other issue is that the request may be processed on multiple threads so the ApiProxy context can't rely on a simple ThreadLocal. Specifically, AsyncContext#start "may" pass contextual information when executing the Runnable and we probably should so that applications can make API calls from background tasks. Doing this from user-land is messy so we should handle it within the container.

The anointing of threads with threadlocals for google API calls should be moved from the extended doScope method of the ContextHandler, to a listener mechanism that can also be triggered from calls to AsyncContext.start(Runnable) and async dispatches (eg onWritePossible).  This will allow a single mechanism to setup threadlocals for async and blocking.
Only then can we look at updating the filters to support async (or better yet removing some of the filters completely).

Note that this may need some changes to the jetty distro, so I will be able to do for the 9.3 branch easily.   I can also do for the 9.2, but would prefer to avoid that if timing allows.

New Pull request to review:
https://github.com/GoogleCloudPlatform/appengine-java-vm-runtime/pull/110
Tomas and Anthony should help on the review

I believe this is no longer an issue in the assync-support branch. @gregw ?

this is fixed in Async branch.    We had created the label to mark this before closing these issues when it is merged.  But we can close now also.

I think we were not consistent with using the label or closing the issue and therefore I suggest that we close anything that was fixed in async. It would be good to do the clean-up, so we can know what exactly is pending. @ludoch ?

Agree. Let's close issues fixed in the branch.
On Wed, Jun 8, 2016 at 2:40 PM, Arie<EMAIL_ADDRESS>wrote:

I think we were not consistent with using the label or closing the issue
and therefore I suggest that we close anything that was fixed in async. It
would be good to do the clean-up, so we can know what exactly is pending.
@ludoch https://github.com/ludoch ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/appengine-java-vm-runtime/issues/23#issuecomment-224737640,
or mute the thread
https://github.com/notifications/unsubscribe/AAE4zXG-kkSlAyxZ861it2zUY8TyNxoEks5qJzbBgaJpZM4FmaYa
.


test: replace tempdir / tempfile with assert_fs

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.25%. Comparing base (8503249) to head (cfc35e8).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #120   +/-   ##
=======================================
  Coverage   88.25%   88.25%
=======================================
  Files          14       14
  Lines         775      775
=======================================
  Hits          684      684
  Misses         91       91

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Baseimage testpr and bookworm

ADSB:

[ ] radarbox build

[x] Build against bookworm
[x] Initial Test
[x] healthcheck
[ ] Verified Good

[ ] readsb-proto

[x] Build against bookworm
[x] Initial Test
[x] healthcheck
[ ] Verified Good

[ ] beast-splitter

[x] Build against bookworm
[x] Initial Test
[x] healthcheck
[ ] Verified Good

[ ] fr24

[x] Build against bookworm
[x] Initial Test
[x] healthcheck
[ ] Verified Good

[ ] radarvirtuel

[x] Build against bookworm
[x] Initial Test
[x] healthcheck
[ ] Verified Good

[ ] tar1090

[x] Build against bookworm
[x] Initial Test
[x] healthcheck
[ ] Verified Good

[ ] tar1090 telegraph

[x] Build against bookworm
[x] Initial Test
[x] healthcheck
[ ] Verified Good

[ ] dump978

[x] Build against bookworm
[x] Initial Test
[x] healthcheck
[ ] Verified Good

[ ] piaware

[x] Build against bookworm
[x] Initial Test
[x] healthcheck
[ ] Verified Good

[ ] adsbx

[x] Build against bookworm
[x] Initial Test
[x] healthcheck
[ ] Verified Good

[ ] adsbhub

[x] Build against bookworm
[x] Initial Test
[x] healthcheck
[ ] Verified Good

[ ] opensky

[x] Build against bookworm
[x] Initial Test
[x] healthcheck
[ ] Verified Good

[ ] planefinder

[x] Build against bookworm
[x] Initial Test
[x] healthcheck
[ ] Verified Good

[ ] ultrafeeder

[x] Build against bookworm
[x] Initial Test
[x] healthcheck
[ ] Verified Good

ACARS

[ ] acarsdec

[x] Build against bookworm
[x] Initial Test
[x] healthcheck
[ ] Verified Good

[ ] vdlm2dec

[x] Build against bookworm
[x] Initial Test
[x] healthcheck
[ ] Verified Good

[ ] dumpvdl2

[x] Build against bookworm
[x] Initial Test
[x] healthcheck
[ ] Verified Good

[ ] acars router

[x] Build against bookworm
[x] Initial Test
[x] healthcheck
[ ] Verified Good

[ ] acars oxide

[ ] Build against bookworm
[ ] Initial Test
[ ] healthcheck
[ ] Verified Good

[ ] acarshub

[ ] Build against bookworm
[ ] Initial Test
[ ] healthcheck
[ ] Verified Good

Other

[ ] rtlsdrairband

[x] Build against bookworm
[ ] Initial Test
[ ] healthcheck
[ ] Verified Good

@kx1t @mikenye I'm plugging away at this. I've created a checklist above showing the status of everything. Am I missing any containers?

I'll also add that the checklist format is basically indicating if the thing builds under bookworm, have I run it (initial test) and the verified good will be once enough people run in and we know it works.

ummm - why is there no airspy container on your list?

ummm - why is there no airspy container on your list?

Great question. It doesn't appear to be part of our CI (it should be) and this list was generated from the CI + my memory. Lemme add it

Alright, I think this is ready to go. Plane Fence will need kx1t's touch but I've got a PR ready for it that should enable a seamless transition. I'd say we give it more time for everyone to run it, but honestly, I don't think it's going to give us many headaches going forward.
Changes to common action:

I may have messed this up, but previously there was a depedency on certain build paths for no_healthcheck and other builds to complete. I didn't see a reason for this, so all build paths (arch specific, no healthcheck, build manifest) should be parallel now
build_baseimage_test. Boolean to indicate that this is being called to test against baseimage test images. Will use the sed statement in build_baseimage_url to update docker file. While not explicitly required, no_healthcheck/version specific/arch specific in all SDR-E callers of this action disable those build paths.
build_baseimage_url is a sed statement (less the leading s and trailing g) used to change the FROM image URL to point to the baseimage test images. If build_baseimage_test is false then this value is ignored.
dockerfile_changes was added to allow ultra and tar1090 to build using the common action. It is a sed statement, that if set, will update the dockerfile
docker_latest_tag was added to allow ultra and tar1090 to build the telegraf images and not overwrite the latest tag of the non-telegraf version. Default is latest. Basically, if build_latest is set, the tag used when building the list of tags will include docker_latest_tag. If this is NOT set to latest, as of right now (and this should be fixed, I just now thought of it) any arch/version specific tags will get overwritten. Basically, if you want to set docker_latest_tag to a something not latest then disable arch/version builds for it. ultra/tar1090:telegraf are done this way.

General Changes:

All of the SDR-E builds now use the common action for deploy except for ACARS Hub. My build process is so....unique, I don't want to mess with it quite yet. However, it functionally is the same as the common action.
I did not touch any PR actions, although I probably should. Likely, it will be largely a copy / paste exercise from deploy to the pr action and disable pushes.
Added in an input to the deploy action in the baseimage repo to build the main images, but NOT trigger any upstream rebuilds.
Added in DEPLOY_STATUS.MD which is a simple MD file that shows the build status of all of the SDR-E deploy actions in one place
Some of the SDR-E containers have changes in them which means that they will NOT build again under non-bookworm debians, and to make my life easier these changes have been all merged into their respective main/master branches. If, for some reason we need to roll back, it will be a manual process of updating container dockerfiles. The actual build action stuff shouldn't be needing any changes.
All containers have switched to using wiede's MLAT client. muta's version was not bookworm safe. I see no reason to change this for the foreseeable future, but it's something to keep in mind.
/run/s6/services is now /run/s6/legacy-services

Warnings:

I honestly expect this to fail once we merge to main. The ONLY build path actually tested has been the baseimage-pr path. No arch, version specific, or healthcheck
There may be an issue with MLAT. If so, this will require fixing from upstream.
Because of the legacy-services thing, no container will now build against any non-v3 S6.
Any future docker images, until we change the service files to non-legacy, will have to reference /run/s6/legacy-services instead of /run/s6/services
Any future docker images should use the correct cont-env shebang (#!/command/with-contenv)
Any future docker images should mark any files in /etc/{cont.init, cont.finish, services.d, whatever S6 path I forgot} as +x. Failure to do so will cause a startup error related to permissions on the run file

Things to do:

Because of the warning above, I would like to merge this to main, stop the build, and retrigger the build but disable any upstream rebuild triggers. Once the rebuild of the base images is done we can go through and individually trigger the builds off to make sure they're doing what we want. Once we know that's all good, in the future we can just let it trigger on its own.
We will need to migrate all of our S6 run files AND healthcheck framework to the new format. What that is, and what that will entail I don't know but I expect it to be a large pain.
Related to the above, we will need to change all of the cont-env shebang lines. I didn't do this because it wasn't necessary to get S6 v3 working and I wanted to keep the breaking changes to a minimum.
When we do the above, we will need to change the S6 v3 deploy script to remove s6-overlay-symlinks-noarch stuff. I think.
Also, when we do the above there is a small hack I did in the S6 v3 overlay script to fix a shebang issue with execlineb and other things that apparently is a bug in their own symlinks. We could likely remove this once we've fixed the shebangs.
It is likely I've cocked up some dockerhub name, no healthcheck/arch specific/version specific thing, either enabling/disabling as appropriate, or using the wrong method for versioning, etc. We will need to check those things to make sure I got it right. I tried my hardest, but there was an awful lot of stuff I was keeping in my head so I'm sure I got it wrong somewhere.
I feel like we could potentially migrate rltsdrairband to the soapy image, and I may take the time to make a base image specifically for it. There seems to be little reason to build all of that nonsense over and over again in the airband container when in reality a decent chunk of it may be useful in a base image and shared.
Healthchecks should be audited and see if we're hitting the mark with them. I feel like this issue mostly impacts new images and not the ones Mike created "back in the day", but if we've added features to these containers (tar1090 maybe?) then we should ensure HC is doing a thing with that. I can state with ceritude I'm missing the mark with HC on the ACARS stack.

This has been a marathon effort but it's as good as I can get it. Sorry for the massive novel.


Implement remaining RISC-V B instructions

Is this still relevant?

Yes. We’ve assigned implementation of several ones to students this year and some were not completed.


Permissions Error When trying to create new site

Peux m'aider avec cette erreur si dessous? Looks like file permissions on the alpine box...
user@host:~$ docker run --rm -it -v $PWD:/src -u hugo jguyomard/hugo-builder hugo new site mysite
2017/01/07 22:00:06 mkdir /src/mysite/: permission denied
panic: mkdir /src/mysite/: permission denied
goroutine 1 [running]:
panic(0xa19600, 0xc42018ce20)
/usr/local/Cellar/go/1.7.4/libexec/src/runtime/panic.go:500 +0x1a1
log.Panicln(0xc4200317f8, 0x1, 0x1)
/usr/local/Cellar/go/1.7.4/libexec/src/log/log.go:334 +0xc9
github.com/spf13/hugo/vendor/github.com/spf13/afero.WriteReader(0xdfca20, 0xe54d70, 0xc4201035e0, 0x17, 0xdf0c20, 0xc420057b00, 0xdf25a0, 0xc420057bf0)
/Users/bep/go/src/github.com/spf13/hugo/vendor/github.com/spf13/afero/util.go:49 +0x272
github.com/spf13/hugo/helpers.WriteToDisk(0xc4201035e0, 0x17, 0xdf0c20, 0xc420057b00, 0xdfca20, 0xe54d70, 0xb, 0x0)
/Users/bep/go/src/github.com/spf13/hugo/helpers/path.go:585 +0x5d
github.com/spf13/hugo/commands.createConfig(0xc42018c890, 0xb, 0xae2f9d, 0x4, 0xdf25a0, 0xc4200578f0)
/Users/bep/go/src/github.com/spf13/hugo/commands/new.go:346 +0x459
github.com/spf13/hugo/commands.doNewSite(0xc42018c890, 0xb, 0x0, 0x0, 0x0)
/Users/bep/go/src/github.com/spf13/hugo/commands/new.go:151 +0x4e1
github.com/spf13/hugo/commands.NewSite(0xe2ecc0, 0xc42018c860, 0x1, 0x1, 0x0, 0x0)
/Users/bep/go/src/github.com/spf13/hugo/commands/new.go:193 +0x2a7
github.com/spf13/hugo/vendor/github.com/spf13/cobra.(*Command).execute(0xe2ecc0, 0xc42018c7a0, 0x1, 0x1, 0xe2ecc0, 0xc42018c7a0)
/Users/bep/go/src/github.com/spf13/hugo/vendor/github.com/spf13/cobra/command.go:632 +0x23e
github.com/spf13/hugo/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xe2d9a0, 0xb5e1b8, 0xe36ad0, 0x1)
/Users/bep/go/src/github.com/spf13/hugo/vendor/github.com/spf13/cobra/command.go:722 +0x367
github.com/spf13/hugo/commands.Execute()
/Users/bep/go/src/github.com/spf13/hugo/commands/hugo.go:160 +0x6d
main.main()
/Users/bep/go/src/github.com/spf13/hugo/main.go:26 +0x32

Bonjour,

Do you have permission to create a new directory in the current directory? Do you have an error if you run this command in the current directory :

touch test

What's your UID? Can you try with this docker command:

docker run --rm -it -v $PWD:/src -u $UID jguyomard/hugo-builder hugo new site mysite

If you still have an error, can you give me the result of:
echo $UID && echo $PWD

Have a good day,

touch test works
my UID is 1001, this command worked.

This began when I created a second user account, gave it the same permissions as the first user account (the command worked on this one) and on the new user account I created I ran the command and got the error...  I tried removing the docker image entirely but still received the error. Is there some fundamental I'm missing?
Thanks a lot,
Jonathan

Hi,
This is a permission problem.
By default, this docker image run hugo with UID=1000 user. If current directory owner has another UID (1001 in your case), you have to set this UID, with -u 1001 parameter:
docker run --rm -it -v $PWD:/src -u 1001 jguyomard/hugo-builder hugo new site mysite

You can also run this docker image as root, if it's simplier for you:
docker run --rm -it -v $PWD:/src jguyomard/hugo-builder hugo new site mysite

Have a good evening,

Understood, thank you very much for taking the time to respond so quickly!


Todo: Test proxy

The client needs some testing for the proxy parameter.

Deleted since proxy is handled by transport.


Fix the census initialization on the server. Remove duplicate initialization logic and also enable census per channel if census is initialized.

With this change we can enable census on the server by initializing the census library. At one point we should probably send the client channel arguments and use them for each channel to control the census library.

Can one of the admins verify this patch?

Can one of the admins verify this patch?