proposal: add a filter for injecting credentials into outgoing HTTP requests

Title: Add a filter for injecting credentials into outgoing HTTP requests
Description:
It would be conventient to have a standard filter that can inject credentials into outgoing HTTP requests (as a value of Authorization header).
The most common use cases:

OAuth2 access token credential
basic auth credential
opaque bearer token credential

The primary focus of this proposal is on injecting OAuth2 access token credential.
Proposal:
Add an HTTP filter with the following configuration model:
- name: envoy.filters.network.http_connection_manager
  typed_config:
    "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
    http_filters:
    - name: envoy.filters.http.credentials
      typed_config:
        "@type": type.googleapis.com/envoy.extensions.filters.http.credentials.v3alpha.Injector
        config:
          rules:
          - match:
              ... # HTTP requests to match
            inject:
              credential: { ... } # credential to inject

If the list of rules is empty, the filter will have no effect.
With regards to OAuth2 support:

the filter will allow a user to specify client_id and client_password
and let filter to acquire OAuth2 access token through Client Credentials Grant flow
the filter will also take care of refreshing access token

Usage examples:
Injecting OAuth2 access token
- name: envoy.filters.network.http_connection_manager
  typed_config:
    "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
    http_filters:
    - name: envoy.filters.http.credentials
      typed_config:
        "@type": type.googleapis.com/envoy.extensions.filters.http.credentials.v3alpha.Injector
        config:
          rules:
          - match:
              prefix: /
            inject:
              credential:
                oauth2:
                  token_endpoint:
                    cluster: oauth
                    uri: oauth.com/token
                    timeout: 3s
                  client_credentials:
                    client_id:
                      secret:
                        name: client-id
                        sds_config:
                          path: "/var/run/secret/credentials/oauth2/client-id.yaml"
                    client_password:
                      secret:
                        name: client-password
                        sds_config:
                          path: "/var/run/secret/credentials/oauth2/client-password.yaml"
                  # (Optional)
                  scopes:
                  - "example"

Injecting basic auth credentials
- name: envoy.filters.network.http_connection_manager
  typed_config:
    "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
    http_filters:
    - name: envoy.filters.http.credentials
      typed_config:
        "@type": type.googleapis.com/envoy.extensions.filters.http.credentials.v3alpha.Injector
        config:
          rules:
          - match:
              prefix: /
            inject:
              credential:
                basic:
                  username:
                    secret:
                      name: username
                      sds_config:
                        path: "/var/run/secret/credentials/basic/username.yaml"
                  password:
                    secret:
                      name: password
                      sds_config:
                        path: "/var/run/secret/credentials/basic/password.yaml"

Injecting opaque bearer token credential
- name: envoy.filters.network.http_connection_manager
  typed_config:
    "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
    http_filters:
    - name: envoy.filters.http.credentials
      typed_config:
        "@type": type.googleapis.com/envoy.extensions.filters.http.credentials.v3alpha.Injector
        config:
          rules:
          - match:
              prefix: /
            inject:
              credential:
                generic:
                  prefix: "Bearer "
                  value:
                    secret:
                      name: bearer-token
                      sds_config:
                        path: "/var/run/secret/credentials/generic/bearer-token.yaml"

Could you give some more descriptions about the specific scenes?
IMO, this may be useful in the mesh where the mTLS is disabled and authentication is necessary.

We are also interested in this.
We want/need client_credentials: https://auth0.com/docs/get-started/authentication-and-authorization-flow/client-credentials-flow because Envoy supports only authorization_code: https://github.com/envoyproxy/envoy/blob/main/source/extensions/filters/http/oauth2/oauth_client.cc#L25.
Do you have a branch or image I could use for testing, if you're already implemented it, that is.

Seriously, I need this feature, and I believe I'm not alone.
There was an out of maintenance service (A) which runs robustly for years. But the service (B) this old service depends on, got updated, that introduced auth for existing apis. (A calls B)
So a proxy is needed to inject credentials into request from A to the consume B, because not willing to touch the code of A.

Seriously, I need this feature, and I believe I'm not alone.
There was an out of maintenance service (A) which runs robustly for years. But the service (B) this old service depends on, got updated, that introduced auth for existing apis. (A calls B) So a proxy is needed to inject credentials into request from A to consume B, because not willing to touch the code of A.

Sounds reasonable scene.

I tagged this issue to help wanted. But based on our contributing policy, we need a maintainer to sponsor this feature. Because we will add a new extension.
Check this https://github.com/envoyproxy/envoy/blob/main/CONTRIBUTING.md#adding-new-extensions for more info.
cc @yskopets

It would be convenient if this can affect at route level. So in an istio mesh, we can create EnvoyFilter cr to patch virtual_host, to tell which route need this, also the workload selector could be used to tell which pod need this.

I'm keen to have this feature as well. There's a great use case for an outbound edge proxy, adding some protection against malicious code.
Say for example an internal service A needs to access an external service like GitHub. Current practice is to inject a PAT into the container, which can be retrieved by either code execution on the container or privileged access at a node or cluster level. If we move the PAT token out of the container and/or cluster then we can protect against malicious actors with code execution.
Authorisation could be managed with service account + outbound domain allowlists, with JWT validation?

We would be very much interested in this feature getting implemented. +100

It seems that STS works like oauth Client Credentials Grant, so I think it would be possible to also include it in this new filter. However, the initial implementation will focus on oauth Client Credentials Grant flow.

Our use case: Expose Kubernetes API server's OIDC metadata.

Kubernetes API server's OIDC metadata is not publicly available
OIDC metadata can be retrieved with a ServiceAccount's token

It'd be great to expose the OIDC metadata with Istio/envoy, without having to deploy an extra component to request the OIDC metadata from Kubernetes API using the ServiceAccount's token.
Why? The OIDC metadata needs to be available for AWS IAM for AWS IAM Roles as Service Accounts (IRSA). This comes out-of-the-box in EKS, but in a private Kubernetes installation one needs to jump through hoops.

Our use case: Expose Kubernetes API server's OIDC metadata.

Kubernetes API server's OIDC metadata is not publicly available
OIDC metadata can be retrieved with a ServiceAccount's token

It'd be great to expose the OIDC metadata with Istio/envoy, without having to deploy an extra component to request the OIDC metadata from Kubernetes API using the ServiceAccount's token.
Why? The OIDC metadata needs to be available for AWS IAM for AWS IAM Roles as Service Accounts (IRSA). This comes out-of-the-box in EKS, but in a private Kubernetes installation one needs to jump through hoops.

This could be implemented as an extension tpye of the credentials injector. https://github.com/envoyproxy/envoy/pull/27769

When you talk about 'OIDC metadata', Do you mean ID token？

No, I mean the OIDC metadata of the Kubernetes API Server.
With AWS IRSA, one needs to create a new Identity Provider in AWS IAM, and its authentication can be OIDC. Then AWS IAM will retrieve the OIDC metadata of this Identity Provider, which in this case is the Kubernetes API server.
Nowdays Kubernetes API server provides the OIDC metadata out-of-the-box. The problem is, in some case like ours, the metadata endpoint requires authentication. Because AWS IAM requires the OIDC metadata be publicly available, one needs to configure a proxy which provides AWS IAM with the OIDC metadata. In this case this proxy will authenticate to the Kubernetes API server OIDC endpoint using the ServiceAccount's credentials (Bearer token).
It looks like this:
❯ curl https://public-proxy-hostname.example.com/.well-known/openid-configuration
{"issuer":"https://public-proxy-hostname.example.com","jwks_uri":"https://oidc.dt.ag-dev.shoot.canary.k8s-hana.ondemand.com/jwks","response_types_supported":["id_token"],"subject_types_supported":["public"],"id_token_signing_alg_values_supported":["RS256"]}

And here the issuer matches with the hostname of the metadata endpoint which is required for by AWS IAM Identity Provider configuration.

I'd be interested in this as well. Is there already a rough idea for when the work in #30850 might get released?

i should imagine it will be included in the next release

It would be convenient if this can affect at route level. So in an istio mesh, we can create EnvoyFilter cr to patch virtual_host, to tell which route need this, also the workload selector could be used to tell which pod need this.

we are interesting in using it as upstream filter. For those apis that could be weight routing.
https://github.com/envoyproxy/envoy/pull/35194


Release v0.4

Awaiting systems api fixes before pushing, but preparing for release.

Did final check over. Everything working as intended (tm)
Holding server pull until systems API is stable again.


question: working with discriminators and inheritance on nested data

Question
Hey guys :)
Currently I'm not sure if I'm not understanding things correctly or if there's indeed a missing/buggy functionality - kinda new to both openapi and swift.
In general I do have an Endpoint that returns some nested data.
Class structure look like this (pseudo):
Action(details: ActionDetails)
ActionDetails(type: String)
ActionDetailsFoo(foo: String): ActionDetails
ActionDetailsBar(bar: int): ActionDetails
GET /nextAction
returns Action
{
    "details": {
        "type": "FOO",
        "foo": "whatever"
    }
}

See (manually adjusted) file with notes:
openapi: 3.0.1
info:
  title: OpenAPI definition
  version: v0
servers:
  - url: http://localhost:8080
    description: Generated server url
paths:
  /nextAction:
    get:
      tags:
        - open-api-controller
      operationId: nextAction
      responses:
        default:
          description: OK
          content:
            'application/json':
              schema:
                $ref: '#/components/schemas/Action'
components:
  schemas:
    Action:
      type: object
      properties:
        details:
          $ref: '#/components/schemas/ActionDetails'
    ActionDetails:
      required:
        - type
      type: object
      properties:
        type:
          type: string
      discriminator:
        propertyName: type
        mapping:
          FOO: '#/components/schemas/ActionDetailsFoo'
          BAR: '#/components/schemas/ActionDetailsBar'
      anyOf: # manually added; removing this will always parse an object from ActionDetails without further info
        - $ref: '#/components/schemas/ActionDetailsFoo'
        - $ref: '#/components/schemas/ActionDetailsBar'
    ActionDetailsBar:
      type: object
      allOf:
#        - $ref: '#/components/schemas/ActionDetails' # keeping this ref to parent will end up in a loop
        - type: object
          properties:
            bar:
              type: integer
              format: int32
    ActionDetailsFoo:
      type: object
      allOf:
#        - $ref: '#/components/schemas/ActionDetails'
        - type: object
          properties:
            foo:
              type: string

I've been playing around a lot with the openapi spec but no matter how I put it, I can't really get it running as expected
A) removing the anyOf on the ActionDetails level will ignore any subtype when parsing
note: the anyOf is currently manually added after generation
        public struct ActionDetails: Codable, Hashable, Sendable {
            public var _type: Swift.String
            public init(_type: Swift.String) {
                self._type = _type
            }
            public enum CodingKeys: String, CodingKey {
                case _type = "type"
            }
        }

B) anyOf within the ActionDetails and allOf within the subclasses -> endless loop during runtime
ActionDetails.init() -> ActionDetailsFoo.init() -> ActionDetails.init() -> ActionDetailsFoo.init() -> ...

C) anyOf within the ActionDetails and removing allOf within subclasses:
kinda works, but I would have to manipulate the file manually and add all attributes that they should have from inheritance manually

From my understanding a) should be the correct way, as having a discriminator should take all schemas that have the parent schema with allOf included into consideration for alternate schemas.
Therefore I'm wondering if I'm doing it wrong or if this is indeed a bug / missing feature, can someone please enlighten me? :)
Also I'm generally new to swift and wonder if there's a more convenient way of getting the actual object then a switch on the cases? Maybe casting or anything? I usually have handlers and would like to just put the ActionDetails and they already know what kind of type they'd expect.
let result = client..

// is it possible to do something like
result as? ActionDetailsFoo

// instead of
switch(result) {
    .case ActionDetailsFoo(let foo):
    .case ActionDetailsBar(let bar):
}

I actually do have a similar issue when sending responses of subtypes. I wonder if there's any elegant way in which I could send any subclass of ActionDetails instead of ActionDetails that lacks all the extra information to an endpoint that expects an object of type ActionDetails.

I think you should be using oneOf instead of anyOf.
oneOf uses a discriminator and allows you to dynamically deserialize values.
Try that first and see if that helps.

Hey @czechboy0, my bad - you're right, I mixed up things while testing.
Nevertheless this only makes option #3 valid:

Sadly in that case I have to comment out the "allOf" and "copy" over all from the parent like this:
    ActionDetailsBar:
      type: object
      allOf:
#        - $ref: '#/components/schemas/ActionDetails' # has to be commented out or I'll end up in an overflow
        - type: object
          properties:
            type: # type added from parent (my actual case contains many more values)
              type: string
            bar:
              type: integer
              format: int32

I kinda feel like this feels hacky as I have to manually adjust the generated openapi file..

Sorry that's wrong. I double checked and it actually works as intended without having to copy over the attributes.
Thank you!

I think what you want is this:
components:
  schemas:
    Action:
      type: object
      properties:
        details:
          $ref: '#/components/schemas/ActionDetails'
    ActionCommon:
      type: object
      properties:
        type:
          type: string
      required:
        - type
    ActionDetails:
      oneOf:
        - $ref: '#/components/schemas/ActionDetailsFoo'
        - $ref: '#/components/schemas/ActionDetailsBar'
      discriminator:
        propertyName: type
        mapping:
          FOO: '#/components/schemas/ActionDetailsFoo'
          BAR: '#/components/schemas/ActionDetailsBar'
    ActionDetailsBar:
      type: object
      allOf:
        - $ref: '#/components/schemas/ActionCommon'
        - type: object
           properties:
             bar:
               type: integer
               format: int32
           required:
             - bar
    ActionDetailsFoo:
      type: object
      allOf:
        - $ref: '#/components/schemas/ActionCommon'
        - type: object
           properties:
             foo:
               type: string
           required:
             - foo

Note that this also means that if you add a 3rd type in the future (e.g. Baz), that'd be considered API-breaking, as providing an unknown discriminator value (BAZ) will fail deserialization.
If you'd like to instead allow unknown values, and have the application logic deal with them, and gracefully fall back, you'd change ActionDetails to:
    ActionDetails:
      anyOf:
        - oneOf:
            - $ref: '#/components/schemas/ActionDetailsFoo'
            - $ref: '#/components/schemas/ActionDetailsBar'
          discriminator:
            propertyName: type
            mapping:
              FOO: '#/components/schemas/ActionDetailsFoo'
              BAR: '#/components/schemas/ActionDetailsBar'
        - type: object

More details on open vs oneOf/enums: https://swiftpackageindex.com/apple/swift-openapi-generator/1.2.0/documentation/swift-openapi-generator/useful-openapi-patterns#Open-enums-and-oneOfs
TL;DR: you wrap it in an extra anyOf and add a type: object, as that'll always succeed to deserialize. And you'd first check if the type-safe oneOf is non-nil, in which case you received a known type, but if it's nil, you know you received an unknown type, and it's present in the second value, in the freeform type: object.
Now, note that while it's more flexible this way and allows for easier API evolution, it is slightly less performant as the known events will always be deserialized twice, once in the known oneOf, and once in the freeform object. It's probably still desirable for its benefits, just something to be aware of.

Thank you very much for your input, that totally makes sense. Also thanks for the hint about the graceful fallback, much appreciated.
I'm just a little bit worried as to my current understanding this means that I have to manipulate the autogenerated openapi file - or find a way in which it gets generated like that. But I'll do my research on this, as it's kinda unrelated to the swift openapi generator project. Again, thank you very much for your input :)

You're welcome.
Out of curiosity, what are you generating the OpenAPI file from? I'd instead encourage you write the OpenAPI document by hand, and use that as the source of truth.
More details on that approach here: https://swiftpackageindex.com/apple/swift-openapi-generator/1.2.0/documentation/swift-openapi-generator/practicing-spec-driven-api-development

For this minimal running example I was using the springdoc openapi gradle plugin. The issue I'm facing is on a project from work - I think we use the swagger gradle plugin there.
Currently the generated json contains more than 20k lines; so I think I'd rather find a script solution rather than doing it by hand, but I'll discuss further steps with my team :D

You can start with the doc generated today, and flip the process and generate the code from the doc, instead of the other way around.
That way you can start making hand edits right away, without rewriting the doc from scratch.


Drawing with a pen on a Lenovo Yoga Book doesn't stop drawing when you lift the pen

User has a Yoga book c930. "I can use the pen on any of my screens I was choosing to use it like my mouse but it would keep the ink running om the screen even when I lifted the pen.  It was accurate just never ending.  It would also sometimes do this with when using the mouse pad and not the pen. The ink just wouldn't stop so I couldn't lift and start a new line.  The pen came with the laptop tablet hybrid that the Lenovo Yoga book c390 is.  Chrome for browser."

I have a Wacom tablet you can use if you need to solve this problem. Or I can investigate with Jacob.

Nice. Can you reproduce the problem on it?

I'll ask Isaac to try his first. I haven't actually used it yet....
On Sat, Mar 6, 2021 at 11:02 AM Melinda Morang<EMAIL_ADDRESS>wrote:

Nice. Can you reproduce the problem on it?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/melindamorang/blowyourfaceoff/issues/94#issuecomment-792026009,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARQDLJ3XQJBJJZ2VZ5MDCU3TCJ32ZANCNFSM4YW2LNAA
.

From Isaac

When I used my drawing tablet:

Drawing a line made it so it kept on drawing even when the pen was just hovering the tablet and even when I wasn't in the drawing space. I needed to tap the tablet to make it stop.
Making dots was perfectly fine.
Here is the game code to see the drawings I did: 435744

If you want me to drop off my tablet, I can have Eric leave it on the porch tomorrow morning. Or Isaac can work with Jacob to figure it out since he built the original anyway. He might just know off the top of his head what the problem is.

Thanks both of you!  Can you please ask Isaac to clear his browser cache and try again really quickly?  I have temporarily pushed something that fixes a liney problem with a mouse that might also fix this issue. If not, then maybe Isaac and Jacob should try to figure it out...

Well, it's definitely something to do with the event listeners for the canvas, but beyond that I don't know. I'm going to go do something else for a while.

Isaac said it still doesn't work. Jacob is going to work on it and have
Isaac test. I told him there is a new database to update to.
On Sat, Mar 6, 2021 at 11:57 AM Melinda Morang<EMAIL_ADDRESS>wrote:

Well, it's definitely something to do with the event listeners for the
canvas, but beyond that I don't know. I'm going to go do something else for
a while.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/melindamorang/blowyourfaceoff/issues/94#issuecomment-792042558,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARQDLJ225MQWLBRI7RHFTILTCKCIZANCNFSM4YW2LNAA
.

Can you make that last request with Jacob's changes live so Isaac can test?
On Sat, Mar 6, 2021 at 12:45 PM Sarah Griffin<EMAIL_ADDRESS>wrote:

Isaac said it still doesn't work. Jacob is going to work on it and have
Isaac test. I told him there is a new database to update to.
On Sat, Mar 6, 2021 at 11:57 AM Melinda Morang<EMAIL_ADDRESS>wrote:

Well, it's definitely something to do with the event listeners for the
canvas, but beyond that I don't know. I'm going to go do something else for
a while.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/melindamorang/blowyourfaceoff/issues/94#issuecomment-792042558,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARQDLJ225MQWLBRI7RHFTILTCKCIZANCNFSM4YW2LNAA
.

I just pushed a change that fixes a javascript error on Android and may fix some other drawing problems. Sarah, could you please as Isaac to re-test this with his drawing pen? I'm not terribly hopeful, but it's worth a try.

Isaac says the experience is better but still "wonky" and "janky". I'm going to send this to Autumn, who reported the problem, and see if it's fixed for her.

Autumn tested the update and said everything is working satisfactorily now with her drawing pen. I'm going to close this issue. I will look into Isaac's "wonky" "janky" problem separately.


fix: update to eye v10.18.3

fix: update to eye v10.18.3

:tada: This issue has been resolved in version 16.17.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v16.17.3

Your semantic-release bot :package::rocket:


Galacticmon Phase 3 secondary attacks don't work

If Phase 3 Galacticmon is a Digimon with no Technique then it will never perform the counter or the laser attack. Instead no animations happen and it will say that your Digimon evaded the attack. It never actually hits

Happens because Digimon in phase 3 doesn't have moves.
Added Keep Galacticmon checkbox in db2185a


Trigger xds routing support via env var instead of channel arg.

Attempting to close and re-open to fix EasyCLA check.

Known issues: #22820 #22523 #22968


fix: compacts artworks displayed in shelf

Unknown what the cause of this is but some nodes in this response are null. This fixes the front-end for now.

There was a related MP PR that may have changed some behavior? https://github.com/artsy/metaphysics/pull/4867
Also worth pointing out that fixes and tweaks have now gone in to both MP and Force, but Gravity is the source of truth and should be very straightforward to debug + reproduce. I think it's better to start debugging there to solve whatever the issue is rather than patching downstream clients, IMO.


API requires that motor calibration is run before encoder data can be read

An expected workflow for setting up the board should be:

Reading data from encoder to make sure it's working
Calibrating motor
Running controls code

Determine what the best way to modify the API would be.

Merged into dev


Question about training image normalization

How to pre-process normalization on the training and testing image， I can not find relate code. But , in demo_FSANET_mtcnn.py,  find
cv2.normalize(faces[i,:,:,:], None, alpha=0, beta=255, norm_type=cv2.NORM_MINMAX)

Hello @janicevidal, during training, we just make sure the image intensity range is bewteen [0,255]. In keras training, there is no big difference to normalize it to [0,1] (at least in my experiment there is no obivious effect.)

Hello @janicevidal, during training, we just make sure the image intensity range is bewteen [0,255]. In keras training, there is no big difference to normalize it to [0,1] (at least in my experiment there is no obivious effect.)

@shamangary Thanks


Run bin/estimate_box_runtime.jl on every quarter square degree of the sky

Might as well do this upfront using taskfarmer. The current version of estimate_box_runtime.jl fits a psf and interpolates the sky background noise for each image. Both are unnecessary for estimating runtime. Some restructuring of the image loading routine is needed could make estimate_box_runtime.jl faster.

Done! To reduce runtime and memory consumption, I estimated runtime with a metric different than number of active pixels. Instead, I computed a "hardness" score by multiplying the number of sources to optimize by the number of RCFs in each box. Since there's an upper bound on the of active pixels per source-rcf pair this is not a bad approximation, and it's much faster. Not every source appears in every RCF of course---multiplying by the number of RCF just scales the hardness to account for the average density of images.
The total hardness units for all of SDSS is 9,621,754,068. The most difficult quarter degree is in stripe 82. It has 2,773,047 hardness units --- about 0.2%, or 1/3500, of the overall work. If we run more than 3500 processes, that task would be a bottleneck. (We can drop down to .25x.25 degree boxes if necessary.) If we exclude stripe 82, the most difficult task has 1,237,428 hardness.
I posted the all the task difficulties here.

Plotting them up, the vast majority of patches look like they are under 500,000 Regier units.

Nice graph! We can subdivide the larger tasks into quarters (recursively, if necessary) to keep any task from taking too long.


Add not_broadcast matcher

Thanks, the spec is failing because the let is outside the describe block. Can you fix and I can merge.

@krisleech thanks, updated

Very useful, thanks.


Revert "stream resync to indexer crawler"

Reverts bluesky-social/indigo#826
(I pressed merge on the wrong PR)

no need for this, the prior PR merge was fine and doesn't need to be reverted


Do not attempt the scale tests

Signed off by @jnpacker

Sonar to skip controller_test.go which is a scale test and requires an endpoint

/lgtm

/lgtm


Add Chrome Timeline Demangler

I’d appreciate any feedback about the wording or the tool!

I've sent you a contributor invite, so feel free to merge 🙂

I primarily use Firefox and don't have experience with Chrome devtools, but this looks great 👍

Updated!

This is probably not the right place to report issues, but I've tried to upload this in the Firefox version and got RuntimeError: name is null.
profile.json.zip

Oops, didn’t realize the names could be null. Fixed!


add sensors for other meter fields

rtlamr reports several useful fields for the r900, like "leakNow" when there's an active leak detected by a water meter. having this be something like a binary sensor would be really useful because then I could make a HA alert trigger on it, for example.
I'm not sure if other meters / protocols have similarly useful fields besides the consumption value, but it might be useful to also report those too as new sensors?

It looks like those sensors do get exposed to home assistant, but they are disabled by default.   Go into the devices and Leak and Leak Now are under diagnostic section as disabled.  Just enabled them from there.

It should be an MQTT device.   Settings > Devices & Services > Devices (tab) > ( Water Meter )
?ro>S4ay9d~88RZ.QR


[models] OBJ file failing to load on RPi

Please, before submitting a new issue verify and check:

[x] I tested it on latest raylib version from master branch
[x] I checked there is no similar issue already reported
[x] My code has no errors or misuse of raylib

Issue description
All the examples consisting of obj files are unable to load the OBJ files. The model defaults to black cube.
My System:
PRETTY_NAME="Raspbian GNU/Linux 9 (stretch)"
NAME="Raspbian GNU/Linux"
VERSION_ID="9"
VERSION="9 (stretch)"
ID=raspbian
ID_LIKE=debian
HOME_URL="http://www.raspbian.org/"
SUPPORT_URL="http://www.raspbian.org/RaspbianForums"
BUG_REPORT_URL="http://www.raspbian.org/RaspbianBugs"

Terminal Log
pi@raspberrypi:~/raylib/examples $ ./models/models_yaw_pitch_roll
INFO: Initializing raylib 2.6-dev
INFO: UPSCALING: Required screen size: 800 x 450 -> Display size: 800 x 480
INFO: Display device initialized successfully
INFO: Display size: 800 x 480
INFO: Render size: 800 x 480
INFO: Screen size: 800 x 450
INFO: Viewport offsets: 0, 30
INFO: GPU: Vendor:   Broadcom
INFO: GPU: Renderer: VideoCore IV HW
INFO: GPU: Version:  OpenGL ES 2.0
INFO: GPU: GLSL:     OpenGL ES GLSL ES 1.00
INFO: Number of supported extensions: 14
WARNING: [EXTENSION] VAO extension not found, VAO usage not supported
INFO: [EXTENSION] NPOT textures extension detected, full NPOT textures supported
INFO: [EXTENSION] ETC1 compressed textures supported
INFO: [EXTENSION] Debug Marker supported
INFO: [TEX ID 1] Texture created successfully (1x1 - 1 mipmaps)
INFO: [TEX ID 1] Base white texture loaded successfully
INFO: [SHDR ID 1] Shader compiled successfully
INFO: [SHDR ID 2] Shader compiled successfully
INFO: [SHDR ID 3] Shader program loaded successfully
INFO: [SHDR ID 3] Default shader loaded successfully
INFO: Internal buffers initialized successfully (CPU)
INFO: Internal buffers uploaded successfully (GPU)
INFO: OpenGL default states initialized successfully
INFO: [TEX ID 2] Texture created successfully (128x128 - 1 mipmaps)
INFO: [TEX ID 2] Default font loaded successfully
INFO: Opening input device [/dev/input/event0] (mouse )
WARNING: Gamepad device could not be opened, no gamepad available
WARNING: Could not change keyboard mode (SSH keyboard?)
WARNING: [resources/angle_gauge.png] Image could not be loaded
WARNING: Texture could not be created
WARNING: [resources/background.png] Image could not be loaded
WARNING: Texture could not be created
WARNING: [resources/pitch.png] Image could not be loaded
WARNING: Texture could not be created
WARNING: [resources/plane.png] Image could not be loaded
WARNING: Texture could not be created
INFO: [TEX ID 3] Texture created successfully (192x192 - 1 mipmaps)
INFO: [FBO ID 1] Framebuffer object created successfully
INFO: [resources/plane.obj] Model loaded successfully in RAM (CPU)
WARNING: [resources/plane.obj] No meshes can be loaded, default to cube mesh
INFO: [VBOs] Mesh uploaded successfully to VRAM (GPU)
WARNING: [resources/plane.obj] No materials can be loaded, default to white material
WARNING: [resources/plane_diffuse.png] Image could not be loaded
WARNING: Texture could not be created
INFO: [TEX ID 0] Mipmaps generated automatically
INFO: Target time per frame: 16.667 milliseconds
INFO: [VBO ID 5] Unloaded model vertex data from VRAM (GPU)
INFO: [VBO ID 6] Unloaded model vertex data from VRAM (GPU)
INFO: [VBO ID 7] Unloaded model vertex data from VRAM (GPU)
INFO: [VBO ID 8] Unloaded model vertex data from VRAM (GPU)
INFO: Unloaded model data from RAM and VRAM
INFO: [FBO ID 1] Unloaded render texture data from VRAM (GPU)
INFO: [TEX ID 2] Unloaded texture data from VRAM (GPU)
INFO: [TEX ID 1] Unloaded texture data (base white texture) from VRAM
INFO: Window closed successfully

Just updated my RPI to latest Raspbian 10 (buster), compiled raylib master branch for PLATFORM=PLATFORM_RPI and compiled examples. It worked ok for me.
ok, now looking at this more carefully I found your issue... you're calling:
pi@raspberrypi:~/raylib/examples $ ./models/models_yaw_pitch_roll

Consequently your working directory is /raylib/examples instead of /raylib/examples/models and your /resources/ directory is not found.

@raysan5 Thank you, I also didn't see it.


feat(jellyfish-api-core): Add tests for dusd burn attribute keys.

What this PR does / why we need it:
Which issue(s) does this PR fixes?:

Fixes #https://github.com/DeFiCh/ain/pull/1357
Additional comments?:

is extract out the test to /mn/setGov.dfip2206a.test.ts better??
btw im doing this way... LOL
https://github.com/JellyfishSDK/jellyfish/blob/fd5a3c30b362044506544e6d3ddfe0518c22866f/packages/jellyfish-api-core/__tests__/category/masternode/setGov.dfip2206f.test.ts


Error while downloading the dataset

When I try to download the dataset, I get a KeyError about content-length. What might be the cause of it? Below is error message:
$ python download.py --datasets celebA
Traceback (most recent call last):
  File "download.py", line 121, in <module>
    download_celeb_a('./data')
  File "download.py", line 65, in download_celeb_a
    filepath = download(url, dirpath)
  File "download.py", line 30, in download
    filesize = int(u.headers["Content-Length"])
  File "/home/guel/anaconda/lib/python2.7/rfc822.py", line 393, in __getitem__
    return self.dict[name.lower()]
KeyError: 'content-length'

There are new sources on http://mmlab.ie.cuhk.edu.hk/projects/CelebA.html
Google Drive:
https://drive.google.com/open?id=0B7EVK8r0v71pWEZsZE9oNnFzTm8
Baidu:
http://pan.baidu.com/s/1eSNpdRG


Bug: New mini window mode (version 1.11.2-3086) does not seem to respect --iconsize

In testing the latest preview build and invoking the new "mini" window size with the following code:
/usr/local/bin/dialog --title none --message "Something is being updated. Please wait" --mini --icon /System/Library/CoreServices/Installer.app --iconsize 16 --position topright --ontop --progress 0

I get this. The icon is not scaled to 16 pixels as I specified. I tried other integers as well (32, 64, etc), but the icon always appears at the same default size, it looks like.

For contrast, this is the same code with --mini replaced with --small. Icon is scaled to 16 pixels.

Correct. Thus is by design. Mini mode is mini in more than just size, it also only supports a subset of commands, one of those is iconsize.

Ah, I see. Got it then, thanks!
Hmm. I wonder if it would be possible to have a default icon size for mini a bit smaller? It's a bit... large for such a small window mode. I can submit a FR is this is possible to do.


Changed the submit button and social media buttons hover effects

Pull Request Template

Added hover effects to submit button and changed effects of social media buttons in index.html
URL of the issue: https://github.com/zero-to-mastery/Keiko-Corp/issues/498

Summarize what this PR fixes:-
Fixes #

Changed the hover effects for submit button in 'never miss an update' section of index.html.
Changed the social media buttons to look bold instead of italics when hovered.

Checklist
(Add an x between the brackets to check the items)

[ x] I have summarize what this PR fixes above
[ ] I have provided the issue ID/URL above
[ ] I have not added Bootstrap or jQuery and used correct styling guide.
[x ] This PR fixes only the issue mentioned above (create separate PRs for separate issues)
[x ] I was the first one to claim the issue or I created the issue - I created the issue

This style does not align with the mockup. Colors should be changed using the css variables in global.css and it should look similar to this


Add Content-Length header

I created Pull Request in my issue.
https://github.com/MicrosoftDocs/azure-docs/issues/58216

@mym-kingbob : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@mym-kingbob it looks like we did already make this fix in a PR to the private repo (120832).  Thanks for taking the time to submit a PR, but there will probably be a conflict since the fix was already made. #please-close


Suport for Scintilla as a text editing widget

Scintilla (https://www.scintilla.org/) is a great text editing component and it would be fantastic if there would be a lightweight cross platform rust GUI library supporting it.
Since Scintilla is usually used with GTK, I can imagine that this would be a difficult undertaking. I did however noticed a couple of years back FLTK port of Scintilla (https://github.com/McNeight/Fl_Scintilla), so I guess one could at least conclude that it is feasible.
FLTK does come with its own text editing widget, but it is nowhere as advanced as Scintilla. It would of course be perfectly understandable to consider having something more feature rich as out of scope for fltk-rs.

It might be possible to wrap Fl_Scintilla like how fltk-flow wraps Fl_Flow, via the fltk-build crate. I might give it a go sometime (as a separate crate).
However it would be out of scope for the fltk crate itself.

This is a proof of concept here:
https://github.com/MoAlyousef/fltk-scintilla

I currently don't have much time to improve the api and expose safe wrappers. I'll probably get back to it at some point, or if anyone is interested in championing the effort, please go ahead.

Just wanted to thank you for the effort, his is fantastic. It definitely covers cases where not having easy access to a more advanced editing component was a deal breaker before.


sphinx conversion -- sql magic

I was able to convert the SQL magic page, but the hchart extension wouldn't load. Any ideas? Kept getting this error:
UsageError: Line magic function %hchart not found.

I was able to convert the SQL magic page, but the hchart extension wouldn't load. Any ideas? Kept getting this error:
UsageError: Line magic function %hchart not found.

Nvm. I just had to change the extension name from hchart to chart.

Please update your PR with the latest merge. Arash corrected the pylint issue.

Please update your PR with the latest merge. Arash corrected the pylint issue.

@afard can you please look why this PR is failing?


improve configure.sh and add .gitignore

Solve the problem that TF_VERSION does not update with tensorflow.version when one updates tensorflow afterward.
Add .gitignore

Did you test this script? Are you able to build a pip package from it?

@peisun1115
If you use build.sh or Docker, this PR is not necessary.
After running build.sh without Docker, my local python3.6.12 becomes python3.6.7 ......

Right, that is automatically handled. I do not remember I install python out of the docker. I will merge this

@peisun1115
I run the python script used by Docker locally... it doesn't matter from 3.6.12 to 3.6.7 until now.
I have tested it. It is OK.


Feat/alias exact match

Closes #145

Codecov Report

Merging #148 (3a61468) into master (4e3772a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   78.65%   78.65%
=======================================
  Files          29       29
  Lines        1054     1054
  Branches      189      189
=======================================
  Hits          829      829
  Misses        225      225

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e3772a...3a61468. Read the comment docs.


PMID:12442907

abnormal chromatin organization during G2 phase

abnormal chromatin organization during mitotic G2 phase FYPO:0007628


Stickyfill not used?

The "sticky" examples still refer to the Stickyfill even though they're not currently used. Source
It didn't turn up an error because there aren't any elements with the sticky class to be set up using setupStickyfill.
I'm not sure whether you still plan to use stickyfill or not, but thought I'd flag that the code as it's written currently appears to be unnecessary.

thanks for spotting, removed!


[17.06] Make plugin removes more resilient to failure

Backport fixes:

moby/moby#33830 Make plugin removes more resilient to failure
moby/moby#33944 Fix plugin remove dir name after rename.

ugh, actually looks like it needs to be rewritten for 17.06;
03:41:11 [init] Building: bundles/17.06.0-ce/binary-daemon/dockerd-17.06.0-ce
03:41:58 [init] # github.com/docker/docker/plugin
03:41:58 [init] plugin/manager.go:194: undefined: system in system.EnsureRemoveAll
03:42:10 [init] $ ssh-agent -k

This depends on https://github.com/moby/moby/pull/31012, which was on the 17.06 milestone, but actually missing in the branch / release - see https://github.com/docker/release-tracking/issues/39

Just added one more commit to this PR to get the import system line in. Looks like that import line was added by https://github.com/docker/docker-ce/commit/8508f49 but don't want to take the entire commit.

@andrewhsu I think you need to include https://github.com/moby/moby/pull/33944/commits/4bf263c19873718394f8161dbc020bf4be30f9d6 here (see https://github.com/docker/docker-ce/pull/91#discussion_r125486950).

i've cherry-picked the git commit from moby/moby#33944
$ git cherry-pick -s -x -Xsubtree=components/engine 4bf263c

ping @andrewhsu ready to go?

ping @andrewhsu


Refactor jsg wrappable for oilpan

Updates the jsg Wrappable implementation around oilpan.

TODOs on this PR:

[ ] jsg/function.test.c++ failure
[ ] jsg/jsg-test.c++ failure

Superseded by #199


Pass mth5 station_metadata to transfer_function_header

Gary's transfer_function_header class contains station_header objects for local and remote sites.  We probably want to emulate this but let's take our "station_header" object to me an mth5 station metadata object.

whoops, I meant to create this under aurora.  Not sure how to transfer the issue as I can't find the aurora repo when I push the "Transfer Issue" button at the bottom.  @lheagy  can we take a look at this on Wednesday time permitting?

@kkappler This can be a duplicate for Aurora but can reside here.  Suggest we add a metadata object, like Processing that would take in the objects that need to be passed from the timeseries to the transfer function:

Station (mt_metadata.timeseries.Station)
Remote References list of mt_metadata.timeseries.Station objects
Channels used, "runs" used, etc.
Processing parameters

The metadata has been handled for this case to make a self describing transfer function.


fusion tests from test_opt

test_llama remains in external_test_opt because model.forward calls realize internally.

The models tests take the longest:
1.33s call     test/test_schedule.py::TestSchedule::test_enet
1.25s call     test/test_schedule.py::TestSchedule::test_enet_se
1.17s call     test/test_schedule.py::TestSchedule::test_convnext
0.97s call     test/test_schedule.py::TestSchedule::test_resnet
0.64s call     test/test_schedule.py::TestSchedule::test_vit

I think we can keep them in external_test_opt.py and run once in GPU=1.
This picks the the more specific fusion tests from external_test_opt.


DEPTRAC_INTERNAL___PHPSTORM_HELPERS\object

I have "qossmic/deptrac": "^2.0.1" in my dev requirements. Every time I use the object type, PhpStorm imports DEPTRAC_INTERNAL\___PHPSTORM_HELPERS\object first. This is extremely annoying.
I understand that autocomplete is a PhpStorm issue. However I want to ask, why are you including PhpStorm stubs into the package instead of requiring jetbrains/phpstorm-stubs via composer (PhpStorm automatically removes this package from autocompletion)? And why do you prepend a custom namespace for object?

If you don't want PHPStorm to suggest DEPTRAC_INTERNAL\___PHPSTORM_HELPERS\object, you can mark vendor/qossmic/deptrac/vendor as excluded
https://www.jetbrains.com/help/phpstorm/excluding-files-from-project.html
Maybe vendor/qossmic/deptrac/deptrac.phar should also be excluded, not sure about this one

@jon-ht , I know this technique and I use use it for var directory in Symfony projects. However, you cannot exclude vendor/qossmic/deptrac/vendor, because PhpStorm already automatically excludes vendor packages (see, the whole deptrac directory is yellow):

Even if I manually exclude the qossmic directory (so that it's red now), the autocomplete remains. Probably because PhpStorm treats vendor directory differently. I also don't want to exclude the qossmic directory, because I need autocomplete for writing custom Deptrac collectors.

@vudaltsov Indeed, I didn't had your issue because I'm working on a mono-repo, so my path to deptrac was actually my-app/vendor/qossmic/deptrac/vendor. PHPStorm seems to only exclude root vendors by default
And what about https://www.jetbrains.com/help/phpstorm/excluding-files-from-project.html#exclude-libraries-from-indexing ? Is it what you mention with red color ?


acceleration normalized to direction of motion

Hi, thanks for this excellent library. My use case is to detect acceleration values relative to the direction of motion in a car. In other words, the device could be kept in any orientation but I'd like the x/y/z to be normalized in the direction of motion. What might be the best settings to use ? So far I am using the following options (which is not producing intended results - depending on how my phone is oriented acc x/y/z report different values when I move)
Also note that in the retuned value, I am seeing absolute:false - my understanding reading the documentation is this should be true since  I am using WORLD base
I am testing on iPhone 7 (latest OS update)
let gyroNormArgs = {
    logger: function (data) {console.log ("Gyr-log:"+JSON.stringify(data))},
    gravityNormalized:true,
    orientationBase:GyroNorm.WORLD,
    frequency:1000,
    screenAdjusted:true,
  }

Hello there,
I am glad to see the library being used in different use cases.
Couple of remarks to clarify the use of parameters and the return values:
The parameters you pass are correct.
orientationBase only efects the deviceOrientation values; alpha, beta and gamma values. The acceleration values stay with respect to the axis' of the device. These values are returned like this from the JS API and GyroNorm passes them to your application.
What you are trying can be achieved by some calculation. Something like... getting the orientation world based and accelerationIncludingGravity and using it to calculate the acceleration in world axis. Gyronorm does not contain such calculation at the moment. So you need to implement on your side. You can also implement within Gyronorm and send a pull-request ;) I'll be more than glad to merge.
One last thing: you need to use the accelerationIncludingGravity values.
Let me know if anything is not clear.
Cheers,
Doruk

Thanks @dorukeker
I did a bit of reading. It looks like if I normalize the values of gx gy and gz (including gravity) with the rotation matrix, I'll get earth co-ordinates.
Can you check if this look ok to you and if I need to do any other conversions with the data your library provides?
rotationMatrix = getRotationMatrix(data.dm.alpha, data.dm.beta, data.dm.gamma)
accEarthX = rotationMatrix[0] * data.dm.gx + rotationMatrix[1] * data.dm.gy + rotationMatrix[2] * data.dm.gz
accEarthY = rotationMatrix[3] * data.dm.gx + rotationMatrix[4] * data.dm.gy + rotationMatrix[5] * data.dm.gz
accEarthZ = rotationMatrix[6] * data.dm.gx + rotationMatrix[7] * data.dm.gy + rotationMatrix[8] * data.dm.gz

And getRotationMatrix is:
// credit:https://stackoverflow.com/a/36662093/1361529
getRotationMatrix(alpha, beta, gamma) {
  _z = alpha;
  _x = beta;
  _y = gamma;

  cX = Math.cos( _x );
  cY = Math.cos( _y );
  cZ = Math.cos( _z );
  sX = Math.sin( _x );
  sY = Math.sin( _y );
  sZ = Math.sin( _z );

  out[0] = cZ * cY + sZ * sX * sY,    // row 1, col 1
  out[1] = cX * sZ,                   // row 2, col 1
  out[2] = - cZ * sY + sZ * sX * cY , // row 3, col 1

  out[3] = - cY * sZ + cZ * sX * sY,  // row 1, col 2
  out[4] = cZ * cX,                   // row 2, col 2
  out[5] = sZ * sY + cZ * cY * sX,    // row 3, col 2

  out[6] = cX * sY,                   // row 1, col 3
  out[7] = - sX,                      // row 2, col 3
  out[8] = cX * cY                    // row 3, col 3

return out
};

Okay, so I ran this code, and it looks like I am not doing it right. When I hold the phone perpendicular to  the floor, I see gravity on Y. If I lay it flat, I see gravity on Z.
Here is an example of the output when holding the phone perpendicular to my table
2017-09-10 08:29:15.055417-0400 TripData[6027:2061953] *** EARTH DATA X=2.2943273132349287, Y=9.534772910579633 Z=-0.1909652413948768
2017-09-10 08:29:16.056623-0400 TripData[6027:2061953] *** EARTH DATA X=-4.630849432456284, Y=8.649729578711812 Z=-0.24064860082132544
2017-09-10 08:29:17.056643-0400 TripData[6027:2061953] *** EARTH DATA X=-1.9508303521644637, Y=9.600077721852953 Z=-0.305562876437087
2017-09-10 08:29:18.071261-0400 TripData[6027:2061953] *** EARTH DATA X=-0.017282406466729114, Y=9.58242138261782 Z=-2.0579362877347576
2017-09-10 08:29:19.073391-0400 TripData[6027:2061953] *** EARTH DATA X=-0.7562998091905141, Y=9.67232563579337 Z=-1.4375769175222382
2017-09-10 08:29:20.088494-0400 TripData[6027:2061953] *** EARTH DATA X=3.014021667418713, Y=9.29277056085625 Z=-0.8659033962365313

Here is an example of holding the phone flat on my table, facing up
2017-09-10 08:30:29.273031-0400 TripData[6030:2062680] *** EARTH DATA X=0.3213661367499145, Y=-0.30880129933902706 Z=-9.710152705476727
2017-09-10 08:30:30.282963-0400 TripData[6030:2062680] *** EARTH DATA X=-0.8330555159493345, Y=-0.35403901361236245 Z=-9.678061525129234
2017-09-10 08:30:31.288030-0400 TripData[6030:2062680] *** EARTH DATA X=-0.25170701382938837, Y=-0.3217699399585805 Z=-9.711684080782703
2017-09-10 08:30:32.293732-0400 TripData[6030:2062680] *** EARTH DATA X=-0.30199915826823015, Y=0.9298620373824118 Z=-9.681056404124517
2017-09-10 08:30:33.294888-0400 TripData[6030:2062680] *** EARTH DATA X=0.31606866523909627, Y=0.3622808441701922 Z=-9.70845266707323
2017-09-10 08:30:34.301882-0400 TripData[6030:2062680] *** EARTH DATA X=-0.24551748429710923, Y=0.9452959329108171 Z=-9.671108352413734
2017-09-10 08:30:35.284257-0400 TripData[6030:2062680] *** EARTH DATA X=0.9266874306677086, Y=-0.854412045314473 Z=-9.648364134021065
2017-09-10 08:30:36.301415-0400 TripData[6030:2062680] *** EARTH DATA X=0.8516336100663204, Y=0.4447390757116382 Z=-9.682826413229794

Hello there @arjunroychowdhury
Wow that is some maths. Frankly speaking I am not very good at the matrix operations.
Having said that I see in the code you are using the angles from the deviceMotion
let alpha = gdata.dm.alpha;
let beta = gdata.dm.beta;
let gamma = gdata.dm.gamma;

Which are the change rates in these angles; not actual orientation. The orientation are in the deviceOrientation. Like this:
let alpha = gdata.do.alpha;
let beta = gdata.do.beta;
let gamma = gdata.do.gamma;

// do instead of dm

Can this be what you are looking for? Also try to switch orientation base as you mentioned. (WORLD or GAME) Not sure which one should give you the result you are looking for.
Cheers,
Doruk

Hi All,
Did you figure this out?
I'll be attempting this as well and would like to save some some time and troubles.

@arjunroychowdhury @ziqbal Anyone figure this out?

@marcusx2 I never found the time to check the last feedback from dorukeker. Maybe it works.
My advice is that if you're targeting a single device then you should use whatever is provided on that platform, otherwise a generic library to do absolute orientation on all devices and platforms is going to be a serious PITA. Especially when libraries become out of date and "features" become deprecated and obsolete.


[release-v0.26] remove ansible

Signed-off-by: Matthias Wessendorf<EMAIL_ADDRESS>

/assign @mgencur

/retest
On Tue 16. Nov 2021 at 17:41, openshift-ci[bot] @.***>
wrote:

@matzew https://github.com/matzew: The following tests failed, say
/retest to rerun all failed tests or /retest-required to rerun all
mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/49-images c5d6ae0
https://github.com/openshift-knative/eventing-kafka/commit/c5d6ae011b7e03ed877dee9fb6ae46c53b2471ce
link
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift-knative_eventing-kafka/441/pull-ci-openshift-knative-eventing-kafka-release-v0.26-49-images/1460648500340461568
true /test 49-images
ci/prow/47-e2e-aws-ocp-47 c5d6ae0
https://github.com/openshift-knative/eventing-kafka/commit/c5d6ae011b7e03ed877dee9fb6ae46c53b2471ce
link
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift-knative_eventing-kafka/441/pull-ci-openshift-knative-eventing-kafka-release-v0.26-47-e2e-aws-ocp-47/1460648500147523584
true /test 47-e2e-aws-ocp-47
ci/prow/48-images c5d6ae0
https://github.com/openshift-knative/eventing-kafka/commit/c5d6ae011b7e03ed877dee9fb6ae46c53b2471ce
link
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift-knative_eventing-kafka/441/pull-ci-openshift-knative-eventing-kafka-release-v0.26-48-images/1460648500264964096
true /test 48-images
ci/prow/47-images c5d6ae0
https://github.com/openshift-knative/eventing-kafka/commit/c5d6ae011b7e03ed877dee9fb6ae46c53b2471ce
link
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift-knative_eventing-kafka/441/pull-ci-openshift-knative-eventing-kafka-release-v0.26-47-images/1460648500181078016
true /test 47-images
ci/prow/49-e2e-aws-ocp-49 c5d6ae0
https://github.com/openshift-knative/eventing-kafka/commit/c5d6ae011b7e03ed877dee9fb6ae46c53b2471ce
link
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift-knative_eventing-kafka/441/pull-ci-openshift-knative-eventing-kafka-release-v0.26-49-e2e-aws-ocp-49/1460648500298518528
true /test 49-e2e-aws-ocp-49
ci/prow/48-e2e-aws-ocp-48 c5d6ae0
https://github.com/openshift-knative/eventing-kafka/commit/c5d6ae011b7e03ed877dee9fb6ae46c53b2471ce
link
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift-knative_eventing-kafka/441/pull-ci-openshift-knative-eventing-kafka-release-v0.26-48-e2e-aws-ocp-48/1460648500223021056
true /test 48-e2e-aws-ocp-48
Full PR test history
https://prow.ci.openshift.org/pr-history?org=openshift-knative&repo=eventing-kafka&pr=441.
Your PR dashboard
https://prow.ci.openshift.org/pr?query=is:pr+state:open+author:matzew.
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openshift-knative/eventing-kafka/pull/441#issuecomment-970455478,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABGPTR5TM7JJY6XON654VLUMKCR7ANCNFSM5IETXWWQ
.

--
Sent from Gmail Mobile

/test 48-e2e-aws-ocp-48

/lgtm


Issue Creating New Branch From Existing Branch

How can i create a new branch in a repo that branches from an existing commit (as opposed to starting out empty)? Lets say i have a repo test with the following commits already in it:
BRANCH              ID                                 PARENT                             STARTED             FINISHED            SIZE
                    6a6e996150f94524be38f5999363ae8a   6d594ceb2d454be583ac020b68884851   11 minutes ago      10 minutes ago      2.818 MiB
master              939b4ca31d1a4671a7d81557663706c4   35610db5c5e44e37b4ebfb41bcb1fcad   13 minutes ago      13 minutes ago      2.818 MiB
dev                 6d594ceb2d454be583ac020b68884851   <none>                             15 minutes ago      14 minutes ago      2.818 MiB
master              35610db5c5e44e37b4ebfb41bcb1fcad   <none>                             15 minutes ago      15 minutes ago      2.818 MiB

As you can see, the most recent commit in that repo has the commit labeled dev as its parents. This was straight forward to do via pachctl start-commit test -p 6d594ceb2d454be583ac020b68884851.
However, if I try to start and new commit while specifying both the branch name and the parent like pachctl start-commit test new_branch -p 6a6e996150f94524be38f5999363ae8a I got the following error:
branch new_branch already exists as 6a6e996150f94524be38f5999363ae8a, can't create with 6a6e996150f94524be38f5999363ae8a as parent

Then, when i try to run pachctl list-commit test I get:
commit 72b09176bd864f268f0c8b45d9afed45 not found in repo test

and I don't get the list of commits in the repo.
Now, reading the docs of the go api, it does seem like specifying both a branch name and a parent id shouldn't really work. But, my question is, how can I start a commit that has an existing branch as its parent, but gets assigned a new branch name?
Also, I think its a bug that i can't view the list of commits after making this ill formed request (i can still make new commits).
Here's my pachyderm version:
COMPONENT           VERSION
pachctl             1.1.0-ba43f31be2be7e013f1373eac6581f9093f37f48
pachd               1.1.0-ba43f31be2be7e013f1373eac6581f9093f37f48

Also, thanks for being so responsive on the issue reports.

Hi @alexsbromberg, sorry you hit this. The way you were trying to make a branch is supposed to work but I think you hit a bug in pfs. We're about to merge in a big refactor of pfs that we've been working on that I'm hoping will fix this issue because it handles branches in a different and much more consistent way. I'm going to add this issue to the 1.2 to milestone so that we remember to check that it works before shipping 1.2.

Just to add to jd's comments ... I'll explain how this might look once 1.2 lands.
Most often users are going to want to start a new commit at the HEAD of a branch. This workflow looks like this:
$pachctl create-repo test
$pachctl start-commit test master
e8b9e6bc428547aa9bd0286068eee3e1
$pachctl finish-commit test master
$pachctl list-commit test
BRANCH              ID                                 PARENT              STARTED             FINISHED            SIZE
master              e8b9e6bc428547aa9bd0286068eee3e1   <none>              10 seconds ago      4 seconds ago       0 B
$pachctl start-commit test master
46e286b0c88e439c88937a9370b01366
$pachctl finish-commit test master
$pachctl list-commit test
BRANCH              ID                                 PARENT                             STARTED              FINISHED             SIZE
master              46e286b0c88e439c88937a9370b01366   e8b9e6bc428547aa9bd0286068eee3e1   23 seconds ago       17 seconds ago       0 B
master              e8b9e6bc428547aa9bd0286068eee3e1   <none>                             About a minute ago   About a minute ago   0 B

In the other case (where you want to start a new branch off of a commit) you specify both the branch and the commitID as you did above:
$pachctl start-commit test dev -p 46e286b0c88e439c88937a9370b01366
49309f5820e3439f81e21c2dad30571f
$pachctl finish-commit test dev
$pachctl list-commit test
BRANCH              ID                                 PARENT                             STARTED             FINISHED            SIZE
master              46e286b0c88e439c88937a9370b01366   e8b9e6bc428547aa9bd0286068eee3e1   6 minutes ago       6 minutes ago       0 B
master              e8b9e6bc428547aa9bd0286068eee3e1   <none>                             7 minutes ago       7 minutes ago       0 B
dev                 49309f5820e3439f81e21c2dad30571f   46e286b0c88e439c88937a9370b01366   11 seconds ago      5 seconds ago       0 B

Cool. I'll check that it works on my end too once that refactor is merged in.

Refactor is merged onto master now, and the new behavior is supported


[flutter_tools] threadStateError: Bad state: StreamSink is closed

From beta 2.11.0-1.0.pre
Thread 0 main threadStateError: Bad state: StreamSink is closed
at _StreamSinkImpl.add(io_sink.dart:134)
at _StdSink.add(stdio.dart:327)
at DaemonStreams.send(daemon.dart:185)
at DaemonConnection.sendErrorResponse(daemon.dart:290)
at Domain.handleCommand.<anonymous closure>(daemon.dart:282)
at _rootRunBinary(zone.dart:1450)
at _CustomZone.runBinary(zone.dart:1342)
at _FutureListener.handleError(future_impl.dart:171)
at Future._propagateToListeners.handleError(future_impl.dart:752)
at Future._propagateToListeners(future_impl.dart:773)
at Future._completeWithValue(future_impl.dart:575)
at _completeOnAsyncReturn(async_patch.dart:262)
at EmulatorDomain.getEmulators(daemon.dart)
at <asynchronous gap>(async)

Updated from 3.0.0:
Command flutter daemon
StateError: Bad state: StreamSink is closed
at _StreamSinkImpl.add(io_sink.dart:134)
at _StdSink.add(stdio.dart:327)
at DaemonStreams.send(daemon.dart:218)
at DaemonConnection.sendErrorResponse(daemon.dart:301)
at Domain.handleCommand.<anonymous closure>(daemon.dart:283)
at _rootRunBinary(zone.dart:1450)
at _CustomZone.runBinary(zone.dart:1342)
at _FutureListener.handleError(future_impl.dart:162)
at Future._propagateToListeners.handleError(future_impl.dart:778)
at Future._propagateToListeners(future_impl.dart:799)
at Future._completeWithValue(future_impl.dart:566)
at _completeWithNoFutureOnAsyncReturn(async_patch.dart:277)
at EmulatorDomain.getEmulators(daemon.dart)
at <asynchronous gap>(async)

Best case fix would be to register a callback that fires when the stream is closed.
Also, we should add an error handler to the stream, if there is not already one.


It should be possible to set up a node without starting calico (felix/bird/confd)

Operators may want to choose their own way of deploying the calico-node components i.e. felix, bird and confd. We currently only support using a docker container, but we do have native packages in our openstack repos. In addition to running the components natively, operators may want to use other container formats such as rkt.
The expected way that we'll support this is to add a new calicoctl node --runtime=<RUNTIME> command. It can take the following values

docker - which is the current and default behaviour
none - which doesn't run felix/bird/confd at all.

It future we may add other options.

+1


Codeowners update post fork

Summary

How did you test this change?

Issue

Hi Mike, are you plan to merge this pr to fork-lacework-go-sdk repo instead of main go-sdk repo?

Hi Mike, are you plan to merge this pr to fork-lacework-go-sdk repo instead of main go-sdk repo?

No, this was a GitHub UI mistake on my part

Cool. I'll close this PR.


Rejected By Valve Software

Rejected by Valve Software for a Software Engineer position because i was young. (when i was 19)

Submitting this as a PR .

Thank you!! Falling behind on the issues :/

Rejected by Valve as a web developer because I wasn't "senior enough". They drew this conclusion by just looking at my resume and didn't even give me an interview. 4 months later, I got a job as a senior web engineer at Heroku.


Allow renaming variables via a new options.rename function

This pull request adds a rename option expecting a function that, given the name of a variable in the final output, can return a modified name. As shown in the README example, I wanted to convert names to camel case for easier usability.
If a developer chooses to rename destructively such that two distinct variables could have the same name only the last value is included in the JSON output.

Hi guys, I created a fork to update this repo! https://github.com/jairmedeiros/scss2json


fix: Update the URL of the component feed

Resolves #4902
Depends on https://github.com/microsoft/botframework-components/pull/412! Do not merge til that one does.
Description
Change the URL for package manager's default feed to point at the new component repo.

Coverage increased (+0.004%) to 54.64% when pulling dd25b6ba00af4f246a2e4f674028b6ac3b80d7b1 on benbrown/4902 into 046906419ce02e1b90c398b4a1a0abde749dfbc1 on main.


WIP GH140: Add integration tests

fixes #140

Example usage
.\build.ps1 -Target 'Run-Integration-Tests'

@devlead this looks really good to me!
Are you happy to remove the WIP?

@gep13 yes ;)

@devlead do you think we should run these integration tests on AppVeyor for each commit?

@gep13 perhaps if not pr? so merge to develop/master will trigger it?

Yeah, perhaps.  I will take a look at how long it takes, and then make a decision about how to go forward.  Thanks for adding this though!

@devlead your changes have been merged, thanks for your contribution 👍


Setting Global Style makes control not get theme

What steps will reproduce this issue?
If I set something like this in App.xaml:
            <Style TargetType="ScrollBar" BasedOn="{StaticResource {x:Type ScrollBar}}">
                <Style.Triggers>
                    <Trigger Property="Orientation" Value="Horizontal">
                        <Setter Property="Height" Value="30"/>
                    </Trigger>
                    <Trigger Property="Orientation" Value="Vertical">
                        <Setter Property="Width" Value="30"/>
                    </Trigger>
                </Style.Triggers>
            </Style>

Expected outcome
I would expect the control to still use the MahApps.Metro theme applied as its using "BasedOn" but unfortunately its not themed, its back to its default colors. If I set that Style in the ScrollViewer.Resources of an existing ScrollViewer it works fine. But I would like to have this Application Wide.
--
Environment

MahApps.Metro v1.2.4
Windows 10
Visual Studio 2015
.NET Framework 4.5

Your based in should be pointed to MetroScrollBar
BasedOn="{StaticResource {x:Type MetroScrollBar}}"

What namespace is that in?

@Memphizzz the styles located in
<ResourceDictionary Source="pack://application:,,,/MahApps.Metro;component/Styles/Controls.Scrollbars.xaml" />

and the keys are globally set in Controls.xaml
    <Style BasedOn="{StaticResource MetroScrollBar}" TargetType="ScrollBar" />
    <Style BasedOn="{StaticResource MetroScrollViewer}" TargetType="ScrollViewer" />

@Memphizzz it's also possible to override width or height of the scrollbars globally without restyling the styles
you must only override these keys after the MahApps resource dictionaries in your App.xaml.
    <System:Double x:Key="MetroScrollBarHeight">14</System:Double>
    <System:Double x:Key="MetroScrollBarWidth">14</System:Double>

    <System:Double x:Key="HorizontalScrollBarRepeatButtonWidth">14</System:Double>
    <System:Double x:Key="VerticalScrollBarRepeatButtonHeight">14</System:Double>

It's recommend to use the latest pre-release, cause there was a bug with these styles and keys usage.

Works great! Thank you!


#import "librtmp/log.h" file not found

I am trying to implement kick flip IOS SDK in my project but after setup pod file its show me error message
<Bolts/BFTask.h> file not found
after searching on internet i found replace
pod 'Kickflip'
to
pod 'Kickflip', :git => 'https://github.com/zummenix/kickflip-ios-sdk'
but after doing that it give me new error message
import "librtmp/log.h" file not found
so please tell me what should do to solve this problem?

I'm getting the same error.. Have you solved it yet?

not yet but if i find anything i will let you know.

I have solve this error from below step :
$ git clone git@github.com:Kickflip/kickflip-ios-example.git
$ cd kickflip-ios-example
$ git submodule update --init
$ pod install
and then change podfile to this
pod 'Kickflip', :path => 'Submodules/kickflip-ios-sdk/Kickflip.podspec'
#pod 'Kickflip' ,  :git => 'https://github.com/zummenix/kickflip-ios-sdk'
pod 'YapDatabase', '~> 2.5'
pod 'SSPullToRefresh', '~> 1.2'
pod 'UIAlertView-Blocks', '~> 1.0'
pod 'VTAcknowledgementsViewController', '~> 0.10'
pod 'BButton', '~> 4.0'
and also change on 'KFHLSWriter.m'
#import "librtmp/log.h" to #import "log.h"
and comment this two lines
RTMP_LogSetLevel(RTMP_LOGALL)
RTMP_LogSetLevel(RTMP_LOGCRIT)

@chrisballinger - Still an issue

i  dont find any "KFSecrets.h" file

@developertechnostacks You have to create it from scratch.

can u show me a steps or doc of that

https://github.com/Kickflip/kickflip-ios-example#kfsecretsh

@chrisballinger - still an issue


Nuxt 3 Error with custom directives

System info

Operating System: Linux
Node Version:     v20.16.0
Nuxt Version:     3.13.0
CLI Version:      3.13.0
Nitro Version:    2.9.7
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      compatibilityDate, devtools, modules, runtimeConfig
Runtime Modules<EMAIL_ADDRESS>Build Modules:    -

Reproduction
Create new nuxt project, install @vueuse/motion and add it to nuxt modules, then create custom directive
runtimeConfig: {
public: {
motion: {
directives: {
'pop-bottom': {
initial: { opacity: 0, y: 100 },
enter: {
opacity: 1,
y: 0,
transition: { duration: 400 },
},
}
}

then create something like this and you get this

Describe the bug
Cannot use custom animation in Nuxt3 with vueuse/motions directive
Additional context
No response
Logs
No response

Issue seems to be happening here https://github.com/vueuse/motion/blob/eb7c01de524be8fef787148ee146aa780dd3692d/src/directive/index.ts#L24
it seems that we are receiving a vue ref object and so the stucturedClone fails. I'm guessing it's a simple fix by using a toRaw(variants) on that line

Not sure who to tag here but i have an open PR that potentially fixes this issue here https://github.com/vueuse/motion/pull/221
@Tahul @BobbieGoede

This should be resolved thanks to @hajiskyy's contribution! You can install a preview release containing the fix like so npm i https://pkg.pr.new/@vueuse/motion@221 until a new full release has been published.


fix: remove order from DocumentInfo as apparently unneeded (fix #5245)

Includes migration, although I admit that I didn't run the reverse to see if I got that right.

closing this to get a better one based on codesprint discussion


Remove version: Google.Chrome.Canary version 133.0.6836.0

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://dl.google.com/release2/chrome/adzfdl6tz7pim5z7hfs4bjy3sota_133.0.6836.0/133.0.6836.0_chrome_installer.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 923)


COMP: Fix MacOS Python packages

Notebooks test fails, and wheels are missing for MacOS ARM 3.8, but this is a substantial improvement in CI. Merging.


Minutes from previous workshops

Romain, I think you also had minutes from the Marseille meeting, didn't you? If yes, can you add those too? Apart from that good structure.

OK I added minutes from two workshops in Marseille, and displayed the minutes as MD files.
hope you'll like it ;)

Thanks Romain - good minutes


TST: fix test bug w/ convolve method

Fixes #7348

I'm running into a CI bug.
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/nose/failure.py", line 39, in runTest
    raise self.exc_val.with_traceback(self.tb)
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/nose/loader.py", line 418, in loadTestsFromName
    addr.filename, addr.module)
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/nose/importer.py", line 47, in importFromPath
    return self.importFromDir(dir_path, fqname)
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/nose/importer.py", line 94, in importFromDir
    mod = load_module(part_fqname, fh, filename, desc)
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/imp.py", line 234, in load_module
    return load_source(name, filename, file)
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/imp.py", line 172, in load_source
    module = _load(spec)
  File "<frozen importlib._bootstrap>", line 693, in _load
  File "<frozen importlib._bootstrap>", line 673, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 665, in exec_module
  File "<frozen importlib._bootstrap>", line 222, in _call_with_frames_removed
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/scipy/ndimage/tests/test_c_api.py", line 8, in <module>
    from scipy.ndimage import _ctest_oldapi
ImportError: dynamic module does not define module export function (PyInit__ctest_oldapi)

All tests pass except the Python 3.5 test.

Failure is unrelated and is happening on all CIs. Thank @stsievert

Just ran into this because I didn't backport it. After looking into it I'm pretty sure that this fix is not correct and that _fftconvolve_valid doesn't make sense. It returns False also for float64 input, because of the last check:
if _numeric_arrays([volume, kernel]):
    return False

I'll open a new issues about checking _fftconvolve_valid, and will open a new PR with what I think is the correct fix.

PR to fix this up: gh-7517


Package woofmark not found

I wanted to add woofmark to my project with Bower but when i tried
->
'Bower install woofmark --save' return Package woofmark not found
Did you forgot something or is it just a random bug ?

Fixed. Thanks!

For documentation purposes, it is helpful to, at some point in the future, be able to get to know how you fixed the bug; So it would be great if you could reference, the commit, pull request or issue number.

There's none of that. I just did:
bower register woofmark https://github.com/bevacqua/woofmark.git


Allow cursor to scale in any direction

Hello!
This software is so great. I've had a ton of fun using it, it's been really inspiring. Like @nlebellier, I noticed that it's not possible to select parts of the grid by holding shift and using the left and up keys - only right and down. I took the comment #117 and did my best to implement it! Hopefully this is something like what you were expecting!
I'm open to all the feedbacks, and will remove my note before the final version, I just figured I would leave it in there while it's being reviewed in case the context is helpful.

This is great! Could you remove the note, and remove the min/max functions, and instead just do the operation inline? I'll merge it after :)

@jcmorrow great ! Thanks for your work !


Code formatter can't remove unused imports in Java

We have a very unique style in Java samples on showing users what imports are needed:
package com.google.cloud.examples.speech.v1;

import com.google.api.gax.longrunning.OperationFuture;
import com.google.cloud.speech.v1.LongRunningRecognizeMetadata;
...
import org.apache.commons.cli.CommandLine;
import org.apache.commons.cli.DefaultParser;
import org.apache.commons.cli.Option;
import org.apache.commons.cli.Options;

public class SpeechTranscribeAsync {
  // [START speech_transcribe_async]
  /*
   * Please include the following imports to run this sample.
   *
   * import com.google.api.gax.longrunning.OperationFuture;
   * import com.google.cloud.speech.v1.LongRunningRecognizeMetadata;
   * import com.google.cloud.speech.v1.LongRunningRecognizeRequest;
   * import com.google.cloud.speech.v1.LongRunningRecognizeResponse;
   * ...
   */

  /**
   * Transcribe a long audio file using asynchronous speech recognition
   *
   * @param localFilePath Path to local audio file, e.g. /path/audio.wav
   */
  public static void sampleLongRunningRecognize(String localFilePath) {
    // ...
  }
  // [END speech_transcribe_async]

  public static void main(String[] args) throws Exception {
    // ...
  }
}

We have this comment showing which imports are needed instead of showing the real import statements on the devsite because:

We would have to show the entire file on the devsite if we show the imports, because otherwise there would be unmatching braces
We didn't want to show imports used only in the main method (apache clis), and inserting region tags between imports would break code formatter

However, this setting causes code formatter to be unable to remove unused imports from this comment showing required imports, because, well it is a comment. Although the generator is trying to be accurate about useful imports, but having code formatter to do another check is always safer.
Proposing:
We are having this ApplicationChooser idea in C#, which is basically a unified entry to the sample project. Each individual sample will not have any main method, and the ApplicationChooser class will decide which sample method to call based on user input.
This way we can get rid of the main method in each sample, and we can show the entire file on the devsite, and we don't need to put imports in a comment.

cc/ @googleapis/samplegen

Let's see whether there are other possible solutions, but the ApplicationChooser sounds like a very reasonable one. We should collect use cases (like this one) for ApplicationChooser, as well as any cons of implementing it to help us decide.

Moved to backlog: https://github.com/googleapis/gapic-generator/wiki/feature-backlog


Unifiy create syntax for operators

Describe the problem you are trying to solve
All create statements in trickle it follows the logic of create <what> <name> <specification> for operators we have create <specification> <what> <name> this makes it easy to get this wrong.
Example:
create script name
script
 <specification>
end

wile for operators it is:
create <specification> operator <name>;

Describe the solution you'd like
We should unify the way we create statements to follow the same conventions for all its invocations.
a solution could be:
create operator <name> as <specification>;
create operator kfc as grouper::bucket;

Notes
This needs an RFC!
If this is an implementation of an RFC provide a URL
to the RFC this enhancement implements.
If this is a major enhancement or contribution an RFC may be required. It is ok to submit an enhancement
first and our core team will assist with major contributions. In general, major contributions should be
discussed with the community before submission.

This is done


[Compose-iOS] - The isSystemInDarkTheme() flag does not set dark theme on iOS

Describe the bug
When using the isSystemInDarkTheme() flag, the theme colors don't change on iOS based on the system appearance.
Affected platforms

iOS

Versions

Kotlin version*: 1.9.0
Compose Multiplatform version*: 1.5.0-rc06 (using material3)
OS version(s)* (required for Desktop and iOS issues):  iOS 16.2 (Simulator Device)
OS architecture (x86 or arm64): x86 Architecture

To Reproduce
Here's a minimal reproducible project based on the compose-multiplatform-ios template.
The theme file is structured as follows:
The commonMain directory has an expect fun declaration for the theme. Here, the useDarkTheme variable is set to isSystemInDarkTheme() flag.
@Composable
expect fun AppTheme(
    useDarkTheme: Boolean = isSystemInDarkTheme(),
    content: @Composable () -> Unit
)

And here's the iosMain actual implementation of the theme:
@Composable
actual fun AppTheme(
    useDarkTheme: Boolean,
    content: @Composable () -> Unit
) {
    val colors = when {
        useDarkTheme -> DarkColors
        else -> LightColors
    }
    MaterialTheme(
        colorScheme = colors,
        content = content
    )
}

I am aware that the app does not change theme during run time but I also face this issue after removing the app from recents, changing the theme and relaunching the app.
Expected behavior
The app theme on iOS should follow system appearance when using the isSystemInDarkTheme() flag.
Screenshots
iOS App with Dark Theme enabled

Android App with Dark Theme enabled

Thanks! Yes, it happends because of this line of code in SwiftUI:
.preferredColorScheme(.light)

https://github.com/dima-avdeev-jb/check-issues-3575/blob/60753355f27810ce3b686650fb2f80d6f0c73939/iosApp/iosApp/iOSApp.swift#L10
You should remove it. Also, we will change our templates soon

Thanks. Should have checked the Swift file as well 😅.

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Implement tests for off_nadir_dataset.py (in challenge_eval)

Similar to #9 and #10 and related to #8

Resolved by #31


Unable to locate appropriate distribution of QtCreator

Ran the installer as
./qt-downloader linux desktop 6.0.3 gcc_64 --opensource --creator
And this is the overall output:
OS type: linux
Target: desktop
Qt version: 6.0.3
Toolchain: gcc_64
Verifying arguments... Done
Unable to locate appropriate distribution of QtCreator

Installed this on Ubuntu <IP_ADDRESS> using Python 3.8
Any ways to work around this?

Confirmed on macOS under pipenv run. Thus, it seems to be not related to environment. Likely, the QtCreator is not found or even absent for this version of Qt. I will investigate it.

This was, apparently, the same issue as in #16. Check the master branch as of ebfd540 commit.

This was, apparently, the same issue as in #16. Check the master branch as of ebfd540 commit.

Thanks! I'm able to see the commit now. Thank you!


Add ability to specify a custom sorting function for a column

Your patch sounds reasonable, but unfortunately it no longer applies cleanly. Please fix that (and maybe PR-73 at the same time since they are bound to be in conflict with this one?) and then I can merge it.

@tbroadley Can you resubmit? Your changes are mostly still good, just don't need the default compare anymore. If you don't have time I'll make your changes on top of master and submit the PR.

@SergeyCherman Sure, I'll fix the merge conflicts right now.

@SergeyCherman Could you please take another look at these changes?

Looks good to me, thanks for the quick turn around!

@mattiash can you take a look and consider a merge and version bump?


Decryption problem for Compress 7000 with new firmware 04.07.05

Describe the bug
Component can't communicate with heatpump
I have tried to reinstall component and HA, without success.
I was not able to run debugscan but did the best I could, see below...
I suspect the new firmware in the heatpump is the problem.
What steps are neccesary to support this?
ERROR:bosch_thermostat_client.gateway.base_gateway:You might have unsuporrted firmware version 04.07.05
INFO:bosch_thermostat_client.bosch_rawscan_cli:Successfully connected to gateway. Found UUID: xxxxxx
ERROR:bosch_thermostat_client.encryption.base_encryption:Unable to decrypt: b"\xf8\xa9\xfc\x99\\\th\xdb\xa1\xb5\x81A\xdep\x9e\xac\xd8\x90\\6*AQ\xe6_\t]oR\xaa\x1f+Yp\xe1\xb0\xa3`\xec\xa8\x0ca\x06zXN\xff\xbbn$\xd9\xf8S\x8e-\x89\x8bo\xa3\xd5'\x10\x83\xedn\xf9s\xcd\xff\xf9\xc0\xdd\xe5 84\xec\xe8\xd5\xa5\x86)W2\x04\x9f\x94f\x90\xbf\xc0\x8a\xb2[\xa5\xc4\xbf8\xa6\xc2\x84\xba\x15\xa6\xc3!\xb8\xb5\x10\xe1#\xc7W,\x82\x0e{\x80[S\xc7Zcgo\xdcB\xd0\xd9\xea\xba#\xf72\x9d\x03\xda\xe4\x95\xbe\xf3#\xe7\xec\x88\xcd\xa9p\xc5\xc4\xf6\xa5\xdb\xe7:\xf2\xc3^\x94I\xfb\x90\xf9\xd5\x03\xfc\x15\xe3\x15\xdev\xc4\xeeP\x14\xae\x00\xae\xf4\xba,%\x99\x16v%F\xb9\x8c\x88\xd4q\xe6n#L\x14]X\xaa\xd7\x9en`\xab!{)w\xd9\xafo\x8a\xa7\xb3\xe0\xe4\x85\xe2Bx\xa0\xc3\xa1" with error: 'utf-8' codec can't decode byte 0xf8 in position 0: invalid start byte
INFO:bosch_thermostat_client.bosch_rawscan_cli:Successfully saved result to file: rawscan.json
(venv) ajn@ubuntu:~/Projects/bosch-thermostat-client-python$

What can I do to help?
rawscan.zip

rawscan is enough. I will add it.
I had only scan of 04.07.05 for RC300 till now, now I can add Compress as well.

Many thanks, brilliant work

new version released. test it and let me know

Great!
Now it works like before the firmware update.
I have this:
Can't update data. Error: URI /heatSources/sensors/collectorInTemp doesn not exist: 403, message='Forbidden', url=URL('http://x.x.x.x/heatSources/sensors/collectorInTemp')
and this:
Can't update data. Error: URI /heatSources/energyMonitoring/startDateTime doesn not exist: 500, message='Internal Server Error', url=URL('http://x.x.x.x/heatSources/energyMonitoring/startDateTime')
and this:
Can't update data. Error: URI /heatSources/systemPressure doesn not exist: 404, message='Not Found', url=URL('http://<IP_ADDRESS>/heatSources/systemPressure')
I think it was like that before, but is it excpected behaviour?

it's probably just your installation which lacks those sensors or there is something bad with Compress  device schema. what do you think @slovdahl ?

Hmm, good question. It looks my Compress 7001i is still running 04.07.03. I'll get back to this whenever my pump updates itself 🙂


Add Java templates

Java templates are part for azure-functions-maven-plugin. This makes it difficult for version controlling Java templates for VS code.

cc: @jdneo

Hi @pragnagopa, please see the discussion here: https://github.com/Microsoft/vscode-azurefunctions/issues/486

@pragnagopa is this still relevant?

Closing. If needed issue can be re-opened.


vc: Version support check is ineffective in createSandbox

Fixes #2311
If major version matches max supported major, we continue comparing the minor version.
Signed-off-by: Ted Yu<EMAIL_ADDRESS>The error along with the original check was actually negated.
Since supportedMajorVersion is 0, the condition was never hit. But the new test exposes the bug.

@tedyu looks good, but can you add some unit tests for this as well.

cloudHypervisor#checkVersion accesses the version field.
Let me see if I can come up with some test.

@jodh-intel
I have added message to the assertion.

@jodh-intel
Thanks for the detailed review.
If you can trigger ubuntu test, that would be nice.

@ericooper
Please review.

/test

@egernst
Please trigger test again.
thanks

/test

The failure in debian test was not related to my PR:
17:39:31 --- FAIL: TestContainerListStatsWithIdSandboxIdFilter (64.59s)
17:39:31     container_stats_test.go:248: Create a pod config and run sandbox container
17:39:31     container_stats_test.go:256: Create container config and run containers in a pod
17:39:31     require.go:794:
17:39:31         	Error Trace:	container_stats_test.go:272
17:39:31         	Error:      	Received unexpected error:
17:39:31         	            	rpc error: code = DeadlineExceeded desc = context deadline exceeded
17:39:31         	Test:       	TestContainerListStatsWithIdSandboxIdFilter

From ubuntu run:
Skipping 2,272 KB..

It seems not all test log was preserved.

@tedyu - at the top of the console log at http://jenkins.katacontainers.io/job/kata-containers-runtime-ARM-18.04-PR/1304/console - you need to click on the 'Full Log' link to take you to http://jenkins.katacontainers.io/job/kata-containers-runtime-ARM-18.04-PR/1304/consoleFull for instance...
Yeah, the size of those full logs still bugs me....

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (7) Failed to connect to <IP_ADDRESS> port 8080: Connection refused
18:10:04 # service "my-service" deleted
18:10:04 # deployment.apps "hello-world" deleted
18:10:04 Failed at 80: bats "${K8S_TEST_ENTRY}"
...
18:10:04 W1205 02:10:04.227663   11187 removeetcdmember.go:61] [reset] failed to remove etcd member: error syncing endpoints with etc: etcdclient: no available endpoints

It seems the failure was not related to my PR.
@jodh-intel
Mind re-triggering the failed tests?
thanks

Looking at other tests, such as ci-cri-containerd, the test runs passed.

@amshinde @egernst
Mind triggering another test run ?
thanks

@lifupan
Can you trigger another test run ?
thanks

/test

/test

@ericooper @egernst
Please review.

@ericooper @egernst @grahamwhaley
The condition for returning error currently is backwards.
This means when supported major version goes to 1, the error would be returned for supported version:
clh.version.Major < supportedMajorVersion

I think we should fix this bug now.

/test

/test

@ericooper @egernst @grahamwhaley
Please take another look.
Thanks

@tedyu You need to gofmt virtcontainers/clh_test.go in place using
gofmt -w virtcontainers/clh_test.go

This is the diff that needs to be applied to make CI happy :
diff --git a/virtcontainers/clh_test.go b/virtcontainers/clh_test.go
index 6e8fb5b7..0cd6f817 100644
--- a/virtcontainers/clh_test.go
+++ b/virtcontainers/clh_test.go
@@ -66,4 +66,4 @@ func TestCheckVersion(t *testing.T) {
                        assert.Error(err, msg)
                }
        }
-}
\ No newline at end of file
+}

@amshinde
I have applied the above diff.
Please take another look.

/test

/test

/test

06:39:46 time="2019-12-10T14:39:46Z" level=error msg="error copying docker://quay.io/crio/busybox:latest to dir:/tmp/jenkins/workspace/kata-containers-runtime-ubuntu-18-04-PR/go/src/github.com/cri-o/cri-o/.artifacts/busybox-image: Error initializing source docker://quay.io/crio/busybox:latest: unexpected http code: 504 (Gateway Timeout), URL: https://quay.io/v2/auth?scope=repository%3Acrio%2Fbusybox%3Apull&service=quay.io"
06:39:46 Error pulling quay.io/crio/busybox

Not related to my change.

/test

/test

/test

/test

From firecracker test output:
Failed at 44: sudo -E PATH="$PATH" bash -c "make crio"

Not related to this PR.

/test

/test

/test

/test vsocks

ping @kata-containers/runtime for review

/test

/test

/test

@bergwolf
Can you take another look ?

/test

/test

/test

/test

@tedyu ping. Any updates? Thanks.

http://jenkins.katacontainers.io/job/kata-containers-runtime-ARM-18.04-PR/1433/  gave me 404
I checked the test result some time back.
I don't think the test failure was related.

/retest ubuntu

/retest ubuntu

From http://jenkins.katacontainers.io/job/kata-containers-runtime-opensuse-15-PR/1073/console :
Stderr: Error unpacking rpm package shadow-utils-2:4.6-9.fc30.x86_64Error: Transaction failed

/retest ubuntu

From http://jenkins.katacontainers.io/job/kata-containers-runtime-opensuse-15-PR/1073/console :
Stderr: Error unpacking rpm package shadow-utils-2:4.6-9.fc30.x86_64Error: Transaction failed

This is a known issue, please refer to: https://github.com/kata-containers/runtime/issues/2580

From the centos test suite:
[3] Running command '/usr/bin/docker [docker update --cpus -3.000000 JVebMIP8aULrf5MRY3cdscfKYyhGB3]'
[3] command failed error 'exit status 1'
[3] [docker update --cpus -3.000000 JVebMIP8aULrf5MRY3cdscfKYyhGB3]
[3] Timeout: 120 seconds
[3] Exit Code: 1

/retest

From ARM ubuntu build log:
21:17:13 go<EMAIL_ADDRESS>invalid pseudo-version: does not match version-control timestamp (2019-02-10T22:04:43Z)
21:17:13 Makefile:8: recipe for target 'build' failed
21:17:13 make: *** [build] Error 1

Not related to the PR.
@fidencio @raravena80
Can you take another look ?

Hi~ @tedyu ARM failure fixed by https://github.com/kata-containers/tests/pull/2435. And I've rebuilt it. ;)

/retest

From power8 build:
panic: ERROR: Docker-like container engine not accessible to current user:  (error exec: "podman": executable file not found in $PATH)

goroutine 1 [running, locked to thread]:

/retest

@Pennyzct @raravena80
All tests passed

@fidencio @devimc @jodh-intel
Please review.

@bergwolf, can you confirm all your comments were addressed?

@tedyu Was this change backported to stable?

I have been busy with day job and haven't a chance to do the backport.


Argument masking (standalone)

This is the port of the main branch masking feature

Based on the wrong branch

No this is the one :)

Thanks! I found out that I needed to apply these patches to another version, which I did here.


fix meshing with gmsh

Topo solid required for gmsh meshing but Topo shape read by step file.

in the moment use Wall example (dodo_wall.py in examples/Wall) for testing

@YuXHe15 I added the solid_amker function and transfer the Topo_shape to Topo_solid in the meshing class, but the mesh creating still doesn't work. Could you please have a look.

Hi Annika, yes I ll look into this issueOn 13. Oct 2023, at 08:28, aradermacher @.***> wrote:
@YuXHe15 I added the solid_amker function and transfer the Topo_shape to Topo_solid in the meshing class, but the mesh creating still doesn't work. Could you please have a look.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>


[Feature Request] Dropdown adds clicks to disappear events

Existing Component
Yes
Component Name
Dropdown
Description
Dropdown增加点击消失的事件

Sorry, we have no plan to support this.


Align previous/next page flag with relay standard.

This is related to https://github.com/graphql/graphql-relay-js/issues/58 and bi-directional pagination.
I know that the changes in Connection.connectionFromSeq are kind of cumbersome so any help on improving those would be very much appreciated.
Also, I tried to document why the changes in the tests with small comments just to clarify (and honestly, those comments helped me to debug the offsets computations).
Thanks in advance.

Thanks for the contribution.
Can you check the compilation error on older scala version: https://github.com/sangria-graphql/sangria-relay/actions/runs/4767885408/jobs/8494878854?pr=225 ?

Does this PR fix https://github.com/sangria-graphql/sangria-relay/issues/35?

And https://github.com/sangria-graphql/sangria-relay/issues/11?

This PR fixes https://github.com/sangria-graphql/sangria-relay/issues/35
Regarding, https://github.com/sangria-graphql/sangria-relay/issues/11 it seems to me that those cases were already handled correctly prior to this PR. This test is related.

Thanks a lot for the help!!


Expose key instead of value within transpile method

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior
The transpile method of the TranslocoTranspiler interface is declared as follows:
transpile(value: any, params: HashMap<any>, translation: HashMap): any;

Expected behavior
Instead, the transpile method of the TranslocoTranspiler interface is declared as follows:
transpile(key: TranslateParams, params: HashMap<any>, translation: HashMap): any;

Minimal reproduction of the problem with instructions
Create a custom transpiler as stated in the Transloco documentation: https://netbasal.gitbook.io/transloco/hack-the-library/transloco-transpiler.
What is the motivation / use case for changing the behavior?
Exposing key instead of value would be more useful.
Example use case: I would like to do some custom processing (with the help of a custom service injected within the transpiler) to determine whether to add a prefix or suffix to the key and provide a different translation at the end. Currently, I am doing a workaround where I get the key based on the provided value, but this is not optimal and would lead to problems in case of duplicate values within a translation file.
As an additional argument, by knowing the key we can get to the value via translation[key], but not vice versa (at least not directly and robustly).

@bevkoski maybe you could use the interceptor for your usecase?

@itayod, thanks for the input. After a closer look at the interceptor, I can say that it is indeed applicable for my use case. Sorry for not checking more thoroughly earlier - I assumed that the timing of the interception would not work for me. In case you believe that exposing the key within the transpiler is not a good idea, feel free to close this issue.

@bevkoski I'm glad that solved your issue 🙂