Restart Process does not work while terminate process terminates process correctly

Brief description of your issue
GT3.exe process when Restarting does not work as it will say the requested operation requiresres elevation while terminating the process works correctly.
Steps to reproduce (optional)

locate GT3.exe process in SystemInformer and selecting it  (GT3 is the Swiftpoint P3 Control Panel which can be downloaded from https://drivers.swiftpoint.com/pengrip3/public/SwiftpointP3-V<IP_ADDRESS>.msi)
Right click then Restart
SystemInformer will confirm restarting process

Restart button is clicked
SystemInformer returns with unable to restart GT3.exe
The requested operation requires elevation

Expected behavior (optional)
It was supposed to terminate the process and then restarting it.
Terminating the process works when selecting terminate instead of restart.
Actual behavior (optional)
It is not terminating the process.   There was something similar that happened with Process Hacker 3 Nightly Build after Windows 10 was updated which was fixed by dmex after it was reported on the wj32 forums.
Environment (optional)
System Informer Nightly Build Version 3.0.6215
Windows 11 Professional Edition x64 22H2 Build 22623.1325 Insiders Beta Channel

There's another issue here:

Process identifiers are recycled on Windows and you should never see PIDs with high numbers (6627544) unless some program is leaking process handles. You need to find the program and update/uninstall it before your machine crashes from a lack of resources.

It's high because I terminated the process and manually started it again as this is after 8 days of uptime as that process is one that I rarely restart except a few years ago.  The other processes were also done because I killed explorer.exe and some of the system tray icons disappeared and I had to restart the processes so the system icons came back.  I think the other reason is I have a process that is run as a batch script that repeatedly runs every 5 seconds to pull stock quotes so it's more real time to get around the 15 minute intervals an ofcourse I have a few hundred tabs in Google Chrome.   But regardless, it seems I only have the issue mentioned with GT3.exe and also NJCOM32.exe and NJCOM64.exe (NJStar Communicator), all of which are the latest versions and I need both of them as GT3.exe controls the button assignments of my Swiftpoint ProPoint mouse snd NJStar Communicator is for Chinese/Japanese/Korean input and decoding.  The other issue is because this is on a Dell XPS 15 9570 laptop is I am using S3 standby mode which has well known BIOS/firmware bug that has a permanent runaway process of 10% on one core toggling around which others have found except Dell had not fixed it.  Not much I can do about that one except reboot after a few weeks of uptime.  This is mentioned in detail here:
https://www.reddit.com/r/Dell/comments/91313h/xps_15_9570_c_state_bug_after_s3_sleep_and_modern/

Can you give me the steps of how to use System Informer to find what's causing the issue of finding where the leaks are coming from?
But anyways, this is after rebooting using System Informer v3.0.6226 which I had been using before the system restarted:

how to use System Informer to find what's causing the issue of finding where the leaks are coming from?

You can when it's caused by a process but not when it's caused by kernel drivers.

Add the Handles column and look for processes with high numbers then check the Handles tab of the process for any Process handles named (terminated):

The Tools > Processes menu for Gray entries:

Search for terminated using the Find Handles or DLLs window:

I actually did 1 before I saw your response after 3 days of uptime, the total handles were at 2,000,000 (2 Million)+ with two processes when it was causing the system to be sluggish and the Processes, Threads, and Handles showing 0's for the three on the bottom right as well as the System Infomation - CPU window as mentioned in the other opened issue.

msmoney.exe - Microsoft Money Sunset Edition which is the last version they put out as part of discontinuing the product had 700,000 handles listed
DellFanManagement.exe which is a GUI for managing the fans on Dell laptops had 200,000 handles listed

I manually closed msmoney.exe as it always backs up the portfolio which takes a minute and then restarted it.
I restarted DellFanManagement.exe
At this point, the system is fast again with the total handles on the system at 200,000
And the Processes, Threads and Handles all show the correct count instead of 0.
I will need to go through steps 1-3 from your last comment when it happens again as I just rebooted.  But anyways, when you mentioned Step 2 above:
"2. The Tools > Processes menu for Gray entries:"
I do not have a Processes option under the Tools menu.

GT3.exe process when Restarting does not work as it will say the requested operation requiresres elevation while terminating the process works correctly.

This program has UIAccess privileges and requires elevation while termination doesn't require elevation. The restart option now checks for UIAccess and restarts the process when you have the privileges👍

Updated to System Informer 3.0.6328 and it seems GT3.exe as well as things that worked with Restart before are now showing this:

GT3.exe process when Restarting does not work as it will say the requested operation requiresres elevation while terminating the process works correctly.

This program has UIAccess privileges and requires elevation while termination doesn't require elevation. The restart option now checks for UIAccess and restarts the process when you have the privileges👍

Currently on v3.0.6397 and these are the results from testing:
GT3.exe displays the message as mentioned in https://github.com/winsiderss/systeminformer/issues/1621#issuecomment-1472109241
The processes that correctly restarted in System Informer v3.0.6328 and earlier also would no longer Restart and display the "A required privilege is not held by the client" which is the same thing GT3.exe shows.

In v3.0.6397 Restart works corre

GT3.exe process when Restarting does not work as it will say the requested operation requiresres elevation while terminating the process works correctly.

This program has UIAccess privileges and requires elevation while termination doesn't require elevation. The restart option now checks for UIAccess and restarts the process when you have the privileges👍

Currently on v3.0.6397 and these are the results from testing: GT3.exe displays the message as mentioned in #1621 (comment)
The processes that correctly restarted in System Informer v3.0.6328 and earlier also would no longer Restart and display the "A required privilege is not held by the client" which is the same thing GT3.exe shows.

In v3.0.6397, this process when restarted worked correctly but in v3.0.6427:

The original process in v3.0.6427 that had the restart problem when restarted:

Fixed in latest update 👍

Fixed in latest update 👍

Using System Informer v3.0.6433
It works for everything but with GT3.exe, it's a little bit weird for the original GT3.exe that runs from Windows starting up as the video probably explains it better than I can:
https://user-images.githubusercontent.com/78993393/229268415-72f9c7ab-3bf2-4cdb-8c31-ccd9b7dda13d.mp4
So basically PID 19792 GT3.exe is what is running from Windows system startup, when Restart is selected,
it appears to be terminating PID 19972  GT3.exe but then it starts up GT3.exe as PID 11116 then it starts up a 2nd GT3.exe as PID 22040 and then the origininal PID 19792 is terminated and killed but the other two GT3.exe's as PID 11116 and PID 22040 appears to terminate at the same time.
Since it is terminated, I manually run the GT3.exe process which is known as Swiftpoint P3 Control Panel on the Windows Start Menu as seen below and the behavior is completely different and works correctly:
https://user-images.githubusercontent.com/78993393/229268768-428216fc-8ea5-4b7c-bc01-8a16e02e6034.mp4
This time GT3.exe is PID 23704, when Restart is selected, the original PID 23704 GT3.exe  is terminated while at the same time, the new process PID 60272 is started.

Windows Start Menu ... the behavior is completely different and works correctly

The restart option is essentially cloning the existing process parameters and not creating a new process like the start menu does... GT3.exe is also manifested with UIAccess=TRUE and these processes cannot be created without using ShellExecute and/or custom services or modifying security policies - something we're not going to support.
I'll take another look but the restart option will probably get disabled for UiAccess processes.

Interesting...  I remember a few years ago, using the exact same version of GT3.exe, Process Hacker 3.x was able to restart correctly.  I guess if you can't get it working, it's not that big of a deal since to be honest, it's still in the system tray even after Explorer crashes or restarted so it's not one of the processes I need to regularly restart.  There used to be a NJCOM32.exe which is the process started that calls NJCOM64.exe which is NJSTAR Communicator that Restart would not work on so I always just highlighted and terminate both processes and then manually restart the NJCOM32.exe but it seems like with the last thing you did with #1621, I can now restart NJCOM32.exe and it will restart correctly.  Regardless, thanks for atleast looking into it and for making SI such a awesome tool!


Connections dropping every day

I'm creating this new issue because I'm not sure if it's the same problem happening on the issue https://github.com/Azure/azure-signalr/issues/402.
Two or three times per day our logs are flooded with error messages related to the Azure SignalR service.
Checking the Metrics page, we saw that at the same time the number of connections drops. Then the connections begin to increase again.

And we are not seeing any error on the client side.
These are the error messages:
15:52:46.808 [53] ERR Microsoft.Azure.SignalR.ServiceConnectionBase -> Connection e34eab1c-34bf-46fb-bc07-31d2843fa0fb to the service was dropped.
System.Net.WebSockets.WebSocketException (0x80004005): The remote party closed the WebSocket connection without completing the close handshake. ---> System.Net.WebSockets.WebSocketException (0x80004005): The remote party closed the WebSocket connection without completing the close handshake.
   at System.Net.WebSockets.ManagedWebSocket.ThrowIfEOFUnexpected(Boolean throwOnPrematureClosure)
   at System.Net.WebSockets.ManagedWebSocket.EnsureBufferContainsAsync(Int32 minimumRequiredBytes, CancellationToken cancellationToken, Boolean throwOnPrematureClosure)
   at System.Net.WebSockets.ManagedWebSocket.ReceiveAsyncPrivate[TWebSocketReceiveResultGetter,TWebSocketReceiveResult](Memory`1 payloadBuffer, CancellationToken cancellationToken, TWebSocketReceiveResultGetter resultGetter)
   at System.Net.WebSockets.ManagedWebSocket.ReceiveAsyncPrivate[TWebSocketReceiveResultGetter,TWebSocketReceiveResult](Memory`1 payloadBuffer, CancellationToken cancellationToken, TWebSocketReceiveResultGetter resultGetter)
   at Microsoft.AspNetCore.Http.Connections.Client.Internal.WebSocketsTransport.StartReceiving(WebSocket socket)
   at System.IO.Pipelines.PipeCompletion.ThrowLatchedException()
   at System.IO.Pipelines.Pipe.GetReadResult(ReadResult& result)
   at System.IO.Pipelines.Pipe.GetReadAsyncResult()
   at Microsoft.Azure.SignalR.ServiceConnectionBase.ProcessIncomingAsync()

15:53:13.358 [73] ERR Microsoft.Azure.SignalR.ServiceConnection -> Error while sending message to the service.
Microsoft.Azure.SignalR.Common.ServiceConnectionNotActiveException: The connection is not active, data cannot be sent to the service.
   at Microsoft.Azure.SignalR.ServiceConnectionBase.WriteAsync(ServiceMessage serviceMessage)
   at Microsoft.Azure.SignalR.ServiceConnection.ProcessOutgoingMessagesAsync(ServiceConnectionContext connection)

15:53:15.870 [197] ERR Microsoft.Azure.SignalR.ServiceConnectionBase -> Service timeout. 30000.00ms elapsed without receiving a message from service.

15:53:31.865 [182] ERR Microsoft.Azure.SignalR.ServiceConnectionBase -> Error receiving handshake response.
System.OperationCanceledException: The operation was canceled.
   at System.Threading.CancellationToken.ThrowOperationCanceledException()
   at System.IO.Pipelines.Pipe.GetReadResult(ReadResult& result)
   at System.IO.Pipelines.Pipe.GetReadAsyncResult()
   at Microsoft.Azure.SignalR.ServiceConnectionBase.<ReceiveHandshakeResponseAsync>d__58.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Azure.SignalR.ServiceConnectionBase.<HandshakeAsync>d__56.MoveNext()

Today, we saw two new messages when the connections dropped:
16:21:02.385 [124] ERR Microsoft.Azure.SignalR.ServiceConnection -> Error while sending message to the service.
System.InvalidOperationException: Internal server error.
   at Microsoft.Azure.SignalR.ServiceConnectionBase.WriteAsync(ServiceMessage serviceMessage)
   at Microsoft.Azure.SignalR.ServiceConnection.ProcessOutgoingMessagesAsync(ServiceConnectionContext connection)

16:21:02.284 [40] ERR Microsoft.Azure.SignalR.ServiceConnection -> Error while sending message to the service.
System.InvalidOperationException: Internal server error.
   at Microsoft.Azure.SignalR.ServiceConnectionBase.<WriteAsync>d__46.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Azure.SignalR.ServiceConnection.<ProcessOutgoingMessagesAsync>d__14.MoveNext()

Versions:

JavaScript client: 1.1.2
Microsoft.AspNetCore.SignalR: 1.1.0
Microsoft.Azure.SignalR: 1.0.6

Could you email me your instance name and subscription id for me to check the service side log?

@vicancy Just sent to you the email

We are also seeing this error in our app service logs. I will email our app instance name if you do not mind taking a look at it too, @vicancy

I have a web application in production and cannot suddenly connect to our SignalR service at all.
Wonder if this could be related?

We started seeing this same error on 2/28/2019. There were no changes made to the environment. It's been happening 3 - 5 times per day and forces us to restart our AppService to reconnect.
We are currently working on a patch that will isolate all the signalr related startup into its own function with the hope that we can "self-heal" these drops without interrupting user sessions.
Is there any quick configuration/startup change that may help keep this connection stable in the meantime?
Happy to provide more details if it helps troubleshoot.

We’ve identified an issue in our load-balancer that it reloads frequently which leads to persistent connections drop. We’ve rolled out the hotfixes to all the impacted instances.

@vicancy We are not seeing errors in our logs anymore. Thank you again for your help.

I am closing the issue. Please reopen it when there are still issues.

@vicancy We're seeing the same Microsoft.Azure.SignalR.Common.ServiceConnectionNotActiveException errors from the host app communication to the Azure SignalR service periodically (and most of the other error messages noted above are recorded by the clients connected to the host).  We just had 2 events in the last hour that dumped all the connections off.  Did the hotfixes that were made apply to everyone, or only those complaining of the issue noted here?
Version
Microsoft.Azure.SignalR 1.0.6

@jasonkirby All the influenced instances should be patched already. Would you minding sending me your instance name for a check?

@vicancy I sent you an email yesterday with the requested info.

@vicancy Errors are ongoing.  Did you need any further info?

Hi Jason @jasonkirby , I noticed that all your server connections came from one app server. Could you check if there were any events took place from app server side such as app server restart, IIS recycle, high CPU usage, etc? When server connection drops, client will experience connection drops.
I looked into the latest events of your instance. I can see twice all server connection drops on 2019-03-18,  which were 2019-03-18T11:23:26 and 2019-03-18T23:24:58, and once on 2019-03-19 at 01:28:21 UTC.
From our log, we can see that:

2019-03-18T11:23:26: all server connections don't receive heartbeat from app server side and closed the server connection. Doubt if it is caused by app server side.
2019-03-18T23:24:58: internally we experience short network connectivity issue connecting to internal service. Should be recovered very soon.
2019-03-19T01:28:21, one of our internal service was doing OS patching which can cause server connection drops. Should be recovered very soon.

As the connections between client and Service, and between AppServer and Service are persistent connections, they may experience network connectivity issues. In the Server SDK, we have “Always Reconnect” strategy to server connections. As the best practice, we also encourage users to add continuous reconnect logic to the clients with a random delay time to avoid massive simultaneous requests to the server.
The Load Balancer related instability should have been fully addressed, on regular basis there are service new version releases, and sometimes the Azure wide OS patching or upgrades or occasionally our dependent services’ interruption. These may bring in a very short period of service disruption, but as long as client side has the disconnect/reconnect mechanism, the impact is minimal like any client-side caused disconnect-reconnect.
If you have very strict availability requirement scenarios, we can further discuss about your specific service and scenarios, and what we can do to help.

Hi @vicancy ,
Regarding number 1, I'm not seeing anything in the Application insight logs / metrics of the App server at that time, perhaps I'm not looking in the right place or right way.
The clients do have reconnection code and will typically recover on their own.  I do need to get the random time delay added back in however as I lost that with some refactoring I did a couple weeks back.
The host app server is catching the Microsoft.Azure.SignalR.Common.AzureSignalRNotConnectedException in the Serilog entries recorded to Azure Log Analytics (not from one of my logging statements, something automatically being logged by the addition of Serilog), but I'm not certain if the clients are realizing that they need to reconnect for a period of time after one of those events.  I'd like to catch that exception myself and manually inform the clients to reconnect.  I just need to figure out where to catch that exception in the app server code to notify them.
We had a new issue overnight where at around 9AM UTC the SignalR service dropped all connections and was still that state when I came into work 5.5 hours later.  Our app server logged almost 31K AzureSignalRNotConnectedException during that time while the clients were trying to reconnect.  I ended up restarting the SignalR service and the app server to get it going again.
Could you look into the logs on your end to see if you can tell what may have occurred there?  That's the first time anything like that has happened.  All other issues previously noted have been transient.
'Server timeout (30000.00ms) elapsed without receiving a message from the server' errors are the other thing we've been seeing more of lately.
We develop a point of sale legacy application that we have lifted and shifted to the cloud (running in RDS) that the SignalR tech is being used to communicate between that and an on prem application handling local hardware devices performing things like integrated credit card processing and barcode scanning.  Any extended periods of downtime leave our customers potentially unable to operate their business and are very impacting to them.
Transient failures are unavoidable of course, but we're trying to minimize them and automatically recover as quickly as we can.  We're still in the initial roll out phase for the solution to a limited number of customers.
Your help is greatly appreciated.
Thanks

Hi @jasonkirby We are actively investigating the issue, will let you updated once we have any findings.

Hi @jasonkirby is there any other connection related errors observed from your app server side during that 5.5 hours? AzureSignalRNotConnectedException happens when client negotiates with app server however app server finds no server connections available.
Could you help to verify that

within these 5.5 hours, is there any log indicating that the SDK is trying to reconnect to the Azure Service? In our SDK, we have logic that SDK should always reconnect at most every 1 minute, if it is not reconnecting, there must be a bug in our SDK's reconnect logic.
If SDK is always trying to reconnect, could you provide the error message why the connection failed to establish? We don't find any server connection logs from the service side during that period.

Or you can provide us logs within the 5.5 hours for us to investigate.

Hi @vicancy I have sent you an email with a zipped CSV dump of the log tables from that 5.5 hour time period.
Let me know if you need anything else, or if there is some specific logging that I have missed.
Thanks

@vicancy I just sent another email containing the local client exceptions from the HubConnection.Closed event handler.  I just realized I had those filtered out in the previous custom log dump and they may be useful.

Also experiencing this issue in #497


hardcode mapping from new to old core backend

TODO

change hardcode links from cart/checkout to use "11" SKU (inverse map)
add option map to any other products, simple or configurable, that will be used in demo

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs:

Before: https://main--{repo}--{owner}.hlx.live/
After: https://--{repo}--{owner}.hlx.live/

Closing - we opted to just fork this repo and have two UI repos each pointing to a diff backend.


Correct changelog version title

Add space between ## and version. The title was previously not displaying correctly because of the lack of space.
Could not find where the problem was but it is probably in the gen-changelog.sh file

I signed it!


[noup] ED25519 Vetrification via PSA crypto

ED25519 image verification using PSA_CRYPTO, NRF_SECURITY and NRF_OBERON.

Please rebase.

Replaced by https://github.com/nrfconnect/sdk-mcuboot/pull/323


Updated to add a see also section

Description
Updated to add a see also section in the api docs
Related Issues
Fixes #51971
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I signed the [CLA].
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].

[x] No, no existing tests failed, so this is not a breaking change.

Instead of doing multiple pull requests, can you combine them all into one? e.g. https://github.com/flutter/flutter/pull/64082, https://github.com/flutter/flutter/pull/64083, https://github.com/flutter/flutter/pull/63866 all could be one PR since they are all doing the same thing.


Configure count by X-FORWARDED-FOR address ?

When an application is behind a reverse proxy, we want to count by x-forwarded-for rather than by source IP.
Do you think of a way to make it configurable for this library?

Forget about it, it's already managed by gin and that was just me misusing it ;)


Windows compile error

I've got an error when I was trying to compile bgfx in Windows. This is the following error:
C:\Users\rauls\AppData\Local\JetBrains\Toolbox\apps\CLion\ch-0\172.3544.40\bin\cmake\bin\cmake.exe --build C:\Users\rauls\CLionProjects\Litecraft\cmake-build-debug --target litecraft -- -j 2
[  6%] Built target pvrtc
[ 20%] Built target bx
[ 26%] Built target squish
[ 33%] Built target edtaa3
[ 33%] Built target etc1
[ 33%] Built target Boost_system
[ 40%] Built target iqa
[ 53%] Built target nvtt
[ 53%] Built target etc2
[ 53%] Built target ib-compress
[ 53%] Built target ocornut-imgui
[ 53%] Built target bimg
[ 60%] Built target Boost_filesystem
[ 60%] Building CXX object bgfx/CMakeFiles/bgfx.dir/bgfx/src/renderer_d3d11.cpp.obj
[ 60%] Building CXX object bgfx/CMakeFiles/bgfx.dir/bgfx/src/renderer_d3d12.cpp.obj
In file included from C:\Users\rauls\CLionProjects\Litecraft\bgfx\bgfx\src\renderer_d3d12.h:15:0,
                 from C:\Users\rauls\CLionProjects\Litecraft\bgfx\bgfx\src\renderer_d3d12.cpp:9:
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3d12.h:946:56: error: expected constructor, destructor, or type conversion before ';' token
 DEFINE_ENUM_FLAG_OPERATORS( D3D12_COMMAND_QUEUE_FLAGS );
                                                        ^
In file included from C:\Users\rauls\CLionProjects\Litecraft\bgfx\bgfx\src\renderer_d3d12.h:15:0,
                 from C:\Users\rauls\CLionProjects\Litecraft\bgfx\bgfx\src\renderer_d3d12.cpp:9:
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3d12.h:1598:57: error: expected constructor, destructor, or type conversion before ';' token
 DEFINE_ENUM_FLAG_OPERATORS( D3D12_PIPELINE_STATE_FLAGS );
                                                         ^
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3d12.h:1653:65: error: expected constructor, destructor, or type conversion before ';' token
 DEFINE_ENUM_FLAG_OPERATORS( D3D12_SHADER_MIN_PRECISION_SUPPORT );
                                                                 ^
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3d12.h:1715:52: error: expected constructor, destructor, or type conversion before ';' token
 DEFINE_ENUM_FLAG_OPERATORS( D3D12_FORMAT_SUPPORT1 );
                                                    ^
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3d12.h:1733:52: error: expected constructor, destructor, or type conversion before ';' token
 DEFINE_ENUM_FLAG_OPERATORS( D3D12_FORMAT_SUPPORT2 );
                                                    ^
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3d12.h:1741:68: error: expected constructor, destructor, or type conversion before ';' token
 DEFINE_ENUM_FLAG_OPERATORS( D3D12_MULTISAMPLE_QUALITY_LEVEL_FLAGS );
                                                                    ^
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3d12.h:1876:47: error: expected constructor, destructor, or type conversion before ';' token
 DEFINE_ENUM_FLAG_OPERATORS( D3D12_HEAP_FLAGS );
                                               ^
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3d12.h:1916:51: error: expected constructor, destructor, or type conversion before ';' token
 DEFINE_ENUM_FLAG_OPERATORS( D3D12_RESOURCE_FLAGS );
                                                   ^
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3d12.h:2016:55: error: expected constructor, destructor, or type conversion before ';' token
 DEFINE_ENUM_FLAG_OPERATORS( D3D12_TILE_MAPPING_FLAGS );
                                                       ^
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3d12.h:2026:52: error: expected constructor, destructor, or type conversion before ';' token
 DEFINE_ENUM_FLAG_OPERATORS( D3D12_TILE_COPY_FLAGS );
                                                    ^
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3d12.h:2050:52: error: expected constructor, destructor, or type conversion before ';' token
 DEFINE_ENUM_FLAG_OPERATORS( D3D12_RESOURCE_STATES );
                                                    ^
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3d12.h:2087:59: error: expected constructor, destructor, or type conversion before ';' token
 DEFINE_ENUM_FLAG_OPERATORS( D3D12_RESOURCE_BARRIER_FLAGS );
                                                           ^
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3d12.h:2161:53: error: expected constructor, destructor, or type conversion before ';' token
 DEFINE_ENUM_FLAG_OPERATORS( D3D12_BUFFER_SRV_FLAGS );
                                                     ^
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3d12.h:2414:53: error: expected constructor, destructor, or type conversion before ';' token
 DEFINE_ENUM_FLAG_OPERATORS( D3D12_BUFFER_UAV_FLAGS );
                                                     ^
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3d12.h:2608:46: error: expected constructor, destructor, or type conversion before ';' token
 DEFINE_ENUM_FLAG_OPERATORS( D3D12_DSV_FLAGS );
                                              ^
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3d12.h:2644:48: error: expected constructor, destructor, or type conversion before ';' token
 DEFINE_ENUM_FLAG_OPERATORS( D3D12_CLEAR_FLAGS );
                                                ^
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3d12.h:2653:48: error: expected constructor, destructor, or type conversion before ';' token
 DEFINE_ENUM_FLAG_OPERATORS( D3D12_FENCE_FLAGS );
                                                ^
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3d12.h:2671:58: error: expected constructor, destructor, or type conversion before ';' token
 DEFINE_ENUM_FLAG_OPERATORS( D3D12_DESCRIPTOR_HEAP_FLAGS );
                                                          ^
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3d12.h:2763:57: error: expected constructor, destructor, or type conversion before ';' token
 DEFINE_ENUM_FLAG_OPERATORS( D3D12_ROOT_SIGNATURE_FLAGS );
                                                         ^
In file included from C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3d12.h:6189:0,
                 from C:\Users\rauls\CLionProjects\Litecraft\bgfx\bgfx\src\renderer_d3d12.h:15,
                 from C:\Users\rauls\CLionProjects\Litecraft\bgfx\bgfx\src\renderer_d3d12.cpp:9:
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3d12sdklayers.h:187:50: error: expected constructor, destructor, or type conversion before ';' token
 DEFINE_ENUM_FLAG_OPERATORS( D3D12_DEBUG_FEATURE );
                                                  ^
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3d12sdklayers.h:200:1: error: expected constructor, destructor, or type conversion before 'extern'
 extern RPC_IF_HANDLE __MIDL_itf_d3d12sdklayers_0000_0001_v0_0_c_ifspec;
 ^~~~~~
In file included from C:\Users\rauls\CLionProjects\Litecraft\bgfx\bgfx\src\renderer_d3d12.h:37:0,
                 from C:\Users\rauls\CLionProjects\Litecraft\bgfx\bgfx\src\renderer_d3d12.cpp:9:
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3dx12.h: In function 'UINT64 GetRequiredIntermediateSize(ID3D12Resource*, UINT, UINT)':
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3dx12.h:1359:58: error: expected primary-expression before ')' token
     pDestinationResource->GetDevice(__uuidof(ID3D12Device), reinterpret_cast<void**>(&pDevice));
                                                          ^
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3dx12.h:1359:58: error: '__uuidof' was not declared in this scope
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3dx12.h: In function 'UINT64 UpdateSubresources(ID3D12GraphicsCommandList*, ID3D12Resource*, ID3D12Resource*, UINT64, UINT, UINT, D3D12_SUBRESOURCE_DATA*)':
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3dx12.h:1453:58: error: expected primary-expression before ')' token
     pDestinationResource->GetDevice(__uuidof(ID3D12Device), reinterpret_cast<void**>(&pDevice));
                                                          ^
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3dx12.h:1453:58: error: '__uuidof' was not declared in this scope
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3dx12.h: In function 'UINT64 UpdateSubresources(ID3D12GraphicsCommandList*, ID3D12Resource*, ID3D12Resource*, UINT64, UINT, UINT, D3D12_SUBRESOURCE_DATA*)':
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3dx12.h:1481:54: error: there are no arguments to '__uuidof' that depend on a template parameter, so a declaration of '__uuidof' must be available [-fpermissive]
     pDestinationResource->GetDevice(__uuidof(*pDevice), reinterpret_cast<void**>(&pDevice));
                                                      ^
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3dx12.h:1481:54: note: (if you use '-fpermissive', G++ will accept your code, but allowing the use of an undeclared name is deprecated)
In file included from C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3d11.h:14382:0,
                 from C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3d11_1.h:127,
                 from C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3d11_2.h:66,
                 from C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3d11_3.h:115,
                 from C:\Users\rauls\CLionProjects\Litecraft\bgfx\bgfx\src\renderer_d3d11.h:23,
                 from C:\Users\rauls\CLionProjects\Litecraft\bgfx\bgfx\src\renderer_d3d11.cpp:9:
C:/Users/rauls/CLionProjects/Litecraft/bgfx/bgfx/3rdparty/dxsdk/include/d3d11sdklayers.h:129:1: error: expected constructor, destructor, or type conversion before 'extern'
 extern RPC_IF_HANDLE __MIDL_itf_d3d11sdklayers_0000_0000_v0_0_c_ifspec;
 ^~~~~~
C:\Users\rauls\CLionProjects\Litecraft\bgfx\bgfx\src\renderer_d3d12.cpp: In member function 'void bgfx::d3d12::TextureD3D12::create(const bgfx::Memory*, uint32_t, uint8_t)':
C:\Users\rauls\CLionProjects\Litecraft\bgfx\bgfx\src\renderer_d3d12.cpp:4213:27: error: invalid conversion from 'int' to 'D3D12_RESOURCE_FLAGS' [-fpermissive]
     resourceDesc.Flags |= D3D12_RESOURCE_FLAG_ALLOW_DEPTH_STENCIL;
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:\Users\rauls\CLionProjects\Litecraft\bgfx\bgfx\src\renderer_d3d12.cpp:4214:27: error: invalid conversion from 'int' to 'D3D12_RESOURCE_STATES' [-fpermissive]
     state              |= D3D12_RESOURCE_STATE_DEPTH_WRITE;
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:\Users\rauls\CLionProjects\Litecraft\bgfx\bgfx\src\renderer_d3d12.cpp:4215:28: error: invalid conversion from 'int' to 'D3D12_RESOURCE_STATES' [-fpermissive]
     state              &= ~D3D12_RESOURCE_STATE_PIXEL_SHADER_RESOURCE;
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:\Users\rauls\CLionProjects\Litecraft\bgfx\bgfx\src\renderer_d3d12.cpp:4231:27: error: invalid conversion from 'int' to 'D3D12_RESOURCE_FLAGS' [-fpermissive]
     resourceDesc.Flags |= D3D12_RESOURCE_FLAG_ALLOW_RENDER_TARGET;
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:\Users\rauls\CLionProjects\Litecraft\bgfx\bgfx\src\renderer_d3d12.cpp:4236:27: error: invalid conversion from 'int' to 'D3D12_RESOURCE_FLAGS' [-fpermissive]
     resourceDesc.Flags |= D3D12_RESOURCE_FLAG_DENY_SHADER_RESOURCE;
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:\Users\rauls\CLionProjects\Litecraft\bgfx\bgfx\src\renderer_d3d12.cpp:4237:28: error: invalid conversion from 'int' to 'D3D12_RESOURCE_STATES' [-fpermissive]
     state              &= ~D3D12_RESOURCE_STATE_PIXEL_SHADER_RESOURCE;
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:\Users\rauls\CLionProjects\Litecraft\bgfx\bgfx\src\renderer_d3d12.cpp:4242:27: error: invalid conversion from 'int' to 'D3D12_RESOURCE_FLAGS' [-fpermissive]
     resourceDesc.Flags |= D3D12_RESOURCE_FLAG_ALLOW_UNORDERED_ACCESS;
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mingw32-make.exe[3]: *** [bgfx/CMakeFiles/bgfx.dir/bgfx/src/renderer_d3d12.cpp.obj] Error 1
bgfx\CMakeFiles\bgfx.dir\build.make:262: recipe for target 'bgfx/CMakeFiles/bgfx.dir/bgfx/src/renderer_d3d12.cpp.obj' failed
mingw32-make.exe[3]: *** Waiting for unfinished jobs....
mingw32-make.exe[3]: *** [bgfx/CMakeFiles/bgfx.dir/bgfx/src/renderer_d3d11.cpp.obj] Error 1
bgfx\CMakeFiles\bgfx.dir\build.make:237: recipe for target 'bgfx/CMakeFiles/bgfx.dir/bgfx/src/renderer_d3d11.cpp.obj' failed
mingw32-make.exe[2]: *** [bgfx/CMakeFiles/bgfx.dir/all] Error 2
CMakeFiles\Makefile2:1073: recipe for target 'bgfx/CMakeFiles/bgfx.dir/all' failed
CMakeFiles\Makefile2:3628: recipe for target 'src/CMakeFiles/litecraft.dir/rule' failed
mingw32-make.exe[1]: *** [src/CMakeFiles/litecraft.dir/rule] Error 2
Makefile:1268: recipe for target 'litecraft' failed
mingw32-make.exe: *** [litecraft] Error 2

I tried also to compile it with the examples, but the same error occur.

What compiler are you using? It's possible I'm missing some define for another compiler. I only test with VS2015 on Windows.
I can also add an option to avoid compiling d3d12 altogether. It's not even fully supported by bgfx yet. Should fix this error for you.

I'm using gcc installed with MinGW Installer. I'm trying to compile with it because I use CLion instead of VS.

That's fine. A few other people have managed to get MinGW working. Can you link me to the specific MinGW installer? There's a couple different ones.

Works fine on Windows with mingw-w64.

I can confirm that it works with Windows 10 x64 - Code::Blocks + MSYS2 GCC 7.3.0.
There are errors with -fpermissive try add this flag it should fix some errors or romove D3D12 support altogether from CMake script.


Retire this project in favor of official REST Connector

Or at least link to https://docs.camunda.io/docs/next/components/connectors/out-of-the-box-connectors/rest/

I'm fine with recommending the official Camunda connector. :+1:
If there is no further interest in this worker, I will mark it as deprecated.


Update sql-database-cloud-migrate-compatible-export-bacpac-ssms.md

Added a TAB before Important in step 4 to correctly format it and the image that follows.

Hi @kmataru, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@kmataru - Hi, thanks for your contribution. We are in the process of refactoring the Azure technical articles, so we can’t merge this PR. When the refactoring is complete, we can give you a link to the new location of the article you updated so you can resubmit your update, if you want to.

@kmataru - Thanks for your contribution to the Azure docs. On November 16th, we announced the availability of our Azure technical documentation in a new location on docs.microsoft.com. You can read about it on our team blog. This change means the article source lives in a new GitHub repository. Because there are some changes in the source markdown as a result of the move, we can’t pull your contribution over to the new repo without creating a ton of merge conflicts. We invite you to resubmit the change (if you are willing) to the new version of the article at https://docs.microsoft.com/en-us/azure/sql-database/sql-database-cloud-migrate-compatible-export-bacpac-ssms. Thanks for your understanding.


Add a dev container to simplify contributing

It would be great to add a development container to this repo. This can simplify getting started with the repository (since the dev container sets up all the tools you need to get started) and will also make the repo work better on codespaces

Thanks Matt!


Error loading on dedicated server

Trying to load the mod on a dedicated server results in a crash because it tries to load a client only class.
[19Oct2019 10:50:27.601] [Server thread/FATAL] [net.minecraftforge.fml.ModLoader/LOADING]: Failed to complete lifecycle event CONSTRUCT, 1 errors found
[19Oct2019 10:50:27.602] [Server thread/ERROR] [net.minecraft.server.MinecraftServer/]: Encountered an unexpected exception
net.minecraftforge.fml.LoadingFailedException: Loading errors encountered: [
	Demagnetize (demagnetize) has failed to load correctly
§7Attempted to load class net/minecraft/client/world/ClientWorld for invalid dist DEDICATED_SERVER
]
	at net.minecraftforge.fml.ModLoader.dispatchAndHandleError(ModLoader.java:199) ~[?:?]
	at net.minecraftforge.fml.ModLoader.gatherAndInitializeMods(ModLoader.java:181) ~[?:?]
	at net.minecraftforge.fml.server.ServerModLoader.begin(ServerModLoader.java:45) ~[?:?]
	at net.minecraft.server.dedicated.DedicatedServer.func_71197_b(DedicatedServer.java:121) ~[?:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:598) [?:?]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_201]

Forge version: 1.14.4-28.1.61
Demagnetize version: 1.14.4-1.2.0
Crash log
Debug log

Thanks, I'll look into it.

I found where the error is being caused and have fixed it. However, I also found another crash that occurs when you open the Demagnetizer GUI, which I think should be fairly easy to fix.


sample of undelete versioned blob doesn't compile

V12 example of undeleting versioned blobs doesn't "just work" for starters I don't think pageable blobItems can go directly into blobItems.OrderByDescending, getting the URI is also an exercise left for the user, what's most efficient,? GetBlobClient?
Maybe it's my novice eyes that can't grock this stuff, but reminds me of college textbooks where samples don't compile.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d82c6eb8-2129-8e58-b5ae-d559fa83ddd1
Version Independent ID: 4be98994-6bab-fbe6-dd48-b952f4a5d787
Content: Manage and restore soft-deleted blobs - Azure Storage
Content Source: articles/storage/blobs/soft-delete-blob-manage.md
Service: storage
Sub-service: blobs
GitHub Login: @tamram
Microsoft Alias: tamram

@yanp2k
Thanks for the question! We are investigating and will update you shortly.

@yanp2k Thank for reaching out. Since this channel is for driving improvements towards MS Docs, I'd recommend posting your question in https://azure.microsoft.com/en-us/support/community/ since it's not directly related to the documentation. We'll follow up there. We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

#reassign: @tamram


Expose TXID

Because LiteFS requires that the application layer direct writes to the primary node, many use cases will need the transaction ID to be exposed to the application layer.  The simplest example of this is a replica node sending a write to the primary, waiting for it to succeed, then querying its local database with the expectation that the write will have appeared locally.  This can be accomplished by having the application on the primary node return the transaction ID of the write and the application on the replica busy-loop until the local transaction ID is equal or greater to the returned ID.  Litestream exposes a position file that allows this kind of functionality and it seems reasonable for LiteFS to do the same by exposing TXID and checksum as files in the shadow directory.
Some implementation considerations from my brief experience working with Litestream:

Storing checksum and txid in separate files would be convenient for readers but we could get into trouble with atomicity: if the timing is just so, a reader could observe a checksum and a txid that are out of sync.  Storing both in the same file probably makes it much easier to guarantee consistency.
Make the file(s) fixed length and thus mmap friendly.  A naive getPosition/getTXID function would open, read, and close: three system calls to fetch what essentially boils down to an incrementing integer.  Much more efficient to simply mmap the file on startup and thus have a live view of the data in the process memory.
The Unix way is to make the file text so that anyone can cat it and see the current id.  But it would be ever so much more convenient (for me) if it were stored in binary form in the system endianness: getting the current, ready for comparison TXID would then be as simple as a pointer dereference.  That said, storing as zero-padded text is still probably the Right thing to do.
This is getting nitty-gritty on performance, but one problem with the Litestream position file is that the three components are stored with 1-byte separators.  I was originally mapping the whole file into memory as a struct where the three members were a union { char[16], u128 } but this resulted in unaligned loads which are not great for performance.  I'd recommend either storing data in the file such that it's naturally aligned or having readers make separate mmap calls using the offset and length arguments to slice out each piece of the file (e.g. in LiteFS's case this might be txid and checksum).
Really nitty-gritty but something I discovered while working with Litestream: if storing an integer as zero-padded 16 characters, you can check equality and less-than/greater-than without parsing text -> integer.  Specifically, it is about half the cycles to reinterpret the memory as a u128, do a byte swap, then compare the resulting u128s.  Mileage obviously varies on parsing implementation, my benchmark was done using Zig's std.fmt.parseInt and @byteSwap builtin.

@jwhear Thanks for adding this issue. I swear I thought I added it before but I guess not. :) I added it to the next milestone.

Storing both in the same file probably makes it much easier to guarantee consistency

Yeah, I'll probably just store in the same file for this reason. It seems like you could extract out one of the two values using something like cut.

Make the file(s) fixed length and thus mmap friendly.

That should be pretty easy to do. I wonder if there's a potential race condition there though. With read() I can fill in the bytes with exactly the right values but with mmap(), I'm not sure if it's possible for the OS to clear the page from cache and re-read when you're halfway through reading it from the mmap.

The Unix way is to make the file text so that anyone can cat it and see the current id

Yeah, I'll probably just format it as %016x/%016x with the TXID & checksum. I'm surprised you notice a performance difference in the parsing. It seems like the file system overhead would be much larger.


The Comments Tab is visible from User side

The Comments Tab is visible from User side

Now the Comments tab is not visible for the User account:

Now the Comments tab is not visible from User side:


Update Readme to reflect new network-service tags

Change references #276

LGTM.
@eparis any thoughts?


Write cron expressions for expense report

Write a cron expressions that will be used for scheduling automated expense report generation.
Consider following report types:

weekly: every Monday
monthly: on the 1st of each month
yearly: on January the 1st of each year

Cron expressions reference:
https://www.baeldung.com/cron-expressions
You can you cron generator:
https://crontab.cronhub.io/

Crone Expressions

weekly:   0 0 * * Mon (At 12:00 AM, only on Monday)
monthly: 0 0 1 * * (At 12:00 AM, on day 1 of the month)
yearly: 0 0 0 1 1 * (At 12:00 AM, on day 1 of the month, only in January)

@RomanOresh please document these expressions on project Wiki
https://github.com/ownerofglory/hillel-expense-tracker-backend/wiki
thanks!


xrange not available in py3

Couldn't find any other uses of xrange, any specific reason to have it there?

Coverage remained the same at 89.121% when pulling 0a8f4846d186eb9180eb8f1ac356c346d21734d6 on jonrei:master into 881840522ee91f531abebc57fcee4208990280a4 on bshillingford:master.

Coverage remained the same at 89.121% when pulling 0a8f4846d186eb9180eb8f1ac356c346d21734d6 on jonrei:master into 881840522ee91f531abebc57fcee4208990280a4 on bshillingford:master.

Coverage remained the same at 89.121% when pulling 0a8f4846d186eb9180eb8f1ac356c346d21734d6 on jonrei:master into 881840522ee91f531abebc57fcee4208990280a4 on bshillingford:master.


Attributes don't work in Tag Helper if newline precedes first attribute

Tag helper:
public class HelloTagHelper : TagHelper
{
	public string First { get; set; }
	public string Second { get; set; }

	public override void Process(TagHelperContext context, TagHelperOutput output)
	{
		output.TagName = "span";
		output.SelfClosing = false;
		output.Attributes.Add("data-first", First);
		output.Attributes.Add("data-second", Second);
	}
}

cshtml:
<hello first="1111" second="2222" />
<hello
	first="1111"
	second="2222"
/>
<hello first="1111"
       second="2222"
/>

Result:

The middle <hello /> tag has a newline before the first attribute, which seems to break it (all attributes come through as empty). The final <hello /> only has a newline before the second attribute, which seems to work.
Tested on beta 6.

Just did a quick repro with current Beta 7 bits. It looks as if Razor generates nothing at all for the attributes in the newline-before-attributes case. Likely something is causing the attributes to have a null generator or they're lost completely.


Telegram_bot: Allow fetching data from unverified SSL endpoints (#22067)

Description:
This patch adds an extra option to the payload that describes the resource to send to disable the SSL server verification when polling data from URLs.
Related issue (if applicable): fixes #22067
Pull request in home-assistant.io with documentation (if applicable): TODO
Example entry for configuration.yaml (if applicable):
action:
  service: notify.NOTIFIER_NAME
  data:
    title: Send an images
    message: "That's an example that sends an image."
    data:
      photo:
        - url: https://<IP_ADDRESS>/camera.jpg
          username: admin
          password: secrete
          verify_ssl: false

Checklist:

[ ] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[ ] Documentation added/updated in home-assistant.io
[ ] Tests have been added to verify that the new code works.

This is a PoC that has not been tested locally yet Will increase the test coverage and contribute to the documentation if the change proposal goes through.
Thanks for reviewing!

Hi @nbarrientos,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Thanks for the review. I will prepare the patch for the documentation.


escape key blurs codemirror instead of exiting insert mode

When I am in insert mode and press escape, I would expect it to go back to normal mode but instead the editor looses focus. I guess this is due to some browser defaults? Is there any way to fix this? I am using svelte-codemirror-editor.

Maybe you have another codemirror extension that handles escape key before vim? Do you see the same issue on https://raw.githack.com/replit/codemirror-vim/master/dev/web-demo.html?

Did you manage to find the cause of the issue you were seeing? I am closing this due to lack of reproduction steps, but if you have any additional info, please comment.

I have the exact same issue happening, but it is indeed this issue: https://github.com/philc/vimium/issues/2734
If I disable the Vimium extension for the page in Firefox, Escape works as one expects to exit insert mode.
https://raw.githack.com/replit/codemirror-vim/master/dev/web-demo.html


store tools in supabase db table

started

Took over from @vitalikmay

@BotanMan, have look at #22 - you could use similar approach for products service. Comments service has basic CRUD and usage of supabase functions


Root Mounted paths, override output files

Describe the bug
When we have root mounted paths, the build command copy features are overwriting the correct esbuild output files, this happens because we copy the contents of the mounted directories except F# sources while we normally don't care (because we use the .fs.js extension) when we're dealing with pure js files this can force wrong outputs.
While we usually exclude some of the files with build.excluides I think this is a fairly common scenario or one that at least we should be able to support
To Reproduce
Steps to reproduce the behavior:

With a perla.json file like this:

{
  "index": "./index.html",
  "mountDirectories": {
    "/": "./src"
  },
  "fable": {
    "extension": ".js"
  }
}

attempt to run perla build
2. the outDir directory is filled with the contents of src
Expected behavior
While we should copy some of the contents of the mounted directory we should avoid copying the source code files to avoid override these situations.
Desktop (please complete the following information):

OS: any
Browser: any
Version: v1.0.0-beta-012 and below

Additional context
Found at #96

this was fixed but will close in favor of #128 for the remaining work


Feature Request: Display limit of messages

it's like twitter or SMS, when you type a message, long or short, please display the bytes/space remaining for 1 tx and if your message is long, how many tx it would require for the user

Agree this is usefull for the future but not a blocker to use in the current shape too.


Update connect modal

Closes #329

Name and address overlap in some cases (6px gap should do the trick) but otherwise lgtm!


[MINOR][PYTHON][DOCS] Fix typos in PandasCogroupedOps.applyInArrow

What changes were proposed in this pull request?
fix two typos
Why are the changes needed?
the returned dataframe should be pyarrow.Table other than pandas.DataFrame
Does this PR introduce any user-facing change?
yes, doc fix
How was this patch tested?
ci
Was this patch authored or co-authored using generative AI tooling?
no

Merged to master.


fix channel sequencing bug

Fixes micro-manager/pycro-manager#457

Tested, and ready to merge, I think.


Implement the ".. author::" directive

it should just have a single definition list - which doesn't even need to be special

Fixed in latest commit


Some fixes for NetworkMessages API

Return callbacks handles for session request/failed.
Remove drop impl for SessionRequest, this was causing all sessions to be rejected
Add user-defined NetConnectionEnd. User can define their application-specific errors from a range, but this was causing panics if used. I caught this because NetworkMessages define 2 errors in this range (1001, 1002), I'm not sure why they used this values that should be application-specific errors.

Does this PR need any changes to move it forward? I can also add a simple example for the NetworkingMessage API if this would help.

Hey, I made the pull request that added support for NetworkingMessages and NetworkingSockets.
I don't use networking messages myself, so it makes sense I missed some bugs in that part of the implementation.
I think your solution is not idiomatic, simply removing the drop makes it possible to leave a request open without giving an answer. In the NetworkingSockets API, I fixed the same problem by adding an is_handled field. It gets set to true when calling accept and prevents drop from rejecting the connection.

Hey, I made the pull request that added support for NetworkingMessages and NetworkingSockets. I don't use networking messages myself, so it makes sense I missed some bugs in that part of the implementation, so thanks for cleaning up after me.
I think your solution is not idiomatic, simply removing the drop makes it possible to leave a request open without giving an answer. In the NetworkingSockets API, I fixed the same problem by adding an is_handled field. It gets set to true when calling accept and prevents drop from rejecting the connection.

Makes sense, I updated the PR with the copied logic from NetworkingSockets for the automatic reject request when not handled.

For the callback, I'm not sure if I should just save it inside the NetworkingMessages struct.

Yes, I think saving the callback handles in the struct is probably best. I don't remember what they are used for, but I definitely wouldn't return the handle. That's part of the internal implementation, so ideally it shouldn't be necessary to have it.


Allow multiple use of --format option

Please allow to use multiple -f (--format) per URL. For now this:
youtube-dl -f 130 -f 128 URL

will just download format referenced as 128 while I'd like to have both downloaded.

Have you even read FAQ?


Bug | Bad owner or permissions on /root/.ssh/config

Describe the Bug
When trying to init a layer, and using private ssh accessed repos, this error occurs:
Bad owner or permissions on /root/.ssh/config

Problem seems to be .ssh/config does not belongs to the user in the container (root) instead, the UID is the one of the user in the host machine.
Workaround:

edit  ~/.ssh/config adding this

host gitlab.com
 HostName gitlab.com
 IdentityFile ~/.ssh/filename
 User username

(this example is for gitlab.com, also replace the filename and user name)

change ownership and permissions

sudo chown root:root ~/.ssh/config && sudo chmod 600 ~/.ssh/config

run init as usual

leverage tf init

Expected Behavior
Leverage to handle this situation.
Steps to Reproduce
Steps to reproduce the behavior:

Go to '...'
Run '....'
Enter '....'
See error

Screenshots
If applicable, add screenshots or logs to help explain your problem.
Environment (please complete the following information):
Anything that will help us triage the bug will help. Here are some ideas:

OS: [e.g. Linux, OSX, WSL, etc]
Version [e.g. 10.15]

Additional Context
Add any other context about the problem here.

@juanmatias we'll take your blog post as reference to improve this design https://juanmatiasdelacamara.wordpress.com/2019/04/07/ssh-keys-ssh-agent-and-docker/ ;)

new solution implemented, it has to be checked... no Toolbox change is needed here.

@juanmatias thanks for your update! So the PR https://github.com/binbashar/leverage/pull/174 is ready to review? Do we need to wait for the doc 1st?
CC: @angelofenoglio @Franr @diego-ojeda-binbash

https://github.com/binbashar/le-ref-architecture-doc/pull/156 and https://github.com/binbashar/leverage/pull/174 merged... closing

Reopening this issue since a customer reported it again:

root permissions on the .aws/project_short dir probably related to a specific linux distro
We should be able to run quick checks to verify those scenarios and show a warning at the very least
✅ QUICK FIX: run a chown after the leverage command similar to what we've done in the past => https://github.com/binbashar/le-dev-makefiles/blob/e478a17152a5abdd1649a269fbfa903d1bdb8a59/terraform1/terraform1.mk#L60

Functionality was tested during the last call. Docs and CI are remaining.


Fix Traffic Metric Policy in universal mode doc

Signed-off-by: YuikoTakada<EMAIL_ADDRESS>Fix #295

Can you also have this updated for 0.7.1 and 0.7.2?

@nickolaev sure. I cannot find docs path of 0.7.1 and 0.7.2. Could you please tell me?

@nickolaev sure. I cannot find docs path of 0.7.1 and 0.7.2. Could you please tell me?

https://github.com/kumahq/kuma-website/blob/master/docs/docs/0.7.1/quickstart/universal.md
https://github.com/kumahq/kuma-website/blob/master/docs/docs/0.7.2/quickstart/universal.md

Thanks! @YuikoTakada


Pin Python to 3.6 in conda install cmd

For some reason, doing a conda install of tensorflow=1.0* appears to
make conda want to downgrade from Python 3.6 to 2.7 and this causes
problems like:
$ sudo docker run -v $(pwd):/home/jovyan/work -it --rm -p 8888:8888 tensorflow-ll-stack
/usr/local/bin/start-notebook.sh: ignoring /usr/local/bin/start-notebook.d/*

Container must be run with group "root" to update passwd file
Executing the command: jupyter notebook
Traceback (most recent call last):
  File "/opt/conda/bin/jupyter-notebook", line 4, in <module>
    import notebook.notebookapp
ImportError: No module named notebook.notebookapp

Fixes: GH-31

This issue is resolved by using my latest TensorFlow LiveLessons repo here, which doesn't rely on conda for installation within the Dockerfile.


fix(costmodel): cost model wizard texting updates

closes #1321

Codecov Report

Merging #1325 into master will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1325      +/-   ##
==========================================
+ Coverage   76.88%   76.99%   +0.11%
==========================================
  Files         226      222       -4
  Lines        4404     4347      -57
  Branches      843      840       -3
==========================================
- Hits         3386     3347      -39
+ Misses        891      874      -17
+ Partials      127      126       -1

Impacted Files
Coverage Δ

src/routes.tsx
87.5% <0%> (-0.74%)
:arrow_down:

src/store/rootReducer.ts
100% <0%> (ø)
:arrow_up:

src/store/sourceDeleteDialog/actions.ts

src/store/sourceDeleteDialog/index.ts

src/store/sourceDeleteDialog/selectors.ts

src/store/sourceDeleteDialog/reducer.ts

src/app.tsx
57.74% <0%> (+1.49%)
:arrow_up:

src/store/sourceSettings/actions.ts
40% <0%> (+6.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b823ab...725ca48. Read the comment docs.

Please don't use the keyword "closes #1321" in the description. Github will close the issue before QA can approve.


resource handling with  URI params not working well.

package io.advantageous.qbit.service.rest.endpoint.tests.services;

import io.advantageous.qbit.annotation.PathVariable;
import io.advantageous.qbit.annotation.RequestMapping;
import io.advantageous.qbit.annotation.RequestMethod;
import io.advantageous.qbit.service.rest.endpoint.tests.model.Department;
import io.advantageous.qbit.service.rest.endpoint.tests.model.Employee;

import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;

@RequestMapping("/hr")
public class HRService {

    final Map<Integer, Department> departmentMap = new HashMap<>();

    @RequestMapping("/department/")
    public List<Department> getDepartments() {
        return new ArrayList<>(departmentMap.values());
    }

    @RequestMapping(value = "/department/{departmentId}/", method = RequestMethod.POST)
    public boolean addDepartments(@PathVariable("departmentId") Integer departmentId,
                               final Department department) {

        departmentMap.put(departmentId, department);
        return true;
    }

    @RequestMapping(value = "/department/{departmentId}/employee/", method = RequestMethod.POST)
    public boolean addEmployee(@PathVariable("departmentId") Integer departmentId,
                                  final Employee employee) {

        final Department department = departmentMap.get(departmentId);

        if (department ==  null) {
            throw new IllegalArgumentException("Department " + departmentId + " does not exist");
        }

        department.addEmployee(employee);
        return true;
    }

    public Map<Integer, Department> getDepartmentMap() {
        return departmentMap;
    }
}

Got ti working. Need to add more tests.


Empty text node added when replacing the doc content with the new content

Discussed in https://github.com/BitPhinix/slate-yjs/discussions/387

Originally posted by Maryam-Yumna April 11, 2023
There's an extra empty text node added everytime i try to delete all the content in a shared type and insert new content
const versionContent = [
    {
        "type": "p",
        "id":<PHONE_NUMBER>756,
        "children": [
            {
                "text": "hi"
            }
        ]
    }
]
sharedType.delete(0, sharedType.length);
const delta = slateNodesToInsertDelta(versionContent);
sharedType.applyDelta(delta);

//expected
 [
    {
        "type": "p",
        "id":<PHONE_NUMBER>756,
        "children": [
            {
                "text": "hi"
            }
        ]
]

//result I get
[
    {
        "type": "p",
        "id":<PHONE_NUMBER>756,
        "children": [
            {
                "text": "hi"
            }
        ]
    },
    {
        "type": "p",
        "children": [
            {
                "text": ""
            }
        ]
    }
]
```</div>

Duplicate of https://github.com/BitPhinix/slate-yjs/issues/385

Actually nvm


Add minio integration (as a data loader)

Request:
hi, is minio integration on the roadmap? as a data loader??? <https://min.io>

Slack Message

This feature is supported now: https://github.com/mage-ai/mage-ai/pull/2748


mgmt/MCUmgr/img: Fix img_mgmt_get_unused_slot_area_id checks

Remove image == -1 check that can not happen anymore.

@de-nordic please rebase

@carlescufi Rebased.

@de-nordic please rebase


Config option kernel_spec_manager_class not recognized by DisableLabExtensionsApp.

Platform identifier
Amazon Linux 2, Jupyter Lab 3
(notebook-al2-v2)
setup-codeserver.sh outputs before the systemctl restart jupyter-server command is executed:
Config option `kernel_spec_manager_class` not recognized by `DisableLabExtensionsApp`.
[W 2022-11-15 07:38:31.512 LabApp] Config option `kernel_spec_manager_class` not recognized by `LabApp`.

Afterwards, jupyterlab restarts and the instance is returning a 503. When I restart the notebook it is working again, but code-server is not activated.

Here is the full log:
sh-4.2$ sudo ./setup-codeserver.sh
+ CODE_SERVER_VERSION=4.5.2
+ CODE_SERVER_INSTALL_LOC=/home/ec2-user/SageMaker/.cs
+ XDG_DATA_HOME=/home/ec2-user/SageMaker/.xdg/data
+ XDG_CONFIG_HOME=/home/ec2-user/SageMaker/.xdg/config
+ CREATE_NEW_CONDA_ENV=1
+ CONDA_ENV_LOCATION=/home/ec2-user/SageMaker/.cs/conda/envs/codeserver_py39
+ USE_CUSTOM_EXTENSION_GALLERY=0
+ EXTENSION_GALLERY_CONFIG='{{\"serviceUrl\":\"\",\"cacheUrl\":\"\",\"itemUrl\":\"\",\"controlUrl\":\"\",\"recommendationsUrl\":\"\"}}'
+ LAUNCHER_ENTRY_TITLE='Code Server'
+ PROXY_PATH=codeserver
+ LAB_3_EXTENSION_DOWNLOAD_URL=https://github.com/aws-samples/amazon-sagemaker-codeserver/releases/download/v0.1.5/sagemaker-jproxy-launcher-ext-0.1.3.tar.gz
+ INSTALL_LAB1_EXTENSION=1
+ LAB_1_EXTENSION_DOWNLOAD_URL=https://github.com/aws-samples/amazon-sagemaker-codeserver/releases/download/v0.1.5/amzn-sagemaker-jproxy-launcher-ext-jl1-0.1.4.tgz
+ export XDG_DATA_HOME=/home/ec2-user/SageMaker/.xdg/data
+ XDG_DATA_HOME=/home/ec2-user/SageMaker/.xdg/data
+ export XDG_CONFIG_HOME=/home/ec2-user/SageMaker/.xdg/config
+ XDG_CONFIG_HOME=/home/ec2-user/SageMaker/.xdg/config
+ export PATH=/home/ec2-user/SageMaker/.cs/bin/:/sbin:/bin:/usr/sbin:/usr/bin
+ PATH=/home/ec2-user/SageMaker/.cs/bin/:/sbin:/bin:/usr/sbin:/usr/bin
+ EXT_GALLERY_JSON=
+ '[' 0 -eq 1 ']'
+ JUPYTER_CONFIG_FILE=/home/ec2-user/.jupyter/jupyter_notebook_config.py
+ grep -q /home/ec2-user/SageMaker/.cs/bin /home/ec2-user/.jupyter/jupyter_notebook_config.py
+ cat
++ /home/ec2-user/anaconda3/envs/JupyterSystemEnv/bin/jupyter-lab --version
+ JUPYTER_LAB_VERSION=3.5.0
+ sudo -u ec2-user -i
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 19651  100 19651    0     0  25306      0 --:--:-- --:--:-- --:--:--  223k
Looking in indexes: https://pypi.org/simple, https://pip.repos.neuron.amazonaws.com
Processing ./SageMaker/.cs/lab_ext/sagemaker-jproxy-launcher-ext.tar.gz
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: sagemaker-jproxy-launcher-ext
  Building wheel for sagemaker-jproxy-launcher-ext (pyproject.toml) ... done
  Created wheel for sagemaker-jproxy-launcher-ext: filename=sagemaker_jproxy_launcher_ext-0.1.3-py3-none-any.whl size=28044 sha256=07c6e1b86f57d64e26b94a21c11d9871db08f9263b51d97af802f31c13ac7705
  Stored in directory: /home/ec2-user/.cache/pip/wheels/b1/ae/23/e402630d56afaedbf7083d851b13612dbb641f84efdc4523b5
Successfully built sagemaker-jproxy-launcher-ext
Installing collected packages: sagemaker-jproxy-launcher-ext
Successfully installed sagemaker-jproxy-launcher-ext-0.1.3
Config option `kernel_spec_manager_class` not recognized by `DisableLabExtensionsApp`.
[W 2022-11-15 07:38:31.512 LabApp] Config option `kernel_spec_manager_class` not recognized by `LabApp`.
+ systemctl restart jupyter-server

Hi @nicornk thanks for reaching out.
The kernel_spec_manager_class one is a warning that does not affect the install procedure.
After the Jupyter server restarts, you might have to wait a few seconds before reloading the browser window.
If you stop and restart the notebook, the setup_codeserver.sh script should be executed again, as documented.
Hope this helps.

Good to know that the warning is expected.
however, my jupyter server seems to not start up again - the 503 continues until I manually stop and start it from the Sagemaker console.


Get preliminary feedback

Before you show the interview to the decisionmaker and stakeholders, get someone with Document Assembly Line experience to test it with you. This will help you identify any remaining bugs, questions you still need to ask the decisionmaker, or other issues.
If you do identify any issues, add them to this project or the interview repository.

awaiting preliminary feedback #3


How to get the preprocessed BTCV dataset?

Many thanks for the great work! Could you please share the preprocessed BTCV dataset as those for the synapse and acdc datasets?

Hi @lphilomena,
I appreciate your interest in our work.
Please note that the preprocessed BTCV dataset is the same as Synapse we already shared. You will find that we shared preprocessed 30 samples. The difference is that Synapse has 18 training samples and 12 validation samples considering only 8 organs, while BTCV has 24 training samples and 6 validation samples considering all organs.
To train or evaluate our model on BTCV, you have to download this json file and train the same model of Synapse. After that, to get the results from the leaderboard, you have to register in Multi-Atlas Labeling Beyond the Cranial Vault - Workshop and Challenge and submit your predictions to the server.
I hope it is clear now.
Best regards.

Hi，@Amshaker，
Thank you very much for your clear reply. It is quite helpful!
Best regards,

@Amshaker
Excuse me, can you provide BTCV training and testing datasets? How is 24/6 divided?


ReTest.jl - more productive testing | Rafael Fourquet | JuliaCon 2021

ReTest.jl - more productive testing, https://www.youtube.com/watch?v=n-UP_Ul-JjE
I need to dig up more into testing to make better timestamps for this video. This is my first try and maybe I will be able to improve them before they will be place on YouTube.
00:00 Welcome!
00:19 ReTest.jl is mostly backward-compatible stdlib Test
00:45 Example
01:55 Standard test workflow in Julia
03:00 ReTest.jl workflow
04:13 Function watch
05:36 Function hijack
06:50 Function hijack_base for testing Julia Base

Thanks! Tests are cool : )


3 Level decomposition using Haar wavelet

Can anyone help me write python script to decompose an image upto 3 Low levels using haar wavelet ?? to gain low level detail for upto 3 levels. As i am new to this field and i am facing lots of problems here.

I'm sorry, we (the two active maintainers) don't have bandwidth to help with custom usage questions beyond improving the docs. I hope you figured it out after you asked this.


Real-time plot flickering with MahApps.Metro controls

Describe the bug
I use OxyPlot library for real-time plotting in my WPF application. Now I want to use MahApps.Metro controls to improve visual style of my application.
But with MahApps.Metro controls the real-time plot is flickering. See demo video below.
Clear WPF application
https://user-images.githubusercontent.com/97022983/154469066-40fe2949-6020-42ee-97a1-19c63314fa54.mp4
WPF application with MahApps.Metro controls
https://user-images.githubusercontent.com/97022983/154469131-e8f1938c-f653-4e0c-86d3-f68f8c4ae75f.mp4
Steps to reproduce
Please see MahAppsRTPlotDemo demo application where the bug is demonstrated.
With clear WPF application real-time plot works good. But after adding the MahApp styles into the App.xml
          <ResourceDictionary.MergedDictionaries>
              <!--  Comment the line below to remove the flickering from the plot  -->
              <ResourceDictionary Source="pack://application:,,,/MahApps.Metro;component/Styles/Controls.xaml" />
          </ResourceDictionary.MergedDictionaries>

we got a flickering.
Environment
MahApps.Metro version: v2.4.9
Windows build number: Windows 10 21H1 [OS Build 19043.1526]
Visual Studio: 2022
Target Framework: .Net 6.0

I solve the problem by setting the parameter SnapsToDevicePixels="False"
        <GroupBox
            Width="200"
            Height="200"
            Margin="5"
            SnapsToDevicePixels="False">
            <oxy:PlotView Background="Transparent" Model="{Binding PlotModel}" />
        </GroupBox>

So probably this is not a bug, but the feature.

@alxkalinin Thx for the hint. The GroupBox style uses SnapsToDevicePixels="True" as the default. You can also set it directly to the PlotView:
<oxy:PlotView Background="Transparent" Model="{Binding PlotModel}" SnapsToDevicePixels="False" />

@alxkalinin If you use the UseLayoutRounding then it will also stay pixel tune
        <GroupBox
            UseLayoutRounding="True"
            Width="200"
            Height="200"
            Margin="5">
            <oxy:PlotView Background="Transparent" Model="{Binding PlotModel}" SnapsToDevicePixels="False" />
        </GroupBox>


Update changelog for 1.0.1 release

This changelog reflects the change in #41, which hasn't merged yet. Will wait to merge until that ships.

🎉 👍  lgtm


xip.io ingress does not work on GKE

Rancher versions: 2.0.0
Steps to Reproduce:

Create a GKE cluster
Create a workload
Expose NodePort
Create xip.io Ingress
Wait until Rancher generates xip.io URL

Results:
The generated xip.io URL does not work. It requires us to update the host in Ingress rules. GKE does not seem to work in that case.
Solution:
On GKE we can use the Ingress public IP address directly in the URL. Each Ingress has a unique public IP.

Duplicate of #13223


Update the HASH for forest and sol2

Forest and sol2 failed with the HASH number not match.
Update the correct HASH for these two ports.

This issue has been fixed by Robert's commit https://github.com/Microsoft/vcpkg/commit/ff5d6eb3c84d6a41fefc2ab10b77790db933c8ed, so close this PR.

Thanks!


Pass state to getComponents of Route

I've seen in the docs that function passed as getComponents prop to Route was supposed to get state user is navigating to. It wasn't getting it so I passed it there.
Not sure if it callback should be the first parameter and state the second. If other way around is preferable then we need to correct usage in examples as well..

Not sure why two additional commits got included into this pull request. I made them after creating this pull request.
One fixes the error that shows up on page unload, other helps with building on windows machine under git bash.

I'd also like to see state passed to getComponents. It would be very useful for a use case that I have in which I need to render a different component based on the state.
This pull request passes the arguments to getComponents(cb, state) in the opposite order as they are passed to getChildRoutes(state, cb). It would be nice if this argument ordering were consistent, although that would likely involve a breaking change.
The documentation already shows getComponents receiving a state argument (see d16feea3962c0a37b3e1c6f70ec17d12228a5cb2).
The 1.0 router is awesome! Thanks.

I can reverse the order of arguments but as you said it would be breaking change, so I'll wait for some core developer to pitch in about what should be the order of arguments.

In master the signature of getChildRoutes is currently getChildRoutes(location, callback). If you need location.state in getComponents as well, let's just pass the whole location object so the APIs are more predictable (they match).

I'm closing this pull request as it seems the codebase is quickly moving target

@mjackson I made new pull request for passing state into getComponents based on your current  master branch so that getComponents can have signature like that: https://github.com/rackt/react-router/blob/master/doc/01 Route Configuration/0 Route.md#getcomponentsstate-cb
Here's the pull request:
https://github.com/rackt/react-router/pull/1700


issues with helm deployment

I faced an issue yesterday with Chart 1.1.2, it seems the 1.0-beta chaged to be copy of 1.0-beta10 which caused trickster to fail to start after updating my kubernetes cluster nodes and pulling the docker image. then I tried to update to latest chart.
for 1.3.0 also some values in values.yaml is duplicated like service section which cause an issue with config file having an empty listen_port
also PVC contains deprecated values for example https://github.com/Comcast/trickster/blob/6ac009f29aeeea9476da9db6311d0aa7cf39033c/deploy/helm/trickster/templates/pvc.yaml#L1 there is no section called config in current values.yaml
workaround: used tag 1.0.9-beta9

@agoloAbbas these issue should be resolved in the latest release (Trickster 1.0.0-rc1, Chart 1.4.0). Please let use know if everything looks good for you now! Thank you again!

now it fails to pull 1.0.9-beta9
Failed to pull image "tricksterio/trickster:1.0-beta9": rpc error: code = Unknown desc = Error response from daemon: manifest for tricksterio/trickster:1.0-beta9 not found: manifest unknown: manifest unknown

why was this image deleted? I don't get it. It is so hard to keep using this solution

Same problem here. Image deleted and now i have some issues with the chart. Could you reupload the image please?

@agoloAbbas Thanks for following up, and for sticking with the project during the beta process. I know that it required some effort to keep up as we released new versions, and we really appreciate it.
To your question about the image deletion: now that the 1.0 release is live, the beta images have been removed, so as to avoid users installing now-unsupported builds and filing issues against them. We only remove pre-release images, and only once they are obsolete, and never remove GA release images. For example, the previous GA release was 0.1.10 and that image will be available indefinitely.
Would you mind checking that you synced the repository recently? The helm chart has been pointing to the 1.0 tag for about 6 days (see https://github.com/Comcast/trickster/blob/master/deploy/helm/trickster/values.yaml). That is a valid tag, so a quick sync of the repo should solve the tag issue you are experiencing.  1.0 will be the primary image tag going forward, and will not be deleted.
We are in the process of getting the helm charts into their own repository so they can be added with a simple helm repo add which is being worked on #317

Same problem here. Image deleted and now i have some issues with the chart. Could you reupload the image please?

Nico, can you please check your chart version? The image tag in the latest helm chart is 1.0

simply I didn't migrate to it cuz I didn't find fixes for issues I reported for example right now.
for example:-
ingress.enabled=true would fail the deployment
$helm diff upgrade -f values.yaml -f values-custom.yaml trickster --set ingress.enabled=true .
Error: render error in "trickster/templates/ingress.yaml": template: trickster/templates/ingress.yaml:4:27: executing "trickster/templates/ingress.yaml" at <.Values.trickster.service.servicePort>: nil pointer evaluating interface {}.service
render error in "trickster/templates/ingress.yaml": template: trickster/templates/ingress.yaml:4:27: executing "trickster/templates/ingress.yaml" at <.Values.trickster.service.servicePort>: nil pointer evaluating interface {}.service
Error: plugin "diff" exited with error```

it make no sense to delete old images while the current one is not working. or not stable enough to migrate to

there are errors like @agoloAbbas  mentions, i try to patch the templates directory and still get more errors after, i agree with him deleting images without testing first.

Thanks for the additional information. We do test the charts with a helm lint and a helm template, which chart version 1.4.0 passed before it was released. I'm sorry to hear there are some errors despite those tests. Are there other validation tests that you can recommend we add? I am unfortunately just one person trying very hard to maintain this project and I am not a helm expert, so my apologies for the frustrations with this. I appreciate any constructive help to make this better.

I am willing to help you with helm but I would recommend to not deprecate 0.9 image as it would cause issue with anyone currently using the chart.
I rebuilt the image localy and pushed to agoloabdelsalam/trickster:v1.09-beta9 if anyone want to use it. I will create a pr soon to fix current deployment.
I myself test helm with testing different scenarios y enabled different keys like ingress..etc to see if it will fail or not besides it seems the values.yaml file was alerted in way to that duplicated things. I will try to make a PR soon to fix it when I have time.

Thanks for the help! Is there an issue with the 1.0 image itself? I can run it in docker with no issues. It would be preferable to not use images of old beta software if the only issues are with the actual chart. I believe then that you should be able to take your working chart and update the image tag to 1.0 to have it work, while we work out the chart issues directly (irrespective of the image). If that does not work, can you provide the runtime error that the image returns when you try to run it?

@agoloAbbas and @nicopapayann it looks like removing the duplicate service section (which does not appear to be checked by helm lint and helm template) didn't quite make it into a PR, and that was my mistake - I was sure we'd taken care of it. We have a PR open to address that issue now.
Also, our gracious kube/helm reviewer (@LimitlessEarth) will be standing up a kube namespace in our test environment for verifying the end-to-end deployment of the chart. So he'll fix up any other issues, and integrate that environment into our standard verification steps. So hopefully we'll have any issues resolved in short order and will be able to catch them more reliably going forward. Thanks for your patience and all the great info!
BTW, the other issue with the chart you reported was the persistent volume claims, which we did address (and Adam will verify as per above and commit any additional fixes). PVC was incorrectly dependent upon a configuration value that only existed in the 0.1.x version of Trickster, and that is why it has been failing. With 1.0, you can configure multiple caches, and none, some, or all of those multiple caches could be a filesystem cache. It was not easy to migrate this logic (e.g., reading a scalar => iterator with a break). So instead, we now key off of the .Values.persistentVolume.enabled boolean to for PVC, which will need to be set to true for the claim to be made, irrespective of which caches are configured. We can certainly improve this to use a deterministic iterator that can break after making the claim, but break did not seem to be an intrinsic feature in helm templating. Again any help is welcomed!

Thanks for the help! Is there an issue with the 1.0 image itself? I can run it in docker with no issues. It would be preferable to not use images of old beta software if the only issues are with the actual chart. I believe then that you should be able to take your working chart and update the image tag to 1.0 to have it work, while we work out the chart issues directly (irrespective of the image). If that does not work, can you provide the runtime error that the image returns when you try to run it?

running old chart with new image would not work as it seems health probe endpoint has changed . so updating image tag within same chart is not a solution. pod keep restarting due to health probe failure.

https://github.com/Comcast/trickster/pull/370
FYI

thanks guys, i found a couple of problems and fixed them but there was one i really had trouble found a fix, i will wait for the merge.

Hi everyone, we have merged #370 into master, which is chart version 1.4.1. It is compatible with the 1.0 GA release and the release candidates, but will not work with the beta binaries prior to beta 10. Thanks for your patience while we got everything sorted out with the charts, and please let us know if there are any additional issues and we'll get them worked out as soon as possible.

All, closing this issue as there has been no more discussion since chart 1.4.1 was released. Note we have moved Trickster's Helm charts over to their own project at < https://github.com/tricksterproxy/helm-charts>, so please open any new issues discovered with the charts over there. The charts are now available as a chart repo, and you can find information about that at https://helm.tricksterproxy.io/ or on Helm Hub. The next main Trickster release will replace the deploy/helm directory with a notice of the charts relocation. Thanks again for this report and helping us get the charts in good shape!


Add Field Components for Input and Textarea

Summary
Resolves #1285
This pull requests introduces the TextareaField and InputField components found inside the linked issue.

I didn't first class errorIcon, as I didn't want to introduce terra-icon as a dependency into the form components.
I wonder though if we can get away with only first classing just some of the properties, such as onChange, inputId, value, defaultValue

Although the errorIcon is not exposed in InputField component there is still dependency on terra-icon. Because terra-form-field default errorIcon with a terra-icon.
https://github.com/cerner/terra-core/blob/master/packages/terra-form-field/src/Field.jsx#L68
If we expose erroricon user can pass an empty element to suppress the default errorIcon.

They could still pass it in. It would be done through customProps.

Few cleanup thing but otherwise looks good

Functional verification completed. The field and text area input examples display and function correctly.


Added package name, license and description so it is installable

Dead project is dead. You shouldn't be using it anyway :-)

:sadpanda: :cry:


spdystream depends on golang.org/x/net/spdy which no longer exists

As of 4 days ago golang.org/x/net/spdy has ceased to exist.

Thanks for the heads up, I will get this updated as soon as possible.


Add an attribute to hannibal hbase_site.xml to point to the hbase.regionserver.info.port

This PR adds an bcpc-hadoop attribute for specifying hbase region server info port. In HDP2.2, we set a different port(e.g.: 60300) than what the default(60030) is assumed by hannibal.
It also cleans up some unused templates.

Created PR on wrong branch; should goto bloomberg:hdp2.2. Closing this one.


overriding max upload limit

From @Tratcher on May 27, 2016 18:33
From @Ryuuke on May 27, 2016 18:30
Hello,
I encountered this error when uploading large file (~200MB).

An unhandled exception occurred while processing the request.
Multipart body length limit 134217728 exceeded
at Microsoft.AspNetCore.WebUtilities.MultipartReaderStream.UpdatePosition(Int32 read)

I already tried to modify my web.config file :
httpRuntime maxRequestLength="1073741824" executionTimeout="300000"
and requestLimits maxAllowedContentLength="1073741824"
but still, I get the same error.
I'm using the RC2 version, is there a way to override that limit ?
Copied from original issue: aspnet/KestrelHttpServer#891
Copied from original issue: aspnet/HttpAbstractions#641

From @davidfowl on May 27, 2016 18:40
@Tratcher @Eilon @kichalla should that filter be built into mvc?

From @Tratcher on May 27, 2016 18:38
There are limits on the request form. Where are you trying to read the Form, an MVC Controller/Action?
The limits can be adjusted per action like this:
https://github.com/aspnet/Entropy/blob/dev/samples/Mvc.FileUpload/Controllers/RequestFormLimitsController.cs#L19
Or for the whole app like this (but don't do this just for one file):
https://github.com/aspnet/Entropy/blob/dev/samples/Mvc.FileUpload/Startup.cs#L34

From @Tratcher on May 27, 2016 18:43
https://github.com/aspnet/Entropy/blob/dev/samples/Mvc.FileUpload/Filters/RequestFormSizeLimitAttribute.cs

From @Tratcher on May 27, 2016 18:42
@rynowak Probably.

From @Ryuuke on May 27, 2016 19:7
Hey, thanks for your reply, yeah i'm trying to read the form from the an MVC action, it was the MultipartBodyLengthLimit property inside the FormOptions that I updated to a larger value than the default and It Worked well.

From @Eilon on July 7, 2016 1:52
Is this the same as https://github.com/aspnet/Mvc/issues/481?

From @Tratcher on July 7, 2016 2:21
Not quite, this is specific to forms.

From @victorhurdugaci on July 6, 2016 22:16
This is something that should be in MVC. cc @kichalla @rynowak

We should revisit what exactly we want to do here.

What am I missing? We added upload limits to kestrel by default, and also added an override to MVC in a sample

I think the proposal was to add a MVC filter to set the available form options here https://github.com/aspnet/HttpAbstractions/blob/8b3c308c226dd61532e543697d9d35bb94aba823/src/Microsoft.AspNetCore.Http/Features/FormOptions.cs. There is a sample in Entropy that illustrate this mentioned above but I think the discussion was whether we should polish that and ship it.

Setting the MutltiPartBodyLength on for both the whole application and via the attribute are working on a windows development machine, but when I publish to a Linux environment neither setting makes any difference.
I still get the: An unhandled exception has occurred while executing the request Multipart body length limit 134217728 exceeded.
My settings look like
services.Configure(x =>
{
x.ValueCountLimit = int.MaxValue;
x.MultipartBodyLengthLimit = int.MaxValue;
});
and
[RequestFormSizeLimit(valueCountLimit: int.MaxValue, multipartBodyLengthLimit: int.MaxValue, Order = 1)]
I added the attribute from the Entropy project and added the multiPartBodyLengthLimit argument.

Upgraded my project to latest versions 1.1.1 along with the tooling upgrade in VS2017. The work around mentioned doesn't seem to work anymore. When I'm debugging I can see the options code gets run and the values are updated. The controller just doesn't seem to recognize the change.
Keep getting "Multipart body length limit 16384 exceeded." even though I have this in my startup.
			services.Configure<FormOptions>(options =>
			{
				options.ValueLengthLimit = int.MaxValue;
				options.MultipartBodyLengthLimit = long.MaxValue;
			});

			services.AddMvc()
				.AddViewLocalization(LanguageViewLocationExpanderFormat.Suffix)
				.AddDataAnnotationsLocalization();

@JasonRowe, I ran into that issue earlier today, I upgraded a project to 1.1.1 yesterday.
For me I believe having the RequestFromSizeAttribute on the method fixed the problem. I haven't had time to dig in and actually figure out what fixed it.
Heres an example:
[HttpPost("api/[controller]/upload")]
[RequestFormSizeLimit(500,<PHONE_NUMBER>)] //500 - ValueCount Limit, 25 MB MaxBodyPartLengthLimit
public async Task Upload(FileDescription fileDescription){...

Also tried adding a form attribute with no luck. Nothing I do seems to effect the MultipartBodyLengthLimit. Anyone have a work around?

/cc @Tratcher @halter73 - what's the right setting for this?

I also tried the "DisableFormValueModelBindingAttribute" attribute from these old docs and it didn't help.
https://docs.microsoft.com/en-us/aspnet/core/mvc/models/file-uploads
https://raw.githubusercontent.com/aspnet/Docs/master/aspnetcore/mvc/models/file-uploads/sample/FileUploadSample/Filters/DisableFormValueModelBindingAttribute.cs

@rynowak Here are the Kestrel limits that can be configured today.
While you can set absolute limits for the request line and request headers sizes, there is none for the request body. The MaxRequestBufferSize only limits the number of request body bytes that can sit in Kestrel's internal buffers without the app reading them before back pressure is applied.

Not very helpful but suddenly I can't recreate my issue. I did change some settings that made my virtual machine run faster (added additional CPU's). Now I don't appear to need any settings in the startup and the same file works fine via the same form without changes.

/cc @Tratcher did you have any thoughts on this?

Not if he can't reproduce it. It would be nice to make the sample filter/attribute a shipping thing.

@davidfowl this doesn't work in 1.1.1.  I cannot believe I can't upload a file in asp.net core over a certain size
https://github.com/aspnet/HttpAbstractions/blob/dev/src/Microsoft.AspNetCore.WebUtilities/MultipartReader.cs#L50
It is set to the default and fails here
https://github.com/aspnet/HttpAbstractions/blob/dev/src/Microsoft.AspNetCore.WebUtilities/MultipartReaderStream.cs#L156
Any guidance?

@rynowak / @Tratcher  - how does this relate to some of the limits work that we're doing right now?

This isn't directly related to IHttpMaxRequestBodySizeFeature, form has always had its own limits. But it does show why we need to do https://github.com/aspnet/Mvc/issues/6352 once there's a global body size limit.

how does this relate to some of the limits work that we're doing right now?

This is part of the limits work that we're doing right now. This is needed for 2.0

Closing as dup of the newer bug https://github.com/aspnet/Mvc/issues/6352.

This is not a duplicate of #6352, this bug is about form size limits, not overall request body limits.

I'm getting this error on 1.1.1 trying to upload large files in an mvc controller action.
Multipart body length limit 16384 exceeded
at Microsoft.AspNetCore.WebUtilities.MultipartReaderStream.UpdatePosition(Int32 read)
MultipartReader has a hard-coded HeaderLenghtLimit = 16384. It uses this to set MultipartReaderStream LengthLimit which is used to used to check the body length limit.
https://github.com/aspnet/HttpAbstractions/blob/dev/src/Microsoft.AspNetCore.WebUtilities/MultipartReader.cs#L50
https://github.com/aspnet/HttpAbstractions/blob/dev/src/Microsoft.AspNetCore.WebUtilities/MultipartReaderStream.cs#L156
There is no way to adjust this limit when using MultipartReader.

/cc @Tratcher

@trevordaniels what's the structure of your upload that includes 16kb of preamble data?

Sorry my mistake, this error was caused by using two MultipartReaders. The first one was reading part of the request and tripping up the second reader when it tried to read the stream.

OK, so it sounds like the original issue here is tracking productizing https://github.com/aspnet/Entropy/blob/dev/samples/Mvc.FileUpload/Filters/RequestFormSizeLimitAttribute.cs
I don't think we have a good reason to leave this out of the box.
/cc @eilon 2.1.0?

Yeah.

This was already implemented by @jbagga as part of this commit https://github.com/aspnet/Mvc/commit/17f6b17a6dc0e76606b091187a4e43a184656c89

Are you going to update https://github.com/aspnet/Entropy/blob/dev/samples/Mvc.FileUpload/Filters/RequestFormSizeLimitAttribute.cs now?

Sure, good point.


Remove  or pass in scrollEnabled prop

Great component! : )
Nevertheless, I had to remove ScrollView in order for my form components to stay fixed. Otherwise, any minimal vertical movement would trigger the vertical scroll which is not something desirable, especially with a range select component. I would propose removing ScrollView or allowing the scrollEnabled prop to be passed in, so that it's possible to create fixed position forms.

I think scrollEnabled prop is better. Simply removing scrollview can cause longer forms to break.
Also to handle your specific case setting keyboardShouldPersistTaps="always" on ScrollView should allow vertical sliders to work. Do let me know if that works.


Debounce/sensor delay

Some of my sensors appear to be a bit unstable. Perhaps for example a window shakes a bit like if there is wind. This can cause a sensor to go Open Closed Open Closed in quick succession.
If there is either a global or a sensor-specific setting to add a debounce time, then it could help to resolve some false positive triggers.
If the sensor goes from Open back to Closed within this debounce time, it will be ignored. This could go in the advanced settings for each sensor, or under General settings for a global setting (or both, the advanced settings being an override).
This would obviously add a delay, so if it's a global setting, then it should have a warning note near, or set the minimum Entry Time to the globally set debounce time (just in the GUI, so that the users understand that a delay is applied because of debounce).

Debounce is already applied in case of applying the 'arm after closing' setting for a door sensor.
But as far as I am aware this is the only use-case where debounce is really relevant.
In which scenario would a sensor go (falsely) from Closed to Open state (and back) while the alarm is armed?

I have a garage door that when it closes, the arm does a strange locking movement, and the sensors rapidly goes open closed open closed within 1 or 2 seconds, but I suppose if you've considered the use cases, then that's fine. Thanks