TextField on web with experimental canvas enabled in release mode doesn't show trailing spaces

Steps to Reproduce

In a fresh new flutter project, add a TextField.  For example:
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
        visualDensity: VisualDensity.adaptivePlatformDensity,
      ),
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key key, this.title}) : super(key: key);
  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;

  void _incrementCounter() {
    setState(() {
      _counter++;
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            Text(
              'You have pushed the button this many times:',
            ),
            Text(
              '$_counter',
              style: Theme.of(context).textTheme.headline4,
            ),
            TextField()  // ADD THIS LINE
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: Icon(Icons.add),
      ), // This trailing comma makes auto-formatting nicer for build methods.
    );
  }
}

Run in release mode with experimental canvas enabled:
flutter run -d chrome --release --dart-define=FLUTTER_WEB_USE_EXPERIMENTAL_CANVAS_TEXT=true
In the text field that appears, type some text, then some spaces.  The spaces at the end of the text will not appear (cursor doesn't move) until there is additional text afterwards.
Expected results:
Typing "hello    " would show this (image generated in debug mode instead of release):

Actual results:
Typing "hello    " shows this:

Logs
PS C:\Users\MrMax\Documents\bash_work\debug_web_spaces> flutter run --verbose -d chrome --release --dart-define=FLUTTER_WEB_USE_EXPERIMENTAL_CANVAS_TEXT=true
[ +124 ms] executing: [C:\flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[  +64 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[   +1 ms] a2bde82fbd52e09057a4146f46889f4e10342d32
[        ] executing: [C:\flutter/] git tag --contains HEAD
[ +241 ms] Exit code 0 from: git tag --contains HEAD
[   +1 ms] 1.20.0-7.2.pre
[   +9 ms] executing: [C:\flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[  +40 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] origin/beta
[        ] executing: [C:\flutter/] git ls-remote --get-url origin
[  +35 ms] Exit code 0 from: git ls-remote --get-url origin
[   +1 ms] https://github.com/flutter/flutter.git
[  +77 ms] executing: [C:\flutter/] git rev-parse --abbrev-ref HEAD
[  +40 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[   +1 ms] beta
[  +64 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[   +8 ms] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +5 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[   +2 ms] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[  +12 ms] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +40 ms] executing: C:\Users\MrMax\AppData\Local\Android\sdk\platform-tools\adb.exe devices -l
[  +63 ms] List of devices attached
           emulator-5554          device product:sdk_gphone_x86 model:Android_SDK_built_for_x86 device:generic_x86 transport_id:6
[  +13 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[   +5 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[ +231 ms] Generating C:\Users\MrMax\Documents\bash_work\debug_web_spaces\android\app\src\main\java\io\flutter\plugins\GeneratedPluginRegistrant.java
[ +118 ms] Launching lib\main.dart on Chrome in release mode...
[  +94 ms] Generating C:\Users\MrMax\Documents\bash_work\debug_web_spaces\android\app\src\main\java\io\flutter\plugins\GeneratedPluginRegistrant.java
[  +10 ms] Compiling lib\main.dart for the Web...
[   +9 ms] Initializing file store
[  +20 ms] Done initializing file store
[  +98 ms] Skipping target: gen_localizations
[  +16 ms] Skipping target: web_entrypoint
[ +874 ms] Skipping target: dart2js
[ +116 ms] Skipping target: web_release_bundle
[  +54 ms] Skipping target: web_service_worker
[   +2 ms] Persisting file store
[  +23 ms] Done persisting file store
[  +26 ms] Compiling lib\main.dart for the Web... (completed in 1.2s)
[ +258 ms] [CHROME]:
[   +2 ms] [CHROME]:DevTools listening on ws://<IP_ADDRESS>:50676/devtools/browser/7ee142d4-ee84-4307-a31a-ae0c97844df4
[ +481 ms] Warning: Flutter's support for web development is not stable yet and hasn't
[   +1 ms] been thoroughly tested in production environments.
[   +2 ms] For more information see https://flutter.dev/web
[  +25 ms] �🔥  To hot restart changes while running, press "r" or "R".
[   +2 ms] For a more detailed help message, press "h". To quit, press "q".

PS C:\Users\MrMax\Documents\bash_work\debug_web_spaces> flutter analyze
Analyzing debug_web_spaces...
No issues found! (ran in 2.0s)

> flutter doctor -v
[√] Flutter (Channel beta, 1.20.0-7.2.pre, on Microsoft Windows [Version 10.0.18363.959], locale en-US)
    • Flutter version 1.20.0-7.2.pre at C:\flutter
    • Framework revision a2bde82fbd (2 weeks ago), 2020-07-18 15:16:35 -0700
    • Engine revision 60b269d898
    • Dart version 2.9.0 (build 2.9.0-21.2.beta)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at C:\Users\MrMax\AppData\Local\Android\sdk
    • Platform android-29, build-tools 30.0.1
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 4.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.8052
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] VS Code (version 1.47.2)
    • VS Code at C:\Users\MrMax\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.12.2

[√] Connected device (4 available)
    • Android SDK built for x86 (mobile) • emulator-5554 • android-x86    • Android 10 (API 29) (emulator)
    • Web Server (web)                   • web-server    • web-javascript • Flutter Tools
    • Chrome (web)                       • chrome        • web-javascript • Google Chrome 84.0.4147.105
    • Edge (web)                         • edge          • web-javascript • Microsoft Edge 83.0.478.61

• No issues found!

Hi @mrmax99
This looks to be fixed in latest master

Code Sample
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
        visualDensity: VisualDensity.adaptivePlatformDensity,
      ),
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key key, this.title}) : super(key: key);
  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;

  void _incrementCounter() {
    setState(() {
      _counter++;
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            Text(
              'You have pushed the button this many times:',
            ),
            Text(
              '$_counter',
              style: Theme.of(context).textTheme.headline4,
            ),
            TextField() // ADD THIS LINE
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: Icon(Icons.add),
      ), // This trailing comma makes auto-formatting nicer for build methods.
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel master, 1.21.0-6.0.pre.191, on Mac OS X 10.15.6 19G73,
    locale en-GB)
    • Flutter version 1.21.0-6.0.pre.191 at /Users/taha/Code/flutter_master
    • Framework revision f3b7788f77 (7 hours ago), 2020-08-05 00:11:03 -0400
    • Engine revision e1828008b9
    • Dart version 2.10.0 (build 2.10.0-3.0.dev 987c9e347c)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at /Users/taha/Code/sdk
    • Platform android-30, build-tools 30.0.1
    • ANDROID_HOME = /Users/taha/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.6, Build version 11E708
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 48.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.47.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.13.1

[✓] Connected device (4 available)
    • SM M305F (mobile) • 32003c30dc19668f • android-arm64  • Android 10 (API
      29)
    • macOS (desktop)   • macos            • darwin-x64     • Mac OS X 10.15.6
      19G73
    • Web Server (web)  • web-server       • web-javascript • Flutter Tools
    • Chrome (web)      • chrome           • web-javascript • Google Chrome
      84.0.4147.105

• No issues found!

I cannot reproduce this issue on latest master channel.
Can you upgrade to dev and try again
flutter channel dev
flutter upgrade --force
flutter doctor -v
Thank you

I agree, it looks fixed in the latest master, thanks!

Hi @mrmax99
given your last message I feel safe to close this issue, if you disagree please write in the comments and I will reopen it.
Thank you


ROX-20417: Enable client reconciliation feature flag

Description
Enable feature for 4.3.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change
Tested in all previous PRs

[ ] CI

Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

/retest

/retest

/retest


Not initialized on android when in Shipping mode

Hey. Is there any reason why when i upload to android store, it works when in a development apk pushed via adb. The only difference i can see is that store is built with target 33 and apk was targeting 32

Sorry, I don't get it. Do you mean it doesn't work? Please provide more detailed information or logs.

Ok, heres what i did.
Built for Android 33 - directly to go on the store - distribution - No logs since its shipping
This didnt work. For some reason, the init function itself fails or is never hit. Im checking the blueprint to ensure its not an issue with my own setup, but dont think it is since its working otherwise. This never asked for any permissions.
Built for android 32 - APK - installed via ADB
Works! But never asked for permission. I had to go into app info to enable permissions.
Built for android 33 - APK - installed via ADB
Works! And asked for permissions as well.
Can you make sense of this? Cause the only common point here i can think of is the Play Store.

@WinterPu
So i did some more testing. Voice doesnt work specifically when in shipping mode. All i can get for this is logcat logs.
phoneLogs.log
The app is called ToolboxVR (for searching through it)
When i say it doesnt work, i dont believe that even the initialization is happening because i have a callback connected to show me if theres any change in the connection state even in shipping.
This is what my blueprints look like.
PlayerController calls init and then join channel on the game instance:

This is the init function:

This is the join function:

Ignore the aws lambda stuff, thats simply to get a token to connect.
Some help on this would be great. Im nearing a scary deadline.

Nevermind. I managed to solve this one. Was a BP error


Add ListTask Command documentation

Resolve #70
Add repo-sense link for all members

Do check the repo-sense link in each of ur team.md files to ensure it is correct

LGTM. Thanks for the fix, i've checked all members's reposense and it tallies now. 👍


feat(validation): enhance enum validation

This PR adds:

Supports varidic functions for only and expects
Chainable only or expects

Nice, thanks!


fix: querying on date partitions (fixes #1445)

Description
Fix querying on date partitions
Related Issue(s)

fixes #1445

What can I do to help move this along? We're currently pinning on a copy of this PR plus some merges and would very much like to move to a more official version.

@watfordkcf - seems like there are some tests that need fixing. Haven't had a chance to properly review yet, but it seems they are partially related to a table that was previously commited to the (within this PR) and later removed not being created within the tests.
Other failures are related to column encodings. On first glance related to how we encode the partitioned columns.

Closing since we merged https://github.com/delta-io/delta-rs/pull/1594


Add tests for export job admin progress

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

5 of 5 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+2.0%) to 88.375%

Totals

Change from base Build<PHONE_NUMBER>3:
2.0%

Covered Lines:
1300

Relevant Lines:
1471

💛  - Coveralls


VAT formatter does not work in fr_FR namespace

Hello,
The error occurs when I try to use the vat formatter. This formatter use the siren method which does not exists in the class and its parent. This method seems to be defined in the Faker\Provider\fr_FR\Company class.

Hi @thomasngataly
I think VAT is Payment Provider
Give me a code example please

Hi @raphaeldealmeida
The code inside the VAT method call an undefined siren method. See the code below
public function vat($spacedNationalPrefix = true)     {         $prefix = ($spacedNationalPrefix) ? "FR " : "FR";         return sprintf("%s%s%s%s", $prefix, self::randomNumber(2, true), **$this->siren**($spacedNationalPrefix));     }

Hi
I also have this issue. I've seen that this commit is the one that introduced the change that broke this, because the method siren does not exist in the class Payment for fr_FR locale.

Hi,
Same issue for me, code example to reproduce the issue is simple:
$faker = Factory::create('fr_FR');
echo $faker->vat();

What do you think about making the method static?
    public function vat($spacedNationalPrefix = true)
    {
        $prefix = ($spacedNationalPrefix) ? "FR " : "FR";

-       return sprintf("%s%s%s%s", $prefix, self::randomNumber(2, true), $this->siren($spacedNationalPrefix));
+       return sprintf("%s%s%s%s", $prefix, self::randomNumber(2, true), Company::siren($spacedNationalPrefix));

    }

Fixed by #1381

Does this fix will be released soon

@jdecool see #1391

I saw it, but I can't set a dependency point to the master branch, even if it's only required for development.
This issue was fixed nearly 3 months ago...

I don't know what the policy or planning is for releases but I thought that could help you out in the mean time. Can't be of any more help I'm afraid.

No problem @ppelgrims, thanks for the suggestion :)


According to folder dependency support?（根据文件夹依赖支持吗）

The scripts for different projects are placed under different hierarchical directories. For example, as follows, there may be script dependencies in folder 2, and whether folders and script dependencies can be supported at present.
                Folder 2.1
File 1--"Box 2.2-------" File 3
               Folder 2.3

     不同的项目的脚本放在不同的分层目录下面，举个例子 如下，可能文件夹2中还有脚本的依赖，目前能否支持文件夹和脚本的依赖。
           文件夹2.1

文件1--》文件夹2.2-------》文件3
文件夹2.3

not supoort for now, we will consider this feature if more users need it, so we will keep this issue open.
if anyone else need this featue, please reply "+1"

+1

I have my version of  the granularity as  resource mapping project ，means that resource is related a project

current version ： all resources are put into current tenant root dir
my changed version ： resources can be put into a project dir which can choose or u also can not choose like this picture shows


MUMUP-2577 Add UWRF Freddy Falcon mascot

Add custom mascot for UWRF uw-frame theme.
As a UW-River Falls user, able to see the UWRF mascot announce features, so can be able to regard my.uwrf.edu as part of the friendly UWRF brand.

Coverage remained the same at 34.738% when pulling 07b289f6d347e26a3e2348834f89569c7bb6bd5a on jiayinjx:updateFrameTheme into 0b755b46e0cc34c992253cae983f06ebf885b28f on UW-Madison-DoIT:master.

:+1:


Error with 32k Context

I have trained LLAMA-2-7B with 32k context window still I am getting below error with long context window:-
This is a friendly reminder - the current text generation call will exceed the model's predefined maximum length (4096). Depending on the model, you may observe exceptions, performance degradation, or nothing at all.

Hi,
This is not an error, but just a warning. You need to reset the config like the following before inference.
https://github.com/dvlab-research/LongLoRA/blob/2f050a4393706744a2f604115ed1a8392b9a2426/inference.py#L80
Regards,
Yukang Chen


WIP: feat: Add generate_test_per_endpoint hook

Related issue: #458
This initial PR is a proof of concept and is ready for discussion.
This solution adds a before_one hook. This hook adds a test to the test suite for each before_one hook defined. Each before_one hook receives one of the strategies from one of the additional tests. The hook may update this strategy before a request is sent to the server. Since each strategy produces data that is valid against the schema, it allows the user to alter an otherwise valid strategy to produce requests that target specific behavior of the server.
Additional Questions and Needs:

Tests
Does this implementation duplicate requests generated from an example (i.e. --hypothesis-phases=explicit)? Because an example request is (in my experience) the best representation of a valid request, I would like the duplicated tests to come from examples if they exist and randomly generated, valid data otherwise.
Is the GLOBAL scope appropriate for this hook?
Is it OK that we have to get the before_one hooks in two places (threadpool.py and schemas.py)?

Hi @barrett-schonefeld
Sorry for not getting back to you. Thank you for your contribution, I'll try to find a timeslot to review your PR in the next few days :)

Regarding your questions:

Tests

I think that we need to test it in CLI & in-code cases. Usually, I do such kind of tests with the testdir fixture. There are some examples in test/cli/test_commands.py. Let me know if I can provide more information on tests

Does this implementation duplicate requests generated from an example (i.e. --hypothesis-phases=explicit)? Because an example request is (in my experience) the best representation of a valid request, I would like the duplicated tests to come from examples if they exist and randomly generated, valid data otherwise.

Examples are added a bit later in create_test, so examples will be duplicated since this function creates separate hypothesis test functions and each will have its own @example decorator

Is the GLOBAL scope appropriate for this hook?

I believe it could be on all scopes. It might be easier to implement if hooks will be extracted inside create_test (there are local hook dispatcher and endpoint.schema.hooks so it is easier to get in a single place)

Is it OK that we have to get the before_one hooks in two places (threadpool.py and schemas.py)?

Probably it is better to isolate inside create_test. At least now I think that it might be easier and more flexible if it will be implemented as a generator (as I described in comments)

Looks great! Could you, please, rebase?
I can do some more review tomorrow

Sounds great! Will rebase and push latest updates.
Still need to:

Test my implementation.
Know if the hooks will modify requests generated from OpenAPI examples. My intuition is that the current implementation will not modify requests generated from OpenAPI examples, but I need to explore this more thoroughly.

@Stranger6667 how a strategy converted to a Case?
It seems SearchStrategy and Case are used somewhat interchangeably. For example, this get_example function returns a Case. The return statement, however, uses a function that returns a SearchStrategy.
I don't see any explicit relationships between them in code (neither object is a descendant of the other). Could you explain how they are related and possibly point to code that shows how the conversion is done?

@barrett-schonefeld

Is there a particular piece of code responsible for getting Case objects generated from Hypothesis.core.given?

This part is here. The idea is to use st.builds that will create instances of Case during test runs. But, for examples, we need to have instances before a test run to add them via hypothesis.example decorator. Often examples are incomplete and we take static parts from example fields in the schema and generate the rest by using .example() call on a strategy. example is often is not representative and is not recommended to use (given is preferred), but we don't care about these disadvantages since we need to fill gaps in a Case instance that will be used. Also, it is possible, that the schema has all data and in this case, generation will be a no-op (but actually slower than it could be - we can just create an instance straight away in this case). More info on how builds works is here.

I have not found code where Case.call is used to make a request.

There are two places:

HTTP is in the network_test function here
WSGI is in the wsgi_test function here

For this PR, would it be better for the generate_test_per_endpoint hooks to accept a Case or a SearchStrategy?

I thought that it aims to generate an additional test in a sense of an extra endpoint :( With the current approach, it will be generated per endpoint (which means also an extra line in the output). However, it could be done this way by creating a strategy with one possible output, but if it should be one test (in a sense of request) then it is better to have a hook somewhere below in the runner, for example in network_test.
It seems to me that both approaches could be useful in different circumstances. The approach with a hook inside of network_test / wsgi_test should be simpler to implement, but we'll need to decide how to treat the statistic - we can just call run_checks & store_requests_response on the generated extra response (not sure about run_targets).
Having all of this I think that the latter approach can be represented as a hook that accepts Case instance. And it looks like that the goals can be fulfilled with this approach

Closing this PR in favor of #590.


Fix high cpu caused by early stop when generating secret

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ X ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.
The ExponentialBackOff has a default 15min's MaxElapsedTime which will bring the state to STOP after that time. And the use code will enter a nearly infinite loop and cause very high CPU. This change sets the MaxElapsedTime to 0 with no-stop semantic.

Hi @YonkaFang. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@YonkaFang: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
af06bf518a76330b12f650fe37305c57618c1cfa
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@YonkaFang: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
af06bf518a76330b12f650fe37305c57618c1cfa
link
/test release-notes_istio

integ-pilot-k8s-tests_istio
af06bf518a76330b12f650fe37305c57618c1cfa
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@YonkaFang: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
af06bf518a76330b12f650fe37305c57618c1cfa
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest
known flake


Add hyperlink to referenced models

I'd add an hyperlink to referenced models. E.g. for this entry https://ilimodels.ch/detail/c5adc4042909326c16014763d30cc00c/Alpenkonvention_V1_1 I'd let "GeometryCHLV95_V1" point to https://ilimodels.ch/detail/c407a562e1e4ecbf4669228ffaa3e050/GeometryCHLV95_V1

@p1d1d1 What will happen if there are two models with the same name? Since they are not really imported "fully qualified".

I'm refering to this:

Cannot be hyperlinked?

MODEL Alpenkonvention_V1_1 (de)
AT "https://models.geo.admin.ch/ARE/"
VERSION "2020-11-19"  =
  IMPORTS GeometryCHLV95_V1;

If I put GeometryCHLV95_V1 in our repository. To which model do you link?
(definitely happens with the sia models ;))

No idea! We could maybe link to something like https://ilimodels.ch/?query=GeometryCHLV95_V1 ?

we can add the link suggested from @p1d1d1 to the items we provide under "Referenzierte Modelle". We publish a concrete URL in the case we get an address like to cataloguefiles from ilidata (f.e.: https://ilimodels.ch/detail/705b3943db8e1caab1af47c427e92547/SanierungWasserkraft_LV95_V1_1)


[Merge] MONDO:0009997	Roberts syndrome

Mondo term (ID and Label)
MONDO:0009997	Roberts syndrome
Reason for deprecation
duplicate
Term to be merged with
MONDO:0100253	Roberts-SC phocomelia syndrome

I need to revisit this, see: https://github.com/monarch-initiative/mondo/issues/2553
https://omim.org/entry/268300
Also, the grouping class 'non-syndromic limb reduction defect' does not seem correct. This is related to the primary bone dysplasia ticket, see spreadsheet

'SC phocomelia syndrome' should be merged into 'Roberts-SC phocomelia syndrome' as well. I added it to the obsoletion list.

Also, the grouping class 'non-syndromic limb reduction defect' does not seem correct. This is related to the primary bone dysplasia ticket, see spreadsheet

I think this is correct, I don't remember why I thought otherwise.

I don't think these should be merged. Closing. If anyone disagrees, please reopen, thanks!

Hi Nicole: why did you opt not to merge SC phocomelia syndome with the broader roberts-sc phocomelia syndrome? I dont see current sources in Mondo to support MONDO:0100282 as a separate concept anymore.

@kanems I'll look into this and get back to you asap.

Looking into this again, I do agree that MONDO:0009997 Roberts syndrome should be merged with MONDO:0100253 Roberts-SC phocomelia syndrome, this is what OMIM has done. (I don't remember my reasoning for closing this before).

it seems like 'SC phocomelia syndrome' should be merged into 'Roberts-SC phocomelia syndrome' as well, per OMIM.


Added Netflix Clone as a Web Development Project

Tech Stack: HTML and CSS
Screenshots for reference:

all check are failed

Since all checks have failed, I will be closing the pull request. Please create a new one and include the issue number.


[Refactor] ES6

Refactor Tasks
[x] Change Directory to src
[x] Flatten namespacing to follow directories
[x] Refactor to ES6 classes
[x] Apply ESFormatter
[ ] Create new tests (refactor?)
Notes:

There are commands to build CommonJS, AMD, or UMD
$ npm run build-commonjs
$ npm run build-amd
$ npm run build-umd
These commands will build into their associated directory under the dist directory. It should be easy enough to also develop against these builds. We may have to create some shell branches for dev builds at some time, but for now this should be a good solution.
I use Atom as an editor and ESFormatter. ESFormatter has been added to the repo devDependencies. I am not stuck on this if you have a better code formatter.
This refactor has flattened out the namespacing to be inline with the export locations of files. If I namespace should be in a different location, then the script file needs to be changed to that location. Namespacing should allow a coder to find the file where it is supposed to be and not have to click around searching.

Mute point at this time. I feel there is too much work to be done to make the engine viable in the state it is in.


Add docs about filtering and indexes on numeric columns.

Docs describing how to filter on numeric columns, and describing the performance tradeoffs of string vs numeric columns. I tagged this with 0.10.0 since numeric dims are a new feature and this will help people understand how to use them.

:+1:


bugfix: global session is always begin in saga mode

fixes #5045
#5050 can not fix this bug,because in saga mode,when a global transactional end , TM report the global session status to TC rather than do commit or do rollback

Codecov Report

Merging #5145 (319c1a1) into develop (bf99018) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

:exclamation: Current head 319c1a1 differs from pull request most recent head a9f6ea5. Consider uploading reports for the commit a9f6ea5 to get more accurate results

@@              Coverage Diff              @@
##             develop    #5145      +/-   ##
=============================================
- Coverage      48.95%   48.93%   -0.03%
+ Complexity      4168     4162       -6
=============================================
  Files            741      741
  Lines          26521    26525       +4
  Branches        3294     3294
=============================================
- Hits           12984    12979       -5
- Misses         12129    12138       +9
  Partials        1408     1408

Impacted Files
Coverage Δ

...in/java/io/seata/server/session/SessionHelper.java
64.81% <0.00%> (-2.50%)
:arrow_down:

...ava/io/seata/server/transaction/saga/SagaCore.java
2.75% <0.00%> (ø)

...ver/storage/redis/session/RedisSessionManager.java
45.61% <0.00%> (-5.27%)
:arrow_down:

...o/seata/server/coordinator/DefaultCoordinator.java
47.54% <0.00%> (-1.23%)
:arrow_down:

...very/registry/zk/ZookeeperRegisterServiceImpl.java
61.02% <0.00%> (-0.74%)
:arrow_down:

...erver/storage/file/session/FileSessionManager.java
53.50% <0.00%> (-0.64%)
:arrow_down:

...in/java/io/seata/server/session/GlobalSession.java
78.68% <0.00%> (ø)

...rage/redis/store/RedisTransactionStoreManager.java
74.93% <0.00%> (+0.26%)
:arrow_up:

...torage/file/store/FileTransactionStoreManager.java
56.27% <0.00%> (+0.64%)
:arrow_up:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@tuwenlin Pls add change.

@tuwenlin Pls add change.

done

Saga mode can consider switch globalReport to commit/rollback，makes it consistent, reduce the judgment like isSaga .


Additional Information for Washer & Dryer

Hello,
Would be great if Washer & Dryer would display in homekit also the program running on machine and the stage: Washing, rinsing etc.
Thanks !

homekit don't support this type of data, maybe in near future, when homekit official support washer, I'll update it


Layout omit image.ref.name annotation

Fixes #869
Signed-off-by: Furkan<EMAIL_ADDRESS>Co-authored-by: Batuhan<EMAIL_ADDRESS>cc @developer-guy

[ ] tests a bit missing, we will add some assertions to check if all annotations are valid and correct. (if overall idea is OK)

DEMO
$ KO_DOCKER_REPO="foo" LDFLAGS="-s" go run . build -t foo,bar,baz --push=false --oci-layout-path test .

$ cat test/index.json | jq

{
  "schemaVersion": 2,
  "manifests": [
    {
      "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
      "size": 1943,
      "digest": "sha256:99a7a7bf1ad3fde0107b1f5909bb9a1df037f8be8b73e73d1779a0fd473cf1ed",
      "annotations": {
        "org.opencontainers.image.ref.name": "foo"
      }
    },
    {
      "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
      "size": 1943,
      "digest": "sha256:99a7a7bf1ad3fde0107b1f5909bb9a1df037f8be8b73e73d1779a0fd473cf1ed",
      "annotations": {
        "org.opencontainers.image.ref.name": "bar"
      }
    },
    {
      "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
      "size": 1943,
      "digest": "sha256:99a7a7bf1ad3fde0107b1f5909bb9a1df037f8be8b73e73d1779a0fd473cf1ed",
      "annotations": {
        "org.opencontainers.image.ref.name": "baz"
      }
    }
  ]
}

also ccing @imjasonh @jonjohnsonjr 🙈

Codecov Report

Merging #870 (0df8f7d) into main (f158992) will decrease coverage by 0.05%.
The diff coverage is 45.83%.

@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
- Coverage   51.29%   51.24%   -0.06%
==========================================
  Files          44       44
  Lines        3394     3413      +19
==========================================
+ Hits         1741     1749       +8
- Misses       1426     1436      +10
- Partials      227      228       +1

Impacted Files
Coverage Δ

pkg/commands/resolver.go
35.87% <0.00%> (ø)

pkg/publish/layout.go
43.07% <47.82%> (-0.41%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

/check-cla

kindly ping @imjasonh ☝

kindly ping @Dentrax, we should fix the tests 🙈

kindly ping @imjasonh 🙈

kindly ping @imjasonh 🕺🏻

@jonjohnsonjr any concerns?

kindly ping @jonjohnsonjr @imjasonh, it seems that everything is working fine.

kindly ping @Dentrax


App stuck in onboarding, arrow to continue to the app is missing [XCode 15.1 RC]

Summary: While testing XCode 15.1 RC We noticed that the app is not rendering the arrow that allows te user to finish the onboarding steps and get into the app. It also shows a warning and an error.
Replication steps

Get latest version of Wonderous app (This is the log when this issue was created - commit https://github.com/gskinnerTeam/flutter-wonderous-app/commit/432becb17a38dbb6c995ea5aadfe99207f0ade74 (HEAD -> main, origin/main, origin/HEAD)
Run Wonderous in the ios 17.2 simulator with Xcode 15.1 RC1.
Navigate to the last step of the onboarding.

Expected Results:
The user should be able to navigate out of the onboarding and into the first wonder.
Actual Results:
Navigation is not possible and the user is stuck on the onboarding.
Screenshots or Video: https://drive.google.com/file/d/1uXS_AQhdinPG1FHx28J9LGzxL03m0seY/view?usp=sharing
Logs
Warning: Error creating LLDB target at path '/Users/josefinadiz/Library/Developer/Xcode/DerivedData/Runner-dvabjmmhwocuqjcmyfiggzukgnem/Build/Products/Debug-iphonesimulator/Runner.app'- using an empty LLDB target which can cause slow memory reads from remote devices.

objc[7879]: Class AKAlertImageURLProvider is implemented in both /Library/Developer/CoreSimulator/Volumes/iOS_21C62/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 17.2.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/AuthKitUI.framework/AuthKitUI (0x14c39a628) and /Library/Developer/CoreSimulator/Volumes/iOS_21C62/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 17.2.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/AuthKit.framework/AuthKit (0x133f239a0). One of the two will be used. Which one is undefined.

[ERROR:flutter/shell/platform/darwin/graphics/FlutterDarwinContextMetalImpeller.mm(42)] Using the Impeller rendering backend.

flutter: The Dart VM service is listening on http://<IP_ADDRESS>:51171/7XHZX79rjNE=/

flutter: bootstrap start...

flutter: Navigate to: /

flutter: Saving...

flutter: Navigate to: /welcome

flutter: Saving...

Flutter Doctor Output
Flutter (Channel stable, 3.16.2, on macOS 14.1.1 23B81 darwin-arm64, locale en-US)

Flutter version 3.16.2 on channel stable at /Users/josefinadiz/Desktop/flutter/flutter

Upstream repository https://github.com/flutter/flutter.git

Framework revision 9e1c857886 (5 days ago), 2023-11-30 11:51:18 -0600

Engine revision cf7a9d0800

Dart version 3.2.2

DevTools version 2.28.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)

Android SDK at /Users/josefinadiz/Library/Android/sdk

Platform android-34, build-tools 34.0.0

Java binary at: /opt/homebrew/opt/openjdk/bin/java

Java version OpenJDK Runtime Environment Homebrew (build 20.0.1)

All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.1)

Xcode at /Applications/Xcode.app/Contents/Developer

Build 15C65

CocoaPods version 1.12.1

[✓] Chrome - develop for the web

Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.84.2)

VS Code at /Applications/Visual Studio Code.app/Contents

Flutter extension version 3.78.0

[✓] Connected device (4 available)

iPhone 13 de Josefina  (mobile) • 00008110-0002751E2E90401E            • ios            • iOS 17.1.2 21B101

iPhone 15 (mobile)              • D9487425-C333-4B4A-9BE0-87549BCE1CC6 • ios            •

      com.apple.CoreSimulator.SimRuntime.iOS-17-2 (simulator)

macOS (desktop)                 • macos                                • darwin-arm64   • macOS 14.1.1 23B81

      darwin-arm64

Chrome (web)                    • chrome                               • web-javascript • Google Chrome

      119.0.6045.199

[✓] Network resources

All expected network resources are available.

The Issue seems to be in the file intro_screen.dart, There is a widget  called PreviousNextNavigation  which handles the introComplete Process.
The widget PreviousNextNavigation is actually returning the child  in mobile platforms while in web it's another view which has some buttons.

 PreviousNextNavigation(
              maxWidth: 600,
              nextBtnColor: _isOnLastPage ? $styles.colors.accent1 : null,
              onPreviousPressed: _isOnFirstPage ? null : () => _incrementPage(-1),
              onNextPressed: () {
                if (_isOnLastPage) {
                  **__handleIntroCompletePressed();_**
                } else {
                  _incrementPage(1);
                }
              },
              child: Stack(
                children: [
                  // page view with title & description:
                  MergeSemantics(
                    child: Semantics(

In PreviousNextNavigation (The  Widget returns child in Mobile Platforms)
  @override
  Widget build(BuildContext context) {
    **_if (PlatformInfo.isMobile) return widget.child;_**
    return Listener(
      onPointerSignal: widget.listenToMouseWheel ? _handleMouseScroll : null,
      child: FullscreenKeyboardListener(
        onKeyDown: _handleKeyDown,
        child: Stack(
          children: [
            widget.child,
            Center(
              child: SizedBox(
                width: widget.maxWidth ?? double.infinity,
                child: Padding(
                  padding: EdgeInsets.symmetric(horizontal: $styles.insets.sm),
                  child: Row(
                    children: [
                      CircleIconBtn(
                        icon: AppIcons.prev,
                        onPressed: widget.onPreviousPressed,
                        semanticLabel: 'Previous',
                        bgColor: widget.previousBtnColor,
                      ),
                      Spacer(),
                      CircleIconBtn(
                        icon: AppIcons.prev,
                        onPressed: widget.onNextPressed,
                        semanticLabel: 'Next',
                        flipIcon: true,
                        bgColor: widget.nextBtnColor,
                      )
                    ],
                  ),
                ),
              ),
            ),
          ],
        ),
      ),
    );
  }

The Child widgets is a stack and sadly there are no widgets that uses __handleIntroCompletePressed();_
 child: Stack(
                children: [
                  // page view with title & description:
                  MergeSemantics(
                    child: Semantics(
                      onIncrease: () => _handleSemanticSwipe(1),
                      onDecrease: () => _handleSemanticSwipe(-1),
                      child: PageView(
                        controller: _pageController,
                        children: pages,
                        onPageChanged: (_) => AppHaptics.lightImpact(),
                      ),
                    ),
                  ),

                  IgnorePointer(
                    ignoringSemantics: false,
                    child: Column(children: [
                      Spacer(),

                      // logo:
                      Semantics(
                        header: true,
                        child: Container(
                          height: _logoHeight,
                          alignment: Alignment.center,
                          child: _WonderousLogo(),
                        ),
                      ),

                      // masked image:
                      SizedBox(
                        height: _imageSize,
                        width: _imageSize,
                        child: ValueListenableBuilder<int>(
                          valueListenable: _currentPage,
                          builder: (_, value, __) {
                            return AnimatedSwitcher(
                              duration: $styles.times.slow,
                              child: KeyedSubtree(
                                key: ValueKey(value), // so AnimatedSwitcher sees it as a different child.
                                child: _PageImage(data: pageData[value]),
                              ),
                            );
                          },
                        ),
                      ),

                      // placeholder gap for text:
                      Gap(_IntroScreenState._textHeight),

                      // page indicator:
                      Container(
                        height: _pageIndicatorHeight,
                        alignment: Alignment(0.0, 0),
                        child: AppPageIndicator(
                            count: pageData.length, controller: _pageController, color: $styles.colors.offWhite),
                      ),

                      Spacer(flex: 2),
                    ]),
                  ),

                  // Build a cpl overlays to hide the content when swiping on very wide screens
                  _buildHzGradientOverlay(left: true),
                  _buildHzGradientOverlay(),

                  // nav help text:
                  if (PlatformInfo.isMobile) ...[
                    BottomCenter(
                      child: Padding(
                        padding: EdgeInsets.only(bottom: $styles.insets.lg),
                        child: _buildNavText(context),
                      ),
                    ),
                  ]
                ],
              ),

Thanks for the report, this has been fixed in 91c8cb97


release note: add item for apply_on_stream_done ratelimit API

This is a follow up on #37548, and forgot to add
the release note in the PR.

cc @phlax


Since updating, font size is inconsistent

VSCode Version: 1.46.1
OS Version: mac OS Catalina, 10.15.3

Steps to Reproduce:
Since updating, the font size has been inconsistent between files. Files with fewer lines of code render with very large font sizes. If I try to zoom out, the font size is so small it's unreadable in bigger files. I have inspected with dev tools, and even with editor.fontSize: 13, the HTML in the picture below is at 28px.
 Yes.

@kira-m
Can you please check both your user settings and workspace settings? It looks like some language specific setting defines the font size to be larger for HTML files.
Does this reproduce when disabling all extensions?  Press F1 and then choose Developer: Reload Window with Extensions Disabled

@alexdima
Unfortunately it's not only HTML files. It seems to be based on how many lines are in the file - the font is bigger on shorter files.
It does persist with extensions disabled; I've attached a screenshot which was taken with extensions disabled. The fonton the left is 20px, and the font on the right is 12px (default editor font size) according to dev tools.
I've disabled any settings related to font - ligatures, fontFamily, etc.

turns out a repository that I was working on had a .vscode folder which was overriding my settings, so I'm closing this issue. Thanks!


Refactor C++ examples codes

This PR includes these features:

Re-define compilation time, remove the time spent on loading models from it.
Add first inference for warming up when setting nIter>1 for performance measurement.
Refactor and simplify codes for supporting other image classification examples more easily in the future.

All examples and model tests can pass. PTAL, thanks! @fujunwei

@mingmingtasd , please help solve the conflicts. Thanks!

@mingmingtasd , please help solve the conflicts. Thanks!

Yes, I have solved them, thanks! @huningxin

I have updated as you suggested, PTAL again, thanks! @fujunwei


The deprecated pex.pex_bootstrapper.bootstrap_pex_env API does not scrub pex.third_party.

The pex.pex_bootstrapper.bootstrap_pex_env is maintained for legacy consumers, including https://github.com/pantsbuild/lambdex and https://github.com/kwlzn/pyuwsgi_pex. As such, despite the __pex__ magic import package prefix which obviates the need for the entrypoint generally and the pex3 venv create --prefix tool for the Lambdex use case in particular, the API should be fixed to scrub pex.third_party vendored imports and the Pex bootstrap from the sys.path like the pex.pex.PEX.execute standard entry point does. Without this, errors like the following are seen for user-code that depends on the latest versions of attrs - which Pex vendors at ~21.5.0 (this is from the Lambdex use case with a user code dependency on attrs 23.1.0 and using Pex 2.1.134):
Unable to import module 'lambdex_handler': cannot import name 'AttrsInstance' from 'pex.vendor._vendored.attrs.attr' (/var/task/.bootstrap/pex/vendor/_vendored/attrs/attr/__init__.py)

The issue is here:
https://github.com/pantsbuild/pex/blob/ae83e326c2ba42a6d56ceb6beb4ce134aded844b/pex/pex_bootstrapper.py#L693-L702
Which fails to do the scrubbing found here before returning from the function:
https://github.com/pantsbuild/pex/blob/ae83e326c2ba42a6d56ceb6beb4ce134aded844b/pex/pex.py#L607-L634
The example failing lambdex in the OP above was fixed with this patch:
+++ .bootstrap/pex/pex_bootstrapper.py.orig     2023-07-22 16:43:47.570107642 +0000
--- .bootstrap/pex/pex_bootstrapper.py  2023-07-22 16:52:07.720031735 +0000
@@ -700,11 +700,3 @@
     from .environment import PEXEnvironment

     PEXEnvironment.mount(entry_point, pex_info).activate()
+
+    from . import third_party
+    from .bootstrap import Bootstrap
+    third_party.uninstall()
+    bootstrap = Bootstrap.locate()
+    bootstrap.demote()
+    import pex
+


Update to latest on Winget

The latest version of Bulk-Crap-Uninstaller [v5.8.1) is currently not available on Winget. Adding the latest version to Winget would be beneficial for Windows users who use this tool to manage their software.
Appreciate all the work done on Bulk-Crap-Uninstaller and hope this can be updated soon.

I have manually created a PR for now:

https://github.com/microsoft/winget-pkgs/pull/171036


make all gn example builds export the compile commands

Problem
compile_commands.json is really helpful for IDEs/autocomplete.
Change overview
Make build_examples.py generate this file automatically, since there seems to be little downside (some extra storage and time, but likely  minimal) and great benefit (ide autocomplete).
Testing
Unit tests  validate this
Ran a build and found compile_commands.json exists in the output directory.

fast track: trivial change that does not affect functionality

Fast tracking, as this is updating our tools


Orbit <> Discord integration

Checklist

[x] I have read the Contributor Guide
[x] I have read and agree to the Code of Conduct
[x] I have added a description of my changes and why I'd like them included in the section below

Description of Changes
WIP

Closing for now as we may be able to use an official integration from Orbit in January


New version: LutzRoeder.Netron version 7.3.8

Pull request has been created with Komac v1.11.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

For moderators
This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping @Exorcism0666, I'll get a notification.

[!important]
Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください！

[Policy] Needs-Attention
@stephengillie - Can you add this package in your auth list? The publisher @lutzroeder usually submits PRs for this package.

@mdanish-kh,
Should this be a "should" or "must"? "Should" will alert but still approve, while "must" blocks the approval.

@stephengillie
I believe it can be a "should" unless @lutzroeder feels that any modifications to Netron's manifests are to be restricted


[SPARK-23944][ML] Add the set method for the two LSHModel

What changes were proposed in this pull request?
Add two set method for LSHModel in LSH.scala, BucketedRandomProjectionLSH.scala, and MinHashLSH.scala
How was this patch tested?
New test for the param setup was added into

BucketedRandomProjectionLSHSuite.scala

MinHashLSHSuite.scala

Please review http://spark.apache.org/contributing.html before opening a pull request.

Can one of the admins verify this patch?

add to whitelist

Test build #89079 has started for PR 21015 at commit 9f16ea6.

Test build #89079 has finished for PR 21015 at commit 9f16ea6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89079/
Test PASSed.

LGTM
Merging with master
Thanks @ludatabricks !


No newick file

This PR removes the redundant storage of the newick serialization of a tree as FileContent.
It also removes the unnecessary requirement pyglottolog.

Codecov Report

Merging #451 into master will increase coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #451     +/-   ##
=========================================
+ Coverage   93.92%   94.03%   +0.1%
=========================================
  Files          24       24
  Lines        1565     1559      -6
=========================================
- Hits         1470     1466      -4
+ Misses         95       93      -2

Impacted Files
Coverage Δ

dplace_app/models.py
98.12% <ø> (-0.02%)
:x:

dplace_app/loader/tree.py
92.04% <ø> (-0.35%)
:x:

dplace_app/migrations/0001_initial.py
100% <ø> (ø)
:white_check_mark:

dplace_app/tree.py
96.07% <100%> (+3.77%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e1eba2...9a8610c. Read the comment docs.

merge?

done!


rule suggestion hash inside array

When a ruby hash is the last item in an array, we can use the same shorthand syntax as for method calls. It would be nice to have a linter to enforce one style or another:
# braces
my_array = ['foo', 'bar', { baz: 'butz' }]

# no_braces
my_array = ['foo', 'bar', baz: 'butz']

We should also add a rule about this in the style guide. I definitely think the preferred practice should be to use curly braces.

Unless this has been resolved without my knowledge, please re-open the issue


Screen Recording

Description of the new feature / enhancement

Full screen recording
scheduled recording
designated area recording
One click recording

recording can be displayed and saved after completion
Scenario when this would be used?
Quick recording
Supporting information
Similar products: Zoomlt

Built into windows via snipping tool.


Provide a "focus-follow-mouse" setting

I am used for years (X11 times) with focus following the mouse, instead of having to click to type (which is slow, and wears).

This feature will be very handy particularly for Linux users like me who has the habit of enabling the focus follows mouse feature in the window manager...

This is not only a Linux issue but a Windows one as well
https://superuser.com/a/1209478/76968

It's also a Mac issue; Terminal.app has this as a configuration via the defaults interface: https://osxdaily.com/2011/04/18/terminal-focus-follow-mouse-mac/

Would love to see this!
Windows supports it (although it can only enabled via WinAPI or registry changes), Windows Terminal also supports it since 1.7. Now only VSCode needs it for switching focus between terminal(s), open editors, and the sidebar/toolbar elements.

I would love to have this. I use it for all my terminals and I always forget to click the integrated terminal in vscode, its very annoying.
I know this must be a hard to implement feature.
Thanks code team for the good work you are doing! :)

Clicking files in a multi-pane layout can lead to inadvertently moving selected text, or inadvertently canceling a text selection.
This feature would help correct these potential problems, and it would help VSCode fall better in line with Linux environments where focus-follows-cursor is heavily in use (as with https://github.com/i3/i3 and https://github.com/software-jessies-org/jessies/tree/master/terminator)

I have a super ultra wide monitor.  with the terminal panel on the right side of the screen, this function would basically allow me to live in vscode.

Yes, focus should strictly follow mouse between all sub windows! Not only between editor and terminal, but also between different editors and terminals and side bar.

+1 This is also an important usability feature for people on the move using trackpads who need to minimize their clicking due to RSI.

This has been open for quite a while now. Anyone knows if it'll be worked on? Other duplicates have been closed, not this one 🤔

I hope that it stays open as it is a feature I would really like to see.

I would love it too. Im using external terminal because this.
El mié, 4 may 2022 a las 3:29, Charles Ulrich @.***>)
escribió:

I hope that it stays open as it is a feature I would really like to see.
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/93772#issuecomment-1116852752,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFH52GKXIBLQKHX525ROKCTVIHHILANCNFSM4LWXQPQA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

hold Ctrl and enable focus in sections by mouse moves.
release Ctrl to back focus to the previous state.

This doesn't work across the window, to go to the Terminal, for example.

This doesn't work across the window, to go to the Terminal, for example.

We can ignore release ctrl to back to previous state.
btw I think hold a key and move mouse to active that state is the best solution.

hold Ctrl and enable focus in sections by mouse moves. ~release Ctrl to back focus to the previous state.~

I think focus-follows-mouse functionality should be selectable as a persistent setting, having to press or hold down keys is not the same.

This is almost a safety issue. The number of times that I've started typing with my mouse in one window and focus in another is countless. One of these days, I'm going to hit the Del key while I think that I'm in an editor or terminal window and I'm going to nuke a file in the File Explorer where the Del key means "Delete permanently".

I have become so accustomed to 'focus-follows-mouse' in all other environments that it took me a few days to figure out why I was having issues with the Integrated Terminal!

For me the current solution unfortunately can only be not to use terminal windows in vscode but to use an external terminal. I am just done with destroying editor contents after moving the mouse into the terminal subwindow and forgetting to click.

I just moved to a new company which largely uses VS Code as their development platform on Linux. So far, overall it's not bad, but the fact that focus doesn't follow mouse is a constant source of aggravation for me.
I'm always typing terminal commands into my source-code or, worse (when working on a shell script) typing shell commands directly into the terminal.. it's only a matter of time before I rm -RF * in an important directory.
Please default Focus to OS settings and provide an override within VS Code for broken OS's or for people who want one behaviour on their Desktop and another within VS Code. Ie, options should be "Default Focus", "Focus follows Mouse", or "Click to Focus".
But seriously, this is a no-brainer to want to support, especially given the lack of hot-keys to switch between different panels (OT, but Ctrl-Alt- and some visible indicator as to what the active panel is would be nice..) .

I would like to see this feature, too.

it's only a matter of time before I rm -RF * in an important directory.
^

This... @mwerle said it.

I use the Vi/Vim editor extensions and vi mode on the command line in my shell.  It's very efficient, same keys for editing text and my command history. The edit commands are muscle memory.
Outside of VSCode all my windows on macOS have "raise on focus" and "focus follows mouse".  The raise isn't so important, but focus following the mouse from pane to pane would be great.
Because I use Vi mode on the command and in the edit panes, I can't count how many times I've moved the mouse from the editor into the terminal and begin typing and do potential damage to a file I was editing. What's worse is I may have 4 vertical panes open and go to enter commands on the command line and only after I've typed a bit notice nothing has echoed. Only to find I've just performed unknown edits to one of my edit panes and am not sure which one was active at the time. VSCode actually isn't too bad, I actually like it, but yeah, I guess I gotta change my workflow.
Please fix this before my finger suffers RSI, or I throw the keyboard and trackpad at my monitor. This can't be that difficult.

Please add this. The behavior change between all the other windows on my desktop and the windows within VSCode basically make VSCode unusable for me.
Also, clicking on windows to be able to interact with them is sloooooooooooooooow, please give us that productivity boost.

I just typed Ctrl-Q to quit out of Micro (don't judge me!) running in the integrated terminal (yes, I'm aware I have another text editor right there, but muscle memory) and accidentally quit VSCode because I forgot to click on the terminal to focus it. Needless to say, my productivity was impacted.
I would love it if the VSCode peeps could implement this feature.

I tried VS code few years ago, I gave up because I am too much used to have this option. I retried now, VS has plenty wonderful options, but I cannot work without focus follow mouse. So if you can add it, it would be very nice.

Add it. Jesus, I could implement it over a weekend.

Add it.
Jesus, I could implement it over a weekend. Don't make me do it and embarrass you.

Why don't you do it then? That's the point of open source software. Nobody here is working for your hire.

Having some fun with ya's. Just go ahead and do it already.

Is there no persistent configuration setting for VS Code to enable the window focus to be "follows mouse"?   Just learning VS Code and can't find anything.  Found this thread that's over 3 years old.  Apparently it's never been added/fixed.   Not sure what the comment a ways back in time that says "moved to backlog" means.  Is this getting fixed sometime?

Is there no persistent configuration setting for VS Code to enable the window focus to be "follows mouse"?

Not yet.

Not sure what the comment a ways back in time that says "moved to backlog" means. Is this getting fixed sometime?

At least 20 people upvoted this issue in the Backlog Candidates to prevent it from being closed. It subsequently made it into the Backlog.
Aside: it's surprising to me that there is no search box for milestones. The backlog has about 4,000 issues open and 9,000 issues closed and it seems like the way you search this is by scrolling to the bottom for minutes at a time while they lazily load and then Ctrl-F. I'm still searching, TBH.
One of the other commenters suggested the current issue might be a weekend job. Indeed, how hard could it be? I was curious.
$ cd vscode/src
$ cloc .
    4343 text files.
    4310 unique files.
     184 files ignored.

3 errors:
Line count, exceeded timeout:  ./vs/workbench/api/test/node/extHostSearch.test.ts
Line count, exceeded timeout:  ./vs/workbench/contrib/extensions/test/electron-sandbox/extensionRecommendationsService.test.ts
Line count, exceeded timeout:  ./vs/workbench/contrib/interactive/browser/interactive.contribution.ts

github.com/AlDanial/cloc v 1.90  T=9.18 s (453.9 files/s, 132103.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
TypeScript                    3721         166480         108335         864608
JavaScript                      50           1638           2544          31171
CSS                            222           4165           1503          18846
JSON                           114              1              0           6249
HTML                            16            423             34           2968
SVG                             28             24              9           1873
Bourne Shell                     4             54             65            295
zsh                              4             33             38            161
PowerShell                       1             19             45            131
Markdown                         3             34              0            125
Fish Shell                       1             21             49            121
LESS                             1              1              1              0
-------------------------------------------------------------------------------
SUM:                          4165         172893         112623         926548
-------------------------------------------------------------------------------
$ find . -name '*.ts' -exec grep -i focus {} /dev/null \; | grep -v test | wc -l
9514

She's a big 'un. And one of a couple of Microsoft projects where sloppy focus mode is a neglected feature.
Looking at those other issues reminds me: we need to specify that raising a focused window is a separate matter from focusing the window on hover. People who exclusively use Windows may be unaware of this. There are situations where you really don't want to raise that newly-focused VSCode window over the top of the application you're debugging, or whatever. Avoiding a flurry of window Z/layer management by clicking on stuff is one of the things we would like to avoid.

There are situations where you really don't want to raise that newly-focused VSCode window over the top of the application you're debugging, or whatever. Avoiding a flurry of window Z/layer management by clicking on stuff is one of the things we would like to avoid.

I wasn't even aware that VSCode has any floating windows/dialogs that could cause this issue, unless you're talking about the VSCode window itself at the OS level? I understand this feature request as referring to individual panes inside the VSCode window (anything else would be the OS/desktop environment's job).

There are situations where you really don't want to raise that newly-focused VSCode window over the top of the application you're debugging, or whatever. Avoiding a flurry of window Z/layer management by clicking on stuff is one of the things we would like to avoid.

I wasn't even aware that VSCode has any floating windows/dialogs that could cause this issue, unless you're talking about the VSCode window itself at the OS level? I understand this feature request as referring to individual panes inside the VSCode window (anything else would be the OS/desktop environment's job).

When you hover over a window at an OS level, and your desktop focuses-on-hover, the window is not raised, only focused, This means that you can enter text into it without raising the window. Without focus-on-hover for vscode, a user can't use this benefit for the terminal unless they had already clicked into the terminal before focusing a different window.

There are situations where you really don't want to raise that newly-focused VSCode window over the top of the application you're debugging, or whatever. Avoiding a flurry of window Z/layer management by clicking on stuff is one of the things we would like to avoid.

That's why they are options, you don't want it, don't turn it on. I have ny workflow, you have yours, other people have theirs, whatever works for you. Options, people want options, I used to have virtual desktops in a 3x3 arrangement and would roll off the right, left, top, down and be on the adjacent desktop simply by pushing through the edge and wrapping. It worked for me, did everyone else like it, not really, but I was never more than 1 desktop away from any of the 9 I had set up.

I wasn't even aware that VSCode has any floating windows/dialogs that could cause this issue, unless you're talking about the VSCode window itself at the OS level? I understand this feature request as referring to individual panes inside the VSCode window (anything else would be the OS/desktop environment's job).

I did not know this either, will have to try it out, live and learn.

When you hover over a window at an OS level, and your desktop focuses-on-hover, the window is not raised, only focused, This means that you can enter text into it without raising the window. Without focus-on-hover for vscode, a user can't use this benefit for the terminal unless they had already clicked into the terminal before focusing a different window.

Focus-on-hover, focus-follows-mouse, raise-on-focus, raise-on-hover, then delay times for all to happen.  If you don't like the options I have, I'm not going to force you to use them, my time delays and mouse-acceleration are probably not to your liking either, but you have a different workflow, everyone has their own workflow and the tool shouldn't slow me down.
Wanna know another thing the tool shouldn't do? Shoot me in the foot on a regular basis. I use "vi mode" in edit panes, when I'm outside VSCode, everything works the way I like it.  I move the mouse over a window and it gets focus. I can't count the number of times I've moved my mouse from elsewhere on my desktop and last time I was in VSCode an edit panel was active with focus and I move back into VSCode, sliding the mouse over a terminal and start typing only to start wondering where my characters are going because latency isn't THAT bad, to noticing that one of my edit panels is active and has focus. Then trying to figure out what keys I hit or what mode the editor was in when I started typing... this happens on a regular basis. To compound that, there are two undo/redo buffers in the editor, one for "vi mode" and the other for undo/redo the OS provides, yeah that sucks too because they don't sync stacks.
I really wish they would fix this issue, maybe before I retire?

@unixwzrd Why does your reply (specifically your reply to me) read so defensive? I wasn't even responding to you, I was explaining to someone else why one might want the option.
Definitely on the same page with you though, I can't believe this isn't an option yet.

 Just a bit frustrated with the fact that this "problem" has been here for more than 4 years. It really is about individual workflow though isn't it?
Be well...

I use "focus follows mouse" on both Windows and Linux.  It is nice because I don't have to click, just move the mouse and start typing.  It is very nice and easy-to-use.
Sadly, VS Code does not have a setting to support it.  Ideally, it should focus whatever editor pane (from vertical or horizontal splits) or embedded terminal the mouse is over.
The workaround is to just create multiple VS Code windows for each file I am editing and use a separate terminal.  It feels clunky and undermines the whole point of having VS Code support multiple editor panes and an embedded terminal.

Would really like to see whatever pane being under the mouse pointer getting the focus. Got used to it a lot in Blender.

May I ask how to set it up like this in blender?

I use "focus follows mouse" on both Windows and Linux. It is nice because I don't have to click, just move the mouse and start typing. It is very nice and easy-to-use.
Sadly, VS Code does not have a setting to support it. Ideally, it should focus whatever editor pane (from vertical or horizontal splits) or embedded terminal the mouse is over.
The workaround is to just create multiple VS Code windows for each file I am editing and use a separate terminal. It feels clunky and undermines the whole point of having VS Code support multiple editor panes and an embedded terminal.

These are all fantastic points. Rhetorical question how does "mouse hover" work, and how is it so many extensions use it even if the window doesn't "officially" have focus?
I use it on macOS and have used focus-follows-mouse and raise-on-focus for many years, in Unix using X, Linux and X, Windows using some registry hack I believe, and macOS. This is embedded deeply in my cerebellum and is reflex from over 35 years of doing this. Not having this has caused me to hose things up quite a few times. This is the only application I have to move to the pane and click the mouse/trackpad/pointing device, and the application I spend the most time in it. It could really be a great app if some of the rough edges could be worked out, but it's the best that's available, so it's not like I'll find something else which can do as many things as VS Code does for me.
I know the panes are getting mouse over messages because I have seen them in BetterTouch Tool. Not only that there are so many extensions that use "mouse hover".  I cannot fathom having the number of mouse-hover extensions and that giving the pane the mouse is in focus absolutely boggles my mind. This cannot be that difficult to implement, and if I didn't have other things to do, I'd do it myself, but that would mean learning the code base, JS and other things I have no time for.
Now that there is integrated AI like Codeium, Copilot and others, I cycle from edit pane, to AI chat, to terminal, to AI chat, to edit pane.  Then there's selecting a file or something in the side bar, especially opening a new file.  I select the file and it opens in the last active edit pane. Great, now I've clicked in the file explorer and then rather than being able to move directly and edit the file, I have to move to the pane where the file is open again and click there. Add the AI pane which I have attached to the right side of my VS Code window and I am clicking all over the place.
I tried using iTerm2 as a workaround for the integrated terminal problems I have at times, but I cannot get iTerm2 fully integrated, even though I've read plenty of places that it's simple to do.  For some  reason it refuses to work.  Having iTerm2 would be great as that would allow me to never have to enter the integrated terminal and then my edit sessions would get focus when I move back into VS Code from iTerm2 and vice-versa.  Problem is that iTerm2 does not work with the debugger.
The macOS ChatGPT app is in similar situation as how I use iTerm2, it sits off to the right side and if I want to use it, I move past Copilot or Codeium and it auto-raises and gets focus, which is outstanding, but I have to copy and paste to it, but at least no clicking.  Move back to VS Code and it auto raises, but then I have to make sure I'm in the active pane or click in the pane to make it active, and no integration means copy and paste.
Apart from YouTube, having to go through my email, and playing with Stable Diffusion, this is the biggest source of frustration and waste of my time having to deal with this, it has cause me to make inadvertent edits to code which I have to figure out what I did and undo it once I notice my keystrokes are not going where I intended.
If someone too a bit of time and actually implemented this, I have no doubt we would create a national holiday for you. Besides, it's my birthday this month, and I would love to get a really nice birthday present of focus follows mouse, so for FFS, FFM, someone please.
Sorry for the length, but this is my semi-annual post to this issue. My first was about two years ago, sorry for the length, but I feel better and I think I express a lot of the same frustration others feel with this.
Be well...

++1

It really sucks, we had focus-follows-mouse back in 1993.  32 years ago.

It really sucks, we had focus-follows-mouse back in 1993. 32 years ago. And Microsoft...?

X11 had it with various window managers WAY before then.
I looked into whether this could be done as an extension, and unfortunately no because extensions cannot be done as extensions are sandboxed and would need access to all system events.
Asking o1 about it and ddi a bit of researching myself, got this response,

There’s no supported way for an extension to intercept mouse enter or leave events for existing VS Code panels directly. The extension API isn’t designed to expose low-level UI event hooks for the editor’s own interface elements, including the built-in sidebar, panel, and activity bar.
Extensions can handle mouse events within their own contributed content—most notably via a webview—but not in the surrounding UI. Without a webview, the underlying Electron-based shell isn’t accessible to your code in any official or reliable manner.
If this functionality is important, consider filing a feature request with the VS Code team or exploring ways to achieve the desired effect through custom panels (webviews) rather than existing ones. The built-in panels simply don’t provide programmatic mouse event subscriptions through the current extension API.

I put it in as a suggestion to the Codeium team for Windsurf, haven't done so with Cursor yet, but will soon.
If you want to upvote this as a feature for Windsurf, here's the link:
https://codeium.canny.io/feature-requests/p/windsurf-focus-follows-mouse-as-a-configuration-option
I'll file another lmk if I can find suggestions for Cursor.


[CH]Update Readme for clickhouse backend

What changes were proposed in this pull request?
update readme for clickhouse backend. Add some usage instructions,
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Please rebase .

had rebased

LGTM


Bridgefy events not working when app is in background

When the app is in the foreground everything seems to work fine, but when the app is in the background it is not receiving events anymore. Also if you open the app after you have already sent some events while in the background it stops receiving events as well (I've added logs and Bridgefy is initialized and started but no event was received).
import { Bridgefy, BridgefyEvents, BridgefyPropagationProfile } from "bridgefy-react-native";
import * as Notifications from "expo-notifications";
export { ErrorBoundary } from "expo-router";

export const BRIDGEFY = new Bridgefy();

// Prevent the splash screen from auto-hiding before asset loading is complete.
SplashScreen.preventAutoHideAsync();

export default function RootLayout() {
	const { loaded, error } = useLoadFonts();
	const appState = useRef(AppState.currentState);

	// Expo Router uses Error Boundaries to catch errors in the navigation tree.
	useEffect(() => {
		if (error) throw error;
	}, [error]);

	useEffect(() => {
		if (loaded) {
			SplashScreen.hideAsync();
		}
	}, [loaded]);

	useEffect(() => {
		const subscription = AppState.addEventListener("change", (nextAppState) => {
			console.log("nextAppState", nextAppState);
			if (appState.current.match(/inactive|background/) && nextAppState === "active") {
				console.log("App has come to the foreground!");
				BRIDGEFY.isInitialized().then((isInitialized) => {
					console.log("isInitialized", isInitialized);
				});

				BRIDGEFY.isStarted().then((isStarted) => {
					console.log("isStarted", isStarted);
				});
			}
			appState.current = nextAppState;
			console.log("AppState", appState.current);
		});

		return () => {
			subscription.remove();
		};
	}, []);

	useEffect(() => {
		(async () => {
			try {
				const isInitialized = await BRIDGEFY.isInitialized();

				console.log("isInitialized", isInitialized);
				if (isInitialized) {
					return;
				}
				await BRIDGEFY.initialize({
					apiKey: "MY_KEY",
					verboseLogging: true,
				});
				await BRIDGEFY.start({
					userId: "user1",
					propagationProfile: BridgefyPropagationProfile.longReach,
				});
				const userId = await BRIDGEFY.currentUserId();
				console.log("userId", userId);
			} catch (error) {
				console.error("SHYQA", error);
			}
		})();
	}, []);

	useEffect(() => {
		const subscriptions: EmitterSubscription[] = [];
		const eventEmitter = new NativeEventEmitter(NativeModules.BridgefyReactNative);

		// When this device received data from another Bridgefy device.
		subscriptions.push(
			eventEmitter.addListener(BridgefyEvents.bridgefyDidReceiveData, async (event) => {
				console.log(`Bridgefy received data`, event);
				// alert(`Bridgefy received data: ${event.data}`);
				const data = JSON.parse(event.data);
				await Notifications.scheduleNotificationAsync({
					content: {
						title: data.title,
						body: data.description,
					},
					trigger: null,
				});
			})
		);
		return () => {
			for (const sub of subscriptions) {
				sub.remove();
			}
		};
	}, []);

	if (!loaded) {
		return null;
	}

	return <RootLayoutNav />;
}

+1


Add Toil script for adam convert

Work towards #104

@heuermh — What is the status of this?

Can close, #104 took care of this already


Integrate ServiceNow bot with Modernisation Platform repositories

User Story
As a Change and Release lead
I want to integrate ServiceNow with Modernisation Platform GitHub repositories
So that ServiceNow can track changes happening in GitHub
Value / Purpose
As part of a wider initiative to give ServiceNow visibility into GitHub changes we've been asked to give the operations-engineering-servicenow GitHub account admin permissions for our repositories. This user account is tied to a bot.
Hopefully this is pretty simple - something like this in our github directory:
resource "github_repository_collaborator" "servicenow" {
  for_each   = toset(local.list-of-repositories)
  repository = each.key
  username   = "operations-engineering-servicenow"
  permission = "admin"
}

Useful Contacts
No response
Additional Information
The following Slack conversations are useful starting points:

https://mojdt.slack.com/archives/C01A7QK5VM1/p1726475633280699
https://mojdt.slack.com/archives/C01A7QK5VM1/p1726582136645589

Definition of Done

[ ] New account added as administrator to MP repositories
[ ] Customer confirms ServiceNow integration

On discussion with @connormaglynn we'd like to understand the requirement for admin access prior to implementing this.

Closing this issue as admin is too high access request for our repo David Elliot to reply with requester


feat: add bench

feat: add polymath's bench
chore: fmt

Thanks for adding the bench, @SuccinctPaul ! 🚀
It takes forever to run, this got me thinking we need to improve performance of the generator.


[Discuss] Should we limit the field types for Constant and Property to be more user friendly?

Currently, we display the full list of all available field types. Many of these are technical in nature -- "UNSIGNED.. TZ .. etc"
BOOLEAN
BYTE
BYTE_ARRAY
CHAR
COMPLEX
DECIMAL
DOUBLE
FLOAT
INTEGER
LONG
SHORT
STRING
TIME
DATE
DATE_TIME
DATE_TZ
TIME_TZ
DATE_TIME_TZ
UNSIGNED_BYTE
UNSIGNED_INTEGER
UNSIGNED_LONG
UNSIGNED_SHORT

Discussed.. this is probably a UI issue where it could be separated w/ common types and then Advanced field types

Closing.. use this ticket instead: https://github.com/atlasmap/atlasmap-ui/issues/25


[Doc] Fix links to Google docs page in the documentation guide

Search before asking

[X] I searched in the issues and found nothing similar.

What issue do you find in Pulsar docs?
There are still several links to Google Docs at https://pulsar.apache.org/contribute/documentation/overview
What is your suggestion?
Replace with links to the corresponding doc site files.
Any reference?
Subtask of #18272.
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

Well. I notice that these three files are still not ported to a markdown file:

Pulsar Documentation Writing Style Guide
Pulsar Design Style Guide
Pulsar API Documentation Guide

cc @Anonymitaet do you have a plan to migrate them? For example:

Pulsar API Documentation Guide can be merged with Documentation Contribution Guide as the latter contains a section talking about the api/reference page.
Pulsar Design Style Guide may be merged into the syntax guide or be ported as a lightweight new page.
Pulsar Documentation Writing Style Guide seems a heavyweight page to migrate.

Pulsar API Documentation Guide can be ignored temporarily since it does not have much content. I'll add more content if I have more in the future.

Pulsar Design Style Guide should be a separate guide on an independent page, it has nothing to do with the syntax guide.

Yes, it's a large one and updated continuously.

This can be referred to https://github.com/apache/pulsar/issues/13288. I'm trying to pick up this issue in this month.

https://github.com/apache/pulsar/issues/18272#issuecomment-2053889607


Icon not applied when --out argument is specified.

Using following command icon is applied correctly.
'electron-packager ./static app --platform=all --arch=all --version=0.34.2 --icon=assets/favicon.ico'
When Adding --out=dist the executabls are copied to "dist" folder. But it ignores --icon argument.
'electron-packager ./static app --platform=all --arch=all --version=0.34.2 --out=dist --icon=assets/favicon.ico'
I'm using electron-packager 5.1.1 .

Does this also happen when you set --platform=win32?
Per the contribution instructions,

What platform are you running electron-packager on?

Its running on windows 10.  After running it once with --platform=win32 it worked. And it's even working when I switch back to all. So probably I did something wrong. I can't reproduce it anymore. Sorry for that.

I'm closing this as "can't reproduce", then.


Enable delta updates for the auto updater

I believe this is due to the blockmaps not getting uploaded correctly to the bucket. Will investigate.

Seeing on macOS too
Cannot download differentially, fallback to full download: Error: Response ends without calling any handlers
    at Timeout._onTimeout (/Applications/Zoo Modeling App.app/Contents/Resources/app.asar/node_modules/electron-updater/out/differentialDownloader/multipleRangeDownloader.js:89:24)
    at listOnTimeout (node:internal/timers:581:17)
    at process.processTimers (node:internal/timers:519:7)

Technically the PR merged above makes sure we don't attempt delta updates since they aren't working. But this isn't something we really want to prioritize now so closing is good.


Make BPF symbolization tests end-to-end tests

The BPF symbolization tests were added as unit tests, because they require a bunch of setup shenanigans that we only had internally to the crate. Conceptually, however, they are very much end-to-end tests that test the public API surface and not just some implementation detail. We really want to preserve the ability to get a good overview of all end-to-end tests in a single location and so with this change we take necessary steps to expose necessary test helpers so that they can be used from end-to-end tests. Furthermore, we move said BPF symbolization tests into tests/blazesym.rs, co-located with most other end-to-end tests.

Ugh yeah, that won't work... :-(


Option to create "named" static files

Newer* versions of gatsby-source-filesystem's createRemoteFileNode() accepts an optional name parameter. This PR passes the names of file uploads from strapi to createRemoteFileNode, so that files can have SEO optimized names (like pretty-file-name.png) instead of ugly hashes (like 149853f04f9befa5fd15b60561bea32fa7b7f490.png).
By default, the useNamedImages option defaults to false, so that this won't change image names on existing deploys.
This PR add to ability to write graphql queries on strapiUploadFile nodes themselves, ie:
strapiUploadFile {
  self {
    childImageSharp {
      fluid(maxWidth: 300) {
        src
      }
    }
  }
}

*See: https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-source-filesystem/CHANGELOG.md#2017-2019-01-23

is this still not working?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello, unfortunately this PR is now quite outdated after all the changes to this source plugin. The diff has become unreadable, so I'll have to close it.
I'm sorry this PR was not looked at before. Please open a new one based on the current state of the plugin if you still want this change


CI: Stop testing legacy layout

It's been long enough, and a good time to change the outputs is when we've disabled checking that they don't change.

ds005 is down to 20 minutes with a two-BOLD run and a one-BOLD re-run + SyN-SDC.
I promise I'll give y'all more chance to review in the future, but I don't want to keep wasting CI time with pointless work, especially when tests are passing and can start meaning something again.


Add timeout behaviors to the socket module

When a remote server becomes unavailable or non-responsive without
properly terminating connections, any requests in-flight will
wait indefinitely.
A optional connection parameter req_timeout has been added. The
default value is infinity, which preserves the existing behavior.
If a non-infinite value is specified, it is used internally as a
gen_server timeout value within epgsql_sock. If there are outstanding
requests (determined by looking at the queue state) the timeout is
applied.
This also adds overall timeout to the initialization process.
if the initialization messages - ending with ReadyForQuery - arrive at
intervals greater than the timeout, the epgsql_sock will timeout.
Notes:
One request in queue can represent multiple pipelined requests to the PG
server. In this case a single timeout is applied - and it gets
restarted as the reply to each individual message sent is received. This is
intentional, because any network activity from the postgres server
indicates we have a valid connection to it.
Limitations:
This change only ensures support for the default epgsql interface.
Additional behavior consideration is required to support the async
interface.
The timeout is not exact - intervening inbound messages (whether to
perform new actions, or received from the PG server) will restart the timer.
A further refinement will be to only reset the timeout when receiving
messages from the server, and to  reduce remaining time available if
the message is received from another caller. That is not addressed in
this changeset.
Signed-off-by: Marc Paradise<EMAIL_ADDRESS>

/cc @chef/erlangers

@mp If I remember correctly, the inet_reply only got sent to use when we use erlang:port_command here --and the ssl situation was unclear. Has this been resolved?

@sr I did find that the other insertions of timeout handled it well when SSL was enabled too, but I'm reluctant to remove this one because it gives us guaranteed knowledge that we should be receiving a response of some kind (with rare exceptioin - pg cancel call will not respond, but we also don't use that...)


Fixes #2210 - Creating a transaction in zio-jdbc-postgres drops the error type

Fixes #2210
Problem
If I have a ZIO[R, E, A] and I create a transaction around it, I should get back a ZIO[R, E, A].
I get back a ZIO[R, Throwable, A], which is less-precise than what I put into it. There is just a small mistake in the type definition of the function.
def transaction[A](f: ZIO[Has[Connection], Throwable, A]): ZIO[Has[Connection], Throwable, A]
Instead of hard-coding Throwable here, we should add a type E to the list of generics.
Solution
Add a type E <: Throwable to the def transaction definition. E need not necessarily be a Throwable in ZIO, but it appears that the rest of the code around this function is expecting the Error channel to hold a Throwable.
Notes
Additional notes.
Checklist

[x] Unit test all changes
[x] Update README.md if applicable
[x] Add [WIP] to the pull request title if it's work in progress
[x] Squash commits that aren't meaningful changes
[x] Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

I ran the following command to test:
sudo docker-compose run --rm sbt sbt "project quill-jdbc-zio" test

And it worked:
[info] Run completed in 1 minute, 1 second.
[info] Total number of tests run: 129
[info] Suites: completed 26, aborted 0
[info] Tests: succeeded 129, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 66 s (01:06), completed Jul 23, 2021 1:33:18 AM

I'm a beginner in Zio and even Scala as a whole so I can't figure this out myself, what are the reasons for limiting it to Throwable here? It's a pretty annoying limitation, but I suppose there must be a reason why we need a Throwable.

@sloanesturz Can you rebase your PR, please?

@guizmaii I don't work with Scala/ZIO anymore, so it would take me a couple hours to get set back up with IntelliJ. If you want to take over this PR, I would be happy!
With 14 month old code, though, it might just be easier to cut a new PR.

Closing as this PR targets ZIO1 version


Please invite me to the Recode-Hive GitHub Community Organization

Name
Gadiraju Rishitha
Discord Username (if applicable)
No response
Additional Context
To gain knowledge on open source and to enhance our skills

Invitation sent to join the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see. You can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/Recode-Hive/people


KAFKA-4361: Streams does not respect user configs for "default" params

Enable user provided consumer and producer configs to override the streams default configs.
Author: Damian Guy<EMAIL_ADDRESS>Reviewers: Eno Thereska, Matthias J. Sax, Guozhang Wang
Closes #2084 from dguy/kafka-4361

@guozhangwang @sriramsub - i cherry picked this from AK trunk. Please let me know if i'm good to merge (or merge if you are happy)

+1