fromString unexpected results

Was doing some edge testing today and found some odd behaviors with using fromValue on certain strings. Thought I would make note of it here.

Providing strings in excess of 64 bit range seems to cause a silent overflow:
Passing in '-9223372036854775809' yields '9223372036854775807' result.
Passing in '9223372036854775809' yields '-9223372036854775807' result.
I would expect if there was an overflow that an error would be thrown instead of returning bad data.
For signed numbers I can probably catch this by checking for the unexpected sign flip, but not sure about unsigned numbers.

Trailing spaces with larger numbers seem to create odd results:
Passing in "9223372036854775807 " yields '-7273' (not sure what happened there)
Passing in "9007199254740991 " yields '90071992547409910' (seems like space became a zero)
However passing "123 " correctly yields '123'.
I seem to be able to work around this one by making sure my strings are trimmed before I pass them.

Yes, all methods expect sanitized inputs. If it'd check each time, that'd just be redundant operations where inputs are already known to be sanitized.

That's understandable.
Actually, having had more time to think on it. I should be able to cover these in my code with a few simple lines similar to below. (Assuming that the string coming out should match what went in it, if it converted correctly.)
function fromStringUnsanitized(str, unsigned, radix)
{
	if (typeof str !== 'string') throw new Error("Data is not a string");
	str = str.trim();
	var data = Long.fromString(str, unsigned, radix);
	if (data.toString(radix) !== str) throw new Error("Data: '"+ str + "' did not convert correctly");
	return data;
}

Thank you for the clarification.

@dcodeIO For longs that would cause overflows, what would be the best way to sanitize the input?
@CyDragon80 's solution to convert the long back to a string and compare that against the input seems too expensive.

Well, the information you put in is essentially just a string literal with no surrounding knowledge, so in order to examine if the result is expected you can either compare it to the input or modify the conversion algorithm. The latter is usually achieved by using an intermediate value that can represent additional bits of information, which might or might not be trivial to implement.

As I'm currently building a purescript binding for long.js, I wanted a safer Long.fromString which handles invalid characters and overflows. I handled overflows using simple String comparison once it reaches some maximum length. I coded this part in JS hoping parts of it might be put into this project.
See safeReadLong here.
Sample tests here.
@dcodeIO might it be useful to modify the existing readLong to do the same checking? Alternatively, I can instead introduce a safeReadLong variant similar to what I've done in my project. If so, I can submit a pull req for this.


Android: language switcher does not increase in font size

The font size for the language switcher options do not increase on Android Chrome. Issue also on the HMRC design system example https://design.tax.service.gov.uk/hmrc-design-patterns/welsh-language-toggle/
This may also be the case for sign out link https://design.tax.service.gov.uk/hmrc-design-patterns/sign-out/
See on service https://github.com/hmrc/accessibility-audits/issues/97

Actually, also noticing that design system components not increasing with font size on Android Chrome, e.g. https://design-system.service.gov.uk/components/text-input/default/index.html

To test with android and update platui to issue update.

Tested and resolved with latest Android version (14) on pixel phone


Is this dead? Who is using it in production?

Is the .Net version of Proto.Actor dead? The reason I ask:

Gitter chat goes unresponded.
An issue opened here almost a month ago goes unresponded.
No commits in months.
Large swaths of documentation pages are skeletons.
0 Releases

Orleans community seems vibrant in comparison, but it's also very "heavy" compared to Proto.Net.
Akka is out of the question for us,a s the system screams for virtual actors. I've have a Love-Hate relationship with Service Fabric: I love to hate it. ;-)
I plan on evaluating both Proto.Net and Orleans, but if this is dead and none of the original contributors are planning on coming back to it, I'll probably bail...

Hello @SixFootRhino, I'm not the core maintainer/creator of protoactor-dotnet but I use it in production.
I share your concerns, ProtoActor is a pretty interesting alternative compared to Orleans and Akka but it lack a strong community.
I can share  you some of our work done on top off ProtoActor (reminders with rabbitmq for example) that I didn't open source for now.
We did also some service fabric, and we are now trying to get rid of it.
The https://github.com/vlingo-net project is rising, but it's still in very early stages, and probably the community is as little as proto actor.

The protoactor-go project has some recent activity, so that's good to see. I am concerned seeing this project stagnate, I have a couple projects using it and really enjoy using it. It's been rock solid for us a little less than a year.

Is the .Net version of Proto.Actor dead? The reason I ask:

Gitter chat goes unresponded.
An issue opened here almost a month ago goes unresponded.
No commits in months.
Large swaths of documentation pages are skeletons.
0 Releases

Orleans community seems vibrant in comparison, but it's also very "heavy" compared to Proto.Net.
Akka is out of the question for us,a s the system screams for virtual actors. I've have a Love-Hate relationship with Service Fabric: I love to hate it. ;-)
I plan on evaluating both Proto.Net and Orleans, but if this is dead and none of the original contributors are planning on coming back to it, I'll probably bail...

I feel you, I am starting to work on a new project from scratch and thought going for Protoactor but sadly the lack of activity kinda scares me.
Any reason why you folks decided not to go for alternative (eg. Orleans, Akka)?

Hello @SixFootRhino, I'm not the core maintainer/creator of protoactor-dotnet but I use it in production.
I share your concerns, ProtoActor is a pretty interesting alternative compared to Orleans and Akka but it lack a strong community.
I can share you some of our work done on top off ProtoActor (reminders with rabbitmq for example) that I didn't open source for now.
We did also some service fabric, and we are now trying to get rid of it.
The https://github.com/vlingo-net project is rising, but it's still in very early stages, and probably the community is as little as proto actor.

That would be awesome if folks like you could share a bit of their work with protoactor to fill the gap with the documentation or lack of thereof.

I feel you, I am starting to work on a new project from scratch and thought going for Protoactor but sadly the lack of activity kinda scares me.

Glad to see I'm not the only one. ;-)

Any reason why you folks decided not to go for alternative (eg. Orleans, Akka)?

We are actually going to prototype Oreans. It really came down to that or Proto.Actor.
We're not considering Akka because virtual actors are a perfect fit for most of the services in this project. ClusterSharding in Akka is close but not really the same thing. Orleans or the Virtual Actors in Proto.Actor are simply a much better fit.
However, in theory Proto.Actor would have been a great fit as well, and in the past it has had significant performance advantage over Orleans. However, recent additions to Orleans 2.0 and 2.1 has saw some substantial performance improvements due to the work of the community. The fact that there even is a solid community behind it making these types of improvements certainly adds to it's appeal....
Furthermore, Orleans has had Journaled virtual actors for quite some time now, as well as a modern agent-based Distributed Transaction support that was recently added. These features will greatly reduce the difficulty in meeting the requirements in our project. Not all of our grains will fit the journaled model, but those which do will be able to provide a much simpler consistency implementation at scale.
While on the subject, does anybody know of an established virtual actor framework for .Net / C# that I'm overlooking?

The https://github.com/vlingo-net project is rising, but it's still in very early stages, and probably the community is as little as proto actor.

vlingo looks interesting, but as pointed out is way too early. Plus, it seems to suffer a bit from NIHS: Not Invented Here Syndrome. Look at all of the sub-projects. There are established projects out there for most of these. For example, why would you build a HTTP/S server for vlingo when Kestrel is a thing?

I wouldn’t say this is dead but it’s lacking vision as the primary devs (and myself) have interests elsewhere now I guess.
Are there features or bugs?  Make issues or PRs.  I’m sure if other people are active enough, they can have control over the repo.

Hi guys, thank you for the post!
I jumped onto ProtoActor when I was doing my previous project, and I mainly
contributed to the Cluster part of the project, as well as bridging dotnet
version with go version all together. Unfortunately my current project is
not using ProtoActor, thus I’m currently more focus on maintaining the
project, fixing bugs and answering issues. I guess Roger is same as well? I
hope I can jump back onto this project again after my current project. = )
Same as you, I was choosing between Orleans and ProtoActor since that’s the
only two libraries available at that time. And for protoactor-go, I think
till today it is still the most mature Actor library for Golang.
I ended up choosing ProtoActor because:
For Orleans: it’s solid but very heavy. We need to re-establish our entire
project structure based on it. It also got its own messaging system,
serialization, cluster structure, etc., which is a Good/Bad thing from
different point of view.
For ProtoActor:  it’s lightweight and flexible. It can be used alongside
with any existing libraries, without changing much of existing code
structure, and it uses Consul and GRPC which is very mature and performant.
And for us we need something quick to integrate, and fast(or even hacky) to
build, so we in the end choosing ProtoActor.
In the end I think it’s more of a design choise. The diffence between the 2
projects are written in Roger’s blog:
https://rogerjohansson.blog/2017/05/19/do-not-do-in-code-what-can-be-done-in-infrastructure/
On Wed, Apr 24, 2019 at 12:43 PM SixFootRhino<EMAIL_ADDRESS>wrote:

I feel you, I am starting to work on a new project from scratch and
thought going for Protoactor but sadly the lack of activity kinda scares me.
Glad to see I'm not the only one. ;-)
Any reason why you folks decided not to go for alternative (eg. Orleans,
Akka)?
We are actually going to prototype Oreans. It really came down to that or
Proto.Actor.
We're not considering Akka because virtual actors are a perfect fit for
most of the services in this project. ClusterSharding in Akka is close but
not really the same thing. Orleans or the Virtual Actors in Proto.Actor are
simply a much better fit.
However, in theory Proto.Actor would have been a great fit as well, and in
the past it has had significant performance advantage over Orleans.
However, recent additions to Orleans 2.0 and 2.1 has saw some substantial
performance improvements due to the work of the community. The fact that
there even is a solid community behind it making these types of
improvements certainly adds to it's appeal....
Furthermore, Orleans has had Journaled virtual actors for quite some time
now, as well as a modern agent-based Distributed Transaction support that
was recently added. These features will greatly reduce the difficulty in
meeting the requirements in our project. Not all of our grains will fit the
journaled model, but those which do will be able to provide a much simpler
consistency implementation at scale.
While on the subject, does anybody know of an established virtual actor
framework for .Net / C# that I'm overlooking?
The https://github.com/vlingo-net project is rising, but it's still in
very early stages, and probably the community is as little as proto actor.
vlingo looks interesting, but as pointed out is way too early. Plus, it
seems to suffer a bit from NIHS: Not Invented Here Syndrome. Look at all of
the sub-projects. There are established projects out there for most of
these. For example, why would you build a HTTP/S server for vlingo when
Kestrel is a thing?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/AsynkronIT/protoactor-dotnet/issues/461#issuecomment-486325182,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA4VWZ5YSPWCLIERAYKO3STPSCE2VANCNFSM4HHGTBRA
.

We use Proto.Actor in production and we process about 5 billions of messages per month., per "service", which we have two. The documentation is definitely lacking and I still have plans to improve it but I have a couple of tough deadlines now, so will not start until the end of May. At the same time, Proto.Actor just works. I have tried Orleans and it was just no-go. I don't want to say anything bad abut Orleans but they must be working really hard to clean up all that mess that they have created previously. Luckily, Proto.Actor doesn't have such a legacy. I would say that things that bother me the most are:

no releases after some nasty bugs were fixed
docos
issues with Consul cluster provider
We keep our local copy of the code and although I am now a member of the org here, I am not feeling very comfortable doing things without having a discussion with core contributors, but they apparently have even less time than me. But definitely, we need to do at least a new release.

As for the features, it would be nice to do a proper version of streams. Orleans streams have nice ideas and somewhat convoluted implementation and Akka streams a quite weird. I have some ideas but it's quite a lot of work.
And, of course, if you guys think that the project is useful and you want to use it in prod - it is a library and you can read its code in a couple of hours (unlike Akka or Orleans), open issues if you get any, fix issues. The only way OSS projects live is that people contribute and don't scream "is it dead??". Sorry if it's a bit harsh, but I've heard this so much in RestSharp...

@alexeyzimarev Agree, I actually never realized that OSS projects took so much efforts until I became part of the ProtoActor's team, haha.
Similar to you, I certainly love to push a new release, but not feeling very comfortable to do so since I believe @rogeralsing should be the guy to make the final push? However from certain point @rogeralsing just disappeared.

Thanks for both of your replies.
The #1 concern I have with Orleans is it's heft and inflexibility of the model. While they have done a good job in embracing the provider pattern, there is a still a lot of rigidity to do things their way. I do concur that Proto.Actor does seem far more flexible in this regard, and definitely more lightweight.
The #1 concern I have with Proto.Actor is exactly what you said:
"no releases after some nasty bugs were fixed"
Maybe I'm missing something, but there's been no releases, right?
That scares me. If not Roger, somebody needs to take the reins so that critical fixes to nasty bugs are submitted and make it into at least one stable release that people can grab. If they aren't, people will be scared away, and there will be no adoption and community growth.
Are all of these "nasty bug" fixes in as closed pull requests? Or do people still have them in their own copy of the library only?

@SixFootRhino To answer your last question, In our use case we just use latest version from MyGet instead of a released version from Nuget. I know it's hacky but it just works.
This has never been a problem in Go since it's always fetches the latest.

As I wrote, we build from source and we fix things so when we ensure our fixes work, we can bring it back here. The repo is not huge and you don't usually need all of it. MyGet works also like @PotterDai mentioned. I agree that we need to make a release of a minor with bug fixes, then merge #452 and #455 and make a major.

Some clarifications from my side:
Design concepts behind Proto.Actor
Proto.Actor was designed from day 1 to be narrow in scope.
Meaning that we did not want to have a never ending project like Akka .NET was.
Instead we aimed for solving the key issues about scaling, concurrency etc.
As such, much of the project was "done" long ago in terms of key features, where any new commits have mostly been about bug fixes, updating the API based on feedback/new lessons learned etc.
e.g. Stablising the Cluster support
On a personal level
For me personally, I do not have a lot of time for OSS work anymore, mostly work and family right now.
Philosophical level
I've also changed my stance somewhat on the topic of Actor frameworks.
I still love the concept. but in the current state of where cloud computing is moving.
There are often better options.
e.g. leveraging PaaS services of Azure or AWS takes you really really far.
For example, Lambda/Azure functions are extremely cheap and easy to build, and scale.
Azure event hubs gives built in support to raise events through your systems.
This leaves a more or less niched area for actors, e.g high performance processing. fin tech etc, iGaming etc.
But fault tolerant clusters or event driven systems can pretty much be done with out of the box offerings without the hassle of running custom software clusters.
Moving forward
We have been discussing things interanlly about moving Proto.Actor to some form of foundation. but this has been hard as we have C#, Go and Kotlin implementations.
There is no clear polyglot foundation where this might fit.
Any ideas there would be welcome.

I agree that we need to make a release of a minor with bug fixes, then merge #452 and #455 and make a major.

This would be fantastic @alexeyzimarev, but as has been noted I'll just get head and build local as it sounds like all of the critical fixes are in the codebase.
@rogeralsing thanks for the candid response. I also agree for a lot of systems, Azure and AWS have so many great pieces now that you should approach every system design with the idea that you will use them, and only move away when it's absolutely necessary.
Gaming (my field) is one area where this has been slow to adopt PaaS for certain titles, and will remain to be for the foreseeable future unless Streaming takes off.
I absolutely concur that for the time being anyway, there'll be a strong need for tech like Akka or Proto.Actor or Orleans, or even non-actor frameworks, for building massively scalable games. The fact is for the biggest games, they don't rely on just one cloud provider. Some games deploy to 50+ PoP's across a half-dozen providers, including the big 3. When you do that, you can't rely on any one PaaS. You have to, unfortunately, have built your own that has enough abstraction so that it doesn't care where it runs. As awesome as pieces like EventHub and GameLift are, they tie you to one provider. Fine for most systems and industries, and even fine for many games, but not fine for all games.

Any ideas there would be welcome.

Unfortunately I don't have any suggestions where Proto.Actor would end up wrt foundations; not my strong suit.
However, I have decided that I'm going to build the prototype slice for my next title in both Orleans and Proto.Actor so that I can get a better feel for both. Having just come off a large-ish Service Fabric project (with over 50 services), I'm definitely open to the idea of something lighter weight and more flexible.

@rogeralsing IT's PaaS services like Lambda that have lead me to ProtoActor
The use of protobuf and GRPC is perfect for an environment where you need to coordinate the work of many different Lambda functions.
Conceptually, I am using protoactor-dotnet where each Lambda is like a short lived actor that can communicate back to the central cluster.
We had been using Orleans for several years in a similar way but had to build an integration layer between the lambdas and Orleans. Keeping grain definitions up to date between the processes on the lambdas was a nightmare that is no longer due to the use of protobuf and grpc in protoactor.
The whole thing is much easier to program and reason about because my lambda clients are essentially just other actors programmed in the same way as the ones that reside in the server. In orleans you need to adopt a different mindset for the clients.
Anyway, we have been using it in production for about a month, but with thousands of lambda processes connecting and disconnecting as our (extremely variable) load changes. So far I am extremely happy and hope to make some bug fix and feature contributions back to the project shortly.
For the time being I just build from source into a local folder nuget repository. As far as I am concerned, the work I did to get my project up and running on ProtoActor has been far less than what I would have needed on Orleans and I feel much more comfortable making changes to the code bases since it is much easier to get my head around.

So what can we do to keep thing rolling?
We have a fairly well defined scope for the project, what to aim for design-wise.
Any participants here want commit rights?

I have commit rights and I plan to rewrite the Consul provider and possibly work on a Kubernetes provider. But I don't feel comfortable moving along without my code being reviewed. Also, we need some release strategy and a larger group needs to get access to both MyGet and NuGet feeds.

I have little time to spare like most people here, but I would be prepared to become a committer to review occasional pull requests.
Is it the normal workflow that committers should submit their own changes as pull requests for other committers to review?

Hi guys. I'm porting protoactor-dotnet to python. Maybe you could do code review and apply my commits to main branch of python version, or give me rights to python repository?

@Valentin-Miroshnichenko Wow!! Didn't notice that since I'm not within protoactor-python's channel! That's a huge amount of progress! Thank you very much for the contribution! =D

Maybe you could try to get some love and attention from https://dotnetfoundation.org/about

The Cloud Native Computing Foundation seems like a better place for this project because it is language/platform neutral: https://www.cncf.io/

@SixFootRhino To answer your last question, In our use case we just use latest version from MyGet instead of the released version from Nuget. I know it's hacky but it just works.
This has never been a problem in ProtoActor-Go since it's always fetches the latest.

@PotterDai Hi Potter. How can I fetch the latest version of protoactor-dotnet and protoactor-go from MyGet? What's the feed url?

Hi @kiwill , you can find the latest protoactor-dotnet from MyGet using following feed:
https://www.myget.org/F/protoactor/api/v3/index.json
For protoactor-go, I think it automatically update to the latest branch! = )

thanks! @PotterDai

@AsynkronIT/developers I perfectly understand that you guys are quite busy. At the same time, I'd like to get some clarity on how to move forward. I have two large PRs open now. One is to update a long list of obsolete packages and move to .NET Standard 2.0 solely. Another one is to fix old and nasty cluster recovery issues and Consol provider problems. My organisation active uses Proto.Actor and we have the will and the ability to develop it, but, despite being a maintainer here, I struggle to understand my role and the role of AsynkronIT.
Do you want to keep the ownership and the copyright of Proto.Actor or you plan to separate it to its own, community-driven GitHub org?
Do you plan to do code reviews still?
Can I just merge my PRs and other pending PRs?
Who will be releasing NuGet packages to nuget.org?
What to do with the website? It's really outdated and even the generator used there is not being maintained anymore.
I have even more questions, but I have no idea how to reach out and have a discussion.

@PotterDai send me your nuget name an I can add you to the nuget org.
Things that could use some love right now:

New site generator
New build pipeline + Nuget publishing pipeline

Also, anyone who needs commit rights, let me know.

I would like commit rights please.

@sudsy done!
I've removed the last traces of .NET 461.
Also merged the TestKit from @Vindil
The TestKit is similar to testkit in Akka, we should review the design of it to polish it of, and then look into where it makes sense to use the testkit for the other tests in the solution.

Been away from .NET for some time, whats the status on C# 8 and Netstandard 2?
Is it possible to use C# 8 and still be backwards compat?

Yeah, using C# 8 is possible since .NET Core SDK 2.1. It's the compiler who applies restrictions, so newer SDKs can build for older versions from the source code written with the latest lang version.

And down the rabbit hole with nullability now :)

Yeah, that's a bit mad. I'd very much like have a more powerful type system like Rust, instead of trying to save nullable types from misery.

@rogeralsing I saw you trying the nullability thing. I spent a bit of time resolving issues with the Proto.Actor project but some places weren't possible to fix. For example, the TrySetResult call where null is possible but TrySetResult doesn't have it nullable. Also, PID is a partial class, a part of it is generated and we have no control over it, but the compiler complains. When I got enough pragmas around those places, I asked myself if it's necessary...

New build pipeline + Nuget publishing pipeline

That's done now

So, new packages get to nuget.org now, no need to look at MyGet anymore.
https://www.nuget.org/packages/Proto.Actor/0.2.1-alpha.0.15
the first package since 0.2.0 🎉

Great Job @alexeyzimarev ! Thank you very much!

Anybody still using this in production?

@Swoorup not sure where you got this impression from, I believe the whole discussion in this issue shows the opposite.
I think there's no need to keep this issue open.

@alexeyzimarev I looked at the insights, there wasn't much activity for 2 years until few months ago. In case any I am glad to be proven wrong. ;)


Additional change for same defect PE00DY2V

Found wrong i2c addresses during code review.
Correct wrong i2c addresses for:

ADS7138_Imon_C1-C4 and ADS7138_Imon_C5-C8   0x2A --> 0x2E  (wrong in workbook)
Tola-0/IR35220-00-0 (0x7F-->0x28)
Tola-0/TDA38740-00-0 (0x1F-->0x20)
Tola-0/TDA38740-01-0  (0x1F-->0x20)

Can one of the admins verify this patch?

test this please

looks good to me.


Update Arbitrary Calls section to remove Session

Fix the Arbitrary Calls section on the README which references a Session that does not exist:

unknown field 'Session' in struct literal of type <....>

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Filename prefixes

Please consider making this extension work with filenames that have prefixes too. E.g, instead of just "openapi.yaml", also work with "anything.openapi.yaml".

Did try this in an earlier release, but will revisit it. Thanks for the suggestion.

Published as v0.3.1 - thanks again!


Improve Segmented Controls and Token Groups

Another issue related to the Wallet tab. We are very, very close to the end design I made while designing Samoa.
So based on Hu's recent work, we now have specified token groups.

All (Assets, Defi, Governance but no Collectibles)
Assets (ERC20)
Collectibles (ERC721 and ERC1155),
DeFi (all ctokens, atokens, ptokens, itokens, liquidity pools, etc...),
Governance (DAO tokens like COMP, UNI, etc)

So we have to:

Update Segmented Controls (so they are horizontally scrollable) - ScrollableSegmentedControl
Add Token groups

Zeplin:
https://zpl.io/bAgG6ox
Prototype
https://invis.io/6U125DXFWE2X

Examples of scrollablesegmentedcontrol
https://user-images.githubusercontent.com/51817359/146033231-15e38a17-c863-491b-98f8-b530b9993589.MOV
https://user-images.githubusercontent.com/51817359/146033184-487ae25c-5157-4e0b-b900-4a7d6396db63.MOV

@hboon We need to come up with a way to distinguish these tokens - I don't know of any way to tell from looking at the token, but maybe an API can say? Failing this we should maintain a common list of tokens that are governance or defi.

We need to come up with a way to distinguish these tokens - I don't know of any way to tell from looking at the token, but maybe an API can say? Failing this we should maintain a common list of tokens that are governance or defi.

@JamesSmartCell It's already in the token mapping schema, but the data hasn't been populated yet: https://github.com/AlphaWallet/tokens/blob/main/tokens.json, eg.
[
  {
    "contracts": [
      {"address": "0xc18360217d8f7ab5e7c516566761ea12ce7f9d72", "chainId": 1},
      {"address": "0xbD7A5Cf51d22930B8B3Df6d834F9BCEf90EE7c4f", "chainId": 137},
      {
        "address": "0xfeA31d704DEb0975dA8e77Bf13E04239e70d7c28",
        "chainId": 42161
      },
      {"address": "0x65559aA14915a70190438eF90104769e5E890A00", "chainId": 10}
    ],
    "group": "Governance"
  },
  {
    "contracts": [
        //…
    ],
    "group": "Governance"
  },
  //…

So how to group them should be done #3549

What is the plan to release this? It's live and working on Android.

@colourfreak It's merged recently. So will be in the next release.

Done earlier

The problem is - these groups are empty.

Compare this with Android

The code is working properly for iOS. It's actually a bug on Android's side, or at least not by design.
If you add this token 0x21bfbda47a0b4b5b1248c767ee49f7caa9b23697 on Ethereum mainnet, you'll see it appear under Governance like this:

The reason why it's not appearing on iOS is because the filtered down tokens.json (that Android should be using, but isn't. Instead it's usually the original, bigger file but with erroneous mapping) has a much smaller subset of the original. So we should fix it there. We had to filter it down earlier because the mapping isn't accurate (and we can't put wrong mappings in as that will affect the price, display, or in the worse case cause the users to lose funds). But I think what we can do is to add back the tokens that are on mainnet and not map those to other chains.
Once I have the updated tokens.json file, I'll create an issue for Android to update.
Leaving this issue open until I create an updated file and issue for Android

[ ] Create updated tokens.json
[ ] Create Android issue

Closing. Will see results in next build


Aurora Crashing on launch

What are you experiencing an issue with?

[x] Aurora
[ ] Aurora supported game, (Fill in the game)
[ ] Aurora Wrapper
[ ] Aurora Profile
[ ] Aurora supported device, (Fill in problematic devices)
[ ] Aurora Scripts
[ ] Aurora Updater
[ ] Aurora Lighting issue
[ ] Other, (Fill in another issue here)

What kind of an issue is it?

[x] Crash
[ ] Performance problems
[ ] Visual bug
[ ] Localization issue
[ ] Enhancement suggestion
[ ] Device issue
[ ] Other, (Fill in another type of issue here)

How often does this problem occur?

This problem occurs every time
Please describe the steps to reproduce this issue:
The issue can be reproduced by doing following steps:

Try running the executable file

What is the version of Aurora you are experiencing this issue with?

My version is 0.6.1-dev
Does the previous version of Aurora have this issue?
The previous version, 0.6.0b Beta ,did not have this issue.
Please include any logs, screenshots, or files that are related to this issue:

Screenshot -

Delete %appdata%/Aurora

Thx!


TCPMapping traffic not behaving as expected

I'm following the documentation provided here, but I'm still not able to get this to work correctly.
Ambassador version: v1.7.0
Kubernetes environment: EC2, deployed via Rancher Kubernetes Engine
Kubernetes version: 1.18.6
I've configured Ambassador as such
apiVersion: v1
kind: Service
metadata:
  name: ambassador
  namespace: ambassador
  annotations:
    service.beta.kubernetes.io/aws-load-balancer-ssl-cert: <ARN CERT ID>
    service.beta.kubernetes.io/aws-load-balancer-ssl-ports: "443"
    service.beta.kubernetes.io/aws-load-balancer-backend-protocol: "http"
spec:
  type: LoadBalancer
  ports:
  - name: http
    port: 80
    targetPort: 8080
  - name: tcp
    port: 5000
    protocol: TCP
    targetPort: 5000
  - name: https
    port: 443
    targetPort: 8080
  selector:
    service: ambassador

I've checked and the port is open in the provisioned AWS ELB.
---
apiVersion: getambassador.io/v2
kind: TCPMapping
metadata:
  name: logstash-tcp-mapping
  namespace: ambassador
spec:
  port: 5000
  service: logstash.monitoring:5000

From within the ambassador pod, I was able to ensure that ambassador was listening on the port
bash-5.0$ netstat -anp | grep 5000
tcp        0      0 <IP_ADDRESS>:5000            <IP_ADDRESS>:*               LISTEN      113/envoy

Looking at envoy/envoy.json, I do see a mapping avaliable for port 5000
  {
                "address": {
                    "socket_address": {
                        "address": "<IP_ADDRESS>",
                        "port_value": 5000,
                        "protocol": "TCP"
                    }
                },
                "filter_chains": [
                    {
                        "filters": [
                            {
                                "config": {
                                    "stat_prefix": "ingress_tcp_5000",
                                    "weighted_clusters": {
                                        "clusters": [
                                            {
                                                "name": "cluster_logstash_monitoring_5000_ambassador",
                                                "weight": 100
                                            }
                                        ]
                                    }
                                },
                                "name": "envoy.tcp_proxy"
                            }
                        ]
                    }
                ],
                "name": "listener-<IP_ADDRESS>-5000"
            }

However, even though I'm able to telnet to the port - the data never arrives at the logstash service.
When executing kubectl logs on the ambassador pod, even when the request is made, I do not see any logs.
I've double checked the logstash service by doing a kubectl proxy, and I was able to send logs to the logstash pods.
Is there something I am missing from the documentation?

UPDATE:
I've fixed the issue.
Even though the type is specified as TCP in the loadbalancer config, when it is applied to ELB, it is applied as type HTTP instead of tcp.

UPDATE:
I've fixed the issue.
Even though the type is specified as TCP in the loadbalancer config, when it is applied to ELB, it is applied as type HTTP instead of tcp.
To fix this, I had to go to AWS's GUI, and change the type from HTTP 5000 : HTTP  to TCP 5000: TCP  under the ELB's listeners
Is this intended behaviour? If not, I would be open to submitting a PR to fix this, which files should I take a look at?

Hi @xlanor, in Emissary version 2.4 we released a bug fix noting that "prior releases of Emissary-ingress had the arbitrary limitation that a TCPMapping cannot be used on the same port that HTTP is served on. Emissary-ingress now allows TCPMappings to be used on the same Listener port as HTTP Hosts, as long as that Listener terminates TLS."  With version 2.x you configure your own Listener, but I think this may be related to the issue you noted here.  If you test on this version please let us know if it fixes the problem.


[Extension] Adding a project with invalid fstab.yaml fails

This case should be handled more gracefully, allowing the user to manually add the mountpoint later.

:tada: This issue has been resolved in version 3.18.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[stable/datadog] Fix passwd volume error when processAgentEnabled is unset

When processAgentEnabled is not set, trying to instantiate the datadog chart caused the following error:
Error: release datadog failed: DaemonSet.apps "datadog" is invalid: spec.template.spec.containers[1].volumeMounts[2].name: Not found: "passwd"

/ok-to-test

/assign @hkaj
@shang-wang and I have just re-tested that PR in the case where processAgentEnabled is not set. And the process-agent is functioning properly.

/lgtm


Hide link wall from search engines

I think this is best done with a meta tag set in head. It can be set per page with the Meta component.
See related MDN docs. noindex and nofollow are probably what we want.
I also suggest hiding the officials page and the archive to some extent.

Also need to implement link wall (copy from current site)


[WIP] 🐛  content folder has no themes

no issue

if your content/themes folder has no themes, your admin panel doesn't work anymore

TODO

the current fix can work, but this function is used for browsing and editing settings
in case of editing, we only return the affected settings model
and if we keep it like this, Ghost would always return the availableThemes
we should make a differentiation between browsing and editing
because i think, we only need to return the availableThemes on browsing settings (because it's an additional settings key, which does not exist in the database)

I won't have time to finish this (see TODO list), especially not for LTS. If this comes up to be a problem with 1.X, we can raise a proper issue. Closing.


[api] Refactor: Always read params from RequestAdapter

Simple refactoring pattern: Extract method.
@miq-bot assign @abellotti
@miq-bot add_label api, refactoring, darga/no

LGTM.  Thanks !!


Update course choice pages to match production

This applies a bunch of content and UI changes from the course choice flow in production to the prototype.
Changes:

"Have you chosen a course to apply to?" changed to "Do you know which course you want to apply to?"
"Pick a course location" changed to "Which location are you applying to?"
Location names in radios lose their boldness
Course selection changed from autocomplete to radios to match production
Provider autocomplete gains a dropdown arrow
Summary cards on review page are only 2/3rds width

I’ve quite possibly still missed some things. Also need to get my head around how the Apply -> Find -> Apply integration works.

Dirty work, but somebody’s gotta do it 😉 I haven’t looked to closely, but will assume it’s correct.


Updating version for hwc for latest

This is default description of the PR

Close in favor of https://github.com/cloudfoundry/hwc-buildpack/pull/118


⚠ Jenkins Plugins Artifactory has degraded performance

In caceb1f, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1064 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 6ed93cb after 25 minutes.


adds test - rejects invalid nucleotides

Does as it says on the tin

Same issue here. The early, simpler exercises are purposely simple and purposely do not include more advanced concepts like exceptions.
It's great that you're interested in contributing.  What we could really use if you're looking for a place to help out is someone to port additional exercises across from JavaScript to Wren.
Would you be interested in that?


fix: randomize file name before linting

fixes #4 by randomizing the name of the files that it will lint. If it's a .h file, it will change it's contents to make the inclusion guard match the file name.

Great. Thanks for the contribution :)


[Breaking Change] Make emitter shapes easier to construct

Changes emitter shapes to use an inner struct to define properties, so that defaults can be used. Also defines a few convenience functions for creating emitter shapes, and adds Default to EmitterShape itself.
Closes #36

Hey, sorry I never got back to you, and thanks for looking into this. I think my suggestion perhaps wasn't as good as I thought...
EmitterShape::CircleSegment(CircleSegment { etc. is quite of a mouthful. I think either a bunch of convenience methods are going to be needed, or some helper pattern to make it less tedious to write is needed.
One solution would perhaps be to implement From<CircleSegment> for EmitterShape or if it's possible impl<T: ShapeTrait> From<T> for EmitterShape if it's possible.
Then you could do:
emitter_shape: CircleSegment::default().into()

or
emitter_shape: CircleSegment { /* values */ }.into()

Ahh, yeah fair point. I think implementing From<> for the segments would clean this up a good bit.


iMessage thumbnail not working

Describe the bug
when sending and receiving images/video/GIFS in group text with non iPhone users the thumbnail appears as a question mark. also Memojis don't show up in iMessage on my side either.
To Reproduce
Open messages and picture thumbnails are a question mark.
Screenshots

Device (please complete the following information):

iOS Version: 13.3
iOS Device: XS MAx
unc0ver Version: 4.3.1

Place an "x" between the brackets if true:

[ x] this is a bug others will be able to reproduce
[ x] this issue is present with all tweaks uninstalled(except for default packages) or disabled
[ x] this issue is present after a rootfs restore
[ x] this issue is present on the latest version of unc0ver

Logs
If applicable, add logs or error messages here.

What font are you using ?

KG blank space sketch
Sent from my iPhone

On Apr 3, 2020, at 9:13 PM, Malcolmevin<EMAIL_ADDRESS>wrote:

What font are you using ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Thanks 🙌🏾 Are you using A-font I don't see it on there ?

DL iFont and font manager from the App Store. I got the font from iFont.
Sent from my iPhone

On Apr 4, 2020, at 2:43 AM, Malcolmevin<EMAIL_ADDRESS>wrote:

Thanks 🙌🏾 Are you using A-font I don't see it on there ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Solid Query: App crashes when a query in a component is resolved before a query in a context provider

Describe the bug
I'm using Solid Query.
My component hierarchy:
    <QueryClientProvider client={queryClient}>
      <UserProfileProvider>
        <Counter>

Hello, Solid!

        </Counter>
      </UserProfileProvider>
    </QueryClientProvider>

Where UserProfileProvider is a SolidJS context, which contains a TanStack query.
The Counter component contains a TanStack query as well.
If the query function in Counter resolves before the query function in UserProfileProvider, the site crashes during server side render. The server doesn't return anything for 30 seconds, and after that a "renderToString timed out" message is displayed. That's the only error message.
Your minimal, reproducible example
https://stackblitz.com/edit/github-pqy8j7?file=src%2Fcomponents%2FCounter.tsx
Steps to reproduce

Open the link
Wait until the container starts, dependencies are installed.
You are shown a blank page (app crashed instead of displaying the counter)
Wait for a 30 second timeout.
"renderToString timed out" is shown in the console and in the preview window.
--
Optionally:
Change the triggerError to false in Counter.tsx. This will make the query function in Counter.tsx resolve after the query function in UserProfileContext.tsx.
Save file and reload page.
The counter is shown, website is loaded correctly.

Expected behavior
I expected the app to work regardless of the order of promise resolution.
If this is not correct use of Solid Query, I'd expect to see a reasonable error message :)
Environment

Happens every time
OS: Windows 11
Browser: Google Chrome Version 122.0.6261.69 (Official Build) (64-bit)
TanStack Query adapter: solid-query
TanStack Query version: 5.22.2

Additional context
I'm just a user, so I'm not sure if this needs to be addressed on the level of TanStack Query, in SolidJS or in Astro. But since the issue doesn't appear if I use Solid's async mechanism (createResource) instead of TanStack Query, I assume that this is a TanStack Query bug.

@ardeora FYI

Could you pls make sure that when an issue like this happens, there is some error message reported, ideally with stack trace?
I'm faced with "renderToString timed out" errors quite often, and it's hard to debug them as they provide no indicator even which component is failing.


Transition on router-view appears on pageload when router.beforeEach used

Version
3.0.1
Reproduction link
https://codepen.io/exophunk/pen/vdYKjd
Steps to reproduce
A transition animation on <router-view> is supposed to only happen when the route changes, not already on the initial page load. In initial page load, it should only happen, when the "appear" attribute is present on the transition.
When a router.beforeEach() hook is used and next() is called asynchronously, the transition also happens on initial page load. This is not desired and I don't finde a way to prevent it.

Is this an intended behaviour?
I think the usage of the beforeEach hook should not affect the transition on pageload.

What is expected?
No transition on page load in any case
What is actually happening?
Transition on initial page load, but only when beforeEach() hook is used with async callback.

I think a work-around might be using a transition-group? That seems to have done the trick for me, but I wasn't using a beforeEach hook, so the root cause may be different.
At first I tried purposely enabling appear and setting an appear-active class, with no transition, but that wasn't working. Then I tried changing to a transition-group, and that solved the problem entirely, even after removing the appear options.
This was definitely confusing and unexpected IMO. But at least it appears not too many people have an issue with it 😅

It's possible to wait for the router to finish the initial navigation before mounting:
const app = new Vue({
    router
})

router.onReady(() => app.$mount('#app'))

That way, the transition won't trigger initially (unless appear is provided to transition)


Outline is broken

The outline I typically use doesn't work. Some weird problem with the typst counter I implemented. Will take a look and fix when I have more time.
Reference image:

Fixed in 231298bc9530a3967d8515160d0878b0c557d6ca


ARB Feedback - Convert participantIDs to participantIds

What
ARB Feedback - Convert participantIDs to participantIds
Why

In the TypeScript SDK we do not capitalize it. Let's change it to participantIds to be consistent with other libraries and idiomatic to JS
Azure Guidelines explicitly indicate that acronyms should not be fully capitalized (So Id over ID)

How Tested

Process & policy checklist

[ ] I have updated the project documentation to reflect my changes if necessary.
[ ] I have read the CONTRIBUTING documentation.

Is this a breaking change?

[ ] This change causes current functionality to break.

Removing from attention set.


The windows platform downloads "dont work"

Clicking on the link downloads the file "allmark_windows_amd64" without extension, but 7zip can view the contents.
Running the powershell command from the main page nets a connection error.
PS C:\temp\allmark> Invoke-WebRequest https://allmark.io/bin/windows_amd64/allmark.exe -OutFile allmark.exe
Invoke-WebRequest : The underlying connection was closed: An unexpected error occurred on a send.
At line:1 char:1
+ Invoke-WebRequest https://allmark.io/bin/windows_amd64/allmark.exe -O ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:HttpWebRequest) [Invoke-WebRequest], WebExc
   eption
    + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShell.Commands.InvokeWebRequestCommand

if I add ".exe" to the file it appears to be what I want, but the directions may need a bit of touchup.

Confirm same problem.
https://allmark.io/bin/windows_amd64/allmark.exe was not found.


Update envoy for Istio 1.0.2

Upgrade Envoy to Istio 1.0.2's fork of Envoy:
https://github.com/istio/proxy/blob/1.0.2/WORKSPACE#L33-L39
This fork is based on Envoy commit c1cc68dda009452e90d485da22ee9c74c08b328d and fixes a bug with mTLS support.
This PR also cherry-picks commits from https://github.com/cilium/cilium/pull/5499:

Update BUILD_DEPS
Increase Memory available to Bazel to 4GB, limit jobs to 4
Update Bazel to 0.16.1
Remove deprecated Bazel option '--batch'

Signed-off-by: Romain Lenglet<EMAIL_ADDRESS>Signed-off-by: Jarno Rajahalme<EMAIL_ADDRESS>

This change is

The packer build succeeded: https://jenkins.cilium.io/job/Vagrant-Master-Boxes-Packer-Build/114/

test-me-please

Successful CI build: https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/6383/


Reactivate change notifications

Seiso needs to send AMQP notifications when there are changes (item create/update/delete).
See NotificationGatewayImpl for details. Right now the convertAndSend is commented out.

Done.


Add BigDataViewer IO plugin

🚀 Feature
Add plugin to load and apply transformations to data stored in BigDataViewer XML and associated HDF5 file.
Motivation
Using light sheet microscopy, we and others are now routinely generating multi-TB datasets. Many light sheet approaches require multiple processing steps after raw data collection, such as deskewing, deconvolution, and registration, to produce a usable dataset for quantification. @tlambert03 has already provided a great tutorial on how to use Dask and Napari to perform on the fly deskewing and deconvolution for timelapse data for one field of view (FOV) generated using lattice light sheet.
A current roadblock for us is the transition from image registration to quantification for spatially large datasets that consist of many smaller, individual, spatial volumes.  Excellent software packages, such as BigStitcher, have made high-quality registration of tiled volumetric data a routine task. However, once the transformations are determined for each individual tile, it is still common to only a) view the final product or b) write custom code to interact with the very large data for quantification.
For a, the existing BigDataViewer (BDV) ecosystem does a good job of allowing the user to view their data to evaluate the quality of volume registration. There are multiple open-source (including Napari) and commercial tools to produce high quality movies and figures from such data.
We believe b is a common issue that many groups face when using these large area volumetric imaging methods. Given recent progress on a plugin eco-system for Napari, we are wondering if it would be possible to load these very large datasets and apply tools such as StarDist to the data. Here, we initially focus on tiled volumetric data that has been registered by BigStitcher, but one could imagine extending to other registration pipelines.
Pitch
Creation of a new plugin or functionality to correctly load and display a BDV dataset that has been registered and virtually stitched by BigStitcher. Each BDV dataset has an XML that contains all of the transformations (translation, rotation, affine) required to register each tile contained within an HDF5 to a global coordinate system. Using the information in this XML, Napari would display the data associated the current FOV using lazy loading and applying the required transformations. The user could then perform interactive quantification of the current FOV and potentially entire dataset using the plugin scheme.
BigStitcher provides example raw data and aligned + fused data to test their pipeline. This data could be used to check if Napari is correctly loading and applying the transformations as defined in the XML.
Alternatives
A fused image can be produced by BigStitcher. This output can be stored as TIFF, HDF5, or N5. By applying all transformations and blending the edges between tiles, this removes the need to do it on the fly. However, this requires resaving the data, which can be very time and resource consuming for these large datasets.
Some commercial software is also potentially capable of loading and interacting with BDV files, although the ability to perform registration using affine transformations is limited.

Hi @dpshepherd!
I agree 100%, that would be a fantastic plugin!  Want to volunteer 😄?  I (and I'm sure others here) would love to stay abreast of progress on that front and offer suggestions when possible.
Couple immediate thoughts:
@sofroniewn, @jni, and @GenevieveBuckley have made progress adding built-in support for chains of transformations in #1042, and while full support for arbitrary affine transforms is still on the roadmap, i think it's a high priority (see also progress on world coordinates).
So, in the short-term, I think it could make sense to model this after that dask tutorial you mentioned, where the job of your plugin would be to basically create a delayed dask array of  TIFF/HDF5/N5 chunk readers, and use dask.map_blocks to define the chains of transforms.
I'll mention that, while I haven't really "publicized" it, I did turn that dask tutorial into a reader plugin (napari-ndtiffs).  In there is some general-purpose pyopencl affine transform code that follows the same API as scipy (and has been tested to work on both CPU/GPU with fallback to scipy if pyopencl isn't available).   so you might consider perusing that plugin as a starting point?
The main napari plugin hook is here... the core reader function is here ... and that dask.map_blocks call that sets up the affine transform is here.

@dpshepherd this sounds like a great idea.

Each BDV dataset has an XML that contains all of the transformations (translation, rotation, affine) required to register each tile contained within an HDF5 to a global coordinate system. Using the information in this XML, Napari would display the data associated the current FOV using lazy loading and applying the required transformations.

As @tlambert03 notes above, here napari still has a bit of work to do to finish up its transition to having a physical coordinate system, see #1276 for the latest. After that PR goes in, we'll still need a little bit of work to extend our transform system to affine + rotation. At that point a BDV plugin that leveraged the coordinate transforms would be great!

Hi @tlambert03 and @sofroniewn!
Thanks for the helpful and positive responses. I'll talk with the group and see who wants to start tackling this problem. We might be a bit slow on getting started due to other projects, but are vested in seeing this happen.
One question that I just thought of. In the lattice light sheet example, the FOV is the entire XYZ space. For these larger datasets that I'm thinking of, changes to the FOV will need to be returned to the loader so that new data can be pulled from disk and transformed to populate the new XYZ space. Is the location of the FOV something that is currently accessible or planned to be accessible as part of ongoing work?
Part of the reason BigDataViewer is so great is how optimized their loading and display code is. It's amazing how responsive it is while performing transforms on the fly and in the background for massive datasets.

Looping in @pwinston who has been thinking the most recently about tiled rendering and performance considerations.
There is a representation of (“camera”) FOV in napari, but whether we are setup already to handle the needs of this use case is another question.  I would expect that we’d have work to do to match the performance of big dataviewer!  Note also, we don’t currently have support for arbitrary 2slicing through 3D volumes like BDV.  It’s either full 3d projections or 2D orthogonal.

Sorry, I didn't mean to imply that this should compete with BDV. I think it just has to be good enough to allow someone to find an ROI and perform quantification. The ability to do quantification is what is so exciting to me, as this is a huge hurdle right now.
In the beginning of our light sheet adventure, we used Vaa3D for limited viewing + interactive quantification, but our needs diverged from its capabilities.

Glad I found this thread after googling "napari bdv hdf5"!
I second everything @dpshepherd said. a is well addressed, while b remains a bottleneck and headache for us. Would be very excited to see this implemented, and am happy to help/contribute in anyway I can.


refactor(bindings/nodejs): Polish benchmark to make it more readable

Also, cc @promer94 for reviewing.


Improve security (Fixes #32)

Contributor Comments
This improves the security of the docker image by running as a non-root user
Depends on  #91
Pull Request Checklist
Thank you for submitting a contribution to easy_infra!
In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

[x] Rebase your branch against the latest commit of the target branch
[x] If you are adding a dependency, please explain how it was chosen
[x] If manual testing is needed in order to validate the changes, provide a testing plan and the expected results
[x] If there is an issue associated with your Pull Request, align your PR
title with this documentation

Proof that the added test for -nouser -nogroup works is here


JavaScript.Web.WebSocket: ReadyState does not map to readyState constants

Synopsis
The ReadyState type exported by JavaScript.Web.WebSocket has an enum instance which is used to marshall it from the readyState property of a websocket. This enum instance does not properly map the integer constants to ReadyState values. The possible values of the readyState property are given at https://developer.mozilla.org/en-US/docs/Web/API/WebSocket#Ready_state_constants
Expected behavior
getReadyState myWebSocket

returns the ready state of the websocket.
Actual behavior
getReadyState myWebSocket

throws the following exception to the console:
toEnum{ReadyState}: tag (3) is outside of enumeration's range (0,2)
CallStack (from HasCallStack):
  error, called at ./JavaScript/Web/WebSocket.hs:71:29 in ghcjs-base-<IP_ADDRESS>-GiGsdYOoO5CISyJ2m7ax9F:JavaScript.Web.WebSocket

Cause
The ReadyState type is written
data ReadyState = Closed | Connecting | Connected
  deriving (Data, Typeable, Enum, Eq, Ord, Show)

and decoded by
getReadyState ws = fmap toEnum (js_getReadyState ws)

The Enum instance derived by the deriving clause does not map to the ready states given in the WebSocket API documentation.

I've made a pull request #95  which fixes this issue.

Good catch! I wonder if functionality that is available from ghcjs-dom should be eventually removed from ghcjs-base.  ghcjs-dom  has the advantage that is auto generated from the IDL files and this kind of bugs are unlikely to come up

Is ghcjs-dom now the preferred way to access Javascript API functionality? If so, this should be stated somewhere more clearly than it is right now.


Removed the !defined logic as the variable su_user and su_group are d…

The existing code was using defined() to determine if $su_user and $su_group were defined or not.
The variables are parameters of the class with default values of undef.
A variable that has been set to undef is defined, and has a value of undef.
So the code thought $su_user was defined and took its value and placed it into $_su_user, it value being in fact was undef.
This meant that the template which checks for both $_su_user and $_su_group being defined before including the 'su' directive in logrotate.conf failed because the way in which puppet code and ruby code check for whether a variable is defined are different. So ruby was determining that $_su_user was in fact undefined and didn't include the 'su' directive.
This isn't specific to Ubuntu 16.04 but fixes issue #59 I believe.
Switched the code to use selectors which specifically check $su_user and $su_group for having a value of undef or not.
Selectors were used to make it consistent with the other code in the class.

This looks correct.  Would you be able to add tests for su_user and su_group to https://github.com/voxpupuli/puppet-logrotate/blob/master/spec/defines/conf_spec.rb?

@alexjfisher I believe the spec is correct, not very experienced with writing rspec test cases.

Ok the deeper I drill into this the more I find to fix.
Didn't realise 'su' directive can also be used within a rule.
However in rule.pp the parameter was su_owner not su_user like in conf.pp, so I've aligned them on su_user as this is terminology from the logrotate man page.

su user group
Rotate log files set under this user and group instead of  using
default  user/group (usually root).

manpage
Updated the test cases as well to align everything.
The manpage also indicates that both user and group must be specified with the 'su' directive.

Man me and test cases don't get on well ...

This thread needs help, however I miss to see what needs help.
How can I help? :)

@Heidistein if you want you can checkout the feature branch and rebase it against our latest master. Afterwards we can properly review the changes and merge them.

I have rebased the PR, fixed the merges and the tests here:
https://github.com/Heidistein/puppet-logrotate/tree/pr80fix

@Heidistein can you create a PR with this? You can always ping us on slack at https://puppetcommunity.slack.com or on IRC at #voxpupuli on freenode if you need help with git in general or rebasing. We're happy to help out.

This will be replaced with https://github.com/voxpupuli/puppet-logrotate/pull/128


Don't use environment variables for intent environment

Currently the intent environment is being specified using an environment environment, this is a non-native Ansible concept so isn't supported by for example Ansible Tower/AWX. Instead just use env as a fact directly as is being set in https://github.com/srl-labs/intent-based-ansible-lab/blob/dev/playbooks/roles/initialize/tasks/main.yml#L11.
This is what we have changed in our internal fork to make it work with AWX.

Addressed with commit https://github.com/srl-labs/intent-based-ansible-lab/commit/4e2a328fdabdaffa374df0712b57b7085e629ffc
Now you can provide an extra_var 'intent_dir' from which intent files will be read, e.g. ansible-playbook -e intent_dir=<intent_dir> ...

No reliance on env vars anymore. It's still there for existing CI/CD pipelines but no longer required.


CI ONLY Fix npm crashes on the CI servers

Trying to address the following error happening all the time on our CI when several jobs start at the same time:
npm ERR! unpack Could not read data for<EMAIL_ADDRESS>npm ERR! unpack Could not read data for<EMAIL_ADDRESS>npm ERR! unpack Could not read data for<EMAIL_ADDRESS>npm ERR! unpack Could not read data for<EMAIL_ADDRESS>npm ERR! unpack Could not read data for<EMAIL_ADDRESS>npm ERR! unpack Could not read data for<EMAIL_ADDRESS>npm ERR! unpack Could not read data for<EMAIL_ADDRESS>/localhome/jenkins/a/workspace/scalajs-task-worker
├─┬<EMAIL_ADDRESS>│ └──<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>  └──<EMAIL_ADDRESS>
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/dashdash/node_modules/assert-plus):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: Unknown system error -116: Unknown system error -116, read
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/extsprintf):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: Unknown system error -116: Unknown system error -116, read
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/jsprim/node_modules/assert-plus):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: Unknown system error -116: Unknown system error -116, read
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/json-schema):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: Unknown system error -116: Unknown system error -116, read
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/sshpk/node_modules/assert-plus):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: Unknown system error -116: Unknown system error -116, read
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/verror):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: Unknown system error -116: Unknown system error -116, read
npm ERR! Linux 4.4.0-66-generic
npm ERR! argv "/home/jenkins/apps/node-v6.9.5-linux-x64/bin/node" "/home/jenkins/apps/node/bin/npm" "install"
npm ERR! node v6.9.5
npm ERR! npm  v3.10.10
npm ERR! code Unknown system error -116
npm ERR! errno -116
npm ERR! syscall read

npm ERR! Unknown system error -116: Unknown system error -116, read
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     /localhome/jenkins/a/workspace/scalajs-task-worker/npm-debug.log

I am posting the error message in full because I could not find anyone on the Internet with the same error code. Hopefully this page will serve as a reference for future users.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/4033/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/5343/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/4034/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/5344/
Test FAILed.

OK solved. It was a race condition when different machines were running npm install at the same time, and using the same cache folder (through NFS). I solved it by convincing npm to use a cache folder on a local file system (with npm config set cache /path/to/some/local/dir/.npm).


file doc/a1893982.txt contains ‘XXXXXXX’

Hi, thanks for your project! I think I may have found an issue” - be humble and kind. You may be adding more stress to an overworked person trying to do altruistic work…

thanks for reporting


FrictionContactsSystem.cs and SpeedModifierContactsSystem.cs refactoring

About the PR
Refactored FrictionContactsSystem.cs and SpeedModifierContactsSystem.cs (this is my first time refactoring, and because of that, this is probably very bad).
Why / Balance
Resolves #22046, resolves #22104 (propably).
Technical details

Moved anything that is shared between FrictionContactsSystem.cs and SpeedModifierContactsSystem.cs into the SharedContactsSystem.cs.

Made some other minor changes.

Swapped some methods around.

Media

Requirements

[X] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

None.

Unrelated failed check?...


proj_psnr VS psnr_3d

Nice work! I have run your code on the chest_50 data. I find that your method can achieve 32 psnr_3d but 12.8 proj_psnr. The proj_psnr is pretty low. I also try to change the hashgrid encoding to frequency encoding, which achieves 23.9 psnr_3d and 30.63 proj_psnr.
I wonder why your method achieves superior psnr_3d but a pretty low proj_psnr since you use the proj_mse to optimize the model.
It would be appreciated if you can provide some explanation.

Thanks for your interest in our work. I reran the code with the chest_50 data and obtained 33.2 psnr_3d and 40.9 proj_psnr. Could you please check if you made any modifications? If not, could you provide more details, such as logs, so that I can identify the potential problem?
 See logs in ./logs/chest_50
epoch=1500/1500, loss=8.3e-08, lr=0.0001: : 75050it [10:37, 117.82it/s]

@Ruyi-Zha Thank you for your reply. I find that this is because I use the chest_50 data generated by myself from raw data with the generateData.py. I have generated twice and run the experiments twice. The proj_pnsr is still pretty low. See the logs here:
[Start] exp: chest_50_2, net: Basic network
epoch=0/1500, loss=0.00438, lr=0.001:   0%|          | 1/75000 [00:01<30:02:08,  1.44s/it][EVAL] epoch: 0/1500, proj_mse: 0.00756, proj_psnr: 7.04, psnr_3d: 9.64, ssim_3d: 0.314
epoch=250/1500, loss=9.73e-08, lr=0.001:  17%|█▋        | 12504/75000 [02:13<10:52, 95.83it/s][EVAL] epoch: 250/1500, proj_mse: 0.00017, proj_psnr: 12.2, psnr_3d: 31, ssim_3d: 0.947
epoch=500/1500, loss=6.2e-08, lr=0.001:  33%|███▎      | 25006/75000 [04:26<48:39, 17.12it/s] [EVAL] epoch: 500/1500, proj_mse: 0.000189, proj_psnr: 13.2, psnr_3d: 31.7, ssim_3d: 0.952
epoch=500/1500, loss=1.02e-07, lr=0.001:  33%|███▎      | 25050/75000 [04:27<18:22, 45.31it/s][SAVE] epoch: 500/1500, path: ./logs/chest_50_2/ckpt.tar
epoch=750/1500, loss=7.72e-08, lr=0.001:  50%|█████     | 37501/75000 [06:39<06:22, 98.04it/s][EVAL] epoch: 750/1500, proj_mse: 0.00021, proj_psnr: 11.4, psnr_3d: 31.9, ssim_3d: 0.953
epoch=1000/1500, loss=6.27e-08, lr=0.001:  67%|██████▋   | 50001/75000 [08:52<04:23, 94.92it/s][EVAL] epoch: 1000/1500, proj_mse: 0.000225, proj_psnr: 12, psnr_3d: 32, ssim_3d: 0.954
epoch=1000/1500, loss=7.11e-08, lr=0.001:  67%|██████▋   | 50050/75000 [08:52<09:07, 45.55it/s][SAVE] epoch: 1000/1500, path: ./logs/chest_50_2/ckpt.tar
epoch=1250/1500, loss=5.29e-08, lr=0.001:  83%|████████▎ | 62502/75000 [11:04<10:53, 19.12it/s][EVAL] epoch: 1250/1500, proj_mse: 0.000245, proj_psnr: 12, psnr_3d: 32, ssim_3d: 0.954
epoch=1500/1500, loss=5.86e-08, lr=0.0001: 100%|██████████| 75000/75000 [13:15<00:00, 95.46it/s][EVAL] epoch: 1500/1500, proj_mse: 0.000265, proj_psnr: 12, psnr_3d: 32, ssim_3d: 0.954
epoch=1500/1500, loss=5.15e-08, lr=0.0001: : 75050it [13:16, 45.19it/s][SAVE] epoch: 1500/1500, path: ./logs/chest_50_2/ckpt.tar
epoch=1500/1500, loss=5.15e-08, lr=0.0001: : 75050it [13:17, 94.10it/s]
Training complete! See logs in ./logs/chest_50_2

I also run the experiment on your example chest_50.pickle. The logs are shown here:
0%|          | 0/75000 [00:00<?, ?it/s][Start] exp: chest_50_2, net: Basic network
epoch=0/1500, loss=0.0051, lr=0.001:   0%|          | 1/75000 [00:01<33:15:57,  1.60s/it][EVAL] epoch: 0/1500, proj_mse: 0.00682, proj_psnr: 7.73, psnr_3d: 9.11, ssim_3d: 0.31
epoch=250/1500, loss=2.02e-07, lr=0.001:  17%|█▋        | 12501/75000 [02:14<10:51, 95.97it/s][EVAL] epoch: 250/1500, proj_mse: 3.68e-06, proj_psnr: 29.5, psnr_3d: 30.8, ssim_3d: 0.946
epoch=500/1500, loss=1.22e-07, lr=0.001:  33%|███▎      | 25001/75000 [04:26<08:06, 102.76it/s][EVAL] epoch: 500/1500, proj_mse: 1.89e-06, proj_psnr: 33.1, psnr_3d: 32.1, ssim_3d: 0.957
epoch=500/1500, loss=1.42e-07, lr=0.001:  33%|███▎      | 25050/75000 [04:26<19:10, 43.43it/s][SAVE] epoch: 500/1500, path: ./logs/chest_50_2/ckpt.tar
epoch=750/1500, loss=1.1e-07, lr=0.001:  50%|█████     | 37501/75000 [06:39<06:19, 98.88it/s] [EVAL] epoch: 750/1500, proj_mse: 1.8e-06, proj_psnr: 32.8, psnr_3d: 32.5, ssim_3d: 0.96
epoch=1000/1500, loss=5.75e-08, lr=0.001:  67%|██████▋   | 50005/75000 [08:52<04:16, 97.26it/s][EVAL] epoch: 1000/1500, proj_mse: 2.01e-06, proj_psnr: 32.8, psnr_3d: 32.7, ssim_3d: 0.961
epoch=1000/1500, loss=1.03e-07, lr=0.001:  67%|██████▋   | 50050/75000 [08:52<11:05, 37.47it/s][SAVE] epoch: 1000/1500, path: ./logs/chest_50_2/ckpt.tar
epoch=1250/1500, loss=9.02e-08, lr=0.001:  83%|████████▎ | 62501/75000 [11:04<02:11, 95.31it/s][EVAL] epoch: 1250/1500, proj_mse: 1.98e-06, proj_psnr: 33.1, psnr_3d: 32.9, ssim_3d: 0.962
epoch=1500/1500, loss=5.66e-08, lr=0.0001: : 75008it [13:16, 18.14it/s][EVAL] epoch: 1500/1500, proj_mse: 2.56e-06, proj_psnr: 30.3, psnr_3d: 33, ssim_3d: 0.962
epoch=1500/1500, loss=8.92e-08, lr=0.0001: : 75050it [13:17, 47.03it/s][SAVE] epoch: 1500/1500, path: ./logs/chest_50_2/ckpt.tar
epoch=1500/1500, loss=8.92e-08, lr=0.0001: : 75050it [13:18, 94.01it/s]
Training complete! See logs in ./logs/chest_50_2

No modification in chest_50.yaml except the name:
exp:
  expname: chest_50_2
  expdir: ./logs/
  datadir: ./data/chest_50_2.pickle
network:
  net_type: mlp
  num_layers: 4
  hidden_dim: 32
  skips: [2]
  out_dim: 1
  last_activation: sigmoid
  bound: 0.3
encoder:
  encoding: hashgrid
  input_dim: 3
  num_levels: 16
  level_dim: 2
  base_resolution: 16
  log2_hashmap_size: 19
render:
  n_samples: 192
  n_fine: 0
  perturb: True
  raw_noise_std: 0.
  netchunk: 409600
train:
  epoch: 1500
  n_batch: 1
  n_rays: 1024
  lrate: 0.001
  lrate_gamma: 0.1
  lrate_step: 1500
  resume: False
log:
  i_eval: 250  # Epoch for evaluation
  i_save: 500  # Epoch for saving

Also no modification for the config.yml for generating chest data:
# Parameters to setup CT simulation.

# dataset
numTrain: 50
numVal: 50

# System configuration
DSD: 1500.0  # Distance Source Detector      (mm)
DSO: 1000.0  # Distance Source Origin        (mm)

# Detector parameters
nDetector: # Number of pixels              (px)
- 256
- 256
dDetector: # Size of each pixel            (mm)
- 1.5
- 1.5

# Image parameters
nVoxel: # Number of voxels              (vx)
- 128
- 128
- 128
dVoxel: # size of each voxel            (mm)
- 1.0
- 1.0
- 1.0

# Offsets
offOrigin: # Offset of image from origin   (mm)
- 0 # x direction
- 0 # y direction
- 0 # z direction
offDetector: # Offset of Detector (only in two direction)            (mm)
- 0 # u direction
- 0 # v direction

# Auxiliary
accuracy: 0.5 # Accuracy of FWD proj          (vx/sample)

# Mode
mode: cone # X-ray source mode parallel/cone
filter: null

# Angles
totalAngle: 180.0 # Total angle  (degree)
startAngle: 0.0 # Start Angle (degree)
randomAngle: False

# CT
convert: False
rescale_slope: 1.0
rescale_intercept: 0.0
normalize: True

# Noise
noise: 0

Thank you for your reply. I identified the issue: I mistakenly set dDetector in chest/config.yml to 1.5 instead of 1.0. This caused some rays to be outside the predefined space, leading to artifacts in the rendered 2D projections and low psnr_proj values. I have updated the repository and data. You should now be able to get the expected results. Thanks for your help.
dDetector=1.5

dDetector=1.0

Thank you for your reply. Nice work!


Allow states to be initial and final states.

It's legal for states to be an initial and a final state, especially in machines with only one state. Right now, the $type only supports either INITIAL or FINAL (among other choices).

Can initial states be final? Would that be something like this?
<state id="p">
    <final id="q"/>
</state>

It's not very useful, but yeah, I'd imagine initial states can be final states. No reason why not.

Both SCXML and Statecharts have special syntaxes for initial states and for final states, and so the $type attribute is a carry-over of that special syntax requirement. In practice, semantically, initial states are not very different from regular states.
@davidkpiano Can you provide a use case for this? Thank you.


Transfer request cancelled by a third device simultaneous connection

The bug
While checking the error notification for "The recipient is busy with another request" I noticed that I was able to use the Close button on a third device to interrupt the transfer between the other two.
To reproduce

Set up a file transfer between two devices.
Start a third connection on another device.
Press the close button on the third device before the transfer begins.

Expected behaviour
Upon pressing the Close button the receiving end will notify that the sender has cancelled the transfer request.
Screenshots

The "man in the middle" device:

The desktop client after the forced interruption:

Devices
Desktop: Linux Pop Os ( Recipient )
Phones: Android 9 device ( Sender ) , Android 11 Device (  Man in the middle )

I guess this behaviour would be fixed like this, but I'm not sure if there are some trickling down effects with this change.

Yes, the gateway removes the original IPs of the mobile phones which makes it hard for the server that only relies on IP.
I have added a PR for the protocol: https://github.com/localsend/protocol/pull/5


Community Meeting September 6, 2022

At 11am Eastern, 8am Pacific, 3pm UTC; find your time
Video call link: https://meet.google.com/mpd-cypd-sdp
Or dial: (DE) +49 30 300195060 PIN: 500<PHONE_NUMBER>#
More phone numbers: https://tel.meet/mpd-cypd-sdp?pin=5005991305702
Or join via SIP<EMAIL_ADDRESS>Meeting recordings available on YouTube at https://www.youtube.com/channel/UCfP_yS5uYix0ppSbm2ltS5Q
This issue will collect prospective agenda topics.

0.8 🎉
README hackmd: https://hackmd.io/-YpPqiVsQZyiPIjyoxLiKw?both

https://github.com/kcp-dev/kcp/issues/1891

Split of EPIC Multi-Release-Epic: Consume Compute via Transparent Multi Cluster set up in a different workspace.
Some remaining issues moved to new epics:

Compute type Management
Support for multiple SyncTargets syncing and coordination controllers

Recording: https://www.youtube.com/watch?v=6zK66ajsZPI


Support for Fat Formats (Fat Default)

Hi,
Awesome library! Is there any chance in allowing for support for Plain Fat Format (non Fat32, but just Fat)?
I have a requirement that users will plug in specific flash storage devices that are less than 500Mb. Fat32 is of course too big for these devices.
Do you know of any other library that supports plain Fat Format? Or is there any plans to support this format in this library.
Thanks

Have you looked at the experimental java-fs module?


Revert "Add my first file"

Reverts Exp-Intro-to-GitHub-Flow-Cohort-1/series-intro-to-github-flow-virtualbox99#2

00


Issue from website page Get Started: Configure Editor

s/combioned/combined

Thanks for the report! Just pushed flutter/website#842 to fix.


Blazor movie dB tutorial Paginator updates

Description
Addresses #34211
Related to #34214

Five row default pagination
Isolated CSS row height styling (2em)
Vertical table cell content centering

Page URL
https://learn.microsoft.com/en-us/aspnet/core/blazor/tutorials/movie-database-app/part-8?view=aspnetcore-9.0
Content source URL
https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/blazor/tutorials/movie-database-app/part-8.md
Document ID
62c56ff5-cdd9-160b-c45c-5215644c0737
Article author
@guardrex
Related Issues

@danroth27 ... I'm going to go with 3em to exaggerate it a bit to make it clear that it had an effect ...
::deep tr {
    height: 3em;
}

::deep tr > td {
    vertical-align: middle;
}

For the following images, I'll temporarily go with four records to see what the second screen looks like. In the article, I'll have the reader go with five rows.


can the YouTube class downloads videos with proxy enable?

如题

I think your issue is a duplicate of #139. If it's something else, feel free to reopen.

@vn-ki
they are not the same issue,of course ,Youtube class has the interface for proxy,but  playlist class has no  such interface,however playlistclass has some Youtube class instances,but it HAS NO proxy for playlist.


[BUG] Form Recognizer - Table Row and Column Indexing not accurate

Apologies if this is not the correct place to raise, I am finding the auto Table parsing not completely accurate. Trying to train models on multple documents has not improved things.
Take the following example

The highlighted text has been placed in row 16 column 8, when it should be part of row 17.
Using Azure.AI.FormRecognizer v3.0.0
Thanks

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

Thanks @chrizy for the information.
Looping @NHaiby @ramparab as in this case, the information is coming directly from the service

Looping @esclee in as owner

Please also try out the new release which enables you to label and train on tables.
https://docs.microsoft.com/en-us/azure/cognitive-services/form-recognizer/whats-new

@esclee @NHaiby @anrothMSFT can you help with this issue?

@esclee @NHaiby @anrothMSFT - Following up to see if there is any update on this issue? - Thank you

@chrizy Can you still reproduce this issue with the latest SDK version (4.0.0-beta.3)?


Fix piwik metrics reporting

Bug Description
events.canonical.com has the piwik plugin installed, however it does not seem like metrics are set up correctly since all values are zero. This might be as simple as fixing the configuration, but I didn't want to mess around with it as I don't know the right URLs and tokens:
https://events.canonical.com/admin/plugins/piwik/
To Reproduce
Visit https://events.canonical.com/event/2/manage/statistics/
Environment
events.canonical.com
Relevant log output
none

Additional context
No response

We need this at latest when we have the Ubuntu Summit site up, but it would be good to test this prior with an event like the upcoming sprint.


Expected behavior
Fire event when you drop the image, not when you drag.
Or add a drop event ?
Additional context
Test with jQuery
Thanks ^^

It currently should fire an event when the index changes. Does it fire events when it stays the same?

If I drag & drop an image, I have 11 events (test with two images)

Fixed in 4.17.1, event now also receives origin and target properties which contain indexes
https://github.com/pqina/filepond/releases/tag/4.17.1

At the top ! Thanks for the reactivity ^^


chore(deps): update tubenhirn/semantic-release-github docker tag to v4.1.4

This PR contains the following updates:

Package
Update
Change

tubenhirn/semantic-release-github
patch
v4.1.3 -> v4.1.4

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 5.3.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Some command line options (--enable-gpu-rasterization) require a different order than specified in --help

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

[X] Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
[X] Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
[X] Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
[X] Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
[X] Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
When starting atom from the command line, it seems some options have to be specified after the file path. This is not documented AFAICT.
Specifically I found that --enable-gpu-rasterization cannot come before the file path (as specified in --help usage, it only works correctly when it comes after).
I found this when reading and attempting workarounds for:
https://github.com/atom/atom/issues/12634
Steps to Reproduce

Make sure you close all atom windows and quit atom completely.
Start atom from the command line:

atom --enable-gpu-rasterization ~/some_project

Expected behavior: Atom starts, and opens the folder ~/some_project
Actual behavior: Atom opens, but doesn't open the project folder
Reproduces how often: 100%
Note: Seems to be the same for --disable-gpu as well.
Workaround
Switch the order of the arguments:
atom ~/some_project --enable-gpu-rasterization

or use a function (add to ~/.bash_profile:
function atom-gpu {
    atom $1 --enable-gpu-rasterization ;
}

Versions
Atom    : 1.17.2
Electron: 1.3.15
Chrome  : 52.0.2743.82
Node    : 6.5.0
Mac OS Sierra
Version 10.12.5
Additional Information
This might be intended behaviour, for the more advanced options parameters, but I believe it should be documented (better?).
I'm sorry if this is documented somewhere, I tried searching Issues, FAQ, and message board, but couldn't find anything. Feel free to link to relevant docs and close issue if appropriate.

I'm thinking that this is because the flags you're referencing are Chromium flags, not Atom flags.  So Atom disregards them when reading its options and passes them down to Chromium.


Need clean target?

I am gettimg errors when using Build.Clean or Build.Rebuild.
------ Clean started: Project: NodejsWebApp1, Configuration: Debug Any CPU ------
npm ERR! missing script: clean
npm ERR!      C:\Users\joseo\AppData\Roaming\npm-cache_logs\2019-11-07T15_16_15_572Z-debug.log
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VisualStudio\v16.0\Node.js Tools\Microsoft.NodejsToolsV2.targets(56,5): error MSB3073: The command "npm run clean" exited with code 1.
Done building project "NodejsWebApp1.njsproj" -- FAILED.
Build FAILED.
========== Clean: 0 succeeded, 1 failed, 0 sk
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c4b0ea28-4a31-a3ea-fa5f-c32d5c72d4bd
Version Independent ID: 31bd064b-51eb-5505-986e-2c7148784085
Content: Create a Node.js and React app - Visual Studio
Content Source: docs/javascript/tutorial-nodejs-with-react-and-jsx.md
Product: visual-studio-windows
Technology: vs-javascript
GitHub Login: @Mikejo5000
Microsoft Alias: mikejo

@joseogl Hi, at what section and iinstruction did you run into this error? Do you run into errors when not using Clean or Rebuild and just following the instructions as described in the article? Thx!

Some of the templates previously had a post build event in the .njsproj file, like this, which supported the Clean/Rebuild:
npm run build
See this:
https://docs.microsoft.com/en-us/visualstudio/javascript/quickstart-vuejs-with-nodejs?view=vs-2019#build-the-project
I believe this element was removed from more recent projects for some reason.

Thanks.  I just got this error while trying to rebuild while exploring the project. I am trying to get debugging the client side to work without any luck do far.

What version of Visual Studio are you using? And what browser are you running in?

@armanio123 Armando, do you know why Clean/Rebuild doesn't work in the templates? Looks like it might be due to a template change, as I noted above.

I am using VS2019 Community v 16.3.8 with Edge, Chrome, and Edge Beta. No matter what, I can't breakpoints to hit on the client code.  Server side code hits breakpoints.

Did you see any errors? What was the result? It is a tricky area with source maps and transpiled code. I know that the steps to do this need to be exact:

Set a breakpoint in client-side code in an area of code that will execute.
Make sure your sourcemaps are correct. Both relative path and prefixes. In this example, the array should have a reference to "./app.tsx" and not "webpack:///./app.tsx". If you've moved around source files, that can be a source of path issues, too.
Close all browser instances (use Task Manager to close extensions).
Open the browser in debug mode. I suggest using the Start > Run command line if you tried the UI config already.
Start without debugging.
Attach to process.
In Attach to Process dialog box, select the correct script debugger type, as described, and Attach to the correct browser instance.
Restart the browser.

If these steps don't work, you might need to use the F12 tools for client-side code.

Also, with Edge Beta (Chromium base), I believe I've seen Chrome extensions interfere with getting the Edge Beta browser into debug mode.

Visual Studio uses the build and clean scripts of the package.json when executing either Build, Rebuild or Clean . The error message states that the clean script is missing. To fix it you can either add it to the package.json or remove the command my modifying the project.
Examples:
Add to package.json (assuming you're using TypeScript):
...
scripts {
  "build": "tsc --build",
  "clean": "tsc --build --clean"
}
...

To remove the commands all together, add the following lines to your project (right click > unload project, right click > edit project) inside the project node:
<Project DefaultTargets="Build" ... >
...
  <Target Name="AfterClean"></Target>
  <Target Name="AfterCompile"></Target>
</Project>

The scripts might be tailored based on the your project kind and needs.

Thanks @armanio123. I will try the package.json changes.
@Mikejo5000 I have followed the steps for debugging as suggested.  Here are my results.
I was unable to launch Microsoft Edge (not the Beta) with the debugger port argument suggested. U switched to Chrome and that allowed me to set the breakpoint in the JS file not TS file (because of the change to webpack-config.js?). Unfortunately I get a message in VS saying that a debugger operation is taking too long to complete. My breakpoint flashes and Chrome then displays a message saying that the script is Paused I Visual Studio Code.  (I do have Visual Studio Code but am using Visual Studio).  Upon hitting F5 in Visual Studio, the text renders but I don't get any more breakpoint hits. So closer but still no cigar. Thanks for the help.

Yeah, I think only Chrome or the Edge Beta will work for debugging with source maps. I don't think regular Edge can do it.

@joseogl BTW, I have seen that exact issue with script paused in Visual Studio Code. If I recall correctly, the issue was either the wrong relative path in the source map to "webpack:///...." or it was that the browser was not getting into debug mode properly, with other instances of Edge (Chromium) / Chrome / Chrome extensions interfering.
Besides F12 tools, another option would be to try the project with Visual Studio Code. They have a debugging extension for Chrome and Edge (Chromium) that may simplify this whole scenario.

I am closing this issue now.  You are welcome to @ mention me for any followup.
We hope to hear from you again.

Keeping this open for upcoming doc on compile and build. Some of the comments above may be helpful.

Adding docs on compile and build.


PowerShell Saturday Paris Logo

Working with @lazywinadmin (FX) to design a PowerShell Saturday Paris logo/sticker. He would like something nice and simple, a relatively flat design. We have worked on a few mock-ups together.

cc: @omiossec @LaurentLienhard @stephanevg

These are some of the ideas thus far, as worked on with @lazywinadmin:

And icon:

This was original idea, but we both found it a bit too.... busy:

I like the last one

I like the logo on icon. The ps Saturday one a bit less

For the PS Saturday I like the last but without the face and maybe a little less yellow color for the logo

Hi All!
OK, so the original design (last one) was a bit too complicated. We can definitely mute colours and remove elements, but I'd encourage taking another look at the one at the top.
Remember that it will likely be shrunken down, and possibly be put on a sticker. Simplicity works better in those cases.
I'll leave you all to discuss, and come to a consensus. Once that's clear, we can proceed with one direction. Sound good?
Merci beaucoup!

I think the logo needs to be like a light projecting the logo.....representing the light on top of the tower

I prefer the first one, simple and direct. PowerShell and Paris.
Any ideas on how it could be improved ?

First one for me 👍

Hi All, yes I'm leaning towards first one as well.
Can work on enhancing it a bit.
I still feel like we could integrate a hashtag in there. SOmething like #PSSatParis ?
Please feel free to share ideas, Mes Amies!

Hey @adilio Thanks again for your help.
I think we will go with the first logo (powershell core logo with the yellow eiffel tower in it).
Would you have a large version ?

Of course @lazywinadmin !
Larger PNG is here in the repo at:
https://github.com/adilio/ps-design/blob/master/ps-saturday-paris/ps-saturday-paris-large.png
Larger scalable SVG is at:
https://github.com/adilio/ps-design/blob/master/ps-saturday-paris/ps-saturday-paris-large.svg
You can make that one as big as you like in InkScape (OSS).
Cheers! 🍻

Thank you sir! We own you one 👍 🍺

As the work is now complete on this, going to go ahead and close this issue. Cheers!


About training settings

Hi Johan,
I really appreciate your great work RoMa. I found that the training strategy of RoMa (i.e., scheduler) is different from DKM. Does using different training strategies help with performance?
Thank you so much for your help!

I think it does give a slight improvement, stepping later gives a little boost. The baseline in the paper is already with that improvement compared to DKM. I think its about 0.5 points or so.

Thank you for your answer!


Simplify nested characters classes and expression character classes

Motivation
The v flag added set operation to character classes. These set operations can be simplified in some cases.
Description
The rule should apply the following simplifications:

[[abc]] -> [abc] and [^[abc]] -> [^abc] and [[^\w&&\d]] -> [^\w&&\d]: remove trivially nested (expression) character classes.
[[abc][def]ghi] -> [abcdefghi]: always inline non-negated character classes.
[a&&[^b]] -> [a--b] and [[^b]&&a] -> [a--b]: use subtraction
[a--[^b]] -> [a&&b]: use intersection
[[^a]&&[^b]] -> [^ab]: De Morgan

Thank you for the rule suggestions! I haven't really used nested character classes yet, but I think the rule is very useful!

I haven't really used nested character classes yet

Same. I only used them when writing tests for v flag regexes thus far. These simplifications are just a suggestion.
I'm looking forward to using the v flag in practice though. I had to write quite a few regexes like /(?!\s)[\w\x80-\uFFFF]/ in the past, and I can now rewrite them, e.g. as /[[\w\P{ASCII}]--\s]/v.
We might even want to make a rule for that. If a regex has the v flag, then transform (?=[x])[y] => [y&&x] and (?![x])[y] => [y--x]. Let me make an issue for that.

I was working on no-useless-character-class rule and noticed that it supports two patterns. #593

/[[abc]]/v -> /[abc]/v
/[[^\w&&\d]]/v -> /[^\w&&\d]/v

However, the following patterns are not supported yet. I'm wondering whether we should support them with no-useless-character-class rule or create a separate rule.

/[^[abc]]/v -> /[^abc]/
/[[abc][def]ghi]/v -> /[abcdefghi]/v

https://github.com/ota-meshi/eslint-plugin-regexp/pull/593/files#diff-eb1d64f6019f074be64747d51d62981aaddc46eb17bf309a9f11da0789c5fdabR51-R54

By the way, I think it would be better to use a separate rule to check patterns that rewrite the following expressions. Because I think it's an optimization problem.

/[a&&[^b]]/v -> /[a--b]/v
/[a--[^b]]/v -> /[a&&b]/v
/[[^a]&&[^b]]/v -> /[^ab]/v

However, the following patterns are not supported yet. I'm wondering whether we should support them with no-useless-character-class rule or create a separate rule.

/[^[abc]]/v -> /[^abc]/
/[[abc][def]ghi]/v -> /[abcdefghi]/v

I thought for a moment and thought the rule should support them, so I'll change the rule.


git Ignoring most of the build files

Hey,
Everything works great, but I have just a little problem.
It looks like when I installed this package it automatically added the nativescript/app/app path to my .gitignore file.
So I wanted to ask - what more can I\you recommend ignoring?
I really don't like the idea of pushing all of nativescript/node_modules and every platform's build under nativescript/platforms/[android\ios], it looks like theres a ton of code there, which can be generated whenever one wants by running tns run [android/ios] if I understood correctly.
Thanks in advance!

Hi @LiorArbel yes for sure you absolutely want to ignore:
nativescript/app/app
nativescript/hooks
nativescript/lib
nativescript/node_modules

I could add that if that seems easier to the auto gitignore modification?

@NathanWalker Thank you, I'll add these to my gitignore.
It would be cool if you added it to the gitignore automatically 😄

Hi LiorAbel,
Can you please provide me a one example of "ng2-magic" for intergate the nativescript code with angular2 app code.

Hi Nathawalker,
please provide me a one live example .


Don't decrypted data when writing generated secret

If the user puts an encrypted value a secret data field
in the Acornfile do not decrypt the value when creating the generated
secret in the app's source namespace. This causes an undesired side
effect  in that the user can now do "acorn secret reveal" to get the
clear text of an encrypted secret. This isn't a secret issue because
the users has already been granted "reveal", but we'd rather not
reveal the clear text value for a secret that was intentionally
encrypted by the user.
Signed-off-by: Darren Shepherd<EMAIL_ADDRESS>Checklist

[ ] All relevant issues are referenced in this PR
[ ] The title of this PR would make a good line in Acorn's Release Note's Changelog
[ ] Commits follow contributing guidance.
[ ] Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
[ ] Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description

https://github.com/acorn-io/hub/issues/216