Too much logic in the models and controllers.

Hey guys,
I would like to make a pull request to move out a lot of the logic in the models. I recommand a more SOA/DDD approach:
Models: I think that the model should represent an entity. With Laravel, I only use the model class to add things like fillable, guarded, table and the relations. (If the Repository Pattern isn't used,  the model would also have the save, update, find, etc methods/scopes).
Services: The home of global logic, containing functions that are used throughout the app. This service class can then be a single point of entry and give the app a lot of the required functionality, as an example, functions like sendMessage, createThread would handle the the required logic to send a message or to create a new thread.  Making the controller of the app slim, DRY and less error prone.
A service class will also allow the creation of a facade.
How does this sound? Would you be interested in moving logic into a separate class?
Raoul
EDIT: I forgot to mention that a service class also allows for beter testing and will allow for beter eager loading! At the moment eager loading in this package is a big problem if the default functions are used.

:+1: This gets my vote !

Yes, I have toyed around with this and I would personally like this a lot better. The original idea of this package was to just keep it simple, open, and as easy to use in Laravel as possible. New users look to controllers and models to see what's going on and might get confused with more abstraction. I'm hesitant to make this package more abstracted and much less "simple".
So with that, in my mind we have two options:

Do it anyways with this package
Make a new package, DDD it up, and maybe offer it to other frameworks too. Similar to what Cartalyst does with it's packages.

Thoughts?

my vote is on option 1, people should learn not to put all the logic in the models and it's not too hard to look through the code anyway they should know that they have it all available under the vendor folder.

I would go with option 1, but create a new version with the new improvements (2.x.x) and leave the old version there as legacy (1.x.x) just support bug fixes.
This way people can use the old "easier" method or the newer version package.

I would go with option 1. I agree that this package needs to remain simple. But i believe by adding a service class it will become a simpler.
@override-chaos Isn't this package already at 2.x? Lets make this a 3.x version branch.

Ok, let's move forward with option 1. What about branching from the current master to a v2 branch, and keeping this new v3 version on master (develop branch initially)?

@cmgmyr Sounds great .
So this is how i see it:
Thread is the aggregate. This means the first step for an app would be to get a thread object(s).
$threads = $messenger->getAllTreadsForUser()
$threads = $messenger->getThreadsBetweenUsers()
All methods are called on thread objects.
$thread->sendMessage()
$thread->addParticipant()
This is a very OOP way of handling it. What do you think?

The functions that are requiered as entry point that i can think of are:
public function getThread($threadId)
public function getAllThreads()
public function getAllTreadsForUser($userId)
public function getUpdatedTreadsForUser($userId)
public function getThreadsBetweenUsers($participants)
public function createThread($participants)

Thanks everyone, I'm just doing some housecleaning right now. v2 and develop branches have been made. Also added a milestone for v3 to better track the changes that need to be done. I'm going to close this issue in favor of #51. I'll add everything into that issue shortly. Thanks for all of the input so far!


werf build is unusably slow on large repositories with git-lfs

Before proceeding

[X] I didn't find a similar issue

Version
1.2.152
How to reproduce

Craft a multi-GB repository that contains git-lfs objects
Create any werf.yaml in repo root. Example:

configVersion: 1
project: example
---
image: example

Run werf build multiple times

Result
Each werf build run is extremely slow
$ werf build --dev --verbose
Version: v1.2.152
┌ Switch work tree /home/marat/.werf/local_cache/git_worktrees/9/local/5099c8a4a567d60d44685d73b0054912613f26fe ...
│ Work tree dir: /home/marat/.werf/local_cache/git_worktrees/9/local/5099c8a4a567d60d44685d73b0054912613f26fe4d8e ↵
│ 038ae15fadd038250c32/worktree
│ Commit: b5881ca5e4e75efbbf0358103f52496c5816bc3d
│ ┌ Sync submodules in work tree "/home/marat/.werf/local_cache/git_worktrees/9/local/5099c8a4a567d60d44685d73b ...
│ └ Sync submodules in work tree "/home/marat/.werf/local_cache/git_worktrees/9/local/5099c8a4a5 ... (0.02 seconds)
│
│ ┌ Update submodules in work tree "/home/marat/.werf/local_cache/git_worktrees/9/local/5099c8a4a567d60d44685d7 ...
│ └ Update submodules in work tree "/home/marat/.werf/local_cache/git_worktrees/9/local/5099c8a4 ... (0.02 seconds)
└ Switch work tree /home/marat/.werf/local_cache/git_worktrees/9/local/5099c8a4a567d60d44685d73b ... (0.35 seconds)

Running ssh agent on unix sock: /tmp/werf-ssh-agent/99b19f26-1583-4fd5-9dd0-e10f49673d57
Added private key /home/marat/.ssh/id_rsa to ssh agent /tmp/werf-ssh-agent/99b19f26-1583-4fd5-9dd0-e10f49673d57
Added private key /home/marat/.ssh/id_dsa to ssh agent /tmp/werf-ssh-agent/99b19f26-1583-4fd5-9dd0-e10f49673d57
Using werf config render file: /tmp/werf-config-render-2985024122

┌ Determining of stages
│ ┌ ⛵ image backend
│ └ ⛵ image backend (0.00 seconds) FAILED
└ Determining of stages (0.00 seconds) FAILED

Running time 308.89 seconds

Note that worktree switch is fast because this is not the first run and worktree is already up-to-date. But still, werf takes 5 minutes to do nothing.
All running time is dominated by git -c core.autocrlf=false -c gc.auto=0 --work-tree /home/marat/example add --dry-run --ignore-missing --pathspec-from-file=- --pathspec-file-nul command.
Expected result
Only the first werf build run is slow because it needs to create a worktree. Subsequent runs on the same commit are expected to be fast.
Additional information
The root cause lies in checkNewChangesInSourceWorktreeDir function. It forces git to read whole working tree from disk, including git-lfs objects. In my case, it involves reading 30GB of data. I believe, checkNewChangesInSourceWorktreeDir needs to be rewritten using some more light-weight approach (like git status) that would not involve reading everything.
I haven't tested, but possibly addNewChangesInServiceWorktreeDir function in the same file also shows suboptimal performance.

Git operations that werf runs in dev mode might take a lot of time with Git LFS files.
As a workaround, you can ignore Git LFS files ( .gitattributes ) in dev mode with --dev-ignore (WERF_DEV_IGNORE) option, e.g.:
werf render --dev --dev-ignore='*.pdf' --dev-ignore='*.fdx'


Fix test condition for short

This test always fails.
Since tinyurl may returns different URL by time, use pattern instead.
Pull Request Label:

[x] Bug
[ ] New feature
[ ] Enhancement
[ ] New component
[ ] Typo

Pull Request Checklist:

[x] Have you followed the guidelines for contributing?
[x] Have you checked that there aren't other open pull requests for the same fix or component?
[x] Have you ran the tests locally with bats tests?

Looks good, thanks for this. Lots of the existing tests need to be fixed for stability 😄

Lots of the existing tests need to be fixed
Yep! It bothers. I may take some time to check the rest of them, but cannot promise to fix them all.


Revert "[sil-serializer] Do not use RPOT order for serializing SIL basic blocks

What's in this pull request?

Resolved bug number: (SR-)

Before merging this pull request to apple/swift repository:

[x] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    All supported platforms     | @swift-ci Please smoke test and merge
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    All supported platforms     | @swift-ci Please test and merge
    OS X platform               | @swift-ci Please test OS X platform
    OS X platform               | @swift-ci Please benchmark
    Linux platform              | @swift-ci Please test Linux platform

Lint Testing
    Language     | Comment
    ------------ | -------------
    Python       | @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

This reverts commit 2f9ee20df2f7170dfdb0c13deaa4a5107c62c564.
It broke some of the stdlib serialization tests.
rdar://problem/27404044

@swift-ci Please smoke test

OK. Smoke tests pass. Let's merge and see if this makes the bots green again.

Thanks!


Added example for color usage

Hi,
I was in trouble because there was no way to write how to use colored output.
So, I added the usage of colored output based on the pointed out earlier received.

Thank you for your replying.
I make the code concise as you pointed out and remove some unnecessary lines.


refactors static table iterable and expressions registration

iterables and expressions are now registered by a new
StaticTableDefinition class. this centralizes the registration and makes
it possible to access iterables (e.g. to register filters)
also expression definition is now done on the concrete TableInfo classes

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@edaeb89). Click here to learn what that means.
The diff coverage is 93.73%.

@@            Coverage Diff            @@
##             master    #5920   +/-   ##
=========================================
  Coverage          ?   82.98%
  Complexity        ?    12239
=========================================
  Files             ?     1423
  Lines             ?    46466
  Branches          ?     5700
=========================================
  Hits              ?    38560
  Misses            ?     5231
  Partials          ?     2675

Impacted Files
Coverage Δ
Complexity Δ

...src/main/java/io/crate/operation/InputFactory.java
96.61% <ø> (ø)
5 <0> (?)

...eration/collect/sources/CollectSourceResolver.java
76.92% <ø> (ø)
6 <0> (?)

...main/java/io/crate/action/job/ContextPreparer.java
89.64% <ø> (ø)
18 <0> (?)

...ate/metadata/information/InformationTableInfo.java
100% <ø> (ø)
4 <0> (?)

.../io/crate/metadata/sys/SysPrivilegesTableInfo.java
97.87% <ø> (ø)
15 <0> (?)

...io/crate/executor/transport/TransportExecutor.java
97.19% <ø> (ø)
6 <0> (?)

...rate/operation/collect/ShardCollectorProvider.java
80.55% <0%> (ø)
8 <0> (?)

...erence/sys/node/NodeStatsThreadPoolExpression.java
100% <100%> (ø)
2 <1> (?)

.../reference/sys/node/NodeThreadPoolsExpression.java
92.3% <100%> (ø)
4 <1> (?)

...reference/sys/node/NodeProcessStatsExpression.java
66.66% <100%> (ø)
1 <1> (?)

... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edaeb89...14fe336. Read the comment docs.


Bugsnag sends all reports in store regardless of releaseStage settings

Description
If I have reports in the Bugsnag store (~/Library/Caches/KSCrashReports/) that were generated during Unit Testing and not sent due to releaseStage and notifyReleaseStage not matching up the next time I run the app where they do match up, it will send all the reports that are left in the store. Even if they have a releaseStage set on them that does NOT match the current notifyReleaseStage setting.
Issue
Reports are generated during unit testing with a releaseStage setting of "testing" and notifyReleaseStage setting of [ "development", "production" ]. The next time I run my app with the releaseStage set to "development" (or "production") it sends ALL the reports that are sitting in the store (all of which have a releaseStage of "testing", seen in the report files.) Note the reports are properly NOT sent when running unit tests with releaseStage set to "testing", but the files are created and written to the store. The backlog of reports are all sent the next time you run the app with a releaseStage that is valid for sending.
Environment
Library versions:

Bugsnag version bugsnag-cocoa-5.22.4
CocoaPods version (if any) (pod -v): N/A
Carthage version (if any): N/A
iOS/tvOS/macOS version(s) macOS 10.14.6
debug mode or production?: Debug
How are you initializing Bugsnag? Can you share a snippet of your
AppDelegate where Bugsnag is configured?

import Bugsnag

// Normal initialization
        let bugSnagConfig = BugsnagConfiguration()
        bugSnagConfig.apiKey = Constants.BugSnagKey
        bugSnagConfig.notifyReleaseStages = [ "development", "production" ]
        // tried to do this as a way to circumvent the described behavior, but it doesn't work.
        bugSnagConfig.add(beforeSend: { (rawData, report) -> Bool in
            // note this doesn't work because releaseStage is always nil on the report object....
            if(report.releaseStage == "testing") {
                return false
            }

            return true
        })

        Bugsnag.start(with: bugSnagConfig)

// In unit tests' setUp() method
Bugsnag.configuration()?.releaseStage = "testing"

Error messages:
None

@dwmatteson
That does sound like it may be a bug. We'll investigate and confirm whether this needs a fix or whether there's a different way to configure this that works.

Fixed in v5.22.6


Add missing attribute to project push rules

The commit_committer_name_check was missing from the project push rules.  Also added tests for the project push rules.

@svanharmelen This is ready for your review!


Addition of a new member

Please add me as a member 👍

@coderpradp  Thanks for the PR. Merged. :+1:


"Pause" sending of messages

Hi,
I have the usecase that some informations (eg. UserName) are not directly available after startup, but getting fetched after bodyloaded. However, appInsights should start asap on the page to be able to record every action/requests done already during pageload.
Problem is, that currently the first messages are sent to appInsights without the informations (eg. Username) as they were not available at that point.
What I want to ask is, if there is the possibility to somehow let the appInsights engine run, so that it can record everything, but hold back the sending of the messages to the server, until a specific event occurs (in my case all of the informations are available), eg. through a promise.
Something like the opposite of the "flush" command, if you know what I mean

Just to clarify, it sounds like your looking not just to "pause" sending of messages but also to wait until some specific point in time to "post process" all recorded/reported events so you can update them with in this case user details... Am I following the request correctly?
We have a feature planning to allow pausing / resuming the sending of event, however, this is really caching and batching previously reported events -- there is (currently) no option to re-decorate the events as this can and could lead to reporting incorrect data (from a timeline perspective at least)


moved pagination into results UL for fomatting

Moved Pagination into Results UL and appended as last LI so that it is always displayed at the end of the results page

much better :) waiting for travis

so now that everything works again can we merge this potentially?

@lukecoy travis should pass now that react is installing correctly again

oh okay we'll see if that NPM issue resolved itself


Broadcast order updates

@komizutama not done, but this is WIP on real time updating for orders, can make sureit doesn't conflict with anything you're touching etc... next step is to just add a handler to take the html being broacast and add to page if user is on the order management page.

This has been incorporated into #119 for better or worse as that's our working integration branch for production/user testing, will merge to master as soon as tests pass!  #helpwanted


RISC-V Matrix Extension Specification 0.6 can not build

Commit db17dced251e2a5d78ff5fa7c50b6f72b7bfc6da  delete the content under spec/ (and leave it unbuildable, missing header.adoc).
README.md say this:

Matrix Extension Documents
This project is built using AsciiDoctor (Ruby). The repository has been setup to build the PDF on checkin using GitHub actions. Workflow dependencies are located in the dependencies directory.
[...]
RISC-V Matrix Extension Specification is kept in ./spec.
User guide and reference manual for RISC-V Matrix Extension tools are kept in ./doc.
The final documents form of PDF can be generated using the make command under corresponding folder. The generation method of each document is as follows.

Folder
Command
Documents

spec
make
RISC-V Matrix Extension specification

[...]

Commit db17dce delete the content under spec/ (and leave it unbuildable, missing header.adoc).
README.md say this:

Matrix Extension Documents
This project is built using AsciiDoctor (Ruby). The repository has been setup to build the PDF on checkin using GitHub actions. Workflow dependencies are located in the dependencies directory.
[...]
RISC-V Matrix Extension Specification is kept in ./spec.
User guide and reference manual for RISC-V Matrix Extension tools are kept in ./doc.
The final documents form of PDF can be generated using the make command under corresponding folder. The generation method of each document is as follows.
Folder
Command
Documents
spec
make
RISC-V Matrix Extension specification
[...]

Sorry fot the mistake. The adoc files are uploaded, and you can use "make all" to generate the spec.


Support different prompting templates

Thank you for Amica, I'm having a lot of fun with it!
I tried using the yi-34B models with llama.cpp with it, and generally it works, but the results aren't optimal. For example, the reply always ends with "<|im_end|>" which ends up visible in the conversation.
It would be great to have a way to not just change the system prompt, but to change the prompting template altogether. Here's ChatML, which Yi is trained to use:
<|im_start|>system
{system_message}<|im_end|>
<|im_start|>user
{prompt}<|im_end|>
<|im_start|>assistant

I would agree with a need for this functionality. On several models, Amica tends to trend toward ending all responses with "agent: {... something they thin the user would say}" instead of waiting for the next response.

src/utils/buildPrompt.ts --- 1/1 --- TypeScript
 6   for (let m of messages) {                                                                  6   for (let m of messages) {
 7     switch(m.role) {                                                                         7     switch(m.role) {
 8       case 'system':                                                                         8       case 'system':
 9         prompt += config("system_prompt")+"\n\n";                                            9         prompt += "<|im_start|>system\n" + config("system_prompt")+"<|im_end|>\n";
10         break;                                                                              10         break;
11       case 'user':                                                                          11       case 'user':
12         prompt += `User: ${m.content}\n`;                                                   12         prompt += `<|im_start|>user\n${m.content}<|im_end|>\n`;
13         break;                                                                              13         break;
14       case 'assistant':                                                                     14       case 'assistant':
15         prompt += `${config("name")}: ${m.content}\n`;                                      15         prompt += `<|im_start|>assistant\n${m.content}\n<|im_end|>\n`;
16         break;                                                                              16         break;
17     }                                                                                17     }
18   }                                                                                18   }
19   prompt += `${config('name')}:`;                                                           19   prompt += `<|im_start|>assistant\n`;
20   return prompt;                                                                            20   return prompt;
21 }                                                                                21 }
22

here's a diff that switches to the chatml format, just for other users who might find this issue

Arbius has a $150 AIUS bounty for this issue!
Brief: Fix/Complete Issue, suggest adding it as expandable under system prompt page.
Please read carefully:
To begin work on a bounty, reply by saying “I claim this bounty” - you will have 48 hours to submit your PR before someone else may attempt to claim this bounty.
To complete the bounty, within 48 hours of claiming, reply with a link to your PR referencing this issue and an Ethereum address. You must comply with reviewers comments and have the PR merged to receive the bounty reward. Please be sure to focus on quality submissions to minimize the amount of time reviewers must take.


Menu (FlatList) viewport doesn't follow the selected item

When there are more items than the Menu/FlatList shows it doesn't follow the selectedItem.
You can see here: https://www.youtube.com/watch?v=xPhhNNhfVkM
I changed my menu config form <C-N>/<C-P> to <C-J>/<C-K>.
I'd like to give it a shot at fixing it.

Here is what I believe should be the behavior for the menu
List shorter than view:
Current:

Expected? (This is how VS Code menu works)

List is longer than view
Current

Expected

FYI: I'm working on this as part of the menu renovation project.


Upgrade debug-dependency to 4.3.4

fixes #2513

error in tests:
1) no-internal-modules invalid import get from "debug/node":

      AssertionError [ERR_ASSERTION] [ERR_ASSERTION]: Should have 1 error but had 0: []
      + expected - actual

      -0
      +1

      at testInvalidTemplate (node_modules/eslint/lib/rule-tester/rule-tester.js:773:24)
      at Context.<anonymous> (node_modules/eslint/lib/rule-tester/rule-tester.js:997:29)
      at processImmediate (node:internal/timers:471:21)

  2) no-internal-modules invalid export {get} from "debug/node":

      AssertionError [ERR_ASSERTION] [ERR_ASSERTION]: Should have 1 error but had 0: []
      + expected - actual

      -0
      +1

      at testInvalidTemplate (node_modules/eslint/lib/rule-tester/rule-tester.js:773:24)
      at Context.<anonymous> (node_modules/eslint/lib/rule-tester/rule-tester.js:997:29)
      at processImmediate (node:internal/timers:471:21)

i'm wondering if it is not that the updated dependency is no more breaking the rule and the test must be updated to use another package to test the rule. is it possible?

requires node 6

Security support of Node 6 ended 3 years ago on the 30 Apr 2019 https://endoflife.date/nodejs
I wasn't imagining that it could be a constraint.
(but maybe supported by some companies and not the community?)
Are there documents on the policy for node version upgrade related to this project? (so that I can see how far we are from upgrading the minimal node version)

We support down to eslint 2, and every version of node that implies. Platform support is, as always, irrelevant. We likely will not ever upgrade the minimal node version.

See also #2447


[PLUGIN REQUEST] CodeSnap.nvim

Field
Description

Plugin
codesnap.nvim

Homepage
codesnap

Nixpkgs
false

Extra Information
From the repo's README:

📸 Snapshot plugin with rich features that can make pretty code snapshots for Neovim

Made a PR usptream: https://github.com/NixOS/nixpkgs/pull/321030


Implementing FaceID iphoneX like feature in Android using this plugin

Hi,
Is there any way to implement the FaceID like feature in iPhoneX in my android device using this plugin. I mean i want to use the Trusted Face feature for my android application using Cordova. Please do tell . Any help will be appreciated along with ideas for Cordova.

Could not find that an API exists to utilize Trusted Face feature.  If one does exist it would be better to integrate this feature in a separate plugin.  Closing as this does not pertain to this plugin.


400 Bad Request - The plain HTTP request was sent to HTTPS port

I followed this guide https://developers.cloudflare.com/argo-tunnel/reference/kubernetes/
But in my case I prefer to use http2 for performance (https://imagekit.io/demo/http2-vs-http1) and security (mitm) reasons...
I see error 400 Bad Request - The plain HTTP request was sent to HTTPS port
I use Cloudflare Origin Certificates for my services...
Also I enable Automatic HTTPS Rewrites in Cloudflare panel.
I do not expect to see any plain http requests here... How to fix it?..

Hi @lorddaedra , could you solve your problem? The same thing is happening to me, any idea how to solve it?
Thanks

I've also run into this issue - anyone found a reason why or how to solve it?

@skilledboy I am sorry to have kept you waiting for so long.
@ here
I do not use cloudflare-ingress-controller anymore. (I use Google Cloud Run service for most of my projects...)

thanks @lorddaedra , I am particularly a fan of Google Cloud Run, but unfortunately it is not useful for me to expose my services from my raspberry pi 4 cluster. For this reason I use https://developers.cloudflare.com/argo-tunnel/reference/kubernetes
I leave you an image of how I mix everything (Cloudflare argo tunnel, kong gateway, etc ...).
Sorry, my english is very bad

We are currently more focused on improving the cloudflared client itself, leaving this ingress controller deprecated. You can read more here: https://github.com/cloudflare/cloudflare-ingress-controller/issues/172#issuecomment-541230988


Try HTMX for song submission

Using traditional forms, when submitting a song name a complete refresh of the page occurs. This causes the rappers to change. We don't want this.
To solve this we can either use AJAX, Fetch API or HTMX. Let's try HTMX.
This is a child of #6.

This may help in loading and swapping only part of a page:
HTMX is a library that simplifies working with AJAX requests and updates in web applications. To use HTMX to load only a part of a page when a user submits a form in Django, you can follow these steps:

Install HTMX: First, make sure you have HTMX installed in your Django project. You can use a package manager like pip to install it:
pip install htmx

Include HTMX in Your Template: In your HTML template, include HTMX by adding the following line in the <head> section:
<script<EMAIL_ADDRESS>

Update Your Form: Add hx-post and hx-target attributes to your form element. hx-post specifies the URL to which the form should be submitted, and hx-target specifies the HTML element where the response should be inserted. You can also add an hx-swap attribute to specify how the content should be inserted (e.g., outerHTML, innerHTML, etc.).
<form id="myForm" method="post" hx-post="{% url 'my_form_submission_view' %}" hx-target="#partial-view" hx-swap="outerHTML">
    {% csrf_token %}
    <!-- Form fields go here -->
    <input type="submit" value="Submit">
</form>

Create a Django View: Create a Django view that handles the form submission and returns the updated content. This view should render the template fragment you want to update.
from django.shortcuts import render
from django.template.loader import render_to_string
from django.http import HttpResponse

def my_form_submission_view(request):
    if request.method == 'POST':
        # Process form data
        # ...

        # Render the template fragment
        partial_html = render_to_string('partial_template.html', context)

        return HttpResponse(partial_html)

    # Handle GET requests here
    # ...

Create a Template Fragment: Create a template fragment (e.g., partial_template.html) that contains the HTML you want to update when the form is submitted.

JavaScript: HTMX will automatically handle the AJAX submission and response handling for you. There's no need to write custom JavaScript for this purpose.

With these steps, when the user submits the form, HTMX will send an AJAX request to the specified URL (hx-post), and the response will replace the content of the element specified by hx-target, using the specified method defined in hx-swap. This way, you can update only a part of the page without a full page refresh.


Fix sample splitting and cross fitting for doubly robust estimation

Need to go back and look at Kennedy (2022) again. The algorithm he gives is kind of ambiguous and confusing about what split to train on and what split to predict on.

Fixed with commit b84bb08.


Remove failure logs thats cluttering the e2e test logs.

The below logs make it look like the e2e tests have errors, these need to be removed till we have log levels for the tests:
2017/06/11 18:33:34 Failed to invoke command [docker volume  create --driver=vsphere  --name= 8F2qNfHK5a84jjJkwzDkh9h2fhfUVuS9jZ8uVbhV3vC5AWX39IVUWSP2NcHciWvqZTa2N95RxRTZHWUsaD6HEdz0ThbXfQ6pYSQ3n]: exit status 1
2017/06/11 18:33:35 Failed to invoke command [docker volume  create --driver=vsphere  --name= Volume_volume_4swm71tvdge@invalidDatastore]: exit status 1
2017/06/11 18:33:35 Failed to invoke command [docker volume  create --driver=vsphere  --name= Volume-000000]: exit status 1

Agree.
This print is from the ssh util in case where the command fails
	out, err := exec.Command("/usr/bin/ssh", append(sshIdentity, "root@"+ip, cmd)...).CombinedOutput()
	if err != nil {
		log.Printf("Failed to invoke command [%s]: %v", cmd, err)
	}

But the command actually fails in the the negative test cases :-)).
I think we can silence this print here. As far as I recall, all our tests have Commentf in case when assertion fails which prints the output of the failed command.
What do you think?

Agree, especially when debugging a CI failure it keeps showing up as failures and misleading.


Interferes with keyboard shortcut for paste

If I try to do ctrl+v, I normally release ctrl prior to releasing v. The result is that the vote gets triggered incorrectly.
The vote trigger must only proceed if the non-repeat keydown associated with it doesn’t have any modifiers pressed.

This is actually more complicated. It needs to detect and prevent action if the key would have the effect of causing input.
I am trying out if I can detect whether or not beforeinput runs.


MM-42679 : Remove all occurence of getAllCustomEmojis action

Summary
Removed pre-fetching of all custom emojis on initial load.
Ticket Link
https://mattermost.atlassian.net/browse/MM-42679
Related Pull Requests
N/A
Screenshots
N/A
Release Note

Removed preloading of all custom emojis on app initial load.

Regarding the release note, we could probably leave it blank since we haven't actually pre-loaded all custom emojis for years now


fix bad participants

we were filtering out the list but using the unfiltered list which made the results mismatch
@keybase/react-hackers

The commits 64cb2dd3a530...14a614a2a8ed introduce visual changes on linux. :mag_right: 9 new, 11 changed

Added: Text_Message-pending_Not_Following

Added: Text_Message-pending_Following

Added: Text_Message-pending_Broken

Added: Text_Message-failed_Not_Following

Added: Text_Message-failed_Following

Added: Text_Message-failed_Broken

Added: Chat_Banner-Broken_Tracker_3

Added: Chat_Banner-Broken_Tracker_2 (view)
Added: Chat_Banner-Broken_Tracker_1 (view)
Changed: Text_Message-sent_Not_Following (before) (after) (diff)
Changed: Text_Message-sent_Following (before) (after) (diff)
Changed: Text_Message-sent_Broken (before) (after) (diff)
Changed: Text_Message-from_revoked_device (before) (after) (diff)
Changed: Popup-You_Revoked (before) (after) (diff)
Changed: Popup-Following_Revoked (before) (after) (diff)
Changed: Chat_Side_Panel-Normal (before) (after) (diff)
Changed: Chat_Side_Panel-Empty (before) (after) (diff)
Changed: Chat_Banner-Invite (before) (after) (diff)
Changed: Chat_Banner-Info (before) (after) (diff)
Changed: Chat_Banner-Error (before) (after) (diff)

@keybase/react-hackers bump


only setFont if useful

The setFont call is CPU expensive so it should be avoided.
There are cases when there is no need to setFont:

the page does not have any characters using the font

for each font keep a list of chars using the font

setFont has already been called and no new characters have been added

record that setFont has been called
record if new characters have been added

fixed


WIP: Various fixes for release-3.72

Description
WIP.
Picked so far
d955417b1f [ROX-13500] Perform type check for V1 CronJob (#3787)
eb1b45f04c Start using the batch/v1 api for CronJobs (#3854)
5e1595c454 ROX-14485: update monitoring psp (#4655)
f5baf265f9 ROX-14427: set PSPs for CI to false for k8s version 1.25 and higher (#4488)
42719ea90b ROX-12856: roxctl: Make sure that PSPs are not rendered for deployment bundles (#3230)
Checklist

[ ] Investigated and inspected CI test results

Testing Performed
CI is sufficient

/test openshift-newest-operator-e2e-tests
/test openshift-newest-qa-e2e-tests
/test openshift-oldest-operator-e2e-tests
/test openshift-oldest-qa-e2e-tests
/test openshift-penult-operator-e2e-tests
/test openshift-penultimate-qa-e2e-tests

/test openshift-newest-operator-e2e-tests
/test openshift-newest-qa-e2e-tests
/test openshift-oldest-operator-e2e-tests
/test openshift-oldest-qa-e2e-tests
/test openshift-penult-operator-e2e-tests
/test openshift-penultimate-qa-e2e-tests

/test openshift-penultimate-operator-e2e-tests

/test openshift-penultimate-operator-e2e-tests
/test openshift-penultimate-qa-e2e-tests


3G UMTS support?

Does this project support 3G UMTS or only GSM?

Yes, it's support 3G.

Hi,
How can I scan freq UMTS? grgsm_scanner only scan GSM

can someone answer ?


I need not only test accuracy  but test  loss also...

When i train with default setting, VEER is calculated for every 10 iteration, and I regard VEER as Validation Equal Error Rate.
thus, VEER is derived from test accuracy and it is very important measure.
But I need not only VEER but Validation Loss also to pick the best model.
How could I print Validation loss?
Thank you...

There is no 'validation loss' as such, since the train function is not run on the validation set.
To implement this function, you will need to:

Initiate data loader for the validation set
Modify train_network function to run with self.eval() mode.
Run this function without the weight updates.

Oh, I think I express improper way thus you misunderstood my purpose...
The sample code you give just train on TRAINING SET, and for every 10 epoch, calculate EER on test accuracy (VEER) and print it.

I think my answer still remains the same. You will need to run the train function without the weight update every 10 epochs. Currently the script does not compute the validation loss.

Oh, thank you for your answer! I understand it!


Fail the installation script if something went wrong

@yoanisgil This should fix the zero exit status on failed builds.

I'm testing this right now.

Seems to be working this time.
FYI: Building v1.8.0 is broken but well this time the build fails ;)


Only accept Vert.x style url

See #333
A draft to check that everything works. I still need to update the docs and add some bits.

Not sure this is the kind of thing we should do in a point release.

Yes, I'm not sure either. But I wanted to see the impact on the code base.


util: gen_effect_id.py missing some useful effect

Seems thatStormbite: '4b1' and CausticBite: '4b0' is missing in effect_id.js
Maybe it is because there are two different Stormbite/CausticBite effect share a same name?

Yeah, that's exactly it.  It seems like from #1834 that there may be fields that say whether something is pvp or pve, so that might help to eliminate the pvp abilities that are causing conflicts.

I don't see any fields for this to make this determination easier.  The two stormbites effects look impossible to differentiate.
I asked in the XIVAPI discord but didn't get a good answer here.  It seems like there's nothing in the game data, and so in the future if these are missing, we'll just need to add them manually, sorry!
https://github.com/xivanalysis/xivanalysis/tree/master/src/data/STATUSES/root was also listed as a place where other people are trying to solve the same problem.  However, since that's not game data, I think it'd be better to just handle this inside of cactbot directly with our own set of ids.
I'm going to close this, as I don't think there's any automatic answers here, sorry.


Update vulcan, vulcan-generic, ... to 1.4.1

Updates

com.github.fd4s:vulcan
com.github.fd4s:vulcan-generic
com.github.fd4s:vulcan-refined

from 1.2.0 to 1.4.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.github.fd4s" } ]

labels: library-update, semver-minor

Superseded by #631.


Node client unable to establish connection to server hub

I am getting the following error message when trying to connect to a hub:
Error: Failed to start the connection: Error: Unable to initialize any of the available transports.
I am using the following packages:
Server is a .net core API:

Microsoft.AspNetCore.All - Version="2.0.5"

Microsoft.AspNetCore.SignalR - Version="1.0.0-preview1-final"

Client is an Angular 6 cli app:

@aspnet/signalr - version "^1.0.0-rc1-update1"

I am currently developing my application with VS 2017 & VS Code using IIS Express on Windows 10 (both client & server). The issue occurs on all browsers, though I am mainly using the latest stable Chrome.
Here is the client:
import { NGXLogger } from 'ngx-logger';
import { Component, OnInit, OnDestroy } from '@angular/core';
import { HubConnection } from '@aspnet/signalr';
import { Router } from '@angular/router';
import * as signalR from '@aspnet/signalr';

@Component({
  selector: 'app-operation-list',
  templateUrl: './operation-list.component.html',
  styleUrls: ['./operation-list.component.scss']
})
export class OperationListComponent implements OnInit, OnDestroy {

  private hub: HubConnection;
  private data: Operation[];

  constructor(private progressBarService: ProgressBarService,
    private logger: NGXLogger,
    private authService: AuthenticationService,
    private router: Router) {

    this.data = [];
    this.progressBarService.show();

    const user = this.authService.getCurrentUser();

    this.hub = new signalR.HubConnectionBuilder()
      .configureLogging(signalR.LogLevel.Trace)
      .withUrl(`${environment.apiUrl}emergency-operations?token=${user.token}`)
      .build();

    this.hub.on('GetOperations', (data: Operation[]) => {
      this.logger.trace(`Retrieved ${data.length} operations`);
      this.data = data;
      this.progressBarService.hide();
    });

  }

  ngOnInit() {
    this.hub.start()
      .then(() => {
        this.logger.trace('Hub started');
        this.progressBarService.show();
        this.hub.invoke('GetOperations');
      })
      .catch((e) => {
        this.logger.error(`An error occurred while connecting to operations hub. Details ${e}`);
        this.notificationService.openSnackBar('Error while establishing connection');
        this.progressBarService.hide();
      });

  }

  ngOnDestroy() {
    this.hub.stop()
      .then(() => {
        this.logger.trace('Hub stopped.');
      });
  }

Full trace logs from Chrome dev console:
Angular is running in the development mode. Call enableProdMode() to enable the production mode.
Utils.js:192 Debug: Starting HubConnection.
Utils.js:192 Debug: Starting connection with transfer format 'Text'.
Utils.js:192 Debug: Sending negotiation request: http://localhost:6300/emergency-operations/negotiate?token=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiJtYXZlcmlsbCIsImp0aSI6IjMyNDExMDc2LTdiNjMtNGJmMy04ZWYxLTczMjRjMWYxNGQ2NSIsInVuaXF1ZV9uYW1lIjoibWF2ZXJpbGwiLCJleHAiOjE1MjYxNDU2NDAsImlzcyI6ImxvY2FsaG9zdCIsImF1ZCI6InVzZXJzIn0.9OP1eQ6ioZAVbw4tTtrPKgJFYqV8xHl9saw27DcOboY
3Utils.js:192 Debug: Skipping transport 'undefined' because it is not supported by this client.
Utils.js:182 Error: Failed to start the connection: Error: Unable to initialize any of the available transports.

I believe the problem is that I am not specifying the transport type. Notice the log above:
Debug: Skipping transport 'undefined' because it is not supported by this client.
I recently updated the client to the latest version from npm and the library seems to have changed, it appears that the HubConnectionBuilder is used instead of the HubConnection class, whose constructor is now private.
I was previously able to do the following to specify the transport type:
const options = {
      transport: TransportType.WebSockets
    };

    this.hub = new HubConnection(`${environment.apiUrl}emergency-operations?token=${user.token}`, options);

Since the HubConnection class constructor is now private and I have to use the builder to create the connection, how do I specify the transport type?

You're using mismatching versions, if you want to use rc1 of the server you need to use rc1 of the client

Thank you, updating the server solved the problem.


add tc api

This PR adds the low level tc api as described in https://github.com/libbpf/libbpf/commit/d71ff87a2dd7b92787719aab233767e9c74fbd48

Do I understand correctly that this allows users to attach bpf programs to tc actions, where tc actions are when tc filters are modified in some ways?
I.e.) User adds a tc filter for slowing down egress on a particular interface. The bpf program would have access to information about that action.


Fix compatibility with microlens 0.4.10

Fixes #163

Thank you for the patch! I decided to go with a slightly different approach in 8f32f8ea4c4b70b31b15cbe21ab9890108cd4765, however.


Improve the gatsby remark shiki tests

Adds tests which uses fixtures to generate both HTML and the twoslash as JSON
This is needed because the 2-3 examples in the package work, but there's a bunch of cases where the inline lsp results aren't right in the tsconfig ref.

Tests pass


[Question] Is that WordPress Plugin abandoned?

Checking WordPress.org plugins page I can see that the last update was 2yrs ago.
Also @xDae Github's profile seems to be inactive

I meant that the react plyr plugin is not abandoned as @deblynprado suggests :)

I've mentioned the wrong guy, sorry.
It wasn't my intention request anything.
I just tried to use this https://wordpress.org/plugins/plyr/ and saw that last update was 2 years ago. So I thought to clone and maintain that working, that's why my question.
Thank you for your time and efforts in this project, it's amazing! :D

Closing in favour of #1127


[CARBONDATA-4078] Add external segment and query with index server fails

Why is this PR needed?
Query after adding an external segment to carbon table tries to getSplits from Index server and throws an exception as it cannot read the external(orc/parquet) file format.
When the fallback mode is disabled, it throws an exception and fails.
What changes were proposed in this PR?
To avoid the exception, filtered only valid carbon segments to cache in index server.
Does this PR introduce any user interface change?

No

Is any new testcase added?

No

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12444/job/ApacheCarbonPRBuilder2.3/5101/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12444/job/ApacheCarbon_PR_Builder_2.4.5/3340/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12444/job/ApacheCarbonPRBuilder2.3/5145/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12444/job/ApacheCarbon_PR_Builder_2.4.5/3383/

@ShreelekhyaG Check and handle in BroadCastSIFilterPushJoin

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12444/job/ApacheCarbonPRBuilder2.3/5160/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12444/job/ApacheCarbon_PR_Builder_2.4.5/3398/

@ShreelekhyaG Check and handle in BroadCastSIFilterPushJoin

Tested queries in cluster with SI, no issues.

retest this please

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12444/job/ApacheCarbonPRBuilder2.3/5177/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12444/job/ApacheCarbon_PR_Builder_2.4.5/3415/

LGTM


Newly initialized object with non-optional properties are not initialized

Description:
Assume that a class Foo exists with no constructor or default assignments, with a number of member fields or properties, that are not optional (they lack the ? token after the type declaration).  These non-optional properties are not set up with default values.  If referenced at runtime, the code creates an Undefined Reference JavaScript exception.
TypeScript Version:  2.1.5
Code
// A *self-contained* demonstration of the problem follows...
export class Foo {
    public name: string;
    public someThing: Bar;
}

export class Bar {
    public isActive: boolean;
}

let foo : Foo = new Foo();

// foo's contents are { __proto__: {...}}, no fields or properties exist on it at this point.
// foo.someThing is undefined!
if(foo.someThing.isActive === true)
{
    // JS Undefined reference exception here when executed
    // When transpiling, TypeScript does not catch that foo.someThing is undefined
}

Expected behavior:
There are two possibilities for what is expected of an instantiation to do, in regards to the TS transpiler:

Non-optional fields/properties have default values generated by the TypeScript transpiler.  This is how C#, Java, and other languages that TypeScript syntactically are based on, actually work.
TypeScript warns you of a possibly undefined field as a transpiler warning or error.  This is helps the end-user prevent a JavaScript exception that the TS compiler should be helping you avoid.  This warning or error is not raised if the type is appended with the optional modifer (in the example above, 'public someThing: Bar?')

Actual behavior:

The above code compiles without issue, when it will cause the end-user to encounter an Undefined Reference exception.
The above code as-is is not type-safe even with explicit non-'any' types, as the value of the variables is undefined, and not a default value of the non-optional type that was defined.

#8476

@RyanCavanaugh - even if Expected Result 1 isn't feasible, it would be helpful to know upon compilation that what is trying to be done in the code snippet given is a no-no.  This is easily worked around, but breaks continuity with other languages (or, is a little too continuous with JavaScript.)
export class Foo {
    public name: string = '';
    public someThing: Bar = new Bar();
}

export class Bar {
    public isActive: boolean = true;
}

// ...Rest of example code, should now work...

Please leave comments in the linked bug, or clarify if you think this isn't a duplicate of the other

I've clarified the Issue title to note the primary point of divergence from the issue you linked, which is that you can do this sort of thing, but get no warnings.

There's no way we could initialize a satisfactory value for an arbitrary type (even if we wanted to). For example number | string, or a class type with no parameterless constructor, or a generic type all lack a plausible initializer. This also directly conflicts with our stated design goals.

@RyanCavanaugh - I don't find that argument entirely accurate, as languages like C# and Java don't implicitly instantiate child complex types, but do implicity instantiate primitives on construction, which is what I'm talking about - bringing TypeScript in to parity with the languages it's aping.  In C# if you have the following code:
public class Foo
{
    public string Name;
    public Bar SomeThing;
}

public class Bar
{
    public bool IsActive;
}

// ...Boilerplate...
public static void Main()
{
    var foo = new Foo();

    if(string.IsNullOrEmpty(foo.name)
        Console.WriteLine("foo has no name!");

    if(foo.Bar.IsActive)
        Console.WriteLine("This throws an exception because Bar isn't initialized!");
}

...The first Console.WriteLine will be presented, as string primitives initialize as a string with length of zero (or, to use C# parliance, 'string.Empty'), but the program given above will throw an exception due to Bar not being initialized.
As noted in my original bug report above, this is what I would count as a valid expected behavior as it's in-line with how the languages that TypeScript's syntax is modeled off of, behaves.

Just to clarify: TypeScript is not based on C#. It's JavaScript with static typing. Classes are an ES6 feature which originated in the abandoned ES4 spec; these classes did not have automatic member initialization either.


Cranelift: Module data apis should allow specifying the object file section

This fixes #1640.
What it does is two things:

Expose a new api on the data context type to set the section of the current data item
Emit it in the Object backend

I have no idea how to write a testcase for this or if it's meaningful at all.
I don't know who can review this.

Please add an assertion to cranelift-faerie that section is None. You don't have to implement support, as it has been deprecated.

Please add an assertion to cranelift-faerie that section is None. You don't have to implement support, as it has been deprecated.

Looking at the build failure, should I do something for JIT too ?

For simplejit I think an assertion would be fine too.

pushed a fix for fmt & simplejit. Never did rust before today so sorry for the long number of commits.

I think I addressed all your concerns now.

Thanks! Looks great. One last thing required to merge - can you please run cargo fmt at the root of the project to get the rustfmt CI check to pass? rustup component add rustfmt will install that command if you don't have it.

Thank you!


StatsD logging plugin add datatypes, xref to adv plugin

https://konghq.atlassian.net/browse/DOCS-1396 epic to add datatypes to plugins beyond the few template-autogenerated parameters. I'm not logging Jira subtickets because it's a lot of overhead.
This PR also is part of https://konghq.atlassian.net/browse/DOCS-1417.
Schema link:
https://github.com/Kong/kong-ee/blob/master/kong/plugins/statsd/schema.lua
Direct review link:
https://deploy-preview-2648--kongdocs.netlify.app/hub/kong-inc/statsd/

I think most of my reviews from #2647 apply here.

Thank you @murillopaula. I inc. your feedback into 2647 and after your review and approve that, will port same changes to community plugin.


Working Memory Event Notifications

Enhancement Request
Description
It would be helpful to have changes to working memory be announced to external listeners/code via an officially supported API in Clara.
Requirements

Clara should provide notifications for changes to working memory.

Notifications should be symmetrical so that both insertions and retractions would trigger the notification(s.)

Notifications should be in the form of a collection (sequence or vector of facts), possibly only one, never empty.

Example use case
Using Clara in CLJS for DOM related pattern matching. Rules/code can create DOM elements, insert them into working memory and pattern match against them. When necessary, DOM elements may be removed from working memory and, upon receiving a wm notification, removed from the DOM tree by a notification handler.
Background (from a Clara ML conversation)
kahunamoore wrote:

I am needing to run some code whenever certain fact types are retracted (either explicitly or via truth maintenance.) I was reading through the code and found the :listeners option.

What is the recommended usage for listeners? It seems the clojure defsession/mk-session macro/function passes along the options but the clojurescript versions do not AFAIK.

I can see the clara.tools.tracing/with-tracing might be just the ticket I need - is this the suggested way to do tracing, or in my case, executing some code with side-effects whenever facts are inserted/removed? If so, do you have a small example that uses this feature?

rbrush wrote:

Tracing and listeners are intended for debugging and troubleshooting rules and for truth maintenance. I don't think this is the mechanism we want to detect retractions in the long run.

One enhancement that i had considered was the ability for callers to pass an on-retract function when doing an insertion from a rule. The function would simply be called by the truth maintenance engine if and when the support for that rule is retracted.

Here is an (untested) example. If FireDetected matches, the rule triggers the alarm and inserts the corresponding fact. If FireDetected is retracted, the FireAlarm fact is retracted via truth maintenance, and the on-retract function is called to cancel the alarm.

(defrule fire-alarm
[FireDetected]
=>
(do
(println "Starting the alarm!")
(insert-facts! [(->FireAlarm)] {:on-retract (fn [facts]  (println "Stopping the alarm!"  ))})))

If this type of functionality is interesting to you, please log an issue over on Clara's github site and we can follow up on it. I don't think it will be a huge effort to make this happen.

This sort of thing probably can be built into a specialized listener. To this point I've only used listeners for debugging and tracking the history of a session, but there really isn't a reason it couldn't be expanded for other uses.
I'm thinking something like the tracing listener that keeps only the state described above would do the trick. The link to the tracing listener below is probably a good reference:
https://github.com/rbrush/clara-rules/blob/master/src/main/clojure/clara/tools/tracing.clj

Given the fix for issue #92 gives cljs users the ability to pass the :listeners option we have (most of) what is needed. Closing...


double quotes in string literal arguments get removed when calling native commands

Steps to reproduce
On macOS run
osascript -e 'display notification "FOO" with title "TITLE"'

Expected behavior
Show notification, just like in bash
Actual behavior
PS /> osascript -e 'display notification "FOO" with title "TITLE"'
21:24: execution error: The variable FOO is not defined. (-2753)
PS /> bash
bash-3.2$ osascript -e 'display notification "FOO" with title "TITLE"'
bash-3.2$

Environment data

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      6.0.0-alpha
PSEdition                      Core
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   <IP_ADDRESS>
GitCommitId                    v6.0.0-alpha.14
CLRVersion
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

The following change does work.
osascript -e 'display notification \"FOO\" with title \"TITLE\"'

Per the man page.
-e statement
       Enter one line of a script.  If -e is given, osascript will not look for a filename in the argument list.
       Multiple -e options may be given to build up a multi-line script.  Because most scripts use characters that
       are special to many shell programs (for example, AppleScript uses single and double quote marks, ``('',
       ``)'', and ``*''), the statement will have to be correctly quoted and escaped to get it past the shell
       intact.

@thezim good to know, thank you!
I still think there is an issue, because it's super unintitive for me, why I need to escape these quotes, when the whole parameter is already wrapped in the single-quoted string.
Also it related to the pillar of "making PS more compatible with existing shells to allow more commands work thru copy-paste".

@vor I agree. I would prefer your example to work too.

Invoke-AppleScript would be a nice cmdlet for macOS. Following would lead me to believe is could be done.
http://jonathanpeppers.com/Blog/xamarin-ios-under-the-hood-calling-objective-c-from-csharp
https://docs.microsoft.com/en-us/dotnet/articles/standard/native-interop

@vors This works too.
'display notification "FOO" with title "TITLE"' | osascript

Repro (using test code in our repo):
PS> cd test/tools/EchoArgs
PS> dotnet run 'a "b" c'
Arg 0 is <a b c>
PS> bash
$ dotnet run 'a "b" c'
Arg 0 is <a "b" c>

Note that the behavior is consistent with Windows, but maybe it shouldn't be.

Why is it this way on Windows?  If I recall correctly, this behavior was a major annoyance.

Correct me if I'm wrong, but isn't this a duplicate of https://github.com/PowerShell/PowerShell/issues/1995 ?
@lzybkr I think it absolutely must be consistent with Windows, but double escaping should not be necessary on any platform.

@vors Note that in the workaround on macOS, the double quotes are being escaped with ''. PowerShell doesn't treat \ as the escape character so clearly osascript is doing it's own escape processing.
@lzybkr the value of argv[0] is exactly what I'd expect it to be. Since windows CreateProcess passes arguments as a simple string, process startup code needs to break that string up into individual arguments. It does this by processing the quotes that are passed, doing quote removal for string arguments.

@BrucePay - The annoyance is that calling a process differs from calling a command:
#437 PS> function myechoargs { for($i = 0; $i -lt $args.Length; $i++) { "arg ${i}: <$($args[$i])>"}}
#438 PS> myechoargs 'a "b" c'
arg 0: <a "b" c>
#439 PS> echoargs.exe 'a "b" c'
arg 0: <a b c>

Add to this - the behavior of bash differs from windows - it is more like calling a script/function than an executable.
I don't see a perfect solution. As I see it, the incompatible goals are:

be more bash like
be less surprising
write portable PowerShell scripts
not break existing PowerShell scripts

People do find the behavior on Windows confusing.
People do find many command lines for cmd/bash and should just work in PowerShell - this is one example where it doesn't.
PowerShell Core could chose to break compatibility with Windows PowerShell to deliver on goals 1, 2, and 3.
We could make no changes, and we've delivered on 3 and 4.

@BrucePay Although Windows does only send a single Commandline to the new Process, almost every CLI-App splits this Commandline according to these rules. Therefore Powershell should build the Commandline in a way, that matches those rules instead of just sometimes adding quotes around arguments.
Almost every other modern Commandshell on windows does this:

https://www.hamiltonlabs.com/Cshell.htm (not documented)
Cygwin (see linebuf::fromargv)
Python (see list2cmdline)
Tcl (see BuildCommandLine, Comment: "N backslashes followed a quote -> insert N * 2 + 1 backslashes then a quote.")

People also expect this from Powershell. See:

"This seems like a bug to me. If I am passing the correct escaped strings to PowerShell, then PowerShell should take care of whatever escaping may be necessary for however it invokes the command."
"... and I think this is a bug Powershell doesn't escape any double quotes that appear inside the arguments."

@lzybkr I think 4. is not really a Problem, as it never really worked on Windows and even changed from time to time. For example in Powershell on Windows 10 (PSVersion: 5.1.14393.693; PSEdition: Desktop; BuildVersion: 10.0.14393.693) it's completely impossible to send a"b c to the argv[1] of the next Process via a normal call:

PS: echoargs 'a\"b c' -> Commandline: \path\to\echoargs.exe  a\"b c
PS: echoargs '"a\"b c"' -> Commandline: \path\to\echoargs.exe  ""a\"b c""

Necessary Commandline for argv[1]=a"b c: \path\to\echoargs.exe  "a\"b c"
The only option to accomplish this is via --%, but that gets really botched, if one needs to pass content from calculations or variables.

@TSlivede - I feel comfortable saying somebody depends on the current behavior.
That said, compatibility can't really be guaranteed (different runtimes amongst other big differences), so it's really a best effort.
Personally I'm in favor of the breaking change - far too many people avoid the easy way of running an external command because of issues like this.

@vors asked in https://github.com/PowerShell/PowerShell/issues/1995 if anybody wants to start an RFC process.
I wrote a draft, here it is!

Dupe of https://github.com/PowerShell/PowerShell/issues/1995


3D view doesn't refresh after upload and drape a new design

The second uploaded design and all subsequent ones don't change the 3d view what I generated at the first time on the connection. All processes are successfully completed and all tmp directories are updated normally and contained the new generated files, but the 3d view doesn't change since the first drape.
This bug isn't reproduced on demo https://garmentcode.ethz.ch/
I have installed the last version of both githubs and tuned my environment as described in Environment Setup Notes #17, but it is not help

This is the issue with browser caching files with by file name instead of the content. For now you can manually clean the page cache to view the correct 3D model
We know a workaround for it, and I will soon add it here too

Thank you for the fast reply
пн, 25 нояб. 2024 г. в 12:19, Maria Korosteleva @.***>:

This is the issue with browser caching files with by file name instead of
the content. For now you can manually clean the page cache to view the
correct 3D model
We know a workaround for it, and I will soon add it here too
—
Reply to this email directly, view it on GitHub
https://github.com/maria-korosteleva/GarmentCode/issues/29#issuecomment-2497372131,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJJCN6PFXUDCX3BN7KAFSN32CLTRTAVCNFSM6AAAAABSMSDCG6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJXGM3TEMJTGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Finally, I've pushed the fix: https://github.com/maria-korosteleva/GarmentCode/commit/e04ad9c015356aa7382f2a60eaa59735131b008a
It should work now =)

Great! Thank you!
вт, 17 дек. 2024 г. в 14:03, Maria Korosteleva @.***>:

Finally, I've pushed the fix: e04ad9c
https://github.com/maria-korosteleva/GarmentCode/commit/e04ad9c015356aa7382f2a60eaa59735131b008a
It should work now =)
—
Reply to this email directly, view it on GitHub
https://github.com/maria-korosteleva/GarmentCode/issues/29#issuecomment-2548010340,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJJCN6PWNLGOATTWMSTTXKD2F7ZGLAVCNFSM6AAAAABSMSDCG6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBYGAYTAMZUGA
.
You are receiving this because you authored the thread.Message ID:
@.***>


cargo miri: add support for '--many-seeds'

to run the program / tests many times with different seeds: cargo miri run --many-seeds / cargo miri test --many-seeds.
@rust-lang/miri any opinion on the flag name here? Should it be -Zmiri-many-seeds or is --many-seeds fine?
Fixes https://github.com/rust-lang/miri/issues/3546

I think --many-seeds is better. Honestly I don't see any reason to claim this is unstable/experimental, we've been doing this many seeds thing for years and I think it has proven its value.

All right, let's land this then. We can always adjust this later.
@bors r+

:pushpin: Commit e81fa00d00a6dfca9ed2d2092809ad0cd3bc243c has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit e81fa00d00a6dfca9ed2d2092809ad0cd3bc243c with merge 60a720040d6c60656ab9cac0980e587d19d9c07a...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 60a720040d6c60656ab9cac0980e587d19d9c07a to master...

--many-seeds doesn't seem to run integration tests, was this intentional?

I am not sure what you mean. Test selection is independent of this flag.
Please file an issue with reproducible instructions.


0.7 does no recognize token-label

Updating - 9h22min
Now I have something to ruminate. I kept running the same command again and again, trying to figure out what was going on.
Sometimes it would hang up for a long, long time (like 5, 10, 15 minutes) and then come back with the same error message.
But, after some tries, out of the blue, it started working again...
I am mystified, but the fact is that it is working again.
I'll let the issue as reported bellow, but for the time being, IT IS WORKING.
Thank you.
After installing pyhanko 0.7 the command line I've been using for a long time stop working with the following message:
[cut]
 File "/home/fernando/.local/lib/python3.8/site-packages/pyhanko/cli.py", line 972, in addsig_pkcs11
    with pkcs11.PKCS11SigningContext(pkcs11_config) as signer:
  File "/home/fernando/.local/lib/python3.8/site-packages/pyhanko/sign/pkcs11.py", line 310, in __enter__
    self._session = session = open_pkcs11_session(
  File "/home/fernando/.local/lib/python3.8/site-packages/pyhanko/sign/pkcs11.py", line 72, in open_pkcs11_session
    raise PKCS11Error(
pkcs11.exceptions.PKCS11Error: No token with label FERNANDO JOSE CASTRO CABRAL:12436666687's AC VALID RFB v5 ID found

(I know this is a long and strange label, but that's what worked with previous versions.)
Command line:
pyhanko sign addsig --field "1/250,200,410,300/Fernando Cabral"  --style-name vereador pkcs11 --lib /usr/lib/libaetpkss.so --token-label "FERNANDO JOSE CASTRO CABRAL:12436666687's AC VALID RFB v5 ID" --cert-label "FERNANDO JOSE CASTRO CABRAL:12436666687's AC VALID RFB v5 ID"  "OF047-2021.pdf" "OF047-2021_assinado.pdf"

OS: Linux Mint 20.2, cinnamon edition

That's strange... I didn't change anything in the way PKCS#11 tokens are accessed recently, so I'm not sure what the problem could be. That routine in particular hasn't changed for over half a year, and doesn't call any other code in pyHanko.
Questions:

Are you accessing the device over a network connection?
Can you reproduce the behaviour with earlier versions?
If not, how about a more minimal piece of PKCS#11 signing code that doesn't use PDF?
Can you try looking up the slot number of the token (using something like pkcs11-tool) and pass it in via the --slot-no parameter? That bypasses the (possibly slow) search for matching tokens.

From the behaviour you describe, I'd assume that the problem is somewhere between the PKCS#11 module and the device, but I can't say for sure.

Thank you, Matthias. As per the editing I did some minutes after opening the issue, pythanko started working again. I will presume, for the time being, that I had some hardware issue or perhaps a combination of some rare phenomena that interfered with the software. I would suspect my typing and my eyes if I were typing the command. But, since it is in a shell script that has not been changed, typing can not be issue.
Please, consider this to be a non-issue. If it happens again, I'll let you know.
Thank you again.

OK, that's good news. I'll close this issue for now, then. :)


softmask backdrop ignored

Link to PDF file (or attach file here):
gs-bugzilla689309-reduced-bc1_RGB.pdf
gs-bugzilla689309-reduced-bc0_RGB.pdf
Configuration:

Web browser and its version: ff 50.0.2
Operating system and its version: W7 64bit fully patched
PDF.js version: most recent
Is an extension: ?

Steps to reproduce the problem:

open demo viewer
open file gs-bugzilla689309-reduced-bc1_RGB.pdf

What is the expected behavior? (add screenshot)

What went wrong? (add screenshot)

Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):
n/a
Additional comment:
The two files are identical except for the /bc value in the softmask. The softmask is smaller than the transparency group it is applied to. My understanding is that the /bc color is to be used instead of the softmask as an "influence" for the area that isn't covered by the softmask. I suspect that PDF.js just ignores /bc.
The fine black line doesn't belong there (although it happens to be useful as it shows the size of the softmask). The red line does belong there and shows the size of the transparency group.
The file is a reduced and modified version of one in https://bugs.ghostscript.com/show_bug.cgi?id=688601 to investigate a different problem than the one mentioned there.

I suspect that PDF.js just ignores /bc.

That's not correct, please see src/core/evaluator.js#L443 and e.g. src/display/canvas.js#L701

Some notes in case I don't get back to this for awhile:
The issue is when we compose the smask we only compose the region that the smask image overlaps the canvas, not the whole group/page. This can be fixed by 1) creating a full size page canvas  2) fill the canvas with the bc color 3) draw the smask 4) compose full smask and the page canvas. Unfortunately, if we do that we then have to compose two much larger images. It'd probably be better if we tracked bounding boxes for what we need to compose, but I think that will be quite a bit of work to implement.


Update User Guide for lesson-related features

Codecov Report

Merging #176 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #176   +/-   ##
=========================================
  Coverage     49.84%   49.84%
  Complexity      573      573
=========================================
  Files           125      125
  Lines          2620     2620
  Branches        319      319
=========================================
  Hits           1306     1306
  Misses         1205     1205
  Partials        109      109

Impacted Files
Coverage Δ
Complexity Δ

...c/main/java/trackitnus/model/lesson/DayOfWeek.java
57.89% <0.00%> (ø)
3.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7496a09...c3ae254. Read the comment docs.


No CLA bot message appears when recheckcla typed

It looks like the message is not being sent when recheckcla is typed. My assumption is that PERSISTANCE_GITHUB_TOKEN secret is not present OR token behind it was removed/changed somehow.

recheckcla

recheckcla

I've disabled the cla bot, it was buggy and did not offer a good experience for new contributors.

I've disabled the cla bot, it was buggy and did not offer a good experience for new contributors.


SOUNDS: current ADSR only squeezes the "release" phase

according to the duration of the sound. The other phases remain un-changed. As a result, the sound is cut off with a click sound if the duration is not sufficient. The proper way seems to be to make the phases proportional to the duration.
function adsr(attack_time, decay_time, sustain_level, release_time) {
  return function (sound) {
    var wave = get_wave(sound);
    var duration = get_duration(sound);
    return make_sound(function (x) {
      if (x < attack_time) {
        return wave(x) * (x / attack_time);
      } else if (x < attack_time + decay_time) {
        return ((exponential_decay(1 - sustain_level, decay_time))(x - attack_time) + sustain_level) * wave(x);
      } else if (x < duration - release_time) {
        return wave(x) * sustain_level;
      } else if (x <= duration) {
        return wave(x) * sustain_level * (exponential_decay(release_time))(x - (duration - release_time));
      } else {
        return 0;
      }
    }, duration);
  };
}

Also make ADSR linear instead of exponential.

@martin-henz just to clarify, the changed adsr function would accept A, D and R ratios rather than the raw duration in seconds?

@martin-henz just to clarify, the changed adsr function would accept A, D and R ratios rather than the raw duration in seconds?

Yes, I think that would make more sense. The ratios of A D and R would be added up, and subtracted from 1 to get the ratio for the duration of S. All these duration ratios need to be multiplied with the absolute duration of the sound to which the envelope is applied, in order to get their absolute durations.


added timeout connection in httpclient

Added timeout connection so if the connection to the URL is not available the agent will not wait 100 seconds

#4215


Memory Leak when using Threads

Hi,
When i create a new caffe::Net object in a Thread the memory is not freed.
Below example without Thread works fine and frees memory:
int main()
{
     for(int i=0;i<10;i++)
    {
        caffe::Net* cnn = new caffe::Net(("deploy.prototxt"));
        delete cnn;
    }
    std::cin.ignore();
    return 0;
}

The below example using Threads doesn't free memory
void threadWork()
{
        caffe::Net* cnn = new caffe::Net(("deploy.prototxt"));
        delete cnn;
}

int main()
{
     for(int i=0;i<10;i++)
    {
        std::thread t1(threadWork);
        t1.join();
    }
    std::cin.ignore();
    return 0;
}

Do you know what is causing this?

memory pool manager is used for every thread, and these instances only freed when the program exit.
check the code here and here

为什么在我的程序里面delete cnn就出错？


Value Iteration

I would like to start a discussion on having a class of value_iterator, which will be used to iterate over a value instance like visiting a tree in a depth-first manner.
Currently, we can iterate over array and object but I think a more general iterate functionality will be helpful for many applications. Also it would be nice that value supports generic iteration like other container classes.
I prefer each iteration to return a key-value pair of a JSON Pointer and value reference but I would like to ask your opinion regarding it and whether we can utilize the already implemented mechanisms/structures in the library.

Why specifically depth-first? Why not breadth-first? What's the use case? I agree with Vinnie, this sounds like an example.

We use JSON values as the configuration object for programs. Sometimes, it is nice to list all the hierarchical key-value pairs flatly. I agree that this could be a good flatten example.
"/a/b/c": 12,
"/a/b/": "XYZ",
"/a/d": true,
"/a/e/c": 23,
"/a/f/c": 44,

But more importantly, iteration support would make it easier to use std::algorithm over JSON values. For example, I want to select all keys that satisfy a certain pattern such as /a/*/c, and filter/apply an operation on them. In this case, I will easily iterate over the JSON value and check whether the key matches the expression.

@doganulus I think you should write it as an example contribution to Boost.JSON

Ok, so I am interested in this in a form of an example. I'm not exactly sold on this being general-purpose enough to be added to the library proper. BTW, have you thought about integration with Boost.Graph?


[antd5] add Skeleton component

Add support for Skeleton component.

Hey @georg-malahov.
Any reason for the change from defaultValueHint to defaultValue?

@IcaroG Yes, if am not mistaken now, by using defaultValueHint without providing exact defaultValue the conditional hidden field didn't work as expected. E.g. hidden: (ps) => ps.type !== "Avatar" && ps.avatar !== true, seemed to have no real values set in ps object.


Output resolution problem

Hi
I tried to train with a custom dataset of 640480 and tested it on the .pth I got using test_simple.py. Why is the resulting .npy depth map size 640192 instead of the 640*480 I set?

My data set is aerial images taken by drones, and the test results are as follows:
Original image:

Depth Map：

.npy Depth Map：

Hi, in the options you can change the width and height. Did you change the camera intrinsics before training the network?

Yes, I changed the size in the opening, but the. npy size output by test_Simple.py is still 640 * 192

Can you validate that the size you used for training is correct? Because the image size is read from the trained model, see the code here. I guess you trained your model using 640*192

Yes, upon inspection, it was found that I used a size of 192 * 640 for training. I will retrain. Thank you for your answer!


[SUGGESTION] External server information system

External server information browser. Increase population of servers via people able to see what's going on without having to fire up the game. Helps with servers that have their population based on....population of the server.
Doesn't need to launch the game and join the server- just a tool for information.

You can make yourself using this json
http://<IP_ADDRESS>:3692/

You can make yourself using this json
http://<IP_ADDRESS>:3692/

I made an external serverlist using the API Bartixx posted a while ago if you're interested
github page

I made an external serverlist using the API Bartixx posted a while ago if you're interested
github page


Multiple steps/frames in animation

I am trying to animate a path, to achieve the desired effect I broke the animation in a few steps and I am triggering the next step in a callback like this:
path.animate({path: newPath}, 1000, function () {     animatePath(path, nextPath); });
This does animate all the steps, but there is some lag between the steps, is there a better way to achieve this? It would be nice if you could pass an array of animations to the animate function, just a thought,

You could do something similar to http://svg.dabbles.info/snaptut-animateframe
Something I've been thinking similar could be added to the main code, as it is something that seems to be called for a bit.
There shouldn't be any noticable lag other than the set delay, so if you get some extra lag somewhere, it may be worth producing a minimal test case highlighting the problem.


Question about the Function transform

Thank you for your excellent job-:) I have a question when i read the code about function transform
You say, given the images and image_embedding, and the return is Predictions:Concept predictions for each image
But when i read the code of transform, the output is not the concept prediction for each image.
can you explain it ?Thank you very much!

The .transform function returns the predictions for each image. Take the last few lines of the .transform method as shown below:
https://github.com/MaartenGr/Concept/blob/d270607d6ea4d789a42d54880ab4a0c977bb69ce/concept/_model.py#L193-L195
With that, we create a lower dimensionality of the embeddings and feed those to the HDBSCAN model to cluster. The resulting clusters, predictions, are the concept prediction for each image.

sorry to bother you again. I try to use the following code to find the best concept for each images：
concept_model = ConceptModel()
new_concepts = concept_model.transform(image_list)
the error detail is :
Traceback (most recent call last):
File "_model.py", line 629, in
new_concepts = concept_model.transform(image_list)
File "model.py", line 197, in transform
umap_embeddings = self.umap_model.transform(image_embeddings)
File "/home/lixin/enter/envs/PR-VIST/lib/python3.7/site-packages/umap/umap.py", line 2802, in transform
if self._raw_data.shape[0] == 1:
AttributeError: 'UMAP' object has no attribute '_raw_data'
can you give me some useful advice to fix it ? thank you @MaartenGr

Definitely not a bother! Although I am not familiar with the error, I would advise making sure you have the newest version of umap-learn installed. If that does not work out, creating a completely fresh environment and re-installing in theory should resolve your issue.

Thank you for your nice advice, i will follow that instructions. And i have another to bother you, if you have some ideas, i would appreciate it if you share it with me.
I have a sequences of images(prehaps 10 images), if i want to find the topic or theme(wedding, vocation etc.) of them do you have some ideas?

To find the topics of a set of images, I would advise going through the README and simply replacing those images with the images that you have. Do note that you would want at least a few hundred images to get a good clustering going.

Thank you for you advice and i have some ideas in my minds. I have another question, if i predict the topic of a set of images, but how can i evaluate the results? Because i found no images2topic dataset. Look forward to your reply.

To my knowledge, there currently is not a dataset where you can find both images and topics as topic modeling is typically evaluated through coherence, which cannot easily be generalized to images. Since concept modeling is rather new I do not think there is a set of standard procedures yet for evaluating concepts.


Enable USB booting on RPI4-64

This PR enables USB boot on the Raspberrypi4-64 device.
We switch to upstream HEAD revision of u-boot for the RPI4-64 to enable this feature.
Considerations:

It's necessary to have the latest boot SPI firmware flashed, in order for usb to be started before u-boot is loaded from it. See https://github.com/balena-os/balena-raspberrypi/issues/384
To mute repetitive SDHCI timeout logs when booting from USB with no sd-card inserted, it's necessary to add the following line to config.txt - recommended approach by raspberrypi developers, and will disable sd-card hotplug. This can be achieved from the dashboard, Device Configuration > Define DT Parameters:

        sd_poll_once            Looks for a card once after booting. Useful
                                for network booting scenarios to avoid the
                                overhead of continuous polling. N.B. Using
                                this option restricts the system to using a
                                single card per boot (or none at all).
                                (default off)

Source: https://raw.githubusercontent.com/raspberrypi/firmware/master/boot/overlays/README
Fixes: https://github.com/balena-os/balena-raspberrypi/issues/498

@balena-ci rebase

@resin-jenkins test this please

@resin-jenkins test this please


maxTimeMS support

Since MongoDB version 2.6, cursors can supply a maximum execution time. A function wrapper for this would be useful.
http://docs.mongodb.org/manual/reference/operator/meta/maxTimeMS/
That doc claims you can include $maxTimeMS in the projection of the find() call but I'm unable to confirm that, even using just the mongo shell. Regardless, a cursor method would probably be useful.

Looks like mongodb-core doesn't support maxTimeMS yet. Ask @christkv directly - https://github.com/christkv/mongodb-core

mongocore does :) just take a look at how the 2.0 driver passes it through to mongodb-core

Sorry was looking in the wrong place.

Phew, this took a bit of time but finally available on typescript version mongots - https://github.com/prabhu/mongots/commit/5f1337158260b13258905ddf8814499620a8ab6d
Will send a bunch of PR next week for the js version


CI:add coverage

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@c167541). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #390   +/-   ##
=========================================
  Coverage          ?   46.62%
=========================================
  Files             ?       27
  Lines             ?     2741
  Branches          ?        0
=========================================
  Hits              ?     1278
  Misses            ?     1372
  Partials          ?       91

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

try to get data report


Feat: Return node core error to user

What

Throw the errors returned by node (lit-core-rs error format). These are the new errors objects returned by the nodes.
Some error checking is also done on the client side, standardize those errors to be of the same format as the node errors.

How

Update the throwError() params to match the node errors

Note: Have updated the key message to description in the thrown error to match node error keys.
Tests
To test that the new node errors are being thrown just match the console logged node errors (node errors are logged on the console as most common error, you may also check individual errors in the returned object) with the ones "thrown".

@Adarsh-Kumar28 is there a corresponding PR on the new SDK side? Or are the changes already merged in there?
cc @glitch003

@Adarsh-Kumar28 is there a corresponding PR on the new SDK side? Or are the changes already merged in there?

@hwrdtm No we have to make these changes for the new SDK as well

Will be handled in https://github.com/LIT-Protocol/js-sdk/pull/73


[rareprotocol-staked-balance]: Staked RARE voting strategy

Fixes # .
Changes proposed in this pull request:

Added a strategy, where the balance includes RARE that has been staked

Closing because, this can be achieved with existing strategies


Production build: clearing browser cache

script and styles bundle are imported in index.html as follows:
<script src="dist/bundle.js"></script>

<link rel="stylesheet" type="text/css" href="dist/bundle.css"></style>

However in production builds, old scripts and styles will be loaded from browser cache since the import urls are static.
Would like to ask what is the recommended way to solve this problem?

Without serverside injection of the script might be trickier, but I think
the commonly used is bundle.js?v=some hash that changes everytime there
is changes to the file
2016-03-09 5:23 GMT+02:00 Brandon Woo<EMAIL_ADDRESS>
script and styles bundle are imported in index.html as follows:

However in production builds, old scripts and styles will be loaded from
browser cache since the import urls are static.
Would like to ask what is the recommended way to solve this problem?
—
Reply to this email directly or view it on GitHub
https://github.com/anorudes/redux-easy-boilerplate/issues/68.

Maybe letting Webpack add hashes to the Javascript files? I found this tutorial to be very helpful, see "Adding hashes to filenames": http://survivejs.com/webpack_react/building_kanban/#adding-hashes-to-filenames

Hello, today the boilerplate was updated for 3 version and we have auto rimraf dist folder now


Adding a large number of connections takes a long time

I'm trying to visualize a bigger graph (1200 nodes and 2900 connections) with Draflow. In general it is working and the result is good. Unfortunately, I have the problem that adding connections between nodes gets slower and slower as the number increases. While the first few hundred connections are added quickly, it gets slower and slower until only a few connections are added per second, so that adding all nodes takes about 20 minutes. Is there a way to optimize this?
Looking forward to your feedback.
Best Regards
Tobias

I add them by programming. But the browser is freezing and it takes up to 20min to execute the function addConnection(id_output, id_input, output_class, input_class) for all connections.

Hello
The problem is that it is updating the connections by the nodes. You could comment the following lines in function addConnection:
this.updateConnectionNodes('node-'+id_output);
this.updateConnectionNodes('node-'+id_input);

And delaying the execution of the connections.
In this example, it loads the nodes and loads the connections.
Complete example:
<!DOCTYPE html>

    <meta charset="UTF-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <title>Document</title>
    <link
      rel="stylesheet"
      href="https://cdn.jsdelivr.net/gh/jerosoler/Drawflow/dist/drawflow.min.css"
    />

I would also add to Jero's approach, splitting the flow as modules, or UI tabs, and building a connector flow in and out. we've done this and it works fine. This way you can modularize and keep flows much more sensible 70 to 120 nodes with connections is just fine per UI tab. If you've implemented the minimap it slows everything down.
One comment to jero is change the mini map to a block (square) you can drag around, as this is simpler but also speeds everything up significantly.
On the UI modules approach you can add, 20, 50, 100, 150+ tabs of 50, 70 , 150 nodes  per UI tab/module with connections and in my view that's way more than enterprise standard. with good performance.


[MRG] fix layers 5 and 2 swapped depth dimension

Closes #351

Codecov Report

Merging #352 (ad09cf4) into master (c65bc1e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #352   +/-   ##
=======================================
  Coverage   90.94%   90.94%
=======================================
  Files          13       13
  Lines        2540     2540
=======================================
  Hits         2310     2310
  Misses        230      230

Impacted Files
Coverage Δ

hnn_core/network.py
93.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c65bc1e...ad09cf4. Read the comment docs.

Hmm, digging a little deeper, what's this doing @rythorpe:
https://github.com/jonescompneurolab/hnn-core/blob/c65bc1e1ffa3438727e0bc699aea09aae869ec81/hnn_core/cell.py#L319
So net.pos_dict contains coordinates such that apical=Z, and Cell flips Z and Y so that apical sections are along Y?
Man it's hard to keep track of all these flips splattered all over the place! I'm honestly uncertain which way our dendrite section s are pointing!

yeah, this is what I saying here @rythorpe

Thanks @cjayb ! Feel free to add a whats_new entry for this in your LFP pull request.

Just getting caught up - good catch here @cjayb! Looks like @jasmainak is dismantling the tyranny of incongruent morphology orientation in his most recent PR!


The DCGM make binary failed

env:
datacenter-gpu-manager.x86_64            1.7.2-1
go version go1.14.1 linux/amd64
flow:
[root@shpl009030064 gpu-monitoring-tools]# pwd
/root/zto-eilinge/gpu-monitor/gpu-monitoring-tools
[root@shpl009030064 gpu-monitoring-tools]# ls
bindings            docker  grafana   README.md
CONTRIBUTING.md     etc     LICENSE   RELEASE.md
dcgm-exporter.yaml  go.mod  Makefile  service-monitor.yaml
deployment          go.sum  pkg       vendor
failed logs:
[root@shpl009030064 gpu-monitoring-tools]# make binary
go build -o dcgm-exporter github.com/NVIDIA/gpu-monitoring-tools/pkg
github.com/NVIDIA/gpu-monitoring-tools/bindings/go/dcgm
bindings/go/dcgm/api.go:20:13: undefined: mode
bindings/go/dcgm/api.go:65:33: undefined: Device
bindings/go/dcgm/api.go:70:35: undefined: DeviceStatus
bindings/go/dcgm/api.go:75:39: undefined: P2PLink
bindings/go/dcgm/api.go:81:24: undefined: GroupHandle

export PATH=$GOROOT/bin:$GOPATH/bin:$PATH
export GOROOT=/usr/local/go
#export GOBIN=$PATH:$GOROOT/bin
export GOBIN=$GOROOT/bin
export GOPROXY=https://goproxy.io
export GOARCH=amd64
export GOOS=linux
export CGO_ENABLED=0
export GO111MODULE=on
export GOTOOLS=$GOROOT/pkg/tool
i can run other go program in my env, but it failed when running make binary

Hello!
This seems like an issue with your setup, I would suggest you take a look at the Dockerfile: https://github.com/NVIDIA/gpu-monitoring-tools/blob/2.0.0-rc.10/docker/Dockerfile.ubuntu18.04
If you want you can also look into building the source in the dockerfile and copy the resulting binary to your machine by running make image and then docker copy


[feat] update packages

need to wait for https://github.com/mswjs/msw/issues/2342 to be fixed and released


Fix multi-line bar chart label positioning

When using a multi-line label in a bar chart the text is rendered via draw instead of directly to the renderer. Because of this the style of the renderer is reset after drawing the first line (which causes alignment issues due to MeasureText returning a zero value Box).
This PR fixes this by calling the renderer directly.

thanks for the contribution!


[Content]: Request New Page Under Sources

What article on segment.com/docs is affected?
None, new page under "Sources"
What part(s) of the article would you like to see updated?
Sending Events via Server Side Libraries
Several key factors can prevent events from being successfully ingested into the Segment platform through server-side libraries as sources. Understanding these reasons is crucial for troubleshooting and ensuring data integrity. Here are some suggestions to address these challenges:

Payload is too large
There is a maximum of 32KB per normal API request. The batch API endpoint accepts a maximum of 500KB per request, with a limit of 32KB per event in the batch. If you are sending data from a server source, Segment’s API responds with 400 Bad Request if these limits are exceeded.

Identifier is not present
Segment's API requires that each payload has a userId and/or anonymousId.

Track event is missing name
All Track events to Segment must have an event field.

Deduplication
Segment deduplicates based on the messageId field. That field is automatically added to all payloads coming into Segment but if you're setting it yourself, please make sure all events have unique messageId values.

Additional information
No response

hi @courtneyga - you mention Segment's API a few times in your original request, is that the tracking API, or a different internal API?
Also, you mention a specific error code for the first item in the list, but not for the other three items. What error codes will users get if they send events without an identifier, or Track events without a name? I assume Segment would silently drop events that have the same messageId, but would that result in an observable error?

hi @forstisabella , my apologies for being unclear. I am referencing the Segment API's: https://docs.segmentapis.com/
Segment does silently drop the events, and typically the error code is a Bad Request (400).


Music not playing, strange white rectangle in bottom-left

I am running OSX 10.10.5 and I have flash installed. I have Radiant Player version 1.4.0. When I open the app I get a weird white rectangle in the bottom left. I can interact with the app, selecting songs, albums, or radio stations, but no audio plays when I click play. See screen shot.
Also I have opened the google web app in the latest version of chrome and safari and I do don't experience the same problems there.

Did some more research and found issue #318 but I'm on the latest version of everything and still having the issue. Here is the console output: https://gist.github.com/rlbaxter/a7c9c9469c98bc031b71

Isn't this the same as #351 and #352 and #358 ?  There is a compiled version linked in #358.  Otherwise I think the solution for now is to build it yourself from the source code.

Indeed it is. Thanks. Didn't see those in my search, I apologize for creating duplicates.


Request: Insert* methods should return the PK regardless of if the PK was generated by the DB or not

Currently when you call InsertAsync (for example) and the PK is non identity column (i.e UUID with default) or a PK is already provided by the entity you are inserting, the Insert method returns an empty PK value.
This change would make it so you are ALWAYS provided the PK of the entity from the Insert even if you provided it yourself or the DB generated it outside of an identity situation, this provides a more consistent experience for the library consumer. It may also be worth noting that the PK is only returned if it is an identity field run on the DB.

This was discussed in a gitter conversation with @mikependon  and he was happy for it to be raised here as a request.

We have assessed and made a branch changes for this. The extent of the changes for the fix on this request is quite big. It is a bit critical to make such big changes as we are to release the new stable version soon.
We will consider this one as an enhancement and have decided to have this request be a part of our next release.

This is affecting the entire extensions (SQL Server, PostgreSQL, MySQL/MySQL(Connector), SQLite and also the Bulk Operations).

This exception has triggered a behavioral-breaking-changes to the library which actually forces us to fix it. Before, RepoDB always consider the identity column as the primary column, and the library is actually failing in the use-case that the identity column is a completely separate than the primary column.
With the upcoming changes, we have updated the behavior that the library will always return and set-back the value only to the identity column. In the case that there is no identity column define in the entity/model, there will be "no" value to be set back to the entity/model.
However, pertaining to the issue where you actually provided an auto-generated column for the Primary column, this kind of behavior is not fix due to the fact that RepoDB is only considering to return the identity column. The scenario of having an auto-generated column for Primary is actually same scenario as the any other column with default value from the database, in which RepoDB is lacking the capability since the beginning and is considered as limitation.
To rectify this problem, you have to explicitly do a round trip call to the database, and it is a little bit hack.

We will never fix your scenario due to the limitation on the behavior. We also have updated our limitation page by adding the new section named Auto-Generated Primary Column.
However, we will set this issue to "fixed" due to the fact that we have issue a fix to the scenario of identity and primary column value hydration back to the model.
The updates will be available on the next version > RepoDB v1.12.10. Please do not hesitate to revert if you have questions.