Rename "Temporary Accommodation" in UI

Context
It's been decided that the Temporary Accommodation service will now be
called the Transitional Accommodation service. Therefore we need to
update any places that reference the old name.
In this change, we update all the places in the user interface as this is
essential for rolling out the service to the rest of the regions.
We will address the non-user-facing changes in separate commits as these
are not as urgent.
Changes in this PR
Screenshots of UI changes
Limited to 3 for brevity.
Before

After

Release checklist
Release process documentation.
Pre-merge checklist

[ ] Are any changes required to dependent services for this change to work?
(eg. CAS API)
[ ] Have they been released to production already?

Post-merge checklist

[ ] Manually approve
release to test
[ ] Manually approve
release to preprod
[ ] Manually approve
release to prod

 Service name change (UI)


Colors from Grafana's palette #29

Looks good.  Can you add an item on the v0.0.7 changelog?

go ahead and merge

@ryantxu I will add to changelog. thx for approve


104 tests fail on aarch64 with RuntimeWarning: invalid value encountered in cast

Describe your issue.
On openSUSE Tumbleweed, we have 104 tests fail on aarch64 with RuntimeWarning: invalid value encountered in cast.
Reproducing Code Example
Run test suite on openSUSE Tumbleweed aarch64.

Error message
Full error log (too long for a copy/past as it is limited to 65536 char): https://paste.opensuse.org/pastes/b86ee07b9136
SciPy/NumPy/Python version information
scipy 1.9.3, numpy 1.24.1

Thanks @ggardet, seems to be linked to this: https://numpy.org/devdocs/release/1.24.0-notes.html#numpy-now-gives-floating-point-errors-in-casts

That's interesting, because the issue doesn't arise in CI, https://cirrus-ci.com/task/5758309563629568, albeit with python310

Clarification, the issue doesn't arise in main, with numpy 1.24.1, with python3.10.
However, it does manifest in 1.9.3. #16403 is related and is the original issue for this problem. There were more issues uncovered at a later stage, #17630, for linux_aarch64. (note we've only had a linux_aarch64 CI run for a short period of time). Those issues were fixed in >= 1.10 by PR #17634. However, the latter PR has not been backported to the 1.9.x branch.
@tylerjereddy, is it possible to backport the fixes in #17634 if we make another 1.9.x point release? If we're not going to be making another 1.9.x release then we should close this issue as wontfix.
@ggardet, thanks for reporting these test failures. You won't see the issues if you update to 1.10, but the fix has not yet been backported to the 1.9.x maintenance branch.

I like @andyfaff's suggestion. The test failures themselves seem harmless, they're just warnings that get turned into errors by the test suite. So a new release specifically for this should not be necessary.

Ok, I added the label and a short comment over there

Clarification, the issue doesn't arise in main, with numpy 1.24.1, with python3.10.
However, it does manifest in 1.9.3. #16403 is related and is the original issue for this problem. There were more issues uncovered at a later stage, #17630, for linux_aarch64. (note we've only had a linux_aarch64 CI run for a short period of time). Those issues were fixed in >= 1.10 by PR #17634. However, the latter PR has not been backported to the 1.9.x branch.
@tylerjereddy, is it possible to backport the fixes in #17634 if we make another 1.9.x point release? If we're not going to be making another 1.9.x release then we should close this issue as wontfix.
@ggardet, thanks for reporting these test failures. You won't see the issues if you update to 1.10, but the fix has not yet been backported to the 1.9.x maintenance branch.

Indeed, I updated to 1.10 release and the problem is gone. Thanks!

I'll close this issue--if we do have an accumulation of reasons to do another 1.9.x point release, I'll aim to fix this while I'm at it, but it sounds like we won't rush another 1.9.x just yet for these warnings alone--hopefully that's ok.


Zoom

There is any zoom function working with multi-touch?
Thanks

Hey, no sorry, nothing like that supported at the moment. Feel free to create a pull request!


Cherry-picks for the 4.1 branch (future 4.1.2) - 1st batch

I will make a second batch with more fixes, and update the changelog alongside it. But for now, here's a number of good picks.

Thanks!


Add allowlist in js

Docs Build status updates of commit c73ec48:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docsms-allowlist/js-allowlist.txt
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


unminified build

Description

[!TIP]
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation
/ok-to-test tags=""
:mag: Cypress test results

[!WARNING]
Tests have not run on the HEAD 5bb39b7ecdc86bcfecfaf6950a7bff0018897afd yet
Wed, 20 Nov 2024 10:58:38 UTC

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[ ] No

Summary by CodeRabbit

Chores

Enhanced configuration for better source map generation.
Disabled code minimization for improved debugging experience.

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true


Request to change "Bookmark" to "Favorite" for consistency among marketing materials, video's etc

This will be fairly painful to implement and could cause user confusion at this time. Screenshots, help documentation, tour documentation, platform language, icons, modals, etc would all need to be changed. I think the biggest hurdle to users would be changing the icon. That is everywhere-- and users would have to be re-educated to know that the new icon has the same functionality as the old. The actual terminology of the functionality isn't that big of a deal (going with Bookmarks gives us more freedom for future functionality), but once something has been implemented, its a big deal to switch it.
https://github.com/ozone-development/ozp-hud/issues/99
Reason "Bookmark" was initially chosen over "Favorite"

"Bookmarking" indicates an strong action -- this listing is being placed somewhere. "Favoriting" could just be a notation on it for future searches. Not as clear/strong to indicate what is happening. This function should be clear since it is critical in AML -- you must bookmark in order to find it in Webtop.
"Bookmark/bookmarked/bookmarking" has good words to support all tenses. "Favorite" doesn't.
"Bookmark" has a widely-accepted and recognized icon. "Favorite" is a bit more fuzzy - maybe a heart?
We've already acclimated users to understand "Bookmark". Any change would need a very solid reason.
Making the change would steal valuable dev time away from moving forward with new functionality

Sticking with Bookmarks.


Update Set-Mailbox.md to add new parameter

A new parameter -DisableThrottling has been added to the Documentation

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/mailboxes/Set-Mailbox.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/mailboxes/Set-Mailbox.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


cmd/compile: confusing error messages when package paths mismatch

Example error message:
./fakeapi_test.go:29: cannot use names.NewModelTag("dead-beef") (type names.ModelTag) as type names.ModelTag in field value

The error was actually that I'd imported the names package from the wrong path.
It would be nice if the error message could make that clearer - as it is, it
it confusing because both types look identical.
For example:
./fakeapi_test.go:29: cannot use names.NewModelTag("dead-beef") (type names.ModelTag) as type names.ModelTag in field value (package github.com/juju/names, not gopkg.in/juju/names.v2)

Another possibility might be to do general disambiguation when more than one
identical package name referring to a different path is used in the same error
message.
For example:
./fakeapi_test.go:52: cannot use "github.com/juju/names".NewModelTag("dead-beef") (type "github.com/juju/names".ModelTag) as type "gopkg.in/juju/names.v2".ModelTag in field value

There is actually code in symfmt in cmd/compile/internal/gc/fmt.go that is supposed to handle this (look for If the name was used by multiple packages).  I don't know why it is not working for your example.  What is your test case?

Here's a test case that can probably be reduced further.
==> ./b/b.go <==
package b
import "a2"

type T struct {
	X a.X
}

==> ./a1/a.go <==
package a

type X string

func NewX() X {
	return ""
}

==> ./a2/a.go <==
package a

type X string

func NewX() X {
	return ""
}

==> ./p/tst.go <==
package main
import (
	"a1"
	"b"
)

var _ = b.T{
	X: a.NewX(),
}

func main() {
}

Sample run:
% pwd
/tmp/d/src/p
% go install
# p
./tst.go:8: cannot use a.NewX() (type a.X) as type a.X in field value

It looks like the respective code in the compiler doesn't trigger because numImport[s.Pkg.Name] is always 0 in this case. Possibly an error in the new importer. Investigating.

Yes, this got lost in the move from the old textual importer to the new binary one. This is a 1.7 regression. We should probably fix it, the fix is simple; with it, the error message is:
tst.go:8: cannot use "/Users/gri/tmp/a".NewX() (type "/Users/gri/tmp/a".X) as type "/Users/gri/tmp/a2".X in field value
(I've compiled all packages in the tmp directory.)
CL coming later today.

@rogpeppe Thanks for the test case.  This is in fact a regression since 1.6, so setting milestone to 1.7maybe.
1.6.2:
# issue16133
./tst.go:9: cannot use "issue16133/a1".NewX() (type "issue16133/a1".X) as type "issue16133/a2".X in field value

1.7beta2:
# issue16133
./tst.go:9: cannot use a.NewX() (type a.X) as type a.X in field value


Introduce has() for DTO like classes

https://github.com/propelorm/Propel2/pull/1624 and alike reveal a lot of the underlying nullable issues in the current code base
Instead of blindly reusing the return result, e.g. $this->getFoo()->doSth() on currently nullable ones, we should introduce a new has...() wrapper on top, and throw meaningful exception for getter if null.
For the cases currently used as finder, we need to rewrite using
$result = $x->hasFoo() ? $x->getFoo() : null

or alike.
This way we can also in the future add typehints and have a cleaner API moving towards PHP8 compatibility.

is this issue still valid, with the ?-> operator in PHP8? If $x->getFoo() returns a nullable result, that seems to be a better way to go forward than throwing on empty values/relations.

If you use PHP8+, many libs are PHP7/8 for quite some time still
So yeah, I would consider this a code smell still in projects and it would be nice if there was a way to avoid this.

Currently https://github.com/propelorm/Propel2/pull/1849 dos the opposite, it adds new not-null return methods where needed.
This keeps the current API and therefore less BC breaks for now
We should use has() none the less where we could safely change the status quo of the methods that exist.
Someone would need to investigate.
Otherwise a future major (BC break) could maybe fix this up.


fix: wait_for_logs can now fail early when the container stops

Addresses my suggestion made in issue 681.
This PR adds a flag that checks is the status is not running and raises a RuntimeError to avoid waiting for logs after the container already has exited. The idea is to save wait time when there is a long startup time in case the container fails early.
from testcontainers.core import container, waiting_utils

if __name__ == "__main__":
    waiting_utils.wait_for_logs(
        container.DockerContainer("flyway/flyway").start(),
        r"Successfully applied \d+ migrations to schema",
        timeout=10,
        raise_on_exit=True,
    )

# > RuntimeError(f"Container exited before emitting logs satisfying predicate")
# ( Raised almost immediately )

why is true is not the default, any background on this?

why is true is not the default, any background on this?

I think it would be a good default.
Kept it False just to not change existing functionality without explicit opt-in.

i would like to roll it out everywhere else, wonder what would be a good strategy for that, unless i am overthinking it, in which case we should just do it.

TBH, I think the false behavior is more a bug than actual expected behavior. If I were to make the call, I would not only make true the default, but also don't make it user configurable at all (can any of you come up with a use case were the false behavior is useful?).

pr title = "fix: wait_for_logs can now fail early when the container stops"
next pr title = ${pr title/can/WILL/}

Hi!
Agree with above, for all our use cases, the expected behavior would be to raise RuntimeError if the container exited. I think its a good idea to drop the option.
Another option is to allow user to define the set of Container.status that (don't) cause a fail. This would allow for a bit more configurability. WDYT?


Allow left and right button clicks to navigate

At least in presentation mode, clicking on the slide with the left mouse button should go to the next slide, and clicking with the right mouse button should move to the prior slide. That is how it works for example in Evince (only in presentation mode).
It doesn’t work with Mozilla Firefox 56.0 in Ubuntu 17.10 with Cinnamon as desktop environment.

middle button scroll works.

middle button scroll works.

Thank you for the hint. I’d still say, that clicking buttons would be easier especially with touchpads.
On the other hand, and list the right button click opens the context menu in browsers, so thinking about it again, it’s probably a bad idea to override that with something else. (I do not use the context menu at all, but other people might.)


Add next TechSource outage window

Context
Adds next TechSource outage window for banner
Changes proposed in this pull request
Add outage period for between 6pm on Friday 11 June and 8pm on Sunday 13 June.
Guidance to review

 TechSource outage 11 Jun


Images not visible

Describe the issue that you're seeing. Any Loom videos or screenshots usually help a lot!
By accessing the admin area in any published post the images are not visible. In the media manager the images are loaded correctly but in the editor they are not visible

The problem occurs both locally and in distribution via netlify. I also tried switching browsers and clearing the cache but nothing
Reproduction
npx create-tina-app@latest
Steps to reproduce
No response
System Info
Binaries:
    Node: 18.16.0
    Yarn: 1.22.19
    npm: 8.3.0
  Browsers:
    Chrome: 113.0.5672.63
    Edge: Spartan (44.22621.1635.0), Chromium (112.0.1722.68)
    Internet Explorer: 11.0.22621.1

Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug.

To initialize media in your project, you'll need to click "sync" in the media manager from the TinaCMS sidebar

To initialize media in your project, you'll need to click "sync" in the media manager from the TinaCMS sidebar

Already done the images are correctly visible in the Media manager and in the posts that are not seen

Hey, sorry for the delay getting back to you. Could you copy the URL that's in the HTML of the broken thumbnail?
Also, could you share the image that is failing to load for you?

Ehi, scusa per il ritardo nel risponderti. Potresti copiare l'URL che si trova nell'HTML della miniatura danneggiata? Inoltre, potresti condividere l'immagine che non riesce a caricare per te?

doing a more in-depth check I noticed that a further link to assets.tina.io cms is inserted in the Markdown example:
![image](https://assets.tina.io/305bf938-d8d2-41c5-ab47-b12d2cf62b85imagelink.jpg)


Add new proposal types

Adds proposal types for airdrop (3) where the payload is the merkle tree root and proposal type 4, which is no-op, useful for signal votes.

Everything looks good to me, I just wanted to know what motivates the replacement of impl_hash by payload, or what is the sense of payload ?

Payload can also be merkle tree hash if proposal type is airdrop, so impl_hash name isn't relevant anymore


Ability to share/import multiple Mirage configs

6 upvotes from Canny

@samselikoff could you explain a bit more of how to call server.config(options) multiple times? I'm trying to setup multiple config with different namespaces under mirage/config.js but there are no documentation to describe how.
Happy to submit a PR for updating docs if we could find a solution!

Sure, just that you can do
let server = new Server({
  models: {
    user: Model
  }
})

server.config({
  models: {
    message: Model
  }
})

Def should be documented! config method on Server class: https://miragejs.com/api/classes/server/

Sorry, just realized this is ember-cli-mirage repo.
So you'd need to get a hold of the Mirage server instance so you can call .config like ^ above.
I would try to do it by doing this.config() in the function in mirage/config.js (since this is the server instance).


feature: add support for ssh key authentication

A clear and concise description of what you want the system to do.

Add support for ssh key authentication.
Github docs: https://docs.github.com/en/authentication/connecting-to-github-with-ssh

What are the Caddyfile directives that need to be added.

Add Caddyfile directive:
git {
  repo foo {
    url git@github.com:greenpau/caddy-git.git
    auth key <path> [passphrase <secret>]
  }
}

Added caddyfile directives in https://github.com/greenpau/caddy-git/commit/3918564dd84599c85f160bfa7dfa4c66260e699e


added changed 0x to a #

it removes a lot of confusion

thanks for this and apologies for getting to it a month later! forgot I had used 0x instead of hash signs.


The counter of unread actions is restarted after a page refresh

Generate some alerts or notifications on sidebars
Read it - counter shows "0"
Refresh the page

Results:
The counter of unread actions is restarted, it shows again the number of notifications, should be 0
https://image.prntscr.com/image/0vOrbwqZR4yRCuar869CjQ.png

@dawid-g Fixed

verified as fixed.


How can remove the border of the button that close the zoom

Please i need a help. i can't remove the border of the close button when focus or active it
.dialog-zoom button:focus,   .dialog-zoom button:active{
border: none !important
}
doesn't work

@TonyFTannous Thanks for using this project, and I'm sorry you're having trouble.
If you're referring to the outline, that's something that is different across browsers, and unless you replace it yourself with something like border, removing outline from focusable elements can create severe accessibility issues.
One thing I don't understand is the CSS class names you're using above, for those are not used in this project. If you would like to style the component differently, you can find all the styles in this file, and here is the specific selector for overriding the styles for the unzoom button.
When it comes to styling this, you can either:

import the CSS file from the project, like it says it in the README, and then provide your own overrides for those styles
copy and paste the styles into your own project, modify those, and import your own CSS file without using the one from the NPM module

I hope that answered your request and provided enough info. This isn't an issue for the project, so I'm closing this, but feel free to keep asking questions here.


Replaces all computers on Saltern and reinforces all space-touching walls

About the PR
Replaces all outside walls with reinforced windows and walls. Also replaces every computer since they have rotation issues. Also removes the plasma canister in engineering storage.
Screenshots

Changelog

:cl:

tweak: Saltern's space-facing walls are all reinforced and computers should not be physics fucky anymore
remove: Removed plasma canister from Saltern for now

are computers supposed to be saved with their circuit boards?

yes

are computers supposed to be saved with their circuit boards?

yes

Guess somebody's getting shedded.


Unable to download videos from Dorkly.com.

$ youtube-dl -v http://www.dorkly.com/video/80646/super-mario-undertale
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-v', 'http://www.dorkly.com/video/80646/super-mario-undertale']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.09.15
[debug] Python version 3.4.2 - Linux-3.16.0-4-amd64-x86_64-with-debian-8.5
[debug] exe versions: ffmpeg 3.0.2-4, ffprobe 3.0.2-4, rtmpdump 2.4
[debug] Proxy map: {}
[generic] super-mario-undertale: Requesting header
WARNING: Falling back on generic information extractor.
[generic] super-mario-undertale: Downloading webpage
[generic] super-mario-undertale: Extracting information
[generic] 80646: Requesting header
WARNING: Could not send HEAD request to https://www.dorkly.com/e/80646: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:600)>
[generic] 80646: Downloading webpage
ERROR: Unable to download webpage: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:600)> (caused by URLError(SSLError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:600)'),))
File "/home/ant/bin/youtube-dl/youtube_dl/extractor/common.py", line 394, in _request_webpage
return self._downloader.urlopen(url_or_request)
File "/home/ant/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 2001, in urlopen
return self._opener.open(req, timeout=self._socket_timeout)
File "/usr/lib/python3.4/urllib/request.py", line 455, in open
response = self._open(req, data)
File "/usr/lib/python3.4/urllib/request.py", line 473, in _open
'_open', req)
File "/usr/lib/python3.4/urllib/request.py", line 433, in _call_chain
result = func(*args)
File "/home/ant/bin/youtube-dl/youtube_dl/utils.py", line 1011, in https_open
req, **kwargs)
File "/usr/lib/python3.4/urllib/request.py", line 1176, in do_open
raise URLError(err)
--
$  youtube-dl -v http://www.dorkly.com/video/80646/super-m                                         ario-undertale
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.dorkly.com/video/80646/super-mar                                         io-undertale']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.09.15
[debug] Python version 2.7.9 - Linux-3.16.0-4-amd64-x86_64-with-debian-8.5
[debug] exe versions: ffmpeg 3.0.2-4, ffprobe 3.0.2-4, rtmpdump 2.4
[debug] Proxy map: {}
[generic] super-mario-undertale: Requesting header
WARNING: Falling back on generic information extractor.
[generic] super-mario-undertale: Downloading webpage
[generic] super-mario-undertale: Extracting information
[generic] 80646: Requesting header
WARNING: Could not send HEAD request to https://www.dorkly.com/e/80646: <urlopen                                          error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:581)>
[generic] 80646: Downloading webpage
ERROR: Unable to download webpage: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILE                                         D] certificate verify failed (_ssl.c:581)> (caused by URLError(SSLError(1, u'[SS                                         L: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:581)'),))
File "/home/ant/bin/youtube-dl/youtube_dl/extractor/common.py", line 394, in _                                         request_webpage
return self._downloader.urlopen(url_or_request)
File "/home/ant/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 2001, in urlopen
return self._opener.open(req, timeout=self._socket_timeout)
File "/usr/lib/python2.7/urllib2.py", line 431, in open
response = self._open(req, data)
File "/usr/lib/python2.7/urllib2.py", line 449, in _open
'_open', req)
File "/usr/lib/python2.7/urllib2.py", line 409, in _call_chain
result = func(*args)
File "/home/ant/bin/youtube-dl/youtube_dl/utils.py", line 1011, in https_open
req, **kwargs)
File "/usr/lib/python2.7/urllib2.py", line 1197, in do_open
raise URLError(err)
--
Thank you in advance. :)

It's a bug of Dorkly.com. Use --no-check-certificate before they've fixed it:
youtube-dl -v --no-check-certificate http://www.dorkly.com/video/80646/super-mario-undertale

If anyone is going to report a bug to Dorkly.com, tell them their SSL certificate should contain the full certificate chain.

Thank you Yan12125. I sent an e-mail to<EMAIL_ADDRESS>:)


Several instances leads to having several submit.php's, which doesn't work

First of all, many many thanks for this amazing plugin.
I'm trying to make several instances of filepond on the same page, that should lead to different upload directories. I'm using the following code that was suggested on the github page:
$('.pond1').filepond({ allowMultiple: true, server: 'my-first-url' });
$('.pond2').filepond({ allowMultiple: true, server: 'my-second-url' });

However, having several servers means each server comes with it's own submit.php. But one form can only have one submit button, right? As a result, my files are correctly being uploaded to the tmp directory, but upon submit, nothing more happens.
Am I doing something wrong?
Cheers!

Hi, Thanks, glad to hear that!
We require the issue template to be filled out on all new issues. The issue template helps us collect all the information we need to address your submission efficiently.
If your issue can be classified as an integration question or a question about specific features of FilePond we ask you kindly to submit it on Stack Overflow.
We will be able to more closely look at your issue once the issue template has been filled out. This issue will be closed in 5 days if the template is not filled out or if the issue is determined to be a question.


Test against django 1.8, update dev requirements.

Have tox create and test against django 1.8 with python 2 and python 3.
Update the requirements-dev.txt file to use the latest versions of the testing packages. Add pytest-cov to allow pytest to generate a coverage report.
Change the tox configuration to tell pytest to generate the coverage report.
Add the .coverage and the .cache to the gitignore file.
Create unit tests for views and management commands.
Add a backend test to make sure that no users are created when CAS_CREATE_USER is false
Fix a bug in the callback function where the slos were not being iterated over.

Thank you for making it work with Django 1.8.

No problem, it actually worked well with Django 1.8 out of the box. I believe that nitmir fixed the one issue in the views.py file where the session object was not being flushed before the tickets were being delete. This would cause an internal error when someone used the saml logout and the sessions were backed by the db, as SessionTicket has a fk constraint on Sessions.
In any case, I hope these view tests and the minor cleanup can help. Would you be willing to create a new pip release in the near future?
Thanks,
Bryce

If you want a new pip release, please let me know. I can create one.

Can you tag a 3.4.3 and we can see if there are problems, and maybe in a few days push a new release?

Since there are some changes in those days. How about wait one week, if there is bug report then create a new release?

Sounds like a good plan to me. Thanks!


Not working with STM32CubeIDE 1.7.0 / STM32CubeMX 6.3.0

I don't know if it is an issue with the latest IDE, or something else, but it compiles in the CubeIDE but fails running the python script in VSCode.
AttributeError: 'NoneType' object has no attribute 'text':   File "C:\Users\xxxx\.platformio\penv\Lib\site-packages\platformio\builder\main.py", line 176:     env.SConscript(item, exports="env")   File "C:\Users\xxxx\.platformio\packages\tool-scons\scons-local-4.2.0\SCons\Script\SConscript.py", line 597:     return _SConscript(self.fs, *files, **subst_kw)   File "C:\Users\xxxx\.platformio\packages\tool-scons\scons-local-4.2.0\SCons\Script\SConscript.py", line 285:     exec(compile(scriptdata, scriptname, 'exec'), call_stack[-1].globals)   File "C:\Users\xxxx\git\yyyy\zzzz\setup_cubemx_env_auto.py", line 72:     linkedURI = linked_resource.find(".//locationURI").text
I had a quick look at the .project and .cproject files and don't see any elements named locationURI
Perhaps the node name has changed?
<linkedResources>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal.c</name>
			<type>1</type>
			<location>D:/DataFiles/STM32Cube/Repository/STM32Cube_FW_G4_V1.4.0/Drivers/STM32G4xx_HAL_Driver/Src/stm32g4xx_hal.c</location>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_cortex.c</name>
			<type>1</type>
			<location>D:/DataFiles/STM32Cube/Repository/STM32Cube_FW_G4_V1.4.0/Drivers/STM32G4xx_HAL_Driver/Src/stm32g4xx_hal_cortex.c</location>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_dma.c</name>
			<type>1</type>
			<location>D:/DataFiles/STM32Cube/Repository/STM32Cube_FW_G4_V1.4.0/Drivers/STM32G4xx_HAL_Driver/Src/stm32g4xx_hal_dma.c</location>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_dma_ex.c</name>
			<type>1</type>
			<location>D:/DataFiles/STM32Cube/Repository/STM32Cube_FW_G4_V1.4.0/Drivers/STM32G4xx_HAL_Driver/Src/stm32g4xx_hal_dma_ex.c</location>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_exti.c</name>
			<type>1</type>
			<location>D:/DataFiles/STM32Cube/Repository/STM32Cube_FW_G4_V1.4.0/Drivers/STM32G4xx_HAL_Driver/Src/stm32g4xx_hal_exti.c</location>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_flash.c</name>
			<type>1</type>
			<location>D:/DataFiles/STM32Cube/Repository/STM32Cube_FW_G4_V1.4.0/Drivers/STM32G4xx_HAL_Driver/Src/stm32g4xx_hal_flash.c</location>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_flash_ex.c</name>
			<type>1</type>
			<location>D:/DataFiles/STM32Cube/Repository/STM32Cube_FW_G4_V1.4.0/Drivers/STM32G4xx_HAL_Driver/Src/stm32g4xx_hal_flash_ex.c</location>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_flash_ramfunc.c</name>
			<type>1</type>
			<location>D:/DataFiles/STM32Cube/Repository/STM32Cube_FW_G4_V1.4.0/Drivers/STM32G4xx_HAL_Driver/Src/stm32g4xx_hal_flash_ramfunc.c</location>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_gpio.c</name>
			<type>1</type>
			<location>D:/DataFiles/STM32Cube/Repository/STM32Cube_FW_G4_V1.4.0/Drivers/STM32G4xx_HAL_Driver/Src/stm32g4xx_hal_gpio.c</location>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_i2c.c</name>
			<type>1</type>
			<location>D:/DataFiles/STM32Cube/Repository/STM32Cube_FW_G4_V1.4.0/Drivers/STM32G4xx_HAL_Driver/Src/stm32g4xx_hal_i2c.c</location>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_i2c_ex.c</name>
			<type>1</type>
			<location>D:/DataFiles/STM32Cube/Repository/STM32Cube_FW_G4_V1.4.0/Drivers/STM32G4xx_HAL_Driver/Src/stm32g4xx_hal_i2c_ex.c</location>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_pwr.c</name>
			<type>1</type>
			<location>D:/DataFiles/STM32Cube/Repository/STM32Cube_FW_G4_V1.4.0/Drivers/STM32G4xx_HAL_Driver/Src/stm32g4xx_hal_pwr.c</location>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_pwr_ex.c</name>
			<type>1</type>
			<location>D:/DataFiles/STM32Cube/Repository/STM32Cube_FW_G4_V1.4.0/Drivers/STM32G4xx_HAL_Driver/Src/stm32g4xx_hal_pwr_ex.c</location>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_rcc.c</name>
			<type>1</type>
			<location>D:/DataFiles/STM32Cube/Repository/STM32Cube_FW_G4_V1.4.0/Drivers/STM32G4xx_HAL_Driver/Src/stm32g4xx_hal_rcc.c</location>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_rcc_ex.c</name>
			<type>1</type>
			<location>D:/DataFiles/STM32Cube/Repository/STM32Cube_FW_G4_V1.4.0/Drivers/STM32G4xx_HAL_Driver/Src/stm32g4xx_hal_rcc_ex.c</location>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_tim.c</name>
			<type>1</type>
			<location>D:/DataFiles/STM32Cube/Repository/STM32Cube_FW_G4_V1.4.0/Drivers/STM32G4xx_HAL_Driver/Src/stm32g4xx_hal_tim.c</location>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_tim_ex.c</name>
			<type>1</type>
			<location>D:/DataFiles/STM32Cube/Repository/STM32Cube_FW_G4_V1.4.0/Drivers/STM32G4xx_HAL_Driver/Src/stm32g4xx_hal_tim_ex.c</location>
		</link>
	</linkedResources>

Just tried converting the linked resources to relative which seems to have created locationURI nodes, but I get a different error now:
SETUP_CUBEMX Error: Unexpected relative path type 'Src/stm32g4xx_hal.c'
<linkedResources>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal.c</name>
			<type>1</type>
			<locationURI>Src/stm32g4xx_hal.c</locationURI>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_cortex.c</name>
			<type>1</type>
			<locationURI>Src/stm32g4xx_hal_cortex.c</locationURI>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_dma.c</name>
			<type>1</type>
			<locationURI>Src/stm32g4xx_hal_dma.c</locationURI>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_dma_ex.c</name>
			<type>1</type>
			<locationURI>Src/stm32g4xx_hal_dma_ex.c</locationURI>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_exti.c</name>
			<type>1</type>
			<locationURI>Src/stm32g4xx_hal_exti.c</locationURI>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_flash.c</name>
			<type>1</type>
			<locationURI>Src/stm32g4xx_hal_flash.c</locationURI>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_flash_ex.c</name>
			<type>1</type>
			<locationURI>Src/stm32g4xx_hal_flash_ex.c</locationURI>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_flash_ramfunc.c</name>
			<type>1</type>
			<locationURI>Src/stm32g4xx_hal_flash_ramfunc.c</locationURI>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_gpio.c</name>
			<type>1</type>
			<locationURI>Src/stm32g4xx_hal_gpio.c</locationURI>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_i2c.c</name>
			<type>1</type>
			<locationURI>Src/stm32g4xx_hal_i2c.c</locationURI>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_i2c_ex.c</name>
			<type>1</type>
			<locationURI>Src/stm32g4xx_hal_i2c_ex.c</locationURI>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_pwr.c</name>
			<type>1</type>
			<locationURI>Src/stm32g4xx_hal_pwr.c</locationURI>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_pwr_ex.c</name>
			<type>1</type>
			<locationURI>Src/stm32g4xx_hal_pwr_ex.c</locationURI>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_rcc.c</name>
			<type>1</type>
			<locationURI>Src/stm32g4xx_hal_rcc.c</locationURI>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_rcc_ex.c</name>
			<type>1</type>
			<locationURI>Src/stm32g4xx_hal_rcc_ex.c</locationURI>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_tim.c</name>
			<type>1</type>
			<locationURI>Src/stm32g4xx_hal_tim.c</locationURI>
		</link>
		<link>
			<name>Drivers/STM32G4xx_HAL_Driver/stm32g4xx_hal_tim_ex.c</name>
			<type>1</type>
			<locationURI>Src/stm32g4xx_hal_tim_ex.c</locationURI>
		</link>
	</linkedResources>
	<variableList>
		<variable>
			<name>Src</name>
			<value>file:/D:/DataFiles/STM32Cube/Repository/STM32Cube_FW_G4_V1.4.0/Drivers/STM32G4xx_HAL_Driver/Src</value>
		</variable>
	</variableList>

Sorry for the delay, I‘m currently working on another project that takes all of my spare time.
But the error message says that the type of URI is one that I haven‘t seen before. To me it looks as if the HAL files have been copied into the Workspace (which shouldn‘t happen). Is there an option in the new version of the STM32CubeIDE that does this, and if so, could you try and turn it off?
My other project will need another 2-3 weeks until I can come back and look at this…

The files are definitely not copied into the project folder; however, the default repository is on my D:\ drive, and the project folder is on C:\ in my example.

Ok, the other project took a bit longer...
I now had the time to update the whole toolchain, both STM32CubeIDE and PlatformIO to the current versions, and I have no problems building. The entries in my .project file look like this:
<link>
	<name>Drivers/STM32F4xx_HAL_Driver/stm32f4xx_hal.c</name>
	<type>1</type>
	<locationURI>PARENT-6-PROJECT_LOC/Users/jbaumann/STM32Cube/Repository/STM32Cube_FW_F4_V1.26.2/Drivers/STM32F4xx_HAL_Driver/Src/stm32f4xx_hal.c</locationURI>
</link>

Currently, I'm matching on PARENT-(\d+)-PROJECT_LOC(.*)$ to identify the prefix that I change. The changed value is the path to the STM32 repository.
In your case it looks as if the IDE has created an additional variable that is then used as a prefix. In my tests the IDE does not do this.
How did you create the project? Could you provide me with a simple step-by-step description? I would like to understand this before I try to add functionality to cope with this case.

It seems the problem no longer exists. Closing the issue.


[CHART] Support user modifying ingress path/pathType

Issue:  https://github.com/rancher/rancher/issues/48167

Problem

Rancher's helm chart hardcodes the .spec.rules[].http.paths[].path to "/" and .spec.rules[].http.paths[].pathType to ImplementationSpecific in the ingress crd. It is common practice in other helm charts to allow the user to modify these 2 spec parameters in the values.yaml. The reporter in Issue https://github.com/rancher/rancher/issues/48167 reported:

on GKE, ingress path should be set to "/*" not "/" .

Solution

PR adds .Values.ingress.path and .Values.ingress.pathType to the ingress template and values.yaml making these parameters configurable while keeping the current default.
Testing

Ran the helm-unittest.sh script with no errors.
% ./dev-scripts/helm-unittest.sh
==> Linting ./

1 chart(s) linted, 0 chart(s) failed

### Chart [ rancher ] ./

2024/12/18 17:53:02 warning: skipped value for rancher.webhook: Not a table.
2024/12/18 17:53:02 warning: skipped value for rancher.fleet: Not a table.
 PASS  Test ConfigMap	tests/configmap_test.yaml
 PASS  Test Deployment	tests/deployment_test.yaml
 PASS  Test Ingress	tests/ingress_test.yaml
 PASS  Test Issuers	tests/issuer_test.yaml
 PASS  Test persistentVolumeClaim	tests/pvc_test.yaml
 PASS  Test Service	tests/service_test.yaml

Charts:      1 passed, 1 total
Test Suites: 6 passed, 6 total
Tests:       112 passed, 112 total
Snapshot:    0 passed, 0 total
Time:        240.076583ms

Updated 2 paths from the index

Engineering Testing
Manual Testing

Automated Testing

Test types added/modified:

Unit
Integration (Go Framework)
Integration (v2prov Framework)
Validation (Go Framework)
Other - Explain: EXPLAIN
None
REMOVE NOT APPLICABLE BULLET POINTS ABOVE

If "None" - Reason: EXPLAIN THE REASON

If "None" - GH Issue/PR: LINK TO GH ISSUE/PR TO ADD TESTS

Summary: TODO
QA Testing Considerations

Regressions Considerations

TODO
Existing / newly added automated tests that provide evidence there are no regressions:

TODO

Added helm-unittest for non-default path/pathType. Result from unit test script below.
rancher % ./dev-scripts/helm-unittest.sh
==> Linting ./

1 chart(s) linted, 0 chart(s) failed

### Chart [ rancher ] ./

2024/12/19 16:56:27 warning: skipped value for rancher.webhook: Not a table.
2024/12/19 16:56:27 warning: skipped value for rancher.fleet: Not a table.
 PASS  Test ConfigMap	tests/configmap_test.yaml
 PASS  Test Deployment	tests/deployment_test.yaml
 PASS  Test Ingress	tests/ingress_test.yaml
 PASS  Test Issuers	tests/issuer_test.yaml
 PASS  Test persistentVolumeClaim	tests/pvc_test.yaml
 PASS  Test Service	tests/service_test.yaml

Charts:      1 passed, 1 total
Test Suites: 6 passed, 6 total
Tests:       113 passed, 113 total
Snapshot:    0 passed, 0 total
Time:        242.085ms

Updated 2 paths from the index


packet 0.2.2

https://github.com/rancher/rancher/issues/23476

@luthermonson did you try testing out if packet still works after this change?

do not merge this until UI and testing is done, this is just a PR to get us the new binary/shasum

https://github.com/rancher/rancher/issues/23279


Reduce dependencies on FXGL internal properties

Some places e.g. AssetsCache directly access system properties from FXGL. Better approach would be to take a dependency in the ctor.

while dep in ctor is still the preferred approach, we don't care too much about internal props since we can bind them, even for testing.


Update RPC types to have consistent status key

Currently, the subscribeLnReceive and subscribeLnPay functions return a status with the following types:
type LnPayState =
  | 'created'
  | 'canceled'
  | { funded: { block_height: number } }
  | { waiting_for_refund: { error_reason: string } }
  | 'awaiting_change'
  | { Success: { preimage: string } }
  | { refunded: { gateway_error: string } }
  | { unexpected_error: { error_message: string } }

type LnReceiveState =
  | 'created'
  | { waiting_for_payment: { invoice: string; timeout: number } }
  | { canceled: { reason: string } }
  | 'funded'
  | 'awaiting_funds'
  | 'claimed'

This makes pattern matching a bit ugly for the SDK because objects and strings are mixed.
Let's changes the types to have a consistent shape:
type LnPayState =
  | { status: 'created' }
  | { status: 'canceled' }
  | { status: 'funded'; block_height: number }
  | { status: 'waiting_for_refund'; error_reason: string }
  | { status: 'awaiting_change' }
  | { status: 'Success'; preimage: string }
  | { status: 'refunded'; gateway_error: string }
  | { status: 'unexpected_error'; error_message: string }

type LnReceiveState =
  | { status: 'created' }
  | { status: 'waiting_for_payment'; invoice: string; timeout: number }
  | { status: 'canceled'; reason: string }
  | { status: 'funded' }
  | { status: 'awaiting_funds' }
  | { status: 'claimed' }

@maan2003

this is not possible, because fedimint commits to the first json representation in the database :/
if we change it, fedimint client will become backwards incompatible

Could we just transform the shape before returning it to the caller?
If not, I'll just do that in the javascript

feel free to do it on javascript, I don't want yet another RpcLnPayState(MaybeLoading) in rust.


Bump packages prod to latest version

Issue #, if available:
Bump packages prod bundle to latest version.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

/lgtm


Add support for Angular 1.6

Hi @Naimikan ,
Currently the bower dependencies support only angular 1.5
"dependencies": {
  "angular": "~1.5.8"
}

But from what I tested, angular-mapboxgl-directive library works well with angular version 1.6.3,
So maybe it is possible to change bower.json dependencies like so:
"dependencies": {
  "angular": ">=1.5 <1.7"
}

Thanks.

Hi @idanb11!
Thank you for the tip!


Update GHA tokens

RFC Title
RFC Preview Link
Comment Period End Date

LGTM; please make sure to remove the previously used secret (PLATFORM_ARCH_GHA) from the repo as it is no longer used anywhere else in the repo

secret removed, PAT deleted :D


Full support for Transform3D archetype in Python

[x] Code is generated successfully
[x] There's a unit test in place making sure that all possible constructors work now and tomorrow
[x] The archetype has been backported to the existing SDK

[x] log_transform still works
[x] log_any(rr.Transform3D) works as well

[ ] test_api has been updated to make use of both log_transform and log_any based on a flag

Keep track of progress in:

#2639

Only thing left to do here is to update test_api, I'll do a PR in a moment.


[Tool] UT coverage report use merged code, no need to rebase

What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[x] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)


Avoid placeholder image in case of SDImageCacheTypeDisk or SDImageCacheTypeMemory.

I am using SDWebImageManager class to download the image and process it. When Image in disk or memory I get it instantly but its flickers for the moment as it sets placeholder first and then the image.
This is an issue when my app goes background and try to refresh the table view.
What I want is the image is in disk or memory then I don't want to set the placeholder instead I want to  set the image directly.
    SDWebImageManager *manager = [SDWebImageManager sharedManager];
    movieStoryCell.backdropImageView.image = [UIImage imageNamed:@"poster_placeholder_image"];
    [manager downloadImageWithURL:imageURL
                          options:SDWebImageAvoidAutoSetImage
                         progress:nil
                        completed:^(UIImage *image, NSError *error, SDImageCacheType cacheType, BOOL finished, NSURL *imageURL) {
                            if (image) {
                                if(cacheType == SDImageCacheTypeNone || cacheType == SDImageCacheTypeDisk) {
                                    [UIView transitionWithView:movieStoryCell.backdropImageView
                                                      duration:0.35
                                                       options:UIViewAnimationOptionTransitionCrossDissolve | UIViewAnimationOptionCurveEaseInOut | UIViewAnimationOptionBeginFromCurrentState
                                                    animations:^{
                                                        movieStoryCell.backdropImageView.image = [GSStoryModel resizeBackdropImage:image];
                                                    } completion:NULL];
                                } else {
                                    movieStoryCell.backdropImageView.image = [GSStoryModel resizeBackdropImage:image];
                                }
                            }
                        }];

you said that when the image is cached on disk or in memory then you get it instantly but it flickers.
however you have this:
if(cacheType == SDImageCacheTypeNone || cacheType == SDImageCacheTypeDisk) {
which animates with a crossdissolve animation when the image is cached on disk or not at all.
In your else (memory cache type) statement you assign the UIImageView without animation.

@mythodeia
If you look at afnetwork UIImageView cataogry. It takes care it very neat way.
So if you pass placeholder image to API, It will set only if image is downloaded from the web otherwise its sets the cached image directly. I do want to achieve the same thing here.
Eg. some check that can tell me that image is in memory or disk and I can avoid this line.
movieStoryCell.backdropImageView.image = [UIImage imageNamed:@"poster_placeholder_image"];

At this moment, I don't see this possible, as it is a trait of the framework to set the placeholder before querying the cache.


Update init.py

remove parameter 'options' in function generate, barcode = get(name, code, writer, options), as passing 'options' raises exception in Code128(code, writer, **options)

Do you have an example of failing code, or of what this change fixes?
This seems to work fine for me:
import barcode
from barcode.writer import ImageWriter

barcode.generate('code128', 'hi', ImageWriter(), '/tmp/1.png')

Doesn't seem to work when setting these kind of options={'module_width':4.0, 'module_height':10.0}

I believe this is the same error in issue #38

Finally figured it out. This PR breaks other types of barcodes. I've pushed a different change that also fixes this issue. Thanks for the PR though, that to it I found where the problem was! :cake:


Device dataclass fix

Added to Device dataclass memState, cpuState, cpuLoad, stateDescription

This issue was migrated from an old repository: https://github.com/CiscoDevNet/catalystwan/pull/36


When can this be a static page that has no backend component

Is your feature request related to a problem? Please describe.
There are plenty of free hosted products out there in the market for status page management. Such as instatus. We currently use one of these, and we don't have to run literally anything. And it is already free.
Describe the solution you'd like
We would love to host an static webpage ourselves such as kener, but it would have to completely fit in an S3 bucket. The generation of all other data for the site we would want to deploy with the website on incident updates.
Additional context
We never want to have to run a service. Alternatively, since we use AWS, we would be okay with an S3 bucket static website AND a Lambda Function that ran on a CloudWatch Schedule Rule that would update the bucket based on the feedback. Running a full container as well as SSR to accomplish this will never work for us.

This is am working. Also requested here https://github.com/rajnandan1/kener/issues/43


Wrongly transformed private field in nested class

Describe the bug
JS has a lexcial scope of private field, so any function and class inside a class could use the private field outside of it
Input code
No response
Config
No response
Playground link
https://play.swc.rs/?version=1.2.133&code=H4sIAAAAAAAAAz2NQQrDMAwE73rFQg6xL%2FpBD%2BlPVGO3BWEF26WU4r83MWl0EGh20AaVWrHgS8AkuGBOKc3bkcycHxgosb1KRhju9YDATcqp7BMsV9PIanfXHs%2FKk%2Fgj7PTfnTpRjm8szvMo4bVYs%2FZZI28fOYiqG4L%2FAQfD0aWdAAAA&config=H4sIAAAAAAAAA0WMWwoCMQxFtyL57p%2BoMHtwEaFmtNIXSUYsQ%2FduWgb8u49z7w5v8bDsUJGFeChpWfELC5BPKJ5DVXCGWbRiFOoOFPlJOhC5WBdLEfq3qTy2SONKW6VJXWHkIYe1HZyDIPcDVN7MU%2F7MzfwWm%2FkXl0Sn2xl6%2FwFhK12uqAAAAA%3D%3D
Expected behavior
Code could run
Actual behavior
throw a is not found
Version
1.2.133
Additional context
No response

Seems like scope tag for bugs is needed


Target folder expansion does not work

Using parameter --to=~/bin creates folder ~/bin in current folder instead of writing file to bin folder in home directory.

Duplicate of #74


Make Robyn more modularized

Hi, @sansyrox, I noticed the fixed Public RoadMap for issues and would like to make a few suggestions. Could we consider removing the default internal implementation of jsonify and instead modify it to an extension interface with additional extension modules to achieve better extensibility? I might need better performance and wish to replace the default orjson with msgspec. Since msgspec also includes validation features similar to pydantic, if we can combine these through abstract interfaces + extension implementations, it would result in a cleaner list of component dependencies compared to default integration. This approach would also avoid confusion caused by multiple libraries having overlapping functionalities. We could extend this into something like the following:

robyn-jsonify-orjson
robyn-jsonify-msgspec
robyn-serde-msgspec
robyn-serde-pydantic

Hey @i1619khz 👋
Yess, that is the plan 😄 Do you have a sample implementation in mind?

@sansyrox I prefer not to provide a default implementation, but rather by providing a wrapped library


feat(query-core): Expose retry error as failureReason

Added failureReason: TError | null to query as suggested here:
https://github.com/TanStack/query/discussions/4305
Open Question: Would it make sense to add this to mutations as well?

Open Question: Would it make sense to add this to mutations as well?

I would say so, yes.

Open Question: Would it make sense to add this to mutations as well?

I would say so, yes.

While implementing it I stumbled over:

failureCount was not documented for useMutation
failureCount implementation differs as it doesn't reset to 0 after a successful mutation, this led to not using the failureCount from the action but incrementing the one in the state

failureCount implementation differs as it doesn't reset to 0 after a successful mutation

I'd say this is a bug, isn't it? Why would the failureCount behave differently for mutations

@ardeora @DamianOsipiuk if you have some time, please take a look at the PR and let me know if you agree with the api decision

Looks good to me 👍

seems like the new test fails and there are also lint errors.

seems like the new test fails and there are also lint errors.

Oh I am sorry, I forgot to run prettier. Haven't setup format on save in this repo yet.
=> Fixed Tests and linting

Codecov Report
Base: 96.36% // Head: 92.27% // Decreases project coverage by -4.09% :warning:

Coverage data is based on head (4b47b01) compared to base (eab6e2c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4315      +/-   ##
==========================================
- Coverage   96.36%   92.27%   -4.10%
==========================================
  Files          45       87      +42
  Lines        2281     3558    +1277
  Branches      640      899     +259
==========================================
+ Hits         2198     3283    +1085
- Misses         80      259     +179
- Partials        3       16      +13

Impacted Files
Coverage Δ

src/core/onlineManager.ts

src/react/reactBatchedUpdates.ts

src/devtools/useLocalStorage.ts

src/core/mutation.ts

src/devtools/theme.tsx

src/react/QueryErrorResetBoundary.tsx

src/react/useIsFetching.ts

src/core/focusManager.ts

src/devtools/useMediaQuery.ts

...rc/createWebStoragePersistor-experimental/index.ts

... and 122 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Fix react18 concurrent mode drag glitch due to state inconsistency

fixes https://github.com/react-grid-layout/react-draggable/issues/698

Confirmed that it solved the same issue I was having when I upgraded to React 18.

This fixed an issue I was having when dragging an item very quickly across the screen.
As in #698, the dragged item would move progressively further and further away from the cursor proportionate to the dragging acceleration (which makes sense since this issue is caused by React 18 batching).
Thanks @erictheswift for investigating and fixing this!
LGTM

@STRML can we please get this on in? Thank you!

Assigning directly to state is a pretty bad habit.
That said, you are correct that this data is not used for rendering, so it shouldn't be on this.state at all! Instead, it should simply held as local variables on the component.
If you make that change, I'll merge it.


Cyrillic characters don't work

Regular expressions with cyrillic characters (e.g. [А-Я]{1,5}[а-я]{5,10}) don't work in the latest version. The last version it used to work in is 0.4.6.
This reproduces the issue: https://codesandbox.io/s/randexp-cyrillic-issue-2kcou

IMO this should be left as it is. People only need a minute of time to check the docs to understand what's going on.
It makes no sense if I explicitly specify character range on Randexp object and then see that my string does not follow the range I specified. A regular expression may come from anywhere; a Randexp instance is what I control and use and want my generated string to be in range of.

I'm leaning towards @michaelficarra in that the default range should be respected for predefined sets, but for custom non-negated sets like in the OP (e.g. [А-Я]{1,5}[а-я]{5,10}), could ignore the default range

Then why defaultRange is even needed, if some constructs in regexp can override it?

@1valdis That's ridiculous. If defaultRange is restricted to a through f, and I provide the regexp x, should it not produce anything? How about [x]? Or [xyz]? Or [x-z]? defaultRange should only affect "open" sets like . or [^a].

@michaelficarra if it was restricted by someone to a-f then it was done on purpose. For a-f it can be easily found: letters for hexadecimal numbers.  The regexp itself is not always something you write into code and control. The randexp.js instance however is.
I believe explaining that as "the default range of generated characters applies to whole regexp" is also simpler and more consistent than "the default range applies only to 'open' sets and negated groups, but not for predefined ranges".
And I don't understand what's the problem with one line of code randexp.defaultRange.add(0, 65535); if you want Chinese, Russian and others.


Allow subscripting of 'forms' variable in template.

forms.values() returns a dict_keys objects in Python 3, which is not subscriptable. Casting forms.values() to a list allows subscripting in the template (forms.0, forms.1 etc.).

This makes sense to me - @kennethlove?


Role Clarifications in /mafia dt

Created distinctions between:
Role Cop and Role Cop (Classic)
Red Goo and Red Goo (Cracking Idea)
Neapolitan and Vanilla Cop
Also clarified some roles and standardized how Idea Variant roles are listed.

If we are doing distinctions within /mafia dt, can we also implement Silencer and Silencer GI (since those are distinctly different)?


feat: bloom modificable for each material

As mentioned during wednesday's meeting i added a drag to manipulate the bloom intensity of each material, you can find it below the emissive texture. I have limited the value  between 0.05 and 1. For test it you can use the level 1. Remember that with F1 you can disable the bloom.

It's working, the only things I want to mention is that it seems the value is only take in account between 0 and 1 , over 1 there is no modificaiton. I don't know if this is the purpose (because you put it to 5 I tried with more but as I said over 1 nothing change)

i take a look

fixed @AlexisDieu


Tighten S3 bucket security

tfsec reports the following issues:

_forwarder.this_s3_bucket/main.tf
[aws-s3-block-public-policy][HIGH] - Resource 'module.web_bucket:aws_s3_bucket_public_access_block.this[0]' sets block_public_policy explicitly to false
[aws-s3-enable-bucket-encryption][HIGH] - Resource 'module.web_bucket:aws_s3_bucket.this[0]' defines an unencrypted S3 bucket (missing server_side_encryption_configuration block).
[aws-s3-ignore-public-acls][HIGH] - Resource 'module.web_bucket:aws_s3_bucket_public_access_block.this[0]' sets ignore_public_acls explicitly to false
[aws-s3-no-public-access-with-acl][CRITICAL] - Resource 'module.web_bucket:aws_s3_bucket.this[0]' has an ACL which allows public access.
[aws-s3-no-public-buckets][HIGH] - Resource 'module.web_bucket:aws_s3_bucket_public_access_block.this[0]' sets restrict_public_buckets explicitly to false

Hey @bryantbiggs, thanks, regarding control block - yes, after checking again it seems to be fine. web_bucket is just the name of the module where I call this module.

encryption is enabled by default (S3 AES256)

Using AWS default encryption key is generally discouraged, best practice is to use customer-managed keys, therefore it would be great if the module would allow specifying a customer-managed key. Ref: https://tfsec.dev/docs/aws/s3/enable-bucket-encryption/


need quizes for all the modules you own

Andy, you can check telemtry or traffic mgmt for an example.

This has been fixed. Issue can be clsoed.

Closing per @nilesh32's request


added group tabs for launch in using cpp parameters

node_name and node_executable in launch_ros.node are deprecated in Foxy. I added a group tab to add the name and executable in Foxy tab in Using-Parameters-In-A-Class-CPP.rst

The linter was showing an error for indentation using tabs (you can see this yourself if you hit the "Details" link at the far right end of the line right under the big red "All checks have failed", and then scroll down to line 336 of the Job Log.) I pulled your branch and re-did it, though I'm not sure what caused the error in the first place. Anyway, thanks!

I see. I will make sure next time. Thank you!


coff: cryptopp.lib crashes

2022-11-29 14:21:49 [WARN ]  get_reachable_blocks: address is not a basic block: 0x2000a00d
2022-11-29 14:21:49 [WARN ]  get_reachable_blocks: address is not a basic block: 0x20053000
2022-11-29 14:21:49 [WARN ]  get_reachable_blocks: address is not a basic block: 0x20056000
2022-11-29 14:21:49 [WARN ]  get_reachable_blocks: address is not a basic block: 0x20059000
2022-11-29 14:21:49 [WARN ]  get_reachable_blocks: address is not a basic block: 0x200c5000
2022-11-29 14:21:49 [WARN ]  get_reachable_blocks: address is not a basic block: 0x2012c00d
2022-11-29 14:21:49 [WARN ]  get_reachable_blocks: address is not a basic block: 0x2013100d
2022-11-29 14:21:49 [WARN ]  get_reachable_blocks: address is not a basic block: 0x2013600d

Backtrace omitted. Run with RUST_BACKTRACE=1 to display it.
Run with RUST_BACKTRACE=full to include source snippets.

The application panicked (crashed).
  no entry found for key
in core/src/analysis/cfg/mod.rs, line 551
thread: main

fixed in 7f42ec5214a378db3fb880941f9794603b124611


[Obsidian] Menu Bar stopped working

Extension
https://www.raycast.com/KevinBatdorf/obsidian
Description
Error:
SyntaxError: Unexpected end of JSON input

Ef:obsidianMenuBar.tsx:8:33

---
 5: import { getObsidianTarget, ObsidianTargetType, useObsidianVaults, vaultPluginCheck } from "./utils/utils"

### Steps To Reproduce

1. Activate the Obsidian Menu Bar in settings
2. See the exclamation point on the menu bar
3. Click it and see the error

### Current Behaviour

This was working until this morning. Now it won't work at all.

This is what it looks like:
![CleanShot 2023-07-14 at 10 56 06@2x](https://github.com/raycast/extensions/assets/7596032/4c61fccf-ac71-471f-b00d-f2747870f7dc)
<img width="772" alt="CleanShot 2023-07-14 at 10 57 08@2x" src="https://github.com/raycast/extensions/assets/7596032/c6c5d2ba-f2c0-41b8-8a29-3dbe2ab2cbce">

Tried reloading, restarting Raycast, deactivating and reactivating the extension. It still won't work.

### Expected Behaviour

It should continue working as before

The error is suggesting that data is malformed somehow. It might be hard for me to debug it without more information.

5: import { getObsidianTarget, ObsidianTargetType, useObsidianVaults, vaultPluginCheck } from "./utils/utils"

Could there be a copy/paste issue sharing the stack trace? This seems incomplete.
Maybe just clear the extension cache completely from the Raycast action panel? It won't delete anything in your vault.
If that doesn't work, share the stack trace or more of the error. I can walk you through debugging it too (clone, install, build etc) if you're interested.

The error is suggesting that data is malformed somehow. It might be hard for me to debug it without more information.

5: import { getObsidianTarget, ObsidianTargetType, useObsidianVaults, vaultPluginCheck } from "./utils/utils"

Could there be a copy/paste issue sharing the stack trace? This seems incomplete.
Maybe just clear the extension cache completely from the Raycast action panel? It won't delete anything in your vault.
If that doesn't work, share the stack trace or more of the error. I can walk you through debugging it too (clone, install, build etc) if you're interested.

It does look like there was an issue. I used the "Report Bug" option which I thought prefilled the full error, but apparently it doesn't. Here's the output from choocing "Copy Error"
SyntaxError: Unexpected end of JSON input

Ef:obsidianMenuBar.tsx:8:33

---
 5: import { getObsidianTarget, ObsidianTargetType, useObsidianVaults, vaultPluginCheck } from "./utils/utils";
 6:
 7: function BookmarkedNotesList(props: { vault: Vault }) {
 8:   const [notes] = useNotes(props.vault, true);
 9:   return (
10:     <MenuBarExtra.Submenu title={props.vault.name} key={props.vault.path + "Bookmarked Notes"}>
11:       {notes.map((note) => (
---

    at ray-menu-bar-extra-submenu
gs:index.js:20:27030
Tf:obsidianMenuBar.js:134:10573

I'm happy to help with debugging, too. I haven't worked directly with extension coding, but it's something I've been interested in learning :)

Given the updated stack trace, I tested using the Bookmarked Notes command and it worked OK. I don't have any notes bookmarked, though, so it only went through the create a new note path.

@KevinBatdorf I was able to stop the error by filling in the "Path to Vault" setting in the main extension settings. Interestingly, every other command seems to be working properly and pulling the vault info from Obsidian itself. This one was working until a couple days ago, too.

Thanks for that extra info. If the "Path to Vault" field is empty it will attempt to load the obsidian.json file from ${homedir()}/Library/Application Support/obsidian/obsidian.json and use the vault info from there.
For example
{"vaults":{"fc7a372760a58ff2":{"path":"/Users/kevin/code/brain","ts":1683469744872,"open":true}}}

Can you check if that file is corrupt or has something different?

That looks correct:
{
    "vaults": {
        "fa9d2a628d52e39b": {
            "path": "/Users/taco/Second Brain",
            "ts":<PHONE_NUMBER>328
        },
        "df499aacf486501b": {
            "path": "/Users/taco/Digital Garden",
            "ts":<PHONE_NUMBER>260,
            "open": true
        },
        "14c92d8a4debe957": {
            "path": "/Users/taco/Dropbox/Obsidian/Developer Apprenticeship",
            "ts":<PHONE_NUMBER>640
        },
        "fd8b033ab8b71e8e": {
            "path": "/Users/taco/Dropbox/Second Brain v0.1",
            "ts":<PHONE_NUMBER>861
        }
    }
}

Sorry for not following up sooner. I think I may have identified the issue. If the cache is undefined or null, the extension falls back to an empty string which would give that error.
I'll update that code, but since it works for you this way then you can leave things be anyway.


Restructure pd to eliminate the split between "X crates" and "X components"

Following the big refactoring in #488, we've ended up with a much better architecture for the Penumbra application logic, with an App that holds a bunch of Components; the Components access a common Overlay over the backing Storage, and expose Views that read and write data.
However, this means that we end up having a bit of a weird split between our crates that handle some area of the application logic, and the components that actually implement that logic in pd.  For instance, we have a stake crate that has staking-related structures, but the logic about validator state transitions is handled by the staking component in the pd crate.
It would be cleaner if we could have each component in a different crate, because:

we could avoid a split between the structures for that part of the logic, and the logic itself;
we could enforce privacy boundaries between components, by choosing whether or not to export a View trait from the component's crate;
we could enforce (non-cycles) of dependencies between components; if one component needs to use another component's data, it has to depend on that component's crate, and that can't be cyclic.

To do this, we'd pull out the current contents of the pd crate as follows:

Create a penumbra-storage crate that would have the Storage wrapper around RocksDB, as well as the Overlay type definition, and the OverlayExt trait that handles reading/writing domain and proto types.  The penumbra-storage crate would depend just on penumbra-proto to get the proto trait definitions.
Create a penumbra-component crate that would have the definition of the Component trait.  This crate would depend on penumbra-storage.
Move the staking component code into the penumbra-stake crate, and add a dependency on penumbra-component to penumbra-stake.
Move the ibc component code into the penumbra-ibc crate, and add a dependency on penumbra-component to penumbra-ibc.
Create a new penumbra-shielded-pool crate, dependent on penumbra-component and move the shielded pool component into it.
Change the pd code so that only the App is present, and built out of components from other crates.

This refactoring would be fairly mechanical, but obviously clobbers any work that touches any of the components or any of the other crates, so if we decide to do it, we should plan when to slip it in.

As written above, this doesn't work, because the Component trait needs the Transaction type, and the Transaction type uses actions from different crates (e.g. Delegation is from the stake crate, etc).
As a start, though, we can pull out the storage and the component traits.

The groundwork for this is done now; what's left is moving the IBC component and the staking components out into their crates:

[ ] Move the IBC component into the ibc crate;
[ ] Move the staking component into the stake crate;


Feature: Generic Power on / Power off

Will add details using new updated template

This can be contained in tests/test_power_restore.robot  however it would be good if we do separately ...

What are the list of test cases we are looking at here ? are we going to do as a separate test suite or extend the use case in one of the existing test ?

Will work on this.. to create a new suite to have only power on and off.. we can extend the generic use cases here ahead...

Code pushed for review..


Getting buggy when "Show app" set to "On Menubar"

Describe the bug
Not able to reach context menu in the left top. (worked with any other app)
Not able to go to settings in any way
No app icon in the menubar
Versions
Ray version: 1.0.2
spatie/ray package version:
spatie/laravel-ray package version (if applicable):
Laravel version (if applicable):
Media Library Pro version:
To Reproduce
Steps to reproduce the behavior:

Go to preferences
Set "Show App" to "On Menubar"
Close settings

Expected behavior
Icon added to menubar I guess?!?
Just the normal mac context menu, shown when focused (was visable before changing this setting)
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: MacOS Big Sur
Version 11.0.1

Additional context
When the auto update came, I had a change to go the the tips page. There was a link to the config on the "Tips" page, so I could set it back to "On Dock"

If the menubar icon contains a link to settings, the only problem is the icon not showing up.

If the menubar icon contains a link to settings, the only problem is the icon not showing up.

@pieterhielkema Could you update the app to the latest version (it should automatically update when launching), and see if this issue still occurs?
If the problem persists, I'll reopen the issue and investigate further.

@pieterhielkema Could you update the app to the latest version (it should automatically update when launching), and see if this issue still occurs?
If the problem persists, I'll reopen the issue and investigate further.


feature request: add grab strategies

Would it be possible to add the supported grab strategies to grab_images()? I noticed a corresponding annotation in factory.pyx.

Sure, it's just that I'm driven by my PhD and little short on time... I hope to take a look at it too. I personally like the iterator approach. However, one does not "know" when an iterator is not needed anymore in Python. So I might drop the iterator style API and expose something closer to the metal..

Oh, of course. Sorry for my impatience. I'll try to add the strategies myself. By now, the integration of the Basler camera into my existing application works quite well, thanks to PyPylon. There's only a little thread safety thing left but that's about PyQt. When I got this done I could make a small PyQt example GUI as a showcase for PyPylon. Anyways, I wish you success with your PhD. :thumbsup:

Unfortunately I'm not able to add the grab strategies myself. @RichardLangFromNZ, would you be willing to do this?

Looks like we need this for the work we're trying to do, so will probably be able to put some time into it and push something back fairly shortly

Fix in https://github.com/mabl/PyPylon/pull/23

@RichardLangFromNZ
Thanks! Cool! Thanks again! :+1:


mongodb: Properly return json workloads

Golang switches don't fall through (and typeswitches don't allow the fallthrough keyword).

Thanks! LGTM


Rebuild with autoconf 2.71

Automake is a build tool. It must be updated with other build tools:
autoconf https://github.com/AnacondaRecipes/autoconf-feedstock/pull/1 -> automake -> libtool https://github.com/AnacondaRecipes/libtool-feedstock/pull/4
Actions:

Add set -xe command (print shell command before executing it and exit immediately if it fails)
Bump build number to 1
Add automake --version to test/commands
Update dev_url
Remove doc_source_url

Linter check found the following problems:
The following problems have been found:
WARNING: /tmp/abs_12sgbddcns/clone/recipe/meta.yaml:50: missing_doc_source_url: The recipe is missing a doc_source_url
WARNING: /tmp/abs_12sgbddcns/clone/recipe/meta.yaml:50: missing_license_url: The recipe is missing a license_url
Warnings were found

Linter check found the following problems:
The following problems have been found:
WARNING: /tmp/abs_d0hs1ehp40/clone/recipe/meta.yaml:50: missing_doc_source_url: The recipe is missing a doc_source_url
WARNING: /tmp/abs_d0hs1ehp40/clone/recipe/meta.yaml:50: missing_license_url: The recipe is missing a license_url
Warnings were found

Linter check found the following problems:
The following problems have been found:
WARNING: /tmp/abs_7bej7fucsy/clone/recipe/meta.yaml:50: missing_doc_source_url: The recipe is missing a doc_source_url
WARNING: /tmp/abs_7bej7fucsy/clone/recipe/meta.yaml:50: missing_license_url: The recipe is missing a license_url
Warnings were found


ionic conference app got blank screen in iOS 10

Hi, the ionic conference app doesn't work in iOS 10, blank after splash screen. 9.3 is OK.

Looks okay to me on my iOS 10.0.1 on my iPhone 6. How are you opening the application? I'm using Ionic View.

This issue was moved to driftyco/ionic-conference-app#251

Hello, thanks for using Ionic! As this issue is related to the conference app and not the framework I have moved this issue to the appropriate repo.

+1


Zuul testing

This should not be merged. Run npm run test:zuul:local and then open http://localhost:8080/__zuul.
History goBack/goForward failing.

window.location.href is commented out (from beforeEach) because it is causing Cannot GET / in browser. Maybe someone can advise how to fix that? #5

Ok now is hash history fully passing tests. With #3 it seems that all tests are passing.

I added "complex" test for states and goBack/goForward because I found bug when integrating to routex.
replaceState was acting like pushState in MemoryHistory. Now it is fixed but HashHistory and BrowserHistory are failing.

Ok now are all tests passing. You can close #3 in favour of this PR because I added same fix here.

Awesome! I was going to do this exact thing this morning! Now, instead of figuring all this out myself I can review your PR. :dancer:
(also, I invited you as a collaborator @michalkvasnicak)

Happy to see you working together!

Thank you for invitation. :) I am glad I helped.

I'm still not 100% sure that zuul is the best option for testing (see the discussion in #5) but it sure is better than what we have with jsdom so let's go ahead and merge. I'm going to keep working on getting a webdriver-based stack going, but this works great for now.
Thanks again for taking this on @michalkvasnicak! I'll give you the pleasure of pushing the merge button whenever you think you're ready :)

Sorry, just couldn't wait :)

It's ok, here is UTC+02:00 so I was sleeping :D


Add cut button for bounding boxes

I offer add cut button to cut all bounding boxes into little images.
It can be useful when you need big annotated images and simple little images both.
So you dont need to do double work.

I don't understand what you're asking for...can't you just duplicate the bounding box and then resize it was needed? Can you provide an example of what you're trying to annotate?

Ok. I use Nvidia DIGITS object detection which requires annotated images. But also i want use TensorFlow which require simple images.
For example i have an image with selected faces:
I can load it to the nvidia digits.
But also i need images like this:

I can load it to the TensorFlow.
So my idea is very simple: add button 'Cut' which creates folders by class names and put selected areas inside.
For example: we have 3 faces and 5 legs on the image, so if we press 'Cut' it creates two folders - "legs" and "faces" with 5 and 3 images inside correspondenly.

Thanks for the clarification, but I don't think would be a practical feature. It seems like it would be a hassle to constantly click the 'Cut' button for every image you annotate. I wrote a script a while ago that does what you're looking for, but for all annotations in the train and val folders, at one time. I've uploaded it here: https://gist.github.com/vdalv/7aaf8a090a6111184d6b6438a6847669

Thanks for the clarification, but wouldn't it make more sense to 'cut' all the images you want, at one time? I think that it would be a hassle to constantly click the 'Cut' button for every image you annotate...
I wrote a script a while ago that does what you're looking for, but for all annotations in the train and val folders, at one time. I've uploaded it here: https://gist.github.com/vdalv/7aaf8a090a6111184d6b6438a6847669

Thanks! If you dont plan add 'Cut' or 'Cut all' button then close this issue.


Clarify flagging procedure

The readme says "Non-mature packages should be flagged as such". This sounds a good idea, but I think the odds of it being done are very low if it's not suggested how to do this. I recommend changing the wording to "Non-mature packages should be flagged as such by ..."
Small change, but I imagine that would make a big difference if you want people to actually do that.

I assume the flagging procedure is done by opening an issue here. So that's my PR tries to clarify


Update event-hubs constants.ts to match package.json

Fixes live tests

/azp run js - eventhubs-client - tests

It looks like the CI is still failing on the IotHub connection string (node and browser version). Is it set to use the event-hubs compatible endpoint?

@chradek: I will merge this PR since the constants issue is fixed in the live tests.  I will then fix the secrets for iothub and re-run tests against master, since this is unrelated to this PR.


Drag a link from a web page or from the address bar does not work

Drag a link from a web page or from the address bar does not work. I am using HS 10.13.5 and Safari 11.1.1
Link to a screen Video HERE:
https://send.firefox.com/download/1fcafad596/#y3le5lrVgB91QbW9yQWzZQ

Thank you so much for the report.  Two bugs in there.  The first one is unreported, I'll get working on it.  The second one is tied into the fact that the function which pulls down favicons automatically stopped working, which is related #49

I am glad you identified those as bugs :).
Looking forward to the update of this very useful extension. Thanks for your work.


Update README.md

Pull Request
Related Issues:
[List any related issues or reference them using the syntax #issue_number.]
Fixes #issue number
Description:
[Provide a brief description of your changes.]
Note: Do [x] to select the below checkbox
Checklist:

[x] I have tested my changes.
[x] My code follows the project's coding standards.
[x] I have updated the documentation (if applicable).

Screenshots:
[If applicable, include screenshots to help reviewers understand your changes.]
Additional information
Please provide any other information that you think may be relevant to the pull request.

Added a Table of content with some suggestions that you might want to add such as screenshots, Troubleshooting, Deployment etc don't hesitate if you want me to help in anything


Change in logging frequency for automated logging

Bug description
Utilising Automated Logging with self.log and self.log_dict as described in the documentation results in a shift of the logging frequency after various amounts of steps.

This is also observed in all train metrics but only in the _step. It could be mutually exclusive to the WandbLogger but has already been observed to some extent in the TensorboardLogger as reported in #13525 and more generally in #10436.
How to reproduce the bug
Call self.log(, on_step=True, on_epoch=True) in training_step and let it run for more than 15k steps (in my case).
The logging rate initial is equal to log_every_n_steps=50 for some iterations but jumps wildly around for others.
batch_size=10 (specified in self.log(batch_size=10))
test_subjects=20
samples_per_subject=10
This equals to 200 samples per epoch and 20 steps per epoch. Even if log_every_n_steps=50, this should log then precisely every 100 steps (as the first 50 is not met according to my understanding) and not jump around from 2 to 200.
Environment

Lightning Component: Trainer/ LightningModule
Python 3.9
Pytorch-lightning 1.9.1 (installed with pip)
PyTorch 1.13.1
CUDA/ cuDNN: cuda11.6-cudnn8
OS: Linux (Kernel 3.10.0-1160)
Running environment: server

@nicoloesch could you provide a minimum working example? I was not able to reproduce the issue with your settings. Specifically, the following code works as expected (i.e. not showing any jump at around ~12k steps):
    class CustomModel(BoringModel):
        def training_step(self, batch, batch_idx):
            loss = self.step(batch)
            self.log("train_loss", loss, batch_size=10, on_step=True, on_epoch=True)
            return {"loss": loss}

    logger = WandbLogger()
    model = CustomModel()
    trainer = Trainer(max_steps=15000, log_every_n_steps=50, logger=logger, default_root_dir=tmpdir)
    trainer.fit(model)

My suspicion is that there is an interaction with the size of the training and validation sets, so maybe this could be included.

@baskrahmer Thanks for the reply! I have recently changed over to the automated self.log in combination with the torchmetrics implementation and also WandbLogger as opposed to TensorboardLogger. For background, initially I called the functional interface of torchmetrics and created my own dictionary that is logged - most likely, that is where the mistake is arising from (?). Since I changed over to the fully automatic logging with the class interface of torchmetrics, I have not observed the behaviour of my initial bug report. I am not sure if you want to keep the issue open for some time (maybe a month as I currently use it almost daily) and I comment under it as soon as I observe it again, or if you/I close this issue and I open a new one with a working example if it occurs again?
Cheers,
Nico


Fixed broken block by updating node-manager dependency

Changed som unrelated stuff at the same time.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Matthieu Vachon seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@clearloop

@clearloop

great! thanks!


About multilingual pretraining dataset

Hi! Thanks for your great work. Will the multi-language pre-training dataset (image caption) be made public?

Hi! The multilingual training dataset PangeaIns is already public at huggingface! :)

Thanks a lot. But the file cultural/laion-multi-1M/part_00 on huggingface is not a compressed package. How can I decompress it? By the way, is it only the "cultural/laion-multi-1M" portion that contains a multilingual caption dataset? Looking forward to your kind response~

Hi!
I added some instructions on how to decompress files like part_00 on huggingface. Basically, you would need to first combine the splitted tar files into one by cat part_* > images.tar, and then you could untar the file by tar -xvf images.tar
for captioning, "caption/STAIR-Captions" and "cultural/laion-multi-1M" contains multilingual caption data, while the other multilingual datasets are mostlly designed for more general purposes.

Thanks!


Doesnt run test, does not appear the "to do" list

Challenge Target the same element with multiple jQuery Selectors has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

jQuery Playground

#left-well

        <button class="btn btn-default target" id="target1">#target1</button>
        <button class="btn btn-default target" id="target2">#target2</button>
        <button class="btn btn-default target" id="target3">#target3</button>

#right-well

        <button class="btn btn-default target" id="target4">#target4</button>
        <button class="btn btn-default target" id="target5">#target5</button>
        <button class="btn btn-default target" id="target6">#target6</button>

When I try to run the test for this excersice, it doesnt appear the "to do" list below the "run test, help," etc. buttons, also it doesnt run the test (I belive the code is correct and it doesnt let me check that).
Help?

This is a duplicate of #9673; you have a capitalization error (addclass) that is causing the tests not to run correctly.
Note: you may need to refresh the page after correcting the error in order to allow the tests to run properly.
Happy coding!

It still doesnt let me correct the test and doesnt show me the "To do" list below that.
Is that normal? All other excercise show me that and allow me to run the test, but not that expecific one

@MTeresaArista Be sure to refresh the page. If it still doesn't work, use the Reset button and refresh again, then re-enter your code with the correct capitalization for addClass

Thank you! It works now :+1:
Have a nice day!

@MTeresaArista thanks for posting, @BKinahan thanks for your help. Closing this PR as resolved.


several UI improvements for dialogs, video messages, and the previewer activity

So the first change was fixing the padding and other spacing issues on a lot of dialogs. I probably missed a few but at least the most commonly used ones are fixed. The font preference wasn't displaying the currently selected font size, it is working now.
I also implemented the play icon I was talking about instead of using the filetype icons for image and video messages. This is what the iOS client does, and I also think it makes more sense for end users.
The last changes were in the MediaPreviewerActivity, which is now much more functional with some modifications to the glide calls. Small images and gifs are properly scaled to fill the screen, images with a transparent background are working, gifs will now play instead of just showing a thumbnail, and the UI looks more polished.

Hi @dkanada ,
Thanks for this new PR.
Can you please sign-off and touch CHANGES.rst please?
Also, CI report this error: ❌ Error: 'android\:text=\"[^@]' detected 17 times, last in file './vector/src/main/res/layout/dialog_phone_number_verification.xml'.
Why have you remove the tools namespace for example in a XML layout file? You can get more info on this here: https://developer.android.com/studio/write/tool-attributes
I will review the code soon.
Benoît

Signed-off-by: Dillon Kanada<EMAIL_ADDRESS>


big ol' rename

Thank you a lot for contributing to Cosmos Voyager!

Issue

closes: #519
Screenshots

❤ Thank you!

Needs more extensive testing. Let's not merge until there has been in-depth review.

Real comment though: it might be worth renaming PageDelegates to PageStaking to be less confusing for ourselves in the future.


Opening a ComboBox Flyout within another Flyout Closes all Flyouts

Describe the bug
Opening a ComboBox flyout itself nested in another flyout will close all flyouts and prevent making selections. Interestingly, this only seems to happen on the second opening of the ComboBox flyout.
This issue was not present until switching to Microsoft.UI.Xaml 2.2.190830001. Before that the app was using plain UWP.
Steps to reproduce the bug
Add a ComboBox to a Flyout. Clicking the ComboBox to make a selection the second time will close all Flyouts. (I didn't make a bare-bones repro of this but can if others can't see this issue).
Expected behavior
The ComboBox flyout should open normally and allow selections without closing other flyouts.
Screenshots

A custom templated control is pictured which allows selecting both a date and time from a flyout. The time selection is done using ComboBoxes. Setting the hour will work fine, however, as soon as the minute ComboBox is clicked all flyouts are closed.
Version Info

NuGet package version:
Microsoft.UI.Xaml 2.2.190830001 and 2.2.190917002

Windows 10 version
Saw the problem?

May 2019 Update (18362)
Yes

October 2018 Update (17763)
Not tested

April 2018 Update (17134)
Not tested

Fall Creators Update (16299)
Not tested

Creators Update (15063)
Not tested

Device form factor
Saw the problem?

Desktop
Yes

I don't know what could have changed in WinUI 2.2 to have cause this. @robloo Do you have a standalone repro that you could share?

@jevansaks I've made the small app attached to reproduce this issue. There appear to be multiple ways to cause it. It potentially has something to do with clicking between controls, the click speed, or bindings.
In the code-behind I am using techniques similar to what are used in the custom controls where this issue was first encountered. There are some work-arounds as 'clean' binding (like in WPF) can't be used to update the list of ComboBox items when a selection changes.... (that's been talked about a lot separately).
(1) Start the app (Debug or Release)
(2) Click the 'Open Flyout' button
(3) Select "12 hour clock" in the first (left) ComboBox
(4) Select an hour "11:00" in the second (right) ComboBox
(5) Very rapidly click a date in the calendar view 3-4 times (rapidly means at the speed of double click << 500ms)
(6) Click the left ComboBox to select "24 hour clock" -- as soon as the ComboBox dropdown flyout opens all flyouts close
This above steps reproduce the issue the vast majority of the time. There is a chance you will need to try it again though.

FlyoutTest.zip

Thanks for the repro! I can see that the flyout is closing because it's losing focus (presumably because it's being sent into the combobox flyout). I'm following up on if there's any work arounds for you here.

This was reported again in #1782 for the Windows magnifier app. Seems to be a fundamental issue with flyouts.

@kaiguo Please take a look

Any news on this? Since it affects even Microsoft's own apps I would expect it is high priority. It should not wait until WinUI 3.0 to be fixed.

This problem is very serious. I have developed a CMR App, the customer enters the data in Flyout and it closes losing all the data. Is it unacceptable to work with this problem when it is fixed?

@kaiguo did you get a chance to investigate this ? @llongley can you help diagnose this issue ?

xaml code for testing, is incredible problem, renders flyout control unusable!
    <Button Content="Click Me" Margin="50">
        <Button.Flyout>
            <Flyout Placement="Right">
                <StackPanel x:Name="stackContatto">
                    <TextBlock Text="click me, after select 2 in to the combo, after click me, and repeat." Margin="10,10,10,50" />
                    <ComboBox Margin="10" HorizontalAlignment="Stretch" SelectedIndex="0">
                        <ComboBoxItem>1</ComboBoxItem>
                        <ComboBoxItem>2</ComboBoxItem>
                        <ComboBoxItem>3</ComboBoxItem>
                    </ComboBox>
                </StackPanel>
            </Flyout>
        </Button.Flyout>
    </Button>

My solution for fix the problem, create a FlyoutBehavior and attach it to Flyout Control.
in the Behavior cancel the GettingFocus event of Popup.
protected override void OnAttached()
{
_flyout = AssociatedObject.Ancestors().OfType().FirstOrDefault(); ;
if (_flyout != null)
{
_popup = _flyout.Parent as Popup;
_popup.GettingFocus += _popup_GettingFocus;
}
}
    private void _popup_GettingFocus(UIElement sender, GettingFocusEventArgs args)
    {
        args.Cancel = true;
    }

@premiaware Thanks for posting the workaround and the small repro.
@robloo I can repro it with OS Xaml bits as well as WinUI2. Was this not the case for you ? If this is an issue with the OS Xaml bits, then the fix will have to wait for WinUI3.

@llongley it's probably a focus issue. When ComboBox closes the focus drifted to its parent popup. Adding a DropDownClosed event handler on ComboBox and forcing the focus onto ComboBox itself might be able to fix it.

@ranjeshj It could have been an OS XAML update that caused this. I just noticed it about the same time I switched to using WinUI. Really is a fundamental issue. I really hope after WinUI 3.0 we don't have to wait ages for stuff like this to get fixed. It's not sustainable for development.
@premiaware Thanks for finding and posting a work-around. At least that's a good start.

I have also come across this issue with just one simple flyout and a combo box using system XAML on Windows 11. Here is the code.
<Page x:Class="FlyoutCloseBug.MainPage" xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml">
    <StackPanel>
        <Button Content="Show flyout">
            <Button.Flyout>
                <Flyout>
                    <StackPanel MinHeight="100">
                        <ComboBox>
                            <ComboBox.Items>
                                <ComboBoxItem IsSelected="True" Content="Test"></ComboBoxItem>
                            </ComboBox.Items>
                        </ComboBox>
                    </StackPanel>
                </Flyout>
            </Button.Flyout>
        </Button>
    </StackPanel>
</Page>

Click on the button to open the flyout, click anywhere in the flyout except on the combo box, then click in the middle of the combo box and the flyout closes. Seems like a pretty bad bug. It seems to be related to the flyout scroll viewer somehow (but perhaps this is just a special case of some sort of focus issue). For example, a flyout without a scrollviewer in the template works fine.
<Page x:Class="FlyoutCloseBug.MainPage" xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml">
    <Page.Resources>
        <Style TargetType="FlyoutPresenter" x:Key="NoScrollFlyoutPresenterStyle">
            <Setter Property="HorizontalContentAlignment" Value="Left" />
            <Setter Property="VerticalContentAlignment" Value="Top" />
            <Setter Property="Template">
                <Setter.Value>
                    <ControlTemplate TargetType="FlyoutPresenter">
                        <Border Background="{TemplateBinding Background}" BorderBrush="{TemplateBinding BorderBrush}" BorderThickness="{TemplateBinding BorderThickness}">
                            <ContentPresenter Content="{TemplateBinding Content}" ContentTemplate="{TemplateBinding ContentTemplate}" ContentTransitions="{TemplateBinding ContentTransitions}" Margin="{TemplateBinding Padding}" HorizontalAlignment="{TemplateBinding HorizontalContentAlignment}" VerticalAlignment="{TemplateBinding VerticalContentAlignment}" />
                        </Border>
                    </ControlTemplate>
                </Setter.Value>
            </Setter>
        </Style>
    </Page.Resources>
    <StackPanel>
        <Button Content="Show flyout">
            <Button.Flyout>
                <Flyout FlyoutPresenterStyle="{StaticResource NoScrollFlyoutPresenterStyle}">
                    <StackPanel MinHeight="100">
                        <ComboBox>
                            <ComboBox.Items>
                                <ComboBoxItem IsSelected="True" Content="Test"></ComboBoxItem>
                            </ComboBox.Items>
                        </ComboBox>
                    </StackPanel>
                </Flyout>
            </Button.Flyout>
        </Button>
    </StackPanel>
</Page>

Also, if you put the scroll viewer inside the flyout's content instead of in the flyout presenter template, it also works fine.

If this doesn't occur in WinUI 3 I'm fine with closing it.

Please re open if this does still repro with WinUI3.

Definitely this issue also occurs in WinUI3,
microsoft.windows.sdk.buildtools 10.0.22621.3233
microsoft.windowsappsdk 1.5.240404000
Target framework: .NET 8.0

As shown in this gif I've got a DataGrid with a button column that shows a flyout. The flyout contains two comboboxes in order to let the user configure a parameter.
I cannot select any of the comboboxes values as the flyout is closed immediately.
Silly thing, if I insert just one empty row without fulfill the other columns comboboxes work (first attempt always missed)!


Changed go module path to match github repository

I'm unable to add the go bindings to a project because the module path doesn't match the require path.

Thanks!