WIP: rename same to deepEqual

Do not merge :-)
This is a work in progress PR just to get the conversation started. There are several tests that are failing and I could use some help there I think.
Thoughts?

And shall I just say that because the tests for this project are written in tap rather than AVA, I'm coming to appreciate AVA more and more :-) :heart:

Thanks for starting the conversation @kentcdodds :)

We'll definitely need a codemod if we're going with this.

Not to start a bikeshedding, but is there any other word we could use that might be even clearer?

Great to explore options for the best API possible while the topic is open for debate. I have no ideas though...

Here's an idea: what if t.same becomes t.is? Couldn't be clearer and shorter to type. And t.is gets removed in favor of t.true(a === b).
I use t.is only for primitive values and when I need to check that references are equal. t.same also handles primitive values, so the only benefit of t.is is checking reference equality.
What do you think?

I'd be fine with that.

I think the best criteria by which to judge is this:
If someone who has never used tap/AVA/chai/etc is reading the test, what gives them the best chance of understanding what the assertion does without looking at the docs. Part of this includes avoiding ambiguity where possible. If a word could mean two different types of assertions, that's a big knock against it (we won't reach perfection here, because English).
Short names should be low on the list of priorities. There is a limit at which something is too long, but a few extra characters is worth any added clarity.

Short names should be low on the list of priorities. There is a limit at which something is too long, but a few extra characters is worth any added clarity.

Couldn't agree more.
But I still have no suggestions to a better name than deepEqual :-)

Not to start a bikeshedding, but is there any other word we could use that might be even clearer?

Off of the top of my head, here's a couple of candidates (of varying degrees of suck);

t.sameStructure
t.distinctEq
t.reflect

t.reflection
t.reflectionOf

t.mirror

t.mirrorOf

t.comparable

t.comparableTo

t.represent

t.representation
t.representationOf

t.isomorphism

t.isomorphicTo

The ones that I do like to some extent would be sameStructure and comparableTo. Possibly distinctEq as well, even though it's somewhat of an oxymoron. Can probably bin the rest swiftly :smile:
I reckon sameStructure is the winner here. I find it very hard to misinterpret, and it conveys the intent of the assertion very clearly. I don't quite see it trumping deepEqual though. Just gotta keep crossing off those candidates I suppose..

Here's an idea: what if t.same becomes t.is? Couldn't be clearer and shorter to type. And t.is gets removed in favor of t.true(a === b).

I agree, in parts. It's ridiculously short to type, and I think opting for t.true(a === b) is a good way to go so there's that going for it. But I don't think t.is adequately conveys the intention of comparing two distinct objects of the same structure.
I'm sorry to say I don't have any better suggestions, aside from the list of verbose candidates in my first segment - along with deepEqual.
My dream scenario would be for the deepEquality assertion to die off entirely and we'd have something like t.true(Object.equals(a,b))
In all honesty, I find deepEqual hard to beat - purely based on the fact that it's "widely adopted". It's probably something most of us are already familiar with. If not, it's pretty easy to find out with a quick Google search as it's not widely adopted outside of computer programming from what I can find. same, is, and most of my suggestions above - are and could be.

My concern with t.is is what happens to users who fail to update current t.is assertions. We leave them open to subtle bugs. Also, it doesn't pass the disambiguation test.

Regardless which name we pick we should carefully document which values are considered passing and which aren't. E.g. #630 surfaced that we were requiring constructor equality.
I wonder if the "same" or "equal" part is implicit.
Given that, how about t.deep()?

Which would lead to t.strict() for t.is(), if we want to go that far.

how about t.deep()?

I still prefer deepEqual. To me it's confusing without equal.

I'm good with deepEqual.

We should really have a codemod for this change before releasing it. Anyone interested in trying to make one (I especially encourage community members to try)? Resources: https://github.com/sindresorhus/ava/issues/644

Anyone interested in trying to make one (I especially encourage community members to try)?

Looping in our AST friends: @twada @jfmengels

Whipped up a quick codemod for this: https://astexplorer.net/#/AbMVMKHZhp
I'm happy to put this in a PR. Where should I put the files? Perhaps in /codemods?

@spudly :+1:!
I'd create a new project containing the codemods (ava-codemods?). Don't see the value of putting it in the AVA project if it's only going to be run once at the very most.
There is talk about writing other (complex) codemods too in https://github.com/sindresorhus/ava/issues/644.

@spudly I improved your code a bit by providing support for notSame --> notDeepEqual (and some necessary refactoring to avoid duplicating) https://astexplorer.net/#/yXo9G9wx9m/1

@sindresorhus, @jamestalmage, @vdemedes, @novemberborn
Opinions about where to put codemods? I was thinking in /codemods but @jfmengels recommended a separate repo. I'll do whatever.

@jfmengels,
Looks good and nice refactor. Guess I forgot about notSame/notDeepEqual because I never use them...

See https://github.com/jamestalmage/ava-codemods.

@kentcdodds We now have a codemod, so this could potentially go into the next release. Would you be able to finish this up and fix the failing tests?

Could definitely use some help on this to know why tests are failing. It's confusing with mix of ava and assert :-)
I definitely want to make this happen soon! :D

Updated the deprecation to use util.deprecate (TIL) and added a note about the codemod repo. I'll try to give the failing tests another look, but last time I know I had a bit of trouble with them.

Alrighty, this should be ready to go I think. Feedback welcome!

Also, let me know if you want me to squash and clean things up with the commit message or if you're fine using GitHub's fancy new squash and merge feature :-)

We will use GH' squash and merge.

A few notes, mostly related to making sure we are deprecating t.same without breaking it.
Once those are cleared up, LGTM.

Updated PR to respond to @jamestalmage's comments. Thanks!

LGTM.

:shipit:!

Yay for better user UX. Thanks for nudging us towards this and doing the work @kentcdodds :)

Fantastic! Did we decided on doing truthy/falsy? I'm happy to do that work as well

Yes. We're going with that. PR super appriciated :)


Live

OPS Build status updates of commit 7696283:
:clock10: Preparing: average preparing time is 43 sec(s)

OPS Build status updates of commit 7696283:
:clock10: Incremental building: average incremental building time is 18 sec(s)

OPS Build status updates of commit 7696283:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/Downloads.md
:white_check_mark:Succeeded

windows-iotcore/Resources.md
:white_check_mark:Succeeded

windows-iotcore/TOC.md
:white_check_mark:Succeeded

windows-iotcore/learn-about-hardware/iotnxp.md
:white_check_mark:Succeeded

windows-iotcore/mDNS.md
:white_check_mark:Succeeded

windows-iotcore/media/mDNS/mdns1.png
:white_check_mark:Succeeded

windows-iotcore/media/mDNS/mdns2.png
:white_check_mark:Succeeded

windows-iotcore/release-notes/CurrentCommercial.md
:white_check_mark:Succeeded

windows-iotcore/release-notes/CurrentInsider.md
:white_check_mark:Succeeded

windows-iotcore/release-notes/Insider/17763.md
:white_check_mark:Succeeded

windows-iotcore/release-notes/Insider/RPi3BP.md
:white_check_mark:Succeeded

windows-iotcore/release-notes/commercial/17763.md
:white_check_mark:Succeeded

windows-iotcore/release-notes/commercial/October2018Update.md
:white_check_mark:Succeeded

windows-iotcore/tutorials/quickstarter/DeviceSetup.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Design purpose macro has to be locked after project initiation.

Because designed schedule has to be protected from someone accidentally pushing macro button.

This issue was resolved.


update broccoli deps

These are just the ones consumers of this add-on would get. Im sure some of the devDeps could also be updated but that is likely more involved.

😱 seems good!


Support bigquery DDL optional args

Listed all possible create/alter/drop commands, and keywords for bigquery. https://cloud.google.com/bigquery/docs/reference/standard-sql/data-definition-language
Will handle the other dialects later in a separate PR.
Also fixes the AS issue in https://github.com/sql-formatter-org/sql-formatter/issues/309.

Looks fairly comprehensive, thanks for the good work!

Merged in and released as 9.0.0-beta2


again: visualisation of (undefined/external) agents and activities

I have just (after a longer time) updated my prov package with the latest version of the master branch, and an issue is re-emerging that was covered in #118: Agents that are not explicitly defined, but just referenced (e.g. from documents outside the current prov document), are rendered as a grey oval, rather than a grey pentagon/house shape.
Is that intentional, or is there a way on how this is to be handled for external references to be displayed correctly? I was very happy with the solution as visible in the last comment on ticket #118.

The commit 93df6ea869bd1230651f5faf9c4a22534fcf219d shown in #118 is still in the dev branch and have not been merged into the master branch yet.
I'll include it in the next release.

Fixed and included in 1.5.3


test: Cypess | Oracle DS validations added (Part 5) + CI Stabilize

Description

This PR adds below:
Oracle - Delete table data validation
Deploy App & verify the deleted data
Bind query to already existing table widget, deploy, Filter table & verify
ServerSide/QueryPane/Mongo_Spec.js - flaky fix
Improved AssertPopoverTooltip - to handle both tooltip elements
Oracle - Copy, Move query validated Tc # 2363

Type of change

Script fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

[X] Cypress CI runs

Checklist:
QA activity:

[X] Added Test Plan Approved label after Cypress tests were reviewed

/ci-test-limit

/ci-test-limit runId=6234840955

/ci-test-limit


Test change to trigger CI

Unneeded now that https://github.com/cncjs/cncjs/issues/747 is resolved.


Fixed links in DSX install for new tutorial structure.

Can you please double check this, as urllib.request.urlretrieve requires raw format in this block of code
    # Try importing Qconfig module. If it doesn't exist, then download it from the qiskit-tutorials repo.
    try:
        import Qconfig
    except ImportError:
        urllib.request.urlretrieve ("{}".format(qconfig_template_path), "{}".format(qconfig_filepath)) ```

Thanks. I am checking it.

@nubbyOne  Thanks for pointing this. I have applied a hotfix by accepting this PR:
https://github.com/QISKit/qiskit-tutorial/pull/146


bug: format operator "=" not work

Did you check docs and existing issues?

[X] I have read all the vscode-neovim docs
[X] I have searched the existing issues of vscode-neovim
[X] I can reproduce the issue with an empty init.vim/init.lua and no other vscode extensions (when applicable)

Neovim version (nvim -v)
0.9.1
Operating system/version
windows10
Describe the bug
these format operation not work on vscode neovim Version 0.4.4
=ap
=ip
gg=G
...
only visual select then = works ...
Steps To Reproduce

normal mode and cursor at any paragraph, type =ap
when type a, it enters into insert mode ...

Expected Behavior
gg=G should format all text
=ap and =ip should format current paragraph

Works for me. Did you try with "clean" option? This is not a support forum.

yes, i have tried with empty init.vim and clean vscode.
I found that the key map "=" was changed since vscode neovim 0.4.0
I revert it to 0.3.2, then the operator "=" works well for me.

#1422
For now, you can add these to your init.vim
function! s:vscodeFormat(...) abort
    if !a:0
        let &operatorfunc = matchstr(expand('<sfile>'), '[^. ]*$')
        return 'g@'
    elseif a:0 > 1
        let [line1, line2] = [a:1, a:2]
    else
        let [line1, line2] = [line("'["), line("']")]
    endif

    call VSCodeCallRange('editor.action.formatSelection', line1, line2, 0)
endfunction

" Bind format to vscode format selection
xnoremap <expr> = <SID>vscodeFormat()
nnoremap <expr> = <SID>vscodeFormat()
nnoremap <expr> == <SID>vscodeFormat() . '_'


about-me: Provide a Windows version

Is your feature request related to a problem? Please describe.
I would like the consistency of having the "About me"-service also in the basic service-set on Windows servers.
Describe the solution you'd like
Port about-me to Windows or write a Windows version and add the service to the Windows service-set.
Alternatives
No response
Additional context
No response

Any updates on this?
An about-me version for Windows would be very useful.

You can help by looking at the output of the linux version and considering/telling us which command-line calls are necessary in Windows for each section (without tools to install).

Let me help you - to be more specific: To make about-me behave more or less the same on Windows as it does on Linux, we need to collect the following information using cmdline calls.
How to...

get Kernel/Windows version
get if running on bare metal or not
get the hypervisor software Windows is running on
get boot mode (uefi/legacy)
get birthday
get list of features (essential for safe operation of Windows in a datacenter)
get list of installed software (software of interest)
get list of installed tools (tools of interest)
get list of non-default local users
get whether Windows boots into GUI or not
get list of enabled services
get list of enabled task scheduler jobs

There may be others that are Windows-only and might be of interest.

Yes, I can gather some info on this.
I think we could get some hints from Ansible facts.
I will invest some time on this!


Try to modify the NMS code

I'm trying to change the threshold of soft-NMS and the way of reduction score, but I find that it involves nms.py in mmcv, I want to know how to modify it.

just modify the source file directly

直接修改源文件即可

I tried to modify the nms.py in mmcv,  but I found that it used the ext_module. It seems to encapsulate the method, and I don't know how to continue to find its code.
inds = ext_module.softnms(
boxes.cpu(),
scores.cpu(),
dets.cpu(),
iou_threshold=float(iou_threshold),
sigma=float(sigma),
min_score=float(min_score),
method=int(method),
offset=int(offset))

it's c++ code, in mmcv/ops/csrc/pytorch

it's c++ code, in mmcv/ops/csrc/pytorch

Thanks for your answer


Fixes #217: Fix regression of broken SafeString concatenation

This fix is working for me, however you may have an alternate implementation suggestion.

Any thoughts? I'd like to update to the 2.x Pebble releases but this bug is blocking me.

Thanks for the merge.  Would you be willing to deploy a point release with this fix?


[release/1.3] Avoid deadlock in unpacker.

Cherrypick #3825 to release/1.3.
Signed-off-by: Lantao Liu<EMAIL_ADDRESS>

Codecov Report

Merging #3834 into release/1.3 will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release/1.3    #3834   +/-   ##
============================================
  Coverage        45.59%   45.59%
============================================
  Files              116      116
  Lines            11465    11465
============================================
  Hits              5227     5227
  Misses            5338     5338
  Partials           900      900

Flag
Coverage Δ

#linux
45.59% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5ede20...a18acaf. Read the comment docs.

LGTM


Package control installing but not making actionable

Sublime Text 3 on macOS
I keep installing the package through package control and it shows up as installed but isn't usable. The snippetx.sublime-package file created is only 1.2Mb. I don't see a snippetx.sublime-package file in this repository. Is that something that is created after installation? Is there a way to manually install this plugin?

Hmm🤔 I'll test this out. What version of  OSX are you using?

MacOS high Sierra
On Fri, Nov 17, 2017 at 14:35 Colin Ryan<EMAIL_ADDRESS>wrote:

Hmm🤔 I'll test this out. What version of OSX are you using?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ColinRyan/SnippetX/issues/3#issuecomment-345344953,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGicHvdfLLR6Sh8g4pJ3fzTlGrzWHCXUks5s3eASgaJpZM4QA2wz
.

--
Brendan Ryan
Technical Services Librarian
Providence Athenaeum
251 Benefit St Providence RI 02903
C:<PHONE_NUMBER>


Initial pass at concepts

@MBishop17 ready for you!

Closed in favor of https://github.com/rancher/docs/pull/423 due to the failing CI build


fix: wrong pointer to "Nested Projections"

nested projections != postfix projections

actually there is no real documentation available for this feature. At least I didn't find an appropriate place to point at. We should add some documentation on this feature. For now, we should remove the wrong pointer.

what's wrong with that link?

Not sure why the job fails with:
´´´log
Found 3 broken link(s) to internal targets in 3 source(s):
in: /cds/cdl
Unresolved hash link: /cds/cql #nested-expands
in: /java/working-with-cql/query-api
Unresolved hash link: /cds/cql #nested-expands
in: /cds/cdl.html
Unresolved hash link: /cds/cql #nested-expands

I searched through the whole code base and there is not a single reference to `#nested-expands`


Docs for Gitpod

Setting and starting gitpod workspace

If we can get the LiveShare for Gitpod finished as per the pull request, I think that we can close it.

Closed by https://github.com/r-devel/r-dev-env/pull/178.


update for genesis timestamp

update genesis time stamp for berkeley

https://github.com/MinaProtocol/mina/pull/13522

CR sent and merged after approval.

1989
در تاریخ پنجشنبه ۶ ژوئیهٔ ۲۰۲۳، ۰۶:۲۸ vanarasi A @.***>
نوشت:

update genesis time stamp for berkeley
—
Reply to this email directly, view it on GitHub
https://github.com/MinaProtocol/mina/issues/13527, or unsubscribe
https://github.com/notifications/unsubscribe-auth/A64QIH2OWKFYF4RZJ3OJ6BLXOYSUBANCNFSM6AAAAAAZ7YGH2I
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Notifications are not working on Snack

Reported by @cruzach
running this snack on my device, the scheduled notifications don’t come through, but if I run the same code through expo-cli (same version of expo-notifications installed) they come through fine
https://snack.expo.io/@charliecruzan/push-notifications
oh you know what, I think this has to do with how we’re scoping the notifications
but this was definitely working before :thinking_face:

@byCedric this appears to be the same issue as https://github.com/expo/expo/issues/27334 . It is reproducible on SDK 50 but not on SDK 49.


Delta time (dt) variable inside pose_system.hpp

I am a little confused as to how did you choose dt as 0.01?
https://github.com/koide3/hdl_localization/blob/master/include/hdl_localization/pose_system.hpp#L21
Imu frequency is 200 Hz
I guess dt should be equal to (1 / imu_frequency)
Thank you in advance

Yes, you are correct, and dt will be updated based on the last and current data timestamps.
https://github.com/koide3/hdl_localization/blob/1cdef711d66fdb4ec8969623dd2568eb3f45ce25/src/hdl_localization/pose_estimator.cpp#L66


Refactor clear-cache to use GenericForm

This PR refactors the clear-cache message to use the GenericForm component. Note that the customData property was commented out with a TODO, as with all the other customData in the other components. Removing customData results in a bare drawer, but otherwise the functionality is the same (clear cache will be invoked).

I do want to note that we can also utilize the exec part of execOrRender to trigger the clear cache request right away without showing the Drawer with the blank form and a submit button

I do want to note that we can also utilize the exec part of execOrRender to trigger the clear cache request right away without showing the Drawer with the blank form and a submit button

ooooh okay very neat, did not realize that! noted for the next message if it happens to also be a blank drawer after removing customData temporarily.


travis: test with most recent minor go version

Just doing this for consistency with other cloud clients (which i'm updating atm to add 1.9).
Feel free to reject if you disagree.

Thanks! This is better. Could you add 1.6.x back in while you're there?


TODO list

The ability to keep a list of things you want to print.

Favourites, todos, and other functionality might all be added easily with https://github.com/jonhue/acts_as_favoritor


I need some help with an issue regarding enumerations in Flask.

I need some help with an issue regarding enumerations in Flask.
My model is as follows:

class ApprovalStatus(PyEnum):

PENDING = 'pending'

APPROVED = 'approved'

REJECTED = 'rejected'

class Approval(db.Model):

id = db.Column(db.Integer, primary_key=True)

content_type = db.Column(db.String(50), nullable=False)

content_id = db.Column(db.Integer, nullable=False)

field_name = db.Column(db.String(50), nullable=False)

new_value = db.Column(db.Text, nullable=False)

status = db.Column(SQLAlchemyEnum(ApprovalStatus), default=ApprovalStatus.PENDING)

submitter_id = db.Column(db.Integer, db.ForeignKey('user.id'), nullable=False)

submit_time = db.Column(db.DateTime, default=current_time)

reviewer_id = db.Column(db.Integer, db.ForeignKey('user.id'))

review_time = db.Column(db.DateTime, default=current_time)

review_comment = db.Column(db.Text)

submitter = db.relationship('User', foreign_keys=[submitter_id])

reviewer = db.relationship('User', foreign_keys=[reviewer_id])

__table_args__ = (UniqueConstraint('content_type', 'content_id'),)

[u/property](https://www.reddit.com/user/property/)

def content(self):

model = getattr(models, self.content_type)

return model.query.get(self.content_id)

However, I keep encountering the following error:

LookupError: 'pending' is not among the defined enum values. Enum name: approvalstatus. Possible values: PENDING, APPROVED, REJECTED

I have already queried the database, and all the enum values in it are lowercase. However, theoretically, no matter what I change the name on the left side of the enum to, it should not affect the operation of the database. But in reality, now I can only run normally if I keep both sides of the enum in consistent case.

Please post correctly indented Python code, that's not been copy-pasted from what looks like a reddit post. You also failed to include the full traceback of your exception.


Muxers created in seperate function

Am planning this to streamline the code and for future unit testing.

Gonna go ahead and merge this straightaway because this could interfere with other people's PR's in the future pretty nastily.


refactor!: remove gg20 support

AXE-2327

[x] Requires merging this PR and updating the proto submodule to point to it

shall we remove gg20 from https://github.com/axelarnetwork/grpc-protobuf/blob/5fa83fe0dbe1463f756348fa48116c7b69564a2f/grpc.proto too?

Yep, already removed in this PR:
https://github.com/axelarnetwork/grpc-protobuf/pull/14


docs(headers): add examples

Added examples for all common header types.
Further work could be done to add descriptions around the examples, or the equivalent string representation of the headers, but this is a start.
If there is an Extension for the header enum type, I've tried to specifically include an example of it.
Fixes #468

:dancers:


[FEA] Simplify API for adding ops to a workflow

Is your feature request related to a problem? Please describe.
After a few offline discussions (and my own personal experience), I feel that the current add_preproc/add_feature API is  causing unnecessary confusion for new users.   For example, it seems a bit confusing that add_preprocess should be used to add DFOperators (which have 1+ StatOperator dependencies), *unless those ops are transforming columns that do not exist in the raw dataset.  Overall, I don’t think there is a real need for two different APIs at all.
I suggest we consolidate the API to a single add_operators (or something like that), and deprecate the existing API in a future release.
Describe the solution you'd like
A consolidated API for adding all operator types (like add_operators).  Operator-dependencies can still be captured by adding a list of ops as a single pipeline.
Describe alternatives you've considered
The obvious alternative is to carry on with the existing API.  This is fine, but likley to cause confusion for new users.

This should be handled by the API overhaul (#472)

New API is merged ! We no longer have add_preprocess / add_feature anymore

New API is merged ! We no longer have add_preprocess / add_feature anymore


Possibility to integrate with existing authentication provider

Hello nHost team, thanks for the great product!
But may I know if it's possible to reuse any existing authentication provider for the JWT authentication in hasura? For example, can I also support Firebase for authentication in addition to nHost auth?
https://hasura.io/docs/latest/graphql/core/auth/authentication/jwt/#introduction
Currently, the system doesn't allow me to set the HASURA_GRAPHQL_JWT_SECRET ENV, which is how hasura adds a JWT authentication.

As far as I knew, NHost is not exposing this environment variable (HASURA_GRAPHQL_JWT_SECRET) if NHost exposes this variable, that will be a huge win-win for the existing projects also opens the doors for integrating NHost with some of the Authentication providers like Super Tokens and Clerk

I think this would be awesome to allow support for Clerk.

With Clerk, I know it is setting the HASURA_GRAPHQL_JWT_SECRET like this
{"jwk_url":"https://<YOUR_FRONTEND_API>/.well-known/jwks.json"}

I think the hard part for something like clerk, is we would want to keep using clerk because of some of the features it supports around their session management. Would it make sense to put those as feature requests?

Hi @elitan , What exactly I need is to edit the value inside the session variable NHOST_JWT_SECRET so that it will allow the developers to decouple the current offering of NHost (i.e. Auth + Hasura & Database) and bring their own Auth (i.e. Clerk or Super Tokens etc) and use the Hasura & Database part from NHost
Currently, NHost auth is connected to the Hasura via type, key combination. However, there is one more way to bring the Auth is via jwk_url and this can also be easily set up by editing the --jwt-secret inside the docker setup. So if you allow setting this up either via Dashboard or manually editing that can offer a smooth transition to the developers who would prefer choose the decoupled architecture.
Any Thoughts?

Make sense. Relevant issue here: https://github.com/nhost/hasura-auth/issues/123

Hi @elitan would you consider this option any time soon? i.e. exposing the HASURA_GRAPHQL_JWT_SECRET via NHost dashboard? so that I can bring the jwk (looks like below) and have Clerk integrated with NHost
I am also okay if you manually edit the docker file and set this on
--jwt-secret
{"jwk_url":"https://<YOUR_FRONTEND_API>/.well-known/jwks.json"}
Any thoughts? this kind of feasibility will open the doors for developers to bring their own Auth

Hello @elitan ! I have the exact same issue. I was looking for a way to integrate Outseta with Nhost, and to my surprise HASURA_GRAPHQL_JWT_SECRET  isn't available for modification.

Hello @elitan ! I have the exact same issue. I was looking for a way to integrate Outseta with Nhost, and to my surprise HASURA_GRAPHQL_JWT_SECRET  isn't available for modification.

I think we should allow editing the JWT secret to allow integration with other providers. I'll add that to our near-term road map.
Our goal with Nhost is not to only work in isolation, but to work with other services too that might work better for your use case.
In the meantime, if you need us to change the JWT secret, we can do it manually. Please reach out to<EMAIL_ADDRESS>and we'll make it happen.

We will be working on this pretty soon so that you are able to set NHOST_JWT_SECRET with a key from elsewhere.

Hello bcdrme, venkata-penumatsa & others. This feature is ready to be tested, please contact me at<EMAIL_ADDRESS>so we can do a step-by-step guided integration and see if we need to make something clearer or fix any bugs :+1:

It's now possible to change the JWT Secret in the Nhost Dashboard:

Hi @guicurcio @elitan I just tested this feature. I put my own jwk url inside the NHOST JWT SECRET and tried sending a GraphQL query from my Next JS app, but I got the following error.
Could not verify JWT: JWSError JWSInvalidSignature
This is how my setup look like. I would like to pass the JWT from Clerk

Hello @venkata-penumatsa ! I'm using Clerk as well.
Jwks are apparently unsupported for now, setting a jwks as en environnement variable will break nhost (happened to me this week).
What you can do however is setting a JWT using the following format
{"type": "HS256", "key": "<MY_CLERK_JWT>"}
Replace the key with what you can find in Clerk
Dashboard > API Keys > JWT Verification Key
You don't need to use their jwk as explained here : https://clerk.dev/docs/request-authentication/validate-session-tokens#instructions

@bcdrme Hi Thanks for the details. I will work on this and get back.

@bcdrme Hi Benoit, Thank you for all of the information. I just tried to set the HS256 value. I let NHost generate the key, then copied it and pasted it into the Clerk's signing key field, and both are now integrated. There is some confusion in setting up the type and key pattern instead of the jwk url, which is very simple. Also, do we need to keep anything else when we combine these two tools in this manner? Is this ready for production? Is your application currently in production?

@bcdrme Thank you for all of your information and assistance. Between @elitan confirmed that they will add the feature to accept jwk url as well. The date has not yet been confirmed.

hi everyone, I just deployed a small fix to allow for the use of Clerk and jwk_url.
As of now, NHOST_JWT_SECRET supports either a (type, key) pair or a single jwk_url. One of them needs to be present.

if the pair (type, key) is used, hasura auth is started as usual and shares that pair with hasura.
if jwk_url is used, we assume you are using an external auth provider like Clerk.

To use Clerk with Nhost, update the NHOST_JWT_SECRET variable of your app with the right url (e.g., {"jwk_url":"https://clerk.helpful.gull-71.lcl.dev/.well-known/jwks.json"}).
@venkata-penumatsa I did some testing on my side and things seem to be working, please let me know if that works for you.

@nunopato Hello, Nuno. I'll test it and report back. Thank you for implementing this new feature so quickly.

@nunopato Hi Nuno,I just integrated the Clerk with NHost by using the jwk_url. I just pasted the Clerk's front end jwk_url in NHost environment variable (i.e. NHOST_JWT_SECRET) and they both are integrated now. I am able to pass the JWT in the query/mutation header from my Next JS application and Hasura is responsing back. Already executed few queries and mutations. Thank you for adding this feature I also request your team to have this added to your official documentation so that it will help the developers to know.

@venkata-penumatsa no worries, glad it is working for you now. We will be adding this to the documentation soon, thank you!

hi everyone, I just deployed a small fix to allow for the use of Clerk and jwk_url.
As of now, NHOST_JWT_SECRET supports either a (type, key) pair or a single jwk_url. One of them needs to be present.

if the pair (type, key) is used, hasura auth is started as usual and shares that pair with hasura.
if jwk_url is used, we assume you are using an external auth provider like Clerk.

To use Clerk with Nhost, update the NHOST_JWT_SECRET variable of your app with the right url (e.g., {"jwk_url":"https://clerk.helpful.gull-71.lcl.dev/.well-known/jwks.json"}).
@venkata-penumatsa I did some testing on my side and things seem to be working, please let me know if that works for you.

Hi @nunopato, will this work the same in Hasura Auth?

@mmmmillar you want to connect Hasura Auth with jwk_url instead of type, key ?

@venkata-penumatsa yeah that's what I'd like to do

@mmmmillar Also, how are you currently utilising Hasura Auth? Do you connect to Hasura using this as a stand-alone package? (not NHost)

@venkata-penumatsa yep using it stand-alone

@mmmmillar ok. I believe that this modification must be made while considering the current architecture and how the Hasura auth processes the JWT. I'll let the experts weigh in on this. @elitan @nunopato

on latest 0.21.2 with jwk_url it doesnt work.
/app/dist/utils/jwt/get-claims.js:9
    throw new Error(`Invalid JWT type: ${env_1.ENV.HASURA_GRAPHQL_JWT_SECRET.type}`);
    ^

Error: Invalid JWT type: undefined

I tried to Edit JWT Secret, but got error
{
  "key": "mykey",
  "claims_map": {
        "x-hasura-default-role": "anonymous"
  },
  "type": "HS256"
}

Error: variable value contains object with key "x-hasura-default-role", which is not a legal GraphQL name


Update the analysis interval when the custom resource changes

Changes to the canaryAnalysis.interval are not applied by Flagger. The canary analysis interval stays the same until Flagger restarts due to the fact that a job is created and never updated.

Let me take a stab at this issue. Thank you @stefanprodan


[docs] Fix the crash when applying custom colors

🔗 https://deploy-preview-30563--material-ui.netlify.app/customization/color/#playground
close #30343

[x] I have followed (at least) the PR section of the contributing guide.

Could we publish this ASAP please? Two more reports today, so presumably many more users affected.


#2322 Filter Popup Enhancements

Description

필터 설정에서 눈 아이콘을 제거 하였습니다.
데이터 소스명이 길어져서 줄임(...)이 발생하는 경우에만 브라우저 툴팁이 보여 지도록 하였습니다.

Related Issue :

#2322
How Has This Been Tested?

Need additional checks?
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.

Additional Context

run build
deploy to 6

@kyungtaak I cannot to connect test6 server. Please check it.

@AnnieHwang
you can test on http://<IP_ADDRESS>:8190


Initial ROI breakout PR

This PR enables ROI break on the basys3-x0y1 graph (which is now misnamed).
Remaining work to submit this PR:

[ ] Rename basys3-x0y1 to just the 50T underlying part
[ ] Remove search locations now that VPR no longer actually uses those arguments

I'll do  "Rename basys3-x0y1 to just the 50T underlying part" and "Remove search locations now that VPR no longer actually uses those arguments" in follow up PRs.


nrf54l15pdk: unit address and first address in 'reg' (0x5004c000) don't match for /soc/peripheral@50000000/vpr@4c000/mailbox@1

Building an application for the Nordic nrf54l15pdk board results in a warning generated by gen_defines.py:
$ west build --pristine --board nrf54l15pdk/nrf54l15/cpuapp samples/userspace/hello_world_user
-- west build: generating a build system
Loading Zephyr default modules (Zephyr base).
-- Application: <snip>/zephyr/samples/userspace/hello_world_user
-- CMake version: 3.25.1
-- Found Python3: /home/reto/code/3rd-party/venv-zephyrproject/bin/python3 (found suitable version "3.11.2", minimum required is "3.8") found components: Interpreter
-- Cache files will be written to: /home/reto/.cache/zephyr
-- Zephyr version: 3.7.99 (<snip>/zephyr)
-- Found west (found suitable version "1.2.0", minimum required is "0.14.0")
-- Board: nrf54l15pdk, Revision: 0.3.0, qualifiers: nrf54l15/cpuapp
-- ZEPHYR_TOOLCHAIN_VARIANT not set, trying to locate Zephyr SDK
-- Found host-tools: zephyr 0.16.8 (/home/reto/.local/opt/zephyr-sdk-0.16.8)
-- Found toolchain: zephyr 0.16.8 (/home/reto/.local/opt/zephyr-sdk-0.16.8)
-- Found Dtc: /home/reto/.local/opt/zephyr-sdk-0.16.8/sysroots/x86_64-pokysdk-linux/usr/bin/dtc (found suitable version "1.6.0", minimum required is "1.4.6")
-- Found BOARD.dts: <snip>/zephyr/boards/nordic/nrf54l15pdk/nrf54l15pdk_nrf54l15_cpuapp.dts
CMake Warning at <snip>/zephyr/cmake/modules/dts.cmake:314 (message):
  gen_defines.py succeeded with some stderr contents:

  unit address and first address in 'reg' (0x5004c000) don't match for
  /soc/peripheral@50000000/vpr@4c000/mailbox@1

Call Stack (most recent call first):
  <snip>/zephyr/cmake/modules/zephyr_default.cmake:133 (include)
  <snip>/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:66 (include)
  <snip>/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:92 (include_boilerplate)
  CMakeLists.txt:5 (find_package)

-- Generated zephyr.dts: <snip>/zephyr/build/zephyr/zephyr.dts

This warning has "always" (at least since Zephyr 3.7.0) existed, but recently got hidded by #76472. PR #78250 will make it visible once again.
Reproducing
Steps to reproduce the behavior:

(until #78250 is merged): Cherry-pick the commit in PR #78250
west build --pristine --board nrf54l15pdk/nrf54l15/cpuapp samples/userspace/hello_world_user
observe the resulting warning

Expected behavior
No device tree warnings printed.
Impact
I can not build Zephyr without warnings.
Workaround

Nasty hack (use @0 and @5004c000 to describe the same address):

diff --git a/dts/arm/nordic/nrf54l15_cpuapp.dtsi b/dts/arm/nordic/nrf54l15_cpuapp.dtsi
index 9cf1f6eea54..fe9e50172b4 100644
--- a/dts/arm/nordic/nrf54l15_cpuapp.dtsi
+++ b/dts/arm/nordic/nrf54l15_cpuapp.dtsi
@@ -37,7 +37,7 @@ nvic: &cpuapp_nvic {};
 };

 &cpuflpr_vpr {
-        cpuapp_vevif_rx: mailbox@1 {
+        cpuapp_vevif_rx: mailbox@5004c000 {
                 compatible = "nordic,nrf-vevif-event-rx";
                 reg = <0x0 0x1000>;
                 status = "disabled";

Triaged internally

Just figured out that this might be related to #72273

Triaged internally

Any updates on this? I'd love to finish #78253.

@masz-nordic @anangl can you help? (regarding updates)

@nordic-piks Any updates on this?

@nordic-piks Any updates on this?

@masz-nordic @anangl ?


pos? is broken

I would expect (pos? 0) to be false.
(dc/pos? (dc/decimal 0)) ;=> true

Also its docstring makes no sense: "Returns true if the value of this Decimal is negative, otherwise returns false."

Related: https://github.com/MikeMcl/decimal.js/issues/62


Using Ganbert to generate french Data ?

Hello,
I would like to know if I can use ganbert to generate french data and if yes how , should i switch Bert to use FlauBert the french version ?

What do you mean generate French data? GAN-BERT is not used as a generative model, but instead as an adversarial training schema to enable an effective semi-supervised schema for text classification with BERT.
If you want to perform text classification in French, I think you can use a multilingual BERT version within our framework.

In your description of the architecture, you said this line above :
With GAN-BERT we extend the fine-tuning stage by introducing a Discriminator-Generator setting, where:
the Generator G is devoted to produce "fake" vector representations of sentences;
the Discrimator D is a BERT-based classifier over k+1 categories.
So I thought that if I use your architecutre I could use the generator to produce more sample (increase my dataset) for my data since I have really small data.

The Generator is not used to create new examples and augment the dataset.
It is used to improve quality of the Discriminator according to the Semi Supervised GAN (SS-GAN) schema.
GANBERT is useful in case you have (possibly a lot of) non labeled data and a (possibly small) part of this data is labeled. The adversarial learning uses the labeled data to learn the task (as in a classical supervised schema) and, at the same time, it uses the unlabeled data (together with the fake one generated by the Generator) to improve the fine tuning of BERT.
If you have only a few data (whether labeled or unlabeled) I'm afraid that GANBERT, at the moment, is not very helpful.
Hope it helps
Danilo


Uncaught Error: Cannot call function 'getPosition' on missing remote object 78Error: Cannot call...

I work on a laptop that is closed and I use an external monitor as my main monitor. This happened when I opened my laptop which turned its screen back on and all that was on my external monitor was transferred to the laptop screen. I suspect this is because for a short time there was no screen.
Concretely there wasn't any disturbance, only the uncaught error message. So I figured I'd report it.
Atom: 1.40.1 x64
Electron: 3.1.10
OS: Windows 10
Thrown From: Atom Core
Stack Trace
Uncaught Error: Cannot call function 'getPosition' on missing remote object 78
Error: Cannot call function 'getPosition' on missing remote object 78
at throwRPCError (C:\Users\Henri\AppData\Local\atom\app-1.40.1\resources\electron.asar\browser\rpc-server.js:145:17)
at EventEmitter. (C:\Users\Henri\AppData\Local\atom\app-1.40.1\resources\electron.asar\browser\rpc-server.js:367:7)
at EventEmitter.emit (events.js:182:13)
at WebContents. (C:\Users\Henri\AppData\Local\atom\app-1.40.1\resources\electron.asar\browser\api\web-contents.js:294:13)
at WebContents.emit (events.js:182:13)
At C:\Users\Henri\AppData\Local\atom\app-1.40.1\resources\electron.asar\renderer\api\remote.js:219

Error: Cannot call function 'getPosition' on missing remote object 78
Error: Cannot call function 'getPosition' on missing remote object 78
    at throwRPCError (~/AppData/Local/atom/app-1.40.1/resources/electron.asar/browser/rpc-server.js:145:17)
    at EventEmitter.<anonymous> (~/AppData/Local/atom/app-1.40.1/resources/electron.asar/browser/rpc-server.js:367:7)
    at EventEmitter.emit (events.js:182:13)
    at WebContents.<anonymous> (~/AppData/Local/atom/app-1.40.1/resources/electron.asar/browser/api/web-contents.js:294:13)
    at WebContents.emit (events.js:182:13)

    at metaToException (~/AppData/Local/atom/app-1.40.1/resources/electron.asar/renderer/api/remote.js:271:17)
    at Object.exception (~/AppData/Local/atom/app-1.40.1/resources/electron.asar/renderer/api/remote.js:219:30)
    at metaToValue (~/AppData/Local/atom/app-1.40.1/resources/electron.asar/renderer/api/remote.js:223:28)
    at Object.remoteMemberFunction (~/AppData/Local/atom/app-1.40.1/resources/electron.asar/renderer/api/remote.js:123:16)
    at AtomEnvironment.getWindowDimensions (~/AppData/Local/atom/app-1.40.1/resources/app/static/<embedded>:1:731570)
    at AtomEnvironment.storeWindowDimensions (~/AppData/Local/atom/app-1.40.1/resources/app/static/<embedded>:1:731985)
    at WindowEventHandler.handleWindowResize (~/AppData/Local/atom/app-1.40.1/resources/app/static/<embedded>:11:285420)
    at l (~/AppData/Local/atom/app-1.40.1/resources/app/static/<embedded>:11:1197399)

Commands
  2x -4:51.9.0 core:backspace (input.hidden-input)
     -3:10.1.0 intentions:highlight (input.hidden-input)
  6x -2:59.1.0 core:backspace (input.hidden-input)
     -2:54.1.0 core:save (input.hidden-input)

Non-Core Packages
busy-signal 2.0.1
git-plus 8.7.1
indent-detective 0.4.0
ink 0.12.3
intentions 1.1.5
julia-client 0.12.3
language-julia 0.19.2
latex-completions 0.3.6
linter 2.3.1
linter-julia 0.8.3
linter-ui-default 1.8.1
save-workspace 0.5.0
tool-bar 1.2.2
uber-juno 0.3.0

Thank you for opening this issue. This was issue present in electron versions 4 and below. The latest atom version v1.51.0 uses electron version 5.0.3. The issue was fixed on this commit https://github.com/electron/electron/commit/a8f2646ba682d65f94ea628ac11b1a5521bcedcd. The fix has been available from electron version 5.0.0. I would advice you to upgrade to the latest atom version. I am closing this for now but happy to reopen if you still experience the issue.


Resource rollbar_team

Implement Terraform resource rollbar_team.
How will team to user relationships be expressed?  Cf #61.

We can relation relate users to teams in two ways.  Either a user can have a teams argument; or a team can have a users argument.
Either
resource "rollbar_team" "foo" {
  name = "foo-team"
}

resource "rollbar_user" "linus" {
  email =<EMAIL_ADDRESS>  teams = [rollbar_tam.foo.id]
}

or
resource "rollbar_team" "foo" {
  name = "foo-team"
  users = [rollbar_user.linus.id]
}

resource "rollbar_user" "linus" {
  email =<EMAIL_ADDRESS>}

Probably teams needs to be an argument on rollbar_user.  Because it's not possible to have a Rollbar user that's not a member of a team.  A user is created only by invitation to a team.


WriteException fails because of generic

When a stack trace contains a generic method the AnsiConsole.WriteException fails with the error message:
"Could not parse style T"
Example "text "string in Markup.cs :
_paragraph = MarkupParser.Parse(text, style);
[silver]Microsoft.VisualStudio.Services.WebApi.VssHttpClientBase.[/][yellow]SendAsync**[T]**[/][silver]([/][blue]HttpRequestMessage[/] [silver]message[/], [blue]Object[/] [silver]userState[/], [blue]CancellationToken[/] [silver]cancellationToken[/][silver])[/]
Expectation:
The used strings should be encoded so that special characters like [ and ] are not interfere with the color rendering.

@patriksvensson
Thanks a lot for your fast reponse. I am using 0.30.0,
Strange, I was not updating yet because the release notes mention only a typo fix and also the commit shows only a typo change:
"Fix typo in package description"
https://github.com/spectresystems/spectre.console/releases/tag/0.31.0
But after updating to 0.31.0 it seems to work.
Sorry for that but how is this explainable?

@zplan Great that it solved itself.
I don't update the release notes, so it just shows the commit the release was made from.


Add support for GCP Tau T2D (AMD EPYC Gen 3) instance types

Following https://github.com/cloud-carbon-footprint/cloud-carbon-footprint/issues/332 GCP now also has support for AMD EPYC Gen 3 with their Tau T2D instance types: https://cloud.google.com/blog/products/compute/compute-engine-tau-t2d-vms-now-available-for-scale-out-workloads
This ticket is to add support for that instance type.

2 PRs opened:

Updated coefficient calculations: https://github.com/cloud-carbon-footprint/cloud-carbon-coefficients/pull/10
Updated coefficients, tests and GCP instance reference: https://github.com/cloud-carbon-footprint/cloud-carbon-footprint/pull/555

Awesome @davidmytton - we'll review soon!


No padding between icon and text in Upload component when using Oruga Full theme

Overview of the problem
Oruga version:  v0.9.0
OS/Browser: Chrome 130.0.6723.117 and FireFox 132.0.2 (64-bit)
Description
When using the "Oruga Full" theme, the Upload component has no padding between the upload icon and the "Click to upload" text. This causes the icon and text to appear too close to each other, impacting readability and aesthetics.

Steps to reproduce
Set the Oruga theme to "Oruga Full".
Navigate to the Upload component.
Observe the lack of padding between the upload icon and text in the upload button.

Expected behavior
To improve spacing and visual clarity, the upload icon and the "Click to upload" text should be slightly padded.
Actual behavior
Something like this (not exactly)

The upload icon and text are displayed without any padding, causing them to appear cramped together, ruining the asthetic

I would like to work on this issue if possible

Hey @AdityaBhate, I appreciate your engagement to contribute :)
First, I would suggest opeaning thinks like this in the repo of the respective theme (https://github.com/oruga-ui/theme-oruga).
Second, it's not a problem with the Upload component, because you can pass any element in the trigger slot. The button here is just an example.
However, we could add some spacing like the bulma theme does


Bump mavlink-router to v2

https://github.com/intel/mavlink-router/releases/tag/v2
New interesting features to us:

New "LogMode" configuration to allow logging only when armed
New MinFreeSpace and MaxLogFiles configuration to control logging maximum size
and rotation

We're already using master branch, so just need to remove ~/software/mavlink-router and ~/var/build/install_flag_mavlink-router and rerun configure to ensure new version.
Added new logging params to config template.


7/6/2023 3:30 PM Publish

PR Summary

PR Checklist

[ ] Descriptive Title: This PR's title is a synopsis of the changes it proposes.
[ ] Summary: This PR's summary describes the scope and intent of the change.
[ ] Contributor's Guide: I have read the contributors guide.
[ ] Style: This PR adheres to the style guide.

PR Summary
PR Checklist

[ ]  Descriptive Title: This PR's title is a synopsis of the changes it proposes.
[ ]  Summary: This PR's summary describes the scope and intent of the change.
[ ]  Contributor's Guide: I have read the contributors guide.
[ ]  Style: This PR adheres to the style guide.

https://github.com/MicrosoftDocs/azure-docs-powershell/pull/2636#issue-1792376556


[Tables] Add dependency yarl

yarl is installed while run dev_requirements.txt, it may be a dependency of a dependency in that file. Since we are using this package in Tables(link), it's safer to add the dependency to setup.py instead of being controlled by a dependency.

API change check
API changes are not detected in this pull request.


Sharding a model checkpoint for deepspeed usage

Hey!
I'm using a custom version of this repo to run BLOOM-175B with DeepSpeed and it works great, thank you for this!
I was thinking of exploring using large models (such as OPT-175B) and was wondering what is the process for creating a pre-sharded, int8 deepspeed checkpoint for it, similar to https://huggingface.co/microsoft/bloom-deepspeed-inference-int8
Is there any documentation available or example scripts for this?

I am unsure about OPT's compatibility with deepspeed.
But if it works, you can simply pass save_mp_checkpoint_path parameter to init_inference method.
This will create a pre-sharded fp16 version (assuming it works :) )
For generating int8 weights (pre-sharded), look at https://github.com/microsoft/DeepSpeedExamples/blob/master/model_compression/gpt2/bash_script/run_zero_quant.sh
This scripts generates a quantized version of gpt2, but it is QAT and requires training.
I haven't personally tried this though.

Also watch out for https://github.com/huggingface/transformers-bloom-inference/pull/37

If you don't have memory constraints (number of GPUs), I will encourage you to use fp16 since it is faster.
int8/int4 will be much faster once DeepSpeed starts supporting their kernels.


Best way to stop the war is trying to sit down and talk, not initiating more attack.

Best way to stop the war is trying to sit down and talk, not initiating more attack.

🖕💩, feel free to follow the "russian war ship"


feat(gui): save tree expansions in project

Tree expansions, and expanding them back when the project is open.

@asashour it works, but I don't like implementation it is too "heavy". I mean on every tree change you traverse all leaves and creating new arrays of arrays and it can be a lot of classes and packages.
I think it is better to use incremental changes like add item on expanding and remove on collapse without rebuild full info (for this you can use temporal optimized storage and convert it to "save" format only on save).
Another approach is to save this tree info only on project save or file reload.
Also, it will be nice if this work on deobfuscation switch, so you need to store and search by original names.
And you need to decide with @jpstotz  who implements saving of splitter location :))

I don't know how to get the original name of JPackage.

Yeah, looks like adding original package name to JPackage will need a lot of changes. So I think this change is good start and we will fix it later.


Update reference to sbt integration project

olim7t's project is outdated; typesafehub's was moved

fixed in master


Return None if pm25_value is unsupported.

To fix #45

We need to fix this issue holistically not just the sensor in question, let me think about it.

Sure, take your time :)


Memory leak in new map renderer with compose map with  PolyLines

In our app we have out-of-memory errors since we updated to android compose maps 4.3.0.
This is related to the new map renderer which became default in maps sdk 18.2.0,  see https://developers.google.com/maps/documentation/android-sdk/renderer
It is caused by drawing polylines on a compose map. When the lines are not drawn the memory-leak does not occur anymore.
We work around this for now by enabling the legacy renderer in this way:
MapsInitializer.initialize(applicationContext, Renderer.LEGACY) { }
Environment details
Android, any version
android-maps compose from version 4.1.0 and higher, (since the use of maps sdk 18.2.0 where the new map renderer became default, see https://developers.google.com/maps/documentation/android-sdk/renderer)
Steps to reproduce

create 2 maps which show polylines
switch between them a few times (overview and details for example)
memory usage is rising until the garbage collector can not get more memory and kills the app.

Code example
I am not able to provide a code example right now

If you would like to upvote the priority of this issue, please comment below or react on the original post above with :+1: so we can see what is popular when we triage.
@bluevoidnl Thank you for opening this issue. 🙏
Please check out these other resources that might help you get to a resolution in the meantime:

Check the issue tracker - bugs and feature requests for Google Maps Platform APIs and SDKs
Open a support case - Get 1:1 support in Cloud Console.
Discord - chat with other developers
StackOverflow - use the google-maps tag

This is an automated message, feel free to ignore.

Hi @kikoso ,
I work together with @bluevoidnl . I created a new issue here.

I am also seeing this issue when I upgrade to the new rendered on my map that is rendering several hundred polylines.

I'm also facing this issue when I add lots of Polylines on a map. Crashes for out of memory on the new renderer, but not when switching back to the legacy one.
However, according to the issue, running out of memory is the intended behaviour. Not sure how to migrate this problem once the new renderer is the only option available.


bug: how to revert the order to use both 2 lines?

Describe the Bug
they are all on the bottom line with goofy order,but id like to have it as before 0.6.0 update, what can i do?
Steps to Reproduce
get latest neoforge 1.21.1 update
Expected Behavior
have the order it had before
Screenshots
a
Modloader Type
Neoforge
Modloader Version
latest
Mod Version
latest
Log Output
a

Additional Context
a

also how do i access config from config folder? cuz editing stuff in game makes the game crash

@VaporeonScripts hi, can you provide me screenshots, and logs from crash please ?
That will help me to give you help and/or fix issue !

alright, ima send the crash log, then the pic of the order,cuz it seems that im unable to see some advancements that i could see before

also seems to be unable to generate config

now it seems like it also uses top bar, btw how can i make them straight, and not up and down?

Thanks for the extra context 🙏  Really appreciated !
Effectively disorder.. a kind of.. "order" :trollface:
I will check that !

alright,ty!!

@VaporeonScripts, im back

For the visual issue, That the mod obviously.
For the crash that seems to be on your side, the crash come from mojang/Narrator due to missing flite library required by the narrator. As you are on archlinux you can try to install flite and restart prismalauncher !

is flite a mod or what? cuz i dont really understand why narrator would be required fr

if im right flite should be a package?

i installed it, ima see how it goes

https://mclo.gs/nLPbtcz with flite (assuming its the one from sudo pacman -S flite)

i did not reboot btw

narrator works altough still crashes

Thanks for your time ! The narrator Issue are resolved well, and now I can see the real source of the crash 💥
I will works on the fix starting monday !

alright

I fix the crash but maybe another UI mod cause another error. When you will have install the  0.6.1, if you have another issue, please re-open a new one 🙏 💜

Alright,thanks


Make list of speakers rearrangeable on mobile

proposal to resolve #2306
This PR enables the rearrangement functionality for mobile devices. To deal with accidental rearrangements a delay was added. A user has to hold the rearrangement icon for a certain time before they can move it. This way when scrolling over the page the user will not accidentally move an entry.
The Angular Material documentation mentions the used functionality to deal with these scenarios so I think this is the way to go here. https://material.angular.io/cdk/drag-drop/overview#delayed-dragging
Although we might need to adjust the delay time.

I will close this one for now as a visual feedback does not seem to be possible with angular materials API and we therefore might need a different solution.

Tested it, the feedback looks good.
I found another bug in the mobile view. On the small devices the More Vert icon falls of the tile.


Build error of neon on Odroid

Output of 'strings libarm_compute.so | grep arm_compute_version':
Platform:
Odroid C4
Operating System:
Distributor ID:	Ubuntu
Description:	Ubuntu 20.04.1 LTS
Release:	20.04
Codename:	focal

Problem description:
Hi,
I tried to compile compute library base on this tutorial, but when I set neon=1, I got the following error:
./arm_compute/core/PixelValue.h:38:5: error: arm_compute::PixelValue::PixelValue()' does not throw; perhaps it should be declared noexcept` [-Werror=noexcept]
The version of compute library is set as 21.02.
Currently, I set neon=0 and compute library is compiled successfully. I'm not sure if this is a bug on Odroid, compute library, or the version of Ubuntu.

Thank you,
Rahn

Hi @Rahn80643
This patch solves the problem:
https://review.mlplatform.org/c/ml/ComputeLibrary/+/5281
Hope this helps

Hi @morgolock,
I've successfully built Compute Library with the patch.
Thank you

How to apply the patch?

Hi,
You have to cherry pick the patch on the top of 21.02.
21.05 and 21.08 already have the fix applied.
Hope this helps.

From: Divy Sancheti @.>
Sent: 16 September 2021 23:10
To: ARM-software/ComputeLibrary @.>
Cc: Subscribed @.***>
Subject: Re: [ARM-software/ComputeLibrary] Build error of neon on Odroid (#892)
How to apply the patch?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/ARM-software/ComputeLibrary/issues/892#issuecomment-921289148, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGNXIST33J63VSNE3G2X7S3UCJTOTANCNFSM42NVZDFA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


Not Satisfied with Kata - OK. Why?

Suggest requiring the "Not Satisfied" voters to give a reason (which could appear in the discourse a comment)
Because how can an author (e.g. me) know how to improve a Katas if an unsatisfied user does not bother to say what the perceived problem is?
Sometimes I think these satisfaction votes are little more than just an indication of the user state of mind.

More than likely there will be at least some number of users who would prefer not to have it as suggested. For any number of reasons, a user may want to keep their votes anonymous, especially when it comes to the negative votes they've posted.
Perhaps some changes to the voting system instead. For example, something like:

users who complete a kata at a higher kyu rank than the user's rank cannot downvote a kata (e.g. 8kyu user cannot downvote a 6kyu kata), except when user is at least 4 kyu rank
when users downvote, allow them to comment anonymously.
when additional users complete the same kata and find a comment congruent to their own sentiment, they can simply upvote the comment. Each comment shows the number of upvotes it received.
kata authors can act upon the comments by making revisions to the kata, then posting a response to each comment.
if the user's issue is resolved by the author within a specific time window, the user who posted the comment as well as all others who upvoted the same comment get a notification.
each of these users can then decide if they're satisfied with the changes and change their original vote, or leave it as is otherwise.

Not sure if this is feasible due to it possibly being very time-consuming (possibly breaking some things) as well as increasing burden on CW resources.
As for the user state of mind aspect, I'm not sure if there's a possible solution to that.

Well ... back with this gripe/suggestion again.
It is very frustrating getting "Not Satisfied" votes for what I consider perfectly good quality Kata that I've spent a lot of time on. I think the "Not Satisfied" votes should have a mandatory "reason" text field to go with it.
I am don't care if there is an "anonymous" checkbox if the user wants to hide behind it. But without knowing a reason how can the issue be addressed? And if they just enter a garbage reason like "xxx", then at least I will know the vote just some vindictive nones and not a real Kata problem at all.

If they're the first downvote, then they probably won't be anonymous anyway.

I just spent 3 days fixing and polishing a kata just to have someone downvote it from 100% to 50% without giving any reason.
 I was going to go straight to fixing an older beta kata of mind after this, but this really kills motivation.
Clicking "not satisfied" should open a little dialog that prompts you to write a message offering constructive feedback.
Many kata authors would appreciate this.
Please consider this issue again, @kazk!

I really hate the suggestions by various people over the years that for some reasons it should be mandated to have everyone who wants to vote "not satisfied" perform the equivalent of "writing a 1000-word essay why the downvote is justified and have it approved by 3 reviews".
Beta katas are filled with hot garbage (Hell, even approved katas are filled with them), and there are even more kata authors that does dubious practices in their katas, either due to inexperience or ignorance, and they're just left there not fixed forever.
The only thing that allows me, or anyone, to defend ourselves from all the shitty katas corroding the sanity and giving a constantly bad experience is the "not satisfied" button. If anyone's gonna tell me I have to prove the downvote I'm going tell them to fxck off and fend for themselves.
Seriously, have you done most of the katas on CW, and be so frustrated by the overall experience you've never had a single day of satisfied CW experience? That's me. Until you've gone through this stage I'm not gonna treat your opinions as qualified, period.

@Voileexperiments, I bet you had good days when you still had approved 100% satisfaction rated kata left to solve, didn't you?
I might not have been where you have, but I've done not-so-great kata and they usually have a lower satisfaction percentage than usual. So it makes sense to prefer kata with higher ratings. Lower ratings, especially in beta, mean less people are going to be willing to try to solve it, so as to avoid that frustrating experience you talk about.
Having a troll/upset person downvote a kata that you worked hard on is a far more frustrating experience than having leave a little note when giving a satisfaction rating. No one said anything about 1000 words. One sentence - less than a fraction of a typical solution - should suffice.
If not a required message, then what is a solution you're willing to consider?

I bet you had good days when you still had approved 100% satisfaction rated kata left to solve, didn't you?

No. I already said many times in gitter chat how I'm finding an average of 1 glaring issue per freshly approved kata. Please don't assume my experience.

Lower ratings mean less people are going to be willing to try to solve it

Are you sure? There are many katas with 100% satisfaction rating but still has <50 solves even after a year. (The trainer is partly to blame about this, because it keeps suggesting the same katas with lots of solves.) And it isn't rare for me to find glaring issues in such katas too, simply because nobody bothered to raise one.

Having a troll/upset person downvote a kata that you worked hard on is a far more frustrating experience than having leave a little note when giving a satisfaction rating

Are we that low we're setting up strawmen to attack already? Why do we keep bringing up hypothetical "trolls"/"grumpy dudes" whenever this topic is discussed? Is facing downvotes gracefully that hard for everyone involved in the discussion?
I'm not a fan of treating people like snowflakes because they might feel hurt. If anything, I wish people in CW would care about my feeling a bit more, so I won't feel like my time spent on CW has gone to waste every time I come back to solve some katas.

If not a required message, then what is a solution you're willing to tolerate?

I reserve my right to not engage with kata authors I know will be a waste of everybody's time, while still exercising my right to vote and have it count as any other vote.
Also, frankly speaking, there are no "problems" to speak with, so no solution is needed.

I wanted to chime in and say how mandatory comment will just increase visit counters of lorem ipsum generators and that if anyone wants to, they can leave constructive feedback even now and for some reason people just don't bother, but Voile was faster to answer so just let me quote and upvote something what almost exactly reflects my thoughts:

Why do we keep bringing up hypothetical "trolls"/"grumpy dudes" whenever this topic is discussed? Is facing downvotes gracefully that hard for everyone involved in the discussion?

👍

@Voileexperiments,
Sorry for making assumptions. I often tend to think people are more similar to me than they really are.
In the end I'm just trying to argue for my case and make the downvote go away.
And I realized I would probably look like a snowflake before engaging with this thread, but I don't care.
 I'm not just going to be quiet about it.

Is facing downvotes gracefully that hard for everyone involved in the discussion?

Usually, no. But this one just sucked. The kata had 100% satisfaction, and I just spent 3 days going hard on it, fixing it, writing tests, and polishing it. I was just really excited for other people to solve it.
Then someone comes and downvotes it without saying anything, and now it's at 50%.  Also, the reason why I mentioned "troll" is because I heard that the user is a serial downvoter.

I wish other PUs in CW would care about my feeling a bit more, so I won't feel like my time spent on CW has gone to waste every time I come back to solve some katas.

I do care, man.

I try to craft my kata just like the ones I really enjoy.
I try to make my descriptions as clear and concise as possible.
I've learned how to improve my kata authoring from listening to others' feedback.
I try to make sure that the problem is fun, and that nothing about it is annoying/quirky.
I don't stop working on fixing my kata when I know it has a bug - it needs to be fixed before anyone notices. I cringe at the thought of people noticing something wrong with my katas.

Would you not also be upset?

Also, the reason why I mentioned "troll" is because I heard that the user is a serial downvoter.

Then instead of vague finger pointing and witch hunting, you should contain the mods/admins about possible serial downvoting and let them resolve that; otherwise we're gonna have a thousand threads of people doing the same, and the voting process will die in a fire from all the speculations and accusations.
I don't think feeling bad about something is a bad thing (I feel bad and vent about my CW experience more than others), but the misery that you encountered aside, threads like this keep being opened as far as I joined CW a long time ago, and these threads never end up being constructive since it's all angry venting and finger pointing. You're basically preaching to the choir about the infuriating insanity known as the beta process here ;-)

Then instead of vague finger pointing and witch hunting, you should contain the mods/admins about possible serial downvoting and let them resolve that

To be fair, I heard it from a mod, but then admin said that it might not really be the case.
The same user also completed my most recent kata (not the one from this complaint, but shortly after) but didn't downvote it. There also wasn't a 100% satisfaction rating he could ruin.
If he could just answer me about why he did that, then it would make things better.
Well, I hope to hear of any possible improvements.
But if my kata stays in beta for longer than 3 years, I'm deleting it and reopening it as another one...


simpler NormalizeTargets

path.Join("/", foo) will always add a / on the front of foo and additionally a path.Clean happens internally as part of path.Join

Thanks! Please add a DCO sign-off (I just realized that we're missing a CONTRIBUTING file).

Ah yep, no worries.
Are you interested in the changes I made around verifiers (see my master branch, signed/verifiers.go and updates to signed/verify.go)? I'd be happy to port them over.

Yeah, pluggable signature verification makes sense, ideally with RSA off by default.

 :-P

There we go.

LGTM, Thanks!


Indeces can get reused without a way of the holder of an index being able to check that

Lariv tries to fill empty spaces before allocating a new node which results in indeces being reused. But there is no way to check if the value is still the "same".
This is motivated by usecases like connections being stored in this where one thread manages the insertion/removal of the connections and other threads are responsible for using them, only identified by the LarivIndex. A thread using an old index should always see that the index it is holding is no longer valid even if the slot in the Lariv got reused.
Maybe the slots could have an epoch counter, which gets included into the lariv index. If an element is put into a slot the respective counter is incremented. And the various operations like get/take/... only work if the counter in the index still matches the current counter of the slot.
This could be implemented with a counter in the AtomicOption and changing the signature of AtomicOption::get AtomicOption::get_mut to take an additional parameter that indicates the expected counter value.
Example of current behaviour:
#[test]
pub fn index_reuse() {
    let lariv = Lariv::<u32>::new(10);

    let original_idx = lariv.push(1);

    // Fill all other slots
    for _ in 0..9 {
        lariv.push(0);
    }

    // remove the original element
    lariv.remove(original_idx);
    assert!(lariv.get(original_idx).is_none()); // I'd expect this to always return None in the future

    // push new element, this will reuse the original index
    let new_idx = lariv.push(2);

    assert!(lariv.get(original_idx).is_none()); // <-- this fails because the index got silently reused
}

That went completely under my radar. I'll fix it, thanks!


Data augmentation: brightness and contrast

Wouldn't trained models gain robustness if data augmentations (utils/augmentation.py) included brightness and contrast shifts (ex.: random, 10-15%)? I imagine it could also help with overfitting issues.

That's true for satellite imagery. But since brightness and contrast shifts are only histograms modifications, there are a few considerations:

EO data other than satellite or aerial imagery (e.g. derived products from DEMs [Slope, aspect, etc.]) have specific data range and I'm not convinced that messing with these histograms would really help.
We could add this feature as a parameter in the config file. But we would have to be able to turn it on/off for each band. For example, let say we use as input data images with RGB+slope. We'd like to apply contrast and/or brightness shifts on the RGB bands but probably not on the slope band...
We would probably have to manage those functions ourselves, since data augmentations libraries such as Albumentations only manage 3bands data (for now).

It's worth the discussion, tough. I think the first step would be to test the first hypothesis and work from there. I'll add this to our "tests wishlist".
Math

Duplicate of #132

This implementation good be a good start:
https://github.com/SpaceNetChallenge/SpaceNet_SAR_Buildings_Solutions/blob/master/2-MaksimovKA/predict/tta.py


0.11.2/redeclare ts

Motivation and Resolution
Fix https://github.com/0xs34n/starknet.js/issues/588
Usage related changes
Because of cairo0 back compatibility, we left formatting to be compressed program in response class, so it needs to be decompressed for declare and also typecast to legacy.
An example of redeclare cairo0 without a helper will be:

Redeclare cairo0 contract helper:
contractClassResponseToLegacyCompiledContract();
Example Cairo0 redeclare:
https://github.com/0xs34n/starknet.js/blob/a5b628fb0248a5c8caddc985cf93b6d53a69bf04/__tests__/account.test.ts#L75
Example Cairo1 redeclare:
https://github.com/0xs34n/starknet.js/blob/a5b628fb0248a5c8caddc985cf93b6d53a69bf04/__tests__/cairo1.test.ts#L60

Fix ContractClassResponse type
Extend isSierra() response type to help TS evaluate the resulting type

Checklist:

[x] Performed a self-review of the code
[x] Rebased to the last commit of the target branch (or merged it into my branch)
[x] Linked the issues which this PR resolves
[x] Documented the changes in code (API docs will be generated automatically)
[x] Updated the tests
[x] All tests are passing

I didn't succeed to import in my test script the exports of utils/contract and utils/provider.
How to import them?

@tabaktoni I didn't succeed to import in my test script the exports of utils/contract and utils/provider. How to import them?

Added missing utils exports


How do I include ImGui.Net Source code into my own project?

Im trying to add ImGui.Net as a seperate source project in my solution however i see like 7 csproj's and im not sure which ones to include in my solution.

You just need ImGui.NET. The others are:

CodeGenerator (not needed at runtime)
Example projects
Auxiliary libs (you could include these if you wanted more features)

You just need ImGui.NET. The others are:

CodeGenerator (not needed at runtime)
Example projects
Auxiliary libs (you could include these if you wanted more features)


Sadie/update for secure cadence

We need to update the flow-pds to use the following versions due to some breaking changes incoming for Cadence.
	github.com/onflow/cadence v0.21.3-0.20220422215834-5ba7ff3666fd
	github.com/onflow/flow-cli v0.33.2-0.20220425184358-8797257ba650
	github.com/onflow/flow-go-sdk v0.24.1-0.20220421152843-9ce4d554036e

The flow-pds has a dependency on this library which also needs to be updated. I bumped the versions but had to base off a different version from what is in the main branch as this is what the flow-pds is pointing towards:
replace github.com/bjartek/go-with-the-flow/v2 => github.com/flow-hydraulics/go-with-the-flow/v2 v2.0.0-20210916131243-1b2f9db5a593
Most of the code here is updated from some internal library changes that I hacked at to get working. The main Cadence upgrade changes are fixing a few functions from the SDK which have changed function signature (eg. cadence.NewString() which now produces an error).
I'm open to a better way of doing this - would appreciate any help as we are on a time crunch to have this working by next week. This seems to work so far, at least when I run the tests through the flow-pds by pointing at my local branch, but further testing is required.
The testing suite is also erroring in several places, however this seems to be the case for the commit that I forked from with the main culprit the TransactionFromFile() signature changing. This is not related to the Cadence change - would appreciate any guidance on how to fix that.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 11 (18.18%)  changed or added relevant lines in 3 files are covered.
502 unchanged lines in 8 files lost coverage.
Overall coverage decreased (-52.0%) to 38.838%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

gwtf/script.go
0
3
0.0%

gwtf/transaction.go
0
6
0.0%

Files with Coverage Reduction
New Missed Lines
%

gwtf/cadence.go
2
87.5%

gwtf/account.go
10
68.18%

gwtf/setup.go
36
37.14%

gwtf/script.go
42
60.14%

gwtf/asserts.go
77
0%

gwtf/transaction.go
96
44.91%

gwtf/templates.go
107
0%

gwtf/event.go
132
30.8%

Totals

Change from base Build<PHONE_NUMBER>:
-52.0%

Covered Lines:
381

Relevant Lines:
981

💛  - Coveralls

Updated to latest version as realized it didn't need to point to the older version from pds- closing this in favour of https://github.com/flow-hydraulics/go-with-the-flow/pull/2

Reopening as this maintains the function signature from TransactionFromFile which the flow-pds utilizes heavily and it appears to break once the code parameter is removed. Any guidance on this would be much appreciated. Right now there's two PRs:

One based off of 1b2f9db5a593 which is the compatible version with flow-pds #1
One based off of Main #2

The second requires fewer changes however is not compatible with flow-pds.

Go-with-the-flow is deprecated in favor of https://github.com/bjartek/overflow.
It has a secure-cadence branch.

Thank you @bjartek - I've ported over the PDS to overflow. I wonder if it would be possible to mark the go-with-the-flow repos as deprecated? To save time for the next person. Thanks!
Closing this PR


Add change in SC5 SSL bumping behavior to Major changes list

Description

SC5 does not bump test traffic by default, so added a line under major changes.
Motivation and Context

Documentation/Awareness for this change.
Types of Changes

[ x] Documentation fix (typos, incorrect content, missing content, etc.)

hmm... came across this MR just after merging mine 🤷
SSL Bumping behavior change is updated. We'd still need to write a more detailed doc containing the changes


[5.9] Display actual expanded source, not expected source

Explanation: When assertMacroExpansion fails, it incorrectly displayed the expected source as the expanded source.
Scope: The assertMacroExpansion test function
Risk: Very low, only changes the description in case of an XCTFail
Testing: Tested manually
Issue: n/a
Reviewer:  @ahoppen on #1917

@swift-ci Please test


manjaro AUR : set_sources_assignment_filter argument must be an empty list.

Describe the bug
when building the package ungoogled-chromium from the AUR on update to date manjaro linux i get this error :
==> Starting build()...
make: Entering directory '/home/mirsella/.cache/yay/ungoogled-chromium/src/chromium-launcher-6'
cc -o chromium -D_FORTIFY_SOURCE=2 -DLAUNCHER_VERSION=\"v6\" -DCHROMIUM_NAME=\"chromium\" -DCHROMIUM_BINARY=\"/usr/lib/chromium/chromium\" -DCHROMIUM_VENDOR="\"Manjaro Linux\"" -DPEPPER_FLASH_DIR=\"/usr/lib/PepperFlash\" -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/json-glib-1.0 -pthread -I/usr/include/libmount -I/usr/include/blkid  -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now launcher.c -ljson-glib-1.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0
make: Leaving directory '/home/mirsella/.cache/yay/ungoogled-chromium/src/chromium-launcher-6'
  -> Configuring Chromium
ERROR at //build/config/BUILDCONFIG.gn:402:1: set_sources_assignment_filter argument must be an empty list.
set_sources_assignment_filter(sources_assignment_filter)
^------------------------------------------------------
==> ERROR: A failure occurred in build().
    Aborting...
error making: ungoogled-chromium

To Reproduce
Steps to reproduce the behavior:

yay -S aur/ungoogled-chromium

Expected behavior
the package would compile
Screenshots

Environment (please complete the following information):

OS/Platform and version: Linux main 5.9.8-2-MANJARO #1 SMP PREEMPT Wed Nov 18 06:38:03 UTC 2020 x86_64 GNU/Linux
ungoogled-chromium version: aur/ungoogled-chromium 86.0.4240.183-1

Is this still an issue? If so, please file this issue with the corresponding platform repo: ungoogled-software/ungoogled-chromium-archlinux


Fixing a path issue as %~dp0 resolves the path the bat is running from

As per the title.
Once the new package has been built, give me a holla and I will give it a test.

Thanks Neil.


Empty modular page content causes Allowed memory size exhausted

The problem arises integrating https://github.com/variar/grav-plugin-unitegallery in my twig templates of a theme inheriting from Quark. The pages are generated by converting an old TYPO3 site and have lots of galleries on part of the pages.
So I added an empty block named galleries to partials/base.html.twig and modified default.html.twig in this way:
{% extends 'partials/base.html.twig' %}
{% macro pageLinkName(text) %}{{ text|lower|replace({' ':'_'}) }}{% endmacro %}

{% block content %}
    {{ page.content }}
{% endblock %}

{% block galleries %}

    {% for module in page.collection('galleries') if module.template == 'modular/gallery' %}

        {{ module.content }}
    {% endfor %}

{% endblock %}

modular/gallery.html.twig is
{% set grid_size = theme_var('grid-size') %}
{% set columns = page.header.class == 'small' ? 'col-3 col-md-4 col-sm-6' : 'col-4 col-md-6 col-sm-12'  %}

{% set gallery_id = (page.header.unitegallery.gallery_id ?: page.slug|ltrim('_')) %}
{% set gallery_theme = page.parent.header.unitegallery.gallery_theme ?: 'tiles' %}
{% set gallery_options = { 'gallery_theme': gallery_theme } %}

{{ page.content }}

  {{ unite_gallery(page.media.images, gallery_options|json_encode, gallery_id) }}

The problem is in the {{ module.content }} call in default.html.twig: If the markdown of the modular gallery page is not empty every thing works as expected. If the markdown is empty, only with a frontmatter in the md file, nothing of the modular template is rendered and even the debugger does not show up on the displayed page. Any content, even a html comment in the gallery md makes it run, but blanks are not sufficient.
Error in apache logs was:
[Sun Jul 22 09:59:00.787786 2018] [:error] [pid 3152] [client <IP_ADDRESS>:4906] PHP Fatal error:  Allowed memory size of 134217728 bytes exhausted (tried to allocate 262144 bytes) in /var/www/domains/saint-josse-europe.eu/grav/system/src/Grav/Common/Plugin.php on line 265
[Sun Jul 22 09:59:00.788029 2018] [:error] [pid 3152] [client <IP_ADDRESS>:4906] PHP Fatal error:  Allowed memory size of 134217728 bytes exhausted (tried to allocate 262144 bytes) in /var/www/domains/saint-josse-europe.eu/grav/vendor/monolog/monolog/src/Monolog/Logger.php on line 416

After increasing memory to 256 MB still errors, but in other routines:
[Sun Jul 22 10:06:23.521845 2018] [:error] [pid 3695] [client <IP_ADDRESS>:5300] PHP Fatal error:  Allowed memory size of 268435456 bytes exhausted (tried to allocate 262144 bytes) in /var/www/domains/saint-josse-europe.eu/grav/vendor/symfony/event-dispatcher/Event Dispatcher.php on line 184
[Sun Jul 22 10:06:23.522013 2018] [:error] [pid 3695] [client <IP_ADDRESS>:5300] PHP Fatal error:  Allowed memory size of 268435456 bytes exhausted (tried to allocate 262144 bytes) in /var/www/domains/saint-josse-europe.eu/grav/vendor/filp/whoops/src/Whoops/Run.php

It's not a gallery problem, I know how to handle them, and the problem is the same if I omit the gallery call and just render some dummy html.
There must be a infinite loop somehow. Is this from my twig structure or is it a bug?
Additional information: In the frontmatter of the containing page I have
galleries:
  items<EMAIL_ADDRESS>unitegallery:
  gallery_theme: tiles

Grav 1.4.7
See also my unsuccessful post in forum.

I'm trying with Quark theme and I can't reproduce this....

I transferred the theme to a fresh grav-skeleton-blog-site and cannot reproduce too. I will compare the two instances deeper to find the problem and will report.

bin/gpm uninstall image-captions solved the problem.

Weird as that bug was fixed in 1.0.2 of image-captions:  https://github.com/trilbymedia/grav-plugin-image-captions/blob/develop/CHANGELOG.md

Sorry, I am not a php champion and have no debugging configuration on my server. But the error is reproducible: when I install the plugin, the rendering is stopped by the memory limit, after uninstall the page renders as expected.

@tremel what version of image-captions was installed for you?  Can you reproduce the issue on grav-skeleton-blog-site by installing image-captions? Because it's not doing it for me with that skeleton.

@rhukster I tested also with a grav-skeleton-blog-site I set up only for this purpose and Image Captions [v1.0.2]. Error is reproducible in this instance. Please see grav-skeleton-blog-site.zip with the relevant parts of my site. Use path /jkirchenkapellen/a-osterreich/bezau for test request.

Ok, i can see your error.. looking at it now...

Phew, found the problem, and fixed in image-captions: https://github.com/trilbymedia/grav-plugin-image-captions/commit/80fa7cb931f306475e03920ef297899b488fe1cc

Also image-captions 1.0.3 released, should show up soon...

@rhukster Thank you, great work. :-)
I had a look at the start of processFigures and had this part in mind, but could not imagine that a simple terminating return was harmful. Did not want to give silly hints with levity, sorry.


make configuration key in Consul configurable

Hi，we are using multi-gateway with ReRoutes in one consul store,and ReRoutes are diffrent for each gateway.
I see Ocelot can only recognize the fixed key InternalConfiguration.
Could you make it configurable？
Thanks for your time!

@zpf1989 yes we can definitely take a look at this! How do you think this should work?

Well,should we add a node(something named like ConfigurationKey) for the ServiceDiscoveryProvider node in ocelot.json ,besides the Provider,Host and Port?
And when fetching configuration from Consul,ConsulFileConfigurationRepository may use the  ConfigurationKey first,then the default key(InternalConfiguration) if ConfigurationKey is empty.

@zpf1989 sounds perfect to me!

Thank you very much!!
I will try it later.


The code doesn't reflect the change of topic edit box

I edited the topic in the topic edit box, but the code still shows default topic

When you change the topic, you need to click the save button. And then the code in editor will reflect the change


Allow column width size to be changed

The ability to manually change the column width in all sub sections, user experience should be consistent across the application and this feature added to all section that have columns.
Some columns are not auto sized correctly or I may want to see more of a column as not all data show.
As an example the node column under Workloads - Pods
for me typically columns like node are not displaying the last 2 or 3 characters. It would be nice to be able to extent this column's width to make the content visible at the expense of other columns or for a horizontal scrollbar to become visible.
Using Lens 2023.1

Desktop OS: Windows 11

Duplicate of #601


After trick answers have been entered, trim any leading or trailing spaces

Lets do this as part of https://github.com/rightoneducation/righton-app/issues/43 since it's kinda a simple version of input validation work that we need to design and implement in client.

Following up with our 10/20 chat: here's a draft wiki with global input validation requirements:
https://github.com/rightoneducation/righton-app/wiki/Trick-Answer-Input-Validation


Remove spmd from repo

Description
Remove spmd from repo as most part has been uploaded to PyTorch

Thanks for cleaning this up!


⚠ ClamAV has degraded performance

In 680c432, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 67 ms

Resolved: ClamAV performance has improved in 24341d8.


Ci patch numpy2.0.0 error

Fix current error of NumPy 2.0.0 integration for different library dependencies.

Hello @McBs! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file setup.py:

Line 15:80: E501 line too long (107 > 79 characters)


Publish for Scala 3 + Native

Supersedes/backports (?) https://github.com/scalameta/munit/pull/477.
This PR is based against https://github.com/scalameta/munit/commit/92f3ad9e8261b4c142a551baaf61ef5fed84d36a aka v0.7.29. This is so that these changes can be released as 0.7.30, instead of a milestone of 1.0.0 which the ecosystem has not yet adopted.
Since there are conflicts with subsequent changes on main, I'll need a series/0.7 branch to target this to.

@armanbilge https://github.com/scalameta/munit/tree/series/0.7 is at your disposal.

Green! Although credit where credit's due, I didn't contribute a single change to this PR 😂

On Discord we decided instead of backporting to 0.7.x it's time to cut a stable 1.0. So closing in favor of the other PR.
https://discord.com/channels/632642981228314653/671278431102697472/962322218652692572


Feature Request: it would be nice to offer the option to concatenate along the "record" or "unlimited" dimension, as nc4 calls it, almost always "time"

This would also hopefully allow for it to show up in panoply properly with multiple granules in different locations at once
Yea you're already consulting umm-var in L2SS anyway I think. You could reliably get the record dimension from there, or from the netcdf itself if it's a good one

This feature request is the use-case that stitchee was designed for; stitchee concatenates along an existing dimension, such as the record/unlimited dimension.
Note that stitchee tackles the concatenation process by leaning on xarray's concatenation functions, in contrast to concise, which has a more elaborate method of performing parallel read/writes.


plugin prevents successful weave launch on reboot

The plugin is started with a restart policy of always. Consequently, if you have a startup script that runs weave launch, such as our published systemd, it will fail the 2nd time round, since weave launch will report weaveplugin is already running; you can stop it with 'weave stop-plugin'. and exit with status 1.

If there was a $WEAVEPLUGIN_DOCKER_ARGS, then folks who didn't want the restart policy could put --restart=none there.

Although that may not work work if you actually use the plugin; I've seen Docker get stuck trying to talk to the plugin before starting to accept commands.

In a configuration I've been building, I've gone with 4 systemd unit files, plus an environment file, which I've attached.
These files might be helpful for #1836 too.
The only problem with this arrangement is that the weave-plugin service doesn't start cleanly on a reboot because launch-plugin exits uncleanly. Perhaps a "--ifnotlaunched" or similar flag could be made available so that the weave script returns 0 if the plugin is already running.
weave-config.txt
weave-proxy.service.txt
weave-expose.service.txt
weave-plugin.service.txt
weave-router.service.txt

Fixed by b3a29bec1b98aca7bdd0a987e4e4e4909f7d8fb0


[3858] Add a rake task to import dttp trainees without academic years

Context
TBC, this can be run as  bundle exec rails dttp:import
Changes proposed in this pull request
Guidance to review
Important business

Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?

 [M] Import DTTP trainees without academic years


[Initialization of SS frame] Should change fonts and color.

Now we have 3 different fonts here, should change it to one font and change purple color to blue.

will be changed after DevExpress eliminated if needed (as we are transferring to launcher)


fix: Add nodenext option

Closes https://github.com/SAP/cloud-sdk-backlog/issues/1256
As explained in the ticket.

[q] Just curious, what about other module kinds like es2022?

moduleResolution nodenext requires that module is also nodenext.
We can add it as an option, but it doesn't fix this specific issue.


How to upload .mew file log?

I was trying to report an issue on another mod and tried to load my .mew log file to the issue post but GitHub won't let you do that with your .mew file type. Sorry if this isn't the place to put this, I haven't used GitHub much.

No worries. Just wrap it in a zip file; honestly I probably need to rework how that log file is shared I just haven't been actively modding lately.


Exclude failing UTC test on MacOS on Eclipse only

An extension of https://github.com/adoptium/aqa-tests/pull/5447/files
ref https://github.com/adoptium/infrastructure/issues/3361

Could someone with write access please merge. Thanks


Useful links (eg. to Wiki, Gameswith, /r/granblue_en)

The GUI library I'm using doesn't yet support SysLinks so this isn't yet possible - but it is something I may add in the future if the GUI transitions to use Iced or NWG gets support for SysLinks.
see:
https://github.com/gabdube/native-windows-gui/issues/227

I found a workaround to this by using the open crate instead of using SysLinks. Quicklinks are available in the File Menu under Helpful Links.


print to stdout instead

printing to stdout we can use it in scripts and pipe to other programs, or redirect to a file

Piping content over system io is not really fast, so it should be avoided in my mind.
I don't think it is slow enough to not use, but regardless of performance, this is a common standard for CLIs. Personally, I think it makes sense in this case and allows more flexibility in scripts. If you want people to use the library, why make the CLI part?

Usually use a -o option to choose an output file


install fails with pip 6+

installing django versatile image field with pip 6+ raises the following error
Collecting django-versatileimagefield
  Using cached django-versatileimagefield-0.5.tar.gz
    Traceback (most recent call last):
      File "<string>", line 20, in <module>
      File "/var/folders/vc/7wgsmmhd2xl2v5djtg7m74n00000gn/T/pip-build-m_GYdH/django-versatileimagefield/setup.py", line 22, in <module>
        for ir in parse_requirements('requirements.txt')
      File "/usr/local/Cellar/python/2.7.9/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/pip-6.0.3-py2.7.egg/pip/req/req_file.py", line 19, in parse_requirements
        "parse_requirements() missing 1 required keyword argument: "
    TypeError: parse_requirements() missing 1 required keyword argument: 'session'
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):

      File "<string>", line 20, in <module>

      File "/var/folders/vc/7wgsmmhd2xl2v5djtg7m74n00000gn/T/pip-build-m_GYdH/django-versatileimagefield/setup.py", line 22, in <module>

        for ir in parse_requirements('requirements.txt')

      File "/usr/local/Cellar/python/2.7.9/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/pip-6.0.3-py2.7.egg/pip/req/req_file.py", line 19, in parse_requirements

        "parse_requirements() missing 1 required keyword argument: "

    TypeError: parse_requirements() missing 1 required keyword argument: 'session'

    ----------------------------------------
    Command "python setup.py egg_info" failed with error code 1 in /var/folders/vc/7wgsmmhd2xl2v5djtg7m74n00000gn/T/pip-build-m_GYdH/django-versatileimagefieldd keyword argument: 'session'

This issue has been fixed and released to PyPI in the 0.5.1 release.


[gRPC] Give proper error message when failed to create proto file

Description:
At compile time, compiler derive gRPC service descriptor using compiler plugin and creates proto file according to the service descriptor. We need to give proper error message, when compiler fails to derive service descriptor.

Closing this issue, since fix is merged to master branch


ALL: Buttons (see comments / screenshot)

I imagine our 'buttons' should have some rule around the margin surrounding the button.
See this screenshot :

Zeplin (on the left) has some horizontal left/right spacing- we may want something along these lines by default for our buttons. (screenshot shows github on right)
Zeplin also shows "gotham medium" for the button text when github shows gotham book - granted I think 'book' looks better here we should likely adhear to the approved Zeplin specifics.

@fuhton
PR submitted for this issue:
https://github.com/JDRF/design-system/pull/21

Merged.

@fuhton
Submitted a PR with this change only:
https://github.com/JDRF/design-system/pull/24

Merged. Will review locally.

Looks good.

buttons should be “gotham medium” font weight - on our stage we have them as “book” still

Also just noticed that "button outlines" should have a 2px border instead of the current 1px.

Our toggle segment/icon styling is off.
For theToggle Segment: Zeplin shows white bg, with green border color. "selected" state shows the green bg.
For the Toggle Icon Bar: Zeplin shows default state with the white bg. "selected" state shows the darker gray background.

Staging just shows the 'gray bg' at all times for both:

Toggling isn't complete yet. I'll be adding the JS to make it work correctly in #18 .
@RachelRVasquez Let's address @McCallumDillon 's other two comments.

I'll be taking over all work regarding this ticket.

@McCallumDillon @fuhton
The styles should be correct on staging now - the PR just needed to be merged in.
https://github.com/JDRF/design-system/issues/15

@McCallumDillon Will create another PR for the border width on buttons.

Outline is correct now. Toggling moved to a new ticket.