Reprojected face region

Hi,
You have done a grat work! I am confused about reprojected face region in 4.1.1 of your paper. Could you please explain it a little bit more?
Thanks

Hi, the reprojected face region is just the region of the face in the rendered image, which can be directly obtained via the rendering process.

Hi, the reprojected face region is just the region of the face in the rendered image, which can be directly obtained via the rendering process.
Hi，yudeng，do you mean the pix_mask obtained via the rendering process?
pixel_mask = tf.cast(tf.reduce_any(diffuse_colors >= 0, axis=3), tf.float32)
But I find that the pixel_mask is upside down while the render_image isn't , do I need to turn the pixel_mask myself or is there any settings I ingored?
I would appreciate it if you could give me some advices.

Hi，yudeng，do you mean the pix_mask obtained via the rendering process?
pixel_mask = tf.cast(tf.reduce_any(diffuse_colors >= 0, axis=3), tf.float32)
But I find that the pixel_mask is upside down while the render_image isn't , do I need to turn the pixel_mask myself or is there any settings I ingored?
I would appreciate it if you could give me some advices.

Hi, the reprojected face region is just the region of the face in the rendered image, which can be directly obtained via the rendering process.

Hi，yudeng，do you mean the pix_mask obtained via the rendering process?
pixel_mask = tf.cast(tf.reduce_any(diffuse_colors >= 0, axis=3), tf.float32)
But I find that the pixel_mask is upside down while the render_image isn't , do I need to turn the pixel_mask myself or is there any settings I ingored?

Also，how can I get the 2D pixel position of 3d landmarks?
I would appreciate it if you could give me some advices.


Add ~/.virtualenvs to python.venvFolders

Issue Type: Bug
by default, the command ran when installing Pylint defaults to 'python.exe -m pip install -U pylint --user' and gives the error 'Can not perform a '--user' install. User site-packages are not visible in this virtualenv.'
Extension version: 2019.2.5433
VS Code version: Code - Insiders 1.32.0-insider (c23e8995f6e31b3540e0a2c3d4fdc58e6d7cba53, 2019-03-04T17:23:10.903Z)
OS version: Windows_NT x64 10.0.16299

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-2600 CPU @ 3.40GHz (8 x 3392)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
15.96GB (4.30GB free)

Process Argv

Screen Reader
no

VM
0%

Have the same issue with virtualenvwrapper.
Steps to reproduce this issue:
# install virtualenvwrapper
pip install virtualenvwrapper
source /usr/local/bin/virtualenvwrapper.sh

# make venv
mkvirtualenv foo

# create dirs
mkdir -p foo/.vscode
cd foo

# create vscode config with venv set
cat <<EOF > .vscode/settings.json
{
    "python.pythonPath": "~/.virtualenvs/foo/bin/python"
}
EOF

# create python file
echo "print('foo')" > foo.py

# open vscode
code .

After vscode has opened, click on foo.py and wait for the Linter pylint is not installed message. Press Install and see the error

Stumbled on this today too using virtualenvwrapper.
I wonder what changed.
#808 seems to be a similar issue.

So it seems that setting globalModuleInstallation to true fixes it.

but that seems not what we want. We just want the module to be installed in the current environment. So that is slightly weird. Let's try.
I have set globalModuleInstallation to true in my workspace settings and it worked.
The linter was installed in the virtualenv.
ls -al ~/.virtualenvs/webcompatcom/lib/python2.7/site-packages/flake8
total 456
drwxr-xr-x   25 karl  staff    800 14 mar 09:53 .
drwxr-xr-x  110 karl  staff   3520 14 mar 09:53 ..
-rw-r--r--    1 karl  staff   2118 14 mar 09:53 __init__.py
…

and not globally.

It seems we are not detecting that the virtual environments created by virtualenvwrapper are not virtual environments. I'm not sure if it's because it's in a global location or some other reason.
@cebor @karlcow if you set "python.venvPath": "~/.virtualenvs" does that solve the problem?

@brettcannon yes that worked for me.

Prescribed Solutions:

Remove defaults from pythonPath.venvFolders defined in package.json
Leave python.venvFolders as is but with a default value of []
Hardcode the defaults currently defined package.json for python.venvFolders in code.

This way, the defaults are hardcoded and users cannot remove them (as we don't see the need for that - not yet)

Hardcode defaults in src/client/interpreter/locators/services/globalVirtualEnvService.ts in the getSearchPaths method.

Combine the value provided by user in settings along with the hardcoded values.

Do note that ~/.virtualenvs is the wrong value as venvFolders is explicitly documented as being directories in your home directory (hence why there has been talk of dropping the setting and coming up with a new one that let users specify any directory; maybe we could just modify a user's settings to prepend ~/ and then add support for user expansion?).

Also add whatever the following tools use:

[ ] pipenv
[ ] virtualenvwrapper

Can probably also do #118 at the same time since it mostly likely should be done in the same place in the code. It also will let us say in the docs in package.json for this setting to say we support virtualenvwrapper and pipenv instead of listing specific directories.

Todo:

[ ] Move defaults from package.json's pythonPath.venvFolders to src/client/interpreter/locators/services/globalVirtualEnvService.ts in the getSearchPaths method
[ ] Add .virtualenvs as one of the hardcoded values
[ ] Set defaults from package.json's pythonPath.venvFolders to []
[ ] Combine the value provided by user in settings along with the hardcoded values. ⚠ remove duplicates (when path is expanded)
[ ] Add folders used by pipenv and virtualenvwrapper to defaults (#5899) (OS-specific folders?)
[ ] Add WORKON_HOME to defaults if set (#118)
[ ] Update docstring in package.json to say that we support pipenv and virtualenvwrapper directories (check settings UI) 🎉

Aren't these out of scope (i.e. Separate issue)
Add folders used by pipenv and virtualenvwrapper to defaults (#5899) (OS-specific folders?)
 Add WORKON_HOME to defaults if set (#118)

#5899 was closed as a duplicate of this one, i believe it's just about adding .local/share/virtualenvs along with .virtualenvs?
for #118 you're right I'll remove the last 2 boxes since they belong to it

@DonJayamanne they aren't out of scope if those are the projects the reasons we are adding these defaults. 😁 The key point is to know whether we know we need to add more or whether this covers everything.
And the WORKON_HOME is necessary to not have a half-baked solution for those tools, otherwise we are only covering the hard-coded defaults and not what the tools actually use for users to specify their preferences. They can definitely be done as separate PRs, but I think not doing it now leaves a rough edge in our support and we don't have a good history of going back and shaved those rough edges down quickly.

And #5899 was closed because Luciana's specific ask in that issue was "support pipenv and virtualenvwrapper" which this might implicitly cover, otherwise we can do separate issues if necessary.

After discussion with @brettcannon and @luabud  we're not gonna add .local/share/.virtualenvs to python.venvFolders (so #5899)

@kimadeline Can we document the reason (or work around) in #5899


As a ward doctor in an emergency, I want to view the patient's status code on the patient's main page

So that I know at a glance during an emergency if the patient has a Do Not Resuscitate order

This is not essential as it is technically satisfied by #35

Not implementing. Fulfilled by view command.


Authentication fails when app is run in a sub-path

Issue / Steps to reproduce the problem
I have created an IdentityServer derived app but removed the default MVC based UI and created a pure HTML/JavaScript UI that calls a WebApi for Login/Logout.
It works fine when run in VisualStudio and also under IIS in the root path, say http://localhost:5001.
Now I would like to run it in IIS in a sub-path, say http://localhost:5001/Test
but this fails after committing the login form.
Relevant parts of the log file
Here are two excerpts from the log files, one for the root path and one for the sub-path. I marked the lines where they start to differ.
This one is from a test in the root path that works
2017-05-19 02:18:10.459 +02:00 [Debug] Augmenting SignInContext
2017-05-19 02:18:10.498 +02:00 [Information] AuthenticationScheme: "Identity.Application" signed in.
2017-05-19 02:18:10.498 +02:00 [Information] User 'root' logged in.
2017-05-19 02:18:10.500 +02:00 [Verbose] returnUrl is valid
2017-05-19 02:18:10.500 +02:00 [Verbose] IsValidReturnUrl true
2017-05-19 02:18:10.518 +02:00 [Information] Executing ObjectResult, writing value "Microsoft.AspNetCore.Mvc.ControllerContext".
2017-05-19 02:18:10.544 +02:00 [Information] Executed action "RiaIdentityServer.Controllers.AccountController.Login (RiaIdentityServer)" in 1028.3367ms
2017-05-19 02:18:10.546 +02:00 [Information] Request finished in 1042.045ms 200 application/json; charset=utf-8
2017-05-19 02:18:13.550 +02:00 [Information] Request starting HTTP/1.1 GET http://localhost:5001/connect/authorize/login?client_id=RiaIdentityServer&redirect_uri=http%3A%2F%2Flocalhost%3A5001%2Fcallback.html&response_type=id_token%20token&scope=openid%20profile%20RiaIdentityServerApi&state=4f3a4a1935a04c0496e731cd7e2a8cb0&nonce=38e89e380da84418916f4c85acd57e6e
####### 2017-05-19 02:18:13.682 +02:00 [Information] HttpContext.User merged via AutomaticAuthentication from authenticationScheme: "Identity.Application".
2017-05-19 02:18:13.683 +02:00 [Information] AuthenticationScheme: "Identity.Application" was successfully authenticated.
2017-05-19 02:18:13.683 +02:00 [Debug] Request path "/connect/authorize/login" matched to endpoint type Authorize
2017-05-19 02:18:13.683 +02:00 [Debug] Mapping found for endpoint: Authorize, creating handler: "IdentityServer4.Endpoints.AuthorizeEndpoint"
2017-05-19 02:18:13.683 +02:00 [Information] Invoking IdentityServer endpoint: "IdentityServer4.Endpoints.AuthorizeEndpoint" for "/connect/authorize/login"
2017-05-19 02:18:13.690 +02:00 [Debug] Start authorize request (after login)
2017-05-19 02:18:13.690 +02:00 [Information] AuthenticationScheme: "Identity.Application" was successfully authenticated.
2017-05-19 02:18:13.691 +02:00 [Debug] User in authorize request: "83504cd2-0473-4b05-b57e-72f94dba6be2"
2017-05-19 02:18:13.692 +02:00 [Debug] Start authorize request protocol validation
2017-05-19 02:18:13.692 +02:00 [Information] AuthenticationScheme: "Identity.Application" was successfully authenticated.
2017-05-19 02:18:13.692 +02:00 [Debug] Calling into custom validator: "IdentityServer4.Validation.DefaultCustomAuthorizeRequestValidator"
2017-05-19 02:18:13.692 +02:00 [Verbose] Authorize request protocol validation successful
2017-05-19 02:18:13.692 +02:00 [Information] ValidatedAuthorizeRequest

This one is from the failed test with the app running in the sub-path:
2017-05-19 02:07:33.190 +02:00 [Debug] Augmenting SignInContext
2017-05-19 02:07:33.228 +02:00 [Information] AuthenticationScheme: "Identity.Application" signed in.
2017-05-19 02:07:33.228 +02:00 [Information] User 'root' logged in.
2017-05-19 02:07:33.228 +02:00 [Verbose] returnUrl is valid
2017-05-19 02:07:33.228 +02:00 [Verbose] IsValidReturnUrl true
2017-05-19 02:07:33.246 +02:00 [Information] Executing ObjectResult, writing value "Microsoft.AspNetCore.Mvc.ControllerContext".
2017-05-19 02:07:33.264 +02:00 [Information] Executed action "RiaIdentityServer.Controllers.AccountController.Login (RiaIdentityServer)" in 1197.9142ms
2017-05-19 02:07:33.267 +02:00 [Information] Request finished in 1212.6975ms 200 application/json; charset=utf-8
2017-05-19 02:07:33.275 +02:00 [Information] Request starting HTTP/1.1 GET http://localhost:5001/Test/connect/authorize/login?client_id=RiaIdentityServer&redirect_uri=http%3A%2F%2Flocalhost%3A5001%2FTest%2Fcallback.html&response_type=id_token%20token&scope=openid%20profile%20RiaIdentityServerApi&state=c940d0f5598b4087ad28e291f6d0388e&nonce=e8d14e6fe710456080df6af8f6018bb8
####### 2017-05-19 02:07:33.276 +02:00 [Information] "Identity.Application" was not authenticated. Failure message: "Unprotect ticket failed"
2017-05-19 02:07:33.276 +02:00 [Debug] Request path "/connect/authorize/login" matched to endpoint type Authorize
2017-05-19 02:07:33.276 +02:00 [Debug] Mapping found for endpoint: Authorize, creating handler: "IdentityServer4.Endpoints.AuthorizeEndpoint"
2017-05-19 02:07:33.277 +02:00 [Information] Invoking IdentityServer endpoint: "IdentityServer4.Endpoints.AuthorizeEndpoint" for "/connect/authorize/login"
2017-05-19 02:07:33.284 +02:00 [Debug] Start authorize request (after login)
2017-05-19 02:07:33.288 +02:00 [Error] User is not authenticated
2017-05-19 02:07:33.295 +02:00 [Verbose] Invoking result: "IdentityServer4.Endpoints.Results.AuthorizeResult"
2017-05-19 02:07:33.347 +02:00 [Verbose] Protecting message: "{\"Id\":\"541e482e7e6ffbecdae22cdd43636db0\",\"Created\":636307492533100205,\"Data\":{\"Error\":\"server_error\",\"RequestId\":\"0HL4U9C0Q8DLK\"}}"
2017-05-19 02:07:33.354 +02:00 [Information] Request finished in 78.9716ms 302
2017-05-19 02:07:33.359 +02:00 [Information] Request starting HTTP/1.1 GET http://localhost:5001/Test/error.html?errorId=541e482e7e6ffbecdae22cdd43636db0
2017-05-19 02:07:33.359 +02:00 [Information] Sending file. Request path: '"/error.html"'. Physical path: '"C:\inetpub\wwwroot\RiaIdentityServer\Test\wwwroot\error.html"'
2017-05-19 02:07:33.360 +02:00 [Information] Request finished in 1.1124ms 200 text/html

Here is the code from ConfigureServices:
    //Custom class that reads the clients/resources from a file
IIdentityServerConfig idsc = new IdentityServerConfig(Configuration);

services.AddIdentityServer(options =>
{
	options.UserInteraction.LoginUrl = "/api/Account/Login";
	options.UserInteraction.LogoutUrl = "/api/Account/Logout";
	options.UserInteraction.ErrorUrl = "/error.html";

})
	.AddTemporarySigningCredential()
	.AddInMemoryIdentityResources(idsc.GetIdentityResources())
	.AddInMemoryApiResources(idsc.GetApiResources())
	.AddInMemoryClients(idsc.GetClients())
	.AddAspNetIdentity<ApplicationUser>();

I currently have no idea how to further diagnose this issue. I can not debug it in Visual Studio because I don't have it running in a sub-path there.
I would appreciate any idea. Please let me know if more information or code is necessary.

After a couple more tests I found out that this is simply a cookie problem. First running the app in VS produces a cookie with the root path in it. Then running the same app in a sub-path under IIS leads to the mentioned problem. Deleting cookies fixes it. Sorry for reporting another seemingly bug that again turns out to be simply incompetence on my side ;-)

It also might be a casing issue -- keep in mind that URLs are case sensitive and that if the client has the wrong case, the browser might not send the auth cookie if the redirect URL is incorrect.


Builds fail if root project is in root of mount point, with further implications

Building any project in a root mount point (e.g. C:/ for Windows or / for *nix) fails unless settings.gradle has a rootProject.name= value specified.
Expected Behavior
Gradle should not be smart about the project name, by deducing it from the directory name, but it should be specified explicitly. Especially, this is problematic in a multi-developer environment where the project name can vary greatly depending on what developers are naming their clone directories, and it will affect what's getting reported to Gradle Enterprise, thereby polluting data.
I suppose it could be discouraged as a deprecation, then to be disallowed in a future major release.
Current Behavior
A problem occurred configuring root project ''.
> The project name must not be empty. Set the 'rootProject.name' or adjust the 'include' statement (see https://docs.gradle.org/6.7.1/dsl/org.gradle.api.initialization.Settings.html#org.gradle.api.initialization.Settings:include(java.lang.String[]) for more details).

Context
This was causing issues when I mounted a shared folder in a Windows VirtualBox environment.
Steps to Reproduce
$ gradle -p / --project-cache-dir=$HOME

Your Environment
OS: Windows/macOS
Gradle: 6.8-rc-4

Verified this happens as described.


Refactoring - grid property collection

Refactoring of grid_property_collection.py to reduce complexity.
Remaining functions relating to vdbs have been unchanged as coverage is low.

Codecov Report

Merging #354 (cfdaa55) into master (06f44ee) will increase coverage by 0.03%.
The diff coverage is 90.18%.

:exclamation: Current head cfdaa55 differs from pull request most recent head 0027b20. Consider uploading reports for the commit 0027b20 to get more accurate results

@@            Coverage Diff             @@
##           master     #354      +/-   ##
==========================================
+ Coverage   72.16%   72.20%   +0.03%
==========================================
  Files         157      157
  Lines       28119    28159      +40
==========================================
+ Hits        20293    20333      +40
  Misses       7826     7826

Impacted Files
Coverage Δ

resqpy/property/grid_property_collection.py
58.27% <90.18%> (+3.92%)
:arrow_up:

resqpy/model/_xml.py
85.86% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06f44ee...0027b20. Read the comment docs.


ED3 in the alt buffer should erase the main scrollback buffer

Environment
Windows build number: Version 10.0.18362.356
Also tested with a recent build from source: 171f00c2656731e5ba0185dbbf337389fb7030bd
Steps to reproduce

Start a WSL bash shell in conhost.
Do a long directory listing so you get some content in the backscroll buffer.
Execute this command: printf "\e[?1049h\e[3J\e[?1049l"

That command switches to the alternate buffer (private mode 1049), executes the ED escape sequence with parameter 3 (i.e. erase the scrollback buffer), and then switches back to the main buffer.
Expected behavior
The alternate screen buffer doesn't have a scrollback, so the ED3 sequence should erase the main scrollback buffer. Then when you switch back to the main screen, there should be no scrollback any more.
This is how the command is implemented in XTerm, and most of the other terminal emulators I've tested.
Actual behavior
The main scrollback buffer isn't erased.
This is probably somewhat related to issue #3545. I think the alt screen technically has its own scrollback (even though it's zero length), and it's that empty buffer that is being "erased" when ED3 is executed. It might be better if the alt screen shared the same buffer as the main screen.

It might be better if the alt screen shared the same buffer as the main screen.

I disagree with this bit, in fact, it should be the exact opposite: operations performed on the alternate screen shouldn't be able to place anything in the (normal screen's) scrollback. See #3492.
That being said, I think ED3 could easily wipe out the normal screen's scrollback even when the alternate screen is active, as done in at least xterm and vte, to address this issue.

operations performed on the alternate screen shouldn't be able to place anything in the (normal screen's) scrollback.

I realise that. But I think that could be achieved fairly easily by treating the alternate screen as if the viewport were fully enclosed in scrolling margins, so the content is scrolled out of existence instead of panning the viewport down. By doing things this way, the user can then still manually pan the viewport up to see the scrollback from the main screen, which is what XTerm lets you do.
I don't think the VTE way of doing things is necessarily bad - it certainly seems less buggy than XTerm - but XTerm is the de facto standard for this stuff, and I thought that was what we were trying to emulate.

which is what XTerm lets you do

XTerm is weird here: if you're on the alternate screen, you can scroll back by dragging the scrollbar, but not using the keyboard. If you don't have the scrollbar enabled, you're out of luck.
(On the other hand, it's a great thing that Shift+PageUp and similar keypresses can be sent to the application running on the alternate screen.)

But I think that could be achieved fairly easily by treating the alternate screen as if the viewport were fully enclosed in scrolling margins, so the content is scrolled out of existence instead of panning the viewport down.

This is indeed one possible way of thinking about it, although IMO a problematic one. There are more scenarios to keep in mind. E.g. when enlarging the window, contents shouldn't be brought back from the scrollback to the alternate screen. When rewrapping (which XTerm doesn't do so can't be taken as reference), the scrollback should be rewrapped as a contiguous region with the normal screen (#3491 + #3492), i.e. even at their boundary reflow or not depending on whether there's an explicit newline there. When selecting a word by double-clicking at the upper-left corner, or autodetecting URLs etc., on the normal screen it should include the scrolled-out bits if there was an implicit overflow, on the alternate screen it shouldn't. Etc.
I believe all this logic is much more cumbersome (although certainly possible) to get right if you think of the scrollback as a shared resource, and becomes much easier if you think of the scrollback as belonging to the normal screen only.
That being said, when the alternate screen is active, you could still show the normal screen's scrollback lines if the user scrolls back. It's not done in VTE, but could easily be done. Or it could even show the entire normal screen above the alternate one, followed by its scrollback if you scroll back even further, which would arguably make more sense. (Really, what's the point in seeing all the previous normal screen activity, except for the last ~24 lines, when you scroll back from the alternate screen?) With this approach it's merely a presentation thing to display the normal screen's scrollback, if you wish to.

I believe all this logic is much more cumbersome (although certainly possible) to get right if you think of the scrollback as a shared resource, and becomes much easier if you think of the scrollback as belonging to the normal screen only.

You may well be right. But with what I know of the code base, I'm not certain I could make it work with separate buffers, but I do think I'd have a chance with a single buffer. But really it's up to the person that is assigned the issue. If it's not me, I don't really care.

Seems reasonable to me. Since the alt buffer and main buffer are both just separate SCREEN_INFORMATION objects, it shouldn't be too hard to detect when we're in the alt buffer and perform that erase operation on the main buffer instead.

printf "\x1b[?1049hThis is the alt buffer" ; sleep 1 ; printf "\x1b[3J" ; sleep 3 ; printf "\x1b[?1049l"

xterm shows the length of the scrollbar, then after the 3J you can see it cleared
VTE has the scrollback cleared when you get back to the main buffer

just getting a useful repro set up.


updated hammer image

Description
I could reproduce the issue in centos7, updated them to use centos:8.
Fixes #142
Type of change
Please select the appropriate options:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] This change is a documentation update

Testing
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Tested locally
[ ] Test B

Test Configuration:

Versions:
Hardware: Dell R640

Checklist

[ ] I have performed a self-review of my own code
[ ] If a change is adding a feature, it should require a change to the README.md and the review should catch this.
[ ] If the change is a fix, it should have an issue. The review should make sure the comments state the issue (not just the number) and it should use the keywords that will close the issue on merge.
[ ] A change should not be merged unless it passes CI or there is a comment/update saying what testing was passed.
[ ] PRs should not be merged unless positively reviewed.

@akiselev1 could you test this patch and let us know ?

@akiselev1 could you test this patch and let us know ?

Yes, the fix works for me. I can try the final version as well - let me know.

The new version works fine as well.


How to test the fps of the program？

Hello author, may I ask how to test the fps of the program？
Can you tell me the general method? I'm doing a comparative test.
Thank you!

We simply set a time counter between the network forward and the model output to get the runtime. We run the whole test set and calculate the mean of runtime for each frame. The inference time is reported in our paper.

We simply set a time counter between the network forward and the model output to get the runtime. We run the whole test set and calculate the mean of runtime for each frame. The inference time is reported in our paper.

hello, I can't find the  runtime in your paper, I wonder know the how much fps in one 2080ti in the test phase! thanks a lot !


Windows core

Adding Configuration for Windows Core API (WinCore64A, WinCore32),to OneCore ready (available to run on various versions of Windows (mobile, IoT, Desktop etc)
https://docs.microsoft.com/en-us/windows-hardware/drivers/develop/building-for-onecore
Available in WDK and latest versions of Windows 10.

I'd like to suggest to put it into separate file in Configurations, e.g. 50-win-onecore.

If I just configure for VC-WIN64A and replace libraries with onecore.lib onecore_downlevel.lib and add /nodefaultlib:kernel32 I get fully functioning build. If I don't add onecore_downlevel.lib, then I get linking errors from cryptlib.obj alone. Meaning that I fail to see need for any modifications but for cryptlib.c. But as already said, suggestion is to start with onecore_downlevel.lib and consider cryptlib problem separately. On related note this starts connecting to suggestion to compile for ARM in #4920, because it also has to be linked with onecore. If nobody minds I can cook something together that would solve both problems, or at lest be first step in solving problems. This means that both requests, this and #4920, would be closed, and common discussion would be held in another one.

@dot-asm yes, please do that!  Close the two PR's one yours is posted!

Close/reopen to kick CLA bot.

Microsoft is pushing application vendors to actually be compatible with OneCore Api this Spring, official OpenSSL configuration would help to prepare and meet their unrealistic expectations.
Changes are not huge at all, there is only one problem to be handled and this is EventLogging (Error handling) on cryptolib.c which cannot be supported on OneCore, the only alternative there is ETW system.
Added configuration does not have any real impact on other existing configurations as it only changes the way how OpenSSL is linking with system libraries and how single method handles SystemEvents (for core conf only).
These changes will help testing applications and OpenSSL on core based windows versions, or Microsoft Store apps (UWP), if it is possible to move this feature to current milestone, it would be very appreciated.

Side thing: do we know if appveyor has the possibility to test onecore builds?  In that case, it would be interesting to add onecore cases to appveyor.yml and see how the builds go...

OneCore configuration does not bring new features to be tested at all, it's main purpose is to link with system via proxy lib. I guess tests cases should remain this same (to make sure, there is no regression)
Dunno how continuous integration works here but there is special environment needed to build and test this configuration out.
It must be an UWD system, some modern windows extended with newest Development Kit's, not sure which one tho, i have ADK, SDK, WDK at least one needed, should also work (no building, testing only) on some modern W10RS3.

Hi,
Some apps are forced by Microsoft to be Uniform (UWD) this spring, for security reasons it is better for them to use official branches from OpenSSL community rather than locally made on their own.
I'd like to know when We can expect adding OneCore configuration to OpenSSL?
I've found release strategy below, which one (approx.) can be UWD?

13th February 2018, alpha release 1 (pre1)
27th February 2018, alpha release 2 (pre2)
13th March 2018, beta release 1 (pre3)
OpenSSL_1_1_1-stable created (feature freeze)
master becomes basis for 1.1.2 or 1.2.0 (TBD)
27th March 2018, beta release 2 (pre4)
10th April 2018, beta release 3 (pre5)
24th April 2018, beta release 4 (pre6)
1st May 2018, release readiness check (new release cycles added if required, first possible final release date: 8th May 2018)

I'd like to know when We can expect adding OneCore configuration to OpenSSL?

You need to get two approvals on this PR before it can go in (one OMC approval, one committer approval). It's not clear to me what needs to happen with this to get it moving, although it looks like @dot-asm has some issues that need resolution?
Anyway, in order for this to be included in the 1.1.1 release it has to have been merged by 13th March 2018 (which is the feature freeze date). Otherwise it will have to wait for the next release (which is not yet scheduled, but is likely to be some time away).

I can take a look as well...

This seems to build and test properly (I tried VC-WIN64A-core)...  I haven't tried actually running the changed code in cryptlib, but I don't really see that the discussion about onecore_downlevel.lib is relevant any more...

Yeah, there is an issue that @dot-asm pointed out - the only problem with linking via OneCore.dll I ecountered is that core API does not provide writing to SystemEventLog, Microsoft is forcing usage of EventTracingWindows (ETW) technology, (It's larger and more generic eventing system, Legacy EventLog is kind of one of the many usages of ETW).
I've addressed that issue by changing previously disabled eventing (which was the reason for @dot-asm issue) into ETW TraceLogging in some commit later, but they never got reviewed again.
Also it's not quite easy task to deal with, I couldn't find satisfying solution here, every got some cons.
Somewhere earlier was mentioned removing all error presenting functionalities from library and just returning statuses  (I'd love that solution, why crypt lib interacts with GUI?),
but it can take some time, and probably imply adding after 1.1.1, maybe there is a way to find satisfying solution here that have a chance to enter 1.1.1, my suggestion is TraceEvent commited few weeks ago

Yeah well...  I think that for now, we are stuck with the general structure.  Considering how close we are to 1.1.1 beta, I'd say that changing that now is ill adviced (does anyone even have a plan?  I haven't heard of one).  So we do need to adapt how those out-of-band messages are delivered, and you've done that.  Case closed?
I'll do a quick test program just to test the tracing stuff...

@richsalz

You will also have to sign our CLA.

It looks, that request can be closed, CLA is already signed

Hi, is there a chance for second review and re-pinning this pull request to 1.1.1?

I don't feel for 50-core.conf file name. I'd say that core is too generic term, 50-win-core, or already suggested 50-win-onecore would be more appropriate.

On side note an odd observation. If I build for mingw, crypto/bio/bss_log.c contains code [calling event logging facility], but if I build for VC-WIN it's empty. Once again, this is a side note, it has lesser to do with this request, but it might emerge as problem afterwards...

I once again would like to suggest to start with onecore_downlevel.lib and consider omitting it as separate problem.

I once again would like to suggest to start with onecore_downlevel.lib and consider omitting it as separate problem.

So basically, you're asking for the crypto/cryptlib.c work to happen in a separate PR, right?

I've added onecore_donwlevel-based targets in #5502.

As already said (Api validation test on win-arm branch):

ApiValidation: Warning: API DeregisterEventSource in advapi32.dll is not a supported universal API. libcrypto-1_1.dll calls this API.
ApiValidation: Warning: API RegisterEventSourceW in advapi32.dll is not a supported universal API. libcrypto-1_1.dll calls this API.
ApiValidation: Warning: API ReportEventW in advapi32.dll is not a supported universal API. libcrypto-1_1.dll calls this API.
ApiValidation: Warning: API GetProcessWindowStation in user32.dll is not a supported universal API. libcrypto-1_1.dll calls this API.
ApiValidation: Warning: API GetUserObjectInformationW in user32.dll is not a supported universal API. libcrypto-1_1.dll calls this API.
ApiValidation: Warning: API MessageBoxW in user32.dll is not a supported universal API. libcrypto-1_1.dll calls this API.

https://docs.microsoft.com/en-us/windows-hardware/drivers/develop/building-for-onecore
OneCore_downlevel supports older version of windows like windows7 by wrapping non universal API (obselete), by the cost of running on newer versions and it does not a core version.
That mean calling this API will work on current desktop windows releases, but i won't work on versions such us Windows S, Windows RS4,Windows IoT Core (We want to have securely connected IoT devices right?), Apps containing openssl won't be able to be certified by MS Store. Simply - on some Windows version there is no legacy Eventlog. Microsoft provided apivalidator.exe application with SDK to validate if its Universal.
Downlevel version of library is only for old versions of Windows, (execs)
OneCore.dll is designed for newest releases, so is OneCoreUAP.dll which is extended to support UWP apps (appx)

And as already said, let's just treat them as two separate problems. Well, maybe "two-step" would be more appropriate term. Step 1. Add targets with onecore_downlevel.lib [which requires no source code modification], being done in #5502. Step 2. Add source code modification that allow to omit onecore_downlevel.lib. Once #5502 is merged, you can choose to close this request and move your changes to new request. Or you can re-base this request and proceed here. But nothing prevents you from resolving outstanding issues with source code modifications here and now, they can be resolved in parallel. What's the problem?

What I'm saying is that OneCore configuration linked to downlevel is not universal so it is just legacy but linked via proxy, no going forward.

The way I hear you both, you actually want the same thing, the only real difference is that @dot-asm wants it in two PRs, one for each particular change.

It rather looks like I want OneCore official OpenSSL version which can be certified in MS as universal - which targets for wide range od windows version - not only desktops, and also desktop RS4, RS5.
@dot-asm wants any version, which links to OneCore.dll which does not need to be universal, for current versions of arm Windows. I mean from OneCore conf perspective it's a tiny step which is just adding entry to conf file, which does not provide any changes in functionality.

@dot-asm wants any version, which links to OneCore.dll which does not need to be universal, for current versions of arm Windows.

Nope. Richard asked this very question and I answered that it would be totally possible and appropriate. Yes, I expressed some skepticism about Microsoft being actually consistent in its claims, and expressed worry that if Microsoft was actually that categorical about "onecore.lib and nothing else", then we might face bigger problem, bigger than source code modifications suggested in this request that is. But nowhere did I say that downlevel is a permanent keeper. ALL I'M SAYING* is let's break this thing into two steps. What is it that prevents us from doing this?

Actually nothing,

And personally I agree, every step forward even tiny is a good one, but I wonder, it may defer real changes.

#5502 is merged, and so this needs a re-base.
As for "it may defer real changes", well, did we get any closer today or yesterday? Talking about how important is it doesn't solve it...

I have an idea,
We've got here OneCore configuration which is not onecore at all, cause it can not run on onecore Windows versions, because it supports legacy api supported only on old desktop Windowses.
We can make this pull request 3-step.
In the first step we provided non oneCore  VC-WIN32-core conf
On the second we can provide truly universal VC-WIN32-core conf without EventLogging - (adnotating it) working already fully on pure OneCore api and can be used by any Windows even Windows S and IoT.
Second step would bring us possibility of using it by console apps.
As a third step we can enable it for non-console apps by providing some onecore eventing or by reorganizing openSSL to do not handle message presenting, and simplify it, by forcing applications using openSSL to do it based on statuses or whatever, as mentioned somewhere earlier in current discussion.
This would provide us adding fully universal onecore configuration which can be run on every Windows without recompiling it, for console apps just like now. And would be also good step forward to be fully universal.

You reverted INSTALL a bit far, I'd say...

yep

OneCore conf is all about being universal so it can run on every modern Windows, without recompiling.
It can be provided without real changes for at least console apps.
I Added new PullRequest: #5625
Currently onecore conf supports same pool of OS'es as normal WIN32, due to illegal legacy method calls, which make it useless. #5625 enables that feature for at least console apps.
It gives a huge leap forward for those who want to start their work on Universal apps.
Next step is to find substitute for EventLog (i suggested TraceLogging here) or rework message handling to actually do not present it on screen, by pushing it back to app who called it. So the other apps can handle these errors properly.

Hey, can You look at this? More and more projects require universal openSSL starting with upcoming Windows RS4  on April. #5625 Has been already reviewed here in #4965, so subsequent reviews are not a real effort. It can make this configuration useful and will be good thing to begin with.

Hey, can You look at this?

I don't follow, I left comments, https://github.com/openssl/openssl/pull/4965#pullrequestreview-100479214, https://github.com/openssl/openssl/pull/4965#pullrequestreview-101128259, and they were not addressed. What is it I'm supposed to look at? If expectations are that I just drop them, then no. I won't do that. Of course somebody else might have different opinion at approve this, I can't control others' minds...

As already said, I split that commit like You are,
The first part #5625 does not contain any event logging and its targeting console apps, so any of these comments applies to it. As said this commit at least makes onecore conf usefull, because now it is pointless due to non universal API called.


How use by_alias argument in jsonable_encoder

API that I'm implementing requires from me input and output in camel case style. But I want to use snake case in my python code and follow pep8. So I tried allow_population_by_alias in my config class from the pydantic model and it works as expected without fastapi. But in fastapi, I can get the right response only when I set by_alias in jsonable_encoder to true. Is it possible to use this argument somehow from route decorators? I know that pydantic docs says that it's bad practice to use allow_population_by_alias, but I don't know another way to implement the specification as I want. The best way will be to have in fastapi or pydantic decorator for auto-renaming fields like this in serde for rust, but it's not important for me now. I just want my code to pass these tests now:
import json
from typing import List

from fastapi import FastAPI
from pydantic import BaseModel, Schema

import pytest
from starlette.testclient import TestClient

app = FastAPI()

class Model(BaseModel):
    model_field: str = Schema(..., alias="modelField")

    class Config:
        allow_population_by_alias = True

@app.get("/models", response_model=List[Model])
def get_models():
    m = Model(model_field="string")
    return [
        Model(model_field=m.model_field),
        Model(modelField=m.model_field),
        Model(**m.dict()),
        Model(**m.dict(by_alias=True)),
    ]

@app.post("/models", response_model=Model)
def create_model(m: Model):
    return Model(**m.dict())

@pytest.fixture
def client():
    yield TestClient(app)

def test_get_models(client):
    with client:
        response = client.get("/models")
    assert response.json() == [{"modelField": "string"} for _ in range(4)]

def test_create_model(client):
    with client:
        response = client.post("/models", json.dumps({"modelField": "string"}))
    assert response.json() == {"modelField": "string"}

Here the thing is that even if you return a dict with the data as you want it, FastAPI will try to pass it to the Model in response_model and re-serialize it with that model.
But if instead of returning a Pydantic model or a dict you return a Starlette Response, it will use it as is.
Here's one way you could solve it (your same code and data requirements, but the tests pass):
from fastapi.encoders import jsonable_encoder
import json
from typing import List

from fastapi import FastAPI
from pydantic import BaseModel, Schema

import pytest
from starlette.testclient import TestClient
from starlette.responses import JSONResponse

app = FastAPI()

class Model(BaseModel):
    model_field: str = Schema(..., alias="modelField")

    class Config:
        allow_population_by_alias = True

@app.get("/models", response_model=List[Model])
def get_models():
    m = Model(model_field="string")
    content = jsonable_encoder([
        Model(model_field=m.model_field),
        Model(modelField=m.model_field),
        Model(**m.dict()),
        Model(**m.dict(by_alias=True)),
    ], by_alias=True)
    return JSONResponse(content=content)

@app.post("/models", response_model=Model)
def create_model(m: Model):
    content = jsonable_encoder(Model(**m.dict()), by_alias=True)
    return JSONResponse(content=content)

@pytest.fixture
def client():
    yield TestClient(app)

def test_get_models(client):
    with client:
        response = client.get("/models")
    assert response.json() == [{"modelField": "string"} for _ in range(4)]

def test_create_model(client):
    with client:
        response = client.post("/models", json.dumps({"modelField": "string"}))
    assert response.json() == {"modelField": "string"}

Thanks! I changed my code and now it works as I want

Great! Thanks for reporting back and closing the issue.


errors in server console log during startup

Tons of errors in server console log during startup
I am attaching the latest.log the errors are from line 267 to line 652
latest.log
Minecraft 1.16.5
Java 8 - 291
Forge 1.16.5-36.2.6
AE2 8.4.3
AE2 wt lib 0.3.2-1.16.5
Parsing error loading recipe ae2wtlib:wireless_universal_terminal/upgrade_pattern
Parsing error loading recipe ae2wtlib:wireless_universal_terminal/ip
Parsing error loading recipe ae2wtlib:wireless_universal_terminal/ci
Parsing error loading recipe ae2wtlib:wireless_universal_terminal/cp
Parsing error loading recipe ae2wtlib:wireless_universal_terminal/upgrade_interface
Parsing error loading recipe ae2wtlib:wireless_universal_terminal/upgrade_crafting

the 1.16 forge version is a different mod from a different person.
you can find it's issue tracker here

thanks


add SnapshotProvider to encapsulate Arc<SnapshotProviderInner>

Should close #6249.

@joshieDo anything to unlock here?

similar to the other PR, pointing to feat/static-files and should merge soon

closing this since it has been done on feat/static-files separately
Appreciate the PR, sorry it didnt get in!  It was easier to do it in another branch alongside some other requirement.


feat(pfCard): Add a loading state to the pfCards

Description
Adding a loading state feature to the remaining pfCards as a continuation of PR #661. This would close #662
pfAggregateStatusCard
pfInfoStatusCard
pfCards - Trends (example)

PR Checklist

[X] Unit tests are included
[X] Screenshots are attached (if there are visual changes in the UI)
[X] A Designer (@beanh66) is assigned as a reviewer (if there are visual changes in the UI)
[x] A CSS rep (@cshinn) is assigned as a reviewer (if there are visual changes in the UI)

@amarie401 what's the -22px position on the spinner container for? to compensate for default padding or something? If so, would it be possible to use a pf variable that corresponds to the thing that's being compensated for instead?

@amarie401 what's the -22px position on the spinner container for?

Hi @cshinn, when card is in the process of loading, it's body/contents are not shown, so there is no 'height' to the card.  These changes add a height and adjust the position of the spinner.

Wondering if, at minimum, we should all the consumer to set the card height when loading. When these cards are in a dashboard, the size changes may cause issues.

1 @jeff-phillips-18 I was wondering the same thing, if it would be a problem when card heights all of a sudden change on a dashboard.

Wondering if, at minimum, we should all the consumer to set the card height when loading

Ok, we could add a defaultCardHeight or a loadingCardHeight to the main status configuration obj.

I have added a loadingCardHeight option

Looking good, although the loading icon doesn't appear to be centered:
infoStatusCard:

aggregateStatusCard:

Seems like there is more space above the spinners than there is below the spinners.

Okay will look into it!

I have changed the name from loadingCardHeight to spinnerCardHeight for better correlation, unhid the title when loading and updated the ng-style to make the spinnerHeight more dynamic. @dtaylor113 are you still seeing the icon not being centered?

@amarie401 did you update the gif? I am still seeing that it isn't quite centered but I might be looking at an old version!

@beanh66 @dtaylor113
They seem to be centered to be in their respective cards. Although the frame that I recorded the gif isn't exactly the same..Thoughts?
aggStatus

infoStatus

The info status card should likely show the title and the icon just not the status information. The structure of the card, however, seems incorrect. The card-pf-title is inside the card-pf-body. Can we work around that and still show the title and image but replace the status info content with the spinner?

The info status card should likely show the title and the icon just not the status information.

Might the icon and/or title change based upon the loaded data? Ie. show an error icon/msg?  If so, we should just hide everything until the data is loaded.

The application can leave those values unset if that be the case. Can we try that scenario as well?

My point being, that a blank card with just a spinner gives no indication of what is being loaded. If any of the info can be shown, then it gives the user an idea of what they are waiting for.

Went looking to find PF doc/examples/css/HTML for this card, I can't find InfoStatusCard in any of these locations:
https://github.com/patternfly/patternfly-design/tree/master/pattern-library/cards
http://www.patternfly.org/pattern-library/cards/base-card/
https://rawgit.com/patternfly/patternfly/master-dist/dist/tests/card-view-single-select.html

@dtaylor113 The PR for this is still up in patternfly-design: https://github.com/patternfly/patternfly-design/pull/483

@dtaylor113 The PR for this is still up in patternfly-design: patternfly/patternfly-design#483

ah...that's why I couldn't find it :-)  So this seems to be a case of implementation before official PF html/css/less.

So this seems to be a case of implementation before official PF html/css/less.
Yeah, feel free to implement in PF first 😉

Still not exactly centered.  'with HTML' card doesn't initially set icon or title.  'Loading State' card  does initially set icon and title:

Does the icon have any margins? Seems like the icon is being pushed over

Hi, pushed latest changes.  The infoStatusCard spinner icon is now centered within the card, with and without titles/icons:

Now with the spinner height on the entire card

With @jeff-phillips-18 changes
aggStatus:

infoStat:

Not sure why your image above doesn't have the white background for the aggregate status cards. I pulled and tested and they correctly had the white background.

@jeff-phillips-18 I noticed that as well. The giphy recording tool I'm using is being a bit weird but the actual background is correct.


Sending verification email after successful commit

changed the position of the verification mail send command after the successful db commit. Fixes #5


Add mtls workloadCertTTL and mtls allowedClockSkew CLI commands

Describe the proposal
Currently there are several mTLS commands including enabling mtls and seeing the expiry dates of the root certs.
However the mtls CLI does not enable you to view or update the workloadCertTTL and the allowedClockSkew values for the certs issued to the application. Currently the only way to see and set these value on K8s, is to do this view kubectl command like this
kubectl get configurations/daprsystem --namespace dapr-system -o yaml
This is what you then get:
apiVersion: dapr.io/v1alpha1
kind: Configuration
metadata:
annotations:
meta.helm.sh/release-name: dapr
meta.helm.sh/release-namespace: dapr-system
creationTimestamp: "2022-02-03T23:27:45Z"
generation: 1
labels:
app.kubernetes.io/managed-by: Helm
name: daprsystem
namespace: dapr-system
resourceVersion: "78149"
uid: 5aa76e72-5b40-47f8-93b0-fd559f279c5c
spec:
metric:
enabled: true
mtls:
allowedClockSkew: 15m
enabled: true
workloadCertTTL: 24h

This proposal is to add two new commands to the CLI to view and set these values.
mtls allowedClockSkew  (views the current value)
mtls allowedClockSkew --timespan 0h10m. (or the best way to set a time range. sets a new value)
mtls workloadcertificateTTL (views the current value)
mtls workloadcertificateTTL --timespan 1h (or the best way to set a time range.)
Release Note

RELEASE NOTE:

@msfussell Do we need a CLI command for this? Each configuration file applied to an application is different and it is a simple YAML file. So It can be edited manually. I do not think we need a command for this.


Add body as a callback support to 4.2.4.

Brings Petr's changes from https://github.com/sabre-io/http/pull/65 into a branch based off the 4.2.4 release.
It also brings in this commit which bumps the dependencies - https://github.com/bigcommerce-labs/sabre-http/commit/4b6fef9d1af3801c84195ff11bf5be951e23b602
We currently have all these changes in the custom tag <IP_ADDRESS> - https://github.com/bigcommerce-labs/sabre-http/releases/tag/<IP_ADDRESS>.
I've re-authored the commits to keep them as the head of the branch.
Updating this component will bring us a much needed fix - https://github.com/sabre-io/http/pull/73 - which should resolve - https://rpm.newrelic.com/accounts/44889/applications/4757985/traced_errors/4dca0f16-5188-11e8-b482-0242ac11000f_18714_21831 - which has the highest number of reported errors on production.
https://jira.bigcommerce.com/browse/BIG-30701
This will also allow us to bring the main sabre/dav library up to date (we're also running a custom tag which also has changes from Petr).

ping @philipmuir @gwilym

Is there much that can be done about running a custom fork of this? How divergent are we?


DiscoveryPlus falling back to general extractor

D:>youtube-dln -v -o "%(title)s [WEBDL-%(height)s].%(ext)s" -f best -i --newline --cookies cookies.txt --console-title --all-subs --embed-subs https://www.discoveryplus.com/video/1990s-the-deadliest-decade/a-dangerous-man
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '-o', '%(title)s [WEBDL-%(height)s].%(ext)s', '-f', 'best', '-i', '--newline', '--cookies', 'cookies.txt', '--console-title', '--all-subs', '--embed-subs', 'https://www.discoveryplus.com/video/1990s-the-deadliest-decade/a-dangerous-man']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2021.01.08
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.18362
[debug] exe versions: ffmpeg git-2020-05-10-fc99a24, ffprobe git-2020-05-10-fc99a24
[debug] Proxy map: {}
[generic] a-dangerous-man: Requesting header
WARNING: Falling back on generic information extractor.
[generic] a-dangerous-man: Downloading webpage
[generic] a-dangerous-man: Extracting information
ERROR: Unsupported URL: https://www.discoveryplus.com/video/1990s-the-deadliest-decade/a-dangerous-man
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpe72mu9fe\build\youtube_dl\YoutubeDL.py", line 803, in wrapper
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpe72mu9fe\build\youtube_dl\YoutubeDL.py", line 824, in __extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpe72mu9fe\build\youtube_dl\extractor\common.py", line 532, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpe72mu9fe\build\youtube_dl\extractor\generic.py", line 3467, in _real_extract
youtube_dl.utils.UnsupportedError: Unsupported URL: https://www.discoveryplus.com/video/1990s-the-deadliest-decade/a-dangerous-man

I'm confused.....I'm using the new version that is supposed to have this issue fixed. I'm providing evidence that it was not, and my issue gets closed?

I'm confused.....I'm using the new version that is supposed to have this issue fixed. I'm providing evidence that it was not, and my issue gets closed?


Is it possible to replace html syntax with hyperscript or jsx?

I love lit-html concepts, simplicity and performance!
To be "perfect" I would like to be able to write this:
    return html`

        ${Jumbotron()}
        ${List()}

    `;

like this (jsx-like):
    return (

        <Jumbotron/>
        <List/>

    );

or like this (hyperscript-like):
    return (
      h('div', { id: 'app', className: 'no-select', style },
        Jumbotron(),
        List()
      )
    );

But, unfortunately it's not possible to write ES6 tagged templates programmatically as far as I know.
The main benefits I see to write the templates with, for example, hyperscript or jsx are:

Code migration / reuse: If you already have React functional components written you can just continue to use them but with no React at all. Lit-html will take care of reconciliation at great speed and developer experience.

Better abstractions for other use cases: Being jsx or hyperscript just function calls, you can target the dom (with lit-html) but you can also target other platforms like native-mobile. So, in theory, it will be possible to have the same example above producing <View>, <Text> or any other type of component, because being functions you can just produce whatever you want.

As a programmer I like to separate the WHAT of the HOW, so I can evolve the HOW without the need of (necessarily) touching the WHAT.
I know this is not an issue but I think may be a good topic to talk about.

The point of lit-html is to be able to write HTML templates in JS without a required transpiler. Supporting JSX goes against that and is out of scope for this project. There are existing JSX-to-lit-html compilers which you're free to use.
Hyperscript itself is already an option if you use it with a VDOM. For lit-html's approach it's not suitable because it doesn't separate the static and dynamic parts of a template. We need the static strings to build the HTML <template> element just once so we can clone it for instantiation.
Migrating React components to Web Components + lit-html is in scope, and maybe we'll see some tools pop up to do that. I don't want to invest in a lit-html specific component model though, we have Web Components for that.

Thanks, totally agree about avoiding transpilers (except maybe if you have some previous components already written in jsx).
The best possible scenario I think will be to produce tagged template literals programatically, so I can use lit-html as a renderer for html and another renderer for non-web.
Maybe in a future version of ES it will be possible :)
In any case, how does the code produced by tagged template literals look like inside lit? Maybe it will be possible to produce that code with nested function calls?

Lit-html uses the tagged template literal syntax ( ${ }) to determine which parts are static and which parts are dynamic. The problem with the syntaxes you suggest is that they have nothing that indicates which parts of the template are static, and which parts are dynamic. Without this there is no way to determine how to build the static part of the HTML <template> that can be re-used, which is essential for lit-html to work.
You can reproduce the behaviour of tagged template literals with function calls, which is what Babel does when it transpiles templates to ES5, but it looks nowhere as nice as your examples
You must have some kind of syntax that indicates that certain parts are static for the lit-html rendering algorithm to work. You would need something like this:
    // in render()
    return (
      h(appDiv,
        Jumbotron(),
        List()
      )
    );

    // somewhere global
    const appDiv = static('div', { id: 'app', className: 'no-select', style });

Which is close to what Babel does. If you inline the static() function in render() it can never be as efficient as lit-html, because will re-evaluate the static() function call on every render, whereas lit-html never needs to re-evaluate the static parts of the template, because of how tagged template literals work.
If you want to learn more, you can watch this ~1 hour video where I explain the internals of lit-html here:
https://www.twitch.tv/videos/322965922

@justinfagnani @ruphin Thanks a lot for your comments, I am going to take a look at the video later. I am closing this for now.

@justinfagnani @ruphin
lit-html is a great tool, thanks for it!
But template string is impossible to static type checking. Example:
html`<span color=${function totaliInvalid(){}}>${value}</span>`

Example is more evidently with using custom elements by tag:
html`<my-component property=${someValue}></span>`

^ Here typescript is useless and can't do anythink.
JSX works fine with it and perfectly checks all attributes and its values.
So, is it possible to create build-time compiler JSX -> template literals to use the full power of static type checking?

@artalar try lit-analyzer which provides type checking for lit-html templates. It works really nice.

@web-padawan wow! Looks awesome, thanks a lot!

I know it maybe harsh to say this, but what's the big deal to always know what's static and what's not. IMHO, if the prop doesn't change , then it's always static after initialization even when u code it as a pure dynamic component. Therefore the decision is more on the optimization side, ex. Memo.

waiting for the day chrome supports jsx and typescript tsx, unless it never won´t


Snapping system is not precise

From here:

It's hard to tell, but I think the handle points, when being dragged and snapped to things, are snapping a few pixels vertically offset from true. Try dragging a handle point and snapping it to the bottom of a neighboring shape and notice how it's below the bottom. This might also be the case for anchor points, but instead of vertically it's some other sort of offset. Try out the snapping of anchor and control points to other shapes then zoom in to see if they are precisely located in the same exact location (down to many decimal places before floating point error comes into play).

Reply by @0HyperCube about this:

Yes, if you drag a point with the path tool, it will snap your mouse position and then add the offset dictated by how far your mouse was originally away from the centre of the point. Also would cause more merge conflicts for the path refactor.

So I'm marking this as blocked on #605.

This has been fixed as the path tool now puts the centre of the square at the mouse position.

@0HyperCube do you know which PR or commit fixed this, for the record?


Tor not allowing http requests

I am trying to access a V3 hidden service using your TorClient code and it is working great in the simulator but not on the device which is very strange.
Simulator: everything works.
Device: only HTTPS requests work :(
Do you have any idea why that would be the case?
Thank you for your time.

Swift/iOS disallows any non-HTTPS requests on production-ready devices due to the complication that could be caused by using plaintext HTTP request
See: https://stackoverflow.com/a/35104152/4479618

Yes I have set the "allows arbitrary loads" to true in my info.plist. Just wondering if you have had any success using the tor framework with non https requests as I am stuck. If you have any other suggestions that would be appreciated.

We just don’t use HTTP and it’s not even recommended to do so.
I guess it’s easier to upgrade the certificate than bringing swift to use HTTP requests

So actually Ive tried https request to onion site as well and that also does not work with the implementation of tor.framework, it only works on simulator for onion sites. I know its out of the scope of your app. I am just trying to solve this, if you figure out a solution please do let me know.

I would kindly forward you to the framework repo instead of posting this here as you already stated that this is out of scope for us. And we won't have any further look into it. Sorry.

@FontaineDenton what are you trying to accomplish

@justinvforvendetta Assume a user has a V3 hidden service running that controls their Bitcoin Core RPC port for their full node. I want to allow users to connect to their V3 hidden service in my app https://github.com/FontaineDenton/FullyNoded to allow people to use their nodes securely on an iPhone. I have it working really well in simulator but not at all on the device for hidden services. I am reaching out on the Tor.framework project and others too, I am very keen to figure out what the issue is and how I can fix it.


bookmark-manager

issue: #4

[x] Create a two separate container(right container and left container).
[x] left container to add bookmark name and link.
[x] right container to display the added link.
[x] Create a Scrollable right container.
[x] Using the State hook to update the bookmark name and link

right Container

left container

Scrollable container

Using state hook


[Gekidou] Open & Render Tables in their own screen

Summary
When a post contains a table, tapping on the table opens a screen showing the entire content of the table.
NONE

There is a ticket to look at the UI https://mattermost.atlassian.net/browse/MM-39744


Add pyproject.toml for Custom Node Registry

We are building a global registry for custom nodes (similar to PyPI). The registry makes using custom nodes more reliable by reserving globally unique names for each custom node, and supporting semantic versioning.
Here’s some more information on the registry.
Action Required:

[ ] Go to the registry. Login and create a publisher id. Comment it here and we will update the PR (or just merge it and change it yourself).
[ ] Write a short the description.
[ ] Merge the separate Github Actions PR and run the workflow.

If you want to publish the node manually, install the cli and run comfy node publish
Please message me on Discord if you have any questions!

hey @hay86, wanted to send a small nudge and ask if you had any questions!

@hay86, wondering if there's any way we can support you on this PR!


Documentation for Unicollab

Project Documentation Creation Initiative
About
Our project is in need of comprehensive documentation to serve as a reference guide for developers, contributors, and users. This initiative focuses on creating high-quality documentation from scratch to ensure that all aspects of the project are well-documented and easy to understand.
Objectives

Create Comprehensive Documentation: Develop documentation that covers all aspects of the project, including its purpose, architecture, components, and usage.
Ensure Readability and Clarity: Use clear and concise language, along with appropriate formatting, to make the documentation easy to read and understand.
Establish Documentation Standards: Define standards for documenting code, APIs, and other project-related information to maintain consistency and clarity across the documentation.
Facilitate Future Updates: Create documentation in a format that allows for easy updates and additions as the project evolves.

Tasks

Define the structure and outline of the documentation, including the sections and topics to be covered.
Research and gather information about the project, its architecture, and its features.
Write and format the documentation according to the defined standards.
Review and revise the documentation to ensure accuracy, completeness, and clarity.

How to Contribute

Join the Documentation Team: If you're interested in contributing to the documentation, join the documentation team to collaborate with other contributors(2-3)
Choose a Section to Work On: Select a section or topic from the documentation outline to work on.
Research and Write: Gather information about the selected topic and write the documentation according to the defined standards.
Submit Your Contributions: Once you've completed a section, submit it for review and inclusion in the documentation.

Contribution Guidelines

Follow the project's documentation standards and formatting guidelines.
Use clear and concise language, and avoid unnecessary technical jargon.
Provide references and citations for any external sources or information used in the documentation.

Timeline
We aim to complete the initial draft of the documentation by end of this month, with ongoing updates and revisions as the project evolves.
Additional Information
If you have any questions or need guidance on contributing to the documentation, please feel free to reach out to @SUGAM-ARORA

@SUGAM-ARORA I am interested in the documentation, please assign this to me.

I would like to work on this . Please could you assign me this issue under GSSOC'24

@IbrahimDev00 Issue assigned to you

@Kalyan9064 You can work on this issue. I will assign you another issue of Documentation


vuex support

Any chance of getting this to work with vuex? You have to pass a url to the dropzone component so it handles to uploading of the file to the server.
However, i would like to dispatch the correct data to my store actions and create an ajax request from there. Is this possible with the component?

Hi @kife-design
I tried looking into this a little while ago and didn't find a good answer.
Probably the best I can think of is setting autoProcessQueue to false in the options, and then hook into the vdropzone-file-added event.
Does that help at all?

Closing due to inactivity


Fixes Rhino support

The issue I was trying to describe in #662 was actually caused by the missing colors.js file.

The same fix is available as pull request #651.


util.h: Remove INLINE definition and user

INLINE is a very common macro, just like MAX or MIN.
Defining it always can easily collide with libraries or
application headers.
An option would be to add a ifdef guard around it,
But it was used in only 1 place in Zephyr, instead
of keeping it just for that, remove it.
Signed-off-by: Alberto Escolar Piedras<EMAIL_ADDRESS>Alternative to #25031

By the way, we have another INLINE usage here:
https://github.com/zephyrproject-rtos/zephyr/blob/04d1104ee51754193efb557d6d4d0d1d9452e965/boards/posix/nrf52_bsim/time_machine.c#L106

That is actually not the same macro :). (That file does not include Zephyr headers, but BabbleSim headers. It is part of the HW side of the nrf52 simulated device)

@galak there seems to be some issues in CI due to DT macros?

@aescolar should we try to get this into 2.3?

@aescolar should we try to get this into 2.3?

I'd say "why not?", it is an annoyance for app developers (our app guys hit it) so better to get it fixed


Fix return initial zero volume size

Summary

Fix bug by #30
Function getVolSizeBytes returns initial volSizeBytes (=0)

It requests '000'GiB on CreateVolume and response Client.InvalidParameterTooSmall.Size

Before/After
Before
I0111 09:20:03.299730       1 controller.go:117] create volume in east-12 zone
E0111 09:20:18.876685       1 driver.go:76] GRPC error: rpc error: code = Internal desc = Could not create volume "pvc-3ea25acb-591b-464f-b976-089f50132c72
": could not create NIFCLOUD additional storage: operation error computing: CreateVolume, exceeded maximum number of attempts, 3, https response error Stat
usCode: 500, RequestID: 42d8da3c-9f4a-426a-b9c5-dab24178279a, api error Client.InvalidParameterTooSmall.Size: Volume of '000'GiB is too small; minimum is 1
00GiB.

After
I0111 09:38:09.360219       1 controller.go:117] create volume in east-12 zone

Review

[x] All checks have passed

LGTM :pray:


Do you mean network service groups OR network SECURITY groups?

In this section - https://learn.microsoft.com/en-us/azure/machine-learning/how-to-secure-training-vnet?view=azureml-api-2&tabs=cli%2Crequired#compute-instancecluster-or-serverless-compute-with-no-public-ip you reference the following
If you can access the internet from it, it is because of Azure [default outbound access](https://learn.microsoft.com/en-us/azure/virtual-network/ip-services/default-outbound-access?view=azureml-api-2) and you have an NSG that allows outbound to the internet. However, we don't recommend using the default outbound access. If you need outbound access to the internet, we recommend using either a firewall and outbound rules or a NAT gateway and network service groups to allow outbound traffic instead.
Do you in fact mean network security groups to allow outbound traffic instead rather than network service groups to allow outbound traffic instead.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 90a6beff-4f9f-cbee-64ca-4309118f524d
Version Independent ID: e642737a-d6dd-f97e-785d-7a72a8adf93e
Content: Secure training environments with virtual networks - Azure Machine Learning
Content Source: articles/machine-learning/how-to-secure-training-vnet.md
Service: machine-learning
Sub-service: enterprise-readiness
GitHub Login: @jhirono
Microsoft Alias: jhirono

@michaelspinks  Thanks for reaching out to us and reporting this issue. We are looking into this issue and we will provide an update.

@michaelspinks The above PR has been filed and it is currently under review. Once its approved and merged the docs will be live. Hope this helps.


add flash_attn installation in testcase and update transformers requirement

the newest internlm2's hf model needs flash_attn, add flash_attn installation in test case workflow
the newest internlm2's hf model use transformers's static cache which is supported in version 4.38. Update releated docs.

test workflow is https://github.com/InternLM/InternLM/actions/runs/9560759361

The issue stems from the update to the InternLM2 model in the huggingface transformers, as detailed in this commit: https://huggingface.co/internlm/internlm2-20b/commit/d431f9e4014c895663f30e8942d6e3c1adb6b562


Automated cherry pick of #1693: fix host register:

Cherry pick of #1693 on release/2.11.0.
#1693: fix host register:

/lgtm
/approve

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11.0@cfb275b). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release/2.11.0   #1694   +/-   ##
================================================
  Coverage                  ?   7.65%
================================================
  Files                     ?     412
  Lines                     ?   63111
  Branches                  ?       0
================================================
  Hits                      ?    4834
  Misses                    ?   57869
  Partials                  ?     408

Flag
Coverage Δ

#aFlag
7.65% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfb275b...50a085c. Read the comment docs.


Install VS2017 on all build machines

Oracle are switching to supporting VS2017 builds, so we should too:
Ref: https://bugs.openjdk.java.net/browse/JDK-8201267 and https://github.com/eclipse/openj9/issues/1697

Note that there is a compiler bug in recent versions of VS2017 that prevents JavaFX (at least webkit) from being built for now: https://bugs.openjdk.java.net/browse/JDK-8210218
(this should not block you, as we're not even close to have an Ansible setup for JavaFX on windows)

That's ok - this shouldn't result in earlier versions being removed - it would be an addition for now. But thanks for that info - useful to be aware of it.

I've heard from a colleague on the infrastructure call today that there may be some conflicts installing VS2017 on machines that have the earlier versions so we're going to do some investigation before pushing this forward

The conflicts as I found our are related to the version of mingw installed on the machine.  OpenJ9 only compiles with specific versions in when VS2017 is used.
#422 was the commit for VS2017 required changes, but there is no mention of version of mingw that should be used.  That can be inferred through the openj9 build instructions here in the Windows section :
https://github.com/eclipse/openj9/blob/master/buildenv/Build_Instructions_V11.md#windows
I am not sure if the mingw v8.1 tooling will work alongside older VS installs.  I have a student working on the addition to the playbook which should be coming in the next few days.

The problems we have occur exactly when there are 2 versions installed, and different environment variables point to conflicting versions. Hopefully you won't run into it, but it caused lots of headaches :)

Hopefully you won't run into it

Do you have reason to believe we won't see the same problems as you did @johanvos? We are planning to have them both installed on our machines so we need to know this will have no risk of destabilising our use of either version.

@vsebe has VS2010, VS2013, and VS2017 installed on each of the 4 Windows 2012 Server machines on the OpenJ9 jenkins.
There are further changes required (mingw 8.1) as detail in the url above that I believe @vsebe is working on for adding to the playbook.  Currently there is a defect open against OMR for compilation failure within DDR; https://github.com/eclipse/omr/issues/2885

#479

@johanvos Can you please clarify your "Hopefully you won't run into it" assertion and would like to understand why you believe that to be the case. Has @vsebe seen any of them?
@jdekonin Do you know if that OMR issue related specifically to VS2017 or MinGW?

Its a hard fail with VS2017, VS2013 still compiles fine.  OpenJ9 won't be moving to VS2017 until this defect is resolved and there is a clean compile.

Please note there are two versions of MinGW:

the cygwin packages (gcc 5.4 or newer) required to build OpenJ9 extensions for OpenJDK8 & OpenJDK10
MinGW-W64 v5 (gcc 8.1.0) required to build OpenJ9 extensions for  OpenJDK11 for now (installed ins different location than the cygwin package, has to be added first to the PATH - see https://github.com/AdoptOpenJDK/openjdk-infrastructure/pull/479).

@vsebe So if we're going to move to VS2017 everywhere for OpenJ9 then the version installed in PR479 should be adequate - is that correct? I'll aim to get one of our build machines in a suitable state for this.

https://ci.adoptopenjdk.net/label/windows&&x64&&buildj9/ are the current J9 build machines - I'll start putting the newer versions on https://ci.adoptopenjdk.net/computer/build-softlayer-win2012r2-x64-2/

@sxa555 - yes, the MinGW from PR#479 is adequate.

@vsebe Is the install location specified in that PR - C:\mingw-w64\x86_64-8.1.0-win32-seh-rt_v6-rev0 - the one that the OpenJ9 build process will look for explicitly or does the bin directory in there need to be added to the PATH somewhere as a separate step?

Going to remove the buildj9 tag from https://ci.adoptopenjdk.net/computer/build-softlayer-win2012r2-x64-1/ for now to force all OpenJ9 builds onto the new -2 machine

@sxa555 - fyi the OpenJ9 is investigating using Clang instead of mingw on Windows(https://github.com/eclipse/openj9/issues/2469#issuecomment-420753284)

Bumping to next milestone - installed and tested on one machine so solves the immediate need.

To set expectations this is not going to be solved this Month.  I am about to go on leave.  Realistic timeline is mid October.
@sej-jackson Maybe you want to pick this up.

@sxa555 assume this can be closed? VS2017 is in the playbook and installed on all build machines


Adds all-your-base generator and exercise

Hi, this PR is to add a new exercise for all-your-base, here is a link to the problem-specifications
I'm still learning Crystal, so feel free to point out anything that needs to be change or improved.
Thanks!

Hi @mhelmetag is there anything I can do to help move along the reviewing of the PRs? If it helps, after you review I can update and merge. This should save sometime for updating the PRs due to the  config.json changes. Let me know how I can help.

Rebased with master, and updated the readme. No other updates.


Auth without remote connect? (feature request/inquiry)

I was wondering if it's currently possible to authenticate/login to an account using the access token/email & passwd without needing to enable remote connect (linking with the code) otherwise I'd like to suggest this as a possible addition.

Yep, this is possible by manually creating the Account.


Combine with context

I'm using i18next and there seems to be an issue with combining this post processor with contexts.
For example, given the following translation strings:
{
  "joins": "joins",
  "joins_plural": "join",
  "joins_interval": "(0)nobody joins",
  "joins_past": "joined",
  "joins_past_plural": "joined",
  "joins_past_interval": "(0)nobody joined",
}

t("joins_interval", {count: 1, context: "past", postProcess: "interval"}) returns joined,
but t("joins_interval", {count: 0, context: "past", postProcess: "interval"}) returns nobody joins.
I would expect it to return nobody joined instead.
Am I missing something here?

You're accessing key joins_interval not using interval post processing!
so key with context not using interval would be joins_interval_past for  t("joins_interval", {count: 0, context: "past"})
Accessing interval would be something like: https://github.com/i18next/i18next-intervalPlural-postProcessor#usage-sample i18next.t('key1_interval', { postProcess: 'interval', count: 1 });
but not sure how you will have to mix this up with context - never used that myself...

Ah sorry, forgot writing postProcess: 'interval' in the question. Edited it. I have for now settled on a custom solution without this package, but still it would be cool to see this package support contexts.

should be rather simple to get it working...PR welcome


Update Canary Bank-new to use OAuth access tokens for authZ

Cognito - https://canarybank-aws.hexademo.org
Azure AD - https://canarybank-azure.hexademo.org

@saurabh-io  The azure login does not work, the login button just refreshes the login page


Usability issues with lists

With current windows, you can't drag and drop multiple scenes to a list.
It takes a lot of vertical space and you need to click expand on each element before you see the scene name.

Displaying a list like this, with an inline green dot and your buttons instead of the "open" and "-" buttons, would be great:

I got this result now:

by changing the OnGUI method
public override void OnGUI(Rect position, SerializedProperty property, GUIContent label)
{
    if (property.serializedObject.isEditingMultipleObjects)
    {
        GUI.Label(position, "Scene multiediting not supported");
        return;
    }
    var sceneAssetProperty = GetSceneAssetProperty(property);
    label.tooltip = "The actual Scene Asset reference.\nOn serialize this is also stored as the asset's path.";
    var sceneControlID = GUIUtility.GetControlID(FocusType.Passive);
    EditorGUI.BeginChangeCheck();
    {
        sceneAssetProperty.objectReferenceValue = EditorGUI.ObjectField(position, label, sceneAssetProperty.objectReferenceValue, typeof(SceneAsset), false);
    }
    if (EditorGUI.EndChangeCheck())
    {
        var buildScene = BuildUtils.GetBuildScene(sceneAssetProperty.objectReferenceValue);
        if (buildScene.scene == null) GetScenePathProperty(property).stringValue = string.Empty;
    }
}

Still, I can't just the scene into the list, but it's much better.

This is one of the things that I am reluctant to change. Seeing whether the scene is in the build right while assigning the scene is very useful.
The current foldable behaviour comes from this question I asked a while ago on StackOverflow: https://stackoverflow.com/questions/57948014/how-to-set-serializedproperty-propertytype-in-a-custompropertydraw
You can read my question and the accepted answer to get an idea of why it was necessary.
Maybe we can provide a way to switch between the current foldable detailed view and the summarized inline view you are describing here. Off the top of my head, I think of two ways to do this:

An attribute on the SceneReference field, something like [Inline].
A separate InlineSceneView class.

Or, maybe we can make the foldable behaviour optional via an attribute?
But if we go with the attribute approaches, we will not be able to apply the attribute while the SceneReference is in a collection, unless there is a way of reaching out to the collection's attributes from SceneReference class.
I need to look into this a little bit. I am in my exams week in the uni, so I don't have much free time at my hands currently.

Just want to put in a vote of support for this.
The current behavior is still very useful and shouldn't be changed IMO, but their current behavior adds some tedium when dealing with lists. Having an additional stripped-down inline option would make for a nice alternative.

College is getting the better of me nowadays, I cannot find any spare time for side projects. However, if anyone comes up with a PR, I can quickly review and accept it.

Another potential option would be to create a SceneAssetList type with its own PropertyDrawer so that its behavior can be optimized for that use case.


setting min width for some bubbles [Help]

Hi! awesome library, I was wondering which was the correct approach to setting a minimum width for some bubbles. I've tried overriding the applyLayoutAttributes: in my custom cell, but I need access to my datasource to know which cell should have a minimum width. I've been tinkering with messageBubbleLeftRightMargin in cellForItemAtIndexPath: but with no results.
Any pointers would be great

Ok, so I was missing the instruction [cell applyLayoutAttributes: customAttributes] in cellForItemAtIndexPath

What was the solution for this eventually ... ?

yup, I still get some side effects when I delete a cell (it flashes back to its old width), I had to reload data in the completion block of performBatchUpdates to negate this effect. Hope I can find another way


Solve bugs

Branch used to solve a bug on the API: even if we passed more than one year, the API was only working for one year.
This branch was also used to make small changes pointed out by the first users of the interface (no date in excel file, documentation link missing)

Codecov Report

Merging #7 (c75ef04) into main (a0c61cf) will decrease coverage by 0.75%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   49.27%   48.51%   -0.76%
==========================================
  Files          11       11
  Lines         822      810      -12
  Branches      130      130
==========================================
- Hits          405      393      -12
+ Misses        386      384       -2
- Partials       31       33       +2

Impacted Files
Coverage Δ

pygsod/output.py
38.97% <ø> (-1.32%)
:arrow_down:

pygsod/noaadata.py
59.01% <100.00%> (-4.52%)
:arrow_down:

pygsod/epw_converter.py
30.23% <0.00%> (-0.81%)
:arrow_down:

pygsod/gsod.py
0.00% <0.00%> (ø)

pygsod/isd_lite.py
0.00% <0.00%> (ø)

pygsod/ish_full.py
75.00% <0.00%> (ø)

pygsod/tmy_download.py
25.92% <0.00%> (ø)

pygsod/utils.py
58.33% <0.00%> (+2.99%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us.


User can change account and notifications in Readonly mode

User created in Readonly mode is able to change account and notifications.
Need to remove those links(Account, Notifications) from User page.

That depends on how you define read-only mode. Currently it means that user can't change any shared objects (e.g. devices), but it can change own preferences.

restriction of Readonly should apply only to device modifications or additions. Changes to account and notifications should allowed. custom commands should not allowed in readonly, because with this feature, users will can change configuration on devices.
If you restrict all setting, this account will have demo account property.
Maybe can you add new role as limited user for restrict only device modifications, and allow change on notification and personal account information.

There is already "device readonly" property, which does exactly what you are asking for.

is available in 3.9 version?

No, it's not. It's available starting from 3.10.

closing this issue.


XY start for tileable 2D noise?

Been using this in a framework for some experimental stuff, love the ease of use!
Was wondering if it's possible to have a xStart and yStart for tileable 2D noise or is it impossible?

What purpose do you want to achieve by setting x/yStart. I don't think it will have the affect you think it will. It would be possible to offset the 4D noise used to generate 2D tileable but changing the seed would have a very similar effect.

There's a few case I have where it would be convenient to offset xStart so that edge values are at specific place for a given seed. I realize it's possible to do with changing the seed but it's not as predictable. I also get that this can be done post noise generation just by shifting sampling position as well. If it doesn't seem useful to have than I'll just do that.

2D tileable is generated using 4D noise so the edges wouldn't match up to 2D noise generation.

Got it. Thanks.


pass namespace via CLI

previously it was passed from OSBS Client
as user_params.
Pass it from tekton context using CLI

CLOUDBLD-9054

Signed-off-by: Harsh Modi<EMAIL_ADDRESS>Maintainers will complete the following section

[ ] Commit messages are descriptive enough
[ ] Code coverage from testing does not decrease and new code is covered
[ ] Python type annotations added to new code
[ ] JSON/YAML configuration changes are updated in the relevant schema
[ ] Changes to metadata also update the documentation for the metadata
[ ] Pull request has a link to an osbs-docs PR for user documentation updates
[ ] New feature can be disabled from a configuration file

The more I look at this the more I think we don't need to pass the namespace at all since it's fixed AFAIK and it's available to OSBS-client from config https://github.com/containerbuildsystem/osbs-client/blob/master/osbs/api.py#L94. I think if we just remove the namespace and don't pass it to o-c at all we'll be fine.


Env variable to make lens the default UI

Lens has been around for more than a year now and a lot of development has gone into it. Before removing the old UI we should make it possible to have lens as default ui (most people at my company have never clicked the try lens button afaik).
While we do this we should also add the button to go back to the default ui if people have any issue with lens though

makes sense actually, next release set Lens as default but still offer to
navigate back for one more release or so. Then the release after that
remove old UI.
On Thu, Oct 24, 2019 at 8:30 PM Daniele<EMAIL_ADDRESS>wrote:

Lens has been around for more than a year now and a lot of development has
gone into it. Before removing the old UI we should make it possible to have
lens as default ui (most people at my company have never clicked the try
lens button afaik).
While we do this we should also add the button to go back to the default
ui if people have any issue with lens though
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/issues/2884?email_source=notifications&email_token=AABPKAFYJHUGOPN3B7UFHSDQQHSVZA5CNFSM4JEYCRI2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HUGFKJA,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABPKAH6XFR6XMFCY4E5L5LQQHSVZANCNFSM4JEYCRIQ
.

Just to clarify, I didn't seen any issue or chat in gitter about actually deleting the old UI soon. I just think this is a good next step.
Also afaik most people in my company have never clicked on the try lens button, so changing the default is an easy way to have them try it out.

ps zipkin-slim has lens as default, but I think you use cassandra which is not in slim.

IIRC the reason we didn't make an env variable was that we didn't want to create a variable then have to delete it later. As mentioned, the transition is at a year so far, so might be fair enough to add a variable. So, I would recommend a variable to set lens as default vs set classic or lens. This way, even if we delete it later due to lens being default, it isn't breaking.

I raised this as take it or leave it. I'm not wandering down the path to make the cookies reversable as I think it is only checked for existence now. If it doesn't fit, someone else can do it (likely they won't), so I'd suggest just taking it :P https://github.com/openzipkin/zipkin/pull/2886


Update firewall alias

When we try to update a firewall alias we get {"status":"bad request","code":400,"return":4056,"message":"Firewall alias already exists","data":[]}

Hey!
This was a known issue fixed in v1.1.2. If you haven't already, update the package and that should get things working. Otherwise, if you are still experiencing this issue on v1.1.2, please provide the request data you are using when you receive this error and I can take a closer look.
Thanks!

I confirm that the issue is fixed in v1.1.2.

I confirm that the issue is fixed in v1.1.2.


Cypress test for issue 1810

Add Cypress test for issue 1810
Motivation and context

How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Pull Request Test Coverage Report for Build 6966

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 69.729%

Totals

Change from base Build 6963:
0.0%

Covered Lines:
11722

Relevant Lines:
16356

💛  - Coveralls


DRAFT: Loss functions

Added:

a number of the most common loss functions.
one-hot encoding
Embedding module

Moved the loss functions to the 'Functions' static class, since there's no 'nn.losses' in PyTorch.

This looks good so far, I'll review again when out of draft


Documentation Improvement Facial Biometric Tutorials

Describe the documentation you want to be improved
I want to add a tutorials folder for OpenCV face recognition to guide me and everyone else during the implementation
This a link for one of them

Cool you can add them , assigning you


Reuse memberfield js

@rjmk again this is not ready to be merged in but there for you to take a look to see if we are sailing in right direction. We have not moved everything into shared just yet as we wanted to see whether everything worked first.
@rjmk update 09/08
This PR includes:

Moving Mode and Member modules into shared.
Implementing Redux Form on the member view.
Reuse Rafe's field.js files.
Reset form correctly on both admin and member's view.
Initial styling of member's form for mobile view.

@rjmk here is our latest work for your consideration.

@rjmk I have merged in the styling branch so this is ready for you to have a look at now.

@ivanmauricio Great, thanks. Just so we can clarify for ourselves, could you update the PR description to summarise it?

Looks great. A touch more refactoring to do in the members module

@rjmk got a bit defeated by this refactor. Tried lots of stuff which didn't work so went for something simple in the end. Would love to know if there is a better way.

@ivanmauricio Do these two functions suggest a better way?
fetch_user_url = _ => '/api/account'
fetch_member_url = compose(make_user_url(get_user_url), prop('id'))

Thanks @rjmk, that solved all my problems 😄

Great 👍