added content prop type to alert component

content prop type is PropTypes.node so this component can accept any kind of content. This is implemented because of need to pass links inside alert component.
added custom prop check to make sure one of the props(text/content) is passed to component, this can be removed after text deprecation
added deprecationWarning for Alert component
updated alert.md with content prop
updated storied/alert with sample of alert component with content prop

Is it really required to deprecate the text prop? If so then we should remove all examples with text in the story and just have it in the props definitions saying it's deprecated right?

I think it is unnecessary to keep both props, basically they act same. Content prop gives us more flexibility in this case.  If we all agree, i'll change all text occurrences in stories with content prop.


Verify OVS bridge is created by the plugin at docker run for the first container

Hey @runseb can you double check your OVS bridge isn't created by default. I think I saw a readme update that has it being created manually. There is a br create method in ovs_bridge.go func (driver *driver) setupBridge()  that should create it. If you could double check that was or wasn't working that would be awesome. Below are before and afters and output.
# ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet <IP_ADDRESS>/8 scope host lo
       valid_lft forever preferred_lft forever
    inet6 ::1/128 scope host
       valid_lft forever preferred_lft forever
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UNKNOWN group default qlen 1000
    link/ether 00:0c:29:58:1c:01 brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global eth0
       valid_lft forever preferred_lft forever
    inet6 fe80::20c:29ff:fe58:1c01/64 scope link
       valid_lft forever preferred_lft forever
3: eth1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UNKNOWN group default qlen 1000
    link/ether 00:0c:29:58:1c:0b brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global eth1
       valid_lft forever preferred_lft forever
    inet6 fe80::20c:29ff:fe58:1c0b/64 scope link
       valid_lft forever preferred_lft forever
16: ovs-system@NONE: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group default
    link/ether 0e:88:46:2b:39:e8 brd ff:ff:ff:ff:ff:ff

OVS config
$ ovs-vsctl show

45045b76-ec16-4828-bafb-07b138f6a565
    Manager "ptcp:6640"
    ovs_version: "2.3.0"

Start the plugin with defaults, ovsbr-docker0 with an ip of <IP_ADDRESS>/24 (containers land in that network)
./docker-ovs-plugin  -d

or from source
git clone https://github.com/gopher-net/docker-ovs-plugin.git
cd docker-ovs-plugin/plugin/
# get dependancies
go get ./...
go run main.go -d

Start Docker (note, docker0 still gets created. I am not sure how to disable that yet. @dave-tucker might know. Since we are passing what we want as the default bridge, it would make sense to not create another default bridge that is unused or worse overlapping. Whatever the name passed to the default-network should be what is setup in OVS.
docker -d -D --default-network=ovs:ovsbr-docker0

Start a container
docker run -i -t --rm busybox

After a container starts, the network create is called and the default bridge for the plugin (ovsbr-docker0) is created and assigned an L3 ip addr. (Note: we need to add a masquerade option there to enable a NAT.)
$ ifconfig
docker0   Link encap:Ethernet  HWaddr b2:d1:59:e3:94:d1
          inet addr:<IP_ADDRESS>  Bcast:<IP_ADDRESS>  Mask:<IP_ADDRESS>
          inet6 addr: fe80::b0d1:59ff:fee3:94d1/64 Scope:Link
          UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
          RX packets:0 errors:0 dropped:0 overruns:0 frame:0
          TX packets:8 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:0
          RX bytes:0 (0.0 B)  TX bytes:648 (648.0 B)

eth0      Link encap:Ethernet  HWaddr 00:0c:29:58:1c:01
          inet addr:<IP_ADDRESS>  Bcast:<IP_ADDRESS>  Mask:<IP_ADDRESS>
          inet6 addr: fe80::20c:29ff:fe58:1c01/64 Scope:Link
          UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
          RX packets:10526 errors:0 dropped:0 overruns:0 frame:0
          TX packets:5933 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:1000
          RX bytes:1099310 (1.0 MiB)  TX bytes:939698 (917.6 KiB)
          Interrupt:19 Base address:0x2000

eth1      Link encap:Ethernet  HWaddr 00:0c:29:58:1c:0b
          inet addr:<IP_ADDRESS>  Bcast:<IP_ADDRESS>  Mask:<IP_ADDRESS>
          inet6 addr: fe80::20c:29ff:fe58:1c0b/64 Scope:Link
          UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
          RX packets:1286098 errors:66 dropped:186 overruns:0 frame:0
          TX packets:8144 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:1000
          RX bytes:765846208 (730.3 MiB)  TX bytes:560943 (547.7 KiB)
          Interrupt:19 Base address:0x2080

lo        Link encap:Local Loopback
          inet addr:<IP_ADDRESS>  Mask:<IP_ADDRESS>
          inet6 addr: ::1/128 Scope:Host
          UP LOOPBACK RUNNING  MTU:65536  Metric:1
          RX packets:1751 errors:0 dropped:0 overruns:0 frame:0
          TX packets:1751 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:0
          RX bytes:913292 (891.8 KiB)  TX bytes:913292 (891.8 KiB)

ovs-veth0-c3caa Link encap:Ethernet  HWaddr 9e:8e:dc:75:42:7d
          inet6 addr: fe80::9c8e:dcff:fe75:427d/64 Scope:Link
          UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
          RX packets:6 errors:0 dropped:0 overruns:0 frame:0
          TX packets:10 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:0
          RX bytes:508 (508.0 B)  TX bytes:836 (836.0 B)

ovsbr-docker0 Link encap:Ethernet  HWaddr d6:6a:3c:03:92:44
          inet addr:<IP_ADDRESS>  Bcast:<IP_ADDRESS>  Mask:<IP_ADDRESS>
          inet6 addr: fe80::d46a:3cff:fe03:9244/64 Scope:Link
          UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
          RX packets:6 errors:0 dropped:0 overruns:0 frame:0
          TX packets:6 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:0
          RX bytes:508 (508.0 B)  TX bytes:508 (508.0 B)

# OVS

# ovs-vsctl show
45045b76-ec16-4828-bafb-07b138f6a565
    Manager "ptcp:6640"
        is_connected: true
    Bridge "ovsbr-docker0"
        Port "ovsbr-docker0"
            Interface "ovsbr-docker0"
                type: internal
        Port "ovs-veth0-c3caa"
            Interface "ovs-veth0-c3caa"
    ovs_version: "2.3.0"

@nerdalert yeah I will check but I remember having to create it by hand. And indeed docker0 bridge gets created anyway. I tried passing docker run -d -b=ovsbr-docker0 but that did not work…
I will test again and send the error message.

Thanks @runseb , I think I recreated the issue on vivid with 4.1.1. Its seems like some delay in the netlink bridge getting created after the OVS bridge is created. I am going to stick a retry for the time being on the netlink.GetLinkByName to give OVS and netlink enough time to synchronize if that makes sense to you all. Still curious what changed. Pasting the logs in case anything jumps out for you.
uname -a
Linux ub-1504 4.1.1-040101-generic #201507030635 SMP Fri Jul 3 10:38:27 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

Error:
Jul 19 17:25:27 ub-1504 kernel: [ 3526.631825] openvswitch: netlink: Key type 62 is out of range max 22
Jul 19 17:25:27 ub-1504 systemd-udevd[4488]: conflicting device node '/dev/mapper/docker-8:1-536425-9a3611b06a46825c41fd8ef73a21d84d9dbad827416bb3f473c973668fd1977a' found, link to '/dev/dm-3' will not be created
Jul 19 17:25:27 ub-1504 systemd-udevd[4488]: Could not generate persistent MAC address for ovsbr: No such file or directory
Jul 19 17:25:27 ub-1504 kernel: [ 3526.634692] device ovsbr entered promiscuous mode
Jul 19 17:25:27 ub-1504 systemd[1]: message repeated 3 times: [ Device dev-disk-by\x2duuid-34986662\x2da6cf\x2d4cba\x2dbf15\x2d700ec2bf7b65.device appeared twice with different sysfs paths /sys/devices/virtual/block/loop0 and /sys/devices/virtual/block/dm-3]
Jul 19 17:25:27 ub-1504 systemd[1]: Started ifup for ovsbr.
Jul 19 17:25:27 ub-1504 systemd[1]: Starting ifup for ovsbr...
Jul 19 17:25:27 ub-1504 sh[4542]: Unknown interface ovsbr

Adding a retry:
	iface, err := netlink.LinkByName(name)
	if err != nil {
		log.Debugf("error retrieving the new OVS bridge link [ %s ], retrying in 1 second..", bridgeName)
		time.Sleep(1 * time.Second)
		iface, err = netlink.LinkByName(name)
		if err != nil {
			log.Errorf("Error retrieving the new OVS bridge from netlink: %s", err)
			return err
		}
	}


Binary run.n in repository

Does the binary run.n really have to be included in this repository?
Every time I compile my updated local repo run.n is recompiled (make haxelib is included in make all) and then git status reports "modified content" in the submodule extra/haxelib_src. No big deal, but seems a bit odd to include a binary here.

That is done so one could do haxelib git haxelib https://github.com/HaxeFoundation/haxelib. I know it's annoying, but I don't have another solution right now...

How about another client.hxml that compiles the binary to another name and is only used in the Makefile? A bit complicated maybe.
I'll try to work around this on my side, like renaming the binary before compilation and renaming it back afterwards...


Feature: Export to docker-compose.yml

Hi @ttyS15.
What do you mean? DockStation generates native docker-compose.yml

Yaeh! Thanks! Already seen. Sorry for noise!

You create very good product! Thank you!

Thanks. We have many ideas for help and make work with docker easier. I think that we'll publish on the next week a big update with new awesome features. Stay with us. :)

Thanks! With pleasure! :)
Алексей Манаев

On 26 May 2017, at 13:42, Igor Kozlovsky<EMAIL_ADDRESS>wrote:
Thanks. We have many ideas for help and make work with docker easier. I think that we'll publish on the next week a big update with new awesome features. Stay with us. :)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://github.com/DockStation/dockstation/issues/21#issuecomment-304250498, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_c1uqWS2-RCWXZsin7TAP1r7PXgnkAks5r9qyegaJpZM4Nnb4Y.


Better representation for QPUs

From @mpharrigan: Consider tying together some of the related concepts: device object, sampler, device calibration, and device name, supported gatesets into an easy-to-get nicely-named object.
A version of these classes in ReCirq: https://github.com/quantumlib/ReCirq/blob/master/recirq/engine_utils.py#L232

Related / possible dupe: https://github.com/quantumlib/Cirq/issues/2820

It is, closing as a dupe.


feat(bux-705): Added gitbook

Pull Request Checklist

[x] 📖 I created my PR using provided  : CODE_STANDARDS
[x] 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
[ ] 🏠 I tested my changes locally.
[ ] ✅ I have provided tests for my changes.
[x] 📝 I have used conventional commits.
[x] 📗 I have updated any related documentation.
[x] 💾 PR was issued based on the Github or Jira issue.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.59%. Comparing base (663b991) to head (9dbcba8).
Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #521      +/-   ##
==========================================
- Coverage   52.69%   52.59%   -0.10%
==========================================
  Files         184      186       +2
  Lines       10731    10810      +79
==========================================
+ Hits         5655     5686      +31
- Misses       4529     4573      +44
- Partials      547      551       +4

Flag
Coverage Δ

unittests
52.59% <ø> (-0.10%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 7 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 663b991...9dbcba8. Read the comment docs.


Site improvements

Ideas on how to improve our site (https://trunkrs.dev)

Sea shells here and there. Rock the Ferris & coral reef theme. Maybe get some little Ferris buddies scurrying about with some fancy SVG animations: https://aaronerhardt.gitlab.io/crab-tag/#rust (jk jk ... 👀)
get some of the art work in place (Ferris packing trunk with sea shells, assets logos, scripts/scrolls &c).
hero section doesn't render well on mobile. Rework with a little flexbox magic.

Another idea: add a dark mode.
Currently the website is too harsh on the eyes, especially for those browsing in the dark.

I have sent an PR https://github.com/huhu/juice/pull/14. If juice will merge it, trunk should update the submodule and put juice_exclude_menu = [] in config.toml zola file


Backport to opendistro-1.10

(cherry picked from commit d031626b73c871de3b214f412c49e0bf479896e4 and commit d17ecb323100a48efd1e2c70ae94fee390bae154)
opendistro-for-elasticsearch/security pull request intake form
Please provide as much details as possible to get feedback/acceptance on your PR quickly

Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Github Issue # or road-map entry, if available:

Description of changes:

Why these changes are required?

What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)

Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)

TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)

Is it backport from master branch? (If yes, please add backport PR # and commits #)
Cherry-pick: commit d031626b73c871de3b214f412c49e0bf479896e4
commit d17ecb323100a48efd1e2c70ae94fee390bae154

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

How commit d17ecb323100a48efd1e2c70ae94fee390bae154 was cherry picked? It is already part of 1.10.


etcd cluster not communicating

I set up a CoreOS using vagrant per https://github.com/coreos/coreos-vagrant
I vagrant ssh into each host in a separate terminal.
on node-1 i run:
core@core-01 ~ $ etcdctl set foo bar
on node 2 and 3:
Error:  100: Key not found (/foo) [238]```
```core@core-03 ~ $ etcdctl get foo
Error:  100: Key not found (/foo) [241]```

running `journalctl -u etcd` on each machine produces 3 identical outputs. all nodes have elected themselves leader (does not appear they are communicating).

core@core-01 ~ $ journalctl -u etcd
-- Logs begin at Thu 2015-08-20 18:47:42 UTC, end at Thu 2015-08-20 18:51:49 UTC. --
Aug 20 18:47:56 core-01 systemd[1]: Started etcd.
Aug 20 18:47:56 core-01 systemd[1]: Starting etcd...
Aug 20 18:47:56 core-01 etcd[1084]: [etcd] Aug 20 18:47:56.140 INFO      | 97c12d68c4fe4c188d26e79b681a7d2a is starting a new cluster
Aug 20 18:47:56 core-01 etcd[1084]: [etcd] Aug 20 18:47:56.142 INFO      | etcd server [name 97c12d68c4fe4c188d26e79b681a7d2a, listen on :4001, advertised url http://<IP_ADDRESS>
Aug 20 18:47:56 core-01 etcd[1084]: [etcd] Aug 20 18:47:56.142 INFO      | peer server [name 97c12d68c4fe4c188d26e79b681a7d2a, listen on :7001, advertised url http://<IP_ADDRESS>
Aug 20 18:47:56 core-01 etcd[1084]: [etcd] Aug 20 18:47:56.142 INFO      | 97c12d68c4fe4c188d26e79b681a7d2a starting in peer mode
Aug 20 18:47:56 core-01 etcd[1084]: [etcd] Aug 20 18:47:56.142 INFO      | 97c12d68c4fe4c188d26e79b681a7d2a: state changed from 'initialized' to 'follower'.
Aug 20 18:47:56 core-01 etcd[1084]: [etcd] Aug 20 18:47:56.143 INFO      | 97c12d68c4fe4c188d26e79b681a7d2a: state changed from 'follower' to 'leader'.
Aug 20 18:47:56 core-01 etcd[1084]: [etcd] Aug 20 18:47:56.144 INFO      | 97c12d68c4fe4c188d26e79b681a7d2a: leader changed from '' to '97c12d68c4fe4c188d26e79b681a7d2a'.
core@core-02 ~ $ journalctl -u etcd
-- Logs begin at Thu 2015-08-20 18:48:06 UTC, end at Thu 2015-08-20 18:51:13 UTC. --
Aug 20 18:48:19 core-02 systemd[1]: Started etcd.
Aug 20 18:48:19 core-02 systemd[1]: Starting etcd...
Aug 20 18:48:20 core-02 etcd[1093]: [etcd] Aug 20 18:48:20.032 INFO      | 49b4026aee4c4cfda04daf58a115e53d is starting a new cluster
Aug 20 18:48:20 core-02 etcd[1093]: [etcd] Aug 20 18:48:20.033 INFO      | etcd server [name 49b4026aee4c4cfda04daf58a115e53d, listen on :4001, advertised url http://<IP_ADDRESS>
Aug 20 18:48:20 core-02 etcd[1093]: [etcd] Aug 20 18:48:20.034 INFO      | peer server [name 49b4026aee4c4cfda04daf58a115e53d, listen on :7001, advertised url http://<IP_ADDRESS>
Aug 20 18:48:20 core-02 etcd[1093]: [etcd] Aug 20 18:48:20.034 INFO      | 49b4026aee4c4cfda04daf58a115e53d starting in peer mode
Aug 20 18:48:20 core-02 etcd[1093]: [etcd] Aug 20 18:48:20.034 INFO      | 49b4026aee4c4cfda04daf58a115e53d: state changed from 'initialized' to 'follower'.
Aug 20 18:48:20 core-02 etcd[1093]: [etcd] Aug 20 18:48:20.034 INFO      | 49b4026aee4c4cfda04daf58a115e53d: state changed from 'follower' to 'leader'.
Aug 20 18:48:20 core-02 etcd[1093]: [etcd] Aug 20 18:48:20.034 INFO      | 49b4026aee4c4cfda04daf58a115e53d: leader changed from '' to '49b4026aee4c4cfda04daf58a115e53d'.
core@core-03 ~ $ journalctl -u etcd
-- Logs begin at Thu 2015-08-20 18:48:30 UTC, end at Thu 2015-08-20 18:52:37 UTC. --
Aug 20 18:48:42 core-03 systemd[1]: Started etcd.
Aug 20 18:48:42 core-03 systemd[1]: Starting etcd...
Aug 20 18:48:42 core-03 etcd[1027]: [etcd] Aug 20 18:48:42.652 INFO      | 3f8acdb002ec462b92ad92d61be66de1 is starting a new cluster
Aug 20 18:48:42 core-03 etcd[1027]: [etcd] Aug 20 18:48:42.653 INFO      | etcd server [name 3f8acdb002ec462b92ad92d61be66de1, listen on :4001, advertised url http://<IP_ADDRESS>
Aug 20 18:48:42 core-03 etcd[1027]: [etcd] Aug 20 18:48:42.653 INFO      | peer server [name 3f8acdb002ec462b92ad92d61be66de1, listen on :7001, advertised url http://<IP_ADDRESS>
Aug 20 18:48:42 core-03 etcd[1027]: [etcd] Aug 20 18:48:42.653 INFO      | 3f8acdb002ec462b92ad92d61be66de1 starting in peer mode
Aug 20 18:48:42 core-03 etcd[1027]: [etcd] Aug 20 18:48:42.653 INFO      | 3f8acdb002ec462b92ad92d61be66de1: state changed from 'initialized' to 'follower'.
Aug 20 18:48:42 core-03 etcd[1027]: [etcd] Aug 20 18:48:42.654 INFO      | 3f8acdb002ec462b92ad92d61be66de1: state changed from 'follower' to 'leader'.
Aug 20 18:48:42 core-03 etcd[1027]: [etcd] Aug 20 18:48:42.654 INFO      | 3f8acdb002ec462b92ad92d61be66de1: leader changed from '' to '3f8acdb002ec462b92ad92d61be66de1'.

let me know if there is any more information i can provide for debugging.

there was a type in the discovery token i was using in my user-data file

@ilackarms
Glad you figured it out!
I would suggest you to try etcd2 instead of etcd if you are trying etcd. Thanks!


Default for common attachments filter to Quarantine

As of 1/5/23 and MC468187

Learn Build status updates of commit 5ef0149:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/New-MalwareFilterPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Set-MalwareFilterPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Url.IsLocalUrl should return true when Scheme & Host match

Url.IsLocalUrl returns false for all absolute urls even when the absolute url matches the current request url.
It would be ideal if for absolute urls it would return true if Scheme & Host match. Similar to what's done here:
https://github.com/OrchardCMS/Orchard/blob/dev/src/Orchard/Utility/Extensions/HttpRequestExtensions.cs#L94-L101

That's not what IsLocalUrl is for. It's to indicate a non-absolute URL. Whilst I can see your argument the current behaviour is baked into too many places to change it.


V0.0.5 (#23)

fix bug of computing WEAT score

add factual properity association

update factual properity association demo

update to v0.0.5

add numpy float types as tested types

add ax as passed parameter to plot_factual_association

adapt test_calc_weat_pleasant_attribute to recent weat changes

add warning for eaxct pvalue calculation

update Makefile to remove all generated docs

extend showing depth of docs

fix typo

add warning for filtered weat

change Makefile docs building and cleaning to handle missing directories

rearrange imports

Make docstring line shorter

set atol for testing equality

add to docs page about analysis of we metrics

excecute we demo notebook

elaborate imports

add asserts to cosine_similarities_by_words

use cosine_similarities_by_words to calculate WEAT

add pvalue warning for exact calculating

round WEAT results up to 4 digits

document filtering in WEAT

execute we notebook

clean notebook

fix pvalue caculation bug in WEAT

execute notebook

clean notebook

fix docs

add date of v0.0.5

add test for defualt weat parameters

remove prints

add explanation for WEAT about pvalue

Pull Request Test Coverage Report for Build 235

51 of 63 (80.95%)  changed or added relevant lines in 7 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.3%) to 72.374%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

ethically/we/weat.py
19
20
95.0%

ethically/we/bias.py
16
27
59.26%

Files with Coverage Reduction
New Missed Lines
%

ethically/we/weat.py
1
86.1%

Totals

Change from base Build 210:
0.3%

Covered Lines:
987

Relevant Lines:
1307

💛  - Coveralls


[NeedsReview] B07902077 黃嘉宏

A Pull Request (PR) should explain why we need this PR and how you implement it, so others could understand it quickly.
Since this is just a homework, you do not need to explain why and how.
Do NOT change the status to NeedsReview if you do not want to be graded yet.
Please fill in the following questions as feedback. It is totally optional and would not be graded.
What is the most challenging part in this homework?
git
Is this homework helpful for you?
yes
Is there any suggestion?
可以多教一點git的使用方法

PR readiness check list

[y] Did it pass the Flake8 check?
[y] Did you test this PR?
[y] Did you change the title of this PR to the correct format ([status] student_ID)?

請問助教，這個是not linked to my profile的問題嗎？謝謝～

@B07902077 Yes. See https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/ and https://www.git-tower.com/learn/git/faq/change-author-name-email to fix it.

@amjltc295 助教您好：我把信箱加到github上了 謝謝助教～


Connect statement errors with "Character set '255' unsupported"

Python file
(dbt-env) ubuntu@h1:~$ cat connect.py
import singlestore as s2

HOST = 'h2.singlestore.unx.com'
PORT = 3306
USER = 'root'
PASSWORD = 'Pass@word1'
DATABASE = 'db'

conn = s2.connect(host=HOST, port=PORT, user=USER, password=PASSWORD, database=DATABASE, charset='utf8')

Error
(dbt-env) ubuntu@h1:~$ python3 connect.py
Traceback (most recent call last):
  File "/home/ubuntu/dbt-env/lib/python3.10/site-packages/singlestore/connection.py", line 916, in __init__
    self._conn = self._driver.connect()
  File "/home/ubuntu/dbt-env/lib/python3.10/site-packages/singlestore/drivers/base.py", line 63, in connect
    conn = self.dbapi.connect(**params)
  File "/home/ubuntu/dbt-env/lib/python3.10/site-packages/mysql/connector/pooling.py", line 286, in connect
    return CMySQLConnection(*args, **kwargs)
  File "/home/ubuntu/dbt-env/lib/python3.10/site-packages/mysql/connector/connection_cext.py", line 101, in __init__
    self.connect(**kwargs)
  File "/home/ubuntu/dbt-env/lib/python3.10/site-packages/mysql/connector/abstracts.py", line 1099, in connect
    self._post_connection()
  File "/home/ubuntu/dbt-env/lib/python3.10/site-packages/mysql/connector/abstracts.py", line 1071, in _post_connection
    self.set_charset_collation(self._charset_id)
  File "/home/ubuntu/dbt-env/lib/python3.10/site-packages/mysql/connector/abstracts.py", line 1016, in set_charset_collation
    ) = CharacterSet.get_charset_info(charset)
  File "/home/ubuntu/dbt-env/lib/python3.10/site-packages/mysql/connector/constants.py", line 775, in get_charset_info
    info = cls.get_default_collation(charset)
  File "/home/ubuntu/dbt-env/lib/python3.10/site-packages/mysql/connector/constants.py", line 746, in get_default_collation
    raise ProgrammingError(f"Character set '{charset}' unsupported")
mysql.connector.errors.ProgrammingError: Character set '255' unsupported

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/ubuntu/connect.py", line 14, in <module>
    conn = s2.connect('root:Pass@word1@h2.singlestore.unx.com:3306/db')
  File "/home/ubuntu/dbt-env/lib/python3.10/site-packages/singlestore/connection.py", line 1223, in connect
    return Connection(**dict(locals()))
  File "/home/ubuntu/dbt-env/lib/python3.10/site-packages/singlestore/connection.py", line 918, in __init__
    raise self._driver.convert_exception(exc)
singlestore.exceptions.ProgrammingError: -1: Character set '255' unsupported

Version info
(dbt-env) ubuntu@h1:~$ pip list | grep singlestore
dbt-singlestore          1.1.2
singlestore              0.1.0

(dbt-env) ubuntu@h1:~$ python3 --version
Python 3.10.4

singlestore> select @@memsql_version;
+------------------+
| @@memsql_version |
+------------------+
| 7.8.8            |
+------------------+

Also tested these python connect statements which resulted in the same error as above.
#conn = s2.connect('h2.singlestore.unx.com/db?local_infile=True&charset=utf8mb4&password=Pass@word1&user=root')
#conn = s2.connect(host=HOST, port=PORT, user=USER, password=PASSWORD, database=DATABASE, charset='utf8mb4')
#conn = s2.connect('root:Pass@word1@h2.singlestore.unx.com:3306/db')

Can you include mysql-connector in your pip list as well? That's the backend driver that is doing the actual communication with the server.

(dbt-env) ubuntu@h1:~$ pip list | grep -E 'my|sing'
dbt-singlestore          1.1.2
mypy-extensions          0.4.3
mysql-connector-python   8.0.30
pyparsing                3.0.9
singlestore              0.1.0

Have you tried connecting directly using mysql-connector-python or some other MySQL client? The SingleStore package simply passes those arguments on. I haven't been able to reproduce this issue, so I'm just trying to get more information.

This appears to be an issue with the latest version of mysql.connector. We are actually in the process of changing the driver in the SingleStore Python package to PyMySQL, which I believe will solve this issue. We are trying to get the new release out in a couple of days.

We've verified that this is a bug in the mysql.connector package. The current version of the SingleStore Python package (v0.2.0) no longer uses that driver, so if you change to that version, it should work. Note that the package name changed to singlestoredb rather than singlestore. If you want to work around the issue, you can do the following
conn = s2.connect(host="...", port=..., user="...", password="...")
conn.set_charset_collation(charset="utf8")

Fixed with version 2.0, using singlestoredb package instead of singlestore.
Thanks for the quick turnaround!


fix: bump node core to 2.17.0

PR summary
This PR bumps up our node core version to 2.17.0
PR Checklist
Please make sure that your PR fulfills the following requirements:

[ ] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

:tada: This PR is included in version 0.22.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


security issue in returning post parameters from session in callback phase

Request phase of omniauth store request.params in session which are later assigned in env of callback phase. According do docs we should only store query params but in this case both GET and POST params get stored. POST params can contain authenticity_token of application to protect form CSRF issues. We shouldn't leak such tokens from POST params.
@sferik @jamesarosen @md5

ping ? due to security concern

I haven't been involved in this project in years and know nothing about this.

@lalithr95 Thanks!

@sferik do we need a minor version bump ?


Incorrect halstead formulas

Your documentation (as well as other Halstead documentations) clearly states:

Measure Name
Description

Program Length (N)
The total count of operators and operands.

Program Vocabulary (n)
The total count of unique operators and operands.

However, your code does the opposite -- i.e. adds unique values in program_length, and totals in vocabulary_size:
        let program_length = uniq_operators + uniq_operands;
        let vocabulary_size = total_operators + total_operands;

As a result, all the other derivative measures - Volume, Difficulty, Effort, etc. - are also incorrectly calculated.
p.s. Let me know if I can help with correcting this.

This fix is now available in v2.0.0. Thanks!

@sgb-io -- thanks so much for fixing it so quickly! I can see the new "v2.0.0" tag, but no release yet. When do you plan on marking it as an official release? Just curious.

@ugniusramanauskas the Rust crate and npm package have been available for a few days, but I forgot to publish the Github release. I have now done so. Thanks!


consistent notation

mu, sigma, nu, etc

Notation in text is fixed, still change this in the code


linearstep & smooth_linearstep: handle degenerate edge0==edge1 case.

When edge0 == edge1, these functions should behave like step(edge0,x).
Also add a testsuite that exercises these two new functions, including the degenerate cases.

LGTM


Fatal error didn't mark the task execution as failed

The task in GH actions looks like it was successfully executed but in realty, it failed:

I'm having exactly the same issue - but also have no idea why it's failing as the fatal message doesn't really make sense and I'm sure I have everything configured correctly.


[Caching] Fix the cache replay bugs from driver C APIs

This patch contains a serials of changes that targeted to fix the missing function in C APIs when replaying results from build system. It teaches the driver/build-system to replay the newly specialized makefile dependency files and symbol graph files correctly.
It also tags along and fixes few bugs and small improvements that exposed by the change in separately commits.

@swift-ci please smoke test

@benlangmuir for symbol graph changes because I missed that from the code review.


Not Disabling Ui

When Disabled In The Settings The Ui Still Shows Up
(The Call Container Went Away)

This is not a bug, you're changing the wrong setting. If you would like to entirely disable a button, set its slider to 0 under button customization.


Stick with cids rather than multiformats/cids for now

The change is going to be great, but for now, let's stick with the more "stable" lib.

Done w/ https://github.com/textileio/js-textile/pull/814 over in js-textile

Done w/ https://github.com/textileio/js-textile/pull/814 over in js-textile


Default tamagui theme not working React Native

Current Behavior
I have followed the doc very closely to implement Tamagui for react native.
(which, btw, is super confusing for newcomers since it merges both web & native, and some points feel like they are in the wrong order)
I reached that part:
For an even quicker start, you can get a full design system with @tamagui/config, which we show on the [Configuration](https://tamagui.dev/docs/core/configuration) page. That page also goes into more detail on everything createTamagui accepts.
So I added the "quick start configuration" as is in my tamagui.config.ts, but two issues:
1- setupReactNative is not exported from tamagui, so it crashes
2- so I assumed it was not needed for native, as mentioned in the comments, so here is my final code for this config file:
import { config } from '@tamagui/config'

import { createTamagui } from 'tamagui' // or '@tamagui/core'
const appConfig = createTamagui(config)
export type AppConfig = typeof appConfig

declare module 'tamagui' {
  interface TamaguiCustomConfig extends AppConfig {}
}

export default appConfig

But still, seems like it is not being applied at all:
instead of the expected blue , it is black
I also can't use any of the shorthands like "btrr" etc which I thought would already be part of the default configuration?
Am I missing something here?
I am using the latest 1.43.12 version
Expected Behavior
Default config as per the documentation should world
Tamagui Version
1.43.12

Reproduction
the fork is for next, my issue is on RN

System Info
No response

Try upgrading your tamagui version to 1.7..2 or @latest?

Try upgrading your tamagui version to 1.7..2 or @latest?

I didn't realize there were dozens of updates in just a week;
But even then the latest seems to be 1.47.1; no 1.7xxx
And now that I updated to the latest, the app crashes from this error:

It was working perfectly fine before;
and it doesn't even tell me in which screen it comes from... the risks of working with a "fast moving library" I guess :)

I am also having this issue. My buttons appear black by default. Adding themes to the theme prop doesn't affect the component at all.
I think an update might have broken it?
The example shown here isn't working properly i.e. the superblue them isn't applied.
I even cloned this repo and tried adjusting themes there and they weren't responsive either.

Any update on this? I am also running into issues with the config seemingly not being applied in a blank app.

Fix going out for the superblue that was only specific to the site.
Can you guys give me a repro on the tamagui starter? Platform details too. It's working for us we tested a few different ways.

let me know to re-open it when you have a repro


Updated Spotify to version <IP_ADDRESS>9.gc253025e.

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

cc @jamespik  (sorry for the bump, but this hash has been bad for three days)


Ability to use IAM for etcd snapshot backups to s3

To configure s3 as a backup target in Rancher UI/API, you have to provide s3 credentials. We should be able to leverage IAM as an alternative to that. The backend already supports it, just need to make sure that Rancher-RKE flow works.

Can we make sure that we document it for RKE standalone CLI as well as Rancher docs after it's been tested?

Using IAM profiles for s3 backup auth is implemented and working in rke CLI and in Rancher.

@sangeethah to test, follow the steps defined in the docs and see if you can setup s3 backup using IAM creds.

Tested with build from master-head.

Created rancher server with node having IAM profile
Create cluster in EC2 with nodes having IAM profile by providing S3 bucket name and without other credentials.

During testing this my browser autofilled the key field. The required normal flag is now removed.

Tested with build from master head.
Can create a cluster using S3 backup config, but snapshots are stuck in activating state.
It fails with the below error in rancher logs:
2019/07/18 00:13:04 [ERROR] EtcdBackupController c-g6z9x/c-g6z9x-ms-678dv [etcdbackup-controller] failed with : [etcd-backup] failed to perform etcd backup: Failed to take one-time snapshot, exit code [1]: time="2019-07-18T00:13:03Z" level=fatal msg="faield to set s3 server: failed to check s3 bucket:soumyas3test, err:400 Bad Request"

Tested with build from master head from July 18
Created rancher server with node having IAM profile with S3 access permissions
Create cluster in EC2 with nodes having the same IAM profile by providing S3 bucket name and without other credentials.
Creating cluster with S3 backup is successful
etcd snapshot and restore are functional as expected


Generate models only

Reason/Context
I only want to generate the models and nothing else (for that's all I need). So I copied the whole template and stripped everything I don't need. But that's not a very stable solution assuming that I want to stay in sync with the original template.
Hence, it'd be nice if I could tell the generator to generate models only (like, for example, the OAS generator does it).
Description
We'd have to add a switch to not generate the other stuff. Also, server should become optional, and it shouldn't matter if the protocol is supported or not in that case.

Just jumping in, have you checked out Modelina? 🙂

Thanks, just found that after jumping through some hoops ;)


feat: added test json's #72

Description
Added 4 Json testmodels
How to Review
Check if Json's are correct

LGTM 🚀 let's merge


German translation updated

New words and some corrections/improvements

Thx :smile:

Btw, if you are certain that a particular translation is correct, you need to remove the #, fuzzy line from it or else the translation will not work.

Ah, ok. I'm new to this business, so next time I'll be better :-)


[DesktopVirtualization] Stable 2024 04 03 Release

ARM (Control Plane) API Specification Update Pull Request

[!TIP]
Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

[!NOTE]
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Click here to see the details of Step 1, Breaking Changes review
If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review
See https://aka.ms/azsdk/pr-arm-review.

 Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ ] New resource provider.
[x] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix OpenAPI spec quality issues in S360.
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

 Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

      "$ref": "../../../../../common-types/resource-management/v1/types.json#/definitions/Resource"

could you use the newer vesions of the commontypes everywhere in the PR please : v5

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5476 in 7f70719. [](commit_id = 7f70719dd5d802c3b5250b80e08a2c1194095051, deletion_comment = False)

      "description": "tags to be updated",

tags for example are already defined in the v5 common types

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5485 in 7f70719. [](commit_id = 7f70719dd5d802c3b5250b80e08a2c1194095051, deletion_comment = False)

        "description": "Force flag to delete App Attach package."

[ARMBlockingComment] please do not take query params in the delete payload. ARM will not know to use these for example when doing Resource group delete

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:3488 in 7f70719. [](commit_id = 7f70719dd5d802c3b5250b80e08a2c1194095051, deletion_comment = False)

      "$ref": "../../../../../common-types/resource-management/v1/types.json#/definitions/ResourceModelWithAllowedPropertySet"

v5 everywhere

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5453 in 7f70719. [](commit_id = 7f70719dd5d802c3b5250b80e08a2c1194095051, deletion_comment = False)

      "$ref": "../../../../../common-types/resource-management/v1/types.json#/definitions/Resource"

could you use the newer vesions of the commontypes everywhere in the PR please : v5
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5476 in 7f70719. [](commit_id = 7f70719, deletion_comment = False)

Added v5

      "description": "tags to be updated",

tags for example are already defined in the v5 common types
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5485 in 7f70719. [](commit_id = 7f70719, deletion_comment = False)

Updated to v5, do we need to remove references to tags here?

      "description": "tags to be updated",

tags for example are already defined in the v5 common types
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5485 in 7f70719. [](commit_id = 7f70719, deletion_comment = False)

Updated to v5, do we need to remove references to tags here?

Are the provided field in v5 Resource enough for your case ? If not, add them in AppAttachPackagePatch. I dont see tags present in "Resource". Please verify if other resource objects can match your case.

@ramoka178 , please also review this.

        "description": "Force flag to delete App Attach package."

[ARMBlockingComment] please do not take query params in the delete payload. ARM will not know to use these for example when doing Resource group delete
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:3488 in 7f70719. [](commit_id = 7f70719, deletion_comment = False)

We have used force flags for delete throughout our delete endpoints. Is there documentation on why we can't take query params or what the suggested workaround is?

@ramoka178 , please also review this.

        "description": "Force flag to delete App Attach package."

[ARMBlockingComment] please do not take query params in the delete payload. ARM will not know to use these for example when doing Resource group delete
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:3488 in 7f70719. [](commit_id = 7f70719, deletion_comment = False)

We have used force flags for delete throughout our delete endpoints. Is there documentation on why we can't take query params or what the suggested workaround is?

@ramoka178 , please also review this.

appAttachPackages is the new resourcetype getting added in this api version. For the existing APIs, it will be breaking change to alter the API signature. But for the new DELETE APIs, query params are not being allowed.

For next reviewer: Got an ack for the Delete API having a query param as its an existing pattern for the RP. Waiting on the model validation fix

        "description": "Force flag to delete App Attach package."

[ARMBlockingComment] please do not take query params in the delete payload. ARM will not know to use these for example when doing Resource group delete
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:3488 in 7f70719. [](commit_id = 7f70719, deletion_comment = False)

We have used force flags for delete throughout our delete endpoints. Is there documentation on why we can't take query params or what the suggested workaround is?

@ramoka178 , please also review this.

appAttachPackages is the new resourcetype getting added in this api version. For the existing APIs, it will be breaking change to alter the API signature. But for the new DELETE APIs, query params are not being allowed.

@ramoka178 said he would be investigating whether this applied to us.

Lets indeed remove the force delete parameter if having it has no benefit.

    },

nit - I think systemData is already inherited from v5 trackedResource by default, so you should be able to omit this

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5456 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)

    "tags": {

tags are already inherited from v5 trackedResource by default, so you should be able to omit this

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5473 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)

        "type": "string"

can add "format": "arm-id"

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5526 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)

      "description": "URL of keyvault location to store certificate"

Clarify: is it supposed to be a full path including the certificate name?

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5531 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)

  "description": "Schema for patchable fields on an App Attach Package.",

In the context of a PATCH request right.
Can we please call it 'updatable' not 'patchable' if that is correct, to avoid confusion with software updates.

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5540 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)

"AppAttachPackagePatchProperties": {

You could consider merging your definitions of
AppAttachPackagePatchProperties and AppAttachPackageProperties
and just using "x-ms-mutability" annotations instead

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5539 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)

"AppAttachPackagePatchProperties": {

Or factoring out the hostPoolReferences definition so as to avoid duplication?

In reply to:<PHONE_NUMBER>

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5539 in 63d9b3f. [](commit_id = 63d9b3fee8cb05659ca3d19ff3cccaa9a6f5a782, deletion_comment = False)

"AppAttachPackageInfoProperties": {

Are all of the non-readonly AppAttachPackageInfoProperties mutable for PATCH requests?
Because I that is what the current model says... If so, great.

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5564 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)

  "description": "Schema for Import Package Information properties.",

This description looks probably wrong? Considering you're using it to define the 'AppAttachPackage_Update' request/responses

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5565 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)

  "description": "Schema for App Attach Package properties.",

The phrasing 'Schema for X' can be a bit confusing in the docs. In the context of docs its usually pretty obvious we're talking about schemas already.... so is it a schema for a schema?

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5509 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)

        "ALL"

whats the difference between ALL and Neutral?

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5683 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)

      },

Consider adding detailed values + descriptions list here

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5688 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)

        "x86a64",

nit, I'm searching for this value 'x86a64' online to try and find out if it is a well-known term - but I'm not finding it!?
It seems like it probably means what is also called 'x86_64'...
or even just 'x64'?
But you define both of those enum values. Are they actually any different in meaning? Which one is the architecture I'm thinking of? :)

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5682 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)

  "description": "Parameter indicating how the health check should behave if this package fails staging"

what's health check - the imported app package??

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5706 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)

      "x-nullable": true

why change the nullability? Isn't this a breaking change??

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:6036 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)

      "description": "Package Version found in the appxmanifest.xml. ",

docs nit, Version is not a proper noun, it could be lower case

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:6179 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)

  "description": "The name of the App Attach package arm object",

remove the text 'arm object'. We try to avoid referring to ARM (an implementation detail from the customer POV), and object is kind of redundant isn't it?

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:7707 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)

        "description": "Object containing Workspace definitions.",

doc feedback: can just call it 'The workspace definition'

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:132 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)

        "description": "Object containing App Attach Package definition.",

Doc feedback - can just call it something like 'The app package update parameters'

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:3525 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)

        "description": "Object containing App Attach Package definitions.",

Doc feedback - can just call it something like 'The app package create parameters' or 'The app package definition'

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:3430 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)

    },

nit - I think systemData is already inherited from v5 trackedResource by default, so you should be able to omit this
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5456 in d04b278. [](commit_id = d04b278, deletion_comment = False)

Removed

    "tags": {

tags are already inherited from v5 trackedResource by default, so you should be able to omit this
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5473 in d04b278. [](commit_id = d04b278, deletion_comment = False)

Removed

        "type": "string"

can add "format": "arm-id"
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5526 in d04b278. [](commit_id = d04b278, deletion_comment = False)

added

      "description": "URL of keyvault location to store certificate"

Clarify: is it supposed to be a full path including the certificate name?
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5531 in d04b278. [](commit_id = d04b278, deletion_comment = False)

It does include certificate name, updated description to be clearer.

  "description": "Schema for patchable fields on an App Attach Package.",

In the context of a PATCH request right. Can we please call it 'updatable' not 'patchable' if that is correct, to avoid confusion with software updates.
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5540 in d04b278. [](commit_id = d04b278, deletion_comment = False)

Updated

  "description": "Schema for App Attach Package properties.",

The phrasing 'Schema for X' can be a bit confusing in the docs. In the context of docs its usually pretty obvious we're talking about schemas already.... so do you mean it is a schema for a schema?
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5509 in 63d9b3f. [](commit_id = 63d9b3f, deletion_comment = False)

This description matches the other descriptions for properties in TLAOs.

  "description": "Parameter indicating how the health check should behave if this package fails staging"

what's health check - the imported app package??
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5706 in d04b278. [](commit_id = d04b278, deletion_comment = False)

We have health check on our resources, this parameter determines whether or not there should be errors thrown if the package fails in staging or not.

"AppAttachPackagePatchProperties": {

You could consider merging your definitions of AppAttachPackagePatchProperties and AppAttachPackageProperties
and just using "x-ms-mutability" annotations instead
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5539 in d04b278. [](commit_id = d04b278, deletion_comment = False)

This matches our property separation for all the other resource types in our swagger, and we will remove the distinction when we migrate to TypeSpec this year.

      "x-nullable": true

why change the nullability? Isn't this a breaking change??
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:6036 in d04b278. [](commit_id = d04b278, deletion_comment = False)

This is matching what our current service implementation has been. We have been treating this as null in our service handling the entire time, and are just updated our swagger to match our implementation. This is moving to a less restrictive implementation by allowing nulls, so shouldn't be a breaking change.

      "description": "Package Version found in the appxmanifest.xml. ",

docs nit, Version is not a proper noun, it could be lower case here
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:6179 in 63d9b3f. [](commit_id = 63d9b3f, deletion_comment = False)

Updated.

  "description": "The name of the App Attach package arm object",

remove the text 'arm object'. We try to avoid referring to ARM (an implementation detail from the customer POV), and object is kind of redundant isn't it?
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:7707 in d04b278. [](commit_id = d04b278, deletion_comment = False)

Removed

        "description": "Automation error response describing why the operation failed.",

Why mention 'Automation'?? Is the automation concept customer facing, or an implementation detail?
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:3452 in d04b278. [](commit_id = d04b278, deletion_comment = False)

Cleaned up description

"AppAttachPackageInfoProperties": {

Are all of the non-readonly AppAttachPackageInfoProperties mutable for PATCH requests? Because I that is what the current model says... If so, great.
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5564 in d04b278. [](commit_id = d04b278, deletion_comment = False)

yes

        "ALL"

whats the difference between ALL and Neutral?
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5683 in d04b278. [](commit_id = d04b278, deletion_comment = False)

Neutral is a specific kind of package that is meant to run on all architectures. All means do not filter on package architecture and return everything

        "x86a64",

nit, I'm searching for this value 'x86a64' online to try and find out if it is a well-known term - but I'm not finding it!?
It seems like it probably means what is also called 'x86_64'... or even just 'x64'?
But you define both of those enum values. Are they actually any different in meaning? Which one is the architecture I'm thinking of? :)
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5682 in d04b278. [](commit_id = d04b278, deletion_comment = False)

That is X86 CHPE for ARM64 [Mostly native ARM64, but with X86 function exports]
Described here: https://learn.microsoft.com/en-us/windows/apps/desktop/modernize/package-identity-overview#package-identity-fields-limits

The remaining comments are suggestions. Consider addressing them before merging but they dont block the merge.

      "x-nullable": true

sorry if this was already covered -
why change nullability? Newly returning nulls in the response is a cross-version breaking change, I would question, is it really benign??

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:4364 in cfc2f69. [](commit_id = cfc2f69ecc8785c3d91bb004b33c747bf77039db, deletion_comment = False)

      "x-nullable": true

Looks like you explained this earlier as
"This is matching what our current service implementation has been. We have been treating this as null in our service handling the entire time, and are just updated our swagger to match our implementation. This is moving to a less restrictive implementation by allowing nulls, so shouldn't be a breaking change."
However, I don't think that's actually correct, to say its not a breaking change, unless you would never actually return null in the response, and want this to mean only that you allow nulls in the input.

In reply to:<PHONE_NUMBER>

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:4364 in 63d9b3f. [](commit_id = 63d9b3fee8cb05659ca3d19ff3cccaa9a6f5a782, deletion_comment = False)

      "x-nullable": true

By the way, in general I've been advising people not to declare properties as nullable unless there's a specific need, because needing to worry about both 'null' and 'undefined' cases in general makes life harder.

In reply to:<PHONE_NUMBER>

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:4364 in 63d9b3f. [](commit_id = 63d9b3fee8cb05659ca3d19ff3cccaa9a6f5a782, deletion_comment = False)

      "x-nullable": true

Just to double check:
Meaning your service could actually return 'null' on the wire, since its readonly?
Even though its declared as a boolean in the previous version?

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:4370 in cfc2f69. [](commit_id = cfc2f69ecc8785c3d91bb004b33c747bf77039db, deletion_comment = False)

      "x-nullable": true

I don't remember private link specification docs recommending this property be nullable - is that what they actually say?

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:4383 in cfc2f69. [](commit_id = cfc2f69ecc8785c3d91bb004b33c747bf77039db, deletion_comment = False)

        "ALL"

Adding such details in x-ms-enum 'values' property or the enum description
could become helpful docs for future askers of the FAQs I've asked.

In reply to:<PHONE_NUMBER>

Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5683 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)

/azp run

/pr RequestMerge

/azp run


Description broken on PyPI

I followed a link here from Twitter:
https://pypi.python.org/pypi/nbpresent/1.0.0
And saw that the whole rendering is broken because Markdown.

Thanks!
It's an on-going struggle to get PyPi happy. It's the same content as on
github, and i've got a lot of stuff in the air with respect to the release,
but will definitely keep this in mind in case I have to do a quick 1.0.1 or
something!
On Tue, Feb 16, 2016 at 12:34 PM Juan Luis Cano Rodríguez <
<EMAIL_ADDRESS>wrote:

I followed a link here from Twitter:
https://pypi.python.org/pypi/nbpresent/1.0.0
And saw that the whole rendering is broken because Markdown.
—
Reply to this email directly or view it on GitHub
https://github.com/Anaconda-Server/nbpresent/issues/53.


Expired accounts are reported as locked out

I noticed that a lot of accounts are reported as locked out, which isn't really possible with a lockout duration of 30 minutes. I checked a few accounts and noticed that they have expired months or years ago. This makes the use of --safe pretty pointless. I guess the Kerberos error code ERR_CLIENT_REVOKED doesn't really tell us why the credentials have been revoked, so there is not much that can be done about this. But it could be mentioned in the console output that account isn't necessarily locked, but could also be expired (or possibly disabled?).

Good point. I can make the error message clearer. Maybe a better implementation of --safe would be to check if we get ERR_CLIENT_REVOKED a certain number of times in a row (maybe 3? 5?). That would more likely indicate that our current scan is causing these and we're locking accounts out one-by-one


nz-timeline-item class attribute removed version 9

Reproduction link
https://stackblitz.com/edit/angular-ixi7zb?file=src/app/app.component.ts
Steps to reproduce
Open stackblitz example
What is expected?
In version 8, the "class" attribute of the "nz-timeline-item" was kept when rendering the element.
What is actually happening?
In version 9, the "class" of the element is removed. This way it is not possible to apply specific classes to the timeline item. We need this to overwrite the styling of the dot.

Environment
Info

ng-zorro-antd
9.3.0

Browser
chrome

Could you please specifiy which nz-timeline-item you were refering to? A picture showing the different wouuld be appreciated. Thank you <3

Hi @KevinVG . This is a breaking change introduced in 9.x.
In order to implement the reverse feature, we use nz-timeline-item just to capture user contents
https://github.com/NG-ZORRO/ng-zorro-antd/blob/8415a702552fe147495c7d699bc62c68bc68249a/components/timeline/timeline.component.ts#L68-L69
, and render them with <li>
https://github.com/NG-ZORRO/ng-zorro-antd/blob/8415a702552fe147495c7d699bc62c68bc68249a/components/timeline/timeline.component.ts#L54-L66
So, please overwrite your styling files. I assume that changing nz-timeline-item to li.ant-timeline-item is suitable.

Hello,
When every ant-timeline-item has the same style, this is possible. However, we use different styling on each nz-timeline-item so we need to pass something along. The stackblitz example was an abstract example, i've made two new examples that use our styling. Same code for both versions, V8 works, V9 doesn't.
V8: https://stackblitz.com/edit/angular-sf61nv?file=src/styles.scss
V9: https://stackblitz.com/edit/angular-ixi7zb-qxbvkx?file=src/app/app.component.ts

@KevinVG
As a workaround, I add some class within the content and then use li.ant-timeline-item:has(.blue) to customize the style.
Not an ideal solution but works.


Checking for 'func' command works on MacOS too

This PR changes the code that checks for the func command in PATH so that it works on both Windows and MacOS.
The current code only works on Windows:

The path separator is a semicolon (doesn't work on Mac). This PR changes the code so that it uses the Path.PathSeparator rather than hard-coding a semicolon or a colon. For more information check: https://learn.microsoft.com/en-us/dotnet/api/system.io.path.pathseparator?view=net-7.0
The check assumes that the command file func has the extension suffix .exe. This is true on Windows, but not on MacOS. This PR searches for both cases to support both Windows and MacOS.
The Environment.GetEnvironmentVariable("PATH", EnvironmentVariableTarget.Machine) returns null because the option passed EnvironmentVariableTarget.Machine fails on MacOS. Removing the option fixes it and shouldn't cause any unexpected behaviours. For more infomration check https://learn.microsoft.com/en-us/dotnet/api/system.environment.getenvironmentvariable?view=net-7.0

Thanks for accepting the PR. I haven't came across any other issues, but will keep you posted. Cheers.

Hi @eashi , I have uploaded version 1.6.0 of LogicAppUnit to Nuget. This includes your changes in PR #14 and also PR #15 for support for the MacOS platform. Thank you for your contribution.

This is great news, thanks Mark for the great project and active maintenance.


Markdown: Added support for nested bold and italic tokens

This PR adds support for nested bold and italic tokens.
This also resolves #1849.

Example
Before:

After:

@DaveJarvis Thank you for taking the time to review this PR!

bold and italic share nearly identical regular expressions
bold, italic, and strike share nearly the same content

The new createInline function should address both issues.

pandoc's markdown defines ::: as well, for classes
pandoc's markdown supports { } after various elements, also for classes

I don't think we need to support a parser specific feature. If it's a commonly used feature, then sure we'll add it.
But you might want to open a new issue for this or add it to #1558 as this isn't within the scope of this PR.

not immediately obvious why token.content[2] isn't used/defined (line 196)

I added a comment explaining the structure of token.content.

don't see any tests for ** bold with _ italic inside
don't see any tests for __ bold with * italic inside

Added.

is bold/italic/strike a possibility?

Yes, you can nest bold, italic, and strike, or is there any issue with it?
The reason why support for nested bold, italic tokens was so difficult is that they can use the same character as delimiters. This makes parsing very hard and error-prone (sometimes even actual MD parser get wrong). Because strikes use a different character, there shouldn't be an issue, or is there?

If it's a commonly used feature, then sure we'll add it.

Available since Oct 2017 (https://github.com/jgm/pandoc/issues/168), so it's gaining in usage and popularity.

Yes, you can nest bold, italic, and strike, or is there any issue with it?

I didn't see any specific unit tests that go through all the combinations, but maybe they aren't necessary.

Because strike uses different delimiters than bold and italic, so it's generally less problematic. So I think that this should be sufficent testing.

Regarding the combinations: Yes we could write such a function but I don't think we have to. Looking at the regular expression, it's enough to test the nested tokens one level deep (It doesn't make sense the nest e.g. bold inside bold which makes things simpler) which gives us 6 * 4 combinations which are all covered by the bold, italic and strike tests in this PR.
More extensive tests might be necessary in the future but for now, I think it's fine as is.

@DaveJarvis Again, thank you for reviewing!


Update documentation on auto login and lock

Update documentation on auto-login and lock to contain a second link which has the original author's plist.  The author was hosting the file but their links appear to be broken.  Including this would have saved me some time.
If you want to chat privately about this, feel free to reach out to my MSFT alias: jiboulte.

If we want to depend on some specific .plist, we should probably host its contents ourselves rather than having users chase a trail of breadcrumbs.

Sounds good to me!  I assumed there was a reason it wasn't in there already, copyright or something.  I'll make the change and keep the original link as attribution.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: jboulter11 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@andyjlewis I'm good with this change. You would know better than me what standards we have around attribution, copyright, etc.


[$1000] Web - Tooltip position keeps on shifting for long user names on request money details page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app
Click on plus and click on request money
Enter any amount and continue
Select user with long user name
On details page, hover on username, observe current tooltip position
Change amount of change description text and again hover on username, observe that for same user, tooltip position is now changed

Expected Result:
App should display tooltip constantly at center of username on request money details page as it does on search page
Actual Result:
Tooltip position changes when we change amount or description and is not at center of username on request money details page
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.46-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/207a86e7-41d6-4053-b887-00ff2fe69b9d
https://github.com/Expensify/App/assets/93399543/7f95a6f4-ba4a-468a-a0d8-436eb86e6983
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690428525912479
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0133c32537626b0505
Upwork Job ID:<PHONE_NUMBER>677566976
Last Price Increase: 2023-07-31

The issue is caused by getTooltipShiftX not working as expected
https://github.com/Expensify/App/blob/ddc19e004211ce4282c2c28b08dafadd84a62cc5/src/components/DisplayNames/index.js#L49
Here you can see the inconsistent outputs it is generating

not overdue, added to upwork

@spcheema Thanks for the proposal. Your RCA does not seem accurate enough, I don't see how the display name container is related to changing the amount. Also onLayout returns different values but it has nothing to do with the element being visible or not, the callback just seems to fire during animation.

@bernhardoj Thanks for the proposal. Your RCA is correct, this is solely dependent on the onLayout being called too early. Using getBoundingClientRect to get the correct value just before rendering the tooltip (instead of using the stale value that was calculated on mount) looks good to me.
:ribbon: :eyes: :ribbon: C+ reviewed
Link to proposal

https://github.com/Expensify/App/pull/23990 - this was deployed to prod on 9 august - I am working on payment now

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@s77rt] The PR that introduced the bug has been identified. Link to the PR:
[@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@s77rt]  Determine if we should create a regression test for this bug.
[@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Payment Summary:

[ ] External issue reporter - @dhanashree-sawant, paid in Upwork $250
[ ]  Contributor that fixed the issue - @bernhardoj, paid in Upwork $1000 + 3 day bonus $500 = $1500
[ ]  Contributor+ that helped on the issue and/or PR - @s77rt,  paid in Upwork $1000 + 3 day bonus $500 = $1500

@s77rt please complete the regression checklist above and then we can close this out. Thanks

The PR that introduced the bug has been identified: This existed since day one https://github.com/Expensify/App/pull/1632
The offending PR has been commented on: I can't comment as the PR is locked
A discussion in #expensify-bugs has been started: Not needed. Not much to discuss
Determine if we should create a regression test for this bug: No

@laurenreidexpensify ^


Attribute Mappings are unable to update when a secondary userstore is disabled

Describe the issue:
When there are multiple multiple userstore configured and one of them is disabled, then unable to update the attribute mappings.

How to reproduce:

Add a secondary userstore

Create attribute mapping for it

Add a new userstore.

Disable the first user store.

Try to add attribute mappings for the 2nd userstore and notice the error when you try to save them.

Expected behavior:
Should be able to update the attributes of the new user store.
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: [e.g., IS 5.10.0, IS 5.9.0]
OS: [e.g., Windows, Linux, Mac]
Database: [e.g., MySQL, H2]
Userstore: [e.g., LDAP, JDBC]

Optional Fields
Related issues:

Suggested labels:

Do we need to show the disabled user-store in the Mapped Attributes for the claim/attribute?


How to load the pretrained model in Fraud Detection Tasks

Hi,
It's very nice of you to opensource the code.
I've run your code and got the model in checkpoints.
When I tried to reproduce the results in Fraud Detection Tasks, I tried many kinds of methods but failed to load the pretrained model.
For example,
model=TabFormerHierarchicalLM.from_pretrained("model_path")
but it failed.
Could you tell me how to load the the pretrained model? Thanks a lot.

Hello @J-JY ,
Thank you for the message.
Could you provide more information what error you get? I am yet to update this public repository with the downstream tasks code and hoping to make it available around the conference (ICASSP) week.


[Bug] External links for vm.Card now open in new tabs

Description
Previously when clicking vm.Card used as a NavCard, ie with href enabled, would lead to external links opening in the same tab, but not in a new tab, on py.cafe. This is now fixed.
Adding some more info (thanks @petar-qb ):

More info on what target="_blank" does - see link
It looks from the docs that dbc.NavLink works out when to format links and when not: https://dash-bootstrap-components.opensource.faculty.ai/docs/components/nav/

P.S. It is debatable whether this is really a bug or a feature, but given that it broke things on py.cafe, I will leave the Bug tag - happy to have it changed though
Screenshot
Notice

[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
I have not referenced individuals, products or companies in any commits, directly or indirectly.
I have not added data or restricted code in any commits, directly or indirectly.

I'm sharing this link with the reviewers in case you're unfamiliar with the context of target="_blank" as I haven't been.

It previously always opened in the same tab, right? It's not specific to py.cafe?

Ah yes, I only tested this on py.cafe, and never locally, but you are correct. Changed the PR title

I didn't look at how it works on py.cafe but from a UX perspective, I wonder if we even want to add this to our Card model. There are some standard guidelines of when "opening in a new tab" vs "opening the same tab" is preferable, and generally, it tends towards "opening in the same tab". See this for context: https://blog.pope.tech/2024/01/02/how-to-make-external-links-accessible/

On py.cafe this does not work, and this was the suggested fix by Maarten and Antony. I just read through the guidelines and they seem pretty strong and mostly convincing! Personally I have never perceived this, but I think the accessibility points are a good point.

That said, the article also mentions that if links open in a new tab, there should be a visual clue, which is not the case for the NavCard because the actual link is not visible.
So I am wondering if this should even live in our standard Card model or if this should be a custom component where you extend the Card with that argument. I currently prefer the second considering above.

Happy to go either way - we certainly cannot make this a custom component for the py.cafe landing snippet because we want that code to be as clean as possible. If we choose not to implement this, then we have to find another solution. Curious to hear what @Joseph-Perkins and @antonymilne think.
@Joseph-Perkins For context: do we want the Card with href to open external links in a new browser tab or not? (this is the bug we encountered with your snippet example - but fixing this we this solution causes other accessibility issues)

@Joseph-Perkins For context: do we want the Card with href to open external links in a new browser tab or not? (this is the bug we encountered with your snippet example - but fixing this we this solution causes other accessibility issues)

Why don't we add the same footer-banner as in our demo app? That didn't add much code. I think the links to the docs and git repo shouldn't be that prominent as currently in the form of NavCards anyway 😄
I think that's still clean enough and then you can add the argument directly inside the NavLink below. No need to create a custom component and I think that visually looks better + doesn't require that much code.
app = Vizro(assets_folder="./assets").build(dashboard)
app.dash.layout.children.append(
    html.Div(
        [
            dbc.NavLink("Contact us", href="https://github.com/mckinsey/vizro/issues", className="footer-link"),
            dbc.NavLink("GitHub", href="https://github.com/mckinsey/vizro", className="footer-link"),
            dbc.NavLink(
                "Docs", href="https://vizro.readthedocs.io/en/stable/", className="footer-link"
            ),
            html.Div(["Made in ", html.Img(src=get_asset_url("logo.svg"), id="banner", alt="Vizro logo"), "vizro"],
                     className="banner-text"),
        ],
        className="anchor-container"
    )
)

It previously always opened in the same tab, right? It's not specific to py.cafe?

Yes indeed. It's just the py.cafe is a good example (but not the only one) where opening in the same tab doesn't work well.

I didn't look at how it works on py.cafe but from a UX perspective, I wonder if we even want to add this to our Card model. There are some standard guidelines of when "opening in a new tab" vs "opening the same tab" is preferable, and generally, it tends towards "opening in the same tab". See this for context: https://blog.pope.tech/2024/01/02/how-to-make-external-links-accessible/
That said, the article also mentions that if links open in a new tab, there should be a visual clue, which is not the case for the NavCard because the actual link is not visible.
So I am wondering if this should even live in our standard Card model or if this should be a custom component where you extend the Card with that argument. I currently prefer the second considering above.

Indeed I've read very similar things in the past, and this was exactly why I didn't want to set the link target in the dcc.Markdown. In general the correct default behaviour for links is definitely to open them in the same tab.
However, I think for the special (and not very common) case of a dbc.Card that does an external link, opening in a new tab is reasonable as a default (not just for py.cafe). Ideally we would have a the little "opens in new tab" icon on the card like you say also, but I'm ok to not do that straight away.
In this case I would prefer to not do as a custom component because this will be part of the py.cafe template code so should be a simple example to get people started and that will just make it look way too complicated. So the only other possibility here is that we add another argument to vm.Card that allows a user to specify whether to open external links in new tabs or not. That seems like overkill though (and could itself just be done through a custom component). So overall I think this is a good default, and the only thing I would change is to make it clearer visually that the link opens in a new tab, but we can save that for another time.
wdyt?

wdyt?

See answer above :) Independently of the technicalities, I would prefer to just have the footer and not have these external links as prominent as the NavCard if this should be our pyCafe landing page? And then I think we don't need a custom component and the code it still simple enough?

The footer banner is an interesting idea and not something I'd thought of here, but I don't think it solves this case (which is relevant for other examples I've seen outside py.cafe also, not just our demos banner). It's still kind of weird custom code that we'd need to put in - especially because we'd need all the CSS as well, not just the Python. To avoid it being weird custom code at all we'd need to create a new "Vizro footer" component that bundles the CSS too, which is not impossible but a lot more effort. Also maybe in future it would be useful to have some insert_footer command or even Footer model or similar to simplify this beyond just the Vizro banner, but again that would be a much bigger change.
So in terms of visuals, the navcards is good enough for me since it shows off the native use of vizro components, and even if the banner looks a bit nicer I don't think it's worth the extra complexity, especially since we should solve the navcard link opening for other contexts anyway.
BUT your comments have made me go back and think again about there's a different fix here that would avoid opening in a new tab, and actually I think there is! If we set target="_top" then this will not open anything in a new tab but instead break out of the iframes, which is really what we want - py.cafe example. This is much more the expected user behaviour so we don't need to worry about visually indicating that the link opens in a new tab any more.

This is much more the expected user behaviour so we don't need to worry about visually indicating that the link opens in a new tab any more.

That sounds like a great solution! 😄 👍

BUT your comments have made me go back and think again about there's a different fix here that would avoid opening in a new tab, and actually I think there is! If we set target="_top" then this will not open anything in a new tab but instead break out of the iframes, which is really what we want - py.cafe example. This is much more the expected user behaviour so we don't need to worry about visually indicating that the link opens in a new tab any more.

Shall we go with this then?


Basic Dockerfile

Adding a basic dockerfile

I will cheat and break the only rule of github development (You don't merge your own pull requests). Fingers crossed.


Adding Visual Studio Team Services integration with Azure Automation

Hi @eamonoreilly, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@eamonoreilly Hi Eamon
If you're adding new content, please work in the private repo instead of the public repo.
You can Move content between the public and private repos.
I'm closing this pull request so that you can make the changes in the private repository. Thanks.


V5 - Complex values example doesn't work

http://redux-form.com/5.3.1/#/examples/complex?_k=m8uqn5
Changing Line 34 of ObjectSelect.js to
const val = Array.isArray(value) ? value.map(JSON.stringify) : value

Fixes it for me. Problem was value was ""1"" not "1". Although I'm not sure this will work with multiple

Closing with bulk close of v5 issues. If this issue still requires action and/or also affects v6/7, please request a reopen with details or raise a new issue. v5 PR's are still welcomed.


As a user, I want to see an alphabetized list of members on the members page, where letters come alphabetically before punctuation.

testing notes
Confirm that "friend of renoir" is not listed first on the members page when sorted alphabetically; confirm that "friend of renoir" is listed in the members list with quotes.

On the members page, the first item is "Friend of Renoir"--I assume this is because "quotation mark" is treated as alphabetically prior to "A" (for "Abbott"). Abbott should be first on the list, and members whose names begin with quotation mark (and/or other punctuation) should be at the end.
https://shakespeareandco.princeton.edu/members/
dev notes

[x] update index_data method on mep.people.models.Person method to strip leading punctuation on the sort name that is used for the sort_name_isort field; the logic for generating sort titles for books uses: title.lstrip(punctuation)
[x] add a test case for Person index_data to confirm that the "Friend of Renoir" case is handled properly.

Test site looks good!


Add dburi option for full Mongo connection string support

This PR simply allows for more complex Mongo connection strings to be passed to Agenda. For instance, when connecting to clusters.

Looks great, thanks @chickencoder! I'll publish a version containing this feature in the coming days.

I'm really sorry @chickencoder, totally forgot about publishing this back then. Included now in the latest.


Video element inside editor

Video element is not movable inside bootstrap-wysiwyg editor. E.g. Justify align center, left and right is not working in video tag.

@timdorr #213


⚠ TorrentLeech has degraded performance

In e5e712e, TorrentLeech ($TL) experienced degraded performance:

HTTP code: 200
Response time: 3508 ms

Resolved: TorrentLeech performance has improved in 102c824 after 6 minutes.


Error in automatic test due to unknown parameter 'players'.

This has been solved in https://github.com/deepmind/open_spiel/pull/599
It should be implemented on master branch

See how to implement heterogeneous players.


Modrinth

Consider publishing this to Modrinth as well for more exposure and possibility to include in its modpacks.

Thanks !!! I don't really use that platform ofter, but I will publish it for sure.

It has been sent for review (https://modrinth.com/mod/ctrl-q).
Thank you so much for this suggestion!


Prefix Error?

When trying to run discordmail after configuring, I get this.

You are on a old version of Node.js
Please upgrade before creating an issue.


If (When?) global C# usings are added, include %(Platform) metadata

Proposal: C# global usings
Summary
If C# global usings, are added for the Windows App SDK, then .NET MAUI needs a way to turn them off in MSBuild. A Platform="Windows" item metadata would make this possible.
Currently, the plan for .NET 6 is for MAUI to do something like:
<ItemGroup Condition=" '$(UseMaui)' == 'true' and ('$(ImplicitUsings)' == 'true' or '$(ImplicitUsings)' == 'enable') ">
  <Using Remove="@(Using->HasMetadata('Platform'))" />
</ItemGroup>

They are working on a potential better design in .NET 7.
If the Windows App SDK doesn't add C# global usings, then you don't need to do anything. Thanks!
Rationale
If .NET MAUI doesn't have a way to turn these off, then Microsoft.Maui.Button and the Windows Button (and every other type that has the same name), will conflict.
Important Notes
Related: https://github.com/dotnet/sdk/issues/21996

@Scottj1s more your lane than mine. Tag you're it :P

If the Windows App SDK doesn't add C# global usings, then you don't need to do anything. Thanks!

That's out intent. The proposed patch to make the auto-initializer be agnostic to others using global usings is righteous but WinAppSDK has no intention to use or require global usings.

I think the guidance for https://github.com/dotnet/sdk/issues/21996 is that adding global usings in a NuGet package is not recommended yet. (There isn't a good design for it yet in .NET 6)
If the Windows App SDK is ever a .NET workload, global usings might be a nice feature to add, though.

I concur with @DrusTheAxe - no action needed now


Restore callback microbenchmarks but make them manual for now

While the callback alternative implementation goes through performance debugging, remove these microbenchmarks from the test suites so as to avoid flakes on presubmit and at import. Previous attempts to avoid timeouts by reducing benchmark size were insufficient, so just disable them for now and restore their original message size.

When I try to regenerate projects on master, I get a diff  of build_autogenerated.yaml that results from this PR.
Interestingly, the sanity tests don't seem to catch this  (neither on this pullrequest  or on go/grpc-fusion-master).
This needs to be investigated
FYI  @nicolasnoble @gnossen as  we chatted about this.


Errors from previous session get dumped on first command

The Deephaven IDE has an annoying issue where when I start a new server session, it seems that the browser is still trying to find variables from the previous session, and shows errors in the console when they cannot be found.

This is annoying, but I'm used to it.
In VSCode, these errors didn't show up till I executed code for the first time, and left me thinking something actually went wrong until the code completed.

@alexpeters1208 I believe this is a duplicate of Smarter output logging between server connections #12

I think you're right.


Indeterminate State

Sometimes, you know how long things are going to take. Sometimes you don't. Instead of disabling the progress bar, an indeterminate state would be nice. It would show the elapsed time and input barProgress(i).

Good idea. I have several, higher priority projects I'm working on currently so I can't give any kind of timeline on when I would look at adding this. I'll leave the issue open and add it to my list of things to do. Cheers!


Added disableSticky functionality

Update directive for disableSticky ng-model functionality. For Issue #33.
Changes to sticky.js to include an ng-model binding for disableSticky to disable sticky behavior
Changes to demo.html to test disable-sticky.js.
Changes to Readme.txt to describe the disable-sticky functionality.
Please review and let me know if I missed something. I didn't see any tests or wiki on proper submissions.

Thanks @enkodellc, this is great!

@d-oliveros thanks for merging! It was not clear what you were doing for sticky.min.js so please update that if you have time or give me some direction and I will submit a PR with the minification.


Train module problem: ritm_train.py import error.

THX for sharing!
Import error was found in ritm_train.py
from model.model import (
get_hrnet_model,
DistMapsHRNetModel,
get_deeplab_model,
get_shufflenet_model,
)
these modules were not exist in model.py, even in this project. so where can i find these modules, please?

Is there any plan for release the training code, please? As it's amazing for common scenes， I want to have a try for other domain adaptation。

Is there any plan for release the training code, please? As it's amazing for common scenes， I want to have a try for other domain adaptation。

Sorry, the training code will not be released in the near future, but some new parameters will be released soon.


Add "outline" style to icon button

Added for all button sizes, along with style update for solid style
I also renamed and re-organized all the buttons in Figma so it's more consistent :)


Unhandled Xbox veto, Error Code: 0x8015dc12

VS 2017 15.9.4
Windows 10 SDK (10.0.17763.0)
Unity 2019.3.0f3
Xbox One (retail). Dev Mode activated
Sandbox matches Xbox One, Partner Center, and XBL settings in app.
Unity plug-in 1804 QFE3
uap:SupportedUsersmultiple</uap:SupportedUsers> added to manifest
StartCoroutine(SignInManager.Instance.SignInPlayer(playerNumber));
...
xboxLiveUser = SignInManager.Instance.GetPlayer(playerNumber);
xboxLiveUser is not null but GamerTag and XboxUserId are empty strings

Posting for those who are still having issues:
Your "Sandbox" might be stuck in Developer Mode.  Read this to under stand more: https://docs.microsoft.com/en-us/gaming/xbox-live/test-release/tools/live-pc-sandbox-switcher
HOW TO FIX:
Download the XboxLiveTools.zip from here:  https://aka.ms/xboxliveuwptools
Unzip XboxLiveTools.zip
Open PowerShell as Admin and type:
.\XBLPCSandbox RETAIL
I searched for WEEKS for this!   I tried to make a game on Xbox One back in 2017, and my computer has been stuck in Developer mode.  I had enabled it in Unity, but after many upgrades to Unity, I lost the link to go back to Retail Mode.
Hope this helps some of you.