chore: replicate the existing tests using testcontainers-go

What does this PR do?
It creates a separate main_testcontainers_test.go file with copies of the very same tests as in main_test.go. These new tests use a Go build tag in order to separate their execution from the existing tests, therefore it's possible to run both test suites separately:
# dockertests only
$ go test ./... -count=1 -tags=dockertest
# testcontainers only
$ go test ./... -count=1 -tags=testcontainers

The new tests are created using testcontainers-go, showcasing an alternative to ory/dockertest on how to test Docker containers with Testcontainer for Go.
Finally, it bumps the Go version from Go 1.16 to 1.18
Why is it important?
As we explained in #6, we don't want to replace, but coexist in this application, which is used by the Go tutorial in the Docker docs.
Related issues

Closes #6

Follows-up
As described in https://github.com/docker/docs/issues/16221, we'd like to contribute to the Go tutorial in the Docker docs, including a section for Testcontainers for Go.

@olliefr is there anything that we could do to merge this one? Please see https://github.com/docker/docs/issues/16221#issuecomment-1337086292 for more context

Hello! While working on #8 I have made a decision to remove the dependency on ory/dockertest altogether and replace the existing functional tests with a trivial unit test example.
This is because I feel that in the context of a short tutorial such as the Golang section of Docker docs, those two tests were too extensive and were not adding pedagogical value, and partly because no matter what framework or what testing methodology I would have chosen, it would get out-of-date pretty quickly regardless.
Since the point of that page was not to show "one true way" of how to test Go applications but to demonstrate multi-stage Docker builds, I made a decision to remove the tests. This will also reduce maintenance burden significantly. I plan to update the docs on the topic of testing to provide a few references to popular Go testing frameworks, including testcontainers, but I don't think that this example application needs automatic testing beyond a trivial example that I have just added in the latest update.
I realise that you have spent some time working on this PR and I thank you for your efforts. I'll make sure that I mention testcontainers in the doc page.


Add support for OpenGTS compatible clients (GPSLogger for Android)

Signed-off-by: Kostiantyn Luzan<EMAIL_ADDRESS>

Hi, Is there any more issues before merging this?

I don't know. Have you fixed all the issues? You have to notify me if that's the case.

Yes, I fixed all the issues.

Merged, thanks for the pull request.


Leveraging Numba as a Standalone Compiler like Nuitka without Intrusive Annotations

Having to add annotations to functiona is very intrusive. Sometimes you might be calling functions written by other parties and in libraries. It would be helpful to have Numba compile the code without annotations either AOT or using JIT.

Since a decorator is just a function which returns a function AFAICS you can easily  jit any function in your own code:
from numba import jit
from thirdparty import slow_func

fast_func = jit(slow_func)

It's likely also possible to monkeypatch thirdparty to replace slow_func with the jitted version so that all internal functions will benefit.
Disclaimer: Just thinking out loud - I haven't tried it, YMMV.

If a function calls another function which calls another functions ... These kind of usage becomes very cumbersome. Since most of the work is already done we can have an alternative python compiler which does AOT and JIT using Numba.

I completely agree with @sirinath. It seems silly that to make this work:
def some_func(var):
    return var + 5

@jit
def my_func(var):
    return some_func(var)

you just need to add @jit to some_func, but numba can't provide that functionality for you. For our usage it would also be very helpful if while compiling a function and numba encounters an undecorated function it just tries to jit right there and then.

While I agree with the sentiment that Numba should try compiling dependent functions, Numba is sufficiently limited in what kinds of code it can compile that we prefer users to opt into compiling all needed functions for now.  It isn't clear how often compiling arbitrary functions in third-party code would actually work given the current limitations of the compiler.  (Maybe we've turned a corner on this that I'm not aware of...)
I think once object mode is a little more sophisticated (right now the only benefit is loop lifting) this is something we could investigate.  We would need to see if there is a way to mark functions that Numba previously failed to compile as such, so that we don't waste time attempting to compile them over and over.

In our use case, we provide our users with a library, and as part of it's api we accept user defined python functions. We want to be able to hide the fact that we use numba, as it's an implementation detail on our side. So what we do is we take the user defined function and "decorate" it ourselves (basically calling jit(user_func)). The problem is that it breaks down if the users split their implementation into more than one function, in which case they need to decorate all of them with @jit, which seems like unnecessary cruft. If there was at least a way for us to say jit(user_func, recurse=True) (and similarly cfunc(..., recurse=True)) that would have been great.

Also being able to just run any Python program without additional decoration, imports or other special usage would be ideal. You take a valid python program and use alternate Python runtime based on Numba and everything runs faster with with JIT and also being able to generate standalone executables with AOT compiling.

@sirinath what would you consider to be Nuitka's primary limitations from your perspective? Presumably there is something (indeed, I hope a lot!) about Numba that compels you to want to use it despite the fact that it doesn't do many of the things that Nuitka does.
That said: +1 on facilitating the ability to @jit functions that include other byte-compiled (but non-jitted) functions therein.

Numba has better corporate backing and more mature.

Thank you for the perspective!

OK, @dscole's UDF use case is a pretty compelling reason to make an opt-in opton like @jit(callees=True) (maybe a different name) that would automatically try to compile all called functions as well.  I've spun this idea out into a more focused issue: #2634.
Numba is definitely not designed for efficient whole program compilation at this point, so we won't be addressing that use case any time soon.

Update on this  issue: #2634 was implemented by #4331. From what I understand, the request here initially was whole program compilation? Since the likelihood that we will be doing this anytime soon is low, I will close this issue now. If you would like this issue to be revisted, I would suggest initiating a conversation onabout this is the new Numba Discourse group at: https://numba.discourse.group/ -  perhaps we can revisit this at some point in Numba's future. Thank you for using Numba!


simplify egress and put placeholder values

@linsun @duglin this is ready to review/merge.  Includes the simplified virtualservice & serviceentry rules.


Can we have dedicated class /function to pass the bounding box of entity and it highlights the same on document in UI

Is your feature request related to a problem? Please describe.
Describe the feature you'd like
I need to utilize the function or class which can take in the bounding box details of entity and it highlights the same on document in UI.
Additional context
Add any other context or screenshots about the feature request here.

Is there a function in the library which generates the PDF with rendered bounding box ?

@aakash086 The bounding boxes are placed using HTML+CSS. The code can be found here. You may use it wherever needed.

@aakash086 closing issue with the resolution provided by @OmarRad


Fix incorrect app title, package and file names

Changes

Rename the title of the app to SoConnect.
Rename the seedu/address package to soconnect.
Rename the relevant files, methods and attributes to match our product name - SoConnect.
Fix some of the JavaDocs comments to follow the Java Coding Standards .

Codecov Report
Base: 68.09% // Head: 68.07% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (e05af4b) compared to base (42a4ef5).
Patch coverage: 80.74% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #84      +/-   ##
============================================
- Coverage     68.09%   68.07%   -0.02%
  Complexity      589      589
============================================
  Files            88       88
  Lines          1962     1961       -1
  Branches        245      245
============================================
- Hits           1336     1335       -1
  Misses          531      531
  Partials         95       95

Impacted Files
Coverage Δ

src/main/java/soconnect/AppParameters.java
75.00% <ø> (ø)

src/main/java/soconnect/Main.java
0.00% <ø> (ø)

src/main/java/soconnect/MainApp.java
0.00% <0.00%> (ø)

src/main/java/soconnect/commons/core/Config.java
68.18% <ø> (ø)

.../main/java/soconnect/commons/core/GuiSettings.java
77.77% <ø> (ø)

...c/main/java/soconnect/commons/core/LogsCenter.java
78.37% <ø> (ø)

src/main/java/soconnect/commons/core/Messages.java
0.00% <ø> (ø)

src/main/java/soconnect/commons/core/Version.java
82.50% <ø> (ø)

.../main/java/soconnect/commons/core/index/Index.java
100.00% <ø> (ø)

...ct/commons/exceptions/DataConversionException.java
100.00% <ø> (ø)

... and 78 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Rewrite how to build or make a video how to compile

This is the most annoying tutorial I ever saw,  too confusing to understand wtf I should do

So what?
I would gently support u if u asked me what to do.
Better not understand it u nerd.


Workflows failing with "The issue type selected is invalid"

I am filing this on behalf of my customer @shweta4398 who has successfully set up a workflow with this Action. Every time they run the workflow, it fails with the same error text: The issue type selected is invalid.
Here is the Action they provided:

If there is no issue type, the error occurs, or if they add an issue type, same error. jira_issue_type does not appear to be a criteria you can populate with this Action.
Looking at a portion of the logs, it appears that somewhere along the way, the rest/api path is picked up and the Action seems to identify this as an issue type:
jira.exceptions.JIRAError: JiraError HTTP 400 url: https://appdirect.jira.com/rest/api/2/issue
	text: The issue type selected is invalid.

	response headers = {'Date': 'Mon, 10 Apr 2023 06:09:59 GMT', 'Content-Type': 'application/json;charset=UTF-8', 'Server': 'AtlassianEdge', 'Timing-Allow-Origin': '*', 'X-Arequestid': 'e3f409a204a7400ac8bb8f63346850f5', 'X-Aaccountid': '628dac6ff2261e00682a1d81', 'Cache-Control': 'no-cache, no-store, no-transform', 'X-Content-Type-Options': 'nosniff', 'X-Xss-Protection': '1; mode=block', 'Atl-Traceid': '8a5f7da3d11568d8', 'Report-To': '{"endpoints": [{"url": "https://dz8aopenkvv6s.cloudfront.net"}], "group": "endpoint-1", "include_subdomains": true, "max_age": 600}', 'Nel': '{"failure_fraction": 0.001, "include_subdomains": true, "max_age": 600, "report_to": "endpoint-1"}', 'Strict-Transport-Security': 'max-age=63072000; includeSubDomains; preload', 'Transfer-Encoding': 'chunked'}
	response text = {"errorMessages":[],"errors":{"issuetype":"The issue type selected is invalid."}}
Error: Process completed with exit code 1.

Logs:
1_Set up job.txt
2_Sync CodeQL alerts to Jira issues.txt
4_Complete job.txt

Team,
Yes the above issue seems to be still persisting , Can you guide me on the above errors???
Thanks,
Shweta.

Hello team ,
Can you add jira_issue_type to the workflow?? So that I would be able to execute the workflow!!
Thanks,
Shweta.

This issue is occuring for me as well. is jira_issue_type the correct field used or do we use another field.


Model viewer is not getting the ar-status event

Description
Hello model-viewer team. I'm working with Angular 13 project. And I want to get the ar-status event from model viewer. But i doesn't works for me. Anyone is working with Angular and it happends the same?
I had been installed the model viewer library by npm.
Live Demo
  const compatibleDevice$ = fromEvent(this.modelViewerElement.nativeElement, 'ar-status')
    compatibleDevice$.pipe(
      map((ev:any)=>{
        console.log(ev)
      }),
      take(1),
    ).subscribe()

Im getting the model-visibitilty event and this works for me very well.
const loaded$ = fromEvent(this.modelViewerElement.nativeElement, 'model-visibility')
    loaded$.pipe(
      map((ev:CustomEvent)=>{
        console.log(ev)
        if(ev.detail.visible === true){
          this.isModelLoaded$.next(true)
        }else{
          this.isModelLoaded$.next(false)
        }
      }),
      take(1),
    ).subscribe()

Version

model-viewer: v1.10.1

Browser Affected

[x] Chrome
[ ] Edge
[ ] Firefox
[ ] IE
[x] Safari

OS

[ ] Android
[ ] iOS
[ ] Linux
[x] MacOS
[ ] Windows

AR

[x] WebXR
[x] SceneViewer
[x] QuickLook

Hi @ bieldiaz, thanks for reaching out. I don't have much experience with Angular, but to understand the issue better, can you share more details?

Hello @samaneh-kazemi, thank you for your reply. I want to detect if the device is compatible with AR with the ar-status event. But I see that you have to press the ar-button to know if is compatible or not. Is there any way to know before (not by clicking the ar button). Thank you very much.

HI @benmbark, knowing if device can support AR is only approximate (you aren't allowed to know for sure due to finger-printing concerns in the browser). We hide the AR button when we know AR is not supported, but it sometimes shows when AR still fails. What problem you are trying to solve?

ar-status is not getting fired at all, is this normal?

ar-status only applies to WebXR AR sessions, not Scene Viewer or Quick Look (which don't give us any feedback): https://modelviewer.dev/docs/index.html#entrydocs-augmentedreality-css-arStatus
You can check if AR works (not 100%, but decent) using https://modelviewer.dev/docs/index.html#entrydocs-augmentedreality-properties-canActivateAR


Difference in Polyline Rendering on Mapsui and KML Viewer

Hi,
I have noticed a difference in the rendering of a polyline on Mapsui and on a KML viewer(using the polylines returned from the Mapsui library).  The angles don't align properly. The polylines rendered on the KML view is correct since I corroborated it with other KML viewers. I used version 2.0.3 of Mapsui.Forms
KML viewer used - http://kmlviewer.nsspot.net/
Snapshot taken from Mapsui -

Snapshot taken from the KML Viewer -

This is the contents of the kml file -
<?xml version="1.0" encoding="utf-8"?> <kml xmlns="http://www.opengis.net/kml/2.2">   <Folder>     <Placemark>       <name>Start Point</name>       <Point>         <coordinates>-73.613861083984375,45.540431976318359</coordinates>       </Point>     </Placemark>     <Placemark>       <name>Final Path</name>       <description>Final Path</description>       <LineString>         <extrude>true</extrude>         <tessellate>true</tessellate>         <altitudeMode>absolute</altitudeMode>         <coordinates>-73.613861083984375,45.540431976318352,0 -73.613826212056935,45.540420586979728,0 -73.613799110292646,45.540461294483322,0 -73.613775862327316,45.540453701592085,0 -73.613786703028424,45.54043741858883,0 -73.613763455072956,45.540429825697579,0 -73.613752614370156,45.540446108699811,0</coordinates>       </LineString>     </Placemark>   </Folder> </kml>

Congratulations, you are now the record holder 'finding the oldest bug in the Mapsui'. It stems from the initial commit 'adding the trunk of the svn repository' from 24-1-2012. That is 3522  days. This is the initial import so it is even older.
The problem is that in SphericalMercator we round to float which is not necessary because Point is type double (and was double at the time of the initial import).

I created a PR which will probably be in the next release.
In the meantime you could make a copy of SphericalMercator.cs and remove the rounding (see PR) and make a copy of MinimalTransformation.cs and rename that and assign that to Map.Transformation (see the projection sample).
Apparently no-one even investigated this level op detail so there could be even more rounding errors.

Hi Paul,
As as work around I made a copy of the SphericalMercator class and fixed the rounding issue and it worked when I create 'LineStrings' and add it to the layers of the Map. I did not try the MinimalTransformation yet. Can you suggest a time frame as to when we might get this fix as part of the release.
Thanks for suggesting a workaround. :)

The fix will be in the next RC release which I expect in a week, or maybe two.
I see that there is also direct use of SphericalMercator in Positioncs:
public Mapsui.Geometries.Point ToMapsui()
{
    return Mapsui.Projection.SphericalMercator.FromLonLat(Longitude, Latitude);
}

So the MinimalTransformation fix will have no effect here. So perhaps wait for the release.

So perhaps wait for the release.

Note: You don't necessarily have to wait for a release. The fix has been merged to master and we have CI builds that generate nupkgs for every revision. You could just use the nuget packages of the current master branch (via a local packages source in VS): https://ci.appveyor.com/project/pauldendulk/mapsui/builds/40834197/artifacts
HTH.

The fix has now been released as part of rc.3. I will close this issue.

The fix has now been released as part of rc.3. I will close this issue.

We tested the rc.3 version and the lines are rendering as expected. Thanks a lot Paul for this hotfix!!!


Update name of on-chain PBFT members list

Updates docs to reflect change to the name of the on-chain list of
members in a PBFT network. Corresponds to this PBFT PR:
https://github.com/hyperledger/sawtooth-pbft/pull/126
Signed-off-by: Logan Seeley<EMAIL_ADDRESS>

memebers -> members

oof


Certain Custom Colors do not work - shortcut will not expand

Certain custom colors cause the shortcut to not expand. Dark/Light Color Work as expected. This can be reproduced if you edit the group and select custom color, and using the color palette, select certain colors, then save.
For example I'll go through the top row of the 'Basic Colors' (QTY 8), from left to right (Sorry if i'm not technically correct on the color):

Salmon: Works
Yellow: Works
Light Green : Works
Green : Does not work
Teal  : Works
Blue : Does not work
Pink:  Works
Pink/Purple: Works

I'm running Windows 10, Version 20H2, fully patched.

Reproducible;
Will look into patching the issue now.


OnDeeplink is not triggered when app is launched from background

Report
OnDeeplink is not triggered when the app is launched from the background, using one link URLs but if the app is killed and apps open from the URL then onDeeplink is invoked.
Plugin Version
6.4.4
On what Platform are you having the issue?
ios and android
What did you do?
ℹ Please replace these two lines with what you did.
e.g. Run pod install
What did you expect to happen?
when we click on onelink URLs even while the app is running in the background, onDeeplink callback should be called.
What happened instead?
when we click on onelink URLs even while the app is running in the background, onDeeplink callback should is not called.
Please provide any other relevant information.
we initialize sdk before our main login component as part of app launch.
Code we have
appsFlyer.onDeepLink((res) => {
Logger.log('onDeepLinking: ' + JSON.stringify(res));
if (res?.data?.deep_link_value) {
//deeplink to the screen
}
});
appsFlyerInitValues = {
//sset onDeeplinklistener: true
}
appsFlyer.initSdk(
appsFlyerInitValues,
async (result) => {
    }

    Logger.log('AppsFlyer initialized');
},
(error) => {
    Logger.error(error);
}

);

hi! it happens to me.. how do you fix it?

We're having the same issue, how can this be resolved ?

We've encountered the same issue. The onDeeplink is triggered when the app is closed but when the app is on background it doesn't. Have you resolved the issue @vjmangu

Hi, I have the same problem
Does anyone have a solution?
version: "6.4.0"

My workaround was change android:launchMode to standard on manifest.

same here 6.8.2

Any solution for this issue

why was this closed? obviously still an issue

I believe I found the issue. According to their android docs https://dev.appsflyer.com/hc/docs/dl_android_unified_deep_linking#implementation:~:text=📘-,Note,-onDeepLinking is not
setIntent must be called in onNewIntent in the MainActivity file of the java / kotlin code. It is not called by default.
This is obviously not possible with typical expo workflows, so AppsFlyer should update their config plugin to do it so that they have actual Expo support (right now they don't really support expo since this critical functionality is missing). Going to try to write a config plugin for this and see if it works, if it does I'll open a PR

I have confirmed my above suspicion, Expo support is currently incomplete b/c the config plugin is missing some required native code changes on Android, which leads to the problem @sonnguyprophet has described.
If you're not using Expo you can just override the onNewIntent function in the main activity as in the above docs. If you are using expo you can use this config plugin
const {
  mergeContents,
} = require("@expo/config-plugins/build/utils/generateCode");
const { withDangerousMod } = require("@expo/config-plugins");
const fs = require("fs");
const path = require("path");

async function readFileAsync(path) {
  return fs.promises.readFile(path, "utf8");
}

async function saveFileAsync(path, content) {
  return fs.promises.writeFile(path, content, "utf8");
}

function getPath(root, bundleId) {
  return path.join(
    root,
    "app/src/main/java",
    ...bundleId.split("."),
    "MainActivity.kt"
  );
}

const withOnNewIntent = (config) => {
  return withDangerousMod(config, [
    "android",
    async (mod) => {
      const path = getPath(
        mod.modRequest.platformProjectRoot,
        mod.android.package
      );
      const file = await readFileAsync(path);
      const updatedWithIntentOverride = mergeContents({
        src: file,
        newSrc: `  override fun onNewIntent(intent: Intent) {
    super.onNewIntent(intent)
    setIntent(intent)
  }`,
        // inserts it after the first function in the activity class
        anchor: /\}/,
        offset: 2,
        tag: "appsflyer-on-new-intent",
        comment: "//",
      });
      // import android.content.Intent;
      const updatedWithImport = mergeContents({
        src: updatedWithIntentOverride.contents,
        newSrc: `import android.content.Intent`,
        // import as second line in the file
        anchor: /package/,
        offset: 1,
        tag: "appsflyer-import-intent",
        comment: "//",
      });
      await saveFileAsync(path, updatedWithImport.contents);
      return mod;
    },
  ]);
};

module.exports = function withAppsFlyerAndroid(config) {
  config = withOnNewIntent(config);
  return config;
};

I opened a PR with this config plugin but IDK if they're going to merge it

Thanks @iway1 I have the exact same issues as you. I will try out your plugin.


Add support for proof of key for code exchange

The spec is here: https://tools.ietf.org/html/rfc7636
In essence:

The client sends a code challenge, which is the sha256 of a high entropy value on the authorize request.
The server associates that value with the issued code
The client sends the original high entropy value to the server on the token request.
The server hashes that value, base64url encodes it and compares it against the challenge associate with the code.
If the computed challenge matches the original challenge we emit tokens, otherwise we fail.

Should we be adding support for this in our clients?

PKCE is for desktop/mobile native clients.

Fixes https://github.com/aspnet/Identity/issues/1205


biomass vs microbial biomass- soil & sediment packages

Describe the bug
biomass is available in sediment but not soil. Soil has specifically "microbial biomass".
The definition for biomass : Amount of biomass; should include the name for the part of biomass measured, e.g. Microbial, total. Can include multiple measurements
Definition for microbial_biomass: The part of the organic matter in the soil that constitutes living microorganisms smaller than 5-10 micrometer. If you keep this, you would need to have correction factors used for conversion to the final units
"biomass" providing only microbial as an example while "microbial_biomass" is available is confusing if someone is doing a general term search.
Also, biomass is applicable to soil, thinking about plant or insect. These could be quantified.

Microbial biomass also provides a spot to detail the method.
I think this should be added for biomass as the type of biomass is ambiguous.

biomass vs microbial biomass
because biomass has "Microbial" in the example, and this makes use of biomass vs microbial_biomass confusing.
NMDC will add non-microbial biomass to clarify use until these terms are resolved.


Add certificate provisioning test

HIL test for the certificate provisioning examples
Install mcumgr on runners to facilitate the test

This test will pass on both of the selected boards (1024 and 9160). However it's rather common for the 1024 to not log the opening message which pytest is matching against:
Looking for:
17:01:18.493:DEBUG:twister_harness.device.device_adapter: #: uart:~$ [00:00:00.515,777] <dbg> cert_provisioning: main: Start certificate provisioning sample

Not getting it in a test that failed:
17:45:56.495:DEBUG:twister_harness.device.hardware_adapter: Flashing finished
17:45:56.495:DEBUG:twister_harness.device.hardware_adapter: Opening serial connection for /dev/serial/by-id/usb-SEGGER_J-Link_000729255509-if00
17:45:56.497:INFO:twister_harness.fixtures: Wait for prompt
17:45:56.647:DEBUG:twister_harness.helpers.shell: Got prompt
17:45:56.700:DEBUG:twister_harness.device.device_adapter: #: uart:~$ [00:00:00.502,000] <inf> littlefs: FS at w25q32jvwj0@0:0x3d0000 is 32 0x1000-byte blocks with 512 cycle
17:45:56.701:DEBUG:twister_harness.device.device_adapter: #: uart:~$
17:45:59.510:DEBUG:twister_harness.device.device_adapter: #: uart:~$ [00:00:00.502,000] <inf> littlefs: sizes: rd 16 ; pr 16 ; ca 64 ; la 32
17:45:59.523:DEBUG:twister_harness.device.device_adapter: #: uart:~$ [00:00:00.502,000] <err> littlefs: WEST_TOPDIR/modules/fs/littlefs/lfs.c:1234: Corrupted dir pair at {0x0, 0x1}
17:45:59.581:DEBUG:twister_harness.device.device_adapter: #: uart:~$ [00:00:00.502,000] <wrn> littlefs: can't mount (LFS -84); formatting
17:45:59.582:DEBUG:twister_harness.device.device_adapter: #: uart:~$ [00:00:00.609,000] <inf> littlefs: /lfs1 mounted
17:45:59.583:DEBUG:twister_harness.device.device_adapter: #: uart:~$ [00:00:00.610,000] <wrn> cert_provisioning: Could not stat /lfs1/credentials/client_cert.der, err: -2
17:45:59.584:DEBUG:twister_harness.device.device_adapter: #: uart:~$ [00:00:00.610,000] <wrn> cert_provisioning: Could not stat /lfs1/credentials/private_key.der, err: -2
17:45:59.586:DEBUG:twister_harness.device.device_adapter: #: uart:~$ [00:00:00.610,000] <err> cert_provisioning: Error reading certificate credentials from filesystem
17:45:59.587:DEBUG:twister_harness.device.device_adapter: #: uart:~$ [00:00:00.610,000] <inf> cert_provisioning: Sending hello! 0
17:45:59.592:DEBUG:twister_harness.device.device_adapter: #: uart:~$ [00:00:02.503,000] <inf> eth_mcux: ETH_0 enabled 100M full-duplex mode.
17:46:02.654:DEBUG:twister_harness.device.device_adapter: #: uart:~$ uart:~$ [00:00:05.610,000] <inf> cert_provisioning: Sending hello! 1
17:46:07.620:DEBUG:twister_harness.device.device_adapter: #: uart:~$ uart:~$ [00:00:10.610,000] <inf> cert_provisioning: Sending hello! 2

@sam-golioth I asked for another review just because I added this tiny commit: https://github.com/golioth/golioth-firmware-sdk/pull/294/commits/76681f89105ea59c594a00de3f61810aaa782e3e


it seems not support for python3.6?

Hi WuMing757,
Could you specify which parts you find Python3.6 doesn't work?  Thanks.

Same problem here

Hi jermeythegreat,
Could you let me know which example you are running and you find it doesn't work?  Thank you very much.


96boards-tools: add initial recipe

udev rule for standard UART device name
boot script to resize rootfs to match partition size on first boot

Signed-off-by: Nicolas Dechesne<EMAIL_ADDRESS>

Apart from the minor nitpick, looks good.

ok, i updated the pull request and took care of your comment.
i also tested the recipe on ifc6410, and it worked fine. as far as i am concerned.. it's good to go, can you merge it?
thx


Make headings extraction work with ecmascript spec

https://github.com/mdn/content/issues/4482#issuecomment-826975940 made me notice they were not being extracted at the moment


Can't clone on windows

Not sure if this is meant to run on Windows, but I can't clone the repo:
>git clone https://github.com/hdorio/hwzip.zig
Cloning into 'hwzip.zig'...
remote: Enumerating objects: 109, done.
remote: Counting objects: 100% (109/109), done.
remote: Compressing objects: 100% (91/91), done.
remote: Total 109 (delta 17), reused 104 (delta 12), pack-reused 0
Receiving objects: 100% (109/109), 3.65 MiB | 5.14 MiB/s, done.
Resolving deltas: 100% (17/17), done.
error: invalid path 'doc/zip - Zip Files: History, Explanation and Implementation/files/APPNOTE-4.5.0.txt'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

Looks like the doc filename zip - Zip Files: History, Explanation and Implementation is invalid on Windows.

@marler8997 Thank you for pointing out this issue.

Not sure if this is meant to run on Windows, but I can't clone the repo:

No it was not but since it's the only issue to build it on Windows, I renamed the files.


fix unreleased views in uiwindow for non-dismiss animation case

if we present skbrowser from animated view for a 'single photo' but didn't implement the optional delegate method:
@objc optional func viewForPhoto(_ browser: SKPhotoBrowser, index: Int) -> UIView?
The resizableImageview and backgroundView  should also be removed from UIWindow
Optional way is to make the delegation method compulsory

Thank you for your help! 👍


resourceVersion should not be set on objects to be created

When trying to secure my Ingress with letsencrypt, it gets stuck on the temporary certificate.
cert-manager-controller logs contain a lot of the following:
E0128 19:24:30.977579       1 event.go:296] Could not construct reference to: '&v1alpha1.Certificate{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"my-service-cert", GenerateName:"", Namespace:"my-service-8-testing", SelfLink:"", UID:"24bac32f-a5b7-477f-b3a0-e312eb6b938c", ResourceVersion:"1600503", Generation:3, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:63747458329, loc:(*time.Location)(0x2d04f40)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference{v1.OwnerReference{APIVersion:"extensions/v1beta1", Kind:"Ingress", Name:"ingress-service", UID:"6ce19bd4-d2f3-498f-bb63-853f5542686b", Controller:(*bool)(0xc0008bdb28), BlockOwnerDeletion:(*bool)(0xc0008bdb29)}}, Initializers:(*v1.Initializers)(nil), Finalizers:[]string(nil), ClusterName:"", ManagedFields:[]v1.ManagedFieldsEntry(nil)}, Spec:v1alpha1.CertificateSpec{CommonName:"", Organization:[]string(nil), Duration:(*v1.Duration)(nil), RenewBefore:(*v1.Duration)(nil), DNSNames:[]string{"my.domain.com"}, IPAddresses:[]string(nil), SecretName:"my-service-cert", IssuerRef:v1alpha1.ObjectReference{Name:"letsencrypt-prod", Kind:"ClusterIssuer", Group:""}, IsCA:false, Usages:[]v1alpha1.KeyUsage(nil), ACME:(*v1alpha1.ACMECertificateConfig)(0xc000c69540), KeySize:0, KeyAlgorithm:"", KeyEncoding:""}, Status:v1alpha1.CertificateStatus{Conditions:[]v1alpha1.CertificateCondition{v1alpha1.CertificateCondition{Type:"Ready", Status:"False", LastTransitionTime:(*v1.Time)(0xc000c69580), Reason:"TemporaryCertificate", Message:"Certificate issuance in progress. Temporary certificate issued."}}, LastFailureTime:(*v1.Time)(nil), NotAfter:(*v1.Time)(nil)}}' due to: 'selfLink was empty, can't make reference'. Will not report event: 'Warning' 'SaveCertError' 'Error saving TLS certificate: resourceVersion should not be set on objects to be created'
E0128 19:24:30.978655       1 controller.go:131] cert-manager/controller/certificates "msg"="re-queuing item  due to error processing" "error"="resourceVersion should not be set on objects to be created" "key"="my-service-8-testing/my-service-cert"

And they stop after printing out the following:
W0128 19:51:33.975100       1 reflector.go:302] cmd/controller/app/controller.go:137: watch of *v1.Secret ended with: too old resource version: 1606541 (1607852)

Here's the output of kubectl describe certificate,issuer,clusterissuer --all-namespaces:
# kubectl describe certificate,issuer,clusterissuer --all-namespaces
Name:         my-service-cert
Namespace:    my-service-8-testing
Labels:       <none>
Annotations:  <none>
API Version:  certmanager.k8s.io/v1alpha1
Kind:         Certificate
Metadata:
  Creation Timestamp:  2021-01-28T19:18:49Z
  Generation:          3
  Owner References:
    API Version:           extensions/v1beta1
    Block Owner Deletion:  true
    Controller:            true
    Kind:                  Ingress
    Name:                  ingress-service
    UID:                   6ce19bd4-d2f3-498f-bb63-853f5542686b
  Resource Version:        1600503
  UID:                     24bac32f-a5b7-477f-b3a0-e312eb6b938c
Spec:
  Acme:
    Config:
      Domains:
        my.domain.com
      http01:
        Ingress Class:  nginx
  Dns Names:
    my.domain.com
  Issuer Ref:
    Kind:       ClusterIssuer
    Name:       letsencrypt-prod
  Secret Name:  my-service-cert
Status:
  Conditions:
    Last Transition Time:  2021-01-28T19:18:50Z
    Message:               Certificate issuance in progress. Temporary certificate issued.
    Reason:                TemporaryCertificate
    Status:                False
    Type:                  Ready
Events:                    <none>

Name:         letsencrypt-prod
Namespace:
Labels:       <none>
Annotations:  <none>
API Version:  certmanager.k8s.io/v1alpha1
Kind:         ClusterIssuer
Metadata:
  Creation Timestamp:  2021-01-28T18:26:57Z
  Generation:          2
  Resource Version:    1585021
  UID:                 ec84efb6-17b3-4d4b-b439-737bf1b8070e
Spec:
  Acme:
    Email<EMAIL_ADDRESS>    http01:
    Private Key Secret Ref:
      Name:  letsencrypt-prod
    Server:  https://acme-v02.api.letsencrypt.org/directory
Status:
  Acme:
    Last Registered Email<EMAIL_ADDRESS>    Uri:                    https://acme-v02.api.letsencrypt.org/acme/acct/111029141
  Conditions:
    Last Transition Time:  2021-01-28T18:28:01Z
    Message:               The ACME account was registered with the ACME server
    Reason:                ACMEAccountRegistered
    Status:                True
    Type:                  Ready
Events:                    <none>

My ingress config looks like this:
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: ingress-service
  annotations:
    nginx.ingress.kubernetes.io/rewrite-target: /$1
    kubernetes.io/ingress.class: "nginx"
    certmanager.k8s.io/cluster-issuer: "letsencrypt-prod"
spec:
  tls:
  - hosts:
    - my.domain.com
    secretName: my-service-cert
  rules:
  - host: my.domain.com
    http:
      paths:
      - path: /?(.*)
        backend:
          serviceName: frontend-cluster-ip-service
          servicePort: 3000
      - path: /(api\/.*|swagger\/.*)
        backend:
          serviceName: server-cluster-ip-service
          servicePort: 5000

I replaced all sensitive info with placeholders.

I'm having the same problem.
I recently upgraded to Kubernetes: 1.20.2, and I think this is when the issuing stopped working.
My guess is this is related to: https://github.com/kubernetes/enhancements/issues/1164
If you have access to the kube-apiserver, you might try this:
https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner/issues/25#issuecomment-742616668

Is there anything new?

I got the resourceVersion problem as well. I was using the version 0.10 installed by gitlab managed apps, and I decided to uninstall it and install the version 1.2.0 manually (in fact, following the upgrade steps from 0.10 til 1.2.0). After that, I got everything working.
I'm using Kubernetes 1.20.2 on a bare metal server, with the latest version of Gitlab (partially) managing the cluster.

Ahhhh thank you @mermetbt that explains it.

@AstraLuma You could wipe everything and get new certs. I was trying to avoid the cert-manager to contact the API of letsencrypt again because for some of the domains I've been blocked for 7 days.

I was using the version 0.10 installed by gitlab

Same thing here. I forgot to check what versions gitlab supports, and apparently 1.20 is not yet supported.
https://docs.gitlab.com/ee/user/project/clusters/

Any update on this? cert-manager has the same issue on Kubernetes 1.20.4

Hi,
Having the exact same issue, certmanager v0.10.0 and k8s v1.20.4. For those of you who destroy certmanager v0.10.0 in order to fresh install v1.3.x, did you also delete the ssl secrets in the different namespaces ?
Or just deleting certmanager resources (crds, deploy, r, rb, sa, etc) was enough ?
I mean, I have enough room to re-issue all my certs for all my clusters, and indeed it would be a quicker/easier path than going through all the upgrade guides :)

Hi,
I was able to reproduce the issue using cert-manager v0.10.0 along with Kubernetes 1.20.4 and Kubernetes 1.21.0. This issue most probably comes from the fact that cert-manager v0.10.0 uses an old client (Kubernetes 1.15.1), which seems not to be compatible with Kubernetes 1.20 and above. The same issue was also reported on ServerFault.
cert-manager v0.11.0 does not have this issue probably due to the fact that it relies on the client for Kubernetes 1.16.
Please keep in mind that v0.10.0 and v0.11.0 are more than two years old and are now unsupported. Please try to plan an upgrade as soon as you can.
As a side note, the client incompatibility manifests itself in the following error message:
selfLink was empty, can't make reference

which is a symptom of the selfLink removal in Kubernetes 1.20.
The second error message is still unclear to me:
resourceVersion should not be set on objects to be created

It probably is also caused by the old client Kubernetes 1.15.

My cert-manager is still in v0.10.0. My K8s cluster version is 1.20.9-gke.1001. In the official upgrade page on cert-manager, it just says upgrade only one version. This means I have to do a lot of manual work to bring my cert-manager to the latest version, which is v1.5.3. Is there a way that I can jump from v0.10.0to v1.5.3?

I was in this exact situation : cert-manager v0.9.1 stops renewing / creating SSL certificates after the upgrade of our cluster from Kubernetes 1.19 to 1.20. I managed to uninstall cert-manager and install last version quite smoothly and wrote an article about it if that can help someone reading this GitHub issue thread : https://dev.to/lboix/upgrade-cert-manager-from-old-version-v010-to-v161-1i8f
If you have any question about the process, do not hesitate!
Regards


feat: updating reactor guides to use the new react endpoint

Description

Updating the guides that use reactors to use the new react endpoint

Testing required outside of automated testing?

[x] Not Applicable

Screenshots (if appropriate):

[x] Not Applicable

Rollback / Rollforward Procedure

[x] Roll Forward
[ ] Roll Back

Reviewer Checklist

[ ] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.9.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix aspnetcore/security/authorization/secure-data/samples/final6/Pages/Contacts/Index.cshtml

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b66f8ffa-699c-8b11-0cab-805f5953805f
Version Independent ID: 7c151ed5-fd78-84fd-a08a-88912990c4ca
Content: Create an ASP.NET Core app with user data protected by authorization
Content Source: aspnetcore/security/authorization/secure-data.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Associated WorkItem - 64164

See  https://github.com/dotnet/AspNetCore.Docs/pull/28399, it's unnecessary.


feat(dart): add get access token by refresh token method

Summary

Add get access token by refresh token method

get Access token from the storage by resource
if no access token is found, claim a new access token by calling the getAccessTokenByRefreshToken request
Add a promise cache to avoid the racing condition of getAccessToken request
Fix token storage bug. For all async storage updates, should update the local/inMemory cache value after a successful update of persistent storage
Fix token storage bug.  Set new access token should load from the persistent storage if local/inMemory cache value is null

Testing

test locally
@logto-io/mandatory-reviewers @logto-io/eng  cc: @julian-hartl

Hey, first of all, I really want to thank you :) I really needed this feature.
I just tested this and got the following error: {error: invalid_grant, error_description: grant request is invalid}. Do you know why that could be?


v0.8.0

Update for version 0.8.0. Below are listed the planned additions

[ ] Update how the weights argument works in applicable causal models (IPTW, AIPW, g-formula)

Inverse Probability of Treatment Weights

[ ] Changing entire structure #102

[ ] Figure out why new structure is giving slightly different values for positivity calculations...

[ ] Add g-bounds option to truncate weights

[ ] Update tests for new structure

[ ] Weight argument behaves slightly different (diagnostics now available for either IPTW alone or with other weights)

[ ] New summary function for results

[ ] Allowing for continuous treatments in estimation of MSM

[ ] Plots available for binary or continuous treatments

Inverse Probability of Censoring Weights

[ ] Correction for pooled logistic weight calculation with late-entry occurring

G-formula

[ ] Add diagnostics (prediction accuracy of model)

Augmented IPTW

[ ] Add g-bounds

[ ] Add diagnostics for weights and outcome model

TMLE

[ ] New warning when using machine learning algorithms to estimate nuisance functions #109

[ ] Add diagnostics for weights and outcome model

S-value

[ ] Add calculator for S-values, a (potentially) more informative measure than p-values #107

Positivity values change because the new setup is dropping the y==np.nan observations which is a different behavior. As long as the treatment and covariates predicting treatment are not missing, then the weight should not be missing. This will change when paired with other weights

I am changing IPTW back to not dropping missing outcome data (I switched it in the past few pushes). TMLE does not do this (neither does TimeFixedGFormula). The missing outcome data (censored) should only be dropped from the and fit() procedures. All other missing data (missing treatment A or missing confounders C) will be dropped in the init
I will also update AIPTW to mimic this behavior. This seems to be the standard practice (so far as I can find). It also makes the integration with censoring weights for Y easier for users

Related to the prior comment, I am going to update how missing outcome data is handled across estimators. Like TMLE, AIPTW and IPTW will gain a new function (missing_model()) to generate IPM(C)W to account for missing outcome data.
The advantage of this approach is (1) better alignment of estimator functions, (2) doesn't require user to bring in separately estimated weights, (3) does not require the weights argument change as discussed in #106 and above
For time-varying estimators, I should do something similar. MonteCarloGFormula already has this feature and IterativeCondGFormula implicitly does this (it is a feature of the estimator, much like TimeFixedGFormula). Will need to be added to LTMLE, LongitudinalIPTW, and SurvivalIPTW when implemented

Does g-estimation require the addition of missing_model()? I don't think it does...

Next step is to run through all of the zEpid tutorials and update them before the release. I will likely try to get through them tomorrow and make 0.8.0 available tomorrow


Bug: heart's do not respond to clicks after ajax call to search within reviews

Fixed: 3e6f1bd64780163a45bd4bc7e490d5fb6030c04b
solved by calling the heart event handler when the document is loaded, AND after each ajax call that creates new hearts


Add phrase to FCS_CKM_EXT.7.1 App Note 5

In Para 3, suggest adding "and there are two parties" to the parenthetical so it reads "(e.g., if each share is 128 bits and there are two parties, then the result after concatenation is a 256-bit key, which is appropriate only for AES-256-CMAC)"
In Para 4, suggest changing “For the KDF functions and XOR, each party may have to use an asymmetric method from FCS_CKM_EXT.7 to transmit their shares to each other” to “For the KDF functions and XOR, each party must transmit their shares securely, either by encrypting with an asymmetric method from FCS_CKM_EXT.7 or by procedural means, such as sending them by courier.”

Brian,
I think I made a pull request for #239.  I’m still a little unsure of all the github terms and operators.
-Dave
From: Brian Wood @.>
Sent: Thursday, February 15, 2024 1:36 PM
To: DSC-iTC/cPP @.>
Cc: J David D Thompson @.>; Assign @.>
Subject: Re: [DSC-iTC/cPP] Add phrase to FCS_CKM_EXT.7.1 App Note 5 (Issue #239)
Assigned #239https://github.com/DSC-iTC/cPP/issues/239 to @JDavid-Thompsonhttps://github.com/JDavid-Thompson.
—
Reply to this email directly, view it on GitHubhttps://github.com/DSC-iTC/cPP/issues/239#event-11819345963, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BFSTVCI2S3EISA73ST7PQ7LYTZIRNAVCNFSM6AAAAABDE5RASSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRHAYTSMZUGU4TMMY.
You are receiving this because you were assigned.Message ID: @.***>

I saw it
On Thu, Feb 15, 2024 at 3:02 PM JDavid-Thompson @.***>
wrote:

Brian,
I think I made a pull request for #239. I’m still a little unsure of all
the github terms and operators.
-Dave
From: Brian Wood @.>
Sent: Thursday, February 15, 2024 1:36 PM
To: DSC-iTC/cPP @.>
Cc: J David D Thompson @.>; Assign @.>
Subject: Re: [DSC-iTC/cPP] Add phrase to FCS_CKM_EXT.7.1 App Note 5 (Issue
#239)
Assigned #239https://github.com/DSC-iTC/cPP/issues/239 to
@JDavid-Thompsonhttps://github.com/JDavid-Thompson.
—
Reply to this email directly, view it on GitHub<
https://github.com/DSC-iTC/cPP/issues/239#event-11819345963>, or
unsubscribe<
https://github.com/notifications/unsubscribe-auth/BFSTVCI2S3EISA73ST7PQ7LYTZIRNAVCNFSM6AAAAABDE5RASSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRHAYTSMZUGU4TMMY>.
You are receiving this because you were assigned.Message ID: @.***>
—
Reply to this email directly, view it on GitHub
https://github.com/DSC-iTC/cPP/issues/239#issuecomment-1947196705, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AEVLEAPZ3O3FSPYNL4C7PGTYTZSVPAVCNFSM6AAAAABDE5RASSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBXGE4TMNZQGU
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

@woodbe will review the current crypto catalog and provide a response here (or a PR)

The second proposed change has been already updated (differently) in the catalog, and that text actually makes more sense.


BUG: attribute 'map' missing

https://github.com/nix-community/nixvim/blob/c892aa20732f982d4cc2b3ef2e2276a2a9a4d45b/plugins/lsp/language-servers/default.nix#L184
This line errors for me on main with unstable nixpkgs.

Okay, the issue here was that my nixvim flake input followed the unstable channel, but the nixvimModule got the stable channel passed as pkgs.
Maybe there should be a check for this?

Maybe there should be a check for this?

I can rename this issue to something like "assert that the expected nixpkgs release/channel is used"?


Changes lost in merges from b93e6dd - Merge pull request #244 from jimzucker/collectors (11 days ago) jdamick

If found we have lost changes in the merges to master after b93e6dd.
git diff --summary b93e6dd..HEAD

Can you review how to correct master, I think the merges after this one have to be rolled back and redone.

Let me check.

Looks like this one was the bad one:
https://github.com/capitalone/Hygieia/pull/293

@jimzucker can you verify if I revert #293 if your changes are back? I think they are. Wanted a second eye.

Yes this is it:

4bf717f - (HEAD -> master, upstream/master, origin/master, origin/HEAD) Merge pull request #293 from amp5208/master (6 days ago) Tapabrata "Topo" Pal
|
| *   b497082 - Merge remote-tracking branch 'upstream/master' (7 days ago) amp5208

it is actually b497082 that deleted the files..

Done. Can you check?

I just did a diff against my feature branch and looks OK, the diff is what I expect the files I changed. FYI  I am going to rebase and submit a pull request to put my changes back.  I have created containers for more of the collectors and also fixed up the pom files so we can do a man docker:build from the root and also fixed sonar so  svn sonar:sonar works correctly.
➜  Hygieia git:(mergecollector) ✗ git diff --name-status HEAD..upstream/master
[cid:E786C1E4-B76D-402D-A214-2AC69D43C898]
On Feb 9, 2016, at 6:09 AM, tabladrum <notifications<EMAIL_ADDRESS>wrote:
Done. Can you check?
—
Reply to this email directly or view it on GitHubhttps://github.com/capitalone/Hygieia/issues/315#issuecomment-181878534.

Looks OK now.


Why don't you use bias in convolution?

Hi there! I can't find any bias used in your code, but bias=False. Could you please tell me why? Thanks

Usually when BN is used, bias in conv is set to be False, because there is bias in bn(scale).

Got It, Thank you!


Sidebar Panel Buttons way too spaced after update

Feature Description
Hey its not rly a feature request or a bug, but since a new update the buttons on the sidebar panel are way too spaced and dont even all fit on the window anymore and you have to scroll to see them all
They look nicer now and more mordern, but would it be possible to be able to customize how far they are apart?
Thanks in advance
Screenshots

I understand your point of view but it's a difficult situation because some people may like a change and others wouldn't. In my experience it's not possible for everyone to globally like something so in those situations, in my opinion it's better to modify your local installation to your liking, I hope it's understandable.
In this case you can change the number 15 in the line here to to whatever value works for you: https://github.com/darklinkpower/Harmony/blob/6b8496308cf4028059bb023cfc2623cc98e6acea/source/CustomControls/SidebarItem.xaml#L13
I hope this helps, and feel free to reach out if you have any other questions.

Hey no worries I understand
Thats why I put it more in feature request to maybe make it adjustable with theme modifier or smth else
Thanks for the reply and I will just edit the code then :)
great theme btw, thanks for all your work on it

Closing under


buck android app failed

Report

[ ] I have searched existing issues and this is not a duplicate

Issues and Steps to Reproduce
Replaces this with steps to repro your issue.
chenjianpingdeMacBook-Pro:android chenjianping$ pwd
/Users/chenjianping/Downloads/yoga-master/android
chenjianpingdeMacBook-Pro:android chenjianping$ buck install -r android/sample
WARNING: Output when parsing /Users/chenjianping/Downloads/yoga-master/android/sample/BUCK:
| Traceback (most recent call last):
|   File "/Users/chenjianping/Downloads/yoga-master/.buckd/tmp/buck_run.ltmaIl/buck_python_program8907044429899559464/main.py", line 10, in
|     from buck_parser import buck
|   File "/Users/chenjianping/Downloads/yoga-master/.buckd/resources/2<IP_ADDRESS>/buck_server/buck_parser/buck.py", line 3, in
| ModuleNotFoundError: No module named 'builtin'
Buck wasn't able to parse /Users/chenjianping/Downloads/yoga-master/android/sample/BUCK:
No content to map due to end-of-input
at [Source: com.google.common.io.CountingInputStream@65170769; line: 1, column: 0]
chenjianpingdeMacBook-Pro:android chenjianping$
Expected Behavior
Describe what you expected would happen.
Actual Behavior
Describe what actually happened.
Link to Code
If you have some code that maintainers can clone/test for themselves, bugs can be resolved much faster. Please paste a link here.
When applicable, use this fiddle to post a web repro.

https://github.com/facebook/yoga/pull/1166 removed Buck logic in general. It has not been exercised in OSS, and we should be indexing on the existing Gradle/CMake logic. There is a followup here though, to update the sample to use Gradle.


[AAP-7661] Support inventory in ini/yaml formats

ansible-rulebook doesn't do anything with the inventory data. It just reads it and writes into the inventory file for ansible_runner. So instead of treating every inventory as a yaml file and load it as a dictionary, this PR just loads the inventory data as a blob irrespective of the format and sends it to ansible-runner.
Fixes #241
Closes: https://issues.redhat.com/browse/AAP-7661

@Alex-Izquierdo Another issue we need to handle is that there can be multiple inventory files like ansible-playbook in that case we can't load the data at all, we would have to keep the inventory file names as is and then add them into the ansible-runner inventory folder. So some of these debug test which are based on data would have to change to use file names.

@Alex-Izquierdo @ttuffin Please review keep both the INI file and yaml file for e2e tests

@Alex-Izquierdo Another issue we need to handle is that there can be multiple inventory files like ansible-playbook in that case we can't load the data at all, we would have to keep the inventory file names as is and then add them into the ansible-runner inventory folder. So some of these debug test which are based on data would have to change to use file names.

Agree. I think we need some logic to be able to load a folder instead of a file, this is true also for dynamic inventories.


No Documentation

Hi, can we add a documentation for OpenFace? The only documentation provided does not really explain the code or the structure for the api. It becomes quite hard to be able to use it.
Thanks.

Hi @Mikebarson - sure, I'd be happy to merge in improvements to our documentation.
-Brandon.


Disable column translating

@schneidermichal Great idea, can you provide some tests please?

@paveljanda I'll try it ;-)

@paveljanda Unfortunately, I don't know how to test column header rendering...

@schneidermichal Just one last thing: it is all about column header localization, co can you name the methods and properties more like setTranslatableHeader() and $translatable_header?

Perfect, thanks!


Instruction to ensure performance governor is used

Ubuntu has an ondemand.service that sets the cpu governor to ondemand post boot. This needs to be disabled via systemctl disable ondemand.
ubuntu@ubuntu:/etc/default$ uname -a
Linux ubuntu 5.4.128-rt61 #1 SMP PREEMPT_RT Sat Sep 4 15:19:34 UTC 2021 aarch64 aarch64 aarch64 GNU/Linux
ubuntu@ubuntu:/etc/default$ cat /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor
ondemand
ondemand
ondemand
ondemand
ubuntu@ubuntu:/etc/default$ sudo systemctl status ondemand
● ondemand.service - Set the CPU Frequency Scaling governor
     Loaded: loaded (/lib/systemd/system/ondemand.service; enabled; vendor preset: enabled)
     Active: inactive (dead) since Sat 2021-09-04 15:46:10 UTC; 2min 17s ago
    Process: 1680 ExecStart=/lib/systemd/set-cpufreq (code=exited, status=0/SUCCESS)
   Main PID: 1680 (code=exited, status=0/SUCCESS)

Sep 04 15:46:05 ubuntu systemd[1]: Started Set the CPU Frequency Scaling governor.
Sep 04 15:46:10 ubuntu set-cpufreq[1680]: Setting ondemand scheduler for all CPUs
Sep 04 15:46:10 ubuntu systemd[1]: ondemand.service: Succeeded.
ubuntu@ubuntu:/etc/default$

@shuhaowu thanks for providing this PR. We need to discuss whether there will be a separate project for the system real-time configuration or we shall put such information here.

There are also a number of other settings generally set, like isolcpus and /etc/security/limits.conf.

I'm also working on scripts to tune/prepare real-time systems (in my case for performance benchmarks). Having a standard/common/recommended set of scripts/tools would definitely be a good thing for the community.
We could host this in another repo. Then we could combine that with an OS image with the RT kernel from this repo and possibly ROS 2 packages.

@shuhaowu You can check the ROS event calendars here<EMAIL_ADDRESS>The next one is next Tuesday.

I've updated my image builder to install ROS2 and ROS galactic with some documentations: https://github.com/shuhaowu/ros-realtime-rpi4-image. The scripts there can build a flashable .img file and it even runs on CI (although my CI doesn't actually post a downloadable file as the resulting file is too big).
I'm happy to contribute this upstream if the working group is OK with it. I've used the same system to build images for a robot for the raspberry Pi, albeit no longer in production as that robot moved passed a raspberry pi into an x86 box. I can try to attend next WG meeting to talk a bit more about this as well.


[AIFlow]Fix register_model_version sending wrong event type bug.

What is the purpose of the change
[AIFlow]Fix register_model_version sending wrong event type bug.

Codecov Report

Merging #290 (7a9222a) into master (e932701) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
+ Coverage   66.80%   66.81%   +0.01%
==========================================
  Files         206      206
  Lines       15573    15573
  Branches     2337     2337
==========================================
+ Hits        10403    10405       +2
+ Misses       4602     4601       -1
+ Partials      568      567       -1

Impacted Files
Coverage Δ

ai_flow/endpoint/client/metadata_client.py
94.36% <100.00%> (ø)

ai_flow/store/sqlalchemy_store.py
75.39% <0.00%> (+0.18%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e932701...7a9222a. Read the comment docs.


Support SNS batch publishing

Add support for batch publishing messages to SNS.
Supersedes #1098.
TODO

[x] Review original feedback from #1098 and address.
[x] Check test coverage.
[x] Rebase on #1330 and add updated baselines.
[x] Update version to 7.2.0.

This should be ready to test at your convenience now @hwoodiwiss.

@slang25 Do we want to make this part of 8? If so, I'll update the version number again before merging.

Do we still want to bump the major version for this, or do we want to have this as the last big thing for v7, as it should be backwards-compatible.

A big part of me wants to put this in to a V8. The compression work is almost done.

@slang25 What do you want to do with this PR? Is it ready to merge, or does it need to wait on something else?

Unless there's any objections in the next 24 hours, I'm going to merge this tomorrow and it'll just sit in main until whenever we do another release.


Don't use constant reference in Vector push_back, insert and append_array

Fixes #31159 and similar
Test project - Line.zip - To see errors Valgrind or Address Sanitizer should be used
Reduz explanation from https://github.com/godotengine/godot/pull/31609#issuecomment-565617751

Sorry, this should have been fixed long ago, we even discussed it at the beginning of the year.
I suggest just make a PR that changes this:
bool Vector<T>::push_back(const T &p_elem)
to this
bool Vector<T>::push_back(T p_elem)

It should be fine performance wise, the rational is that in far most cases (Specially where performance is required), Godot uses types that are 8 bytes or less, which is just the same as a pointer. This is fast because it will fit on a CPU register or cache. For larger datatypes, this is not really something critically performant anyway because a good amount of bytes has to be copied or a copy constructor needs to be run, so it should not matter much if it does a copy.

I changed file editor/import/editor_scene_importer_gltf.h because travis complains about unitialized variable
./core/cowdata.h:140:3: error: 'accessor.EditorSceneImporterGLTF::GLTFAccessor::sparse_indices_buffer_view' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Both @hpvb and @reduz say that it seems fine as a short term fix for 3.2, unless Vector can be further refactored to avoid this issue altogether.

Thanks!


FR: pull from external config

As a developer, I would like to have a single, centralized configuration for all projects in my GH org that are using release-please as a GitHub action. There should also be an option to extend this configuration on a per-repo basis, in case certain adjustments need to be made.
Renovate has a good example of how this is implemented in its service. Ideally, I could use an extends field in my release-please-config.json:
{
  "extends": "MyOrgName/.github",
  "packages": { ".": {} },
  "release-type": "node"
}

this would merge the individual repo's configuration with the configuration found in my organization's .github repo, overwriting the parent's configuration with the child's values.

This sounds like a reasonable feature, but not something we have time to prioritize. Note that there are considerations  around permissions which could make this more complex.

@chingor13,
I'd like to try. Could you help me with that?


Wrong time

Whenever i use this mod on the server Bedwarspractice.club; the time is wrong since i think they have a customized fuse time. So could the mod be changed to use The fuze time for the time instead of having a normal

I'm going to look into it


Add optional hardware validations

With this patch, if a scenario file defines the
cifmw_reproducer_minimum_hardware_requirements dict, we can set the minimum hardware requirements for vcpu, memory and disk ensuring the hypervisor meets the scenarios minimum.
As a pull request owner and reviewers, I checked that:

[x] Appropriate testing is done and actually running
[x] Appropriate documentation exists and/or is up-to-date:

/approve


extras/discord: auto-update breaks scoop

Brief
Actual Behaviour
Discord's auto-update breaks scoop's app manifest and causes scoop to report that Discord failed to install. This occurs even on a clean install (with cache emptied and older versions removed).
Expected Behaviour
scoop reports no issues with the Discord app, before and after any updates.
Steps to Reproduce

scoop install discord (this should complete successfully).
Start Discord, and let it update itself to the latest version.
scoop status (should report errors with Discord).

Logs (after Discord updates)
scoop info discord outputs:
Name: discord
Description: Free Voice and Text Chat
Version: 0.0.309
Website: https://discordapp.com/
License: Freeware (https://discordapp.com/terms)
Manifest:
  C:\Users\willi\scoop\buckets\extras\bucket\discord.json
Installed: No
Binaries:
  Discord.exe

scoop status outputs:
Scoop is up to date.
These app manifests have been removed:
    discord
These apps failed to install:
    discord

Discord app reports:
Stable 84785 (fe5e237)
Host 1.0.9001
Windows 10 64-Bit (10.0.19042)

Comments
Not sure if this is something that can be fixed without reworking some of scoop's internal workings, but I thought I may as well submit an issue about it.

try reinstalling discord in Global Mode

for me i have an error with extracting the files
$ scoop install discord
WARN  Scoop uses 'aria2c' for multi-connection downloads.
WARN  Should it cause issues, run 'scoop config aria2-enabled false' to disable it.
Installing 'discord' (0.0.310) [64bit]
Loading Discord-0.0.310-full.nupkg from cache.
Checking hash of Discord-0.0.310-full.nupkg ... ok.
Extracting Discord-0.0.310-full.nupkg ... ERROR Exception calling "Start" with "0" argument(s): "The directory name is invalid"
Failed to extract files from C:\Users\*****\scoop\apps\discord\0.0.310\Discord-0.0.310-full.nupkg.
Log file:
  ~\scoop\apps\discord\0.0.310\7zip.log

there's probably a problem with the JSON file

Discord installs fine for me but I experience the same auto-update issue where Scoop reports the app manifests removed and failed installation.
For Discord 0.0.310, the auto-update creates a scoop\apps\discord\app-1.0.9002 directory alongside the scoop\apps\discord\0.0.310 directory. The current symlink still points to the 0.0.310 directory.


Factory Installers - Bug/ Improvement

When using the factory installers, the config settings do not save. Pretty annoying, hope you can change it :)
EDIT: Also all connections disconnect, including power
Thanks

Alice

This is fixed in v8.1 :)


Flutter run Error Throws

Flutter crash report; please file at https://github.com/flutter/flutter/issues.
command
flutter run
exception
ProcessException: ProcessException: Process "/Users/Mac/Dev/apps/android/gradlew" exited abnormally:
Unzipping /Users/Mac/.gradle/wrapper/dists/gradle-4.10.2-all/9fahxiiecdb76a5g3aw9oi8rv/gradle-4.10.2-all.zip to /Users/Mac/.gradle/wrapper/dists/gradle-4.10.2-all/9fahxiiecdb76a5g3aw9oi8rv
Exception in thread "main" java.util.zip.ZipException: error in opening zip file
at java.util.zip.ZipFile.open(Native Method)
at java.util.zip.ZipFile.(ZipFile.java:219)
at java.util.zip.ZipFile.(ZipFile.java:149)
at java.util.zip.ZipFile.(ZipFile.java:163)
at org.gradle.wrapper.Install.unzip(Install.java:214)
at org.gradle.wrapper.Install.access$600(Install.java:27)
at org.gradle.wrapper.Install$1.call(Install.java:74)
at org.gradle.wrapper.Install$1.call(Install.java:48)
at org.gradle.wrapper.ExclusiveFileAccessManager.access(ExclusiveFileAccessManager.java:65)
at org.gradle.wrapper.Install.createDist(Install.java:48)
at org.gradle.wrapper.WrapperExecutor.execute(WrapperExecutor.java:128)
at org.gradle.wrapper.GradleWrapperMain.main(GradleWrapperMain.java:61)
Command: /Users/Mac/Dev/apps/android/gradlew -v
#0      runCheckedAsync (package:flutter_tools/src/base/process.dart:255:5)
<asynchronous suspension>
#1      _initializeGradle (package:flutter_tools/src/android/gradle.dart:225:9)
<asynchronous suspension>
#2      _ensureGradle (package:flutter_tools/src/android/gradle.dart:206:37)
<asynchronous suspension>
#3      _readGradleProject (package:flutter_tools/src/android/gradle.dart:134:31)
<asynchronous suspension>
#4      _gradleProject (package:flutter_tools/src/android/gradle.dart:111:34)
<asynchronous suspension>
#5      getGradleAppOut (package:flutter_tools/src/android/gradle.dart:105:29)
<asynchronous suspension>
#6      AndroidApk.fromAndroidProject (package:flutter_tools/src/application_package.dart:154:23)
<asynchronous suspension>
#7      ApplicationPackageFactory.getPackageForPlatform (package:flutter_tools/src/application_package.dart:46:32)
<asynchronous suspension>
#8      FlutterDevice.runHot (package:flutter_tools/src/resident_runner.dart:345:56)
<asynchronous suspension>
#9      HotRunner.run (package:flutter_tools/src/run_hot.dart:253:39)
<asynchronous suspension>
#10     RunCommand.runCommand (package:flutter_tools/src/commands/run.dart:428:37)
<asynchronous suspension>
#11     FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:559:18)
#12     _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:77:64)
#13     _rootRunUnary (dart:async/zone.dart:1132:38)
#14     _CustomZone.runUnary (dart:async/zone.dart:1029:19)
#15     _FutureListener.handleValue (dart:async/future_impl.dart:126:18)
#16     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:639:45)
#17     Future._propagateToListeners (dart:async/future_impl.dart:668:32)
#18     Future._complete (dart:async/future_impl.dart:473:7)
#19     _SyncCompleter.complete (dart:async/future_impl.dart:51:12)
#20     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:28:18)
#21     _completeOnAsyncReturn (dart:async-patch/async_patch.dart:294:13)
#22     RunCommand.usageValues (package:flutter_tools/src/commands/run.dart)
#23     _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:77:64)
#24     _rootRunUnary (dart:async/zone.dart:1132:38)
#25     _CustomZone.runUnary (dart:async/zone.dart:1029:19)
#26     _FutureListener.handleValue (dart:async/future_impl.dart:126:18)
#27     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:639:45)
#28     Future._propagateToListeners (dart:async/future_impl.dart:668:32)
#29     Future._complete (dart:async/future_impl.dart:473:7)
#30     _SyncCompleter.complete (dart:async/future_impl.dart:51:12)
#31     _AsyncAwaitCompleter.complete.<anonymous closure> (dart:async-patch/async_patch.dart:33:20)
#32     _rootRun (dart:async/zone.dart:1124:13)
#33     _CustomZone.run (dart:async/zone.dart:1021:19)
#34     _CustomZone.bindCallback.<anonymous closure> (dart:async/zone.dart:947:23)
#35     _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#36     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
#37     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:115:13)
#38     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:172:5)

flutter doctor
[✓] Flutter (Channel stable, v1.5.4-hotfix.2, on Mac OS X 10.13.6 17G3025,
    locale en-IN)
    • Flutter version 1.5.4-hotfix.2 at /Users/Mac/development/flutter
    • Framework revision 7a4c33425d (8 weeks ago), 2019-04-29 11:05:24 -0700
    • Engine revision 52c7a1e849
    • Dart version 2.3.0 (build 2.3.0-dev.0.5 a1668566e5)

[!] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/Mac/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling
      support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_152-release-1136-b06)
    ✗ Android licenses not accepted.  To resolve this, run: flutter doctor
      --android-licenses

[✗] iOS toolchain - develop for iOS devices
    ✗ Xcode installation is incomplete; a full installation is necessary for iOS
      development.
      Download at: https://developer.apple.com/xcode/download/
      Or install Xcode via the App Store.
      Once installed, run:
        sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer
    ✗ libimobiledevice and ideviceinstaller are not installed. To install with
      Brew, run:
        brew update
        brew install --HEAD usbmuxd
        brew link usbmuxd
        brew install --HEAD libimobiledevice
        brew install ideviceinstaller
    ✗ ios-deploy not installed. To install:
        brew install ios-deploy
    ✗ CocoaPods not installed.
        CocoaPods is used to retrieve the iOS platform side's plugin code that
        responds to your plugin usage on the Dart side.
        Without resolving iOS dependencies with CocoaPods, plugins will not work
        on iOS.
        For more info, see https://flutter.dev/platform-plugins
      To install:
        brew install cocoapods
        pod setup

[✓] Android Studio (version 3.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 29.0.2
    • Dart plugin version 181.5540.11
    • Java version OpenJDK Runtime Environment (build
      1.8.0_152-release-1136-b06)

[✓] VS Code (version 1.34.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 2.24.0

[✓] Connected device (1 available)
    • Custom Phone, 5 1 0, API 22, 768x1280 • <IP_ADDRESS>:5555 • android-x86
      • Android 5.1 (API 22)

! Doctor found issues in 2 categories.

sudo flutter run -v
Password:
Woah! You appear to be trying to run flutter as root.
We strongly recommend running the flutter tool without superuser privileges.
/
📎
[  +85 ms] executing: [/Users/Mac/development/flutter/] git log -n 1
--pretty=format:%H
[ +107 ms] Exit code 0 from: git log -n 1 --pretty=format:%H
[   +2 ms] 7a4c33425ddd78c54aba07d86f3f9a4a0051769b
[        ] executing: [/Users/Mac/development/flutter/] git describe --match
v*.. --first-parent --long --tags
[  +15 ms] Exit code 0 from: git describe --match v*.. --first-parent --long
--tags
[   +3 ms] v1.5.4-hotfix.2-0-g7a4c33425
[  +49 ms] executing: [/Users/Mac/development/flutter/] git rev-parse
--abbrev-ref --symbolic @{u}
[  +13 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] origin/stable
[        ] executing: [/Users/Mac/development/flutter/] git ls-remote --get-url
origin
[  +10 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/flutter/flutter.git
[  +95 ms] executing: [/Users/Mac/development/flutter/] git rev-parse
--abbrev-ref HEAD
[  +12 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] stable
[ +249 ms] executing: /Users/Mac/Library/Android/sdk/platform-tools/adb devices
-l
[  +14 ms] Exit code 0 from: /Users/Mac/Library/Android/sdk/platform-tools/adb
devices -l
[   +1 ms] List of devices attached
<IP_ADDRESS>:5555    device product:vbox86p
model:Custom_Phone___5_1_0___API_22___768x1280 device:vbox86p
transport_id:1
[  +16 ms] executing: idevice_id -h
[  +35 ms] /Users/Mac/Library/Android/sdk/platform-tools/adb -s
<IP_ADDRESS>:5555 shell getprop
[  +99 ms] Artifact Instance of 'FlutterWebSdk' is not required, skipping
update.
[   +6 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required,
skipping update.
[   +2 ms] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping
update.
[   +2 ms] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping
update.
[   +1 ms] Artifact Instance of 'FuchsiaCacheArtifacts' is not required,
skipping update.
[ +409 ms] ro.hardware = vbox86
[        ] ro.build.characteristics = default
[  +63 ms] Launching lib/main.dart on Custom Phone, 5 1 0, API 22, 768x1280 in
debug
mode...
[  +27 ms] Initializing gradle...
[   +9 ms] Using gradle from /Users/Mac/Dev/apps/android/gradlew.
[+2398 ms] executing: /usr/bin/defaults read /Applications/Android
Studio.app/Contents/Info
[  +34 ms] Exit code 0 from: /usr/bin/defaults read /Applications/Android
Studio.app/Contents/Info
[   +1 ms] {
CFBundleDevelopmentRegion = English;
CFBundleDocumentTypes =     (
{
CFBundleTypeExtensions =             (
ipr
);
CFBundleTypeIconFile = "AndroidStudio.icns";
CFBundleTypeName = "Android Studio Project File";
CFBundleTypeRole = Editor;
},
{
CFBundleTypeExtensions =             (
""
);
CFBundleTypeName = "All documents";
CFBundleTypeOSTypes =             (
"**"
);
CFBundleTypeRole = Editor;
LSTypeIsPackage = 0;
}
);
CFBundleExecutable = studio;
CFBundleGetInfoString = "Android Studio 3.2, build
AI-181.55<IP_ADDRESS>14246. Copyright JetBrains s.r.o., (c)
2000-2018";
CFBundleIconFile = "AndroidStudio.icns";
CFBundleIdentifier = "com.google.android.studio";
CFBundleInfoDictionaryVersion = "6.0";
CFBundleName = "Android Studio";
CFBundlePackageType = APPL;
CFBundleShortVersionString = "3.2";
CFBundleSignature = "????";
CFBundleURLTypes =     (
{
CFBundleTypeRole = Editor;
CFBundleURLName = Stacktrace;
CFBundleURLSchemes =             (
idea
);
}
);
CFBundleVersion = "AI-181.55<IP_ADDRESS>14246";
JVMOptions =     {
ClassPath =
"$APP_PACKAGE/Contents/lib/bootstrap.jar:$APP_PACKAGE/Content
s/lib/extensions.jar:$APP_PACKAGE/Contents/lib/util.jar:$APP_
PACKAGE/Contents/lib/jdom.jar:$APP_PACKAGE/Contents/lib/log4j
.jar:$APP_PACKAGE/Contents/lib/trove4j.jar:$APP_PACKAGE/Conte
nts/lib/jna.jar";
JVMVersion = "1.8,1.8+";
MainClass = "com.intellij.idea.Main";
Properties =         {
"idea.executable" = studio;
"idea.home.path" = "$APP_PACKAGE/Contents";
"idea.java.redist" = Bundled;
"idea.paths.selector" = "AndroidStudio3.2";
"idea.platform.prefix" = AndroidStudio;
};
WorkingDirectory = "$APP_PACKAGE/Contents/bin";
};
LSApplicationCategoryType =
"public.app-category.developer-tools";
LSArchitecturePriority =     (
"x86_64"
);
LSMinimumSystemVersion = "10.8";
LSRequiresNativeExecution = YES;
NSHighResolutionCapable = 1;
NSSupportsAutomaticGraphicsSwitching = 1;
}
[  +11 ms] executing: /usr/bin/defaults read /Applications/Android
Studio.app/Contents/Info CFBundleShortVersionString
[  +33 ms] Exit code 0 from: /usr/bin/defaults read /Applications/Android
Studio.app/Contents/Info CFBundleShortVersionString
[        ] 3.2
[ +173 ms] executing: /Users/Mac/Dev/apps/android/gradlew -v
[+1530 ms]
------------------------------------------------------------
Gradle 4.10.2
------------------------------------------------------------
                Build time:   2018-09-19 18:10:15 UTC
                Revision:     b4d8d5d170bb4ba516e88d7fe5647e2323d791dd

                Kotlin DSL:   1.0-rc-6
                Kotlin:       1.2.61
                Groovy:       2.4.15
                Ant:          Apache Ant(TM) version 1.9.11 compiled on
                March 23 2018
                JVM:          1.8.0_152-release (JetBrains s.r.o 25.152-b06)
                OS:           Mac OS X 10.13.6 x86_64

[  +12 ms] Initializing gradle... (completed in 4.2s)
[        ] Resolving dependencies...
[        ] executing: [/Users/Mac/Dev/apps/android/]
/Users/Mac/Dev/apps/android/gradlew app:properties

Will track here: https://github.com/flutter/flutter/issues/36282


Add ability to set custom tags

The tags currently added are great and I think they are the basic ones that you'd want to include in pretty much any express app. However, my opentracing tracer (DataDog) has some additional, required custom tags. Sure, I could write an additional middleware to add them but it would be nice if this middleware had the ability to do it.
My initial thought is just adding an tags option, which is an object:
const tags = {
  type: 'web',
  env: 'production'
};
middleware({tracer: tracer, tags })(req, res, next);

Perhaps it should be customTags to differentiate from the built-in tags?
It also might be nice to support a function, in case you want to have request specific tags:
function tags(req) {
  return {
    'http.request_id': req.id
  };
};

Any thoughts on this feature? If you think it's something the project would want to support, I could put together a PR.

That sounds good to me. Perhaps a some kind span decorator function that would allow you to set tags or other attributes. https://github.com/grpc-ecosystem/grpc-opentracing/tree/master/go/otgrpc has something like this: https://godoc.org/github.com/grpc-ecosystem/grpc-opentracing/go/otgrpc#SpanDecorator
I'd be ok with either passing tags in, being able to set them with via a function, or a mix of the approaches.

I'm curious if any progress was made on this, I would also love the ability to add extra tags to our express spans.

+1


Is this supposed to output a war file?

Project has been converted to gradle with the stub provided by gradle-multi-project-example. I noticed a WebContent directory containing various web related files and was wondering what was up and/or what this is?
Also ... take a look at the new structure and let me know what you think.
EDIT: it should be noted that VERY aggressive checking is enabled for the attached static analysis tools and as such this code, as it is now, is in pretty rough shape.

The CI pipeline is currently failing as well.
@cdancy Why is it that we are getting an error tag from Travis-CI on failure? Is that a misconfig on my end? Shouldn't it be a failure tag?

@dcasavant this is a "feature" of travis for better or worse :) Just added a change to the travis file to side-step this feature and get an actual fail.

@cdancy saw that you enabled a few static analysis tools, but they are all failing miserably. I started working through the checkstyle warnings.
https://github.com/feenr/pega-alertanalyzer
Were you able to generate the war file, even if it's not part of the build script yet?
Would you be willing to remove those static analysis tasks from the Travis scripts and track them individually as issues, just so it has a passing build?

Yeah I left these in place so that folks working on this project, whenever they eventually got around to it, would be forced to clean up the code base so that individuals stumbling upon this project on the internets would not think we are churning out un-production level code.
As for removing these checks you can simply comment out the relevant lines in the gradle/projects.gradle file that you don't want it to check for.
    apply from: "$rootDir/gradle/jacoco.gradle"
    // apply from: "$rootDir/gradle/pmd.gradle"
    apply from: "$rootDir/gradle/checkstyle.gradle"
    //apply from: "$rootDir/gradle/findbugs.gradle"


RFC: Make test on every commit

Run make test on every commit of a PR.
Advantages:

Every commit (in pillar) builds and the tests succeed and this helps when bisecting
More likely to find flaky tests

Disadvantages:

It slows down building the PR (roughly 20 minutes with average amount of commits)
Perhaps it is too strict and scares people away from doing a PR or slows them down
It punishes splitting a PR in more commits

@christoph-zededa  just to be sure: we already execute unit tests on every PR, but here you are proposing to execute them not just on every PR, but on every commit in the PR, right?

Would be great to have this optional, so that everyone can decide does it make sense to run the whole test suite against each commit. This measure if it is a requirement looks more like a punishment for me. Testing is good, no doubts, but this is too much.

Would be great to have this optional, so that everyone can decide does it make sense to run the whole test suite against each commit. This measure if it is a requirement looks more like a punishment for me. Testing is good, no doubts, but this is too much.

It is already optional; (nearly) everybody can just run the same command on their machine.
P.S.: Waiting for somebody to do the same for yetus ...

I think for each commit it's a

since unit tests already run on every push to any PR, I think most commits are already covered this way. I would leave it as is

I agree with @europaul . Also, I think it's nice to have the target test-commits in the Makefile (@christoph-zededa , pls, add the corresponding documentation for make help), but I wouldn't add to the GH actions, our resources are still limited and I'm afraid that by enforcing this running for every single commit can slow down too much the PR reviewing process...

I think for each commit it's a

since unit tests already run on every push to any PR, I think most commits are already covered this way. I would leave it as is

I agree with @europaul . Also, I think it's nice to have the target test-commits in the Makefile (@christoph-zededa , pls, add the corresponding documentation for make help), but I wouldn't add to the GH actions, our resources are still limited and I'm afraid that by enforcing this running for every single commit can slow down too much the PR reviewing process...

Actually I don't think it is a good idea to have it in the Makefile; I would rather put the command directly into the github action.
Running make test-commits confuses the user if they don't know what is happening beneath it; f.e. "Why does running it get me into a rebase conflict?"

I think it makes sense to have it locally also, because before publishing one can check if their commits don't break unit tests. Introducing it into CI/CD won't affect costs much, but I'd gather more data. Back of envelope calculations are like: on average it takes ~4 mins to run unit test on average we have ~5 commits per PR so it's additional 20 mins per PR. With Buildjet runners priced for 0.008$ per minute, it'll result in 0.16$ per PR on average. If we have around 60 PR per month (two each day) that will result in 9.6$ additional cost, I think we can live with that.
As for process: we can always run it in parallel to other workflows :)

I think it makes sense to have it locally also, because before publishing one can check if their commits don't break unit tests. Introducing it into CI/CD won't affect costs much, but I'd gather more data. Back of envelope calculations are like: on average it takes ~4 mins to run unit test on average we have ~5 commits per PR so it's additional 20 mins per PR. With Buildjet runners priced for 0.008$ per minute, it'll result in 0.16$ per PR on average. If we have around 60 PR per month (two each day) that will result in 9.6$ additional cost, I think we can live with that.
As for process: we can always run it in parallel to other workflows :)

Thank you very much for adding those numbers!

If we have around 60 PR per month (two each day) that will result in 9.6$ additional cost, I think we can live with that.

@uncleDecart I'm pretty sure each PR goes through multiple builds (updates to fix yetus issues, code review comments, rebase on master, etc). It is easy to extract how many e.g., yetus or unit test workflows we've run in a month so we can compare with how many PRs we did during that month?

If I read everyone right we want to keep this in Makefile, but not to make this as a part of GH actions. @christoph-zededa can you please change this PR accordingly so we can merge?

If I read everyone right we want to keep this in Makefile, but not to make this as a part of GH actions. @christoph-zededa can you please change this PR accordingly so we can merge?

done - please have a look at the change in the Makefile

@christoph-zededa Please add the help line into the Makefile as well and let's merge this

Closing as it seems nobody needs this
and nobody wants to have it on CI.


load_team_season_stats and load_player_season_stats return the same output

When called, the two function return the same values. It is not only the column names that are equal, but all of the data that is identical. This can be proven by using the assert_frame_equal method in pandas:
import nwslpy
import pandas as pd
import datetime as dt

last_season = str(dt.date.today().year - 1)
this_season = str(dt.date.today().year)

all_teams = nwslpy.load_teams()
active_teams = (all_teams[all_teams["last_season"].astype(str)==this_season]).reset_index()

idx = {name: i for i, name in enumerate(list(active_teams), start = 0)}
each_team_stats = {}
each_team_player_stats = {}

for team in active_teams.itertuples(index=False):
    abbreviation = team[idx["team_abbreviation"]]
    each_team_stats[abbreviation] = nwslpy.load_team_season_stats(abbreviation, this_season).reset_index()
    each_team_player_stats[abbreviation] = nwslpy.load_player_season_stats(abbreviation, this_season).reset_index()

    print(f'Differences between frames for {abbreviation}: {pd.testing.assert_frame_equal(each_team_stats[abbreviation], each_team_player_stats[abbreviation])}')

Running this will output a string of the shape Differences between frames for CHI: None for each team.

It looks like there is an issue with the 2023 data from nwslR which this is querying. The tables appear to be correct for 2022 @adror1 are you aware of the 2023 player season stats table not being broken down by player?

Yikes! On it right now...

Should be fixed, was an issue w/ the way the upload worked. Going to try to fix it this weekend, but the data is right now.

Yup, it looks fixed now. Thanks Arielle!


Remove package-lock.json and bump linter

Change-type: patch
Signed-off-by: Roman Mazur<EMAIL_ADDRESS>

@balena-ci retest please


Run tests in a conda environment for the histopathology workflow.

Run histopathology tests in a conda virtual environment instead of installing packages with pip.

Reminder for @kenza-bouzid : add pipdeptree --warn fail action to the workflow

We decided to not switch to conda env as it was too slow; can we close this? @ant0nsc

Resolved by #478


Feature Request: Integrate Info DVTPlugInCompatibilityUUID script into Al

It would be great if Al could run this script to "register" the plugin.
#bang Xcode’s UUID into all plugins
XCODEUUID=`defaults read /Applications/Xcode.app/Contents/Info DVTPlugInCompatibilityUUID`

for f in ~/Library/Application\ Support/Developer/Shared/Xcode/Plug-ins/*; do defaults write "$f/Contents/Info" DVTPlugInCompatibilityUUIDs -array-add $XCODEUUID; done

Hi Daniel,
This issue has already be discussed extensively in the past (see #122 for example), and the conclusion is that keeping the plugin up to date with Xcode's UUID is the plugin's maintainer's job, not Alcatraz's,. Updating all plugins blindly like that would be bad for the overall Xcode stability.
However, displaying which plugins are out of date and won't work with your currently installed version of Xcode is definitely on the roadmap (#201).


Feature Change

received from<EMAIL_ADDRESS>Original Subject : Wording in PEAKS notification emails
Urgency Level : Non-Critical Issue
Support Department : Programming Support
For Application : Peaks
Supplied Message Body :
Hi PEAKS Team,
I hate to be the one to mention this, but I have a few non-critical suggestions for the wording in the PEAKS email notification template.

Would it be possible to remove the line "Thanks for PEAKing at this email. It sPEAKS well of you."? It does not seem to add any value to the notifications, and adds extra text that must be scanned by unfamiliar users before they can process the meaning of the message.

Could we change the line "Not sure who that is? Click Help. To see your team's Admins" to read "Not sure who that is? Click Help to see your team's Admins."? (added/removed punctuation).

Similarly, could we change the final line to read "This email was automatically generated. Please do not reply to it, as the mailbox is not monitored."?

I've just had a few graduate students ask if the email notifications they received were phishing or not.
Thanks,
Arnon

I'll pass it along, but to be fair, no one phishing would use bad puns :).
For #2, we want that to stand out that it is a clickable link. So I'm not sure if we will change it.
For #3, yes, that is better. But it will not be changed until next week.

For #2 I definitely agree that the "Help" link should stand out. One idea would be to underline it as well -- that might have the added benefit of improving accessibility for visually impaired users.
Should be doable


Implement batch addition in SlidingBoundariesArchive

Description

When we implemented batch addition in #221, we skipped SlidingBoundariesArchive since it was complicated. This PR fixes that.
TODO

Questions

Status

[x] I have read the guidelines in CONTRIBUTING.md
[x] I have formatted my code using yapf
[x] I have tested my code by running pytest
[x] I have linted my code with pylint
[x] I have added a one-line description of my change to the changelog in HISTORY.md
[x] This PR is ready to go

Note on benchmarking: The benchmarks for this PR show a mean of 1.1s for the benchmark_add_10k benchmark, compared to 1.8s for the same at this commit https://github.com/icaros-usc/pyribs/tree/742ea05e40e65c37e0b16c15857a105cb045521c
The speedup is likely due to the use of batch addition during the remapping phase.


start_webcam uploaded

Hi,
Thank you for your contributon. Make sure you rebase/merge master first, as it seems your branch is way behind the current master.
Regards,
Yann


add create_service_endpoint activity

Signed-off-by: Thomas Deville-Duc<EMAIL_ADDRESS>

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   77.23%   77.23%
=======================================
  Files           4        4
  Lines         325      325
=======================================
  Hits          251      251
  Misses         74       74

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79ceccf...ef72507. Read the comment docs.

thanks @tdevilleduc for the PR
could you please fixup/squash your 'fix code syntax' commits to each appropriate activity commits. To have only two proper commits (one per activity)
thanks

Hi   @tdevilleduc, do you mind rebasing from master please? (rebase not merge commit please)

It's not very typical of this extension to read resources from local files. I need to ponder on this.

Hi @tdevilleduc, do you mind rebasing from master please? (rebase not merge commit please)

I don't understand what you are asking me.  I tried something

Ok ! Wasn't easy, but i think it's ok now :)

Thanks! This helps a lot the review/merge indeed :)

It's not very typical of this extension to read resources from local files. I need to ponder on this.

I copied the behavior seen in other places :)
The other way is to recreate file structure with data. Its possible for service structure, but it can be really tough for microservice (the other place i copied it from)

I copied the behavior seen in other places :)

Hah! Good catch. I had forgotten about it and I should have been firmer on my review.

The other way is to recreate file structure with data. Its possible for service structure, but it can be really tough for microservice

I agree. This wouldn't be as simple as having these structures in files.
Good enough.

Hello,
I am sorry I have taken so long to come back to this but the end of year has been way too busy unfortunately.
So, I'm looking at this PR again. I think the create_service_endpoint should be part of its own subpackage. You added it to chaosk8s/actions.py but it should be chaosk8s/service/actions.py
The chaosk8s/actions.py should not really be used anymore, it's a legacy module that dates from the early days of this extension.
Also, you copied the entire block of code from another action indeed but I'd rather avoid duplicated code, it would be better to have a function that knows how to load a k8s manifest. This should live in chaosk8s/__init__.py and be imported wherever you want to apply a manifest.

can we kill this one now @tdevilleduc ?

can we kill this one now @tdevilleduc ?

This one is also useful :
I have an experiment where i remove a service_endpoint (with remove_service_endpoint) and i want to recreate it at the end of the experiment
If you're ok with it, I have already rework it to use a service module, and I will add some test + changelog

Done


fix: optimize bundle size

What:
It's reduce bundle size from 20kb to 4kb

Hey, @runnez
Looks great!
Thank you for the contribution 😄

:tada: This PR is included in version 1.7.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: