Cache files to avoid rebuilding the entire project

Sometimes when your project has a lot of resources (like models, sounds, maps), the building process will get a slowdown.
It will be useful to cache the files for the next amxxpack build command call to avoid wasting any precious time and save it only for the compiling part.
The command amxxpack build --watch help with this issue but the caching is only stored in-memory and not in the disk storage, as soon as you stop the task for some reason, you have to go back to the rebuilding process again.
Maybe this article can help you with this: https://medium.com/@wlarch/avoid-long-running-and-killed-gulp-tasks-with-this-simple-caching-gulp-plugin-67ec8bbf466b

Do not waste time during your build process when there is no reason to.
This plugin will process all files in gulp.src() if at least one file was changed. This plugin uses the features of node-file-cache to keep track of the assets SHA1 hashed content in a cache.json file.

Work in Progress: https://github.com/Hedgefog/node-amxxpack/pull/7


Give descriptive name to link in Terms of Service

FRONTEND PULL REQUEST
Related Issue
Resolves #3978
Changes Proposed
Update link destination and copy as per @lauraykerr's comments on the ticket
Testing
Please review the screenshots
Screenshots / Demos

Checklist for Author and Reviewer
Accessibility

[x] All changes have run through the Deque automated testing

Content

[x] Any content changes have been approved by content team

LGTM! I see it was already like that, but do you know reason why privacy.p0 is broken up to many string in the English version and its only one string in the Spanish version?

nope, I don't think there's a reason for either one. I was wondering if we had something that automatically broke up strings in our pre-commit hooks but doesn't look like it


hyper 2.1.2.exe won't open on windows 10

Hi, in W10,  hyper 2.1.2 won't open.
I tried to delete my .hyper config file but doesn't work.
Any Ideas?
Thanks!

@DanielMutu Look at this thread and see if is similar to your issue: #3442

No, because I don't have the javascript popup, simply won't open, I tried run as administrator and there is no change

i am having the same issue

Same issue. The process is running in the background but it just doesn't launch.
What I did before that happen was, installing it for the first time, then replace the config with the config provided for git bash and then close it immediately to restart it. Since then it doesn't launch anymore. Uninstall and reinstall doesn't help either.

going to %appdata%, finding the Hyper folder and wiping it, then reinstalling, helped me.
Why is that folder not removed when Hyper is uninstalled?

No, because I don't have the javascript popup, simply won't open, I tried run as administrator and there is no change

Same issue, caused by changing the config in my case. The Javascript Popup won't appear when Hyper is closed and launched again, it will just not appear at all.
If you changed your config and then opened a new window from within Hyper, you would have probably received the error.
Try going into the directory for hyper, under Windows that should be somewhere under %appdata%
and completely delete it for a proper reinstall.

When i open my hyper it open a new window of cmd and deafult hyper window is blank
plz help me to solve this

Try a recent version


Remove outgoing payment accounts

Discussed in https://github.com/interledger/rafiki/discussions/190

Originally posted by wilsonianb November 30, 2021

related to https://github.com/interledger/rafiki/issues/156

For :point_up: accounts now only exist in Rafiki for:

peers
asset liquidity
invoices
outgoing payments

I'm wondering if there needs to be accounts for outgoing payments.
Instead of creating a tigerbeetle account and adding liquidity to it, we could send directly from the settlement account. The flow would be:

createPayment
handleQuoting
Rafiki notifies wallet of quote
Wallet gets user approval (if necessary) and reserves the quoted amount in the sender's wallet account
sendPayment -> Rafiki sends payment from settlement account
Rafiki notifies wallet of payment outcome

Not having a payment account avoids having an outstanding balance in Rafiki resulting from either a failed send or a successful fixed delivery payment.
The payment outcome notification allows the wallet to return the leftover amount to the sender or claim as fees.

Payments should have liquidity accounts in order for the settlement account provide an accurate snapshot of the wallet operator's liabilities.


Fix SuperLU interfacing bug with recent hypre version

This fixes a bug where the column indices are not created with the recent hypre release 2.16.0. Please check if the version checking here is correct.
Resolves #983

Have you looked at recent versions of SuperLU_dist to see if their CSR matrix format supports big ints?  I'm just trying to gauge when we might need to support this as well.

Have you looked at recent versions of SuperLU_dist to see if their CSR matrix format supports big ints? I'm just trying to gauge when we might need to support this as well.

They support int64 in their interfaces as a compile option.
It is more a problem due to hypre. Some internal behavior was changed that we rely on in a few different places in the code.


Workspace sometimes crashes

The occurrence condition that I could check is as follows.

Immediately after starting Gonvim
Immediately after moving :GonvimWorkspace*

I'm sorry if I got it right, but whenever I open goneovim and then create a new workspace it crashes.
and it says
nvim:nvim_ui_attach validation: Expected width > 0 and height > 0
while in setting.toml I have given
#setting.toml
[Editor]
Width = 800
Height = 600
# rest settings...

Hi :D
What goneovim version are you using?
Please tell me the result of :GonvimVersion


Delete this issue

The new data set that we will use must be added to the download_data.R file. Its the data set name.basics.tsv.gz.

Ignore this issue please


Duplicate key error not on duplicate keys

Currently getting said error:
{ [Error: duplicate key value violates unique constraint "parts_name_key"]   message: 'duplicate key value violates unique constraint "parts_name_key"' }
The first two (out of ~5800+) names (varchar) keys are:
900NTNNEK00000-NO_FW
900NTNNEG00000-NO_FW
These are not the same, but are still somehow being rejected. This may be PostgreSQL or could be Massive.js. If PostgreSQL can't tell these two apart, then I have the wrong DB.

This is a Postgres error, Massive doesn't throw this. If I had to guess, I would say that Postgres can probably tell those two values apart and your test data isn't being cleared properly.
Triggers perhaps? Do you have a callback you're using?

I'm using the same function from the other issue I wrote. I'm starting with a clean table and have limited the data set to only run two. If I run it from Node, the error happens when this.db.query runs the pg commands. I tried it straight in pgAdmin3 and it worked fine when adding the new value. I come from NoSQL and just learning PostgreSQL, so it could be my fault in that end.
Said function (currently fixing for async inside loop):
for (var i = 0; i < 2; i++) {
		console.log(data[i].name);
		db.parts.findOne({name: data[i].name}, function(err, part) {
			if(part) {
				console.log('found');
				db.parts.save({
					id: part.id,
					status: data[i].status,
					fake: 'test'
				}, function(err, inserted) {
					if(err) return console.log(err);
					// console.log(inserted);
					// res.send(inserted);
				});
			} else {
				console.log('not found');
				db.parts.save({
					name: data[i].name,
					status: data[i].status,
					fake: 'super'
				}, function(err, inserted) {
					if(err) return console.log(err);
					// console.log(inserted);
					// res.send(inserted);
				});
			}
		});
	}

Would you mind telling me what this function is supposed to do? In general terms? It's sort of hard to understand what's going on and what you're trying to do etc.

So we run tests every night on parts to pass certain parameters and they are, mostly, the same parts, but new ones are added every so often. Essentially the run the tests with jenkins and then need to post that json to PostgreSQL to have it displayed in a web environment. They don't have IDs so I used id serial primary key not null to create the ID. To be able to do the update you need the key so I have to go find the row matching the name so I can do that.
Essentially I need to find the key that matches the part name so I can either run an update or an insert.

Well, it fixed itself with changing it to using async.each. Sorry to waste your time guys.

No worries! It's usually the culprit when head-scratching stuff happens :).


Docker run is not working

we user docker latest version. UI can be working but api dont works latest version.
Can you check api on docker [Exceptionless] latest version for api

Thanks for reporting this issue, can you please provide enough information that we can reproduce:

What operation system are you using
What version of docker are you using
What is the exact docker command you are using
what is the exact docker tag and version are you using?
Are there any logs that are outputted?

@cetins32 can you please provide the above information

Closing until more information is provided.


how to prepare dataset to train?

from text to image, is there any dataset that using this format?

The Coco dataset contains annotations and images, you could prepare a short python script which renames the images accordingly and adds a ***.txt file for each image, with *** being the imagename.

@robvanvolt You mean using coco's caption annotations?

Exactly - the annotations .csv/.txt file have to be split into single .txt files per image.

https://github.com/lucidrains/DALLE-pytorch/issues/68
Here's an example of a custom dataset loader I made. It's pretty slow, so let me know if you can think of improvements.


or & and in if condition, using ocr in exist() - added 'using ocr' to exist() & present()

Hi, kelaberetiv, I can not find the way for using OR and AND example in tagui in document. Is any way I can add operator?
Also I can not use exist() to find text by using ocr, if exist('abc using ocr') is not work. Could you help me?
Thank you.

Sorry Vince, I was away the past few months - https://github.com/tebelorg/RPA-Python/issues/144
Below is an example of using and / or in conditions -
a = 1
b = 2
c = 'carrot'
d = 'durian'

if a equals to 1 and b equals to 2
    echo YES
else
    echo NO

if c equals to 'cat' or d equals to 'durian'
    echo YES
else
    echo NO

The exist() and present() functions are not designed to take in text search using ocr. Let me review if that can be added in.

Above commits adds 'using ocr' search to present() and exist(). To use it, you can download the latest copy of the code from here and unzip to overwrite your existing installation (please drag the folders under tagui\src to overwrite your existing installation) - https://github.com/kelaberetiv/TagUI/archive/master.zip
In the next release, this will become part of the packaged zip files. Thanks for raising this!

Closing issue since the latest packaged release TagUI v6.14 is out.
Release notes - https://github.com/kelaberetiv/TagUI/releases/tag/v6.14.0
To download v6.14 - https://tagui.readthedocs.io/en/latest/setup.html
Documentation - https://tagui.readthedocs.io/en/latest/index.html


Fixing coverage reporting

Codecov Report

Merging #396 (6a252b7) into master (b31f1cc) will increase coverage by 80.61%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #396       +/-   ##
===========================================
+ Coverage    0.00%   80.61%   +80.61%
===========================================
  Files         145      145
  Lines       10892    12451     +1559
  Branches     1675     1676        +1
===========================================
+ Hits            0    10037    +10037
+ Misses      10892     1902     -8990
- Partials        0      512      +512

Impacted Files
Coverage Δ

...urces/AngouriMath/Core/Exceptions/SysExceptions.cs
0.00% <0.00%> (ø)

...AngouriMath/Functions/Output/ToSympy.Definition.cs
0.00% <0.00%> (ø)

...h/Functions/TreeAnalyzer/InnerSimplifyUnpacking.cs
0.00% <0.00%> (ø)

...h/Functions/Output/Latex/Latex.Discrete.Classes.cs
9.09% <0.00%> (+9.09%)
:arrow_up:

.../Continuous/Entity.Continuous.Number.Definition.cs
16.66% <0.00%> (+16.66%)
:arrow_up:

...ctions/Simplification/Patterns/Patterns.Boolean.cs
27.27% <0.00%> (+27.27%)
:arrow_up:

...h/Functions/Compilation/IntoLinq/MathAllMethods.cs
27.45% <0.00%> (+27.45%)
:arrow_up:

...h/Functions/Compilation/Compile.Linq.Definition.cs
35.29% <0.00%> (+35.29%)
:arrow_up:

...tions/Output/ToString/ToString.Discrete.Classes.cs
36.36% <0.00%> (+36.36%)
:arrow_up:

...Functions/Output/ToSympy/ToSympy.Number.Classes.cs
40.00% <0.00%> (+40.00%)
:arrow_up:

... and 133 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b31f1cc...6a252b7. Read the comment docs.


make-disk-image.sh doesn't work with partitionTableType="efi": Failed to open file system "/dev/block/254:1": No such file or directory

Describe the bug
make-disk-image.sh doesn't work with partitionTableType="efi".
The phase1/phase2 don't setup /dev/block and bootctl install doesn't seem to like that:
(I added a bit of logging to make-disk-image.sh:)
++ ls -al /dev/block
ls: cannot access '/dev/block': No such file or directory
++ true
++ ls -al /dev/disk
ls: cannot access '/dev/disk': No such file or directory
++ true
++ ls -al /sys/dev/block
total 0
drwxr-xr-x 2 root 0 0 Jul 18 02:09 .
drwxr-xr-x 4 root 0 0 Jul 18 02:09 ..
lrwxrwxrwx 1 root 0 0 Jul 18 02:09 1:0 -> ../../devices/virtual/block/ram0
lrwxrwxrwx 1 root 0 0 Jul 18 02:09 1:1 -> ../../devices/virtual/block/ram1
lrwxrwxrwx 1 root 0 0 Jul 18 02:09 1:10 -> ../../devices/virtual/block/ram10
lrwxrwxrwx 1 root 0 0 Jul 18 02:09 1:11 -> ../../devices/virtual/block/ram11
lrwxrwxrwx 1 root 0 0 Jul 18 02:09 1:12 -> ../../devices/virtual/block/ram12
lrwxrwxrwx 1 root 0 0 Jul 18 02:09 1:13 -> ../../devices/virtual/block/ram13
lrwxrwxrwx 1 root 0 0 Jul 18 02:09 1:14 -> ../../devices/virtual/block/ram14
lrwxrwxrwx 1 root 0 0 Jul 18 02:09 1:15 -> ../../devices/virtual/block/ram15
lrwxrwxrwx 1 root 0 0 Jul 18 02:09 1:2 -> ../../devices/virtual/block/ram2
lrwxrwxrwx 1 root 0 0 Jul 18 02:09 1:3 -> ../../devices/virtual/block/ram3
lrwxrwxrwx 1 root 0 0 Jul 18 02:09 1:4 -> ../../devices/virtual/block/ram4
lrwxrwxrwx 1 root 0 0 Jul 18 02:09 1:5 -> ../../devices/virtual/block/ram5
lrwxrwxrwx 1 root 0 0 Jul 18 02:09 1:6 -> ../../devices/virtual/block/ram6
lrwxrwxrwx 1 root 0 0 Jul 18 02:09 1:7 -> ../../devices/virtual/block/ram7
lrwxrwxrwx 1 root 0 0 Jul 18 02:09 1:8 -> ../../devices/virtual/block/ram8
lrwxrwxrwx 1 root 0 0 Jul 18 02:09 1:9 -> ../../devices/virtual/block/ram9
lrwxrwxrwx 1 root 0 0 Jul 18 02:09 254:0 -> ../../devices/pci0000:00/0000:00:07.0/virtio3/block/vda
lrwxrwxrwx 1 root 0 0 Jul 18 02:09 254:1 -> ../../devices/pci0000:00/0000:00:07.0/virtio3/block/vda/vda1
lrwxrwxrwx 1 root 0 0 Jul 18 02:09 254:2 -> ../../devices/pci0000:00/0000:00:07.0/virtio3/block/vda/vda2

++ lsblk -f
NAME   FSTYPE FSVER LABEL UUID FSAVAIL FSUSE% MOUNTPOINT
vda
|-vda1                          247.8M     0% /mnt/boot
`-vda2                               0    94% /mnt
++ udevinfo -q path -n /dev/vda
/nix/store/2a9cv8f3aisf94xgzzpmgpbnd9lhqzxw-stdenv-linux/setup: line 1297: udevinfo: command not found
++ true
++ mkdir -p /dev/block
++ mkdir -p /mnt/etc/nixos
++ NIXOS_INSTALL_BOOTLOADER=1
++ nixos-enter --root /mnt -- /nix/var/nix/profiles/system/bin/switch-to-configuration boot
setting up /etc...
Initializing machine ID from random generator.
Failed to open file system "/dev/block/254:1": No such file or directory
Traceback (most recent call last):
  File "/nix/store/99h20fjb0miaxcascrv8763byq6f43jv-systemd-boot-builder.py", line 256, in <module>
    main()
  File "/nix/store/99h20fjb0miaxcascrv8763byq6f43jv-systemd-boot-builder.py", line 199, in main
    subprocess.check_call(["/nix/store/li8ybhd1x377qb9c14mn8i6vjbig1i4z-systemd-245.6/bin/bootctl", "--path=/boot", "--no-variables", "install"])
  File "/nix/store/7q4crsd8kvmma32ff2xw4w9ydj5k26cy-python3-3.8.3/lib/python3.8/subprocess.py", line 364, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/nix/store/li8ybhd1x377qb9c14mn8i6vjbig1i4z-systemd-245.6/bin/bootctl', '--path=/boot', '--no-variables', 'ins>
+ exitHandler

Unfortunately, I can't figure out how to mount /dev/block properly, or what should be responsible for doing so.
Metadata
This is with nixos-unstable{-small}. currently : 24b55081f5f34bcac32db6dd38948c795c270582

I had a similar problem when using systemd-boot in qemu-vm.nix. I believe udev is supposed to create those device nodes, however, udev isn't available in the more minimal linux environment given by runInLinuxVM. I ultimately just added the symlink manually for the required device:
https://github.com/NixOS/nixpkgs/blob/0ae51edb29dc6aa5f86c1e3686047032818af089/nixos/modules/virtualisation/qemu-vm.nix#L249-L251

I am still running into this.

I am still running into this.

We now sometimes get this error (message) in blocker tests, e.g. the first run of this test on Hydra and I can't even make that test succeed locally. Unfortunately I know little about topics around this.


FileNotFoundError: Could not find module 'v6_w32_nd2ReadSDK.dll'. Try using the full path with constructor syntax.

This package is not working properly in Windows @soft-matter @aaristov . Even after your version 1.1.
  from nd2reader import ND2Reader
  File "c:\program files\python38\lib\site-packages\nd2reader\__init__.py", line 2, in <module>
    from nd2reader.reader import ND2Reader
  File "c:\program files\python38\lib\site-packages\nd2reader\reader.py", line 1, in <module>
    from pims import Frame
  File "c:\program files\python38\lib\site-packages\pims\__init__.py", line 1, in <module>
    from pims.api import *
  File "c:\program files\python38\lib\site-packages\pims\api.py", line 113, in <module>
    from pims_nd2 import ND2_Reader as ND2Reader_SDK
  File "C:\Users\david\AppData\Roaming\Python\Python38\site-packages\pims_nd2\__init__.py", line 1, in <module>
    from .nd2reader import ND2_Reader
  File "C:\Users\david\AppData\Roaming\Python\Python38\site-packages\pims_nd2\nd2reader.py", line 8, in <module>
    from . import ND2SDK as h
  File "C:\Users\david\AppData\Roaming\Python\Python38\site-packages\pims_nd2\ND2SDK.py", line 23, in <module>
    nd2 = cdll.LoadLibrary('v6_w32_nd2ReadSDK.dll')
  File "c:\program files\python38\lib\ctypes\__init__.py", line 447, in LoadLibrary
    return self._dlltype(name)
  File "c:\program files\python38\lib\ctypes\__init__.py", line 369, in __init__
    self._handle = _dlopen(self._name, mode)
FileNotFoundError: Could not find module 'v6_w32_nd2ReadSDK.dll'. Try using the full path with constructor syntax.

I just made a quick test in Miniconda on Windows 10 with pims_nd2 1.1 and python -c "import pims_nd2" works without problems.  Please provide us with more details about your system configuration. Which Windows version you use, which python distribution, etc.

+1 on this. Mine also does this in a anaconda environment when pims is half broken. I recommend removing and installing pims.

Hi, I am getting the following error. Please help me to solve it. I am super new to the Python.
File "", line 1, in
File "e:\Example1.py", line 65, in main
server = windll.LoadLibrary("C:/IMPL/IMPLserver.dll")

File "C:\Users\Andrew\AppData\Local\Programs\Python\Python39\lib\ctypes_init_.py", line 452, in LoadLibrary
return self._dlltype(name)

File "C:\Users\Andrew\AppData\Local\Programs\Python\Python39\lib\ctypes_init_.py", line 374, in init
self._handle = _dlopen(self._name, mode)

FileNotFoundError: Could not find module 'C:\IMPL\IMPLserver.dll' (or one of its dependencies). Try using the full path with constructor syntax.

I found the answer. There is a problem with python versions. If you use python >= 3.8 then you should do the following:
Before that:
server = windll.LoadLibrary("C:/IMPL/IMPLserver.dll")
you should write all paths of dll-dependencies by function os.add_dll_directory() like this:
os.add_dll_directory("Path to dll-dependencies for your dll library").
For example I have a library Library.dll which I downloading by windll.LoadLibrary(). And I have dependency "sublibrary.dll" that used in Library.dll and locate in "C://libs". So, I should call the following before windll.LoadLibrary():
import os' 'os.add_dll_directory(C://libs)
This is the answer!


libsidplayfp: 2.10.1 -> 2.11.0

https://github.com/libsidplayfp/libsidplayfp/releases/tag/v2.11.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 353940

x86_64-linux

:white_check_mark: 8 packages built:

audacious
audacious-plugins
gjay
libsidplayfp
libsidplayfp.doc
qmplay2 (qmplay2-qt6)
qmplay2-qt5
sidplayfp


JEI integration filters

Issue description:
JEI has the option to transfer recipes (IRecipeTransferHandler). It would be nice to use this to fill in item filters used by the logistical sorter & digital miner.
Steps to reproduce (the wanted result):

Open Logistical Sorter
Add new ItemStack filter
Select desired item to filter in JEI
Click the + icon
See the ItemStack appear in the top left slot

Needed functionality:
Somewhere in MekanismJEI needs to be the following call:
registry.getRecipeTransferRegistry().addUniversalRecipeTransferHandler(......)
An IRecipeTransferHandler which is specific for the item filters.
The problem why this is an issue and not something I've already implemented:
It only works with classes extending Container, which there isn't. All needed for the filters are some GUI's to set stuff up, and a list in the tile entity storing all the filters, there isn't a part in between which could store stuff (a container).
Opened for discussion as I'm not sure this is (without to much problems) possible.

For reference, here's how Integrated Dynamics does it with its logic programmer: https://github.com/CyclopsMC/IntegratedDynamics-Compat/blob/8417e00c478781543b7d12f2cfaad921a089fed3/src/main/java/org/cyclops/integrateddynamicscompat/modcompat/jei/JEIIntegratedDynamicsConfig.java

Something to consider:

I think I'm going to just maintain the OreDictionary filters - the reason I haven't added this in yet is I feel that being able to type in the name of any block you want to replace would kind of take away from the fun of the different filters - the OreDictionary filters are great for dealing with wide varieties of blocks, but when you want to get specific, you need to have the type of block on hand. Hope you understand!

https://github.com/aidancbrady/Mekanism/issues/1638#issuecomment-51282193

I think it's worth reconsidering that. It really seems to decrease convenience without adding any real challenge.

Well you can't really decrease convenience that's not there in the first place - but I'm not arguing that it wouldn't add convenience.
Indeed it's not a huge challenge to get the item to put in but typing or selecting stuff would make the DM even more of a magic 'press button, insert power, get thing'
At the end of the day it's not my call, I just wanted to point out what has been said in the past.


Add --ci flag

disable activity indicator
remove --no-progress-bar

I am 99% sure this flag is not needed and Protostar could be able to infer that TTY is not interactive from running environment. Does TQDM properly degrade in CI?


Clarify artifact documentation

Feedback from the Nest with Fedora workshop was that the artifact documenation is not clear. It says that status is idea but in fact it is implemented in cruncher. Let's make it clear what already works.

This has been covered by 0a3c7c52.


Fixed flake8 for setup.py

Coverage remained the same at 67.68% when pulling 76351979cd11ce965c370524b33ba046c7cc342d on PritishC:fix-flake8-issues into 84d52fef8c47e15db5654f5c3931a2f9d0b69525 on openlabs:develop.

Coverage remained the same at 67.68% when pulling 76351979cd11ce965c370524b33ba046c7cc342d on PritishC:fix-flake8-issues into 84d52fef8c47e15db5654f5c3931a2f9d0b69525 on openlabs:develop.


Add support for releases endpoint

Closes #125
Adds support for /releases
https://www.pivotaltracker.com/help/api/rest/v5#Releases
One caveat is I am unsure how to get the test data for VCR to write the tests.

Coverage decreased (-0.3%) to 96.671% when pulling a0d2af3b8da1db43897e32ca0d408d208e04d117 on bmulvihill:releases into 72c51d3ad20d0358808f2dd5b05038c17ab23750 on dashofcode:master.

@bmulvihill for releases you can will want to add a test for Stories#get_release and Project#releases. I think it makes sense to add the tests to the respective test files that already exist. You will see from the existing tests, like for Story#tasks that VCR.use_cassette is used to wrap the parts that make API calls. https://github.com/dashofcode/tracker_api/blob/master/test/story_test.rb#L212
VCR will record the API call and save the response. Then in subsequent test runs it will return this saved response instead of actually making the API call. To get VCR to re-record the response just delete the file with the response and it will be recreated.
When you are happy with the reponse add it to git.

@forest I guess my main question with the tests were which project board you using to create the test data?

Just answered my own question :)
https://github.com/dashofcode/tracker_api/blob/master/test/minitest_helper.rb#L19-L31

Ah. The project has three for different use cases but I typically use #1.
https://github.com/dashofcode/tracker_api/blob/master/test/minitest_helper.rb#L28
You might have to login and create from releases so you have some data to query.

👍  Looks good.


Slices of dynamic shared arrays all alias

The following:
from numba import cuda, int32
import numpy as np

@cuda.jit(debug=True)
def sm_slice(x):
    dynsmem = cuda.shared.array(0, dtype=int32)
    sm1 = dynsmem[0:1]
    sm2 = dynsmem[1:2]

    sm1[0] = 1
    sm2[0] = 2
    x[0] = sm1[0]
    x[1] = sm2[0]

arr = np.zeros(2, dtype=np.int32)
nshared = 2 * arr.dtype.itemsize
sm_slice[1, 1, 0, nshared](arr)
print(arr)

when run on a CUDA device:
$ python alias.py
[2. 2.]

and on the simulator:
$ NUMBA_ENABLE_CUDASIM=1 python alias.py
[1. 2.]

Although we haven't documented dynamic shared memory (yet - I discovered this while writing examples), I think the simulator behaviour should be considered correct, because it matches what a normal user would expect to happen.
The PTX (edited for clarity) clearly does nothing to differentiate the slices, but I am yet to work back any further on the issue:
.visible .entry sm_slice(
        .param .u64 sm_slice_param_0,
        .param .u64 sm_slice_param_1,
        .param .u64 sm_slice_param_2,
        .param .u64 sm_slice_param_3,
        .param .u64 sm_slice_param_4,
        .param .u64 sm_slice_param_5,
        .param .u64 sm_slice_param_6
)
{
        .reg .b32       %r<5>;
        .reg .b64       %rd<5>;

        ld.param.u64    %rd1, [sm_slice_param_4];
        cvta.to.global.u64      %rd2, %rd1;
        mov.u64         %rd3, 0;
        mov.u64         %rd4, %rd3;
        // dbg 11
        mov.u32         %r1, 1;
        st.shared.u32   [_cudapy_smem_1], %r1;
        // dbg 12
        mov.u32         %r2, 2;
        st.shared.u32   [_cudapy_smem_1], %r2;
        // dbg 13
        ld.shared.u32   %r3, [_cudapy_smem_1];
        st.global.u32   [%rd2], %r3;
        // dbg 14
        ld.shared.u32   %r4, [_cudapy_smem_1];
        st.global.u32   [%rd2+4], %r4;
        ret;
}

Thanks for the report. I'm of the view that the simulator behaviour is the expected behaviour too. Mark as a bug to fix?

Sounds good - hoping to look into this fairly soon, so I don't have to write "Don't use slices of dynamic shared memory because it doesn't work" in the docs :-)


fix(config): try to read server from env before falling back to hardcoded claude

try the env for the server and recursion_limit, then fall back to the hardcoded defaults

Actually, looks like it's hardcoded in quite a few places.


Tar Builder ought to use the tarfile module

This issue was originally created at: 2008-01-21 06:48:55.
This issue was reported by: petergummer.
petergummer said at 2008-01-21 06:48:55

The Tar builder is a very crude wrapper for the tar command line utility. It adds no real value compared with simply running tar directly within a Command builder; in fact, it obscures the interface a bit and can complicate things.
Gary Oberbrunner wrote, "I've noticed the same thing.  Ideally IMHO it should be rewritten to use the python tarfile stuff internally, and just look like regular tar options to the user.  Also tar's options aren't the same on all machines (IRIX doesn't even support -z, nor bundling args), another reason to redo it."
Thanks to Gary's suggestion, I've had a look at Python's tarfile module and it does add value; e.g., it allows you to specify each file's name within the archive, which can save an intermediate step of creating the desired directory structure. One thing that it lacks in Python 2.5.1 compared with the command-line tar utility is the ability to exclude specific files, but I notice that this feature has been added to Python 3:
http://mail.python.org/pipermail/python-3000-checkins/2007-June/001000.html
So I think Gary is right. The Tar builder should use the tarfile module.

gregnoel said at 2008-01-21 13:08:04

I've wanted this as well.  And, although I agree that Tar() is the heavy lifter and should be fixed first, I'd like to see this capability extended to Jar() and Zip() as well.  (Maybe those two should be farmed out into separate issues.)  I also think it's a capability that should be explored for Pacakage() as it is integrated with the Autotools feature set (I'm less sure of this as the API could be a serious issue).
This is really an enhancement request, so I changed the issue type.

russel said at 2008-02-26 23:46:49

As noted on my email to the user list, the presence of http://www.scons.org/wiki/AccumulateBuilder and http://www.scons.org/wiki/DistTarBuilder on the wiki indicate some of the deficiencies of the Tar builder.
I agree that Zip (and Jar I guess) also need some attention.

garyo said at 2008-03-17 20:24:47

*** Issue 1360 has been marked as a duplicate of this issue. ***

garyo said at 2008-03-17 20:30:53

Tar builder, reassigning to Greg.

gregnoel said at 2008-03-17 22:44:25

Needs backported tarfile.py, which needs new-style classes, so I made this 2.x.

gregnoel said at 2009-04-18 17:25:40

Issue #2384 is developing the technology for this issue and issue #1351 uses the Zip() builder, so set the dependencies appropriately.

garyo said at 2012-09-01 10:04:01

de-assigning all tickets assigned to Greg Noel (no longer working on SCons)

Votes for this issue: 12.
gregnoel said this issue depends on #2384 at 2009-04-18 17:25:40.
gregnoel said this issue blocks #1351 at 2009-04-18 17:25:40.
garyo said this issue is duplicated by #1360 at 2008-03-17 20:24:49.

The only note would be that using tarfile module leaves the work being done in-process, which is not necessarily the best choice if there's lots going on and many threads building.

The only note would be that using tarfile module leaves the work being done in-process, which is not necessarily the best choice if there's lots going on and many threads building.

True. Could such be run as a forked process instead of a thread as normal? It doesn't modify the Environment() it's connected to..


HDFS-17359. EC: recheck failed streamers should only after flushing all packets.

Description of PR
Refer to HDFS-17359
In method DFSStripedOutputStream#checkStreamerFailures, we have below codes:
    Set<StripedDataStreamer> newFailed = checkStreamers();
    if (newFailed.size() == 0) {
      return;
    }    if (isNeedFlushAllPackets) {
      // for healthy streamers, wait till all of them have fetched the new block
      // and flushed out all the enqueued packets.
      flushAllInternals();
    }
    // recheck failed streamers again after the flush
    newFailed = checkStreamers();

We should better move the re-check logic into if condition to reduce useless invocation.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  3s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 47s

trunk passed

+1 :green_heart:
compile
0m 58s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 52s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 31s

trunk passed

+1 :green_heart:
mvnsite
0m 58s

trunk passed

+1 :green_heart:
javadoc
0m 47s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 42s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 37s

trunk passed

+1 :green_heart:
shadedclient
34m  3s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 45s

the patch passed

+1 :green_heart:
compile
0m 52s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 52s

the patch passed

+1 :green_heart:
compile
0m 44s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
0m 44s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 19s

the patch passed

+1 :green_heart:
mvnsite
0m 46s

the patch passed

+1 :green_heart:
javadoc
0m 35s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 34s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 38s

the patch passed

+1 :green_heart:
shadedclient
33m 54s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 26s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

130m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6503/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6503

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 138005f070ab 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / bde7710e7d1ffcd087c5a2f7068725f393aa338a

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6503/1/testReport/

Max. process+thread count
683 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6503/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@Hexiaoqiao @zhangshuyan0 @tasanuma Hi~ sir. Could you please help me review this simple modification when you are free? Thanks a lot.

Merged. Thanks for your contribution! @hfutatzhanghb

Merged. Thanks for your contribution! @hfutatzhanghb

Sir, thanks a lot for your reviewing and merging ~


[Feature request] Add LSP support

Is it on the works to add LSP support?

How would LSP be used with a file navigation tool?

To display issues in your files according to your LSP

okay, so similar to red/yellow/green file colors in vscode?
-------- Original Message --------
On Dec 9, 2022, 9:47 AM, Rahmerh < @.***> wrote:

To display issues in your files according to your LSP
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

Yes exactly, take this as an example: https://github.com/nvim-tree/nvim-tree.lua You can see the amount of warnings, errors, next to each file in your explorer


Add support for terminal foreground/background responses formatted as rr/gg/bb

Vim sets the 'background' option based on the terminal's response to a request for background color.
Vim only supports the following format for the color from the terminal: rgb:rrrr/gggg/bbbb.
This PR adds support for this format: rgb:rr/gg/bb.
Context: this comment on an Alacritty pull request.
(Summary: the xterm documentation specifies that the response for the foreground/background request is in the same format as setting the color.
Since Alacritty does not support setting the color in the rrrr/gggg/bbbb format, it responds with the rr/gg/bb format.)
If appropriate, I'm happy to close this PR and redirect another one to Alacritty instead, but I believe that supporting this format will help Vim to support more terminals that interpret the xterm docs in the same way.

Failing coverage. I'm not sure I can test this without changing libvterm's response to the request.

coveralls is quite flaky, I suggest to use codecov: https://codecov.io/gh/vim/vim/commit/fc9ff3cde0324d05819da72333ef22a6c1646fe2
This doesn't reduce coverage, so looks certainly okay. Better would be to have a test, not sure if this is actually possible with this change.


Datetime changes

Fixes #736

Uses DateTimeImmutable for everything
Added our own class extending it that means datetimes get serialized in json as "Y-m-d\TH:i:s.uP" or "Y-m-d\TH:i:sP" depending if microsecond precision is enabled.

Feedback welcome :)

BTW build fails due to https://github.com/bzikarsky/gelf-php/pull/62


Handling homepage for multi lang

Home page redirections happen on multi lang sites. Ideally the '/home' node should have a redirect that is language sensitive.

@arjunadotfusion what would be the intended behavior for a multi-language site with an incoming request to /home or /, would you want that to redirect to the default language i.e. /en-us/?

@jamesvidler - ideally it would handle intelligently so the first node would default to the path provided and create the redirect no?

Ideally with a config like this :
languages: [
          {
            // The name of the language code
            name: "French",
            // The actual language code set in Agility CMS
            code: "fr",
            // The name to be used in the URL path that represents the current language
            path: "/fr"
          },
          {
            // The name of the language code
            name: "English",
            // The actual language code set in Agility CMS
            code: "en-us",
            // The name to be used in the URL path that represents the current language
            path: ""
          }
        ],

The french home (/fr/home) should redirect to /fr and (/en/home) should redirect to the base url

The way we had intended for it to work in a multi-lang site would be the following:

A request to / would redirect to /en/ (path param for English)
A request to /fr/home would redirect to /fr/ (path param for French)

That way, every single page always has a language code in it. Does it currently work that way and you want to change it to always stay on '/' for the English language only?

Currently home page logic only kicks in for the last language in the config and it respects the path params in the config.
Unfortunately, currently redirects hit all /home nodes, or rather first child nodes of the sitemap and redirect to /.
i think the change has to be in the this function where it handles it for base as well as for the language path prop.

@arjunadotfusion we just committed fixes for multi-language support. Here is how it works:

A request to / would redirect to /en/ (the default path for the first language)
A request to /en/home would redirect to /en/
A request to /fr/home would redirect to /fr/

Can you take a look at the latest version 1.4.0 and see if this resolves the issue you are seeing?


Switch links to Smithy v2 documentation

Motivation and Context
The latest documentation is Smithy v2. In most cases it's identical. As far as I can tell, there are no links to items with breaking changes between v1 and v2.

@hlbarber Do you think this would cause any users to incorrectly assume that we support IDL v2? If you do then I'm thinking we should hold off until we support:

[ ] The enum stuff (I think we already added this and I just forgot)
[ ] Nullability
[ ] Presence tracking

I suppose that the cost of that confusion isn't very high though. They'd just be a little sad.

@hlbarber Do you think this would cause any users to incorrectly assume that we support IDL v2?

Yeah, probably. I'll put this in draft and we can resurrect it when we're ready.


Bizarre bug with PopupMenu submenus when popped up near the bottom of the screen

Godot version
3.x 9bb6f9576d3ce09941c8ae18a033c15a3f98251f
Probably also happens in 4.0
System information
Arch Linux
Issue description
The specific setup in the linked MRP causes hovering over the item that opens the submenu to flicker the opening of the submenu for every time the mouse is moved, this seems to be caused by f63bea9ef281be2513b8653a4d2eabd77842a5c9 in fact moving the pm->popup(); line under pm->set_scale(get_global_transform().get_scale()); in _activate_submenu seems to fix the issue.
It only seems to happen on a setup specifically like the one in the linked MRP, where the submenu item is the first and it has 4 normal items following it, yeah I don't get it either but this is what it does.
Steps to reproduce
Load the linked MRP and right click anywhere on the screen, hover the "Change type" item and observe how the menu flickers when moving over it, making it impossible to select any of the items.
Minimal reproduction project
PopupMenuBug.zip

@EIREXE @Calinou @akien-mga @YeldhamDev
I have this problem in Material Maker and it is pretty annoying.
It seems autohide areas setup needs the menu to be where it will popup (this depends on its item count, especially if it's near the bottom of the viewport). I modified the draw stuff to display them and they are offset with current 3.x code.
Moving popup() above the if statement seems to break navigating menus with the arrow keys.
I don't think it is that difficult to fix, the "pm->popup();" statement can be moved between the "ui_accept" action stuff and the autohide areas setup, like this:
`	pm->set_position(pos);
pm->set_scale(get_global_transform().get_scale());
PopupMenu *pum = Object::cast_to<PopupMenu>(pm);
// If not triggered by the mouse, start the popup with its first item selected.
if (pum && pum->get_item_count() > 0 && Input::get_singleton()->is_action_just_pressed("ui_accept")) {
	pum->set_current_index(0);
}

pm->popup();

if (pum) {
	pr.position -= pum->get_global_position();
	pum->clear_autohide_areas();
	pum->add_autohide_area(Rect2(pr.position.x, pr.position.y, pr.size.x, items[over]._ofs_cache));
	if (over < items.size() - 1) {
		int from = items[over + 1]._ofs_cache;
		pum->add_autohide_area(Rect2(pr.position.x, pr.position.y + from, pr.size.x, pr.size.y - from));
	}
}

}
`

Fixed by #61686.


Wrong Focus after Search on Mobile

Where to find the issue
Mobile Website, FAQ search ch
Describe the issue
After entering the search terms, the focus is still on the search field and not the list of FAQs. Hence, the page does not scroll down smoothly but wobbles left and right.
Suggested change
Set focus properly.

Fixed :)


allmodules unit test confusion

@Ashmita89 reports that on her Windows Vista machine, ut_seash_allmodules.py raises an exception when run as a standalone Python program, but still passes when run under utf.py despite no #pragma error declaration.
Shell transcript:
C:\Users\Ashmita\seash\RUNNABLE>python ut_seash_allmodules.py
- You can see available seash factoids using 'show factoids [number of factoids]
/all' command.

Enabled modules: factoids, geoip, modules, uploaddir, variables

Traceback (most recent call last):
  File "ut_seash_allmodules.py", line 26, in <module>
    seash.command_loop(commands)
  File "C:\Users\Ashmita\seash\RUNNABLE\seash.py", line 192, in command_loop
    seash_dictionary.command_dispatch(cmd_input, environment_dict)
  File "C:\Users\Ashmita\seash\RUNNABLE\seash_dictionary.py", line 2109, in comm
and_dispatch
    current_callback(input_dict.copy(), environment_dict)
  File "C:\Users\Ashmita\seash\RUNNABLE\modules\modules\command_callbacks.py", l
ine 89, in enable_module
    seash_modules.enable(seash_dictionary.seashcommanddict, modulename)
  File "C:\Users\Ashmita\seash\RUNNABLE\seash_modules.py", line 365, in enable
    raise seash_exceptions.UserError("Module is already enabled.")
seash_exceptions.UserError: Module is already enabled.

C:\Users\Ashmita\seash\RUNNABLE>python utf.py -f  ut_seash_allmodules.py
Testing module: seash
Now starting subprocess: ut_seash_subprocess.py
Generating user keys...
Generating owner key...
Writing config file...
Writing vessel dictionary...
Now running setup script: ut_seash_setup.py
        Running: ut_seash_setup.py                                  [ PASS ]
        Running: ut_seash_allmodules.py                             [ PASS ]

OK, here's part of the key to the solution: allmodules is a stateful test, i.e. after it ran, it leaves traces that change how subsequent runs will behave. In this specific case, see the modules dir, where allmodules happens to cause the creation of *.disabled files: https://github.com/SeattleTestbed/seash/blob/master/tests/ut_seash_allmodules.py#L21-L23 .
@Ashmita89, can you take it from here?


Feliz.Plotly missing files

Description
Adding a reference to Feliz.Plotly causes my project to fail to compile.
Steps to reproduce

Make a new project by cloning the elmish-getting-started template.
Update Feliz dependencies to latest version.
Use femto to add reference to Feliz.Plotly.
Add ifly-loader dependency to webpack config.
npm start.
See error:

ERROR in ./src/Saves.fsproj
Module build failed (from ./node_modules/fable-loader/index.js):
Error: File does not exist: C:/code/saves/.fable/Feliz.Plotly.1.0.1/Props/*.fs
    at C:\code\saves\node_modules\fable-loader\index.js:98:22
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

Pre-packaged repro is here. Run npm i and then npm start.
Expected behavior
No error, should still show the elmish-getting-started app (since I haven't yet added any code that actually uses Feliz.Plotly).

Known workaround
Use Feliz.Plotly 0.22.0 instead of 1.0.x.

Hi @MaxWilson, you scared me! I thought it was because I used a backslash in my path instead of a / for the property directory. Turns out both work.
This happened because the PR I did to add globbing support for the fable compiler was after the current version you have installed, and I didn't get around to updating the package with it until 1.0.
Changing these lines:
"fable-compiler": "^2.4.16",
"fable-loader": "^2.1.8",

to this:
"fable-compiler": "^2",
"fable-loader": "^2",

Allowed the build to succeed and show the graph.

(Aside: I'm not sure what you mean about backslashes. In the context of dir on windows, forward slash doesn't work with wildcards, only backslash does. Forward slash only works with exact file paths.)
Thank you, now I understand the error, and the fix you suggested works for me. Closing the issue.

The paths in the .fsproj are parsed by the fable compiler to determine what files to look for, I jumped to conclusions that it was because of a backslash instead of forward slash as a potential reason because I knew the feature worked.
Anyways, glad you were able to get it resolved! :)


Rebrand aesthetics

This PR re-skins BogoBogo. Opting out the dark theme for a lighter purple aesthetic.

Codecov Report

Merging #195 (227287f) into master (267a041) will increase coverage by 2.98%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master     #195      +/-   ##
============================================
+ Coverage     71.44%   74.42%   +2.98%
- Complexity      739      769      +30
============================================
  Files            99       99
  Lines          2150     2170      +20
  Branches        298      305       +7
============================================
+ Hits           1536     1615      +79
+ Misses          497      431      -66
- Partials        117      124       +7

Impacted Files
Coverage Δ

...ain/java/seedu/address/model/display/ItemCard.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/item/Item.java
65.15% <100.00%> (ø)

src/main/java/seedu/address/model/BookKeeping.java
78.78% <0.00%> (-21.22%)
:arrow_down:

...main/java/seedu/address/model/TransactionList.java
78.94% <0.00%> (-21.06%)
:arrow_down:

...a/seedu/address/model/order/TransactionRecord.java
83.33% <0.00%> (-8.98%)
:arrow_down:

.../java/seedu/address/model/display/DisplayList.java
73.07% <0.00%> (-7.70%)
:arrow_down:

.../address/logic/parser/AddToOrderCommandParser.java
70.00% <0.00%> (-2.73%)
:arrow_down:

.../seedu/address/logic/parser/ArgumentTokenizer.java
96.96% <0.00%> (-0.40%)
:arrow_down:

...rc/main/java/seedu/address/model/ModelManager.java
85.29% <0.00%> (ø)

.../seedu/address/logic/parser/FindCommandParser.java
90.47% <0.00%> (ø)

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 267a041...227287f. Read the comment docs.


add Slave_IO_Running and Slave_SQL_Running to MySQLCollector

I hacked them in by adding 'Slave_IO_Running' , 'Slave_SQL_Running' to _GAUGE_KEYS
The values of them are either Yes or No, so I converted to 1 or 0:
Add the following lines right above the line: metrics['slave'][key] = float(row_slave[key])
if row_slave[key] == "Yes": row_slave[key] = 1
if row_slave[key] == "No": row_slave[key] = 0

This repo has moved to https://github.com/python-diamond/Diamond
Please open a new ticket there if this issue is not resolved with the current code there.
Thanks!


fix: updateProjectVersion (updatePom) adds newline between every node…

… on each run
Refs: https://github.com/semantic-gitlog/maven-semantic-gitlog/issues/16

Also noticed this bug with this plugin, verified.


FRR: squash advertisements with the same prefix

Passing multiple advertisements with the same prefix to the template
causes duplicate entries. This happens for example when the shared ip
annotation is used with the services.
Since a given advertisement has the related peers as fields, the right
place to squash is when we manage the advertisements related to a given
neighbor.
non clean backport of https://github.com/openshift/metallb/pull/174

/jira cherry-pick OCPBUGS-33759

/lgtm

/label backport-risk-assessed

/jira refresh

/label cherry-pick-approved


[Feature]: Develop Diagnosis script to check possible failures

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
A script which helps in running diagnosis incase of downtimes
Why should this be worked on?
Helps in pin pointing problems and helps in faster resolution
### Tasks
- [ ] Determine data points desired to be captured. These data points include -- but may not be limited to -- component configuration settings, logs and status and relevant system configuration settings, logs and status. Ideally the tooling should be a single script smart enough to be portable across platforms irrespective of deployment methodology.
- [ ] Create tooling to parse gathered data for known mis-configurations, known bugs and common errors, with the ability to rapidly add further tests and analysis and expand the scope of error detection.

this is in progress with pull https://github.com/appsmithorg/appsmith/pull/35640

this was completed and pull request has been pending so just been awaiting. closing as completed as it is simply awaiting to be merged.

actually, as this is  an epic and we will undoubtedly be making enhancements, i will leave it open so as to track further work

pushed to production


"Măgura", "Crihan", "Dealu Mare", "Sohodol" are villages in "Măgura" common, "BACĂU" county

Description : When user is typing the villages in the search bar, the locations should appear in the dropdown menu correctly spelled and with localities information (as in Law nr. 2 din 16 februarie 1968)
Preconditions : the website (https://peviitor-ro.github.io/ui.orase/) is up and runing.
After every step delete the text you typed from the search bar.

Steps 1: Click on the search bar and write "Măgura"
Expected result: In the drop down menu you find "Măgura, Bacău"

Steps 2: Click on the search bar and write "Crihan"
Expected result: In the drop down menu you find "Crihan, Bacău (Măgura)"

Steps 3: Click on the search bar and write "Dealu Mare"
Expected result: In the drop down menu you find "Dealu Mare, Bacău (Măgura)"

Steps 4: Click on the search bar and write "Sohodol"
Expected result: In the drop down menu you find "Sohodol, Bacău (Măgura)"


Hello, I'm new to docker. How easy would it be to add the $PORT env variable as a configuration parameter ? Thanks

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hey @apostolou - Unfortunately, that question doesn't quite make sense without more context. If you're looking to modify the port that the container exposes on the host, then you can pretty easily do that using standard docker port mapping (the -p flag on the command line).


calico/kube-controllers:v3.25.1 docker image appears to contain stale binary

Expected Behavior / Current Behavior
When testing official 3.25.1 patch release with https://github.com/projectcalico/calico/pull/7503 bugfix we've observed the issue persisted. However our private build made from the same tag 3.25.1 did not exhibit the same issue. I've dug in some more and it appears the binary packaged in docker.io/calico/kube-controllers:v3.25.1 contains code that I removed in https://github.com/projectcalico/calico/pull/7503:
> strings usr/bin/kube-controllers |grep OnKubernetesPodDeleted
OnKubernetesPodDeleted
github.com/projectcalico/calico/kube-controllers/pkg/controllers/node.(*ipamController).OnKubernetesPodDeleted
github.com/projectcalico/calico/kube-controllers/pkg/controllers/node.(*ipamController).OnKubernetesPodDeleted

> strings usr/bin/kube-controllers |grep OnKubernetesPodUpdated
OnKubernetesPodUpdated
github.com/projectcalico/calico/kube-controllers/pkg/controllers/node.(*ipamController).OnKubernetesPodUpdated
github.com/projectcalico/calico/kube-controllers/pkg/controllers/node.(*ipamController).OnKubernetesPodUpdated

If you look at the changeset https://github.com/projectcalico/calico/pull/7503 these methods are removed and https://github.com/projectcalico/calico/commit/c5750290c174f4d3a97ab19c881f86ab06c948e1 is currently tagged with https://github.com/projectcalico/calico/commits/v3.25.1 but somehow the code still appears in the docker image.
Given the above I'm suspecting suspecting something went wrong with the build process. Perhaps the tag was moved after the patch release build completed? cc @caseydavenport
Possible Solution
Not really sure. Perhaps rerun the build pipeline and make sure the commands bellow no longer show dead/removed code.
Steps to Reproduce (for bugs)
docker pull docker.io/calico/kube-controllers:v3.25.1
docker save docker.io/calico/kube-controllers:v3.25.1 > controllers:v3.25.1.tar
tar xvf controllers:v3.25.1.tar
tar xvf<PHONE_NUMBER>7351b0d11d806f4607fa4beb6e71424a2a691cb81f7bc984acef03/layer.tar
strings usr/bin/kube-controllers |grep OnKubernetesPodUpdated
OnKubernetesPodUpdated
github.com/projectcalico/calico/kube-controllers/pkg/controllers/node.(*ipamController).OnKubernetesPodUpdated
github.com/projectcalico/calico/kube-controllers/pkg/controllers/node.(*ipamController).OnKubernetesPodUpdated
# above output shouldn't appear

Your Environment
Linux / amd64

@danudey if we haven't already we should make sure the release notes properly call this out (and remove any release notes for commits that got pushed to v3.25.2)


TTF_MeasureString returns 1 more character than what can fit without harfbaz

Hello, i am really grateful for the work you are putting into SDL3_ttf, i was trying SDL3_ttf, i downloaded freetype from the linked tag, and compiled with it with SDL3_ttf (so no harfbaz), and i noticed TTF_MeasureString was returning 1 more character than could fit, an example below
I am using latest version, so commit 2554dd7 (3 days ago), also using the same version of freetype that is linked to this repository
#include <iostream>
#include <cassert>
#include <SDL3_ttf/SDL_ttf.h>
#include <string>

int main()
{
	bool init = TTF_Init();
	assert(init);

	TTF_Font* font = TTF_OpenFont("FreeSans.ttf", 16);
	assert(font);

	int measured_width;
	size_t measured_length;
	std::string str{ "ABCD" };
	bool success = TTF_MeasureString(font, str.c_str(), str.size(), 1, &measured_width, &measured_length);
	assert(success);

	std::cout << "width = " << measured_width << '\n';
	std::cout << "length = " << measured_length << '\n';
}

what is printed is width = 0 and length = 1 , for 1 pixel i expected 0 characters to be possible, i tried different fonts and got the same result.
i am using windows with MSVC verion 19.39.33523 (though i think the issue doesn't seem compiler specific)
i tried tracking down what may have caused this and this commit 40e606f seems to remove a comment with // The last character didn't fit along with the line that subtracts 1 from the result in that function, so ... maybe that's causing this issue ? i can't tell for sure.
using SDL3_TTF with harfbaz correctly produces width = 0 and length = 0 , so the issue is specific to using freetype implementation, i will use harfbaz for now so this is not a blocking issue for me.
using Roboto-Regular.ttf font also gives the same result if you want a lightweight font to test with.

Fixed, thanks!


feature: onErrorRetry - disable retry if e.g. status is 404

https://swr.vercel.app/docs/error-handling#error-retry
First part of the implementation in https://github.com/Kong/swrv/issues/53

Came here to request the same thing!


Error optimizing Maki icons

After optimizing (SVGO 5.0.1, all defaults) Maki icons many of them has been crashed. (Each icon has been optimized separately, before building icon set.)

SVG set from original SVG files (SVG set created only with nodes manipulation without any transformation)

v0.5.2 with the fix has been just released.

It's awesome! Thank you very much!


Tag organisations with self in search results

Currently organisation pages are not tagged with themselves as organisations.
This causes odd behaviour when using facetted search: searching for HMRC will show the organisation page as the first result, but that org page disappears when selecting HMRC in the organisations filter.
Compare:
https://www.gov.uk/search?q=hmrc
https://www.gov.uk/search?q=hmrc&filter_organisations[]=hm-revenue-customs
Also tags the page with the parent organisation, so that child agencies like the Valuation Office Agency are also included in search results for HMRC.
Before

After

Trello: https://trello.com/c/2sOGuAhF/285-organisations-not-indexed-under-organisations

Offline :+1: from Ben!


When bot detector is set to launch TF2 on tool start, does not check if TF2 is running first

If TF2 is opened by TF2BD, then TF2BD is closed and reopened TF2BD attempts to start hl2.exe a second time. TF2BD then waits for the user to close the source warning pop up and continues on to function normally. This seems to only happen when TF2BD is set to launch TF2 automatically.

https://github.com/PazerOP/tf2_bot_detector/blob/8f42acd8fdb8245de54559ea072a754ae5dfd07a/tf2_bot_detector/SetupFlow/TF2CommandLinePage.cpp#L315
should probably check if tf2 is running first

I would like to say that the issue persists as of <IP_ADDRESS>0 if TF2 is already launched but not via TF2BD as it seems to complain for a brief moment that it couldn't find the arguments before going back to the main screen when the source warning pops up

I mean, you do have to launch tf2 via tf2bd. Maybe some kind of warning is in order

Hopefully that should resolve all of these issues. If not, leave another message here.


Delete Action is NOT working in "grid" view at any controller

Laravel Version: 5.8
PHP Version: PHP 7.1.33
Laravel-admin: 1.7.8

Description:
So far this has been an issue that we were unable to resolve or even determine the reason behind it, clicking the "Delete" action from the drop-down menu for any row at any Admin CRUD controller will result in displaying the confirmation "swal" modal without actually making a call or redirecting to the delete resource url, this behavior has been observed only in "grid" view
Steps To Reproduce:

Create / Open any admin controller that implements the modal grid functionality
Click on the actions menu trigger icon on the side of the row
Click delete from the displayed drop-down
Confirm the action by clicking "submit"
Nothing happens!

Here is a screenshot of the issue:

Any error in console ?

No nothing at all!

Any updates regarding this?

By the way, I think the handle method is never called,
I assumed so since I tried to make a custom action and its handle method is never called as well, so this means the handle method is never called via JS code in the UI for some reason.
I'd be happy to help with closing this issue just point me in the direction and I'll try to fix it and make a pull request, thanks again..

@z-song Please, I need this fixed ASAP, any updates?

You need to give more information. Please put some code...
First of all debug the swal - what is the js code for it in the view source

Hello everyone,
this might be a bit late, but it might be handy for anyone facing a similar issue with using the new actions which implements $.admin.swal({..}).
I've narrowed down the reasons behind this issue, which is primarily because there isn't any request data sanitization before sending the request, at the buildActionPromise() method which can be located at Dialog.php:L187.
The reason in my case this variable got polluted with an unnecessary property plugin_ripples, which is the result of using the material UI extensions jxlwqq/material-ui, that and using the data object without performing any kind of sanitization before sending the $.ajax({...}) request.
How I fixed the issue is by simply omitting the plugin_ripples property, a more final solution should simply dictate which properties can be sent for any performed ajax request, such that all properties that negates that rule should simply be omitted from request body data, which should allow for more flexibility using any extensions designed to work with Laravel Admin.
Please note that I'm using Laravel version 5.8, and Laravel Admin version 1.7.
Here is a detailed look at the changes I did to Dialog.php's buildActionPromise() method:
    /**
     * @return string
     */
    protected function buildActionPromise()
    {
        call_user_func([$this->action, 'dialog']);

        $route = $this->action->getHandleRoute();
        $settings = $this->formatSettings();
        $calledClass = $this->action->getCalledClass();

        if ($this->uploadFile) {
            return $this->buildUploadFileActionPromise($settings, $calledClass, $route);
        }

        return <<<PROMISE
        var process = $.admin.swal({
            {$settings},
            preConfirm: function(input) {
                return new Promise(function(resolve, reject) {
                    Object.assign(data, {
                        _token: $.admin.token,
                        _action: '$calledClass',
                        _input: input,
                    });

                    data.plugin_ripples && delete data.plugin_ripples;

                    $.ajax({
                        method: '{$this->action->getMethod()}',
                        url: '$route',
                        data: data,
                        success: function (data) {
                            resolve(data);
                        },
                        error:function(request){
                            reject(request);
                        }
                    });
                });
            }
        }).then(function(result) {
            if (typeof result.dismiss !== 'undefined') {
                return Promise.reject();
            }

            if (typeof result.status === "boolean") {
                var response = result;
            } else {
                var response = result.value;
            }

            return [response, target];
        });
PROMISE;
    }

Thanks yall for your concern, I'll create a final solution for similar issues, and make a pull request very soon.
Stay safe everyone <3

in my case, i'm writing class in models with snake case (my_class), so as u can see, laravel-admin getting a wrong path model, with underscore changed to '/' so what i did was changing the snake case class in model with camel case(MyClass), and everything works fine ! hope it helps someone !


Backgammon PubEval bot

Looking for some guidance - keen to implement the backgammon PubEval bot for benchmarking backgammon game performance. The original code is in C++ and would rather implement in this if possible, but all the existing bots are written in Python - is it possible to write a C++ bot, or is there a smarter way of doing this?
I can convert the code to Python if necessary, but just want to know if there are other options first.

Hi @jamesdfrost ! It is perfectly fine to have C++ bots; that's why we have the both API in C++ and the Pyhon one wraps it. It would be far more appropriate to write a C++ bot since it would be wrapping C/C++ anyway, so having it be a C++ bot is the best way forward IMO.
Absolutely no need to convert anything to Python! (And if we ever need to expose it through Python, that will be very easy; we'd just need to add a bot loader that can load the C++ bots and hand them over as a Python PyBot object that internally just runs the C++ functions.. that's simple.)
I think we currently don't have many C++ bots (only uniform?) so it's not clear where to put it, maybe the best place would be a top-level bots/ dir to mirror the python subdir.

BTW two questions:

Do we know that PubEval compiles using modern compilers on its own?
What's the license it uses?

The C++ code is really simple, and should be no problem to compile, its basically an implementation of a hard coded feed forward neural network with pre-configured weights, using the raw board position as inputs with P1 pieces as +ve integers and P2 pieces as negative.
In terms of license, Tesauro published this as "Source code is now publicly available" in 1993, link below, before the time of open source licenses. I'm presuming this is OK to use for this project, but interested in views.
https://bkgm.com/rgb/rgb.cgi?view+610

I'm just starting to look into the implementation of this. PubEval is based on evaluating the strength of a particular state, rather than an action, so what I'm going to need to do is get a full list of all the possible next states following a dice roll, and then pick the state with the highest value.
Is there an easy way of getting a list of next possible states from a game, or is this something I'll need to implement within backgammon.cc? Just looking for the cleanest and most "OpenSpiel" way of doing this.
I've also been playing with the DQN algorithm and backgammon, and not getting great results (episode rewards <0.1 against a random opponent, and in some cases negative) so also keen to implement a search based backup operator with a value net (similar to DQN approach but with state values rather than action values, as per @lanctot suggestion here: https://github.com/deepmind/open_spiel/issues/58#issuecomment-532412871) which would also benefit from this.

Hi @jamesdfrost , closing this one now as it's been open for a while and I want to use the Issues for actual outstanding issues.


[594] Adding unit test for header component

Story / Bug id: https://github.com/CodeForPoznan/volontulo/issues/594
Reference person: @w1stler
Description:
Adding unit tests for header component.

That's not Angular component tests.


Add support to record numa_node_count in metadata. Also ... when retrying remote commands, retries appear as "INFO" intead of "ERROR" in the output.

FYI:  this is a backport from an internal change


add dummy .pre-commit-config.yaml

ref. https://github.com/stack-of-tasks/pinocchio/pull/1629 (also for the loco-3d organization)

This tool mainly help to run other tools. It comes with some simple hooks : https://pre-commit.com/hooks.html but you can add any tool you want. And we intend to to that with clang-format and black (which is replacing yapf…)

This is boring… All versions above 3.7.0 are fine, including 4.0.0, but it looks like we can't tell that to CMake.
So we could either consider that 3.7.0 is old enough and drop the number in the requirements, or handle this manually. I tried the second option in a couple places, like : https://github.com/humanoid-path-planner/hpp-environments/pull/24/commits/ad545a1eb3802452dd1d710c2b897f21bf93b23b

But for the particular case of #1059, we might need to bump this requirement to 4.0.0 in crocoddyl anyway ^^"

But for the particular case of #1059, we might need to bump this requirement to 4.0.0 in crocoddyl anyway ^^"

Then, in our case, it seems better to go consider 4.0.0 as the required version (rather than manually handling it).
We just need to release this version first. Also to be able to merge #1059.
Perhaps, let's try to merge this PR first.

Then, in our case, it seems better to go consider 4.0.0 as the required version (rather than manually handling it).
We just need to release this version first. Also to be able to merge https://github.com/loco-3d/crocoddyl/pull/1059.

jrl-cmakemodules has been fixed in the meantime and bumping it and fixing the CMakeLists to accept AnyNewerVersion will resolve the issue :-)

Exactly, and 4.0.1 has been released to include this fix

The CI looks happy now, and I installed pre-commit.ci on the loco-3d.

Exactly, and 4.0.1 has been released to include this fix

Are you talking about example-robot-data?
If so, why I don't see this version is released here: http://robotpkg.openrobots.org/robotpkg/robots/example-robot-data/index.html?

Because I'm really late on robotpkg


default	16:39:37.829679-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Skipping AppNap state - not lifecycle managed
default	16:39:37.907046-0400	runningboardd	Invalidating assertion<PHONE_NUMBER> (target:[daemon<com.apple.Dock.agent(501)>:2470]) from originator [daemon<com.apple.WindowServer(88)>:394]
default	16:39:38.024341-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Ignoring jetsam update because this process is not memory-managed
default	16:39:38.024780-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Ignoring suspend because this process is not lifecycle managed
default	16:39:38.025316-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Ignoring GPU update because this process is not GPU managed
default	16:39:38.026043-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Skipping AppNap state - not lifecycle managed

Any ideas?

bump

@mrchoc I've got the same hardware (MacBook Air, M1) running 12.3 and it's working fine for me. Maybe have another go at it from the top?

@mrchoc I've got the same hardware (MacBook Air, M1) running 12.3 and it's working fine for me. Maybe have another go at it from the top?
Okay yabai mostly works now, but for some apps they dont seem to respond to yabai -m window --swap or yabai -m window --toggle zoom-fullscreen, while others like terminal do.

Does space --focus work on apple silicon? For me it would be definitive factor for getting new mac :D

Does space --focus work on apple silicon? For me it would be definitive factor for getting new mac :D

It does. Quick switching is one of the highlights for me.

@mrchoc I've got the same hardware (MacBook Air, M1) running 12.3 and it's working fine for me. Maybe have another go at it from the top?

Okay yabai mostly works now, but for some apps(safari, vscode) they dont seem to respond to yabai -m window --swap or yabai -m window --toggle zoom-fullscreen, while others like terminal do. However, yabai -m window --focus does work on safari & vscode.

I managed to find the issue, nothing wrong with yabai. It was karabiner elements messing with the keybinds. So if you encounter a similar issue and use karabiner, try disabling a few complex keybinds.

I am still having this issue on macOS 13 and 14. In both cases, the command sudo yabai --load-sa returns no errors, but there is also absolutely no output in the console when filtering for dock, even after executing pkill dock first. I have SIP disabled with this output:
System Integrity Protection status: unknown (Custom Configuration).

Configuration:
	Apple Internal: disabled
	Kext Signing: enabled
	Filesystem Protections: disabled
	Debugging Restrictions: disabled
	DTrace Restrictions: enabled
	NVRAM Protections: disabled
	BaseSystem Verification: enabled
	Boot-arg Restrictions: disabled
	Kernel Integrity Protections: enabled
	Authenticated Root Requirement: enabled

This is an unsupported configuration, likely to break in the future and leave your machine in an unknown state.

And my boot arguments, as found by nvram -p | grep boot-args are:
boot-args	-arm64e_preview_abi

Yabai has accessibility permissions.
Yabai is functioning in other ways, which leads me to believe it's just the scripting extension not loading completely. My sudoers file is set up properly, I've checked it a hundred times and remade it too. Some functionality that is working is bsp tiling, padding, disabling shadows (!! doesn't this require the scripting addition?), and gaps.
I'm using skhd for hotkeys, but I've also tested the yabai -m space --focus commands on the command line directly, and they execute without error but don't do anything, so I'm sure it's a yabai issue.

I am also having an issue with the scripting addition on macOS Ventura. My SIP is completely disabled, and my boot args are:
boot-args	-arm64e_preview_abi amfi_get_out_of_my_way=0x1 ipc_control_port_options=0

https://github.com/koekeishiya/yabai/issues/1766

Same here:
#!/usr/bin/env bash

sudo yabai -m --load-sa
yabai -m space --focus 2

Output:
yabai-msg: failed to connect to socket..
cannot focus space due to an error with the scripting-addition.


Team 1234 kickoff

Team 1234 kickoff:
Specification:
Create a Streamlit app:
1. Input box (area) for larger texts
2. Call ChatGPT, send the text from the input box.
3.


Files

What is your question?
So when I compile it, where do the files go or are there any files at all?

export folder


Legal problem

I worried about using this repo.
In their terms, they forbid making site which is similar agar.io
https://agar.io/terms.txt
I just wonder and worry.

Ji

Is reverse engineering really illegal? It seems to be very difficult to enforce. Has anyone had any experience with this to inform the discussion?

I don't think anyone sane enough would start a sue or whatever against an open-source clone that doesn't even have official servers (we're not even stealing players, actually some people started playing agar.io because of this repo)...
I vote for ragA.io, by the way :trollface:

It isn't available. :(

You cannot patent an idea. They have no legal right to that idea. You aren't allowed to reverse engineer their software and copy their code, and if they've trademarked the name (which they have not, as far as I know) you aren't allowed to use the name.
Since they've done none of the above, they have no legal right to stop anyone from producing an open source "similar piece of software" to their own.
Even if I made a "Killer's Torah" game which is very similar to Assassin's Creed in every imaginable aspect, but took nothing from their code or graphics and made it all myself, they can't do anything more then sending scary letters which are basically "ask me nicely to take it down".

I think we can close this then.  If it actually becomes an legal issue, we can seek legal advice.  But for now it's a fun open source project.

Good point @MadaraUchiha :+1:
And yeah, agreed @jniles :)

The idea is not a legal issue (esp. since Agar.io is just a multiplayer Osmos) but the name "Agar.io clone" IS a legal issue.

@KAMiKAZOW It is not, because, again, the name is not trademarked. Just because I called my DI library Chusha, doesn't mean you can't do anything with that name anymore, even if I say so in my README or whatever.

Agar and Agar.io are now trademarks btw

That's a good point. I also noticed a few days ago that Agar.IO sent a DCMA Notice to GitHub asking for a repo to be taken down. Perhaps this is something we need to look into now.
https://github.com/github/dmca/blob/master/2015-07-30-Agario.md

We are far different from the guy in the URL above, since we're not steal anything of them (Agar.IO and Miniclip) except the name.
As I remembered few months ago, the above repo contains most of the client code (main.js or something) and rewrite the server.
If naming is the problem, and if Miniclip doesn't feel comfortable with it. I think we should change the repo name, for example: ragA as @IgorAntun said =))
For sure, at this moment, this is just our "for fun" project, and nobody have any plan to make money with it. And I think Miniclip already checked us at the time they sent a DCMA Note to Github.

Btw, we should respect their trademarks.
 Have you even read it? They claim that "adding in-game chat" and "multi-server support" infringes them, as if they invented those features. The shape of the cells as well as most of the gameplay is taken off of Osmos, a game far older than Agario. The only thing they have any sort of merit towards is the name, which may or may not be copyrighted, I haven't checked. For that reason, I vote :+1: here.
Please do not be intimidated into changing the gameplay or any aspects of the clone. They have no real claim over any of them.

how about "petri" as in petri dish

The name is trademarked in the US by Miniclip, so changing it would probably be a good idea. But yeah I don't believe we have any reason to change functionality.

Yeah, we only considering about the name. And we will not change any game functionality.

OK guys, we will close this issue for now.


Getting started with Embark

I want to try this tool, but i got stuck on getting it up and running.

I Created a hyper-VM, and installed linux kali on it.
I cloned the embark repository
And I started the installer from whitin the embark directory:
sudo ./installer.sh -F
The next step should be registering a new user, but there's nothing listening on port 80
What am I missing here?

We are happy that you want to use it. Can you please share the output of the installation process?
Additional the output of docker-compose ps would be helpful.
Maybe there is a bit of a hiccup and you have to restart all docker-compose containers: docker-compose restart.

I'm sorry I don't have the output of the installation process anymore.
In the meantime I installed emba, and I have the first firmware check running!
I will retry embark at a latter stage.
Thank you

Have fun testing with EMBA - we hope you will find many interesting stuff ;)
Please don't hesitate to open a new issue, if something is wrong or a pull request, if you want to add new features.
I will close this one now. Have a nice day.


Improve user facing messages: list of invoked validators

Feature request
This description was edited by @isabelle-dr on 2022-05-05
Is your feature request related to a problem? Please describe.
The user facing messages that print in the terminal during validation are currently confusing because they often imply that something might have gone wrong when it's not the case.
If any of the existing validator (in the sense of a validator.java file) didn't run, the user gets the following message:

There are two problems:

the MISSING_FILE statement should only appear for required files. Right now it implies that the user need to add all these files but they are optional.
the !!! PARSING FAILED !!! statement should not appear when everything runs properly. If an optional file/field isn't present in the dataset, the validator that is based on it doesn't run (which is normal), so we should't give such warning to the user.

What is important to flag is if something happened that would compromise the validator integrity (I can't trust this report). That would happen when a validator should have run but didn't (this seems to have happened in issue 1089, and we opened issue #1096 to troubleshoot why. This could be because it wasn't invoked at all, or that it didn't run because it encountered an issue (e. g. a validator that is dependant on the time fields being properly formatted, or a validator that couldn't find the field name it was looking for)
Proposed solution
This would need further thinking and discussion but the solution could look like:

Remove the MISSING_FILE statement for optional files
Create a list of validators that should be invoked based on the dataset files & fields, and log a list of validators that have run.
If there is a discrepancy between the two lists, print a message that mentions that the validation report may be compromised, and print the name of the validators that should have run.

We might need to implement https://github.com/MobilityData/gtfs-validator/issues/1098 before we can do this.
Additional context
https://github.com/MobilityData/gtfs-validator/issues/1098

Related to #1097 and #1096


Disable swap on slippage

Slip percentage is shown
if it's higher than slip tolerance it gets red and disables swap button

Closes #1105

Some tweaks needed:

Label of selected slippage tolerance has not been updated - it stick with 0.00%
Show "hand" courser (pointer) by hovering items select box
Make gear icon small (check layout at Figma)
Update color by hovering gear icon to "dark" grey

https://user-images.githubusercontent.com/61792675/126304092-76ac1254-8e58-4c84-b7b6-0281b73638e1.mp4

Last (small) change requests:

Fix React warning such as React does not recognize the isCausedSlippage prop on a DOM element. or Received false for a non-boolean attribute 'active'

Show mouse cursor while hovering gear icon. Increase area to react a mouse hover.

https://user-images.githubusercontent.com/61792675/127853601-ce928391-68f9-445b-94ae-648aeb1b7a61.mp4


Add ECMAScript 2020 features?

@babel/plugin-proposal-nullish-coalescing-operator and @babel/plugin-proposal-optional-chaining were just added to @babel/preset-env with the release of 7.8.0 — should they also make an appearance here?

I updated our preset to 7.8, and when the preset-modules is enabled, optional chaining and nullish coalescing are not transformed anymore, while they should.

@rdmurphy I think these make more sense to be handled via preset-env. Currently, preset-modules transforms only syntax that is broken in modern browsers, not syntax that has varying degrees of support. This is the same reason preset-modules doesn't currently include transforms for class fields.
That being said, if we're looking to bridge the gap until preset-env landing the modules fixes, perhaps it'd be worth bringing in these transforms.

Note that the inline helper (it's not a polyfill) it's just an optimization: it will make your code shorter if you use 3-4+ class fields, and uses [[Set]] instead of Object.defineProperty (which is more expensive) when it's not observable.

It’s not stage 4, but it’s stage 3 and shipping in browsers.

Optional chaining and nullish coalescing are standard / stage 4.
Class fields are stage 3, and shipping in browsers, which is a more important milestone for Babel imo than the stage.

Alright, spent an hour putting together a dedicated plugin for class fields. Not sure what I'll end up doing with it, but for those interested here it is:
https://astexplorer.net/#/gist/31dbcb25cfb4b322ce10591a3cd2daaf/3bb90ae34957cee457f862de6beb54864d483392
For me this solves an issue where including plugin-proposal-class-properties produces ES5 class output since I'm not using preset-env.
@nicolo-ribaudo good point about the helper being a helper and not a polyfill. I've included a somewhat naive compile-time version of that logic in this alternative plugin, curious to have folks poke holes in that approach. It fails for assignment to this in inherited classes, as well as for dynamic property assignment (this[window.whatever]=2).

Class fields are stage 3, and shipping in browsers, which is a more important milestone for Babel imo than the stage.

preset-env has the shippedProposals option, for proposals which are not part of the specification yet but are already shipped in at least one browser/node. We should probably add class-fields to that option.
@developit Looking at your plugin, I think that you misinterpreted the reason for using the optimized [[Set]] in the plugin.
Object.defineProperty is unrelated to this.bar = 2 in the constructor: it's needed when there is a setter on the prototype of the class (almost always coming from a superclass) because the setter shouldn't be triggered. This isn't statically analyzable, because almost always the base and derived classes are in two different files.
Also, the descriptor you pass to defineProperty must have the enumerable: true, configurable: true, writable: true properties.
I don't think that it's possible to make a spec-compliant version of the plugin smaller than the current one, and if someone isn't concerned with spec compliancy in the [[Set]] vs [[Define]] case they can already enable loose mode, which produces this output:
class A extends B {
  x = 2;
}

// ->

class A extends B {
  constructor(...args) {
    super(...args);
    this.x = 2;
  }
}

@nicolo-ribaudo indeed, the approach in my link is over-simplified.


Can I get body data from GET request?

Problem/Feature Request Summary

I need get body data from GET request
Environment Information

koa-body: 4.1.0
Koa: 2.7.0
Node.js: 10.15.3

Current Behavior

I can't get body data from GET request. I don't really know koa supported that or from koa-body library.
Steps to Reproduce

I call GET request from postman with body is raw json and header has Content-Type is application/json.
In node server, I show 3 variables is ctx.body, ctx.requests.body and ctx and all of them don't have or containt any data in body request

Expected Behavior

I can get body data from GET request
Possible Solution

Change data from body to param and make get request become post request in server.
But that will change every my client code.
Context (Environment)

Are you disabling strict mode, or adding GET to the parsedMethods array?  GET is not body-parsed by default.
Reference the options in the readme.


Adding Information about potential ManagedRule Groups Changes

Sometimes it may happen that new versions of a Managed Rule Group will be released. If you use a specific version in your WAF it would be nice if we would be informed when a new planned Change occur in the next time.
See:
https://docs.aws.amazon.com/waf/latest/developerguide/waf-using-managed-rule-groups-sns-topic.html

released in https://github.com/globaldatanet/aws-firewall-factory/releases/tag/4.1.1


Add manual test for CronJob of volumes that are detached for a long time

longhorn/longhorn#2513

This test case looks good to me and its steps had been verified with v1.1.2-head(0615)
@khushboo-rancher Please kindly approve this one


PR comment user tagging bug, users not found

Description
When I type @ in pr comment (or elsewhere) I cannot find other members. Only myself and teams
Gitea Version
1.23.0+dev-743-g171edfc793
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
docker
Database
None

Does 1.22 have the same behavior? Is it a regression?

->  Fix mentionable users when writing issue comments #32715


Live server not working

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

No

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines.
Happy Coding!