Details on using Managed Identity, rather than connection

It'd be useful to have details on the process of using Managed Identity for AuthN/AuthZ , similar to the page for Functions ... https://docs.microsoft.com/en-us/azure/logic-apps/logic-apps-azure-functions#enable-authentication-for-azure-functions
Ala ... https://adatum.no/azure/azure-logic-apps/access-to-blob-storage-using-managed-identity-in-logic-apps

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bc1a51f6-730a-6077-6f9d-90afeaceed20
Version Independent ID: 6d012a9a-5fbd-fd18-9656-c42e88bac5d0
Content: Connect to Azure Blob Storage - Azure Logic Apps
Content Source: articles/connectors/connectors-create-api-azureblobstorage.md
Service: logic-apps
GitHub Login: @ecfan
Microsoft Alias: estfan

@steveculshaw Thank you for your feedback! We have assigned this issue to the author to review further and take the right course of action.

Hi @steveculshaw, thanks for submitting this feedback. This Blob Storage connector topic has a section about using managed identities for accessing Azure Blob Storage. The section points at the more generic topic for how to set up managed identity support on your logic app and then how to use the managed identity, for example, through an HTTP action that connects to an Azure Blob Storage account.
The steps to enable and use a managed identity are relatively generic, so they're not repeated in every connector topic that supports managed identities. Was there something more specific or other info that you're looking to find?

Hi @steveculshaw, given that we haven't heard back, we'll resolve this issue as closed. If you have future questions, feel free to reopen, thanks!
@mike-urnun-msft: #please-close


Create an AWS account

User Stories

As a developer, I want to be able to view the management console in AWS.
As a developer, I want to manage my IAM role.
As a developer, I want to set up a billing alert.

Created my AWS account, setup my IAM and billing alerts, and installed AWS-CLI


REST: unset verbs for restricted actions

If we restrict some actions in rest controller by using yii\rest\UrlRule::$only or yii\rest\UrlRule::$except, or by unsetting them from yii\rest\ActiveController::actions(), why not unset related options from yii\rest\OptionsAction? So API consumer can retreive only allowed HTTP verbs by sending OPTIONS request.

You mean doing it automatically? Not sure how this could be done, can you propose some code change?

somehow related to #5850

Yes, I mean automatically. Didn't try to implement this yet.

+1 , gonna save a lot of time handling the allowed verbs and actions

Closing due to inactivity. If this should be reopen please write here.


Feat/private ip during microos install

refactor: moving the shell scripting of the server installation outside of the hcloud_server block.
All the remote-exec blocks are now in a null-resource, instead of immediately in the hcloud_server block. The benefit is that now the private ip can be assigned (in the subnet) before microos is installed. With the current code base that has zero impact, but it opens up the possibility to ho to communicate safely in the private network at the installation stage already.

Hm, after actually testing this, the private ip is not know in the actual host during its rescue boot (the phase where microos is installed). Bummer, I was hopping to redistribute the microos image through the private network, descreasing the number of downloads.

@valkenburg-prevue-ch Interesting take, but please have a look at what @ifeulner is working on to fix the download issues. Though packer, super-duper elegant!
You actually download on localhost and create a snapshot in your project before the terraform stage. This will be a game-changer! More info here https://github.com/kube-hetzner/terraform-hcloud-kube-hetzner/issues/535#issuecomment-1403728279

I actually use that packer project to deploy MicroOS instances for docker-compose use and it runs amazingly well.

Ah yes, I should have checked that one more closely. Will use it. I was under the impression (my mistake) that it would become a part of this project's initialization, but I understand it will always be outside of it, and it will be a manual task.

Wait, but there is no flag in kube-hetzner yet to use a custom snapshot instead of running the whole microos-triple-reboot dance, right?

Wait, but there is no flag in kube-hetzner yet to use a custom snapshot instead of running the whole microos-triple-reboot dance, right?

It's a work in progress by @ifeulner . I assume it will be integrated into kube-hetzner and used as a single primary way of installing MicroOS.

Exactly @aleksasiriski, @valkenburg-prevue-ch He's working on it. The separate repo was just a proof of concept to launch the snapshot.
But the integration with terraform comes is being worked on for v2.0. I am sure that he will share more as soon as he can, and we can all help him tune this up!

@valkenburg-prevue-ch Turning it into a draft for now, feel free to close or re-activate it.


Does netopeer2 send a notification, yang-library-update, when a module is removed/disabled in sysrepo?

Hi,
We need to test this RFC:
https://datatracker.ietf.org/doc/rfc8525/
Before I create a test case I wonder if the following scenario is supported in Netopeer2:
Our NETCONF client have an open session to netopeer2 and we make a change on the module ( remove or disable) in sysrepo.
Client wait for a notifcation, yang-library-update, and when notifcation is received we read data from yang-library module again.
These are the modules:
# sysrepoctl --list
Sysrepo repository: /etc/sysrepo

Module Name                | Revision   | Flags | Owner     | Permissions | Submodules | Features
----------------------------------------------------------------------------------------------------------------------------------------------------------------
iana-crypt-hash            | 2014-08-06 | i     |           |             |            |
ietf-crypto-types          | 2019-07-02 | I     | root:root | 600         |            |
ietf-datastores            | 2018-02-14 | I     | root:root | 600         |            |
ietf-inet-types            | 2013-07-15 | i     |           |             |            |
ietf-keystore              | 2019-07-02 | I     | root:root | 600         |            | keystore-supported
ietf-netconf               | 2013-09-29 | I     | root:root | 600         |            | writable-running candidate rollback-on-error validate startup url xpath
ietf-netconf-acm           | 2018-02-14 | I     | root:root | 600         |            |
ietf-netconf-monitoring    | 2010-10-04 | I     | root:root | 600         |            |
ietf-netconf-nmda          | 2019-01-07 | I     | root:root | 600         |            | origin with-defaults
ietf-netconf-notifications | 2012-02-06 | I     | root:root | 600         |            |
ietf-netconf-server        | 2019-07-02 | I     | root:root | 600         |            | ssh-listen tls-listen ssh-call-home tls-call-home
ietf-netconf-with-defaults | 2011-06-01 | I     | root:root | 600         |            |
ietf-origin                | 2018-02-14 | I     | root:root | 600         |            |
ietf-ssh-common            | 2019-07-02 | i     |           |             |            |
ietf-ssh-server            | 2019-07-02 | I     | root:root | 600         |            | local-client-auth-supported
ietf-tcp-client            | 2019-07-02 | i     |           |             |            |
ietf-tcp-common            | 2019-07-02 | I     | root:root | 600         |            | keepalives-supported
ietf-tcp-server            | 2019-07-02 | i     |           |             |            |
ietf-tls-common            | 2019-07-02 | i     |           |             |            |
ietf-tls-server            | 2019-07-02 | I     | root:root | 600         |            | local-client-auth-supported
ietf-truststore            | 2019-07-02 | I     | root:root | 600         |            | truststore-supported x509-certificates
ietf-x509-cert-to-name     | 2014-12-10 | I     | root:root | 600         |            |
ietf-yang-library          | 2019-01-04 | I     | root:root | 600         |            |
ietf-yang-metadata         | 2016-08-05 | i     |           |             |            |
ietf-yang-types            | 2013-07-15 | i     |           |             |            |
nc-notifications           | 2008-07-14 | I     | root:root | 600         |            |
notifications              | 2008-07-14 | I     | root:root | 600         |            |
sysrepo-monitoring         | 2021-01-15 | I     | root:root | 600         |            |
sysrepo-plugind            | 2020-12-10 | I     | root:root | 600         |            |
yang                       | 2017-02-20 | I     | root:root | 600         |            |

Flags meaning: I - Installed/i - Imported; R - Replay support; N - New/X - Removed/U - Updated; F - Feature changes
Features: ! - Means that the feature is effectively disabled because of its false if-feature(s)

Which operation, remove or disable, module in sysrepo is easiest to perfom and restore?
1.1 Any of these modules that I can perform remove or disable on without giving netopeer2 issues?
1.2 Commands to use ?

Will a notifcation, yang-library-update, be sent in the same NETCONF session ( I have a subscription ongoing for that NETCONF session) to client when module change takes place?

br,
//mikael
Operations in sys-repo:
https://netopeer.liberouter.org/doc/sysrepo/master/html/group__schema__api.html#ga7321be6b965ffc6ca89fee61a806faae
https://netopeer.liberouter.org/doc/sysrepo/master/html/group__schema__api.html#ga7793eebc32a87bc48b340030cde5042c

Makes no difference, they are simple to perform and revert.
1.1. These are all the default server modules so you should not be uninstalling any of those.
1.2. You can use sysrepoctl to perform any YANG modules changes.

No, updating the supported YANG modules in a running NETCONF session is not a supported use-case by NETCONF, it is not mentioned anywhere. And as long as there is a NETCONF session, the server is holding the YANG context lock and any YANG modules changes will fail on a timeout because of this. So no, the session will not get any notification.
I suppose it could be improved to support this, to some extent. It would be possible to implement some internal mechanism of informing about context changes that results in the server updating its context and sending the mentioned notification to all the connected sessions. They could then restart their connection to have the updated context, there is no simple and direct way of doing so without a connection restart (would again have to be some proprietary design and solution). If they don't, they would continue to use the old context, should already be properly handled.

Also just double checking:
And there will be no netconf-capability-change notification when the module is changed?

Right, that can be sent, too. Although it seems to be redundant, the 2 notifications would essentially include the same information.

@michalvasko  and I guess that there is no difference if we use adding a module?

I do not understand the question, difference between what?


ENHANCE AND STRUCTURE THE CONTRIBUTORS SECTION

Has this bug been raised before?

[X] I have checked "open" AND "closed" issues and this is not a duplicate

Description
The Contributors section is a vital component of any open-source project, as it acknowledges and celebrates the individuals who have contributed their time and expertise to the development of the software. Recognizing contributors fosters a sense of community and encourages collaboration, which is essential for the project's growth and sustainability. This section serves not only as a record of contributions but also as an inspiration for others to get involved. By highlighting the diverse talents and backgrounds of contributors, it promotes inclusivity and demonstrates the collective effort that drives the project's success. Additionally, a well-structured Contributors section enhances transparency, allowing users to understand who is behind the project and how they can engage with the community. Overall, it is an important tool for building a supportive ecosystem that values collaboration and continuous improvement.
Steps to Reproduce
Steps to Reproduce
To help us recreate the bug related to Enhancing and Structuring the Contributors Section , follow these steps:

Navigate to the repository:

Open the project repository on GitHub.
Ensure you're on the main page of the repository.

Access the README file:

Scroll down to the README.md file in the repository’s root directory.
Scroll further to locate the Contributors section.

What you were trying to do:

Try to add a new contributor by modifying the section (either by inserting an image, updating names, or changing the layout).
You may attempt to use existing tools (e.g., GitHub profile image links, contrib.rocks, or manual markdown edits) to modify the section.

What went wrong:

After editing, you may notice that the contributors' layout is inconsistent. For example:

Images might not align properly (misaligned avatars or uneven columns).
Some contributor names or links may be missing or incorrectly formatted.
The page’s structure might break due to improper markdown rendering.

Refresh and inspect:

Once the changes are pushed, refresh the page to see the final view of the contributors' section.
Check if all images are displayed correctly, contributor details are intact, and the layout remains consistent.

By following these steps, the bug related to Enhancing and Structuring the Contributors Section should become visible, allowing you to identify where the formatting or display issues occur.
Screenshots
N/A
Do you want to work on this issue?
Yes
If "yes" to the above, please explain how you would technically implement this.
Steps to Reproduce
To help us recreate the bug related to Enhancing and Structuring the Contributors Section , follow the steps below:

Open the project repository on GitHub.
Navigate to the README.md file in the root directory.
Scroll down to the Contributors section of the README.
Observe the current structure of the contributors' list (either using images, links, or plain text).
Attempt to update the section by adding new contributors or modifying the layout.
Notice any issues with layout consistency, image alignment, or missing contributor details.
Push changes and refresh the view in the repository to verify the final display of the contributors.

If any issues arise during steps 5–7, this indicates a problem with the structuring of the contributors' section.

@rohitinu6 ADD LABELS GSSOC EXT 24 AND HACKTOBERFEST AND ASSIGN ME THE TASK.
THANK YOU!


Alluxio/alluxio  [SMALLFIX]Change protected URIStatus mStatus to protected final URIStatus mStatus

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17199/
Test PASSed.


sort keys by default.

Previously lltsv outputed keys in random order when keys were not specified by -k. It's confusing. (On the other hand, this PR changes original behavior.)

Was that random order? I intended to be ordered same with LTSV file.

There is sample output below.
% lltsv --version
lltsv version 0.5.6
% wc -l sample.ltsv
 9497178 sample.ltsv
% cat sample.ltsv | head
uri:/hoge       ptime:0.120     uptime:0.050
uri:/foo        ptime:0.110     uptime:0.030
uri:/hoge       ptime:0.120     uptime:0.050
uri:/foo        ptime:0.110     uptime:0.030
uri:/hoge       ptime:0.120     uptime:0.050
uri:/foo        ptime:0.110     uptime:0.030
uri:/hoge       ptime:0.120     uptime:0.050
uri:/foo        ptime:0.110     uptime:0.030
uri:/hoge       ptime:0.120     uptime:0.050
uri:/foo        ptime:0.110     uptime:0.030
% lltsv sample.ltsv | head
uri:/hoge       ptime:0.120     uptime:0.050
uri:/foo        ptime:0.110     uptime:0.030
uri:/hoge       ptime:0.120     uptime:0.050
uri:/foo        ptime:0.110     uptime:0.030
uri:/hoge       ptime:0.120     uptime:0.050
uri:/foo        ptime:0.110     uptime:0.030
uri:/hoge       ptime:0.120     uptime:0.050
uri:/foo        ptime:0.110     uptime:0.030
uri:/hoge       ptime:0.120     uptime:0.050
uri:/foo        ptime:0.110     uptime:0.030
% lltsv sample.ltsv | head
uri:/hoge       ptime:0.120     uptime:0.050
uri:/foo        ptime:0.110     uptime:0.030
uri:/hoge       ptime:0.120     uptime:0.050
uri:/foo        ptime:0.110     uptime:0.030
ptime:0.120     uptime:0.050    uri:/hoge
uri:/foo        ptime:0.110     uptime:0.030
uptime:0.050    uri:/hoge       ptime:0.120
uri:/foo        ptime:0.110     uptime:0.030
uri:/hoge       ptime:0.120     uptime:0.050
ptime:0.110     uptime:0.030    uri:/foo
%

If keys to output are not specified by -k, keys are possible to be output in random order like above. Because keysInMap() iterates key-map created by LTSV line and creates key-list per line. Unfortunately this key-list is not always ordered even if LTSV file is same. The keys of map are not ordered in Go1.3 or later. The reference is here.
So the keysInMap() creates key-list in random order and lltsv is possible to output records in random order when the keys to output by -k is not specified.
This PR kepts the order of keys in LTSV file constant.

Thank you for clarification. LGTM :+1:

🙇🏻


Please add a license to this repo

First of all, thank you for creating & open-sourcing a new backend for JanusGraph! This is a great contribution to the JanusGraph ecosystem; please consider advertising it (whenever you're ready) on the janusgraph-users@ list.

Could you please add an explicit LICENSE file to the repo so that it's clear under what terms the content is provided, and under what terms user contributions are licensed?
Per GitHub docs on licensing:

[...] without a license, the default copyright laws apply, meaning that you retain all rights to your source code and no one may reproduce, distribute, or create derivative works from your work. If you're creating an open source project, we strongly encourage you to include an open source license.

Thanks!

please consider advertising it
Connector is now being tested in-house on "master record for players accounts" project. Once this project will be live in production we will send email to the group.

Could you please add an explicit

+

Connector is now being tested in-house on "master record for players accounts" project. Once this project will be live in production we will send email to the group.

I would like to ask to also add a comment in this PR when this adapter is production ready. Regards

Sure
Since you might be wondering whats going on: janus graph in "embedded mode" (this means bundled as library into java service, to support local transactions and repository access pattern) on top of aerospike deployed to production in hidden mode. There is traffic mirroring for online service requests and data migration daemon for bi-directional data sync. Since its sensible component for business, gradual opening will take a while in order to avoid any side effects on players.
Additionally we started development of something like "in-game social graph" between players project which uses janus graph+aerospike as well.
So, once first project will go live - I'll resolve this ticket.

https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/janusgraph-users/OC92ovucThw/M8BE_sGcAwAJ

Additionally, looks like a LICENSE file was added in https://github.com/Playtika/aerospike-janusgraph-storage-backend/commit/444a2ff409d50a5b8b768129586287980e90c8e0 — thanks!


What's the recommended pattern to prevent adding duplicated "base" service/option

Our project has common pattern like this:
IServiceCollection AddBaseService(this IServiceCollection services, IConfiguration configuration) => services
    .Configure<BaseServiceOptions>(options =>
    {
        configuration.Bind(BaseServiceOptions.SectionName, options.SomeList);
    })
    .AddSingleton<IBaseService, BaseService>();

IServiceCollection AddServiceA(this IServiceCollection services, IConfiguration configuration) => services
    .AddBaseService(configuration)
    .AddSingleton<IServiceA, ServiceA>();

IServiceCollection AddServiceB(this IServiceCollection services, IConfiguration configuration) => services
    .AddBaseService(configuration)
    .AddSingleton<IServiceB, ServiceB>();

public void ConfigureServices(IServiceCollection services)
{
    services.AddServiceA(Configuration);
    services.AddServiceB(Configuration);
}

It all worked fine until recently we had a problem because of duplicated items in BaseServiceOptions.SomeList (becasue AddBaseService is executed twice). During investigation, we found 2 issues:

BaseService SeviceDescriptor is added twice. It's not a problem since our controller just asks for IBaseService. But if the controller asks for IEnumerable<IBaseService> or we call container.GetServices<IBaseService>, then the same BaseService will be instantiated multiple times.
Since the function name is AddSingleton, I took it for granted it will only instantiate a singleton instance of the same implementation, i.e., BaseService.
What's more, the doc demonstrated AddSingleton of different implementations will instantiate different implementation, which actually makes me believe more that the same implementation will only be instantiated once.

Configure<TOptions>(Action<TOptions>) is executed twice. And since configuration.Bind(string, IEnumerable) append items to the list, we end up have duplicated items in BaseServiceOptions.SomeList and thus had problem somewhere.

I didn't find any examples of having a "base" service that may get added multiple times in the program, so I'm trying to see what's the recommend pattern to solve the above 2 issues. Here is some options that I thought about

For issue 1, change AddSingleton to TryAddSingleton so IBaseService will only be added once for sure.
It's not perfect because if we really want to add different implementations of IBaseService, we have to switch back to AddSingleton, then there is no guarantee the service descriptor of the same implementation will only be added once.

For issue 2
a)  Change configuration.Bind(BaseServiceOptions.SectionName, options.SomeList) to options.SomeList = configuration.GetSection(BaseServiceOptions.SectionName).Get<IEnumerable<string>>(), so the items are not appended. The Configure<TOptions>() is still unnecessarily executed multiple times though.
b) Add a class that implements IConfigureOptions, i.e., ConfigureBaseServiceOptions: IConfigureOptions<BaseServiceOptions> and add it as a service services.TryAddSingleton<IConfigureOptions<BaseServiceOptions>, ConfigureBaseServiceOptions>. This adds complication in code and not the recommended way as documented here.

For both issues, check if the service descriptor exists. This adds complication in code.

static readonly ServiceDescriptor s_baseServiceDescriptor = ServiceDescriptor.Singleton<IBaseService, BaseService>();
IServiceCollection AddBaseService(this IServiceCollection services, IConfiguration configuration)
{
    if (services.contains(s_baseServiceDescriptor))
    {
        return services;
    }

    services.Configure<BaseServiceOptions>(options =>
    {
        configuration.Bind(BaseServiceOptions.SectionName, options.SomeList);
    })
    .AddSingleton<IBaseService, BaseService>();
}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0d78f540-81fd-1ba9-cb90-591e4ec27d9b
Version Independent ID: 2251f557-dd3a-ec35-2558-6243337db009
Content: Dependency injection in ASP.NET Core
Content Source: aspnetcore/fundamentals/dependency-injection.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

I think you're looking for TryAddEnumerable? There are examples of its usage all over that you can take inspiration from https://grep.app/search?q=TryAddEnumerable&filter[repo][0]=dotnet/aspnetcore

Thanks for contacting us. We believe that the question you've raised have been answered. If you still feel a need to continue the discussion, feel free to reopen it and add your comments.

@Rick-Anderson @davidfowl , TryAddEnumerable() addressed the first issue we have.
What about the second issue, i.e., service.Configure<T>(Action<T>) get registered multiple times?
I understand IConfigurationOptions would work, but that adds complication and pretty tedious. i.e., we have to create 2 classes for each option, i.e., MyOptions and MyOptionsSetup : IConfigurationOptions. Ideally there is something like services.TryConfigure<T>(Action<T>) so it only register the callback once, is it ever considered?

Ideally there is something like services.TryConfigure(Action) so it only register the callback once, is it ever considered?

That doesn't exist, you can propose it here https://github.com/dotnet/runtime. (use the API template).

@Rick-Anderson all my questions are addressed, so I'll close the ticket.


Rethink suspend function design

Per explanation from Jake Wharton, the suspend functions as currently implemented don't offer anything useful.
suspend fun SharedPreferences.awaitAll(): Map<String, *> =
    suspendCoroutine { continuation ->
        continuation.resume(all)
    }

To address this, I first need to better understand the purpose of suspendCoroutine; specifically whether it offers anything useful when wrapping a normal (potentially locked) getter as opposed to a callback.
Some options:

Wrap the current function body in withContext(IO) to make sure the calling thread isn't blocked while waiting for the getter. This seems like it should be right, but I haven't been able to write a test that produces different results than the current implementation.
Wrap the normal getter in withContext(IO). This option will make sense if it turns out suspendCoroutine doesn't give me anything here, but running on IO does.
Rewrite the functions to return Deferred<T>. This would be the easiest option, but wouldn't really make calling the functions any easier for consumers than just making the call on their own thread/coroutine. It also may give the false impression that the work is cancellable when it's really not.
Scrap the single value-returning functions completely. This option makes sense if none of the above effectively make asynchronous preference calls any easier for consumers.

For now I'm going with option 4; removing all the suspend functions. I can always add them back later if I figure out a good reason they should exist.


more github actinos

GitHub Actinos status update
Tests now finish in <= 4 minutes

[X] caching cross-platform tests on stable and nightly - every push
[X] caching cross-platform debug builds on stable - every push
[X] cross-platform release builds and tarballs created - tag pushes that start with v
[X] cargofmt - every push
[x] create wranglerjs tarball - every push or just tag pushes?
[x] create github releases - on release

Open questions:
How do we test GitHub releases without... releasing something?

this will create a github release when you push a tag that starts with v
Here's a screenshot of my fork's release page:

we should double check to make sure that each release binary works as expected.
cc @ashleygwilliams for review

Since this builds a release on tag push, should we create them as pre-releases so that they go live when we say they go live or is it fine the way it is.

i feel fine about how it is now, but i'm happy to be persuaded otherwise

Do we need to be targeting MacOS 10.7?

i would focus on the most up-to-date stable macOS only

Do tests compile all of our code/Do we need to build on every push if we're running tests on every push or should we just do the builds for releases?

i think we should just build for releases

this will create a github release when you push a tag that starts with v

the last setup would create a release with any named tag- do we want to change that behavior?


Show language sevrice that caused the error

If an error was caused by a language service, add to error the language service that triggered it.
I recently opened this issue on TS repo https://github.com/microsoft/TypeScript/issues/59295. @RyanCavanaugh identified that this is caused by the nx language service. As we are not all Ryan, it would be great if the service that caused the issue would be added to the error message. It's a small step for the team, a great step for the users

@mjbvz How can I assist on this issue? Is not this related to the typescript extension?

If the exception is from a separate extension, then the diagnostic should have a clear source for this. However I think nx  may actually be a TS Server plugin, which means that the errors actually get reported by TypeScript. There's no way for us as VS Code to know that these errors are not actually TypeScript errors
In these cases, the language plugin should make sure to set source property on the diagnostic. This is part of the TS Server protocol
@Tallyb I think everything is in place on the VS Code side so can you please follow up with the nx extension about this. Feel free to cc me on the issue too if they need more info


Update kong to 1.0.3 in the snap

The snap should be updated to match the docker-compose file for the security-api-gateway and use kong 1.0.3. A few outstanding issues to handle when doing so:

Apparently kong has never worked properly on arm64, silently failing when run with:

ubuntu@ubuntu:~$ sudo kong migrations up --v --yes --conf /var/snap/kong/current/config/kong.conf
PANIC: unprotected error in call to Lua API (bad light userdata pointer)

(more details available in https://github.com/edgexfoundry/blackbox-testing/issues/185)

Kong now has new dependencies such as a yaml library etc. that need to be installed. For reference, looking at the build tools repo here will be useful: https://github.com/Kong/kong-build-tools/tree/feat/multi-arch
The version of perl in the snap after we migrate to core18 is different now so we need a better way to handle running perl inside the snap and setting up those environment variables
Doing the trivial thing and just updating the source-tag somehow breaks the symlinks setup in the snap currently such that somewhere along the line kong tries (and fails) to execute:

ubuntu@ubuntu:~$ kong
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
	LANGUAGE = (unset),
	LC_ALL = (unset),
	LANG = "en_US.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
ERROR: failed to run command "/build/kong/parts/openresty/install/nginx/sbin/nginx -p /tmp/resty_VzlrgHvfEw/ -c conf/nginx.conf": No such file or directory

Currently unclear if arm64 will be officially supported by kong in time for Edinburgh, however if not it seems that armhf support is working and so we could hypothetically cross-compile kong for armhf target architecture on the arm64 jenkins builders, however this sounds rather difficult to setup in the snap.
We may just end up disabling the security-api-gateway on arm64 if these issues aren't resolved in time.

After some discussion today, we decided to just disable security-api-gateway in the snap when running on arm64 until kong + openresty (and lua I guess?) properly support arm64.

The version of lua and luarocks in the bionic archive seems to be sufficient to build kong 1.0.3, so we can probably drop those parts and just build openresty and kong in the snap. This should simplify the build process a bit and also speed it up. While doing this, care should also be taken to ensure that we fix the kong part build to not just build everything inside $SNAPCRAFT_STAGE so that we don't end up staging everything from previous parts into the snap.

Ian - separate concern, but related to Lua - what are your thoughts?  Some discussion at the Face to Face about using a Lua or similar engine with scripting to replace the rules engine.  Reaction?  Have you actually done any work with Lua outside of just getting the Kong build working?
On Monday, May 13, 2019, 7:15:22 PM PDT, Ian Johnson<EMAIL_ADDRESS>wrote:

The version of lua and luarocks in the bionic archive seems to be sufficient to build kong 1.0.3, so we can probably drop those parts and just build openresty and kong in the snap. This should simplify the build process a bit and also speed it up. While doing this, care should also be taken to ensure that we fix the kong part build to not just build everything inside $SNAPCRAFT_STAGE so that we don't end up staging everything from previous parts into the snap.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@jpwhitemn I've used lua a bit to extend another application by writing plugins (specifically VerneMQ, an MQTT broker written in Erlang). Lua is fairly simple to use and can have good performance, but to my knowledge it's not widely used. It's used in the video games industry a lot, as well as in some applications such as high performance applications that need generic plugin functionality like VerneMQ (as well as Redis actually - perhaps @andresrinivasan can comment on experience using lua in Redis)

In Redis, Lua is perfect for the equivalent of a stored procedure, triggers, and even creating new Redis commands. We have also seen it used in the way IOTech described as a way to create OTA updated apps while treating Redis as an app server.
In general I've been seeing Lua used in microcontrollers and low power devices due to its portability, runtime size, and speed. It would be trivial to express the IFTTT rules described by the EdgeX rules interface in Lua and push them to Redis.

@jpwhitemn perhaps you should spin off a new issue to discuss lua usage as a replacement of the rules engine, possibly with some integration directly into redis...


Resolve the overload in GitHubScanner methods fetch

Link to the class GitHubScanner
methods fetch(long startTime, long endTime, FetchMode fetchMode, Set repos) and fetch(FetchMode fetchMode, Set repos)  shouldn't share the name and should be documented.
Why overloading doesn't support the SOLID principle Open/Closed?

FYI I can't assigned myself, but I'm working on it


[core] Production Babel plugins

You can view the diff between the current and proposed build output here: https://github.com/NMinhNguyen/material-ui/commit/503bf240c24fa4bb3b9d00ff85b7a659d97f74a2
See https://github.com/mui-org/material-ui/issues/10212#issuecomment-364737363 for more context.
It's easier to review the individual commits by the way.
The main changes that concern me with this are things like Object.keys being replaced with transform-runtime, e.g. in https://github.com/NMinhNguyen/material-ui/commit/503bf240c24fa4bb3b9d00ff85b7a659d97f74a2#diff-d4e87d828003c3d0ed59409b821149b9R1. I suppose we could prevent this by not using transform-runtime if ENV === 'es' here?
Closes #10212

@NMinhNguyen Thanks for working on it. I have flattened the babelrc configuration. This is important I would rather sacrifice DRY for explicitness and peace of mind.

The main changes that concern me with this are things like Object.keys being replaced with transform-runtime

This is good thing. It avoid duplication. I have subscribed too the following issues so we can improve the approach in the future:

https://github.com/babel/babel/issues/7330
https://github.com/babel/babel/issues/7267


Add lora+ implentation

Implementing LoRA+ https://arxiv.org/abs/2402.12354

Duplicate of #1504 :)

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

What was the conclusion in that issue?

No conclusion yet, we want to wait and see if the performance gains are indeed robust. Regarding your code, it's basically just a giant string with the code, right? Was that the intent?

waiting for you to ask implement new Trainer object or not?

Hey, after some discussion, I think we can proceed with this project. Let's add the create_loraplus_optimizer function but not the custom trainer class. We can put the function inside of peft/helpers.py.
Some considerations:

Add a reference to the original repo
Update the docs
Remove the logger code
If you feel up for the task, let's add some unit tests.

Yes, This weekend I'll fix the points
On Tue, Mar 12, 2024, 1:41 PM Benjamin Bossan @.***>
wrote:

@moghadas76 https://github.com/moghadas76 do you still plan on working
on this?
—
Reply to this email directly, view it on GitHub
https://github.com/huggingface/peft/pull/1509#issuecomment-1991563308,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFRH3KKIYBNPIB4W5RLD5PTYX3ZZPAVCNFSM6AAAAABD2OVEOGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJRGU3DGMZQHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Great, thanks. On top of what I mentioned, let's also move this to a new file. I'm thinking src/peft/optimizers/loraplus.py. The idea here is that we want to add more optimizer-related methods in the future, so it makes sense to choose a proper file structure right away.

Please review my code

@moghadas76 Do you still plan on working on this?

Yes, I'll fix the comments tonight
On Mon, Mar 25, 2024, 12:48 PM Benjamin Bossan @.***>
wrote:

@moghadas76 https://github.com/moghadas76 Do you still plan on working
on this?
—
Reply to this email directly, view it on GitHub
https://github.com/huggingface/peft/pull/1509#issuecomment-2017824851,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFRH3KIOTROBBMBYUMYCHE3Y2AFIPAVCNFSM6AAAAABD2OVEOGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJXHAZDIOBVGE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Yes, I'll fix the comments tonight

Thanks. No need to rush, I just wanted to inquire if you're still on it :)

@moghadas76 LMK once you're finished with your changes and want me to do another review.

Gentle ping @moghadas76

Hi
I fixed the comments
Please review again

@BenjaminBossan

Sorry for the delay, I was at a conference, will review soon.

@BenjaminBossan
May I ask final check? Best regards

At the risk of repeating myself the 5th time, could you please make the following change:

Great, thanks. On top of what I mentioned, let's also move this to a new file. I'm thinking src/peft/optimizers/loraplus.py. The idea here is that we want to add more optimizer-related methods in the future, so it makes sense to choose a proper file structure right away.

Sorry... I missed that comment. I've fixed it

Hmm, code quality checks are still failing with:

tests/test_loraplus_helper.py:1:1: I001 [*] Import block is un-sorted or un-formatted

Is it possible that your local ruff version differs? CI uses v0.2.2.

You were right. My ruff version was old.

Could you determine what is the problem of
doc-builder style src/peft tests docs/source --max_len 119 --check_only
Traceback (most recent call last):
File "/home/moghadas/miniconda3/bin/doc-builder", line 8, in
sys.exit(main())
^^^^^^
File "/home/moghadas/miniconda3/lib/python3.11/site-packages/doc_builder/commands/doc_builder_cli.py", line 47, in main
args.func(args)
File "/home/moghadas/miniconda3/lib/python3.11/site-packages/doc_builder/commands/style.py", line 28, in style_command
raise ValueError(f"{len(changed)} files should be restyled!")
ValueError: 2 files should be restyled!

Could you determine what is the problem of
doc-builder style src/peft tests docs/source --max_len 119 --check_only

Where did you see that? The code quality check only spits out this:

tests/test_loraplus_helper.py:52:56: W291 Trailing whitespace

Also, these lines could probably be reduced to a single line:
https://github.com/huggingface/peft/pull/1509/files#diff-4d3762210943c647e8ba391b5261730402551c7fa8f3903686fdabde648cea89R71-R78
I guess what happened here is that your editor added those line breaks because it is configured with a lower line limit than what we have in PEFT.

@moghadas76 @BenjaminBossan I can take this up and make necessary changes if you are short on time. We can aim to get this PR merged this week, let me know if its okay.

I can take this up and make necessary changes if you are short on time. We can aim to get this PR merged this week, let me know if its okay.

That's fine from my point of view. A separate PR with credits given would also work for me.
For my understanding: Who is "we" in this case, are you collaborating with moghadas76?

That's fine from my point of view. A separate PR with credits given would also work for me.
For my understanding: Who is "we" in this case, are you collaborating with moghadas76?

I am doing it by myself. By "we" I just meant you and me, and @moghadas76 if they are available.

I see. Sure, please go ahead. As you probably can't push on top of this PR, feel free to create a new one. If we don't hear back from moghadas76 by the time the new PR is ready to be merged, we can add them as a co-author.

I am happy to clean this up too.
IMO the API is not the most clear as currently presented. IMO the embedding LR and the ratio should be either both optimizer_kwargs or both named args. It makes more sense to me that the optimizer kwargs are purely passed to the optimizer rather than to the LR adjustments.
Finally, should the 8 bit -> 32 bit upcast be applied to all the 8 bit optimizers?
    eight_bit_names = ["Adam8bit", "AdamW8bit", "PagedAdam8bit", "PagedAdamW8bit"]
    if optimizer_cls.__name__ in eight_bit_names:

@stillmatic Thanks, that would also be fine, just pinging  @shubhamjain0594 to ensure that there won't be any duplicate work.

This is very disrespectful. He stole this branch.

@BenjaminBossan if @stillmatic has time then sure please go for it. I was going to raise a PR but was mainly looking to fix some documentation and other small bugs you had raised.
@moghadas76 not stealing anyone's work here. Just want to get this PR merged so that I can start using it in my repo without doing weird installation. I have not yet raised a PR, and can wait if you have time to get this done.

Happy to make my suggestions as comments on this branch if you have the time to address them here. I appreciate the work - I used the implementation here in my training, but ran into some problems, hence seeing what needs improvement.

This is very disrespectful. He stole this branch.

Assuming proper credit is given, there's nothing disrespectful about picking up someone's work if they are unable to complete it in a timely manner; there are month+ gaps between you receiving review and you actually addressing it. The PR is 6 months old, for no particular reason at all. Let's get this polished up and merged.

I have rebased and done some fixes on top of this pull request here: https://github.com/kallewoof/peft/tree/202407-loraplus
@moghadas76 You can either base your work off of my fixes or redo it yourself. Whatever gets this merged the fastest. I specifically did not make a pull request out of this, as it sounds like you really want to do this yourself.
@stillmatic Did I get your suggestions in there correctly?

I agree that this is not about "stealing" work. All of this is a big collaboration, after all the initial PR was heavily based on https://github.com/nikhil-ghosh-berkeley/loraplus/blob/main/lora_plus.py.
It would be best if we can get this PR over the finish line, as we're not missing a lot. @moghadas76 if you are still interested, let's try to finish this in the next two weeks. There has been some good feedback in this thread, so I'm sure we have everything we need to get this ready.
If there is no progress here, I'm happy to merge other PRs that implement the same idea, with proper references being given. I'll ensure that co-authorship is respected when merging.

It's been a week, so I opened the above branch as a pull req. Close it if that's not OK, @BenjaminBossan.

Thanks @kallewoof. Starting tomorrow until the end of the week, I'll be at EuroPython Prague, so I will have little time for reviews etc. If by then, there is no progress on this PR, we can close it and continue with yours. As mentioned earlier, I'll make sure to assign proper credit before merging.

Supersedes by #1915.


add openbsd/amd64 support

FWIW, this was developed and tested on OpenBSD with the crypto/ssh package and has been in production for a while.

Ping?

@jcs Sorry, I didn't have a lot of time lately, I still need to spin up an openbsd VM to test it. I'll try to make it happen this week.


Ability to indicate two positions form tensor label

Add the ability to indicate two positions (first the vertical and then the horizontal) to draw the label of the tensor in 8 cardinal points.
Example:
.addTensor ("A", {x: 1, y: 0}, [], [], [], [], {labelPos: 'up left'})
It will draw the label of the tensor in the northwest.
Note: it does not work if it is indicated in reverse: {labelPos: 'left up'}

I have changed the approach, now there are these new positions defined in type Pos:
| 'center' | 'up left' | 'up right' | 'down left' | 'down right'
Please let me know what you think


Can't create a ports-tree with git

Prerequisites

[x] Have you checked for an existing issue describing your problem?
[x] Are you running the latest version?
[x] Is your ports tree recent?
[x] Is your FreeBSD Host on a supported release?

Describe the bug
Cannot create ports-tree after ports switched to git
root@bsd1-build-prod:/usr/local/poudriere/ports # poudriere ports -cvvv -B 2021Q2 -m git -p 2021Q2
=>> Debug: Reading /usr/local/etc/poudriere.conf
[00:00:01] Creating 2021Q2 fs at /usr/local/poudriere/ports/2021Q2... done
[00:00:01] Dev: cache_invalidate: Invalidating _zfs_getfs(/usr/local/poudriere/ports/2021Q2)
[00:00:01] Cloning the ports tree...Cloning into '/usr/local/poudriere/ports/2021Q2'...
warning: Could not find remote branch 2021Q2 to clone.
fatal: Remote branch 2021Q2 not found in upstream origin
[00:00:01] Error:  fail
[00:00:01] Error while creating ports tree, cleaning up.
[00:00:01] Dev: cache_call: Fetching _zfs_getfs(/usr/local/poudriere/ports/2021Q2)
[00:00:01] Dev: cache_invalidate: Invalidating _zfs_getfs(/usr/local/poudriere/ports/2021Q2)
root@bsd1-build-prod:/usr/local/poudriere/ports #

But maybe, it's just documentation missing?
How to reproduce
poudriere ports -cvvv -B 2021Q2 -m git -p 2021Q2
Expected behavior
Should be able to create a ports-tree.
Screenshots
none
Environment

Host OS: 12.2-RELEASE-p6

Poudriere Version: 3.3.6

Ports branch and revision: 2021Q2

as a workaround you can try with: -U "https://git.freebsd.org/ports.git"

Yes, this works! At least, it created a ports-tree.


[Bug Report]: contenthash is not changed with different moduleIds config

System Info
System:
OS: macOS 13.2.1
CPU: (10) arm64 Apple M1 Pro
Memory: 108.92 MB / 32.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 16.19.1 - ~/Library/Caches/fnm_multishells/79180_1678765459198/bin/node
Yarn: 1.22.19 - ~/Library/Caches/fnm_multishells/79180_1678765459198/bin/yarn
npm: 8.19.3 - ~/Library/Caches/fnm_multishells/79180_1678765459198/bin/npm
Browsers:
Chrome: 111.0.5563.64
Chrome Canary: 113.0.5652.0
Firefox: 109.0.1
Safari: 16.3
Details
The moduleId doesn't affect the contenthash of the build assets.
For example, when using different optimization.moduleIds ('named' or 'deterministic'), the output filename are always the same. See reproduction below for more details.
Reproduce link
https://github.com/jkzing/rspack-contenthash-reproduction
Reproduce Steps

pnpm install
pnpm run rspack to see rspack build results
pnpm run webpack to see webpack build results

is this fixed or workaround ?


What If RLock Implement java.io.Closeable?

Is your feature request related to a problem? Please describe.

Closeable interface is used for resources.


File defauts is limited to a list

In Desktop configuration, tab Aplications, we can define our best application for Web browser, Email client, file manager and virtual terminal.
Imagine I select for my virtual Terminal an application from the proposed list.
After a while, if I would associate Virtual terminal to the application xterm. it's not possible :-(
Indeed, xterm is not in the proposed list; and we cannot associate a exe from the filesystem on this screen.
How to proceed ?
ps:
I've added comments on the crash issue #47

Sounds like your installation of xterm did not register itself with a shortcut in /usr/local/share/applications/<xterm.desktop on FreeBSD>, this seem like a problem with how the OpenBSD port performed the installation, since the FreeBSD port just copies the shortcut from the xterm project itself into the proper directory on the system[1].
With all that out of the way, I do see your point that you can't "clear" the application registration back to the default value through the interface. Sounds like I need to make the application-selection dialog a bit smarter by adding the options to clear a setting or select a binary instead.....
[1] https://github.com/pcbsd/freebsd-ports/blob/master/x11/xterm/Makefile (look at the post-install section).

Maybe a problem linked to OpenBSD.
In fact, xterm is part of the base packages and no entries in /user/local/share/applications.
But, rxvt-unicode does neither create entries in /user/local/share/applications.
Sounds that even in Freebsd rxvt-unicode will never appears in the such folder
https://github.com/pcbsd/freebsd-ports/blob/master/x11/rxvt-unicode/Makefile
Note: the tips via the config file works great.
Maybe a button to reset to default could be enough.

Yeah, FreeBSD generally only copies that *.desktop shortcut if it exists in the project's source tree itself. PC-BSD actually creates and installs those shortcuts for particular applications through their PBI system[1]  (pkg overlay with all sorts of additional information, such as adding shortcuts for apps that are missing them).
I am actually a big swamped with some PC-BSD work right now, so since the manual change for the settings worked well enough I am going to put the additional "reset" functionality for lumina-config on the back-burner for the next couple days. I will let you know on here when it is ready for you to test.
[1] https://github.com/pcbsd/pcbsd/tree/master/pbi-modules/x11/rxvt-unicode/xdg-desktop

Ok, I just put a "Reset to Defaults" option on those application registrations. Check it out and see if that works for you now... :-)

indeed, works fine.
selecting an application not in the proposed list is not really an issue, but more a new feature. Thus not relevant here.


Add to OpenBSD ports?

Nice work! Do you plan to package rigg so people can install it easily with pkg_add rigg and get regular updates?

yes, this is planned... likely soon.


Client verify process fails for Qiskit fake provider module

Steps to reproduce the problem
See new PR failures (eg. Client verify process test log on PR #1223).
What is the current behavior?
For
qiskit==1.0.0
qiskit-ibm-provider==0.9.0

Error message:
lint: commands[1]> pylint -rn quantum_serverless tests
************* Module tests.library.test_transpiler
tests/library/test_transpiler.py:18:0: E0611: No name 'FakeAlmadenV2' in module 'qiskit.providers.fake_provider' (no-name-in-module)
tests/library/test_transpiler.py:18:0: E0611: No name 'FakeBrooklynV2' in module 'qiskit.providers.fake_provider' (no-name-in-module)

What is the expected behavior?
No errors.

Looks like the fake classes we are using have been deprecated and have been removed in Qiskit 1.0.

Hey @karlaspuldaro I think @david-alber is working on that in #1227

@karlaspuldaro @Tansito yes this is related to issue #1224 and the PR #1227 intends to fix it.
I am on it :).

@Tansito @david-alber No worries, thx for the heads up. I thought #1224 was only targeting the doc failures.
I'm going to close #1226.


parser: remove sequence order option support

What problem does this PR solve?
Since the order option is not really implemented in TiDB (just syntax compatible)
The warnings message will be ignored by some users, which may migrate their business from Oracle etc to TiDB, consequently, leading the inconsistency.
So better remove it support from the very beginning.
What is changed and how it works?
remove order option in yy and ast.
Check List
Tests

Unit test
Integration test

Related changes

Need to update the documentation

do not merge now

Report an error in TiDB can be another choice.

Report an error in TiDB can be another choice.

sounds good!


Get Master, Worker pages fully ported

Story
Parent Issue
Master and Worker pages should look like original including runtime REST requests

Additionally a fix has been made so that when ~fastOptJS detects that a scala file has been modified it copies it to the output directory so that the browser is updated on refresh. Prior to this a script was required to do this.

merge into parent issue #952


Undefined Symbols

Integration Method: CocoaPods
xcode 15.2
Library version - 5.0.7
iOS
Objective-C
After installing through CocoaPods and before I add any code, it builds fine.
I then  add the first reference to MixPanel:
Mixpanel *mixpanel = [Mixpanel sharedInstanceWithToken:@"XXXX" trackAutomaticEvents: NO];
When I build I get  "undefined symbols" error.
The installation went fine and it built fine until I tried to actually use it in my code.

Same here, any updates on this? Is this a bug in the SDK?


Feedback for "Additional Extensions"

https://help.sap.com/webcomponents/products/SAP Business Application Studio/9d1db9835307451daa8c930fbd9ab264/7188fed1e3764dbc8f71f0d8650d7b68.html
Just wondering why there is an error at the very end of this - looks strange - see attached image

Thanks Tammy, this does look a little odd at first but in fact it's by design, to highlight the fact that this link will take you away from the SAP Help Portal. So the arrow signifies that departure, and the arrow deliberately follows the hyperlink.


Add ABB IRB4600 robot descriptions

This integrates the original abb_irb4600_support package from the ROS-I abb_experimental repo and updates for ROS2. Tested with simulated and real IRB4600_60_205 robot.

It's also good to hear that you were able to run this on hardware. I guess that means the README's weren't awful.  :+1:


Fix incorrect markdown formatting

Ref #447

This looks good to me but I'm not a maintainer - please may you rerun the tests to I can see the failing logs?

Follow-up PR: https://github.com/tiangolo/typer/pull/815


[Feature]: Addition of .env.local_sample file in the project

Description
Currently, contributors do not have a reference for required environment variables, which can lead to setup confusion or misconfigurations.
Suggested Solution
To streamline the development process, we should add an env_sample file that outlines the necessary environment variables without sensitive data. Create an env_sample file in the root of the project
Include placeholders for all required environment variables.
Add documentation in the file explaining what each variable does and any necessary values or formats.
Ensure sensitive data is not included—use placeholders (e.g., YOUR_API_KEY_HERE).
Update the README.md with a section on how to use the env_sample file.
Alternatives
No response
Additional Context
No response

@Bhanu-code  please assign me this issue


[Feature request]White checked background in dark mode is recommended,建议在深色模式下采用白色的选中底色

深色模式下，字符选中后的底色不够明显
In dark mode, the negative color after the character is selected is not noticeable enough
建议在深色模式下采用白色的选中底色
White checked background in dark mode is recommended


Use 'static_assert'  keyword for iar

IAR compiler provides a static_assert keyword that can be used to prevent a compiler error due to _Static_assert not being available.
Related: #589

Thanks!


TypeError: pcst_fast(): incompatible function arguments

When testing with a toy example, I received an error related to how pcst_fast is called:
Traceback (most recent call last):
  File "/miniconda3/envs/oi2/bin/OmicsIntegrator", line 8, in <module>
    sys.exit(main())
  File "/miniconda3/envs/oi2/lib/python3.6/site-packages/OmicsIntegrator/__main__.py", line 78, in main
    vertex_indices, edge_indices = graph.pcsf()
  File "/miniconda3/envs/oi2/lib/python3.6/site-packages/OmicsIntegrator/graph.py", line 296, in pcsf
    vertex_indices, edge_indices = pcst_fast(edges, prizes, costs, root, num_clusters, pruning, verbosity_level)
TypeError: pcst_fast(): incompatible function arguments. The following argument types are supported:
    1. (arg0: numpy.ndarray[int64], arg1: numpy.ndarray[float64], arg2: numpy.ndarray[float64], arg3: int, arg4: int, arg5: str, arg6: int) -> Tuple[numpy.ndarray[int32], numpy.ndarray[int32]]

Invoked with: array([[0, 1],
       [0, 2],
       [1, 3],
       [2, 3],
       [4, 0],
       [4, 3]]), array([1., 0., 0., 1., 0.]), array([8e+19, 8e+19, 8e+19, 8e+19, 6, 6], dtype=object), 4, 1, 'strong', 0

Could this be related to incompatible package versions?  I'm running on Linux inside a conda environment with these packages:
# Name                    Version                   Build  Channel
_libgcc_mutex             0.1                        main
axial                     0.1.10                   pypi_0    pypi
blas                      1.0                    openblas
brotlipy                  0.7.0           py36h27cfd23_1003
ca-certificates           2021.1.19            h06a4308_1
certifi                   2020.12.5        py36h06a4308_0
cffi                      1.14.5           py36h261ae71_0
chardet                   4.0.0           py36h06a4308_1003
cryptography              3.4.6            py36hd23ed53_0
decorator                 4.4.2              pyhd3eb1b0_0
git-lfs                   2.13.2               h06a4308_0
goenrich                  1.7.0                    pypi_0    pypi
idna                      2.10               pyhd3eb1b0_0
jinja2                    2.9.6            py36h489bce4_1
ld_impl_linux-64          2.33.1               h53a641e_7
libffi                    3.3                  he6710b0_2
libgcc-ng                 9.1.0                hdf63c60_0
libgfortran-ng            7.3.0                hdf63c60_0
libopenblas               0.3.13               h4367d64_0
libstdcxx-ng              9.1.0                hdf63c60_0
markupsafe                1.1.1            py36h7b6447c_0
ncurses                   6.2                  he6710b0_1
networkx                  2.1                      py36_0
numpy                     1.19.2           py36h6163131_0
numpy-base                1.19.2           py36h75fe3a5_0
omicsintegrator           2.3.8                    pypi_0    pypi
openssl                   1.1.1k               h27cfd23_0
pandas                    0.23.4           py36h04863e7_0
patsy                     0.5.1                    py36_0
pcst-fast                 1.0.7                    pypi_0    pypi
pip                       21.0.1           py36h06a4308_0
pybind11                  2.5.0            py36hfd86e86_0
pycparser                 2.20                       py_2
pyopenssl                 20.0.1             pyhd3eb1b0_1
pysocks                   1.7.1            py36h06a4308_0
python                    3.6.13               hdb3f193_0
python-dateutil           2.8.1              pyhd3eb1b0_0
python-louvain            0.11             py36h28b3542_0
pytz                      2021.1             pyhd3eb1b0_0
readline                  8.1                  h27cfd23_0
requests                  2.25.1             pyhd3eb1b0_0
scikit-learn              0.19.2           py36h22eb022_0
scipy                     1.1.0            py36he2b7bc3_2
setuptools                52.0.0           py36h06a4308_0
six                       1.15.0           py36h06a4308_0
sqlite                    3.35.2               hdfb4753_0
statsmodels               0.12.2           py36h27cfd23_0
tk                        8.6.10               hbc83047_0
urllib3                   1.26.4             pyhd3eb1b0_0
wheel                     0.36.2             pyhd3eb1b0_0
xz                        5.2.5                h7b6447c_0
zlib                      1.2.11               h7b6447c_3

It could be. I should have pinned numpy versions and whatnot. Is 8e+19 a float64?
I wrote a bunch of tests a long time ago (https://github.com/fraenkel-lab/OmicsIntegrator2/blob/master/test/test_graph.py). Do those still run?

For the tests below, I'm now running with the example data to make sure I don't have an error in my edge or prize files
OmicsIntegrator -e interactomes/inbiomap.9.12.2016.exp.oi2 -p example/example_prizes.tsv -o .

Is 8e+19 a float64?

No, it doesn't seem to be.  I printed the dtypes before calling pcst_fast:

edges is int64
prizes is float64
costs is object

Working backwards, inside __init__ self.edge_costs has dtype float64.  However, inside _reset_hyperparameters self.costs has dtype object after line 130.
https://github.com/fraenkel-lab/OmicsIntegrator2/blob/ea1092fe0053556338cf29c4840a1ff35e8a4f81/src/graph.py#L130
The tests in test_graph.py all passed.

I believe this is happening because the costs are so huge.  For example,
>>> a = np.array([1.0, 2.0])
>>> a
array([1., 2.])
>>> a.dtype
dtype('float64')
>>> b = 10**20 * a
>>> b
array([1e+20, 2e+20], dtype=object)

Why are the edge penalties multiplied by (10**self.params.g)?
https://github.com/fraenkel-lab/OmicsIntegrator2/blob/ea1092fe0053556338cf29c4840a1ff35e8a4f81/src/graph.py#L127-L128

Why are the edge penalties multiplied by (10**self.params.g)?

gamma, or g, is a parameter which penalizes "hub nodes". It is log-scaled, so g = 5 means penalty = 1e5. Although I had thought that was well-documented, I can't find a trace of it in the docs, which is disappointing.

inside init self.edge_costs has dtype float64. However, inside _reset_hyperparameters self.costs has dtype object after line 130.

Thanks for tracking that down. Let's raise an issue about this.

For the tests below, I'm now running with the example data to make sure I don't have an error in my edge or prize files

The tests in test_graph.py all passed.

Does this mean you're able to run OI2 successfully now?
cc @iamjli

Does this mean you're able to run OI2 successfully now?

No, I'm still stuck with the same pcst_fast TypeError.  Because the test cases pass in my conda environment, I now suspect that it could have something to do with how I'm running OI2 via the command line interface.  The default value of g in __main__.py is 20, which is fairly large.
Are you able to run
OmicsIntegrator -e interactomes/inbiomap.9.12.2016.exp.oi2 -p example/example_prizes.tsv -o .

from the command line successfully?

something to do with how I'm running OI2 via the command line interface

Back when I was in the fraenkel lab, we ran OI2 via jupyter notebooks (there should be some examples in the repo). The CLI interface seems outdated (e.g. g = 20 is much too large). A current member of the lab should definitely help you bring it up to date.

I lowered the default g from 20 to 1, and the pcst_fast TypeError went away.  Preventing this error could involve:

Updating _check_validity_of_hyperparameters to set a maximum value of g
Updating _check_validity_of_instance to test the dtype of the edges, prizes, and costs.

A current member of the lab should definitely help you bring it up to date.

I'm willing to submit minor pull requests to fix bugs and make it suitable for my use case, but it would be great to have a current lab member guide me so I can make changes you would want to merge.


[vm] Change version to use a single u32 number.

Motivation
Change the move_version to use a single u32 number. This is a breaking change and will cause stdlib bytes/abis to be regenerated.
Have you read the Contributing Guidelines on pull requests?
Yes

:umbrella: The latest upstream changes (presumably b37d494bae8e2103fe4a6463509c7566548732fb) made this pull request unmergeable. Please resolve the merge conflicts.

@bors-libra r=bob-wilson

:pushpin: Commit 8381c0c has been approved by bob-wilson

@bors-libra r=bob-wilson

:pushpin: Commit c974718 has been approved by bob-wilson

:hourglass: Testing commit c974718d7734a5c3e5ab8780c0cdff76a1a55afb with merge 57b4cb414b605a0511f6111466501bfd67c7b78f...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: bob-wilson
Pushing 57b4cb414b605a0511f6111466501bfd67c7b78f to master...


RFC: stream category

On a recent project we needed to trigger functions and notifications based on specific changes to the dynamoDB.
There was no such built-in support that we could find in the cli. We propose adding support for a new stream category:

DynamoDB change streams
Kinesis event streams

Currently we have a WIP stream-category branch that could serve as an initial blueprint to be further improved.
So far we've had to add custom resources as per the docs and solutions to issues raised here
Cheers!

@kristianmandrup Did you get a chance to take a look at https://github.com/aws-amplify/amplify-cli/pull/2463 ?
Currently we do allow trigger/streaming functionality for S3 and DDB tables added using the amplify add storage functionality.
The above-mentioned PR enables you to add triggers/streaming to the DDB tables provisioned as a part of the GraphQL transformer as well.

Awesome!! However I find that the current CLI is hard to reason about as too much is wrapped into some of the categories.
Would be better with more fine grained categories IMO, and then with the option for some, such as storage to call into and extend using other categories, similar to how Yoman used to work with extensions/plugins.
Hope that PR you referenced gets merged real soon and the docs updated to reflect these additions, making it clear how to use it.
Our problem has been to understand how to extend existing resources and not just add them. Not very clear in the docs. Also had problems understanding how to work as a team on an amplify project.
Thanks.

categories might feel hard to reason about probably because the original intention was not have any tight-coupling to AWS services it feels, thus amplify provider can technically implement a non-AWS resource support, so categories are quite generic, personally for me, stream as a category feels intuitive in kinesis case, as part of #2463 kinesis stream will be available inside analytics category which might not be intuitive.
Extending existing resources in ampllify usually  involves working with cloudformation templates directly, but it might get tricky when we depend on other categories (other cf stacks outputs), this is supported in amplify but currently not really explained in docs, yeah will be great to have docs explaining this.

Thanks for the feedback @kristianmandrup we're waiting on the author of the PR to make some changes before merging. Please keep an eye on it.
In general Categories are based on functional use cases and not implementations, and we try to not add them unless absolutely necessary. I think your requirements as outlined in the original post will be met by https://github.com/aws-amplify/amplify-cli/pull/2463.
Could you however expand with some concrete examples on a couple of your comments so that we could account for them in future designs specifically:

storage to call into and extend using other categories, similar to how Yoman used to work with extensions/plugins
how to extend existing resources and not just add them

the original intention was not have any tight-coupling to AWS services it feels, thus amplify provider can technically implement a non-AWS resource support

This is correct. Categories are functional use cases with declarative APIs that are non-AWS specific. It's also worth remembering that a Category is not just for the CLI but also for the entire Framework such as the JavaScript, iOS, Android libraries and UI components.

Extending existing resources in ampllify usually involves working with cloudformation templates directly, but it might get tricky when we depend on other categories (other cf stacks outputs), this is supported in amplify but currently not really explained in docs, yeah will be great to have docs explaining this.

We do have some docs covering this but if there is more we could add here please let us know or add a PR:

https://aws-amplify.github.io/docs/cli-toolchain/quickstart#custom-cloudformation-stacks
https://aws-amplify.github.io/docs/cli-toolchain/graphql#custom-resolvers

That being said what @kaustavghosh06 and I have been recently discussing for the future is some easier ways to customize. This could potentially be automatically scaffolding out a custom stack or potentially alternatives. We're all ears and open to suggestions here.

We do have some docs covering this but if there is more we could add here please let us know or add a PR

I was referring to the functionality where in amplfy-meta.json and in backend-config.json, dependsOn can be used to pass outputs of other category resources root stacks as parameters, or directly using this in parameters.json:
"Fn::GetAtt": ["stackName",  "Outputs.SomeOutput"]

We do have some docs covering this but if there is more we could add here please let us know or add a PR

@undefobj: I was referring to the functionality where in amplfy-meta.json and in backend-config.json, dependsOn in category can be used to pass outputs of other category resources root stack outputs as parameters, or directly using this in parameters.json:
"Fn::GetAtt": ["stackName",  "Outputs.SomeOutput"]

@kaustavghosh06 @UnleashedMind thoughts on this?

That being said what @kaustavghosh06 and I have been recently discussing for the future is some easier ways to customize. This could potentially be automatically scaffolding out a custom stack or potentially alternatives.

@kaustavghosh06, @undefobj:
can you guys expand on what automatically scaffolding out of a custom stack is?

We're all ears and open to suggestions here.

As of now, amplify-cli has very little provider-independent logic, most of the categories logic will just relay CLI commands to the awscloudformation provider that would perform CLI flow, emitting the resulting CF templates. Rolling out another provider basically would be sort of reimplementing the functionality of each category inside amplify-cli scope, curious if you guys thought of moving some of that logic provider-independent: i.e very roughly: cli flows can emit intermediate representations that are provider-agnostic, those can bundle cross-category dependencies, permission classes, etc and then passed to provider to resolve.
On the client side we would then be able to create instances implementing Provider interface that would convert intermediate representation to any template representation like CF or use imperative approaches akin to aws-cdk or serverless/components.
That can be also tricky in terms of those magical graphQL @transformers where graphql-transformer-core is tighly-coupled to CF. (But IMHO, this appsync abstraction is a single-for-now-unique feature of amplify-cli that is not available in other venture-backed infra-as-code solution like serverless-framework / terraform / pulumi)
Curious to hear your thoughts on this.

@kristianmandrup We recently merged @ambientlight 's PR for kinesis and DDB streams (DDB generated as a part of the GraphQL transformer)
You can checkout the documentation out here - https://aws-amplify.github.io/docs/cli-toolchain/quickstart#as-a-part-of-the-graphql-api-types-with-model-annotation and https://aws-amplify.github.io/docs/cli-toolchain/quickstart#kinesis-stream-trigger
@ambientlight For the provider plugin hooks, could you maybe open a separate issue or an RFC since it seems to be divulging from the original issue.

@kaustavghosh06 Great to see!
"You can also associated a Lambda trigger" should be "You can also associate a Lambda trigger".
"After the above question, you can select one of the types annotated by @model for which you want to add a trigger for."
Please show an example of this in the docs, ie. selecting eventID and eventName I would think?
    console.log(record.eventID);
    console.log(record.eventName);

record.dynamodb will contain a DynamoDB change json describing the item changed in DynamoDB table.
Please show an example of such a JSON change document.
You can add a Kinesis stream to your Amplify project by going through the amplify add analytics flow
I don't understand why Kinesis is under analytics. I would think it is core infrastructure for decoupled micro services in general? Why not an eventing category or sth?
Otherwise everything looks great to me :) Good job!


page loginSuccess,  push logout button has error

Thanks for this! Good catch. :+1:

you are welcome!


Flag icons are not all displayed.

Used Shopware Version: <IP_ADDRESS>
In the Top Navy, not all icons are displayed for languages with the language extension. See image.  Bildschirmfoto%202021-07-09%20um%2010.14.10.png

[public] Shopware automated response: This issue is linked to the internal issue: LAN-78
[created from LAN-78, comment 514161]


Reduce bundle size

It's currently about 1 MB, which seems outrageously large for such a tiny React app. There are tons of tips out there for how to reduce its size.

https://medium.com/better-programming/reducing-js-bundle-size-58dc39c10f9c

It's up to 2 MB now...


InternalURl helper method should incorporate externalRoutes settings …

…into consideration.
Fixes #4559

@sneridagh Any chance to get this merged and released in 16.x?!


multiple authentication schemes

Fixes #20422

@vijayupadya please review. Are there are articles I should add this link?

@HaoK  30 second review please.


Add Discord shield to README.md

Provides an easy way to find the Discord server for new users.

From this project: https://github.com/gitlimes/discord-md-badge
Other style options exist. I went with the default.


[FLOC 2236] Add extra info to pre-tag introduction

Fixes 2236
The Pre-tag review section of the release docs simply said that not deleting tags pushed to GitHub was a policy. This PR adds an explanation of why we don't do that.

Looks good, Thanks for fixing that up!


[sentinel][cypress] Error inspecting

{
  "service": "sentinel",
  "timestamp": "2024-08-31T00:00:04Z",
  "level": 3,
  "message": "Error inspecting",
  "fields": {
    "error": "nonce too low"
  },
  "occurrence_count": 4
}

https://github.com/Bisonai/orakl/pull/2266


Event Based Transitions Example - eventTimeout

What happened:
It's not possible to validate the Event Based Transitions Example with the schema v0.8: Property eventTimeout is not allowed.
What you expected to happen:
The example to be valid
How to reproduce it:
Take the JSON and validate it, in the online editor for instance.

Thanks for reporting, yes
"eventTimeout": "PT1H",

needs to be defined in timeouts def. Will do


Extra colon is present in the Twitch example in style documentation

fixed in https://github.com/inttter/md-badges/commit/55e067db0e3feb0d4365f2f89a76e7976ac230f5


Crash by Create Innovations-1.0.0

Excuse me.
I would like to report a crash when installing Create Innovations-1.0.0.
Mod:
forge-1.18.2-40.2.0
rubidium-0.5.4
rubidium-extra-0.4.16+mc1.18.2-build.57
jei-1.18.2-forge-<IP_ADDRESS>2
Jade-1.18.2-forge-5.2.6
Mantle-1.18.2-1.9.43
TConstruct-1.18.2-<IP_ADDRESS>
flywheel-forge-1.18.2-0.6.8.a
create-1.18.2-0.5.0.i
createaddition-1.18.2-20221219a
create_innovations-1.0.0
crash-2023-01-30_22.00.03-fml.txt

Sorry about the crash! Try an older version of create such as 0.5.0e and an older version of flywheel.


Issue 1191: TestArtifact.versions implementation

Fixes #1191

Thanks, @sbespalov!
It should now be much easier to create artifacts with multiple versions! :)


fix: update committed flag after batch commit

change
update committed flag after batch commit.

Thanks, seems like a serious problem.


Publish to crates.io

[ ] Update Cargo.toml to include required fields.
[ ] Setup CI to auto publish on new releases.

Guess we can support cargo install.
But nix shell github:cargo2nix/cargo2nix already works
So tempting not to support this and just show off the nix workflow


[AutoPR logic/resource-manager] typo: signMdn -> signMDN

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6389

(message created by the CI based on PR content)


Support dynamic plugin loading

Forbid the use of exceptions with the help of fp-ts's TaskEither.

Additionally, please, as always, add comments or even more beautiful documentation, we will need to do it anyway. Soon. Also they provide a lot of value and are cheap to produce.


Used name without knowing

Hey @mirror12k,
We were putting out an LLM terminal integration and called it llmshell, and bought llmshell.com. Only after did I realize this project existed. My bad about that. We're going to rename it to term.chat, and I redirected llmshell.com to this repo.
Just wanted to let you know!

Closing so there's not an open issue for no reason!


Refactor Structure

Ok, this one is massive, i've changed the library to behave better, allowing the user to customize the Raven Store per database, i've also used a approach similar to Ecto, where the user can define several repos if it want, and each of those repos has it's own supervisors tree, so nothing is shared between databases configuration.
This approach also allows me to delegate to GenServer the nodes status, this way i don't need to deal with unhealthy nodes, if the connection drops, it will be restarted automatically with the let-it-crash approach.
Now i want to add a cool functionality, where we can use round-robin, lru or based on node usage which one should be called, i'll probably use poolboy for that.

Pull Request Test Coverage Report for Build 609be1c7991be52b0d75b73d5f69a4fc2b654f0a-PR-3

35 of 189 (18.52%)  changed or added relevant lines in 17 files are covered.
179 unchanged lines in 19 files lost coverage.
Overall coverage decreased (-54.7%) to 29.851%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/connection/models/connection_state.ex
2
3
66.67%

lib/connection/models/node_selector.ex
0
1
0.0%

lib/operations/commands/create_database_command.ex
0
1
0.0%

test/support/factory.ex
0
1
0.0%

lib/connection/supervisor.ex
5
7
71.43%

lib/operations/commands/get_database_command.ex
0
2
0.0%

lib/rql/query.ex
0
2
0.0%

lib/connection/models/topology.ex
0
3
0.0%

lib/documents/session/session_manager.ex
0
3
0.0%

lib/documents/session/supervisor.ex
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

lib/documents/commands/create_database_command.ex
1
0%

lib/documents/protocols/create_request.ex
1
0%

lib/helpers/url_builder.ex
1
75.0%

test/support/random.ex
1
0%

lib/documents/protocols/to_json.ex
2
0%

lib/connection/commands/get_topology.ex
3
0%

test/support/factory.ex
3
55.56%

lib/connection/commands/get_statistics.ex
5
0%

lib/documents/commands/query_command.ex
5
0%

lib/connection/models/server_node.ex
6
45.45%

Totals

Change from base Build 67c8dd5e4f8fa6fcbc5ab74b980265211d1fdcae:
-54.7%

Covered Lines:
160

Relevant Lines:
536

💛  - Coveralls

Pull Request Test Coverage Report for Build b6b841a67c6485a5c733d447b2fb5ac5f516aee4-PR-3
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

139 of 189 (73.54%)  changed or added relevant lines in 17 files are covered.
10 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-3.1%) to 81.53%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/connection/executor/supervisor.ex
21
22
95.45%

lib/connection/models/connection_state.ex
2
3
66.67%

lib/connection/models/topology.ex
2
3
66.67%

test/support/factory.ex
0
1
0.0%

lib/connection/connection.ex
6
8
75.0%

lib/connection/supervisor.ex
5
7
71.43%

lib/operations/commands/get_database_command.ex
0
2
0.0%

lib/connection/connection_state_manager.ex
25
31
80.65%

lib/connection/executor/request_executor.ex
50
84
59.52%

Files with Coverage Reduction
New Missed Lines
%

lib/documents/commands/create_database_command.ex
1
0.0%

lib/documents/session/session.ex
1
88.57%

test/support/factory.ex
3
55.56%

lib/connection/commands/get_statistics.ex
5
0.0%

Totals

Change from base Build 67c8dd5e4f8fa6fcbc5ab74b980265211d1fdcae:
-3.1%

Covered Lines:
437

Relevant Lines:
536

💛  - Coveralls


ICMP error while processing packets

I'm writing a firewall for a school project and encountered this error while testing it. It looks like the library is calling a function that doesn't exist.
ERROR:core:Exception while handling Connection!PacketIn...
Traceback (most recent call last):
  File "/home/mininet/pox/pox/lib/revent/revent.py", line 242, in raiseEventNoErrors
    return self.raiseEvent(event, *args, **kw)
  File "/home/mininet/pox/pox/lib/revent/revent.py", line 295, in raiseEvent
    rv = event._invoke(handler, *args, **kw)
  File "/home/mininet/pox/pox/lib/revent/revent.py", line 168, in _invoke
    return handler(self, *args, **kw)
  File "/home/mininet/pox/pox/forwarding/l2_learning.py", line 99, in _handle_PacketIn
    packet = event.parsed
  File "/home/mininet/pox/pox/openflow/__init__.py", line 193, in parsed
    return self.parse()
  File "/home/mininet/pox/pox/openflow/__init__.py", line 185, in parse
    self._parsed = ethernet(self.data)
  File "/home/mininet/pox/pox/lib/packet/ethernet.py", line 106, in __init__
    self.parse(raw)
  File "/home/mininet/pox/pox/lib/packet/ethernet.py", line 127, in parse
    self.next = ethernet.parse_next(self, self.type, raw, ethernet.MIN_LEN)
  File "/home/mininet/pox/pox/lib/packet/ethernet.py", line 134, in parse_next
    return parser(raw[offset:], prev)
  File "/home/mininet/pox/pox/lib/packet/ipv4.py", line 93, in __init__
    self.parse(raw)
  File "/home/mininet/pox/pox/lib/packet/ipv4.py", line 162, in parse
    self.next = icmp(raw=raw[self.hl*4:length], prev=self)
  File "/home/mininet/pox/pox/lib/packet/icmp.py", line 290, in __init__
    self.parse(raw)
  File "/home/mininet/pox/pox/lib/packet/icmp.py", line 315, in parse
    self.next = unreach(raw=raw[self.MIN_LEN:],prev=self)
  File "/home/mininet/pox/pox/lib/packet/icmp.py", line 221, in __init__
    self.parse(raw)
  File "/home/mininet/pox/pox/lib/packet/icmp.py", line 247, in parse
    self.next = ipv4.ipv4(raw=raw[unreach.MIN_LEN:],prev=self)
AttributeError: type object 'ipv4' has no attribute 'ipv4'

Seems weird.
Can you post the POX log around startup time (which includes the POX and Python versions, for example)?
And, ideally, can you post a packet trace of packets which cause it?  You could do this with Wireshark or tcpdump, or if you're using OpenFlow, I think the info.packet_dump module should do it.

It looks like this error was self inflicted.
POX 0.7.0 (gar) / Copyright 2011-2020 James McCauley, et al.
Starting POX Instance
Starting date and time : 2021-03-10 21:20:39

DEBUG:core:POX 0.7.0 (gar) going up...
DEBUG:core:Running on CPython (3.8.5/Jan 27 2021 15:41:15)
DEBUG:core:Platform is Linux-5.4.0-66-generic-x86_64-with-glibc2.29
WARNING:version:Support for Python 3 is experimental.
INFO:core:POX 0.7.0 (gar) is up.
DEBUG:openflow.of_01:Listening on <IP_ADDRESS>:6633
INFO:openflow.of_01:[00-00-00-00-00-01 2] connected
DEBUG:forwarding.l2_learning:Connection [00-00-00-00-00-01 2]
ERROR:core:Exception while handling OpenFlowNexus!ConnectionUp...
Traceback (most recent call last):
  File "/home/mininet/pox/pox/lib/revent/revent.py", line 242, in raiseEventNoErrors
    return self.raiseEvent(event, *args, **kw)
  File "/home/mininet/pox/pox/lib/revent/revent.py", line 295, in raiseEvent
    rv = event._invoke(handler, *args, **kw)
  File "/home/mininet/pox/pox/lib/revent/revent.py", line 168, in _invoke
    return handler(self, *args, **kw)
  File "/home/mininet/pox/pox/firewall/setupfirewall.py", line 85, in _handle_ConnectionUp
    policies = process_configuration(policy_filename)
  File "/home/mininet/pox/pox/firewall/setupfirewall.py", line 55, in process_configuration
    raise TypeError("Invalid Format for Source IP Address for rulenum %s" % rule['rulenum'])
TypeError: Invalid Format for Source IP Address for rulenum 22

Does that mean you've gotten it straightened out?
Given that you're running gar and I just recently wrote a strange piece of code entirely based on ICMP, I'd be super surprised if ICMP very broken (not that it's not possible).  Offhand, my first guess is that there's some other module called ipv4.py besides POX's one, but that is harder to believe in Python 3.
All to say that I'd be interested in understanding what is/was going on here.
(Also the exception in the log you posted... is unrelated, right?)

Yup it's all straightened out. I wasn't supplying the ipv4 address properly to it.


Add a checkinternaldomain to the upcheck to validate internal domains

This is to add validation to both upcheck domain and a bosh defined internal domain.
I would appreciate any assistance to this PR to see if there are additional tests to be implemented and how.  As there seems to be lots that might be effected including performance and integration tests.
Let me know how you want to proceed.

I think that this will be an useful addition to bosh-dns and would like to help with this pull-request. I created a new pr https://github.com/cloudfoundry/bosh-dns-release/pull/59, where I tried to apply the suggestions provided by @xtreme-conor-nosal. @andrew-edgar I created the pull-request in the bosh-deps-forks organisation. I hope you have rights to push changes there.

We merged in #59 which overlaps a lot with the intent behind your PR @andrew-edgar. Could you take a look and see if that's true?
I'm going to close this PR out for now, but let's continue the discussion if there's something we're missing!

yeah sounds good thanks


Weekly #7: February 16-22

:palm_tree:

Nothing shipped by me last week, but some incremental progress was made:

:star: Me and @whyrusleeping and @chriscool have been doing lots to make our tests greener. This'll let us get PRs in faster because we won't need to wonder whether our CI is lying to us or not.
:star: Made progress toward getting go-ipfs compatible with vanilla go get installation. Hope to have more tangible results to show by end of this week.

as noffle says, we put a lot of effort into making the CI green. This gives us more confidence about the code we ship, and allows us to ship more often.

station

@dignifiedquire fixed drag and drop
file uploading, and some dependency issues. So go ahead and try it
out.

ipfs-geoip

@dignifiedquire rewrote the generation
script and cleaned up the code so that now the data is consistently
reproducable and fully stored on IPFS. This ensures that geoip lookups
over IFPS will work in all future releases.

Made 'ipfs files ls' default to '/'.

Cleaned up sharness tests.

http-api-spec: @RichardLitt finished logging all existing ipfs commands for the HTTP API Spec. This means that if you have any questions about how the HTTP API should work, you can see them either in master or as open PRs to that issue. One step closer to a fully functional API...
community: @RichardLitt proposed using the new GitHub Templates for IPFS. What do you think about this idea? Chime in here.
community: We now have a list of community events for IPFS on the ipfs/community README. Do you have any that you'd like to add? Check out past events, too.

Thanks. Closing in favor of #17.


The documentation is not translated into English

We should translate all of the documentation into English.

This would be awesome!

@orta We've finally completed translating the documentation! If anything is missing, feel free to open a new issue 🙂

ace


Create billing accounts on household creation

Instead of on transaction creation. That way a credit limit can be set before transactions are created.
Originally created by Tom Smyth at 2018-06-01 15:40, migrated from redmine-#8488

Duplicate of #784 which is done.


Google assistant language support

Hello,
Does anybody knows how to change GA speech language on Magic Mirror?
Thanks in advance.
Best,

well, unfortunately, you have to wait until your language is officially supported by GA.


Page froze on me

Challenge http://freecodecamp.com/challenges/bonfire-reverse-a-string has an issue. Please describe how to reproduce it, and include links to screenshots if possible.
Cannot reset code, page is frozen on me.

Thanks for posting an issue,
Try the following:
If you’re having trouble with JavaScript or jQuery challenges, do a hard refresh and it will fix them. (in Chrome: CTRL + Shift + R on Windows or CMD + Shift + R on mac)

I tried refreshing / resetting code / signing out / closing Chrome, none worked.

Try opening 'freecodecamp.com' open your console and go to resources tab(chrome). There click on the localStorate link in the nav bar on the right. Delete all the entries on the right side. Then navigate to the challenge. This removes all your local stored challenges.

It seems that this has been resolved.  I'll close this but feel free to reopen if you still experience this issue.

Thank you!!

just find the page of the challenge and modify the address a bit.

 I was actually frozen on that exact challenge.


chore(main): release 0.2.13

:robot: I have created a release beep boop
0.2.13 (2024-11-10)
Bug Fixes

调试使用Github的环境变量20 (6a88a12)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.2.13
:sunflower:


Questioning UnnecessaryElseBranch when the "then" branch always returns.

The UnnecessaryElseBranch warning is issued when

"the then branch always returns"

What is the reasoning behind issuing this warning? When the if condition fails, the else branch is executed, so it doesn't seem unnecessary to me.
This is one of the unit tests for UnnecessaryElseBranch:
should("""
  def test(): Any = {
    if(util.Random.nextBoolean) {
      println("foo"); return 5; println("foo2");
    } else {
      println("foo3"); println("foo4");
    }
  }""")

I don't see why the else branch would be unnecessary here.

It's a style warning that the code in the else block could be moved outside the if to decrease code nesting, like this:
noLint("""
  def test(): Any = {
    if(util.Random.nextBoolean) {
      println("foo"); return 5; println("foo2");
    }
    println("foo3"); println("foo4");
  }
}""")

I'll change the text of the warning, as it really doesn't explain this, and add this example to the test cases.
Thanks for reporting!

Oh, OK, thanks!


Scroll bar disappears on resize

Hello,
when I resize the window on windows desktop, the scroll bar of the column or row disappears most of the time. It doesn't happen on the web page but only desktop!

Can you show a little video please?
Then share some test code to reproduce the issue.

Hi, my bad, it was resolved. However, I did not quite understand why it happened in the first place.


[Karpenter] [Docs] : Node terminates before ready on failed encrypted EBS volume

Is an existing page relevant?
Yes
https://karpenter.sh/v0.10.1/troubleshooting/#node-terminates-before-ready-on-failed-encrypted-ebs-volume
What karpenter features are relevant?
Node terminates before ready on failed encrypted EBS volume. The Karpenter docs in the Troubleshooting page has the below details.
If you are using a custom launch template and an encrypted EBS volume, the IAM principal launching the node may not have sufficient permissions to use the KMS customer managed key (CMK) for the EC2 EBS root volume. This issue also applies to [Block Device Mappings](https://karpenter.sh/v0.10.1/aws/provisioning/#block-device-mappings) specified in the Provisioner. In either case, this results in the node terminating almost immediately upon creation.

Keep in mind that it is possible that EBS Encryption can be enabled without your knowledge. EBS encryption could have been enabled by an account administrator or by default on a per region basis. See [Encryption by default](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/EBSEncryption.html#encryption-by-default) for details.

To correct the problem if it occurs, you can use the approach that AWS EBS uses, which avoids adding particular roles to the KMS policy.

How should the docs be improved?
However, in my lab I was using EKS Optimized AMI, Launch templates created by Karpenter and EBS encryption enabled. But, still faced the issue similar to https://github.com/aws/karpenter/issues/1760 and Nodes were getting Terminated before it was ready.
I went about adding the Karpenter Controller role (IRSA role) as KMS Key users in the KMS console and that solved the issue for me and it was similar to the KMS policy explained here https://karpenter.sh/v0.10.1/troubleshooting/#node-terminates-before-ready-on-failed-encrypted-ebs-volume
If we can update the documentation with below details :

The issue is not specific to custom launch templates, instead can be seen with EKS Optimized AMIs and LTs created by Karpenter
Also, a note on the docs here https://karpenter.sh/v0.10.1/troubleshooting/#node-terminates-before-ready-on-failed-encrypted-ebs-volume which tells customers that they should add the Karpenter Controller role (IRSA role) and not the Karpenter Node role.

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Ah, is the confusion primarily over this bit - the IAM principal launching the node may not have sufficient permissions to use the KMS customer managed key (CMK)?
I think the reason it's phrased this way is because we want to avoid making assumption on how someone's set up Karpenter. If you've set up IRSA, then you'd need to update the Karpenter Controller role that's associated with the Karpenter pod.
If you weren't using IRSA at all and Karpenter is running on your managed worker node, then the nodeRole associated with your managed node group would need to have these permissions. I haven't used EKS on Fargate a bunch, but without IRSA I think it's the pod execution role you'd have to update there.
I'll try and add a statement to help clarify that. Thanks for opening this.


MM-36766 - Remove RHS tabs

Summary

First step in the RHS redesign.
Removes the tabs
The RHSRunDetails is the parent of two components: RHSAbout and RHSChecklists
@agarciamontoro please rename RHSAbout if you want to, of course!
@agarciamontoro I did not touch the styling in RHSAbout. It's mostly the old style scss, so I'm not sure what you want to do with that.
Not gating with a flag because I'm assuming we're just flipping the switch? (Plus I ripped out a bunch of code that the old way needed...) edit: because we're merging to a feature branch

Ticket Link

https://mattermost.atlassian.net/browse/MM-36766

Checklist

[ ] Telemetry updated
[ ] Gated by experimental feature flag
[x] Unit tests updated

@agarciamontoro The reason I was thinking to use a branch is the case where we're halfway through the feature and we have to worry about the next release. I think having it half done, or having that unrelated release create pressure to commit an in-progress PR just so that the product isn't in a broken state -- I think we'd want to avoid that.
What does everyone else think?

Sorry I was not clear enough before: I'm also ok with the feature branch. It's just that even if we would cut a new release only with this PR, it would not be that bad, as the RHS looks good. And then I think it will be one isolated PR from each of us for each section.
But I agree it could add some pressure when the release comes, so I'm ok using the branch for this specific feature (and I think using a feature flag here is not even an option, it looks like more work than just doing the whole feature).

@lieut-data At the moment there isn't a way to update status, other than slash commands. So howabout we merge this to the branch until we at least have a fully functional RHS? That should be @agarciamontoro 's first commit. Then we'll merge the branch and develop the rest on master. Sound good?

Works for me! But I'm curious why the Update Status button would have disappeared from the remaining tab?

@lieut-data Ah, because there's no more footer -- the update status button moved into the top component, and I didn't move it there. I was working under the assumption that this was a quick PR to get @agarciamontoro unblocked and then the next PR would make it functional.

Works for me, @cpoile! 👍🏼


feat(charts,logging-operator): add possibility to deploy extra manife…

…sts to Helm chart

@pepov maybe you can include that in the upcomming release tomorrow :D

@sebastiangaiser what is the usecase for this? what is the reason against creating an umbrella chart and putting extra resources there?

My use case are the PrometheusRules from here

I meant that you can create a high level chart, add you prometheus resources and add the logging operator as a dependency into that. I haven't really seen this extra resources as a practice this is why I ask.
The term comes from here: https://helm.sh/docs/howto/charts_tips_and_tricks/#complex-charts-with-many-dependencies

I've found a few usage for this in the most popular charts, ok for me