S3 resource fails in amplify push for too-long bucket name

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
v18.17.1
Amplify CLI Version
10.7.3
What operating system are you using?
Ubuntu
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No manual changes made
Describe the bug
I have created a new environment (with amplify env add) named stuartprod, and am now trying to amplify push to deploy the environment. I get the following error:
Deploying storage s3linkfiles [ ---------------------------------------- ] 0/9
	S3Bucket                       AWS::S3::Bucket                CREATE_FAILED                  Mon Oct 23 2023 14:57:56…

🛑 The following resources failed to deploy:
Resource Name: S3Bucket (AWS::S3::Bucket)
Event Type: create
Reason: Bucket name should be between 3 and 63 characters long

🛑 Resource is not in the state stackUpdateComplete
Name: S3Bucket (AWS::S3::Bucket), Event Type: create, Reason: Bucket name should be between 3 and 63 characters long

I don't know what the bucket name that it's trying to create actually is, and I don't know how to find out. The name of the whole project is projnewcomponents. I note that in the existing environment (called staging), the name of the bucket is projnewcomponents5ddb(28 hex chars)3503-staging, which is 61 characters long. So perhaps it's trying to create projnewcomponents5ddb(28 hex chars)3503-stuartprod which would be 64 characters long and therefore too long? This is OK if so, but there really ought to be a warning about this somewhere!
Expected behavior
Either this shouldn't fail, or, if the constructed bucket name is too long, it should tell me what the failing bucket name is so I can try to resolve it.
Reproduction steps
I don't know what's causing this (although see speculation above) so it's hard to know how to reproduce it.
Project Identifier
No response
Log output

# Put your logs below this line

Additional information
No response
Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

Hey @stuartlangridge, thank you for reaching out. I was able to reproduce the issue using the following steps

amplify init -> named projnewcomponents
amplify add storage
observed the bucket name was greater then 63 characters as follows

amplify push fails with Reason: Bucket name should be between 3 and 63 characters long.

marking as bug.

/assign

can someone assign me this issue please ?

can someone assign me this issue please ?

heii @ykethan , can you assign me this issue ??


Update to latest Cake SDK

TheCake.Prompt addin is referencing an older version of Cake.Core (0.33.0).
For best compatibility it should target Cake.Core version 1.0.0.

Fixed by #9


Option to change soapy device properties at runtime

Hey,
Is it possible to change soapy device properties like the center frequency etc. at runtime?  Or more general: Can the flowgraph be changed at runtime?
I would like to avoid stopping the flowgraph to create a new SoapySource object, which will cause a new device initialisation that takes a few seconds.
And if so, how could that be implemented in FutureSDR? I did not find a way to access the device after it is converted to a block.
From what I see in the soapy crate doc (https://kevinmehall.net/rustdoc/soapysdr/soapysdr/struct.Device.html#method.frequency) this might be possible, but I am anything but an expert on this.
What I would like to do at the end is an extension of the fm-receiver example:
let src = SoapySourceBuilder::new()
        .freq(93.7e6)
        .sample_rate(3.2e6)
        .gain(40.0)
        .build();

// Connect everything ...

// Execute
Runtime::new().run(fg)?;
// as an asynchronous task/thread/whatever

// Make changes to the frequency to tune e.g. to a specific radio station on the go

The Soapy Source already has a basic handler to change the frequency: https://github.com/FutureSDR/FutureSDR/blob/master/src/blocks/soapy_src.rs#L36-L55 This could be extended to accept other types of PMTs. And one could add more handlers in a similar fashion.
Instead of running the flowgraph, which awaits the task until the flowgraph is finished. You can start it, which gives you a FlowgraphHandle. With the handle you can call message handlers of blocks. Alternatively, you can use the REST API to issue callbacks.

Thanks for the input, I will give that a try!


Add the resolveDockerTagsByTimestamp argument to virtual repository resource

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description
Add the resolveDockerTagsByTimestamp argument to virtual repository resource.
As of Artifactory version 6.12 it now supports the ability to resolve images with the same docker tags by timestamp. See the release notes here.
New or Affected Resource(s)

artifactory_virtual_repository

Potential Terraform Configuration
resource "artifactory_local_repository" "bar" {
  key = "bar"
  package_type = "docker"
}

resource "artifactory_local_repository" "baz" {
  key = "baz"
  package_type = "docker"
}

resource "artifactory_virtual_repository" "docker" {
  key          = "foo"
  package_type = "docker"
  resolve_docker_tags_by_timestamp = true
  repositories = [
    "${artifactory_local_repository.bar.key}",
    "${artifactory_local_repository.baz.key}"
  ]
}

References

Artifactory release notes
Artifactory virtual repository API reference

I will have a go at adding this myself


utils.ts: fix finding constructors when a comment exists

constructors aren't found correctly if a comment exists before it.

To better test this, #350 is created


Specialize input character conversion.

Add optimized versions of WConv::nextchr() for 1-byte and UTF-8 encodings.
Retain existing mbrtowc()-based code for non-UTF-8 multi-byte encodings.

Completed in commit 853387fab0448a8f3d4dbe5d1912cb3f26cfdb5a.


api: Cache Selector in EndpointSelector on create

Speed up regeneration of endpoints with a large number of rules

BLOCKED: This PR relies on #4548.
Previously, the EndpointSelector would create a new k8sLabels.Selector
every time a match occurs, which would involve validating the selector,
running regexes, DNS FQDN checking, taking global locks and so on. This
is not acceptable from a performance perspective: All policy computation
is serialized. Observed in a setup where several goroutines were
blocking on a mutex while constructing the Selector here.
Instead, when creating the EndpointSelector, generate the set of
requirements at that point in time so that the Matches() can be a set of
simple match operations.
Using microbenchmarks, before:
    $ go test -bench=Parallel -benchtime=10s
    OK: 24 passed
    goos: linux
    goarch: amd64
    pkg: github.com/cilium/cilium/pkg/policy/api
    BenchmarkMatchesValid1000Parallel-4<PHONE_NUMBER>15 ns/op
    PASS
    ok      github.com/cilium/cilium/pkg/policy/api 26.933s

After:
    $ go test -bench=Parallel -benchtime=10s
    OK: 24 passed
    goos: linux
    goarch: amd64
    pkg: github.com/cilium/cilium/pkg/policy/api
    BenchmarkMatchesValid1000Parallel-4      2000000              8036 ns/op
    PASS
    ok      github.com/cilium/cilium/pkg/policy/api 24.149s

Related: #4526

This change is

test-me-please

Needs a bit more work, current CI failure:
03:33:57 panic: runtime error: hash of unhashable type labels.internalSelector
03:33:57
03:33:57 goroutine 458 [running]:
03:33:57 type..hash.github.com/cilium/cilium/pkg/policy/api.EndpointSelector(0xc421afa6c0, 0x2db40c42, 0x127d547)
03:33:57 	<autogenerated>:1 +0x5a
03:33:57 github.com/cilium/cilium/pkg/policy.L7DataMap.addRulesForEndpoints(0xc4218d33e0, 0xc42177e550, 0x1, 0x1, 0x0, 0x0, 0x0, 0xc421772ae0, 0x1, 0x1)
03:33:57 	/go/src/github.com/cilium/cilium/pkg/policy/l4.go:140 +0xbf
03:33:57 github.com/cilium/cilium/pkg/policy.CreateL4Filter(0xc421772ae0, 0x1, 0x1, 0xc421772b20, 0x1, 0x1, 0xc4237ef260, 0x2c2850e, 0x2, 0x2c28b06, ...)
03:33:57 	/go/src/github.com/cilium/cilium/pkg/policy/l4.go:182 +0x2fa
03:33:57 github.com/cilium/cilium/pkg/policy.CreateL4IngressFilter(0xc421772ae0, 0x1, 0x1, 0xc4219950b8, 0x0, 0x0, 0xc421772b20, 0x1, 0x1, 0xc4237ef260, ...)
03:33:57 	/go/src/github.com/cilium/cilium/pkg/policy/l4.go:198 +0x130
03:33:57 github.com/cilium/cilium/pkg/policy.mergeL4IngressPort(0xc421afb620, 0xc421772ae0, 0x1, 0x1, 0xc421afb0b8, 0x0, 0x0, 0xc421772b20, 0x1, 0x1, ...)
03:33:57 	/go/src/github.com/cilium/cilium/pkg/policy/rule.go:50 +0x1219
03:33:57 github.com/cilium/cilium/pkg/policy.mergeL4Ingress(0xc421995620, 0xc421772ae0, 0x1, 0x1, 0x0, 0x0, 0x0, 0xc421772b00, 0x1, 0x1, ...)
03:33:57 	/go/src/github.com/cilium/cilium/pkg/policy/rule.go:162 +0x41f
03:33:57 github.com/cilium/cilium/pkg/policy.(*rule).resolveL4IngressPolicy(0xc420181c00, 0xc421995620, 0xc421afb578, 0xc42139dd40, 0x1, 0x1, 0xc421ad8660)
03:33:57 	/go/src/github.com/cilium/cilium/pkg/policy/rule.go:209 +0x219
03:33:57 github.com/cilium/cilium/pkg/policy.(*Repository).ResolveL4IngressPolicy(0xc42175c4c0, 0xc421995620, 0x0, 0x0, 0x0)
03:33:57 	/go/src/github.com/cilium/cilium/pkg/policy/repository.go:244 +0x252
03:33:57 github.com/cilium/cilium/pkg/endpoint.(*Endpoint).resolveL4Policy(0xc421958280, 0xc42175c4c0, 0xc421afb878, 0xc421afb8a8, 0xc421afb878)
03:33:57 	/go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:180 +0x117
03:33:57 github.com/cilium/cilium/pkg/endpoint.(*Endpoint).regeneratePolicy(0xc421958280, 0x3d090a0, 0xc421adc6c0, 0xc421995878, 0x0, 0x0, 0x0)
03:33:57 	/go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:505 +0x22e
03:33:57 github.com/cilium/cilium/pkg/endpoint.(*Endpoint).regenerateBPF(0xc421958280, 0x3d090a0, 0xc421adc6c0, 0xc42150a5d0, 0x24, 0x2c2a498, 0x4, 0x0, 0xc42128c900, 0x0, ...)
03:33:57 	/go/src/github.com/cilium/cilium/pkg/endpoint/bpf.go:572 +0x3c1
03:33:57 github.com/cilium/cilium/pkg/endpoint.(*Endpoint).regenerate(0xc421958280, 0x3d090a0, 0xc421adc6c0, 0x2c2a498, 0x4, 0x0, 0x0)
03:33:57 	/go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:642 +0x3f4
03:33:57 github.com/cilium/cilium/pkg/endpoint.(*Endpoint).Regenerate.func1(0x2c2a498, 0x4, 0x3d090a0, 0xc421adc6c0, 0xc421773380, 0xc421958280)
03:33:57 	/go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:736 +0x230
03:33:57 created by github.com/cilium/cilium/pkg/endpoint.(*Endpoint).Regenerate
03:33:57 	/go/src/github.com/cilium/cilium/pkg/endpoint/policy.go:719 +0x13f
03:33:57 exit status 2

test-me-please

I'll rebase when #4548 goes in.

test-me-please

test-me-please

Superseded by #4790 .


Android Crash when unsuccessful Purchase (not attached to window manager)

I'm using the Plugin for my forms store, but i encountered a reproducible error on Android.
When Executing a Purchase and the Popup opens from below the user can stop the Purchase when swiping from top to bottom.
This results in the window disappearing and the function returns a PurchaseError.UserCancelled so far so good.
But after a few seconds a new Error gets thrown which crashes the app because it's unhandelt.
Java.Lang.IllegalArgumentException: 'View=DecorView@4bca321[ProxyBillingActivity] not attached to window manager'
This error originates from Xamarin.Android.Google.BillingClient.
Similar to https://github.com/xamarin/Xamarin.Forms/issues/8044
It's seems that the Popup which google uses isn't finished when the Activity returns and results in this error.
This issue also occurs when trying to test and the user isn't included in the testgroup and the closes the popup with ok.

Has anybody got an workaround for this issue?

Where are you calling your purchase call from?

And you are try/catching everything?
May want to look at this https://github.com/xamarin/Xamarin.Forms/issues/14193#issuecomment-828228605 as I can not reproduce

everything is executed in a try catch.
...
Found the issue,
I'm using ACR.UserDialogs to let the user know it worked/or not which seems to confilct with the store...


Release tooling: Use Github Security Advisories

Overview
Our security vuln management process is quite manual: Create an issue in github.com/silverstripe-security, create private forks, review pull requests on those forks, merge into a release branch on the private fork, release private RC from private fork, merge back to public repo on public stable release, copy announcement draft from Github issue and publish on ss.org. Github Security Advisories promises to streamline some of this.
There's three levels of adopting them:

Only use them to request CVEs (instead of emailing Mitre) and publish copies of advisories in addition to our existing processes and channels
Also replace our current advisory publication with Github
Also use Github's temporary private forks for collaborating on a fix

The acceptance criteria below assume we're doing all of the above.
Acceptance Criteria

The process has less manual steps than the current one
The process can be applied to all supported modules
We use the Github CVE authority
There continued to be one feed for subscribing to Silverstripe security issues for supported moduiles
The process allows us to ensure Travis builds on private releases pass before disclosing issues
The process is documented as part of the standard release process and checklists
Core committers, contributing committers and stakeholders from Silverstripe Ltd. (e.g. our CISO) can collaborate on issue resolution privately

Advisory Publication
We currently only have five issues listed in the Github Advisory Database. There are more issues in the CVE list, but it's not complete. The only complete list is on our own advisories on silverstripe.org. They list FriendOfPHP as one of their sources, but haven't reflected most of the security issues there.
Options:

Option A: Retroactively add all known vulns into FriendsOfPHP, work with Github to pull them in
Option B: Retroactively add all known vulns to CVE, work with Github to pull them in (this seems like a giant PITA?)
Option C: Retroactively add all known vulns to Github Advisories directly on the modules. We can't backdate these, which could cause a lot of confusion
Option D: Publish new advisories through Github, keep advisories on silverstripe.org as the canonical source (either manually duplicating announcements there, or integrating with Github feeds)
Option E: Switch to Github advisories going forward, changing feeds. Send a one off message to current subscribers of the old silverstripe.org feed (as a pseudo-entry in the feed). Note that Github also publishes RSS feeds for a project's advisories, although we currently combine them into a single feed across all supported modules.

Notes

CVE numbers claim to be assigned in 72 hours or less

Related

Add support for automatically disclosing security issues

OK I've trialled this with a test advisory and a private temporary fork. Travis CI picks up the new private repo, see https://travis-ci.com/silverstripe/silverstripe-framework-ghsa-pfcw-wfpx-2r26/builds. But it doesn't trigger any builds, even after sending a pull request. I've asked on their community forum.
Even if the Travis builds were working, it's not a clear-cut decision.

Pro: One less Github organisation to manage members in (could get rid of github.com/silverstripe-security)
Pro: Clearer association between multiple pull requests and an advisory (they're the only custom branches on this fork)
Con: More repos to clutter our repo listings on github.com/silverstripe for admins (one per advisory)
Con: One fork per advisory (vs. one fork per module in the status quo)
Con: Travis builds not supported at the moment

I think we should start using Github advisories without using those private forks. They would only be a real advantage to us if Travis was somehow identifying them as "private but related to open source repos", and provide build capacity free of charge.

Another angle I hadn't considered: We can't really put any third party on the critical path to our security releases. At the point when we release, we need to be able to point to an authoritative public description of the vulnerability. And ideally one where we can easily control updates.
This definitely excludes CVE publication, I've experienced weeks of delays between request and publication through Mitre. Might be better through Github as the CNA.
And it also excludes FriendsOfPHP since that's a volunteer-driven pull request system. They even mention explicitly on the README that it's not to be used for a "primary info source". They have a good track record of merging PRs in a day or so, but even that is a pain if we'd pull in a feed directly from their repo to silverstripe.org.
So the value of Github Security Advisories to us keeps decreasing. I'll contact them to ask why they haven't pulled in the FriendsOfPHP stuff even though they claim to do so.

I've contacted Github:

Hello! We're a PHP Open Source project which publishes security vulnerabilities through the FriendsOfPHP advisory database: https://github.com/FriendsOfPHP/security-advisories/tree/master/silverstripe
According to https://help.github.com/en/github/managing-security-vulnerabilities/browsing-security-vulnerabilities-in-the-github-advisory-database, you are adding advisories from this database to the Github Advisory Database.
Quite a few seem to be missing though: FriendsOfPHP has 28 advisories for the silverstripe/* vendor namespace.
Github only finds 5: https://github.com/advisories?utf8=✓&query=silverstripe
Specific example of a missing advisory:
https://github.com/advisories?utf8=✓&query=CVE-2019-12437
https://github.com/FriendsOfPHP/security-advisories/blob/master/silverstripe/graphql/CVE-2019-12437.yaml
Note that we've also started publishing advisories through CVE a few months ago, but use the same identifiers between those two databases.
We're hoping for the wider community to benefit from Github Security Advisories, it's a fantastic service! Any chance you can check why you've got partial data?
Also, you obviously can't make commitments on a free service like this, but can you give us insights into much delay we should expect between publishing an issue in FriendsOfPHP, and it popping up in a Github Security Advisory? I'm conscious there's often human review involved, just looking for ballpark figures to avoid us getting confused when something is missing that might still be under review.
Thanks
Ingo

Aaaand another email to Github:

Hello! We're running an Open Source project which publishes security advisories on CVE as well as the FriendsOfPHP database (https://github.com/FriendsOfPHP/security-advisories/tree/master/silverstripe/framework). I've just sent an enquiry about missing entries there (#488061).
Another potentially impactful bug I've noticed: When parsing the CVE information, the lower bounds for a dependency seems to get lost. This leads to Github repos being marked as vulnerable when they aren't. In the following example, we've marked the lower bounds as >=4.1.0 via the CVE disclosure, so not affecting projects on 3.x versions of our software. Yet the corresponding Github advisory claims vulnerable versions: < 4.3.6.
https://nvd.nist.gov/vuln/detail/CVE-2019-12204
https://github.com/advisories/GHSA-cg8j-8w52-735v
Note that we're planning to more consistently publish advisories on FriendsOfPHP, which probably has a more structured data approach to those constraints. Maybe those clearer definitions could take priority where the identifiers match? We're using the same CVEs in FriendsOfPHP advisories as well, so should be unambiguous.
Thanks!
Ingo

Heard back from Github support. I'll have a call with them soon to clarify a bit

Thanks for reaching out, and sorry it's taken a bit to get back to you.
We're slowly ramping up our Advisory Database and the curation team that manages all of the intake into the database. Right now, we have a semi-manual importer that we can run to import from FriendsOfPHP. We mainly use it when we see a PHP-ecosystem CVE come through our National Vulnerability Database importer, because we've found that you generally have higher-quality and more accurate metadata. That's why you see only a subset of your advisories in GitHub Advisory Database.
In 2020, as we staff up the curation team, we hope to get the FriendsOfPHP importer running automatically, and to have our processes tuned enough that we can do a "catch-up" curation of all the existing advisories in FriendsOfPHP.

@chillu

Aaaand another email to Github:

'< 4.3.6' isn't entirely accurate either. It looks like this is also resulting in GitHub advisories recommending upgrading to non-existent releases (4.3.6) too: https://github.com/silverstripe/silverstripe-cms/issues/2511

Perhaps they're assuming that a disclosure would also go with a stable patch release with a fix in it, in which case it's on us for not releasing a patch for that release line?

A few points I've clarified with Github support:

Private security forks automatically get deleted after merging and publishing the advisory, so minimising clutter
You can use advisories without associating pull requests on them (we can retain our current workflow)
You can grant access to advisories for both teams and individuals, which would work for us
Github is planning to improve the FriendsOfPHP import, currently semi-manual and only imported a fraction of the advisories we published there.

So in the short term, I think we're blocked by us backfilling into FriendsOfPHP (nearly done), and Github backfilling from FriendsOfPHP, as well as automating this. Once those pieces are in place, we could start filing Github advisories instead of requesting CVEs from Mitre, but keep our current workflow around issues and private forks. The advantage here is that we could replace https://www.silverstripe.org/download/security-releases/ with a feed coming straight from Github (through the securityVulnerabilities query in their GraphQL API), and wouldn't need that duplication of info in our own CMS. Admittedly, I'm not sure this tweak is worth rewriting this logic, since we still have four places for advisories (private Github repo, FriendsOfPHP, CVE, Github advisory).

I think we're blocked by us backfilling into FriendsOfPHP (nearly done), ...

Noting that this is done now 😄

Github is still not reliably importing advisories from FriendsOfPHP. I think publishing our own advisories is becoming a higher priority, since this partial alerting by Github is quite damaging - it leads to a false sense of security among Silverstripe users. Having seen some security alerts related to our repos, they'll assume it'll cover all of them - but it's just a random subset (~10%), updated at random times, potentially months after the vulnerability was disclosed.


Closing GRPC put-file call while pachd is downloading large file results in error when calling list-file

When ingesting a large file through the dash, if the browser window is refreshed before pachd finishes downloading the file, the repo is left in a broken state. When loading, the call to pfs.ListFile() returns an error: Error: could not put file at ""; a node of type directory is already there
To be clear: the error is triggered when the browser creates a call to put-file, has sent the initial message asking pachd to ingest a file and is waiting for pachd to close the stream. Not sure why ending the stream from the client side is causing this, though. Also not sure if there's a way to repro through the CLI

nvm... user error -_-


Volatility3

Hi,
Is volatility3 on the roadmap?  I know I can do the install but curious if it will be included at some point.
Thanks,
Salty

Added a pull request to support this. Vol3 will require that the symbols for the appropriate dump be downloaded separately.


Crash when extracting Date type data from DB

Top Statement from crash logs
static (extension in SQLite):Foundation.Date.fromDatatypeValue(Swift.String) -> Foundation.Date
Build Information

version 0.13.3
Xcode used 13.2.1
Os version iOs 14+
How do do you integrate SQLite.swift in your project?

CocoaPods

General guidelines

app Crashing for some user while extracting Date data from DB.
Start happening after upgrading to version 0.13.3

Looks like there's an unexpected date format in the database. Could you get the value of the row using the debugger?

This crash is happening for user in production app and hence can not check the value with debugger attach.
We have multiple date variable in our DB and they are coming from server and nothing has changed recently with our format.
More ever, this is working for user on mac.
As per user, this started happening with latest update where we update sqlite version to 0.13.3.
Not sure if something was changed there for iOS framework.

From which version did you update?

from version 0.13.2

And for reference.
Date format we use is this
2022-03-24T00:00:00.000


BUG: sql truncate

from the mailing list: https://groups.google.com/a/continuum.io/forum/#!topic/blaze-dev/0LxfZ73pUaQ
DatetimeTruncate was not supported for sql expressions. It was being compiled into an extract instead of a date_trunc
This also makes unit_aliases public for testing and adds some extra test utility functions.

merging on pass


Entering days with leading "0" causes wrong date

The behaviour when entering day of month with a leading zero is wrong. I have an input with datetime="longDate. Assume the input value is "January 1, 2016". When setting the focus to the day of month and press the 0 key, the resulting value is "December 31, 2015".
A probably better behaviour would be to ignore the zero (depending on the format, of course) and after entering one of 1-9 to focus the next format group (in this case the year). So when pressing "02" on "January 1, 2016", the resulting value should be "January 2, 2016" with having the focus on the year.
Very cool extension btw!

Sounds good. I guess some other formats (i.e. 'y', 'M', 'H', 'h', 'm', 's', 'w') should also work like this.

Fixed in 2.2.0

Awesome! Thank you.


Q: Unable to call swagger json url with an ajax call

What version of the library are you using? Is it the latest version?
Yes, am using v2.8.0
What kind of issue is this?
Question.
Am unable to call swagger json url (http://<IP_ADDRESS>:8888/v2/api-docs) with an ajax call.
Is there a way i can get the swagger json with ajax call?

@rajeevnaikte I think you need to correctly set the spring security settings

Yup, that was the problem. I was using 'WebMvcConfigurer corsConfigurer()', but it had some problems. Later i created bean of CorsFilter, it is working.

Was creating JS utility to get all Rest APIs from swagger json, for my project. Have made this utility available public at - https://www.npmjs.com/package/rn-swagger2-client

@rajeevnaikte thank you for reporting your solution back!

@rajeevnaikte also thank you for being a awesome fellow OSS participant!


Support dark mode on windows

More accurately detect if the application is in dark mode, and adjust colors accordingly

Also added a devcontainer, since performing some tests easily on Linux was helpful


Errors on example set up

I was trying to implement in angular cli 9. It was getting an error on the plugin. The web example shows the same errors but render. Unfortunately my project won’t build with the same errors.I know it’s experimental, but would really like to use it possible. Thanks.

@GlitchEclipse What Error?

I'm using Angular 9 (9.1.12) and facing these issues, while trying to replicate the example on my project:

NPM show some warning upon installing rete-angular-render-plugin which seems not compatible with Angular 9?
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS><8.0.0 but none is installed. You must install peer dependencies yourself. npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS><8.0.0 but none is installed. You must install peer dependencies yourself. npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS><8.0.0 but none is installed. You must install peer dependencies yourself.

This issue would prevent the build, solved it using this answer https://github.com/retejs/auto-arrange-plugin/issues/7#issuecomment-531561395
export 'zoomAt' was not found in 'rete-area-plugin'

It does not render anything like the example, with no errors in the build or the browser console

The rete-angular-render-plugin is build for angular 8 but it also works with 9 and 10.

<EMAIL_ADDRESS><8.0.0 but none is installed

This error shows that you have NO version of  @angular/common installed.
Cleanup the npm package folder often does miracles.


Dater - missing files link in README

Hey, in Dater README there is missing link to saved files and prompts:

## Download
Download required prompts and saved files and moving files to target folder.

### Step 1
Download the [saved files and prompts]().  <--- HERE

### Step 2
Move saved files to target folder.

will update in this week

hi @jacekplocharczyk , the download link has updated.


search plugin for rarbg

RarBG seems pretty decent and while their releases also float around on Torrentz etc. I think their site is a lot less noisy.
One thing though. They have some weird bot detection. If the cookie does not contain '7fAY799j': 'VtdTzG69', then it will get caught by the bot filter after the ~5th consecutive request.
I'm not entirely sure they'd appreciate this plugin then, but their RSS feed sucks. Their anti-bot captcha is also extremely easy to circumvent with OCR.

Hey :) Will a json api search work better ?

Possibly. There are two kind of feeds I usually use. A continuously updated  rss feed and search specific rss feeds.
I believe KAT employs an XML search API eg. https://kickass.to/usearch/the walking dead/?rss=1.
But any publicly available search API that allows querying on categories, seeds etc. would be a welcome addition.

https://rarbg.com/pubapi/apidocs.txt
That looks fine to you ? I didnt have enough time to make it into something proper but should have everything you want ?

It looks pretty good. I don't know what "The api has a 1req/min limit." means though.

1 request per minute max :)

Ah. Quite a big limitation though. Not sure it will be of much use with Flexget. It will be fine for simple RSS downloading eg. watching the TV/Movie rss feed every hour.
It won't be of much use for direct searching though.

lowered the time to 1req/10s. That should be fine for searching ?

Yeah, that'll work. I will rewrite my plugin when I get some time.

Would it be possible to get magnet and .torrent options?

We cant really implement .torrent because of many reasons which i cant discuss over github :(

This still a WIP, or good to go?

WIP. Been pretty swamped lately and their API is a little funky. I'll merge it when I get it done :P

@cvium Can you add this to the http://flexget.com/wiki/Searches page?

@gazpachoking Done.

@rarbg Would it be possible to search for specific episodes using tvdb or imdb ids? As it stands, older items can never be found if they are not within the latest 100 uploads.

@cvium
From the api docs - The api searches only in the last 10000 torrents except for imdb,tvrage,tvdb.
Meaning if you use the parameteres search_imdb=xxxx / search_tvrage=xxxx / search_tvdb=xxxx you will be able to search in all the old uploads.
example:
pubapi.php?mode=search&search_imdb=tt0944947&search_string=Game+Of+Thrones+S03E03&token=xxxx

@rarbg  This one fails though: pubapi.php?mode=search&search_imdb=tt1839578&search_string=Person%20of%20Interest%20S02E01&token=gin6q1rtm0
but https://rarbgmirror.com/torrents.php?search=person+of+interest+s02e01 returns results.

@cvium
you need to read the docs :)
by default the api will return only ranked torrents ( internal ) ex scene releases + -rarbg releases + -rartv releases.
If you want other groups included in the results use the ranked parameter with a value of 0 to get them included.

@rarbg You are right, I wasn't thinking. Thanks for the clarification. All is well. I also see you have fixed min_seeders and min_leechers.

@cvium yes they are fixed a long time ago :)


missing 5.9 release

Hi team , when we should expect collectd 5.9 deb package  to be built and available at https://pkg.ci.collectd.org/deb/dists/

And for a 5.9 version so there is a centos8 version as well.


HOTFIX Merge of current branch 0.20 to 0.19

PR Merges current 0.20 to 0.19

Thanks @quasiben ! I had to add additional patches to make sure that local build with conda should work. (https://github.com/rapidsai/cucim/pull/12 )
Wonder if fast-forward branch-0.19 to branch-0.20 is possible once https://github.com/rapidsai/cucim/pull/12 is approved&merged.

Yes, it was.
Thank you Ben!
On Mon, Apr 19, 2021 at 8:22 AM Benjamin Zaitlen @.***>
wrote:

@gigony https://github.com/gigony i merged in latest changes from
branch-20 to here. Was that the last change needed before the release ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rapidsai/cucim/pull/11#issuecomment-822555104, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOW2SQFQGO5TB4MEG2AVQDTJRDDFANCNFSM43BXREKA
.


Undoing participant paste crashes BPMN editor with "Cannot read property 'parentNode' of undefined"

Describe the Bug
When undoing pasting of a participant with lanes it can happen that the BPMN editor crashes / becomes unusable. The app reports the following trace:
Cannot read property 'parentNode' of undefined
    at file:///Downloads/camunda-modeler-3.5.0-linux-x64/resources/app.asar/public/6.6.js:1:375923
    at iterator (webpack:///node_modules/diagram-js/node_modules/min-dash/dist/index.esm.js:145:0)
    at file:///Downloads/camunda-modeler-3.5.0-linux-x64/resources/app.asar/public/6.6.js:1:375872
    at iterator (webpack:///node_modules/diagram-js/node_modules/min-dash/dist/index.esm.js:145:0)
    at parents (webpack:///node_modules/diagram-js/lib/core/GraphicsFactory.js:156:9)
    at file:///Downloads/camunda-modeler-3.5.0-linux-x64/resources/app.asar/public/6.6.js:1:604837
    at file:///Downloads/camunda-modeler-3.5.0-linux-x64/resources/app.asar/public/2.2.js:1:17172
    at listener (webpack:///node_modules/diagram-js/lib/core/EventBus.js:366:0)
    at _invokeListener (webpack:///node_modules/diagram-js/lib/core/EventBus.js:351:0)
    at _invokeListeners (webpack:///node_modules/diagram-js/lib/core/EventBus.js:312:0) [ error ]

Steps to Reproduce

Open test diagram
Copy participant with children
Paste participant with children
Undo
Try to interact with the modeling canvas
See the error shown above pop up

Expected Behavior

Undoing does not lead to the editor blowing up.

Environment

OS: Any
Camunda Modeler Version: v3.5.0, v3.4.1, v3.3.5

This may be related, however it does not fix the issue. I can still reproduce it on bpmn-js@master.


The problem with the incoming call.

I try SwiftVoiceQuickstart when I call from the first device to the second one, after I heard the welcome phrase on the first device, on the second I see Alert with the ability to answer the call, but the first device receives Error - 12100 (Error on line 1 of document : Content is not allowed in prolog) if the second device answers the call , then I hear the phrase with congratulations. I use node.js server. Please, tell me, how can I fix this?
async function placeCall(request, response) {
  // The recipient of the call, a phone number or a client
  var to = null;
  var from = null;
  if (request.method == 'POST') {
    to = request.body.to;
      from = request.body.from;
  } else {
    to = request.query.to;
      from = request.query.from;
  }
  console.log(to);
  // The fully qualified URL that should be consulted by Twilio when the call connects.
  var url = request.protocol + '://' + request.get('host') + '/incoming';
  console.log(url);
  const accountSid = process.env.ACCOUNT_SID;
  const apiKey = process.env.API_KEY;
  const apiSecret = process.env.API_KEY_SECRET;
  const client = require('twilio')(apiKey, apiSecret, { accountSid: accountSid } );

  if (!to) {
    console.log("Calling default client:" + defaultIdentity);
    call = await client.api.calls.create({
      url: url,
      to: 'client:' + defaultIdentity,
      from: 'client:' + from,
    });
  } else if (isNumber(to)) {
    console.log("Calling number:" + to);
    call = await client.api.calls.create({
      url: url,
      to: to,
      from: callerNumber,
    });
  } else {
    console.log("Calling client:" + to);
    call =  await client.api.calls.create({
      url: url,
      to: 'client:' + to,
        from: 'client:' + from,
    });
  }
  console.log(call.sid)
  //call.then(console.log(call.sid));
  return response.send(call.sid);
}

My goal is to make a full-fledged call between two users.
Thanks.

Hi @alexanderkhitev
My apology for the delay of responding back to you.
Can you go to your Programmable Voice Call Logs page and provide us the Call SID (CAxxxxx) when you are experiencing this issue?
Thanks
-bobie

Hi @bchen-twilio ! I solved this problem but did not close the issue, sorry. Thank you!

Awesome. Thanks @alexanderkhitev 👍


It used to work but now I get “SSL: CERTIFICATE_VERIFY_FAILED” Error

I use it ~700 times a day with 1 name each time.
What can I do to solve it ?

What operating system and Python version are you using, how did you install Python, and have you read this note on Python 3.6 on macOS if it applies to you?

Cannot repro this without more information, and the likely causes are all related to Python environment setup outside the control of this package. Closing.


refactor(tenant): move bucket and urm auth layers to tenant service

Closes #17426
Closes #17425
This PR moves the auth layers for bucket and URM services into the new tenant directory.

[ ] Well-formatted commit messages
[ ] Rebased/mergeable
[ ] Tests pass

I can undo this if it's overkill but I added a unified NewMockAuthorizer because I didn't want three mock authorizers in different parts of the code base.


Two binary modules installing concurrently can corrupt node headers

Since switching to yarn, we started observing random yarn install failures in one of our binary dependencies (fibers, the other being fsevents).
I was able to pinpoint the cause:

Yarn is executing the install scripts of both deps in parallel
The system doesn't have node headers
Both install scripts invoke node-gyp
Two instances of node-gyp running in parallel are both downloading node header files
In around 10% of our builds, this resulted in a situation where I think one process was extracting files from a tarball that the other process was writing to. Not sure what exactly went on, but as a result the extracted header files were truncated and not parseable.

See https://github.com/yarnpkg/yarn/issues/1874
Could this be solved by downloading and extracting into a tempdir and then moving that into its proper place afterwards?

Could?  Yes.  Should?  I don't think so, downloading the same tarball twice is wasteful.
Since this happens with yarn and not npm, and because other download scripts are presumably also affected, I'm inclined to kick it back to yarn.


Build Cancellation

Implement distributed build cancellation via Consul.
See diagram:
Furan Cancellation.pdf
Fixes #32

Verified working in Docker Compose


Add dyno name to the hostname.

This makes the dyno name semi unique and fixes the issue where
counts from multiple hosts are treated as the same host and
normalized by datadog

Actually, I didn't realize there was already an open PR for this. Closing.


[Enhancement] X Axis Camera Offset

When the head of the player model is moved forward the eye position remains the same. This is especially noticeable on quadrupedal models, as the camera is centered on the body and not the head.
If added it would be ideal to have the position of both first and third person cameras as a part, and the ability to move it from its pivot point like with normal parts, if that makes sense.

You can move the whole body using Scaling/Model Display. Move the model to the eye postion. Minecraft doesn't have the ability to move the camera like that easily, and it would be picked up by serverside anticheat anyway.
With Pehkui you can adjust the eye height and third person camera distance (it's a separate mod).


add appointment status enum

Add appointment status enum
The appointment status values are not well documented unfortunately and span multiple formats (int/str). This enum gives as much flexibility as possible while giving callers the opportunity to call them by name rather than their short letter code.
I have no idea how y'all do enums internally but hopefully this isn't too far off base.
Breaking Changes
N/A

Apologies - can't tag reviewers so have to @dillonstreator @elliehastings manually. Thanks in advance!

no worries @dillonstreator :smile: - addressed comments!
threw in a call to Valid() in the String() implementation so we can still return "" if the enum instance is not a valid AppointmentStatus. Without it - String() just echoes the current string which makes error checking more difficult


Create a flag emptyGetsAll

Is there an existing issue or pull request for this?

[X] I have searched the existing issues and pull requests

Feature description
Create an option that when the query is empty, instead of getting no results, all results are returned.
Desired solution
non-empty query: current behavior
emptyGetsAll is set to true: all results returned on empty input
emptyGetsAll is set to false: no results returned on empty input
default for flag should be false.
Alternatives considered
Hardcoding outside of library; ugly.
Additional context
No response

I have a branch ready with this feature, documentation, and tests, but am unable to push my branch because of permissions.

Love the product but this feature is must have.

Workaround in my Svelte project:
    $: if (fuse) {
        if (searchInput == "") {
            graphNodesStore.set(fuse._docs); // <= to get all results
        } else {
            graphNodesStore.set(fuse.search(searchInput).map((row) => row.item));
        }
    }


Replace images in README.md

Given the fact that the Busty bot's profile picture has been updated and the reasons we updated it, we should change the promotional images to ones which use the new profile picture.

Sounds sensible to me.


Frontend tries to fetch faviorite_status over http (not https)

I'm keep getting 2 error toasts on /superset/welcome: "There was an error fetching the favorite status: NetworkError when attempting to fetch resource."
In js console I see that it tries to reach /api/v1/dashboard/favorite_status/?q=%21%2849%2C48%2C47%29 over http, but I'm running that on https on custom domain behing Cloudflare. I'm runinng that via docker-compose, everything else works ok.
Expected results
No error messages, frontend fetches via https.
Actual results
AJAX fetch calls being blocked due to violating https -> http.
How to reproduce the bug

Go to welcome dashboard
See error "There was an error fetching the favorite status: NetworkError when attempting to fetch resource."

Environment
(please complete the following information):

superset version: c64fcd2ba443
python version: Python 3.7.9
node.js version: v10.19.0

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
I have SUPERSET_WEBSERVER_PROTOCOL = "https" in docker/pythonpath_dev/superset_config.py and I've built frontend with npm run prod

This should be fixed in the next release

@nytai do you have any suggestion how to quick fix that? I've been looking in SupersetClient but was struggling to with build... Is it right clue?

https://github.com/apache/superset/issues/12592

Thanks! Setting ENABLE_PROXY_FIX=True in docker/pythonpath_dev/superset_config.py helped!


feat: add BroadcastSignalCommand

Added BroadcastSignalCommand implementation
Added unit tests
Done by following PublishMessageCommand implementation
closes #752

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


How to use multiple PNG's in PSD as a layer?

Describe the bug
Currently I am able to save the single PNG file as a PSD which default has a background layer only. But I want to add more layers. How to achieve this?

Have you solved the issue now? How are single and multiple images handled separately? Could you provide a sample code?


How can i get MS COCO 'train2014(or2017)_gt_roidb.pkl'file in cache folder?

I'm trying to train this code on my pc with your instructions.
But there is a problem that generating ~_gt_roidb.pkl process.
I've read dataset instructions but nothing explained about generating MS COCO cache folder and ~_gt_roidb.pkl file, even can not find the method on https://github.com/rbgirshick/py-faster-rcnn/blob/77b773655505599b94fd8f3f9928dbf1a9a776c7/data/README.md .
Is there any way to get that file to train this model?

It was just directory problem.
Just making ~/data/COCO/cache directory can solve this problem.

is there anyone who got the train(minval)_gt_roidb.pkl? How to get that? Thanks in advance

@GuoGuoYao and @lc17721825 , Just make the folder named cache in the directory of MS COCO dataset. As for my case, my MS COCO directory is existing in the home directory (~/data/COCO) and I've made cache folder in that MSCOCO directory. You guys don't have to find out or download _gt_roidb.pkl file. Just making cache folder can solve this problem.

Well, my bad, sorry. Thanks a lot!!!


option to save Dockerfile from fn build ?

The problem is that after a user does 0->1 and they want to do more complex stuff 1->2 (add template files, additional dependencies, gifs of cats, you name it), a user has to dig around in our various examples to get a Dockerfile that they can add additional build information / files to (at least, currently it's very 'magic' and it's not clear how to go about doing 1->2). This won't always be the case, but it seems like it's at least a probable case.
currently, we write a Dockerfile to a tmp file that is removed after fn build / fn run / etc. and there's no way to get the contents of that file out easily. At least, this is my interpretation of a problem a user had in getting started very recently, and what we did to get over the hump was to comment out the code that removes the file, copy it, and modify it as neither of us could find a Dockerfile anywhere in the examples that just worked, when fn run did.
some options:

fn run --save-dockerfile -> save $PWD/Dockerfile with contents
fn run --cat-dockerfile -> print contents of Dockerfile to stdout before Building image.....
${your_idea_here} ?

related to #383


Link to external sites in the menu

I've made some code for supporting a 'redirect' variable in page frontmatter to make the menu link to an external site.
See example: https://github.com/fuzzy76/brothersinarms/blob/master/_includes/header.html
Is this something you'd accept a PR on?

Hello.
I don't think so. It seems to add useless complexity for something that people can just add themselves in that same file.
Thanks for proposing anyway !


Tokenizer tests should be refactored (all models)

Discussed with @joecummings Currently, expected_tokens is explicitly given in each test separately, even it is pretty always not unique. With current formatting, it makes tests looks really ugly and not strictly. Maybe we should do fixture or add noqa there?

If everyone agree with such change can open PR

hey Krammnic, are you in our discord? Can you text me there? FelipeM

hey Krammnic, are you in our discord? Can you text me there? FelipeM

Sure

hey Krammnic, are you in our discord? Can you text me there? FelipeM

Sure

Somehow haven't found you. My handle is same as here.

@RdoubleA @joecummings My opinion that something like noqa + fixture, will be enough. We actually don't really want to see all values clearly, because if something will fail we will obviously see diff. Will open PR


Cant Figure Out Multiple PC Monitoring

I am having trouble figuring out how to link multiple PCs up that are on the same network into one screen. I want to be able to monitor the CPU usage of the 2 computers, I have tried looking around but there isnt much information that I have found.
If someone can point me in the right direction?
Many thanks!

Hi @Lukemul6.

how to link multiple PCs up that are on the same network into one screen

What is the definition of a screen here? Is it a Wave app/script?
You can either:

Have all your PCs write to a shared database which would be polled by your Wave app and display the results. The latency might be an issue here.
If you just want to display the dashboard without capturing user input, wave scripts are enough in that case. All you need to do then is to:

Start wave server (waved) on whichever PC. (./waved)
For each PC, setup a periodically run python script (e.g. cron job), that would update the content on your page.

For example script for PC1 (script1) could be
from h2o_wave import site, ui

# Get the web page at route '/'.
# If you're running this example on your local machine,
# this page will refer to http://localhost:10101/.
page = site['/']

# Update CPU usage on the page.
page['cpu1'] = ui.markdown_card(
    box='1 1 2 2',
    title='CPU Usage 1',
    content='...',
)

# Finally, sync the page to send our changes to the server.
page.save()

and for PC2 (script2.py):
from h2o_wave import site, ui

# Get the web page at route '/'.
# If you're running this example on your local machine,
# this page will refer to http://localhost:10101/.
page = site['/']

# Update CPU usage on the page.
page['cpu2'] = ui.markdown_card(
    box='3 3 2 2',
    title='CPU Usage 2',
    content='...',
)

# Finally, sync the page to send our changes to the server.
page.save()

Then set the env variable H2O_WAVE_ADDRESS (see docs) to point to your PC with waved running and run the scripts:
H2O_WAVE_ADDRESS='http://<ip-of-your-waved-machine>:port' python script1.py

For a more realtime-help with questions like these, I recommend joining our Discord.

Thanks for your response. I made a post in the discord as I need further help.

The discussion continues in https://discord.com/channels/1022255416454946906/1078877598119100546/1078877598119100546.


fix issue with comparing client ID objects

What's your use case where !== isn't working? Mongo's ObjectIds?
While I'm not against this change per se, I'm concerned about edge cases where #toString isn't returning something useful (i.e. [object Object]). I'd rather document that the client.id returned by the model must be value-comparable than that the value returned by client.id.toString() must have that property. IMO this change goes against the framework-agnostic design goal.
There's another line in RefreshTokenGrantType#getRefreshToken comparing the client_id. If anything, both should change.

Sorry for my slow response here, I wasn't subscribed to this thread. My apologies!
The problem was indeed with Mongo IDs. The RefreshTokenGrantType instance does look like the same issue. I'll need to refresh my memory as to the original problem with this object comparison, but I see your point where the ID cannot be parsed as a string properly. Would you like me to take another crack at this in coming up with something a little more framework and DB agnostic?

I've updated this PR to be more agnostic about underlying database engines. Does the code look okay?

With these changes ids are not compared at all in cases where only one of code.client.id and client.id is an object.
I'm still not convinced the existing behavior should be changed. Is it really that inconvenient to just add
client.id = client.id.toString();

if required inside the model function before returning the client object?
IIRC if you're using Mongoose, id is already a string and _id is the ObjectId instance. And for the official mongodb package the correct method is called toHexString instead of toString. toString returns 'ObjectId("...")' which would work too, but more by accident than because it's intended to.

I'm using the Loopback Mongo Connector, but I like your idea of handling this in my model function. It didn't occur to me that I could intercept this with my model function first, so I'll give this a shot and see if I can get this to work! Thanks for this.

Okay, I got it working. I realized my main problem was not recognizing that the client argument required by the authorization code grant passes through my getClient model function, so I converted that ID to a string, and converted the authorization code client ID to a string as well, and now I'm cool.
Sorry for taking your time with this! I appreciate your help, and we're excited about releasing our upcoming product that features your library!

Great to know you got it working.
(Hopefully very soon) upcoming documentation and examples will make it a lot clearer how to implement the model and what exactly is expected from the return value of each function.


Anchor links in Readme files are broken

Please describe the bug
In a repo's readme, you can make an anchor link specified like [Link Name](#AnchorName), where #AnchorName corresponds to a Markdown heading. On GitHub, this is correctly translated into an HTML anchor link that scrolls the page to the relevant section. But when that readme is displayed on the Swift Package Index, the link destination has user-content- prepended to it, which makes it not work.
Explain the steps needed to reproduce the bug

Go to https://github.com/pointfreeco/swift-url-routing (for example).
Look at the list of anchor links near the top of the readme, and hover over the Documetation link.
Note that your browser's link preview bar (if visible) says "Go to #Documentation on this page".
Click the link and see that it navigates to the Documentation section.
Go to the same project on the Swift Package Index at https://swiftpackageindex.com/pointfreeco/swift-url-routing.
Hover over the Documentation link in the readme.
Note that your browser's link preview bar says "Go to #user-content-Documentation on this page"
Click the link.

What was the expected behaviour?
Page scrolls or jumps down to the Documentation section.
Screenshots
If applicable, please add screenshots to help explain your problem.
What web browser were you using? (if relevant)
Safari
If you're reporting a bug with the front end, please include your browser information below:

Platform: Desktop
Browser Safari 17.6 (196<IP_ADDRESS>.5)
Version macOS 14.6.1 (23G93)

Additional context

Ah, thanks for reporting this, @ZevEisenberg! This must have changed on the GitHub side, as we have some processing code that's supposed to fix them, and they certainly worked until recently. I'll take a look to see what has changed.
I've been reluctant to put a snapshot test in that snapshots the GitHub README API response so we can be aware of rendering changes as I bet it changes all the time. That said, maybe a separate little tool that I run every few weeks might be a good idea.

This is now fixed and deployed to production. Thanks again for the bug report, @ZevEisenberg!


Check box Questions: Each answer shows in separate column

Is your feature request related to a problem? Please describe.
When a check box button question has multi select answers, all answers show up in one field separated by commas in the CSV which is a problem for reporting.

Describe the solution you'd like
Have multi select answers show each answer in a separate column of the CSV for each possible answer.
Additional context
Add any other context or screenshots about the feature request here.
Done when
What conditions need to be met before this issue can be closed?

This is a simple design and should not require a PRD.
Example: Question with 3 radio button answers
Question
Answer1
Answer2
Answer3
Display in CSV as:

Moving to ready to get developer's input on LoE.  Possibly a feature to be turned on/off depending on municipality.

(Swathi's comment): consider using a semi-colon to separate values.

@elisekalstad - just to confirm- for a check box type question (Not Radio question) if there are three answers selected like :

You want the CSV to look like this:

Yes! That looks great!

Sorry @elisekalstad , This will be a problem. This solution of adding all options will be better. So for a question which contains 5 options like:

The Export will look like (All 5 columns and only the values picked will have non-empty)-

@swatkat1 --That's perfect!

To review with Product Design Committee on 9/6 for approval across jurisdictions.

Reviewed with Product Design Committee on 10/11. Preference for more detailed table, added to the PRD: https://docs.google.com/document/d/148WiVgQ-m9vj3fy1HO4cgh-w4BrvZjDaO-B17EMImtA/edit#heading=h.bknox3ib8wpb


how to prevent submit from setting the viewport to the result coords?

Is there any way to prevent the map from zooming into the selected address? I'm trying to use the geocoder to basically just allow the user to type in an address, then setting the lat/lng into the state without actually moving the viewport there.
essentially i was to use this value from the state to filter my markers based of a proximity around result.result.center coords
handleGeocoderViewportChange = viewport => {
  const geocoderDefaultOverrides = { transitionDuration: 1000 };
  return this._onViewportChange({
    ...viewport,
    ...geocoderDefaultOverrides
  });
};

handleGeocoderResult = result => {
  this.setState({
    searchLngLat: result.result.center
  });
};

<Geocoder
  mapRef={this.mapRef}
  onViewportChange={this.handleGeocoderViewportChange}
  onResult={this.handleGeocoderResult}
  mapboxApiAccessToken={"***"}/>

Hi @mark-rodgers, sorry, but I don't think that's possible. You'll probably need to build a custom component to do that using the Mapbox geocoding API. https://docs.mapbox.com/api/search/#geocoding
You could prob borrow a lot of code from https://github.com/mapbox/mapbox-gl-geocoder/blob/master/lib/index.js

@mark-rodgers if you can access all the config settings from the geocoder-api, you can set flyTo to be false, which should do what you are looking for, no?
https://github.com/mapbox/mapbox-gl-geocoder/blob/master/API.md

@easherma you can actually pass flyTo down as a prop, but unfortunately that only prevents the animation from happening. It will still go to the location that is searched for.
Ideally, this component shouldn't move if you pass in a noop in as the onViewportChange prop value. However, since I'm using the mapbox-gl-geocoder object to do most of the heavy lifting, I don't think that's possible. If I ever get around to writing a version 2 of this component, I plan to remove the mapbox-gl-geocoder dependency. Then I'd be able to get rid of this unexpected behavior.

@easherma you're actually right. I misunderstood flyTo. You have to set flyTo to false and also pass in a noop to onViewportChange.
handleGeocoderResult = result => {
  this.setState({
    searchLngLat: result.result.center
  });
};

<Geocoder
  mapRef={this.mapRef}
  onViewportChange={() => {}}
  flyTo={false}
  onResult={this.handleGeocoderResult}
  mapboxApiAccessToken={"***"}/>

@mark-rodgers I'm going to remove the flyTo param as that should always be false. This is a bug my code due to my misunderstanding of what the flyTo option does. onViewportChange should be the only way to update the viewport. I'll also default onViewportChange to a noop. That way you won't even need to provide those props.

@mark-rodgers just published v1.8.0. Now you should be able to just do this and the weird behavior of the viewport updating even when passing a noop to onViewportChange is gone. I may not have to make a version 2 after all. :)
handleGeocoderResult = result => {
  this.setState({
    searchLngLat: result.result.center
  });
};

<Geocoder
  mapRef={this.mapRef}
  onResult={this.handleGeocoderResult}
  mapboxApiAccessToken={"***"}/>

Let me know if you have any other problems.

Awesome! I’ll checkout the latest release soon, I’m sure this update will be useful to many!

Yay! Glad I could help clarify.
On Thu, Apr 11, 2019 at 12:44 AM Mark Rodgers<EMAIL_ADDRESS>wrote:

Closed #31
https://github.com/SamSamskies/react-map-gl-geocoder/issues/31.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SamSamskies/react-map-gl-geocoder/issues/31#event-2268118480,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKDTT4nIoHGajOpOqrUV6RFjn64LCiKdks5vfsuwgaJpZM4cfkgt
.

--
Eric Sherman
224-402-0004


up logs -f just waits

Description
up logs -f just gets stuck
Steps to Reproduce
Run up logs -f on a deployed project.
up logs works fine. With the -v switch is just exits?
~/go/src/github.com/kaihendry/count$ up logs -v -f
     8ms     DEBU up version 0.2.4
     0s      DEBU region from aws shared config "ap-southeast-1"
   ⠋ 0s      DEBU track "Logs" map[version:0.2.4 query:false query_leng     0s      DEBU track "Logs" map[version:0.2.4 query:false query_length:0 follow:true
since:0s os:linux arch:amd64]
     0s      DEBU query ""
     0s      DEBU follow
     0s      DEBU enter group=/aws/lambda/count
     170ms   DEBU request group=/aws/lambda/count start=1505699770182
~/go/src/github.com/kaihendry/count$

Weird thing is that sometimes it works, but often it doesn't I guess it's a CloudWatch problem, since the query look right. sigh

hmm CloudWatch logs does have a pretty bad delay (~5s) but LMK if there's anything you think is busted or confusing with the query language and I can check it out!


Auth Emulator - Indicate valid Username characters when invalid character(s) submitted

Is your feature request related to a problem? Please describe.
Using the Auth Emulator page for GitHub (may be the same for other Identity Providers):
http://localhost:4280/.auth/login/github
If the user enters invalid characters for Username, an attempt to submit the form fails "silently" in the UI.
Example value for Username:
یونیکد
The console gives additional information:
The string to be encoded contains characters outside of the Latin1 range.
Uncaught DOMException: Failed to execute 'btoa' on 'Window': The string to be encoded contains characters outside of the Latin1 range.     at saveCookie (http://localhost:4280/.auth/login/github:168:54)     at HTMLFormElement.<anonymous> (http://localhost:4280/.auth/login/github:316:11)     at HTMLFormElement.dispatch (https://ajax.aspnetcdn.com/ajax/jquery/jquery-3.2.1.min.js:3:10316)     at HTMLFormElement.q.handle (https://ajax.aspnetcdn.com/ajax/jquery/jquery-3.2.1.min.js:3:8343)
Describe the solution you'd like
If it is required that Username characters be in the Latin1 range, add a validation message near the Username field in the UI.
If the full range of Unicode characters is allowed, adjust logic, to allow such characters.
Describe alternatives you've considered
Open the DevTools Console while running, to view run-time exceptions
Additional context
Exception is thrown in this source code file:
https://github.com/Azure/static-web-apps-cli/blob/main/src/public/auth.html
      function saveCookie(formElement) {
        const data = localStorage[hashStorageKey(formElement)];
        document.cookie = `StaticWebAppsAuthCookie=${btoa(data)}; path=/`;
      }

This link may provide a workaround for the problem:
https://developer.mozilla.org/en-US/docs/Glossary/Base64
function utf8_to_b64( str ) {
  return window.btoa(unescape(encodeURIComponent( str )));
}

function b64_to_utf8( str ) {
  return decodeURIComponent(escape(window.atob( str )));
}

// Usage:
utf8_to_b64('✓ à la mode'); // "4pyTIMOgIGxhIG1vZGU="
b64_to_utf8('4pyTIMOgIGxhIG1vZGU='); // "✓ à la mode"

I found that, if I change the Javascript in auth.html:
      function utf8_to_b64( str ) {
        return window.btoa(unescape(encodeURIComponent( str )));
      }
      function saveCookie(formElement) {
        const data = localStorage[hashStorageKey(formElement)];
        // document.cookie = `StaticWebAppsAuthCookie=${btoa(data)}; path=/`;
	document.cookie = `StaticWebAppsAuthCookie=${utf8_to_b64(data)}; path=/`;
      }

The redirect occurs in the browser.
If a Function needs to inspect the x-ms-client-principal cookie, a small change is required
(based on https://github.com/MicrosoftDocs/azure-docs/blob/master/articles/static-web-apps/user-information.md):
        public static ClaimsPrincipal Parse(HttpRequest req)
        {
            var principal = new ClientPrincipal();

            if (req.Headers.TryGetValue("x-ms-client-principal", out var header))
            {
                var data = header[0];
                var decoded = Convert.FromBase64String(data);

                // Use UTF-8 Encoding
                // var json = Encoding.ASCII.GetString(decoded);
                var json = Encoding.UTF8.GetString(decoded);
                principal = JsonSerializer.Deserialize<ClientPrincipal>(json, new JsonSerializerOptions { PropertyNameCaseInsensitive = true });
            }

            principal.UserRoles = principal.UserRoles?.Except(new string[] { "anonymous" }, StringComparer.CurrentCultureIgnoreCase);

            if (!principal.UserRoles?.Any() ?? true)
            {
                return new ClaimsPrincipal();
            }

            var identity = new ClaimsIdentity(principal.IdentityProvider);
            identity.AddClaim(new Claim(ClaimTypes.NameIdentifier, principal.UserId));
            identity.AddClaim(new Claim(ClaimTypes.Name, principal.UserDetails));
            identity.AddClaims(principal.UserRoles.Select(r => new Claim(ClaimTypes.Role, r)));

            return new ClaimsPrincipal(identity);
        }

Thanks for pointing this out. Looks like Static Web Apps is using UTF8 to encode the client principal, so it's probably more correct for the emulator to encode as UTF8 and for the Functions code samples to use UTF8 when decoding.

@anthonychu Thanks for investigating.
Do you think we should:

Mark this issue as a CLI bug (for the saveCookie problem)?
Create a docs issue for the ClaimsPrinicpal sample?


Upgrade apt dependency

Please consider upgrading to apt module version > 2.0.0
This pull request also fixed the deprecation warnings.

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then  say 'jenkins, test it'.

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then  say 'jenkins, test it'.

Hi,
I just bumped the version to allow < 3.0.0
The key change is not possible yet since some PE versions ship with a pl-apt version < 2.0.0


npm install -g phantomjs2 seems to be failing

I was actually trying to install mocha-phantomjs which seems to have a dependency on phantomjs2 which results in the following error, even if I try to install just phantomjs2 by itself.  It seems to be pointing to a fork of this repo rather than this repo itself and the path for the zip file its trying to download does not exist.  Anyone have any ideas?
$ sudo npm install -g phantomjs2
/usr/bin/phantomjs -> /usr/lib/node_modules/phantomjs2/bin/phantomjs

><EMAIL_ADDRESS>install /usr/lib/node_modules/phantomjs2
> node install.js

Looks like an `npm install -g`; unable to check for already installed version.
Downloading https://github.com/bprodoehl/phantomjs/releases/download/2.0.0-20141016/phantomjs-2.0.0-20141016-linux-x86_64.zip
Saving to /usr/lib/node_modules/phantomjs2/phantomjs/phantomjs-2.0.0-20141016-linux-x86_64.zip
Receiving...
Install exited unexpectedly

@socketwiz Sorry, but we don't maintain PhantomJS in npm registry. Please open an issue in the original repository (https://github.com/bprodoehl/phantomjs)

Ah sorry, I didn't realize that.  And they seem to have issues disabled, oh well :(


Report on the creation of the Crystal port

Hi @ankane
I have ported this wonderful library to blingfire-crystal.
And blingfire-ruby is used in the LibUI example.
I learn a lot reading the code you write.
I wish you all the best. Thank you.

Great to hear, thanks @kojix2!


use old style by default

Use 2.5 style by default

/azp run

/azp run

How would you suggest we test the new visual styles?  I was running the token-experiment branch to do that, so will there be a branch with this setting changed to Latest?

How would you suggest we test the new visual styles?  I was running the token-experiment branch to do that, so will there be a branch with this setting changed to Latest?

yes. you will need to change the testapp to use latest manually

yes. you will need to change the testapp to use latest manually

will take the change in merge feature/token-experiment with master branch

will take the change in merge feature/token-experiment with master branch


Updated dependency bounds

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

requirements: build: python>=3.6 must contain a space between the name and the pin, i.e. python >=3.6
requirements: run: python>=3.6 must contain a space between the name and the pin, i.e. python >=3.6
requirements: run: numpy>=1.13, <2 must contain a space between the name and the pin, i.e. numpy >=1.13,<2
requirements: run: scipy>=1.0.0, <2 must contain a space between the name and the pin, i.e. scipy >=1.0.0,<2
requirements: run: scikit-image>=0.15, <1 must contain a space between the name and the pin, i.e. scikit-image >=0.15,<1
requirements: run: tifffile>=0.13,<1 must contain a space between the name and the pin, i.e. tifffile >=0.13,<1
requirements: run: pywavelets>=1.0.0,<2 must contain a space between the name and the pin, i.e. pywavelets >=1.0.0,<2
requirements: run: crystals>=0.6.5,<1 must contain a space between the name and the pin, i.e. crystals >=0.6.5,<1
requirements: run: npstreams>=1.6,<2 must contain a space between the name and the pin, i.e. npstreams >=1.6,<2
requirements: run: pyyaml>=3.1,<4 must contain a space between the name and the pin, i.e. pyyaml >=3.1,<4

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

requirements: build: python>=3.6 must contain a space between the name and the pin, i.e. python >=3.6


Inconsistent behavior for variables_collections and outputs_collections parameters (contrib/layers)

Using layers from contrib,

The outputs_collections parameter accepts either a string or list of strings.
The variables_collections parameter requires a list of strings.

Granted, the documentation does specify this
variables_collections: optional list of collections for all the variables or
      a dictionay containing a different list of collection per variable.
outputs_collections: collection to add the outputs.

But I don't think it's very obvious.  Furthermore, is it really necessary to have these two parameters behave differently?
The variables_collections parameter is passed to the model_variable function()
Currently, the model_variable() function performs this before creating the variable:
  collections = list(collections or [])
  collections += [ops.GraphKeys.VARIABLES, ops.GraphKeys.MODEL_VARIABLES]

So, if
# variables_collections = 'kernels'
collections
['k', 'e', 'r', 'n', 'e', 'l', 's']

Whereas, for outputs_collections it uses the utils.collect_named_outputs() function, wherein
# variables_collections = 'kernels'
names = (names,) if isinstance(names, six.string_types) else set(names)
names
('kernels',)

Perhaps the behavior of these two parameters should be unified?

This is a bug. Thanks for reporting.

The outputs_collections behavior is clearly the correct one. Both arguments should accept the same types of input, that is, either strings or set types.

We chose not to include the collections arguments when we ported the layers to core.
When using the core layers: If you need access to the variables, use the scope. If you want to add the activations to a collection, do that using the returned tensor.
I'm closing this, since the contrib layers are being deprecated in favor of those in core.

the bug still exists in tf.contrib.layers.batch_norm(variables_collections=['vars'], outputs_collections='vars2'). If you do just variables_collections='vars' it will return an empty list. Annoying if you do not know this thread.

Pretty sure it's not just batch_norm.
On Sat, Jun 17, 2017, 10:31 AM Robomate<EMAIL_ADDRESS>wrote:

the bug still exists in
tf.contrib.layers.batch_norm(variables_collections=['vars'],
outputs_collections='vars2'). If you do just variables_collections='vars'
it will return an empty list. Annoying if you do not know this thread.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/5551#issuecomment-309218406,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEsrOD0jGCHpZoMGUZEBoI3iuPK-eFjGks5sE-NbgaJpZM4KwHT0
.


Ensure we're using thread of the newly created message

This PR fixes #16.
The bug was introduced as part of the codebase refactoring done in 67a22722e2451bcb9d54256036e5a30ce6447c6e where we started using the message to be sent instead of the already sent message while building up the response.

@armiol @alexander-yevsyukov PTAL


stricter checking of migration target

Summary
It will disallow ->migrate($n) if $n is greater than the known levels.
Motivation
Currently 'migrate' will disallow a change if $latest is greater than the known levels ($latest).  This change should mean the user doesn't get into that situation erroneously.
Slightly related, 'migrate' allows a change to levels for which there are no steps.  That makes sense if the $target is within the range of known steps.  (eg migrating 3-->2 even tho there's no 'down' step from 3 to 2)
(I suppose the biggest gain is for authors of other backends since it clarifies the semantics.)
References
https://irclog.perlgeek.de/mojo/2017-06-25#i_14784815

Apologies.  The scenario is already adequately handled.


reset password

I am admin. how to reset password for one of my players?
This player didn’t specify Email address for Recovery.

/flexiblelogin resetpw username password


Maybe cannot distinguish latest key-value in nested-kv of SetAccountDetail?

In https://github.com/hyperledger/iroha/pull/732/ nested-kv storage is adopted.
It seems to distinguish creator_account_id and grantee's account_id, but if they use the same key, how to know which one is the latest information?
Example:
{ "my_account@domain" : { "same_key" : "foo" }, { "admin@domain" : { "same_key" : "bar" } } }

Right now, if two users use same keys they are independent one from another.  admin@domain will have access for modification only to field with "admin@domain" key

Yes, but what is intended for? Maybe I missed some requirements?
If AccountDetail, that is a substitute for ComplexAsset, can be different depending on account_id,
maybe similarly AccountAsset needed to be different depending on account_id, but the latter one is obviously wrong.

I'm sorry, my understanding of kv-storage purpose is wrong. So I'll close this PR.


Code Crashes on 7k Event Sample

Steps to reproduce:
sdl_make_tracklooper -m8c2
./bin/sdl -n 7000 -v 0 -s 8 -o test.root --input /mnt/data1/gsn27/samples/CMSSW_12_5_0_pre3/src/ttbar_CMS12_9000/
Extra info: This bug does not occur if run with "-w 0"

the crash is apparently on the host side.
 Not sure what's going on yet.

Here's where the original error is being thrown:
https://github.com/SegmentLinking/TrackLooper/blob/f87e39b2e64fc5354cb88e3284cc05f871ce8211/code/core/trkCore.cc#L970-L978

Here's where the original error is being thrown. It seems like this error occurs if you run over multiple input files, so I get the same error with n=1100 events since each input file stores 1000 events:
https://github.com/SegmentLinking/TrackLooper/blob/f87e39b2e64fc5354cb88e3284cc05f871ce8211/code/core/trkCore.cc#L970-L978

the stack trace points to https://github.com/SegmentLinking/TrackLooper/blob/0b170ae16a79841802d23e2551a6d08aa6dd19bd/code/core/write_sdl_ntuple.cc#L1020
Is your version of the code the same as in master for this file?

the stack trace points to
https://github.com/SegmentLinking/TrackLooper/blob/0b170ae16a79841802d23e2551a6d08aa6dd19bd/code/core/write_sdl_ntuple.cc#L1020
Is your version of the code the same as in master for this file?

Sorry I was not clear, the stack trace points to that location, but if you look at the original screenshot I posted this trkCore.cc hitidx check throws an "Error" before the code actually crashes.


add option to allow self-signed certificates to admin

code was already prepared but optioned not exposed to admin config + testing & dependency updates

Discussed with @Apollon77, merged


Plug-in causes benches and bins to appear on paths outside owned land

This plugin is great for quickly putting benches and bins in the park, but there is an issue that has yet to be fixed: this plugin actually causes benches and bins to appear on paths that are in land not owned by park, even if the sandbox mode cheat is already off.

Hey @Fred-1044276, thanks for letting me know! This would definitely cause an issue since those additional paths/bins would deduct also deduct your cash when they don't need to. Definitely shouldn't be building on paths you don't own.
Looking through the available JS interfaces, I don't see an obvious way to know whether a tile is owned by the park or not. That said, there seems to be a .data property inside the tile that I can see if maybe has the information we need.


Create a test for spending locked outputs with the test harness

There is currently a unit test for this, but it is quite bulky. It does the trick for now, but it might be easier to implement this test for the test harness once we include this in our CI.

This issue is no longer relevant, as locked outputs are not stored on the wallet, but on a contract.


Bug: Empty folder results in 404 page

What happened?
I think it would be better if there was a text or something that said this folder was empty, rather than misleading the user to believe that folder doesn't exist while it is actually just empty.
Version
upstream (ghcr.io/diced/zipline:trunk)
What browser(s) are you seeing the problem on?


Adding code of conduct to reference knative/community's CoC

@matzew @lionelvillard could I please get a lgtm for this PR ?

/lgtm


aikup can't install aiken v1.0.29-alpha

What Git revision are you using?
N/A
What operating system are you using, and which version?

[ ] Linux / Ubuntu
[X] Linux / Other
[ ] macOS
[ ] Windows

Describe what the problem is?
$ aikup install v1.0.29-alpha

================================================================================

░█▀▀▄░▀█▀░▒█░▄▀░▒█▀▀▀░▒█▄░▒█             Modern and modular toolkit
▒█▄▄█░▒█░░▒█▀▄░░▒█▀▀▀░▒█▒█▒█       for Cardano Smart Contract development.
▒█░▒█░▄█▄░▒█░▒█░▒█▄▄▄░▒█░░▀█                 Written in Rust.

================================================================================

Repo       : https://github.com/aiken-lang/aiken
Docs       : https://aiken-lang.org/
Chat       : https://discord.gg/Vc3x8N9nz2
Contribute : https://github.com/aiken-lang/aiken/blob/main/CONTRIBUTING.md

================================================================================
aikup: installing aiken (version v1.0.29-alpha, tag v1.0.29-alpha)
aikup: downloading aiken
####################################################################################################### 100.0%
tar: Error opening archive: Unrecognized archive format
aikup: installed - aiken v1.0.28-alpha+c9a1519
aikup: done

In particular, notice that it fails to unpack the archive, but still reports that it was succesful; after this, aiken is still v1.0.28
What should be the expected behavior?
Correctly install v1.0.29; report an error if we failed to install a new version of aiken

highly likely you are using the old bash script by accident

Yes, can confirm i have the bash version installed;
However, it's the version that's installed by aikup as described here:
https://aiken-lang.org/installation-instructions; when I try to upgrade it, I get:
Warning: aiken-lang/tap/aikup 0.0.10 already installed

So perhaps you need to release a new brew formula?

just delete .aiken/bin/aikup


resolve plugins

Hey Glenn, PR looks clean.
I'm however still not convinced we want to split dependencies and plugins in our domain (autobump-core). This means we also need a VersionRepository that is capable of finding updates for Plugins, a PluginBumper, next to the DependencyBumper. I'll think about it some more and we'll have time to discuss this tomorrow morning.

maybe we can consider maken a super class like UpdatebleContent and use this to easily deiferentiate between types of "dependencies" E.g.

Dependencies
Plugins
Parent dependencies

because i can see cases being made for diffirent behaviour depending on the type
but there are for sure other ways to do this besides inheritance


[WIP] Stub out InMemoryCASDatabase.

[ ] Depends on #665

This PR isn't ready, just here to show where I am going with #664 and #665...
I am quite new to std::future, among other things...

The Swift project moved the default branch to main and deleted master branch, so GitHub automatically closed the PR. Please re-create pull request with main branch.
More detail about the branch update - https://forums.swift.org/t/updating-branch-names/40412


Porting to raspberry pi2.

Please consider merging this as it was required to compile servo on raspberry pi.

let me try it out.

As I expected, the compiler will just ignore if a folder doesn't exist.
Quick test:
1500002299-ACAV:temp a.cavalcanti$ gcc -Wall -I/foo/bar foo.c
1500002299-ACAV:temp a.cavalcanti$
Or for the longer version: https://gist.github.com/Adenilson/7cf93b9ec93632f2cb04

I guess it's fine then.


WIP: Minor - wording and redundancy on evoked visualization tutorial

Too much text in comments, two almost-identical images ... This should be better. Please merge for 0.12.

Coverage decreased (-0.007%) to 90.803% when pulling 9be98701fece324277a15ebb42b6800521355a49 on jona-sassenhagen:patch-20 into 87d397fdb7098be195ad93c39fffc15943bce0d6 on mne-tools:master.

Coverage decreased (-0.1%) to 90.707% when pulling 9be98701fece324277a15ebb42b6800521355a49 on jona-sassenhagen:patch-20 into 87d397fdb7098be195ad93c39fffc15943bce0d6 on mne-tools:master.

is this WIP or MRG?

WIP, I want to add another thing I discussed with Eric.

Coverage decreased (-0.01%) to 90.796% when pulling 054a6c36755d83082e1c83a93dca5f38f759f361 on jona-sassenhagen:patch-20 into 87d397fdb7098be195ad93c39fffc15943bce0d6 on mne-tools:master.

@Eric89GXL @jaeilepp done.

Coverage increased (+0.002%) to 90.812% when pulling 3f4b48fbfe5c49a6e19be92f25b82cd1c1185909 on jona-sassenhagen:patch-20 into 87d397fdb7098be195ad93c39fffc15943bce0d6 on mne-tools:master.

Thanks again


Can we infer the id in ReplaceItemAsync?

ReplaceItemAsync requires an explicit id field as an argument.
The id field will always be present on the data object, so this seems redundant and it seems the SDK should be able to infer it.
The SDK does infer the partition key if none is passed in explicitly, so inferring the id would also make the API more consistent.

ReplaceItemAsync supports changing the item's id field. Which is why the id value is required. It could be optional and extracted as you pointed out. The down side to this is the performance hit of extracting the id. I do agree that this would make the API easier to use.
@kirankumarkolli what is your opinion?

I didn't know changing the ID was possible. The docs state
idString https://docs.microsoft.com/en-us/dotnet/api/system.string
The cosmos item id, which is expected to match the value within T.
So if it is possible, the docs need corrected. Either way I'd still vote
for making the id field inferred where possible, unless the perf cost is
greater than I'm imagining. (and if it is then consider stating that
explicitly in the documentation, to avoid users requesting it over and over
again)
On Wed, Nov 27, 2019, 4:36 AM j82w<EMAIL_ADDRESS>wrote:

ReplaceItemAsync supports changing the item's id field. Which is why the
id value is required. It could be optional and extracted as you pointed
out. The down side to this is the performance hit of extracting the id. I
do agree that this would make the API easier to use.
@kirankumarkolli https://github.com/kirankumarkolli what is your
opinion?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Azure/azure-cosmos-dotnet-v3/issues/1055?email_source=notifications&email_token=AAG464NLOIA6KQK6FM37HBLQVZST7A5CNFSM4JR77GGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFJLV7Q#issuecomment-559069950,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAG464KRCDGDCAXTI3GQB2DQVZST7ANCNFSM4JR77GGA
.

The only operation that infers the id is the CreateItemAsync<T> . Read, Delete, and Replace all require the id. The CreateItemAsync<T> does a post operation so the URL to the service does not need the id. The service extracts the id value from the body. For the other operation the id is part of the URL that is used to access the item. The SDK needs the id before it can send the request to the service.

UpsertItemAsync<T> infers the id too.  I imagine that as a PUT with the id in the URI, same as ReplaceItemAsync<T>, but with different header?  Or is that a POST like CreateItemAsync<T>?  Anyway yeah I can see the issue here, with CreateItemAsync<T> there's no need to extract the id before sending the request, whereas UpdateItemAsync<T> needs to know the id value in order to determine the URI.
Still, seems like something users would expect the SDK to handle automatically under the hood.

I agree, the docs should clarify if this method allows changing the ID, which would also help clarify why the ID argument is required.


update registry

What this PR does / why we need it:
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Codecov Report

Merging #638 (86ca79e) into main (14a8c54) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #638   +/-   ##
=======================================
  Coverage   30.44%   30.44%
=======================================
  Files          26       26
  Lines        1560     1560
=======================================
  Hits          475      475
  Misses       1020     1020
  Partials       65       65

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


feat: add DEK setup video

Description
Added video for Issue DEK Setup
Related issues

Fixes #120

Documentation
Added video for Issue DEK Setup

@aaronmgdr please review


struct TIME_FIELDS should be struct _TIME_FIELDS

On: https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/wdm/nf-wdm-rtltimefieldstotime
the TIME_FIELDS struct is documented. However the struct is really called struct _TIME_FIELDS (like all other kernel structures with a leading _ ). not struct TIME_FIELDS.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f8ed35c1-00c4-8cca-7974-fa703436886e
Version Independent ID: d8f8fa38-08b7-9e80-ea27-551b3a26fbba
Content: RtlTimeFieldsToTime function (wdm.h) - Windows drivers
Content Source: wdk-ddi-src/content/wdm/nf-wdm-rtltimefieldstotime.md
Product: windows-hardware
Technology: wdk-api-reference
GitHub Login: @barrygolden
Microsoft Alias: bagold

Best regards, Johannes

Thanks for the report Johannes!  I just pushed 1806ccb352bd9eead6d6ca4d71d4598646e664f8, which splits out that struct into a new page of its own.  I realize that we still refer to it without the underscore -- that's just convention in this particular doc set.
The new rendered page should arrive on docs.microsoft.com within 30 minutes or so -- expected URL will be https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/wdm/ns-wdm-time_fields.
Thanks again for caring about the docs :)


Missing files for converting models to PyTorch

Hello, thank you for this nice work!
I want to convert the Tensorflow weights to PyTorch using convert_model_from_tf.py.
But it requires some additional files, which I cant find in this repo. Could you also provide these files?
load_path: /work/sarandi/rwth-data/experiments/kerasreprod/effv2s_bn16ss_huge8_3e-4_sep_1gpu_simplerand_1600k_finetune_48lchirnozero_regul_duallr_aegt_16000k/ckpt-160000.pt
joint_info_path: /work/sarandi/data/cache/huge8_joint_info.pkl

Hi, the Pytorch files can be directly downloaded. It's mentioned in the Readme.
wget -O - https://bit.ly/metrabs_l_pt | tar -xzvf -
python -m metrabs_pytorch.scripts.demo_image --model-dir metrabs_eff2l_384px_800k_28ds_pytorch --image img/test_image_3dpw.jpg

You can replace l by s or s_256 in the URL. I'll make these things clearer in the docs when I get the time.

@isarandi.
Do you have the pytorch weights of this model metrabs_eff2m_y4?
I have tried metrabs_m_pt, metrabs_m_256_pt but can't download.

@isarandi .
I think these cache files (skeleton_infos.pkl,  joint_transform_matrix.npy, joint_info.npz) are also needed to run the pytorch demo scripts.
Where can I find these files?
Also when I run the script, I got this error message from posepile
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/posepile/paths.py", line 5, in <module>
    DATA_ROOT = os.environ['DATA_ROOT']
  File "/usr/lib/python3.8/os.py", line 675, in __getitem__
    raise KeyError(key) from None
KeyError: 'DATA_ROOT'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.8/dist-packages/posepile/util/__init__.py", line 2, in <module>
    from posepile.util.misc import *
  File "/usr/local/lib/python3.8/dist-packages/posepile/util/misc.py", line 6, in <module>
    from posepile.paths import DATA_ROOT
  File "/usr/local/lib/python3.8/dist-packages/posepile/paths.py", line 7, in <module>
    raise KeyError(
KeyError: 'The DATA_ROOT environment variable is not set. Set it to the parent dir of the dataset directories.'

How can I resolve this issue? Do I need to download the whole dataset for inference?

Probably you just need to set that environment variable. Most of the code expects DATA_ROOT to exist, even if empty.
All necessary files are packaged into the downloadable archive.


add "translate page" to contextual button when right click

sometimes I consult Russian streaming wensites to watch video but the interface is in Russian, I have disabled translation option in Ungoogled-Chromium, please can Ungoogled-Chromium add this important button to the context menu so that we can quickly translate the pages into Russian please?
there is libretranslate , a translator which I suggest to use to replace googel translator:
https://github.com/LibreTranslate/LibreTranslate

@trimechee care to share?

javascript:var t=((window.getSelection&&window.getSelection())||(document.getSelection&&document.getSelection())||(document.selection&&document.selection.createRange&&document.selection.createRange().text));var e=(document.charset||document.characterSet);if(t!=''){location.href='http://translate.google.com/?text='+t+'&hl=auto&langpair=auto|auto&tbb=1&ie='+e;}else{location.href=%27http://translate.google.com/translate?u=%27+encodeURIComponent(location.href)+%27&hl=fr&langpair=auto|auto&tbb=1&ie=%27+e;};


RuntimeHandler "spin" not supported error

Running through the README and getting the following error from the deployed pod:
Failed to create pod sandbox: rpc error: code = Unknown desc = RuntimeHandler "spin" not supported

Any tips to get around this would be appreciated.

I think the issue was that I was on minikube and the default container runtime was docker and not containerd.
minikube start --container-runtime=containerd

Starting minikube with the containerd runtime specifically helped me get past this issue.


Timesheet resource editing and listing

@all-contributors please add @mihaisolomon  for code

@all-contributors please add @mihaisolomon  for code


Improve formatting of example snippet

Currently this snippet is hardly readable in the documentation:

With this commit is should become better:

thank you @jmewes !

Should we not consider a code style machine cleanup for the entire project?

@paulbors Any improvements are very welcome!

I would not change tab with 2 spaces for whole project
Even this markup can have tab and will be readable if CSS will be in separate file
my 2c

Hi @paulbors ,
I am not sure this is a good idea. There is no big of a problem with the current formatting. Such big re-formattings usually lead to problems later with merging/cherry-picking commits from one branch to the other.

I tend to agree as this proj is widely used and a bug can easily creep in even with the extensive test coverage. If it wasn't as popular it would have made more sense. The kind of good problems to have :)
However, the question still remains: should the comitee vote on adopting a single uniform code style and enforce it going forward? Over time the code base can be refactored to catch up.


Analyzer incorrectly says that an exported import is unused.

When running dartanalyzer c.dart on the follow code I get the error
Analyzing [c.dart]...
[hint] Unused import (/Users/ianloic/tmp/dart-analyzer-bug/b.dart, line 1, col 8)
1 hint found.

even though the import is clearly used. I was able to work around this by moving a declaration into the wrong file and / or adding extra imports that break the API I'm going for. It would be good for the analyzer to understand what's going on here.
a.dart:
int foo = 42;

b.dart:
import "a.dart";
export "a.dart";

c.dart:
import "b.dart";
void main() {
  print("the answer is $foo");
}

I'm not sure I understand what's going on here :-)
Is that the complete content of b.dart? If so, it looks to me like the import is not necessary. (You don't have to import a library in order to export it.)

Oh. I assumed you had to import to export. Never mind me...


Resolve problem [ location ] not in css folder ,, and watch file didn't delete files and not added to [ mix-manifest ] file

We have to add this to css folder and mix-manifest file as we added all files and watch it for any update for delete old files.

This is fixed in the next release.


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-30-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4772

Questions ?
Please refer to the Backport tool documentation