Code Refactoring

Make sure to move class to another file

Change everything from "Price" to "Normalized Price"


[Nick.com] "Missing CDN configurations" error for all videos

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I remove or skip any mandatory* field

Checklist

[X] I'm reporting a broken site
[X] I've verified that I'm running yt-dlp version 2023.01.06 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and I'm willing to share it if required

Region
United States
Provide a description that is worded well enough to be understood
Nick.com's videos give me an error when I try to download them, whether they're locked or not. This worked for me last week, so it's a recent issue. Here is the episode I am trying to download: https://www.nick.com/episodes/3m23cb/spongebob-squarepants-the-salty-sponge-karen-for-spot-season-13-ep-14. The specific error I get is "media urls could not be created due to missing CDN configurations for the account", but I am not passing in any account details, and I have never needed them before,
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
C:\[...]>yt-dlp -vU https://www.nick.com/episodes/3m23cb/spongebob-squarepants-the-salty-sponge-karen-for-spot-season-13-ep-14
[debug] Command-line config: ['-vU', 'https://www.nick.com/episodes/3m23cb/spongebob-squarepants-the-salty-sponge-karen-for-spot-season-13-ep-14']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2023.01.06 [6becd25] (win_exe)
[debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.19045-SP0 (OpenSSL 1.1.1k  25 Mar 2021)
[debug] exe versions: ffmpeg 2022-05-12-git-30e2bb0f64-full_build-www.gyan.dev (setts), ffprobe 2022-05-12-git-30e2bb0f64-full_build-www.gyan.dev
[debug] Optional libraries: Cryptodome-3.16.0, brotli-1.0.9, certifi-2022.12.07, mutagen-1.46.0, sqlite3-2.6.0, websockets-10.4
[debug] Proxy map: {}
[debug] Loaded 1760 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version: 2023.01.06, Current version: 2023.01.06
yt-dlp is up to date (2023.01.06)
[debug] Using fake IP <IP_ADDRESS> (US) as X-Forwarded-For
[nick.com] Extracting URL: https://www.nick.com/episodes/3m23cb/spongebob-squarepants-the-salty-sponge-karen-for-spot-season-13-ep-14
[nick.com] spongebob-squarepants-the-salty-sponge-karen-for-spot-season-13-ep-14: Downloading webpage
[nick.com] e1ad3187-c4db-11ec-9b1b-0e40cf2fc285: Downloading info
[nick.com] a542088f-a0ca-11ed-ad8e-0e40cf2fc285: Extracting information
[nick.com] a542088f-a0ca-11ed-ad8e-0e40cf2fc285: Downloading video urls
ERROR: [nick.com] spongebob-squarepants-the-salty-sponge-karen-for-spot-season-13-ep-14: nick.com returned error: missing_cdn_config -
      Error - Media urls could not be created due to missing CDN configurations for the account.

  File "yt_dlp\extractor\common.py", line 680, in extract
  File "yt_dlp\extractor\nick.py", line 78, in _real_extract
  File "yt_dlp\extractor\mtv.py", line 323, in _real_extract
  File "yt_dlp\extractor\mtv.py", line 227, in _get_videos_info
  File "yt_dlp\extractor\mtv.py", line 239, in _get_videos_info_from_url
  File "yt_dlp\extractor\mtv.py", line 150, in _get_video_info

MTVServicesInfoExtractor and most (if not all) of its subclassed extractors are in need of an overhaul
Related: #4928
also: #1712, #169, #3167, #5249, #4552

I've also started having problems with the South Park website, This is important, so is there anything else I can use in the meantime?

I'm having this same problem too! Please, fix this so I can download episodes from Nick.com that I may have missed due to technical problems or something else again. I need to download tonight's Lay Lay episode.

note: nick.com is now using adobepass, an MSO account with Nickelodeon included in its plan is needed

It's always had that. The thing is, you're not able to download any videos now, even the free ones.

It's always had that. The thing is, you're not able to download any videos now, even the free ones.

Thank you! Glad I'm not the only one that knew this.

To chime in, I am also getting this error. I DO pass MSO info/account/password. I have also tried passing a cookie file after logging in (successfully) to Nick.com via the Adobe Pass. This arrangement previously worked, and now I get "Missing CDN configurations".

While logged in to nick.com during video playback, running web inpect in Edge browser shows a cdn address for a javascript.
Address is:
<script id="parsely-cfg" src="//cdn.parsely.com/keys/nick.com/p.js"></script>
Unsure if this is relevant to the issue or not.

To add to the above,
MSO account is Charter Spectrum.
Using --ap-mso Charter_Direct had worked previously, and I have also tried using --ap-mso Spectrum without success.
It appears that how it is detecting credentials via adobe pass no longer works.
This issue is being observed across multiple sites, including disneynow.com, although that one is a different error.
For reference, verbose log below.
nick.com:
[debug] Command-line config: ['-vU', 'https://www.nick.com/episodes/b0cvp1/monster-high-what-s-up-watzie-so-familiar-season-1-ep-9', '--ap-mso', 'Charter_Direct', '--ap-username', 'PRIVATE', '--ap-password', 'PRIVATE']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>[392389b7d] (win32_dir)
[debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.19045-SP0 (OpenSSL 1.1.1k  25 Mar 2021)
[debug] exe versions: ffmpeg N-108785-g65f96a965a-20221023 (setts), ffprobe N-108785-g65f96a965a-20221023
[debug] Optional libraries: Cryptodome-3.17, brotli-1.0.9, certifi-2022.12.07, mutagen-1.46.0, sqlite3-2.6.0, websockets-10.4
[debug] Proxy map: {}
[debug] Loaded 1786 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Available version<EMAIL_ADDRESS>Current version<EMAIL_ADDRESS>yt-dlp is up to date<EMAIL_ADDRESS>[debug] Using fake IP <IP_ADDRESS> (US) as X-Forwarded-For
[nick.com] Extracting URL: https://www.nick.com/episodes/b0cvp1/monster-high-what-s-up-watzie-so-familiar-season-1-ep-9
[nick.com] monster-high-what-s-up-watzie-so-familiar-season-1-ep-9: Downloading webpage
[nick.com] 3b9799c7-54a0-11ed-ad8e-0e40cf2fc285: Downloading info
[nick.com] 201cdb3d-bd57-11ed-ad8e-0e40cf2fc285: Extracting information
[nick.com] 201cdb3d-bd57-11ed-ad8e-0e40cf2fc285: Downloading video urls
ERROR: [nick.com] monster-high-what-s-up-watzie-so-familiar-season-1-ep-9: nick.com returned error: missing_cdn_config -
Error - Media urls could not be created due to missing CDN configurations for the account.
File "yt_dlp\extractor\common.py", line 694, in extract
File "yt_dlp\extractor\nick.py", line 78, in _real_extract
File "yt_dlp\extractor\mtv.py", line 323, in _real_extract
File "yt_dlp\extractor\mtv.py", line 227, in _get_videos_info
File "yt_dlp\extractor\mtv.py", line 239, in _get_videos_info_from_url
File "yt_dlp\extractor\mtv.py", line 150, in _get_video_info
disneynow.com:
[debug] Command-line config: ['-vU', 'https://disneynow.com/shows/big-city-greens/season-03/episode-17-pen-pals-study-abroad/vdka32568984', '--ap-mso', 'Charter_Direct', '--ap-username', 'PRIVATE', '--ap-password', 'PRIVATE']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>[392389b7d] (win32_dir)
[debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.19045-SP0 (OpenSSL 1.1.1k  25 Mar 2021)
[debug] exe versions: ffmpeg N-108785-g65f96a965a-20221023 (setts), ffprobe N-108785-g65f96a965a-20221023
[debug] Optional libraries: Cryptodome-3.17, brotli-1.0.9, certifi-2022.12.07, mutagen-1.46.0, sqlite3-2.6.0, websockets-10.4
[debug] Proxy map: {}
[debug] Loaded 1786 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Available version<EMAIL_ADDRESS>Current version<EMAIL_ADDRESS>yt-dlp is up to date<EMAIL_ADDRESS>[Go] Extracting URL: https://disneynow.com/shows/big-city-greens/season-03/episode-17-pen-pals-study-abroad/vdka32568984
[Go] vdka32568984: Downloading JSON metadata
[Go] VDKA32568984: Downloading Provider Redirect Page
ERROR: [Go] vdka32568984: Unable to extract post url; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
File "yt_dlp\extractor\common.py", line 694, in extract
File "yt_dlp\extractor\go.py", line 250, in _real_extract
File "yt_dlp\extractor\adobepass.py", line 1707, in _extract_mvpd_auth
File "yt_dlp\extractor\adobepass.py", line 1395, in post_form
File "yt_dlp\extractor\common.py", line 1278, in _html_search_regex
File "yt_dlp\extractor\common.py", line 1242, in _search_regex

An added note:
The Firefox extension Stream Detector is able to find and download the above streams just fine.
yt-dlp generated link:
yt-dlp --no-part --restrict-filenames -N 4 --user-agent "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/111.0" --referer "https://www.nick.com/" "https://topaz.dai.viacomcbs.digital/h/a/dG9wYXoxYDNiOTc5OWM3LTU0YTAtMTFlZC1hZDhlLTBlNDBjZjJmYzI4NWA2Yzk2YmI3Yjk3ZGMwZjNmYTVmODQ4YWVjZDdmZjA3ZWE5Zjk1NTIxYEw4MXlGSHVUMFhHU21lbVV4cU9mb0FsUHFBZTIzeUI5d3Rib0VZOTdRT0U/master.m3u8?hdnea=st=1678864071~exp=1678867671~acl=/h/a/dG9wYXoxYDNiOTc5OWM3LTU0YTAtMTFlZC1hZDhlLTBlNDBjZjJmYzI4NWA2Yzk2YmI3Yjk3ZGMwZjNmYTVmODQ4YWVjZDdmZjA3ZWE5Zjk1NTIxYEw4MXlGSHVUMFhHU21lbVV4cU9mb0FsUHFBZTIzeUI5d3Rib0VZOTdRT0U/*~id=141e5344-3636-452a-a133-e0e314e69957~hmac=d640c85bfd150fed41ad55ffe7ce67f9fddd84ec3d39890dfbebece1b68d504f&originpath=/ondemand/hls/content/2627899/vid/mgid:arc:episode:shared.nick.us:3b9799c7-54a0-11ed-ad8e-0e40cf2fc285/CHS/streams/d1fc3e25-9194-4724-8b7c-b9db44d271ef/master.m3u8&CMCD=mtp%3D500%2Cot%3Dm%2Csf%3Dh%2Csid%3D%22c6b58277-07ae-422e-98b6-d1c6482cb5bd%22%2Csu"

as does N_m3u8DL. it's absolutely not an MSO issue

All of the formerly-Viacom sites (with extractors that are subclassed from MTVServicesInfoExtractor base class) are using AdobePass in a way that is incompatible with our AdobePass extractor, so it kind of is an MSO issue. And someone would need to share their MSO account credentials in order for a dev to be able to work on this.

To add to the above,
MSO account is Charter Spectrum.
Using --ap-mso Charter_Direct had worked previously, and I have also tried using --ap-mso Spectrum without success.
It appears that how it is detecting credentials via adobe pass no longer works. This issue is being observed across multiple sites, including disneynow.com, although that one is a different error.
For reference, verbose log below.
nick.com:
[debug] Command-line config: ['-vU', 'https://www.nick.com/episodes/b0cvp1/monster-high-what-s-up-watzie-so-familiar-season-1-ep-9', '--ap-mso', 'Charter_Direct', '--ap-username', 'PRIVATE', '--ap-password', 'PRIVATE'] [debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8 [debug] yt-dlp version<EMAIL_ADDRESS>[392389b] (win32_dir) [debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.19045-SP0 (OpenSSL 1.1.1k 25 Mar 2021) [debug] exe versions: ffmpeg N-108785-g65f96a965a-20221023 (setts), ffprobe N-108785-g65f96a965a-20221023 [debug] Optional libraries: Cryptodome-3.17, brotli-1.0.9, certifi-2022.12.07, mutagen-1.46.0, sqlite3-2.6.0, websockets-10.4 [debug] Proxy map: {} [debug] Loaded 1786 extractors [debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest Available version<EMAIL_ADDRESS>Current version<EMAIL_ADDRESS>yt-dlp is up to date<EMAIL_ADDRESS>[debug] Using fake IP <IP_ADDRESS> (US) as X-Forwarded-For [nick.com] Extracting URL: https://www.nick.com/episodes/b0cvp1/monster-high-what-s-up-watzie-so-familiar-season-1-ep-9 [nick.com] monster-high-what-s-up-watzie-so-familiar-season-1-ep-9: Downloading webpage [nick.com] 3b9799c7-54a0-11ed-ad8e-0e40cf2fc285: Downloading info [nick.com] 201cdb3d-bd57-11ed-ad8e-0e40cf2fc285: Extracting information [nick.com] 201cdb3d-bd57-11ed-ad8e-0e40cf2fc285: Downloading video urls ERROR: [nick.com] monster-high-what-s-up-watzie-so-familiar-season-1-ep-9: nick.com returned error: missing_cdn_config - Error - Media urls could not be created due to missing CDN configurations for the account.
File "yt_dlp\extractor\common.py", line 694, in extract File "yt_dlp\extractor\nick.py", line 78, in _real_extract File "yt_dlp\extractor\mtv.py", line 323, in _real_extract File "yt_dlp\extractor\mtv.py", line 227, in _get_videos_info File "yt_dlp\extractor\mtv.py", line 239, in _get_videos_info_from_url File "yt_dlp\extractor\mtv.py", line 150, in _get_video_info
disneynow.com:
[debug] Command-line config: ['-vU', 'https://disneynow.com/shows/big-city-greens/season-03/episode-17-pen-pals-study-abroad/vdka32568984', '--ap-mso', 'Charter_Direct', '--ap-username', 'PRIVATE', '--ap-password', 'PRIVATE'] [debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8 [debug] yt-dlp version<EMAIL_ADDRESS>[392389b] (win32_dir) [debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.19045-SP0 (OpenSSL 1.1.1k 25 Mar 2021) [debug] exe versions: ffmpeg N-108785-g65f96a965a-20221023 (setts), ffprobe N-108785-g65f96a965a-20221023 [debug] Optional libraries: Cryptodome-3.17, brotli-1.0.9, certifi-2022.12.07, mutagen-1.46.0, sqlite3-2.6.0, websockets-10.4 [debug] Proxy map: {} [debug] Loaded 1786 extractors [debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest Available version<EMAIL_ADDRESS>Current version<EMAIL_ADDRESS>yt-dlp is up to date<EMAIL_ADDRESS>[Go] Extracting URL: https://disneynow.com/shows/big-city-greens/season-03/episode-17-pen-pals-study-abroad/vdka32568984 [Go] vdka32568984: Downloading JSON metadata [Go] VDKA32568984: Downloading Provider Redirect Page ERROR: [Go] vdka32568984: Unable to extract post url; please report this issue on https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using yt-dlp -U File "yt_dlp\extractor\common.py", line 694, in extract File "yt_dlp\extractor\go.py", line 250, in _real_extract File "yt_dlp\extractor\adobepass.py", line 1707, in _extract_mvpd_auth File "yt_dlp\extractor\adobepass.py", line 1395, in post_form File "yt_dlp\extractor\common.py", line 1278, in _html_search_regex File "yt_dlp\extractor\common.py", line 1242, in _search_regex

I have zero issue with disney using same link:
C:\>yt-dlp -v https://disneynow.com/shows/big-city-greens/season-03/episode-17-pen-pals-study-abroad/vdka32568984 [debug] Command-line config: ['-v', 'https://disneynow.com/shows/big-city-greens/season-03/episode-17-pen-pals-study-abroad/vdka32568984'] [debug] Portable config "C:\yt-dlp.conf": [ '--ap-mso', 'RCN', '--ap-username', 'PRIVATE', '--ap-password', 'PRIVATE', '--external-downloader', 'aria2c'] [debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8 [debug] yt-dlp version 2023.03.03 [934496428] (win_exe) [debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.19045-SP0 (OpenSSL 1.1.1k  25 Mar 2021) [debug] exe versions: ffmpeg 6.0-essentials_build-www.gyan.dev (setts), ffprobe 6.0-essentials_build-www.gyan.dev [debug] Optional libraries: Cryptodome-3.17, brotli-1.0.9, certifi-2022.12.07, mutagen-1.46.0, sqlite3-2.6.0, websockets-10.4 [debug] Proxy map: {} [debug] Loaded 1782 extractors [Go] Extracting URL: https://disneynow.com/shows/big-city-greens/season-03/episode-17-pen-pals-study-abroad/vdka32568984 [Go] vdka32568984: Downloading JSON metadata [debug] Loading ap-mvpd.DisneyChannels from cache [Go] VDKA32568984: Retrieving Media Token [Go] VDKA32568984: Downloading JSON metadata [Go] VDKA32568984: Downloading m3u8 information [debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id [debug] Default format spec: bestvideo*+bestaudio/best [info] VDKA32568984: Downloading 1 format(s): ULNK-6108

Must be an issue with MSO Charter_Direct.
Disneynow videos that require login are not working, but free ones are.
https://disneynow.com/shows/big-city-greens/season-03/episode-16-virtually-christmas/vdka31091990 works just fine.
All work just fine in a browser.

Just to give some additional details using my use case if it helps.
My MSO is Comcast/Xfinity.
Nick.com has the issue raised by OP that I bumped. I tried Monster High (the same url as ichee) as well as Spongebob. I can watch in browser but I can't download when passing either MSO or cookies.
NickJR.com videos requiring login are working with only passing through MSO credentials.
DisneyNOW videos requiring login continue to give me a 401 not found error or an unable to extract post url error when passing MSO credentials (it has done this for years at this point, as long as I can recall). When I pass a cookie file, it works normally.

Just wanted to check in to see if there are any updates on this or if there is any additional information one of us can provide to try to troubleshoot. Any help is appreciated.

Just wanted to follow up to see if there has been any progress on this issue or if additional information is needed.

Another month has passed. Any update? Any info we can provide to help?

Just to give some additional details using my use case if it helps. My MSO is Comcast/Xfinity.
Nick.com has the issue raised by OP that I bumped. I tried Monster High (the same url as ichee) as well as Spongebob. I can watch in browser but I can't download when passing either MSO or cookies.
NickJR.com videos requiring login are working with only passing through MSO credentials.
DisneyNOW videos requiring login continue to give me a 401 not found error or an unable to extract post url error when passing MSO credentials (it has done this for years at this point, as long as I can recall). When I pass a cookie file, it works normally.

Is disneynow still working for you? I have been unable to get “new” content from there recently.  I can watch them on the website but have tried cookies and also MSO and neither work giving me the POSTURL error.  Any chance you can post your command if it is still working for you.  Thanks!


docs: add Wikipedia links to Scale and Mode

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
431

Relevant Lines:
431

💛  - Coveralls


Question about tracking spectra from MGF files in output

Hello,
I have seen in other topics that it is not trivial to extract and keep track of scannumbers from MGF files since there is no unified standard. My output shows a positional index in the "spectra_ref" column. So the entries are something like "ms_run[1]:index=0" etc.
Is it right that this is the positional index for the input MGF file and thus can be used to annotate the spectra with the predicted sequences?
Thanks for your time and help

Yes, this refers to the positional index in the MGF file and you can use to map Casanovo outputs to input spectra.


redefined Method from hyper in reqwest

Addresses #128
@seanmonstar I'm not sure how to proceed with these errors -
error[E0308]: mismatched types
   --> src/client.rs:501:50
    |
501 |                 let mut req = self.hyper.request(method.clone(), url.clone())
    |                                                  ^^^^^^^^^^^^^^ expected enum `hyper::method::Method`, found enum `method::Method`
    |
    = note: expected type `hyper::method::Method`
               found type `method::Method`

Thanks :)

Oh shoot, I should have point out in the issue, there's no reason to really do this until we can use associated constants...

Would it be an acceptable workaround for the time being to have some internal conversion into an unstable ::hyper::method::Method?

Yea, whenever this does happen, an internal function converting from a reqwest::Method to a hyper::Method would be needed. My comment before was that we don't want an enum Method in reqwest.
We'd want a design like this:
pub struct Method {
    // internals TBD
}

impl Method {
    pub const GET: Method = /* GET internals */;
    pub const POST: Method = /* POST internals */;
    // etc
}

Oops. Apologies for jumping the gun here.
I'm rather new to Rust. Could you point out some other implementations of the design you're describing so I could learn and do the implementation for Method?
--
Regards
Steve Robinson

On 12-Jun-2017, at 9:07 AM, Sean McArthur<EMAIL_ADDRESS>wrote:
Yea, whenever this does happen, an internal function converting from a reqwest::Method to a hyper::Method would be needed. My comment before was that we don't want an enum Method in reqwest.
We'd want a design like this:
pub struct Method {
// internals TBD
}
impl Method {
pub const GET: Method = /* GET internals /;
pub const POST: Method = / POST internals */;
// etc
}
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

It could still have an enum internally, just not exposed publicly. A possible implementation:
pub struct Method {
    inner: Inner,
}

enum Inner {
    Get,
    Post,
    // ....
    Unregistered(String),
}

impl Method {
    pub const GET: Method = Method { inner: Inner::Get, };
    // etc...
}

impl FromStr for Method {}
impl AsRef<str> for Method {}
impl fmt::Display for Method {}

If a new method were to be registered in the future, some YOLO, then there's no concern adding a Yolo variant to the private enum, and a new pub const YOLO: Method = ....

I'm going to suggest we close this, and try again when Rust 1.20 comes out, and we can make use of associated constants. Sorry for the miscommunication!

@seanmonstar  no probs :) Sorry for jumping the gun.


[tree-sitter] Add new port

Describe the pull request

Tree-sitter is a parser generator tool and an incremental parsing library. It can build a concrete syntax tree for a source file and efficiently update the syntax tree as the source file is edited.

https://github.com/tree-sitter/tree-sitter

What does your PR fix?

New port

Which triplets are supported/not supported? Have you updated the CI baseline?

All

Does your PR follow the maintainer guide?

Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/
Maybe wait until this PR is addressed by the maintainers? - https://github.com/tree-sitter/tree-sitter/pull/1749

Duplicate of pr #24768


typoTolerance.disableOnAttributes does not seem to be working when attributesToSearchOn is used.

Describe the bug
The typoTolerance.disableOnAttributes seems to be ignored when the attributesToSearchOn search parameter is used.
To Reproduce
I've not done a separate test other than my current project as described in the Additional context section, but these steps should work?
Steps to reproduce the behavior:

create an index with several fields and disable typo tolerance on one of them, lets call it exact_only
fill the index with data, the exact_only field should have similar but not exact values.
do a search for a term found in the exact_only field and set attributesToSearchOn=exact_only
see more than 1 result.
the same search without attributesToSearchOn will only return 1 result as expected.

Expected behavior
The search with attributesToSearchOn=exact_only should only return 1 result - matching the exact search term, or those with the same term plus extra characters.
For example:
q=test should return results for test and tested, but not tesd
Meilisearch version:
1.5.0
Additional context
I've got an index of products that has some fields for the gtin number and supplier / manufacture product code's, which I have added to the disableOnAttributes array - but doing a search for a sku still returns other skus that are close to the search but not exact.
/indexes/products/settings/typo-tolerance
{
  "enabled": true,
  "minWordSizeForTypos": {
    "oneTypo": 5,
    "twoTypos": 9
  },
  "disableOnWords": [],
  "disableOnAttributes": [
    "code",
    "gtin",
    "product",
    "supplier"
  ]
}

Simple search returns expected results:
/indexes/local_products/search?q=BCK88C
{
  "hits": [
    {
      "title": "Brother LC431C Cyan Ink Cartridge",
      "code": "LC431C",
      "gtin": "4977766810616",
      "product": "DV15817",
      "supplier": "BCK88C",
      "id": 95884,
    }
  ],
  "query": "BCK88C",
  "processingTimeMs": 1,
  "limit": 20,
  "offset": 0,
  "estimatedTotalHits": 1
}

But with attributesToSearchOn, 14 results are returned - only 1 matches the supplier field.
/indexes/local_products/search?attributesToSearchOn=code,supplier,product&q=BCK88C
{
  "hits": [
    {
      "title": "Brother LC431C Cyan Ink Cartridge",
      "code": "LC431C",
      "gtin": "4977766810616",
      "product": "DV15817",
      "supplier": "BCK88C",
      "id": 95884
    },
    {
      "title": "Brother LC39C Cyan Ink Cartridge",
      "code": "LC39C",
      "gtin": "4977766676731",
      "product": "dv3622",
      "supplier": "BCK18C",
      "id": 13384
    },
    {
      "title": "Brother LC23EC Cyan Super High Yield Ink Cartridge",
      "code": "LC23EC",
      "gtin": "4977766754958",
      "product": "DV09882",
      "supplier": "BCK82C",
      "id": 52932
    },
    ...
  ],
  "query": "BCK88C",
  "processingTimeMs": 2,
  "limit": 20,
  "offset": 0,
  "estimatedTotalHits": 14
}

Hello @tobz-nz :wave:
thanks for the detailed report! This allowed @ManyTheFish to reproduce the issue.
We'll try to release a v1.5.1 with a fix when available.

Fixed by #4233


Add a contribution guide

We should have a contribution guide, to where we point the contributions that do not follow the same style adopted by the project.
That guide could have (example here...):

You need to add tests for the features that you write
Every block should be enclosed by curly bracers even if they're just one line
You should use tabs instead of spaces
Coding style is ****
Etc...

Just an idea...

Great idea! :)


Camera Snapshot url

Can you add a snapshot url (jpg)? I would like to use the app as a security camera in ioBroker.

Not sure what you are asking for?  You want to get an image url of the camera?

Sorry, yes I would like a url where an image is generated when called. So for example /snapshot.jpg then shows exactly the image from the camera when the url was called. Something like that would be great :)

Not sure you can get a public url to the image on the camera, is that what you are suggesting?  We can post that image some place, I do this in the Alarm Panel application.  Alternatively, if you are streaming using MJPEG to Home Assistant, you could do something there to capture an image, no?

I support it, I really need this function.

The only way to get this feature is for someone to build it and do a pull request.  I appreciate that people like this feature and their feedback, but we have so many feature reqeust.


Install failure- Docker issue

I have been running into a issue when executing the playbook for setup.  I get the following:
TASK [geerlingguy.docker : Ensure Docker is started and enabled at boot.] *************************************
fatal: [localhost]: FAILED! => {"changed": false, "msg": "Unable to start service docker: Job for docker.service failed because the control process exited with error code.\nSee "systemctl status docker.service" and "journalctl -xe" for details.\n"}
PLAY RECAP ****************************************************************************************************
localhost                  : ok=24   changed=0    unreachable=0    failed=1    skipped=16   rescued=0    ignored=0
running the following: systemctl status docker.service
● docker.service - Docker Application Container Engine
Loaded: loaded (/lib/systemd/system/docker.service; enabled; vendor preset: enabled)
Active: failed (Result: exit-code) since Sat 2019-11-30 05:16:54 UTC; 6s ago
Docs: https://docs.docker.com
Process: 5163 ExecStart=/usr/bin/dockerd -H fd:// --containerd=/run/containerd/containerd.sock (code=exited,
Main PID: 5163 (code=exited, status=1/FAILURE)
Nov 30 05:16:54 XXX-nas systemd[1]: docker.service: Service hold-off time over, scheduling restart.
Nov 30 05:16:54 XXX-nas systemd[1]: docker.service: Scheduled restart job, restart counter is at 3.
Nov 30 05:16:54 XXX-nas systemd[1]: Stopped Docker Application Container Engine.
Nov 30 05:16:54 XXX-nas systemd[1]: docker.service: Start request repeated too quickly.
Nov 30 05:16:54 XXX-nas systemd[1]: docker.service: Failed with result 'exit-code'.
Nov 30 05:16:54 XXX-nas systemd[1]: Failed to start Docker Application Container Engine.
Suggestions?

Please fill out the template in the bug report, there's a lot of info I need to know to be able to help you. This will also help the next person that runs into this.
It sounds like a Docker config issue. I'm guessing there's some permutation of storage driver and paths that doesn't work that we're not catching.

Sorry about the lack of info before.  Running  on the Ansible-NAS box itself. Latest LTS Ubuntu, with all updates. Storage drive is formatted btrfs
Docker version 19.03.5, build 633a0ea838
XXX-nas systemd[1]: Failed to start Docker Application Container Engine.
Dec 01 05:22:36 XXX-nas systemd[1]: docker.service: Service hold-off time over, scheduling restart.
Dec 01 05:22:36 XXX-nas systemd[1]: docker.service: Scheduled restart job, restart counter is at 2.
Dec 01 05:22:36 XXX-nas systemd[1]: Stopped Docker Application Container Engine.
Dec 01 05:22:36 XXX-nas systemd[1]: Starting Docker Application Container Engine...
Dec 01 05:22:36 XXX-nas dockerd[19486]: time="2019-12-01T05:22:36.322207303Z" level=info msg="Starting up"
Dec 01 05:22:36 XXX-nas dockerd[19486]: time="2019-12-01T05:22:36.322797618Z" level=info msg="detected <IP_ADDRESS> nameserver, assuming systemd-resolved, so using resolv.c
Dec 01 05:22:36 XXX-nas dockerd[19486]: time="2019-12-01T05:22:36.324355156Z" level=info msg="parsed scheme: "unix"" module=grpc
Dec 01 05:22:36 XXX-nas dockerd[19486]: time="2019-12-01T05:22:36.324428263Z" level=info msg="scheme "unix" not registered, fallback to default scheme" module=grpc
Dec 01 05:22:36 XXX-nas dockerd[19486]: time="2019-12-01T05:22:36.324479118Z" level=info msg="ccResolverWrapper: sending update to cc: {[{unix:///run/containerd/container
Dec 01 05:22:36 XXX-nas dockerd[19486]: time="2019-12-01T05:22:36.324507421Z" level=info msg="ClientConn switching balancer to "pick_first"" module=grpc
Dec 01 05:22:36 XXX-nas dockerd[19486]: time="2019-12-01T05:22:36.327571442Z" level=info msg="parsed scheme: "unix"" module=grpc
Dec 01 05:22:36 XXX-nas dockerd[19486]: time="2019-12-01T05:22:36.327623309Z" level=info msg="scheme "unix" not registered, fallback to default scheme" module=grpc
Dec 01 05:22:36 XXX-nas dockerd[19486]: time="2019-12-01T05:22:36.327658224Z" level=info msg="ccResolverWrapper: sending update to cc: {[{unix:///run/containerd/container
Dec 01 05:22:36 XXX-nas dockerd[19486]: time="2019-12-01T05:22:36.327689022Z" level=info msg="ClientConn switching balancer to "pick_first"" module=grpc
Dec 01 05:22:36 XXX-nas dockerd[19486]: failed to start daemon: error initializing graphdriver: prerequisites for driver not satisfied (wrong filesystem?)
Dec 01 05:22:36 XXX-nas systemd[1]: docker.service: Main process exited, code=exited, status=1/FAILURE
Dec 01 05:22:36 XXX-nas systemd[1]: docker.service: Failed with result 'exit-code'.
Dec 01 05:22:36 XXX-nas systemd[1]: Failed to start Docker Application Container Engine.
Dec 01 05:22:38 XXX-nas systemd[1]: docker.service: Service hold-off time over, scheduling restart.
Dec 01 05:22:38 XXX-nas systemd[1]: docker.service: Scheduled restart job, restart counter is at 3.
Dec 01 05:22:38 XXX-nas systemd[1]: Stopped Docker Application Container Engine.
Dec 01 05:22:38 XXX-nas systemd[1]: docker.service: Start request repeated too quickly.
Dec 01 05:22:38 XXX-nas systemd[1]: docker.service: Failed with result 'exit-code'.
Dec 01 05:22:38 XXX-nas systemd[1]: Failed to start Docker Application Container Engine.
Filesystem      Size  Used Avail Use% Mounted on
udev            6.8G     0  6.8G   0% /dev
tmpfs           1.4G  3.1M  1.4G   1% /run
/dev/nvme0n1p2  234G  9.0G  213G   5% /
tmpfs           6.9G   51M  6.8G   1% /dev/shm
tmpfs           5.0M  4.0K  5.0M   1% /run/lock
tmpfs           6.9G     0  6.9G   0% /sys/fs/cgroup
/dev/nvme0n1p3  502M  6.1M  496M   2% /boot/efi
tmpfs           1.4G   48K  1.4G   1% /run/user/1000
/dev/sda2       977G   17M  975G   1% /media/XXX/173b403b-c928-4142-86f4-081062f87f94
all.yml vars:
docker_image_directory: "{{ docker_home }}/data"
docker_home: /mnt/Volume2/docker
docker_storage_driver: overlay2
samba_shares_root: /mnt/Volume3

Is all of your storage btrfs?
Each Docker storage driver has different compatibility with different filesystems. The output of df -hT and mount would help to know for sure, but I'm guessing that's your issue based on the log:
Dec 01 05:22:36 XXX-nas dockerd[19486]: failed to start daemon: error initializing graphdriver: prerequisites for driver not satisfied (wrong filesystem?)

Read the doc linked above and select the storage driver relevant to the underlying filesystem and you should be good to go. I'm guessing for you that's btrfs.
Out of interest, why btrfs over ZFS? You will likely find ZFS better performing and using less space overall (lz4 by default) than btrfs.

Going to close this, feel free to re-open if required :+1:


[QA] - Create and register 1 new stake pool with multiple owners

create the keys and addresses for the pool owners
create the stake pool (generate the cold and hot keys, handle the Key Evolving Signature Scheme, issue a node operational certificate)
register the stake pool
check that the stake pool was successfully registered
check that the pool is creating (valid) blocks and it is receiving rewards

https://github.com/ArturWieczorek/node-test-scripts/blob/master/python_scripts/e2e_scenarios/create_register_stake_pool_2owners_test.py


Warning should_run_async will not call transform_cell

should_run_async will not call transform_cell automatically in the future. Please pass the result to transformed_cell argument and any exception that happen during thetransform in preprocessing_exc_tuple in IPython 7.17 and above.

https://github.com/ipython/ipykernel/issues/540
Fix by
pip install "ipykernel==6.0.0a5" "ipython==7.21.0"

@vochicong Thank you very much


Bug: Releases are not found

Bug
There are no releases present for this repo - https://github.com/VADOSWARE/pg_idkit/blob/main/releases so I can not download the library.
Resolution Ideas
Add release binaries

Hi @t3hmrman! I just try to follow the instruction in README (Binary install section):

you may download (and verify the checksum of) a shared library versionfrom the releases

but there are no releases when I click on this link.
My understanding is that I should download this shared library and put it to /etc/postgresql/extensions, isn't it?

Ah @mboldysh apologies -- you have to build this library manually for now! There is a ticket to add a dockerfile #4 which will make it clearer, but if you look at pgx instructions it is a bit more clear.
I'll improve the documentation soon and fix the install instructions!

Oh, got it, thanks. Now it's clear so I close this issue


Fix test introduced in PR and introduce AcceleratorTestCase

Fixes test introduced in https://github.com/huggingface/accelerate/pull/991
It needed another call to AcceleratorState._reset_state() so I just moved it to the tearDown since every test in it reset the state.
Also introduces an AcceleratorTestCase class to handle the _reset_state() for users since it's very easy to forget it happens and then a cryptic stack trace follows

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Thanks!


[LIVY-563] Propagate RSC configuration when creating sessions.

Even though not all RSC configs apply to the remote driver, a few do,
so propagate all of them when starting a new session.
Includes new unit test.

Codecov Report

Merging #168 into master will decrease coverage by 0.24%.
The diff coverage is 75%.

@@             Coverage Diff              @@
##             master     #168      +/-   ##
============================================
- Coverage     68.82%   68.58%   -0.25%
+ Complexity      907      905       -2
============================================
  Files           100      100
  Lines          5662     5666       +4
  Branches        848      850       +2
============================================
- Hits           3897     3886      -11
- Misses         1213     1226      +13
- Partials        552      554       +2

Impacted Files
Coverage Δ
Complexity Δ

rsc/src/main/java/org/apache/livy/rsc/RSCConf.java
85.84% <ø> (ø)
7 <0> (ø)
:arrow_down:

...e/livy/server/interactive/InteractiveSession.scala
69.11% <75%> (+0.07%)
44 <0> (ø)
:arrow_down:

...ain/scala/org/apache/livy/utils/SparkYarnApp.scala
72.53% <0%> (-7.05%)
33% <0%> (ø)

...cala/org/apache/livy/scalaapi/ScalaJobHandle.scala
50% <0%> (-5.89%)
7% <0%> (ø)

...ain/java/org/apache/livy/rsc/driver/RSCDriver.java
78.81% <0%> (-1.28%)
42% <0%> (ø)

...main/scala/org/apache/livy/server/LivyServer.scala
35.96% <0%> (+0.49%)
11% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5b27dd...b1f682a. Read the comment docs.

Merging to master.


Modify yaml linter to enforce single quotes

Signed-off-by: Sayali Gaikawad<EMAIL_ADDRESS>Description
We had inconsistencies in yamls through out the repo with single and double quotes especially the manifests.
Added the config in .yamllint that will check during CI now.
Issues Resolved
https://github.com/opensearch-project/opensearch-build/pull/1734#issuecomment-1063460367
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1742 (db59796) into main (aa75906) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1742   +/-   ##
=========================================
  Coverage     94.79%   94.79%
  Complexity       17       17
=========================================
  Files           169      169
  Lines          3536     3536
  Branches         26       26
=========================================
  Hits           3352     3352
  Misses          181      181
  Partials          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa75906...db59796. Read the comment docs.


Replace the Embedding format from List to float[]

Adjust all affected classes including the Document.
Update docs.

Related to #405

Well, it's (slightly) better than List<Double>... It's using 16 (instead of 24) bytes per vector dimension, which is still a far cry from 4 bytes per dimension a float[] would use. And it still requires boxing and unboxing to do anything useful with, which adds up.
I understand the reluctance to use float[] directly, as it ties you to it and makes it difficult to use any other vector type (and models such as Cohere are already capable of creating int8 and bit embeddings, and any float32 vector can be quantized into similar embeddings to save space, regardless of the model used), but what we've done to address that is introduce Vector<T> interface, where T is one of float[], byte[], or BitSet via corresponding Float32Vector, Int8Vector and BitVector implementations.
It's really not that difficult to do, and it allows you to store the embeddings using the optimal memory representation, and provides a place to add common vector properties and operations on, such as dimension, magnitude, dotProduct, etc.

@aseovic, I guess your assumptions are based on the presumption that all Vector Store APIs take float[]. My experience integrating with those shows that many use List and some even List to represent vectors. So for those the float[] won't make difference or likely introduce additional boxing/unboxing steps.
Having said this i've updated the PR to float[]. Lets see how this plays out.

@aseovic

but what we've done to address that is introduce Vector interface

Where?

Fixed a few tests and the typesense impl.  Merged as d538e00643b3dcab0a3e0595aa406775733aaf3e

@aseovic, I guess your assumptions are based on the presumption that all Vector Store APIs take float[]. My experience integrating with those shows that many use List and some even List to represent vectors. So for those the float[] won't make difference or likely introduce additional boxing/unboxing steps.

I guess my take on it as that you should optimize for the vector stores that use optimal data structure to represent vectors in Java, not for the ones that don't ;-)
In other words, make the inefficient stores pay the price of that conversion if they need to, instead of punishing everyone. So yes, float[] is a much better option. Thank you!

@aseovic

but what we've done to address that is introduce Vector interface

Where?

In Coherence.


Move an endpoint between 2 collections

I have checked the following:

[X] I've searched existing issues and found nothing related to my issue.

Describe the feature you want to add
Add ability to drag and drop end point between 2 open collections. This would make it easier to build collections especially since you cannot import a collection into an existing collection.
Mockups or Images of the feature

+1

https://github.com/usebruno/bruno/issues/290

I'll close this as dupe of #290


Works only occasionally

While my LinkNLink app reports my presence or lack of presence every time within 1 second. The HA integration only sees it once out of every 5-6 times and even with it does it take up to 10 seconds to register.

While my LinkNLink app reports my presence or lack of presence every time within 1 second. The HA integration only sees it once out of every 5-6 times and even with it does it take up to 10 seconds to register.

The current approach is to check the status through polling. It will be updated to message push in the future.


CUDA error

Hi, I am trying this on a MacBook Pro M2 chip. Thanks for all the installation instructions! I am receiving this error when running the test script.
(ddg-predict2<EMAIL_ADDRESS>binding-ddg-predictor % conda install pytorch=1.10.2 cudatoolkit=11.3 -c pytorch -y
Channels:

pytorch
conda-forge
Platform: osx-arm64
Collecting package metadata (repodata.json): done
Solving environment: failed

PackagesNotFoundError: The following packages are not available from current channels:

cudatoolkit=11.3*

Current channels:

https://conda.anaconda.org/pytorch
https://conda.anaconda.org/conda-forge

To search for alternate channels that may provide the conda package you're
looking for, navigate to
https://anaconda.org

and use the search bar at the top of the page.

These are all the items in my conda environment after installation exactly as described, I am running in trouble installing pytorch with the specific CUDA:
(ddg-predict2) oliviamacleod@Olivias-MacBook-Pro binding-ddg-predictor % conda list
packages in environment at /opt/homebrew/Caskroom/miniforge/base/envs/ddg-predict2:

Name                    Version                   Build  Channel
biopython                 1.79             py38hb991d35_3    conda-forge
bzip2                     1.0.8                h93a5062_5    conda-forge
ca-certificates           2024.6.2             hf0a4a13_0    conda-forge
easydict                  1.9                        py_0    conda-forge
libblas                   3.9.0           22_osxarm64_openblas    conda-forge
libcblas                  3.9.0           22_osxarm64_openblas    conda-forge
libcxx                    17.0.6               h5f092b4_0    conda-forge
libffi                    3.4.2                h3422bc3_5    conda-forge
libgfortran               5.0.0           13_2_0_hd922786_3    conda-forge
libgfortran5              13.2.0               hf226fd6_3    conda-forge
liblapack                 3.9.0           22_osxarm64_openblas    conda-forge
libopenblas               0.3.27          openmp_h6c19121_0    conda-forge
libsqlite                 3.45.3               h091b4b1_0    conda-forge
libzlib                   1.3.1                hfb2fe0b_1    conda-forge
llvm-openmp               18.1.6               hde57baf_0    conda-forge
ncurses                   6.5                  hb89a1cb_0    conda-forge
numpy                     1.24.4           py38ha84db1f_0    conda-forge
openssl                   3.3.1                hfb2fe0b_0    conda-forge
pip                       24.0               pyhd8ed1ab_0    conda-forge
python                    3.8.19          h2469fbe_0_cpython    conda-forge
python_abi                3.8                      4_cp38    conda-forge
readline                  8.2                  h92ec313_1    conda-forge
setuptools                70.0.0             pyhd8ed1ab_0    conda-forge
tk                        8.6.13               h5083fa2_1    conda-forge
wheel                     0.43.0             pyhd8ed1ab_1    conda-forge
xz                        5.2.6                h57fd34a_0    conda-forge


Minifier tasklist

[ ] Boolean(true) => true

[ ] RegExp with a wrong flag should not be converted.

https://github.com/swc-project/swc/blob/86b5641d5ef46d1cb63019d29c17915b7caf9fa0/crates/swc_ecma_minifier/tests/terser/compress/issue_269/regexp/input.js#L5

[ ] Drop more unused assignments

https://github.com/swc-project/swc/blob/a0b0fd3e0d8a1084a0399e8b0345d66cfe835b0f/crates/swc_ecma_minifier/tests/terser/compress/drop_unused/chained_3/input.js#L1-L8
We can drop a because c = b follows it.

[ ] IIFE: Object literal

[ ] sequential inliner: typeof

[ ] Swap more

[ ] if_return is not good as one of terser

[ ] Optimize parens

Are these tasks up to date?
PS: 😯I wonder about the real-world use case of Boolean(true) => true.

Yes, those are up-to-date, and I don't remember the input file.
I added it to the list because I faced it in a real-world input, but I expected myself to implement it in a near time 🤣

Closing as obsolete. I'll use TODO.txt of terser


Uncaught TypeError error in browser console when deleting nodes from canvas

Current Behavior
Deleting a node with no label (i.e. link nodes) causes browser console Uncaught TypeError error
Uncaught TypeError: Cannot read properties of null (reading 'getAttribute')
    at Ma.attr (vendor.js?v=3.0.0-beta.4:formatted:20862:66)
    at getElementPosition (red.js?v=3.0.0-beta.4:22867:20)
    at getElementPosition (red.js?v=3.0.0-beta.4:22880:25)
    at red.js?v=3.0.0-beta.4:23438:35

Expected Behavior
no error
Steps To Reproduce

add a hand full of link in / link out nodes.
click then delete before 500ms
error is thrown as above

Example flow
No response
Environment

Node-RED version: v3. beta5 and prior (including v2.x)
Node.js version:
npm version:
Platform/OS:
Browser:

NOTE: A similar problem exists if you hover a node port then delete the node before 500ms
Uncaught TypeError: Cannot read properties of null (reading 'getAttribute')
    at Ma.attr (vendor.js?v=3.0.0-beta.4:formatted:20862:66)
    at getElementPosition (VM4182 red.js:22867:20)
    at getElementPosition (VM4182 red.js:22880:25)
    at getElementPosition (VM4182 red.js:22880:25)
    at getElementPosition (VM4182 red.js:22880:25)
    at VM4182 red.js:22996:27


Suggestion: finding an array inside JSON data

in JSON2CSVParser.js it could be:
  preprocessData(data) {
    //const processedData = Array.isArray(data) ? data : [data];
    //
    let processedData
    if (Array.isArray(data)) {
      processedData = data
    } else { //find an array inside JSON data
      for (let k in data) {
        if ( Array.isArray(data[k]) && (data[k].length > 1) ) {
          processedData = data[k]
          break;
        }
      }
    }
    if (!processedData) {
      processedData = [data]
    }

I understand why you'd want this, but I think this would be inconsistent, since the spec for objects does not guarantee order so subsequent runs might not select the correct array if multiple.
Also this would be a breaking change and would require a major version change.
If you are trying to do this from the CLI, I recommend using something like https://www.npmjs.com/package/node-jq and transforming your JSON. If you want this in JS, then just manually provide the array from your JSON.

OK - I'll try your suggestion.
This is not a change for * @param Array, and maybe  * @param Object is not very useful (is it?).
'spec does not guarantee order' - yes, it is not useful for multiple arrays with length>1.

Hi @andrzejQ,
I agree with @knownasilya
The JSON specification doesn't guarantee the order of an object field. The problem is not that it's not useful for objects with multiple arrays, the problem is that the proposed feature is not even deterministic (you might get different results in different engines).
And it also might break things for users that rely on the correct errors of this library.
This sounds like a very concrete use case that you have so I'd suggest preprocessing your data so it's valid for json2csv.
I'll close this. Feel free to reopen if you think that there is something left to discuss.


feat(syntax): Add Sapling commit message editor syntax highlighting

Stack created with Sapling. Best reviewed with ReviewStack.

-> #11688

feat(syntax): Add Sapling commit message editor syntax highlighting
Summary: Since sl is close enough to hg, just changed HG to SL or HG.
Additionally, to support sl commit --verbose, add a hgcommitDiff.vim
that's a copy of syntax/diff.vim but adds the SL prefix to each line
Questions for reviewer

I know copy/pasting diff.vim is lame.  Would you rather I simply make the (HG | SL): part optional and add it to diff.vim?  I only have two remarks about that

I don't want to add irrelevant matchers to "diff".vim, and am worried this would set a precedent to further clutter it in the future
I haven't measured the performance regression this would cause.  I'm worried it would be noticeable on large files that I personally don't notice in my sl commit --verbose editors

Example:

feat(syntax): Add Sapling commit message editor syntax highlighting

Summary: Since sl is close enough to hg, just changed `HG` to `SL` or `HG`.

Additionally, to support `sl commit --verbose`, add a `hgcommitDiff.vim`
that's a copy of `syntax/diff.vim` but adds the SL prefix to each line

Test Plan: TODO

 SL: Enter commit message.  Lines beginning with 'SL:' are removed.
 SL: Leave message empty to abort commit.
   So how are
you going to do maintenance?  You can perhaps do it manually, but if you
have some script to make those change it would be easier.
Please remove my name from the header, I'm not going to maintain this
file.
--
Linux is just like a wigwam: no Windows, no Gates and an Apache inside.
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

@brammool Yeah, I brought this up in my PR description.  Not sure the best way to do it.
I removed you as a maintainer.  I agree a script would be better, but ngl I don't feel like making one 😉 �

@vegerot commented on this pull request. > @@ -0,0 +1,391 @@ +" Vim syntax file +" Language: Sapling / Mecurial Diff (context or unified) +" Maintainer: Bram Moolenaar @.> +" Max Coplan @.> +" Translations by Jakson Alves de Aquino. +" Last Change: 2022-12-08 +" Copied from: runtime/syntax/diff.vim + +" Quit when a (custom) syntax file was already loaded +if exists("b:current_syntax") + finish +endif +scriptencoding utf-8 + +syn match diffOnly "^%(SL|HG): Only in ." done
It looks like you took diff.vim and applied some changes. So how are you going to do maintenance? You can perhaps do it manually, but if you have some script to make those change it would be easier. Please remove my name from the header, I'm not going to maintain this file.
…
-- Linux is just like a wigwam: no Windows, no Gates and an Apache inside. /// Bram Moolenaar -- @.** -- http://www.Moolenaar.net \\ /// \\ \\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ /// \\ help me help AIDS victims -- http://ICCF-Holland.org ///

@brammool done! :)

Will "hgcommitDiff" ever be a filetype?  As it is now it is only used where it is included in hgcommit.vim.
It would better to place it in another location.  Perhaps in syntax/shared?

Will "hgcommitDiff" ever be a filetype? As it is now it is only used where it is included in hgcommit.vim.
It would better to place it in another location. Perhaps in syntax/shared?

@brammool how's this?

I think this is mostly OK.  I wonder if @k-takata  is OK adding you as maintainer.

I think this is mostly OK. I wonder if @k-takata is OK adding you as maintainer.

I'm OK.
@vegerot
I'm maintaining hgcommit.vim at https://github.com/k-takata/hg-vim, so could you also create a PR to it?
Also, it might be better to update .github/CODEOWNERS to add runtime/syntax/shared/hgcommitDiff.vim.

@k-takata done ✅

Merged into my repository.

Merged into my repository.

Should I include this PR or are you going to send me one?
--
FATHER: We are here today to witness the union of two young people in the
joyful bond of the holy wedlock.  Unfortunately, one of them, my son
Herbert, has just fallen to his death.
[Murmurs from CROWD;  the BRIDE smiles with relief, coughs.]
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Could you include this PR?

I'll include it.


FlexibleSpace in AppBar covers action/back button splash/highlight

Steps to Reproduce
Create AppBar and insert Container with some color into the flexibleSpace. See that the container covers the splash and highlight effect on the back button.
Flutter Doctor
[✓] Flutter (on Linux, locale en_US.UTF-8, channel alpha)
    • Flutter at /home/kamil/Flutter
    • Framework revision 8f65fec5f5 (6 weeks ago), 2017-12-12 09:50:14 -0800
    • Engine revision edaecdc8b8
    • Tools Dart version 1.25.0-dev.11.0
    • Engine Dart version 2.0.0-edge.d8ae797298c3a6cf8dc9f4558707bd2672224d3e

[✓] Android toolchain - develop for Android devices (Android SDK 26.0.2)
    • Android SDK at /home/kamil/Programs/Android/
    • Android NDK at /home/kamil/Programs/Android/ndk-bundle
    • Platform android-26, build-tools 26.0.2
    • ANDROID_HOME = /home/kamil/Programs/Android/
    • Java binary at: /home/kamil/Programs/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b01)

[✓] Android Studio (version 3.0)
    • Android Studio at /home/kamil/Programs/android-studio
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b01)

[✓] Connected devices
    • SM A320FL                 • 5203d96964e7c395 • android-arm • Android 7.0 (API 24) (emulator)
    • Android SDK built for x86 • emulator-5554    • android-x86 • Android 7.1.1 (API 25) (emulator)

@Hixie the gallery app has this behavior on Home and on ContactsDemo. IconButtons don't ripple. Is there a workarround?

@ianldgs Does the Ink widget not work for you?
cc @HansMuller to investigate gallery issues reported above.

@Hixie nope.
I'm actually using a SliverAppBar, so I think its a different case of @kamilez.
The solution might be wrap the actions inside the AppBar widget with a new Material.
I tried to put the Ink arround the background of my FlexibleSpaceBar, but it didn't work. Also tried using a Stack with a Material on top of the background, but no success either.

@ianldgs Ok sounds like you're hitting a different problem. I recommend filing a new issue with code showing the problem you're running into.

Kept open for https://github.com/flutter/flutter/issues/14202#issuecomment-359521866

@kamilez I mean literally the widget named "Ink".

@ianldgs @zoechi Had similar issues with my SliverAppBar. Was using a Container inside the flexibleSpace to have a linear gradient as background for the app bar, but it was covering the TabBar buttons splash. Here's what I ended up doing and it works!
flexibleSpace: Ink(
  child: Container(),
  decoration: BoxDecoration(
    gradient: LinearGradient(
      begin: Alignment(-1.5, -2.5),
      end: Alignment(1.5, 2.5),
      colors: [Colors.pink, Colors.purple[600]],
    ),
  ),
),

The Ink widget requires the child property to be set to a widget that will take the whole available space, otherwise build will just fail.

This does not seem to be solved at this point. As @ianldgs already pointed out, you can observe the issue by taking a look at the current behavior of the Contacts example in the Gallery app. Neither the actions nor the leading icon generate a splash effect on tap when the background image is fully visible.
When the user scrolls until the SliverAppBar is collapsed and the blue background is shown, the splash will be visible on tap.
Is this intended behavior? If so, what would be the best way to show a splash on tap? Wrapping the flexibleSpace with a Material for example does not work.

Hi @kamilez
I'm closing this issue as it refer to an older version of Flutter.
If you are you still experiencing this issue with the latest version of Flutter,
you may want to open a new issue or comment below;
either way please provide your updated flutter doctor -v.
It would be helpful to have also your flutter run --verbose
and a self contained app on github (or the steps to reproduce it).
Thank you


/en-US/docs/Web/JavaScript/Reference/Template_literals

Request type

[x] New documentation

Details
The String.raw() example lists incorrect output, indicating that the result of this expression: String.rawHi\n${2+3}! is "Hi\n5!". But that is a 5-element string which contradicts the next line of the example:
str.length;
// 6
The output should instead be "Hi\n5!"
Hmm...markdown renders that incorrectly...
"Hi\\n5!"

The examples on this page are likewise incorrect: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/raw
This page on String.raw() also uses the term "template string", which appears to be outdated based on the template literal documentation above.

I cannot find the issue in the live page.. am I missing anything?

Both issues are still present.
The first page (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals) shows this example under the section "Raw strings":
let str = String.raw`Hi\n${2+3}!`;
// "Hi\n5!"

str.length;
// 6

Those 2 results contradict each other.
"Hi\n5!"

is a string of length 5.
Whereas the correct output should be:
> let str = String.raw`Hi\n${2+3}!`
undefined
> str.length
6
> str
'Hi\\n5!'

Furthermore, the second page (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/raw) consistently refers to "template strings" in the text and the link at the bottom of the page. As the first page indicates, this is an obsolete term. The documentation should reflect the usage in the standard: template literals

Thanks for getting back @dsletten
There's a comment afterward that says: the character after 'Hi' // is not a newline character, // '\' and 'n' are two characters. which explains why \n shows up as 2 characters instead of 1. Indeed, if you wanted to create it yourself without String.raw, you would have to use \\n to escape it but this is not the case here, so I don't think it makes sense to write the string escaped (considering that we have the explanation in comments). Does that make sense?
In the template strings page, instead of the comment, there's this code: Array.from(str).join(','); which shows how it is indeed made up of 6 characters. Please let me know if I missed something.
As for the 2nd issue, can you tell me where you saw that the term "template string" is obsolete? I could not find that on the template literals page.
Thanks!

Evidently you are referring to the 2nd page: String.raw(). My observation refers to the first page: Template literals. The example shows this result as a literal String:
let str = String.raw`Hi\n${2+3}!`;
// "Hi\n5!"

In JavaScript, that literal value represents a 5-character string. The backslash must be escaped to show that it is a literal '' and not a newline '\n'.
With regard to the 2nd issue, the "Template literals" reference page opens with this statement:
They were called "template strings" in prior editions of the ES2015 specification.

If the language specification no longer uses the term "template strings", then ideally the MDN documentation should reflect this.

Thanks @dsletten, I've opened a PR to change template strings to template literals. I did leave out templateString the specification still refers to templateString inside template strings.
Regarding the first issue, I will leave it for someone else, as I get your point but considering the clarification under it I think it makes sense. However, I could be wrong so I will leave it for someone else to take a look at


Stats measure for produced items added

Hey @zergey both here and in https://github.com/TeamHG-Memex/scrapy-cdr/pull/18 I'd be happy to merge if the build was passing. The fact that the build is broken is not related to your PR's, but without a working build it's harder to be sure that everything is still working. If you make a PR to fix the build (a separate one or here), I'd be happy to merge them, or I can do that myself later this week.

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is 0%.

@@         Coverage Diff          @@
##           master    #5   +/-   ##
====================================
  Coverage       0%    0%
====================================
  Files           4     4
  Lines         110   112    +2
====================================
- Misses        110   112    +2

Impacted Files
Coverage Δ

scrapy_kafka_export/extensions.py
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6322717...3802183. Read the comment docs.

Hi @lopuhin ! Both PR's were updated, issues are fixed


Support gen_statem in error logger

Add a simple case to support gen_statem crashes, since they generate the
same message in error_logger but not the same returned state.

@nickelization care to take a look on this one as well?

This is really nice. Thank you!
Would you mind adding a test here so I can get this merged?

@mrallen1 how should the test be implemented? It feels like it's just a case of gen_fsm messages vs gen_statem messages and gen_fsm crash capturing is not really tested in lager

You know, you're right! I had thought we covered it, but we haven't!

I pushed a new branch fsm_test which has a gen_fsm and gen_statem that crash and conditionally compile statem on OTP 19+ only. So my plan is to merge your PR into that branch and then put at least one simple test in.

I'm going to close this now as I have green tests on #391. Thanks for your patch!


Simple Browser just shows blank page

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.70.1
OS Version: Windows 11

Steps to Reproduce:

Enter URL in Simple Browser (Example: https://github.com/)
Page just stays blank

Screenshot:

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.70.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Probably https://github.com/microsoft/vscode/issues/146656#issuecomment-1088037400
/assign @mjbvz

Thanks for linking the other issue. I just tested the Simple Browser with another URL (https://typescript.tv/) and it worked (although YouTube videos were not loaded), so the bug seems to be related to website content configurations.

Yes duplicate of https://github.com/microsoft/vscode/issues/146656#issuecomment-1088037400
Github (and many other popular sites) don't allow themselves to be embedded


Node picker for the export NodePath variable doesn't give a correct Node path when is set in a custom Resource

Godot version:
3.2.1
OS/device including version:
Window 7
Issue description:
if you set an export NodePath in a custom resource then pass that resource to another Node and calling get_node() on it will return null
when setting the NodePath in the Resource it gives Node2/Node3/HasNeededVar which gives the error above
and when set in the referencing Node it gives ../Node2/Node3/HasNeededVar which works fine
Steps to reproduce:
so we have a node somewhere with this script on it
extends Node
var n_var = 10

with a nod hierarchy like so "/root/Node/Node2/Node3/HasNeededVar" and we have a custom resource
extends Resource
class_name resource_getter

export (NodePath) var getter
export (String) var var_name

create and instance of this resource and set the NodePath, and the String for the parameter we want to access manually and in another Node in the same scene add this code
extends Node
export (Resource) var getter_resource
func _ready():
    var getter = getter_resource.getter
    var var_name = getter_resource.var_name
    var got = get_node(getter).get(var_name)
    print (got)

drag the custom resource to the getter_resource var in the inspector and run and get 'can't call get() on base null'
Minimal reproduction project:
NodePath Resource.zip

I tried the sample project, but it works without any issue for me.

@Ev1lbl0w sorry I uploaded the version where the NodePath is a String, I fixed it
sorry...

Thanks. I've retried, and yes, the problem is happening if I don't make any changes.
However, when I click on the NodePath field to fix it, it changes the original Node2/Node3/HasNeededVar to the correct ../Node2/Node3/HasNeededVar (fixing the issue), and I can't make it go back to the original value again.
How were you able to set the NodePath to that value?

@Ev1lbl0w you click on the NodePath var in the custom resource, it gives a picker, you pick the Node you want

so the Node picker for the export NodePath variable is the problem when setting it in the Resource it gives Node2/Node3/HasNeededVar
and when set in the referencing Node it gives ../Node2/Node3/HasNeededVar

so the Node picker for the export NodePath variable is the problem when setting it in the Resource it gives Node2/Node3/HasNeededVar
and when set in the referencing Node it gives ../Node2/Node3/HasNeededVar

Ah, so that's how it's happening :smile:
Honestly, I don't know if this is a bug. When you're editing the resource from the node's context, Godot is able to infer the NodePath knowing where it comes from (in this case, Getter).
But when you're editing this resource directly without a scene tree, Godot has no idea where the path will begin, so it assumes the root.

@Ev1lbl0w make sense, then the type NodePath shouldn't be available under Resource, or this solution is too drastic ?

@Ev1lbl0w make sense, then the type NodePath shouldn't be available under Resource, or this solution is too drastic ?

No, your solution works well. The only thing you'll have to do is edit the resource's NodePath directly from the Node, and not on the Resource itself.

I will close this since this seems to be not a bug but a workflow issue on my part


Option .map should probably gracefully handle Functions that return null.

See the source below.
default <U> Option<U> map(Function<? super T, ? extends U> mapper) {
    Objects.requireNonNull(mapper, "mapper is null");
    return this.isEmpty() ? none() : some(mapper.apply(this.get()));
}

If the mapper can potentially return nulls, this will cause a Some to be created with a null value. This prevents chaining such as Option.of(someObj).map(someFunctional).map(someOtherFunctional).
I know Option is not meant to mimic Java's implementation, but I feel the Optional has this right.

Hi @chantrybjss,
thank you, that is one of the most controversial discussed topics regarding Vavr.
Vavr was originally designed to bring some of the Scala goodness to the Java world, including Option’s semantics. Today, after developing Vavr for more than 4 years, I would handle things a little different.
In the first place, a library that extends an existing language, must not duplicate features, especially when using different semantics (like Vavr does with Option).
Second, similar features, like Try, Either, ..., should align to existing native API’s (like Optional) in order to not confuse developers.
I already thought about changing Vavr by completely removing Option and align the Try API to the one of Optional. What would we loose?
The main features of Vavr’s Option are

it is iterable
it is serializable
it is convertible within the Vavr space

Convertability currently does not scale very well because of tight coupling. This is a solvable problem.
I give nothing about so-called serializability. Sending objects through a wire can be achieved without extending Serializable.
The most important aspect (of all Vavr values) is that they are iterable. It enables us to compose things in a gereric way.
—-
What is your main reason to use Vavr’s Option. Could you also use Optional? What hinders you/what would it take to increase interoperability between Vavr and Java’s Optional?
Thx!

In this case, I have actually reverted to using Optional in my code.
My main concern is that the map method allows Option to create a Some with a null value, which I had  assumed would be impossible.
I have looked closer at the code and it appears map is not unique in this respect. I had assumed some() was a private scoped method, but it is actually possible to create Some objects of null type (seemingly by design).
It is my opinion that it should not be possible to create null valued Some objects. However, I do not want to get into a debate about API design, so unless there is some other reason, I think it is safe to close this issue.

@chantrybjss as a workaround you could use this pattern:
option.map(nullReturningFunction).flatMap(Option::of)

The flatMap(Option::of) would make sure you switch over from Some(null) to None.

I think there are subtle philosophical differences between Optional and Option. Optional starts from a universe of null pointers and tries to make it easier for functional programming to operate in that universe. Option starts from a universe of functional constructs and includes a bridge (Option.of) to get data out of that other universe.
Vavr-native code shouldn't use null, and if you're talking to a non-Vavr-native library that's documented to return nulls (such as java.util.collection), Vavr's design encourages you to wrap it in Options; but Option isn't intended as a mechanism to prevent NullPointerExceptions.
The way to think about nullable code, I think, is a bit like unsafe in C# or Rust—don't spend any more time there than you have to, be careful when you do and don’t let the nulls escape into your “safe” core code.
Some day, maybe @Nullable will be standardized and enforcable and magically applied to the whole compilation scope by static analysis, but until then, as they say in Python, “explicit is better than implicit”. If you forget the Option.of call, that's a programming error that should fail fast.

(P.S. Some interesting discussion of the history of Optional here, including links to mailing list archives where you can dig into the fights over why it doesn't behave like [various other Option implementations and Option-like things that all behave differently from one another]. If you want to go down that rathole, the Loose Ends: Optional thread is particularly interesting.)

Some features that are possible because of our Option implementation:

Our Map supports null keys and values. I.e. map.get(k) may return Some(null) if the k is associated with null, and None if no value is associated with k.
Symmetrie: option.toTry().toOption() = option (works for both, Some and None)

That's how things should work. My experience is that other interpretations are eligible but not canonical.

Some features that are possible because of our Option implementation:

Our Map supports null keys and values. I.e. map.get(k) may return Some(null) if the k is associated with null, and None if no value is associated with k.
Symmetrie: option.toTry().toOption() = option (works for both, Some and None)

That's how things should work. My experience is that other interpretations are eligible but not canonical.

This example with Map makes sense, however getting Some(null) is not very useful, is it? Maybe in both cases we should get None, or we should have possibility to implicitly convert from Some(null) to None() if we want it?!

There are blogs written about this, Some(null) must be possible in order for Option to obey the functor laws.  It is java's Optional that is broken—Scala and vavr got it right.


Allows code to catch an IndexError if the composer tries to write to …

…a column that is greater than the index corresponding to Z.

Coverage increased (+0.3%) to 80.537% when pulling 306c9a6b23b3c6d2b48a13d91c356ac4bcda9a27 on catch-index-error into d4adef9fe0630f39c3664d3913bbbbe3db3ec069 on master.


rename worker labels to the same pattern from others kubeshark components

Ensure all Kubeshark components use the pattern app.kubeshark.co/app=<component>

Codecov Report
Patch and project coverage have no change.

Comparison is base (742a562) 7.66% compared to head (e433619) 7.66%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1410   +/-   ##
======================================
  Coverage    7.66%   7.66%
======================================
  Files          47      47
  Lines        2987    2987
======================================
  Hits          229     229
  Misses       2748    2748
  Partials       10      10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Custom Locations not listed when creating new Web App on App Service on Kubernetes With Azure Arc

I have found in VSCode 1.64.0 with ms-azuretools.vscode-azureappservice I am no longer able to list custom locations during Advanced Web App Create.  All I see listed are Azure regions.

Do you know if you downgrade VSCode or the Azure App Services extension, if this resolves the problem?  I suspect that something changed with the Azure API, but it would be nice to be able to eliminate those variables!

Maybe related to https://github.com/microsoft/vscode-azuretools/pull/1006. The API changed and I had to update our listing query.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!

Hi @apwestgarth
Could you confirm that this is still an issue?
With the current released version, I am seeing my custom location:

Maybe it was an error in the API that was resolved?


set proper parsing properties to prevent XXE

Pull Request Test Coverage Report for Build 5423

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.007%) to 55.891%

Totals

Change from base Build 5420:
0.007%

Covered Lines:
15217

Relevant Lines:
27226

💛  - Coveralls


Is this library still supported ?

In terms of answering questions, yes.
In terms of code changes, no. This project has fundamental problems. I have updated the project README to steer developers to other solutions.


Minor fix getting description of Ports

Minor fix getting description of Ports
Description
In some cases the port may not have the "description" field, and the "_to_port" function fails.
Status

done, ready for review

Checklist (tick everything that applies)

[x] Code linting (required, can be done after the PR checks)
[ ] Documentation
[ ] Tests
[x] ICLA (required for bigger changes)

Codecov Report

Merging #1543 (f98a7df) into trunk (d5e957a) will decrease coverage by 1.69%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            trunk    #1543      +/-   ##
==========================================
- Coverage   84.77%   83.07%   -1.70%
==========================================
  Files         388      394       +6
  Lines       81521    84738    +3217
  Branches     8243     9002     +759
==========================================
+ Hits        69111    70399    +1288
- Misses       9422    11274    +1852
- Partials     2988     3065      +77

Impacted Files
Coverage Δ

libcloud/compute/drivers/openstack.py
85.74% <100.00%> (+0.06%)
:arrow_up:

libcloud/compute/drivers/outscale.py
8.67% <0.00%> (-10.68%)
:arrow_down:

libcloud/test/dns/test_digitalocean.py
90.72% <0.00%> (-9.28%)
:arrow_down:

libcloud/dns/drivers/linode.py
82.80% <0.00%> (-5.03%)
:arrow_down:

libcloud/test/storage/test_local.py
91.41% <0.00%> (-2.24%)
:arrow_down:

libcloud/dns/drivers/cloudflare.py
92.16% <0.00%> (-1.53%)
:arrow_down:

libcloud/compute/drivers/digitalocean.py
84.86% <0.00%> (-0.33%)
:arrow_down:

libcloud/storage/drivers/s3.py
89.66% <0.00%> (-0.18%)
:arrow_down:

libcloud/test/compute/test_openstack.py
94.43% <0.00%> (-0.01%)
:arrow_down:

libcloud/common/types.py
97.01% <0.00%> (ø)

... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5e957a...f98a7df. Read the comment docs.

Codecov Report

Merging #1543 (f98a7df) into trunk (d5e957a) will decrease coverage by 1.69%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            trunk    #1543      +/-   ##
==========================================
- Coverage   84.77%   83.07%   -1.70%
==========================================
  Files         388      394       +6
  Lines       81521    84738    +3217
  Branches     8243     9002     +759
==========================================
+ Hits        69111    70399    +1288
- Misses       9422    11274    +1852
- Partials     2988     3065      +77

Impacted Files
Coverage Δ

libcloud/compute/drivers/openstack.py
85.74% <100.00%> (+0.06%)
:arrow_up:

libcloud/compute/drivers/outscale.py
8.67% <0.00%> (-10.68%)
:arrow_down:

libcloud/test/dns/test_digitalocean.py
90.72% <0.00%> (-9.28%)
:arrow_down:

libcloud/dns/drivers/linode.py
82.80% <0.00%> (-5.03%)
:arrow_down:

libcloud/test/storage/test_local.py
91.41% <0.00%> (-2.24%)
:arrow_down:

libcloud/dns/drivers/cloudflare.py
92.16% <0.00%> (-1.53%)
:arrow_down:

libcloud/compute/drivers/digitalocean.py
84.86% <0.00%> (-0.33%)
:arrow_down:

libcloud/storage/drivers/s3.py
89.66% <0.00%> (-0.18%)
:arrow_down:

libcloud/test/compute/test_openstack.py
94.43% <0.00%> (-0.01%)
:arrow_down:

libcloud/common/types.py
97.01% <0.00%> (ø)

... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5e957a...f98a7df. Read the comment docs.


Wrong import in example

In example at Readme:
from ratelimit.backends.redis import MemoryBackend, RedisBackend

For MemoryBackend should be:
from ratelimit.backends.simple import MemoryBackend

Thanks, i fixed it.


options.algorithms does not set correct algorithm when client uses RS256

Here is the code in verify.js, lines 61-68, of this repo that determines which algorithms array to attach to the options:
options.algorithms = ~secretOrPublicKey.toString().indexOf('BEGIN CERTIFICATE') ||
                      ~secretOrPublicKey.toString().indexOf('BEGIN PUBLIC KEY') ?
                       [ 'RS256','RS384','RS512','ES256','ES384','ES512' ] :
                       ~secretOrPublicKey.toString().indexOf('BEGIN RSA PUBLIC KEY') ?
                       [ 'RS256','RS384','RS512' ] :
                       [ 'HS256','HS384','HS512' ];

However, if in the Auth0 console I select RS256 as my JsonWebToken signature algorithm, this library throws an invalid algorithm error because the secret does not begin with 'BEGIN RSA PUBLIC KEY', so it thinks that ['HS256','HS384','HS512'] are the only valid algorithms. Of course, my header.alg is set to RS256, and so the code right below the code above throws an error:
if (!~options.algorithms.indexOf(header.alg)) {
  return done(new JsonWebTokenError('invalid algorithm'));
}

Oh I see now that I should not be using this library when signing with RS256: https://auth0.com/docs/quickstart/backend/nodejs/03-authenticate-rs256


Suppress self update for windows CI runner

Which issue does this PR close?
Close #9653

Sometimes CI fails because of rustup, we can re-reun the job and pray for the success.
rustup update stable
  rustup toolchain install stable
  rustup default stable
  rustup component add rustfmt
  shell: C:\Program Files\Git\bin\bash.EXE --noprofile --norc -e -o pipefail {0}
info: syncing channel updates for 'stable-x86_64-pc-windows-msvc'

  stable-x86_64-pc-windows-msvc unchanged - rustc 1.76.0 (07dca489a 2024-02-04)

info: checking for self-update
info: downloading self-update
D:\a\_temp\1c8b34cc-212a-[46](https://github.com/apache/arrow-datafusion/actions/runs/8319817263/job/22763668481?pr=9651#step:3:49)4d-8031-14d0aca81a56.sh: line 2: /c/Users/runneradmin/.cargo/bin/rustup: Device or resource busy
warning: tool `rust-analyzer` is already installed, remove it from `C:\Users\runneradmin\.cargo\bin`, then run `rustup update` to have rustup manage this tool.
warning: tool `rustfmt` is already installed, remove it from `C:\Users\runneradmin\.cargo\bin`, then run `rustup update` to have rustup manage this tool.
warning: tool `cargo-fmt` is already installed, remove it from `C:\Users\runneradmin\.cargo\bin`, then run `rustup update` to have rustup manage this tool.

There is a workaround solution so we can avoid manually re-run CI job.
Downside is that we need to manual update latest rust version for window.
Possible issue
https://github.com/rust-lang/rustup/issues/2441
https://github.com/rust-lang/rustup/issues/3709
Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

I create a new label CI/CD pipeline mainly for fix that related to CI

ci: critial,  ci: important and ci: feature

Merging to stop CI failures on main -- let's contemplate adding the same for other OS's (@comphead 's comment https://influxdata.slack.com/archives/C04PASKL88P/p1710802371742879?thread_ts=1710795428.769569&cid=C04PASKL88P) as a follow on PR


Installation: calib folder doesn't get copied properly

Hi JK,
When I install your pipeline with python setup.py install not all files from the directory calib get copied.
Cheers,
Steve

Should be fixed by latest merge #12. Otherwise let me know.
Note that the pixeltables in the calib folder are mere cached copies of recent reductions and should therefore not be copied to individual users as they are supposed to generate them themselves.


Backup schedule time Select isn't rendering the proper backup windows.

There are inconsistencies between backup schedule between managers.

@na3d can you please update this title to be more specific. The description could probably be clearer too. Thanks.

@na3d can you please update this title to be more specific. The description could probably be clearer too. Thanks.

@rjstires passing to @na3d for clarification.

As the screenshots show above, the Backup Window/Time of Day for scheduling backups do not match.    In EST, Time of Day should be 1AM-3AM if it was rendering properly.
Side Note:
Rob and I plan on working on this together so we can go over the code in more detail.

[Pending API Fix]

Windows are based on GMT-1


Typofix type signature for main in tutorial

Leaving off Str results in an error like the following:
── TYPE MISMATCH in ....0/SlwdbJ-3GR7uBWQo6zlmYWNYOxnvo8r6YABXD-45UOw/main.roc ─

Something is off with the type annotation of the main required symbol:

2│      requires {} { main : Task {} [Exit I32 Str]_ }
                             ^^^^^^^^^^^^^^^^^^^^^^^

This #UserApp.main value is a:

    Task {} [Exit …, …]

But the type annotation on main says it should be:

    Task {} [Exit … Str, …]
...

etc.

Thanks for the fix!


Fix DB backup scripts

We have manual backups, but the automatic database backup scripts don't seem to be working. Make sure that these work automatically with crontab.

The problem seems to have been a matter of using a relative path that has been replaced with an absolute path, and now it works. I'll check on this tomorrow, as well.


CSS drop-down menu visualisation problem

Describe the bug
Hi,
I don't know if this problem has been already reported but there is a visualization problem on the drop-down menu probably due to a CSS error as you can see in the screenshot.
To Reproduce
Steps to reproduce the behaviour:

Go to https://tanzu.vmware.com/developer/learningpaths/
Put the cursor on the "Learn" menu
You can see the CSS problem

Expected behaviour
A clear and concise description of what you expected to happen.
Screenshots

Desktop (please complete the following information):

OS: MacOS Monterey
Browser Brave
Version 1.34.80

** Notes **
It also happens hovering on both Tanzu.TV and Community menus.

@dlion Is this issue occurring during a preview of the site or when you view the actual site? I'm not able to reproduce this issue on Brave with the live site.  Site note, however, I have also seen this issue during a local preview with longer names on the community dropdown.

Hi @danielramirez0 , it's the live site.
I don't have specific extensions that could have impacted my experience
I just visited  https://tanzu.vmware.com/developer/learningpaths/ and moved the cursor over the menu.

I tried to visit the website on Safari and it works fine so I guess it's just my brave instance for some reason 🤔

Unable to replicate issue on any browser (tested with Chrome, Edge, Safari, and Brave).


Set SharedDrawManager to null when disposing

My game on Android crashed when I went to another Activity and came back, because of a check if the GraphicsDevice is null:
See InitializeMainWindow(CCSize windowSizeInPixels, bool isFullscreen = false) on line 557.

Thanks for that fix !!!


[jpeg2000] libjasper does not create profile 3 and profile 4 images required for Digital Cinema applications

Based on private mail with Terrance Mali..., the author of OpenDCP, he brought up the fact that Jasper does not support profile 3 or 4 of the jpeg2000 spec as well as supporting codestream lengths or single tiles, making it unsuitable for DCDM creation.
The solution I put forward is to rewrite the jpeg2000 plugin to use libopenjpeg instead.

Hi rexbron
would You be so kind to send me some spare profile 3 and profile 4 images? Are there any of those images on the net? Can't find it.

Hey maketm,
Sorry for the delay. I'm currently out of my home country. I return on the
10th of Nov and I will get you some samples then.
On Oct 23, 2011 8:47 AM, "matekm" <
<EMAIL_ADDRESS>wrote:

Hi rexbron
would You be so kind to send me some spare profile 3 and profile 4 images?
Are there any of those images on the net? Can't find it.
--
Reply to this email directly or view it on GitHub:
https://github.com/OpenImageIO/oiio/issues/83#issuecomment-2495385

Thanks for the file, look like reading of the file is working.

Hey Matekm,
Does your branch also implement a writer that can write 12 bit images?
Cheers,
Andrew
On Sun, Nov 13, 2011 at 9:37 AM, matekm <
<EMAIL_ADDRESS>
wrote:

Thanks for the file, look like reading of the file is working.

Reply to this email directly or view it on GitHub:
https://github.com/OpenImageIO/oiio/issues/83#issuecomment-2722538

Not yet, but if it is important to You I think I can implement it. For now, I try to finish the writer so it pass all tests from testsuite.

Ok, I think the plugin is ready, if someone is interested - please compile code from my repo nad test it (it is synchronized with master). In the meantime I will add support for writing 10/12 bits images

Hey,
I compiled your code and I am encountering strange artifacts.
http://imgur.com/kWN94
File: http://files.aehunter.net/Sintel/00004554.jp2
Thoughts?
On Thu, Nov 17, 2011 at 1:20 PM, matekm <
<EMAIL_ADDRESS>
wrote:

Ok, I think the plugin is ready, if someone is interested - please compile
code from my repo nad test it (it is synchronized with master). In the
meantime I will add support for writing 10/12 bits images

Reply to this email directly or view it on GitHub:
https://github.com/OpenImageIO/oiio/issues/83#issuecomment-2779675

not sure where the problem is. On my machine it is displayed correctly. What about other files? The same artefacts?

Hey everyone,
It could be a fglrx bug... Hate those buggers!
If it opens fine on yours and other systems, it's definitely a local
problem.
Is anyone else able to test?
On Thu, Nov 17, 2011 at 2:17 PM, matekm <
<EMAIL_ADDRESS>
wrote:

not sure where the problem is. On my machine it is displayed correctly.
What about other files? The same artefacts?

Reply to this email directly or view it on GitHub:
https://github.com/OpenImageIO/oiio/issues/83#issuecomment-2780436

I commited code that writes 10/12 bit images if oiio:BitPerSample is set to 10/12.
Now, one more thing left to support cinema images: parameters. I'm not sure if I should expose all compression/decompresion parameters to the user (opj_cparameters_t is pretty big)? Or maybe there are some presets for this, fe. when user specify jpeg2000:cinema2k I will set parameters in the same way as in OpenDCP. Would it be ok? Or let the user just set all the parameters by himself?

Hey,
openJpeg's command line tools provide command line flags for the parameters
for Cinema2K and Cinema4K. It would great to offer these
as convenience functions for apps using oiio for input and output.
Cheers,
Andrew
On Sat, Dec 17, 2011 at 1:35 PM, matekm <
<EMAIL_ADDRESS>
wrote:

I commited code that writes 10/12 bit images if oiio:BitPerSample is set
to 10/12.
Now, one more thing left to support cinema images: parameters. I'm not
sure if I should expose all compression/decompresion parameters to the user
(opj_cparameters_t is pretty big)? Or maybe there are some presets for
this, fe. when user specify jpeg2000:cinema2k I will set parameters in the
same way as in OpenDCP. Would it be ok? Or let the user just set all the
parameters by himself?

Reply to this email directly or view it on GitHub:
https://github.com/OpenImageIO/oiio/issues/83#issuecomment-3190757

+1 on Cinema2K/4K command-line flags

Yes, I'm also in favor of having special options "jpeg2000:cinema2k" and whatnot that, when nonzero, trigger setting of a bunch of options in a certain way.
Should we review what you have already, or wait for this?

I think I will prepare a pull request in day or two

I think this ticket is ready to close

What ever happened with the Cinema2K/4K part of this discussion?  Was that already committed?

Yes, there are jpeg2000:cinema2k and jpeg2000:cinema4f attributes that set some default attributes for cinema images (as a reference point I used OpenDCP).


Supported aggregations

Sometimes, choosing an aggregation other than the one listed as "Aggregation Type" in the big list of metrics can lead to weird results, like trying to Average something that is intended as a Total or a Count. Can you add some recommendations to this doc about choosing aggregation?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9aeeedc1-d567-f4b1-9913-14f401df8884
Version Independent ID: 324a8bd9-cec9-3be0-b1fb-01e9a0f95710
Content: Create, view and manage Metric Alerts Using Azure Monitor
Content Source: articles/azure-monitor/platform/alerts-metric.md
Service: azure-monitor
Sub-service: alerts
GitHub Login: @snehithm
Microsoft Alias: snmuvva

@dcbrown16 Thanks for your comment. We are actively investigating and will get back to you shortly.

@dcbrown16 This document contains the information of Aggregation Type for each metric that are supported. Can you please let me know if you are looking for any other information that is not included in the document?

@SwathiDhanwada-MSFT I believe you mean this link, which is what I was referring to as the "big list of metrics".
https://docs.microsoft.com/en-us/azure/azure-monitor/platform/metrics-supported
The problem I would like to solve is that that link lists one aggregation type, but you can select any aggregation type you want for any metric, including ones that make no sense. It would be helpful to have a document that describes how you should refer to the link above to find the appropriate aggregation for each metric when creating an alert.
The specific example is that we have a customer looking at "Requests" under API Management. The listed aggregation is Total, and that one works fine, but they were trying to use "Average", where the result is 1 for any minute that had any requests. Using "Average" aggregation for this metric is meaningless, so we need to warn against that sort of thing in the metric creation process.

@msvijayn @snehithm Can you please provide your inputs on this please?

Adding @harelbr who owns metric alerts now.

Hi @dcbrown16 ,
You're correct, this article only specifies the default aggregation type for the metric. There could be additional supported aggregation types for each metric, and if there are ones that aren't applicable, we should remove them. I'll reach out to the relevant team about this.

#please-close


Feature requests, cappuccino icon theme for iterm2

Hi this is a feature request.
I would like have the catppuccing icon themes for iterm2, for example to show the icons on the top with that theme, and not with the standard one like that:

Closing as not planned for now but feel free to re-open if you find any documentation on your feature request being possible, thanks!


improved csv handling.

Have added some quotes to be sure that comma in portal names wont be negative...
Also semicolon to comma for keycount
and of course the csv header.
at least version switched to ...5 , have seen some other forks with ...4

Thanks!


module import in Quarto

Currently, require("bertin") does'nt work in Quarto. The following error is returned: OJS Error. RequireError$1: invalid module. To import bertin, I have to write: bertin = import('https://cdn.skypack.dev/bertin@0.9').  However, require works in Observable. It's weird... See also https://talk.observablehq.com/t/quarto-module-require/6573 & https://stackoverflow.com/questions/72300480/error-quarto-require-invalid-module-bertin-js

Actually, it's very weird. There is an error in rstudio. But when I deploy the page in github (see), the error disappears.

(Quarto dev here) This commit from yesterday addresses a bug in our version of d3-require (which we need for interoperability with imports from ipython's html widgets). Could you upgrade to the latest quarto version and test that? Thanks!

The problem is not solved with quarto 0.9.434 :(

Huh, weird. This is what it looks like for me locally:

Within Rstudio :

It works if I choose "Preview in window". Output in localhost is ok.
It doesn't work if I choose "Preview in Viewer Pane". Cf screenshot above.

Solved : https://github.com/quarto-dev/quarto-cli/issues/943


Edit form with image (avatar)

Hello,
Somebody maybe had same problems in edit forms with images?

i using :
$form->image('avatar')->move('users')->uniqueName();
When i checking in database record is correct saved,
copy and paste it:
http://localhost:8000/images/users/74127a64a8425c922c393a13b973144f.jpeg
to web browser image is showed correct. Any ideas?

In dev version,  laravel-admin upgrade bootstrap-fileinput to v4.3.7,  so you need to upgrade it in the path public/packages/admin/bootstrap-fileinput, the path in vendor is vendor/encore/laravel-admin/assets/bootstrap-fileinput.

It's not working even after files(bootstrap-fileinput to v4.3.7) upgrade.
Also multiple image upload not working:

 $form->image('pictures','Image')->multiple();

Try mutipleImage()
Z-song had changed the function....


Add missing files to the 'documentation' solution folder

[Current coverage][cc-pull] is 96.76%

No coverage report found for master at f044621.

Powered by Codecov. Last updated by [f044621...3def7b1][cc-compare]
[cc-base-branch]: https://codecov.io/gh/DotNetAnalyzers/StyleCopAnalyzers/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/DotNetAnalyzers/StyleCopAnalyzers/compare/f044621cdf4d1acd676d349cdb8aac8473c68bb9...3def7b144a726d3b0dc29139952e005de8f429f3?src=pr
[cc-pull]: https://codecov.io/gh/DotNetAnalyzers/StyleCopAnalyzers/pull/2167?src=pr

:+1:


feat(ESSNTL-4191): inventory groups nav behind feat flag

Task
https://issues.redhat.com/browse/ESSNTL-4191
Sketches
https://www.sketch.com/s/550bd962-ca1f-42d8-8d89-d457527a059a/a/g1Qrn4x

Closing because I have no way to push to this branch.