Scenario: Improved keyboard handling

The Terminal's keyboard input is fundamentally backed by VT sequences, which limits the range of keys that we can actually send relative to what the console was capable of. This megathread is tracking all the issues that might be related to this:

[x] Some keybindings used by PSReadLine aren't getting through #879
[x] Bug Report: Control+Space not sent to terminal emulator. #2865
[x] Shift+Enter always submits, breaking PSReadline features [Windows.Terminal] #530
[x] Powershell: Ctrl-Alt-? does not work in Windows Terminal #3079
[x] Bug: ctrl+break is not ctrl+c #1119
[x] Something wrong with keyboard modifiers processing? #1694
[x] Numeric input not accepted by choice.exe #3608
[ ] Ctrl+Keys that can't be encoded as VT should still fall through as the unmodified character #3483
[x] Modifier keys are not properly propagated to application hosted in Windows Terminal #4334 / #4446
[ ] We may be able to fix the Ctrl+Backspace/Ctrl+H mixup that resulted in #5957.

Before 2.0, we're hoping on adding support for parsing a much broader variety of keys via conpty.
Keys that we definitely need to support, that don't have unique VT sequences:

[x] Ctrl+Space (#879, #2865)
[x] Shift+Enter (#530)
[x] Ctrl+Break (#1119)
[x] Ctrl+Alt+? (#3079)
[x] Ctrl, Alt, Shift,  (without another keydown/up) (#3608, #4334, #4446)

This is a work-in-progress
Potential Solutions:
DECPCTERM
VT100.net doc
Pros:

Enables us to send key-down and key-up keys independently
Enables us to send modifiers on their own
Part of the VT 510 standard

Cons:

neither xterm nor gnome-terminal (VTE) seem to implement this. I'm not sure if anyone's got a reference implementation for us to work with.
Unsure how this would work with other keyboard layouts

this doc seems to list the key-down/up codes for all the en-us keyboard keys, but the scancodes for these are different for up and down. That would seem to imply we couldn't just shove the Win32 scancode in those bits

xterm "Set key modifier options"
Notably looking at modifyOtherKeys.
Pros:

xterm implements this so there's a reference implementation

Cons:

Only sends the sequence on key-up
Doesn't send modifiers all on their own

kitty extension
Reference
TODO
ConEmu INPUT_RECORD extension
TODO - does this even exist? IIRC this was the original plan like, years ago
Things to keep in mind

Would this encoding be mixable with other normal VT processing easily?

How would the Terminal know when it should send a <chosen_encoding> key vs a normally encoded one?

For ex, Ctrl+space - should we send NUL or <chosen_encoding's version of ctrl+space>

If there's a scenario where Windows Terminal might not be connected to a conpty, then how does conpty enable <chosen_encoding>?

Another option to consider is Key Position Mode (DECKPM) which reports the state of the modifier keys along with each key press (see DECEKBD for the actual report format). I don't think it has separate keyup and keydown events, but it does have an option to report modifier keypresses separately (see DECSMKR).

How would the Terminal know when it should send a <chosen_encoding> key vs a normally encoded one?

I assumed this is something the conpty host would initiate on startup, requesting whichever mode (or modes) we decided to support. If the terminal at the other end supported the requested mode, then it would start reporting keypresses in that format.
In some cases, if the key reporting sequences can mean different things in different modes, the host might need to know whether the client had actually accepted the request to use a particular mode. In the case of DECKPM you could determine that by querying the mode state with DECRQM. In the case of DECPCTERM, you could determine whether the client supported the option from the DA1 report.

Thanks for the suggestions @j4james. Those worry me the same way that DECPCTERM does in that there doesn't seem to be any terminal applications that I can use as a reference implementation for them 😕

Those worry me the same way that DECPCTERM does in that there doesn't seem to be any terminal applications that I can use as a reference implementation for them

What about this? https://www.amazon.com/DEC-VT510-TERMINAL/dp/B016YJZYVK 😄
I've actually considered getting one myself, although I don't really have the space for it.
Anyway I'd much prefer implementing an actual standard over any of the proprietary extensions, but I suspect we'll probably end up implementing several of the protocols anyway. I know I would want to add support for the DEC standards even if nobody else does, just because I'd like WT to be a proper terminal emulator. And we'll probably want to do XTerm's modifier extension, because I think there are existing apps that make use of it.
I don't really see the point of coming up with our own proprietary protocol, though, unless it can actually do something that DECPCTERM doesn't. You still don't have a reference implementation, and you've got the additional effort of inventing your own protocol.

this doc seems to list the key-down/up codes for all the en-us keyboard keys, but the scancodes for these are different for up and down. That would seem to imply we couldn't just shove the Win32 scancode in those bits

I haven't really looked at it in much detail, but the impression I got was that the "make" code was a standard scancode, and the "break" code is just the same thing with the high bit set (for the two byte sequences, it'll be the second byte that has the high bit set).

What about this? amazon.com/DEC-VT510-TERMINAL/dp/B016YJZYVK 😄
I've actually considered getting one myself, although I don't really have the space for it.

We can barely convince management to get us high-dpi displays, I doubt I could get that approved 😆

I would want to add support for the DEC standards even if nobody else does, just because I'd like WT to be a proper terminal emulator

I totally agree with this sentiment. I don't disagree that this is a valuable goal to move towards. However, from where I'm sitting looking at these bugs, being a better terminal emulator doesn't actually help us solve them. Being a better console emulator would though.
The way I'm looking at it now is that we can definitely make conhost a better terminal emulator independently of making the Windows Terminal a better console emulator. By letting the Terminal speak <our INPUT_RECORD protocol> to conpty, then conpty can have real INPUT_RECORDs in it's input buffer that Win32 applications will be able to read just the way they like to. Then, conhost is also already good at taking INPUT_RECORDs and turning them into strings of characters for applications that request VT input.

You still don't have a reference implementation, and you've got the additional effort of inventing your own protocol.

Without a reference implementation, I'm kinda inventing my own protocol anyways though, right? 😉 I still hate this about this solution, but the crux of the issue is that there are going to be some legacy Win32 apps out there somewhere that are going to want some piece of information that will only come from an INPUT_RECORD, and only a Win32 solution will work for this.
Maybe there's some future where the Terminal isn't connected to conpty. In that future, the Terminal will still be a better terminal emulator because it shares the same core terminal input translation as conhost does. So doing the INPUT_RECORD path isn't going to back the Terminal into a corner in the future.

but the crux of the issue is that there are going to be some legacy Win32 apps out there somewhere that are going to want some piece of information that will only come from an INPUT_RECORD, and only a Win32 solution will work for this.

Maybe you're right. I was just hoping we'd have a solution where you could connect a standard terminal to the end of a conpty pipe and have it just work. With a proprietary solution that's never going to happen.

See but here's the thing I'm thinking - I think that's going to be just fine still.
The way I'm imagining it right now, when conpty starts up, it's going to ask for some private input mode. As all good terminal emulators should, when they don't understand that sequence, they'll just ignore it. Then they'll send input like they currently do, and conpty will handle it just the same as it can currently. We'll translate the normal sequences the same way we currently do, and everything will work just as well as they currently do.
However, for something that's been updated to support win32-input-mode, like the Terminal, it'll see that private mode sequence and start sending the win32 compatible sequences instead. If other terminals wanted to also adopt this to work better with legacy Windows applications they totally could, but I wouldn't say that this would be horribly important.
Our guidance is still going to be "if you're authoring a commandline application, you should avoid these keyboard shortcuts or use VT input, otherwise your application might not work in all terminals". For things like Hyper, mintty, putty, they're still going to hit this bug unless they're updated. However, regardless of which dialect we chose, they'd hit this bug, since none of them implement some reasonable alternative 😄
I'm just thinking that a win32-specific solution to a win32-specific bug isn't the worst outcome. I do appreciate you keeping me honest though ☺

For things like Hyper, mintty, putty, they're still going to hit this bug unless they're updated. However, regardless of which dialect we chose, they'd hit this bug, since none of them implement some reasonable alternative

Yeah. If I'm being realistic, it really doesn't matter. But I can't help thinking how cool it would have been to hook up a DEC terminal, built nearly 30 years ago, and have it work near perfectly with modern console apps. I means that's essentially what the PCTerm mode was designed for in the first place.
Then you could tell any terminal emulators that want the same level of functionality they'd just need to implement an existing VT protocol. As feature requests go, I suspect that's a lot easier to justify to some people than a proprietary win32-specific protocol.
Anyway, I'm just musing here on what might have been. I do understand your reasons for going the other route.

Hi, I'm just a lurker and not an expert in this area, but when I saw this task I immediately thought of libtermkey/libtickit and their author who's been trying to improve terminal keyboard input for a long time: http://www.leonerd.org.uk/hacks/fixterms/ Maybe this could give you some ideas.

As of 6b2d95264

[x] Some keybindings used by PSReadLine aren't getting through #879

[x] Ctrl+Backspace (BackwardKillWord)

✔ already works in 1.0

[x] Shift+Ctrl+Enter (InsertLineBelow)

🎉 This is a new fix! 🎉

[x] Ctrl+Space (MenuComplete)

✔ already works in 1.0

[x] Shift+Tab (TabCompletePrevious)

✔ already works in 1.0

[x] Alt+0 (DigitArgument) (and other digits)

✔ already works in 1.0

[ ] PageDown (ScrollDisplayDown)

⚠ Not sure this is even possible with conpty at all, though this can be bound directly in the Terminal

[ ] Ctrl+PageDown (ScrollDisplayDownLine)

⚠ Not sure this is even possible with conpty at all, though this can be bound directly in the Terminal

[ ] PageUp (ScrollDisplayUp)

⚠ Not sure this is even possible with conpty at all, though this can be bound directly in the Terminal

[ ] Ctrl+PageUp (ScrollDisplayUpLine)

⚠ Not sure this is even possible with conpty at all, though this can be bound directly in the Terminal

[x] Ctrl+Alt+? (ShowKeyBindings)
[x] Alt+? (WhatIsKey)

✔ already works in 1.0

[x] Bug Report: Control+Space not sent to terminal emulator. #2865

✔ already works in 1.0

[x] 🎉 Shift+Enter always submits, breaking PSReadline features [Windows.Terminal] #530
[x] 🎉 Powershell: Ctrl-Alt-? does not work in Windows Terminal #3079
[ ] Bug: ctrl+break is not ctrl+c #1119

Pause/Break now works in this scenario to pause the ping output
❌ Ctrl+C STOPPED working!

[x] 🎉 Something wrong with keyboard modifiers processing? #1694
[x] 🎉 Numeric input not accepted by choice.exe #3608
[ ] Ctrl+Keys that can't be encoded as VT should still fall through as the unmodified character #3483

Okay this one's different. For this one, if a Ctrl+char hits the normal VT translation path, and that char is in (0x20,0x3f]|[0x60,0x7e], then we should just send that char

[x] 🎉 Modifier keys are not properly propagated to application hosted in Windows Terminal #4334 / #4446

I came from #5957.
I found other different key codes.
ctrl+J -> ^Q == LF -> DC1
ctrl+? -> ^_ == DEL -> US

With #6309 merged, I'm closing this issue out. #3483 and #5957 were both bugs that can be solved on their own, and weren't really a part of this scenario.

To simplify implementation of win32-input-mode in terminals on platforms other than Windows, I wrote a small library that translates X11/Wayland XKB key syms into Windows key codes. There is also a demo application that prints win32-input-mode escape sequences based on X11 input events. I hope this will help those who want to add support for the win32-input-mode to their terminals designed for platforms other than Windows.
https://github.com/unxed/xkb2win

eee... mm.. so where's the protocol description? how do i parse it without any description

Here's the spec: https://github.com/microsoft/terminal/blob/main/doc/specs/%234999 - Improved keyboard handling in Conpty.md

notes

it's not INPUT_RECORD, its KEY_RECORD, INPUT_RECORD includes MOUSE_RECORD and others
same negligence for parsers as in kitty's design. querying must come first. what will happen with 9001$p ?
who needs scancodes?
repeat and keyup / keydown may be transferred as a single value
char codepoint may be the length of utf8 bytes that follow

here's my recent take on this topic ... (im really lost in these github interfaces with thousands of links etc, no centralized chat or somehting.. so lost it)
i think one more possible scenario will be moving from ReadConsoleInput to generic ReadFile bytes like in *nix systems..

FYI: kitty protocol escape sequences generation from Windows compatible Key Event Record, public domain.
https://github.com/microsoft/terminal/issues/11509#issuecomment-2308421220


GOAT algorithm

Hello!
In this PR I implemented the graph alignment algorithm 3 of this paper.

closing PR because obsolete, see new one #11


[Swift2.0] Missing return in a closure expected to return 'AnyPromise'

This is working
        basicDelegate!.signUp(_PSRegisterData).then { result in
            self.afterSignUpSucceed()
        }

This is not and got Missing return in a closure expected to return 'AnyPromise'
        basicDelegate!.signUp(_PSRegisterData).then { result in
            if result {
                self.afterSignUpSucceed()
            } else {
                self.afterSignUpFailed()
            }
        }

I think I missing something here, Any hint?

Swift bug. This probably is the solution:
        basicDelegate!.signUp(_PSRegisterData).then { result -> Void in
            if result {
                self.afterSignUpSucceed()
            } else {
                self.afterSignUpFailed()
            }
        }

@mxcl Thanks for workaround, working like charm! :D

FFR, this is because Swift was confused about which then to pick (it shouldn't have been). They will fix this or improve the error message, but this category of compile errors will always be around.

The first question at the FAQ is also relevant: http://promisekit.org/faq/


Repo not including 24.1 plug-ins

New repo not including 24.1 plug-ins?

Thanks for your reminder. I've uploaded it now, please check.


Transition to Micro

To make the personalized routes we use express we can change it to micro.js, it should not be so complicated to make this change 😸

@timothyis If you want I can take care of that task 😸

Duplicate of #20


Add extra bot exclusion, and avoid infinite loop

Checklist

[ ] npm test passes
[ ] documentation is changed or added (if applicable)
[ ] permission has been obtained to add new logo (if applicable)
[ ] contribution guidelines followed here

@tellison - Is this ready for review?


My personal tmux aliases

My personal Tmux (terminal multiplexer) aliases for named sessions.
Hope it helps somebody.

@nwinkler Yes, you are right. i wasn't sure, but there is no reason for it be different

Looks great now - thanks!


Update to latest mypy

Looks like there are some typescript test failing

@anthonykim1 It should be fixed now


Publich eta-vscode on open-vsx

Is your feature request related to a problem? Please describe.
I am using an instance of cdr/code-server. Legally, they cannot use the microsoft extension marketplace. So they use alternatives such as https://open-vsx.org/. It would be really nice if the eta-vscode extension could be published there too.
Describe the solution you'd like
I would like the eta-vscode vscode extension to be published on https://open-vsx.org/
Describe alternatives you've considered
Using EJS as they have an extension on open-vsx
Additional context
I would rather use ETA because of the speed claims

@AurangAsif Sorry for the late repy, but can you make this issue in the eta-vscode repository instead?
shadowtime2000/eta-vscode


feat: project_id as property

For now it is just configured, I will push the implementation all over the code-base on this branch only.

fix: #123

ToDo's

For me(@OmAximani0) only as checklist. @andrii-bodnar You can add things that should be implemented with this PR

[ ] project_id as optional param for all API resources
[ ] Add test for client and other API resources
[ ] Update README.md

Codecov Report

Merging #129 (93fc454) into main (00d0ff2) will decrease coverage by 0.03%.
The diff coverage is 96.62%.

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
- Coverage   99.19%   99.16%   -0.03%
==========================================
  Files         146      146
  Lines        5056     5064       +8
  Branches      710      711       +1
==========================================
+ Hits         5015     5021       +6
- Misses         29       30       +1
- Partials       12       13       +1

Files
Coverage Δ

...api/api_resources/abstract/tests/test_resources.py
100.00% <100.00%> (ø)

..._resources/bundles/tests/test_bundles_resources.py
100.00% <100.00%> (ø)

.../dictionaries/tests/test_dictionaries_resources.py
100.00% <100.00%> (ø)

...istributions/tests/test_distributions_resources.py
100.00% <100.00%> (ø)

...rces/glossaries/tests/test_glossaries_resources.py
100.00% <100.00%> (ø)

...pi_resources/groups/tests/test_groups_resources.py
100.00% <100.00%> (ø)

...pi_resources/labels/tests/test_labels_resources.py
100.00% <100.00%> (ø)

...ources/languages/tests/test_languages_resources.py
100.00% <100.00%> (ø)

...ests/test_machine_translation_engines_resources.py
100.00% <100.00%> (ø)

...notifications/tests/test_notification_resources.py
100.00% <100.00%> (ø)

... and 22 more

@andrii-bodnar Please checkout these changes and I have not done changes in tests but the builds are passing please suggest changes according

@andrii-bodnar Please checkout below resources in which I have made the changes according to previous changes suggested and please inform me that can I change all the other API resources according to these below resources?

dictionaries
distributions

@OmAximani0 this looks good to me. The only thing I'd suggest changing is:
projectId = projectId if projectId else self.get_project_id()

can be simplified:
projectId = projectId or self.get_project_id()

@OmAximani0 this looks good to me. The only thing I'd suggest changing is:
projectId = projectId if projectId else self.get_project_id()

can be simplified:
projectId = projectId or self.get_project_id()

@andrii-bodnar Fine then, I'll implement the line as you suggested and I'll also change the other API resources according to it 👍


[6.4.x] Documentation for QueryService and UpdateTimer on running process instance

@ibek could you please take a look as you were involved in testing both jiras

jenkins retest this

@mswiderski except few typos, the documentation is well written and the code samples are great.

@ibek thanks, updated based on your comments.

merged into 6.4.x


[Bug] Some Unit and UI Tests have failed

Issue
Currently, some Unit and UI tests have failed.

Expected
It's expected that all tests should be passed.
Steps to reproduce

Open the project with Xcode.
Run all tests.

Refactor all unit tests done


More accurate transport controls in sequences

Currently, trying to time events accurately to music is tricky, as it's very hard to correctly place the playhead.

Add hotkeys that move the playhead by set time intervals (e.g. 100ms, 500ms, 1s)
Add a way to manually enter a timestamp to place the playhead, e.g. by double clicking the timeline legend.
Preview the sound while moving the playhead/scrubbing the timeline in a sequence, as e.g. Premiere or DAW software allow you to.
Snap the playhead to beats or measures while holding a certain hotkey. This would depend on a preconfigured BPM/beat level value, maybe even an event that signals changes in these values - this would be especially useful for music that changes in BPM. Measures could be visualized by vertical lines in the sequence panel. If a BPM/level is configured, hotkeys could be added that move the playhead between beats.

These features will make it far easier to create timelines that need to sync up to music accurately.

As one who hasn't used apps with timelines quite a lot, what would your ideal keybinds for moving the playhead be?


Remove Welcome Voice and Notification

We need to remove the "Welcome to chatApp, Instant messaging at your service" voice, since it is not necessary. This also includes the notification sounds. Remove any code belonging to this feature, including the mp3 files.
Check out this function here, and other similar functions in client.js , and remove any code that plays sound.
https://github.com/osPrims/chatApp/blob/f612192999d6722bff509b055eaaf8a829e0dd00/public/client.js#L126
There are some more instances of playSound() here.

Hello, I would work on this issue.

Hi @KossakowskaKarolina , we're reserving all good first issues for absolute beginners, who have little to no experience in web dev. You can checkout our other non goodfirstissues :D

I absolutely understand, that's why I've been looking for that kind of issues :) Trying to do my first contibution. I'll give another one a try.

The other issues might not be that tough, for example a good dark mode UI would be nice to have :D

I want to work on this, Assign it to me :)

Hello, I would like to make a contribution to this issue.

Hey @Ocidemus , thanks for showing interest in this, assigning this to you!


Fix session token from extra config

when AWS secrete and access key is passed via the connection UI field the session token is not considered, when it is passed via extra config it is considered
closes: #725

@rajaths010494 @pankajastro @phanikumv can you review this PR


Broken link to machine learning open source resources

Hello - the page link leads to a 404: https://docs.microsoft.com/EN-US/azure/machine-learning/concept-open-source
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 16ab4665-2ea9-5312-e107-28d8d7e2a111
Version Independent ID: 4f862540-1c4f-5b03-a61a-42026ef3b00f
Content: What is Azure Machine Learning? - Azure Machine Learning
Content Source: articles/machine-learning/overview-what-is-azure-machine-learning.md
Service: machine-learning
Sub-service: core
GitHub Login: @sdgilley
Microsoft Alias: sgilley

This has been fixed. Thanks for fixing this, sdgilley.
Thanks for taking time to bringing this to our attention, mmonsma.


feat: Reconcile argocd-repo-server-tls volume mounts

What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
Argo CD v2.0 introduced a Secret mount for a TLS secret named argocd-repo-server-tls. This secret can be used to specify the TLS certificate used by the repo server's gRPC endpoint. It must be made available to the workloads of the server, application controller and the repo server itself.
This PR adds reconciliation logic for adding the required volume mounts.
The next step will be to provide configuration to request this TLS from OpenShift service CA.
Have you updated the necessary documentation?

[ ] Documentation update is required by this PR.
[ ] Documentation has been updated.

Which issue(s) this PR fixes:
Fixes #288
How to test changes / Special notes to the reviewer:

Do you mind fiill in "how to test" section?

Sure @wtam2018 - updated the description.
There's not much to test, just check whether the volumes have been correctly setup to the workloads.


Automated Package Upgrade

:tada: This PR is included in version 2.2.417 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


google.api_core.exceptions.PermissionDenied: 403 IAM permission 'dialogflow.sessions.detectIntent' on 'projects/None/agent' denied.

Facing this error while trying a customised frontend client Flask for dialogflow!

Here's the code!
# /index.py
from flask import Flask, request, jsonify, render_template
import os
import dialogflow
import requests
import json
import pusher

pusher_client = pusher.Pusher(
        app_id=os.getenv('PUSHER_APP_ID'),
        key=os.getenv('PUSHER_KEY'),
        secret=os.getenv('PUSHER_SECRET'),
        cluster=os.getenv('PUSHER_CLUSTER'),
        ssl=True)

final = []
app = Flask(__name__)

@app.route('/')
def index():
    return render_template('index.html')

@app.route('/webhook', methods=['POST'])
def static_reply():
    string = "Hello there, this reply is from the webhook !! "
    my_result =  {"fulfillmentText": string, "source": string}
    return jsonify(my_result)
def detect_intent_texts(project_id, session_id, text, language_code):
    session_client = dialogflow.SessionsClient()
    session = session_client.session_path(project_id, session_id)

    if text:
        text_input = dialogflow.types.TextInput(
            text=text, language_code=language_code)
        query_input = dialogflow.types.QueryInput(text=text_input)
        response = session_client.detect_intent(
            session=session, query_input=query_input)

        return response.query_result.fulfillment_text

@app.route('/send_message', methods=['POST'])
def send_message():
    try:
        socketId = request.form['socketId']
    except KeyError:
        socketId = ''

    message = request.form['message']
    project_id = os.getenv('virtual-police-pmrtai')
    fulfillment_text = detect_intent_texts(project_id,, message, 'en')
    response_text = { "message":  fulfillment_text }

    pusher_client.trigger(
        'Virtual-Police',
        'new_message',
        {
            'human_message': message,
            'bot_message': fulfillment_text,
        },
        socketId
    )

    return jsonify(response_text)
# run Flask app
if __name__ == "__main__":
    app.run()

complete error statement -
<IP_ADDRESS> - - [16/Mar/2020 13:05:03] "POST /send_message HTTP/1.1" 500 -
Traceback (most recent call last):
  File "C:\Users\Shreya\Anaconda3\lib\site-packages\google\api_core\grpc_helpers.py", line 57, in error_remapped_callable
    return callable_(*args, **kwargs)
  File "C:\Users\Shreya\Anaconda3\lib\site-packages\grpc\_channel.py", line 565, in __call__
    return _end_unary_response_blocking(state, call, False, None)
  File "C:\Users\Shreya\Anaconda3\lib\site-packages\grpc\_channel.py", line 467, in _end_unary_response_blocking
    raise _Rendezvous(state, None, None, deadline)
grpc._channel._Rendezvous: <_Rendezvous of RPC that terminated with:
        status = StatusCode.PERMISSION_DENIED
        details = "IAM permission 'dialogflow.sessions.detectIntent' on 'projects/None/agent' denied."
        debug_error_string = "{"created":"@1584344103.812000000","description":"Error received from peer ipv4:<IP_ADDRESS>:443","file":"src/core/lib/surface/call.cc","file_line":1052,"grpc_message":"IAM permission 'dialogflow.sessions.detectIntent' on 'projects/None/agent' denied.","grpc_status":7}"
>

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "C:\Users\Shreya\Anaconda3\lib\site-packages\flask\app.py", line 2463, in __call__
    return self.wsgi_app(environ, start_response)
  File "C:\Users\Shreya\Anaconda3\lib\site-packages\flask\app.py", line 2449, in wsgi_app
    response = self.handle_exception(e)
  File "C:\Users\Shreya\Anaconda3\lib\site-packages\flask\app.py", line 1866, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "C:\Users\Shreya\Anaconda3\lib\site-packages\flask\_compat.py", line 39, in reraise
    raise value
  File "C:\Users\Shreya\Anaconda3\lib\site-packages\flask\app.py", line 2446, in wsgi_app
    response = self.full_dispatch_request()
  File "C:\Users\Shreya\Anaconda3\lib\site-packages\flask\app.py", line 1951, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "C:\Users\Shreya\Anaconda3\lib\site-packages\flask\app.py", line 1820, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "C:\Users\Shreya\Anaconda3\lib\site-packages\flask\_compat.py", line 39, in reraise
    raise value
  File "C:\Users\Shreya\Anaconda3\lib\site-packages\flask\app.py", line 1949, in full_dispatch_request
    rv = self.dispatch_request()
  File "C:\Users\Shreya\Anaconda3\lib\site-packages\flask\app.py", line 1935, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "C:\Users\Shreya\Desktop\Virtual_cop\index.py", line 53, in send_message
    fulfillment_text = detect_intent_texts(project_id, "unique", message, 'en')
  File "C:\Users\Shreya\Desktop\Virtual_cop\index.py", line 39, in detect_intent_texts
    session=session, query_input=query_input)
  File "C:\Users\Shreya\Anaconda3\lib\site-packages\dialogflow_v2\gapic\sessions_client.py", line 323, in detect_intent
    request, retry=retry, timeout=timeout, metadata=metadata
  File "C:\Users\Shreya\Anaconda3\lib\site-packages\google\api_core\gapic_v1\method.py", line 143, in __call__
    return wrapped_func(*args, **kwargs)
  File "C:\Users\Shreya\Anaconda3\lib\site-packages\google\api_core\retry.py", line 286, in retry_wrapped_func
    on_error=on_error,
  File "C:\Users\Shreya\Anaconda3\lib\site-packages\google\api_core\retry.py", line 184, in retry_target
    return target()
  File "C:\Users\Shreya\Anaconda3\lib\site-packages\google\api_core\timeout.py", line 214, in func_with_timeout
    return func(*args, **kwargs)
  File "C:\Users\Shreya\Anaconda3\lib\site-packages\google\api_core\grpc_helpers.py", line 59, in error_remapped_callable
    six.raise_from(exceptions.from_grpc_error(exc), exc)
  File "<string>", line 3, in raise_from
    # Permission is hereby granted, free of charge, to any person obtaining a copy
google.api_core.exceptions.PermissionDenied: 403 IAM permission 'dialogflow.sessions.detectIntent' on 'projects/None/agent' denied.

Question: did you redact the project-id or is it actually None?
How do you configure auth? Environment variable to you Service Account's JSON key?

I had the same issue, which was solved by exporting the GOOGLE_APPLICATION_CREDENTIALS to my python script:

export GOOGLE_APPLICATION_CREDENTIALS='path/to/google-credentials.json'
python bot.py

I also tested without exporting the env var and instead, from within my python script

import os
...
os.environ['GOOGLE_APPLICATION_CREDENTIALS'] = './google-credentials.json'

it works as well. (in a new shell)
So  GOOGLE_APPLICATION_CREDENTIALS env var must be set to the right file one way or another.

@nnegrey I have tried to use both the env var and the json file, doesn't work. Service account is set to Owner as directed in the docs.


Its Stuck at Genrating Video

a google colab notebook will be more helpfull if possible thank you.

Hey @enterprisium
It does take some time to finish based on your internet speed for downloading the assets and your computer hardware for rendering. You can check the logs on your terminal for more information.
If there is some issue it will popup an alert with the error and you should hit generate again. I'm still working on resolving all issues.
Also, make sure you have followed the setup explained on the README.md file and you need both the backend server and the frontend running.

Thanks brother I just realised that it's a fork of Moneyprinter and your version is different then that. I have a quick question if you don't mind. Do your version support auto uploading to youtube or tiktok?

No, not yet. I'm planning to add it soon.

Okiee please have a look at ShortGPT project that may help you in ur project

Wow, I didn't know about this project. I'll only create an auto-uploader for Insta and Shorts then lol. Thanks for the info! :)

well i have shortgpt auto youtube uploader as well as auto upload scadular and there are many other projects that may take your journey to the next level lol

Wow, I didn't know about this project. I'll only create an auto-uploader for Insta and Shorts then lol. Thanks for the info! :)

any update?

I am still working on it. For Instagram I use Instagrapi, and it's excellent.

i need your help in modefying ShortGPT. since ShortGPT uses OPENAI API so it cost us money after sometime when free tire ends. i can see your work is amazing! and i dont see so much diffrance in your Modefied version and the ShortGPT Version. can you please make an another verion of shortGPT ? as it yhe best one that i ever used and with alot of features. so can you replace OPENAI API with G$F?


Support for the R language

Support for the R language

Added R implementations for operator and programming actions.
Added list of R functions and libraries.
Libraries can now also be seen in a GUIi window and entered with commands the same way as functions.
Added general actions for break, next, true, false, and NA.
Added action for the operator "is in". In R this checks if the element is in a vector, it could appear in other languages.
Showing function list will close library list and viceversa.

The R functions and libraries were taken from mrob95 (https://github.com/mrob95/MR-talon.git).

I left the user.code_private_function action commented out because I don't know how to modify the ^funky <user.text> command so that it works for both Python and R. Functions in R are created like this: foo <- function(arg1, arg2) {}. Maybe the funky command should be defined by each programming language separately?

I took a crack at the discussed tweaks + a first pass of R functions. I don't know R at all, so bear that it mind!
Looking at the R snippet format though
https://support.rstudio.com/hc/en-us/articles/204463668-Code-Snippets
...
Somewhat aside:
you might be well-served by using snippets similar to what I'm doing for VSCode for functions and such -- for tab stops. I watch the user snippet folder + parse on load. It's disabled by default, but snippet_watcher.py and csharp.py might serve as inspiration.


Stubs don't behave correctly with augmented options

Version
1.0.0-beta.29
Reproduction link
https://codepen.io/strutcode/pen/YoGXeW?editors=0010
Steps to reproduce
View the console output
What is expected?
In the console:
Permissions in component-a: some other value
Permissions in component-b: some value

The global mixin should be called with the original component's options
What is actually happening?
In the console:
Permissions in undefined: undefined
Permissions in component-a: some other value
Permissions in component-b: undefined

The mixin is called three times in spite of only two components being in use. The options passed to the stub mixin are filtered unnecessarily.

The code base I'm currently working on uses a global mixin that provides a new option for components, but the stubbing functionality of shallowMount is filtering the component options here:
https://github.com/vuejs/vue-test-utils/blob/dev/packages/create-instance/create-component-stubs.js#L37
Is there a purpose to that function? It's causing a considerable number of issues for me in testing.

https://github.com/vuejs/vue-test-utils/issues/1564#issuecomment-1424857260


not working.... help me

hello~ my friend!
is not working.....

I need code intellisence ...
but do not working...
what should i do??

The same problem，cannot  Jump to the definition when using the C_BattleNet function, but can jump to the definition  when using the UIParent

Sorry for not responding, this should be fixed in v0.9.11 thanks to #101


dag action fails trying to import from another file in dag folder

tests/dags/shared_var.py contains CONSTANTS that is used by multiple dags within the dag root AIRFLOW__CORE__DAGS_FOLDER, but dag-action fails
dag_validation.py:25: AssertionError
------------------------------ Captured log call -------------------------------
INFO     root:dag_validation.py:18 DAGs dir : tests/dags
INFO     airflow.models.dagbag.DagBag:dagbag.py:500 Filling up the DagBag from tests/dags
ERROR    airflow.models.dagbag.DagBag:dagbag.py:334 Failed to import: tests/dags/test_dag.py
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/airflow/models/dagbag.py", line 331, in _load_modules_from_file
    loader.exec_module(new_module)
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "tests/dags/test_dag.py", line 8, in <module>
    from shared_var import image
ModuleNotFoundError: No module named 'shared_var'

This issue has been added to this release v2.2


datastore: datastore/example_test.go example functions return 401 invalid credentials

This example function returns a 401 invalid credentials error when run on a Google Compute Engine instance running in a project that has the datastore API enabled and a JSON key generated.
func Example_auth() *datastore.Client {
    // Initialize an authorized context with Google Developers Console
    // JSON key. Read the google package examples to learn more about
    // different authorization flows you can use.
    // http://godoc.org/golang.org/x/oauth2/google
    jsonKey, err := ioutil.ReadFile("/path/to/json/keyfile.json")
    if err != nil {
        log.Fatal(err)
    }
    conf, err := google.JWTConfigFromJSON(
        jsonKey,
        datastore.ScopeDatastore,
        datastore.ScopeUserEmail,
    )
    if err != nil {
        log.Fatal(err)
    }
    ctx := context.Background()
    client, err := datastore.NewClient(ctx, "project-id", cloud.WithTokenSource(conf.TokenSource(ctx)))
    if err != nil {
        log.Fatal(err)
    }
    // Use the client (see other examples).
    return client
}

I have a similar problem. I run it from managed VM using the default credential.

I solved my problem. It was caused I didn't run gcloud init for the user I run my job (only did that for my own account). It would be nice if the code could print some useful info for such cases.

i have the same problem but i suspect it's because the key i'm using belongs to a service account that doesn't have Editor permissions

@andrewwatson assuming you're right and closing this.


feat: add samples for Datastore Admin

These tests take ~15 minutes to execute.

@bshaffer these tests are reliably passing locally against multiple projects, and failing reliably on kokoro against multiple projects. Is there perhaps something I'm missing with the configuration of the kokoro projects?

I believe the cause of the problem is when tested on projects using "Datastore Legacy", the operation to create the index pass, but when tested on projects using "Firestore in Datastore Mode", the tests fail.


Rename repo to dcos-terraform

to have the same name convention as other repos e.g. https://github.com/dcos-labs/dcos-ansible

gotcha, thanks


Added docs for the bulk loading feature

Added the docs, and added them to the ToC in the Deployment section of the Administrator's Guide.
Note that the doc is modular. That is, there are four files for one doc. To see how the doc looks in it's entirety, see https://jeffschering.github.io/mmdocs/bulk-loading/deployment/bulk-loading.html

@grundleborg Thanks! I made the updates. Let me know how they look.


Extended AppWindow titlebar top border not visible on Windows 10

Describe the bug
When having a custom titlebar using ExtendsContentIntoTitleBar the top border of the app will dissapear.
Steps to reproduce the bug

Create an empty project
Configure the titlebar

public MainWindow()
{
     AppWindow.TitleBar.ExtendsContentIntoTitleBar = true;
}

Run the app

Expected behavior
I would expect to see the top border, same way we can see it when using MainWindow.ExtendsContentIntoTitleBar.
Now that the API is supported on Windows 10 too, it should work as it's not a compatibility problem anymore.
Screenshots

This is how it looks on Windows 10.

This is how it looks on Windows 11.
NuGet package version
Windows App SDK 1.3 Experimental 1: 1.3.230202101-experimental1
Packaging type
Packaged (MSIX)
Windows version
Windows 10 version 21H2 (19044, November 2021 Update)
IDE
Visual Studio 2022
Additional context
This issue is in  WinAppSdk 1.2 as well.

Many windowing frameworks have this problem as well. It is because the border is created by the non-client area frame. The left, right, and bottom edges of the window are extended non-client areas created during the processing of WM_NCCALCSIZE. The top border is an extended frame using DwmExtendFrameIntoClientArea or may not have an extended frame. Either way, on Windows 10 extended frames do not have a border line. You need to draw it in manually like ApplicationFrameHost which draws UWP windows does.

This is not an excuse of winui3 not handling it well (I believe winui team could just handle it in the window proc to draw that row of pixels and not affecting 99.9% of the scenarios, like who would ever put controls in that top 1px) and definitely not an excuse of throwing the responsibility to us developers. The winui3 gallery is supposed to be a demo and a reference, but now all we have
is this obtrusive bug.

Related to #6901


refactor(pie-tag): DSW-2467 update variant names (breaking change)

Describe your changes (can list changeset entries if preferable)
[Updated] - (Breaking change) rename the following variants:
- blue to information
- green to success
- red to error
- yellow to brand-05
- brand to brand-02
📓 docs will updated later in DSW-2324
Author Checklist (complete before requesting a review)

[x] I have performed a self-review of my code
[x] I have reviewed the PIE Storybook/PIE Docs PR preview
[x] I have reviewed visual test updates properly before approving
[x] If changes will affect consumers of the package, I have created a changeset entry.
[x] If a changeset file has been created, I have used the /snapit functionality to test my changes in a consuming application

Reviewer checklists (complete before approving)
Reviewer 1

[ ] I have reviewed the PIE Storybook/PIE Docs PR preview
[ ] If there are visual test updates, I have reviewed them

Reviewer 2

[ ] I have reviewed the PIE Storybook/PIE Docs PR preview
[ ] If there are visual test updates, I have reviewed them

/snapit


Prevent possible rocksdb-corruption by running benchmark-storage

Also adds a sanitize_key function to strip path-prefixes from the db-keys (for databases that
use prefixed keys such as rocksdb)
Questions:

[ ] How does this interfere with the benchmark warmup procedure?
[ ] Do we need a test that artificially generates a collision and check if this avoids corruption?
[ ] Does sanitize_key need a test?

fixes #10998
polkadot address: 1ZApdbwrNnT1Hey4xeTAH6SZPDgbA9ZVftNuu9jTRbkc2Bg

bot merge

@hirschenberger do you want a tip for this PR? please add your information to the top

Why not, gracias 😀

/tip small
de nada

/tip small

/tip small

hmm something wrong, looking into it

The bot is out of tips for me this month 🙈

^ well there you go :)


Add source to users model

Because there are multiple ways to create users, it would be nice to track the source of how users are coming to the system.  This task would add a source``string column to the User model and set it if the user is added by api, email, registration, admin_invite, ticket_form, widget etc.
This source should be added to the user entity.

Would an enum be a better way to store this data?

It could be, but the column is more for a logging purpose- so don't expect to need any kind of manipulation or querying based on this.  Also, I imagine people may want to add their own sources when adding users by API (from an app for example), which makes enums not suitable.


Any word inside a class, struct or enum without the keyword func is considered as FunctionDecl

Why when we type any word inside a class, struct or enum without the keyword func is considered as FunctionDecl?
///Bug
class MyClass {
  word1 //FunctionDecl
}

enum MyEnum {
  word2 //FunctionDecl
}

struct MyStruct {
  word3 //FunctionDecl
}

///Normal:
class MyClass {
  func word1 //FunctionDecl
}

enum MyEnum {
  func word2 //FunctionDecl
}

struct MyStruct {
  func word3 //FunctionDecl
}

I transferred this to swift-syntax, since it's a parser question.

Tracked in Apple’s issue tracker as rdar://114559579

This is the parser recovery kicking in. We want to represent the code as something and we judge that a function declaration is the most likely, since functions are the most comment members of a type. What would you have expected?

This is the parser recovery kicking in. We want to represent the code as something and we judge that a function declaration is the most likely, since functions are the most comment members of a type. What would you have expected?

I think that just writing the word should not give priority to any possibility, until there are some conditions that support this possibility, such as the presence of one parenthese after the word or the presence of the func keyword before it. Until these conditions exist, it can be considered as an UnknownExpr.
From here let me ask the same question to the word we write outside of class, structure or enumeration. Why is it considered an IdentifierExpr and not a FunctionDecl?

I think that just writing the word should not give priority to any possibility, until there are some conditions that support this possibility, such as the presence of one parenthese after the word or the presence of the func keyword before it. Until these conditions exist, it can be considered as an UnknownExpr.

OK, I see a point that we should parse this as MissingDeclSyntax, making word1 an unexpected token within that node.

From here let me ask the same question to the word we write outside of class, structure or enumeration. Why is it considered an IdentifierExpr and not a FunctionDecl?

That’s because a word at the top level of a function is actually syntactically valid if you file allows top-level code. For example
let someWord = 1
someWord

is a valid Swift program.

@ahoppen
I thought this was interesting and tried to resolve some of the concerns in this issue here: https://github.com/apple/swift-syntax/pull/2149
It basically eliminates the problem in this issue, and only parses a declaration with function-related tokens as FuncDecl.
Would changing the current parser behavior and the diagnostics produced be an okay-direction to go?
I think the change in the PR would be more acceptable if it comes with better diagnostics that suggest an addition of func or var, but what do you think?

Done in https://github.com/apple/swift-syntax/pull/2149.


[WIP] Enforce call order for session/background activity state transition

Goal
Enforces a specific call order for the session/background activity state transition. Previously we prioritised the session service but were not prioritising the background activity service.
The existing behavior almost certainly led to subtle bugs. As an example, the background activity service sets a session ID on the MetadataService. If this was called in the wrong order then events/logs could have the wrong session ID towards the end of a session.
Testing
Added unit test coverage.

Converting to a draft - there are some functional test failures here around rejected executions that I need to dig into further.

Updated changeset to unregister the lifecycle callbacks, as this was failing the tests in a subtle way (by throwing RejectedExecutionException when the previous EmbraceImpl in BaseTest was shutdown).

Functional tests doing their job!


Using "plain" encoding for program source does not seem to work

Problem description
Creating a VM with a program source sent as a "plain" encoded file does not seem to work.
How to reproduce :
Create two program with the exact same source. For one of the program use "zip" or "squashfs" encoding, and for the other "plain". The one with the plain encoding will fail, and an HTTP 500 error will be issued.
Additional reference
https://github.com/aleph-im/front-aleph-cloud-page/pull/76

The entrypoint provided by the web console was invalid, hence causing the issue. Nothing to fix on the backend.


Error when loading Angular from CDN from web part on a classic page

Category

[ ] Question
[ ] Typo
[x] Bug
[ ] Enhancement / Suggestion
[ ] Additional article idea

Expected or Desired Behavior
Web part should be able to load Angular from CDN both in the local workbench as well as on a classic page.
Observed Behavior
When trying to load Angular from CDN in a web part placed on a classic page, the following error occurs:
VM8010:4 Uncaught (in promise) Error: Error: https://spoppe-a.akamaihd.net/files/angular did not call System.register or AMD define. If loading a global module configure the global name via the meta exports property for script injection support.(…)

The same web part loaded in the local workbench works correctly. Angular is defined as an external resource using:
"angular": {
  "path": "https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.5.8/angular.min.js",
  "globalName": "angular"
}

Steps to Reproduce

create new web part
reference Angular as external resource
run $ gulp package-solution and deploy .spapp to app catalog in the dev tenant
run $ gulp serve --nobrowser
add web part to a classic page > error occurs

Is there a current work around for this?

sorry guys didn't realize that a temp fix is as simple as not include the angular reference in the externals object of the config.json

Closing this.

Why are you closing this issue @patmill?

From the comments, it sounded like a) an issue with Angular and b) that there was a simple workaround.  Is that not the case?

@davidhartman mentioned in his comment that he found a temporary fix rather than a robust solution to the problem. If we're to build web parts that work both with classic and modern UI, then we have to have a reliable way of loading scripts.
This issue is quite old and has been sitting here for a while without a response. I suggest, that we verify if it's still applicable and handle it accordingly rather than closing without any further comments.

I've just tested this issue with SPFx generator v1.3.2 and while the error has changed, the issue is still there: if you declaratively reference AngularJS, the web part doesn't work on classic pages.
Here is the issue surface:
v1.3

local workbench: ok
hosted workbench: ok
modern page: ok
classic page: error

v1.1

local workbench: ok
hosted workbench: ok
modern page: ok
classic page: error

Repro steps:

create new web part
reference AngularJS as external resource
in the web part add a reference to AngularJS using import * as angular from 'angular';
in the web part change the render method to:

  public render(): void {
    this.domElement.innerHTML = `

              Welcome to SharePoint!

Customize SharePoint experiences using Web Parts.

${escape(this.properties.description)}

{{::vm.msg}}

                Learn more

`;

      if (this.renderedOnce === false) {
        angular.module('app', [])
          .controller('MainController', function() {
            this.msg = 'Hello from ng';
          });
        angular.bootstrap(this.domElement, ['app']);
      }
  }

run $ gulp package-solution and deploy .sppkg to app catalog
run $ gulp serve --nobrowser
add web part to a classic page > error occurs

Uncaught (in promise) TypeError: angular.module is not a function
    at HelloWorldWebPartWebPart.render (HelloWorldWebPart.ts:38)
    at HelloWorldWebPartWebPart.t._renderWithAccessibleTitle (sp-classic-page-assembly_en-us_d11c60394d37dddaa20239892768f949.js:273)
    at sp-classic-page-assembly_en-us_d11c60394d37dddaa20239892768f949.js:273
    at <anonymous>

Looking at the network tab, AngularJS is being correctly downloaded so something else must be wrong initializing it inside SPFx.

Smells like a race condition...
I've seen where async loading of externals is better handled with registered declaratively in config.json vs. loading programmatically.


CommunityToolkit.Maui.IServiceCollectionExtensions

Documentation for CommunityToolkit.Maui.IServiceCollectionExtensions in PR #494

Updated TOC
Updated /extensions/index.md
Added new ServiceCollectionExtensions page

NOTE: Markdownlint rule MD024 was set to allow_different_nesting = true at the page level due to multiple extension methods requiring documentation for parameters of same name, type, etc.

Microsoft authors of articles need to make updates through the private repository, so the updates can be staged and validated by current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.
It's easy to access the private repo version of your articles in GitHub. Just add -pr to the URL, as follows:
 Public repo URL: https://github.com/MicrosoftDocs/{docs-repo}
 Private repo URL: https://github.com/MicrosoftDocs/{docs-repo-pr}
We have closed this pull request. Please resubmit the updates through the private repo. For more information, see the contributor guide.

Docs Build status updates of commit 6796281:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/extensions/index.md
:white_check_mark:Succeeded
View

docs/maui/extensions/servicecollection-extensions.md
:white_check_mark:Succeeded
View

docs/maui/TOC.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

PRMerger Results

Issue
Description

Added File(s)
This PR contains added files. New files require human review.

Yaml File(s)
This PR includes changes to .yml file(s) owned by another author.

File Change Percent
This PR contains file(s) with more than 20% file change.

Index File
This PR contains a change to the index file.

Docs Build status updates of commit 6796281:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/extensions/index.md
:white_check_mark:Succeeded
View

docs/maui/extensions/servicecollection-extensions.md
:white_check_mark:Succeeded
View

docs/maui/TOC.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit e2ec71c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/extensions/index.md
:white_check_mark:Succeeded
View

docs/maui/extensions/servicecollection-extensions.md
:white_check_mark:Succeeded
View

docs/maui/TOC.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

PRMerger Results

Issue
Description

Added File(s)
This PR contains added files. New files require human review.

Yaml File(s)
This PR includes changes to .yml file(s) owned by another author.

File Change Percent
This PR contains file(s) with more than 20% file change.

Index File
This PR contains a change to the index file.

Docs Build status updates of commit 17824e3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/extensions/index.md
:white_check_mark:Succeeded
View

docs/maui/extensions/servicecollection-extensions.md
:white_check_mark:Succeeded
View

docs/maui/TOC.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

PRMerger Results

Issue
Description

Added File(s)
This PR contains added files. New files require human review.

Yaml File(s)
This PR includes changes to .yml file(s) owned by another author.

File Change Percent
This PR contains file(s) with more than 20% file change.

Index File
This PR contains a change to the index file.

FYI - I'm merging https://github.com/CommunityToolkit/Maui/pull/494 now 🎉


Change background color for cell

How can I apply a similar style as cell Conditional?
Ex:
if value='Yes
style="background: red"
else
style="background: green"
Thanks

Thx for asking that question, I forgot to documentate it in the readme.
I've added it. See the last example and the explanation in the styling section: https://github.com/arnedesmedt/vue-ads-table-tree#examples
In this specific case and if the printscreen is the whole table it will be something like this:
<template>
    <vue-ads-table-tree :classes="classes" ...>...</vue-ads-table-tree>
</template>

<script>
export default {
    let classes = {
        'all/3': (row, column) => {
            return {'bg-red': row.[columnName] === 'Yes'};
        }
    };
}
</script>

it's working. Thanks for your support
Note:
Add check undefined
let classes = {             'all/3': (row, column) => {                if (row !== undefined) {                   return { 'bg-red': row.[columnName] === 'Yes' };                }             }          };


Parsing JSON data

Hi,
Was playing around with revel this week, one component I wanted to try was building out JSON API, responding with JSON was no prob but I haven't been able to figure out how to properly parse JSON data posted to an action.
I may be missing something but couldn't find a good way to handle it using the Binder.

@robfig @brendensoares Can you add this to params.go in master?
func (c Application) Test() rev.Result {     mentions := []struct {         Text string json:text     }{}     err := json.NewDecoder(c.Request.Body).Decode(&mentions)     if err != nil {         rev.ERROR.Println(err)     }     rev.INFO.Println(mentions)     return c.RenderText("ok") }

@kumarsiva07 Can you describe your use case?

Yes.  I am using react instead of revel templates.
So all the request will have request data in the form of json. It's a
application/json type request.
On 2 Jun 2016 2:50 am, "Jeevanandam M."<EMAIL_ADDRESS>wrote:

@kumarsiva07 https://github.com/kumarsiva07 Can you describe your use
case?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/revel/revel/issues/97#issuecomment-223127629, or mute
the thread
https://github.com/notifications/unsubscribe/AHXgdqsHiz0jYrvCxovWB8ag_ow7bzu0ks5qHfcOgaJpZM4AfIxc
.

@kumarsiva07 - please create an issue with your description and also mention about #97 and #110.


DoubleTanchetArc fails due to axis is_parallel check

Below is some code that should produce DoubleTanchetArcs for each iteration but it fails 340 times out of 900 because of the parallel check on ~objects_curve.py:233. I'm not sure the best solution for this but reducing the tolerance to 5e-2 fixes it for the code below.
failcount = 0
for i in range(0,900):
	l1 = Rot(0,0,-45 + i/10) * Line((0,0),(10,0))
	l2 = Line((0,-10),(0,0))
	try:
		dta =<EMAIL_ADDRESS>l2%0, l1)
	except Exception as e:
		failcount+=1

print (f"failed {failcount} times")

If I change the code to use the cross product to check for parallel(below), I also get 340 failures when using 1e-5 as the tolerance. Increasing the tolerance to 2e-3 fixes.
t1 = other.tangent_at(p1)
t2 = circle.tangent_at(p2)
cross_mag = t1.cross(t2).length

if cross_mag < 2e-3:
    arc_centers.append(arc_center)

Thanks for the testing.  I found that I had to relax the value even further: if other_axis.is_parallel(circle_axis, 0.05): to get all of these tests to pass. I don't see a down side to this but if you do let me know.


Return same datastructure from withCookies and useCookies

I cannot easily switch between usage of withCookies and useCookies. Honestly, the useCookies typing makes no sense to me at all. Please make both return the same identical datastructures so that my method of reading the data in the cookie (JSON) that used to take Cookies type can be handed whatever rolls out of useCookies, too.

Preferably, return Cookies object from useCookies.
Argument of type '{ [name: string]: any; }' is not assignable to parameter of type 'Cookies'.
  Type '{ [name: string]: any; }' is missing the following properties from type 'Cookies': cookies, changeListeners, HAS_DOCUMENT_COOKIE, _updateBrowserValues, and 7 more.ts(2345)

Doing this does not align with how React hooks work. It is not a breaking change I am willing to make.


Fix correct order of segment credentials

Guys, the Segment credentials are injected into the UI pod and Spog Api pod in reverse order. I hope this change fixes the issue, but please help me understanding this PR is all we need to fix this issue


What's the status on no-std vs std?

How feature complete is no-std version of the esp32c3 ecosystem vs using esp-idf?

I'm not really sure how to quantify this, to be honest.
The std ecosystem supports whatever ESP-IDF does, whether this is via the safe Rust wrappers (eg. esp-idf-hal) or via the unsafe bindings (eg. esp-idf-sys). The no-std ecosystem has had to be written from the ground up, and has been being developed for much less time and by much fewer people, so it's obviously a lot less developed.


Training speed difference between hdd and ssd

Hello
Is there a big difference in training time between hdd and ssd?
I use hdd and get around 500 hz but it fluctuates quite often to lower hz. I was wondering if anyone had comparable experience between the two. Thank you.

This can be a symptom of slow random access in some hard drive. We recommend using SSDs, but it may help to use more data loader threads if that's not possible.


Use machine name as disk name

When compiling crc with a name different than crc, the machine won't start because the disk image name is not the right one. See https://github.com/code-ready/crc/blob/d2b83d6a75b9522fba12b1eaf28f38dc799535f7/pkg/crc/machine/libvirt/driver_linux.go#L39

For what it's worth, I have more extensive changes in that area, see https://github.com/cfergeau/crc/commit/bf5b0ffefcf2e457fcbb8cb534dead04f2c316cc for example which I think is related to the issue you were having.


feat added Applitools and Cypress testing framework

Changes
This PR adds a suite of visual regression tests for Buefy docs using Applitools Eyes and Cypress. These tools allows for a seamless and lightweight testing of the documentation. When the tests are run, the Applitools SDK grabs DOM elements and takes snapshots of the style scripts. Then, Applitools launches Chrome and Firefox before rendering the selected elements (and any accompanying interaction with the UI) and taking screenshots of the specified visual components. The first time the tests are run, the snapshots will be saved as a baseline for comparison in future tests.
Tests
The test suite loads each page of the documentation and interacts with certain UI components to make sure they render correctly. The screenshots generated do not use pixel-by-pixel identification, but rather inspect as a human eye would, thus eliminating test failures caused by minuscule changes in pixelation. The current tests are already robust, but you can either cut them down or build upon them further. If you'd like to take a look, they are located in the cypress/integration folder.
To run the tests, you would need to create an account with Applitools, which will give you a unique ID needed to run the tests. You can receive your unique API key with a free account, but for OSS maintainers, more flexible, free unlimited accounts are also available. Once the account is created, you can use the command "export APPLITOOLS_API_KEY=value".
Please let me know if you'd like to take a further look into Applitools. I have created a testing framework using Jest, Jest Image Snapshot, Docker, AWS S3, and Jenkins before, and this is far more lightweight, efficient, and user-friendly. Thank you for your time in reviewing this PR.
For reference: https://applitools.com/docs/topics/overview/overview-visual-testing.html

@sassypianist98 looks good to me. here is what you should do next:

add the git@github.com:buefy/buefy.git as a remote (I recommend naming it upstream)

git remote add upstream git@github.com:buefy/buefy.git

fetch the upstream to pull it down: git fetch upstream
rebase onto upstream/dev to get any changes they have made

git rebase upstream/dev ui-testing
resolve any conflicts
commit

copy the description from this PR
squash and merge this PR
open a across fork PR from sassypianist98/buefy into buefy/buefy
paste this description
tag me in a comment so I can see the PR

If you have any questions or would like to work on this together, hit me up


ServiceEventName-specific deserialization of charging events

After #183 every single field in ServiceEventChargingData.
We should probably look at deserializing these events differently depending on the name (ServiceEventName) and not just the topic.
E.g.
{"version":1,"traceId":"81b50439-af83-44e1-9515-5b3925d4c34a","timestamp":"2024-11-09T13:30:34Z","producer":"SKODA_MHUB","name":"charging-status-changed","data":{"userId":"97bee240-dd09-4d56-8d8b-fbdfxxxxxxxx","vin":"TMBAXXXXXXXXXXXXX"}}\

vs
{"version":1,"traceId":"b03c66fe-67c5-4cd1-b50f-3c551078f6d0","timestamp":"2024-11-09T15:04:48Z","producer":"SKODA_MHUB","name":"change-soc","data":{"mode":"manual","state":"charging","soc":"50","chargedRange":"195","timeToFinish":"440","userId":"ad0d7945-4814-43d0-801f-fbdfxxxxxxxx","vin":"TMBAXXXXXXXXXXXXX"}}

Loosly related: We probably should look at linking topic subscriptions to capabilities as well.
But yes, we need to start deserializing this data properly. Just like we should probably start properly serializing data we send, and not just slap a random dict in a json body.

@WebSpider do you work atm on this topic? I have some spare time and could take the ticket also unless you do already something.

Yeah im working on this when time permits

@fursov feel free to take this

do we know any other names besides "change-soc" and "charging-status-changed" @dvx76 reported above?

Check here https://github.com/skodaconnect/myskoda/blob/43b2061ac9f6cbdee50fbf6fb993c78932679510/myskoda/models/service_event.py#L14 and here https://github.com/skodaconnect/myskoda/blob/main/docs/mqtt.md

The first attempt is here: #235


fake data

https://www.npmjs.com/package/json-schema-faker

moving this to separate extension, closing


Fix /proc/<pid>/oom_score_adj: invalid argument error caused by empty env name

- What I did
This fix is part of the fix for issue #25099. In #25099, if an env has a empty name, then docker run will throw out an error:
ubuntu@ubuntu:~/docker$ docker run -e =A busybox true
docker: Error response from daemon: invalid header field value "oci runtime error:
container_linux.go:247: starting container process caused \"process_linux.go:295:
setting oom score for ready process caused \\\"write /proc/83582/oom_score_adj:
invalid argument\\\"\"\n".

- How I did it
This fix validates the Env in the container spec before it is sent to containerd/runc.
- How to verify it
Integration tests have been created to cover the changes.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)

This fix is part of fix for #25099 (not complete yet, non-utf case may require a fix in runc).
This fix is related to #25300.
Signed-off-by: Yong Tang<EMAIL_ADDRESS>

Thanks @vdemeester. The PR has been updated. Please take a look.

LGTM ping @vdemeester


[SPARK-49579][SQL][TESTS] Rename errorClass to condition in checkError()

What changes were proposed in this pull request?
In the PR, I propose to rename the errorClass parameter of the checkError() functions (and related and similar functions) to condition to follow the naming convention introduced by SPARK-46810.
For example:
checkError(
  exception = e,
  condition = "UNRESOLVED_COLUMN.WITH_SUGGESTION",
  parameters = Map("objectName" -> "`non_exist`", "proposal" -> "`i`, `j`"))

Why are the changes needed?
To follow new naming convention introduced by https://github.com/apache/spark/pull/44902.
Does this PR introduce any user-facing change?
No, the changes affect only in tests.
How was this patch tested?
By running the existing test suites and GAs.
Was this patch authored or co-authored using generative AI tooling?
No.

@srielau @panbingkun @nchammas @cloud-fan Could you review the PR, please.

late LGTM.


TASK: Remove interface and code cleanup

Interface will be added when valid use case are detected and marked as API

Please merge #14 first


Feature Request: Make filter more usable

If filter could filter out processes with dlls or have negative search it would be awesome.

filter out processes with dlls

Every process has a DLL except system?

negative search

Adding a NOT operator with ! or another character could work. The filtering callbacks need to be rewritten for this to work though.

I mean with particular dlls.

Merging with issue #1231 👍


Amplify Status hook for plugins

Is your feature request related to a problem? Please describe.
When you run amplify status it should show important info from the plugin callback. Today this is hard coded for every plugin. It would be nice to add it as an event that you can display important info whenever a user runs amplify status
Describe the solution you'd like
Add a new amplify event called getStatus which allows you to display info. This should also be moved outside of the provider and instead be dependent on the category plugins.
https://github.com/aws-amplify/amplify-cli/blob/8b225c1f9f16fed303adaaa91831bac7752d579d/packages/amplify-cli/src/extensions/amplify-helpers/show-helpful-provider-links.js#L14
This file could change to instead of looping through all the providers, it would loop through all the categories and see if they have a showHelpfulLink available
Describe alternatives you've considered
Making a pull request to the cloudformation provider to add custom callback location to all plugins but this would only work if they support cloudformation which isn't good.
Additional context
Current location where all the urls are being displayed from: https://github.com/aws-amplify/amplify-cli/blob/54676797b913d4a2c284c62244c8ccf8e55a44d8/packages/amplify-provider-awscloudformation/lib/display-helpful-urls.js
Current location that is goes into the provider: https://github.com/aws-amplify/amplify-cli/blob/8b225c1f9f16fed303adaaa91831bac7752d579d/packages/amplify-cli/src/extensions/amplify-helpers/show-helpful-provider-links.js#L14

Bumping this as I saw that Rest got support but plugins still don't have support

Ref #4547 @attilah


Removing HTTP requests from Bucket logging methods.

Relates to  #728

Coverage remained the same at 100.0% when pulling 74cb2b0b487ffdf4d6fd6606a1cd18369100f611 on dhermes:logging-no-requests into 4d69bb34862d709c4d0abeb0e21fe19a2b1a77cd on GoogleCloudPlatform:master.

@tseaver based on https://github.com/GoogleCloudPlatform/gcloud-python/pull/773#issuecomment-87799124 are we a go to merge this?

@tseaver Just rebased (the public .reload() in #770 made this un-mergeable).
Are we good?

LGTM:  I added #778 to track the testcase cleanups.

Coverage remained the same at 100.0% when pulling ed87a2f6d853888f85680f1f34e6beb281ce93c8 on dhermes:logging-no-requests into 522987aac505a5287c675df7e19800fb944b1de9 on GoogleCloudPlatform:master.


[Suggestion] Disable Listing

Hello,
Would it be possible to put in fullmoon a way to disable root listing (redbean default) without the need to create an index file?
e.g.
When the listing is deactivated
A blank or 404, default route to / is created if the user has not defined

Are you saying that you may not have any routes for / and the listing is displayed by default? Do you have any other routes or is this some configuration without any routes?
I'd rather consider doing the opposite: the listing is disabled by default, but you can enable it with a specific route (as desired).

Correct, listing is disabled by default and only activated if the user wants

I don't get any listing by default from the following code:
local fm = require"fullmoon"
fm.run()

I get 404 when accessing root URL /; isn't that what you'd expect?

Oh great! This what I expected. Thanks for support!


[aes] Fix/update checklist

This PR implements a couple of changes to the AES checklist including fixing a broken link preventing the build of the documentation.

Thanks Scott for approving the PR.


Recompile view module automatically when new templates are added

Adds support for automatically recompiling the view module when a new template file is added. This was missing on https://github.com/surface-ui/surface/pull/543.
Before this change, everytime a new template was added (e.g. lib/example_web/templates/foo/new_template.sface), we'd need to touch the view file (e.g. lib/examples_web/views/foo_view.ex) so that Mix recompiled it with the macro generating a render/2 clause for the new template.
After this change, this is no longer needed. To accomplish that, we're exporting a __mix_recompile__? function that will compare a hash of the template paths of the view with a hash calculated on the previous compilation. This uses the same approach as Phoenix.Template does under the hood.

@guisehn thanks! ❤


Pull fonts and colors from the DH design system

Need a few type faces and colors for the Docusaurus

@earth2travis Our custom font works for this but having more trouble with the colors. This is due to the nextra theme being a 'plugin' basically and it's using Tailwind under the hood. I've tried a few things but nothing has been consistent. Going to try a few more things but then I'll at least push up a PR using Mulish to match the apps.
We can then keep figuring out the custom theme.

Ok, I got this working kind of. I successfully updated to Nextra v2 (beta, but has nice features and will be stable soon!) and took care of the breaking changes. In that we're able to set a primaryHue  -- this isn't as deeply customizable as a full theme config, but we can set a main accent color based on hues.
I'm going to get this stable and make a PR for the v2 migration and then I'll update the fonts and styles.

@jonathanprozzi sounds good. Just make sure it deals with how we have the menus collapsed with Plor's fix and if the navigation structure changes any that all the links still work sitewide

@jonathanprozzi sounds good. Just make sure it deals with how we have the menus collapsed with Plor's fix and if the navigation structure changes any that all the links still work sitewide

Yup should be good. It's a setting now. Will be sure to test that tho


160px

since the update on March 13 all my photos are being downloaded or uploaded ay tiny 160x160 resolution, no matter which options i select. granted, i tried just a few combinations, mostly to either download to device dcim or not, combined with uploading directly to drive or not.
funny enough, i don't think I've updated the app as soon as the update was released (but maybe i did later in the same day) yet, i just notice my tiny photos date back precisely and coincidentally with March 13th.
cheers again!

ok, not so much the "funny enough" part, after all. i do see tiny photos from february as well, duplicated with previous photos which were already uploaded in the correct size.

I tested app on my phone. All of photo size is 2005x2673.
I did not change download algorism form Narrative Service.
I guess Narrative Service do not provide url of full size data. 160x160 is perhaps thumbneil data. This app select biggest size photo from liat of photo data.
Thanks

all my photos in narrative cloud are at full resolution as usual. i uninstalled the app and tried again, still getting only tiny photos.

it is mostly an error on narrative api indeed. i went to https://narrativeapp.com/api/v2/moments/02f7f033fde044d5a9f40cebf3b0432a/photos/ and found this:
{
    "count": 52,
    "next": "https://narrativeapp.com/api/v2/moments/02f7f033fde044d5a9f40cebf3b0432a/photos/?page=2",
    "previous": null,
    "results": [
        {
            "trim": false,
            "uuid": "9c22dbcfe3fc4edaa456056791793d3b",
            "taken_at_local": "2018-04-13T14:22:47+01:00",
            "url": "https://narrativeapp.com/api/v2/photos/9c22dbcfe3fc4edaa456056791793d3b/",
            "tags": [],
            "favorite": false,
            "quality_score": 4.90272131119234,
            "faces_url": "https://narrativeapp.com/api/v2/photos/9c22dbcfe3fc4edaa456056791793d3b/faces/",
            "moment_uuid": "02f7f033fde044d5a9f40cebf3b0432a",
            "favorited_time": null,
            "renders": {
                "g1_thumb_square": {
                    "url": "https://nrtv3-app-privatebucket-1nx6pcmahiqo5.s3.amazonaws.com/private/users/345b22ce9d624f0c9fb73337052a4436/renders/g1_thumb_square/9c22dbcfe3fc4edaa456056791793d3b.jpg",
                    "size": {
                        "width": 133,
                        "height": 100
                    }
                },
                "g1_webrender": {
                    "url": "https://nrtv3-app-privatebucket-1nx6pcmahiqo5.s3.amazonaws.com/private/users/345b22ce9d624f0c9fb73337052a4436/renders/g1_webrender/9c22dbcfe3fc4edaa456056791793d3b.jpg",
                    "size": {
                        "width": 133,
                        "height": 100
                    }
                },
                "g1_hd": {
                    "url": "https://nrtv3-app-privatebucket-1nx6pcmahiqo5.s3.amazonaws.com/private/users/345b22ce9d624f0c9fb73337052a4436/renders/g1_hd/9c22dbcfe3fc4edaa456056791793d3b.jpg",
                    "size": {
                        "width": 133,
                        "height": 100
                    }
                },
                "g1_smartphone": {
                    "url": "https://nrtv3-app-privatebucket-1nx6pcmahiqo5.s3.amazonaws.com/private/users/345b22ce9d624f0c9fb73337052a4436/renders/g1_smartphone/9c22dbcfe3fc4edaa456056791793d3b.jpg",
                    "size": {
                        "width": 133,
                        "height": 100
                    }
                }
            },
            "faces": [],
            "type": "photo"
        },

already pinged the guys at narrative... but, at the same time, seems like a very simple change on those lines could help in here too:
https://github.com/MypaceEngine/PhotoDL4NarrativeServ/blob/2bbfa52fc428fe78a5fd03480147402668472b6a/app/src/main/java/com/mypaceengine/downloadnarrative/Job_DownLoadPhoto.java#L77-L78
making it start with "g1_hd" rather than the first item, in case an issue like this happens.
do you think you could kindly make the magic once more? :)

Oh!, I understood the issue. I guess photo size information sending from Narrative Service is not correct. I fix the this bug, and release new version. Please try new version.

https://github.com/MypaceEngine/PhotoDL4NarrativeServ/commit/7944e1b9a863a7e9497bc56f15ad0440fc408aee#diff-d233588577e6e03f3f30b46d60a331b9R68
thank you so much, it worked! :) +1


Reuse shared functionality between etcd and skydns2 backend

IMHO it does not make sense to keep the two backends skydns2 and etcd completely independent. They're not: they both work on top of etcd. The only difference between the backends is the key-value pairs they're writing.
They were couple issues in the past (that I remember) that fixed just of the backend, although the fix should be applied to both of them. Recently https://github.com/gliderlabs/registrator/pull/221 was merged, fixing etcd backend while keeping the skydns2 untouched.
I believe that's not the last fix for etcd client usage. In order to make sure any future fix is applied to both backends, I think we should add a minimal and thin layer of abstraction on top of github.com/coreos/go-etcd/etcd exposing the functionality needed by etcd2 and skydns: set, delete, ping. The backends should reuse just it and implement any backend-specific code.

I've done something similar in https://github.com/gliderlabs/registrator/pull/138


[Music] General Improvements

Description
Improved stability. Better error handling / reporting
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

I'm using the native screenshot method for assets. How can I improve the size?

@pernielsentikaer any suggestion on this?

@Rawnly would you mind adding an entry to the changelog?

sure!


Server should only pick from supported_group and not from key_share

The situation is, both the client and server support (and prefer) some post-quantum groups (post-quantum later on here) that are super costly to compute. More costly than to do a HelloClient without KeyShare and to wait for the HelloRetryRequest. At the same time, post-quantum groups are not super well deployed so there is a high chance that the other end will not pick the post-quantum group and instead pick another more common group such as x25519. x25519 is less costly to compute than do wait for a HelloRetryRequest.
The client sends the following:

supported_group = [post-quantum, x25519]
key_share = [x25519]

The server has the following configuration:

supported_group = [post-quantum, x25519]

The server at the moment would pick the x25519 group but it should had picked the post-quantum group instead and send a HelloRetryRequest advertising post-quantum.

solved in b11791b


feat(python): expose rust writer v2 as additional engine

Description
Builds on top of the other PR by adding schema overwrite.

Messed up my branch .. starting over


Build Fails

After I install elixir and erlang and run MIX_ENV=prod mix do deps.get, compile, release, I get the following output:
* Getting eiconv (https://github.com/zotonic/eiconv.git)
remote: Counting objects: 81, done.
remote: Total 81 (delta 0), reused 0 (delta 0), pack-reused 81
Running dependency resolution

[ [ [ OMITTED FOR BREVITY ] ] ]

===> Compiling idna
===> Fetching rebar3_hex ({pkg,<<"rebar3_hex">>,<<"3.0.0">>})
===> Downloaded package, caching at /Users/adam/.cache/rebar3/hex/default/packages/rebar3_hex-3.0.0.tar
===> Compiling rebar3_hex
===> Compiling mimerl
==> erlware_commons (compile)
Compiled src/ec_vsn.erl
Compiled src/ec_dictionary.erl
Compiled src/ec_talk.erl
Compiled src/ec_semver_parser.erl
Compiled src/ec_semver.erl
Compiled src/ec_orddict.erl
src/ec_plists.erl:220: syntax error before: '/'
src/ec_plists.erl:226: syntax error before: '/'
src/ec_plists.erl:250: syntax error before: '/'
src/ec_plists.erl:256: syntax error before: '/'
src/ec_plists.erl:279: syntax error before: '/'
src/ec_plists.erl:285: syntax error before: '/'
src/ec_plists.erl:300: syntax error before: '/'
src/ec_plists.erl:305: syntax error before: '/'
src/ec_plists.erl:326: syntax error before: '/'
src/ec_plists.erl:336: syntax error before: '/'
src/ec_plists.erl:343: syntax error before: '/'
src/ec_plists.erl:355: syntax error before: '/'
src/ec_plists.erl:361: syntax error before: '/'
src/ec_plists.erl:372: syntax error before: '/'
src/ec_plists.erl:384: syntax error before: '/'
src/ec_plists.erl:397: syntax error before: '/'
src/ec_plists.erl:403: syntax error before: '/'
src/ec_plists.erl:418: syntax error before: '/'
src/ec_plists.erl:427: syntax error before: '/'
src/ec_plists.erl:438: syntax error before: '/'
src/ec_plists.erl:450: syntax error before: '/'
src/ec_plists.erl:459: syntax error before: '/'
src/ec_plists.erl:472: syntax error before: '/'
src/ec_plists.erl:484: syntax error before: '/'
src/ec_plists.erl:522: syntax error before: '/'
src/ec_plists.erl:590: syntax error before: '/'
src/ec_plists.erl:625: syntax error before: '/'
src/ec_plists.erl:209: type el_fun() is unused
Compiling src/ec_plists.erl failed:
ERROR: compile failed while processing /Users/adam/Sites/Thumbifier/deps/erlware_commons: rebar_abort
** (Mix) Could not compile dependency :erlware_commons, "/Users/adam/.mix/rebar compile skip_deps=true deps_dir="/Users/adam/Sites/Thumbifier/_build/prod/lib"" command failed. You can recompile this dependency with "mix deps.compile erlware_commons", update it with "mix deps.update erlware_commons" or clean it with "mix deps.clean erlware_commons"

I can fix this by doing a mix deps.update --all and everything seems like it's going OK for a bit. And then build fails on phoenix_ecto:
Generated ecto app
==> phoenix_ecto
Compiling 4 files (.ex)

== Compilation error on file lib/phoenix_ecto/html.ex ==
** (KeyError) key :model not found in: %Phoenix.HTML.Form{data: nil, errors: {:form_for_errors, [line: 12], [{{:., [line: 12], [{:changeset, [line: 12], nil}, :errors]}, [line: 12], []}]}, hidden: [], id: {:name, [line: 10], nil}, impl: Phoenix.HTML.FormData.Ecto.Changeset, index: nil, name: {:name, [line: 11], nil}, options: [], params: %{}, source: {:changeset, [line: 8], nil}}
    (stdlib) :maps.update(:model, {:model, [line: 13], nil}, %Phoenix.HTML.Form{data: nil, errors: {:form_for_errors, [line: 12], [{{:., [line: 12], [{:changeset, [line: 12], nil}, :errors]}, [line: 12], []}]}, hidden: [], id: {:name, [line: 10], nil}, impl: Phoenix.HTML.FormData.Ecto.Changeset, index: nil, name: {:name, [line: 11], nil}, options: [], params: %{}, source: {:changeset, [line: 8], nil}})
    lib/phoenix_html/form.ex:170: anonymous fn/2 in Phoenix.HTML.Form.__struct__/1
    (elixir) lib/enum.ex:1623: Enum."-reduce/3-lists^foldl/2-0-"/3
    expanding struct: Phoenix.HTML.Form.__struct__/1
    lib/phoenix_ecto/html.ex:7: Phoenix.HTML.FormData.Ecto.Changeset.to_form/2

could not compile dependency :phoenix_ecto, "mix compile" failed. You can recompile this dependency with "mix deps.compile phoenix_ecto", update it with "mix deps.update phoenix_ecto" or clean it with "mix deps.clean phoenix_ecto"

If I update phoenix to 2.0 and phoenix_ecto to 1.2 in the mix.exs file, I can get the project to build, but it doesn't run, and I get errors in my /var/log/supervisor:
/var/log/supervisor# cat supervisord.log
2016-10-18 21:16:50,553 CRIT Supervisor running as root (no user in config file)
2016-10-18 21:16:50,554 WARN Included extra file "/etc/supervisor/conf.d/supervisord.conf" during parsing
2016-10-18 21:16:50,564 INFO RPC interface 'supervisor' initialized
2016-10-18 21:16:50,564 CRIT Server 'unix_http_server' running without any HTTP authentication checking
2016-10-18 21:16:50,564 INFO supervisord started with pid 1
2016-10-18 21:16:51,569 INFO spawned: 'thumbifier' with pid 9
2016-10-18 21:16:51,614 INFO exited: thumbifier (exit status 0; not expected)
2016-10-18 21:16:51,615 CRIT reaped unknown pid 46)
2016-10-18 21:16:51,765 CRIT reaped unknown pid 83)
2016-10-18 21:16:52,328 CRIT reaped unknown pid 104)
2016-10-18 21:16:53,332 INFO spawned: 'thumbifier' with pid 105
2016-10-18 21:16:53,360 INFO exited: thumbifier (exit status 0; not expected)
2016-10-18 21:16:53,361 CRIT reaped unknown pid 140)
2016-10-18 21:16:53,483 CRIT reaped unknown pid 177)
2016-10-18 21:16:53,483 CRIT reaped unknown pid 178)
2016-10-18 21:16:54,054 CRIT reaped unknown pid 198)
2016-10-18 21:16:55,495 INFO spawned: 'thumbifier' with pid 199
2016-10-18 21:16:55,496 CRIT reaped unknown pid 97)
2016-10-18 21:16:55,514 INFO exited: thumbifier (exit status 0; not expected)
2016-10-18 21:16:55,514 CRIT reaped unknown pid 234)
2016-10-18 21:16:55,520 CRIT reaped unknown pid 47)
2016-10-18 21:16:55,652 CRIT reaped unknown pid 271)
2016-10-18 21:16:55,652 CRIT reaped unknown pid 272)
2016-10-18 21:16:56,297 CRIT reaped unknown pid 292)
2016-10-18 21:16:57,266 CRIT reaped unknown pid 191)
2016-10-18 21:16:57,312 CRIT reaped unknown pid 141)
2016-10-18 21:16:59,316 INFO spawned: 'thumbifier' with pid 293
2016-10-18 21:16:59,337 INFO exited: thumbifier (exit status 0; not expected)
2016-10-18 21:16:59,337 INFO gave up: thumbifier entered FATAL state, too many start retries too quickly
2016-10-18 21:16:59,337 CRIT reaped unknown pid 328)
2016-10-18 21:16:59,453 CRIT reaped unknown pid 365)
2016-10-18 21:16:59,453 CRIT reaped unknown pid 366)
2016-10-18 21:16:59,563 CRIT reaped unknown pid 285)
2016-10-18 21:16:59,608 CRIT reaped unknown pid 235)
2016-10-18 21:16:59,966 CRIT reaped unknown pid 386)
2016-10-18 21:17:03,084 CRIT reaped unknown pid 379)
2016-10-18 21:17:03,128 CRIT reaped unknown pid 329)

/var/log/supervisor# cat thumbifier-stdout---supervisor-8N0SvW.log
mkdir: created directory '/root/running-config'

I wish I had something in the form of a PR to help with, but these languages/frameworks are not my area of expertise.
Please let me know if there's anything else I can do to help.

Same problem with me.

A little, late but in my case I couldn't have eiconv being compiled by rebar3, so in my
dependencies I listed it as
 {:eiconv, git: "https://github.com/zotonic/eiconv.git", manager: :rebar }


Separate deploy-broker and join

deploy-broker’s ability to set the dataplane up is confusing, it’s
best to leave that to an explicit join (or the all-in-one deploy which
is explicitly all-in-one).
Fixes: #69
Signed-off-by: Stephen Kitt<EMAIL_ADDRESS>

This change is

Ping @manosnoam @dimaunx ^ :-)

Talking with @manosnoam and @Oats87 we seem to be happier about the alternative patch you wrote on #75 . Thanks :)


mapbox is outdated

Maputnik v1.7.0 (as hosted on https://maputnik.github.io/editor) runs using mapbox Version 1.9.1.
https://github.com/maputnik/editor/blob/v1.7.0/package.json#L44
This is an old version of mapbox that doesn't support expressions such as slice: https://docs.mapbox.com/mapbox-gl-js/style-spec/expressions/#slice
I'd consider this so limiting, that a new maputnik release should occur after the mapbox upgrade, so these new styling features can be used.
In master, this has been upgraded to 1.11.0 (in https://github.com/maputnik/editor/commit/24327541c5c61389c54484396e404689b48fca92), but that's also outdated by now.
Please consider upgrading mapbox 1.x to the latest 1.13.x + potentially additional support for maplibre in the future.

With @propheel's PR, master is now using mapbox-gl 1.13.2.
Opened #781 to start a discussion about maplibre support.

Any plans on building and deploying a new release?