Hacktoberfest : Add illustrations (TODO)

I am opening this issue for someone looking to contribute, as per Hacktoberfest event.
Open a PR including changes to all the below TODO List of Resources, and make sure to link the issue to the PR so that I get notified that this contribution is done for Hacktoberfest.
Adding the whole list will definitely prove that the contribution is up to the standards of the Hacktoberfest event.

Comment, if you want me to assign this issue to you

Illustration

[ ] Scratches
[ ] Tiny Dribbble Shots Constructor
[ ] Desk Dudes
[ ] The Townies
[ ] Lil Helpers
[ ] The Carltons
[x] Neighbour Larry
[ ] Jane
[ ] Springtale
[ ] Office Dave
[ ] Workaholics
[ ] Isotopia
[ ] Polydrome
[ ] Aventine
[ ] Fundango

Hi :) I would like to work on this issue, please assign it to me. Thanks!

@jpacsai
Please, do not reference the issue in the individual commits.
Since that would be appropriate when the fork is deleted, and it also makes the issue quite a mess.


Feature/db sync progress awareness

Tested against<EMAIL_ADDRESS>Throws a meaningful error when accessing Cardano.currentEpoch when the DB is not fully synced.
Fixes an issue with the migrations rollback queries.
Adds support for querying the API for sync status:

{
  cardanoDbMeta {
    initialized
    slotDiffFromNetworkTip
    syncPercentage
  }
}

{
  "data": {
    "cardanoDbMeta": {
      "initialized": false,
      "slotDiffFromNetworkTip": -2928618,
      "syncPercentage": 33.29
    }
  }
}

:warning: Breaking changes

Cardano.blockHeight removed in favour of Cardano.tip.number. Tip = the most recent Block, so it's possible to get more information such as slotNo, traverse the chain, or any other interaction with the most recent block.
Dates are now coerced to RFC 3339 UTC date-time strings

:green_circle: Tests passing
yarn run v1.22.4
$ yarn workspaces run test --ci

> @cardano-graphql/api-cardano-db-hasura
$ yarn build && NODE_ENV=test jest -c ./test/jest.config.js query --ci
$ yarn codegen && tsc -b ./src
$ graphql-codegen
(node:21099) ExperimentalWarning: Conditional exports is an experimental feature. This feature could change at any time
  ✔ Parse configuration
  ✔ Generate outputs
 PASS  test/cardano.query.test.ts
 PASS  test/transactions.query.test.ts
 PASS  test/blocks.query.test.ts
 PASS  test/epochs.query.test.ts
 PASS  test/utxos.query.test.ts

Test Suites: 5 passed, 5 total
Tests:       22 passed, 22 total
Snapshots:   14 passed, 14 total
Time:        4.67 s, estimated 5 s
Ran all test suites matching /query/i.

> @cardano-graphql/cli
$ NODE_ENV=test jest -c ./test/jest.config.js cli.test.ts --ci
 PASS  test/cli.test.ts (12.137 s)
  CLI Test
    ✓ Shows the program help if no arguments are passed (252 ms)
    system-info command
      ✓ Logs an object useful during issue reporting (252 ms)
    docker command
      ✓ Shows the program help if no arguments are passed (467 ms)
      init
        ✓ writes a config file to the appropriate platform-specific path, scoped by command, copies a docker compose file to use as boilerplate, and handles secret generation (505 ms)
        ✓ can be used in automated processes using command arguments (476 ms)

Test Suites: 1 passed, 1 total
Tests:       5 passed, 5 total
Snapshots:   3 passed, 3 total
Time:        12.472 s, estimated 17 s
Ran all test suites matching /cli.test.ts/i.

> @cardano-graphql/client-ts
$ shx echo No tests in this package --ci
No tests in this package --ci

> @cardano-graphql/server
$ yarn build && NODE_ENV=test jest -c ./test/jest.config.js --ci
$ tsc -b ./src
npx: installed 69 in 4.101s
npx: installed 69 in 4.703s
  console.log
    The server is configured to accept 2 operations from the provided whitelist

      at Object.serverWillStart (../src/apollo_server_plugins/whitelist_plugin.ts:7:15)
          at Array.map (<anonymous>)

  console.log
    The server is configured to accept 2 operations from the provided whitelist

      at Object.serverWillStart (../src/apollo_server_plugins/whitelist_plugin.ts:7:15)
          at Array.map (<anonymous>)

 PASS  test/Server.test.ts (10.231 s)
  Server
    Whitelisting
      Booting the server without providing a whitelist
        ✓ returns data for all valid queries (65 ms)
      Providing a whitelist produced by persistgraphql, intended to limit the API for specific application requirements
        ✓ Accepts listed queries (4429 ms)
        ✓ Returns a networkError if a valid but unlisted operation is sent (4968 ms)

Test Suites: 1 passed, 1 total
Tests:       3 passed, 3 total
Snapshots:   0 total
Time:        10.555 s, estimated 12 s
Ran all test suites.

> @cardano-graphql/util-dev
$ shx echo No tests in this package --ci
No tests in this package --ci

> @cardano-graphql/util
$ shx echo No tests in this package --ci
No tests in this package --ci
Done in 31.80s.


DEPRECATION: Addon files were detected

I know this project is possibly not updated regularly but I cannot do a pull from my office.
Ember 2.12 chokes on this issue
DEPRECATION: Addon files were detected in /node_modules/ember-breadcrumbs/addon, but no JavaScript preprocessors were found for ember-breadcrumbs. Please make sure to add a preprocessor (most likely ember-cli-babel) to in dependencies(NOTdevDependencies) in ember-breadcrumbs's package.json`.
which is fixed by moving ember-cli-babel location in the package.json
"dependencies": {
"ember-cli-babel": "^4.3.0"
},
"devDependencies": {
"broccoli-asset-rev": "^2.0.0",
"ember-cli": "0.2.0",
"ember-cli-app-version": "0.3.2",
"ember-cli-content-security-policy": "0.3.0",
"ember-cli-dependency-checker": "0.0.8",
"ember-cli-htmlbars": "0.7.4",
"ember-cli-ic-ajax": "0.1.1",
"ember-cli-inject-live-reload": "^1.3.0",
"ember-cli-qunit": "0.3.9",
"ember-cli-uglify": "1.0.1",
"ember-export-application-global": "^1.0.2"
},

Fixed by 0.1.10. Thanks @hbrysiewicz!

thanks for jumping on that one


Possible indexing fix

Fixes #181
@Marius1311 could you please test this out where it fixes the problem? If yes, I will begin writing tests.

Thanks, will try this.

This works, great!

Ok, merging this, I've also fixed a possible issue with having an empty category. I didn't add any tests yet because in the current implementation, it's not that easy. I think it might be worthwhile to refactor some of these to utils (i.e. be class independent) so that it's easier to test.


zabbix_repo - inconsistent use between server and agent roles.

In ansible-zabbix-server, zabbix_repo is a boolean, whereas (following some adjustments for epel handling) zabbix_repo is a string.
When hooking both roles into a playbook, ansible-playbook barfs:
TASK: [dj-wasabi.zabbix-server | RedHat | Install basic repo file] ************
fatal: [xxx.xxx.xxx.xxx] => error while evaluating conditional: zabbix
FATAL: all hosts have already failed -- aborting
PLAY RECAP ********************************************************************
to retry, use: --limit @/root/install-zabbix-server.retry
I have tweaked my local installation, to get around this issue (but only for my exact use case - installing zabbix server + agent on CentOS 7)
Is there any merit in adjusting the zabbix_repo in ansible-zabbix-server to match the agent role, or is it bad practice to try and wrap both of these roles into one playbook anyway ?!!

Hi @blofeldthefish
You are absolutely right. Both roles should use the same 'overall' variables like zabbix_repo, zabbix_version etc ...

I pushed an fix for this. I use the same method as the Zabbix Agent, this would allow to use the EPEL version when people want to.
Please let me know if you have issues with this.

For my particular use case, (install server + agent onto CentOS 7) works like a charm.
I sight checked non-redhat modules with prior version, so would expect those to work well too!!
Not sure of how Ansible Galaxy and Github interact, but an install via ansible-galaxy still installs versions 0.5.1 (not the 0.6.0 codebase)
Appreciate the turnaround on this one...

Hi @blofeldthefish
Thank you. I still have some things that I want in the 0.6.0 release so it isn't available on the galaxy yet.

Just pushed 0.6.0 to the galaxy.


Unable to load libmgrs.pyd error

Hello,
I have installed the library by pip (Windows 10, Python 3.8.2) and when I try to import mgrs, I see the following error:
>>> import mgrs
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\repos\hilla-deep-matching\env\lib\site-packages\mgrs\__init__.py", line 1, in <module>
    from . import core
  File "C:\repos\hilla-deep-matching\env\lib\site-packages\mgrs\core.py", line 74, in <module>
    raise MGRSError("Unable to load %s" % lib_name)
mgrs.core.MGRSError: Unable to load libmgrs.pyd

Could you please advise which library/dependency I might be missing?

For some reason the wheel is not being used. It should be trying to load libmgrs.cp38-win_amd64.pyd and that file should exist in your install package.

I do not see such a file. Sorry for asking but is it sufficient to run pip install mgrs or is it required to install something else?

pip install mgrs should have installed the wheel I believe. I don't have time to test this unfortunately.
if you have MSVC installed, you can clone the repo and issue python setup.py install and it should build everything for you.

Sorry, my mistake, I found the file. I solved the issue by creating a copy of libmgrs.cp38-win_amd64.pyd named libmgrs.pyd.


Make seperate make detection and make track options

We probably want either:
(1) a separate "+" for either detection (single frame) or tracks (multi-frame) where the track option automatically goes to the next frame, right now it's
or
(2) a user-specific setting for switching between these modes

The detection creation option after you draw a box you don't want to stay in edit mode, though you do want to keep the target highlighted

Simple idea would be two text buttons   (Add Detection)  (Add Track) Add detection will be disabled unless a track is selected.
Alternatively If a track is selected we can have it say (Edit Detection) which will set it to edit mode immediately when clicked and then when there isn't an existing detection for a track it can say Add Detection.


Dashborad is 404 - not found

Hello Youssef,
I really appreciate the work you have done. I am facing a little problem that when I try to enter the dashboard it is not found even with your sample. hangfire seems to work fine, and "RavenSMS/Hub" seems to work fine.
Thank you,

I have found a solution by installing RavenSMS.Dashboard and using config.UseDashboard();


Fix incorrect type in certificate_at_index()

Fixes #43
Also adds a single i686 travis build, so this type of thing can be caught in the future. (Also I don't have any way to test this besides travis)

This is a breaking change, I suppose. May just want to publish 0.1.16 and yank 0.1.15.

Ah good catch. Sorry about that :/


Just curious, is the team picture Photoshopped? :)

Let me state first that I love Materialize and have created a Slant entry recommending it.
I'm just curious, was the team picture Photoshopped?

Error-Level Analysis:

Nope haha. thanks for the Slant entry!


Referential transparency and memoization in the proposed event-based architecture

This issue exists mostly as a brain-dump for issues surrounding https://github.com/mikesol/purescript-wags/pull/51.
The problem
Wags in anger suffers from three large-ish problems:

Big graphs take a long time to compile: upwards of 2 hours on some machines. This makes graph updates in the development process very painful.
There's a tradeoff between ergonomics and performance with named audio units. To get fine-grained performance, you need to name your audio units and send changes to their address. Naming makes sense for things that resemble tracks, but for small things like filters or delay lines, giving each one a name is a pain and slows down the creative process. That said, by not naming things, we wind up broadcasting all changes to all nodes, which slows down the rendering loop.
There is no notion of internal event-based logic, which means that all events need to come from the outside. This makes subgraph development painful: imagine that you have a subgraph that needs some sort of internal event emitter when it's created. It makes sense to bundle this logic within the subgraph rather than relying on a top-level handler to know about the event-logic needed by inner scopes.

That said, workarounds have been possible for all of these things, and really nice music has been made with wags. But larger and more ambitious works have suffered from these design limitations.
A potential solution
Moving wags from a comonadic architecture to an event-based architecture has solved at least some of these problems.

Compile times are much faster.
Audio units only require names when there are feedback loops, which makes the code much easier to read and write.
Arbitrary events can be injected into any subgraph.

However, with every design comes tradeoffs, and this has some important ones. The current tradeoffs make the design not-ready-quite-yet-for-production-use. That said, I don't think any of the issues are intractable: they just require thought. The biggest problem has to do with too many computations being re-performed. I describe it below.
Referential transparency. memoization, and events
In the current proposed design, there is a lot of stuff like:
graph = gain 1.0 (gain eventA)
  $ sinOsc 440.0 (frequency (map (mul 1000.0) eventA))) :* [sinOsc 330.0 (frequency (map (mul 2000.0) eventA))]

Here, eventA may represent the result of 1000 map operations. In the current architecture, the 1000 maps will be performed three times: one for each node. That is because, under the hood, the result of the events are <|>'d together, and <|> simply forwards a subscriber down its two sides, which means that the subscriber has operations like map applied to it on either side of the stream.
To get production-level performance, all computations would need to happen once. This is not an issue in the current address-based model because we have more control over the computations, whereas in the event-based model, computations happen in an execution environment (within the events) so the implementation determines when and how often they're done.
I think this problem is soluble, but it's delicate and requires careful attention and/or more powerful abstractions.
Solution 1: Memoize computations
One solution is to simply stash already-computed results somewhere and use some mechanism to check if they exist and either use them or compute them if they don't exist yet. This is hard with events, though. Because events are streams, how do we know that a particular event is needed at this value. It could be that a value is memoized, but the actual one needed is the next one whenever it's emitted. This sort of requires a subscription to be aware of when it's processing a single event in its chain, which is monstrously difficult, as nothing stops an intermediary event from delaying a particular event a few seconds before passing it along. So while memoization could work in some trivial contexts, the complexity doesn't seem to scale well.
Solution 2: Use some type besides Event for internal computations.
Using a more tame type internally solves the above issue, as we can create our own custom computational context that has whatever performance characteristics we want. However, we could just wind up accidentally re-implementing Event, as we need a lot of stuff Event is good at, like feedback loops, state, arbitrary timers, DOM listeners, requestAnimationFrame, etc. This doesn't mean that we need to throw out the baby with the bathwater, however: we could find hooks into which we can inject event-based logic while having a more tame computational context for internal computations. But that adds lots of complexity.
Solution 3: Use something closer to current wags that uses only some of the benefits of this approach
Great is the enemy of good! Already, by hacking at this PR, @PureFunctor and I have come up with two much faster ways to build graphs than in the bad-old days. So we could cash in on the faster compile times while losing out on the expressiveness of purely declarative graphs. We could also likely inject arbitrary events into subgraphs from the top down, which is not quite as expressive as nestling arbitrary events wherever we want, but seems like a good compromise.

I'm confident this PR will make it through in some form in the not-too-distant future, but it requires more thought to make sure it's a solid step forwards for the project.

A few more thoughts having to do with named audio units.
Named audio units can be thought of like addresses. We send them messages from time to time. This is exactly how SuperCollider and all other osc-based audio applications work. There is an address and you periodically send it messages.
If you don't give names to audio units, you actually rotate the tradeoff 90% by forcing one to give names to your computations. This may or may not be more onerous. For example, consider the following snippet:
create { foo: gain {bar: sinOsc }}
case _, _ of
  _, BarA -> @"foo" change 1.0 *> @"bar" change 880.0
  FooB, _ -> @"foo" change 0.4
  FooC, BarA -> @"bar" change 90.0
  FooC, _ -> @"foo" change 0.1

Here, we are addressing audio units foo and bar based on complicated control-flow logic. Imagine it were rotated 90 degrees:
let
  p0 = partition (eq BarA) event
  p1 = filter (eq FooB) p0.no
  p2 = partition (eq BarA) (filter (eq FooC) p0.no)
in
  gain 1.0 (p0.yes $> 1.0 <|> p1.yes $> 0.4 <|> p2.no $> 0.1) (sinOsc 440.0 (p0.yes $> 880.0 <|> p2.yes $> 90.0))

In terms of addresses, we now have three (p0, p1, p2) instead of two (foo and bar).
In both cases, we have to play a game of "what was that thing again?" In the first case, thing in question is an audio unit. What was foo and what was bar? In the second, the thing in question is a computation. What was p0 and what was p1? In slightly-more realistic terms do we want to be seeing a lot of stuff likedelayNodeForLeadVocal versus fooFilteredOutAndSelectingBarB?

A back-of-the-envelope calculation about current wags projects suggests there are many more audio units than intermediary computations. The only common intermediary computations are multiplying time by pi for LFOs and filtering out events.
For filtered events, it's rare that there are as many events as there are audio units. It's much more common to have a robust graph that responds to a few events than a tiny graph that responds to many external events.

After hacking at this issue a while, I’m learning that there are some performance bottlenecks in the event-based architecture. While big parts of it can be used, the overall approach may not work.
One really nice thing about the current wags setup is that the performance-critical part, meaning the pathway from an event to the loudspeaker, is basically as performant as handwritten imperative code. This is because all of the modifications to the graph are type-checked at compile time, and writing to the audio graph is done by taking a bunch of tagless-encoded closures and thunking them one after the other, which is very computationally efficient.
When using an event-based architecture, on the other hand, you put an algebra on top of this performance-critical layer. The algebra is essentially one of many thunks: every operation (map, fold, etc) has an Effect Unit on top of it, and most operations are recomputed because they don’t benefit from the inherent memoization in imperative code. Meaning that when you write:
let a = 1
let b = a+3
let a = b+a
a+b=c

The JS interpreter is able to efficiently memoize the intermediary results. The PS compiler doesn’t even need to do any magic here: it just passes b+a to JS and knows that it will be computed once and only once.
The thunk tax + no-efficient-memoization of events leads to a ~100x slowdown in events vs "normal" code.
OTOH, and in spite of its performance benefits, the annoying part of the current wags are its compile times, the monster types, and the repetitive naming of things.
@PureFunctor's work goes a long way towards helping keep the compile times down, and while it doesn’t solve the monster-type problem, his types are super readable thanks to his work on type-level error messages. I think that, with some extra work and perhaps some tweaks to the PureScript compiler (like memoizing type-level computations), we’ll be able to ergonomically infer types from terms in function signatures (so we don’t have to write out the type and the term all the time) and have those types look readable when we hover over them.
The issue that remains, then, is one of addressing. The elegant thing about the SDOM approach is that, for all its slowness, there is no addressing problem: all changes to a node are bundled with the node’s creation, so you don’t need addresses at all. In wags, on the other hand, you find yourself typing “masterGain.filter3.delay5.gain2.sinOsc4” just to change a sine-wave oscillator. This is a pain and makes it hard to move fast.
The solution here, if there is one, may be tooling. Essentially, what we want to do is highlight a little bit of a row type, press a couple keys, and have it be changed by the outcome of a computation. These are essentially our “patcher cords” from Max/PD/OpenMusic. Here, we move into another realm of type-level programming. Type-level programming already hooks into our console with Warn, but now, we’d need it to hook into our IDE.

Here's one possibility for what a livable alternative could look like:
(e /\ a /\ gain @"g1" 0.1 (sinOsc @"s0" 90.0 :* [sinOsc @"s1" 96.0]))
  @> \e' a' -> a' /\ do
        change @"g1" 1.6
        when e'.time > 3.0
          change @"s0" 880.0

It doesn't solve the naming problem, but it makes them less painful than the current setup.

I've been experimenting with converting some large wags projects to the proposed event-based approach, and one really nice thing about the event-based approach is when dealing with variants. You can flip Event (Variant r) to a record of filtered events as a generalization of partition. In the current wags, things feel more continuation-passing-y, so variants use big match clauses that result in monster records.

Resolved using the new event library's memoization primitives.


Hello, Regarding Training Loss Issue

Thank you for your work!
I have noticed that during training, the loss frequently oscillates between positive and negative values. Is this behavior normal? Or does it indicate an issue with my data or modifications in the code?

Best regards,

Thank you for your attention.
The loss oscillating between positive and negative values is abnormal. I haven't encountered this issue in my own runs, and theoretically, the loss should remain positive. This is likely due to specific code modifications rather than data-related issues. If the main modifications to the code can be provided,  it would make it easier for me to diagnose and resolve the problem.


Run task every 20 seconds?

From reading the docs and a quick look at the code, it seems like 1 minute is the shortest possible interval between tasks. Are there any external obstacles to using seconds instead of minutes as the base time measure for scheduled tasks?

The current design has a heartbeat of 30 seconds, which means the schedule table can't have schedules below that. Most of this is explained in the architecture docs. Because of the way the internal loop is set up, a resolution under a dozen seconds or so, quickly becomes unreliable.
I always imagined tasks that need accuracy measured in seconds, would use a delayed tasks strategy where a few seconds delay is either added through the broker or inside the task itself.
The problem with all this, is that a task is currently always added to the back of the queue.
So even with a 1 second resolution on the schedule, the task still has to wait it's execution time. Which can of course vary wildly depending on the broker type, worker capacity and current workload.

So basically, if I understood correctly, the main concern is that brokers might be too slow. The architecture looks really really nice, but I can't say I fully understand it (yet). For instance, I don't see why adding tasks to the back of the queue would be an issue.
In any case, I have made a few changes to get django-q to use seconds instead of minutes, and if seems to be working well. I'm only trying with the ORM broker.
Here  is the PR: https://github.com/Koed00/django-q/pull/181
It is not really a pull request - rather I'm wondering what might go wrong with these changes? They seem to work quite well for my case (and I intend to use so modified django-q), but I'm interested into why not make it the default behaviour - why limit yourself to 1 minute resolution. Smells of crontab for no reason 😦

BTW, I'll be running it on a Raspberry Pi, with SQLite db. The tasks are going to be quick and need to be run about every 20 seconds. 1 worker should be enough. Avoiding multiple processes (e.g. running Redis) seems like a good idea, that's why using ORM broker.

Regarding the heartbeat, It should be noted that with the introduction of GUARD_CYCLE and the fixed counter in https://github.com/Koed00/django-q/blob/master/django_q/cluster.py#L231 the 30 second heartbeat is not guaranteed. (before this patch the heartbeat seemed to be 15 seconds, 0.5 * 30)
It seems scheduled tasks may incur a significant delay if GUARD_CYCLE is set to >2 seconds.

Has there been any more work/thought/progress on this? I'm currently doing an evaluation of task queues, and django-q is a front runner, but I need to be able to have a task polling the database on a very tight schedule, probably around every 10 seconds.

What's the status of sub-minute tasks with django-q? I'm re-evaluating our tech stack and would love to migrate away from Celery-based tasks, but we need some to run every 15-20 seconds and it seems that this cannot be done with django-q at the moment. Is there a workaround or is this just out of scope here?
I'd also be interested hearing if someone has experience in other Django-based solutions that would do the job. I imagine sub-minute (not sub-second or anything crazy like that) repeating tasks wouldn't be that exotic these days.

Personally I’m just resigned to using Celery, even on projects where it is an overkill of criminal proportions. There are some hacks to make the setup simpler, e.g. https://www.distributedpython.com/2018/07/03/simple-celery-setup/
This method is only viable if you have a single worker and your tasks can tolerate occasional file access conflict, so YMMV.
I find it useful for running a single task every few seconds on a Raspberry Pi, with having the broker directory mounted to a tmpfs path (to reduce wear on the SD card).
For anything larger, Docker is your friend. Or mine, at least :)

In case anyone is still interested in this later on, why not just have the schedule be every 1/2 min and then, in your code, just have a sleep for 20sec (or whatever you need) and call the function/script again (repeated as many times as needed before the next schedule call). Seems simple enough.


View a flashback

Please provide all the information requested. Issues that do not follow this format are likely to stall.
Description
Please provide a clear and concise description of what the bug is. Include screenshots if needed.
Please test using the latest React Native release to make sure your issue has not already been fixed: https://reactnative.dev/docs/upgrading.html
React Native version:
Run react-native info in your terminal and copy the results here.
Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.
1.RN 0.62.2    ios
2.View issue
code:
 return (
        <View style={{width:SCREEN_WIDTH,height:SCREEN_HEIGHT,backgroundColor:'red'}}>
            <View style={{height:40,width:40,backgroundColor:'blue'}}>

            </View>
        </View>
    );

picture:

Please look at the code
Why is the Ui sequence loaded down below
There's nothing wrong with Android
What is the setting of iOS?

Hi @JonsonHI could you fill out all the sections on the issue template and provide a repro?
Also, what device & OS version is the issue happening on?


[TM] Add spec for AndroidToast

Summary
part of #24875
Changelog
[General] [Added] - Add TM spec for AndroidToast
Test Plan
Flow passes

@ericlewis i fixed comments you left, could you review it once again?

@wojteg1337 there are tons of errors here still. Since the library has been changed to conditional you probably need to do invariant checks on wether or not the library exists at existing call sites. Once you get all the tests passing (except e2e, don’t worry about that) I’ll approve.

you have to export something, undefined or null. i dont think there is a specific on witch.
Sent via Superhuman<EMAIL_ADDRESS>)
On Fri, May 17, 2019 at 12:55 PM, Luna <<EMAIL_ADDRESS>> wrote:

@lunaleaps commented on this pull request.
In Libraries/ Components/ ToastAndroid/ NativeToastAndroid. js (
https://github.com/facebook/react-native/pull/24888#discussion_r285207144
) :

message: string, + duration: number, + gravity: number, + ) => void; +
+showWithGravityAndOffset: ( + message: string, + duration: number, +
gravity: number, + xOffset: number, + yOffset: number, + ) => void; +} +
+export default (Platform.OS === 'android' + ?
TurboModuleRegistry.getEnforcing('ToastAndroid') + : null);

Is it odd to export default null ? I wonder if we shoudn't export at all if
iOS
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (
https://github.com/facebook/react-native/pull/24888?email_source=notifications&email_token=AAFEVR4ELLVKD5VF52AUKOTPV3PQTA5CNFSM4HNKWMQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBY7VHRQ#pullrequestreview-239031238
) , or mute the thread (
https://github.com/notifications/unsubscribe-auth/AAFEVRZ67WZG6ISPQHEVEFDPV3PQTANCNFSM4HNKWMQQ
).

its not possible to export nothing i.e., make the export itself conditional
Sent via Superhuman<EMAIL_ADDRESS>)
On Fri, May 17, 2019 at 4:56 PM, Eric Lewis <<EMAIL_ADDRESS>> wrote:

you have to export something, undefined or null. i dont think there is a
specific on witch.
Sent via Superhuman<EMAIL_ADDRESS>)
On Fri, May 17, 2019 at 12:55 PM, Luna < notifications@ github. com (
<EMAIL_ADDRESS>) > wrote:

@lunaleaps commented on this pull request.
In Libraries/ Components/ ToastAndroid/ NativeToastAndroid. js (
https://github.com/facebook/react-native/pull/24888#discussion_r285207144
) :

message: string, + duration: number, + gravity: number, + ) => void; +
+showWithGravityAndOffset: ( + message: string, + duration: number, +
gravity: number, + xOffset: number, + yOffset: number, + ) => void; +} +
+export default (Platform.OS === 'android' + ?
TurboModuleRegistry.getEnforcing('ToastAndroid') + : null);

Is it odd to export default null ? I wonder if we shoudn't export at all if
iOS
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (
https://github.com/facebook/react-native/pull/24888?email_source=notifications&email_token=AAFEVR4ELLVKD5VF52AUKOTPV3PQTA5CNFSM4HNKWMQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBY7VHRQ#pullrequestreview-239031238
) , or mute the thread (
https://github.com/notifications/unsubscribe-auth/AAFEVRZ67WZG6ISPQHEVEFDPV3PQTANCNFSM4HNKWMQQ
).

@ericlewis, I removed the conditional export of turbo module since it's never used in ios.js files. In iOS files, I added stubs to return correct types.

also I'm not sure what causes test_android to fail, could you help me with it?

@wojteg1337 do you have the verbose output of the failing test?

@lunaleaps when I add a verbose flag to the command from test node cli.js bundle --max-workers 2 --platform android --dev true --entry-file ReactAndroid/src/androidTest/js/TestBundle.js --bundle-output ReactAndroid/src/androidTest/assets/AndroidTestBundle.js --verbose the output seems to be the same as the one from CI


New EA Games?

https://github.com/OpenSAGE/OpenSAGE
https://www.openra.net/download/ (detect steam assets?)
~https://github.com/TheAssemblyArmada/Vanilla-Conquer for original games (look at existing vanilla-conquer use)~
alpha centurai?

https://github.com/OpenRA/ra2 (Red Alert 2)
https://github.com/MustaphaTR/Romanovs-Vengeance (modded Red Alert 2 mp)
https://github.com/ABrandau/Shattered-Paradise-SDK (modded Shattered Paradise mp)

Once https://github.com/OpenRA/OpenRA/pull/21355 is ready, then I could add that for the original games. Working on adding Vanilla Conquer
For RA2 & OpenRA, it seems like that hasn't been updated in a while. Will investigate the other two in the future.

I've added vanilla-conquer to both of the new original steam versions, so that should be working now

@d10sfan

For RA2 & OpenRA, it seems like that hasn't been updated in a while. Will investigate the other two in the future.

@ondrejmirtes' RA2 fork seems to be few commits ahead of the main branch and offers an AppImage build.
https://github.com/ondrejmirtes/ra2

@rea987 Yeah, I made the build work in GitHub Actions. But I wholly recommend using https://github.com/MustaphaTR/Romanovs-Vengeance which is actively developed and really awesome! Just spent the last weekend playing it with friends at a LAN party :)

I've added vanilla-conquer to both of the new original steam versions, so that should be working now

The games start, but the folder structure is unsuitable for VanillaRA. Red Alert, for example, crashes when trying to start a campaign, and is unable to read any of the expansion pack campaigns or multiplayer map files.
I would also advise against using OpenRA as anything other than an optional secondary choice, as OpenRA is more of a fan remake that reuses the assets and basic gameplay, but the mechanics and balance are very different in practice to the original games.

Interesting, I'll look into that soon

@hazelnot

I would also advise against using OpenRA as anything other than an optional secondary choice, as OpenRA is more of a fan remake that reuses the assets and basic gameplay, but the mechanics and balance are very different in practice to the original games.

Many if not the most games here use engine re-implementations which aren't exactly the same with the original game. I don't see an issue with OpenRA as an addition. Considering that none of the 2D C&C titles' online multiplayer work properly without patches and/or 3rd party clients, OpenRA is a great convenience for the players.

Considering that none of the 2D C&C titles' online multiplayer work properly without patches and/or 3rd party clients, OpenRA is a great convenience for the players.

We should have LAN working for both TD and RA in Vanilla Conquer but it doesn't have the convenience of easy online multiplayer.
It all boils down to the preferred order and accurate description of both of the engines. VC is based on the original source and strictly about original gameplay while making them portable. ORA is about other conveniences and re-imagined gameplay and is much more mature as a project with a lot more developers behind it.

It's really a matter of prioritizing singleplayer or multiplayer. OpenRA is very multiplayer-focused, and has a very hardcore playerbase in my experience, while missing or reimagining big chunks of the campaigns.
I've never really played C&C online because pretty much everyone doing that has been playing for 20 years, so OpenRA despite the quality of life improvements gets in my opinion even less beginner-friendly.
As far as I'm aware most people who play C&C these days tend to stick with singleplayer for this reason, which is why I said that OpenRA shouldn't be used as a primary/default option.

I looked into RA1 a bit more and talked to some of the vanilla conquer devs
The game was repackaged, and currently vanilla conquer itself doesn't support it out of the box due to some of the different filenames.
I managed to fix the filestructure of the linuxdata-ra folder by creating some new folders and redoing the symlinks (as currently luxtorpeda assumes it's working with the Remastered Collection version of the game)
Basically, main1.mix corresponds to allied/main.mix, main2.mix to soviet/main.mix, main3.mix to counterstrike/main.mix and main4.mix to aftermath/main.mix. The rest of the files are in the game's root directory, so for example ../Data/CNCDATA/RED_ALERT/CD1/EXPAND.MIX simply needs to be redirected to ../EXPAND.MIX
At least until VC gets updated to support this packaging scheme.

@hazelnot nice! Can you send a screenshot or copy paste the directory listing for the games so I can verify how it looks? I can update the setup to match for the non remastered games

Looks like this. HIRES.MIX and LORES.MIX aren't necessary as they're already packed into a different MIX, though I'm not really sure about HIRES1.MIX and LORES1.MIX, which are apparently the icons for units added by The Aftermath. They may or may not be necessary, though I'm not sure.

@hazelnot I've pushed up some changes for the original RA, if you can test it out when you have a chance. I didn't see either of those pal files, but it seems to run ok without them.

I've also added support to the original C&C for OpenRA, and it'll discover the steam installation and put it in the right place, other than the movies.
The steps to get it for manual for ra is pretty complicated (https://gist.github.com/abcdefg30/a4fe1110c2727c3960e340ae2ce45bc0), so I'll leave that alone until the auto-detect is ready (and re-visit cnc)

RA2 (https://github.com/MustaphaTR/Romanovs-Vengeance?tab=readme-ov-file) can be added by creating a link between the ra2 folder and ~/.config/openra/Content/ra2, then grabbing the appimage from https://github.com/MustaphaTR/Romanovs-Vengeance?tab=readme-ov-file, and following the same as the cnc openra.
Looks like tiberium sun could be done similarly with: https://github.com/ABrandau/Shattered-Paradise-SDK/releases

RA2 and Tiberium Sun have been added, ra2 uses the steam assets, tiberium sun you can use the quick install for now.
I believe that's all the games covered that make sense, as OpenSAGE is still a bit too early, but if there's anything else, feel free to comment here or add a new issue. Thanks!

@d10sfan Having Romanov's Vengeance for RA2 is great as it offer new balancing options and units but it's not exactly RA2 or YR but rather an different multiplayer take on the game. It would be nice to have modern and more authentic multiplayer remakes of RA2 and YR. Hence I believe following OpenRA mods can be added;

RA2: https://github.com/OpenRA/ra2

It is called as Red Alert 2 ({DEV_VERSION}) on MP servers list. I compiled this one with Mono 6.12.0. It works fine with Steam assets and there's even an online server available for this build.

https://github.com/cookgreen/Yuris-Revenge/releases

This mod offers Yuri faction and AppImage builds are available.

@d10sfan Yes, listed .mix files need to be put in ~/.config/openra/Content/ra2 and ~/.config/openra/Content/yr .
https://github.com/cookgreen/Yuris-Revenge/wiki/Install-the-content

Thanks that looks like it did the trick. I added yr to the supported ones, for RA2 I'll need to wait for them to release an appimage, as packaging all of the necessary libraries for that project would not be feasible at this point.


Assigning 2 Options with same value fails

Hi,
Couldn't find an answer for this here or at codeplex.
I have these 2 properties:
[Option("IpAddress1")]
public string IpAddress1 { get; set; }
[Option("IpAddress2")]
public string IpAddress2{ get; set; }
and when running with these parameters:
--IpAddress1 "<IP_ADDRESS>" --IpAddress2" <IP_ADDRESS>"
I get the "MissingValueOptionError".
when running with:
--IpAddress1 "<IP_ADDRESS>" --IpAddress2" <IP_ADDRESS>"
everything works fine.
Any idea why?

It looks like it has something to do with setting the "_.IgnoreUnknownArguments = true;" :
at:
new Parser(
_ =>
{
_.CaseSensitive = false;
_.HelpWriter = helpWriter;
.IgnoreUnknownArguments = true;
}).
ParseArguments(commandLineArguments).
WithParsed( => parsedFromCommandLineArguments = ).
WithNotParsed(
_ =>
{
parseSucceeded = false;
if (.Any(
__ => __.Tag == ErrorType.HelpRequestedError ||
__.Tag == ErrorType.HelpVerbRequestedError))
{
isHelpRequestedDetected = true;
}
});

Its possible that this is related to issue #277 too

I ran into the same problem and constructed a minimal example causing the problem.
Code
It seems to be related to the normalization in the Tokenizer (Tokenizer.Normalize).
Both cases result in an emtpy set of toExclude tokens but somehow in the case of
duplicated values it deletes one of the values causing the error in the end.
I assume the error is that Except returns distinct results.
https://msdn.microsoft.com/en-us/library/bb300779(v=vs.100).aspx (see comments)
Pull Request

Hi @b0urb4k1 your pull request looks great. Can you add two unit tests based on your minimal example? One that tests workingArgs (as the baseline) and another testing failingArgs.

I added the tests as requested.

Merged. Thank you for your contribution, @b0urb4k1!


Fatal error while pulling node image

Hello,
Straight to the chase:
Docker version 1.6.2, build 7c8fca2

$ docker pull node
Pulling repository node
4797dc6f7a9c: Error pulling image (latest) from node, Driver aufs failed to create image rootfs 7a3871ba15f89cd1e26daca15d6ee121d94e6eea1db3e209770d02a2561e6f59: open /mnt/sda1/var/lib/docker/aufs/layers/df2a0347c9d081fa05ecb83669dcae5830c67b0676a6d6358218e55d8a45969c: no such file or directory 8218e55d8a45969c: no such file or directory ete
7a3871ba15f8: Error downloading dependent layers
FATA[0021] Error pulling image (latest) from node, Driver aufs failed to create image rootfs 7a3871ba15f89cd1e26daca15d6ee121d94e6eea1db3e209770d02a2561e6f59: open /mnt/sda1/var/lib/docker/aufs/layers/df2a0347c9d081fa05ecb83669dcae5830c67b0676a6d6358218e55d8a45969c: no such file or directory

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

@raqystyle can you try again- I'm unable to reproduce this using the latest.

@duglin Excuse for a huge delay. It was something wrong with my setup. Now it's all gone. Thank you very much for your attention!


Signature to pass to contract

Hi.
The solution you suggesting is really nice but i can't understand the one thing, the signature needed is sig.length = 65 and i can't find out how to generate the signature using Web3.
when i use web3.eth.sign() i get sig.length = 134 and I'm not sure what the parameters i need to pass to the sign() function.
Can you explain how to generate the signature?
Thanks.

hi @HadarKeidar.
Maybe the tests can help you understand how to create the signature: https://github.com/PROPSProject/props-token-distribution/blob/a1a7488581e74e9c66b44a19edd7ff7caa792109/test/PropsToken.js#L87
Does it help?
Best

Yes it helped.
Thank you.


Exception while parsing header of batch request

Lately we have an issue with a batch request to GMail API that worked before. We get a list of all labels a user has in gmail with the first request, then we create a batch to get details for all labels.
Environment details

OS: Debian Linux Server
PHP version: 7.3.33
Package name and version: google/apiclient 2.12.1

Steps to reproduce

Get list of all user labels using users_labels->listUsersLabels('me')
Create batch with single calls to users_labels->get() after calling setUseBatch before.
Execute batch with execute() method
Throws an exception during parsing of headers

Further details
In my opinion, there is an issue with the resulting header of the batch requests, and the parsing inside the PHP client.
Here is a snipped of a single batch result
--batch_KrShUDjgnVv3chxBsrI2iopwhvYu4fjU
Content-Type: application/http
Content-ID: response-1730032590

HTTP/1.1 200 OK
Content-Type: application/json; charset=UTF-8
Vary: Origin
Vary: X-Origin
Vary: Referer

{
  "id": "IMPORTANT",
  "name": "IMPORTANT",
  "messageListVisibility": "hide",
  "labelListVisibility": "labelShow",
  "type": "system",
  "messagesTotal": 204,
  "messagesUnread": 0,
  "threadsTotal": 187,
  "threadsUnread": 0
}

--batch_KrShUDjgnVv3chxBsrI2iopwhvYu4fjU

There are multiple Vary header in the response compared to official docs where these headers are missing:
https://developers.google.com/gmail/api/guides/batch#batch-example-response
Inside src/Http/Batch.php  in parseRawHeaders method these headers are combined using \n.
When debugging further, we get to src/MessageTrait.php and the trimAndValidateHeaderValues method.
There is a line with $this->assertValue($trimmed); where inside there is a check for allowed characters and \n seems not to be allowed.
If we change the concat from \n to , it would run.

I've done a bit of further digging on this (since it's broken our app entirely).
I think this is actually related to a recent change in guzzlehttp/psr7 (https://github.com/guzzle/psr7/blob/2.2.1/CHANGELOG.md).
Temporarily forcing guzzle/psr7 to v2.1.0 in composer.json seems to do the job of fixing this (because it removes the newly added header validation). Unfortunately this is not a safe thing to do, thanks to this: https://github.com/guzzle/psr7/security/advisories/GHSA-q7rv-6hp3-vh96
Making the change suggested by @brainformatik would solve the issue properly.

If we change the concat from \n to , it would run.

Headers should not be concatenated, but passed as an array. See my response in this issue for guzzlehttp/psr7:
https://github.com/guzzle/psr7/issues/494#issuecomment-1075520105

Isnt the bug not in the SDK but the API itself? If i look at the definition it seems that the Vary header needs to be comma seperated?
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Vary
For now we just receive multiple Vary headers. I have to admit that this is not my overall expertise area on how the spec works on this. Maybe @TimWolla knows something about this?

Isnt the bug not in the SDK but the API itself? If i look at the definition it seems that the Vary header needs to be comma seperated?

The API is fine, this is defined in RFC 7230#3.2.2:

A sender MUST NOT generate multiple header fields with the same field
name in a message unless either the entire field value for that
header field is defined as a comma-separated list [i.e., #(values)]
or the header field is a well-known exception (as noted below).

and further

A recipient MAY combine multiple header fields with the same field
name into one "field-name: field-value" pair, without changing the
semantics of the message, by appending each subsequent field value to
the combined field value in order, separated by a comma.

The Vary header is defined to be a comma-separated list of values and thus may be split across multiple header fields with the same header name.
If an array doesn't work, then concatenating them with a comma is fine according to the spec, but set-cookie is the one header where this will break semantics. A newline (like it is currently implemented) is never correct and rightfully rejected by Guzzle.

I am also facing issues with the Google API client.
The following error is received by Guzzle when I perform batch requests.
 InvalidArgumentException

  "Origin
X-Origin
Referer" is not valid header value

  at vendor/guzzlehttp/psr7/src/MessageTrait.php:263
    259▕         // Clients must not send a request with line folding and a server sending folded headers is
    260▕         // likely very rare. Line folding is a fairly obscure feature of HTTP/1.1 and thus not accepting
    261▕         // folding is not likely to break any legitimate use case.
    262▕         if (! preg_match('/^[\x20\x09\x21-\x7E\x80-\xFF]*$/', $value)) {
  ➜ 263▕             throw new \InvalidArgumentException(sprintf('"%s" is not valid header value', $value));
    264▕         }
    265▕     }
    266▕ }

It seems that problem is that Guzzle doesn't allow headers with break lines.

Hi, I just stumbled upon this issue too. Is there any way we can work around this?

Hi, I just stumbled upon this issue too. Is there any way we can work around this?
For now I did a composer require guzzlehttp/psr7:2.1.0

Wait till a maintainer resolves the open pr i guess

fixed in v2.12.2


pr2_robot: 1.6.16-0 in 'indigo/distribution.yaml' [bloom]

Increasing version of package(s) in repository pr2_robot to 1.6.16-0:

upstream repository: https://github.com/pr2/pr2_robot.git
release repository: https://github.com/pr2-gbp/pr2_robot-release.git
distro file: indigo/distribution.yaml
bloom version: 0.5.21
previous version for package: 1.6.10-4

Can you please close #10685 if it is obsolete.


code is still running and not taking any input

Type: Bug
Running any code and trying to give an input to the program is not possible as its stuck and isn't responding. And if we stop the code it gives "exited with code=1 in x seconds"
VS Code version: Code 1.77.3 (704ed70d4fd1c6bd6342c436f1ede30d1cff4710, 2023-04-12T09:16:02.548Z)
OS version: Windows_NT x64 10.0.22623
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-9300H CPU @ 2.40GHz (8 x 2400)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
7.84GB (1.01GB free)

Process Argv
--crash-reporter-id 21bb31d5-4769-4861-9043-36480220a875

Screen Reader
no

VM
0%

Extensions (14)

Extension
Author (truncated)
Version

vscode-html-css
ecm
1.13.1

code-runner
for
0.12.0

python
ms-
2023.6.1

vscode-pylance
ms-
2023.4.40

jupyter
ms-
2023.3.1201040234

jupyter-keymap
ms-
1.1.0

jupyter-renderers
ms-
1.0.15

vscode-jupyter-cell-tags
ms-
0.1.8

vscode-jupyter-slideshow
ms-
0.1.5

material-icon-theme
PKi
4.27.0

material-product-icons
PKi
1.5.0

LiveServer
rit
5.7.9

html5-boilerplate
sid
1.1.1

JavaScriptSnippets
xab
1.8.0

(2 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
nodejswelcome1:30587005
282f8724:30602487
pyind779:30671433
89544117:30613380
pythonsymbol12:30671437
showlangstatbar:30730054
vsccsb:30705552
azdwalk:30721579
pythonms35:30701012
pythonfmttextcf:30716743
pythonclientmvcf:30725893
fixhidewlkth:30730051

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

I'm not able to enter any input to my terminal after writing a code and if I stop the code from running it shows this message "exited with code=1 in 8.507 seconds"

The output view isn't a terminal but just a readonly view. Try the terminal to the side of it. Unsure how you got the output but it must have been via an extension. Please follow up with the authors of those extensions

Thanks for the help, terminal works fine


How to fixt this

Ignore that error, its bug in discord.js i guess.
Is the player command working after this error?


Change mongodb extension installation instructions

resolves drud/ddev-contrib#69
Installing MongoDB php extension via webimage_extra_packages config option instead of altering Dockerfile

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Shoot, you didn't mention the issue in the title, or mention this in the issue I don't think, so I redid it with more stuff. Could you please look at #83. #83 does add much more finesse to the docker-compose.mongo.yaml.

@rfay Looks good, thx!

Thanks for taking a look!


Add Docker as a service to CI for functional testing

Description

Test Docker as a service by pulling a sample Docker image and running it.
Compose a Docker environment for Alloy for functional testing.
Replace the placeholder image. Add composer to Travis pipeline to install dockerfile in repo.

Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Requested QOS number to create public hosting account
Once QOS is approved for Alloy, will create a request on CAMP for public hosting / domain.


Overwrite the default batch file on windows

This will overwrite the now.cmd file on windows with the path to direct executable.
This will allow us to use a default fallback script if the postinstall script will not execute. And since it is overwriting the default now.cmd file it will directly call the executable without loading node.exe first.

Good. Have you tried publishing to some unused name and installing to Windows?

Codecov Report

Merging #1922 into canary will increase coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           canary   #1922      +/-   ##
=========================================
+ Coverage    6.35%   6.61%   +0.25%
=========================================
  Files          91      91
  Lines        4062    4069       +7
=========================================
+ Hits          258     269      +11
+ Misses       3804    3800       -4

Impacted Files
Coverage Δ

src/util/read-metadata.js
100% <0%> (ø)
:arrow_up:

src/util/get-project-name.js
100% <0%> (ø)
:arrow_up:

src/util/hash.js
100% <0%> (ø)
:arrow_up:

src/util/error.js
100% <0%> (ø)
:arrow_up:

src/util/get-files.js
100% <0%> (+3.1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4337f0b...22bbcc4. Read the comment docs.

@igorklopov I created a tarball with npm pack and installed that with npm i -g ./now.tgz. I don't think there is any difference in doing that and doing npm i -g now.

Ok 👌


[Bug Report] When the Input type = "number" is input in Chinese, the cursor will be positioned upwards.

Element UI version
2.4.7
OS/Browsers version
mac/chrome 69
Vue version
2.5.17
Reproduction Link
https://jsfiddle.net/3w4aqx2o/
Steps to reproduce
When the Input type = "number" is input in Chinese, the cursor will be positioned upwards.
What is Expected?
the cursor will be positioned center.
What is actually happening?
the cursor will be positioned upwards.

@x710894881 Maybe it's a bug of the web browser. https://jsfiddle.net/3w4aqx2o/1/

@ziyoung It the matter of line-height: https://stackoverflow.com/questions/15603197/how-to-solve-buggy-line-height-on-input-fields

The fix plan will import lots of breaking changes, maybe we can solve it in Element 3.0 later.


Divider component in code

Following spec from #3320

New component
Test
Site doc
Storybook

To be released, lab to core merged in #3543

added example for divider in AG grid statusBar and Overlay - with Actions

Released in<EMAIL_ADDRESS>


Convert atomic Int64 to native type when logging value

The atomic Int64 type wasn't able to be represented when logging
via go-kit log and ended up as "unsupported value type".
Signed-off-by: Nick Pillitteri<EMAIL_ADDRESS>

Example of what this log line looked like before this fix:
level=info ts=2021-12-03T17:32:28.453017285Z caller=head.go:705 org_id=team-b msg="Exemplar storage resized" from=0 to="unsupported value type" migrated=0

The windows test failure seems unrelated. Could you please rebase your branch on top of latest main branch?

Thank you!


Chore: Removed unused code from old interface

@tdashworth - coverage falls slightly below 80% after merge. But let's merge in and then I'm happy to do another PR that adds tests where the code is lightly tested?


Performance v 2.2.2

Issue description:
https://spark.lucko.me/#exNtnGPNkN

Version (make sure you are on the latest version before reporting):

Minecraft: 1.12.2
Forge: latest
Refined Storage: 2.2.2

Does this issue occur on a server? [yes/no] yes

Do you have a spark with 2.2.1? This by itself doesn't say much

Do you have a spark with 2.2.1?

maybe this https://spark.lucko.me/#56ACPHcDZW

Closing this for now, because there's nothing of significance in both sparks


aprior formular

Hello,
I have a question regarding the aprior function,
From the equation that is shown in Johnson 2007

y=(2s2+m^2)/s2 in the aprior function confused me,
if I understand it correctly, should it be written as
y=(2s2+m)/s2?
zhipeng

There's actually a typo in the original Johnson 2007 paper equation; if you solve the equations in their supplementary material, you'll find that lambda = (V^2+2S^2)/S^2.
Both the ComBat original code implementation and our code implementation use the correct formula, so all good!


Unresolved Yeoman.yeomanSettings  in the 0.9.0

Hi,
I am upgrading play-java app to play 2.5. My build.sbt file cant find the yeomanSettings when configured as in documentation for 0.9.0 tuplejump.
val appSettings = Seq(version := appVersion, libraryDependencies ++= appDependencies) ++
Yeoman.yeomanSettings
But I got it working by changing  it to
Yeoman.projectSettings
Is this a documentation mistake?

Starting from 0.9.0, the plugin is an auto-plugin. Please make sure you enable the plugin. Refer the demo to make sure you got it right. If it doesn't work even after that, please share your build file or a sample project for us to look into.

Thanks for the reply.My build.sbt was like this.
lazy val root = (project in file(".")).enablePlugins(PlayJava, Yeoman, PlayEbean).settings(
Yeoman. yeomanSettings: _*
}
I removed the settings part and it is working.I think for the 0.9.0 auto plugin version, we do not need to call
.settings(
Yeoman. yeomanSettings: _*
}
(I got confused with the following line in documentation
Note: If you're using build.sbt instead of the full scala build, you need to place the 2 additions above into build.sbt as follows:)
Please correct me if I am wrong...
Thanks

@nuwan1025 After the note, you need to check the sample code for the corresponding version

When I run the application as an play app in my ide it worked fine. But when I try to package it with activator dist command, it doesnt package the ui part. Hence the grunt file is not read.
(Configured build.sbt as in the documentation)
I found the solution for that and it is working fine for me.
lazy val root = (project in file(".")).enablePlugins(PlayJava, Yeoman, PlayEbean).settings(
com.tuplejump.sbt.yeoman.Yeoman.projectSettings: _*
)

@shiti I was running into the same issue as @nuwan1025 and was able to fix it with his workaround

I too faced the same issue as @nuwan1025 and was able to fix it with his workaround. This should be documented as I feel it's relevant to #86, #90, and #95

@nuwan1025 Thank you for this workaround!


Allow fast access to most recent sample

For federation in Prometheus we want fast access to the most recent sample. This is currently not served by the interface we have which only allows forward-streaming access to a series for a time window.
That's the interface actually reflecting properly how data is stored in the database. We do have an efficient cache of the most recent sample but that is strictly speaking an implementation detail. Meaning: extending the SeriesIterator interface by a Last() call would seem like a workaround at best.
First, need for such a fast access should be benchmarked again in context of the new storage. If it turns out to still be necessary, I'm leaning towards exposing the in-memory block type and making it accessible – potentially as yet another interface.
The federation layer would then use this instead of the general SeriesIterator interface.
Sounds sane? @beorn7 @brian-brazil

With atomicity and staleness handling, which I hope to get in with the new storage for 2.0, I can see this requiring more involved logic which makes considerations around the current implementation largely moot.
Let's get something working, and then benchmark.

Federation does work modulo #10 which can cause duplicate entries for overlapping selectors right now. So yes, this is is a low priority issue for now.

Just two thoughts at this point (not much time to dig deeper):

The fast access path for the last sample was not only motivated by federation but also by the fact that rule evaluation are often just accessing the last sample of a series.

Given that allocation churn of the query layer seems a problem right now, I could imagine that a low-alloc access path to the last sample would help here (note that many advanced setups have a huge amount of rule evaluations going on all the time). (This is based on naïve code reading if how the iteration for for federation works. Might be all wrong.)

The fast access path for the last sample was not only motivated by federation but also by the fact that rule evaluation are often just accessing the last sample of a series.

To my knowledge rule evaluations are just regular queries and do not make us of the particular storage call. The query engine does not use it internally either.
I'd argue that almost all rule evaluations that are relevant in cost, use time aggregation anyway and it doesn't apply.

Given that allocation churn of the query layer seems a problem right now, I could imagine that a low-alloc access path to the last sample would help here (note that many advanced setups have a huge amount of rule evaluations going on all the time). (This is based on naïve code reading if how the iteration for for federation works. Might be all wrong.)

Not so much of a problem. Just way higher than it would need to be. The allocs don't relate so much to access but to what the QE allocates itself. v2 also allocates internally when being queried, but that's not happening in v3.

Storage v2 transparently returns an "instant" series iterator for an instant query with a timestamp beyond the end of a series.
But yes, range queries obviously cannot benefit from that.

As per reports federation actually works faster already and there's currently no need for adding complexity of the fast access.


Private field without a property does not work

I have tried to use this sample
Fields without a property with an XUnit test, with inmemory SQLite database but it does not work. _validatedUrl is never set with values from database, wheter it is private or public.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2e162696-b19f-d73f-8b1f-d1b4c3048b62
Version Independent ID: a83e4fb5-e4ae-a46f-7248-487ea2679ac5
Content: Backing Fields - EF Core
Content Source: entity-framework/core/modeling/backing-field.md
Product: entity-framework
GitHub Login: @rowanmiller
Microsoft Alias: divega

I have the same issue.

I'm getting this: The specified field '_validatedUrl' cannot be used for the property 'Url' because it does not match the property name.


Added LazyBsonDocument and made SinkDocument key/values lazily decoded.

KAFKA-45
https://evergreen.mongodb.com/version/5e84aa5a7742ae7105ed9ccd

Updated.  For context: Sink Records have both a Key value and a Value value.
Most the time the connector only cares about the value part and ignores the key part. However, at present if the key is not convertible into a document it will fail.  This requires the user to do an extra Kafka configuration step to make the key convertible (via a Single Message Transform). It also throws a cryptic error to the user about what to do.
Often keys are used as a partitioning values for Kafka - so are message metadata that isn't stored by the sink connector at all.
In short this change makes life easier for users.


Added the custom-reward-id properties

As mentioned in #73 IRC messages can contain the GUID of custom channel point redeems if they prompt the user to send a message with them.
I hope the enum and property placement is fine
If a test is needed, should I add a new one or extend the "Construct" one?

Looks great. You can add a new test similar to PrivmsgTests.WithBits(). As well as adding { (int)Tags.CustomRewardId, "custom-reward-id" }, here

Sorry for the delay, life™ happened, hope this is fine, I just copy/pasted the one from the construct test and then inserted the reward id at the position I saw in the raw message

All good. Thank you for your contribution


Lack of update path

When attempting to update pg_prometheus:
ERROR:  extension "pg_prometheus" has no update path from version "0.0.1" to version "0.2"

I had to place an empty 0.0.1--0.2.sql file in the extension directory as suggested by @niksajakovljevic to work around it.

I'm seeing the same problem when trying to update to 0.2.1.
I've tried the suggested work around, placed a an empty file at /var/lib/postgresql/9.6/main/0.0.1--0.2.1.sql, but the error is still there.

@momania Not sure if that's the proper folder to store it? I guess the file should be named pg_prometheus--0.0.1--0.2.1.sql and should be stored where the rest of extensions sql scripts are: for PG10 thats ./share/extension/

Ah go it!
For reference: $SHAREDIR by looking at the output of pg_config
In my case, creating empty file /usr/share/postgresql/9.6/extension/pg_prometheus--0.0.1--0.2.1.sql did the trick.


Copying and pasting with shellhost code fails

For some reason when copy and pasting into the shellhost connection, it prints out a number of empty lines.

This is closed due to the removal of shell-host code, in favor of a more simple solution


Pass self variable to condition lambda in def_class_method_mock

def_class_method_mock decorator is used in test benches to mock a method. It takes an argument condition, a lambda returning a flag denoting whether the method is ready to run. The problem is that this lambda is expected not to take any arguments, but def_class_method_mock is meant to be used to wrap methods, so a variable self would be very useful (to access objects variables).

Fixed by #272


Can't find the assistant's answers in the history

Describe the bug
Hello,
I updated my prod with last commit "3a6c7b7", and since then, the assistant's response history is no longer being saved in the database.
Do you have any idea?

I noticed this yesterday also, but since no one was talking about it I thought it might have been some other change I had done. The issue is coming from the change at line 655 in Chat.tsx. It is causing history/update to never fire so it isn't saving the assistant response.

Oh ok, thank you for your response!
Do you think the patch will be able to be deployed to the main branch soon?


Automated cherry pick of #4258: feature: add domain usage with prefix "domain."

Cherry pick of #4258 on release/2.13.
#4258: feature: add domain usage with prefix "domain."

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.13@69f9698). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/2.13   #4259   +/-   ##
==============================================
  Coverage                ?   6.86%
==============================================
  Files                   ?     519
  Lines                   ?   88131
  Branches                ?       0
==============================================
  Hits                    ?    6052
  Misses                  ?   81580
  Partials                ?     499

Flag
Coverage Δ

#aFlag
6.86% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69f9698...aca3da0. Read the comment docs.

/lgtm
/approve


Bugfix: Empty and Any markers saved to lockfile

When locking some private packages of ours (that have extras) it used to copy those extras over in 1.0.0b3 when we changed that behaviour it's now the Any marker and when it stringifies that when generating the lockfile it creates a format the lockfile doesn't support.
bugfix: Originally, the MarkerUnion didn't correctly respond to is_any or is_empty because it didn't evaluate the collection of markers which led to it trying to stringify those markers.
This on conjunction with the other fix means that the [Any, Any] case is simply excluded from the lockfile just like a single Any case.
bugfix
Before:
' or '.join([Any, Any]) -> ' or '
' or '.join([Any, REAL MARKER]) -> ' or REAL MARKER'
' or '.join([Empty, Empty]) -> '<empty> or <empty>'
Now
' or '.join([Any, Any]) -> ''
' or '.join([Any, REAL MARKER]) -> 'REAL MARKER'
' or '.join([Empty, Empty]) -> ''
This means if we have a mix of markers with any/empty that won't be propagated to the lockfile.

@sdispater thoughts?

@finswimmer I see you're also able to commit on this repo, any thoughts?

Same for empty?

@JBKahn No, it's fine for is_empty() since all markers must be empty for the union to be empty as well.

K, then I think with that test change, this should be good for the next release?

@sdispater on a side note, I'm not super familiar with the code yet but if you're looking for help maintaining poetry, I'm happy to give some time to the project.


Fix for crash with KeyError on certain regex

Fixes #605

@rlouf Simple crash fix

Added regression test case, which fails before the fix: test_regression_regex_missing_final_state
Apparently test_regex has to be fixed to expect the final state in states_to_token_maps. I think that test case was wrong, that's why the bug wasn't detected originally.
With the fix applied test_regex_vocabulary_error fails, because it does not get the expected exception. I think the following check is fishy in RegexFSM.__init__:
            # We make sure that it is possible to generate strings in the language
            # of the regular expression with the tokens present in the model's
            # vocabulary.
            if not any(
                regex_fsm.finals.intersection(v.values())
                for v in states_to_token_maps.values()
            ):
                raise ValueError(
                    "The vocabulary does not allow us to build a sequence that matches the input regex"
                )

I think such tests should not remain in the production code, but go into test cases.
Also, the cacheable_vocabulary argument of the create_states_mapping inner function is not used at all, which seems to point to unfinished code here not properly tested before.

After this fix it works better, but now I see an unrelated issue with long/complex regex constraints. New ticket: #610

I think the core issue is that a recent change removed the actual FSM final states from RegexFSM's set of final states. This must have caused the issue that you observed. I will revert this change and add your test case to see if it runs. I will also add a test case for when a regex leads to a FSM with several final states.

Should be fixed by https://github.com/outlines-dev/outlines/pull/734. Closing for now.


sorl-thumbnail does not save photo or save to key/value store

Hi I'm having a weird problem. sorl-thumbnail does not report any errors for this, I have TUMBNAIL_DEBUG = TRUE. When I call get_thumbnail like so
thumb = get_thumbnail(image, '100x100')

I actually get a result. And if I then request the url
>>> thumb.url
>>> '/media/cache/54/88/5488098dc3e08824918a06aff19b6962.jpg'

I get an url. But when I look for this image at the location it tells me, I find no photo.
Also I check for keys in redis database, nothing.
I originally thought this was some kind of key/value store conflict because I'm using
redis for caching as well, so I moved thumbnail redis to another server. But this does not change anything.
My configs?
I just have THUMBNAIL_REDIS_HOST set with the ip I'm pointing it towards
otherwise my configs have default settings, 6379 as port and 0 as redis-db

I am experiencing a similar issue. In most cases, the scaled images are created on disk, but sometimes, they are not. I am also using the get_thumbnail method, not the template tag.
I dont have any special config, except a custom Storage Backend, which only refines the storage location.

class Storage(FileSystemStorage):

    def __init__(self, *args, **kwargs):
        super(Storage, self).__init__(*args, **kwargs)
        self.location = settings.CUSTOME_FILE_STORAGE_PATH

I'm not sure what this was but after restarting redis and cleaning up obvious javascript errors in my code I got it working again. I'm closing this @tonimichel I hope you are fine with this, feel free to open it again if you still have this issue.


console spam network serialization

can we get rid of this please. (config option if you want)

This was already fixed in the latest alpha. Just update the mod :)

You need to update past 6.0.6-alpha, duplicate of #391


Receiving deprecation messages

I was receiving the following messages in my Symfony installation:
Defining the getGlobals() method in an extension is deprecated without explicitly implementing Twig_Extension_GlobalsInterface.

And:
Defining the initRuntime() method in an extension is deprecated. Use the `needs_environment` option to get the Twig_Environment instance in filters, functions, or tests; or explicitly implement Twig_Extension_InitRuntimeInterface if needed (not recommended).

I managed to track the issues down by patching the following two classes to have them implement the required interfaces:
namespace Assetic\Extension\Twig;

class AsseticExtension extends \Twig_Extension implements \Twig_Extension_GlobalsInterface

And:
namespace Symfony\Bridge\Twig\Extension;

class FormExtension extends \Twig_Extension implements \Twig_Extension_InitRuntimeInterface

But I have no easy way to make these permanent other than to create a fork etc. They seem very simple changes, at least I think, it would be great to have them added in a next release. They are currently adding a lot of overhead to my logs. I.e. this is what a full message looks like:
[2015-11-03 13:41:11] php.INFO: Defining the initRuntime() method in an extension is deprecated. Use the `needs_environment` option to get the Twig_Environment instance in filters, functions, or tests; or explicitly implement Twig_Extension_InitRuntimeInterface if needed (not recommended). {"type":16384,"file":"/home/example/portal/vendor/twig/twig/lib/Twig/Environment.php","line":740,"level":28928,"stack":[{"function":"handleError","class":"Symfony\\Component\\Debug\\ErrorHandler","type":"->"},{"file":"/home/example/portal/vendor/twig/twig/lib/Twig/Environment.php","line":740,"function":"trigger_error"},{"file":"/home/example/portal/vendor/twig/twig/lib/Twig/Environment.php","line":408,"function":"initRuntime","class":"Twig_Environment","type":"->"},{"file":"/home/example/portal/vendor/symfony/symfony/src/Symfony/Bridge/Twig/TwigEngine.php","line":126,"function":"loadTemplate","class":"Twig_Environment","type":"->"},{"file":"/home/example/portal/vendor/symfony/symfony/src/Symfony/Bridge/Twig/TwigEngine.php","line":50,"function":"load","class":"Symfony\\Bridge\\Twig\\TwigEngine","type":"->"},{"file":"/home/example/portal/vendor/symfony/symfony/src/Symfony/Bundle/TwigBundle/TwigEngine.php","line":72,"function":"render","class":"Symfony\\Bridge\\Twig\\TwigEngine","type":"->"},{"file":"/home/example/portal/vendor/symfony/symfony/src/Symfony/Bundle/TwigBundle/TwigEngine.php","line":97,"function":"render","class":"Symfony\\Bundle\\TwigBundle\\TwigEngine","type":"->"},{"file":"/home/example/portal/src/Roboteye/Bundle/PortalBundle/Controller/IndexController.php","line":13,"function":"renderResponse","class":"Symfony\\Bundle\\TwigBundle\\TwigEngine","type":"->"},{"function":"indexAction","class":"Roboteye\\Bundle\\PortalBundle\\Controller\\IndexController","type":"->"},{"file":"/home/example/portal/app/bootstrap.php.cache","line":3109,"function":"call_user_func_array"},{"file":"/home/example/portal/app/bootstrap.php.cache","line":3071,"function":"handleRaw","class":"Symfony\\Component\\HttpKernel\\HttpKernel","type":"->"},{"file":"/home/example/portal/app/bootstrap.php.cache","line":3222,"function":"handle","class":"Symfony\\Component\\HttpKernel\\HttpKernel","type":"->"},{"file":"/home/example/portal/app/bootstrap.php.cache","line":2444,"function":"handle","class":"Symfony\\Component\\HttpKernel\\DependencyInjection\\ContainerAwareHttpKernel","type":"->"},{"file":"/home/example/portal/web/app_dev.php","line":28,"function":"handle","class":"Symfony\\Component\\HttpKernel\\Kernel","type":"->"}]} []

Thanks.

Regarding FormExtension, it has nothing to do with Assetic. It is not part of Assetic.
Regarding the AsseticExtension, it should indeed be updated. Please send a pull request updating the extension (and bumping the min requirement to Twig 1.23)

Ah. My bad re. the FormExtention. I was doing a Sublime search over multiple files. I must have assumed the FormExtention was part of Assetic. I will take this up with the Symfony guys.. :)

The full path of the specific files are:
vendor/kriswallsmith/assetic/src/Assetic/Extension/Twig/AsseticExtension.php
and
vendor/symfony/symfony/src/Symfony/Bridge/Twig/Extension/FormExtension.php

Closing because https://github.com/kriswallsmith/assetic/pull/772 fixed the deprecation in AsseticExtension (and the issue in FormExtension is already fixed in Symfony)


[D3D9] NFS Carbon: graphics issue

D9VK
http://www.img.tpx.cz/uploads/WITH D9VK.png
http://www.img.tpx.cz/uploads/WITH D9VK 2.png
WineD3D
http://www.img.tpx.cz/uploads/WITHOUT D9VK.png
http://www.img.tpx.cz/uploads/WITHOUT D9VK 2.png
Software information
Need for Speed: Carbon Collector's Edition (PC DVD), max settings with anti-aliasing.
With WineD3D it works correctly, with d9vk it has graphical issues, i have tested previous versions of d9vk and the same problem occurs.
System information

GPU: GTX 650 (Stock Clock)
Driver: 440.36 (Linux)
Wine version: 4.21
DXVK version: v1.5-19-gfae99907

Apitrace file(s)

https://drive.google.com/open?id=1sHUHBgXRol-4oisU5UYLjtkH63TXC1Q8

Log files

NFSC_d3d9.log

Can you please try with native d3dx9 and d3dcompiler_43 and d3dcompiler_47
(You can use winetricks/protontricks)

Thank you Joshie! Now it's working 100%, until my fps has increased, have a good night.
http://www.img.tpx.cz/uploads/NFSCarbonPrint01.png
http://www.img.tpx.cz/uploads/NFSCarbonPrint02.png

After playing for a long time and completing 100% NFS Carbon, I came across some problems showing that installing the native version of 3dx9 and d3dcompiler_43 and d3dcompiler_47 by winetricks was not efficient:
Sometimes the texture error e is not rendered correctly:
http://www.img.tpx.cz/uploads/NFSCarbonBug01.png
http://www.img.tpx.cz/uploads/NFSCarbonBug02.png
http://www.img.tpx.cz/uploads/NFSCarbonBug03.png
I found that disabling MotionBlur solves the rendering problem:
Menu Conf:
http://www.img.tpx.cz/uploads/NFSC01.png
MotionBlur ON:
http://www.img.tpx.cz/uploads/NFSC02.png
MotionBlur OFF:
http://www.img.tpx.cz/uploads/NFSC03.png
There is a camera bug with D9VK that doesn't happen with WineD3D:
http://www.img.tpx.cz/uploads/NFSCarbon-D9VK.png
http://www.img.tpx.cz/uploads/NFSCarbon-WineD3D.png

Hi, please provide an apitrace for these bugs.

Please re-test and feel free to re-open if you find any more bugs.

Hello Josh, playing for a while is what I could observe:
The problem with camera and cutscene have been fixed:
http://www.img.tpx.cz/uploads/NFSC-CanFix.png
http://www.img.tpx.cz/uploads/NFSC-CutsceneFix.png
But it may happen that I open Need For Speed and eventually the texture disappears and turns black:
http://www.img.tpx.cz/uploads/NFSCTextureBug01.png
http://www.img.tpx.cz/uploads/NFSCTextureBug02.png
http://www.img.tpx.cz/uploads/NFSCTextureBug03.png
http://www.img.tpx.cz/uploads/NFSCTextureBug04.png

Hello Josh, playing for a while is what I could observe:
The problem with camera and cutscene have been fixed:
http://www.img.tpx.cz/uploads/NFSC-CanFix.png
http://www.img.tpx.cz/uploads/NFSC-CutsceneFix.png
But it may happen that I open Need For Speed and eventually the texture disappears and turns black:
http://www.img.tpx.cz/uploads/NFSCTextureBug01.png
http://www.img.tpx.cz/uploads/NFSCTextureBug02.png
http://www.img.tpx.cz/uploads/NFSCTextureBug03.png
http://www.img.tpx.cz/uploads/NFSCTextureBug04.png

Can you send me logs of a play session where this happened?

Yes, here:
NFSC_d3d9.log

Hmmm, I'm not entirely sure why then...

Me too, but there's one thing, I use it in my game:
https://github.com/AeroWidescreen/NFSCHDReflections
I think "maybe" this is not causing this problem, or is it?

Hi Josh, I want to thank you for the support and say that the texture is gone and black because of the HD Reflections.

ah


AppTP remote config 2/N - Define/parse json model

Task/Issue URL: https://app.asana.com/0/0/1202005414608950/f
Description
[stacked PR]
This PR defines and parses the JSON model for the AppTP remote configuration. See privacy_config.json file, in particular the appTrackerProtection json object.
The PR has the following plugins:

AppTpPrivacyFeaturePlugin -> this is the PrivacyFeaturePlugin that receives the appTrackerProtection json model
It depends on a DaggerSet of AppTpSettingPlugins to which it'll pass the configurations
Every AppTpSettingPlugin will receive the configuration they need to store
this configurations are generally AppTP features
Some of them will also have some configurations, like timeouts, and simple settings
All AppTpSettingPlugins depend on the AppTpFeatureConfig
AppTpFeatureConfig is the interface to set/get the AppTP inner features/configs
it currently is not dummied because the implementation of the persistance will come in the subsequent PRs

Open questions (for next stacked PRs):

what to do with the AppTpFeatureToggleRepository

the AppTP feature will always be enabled (ie. can't be disabled from remote config) so probably we'll re-purpose that repository or delete it altogether

Steps to test this PR

[ ] Install from this branch
[ ] filter logcat by received configuration|apptpconfigs
[ ] launch the app
[ ] verify Received configuration... logs match the subsequent Store AppTpConfigs... message

Current dependencies on/for this PR:

develop

PR #1829

PR #1830   (this PR)

This comment was auto-generated by Graphite.


Feature adding : Adding confetti effects on winning

On winning match add feature of confetti effect

something like this

@iamparas0 please assign me this issue


tweak WorkerController and port non-blocking-async example

This PR changes WorkerController and WorkerHandle to use the Worker impl instead of the input and output types directly, which reads a bit nicer (WorkerController<MyWorker> instead of WorkerController<MyWorkerMsg>.
This commit also ports over the non-blocking-async example.

Updated.


/v1/get_account 500 error, unspecified exception

Hello,
I'm seeing that some accounts throw a 500 error from the get_account endpoint.
on my local:
curl -X POST -H "Content-Type: application/json" http://<IP_ADDRESS>:8888/v1/get_account -d '{"account_name": "ethsidechain"}'
results in:
{"code":500,"message":"Internal Service Error","error":{"code":0,"name":"exception","what":"unspecified","details":[]}}
while, using the url from the eostracker.io explorer, it works.
curl -X POST -H "Content-Type: application/json" https://eos.greymass.com/v1/chain/get_account -d '{"account_name": "ethsidechain"}'
{"account_name":"ethsidechain","head_block_num":24731621,"head_block_time":"2018-11-01T22:36:00.000","privileged":false,"last_code_update":"2018-10-22T14:58:08.000","created":"2018-07-17T03:38:11.500","core_liquid_balance":"0.0035 EOS","ram_quota":269977,"net_weight":106000,"cpu_weight":1070000,"net_limit":{"used":129,"available":7254875,"max":7255004},"cpu_limit":{"used":1037,"available":703518,"max":704555},"ram_usage":267451,"permissions":[{"perm_name":"active","parent":"owner","required_auth":{"threshold":1,"keys":[{"key":"EOS68PG99c2u83SuS5DkWuEp7yKbPQDEJ4qzNbqQdKTVwwfuznYtp","weight":1}],"accounts":[{"permission":{"actor":"ethsidechain","permission":"eosio.code"},"weight":1}],"waits":[]}},{"perm_name":"owner","parent":"","required_auth":{"threshold":1,"keys":[{"key":"EOS68PG99c2u83SuS5DkWuEp7yKbPQDEJ4qzNbqQdKTVwwfuznYtp","weight":1}],"accounts":[],"waits":[]}}],"total_resources":{"owner":"ethsidechain","net_weight":"10.6000 EOS","cpu_weight":"107.0000 EOS","ram_bytes":268577},"self_delegated_bandwidth":{"from":"ethsidechain","to":"ethsidechain","net_weight":"10.1000 EOS","cpu_weight":"106.0000 EOS"},"refund_request":null,"voter_info":{"owner":"ethsidechain","proxy":"","producers":[],"staked":1176500,"last_vote_weight":"0.00000000000000000","proxied_vote_weight":"0.00000000000000000","is_proxy":0}}
any insight into fixing this would be fantastic.
thank you!

Assuming the node on <IP_ADDRESS> that you are querying is syncing with mainnet, your sync probably is not yet complete.  Compare get_info on your node vs greymass and see.
If your local node is not syncing with mainnet, there's no reason for that account to exist, so the error would be correct.

If the node is run with verbose-http-errors turned on, it can provide more detail in errors.
Yes, you should be able to see how close to synced you are.  As I said, use /v1/chain/get_info to see what head block the local node has.


[iOS] Input event issues

Because the input events on phaser are async with respect to the actual event (they are handled during the "update" cycle and not directly in the pointerdown/touchdown/click trigger), I seem to be unable to trigger some stuff that "requires" user interaction (audio, trigger the keyboard (by focussing a hidden text input)) since the function trace does not lead back to the actual user input event...
Is there a trick I can use to have the phaser input system behave in such a way that iOS does play the audio or shows the keyboard when the user touched a button or tries to focus my input area or am I out of luck here...
I'm using the latest release from npm.

Did a quick and dirty test/fix this morning and found one (not so nice, but it works) solution:
In the src/input/touch/TouchManager.js:
Add a reference to this in the startListeners method (something like: var that = this;) and then update the handler to call that.manager.game.loop.tick().
By running a "tick" of the engine the update loop(s) get triggered on the same call as the input happened and at least the input focus works as expected.
Unfortunately audio (both html5 and webaudio) still seem broken (at least on iOS) so I will have to look into that further

Also traced the audio issue (at least for html5 audio), my game does not load/use any audio in the beginning (it will load assets as needed based on the progress) and the HTML5AudioSoundManager's unlock function will fail if there are no assets yet but does remove the event listeners...
To remedy this I injected the following before the removal of the listeners:
            if (!_this.game.cache.audio.entries.size)
            {
                return;
            }

This way the unlock listener remains attached up until the point where there actually is any audio loaded instead of removing itself and failing with a "undefined" error.

Thanks for opening this issue. I think there are 2 separate things going on here. The first is the bug with not unlocking audio unless it was preloaded in the first Scene. This is now fixed in the master branch. The second is getting access to the native touch event for iOS permissions. As this is more of an edge-case (now that audio unlocking responds properly) I'm happy for devs to add their own touch handlers specifically for this.


Fixed implementation of RichTextLabel remove_line(), which fixed issues in EditorLog.

There were some issues in RichTextLabel remove_line() method, where items were not correctly removed, and line decremending for items in later lines was not correctly done.
This also fixed several headaches with EditorLog, which relied on the remove_line() method for collapsing of duplicate messages.
I added some comments which should help clarify some of the logic for the next person to look at this code.
Fixes #49030
See #49030 for the code which I used for the below samples. Essentially the spacebar just calls remove_line(get_line_count() - 1), which should remove the last line of the rich text label. I also tested the update with code which removes lines from the middle of a set of lines and it worked as expected.
Note the "Before" was even more broken because an update() was not triggered on remove_line() - for the below "Before" showcase I added a manual call to update() in the GDScript code.
BEFORE
https://user-images.githubusercontent.com/41730826/119494471-aeceb280-bda4-11eb-96ac-81a119f18697.mp4
AFTER
https://user-images.githubusercontent.com/41730826/119494492-b4c49380-bda4-11eb-994a-a4621f957a74.mp4
Editor Log AFTER
https://user-images.githubusercontent.com/41730826/119494422-a2e2f080-bda4-11eb-957b-e339ee36cde8.mp4
CC @KoBeWi I hope you can stop submitting reports about EditorLog now... 😂

CC @KoBeWi I hope you can stop submitting reports about EditorLog now... 😂

Haha, you wish XD
Printing is still broken, but only after starting.
func _process(delta):
	print("test")

Clearing the text fixes it permanently.

Uhhh... Progress...? 😅

More issues with RichTextLabel... see https://github.com/godotengine/godot/pull/45128#discussion_r639265405
get_line_count() was not count the number of lines internally in RichTextLabel, but all rendered lines... So if there was long enough text to go over multiple lines, it would report more lines than was is current_frame->lines.size(), which is what remove_line checks against when it removes lines. I have added a new separate commit to this PR to add an optional parameter to get_line_count() which allows optionally included wrapped lines as multiple lines or as one line.

Ok, turns out what I was after was get_paragraph_count() which is what get_line_count() used to be.
Updated

Thanks!

@KoBeWi have some confidence 😭


Run all make commands in container.

All make commands require various dev resources to be available:

golang
helm
various gnu utils  such as tar, gzip, tr, base64, cut, find, grep, xargs.
gingo
linters.

I think that the most reasonable way to get reproducible builds and things such as make generate is to run those commands in a pre-build container image.

I highly suggest using nix and a proper shell/default.nix for the build process.
https://nixos.org/explore.html
niv allows you to have proper dependencies across different operating systems.

I highly suggest using nix and a proper shell/default.nix for the build process.
https://nixos.org/explore.html
niv allows you to have proper dependencies across different operating systems.

Closing in favor of #4519 to keep the conversation in a single place. Thanks for raising this issue, @mvladev!