DO-NOT-MERGE istio-mutual support in 0.8

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ldemailly
Assign the PR to them by writing /assign @ldemailly in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@incfly: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
123658d115406b1b4efa1e3a0ec7b363e94cfe36
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
123658d115406b1b4efa1e3a0ec7b363e94cfe36
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
123658d115406b1b4efa1e3a0ec7b363e94cfe36
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
123658d115406b1b4efa1e3a0ec7b363e94cfe36
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
123658d115406b1b4efa1e3a0ec7b363e94cfe36
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
123658d115406b1b4efa1e3a0ec7b363e94cfe36
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
123658d115406b1b4efa1e3a0ec7b363e94cfe36
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
123658d115406b1b4efa1e3a0ec7b363e94cfe36
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
123658d115406b1b4efa1e3a0ec7b363e94cfe36
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
123658d115406b1b4efa1e3a0ec7b363e94cfe36
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ping.. please rebase and fix. Also remove the istio ALPN protocol that @mandarjog set in his #5618 , and instead set ALPN as H2 when istio mutual tls mode is set (you could do this in the convertIstioMutual) function..

Update the offline discussion with @mandarjog:
What Mandar wants to do is to detect whether the other end is Istio service (having Envoy sidecar). If the service does have a authn policy to say ISTIO_MUTUA, that's a good indicator, but it's not quite the same( we don't require services to have authn policy).
So the plan for this PR stays the same, we withhold this till 0.8.1.

Close it for now to avoid confusion, since we expect

0.8 cut is done.
0.8 merge into master.
This PR checked into master.
Re-apply this PR into 0.8.1

0.8.1 will be cut from the release branch and it should contain bug fixes only. It will not be cut from master.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
123658d115406b1b4efa1e3a0ec7b363e94cfe36
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
123658d115406b1b4efa1e3a0ec7b363e94cfe36
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
123658d115406b1b4efa1e3a0ec7b363e94cfe36
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
123658d115406b1b4efa1e3a0ec7b363e94cfe36
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-presubmit.sh
123658d115406b1b4efa1e3a0ec7b363e94cfe36
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
123658d115406b1b4efa1e3a0ec7b363e94cfe36
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
123658d115406b1b4efa1e3a0ec7b363e94cfe36
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
123658d115406b1b4efa1e3a0ec7b363e94cfe36
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-presubmit.sh
123658d115406b1b4efa1e3a0ec7b363e94cfe36
link
/test istio-presubmit

prow/istio-unit-tests.sh
123658d115406b1b4efa1e3a0ec7b363e94cfe36
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
123658d115406b1b4efa1e3a0ec7b363e94cfe36
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
123658d115406b1b4efa1e3a0ec7b363e94cfe36
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
123658d115406b1b4efa1e3a0ec7b363e94cfe36
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-presubmit.sh
123658d115406b1b4efa1e3a0ec7b363e94cfe36
link
/test istio-presubmit

prow/istio-unit-tests.sh
b3e25f518563088398200e67315fe331b0bcb10f
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
123658d115406b1b4efa1e3a0ec7b363e94cfe36
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
123658d115406b1b4efa1e3a0ec7b363e94cfe36
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
3a6b3ac166d8a72cb7755a421e9c995f4512f977
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
3a6b3ac166d8a72cb7755a421e9c995f4512f977
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3a6b3ac166d8a72cb7755a421e9c995f4512f977
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
3a6b3ac166d8a72cb7755a421e9c995f4512f977
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Add a bunch of the DestinationRule to get the test passing. This is not in a ready-to-checkin shape though. Leaving some notes:

Auth related tests are now passing,  egress/gateway/serviceEntry tests are still failing, not sure how it's related to this change. Need to look further how to resolve.
Need to make the testing DR policy more maintainable, refactoring etc.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
3a6b3ac166d8a72cb7755a421e9c995f4512f977
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3a6b3ac166d8a72cb7755a421e9c995f4512f977
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
3a6b3ac166d8a72cb7755a421e9c995f4512f977
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
e2523f504a467bfd8ace5997752e5f5e9c1a0b98
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
3a6b3ac166d8a72cb7755a421e9c995f4512f977
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
3a6b3ac166d8a72cb7755a421e9c995f4512f977
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
e2523f504a467bfd8ace5997752e5f5e9c1a0b98
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
e2523f504a467bfd8ace5997752e5f5e9c1a0b98
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
3a6b3ac166d8a72cb7755a421e9c995f4512f977
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
e2523f504a467bfd8ace5997752e5f5e9c1a0b98
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
e2523f504a467bfd8ace5997752e5f5e9c1a0b98
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
e2523f504a467bfd8ace5997752e5f5e9c1a0b98
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
e2523f504a467bfd8ace5997752e5f5e9c1a0b98
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9218e769d7f8d13f02c065a0f090ee27f9408179
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
e2523f504a467bfd8ace5997752e5f5e9c1a0b98
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9218e769d7f8d13f02c065a0f090ee27f9408179
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
9218e769d7f8d13f02c065a0f090ee27f9408179
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9218e769d7f8d13f02c065a0f090ee27f9408179
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
9218e769d7f8d13f02c065a0f090ee27f9408179
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
9218e769d7f8d13f02c065a0f090ee27f9408179
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly don't worry about the ALPN stuff. We fixed it in a different way.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9218e769d7f8d13f02c065a0f090ee27f9408179
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
9218e769d7f8d13f02c065a0f090ee27f9408179
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
349576ce063098008c43403aa55cf48b77f67e90
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9218e769d7f8d13f02c065a0f090ee27f9408179
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
9218e769d7f8d13f02c065a0f090ee27f9408179
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
349576ce063098008c43403aa55cf48b77f67e90
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
349576ce063098008c43403aa55cf48b77f67e90
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
9218e769d7f8d13f02c065a0f090ee27f9408179
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
349576ce063098008c43403aa55cf48b77f67e90
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
349576ce063098008c43403aa55cf48b77f67e90
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
349576ce063098008c43403aa55cf48b77f67e90
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
349576ce063098008c43403aa55cf48b77f67e90
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
349576ce063098008c43403aa55cf48b77f67e90
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
349576ce063098008c43403aa55cf48b77f67e90
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
349576ce063098008c43403aa55cf48b77f67e90
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
349576ce063098008c43403aa55cf48b77f67e90
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
349576ce063098008c43403aa55cf48b77f67e90
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
349576ce063098008c43403aa55cf48b77f67e90
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
349576ce063098008c43403aa55cf48b77f67e90
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
349576ce063098008c43403aa55cf48b77f67e90
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Repeating my comment from https://github.com/istio/istio/pull/5418:
Is (ab)using TLSMode for this is really a good idea? Shouldn't this a part of the TrafficPolicy? Perhaps bool TrafficPolicy.InMesh?

@PiotrSikora how do you do finer granularity of TLS change, e.g subset/per-port if it's in TrafficPolicy, not TLSMode level?

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
349576ce063098008c43403aa55cf48b77f67e90
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
349576ce063098008c43403aa55cf48b77f67e90
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
349576ce063098008c43403aa55cf48b77f67e90
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
349576ce063098008c43403aa55cf48b77f67e90
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
64ec6051cf030cd1b76eb029173f3d6cff336f4d
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Having another bool may add unnecessary dimension (what does it means when
tlsMode is SIMPLE and that bool is true etc).
On the other hand, I think we can also avoid having new enum by filling all
those fields with proper default values, if they are not set. Anyway, it
can be revised after 0.8, together with how to make better usability.
On Wed, May 23, 2018 at 4:04 PM Jianfei Hu<EMAIL_ADDRESS>wrote:

@PiotrSikora https://github.com/PiotrSikora how do you do finer
granularity of TLS change, e.g subset/per-port if it's in TrafficPolicy,
not TLSMode level?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/5525#issuecomment-391527812, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AX99cYt-PZfu8Y-XcVgSyV_giu0Tl4sAks5t1esNgaJpZM4T5G4d
.

--
Diem Vu | Software Engineer |<EMAIL_ADDRESS>| +1<PHONE_NUMBER>

Also FYI, here's the proposal
Istio Config for incremental mTLS

@incfly: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
16c1bf8dd43d8a56dc77527df0c31189102e6da4
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly Subset contains TrafficPolicy.
@diemtvu You can document that TLSSettings are ignored when TrafficPolicy.InMesh == true. Also, I don't see how that's different issue than having TLSSettings_ISTIO_MUTUAL and certificates configured.

TrafficPolicy.InMesh in more general than just ISTIO_MTLS. In can be used to infer other characteristics about traffic as well. For example whether to upgrade to h2c or not.
One can specify that the other side is istio without enabling MTLS.

what does TrafficPolicy inMesh mean? I would rather not define something generic like that, because we allow people to set a bunch of actual traffic policies like circuit breakers, outliers, etc. the inMesh thing essentially is a way of saying whether the service is in the mesh or outside the mesh (which service entry is already doing).
If ISTIO_MUTUAL is not sitting well with you guys, then I would much prefer to have something explicit in the TLS settings rather than have this TrafficPolicy.inMesh thing. One alternative is to add a field under the TLS settings, that says "bool use_mesh_mTLS_settings" which if true (and TLSMode is MUTUAL), then we populate the fields.
For example:
    TLSMode: NONE, SIMPLE, MUTUAL
     bool useMeshMTLS; // valid only if mode is Mutual
      certs...

I'd like to have default values for key and cert parths are the one that Istio uses (ie "/etc/certs/cert-chain.pem" etc), either by proto default string, or in go code. Customers can just overwrite one of them or all of them, based on their need. With that, we can get rid of ISTIO_MUTUAL, while still have consistency else where.

I'd like to have default values for key and cert parths are the one that Istio uses (ie "/etc/certs/cert-chain.pem" etc), either by proto default string, or in go code. Customers can just overwrite one of them or all of them, based on their need. With that, we can get rid of ISTIO_MUTUAL, while still have consistency else where.

That would be a bit dangerous. I would much rather have ISTIO_MUTUAL as an explicit mode and let people overwrite the cert paths, than overload normal MUTUAL with implicit istio mTLS semantics.

@incfly: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
56c185750a3da030069f2437b5fc246a21401624
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
56c185750a3da030069f2437b5fc246a21401624
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
56c185750a3da030069f2437b5fc246a21401624
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
56c185750a3da030069f2437b5fc246a21401624
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
56c185750a3da030069f2437b5fc246a21401624
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
221c62fa8aaf469abb0d31670537ec1b73aef0a5
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
56c185750a3da030069f2437b5fc246a21401624
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
221c62fa8aaf469abb0d31670537ec1b73aef0a5
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
221c62fa8aaf469abb0d31670537ec1b73aef0a5
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
221c62fa8aaf469abb0d31670537ec1b73aef0a5
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
221c62fa8aaf469abb0d31670537ec1b73aef0a5
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
221c62fa8aaf469abb0d31670537ec1b73aef0a5
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
221c62fa8aaf469abb0d31670537ec1b73aef0a5
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
221c62fa8aaf469abb0d31670537ec1b73aef0a5
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
4c4497057d4cd3a16066e85a5059ccadc7096184
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hklai @rshriram
I'll try to address the existing comments., but this is ready to be merged, The prow/e2e-bookinfoTests-v1alpha3 is already failing
https://prow.istio.io/?repo=istio%2Fistio

https://prow.istio.io/?repo=istio%2Fistio&job=e2e-bookInfoTests-envoyv2-v1alpha3 actually passed the last couple times. Perhaps you want to try again?

@incfly: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
f128a47755033be1c2d8058bab79eec536d6d9fc
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
f128a47755033be1c2d8058bab79eec536d6d9fc
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
f128a47755033be1c2d8058bab79eec536d6d9fc
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hklai The prow tests seem now are failing at gsutil stats phase, before tests actually runs. I'll try to rerun it but please let me know if it's a known issue.

@incfly the tests are failing with
I0524 23:09:48.666] time="2018-05-24T23:07:39Z" level=info msg="Attempting to acquire resource"
I0524 23:09:48.667] time="2018-05-24T23:07:41Z" level=info msg="Resource gke-e2e-test-01 acquired"
I0524 23:09:48.667] time="2018-05-24T23:07:43Z" level=info msg="Saved user data to /tmp/VAR7B.boskos.info"
I0524 23:09:48.667] time="2018-05-24T23:07:43Z" level=info msg=READY
I0524 23:09:48.667] time="2018-05-24T23:07:43Z" level=info msg="Type CTRL-C to interrupt"
I0524 23:09:48.667] time="2018-05-24T23:07:57Z" level=info msg="Updated resources"
I0524 23:09:48.667] time="2018-05-24T23:08:12Z" level=info msg="Updated resources"
I0524 23:09:48.667] time="2018-05-24T23:08:25Z" level=info msg="Updated resources"
I0524 23:09:48.667] time="2018-05-24T23:08:38Z" level=info msg="Updated resources"
I0524 23:09:48.667] time="2018-05-24T23:08:53Z" level=info msg="Updated resources"
I0524 23:09:48.667] time="2018-05-24T23:09:06Z" level=info msg="Updated resources"
I0524 23:09:48.668] time="2018-05-24T23:09:20Z" level=info msg="Updated resources"
I0524 23:09:48.668] time="2018-05-24T23:09:34Z" level=info msg="Updated resources"
I0524 23:09:48.668] time="2018-05-24T23:09:48Z" level=info msg="Released resource gke-e2e-test-01"
which looks boskos is running out of clusters/projects in the pool.
@sebastienvas could you help? Many devs are hitting this problem now.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
f128a47755033be1c2d8058bab79eec536d6d9fc
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
f128a47755033be1c2d8058bab79eec536d6d9fc
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
f128a47755033be1c2d8058bab79eec536d6d9fc
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-unit-tests.sh
21e2945f775788674710f86c41f77a0b5f56fbc6
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
f128a47755033be1c2d8058bab79eec536d6d9fc
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-unit-tests.sh
21e2945f775788674710f86c41f77a0b5f56fbc6
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
21e2945f775788674710f86c41f77a0b5f56fbc6
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-pilot-e2e

@incfly: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
1467c7d7acb57d8154a226a75ca2bbe2de579ac1
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
1467c7d7acb57d8154a226a75ca2bbe2de579ac1
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
1467c7d7acb57d8154a226a75ca2bbe2de579ac1
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram @hklai @mandarjog @diemtvu
Finally now all tests are passing... For the last test suite of prow/bookinfo tests, we did some hacky thing to use different config when authEnabled = true or false. But other than that, we now do have fair understanding of the effect of the PR...

@incfly thanks! Why is the hack needed for the bookinfo test? And why only prow?

@hklai This is because in the prow test we use samples/bookinfo/xxx.yaml for testing. And with this PR, the DestinationRule has to include ISTIO_MUTUAL if and only if meshconfig.AuthEnabled = true. However, we can't add {{ if .AuthEnable eq true }} template syntax into those yaml file as they're not just for testing input but also used directly for our customers' BookInfo app example.
https://github.com/istio/istio/pull/5525/commits/1467c7d7acb57d8154a226a75ca2bbe2de579ac1#diff-b63c1d5d096cfcdc9ef91645f4336e8c

What about circle? (I thought these tests were passing on circle before the hack IIRC)

The circle tests all use app.tmpl.yaml template (only used by test test) as input, so we can add check `{{if .AuthEnable eq true}}`` without worrying about breaking our sample bookinfo app.


Auth0 login issue

https://github.com/devdennysegura/flutter-auth0/blob/cf9420653208ceb56ebe61c0ab78c8f346c81e1f/example/lib/pkce.dart#L32
in the above mentioned position, I'm getting some error and not able to open auth0 authentication page in any of my browsers.
I checked only for android device.

D/FlutterView(24900): Detaching from a FlutterEngine: io.flutter.embedding.engine.FlutterEngine@90557e4
W/ActivityThread(24900): handleWindowVisibility: no activity for token android.os.BinderProxy@6995768
D/FlutterView(24900): Attaching to a FlutterEngine: io.flutter.embedding.engine.FlutterEngine@90557e4
I/flutter (24900): Error: ======================>>>>>>
I/flutter (24900):
I/flutter (24900):
I/flutter (24900):
I/flutter (24900):
I/flutter (24900):
I/flutter (24900):
I/flutter (24900):  type '_InternalLinkedHashMap<String, dynamic>' is not a subtype of type 'String'
I/flutter (24900):
I/flutter (24900):
I/flutter (24900):
I/flutter (24900):
I/flutter (24900):
E/flutter (24900): [ERROR:flutter/lib/ui/ui_dart_state.cc(157)] Unhandled Exception: Connection closed before full header was received
E/flutter (24900): #0      IOClient.send
package:http/src/io_client.dart:65
E/flutter (24900):
E/flutter (24900): #1      BaseClient._sendUnstreamed
package:http/src/base_client.dart:176
E/flutter (24900): #2      BaseClient.patch
package:http/src/base_client.dart:104
E/flutter (24900): #3      Auth0Client.request
package:flutter_auth0/…/networking/client.dart:70
E/flutter (24900): #4      _AsyncAwaitCompleter.start  (dart:async-patch/async_patch.dart:45:6)
E/flutter (24900): #5      Auth0Client.request
package:flutter_auth0/…/networking/client.dart:56
E/flutter (24900): #6      Auth0Client.mutate
package:flutter_auth0/…/networking/client.dart:30
E/flutter (24900): #7      _AsyncAwaitCompleter.start  (dart:async-patch/async_patch.dart:45:6)
E/flutter (24900): #8      Auth0Client.mutate
package:flutter_auth0/…/networking/client.dart:29
E/flutter (24900): #9      Auth0Auth.exchange
package:flutter_auth0/…/auth/index.dart:99
E/flutter (24900): #10     _AsyncAwaitCompleter.start  (dart:async-patch/async_patch.dart:45:6)
E/flutter (24900): #11     Auth0Auth.exchange
package:flutter_auth0/…/auth/index.dart:87
E/flutter (24900): #12     WebAuth.authorize..
package:flutter_auth0/…/webauth/index.dart:63
E/flutter (24900): #13     _AsyncAwaitCompleter.start  (dart:async-patch/async_patch.dart:45:6)
E/flutter (24900): #14     WebAuth.authorize..
package:flutter_auth0/…/webauth/index.dart:62
E/flutter (24900): #15     _rootRunUnary  (dart:async/zone.dart:1134:38)
E/flutter (24900): #16     _CustomZone.runUnary  (dart:async/zone.dart:1031:19)

@rohitattaluri Do you have any parameters inside curly braces? I mean you have code like this:
var response = await auth.webAuth.authorize({})

or this
var response = await auth.webAuth.authorize({'key1': 'value1', 'key2': 'value2'})

@mkolbusz  sorry dude, I forgot to close this. Actually I found some issues from my end and got fixed long back.
Thanks for taking time for looking into this.
I'm closing it now.

@rohitattaluri I am glad you have resolved your problems. Could you share your code? I have still some problems and can not make Apple Sign In with auth0 works :/ Thanks for your help in advance!

@mkolbusz  sorry for that pal!!
I've switched to new organization. I don't have the access for the worked codebase to get that here. 😞😞


e2e pretty busted since ~16:30 on Wed 4/29

I haven't looked into the details yet, but it seems that a PR went in at around 16:30 PDT today (Wed 04/29) that is causing significantly more e2e failures than usual in our continuous integration.
I'll dig into it in the morning unless one of the oncalls gets there before me.

Wild guess that it might be this one, based purely on merge time:

Move ComputePodChanges to the Docker runtime #7480

Bad news :(
what tests are failing?

A variety, and they're intermittent:

Services should provide DNS for the cluster
Density [Performance suite] should allow starting 30 pods per node
Shell tests that services.sh passes
Monitoring verify monitoring pods and all cluster nodes are available on influxdb using heapster.
kubectl guestbook should create and stop a working application
Cluster level logging using Elasticsearch should check that logs from pods on all nodes are ingested into Elasticsearch

... all failed at least once...

Tests have been consistently passing since filing this issue.  Dropping to P1 while investigation continues.  Pretty sure that this is going to crop up again until we figure out the root cause.

As I guessed, this cropped up again.  I'm going to try to repro locally with verbose cluster logging to figure out what's happening.  The DNS service is not working, which is breaking other stuff.  Not clear yet whether DNS, Services, or just Pods in general are flaky.
Test Result (4 failures / +4)

Kubernetes e2e Suite run 1 of 1.Cluster level logging using Elasticsearch should check that logs from pods on all nodes are ingested into Elasticsearch
Kubernetes e2e Suite run 1 of 1.kubectl guestbook should create and stop a working application
Kubernetes e2e Suite run 1 of 1.Density [Performance suite] should allow starting 30 pods per node
Kubernetes e2e Suite run 1 of 1.Services should provide DNS for the cluster
Identified problems
Cluster level logging using Elasticsearch should check that logs from pods on all nodes are ingested into Elasticsearch
/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/es_cluster_logging.go:46
Failed to find all 200 log lines
kubectl guestbook should create and stop a working application
/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/kubectl.go:125
Frontend service did not start serving content in 600 seconds.
Density [Performance suite] should allow starting 30 pods per node
/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/density.go:158
Expected error:
<*errors.errorString | 0xc208a36240>: {
s: "Error: Pod my-hostname-density60-4363cd45-ef6e-11e4-a8a5-42010af01555zzng7: Container my-hostname-density60-4363cd45-ef6e-11e4-a8a5-42010af01555 was found to have terminated 1 times",
}
Error: Pod my-hostname-density60-4363cd45-ef6e-11e4-a8a5-42010af01555zzng7: Container my-hostname-density60-4363cd45-ef6e-11e4-a8a5-42010af01555 was found to have terminated 1 times
not to have occurred
Services should provide DNS for the cluster
/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/service.go:165
Expected
: 3
to equal
: 0

I'm also running the DNS test in a loop locally to see if I can get a failed cluster to pick at.

I can consistently get DNS to fail by killing the kube-dns-xxxxx pod. And I can consistently get it to come back to life by killing the kube2sky container.
"kubectl stop pods kube-dns-xxxxx" will cause the DNS RC to recreate the kube-dns pod, and the kube2sky logs will show that the etcd client is hung on the first write to etcd.
Then, "docker stop xxxxxxxxxxx" on the kube2sky container will cause kubelet to restart kube2sky, and it will successfully write all service DNS entries to skyDNS's etcd.

Might be worth timing out the kube2sky Set operation and re-try?

I think that we can close this one now?  (closed by #7675)

Agreed. I wanted to hold off until the flakiness aged out of jenkins, which it looks like has happened.


Add support for decimal.Decimal

ormsgpack version: 1.2.3
Current behavior
>>> import decimal
>>> ormsgpack.packb(decimal.Decimal("12.345"))
Traceback (most recent call last):
  File "...", in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)
  File "<ipython-input-119-58a3aa663d1a>", line 1, in <module>
    ormsgpack.packb(decimal.Decimal("12.345"))
TypeError: Type is not msgpack serializable: decimal.Decimal

Desired behavior
Decimals seem to be primarily stored as strings. It should be lossless and reasonably fast to cast decimal.Decimal to str during serialization, and back during deserialization.

hey @scnerd, thanks for the suggestion.
I don't have time to add more features currently, but if someone wants to send a PR it'd be great!

Decimals seem to be primarily stored as strings. It should be lossless and reasonably fast to cast decimal.Decimal to str during serialization, and back during deserialization.

Arbitrary types can be serialized using the default callable, see https://github.com/aviramha/ormsgpack#default (the example uses decimal).


Upgrade to kernel 4.9.80 optimized for Docker (kernel build 20180426-171616)

This new kernel build 20180426-171616 includes the support for the Raspberry Pi 3 B+ for the built-in ethernet interface.
Signed-off-by: Dieter Reuter<EMAIL_ADDRESS>

LGTM


Cleanup

Last force push fixed link to Paving the Path for TrenchBoot DRTM in Xen Hypervisor added in https://github.com/TrenchBoot/TrenchBoot.github.io/pull/32 that was both malformed and wrong. It also squashed some commits related to that and next PR to avoid reverting and adding the same change later.

A lot of work has been put into this, is there anything blocking the current cleanup from merging? @krystian-hebel @SergiiDmytruk ?
I wanted to take advantage of these improvements and point someone to the updated events page, but it is still not hosted in the recent version.


Is there a way to assign complexities to mutations, objects and fields by default ?

Is there a way to set up this library such that I provide a configuration where I specify the default cost for mutations, objects and fields ? Something like this:
estimator({mutation: 100, object: 10, field: 1})
This would be very useful for me and I saw it on another library that is not maintained. I cannot add custom directives on my schema and i cannot add extensions as well, because I am using apollo gateway.

You can just create a custom estimator where you examine the type that is being provided. If it's your mutation type, return 100 etc.


New plugin name requirements

Hi @ocapraro
Per our developer policies,
please ensure that your plugin's name does not include the word "Obsidian".
In addition, the plugin name should not include the word "Plugin", as that is unecessary duplication.
We have already modified the name of your plugin to "Math+" in our records.
To maintain compliance, take the following actions:

Modify the manifest.json file in your plugin repository.
Generate a new release for your plugin to ensure users download the updated manifest.

If you have a idea for a different plugin name, you may also submit a pull request to the obsidianmd/obsidian-releases repository.
Thank you for your cooperation.
— the Obsidian team

Done, thank you!


Set botttom boundary on rellax

By setting the data-rellax-boundary to a valid parent element of the '.rellax', you can stop an element from rellaxing at a certain point.  This is useful if you don't want the element to overlay anymore.

This could probably be optimized a bit, and or applied to the top as well as the bottom of the boundary wrapper.

@jacobraccuia This is awesome, a lot of people have been asking me for this! Do you mind adding the top as well?

I added the top!  Please review if you want to change the name of the options (I struggled a bit on what was best) and or to optimize the code better!

Is closest valid JS? It seems like I mixed in some jQuery habits in my
code.  I think it's important that we use a parent element for the
boundary, but a document.querySelector.closest isn't supported in IE.
The alternative is something like below?
while(thisTag.parentNode.className.indexOf(boundary) === -1)
{
thisTag=thisTag.parentNode;
}
On October 5, 2018 at 10:16:20 AM, Moe Amaya<EMAIL_ADDRESS>wrote:
@moeamaya commented on this pull request.
In rellax.js
https://github.com/dixonandmoe/rellax/pull/129#discussion_r223021839:

@@ -149,6 +149,10 @@
var dataSpeed = el.getAttribute( 'data-rellax-speed' );
var dataZindex = el.getAttribute( 'data-rellax-zindex' ) || 0;

 var bounds = el.getAttribute('data-rellax-bounds') || 'both';

 var dataWrapper = el.getAttribute('data-rellax-boundary');

 var boundary = dataWrapper ? el.closest(dataWrapper) : null;

Should we use closest or just do a general document.querySelector here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dixonandmoe/rellax/pull/129#pullrequestreview-162054809,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEcK9CDFApVK0OXTCzXIVrt1GQ6AM_nDks5uh2mzgaJpZM4WvUcV
.

Should probably close the PR if a similar one was already integrated


Secure connection to MS SQL Server

Hello,
I can login to MS SQL Server but my password is in plaintext, i think. When I add encrypt = true I get this error:

error query: TLS Handshake failed: x509: cannot validate certificate for x.x.x.x because it doesn't contain any IP SANs

How can I secure my connection to MS SQL Server?
Thanks

Either use the hostn

Using hostname I get this error:

error query: TLS Handshake failed: x509: certificate signed by unknown authority

allow insecure is what i don't want

Then you must install a valid server certificate that is trusted by the client.

Do you know a good tutorial for that?

Not really. Do a Google search. Maybe look into mkcert on GitHub. I always have to look up the steps each time via Google or msdn.


Confidence Monitor

@jhibbets to bring.

Need to know what cable we need for it. Leo to figure out how to drive all the monitors from one laptop.

HDMI and compostite

Does anyone have a fairly long HDMI cable?
On Mon, Sep 17, 2018 at 2:30 PM Jason Hibbets<EMAIL_ADDRESS>wrote:

HDMI and compostite
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/ncopenpass/NCOpenPass/issues/1211#issuecomment-422121941,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB3Ie3eJHO4wVhPgh2zCbhJ7iQgA1BGjks5ub-pHgaJpZM4WoNK1
.

6’ 8’
On Mon, Sep 17, 2018 at 3:50 PM Leo Suarez<EMAIL_ADDRESS>wrote:

Does anyone have a fairly long HDMI cable?
On Mon, Sep 17, 2018 at 2:30 PM Jason Hibbets<EMAIL_ADDRESS>wrote:

HDMI and compostite
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<
https://github.com/ncopenpass/NCOpenPass/issues/1211#issuecomment-422121941
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AB3Ie3eJHO4wVhPgh2zCbhJ7iQgA1BGjks5ub-pHgaJpZM4WoNK1
.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ncopenpass/NCOpenPass/issues/1211#issuecomment-422147005,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOGtfIlMUObBmfq1DnRYJQ1hfPjsS8oks5ub_0XgaJpZM4WoNK1
.

--
Chris Mathews

I have 6' which I think is too short.
On Mon, Sep 17, 2018 at 3:56 PM Chris Mathews<EMAIL_ADDRESS>wrote:

6’ 8’
On Mon, Sep 17, 2018 at 3:50 PM Leo Suarez<EMAIL_ADDRESS>wrote:

Does anyone have a fairly long HDMI cable?
On Mon, Sep 17, 2018 at 2:30 PM Jason Hibbets<EMAIL_ADDRESS>wrote:

HDMI and compostite
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<

https://github.com/ncopenpass/NCOpenPass/issues/1211#issuecomment-422121941

,
or mute the thread
<

https://github.com/notifications/unsubscribe-auth/AB3Ie3eJHO4wVhPgh2zCbhJ7iQgA1BGjks5ub-pHgaJpZM4WoNK1

.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<
https://github.com/ncopenpass/NCOpenPass/issues/1211#issuecomment-422147005
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAOGtfIlMUObBmfq1DnRYJQ1hfPjsS8oks5ub_0XgaJpZM4WoNK1
.

--
Chris Mathews
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/ncopenpass/NCOpenPass/issues/1211#issuecomment-422148745,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB3Ie8j8RcwMiiP2olcH-NUTkw2hRZD6ks5ub_5TgaJpZM4WoNK1
.

MB might have one at work, will know tomorrow.

She forgot to check today, I'll have to remind her tomorrow. I tested the monitor today with my laptop, things worked great.
@dtraleigh do you need to get some type of splitter to have A/V going to the confidence monitor and the wall inputs?

Tonight, I'll try to see if my laptop can drive two monitors. If not, I'll
have time on Thursday to get a splitter.
On Tue, Sep 18, 2018 at 10:49 PM Jason Hibbets<EMAIL_ADDRESS>wrote:

She forgot to check today, I'll have to remind her tomorrow. I tested the
monitor today with my laptop, things worked great.
@dtraleigh https://github.com/dtraleigh do you need to get some type of
splitter to have A/V going to the confidence monitor and the wall inputs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ncopenpass/NCOpenPass/issues/1211#issuecomment-422630640,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB3Ie8_b2NHn_F8HULgX8x2qqX3tIodvks5ucbDOgaJpZM4WoNK1
.

I have a 25 ft HDMI cable, should be enough

That is solid! Please bring.
On Wed, Sep 19, 2018 at 2:30 PM Jason Hibbets<EMAIL_ADDRESS>wrote:

I have a 25 ft HDMI cable, should be enough
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ncopenpass/NCOpenPass/issues/1211#issuecomment-422910515,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB3Ie7M2mch2XqTT0itnvIFXQB0okNthks5uco1KgaJpZM4WoNK1
.

I can push two monitors from my laptop. I'd feel better with a longer Lightning-to-HDMI cable though so will pick one up just in case. (will save receipt)
Between this and the loaner laptop as a backup, we should be good. Let me close this ticket.


Cell Voltages

Response to issue : Show all Cells within the battery on console detail screen #68
Added publishing of cell voltages and cell balancing to dbus.
Added qml files for visualisation of cell voltages
qml files are installed by running "sh /data/etc/dbus-serialbattery/installqml.sh"
WARNING! - by running the "installqml.sh" is the existing file "/opt/victronenergy/gui/qml/PageBattery.qml" overwritten

The etc/dbus-serialbattery/qml/PageBatteryCellVoltages.qml file is for 16 batteries

The feature has not been dropped. I just missed the new files (installqml and QML folder) in the build script.

For the Daly battery the cell values does not work for all models it seems and then the min/max cell info is wrong. So for the Daly BMS the cell details are disabled until we can sort that out.

Daly single voltage cells are fixed here:
https://github.com/Louisvdw/dbus-serialbattery/pull/162


Does not work with newer versions of Homebridge

Causing fatal error: Homebridge v2.0.0-alpha.2 (HAP v1.0.0) (homebridge-cmdswitch2) is running on port 48904.
/opt/homebrew/lib/node_modules/homebridge-cmdswitch2-no-logs/index.js:145
accessory.updateReachability(true);
^
TypeError: accessory.updateReachability is not a function
at cmdSwitchPlatform.getInitState (/opt/homebrew/lib/node_modules/homebridge-cmdswitch2-no-logs/index.js:145:13)
at cmdSwitchPlatform.addAccessory (/opt/homebrew/lib/node_modules/homebridge-cmdswitch2-no-logs/index.js:99:8)
at cmdSwitchPlatform.didFinishLaunching (/opt/homebrew/lib/node_modules/homebridge-cmdswitch2-no-logs/index.js:36:37)
at HomebridgeAPI.emit (node:events:519:28)
at HomebridgeAPI.signalFinished (/opt/homebrew/lib/node_modules/homebridge/src/api.ts:271:10)
at ChildBridgeFork.startBridge (/opt/homebrew/lib/node_modules/homebridge/src/childBridgeFork.ts:194:14)

I'll give it a look over at some point next week and see what I can do!

It works with the latest versions of the Homebridge Alpha and Beta - thanks @joepool ! Have to keep reverting back to the older version of Homebridge though because so many other plugins break on 2.0

Glad all is working, have just published final version.

The plugin is not working with Homebridge 2.0.0-betal.11


Currently the Cloud Formation Script ( github.com/pivo...master/pcf.json...

...) has the Old AMI (ami-fa5b6792) which is no longer available.
OpsMgrAMI": {
"Type": "String",
"Default": "ami-fa5b6792",
"Description": "Enter Ops Manager AMI"
The pcf.json should be updated with the <IP_ADDRESS> AMI (ami36030c5e) as noted in Pivotal network .

typo


Hover: remove the assumption that the go dir is the project root for golang tooling

currently hover assumes that it controls go.mod, it generates one and then looks for it in a specific location.
this is relatively undesirable because it forces the end user to a specific directory tree or to run into issues dealing with golangs vendor tooling for private repositories.
we should be able to remove this assumption by letting the standard go tooling find the go.mod file.

If you want to add this feature to hover, I can assign you to this task!

I'll gladly help out with it. mainly filed so it was on the radar and if anyone else has ideas towards its implementation they wish to add.


feat: lesson/tela-de-autenticacao

Codecov Report

Merging #7 (33d7d4a) into main (ae1ef5f) will decrease coverage by 9.38%.
The diff coverage is 72.09%.

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   97.61%   88.23%   -9.39%
==========================================
  Files          30       32       +2
  Lines          84      119      +35
  Branches       10       18       +8
==========================================
+ Hits           82      105      +23
- Misses          2       14      +12

Impacted Files
Coverage Δ

src/components/button/FooterButton/styles.ts
100.00% <ø> (ø)

src/components/button/LinkButton/index.tsx
100.00% <ø> (ø)

src/screens/Auth/SignIn/index.tsx
100.00% <ø> (ø)

src/components/button/FooterButton/index.tsx
58.82% <53.33%> (-41.18%)
:arrow_down:

src/components/input/TextInput/index.tsx
69.23% <66.66%> (-30.77%)
:arrow_down:

src/components/input/TextInput/styles.ts
91.66% <83.33%> (-8.34%)
:arrow_down:

src/components/button/Button/styles.ts
100.00% <100.00%> (ø)

src/components/layout/Container/index.tsx
100.00% <100.00%> (ø)

src/components/layout/ScrollView/index.tsx
100.00% <100.00%> (ø)

src/components/layout/ScrollView/styles.ts
100.00% <100.00%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e673fb...33d7d4a. Read the comment docs.

Codecov Report

Merging #7 (33d7d4a) into main (ae1ef5f) will decrease coverage by 9.38%.
The diff coverage is 72.09%.

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   97.61%   88.23%   -9.39%
==========================================
  Files          30       32       +2
  Lines          84      119      +35
  Branches       10       18       +8
==========================================
+ Hits           82      105      +23
- Misses          2       14      +12

Impacted Files
Coverage Δ

src/components/button/FooterButton/styles.ts
100.00% <ø> (ø)

src/components/button/LinkButton/index.tsx
100.00% <ø> (ø)

src/screens/Auth/SignIn/index.tsx
100.00% <ø> (ø)

src/components/button/FooterButton/index.tsx
58.82% <53.33%> (-41.18%)
:arrow_down:

src/components/input/TextInput/index.tsx
69.23% <66.66%> (-30.77%)
:arrow_down:

src/components/input/TextInput/styles.ts
91.66% <83.33%> (-8.34%)
:arrow_down:

src/components/button/Button/styles.ts
100.00% <100.00%> (ø)

src/components/layout/Container/index.tsx
100.00% <100.00%> (ø)

src/components/layout/ScrollView/index.tsx
100.00% <100.00%> (ø)

src/components/layout/ScrollView/styles.ts
100.00% <100.00%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e673fb...33d7d4a. Read the comment docs.


update optional way to getting started with node.js with cloud firestore

After exprimenting on cloud firestore by following the guide by creating project in cloud platform I've some problem and cannot access firestore db.
So I've creating new project on firebase console instead then go to db section and select the firestore, then generate new config and use the same experimental code [from previous project above] to access firestore and it's work properly.

I sign it

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #38   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          11     11
  Lines        1467   1467
=====================================
  Hits         1467   1467

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a60b4e...f2f1a99. Read the comment docs.

This README is auto-generated, and therefore your changes would be wiped out the next time we re-generate it.
However, you should be able to use Firestore without a Firebase project, I'm investigating.

Unfortunately, we can not accept this PR (our tooling would plow over it).
Did we figure out the Firebase project part?

@noomerzx You may have run into the problem that Firestore cannot be used in any Google Cloud Platform project that has every used Datastore. They can't both be used in the same project. You'd have to create a new Datastore-less project to use Firestore.

Closing due to age of the issue.


Add possibility to prefix EnvVar Names

we are using Vite to run our react frontends. adding those with AddNpmApp works well, but the problem is, that the environment variables are not available to the frontend.
as per Vite Documentation environment variables are only available in vite, if the name begins with VITE_.
so I suggest to add a WithEnvironmentPrefix(string prefix) method to set the prefix for all the exposed environment variables like service URLs, Otlp endpoints etc.

This feels a little special. I don't think we would want to do this for all environment variables. It would need to be controlled somehow.

another possibility would be to add multiple methods like so:
WithEnvironmentPrefixForService(string service Name, string prefix);
WithEnvironmentPrefixForOtlp(string prefix);

and others if needed.

Do you have a running sample today that we can use to validate the suggestion?
cc @IEvangelist as he has built samples using various front end frameworks.

Sorry it took me a few days.
I have created a sample project here:
https://github.com/dersia/AspireWithViteSample

I would be happy to contribute this change, if chosen to be done.

The Vue example frontend is using Vite, see how here:
https://github.com/dotnet/aspire-samples/blob/main/samples/AspireWithJavaScript/AspireJavaScript.Vue/src/components/TheWelcome.vue#L21
It's just mapping the VITE_WEATHER_API from the env from Aspire. Article here.

sure, you could do that, but this means that you have to adjust the env file whenever a new nev is added, or the name of the service changed. there are multiple workarounds, but I think this should all be configured in aspire, I don't want to maintain multiple configurations with different concerns and have them duplicated.

From: David Pine @.>
Sent: Saturday, February 17, 2024 2:47:37 PM
To: dotnet/aspire @.>
Cc: Sia Ghassemi @.>; Author @.>
Subject: Re: [dotnet/aspire] Add possibility to prefix EnvVar Names (Issue #1898)
The Vue example frontend is using Vite, see how here:
https://github.com/dotnet/aspire-samples/blob/main/samples/AspireWithJavaScript/AspireJavaScript.Vue/src/components/TheWelcome.vue#L21
It's just mapping the VITE_WEATHER_API from the env from Aspire. Article herehttps://learn.microsoft.com/en-us/dotnet/aspire/get-started/build-aspire-apps-with-nodejs.
—
Reply to this email directly, view it on GitHubhttps://github.com/dotnet/aspire/issues/1898#issuecomment-1950200954, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AALXPJUIWC455OS3RZC44BDYUCYHTAVCNFSM6AAAAABCNDU3C2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJQGIYDAOJVGQ.
You are receiving this because you authored the thread.Message ID: @.***>

It would be possible to do this today by writing something like this:
public static class EnvExtensions
{
    public static IResourceBuilder<T> WithEnvironmentPrefix<T>(this IResourceBuilder<T> resourceBuilder, string prefix)
        where T : IResourceWithEnvironment
    {
        return resourceBuilder.WithEnvironment(context =>
        {
            var kvps = context.EnvironmentVariables.ToArray();

            // Adds a prefix to all environment variable names
            foreach (var p in kvps)
            {
                context.EnvironmentVariables[$"{prefix}{p.Key}"] = p.Value;
            }
        });
    }
}

It would be really great to have option to define extra prefix. It's quite common pattern to increase security. It appears in create-react-app, Vite but also .NET has option to load only prefixed variables: .AddEnvironmentVariables(prefix: "CustomPrefix_")
Current workaround is fine if you have only one reference for API, but it's worst when you have more complicated use case. In my case I have to also reference keycloak in my React application to support authentication.


error on importing legacy wurst project

see https://github.com/wurstscript/WurstScript/issues/609

wurst.build :
---
projectName: "DefaultName"
dependencies:
- "https://github.com/wurstscript/wurstStdlib2"
buildMapData:
  name: "DefaultName"
  fileName: "DefaultFileName"
  author: "DefaultAuthor"

Just to mention that after updated WurstSetup.jar to latest version, issue resolved. Sorry for causing inconvenient.


Problem with Dataset

Hello, First of all, thank you for your neat work! I managed to run your code on the bottle class of the Mvtec dataset by running the command:
python train.py --dataset_path /home/username1/data/datasets/mvtec/bottle/train --num_class 3

However when I tried to run the anomaly_detection.py, using the following command:
python anomaly_detection.py --checkpoint ./tb_logs/exp1/version_3/checkpoints --data /data/username1/datasets/mvtec/bottle/test

I did not obtain any results, the problem is that the all_checkpoint list in the main part of the anomaly_detection.py contains only the checkpoint I specified in the command above, which makes me wonder whether I am doing something wrong when specifying the command above and also I wonder whether you have a different dataset organization on your side. Because for now, I am having the following organization (the original):
mvtec
│   readme.
│   license.txt
│
└─── bottle
│   │   readme.txt
│   │   lisence.txt
│   │
│   └─── ground_truth
│   |   └─── broken_large
│   |   └─── broken_small
│   |   └─── contamination
│   |
|   └─── train
|   |     └─── good
|   |       |  000.png
|   |       | ...
│   |
|   └─── test
|   |     └─── broken_large
|   |     | |  000.png
|   |     | |  ...
|   |     └───   broken_small
|   |     | |  000.png
|   |     | |  ...
|   |     └───   contamination
|   |     | |   000.png
|   |     | |  ...
|   |     └───   good
|   |     | |  000.png
|   |     | | ...
└─── cable
| ...
└─── zipper

Can you please tell me whether you used a different organization? Because when I look at mvtec_anomaly_detection function I see that you build a path using the defect name + "train" and you do the same for "test". Thank you for your help.

Hello, How did you solve this problem?
did you change the folders?
Originally posted by @farzadips in https://github.com/LilitYolyan/CutPaste/issues/14#issuecomment-1079054692

Check #14 comments


Slider maximumValue with some special numbers like 1006.5824985 has some calculate problem

[x] I have reviewed the documentation
[x] I have searched existing issues
[x] I am using the latest React Native version

Environment

Environment:
OS: macOS High Sierra 10.13.4
Node: 9.3.0
Yarn: 1.6.0
npm: 5.5.1
Watchman: 4.9.0
Xcode: Xcode 9.3 Build version 9E145
Android Studio: 3.1 AI-173.4720617
Packages: (wanted => installed)
react: 16.3.1 => 16.3.2
react-native: ~0.55.2 => 0.55.4
Steps to Reproduce

Set Slider with a special amount 1006.5824985, there is a problem
The code is that
import * as React from 'react'
import { View, Slider, Text } from 'react-native'

class SlderTest extends React.Component {
  constructor(props) {
    super(props)
  }

  state = {
    amount: 1,
  }

  handleSlidingChange = (amount) => {
    console.log(amount)
    this.setState({ amount })
  }

  render () {
    return <View style={{ paddingTop: 30, width: 300 }}>
      <Text>{this.state.amount}</Text>
      <Slider
        minimumValue={0}
        maximumValue={1006.5824985}
        value={this.state.amount}
        onValueChange={this.handleSlidingChange}
        onSlidingComplete={this.handleSlidingChange}
      />
    </View>
  }
}
export default SlderTest

Expected Behavior

The amount should not be larger then 1006.5824985
Actual Behavior

But the handleSlidingChange will receive like 1006.58251953125
Another test maximumValue, like<PHONE_NUMBER>2, has wrong behavior too.
Thanks!
Same issue https://github.com/facebook/react-native/issues/18957

@Xaber20110202 maximumValue is a float value in the native component, and 1006.5824985 is 1006.58251953125 as float.

This problem is still exist on<EMAIL_ADDRESS>

May be it's not a very serious problem, but may cause some unexpected behaviors


Safari 12.1 vs Safari TP

Safari 12.1 has been split from Safari TP (although still unreleased) and Safari TP is now tracking Safari 12.2.
I don't know what the protocol for handling these versions are so treat this issue as appropriate.

12.2 has now been added. Support will be checked again once it's been released.

12.1 released!


Changing parallax factor

Hi,
why not consider to implement methods that allows parallax factor editing?

That should be easy to do. Just change SCROLL_MULTIPLIER  to a field and create a method that changes it

Fixed with 7da8179043e7172d5e44443ce7d4c9a0129f8175


Refactor profileBuilder tool

Simplified the code and in the process uncovered several bugs where an
operation would fail but the error was ignored.
Removed dependency on GOPATH.
For the list command changed the input format to JSON; this is
required for upcoming changes to support hybrid profiles.
Removed dependency on viper as it wasn't used and cluttered up the code.
The content in aliasPackage.go is a copy from an external dependency so
the core logic is the same but simplified.
Removed all default values and made their flags required.
Properly support packages that are versioned like v1.
The sort order for aliased content has been fixed once and for all.
Update profiles with latest profileBuilder tool
Converted test list files to JSON.
Added root generate.go file and swagger->sdk to use it.
Some missing profile content has been added due to bug fixes.
Sort order fixes has rearranged some content.

Can one of the admins verify this patch?


Cannot implement a app/driver which uses other datasources AND has external network access

The container manager sets container config, including environment, differently for drivers vs apps, see [getDriverConfig](https://github.com/me-box/core-container-manager/blob/master/containerManager.go#L759] and getAppConfig.
In particular, only drivers get environment variable DATABOX_STORE_URL whether or not an app has required a store, and only apps get environment variables DATASOURCE_... whether or not a driver has declared that it need datasources. For drivers, the access permissions are also not set up in the CM
Perhaps that's why some existing examples rely on DATABOX_ZMQ_ENDPOINT where they should apparently use  DATABOX_STORE_URL (as an app workaround?!).
So you would think tagging it as an app would be better...
But if it tagged as an app then I believe the external whitelist is not initialised in the core network by the CM.

There again, maybe its a feature, as it means you can't write a component that reads data from another component's datasource and sends it out to a (whitelisted) host without going via a datasource/store (i.e. splitting it into an export driver/actuator and a bridge app to link the two)
(But not setting DATABOX_STORE_URL in apps with stores is probably still a bug)

I think the former is definitely a feature of Databox, the latter sadly is the issue with the store which has to be addressed

To stop a driver with external access leaking data, drivers cannot read data from any store apart from the one they own. This is by design but does cause a lot of confusion and complication (combined with App not having any external access ever) as many simple use-cases need an app driver pair to perform even simple tasks.  As the relationship between the driver and store is a one to one relationship it was implemented as an env var DATABOX_STORE_URL.
Apps can request access to many data sources in different stores so the store URL can and often is different for each data source. So when accessing a data source the URL is extracted from the DATASOURCE_... env var.
DATABOX_STORE_URL should only be set for Apps if they request a store. If it's not then its a bug 👍
It was on my todo list for a long time to tidy this up and move to using docker secrets to pass the config data to apps and drivers. However, it never made it to the top :-)

OK, I think it makes sense.
Some kind of error/warning at some point prior to silently failing to access the apparently whitelisted external sites from apps would be good to have, though :-)


form-data not accessible in middleware via $request

Hi,
I'm unable to access my form-data in middleware, however, If I send the same data as a JSON, I can access it. Is anything missed in the documentation? Any resolution to this?
The question relating this
http://stackoverflow.com/questions/34191178/laravel-5-1-unable-to-get-form-data-in-middleware

Please direct questions to the forums.


[] build failure

Host Environment

OS: Windows 7 x64
Compiler: VS 2017

To Reproduce
Steps to reproduce the behavior:
`./vcpkg install assimp
Failure logs
-- Using cached D:/Program Files/vcpkg/downloads/zlib1211.tar.gz
-- Cleaning sources at D:/Program Files/vcpkg/buildtrees/zlib/src/1.2.11-63309e48e5.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source D:/Program Files/vcpkg/downloads/zlib1211.tar.gz
-- Applying patch cmake_dont_build_more_than_needed.patch
-- Applying patch 0001-Prevent-invalid-inclusions-when-HAVE_-is-set-to-0.patch
-- Applying patch add_debug_postfix_on_mingw.patch
-- Using source at D:/Program Files/vcpkg/buildtrees/zlib/src/1.2.11-63309e48e5.clean
-- Configuring x86-windows
-- Building x86-windows-dbg
-- Building x86-windows-rel
-- Using cached D:/Program Files/vcpkg/downloads/mingw-w64-i686-pkg-config-0.29.2-1-any.pkg.tar.xz
-- Using cached D:/Program Files/vcpkg/downloads/mingw-w64-i686-libwinpthread-git-<IP_ADDRESS>06.c9a21571-1-any.pkg.tar.zst
-- Fixing pkgconfig file: D:/Program Files/vcpkg/packages/zlib_x86-windows/lib/pkgconfig/zlib.pc
-- CHECK_LIB_zlib_RELEASE:CHECK_LIB_zlib_RELEASE-NOTFOUND
CMake Error at scripts/cmake/vcpkg_fixup_pkgconfig.cmake:232 (message):
Library "zlib" was not found! If it is a system library use the
SYSTEM_LIBRARIES parameter for the vcpkg_fixup_pkgconfig call! Otherwise,
correct the *.pc file
Call Stack (most recent call first):
scripts/cmake/vcpkg_fixup_pkgconfig.cmake:298 (vcpkg_fixup_pkgconfig_check_files)
ports/zlib/portfile.cmake:48 (vcpkg_fixup_pkgconfig)
scripts/ports.cmake:79 (include)
Additional context
Package: zlib: x86-windows
Vcpkg version: 2020.06.15-nohash

This is caused by a bug in vcpkg with paths containing spaces - fixed by #13126. In the meantime, you can work around it by cloning vcpkg to a path without a space, eg C:\vcpkg.

Hi @MicSm ,
According to @Hoikas ’s suggestion, you can verify if it is feasible？

Hi @MicSm ,
According to @Hoikas ’s suggestion, you can verify if it is feasible？

Hi @JonLiu1993 ,
Right now I made a full reinstall of vcpkg, and it seems there is another one error as well
(after executing vcpkg.exe install assimp):
-- Downloading http://www.zlib.net/zlib-1.2.11.tar.gz...
-- Extracting source D:/vcpkg/downloads/zlib1211.tar.gz
-- Applying patch cmake_dont_build_more_than_needed.patch
-- Applying patch 0001-Prevent-invalid-inclusions-when-HAVE_-is-set-to-0.patch
-- Applying patch add_debug_postfix_on_mingw.patch
-- Using source at D:/vcpkg/buildtrees/zlib/src/1.2.11-63309e48e5.clean
-- Configuring x86-windows
-- Building x86-windows-dbg
-- Building x86-windows-rel
-- Downloading https://repo.msys2.org/mingw/i686/mingw-w64-i686-pkg-config-0.29.2-1-any.pkg.tar.xz...
-- Downloading https://repo.msys2.org/mingw/i686/mingw-w64-i686-pkg-config-0.29.2-1-any.pkg.tar.xz... Failed. Status: 35;"SSL connect error"
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:178 (message):
  Failed to download file.
  If you use a proxy, please set the HTTPS_PROXY and HTTP_PROXY environment
  variables to "https://user:password@your-proxy-ip-address:port/".
  Otherwise, please submit an issue at https://github.com/Microsoft/vcpkg/issues

Call Stack (most recent call first):
scripts/cmake/vcpkg_find_acquire_program.cmake:403 (vcpkg_download_distfile)
scripts/cmake/vcpkg_fixup_pkgconfig.cmake:270 (vcpkg_find_acquire_program)
ports/zlib/portfile.cmake:48 (vcpkg_fixup_pkgconfig)
scripts/ports.cmake:79 (include)

@JonLiu1993 As I see, my vcpkg installation was compiled with VS 2019 compiler and it is possible to download directly from browser that archive: https://repo.msys2.org/mingw/i686/mingw-w64-i686-pkg-config-0.29.2-1-any.pkg.tar.xz

Hi @MicSm ,
I feel your problem has been solved, can I close the issue?

Hi @MicSm ,
I feel your problem has been solved, can I close the issue?

Yes, but need to fix another one from my above message about when vcpkg tries to download https://repo.msys2.org/mingw/i686/mingw-w64-i686-pkg-config-0.29.2-1-any.pkg.tar.xz and fails

@MicSm, this issue has been fixed, please get latest source and try again.


[BUG]: Ads audio still playing when exiting the video (iOS only)

Version
"react-native-video": "6.0.0-rc.0"
What platforms are you having the problem on?
iOS
Architecture
Old architecture
What happened?
Using adTagUrl on iOS, load an ad and then go back or unmount the video component you can still hear the audio of the ad for 4-5 seconds.
This happen both on emulator and real device.
https://github.com/react-native-video/react-native-video/assets/140423003/29029402-77f1-4ab0-a962-5b5d4295c0c9
On android is working as expected.
Reproduction
repository link
Reproduction
Step to reproduce this bug are:

Create a react app
Install<EMAIL_ADDRESS>Create a video component and add adTagUrl
Enter video and go back, you will hear for 4-5 seconds the audio of the ad loaded before.

Expected behaviour:
When exiting the video the ad should stop reproducing the audio.

They likely forgot to call the destroy method when the player is detached from the super view. While waiting for the fixes, you can use my patch-package file for a temporary solution.
Please note that in this patch file, I've also added 2 events for iOS, (AD_CUEPOINTS & AD_ERROR) to grab all ad positions, error when loading adTagUrl and additional metadata of the playing ad break to know which ad position is playing (use cases are included in the file), these event will not included in others release without patching so use at your own risk.
react-native-video+6.0.0-rc.0.patch

@Khuongnb do you want to create PR 😄 or I should do it ?

Thank you for the patch, I confirm this is looking good, just need to add new events in the documentation !

Hi, sorry for the late response. I created a PR for this issue, which only addresses the ad audio problem. The new ad events will need to be implemented on Android before they can be used to ensure functionality on both platforms, I will open another PR when it's available. Thanks everyone.

PR has been merged, will be available in 6.0.0-RC.1


Where to obtain domain and quality model files?

I'm trying to follow the data classification tutorial,  which refers to some .pth model files.
Where can I obtain these from? I'd have expected the library to automatically pull them from Hugging Face?

Possibly a duplicate of #72

Domain classifier available here. I will close the issue when we release the quality classifier as well.

Quality classifier available here. Both domain and quality now automatically download from Hugging Face too with #190.


Missing right click option

Issue Type: Bug
Version 1.53.0 - Python
Right clicking on a function or class used to give the option to go to Definition.  This has suddenly vanished, much to my distress!
VS Code version: Code 1.53.0 (8490d3dde47c57ba65ec40dd192d014fd2113496, 2021-02-03T20:36:38.611Z)
OS version: Windows_NT x64 10.0.19042
Remote OS version: Linux arm 5.4.83-v7+

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz (8 x 3392)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.94GB (8.19GB free)

Process Argv
--crash-reporter-id dda82bfd-c40b-43f6-a28d-42e78c8eba67

Screen Reader
no

VM
0%

Item
Value

Remote
SSH: <IP_ADDRESS>

OS
Linux arm 5.4.83-v7+

CPUs
ARMv7 Processor rev 4 (v7l) (4 x 1400)

Memory (System)
0.90GB (0.08GB free)

VM
0%

Extensions (8)

Extension
Author (truncated)
Version

remote-containers
ms-
0.158.0

remote-ssh
ms-
0.63.0

remote-ssh-edit
ms-
0.63.0

vscode-remote-extensionpack
ms-
0.20.0

jinja
who
0.0.8

python
ms-
2021.1.502429796

vscode-pylance
ms-
2021.2.0

jupyter
ms-
2020.12.414227025

Steve,
I have no idea why, but this morning when I logged on all it working as it should be.  Sorry for wasting your time.  FYI I am developing code on an RPi using SSH and normally this works a treat.
Regards,
Marc
@Darkfish888 can you provide a screen shot of your experience? I am unable to reproduce this issue with the latest python extension installed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@Darkfish888 I will close for now. I wonder if there was some issue with the Python extension or just some delay in its activation. Thanks for getting back.


Add rust-gpu dev guide

Currently just includes the getting started docs and a GitHub action to automatically deploy the book to GitHub Pages.

Is there any way to deduplicate those getting started sections? They're sort of in flux and not remembering to update both is going to happen.

Yeah, I'd probably be in favour of moving the text entirely over to the guide, to keep the README from getting too big. I'd want to do that in a followup PR though, as we need the GitHub Pages site up first (as there are caching issues if you guess the URL before the site is up).


absLangURL has no effect on base the url

Scenario: the site name or logo in the header should link link to the homepage of the corresponding language. The German version links to / instead of /de.
It would also be nice if I don't have to convert the base url into a string before piping it to absLangURL.

I assume the baseURL is absolute already, and then this is by design -- I do not touch absolute URLs. The trick here is do do something ala absLangURL "/".


Low Res images from S3

I copies the Tiles folder to S3 and amended the amended index.js to point to S3 for the source images,  but the images returned are very low resolution.
Example, 100% quality http://quick360tours.com/tours/Cloverdale/
Example, 50% quality http://quick360tours.com/tours/Cloverdale/index2.html
Looking forward to your feedback
TIA,
Fred

It seems that the server is returning a 403 (Forbidden):
https://p1og-360-videos.s3.amazonaws.com/cloverdale/tiles/0-the-entrance/3/f/0/3.jpg.
Probably some configuration needs to be changed on the server.
On Tue, Apr 4, 2017 at 1:56 AM, nittygritty<EMAIL_ADDRESS>wrote:

I copies the Tiles folder to S3 and amended the amended index.js to point
to S3 for the source images, but the images returned are very low
resolution.
Example, 100% quality http://quick360tours.com/tours/Cloverdale/
Example, 50% quality http://quick360tours.com/tours/Cloverdale/index2.html
Looking forward to your feedback
TIA,
Fred
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/marzipano/issues/75, or mute the thread
https://github.com/notifications/unsubscribe-auth/AArp05Ao7F-MXSKGK0VhiyLbKz6NIjt1ks5rsgWvgaJpZM4MykKS
.

The problem is that S3 is allowing the first level images to be loaded but not the rest. Simply make public the entire tour folder in Amazon Console.


create sendTransactionsThread task

/src/tasks create a function that accepts a list of actions and sends them to discord

created API helper function since we want users to be able to queue a variable amount of transactions from TransactionQueue modal
https://github.com/nance-eth/nance-ts/blob/95c499ccf84f43d2f238367741a6cb2bb9efbfec/src/api/helpers/discord.ts#L106


[FEATURE] Need a way to clean up a specific eBPF program in the global shm

The global shm is leaking because there is no way to release a particular eBPF program individually. We can only free up everything like this:
$ bpftimetool remove
[2024-01-26 23:03:24.274] [info] [bpftime_shm_internal.cpp:46] Global shm removed

Maybe we can specify an argument of ebpf program name or ebpf program ID (we'll also need a way to lookup such IDs, though).

Maybe we need to identify all the ebpf program we used in the global shm and manage it


Autoscaling Experiment.

Deadline: Oct 27, 2017
Design doc: https://github.com/PaddlePaddle/cloud/blob/develop/doc/autoscale_experiment.md
TODO:

Make sure all demos in the book is running on Cloud correctly.

[x] 01.fit a line, #401 -- @putcn
[ ] 02.recognize_digits, #405 -- @gongweibao
[ ] 03.image_classification,
[ ] 04.word2vec, #402
[ ] 05.recommender_system, #406 -- @putcn
[ ] 06.understand_sentiment, #407
[ ] 07.label_semantic_roles, #404
[ ] 08.machine_translation, #403

[ ] Implement scripts to submit the job.
[ ] Implement the program that collects time series data for plotting graph(CPU and GPU utils).

BLOCK BUGS:

https://github.com/PaddlePaddle/cloud/projects/1

Cluster Resouces
CPU: 2348(Core)
GPU: 0(GPU card)

TestCase1

Submit two GENERAL jobs, mnist0(40 trainers, 15 pservsers),mnist1(45 trainers, 25 pservsers)

Total time: 420(s)
Average running time: 220(s)
Average pending time: 85(s)
mnist0 running time: 205(s)
mnist1 running time: 235(s)

Details

Times	Name	Status	CPU	GPU	PARALLELISM
0	mnist0	WAITING	5.60	0	0   // no job has been submited
0	mnist1	WAITING	5.60	0	0
5	mnist0	WAITING	5.60	0	0
5	mnist1	WAITING	5.60	0	0
10	mnist0	RUNNING	29.88	0	40  // mnist0 starts to run
10	mnist1	WAITING	29.88	0	0
15	mnist0	RUNNING	29.88	0	40
15	mnist1	PENDING	29.88	0	34  // mnist1 pending, no enough resource
20	mnist0	RUNNING	50.32	0	40
20	mnist1	PENDING	50.32	0	45
...
180	mnist0	RUNNING	36.52	0	40
180	mnist1	PENDING	36.52	0	45
185	mnist0	RUNNING	39.59	0	40
185	mnist1	RUNNING	39.59	0	45  // minist1 running
210	mnist0	RUNNING	38.05	0	40
210	mnist1	RUNNING	38.05	0	45
215	mnist0	FINISH	37.54	0	40  // mnist0 finished
215	mnist1	RUNNING	37.54	0	45
220	mnist0	FINISH	37.54	0	40
220	mnist1	RUNNING	37.54	0	45
...
415	mnist0	FINISH	15.06	0	40
415	mnist1	RUNNING	15.06	0	45
420	mnist0	FINISH	14.54	0	40
420	mnist1	FINISH	14.54	0	45  // mnist 1 finished

Great!!!
Maybe we can change the "WAITING" in 0	mnist0	WAITING	5.60	0	0 to "NOT EXISTS" or "N/A"? To me waiting means more like pending, which we already have.

@helinwang I push a PR. #447 to reproduce the experiment, I think I will fixed 1. and 2. of your comment abvoe.

@Yancey1989 I tried the following, and get error log on fault tolerant mode, it seems that the ETCD_IP environment variable is not set in the fault tolerant mode.
$ ./control_case1.sh start 1 ON
$ kc logs -f mnist0-trainer-w98q9
label selector: paddle-job-master=mnist0, desired: 1
Starting training job<EMAIL_ADDRESS>num_gradient_servers: 2, trainer_id:  1, version:
I1027 22:58:52.600109    28 Util.cpp:166] commandline:  --num_gradient_servers=2 --ports_num_for_sparse=1 --use_gpu=0 --trainer_id=1 --trainer_count=10 --num_passes=1 --ports_num=1 --port=7164
[INFO 2017-10-27 22:58:52,696 layers.py:2556] output for __conv_pool_0___conv: c = 20, h = 24, w = 24, size = 11520
[INFO 2017-10-27 22:58:52,697 layers.py:2684] output for __conv_pool_0___pool: c = 20, h = 12, w = 12, size = 2880
[INFO 2017-10-27 22:58:52,698 layers.py:2556] output for __conv_pool_1___conv: c = 50, h = 8, w = 8, size = 3200
[INFO 2017-10-27 22:58:52,699 layers.py:2684] output for __conv_pool_1___pool: c = 50, h = 4, w = 4, size = 800
I1027 22:58:52.706857    28 GradientMachine.cpp:94] Initing parameters..
I1027 22:58:52.708870    28 GradientMachine.cpp:101] Init parameters done.
t=2017-10-27T22:58:57+0000 lvl=eror msg="Init etcd connection failed" error="dial tcp: lookup None on <IP_ADDRESS>:53: no such host" stack="[github.com/PaddlePaddle/Paddle/go/pserver/client/etcd_client.go:145 c/cclient.go:129 _obj/_cgo_gotypes.go:109]"
t=2017-10-27T22:59:07+0000 lvl=eror msg="Init etcd connection failed" error="dial tcp: lookup None on <IP_ADDRESS>:53: no such host" stack="[github.com/PaddlePaddle/Paddle/go/pserver/client/etcd_client.go:145 c/cclient.go:129 _obj/_cgo_gotypes.go:109]"

For documentation purpose in case anyone else run into the problem:
For none fault tolerant job (./control_case1.sh start 1 OFF), I have to comment out the below line to make it start training reliably:
     elif sys.argv[1] == "train":
-        prepare_dataset()
+        #prepare_dataset()
         main()

And to make the trainer run longer, we need to do:
-        num_passes=1)
+        num_passes=100)

Hi @helinwang , I have update the PR #447 , please follow code :)  The update as following:

Fix train_ft.py, fetch record from master
Support PASSES and JOB_COUNT args to support run the experiment multipl tims.
Generating a experiment report after all passes are finihsed.

Remaining problems:

Scale down does not work, https://github.com/PaddlePaddle/cloud/issues/450,
The result of the experiment is unstable because of the unstable HDFS mount.

maybe can add definition description about AVG_RUNNINT_TIME, AVG_PENDING_TIME and JOB_RUNNING_TIME.

@Yancey1989 got this error after starting autoscaler, seems to be a RBAC related issue, do you have any idea?

E1030 21:10:27.490697       1 reflector.go:201] github.com/PaddlePaddle/cloud/go/controller/controller.go:100 : Failed to list *api.TrainingJob: User "system:serviceaccount:helinwang-baidu-com:default" cannot list trainingjobs.paddlepaddle.org at the cluster scope. (get TrainingJobs.paddlepaddle.org)

controller.yaml:
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  name: training-job-controller
spec:
  replicas: 1
  template:
    metadata:
      labels:
        name: training-job-controller
    spec:
      containers:
      - name: training-job-controller
        image: helinwang/training-job-controller
        imagePullPolicy: Always
        command: ["/controller", "-logtostderr", "-log_level", "debug"]

I sent a PR to improve scale down: #456 . But could not test it because I got this error after starting > autoscaler, seems to be a RBAC related issue, do you have any idea?

The controller needs a ClusterRoleBind to bind with the ClusterRole(admin)，in the internal CPU cluster, please submit to namespace with paddlecloud

Here is one run for test case 1 today:
PASSES=5 JOB_COUNT=1 FAULT_TOLERANT=ON ./control_case1.sh start
PASS_NUM|AVG_RUNNINT_TIME|AVG_PENDING_TIME|JOB_RUNNING_TIME|CPU_UTILS
0|2360|5|2360|13.69
1|320|5|320|14.54
2|1630|0|1630|13.91
3|4570|0|4570|14.80
4|5870|0|5870|14.94
TOTALLY|2950|2|N/A|14.38

有一些问题请教：
case1：开启autoscale的情况，平均job执行时间变长了，整体集群CPU利用率上升不明显，而且貌似也没有达到很高的利用率？是否是因为每个pod request的CPU比较多呢？
case2：没有开启autoscale的情况，最后两行，trainer也变得很少，是job执行完成了么？这时是否nginx有大量pending的pod？

同请教：
case1：为何autoscaling=ON会有pending？
case2：为何autoscaling=ON的时候有450s，而OFF的时候只有212s？
还有case2因为总时间是固定的，考虑加一个total trainer running time（trainer数在时间上的积分，越高越好）？

Some helpful commands:
get total cluster CPU capacity:
kubectl describe nodes|grep -A1 Capacity|grep cpu|awk '{a=a+$2} END {print a}'

我们对于case 1是不是可以也收集下time series的每个pod和总体cpu的利用率, 这样我们就可以生成如下的图:

上下俩chart分别对应打开auto scale和没开的情况. 横轴为时间, 纵轴为CPU利用率.
除了红色的每条线都是一个pod的CPU利用曲线, 通过这个可以看出来每个pod的调度情况, 这样可以显示出打开auto scale的情况下pending的time都很少.
红色的曲线代表总体CPU的利用率. 对时间求下积分, 算出x轴和红色曲线的面积, 作为CPU utilization score. 分数越高说明CPU做功越多. 如果同样功情况下时间越短, 说明效率越高.
不知道我说明白了没...

@putcn 这个方法甚好，而且足够直观。但可能需要 @Yancey1989 也记录执行过程的详细数值。

@typhoonzero @Yancey1989 我改了下程序，能够输出每秒的情况，一会push上来。

Cool!! Thanks @helinwang @putcn

Update this PR #452

Do not need to run python main.py print_info, the time serise data will be generated at ./out/mnist-case[1|2]-pass[0-9].log folder.
Package the dataset and recordio files in the Docker image registry.baidu.com/paddlepaddle/paddlecloud-job:mnist
Add two colume in the time serise data, running trainers for each job and cpu utils for each job, @putcn could you help to add these two colume on the figure?

sure, will do

Update today on #453

Change case 2 so that it will run around 10 min for each experiment, no matter how many jobs has been submitted. The experiment will stop after the Nginx is scaled back to 400.

Not longer rm ./out every time, test will have different output folder depend on the configuration.
So now you can run multiple experiments in a loop:
$ for i in `seq 1 2`; do echo pass $i; TAG=round_$i JOB_COUNT=5 ./run.sh start case2; done
pass 1
outputing output to folder: ./out/mnist-OFF-5-1-ON-400-case_case2-round_1

Remaining problem:

The max CPU util is capped around 85%, it would be great if we can explain why this happens, to the readers.

Graph:
Test case 2:
Autoscaling ON:

Autoscaling OFF:

Running case1 with 20 jobs, with trainer cpu:2, pserver cpu:2:
some trainer pods error with:
label selector: paddle-job-pserver=mnist5, desired: 10
label selector: paddle-job-master=mnist5, desired: 1
Starting training job<EMAIL_ADDRESS>num_gradient_servers: 5, version:
I1102 03:27:33.970584    30 Util.cpp:166] commandline:  --num_gradient_servers=5 --ports_num_for_sparse=1 --use_gpu=0 --trainer_count=1 --num_passes=1 --ports_num=1 --port=7164
[INFO 2017-11-02 03:27:35,513 layers.py:2556] output for __conv_pool_0___conv: c = 20, h = 24, w = 24, size = 11520
[INFO 2017-11-02 03:27:35,514 layers.py:2684] output for __conv_pool_0___pool: c = 20, h = 12, w = 12, size = 2880
[INFO 2017-11-02 03:27:35,514 layers.py:2556] output for __conv_pool_1___conv: c = 50, h = 8, w = 8, size = 3200
[INFO 2017-11-02 03:27:35,515 layers.py:2684] output for __conv_pool_1___pool: c = 50, h = 4, w = 4, size = 800
I1102 03:27:35.520740    30 GradientMachine.cpp:94] Initing parameters..
I1102 03:27:35.522634    30 GradientMachine.cpp:101] Init parameters done.
panic: context deadline exceeded

goroutine 17 [running, locked to thread]:
main.paddle_new_etcd_master_client(0x7fc7bbffb4d4, 0x5, 0x40, 0x1c400000008)
	/paddle/build/go/src/github.com/PaddlePaddle/Paddle/go/master/c/client.go:85 +0x132
main._cgoexpwrap_3d60921c95c9_paddle_new_etcd_master_client(0x7fc7bbffb4d4, 0x5, 0x40, 0xd8bb14b74dceb600)
	command-line-arguments/_obj/_cgo_gotypes.go:100 +0x41
Aborted
job returned 134...setting pod return message...
===============================
termination log wroted...

Hi @helinwang

The max cluster CPU util is capped around 85%, it would be great if we can explain why this happens, to the readers.

I think the reason is the same as #465 , There is a calico Pod which request 250m CPU running on each Node, and the Trainer Pod request 5 CPU in the epxeriment, so always some CPU is idle.

case 1 there are many pending jobs. Maybe we need to be more aggressive for scale down, now we only scale down when util reaches 100%, maybe we should scale down when reaching 90% or 95%.

I submit a PR to fix this problem, #467

Update #453

Run case1 for 10 mins for each experiment, the same as case2.
Upload the logs to the ./experiment/result foler.
Update the contorller Docker image to registry.baidu.com/paddlepaddle/controller:yx2, build from #467

Update:
"Print less log, fix unit test" for https://github.com/PaddlePaddle/cloud/pull/467

Problems:

Not very related to the experiment, but kubectl get events sometimes shows:

2m         2m          1         mnist4-trainer-xlqk1    Pod                                         Warning   FailedMount        kubelet, yq01-jpaas-paddle01-wrk18.yq01.baidu.com    Unable to mount volumes for pod "mnist4-trainer-xlqk1_helinwang-baidu-com(e8f619c6-c024-11e7-aa74-6c92bf4727a8)": timeout expired waiting for volumes to attach/mount for pod "helinwang-baidu-com"/"mnist4-trainer-xlqk1". list of unattached/unmounted volumes=[public mulan default-token-hkc45]

TODO:

Let's always use the latest #453 for the experiment, as it contains changes to experiment script, train_ft.py.
Let's make our experiment command line exactly the same:
I have found that when PASSES=2, the experiment log for PASS1 and PASS2 differs. So let's always use PASSES=1.

case 1:
TAG=round_0 AUTO_SCALING=ON PASSES=1 JOB_COUNT=20 ./run.sh start case1
TAG=round_1 AUTO_SCALING=ON PASSES=1 JOB_COUNT=20 ./run.sh start case1
...
TAG=round_0 AUTO_SCALING=OFF PASSES=1 JOB_COUNT=20 ./run.sh start case1
TAG=round_1 AUTO_SCALING=OFF PASSES=1 JOB_COUNT=20 ./run.sh start case1
case 2:
TAG=round_0 AUTO_SCALING=ON PASSES=1 JOB_COUNT=5 ./run.sh start case2
TAG=round_1 AUTO_SCALING=ON PASSES=1 JOB_COUNT=5 ./run.sh start case2
...
TAG=round_0 AUTO_SCALING=OFF PASSES=1 JOB_COUNT=5 ./run.sh start case2
TAG=round_1 AUTO_SCALING=OFF PASSES=1 JOB_COUNT=5 ./run.sh start case2

Latest Graphs:

Update #453

Package train_ft.py in the Docker image, and modify the run.sh to use the new Image to run the job.
Push the time series data under the log folder.

Update #453

Plotter: support averaging inputs on different timestamps

Problem:
Sometimes case 2 stuck at:

waiting for collector exit, generated file  ./out/case2-mnist-ON-5-1-ON-400-round_3/mnist-case1-pass0.csv
waiting for collector exit, generated file  ./out/case2-mnist-ON-5-1-ON-400-round_3/mnist-case1-pass0.csv
waiting for collector exit, generated file  ./out/case2-mnist-ON-5-1-ON-400-round_3/mnist-case1-pass0.csv
waiting for collector exit, generated file  ./out/case2-mnist-ON-5-1-ON-400-round_3/mnist-case1-pass0.csv

我们最后会在timestamp 550截断试验（之后会kill job，实验数据没有意义）。
avg pending time不被影响。
avg cpu util受影响，统计方式是如下命令行：
at out/case1-mnist-OFF-20-1-ON-400-round_*/mnist-case1-pass0.log|awk -F, '{if ($1<=550) {a=a+$2; b=b+1}} END {print a/b}'

Push a PR: #470

Fix a bug, the controller does rewrite the node resource when executing the DryRun.
Fix the long pending time in a track way, shrink the time interval of submitting jobs.
Remainding Pods after delete the job with a track way: kubectl delete pod `kubectl get pods | | grep -v Terminating | awk '{print $1}'`
Rerun the experiment,  update the log files: out/case1-mnist-ON-20-1-ON-400-round_{0-9}, out/case1-mnist-OFF-20-1-ON-400-round_{0-3}

Seems something wrong with the state of autoscaler, I have to kill the pod between every run of case 1 to see the expected experiment result.
for i in `seq 2 9`; do TAG=round_$i AUTO_SCALING=ON PASSES=1 JOB_COUNT=20 ./run.sh start case1; kc delete po `kc get pod --namespace paddlecloud|grep training |awk  '{print $1}'` --namespace paddlecloud; sleep 10; done

Seems something wrong with the state of autoscaler, I have to kill the pod between every run of case 1 to see the expected experiment result.

@Yancey1989 is that a bug of case 1 job submit scripts, it's not deleting jobs after they finishes?

@typhoonzero , Yes, I fixed it by a tracking way, but I think it's a bug of controller or cloud server..


[FEA] Benchmark Suite for Inference

We need to create a benchmark suite to measure the running time of the inference queries for different input data shapes and models. This benchmark suite will help us to spot where the bottlenecks in the whole inference pipeline. Benchmark suite should at least cover the running time measurements of the points below;

[ ] Each applied transformations in NVTabular and overall inference of NVTabular
[ ] NVTabular + TF ensemble model
[ ] NVTabular + PyTorch ensemble model
[ ] NVTabular + HugeCTR ensemble model
[ ] All communication and data conversion costs in the ensemble models
[ ] Add the measurements to nightly CI

+1 I've observed that the NVTab+HugeCTR Triton ensemble is significantly slower than querying the HugeCTR Triton backend directly (using offline NVTab preprocessed data, but doing CSR conversion live) . 700ms vs. 40ms. It would be good to have an idea of how long each phase of the ensemble inference take.

@shashank3959

+1 I have the same observation as @vinhngx

@shashank3959 @vinhngx Agreed - the inference latency is unacceptably bad in v0.5. Improving this is a major focus of v0.6.
I've added some benchmarking scripts here using tritons perf_analyzer: https://github.com/NVIDIA/NVTabular/pull/868. There are some graphs of times for the rossmann/movielens datasets there, including some of the speedups we're expecting in 0.6 (like rossmann should go from ~150ms down to around ~2ms per request).
When you're seeing 700ms latency what model is this ? Also is this on the first request ? I was seeing a case with the movielens example where the first request was > 1s but subsequent requests were on the order of 22ms.

This is great improvement.  The 700ms inference observed is for the movie lens demo.
HugeCTR inference time is ~7ms.
We shall verify this at our end with the Movie demo. @shashank3959

Verified that with Merlin v0.6 image, inference time of our pipeline is reduced from ~700ms to ~40ms, which is a huge improvement :)
@shashank3959 @benfred FYI

As for the model,  you can find and e2e notebook here with inference at the end. Basically, it's a full-sized DLRM model on movielens data, with 23 cat and 171 cont. engineered features.
https://gitlab-master.nvidia.com/vinhn/movie-recsys/-/blob/hugectr/RecSys/notebooks/hugectr/hugeCTR-train-and-inference-v0.6.ipynb