Can't login with AAD MFA "Error: Failed to get token" without restart of ADS

Azure Data Studio Version:
OS Version:

Steps to Reproduce:

Select accounts and add an azure account with MFA enabled, this works fine and no prompt was given
Select a database, in the azure panel I can see that its logged into azure and can see the server and database but when expanding the database the error pops up

The logs from the console in developer tools state:
WARN Connection providers incorrectly registered. Defaulting to SQL Azure resource,
log.ts:313   ERR Error: Failed to get token
at t.AzureAccountProvider._getAccountSecurityToken (c:\Program Files\Azure Data Studio\resources\app\extensions\azurecore\dist\extension.js:2:525749)
at process.processTicksAndRejections (node:internal/process/task_queues:96:5)
4. Relaunching ADS fixed the issue, but this wasn't obvious nor should I have to do this

Does this issue occur when all extensions are disabled?: Yes/No
Tricky to answer, I tried this, and it started to work. So then I tried again with extensions enabled and now it all works. See step 4 from above.

Hi @AnthonyDewhirst

Tricky to answer, I tried this, and it started to work. So then I tried again with extensions enabled and now it all works. See step 4 from above.

Let us know if you hit the issue again, please also provide ADS version when you do, so we can provide support accordingly.
Thanks!

Closing as inactive, likely fixed with #22140


memberOf: aggregate on element identity, rather than a hash of the concept

See #113.
Currently the memberOf function works by creating a hash of the input concept, and joining across to the expansion result using this hash. This can result in the loss of duplicate values, which is technically incorrect.
As part of #113 we will develop a new approach to preserving element identity within a resource, and we can use this to fix this problem within memberOf.

Closing this to be done as part of #190.


Unexpected Response Code 406 for WebPush

I get lots of log entries about expected response code 406 when sending web push notifications.
Unfortunately I'm not able to see the correlation to an event or user.
What's the exact meaning of this 406? Is it an issue or an expectable behaviour?

I have no idea. For Edge it seems to be some kind of throttling:
https://learn.microsoft.com/en-us/answers/questions/940324/406-not-acceptable-may-be-returned-when-sending-a.html

Do you know what kind of endpoints are related to this?

hm you could be right. As mentioned I'm not absolutely sure which message/user is responsible for the error. But around these issues I have users with the wns tokens (https://wns2-par02p.notify.windows.com/w)


Settings UX - Slider

This is a feature request to add sliders for settings that take values from A to B.

Which settings would you like to see this for? Many number settings don't have max/min values so a slider might not be a good fit.


[improve] [deploy] Configurable init container images

Description
This PR enables configurable init container images.
In line with other images in this chart, this PR makes sure you can configure registry, repository and tag all separately.
It also adds a imagePullPolicy.
To ensure backwards compatibility I left the redis.image and mongodb.image properties in there. But imho these should be removed in a future major chart version.
Fixes #32844
Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[x] No

Summary by CodeRabbit

New Features

Enhanced Helm chart configurations to allow customizable image references and pull policies for Redis and MongoDB init containers.

keep open

@sharat87 @pratapaprasanna Possible to have a look at this? Anything you want me to change?

@sharat87 @pratapaprasanna Possible to have a look at this? Anything you want me to change?

bump


[BUG] Service Detail Page Admin users cannot see pending applicants

Describe the bug
Admin users cannot see pending applicants in the application section of the Service Detail page.
What Did You Want
As an admin user, I wanted to all the applicants of a service. Only approved applicants were visible, pending applicants were not visible to the admin user.
To Reproduce
Steps to reproduce the behavior:

As admin go to Service Detail page of a service which already has at least one approved and one pending applicants.
Scroll down to the applications section under the service detail.
Admin cannot see the pending applicants.

Expected behavior
All applicants of a service should be visible to admin.
Result behavior
No error message. Missing list-item.
Screenshots
Desktop (please complete the following information):

OS: Windows
Browser: Chrome
Version: -

Additional context

Bug is fixed and can be tested via bug/68_73_74_92_93_100


[BUG]: Cannot read property 'updateStartupCommandAndRuntimeStack' of undefined

Task name
Azure Web App
Task version
1.227.0
Environment type (Please select at least one enviroment where you face this issue)

[ ] Self-Hosted
[X] Microsoft Hosted
[ ] VMSS Pool
[ ] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Azure DevOps Server Version (if applicable)
No response
Operation system
Linux - Ubuntu
Task log
Starting: Deploy Azure Web App : leandropythonsample
==============================================================================
Task         : Azure Web App
Description  : Deploy an Azure Web App for Linux or Windows
Version      : 1.227.0
Author       : Microsoft Corporation
Help         : https://aka.ms/azurewebapptroubleshooting
==============================================================================
Got service connection details for Azure App Service:'leandropythonsample'
(node:1917) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
$leandropythonsample
leandropythonsample.scm.azurewebsites.net
Package deployment using ZIP Deploy initiated.
Deploy logs can be viewed at https://leandropythonsample.scm.azurewebsites.net/api/deployments/d5e0fb41-b459-4977-9e9c-ad198ff63182/log
Successfully deployed web package to App Service.
##[error]TypeError: Cannot read property 'updateStartupCommandAndRuntimeStack' of undefined
Successfully updated deployment History at https://leandropythonsample.scm.azurewebsites.net/api/deployments/54751696884483486
App Service Application URL: https://leandropythonsample.azurewebsites.net
Finishing: Deploy Azure Web App : leandropythonsample

Relevant log output
##[error]TypeError: Cannot read property 'updateStartupCommandAndRuntimeStack' of undefined

Aditional info
Steps to reproduce:
1) Python Application (https://github.com/Azure-Samples/msdocs-python-flask-webapp-quickstart)
2) Create Azure App Service - Runtime Python
3) Create Azure Service Connection using publish profile
4) Create YML pipeline
- task: AzureWebApp@1
    displayName: 'Deploy Azure Web App : leandropythonsample'
    inputs:
        azureSubscription: '$(publishProfile)'
        appType: 'webAppLinux'
        appName: '$(webAppName)'
        package: '$(Pipeline.Workspace)/drop/$(Build.BuildId).zip'
        startUpCommand: 'gunicorn --bind=<IP_ADDRESS> --workers=4 startup:app'
        runtimeStack: 'PYTHON|3.8'

Hi @lsprado have you tried using a service connection based on “Service Principal” ? This might work under the same configuration.

service connection based on “Service Principal” will resolve this issue.


sqlx_cli can not read database_url from .env in win10

why? and when you migrate with error,you have to fix _sqlx_migrations mannuly.this is boring.

Please include the error you get from sqlx-cli.

error: The following required arguments were not provided:
--database-url <DATABASE_URL>
USAGE:
sqlx database create --database-url <DATABASE_URL>
For more information try --help

Have you checked your in the right directory for the .env to be detected by sqlx-cli?
If so, is DATABASE_URL=.. in your .env file correctly?

Have you checked your in the right directory for the .env to be detected by sqlx-cli?
If so, is DATABASE_URL=.. in your .env file correctly?

my project directory:
|---.env
|---src
I had add DATABASE_URL= in my .env file,and this directory is working in ubuntu not windows


Gaps and changes in the API Stewardship Board activities due to TypeSpec

The purpose of this Epic is to define the gaps on the API Review (management and data plane) process inside the Azure SDK Release process affected by Cadl.
Some general parts on the step that need to be accounted for:

APIView should support Cadl in some sort. Issue looking into that is https://github.com/Azure/azure-sdk-tools/issues/1208
Information communicated to API Stewardship around Cadl state and breaking changes
How will the approval take place? With a label on the PR like today? With a button on APIView?
Follow up with teams?
Other items: https://github.com/Azure/azure-sdk-tools/issues/5760

wiki will have to be updated to include information about Cadl https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/665/Azure-REST-API-Stewardship-Review

I place the milestone to be '2023-01'. This could be closed when Release Planner can cover both Data Plane and Management Plane SDK release. Notification and dashboard requirements can be tracked with separate epics.

@mikekistler I assigned you to this issue.  This is related to some of the process gaps I wanted to discuss yesterday but we did not have enough time.  I will setup a meeting so we can walk through the open issues related to Release Planner and Cadl and API Reviews.

@ladonnaq Is there still work do to on this or can we close?

Closing this issue.  Outstanding APIView todo being tracked in this GitHub issue - https://github.com/Azure/azure-sdk-tools/issues/5760


Roadmap for Start/Stop v2? Is there a committed schedule for Start/Stop v2 GA?

Thanks for putting together this solution. Is there a publicly announced date for Microsoft to make Start/Stop v2 generally available? Given the statement that the v1 solution support ends in 2022 I would like to know our options for long term support for this type of automated solution. Additionally, are there any plans to open source the underlying functions app?
Thanks again!

How about the GA date? If I read the date correctly in the comment above 1st November 2021, but still all docs state preview?

Is there a GA date at this time?

@balas77
I think v2 is already GA, but there are preview keyword in marketplace
https://github.com/microsoft/startstopv2-deployments/issues/88


Testplan for Tilgangsliste Autorisasjon

Delivery
<EPIC/FEATURE/CASE>

Roadmap

Involved teams
@team-...

Due date
xx.xx.xxxx

Test period
xx.xx.xxxx - xx.xx.xxxx

Dependencies

Dependency
Owner
Status

Functional tests

✅ OK, ⚠ In progress, 🛑 Failed
During test period run tests covering business needs and requirements listed here

Scenario
Test data
Done by
Importance
Level
Status
Comment

@...
High

✅

@...
Low

🛑

Non-functional tests

Performance tests: Link to runs and documentation when needed
Security tests: Link to documentation when needed

Clarifications

Question
Answer
**Date **

⚠ Out of scope

List discussed functionality out of scope or that might be relevant in a later release

:information_source: Useful links
Sketches
Architecture diagrams
Test environment
Testd ata
Link to milestone

@Siri-Anna Blocked pga under utvikling


Defect found in 'Default Prompt Suggestions' feature within the Admin Panel.

Issue 1: When attempting to add more than 8 prompts under 'Default Prompt Suggestions', no placeholder is displayed in the UI, preventing users from adding new prompts. This results in a blocked interface.
Issue 2: Additionally, if all existing prompts are deleted and an attempt is made to add new ones from scratch, only 2 prompts can be added before the add icon becomes unresponsive. When clicked, the add icon fails to introduce a new placeholder for additional prompt entries.
Simulation Steps:

Access the Admin Panel.
Click on the 'Settings' option.
Select 'Interface'.
Scroll down to locate the 'Default Prompt Suggestions' feature.
Attempt to add more than 8 prompts.
Delete all existing prompts and then try adding new ones from scratch, observing that only 2 prompts can be added.

Expected Results:
The add icon should display a new placeholder to initiate prompt entry.
Actual Results:

The add icon becomes unresponsive when there are already 8 prompts already in place.
The add icon becomes unresponsive when after adding two prompts (After deleting all the existing prompts)

Unable to reproduce the neither of these issues, the content must be provided first before you can add additional prompt suggestions.


Input Field Screen

I would like to improve the Input Field Screen UI. The text fields look very similar. I would like to add circular text fields of all the types. Different text fields specific for phone number, address, email etc. I will also add the validation of various text like emails and phone numbers into the fields.
Please assign me this issue. Thank you.
GGSOC'23

Hey @Debajyoti14!! I have send a pull request for this issue. Kindly review it. Thanks.


The task includes an option with an undefined variable. The error was:

Describe the version
version about:

kubean 0.15.3
kubespray
kubenetes 1.29.5
what CNI and itsversion

fatal: [localhost]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: {{ hostvars[groups['kube_control_plane'][0]].ansible_host }}: 'dict object' has no attribute 'kube_control_plane'. 'dict object' has no attribute 'kube_control_plane'. {{ hostvars[groups['kube_control_plane'][0]].ansible_host }}: 'dict object' has no attribute 'kube_control_plane'. 'dict object' has no attribute 'kube_control_plane'\n\nThe error appears to be in '/kubespray/kubeconfig.yml': line 52, column 7, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n    - name: Update kubeconfig server\n      ^ here\n"}

Describe the bug
A clear and concise description of what the bug is.
root@k8s-master01:~/kubean/examples/install/2.mirror# cat Cluster.yml
# Copyright 2023 Authors of kubean-io
# SPDX-License-Identifier: Apache-2.0

apiVersion: kubean.io/v1alpha1
kind: Cluster
metadata:
  name: cluster1-online
  labels:
    clusterName: cluster1-online
spec:
  hostsConfRef:
    namespace: kubean-system
    name: online-hosts-conf
  varsConfRef:
    namespace: kubean-system
    name: online-vars-conf

root@k8s-master01:~/kubean/examples/install/2.mirror# cat ClusterOperation.yml

cat > ClusterOperation.yml <<EOF
# Copyright 2023 Authors of kubean-io
# SPDX-License-Identifier: Apache-2.0

apiVersion: kubean.io/v1alpha1
kind: ClusterOperation
metadata:
  name: cluster1-online-install-ops
spec:
  cluster: cluster1-online
  image: ghcr.m.daocloud.io/kubean-io/spray-job:v0.15.3 # Please replace <TAG> with the specified version, such as v0.4.9
  actionType: playbook
  action: cluster.yml
  preHook:
    - actionType: playbook
      action: ping.yml
    - actionType: playbook
      action: disable-firewalld.yml
  postHook:
    - actionType: playbook
      action: kubeconfig.yml
    - actionType: playbook
      action: cluster-info.yml
EOF

root@k8s-master01:~/kubean/examples/install/2.mirror# cat HostsConfCM.yml

cat > HostsConfCM.yml <<EOF
# Copyright 2023 Authors of kubean-io
# SPDX-License-Identifier: Apache-2.0

apiVersion: v1
kind: ConfigMap
metadata:
  name: online-hosts-conf
  namespace: kubean-system
data:
  hosts.yml: |
    all:
      hosts:
        node1:
          ip: <IP_ADDRESS>
          access_ip: <IP_ADDRESS>
          ansible_host: <IP_ADDRESS>
          ansible_connection: ssh
          ansible_user: root
          ansible_password: mark
        node2:
          ip: <IP_ADDRESS>
          access_ip: <IP_ADDRESS>
          ansible_host: <IP_ADDRESS>
          ansible_connection: ssh
          ansible_user: root
          ansible_password: mark
        node3:
          ip: <IP_ADDRESS>
          access_ip: <IP_ADDRESS>
          ansible_host: <IP_ADDRESS>
          ansible_connection: ssh
          ansible_user: root
          ansible_password: mark
        node4:
          ip: <IP_ADDRESS>
          access_ip: <IP_ADDRESS>
          ansible_host: <IP_ADDRESS>
          ansible_connection: ssh
          ansible_user: root
          ansible_password: mark
      children:
        kube_control_plane:
          hosts:
            node1:
            node2:
        kube_node:
          hosts:
            node1:
            node2:
            node3:
            node4:
        etcd:
          hosts:
            node1:
            node2:
            node3
        k8s_cluster:
          children:
            kube_control_plane:
            kube_node:
        calico_rr:
          hosts: {}
EOF

root@k8s-master01:~/kubean/examples/install/2.mirror# cat VarsConfCM.yml
# Copyright 2023 Authors of kubean-io
# SPDX-License-Identifier: Apache-2.0

apiVersion: v1
kind: ConfigMap
metadata:
  name: online-vars-conf
  namespace: kubean-system
data:
  group_vars.yml: |
    container_manager: containerd
    k8s_image_pull_policy: IfNotPresent
    kube_network_plugin: calico
    kube_network_plugin_multus: false
    kube_proxy_mode: iptables
    enable_nodelocaldns: false
    etcd_deployment_type: kubeadm
    override_system_hostname: false
    ntp_enabled: true

    download_run_once: true
    download_container: false
    download_force_cache: true
    download_localhost: true

    additional_sysctl:
    - { name: kernel.pid_max, value: 4194304 }

    calico_cni_name: calico
    calico_felix_premetheusmetricsenabled: true
    calico_feature_detect_override: "ChecksumOffloadBroken=true" # FIX https://github.com/kubernetes-sigs/kubespray/pull/9261

    ##https://github.com/kubernetes-sigs/kubespray/blob/master/docs/mirror.md
    gcr_image_repo: "gcr.m.daocloud.io"
    kube_image_repo: "k8s.m.daocloud.io"
    docker_image_repo: "docker.m.daocloud.io"
    quay_image_repo: "quay.m.daocloud.io"
    github_image_repo: "ghcr.m.daocloud.io"
    files_repo: "https://files.m.daocloud.io"

    kubeadm_download_url: "{{ files_repo }}/dl.k8s.io/release/{{ kubeadm_version }}/bin/linux/{{ image_arch }}/kubeadm"
    kubectl_download_url: "{{ files_repo }}/dl.k8s.io/release/{{ kube_version }}/bin/linux/{{ image_arch }}/kubectl"
    kubelet_download_url: "{{ files_repo }}/dl.k8s.io/release/{{ kube_version }}/bin/linux/{{ image_arch }}/kubelet"
    cni_download_url: "{{ files_repo }}/github.com/containernetworking/plugins/releases/download/{{ cni_version }}/cni-plugins-linux-{{ image_arch }}-{{ cni_version }}.tgz"
    crictl_download_url: "{{ files_repo }}/github.com/kubernetes-sigs/cri-tools/releases/download/{{ crictl_version }}/crictl-{{ crictl_version }}-{{ ansible_system | lower }}-{{ image_arch }}.tar.gz"
    etcd_download_url: "{{ files_repo }}/github.com/etcd-io/etcd/releases/download/{{ etcd_version }}/etcd-{{ etcd_version }}-linux-{{ image_arch }}.tar.gz"
    calicoctl_download_url: "{{ files_repo }}/github.com/projectcalico/calico/releases/download/{{ calico_ctl_version }}/calicoctl-linux-{{ image_arch }}"
    calicoctl_alternate_download_url: "{{ files_repo }}/github.com/projectcalico/calicoctl/releases/download/{{ calico_ctl_version }}/calicoctl-linux-{{ image_arch }}"
    calico_crds_download_url: "{{ files_repo }}/github.com/projectcalico/calico/archive/{{ calico_version }}.tar.gz"
    helm_download_url: "{{ files_repo }}/get.helm.sh/helm-{{ helm_version }}-linux-{{ image_arch }}.tar.gz"
    crun_download_url: "{{ files_repo }}/github.com/containers/crun/releases/download/{{ crun_version }}/crun-{{ crun_version }}-linux-{{ image_arch }}"
    kata_containers_download_url: "{{ files_repo }}/github.com/kata-containers/kata-containers/releases/download/{{ kata_containers_version }}/kata-static-{{ kata_containers_version }}-{{ ansible_architecture }}.tar.xz"
    runc_download_url: "{{ files_repo }}/github.com/opencontainers/runc/releases/download/{{ runc_version }}/runc.{{ image_arch }}"
    containerd_download_url: "{{ files_repo }}/github.com/containerd/containerd/releases/download/v{{ containerd_version }}/containerd-{{ containerd_version }}-linux-{{ image_arch }}.tar.gz"
    nerdctl_download_url: "{{ files_repo }}/github.com/containerd/nerdctl/releases/download/v{{ nerdctl_version }}/nerdctl-{{ nerdctl_version }}-{{ ansible_system | lower }}-{{ image_arch }}.tar.gz"
    cri_dockerd_download_url: "{{ files_repo }}/github.com/Mirantis/cri-dockerd/releases/download/v{{ cri_dockerd_version }}/cri-dockerd-{{ cri_dockerd_version }}.{{ image_arch }}.tgz"

How To Reproduce
Steps to reproduce the issue:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots and log
If applicable, add screenshots and log to help explain your problem.
Additional context
Add any other context about the problem here.

[WARNING]:  * Failed to parse /conf/hosts.yml with auto plugin: We were unable
to read either as JSON nor YAML, these are the errors we got from each: JSON:
Expecting value: line 1 column 1 (char 0)  Syntax Error while loading YAML.
could not find expected ':'  The error appears to be in '/conf/hosts.yml': line
47, column 5, but may be elsewhere in the file depending on the exact syntax
problem.  The offending line appears to be:          node3     k8s_cluster:
^ here
[WARNING]:  * Failed to parse /conf/hosts.yml with yaml plugin: We were unable
to read either as JSON nor YAML, these are the errors we got from each: JSON:
Expecting value: line 1 column 1 (char 0)  Syntax Error while loading YAML.
could not find expected ':'  The error appears to be in '/conf/hosts.yml': line
47, column 5, but may be elsewhere in the file depending on the exact syntax
problem.  The offending line appears to be:          node3     k8s_cluster:
^ here

A colon( : ) is missing.
root@k8s-master01:~/kubean/examples/install/2.mirror# cat HostsConfCM.yml

cat > HostsConfCM.yml <<EOF
# Copyright 2023 Authors of kubean-io
# SPDX-License-Identifier: Apache-2.0

apiVersion: v1
kind: ConfigMap
metadata:
  name: online-hosts-conf
  namespace: kubean-system
data:
  hosts.yml: |
    all:
      hosts:
        node1:
          ip: <IP_ADDRESS>
          access_ip: <IP_ADDRESS>
          ansible_host: <IP_ADDRESS>
          ansible_connection: ssh
          ansible_user: root
          ansible_password: mark
        node2:
          ip: <IP_ADDRESS>
          access_ip: <IP_ADDRESS>
          ansible_host: <IP_ADDRESS>
          ansible_connection: ssh
          ansible_user: root
          ansible_password: mark
        node3:
          ip: <IP_ADDRESS>
          access_ip: <IP_ADDRESS>
          ansible_host: <IP_ADDRESS>
          ansible_connection: ssh
          ansible_user: root
          ansible_password: mark
        node4:
          ip: <IP_ADDRESS>
          access_ip: <IP_ADDRESS>
          ansible_host: <IP_ADDRESS>
          ansible_connection: ssh
          ansible_user: root
          ansible_password: mark
      children:
        kube_control_plane:
          hosts:
            node1:
            node2:
        kube_node:
          hosts:
            node1:
            node2:
            node3:
            node4:
        etcd:
          hosts:
            node1:
            node2:
            node3     <------ here
        k8s_cluster:
          children:
            kube_control_plane:
            kube_node:
        calico_rr:
          hosts: {}
EOF


Relax dependencies on parallel and deepseq

Fairly self-explanatory.
The update on deepseq was for the removal of containers instances – which we don't use.
The update on parallel I didn't check carefully, but I don't think it's important – seems to be just an API addition.

Thanks!

Pushed to hackage.


Create favicon

I'll do this, do we have an icon to shrink down, or is a brand new icon?
On Fri, 16 Oct 2015 at 07:14 Dan Kohn<EMAIL_ADDRESS>wrote:

—
Reply to this email directly or view it on GitHub
https://github.com/linuxfoundation/cii-best-practices-badge/issues/88.

All done by latest changes.


Vid2vid not showing up in node options

I downloaded vid2vid using the manager for Comfy UI but I still don't see the node options...what else do I need to do? Run the python requirement? Where/how would I install that?

Same issue.

Resolved by modifying 3 lines in ComfyUI\custom_nodes\comfy_vid2vid\sd. :
import torch
from comfy import model_management, model_patcher
from comfy.sd import load_model_weights, VAE, CLIP
from comfy.lora import model_lora_keys_unet, model_lora_keys_clip

ComfyUI\custom_nodes\comfy_vid2vid\sd. py:
from comfy.sd import load_model_weights, VAE, CLIP
from comfy.model_patcher import ModelPatcher
from comfy.lora import model_lora_keys_unet, model_lora_keys_clip
i'v tried this, it works

Worked for me as well - thanks mancat49

Worked, Node got loaded, thanks @mancat49

Almost worked for me -
Still had errors with ImportError: cannot import name 'load_model_weights' from 'comfy.sd'
commenting out this line solved the issue for me:
#from comfy.lora import model_lora_keys_unet, model_lora_keys_clip


Add support for Rails 5 ActionDispatch::IntegrationTest

I'm not sure if this is the best approach, but I got it working on a Rails 5.1.x app.
The underlying problem is that in ActionDispatch::IntegrationTest a request object is not available before the request is made, unlike in old ActionController::TestCase (link). In current Rails documentation, a test helper that sends a real request is suggested, so by overriding #sign_in_as it can be fixed.
I don't think this PR is complete, since if session route name is changed it will raise an error, but I wanted to know first if this would be an acceptable approach.
An alternative workaround would be to set the request object as ActionController::TestCase does.

I'm going to close this in favor of encouraging people to just do these steps within their tests.


How to trigger game over screen for a custom character.

Describe your problem here.
Even though I have the game over implemented in the game it  keeps using bf's default  game over for some reason. Am i supposed to code a specific thing or is this a bug of some sort?
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No response

this or using setPropertyFromClass may help.
Example script: (Click here)

tank you for your service


fix(wizard): class scope

Summary

Class selector scope

Change List (commits, features, bugs, etc)

items_here

Related Issues

Closes IBM/carbon-addons-iot-react#NUMBER

Acceptance Test (how to verify the PR)

tests here

:tada: This PR is included in version 1.52.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.52.1 :tada:
The release is available on npm package (@release-1.x dist-tag)
Your semantic-release bot :package::rocket:


Display Stories Users in Admin Panel

Description
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Code quality improvements

Checklist

[ ] I have tested this code
[ ] I have updated the documentation

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 13 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 36.011%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/pages/academy/adminPanel/subcomponents/storiesUserConfigPanel/StoriesUserConfigPanel.tsx
0
13
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
5473

Relevant Lines:
14232

💛  - Coveralls

Superseded by #2763.


Remove problematic hiding scripts

Issue 1:
According to user reports, setting Xiaomi region props will break booting. This may be caused by some framework internal check. As this is for cross-region flash which is not used for hide, remove it.
Issue 2:
We have seen applications using new ways to detect abnormal environments. One of them is /sys/fs/selinux, as this dir has +x permission for all users. This makes running 'stat' command on nodes possible.
Here we have a problem. Running busybox's 'cat' on files will change its access time (not seen on toybox's 'cat' though). This
can be easily detected by 'stat /sys/fs/selinux', seeing access time which does not start with '1970-01-01'.
This check is actually useless at all. Chmod +644 the node will make 'stat' impossible, thus leading to more detection. Thus remove the check. This method is seen on multiple apps in recent research.

Leave SELinux check for now. Removing causes attestation failing on some ROMs.

Is it possible that this is the reason why I encountered the issue with Blind?
https://github.com/LSPosed/LSPosed/issues/2570


Build a primitive spell checker utility given our WordFind dictionary

Given a reasonably fast lookup this should be relatively simple. What is hard is the user interface and coming up with spelling suggestions.

Apparently "ispell" uses this algorithm (with distance 1) to produce spelling suggestions: https://en.wikipedia.org/wiki/Damerau–Levenshtein_distance

Needs the work done in #411 first so the dictionary is accessible to other classes.


error when run genereate_tfrecord.py

when I run the genereate_tfrecord.py,the terminal display "tensorflow.python.framework.errors_impl.NotFoundError: raccoon-2.jpg; No such file or directory", I don't find  the solve way

I guess that's because the path mentioned in the csv file has just FILENAME and you files are in the directory IMAGES/FILENAME . You can edit your csv or just paste all images in your current directory.


add test execution with zyborg/dotnet-tests-report@v1

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] Performance improvement
[ ] Refactoring (so no functional change)
[ ] Other (docs, build config, etc)

Checklist:

[ ] I've added tests for my code. (most of the time mandatory)
[ ] I have added an entry to the changelog. (mandatory)
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Without GIST support it was not working, because the message was too large.
The GIST support requires write access to create GIST for a particular user (mine?) that is not very nice.
It created this nice GIST BTW: https://gist.github.com/gasparnagy/8e57af46b4b5eeac2af2459fd7700cb5
So I think this tool is not for us at the end...


[Bug]: Red errors about not loading melon

All of the following criteria must be met

[X] All Requirements must be installed.
[X] Changed the title so that it doesn't just says "[Bug]: "
[X] I have searched the GitHub issues for my bug, even in the closed issues.

All of the following are optional to answer

[X] Tried reinstalling the Game.
[X] Tried reinstalling MelonLoader.
[X] Tried restarting PC.
[X] Was able to see the Start Screen.

Describe the issue.
Latest.log
Alot of red errors, dont understand what is happening, melon is 0.5.7, TKAftermarket and TKBasics is the newsest
Did you attach your log file?
Yes, I attached my log file to the text box above.

Buy the game.


Does this work with OpenCVSharp4? or is it frozen at v3.2?

I have been using OpenCVSharp4, and would like to continue with that, but just realized I would like to port to Android.

Any guidance on how to create the OpenCVSharpExtern.so file for Android.
What were the steps followed to generate this for 3.x version?

Same question here, anybody can help with compiling opencv 4 to OpenCvSharpExtern with Android build enabled?


Merge 5.0.0-alpha to develop

What is the purpose of the change
Merge  RIP-19 pop consumer，RIP-21 logic queue, RIP-26 batch message features into develop.
Several PRs that have not been merged in 5.0.0-alpha will also be included
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage decreased (-2.05%) to 49.695% when pulling 176e0d5c225a15e6c24a065325eed6eabc9cb1a2 on 5.0.0-beta into 8cd998829ab2c6f94ca6ad6d285f56f455e97790 on develop.

Codecov Report

Merging #3988 (0b7291b) into develop (40d9505) will decrease coverage by 2.18%.
The diff coverage is 27.56%.

@@              Coverage Diff              @@
##             develop    #3988      +/-   ##
=============================================
- Coverage      47.68%   45.50%   -2.19%
- Complexity      4972     5633     +661
=============================================
  Files            633      722      +89
  Lines          42579    50616    +8037
  Branches        5589     6935    +1346
=============================================
+ Hits           20305    23032    +2727
- Misses         19764    24615    +4851
- Partials        2510     2969     +459

Impacted Files
Coverage Δ

.../broker/client/rebalance/RebalanceLockManager.java
12.72% <ø> (ø)

...etmq/broker/plugin/AbstractPluginMessageStore.java
0.00% <0.00%> (ø)

...etmq/broker/processor/ConsumerManageProcessor.java
2.51% <0.00%> (-3.37%)
:arrow_down:

...apache/rocketmq/broker/slave/SlaveSynchronize.java
8.04% <0.00%> (-0.82%)
:arrow_down:

...ocketmq/client/consumer/DefaultMQPullConsumer.java
32.74% <0.00%> (-0.59%)
:arrow_down:

...rg/apache/rocketmq/client/consumer/PullResult.java
87.50% <ø> (ø)

...e/rocketmq/client/exception/MQBrokerException.java
27.77% <0.00%> (-10.69%)
:arrow_down:

...rocketmq/client/exception/MQRedirectException.java
0.00% <0.00%> (ø)

...a/org/apache/rocketmq/client/impl/MQAdminImpl.java
5.06% <0.00%> (-0.03%)
:arrow_down:

...nt/impl/consumer/ConsumeMessageOrderlyService.java
44.91% <0.00%> (-5.44%)
:arrow_down:

... and 273 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40d9505...0b7291b. Read the comment docs.


Add Ruby 3.3 to CI

Runs green on my fork.

This is a good change, thanks.
It also revealed that the required status checks don't run for PRs from forks.  I just added that the workflow should run when a pull request is created.  Please rebase to bring in that change and then this should be good to merge

Rebased.


use html-element-attributes

Right now we've got our own list of html-element-attributes. But we should probably rely on another package that will keep itself updated. So it was suggested in #8 that we use https://github.com/wooorm/html-element-attributes from @wooorm
It doesn't have all the svg attributes (maybe that's something @wooorm would be willing to support?). And it also doesn't have the react-specific props so we'll probably want to keep those too. But for some of this we could simplify this file a bit by using that. Pretty much just need a refactor of that file to replace htmlProps with that file's stuff. One thing that shouldForwardProperty accepts is a tagName which is great because it means we can leverage the knowledge of tag-specific props that html-element-attributes has to be more specific about which props to forward.
I think we should probably add some unit tests for that file as well so it's more clear what that module is capable of/responsible for.
If anyone wants to take this on, let us know!

Hello @kentcdodds, I have been following you since I watched your webpack course. I also read your blog post and watched your videos on open source project contribution.
I do want to contribute to open source projects much more often than how much I am doing now. I believe this issue is a good opportunity and I think I can handle it. With that said, may I give this issue a go?

Absolutely! Let me know how I can help!

Thanks!
For checking html props, do you want me to take into account the tag name? That means isHtmlProp will only check if the property name exists in the global attributes and the attributes that belong to that tag in html-element-attributes. If so, I will have to add more attributes to svgProps because html-element-attributes does not include SVG as a tag and some SVG attributes are missing in svgProps.
Otherwise, I will simply set htmlProps to all the html attributes in html-element-attributes and everything else will stay the same.

Yes, that's actually one of the benefits of going with html-element-attributes is that the attributes are scoped to the tag name and we have that (most of the time) so we can do a better job of determining which props to forward to the underlying element. So, to address your comments/questions:

That means isHtmlProp will only check if the property name exists in the global attributes and the attributes that belong to that tag in html-element-attributes.

Perfect :+1:

I will have to add more attributes to svgProps because html-element-attributes does not include SVG as a tag and some SVG attributes are missing in svgProps.

Also perfect :+1:
Thanks!

Thanks for the reply!
Three questions I have right now:

I tried to do import htmlElementAttributes from 'html-element-attributes' but rollup gives me an error. I think it has to do with it only knowing how to import ES modules and excluding anything in node-modules in the current setup. Sorry, I am not totally familiar with rollup. Do you want me to change the setting necessary to make it work? Or can I simply use require?

I am also trying to write some tests for should-forward-property.js. It obviously would be quite substantial for the tests to cover every single scenario. Maybe we could just write a few examples that cover the general scenarios to be tested for now?

In the main function for should-forward-property.js, it will always forward a property to the react component if the tagName is not a string. I am not 100% sure why. Could you explain a little bit on that?

This might be helpful for listing svg attributes: https://github.com/alexmingoia/svg-attributes

I tried to do import htmlElementAttributes from 'html-element-attributes' but rollup gives me an error. I think it has to do with it only knowing how to import ES modules and excluding anything in node-modules in the current setup. Sorry, I am not totally familiar with rollup. Do you want me to change the setting necessary to make it work? Or can I simply use require?

See https://github.com/paypal/glamorous/pull/26#discussion_r110428820. This is the same issue and they used require to solve, so I think we're OK there.
Also, if you've already branched off to start working be sure to pull in the latest changes since #26 was merged and is related to this issue. (If you didn't do that already of course. 😄 )

@paulmolluzzo
Thank you for the reminder! And I will take a look at https://github.com/alexmingoia/svg-attributes.

Maybe we could just write a few examples that cover the general scenarios to be tested for now?

Yep, just cover some general scenarios :+1:

it will always forward a property to the react component if the tagName is not a string.

Glad you asked, we should have a test for this to demonstrate the reason it is this way and make sure it stays this way. Here's a use case that hopefully will help explain:
import glamorous from 'glamorous'
import ThirdPartyComponent from './third-party-component'

const MyStyledThirdPartyComponent = glamorous(ThirdPartyComponent)({/* styles */})

<MyStyledThirdPartyComponent />

In this case, the rootEl is set to componentsCompwhich will be ThirdPartyComponent. And then when we determine which props to forward, we're forwarding ThirdPartyComponent (which is not a string like 'div' or 'span', but is actually a Function). In that case, we want to forward all props.
Perhaps we could add logic to splitProps to not even do the reduce if the rootEl is not a string because we should forward all the props anyway. But in any case, it'd probably be good to preserve this behavior in should-forward-property.js.
Does that help?
Thanks a bunch!

Hey @jackyho112, once this is merged, you'll want to rebase your branch onto the latest from master and you'll be able to import json files :+1:

@kentcdodds Thanks for the reply. That was helpful and I will definitely take it into account. Also, thanks for the reminder. I will rebase my branch.

Hi folks! 👋

In some other threads I saw that maybe svg tag-names wouldn’t be supported out of the box, does that affect whether a package like html-element-attributes (scoped to tag-names) is needed?

As this project uses HTML attributes, and not DOM properties (e.g., class instead of className, rel instead of relList, for instead of htmlFor), is a package that does that needed? I previously made a module that does that, based on React’s internal code: property-information, but I think it contains more info than needed, so I’m all for making/finding a new module that translates DOM properties to HTML attribute names.

I realized that the package had originally included svg tag names as well, so that's what we went with in #26 (thank you for the packages!)

As this project uses HTML attributes, and not DOM properties (e.g., class instead of className, rel instead of relList, for instead of htmlFor),

That's a good point! I hadn't considered it but we can't quite just use a list of valid html attributes and call it good because React is a little different in some cases. I think a package that can filter React props based on tag name is what we really need. I don't think we need anything that translates DOM properties to HTML attribute names. What we need is basically something like html-element-attributes (that includes svg) that has a mapping of tag names to their valid React props.
Anyone wanna make a package like that?

@kentcdodds Is it cool if I look into it? My branch is supposed to implement a package like that into the library anyway. Since we have decided that html-element-attributes is not the optimal package, I should be responsible for making a suitable one. I don't think it will be that complicated.

Sounds perfect

The react doc says 'React supports all data-* and aria-* attributes as well as these attributes'. Should we just include that logic in should-forward-property.js?

I think we do actually... 🤔

Nvm. We do. 😄

Thanks for your help @jackyho112!


Async iterators blocking the event loop

What is wrong?
Any async iterators that we have need to be explicitely yielding to the event loop, typically on every iteration, though there may be cases where we want to do something more fancy.
How can it be fixed
Search for every implementation of an async iterator and validate that it yields to the event loop.
Known locations:

[ ] https://github.com/ethereum/trinity/blob/7fc8492663ff230e6a7823fc753c530e9f4ba42c/p2p/multiplexer.py#L280-L289
[ ] https://github.com/ethereum/trinity/blob/7fc8492663ff230e6a7823fc753c530e9f4ba42c/trinity/protocol/common/servers.py#L138-L146
[ ] https://github.com/ethereum/trinity/blob/7fc8492663ff230e6a7823fc753c530e9f4ba42c/trinity/_utils/async_iter.py#L29-L41
[ ] https://github.com/ethereum/trinity/blob/7fc8492663ff230e6a7823fc753c530e9f4ba42c/trinity/sync/beam/chain.py#L331-L342
[ ] https://github.com/ethereum/trinity/blob/7fc8492663ff230e6a7823fc753c530e9f4ba42c/trinity/sync/beam/chain.py#L567-L579
[ ] https://github.com/ethereum/trinity/blob/7fc8492663ff230e6a7823fc753c530e9f4ba42c/trinity/sync/full/chain.py#L172-L270

these are all addressed in #1964
however, I do think it would be worth taking another more exhaustive pass over the codebase to try and find any other places, specifically any async for code that deals with async iterators.  Also, lahja needs to be looked at.


No display name received from Xvfb on test-osuosl-ubuntu1604-ppc64le-1

Exception: java.lang.IllegalStateException: No display name received from Xvfb within 30 seconds
To make it easy for the infrastructure team to repeat and diagnose, please
answer the following questions:

test suite/name (e.g, BUILD_LIST, TARGET, CUSTOM_TARGET)?
a link into recent Test_ job on https://ci.adoptopenjdk.net which showed the failure https://ci.adoptopenjdk.net/job/Test_openjdk17_hs_sanity.openjdk_ppc64le_linux/255/
Hyperlink to re-run in Grinder: rerun link
Is there an existing issue elsewhere covering this?
Which machine(s) does it work on? other machines
Which machine(s) does it fail on? test-osuosl-ubuntu1604-ppc64le-1

Any other details:
Will take this machine offline until this is resolved

Machine still seems to be online and from the grinder I've just run there is no problem with Xvfb so I'm going to close this.
Having said that, since Ubuntu 16.04 is out of support we should consider fully decommissioning this machine


open file, neovim response slowly in big git repository

neovim0.5 release, macos 10.15
not so big repository,1385 files.
when i git merge, there are some conflicts, when i open any files, either conflict files or merged files, vim response is very slow, every action is very slow, include cursor move in normal mode, hijk etc...
i use evilline.lua or spaceline.lua galaxyline example.
when i disable galaxyline, it's ok.
i have tried a little repository, about 600 files, it's not as slow as the big one, but it's slow too

open a file that big enough, for example, 8.6MB txt, the same problem. neovim action is very slow.

+1, i have these issues as well, both when fixing conflicts and editing commit messages

In my (custom) configuration the problem comes from the "GitBranch" provider, if I disable just that part the slowness dissapears.


Query: how to host files within company network

@burtlo Thanks for this amazing plugin, I've started to learn and play around with it for achieving " living documentation".
Can you please clarify what is best way to host within company network ?
Note:
README needs update
User needs to install latest versions of Gherkin, Cucumber and YARD gems, then install yard-cucumber gem.
Thanks & Regards,
Vikram

Put it on a VM running Windows and IIS or a Linux box with Apache2? You can generate the docs nightly or based on a trigger when something is merged to master.


Allow rshell to be run as a module script with "python -m rshell"

@dhylands Any chance you'd be willing to merge this for those of us who prefer to invoke rshell with "python -m rshell"?
Thanks!
--Tim


WRP-17253: Updated node modules major version

Checklist

[x] I have read and understand the contribution guide
[x] A CHANGELOG entry is included
[ ] At least one test case is included for this feature or bug fix
[x] Documentation was added or is not needed
[ ] This is an API breaking change

Issue Resolved / Feature Added
Updated node modules major version
Resolution
Updated (there were no breaking changes affecting our code):
@enact/dev-utils
https://github.com/enactjs/dev-utils/releases
postcss-loader
https://github.com/webpack-contrib/postcss-loader/releases
postcss-preset-env
https://github.com/csstools/postcss-plugins/blob/main/plugin-packs/postcss-preset-env/CHANGELOG.md
Migration Guide - there are no breaking changes affecting Enact
Additional Considerations
@enact/dev-utils and postcss-loader, the minimum required node version is v14.15.0. postcss-preset-env supports Node v14+
storybook dependencies will be handled in a separate user story
Links
WRP-17253
Comments
Enact-DCO-1.0-Signed-off-by: Ion Andrusciac<EMAIL_ADDRESS>

I don't think the node version required is currently correct.
In the case of dev-utils, the node version has been changed as follows.
"node": "^14.15.0 || ^16.10.0 || >=18.0.0.
The storybook-utils should also be changed to the correct node version by checking the breaking changes of each major updated module

I don't think the node version required is currently correct.
In the case of dev-utils, the node version has been changed as follows.
"node": "^14.15.0 || ^16.10.0 || >=18.0.0.
The storybook-utils should also be changed to the correct node version by checking the breaking changes of each major updated module
postcss-preset-env has a migration guide: https://github.com/csstools/postcss-plugins/wiki/PostCSS-Preset-Env-8
Did you check that?

I updated the node version in package.json based on all restrictions from the three updated dependencies, thank you for noticing.
I checked Migration Guide and there are no Breaking Changes affecting the storybook-utils


Poor error message

use "format"
use "files"

actor DirectoryTraverser
  be traverse(target: String val) =>
    let directory = Directory.open(target)

actor Main
  new create(env: Env) =>
    env.out.print("foo")

not enough arguments
let directory = Directory.open(target)

I asked @insanitybit to open this in IRC.
If you look at Directory.open:
  fun open(target: String): Directory iso^ ? =>
it takes a single argument that is a string. However, its not a constructor. The error message that results from calling on Directory the class rather than an instance of the class could be much better.

The simplest thing we could do to improve this UX is to add an "info" line to this (using ast_error_continue) to point to the definition of the function signature, to show you what arguments are expected, to demonstrate why you're not providing enough.  This would be helpful in general, but would also help in this case to show you that it's trying to call the constructor.

@jemc Can you take a look at my fix suggestion.
Error messages for too many / not enough arguments now look like:
Error:
/home/klaunonen/Develop/pony/not_enough-args/argh.pony:5:36: too many arguments
    let dirTooManyArgs = Directory(".", 1)
                                   ^
    Info:
    /home/klaunonen/Develop/pony/ponyc-klaunonen/packages/files/directory.pony:32:14: definition is here
      new create(from: FilePath) ? =>
                 ^
Error:
/home/klaunonen/Develop/pony/not_enough-args/argh.pony:6:37: not enough arguments
    let dirNotEnoughArgs = Directory.open(target)
                                    ^
    Info:
    /home/klaunonen/Develop/pony/ponyc-klaunonen/packages/files/directory.pony:32:14: definition is here
      new create(from: FilePath) ? =>
                 ^

@KaroLaunonen - Thanks, looks perfect! Want to file it as a PR?

@jemc If I'm not mistaken, this is resolved as of the May 17 commit https://github.com/ponylang/ponyc/commit/939cf25789c72fec3e623570cb4f8cf934fc6214

@Perelandric - yes, thanks!


spelling

A spelling error I noticed in an error message while I was trying to use this to setup a react-native module. Since you mention https://github.com/maxs15/react-native-spinkit as the source of the script I also created a PR there as well.

@nickburkhart thanks :)


ngStyle one-time binding regression

There's a regression in ngStyle that breaks lazy one-time binding  (when a property value is initially undefined), caused by https://github.com/angular/angular.js/commit/4c8d8ad5083d9dd17c0b8480339d5f95943f1b71
Example: http://jsbin.com/tuyetahaxi/2/edit - change the version to 1.3.9, and the background-color will not be applied.
The cause for this break is that $watchCollection passes its own changeDetector function to $watch, which does not return the actual changed values, but only a changeDetected counter. However, $parse has a special path for one-time bound object literals, where it unwatches only when all object properties /  array elements are defined (see https://github.com/angular/angular.js/commit/c024f28217cf8eedd695dd4b933ecf2ba4243c15). With watchCollection, the binding watch is now removed instantly as the value that is passed to $watch is not the actual object / array but the changeDetected count from $watchCollection.
I worked around this by returning the actual newValue / oldValue from inside $watchCollection's changeDetected. I'll have to test if this breaks anything, though.

+1

it looks like 4c8d8ad5083d9dd17c0b8480339d5f95943f1b71 was simply wrong and should be reverted.
PR (with a test) welcome

Shouldn't the revert add a test as well?

The test was added in the commit before the revert. Not ideal, but hey. I thought I added it after it.
----- Ursprüngliche Nachricht -----
Von: "Michał Gołębiowski"<EMAIL_ADDRESS>Gesendet: 31.03.2015 14:03
An: "angular/angular.js"<EMAIL_ADDRESS>Cc: "Martin Staffa"<EMAIL_ADDRESS>Betreff: Re: [angular.js] ngStyle one-time binding regression (#11403)
Shouldn't the revert add a test as well?
—
Reply to this email directly or view it on GitHub.


Feature: detect code that updates dependency hash pins "manually"

Tools that help update dependencies is what we advise user to use in the Dependency-Update-Tool check.
Asa result, we should never see, inn a script, a command that tries to update dependencies, e.g. npm update - same for other package managers.
We should add support to check for such commands in the Pinned-Dependencies check.

Does it make more sense for this to be part of Dependency-Update-Tool? Basically, what if we upgrade the scope of Dependency-Update-Tool to check how projects manage their different dependencies (automatically or manually)and score them accordingly?

Good point, I think you're right. It's going to take some effort to re-use the shell utility functions and disentangle them from the Pinned-Dependency check. Adding to Pinned-Dependency is straight forward.
Is there value in first landing it in Pinned-Dependency check to have the data available, and then 2) work on the more long-term solution?

If its easier to add it in Pinned-Dependencies then let's do that, no need to complicate.
On a separate note though, its weird that these generic file parsing util fns are tied to checks. Maybe we should separate these out such that any check can use them. Probably have a fileparser package inside the checks package to do this. Wdyt?

If its easier to add it in Pinned-Dependencies then let's do that, no need to complicate.
On a separate note though, its weird that these generic file parsing util fns are tied to checks. Maybe we should separate these out such that any check can use them. Probably have a fileparser package inside the checks package to do this. Wdyt?

definitely, we should do that. Once it's done, we can move the code to Dependency-Update-Tool. I'll create a PR


adjusts tests location to be inside craterstats src folder

tests on the ci were failing I think because of the source layout of craterstats. This PR should restructure things to allow the action to run.
@ggmichael please authorize the tests to run but do not merge until the tests pass

Ah! the demo cmd file is not being packaged in sdist, I should be able to fix it quickly

nope, nothing extra at this point. I'll keep iterating until I work out the solution

@ggmichael it looks like the file craterstats/sample/c7_Michael-et-al-2021.scc is missing from the project. If you push the file to the repository then this pr can be merged

ok - that file's there

argh - sorry!

great - it worked. Thanks for this.

So where do those demo plots end up? I don't see them

You should see them of the page for each run as a section called “Artifacts”
-Andrew Annex

On Sep 30, 2021, at 11:14 AM, ggmichael @.***> wrote:

So where do those demo plots end up? I don't see them
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

I found it - thanks!
On Thu, 30 Sept 2021 at 17:54, Andrew Annex @.***>
wrote:

You should see them of the page for each run as a section called
“Artifacts”
-Andrew Annex

On Sep 30, 2021, at 11:14 AM, ggmichael @.***> wrote:

So where do those demo plots end up? I don't see them
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/ggmichael/craterstats/pull/6#issuecomment-931449845,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR5ZQ2W35K73LFUWRUKFJPLUESB2XANCNFSM5FCPQA6Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


[SPARK-23300][TESTS] Prints out if Pandas and PyArrow are installed or not in PySpark SQL tests

What changes were proposed in this pull request?
This PR proposes to log if PyArrow and Pandas are installed or not so we can check if related tests are going to be skipped or not.
How was this patch tested?
Manually tested:
I don't have PyArrow installed in PyPy.
$ ./run-tests --python-executables=python3

...
Will test against the following Python executables: ['python3']
Will test the following Python modules: ['pyspark-core', 'pyspark-ml', 'pyspark-mllib', 'pyspark-sql', 'pyspark-streaming']
Will test PyArrow related features against Python executable 'python3' in 'pyspark-sql' module.
Will test Pandas related features against Python executable 'python3' in 'pyspark-sql' module.
Starting test(python3): pyspark.mllib.tests
Starting test(python3): pyspark.sql.tests
Starting test(python3): pyspark.streaming.tests
Starting test(python3): pyspark.tests

$ ./run-tests --modules=pyspark-streaming

...
Will test against the following Python executables: ['python2.7', 'pypy']
Will test the following Python modules: ['pyspark-streaming']
Starting test(pypy): pyspark.streaming.tests
Starting test(pypy): pyspark.streaming.util
Starting test(python2.7): pyspark.streaming.tests
Starting test(python2.7): pyspark.streaming.util

$ ./run-tests

...
Will test against the following Python executables: ['python2.7', 'pypy']
Will test the following Python modules: ['pyspark-core', 'pyspark-ml', 'pyspark-mllib', 'pyspark-sql', 'pyspark-streaming']
Will test PyArrow related features against Python executable 'python2.7' in 'pyspark-sql' module.
Will test Pandas related features against Python executable 'python2.7' in 'pyspark-sql' module.
Will skip PyArrow related features against Python executable 'pypy' in 'pyspark-sql' module. PyArrow >= 0.8.0 is required; however, PyArrow was not found.
Will test Pandas related features against Python executable 'pypy' in 'pyspark-sql' module.
Starting test(pypy): pyspark.streaming.tests
Starting test(pypy): pyspark.sql.tests
Starting test(pypy): pyspark.tests
Starting test(python2.7): pyspark.mllib.tests

$ ./run-tests --modules=pyspark-sql --python-executables=pypy

...
Will test against the following Python executables: ['pypy']
Will test the following Python modules: ['pyspark-sql']
Will skip PyArrow related features against Python executable 'pypy' in 'pyspark-sql' module. PyArrow >= 0.8.0 is required; however, PyArrow was not found.
Will test Pandas related features against Python executable 'pypy' in 'pyspark-sql' module.
Starting test(pypy): pyspark.sql.tests
Starting test(pypy): pyspark.sql.catalog
Starting test(pypy): pyspark.sql.column
Starting test(pypy): pyspark.sql.conf

After some modification to produce other cases:
$ ./run-tests

...
Will test against the following Python executables: ['python2.7', 'pypy']
Will test the following Python modules: ['pyspark-core', 'pyspark-ml', 'pyspark-mllib', 'pyspark-sql', 'pyspark-streaming']
Will skip PyArrow related features against Python executable 'python2.7' in 'pyspark-sql' module. PyArrow >= 20.0.0 is required; however, PyArrow 0.8.0 was found.
Will skip Pandas related features against Python executable 'python2.7' in 'pyspark-sql' module. Pandas >= 20.0.0 is required; however, Pandas 0.20.2 was found.
Will skip PyArrow related features against Python executable 'pypy' in 'pyspark-sql' module. PyArrow >= 20.0.0 is required; however, PyArrow was not found.
Will skip Pandas related features against Python executable 'pypy' in 'pyspark-sql' module. Pandas >= 20.0.0 is required; however, Pandas 0.22.0 was found.
Starting test(pypy): pyspark.sql.tests
Starting test(pypy): pyspark.streaming.tests
Starting test(pypy): pyspark.tests
Starting test(python2.7): pyspark.mllib.tests

./run-tests-with-coverage

...
Will test against the following Python executables: ['python2.7', 'pypy']
Will test the following Python modules: ['pyspark-core', 'pyspark-ml', 'pyspark-mllib', 'pyspark-sql', 'pyspark-streaming']
Will test PyArrow related features against Python executable 'python2.7' in 'pyspark-sql' module.
Will test Pandas related features against Python executable 'python2.7' in 'pyspark-sql' module.
Coverage is not installed in Python executable 'pypy' but 'COVERAGE_PROCESS_START' environment variable is set, exiting.

@ueshin, @cloud-fan, @yhuai, @felixcheung and @BryanCutler, I tried to log it here. Could you take a look and see if it makes sense to you?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/477/
Test PASSed.

Test build #86929 has started for PR 20473 at commit 0261045.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/478/
Test PASSed.

Test build #86930 has started for PR 20473 at commit e7d752f.

Test build #86929 has finished for PR 20473 at commit 0261045.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86929/
Test PASSed.

Current Jenkins output was:
========================================================================
Running PySpark tests
========================================================================
Running PySpark tests. Output is in /home/jenkins/workspace/SparkPullRequestBuilder/python/unit-tests.log
Will test against the following Python executables: ['python2.7', 'python3.4', 'pypy']
Will test the following Python modules: ['pyspark-core', 'pyspark-sql', 'pyspark-streaming', 'pyspark-mllib', 'pyspark-ml']
PyArrow is not installed in Python executable 'python2.7', skipping related tests in 'pyspark-sql'.
PyArrow is not installed in Python executable 'pypy', skipping related tests in 'pyspark-sql'.
Pandas is not installed in Python executable 'pypy', skipping related tests in 'pyspark-sql'.
Starting test(pypy): pyspark.sql.tests
Starting test(python2.7): pyspark.mllib.tests

Test build #86930 has finished for PR 20473 at commit e7d752f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86930/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/504/
Test PASSed.

Test build #86965 has started for PR 20473 at commit 014612a.

Test build #86965 has finished for PR 20473 at commit 014612a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86965/
Test PASSed.

Test build #86972 has started for PR 20473 at commit b726330.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/512/
Test PASSed.

The message seems now much clear :D.
========================================================================
Running PySpark tests
========================================================================
Running PySpark tests. Output is in /home/jenkins/workspace/SparkPullRequestBuilder/python/unit-tests.log
Will test against the following Python executables: ['python2.7', 'python3.4', 'pypy']
Will test the following Python modules: ['pyspark-core', 'pyspark-sql', 'pyspark-streaming', 'pyspark-mllib', 'pyspark-ml']
Will skip PyArrow related features against Python executable 'python2.7' in 'pyspark-sql' module. PyArrow >= 0.8.0 is required; however, PyArrow was not found.
Will skip Pandas related features against Python executable 'python2.7' in 'pyspark-sql' module. Pandas >= 0.19.2 is required; however, Pandas 0.16.0 was found.
Will test PyArrow related features against Python executable 'python3.4' in 'pyspark-sql' module.
Will test Pandas related features against Python executable 'python3.4' in 'pyspark-sql' module.
Will skip PyArrow related features against Python executable 'pypy' in 'pyspark-sql' module. PyArrow >= 0.8.0 is required; however, PyArrow was not found.
Will skip Pandas related features against Python executable 'pypy' in 'pyspark-sql' module. Pandas >= 0.19.2 is required; however, Pandas was not found.

BTW @ueshin,
I think we should use require_minimum_pyarrow_version here:
https://github.com/apache/spark/blob/ec63e2d0743a4f75e1cce21d0fe2b54407a86a4a/python/pyspark/sql/tests.py#L78-L84
because we declared >= 0.8.0 as you already know:
https://github.com/apache/spark/blob/b8bfce51abf28c66ba1fc67b0f25fe1617c81025/python/setup.py#L204
Would you like me to double check other files and fix it separately or would you be willing to fix it?

Test build #86972 has finished for PR 20473 at commit b726330.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86972/
Test PASSed.

@HyukjinKwon Good catch! Yeah, we should use it there. Could you fix it please? Thanks!

Will double check and open a PR tonight ..

retest this please

Test build #87046 has started for PR 20473 at commit b726330.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/574/
Test PASSed.

Test build #87046 has finished for PR 20473 at commit b726330.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87046/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/579/
Test PASSed.

Test build #87055 has started for PR 20473 at commit fe2943e.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/580/
Test PASSed.

Merged build finished. Test PASSed.

Test build #87056 has started for PR 20473 at commit 78f5879.

Test build #87055 has finished for PR 20473 at commit fe2943e.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87055/
Test FAILed.

Test build #87056 has finished for PR 20473 at commit 78f5879.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87056/
Test PASSed.

Will merge this one if there's no more comments in few days.

LGTM.

Merged to master.

Thank you @felixcheung, @yhuai, @ueshin and @BryanCutler for reviewing this.

Let me actually backport this to bracnh-2.3. I think there isn't any downside or harm to backport it.


ObjectMapperSupplier implementation never loaded

Summary
A custom ObjectMapperSupplier implementation is not loaded on startup.
Steps to reproduce

Create a custom ObjectMapperSupplier implementation that enables serialization features
Register the implementation with the hibernate.types.jackson.object.mapper setting in your application.yml file
Run the application

Expected results
The enabled serialization features are honored when retrieving json types from the database.
Actual results
The enabled serialization features are not honored when retrieving json types from the database.

More info
When I add a throw new RuntimeException(); in the implementation's get() method it fails to throw on startup so I know the body is never run.
My application.yml is as follows:
spring:
  profiles:
    active: dev
  rabbitmq:
    listener:
      simple:
        concurrency: 32
        max-concurrency: 48
        prefetch: 16
        acknowledge-mode: auto
        default-requeue-rejected: true
        retry:
          enabled: true
          multiplier: 2
          max-attempts: 10
          stateless: true
          initial-interval: 1s
          max-interval: 30s
  jpa:
    database-platform: org.hibernate.dialect.MySQLDialect
    hibernate:
      ddl-auto: none
      naming:
        implicit-strategy: org.hibernate.boot.model.naming.ImplicitNamingStrategyLegacyJpaImpl
        physical-strategy: org.hibernate.boot.model.naming.PhysicalNamingStrategyStandardImpl
    properties:
      hibernate.generate_statistics: false
      hibernate.cache.use_query_cache: true
      hibernate.cache.use_second_level_cache: false
      hibernate.cache.region.factory_class: org.hibernate.cache.ehcache.EhCacheRegionFactory
      hibernate.types.jackson.object.mapper: net.zuluconnect.ZuluconnectObjectMapperSupplier
      hibernate.jdbc.batch_size: 20
      hibernate.jdbc.batch_versioned_data: true
      hibernate.order_inserts: true
      hibernate.order_updates: true
  datasource:
    type: com.zaxxer.hikari.HikariDataSource
    driver-class-name: org.mariadb.jdbc.Driver
    hikari:
      minimum-idle: 32
      maximum-pool-size: 48
      idle-timeout: 60000

A separate profile-based configuration application-dev.yml is also loaded:
spring:
  rabbitmq:
    host: "<IP_ADDRESS>"
    username: guest
    password: guest
  datasource:
    url: jdbc:mariadb://localhost:3306/my_db
    hikari:
      username: root
      password:
logging:
  level:
    org: DEBUG

And my ObjectMapperSupplier implementation:
package net.zuluconnect;

import com.fasterxml.jackson.databind.DeserializationFeature;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.vladmihalcea.hibernate.type.util.ObjectMapperSupplier;

@SuppressWarnings("unused")
public class ZuluconnectObjectMapperSupplier implements ObjectMapperSupplier {

    @Override
    public ObjectMapper get() {
        ObjectMapper objectMapper = new ObjectMapper();
        objectMapper.configure(DeserializationFeature.ACCEPT_EMPTY_STRING_AS_NULL_OBJECT, true);
        objectMapper.configure(DeserializationFeature.ACCEPT_EMPTY_ARRAY_AS_NULL_OBJECT, true);
        objectMapper.configure(DeserializationFeature.USE_LONG_FOR_INTS, true);
        return objectMapper;
    }
}

Thanks for creating the issue. Now, I want you to:

Fork the repository.
Copy an existing test case and provide the logic that replicates the issue.

Once the issue is replicated, I can start investigating it.

Any news about the cause of the issue? Dix you manage to create a replicating test case?

I haven't found the time to prepare the test case just yet. I hope to be able to provide one somewhere this week.

I'll reopen it if a test case will be provided.

Based on your documentation the library is looking for the file hibernate-types.properties or hibernate.properties where in a spring context we define the hibernate properties in the application file and all hibernate properties are prefixed by spring.jpa.properties.
It would be nice if the library is used in a spring context, the object mapper defined for spring should be used for the hibernate data types.

Just because Spring uses the spring.jpa.properties, it does not mean you cannot embed a hibernate.properties file in the jar via the main/resources folder. Or, you can even use a Java System property too.

Yeah I agree but it forces us to define the hibernate properties in 2 different files which is not top.

Send me a Pull Request with a fix if think this is worth adding. Thanks.

I can verify that moving the setting hibernate.types.jackson.object.mapper to a separate hibernate.properties file fixes my issue but it's strange that it's the only hibernate property that can't be read from a Spring application.yml.

You should investigate the issue and propose a fix.

I will have to try via a Hibernate Integrator or something similar to see whether I could register the types when the SessionFactory is built to get access to the supplied properties.

Closed as it's not possible due to Hibernate limitations. Once HHH-13103 gets fixed, it will be possible to address this issue.

It seems that the other issue was fixed: https://github.com/hibernate/hibernate-orm/pull/2649

@Davio The change in HHH-13103 can only be used from Hibernate 5.5 onwards since it introduces a new class that will throw a NoClassDefFoundError on other Hibernate versions.
So, if the HHH-14020 issue will be fixed, then Hibernate Types could use this feature for older Hibernate versions too. In the meanwhile, there is nothing to be done.


Added tests for loading scenarios

Closes #1029
Description
Added tests for loading scenarios.
Is this a breaking change (Yes/No):
No

@108yen
Fixed waitFor.


[WIP] Add sysprep support for oVirt provider

Implements: https://bugzilla.redhat.com/show_bug.cgi?id=1553833
What:
Add sysprep specification support for vm provisioning from template
for the oVirt provider.
Steps to see the dialog:
Compute -> Infrastructure -> Virtual Machines
Lifecycle -> Provision VMs
Select a template with a Windows OS.
Go to the "Customization" tab.
Under Basic Options open the "Customize" drop down.
Before:

After:

And then after selecting "Sysprep Specification":

@borod108 If this is WIP (as per your second commit), can you please change the title to include [WIP] at the front

Also, please don't leave the pull request template as your PR message.  Please fill it in with the intent of this PR.
Also, also

borod108 added some commits on Jan 3

How is that possible? :)

@Fryguy wow, sorry I opened the pull request back then by mistake, and did not even notice you commented on it :/
@agrare can you please take a look? (or maybe point to someone who should)

@miq-bot remove_label wip

cc @gmcculloug @bdunne

@miq-bot add_label wip
got some feedback need to add couple of fields.

@miq-bot remove_label wip
added missing fields.

@borod108 Since this is a change to the provisioning dialog can you also include before/after screenshots in the description similar to what is done in the UI-classic repo.
For example, https://github.com/ManageIQ/manageiq-ui-classic/pull/4460

0  tmp/.gitkeep

@borod108 did you intend to delete the tmp dir?

I realize that Computer Details and Domain Information are useful as text fields, but I am wondering about some of the Localization fields.  Would it make sense to provide a drop-down for Timezone like we do for VMware or any of the Locale fields?
Also, the fields are subject to what the sysprep script is expecting so this might not be useful but wanted to ask.
@mwperina @agrare Thoughts?

@miq-bot add_label wip

@gmcculloug we discussed on our weekly sync call and the native RHEV provider doesn't have a dropdown for the locale, but it does for the timezone field.  @borod108 is going to add a dropdown for timezone similar to the one for VMware.

@gmcculloug @agrare done.

Sending over to @gmcculloug for final review

@borod108 Looks good, I think we just need to include the sysprep_* dialog fields in the miq_provision_redhat_dialogs_clone_to_vm.yaml file as well.

@gmcculloug done

@borod108 just realized this is not merged yet.  Any reason to keep it WIP?

@agrare can we merge please?

@borod108 @agrare PR https://github.com/ManageIQ/manageiq-providers-ovirt/pull/275 should be merged first since this PR adds a call to get_timezones.

@gmcculloug merged the ovirt pr


fixes #346

This fixes #346.

Changes Unknown when pulling 2125a1f01a559768d271ccce267abe7231d2b158 on justinclayton:openstack_volume_attach_fix into ** on emccode:master**.

Current coverage is 91.08%

Merging #353 into master will not affect coverage as of b47ddd7

@@            master    #353   diff @@
======================================
  Files            8       8
  Stmts          729     729
  Branches        14      14
  Methods          0       0
======================================
  Hit            664     664
  Partial         14      14
  Missed          51      51

Review entire Coverage Diff as of b47ddd7

Uncovered Suggestions

+1.37% via ...re/drivers_volume.go#183...192
+1.23% via ...re/drivers_volume.go#344...352
+0.96% via ...re/drivers_volume.go#220...226
See 7 more...

Powered by Codecov. Updated on successful CI builds.

@justinclayton We are looking to merge this in on a separate branch for 0.3.3 as we have already begun development on 0.4.0 with the master. Can you create a new PR for this going against our 0.3.3 branch?

Done. See #357.


Azure Data Lake Gen 2 support

Delta-rs (and soon, datafusion) will support ADL2, and I think it would be great  to also have this in ROAPI.
If I had to implement it, I'd have a closer look at the implementation in delta-rs but I'm open to other suggestions.

That sounds good, I also use the s3 storage backend in delta-rs as the inspiration for roapi's s3 io module.

I am not familiar with Azure, but looks like ADLS Gen 2 adfs:// and adfss:// are supported by object_store and thus done in https://github.com/roapi/roapi/pull/250?

I think so, thanks @jychen7 !


new clients cannot load video after a random amount of time unless source reconnects.

I run a 24/7 test stream at https://testrp.cdtv.live/smashbets
I find that after a random amount of time, (sometimes as short as a few minutes). no new users can connect to the stream.
If you are already watching, it continues working - but open another tab or refresh and it wont load unless I stop/start OBS's streaming output.

Hey @jfarre20!
Sorry about that. Would you mind capturing a chrome://webrtc-internals dump on a client that isn't able to connect?

I forgot to update my issue, I updated my docker container to your latest
commit and it's been behaving so far. however if it does act up I will do
this.
On Mon, Jul 10, 2023, 9:36 AM Sean DuBois @.***> wrote:

Hey @jfarre20 https://github.com/jfarre20!
Sorry about that. Would you mind capturing a chrome://webrtc-internals
dump on a client that isn't able to connect?
—
Reply to this email directly, view it on GitHub
https://github.com/Glimesh/broadcast-box/issues/23#issuecomment-1628980030,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABYLWCT2FADZOIOGMLSEXPDXPQAO5ANCNFSM6AAAAAAZ7CSZDY
.
You are receiving this because you were mentioned.Message ID:
@.***>

That's great news! Glad it is working for you @jfarre20
I am available in https://pion.ly/slack if you ever want to debug right away.


Back Button takes much time

Could the Backbutton [picture one] of an account (which takes you to the Dashboard) be activated first bevore all transactions have been loaded? With a small bandwidth, with a lot of transactions it takes more than a few seconds to get back to the Dashboard.
Now it's like an old TV where the channel change takes to much time :)

Espo: NDEFC3-H4VAIU-FQ5GFT-IK3IJR-4DGKF7-PEQKRW-LPZ5

@LyubomirDominik is this an easy thing to fix?

this is really causing a problem if the server is slow so I will click must fix.

Its also not just the back button.  It is also things like new transaction

Fixed in Version 2 Build 42 downloading transactions not influence any more.

okay thanks

Bounty paid. Tx hash: 1d130338b5d90eddda1658243b0f11a1679a4064f90f31d9896a169e412103bb


Scaling up App on vCenter cluster can't add shared vSan storage to other worker nodes

Rancher versions: 2.0 master July 7
vCenter 6.7
ESXi 6.7
Setup details: single node rancher run as docker container
Steps to Reproduce:
Create a cluster with the vSphere template, edit yaml and and add CloudProvider details for vCenter
Create a Node Template with 2GB and 2 vCPU
Add 3 etcd, 3 control, 3 workers
Wait for cluster to be online
vMotion nodes so workers are on different ESXi hosts
Create a mysql workload from catalog Apps and assign persisted storage on vSan
Wait for App to be online
scale up app from 1 pod to 2
Results:
in vCenter, when Rancher tries to reconfigure another worker node to add vSan volume to the VM it has error:
Status: Failed to add disk 'scsi0:1'.
Error Stack:
File system specific implementation of OpenFile[file] failed
File system specific implementation of OpenFile[file] failed
File system specific implementation of OpenFile[file] failed
[...]
Failed to lock the file
Cannot open the disk '/vmfs/volumes/vsan:52e178f37733d363-4bd144458634c437/ae3c405b-1254-71a6-cbe9-0cc47a7edcd8/kubernetes-dynamic-pvc-4315955f-819c-11e8-9f44-005056bb7f95.vmdk' or one of the snapshot disks it depends on.
Failed to power on 'scsi0:1'.
Failed to add disk 'scsi0:1'.

All vSphere volumes are RWO, there is no way provisioning shared vSphere volumes. This is a limitation with the current implementation of VCP.

Please see https://github.com/rancher/rancher/issues/14444#issuecomment-412770234


"Unexpected exception: Media stream not specified"

When i try to run the datamix14 script, it gives me this error:

It does not let me specify the media stream, i don't even know what that means.
I am using VEGAS Pro 15

for me this popped up when windows security blocked avidemux2cli from "protected folders"; after i added an exception to it it worked fine 👍


Sending a Message should return the MailFolderId of the SENT folder

This is to identify the folder to which the sent message has to get moved.

target folder determined by client and available folders for now


Support passing apis list to artman smoketest.

artman CI can run partial smoketests with selected APIs, while artman CD can run the full smoketests.

Codecov Report

Merging #198 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #198   +/-   ##
=======================================
  Coverage   69.72%   69.72%
=======================================
  Files          48       48
  Lines        1982     1982
  Branches      233      233
=======================================
  Hits         1382     1382
  Misses        567      567
  Partials       33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b57293...b5b5cf1. Read the comment docs.


Change name of whitepaper to Technical, as well as remove link to "Tokenomics"

This PR removes the Tokenomics link that we don't have yet - and changes the name of the current whitepaper to its correct name, Technical Whitepaper.

Currently 404s from the footer ;(

should be good now!~


Support for validating IBAN of the state of Vatican City

First of all, thank you for the great code! I noticed that the implementation for IBAN of the state of Vatican City is missing.
Are there any plans to solve this problem so far?
Thank you for your great work!

Hi @m-michalek, sorry for the late reply. In release 2020.1.0 IBANs from Vatican City are supported.


[test/plugin] immigrate dubbo scenario

Please answer these questions before submitting pull request

Why submit this pull request?

[ ] Bug fix

[x] New feature provided

[ ] Improve performance

Related issues
#3583

New feature or improvement

Describe the details and related test reports.

FYI @dmsolr

#3584 merged, you are good to go.

@wu-sheng @kezhenxu94 @zhaoyuguang @ascrutae  please review


MSBuild: Respect TreatWarningsAsErrors and WarningsNotAsErrors properties

Is your feature request related to a problem? Please describe.
Currently when building Bicep using the MSBuild package, it can output warnings. We would like to enforce a more strict rule, where most of these warnings become errors that break the build.
Describe the solution you'd like
MSBuild already has known properties for this, TreatWarningsAsErrors (boolean) and WarningsNotAsErrors (comma-separated list of warning codes), so the Bicep task could just respect those.

I would suggest using the standardized .editorconfig instead, also used by Roslyn analyzers, e.g.:
dotnet_diagnostic.CA1822.severity = error

BUT TreatWarningsAsErrors is a general override which is very convenient and safe. Say you add new warnings, we would not have to update the config file, they would just be configured as errors by default. You can add these features to the config file instead of relying on the MSBuild properties.

@aelij - thanks I just took that label off. Is this issue blocking you right now?

It's not blocking but we'd consider it a big improvement for our linting capabilities. Right now we have to manually update the Bicep config file. In contrast, in C# we'd just get new build errors when we upgrade, and we'd have to fix/suppress them.

@aelij would #10304 help?

@anthony-c-martin Yes, definitely

We will be working on the other issue mentioned and track it at #10304


[Feature]: PASST networking mode

Is your proposal related to a problem?
In Windows (or in a complex Docker host) the macvlan interface could not be used. The alternative is to use the user mode, that it's very slow because it uses the SLIRP emulation.
Describe the solution you'd like.
The proposed solution is the add support for the PASST networking mode (aka SOCKET networking using the passt tool). This will replace (as an option) the USER mode.
Read more about it: https://passt.top/
The idea is to run passt inside the container and attach to it the qemu instance using the socket for networking. The performance of this mode over slirp is impresive.
Describe alternatives you've considered.
The only alternative is to continue to use the stock user mode. This will add another option in between of macvlan and user.
Additional context
No response

Hi @kroese ,
Thank you for the response.
I know that we can use user (the slow allways supported nat mode), the two macvtap and macvlan (not in Windows), or the bridge (internal only). But the request is to add support for "connect network devices". The idea is to add -netdev sockert|stream and add support to attach to them a PASST process or GVISOR-TAP (https://github.com/containers/gvisor-tap-vsock). Or whatever other implementation that will run outside the qemu process that will provide the networking functionality. With this optional support we could use more complex environments.
What you think?

OK, I'll try to explain the use case:

At time, the only method to interconnect complex networking with vDSM is through the "host networking" (not the user netwrking, "host" in the sense of the machine that runs Docker). This implies TUN/TAP devices and root privileges. However, because you're using QEMU you can connect the "user process" of qemu to anything... not only to the host. And to support this, it's necessary to expand the networking to -netdev socket|stream backends. So not only user, macvtap, etc. We need to accept that the Docker support for networking is limited (to generic use cases). But with the introduction of QEMU we can attach anything to it. Some use cases can be: tunnels, software bridges, etc. But take note that is not required that these network backends will be host devices. We can attach other user processes (like PASST i.e.) to these backends of QEMU. This will grant three objectives: 1) independence from the host (no root privileges). 2) native performance (no emulation inside the virtual machine). 3) flexibility, as you can virtually connect anything.

I hope it's clearer now, right?

One question: To use bridge mode with vDSM without root privileges on the host and without instantiating another vm with qemu to connect to it.... how to do it?
A more concrete use case:

Docker host without root privileges, so you can't touch the host networking (no tap/tun devices available).
vDSM running in a docker.
One -netdev of the running vDSM container configured like: -netdev stream,id=vpnnet,server=off,addr.type=unix,addr.path=/tmp-shared/passt_1.socket and the unix socket /tmp-shared/passt_1.socket shared with the host.
Another different container will attach the unix socket /tmp-shared/passt_1.socket to execute a PASST process serving it. And in the same container one userlevel VPN client is running and up. The PASST process is then configured to send all packets to the VPN client.

I hope this be a more concrete example.
The objective is to have support to add this -netdev stream device to vDSM and share the /tmp-shared/passt_1.socket.

Hi @kroese ,
Yes, the idea is to overcome the NET_ADMIN support. And at the same time provide a near hardware wire speed.
After further research, I have found that it might be preferable to use the -netdev l2tpv3 option. In this case the networking is linked to a UDP Ether tunnel. The order end then could be executed anywhere. And it is internally supported in QEmu.
You think you can add some basic support for l2tpv3 networking?


Fixing up broken tests due to the compositor refactor

This change is

@yiyang-msft is added to the review. #Closed

@oliversa-msft is added to the review. #Closed

@davelamb is added to the review. #Closed

:shipit:

:shipit:


Algorithm & Content changes to !quote

Fix 'John Green' appearing as 'Albert Einstein'
Allow single-name authors (e.g. Aristotle)
Add log message for Except clause
Make author name appear on separate lineThis is the quote
  - This is the author

Add more quotes & authors
No longer returns user messages containing '!quote', and/or bot messages, when issued the command !quote

Now !quote no longer returns messages beginning with !, or empty messages (i.e. pictures-only)


test: primitives

Codecov Report
Attention: Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.

Project coverage is 45.24%. Comparing base (dad4beb) to head (a51d619).

Files with missing lines
Patch %
Lines

primitives/src/lib.rs
91.17%
3 Missing :warning:

@@                         Coverage Diff                         @@
##           daan/tests-pallet_api_extension     #273      +/-   ##
===================================================================
+ Coverage                            44.10%   45.24%   +1.14%
===================================================================
  Files                                   47       47
  Lines                                 4222     4252      +30
  Branches                              4222     4252      +30
===================================================================
+ Hits                                  1862     1924      +62
+ Misses                                2299     2267      -32
  Partials                                61       61

Files with missing lines
Coverage Δ

primitives/src/lib.rs
75.60% <91.17%> (+75.60%)
:arrow_up:


Add new icons for Video recording in UC

The new icons are collected on this Figma page.
Essentially there is one new custom icon. In the UI there's a variation of this icon with a red dot. Please use your best judgment to decide whether to add a variation as a separate dialtone component. Alternatively, in Figma, I provided guidance for implementing the multi-color variation based on the monochrome one.

@alekseyh5 Can you place this icon in the Dialtone Icons file?

@alekseyh5 Can you place this icon in the Dialtone Icons file?

I placed the new icon (monochrome version) there. The Figma page that I mentioned in the description of the request still needs your attention. TBD is the implementation method of the multi-color variation of the icon.

@dialpad-drew Another icon we should include in the next Dialtone version.

I placed the new icon (monochrome version) there. The Figma page that I mentioned in the description of the request still needs your attention. TBD is the implementation method of the multi-color variation of the icon.

Hey @alekseyh5 , I'm looking at your Figma link and am not totally following what needs attention here. Are there two versions of this icon: one for starting a recording and another (with the red dot and border) for a recording in progress?


Internals could use refactoring

The internals of this gem are a tad wonky: parts of the code are implemented in Ruby and other parts as native extensions, calling each other through Ed25519::Engine.
They should probably be rewritten to work more like the x25519 gem, with the entirety of the gem implemented in the respective native language.

On second thought (#3), a multi-provider architecture might be nice, although the API should be better specified, with shared RSpec examples.

This was addressed in #6


Undefined symbols for architecture arm64

VERSIONS

Maui.GoogleMaps - <IP_ADDRESS>
.NET SDK - 8 core

IDE

[ ] Rider
[x] Visual Studio 2022
[ ] Visual Studio for Mac

PLATFORMS

[ ] Android
[x] iOS

ACTUAL BEHAVIOR
Cannot build a .NET MAUI app due to "Undefined symbols for architecture arm64: _GMSGeometryArea ........." etc.

Try building on a mac. Also check sample app.

Build on a Mac how, its's a test .net maui app. VS2002 paired with a Mac. The sample includes the source and doesn't reference the nuget package?


Fix a bug that doesn't update props with lifecycleExperimental: true and sCU: false

This PR is to fix #805.
When lifecycleExperimental is true and shouldComponentUpdate returns false, ShallowWrapper should update instances's props with passed props.
I've also added some unit tests for to assert updating props and state and context whether shouldComponentUpdate returns true or not.

Thanks!


proposal: use group version kind to dispatch to different handlers

I am new to the operator sdk, but when exploring the code I noticed the following comment
// Handle registers the handler for all events.
// In the future, we would have a mux-pattern to dispatch events to matched handlers.

In an operator I am working on there are multiple crds. I added the following code to allow the handler to easily dispatch to a different handler. I wondered if you see any drawbacks to this approach but also wondered if it could satisfy the requirement in the comment:
type Handler struct {
	gvkHandlers map[schema.GroupVersionKind]sdk.Handler
}

func (h *Handler) Handle(ctx context.Context, event sdk.Event) error {
	if handler, ok := h.gvkHandlers[event.Object.GetObjectKind().GroupVersionKind()]; ok {
		return handler.Handle(ctx, event)
	}
	return errors.New("no handler registered for group version kind " + event.Object.GetObjectKind().GroupVersionKind().String())
}

type MuxHandler interface {
	sdk.Handler
	GVK() schema.GroupVersionKind
}

func (h *Handler) AddHandler(handler MuxHandler) {
	h.gvkHandlers[handler.GVK()] = handler
}

Each individual handler then implements MuxHandler
type Handler struct{}

func NewHandler() *Handler {
	return &Handler{}
}

func (h *Handler) Handle(ctx context.Context, event sdk.Event) error {
	fmt.Print("handling object ", event.Object.GetObjectKind().GroupVersionKind().String())
	return nil
}

func (h *Handler) GVK() schema.GroupVersionKind {
	return schema.GroupVersionKind{
		Version: v1alpha1.Version,
		Group:   v1alpha1.Group,
		Kind:    v1alpha1.KeycloakKind,
	}
}

Feel free to close if it doesn't make sense, but happy to contribute if something like this makes sense in the sdk

@hasbro17 Thank you for the reply what you have outlined makes sense to me. Thanks for making me aware of the controller runtime, that seems useful the example they show has multiple watches which is closer to my current use case. I will continue with the pattern in my operator for now, but keep an eye on how things change over time


Add ZipLine / ZipWire

Basically a ZipMover entity that is not a block, but somehting you grab and hold to have it move to defined nodes. Ideally you could let go mid-travelling to exit and gain speed. Maybe we don't want to have it stop at every node, let's just have it going until the last node, with always the same speed, no matter the distance between nodes.

 Will not work on this for a while, if not at all.

no longer planning on working on this


Make c robust to price account size

We plan on resizing price accounts to fit the Time Machine. This PRs ensures that this does not cause existing C code to fail.
There are two places where the size of price_t not being the same as the account size can cause failures:
1-rent exempt check while validating accounts (oracle.c)
2-Decompressing the result of the RPC request to Solana requesting to read price contracts (pythd, request.cpp)
(We do not change the default new account size for Pyth-manager because it is helpful to have accounts from the old size in unit tests, and C pyth-manager is no longer used anyway)

Definitely want a second pair of eyes on this