Make a new API in huggingface_hub.hf_api for recommended deployment config

Hi,
Right now we have a http call to https://huggingface.co/api/integrations/tgi/v1/provider/gcp/recommend" to get the recommended deployment configs. We need to make a http request and parse the http response to json. It would be better if we can have a python API, for example in the huggingface_hub.hf_api for this purpose.
Is it a reasonable feature request?

Hi here @weigary! I believe that @Wauplin may be able to respond this issue better, but I think that the recommendation API is not integrated within the huggingface_hub neither planned, but I'll let @Wauplin confirm.

Hey there, thanks for the ping :)
For better context, what call is made to this API and what does it return? If I GET https://huggingface.co/api/integrations/tgi/v1/provider/gcp/recommend, I receive a 500 internal error so I assume this is not the intended use :smile: I am not against adding id officially to huggingface_hub but 2 things I want to ensure first:

is the API stable or is it subject to change in the near future to improve HF <> GCP integration? (talking about inputs/outputs here). If we add an endpoint in huggingface_hub, we will have to ensure backward compatibility on the long run, making it less flexible to updates.
is the API only meant for the HF <> GCP integration or is it something that end users could benefit from? If it's only for this integration to work, I would be a bit more reluctant to add it given it will add maintenance cost while not providing much benefit.

Hi here @Wauplin thanks for the prompt response and the suggestion! 🤗

For better context, what call is made to this API and what does it return?

Here's an example API call:
curl https://huggingface.co/api/integrations/tgi/v1/provider/gcp/recommend?model_id=google/gemma-7b-it&gpu_memory=80&num_gpus=2

Hope that helps, and @weigary feel free to add any other detail if needed!

thanks! We will try it out!


How to update only root package.json in Monorepo?

In Lerna Monorepo we not quite interested in updates for all packages, rather only root one.
Is it possible to set dependabot updates only for it? I see only directory can be specified

@feelepxyz Is there a way to configure this?

@godban 👋 Do you mean to only update the root package.json/lockfile? There's currently no config for this but could use config files and set your allowed updates by name: https://dependabot.com/docs/config-file/#allowed_updates
This is definitely not ideal as you would have to keep this in sync with what's in your root package file.
This is also the first time we've heard this piece of feedback so keen to wait and see if this is a useful pattern for others before planning how we would implement.

@godban 👋 Do you mean to only update the root package.json/lockfile?

yes, exactly
I will try allow unique updates by name, thank you.
But as understand it could solve issue only partially, same dependency could exist in multiple places, in root and other packages.

@godban nice one. Good point, to better understand the problem, what's the reason for only updating root packages? Or rather, why do you not want to update the packages?

difference between this two kinds in monorepos are crucial for us
root serves whole repo infrastructure (tests, build, etc.) it's very similar to any single package application, where we interested in latest updates.
packages package (sounds funny, so let's call it shared package) is responsible for our shared components, utils and lib, distributed as standalone npm packages.
Here we totally not interested in updates, unless we really want to change something. So shared package dependency never goes greater than dependency of app that gonna use it, and we assure that app and this shared package dependency can use same version that used in app.
Otherwise they gonna use each own version.
We could solve it by non-strict package versions in app, but it raises even more concerns.

@godban gotcha! That does make sense and I guess you would actually want different update strategies for the root vs the shared packages. Have you looked the  version_requirement_updates setting? If you set this to widen_ranges Dependabot will try to allow both the old and new versions in in your package.json version requirement which might be more suitable for your packages: https://dependabot.com/docs/config-file/#version_requirement_updates

Closing as a duplicate of both of the following:

https://github.com/dependabot/dependabot-core/issues/4364
https://github.com/dependabot/dependabot-core/issues/2883


[🐛 Bug]: Rewrites with has query option doesn't behave as expected

next-on-pages environment related information

env info
  System:
	Platform: darwin
	Arch: arm64
	Version: Darwin Kernel Version 22.6.0: Wed Jul  5 22:17:35 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T8112
	CPU: (8) arm64 Apple M2
	Memory: 8 GB
	Shell: /opt/homebrew/bin/zsh
  Binaries:
	Node: 18.17.0
	Bun: N/A
	pnpm: N/A
	Yarn: 1.22.19
	npm: 9.6.7
  Package Manager Used: yarn (classic)
  Relevant Packages:
	@cloudflare/next-on-pages: 1.6.0
	vercel: 32.1.0
	next: 13.4.19

Description
Hi there,
During deployment we've noticed an issue which only seems to affect our project once deployed via next-on-pages. The issue pertains to Next's 'rewrites' config option which doesn't appear to be supported properly at the moment.
On the supported doc it does state that "routes has" is supported; at present however I think some of the behaviour is not supported. For example, the following "rewrites" config:
async rewrites() {
    return {
      beforeFiles: [{
          source: '/user-query',
          has: [{
              type: 'query',
              key: 'name',
              value: '(?<name>.*)',
          }],
          destination: '/user/:name',
      }],
    };
  },

Which aims to rewrite "/user-query?name=bacon" to "/user/bacon". This does not appear to work correctly in next-on-pages. I'm not sure if this is a particularly unusual pattern or not but does seem to follow the docs on nextjs and does work when running in development or production build with next. It appears to only fail when locally using wrangler or when deployed to a preview URL on Cloudflare.
I also believe fixing this could fix some of the issues with @sentry/nextjs as their tunnelling option makes use of a very similar rewrite under-the-hood.

@sentry/nextjs rewrite option
  {
    // Matched rewrite routes will look like the following: `[tunnelPath]?o=[orgid]&p=[projectid]`
    // Nextjs will automatically convert `source` into a regex for us
    source: `${tunnelPath}(/?)`,
    has: [
      {
        type: 'query',
        key: 'o', // short for orgId - we keep it short so matching is harder for ad-blockers
        value: '(?<orgid>.*)',
      },
      {
        type: 'query',
        key: 'p', // short for projectId - we keep it short so matching is harder for ad-blockers
        value: '(?<projectid>.*)',
      },
    ],
    destination: 'https://o:orgid.ingest.sentry.io/api/:projectid/envelope/',
  }

Reproduction
https://github.com/emma-cw/next-pages-rewrites-test
Pulling this repo and running with npm run dev/yarn dev will run successfully and the rewrite will behave as expected. For example http://localhost:3000/user/bacon and http://localhost:3000/user-query?name=bacon will display the same very basic page.
However if running with npx @cloudflare/next-on-pages@1 and then npx wrangler pages dev .vercel/output/static --compatibility-flag=nodejs_compat the rewrite no longer functions as expected. Instead,  http://localhost:8788/user/bacon will show correctly but http://localhost:8788/user-query?name=bacon will return 404 instead.
Pages Deployment Method
None
Pages Deployment ID
No response
Additional Information
No response
Would you like to help?

[ ] Would you like to help fixing this bug?

Hey there, thank you for opening this issue. I actually find it rather interesting because the Vercel build output config documentation doesn't describe this behaviour, but I can see that the Next.js docs do.
I have opened a PR that should resolve this. Would you be able to try out the prerelease in https://github.com/cloudflare/next-on-pages/pull/449#issuecomment-1702920072, please?

Hi @james-elicx,
Thank you so much for the quick turnaround on this. That prerelease works perfectly and has also instantly fixed the tunnelling option for the Sentry next.js as well.


Retry to reach IAM endpoint

Removal of unnecessary image Pull Secrets.
Added retry in case of unreachability to IAM endpoint

/ok-to-test

coverage: 83.118%. remained the same when pulling 096f8295746312eeb5afe1bb3246def585a57334 on GunaKKIBM:IAM-reach-retry into 4ca1344cfbce69a39bf04379486efeb4abaabd26 on kubernetes-sigs:master.

/lgtm


Large transaction benchmarks

Decided this branch that I put together for @malin1993ml  was clean enough for a PR. I want to see how it runs on Jenkins and then we can consider merging them.

Coverage decreased (-0.3%) to 94.783% when pulling 12585bd914203f51c77aa96de36f137a2683c19b on mbutrovich:benchmarks into 7618fcad8bb042e97ab9239cec4d3374c8e96ccb on cmu-db:master.

I switched this back to In Progress because I'm experimenting with another set of tests with WAL turned on. Those parameters need tuning though since logging 1,000,000 initial inserts and then 1,000,000 txns (multiple iterations for Google Benchmark) writes some big files.

We'll defer logging benchmarks for another PR since we're still investigating performance with WAL.

Since it caused some communication confusion over the weekend, we should be better about documenting performance deviations that get merged:
FAIL 1.326e+07 2.094e+07 10     -36    history  10   DataTableBenchmark           ConcurrentRandomRead
Expected: random read is thread-bound and we reduced the number of threads from HardwareConcurrency() to 4.
pass 6.989e+06 5.587e+06 10     +25    history  10   DataTableBenchmark           ConcurrentInsert
Expected: concurrent insert is bottlenecked on CAS on the free slot bitmap, so reducing the number of threads from HardwareConcurrency() to 4 reduces contention.
pass 4.917e+06 3.698e+06 10     +32    history  10   GarbageCollectorBenchmark    ReclaimTime
Expected: the default buffer segment size changed from 32KB to 4KB so freeing them is now faster
pass 6.539e+06 5.367e+06 10     +21    history  10   TupleAccessStrategyBenchmark ConcurrentInsert
Expected: see previous insert bottleneck discussion
All of these will be resolved with a reset in the near future (after the rest of our Jenkins issues shake out) as we now expect these to be our baselines -- until we change them again :)


Use rubocop to find untranslated strings

I'm not sure if this feature might already exists somewhere,.. my google-foo can't find anything useful.
For a project that uses translations, we either do I18n.t('foo'), or just _('foo') sometimes
Could a cop be made to return an offense anytime an English string "I am a father" is found within the source code?
Describe the solution you'd like
Rubocop to report places where I left hardcoded text strings, which won't be translated
Describe alternatives you've considered
Going through the code manually
Additional context
We are going to implement multi-language in a large software which was never prepared for it.
Thanks

Will rubocop-i18n help with the issue?
https://github.com/puppetlabs/rubocop-i18n

Exactly what I was looking for, thank you

You are welcome!


Return errors login

Following issue #60, it is necessary to modify the returns in order to display the messages in case of error

The error and creation messages have been modified to display the corresponding information, if the user has created his account or if it is impossible to create an account, if the login information is wrong


Tablefilter fix

Closes #1330
Summary
Fixes the clear filter issue that was introduced
Change List (commits, features, bugs, etc)

add key conditionally to filterheaderrow

Acceptance Test (how to verify the PR)

go to ?path=/story/watson-iot-table--stateful-example-with-expansion-maxpages-and-column-resize
open knobs and change hasFilter from onKeyPress to onBlur
press clear filter button
see that all filters are cleared.

:tada: This PR is included in version 2.93.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


do we need an icons folder?

The idea is to collect all the headless and daisy icons in a folder so the components can use them.

i prefer with this one

@qwik-ui/icons/{headless, material, daisy}

How about using https://icones.js.org/ ?

Wow, cool! that's a lot of icons, and also Qwik is already integrated (even just the Qwik component with svg in it).
But I wonder, with Icones, do we need to download all of the icon sets or just cherry-pick one or two icon sets?


OAuth AppAccessToken seemingly not getting automatically added to request headers.

(Reposting because may be urgent). Hey, this doesn't seem to work as you say. I have this code:
if time.Now().After(authExpiry) {
	authExpiry = time.Now()
	res, err := twitch.GetAppAccessToken()
	exitIfError(err)
	authExpiry = authExpiry.Add(time.Duration(res.Data.ExpiresIn) * time.Second)
	log.Insta <- fmt.Sprintf("< | token generated: %s (for %ds)", res.Data.AccessToken, res.Data.ExpiresIn)
}
res, err := twitch.GetStreams(&getStreamsParams)
if err == nil && res.StatusCode != 200 {         // reinterpret HTTP error as actual error
	err = fmt.Errorf("HTTP %d: %s", res.StatusCode, res.ErrorMessage)
}
if err != nil {
	log.Insta <- fmt.Sprintf("x | < : %s", err)
}

and my program output
< | token generated: pfzn88vavmt9hlgy6c33aonf2imako (for 5444223s)
x | < : HTTP 401: OAuth token is missing

during the migration test window that just ended (is back to normal now). Any ideas?
Originally posted by @Pyorot in https://github.com/nicklaw5/helix/issues/42#issuecomment-622518993

@Pyorot hey man, subscriptions require a user access token, not a app access token fyi, you also did not show how you initialised the twitch obj,all aswell fetching one but you also need to use either a app access or user token

Do you have a worked example? I was just following this one; I define the helix object using client ID and client secret.

I just found out that this library has not been sending the Bearer token. I found out because resp.GetRateLimit() returned 30 instead of 800.
It seems a lot of oauth code has been re-written instead of using the official oauth2 package, so it doesn't quite behave the same as other packages. I wonder what happens when the app token expires?
Got it to work using this:
ops := &helix.Options{
	ClientID:     config.Config.TwitchClientID.Get(),
	ClientSecret: config.Config.TwitchClientSecret.Get(),
}

client, err = helix.NewClient(ops)
token, err := client.GetAppAccessToken()
client.SetAppAccessToken(token.Data.AccessToken)

Yeah, I also got it to work the same way, confirmed during the 2020/5/4 token requirement window. Leaving the issue open until issues #42, #44, and the [https://github.com/nicklaw5/helix/blob/master/docs/authentication_docs.md](usage example) are updated accordingly.

This is already documented here.
Please open a PR if you would like to add any further documentation.

The authentication_docs.md usage example is missing the SetAppAccessToken() line. I don't fancy forking the repo just to correct that.

I don't fancy forking the repo just to correct that.

Then stop wasting our time, and either write your own library or use another.


Don't highlight output stating no errors/warnings

I'm building the new xproj/dnx project type and seeing output like this:

This seems similar to issue #3. Perhaps the output format is slightly different in this case.
Each time the magenta/red flashes up, I have cause to pause. It'd be nicer to only see red for real errors.
Thanks for a great VS extension.

Just change the regular expressions in the settings to suit your needs. There's no way to match every situation.

Got this working like so:

You may wish to make this part of the default set though. This is not some exotic project type -- it's set to become the default project type in future.

I'll add it in a future version. Thanks.


Add in bioinfo bootcamp details retrospectively

Would you advise adding anything else here? (esp. any information / metadata that helps you in particular)
Do these events get automatically pulled into the TESS/ELIXIR database, or do I need to add it separately?

I don't actually have a link out for it, as it was an internal course, is that a problem?

not a problem, but in that case we should change the layout to event, not event-external, then you just get a GTN event page with any description and info you want :+1:

event-external do not get submitted to TeSS, it's assumed that's handled by the course authors elsewhere. (and reduces the metadata required for those events.)
if it's an event layout, then it will be submitted to TeSS, you won't have to do that at all :)


[SPARK-32757][SQL][FOLLOWUP] Preserve the attribute name as possible as we scan in SubqueryBroadcastExec

What changes were proposed in this pull request?

This is a minor followup of https://github.com/apache/spark/pull/29601 , to preserve the attribute name in SubqueryBroadcastExec.output.
Why are the changes needed?

During explain, it's better to see the origin column name instead of always "key".
Does this PR introduce any user-facing change?

no
How was this patch tested?

existing tests.

cc @wangyum @HyukjinKwon

Test build #128979 has started for PR 29839 at commit 36a06c4.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33601/
Test PASSed.

Test build #128979 has finished for PR 29839 at commit 36a06c4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128979/
Test PASSed.


Fixed punctuation and removed unrelated sentence

(309) Removed unwanted comma and dot
(310) Changed single quotes to double quotes
(314) Removed unrelated sentence

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks.

Copy review.

https://github.com/MicrosoftDocs/windows-insider/pull/293#discussion_r443146647

@bleblancMSFT - PR has been copy edited and is ready for final review.
Thank you.

@bleblancMSFT Please merge this PR. Thanks.


Alloy docs are missing

The old Alloy docs (https://docs.appcelerator.com/platform/latest/#!/api/Alloy) are not included in the current https://titaniumsdk.com/api/
The files are located at https://github.com/tidev/alloy/tree/master/docs

+1

any news on the integration part? Would be nice to have it in the docs again for the next release

still have no clue how to add the alloy docs. There is only a jsca file and some js docs, no yml files. If I remember correctly the old docs showed all animations (https://github.com/tidev/alloy/blob/master/Alloy/builtins/animation.js#L70-L77)  but they are not listed in https://github.com/tidev/alloy/blob/master/docs/apidoc/builtins.js
Is https://github.com/appcelerator/doctools needed to build Alloy docs?

I can't fully remember how the Alloy docs got included in the old site and I'm not certain that they ever were included in this site.
If I remember right, jsduck would be ran over the JS files in the Alloy repo and use the JSDoc in those to then generate the required pages. Given that the jsduck is now no longer used maybe it would make sense to convert those files into TDoc yaml and have those instead?

I think you are right, guess we'll need to convert them. Would make it easier in the long run


Meta just changed encodec license to MIT

Check it out...
Should be able to use for commercial use now.
https://github.com/facebookresearch/encodec/commit/349b72939f57cb3bc7b60906c0ee8228c849485d

Duplicate


Starting merger without common-forked-blocks-store-url generates error

Don't specify any storage locations.  It should default to the datadir specified with -d (which is /var/lib/dfuse in our case.  Get weird error:
Error: unable to launch: failed to init destination archive store: parse "file://{sf-data-dir}/storage/forked-blocks": invalid character "{" in host name
2022-11-26T17:03:44.884Z ERRO (derr) acme-blockchain {"error": "unable to launch: failed to init destination archive store: parse \"file://{sf-data-dir}/storage/forked-blocks\": invalid character \"{\" in host name"}

Example:
$ /usr/bin/fireantelope -d /var/lib/dfuse -c /etc/dfuse/config.yml start

config.yml:
start:
  args:
  - reader-node-stdin
  - merger
  flags:
    verbose: 0
    reader-node-grpc-listen-addr: :9000
    common-first-streamable-block: 1

This is presumably an upstream bug.  I already mentioned to SF team a few other issues with forked directories getting created on blockchains that have no forks.. So maybe something broke/needs fixing here.


[Discussion] Behavior of Multi-Pilet Debugging

Bug Report
Prerequisites

[ ] Can you reproduce the problem in a MWE?
[x] Are you running the latest version?
[x] Did you perform a search in the issues?

Environment Details and Version
piral-cli@next
Description
When running pilet debug on multiple pilets, only peer dependencies listed in the first found pilet will be exposed to the other pilets.
Steps to Reproduce
Expected behavior
Externals are gathered from all pilets rather than the first found
Actual behavior
Only the peer dependencies of the first pilet found in the glob are used for externals.
Possible Origin / Solution
I believe the solution would be concating all externals (and removing duplicate values) from the pilet passed in here

I may have had a fundamental misunderstanding - If pilet upgrade will go through and update the peerDependencies it's likely I just need to properly use that command

Yeah that is what pilet upgrade should do. It should essentially make sure your package.json (and the rest) of the pilet changes to whatever the Piral instance "wants" / "offers" / "expects".
Its a helper that makes sure you will produce a pilet that is fully compatible (and can leverage all the possibilities) with your shell.


New tklinenums 1.6.2 removes need to pass font

Remove font from line 257

Ohh, I didn't see this


electron-mail: init at 4.12.2

https://github.com/vladimiry/ElectronMail
Tested on x86_64 as that is the only supported architecture by the prebuilt upstream packages. Eventually the package could be updated to build the electron app.
I tested it on sway desktop environment with 'waybar' as my desktop status bar. This is notable as it seems to be one of the few status bars that has issues displaying some tray icons which is an issue as this package defaults to closing & opening minimized. I think this is a very small edge case that user's can manually fix by editing ~/.config/electron-mail/config.json - I mostly just want to document this issue.
A future update could expose some settings in config.js & hopefully allow setting the master key. It could change the default behavior to not minimize to avoid the issue mentioned above.
Since this is a new package it should be backported to stable.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 126523 run on x86_64-linux 1

1 package built:

electron-mail

OK, everything should be fixed. Thanks for the feedback.


Fixes #582 (Nested Provider subscriptions)

thx..i just got into this problem. That's awesome

and when will next patch be released? I need this in my project😅😍

@timdorr Any thoughts on pushing out a patch release?

 I'll try to get something out soon-ish.


Use in angular form

I'm trying to use ion-datepicker in an angular form, so my code uses formControlName instead of [(value)] to bind the value:
<span ion-item item-right ion-datepicker formControlName='expDate' clear class="ScheduleDate">
   <span>{{expDate | date}} <ion-icon name="clipboard"></ion-icon> </span>
</span>

But when I enter the page the following error is thrown:
ERROR Error: Uncaught (in promise): Error: No value accessor for form control with name: 'expDate'
Error: No value accessor for form control with name: 'expDate'

Is there any way to fix this?

Use inputs not spans
On Aug 16, 2018 1:38 PM, "sertal70"<EMAIL_ADDRESS>wrote:
I'm trying to use ion-datepicker in an angular form, so my code uses
formControlName instead of [(value)] to bind the value:

{{expDate | date}}

But when I enter the page the following error is thrown:
ERROR Error: Uncaught (in promise): Error: No value accessor for form
control with name: 'expDate'
Error: No value accessor for form control with name: 'expDate'
Is there any way to fix this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/misha130/ion-datepicker/issues/86, or mute the thread
https://github.com/notifications/unsubscribe-auth/AGV4LKP0hWG3kZTuz7byrDUuplCxRZGJks5uRa4lgaJpZM4WASfJ
.


feat(styles): add list inline styles and update docs

This will be added with #4097

@gfellerph please check if this PR is still needed, as a list-inline mixin and class have already been implemented.

Closing as duplicate


Updating Text, does not re-redraw the image

When updating data-name from one value to another, the Avatar does not refresh to reflect the new value.

This might not be the best way to do it and i hope we can get a better solution to it in the future but this is how i did it
$(#initial_img).remove();
var img = $('', {
id: "#your_id"
});
img.attr('data-name', "Name");
img.attr('class', "profile circle");
img.appendTo($("#id_of_div_around_img"));
i had to remove the img because html i could'nt just remove the src of an image it had to be replaced and i didnt want to scouring through the code to find the svg creation bit. This seemed like an easier solution to me


how do i stop a sound though lua?

Describe your problem here.
here's the code i have so far
if curStep == 446 then
removeLuaSprite('boo', false)
stopSound = 'boo'
end
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
no

wait i didn't add a tag to the sound


Links for updated CIPR and source code

Thanks, @atakanekiz.

Thank you @seandavi! This is an amazing resource.


Bagel recipe.

When boiling bagels, should put them upside down first so don't have to flip them again when done


Calibration Error

Dear author, thank you very much for sharing your code. Your code is essential for building a reasonable traffic scene, which is also the foundation of my next research.
Recently, I have been using your code to calibrate a small scene. I have adjusted all the parameters according to the readme and provided the files required for the small scene. Then I ran the code according to your steps, but I encountered the following error:

May I ask how to fix this error and where did I make a mistake in the settings? Could you please give me some advice when you have time? Thank you!

I am trying to calibrate traffic demand and supply using real data, using the Munich scenario provided in the example code, but I keep getting the following error：

Hi, sorry for the delay in responding. These errors seem to be originating due to the mismatch in the provided vs expected input formats. Please try to arrange the inputs as per the provided sample inputs. Although, I have tried to document that in the README, something might have been overlooked. Would it be possible for you to share the sample input files for me to inspect the error?

hi, same problem, i use provided Munich real data and a error raises "AssertionError: Shapes of Weight matrix: 4 and Count matrix: 0 are not equal"


Pyic 4822 mobile app download page

Proposed changes
What changed
Add mobile app download page
Why did it change
New page
Issue tracking

PYIC-4822

I've added some code for setting Android intents. It's currently untested as don't have an android app to test with, but I think it's worth keeping the code as the structure should be right even if not all the details are 100%


unable to create cdap in docker using windows 10

Expected behavior
Actual behavior
Information about the Issue
Steps to reproduce the behavior

...
...

Seems like this could've been a simple network issue - Could you re-try?


Directory reorganization

This changes our directory structure to allow for the main work space and android application to be stored in separate locations. I have run the tests and confirmed that they pass. Please review in case something is missing. Thank you.

Your OpenBankApplication/.idea directory is being tracked by your branch, as is now your open-bank/.idea directory. Because this is a result of your base directories now being in different paths than are assumed in your .gitignore, I believe it's worth disregarding the penalty for opening a pull request with these files. However, you'll need to update your .gitignore so that files which are no longer in open-bank/[directory] are listed properly as either open-bank/open-bank/[directory] or open-bank/OpenBankApplication/[directory].

Also, you seem to have several .gitignore files in the OpenBankApplication directory at different folder levels. Is this intentional? I believe it would be best to have only one .gitignore file for the whole project.

I will correct this.


Project

@AntonOsika / any engineers (if Anton is busy) interested to build an AI web & app based product with gpt-engineer in collab with a non engineer?

what do you have in mind?

The basis is a "How do I...?" query for deep learning, I have a specific set of data I'd like to train a LLM on. It could use it be useful for engineering, like gpt-engineer. You can even use it for games.

Hi @1nputmeth0d I am interested in making a web version of GPT Engineer. Can you give me your email?


MOMO api error

Getting this error ConnectionError: ('Connection aborted.', error(54, 'Connection reset by peer')) after submitting the callback host and Ocp-Apim-Subscription-Key for my transaction yet I have a steady network connection

CC @mossplix


Private Repositories multiple modules inside project

I tryed to put my modules on:
project/odoo/custom/src/private
If i put each module or addon inside private there is no problem like this:
private/
|-  module_one/
|- module_two/
|- ...
git-aggregate do right the job  but, if try to get a hole project inside private like:
private/
|- modules_project/
|-  module_one/
|- module_two/
|- ...
invoke git-aggregate cant link modules inside private/modules_project/

That's not possible: you have to put in private the modules in first level folder. There's no sense any way to put several folders there. It's the private part, which should tend to be minimal.

Well if you have an app with multiple modules it can be very functional,  I see the utility to do it because I have a repo on a private gitlab and cannot get it to work on copier, maybe I’m missing something to get it working the right way

Well, the requirement is to have all modules in first level, so you have to adapt your folder layout to that requirement.

Excelent thank you Manuel


Bug in kaldi/util/table.py

In this line, the method call to Open in self.Open(table_rspecifier, map_rspecifier) should be changed to lower case (open). I ran into this bug when trying to use the RandomAccessMatrixReaderMapped class.

Thanks for the report. Would you like to open a PR for the bugfix?


[Misc] Adding MMMU-Pro vision dataset to serving benchmark

This PR adds the support for MMMU-Pro vision dataset to the serving benchmark. This dataset is image-token-heavy (single image with average resolution of 1700x1600) and comes with a generic short text prompt, as describe in the dataset model card:

Vision: In this subset, questions are embedded within screenshots or photos, and models must integrate visual and textual information to answer correctly. No separate text is fed into the model.

Example command to run the benchmark
python3 benchmarks/benchmark_serving.py \
--dataset-path MMMU/MMMU_Pro \
--dataset-name hf \
--hf-subset "vision" \
--hf-split test \
--model <model name>  \
--backend openai-chat \
--endpoint /v1/chat/completions \
--num-prompts 100

Co-authored-by: @heheda12345

Currently the serving benchmark does not correctly count the image tokens, therefore the reported token generation rates are not accurate.


SSL Certificate Issues

When executing the Mod Updater, i get following issue:
[zetabite@thinkpad-l390-yoda VS_ModsUpdater_Linux]$ ./VS_ModsUpdater
Vintage Story Mod Updater - v.1.3.6 by Laerinok
An error has occurred. Please consult the debug file.
Limit mod updates to the game version : Latest version
An error has occurred. Please consult the debug file.
An error has occurred. Please consult the debug file.
An error has occurred. Please consult the debug file.

When looking in the debug log for every mod it says:
2024-03-29 23:23:35 : [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self-signed certificate in certificate chain (_ssl.c:1006) : [MOD NAME]

I don't know many about this. All I have read about this kind of ssl issue was for users having proxy or certain ISP with some security software. If they disable the proxy and have a direct connection, it was OK.
This message means that Python doesn't trust the certifcat provided by the site.
There was a user who had the same issue some months ago., with Linux too. As I am not a Linux user, my knowledges are very limited. I will investigate because I want understand this issue (and try to fix it), but for now I don't know what I can  do.

I downloaded your python file and executed it that way, and it downloaded. I would assume that means that the baked in libraries you ship are outdated or incompatible. I disabled the pdf part tho, since i cant seem to find the working version of fpdf

OK, nice you could use it this way.
I started this script as an exercice for learning python. It's my very first script and I didn't think to share it at the begining. So for sure, it can be a bit mess, and with some errors... I did not think it would become so "big" but thanks to this I learned a lot of things :)
If you want the pdf features, you need fpdf2 not fpdf. I don't know why it is not explicitly describe in the import.
You can have a look to the requirement.txt file if you need.

Ah, i see. Its weird that both use the same import name. Anyways. I would help, but i dont feel comfortable without license.

Fixed the fpdf thing. If you had installed the original fpdf, not fpdf2, then it borked when you installed fpdf2, since both use the same module name. By removing the fpdf files and reinstalling fpdf2 it worked. So now i have the script fully working.

Currently analyzing your packaged file. Would you be so kind to share your building parameters, i am guessing you are using pyinstaller?

I now was able to recompile the package myself, and that version works, i also diffed the extracted versions of both execu
tables and the following differs:
diff.txt

BTW, there is a space in your 1.3.6 release tag

I would help, but i dont feel comfortable without license.

Thanks. As I am learning I may often need help. But I like to search by myself for a while, and only when I cannot find my answer I ask for help.
According the license, do you mean for my script ? that's right I didn't give any info about it as, it was only an exercie for me, at the beginning, I didn't look for a specific license. Now it becomes "bigger" maybe I could think about it. But in anyway it will be something quite free. I didn't really know differences between each kind of licence, I should have a look, but if you want to modify and use  don't hesitate. If you want to give me some ideas, don't hesitate. And if you want to whos what you added/changed, that's the same. The more I see, the more I learn.
Indeed I use pyinstaller. I don't know if it is good, or if something better exists. As I said I am learning Python. Before I made this script I didn't know anything in Python or programming. So I used the first info I found, and now with some months more, I know I would make some things in an other way. But I won't start from the begining now.
I have already a fresh venv. I noticed that the binairie file was bigger and biger and it was beacuase I tried and installed some modules and they were packaged event I didn't use them. So having a fresh venv is something I try to have.

Currently analyzing your packaged file. Would you be so kind to share your building parameters, i am guessing you are using pyinstaller?

Do you mean theses arguments : --onefile $FileName$ --icon Vintagestory.ico --version-file file_version_info.txt --distpath PyInstaller\dist --workpath PyInstaller\build --specpath PyInstaller\spec
I use pyinstaller from Pycharm.

thanks, I will investigate what you said about ssl, but I as I said, it's already a fresh venv. I had a look at the file you gave me, but I am too tired to go further this evening :)

Yeah no problem. License just makes it easier to know the limits of usage and reusage of code. Since i might be able to use code from another project and viceversa. Otherwise if i contribute and mistakenly add code that was liscenced otherwise, that might force a license etc. I can suggest a few, but you probably wanna read in it yourself, to understand the terms used for licenses. for now what you wrote suffices for me to suggest stuff. I might do some refactoring later. I was planning on adding your mod updater to the AUR, its a place where people with archlinux or similar systems can fetch packages coveniently. Very similar to what Vintage story does via ModDB, but for programs for a distro. For that i rather have a license for your project, since that makes it easier to distribute. I am just careful, as I had a mess with people abusing licensing terms or the lack thereof, so i rather stay safe what that belongs. But yeah. Again, i really thank you for this tool its really great.

That's OK. I will Definitely have a look to choose a license. It will be "official". But there are so many ans I don't really see the difference (because I don't didn't really read them) between gnu, cc, mit e.g But I know what I don't want : to have a closed propriety. It's only an exercice for me and if it can be useful for anyone, that's a good thing. Moreover, I am not a linux user. I had a server on Ubuntu/Mint for a while, but it was more for learning purpose too. Now I only have  a VM or a rescue usb drive.
As some players asked me to be able to use on Linux I tried to make something. But I definitely have a lack of knowledge.
So feel free to make it available on different linux architectures

If you dont care what others do with your stuff, use UNLICENCSE (tho most people would discourage the use), if you dont wanna bother much, MIT and Apache, if you want copyleft, meaning, people have to use the same or stronge licenses, you use one of the diverse GPL licesenses. Copyleft means, that the same or stronger liscense has to be used.

Hello,
MIT-license added.
I deleted the 'build' folder before to make the new binairie. I think I didn't do this last time. I had only made a new venv. Hope this could solve the ssl issue.

Same issue on Linux. What's the current status here?

I think it's due to the SSL certificate expiring.
I saw that Python's certification is updated regularly. I could make a new release with the latest certificate to see if it fixes the issue. I'll try to see if I can release it this weekend, but no guarantees.


Laravel recipe: artisan config:cache is called twice

The deploy tasks of the current Laravel recipe (recipe/laravel.php) contain the following steps
    'artisan:config:cache',
    'artisan:optimize',

In Laravel the artisan:optimize command (Illuminate\Foundation\Console\OptimizeCommand) calls
        $this->call('config:cache');
        $this->call('route:cache');

That means that Deployer executes effectively

artisan config:cache
artisan config:cache
artisan route:cache

artisan config:cache is called twice.
I see two variants to fix it:
Variant 1: only artisan:optimize
    'artisan:optimize',

Variant 2: artisan:route:cache instead of artisan:optimize
    'artisan:config:cache',
    'artisan:route:cache',

Environment

Deployer version: 6.8.0
PHP version: 7.2.24
Deployment target(s) OS: Ubuntu 18.04.4 LTS
Laravel version: 7.15.0

Please, take a look at master branch. I think it’s already fixed there. Please, verify?

True, but artisan:route:cache is missing in the deploy process. It that intended?

I’m not sure.

Since version 5.5, this task can be removed from the script:

The optimize Command
With recent improvements to PHP op-code caching, the optimize Artisan command is no longer needed. You should remove any references to this command from your deployment scripts as it will be removed in a future release of Laravel.

I am cleaning up on issues. Fill free to reopen if needed.
Also, we have a new section available: discussions.


integration tests using cucumber and knative table tests

working first pass of integration tests using cucumber and knative table tests

/lgtm


fixed gimp; install+uninstall were not silent

silent args were not stringent enough to install or uninstall silently.  updated to suppress progress boxes.
also, filled in empty nuspec tags and corrected poor info

@dtgm thanks for your contribution!  Apart from one comment, this looks good to me.  Can you fix it up, and then I will get it pulled in.
Thanks!

@dtgm These changes will appear in the next official release of GIMP, or do you think it is justified to release a version with package fix notation?


not safe to start multiple instances of embedded mysql for same major version

Now they share several resources:

temp fodler is fixed to ./target/mysql-5.x;
running multiple downloads in parralel is not safe.
might be some temp file issues (sock ir such).

Given you run multiple instances in parallel, it pretends to work (and starts), but it is in an inconsistent state as they potentially share database files and shutdown for only one instance will succeed.
Solution:

either think of a way to enable multiple parallel runs;
fail fast if another instance is being started in same process.

@noam-almog given it's in a single process, then yes, but we might have a set-up, where multiple jvms are forked for a single module (I'm sure you can do that via maven as well), then I have to do some fs-locking and that is plain annoying:/ Also I still get issues with multiple downloads - let's say you have a clean state (mysql files are not cached in ~./embedmysql), then multiple processes/runs start downloading it/extracting it and I'm not even sure what will happen then:/
So it's doable, but not sure I wanna go there.

I don't know if you remember, but the initial implementation used random guid on target dir, so user could have created as much instances he wanted but we changed it to fix the FW issues on osx.
To sync stuff here, because you can have multiple builds running on multiple processes you must use a file lock, there is no way around this.

@noam-almog - you are correct, but after cleaning-up all startup/preparation scripts now it's clear how multiple instances can be separated. I did a PR, ci for linux, osx, windows seem to pass, so I will merge this PR on Monday if all is good.


Cannot find module '@workshop/server'

Hi,
I installed as per the README.md instructions and ran webgl-workshop which gave the following error:
Error: Cannot find module '@workshop/server'
at Function.Module._resolveFilename (module.js:339:15)
at Function.Module._load (module.js:290:25)
at Module.require (module.js:367:17)
at require (internal/module.js:16:19)
at boot (C:\Users\crowne\AppData\Roaming\npm\node_modules\webgl-workshop\node.js:49:3)
at PromptUI.completed (C:\Users\crowne\AppData\Roaming\npm\node_modules\webgl-workshop\node.js:44:5)
at PromptUI.onCompletion (C:\Users\crowne\AppData\Roaming\npm\node_modules\webgl-workshop\node_modules\inquirer\lib\ui\prompt.js:51:10)
at C:\Users\crowne\AppData\Roaming\npm\node_modules\webgl-workshop\node_modules\inquirer\node_modules\async\lib\async.js:254:17
at C:\Users\crowne\AppData\Roaming\npm\node_modules\webgl-workshop\node_modules\inquirer\node_modules\async\lib\async.js:157:25
at C:\Users\crowne\AppData\Roaming\npm\node_modules\webgl-workshop\node_modules\inquirer\node_modules\async\lib\async.js:251:21

Something changed in Node 5.x that broke webgl-workshop.  If you use nvm, nvm install 4 && npm install -g webgl-workshop.  Everything should work then.

What if you don't use nvm?
And Node is now at 6 and counting; shouldn't someone just fix the actual problem?

Someone should fix the actual problem.  In the meantime, there's a workaround.

@andyearnshaw I've got same problem, according to your suggestion I installed nvm and press "nvm install 4 && npm install -g webgl-workshop", It works! Thanks a lot.

It seems, the subfolder work-shop and exercises are not installed. I cloned the repo and linked the start file to the bin folder.

Same issue.
λ npm -v
5.3.0

λ node -v
v6.9.1

λ uname
MSYS_NT-10.0

error:
readline.js:982
            throw err;
            ^

Error: Cannot find module '@workshop/server'
    at Function.Module._resolveFilename (module.js:469:15)


when add do_mlm

when i add do_mlm flag, cosine similarity will become larger even two sentences are irrelevant?

Hi,
The MLM training is know for causing "representation degeneration", which means the embeddings of different words/sentences become similar.

thank for you kind apply !
well, i have an another question. i have a dataset consist of a line of two sentence, which not labels whether they are similar or not .
for the task above , i try to train the model in the unsupervised way, where i group the sentA and sentB into one sentence for the unsupervised training.
Do you have some kind advice ?  thanks a lot .


False negatives

We have applied this library to a corpus of ours and have found the following issues

it doesn't annotate sentences without "that"

Amidst the turmoil, some seasoned diplomats have expressed concerns, deducing Russia's strategy to be more intricate than openly acknowledged.
Notwithstanding the public opinion, those well-versed in Russian politics argue its goals remain consistent, albeit strategically veiled.
As per the insights from senior defense officials, Moscow's endeavors in the space sector are a clear testament to its global ambitions.
Taking into consideration Russia's recent actions, a majority of   European leaders have suggested stronger sanctions might be the answer.
Russia, geopolitical analysts contend, is reshaping its stance towards Middle Eastern affairs.
From various reports, it seems Russia is keen on bridging gaps with European neighbors.
Russia's Arctic strategy, as defense analysts have pointed out, is both economic and military.
Global leaders have inferred from Russia's moves that a new cold war era might be looming.
Notably, Russia, defense insiders suggest, is widening its influence in Asia-Pacific regions.

it doesn't annotate sentences with unusual CUE

There's speculation among international experts that Russia might be diversifying its energy sources.

Bad annotation with "according to", but there are good ones as well

According to some sources source , the Russian administration believes cue economic ties with Africa to be vital content .
It's content , according to cue some political analysts source , a move to consolidate power that Russia is exhibiting.

Bad annotated or NOT annotated when CONTENT is divided

Russia's moves in the Baltic sea, intelligence experts source hint cue , might be about more than naval exercises content .
Russian tactics, military scholars often emphasize, are adaptive to changing geopolitical climates.

it doesn't annotate complex SOURCE

Valentina Tereshkova source , the famous cosmonaut, has often said cue she sees potential for greater space collaboration between countries content .
Sergey Naryshkin source , the head of Russia's Foreign Intelligence Service, hinted cue that there's more to the story than what's public content .
Irina Bokova source , former Director-General of UNESCO, has argued cue that cultural exchanges can bridge many international divides content

Other bad annotations:

Is Russia diversifying its trade? Some economic experts source think cue so content .
Concerning missile defense systems source , Russian military theorists contend cue that it's a move for deterrence content , not first strike.
I source once heard that Garry Kasparov commented on the political landscape, claiming cue that change is always possible with collective effort content .

Any idea whether anything could,be done about this?

Unfortunately there is no easy solution. You could annotate the problem cases, add them to the PARC dataset and then retrain the classifiers but this might not eliminate all the errors.


[mesheryctl] channel switch: update in confirmation verbiage

Signed-off-by: leecalcote<EMAIL_ADDRESS>Description
This PR simply improves the confirmation question slightly.
Signed commits

[x] Yes, I signed my commits.

Codecov Report

Merging #3507 (2f7de14) into master (008287e) will decrease coverage by 2.16%.
The diff coverage is 0.49%.

@@            Coverage Diff             @@
##           master    #3507      +/-   ##
==========================================
- Coverage   12.63%   10.47%   -2.17%
==========================================
  Files          37       37
  Lines        2929     3209     +280
==========================================
- Hits          370      336      -34
- Misses       2467     2806     +339
+ Partials       92       67      -25

Flag
Coverage Δ

gointegrationtests
?

unittests
10.47% <0.49%> (-0.94%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mesheryctl/internal/cli/root/config/config.go
0.92% <0.00%> (ø)

mesheryctl/internal/cli/root/perf/perf.go
26.66% <0.00%> (-23.34%)
:arrow_down:

mesheryctl/internal/cli/root/system/channel.go
16.49% <0.00%> (-2.33%)
:arrow_down:

mesheryctl/internal/cli/root/system/config.go
1.11% <ø> (ø)

mesheryctl/internal/cli/root/system/start.go
1.27% <0.00%> (-0.24%)
:arrow_down:

mesheryctl/internal/cli/root/system/status.go
0.00% <0.00%> (ø)

mesheryctl/internal/cli/root/system/stop.go
0.93% <0.00%> (-0.16%)
:arrow_down:

mesheryctl/internal/cli/root/system/system.go
69.23% <ø> (ø)

mesheryctl/internal/cli/root/system/update.go
1.13% <0.00%> (-0.22%)
:arrow_down:

mesheryctl/pkg/utils/auth.go
0.00% <0.00%> (ø)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8ce3b8...2f7de14. Read the comment docs.


selectively import lodash to avoid bundling the whole lodash

fix #114
based on the sample app in https://github.com/ignatiusreza/cloudinary-114 , different in final bundle size are:

current master: 126 kB
shrinkwrap: 73 kB
this PR (without shrinkwrap): 99.6 kB

@ignatiusreza Good idea! Thanks for the pull request!

Thanks for the merge! Glad I could help


Unable to use exllama binding

Expected Behavior
Be able to use exllama binding
Current Behavior
Imposible use exllama binding
I get the error:
Traceback (most recent call last):
File "E:\data_test\bindings_zoo\exllama2_init_.py", line 114, in build_model
from exllamav2 import (
ModuleNotFoundError: No module named 'exllamav2'
Steps to Reproduce
clone repo
run scripts\windows\win_install.bat
once app run, select exllama2 binding
Context
windows 10
rtx 3090
Screenshots
(video to the entire process https://youtu.be/UpXPpFnTC8A)

FYI seems that i've found workaround for now, you can add to bindings_zoo/exllama2/requirements.txt dependency exllamav2 manually, something like:
...
websockets
regex
exllamav2 # add here

And reload exllama2 binding from UI

thanks very much for your reply, I think we are close, but now I have this other error:
Traceback (most recent call last):
  File "E:\finalLollms\lollms-webui\env\lib\site-packages\exllamav2\ext.py", line 14, in <module>
    import exllamav2_ext
ModuleNotFoundError: No module named 'exllamav2_ext'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "E:\finalLollms\data\bindings_zoo\exllama2\__init__.py", line 114, in build_model
    from exllamav2 import (
  File "E:\finalLollms\lollms-webui\env\lib\site-packages\exllamav2\__init__.py", line 3, in <module>
    from exllamav2.model import ExLlamaV2
  File "E:\finalLollms\lollms-webui\env\lib\site-packages\exllamav2\model.py", line 11, in <module>
    from exllamav2.cache import ExLlamaV2Cache
  File "E:\finalLollms\lollms-webui\env\lib\site-packages\exllamav2\cache.py", line 2, in <module>
    from exllamav2.ext import exllamav2_ext as ext_c
  File "E:\finalLollms\lollms-webui\env\lib\site-packages\exllamav2\ext.py", line 124, in <module>
    exllamav2_ext = load \
  File "E:\finalLollms\lollms-webui\env\lib\site-packages\torch\utils\cpp_extension.py", line 1308, in load
    return _jit_compile(
  File "E:\finalLollms\lollms-webui\env\lib\site-packages\torch\utils\cpp_extension.py", line 1736, in _jit_compile
    return _import_module_from_library(name, build_directory, is_python_module)
  File "E:\finalLollms\lollms-webui\env\lib\site-packages\torch\utils\cpp_extension.py", line 2136, in _import_module_from_library
    module = importlib.util.module_from_spec(spec)
ImportError: DLL load failed while importing exllamav2_ext: No se puede encontrar el módulo especificado.

Hi and sorry for the late reply.
Last week I worked on major upgrades to the ui and now it has a new more stable structure. Please consider reintalling using the last stable release installer.
This should be the final structure.

Hi @ParisNeo , thanks for your reply.
Now, i have installed exllama, but I have detected other error when you try to download a model.
To be able to download a model I have done two things,
first, I have comment some code on get_file_size function because it explode

second,

I have had to parse repo var because on repo was the url complete, so the if of line 402 (on my code because the prints)
On repo, instead TheBloke/Spicyboros-13B-2.2-GPTQ was  https://huggingface.co/TheBloke/airoboros-33B-GPT4-2.0-GPTQ/resolve/main/model.safetensors
Im not python programmer, so I dont understand very well the structure of the code, so I think I cant to make a pr, but I think this information is good for you
def obtener_nombre_modelo_desde_url(url):
    from urllib.parse import urlparse
    parsed_url = urlparse(url)
    path_segments = parsed_url.path.split('/')
    path_segments = [segment for segment in path_segments if segment != '']
    nombre_modelo = '/'.join(path_segments)
    return nombre_modelo


Clean

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Test done. The cluster creation function works


error occurs when creating chaos-controller-manager

dongxu@dongxus-MacBook-Pro ~
$ kubectl get po -n chaos-testing                                                                                [17:17:56]
NAME                                        READY   STATUS      RESTARTS   AGE
chaos-controller-manager-75ff888c45-nrq4z   0/1     Error       5          94m
chaos-daemon-2tvb4                          1/1     Running     0          94m
chaos-daemon-644l2                          1/1     Running     0          94m
chaos-daemon-6vfkf                          1/1     Running     0          94m
chaos-daemon-8kw2t                          1/1     Running     0          94m
chaos-daemon-ffgz9                          1/1     Running     0          94m
chaos-daemon-kwr6s                          1/1     Running     0          94m
webhook-certs-job-n2ffj                     0/1     Completed   0          94m
webhook-mw-job-4n6jz                        0/1     Completed   0          93m

$ kubectl describe po chaos-controller-manager-75ff888c45-nrq4z -n chaos-testing                                                                                [17:18:25]
Name:               chaos-controller-manager-75ff888c45-nrq4z
Namespace:          chaos-testing
Priority:           0
PriorityClassName:  <none>
Node:               kind-worker2/<IP_ADDRESS>
Start Time:         Mon, 06 Jan 2020 15:43:40 +0800
Labels:             app.kubernetes.io/component=controller-manager
                    app.kubernetes.io/instance=chaos-mesh
                    app.kubernetes.io/name=chaos-mesh
                    pod-template-hash=75ff888c45
Annotations:        <none>
Status:             Running
IP:                 <IP_ADDRESS>
Controlled By:      ReplicaSet/chaos-controller-manager-75ff888c45
Containers:
  chaos-mesh:
    Container ID:  containerd://c634de296bd9bfc5b4f850ab29e3317ec34779ffa9b7e9ffea6fc2a53599091e
    Image:         pingcap/chaos-mesh:latest
    Image ID:      docker.io/pingcap/chaos-mesh@sha256:79dcc52939857a48bc524465985617765b3bde14f4b32a64c0c5e24654244f4a
    Port:          9443/TCP
    Host Port:     0/TCP
    Command:
      /usr/local/bin/chaos-controller-manager
      -configmap-labels=app.kubernetes.io/component=webhook
      -conf=/etc/webhook/conf
    State:          Waiting
      Reason:       CrashLoopBackOff
    Last State:     Terminated
      Reason:       Error
      Exit Code:    1
      Started:      Mon, 06 Jan 2020 17:18:17 +0800
      Finished:     Mon, 06 Jan 2020 17:18:19 +0800
    Ready:          False
    Restart Count:  5
    Limits:
      cpu:     500m
      memory:  1Gi
    Requests:
      cpu:     250m
      memory:  512Mi
    Environment:
      NAMESPACE:          chaos-testing (v1:metadata.namespace)
      TZ:                 UTC
      CHAOS_DAEMON_PORT:  31767
    Mounts:
      /etc/webhook/certs from webhook-certs (ro)
      /var/run/secrets/kubernetes.io/serviceaccount from chaos-controller-manager-token-htbrf (ro)
Conditions:
  Type              Status
  Initialized       True
  Ready             False
  ContainersReady   False
  PodScheduled      True
Volumes:
  webhook-certs:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  webhook-certs
    Optional:    false
  chaos-controller-manager-token-htbrf:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  chaos-controller-manager-token-htbrf
    Optional:    false
QoS Class:       Burstable
Node-Selectors:  <none>
Tolerations:     node.kubernetes.io/not-ready:NoExecute for 300s
                 node.kubernetes.io/unreachable:NoExecute for 300s
Events:
  Type     Reason       Age                    From                   Message
  ----     ------       ----                   ----                   -------
  Normal   Scheduled    94m                    default-scheduler      Successfully assigned chaos-testing/chaos-controller-manager-75ff888c45-nrq4z to kind-worker2
  Warning  FailedMount  94m (x7 over 94m)      kubelet, kind-worker2  MountVolume.SetUp failed for volume "webhook-certs" : secrets "webhook-certs" not found
  Normal   Started      2m40s (x4 over 3m39s)  kubelet, kind-worker2  Started container
  Warning  BackOff      2m5s (x7 over 3m32s)   kubelet, kind-worker2  Back-off restarting failed container
  Normal   Pulling      113s (x5 over 93m)     kubelet, kind-worker2  pulling image "pingcap/chaos-mesh:latest"
  Normal   Pulled       110s (x5 over 3m40s)   kubelet, kind-worker2  Successfully pulled image "pingcap/chaos-mesh:latest"
  Normal   Created      110s (x5 over 3m40s)   kubelet, kind-worker2  Created container

@c4pt0r  Can you give us some logs about this pod
kubectl logs chaos-controller-manager-75ff888c45-nrq4z -n chaos-testing -p
kubectl logs chaos-controller-manager-75ff888c45-nrq4z -n chaos-testing

dongxu@dongxus-MacBook-Pro ~/gopkg/src/github.com/pingcap/chaos-mesh
master $ kubectl logs chaos-controller-manager-75ff888c45-nrq4z -n chaos-testing -p                                                                                [13:07:23]
kubectl logs chaos-controller-manager-75ff888c45-nrq4z -n chaos-testing
Controller manager Version: version.Info{GitVersion:"v0.0.0-master+$Format:%h$", GitCommit:"dfb390693dbe8a7afba472bb3b6a939f5de1137f", GitTreeState:"clean", BuildDate:"2020-01-03T15:17:35Z", GoVersion:"go1.13.4", Compiler:"gc", Platform:"linux/amd64"}
2020-01-06T09:47:14.248Z	INFO	controller-runtime.metrics	metrics server is starting to listen	{"addr": ":8080"}
2020-01-06T09:47:14.248Z	INFO	setup	setting up webhook server
2020-01-06T09:47:14.248Z	INFO	inject-webhook	Inferred ConfigMap	{"namespace": "chaos-testing", "filepath": "/var/run/secrets/kubernetes.io/serviceaccount/namespace"}
2020-01-06T09:47:14.249Z	INFO	inject-webhook	Creating Kubernetes client from in-cluster discovery
2020-01-06T09:47:14.253Z	INFO	inject-webhook	Created ConfigMap watcher	{"apiserver": "https://<IP_ADDRESS>:443", "namespaces": "chaos-testing", "watchlabels": {"app.kubernetes.io/component":"webhook"}}
2020-01-06T09:47:14.253Z	INFO	controller-runtime.webhook	registering webhook	{"path": "/inject-v1-pod"}
2020-01-06T09:47:14.253Z	INFO	setup	Starting manager
2020-01-06T09:47:14.253Z	INFO	controller-runtime.controller	Starting EventSource	{"controller": "iochaos", "source": "kind source: /, Kind="}
2020-01-06T09:47:14.253Z	INFO	controller-runtime.webhook.webhooks	starting webhook server
2020-01-06T09:47:14.254Z	INFO	controller-runtime.certwatcher	Updated current TLS certificate
2020-01-06T09:47:14.254Z	INFO	controller-runtime.webhook	serving webhook server	{"host": "", "port": 9443}
2020-01-06T09:47:14.253Z	INFO	setup	Launching watcher for ConfigMaps
2020-01-06T09:47:14.254Z	INFO	inject-webhook	Watching for ConfigMaps for changes	{"namespace": "chaos-testing", "labels": {"app.kubernetes.io/component":"webhook"}}
2020-01-06T09:47:14.253Z	INFO	controller-runtime.controller	Starting EventSource	{"controller": "networkchaos", "source": "kind source: /, Kind="}
2020-01-06T09:47:14.253Z	INFO	controller-runtime.manager	starting metrics server	{"path": "/metrics"}
2020-01-06T09:47:14.253Z	INFO	controller-runtime.controller	Starting EventSource	{"controller": "podchaos", "source": "kind source: /, Kind="}
2020-01-06T09:47:14.306Z	INFO	controller-runtime.certwatcher	Starting certificate watcher
2020-01-06T09:47:15.794Z	ERROR	controller-runtime.source	if kind is a CRD, it should be installed before calling Start	{"kind": "IoChaos.pingcap.com", "error": "no matches for kind \"IoChaos\" in version \"pingcap.com/v1alpha1\""}
github.com/go-logr/zapr.(*zapLogger).Error
	/home/pingcap/go/pkg/mod/github.com/go-logr/zapr@v0.1.0/zapr.go:128
sigs.k8s.io/controller-runtime/pkg/source.(*Kind).Start
	/home/pingcap/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.4.0/pkg/source/source.go:88
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1
	/home/pingcap/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.4.0/pkg/internal/controller/controller.go:165
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start
	/home/pingcap/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.4.0/pkg/internal/controller/controller.go:198
sigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).startLeaderElectionRunnables.func1
	/home/pingcap/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.4.0/pkg/manager/internal.go:477
2020-01-06T09:47:15.794Z	DEBUG	controller-runtime.manager	leader-election runnable finished	{"runnable type": "*controller.Controller"}
2020-01-06T09:47:15.794Z	ERROR	setup	problem running manager	{"error": "no matches for kind \"IoChaos\" in version \"pingcap.com/v1alpha1\""}
github.com/go-logr/zapr.(*zapLogger).Error
	/home/pingcap/go/pkg/mod/github.com/go-logr/zapr@v0.1.0/zapr.go:128
main.main
	/home/pingcap/go/src/github.com/pingcap/chaos-mesh/cmd/controller-manager/main.go:149
runtime.main
	/home/pingcap/local/go/src/runtime/proc.go:203
Controller manager Version: version.Info{GitVersion:"v0.0.0-master+$Format:%h$", GitCommit:"dfb390693dbe8a7afba472bb3b6a939f5de1137f", GitTreeState:"clean", BuildDate:"2020-01-03T15:17:35Z", GoVersion:"go1.13.4", Compiler:"gc", Platform:"linux/amd64"}
2020-01-06T09:52:26.262Z	INFO	controller-runtime.metrics	metrics server is starting to listen	{"addr": ":8080"}
2020-01-06T09:52:26.264Z	INFO	setup	setting up webhook server
2020-01-06T09:52:26.266Z	INFO	inject-webhook	Inferred ConfigMap	{"namespace": "chaos-testing", "filepath": "/var/run/secrets/kubernetes.io/serviceaccount/namespace"}
2020-01-06T09:52:26.266Z	INFO	inject-webhook	Creating Kubernetes client from in-cluster discovery
2020-01-06T09:52:26.269Z	INFO	inject-webhook	Created ConfigMap watcher	{"apiserver": "https://<IP_ADDRESS>:443", "namespaces": "chaos-testing", "watchlabels": {"app.kubernetes.io/component":"webhook"}}
2020-01-06T09:52:26.269Z	INFO	controller-runtime.webhook	registering webhook	{"path": "/inject-v1-pod"}
2020-01-06T09:52:26.269Z	INFO	setup	Starting manager
2020-01-06T09:52:26.270Z	INFO	controller-runtime.webhook.webhooks	starting webhook server
2020-01-06T09:52:26.270Z	INFO	setup	Launching watcher for ConfigMaps
2020-01-06T09:52:26.270Z	INFO	controller-runtime.certwatcher	Updated current TLS certificate
2020-01-06T09:52:26.270Z	INFO	inject-webhook	Watching for ConfigMaps for changes	{"namespace": "chaos-testing", "labels": {"app.kubernetes.io/component":"webhook"}}
2020-01-06T09:52:26.270Z	INFO	controller-runtime.webhook	serving webhook server	{"host": "", "port": 9443}
2020-01-06T09:52:26.270Z	INFO	controller-runtime.manager	starting metrics server	{"path": "/metrics"}
2020-01-06T09:52:26.271Z	INFO	controller-runtime.controller	Starting EventSource	{"controller": "iochaos", "source": "kind source: /, Kind="}
2020-01-06T09:52:26.271Z	INFO	controller-runtime.controller	Starting EventSource	{"controller": "podchaos", "source": "kind source: /, Kind="}
2020-01-06T09:52:26.271Z	INFO	controller-runtime.certwatcher	Starting certificate watcher
2020-01-06T09:52:26.271Z	INFO	controller-runtime.controller	Starting Controller	{"controller": "iochaos"}
2020-01-06T09:52:26.272Z	INFO	controller-runtime.controller	Starting EventSource	{"controller": "networkchaos", "source": "kind source: /, Kind="}
2020-01-06T09:52:26.372Z	INFO	controller-runtime.controller	Starting Controller	{"controller": "podchaos"}
2020-01-06T09:52:26.372Z	INFO	controller-runtime.controller	Starting Controller	{"controller": "networkchaos"}
2020-01-06T09:52:26.373Z	INFO	controller-runtime.controller	Starting workers	{"controller": "podchaos", "worker count": 1}
2020-01-06T09:52:26.372Z	INFO	controller-runtime.controller	Starting workers	{"controller": "iochaos", "worker count": 1}
2020-01-06T09:52:26.373Z	INFO	controller-runtime.controller	Starting workers	{"controller": "networkchaos", "worker count": 1}
2020-01-06T10:43:26.069Z	ERROR	inject-webhook	channel has closed, should restart watcher
github.com/go-logr/zapr.(*zapLogger).Error
	/home/pingcap/go/pkg/mod/github.com/go-logr/zapr@v0.1.0/zapr.go:128
github.com/pingcap/chaos-mesh/pkg/webhook/config/watcher.(*K8sConfigMapWatcher).Watch
	/home/pingcap/go/src/github.com/pingcap/chaos-mesh/pkg/webhook/config/watcher/watcher.go:122
main.watchConfig.func1.1
	/home/pingcap/go/src/github.com/pingcap/chaos-mesh/cmd/controller-manager/main.go:176
2020-01-06T10:43:26.069Z	ERROR	setup	watcher got error, try to restart watcher	{"error": "watcher channel has closed"}
github.com/go-logr/zapr.(*zapLogger).Error
	/home/pingcap/go/pkg/mod/github.com/go-logr/zapr@v0.1.0/zapr.go:128
main.watchConfig.func1.1
	/home/pingcap/go/src/github.com/pingcap/chaos-mesh/cmd/controller-manager/main.go:180

can we close it now? @cwen0

@siddontang yes, this error caused by no CRD object, we need to apply these CRD objects before starting the Chaos Mesh.
exec the following commands to apply CRD objects:
cd chaos-mesh
kubectl apply -f manifests/

more detail: https://github.com/pingcap/chaos-mesh#create-custom-resource-type

so why @c4pt0r forgot to apply this? do we provide a more specific guide?

@cwen0 will create a script to wrapper this https://github.com/pingcap/chaos-mesh/issues/192


Move 13 tests from smoke-fails to smoke

The list of 13 was produced by taking intersection of passing tests in smoke-fail for ROCm 6.0 , 6.1 and COD


Layout group choice

Codecov Report

Merging #145 into master will decrease coverage by 3.70%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88389d7...84e3d55. Read the comment docs.


Add release pipeline definitions

What this PR does / why we need it:
Adds release pipeline definitions.
/kind enhancement
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

NONE

/lgtm
/approve


Comment out timeoutSeconds

Please ensure your pull request adheres to the following guidelines:

[x] explain your motives to contribute this change: what problem you are trying to fix, what improvement you are trying to make
[x] Document your Changes in the CHANGELOG.md file of the respected chart as well as the Chart.yaml
[x] Bump the Version number of the respected chart

No need to set it since the value given is the default as noted at https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#configure-probes

Hello @bbodenmiller, thanks a lot for taking the time to participate in the community.
We purposely chose to keep those default value explicitly defined, ensuring that any default changes will not impact users on that topic.
I am going to close that PR.
Nonetheless i would really thank you for looking for improving our product, please do not hesitate to keep giving us those feedback.


Question about stage1.sh

Hello, I am very interested in your work and have a question I would like to ask.
Should the path in stage1.sh in the readme be scripts/pretrain_molecule instead of scripts/pretrain_multi_molecule?

bash scripts/pretrain_multi_molecule/stage1.sh

Looking forward to your reply.

Yeah you're right. Thx for pointing it out.


Update iOS.md

Updated iOS doc as to reflect API changes with patch 1.0.1

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

AdaptiveCards/display/libraries/iOS.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Plugin/Theme install/uninstall button links contain %5c

WonderCMS v3.4.1
Windows 11
Apache <IP_ADDRESS>
php 8.2.0
The install/uninstall Theme/Plugin buttons don't work in my installation because the urls for the links associated with these buttons contain "%5C".
Examples:
[code]https://wonder.test%5C/?deleteModule=sky&type=themes&token=...[/code]
[code]https://wonder.test%5C/?installModule=https://github.com/robiso/essence/archive/master.zip&directoryName=essence&type=themes&token=...[/code]
I believe %5C is an encoded backslash, so perhaps somewhere WonderCMS is escaping the forward slash in the url string?
I got things to install/uninstall by removing the %5C from the url.
Example:
[code]https://wonder.test/?deleteModule=sky&type=themes&token=...[/code]
[code]https://wonder.test/?installModule=https://github.com/robiso/essence/archive/master.zip&directoryName=essence&type=themes&token=...[/code]
But then I got some php Notices:
Deprecated: str_ireplace(): Passing null to parameter #2 ($replace) of type array|string is deprecated in ...index.php on line 906
Deprecated: str_ireplace(): Passing null to parameter #2 ($replace) of type array|string is deprecated in ...index.php on line 911
Warning: Cannot modify header information - headers already sent by (output started at ...index.php:911) in ...index.php on line 2046

Hello @foobass, thanks for dropping by!
We intentionally strip the %5C to avoid any directory traversal.
Is there any specific reason your setup uses those?

I'm sorry for the misunderstanding. I did not do anything to add %5C to the urls. They are just there. I will try to track down where they come from.

Inside the function url() on line 2800 of index.php I added a bit of code to write dirname($_SERVER['SCRIPT_NAME']) to a log.
The logfile contains many backslashes.  Here is the copy/pasted data:
\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\
Also, there are many backslashes in the urls in cache.json. Not sure if it's a Windows thing at this point. Will try to investigate further.

Aparently dirname returns backslashes on Windows so I guess that's the issue there.
But something is also escaping forward slashes. Here is an example of a url in my cache.json file:
"repo": "https:\/\/github.com\/robiso\/summernote-editor\/tree\/master",
The JSON spec says you CAN escape forward slashes, but you don't have to.

This fixed my original problem with being able to install/uninstall plugins/themes
inside function url() on line 2800:
$dir = str_replace('\\', '/', dirname($_SERVER['SCRIPT_NAME']));

return ($showHttps ? 'https' : 'http')
. '://' . ($_SERVER['HTTP_HOST'] ?? $_SERVER['SERVER_NAME'])
. ($_SERVER['HTTP_HOST'] ? '' : $serverPort)
. ((dirname($_SERVER['SCRIPT_NAME']) === '/') ? '' : $dir)
. '/' . $location;


[frames] Helper functions for frames

framesForwardKinematics(model, data, frame_id) computes oMf[frame_id], stores it and returns it. Assumes forwardKinematics has already been run. Thought it might be useful if the model contains many frames but we are only interested in one or two of them.
getFrameVelocity(model, data, frame_id, v_frame) computes the velocity of frame frame_id and puts it in v_frame. Assumes first-order forwardKinematics has already been run.
getFrameAcceleration(model, data, frame_id, a_frame) computes the acceleration of frame frame_id and puts it in a_frame. Assumes second-order forwardKinematics has already been run.

I think you should also implement the python bindings, and update the robot_wrapper API which does the same thing.

I agree. I was planning to do it if this pull request gets accepted

Thanks for these feedbacks.
I would go for updateFramePlacement instead of framesForwardKinematics by making this last function deprecated.

@gabrielebndn Can you make the modifications?

Alright

Ok, to summarize:

framesForwardKinematics(model,data,q) stays the same
framesForwardKinematics(model,data) is deprecated and replaced by updateFramePlacements
updateFramePlacements(model,data) replaces framesForwardKinematics(model,data)
updateFramePlacement(model,data,frame_id) [without final s] updates and returns a single frame
getFrameVelocity(model, data, frame_id, v_frame) returns the velocity of a single frame
getFrameAcceleration(model, data, frame_id, v_frame) returns the acceleration of a single frame

So, are we sure we want to split framesForwardKinematics into two different methods depending on the arguments? It might be confusing for those who are already using these methods. Maybe it's just easier to stay with framesForwardKinematics.
In Python, I also did the following

framesKinematics(model,data[,q]) is deprecated. It should be replaced either by framesForwardKinematics(model,data,q) or updateFramePlacements(model,data). I deprecated this function because the name was not consistent with C++
created the bindings for the new methods
updated RobotWrapper to use the bindings
other changes to RobotWrapper. Notably, deprecated "position" and "framePosition" to replace them with "placement" and "framePlacement"

Update: I slightly modified deprecation.py so that the instructions are automatically used as docstring in case none is provided

Looks fine.
I'm going to merge!


Radium integration Issue

When using radium, you pass in styles as such: style={[style.property]} but when they render on the page, the style attribute shows style="0 [Object object]" so, stardust components do not render radium styles.

It looks like Radium only works on built in html components.
//
// Widget.js
//
import React, {Component, PropTypes} from 'react';

export default class Widget extends Component {
  render() {
    return
I'm a widget.
;
  }
}

//
// WidgetUse.js
//
import React, {Component} from 'react';
import Radium from 'radium';
import Widget from './Widget';

@Radium
export default class WidgetUse extends Component {
  render() {
    return (

        <Widget style={[{background: 'coral'}]} />

I'm an html element

    );
  }
}

The result:

The style is spread as an array, which React converts to the array like object 0: [object Object], before Radium can deal with it.
Quick fix
The quick fix would be to use Radium on all our components, however, I'd prefer not to do this since not everyone uses Radium.  Stardust shouldn't dictate it.
Slightly Better
We could make a decorator that is a light wrapper around Radium.  It could use Radium if it exists, if not, then it would just return the decorated component directly.  This way, if you install Radium in your project, Stardust will use it, if you don't no harm.  This is a little better because we don't dictate dependencies.  It adds a little magic and an extra wrapper to every component.
There is likely a great solution to this so I want to leave this issue here a while.  If Radium could somehow support composite components, that may be the best solution.

@TechnologyAdvice has no more need for Radium as we've moved to SCSS and WebPack's style loader.  Closing for now, open to further discussion if community interest pushes it.


fix(README): update the links to point at openebs archive

Well, we hit this in CI this morning...


FC layer without Bias conversion issue

Introduction
Conversion from onnx to coreML fails if we use a Linear (Fully connected layer) with No bias. Pytorch generate a graph with the GEMM op if we use Bias, but uses a transpose and MatMul op if we set no Bias. Seems that there is an issue with the MatMul data initialization.

Code to reproduce
# Build a Mock Model in Pytorch with a convolution and a reduceMean layer\
import torch
import torch.nn as nn
import torch.onnx as torch_onnx
from onnx_coreml import convert

class Model_issue(nn.Module):
    def __init__(self):
        super(Model_issue, self).__init__()
        self.simple_nn = nn.Sequential(
            nn.Linear(256, 128, bias=False),
            #nn.Conv2d(in_channels=256, out_channels=128, kernel_size=(1,1), stride=1, padding=0, bias=False),
            nn.ReLU(),
        )

        # Initialize weights
        for m in self.modules():
            if isinstance(m, nn.Conv2d):
                nn.init.kaiming_normal_(m.weight, mode='fan_out', nonlinearity='relu')
            elif isinstance(m, nn.Linear):
                size = m.weight.size()
                fan_out = size[0]  # number of rows
                fan_in = size[1]  # number of columns
                variance = np.sqrt(2.0 / (fan_in + fan_out))
                m.weight.data.normal_(0.0, variance)

    def forward(self, x):
        feat1 = self.simple_nn(x)
        return feat1

# Use this an input trace to serialize the model
x_dummy_conv = torch.rand(1, 256, 1, 1)
x_dummy = torch.rand(1, 256)
model_onnx_path = "torch_model_fc_no_bias_issue.onnx"
model = Model_issue()
model.train(False)

# Export the model to an ONNX file
output = torch_onnx.export(model,
                          x_dummy,
                          model_onnx_path,
                          export_params=True,
                          verbose=True)

# Export to coreml
coreml_model = convert(model_onnx_path)
coreml_model.save('./test.mlmodel')

Error Stack
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-38-8ceb5c24bbd5> in <module>()
     44
     45 # Export to coreml
---> 46 coreml_model = convert(model_onnx_path)
     47 coreml_model.save('./test.mlmodel')

/usr/local/lib/python3.5/dist-packages/onnx_coreml/converter.py in convert(model, mode, image_input_names, preprocessing_args, image_output_names, deprocessing_args, class_labels, predicted_feature_name, add_custom_layers, custom_conversion_functions)
    394     for i, node in enumerate(graph.nodes):
    395         print("%d/%d: Converting Node Type %s" %(i+1, len(graph.nodes), node.op_type))
--> 396         _convert_node(builder, node, graph, err)
    397
    398     if add_deprocess:

/usr/local/lib/python3.5/dist-packages/onnx_coreml/_operators.py in _convert_node(builder, node, graph, err)
    992 def _convert_node(builder, node, graph, err):  # type: (NeuralNetworkBuilder, Node, Graph, ErrorHandling) -> None
    993     converter_fn = _get_node_converter_fn(builder, node, err)
--> 994     return converter_fn(builder, node, graph, err)

/usr/local/lib/python3.5/dist-packages/onnx_coreml/_operators.py in _convert_matmul(builder, node, graph, err)
    517     else:
    518         err.missing_initializer(node,
--> 519                                 "Weight tensor: {} not found in the graph initializer".format(weight_name, ))
    520
    521     if len(W.shape) != 2:

/usr/local/lib/python3.5/dist-packages/onnx_coreml/_error_utils.py in missing_initializer(self, node, err_message)
     69         "Missing initializer error in op of type {}, with input name = {}, "
     70         "output name = {}. Error message: {}\n".
---> 71         format(node.op_type, node.inputs[0], node.outputs[0], err_message)
     72       )
     73

ValueError: Missing initializer error in op of type MatMul, with input name = 0, output name = 3. Error message: Weight tensor: 2 not found in the graph initializer

ONNX file
Including the ONNX with and without the bias (Issue with the no bias version)
onnx_bias_no_bias.zip
Environment
I was able to reproduce the issue on the following case:

Pytorch 0.4.1 and 0.4.0
Python 3.5
onnx-coreml version from repository
onnx 1.2.1 and 1.3.0

PR #335 should fix this issue

Hi @aseemw I've checked with bigger models as well, and seems fine.

Hi, I'm confused about what was resolved in this issue. I'm trying to convert a linear layer with bias and getting the error "Error message: This Gemm layer cannot be converted to CoreML inner_product layer". I've built from onnx-coreml master just a few minutes ago, but the error wasn't resolved. Am I missing something? Are linear layers with bias currently supported and I have some other error going on?

This is likely because you model is slightly different.
There are 3 checks that can raise this error, can you inspect which one of these are raised by your model?
(See: https://github.com/onnx/onnx-coreml/blob/0ecca747f06e9861045a812f25d4a66f62173565/onnx_coreml/_operators.py#L1025)

It's an error from the first condition:
if node.attrs.get("transB",0) != 1:
If I instantiate the original model with a linear layer that has no bias term, I can convert successfully. I suppose that is different than the problem described by this issue, which was converting a no bias linear layer ( out =wx ) not ( out = wx +b ). Sorry for the confusion!

CoreML does not support all the variants of the generic "GEMM" layer, only the matrix-vector specific case.
Can you provide a tiny code block that generates the ONNX model with GEMM layer that has the "transB" set to 0? Maybe there is a workaround involving CoreML "inner_product" and "transpose" layers that can get the job done.

One question, why isn't Gemm without TransB supported in onnx-coreml? I'm
trying to convert from a pytorch model saved in onnx. Pytorch's
onnx.export() function exports Linear layers with bias as a Gemm with alpha
== beta == 1.0 and transa == transb == 0.0. It seems non-trivial to get
around this, and Linear is a very typical kind of layer.
Is there a place besides github issues to post this question?
On Sun, Nov 4, 2018 at 9:37 PM Aseem Wadhwa<EMAIL_ADDRESS>wrote:

This is likely because you model is slightly different.
There are 3 checks that can raise this error, can you inspect which one of
these are raised by your model?
(See:
https://github.com/onnx/onnx-coreml/blob/0ecca747f06e9861045a812f25d4a66f62173565/onnx_coreml/_operators.py#L1025
)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/onnx/onnx-coreml/issues/333#issuecomment-435738071,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABLs3kXMKomQnfDoZjbJQeq3gWKrcwEHks5ur6RMgaJpZM4WpM8R
.

--
Genevieve

Hmm, when I tried a pytorch (0.4.1) linear layer with bias, I got an onnx model with transB=1
(see here: https://github.com/onnx/onnx-coreml/blob/32df62e1292aaf1fc81de1e3d80323a91366ee6d/tests/model_test.py#L61)
Anyways, it turns out that the transB check was unnecessarily strict. PR #352 does away with that.
Please try again your model with that PR


chore: update aws instance status code

Type of change:

[ ] Bugfix
[ ] New feature provided
[ ] Improve performance
[ ] Backport patches

What this PR does / why we need it:

update aws instance status code to adapt golang-sdk
Pre-submission checklist:

[x] Did you explain what problem does this PR solve? Or what new features have been added?
[ ] Have you added corresponding test cases?
[ ] Have you modified the corresponding document?

Codecov Report

Merging #367 (36030e9) into main (559108f) will increase coverage by 0.26%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
+ Coverage   44.39%   44.66%   +0.26%
==========================================
  Files          46       46
  Lines        4919     4923       +4
==========================================
+ Hits         2184     2199      +15
+ Misses       2549     2525      -24
- Partials      186      199      +13

Impacted Files
Coverage Δ

...rator/pkg/reconcile/storagenode/aws/rdsinstance.go
22.79% <0.00%> (ø)

pitr/cli/internal/pkg/shardingsphere-proxy.go
15.51% <33.33%> (+15.51%)
:arrow_up:

...perator/pkg/controllers/storage_node_controller.go
47.25% <80.00%> (ø)

... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Please handle these conflicts and rebase, thanks


Grid Tile Clustering

This is from @joshuacortez:
In geospatial projects that involve scoring grid tiles, sometimes apart from the individual tiles, we’re also interested in the clusters of contiguous tiles that share the same attribute.
For example, we have tiles classified as urban or rural and want to find the urban clusters.
Input: Geodataframe (grid_x, grid_y)
Output: Geodataframe (grid_x, grid_y, cluster_id)
Important Considerations:

Scalability: Can handle many tiles and tiles of varying resolution
Runtime: Should run faster compared to the alternative spatial join approach
Tile format constraint: We don’t aim to cluster polygons of varying shapes (e.g. hexagon with square). This clustering follows directly from the “Grid Tile Generation” feature request, where the tiles are of the same square shape.

@joshuacortez  Just a clarification with the intended use case in mind, to get a clearer picture of how it'll be used.
Sample scenario: I have a gdf containing: grid_x, grid_y, geometry, urban_class
If I want to get urban clusters, I would do something like this (roughly based on the reference implementation):
urban_gdf = gdf[gdf["urban_class"] == "urban"]
urban_gdf_with_cluster_ids = cluster_tiles(urban_gdf)

gdf = # join logic here to place the cluster IDs back to the original GDF

Is this right?
For consistency with the other GeoWrangler functions, was thinking of something like this instead:
connectable_tiles = gdf[gdf["urban_class"] == "urban"]
gdf = cluster_tiles(gdf, connectable_tiles)
# gdf would then have a new column called "cluster_id" where each urban row has its corresponding cluster ID, while the the others (e.g. rural, sub-urban, etc) have NaNs.

This follows our current paradigm of input/output generally being the GDF representing the AOIs you care about.
Having the connectable_tiles param still keeps it flexible for any kind of logic you have on which tiles can be connected if adjacent (say, maybe you want urban and sub-urban).

What do you think?

Yep sounds good!
The function inputs can look like this
def cluster_tiles(
    gdf: gpd.GeoDataFrame,
    grid_x_col = "x",
    grid_y_col = "y",
    category_col: Optional[str] = None,
    categories_used: List[str] = None,
    connectivity_type: str = "four-way"
) -> gpd.GeoDataFrame:

The output is the same as the original gdf but with an appended cluster_id (string but can be NULL)
tile_id, x, y, , cluster_id

Addressed in PR here


TavilySearchResults in Agents Quick Start always return empty result

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.

Example Code
from langchain_community.tools.tavily_search import TavilySearchResults, TavilyAnswer

search = TavilySearchResults()
print(search.invoke("what is the weather in SF"))
# output: []

tans = TavilyAnswer()
print(tans.invoke("What is the weather in SF?"))
# output: The current weather in San Francisco is partly cloudy with a temperature of 51.1°F (10.6°C). The wind is coming from the west-northwest at 8.1 mph (13.0 km/h), and the humidity is at 86%. The visibility is 9.0 miles (16.0 km), and the UV index is 1.0. The highest temperature recorded in San Francisco in 2024 was 73°F (23°C) on January 29.

Error Message and Stack Trace (if applicable)
No response
Description
Issue:
I'm trying the Agents Quickstart example on Tavily.
As shown above, "TavilySearchResults" is returning empty response. Upon checking, I found "TavilyAnswer" can return results correctly. Digging further, I found the difference is due to Tavily rest API param "search_depth".
"TavilySearchResults" defaults to "advanced" while "TavilyAnswer" defaults to "basic".
I tried on https://app.tavily.com/playground, same behavior, search_depth="basic" can return results while "advanced" does not have result.
Possible Solution
I'm on Tavily free tier, hope the API tier does not make a difference.
I propose either to change default search_depth to "basic" or expose search_depth as variable in TavilySearchResults.
let me know any option is preferred, I can create a pull request
System Info
System Information

OS:  Darwin
OS Version:  Darwin Kernel Version 23.3.0: Wed Dec 20 21:30:44 PST 2023; root:xnu-10002.81.5~7/RELEASE_ARM64_T6000
Python Version:  3.9.18 | packaged by conda-forge | (main, Dec 23 2023, 16:35:41)
[Clang 16.0.6 ]

Package Information

langchain_core: 0.1.16
langchain: 0.1.5
langchain_community: 0.0.17
langchain_experimental: 0.0.50
langchain_openai: 0.0.5
langchainhub: 0.1.14

Packages not installed (Not Necessarily a Problem)
The following packages were not found:

langgraph
langserve

hi @wanwe I'm here from Tavily. Can you check if the issue is still happening?

@rotemweiss57 issue resolved, thank you !

I do encounter it now. The Playground returns a result as expected with TavilySearchResults from langchain_community.tools.tavily_search the result is empty. I did get results for exactly the same query yesterday.

I'm having the same issue with the TavilySearchAPIRetriever that is unreliable. It sometimes returns an empty array for the exact same input

I'm having the same issue too.
 // ===tavily response===
 {
  query: '"{\\"input\\":\\"2023 NBA final winner\\"}"',
  follow_up_questions: null,
  answer: null,
  images: null,
  results: [],
  response_time: 1.28
}


Reduce installation time

Installation time is fairly long because we have a lot of (indirect) dependencies.
It may be worth investigating whether this can be easily addressed.

Not a big problem anymore and the dependencies we have are truly needed


Add color and opacity to group elements

There are only 3 types of element components: image, text, and group. Groups are used  to control the size and position of its children, however there is more that could be done. Both image and text elements have in common the color and opacity properties. As such, the group could theoretically also control the color and opacity of its children.
If a group had the opacity set to 0.5, then a child image with opacity of 1 would only have effectively 0.5 opacity. If said child instead had 0.5 opacity, then it would have effectively 0.25 opacity(0.5 * 0.5). If the parent has color yellow and the child color blue, the child ends up with color green. And so on.
Why is this useful? For the same reason groups are already useful for positioning and scaling its children. When I want to control the color/opacity of a group of UI images/text at the same time. For example, If I want to fade out/fade in a UI screen, I currently have to iterate through each UI image/text to change the opacity, when I could just do that to the group if it was possible.

Wouldn't yellow parent and blue child end up black instead of green? Yellow is (1, 1, 0) and blue is (0, 0, 1) so yellow * blue = (0, 0, 0).

Hm...if you look at it this way, yeah. Not in the conventional way. But I guess it doesn't matter how it's done, as long as we can mix and get the result we want.

Anyway, I support the idea and I think it could also include a property to control interactibility of children (to mass toggle Element.useInput and possibly Button.active so they appear disabled). And maybe also a way for a child group to ignore parent group (when you need complex hierarchy, it can be useful to "reset" those properties locally).

+1

Oh, I see, we're in the designer vs. developer zone 😄
Unfortunately, in PlayCanvas (and in most if not all game engines), if you set up an element component with a yellow texture and a blue color, it ends up black because it simply does a multiply blend in sRGB color space, without considering any design convention. Color blending can be done in lots of way and I know first hand it could lead to misinterpretation (like a graphist making an asset to be tinted but using a blend mode other than "multiply" to test it in Photoshop thus it doesn't look the same in the game engine).
It still is a nice idea though, and I wish I'd thought about it before. I already have a terribly hacky way to handle group opacity and adding color to it could really be a great addition. Maybe some day I might make a PR to add all of this to the engine (if no one does it before) but it's way longer to do it correctly than nastily.

I think it's specially useful the opacity and color properties, since all UI elements have them. However I also support mass activating buttons and a property on the child to ignore parent. Just afraid it could get convoluted.
If you liked this suggestion, I invite you to take a look at my other ones :). See my editor suggestions  and other engine suggestions.


Publish to npm

You have a beautiful package.json, but it seems like css-layout is not in the npm registry registry.
Could you publish this to npm, please?

Sure, good idea :)

Done
> npm publish
+<EMAIL_ADDRESS>


make: add option to build/deploy with the UI component

Add a new configuration to choose if the REANA UI should be built and deployed. By default, it shouldn't do it since it is only ready for CERN.
Currently, it is built by default but never deployed.

Note that we may want to amend cli.py and REPO_LIST_CLUSTER as well, so that the component wouldn't be built unnecessarily.  (E.g. currently I've commented reana-ui out there in order to speed up local  developments.)


Added InsightsNetworkMigrationToEOS contract ABI

@gamalielhere You were the last person to make a commit on the mercury branch. Would you be able to help me identify who can approve this PR?

@gamalielhere Thanks for the approval. Would you be able to merge this PR as well?


ara: use correct variable for enabling persistent volumes

Signed-off-by: Ryan Taylor<EMAIL_ADDRESS>A default out-of-the-box installation of the ara chart fails because $.Values.persistence.enabled is referenced but not defined anywhere.
"Failure when executing Helm command. Exited 1.\nstdout: Release \"ara\" does not exist. Installing it now.\n\nstderr: Error: template: ara/templates/pvc.yaml:1:8: executing \"ara/templates/pvc.yaml\" at <$.Values.persistence.enabled>: nil pointer evaluating interface {}.enabled\n", "stderr": "Error: template: ara/templates/pvc.yaml:1:8: executing \"ara/templates/pvc.yaml\" at <$.Values.persistence.enabled>: nil pointer evaluating interface {}.enabled\n", "stderr_lines": ["Error: template: ara/templates/pvc.yaml:1:8: executing \"ara/templates/pvc.yaml\" at <$.Values.persistence.enabled>: nil pointer evaluating interface {}.enabled"]

It looks like the variable $.Values.persistentVolumes.enabled should be used for this, and it already exists in the values.yml file.

@Nold360

sadly it currently doesn't work like that, might need to take a deeper look at this
==> Linting .
[ERROR] templates/: template: ara/templates/pvc.yaml:1:8: executing "ara/templates/pvc.yaml" at <$.Values.persistence.enabled>: nil pointer evaluating interface {}.enabled

sadly it currently doesn't work like that, might need to take a deeper look at this
==> Linting .
[ERROR] templates/: template: ara/templates/pvc.yaml:1:8: executing "ara/templates/pvc.yaml" at <$.Values.persistence.enabled>: nil pointer evaluating interface {}.enabled

nvm.. your PRs are based on each other


Use UnicodeDammit in stoq.dumps

Coverage increased (+0.03%) to 95.827% when pulling 54444487df4c8d7036f514f12f60a93ebd1873bd on maydewd:v2 into 045830a385837e2a7b548ec34970d40ab483aab0 on PUNCH-Cyber:v2.