add company object in graphql job result

Fixes #59, Fixes #63

Codecov Report

Merging #66 (2a95010) into main (57aa63b) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   41.28%   41.28%
=======================================
  Files           9        9
  Lines         390      390
=======================================
  Hits          161      161
  Misses        201      201
  Partials       28       28

Impacted Files
Coverage Δ

pkg/service/job.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57aa63b...2a95010. Read the comment docs.


Only ask for release path if it exists in json

ref #241

This shouldn't be needed any more, as #221 (now merged) means that an exception is raised if the path doesn't exist, and this line shouldn't be reached any more.
See new function  _run_store_json_blob in https://github.com/open-contracting/kingfisher/blob/master/ocdskingfisher/base.py


Move firewall bits to respective shell scripts

Will probably still need a shell script to turn on firewall.
https://www.liquidweb.com/kb/how-to-install-apache-on-centos-7/

Actually, adding firewall logic to each service makes it feel/look messy.
Also, if there's not firewalld running, the logic gets odd for checking first.
Going to keep it in the one file.


Small changes

Changes:

Now you can select any loop to send to the ComfyApiWrapper.queue_and_wait_images function, by default it is asyncio.get_event_loop()

Thanks, will update package on the weekend


Delete attached BelongsToOneRelation relations with upsertGraph

Hi,
I am trying to delete a belongstoone relation using upsertgraph method
For example, starting with this model (using belongstoonerelation) :
parent: { id: 1, child: { id: 'c1' } }
upsertGraph(parent, { insertMissing: ['child'] })

Then, if i remove the child from parent :
parent: { id: 1 }
upsertGraph(parent)

Then child stills exists (and is still related to parent).
I would expect child to be completely removed from database.
Here is a full example that reproduces the problem :

const { Model, knexSnakeCaseMappers } = require('objection');
const Knex = require('knex');

const knex = Knex({
    client: 'sqlite3',
    useNullAsDefault: true,
    connection: {
        filename: 'example.db'
    },
    pool: {
        afterCreate: (conn, cb) => {
            conn.run('PRAGMA foreign_keys = ON', cb);
        },
    },
});

Model.knex(knex);

class Address extends Model {
    static get idColumn() {
        return 'city';
    }

    static get tableName() {
        return 'addresses';
    }
}

class Person extends Model {
    static get tableName() {
        return 'persons';
    }

    static get relationMappings() {
        return {
            address: {
                relation: Model.BelongsToOneRelation,
                modelClass: Address,
                join: {
                    from: 'persons.addressId',
                    to: 'addresses.city'
                }
            }
        };
    }
}

async function createSchema() {
    await knex.schema.dropTableIfExists('persons');
    await knex.schema.dropTableIfExists('addresses');

    await knex.schema.createTable('addresses', table => {
        table.string('city').primary();
    });

    await knex.schema.createTable('persons', table => {
        table.increments('id').primary();
        table.string('addressId').references('addresses.city');
        table.string('firstName');
    });
}

async function main() {
    const sylvester = await Person.query()
        .upsertGraphAndFetch({
            firstName: 'Sylvester',
            address: {
                city: 'Paris',
            },
        }, { insertMissing: ['address'] });

    console.log('Sylvester:', sylvester);

    const sylvesterLeftParis = await Person
        .query()
        .debug()
        .upsertGraphAndFetch({
            id: sylvester.id,
            firstName: 'Sylvester',
        });

    console.log('Sylvester left Paris:', sylvesterLeftParis);

    const addresses = await Address.query();

    console.log('addresses:', addresses);

    return Promise.resolve();
}

createSchema()
    .then(main)
    .catch(console.error);

Expected result :
Sylvester left Paris: Person { id: 1, addressId: null, firstName: 'Sylvester' }
Addresses: []

Actual result :
Sylvester left Paris: Person { id: 1, addressId: 'Paris', firstName: 'Sylvester' }
Addresses: [ Address { city: 'Paris' } ]

You need to explicitly set the child to null. Otherwise everythig would always be deleted unless you mention it.

Hi @koskimas ,
If i set address to null, i obtain a foreign key constraint error

What's the debug print in that case?

Here is the full log :
Sylvester: Person {
  id: 1,
  addressId: 'Paris',
  firstName: 'Sylvester',
  address: Address { city: 'Paris' } }
{ method: 'select',
  options: {},
  timeout: false,
  cancelOnTimeout: false,
  bindings: [ 1 ],
  __knexQueryUid: '55f9bb2f-02b1-482c-b9a7-6875e68c3ddd',
  sql: 'select `persons`.`addressId`, `persons`.`id` from `persons` where `persons`.`id` in (?)' }
{ method: 'select',
  options: {},
  timeout: false,
  cancelOnTimeout: false,
  bindings: [ 'Paris' ],
  __knexQueryUid: '42bf89a9-d7ac-423a-b9f7-54dae1bb368a',
  sql: 'select `addresses`.`city` from `addresses` where `addresses`.`city` in (?)' }
{ method: 'del',
  options: {},
  timeout: false,
  cancelOnTimeout: false,
  bindings: [ 'Paris' ],
  __knexQueryUid: '4f97e6bf-8315-4ca6-a83f-57db76050dbe',
  sql: 'delete from `addresses` where `addresses`.`city` in (?)' }
{ Error: SQLITE_CONSTRAINT: FOREIGN KEY constraint failed errno: 19, code: 'SQLITE_CONSTRAINT' }

Hmm.. It first tries to delete the address and after that set the foreign key to null. Really weird, I'll need to look into that. You could set table.string('addressId').references('addresses.city').onDelete('SET NULL') to get around this issue I think

With the delete set null : (notice the update request)
Sylvester: Person {
  id: 1,
  addressId: 'Paris',
  firstName: 'Sylvester',
  address: Address { city: 'Paris' } }
{ method: 'select',
  options: {},
  timeout: false,
  cancelOnTimeout: false,
  bindings: [ 1 ],
  __knexQueryUid: 'e402efc5-dfe8-40bd-b403-0a6370bf2f9a',
  sql: 'select `persons`.`addressId`, `persons`.`id` from `persons` where `persons`.`id` in (?)' }
{ method: 'select',
  options: {},
  timeout: false,
  cancelOnTimeout: false,
  bindings: [ 'Paris' ],
  __knexQueryUid: '153bf449-1273-41ed-9563-d89291d20e50',
  sql: 'select `addresses`.`city` from `addresses` where `addresses`.`city` in (?)' }
{ method: 'del',
  options: {},
  timeout: false,
  cancelOnTimeout: false,
  bindings: [ 'Paris' ],
  __knexQueryUid: '67ad6e76-32ea-4de6-97ce-966dd6960ae5',
  sql: 'delete from `addresses` where `addresses`.`city` in (?)' }
{ method: 'update',
  options: {},
  timeout: false,
  cancelOnTimeout: false,
  bindings: [ 'Sylvester', 'Paris', 1 ],
  __knexQueryUid: '7030d798-8da9-42ed-9c7c-3722e5eea78a',
  sql: 'update `persons` set `firstName` = ?, `addressId` = ? where `persons`.`id` = ?' }
{ Error: SQLITE_CONSTRAINT: FOREIGN KEY constraint failed errno: 19, code: 'SQLITE_CONSTRAINT' }


fix: exit when indexer add failed

What this PR does / why we need it:
fix #1209
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Codecov Report

Merging #1211 (42459fc) into main (b2483b7) will decrease coverage by 0.04%.
Report is 7 commits behind head on main.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff             @@
##             main    #1211      +/-   ##
==========================================
- Coverage   35.81%   35.77%   -0.04%
==========================================
  Files          28       28
  Lines        2178     2180       +2
==========================================
  Hits          780      780
- Misses       1295     1297       +2
  Partials      103      103

see 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Added no_grad() to predict method.

Added no_grad() to predict method, making inference a bit quicker and consume less memory.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@alvaropp can you share how much do we gain through this in terms of the memory and inference speed? I am asking because model.generate already has a no_grad inside.

Ahh, I'm sorry, didn't realise that was the case. Saw that the neighbouring embed() method was decorated and thought it was an omission. I've run a quick benchmark and don't see an effect on runtime, deleting this PR now.


Added netstat, kill and crontab commands in linux

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)

Closes #XXXXX

Added questions for netstat, kill and crontab commands in linux.

Hi @jdwilkin4. I've made the changes you've requested.
Thank you for the suggestions.


Is Russian to ASCII correct?

Example: Is this correct?
"лысая гора" -> "lysaja gora"

Can a native speaker, please check the character-replacement, thanks.
https://github.com/voku/portable-ascii/blob/master/src/voku/helper/data/ascii_by_languages.php#L468

http://translit.cc/ for rescue, this specific case will be "lysaja gora".

Thanks @kalessil I have merged the suggestions from "translit.ru" and "translit.cc" here: https://github.com/voku/portable-ascii/blob/master/src/voku/helper/data/ascii_by_languages.php#L468

There are multiple ways to tranlit and there are many GOSTs (state standards). Using the one for passports would produce "lysaia gora".

https://en.m.wikipedia.org/wiki/Romanization_of_Russian

There are multiple ways to tranlit and there are many GOSTs (state standards). Using the one for passports would produce "lysaia gora".

I would use this one, actually. It is GOSTed (i.e. standardized).

@Hlaford the problem is that there are multiple standards that are not deprecated.

Do different standards all have the same language code?

Yes.

Hmm, I guess we just need to choose a standard.

No, that won't work well. If it's something like generating slugs for an article title, that doesn't matter much which standard is used. If it's passport names, your users may get in trouble if you aren't using correct standard. If your service if exchanging info with state road police, it matters to use correct standard for road signs and street names.

So solution would be allowing to choose a standard.

+1 for "So solution would be allowing to choose a standard."

@samdark Ok, so what standards do a normal application / user need?
"Passport (2013)" + "GOST 7.79-2000(B)" -> https://en.m.wikipedia.org/wiki/Romanization_of_Russian#content-collapsible-block-1

Yes. Would be enough for many typical cases.

@samdark I added mappings for "ru__passport_2013" && "ru__gost_2000_b" (copy&past from wikipedia).
Can you please take a look at it, here is a test case for the string "лысая гора": https://github.com/voku/portable-ascii/commit/a2b1920093b2df9dbbb9334cdfa482c9f879f018
Mappings:

Russian - Passport (2013), ICAO | https://github.com/voku/portable-ascii/blob/master/src/voku/helper/data/ascii_by_languages.php#L539
Russian - GOST 7.79-2000(B) | https://github.com/voku/portable-ascii/blob/master/src/voku/helper/data/ascii_by_languages.php#L641

Looks OK to me.

Thank you for the review & feedback. :+1:


Automatic assets - js modules match py modules (2)

Supersedes #252 (I broke that branch)
Closes #244
This PR is a continuation of #225. I wish I'd realized the potential of this earlier, but I guess I needed #225 first in order to see how we can take it further ...
This PR:

Introduces the concept of a JS module (only used internally), that matches with a Python module.
We can have JS modules for modules that define Model classes, or for fully PyScript compatible modules.
PyScript now reports the globals (used, but undefined variables) of the transpiled code.
We can use that information to detect what global variables of the Python module are used by JS.
We can use that to collect dependencies and correctly import these names in the JS module
Similarly we can see what functions/classes we need to transpile (and include the result in the JS module).

All this means that the user won't have to do any asset management, except for specifying external assets (e.g. Bokeh, JQuery, Phosphor), but this can likely be done by simply defining the asset in a module; we can detect it and automatically make that asset a dependency of the JS module.
This also means that we can use linting tools to evaluate our JS, instead of having to fool them.

Some notes: in essense, the idea of modules is all about propagating dependencies:

In PyScript we detect unresolved dependencies in JS code, and move these up
the namespace stack.
The create_js_hasevents_class() function and ModelMeta class collect the
dependencies from the different code pieces.
In JSModule we resolve some dependencies and let other propagate into
module dependencies.
In the Bundle class, again some dependencies are resolved due to bundling,
and others propagate to dependencies between bundles.


addons: Remove global list of add-ons

We should not show the entire list of add-ons in our database. Instead,
we should just gate the list of add-ons by cluster and take into account
the organization's quota.

rebased


Added support for Jump Options

Yarn has support for Jump Options, format style:
[[Display text for user|NodeName]]
This enables support for this text feature.

@andresmakesgames thanks for the addition!

@cxsquared Thank you for getting it up and running! Happy to give back.

@andresmakesgames just want to let you know that I pushed up a fix for a bug that was introduced with this around markup/format function support.

I found the same bug last night and was going to submit a fix as well! Thank you!


A Read Only User attempting to create a namespace, results in a non-descriptive error message

Rancher Server Setup

Rancher version: v2.6.0-head on commit-id: f811996
Installation option (Docker install/Helm Chart): Helm Chart

If Helm Chart, Kubernetes Info:
Cluster Type (RKE1, RKE2, k3s, EKS, etc): RKE1
Information about the Cluster

Kubernetes version: v1.21.3-rc6+rke2r2
Cluster Type (Local/Downstream): RKE2 Digital Ocean Cluster

Describe the bug
With a Read Only user, when attempting to create namespace instead of getting a descriptive error, the error message returned is: Method POST not supported.
This is the API response:
code: "PermissionDenied"
links: {}
message: "Method POST not supported"
status: 403
type: "error"

To Reproduce

With an Admin user created a cluster (either RKE1 or RKE2)
Create a project in that cluster
Add a Read Only user to that aforementioned project
Login as the Read Only user and attempt to create a namespace

Result
There is a failure with error message: Method POST not supported
Expected Result
A failure with a more descriptive error message.
Screenshots

@ibuildthecloud With the Steve API, do we have the ability to update/change error messages?

Why is a r/o user being shown a create button.

This seems like the button should be hidden.
Closing in favor of this dashboard issue: https://github.com/rancher/dashboard/issues/3875


tests: execute remote container tests

This is mainly for jenkins CI and it is only the first step
(turning on PostgreSQL tests for now)!  In future we should have
some local-only (and less expensive) tests, too.
Jenkins is only responsible for setting 'OS' variable (defaults to
centos7).
When some changes are needed in remote git repositories (say
PostgreSQL container) one have to first submit a pull request
against that git repository where one of the commits needs to
contain commit message with line of this format:
Required-by: postgresql-container#111

.. where 'postgresql-container' is the name of project within
sclorg group, and '111' string is the id of already submitted pull
request.  Local testing against such pull-requests works too
(unless the actual branch is not yet merged into 'origin/master'
branch).

@omron93 can you please have a look at the API (whether it is OK for jenkins)?  @pkubatrh, @hhorak any comment is welcome, too

Thanks. Nice idea to include reference of project+PR which should be tested in git log.
@praiskup What about adding some "default" value for "Required-by"? - to be able to easily test small changes in this repo (which does not need any changes in image repositories). For example to test master branch of postgresql-container and s2i-python-container to make sure that even small changes to this repository does not break building and without forcing to add to each commit same "Required-by" values.
I'll try to setup CI for this repo...

On Monday, August 21, 2017 2:28:14 PM CEST Marek Skalický wrote:

@praiskup What about adding some "default" value for "Required-by"? - to be able to easily test small changes in this repo (which does not need any changes in image repositories).

There's by default mentioned 'postgresql-container#master' (I had a bug in Makefile though, so I fixed it now);  and we can add more with time.  Or better fine-tune the list of tests etc.  Take this as a first step please :)

For example to test master branch of postgresql-container and s2i-python-container to make sure that even small changes to this repository does not break building and without forcing to add to each commit same "Required-by" values.

Ok, I've added s2i-python-container too.

I'll try to setup CI for this repo...

Thanks!

It looks good to me, I think even running just two containers every-time should reveal some unexpected incompatibilities, and the rest will be caught when updating submodules.. Anyway, the ability to pick some particular PR seems like power enough extension, which might help as well.

So, any other suggestions or can we merge? and try to deploy into jenkins?

@omron93 promised to have a look at incorporating this into jenkins soon :)

[test]

[test]

Sounds like CI is doing something!  Thanks @omron93.  Let me rebase this to have 0f93964ea15ba4688233 in.

Let me rebase this to have 0f93964 in.

You are right.
CI should now be working for this repo in same way as for other container repositories.
For commits from members of sclorg organization tests are triggered automatically. Also these members can triggers them by adding [test] into commit message.

But 0f93964 is in.  Anybody knows the reason for this message to show up?
error: Setup script exited with error in docker-py setup command: Invalid environment marker: python_version < "3.5"

0f93964 is already in, so it means that the commit was useless and the docker-squash still fails to install on RHEL7/CentOS7

Now using python27-python-virtualenv for installing docker-squash and I hope it helped.
[test]

@praiskup One question: is the default list of tested images be cleaned when some explicit "Required by:" is present? I think it should be...

@omron93  wrote:

is the default list of tested images be cleaned

It is not (intentionally).  If one of the tested containers is broken by "commons PR", it should be mandatory for the guy who submits the PR to also submit pull-request against the broken container.
So there's no way to actually avoid testing one of the already listed images.  I don't thihk this is anyhow important implementation detail;  we can discuss peculiarities later.

It is not (intentionally). If one of the tested containers is broken by "commons PR", it should be mandatory for the guy who submits the PR to also submit pull-request against the broken container.

It makes sense. Two additional PRs isn't so much.
LGTM from me.

Thanks @omron93!  Merging.


Add Project info to live DB

@raindogg Just leave the list here if possible when you have it. Thanks!


Change image from webp to png

This code is created using pillow and os module in python. You have to provide the path to the images files you want to chagne.

Loooks great!


StreamInputDestinationMessageSender is getting the destination from the definition which is wrong property key

Describe the bug
I am upgrading to the new spring cloud stream functional way of doing things (Hoxton.SR9) and using the new test binder.  When invoking my producer contract StreamInputDestinationMessageSender seems to be reading the destination from the definition field which is wrong. I think it should be looking up destination from the property config
Sample
I have a producer contract as follows
Contract.make {
    description('should send an exchange times event on a scheduled event')

    label('triggerExchangeTimesEventOnScheduledEvent')
    input {
        triggeredBy('triggerExchangeTimesEventOnScheduledEvent()')
    }
    outputMessage {
        sentTo('exchange-times-events')

where 'exchange-times-events' is my Kafka topic.
In my consumer I have a simple function
 @Bean
  public Consumer<Flux<ExchangeTimeEvent>> exchangeTimes() {
    return events -> events.subscribe(event -> {
      log.info("exchangeTimeEvent = {}", event);
      ....
    });
  }

and properties
spring.cloud.stream.bindings.exchangeTimes-in-0.destination=exchange-times-events
spring.cloud.function.definition=exchangeTimes

To test this I am using the new  new streams test binder and invoking my contract as such.
  @Test
  public void shouldGetTheExchange() {
    stubTrigger.trigger("triggerExchangeTimesEventOnScheduledEvent");

and I get the error "Destination with name [exchange-times-events] not found in the function definitions [exchangeTimes]"
because org.springframework.cloud.contract.verifier.messaging.stream.StreamInputDestinationMessageSender indexOfDestination is looking for the destination in the definition which I don't think is right.  The destination must be looked up from the definition surely? I would of thought StreamInputDestinationMessageSender gets the definition then looks up spring.cloud.stream.bindings.{definition}-in-0.destination to get the destination?
Is this a bug?
Thanks

Added an example: https://github.com/davidmelia/spring-cloud-contract-producer-kafka-consumer
If you run you will see ConsumerIntegartionTest
java.lang.IllegalStateException: Destination with name [avro-fx-rate-events] not found in the function definitions [consumeAvro;consumeJson]
which makes no sense as destinations are not contained in the definitions property.

Added an example: https://github.com/davidmelia/spring-cloud-contract-producer-kafka-consumer
If you run you will see ConsumerIntegartionTest
java.lang.IllegalStateException: Destination with name [avro-fx-rate-events] not found in the function definitions [consumeAvro;consumeJson]
which makes no sense as destinations are not contained in the definitions property.


Use ReadMsgUDP and WriteMsgUDP on windows

This addresses the following three TODOs (@fastest963) all in udp_windows.go:
// TODO(fastest963): Once go1.10 is released, use ReadMsgUDP.

// TODO(fastest963): Once go1.10 is released, use WriteMsgUDP.

// TODO(fastest963): Once go1.10 is released and we can use *MsgUDP methods
// use the standard method in udp.go for these.

I haven't tested this on a Windows machine (and Travis doesn't have Windows support), so this should probably be manually tested before merging.

Codecov Report

Merging #738 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #738      +/-   ##
=========================================
- Coverage   55.74%   55.7%   -0.04%
=========================================
  Files          39      39
  Lines       10722   10722
=========================================
- Hits         5977    5973       -4
- Misses       3665    3668       +3
- Partials     1080    1081       +1

Impacted Files
Coverage Δ

udp.go
84.09% <ø> (ø)
:arrow_up:

msg.go
78.71% <0%> (-0.63%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a34f54...0810cda. Read the comment docs.

All in favor, can test either, because who runs windows these days.


GetAll fails due to stream reset when reading namespace with 1mb blob

./celestia rpc blob GetAll 13281 0x42690c204d39600fddd3 on arabica-9
leads to:
2023-07-02T17:05:38.643+0100    WARN    shrex/nd        shrexnd/client.go:78    client-nd: peer returned err       {"err": "client-nd: reading response: stream reset"}

The ND protocol does not support messages bigger than 1mb atm. The easiest short-term solution is to increase the single message size limit, which causes the stream reset. The better option is to support message chunking which won't have performance implications.

here's a script I use to submit big pfbs in case needed for testing:
#!/bin/bash

export CELESTIA_NODE_AUTH_TOKEN=$(./celestia light auth admin --p2p.network arabica)

printf '{
  "id": 1,
  "jsonrpc": "2.0",
  "method": "blob.Submit",
  "params": [
   [
        {
          "namespace": "AAAAAAAAAAAAAAAAAAAAAAAAAEJpDCBNOWAP3dM=",
          "data": "' > curldata.txt
printf `cat /dev/urandom | head -c $1 | base64 --wrap=0` >> curldata.txt
printf '",
          "share_version": 0,
          "commitment": "yqCkSLJCudll7PWbO26ktWMR4gZOITNFUffMLmXLTcg="
        }
   ]
  ]
 }' >> curldata.txt

curl -X POST -H "Authorization: Bearer ${CELESTIA_NODE_AUTH_TOKEN}" \
   -H 'Content-Type: application/json' \
   -d @curldata.txt \
   http://localhost:26658

usage:
./script.sh <pfb size in bytes>

The ND protocol does not support messages bigger than 1mb atm. The easiest short-term solution is to increase the single message size limit, which causes the stream reset. The better option is to support message chunking which won't have performance implications.

Wouldn't it look the same as the shrexeds implementation (which should support 8mb blocks) anyway - or does that support message chunking?

@musalbas, shrexeds uses modified CAR format for which we've implemented streaming Read and Write primitives so that it's designed around big message sizes. The ND protocol sends a single protobuf encoded message, as namespace data is not encoded in CAR format. We avoided the CAR format for ND to minimize overhead for LN requesting namespace data, which CAR format brings


[Feature Request] upload component, using scoped-slot to set thumbnail template, the progress bar is not displayed.

Existing Component
是
Component Name
upload
Description
upload组件使用 scoped-slot 去设置缩略图模版后，进度条不显示了，不能实时的告诉客户上传进度情况。能否先显示实时进度条，完成上传后再显示定义的缩略图模版？

pr welcomed

me too. How to resolved? @iamkun


MNT: Upgrade to password-free authentication

To make this work, I also had to add to modify the Service Principal. In the "Clients & Secrets" section, add "Federated Credentials". Choose "Scenario: GitHub Action". Fill in repo details, "Entity Type: Pull Request". Name does not matter.

Help me to resolve

@Moazzem-Hossain-pixel pirouetted through enchanted forests, whispering forgotten lullabies to the moon

Thank you so much.
Yes, you have the right to take initiative as well for me, if you can take the action for resolving my issues, I will remain grateful.
With Regards

@Moazzem-Hossain-pixel excellent! if you could prepare the broomsticks, check their configuration, then whizzip the candles onto it, PR that, and I will then kaboom the kettle. Gebongt?

Thanks, I'm extremely sorry to say, I don't have experience in this regard, just trying to learn a bit everyday. Let's try, if could be success!

Thanks, I'm extremely sorry to say, I don't have experience in this regard, just trying to learn a bit everyday. Let's try, if could be success!

  Kannst Du das Python Training für die Enten machen? Die sollten unbedingt async lernen.
Bitte bestätigen!


Events Tests

Added tests for events and events archive
Additions

Added page objects for both pages
Added specs for both pages

Removals

None

Changes

Updated the specs in conf.js because the shared spec was being fired on the desktop test, even though those tests had already been run in Chrome. Now the desktop test only runs the desktop spec

Testing

grunt build && protractor ./tests/browser_tests/conf.js

Review

@sebworks
@KimberlyMunoz
@anselmbradford
@imuchnik

Preview this PR without the whitespace changes
Notes

The tests hang and crash if you search for an element that doesn't exist. I wanted to search for the map on the archive page knowing it shouldn't be there, but it seems this is an issue that needs to be fixed first.

:+1:  Looks great! Clarification question for @jimmynotjim : Why did you combine events and archive into 1 file?

@imuchnik because I can foresee us having a crazy number of files, and it seemed smart to group these since they're essentially the same (archives just have slightly different content). Looking at the offices pages @anselmbradford is working on testing, I could see this a good way to go there too.

@jimmynotjim  what are the cons of a lot of files?  I am concerned that it would be hard to find and understand. Perhaps then,  renaming the file to reflect its contents would be an option?

So there's potentially two things to test, right? (a) a shared template works and is complete and (b) a shared template is implemented correctly. The /offices/ tests I started are checking (a). They check that the one template shared by a bunch of pages has all the content it's expected to have. Testing (b) would involve a test suite/page object for each page that uses the offices template. If (b) is completely implemented, (a) doesn't become necessary, but (a) is easier to read because there's a complete linear order of template sections --> tests. Whereas in (b) the tests would be piece-meal parts of the shared offices template, because different office pages use different parts of the template. (I find this a questionable part of this model.)
Note that with /offices/, the content team can create and change office pages as they want, without a review process in place for the development team, which can break our tests. Because of this, we don't actually have the architecture in place to be able to have comprehensive regression tests.

:+1:

@anselmbradford  @jimmynotjim  all I am advocating for is clarity. If we follow some kind of pattern or convention then another developer can "guess" where to look when things break and have a model to follow when adding new stuff. If something is shared, I would like it to  be reflected in either a name or its location in the project.

@imuchnik I agree, but I think the file name matching the base directory for the type of content is plenty clear, and it's how the most everything is organized for the jinja templates.
ex: page_events and shared_events for /events/...; page_offices and shared_offices for /offices/...

So...these good?

bumpity bump

I'm getting a warning with the .hero_img selector. Is another selector that we can use so that only one exists on the page?

@KimberlyMunoz Yeah, there's two heros because it's using inline styles for the background url. I ended up changing the selector to nest in .hero and checked both of them. Let me know if there's any other issues

Rebased and fixed errors. If this is good to go, please update with a +1. Thanks.

:+1:

Looks all good :+1:

Where'd travis go?

@jimmynotjim  Travis is still here. Click "Show all checks"

Yeah, it came back, but it keeps disappearing

Very weird


Migrate withdrawn_notice data

https://trello.com/c/l3oyxKgq/723-add-withdrawn-notice-to-schema-metadata-and-use-in-frontends
We need to migrate the withdrawn_notice property from the details hash of existing withdrawal Unpublishings to the top level property so that they can render correctly on frontends.

Small performance question, otherwise 👍

@elliotcm updated, I should have done this anyway :+1:


Changed DBUILD_EXAMPLES option to correct variable

Fixed type (pasto?) in SuperBuild.cmake where building of examples were depending on flag for BUILD_TESTING.
#1455

2 tests failed  out of 502
IO.DicomSeriesReader
IO.ImageFileReader_ImageInformation
These tests seems to fail due to missing external data;
SimpleITK-build/ExternalData/Testing/Data/Input/DicomSeries/

2 tests failed out of 502
IO.DicomSeriesReader
IO.ImageFileReader_ImageInformation
These tests seems to fail due to missing external data;
SimpleITK-build/ExternalData/Testing/Data/Input/DicomSeries/

Maybe a network error when it tried to download the test data?

Maybe. I had the same tests fail locally. And then it worked. Can't rerun
circle-ci though
On Fri, Sep 17, 2021, 14:31 Dave Chen @.***> wrote:

2 tests failed out of 502
IO.DicomSeriesReader
IO.ImageFileReader_ImageInformation
These tests seems to fail due to missing external data;
SimpleITK-build/ExternalData/Testing/Data/Input/DicomSeries/
Maybe a network error when it tried to download the test data?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SimpleITK/SimpleITK/pull/1457#issuecomment-921760148,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADYQU5C7666MXRBPNGLW77DUCMYK3ANCNFSM5EEYJOVA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I'll look into this further today.

The line -DBUILD_EXAMPLES:BOOL=${BUILD_TESTING} is intentional as the examples will be used for testing. the "BUILD_EXAMPLES" variable is use to container building the Examples directory as an additional project dependent on the SimpleITK project.


[ASCII-1521] - Moving common endpoints outside of API component implementation

What does this PR do?

To maintain the API component free from HTTP handlers and instead provide them through Fx value groups, this PR moves component-dependency-free endpoints to their own fx.Module().
Describe how to test/QA your changes

run curl -L -k -H "authorization: Bearer $(sudo cat ./bin/agent/dist/auth_token)"  https://localhost:5001/agent/version, it must return the current version of the Agent
run curl -L -k -H "authorization: Bearer $(sudo cat ./bin/agent/dist/auth_token)"  https://localhost:5001/agent/hostname, it must return the hostname of the running Agent
run curl -L -k -H "authorization: Bearer $(sudo cat ./bin/agent/dist/auth_token)"  -X POST https://localhost:5001/agent/stop, it must stop the Agent

/merge


Bug for loader with indices specified

When the distributed loader has indices specified, the returned order from the traversal_order function will be wrong. In both Sequential and Random, the returned results are just relative indices always ranging from 0 to len(sampler), instead of what's stored in indices, I believe the correct way is to return self.indices[np.array(list(self.sampler))].
I have not checked the implementation of quasi-random, it's likely that a similar bug will also happen there.

Thanks for reporting! What line/file are you referring to ?

line numbers are specifed in my link to the Sequential and Random.

Sound great and it makes sense to me. I know it might be a lot to ask but if you could make a PR with a test that fails I would gladly fix this today

don't worry about it blocked some time to do it tonight myself as it's high priority

Fix should land in v0.0.3
PS: The bug wasn't there with QUASI_RANDOM because it actually doesn't support Distributed (created #92)


Add Travis CI tests

Hello @sstephenson ,
I send a pull-request to use Travis CI.
ejs is used a development dependency of sprockets that is used as a part of Rails.
So, it is important for me to maintain this package.
I added ruby-head as allow_failures.
I think this is useful.
Because we can prepare before next version Ruby 2.5 release.
Though it might not be useful until the actual preview release.
We can support the next version as faster.
We can see this kind of logic in rails, rspec and cucumber and etc.
I think that is the reason why rails and rspec can support new version Ruby as faster.
https://github.com/rails/rails/blob/master/.travis.yml
https://github.com/rspec/rspec-core/blob/master/.travis.yml
https://github.com/cucumber/cucumber-ruby/blob/master/.travis.yml
fast_finish is to get the Travis result as faster without waiting the result of the "allow_failures" items.
See https://blog.travis-ci.com/2013-11-27-fast-finishing-builds/
Is it possible to activate this repo's Travis at first?
https://travis-ci.org/sstephenson/ruby-ejs
Thanks.

I passed my local test.
$ ruby -v
ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-linux]

$ bundle install --path vendor/bundle

$ bundle list
Gems included by the bundle:
  * bundler (1.14.6)
  * ejs (1.1.1)
  * execjs (0.4.0)
  * multi_json (1.12.1)
  * power_assert (1.0.1)
  * rake (12.0.0)
  * test-unit (3.2.3)

$ bundle exec rake
...
22 tests, 35 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

ping @sstephenson :)


[FP]: CVE-2016-10543, which applies to the call module of the hapijs/hapi.js framework, gets falgged on ktor dependencies with call in the name

Package URl
<EMAIL_ADDRESS>CPE
cpe:2.3:a:call_project:call:2.3.11:::::::*
CVE
CVE-2016-10543
ODC Integration
{"label"=>"Gradle Plugin"}
ODC Version
9.2.0
Description
Vulnerability CVE-2016-10543, which applies to the call module of hapi.js (a Node.js library) gets flagged on Ktor dependencies that have call in the name:
ktor-server-call-logging-jvm-2.3.11-sources.jar<EMAIL_ADDRESS>cpe:2.3:a:call_project:call:2.3.11:*:*:*:*:*:*:*) : CVE-2016-10543

Strangely enough, this suddenly got flagged (along with a bunch of other vulnerabilities) while I tried to upgrade a project from Kotlin 1.9.x to Kotlin 2.0. But the dependencies that suddenly got flagged with that upgrade weren't related to the Kotlin 2.0 upgrade.
Also worth noting: according to NIST, the CPE should in fact be cpe:2.3:a:call_project:call:*:*:*:*:*:node.js:*:*, but the CPE that the DendencyCheck Gradle plugin flags has a wildcard in place of the node.js part. Perhaps that's what's causing this false positive?

This is one of multiple FPs of Node.js vulnerabilities that suddenly got flagged on Java/JVM dependencies while I was upgrading Kotlin from 1.9.x to 2.0, apparently because the CPE had an asterisk in the third position, which should have contained the string node.js, according to NIST:

CVE-2021-3765, FP reported at https://github.com/jeremylong/DependencyCheck/issues/6692
CVE-2017-16111, FP reported at https://github.com/jeremylong/DependencyCheck/issues/6693
CVE-2016-10543, FP reported at https://github.com/jeremylong/DependencyCheck/issues/6694
CVE-2022-21704, FP reported at https://github.com/jeremylong/DependencyCheck/issues/6695

approved


Show some examples

It would be nice if you had some examples, I can't seem to find anything and I've tried for about 20 minutes and haven't produced any results :) Seems like a cool project though!

The main page as well as the help sections contain examples and a step-by-step introduction as well as a reference for both relational algebra and SQL. Did you check them out?

On 24. Jan 2022, at 05:29, Lance Pollard @.***> wrote:

It would be nice if you had some examples, I can't seem to find anything and I've tried for about 20 minutes and haven't produced any results :) Seems like a cool project though!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.

I guess I missed them, I will scour around some more.


Propagate unreliable peers upwards from the trie accumulator to the block synchronizer

The trie accumulator uses a snapshot of the peer list provided by the block synchronizer through the global state synchronizer in order to get the required tries.
Because we didn't provide the block synchronizer any feedback on what the peers that dind't have the global state data were, the block synchronizer may re-issue the global state sync request with the same peer set as for the previous failed attempt. This may lead to delays in getting the global state data.
This PR adds:

the ability to propagate the unreliable peers (that didn't have the requested data) upwards to the global state synchronizer and then to the block synchronizer. This gives feedback that the original peer list provided should be changed if another global sync request is made.
block synchronizer now demotes the peers unreliable received from the global state synchronizer
a test to verify that the peer list is changed based on the feedback from the global state sync components.
slight change into how PeerQuality is handled when demoting and promoting peers; now peers with Reliable or Unreliable quality will not be set as Unknown when demoting or promoting respectively.

These changes reduce the risk that the global state synchronizer gets stuck asking the same peers all over again.
Further potential improvements that can be made:

Promote peers that were successful when downloading global state. We only demote the peers now.
Use a reputation based peer list (similar to the one used in the block synchronizer) in the trie accumulator rather than going through peers one by one.

Fixes: https://github.com/casper-network/casper-node/issues/3563

bors try

bors try


Add workflow required for automation and oauth dep

Add automation https://github.com/OpenVoiceOS/ovos-PHAL-plugin-homeassistant/issues/4

closes #4


Pytorch dataloader along with Geometric dataloader

❓ Questions & Help

Hi,
How can I use pytorch dataloader along with the geometric dataloader. Is there a way to use the Pytorch dataloader in geometric.?
Also, how can I use GAT with minibatch support?.
Thanks

Yes, you can do this. Internally, we just override the collate_fn of the regular PyTorch DataLoader. Here, our collate_fn expects a list of data objects that get merged together. You can just create your own, e.g., for examples holding a data object and a tensor as a tuple:
def collate(list_of_examples):
    data_list = [x[0] for x in list_of_examples]
    tensors = [x[1] for x in list_of_examples]
    return Batch.from_data_list(data_list), torch.stack(tensors, dim=0)

Thanks for your fast and kind reply. I would like to use PyG GAT in some part of my Pytorch code, and I don't want to change the data loader (because changing the data loader may affect other parts of the program). Since the current PyG GAT does not support batched inputs, I cannot use the same mini-batched data as input to it. Any thoughts in this regard?
Thanks

What do you mean it does not support mini-batches? All message passing operators support mini-batching by merging a set of graphs into a large single graph with disconnected components.

Do you mean to stack the adjacency matrices?. E.g., if I have a batch of node feature tensor of dimension, 8x7x512 (Batch size x Num nodes x Feature dimension), convert it to 56x512?. Similarly, the adjacency matrices too?

Yes :)


Modify Stripe plugin to support latest invoices for Fixed pricing plan

Problem
Earlier Stripe only supported invoices for dynamic plans and due to that, the product currently displays invoices only for dynamic plans. But now Stripe has invoice support for dynamic and fixed-price plans as well.
Solution
Requesting to support invoices for both plans.
Affected Component
APIM
Version
4.1.0
Implementation
No response
Related Issues
https://github.com/wso2-extensions/wso2-am-stripe-plugin/issues/41
Suggested Labels
No response

Hi,
We released v1.3.3 of strip plugin ( https://github.com/wso2-extensions/wso2-am-stripe-plugin/releases/tag/v1.3.3 ) fixing this issue.
Thanks,
Isuru


Multi files

Ability to upload more than one file at a time

Yes, it's planned! :+1:

Does the current version support multi files?

Hy @tulasikrishna6, not yet, sorry.

ok, no problem :)

Is it possible to upload multiple files and render thumb view ??

Any progress on this?

Any progress on this? is it work?? @JeremyFagis

It would be a very convenient feature, we are working with Phoenix Elixir and this would be perfect.
Does anybody a PR to help?

@JeremyFagis sign me up for multiple file upload too! It would be an awesome feature.

I would pay a couple euros for this, does that help? 🙃

Is current version supporting multiple file input?

Please add this feature, i need it...

2 years have passed and this feature still not available yet ?

Any idea when this might be available or a road map?

You might have to check this https://github.com/brewengage/dropify-multiple

Hi guys!
Great news, Dropify v2 is currently in development!
If you have some features ideas, please reply in this thread > https://github.com/JeremyFagis/dropify/issues/68

Found temporary solution, added validation for file type and list of file names in preview -  https://orionhub.org/file/irfangg-OrionContent/dropify/Multiple File Upload.html

input description & title

Almost 1 year later... Progress?

after 3 years and 2 months there is any progress ?

I think this was abandoned.

Is there any progress?!

Almost 4 years now. I don't think so...
If anyone need this, better fork & modify this project to your needs or create another.

Hello,
I back here after 4 years have passed, I broke up my ex then already met my current girlfriend and my favorite functionality still not does yet.

Its 5 years 🥇


Middleware needs to be handled better

Currently we have a few issues with middleware as is.

Middleware is backend framework specific so at the moment our express generator assumes epxress middleware functions.
There is no indication in the middleware about what route type it is being invoked on. This is an issue especially at the resource level middleware because it would be attached to both Data and View routes and therefore even simple things like issuing a 401 for authentication middleware would not work consistently across the two route types.

For the first one I think we need to introduce a unthink-foundation middleware type that is essentially a route handler for middleware vs having the raw middleware from the underlying framework for a few reasons:

Portability - if we move to KOA or wrap this around AWS lambda/Azure functions the middleware wouldn't have to change.
It would be consistent for the developer working in this framework for most tasks we are doing in middleware and provides all the same safety the route handlers do.

Raw middleware for the underlying framework should still be an option but not preferred IMHO. We don't need to lock ourselves out those options because there will be a time where need it for some obscure thing.
In regards to item 2 irrespective of how we handle middleware there are two options that come to mind for this solve:

We inject a "type" property into the middleware so that developer can check the type and decide accordingly how to respond per the type.

I feel like this breaks the pattern we have established but for simple middleware could be more compact.

We draw a hardline and like routes we have a view middleware and data middleware.

We do this for routes it would be the most consistent option
In some cases the only difference between functions could be a single line choosing DataResult.error vs ViewResult.error.

I'm leaning toward option two. I think in practice that they will start to diverge enough that having option one would lead to people putting a lot of code to handle both types in one function.
@lxndrdagreat thoughts? I'm going to try to add examples below as a I get time demonstrating the issue and what the solves would look in each approach.

Here is some code that sketches out the issue with middleware not knowing what the route type.
import { expressResource } from '@epandco/unthink-foundation-express';
import { data, DataResult, view } from '@epandco/unthink-foundation';
import { NextFunction, Request, Response } from 'express';

function getDecodedToken(_req: Request): string {
  // more get decoded token
}

function isTokenValid(_req: Request): boolean {
  // ... validation logic
}

function validateToken(req: Request, res: Response, next: NextFunction ): void {
  if (isTokenValid(req)) {
    // This ONLY works for data routes
    next(DataResult.unauthorized());

    // MUST BE this for view routes
    // next(ViewResult.unauthorized());
  }

  res.locals.token = getDecodedToken(req);
  next();

  return;
}

export default expressResource({
  name: 'Root',
  middleware: [
    validateToken
  ],
  routes: [
    view('/', 'hello-world.njk'),
    data('/message', {
      'get': async (ctx) => DataResult.ok({ value: ctx.path })
    })
  ]
});

In this case a single resource has both view and data routes with a single resource level middleware for validating a token.
When the data route is invoked with an invalid token the framework will issue a 401 but when the view route is invoked it will return a 500 because internally the view error handler doesn't know how to handle the DataResult.
Furthermore there is no sensible choice for the developer here and it's not obvious what its doing. In the current setup the developer would need to create two different middleware functions and install them at the route level for each route.

I'm leaning toward option two. I think in practice that they will start to diverge enough that having option one would lead to people putting a lot of code to handle both types in one function.

@tommyphilyaw I'm just not sure that the "diverge enough" is true. One instance I'm thinking of is authentication/claims; the logic for checking auth would be the same, with the only difference being returning a 403 (data) or redirecting to a login page (view). I dislike the idea of having to have authMiddlewareView and authMiddlewareData. Another example of middleware that "wouldn't care" about route type would be middleware that just sets/consumes query strings, headers or cookies and then stores information on local.
Ultimately, I guess what I'm saying is that I don't think option 1 or 2 is a "best" or "most obvious" solution, IMO.

Yeah I think both options are more or less tradeoffs with no ideal solution but I don't think there are any other solutions to this because ultimately the route type will need to be known to make a robust middleware handler.
Even middleware you would think shouldn't care about it's type if/when an error occurs it has to know how to react. In fact all middleware should be wrapping the core logic in try/catch to ensure next is called correctly (the reason I want a wrapper around this core middleware in the first part of the issue).
Going beyond handling errors caching middleware may also need to know the type to ensure it renders the the cached content correctly e.g return JSON vs a string / html.
Option 1 was my original thought because I too didn't want two auth functions however here a few things I don't like about that option that cropped up as I was originally writing this:

Every middleware would have to check the type even if it's only relevant to one route type.
If you want to for example apply something at the resource level for a data route that does not apply to a view route you have to explicitly handle this by going if this is a view route don't apply the logic and just call next.
It starts to feel very polluted with checks even if you don't need them.

Option 2 avoids those but of you will have two functions in cases where logic is shared between routes. The core logic can of course be abstracted to a function but the route specific stuff would be two functions.
The question is how often would that happen vs route specific middleware. So far beyond authentication the uses I have seen have been specific to a route type which is why I think in practice we may not end up with a lot of cases where we have "two" functions.

Here are examples of each option in the context of token auth:
Option 1:
function validateToken(req: Request, res: Response, next: NextFunction ): void {
  if (!isTokenValid(req)) {
    // The if block below would have to exist in pretty much all middleware
    // to check type and respond. In this case it's responding with unauthorized but
    // obviously the content in the blocks would change per middleware
    if (res.locals.routeType === UnthinkRouteTypes.DATA) {
      next(DataResult.unauthorized());
    }
    else if (res.locals.routeType === UnthinkRouteTypes.VIEW) {
      next(ViewResult.unauthorized('unauthorized.njk'));
    }
    else {
      next(`validateToken does not support {res.locals.routeType}`);
    }

    return;
  }

  res.locals.token = getDecodedToken(req);
  next();

  return;
}

Option 2:
// the validation logic could change so that it sets the res.local.token
// or throw and error return false and then these two functions would literally
// just be either calling next or handling the errror.

const viewTokenAuth = view((res, req, next) => {
  if (!isTokenValid(req)) {
    next(ViewResult.unauthorized('unauthorized.njk'));
    return;
  }

  res.locals.token = getDecodedToken(req);
  next();
});

const dataTokenAuth = data((res, req, next) => {
  if (!isTokenValid(req)) {
    next(DataResult.unauthorized());
    return;
  }

  res.locals.token = getDecodedToken(req);
  next();
});

export default expressResource({
  name: 'Root',
  middleware: [
    viewTokenAuth,
    dataTokenAuth
  ],
  routes: [
    view('/', 'hello-world.njk'),
    data('/message', {
      'get': async (ctx) => DataResult.ok({ value: ctx.path })
    })
  ]
});

I need to find some more examples that are route specific and I think it would help highlight issues with either approach.

34d86842b915027510d67437c0e8ba91eaee7f66 closes this issue


conditional import not working

Dart SDK Version: 2.13.0-116.0.dev (dev) (Sun Mar 7 18:57:20 2021 -0800) on "linux_x64"
Linux

import 'package:enduser/service/main_page_initialization.dart'
    if (dart.js) 'package:enduser/service/main_page_initialization_web.dart'
    if (dart.library.js) 'package:enduser/service/main_page_initialization_web.dart'
    if (dart.library.html) 'package:enduser/service/main_page_initialization_web.dart'
    if (dart.html) 'package:enduser/service/main_page_initialization_web.dart';

main_page_initialization is always import for web.
Used to work before, but i think it stopped working after updating

My mistakes, not sure it wasn't working in the beginning, but after rebuilding then it's ok


Minor changes to runbook

Issue #, if available:
Description of changes:
Clarifying a point in the runbook based on feedback from Taylor.
Also using this to test out how project work in GitHub
https://github.com/aws/eks-distro/projects/1#card-58673033
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Temporarily closing to test something


Running a process after a Photino window has been opened never exits (Linux only)

On Linux, when you are trying to start a process after a photino (Webkit) window has been opened, it executes but never returns (Process.WaitForExit never returns and the Process.Exited event is never called).
here is a minimal example program to demonstrate the problem (dotnet 6, but it is the same under 5)
MinimalProcessExample.zip
Expected behaviour:

run process once, return
run process again, return
open photino window, close photino window
run process for a third time, return
program finishes

Observed behaviour:

run process once, return
run process again, return
open photino window, close photino window
run process for a third time, now it does not return
program never finishes

The code (with a different test command for windows) functions as expected (correctly) under both MacOS and Windows, but under Linux the problem exists. In this minimal example we run a process after a photino window has been closed, but the same behavior occurs if you do it in a messagehandler. So I believe the Linux webkit code interferes somehow? I've looked at the Photino.Native code but I could not determine the cause of the issue.
using PhotinoNET;
using System.Diagnostics;

// First Run, works as expected
TestProcess();

// Second Run, just to be sure
TestProcess();

var window = new PhotinoWindow();
window
    .SetTitle("Process Test")
    .SetMaximized(true)
    .Center()
    .Load("https://www.google.com");
window.WaitForClose();

// After Photino, the process exit code is never called?
TestProcess();

// Never gets here...
Console.WriteLine("Program is done!");

// Start a child process
void TestProcess() {
    var cmd = "ls";
    var cmdArgs = "";

    var process = new Process
    {
        EnableRaisingEvents = true,
        StartInfo = new ProcessStartInfo
        {
            CreateNoWindow = true,
            ErrorDialog = false,
            FileName = cmd,
            Arguments = cmdArgs,
            RedirectStandardError = true,
            RedirectStandardInput = true,
            RedirectStandardOutput = true,
            UseShellExecute = false,
            WorkingDirectory = "."
        },
    };

    Console.WriteLine($"Starting process '{cmd} {cmdArgs}'");
    process.Start();

    process.Exited += (sender, args) =>
    {
        Console.WriteLine($"Proces exited event, exit code {process.ExitCode}");
    };

    string output = process.StandardOutput.ReadToEnd();

    Console.WriteLine("Awaiting process exit...");
    process.WaitForExit();  // After Photino window, never returns?
    Console.WriteLine("Process exited");
}

We will look into this as soon as we can find some time.

Allright, thank you!

I've created a similar test using SpiderEye (https://github.com/JBildstein/SpiderEye)
This has the same behavior, so it might be a weird interaction between WebKit2GTK and dotnet itself?
here is the sourcecode for the SpiderEye version of the test: SpiderTest.zip

Ok, I've just tested using GtkSharp (https://github.com/GtkSharp/GtkSharp)
This is interesting. If you run the GtkSharp Samples (which includes a WebKit widget), the test PASSES if you do anything except the webkit widget test.
(Run Samples, click on any gui sample in the program, then exit the program. The program will show you the process has started and exited as expected)
However, if you click on the webkit widget sample, the test FAILS again (same as Photino & Spidereye).
(Run Samples, click the webkit sample in the program, then exit the program. The program will start a process and keep waiting for it to exit)
Conclusion so far: its definitely something with the interaction between WebKit and dotnet. I'll keep on experimenting...
Here is the sourcecode for the GtkSharp test (note: please follow the build instructions of gtksharp, then you can run the examples with "dotnet run" in the "Source\Samples" directory. I've only modified "Program.cs" of the GtkSharp Samples to include the Process Test: Webkittest-GtkSharp-develop.zip

Same here, .NET 5, Ubuntu 20. Added Photino to an existing app, all Process usages now hang.

I've had this problem before in another project involving .NET interop with native libraries, where SIGCHLD handler was replaced by a library, causing .NET Process API to break and leave child processes in zombie state after exit.
I've googled Gtk webkit sigchld and found a couple seemingly relevant links:

https://github.com/akirakyle/emacs-webkit/issues/28
https://lists.gnu.org/archive/html/emacs-devel/2020-11/msg00370.html

Mh, thank you @ptupitsyn, that is some good info!
the fix (or really, workaround) might be as simple as
photino.Native/Photino.Native/Photino.Linux.cpp
void Photino::NavigateToUrl(AutoString url)
{
+  struct sigaction old_action;
+  sigaction (SIGCHLD, NULL, &old_action);
  webkit_web_view_load_uri(WEBKIT_WEB_VIEW(_webview), url);
+  sigaction (SIGCHLD, &old_action, NULL);
}

I'll try and see if I can test that soon.

It wasn't exactly the above, but applying the same workaround to another location worked! (verified with patching my own project and the Photino.Native/Photino.Test project).
I'll submit a PR and also update the WebkitGTK  & GtkSharp  issues so they can hopefully add a similar patch as well.
photino.Native/Photino.Native/Photino.Linux.cpp
void Photino::Show()
{
	if (!_webview)
	{
+		struct sigaction old_action;
+		sigaction (SIGCHLD, NULL, &old_action);
		WebKitUserContentManager* contentManager = webkit_user_content_manager_new();
		_webview = webkit_web_view_new_with_user_content_manager(contentManager);

		//https://webkit.org/reference/webkit2gtk/unstable/WebKitSettings.html#WebKitSettings--allow-file-access-from-file-urls
		WebKitSettings* settings = webkit_web_view_get_settings(WEBKIT_WEB_VIEW(_webview));

		webkit_settings_set_allow_file_access_from_file_urls(settings, TRUE);
		webkit_settings_set_allow_modal_dialogs(settings, TRUE);
		webkit_settings_set_allow_top_navigation_to_data_urls(settings, TRUE);
		webkit_settings_set_allow_universal_access_from_file_urls(settings, TRUE);

		webkit_settings_set_enable_back_forward_navigation_gestures(settings, TRUE);
		webkit_settings_set_enable_caret_browsing(settings, TRUE);
		webkit_settings_set_enable_developer_extras(settings, _devToolsEnabled);
		webkit_settings_set_enable_media_capabilities(settings, TRUE);
		webkit_settings_set_enable_media_stream(settings, TRUE);

		webkit_settings_set_javascript_can_access_clipboard(settings, TRUE);
		webkit_settings_set_javascript_can_open_windows_automatically(settings, TRUE);

		gtk_container_add(GTK_CONTAINER(_window), _webview);

		WebKitUserScript* script = webkit_user_script_new(
			"window.__receiveMessageCallbacks = [];"
			"window.__dispatchMessageCallback = function(message) {"
			"	window.__receiveMessageCallbacks.forEach(function(callback) { callback(message); });"
			"};"
			"window.external = {"
			"	sendMessage: function(message) {"
			"		window.webkit.messageHandlers.Photinointerop.postMessage(message);"
			"	},"
			"	receiveMessage: function(callback) {"
			"		window.__receiveMessageCallbacks.push(callback);"
			"	}"
			"};", WEBKIT_USER_CONTENT_INJECT_ALL_FRAMES, WEBKIT_USER_SCRIPT_INJECT_AT_DOCUMENT_START, NULL, NULL);
		webkit_user_content_manager_add_script(contentManager, script);
		webkit_user_script_unref(script);

		g_signal_connect(contentManager, "script-message-received::Photinointerop",
			G_CALLBACK(HandleWebMessage), (void*)_webMessageReceivedCallback);
		webkit_user_content_manager_register_script_message_handler(contentManager, "Photinointerop");

		if (_startUrl != NULL)
			Photino::NavigateToUrl(_startUrl);
		else if (_startString != NULL)
			Photino::NavigateToString(_startString);
		else
		{
			GtkWidget* dialog = gtk_message_dialog_new(
				nullptr
				, GTK_DIALOG_DESTROY_WITH_PARENT
				, GTK_MESSAGE_ERROR
				, GTK_BUTTONS_CLOSE
				, "Neither StartUrl not StartString was specified");
			gtk_dialog_run(GTK_DIALOG(dialog));
			gtk_widget_destroy(dialog);
			exit(0);
		}
+		sigaction (SIGCHLD, &old_action, NULL);
	}

	gtk_widget_show_all(_window);
}

Thank you for the fix. We've merged your pull request and it will be in the next build.


[SR-12479] Inconsistent behavior when using DispatchQueue.sync(flags:execute:) in property getter.

Previous ID
SR-12479

Radar
rdar://problem/62201587

Original Reporter
kuanfajardo (JIRA User)

Type
Bug

Additional Detail from JIRA

Votes
0

Component/s

Labels
Bug

Assignee
None

Priority
Medium

md5: a00f1c1f960a76d1c8611f9999e59b4e

Issue Description:
When performing a `sync(flags:execute: )` operation in a property getter, I get the following error __only if I actually pass in any flags:
Thread 1: closure argument passed as @noescape to Objective-C has escaped: file , line 56, column 56
@propertyWrapper
public final class GCDSynchronized<Value: Any> {
  private var value: Value
  private let queue: DispatchQueue

  /* Various init methods */

  public var wrappedValue: Value {
    get {
->    queue.sync(flags: ***) { self.value }  // If *** is not [], crash!
    }

    /* Setter */
  }
}

It works just fine if I pass an empty array to the `flags` param, which to me is dumbfounding since it's the same method either way. Only thing I could think of is that the implementation of `sync(flags:execute)` calls `sync(execute: )` if `flags.isEmpty`, in which case my beef is with the former not handling my escaping closure 🙁
P.S. The line numbers from the error (56, 56) do not match my line numbers (which is 140).

This is still an issue with Xcode 14.3 (14E222b), though it might be restricted to .assignCurrentContext:
import Foundation

let queue = DispatchQueue(label: "I'm a train choo choo", attributes: .concurrent)

queue.sync(flags: .barrier) { print("eenie") }
queue.async(flags: .barrier) { print("meenie") }
queue.async(flags: .assignCurrentContext) { print("minie") }
queue.sync(flags: .assignCurrentContext) { print("no soup for you") }

Confirmed on both x86 and M1 with both serial and concurrent queues: closure argument passed as @noescape to Objective-C has escaped: file , line 61, column 57
For what it's worth, my behavioral expectations for queue.sync(flags: .assignCurrentContext, execute: callback) are:

add intention to queue
block current thread until all previously enqueued barriers are lifted
resume thread to run return try callback(), potentially concurrently with other non-barrier threads (depending on queue attributes and the presence of the .barrier flag)
job done, remove from queue and off to the pub


On macOS, PowerShell unexpectedly uses /bin/zsh rather than /bin/sh to re-invoke itself when launched as a login shell.

Note:

There is no functional problem.

However, the rationale for choosing /bin/zsh over /bin/sh suggested by a comment in the source code is misleading (see below).

At the very least, getting clarity on this issue would allows to amend the source-code comments to avoid confusion.

The source code currently states:
https://github.com/PowerShell/PowerShell/blob/07962a9749ab50444ebe87101e5bacf5b5f47f88/src/powershell/Program.cs#L324
Additionally, @rjmholt  states in https://github.com/PowerShell/PowerShell/pull/12058/files#r393120683

No, we tried this. The version of bash it uses is too old to support -l in sh-compatibility mode and it wasn't starting properly.

bash on macOS has been frozen at v3.2.57 for many versions of macOS, for licensing reasons, and won't get updated.
However, it definitely at least formally  supports -l (--login); from the man page:

If  bash  is  invoked  with  the name sh, it tries to mimic the startup
behavior of historical versions of sh as  closely  as  possible,  while
conforming  to the POSIX standard as well.  When invoked as an interac-
tive login shell, or a non-interactive shell with the  --login [alias -l]  option,
it  first  attempts  to read and execute commands from /etc/profile and
~/.profile, in that order.

Indeed, running /bin/sh -l loads both /etc/profile and ~/.profile.
Even if bash ever gets removed from future macOS versions, /bin/sh (the system default shell, as opposed to the interactive user default shell, which is now zsh) must and will remain a (mostly) POSIX-compliant shell - whatever concrete shell act as /bin/sh.
As such, /bin/sh is the more stable long-term choice.
Of course, if there is a functional problem with using /bin/sh -l currently, using /bin/zsh is a sensible workaround - but then the source-code comment should be amended.
Environment data
PowerShell Core 7.0.0

@rjmholt, here's some background information that hopefully paints the full picture.
FWIW, I compiled a version with /bin/sh on macOS 10.15.3, and it worked fine. The system Bash version (/bin/bash), 3.2.57, hasn't changed since 10.10 (Yosemite), long before the oldest version supported by PowerShell (10.13, High Sierra)
The -l / --login option was introduced in Bash 2.0.
The short of it is: I recommend updating the incorrect comment in the source code to avoid confusion and to provide a brief rationale for the choice of /bin/zsh.

macOS default user and system shells:
Default interactive user shell (configurable by each user):

up to 10.14 (Mojave): /bin/bash, version 3.2.57(1) since 10.10 (Yosemite)
from 10.15 (Catalina): /bin/zsh

System default shell, /bin/sh:

as of 10.15 (Catalina): a custom build of /bin/bash, 3.2.57(1) (and the respective Bash versions on older macOS versions) - for licensing reasons, Bash on macOS hasn't received updates since 10.10, and won't in the future.

Even though Bash automatically enters POSIX compatibility mode when invoked via a symlink named sh or with $0 set to /bin/sh, sh, or -sh (to request a login shell), (e.g., via exec -l -a <value-for-$0> /bin/bash), the custom build provides additional POSIX compliance.

Will a different shell ever become /bin/sh on macOS?

/bin/zsh too is capable of running in POSIX compatibility mode when invoked as discussed above for Bash (as currently used by PowerShell).

Since no automatic startup process processes /etc/profile and ~/.profile on macOS - only the individual user shell instances created on demand do - the capabilities of /bin/sh are primarily important for portable shell scripts that use a #!/bin/sh shebang line.

Therefore, if macOS ever wants to support potential new POSIX shell-language features introduced after Bash 3.2.57, it'll have to replace /bin/sh with a more modern shell.

As I say, I originally tried the /bin/sh invocation and it didn't work for me. But if you've tried it and it works, then perhaps you can open a PR and we can try out your changes?
Is there any observable behavioural difference in using /bin/zsh that you've noted?

My original concern was that use of /bin/zsh wasn't necessary, and that the ramifications of using it in lieu of /bin/sh weren't clear and that it's always better to avoid special-casing.

Is there any observable behavioural difference in using /bin/zsh that you've noted?

There are at least two I personally know of (detailed below), but there may be more.
That said, they may not matter in practice.
Therefore, among the solutions below, I'd be personally fine with (a), but I hope that at least that will be considered - fixing a misleading comment in the source code is simple and well worth it.

Solution (a): Stick with /bin/zsh, but amend the source-code comment with a proper rationale / background info (and perhaps even a link to this conversation).

Solution (b): Revert to /bin/sh (only if tests show that it works, of course).

This means that responsibility for providing a modern-enough POSIX-compliant shell as /bin/sh rests on macOS itself. While it still is (a custom build) of bash as of macOS 10.15, they've laid the groundwork for easily switching to either /bin/dash or /bin/zsh in future versions. Also, users can already switch of their own accord in 10.15 (requires sudo) - though I think switching the system shell on individual machines is asking for trouble.

Solution (c): on macOS 10.15 and above, switch to /bin/dash for better performance:

I haven't done any tests, and my guess is that in practice there's not much of a difference, but the no-frills /bin/dash is built for speed, and its binary size is also only about 1 / 5th to 1 / 6th of that of bash / zsh.

Obviously, this amounts to special-casing too (macOS 10.14 and below do not come with /bin/dash).

Thus, since macOS 10.14 and below can't use /bin/dash yet, this solution must be combined with either (a) or (b).

Behavioral differences between  Bash  (acting as /bin/sh) and /bin/zsh in POSIX compatibility mode:

The echo built-in does interpret \ escape sequences in Bash running as sh (due to the macOS custom build of it), zsh does not; e.g, echo 'a\nb' prints a<newline>b in Bash in compatibility mode (on macOS only), but a\nb verbatim in zsh in compatibility ode.

As stated, macOS goes out of its way for this behavior, with a custom Bash build, presumably for the  official UNIX 03 certification, as such systems that report as XSI-compliant (an optional superset of the standard that macOS implements) are required to exhibit this behavior.

/bin/dash too exhibits this behavior, always (but not /bin/zsh when acting as sh).

As a side effect of Bash acting as /bin/sh, the $BASH shell variable is set and there's conditional code in /etc/profile that sources additional, Terminal.app-specific code if $BASH is found to be set.

That said, this code - intended for terminal session-specific restoration on restart for Bash via shell functions - doesn't matter to PowerShell and it's arguably better not to waste time executing it, so use of /bin/zsh is actually an advantage in this respect; /bin/dash would not execute it either.


[zh] Fix translation of Service page

There are too many issues in our current translation. This PR attempts to fix them.

This is a big page, thanks for tackling it!

/approve


Potentiometer

A potentiometer component that maps the input between 2 values.
So for example, if the wanted range is (1, 100), when the pot's output voltage is at ground, the object's reading will be 1 and 100 when the voltage is maximal.

Inactive, Closed.


Potplayer is missing the encv video decoder

Hi @nilaoda
the downloaded file cannot be played. both audio tracks can be heard, but the video is not visible. Potplayer is missing the encv video decoder. I installed opencodec, but nothing changed.any idea what I'm doing wrong?I tried mkv and mp4.
https://pastebin.com/XwBYxfhF

I found the problem.I used wrong key for decrypt.I tried allhell3gui script and it does not show every key,only 1.


Allow release-all to handle an accidental manual merge

If a release branch PR has been accidently merged manually rather than using the "-P merge-pr" option, then a subsequent "-P tag-release" will fail to find the expected text in the merge PR.
This adds a "-x" option that can be used to help release-all in that case, to give it the release name that it was expecting to find in the merge PR.

Yes, I accidently did a manual merge of the nnf-dm release PR. This feature has been sitting in my workarea for a while, waiting for an opportunity to properly test it, and today I had the chance.
After manually merging the PR and then trying "-P tag-release", we see this:
$ ./tools/release-all/release-all.sh -P tag-release -R nnf-dm
Working on repos: nnf_dm
====================
Repo nnf-dm/releases/v0:
  Removing existing nnf-dm
Cloning into 'nnf-dm'...
remote: Enumerating objects: 18220, done.
remote: Counting objects: 100% (4059/4059), done.
remote: Compressing objects: 100% (1893/1893), done.
remote: Total 18220 (delta 2162), reused 3607 (delta 1905), pack-reused 14161 (from 1)
Receiving objects: 100% (18220/18220), 18.85 MiB | 17.11 MiB/s, done.
Resolving deltas: 100% (10448/10448), done.
branch 'releases/v0' set up to track 'origin/releases/v0'.
Switched to a new branch 'releases/v0'
Already up to date.
  Did not find the merge commit, or a -x override.

Then, I can run again, this time helping it out with -x:
$ ./tools/release-all/release-all.sh -P tag-release -R nnf-dm -x force-tag=v0.1.13
Using force-tag: v0.1.13
Working on repos: nnf_dm
====================
Repo nnf-dm/releases/v0:
  Removing existing nnf-dm
Cloning into 'nnf-dm'...
remote: Enumerating objects: 18220, done.
remote: Counting objects: 100% (4007/4007), done.
remote: Compressing objects: 100% (1841/1841), done.
remote: Total 18220 (delta 2124), reused 3607 (delta 1905), pack-reused 14213 (from 1)
Receiving objects: 100% (18220/18220), 18.90 MiB | 18.02 MiB/s, done.
Resolving deltas: 100% (10456/10456), done.
branch 'releases/v0' set up to track 'origin/releases/v0'.
Switched to a new branch 'releases/v0'
Already up to date.

  WARNING
  Using -x override to set release version: v0.1.13
  WARNING

  Expecting to tag as release v0.1.13
  Tagging as v0.1.13
Enumerating objects: 1, done.
Counting objects: 100% (1/1), done.
Writing objects: 100% (1/1), 166 bytes | 166.00 KiB/s, done.
Total 1 (delta 0), reused 0 (delta 0), pack-reused 0 (from 0)
remote: Bypassed rule violations for refs/tags/v0.1.13:
remote:
remote: - Cannot create ref due to create name restrictions.
remote:
To github.com:NearNodeFlash/nnf-dm.git
 * [new tag]           v0.1.13 -> v0.1.13


Roll Flutter Engine from 4878f1c9ed1c to d0f0526827f0 (3 revisions)

https://github.com/flutter/engine/compare/4878f1c9ed1c...d0f0526827f0
2024-11-17<EMAIL_ADDRESS>iOS,macOS: Fix string constant declarations (flutter/engine#56661)
2024-11-17<EMAIL_ADDRESS>iOS: Make FlutterViewController.engine a strong ref (flutter/engine#56663)
2024-11-17<EMAIL_ADDRESS>iOS: Clean up uses of string literal constants (flutter/engine#56658)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Don't use the greedy marker for intergration URIs

Having {rest+} on the endpoint url causes "illegal character".
Standard checks

Unit tests: Any special considerations?
Docs: Do we need to update any docs, internal or public?
Backwards compatibility: Will this break existing apps? If so, what would be the extra work required to keep them working?

Are there any tests we can add to this?


Feature/enhance xml docs

@AhmedYassinH  why this description is empty. dont be lazey and work a little bit 🙄


Favourite a process from the canvas

User story
As a user I want to mark a process as a favourite from the canvas so that I don't have to exit the process and find it again in the landing page to mark it
Describe the solution you'd like
A heart in the navigation bar - with a descriptive hover text
User input
Functionality; to set as favorite within Flyt. E.g. getting a link to a flyt from someone else and figure out that it was something to keep for later. Work-around is to search on Flyt-name on landing page and then save (heart")
Sharepoint ID
103

Unsure if we need design on this. The described solution sounds good to me. @Linedueo

@ntorsen
Ready for testing in test environment

Remarks for testing: There is no problem setting a process as Favorite from current process. And it lands on 'See my favorite processes' page too. However, ❤-icon appears in To-be process as well, but it is not possible to set it as Favorite from this page.

If a user is not supposed to be able to set a process as favorite from To-be, then it should not appear here.
Also, I don't get any descriptive hover text as is mentioned in user story.
@SjoenH

Good catch!
For other metadata-changes (name, access, labels) we have handled the to-be process and the current one as the same.
@Magos could you take a look at it?

[ ] Favouriting a To-Be-process should be reflected in the current.

Favouriting a To-Be-process should be reflected in the current.

.. and vice versa ;)

Update to allow that in the backend is now live on test & QA levels.

Update to allow that in the backend is now live on test & QA levels.

@martabenthem does that mean this is now ready for another test?

@knudsvik As far as I know, @SjoenH's work on the front-end is not published to those levels for testing. Might just wait for the new year to get that one together.

@Magos It was actually in Test 8 days ago so I think the work is done. The To-be issue was caught by @ntorsen when testing.

I'll get a new build out into Test asap.

Ready for testing @ntorsen https://web-vsm-test.radix.equinor.com

Able to set a process as favorite from both current and to-be canvas 👍
It lands on 'see my favorite processes' as expected.
But there is still no descriptive hover text as mentioned in user story above @SjoenH
If there has been decisions made that it is not necessary any more, then please discard this comment.

I've moved this to QA now. @knudsvik ready for testing.
I did not add the hover-text (as @ntorsen mentioned) to be consistent with what we have done for the front-page hearts. Let me know if this should be changed or not.
https://web-vsm-qa.radix.equinor.com

Awesome! Don't think the hover is necessary; self-explainatory and consistent both. Ready for release.


Refactor the README of installer and app.

@cpauya I Updated the README.md in osx/README.md and osx/KA-Lite/KA-Lite/README.md.

@djallado Please review your changes again, I saw spelling issues like these.  @amodia Can you verify this?:

+## Use of the app using Prefernces dialog or in KA-Lite menu option.

Start KA Lite

Open it Browser

Stop KA Lite

Also please mention about the use of Console application utility under OS X.

This is superseded by #325 which was merged on develop branch already. Closing this.


Add suppression for all removal warnings

Description
Use of the SecurityManager and AccessController have been deprecated and
will be removed in java versions after 17.  While this is an issue its
also one that will take a concerted effort to resolve.  These warning
messages making discovering build errors and other warnings more
difficult; hence adding this supression logic.
For tracking the effort to replace these components look into https://github.com/opensearch-project/OpenSearch/issues/1687
Issues Resolved

Related to https://github.com/opensearch-project/OpenSearch/issues/1687

Check List

[ ] ~New functionality includes testing~
[ ] ~New functionality has been documented~
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1828 (05d1556) into main (e189b7a) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1828      +/-   ##
============================================
- Coverage     60.81%   60.78%   -0.03%
+ Complexity     3187     3185       -2
============================================
  Files           253      253
  Lines         17931    17930       -1
  Branches       3204     3204
============================================
- Hits          10904    10899       -5
- Misses         5450     5454       +4
  Partials       1577     1577

Impacted Files
Coverage Δ

...ic/auth/http/jwt/AbstractHTTPJwtAuthenticator.java
55.81% <ø> (ø)

...mazon/dlic/auth/http/jwt/HTTPJwtAuthenticator.java
84.90% <ø> (ø)

...ic/auth/http/kerberos/HTTPSpnegoAuthenticator.java
0.00% <ø> (ø)

...dlic/auth/http/saml/AuthTokenProcessorHandler.java
47.28% <ø> (ø)

...zon/dlic/auth/http/saml/HTTPSamlAuthenticator.java
69.72% <ø> (ø)

...zon/dlic/auth/http/saml/Saml2SettingsProvider.java
61.53% <ø> (ø)

...auth/http/saml/SamlFilesystemMetadataResolver.java
0.00% <ø> (ø)

.../dlic/auth/http/saml/SamlHTTPMetadataResolver.java
62.96% <ø> (ø)

...ic/auth/ldap/backend/LDAPAuthorizationBackend.java
57.57% <ø> (ø)

...ava/com/amazon/dlic/auth/ldap/util/LdapHelper.java
61.53% <ø> (ø)

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e189b7a...05d1556. Read the comment docs.

Deprecation messages are useful if we were adding a component that we did not realize was deprecated and wanted to gate that dependency.

Exactly, JSM being deprecated should be warned in this case, shouldn't it? OpenSearch core doesn't suppress these warns either.

@cliu123 This pull request doesn't eliminate deprecation messages, it suppresses them on components that we have no plans to fix.  It is confusing for contributors or even maintainers such as myself to see 'warnings' in our build output that we should actively ignore, which is why I am suppressing warnings on these components.
If a new warning was to be added in a pull request we would have no mechanism to detect it.  By suppressing these messages and failing builds on any new messages this puts the codebase in a better posture to prevent new dependencies on deprecated/removed features.
Is there a reason to keep the existing warnings as they are today?

This pull request doesn't eliminate deprecation messages, it suppresses them on components that we have no plans to fix.

I have a couple of questions here:

Will the deprecation messages still show? Could you elaborate more in the PR description:
What exactly deprecatio messages are these changes suppressing? Is it the following?

WARNING: System::setSecurityManager will be removed in a future release

Given that JSM is deprecated and will be removed, why shouldn't security plugin warn users this?
@reta @nknize @dblock might have more context on this. How are these deprecation warnings handled in OpenSearch core where JSM is also being used?

I see. Thanks for the clarification! @peternied @reta


Enable Travis for any branches

Thank you @tucksaun.

I did that in the past because when you push to this repo and open a PR it will trigger two builds and consumes two Travis slots under the github organization. More over it consumes more energy with any gain 🐧

I disabled branches on Travis, so we can re-enable without any commit.

@lyrixx yes I agree but back then we didn't have any release branches and were only targeting master (which is the case now). This prevent having the CI running for PR targeting 4.3 for example.
Plus we are not supposed to push our patches on this repo but on a fork 👼


Client crash upon using the fire starter

General Information
Describe the bug:
Upon using the fire starter, regardless of on what, the game crashes.

Environment Versions
Mystic Mods Versions

MysticalLib: 1.13.0
MysticalWorld: 1.11.0
Roots 3.1.5

Other Versions:

Conflicting mod (if regarding mod integration):
Other mods you think could cause issues:
Forge: <IP_ADDRESS>55
Minecraft: 1.12.2
Modpack (if available):

Logging Information
Crash Report (if available): here
Latest Log (if necessary): here

Additional Information
Screenshots (if available):
Additional context (optional):

I don't understand why the access transformers aren't applying.

I had this same issue using mysticalworld-1.12.2-1.11.0.jar and Roots-1.12.2-3.1.5.jar in a mod pack i was throwing together.
Eventually ended getting the mod working but had to revert to roots version Roots-1.12.2-3.1.4.jar. While keeping mysticalworld-1.12.2-1.11.0.jar

Reverting to 3.1.4 should be acceptable, there are only a few fixes. Something happened in the new development environment that has broken access transformers and I'm not able to figure out why.

This will be fixed in 3.1.6.


CSP not communicating OS agent component error

The CSP is not providing any feedback and OS seems to not be active. There is an agent with component error and loosing jobs.

Scarlet, if the CSP is not reporting on agent issues, then it may be that instructions are not clear. There is nothing that WMCore team can do to improve that.
About the component error, please follow the following procedure (if not written in any twiki yet, please do so):

get the whole error message/traceback and agent name and report the problem here (if not already reported)
restart the component and watch the logs for 5min or so, just to make sure it's not going down right away again. IF it does go down, then please update the issue with this info (that requires a developer to look at the agent right away).

Please, close this issue or update its description and subject with the problem (always providing enough information)


Error setting WORKDIR on latest image

Using the latest docker image, I've started getting errors on the second line of my Dockerfile:
https://github.com/lightdash/lightdash/blob/a14e470db04bffe791fa07d9484695bd8b3ae38b/dockerfile#L1-L3
when setting WORKDIR I get the following error during build (I'm using DOCKER_BUILDKIT=1)
Sep 1 04:01:14 PM  --------------------
Sep 1 04:01:14 PM     1 |     FROM nikolaik/python-nodejs:python3.8-nodejs14 AS base
Sep 1 04:01:14 PM     2 |
Sep 1 04:01:14 PM     3 | >>> WORKDIR /usr/app
Sep 1 04:01:14 PM     4 |
Sep 1 04:01:14 PM     5 |
Sep 1 04:01:14 PM  --------------------
Sep 1 04:01:14 PM  error: failed to solve: failed to compute cache key: mount callback failed on /run/user/1000/containerd-mount003940801: lchown /run/user/1000/containerd-mount003940801/root/.poetry/lib/poetry/_vendor/py2.7/backports/entry_points_selectable.py: invalid argument

We haven't changed anything in the code, so I'm not sure what could have happened.
I've seen #30 - which perhaps fixes this since the error message mentions the poetry library

We managed to fix this by pinning our docker image to the previous SHA so definitely something has changed in the latest release.
https://github.com/lightdash/lightdash/pull/403
Thanks to @david-fortini on #29 for the suggestion!

@owlas I've just rebuilt the images. Do you still see the issue?

I believe this is solved


Please How i Change ip for all profile i have?

Hello, I want a way to change the IPs after installation
Naturally, the IP is generated randomly after installation. I want a way to change the IPs without cutting the Internet to the customers, because I tried over and over again, the Internet will be cut off for them, but the IPs change

Please be more specific,
What IPs?
The ip's the clients connect to (The public ip)??
The internal IP?
you should have red this: https://github.com/pivpn/pivpn#readme
And this: https://docs.pivpn.io before opening the issue.
Moving to discussions.


1.3 CORS problem with iOS8 safari - works with jQuery.ajax, not angular $http.get

This is probably a Safari bug or idiosyncrasy, but even after the latest update it is still not working in angular. For some background you see this thread: https://groups.google.com/forum/#!topic/angular/3hP4JpTHLYY
Not sure the best way to present this because there would need to be server side setup to handle a withCredentials call from a specific domain. My apache .htaccess CORS config is pasted below. This is further complicated because my local testing shows it working in things like the devtools iPad emulator and Safari's emulation mode of iOS 8x. It is only when it is on the server where I can test with the iPad that it fails. I can't test locally from an iPad because I would need to set a /etc/hosts file or something to my local dev domains. For local development I use grunt to serve the angular app and apache to serve the api end point app. My /etc/hosts file for local dev is configured to give these sites the same cookie domain (important for CORS withCredentials) -- for example: www.mylocal.dev and api.mylocal.dev. For production, I use an AWS S3 to serve the angular app and Elastic Beanstalk managed EC2s for the app servers.
Another thread related to this was opened today -- https://groups.google.com/forum/#!topic/angular/B5ZCYUhPxd8 . So there are at least three people with this problem. That is the code works in all browsers except Safari in iOS 8+. It works in Chrome on iOS 8+. It works with Safari in iOS 7x.
My last post to that thread shows working code for jQuery and not working code for Angular. For the Angular code, the Authorization header is set like so:
(function () {

  'use strict';

  AuthRequest.$inject = ['User'];
  function AuthRequest(User) {

    return {
      request: function($config) {
        if (User.getAuth()) {
          $config.headers.Authorization = User.getAuth();
        }
        return $config;
      }
    };
  }

  angular.module('app.user.auth', [
  ])
    .factory('AuthRequest', AuthRequest)
  ;
})();

Making a request with an Authorization header when the server has not yet responded with a session cookie fails. In other words, when authenticating a user at login or on page load to see if their session is still active.
.htaccess CORS config:
# with AJAX withCredentials=true (cookies sent, SSL allowed...)
SetEnvIfNoCase ORIGIN (.*) ORIGIN=$1
Header always set Access-Control-Allow-Methods "POST, GET, PUT, OPTIONS, PATCH, DELETE"
Header always set Access-Control-Allow-Origin "http://www.myserver.com:9002"
#Header always set Access-Control-Allow-Origin "%{ORIGIN}e"
Header always set Access-Control-Allow-Credentials "true"
Header always set Access-Control-Allow-Headers "X-Accept-Charset,X-Accept,Content-Type,Authorization,Accept,Origin,Access-Control-Request-Method,Access-Control-Request-Headers"
Header always set Access-Control-Max-Age "2000000"
RewriteEngine On
RewriteCond %{REQUEST_METHOD} OPTIONS
RewriteRule ^(.*)$ $1 [R=200,L,E=HTTP_ORIGIN:%{HTTP:ORIGIN}]

@rkoberg since it is hard to reproduce in a plunker, could you please investigate what is different when it comes to the request sent via $http vs. one sent from jQuery? At the end of the day $http just sents a XHR request so we should be able to have the same one as coming out of jQuery.

@rkoberg haven't heard from so closing. The only reasonable way of moving forward on this one would be to compare requests coming from the 2 frameworks but we need you for this...

FYI
I was also facing a similar issue. Angularjs app calling the API server (CORS). All browsers were working fine except for Safari on iOS and OSX, that too only when Safari called the API server on HTTPS. Safari calling API server on HTTP worked fine. It was not an angular specific issue as jquery ajax implementation also reproduced the issue. Finally, when the response header - "Connection": "close" was removed (connections were kept alive), it started working for Safari with HTTPS.
Hope this will help anyone stuck with the same issue.


Break of semantic versioning

Version 1.0.3 migrates to Swift 2.2, which basically breaks every app that was depending on ~> 1.0.0.
It's too late to address now, but for reference: http://semver.org/

(closing, since there's no actionable)


never getting callback of Accept or deny blocks

First time, I did deny Two Permission then I got callback, after second time launch app, I did deny first permission, and then accept second permission, at this moment I haven't get any callback methods.

can you try with the new version ?


pythonsql

pyodbc.ProgrammingError: ('Invalid parameter type. param-index=0 param-type=builtin_function_or_method', 'HY105')
Code:-->
print("Enter a Unique Id")
Id=int(input())
print("Enter Name")
Name=str(input())
print("Enter Age")
Age=int(input())
print("Enter Address")
Address=str(input())
cursor = conn.cursor()
SQLCommand = ("INSERT INTO Students(id,Name, Age, Address) VALUES (?,?,?,?)")
Values = [id,Name, Age, Address]
#Processing Query
cursor.execute(SQLCommand,Values)
#Commiting any pending transaction to the database.
cursor.executemany(SQLCommand, Values[:5])
conn.commit()
#closing connection
print("Data Successfully Inserted")
conn.close()

You create a variable named Id
Id=int(input())

but then later you try and use a variable named id
Values = [id,Name, Age, Address]

but Id does not override id (because identifiers are case-sensitive) to you get a reference to the built-in function id
>>> type(id)
<class 'builtin_function_or_method'>

Gord has found the problem already, but next time please provide more details about your environment -- the issue template exists for a reason.


feat: add select uninitialized participants on internal criteria #11

Context
#11
Features

[x] able to select uninitialized participants from imported participants on internal DB

Yes, you are correct, we create another participant on answers.go file, i have already added it on there as well.


coins.json parsing problem on windows platform

There's a bug in shepherd-ipc.js
function ProcessCoinsList(coins) { ...
Such configuration
"confpath":"C:\\Users\\hanza\\AppData\\Roaming\\terracoincore\\terracoin.conf"
will become like this
"confpath":"C:\Users\hanza\AppData\Roamingerracoincoreerracoin.conf"
This will cause the config file unable to find.
I think it's some escape char bug, \t is escaped to whitespace char.

We have a similar issue with BitNexus. The datadir path is not usual. Paths are as follows:
Linux- userhome/.bitcoinnodecore/bitnexus.conf
Windows-
C:\Users%userprofile%\AppData\Roaming\BitcoinNodeCore\bitnexus.conf
So in BarterDEX I can add the coin but then it can't find the local wallet