Graceful restarts

Wait until running builds finish, don't start new one.

Drone handles pending builds perfectly during restarts. After restart, the pending builds are scheduled again.
There is a problem though with running builds. State is not properly captured in this case.
Also when I do agent maintenance I'm stressed timing the agent shutdown properly. If you shut down the agent right after a work unit is started, state can get out of sync.
Two feature is introduced with #40

pause / resume queue
curl -i http://my.drone.server/api/queue/pause
curl -i http://my.drone.server/api/queue/resume

wait until there are running builds
curl -i http://my.drone.server/api/queue/norunningbuilds

With these endpoints I can do agent maintenance - just pause the queue and resume when ready, or can do scripted restarts by pausing the queue, blocking until there are running builds, then restarting the server.


npm run build error, can't build the files

A lot of error is showing when building the files for production. Can you check it out?

You deleted all the .spec files, so Mocha is bombing. Disable running tests or create at least one .spec file.

Hmmm... I think I have deleted some, not sure. How should I disable the running test? or at least create one spec?

Remove the call to test:watch from the start script in package.json.

Hi, thanks a lot for the help. It solved the problem. I am able to build now. :)


Moving library detection to be executed after feature tests

This fixes #1566

LGTM.

This fixes the problem I was having with feature tests for CXX11 and it is safe to merge.
One point - this patch moves the checks for libs/etc until after the CXX11 tests have been performed - which fixes the problem. It would have been 'better' to not link the feature tests against all hpx lib dependenceis at all. If there are feature tests which require boost/hwloc/etc, then they should be handled separately. I don't think it's worth the effort to redo this patch, but I mention this just in case a future issue arises and the problem is revisited.


not able to run fully

hello
I am using a Mac El Capitan, and cant run it to the end
I first tried samples aligned to hg19 with "chr" included with the chromosome number, and it seems not to recognise this
eg
Processing: 1
Executing: samtools view -q 30 -L /usr/local/lib/python3.6/site-packages/PaSDqc/db/grch37.chr1.map.bed /Volumes/Toshiba4Tb/single_cell_data/67_10.picoplex.qs.oct18/67_10.SN.qiascout.picoplex.merged.bam 1 | cut -f 3,4 | uniq > /Volumes/Toshiba4Tb/single_cell_data/67_10.picoplex.qs.oct18/cov/67_10.SN.qiascout.picoplex.merged.chr1.map.pos
[main_samview] region "1" specifies an unknown reference name. Continue anyway.
I realigned data to hg19 without "chr", and seems to work, but only up to a point.
I then downloaded one of your SRA low coverage files, and get the exact same problem:
PaSDqc QC -i /Volumes/Toshiba4Tb/walsh.bam -d /Volumes/Toshiba4Tb/ -c db/categorical_spectra_0.1x.txt
......
Executing: samtools view -uh -q 30 /Volumes/Toshiba4Tb/walsh.bam 22 | samtools depth -b PaSDqc/cov/walsh.chr22.map.pos - > PaSDqc/cov/walsh.chr22.map.pos.cov; rm PaSDqc/cov/walsh.chr22.map.pos
[main_samview] random alignment retrieval only works for indexed BAM or CRAM files.
PaSDqc/psd/walsh.chroms.spec
/usr/local/lib/python3.6/site-packages/PaSDqc/PSDTools.py:34: FutureWarning:
read_table is deprecated, use read_csv instead, passing sep='\t'.
PaSDqc/psd/SRS379201.walsh.chroms.spec
multiprocessing.pool.RemoteTraceback:
"""
Traceback (most recent call last):
File "/usr/local/Cellar/python/3.6.5/Frameworks/Python.framework/Versions/3.6/lib/python3.6/multiprocessing/pool.py", line 119, in worker
result = (True, func(*args, **kwds))
File "/usr/local/bin/PaSDqc", line 102, in _build_and_save
psd = PaSDqc.PSDTools.SamplePSD.build_from_dir(str(dir_in), sample=sample, clean=clean, build=build)
File "/usr/local/lib/python3.6/site-packages/PaSDqc/PSDTools.py", line 268, in build_from_dir
df = cls._build_dataframe(file_list, build)
File "/usr/local/lib/python3.6/site-packages/PaSDqc/PSDTools.py", line 313, in _build_dataframe
psd_list = [ChromPSD(str(f)) for f in f_list]
File "/usr/local/lib/python3.6/site-packages/PaSDqc/PSDTools.py", line 313, in
psd_list = [ChromPSD(str(f)) for f in f_list]
File "/usr/local/lib/python3.6/site-packages/PaSDqc/PSDTools.py", line 35, in init
self.chrom = str(self.df.chrom.iloc[0])
File "/usr/local/lib/python3.6/site-packages/pandas/core/indexing.py", line 1500, in getitem
return self._getitem_axis(maybe_callable, axis=axis)
File "/usr/local/lib/python3.6/site-packages/pandas/core/indexing.py", line 2230, in _getitem_axis
self._validate_integer(key, axis)
File "/usr/local/lib/python3.6/site-packages/pandas/core/indexing.py", line 2139, in _validate_integer
raise IndexError("single positional indexer is out-of-bounds")
IndexError: single positional indexer is out-of-bounds
"""
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/usr/local/bin/PaSDqc", line 265, in
args.func(args)
File "/usr/local/bin/PaSDqc", line 210, in QC
PSD(args)
File "/usr/local/bin/PaSDqc", line 95, in PSD
[p.get() for p in res]
File "/usr/local/bin/PaSDqc", line 95, in
[p.get() for p in res]
File "/usr/local/Cellar/python/3.6.5/Frameworks/Python.framework/Versions/3.6/lib/python3.6/multiprocessing/pool.py", line 644, in get
raise self._value
IndexError: single positional indexer is out-of-bounds
So I guess there is something wrong in my Python setup? If you have any suggestions, I will be grateful
thanks
christos

Hi Christos,
It looks like your bam file is not indexed hence this error from samtools in the first step

[main_samview] random alignment retrieval only works for indexed BAM or CRAM files.

Can you index the BAM with samtools index and retry?
Best,
Max

Oh what a muppet I am !  Please use DataFrame.from_dict(dict(items), ...) instead. DataFrame.from_dict(OrderedDict(items)) may be used to preserve the key order.
PaSDqc/psd/38_24.hg19mod.bwa.sorted.chroms.spec
multiprocessing.pool.RemoteTraceback:
"""
Traceback (most recent call last):
File "/usr/local/Cellar/python/3.6.5/Frameworks/Python.framework/Versions/3.6/lib/python3.6/multiprocessing/pool.py", line 119, in worker
result = (True, func(*args, **kwds))
File "/usr/local/bin/PaSDqc", line 102, in _build_and_save
psd = PaSDqc.PSDTools.SamplePSD.build_from_dir(str(dir_in), sample=sample, clean=clean, build=build)
File "/usr/local/lib/python3.6/site-packages/PaSDqc/PSDTools.py", line 268, in build_from_dir
df = cls._build_dataframe(file_list, build)
File "/usr/local/lib/python3.6/site-packages/PaSDqc/PSDTools.py", line 313, in _build_dataframe
psd_list = [ChromPSD(str(f)) for f in f_list]
File "/usr/local/lib/python3.6/site-packages/PaSDqc/PSDTools.py", line 313, in
psd_list = [ChromPSD(str(f)) for f in f_list]
File "/usr/local/lib/python3.6/site-packages/PaSDqc/PSDTools.py", line 35, in init
self.chrom = str(self.df.chrom.iloc[0])
File "/usr/local/lib/python3.6/site-packages/pandas/core/indexing.py", line 1500, in getitem
return self._getitem_axis(maybe_callable, axis=axis)
File "/usr/local/lib/python3.6/site-packages/pandas/core/indexing.py", line 2230, in _getitem_axis
self._validate_integer(key, axis)
File "/usr/local/lib/python3.6/site-packages/pandas/core/indexing.py", line 2139, in _validate_integer
raise IndexError("single positional indexer is out-of-bounds")
IndexError: single positional indexer is out-of-bounds
"""
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/usr/local/bin/PaSDqc", line 265, in
args.func(args)
File "/usr/local/bin/PaSDqc", line 210, in QC
PSD(args)
File "/usr/local/bin/PaSDqc", line 95, in PSD
[p.get() for p in res]
File "/usr/local/bin/PaSDqc", line 95, in
[p.get() for p in res]
File "/usr/local/Cellar/python/3.6.5/Frameworks/Python.framework/Versions/3.6/lib/python3.6/multiprocessing/pool.py", line 644, in get
raise self._value
IndexError: single positional indexer is out-of-bounds
any idea?
i will try to run other files, and the one from SRA, later
christos

i was unable to get it work, although the example was running
.p arm
9.q arm
/usr/local/lib/python3.6/site-packages/PaSDqc/PSDTools.py:324: FutureWarning:
from_items is deprecated. Please use DataFrame.from_dict(dict(items), ...) instead. DataFrame.from_dict(OrderedDict(items)) may be used to preserve the key order.
PaSDqc/psd/38_24.hg19mod.bwa.sorted.chroms.spec
PaSDqc/psd/38_24.hg19mod.bwa.chroms.spec
multiprocessing.pool.RemoteTraceback:
"""
Traceback (most recent call last):
  File "/usr/local/Cellar/python/3.6.5/Frameworks/Python.framework/Versions/3.6/lib/python3.6/multiprocessing/pool.py", line 119, in worker
    result = (True, func(*args, **kwds))
  File "/usr/local/bin/PaSDqc", line 102, in _build_and_save
    psd = PaSDqc.PSDTools.SamplePSD.build_from_dir(str(dir_in), sample=sample, clean=clean, build=build)
  File "/usr/local/lib/python3.6/site-packages/PaSDqc/PSDTools.py", line 268, in build_from_dir
    df = cls._build_dataframe(file_list, build)
  File "/usr/local/lib/python3.6/site-packages/PaSDqc/PSDTools.py", line 313, in _build_dataframe
    psd_list = [ChromPSD(str(f)) for f in f_list]
  File "/usr/local/lib/python3.6/site-packages/PaSDqc/PSDTools.py", line 313, in
    psd_list = [ChromPSD(str(f)) for f in f_list]
  File "/usr/local/lib/python3.6/site-packages/PaSDqc/PSDTools.py", line 35, in init
    self.chrom = str(self.df.chrom.iloc[0])
  File "/usr/local/lib/python3.6/site-packages/pandas/core/indexing.py", line 1500, in getitem
    return self._getitem_axis(maybe_callable, axis=axis)
  File "/usr/local/lib/python3.6/site-packages/pandas/core/indexing.py", line 2230, in _getitem_axis
    self._validate_integer(key, axis)
  File "/usr/local/lib/python3.6/site-packages/pandas/core/indexing.py", line 2139, in _validate_integer
    raise IndexError("single positional indexer is out-of-bounds")
IndexError: single positional indexer is out-of-bounds
"""
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
  File "/usr/local/bin/PaSDqc", line 265, in
    args.func(args)
  File "/usr/local/bin/PaSDqc", line 210, in QC
    PSD(args)
  File "/usr/local/bin/PaSDqc", line 95, in PSD
    [p.get() for p in res]
  File "/usr/local/bin/PaSDqc", line 95, in
    [p.get() for p in res]
  File "/usr/local/Cellar/python/3.6.5/Frameworks/Python.framework/Versions/3.6/lib/python3.6/multiprocessing/pool.py", line 644, in get
    raise self._value
IndexError: single positional indexer is out-of-bounds
i then cleaned up my brew, upgraded to python 3.7 ,and installed all dependencies
then tried to build, and failed
make
python setup.py sdist
'import sitecustomize' failed; use -v for traceback
Traceback (most recent call last):
  File "setup.py", line 56, in
    install_requires = check_dependencies()
  File "setup.py", line 24, in check_dependencies
    import matplotlib
  File "/usr/local/lib/python3.6/site-packages/matplotlib/init.py", line 351
    print(s, file=self.fileo)
                 ^
SyntaxError: invalid syntax
make: *** [dist] Error 1
I will try to get local help, but is it possible that it cant compile on python 3.7? (sorry if this is a stupid question)

Hmm, the make error seems like something is wrong with the python setup.
Just to confirm, you were not able to get the software to run on the SRA bam?

Yes  it does, thanks
So I had a problem with the SRA bam- the numbers in the paper seemed to refer to experiment rather than a single bam file in SRA- or i misunderstood something
And I downloaded one which gave me an error that suggested that the reference didn’t match- as if it came from a ref with “chr” included, if I understood correctly
I am away this week but someone is working on it on a different mac which will hopefully work, and I will try if needed via anaconda next week, and get back to you and / or close thread if all fine, thanks again

Ah, I am sorry about the SRA problems. I wasn't involved in uploading them, so I am afraid I don't know much about those files.
As for the outstanding chr9 issue, my guess is that your bam file has little (or no) coverage on chr9; this would produce the error you've encountered as the program would try to index an empty array. This is an easy thing to check once you've got the python environment set up again. I've meant to correct this behavior for sometime (it would be far better for PaSDqc to print a warning and skip the chromosome rather than fail outright). I could integrate this feature if you'd be willing to test for me =).

Hello Max,
I am working with Christos.
So I was able to run your pipeline and create the chrom.spec files but I got this error afterwards. If you have any idea what might have caused it, that would be extremely helpful.
My command: PaSDqc QC -d/Users/maria/Desktop/Diego_P7006-124586463/Fastq/pons/bams -o /Users/maria/Desktop/PaSD-qc -c categorical_spectra_0.1x.txt
The warning:
`Reading data from /Users/maria/Desktop/PaSD-qc
/Library/Frameworks/Python.framework/Versions/3.7/bin/PaSDqc:117: FutureWarning:
read_table is deprecated, use read_csv instead, passing sep='\t'.
Fitting chromosome and sample curves
/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/pandas/core/series.py:4141: FutureWarning:
from_csv is deprecated. Please use read_csv(...) instead. Note that some of the default arguments are different, so please refer to the documentation for from_csv when changing your function calls
/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/PaSDqc/extra_tools.py:54: FutureWarning:
Method .as_matrix will be removed in a future version. Use .values instead.
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.7/bin/PaSDqc", line 265, in
args.func(args)
File "/Library/Frameworks/Python.framework/Versions/3.7/bin/PaSDqc", line 211, in QC
report(args)
File "/Library/Frameworks/Python.framework/Versions/3.7/bin/PaSDqc", line 123, in report
[psd.fit_chrom_curves(chroms, bulk=args.bulk) for psd in psd_list]
File "/Library/Frameworks/Python.framework/Versions/3.7/bin/PaSDqc", line 123, in
[psd.fit_chrom_curves(chroms, bulk=args.bulk) for psd in psd_list]
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/PaSDqc/PSDTools.py", line 376, in fit_chrom_curves
amp_chrom.fit_curve(method=method, bulk=bulk)
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/PaSDqc/amplicon.py", line 197, in fit_curve
popt, pcov = scipy.optimize.curve_fit(f_fit, period, psd_cut, method='trf')
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/scipy/optimize/minpack.py", line 703, in curve_fit
ydata = np.asarray_chkfinite(ydata)
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/numpy/lib/function_base.py", line 498, in asarray_chkfinite
"array must not contain infs or NaNs")
ValueError: array must not contain infs or NaNs'
Christoss-giant-Mac:bams maria$
`

Hello Max,
I am working with Christos.
So I was able to run your pipeline and create the chrom.spec files but I got this error afterwards. If you have any idea what might have caused it, that would be extremely helpful.
My command: PaSDqc QC -d/Users/maria/Desktop/Diego_P7006-124586463/Fastq/pons/bams -o /Users/maria/Desktop/PaSD-qc -c db/categorical_spectra_0.1x.txt
The warning:
`Reading data from /Users/maria/Desktop/PaSD-qc
/Library/Frameworks/Python.framework/Versions/3.7/bin/PaSDqc:117: FutureWarning:
read_table is deprecated, use read_csv instead, passing sep='\t'.
Fitting chromosome and sample curves
/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/pandas/core/series.py:4141: FutureWarning:
from_csv is deprecated. Please use read_csv(...) instead. Note that some of the default arguments are different, so please refer to the documentation for from_csv when changing your function calls
/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/PaSDqc/extra_tools.py:54: FutureWarning:
Method .as_matrix will be removed in a future version. Use .values instead.
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.7/bin/PaSDqc", line 265, in
args.func(args)
File "/Library/Frameworks/Python.framework/Versions/3.7/bin/PaSDqc", line 211, in QC
report(args)
File "/Library/Frameworks/Python.framework/Versions/3.7/bin/PaSDqc", line 123, in report
[psd.fit_chrom_curves(chroms, bulk=args.bulk) for psd in psd_list]
File "/Library/Frameworks/Python.framework/Versions/3.7/bin/PaSDqc", line 123, in
[psd.fit_chrom_curves(chroms, bulk=args.bulk) for psd in psd_list]
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/PaSDqc/PSDTools.py", line 376, in fit_chrom_curves
amp_chrom.fit_curve(method=method, bulk=bulk)
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/PaSDqc/amplicon.py", line 197, in fit_curve
popt, pcov = scipy.optimize.curve_fit(f_fit, period, psd_cut, method='trf')
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/scipy/optimize/minpack.py", line 703, in curve_fit
ydata = np.asarray_chkfinite(ydata)
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/numpy/lib/function_base.py", line 498, in asarray_chkfinite
"array must not contain infs or NaNs")
ValueError: array must not contain infs or NaNs`

Hi Maria,
Great news that you you've generated the spec files. This is a fairly common error and usually easily fixed. First things first, can you confirm that the chrom.spec files are not empty?

Happy to hear that. They are not empty and around 3.5 MB each.
Here is a screenshot of how they look

Great! How many samples are you profiling? My guess is that you have one or two samples of very bad quality (lots of regions of very low or no coverage). The estimation procedure will fail in such cases. Can you try generating a report using some small subsets of the chrom.spec files?
You can just copy a few to a new directory and run
PaSDqc report -d <directory> -c db/categorical_spectra_0.1x.txt

I tried but I got this error.
PaSDqc report -d /Users/maria/Desktop/example -c db/categorical_spectra_0.1x.txt Reading data from /Users/maria/Desktop/example Traceback (most recent call last):   File "/Library/Frameworks/Python.framework/Versions/3.7/bin/PaSDqc", line 265, in <module>     args.func(args)   File "/Library/Frameworks/Python.framework/Versions/3.7/bin/PaSDqc", line 119, in report     freq = psd_list[0].freq IndexError: list index out of range
I tried 3 samples just for testing before. I will try again now with more samples and higher reads.

How many files did you copy to examples? That error implies the program did not find any files to read.

So sorry I forgot to create a psd directory inside the example directory I moved the files.
So now it worked and produced the same error for these 3 test files.
`eduroam-int-dhcp-97-153-178:PaSDqc maria$ PaSDqc report -d /Users/maria/PaSDqc/examples/ -c db/categorical_spectra_0.1x.txt
01_example_report/                     06_example_clustering/
02_example-basic_PSD/                  07_example_region_blacklist/
03_example-amplicon_distribution/      08_example_make_gold_standard_spectra/
04_example-dispersion_estimation/      data/
05_example_chromosome_classification/
eduroam-int-dhcp-97-153-178:PaSDqc maria$ PaSDqc report -d /Users/maria/PaSDqc/examples/01_example_report/ -c db/categorical_spectra_0.1x.txt
PaSDqc_report.html  data/               psd/
eduroam-int-dhcp-97-153-178:PaSDqc maria$ PaSDqc report -d /Users/maria/Desktop/example/ -c db/categorical_spectra_0.1x.txt
Reading data from /Users/maria/Desktop/example
/Library/Frameworks/Python.framework/Versions/3.7/bin/PaSDqc:117: FutureWarning:
read_table is deprecated, use read_csv instead, passing sep='\t'.
Fitting chromosome and sample curves
/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/pandas/core/series.py:4141: FutureWarning:
from_csv is deprecated. Please use read_csv(...) instead. Note that some of the default arguments are different, so please refer to the documentation for from_csv when changing your function calls
/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/PaSDqc/extra_tools.py:54: FutureWarning:
Method .as_matrix will be removed in a future version. Use .values instead.
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.7/bin/PaSDqc", line 265, in
args.func(args)
File "/Library/Frameworks/Python.framework/Versions/3.7/bin/PaSDqc", line 123, in report
[psd.fit_chrom_curves(chroms, bulk=args.bulk) for psd in psd_list]
File "/Library/Frameworks/Python.framework/Versions/3.7/bin/PaSDqc", line 123, in
[psd.fit_chrom_curves(chroms, bulk=args.bulk) for psd in psd_list]
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/PaSDqc/PSDTools.py", line 376, in fit_chrom_curves
amp_chrom.fit_curve(method=method, bulk=bulk)
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/PaSDqc/amplicon.py", line 197, in fit_curve
popt, pcov = scipy.optimize.curve_fit(f_fit, period, psd_cut, method='trf')
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/scipy/optimize/minpack.py", line 703, in curve_fit
ydata = np.asarray_chkfinite(ydata)
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/numpy/lib/function_base.py", line 498, in asarray_chkfinite
"array must not contain infs or NaNs")
ValueError: array must not contain infs or NaNs`
I will try to run the pipeline again with more files and more reads now

That's a good next step. I would suggest a minimum coverage of 0.5x per bam. Coverage >1X is optimal for performance, though.

I see! Thank you very for the help.
Maria

Hello- a very brief note- we are citing this in a book chapter, and i will say that optimal coverage is >1, based on the above- hopes that's ok, christos

Hi Christos, yes that is accurate. Many thanks for checking.


support verbose mode in rbenv_ruby resource

this can be useful for debug and can solve timeout issues in ci when tests are stopped, because there is no output for a long time.

Is this project alive?

@hd-deman the project is alive, but I don't agree with the implementation of this addition. We should instead look at Chef's log level and, if set to debug, include the verbose output.


Updates the register computation gql

Closes https://github.com/capeprivacy/pycape/issues/187
The project id field is now optional. Also removes the RUTIME_VERSION
global and passed be passed via the computation class.

You'll want to update this test here - https://github.com/capeprivacy/pycape/blob/main/pycape/api/cape/cape_test.py#L290
Otherwise looks good!


Android 3.x changes - Gradle, Github Scripts and CircleCI updates

Other than Gradle, CircleCI and  Github action scripts. Here are the major things to look for in this PR

Commented out a few tests in
MessagingFullscreenEventListenerTests.java
PresentableMessageMapperTests.java
MessagingExtensionTests.java

Renamed TestApp folder name

Thanks for the quick review @spoorthipujariadobe . Will merge it after getting the build to pass.


refactor: update discover page route

Description

Change the discover page route from /new-app to /discover and handle all previous route hrefs.
Use NAVIGATION constant to use hrefs

Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[x] Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)
Slack thread

Not a priority, closing for now. Can be reopened later if re-prioritzed


Release Post: v1.10.0

Description
An article to detail the features, updates and fixes provided in the 1.10.0 Release of FlowForge.
Epic/Story
No response
Have you provided an initial effort estimate for this issue?
I have provided an initial effort estimate

PR #1011

AWS Marketplace entry submitted, it is currently in a manual review phase as it's our first submission.
I suggest we publish the release notes saying it will be available and we will publish a second post when it goes live.


Pages don't always load (load balancer issues?)

Looking at http://zooniverse-aggregation.readthedocs.org/en/latest/. Refreshing this page will sometimes result in a full page load, sometimes the CSS won't load, sometimes the page itself will be a 404 message... Seems like there is load balancing being done but not all endpoints behind the balancer have this repository.
Any ideas would be welcome.

Yikes, a number of issues there. We have some changes coming hopefully next week to reduce the likelihood of some of these issues. I'll see about manually cleaning things up on the build servers before then.

Does this happen to new builds/projects only? I'm having the same issues http://sklearn-evaluation.readthedocs.io/en/latest/

It's still happening for us, at least. But only for our latest project, older ones are unaffected

We have since deployed changes that require each web server to handle their own syncing. This fixes the majority of the cases where this issue was triggered, so I'm going to mark this one as closed.


fix: fix scrollbar styles for Chrome

Chrome started to support scrollbar-width and scrollbar-color CSS properties which we are currently using as a fallback for Firefox. However, when using it in Chrome, it disables all the -webkit-scrollbar stylings. With the new supports check we can avoid to switch to the scrollbar-color approach in Chrome as long as the old approach still works. Painpoint: the new approach doesn't allow a different color for hover.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@2a9f60e). Click here to learn what that means.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2524   +/-   ##
=======================================
  Coverage        ?   93.14%
=======================================
  Files           ?      301
  Lines           ?    24954
  Branches        ?     2041
=======================================
  Hits            ?    23244
  Misses          ?     1681
  Partials        ?       29

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


The RunningBlock : height property doesn't adapt better.

Hi brother,
I'm always frustrated when I use runningblock as a item of statusbar, cuz there is no height property to set and it changes the statusbar's sharp or the value is incomplete.
It will be great if I can set runningblock's property height just like common control, such as textblock.
Thank you!

@JeremyWu917  you can set height property,
<StatusBar VerticalAlignment="Bottom">
            <Label Content="test"/>
            <Label Content="test"/>
            <hc:RunningBlock Height="120">
                <Label Content="Hello"/>
            </hc:RunningBlock>
        </StatusBar>

i tested and worked fine, If you still have problems, please upload a demo project

@JeremyWu917 you can set height property,
<StatusBar VerticalAlignment="Bottom">
            <Label Content="test"/>
            <Label Content="test"/>
            <hc:RunningBlock Height="120">
                <Label Content="Hello"/>
            </hc:RunningBlock>
        </StatusBar>

i tested and worked fine, If you still have problems, please upload a demo project

Thanks for your reply.
After review the runningblock source code, it does allow you to set the height property, but when you set the height property to less than 51(Cuz most of the time, the height of the status bar will not exceed 30), another new problem arises, which is that the height doesn't adapt and the value doesn't display in full.
Maybe I should change the title of this issue to something like - The RunningBlock control height property doesn't adapt better.
Thanks again.

@JeremyWu917 you can set height property,
<StatusBar VerticalAlignment="Bottom">
            <Label Content="test"/>
            <Label Content="test"/>
            <hc:RunningBlock Height="120">
                <Label Content="Hello"/>
            </hc:RunningBlock>
        </StatusBar>

i tested and worked fine, If you still have problems, please upload a demo project

@ghost1372
Sorry for the late response and here is the demo you can refer, thanks.
<StatusBar VerticalAlignment="Bottom">             <Label Content="test"/>             <Label Content="test"/>             <hc:RunningBlock Height="30">                 <Label Content="Hello"/>             </hc:RunningBlock>  </StatusBar>

@JeremyWu917  Set the padding value to 0
 <hc:RunningBlock Padding="0" Height="30">
                <Label Content="Hello"/>
            </hc:RunningBlock>

@NaBian  Wouldn't it be better if the padding was set to 0 by default? It is currently at 10

@JeremyWu917 Set the padding value to 0
 <hc:RunningBlock Padding="0" Height="30">
                <Label Content="Hello"/>
            </hc:RunningBlock>

@NaBian Wouldn't it be better if the padding was set to 0 by default? It is currently at 10
https://github.com/HandyOrg/HandyControl/blob/b4d1616753e67fe0015bf1062097df5a0d782164/src/Shared/HandyControl_Shared/Themes/Styles/Base/RunningBlockBaseStyle.xaml#L15

padding with a value of 10 is common in hc, such as button, textbox. so should RunningBlock.

Thanks for your reply.
When I set the height to 30 and the padding to 0, it does work fine, but when the height is even smaller, it still doesn't show up all the way. Please see the screenshot below.
So, if possible, I think it's a little better to set the height to adaptive, what do you think? Thank you.
<hc:RunningBlock Padding="0" Height="20">      <Label Content="Hello"/> </hc:RunningBlock>

@JeremyWu917 ok, you can use codes following:
<hc:RunningBlock Height="20" Padding="0">
    <Label Content="Hello" Height="Auto" Padding="0"/>
</hc:RunningBlock>


Update: remove duplicated resource and should have lower in order

https://github.com/project-codeflare/codeflare-operator/blob/main/controllers/mcad_controller.go#L232 has added resource

/ok-to-test

/lgtm /approve

/approve
/retest


Use vmware-tanzu/carvel instead of the deprecated k14s/tap to install deps with brew

Replace in the occurrences of k14s/tap in favor of vmware-tanzu/carvel  in the Contributing.md and hack/prepare-for-integration-tests.sh. This is to avoid the deprecation messages like:
Warning: k14s/tap/kapp has been deprecated because it Migrating tap to vmware-tanzu/carvel!
and
Warning: k14s/tap/ytt has been deprecated because it Migrating tap to vmware-tanzu/carvel!

Release note:

NONE

Done!

Done!

Thanks! As soon as it goes through an internal review process the bot will respond again, and then we will be able to merge. That usually takes a couple of days.

Merged main into PR, and merging to main now. Didn't wait for CI to run again since these docs are not covered by tests.
Thanks for your contribution @vicmarbev! Much appreciated!


Breakpoint locations are updated after code edits even before saving

I am trying to write a debug adapter which supports a "live reload" type of scenario, where executing code updates to reflect the latest sources as soon as they are changed on disk. However I see vscode attempting to update breakpoints after code edits even before writing the code to disk, so the debug adapter is working from different code to vscode.
For a concrete example, consider the nodejs code
setInterval(function() {
    console.log("1");
    console.log("2");
}, 5000);

If you set a breakpoint on line 2 with the first console.log line there and run it, the breakpoint is hit before printing the line, as expected. If you then continue execution and insert a newline before that first console.log without saving the file, the next iteration will show the breakpoint as being hit on line 3 with the console.log("1") line, but the program output will show that a "1" has already been printed and the breakpoint is actually set on line 3 of the original sources.
It seems to me that vscode should only instruct the debug adapters to update breakpoints after the files have been saved to disk and are visible to other processes.

Dup of #2975


networks.ingress value Additional properties are not allowed ('name' was unexpected)

Hey @lmakarov, thanks for putting together this sample of what a production setup might look like leveraging traefik for a reverse proxy alongside classic Docksal project images. This is more or less the setup I'm chasing (i.e. hoping to reuse Docksal's classic service offerings cli, web, db, varnish, etc.).
I'm running into a couple errors getting the system portion of this working.
lpeabody@peabody-server01:~/server_configuration/system$ make up
Starting up containers for system...
#@sudo -E /usr/bin/docker-compose pull
ERROR: The Compose file './docker-compose.yml' is invalid because:
networks.ingress value Additional properties are not allowed ('name' was unexpected)
services.portainer.labels.traefik.enable contains true, which is an invalid type, it should be a string, number, or a null
services.traefik.labels.traefik.enable contains true, which is an invalid type, it should be a string, number, or a null
Makefile:27: recipe for target 'start' failed
make: *** [start] Error 1

My setup is a straight clone of the system setup you've documented on https://github.com/lmakarov/docksal-prod-poc/tree/master/system. I have .env with the following:
HOSTING_ENVIRONMENT = prod

And my .prod.env has the following:
# Settings for running docker/docker-compose
DOCKER ?= sudo -E /usr/bin/docker
DOCKER_COMPOSE ?= sudo -E /usr/bin/docker-compose

HTTP_PORT_MAPPING = 80:80

# Basic auth
# Generate a new credentials string with:
# echo $(htpasswd -nb '<AUTH-USER>' '<AUTH-PASS>') | sed -e 's/\$/\$\$/g'
# Credentials: admin:Ch@ngeMePle@se
ADMIN_BASIC_AUTH = userscrubbed:passscrubbed/

I googled a bit and found that this error:
networks.ingress value Additional properties are not allowed ('name' was unexpected)

Is due to network name being supported in compose file version 3.5+ (https://docs.docker.com/compose/compose-file/compose-versioning/#version-35), but the compose file version in system's docker-compose.yml is 2.1. I have not traced the other boolean-related errors yet. Just wondering if you could shine some light on this.

Looking at some Traefik docs, it looks like the labels should just be strings (https://docs.traefik.io/user-guide/examples/). I converted them accordingly. Still running into the error re: name not being a valid property of a network.

I got it working by updating to Docker Compose 1.24 and updating the version in system's docker-compose.yml file to 3.7.

@lpeabody that's weird. I just tried it locally and system services are starting just fine:
$ make start
Starting up containers for system...
#@docker-compose pull
Creating network "ingress" with the default driver
Creating portainer ... done
Creating traefik   ... done

$ make remove
Removing resources for system...
Stopping traefik   ... done
Stopping portainer ... done
Removing traefik   ... done
Removing portainer ... done
Removing network ingress

$ docker --version
Docker version 18.09.2, build 6247962
$ docker-compose --version
docker-compose version 1.23.2, build 1110ad01

$ docker version
Client: Docker Engine - Community
 Version:           18.09.2
 API version:       1.39
 Go version:        go1.10.8
 Git commit:        6247962
 Built:             Sun Feb 10 04:12:39 2019
 OS/Arch:           darwin/amd64
 Experimental:      false

Server: Docker Engine - Community
 Engine:
  Version:          18.09.2
  API version:      1.39 (minimum version 1.12)
  Go version:       go1.10.6
  Git commit:       6247962
  Built:            Sun Feb 10 04:13:06 2019
  OS/Arch:          linux/amd64
  Experimental:     false

So your docker-compose.yml system file has version 2.1 specified but it's allowing the name property on the network?

So a couple details I left out:
I upgraded to docker-compose 1.24 from 1.17. When I ran make up with 1.17 it complained about name being unsupported in networking. I looked it up and name was introduced in Compose file version 3.5. So I upgraded to the latest Docker Compose, AND also changed the Compose version of system's docker-compose.yml to 3.7 (because why not use the latest).
That worked, but I never checked if leaving the version at 2.1 would work because I thought the error was telling me that 2.1 did not support the name property on networks, lol. Apparently it does? I'm confused though, if it was introduced in 3.5, then why would 2.1 build without error?

So your docker-compose.yml system file has version 2.1 specified but it's allowing the name property on the network?

Yep.
I've just cloned the repo clean and verified it works. I see the docs stating the name property is not available until composer file format 3.5, but it works fine in 2.1.
The only issues is with the spaces in the .env files when using docker-compose v1.24. Apparently, it is more strict with the file format.
$ ./docker-compose --version
docker-compose version 1.24.0, build 0aa59064

$ DOCKER_COMPOSE=$(pwd)/docker-compose make config
/Users/leonid/Work/Labs/docksal/docksal-prod-poc/system/docker-compose config
ERROR: In file ./.env: environment variable name 'HOSTING_ENVIRONMENT ' may not contains whitespace.
make: *** [config] Error 1

Actually, compose loading that the .env file is unintentional, maybe even undesirable. The file is meant to be loaded by Makefile and not docker-compose.

Interesting! I guess it just probably auto-detects if it can support the content of the compose file, and if it can then it just does it... or maybe it's a bug :)
I'm going to stick pretty close to this setup, at least for the initial go of setting up this project's dev/stage/prod environments. Thank you for putting it together.


Update tapir-core, tapir-http4s-server, ... to 1.0.3

Updates

com.softwaremill.sttp.tapir:tapir-core
com.softwaremill.sttp.tapir:tapir-http4s-server
com.softwaremill.sttp.tapir:tapir-json-circe
com.softwaremill.sttp.tapir:tapir-openapi-docs
com.softwaremill.sttp.tapir:tapir-swagger-ui

from 1.0.0-M9 to 1.0.3.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.softwaremill.sttp.tapir" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "com.softwaremill.sttp.tapir" }
}]

labels: library-update, early-semver-pre-release, semver-spec-pre-release, commit-count:1

Superseded by #534.


Task :app:lintVitalAnalyzeRelease FAILED

Task :app:lintVitalAnalyzeRelease FAILED

FAILURE: Build failed with an exception.

What went wrong:
A problem was found with the configuration of task ':app:lintVitalAnalyzeRelease' (type 'AndroidLintAnalysisTask').

Gradle detected a problem with the following location: '/home////packages//android/app/build/intermediates/ReactNativeVectorIcons'.
Reason: Task ':app:lintVitalAnalyzeRelease' uses this output of task ':app:copyReactNativeVectorIconFonts' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
Possible solutions:

Declare task ':app:copyReactNativeVectorIconFonts' as an input of ':app:lintVitalAnalyzeRelease'.
Declare an explicit dependency on ':app:copyReactNativeVectorIconFonts' from ':app:lintVitalAnalyzeRelease' using Task#dependsOn.
Declare an explicit dependency on ':app:copyReactNativeVectorIconFonts' from ':app:lintVitalAnalyzeRelease' using Task#mustRunAfter.

Please refer to https://docs.gradle.org/8.0.1/userguide/validation_problems.html#implicit_dependency for more details about this problem.

This patch solution might works for you:
https://stackoverflow.com/a/76614223

@timhatch Are you sure you're running 10.0.0? The extra lines in the comment you mentioned should already exist in fonts.gradle.
Where did you add them?

@oblador
I've double checked the package.json and it's 10.0.0
The relevant lines in the fonts.gradle file were (prior to patching):
    android.applicationVariants.all { def variant ->
        def targetName = variant.name.capitalize()

        def generateAssetsTask = tasks.findByName("generate${targetName}Assets")
        generateAssetsTask.dependsOn(fontCopyTask)

        def lintVitalAnalyzeTask = tasks.findByName("lintVitalAnalyze${targetName}")
        lintVitalAnalyzeTask?.dependsOn(fontCopyTask)
    }

and I've checked these against the same file in this repo.
The patch file contents are:
diff --git a/node_modules/react-native-vector-icons/fonts.gradle b/node_modules/react-native-vector-icons/fonts.gradle
index ddcf377..1084091 100644
--- a/node_modules/react-native-vector-icons/fonts.gradle
+++ b/node_modules/react-native-vector-icons/fonts.gradle
@@ -30,6 +30,9 @@ afterEvaluate {
         def generateAssetsTask = tasks.findByName("generate${targetName}Assets")
         generateAssetsTask.dependsOn(fontCopyTask)

+        def lintAnalyzeTask = tasks.findByName("lintAnalyze${targetName}")
+        lintAnalyzeTask?.dependsOn(fontCopyTask)
+
         def lintVitalAnalyzeTask = tasks.findByName("lintVitalAnalyze${targetName}")
         lintVitalAnalyzeTask?.dependsOn(fontCopyTask)
     }

Scrolling back through my terminal output I can see that the original messages were as follow:
* What went wrong:
A problem was found with the configuration of task ':app:lintAnalyzeDebug' (type 'AndroidLintAnalysisTask').
  - Gradle detected a problem with the following location: '/Users/timhatch/Development/ifsc/wm23-RN72/android/app/build/intermediates/ReactNativeVectorIcons'.

    Reason: Task ':app:lintAnalyzeDebug' uses this output of task ':app:copyReactNativeVectorIconFonts' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.

    Possible solutions:
      1. Declare task ':app:copyReactNativeVectorIconFonts' as an input of ':app:lintAnalyzeDebug'.
      2. Declare an explicit dependency on ':app:copyReactNativeVectorIconFonts' from ':app:lintAnalyzeDebug' using Task#dependsOn.
      3. Declare an explicit dependency on ':app:copyReactNativeVectorIconFonts' from ':app:lintAnalyzeDebug' using Task#mustRunAfter.

    Please refer to https://docs.gradle.org/8.0.1/userguide/validation_problems.html#implicit_dependency for more details about this problem.

..so actually my issue was adjacent issue rather the same

Ahh, thanks. I looked at both bits of code, and they looked identical at first glance. :smile:
I'll do some testing on this tonight.

@oblador No problem. It caught me out also - and I can't pretend to understand the difference usage of lintAnalyzeDebug, lintAnalyze and lintVitalAnalyze. The inner workings of Gradle are a mystery to me.

Any news here :-)? Also struggling with this error :-/

react native version: 7.2.4, I also encountered the same problem
The error is the same as below:
Upgrading react-native-vector-icons to 10.0.0 did not solve this problem
`/**

Register font asset source folder
*/
android.sourceSets.main.assets.srcDirs += file("$buildDir/intermediates/ReactNativeVectorIcons")

/**

Task to copy icon font files
/
afterEvaluate {
def config = project.hasProperty("vectoricons") ? project.vectoricons : [];
def iconFontsDir = config.iconFontsDir ?: "../../node_modules/react-native-vector-icons/Fonts";
def iconFontNames = config.iconFontNames ?: [ ".ttf" ];
def fontCopyTask = tasks.create(
name: "copyReactNativeVectorIconFonts",
type: Copy) {
description = "copy vector icon fonts."
into "$buildDir/intermediates/ReactNativeVectorIcons/fonts"
 iconFontNames.each { fontName ->
     from(iconFontsDir) {
         include(fontName)
     }
 }

}
android.applicationVariants.all { def variant ->
def targetName = variant.name.capitalize()
 def generateAssetsTask = tasks.findByName("generate${targetName}Assets")
 generateAssetsTask.dependsOn(fontCopyTask)

 def lintVitalAnalyzeTask = tasks.findByName("lintVitalAnalyze${targetName}")
 lintVitalAnalyzeTask?.dependsOn(fontCopyTask)

}
}
 > Task :app:lintAnalyzeDebug FAILED
w: Detected multiple Kotlin daemon sessions at build\kotlin\sessions

FAILURE: Build failed with an exception.

What went wrong:
A problem was found with the configuration of task ':app:lintAnalyzeDebug' (type 'AndroidLintAnalysisTask').

Gradle detected a problem with the following location: 'D:\Users\Administrator\react-project\WhatAi\android\app\build\intermediates\ReactNativeVectorIcons'.
Reason: Task ':app:lintAnalyzeDebug' uses this output of task ':app:copyReactNativeVectorIconFonts' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what ord
er the tasks are executed.
Possible solutions:

Declare task ':app:copyReactNativeVectorIconFonts' as an input of ':app:lintAnalyzeDebug'.
Declare an explicit dependency on ':app:copyReactNativeVectorIconFonts' from ':app:lintAnalyzeDebug' using Task#dependsOn.
Declare an explicit dependency on ':app:copyReactNativeVectorIconFonts' from ':app:lintAnalyzeDebug' using Task#mustRunAfter.

Please refer to https://docs.gradle.org/8.0.1/userguide/validation_problems.html#implicit_dependency for more details about this problem.
`

+1

Same issue. Any update?

I'd like to put this to bed once and for all, but I'm not experiencing this my project using RNVI on android.
Is someone able to provide a reproducible example repository?

@vecchiomatias  @joviksdev  @Pivosoft @johnf
To fix this ,follow these step

remove apply from: file("../../node_modules/react-native-vector-icons/fonts.gradle") from android/app/build.gradlew
go to node_modules/react-native-vector-icon/Fonts and copy all the fonts
go to android/app/src/main and create a folder named assets if not exist then inside then assets create one more folder named fonts and paste all the fonts from   node_modules/react-native-vector-icon/Fonts to here
now you can use the vector icon as usual and also you can create a build which won't failed

This patch solution might works for you:
https://stackoverflow.com/a/76614223

thanks, worked for me.

This should be fixed in the latest release


Extend supported media formats

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

[ ] Bug fix
[x] Feature
[ ] Other

What is the current behavior?
(You can also link to an open issue here)
Bot handles only photo
What is the new behavior?
Bot handles three types of media: animation, video and photo
Does this PR introduce a breaking change?
Yes.

withImage preprocessor is replaced with withMedia
Sharp is replaced  with ffmpeg

Other information

Everything seems to be done pretty well :) Approved


Add Hikey960 board support in LISA #443

Add Hikey960 board support in LISA

The HiKey960 is in a good state right now, and with hardware video decoding hopefully coming at the end of the month I think we'll be using the platform more and more. We'll need this PR merged sooner than later, but I'd like the following points to be addressed first:

Merge/Notebook commits should be removed from this PR.
Move the UNKNOWN board warning in a separate commit
Energy model values should be aligned with the values used by the kernel, so they should be the same as in hi3660-sched-energy.dtsi.


Update xmldom version to 0.8.10

Upgrades the xmldom version to 0.8.10
The previously used version (0.6.0) has a critical security vulnerability: https://github.com/advisories/GHSA-crh6-fp67-6883

Hi @yousufkalim can you take a look at this when you have a chance? Thanks

@milandhar thank you so much for this contribution, I'm merging the PR and publishing a release.


Unable to bind state types to useLocation

Currently, it is not possible to safely type custom state values for the Location object returned by the useLocation hook. This is because the State generic is never properly bound from the hook direction.
Version
6.0.0-beta.0
Steps to reproduce
In a typescript project,
import { Location } from 'history';
import { useLocation } from 'react-router-dom';

interface MyState {
  someValue: boolean;
}

function App() {
  const { state }: Location<MyState> = useLocation();
}

Expected Behavior
TypeScript compiles the above successfully without warnings.
Actual Behavior
Typescript throws the following error:
TS2322: Type 'Location<State>' is not assignable to type 'Location<MyState>'.
  Type 'State' is not assignable to type 'MyState'.
    Type 'null' is not assignable to type 'MyState'.

https://github.com/ReactTraining/react-router/pull/7326#issuecomment-626418225


Fix removing previous module files in PHPStan tests

Questions
Answers

Description?
The previous way of removing the directory didn't work correctly.

Type?
bug fix

BC breaks?
no

Deprecations?
no

Fixed ticket?
This is just a copy of https://github.com/PrestaShop/blockreassurance/pull/594

How to test?
CI is 🟢 (with less random php-test rm -rf failures)

@kpodemski We still face Clear previous module failure here.

@leemyongpakvn this time it's different I think 🤔 it looks like it has been deleted, and we try to remove something that doesn't exist

thank you @leemyongpakvn - since it has no functional changes, I'm merging it


feat(http-client-csharp): support @flattenProperty

this is a port of https://github.com/Azure/autorest.csharp/pull/4688 with some additional changes due to different code base:

add FlattenedNames to InputModelProperty
add TryReadStringArray to Utf8JsonReaderExtensions

This PR has been covered in https://github.com/microsoft/typespec/pull/3503


Week 06 - Lab Error 2/3

Only 2 test cases out of  3 passes resulting in score ~66

mCallBack was sometimes null when onPostExecute() was reached. In that method add a nullcheck on mCallBack before calling notifyDataRefreshed()
updated code - https://github.com/UtkarshPathrabe/Programming-Mobile-Applications-for-Android-Handheld-Systems--Part-2--University-of-Maryland/pull/2


Client does not appear to respect Request headers

This could be an issue on my end but things are not working as expected... When I set an auth header when creating the client, a subsequent fetch call does not seem to have that header...
I have this code:
<script type="module">
    import * as metro from<EMAIL_ADDRESS>
    function createClient() {
        return metro.client('https://show-request.potherca.workers.dev/', {
            headers: {
                'Authorization': `Bearer mock-token`,
                'User-Agent': 'Potherca',
            },
        })
    }

    const client = createClient()

    client.get('/')
        .then(async response => {
            document.body.insertAdjacentHTML('beforeend', `<pre>${JSON.stringify(await response.json(), null, 2)}</pre>`)
        })
</script>

(I created https://show-request.potherca.workers.dev/ to make it easier to see what is going on, in stead of having to continuously check the network panel).
On a side note, JSON.stringify(response.body, null, 2) keeps returning {} instead of the actual value?
Used json() as instructed below

Looks like this is related to my example not using any middle-ware. If you remove the .with(jsonmw()) from your example, it stops working too...


[GH-11] gopath and gobin

First off, thanks for taking the time to use and give feedback on the role.
I've tried to split the "installation" vs "configuration" into the andrewrothstein.go and andrewrothstein.go-dev roles, respectively. This PR seems to indicate that perhaps I've done a poor job at separating the two or that there's not a lot of use in this approach.
What are your thoughts?

Hi, Thanks for the reply. If the configuration is restricted to this repository then I would advocate to merge it, but if the go-dev is used in other roles then it could be kept as is and then a dependency could be added to this role.
What do you think about that? If the go-dev is used by other roles then I could apply the changes in go-dev and add a dependency to this repository.

My comment is somewhat unrelated to your discussion, but I have two pet peeves:

Please quote the vars: export MYVAR="${whatever} space space"
I feel that ${GOBIN} should go before ${PATH}  to combat system golang installations: export PATH="${GOBIN}:${PATH}"

@Kaurin and @andrewrothstein thanks for the comments. I think that this can be closed as go modules solved the issue.


⚠ ClamAV has degraded performance

In 8d1a659, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 89 ms

Resolved: ClamAV performance has improved in dbc0b54 after 5 minutes.


libssh2 url updated

failing submodules init due to non existing libssh2 link.
updated to new github repo as stated at https://libssh2.org

+1 to merging this one-line change. git.libssh2.org no longer functions, which blocks users from building your branch of gitx. Merging this pull request would fix the issue.


Viewer JS support image?

Hi,
I tried to open jpg and png files using viewer js but it cant open. Will viewer js  support images?

Currently ViewerJS does not (yet) support images. Somebody started a plugin for it, but it has not yet reached a state where it is bug-free enough to be integrated: #28. So yes, one day ViewerJS will support images. But it needs someone to invest into it, either time or money :)
Closing this issue as resolved and duplicate, supporting images is (indirectly) tracked by #28.

Hi,
Thanks for your kind response...


Remove '/grouped_content_and_links' endpoint

Finding Things are no longer using this endpoint, therefore it should be removed as well as the associated tests.

Might want to remove the route too. https://github.com/alphagov/publishing-api/blob/master/config/routes.rb#L32


[FEAT] Add training rules to settings object

Is your proposal related to a problem?

Currently the settings object does not make a model fully reproducible (i.e. re-trainable). The settings json can save out the blocking rules, comparisons, m/u values etc that make up a model, but not the model training steps that have made them.
Describe the solution you'd like

Add sections to the settings object to define lambda, m and u training rules (similar to blocking rules). These can be specified (and run) at the instantiation step, or if the user iteratively runs model training - these should be added to the settings object under the hood.
Describe alternatives you've considered

Additional context

I’ve wondered about adding the estimation logic to the settings object before and I think it’s a good idea in principle
To explain why it's not there already, it's because are a few challenges, some of which could probably be overcome, but make things tricky:

If you train using labels, you couldn’t easily capture that in the settings object
The order of training matters (not that much, but a bit), so the settings dict would have to preserve order
There are some subtle settings which could be difficult to encode.  For example, an edge case would be a user who decided to fix a m or u values mid-training.
The settings dict would need to remember all parameters passed into the model e.g. the starting values of m, whether to train using the new optimised non-tf adjusted EM approach, etc

Converting to a discussion because still unsure whether this is desirable


Package request: mindsdb

Can normally be installed with pip, but having it in Nixpkgs would be nice
Project description
AI Database that manages AI models and automates workflows connecting AI models with enterprise databases
Metadata

homepage URL: https://mindsdb.com/
source URL: https://github.com/mindsdb/mindsdb
license: gpl3
platforms: linux, mac and windows

This change requires adding a loooot of packages. It would take a while, but I'll be working on that


certificate signed by unknown authority Error when creating a ClusterIssuer in GKE autopilot

Describe the bug:
After successfully installing cert-manager in GKE cluster with autopilot setting enabled I get the following error for creating a ClusterIssuer:
Error from server (InternalError): error when creating "./cells/k8s/cert-manager/config/letsencrypt-staging.yaml": Internal error occurred: failed calling webhook "webhook.cert-manager.io": failed to call webhook: Post "https://cert-manager-webhook.cert-manager.svc:443/mutate?timeout=10s": x509: certificate signed by unknown authority

Expected behaviour:
To report that the ClusterIssuer resource has been created successfully.
Steps to reproduce the bug:

create a GKE cluster with autopilot enabled
install and configure nginx ingress via helm
install cert-manager
run kubectl apply on the following:

apiVersion: cert-manager.io/v1
kind: ClusterIssuer
metadata:
name: letsencrypt-staging
spec:
acme:
  # The ACME server URL
  server: https://acme-staging-v02.api.letsencrypt.org/directory
  # Email address used for ACME registration
  email<EMAIL_ADDRESS># Update to yours
  # Name of a secret used to store the ACME account private key
  privateKeySecretRef:
    name: letsencrypt-staging
  # Enable the HTTP-01 challenge provider
  solvers:
  - http01:
      ingress:
          class: nginx

Anything else we need to know?:

When installing via helm with $ helm install cert-manager jetstack/cert-manager --namespace cert-manager   --create-namespace  --set installCRDs=true the operation fails with:
Error: INSTALLATION FAILED: failed post-install: timed out waiting for the condition

cert-manager logs
E1208 15:56:15.240251       1 leaderelection.go:334] error initially creating leader election record: leases.coordination.k8s.io is forbidden: User "system:serviceaccount:cert-manager:cert-manager" cannot create resource "leases" in API group "coordination.k8s.io" in the namespace "kube-system": GKEAutopilot authz: the namespace "kube-system" is managed and the request's verb "create" is den

cert-manager-cainjector pod logs
E1208 15:55:00.895304       1 leaderelection.go:334] error initially creating leader election record: leases.coordination.k8s.io is forbidden: User "system:serviceaccount:cert-manager:cert-manager-cainjector" cannot create resource "leases" in API group "coordination.k8s.io" in the namespace "kube-system": GKEAutopilot authz: the namespace "kube-system" is managed and the request's verb "create" is denied

Environment details::

Kubernetes version:

client v1.23.3
server v1.23.12-gke.100

Cloud-provider/provisioner: GKE
cert-manager version: 1.10.1 and 1.7.1
Install method: static manifests and helm

/kind bug
Do you have any suggestions how to proceed forward in debugging this case because I'm a little bit lost. Possibly I'm hitting more than one bug here or all of them are related to a RBAC misconfiguration?

I was able to successfully resolve/workaround the issue by:

removing cert-manager if it is present
run kubectl apply -f https://github.com/cert-manager/cert-manager/releases/download/v1.10.1/cert-manager.crds.yaml
run

helm install cert-manager jetstack/cert-manager --namespace cert-manager \
  --create-namespace --version v1.10.0 \
  --set global.leaderElection.namespace=cert-manager

This resolved all the errors. Big thanks to https://github.com/cert-manager/cert-manager/issues/3713 for the hints to overcome the helm installation blocker. CRDs needs to be applied on GKE Autopilot before installing cert-manager otherwise the helm chart doesn't succeeds.


Add support to search for Ordinals by text/namespace

From Ordiflow (https://ordiflow.com/)

One important feedback is, it would be great if you provide an API to search ordinals based on text/namespace (Eg: example.sats, 0.bitmap, example.x, example.unisat). Hiro API has the ability to fetch data based on inscription details but not based on the namespace. And hence I was forced to use unisat APIs for this scenario alone.

@sabbyanandan Thanks for adding this as a feature. I am the one form ordiflow. Request your team to add an API to search the ordinals data based on text/namespace. Eg: sabby.sats, 0.bitmap, sabby.x, sabby.unisat, sabby.btc. This should fetch the same result as like the inscription number or inscription ID APIs. This will be a very useful feature not only for me, but also for other API consumers.
So request your team to consider this feature, if possible.


Fix up docs for interface-over-type-literal rule

Noticed a few fields are overly brief / missing on this page: https://palantir.github.io/tslint/rules/interface-over-type-literal/
Would be nice to have a slightly longer rationale and fix up the examples so something shows up.

Fixed by #2170?


List of strings containing nulls is stripped of the null values before being sent through

This is the relevant part of my schema.
type Schedule {
        ...
	occurrences: [OccurrencesInADay]
        ....
}

input ScheduleInput {
	occurrences: [OccurrencesInADayInput]
}

type OccurrencesInADay {
	times: [String]
	timeUnit: Int
}

input OccurrencesInADayInput{
  times: [String]
  timeUnit: Int
}

upon building my ScheduleInput to be sent with the request, I add an ArrayList<OccurrencesInADayInput> which is populated with an ArrayList<String> for its ocurrences field. That array of strings contains some strings but also some nulls. Those nulls are stripped out when the actual request is being sent. I'm verifying this with the okhttp3 logging interceptor.
Is this a bug or am I doing something wrong? I need those null values to be there.

Hi all,
I can see this is still happening for, at least, the latest release v1.0.0-alpha5.
The data is driven by a schema that expects a List<List<String>>
{
    "name": "data",
    "description": "Formatted data",
        "args": [],
        "type": {
            "kind": "NON_NULL",
            "name": null,
            "ofType": {
                "kind": "LIST",
                "name": null,
                "ofType": {
                    "kind": "LIST",
                    "name": null,
                    "ofType": {
                        "kind": "SCALAR",
                        "name": "String",
                        "ofType": null
                    }
                }
            }
        },
        "isDeprecated": false,
        "deprecationReason": null
}

Backend response by using Postman clearly shows a list of string with null as part of it:
["Kids Armoires", "N/A", null, "N/A"]
Android Debug result with no data manipulation:
["Kids Armoires", "N/A", "N/A"]
Thanks in advance.
PS. @AndreiHarasemiuc   Is this still happening to you?


[2.1 TESTNET BUG] calling stack-aggregation-commit fails

Describe the bug
When calling stack-aggregation-commit for the next cycle on the 2.1 testnet we get a failed transaction. 5,200,106.00 STX are ready for that cycle which should be enough for this to work. Can you please tell me why this is erroring.

Steps To Reproduce
I have delegated my STX to ST21815DY1QZWV6NAPCDE54BMHE10WK8HB2QXBNDT the first round  of stacking was successful but we are running into the following error and I am not sure why this is failing
https://2-1-api.testnet.hiro.so/extended/v1/tx/0x2c0fe342f09fd0447d702e2497ef9720669e1dd68f2cf37166a0dbea4d2f165c?unanchored=true
@friedger can you add some additional context.

You might also want to include the method/scripts you used for constructing the tx.

The call was to pox, not pox-2

Is (err none) the expected behaviour?

@janniks isn't the 2-1-api.testnet.hiro.so testnet well into period 3, where pox (v1) is fully disabled?

(err none) I believe is expected when the blockchain is blocking the old contract. Will investigate what's going on with perdiod detection.

(err none) is expected in some cases -- not great for debugging...
When in Period 3, .pox calls will fail (as we're in a .pox-2 cycle)
How was the tx constructed (e.g. which @stacks/stacking version)? Using latest @stacks/stacking the best pox contract to use is determined automatically. And from a local test right now it seems to be working as intended.

The tx was created manually


RegisterFactory with Interceptors

Hi,
Since the InjectionFactory is deprecated, I am trying to use the RegisterFactory method.
I have registrations which use a factory and also have interceptor(s):
Func<IUnityContainer, object> factoryFunc = c => new FileSystemWithWaitAndRetry(
	new FileSystemService(container.Resolve<System.IO.Abstractions.IFileSystem>()),
	container.Resolve<ILogger>());

container.RegisterType<IFileSystemService>(
	createLifetimeManager(),
	new InjectionFactory(factoryFunc),
	new Interceptor<InterfaceInterceptor>(),
	new InterceptionBehavior(new ImpersonationBehavior(sSettings.ImpersonatorDomain, sSettings.ImpersonatorUsername, sSettings.ImpersonatorPassword, container.Resolve<ILogger>())));

(This is a service for filesystem access with a 'wait and retry' decorator. Interception adds impersonation)
How can the RegisterType be rewritten to RegisterFactory and still pass the InterceptionBehaviour?
Is the RegisterFactory method missing some functionality?
Thanks!

@ArnaudB88
This can be done with RegisterFactory, but you need to set up the interception proxy as part of your "factoryFunc", which is a bit messy
container.RegisterFactory<IFileSystemService>(c =>
    Intercept.ThroughProxy(
        new FileSystemWithWaitAndRetry(
            new FileSystemService(container.Resolve<System.IO.Abstractions.IFileSystem>()),
            container.Resolve<ILogger>()),
        new InterfaceInterceptor(),
        new[]
        {  new ImpersonationBehavior(
            sSettings.ImpersonatorDomain, sSettings.ImpersonatorUsername,
            sSettings.ImpersonatorPassword, container.Resolve<ILogger>())
        }));

I am open to suggestions on how to make it more elegant.

I'll have try and put together a pull request on the weekend

Would you like to discuss it first?

Is there any about this issue?
Is there an elegant way to RegisterFactory and still pass the InterceptionBehaviour?


[Feature-Request] Low quality, low bandwidth pointcloud for wireless communication?

Start with the why:
I want to be able to transmit the /oak/points (depthai_ros_driver pointcloud.launch.py) topic over the internet, so I want to configure the parameters in order to have the lightest pointcloud message possible; currently, there are problems in wireless communication for pointcloud messages with the default parameters.
Move to the what:
Is there a guide on which parameters I should tune to achieve this?

Hi, unfortunately ROS2 is known to have problems with large messages, what you could do to solve that message:

Check DDS Tuning information
There is a new point_cloud_transport package which might help
You could instead stream images and do the pointcloud computation on the desired device


ViewRootImpl(27543): ViewPostImeInputStage ACTION_DOWN

Error Logs
[+2467 ms] D/ViewRootImpl(27543): ViewPostImeInputStage ACTION_DOWN
[+1866 ms] D/ViewRootImpl(27543): ViewPostImeInputStage ACTION_DOWN
[+1005 ms] D/ViewRootImpl(27543): ViewPostImeInputStage ACTION_DOWN
[+2294 ms] D/ViewRootImpl(27543): ViewPostImeInputStage ACTION_DOWN

[√] Flutter (Channel master, 1.25.0-8.1.pre, on Microsoft Windows [Version 10.0.17134.1726], locale zh-CN)
    • Flutter version 1.25.0-8.1.pre at G:\Flutter\flutter
    • Framework revision 8f89f6505b (3 months ago), 2020-12-15 15:07:52 -0800
    • Engine revision 92ae191c17
    • Dart version 2.12.0 (build 2.12.0-133.2.beta)
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at F:\SDK\Sdk
    • Platform android-30, build-tools 30.0.1
    • ANDROID_HOME = F:\SDK\Sdk
    • Java binary at: E:\Program Files\Android3.5\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Users\Administrator\AppData\Local\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.6.5)
    • Visual Studio at G:\Flutter\visual studio
    • Visual Studio Community 2019 version 16.6.30320.27
    • Windows 10 SDK version 10.0.18362.0

[√] Android Studio (version 4.0)
    • Android Studio at E:\Program Files\Android3.5
    • Flutter plugin version 50.0.1
    • Dart plugin version 193.7547
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] Connected device (3 available)
    • SM A7000 (mobile) • 1827a73b • android-arm    • Android 5.0.2 (API 21)
    • Windows (desktop) • windows  • windows-x64    • Microsoft Windows [Version 10.0.17134.1726]
    • Chrome (web)      • chrome   • web-javascript • Google Chrome 88.0.4324.190

• No issues found!
Process finished with exit code 0

Click the input box, the soft keyboard is invalid

Hi @Luffys6
You are using a three months old version of Flutter.
Can you please upgrade a try again? If the issue persists, please provide your flutter doctor -v and a minimal reproducible code sample.
Thank you

flutter doctor -v

[√] Flutter (Channel master, 1.25.0-8.1.pre, on Microsoft Windows [Version 10.0.17134.1726], locale zh-CN)
• Flutter version 1.25.0-8.1.pre at G:\Flutter\flutter
• Framework revision 8f89f6505b (3 months ago), 2020-12-15 15:07:52 -0800
• Engine revision 92ae191c17
• Dart version 2.12.0 (build 2.12.0-133.2.beta)
• Pub download mirror https://pub.flutter-io.cn
• Flutter download mirror https://storage.flutter-io.cn
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
• Android SDK at F:\SDK\Sdk
• Platform android-30, build-tools 30.0.1
• ANDROID_HOME = F:\SDK\Sdk
• Java binary at: E:\Program Files\Android3.5\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Users\Administrator\AppData\Local\Google\Chrome\Application\chrome.exe
[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.6.5)
• Visual Studio at G:\Flutter\visual studio
• Visual Studio Community 2019 version 16.6.30320.27
• Windows 10 SDK version 10.0.18362.0
[√] Android Studio (version 4.0)
• Android Studio at E:\Program Files\Android3.5
• Flutter plugin version 50.0.1
• Dart plugin version 193.7547
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
[√] Connected device (3 available)
• SM A7000 (mobile) • 1827a73b • android-arm    • Android 5.0.2 (API 21)
• Windows (desktop) • windows  • windows-x64    • Microsoft Windows [Version 10.0.17134.1726]
• Chrome (web)      • chrome   • web-javascript • Google Chrome 88.0.4324.190

Hi @Luffys6
You are using a three months old version of Flutter.
Can you please upgrade a try again? If the issue persists, please provide your flutter doctor -v and a minimal reproducible code sample.
Thank you
1

You are using a three months old version of Flutter.
Can you please upgrade a try again? If the issue persists, please provide your flutter doctor -v and a minimal reproducible code sample.
Thank you

You are using a three months old version of Flutter.
Can you please upgrade a try again? If the issue persists, please provide your flutter doctor -v and a minimal reproducible code sample.
Thank you

Container(Row(TextField()))

You are using a three months old version of Flutter.
Can you please upgrade a try again? If the issue persists, please provide your flutter doctor -v and a minimal reproducible code sample.
Thank you

Container(Row(TextField()))

You can try the same mobile phone

You are using a three months old version of Flutter.
If you already upgraded to latest version and the issue persists, can please provide your flutter doctor -v and a minimal reproducible code sample? What you provided is not a valid Flutter code.
You can see https://stackoverflow.com/help/minimal-reproducible-example to learn how to create a minimal reproducible code sample.
Thank you


why java predict interface only support single thread

I want to use java predict interface(float[][] predicts = booster.predict(testMat);) in online service. But I found it just it does not support multithreading. Because synchronized used in predict process. Why lock the predict. Can I remove key word "synchronized".

Closed as duplicated of #3058.


Turn off automatic fullscreen for zones

Description of the new feature / enhancement
Hello,
When you drag and drop window to other zone it is getting automaticly maximized. You can avoid it by holding shift button.
It would be nice if there would be an option to maximize windows only when user drop them near the upper border of screen (just like it works in Windows 10 without zones).
Scenario when this would be used?
.
Supporting information
No response

Can you please clarify when does it happen? Any window gets maximized when it snapped to a zone, did I get it right? Do you use grid or canvas layout?
If you attach a bug report, it can help a lot.

@SeraphimaZ it is not a bug, it is just a new feature idea.
You propably misunderstood me, so let me explain it again:

When I drop any window anywhere inside zone, it gets maximized automatically.
When I dopy any window anywhere inside zone and hold shift key, then window keeps it original size.

I think that it would be nice to add option to turn off automatically maximizing. If user would turn on such option then there could be a way to maximize window inside zone by droping window near top edge of zone (like it is in default in windows).

@SeraphimaZ it is not a bug, it is just a new feature idea.

Misunderstood, sorry :)
Thank you for the idea!

This sounds like virtual monitor

Tracked via #279


Expose locked_outputs to users?

Description
Expose locked_outputs or basically a duplication of it to users, so they manually can lock some outputs they don't want to be consumed in transactions?
Having two methods like .lock_output(output_id), .unlock_output(output_id)  that add/remove this output id to/from the locked_outputs field of the wallet.
Motivation
For example one has a basic output with some metadata feature that one would like to keep and not consume in other transactions, then it would be nice if one can just call .lock_output(output_id), .unlock_output(output_id) to make it not available for transactions or later available again.
Requirements

Add  .lock_output(output_id) or .lock_output(output_id, "my precious metadata output".to_string()) and .unlock_output(output_id) which make outputs not or available to the input selection
Make sure that users don't mess up transactions and that https://github.com/iotaledger/iota-sdk/blob/8b55ee58ff725864e78ec8c1ddc154b95f54c9de/sdk/src/wallet/core/builder.rs#L276 isn't messing up user locked outputs

Open questions (optional)
Currently locked_outputs is a HashSet locked_outputs: HashSet<OutputId> that is automatically filled/cleared based on selecting inputs/transactions, if we allow to just unlock any output id there, users could mess it up (unlock outputs that are already used as inputs in txs) which could lead to conflicting transactions. And user defined outputs would be also removed automatically here https://github.com/iotaledger/iota-sdk/blob/8b55ee58ff725864e78ec8c1ddc154b95f54c9de/sdk/src/wallet/core/builder.rs#L276 if that's not changed.
Therefore it might make sense to create a new HashSet for user defined locked outputs to keep them separated. Or maybe a HashMap<OutputId, Reason> would be better? Then users could even specify a reason for what they locked an output. Reason could be an enum like this
pub enum Reason {
    // Used as input in a transaction.
    TransactionInput,
    // Locked by the user.
    Custom(String),
}

Then .lock_output(output_id, "my precious metadata output".to_string())
Are you planning to do it yourself in a pull request?
No.

As a simpler but not so convenient alternative, forbidden_inputs could be added to the TransactionOptions


Fix the description for pipeline start/end time

Explain that the start and end time must be either both empty or
both have values.
Pipelines can have empty start and end times to create the
pipeline; both must have values for the pipeline to execute.

Hi @bgold09, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (brgold). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


Align go.mod version with Kubernetes

Bump Go to 1.20 in go.mod

Pinging @pjbgf @AdamKorcz Looks like oss-fuzz is requiring Go 1.19 that will be EOL in a couple of weeks. Is there anything we can do to get Go 1.20 in the base image?

@stefanprodan You can do the same as here: https://github.com/google/oss-fuzz/blob/43ec92a9737b2d962a774de4bc646d6a9c1e6a7a/projects/istio/Dockerfile#L20-L24
Doing it in Fluxcd's Dockerfile will after all the Flux projects that OSS-Fuzz is fuzzing, or you can do it in source-controllers own build file.

Updated Go to 1.20 and now fails like this:
Building ./internal/controller/gitrepository_controller_fuzz_test.go.FuzzRandomGitFiles into FuzzRandomGitFiles
+ echo 'Building ./internal/controller/gitrepository_controller_fuzz_test.go.FuzzRandomGitFiles into FuzzRandomGitFiles'
+ compile_native_go_fuzzer ./internal/controller FuzzRandomGitFiles FuzzRandomGitFiles
/usr/bin/ld: /usr/bin/ld: DWARF error: invalid or unhandled FORM value: 0x25
FuzzRandomGitFiles.a(000020.o): in function `_cgo_cbcce81e6342_C2func_res_search':
cgo_unix_cgo_res.cgo2.c:(.text+0x32): undefined reference to `__res_search'
/usr/bin/ld: FuzzRandomGitFiles.a(000020.o): in function `_cgo_cbcce81e6342_Cfunc_res_search':
cgo_unix_cgo_res.cgo2.c:(.text+0x81): undefined reference to `__res_search'
clang-15: error: linker command failed with exit code 1 (use -v to see invocation)

Updated Go to 1.20 and now fails like this:
Building ./internal/controller/gitrepository_controller_fuzz_test.go.FuzzRandomGitFiles into FuzzRandomGitFiles
+ echo 'Building ./internal/controller/gitrepository_controller_fuzz_test.go.FuzzRandomGitFiles into FuzzRandomGitFiles'
+ compile_native_go_fuzzer ./internal/controller FuzzRandomGitFiles FuzzRandomGitFiles
/usr/bin/ld: /usr/bin/ld: DWARF error: invalid or unhandled FORM value: 0x25
FuzzRandomGitFiles.a(000020.o): in function `_cgo_cbcce81e6342_C2func_res_search':
cgo_unix_cgo_res.cgo2.c:(.text+0x32): undefined reference to `__res_search'
/usr/bin/ld: FuzzRandomGitFiles.a(000020.o): in function `_cgo_cbcce81e6342_Cfunc_res_search':
cgo_unix_cgo_res.cgo2.c:(.text+0x81): undefined reference to `__res_search'
clang-15: error: linker command failed with exit code 1 (use -v to see invocation)

This will fix it: https://github.com/google/oss-fuzz/blob/43ec92a9737b2d962a774de4bc646d6a9c1e6a7a/projects/istio/build.sh#L18-L19

Note that if the other Flux projects have not bumped their go.mod files to 1.20 then they would break.

I plan to update all Flux controllers to Go 1.20 today and release it with Flux GA this week.

@AdamKorcz here the PR https://github.com/google/oss-fuzz/pull/10597 Thanks


rust-peg dependency preventing v0.19.0 release

We can't release v0.19.0 of tendermint-rpc as it currently stands because of its dependency on unreleased changes in rust-peg. See https://github.com/informalsystems/tendermint-rs/blob/d1c887724603a7ff9d4033023356b0e194fe0b4d/rpc/Cargo.toml#L69
I originally pinned the dependency to this commit due to the need for https://github.com/kevinmehall/rust-peg/pull/245 to be released, but it's not clear when a new crate's going to be published.
As such, cargo publish fails for tendermint-rpc v0.19.0 at this point.
We have several options to solve this at present:

Strip out the query parsing entirely. This will also mean we'd need to remove the Tendermint RPC CLI, or at least the part of it that depends on query parsing. This option is probably the easiest and quickest in the short term.
Try to get rust-peg to work with its latest released version (v0.6.3 from July 2020). I'm least confident about this option.
Replace rust-peg with a stable version of a different parser, e.g. nom or LALRPOP. I'm relatively confident I could replace the parser, but it's probably going to take some time to figure out how to use a new parsing library.

Delaying the release is unfortunately not an option.
What's the definition of "done" for this issue?
When we can complete the v0.19.0 release: #854

Closed in #858


Canonical address length bumped to 54, max bumped to 64

I do not know why it is failing so many tests :((((((

I do not know why it is failing so many tests :((((((

There are multiple smaller issues, one is just formatting. Start by running the following commands locally:
./devtools/check_workspace.sh
./devtools/check_contracts_medium.sh
./devtools/test_workspace.sh

That should point you to the most obvious problems.

In packages/vm/src/imports.rs the line
let dest_ptr = create_empty(&mut instance, 50);

creates a region for the human address result. This is too short now. Change the 50 to 70 to make the tests pass. This is done 4x in the same file.

Ahh it is a wasm error with windows, I tried changing CONTRACT to directly reference hackatom_0.15.wasm but it says that the target windows is not yet supported so I am going to commit your suggestions as the tests will most likely pass on circleci, lets see

Ah, you are on Windows. Then this is a bit tricky. We support developing smart contracts on Windows (i.e. the guest), but not developing the cosmwas-vm (i.e. the host). This is because our Wasm backend (singlepass) does not support Windows yet.
Anyways, you can run cargo fmt directly to get rid of the formatting complains. Running it in the repo root will format the workspace. For the contracts you need to run it in ./contracts/xyz.

whoops, this time i need to look directly at circleci errors. let me fix that right now

And let invalid_bech32 = "bn93hg934hg08q340g8u4jcau3"; this is erroring because this address is successfully canonicalized (as it is in the right range) and it expects an error. so would this have to be increased in length as well?

Ok going to fix these last few errors today

This commit still does not fix the issue in the staking module, IDK why its throwing the 'VM error: RuntimeErr { msg: "Wasmer runtime error: RuntimeError: Error in guest/host communication: Region too small. Got 32, required 54" }', /root/cosmwasm/packages/vm/src/testing/calls.rs:136:49, let me try to look into it more though I guess haha

oh darn, this attempted fix actually failed more tests 😖

having issues with wsl for testing i am a trainwreck

I am struggling with these tests :///
starts I have are
const DEFAULT_MEMORY_LIMIT: Option<Size> = Some(Size::mebi(16));

this memory limit applied to a mock instance is somehow not enough for the staking contract to call with the new canonical address length?
and the other failures in the package vm are somehow related to the instantiated array
let source_ptr = write_data(&env, &[61; 33]);

which should be longer? im not good enough at rust to really understand them but I feel I was close haha
could I please get some assistance @webmaster128
sorry to bother, would really appreciate it,
thanks

Let's figure this out! Regarding the vm, I submitted suggestions that should help fix this up.

const DEFAULT_MEMORY_LIMIT: Option<Size> = Some(Size::mebi(16));

this memory limit applied to a mock instance is somehow not enough for the staking contract to call with the new canonical address length?

I don't think that's the line you want. That's the overall limit for the total size of an instance of a contract, and it should be plenty.
I think this is what you want to update:
https://github.com/CosmWasm/cosmwasm/blob/main/packages/std/src/imports.rs#L21
Looks like this is how much space will be allocated to store the canonicalized address, and with your changes it's too small.

Thanks so much for the patience and suggestions. I really appreciate it, probably wouldve taken me another year to figure this out.
Seeing all of the tests pass brings tear to my eyes 😂

Looks good to me. Thank you!
@uint anything to add?

Nope, looks good! Thanks for contributing, @lukerhoads!


ROX-19320: Use quay.io instead of docker

Description
docker.io is rate limited. We should switch to quay.io where possible.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change
CI
Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

/retest


Don't leak objects out of access policies when used in a computed global

The caching for our computed globals failed to account for whether
access policies are in effect, which could allow leaking of objects
that should not have been visible. Fix this by augmenting the cache
key.
A downside of this fix is that sometimes now we will generate two
identical computations of a computed global. This is probably fine for
now, since this is an important bug to fix, and 2 is still a lot
better than the N that it was without the cache.

Because it is intentionally opaque
On Mon, Feb 26, 2024, 19:41 Elvis Pranskevichus @.***>
wrote:

@.**** approved this pull request.
In edb/edgeql/compiler/context.py
https://github.com/edgedb/edgedb/pull/6926#discussion_r1503594539:

@@ -151,7 +151,10 @@ class Environment:
path_scope: irast.ScopeTreeNode
"""Overrall expression path scope tree."""

schema_view_cache: Dict[s_types.Type, tuple[s_types.Type, irast.Set]]

schema_view_cache: Dict[

   tuple[s_types.Type, object],

Why object and not Any?
—
Reply to this email directly, view it on GitHub
https://github.com/edgedb/edgedb/pull/6926#pullrequestreview-1902457857,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACTC7OGDG5NGWTG3WSBIU3YVVIYBAVCNFSM6AAAAABD3KW76WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMBSGQ2TOOBVG4
.
You are receiving this because you authored the thread.Message ID:
@.***>


feat: add max_retry_backoff option to job runner

A solution to #19 based on https://github.com/StructionSite/sqlxmq/commit/0489b5178ae01ae828c7cbe69d60f298e3e71cb2

This looks very useful. I have a sentinel job that performs some cleanup once a channel is empty. It does that with checkpoints but a long-running sentinel will end up with an absurdly high backoff as there is no option for linear retries. Looks like this PR would allow me effectively avoid using exponential backoff in the first place.
I wonder if @Diggsey has abandoned this project? PRs have been sitting for a long time despite very active GH activity...


Fix CMake SDL build for rlgl_standalone

The rlgl_standalone example depends on having glfw. On the SDL build, glfw is not embedded directly, so we'll have to link it.

@RobLoach @Peter0x44 thanks for the review, solution looks simple and good enough to be added.

Thanks for the review, both. Initially I had disabled it, and thought we could link it directly. Perhaps disabling it is the solution that more closely matches the other platforms workaround for this. I'll submit a follow up...
Also, Raysan5, I know you don't like maintaining these CMake files. Feel free to send a ping whenever you need a review.


Change reference to pandas object to Koalas object

Codecov Report

Merging #1186 into master will decrease coverage by 2.51%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1186      +/-   ##
==========================================
- Coverage   95.24%   92.72%   -2.52%
==========================================
  Files          35       35
  Lines        7105     7105
==========================================
- Hits         6767     6588     -179
- Misses        338      517     +179

Impacted Files
Coverage Δ

databricks/koalas/frame.py
93.74% <ø> (-3.27%)
:arrow_down:

databricks/koalas/usage_logging/__init__.py
24.32% <0%> (-72.98%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
50% <0%> (-50%)
:arrow_down:

databricks/koalas/__init__.py
78.72% <0%> (-6.39%)
:arrow_down:

databricks/conftest.py
92% <0%> (-6%)
:arrow_down:

databricks/koalas/groupby.py
89.6% <0%> (-2%)
:arrow_down:

databricks/koalas/namespace.py
86.06% <0%> (-1.52%)
:arrow_down:

databricks/koalas/plot.py
93.33% <0%> (-0.96%)
:arrow_down:

databricks/koalas/testing/utils.py
77.77% <0%> (-0.75%)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15a6406...46c74c8. Read the comment docs.


Updates initialization of Image(frame:) and fixes bug in Generate

@aleph7 I finally remembered why I had set the contents in the first place...
When creating an image from a filter like this the coordinates of the CIImage are {0, -h, w, h}, so setting a UIImage like this:
self.imageView.image = UIImage(CIImage: output)

Results in the image not showing up... i.e. since the original image data is placed -h the contents of the new UIImage are empty.

This still looks weird to me. Let's follow this SO answer: http://stackoverflow.com/questions/9094058/creating-uiimage-from-ciimage#9615090

@aleph7: amended this commit, not sure if that showed up for you


A minor problem in the bakery pbr

Since we moved to three.js to load the hdr map, we need more changes in the pbr material section that will be applied soon.

The coordinate mode of reflection textures does not match baked meshes.

The coordinate mode of reflection textures does not match current texture.

I found the problem and I'm trying to fix it. Generally, there have been problems from the past that Babylon has automatically fixed and ignored.


⚠ Bofrost.be has degraded performance

In e692f83, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1398 ms

Resolved: Bofrost.be performance has improved in fdf4fc6 after 9 minutes.


Remove extraneous prints

Closes #17
Let me know if there's something else you prefer I do :)

Sure, I can do that, although I have a vague concern there as well. Mostly because applications that use logging and have debug turned on may not expect or want (filesize / chunk size) messages printed, but I think it's a reasonable compromise. Maybe logging at debug with a named param to turn it off entirely?
I'll update this pr and you can let me know what you think :)

@ifedapoolarewaju I added an optional log_func constructor param, this way people can hand in whatever logging function they like :)
lmk what you think

LGTM, thank you for the PR!

Thankyou! Would it be possible to cut a new release so I can pull it into my project?

@richo is this a blocker for you? I'd prefer to add a bit more changes before doing a releasing. But please let me know if it's a major blocker for you.

Not a huge deal, I just applied this patch to the copy in my virtualenv, but it does mean anyone who downloads my software will get a ton of messages in their console.
So, it'd be nice but it's really not a huge deal. Feel free to do it when you're ready.

@ifedapoolarewaju I do releases for tusd and tus-js-client relatively often even after only few changes, so the people can easily upgrade their software. Otherwise it would take long until a new release is published and changes would not propagate so quickly. So I think a release is appropriate for this change :)

@richo @Acconut just FYI this change has been released in version 0.2.2


Axis labels cropped when labelInterpolationFnc creates longer label

I'm prefixing the Y Axis labels with a currency symbol and it's getting cropped off for the longer labels, as illustrated below:

I realise I can manually set the offset for that axis, but it feels clumsy.
Related, but more complex: #158.

Hi @jezmck 👋
In case this is still relevant here's a suggested solution.

Thanks @Arantiryo. I've long since moved on!


Add unit tests

This PR:

Adds more unit tests
Fixes previously made tests
Fixes few features that tests revealed broken

Added github workflow for build and running unit tests. Previously also added some missing functionalities and made tests for them.


[RFC]: improve README examples of stats/base/dists/degenerate namespace

Description
This RFC proposes to improve the README examples of the stats/base/dists/degenerate namespace package. Currently, namespace package READMEs only include minimal examples which are not particularly informative and do not showcase namespace functionality.
Historically, namespace examples were not given much effort due to the rapidly changing nature of the project; however, now that development and organization has settled, it would be good to revisit these packages and add proper examples to better communicate to users how to use namespace contents.
For those wanting to contribute to this issue, you can use the following steps:

Browse through the contents of the stats/base/dists/degenerate namespace and identify interesting functions and packages to showcase.
Update the example code block in the "Examples" section of the README for the stats/base/dists/degenerate namespace and open a PR.
When updating the README, examples should follow existing project conventions (e.g., ES5).
Examples may require functionality from other packages to help make examples more interesting.

Related Issues
None.
Questions
No.
Other
No.
Checklist

[X] I have read and understood the Code of Conduct.
[X] Searched for existing issues and pull requests.
[X] The issue name begins with RFC:.

I would like to work on this issue !!

I'd like to work on this issue


[Bug]: Combobox goes outside the view

Reproduction
https://stackblitz.com/edit/fls328?file=src%2FApp.vue
Describe the bug
When the combobox is at the bottom of the view (or more commonly: at the bottom of an AlertDialog or whatever) it can often "leave the window", and doesn't seem to use avoid-collisions to show on the right side

System Info
System:
    OS: macOS 14.1.2
    CPU: (8) arm64 Apple M1
    Memory: 101.98 MB / 8.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.10.0 - ~/.nvm/versions/node/v20.10.0/bin/node
    Yarn: 1.16.0 - ~/.node/bin/yarn
    npm: 10.2.3 - ~/.nvm/versions/node/v20.10.0/bin/npm
    pnpm: 8.15.4 - ~/Library/pnpm/pnpm
    Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
  Browsers:
    Chrome: 123.0.6312.58
    Safari: 17.1.2
  npmPackages:
    @vueuse/core: 10.8.0 => 10.8.0
    radix-vue: 1.5.3 => 1.5.3
    vue: 3.4.19 => 3.4.19

Contributes

[ ] I am willing to submit a PR to fix this issue
[ ] I am willing to submit a PR with failing tests

@maelp Thank for your reproduction 👍
Based on radix-vue docs you can limit available height to define scroll, but this is not the approach you are chasing.
I made a small fix on your repo where just added min-h-[100px] to PopoverContent component. reproduction.  This forces Radix-vue to recalculate position and place Content above our trigger.
@sadeghbarati Hello mate, I don't think this issue is valid to shadcn-vue repo, maybe need to update radix-vue docs, what do you think?

@romanhrynevych Hello Roman, sure, go ahead
I'm not familiar with FloatingUI stuff

@sadeghbarati @romanhrynevych any update on this? is there a way to fix this without having to introduce an arbitrary size limit?

hmmmm weird, I'd rather not use a large min-h, because otherwise if there's only a few options it will be "mostly empty" no? @sadeghbarati

I've been finding the same issue. In my case I found that adding a max height to the <CommandList> made it adjust its position e.g.
<CommandList class="max-h-[140px]">

I see that Radix Vue now has a dedicated ComboBbox component so I'm not sure if the idea is to replace this with that, or continue to use the Popover/Command for it?