basic auth wasm extension fails to load

Bug Description
We have a kubernetes application with nginx ingress controller 1.1.1 in default namespace that has basic auth enabled and services a backend service in same namespace.
Basic auth stops working as soon as we set peerauthentication to STRICT. curl to the endpoint with basic auth creds work, but browser times out (in STRICT mode). If we set peerauthentication to PERMISSIVE, both curl and browser can access endpoint using basic auth. (We don't use istio ingress gateway in our environment)
After looking at this issue, It seems basic auth with Istio is not supported OOTB. If I understand correctly, we need to install basic auth wasm extension to make it work.  I am not able to install this extension . It fails to load with below error.
Version
$ istioctl version
client version: 1.13.2
control plane version: 1.13.2
data plane version: 1.13.2 (23 proxies)

$ istioctl version --short
client version: 1.13.2
control plane version: 1.13.2
data plane version: 1.13.2 (23 proxies)

Additional Information
Tried to add basic auth wasm extension:
apiVersion: extensions.istio.io/v1alpha1
kind: WasmPlugin
metadata:
  name: basic-auth
  namespace: default
spec:
  selector:
    matchLabels:
      k8s-app: ingress-controller
  url: oci://ghcr.io/istio-ecosystem/wasm-extensions/basic_auth:1.12.0
  phase: AUTHN
  pluginConfig:
    basic_auth_rules:
      - credentials:
          - "YWRtaW46Y2hhbmdlbWU="

Seeing below error in ingress controller sidecar proxy
istio-proxy 2022-07-25T19:21:44.568851Z	debug	envoy filter	Updating filter config default.basic-auth
istio-proxy 2022-07-25T19:21:44.569789Z	critical	envoy wasm	Plugin configured to fail closed failed to load
istio-proxy 2022-07-25T19:21:44.569799Z	critical	envoy wasm	Plugin configured to fail closed failed to load
istio-proxy 2022-07-25T19:21:44.569808Z	critical	envoy wasm	Plugin configured to fail closed failed to load
istio-proxy 2022-07-25T19:21:44.569895Z	warning	envoy config	gRPC config for type.googleapis.com/envoy.config.core.v3.TypedExtensionConfig rejected: Unable to create Wasm HTTP filter default.basic-auth
istio-proxy 2022-07-25T19:21:44.569905Z	debug	envoy filter	Updating filter config default.basic-auth failed due to 2

peerauthentication is set to strict
$ k get peerauthentication -A
NAMESPACE   NAME      MODE     AGE
default     default   STRICT   43m

Backend service Ingress annotation:
    nginx.ingress.kubernetes.io/service-upstream: "true"
    nginx.ingress.kubernetes.io/upstream-vhost: [service-name].default.svc.cluster.local

nginx deployment annotation:
        traffic.sidecar.istio.io/excludeInboundPorts: "443"
        traffic.sidecar.istio.io/includeInboundPorts: ""

pods:
$ k get pods
NAME                                                 READY   STATUS    RESTARTS   AGE
default-http-backend-default-74d4bf74ff-bzs7z        2/2     Running   0          4d23h
default-http-backend-default-74d4bf74ff-pghts        2/2     Running   0          4d23h
default-http-backend-default-74d4bf74ff-vhshl        2/2     Running   0          4d23h
ingress-controller-default-747b75644b-zc99q   2/2     Running   0          4d3h
manager-console-7c8cf9d86-r9v7l               2/2     Running   0          4d23h

I can reproduce this with a invalid config, according to the demo and source code, looks like you parse a invalid config for that wasm filter?
2022-07-27T03:58:09.571482Z	warning	envoy wasm	wasm log: [extensions/basic_auth/plugin.cc:306]::configure() cannot parse plugin configuration JSON string: {"basic_auth_rules":{"credentials":["ok:test","YWRtaW4zOmFkbWluMw=="]}}
2022-07-27T03:58:09.571528Z	warning	envoy wasm	wasm log: [extensions/basic_auth/plugin.cc:282]::onConfigure() configuration has errors initialization will not continue.
2022-07-27T03:58:09.571531Z	error	envoy wasm	Wasm VM failed Failed to configure base Wasm plugin
2022-07-27T03:58:09.571956Z	critical	envoy wasm	Plugin configured to fail closed failed to load

Thanks @zirain - I fixed config. Here's correct config:
apiVersion: extensions.istio.io/v1alpha1
kind: WasmPlugin
metadata:
  name: basic-auth
  namespace: default
spec:
  selector:
    matchLabels:
      k8s-app: ingress-controller
  url: oci://ghcr.io/istio-ecosystem/wasm-extensions/basic_auth:1.12.0
  phase: AUTHN
  pluginConfig:
    basic_auth_rules:
      - prefix: "/"
        request_methods:
          - "GET"
          - "POST"
        credentials:
          - "YWRtaW46Y2hhbmdlbWU="

and I see basic-auth filter getting initialized:
istio-proxy 2022-07-27T17:28:17.279406Z	debug	envoy init	init manager Listener-local-init-manager virtualInbound<PHONE_NUMBER>616388656 initializing shared target FilterConfigSubscription init default.basic-auth

But when I try to access the url from browser, it does not prompt me for any credentials (same behavior with curl) . The request just goes through without any authentication. Am I missing some configuration?
istio-proxy ':status', '200'
istio-proxy 'x-powered-by', 'Express'
istio-proxy 'access-control-allow-origin', '*'
istio-proxy 'accept-ranges', 'bytes'
istio-proxy 'cache-control', 'public, max-age=0'
istio-proxy 'etag', 'W/"29566-181f39ca3d0"'
istio-proxy 'content-type', 'text/html; charset=UTF-8'
istio-proxy 'x-envoy-upstream-service-time', '2'
istio-proxy 'server', 'envoy'

After doing some more research, it seems basic auth wasm extension works only with istio ingress gateway. It's not designed to work with nginx ingress controller. Can someone confirm this statement is correct?

cc @kyessenov can you confirm that?

Hi @kyessenov - can we confirm basic auth wasm extension works only with istio ingress gateway and not with nginx ingress controller?

Yes, I wouldn't expect nginx to be able to run Wasm, but I don't follow nginx development. Istio relies on Envoy Wasm support.

this is working
`apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
name: sleep
spec:
hosts:

sleep.local.k8s
gateways:

sleep
http:

match:

uri:
prefix: /sleep
headers:
Authorization:
exact: "Basic YWRtaW46MTIzNDU2"
route:

destination:
host: sleep
port:
number: 5000
timeout: 3s

match:

uri:
prefix: /sleep
directResponse:
status: 401
headers:
response:
set:
Www-Authenticate: 'Basic realm="Authentication Required"'`

This is working
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: sleep
spec:
  hosts:
  - sleep.local.k8s
  gateways:
    - sleep
  http:
  - match:
    - uri:
        exact: /sleep
      headers:
        Authorization:
          exact: "Basic YWRtaW46MTIzNDU2"
    route:
      - destination:
          host: sleep
          port:
            number: 5000
    timeout: 3s
  - match:
    - uri:
        exact: /sleep
    directResponse:
      status: 401
    headers:
      response:
        set:
          Www-Authenticate: 'Basic realm="Authentication Required"'


Prevent duplicate event when anchoring reg or cred in multisigs

This PR fixes an inconsistency that occurs when a member of a multisig joins an anchoring event (for a registry creation or credential issuance/revocation) and when it's KEL already contains that event, resulting in a new event with the same anchor.
That situation can be easily replicated if the threshold of the multisig is less that the total number of members, and the last member joins with a time delay that allows the propagation of the event.
To fix that problem, the code now checks if the last event already has the anchor event and avoid creating a new event in the KEL.

In my opinion, we should try to reduce the amount of API-calls we do in each method. So I am wondering if there is a way to resolve this issue without adding an additional call.
What is the actual scenario here?

Member 1 creates the acdc, issuance and anchoring events.
Member 2 creates the acdc, issuance and anchoring events.
Member 3 does what exactly, also what happens when they do this thing?

I would expect keria to respond with HTTP 400 Bad Request if member 3 tries to create an inconsistent state.
Maybe member 3 can detect that the issuance is already anchored and it only needs to "import" the credential?

What is currently happening (as implemented in KERIA and Signify), for example when creating a Registry:

member 1 creates an anchoring event for the registry and sends exn to other members
member 2 receives exn from member 1, creates anchoring event for the registry and sends exn to other members
member 1 receives exn from member 2. Since it's the designated member, it verifies that signature threshold was satisfied, sends event+signatures to witnesses, collect witness receipts and distribute them among members. Finally creates the registry in db
member 2 receives  receipts, verifies threshold and creates the registry in DB.
member 3 receives receipts (KERIA) and creates the event in the KEL. Member 3 also receives the exn to join the registry creation (Signify) so it starts creating the anchoring event from its last event in the KEL that already have the anchor, so it ends up creating another event with the exact anchor information but in sn+1. It never receives enough signatures to validate the event and so it never creates the registry. Also its KEL has one event more than the other members.

For KERIA, the event that member3 is trying to create is valid. It would be tricky to make it aware of those edge cases automatically, but not imposible. I added the "check" at the client side for simplicity and also because it gives more control on the decision, but I know it's not the perfect solution. Every time we automate decisions, we'll find edge cases.
Regarding the additional API call, I also agree that we should reduce those, but it this case the client needs to get the latest status of the KEL to proceed correctly. It'd also face an extra call even if KERIA responds with 400 I think.

@rodolfomiranda Sorry for delay here. We are hitting this too. I think we will be able to end up in the same situation anyway if we are unlucky with the timing? What do you think? Is there a way to move this check closer to the DB transaction to avoid race conditions? I am not as familiar as you with the internals of KERIA.


mgear_dist: math nodes for Maya 2017 win64 are no loading

provably are not correctly compiled

@jdrese  also moving this one to 3.1

Thanks @miquelcampos
I will figure this out. When compiling on your side the nodes for Maya 2017 you still had VS11 instralled on your side?


fix: compose issues

I had problems running docker-compose in my MAC and i solved problems with these changes.

ui service change: for some reason, safe-wallet-web image has no contract types generated. (afterinstall is failing). I have adapted the command the fix the issue. (https://github.com/safe-global/safe-wallet-web/issues/2656)
As cgw and ui are using different ports and cgw has no enabled cors, i couldnt use compose without setting cors headers for the cgw. (in a different setup for production this might not be a problem so i dont create issue for this nginx change in cgw repo)

I have read the CLA Document and I hereby sign the CLA


Getting just validation errors messages - without whole error stack messages

How can I respond with proper JSON containing validator errors?
I'm using parseRequest middleware, the error I'm catching has proper status property for validation errors (400), but when I'm about to inform API consumer what exactly went wrong I have only the error message string with concatenated all errors messages in stack:
The \"newFloorPlan\" body parameter is invalid ({\"name\":\"string\",\"number\":0,\"width\":12,\"height\":12,\"backgroundImage\":\"string\",\"backgroundScale\":0,\"backgroundLocalNorthCoordinate\":123323,\"backgroundLocalEastCoordinate\":12})
JSON Schema validation error.
Data path: \"/backgroundLocalNorthCoordinate\"
Schema path: \"/properties/backgroundLocalNorthCoordinate/maximum\"
Value 123323 is greater than maximum 32767

I don't want to expose all the details to API consumer, I just need to expose input data errors, f.e:
[
  {property: "backgroundLocalNorthCoordinate", message: "Value 123323 is greater than maximum 32767"
]

Is it possible?

+1


Membership request

Hi, we are BioClub, a bio community space in Tokyo, Japan. www.bioclub.org
We have been operating since 2015, we are hosted by the FabCafe Tokyo (https://fabcafe.com/tokyo/).

Weekly community meetings
BSL1 Lab
BioHack Academy (in collaboration with the Waag Society) (http://biohackacademy.github.io)
Kids Summer Workshops
BioCamp 2018, 8-day workshop with SE-Asian artists, creators and scientists
Artist-in-Residence Programmes

Hello there did you want to add an entry for BioClub? The instructions to do so are here. If you submit a pull request I am happy to review your code for any errors and merge.


Handover

Hi @yroffin,
do you see a chance that you hand over that github repo and the npm package to me so that I can take care and maintain that?
bye Konne

@yroffin ⬆


Fix Answer Queue page (#89)

Will optimize to query the modals from the server on-demand rather than pregenerating them in a follow-up PR.

Ignore the CircleCI build error for now, since the repo doesn't have any CircleCI config file until #97 is merged.


Don't package up specs and feature tests

Tests aren't useful for end users of the gem, and excluding them from
the gem them reduces the size of the download.
Since bundler/bundler#3207 this has been the default for gems created
using bundler gem, and I've taken the code for excluding them from
there.

Thank you @iainbeeston! I've merged this as be67cbd91fa568757a86565ca786a4d74abc752d


(kubelogin) adding a new automatic package?

I would like to contribute an automatic package for kubelogin.
The maintainer is kind enough to offer 64 bit builds on github releases: https://github.com/int128/kubelogin/releases
Before starting the work, I would ask if this something your open to or should I maintain the chocolatey package in my own repo.

Sorry about the late response (this issue must have gone under my radar).
We are generally open to accepting new packages, as long as the package is up to our standards (as defined in the Contributing documentation )).
Just be aware that you (assuming you will be the one that submits the package to the repository) will still be considered the actual maintainer of the package, and will be responsible for fixing issues related to it (as a general note, we will step in when it is necessary to do so).

Great, I got side tracked myself. I'll get back to opening a PR.

will AU upload itself or do I have to create it?

It will handle it once you fix this error:
https://gist.github.com/choco-bot/a14b1e5bfaf70839b338eb1ab7f8226f#errors

hmm could I reuse the kubernetes logo? Kubelogin does not have one.

https://github.com/chocolatey-community/chocolatey-coreteampackages/blob/master/CONTRIBUTING.md#125-provide-icon

Could I be added as package manager for the kubelogin package? my profile: https://chocolatey.org/profiles/jetersen

We don't generally practice that as you can always PR here and we have single package authority.

sure thing, still learning. Just wanted to be able to see approval and the likes 😅

@jetersen you have been added as a maintainer for the kubelogin package.
You should have received an email with a link to confirm your addition.

Many thanks 🙇

Still awaiting approval, sadly means no choco install kubelogin joy 😓


test: add fixed identity to coredns for k8s 1.12

Signed-off-by: André Martins<EMAIL_ADDRESS>

This change is

test-me-please

The entities tests failed, which is fixed by #5792 and is not related to this PR. This PR fixed the issue it sought to fix, which is getting Cilium to work with etcd-operator in the CI with K8s-1.12. Merging.


Make log message splitting on colons optional

Is your feature request related to a problem? Please describe.
The Kivy logger treats everything in the message string up to the first colon as a label. This leads to unexpected/incorrect output in log messages that include colons in their text. Log messages with colons in them are very common, for example in networking.
from kivy.logger import Logger

Logger.info("MAC address is AA:BB:CC:DD:EE:FF")
Logger.info("Listening on <IP_ADDRESS>:8080")
Logger.info("Listening on [1:2:3:4:5:6:7:8]:8080")

outputs:
[INFO   ] [MAC address is AA]BB:CC:DD:EE:FF
[INFO   ] [Listening on <IP_ADDRESS>]8080
[INFO   ] [Listening on [1]2:3:4:5:6:7:8]:8080

Describe the solution you'd like
A boolean option added to the kivy.config.Config scheme named log_split_on_colon or similar that defaults to true would be fine. An environment variable control would also be nice.
Describe alternatives you've considered
The obvious workaround is to manually put a colon at the beginning of all logger strings:
Logger.info("Network: MAC address is AA:BB:CC:DD:EE:FF")

This is not feasible when using libraries where I don't control the log messages that just use the Python logging module. I'm aware that I can change the Kivy log mode, but I'd really like to keep all the (very nice) Kivy log message formatting EXCEPT the colon separation.
Thanks for considering!

I recommend against this.
Python's batteries-included logging system is a highly-customisable, highly-extensible standard. Kivy developers should avoid reproducing its functionality and duplicating its effort, rather than simply delegating to it.
If users want to customise the logging, they don't need to use Kivy configuration. They can use the standard logging system (which can even be reconfigured remotely while the app is still running).

In this case, use KIVY_LOG_MODE=PYTHON. Add the desired handlers to the root logger (see add_kivy_handlers() for an example of handlers you might like).
Don't use KivyFormatter, because it splits on the colon. Use your own handler which is similar but omits the ColonSplittingLogRecord call. The whole class should be about 8 lines of Python.


The connection to the ARM Template Language Server got closed.

Repro steps:

Action: Language Server Error
Error type: Error
Error Message: The connection to the ARM Template Language Server got closed.
Version: 0.7.0
OS: win32
Product: Visual Studio Code
Product Version: 1.39.1
Language: en

Call Stack
n.callWithTelemetryAndErrorHandlingSync.e extension.bundle.js:218:772819
Object.t.callWithTelemetryAndErrorHandlingSync extension.bundle.js:1:193147
WrappedErrorHandler.closed extension.bundle.js:218:772687
LanguageClient.handleConnectionClosed vscode-languageclient/client.js:2044:55
LanguageClient.handleConnectionClosed vscode-languageclient/main.js:127:15
closeHandler vscode-languageclient/client.js:2023:18
CallbackList.invoke vscode-jsonrpc/events.js:62:39
Emitter.fire vscode-jsonrpc/events.js:120:36
closeHandler vscode-jsonrpc/main.js:226:26
CallbackList.invoke vscode-jsonrpc/events.js:62:39
Emitter.fire vscode-jsonrpc/events.js:120:36
StreamMessageReader.fireClose vscode-jsonrpc/messageReader.js:111:27
Socket.readable.on vscode-jsonrpc/messageReader.js:151:46
Socket.emit events.js:187:15
Pipe._handle.close net.js:606:12

@slavizh Thanks for entering.  Unfortunately, the bug info doesn't tell us much.  Did this happen just once, or every time, or...?

It happened once so far. .Net Core service was also using too much memory as well. I thought that the trace was enough as basically the UI gave me option to open link and log this directly. Something like debug procedure.

We will have a fix soon for the memory usage issue, hopefully that will solve this.


Add support for the steelseries prime mini without the wireless capable

Hello, i want to introduce the add for the original steelseries prime mini without the capable to be wirless or wired because it stay always in wired mode :)
Idk how to call as name but i tested and is working fine
Best Regards,
NextWorks

Seem only having some issue with colors when i put at red it go green idk why

Have you a link to the exact product on the SteelSeries website (or an other site if no more available on SS website)?
I will try to get info about how colors are working on that device. We may have to implement a separate profile to fix color support :)

Prime Mini support was added in Rivalcfg v4.11.0 :)


Restructure the Windows app template

Description
This moves the app template more toward being a more generic starting
point for any Flutter application, eliminating some hard-code
assumptions about there being a single window/engine pair that is
directly bound to the life of the application:

Moves the runloop into its own class, making it capable of servicing
any number of engine instances.
Moves the logic for setting up a window containing only a Flutter view
into a window subclass for ease of re-use.
Makes quit-on-window-close an optional property. (Long term this
should be even more generic, like a quit-when-last-window-closes
option, but this is a short-term improvement that removes the binding
between the runloop and the window).
Allows for multiple instances of Win32Window to exist without issues
relating to the window class registration.

Since there are getting to be a non-trivial number of files associated
with the runner, this moves the source into a runner/ directory, as is
already done on some other platforms.
Note that creating multiple Flutter windows at the same time still
doesn't work correctly even with this change, but this addresses some of
the known issues, and makes it easier to test in the future (e.g., for
debugging engine-level issues with multiple instances).
Related Issues
Fixes #45397
Tests
I added the following tests: None
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I signed the [CLA].
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change.

Unfortunately win32_window.cc changed enough that it didn't get picked up as a move. The main change there is the WindowClassRegistrar.


Hide messages from deliberate malloc impl overflow test as they can be alarming

As a follow up to: https://github.com/numba/numba/issues/2833, see if the messages can be captured and silenced.

Hi, I am first time contributing to open source.  Can I wok on it?

@lalitparate hi, really great to hear you would like to contribute, thanks! I'm not sure how hard this task will be, it might just be a question of wrapping the call in numba.tests.support.caputured_stderr? If this turns out more challenging than anticipated then there are other good first issues that could be looked at.
As a new contributor, some instructions for getting set up for development are here and are a great place to start.
Thanks again!

Thanks @stuartarchibald ,
I will give it try. If it looks challenging to me I will call it out.
Thanks,
Lalit

Need Help.
@stuartarchibald  I tried wrapping the call in numba.tests.support.caputured_stderr however it didn't work.
I tried to find out reason why sterr is not getting captured. I found that the issue is in python
https://bugs.python.org/issue5614
This issue mentions
"The error is printed by libc, there's nothing we can do about that."
There are some solution floating around on internet, not tried it though.
https://dzone.com/articles/redirecting-all-kinds-stdout

@lalitparate Thanks for investigating this, I agree with your conclusion. Perhaps the best (and most likely to work consistently) thing to do is actually just print a message from that test to let the user know that this is in fact fine and the purpose of the test?


Added initial docs for architecture

Overview
Added some stub files for upcoming documentation

These need to be filled in to merge.  Can't accept empty docs, so lets keep the PR open till they are complete.

Why not? It's just a template. I'm working on the core docs but it's a lot of stuff.

Also I was planning on doing each area as it's own pr

These need to be filled in to merge. Can't accept empty docs, so lets keep the PR open till they are complete.

What about merging into a documentation branch? That would allow others to contribute as well (like we are doing for large features)

A separate branch would be good, to avoid putting "empty" stuff in the main dev branch

Need to move spatial docs into their own folder after this... Willing to make the change?

Sure! but I figured I'd make that change when we merge the this back into that branch.

re-targeted to new mrtk_development_documentation branch


Service Request by [Putnam County team(Jessica & Katy)] to edit date created on IPA (D1) in the tracker

[x] Qualtrics Service Request Form was received from User
[x] e-mail acknowledging that User's Qualtrics Service Request Form was sent
[ ] Problem NOT RESOLVED
[ ] Problem PARTIALLY RESOLVED
[ ] Problem FULLY RESOLVED and Issue is Closed
[ ] Qualtrics Post-Service Request Survey was sent to User

Use comments feature (below) to document:

A clear and concise description of the solution.

A clear and concise description of any alternative solutions or features you've considered.

Any additional context, such as screenshots about the problem.

Hi Jeff
I am kindly ask your help to review a case (D1) on behalf of Putnam county to see if we can we the date the strategy was created edited in the system from end.
Historical perspective:
Last week Putnam county team along with Jessica asked me to copy strategy D1 from OEND and move it to MOUD. When I did that it came over to MOUD as a new strategy in MOUD with a new Date Created  12/15/2021.
They have since asked if we can make a change to reflect the correct date created on their behalf. I am unable to edit the date created on my end. Would you be kind enough to help us out with this if possible.
I have attached screen shot #1  of what it looks like in the system as it stands and screen shot #2 of previously downloaded data of its correct history for your review.

From: Donrie Purcell<EMAIL_ADDRESS>Date: Thursday, January 13, 2022 at 3:04 PM
To: Jeff Bazinet<EMAIL_ADDRESS>Cc: Nicholas Bove<EMAIL_ADDRESS>David Lounsbury<EMAIL_ADDRESS>Subject: Putnam County MOUD Strategy D1
Hi Jeff
I am sending a gentle reminder to ask if you can kindly change the date created to 7/26/2021 for the PUTNAM county MOUD strategy D1.
Please see screen shot below:

Regards
Donrie Purcell, PhD, MPH
Every generation has the obligation to free men's minds for a look at new worlds,....to look out from a higher plateau than the last generation.
Ellison S. Onizuka
CONFIDENTIALITY: This email (including any attachments) may contain confidential, proprietary and/or privileged information. Any duplication, copying, distribution, dissemination, transmission, disclosure or use in any manner of this email (including any attachments) without the authorization of the sender is strictly prohibited. If you receive this email (including any attachments) in error, please notify the sender and delete this email (including any attachments) from your system. Thank you.

All set


Component Customization with Styled-Components Library

First off - great out of box feature for my starting app! The Readme looks like there needs to be more work done to it, and I just want to know if it possible to customize the components?
Following:

Disable picture counter on the bottom
Color of the nav buttons?
Modal background overlay color
and etc

Or was the expectation to directly use pure css customization?

@mdere-unbound if you're starting a new project, don't use this.
React View Pager is far better and easier to customise.
This package has been long abandoned by the original creator and I'm the only maintainer left. The code is a mess, and I've given up.

Ah thank you for letting me know right away. Appreciate it!

@mdere-unbound if you're starting a new project, don't use this.
React View Pager is far better and easier to customise.
This package has been long abandoned by the original creator and I'm the only maintainer left. The code is a mess, and I've given up.

If you have the rights to merge, can you put a warning that this project is not maintained anymore and suggest other libs ? Would be awesome :)

I'll do that! @TomPradat

React View Pager hasn't been updated in years either :/


When doing a Source Control "Open Changes" don't wrap past the end of the file on arrow click

When doing a diff in the source control change view, please do not wrap past the top or bottom of the file when the arrows are clicked. Just stop moving the cursor and optionally put a small notification somewhere about "top of file" or "bottom of file" or "no additional differences".  If no differences in that direction disable the arrow, too. Reenabled when the direction is changed.

/duplicate of 163331

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


[CARBONDATA-1737] [CARBONDATA-1760] [PreAgg] Fixed partial load issue if user has set segments to access on parent table

Analysis: Partial load was happening on pre-aggregate table when the user has set segments to access for the parent table.
Solution: Set segments to access to * before firing load for child table.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[x] Any interfaces changed?
No

[x] Any backward compatibility impacted?
No

[x] Document update required?
No

[x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Success with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/456/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1724/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/2106/

Build Success with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/487/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1751/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/2134/

Build Success with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/497/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1760/

retest this please

Build Success with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/509/

Build Success with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/512/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/2143/

LGTM

Build Success with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/516/

LGTM

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1772/


Python3 compatibility, add setup.py, fix tests, misc other bugfixes

I fixed some bugs and added a proper setup.py.
If you want, I can publish this package on pypi.
Changes:

restore python 3 compatibility
fix and move tests (calling without -m still doesn't work, but "setup.py test" does)
setup.py instead requirements
test integration in setup.py
.gitignore
install script (nice feature of setuptools)

Looks great, thanks for getting it to work with modern python!


Bug: Sleep command actually hibernates the PC

Describe the bug
The Sleep command actually hibernates the PC, which is very different and takes a lot more time to recover.
To Reproduce
I believe this is kinda self-explanatory, but:
Add a button like such:

Then press it from Home Assistant. Instead of sleeping, the computer will hibernate. At least mine does.
Expected behavior
To sleep, not hibernate.
Screenshots
N/A
Misc info (please complete the following information):

Windows build (ideally screenshot/info of winver.exe output):

Windows' UI language: Portuguese (Brazil)
HASS.Agent version: 2.1.0

Please check what's applicable (multiple answers possible):

[x] Installed via installer
[ ] Installed manually
[ ] Problem occurs in HASS.Agent
[x] Problem occurs in Satellite Service

Additional context
Sleeping the PC works fine through PowerShell using this:
# load assembly System.Windows.Forms which will be used
Add-Type -AssemblyName System.Windows.Forms

# set powerstate to suspend (sleep mode)
$PowerState = [System.Windows.Forms.PowerState]::Suspend;

# do not force putting Windows to sleep
$Force = $false;

# so you can wake up your computer from sleep
$DisableWake = $false;

# do it! Set computer to sleep
[System.Windows.Forms.Application]::SetSuspendState($PowerState, $Force, $DisableWake);

Logs
I could not find anything relevant in the logs.

Hmm, I'm not the author of that specific piece of code but:

It is interesting however that the winforms command works properly for you - I'll do some testing to see if it can be used but the SleepCommand is also "available" for satellite service where winforms might not work properly due to missing user context.

Oh. I wonder how come I completely missed that.
But I suppose this command can be refactored to simply call that PowerShell command, which works (even when called from Hass Agent using the PowerShell method).


[spi_device, dv] V2S signoff

Description
Get spi_device ready for V2S signoff and sign it off

DESIGN_DELTAS_CAPTURED_V2
List of commits since ES. The list has been compiled via:
git log Earlgrey-M2.5.2-RC0..HEAD hw/ip/spi_device/ hw/dv/sv/spi_agent/

All the commits covered in V1 sign-off have been taken out of the list.
Newer commits at the top:

ee5f4a1abf [sram_ctrl] Add readback feature

RTL change to SRAM

1f05782f8d [spi_device] Add CSB reset sync for outclk domain

RTL fix for unsafe reset timing

1fafdaf22e [dv] Spi_device CFG register Covergroup fix.

spi_device CFG register FCOV update according to RTL changes

07352ce012 [dv] TB fixes for timeouts

TB changes to reduce chances of timeouts

12f60880bd [dv] spi_device_scoreboard flash_status fix

TB flash status fix to allow RTL changes to be tested

8ebf451ed7 [dv] spi_device_pass_base_vseq backpressure fix

TB fix when there's backpressure and a TLUL read/write takes time until the response is accepted

a7dafe6ef6 [dv] Disable spi_device_intercept_vseq 'two_writes' option

Disable TB flash_status write combination which won't happen in SW

432200b06e [dv] spi_monitor fix:

spi byte and termination events won't fire for TPM since these are only used in flash_mode and flash side of RTL won't update on TPM being active.

84372e3bb6 [dv] spi_device_env_cfg: new Flag set by SCB on flash command

TB flag for VSEQs syncing

854377469f [spi_device] Track intercept_en along the read pipeline

RTL change which fixes the RTL not dropping the last 2-bit/4-bit/8-bit in a SPI command

dc848b3e2a [sram_ctrl,prim,rtl] Fix tlul_we -> ready timing path.
e5743c1e1d [spi_device,dv] Lower the reseed count for spi_device_ram_cfg
a937d7678a [spi_device] Replace prim_ram_2p_adv by prim_ram_2p_async_adv dependency

Prim replacement

df40ae5d62 [spi_device] Fix lint error

Lint error fix reported by Nuvoton

8295903d7e [bazel,autogen_hjson] Split C and rust header generation

Bazel change

30d7e787c7 Add the project name to the copyright header

header change across project

ec43583573 [dv] intercept sequence && intr_status stimulus update

TB changes to intercept sequence so reads/writes to flash_status won't only occur while the  SPI interface is idle

42dfffeb8c [dv] flash_status dynamically updated TB update

TB changes to model, exercise and test flash_status RTL changes

18b0cedda1 [dv] Remove phase argument from monitor's collect_trans

cleanup UVM monitors across project

5fe7bfed1a [spi_device] Match OE with the passthrough read pipeline data

RTL fix to sync sd_en_o with read_pipeline signals in passthrough mode

75cb3b901e [spi_device,dv] Generalise description of mem_cfg testpoint

testplan mem configuration amendment

67ffe9a61c [dv] fix spi_device dvsim output path

Double-variant module IT fix

13783951da [dv_doc] spi_device dv doc generic mod and 2P SRAM mentions removal

Doc cleanup

dd3395ee60 [dv] intr_state variable for predicted value

TB fix

cb1e8e8948 [dv] Read buffer watermark interrupt fix

TB fix

4f88e076ec [spi_device,dv] Split sim config into separate 1r1w and 2p versions
cf1d83ff97 [spi_device] Sign off for D2 and D2S
73b61d0b53 [dv] Update spi-device testplan for V1 sign-off.
aa8d343148 [dv] SPI Device testplan generic mode removal
fb0fae4971 [spi_device] Update the checklist for current state
f0490a55bb [spi_device] Remove abandoned TODOs

more RTL file cleanup

11f93a0879 [spi_device] Add missing not-X assertions for output ports
c0132295cf [spi_device] Explain the SRAM split and access

Doc change

3f6f08aa8b [spi_device] Add issue number for ignoring commands while busy
d1f4251212 [spi_device] Remove outdated TODOs

doc + RTL cleanup

ea60d5fd55 [spi_device] Add mechanism to reset the flash read buffer

RTL change to allow SW to flush read buffer

V3 checklist scoping:

X_PROP_ANALYSIS_COMPLETED: done
SIM_NIGHTLY_REGRESSION_AT_V3: nearly there (1/1101 failures), but not soak regressions run. To be on the safe side 1 week
SIM_CODE_COVERAGE_AT_100: 1 week of estimate effort
SIM_FUNCTIONAL_COVERAGE_AT_100: 1 week of estimate effort
ALL_TODOS_RESOLVED: 2-4 days of effort max
NO_TOOL_WARNINGS_THROWN: 1 day
TB_LINT_COMPLETE: Already satisfied

I would say a pessimistic estimate would be 1-week + 1 week + 1 week + 5 days = 20 days

CC @a-will

@andreaskurth / @rswarbrick I believe this issue can now be closed since the last spi-device (DV) PR has been merged on master?
If so #22473 could also be closed

I think I agree this is done (thanks!). To close the issue, could you push a PR that changes the status in spi_device.hjson (line 40).


aurelia-cli package importer

Intention

I'm submitting a feature request
Aurelia-CLI package importer is defined (by Rob) as

We are planning a package importer. The idea is that you install your package with npm and then you use the aurelia cli to import it into your project. At that point, the aurelia cli generates the correct configuration into the aurelia json file. We would like to make it customizable so that library authors can create custom import routines as well. For example, if you wanted to install Kendo but only wanted 5 controls and not the whole thing. The custom importer would be able to give the user that choice and then custom configure the aurelia.json based on that.

Since Monterey was planning to make a similar tool for its own consumption (to last until aurelia-cli can provide this functionality, Rob proposed to unite these two tasks by having Monterey team implement the package importer in the form of a PR to aurelia-cli project.
Rob will provide the specification for this project in the next section below

Package Importer Specification

Thank you @EisenbergEffect for writing this. My immediate comment: precisely as expected and really well written.
@JeroenVinke @Martonsegi Rob's spec appeared not a minute too soon, so please deal with this right away, as both aurelia-cli and Monterey (in that specific order) will get a huge boost from this component.
Note that Rob did not limit this to RequireJS module loader, meaning that Monterey can benefit even more than aurelia-cli.

Thats really great. One thing Id like to stress on top of Robs points is to embrace Aurelias dedication to make devs life easier. So not only the consumers but also the plugin Developers. As such the Workflow of writing, testing and authoring your work should be as smooth as possible. The work started over at Pacman is more than promising in that regards so this should definitely find its way over here too.

This is really a welcome change. Does it have an ETA at the moment?

@SuricateCan the au install and au import commands are in the Aurelia-CLI. A lot can be improved, but the initial implementation is there. You can use it like so: au install jquery

Thanks @JeroenVinke , thats great to hear.


Add support for .Net project detection

The starter project (https://github.com/redhat-developer/s2i-dotnetcore-ex sub dir app branch dotnet-6.0) gives the following results:
Anayze command:
Language:JavaScript Frameworks: Tools: Accuracy:68.18181818181817
Language:C# Frameworks: Tools: Accuracy:13.636363636363635
Language:Smalltalk Frameworks: Tools: Accuracy:13.636363636363635
Language:GCC Machine Description Frameworks: Tools: Accuracy:4.545454545454546

devfile command:
No devfile found to match

Not sure how to handle this kind of situation. Alizer's output looks correct. If you analyze the repo, it contains 15 javascript file, 17 css, 10 html, .... , 3 c#, 3 smalltalk .... so the output is correct as it uses the percentage of files found.
The problem is in devfile detection, it outputs a js devfile.
The only way is to follow the same path we did in component detection... to weight languages based on configuration files, if any. In this case there is c# config file so it would appear as first in list. WDYT?

Analyze seems to be different from what is displayed by GitHub
And yes if there is a .Net app configuration file we should consider it

Maybe they don't consider js files from lib folder (jquery ...) and they count .cshtml as c# file otherwise i don't have any idea about their numbers.
But .cshtml extension in language.yaml is
HTML+Razor:
  type: markup
  tm_scope: text.html.cshtml
  group: HTML
  aliases:
    - razor
  extensions:
    - ".cshtml"
    - ".razor"
  ace_mode: razor
  codemirror_mode: htmlmixed
  codemirror_mime_type: text/html
  language_id: 479039817

and there is no relationship with c#


iss: Fix Proton compatibility

This should address https://github.com/tsunamods-codes/7th-Heaven/issues/206 / https://github.com/tsunamods-codes/7th-Heaven/discussions/207
Issue also tracked downstream: https://github.com/dotaxis/7thDeck/issues/39
I'm not sure why, but when trying to use the canary installer on Linux, {userpf} is causing the Inno setup to fail and throw the following error:
Internal error: Failed to expand shell folder constant "userpf"

According to the Inno documentation, {userpf} will default to {localappdata}\Programs on older versions of Windows, and in my testing I found that to also be the case on Windows 10 22H2.
This PR switches out the use of {userpf} for {localappdata}\Programs which should functionally be the same, but does not fail to install on Linux with Proton 9.

Thanks a lot!


Header-Only-Version Internal Namespace

I've only been using this library for a couple of days (and enjoying it so far), but I ran into an issue during integration that I didn't see in a quick scan here on github. I wanted to use a header only version of the library for quick integration into an existing codebase, but ran into a bunch of 'identifier not found' compiler errors.
After a little bit of inspection, the problem seemed to be that the configure script removes the internal:: namespace labels from everywhere in the library, which causes most of the internal functions in the script to disassociate from their forward declarations.
For example, look at line_search_mt in more_thuente.hpp. This calls mt_step in several places, with no internal namespace prefix. When line_search_mt is correctly defined as being in the internal namespace, the compiler correctly infers that mt_step is also in the internal namespace. However, by killing the internal:: from the definition, the compiler won't be looking in the right namespace for its forward declarations.
Fortunately, I found an easy fix for this: remove the replacement of internal:: from the sed in the header-only-version part of the configure script, so that it reads as follows.
sed -e '1,/\[OPTIM_BEGIN\]/ d' $WDIR/src/"$dir_"/"$file_".cpp | sed -e "s|optimlib_inline|inline|" -e "s|optim::||" >> "$file_".hpp

This fell through the cracks with a recent update. Thanks for pointing it out.


terminate called after throwing an instance of 'dmlc::Error'

Clone code from this repo, build with USE_DIST_KVSTORE=1 in ubuntu:16.04 container, instance multi container, then run cmd bellow:
$ vim hosts
# two container can connect by ssh with no auth
<IP_ADDRESS>
<IP_ADDRESS>

# start training
$ python ../../tools/launch.py -n 2 --launcher ssh -H hosts python train_mnist.py --network lenet --kv-store dist_sync

i get the error as bellow:
[03:58:38] src/./zmq_van.h:123: there is no socket to node 11
terminate called after throwing an instance of 'dmlc::Error'
  what():  [03:58:38] src/van.cc:132: Check failed: (send_bytes) != (-1)

Stack trace returned 7 entries:
[bt] (0) /root/incubator-mxnet/python/mxnet/../../lib/libmxnet.so(dmlc::StackTrace[abi:cxx11]()+0x55) [0x7fc2f9929295]
[bt] (1) /root/incubator-mxnet/python/mxnet/../../lib/libmxnet.so(dmlc::LogMessageFatal::~LogMessageFatal()+0x28) [0x7fc2f9929d98]
[bt] (2) /root/incubator-mxnet/python/mxnet/../../lib/libmxnet.so(ps::Van::Send(ps::Message const&)+0x245) [0x7fc2fc420895]
[bt] (3) /root/incubator-mxnet/python/mxnet/../../lib/libmxnet.so(ps::Van::Receiving()+0x2cdb) [0x7fc2fc42501b]
[bt] (4) /usr/lib/x86_64-linux-gnu/libstdc++.so.6(+0xb8c80) [0x7fc32aeabc80]
[bt] (5) /lib/x86_64-linux-gnu/libpthread.so.0(+0x76ba) [0x7fc33229a6ba]
[bt] (6) /lib/x86_64-linux-gnu/libc.so.6(clone+0x6d) [0x7fc331fd041d]

Aborted (core dumped)
Exception in thread Thread-1:
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 801, in __bootstrap_inner
    self.run()
  File "/usr/lib/python2.7/threading.py", line 754, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/root/incubator-mxnet/tools/../dmlc-core/tracker/dmlc_tracker/tracker.py", line 366, in <lambda>
    target=(lambda: subprocess.check_call(self.cmd, env=env, shell=True)), args=())
  File "/usr/lib/python2.7/subprocess.py", line 541, in check_call
    raise CalledProcessError(retcode, cmd)
CalledProcessError: Command 'python train_mnist.py --network lenet --kv-store dist_sync' returned non-zero exit status 134

how can i fixed it?
thanks a lot

i think should run container with nvidia-docker, at lease so am i ,and i run mxnet with gpu


[build-script] Split the build-script-impl pipeline into two pipelines so I can put a build-script product pipeline in between.

This is where I am going to put the stage 2 swift. The reason why I need to do
this is that I need libdispatch, foundation, etc on Linux to use the stage2
compiler.

@swift-ci smoke test

@swift-ci smoke test


v_get_stored_proc_params.sql   invalid WHERE prolang = 100356

DDL includes the filter "AND prolang = 100356 "
This results in zero results as 100356 does not exists.
Confirmed with : "select * from pg_catalog.pg_language where oid = 100356"  >> No records returned.

Hi @simonB2020 , thanks for reporting this. We applied the fix, can you please check and let us know if you still see the issue.


DEV: Query Start Index and Mnemonic

Query Start Index and Mnemonic  - Validate Data Range and Queried Channels

Complete


feat: yafti: harden ramdisk

#697

modifying fstab in yafti is a bit scary :smile:
we should test this thoroughly, maybe even keep it in PR until we can run it through @girlpocalypse's new integration testing action

Mount points can be modified with systemd mount units without the need to touch fstab. See e.g. https://github.com/konstruktoid/hardening/blob/master/config/tmp.mount.


Supporting Tracing Contexts

There exists a need to support tracing in the Azure client libraries for Java. The existing proof of concept implementation is based on users providing their tracing context information via an explicit Context object that can be passed into service client methods, such that they are sent through the HTTP pipeline as appropriate (being transformed by a tracing-impl specific http policy).
For sync API, there does not appear to be a better way other than having the Context object be an explicit argument into the API, that is:
public Response<Setting> getSetting(int foo, Context context) { .. }

For async API, we could choose to use the Project Reactor subscriber context to accept these tracing details, rather than support an explicit Context argument. This has the benefit of there being one less argument for users to contend with, e.g:
public class ContextFlowTest {

    public static void main(String[] args) {
        ContextFlowTest test = new ContextFlowTest();

        String result = test
            .clientLibraryAPI("Hello, ")
            .subscriberContext(ctx -> ctx.put("TRACER_IMPL", "OPEN_CENSUS"))
            .block();

        System.out.println(result);
    }

    public Mono<String> clientLibraryAPI(String prefix) {
        // convert subscriberContext coming into this method into a Context
        Context context = ...;
        return serviceCall(prefix, context);
    }

    private Mono<String> serviceCall(String prefix, Context context) {
        ...
    }
}

Question One: Do we have explicit Context arguments into our async API, or do we use the subscriber context to receive arguments? Is it better for API consistency, or API brevity?
If the subscriber context approach is used, we should write azure-core utility code to transform the provided subscriber context into an azure-core Context, before sending that through the service interface API. I have prototyped this in #3734.
Question Two: As we design our APIs, where often we have a min / max overload pattern, if not many overloads, do we have Context be a core argument on all overloads, or is Context only present on the max overload? What if we introduce the "T with Response<T> 'overload'" pattern of having most methods returning just T - do we have a T overload that accepts Context, or is Context only an argument on the Response<T> 'overload'?

Question One: I lean towards using the subscriber context on async apis. I think in this case it's more a case of being idiomatic to the paradigm than enforcing arbitrary consistency. Even though they are in the same package, the async methods have their own expected behavior and customs, and it wouldn't be quite right to try to force async to conform to sync.
Question Two: I'm not too familiar with what exactly we're doing in the way of tracing, but I'd sort of default to having Context be available only on the max overload for Response and then we can add other overloads later as necessary. If we think tracing will be super common, though, we can have more overloads exposing it.

Closing as tracing has since been implemented and shipped in the August and September client library previews.


Allow specifiying pod and container security context

What type of PR is this?
/kind feature

What this PR does / why we need it:
Allows the kueue manager to run in more restriced namespaces.
Which issue(s) this PR fixes:

Fixes #874
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Allow specifying the manager pod and container security context instead of hardcoded values

Do I need to sign that CLA to merge this tiny merge request? Yes I'm doing this during work hours as part of our effort to harden our kubernetes deployments, but I'd really rather not bother our legal department with this.

Do I need to sign that CLA to merge this tiny merge request? Yes I'm doing this during work hours as part of our effort to harden our kubernetes deployments, but I'd really rather not bother our legal department with this.

I'm sorry, but any change requires a signed CLA. The good thing is that once you signed this CLA, you can send PRs to any Linux Foundation project, including kubernetes.

Alright, let me forward it to our legal department then.

/approve
/lgtm

/ok-to-test

I dont see how a change to the chart (which is probably not used in the test?) causes a test failure, so just going to try a retest.
/retest

It just looks like we have too many tests cases and we need to increase the timeout :)

Opened #888

Alright the CLA check passes.

Alright the CLA check passes.

Thanks for your contribution!

/retest


Null expiresOn for tokens?

Library

[ ]<EMAIL_ADDRESS>or<EMAIL_ADDRESS>[x]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>
Description
When can AuthenticationResult.expiresOn be null? I get this object back from handleRedirectPromise, acquireTokenSilent, etc.
const msalConfig: Configuration = {
  auth: {
    clientId: 'XXX',
    authority: 'https://login.microsoftonline.com/consumers/',
    postLogoutRedirectUri: `${window.location.origin}/logout`,
  },
  cache: { cacheLocation: 'localStorage' },
};

@k-mehta I have opened a PR for this, but as it is a breaking change we are looking for the right time to add it to the library. I will try to get this in as soon as possible.


Update README.md

Forgot to send as review, sorry for the duplicate dots!

Forgot to send as review, sorry for the duplicate dots!

No worries ^^


Oversized tray menu on high-DPI Windows

I tried the application on a Windows 10 laptop with a high-DPI display. The contextual menu on the tray icon is oversized:

The contextual menu in the app itself is fine.


Dummy PR(Not for merged)

Just for testing tide.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/label tide/merge-method-squash


build: prevent FILE_DEPENDS from being used

The FILE_DEPENDS option is used in exactly one location: swiftCore.
This prevention sets the groundwork for removing the option.
Dependencies should be tracked at the target level.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

CC: @Rostepher @edymtt @xiaobai

@swift-ci please smoke test

This looks good to me. We could also probably just delete this option entirely!

Yes, that is the plan for all the "deprecated" options.


fix(date-picker): month and year picker scroller

Closes #3785
📝 Description

Fixing the month/year UI sync bug.

⛳ Current behavior (updates)

The month and year were incorrectly updating due to a UI rectangle intersection error. This has been removed and the data is updated directly from the value attribute.

🚀 New behavior

Please describe the behavior or changes this PR adds

💣 Is this a breaking change (Yes/No):
No.
📝 Additional Information

Summary by CodeRabbit
Summary by CodeRabbit

New Features

Introduced the AccordionTree component for hierarchical data representation.
Added an aria label for the month/year picker toggle button to enhance accessibility.

Bug Fixes

Improved user interface and data synchronization for the month/year picker component.

Refactor

Simplified scrolling behavior and focused date management in the calendar picker component.

Chores

Updated versions for @nextui-org/accordion and @nextui-org/calendar packages.
Added a new test case for the month and year picker functionality in the DatePicker component.

just keep one changeset file where no accordion is mentioned

Is that correct now?

Please suggest an alternative way to mark this component so the test can
find it.
On Wed, 25 Sept 2024, 14:04 աӄա, @.***> wrote:

@.**** requested changes on this pull request.
In packages/components/calendar/src/calendar-header.tsx
https://github.com/nextui-org/nextui/pull/3789#discussion_r1775134096:

@@ -99,6 +101,7 @@ export function CalendarHeader(props: CalendarHeaderProps) {
return showMonthAndYearPickers ? (
<Button
{...headerProps}

 aria-label={monthAndYearPickerToggle}

we don't hardcode aria-label internally. We can take it from users' side
tho.
—
Reply to this email directly, view it on GitHub
https://github.com/nextui-org/nextui/pull/3789#pullrequestreview-2328101810,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BBL2M6NRIQAJMCWW6L6TKF3ZYKYEDAVCNFSM6AAAAABOU7COTKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMRYGEYDCOBRGA
.
You are receiving this because you were mentioned.Message ID:
@.***>

In the test, you can simply get the element by container.querySelector("[data-slot='header']")

Please include the content of this comment in the PR description.
https://github.com/nextui-org/nextui/pull/3789#issuecomment-2367949681

@buchananwill please click re-request review once it's ready for review.

I had one more idea, which I've added. The PickerItems now also have a keyUp listener, which just calls the scrollIntoView function. This seems to be a bullet proof way of ensuring that if you've been holding down any of the directional keys, then whatever was the last key to fire (and thus has focus) is scrolled to the desired position.
I have to confess my weaker experience with writing imperative DOM events, so please if anyone with that could ponder whether this broad-brush fix could have any unexpected side-effects?
I also changed the home/end values of the keyDown event to 1 and 12, since months are 1-indexed, not zero indexed. These buttons don't work for the year picker, since 1 and 12 aren't valid years within the available range. Couldn't see an obvious way to pass in the max/min years that would be dynamically set (since it could vary with locale etc.).
Hopefully this wraps up the functionality of this component & hook?

The Home/End keys seem to already function in the original implementation. Where did you find the information about the month's index?

I also changed the home/end values of the keyDown event to 1 and 12, since months are 1-indexed, not zero indexed. These buttons don't work for the year picker, since 1 and 12 aren't valid years within the available range.

I added two additional hooks to cover the different behaviours needed for the different navigation keys:

Home/End use a deferred focus that only triggers when the scroll ends. Otherwise, the focus event overrides the scrolling, and the element immediately snaps into view.
Home/End also use a repeated key blocker, to prevent the value from receiving more than one update from these keys, since
a. repetition of this event is meaningless
b. it was playing havoc with the other scrolling/focus events/behaviours.

If you have existing hooks with the required API already in the codebase, feel free to swap them in. Equally, feel free to migrate them to a different (generic) hook folder if you want to centralize them for other scenarios to use.
I can't find any more bugs in this component.
On a side note, I prefer the simpler version where home/end cause the instant scrolling. I get that this is a minor inconsistency in the style of the UI, but the two extra control flow checks to defer the focus update and block repeat key strokes seems overly convoluted. I wouldn't be surprised to find it has negative performance implications or introduces other bugs on different systems from my own...
Let me know what you think! :-)

On a side note, I prefer the simpler version where home/end cause the instant scrolling. I get that this is a minor inconsistency in the style of the UI, but the two extra control flow checks to defer the focus update and block repeat key strokes seems overly convoluted. I wouldn't be surprised to find it has negative performance implications or introduces other bugs on different systems from my own...

This seems to be a separate issue from the current one. If you'd like to address it, please open a new issue for further discussion.

Any updates on this PR?


[LAYOUT FIX]: Documentation - Free Text and Voiceovers only

UI is completed for Lab, Medication, Documentation (Free Text and Voiceover only)!
API for Lab, Medication, Documentation (Free Text and Voiceover) is remaining

[REQUEST]: Pull this repository


Wrong test in Triangle exercise

Hi,
I think I've noticed a mistake inside the Triangle test suit:
test "triangles violating triangle inequality are illegal 2"
     (assertEqual (Err "Violates inequality") (triangleKind 2 4 2))

This one is a flat triangle and doesn't violate the inequality.

Yeah, it's a degenerate triangle, but doesn't violate the triangle inequality. We've had a huge discussion about this not too long ago:
https://github.com/exercism/x-common/issues/202
I think maybe this test suite got added sometime in the middle of that confusion, and didn't get fixed with the others.
Would you be willing to submit a patch that fixes it?

Sorry for just jumping in here but I felt like doing this so I am working on it. I hope that is ok.


Not Connecting from our server

We have php console installed via composer on  a standalone domain on our server (no wordpress or similar application).  Basically we have an app that is making calls to a php file, and in that php file we want to initialize the php console.  However, we can't get it to send the request to authenticate and establish a connection.  Right now we're testing our app in chrome from desktop (the app is currently web languages)
Here's our initialization code.
require DIR . '/vendor/autoload.php';
$connector = PhpConsole\Connector::getInstance();
PhpConsole\Helper::register();
$connector->setPassword('123456', false);
$connector->getDebugDispatcher()->dispatchDebug('ok');
PC::debug("our stuff");
What are we doing wrong?

Note: we're not getting the PC::debug message at all, but there are no errors in the error_log.

And does it works on http://php-console.com/instance/examples/features/debug_vars.php?

Yes, it works there. Everything is up to date, and we're using the standard version of Chrome.

What is URL of your local server? What is web-server?

Do you see authorization icon?

Url is phonebook.mp0studios.com
Web server is Linux, CentOS 6.
We don't see that link.

I need URL to the PHP script with activated php-console :) There must be icon like this http://i.imgur.com/RrE80zy.png

phonebook.mp0studios.com/pb.php
We don't see that icon when we go to the script.

It works for me http://i.imgur.com/SXldzCi.png What is your OS and Chrome version?

Okay, we checked the console there and you're right it works, but it doesn't work when we call the php script via Ajax.

Os is windows 8.1.  Chrome is 44.0.2403.89 m. Php console is 3.0.35

We attempted to instantiate the pc debugger inside of one of our ajax calls, one that we know is being called on initialization; we also attempted to simply call PC::debug within the ajax call with all of the initialization still globally declared at the top of our file but all to to no avail.

the main file we load is an html file which calls all of this on the server, however most of the templates and javascript code is hosted locally (that includes the html file mentioned previously).

Okay, so we tried uploading all our files (index.html, main.js, style.css) to the server where the pb.php file is that initializes the php console.  It works in that environment.  So, the fact that our test files are local to our desktop is the issue.  While the files were on the server, i changed our ajax call between jsonp and json, neither broke the console there.  So, for some reason, if our html and js files are local, calling a php file on a server, then the php console won't initialize.
Hope this helps you find a solution.

We have an html file and a js file that I can send you to download and run locally (it'll do the ajax request to a php file on our server that initializes the php console and tries to do a PC::debug call.)  We don't see the php console icon or get any output to the console.

Also, just to check, I put our test files all on a local WAMP server to see if that worked, and it still will not work in that context either.  I'm at a loss for what's going on.  We really need to be able to test and debug locally, as that is the closest to how the app will be running when it's live.

@TheEmberLeader Please send this files on<EMAIL_ADDRESS>

Here is one thing: php-console extension listener becomes activated for some tab when php-console-server cookie is detected in the response headers of this tab. That means that it will handle only requests from some domain/subdomain.
There is some very tricky way how I can fix it, but it will take some time.
What I can recommend for now, is just to put HTML file on the same domain as PHP file.

Okay, so that issue is just duplicate of https://github.com/barbushin/php-console/issues/54
If you're interested when it will be fixes, just subscribe on https://github.com/barbushin/php-console/issues/54 and you'll get notification.

Thanks, I wasn't aware of this issue.  Though I'm curious why it didn't work on a local WAMP server either.  Anyway, in-case it helps, I sent the files.


minimumpizza.py

@yashigupta4623 please add it in a specific python folder

@dixitt5 I have added them in codechef folder as they are codechef's solution


how to Install MMDetection.

I am really inspired by your work. can you please help me out on how to Install MMDetection? or do we only need to install mmcv?

Thanks for your appreciation of our work. You need to install MMCV first. It is recommended to use version 1.4.8. After that, run the following commands to install MMDetection:
   cd MPEblink
   pip install -v -e .

Thank you @wenzhengzeng for the reply. This is the version I have installed for mmcv and mmdet as you mentioned.

but this is the error I am getting now.
Traceback (most recent call last):
File "./scripts/feature_extraction/dvlog/extract_blink_patterns.py", line 14, in
from mmdet.apis import init_detector
File "/palashm/multimodal-depression-from-video/scripts/conda_envs/feature_extractors/MPEblink/mmdet/apis/init.py", line 2, in
from .inference import (async_inference_detector, inference_detector,
File "/palashm/multimodal-depression-from-video/scripts/conda_envs/feature_extractors/MPEblink/mmdet/apis/inference.py", line 7, in
from mmcv.ops import RoIPool
File "/opt/conda/envs/instblink/lib/python3.7/site-packages/mmcv/ops/init.py", line 2, in
from .active_rotated_filter import active_rotated_filter
File "/opt/conda/envs/instblink/lib/python3.7/site-packages/mmcv/ops/active_rotated_filter.py", line 10, in
['active_rotated_filter_forward', 'active_rotated_filter_backward'])
File "/opt/conda/envs/instblink/lib/python3.7/site-packages/mmcv/utils/ext_loader.py", line 13, in load_ext
ext = importlib.import_module('mmcv.' + name)
File "/opt/conda/envs/instblink/lib/python3.7/importlib/init.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
ModuleNotFoundError: No module named 'mmcv._ext'

I guess maybe there is some incompatibility (e.g., CUDA version). So please refer to the master branch of the MMCV installation documentation, then choose the correct command based on your actual environment.

If this is truly the cause, don't simply replace the old one; uninstall it first.
   pip uninstall mmcv
   pip uninstall mmdet

Besides, to seek other possible solutions, you can also refer to the MCGaze project, whose environment also inherits from InstBlink.


Unable to open reforge screen when using chipped or damaged anvil

Issue: can't access reforge screen using chipped or damaged anvil.
Steps to reproduce:

Use Minecraft 1.18.2, Fabric loader 0.14.19, Fabric API 0.76.0, cloth config 6.3.81, tieredZ 1.1.1.
attempt to use the reforge screen on a chipped or damaged anvil.
observe that the screen closes itself.

I can't use libZ on 1.18.2 as the 1.19 version is the only one available on curseforge. I think that may be the fix to my issues.

This got fixed in a later version.


Table: fixed  loading icon not display

Please make sure these boxes are checked before submitting your PR, thank you!

[x] Make sure you follow Element's contributing guide (中文 | English | Español | Français).
[x] Make sure you are merging your commits to dev branch.
[x] Add some descriptions and refer relative issues for you PR.

Closes #15817

loading icon not display through i updated to 2.9.2


Remove deprecated ActionMailer deliver & deliver!

These methods were deprecated in Rails 4.2 (see f4ee1147) so they can be safely removed in Rails 5.0.

Cherry picked the commit. Thanks

Since you're already working on this branch, I won't make any other changes.
I'm only sending you this one because I had already written it… feel free to do what you want with it! :grin:


[Draft] Overview detail

[ ] fix secondary axis use-case!

=> should be showing "yaxis data" & "yaxis2 data" in the first overview, "yaxis7 data" and "yaxis8 data" in the second overview


Honor aws.protocols#<protocol>.{http,eventStreamHttp}

Example for restJson1: https://awslabs.github.io/smithy/1.0/spec/aws/aws-restjson1-protocol.html#aws-protocols-restjson1-trait

Clients SHOULD pick the first protocol in the list they understand when connecting to a service. A client SHOULD assume that a service supports http/1.1 when no http or eventStreamHttp values are provided.

Note we can't prevent server SDK users from running their server in a configuration that violates the Smtihy spec (e.g. a user could run a @restJson1(http: ["h2"]) model in a Hyper server with the http2 feature flag disabled), so these connections would be established. However, we can reject the request upon inspection of the start line, preferably by wrapping the entire service in a ValidateRequest tower_http middleware.


feat: Add imagePullSecrets to support amundsen private images

Summary of Changes

Added imagePullSecrets option to Amundsen images to support pulling from a private repository.
Documentation

Added references and example for using imagePullSecrets to values.yaml
CheckList
Make sure you have checked all steps below to ensure a timely review.

[X] PR title addresses the issue accurately and concisely, including a title prefix.
[X] PR includes a summary of changes.
[X] My commits follow the guidelines from "How to write a good git commit message"

@feng-tao I had two questions on this one.

In regards to the readme , I was unable to generate with helm-docs to match the current readme.md  against master prior to my changes. TLDR; missing the longer descriptions on keys. Are there certain flags I should be passing or a specific version I should be using?
Moving forward with this idea, do we think it would be a value add to rework the image details into a map which I have seen as a pattern. IE:

image:
  repository:
  tag:
  pullPolicy:
  pullSecrets: <have seen this separate and included in map>

Anyways the second is just to get your thoughts however the helm-docs issue is something I want to get fixed up prior to merge.

I am actually not sure. tag @javamonkey79 who contributed the helm chart

@joeybaer

Are there certain flags I should be passing or a specific version I should be using?

I've just checked my command history, and it does not appear there are any flags on helm-docs that I ran. My version of helm-docs is 0.9.0 and my helm client version is 2.14.3.

Moving forward with this idea, do we think it would be a value add to rework the image details into a map which I have seen as a pattern. IE:

Sure. I would advise taking a look at other open source charts and seeing how they do it, if you haven't already (it sounds like you have). If moving image details to a map adds value for you and\or makes the chart easier to use, I'd say go for it.
Thanks for your contributions, thus far. I look forward to seeing the finished work.

@javamonkey79 thanks for your input , as far as reworking the images to objects, I am going to leave that for now just because the value add isn't strong enough imo to warrant work for end users.
I did however update the values.yaml to support the latest release of helm-docs which includes some updates to the readme outside of changes here just due to some drift in updates and the readme table being updated.


Enable drivers for mimxrt595 evk

Enabled I2C, spi, dma, counter, wdog, flash storage for mimxrt595.

@hakehuang can you test suite on this PR?

@hakehuang can you test suite on this PR?

@dleach02 , test is running will feedback once ready

Updated the PR per review comments and resolved the conflicts in wdt_basic_api/testcase.yaml


Load existing certs from pkcs12 store

Summary

When writing a pkcs12 key store, we read first the existing certificates like done in the jks case. The implementation did remove any existing certs before.
Upport of https://github.com/paketo-buildpacks/libjvm/pull/344
Use Cases

The keystore provided by the JRE already contains some certificates.
Checklist

[X] I have viewed, signed, and submitted the Contributor License Agreement.
[X] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[ ] I have added an integration test, if necessary.
[X] I have reviewed the styleguide for guidance on my code quality.
[X] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@dmikusa can you merge this as well? Same PR as #344, but targeting the release-2.x branch instead.


Remove use of Children.map in favor of an alternative approach

https://react.dev/reference/react/Children#alternatives

Should consider a render prop or children as function pattern. This would leave the hook only responsible for working with strings and not a react tree.


awscli2: 2.9.8 -> 2.9.10

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for awscli2 is: "Unified tool to manage your AWS services"
meta.homepage for awscli2 is: "https://docs.aws.amazon.com/cli/latest/userguide/install-cliv2.html"
meta.changelog for awscli2 is: "https://github.com/aws/aws-cli/blob/2.9.10/CHANGELOG.rst"
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.9.10 with grep in /nix/store/c37jd8f99dlb4y536yqq3r5ndv7y7yjq-awscli2-2.9.10
found 2.9.10 in filename of file in /nix/store/c37jd8f99dlb4y536yqq3r5ndv7y7yjq-awscli2-2.9.10

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
awscli2
liquidsoap

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/c37jd8f99dlb4y536yqq3r5ndv7y7yjq-awscli2-2.9.10 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A awscli2 https://github.com/r-ryantm/nixpkgs/archive/927a44f5cf589852c70c1389f41034e5f1974c39.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/c37jd8f99dlb4y536yqq3r5ndv7y7yjq-awscli2-2.9.10
ls -la /nix/store/c37jd8f99dlb4y536yqq3r5ndv7y7yjq-awscli2-2.9.10/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

awscli2
liquidsoap

Maintainer pings
cc @bhipple @davegallant @bryanasdev000 @devusb @anthonyroussel for testing.

Result of nixpkgs-review pr 207700 run on aarch64-darwin 1

1 package marked as broken and skipped:

liquidsoap

2 packages built:

awscli2
darwin.builder