Recovering from network failures

I cannot proceed to the initial installation because the installer reports that the Git for Windows installer is corrupted :
The Git for Windows installer was corrupted. You will need to retry the installation. If this repeatedly occurs,
please send an email to<EMAIL_ADDRESS>Au caractère
C:\Users\yann\AppData\Local\Temp\7zC98A7834\sg\network-ocamlcompiler\windows_x86_64\setup-userprofile.ps1:658 : 13
+             throw "The Git for Windows installer was corrupted. You w ...
+             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (The Git for Win...port@diskuv.com:String) [], RuntimeException
    + FullyQualifiedErrorId : The Git for Windows installer was corrupted. You will need to retry the installation. If
    this repeatedly occurs, please send an email to<EMAIL_ADDRESS>
FATAL [a0d16230]. A transient failure occurred.

Root cause: The conformant command had exit code 1:
                                           C:\Users\yann\AppData\Local\Temp\7zC98A7834\sg\network-ocamlcompiler\windows_x86_64\setup-userprofile.bat
                                             -AllowRunAsAdmin
                                             -InstallationPrefix
                                             C:\Users\yann\AppData\Local\Programs\DISKUV~1
                                             -MSYS2Dir
                                             C:\Users\yann\AppData\Local\Programs\DISKUV~1\tools\MSYS2
                                             -OpamExe
                                             C:\Users\yann\AppData\Local\Programs\DISKUV~1\bin\OPAM-R~1.EXE
                                             -DkmlPath
                                             C:\Users\yann\AppData\Local\Temp\7ZC98A~1\sg\NETWOR~1\WINDOW~1\dkmldir
                                             -GlobalCompileDir
                                             C:\Users\yann\AppData\Local\Temp\7ZC98A~1\sg\STAGIN~1\generic
                                             -NoDeploymentSlot -DkmlHostAbi
                                             windows_x86_64 -TempParentPath
                                             C:\Users\yann\AppData\Local\Temp\PA319F~1
                                             -SkipProgress -SkipMSYS2Update
                                             -ImpreciseC99FloatOps

>>> A transient failure occurred. <<<

dkml-package.bc: [ERROR] FATAL [5f927a8b].
                         A transient failure occurred.

                         Root cause: The command had exit code 20:
                                       C:\Users\yann\AppData\Local\Temp\7zC98A7834\bin\dkml-install-user-runner.exe
                                         install-user-network-ocamlcompiler --verbosity=info
                                         --color=always --prefix
                                         C:\Users\yann\AppData\Local\Programs\DiskuvOCaml
                                         --staging-files
                                         C:\Users\yann\AppData\Local\Temp\7zC98A7834\sg

                         >>> A transient failure occurred. <<<

A workaround seems to be installing Git for Windows manually beforehand.

Yikes. Thanks for reporting.

I double-checked that the current download (https://github.com/git-for-windows/git/releases/download/v2.36.1.windows.1/Git-2.36.1-64-bit.exe) does match the expected checksum (08A0C20374D13D1B448D2C5713222FF55DD1F4BFFA15093B85772CC0FC5F30E7).
I won't be able to investigate why your download was corrupted ... but it sounds like the SHA256 checksum verification did its job! This is one of the few times where we know the DKML installer is right. It could be a zillion other things: the download had a bit flip during transit (rare), the download site was down temporarily and gave a generic 503 HTML page (not rare at all, especially for GitHub), the download site was compromised temporarily (I've seen it happen, but rare), you have an aggressive malware checker that quarantines or modifies executables in place (not rare), you have a flaky network proxy (you would know), you have something on your machine that can intercept Invoke-WebRequest or PowerShell, etc. If you suspect this is not transient, you can investigate further by doing the following in PowerShell:
$GitWindowsSetupAbsPath = $env:TEMP

# Then copy and paste the lines from
# https://github.com/diskuv/dkml-component-ocamlcompiler/blob/e13977b3c1df32433ca6b2dea1c71a86e33aa5ca/assets/staging-files/win32/setup-userprofile.ps1#L642-L659

The real bug is not being able to retry the installation ... as the message tells you ... without using the uninstaller. You have #36 already open for that.
I'll close this after #36 is addressed.

Thanks you for looking into that. Indeed, download failures can happen. What surprises me is that it happened several times. It is really a case of bad luck that github would have had problems for several minutes in a row.
Anyway, running the commands in powershell now gives no error.
Maybe the installer could offer to retry the download in such a case, instead of crashing, and the user having to restart from zero (see my comment on #36).

It is really a case of bad luck that github would have had problems for several minutes in a row.

The actual 99% likely situation is ... if all the download problems were GitHub URLs ... is that GitHub is throttling your external IP address, not that they are having an outage. If you share your external IP address with others (do you?), you can be retrying for quite a while before the rate limiting is removed. And we'd have to patch opam.exe to ask the users for retries as well, because near the end of the installer opam.exe install dominates the time.
Regardless, Microsoft does not allow packages to be submitted to winget install if the package does not have a mode where no questions are asked (silent install). We have to get clean installs without prompting.
I think I answered a question for myself. I don't see any recourse except to bundle the Git for Windows installer and any subsequent downloads into the installer. I did that for MSYS2 the last release cycle. Bundling Git for Windows will add an extra 100GB to the installer; that should be fine. And I'd have to figure out a way to pre-bundle the opam repositories (in an idempotent way, one that respects any subsequent opam update; perhaps a pre-populated cache).
I'll change the title of this issue and keep it open. But it won't be the highest priority because waiting (if you are rate limited) or retrying (if it is a transient outage) are workarounds.

I do not think I share my IP address ; this is my home connection and I am alone on it.

Regardless, Microsoft does not allow packages to be submitted to winget install if the package does not have a mode where no questions are asked (silent install). We have to get clean installs without prompting.

Does Diskuv have a interactive mode too ?

an extra 100GB to the installer

That seems a lot.

You have a dedicated external IP on your home connection? That is rare in the United States; typically the ISPs will rotate home IP addresses frequently. I had to search for an ISP that only does that on average once a month. (Also, home connections are the least reliable network connections, at least where I am from. But I'm guessing you are pretty advanced in your home networking setup so I won't talk about networking anymore.)
I have limited resources, and do not think that adding interactivity to muddle through rare (as far as I know) network issues is a good use of those limited resources. Doing a basic Invoke-WebRequest should not fail and should not need to be retried on top of the Microsoft defaults. I especially don't think asking interactive questions for every network connection is a good use of resources when adding GBs to an installer permanently solves the problem, and when that "offline" feature has been requested by others.
Not sure if I can convince you, but I have to balance interests for all users.

The configuration interface from my ISP has a specific button to allow me to request a change in my IP address, so I think it is dedicated and will not change without request. It is a FTTH connection and has been very reliable.
I understand it would be a hassle to add checks and retries everywhere. And the problem becomes moot if we can effectively re-run the whole installer (which I understand is intended to be possible, but currently is not, because of the error on the file renaming step in #36).

Closing because related #36 was closed


Printer Status Error With Multi Printer on 1 PI

I have Tried to install MoonCord with a Multiple Klipper Instance on 1 PI setup where each printer is served on a different moonraker Port EX. 7126 or 7125
here is the error im getting using http://<IP_ADDRESS>:7126 as the moonrakerurl in the config,json

I am also unable to Change Permissions in the discord Server but im not sure this is a related issue.

From the discord converation:
Master ID is your discord id and application id is the id from your application...
Also you need to change the port on the websocket (ws://<IP_ADDRESS>:7126)

Solved via discord


Dynamic Obstacles Environment

Based on issue #50

Hi Suman.
The code for your new environment itself seems fine, but there are a few changes that I would like to see:

You included files in the PR that shouldn't be included, ie: settings files for your IDE
Changes to the README should be minimal. You changed things such as the URL for the repo in your fork, but we don't want to change that on this repo.
Your new obstacle has no internal logic, so I would propose simply reusing the Ball object instead, and preventing the pickup action in your environment (if action == self.actions.pickup: return ...). That way we can avoid adding a new type of object with a new observation encoding, etc.

While implementing the 3rd change, I noticed something strange: no matter which environment, the action_space has 7 available actions, including pickup etc. So for the Empty environment, during the RL training, the agent can select from 7 actions, while actually to achieve the goal it requires only 3 actions.
This may not cause a difference for sparse rewards, but otherwise, it increases the complexity unnecessarily. Instead would it not be more optimal to have a method in each environment which constrains the action_space to only the required actions?

Hi Suman,
You are right. The action space has actions that aren't needed, which is somewhat inefficient. I wanted to keep the actions mapped to the same values so we could do experiments with transfer learning or curriculum learning, that is, train in one environment, then test the model in a different environment. For that, the action spaces need to be compatible.
That being said, if you only need the left/right/back actions and not pickup/drop/etc, you should be able to disable the other actions in your environment this way, in the constructor:
self.action_space = spaces.Discrete(self.actions.forward+1)
Other remarks about this pull request:

You've changed the reward_range in minigrid.py. This change should be made in your environment rather than in the base class. Ideally, no changes should be made in minigrid.py

Revert/remove changes to run_tests.py and manual_control.py.  Take a look at the "Files Changed" tab the pull request to see all the changes you've made.

Ping @Suman7495

Hi Maxime,
Sorry for the delay. Unfortunately this week I'm a little caught up with work. I'll try to make the required changes on the weekend and contact you after that.

Hi Maxime,
I have made the required changes. Kindly let me know if any other details are to be mended.
Thank you.

It looks good. If you can revert all changes to gym_minigrid/minigrid.py and run_tests.py I think it's ready to merge. Look under files changed to see the changes that were made to those files.

Hi Maxime,
I did a final check, and now I think all the changes are reverted.

Hi, you still have a number of one-line changes in minigrid.py and run_tests.py. Can you please copy the versions of these files from the master branch of this repository and commit that?

I downloaded the original files from the master and committed them to my branch. I think it should be fine now.

Thank you.


Make CoffeeKup views available in client side scripts

It would be nice to have your CoffeKup views (or at least CoffeeKup in some easy way) available in client side scripts.
My first obvious idea is to auto-compile all views to a template.js file, and serve CoffeeKup as /zappa/coffeekup.js, but maybe it can be done in better way.
As far as I can tell there's currently no easy/shortcut way to use client side CoffeeKup templates in Zappa.

Right. Let me give an example why this would be a Good Thing. I have a microblogging app. Posts are rendered at two times. The server renders posts in a http handler. The client renders posts in a socket handler (providing real-time updates). Presently the server calls a @view—a CoffeeKup template—with partial. Whereas the client socket handler renders posts with jQuery.
In accordance with Don't Repeat Yourself I want to use same code to render the posts on the server and client. Zappa is probably the first framework where this could be possible.


ENH: special: Add the function _scaled_exp1

This is an alternative to https://github.com/scipy/scipy/pull/17844.  Instead of providing a function that computes $\log(E_1(x))$, here we provide the function $F(x) = x e^x E_1(x)$.  It is currently implemented as the private function scipy.special._scaled_exp1.  We can interpret $F(x)$ as the "nice" part of $E_1(x)$, with the exponential decay as $x\rightarrow\infty$ removed and the singularity at 0 removed.  That is, $E_1(x) = \frac{e^{-x}}{x} F(x)$.  $F(x)$ is numerically well-behaved, with the properties that $F(0) = 0$, $F$ is increasing on $[0, \infty)$ and $\lim_{x\rightarrow\infty} F(x) = 1$.
The comments in the C function scaled_exp1.c explain the how $F(x)$ is computed.  The method used depends on the value of $x$:

$0 \le x \le 1$: naive implementation $F(x) = x e^x E_1(x)$,
$1 < x \le 1250$: continued fraction expansion,
$x > 1250$: asymptotic expansion.

The function is private for now.  If there is interest, we can make it public here, or we can wait until additional use-cases arise in the future.  The form of $F(x)$ defined here is a nice fit  for our current use-case in the entropy function of the inverse Gaussian distribution.

@mdhaber, why did you remove the stats tag?  This PR changes code in stats.


Made iterator class configurable on ModelChoiceField

This seemed too trivial to open a ticket regarding, so I just created a pull request without one. Currently isn't trivial to change the iterator class used for a subclass of ModelChoiceField since it is hardcoded in _get_choices, which is then used in a property. This means a subclass has to duplicate code and create the property again to change the iterator class.
Test coverage/documentation can be added if needed, but seemed like a trivial enough change to not need any.

If you want this to be a public API it needs tests and documentation.

What about this change makes it public API needing tests and documentation? If it was self._iterator instead would it be ok? There's no documentation for default_error_messages so I'm not clear on where the dividing line is here.

In both cases not adding regression tests makes the feature more fragile to possible refactoring of the ModelChoiceField class in future Django releases.

@charettes, I've added a small test

merged in 5ec64f96b2d83ec3c0ef574f52e4767a440017b8, thanks!


Invalid handle with Wine

On an Arch Linux machine:
cargo run --example console --target 'x86_64-pc-windows-gnu'
    Updating registry `https://github.com/rust-lang/crates.io-index`
 Downloading winapi v0.2.8
 Downloading user32-sys v0.1.2
 Downloading libc v0.2.14
   Compiling libc v0.2.14
   Compiling winapi v0.2.8
   Compiling rand v0.3.14
   Compiling winapi-build v0.1.1
   Compiling kernel32-sys v0.2.2
   Compiling user32-sys v0.1.2
   Compiling wio v0.1.1 (file:///home/vagrant/wio-rs)
     Running `target/x86_64-pc-windows-gnu/debug/examples/console.exe`
fixme:thread:SetThreadStackGuarantee (0x32fba0): stub
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error { repr: Os { code: 6, message: "Invalid handle." } }', ../src/libcore\result.rs:788
note: Run with `RUST_BACKTRACE=1` for a backtrace.
error: Process didn't exit successfully: `target/x86_64-pc-windows-gnu/debug/examples/console.exe` (exit code: 101)

Maybe it is related to Wine.
But there is no error when running the linenoise-ng example which seems to use the same API:
mkdir build && cd build
cmake -DCMAKE_TOOLCHAIN_FILE=~/Toolchain-x86_64-pc-windows-gnu.cmake -DCMAKE_BUILD_TYPE=Debug ..
make
./example.exe
starting...
linenoise>

Thanks.

Could you try to figure out which exact function call is returning that error? The code runs fine for me on Windows, so it's probably something particular that I'm doing which wine doesn't like.

Ok,
https://github.com/retep998/wio-rs/blob/master/examples/console.rs#L9
https://github.com/retep998/wio-rs/blob/master/src/console.rs#L17

So it appears that wine is unable to handle creating new console screen buffers? Can you figure out whether there is some invocation of CreateConsoleScreenBuffer which does work fine?

It appears that linenoise-ng does not use CreateConsoleScreenBuffer.
And I can't make CreateConsoleScreenBuffer work with Wine.
Sorry for the inconvenience, it is not related to wio-rs...

According to https://www.winehq.org/docs/wineusr-guide/cui-programs, did you try running it with wineconsole? Perhaps trying different backends?

Many thanks for you help.
I have no X server:
$ wineconsole target/x86_64-pc-windows-gnu/debug/examples/console.exe
err:winediag:nulldrv_CreateWindow Application tried to create a window, but no driver could be loaded.
err:winediag:nulldrv_CreateWindow Make sure that your X server is running and that $DISPLAY is set correctly.

And
$ wineconsole --backend=curses target/x86_64-pc-windows-gnu/debug/examples/console.exe
$ echo $?
101

But:
$ # just a check with linenoise-ng
$ wineconsole --backend=curses example.exe
$ echo $?
0

The curses seems to work properly (fullscreen display and color with linenoise-ng).
And with these lines added in the linenoise-ng example:
     HANDLE mScreenBuf = CreateConsoleScreenBuffer (GENERIC_READ | GENERIC_WRITE, FILE_SHARE_WRITE, 0,
                                     CONSOLE_TEXTMODE_BUFFER, 0);
     if (mScreenBuf == INVALID_HANDLE_VALUE) {
         printf("CreateConsoleScreenBuffer failed!\n");
         exit(1);
     } else {
         printf("CreateConsoleScreenBuffer succeeded!\n");
         CloseHandle (mScreenBuf);
     }

It works:
$ wineconsole --backend=curses example.exe
CreateConsoleScreenBuffer succeeded!
starting...
linenoise>

That crash, does it occur with other rust programs when you use the curses backend? Could you perhaps use a debugger to figure out how it is crashing?


Allow an easier way to clear (column) values

Currently, a message (column) of an entity will be empty in the entity storage record only if:
a) The entity has been saved with the (column) absent from its state definition (e.g., for older entities).
b) A custom ColumnMapping is supplied, explicitly mapping certain kinds of values to a null value.
Other approaches, including calling .clear...() on the entity state or overriding interface-based columns and returning null, will not work. The latter seems to cause an exception while calling .clear...() will lead to the (column) being saved with a ColumnType.getDefaultInstance() value.
This is suboptimal for us because, e.g., if we want to clear a Timestamp value, it will be saved to Datastore as datetime(“1970-01-01T00:00:00Z”), and now all our time range queries have to account for this value explicitly. This is also a bit counterintuitive, as calling the corresponding .has...() method on an entity state fetched by such a (column) will return false.

@dmitrykuzmin How about this (in relation to Datastore and Timestamp):
 private static final class CustomMapping extends DsColumnMapping {

        @Override
        protected void
        setupCustomMapping(
                ImmutableMap.Builder<Class<?>, ColumnTypeMapping<?, ? extends Value<?>>> builder) {
            builder.put(Timestamp.class, ofNullableTimestamp());
            builder.put(Version.class, ofVersion());
        }

        @SuppressWarnings("UnnecessaryLambda")
        private static ColumnTypeMapping<Timestamp, Value<?>> ofNullableTimestamp() {
            return timestamp -> {
                if (timestamp.equals(Timestamp.getDefaultInstance())) {
                    return NullValue.of();
                }
                return TimestampValue.of(
                        ofTimeSecondsAndNanos(timestamp.getSeconds(), timestamp.getNanos())
                );
            };
        }
}

// ...
var customMapping = new CustomMapping();
var factory = DatastoreStorageFactory
                   .newBuilder()
                   .setDatastore(datastore())
                   .setColumnMapping(customMapping)
                   .build();

In this way, it will be not possible to have a meaningfully stored Timestamp.getDefaultInstance(), and null will be stored instead in all cases.

@dmitrykuzmin closing this issue now. In case anything related still persists, please feel free to open a new one.


Update PNG scatterplot

Scatterplot PNG file is not fully readable when using dark theme. Created a new PNG file with white background.

hi, this looks good - would you mind replacing the old file with this new one so that the translations don't have to be changed? thanks!

Done.


Documentation and package.json Issues

In my terminal, I tried to start the example app within the example folder. I tried to start it by following the ReadMe by running yarn. I got an error about Nest-Next missing. I then run yarn add nest-next. I tried running yarn again. That worked, but when I tried to run yarn dev. I then get another error for /bin/sh: nodemon: command not found. I then try adding yarn add nodemon --save-dev. I tried running yarn and finally I didn't get any errors. I was then able to run yarn dev.
When I was getting ready to submit a pull request, I noticed yalc. I'm not familiar with yalc so then I noticed that I needed to add it globally with yarn global add yalc. Adding yalc didn't seem to fix the issues though. What is the globally installed app requirements before running your project with the instructions you provided? I know yarn for sure.

Hey thanks for checking this out! Thank you for letting me know about the problems with the package.json file in the example project. Originally I had stripped down one of my personal projects for the example but didn't do a good enough job of making sure you had everything you needed. I went in and fixed the reference for the nest-next package and added nodemon as a dev dependency.  Let me know if you have any other issues with the example.
Also I am going to create a wiki page for a step by step tutorial style guide, and will update this issue when it is ready.  However, the main readme does contain all you need to get started with the package but it does assume a familiarity with nest and next.  With the wiki I will try to write it in a way that doesn't assume there is a deep knowledge of next.

You're welcome. I'm learning Nest and Next through your example app so thank you for creating this package. Is Yalc not needed then? I'm looking forward to your Wiki page.

I apologize this is long overdue. To answer your question yalc isn't needed at all. I actually just use that to test out changes I make to the package before publishing it to NPM. That should have been removed prior to being pushed to git.
I updated the example and removed a ton of complexity. It can essentially be used as a started to quickly setup the project.
I also wrote a setup guide that basically takes your step by step to create the example from scratch. You can look at it here: https://github.com/kyle-mccarthy/nest-next/wiki/Setup-Guide


test ci action

We're testing stuff. Don't merge this yet.

Interesting that ☝ didn't fire a synchronize event (and thus re-run the Checks).

That did it. 🎉


Call DaemonReload after all Load/Unload operations complete

This eliminates the raciness of calling DaemonReload during reconciliation by making it an explicit task that gets executed after all LoadUnit & UnloadUnit tasks complete.
Fix #1158.

Seems like it could be reasonable. Go for it.

@jonboulle cool - I added  26d81ad to make sure the agent was outputting tasks in a deterministic order. One of the tests I added in this PR was failing sporadically due to the arbitrary ordering of the map under pkg.Set.

@bcwaldon herm, can you explain for the dimwitted among us why ordering is important there? You subsequently sort the tasks, and dState/cState are not mutated in calculateTasksForUnit (are they?!), so I'm not seeing why the job iteration order matters.

@jonboulle it's only for the tests. The function needs to output a deterministic so I can make an assertion.

but the tasks are still sorted anyway on line 186/189 so I don't understand how the output of the function was nondeterministic before this change...

@jonboulle The sort operation only takes into account the task type's weight. For two tasks that are of equal weight, the calculate function basically flipped a coin given the initial iteration order is based off a map.

Gotcha, thanks.
On Tue, Mar 31, 2015 at 4:47 PM, Brian Waldon<EMAIL_ADDRESS>wrote:

@jonboulle https://github.com/jonboulle The sort operation only takes
into account the task type's weight. For two tasks that are of equal
weight, the calculate function basically flipped a coin given the initial
iteration order is based off a map.
—
Reply to this email directly or view it on GitHub
https://github.com/coreos/fleet/pull/1168#issuecomment-88286860.


adding vendor directory

This is a suggestion to move to the way Go 1.6 is handling vendoring. I just did:
mkdir vendor
cp -r Godeps/_workspace/src/* vendor/

I have seen this done in kubernetes too. I think we can keep the Godeps directory for a while and then remove it if we see that it works well for us.
@simon3z @pweil-

This is a suggestion to move to the way Go 1.6 is handling vendoring

Is this backward compatible with 1.4/1.5? (Can you build on those versions?)

@simon3z This is not backward compatible but eventually we will have to do the change according to those warnings that I get while compiling using godep:
godep: WARNING: Godep workspaces (./Godeps/_workspace) are deprecated and support for them will be removed when go1.8 is released.
godep: WARNING: Go version (go1.6) & $GO15VENDOREXPERIMENT= wants to enable the vendor experiment, but disabling because a Godep workspace (Godeps/_workspace) exists

To compile this way we just need to use:
go build cmd/image-inspector.go

@enoodle we can't break builds on 1.4 and 1.5 just to suppress warnings in 1.6.
(Anyway I have the feeling that you can use this vendor path with 1.4 and 1.5 if you change the build configuration).

@simon3z Can you please take another look at this? I think as we prepare for a new version of this tool we might be willing to let go of go1.4 to adopt the new "vendor/" directory and use better package management tools than Godep (which I personally really don't like, trying to add the github.com/containers/image repo as a dependency was a nightmare)

@enoodle have you refreshed all the dependencies with newer versions?

@simon3z No, I left them on the exact same version. You can see it in those files:
https://github.com/openshift/image-inspector/pull/20/files#diff-681659ab9abb4b4883e78e8aaa980dba ("Godeps/Godeps.json")
https://github.com/openshift/image-inspector/pull/20/files#diff-4061fcef378a6d912e14e2ce162a1995 ("vendor.conf")

@enoodle as far as I understood by the conversation we just had you're still polishing this. Let me know when it's really settled.

I see that kubernetes has started to move towards this, but I guess moving such a big project is harder. It is present in contianers/image [2] (They upgraded to a similar tool which is better because it does caching [3], I will try it out too). Openshift is also using the vendor directory but I couldn't find where it was introduced.
[1]https://github.com/kubernetes/kubernetes/pull/24242
[2]https://github.com/containers/image/pull/240
[3]https://github.com/containers/image/pull/244

@ilackarms can you test / review this?
cc @pweil-

this compiles without issue, but i would suggest using godep save to generate  Godeps file and vendor directory rather than manually rearranging deprecated structure.
To do so:
godep restore
rm -rf Godeps
godep save ./...

@ilackarms Trash is similar to glide, it can also use the glide configuration file. I added a make deps line to the Dockerfile to do exactly what you advised, Thank you.

ping @ilackarms @pweil- @simon3z Do you want to take another look? This make it much easier to manage dependencies.

Moved to #57


AMBARI-24644. Log Search: support trusted knox proxy.

What changes were proposed in this pull request?
add new properties to supported trusted knox proxy in logsearch.
This PR does not include any changes on stack side, as its not clear yet where to commit changes for that
How was this patch tested?
In progress...
Please review @g-boros @swagle @kasakrisz

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3968/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3972/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3979/
Test PASSed.


CORGI-201: Use password authentication even if a valid Kerb ticket exists

This saves us an extra request to the KDC to validate the ticket against
the DB, which inevitably fails because the DB server is not registered as a
valid principal in the KDC.

LGTM, thanks for catching this!

LGTM


Some "touches" do not disappear

Sometimes the visualized touches do not disappear. But they still do that jellyfish movement. The problem occurs randomly, sadly I haven't found a way to reproduce it. The project is entirely written in swift and the COSTouchVisualizer (1.0.3) is added via CocoaPods. Do you have any idea what the cause could be?

Yeah, I think someone submitted a PR for this.  I've just been busy.  I'll try and merge it in and update the library this weekend.

One way to reproduce it is to segue from a to b while holding down a tap. (At least that was the way I managed to reproduce it on my app)

I've been able to reproduce it so I'll have to look into what's going on.  Thanks for finding this; it wasn't caught in the latest update.

This was fixed in 393debeb77d1e87fc036df3ec42969d2fe3a57b1


No name and value prop on 3rd party Radio component

Are you submitting a bug report or a feature request?
bug report or incomplete/incorrect docs
What is the current behavior?
If one is using a 3rd party component library for form elements, especially radio buttons, (like https://github.com/Semantic-Org/Semantic-UI-React in our example) are not behaving correctly, because they are missing the name and value props.
Have a look at: https://codesandbox.io/s/43oj52ol7x
As stated in the docs:

props : object [optional]
Object with custom props to pass through the Field component into a component provided to component prop. This props will be merged to props provided by Field itself. This may be useful if you are using TypeScript. This construct is completely optional; the primary way of passing props along to your component is to give them directly to the Field component, but if, for whatever reason, you prefer to bundle them into a separate object, you may do so by passing them into props.

and

These are props that Field will pass to your wrapped component. The props provided by redux-form are divided into input and meta objects.
Any custom props passed to Field will be merged into the props object on the same level as the input and meta objects.

This is not the case for custom components as it seems. Everything works fine for normal dom elements. But the Radio components in the given codesandbox example do not get the name nor the value prop passed along. Which results in the problem that you can check both radio buttons, because they are missing the name. And because of the missing value prop you can not pass the correct value onClick/onChange back to reduxForm.
The name property could be extracted from input.name prop and passed down to the component. But the input.value is null or an empty string. So one would have to use the special propsprop to pass that along as seen in the working radio buttons in the sandbox.
What is the expected behavior?
Either that the name and value prop are always passed down to the desired component or that the docs get updated to state this in more detail, if it is intended behaviour how it currently behaves.
Sandbox Link
https://codesandbox.io/s/43oj52ol7x
What's your environment?
All the latest versions. See sandbox

Hello @tpinne, sorry for this incredible delay.
Your example is quite broken, but I managed to get it working.
What happens is that you should always define the type prop, or Redux Form will treat the components as <input type="text"> by default.
Basically, this is a duplicate of #2292.


Add "iftop" to the Firewall's Diagnostic section

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Is your feature request related to a problem? Please describe.
No problems
A clear and concise description of what the problem is including your motivation for the request,
i.e. "For the purpose of [...] I am missing a solution that will [...]."
For the purpose of monitoring connections/traffic on a specific interface, it would be possible to have "iftop" as a tool under Firewall -> Diagnostic? Maybe with the option to select the interface with a drop-down menu that it will re-lunch "iftop" with the correct "-i" flag value. Since "iftop" is already installed and it would be very useful to have it handy in the GUI.
Describe the solution you like
"iftop" as a diagnostic tool under the "Firewall" section
A clear and concise description of what you want to happen.
(e.g. I would like an input field in the /ui/firewall/alias which would add .... to ....)
Describe alternatives you considered
A clear and concise description of any alternative solutions or features you considered.
Additional context
Add any other context or screenshots about the feature request here or links to relevant forum thread or similar

that would be Reporting: Traffic as a user friendly interface
https://github.com/opnsense/core/blob/277ffb6ac50010e17d2daff6aad72672ff2ecdef/src/opnsense/scripts/interfaces/traffic_top.py#L44


setErrors transforms class of bignumber.js instance

Hello,
My form state contains BigNumber objects (from bignumber.js).
After the submit, my BigNumber objects are transformed into Object.
The problem is in setErrors :
if (state && typeof state === 'object') {
      return Object.keys(state)
        .reduce((accumulator, key) =>
            isMetaKey(key) ? accumulator : {
              ...accumulator,
              [key]: setErrors(state[key], errors && errors[key], destKey)
            },
          state);
    }

Not an ES5/6 expert, so not sure how to modify this code to keep the BigNumber class.
Any idea ?

It works with this code :
const oldPrototype = Object.getPrototypeOf(state);
let newState = Object.keys(state)
       .reduce((accumulator, key) =>
            isMetaKey(key) ? accumulator : {
              ...accumulator,
              [key]: setErrors(state[key], errors && errors[key], destKey)
            },
          state);
newState.__proto__ = oldPrototype;
return newState;

It looks a little bit hacky, so I'm not sure if I should write a pull request...

Hi,
This is a usage question, and we encourage you to ask it on StackOverflow instead. We try to use the issue tracker for bug reports and feature requests, as well as some discussions, but this appears to be a very localized question.
This is the only way to ensure the same question doesn’t get asked many times in a row, and that folks who have the same question in the future will be able to find it.
I’m closing for these reasons.


Add Dockerfile and container build workflow

I'm in the process of setting up this script to run within my Kubernetes Mastodon instance and needed it packaging up for ease of use. So I thought I'd contribute back the changes.
This adds the following

Dockerfile to generate the container
A new Github workflow to build and publish the container on ghcr.io

The script is provided as a entry point, so the container can be used with docker run containername --server=mastodon.social ....

That's pretty cool. Thanks so much!
Can you add a section on how to use this with Docker to the README please? I'm not familiar with docker, so can't do it myself.
Once that's added I'll very happily merge this PR.

@nanos Done, added a k8s example CronJob for running the container as well.

Amazing! Thank you so much!

Actually, I just realised a couple of issues after I merged:

This link is a 404: https://github.com/nanos/mastodon_get_replies/pkgs/container/mastodon_get_replies
As far as I can see the will try to run the Build Container workflow, every time I release a version. Any way to adjust this to only execute if needed / configured?

The 404 will fix itself once the container has built (as it's the URL for the container view on Github, e.g. https://github.com/nikdoof/mastodon_get_replies/pkgs/container/mastodon_get_replies).
You can modify the 'on' section of the workflow to restrict its run, if you only want it on a tagged version then remove the branch: main bit.
As for the error on the first run, it may be that the repo doesn't allow Actions to write to the repo: Go to Settings -> Actions -> General, then in the "Workflow permissions" set it to Read/Write.

Yep, the permissions were indeed the problem.
I now need to think about how I'll deal with this, because there are 54 forks for this repo. I don't think we'll want them all to run the Action to build the container. That makes no sense.
I'll have a look at the workflow 'on' bit to see what I can do to fix that

I think as long as I simply remove the branch: main bit, it should be fine, unless forks do their own releases, in which case, again, it's fine.
Thanks again for doing this!
Much appreciated!


add not operator function

implements #101

Can you merge #103 and #102?

@lstrojny I cannot merge those PRs myself. Also, I based the branch of #103 on the #102 branch, so if we merge #103 only, we'll get both commits.
What do you think? Should I close #102?

@docteurklein I think it’s easier to discuss the whole changeset as one. Feel free to close whichever you prefer.


Support Zig package manager

Could a module be exported from zig-wayland to facilitate usage of this package with the official package manager?

I personally won't be looking into this until https://github.com/ziglang/zig/issues/14281 is solved/implemented upstream.
I'd be open to merging changes adding whatever is needed in this repository to support the zig package manager in the meantime as long as they don't significantly increase my maintenance burden.

Correct me if I'm mistaken but does the above issue apply to packaging standards such as python-pywlroots on arch repo which is a specific tag of the project packaged by arch?

https://github.com/ziglang/zig/issues/14281 describes the features necessary for me to be able to use the zig package manager in good conscience for projects I intend to be packaged for distribution by linux distros (e.g. river).


Fixed documentation color values

Color values are documented by Slack here

Cool, they must have updated these. Thanks.

They have updated some things in the API - it was a bit annoying to get all the changes just by exception. :smile:


Distinct operator

Name and description
distinct()
suppress duplicate items emitted by an Observable
Motivation for inclusion
We have some variants of distinctUntilChanged operator in the main repo, but do not have distinct, which is implemented for the most other languages which supports Rx.
Proposed implementation
extension Observable where Element: Hashable {

   func distinct() -> Observable<Element> {
      var set = Set<Element>()
      return flatMap { element -> Observable<Element> in
         objc_sync_enter(self); defer {objc_sync_exit(self)}
         if set.contains(element) {
            return Observable<Element>.empty()
         } else {
            set.insert(element)
            return Observable<Element>.just(element)
         }
      }
   }
}

I'm just thinking aloud here - say if you're using this operator on an Observable wouldn't that consume a lot of memory very quickly? Since the element is a Hashable anyway (in your proposed code) isn't it better to store the hashes instead of the elements themselves?

@icanzilb, I see your point.
But, I wonder if could be a case where Observable emits elements which  have a different type but they are related ?
Kind of :
class A: Hashable {
}
class B: A {
}

let subject = PublishSubject<A>()

let distinct = subject.asObservable().distinct()

.....

subject.onNext(a)
subject.onNext(b) //so hash of  `b` is the same as hash of `a` but they are different

So in this case b would not be edited.
Or I missing something :)

But, yeah potential memory problems is definitely a problem :(

But if we talking about classes. Isn't Set will just hold strong reference to the object?

In your code you're adding the parameter to Hashable not to classes. And even if we limit the operator to classes I think this case will be even worse because adding the object to the set will eventually retain it, while it otherwise might have been released (in case nothing else retained the object of course). I think this

I can see this operator being totally useful, I'm just thinking of a way to have it without a) side effects (e.g. retaining the objects and b) optimal memory footprint (e.g. when the Observable is emitting structs)

@icanzilb  I totally agree with you
The only concern that I have is in this test case:
class A: Hashable, CustomStringConvertible {
   let a: Int

   init(a: Int) {
      self.a = a
   }

   var hashValue: Int {
      return a
   }

   func isEqual(other: A) -> Bool {
      return a == other.a && other.isEqual(self)
   }
   var description: String {
      return "\(self.dynamicType) a = \(a)"
   }
}

func == (lhs: A, rhs: A) -> Bool {
   return lhs.isEqual(rhs)
}

class B: A {
   let b: Int

   init(a: Int, b: Int) {
      self.b = b
      super.init(a: a)
   }

   override var hashValue: Int {
      return a + b
   }

   override var description: String {
      return super.description + " b = \(b)"
   }

   override func isEqual(other: A) -> Bool {
      if let otherB = other as? B {
         return a == otherB.a && b == otherB.b
      } else {
         return false
      }
   }
}

      let subject = PublishSubject<A>()
      subject.asObservable()
         .distinct()
         .subscribeNext {
            print($0)
         }
         .addDisposableTo(disposeBag)

      let a = A(a: 0)
      let b = B(a: 0, b: 0)

      subject.onNext(a)
      subject.onNext(b)
      subject.onCompleted()

As you can see in this case hashValue of a and b is the same (sure this is very bad design of hashValue  in the B class but equality of hashValues in any cases does not guaranty that objects are equal)
In this case if I would store hashes in the Set instead of a real object I would end up that b has not being emitted

My impression was Set also uses hashValue to determine the uniqueness of the objects. I'll research on that later on, need to do smth else right now

Seems to me that we could provide several versions of this distinct operator:

one that is generalized and requires elements to conform to the Equatable protocol. Would be the slowest implementation because it would have to compare all elements in a list until it finds one that is equal (or not)

An implementation for the case where elements conform to Hashable and Equatable: we store elements in a set and Hashable guarantees faster lookups. Note that Hashable alone is not enough because the hash is not guaranteed to be unique -- it's just use to classify objects in smaller buckets.

So having elements conform to Equatable would be a bare minimum and would work but not provide the best performance. What do you guys think?

Good point @fpillet !
I wonder if they are we could also have one version for Comparable and  always keep array sorted so we can use binary search?
Or this is too much?

That's another good idea although I'm not sure we need to go that far -- with Hashable and relying on standard Swift library implementation of Set we should be pretty good. But it's worth a shot with some performance comparison. In there is a gain, then yes it makes sense to have a third implementation!

Ok so let's go with two implementations, and @sergdort if you think that we can get increased performance with a third implementation specializing on Comparable, please feel free to add it too


Show up line number for snippet

Highlight.js, the syntax highlight module currently used, doesn't come with a native line number support.
highlightjs-line-numbers.js, a plugin to address this issue, is based on DOM operation which I don't have much experience with.

http://www.minh.io/tech/2013/08/17/highlightjs-line-numbers/

done: https://github.com/hackjutsu/Lepton/commit/2e8f402856502933999eba5f9f51d7922e03d15b


fix Quit when the RLE length repeat count is larger than int32_t

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


Error while generating symbols

Hello,
I've added a couple of new events in the C/Side environment in a SQL on Azure Database. While generating the new symbols to use in AL with the following command in the correct folder with elevated permissions (for obvious reasons I blanked out the login information):

I am not getting any logs in the command folder. Neither is there a finsql proces starting in the Task Manager. I do get some error messages in the Event viewer but I have no idea how to correct them.

Can anyone help me with this issue? I've used this command before but on local databases, not on a SQL on Azure.
Kind Regards
Joriek

I have the same issue, can anyone help please?

Have you tried starting finsql.exe in the Client folder and not the server. probably you have some .net variable and you are missing the add-in dll?
https://blogs.msdn.microsoft.com/nav/2018/01/16/generate-symbols-in-a-modern-development-environment-with-microsoft-dynamics-nav-2018/

I succeeded with finsql.exe generatesymbolreference=yes and then compiling all the objects.

Seems like @BartPermentier his trick worked. Thanks!


build_helper:  install mvfst

Install mvfst headers and libraries by build_helper.sh as described in README.md.

We went with https://github.com/facebookincubator/mvfst/commit/731d13cc3bd056fc2633f026ffeabad6d5d9fcba


Make lb_calld Orphanable

C++ conversion of GlbLbCallData.

****************************************************************

libgrpc.so

     VM SIZE                                                                                FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +0.1%    +494 [None]                                                                               +9.51Ki  +0.2%
      +0.1%    +414 [Unmapped]                                                                           +9.43Ki  +0.2%
      [NEW]     +40 vtable for (anonymous namespace)::GlbLbCallData                                          +40  [NEW]
      [NEW]     +40 vtable for grpc_core::InternallyRefCountedWithTracing                                    +40  [NEW]
  +0.2%     +26 src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc                           +26  +0.2%
      [NEW] +1.50Ki rr_handover_locked(glb_lb_policy*) [clone .part.25]                                  +1.50Ki  [NEW]
     +11e2% +1.36Ki query_for_backends_locked                                                            +1.36Ki +11e2%
      [NEW] +1.31Ki (anonymous namespace)::GlbLbCallData::OnBalancerMessageReceivedLocked                +1.31Ki  [NEW]
      [NEW]    +801 build_lb_channel_args(grpc_lb_addresses const*, grpc_fake_resolver_response_generato    +801  [NEW]
      [NEW]    +695 (anonymous namespace)::GlbLbCallData::OnBalancerStatusReceivedLocked                    +695  [NEW]
      [NEW]    +531 (anonymous namespace)::GlbLbCallData::SendClientLoadReportLocked                        +531  [NEW]
      [NEW]    +210 extract_backend_addresses_locked(grpc_lb_addresses const*) [clone .isra.3]              +210  [NEW]
      [NEW]    +170 (anonymous namespace)::GlbLbCallData::~GlbLbCallData                                    +170  [NEW]
      [NEW]    +120 (anonymous namespace)::GlbLbCallData::ScheduleNextClientLoadReportLocked                +120  [NEW]
      [NEW]    +109 (anonymous namespace)::GlbLbCallData::ClientLoadReportDoneLocked                        +109  [NEW]
      [NEW]    +105 (anonymous namespace)::GlbLbCallData::OnInitialRequestSentLocked                        +105  [NEW]
      [NEW]     +88 (anonymous namespace)::GlbLbCallData::Orphan                                             +88  [NEW]
      [NEW]     +87 (anonymous namespace)::GlbLbCallData::MaybeSendClientLoadReportLocked                    +87  [NEW]
      [NEW]     +47 grpc_core::Orphanable::Orphan                                                            +47  [NEW]
      [NEW]     +14 (anonymous namespace)::GlbLbCallData::~GlbLbCallData                                     +14  [NEW]
      [NEW]      +9 grpc_core::InternallyRefCountedWithTracing::~InternallyRefCountedWithTracing              +9  [NEW]
      +2.9%      +8 glb_lb_channel_on_connectivity_changed_cb                                                 +8  +2.9%
      [NEW]      +2 grpc_core::InternallyRefCountedWithTracing::~InternallyRefCountedWithTracing              +2  [NEW]

  +0.0%    +520 TOTAL                                                                                +9.53Ki  +0.1%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc.so

     VM SIZE                                                                                FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +0.1%    +494 [None]                                                                               +9.51Ki  +0.2%
      +0.1%    +414 [Unmapped]                                                                           +9.43Ki  +0.2%
      [NEW]     +40 vtable for (anonymous namespace)::GlbLbCallData                                          +40  [NEW]
      [NEW]     +40 vtable for grpc_core::InternallyRefCountedWithTracing                                    +40  [NEW]
  +0.2%     +26 src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc                           +26  +0.2%
      [NEW] +1.50Ki rr_handover_locked(glb_lb_policy*) [clone .part.25]                                  +1.50Ki  [NEW]
     +11e2% +1.36Ki query_for_backends_locked                                                            +1.36Ki +11e2%
      [NEW] +1.31Ki (anonymous namespace)::GlbLbCallData::OnBalancerMessageReceivedLocked                +1.31Ki  [NEW]
      [NEW]    +801 build_lb_channel_args(grpc_lb_addresses const*, grpc_fake_resolver_response_generato    +801  [NEW]
      [NEW]    +695 (anonymous namespace)::GlbLbCallData::OnBalancerStatusReceivedLocked                    +695  [NEW]
      [NEW]    +531 (anonymous namespace)::GlbLbCallData::SendClientLoadReportLocked                        +531  [NEW]
      [NEW]    +210 extract_backend_addresses_locked(grpc_lb_addresses const*) [clone .isra.3]              +210  [NEW]
      [NEW]    +170 (anonymous namespace)::GlbLbCallData::~GlbLbCallData                                    +170  [NEW]
      [NEW]    +120 (anonymous namespace)::GlbLbCallData::ScheduleNextClientLoadReportLocked                +120  [NEW]
      [NEW]    +109 (anonymous namespace)::GlbLbCallData::ClientLoadReportDoneLocked                        +109  [NEW]
      [NEW]    +105 (anonymous namespace)::GlbLbCallData::OnInitialRequestSentLocked                        +105  [NEW]
      [NEW]     +88 (anonymous namespace)::GlbLbCallData::Orphan                                             +88  [NEW]
      [NEW]     +87 (anonymous namespace)::GlbLbCallData::MaybeSendClientLoadReportLocked                    +87  [NEW]
      [NEW]     +47 grpc_core::Orphanable::Orphan                                                            +47  [NEW]
      [NEW]     +14 (anonymous namespace)::GlbLbCallData::~GlbLbCallData                                     +14  [NEW]
      [NEW]      +9 grpc_core::InternallyRefCountedWithTracing::~InternallyRefCountedWithTracing              +9  [NEW]
      +2.9%      +8 glb_lb_channel_on_connectivity_changed_cb                                                 +8  +2.9%
      [NEW]      +2 grpc_core::InternallyRefCountedWithTracing::~InternallyRefCountedWithTracing              +2  [NEW]

  +0.0%    +520 TOTAL                                                                                +9.53Ki  +0.1%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[trickle] No significant performance differences

Corrupt JSON data (indicates timeout or crash):
    bm_fullstack_streaming_pump.BM_PumpStreamServerToClient_SockPair__0.counters.new: 1
    bm_fullstack_streaming_pump.BM_PumpStreamServerToClient_MinSockPair__0.counters.old: 1

[microbenchmarks] Performance differences noted:
Benchmark                            cpu_time    real_time
-----------------------------------  ----------  -----------
BM_ClosureInitAgainstCombiner        -33%        -33%
BM_ClosureInitAndRun                 +6%         +6%
BM_ErrorGetStatusCode<ErrorNone>     -6%         -6%
BM_ErrorGetStatusCode<SimpleError>   -7%         -7%
BM_ErrorStringRepeatedly<ErrorNone>  -5%         -5%

Corrupt JSON data (indicates timeout or crash):
    bm_fullstack_streaming_pump.BM_PumpStreamServerToClient_MinSockPair__0.opt.new: 1

[microbenchmarks] No significant performance differences

This looks pretty good!  My comments are all fairly minor.

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 13 unresolved discussions, some commit checks failed.

src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc, line 134 at r1 (raw file):

namespace {
class GlbLbCallData;

Let's keep these structs and classes defined here, rather than moving them below and needing forward declarations here.

src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc, line 162 at r1 (raw file):

   * is shutting down, or the LB call has ended). A non-NULL lb_calld always
   * contains a non-NULL lb_call_. */
  GlbLbCallData* lb_calld;

I think we'll need to change this to be an OrphanablePtr<> as part of merging the changes from #14221 (which I plan to merge later today).

src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc, line 277 at r1 (raw file):

};

class GlbLbCallData final : public grpc_core::InternallyRefCountedWithTracing {

I don't think final actually adds any benefit here, so let's not use it.

src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc, line 277 at r1 (raw file):

};

class GlbLbCallData final : public grpc_core::InternallyRefCountedWithTracing {

Suggest calling this something like BalancerCallState.
Also, please add a short comment explaining the purpose of this class.

src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc, line 280 at r1 (raw file):

 public:
  explicit GlbLbCallData(glb_lb_policy* glb_policy);
  void Orphan() override;

It's probably worth adding a comment here that it's the caller's responsibility to ensure that Orphan() is called from inside the combiner.

src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc, line 283 at r1 (raw file):

  void StartQuery();
  // TODO(juanlishen): should be removed when glb is C++-ized and a fiend class

Please remove this TODO.  It's better to provide accessor functions than to use friend, since the latter breaks proper encapsulation.

src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc, line 285 at r1 (raw file):

  // TODO(juanlishen): should be removed when glb is C++-ized and a fiend class
  // of GlbLbCallData.
  grpc_grpclb_client_stats* ClientStats();

Simple accessor methods should be named the same as the underlying variable, as per:
https://google.github.io/styleguide/cppguide.html#Function_Names
Also, short methods like this can be defined in-line instead of declared here and defined below, as per:
https://google.github.io/styleguide/cppguide.html#Inline_Functions

src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc, line 312 at r1 (raw file):

   * value may vary if the LB server indicates a redirect) or send client load
   * report. */
  grpc_byte_buffer* send_message_payload_;

Please initialize all pointer fields to nullptr.

src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc, line 320 at r1 (raw file):

  /** The callback to process the response received from the LB server. */
  grpc_closure lb_on_balancer_message_received_;
  bool seen_initial_response_;

Please initialize all bool fields to false.

src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc, line 405 at r1 (raw file):

void GlbLbCallData::Orphan() {
  GPR_ASSERT(lb_call_ != nullptr);
  // lb_on_balancer_status_received_ will complete the cancellation and clean

This comment should point out that there are two possible cases here:

We are being called because the LB policy is cancelling the call, in which case lb_on_balancer_status_received_ will complete the cancellation and clean up.

The call is already complete, in which case grpc_call_cancel() will be a no-op, and we have already cleaned up.

src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc, line 411 at r1 (raw file):

    grpc_timer_cancel(&client_load_report_timer_);
  }
}

Upon initially reading this code, I was going to point out that this method needs to call Unref(), or else the object's external ref will never go away, and we'll have a memory leak.  However, upon reading further, I see that the code is structured such that the object's initial ref is not actually held by the caller.  This is consistent with how the code worked prior to this PR, so it's fine, but it is not the typical use for InterallyRefCounted.  Given that, it's probably worth a comment explainining this.

src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc, line 494 at r1 (raw file):

void GlbLbCallData::MaybeSendClientLoadReportLocked(void* arg,
                                                    grpc_error* error) {
  GlbLbCallData* lb_calld = (GlbLbCallData*)arg;

Please use C++-style casts, both here and throughout this new code.

src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc, line 524 at r1 (raw file):

void GlbLbCallData::SendClientLoadReportLocked() {
  glb_lb_policy* glb_policy = glb_policy_;

This local variable seems totally unnecessary now.

Comments from Reviewable

Review status: all files reviewed at latest revision, 14 unresolved discussions, some commit checks failed.

src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc, line 162 at r1 (raw file):
Previously, markdroth (Mark D. Roth) wrote…
I think we'll need to change this to be an OrphanablePtr<> as part of merging the changes from #14221 (which I plan to merge later today).

Actually, it looks like this is unrelated to the changes from #14221, so don't worry about this now.  I'll take care of it as part of #13870.

src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc, line 438 at r1 (raw file):

  op->reserved = nullptr;
  op++;
  Ref(DEBUG_LOCATION, "OnInitialRequestSentLocked");

Note that when you merge in the changes from #14221, Ref() will now return a RefCountedPtr<>, which we will need to release(), since we're currently tracking the ref manually.  Please add a TODO about fixing this once the new ClosureRef API is done, since that will allow us to track the ref with the closure.
Same thing everywhere you call Ref().

Comments from Reviewable


Adding functionality to read aruco dictionaries from files

I figured that the functionality to read dictionaries from YAML-Files wasn't wrapped yet.
See here from OCV doc:
https://docs.opencv.org/4.x/d5/d0b/classcv_1_1aruco_1_1Dictionary.html#a69ec5ae547b01be07b7ce8c437ad1db4
So I added a wrapper with according tests for that. However, since FileStorage and FileNode were both also not available,
it works on a simple path string now:
var dictionary = CvAruco.ReadDictionary("someDictionaryFile.yaml");
Would be happy if these changes will  find their way into your repository.
Thanks a lot for all your efforts

Thank you!!


Account for new warning messages from Qiskit

CI on Master breaks due to some new warning messages from Qiskit. This was already fixed on #536, but we'll fix it here on master as well.

Closing this since @obliviateandsurrender's PR #559 covers this as well.


pull in documentation and organize

Fixes https://github.com/Azure/autorest.csharp/issues/4345

API change check
APIView has identified API level changes in this PR and created following API reviews.
Microsoft.Generator.CSharp


RPI phpindex no longer loads cam control window

Great Software, easy setup, and runs like a champ and have had no issues until I attempted to condition the RPI as a web server.
I think it's a port or index / directory issue which should be easy to resolve but not knowledgeable enough to know what next step is. Run update.sh and enter in correct values? I can also post the phpindex browser debug info if that helps.
Sorry if this issue is reposted elsewhere, yes I did check the issues and wasn't able to locate exact same problem or resolution of issue. I know a lot of people want to use their Pi's as a web cam AND a web server so...
Think something got misconfigured when I performed the following on the Pi:
822  sudo apt install apache2
823  sudo chown -R pi:www-data /var/www/html/
824  sudo chmod -R 770 /var/www/html/
825  get -O check_apache.html http://<IP_ADDRESS>
826  wget -O check_apache.html http://<IP_ADDRESS>
827  cat ./check_apache.html
828  sudo apt install php php-mbstring
829  sudo rm /var/www/html/index.html
830  echo "" > /var/www/html/index.php
831  sudo apt install mysql-server php-mysql
832  sudo mysql --user=root
833  mysql --user=root --password=******
834  sudo apt install phpmyadmin
835  sudo apt install phpmyadmin mysql --user=root --password=******
836  sudo apt install phpmyadmin --user=root --password=******
837  sudo apt-get install phpmyadmin php-mbstring php-gettext
838  sudo dpkg-reconfigure mysql-server-5.5
839  sudo service mysql stop
840  dpkg --get-selections | grep mysql-server-
841  echo dpkg --get-selections | grep mysql-server-
842  /etc/init.d/mysql stop
843  sudo apt install phpmyadmin
844  systemctl start mysql
845  sudo apt install phpmyadmin
846  htop
847  sudo reboot

As I understand this you want to use the RPi Web cam and also use Apache to host other web apps.
If so that's fine but you need to do things in the right order and also understand the options on running multiple web apps.
I would recommend starting by installing the RPi_Cam software before doing anything else. This will install Apache2 and php so you do need to separately install these later.
During the RPi Cam install you can choose the web subfolder (under /var/www) for the RPi cam and the port number it will use. These default to html and 80. You can change these after the install just by running install again. You can also choose to install into the web root folder by blanking out the subfolder.
One normally allows more than 1 web app on the single app server either by using different urls or by using different port numbers. So with the first method one uses http://ip/webapp1, http://ip/webapp2 etc. With the second method one uses http://ip:port1, http://ip:port2 . This assumes that there is a default start page index.html or index.php for each app in their own folder.
The way RPi Cam is set up makes it easier to do the first scheme where the different apps all use port 80 but are in different subfolders. This means RPi Cam is accessed by http:/ip/html and a second app would be installed into different subfolder and accessed by http://ip/webappfolder.
One of the apps can be put into the base /var/www folder and would then be accessed by http://ip
When you install a further web app then you must make sure it goes into a different folder and doesn't overwrite any RPi Cam files, and you need to check or edit the apache2 site config files to make sure they are set up to access their own app.

@roberttidey Thanks so much for this informative post. Yes, the Cam software is back up and running after a re-install. I figured it would be matter of proper configuration and allocation of correct directories, not knowing enough beyond the basic bootstrap for apache and php install (on the pi). I'm going to reference your above post and see if I can't use that to disambiguate the various installation configs. Thanks so much for your very informative response!


Extend CIM editing capabilities

This PR implementes new functions in cimedit.py (before was called utils.py) to add components to an existing cim topologie.
Based on #23 and #25

Just wondering: Is there still some interest in getting this merged? Or can we close the PR?

Just wondering: Is there still some interest in getting this merged? Or can we close the PR?

These functionalities are needed for the dpsim CIM reader based on cimpy

Okay, I will rebase the changes to the current master.
Apart from the changes to the cgmes_v2_4_15 package it looks good to me.
The issue is that we should not directly modify those auto-generated files by hand.
We need to make those adjustments in the CIMgen repo.
But I can take care of that.


Add Register Page

Solve the conflicts please :pray:

This error message should be prettier

Remove the login and register buttons

"Create a new account" instead


Table Create is silently dying

Hi,
Given I have a list of strings that is my basis for table creation, it silently dies
Enum.each(result, fn x -> db("testdatabase") |> table_create(x["SampleKey"]) |> run end)

It was able to create some tables but it didn't create all of them. I suspect it silently died without throwing. Should this raise an exception?
Also, is there a way to use the '!' so that I get real exception?

You should be checking the response. This is related to https://github.com/hamiltop/rethinkdb-elixir/issues/90
Right now you should match against a %RethinkDB.Response{"tables_created" => 1}. If you do that, it will raise ArgumentError if a table fails.

Ahh, good point. Yes I shall do that, and I agree that it should return atom instead of struct. Thank you for your fast response and sorry for opening an issue.


docs: add status page

The Component Status index is generated from frontmatter on mdx files.

Coverage increased (+0.008%) to 88.49% when pulling adfae5cb2a18b204b57a97e8c514147e26d6b058 on abutterworth/add-status-page into 0af23a5a66bb63f07e57cacd8efc2b7cec5e347f on master.

:tada: This PR is included in version 4.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


D

Work done:

added more tests to test_testserver
added more spaces for readability

@CodiumAI-Agent /review

PR Analysis

🎯 Main theme: Adding more tests and improving readability in test_testserver.py
📝 PR summary: This PR focuses on enhancing the test coverage and readability of the test_testserver.py file. It introduces new tests and adds spaces for better readability.
📌 Type of PR: Tests
🧪 Relevant tests added: Yes
⏱ Estimated effort to review [1-5]: 2, because the PR mainly involves adding new tests and spaces for readability, which are straightforward to review.
🔒 Security concerns: No security concerns found

PR Feedback

💡 General suggestions: The PR is well-structured and focuses on enhancing the test coverage and readability of the code. However, it would be beneficial to avoid excessive use of blank lines for spacing as it can make the code look sparse and harder to read.

 🤖 Code feedback:

relevant file: tests/test_testserver.py
suggestion: Consider removing excessive blank lines to improve code readability. [medium]
relevant line: '+'

relevant file: tests/test_testserver.py
suggestion: Consider using more descriptive test function names to improve code readability and maintainability. [medium]
relevant line: '+    def test_request_recovery_with_bigger_timeout2(self):'

relevant file: tests/test_testserver.py
suggestion: Avoid using magic numbers in your tests. Consider defining them as constants at the top of your file or within your test class. [medium]
relevant line: '+            time.sleep(20)'

relevant file: tests/test_testserver.py
suggestion: The 'fire_in_the_disco' function seems to be complex and hard to understand. Consider simplifying it or adding comments to explain its purpose and how it works. [important]
relevant line: '+    def fire_in_the_disco(msg):'

How to use
 Instructions

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands:
/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs: Generate docstring for new components introduced in the PR.
/generate_labels: Generate labels for the PR based on the PR's contents.
see the tools guide for more details.

To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.

@CodiumAI-Agent /improve


Enable firewall rule on kubernetes nodepool

Current Provider Version
tf -version
Terraform v1.7.4
on linux_amd64
+ provider registry.terraform.io/ionos-cloud/ionoscloud v6.4.13

Use-cases
I would like to enable the firewall of kubernetes nodepool by using terraform. Currently when creating a nodepool I do not have access to the server or nic resource that contains this  flag.
Attempted Solutions
I tried to import the nic ressource but this a little bit tricky.
Proposal
I see 2 possibilities to address that topic.

Allow enablement of the firewall as a nodepool property boolean flag.
Provide an attachment ressource that allows to perform additional configuration of an nic ressource.

This is not supported in the backend. There were discussions at some point, but there are no clear plans to allow this.

@cristiGuranIonos Does this mean it is not possible to enable the firewall with terraform. Is there a workaround by using an API call?

As a workaround I tried with creating an additional NIC to perform the firewall enablement action but as you already stated I get the error message that the resource is managed by k8s:
│ Error: error occured while creating a nic: an error occured while creating nic for dcId: 8f9e61ba-e4a3-417d-8386-1871102a4d4e, server_id: 81cef2fa-b6ee-486d-b165-cd689fc97a00, Response: (403 Forbidden {
│   "httpStatus" : 403,
│   "messages" : [ {
│     "errorCode" : "452",
│     "message" : "Access Denied: Server 81cef2fa-b6ee-486d-b165-cd689fc97a00 is managed by 'k8s'."
│   } ]
│ }
│ )

tf:
resource "ionoscloud_k8s_node_pool" "node_pool" {
  name        = var.ionos_k8s_nodepool_name
  k8s_version = var.ionos_k8s_nodepool_version
  maintenance_window {
    day_of_the_week = "Sunday"
    time            = "03:30:00Z"
  }
  datacenter_id     = data.ionoscloud_datacenter.dc.id
  k8s_cluster_id    = ionoscloud_k8s_cluster.cluster.id
  cpu_family        = "INTEL_SKYLAKE"
  availability_zone = "AUTO"
  storage_type      = "HDD"
  node_count        = var.ionos_nodepool_spec.node_count
  cores_count       = var.ionos_nodepool_spec.cores_count
  ram_size          = var.ionos_nodepool_spec.ram_size
  storage_size      = var.ionos_nodepool_spec.storage_size

  # initial deploy private lan
  lans {
    id              = ionoscloud_lan.private.id
  }
}

data ionoscloud_servers k8s_nodes {
  datacenter_id = data.ionoscloud_datacenter.dc.id

  filter {
    name = "name"
    value = var.ionos_k8s_nodepool_name
  }

  depends_on = [ionoscloud_k8s_node_pool.node_pool]
}

resource "ionoscloud_nic" "public_nic" {

  count = var.ionos_nodepool_spec.node_count

  datacenter_id   = data.ionoscloud_datacenter.dc.id
  server_id       = data.ionoscloud_servers.k8s_nodes.servers[count.index].id
  name            = "NIC ${ionoscloud_lan.public.name}"
  lan             = ionoscloud_lan.public.id
  firewall_active = true

  depends_on = [ionoscloud_k8s_node_pool.node_pool]
}

Treating the nodepool as a normal server is not allowed as it might lead to undefined behaviour.


Init packet

It should be like this.

Alright I've been really busy so I can't get on my PC that often, but I trust you and I'll merge it.


set ipython accessor at _plot_area module level

It's not accessible from within the scope of the method for some reason, can just have it at module level scope instead, shouldn't be any caveats to this:
https://github.com/fastplotlib/fastplotlib/blob/68cf50b319d76196d4bed487128d36f1616706d1/fastplotlib/layouts/_plot_area.py#L676

I can't seem to produce this on my desktop with a simple example, maybe it's the Flatiron cluster or that this call was nested in a real usecase notebook, will try to reproduce :thinking:
@apasarkar have you ever gotten errors with iw.set_data() in notebooks??

Done in #611


Release version 2.0.3

Questions
Answers

Description?
Release version 2.0.3

Type?
bug fix / improvement / new feature / refacto / critical

BC breaks?
yes / no

Deprecations?
yes / no

Fixed ticket?
Fixes PrestaShop/Prestashop#{issue number here}.

How to test?
Please indicate how to best verify that this PR is correct.

Hello @Hlavtox
THanx for the PR ! LGTM QA :heavy_check_mark:

https://user-images.githubusercontent.com/31663369/212715239-67f98d3f-2c4a-4613-a07a-c83d8a56cf47.mp4
Thank you ! :rocket:


Messaging API

Is your feature request related to a problem? Please describe.
The sidekick is loaded in the extension sandbox, which means that content pages can't easily interact with it through the JS API.
Describe the solution you'd like
Content pages should have the ability to communicate with the sidekick. This can be provided via the external messaging system supported by Chrome. The admin service is already making use of it to send the login token to the extension. This should be extended to the following API:
chrome.runtime.sendMessage(
  'extensionId',
  { action: 'actionName', owner: 'adobe', repo: 'foo' },
  (res) => {
    // callback function
  },
);

The following actions should be supported:

updateAuthToken to set the auth token for a project (restricted to messages from https://admin.hlx.page)
loadSidekick to trigger the sidekick on custom domains without the need for configuration
getStatus to retrieve the status for the current resource

Describe alternatives you've considered

communicate via attributes
dispatch events on document or helix-sidekick element
both dismissed for usability reasons

The official extension ID is ccfggkjabjahcjoljmgmklhpaccedipo. Your local, unpacked extension's ID can be found by navigating to chrome://extensions and checking Developer Mode at the top right. This will display the extension ID on the card:

:tada: This issue has been resolved in version 6.24.0 :tada:
The release is available on:

GitHub release
v6.24.0

Your semantic-release bot :package::rocket:


Python-latest

I tested on multiple Pythons, and 3.7 and 3.8 no longer worked, but 3.10 and 3.11 do.

Hi @DouweM – thanks for contributing. And sorry for taking so long to get back. I missed the notification on this.
Have you also been able to run the test suite successfully (pytest)?
When I try to run the tests, I get
INTERNALERROR> AttributeError: module 'collections' has no attribute 'Callable'
Seems to be an issue with readline.

That's on Windows. Maybe you're not on Windows?

https://github.com/pdbpp/pdbpp/issues/498
I'll just remove the pdbpp dependency. Will merge this now. Thanks again.


[Cosmos] Remove ClientSideMetrics

This is technically a breaking change, so we will revisit when we do a v4


Add ProductPage and ProductListPage

Note: includes unrelated https://github.com/zytedata/zyte-common-items/pull/19/commits/34528b2d720f83ad745a69068e75f65f47ce9374 and https://github.com/zytedata/zyte-common-items/pull/19/commits/2d1cd89d1dc7ba16524df311a5d2391989f84bf3

Today I Learned attrs expects underscore attributes to be passed to __init__ without the underscore.

Codecov Report

Merging #19 (b19b833) into main (0dbb593) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #19   +/-   ##
=====================================
  Coverage   0.00%   0.00%
=====================================
  Files          6       6
  Lines        238     252   +14
=====================================
- Misses       238     252   +14

Impacted Files
Coverage Δ

zyte_common_items/base.py
0.00% <0.00%> (ø)

zyte_common_items/pages.py
0.00% <0.00%> (ø)

zyte_common_items/__init__.py


[Interop Test] Use distroless for C++ xDS tests

This should drastically reduce number of vulnerabilities.
Tested locally by running the test
ref b/282107030

This broke builds:
https://source.cloud.google.com/results/invocations/2808550c-034d-4d0d-9265-6a4a18e3c59d
#13 0.270 tools/bazel: line 83: curl: command not found
#13 ERROR: process "/bin/sh -c tools/bazel build //test/cpp/interop:xds_interop_client" did not complete successfully: exit code: 127
------
 > [stage-0 7/8] RUN tools/bazel build //test/cpp/interop:xds_interop_client:
#13 0.266 INFO: Running bazel wrapper (see //tools/bazel for details), bazel version 6.1.2 will be used instead of system-wide bazel installation.
#13 0.269 Downloading bazel, will try URLs: https://storage.googleapis.com/grpc-bazel-mirror/github.com/bazelbuild/bazel/releases/download/6.1.2/bazel-6.1.2-linux-x86_64 https://github.com/bazelbuild/bazel/releases/download/6.1.2/bazel-6.1.2-linux-x86_64
#13 0.270 tools/bazel: line 83: curl: command not found
#13 0.270 tools/bazel: line 83: curl: command not found
------
Dockerfile.xds_client:32
--------------------
  30 |
  31 |     COPY . .
  32 | >>> RUN tools/bazel build //test/cpp/interop:xds_interop_client
  33 |     RUN cp -rL /workdir/bazel-bin/test/cpp/interop/xds_interop_client /artifacts/
  34 |
--------------------
ERROR: failed to solve: process "/bin/sh -c tools/bazel build //test/cpp/interop:xds_interop_client" did not complete successfully: exit code: 127

Please revert


Remove unused image

Deleting unused image, per https://github.com/dotnet/docs/pull/8067#issuecomment-427192486

Ah, I missed that context in the PR. Added another commit to do that.


Package upgrade: location 4.1.1 --> 4.2.0

Summary
Package upgrade: location 4.1.1 --> 4.2.0
Changelog
[General] [Change] - Upgrade location from 4.1.1 to 4.2.0 (changelog)
Test Plan
Regression test the following areas:
./lib/core/providers/wayfinding.dart
./lib/core/providers/location.dart
./lib/app_provider.dart

Closing in favor of #1433


Stream not restarting

Describe the bug
I was asked to reopen this issue here.
Ok let me first try and explain what I'm trying to do and my current setup. Like many of us I'm an IT person so I get most of this but I'm not a programmer by trade. I'm a Network Engineer so very familiar with Cisco, Wireshark, Fortigate, etc.
I have several Wyze cameras already setup with RSTP through FFMPEG and eventually I plan on building a DeepStack AI Facial Recognition with a Jetson Nano soon, so I would like to be able to add this to that mix. Now I bought the 1080p version of the wired camera but it's somewhat confusing as far as their 2K camera vs the 1080p. But anyway the model number is T8201.
I have everything setup like you have in your install script. Including the 2 conditional cards for viewing. I'm able to see all of the sensors and the last captured image. If I click on the still image it starts the generic Eufy Start Stream and the stream then progresses through the WebRTC plugin. So the problem comes after the 3 min stream and trying to reset the environment for another viewing. So after a fresh boot of HA, I can click the image and the stream works fine. If I then run camera.turn_off and turn_on accordingly, the stream still stays hung. I end up having to restart both the Eufy and RSTP add-on and then reloading the Eufy integration before everything resets and I'm able to view the stream again. That or restart HA
To Reproduce
Steps to reproduce the behavior:
See above
Expected behavior
Person clicks on latest still image captured and live stream starts, after so many min it goes back to the last image captured and if you want to view the stream again, just click the image
Or even better, click the image and it stays streaming until the person leaves the page.
Screenshots & Logfiles
If applicable, add screenshots and logfiles to help explain your problem.
Versions:
Client version: <0.5.3>
Node version:
Operating system:
Additional context
Add any other context about the problem here.

hi @bropat , i had a chance to debug this issue but could not generate debug logs as my integration does not support captcha yet.
When I started p2p live stream, video data is arriving but when I stop p2p live stream, docker was hanging up and freeze. There was no way to stop the docker other than killing it. Of course, it is not responding any further commands until it is restarted.
I had asked @LordNex to open this issue here so you can take a look.

I think I have found the issue. Tomorrow I will fix it.

@fuatakgun @LordNex
I thought I understood what the problem was, but after taking a closer look it is not clear to me.
Can someone send me the debug logs?

If you can let me know exactly what log file you need and how you need it I’d be happy to send it.
On Nov 24, 2021, at 12:32 AM, bropat @.***> wrote:

@fuatakgunhttps://github.com/fuatakgun @LordNexhttps://github.com/LordNex
I thought I understood what the problem was, but after taking a closer look it is not clear to me.
Can someone send me the debug logs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/bropat/eufy-security-client/issues/70#issuecomment-977573362, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACGXNJFFUX3IWNM3YMQF253UNSBJJANCNFSM5ITZPM4A.

Sweet. Let me know if there’s anything I can do to assist. And thanks again!
On Nov 23, 2021, at 1:39 PM, bropat @.***> wrote:

I think I have found the issue. Tomorrow I will fix it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/bropat/eufy-security-client/issues/70#issuecomment-977075186, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACGXNJGCVLZBZI3DXMDIEDDUNPUYPANCNFSM5ITZPM4A.

can you implement a function to set the debug level on the fly? I can start add-on with no debug parameter and when problem starts to happen, i can change it, is this feasible?

@fuatakgun
Yes, that should be possible. But this functionality does not have to be implemented here, but in the other project eufy-security-ws.
Can you please make an enhancement request in the other project?
Regarding this issue, I think it is correlated with issue #66 and will be fixed with its fix.

I also on correlation, expecting to be fixed with new release, thanks for quick resolution. :clap:

Version 1.5.0 released which includes the fix.


examples: Add CILIUM_WAIT_BPF_MOUNT variable to minikube DS

The variable CILIUM_WAIT_BPF_MOUNT was missing in minikube DaemonSet
which made wait-bpf-config ConfigMap key not having any effect on the
init script.
Fixes #8646
Signed-off-by: Michal Rostecki<EMAIL_ADDRESS>

This change is

test-me-please

Coverage increased (+0.01%) to 44.123% when pulling ede8c24863532f97d73a04e214fad1e501927ee2 on mrostecki:fix-wait-bpf-mount into 531a554b8ea139e0e23a853b46a70d671f70104d on cilium:master.

I tested this with the main DaemonSet yaml and the env was defined


Make more grammatical sense

Just cleaning up english :)

Actually on second thoughts depends how you interpret XSS- doesn't matter in hindsight


Trackers

Can you add blocklist please?
https://raw.githubusercontent.com/StevenBlack/hosts/master/hosts
Trackers by Vivo Mobile (have a couple of dns queries)
tr-vcode-od.vivoglobal.com
tr-vcode-api.vivoglobal.com
tr-st-sl.vivoglobal.com
tr-domaincfg.vivoglobal.com
tr-timesync.vivoglobal.com
tr-romsp-unifyconfig.vivoglobal.com
asia-ex-adlog.vivoglobal.com
asia-analyzer-appstore.vivoglobal.com
asia-exstsdk.vivoglobal.com
asia-comort-stsdk.vivoglobal.com
asia-comonrt-stsdk.vivoglobal.com
asia-analyzer-appstore.vivoglobal.com
Trackers by Vodafone
netperform-is.vodafone.com.tr
vodafonetr.sc.omtrdc.net
mplusps.ims.vodafone.com
mpluswf.ims.vodafone.com
Advertising
advertise.ldplayer.net
creative.eagllwin.com
api.eagllwin.com
storeen.ldmnq.com
Google Spyware (have a couple of dns queries)
telephonyspamprotect-pa.googleapis.com
growth-pa.googleapis.com
deviceintegritytokens-pa.googleapis.com
gmscompliance-pa.googleapis.com
mdh-pa.googleapis.com
firebaseinstallations.googleapis.com
digitalassetlinks.googleapis.com
tags.tiqcdn.com

@trackerct:
Out of respect for @StevenBlack - and his personal life and time - perhaps you should provide a specific explanation and/or example why each of these domains should be blocked, rather than simply providing a list of domains and expecting him to figure it out.

@trackerct:
Out of respect for @StevenBlack - and his personal life and time - perhaps you should provide a specific explanation and/or example why each of these domains should be blocked, rather than simply providing a list of domains and expecting him to figure it out.

Beacuse they are tracker and advert hosts?
Example: netperform-is.vodafone.com.tr (tracker)
(Vodafone NetPerform · Network coverage. This application will capture statistics about your connectivity for phone calls. · Internet connectivity · Call quality)

Beacuse they are tracker and advert hosts?

How specifically have you determined this?

in my phone:)
install apk file on your phone and watch
https://play.google.com/store/apps/details?id=dnsfilter.android


Allow users to add a small biography to their profile

This will allow a user to add some more information regarding their occupation, specialization, interests and experience. That additional information can be useful for users interested in a speaker, for event organizers to get a feel for a speaker or for getting some context behind a comment.
The changes made in the API will be used by joindin/joindin-web2#443.
Github pages documentation is updated in #450.

Thanks, this is a nice addition


Change the First Paragraph of README File

I have Changed the First Paragraph of Main Readme file Which looks more influential than the previous one. Hope for the approval!!

Closing this PR as not Planed


Generated code imports own package (import cycle)

There may be a way to avoid this using the package and modelpackage flags, but it isn't obvious to me.
My situation is I'm generating in the foo/bar/model package, and types.json includes "Form": "foo/bar/model.Form"
Expected Behaviour
Generator recognizes this is the destination package, does not attempt import.
Actual Behavior
generated.go includes import line:  "foo/bar/model" resulting in import cycle.

a simple schema to reproduce the bug:
input Filter {
  offset: Int!
  limit: Int!
}

type Todo {
  id: String!
  text: String!
  author: User!
  events(filter: Filter = {offset: 0, limit: 25}): [Event!]!
}

@z0mbie42 i filled in some of the missing items i see a interesting bug with Filter.
input Filter {
  offset: Int!
  limit: Int!
}

type Todo {
  id: String!
  text: String!
  author: User!
  # the default value cause a bug
  events(filter: Filter = {offset: 0, limit: 25}): [Event!]!
}

type User {
  name: String!
}

type Event {
  name: String!
}

type Query {
  todos: [Todo!]!
}

generates the following:
			var tmp interface{} = map[string]interface{}{"offset":0"limit":25}

there is a missing comma between the offset and limit.

Thanks for the defaults fix.
The import loop is less obvious, most of the examples work the way you're describing. eg https://github.com/vektah/gqlgen/blob/master/example/scalars/types.json#L2
I wonder if this is another case sensitivity issue, what OS are you running? Have you tried since https://github.com/vektah/gqlgen/pull/136?
A more complete example would be handy here.

The simpler way to reproduce the error is using the following project:
https://github.com/z0mbie42/goes/blob/master/_examples/api
and replace https://github.com/z0mbie42/goes/blob/master/_examples/api/schema.graphql#L14
 events(filter: Filter): [Event!]!

by
events(filter: Filter = {offset: 0, limit: 25}): [Event!]!

But, after applying the patch #146 the code generate without error (no missing comma and no import cycle)


Training data for KITTI test submission

Hi,
May I know whether you used all the 7k training and validation samples as labelled training data for your reported results on the KITTI test server?
Thanks.

Yes, we have used all the 7K labeled data for the KITTI test leaderboard submission.

Ok thanks!


Adding NewsX API to News

[x] My submission is formatted according to the guidelines in the contributing guide
[x] My addition is ordered alphabetically
[x] My submission has a useful description
[x] The description does not have more than 100 characters
[x] The description does not end with punctuation
[x] Each table column is padded with one space on either side
[x] I have searched the repository for any relevant issues or pull requests
[x] Any category I am creating has the minimum requirement of 3 items
[x] All changes have been squashed into a single commit

Thanks for guiding me @matheusfelipeog
I have updated as per your suggestions.
Cheers
HD

Thanks for the contribution @unixguru2k


[feat] Render to INI-style formats

I know your bandwidth is limited, just putting it out there. I would love to see support for INI-like formats, such as systemd configuration files or even just plain ini files.

It's a totally legit ask. For other output formats, especially "simpler" ones, we recommend implementing them in Pkl itself. We did this with the TOML renderer, for example: https://github.com/apple/pkl-pantry/tree/main/packages/pkl.toml
Since bandwidth is indeed limited, you might want to have a go at it that way yourself; we're more than happy to support / review / etc. and since this can be written in Pkl itself, it doesn't require expertise about Pkl internals.

Hi, ill have a look at starting to create a INIRenderer.

since this can be written in Pkl itself, it doesn't require expertise about Pkl internals.

I love that
Unfortunately my bandwith is also limited :skull: but I might get into making some other renderers at a later point, sounds like a fun challenge

Its looking good so far the ini renderer corretly renders ini files as in the correct structure just need to handle escape code and correctly formatting the ini file. Here is a look at what the test outputted.
int = 123
float = 1.23
bool = true
string = Pigeon
unicodeString = abc😀abc😎abc
multiLineString = have a
great
day
[map]
one = 123
two = 1.23
three = true
four = Pigeon
five = abc😀abc😎abc
six = have a
great
day
[map.seven]
name = Pigeon
[mapping]
one = 123
two = 1.23
three = true
four = Pigeon
five = abc😀abc😎abc
six = have a
great
day
[mapping.seven]
name = Pigeon
[typedObject]
name = Pigeon
age = 30
[typedObject.address]
street = Folsom St.
[container]
name = Pigeon
age = 30
[container.address]
street = Folsom St.

Its now outputting correctly and handles escape chars. Is there anywhere else i need to add the IniRenderer to?

Nice! Do you want to PR this? That will make it a little easier to iterate.
To add a new in-language renderer, you will need to create a new standard library module. To do that:

Create the stdlib module itself; stdlib/ini.pkl
Create a new class in org.pkl.core.runtime that extends StdlibModule, and add it to org.pkl.core.runtime.ModuleCache#getOrLoad (see the existing source code to look at what's currently already there).
Create a class RendererNodes in new package org.pkl.core.stdlib.ini (see the other stdlib packages that are in there for reference)

You will also need to add language snippet tests for this renderer, in pkl-core/src/test/files/LanguageSnippetTests/input/api/

Also make sure that you follow the contribution guidelines

Created PR. Ill create the new in-language renderer soon and open another PR.
Thank you for the help.


[Bug] getSchemaInfoAsync is not honoring the PulsarClient timeout

Search before asking

[X] I searched in the issues and found nothing similar.

Version
Pulsar Client CPP version: 3.3
Minimal reproduce step
getSchemaInfoAsync is not honoring the PulsarClient timeout and is not timing out.
What did you expect to see?
Currently, we are having getSchemaInfoAsync method which gives the schema version asynchronously. We need a method to get the schema version synchronously and which will honor the pulsar client timeout.
What did you see instead?
getSchemaInfoAsync is not honoring the PulsarClient timeout and is not timing out.
Anything else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

It needs some refactoring to add a test because the operation timeout is configured by seconds, not milliseconds. I'm going to work on this issue next week.


Ensure creation of new backend nodes can control versions installed

We recently merged #556 that moved what was formerly the deploy repo to the ./deploy folder in this webapp-public repo.  One remaining issue is to follow up on new node creation with that ./deploy folder, ensuring that versions can be controlled for Tax-Calculator, B-Tax, and OG-USA, either from conda installs (with any anaconda.org user/label) or setup.py installs.

@PeterDSteinberg, is this still required now that we are pinning versions?


Add restrictedAdmin option to Helm chart options

I have added a thing that says the restrictedAdmin option is available as of v2.5 https://github.com/rancher/docs/commit/f0c5521edebce47f2a8a3fdd30aa3021f18ed9db


(#1) Integrated a Genetic Algorithm that solves The Prisoner's Dilemma.

This change is

For the README:


Add capability support to VTS APIs

VTS is intended to encapsulate high-trust services. In order to ensure overall system security, clients should be granted the minimum privileged access to VTS APIs they need to perform their job.
Assign capabilities to VTS APIs based on the function they perform w.r.t. protected assets (e.g. "READ", "WRITE", etc).
Add a mechanism for restricting API access to client connections based on the required capabilities.

This issue is migrated here from https://github.com/veraison/veraison/issues/131


TEST: check if codecov.yaml ignores checkqa for status

Using the following in the team config:
codecov:
  ci:
    - !checkqa

Sorry for the delay. Circle changed their context strategy. Can you try this:
codecov:
  ci:
   - "!circleci: checkqa"

@stevepeak
Thanks, that works!


[$1000] Settings - Share code - The text goes beyond the borders + error in console

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/18636
Action Performed:

Go to URL https://staging.new.expensify.com/
Go to Settings -> Share code

Expected Result:
The text should be within the border
Actual Result:
The text goes beyond the borders + error in console
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a529909438a3942d
Upwork Job ID:<PHONE_NUMBER>090259456
Last Price Increase: 2023-05-18

I think that makes sense. Though if it was two names, I think we it would be okay to break the line in between the first and last name. Can you show an example like that?

The text ellipsizing is already implemented here: https://github.com/Expensify/App/pull/18946
You're proposal on changing the qrCodeSize was correct. Otherwise, the react-native-qr-code-svg library would divide by 0, which results in NaN

Reproducible

Can't reproduce on staging

We can close this issue as this is dupe

Thanks @gadhiyamanan - this does indeed appear to be a dupe. Closing!


Update the Instance Type to M5.Large

You're stilling using the m3.large instance type which is $.14 an hour standard and 2vCPU,7.5GB-RAM. You may be able to get better and cheaper performance by migrating to the newer M5.Large instances which are $0.096 an hour and 2vCPU/8GB-RAM.

Thanks for the suggestion, we'll look in to it.

The test instance types have been updated.