sem: Why do we need alignment hack for all arches

https://github.com/libcsp/libcsp/blob/de88960c9502c80931cef5272d13b49921586a8e/include/csp/arch/csp_semaphore.h#L48-L57
@johandc, would you mind elaborating me why we needed this alignment thing for all arch?

Yes. I thought it would be nice for all semaphores to be statically allocated. This was previously done with a macro that resolved to some arch native type. So a csp_sem_t was not an actual type, it was an OS thing that put a requirement on an external header. Like FreeRTOS.h or zephyr.h for anybody who uses the semaphores. So i guess it helps reduce the number of headers that gets pulled in.
I don't know which is better. To use the union to perform the alignment or the GCC attribute align.

I thought it would be nice for all semaphores to be statically allocated.

I agree.

So i guess it helps reduce the number of headers that gets pulled in.

Why did you want to reduce the number of header files to be included?
Header files are there to be used.  Let's use it when we need it.
I can keep this tricked typdef for FreeRTOS like the following or convert to simple typedef StaticSemaphore_t csp_bin_sem_t;.  What do you think?
diff --git a/include/csp/arch/csp_semaphore.h b/include/csp/arch/csp_semaphore.h
index 4b47616c..e605ecd3 100644
--- a/include/csp/arch/csp_semaphore.h
+++ b/include/csp/arch/csp_semaphore.h
@@ -22,9 +22,8 @@
  */

 #if (CSP_POSIX || __DOXYGEN__)
-
-    /* POSIX interface */
-    #define CSP_SIZEOF_SEM_T 32
+#include <semaphore.h>
+typedef sem_t csp_bin_sem_t;

 #elif (CSP_FREERTOS)

@@ -35,16 +34,6 @@
 #define CSP_SIZEOF_SEM_T sizeof(StaticSemaphore_t)
 #else
 #define CSP_SIZEOF_SEM_T sizeof(void *)
-#endif
-
-#elif (CSP_ZEPHYR)
-
-    /* Zephyr RTOS Interface */
-    #include <zephyr.h>
-    #define CSP_SIZEOF_SEM_T sizeof(struct k_sem);
-
-#endif
-
 /**
  * This definition is borrowed from POSIX sem_t
  * It ensures the proper amount of memory to hold a static semaphore
@@ -56,6 +45,13 @@ typedef union {
 	long int __align;
 } csp_bin_sem_t;

+#endif
+
+#elif (CSP_ZEPHYR)
+#include <zephyr.h>
+typedef struct k_sem csp_bin_sem_t;
+#endif
+
 /**
  * initialize a binary semaphore with static storage
  * The semaphore is created in state \a unlocked (value 1).

I don't want any implementation specific headers in the public CSP headers. The reason is that CSP should not rely on external headers compile time, for people who are using our API.
However one could argue that since we discourage the use of #include csp/arch in the first place, we might as well just move the header file to internal path. And then I agree that using the typedef is prettier.

I don't want any implementation specific headers in the public CSP headers.

We have inconsistency.  csp_queue.h has arch specific things.

The reason is that CSP should not rely on external headers compile time, for people who are using our API.

Why?  We can't basically avoid that.  If you are using FreeRTOS and CSP needs some kernel specific features, we must build against it.  That's because we must know the size of the object at the compile time.  And to avoid it, the trick you used is to put a literal number for the size of object by assuming the size won't change?
It's always nice to reduce dependencies. But, when we need it, we must use it.

just move the header file to internal path

How about:

include/csp/csp_semaphore.h for the public header
include/csp/arch/csp_semaphore_freertos.h for arch specific internal header.

I don't want to break the current applications at this stage so I'd

Keep include/csp/arch/csp_semaphore.h for 2.0
Create include/csp/csp_semaphore.h for the new header file which includes include/csp/arch/csp_semaphore.h
After 2.0 is released,

Warn when include/csp/arch/csp_semaphore.h is included directly, and
Tell users the old path is deprecated and must use #include <csp/csp_semaphore.h>

I've got an idea.  This is based on one rule.

OS agnostic source code does NOT allocate OS specific object.

It's simple and acceptable, right?
Pros are

We don't need to know anything about OS specific objects in our public header
OS specific code must access the object, thus needs OS specific header file
Application is OS specific anyway and must include OS specific header file

Cons are

Our header files are not self-contained.  Some coding style requires it (google)

Here is sample code
application code: main.c
#include <stdio.h>
#include <someos.h>
#include "lib.h"

int main()
{
	Foo f;
	func(&f);
	printf("%d\n", f.a);
	return 0;
}

public header: lib.h
struct foo;

typedef struct foo Foo;

void func(Foo *f);

OS specific library source: lib_someos.c
#include <someos.h>
#include "lib.h"

void func(Foo *f)
{
	f->a = 100;
}

OS header file: someos.h
struct foo {
	int a;
};

How to build
gcc -Wall -Wextra -g -I. main.c lib_someos.c && ./a.out

That is known as an opaque pointer.
It is frequently used to hide the implementation of something. As for example the task control block (tcb) of FreeRTOS is an opaque pointer.
I like this approach because it also eliminates a large if/elseif block of code that needs to be maintained. Making the size available to the allocating unit, through a someos.h header seems very reasonable.
Sometimes only parts of the data structure is made available, and the rest is undocumented or obfuscated by variable names such as hidden, or reserved. While on the inside there is full access. The whole idea is to make the user responsible for the buffer, but to disallow any access or knowledge about the contents.
So I applause that as a solution in general.
However. To answer your question from above, I guess the reason I don't want FreeRTOS headers in the public API is still valid, because, I don't believe that csp_sem should be part of the API at all. There are several other os abstraction layers out there. So CSP should only contain what it needs to operate itself. Calling as few hooks and requiring as little from the OS as possible. The ultimate goal is still to be able to run on barebone too.
This hack is literally directly out of the posix semaphore implementation. It was much more beautiful than the rather complex FreeRTOS static semaphore setup which required a handle, a queue, and a queue item buffer. So i rewrote the semaphore from consisting of three objects, and a complex init function, to just a single object which is what's nice about that posix implementation. I can see that zephyr also uses the same notion with a single object.
However now that I got the much much more efficient vTaskNotify to work on FreeRTOS. The static semaphore is in fact just a void pointer to the task to wake up. So it got even better.
In conclusion, we should work on getting the queue and the semaphore out of the API.

I don't believe that csp_sem should be part of the API at all.

OK.  I think I now understand that you only want use csp_sem internally, because libcsp proper needs some locking mechanism, but not wanting to expose the internal semaphore to the applications. Applications, OTOH, can just use whatever they have.
Let me work on that.

Yes exactly. The same with queue.
CSP does need that. But I was wondering if it was prettier to write our own input queue management using just <stdatomic.h> and a ringbuffer. Together with the csp_sem for task notification that should be all that is needed.
If you look at the amount of work done in FreeRTOS for queues and similarly on POSIX. It can all be simplified by the fact that:
Any queue or semaphore in CSP only ever has one consumer and one producer. So queues can be reduced to an atomic update and a means for synchronization.
This latter could be a POSIX or zephyr semaphore, a FreeRTOS task notification or even just a barebone os setting a flag somewhere outside the library.
I think this is what is really necessary for CSP to run on baremetal. Which would be cool. Because so far. Half of CSP development has been around porting to different environments.

Because so far. Half of CSP development has been around porting to different environments.

Right. I'd love to get done with porting and work on libcsp proper. :smiley:
I don't know I can do as I say but I'll move csp_sem to internal, add configuration option to expose it as public API (default expose) in order to keep it compatible for v2.0.  If you beat me to it with the new implementation, I'll drop my PR.
How does that sound?

I think we don't need to make an option to export the header. People moving to CSP 2 should change their code. CSP 2 is backwards compatible (in legacy mode) on the interface only. Not the full API. So I think it's as simple as moving the header file and modifying the typedefs.


Icons change, redirect fix and form link

I want to work on this issue under JWOC.

Replacing links would be good. But can you work on any other aspect that improves the website more.

Sure. Shall I change the links as I have tested it locally?

Yes.

@Priyanshu88 google form link to "subscribe us" button of nav-bar. Fix it

@Priyanshu88 From Tech Updates and Jobs pages, clicking on site icon leads to 404 error.
Fix it too

Ok working on it. Can you please paste the google form link?

Ok working on it. Can you please paste the google form link?

https://docs.google.com/forms/d/e/1FAIpQLSdSNw19LnaM6Ve99y43WduXSn92KIjI7txHShHhZcWcu2S07Q/viewform

I have made changes in code. Everything is done.

Can you please add labels as I would like to merge this solved issue under JWOC?

I am interested to solve this issue please assign me this task


Improve Arabic support

Speaking with some people, it sounds like there are a few things we could do to improve Arabic support:

[x] Shift the nameplate to the right side of the screen when a text box is RTL
[x] Flip the arrow/triangle and shift it to the left side of the screen when a text box is RTL
[ ] Use a different font for Arabic (the person I was chatting with suggested Kawkab Mono; they said the current one didn't connect some characters properly, and as a result, some of the words could be misread)

Progress on this is going well, I just need to look into the replacement font(s):
https://user-images.githubusercontent.com/9957987/200745318-04ca93bc-e80f-4700-9a96-cc9bd9d86f1a.mp4
For some reason my installation of Pillow doesn't seem to be working with libraqm, so the text itself is coming out a bit weird...


deprecate message truncation

Implements #1577, but the issue should remain open until we clean up the debugging loglines.
This splits the baby: default.yaml has allow-truncation: false (and I plan for the test suite to run in this mode), but traditional.yaml has it as true, and it will default to true when unset (so no one gets surprised by their bots breaking).

This will also close #1575; regardless of the value of the new setting, this version of ircmsg will never truncate a valid UTF-8 message in the middle of a codepoint.


Odd Server Behavior

Noticed some odd behavior in the server when running on my work laptop as opposed to my desktop at home. The game status would frequently skip a turn. Sometimes as many as 5 between calls.
At first I thought I might have some faulty logic and my code was taking longer than a turn's time limit to  execute. But when I wrapped the logic in stop watches it was always executing in under a 1/10 of a second.
I'd also get strange, intermittent connection errors from the client to the server. Again, this was only ever on my work laptop. Home PC was fine. So I suspect the problem is environmental but wanted to post the issue in case anyone else was experiencing it.

Good to know! When @eonarheim runs the simulation, he will make sure everything is kosher.

@CoryGM
My first thought when you say your work laptop is having trouble but home machine is good, is that the antivirus is interfering with you.
I've seen odd things before when running code locally that is caused by antivirus. There may be a way to exclude visual studio. Also I have some secret sauce to temporarily disable antivirus, we can chat about that irl.


Add homogenization for translations

Custom translation ids instead of Akeneo's were inserted.
Homogenization of own translations.

@flagbird The naming *.attribute_table.* was already changed to *.table_attribute.*

Please change the naming *.attribute_table.* to *.table_attribute.*. Otherwise this looks fine to me.

@flagbird The naming *.attribute_table.* was already changed to *.table_attribute.*

Please change the base branch to 2.x.

Please change the base branch to 2.x.

Done and conflicts were solved.

I'll concentrate my review on the test of the translations only.

@AngelVazquezArroyo In the german translation is still an english word "Key". Is this by decision or is this a missed translation?

@AngelVazquezArroyo In the german translation is still an english word "Key". Is this by decision or is this a missed translation?

@flagbird the german translation is "Key" since the beginning of this bundle, so is not a missing translation. Anyway we may change it if you've a better alternative, since I'm not german native speaker.


Install/Update 1.1.0-2 Fails on WeeWX 5.0.0a24

I gave the new release a try as the last release (1.0.11) was working well in WeeWX 5 alphas.
I'm attaching the log from the attempt as wx5.txt
wx5.txt

I didn't know there were v5 alphas. I'll have to look into it.

I must have gotten lucky then with the last release.

I've just pushed a new commit updating the VM scripts.
I've tested the driver with v5 alpha and it seems to work now.

Which alpha and driver version?

Driver v1.1, WeeWX directly from Github repo V5 branch

Hmmm, fails to run here. It did install however.
Installing 1..0.11 works fine.
Attaching error log.
wx-wll.txt

It looks like it fails when there is an old driver installed.

Current release (1.1.1) fails when installing in WeeWX  5.0.0b17
sudo weectl extension install weewx-weatherlink-live-v1.1.1.tar.xz
Request to install 'weewx-weatherlink-live-v1.1.1.tar.xz'.
Extracting from tar archive weewx-weatherlink-live-v1.1.1.tar.xz
Traceback (most recent call last):
File "/usr/share/weewx/weectl.py", line 74, in
main()
File "/usr/share/weewx/weectl.py", line 66, in main
namespace.func(namespace)
File "/usr/share/weewx/weectllib/extension_cmd.py", line 112, in install_extension
ext.install_extension(namespace.source)
File "/usr/share/weewx/weecfg/extension.py", line 122, in install_extension
extension_name = self._install_from_file(extension_path, filetype)
File "/usr/share/weewx/weecfg/extension.py", line 154, in _install_from_file
extension_name = self.install_from_dir(extension_dir)
File "/usr/share/weewx/weecfg/extension.py", line 201, in install_from_dir
save_config |= self._inject_config(installer['config'], extension_name)
KeyError: 'config'

Release 1.1.2 following the install instructions does not install. Weewx seems to have changed many files and seems to be broken.

weectl extension list
Using configuration file /etc/weewx/weewx.conf
Extension Name    Version   Description
weatherlink-live  1.1.2     WeeWX driver for Davis WeatherLink Live.

So I think it's installed.

weectl station reconfigure
Only shows the default configurations. Not yours. Assuming the documentation is all wrong now and needs to be updated.

I just installed today.
All is fine with weewx 5.0.2 and 1.1.2
I used the pip install method and activated the vent
You don't mention if you are upgrading or what OS.


Question: with Cmd.getState, getState return the previous state or the next state?

In the reducer when I return:
return loop(nextState, Cmd.run(func, { args: [Cmd.getState ]})

when I execute getState in func, I'm going to retrieve the state after the reducer is executed, or before?

the nextState, after the reducer finishes.


Design doc

Problem
The research bureau and DIAG data team are currently using versions of the wado connector repo to download medical images from our existing AGFA VNA.
AGFA VNA will be replaced by a new vitrea VNA. This means the existing module will need to be rewritten. In addition, the existing module is not of good quality, being an extract from older anonymization server code.
Appetite
How much time we want to spend and how that constrains the solution
Having a re-usable, well documented module for interfacing with our VNA is important. Getting this right now will solve problems in the future. Big appetite: 3 weeks
Solution
The core elements we came up with, presented in a form that’s easy for people to immediately understand
For IDIS The following functions will have to be supported (in pseudocode):
get_study_info(StudyInstanceUID) -> PatientID
get_instance_uids(StudyInstanceUID) -> List[SOPInstanceUID]
download_wado_image(StudyInstanceUID, SOPInstanceUID, basedir) -> writes slice to base dir

These functions will be implemented in two steps: First, a clean internal connector module that works with pydicom Dataset objects wherever possible. Second a legacy layer the uses this module to offer methods matching the methods above.
Part 1: The connector module

This module interfaces with the vitrea VNA on one end, and offers high-level functions on the other.
User-facing functions such as 'give me all data for study X' or 'give me all SeriesUIDs for study X'
To do this it will employ standard connection mechanisms such as WADO, DICOM QR and MINT.
Wherever possible, the module will use pydicom Dataset objects to represent DICOM datasets.

Part 2: Legacy functions for existing applications
Existing applications are using several functions in the [https://github.com/sjoerdk/wado](wado module) at the moment. To make migration to the new module easier, a legacy module will be included

This will have functions with the same signature as the most-used current functions so that moving to the new module can be as changing in import statement.
usage in anonymization server all comes down to this function:
https://github.com/DIAGNijmegen/anonymization_server/blob/master/anonserver/databaserelated/wrappers.py#L483
Rabbit holes
Details about the solution worth calling out to avoid problems
No rewrite of existing module. Rewriting the existing wado connector will not be done because the code quality is too low. For instance, the library uses an old  custom library for modeling DICOM elements and tags that is inferior to pydicom Dataset in every way and makes it hard to integrate. In addition, the existing module's name is 'WADO' which is a misnomer as it also uses DICOM QR and possibly mint. Lastly, the login mechanism that the library was built for is convoluted. This is due to both the AGFA packs actually having a strange mechanism, and the coding being sub-par.
MINT or DICOM QR, not both. To replace existing functionality, we need a method te retrieve all SOPClassInstanceUIDs for a given study or series. This can be done either with MINT or DICOM QR. If one of these methods is implemented, the other can be left as a stub and not implemented in this iteration
Legacy functions are not essential. If discrepancies in internal workings of the old WADO and new module make legacy functions difficult to implement, we will provide a migration guide instead of a legacy functions
No-gos
Anything specifically excluded from the concept: functionality or use cases we intentionally aren’t covering to fit the appetite or make the problem tractable
Only implement existing functionality We will implement the ability to retrieve the DICOM images for studies from the VNA, and any queries related to that (e.g. find all slice IDs for a given study). No new functionality will be added.

This is now done. In retrospect the 3 weeks set for this was more then enough. As a result I went into one of the rabbit holes and implemented DICOM-QR as a search method in addition to MINT.


arch: arc: Remove ref. to undefined Kconfig sym. CONFIG_APP_SHARED_MEM

This symbol was removed in commit 4ce652e4b2 ("userspace: remove
APP_SHARED_MEM Kconfig").

Codecov Report

Merging #13811 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13811   +/-   ##
=======================================
  Coverage   52.26%   52.26%
=======================================
  Files         307      307
  Lines       45410    45410
  Branches    10504    10504
=======================================
  Hits        23733    23733
  Misses      16887    16887
  Partials     4790     4790

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c77c91...2e89905. Read the comment docs.

recheck


[JS] Manual port of empty alttext bugfix to release

Related Issue
Fixes #2235 in release/1.2
Description
Manual port of fix in 5bc63de25b0a4a71d862bbd41d6de6437ee2a5d9 (PR #4010).
How Verified

local build
local sanity check

Microsoft Reviewers: Open in CodeFlow

/azp run

/azp run


"from pwn import *" is automatically is closing ipython in the program interaction challenges.

I'm working on the program interaction challenges and want to use pwntools for a lot of these challenges, however, whenever I try to import the library with:
from pwn import *

It automatically exits ipython. To be more specific I'm on level19 of the program interaction challenges and I have absolutely no idea what's going on here:

The following doesn't fail:
from pwnlib import *

As seen below:

I don't know if this is equivalent to from pwn import * so if it is I will be rather embarrassed but it seems like the former is the standard way of using the framework.
I've tried in both the VSCode environment and in the VDesktop environment and the issue is the same. I have seen others using the library in this fashion to solve these challenges so I don't quite understand what's happening but I just thought I'd post an issue. Feel free to ask any questions you might have. Hopefully someone smarter than me can figure out what's happening!
Many thanks for the platform it's fantastic, already speedran babysuid and am stuck here. Going to continue with standard python libraries for now but would love if this worked because I want to be able to learn pwntools as well while I'm doing this as I'm sure it'll come in handy later down the line in the series.
Anyways, thanks again.
-austinzwile

Hello there!  This is certainly odd behavior.
from pwn import *

should work on the dojo, including in an IPython session.  Is it possible you have a directory named pwn or a pwn.py file in your working directory causing a name collision?  Python and Python will prioritize your current working directory over other module installation paths.

Would a shared object or c file cause this behavior?

To answer my own question, yes it does. Removing those two files solved the issue.

I used the pwn.so for babysuid51 (ssh-keygen GTFOBin/Library Load Exploit) which was pretty nifty. I'm thinking of making a HTB box oriented around that because I have mis-permissioned my ssh keys a handful of times, locking myself out of a couple of my servers by running:
chmod -R 755 /home/azw

In a momentary lapse of judgement haha. Feel free to close the issue, or if you'd like to implement a workaround leave it open, but for me it's resolved.


Facebook connection requires HTTPS however bucket URL is HTTP

For the MultiRegion instructions in:
https://github.com/aws-samples/aws-serverless-workshops/blob/master/MultiRegion/2_UI/README.md
You create the Facebook app and then launch the app via the CloudFormation Bucket URL Output.
You cannot launch the app and sign-in to Facebook. Error message is:

Insecure login blocked: You can't get an access token or log in to this app from an insecure page. Try re-loading the page as https://

As of October 2018, Facebook doesn't allow app connections from HTTP however the S3 bucket URL is via http so the app can't be logged into with Facebook.
Any ideas on a solution?
Thanks

It looks like the documentation has been updated to set the CloudFront default to redirect HTTP to HTTPS.


XACML JSON Multiple decision profile is not working

This is not working as expected and don't have sample for that even.

Thank you for your contribution!
We are closing this issue since it has not been prioritized for a long time. Chances are that it has already been solved in more recent versions. If not, we will be re-evaluating this when it becomes a priority.


As a purchasing manager, I can set the inventory quantity of my items

Closed by #151 during refactoring of Person to Item. This is already a command available in AB3.


Native library is out of date

EDIT: I realized there was another cmake script to be run in the java examples folder. Running this along with the "-DCMAKE_INSTALLPREFIX=/usr .." solved the issue.
Hi
I've been trying to get the tinyb java example to run but I've been running in to some problems. When I Run it it gives me this response:
`
root@Edison1:~# make run
cd build && java -jar tinyb_local.jar XX:XX:XX:XX:XX:XX

Exception in thread "main" java.lang.RuntimeException: Native library is out of date. Please update the native library.

    at tinyb.BluetoothManager.getBluetoothManager(BluetoothManager.java:234)

    at HelloTinyB.main(HelloTinyB.java:109)

Makefile:25: recipe for target 'run' failed

`
(I put the commands in a Makefile to be able to experiment more efficiently.)
I added two printouts in the BluetoothManager class to see the versions:
`
String nativeAPIVersion = getNativeAPIVersion();

String APIVersion = BluetoothManager.class.getPackage().getSpecificationVersion();

System.out.println(nativeAPIVersion);

System.out.println(APIVersion);

if (APIVersion.equals(nativeAPIVersion) == false) {`

It then gives me this:
`
root@Edison1:~# make run

cd build && java -jar tinyb_local.jar XX:XX:XX:XX:XX:XX

nativeAPIVersion: 0.4

APIVersion: 0.5.0-4-g22c1af<IP_ADDRESS>-4-g22c1af1

Exception in thread "main" java.lang.RuntimeException: Native library is out of date. Please update the native library.

at tinyb.BluetoothManager.getBluetoothManager(BluetoothManager.java:234)

at HelloTinyB.main(HelloTinyB.java:109)

Makefile:25: recipe for target 'run' failed

make: *** [run] Error 1

`
Below are the output I got from the build process.
building tinyb.jar
`
mkdir -p tinyb/build
cd tinyb/build && cmake .. -DBUILDJAVA=ON

$(MAKE) -C tinyb/build/

$(MAKE) -C tinyb/build/ MAKEFLAGS="install"`

`
mkdir -p tinyb/build
cd tinyb/build && cmake .. -DBUILDJAVA=ON

-- JNI_INCLUDE_DIRS=/usr/lib/jvm/java-8-openjdk/include;/usr/lib/jvm/java-8-

openjdk/include/linux;/usr/lib/jvm/java-8-openjdk/include

-- JNI_LIBRARIES=/usr/lib/jvm/java-8-openjdk/jre/lib/i386/libjawt.so;/usr/lib/jvm/java-8-

openjdk/jre/lib/i386/libjvm.so

-- Could NOT find Doxygen (missing:  DOXYGEN_EXECUTABLE)

-- Configuring done

-- Generating done

-- Build files have been written to: /home/root/tinyb/build

make -C tinyb/build/

make[1]: Entering directory '/home/root/tinyb/build'

make[2]: Entering directory '/home/root/tinyb/build'

make[3]: Entering directory '/home/root/tinyb/build'

make[3]: Leaving directory '/home/root/tinyb/build'

make[3]: Entering directory '/home/root/tinyb/build'

[  2%] Building Java objects for tinybjar.jar

[  4%] Generating CMakeFiles/tinybjar.dir/java_class_filelist

[  6%] Creating Java archive tinyb.jar

Generating JNI headers..

make[3]: Leaving directory '/home/root/tinyb/build'

[  6%] Built target tinybjar

make[3]: Entering directory '/home/root/tinyb/build'

make[3]: Leaving directory '/home/root/tinyb/build'

[ 32%] Built target tinyb

make[3]: Entering directory '/home/root/tinyb/build'

make[3]: Leaving directory '/home/root/tinyb/build'

[54%] Built target javatinyb

make[3]: Entering directory '/home/root/tinyb/build'

make[3]: Leaving directory '/home/root/tinyb/build'

make[3]: Entering directory '/home/root/tinyb/build'

[56%] Building Java objects for AsyncTinyB.jar

[ 58%] Generating CMakeFiles/AsyncTinyB.dir/java_class_filelist

[ 60%] Creating Java archive AsyncTinyB.jar

make[3]: Leaving directory '/home/root/tinyb/build'

[ 60%] Built target AsyncTinyB

make[3]: Entering directory '/home/root/tinyb/build'

make[3]: Leaving directory '/home/root/tinyb/build'

make[3]: Entering directory '/home/root/tinyb/build'

[ 62%] Building Java objects for HelloTinyB.jar

[ 64%] Generating CMakeFiles/HelloTinyB.dir/java_class_filelist

[ 66%] Creating Java archive HelloTinyB.jar

make[3]: Leaving directory '/home/root/tinyb/build'

[ 66%] Built target HelloTinyB

make[3]: Entering directory '/home/root/tinyb/build'

make[3]: Leaving directory '/home/root/tinyb/build'

make[3]: Entering directory '/home/root/tinyb/build'

[ 68%] Building Java objects for Notification.jar

[ 70%] Generating CMakeFiles/Notification.dir/java_class_filelist

[ 72%] Creating Java archive Notification.jar

make[3]: Leaving directory '/home/root/tinyb/build'

[ 72%] Built target Notification

make[3]: Entering directory '/home/root/tinyb/build'

make[3]: Leaving directory '/home/root/tinyb/build'

[ 76%] Built target asynctinyb

make[3]: Entering directory '/home/root/tinyb/build'

make[3]: Leaving directory '/home/root/tinyb/build'

[ 80%] Built target checkinit

make[3]: Entering directory '/home/root/tinyb/build'

make[3]: Leaving directory '/home/root/tinyb/build'

[ 84%] Built target esstinyb

make[3]: Entering directory '/home/root/tinyb/build'

make[3]: Leaving directory '/home/root/tinyb/build'

[ 88%] Built target hellotinyb

make[3]: Entering directory '/home/root/tinyb/build'

make[3]: Leaving directory '/home/root/tinyb/build'

[ 92%] Built target list_mfg

make[3]: Entering directory '/home/root/tinyb/build'

make[3]: Leaving directory '/home/root/tinyb/build'

[ 96%] Built target notifications

make[3]: Entering directory '/home/root/tinyb/build'

make[3]: Leaving directory '/home/root/tinyb/build'

[100%] Built target uuid

make[2]: Leaving directory '/home/root/tinyb/build'

make[1]: Leaving directory '/home/root/tinyb/build'

make -C tinyb/build/ MAKEFLAGS="install"

make[1]: Entering directory '/home/root/tinyb/build'

make -f CMakeFiles/Makefile2 all

make -f java/CMakeFiles/tinybjar.dir/build.make java/CMakeFiles/tinybjar.dir/depend

make -f java/CMakeFiles/tinybjar.dir/build.make java/CMakeFiles/tinybjar.dir/build

make -f src/CMakeFiles/tinyb.dir/build.make src/CMakeFiles/tinyb.dir/depend

make -f src/CMakeFiles/tinyb.dir/build.make src/CMakeFiles/tinyb.dir/build

make -f java/jni/CMakeFiles/javatinyb.dir/build.make java/jni/CMakeFiles/javatinyb.dir/depend

make -f java/jni/CMakeFiles/javatinyb.dir/build.make java/jni/CMakeFiles/javatinyb.dir/build

make -f examples/java/CMakeFiles/AsyncTinyB.dir/build.make

examples/java/CMakeFiles/AsyncTinyB.dir/depend

make -f examples/java/CMakeFiles/AsyncTinyB.dir/build.make

examples/java/CMakeFiles/AsyncTinyB.dir/build

make -f examples/java/CMakeFiles/HelloTinyB.dir/build.make

examples/java/CMakeFiles/HelloTinyB.dir/depend

make -f examples/java/CMakeFiles/HelloTinyB.dir/build.make

examples/java/CMakeFiles/HelloTinyB.dir/build

make -f examples/java/CMakeFiles/Notification.dir/build.make

examples/java/CMakeFiles/Notification.dir/depend

make -f examples/java/CMakeFiles/Notification.dir/build.make

examples/java/CMakeFiles/Notification.dir/build

make -f examples/CMakeFiles/asynctinyb.dir/build.make examples/CMakeFiles/asynctinyb.dir/depend

make -f examples/CMakeFiles/asynctinyb.dir/build.make examples/CMakeFiles/asynctinyb.dir/build

make -f examples/CMakeFiles/checkinit.dir/build.make examples/CMakeFiles/checkinit.dir/depend

make -f examples/CMakeFiles/checkinit.dir/build.make examples/CMakeFiles/checkinit.dir/build

make -f examples/CMakeFiles/esstinyb.dir/build.make examples/CMakeFiles/esstinyb.dir/depend

make -f examples/CMakeFiles/esstinyb.dir/build.make examples/CMakeFiles/esstinyb.dir/build

make -f examples/CMakeFiles/hellotinyb.dir/build.make examples/CMakeFiles/hellotinyb.dir/depend

make -f examples/CMakeFiles/hellotinyb.dir/build.make examples/CMakeFiles/hellotinyb.dir/build

make -f examples/CMakeFiles/list_mfg.dir/build.make examples/CMakeFiles/list_mfg.dir/depend

make -f examples/CMakeFiles/list_mfg.dir/build.make examples/CMakeFiles/list_mfg.dir/build

make -f examples/CMakeFiles/notifications.dir/build.make

examples/CMakeFiles/notifications.dir/depend

make -f examples/CMakeFiles/notifications.dir/build.make

examples/CMakeFiles/notifications.dir/build

make -f examples/CMakeFiles/uuid.dir/build.make examples/CMakeFiles/uuid.dir/depend

make -f examples/CMakeFiles/uuid.dir/build.make examples/CMakeFiles/uuid.dir/build

make[1]: Leaving directory '/home/root/tinyb/build'

`
building the example jar
`
mkdir -p build
javac -d build/ -classpath tinyb/build/java/tinyb.jar tinyb/examples/java/*.java

cp MANIFEST.MF build/

cd build && jar cfm tinyb_local.jar MANIFEST.MF *.class

`
Makefile
`
make:
    mkdir -p build

    javac -d build/ -classpath tinyb/build/java/tinyb.jar tinyb/examples/java/*.java

    cp MANIFEST.MF build/

    cd build && jar cfm tinyb_local.jar MANIFEST.MF *.class

install:

    mkdir -p tinyb/build

    cd tinyb/build && cmake .. -DBUILDJAVA=ON

    $(MAKE) -C tinyb/build/

    $(MAKE) -C tinyb/build/ MAKEFLAGS="install"

run:

    cd build && java -jar tinyb_local.jar ${MAC_ADDR}

clean:

    rm -r build/

`
MANIFEST.MF
`
Manifest-Version: 1.0

Main-Class: HelloTinyB

Class-Path: ../tinyb/build/java/tinyb.jar

`
Sorry for the long post. Does anyone have any similar experience or idea what might be wrong?

I have the exact same issue. @AxelUlmestig why was this closed?


Added openAI-GPT in ChatBot

Issue No. #422

Description
Hello @Anupkjha2601  ,
I have added Chat Bot using API of Chat GPT v3.5
It is working smoothly and answering all the questions.
Instructions -

Visit to this website - https://rapidapi.com/Glavier/api/chatgpt53
Subscribe the API // important step without this API will not work, also this API is free of cost.
See the right side of the page :-

Copy the API key and paste in the key in the chatbot/script.js

Video -
Screencast from 28-06-23 12:41:31 AM IST.webm
Also I think this Contribution deserves More Points so you can increase my level too 🥇

Checklist

[x] My code adheres to the established style guidelines of the project.
[x] I have included comments in areas that may be difficult to understand.
[x] My changes have not introduced any new warnings.
[x] I have conducted a self-review of my code.

your code cause changes in home page header as well as testimonial section so i am reverting your pull request and removing level3 to level2.

@Anupkjha2601 ,
He is not even a member of GSSoC 23 and not even a contributor so it's not right to take action for this he is just a spammer who spams in my PR

Same goes to you @Killer2-O


nsp string vulnerability

There is vulnerability in string package:
<EMAIL_ADDRESS>><EMAIL_ADDRESS>https://nodesecurity.io/advisories/536
I noticed there is a change in master branch related to this vulnerability but when will you publish it on npm?

Same question here. Can't pass CI cause by this issue.
When will we release next version?

Doesn't look like the stringjs repo is well maintained judging by the number of issues, pull requests and the recent commit history. The issue for stringjs vulnerability is here. I don't assume it will be fixed anytime soon.

Hi! Any new on this?

Bump, seems quite urgent.

Please fix urgently - npm install on any package using swagger-tools gets a high security alert.

Another month passes.

Have you really looked into the scope of the nsp warning?  The commit that removes the dependency shows that the usage of stringjs in swagger-tools didn't even use the affected functions that could result in a DoS, and its use was limited to one swagger-tools CLI command: info  Chances are good you didn't even know that command existed, let alone actually using it.  This, along with the fact that swagger-tools is deprecated, I just didn't see it being of the utmost importance.  My time is going into sway and related tooling to completely EOL swagger-tools and the only effort that goes into it must be proven as necessary.  Given that I've looked into this, I really didnt' see it being that important since you could just as easily install swagger-tools@master.
I apologize if this comes of snarky.  If this is not good enough, feel free to offer to help run the project so things like this can get released.

Come on man. I get it, it's a deprecated project and you don't want to put any more effort in it, because you have something shiny and new...BUT:
Not everyone can just quickly migrate to sway since it doesn't seem to be backwards compatible to swagger-tools. And even though the vulnerable features from the string package are not actually being used, it's never a nice thing to have a high risk vulnerability alert in your dependencies. And having to do a deep check if you're REALLY affected by this can be very daunting, especially if swagger-tools is not the only one of your dependencies with an alert.
And all you have to do to make a lot of people happy is to publish a new version to npm, since the fix is already in master. That's a 5 minute task at max. It probably took you even longer to write that comment.
So PLEASE, would you do us that favor?

<EMAIL_ADDRESS>released.


how to write types.json for Currency in currencies/src/lib.rs in Transferred event

pub struct Currency<T, GetCurrencyId>(marker::PhantomData<T>, marker::PhantomData<GetCurrencyId>);

#[pallet::metadata(CurrencyIdOf<T> = "Currency", T::AccountId = "AccountId", BalanceOf<T> = "Balance", AmountOf<T> = "Amount")]
 pub enum Event<T: Config> {
  /// Currency transfer success. \[currency_id, from, to, amount\]
  Transferred(CurrencyIdOf<T>, T::AccountId, T::AccountId, BalanceOf<T>),
 }

i find below is not right
 "Currency": {
    "CurrencyData": "Vec<u8>",
    "CurrencyId": "u128"
  }

It depends on what's your CurrencyId type defined in your runtime.

Feel free to reopen if you and more questions.


show last 5 scrape statuses on job views

 via https://github.com/paultag/moxie/commit/d8b0c520580038992fe245d0395633409bf972c3


Add time type translation utilities to StandardColumnMappings

This should wait until #4381 goes in.

@martint this is a new method extracted, but the functionality exists already.
What is the reason to block this one?

I haven't looked at the change, but I had to touch all that code in that PR, so it'd be better to base it on it to avoid redoing the work.

At a glance, three of the four methods will have to be rewritten. The last is only spared because it's already implemented in the other PR.


Add drone starlark code to support extraTestFilterTags

so that the starlark CI logic is available when we do oC10.10.0 release, like done in https://github.com/owncloud-docker/server/pull/300

@xoxys please review. I only have read access to this repo, so I had to fork to make this PR, and I can't select reviewers.

trivy complains about existing things https://drone.owncloud.com/owncloud-docker/qnap/249/2/8
When the 10.10 update is being done here, that will all have to be sorted out. The commit in this PR can easily be cherry-picked. I will leave this PR sitting here.

Rebased


Avoid duplicate close deadlock

Closes https://github.com/fiji/fiji/issues/324

@ctrueden this definitely fixes the deadlock I'm seeing in the current Fiji release. But this change is scary since it touches on image synchronization. I stared at it for a long time and I think this is sensible... no tests fail.. and I played around a bit in Fiji and wasn't able to create any orphaned images (which was my main concern). I just wanted another pair of eyes that this is change isn't missing something obvious.

See also Zulip discussion here.


Update Espressif port for OTA

Update Espressif port for OTA
Description

Fix for validating image size > 3MB by splitting image into chunks.
Based on PR from Espressif https://github.com/aws/amazon-freertos/pull/3155

Checklist:

[ ] I have tested my changes. No regression in existing tests.
[ ] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pvyawaha Can you look into the esp32 build failures?

@pvyawaha Can you look into the esp32 build failures?

Looks like the errors are running the CMake on the CI. Will follow up with internal team to find a resolution.

/bot run checks


Stopping public service should report insufficient privilege

In GitLab by @wknet123 on Mar 14, 2018, 11:40
Too narrow.

In GitLab by @yhua123 on Nov 8, 2019, 07:46
Project and service have separate publicity setting.
Search:
Public project and service, all can search.
Private project and service, only project member can search.
Create and Modify:
No relation between service and project publicity configuration.
Project owner can set project publicity.
Project member can set service publicity.

In GitLab by @liyanq528 on Nov 8, 2019, 07:47
fixed Ui with pull request #1082

In GitLab by @sokril on Nov 8, 2019, 08:18
closed

In GitLab by @sokril on Nov 8, 2019, 08:18
assigned to @sokril

In GitLab by @liyanq528 on Nov 11, 2019, 08:46
mentioned in merge request !444

In GitLab by @liyanq528 on Nov 13, 2019, 08:43
mentioned in merge request !1041


Does findContextOutbound need synchronized?

The findContextOutbound() would access the context linked list, while the list may be modified, e.g. addLast(), so does it need synchronized?

@kingluo nope as the nodes are volatile.


AggregateServiceProvider doesn't respect deferred providers

Laravel Version: 10.x
PHP Version: 8.2

Description:
I've encountered a problem with AggregateServiceProvider. In the code, we can find the following register method:
public function register()
{
    $this->instances = [];
    foreach ($this->providers as $provider) {
        $this->instances[] = $this->app->register($provider);
    }
}

It means that every provider added to AggregateServiceProvider will be registered immediately on every request because to register a deferred provider in the container there should be used the method registerDeferredProvider($provider, $service = null);.
I've described more here: https://sarvendev.com/2023/03/laravel-aggregateserviceprovider-affects-the-performance/.
I could prepare a fix for that, but first I want to discuss the proper solution. I see two options:

fix AggregateServiceProvider

it could break projects whose uses that Provider and included providers have invalid configurations in the provides() method

just mark AggregateServiceProvider as deprecated?

this provider isn't even mentioned in the documentation, so maybe we can just deprecate it and remove it in the next versions?

Let me know what you think.

I don't review PRs, taylor does. Please just attempt whatever you feel is right.


fix: [#9063] Broken link in UI: Configure/Connections/External connections/see documentation

Description
This PR fixed the "Add external connections" link which was returning a 404 error.
Task Item
Fixes # 9063
#minor
Screenshots
This image shows the link working.

/promoted 9336


Improper Handling of Exceptional Conditions

Describe the bugs: 🐛
Newtonsoft.Json prior to version 13.0.1 is vulnerable to Insecure Defaults due to improper handling of expressions with high nesting level that lead to StackOverFlow exception or high CPU and RAM usage. Exploiting this vulnerability results in Denial Of Service (DoS).
The serialization and deserialization path have different properties regarding the issue.
Deserializing methods (like JsonConvert.DeserializeObject) will process the input that results in burning the CPU, allocating memory, and consuming a thread of execution. Quite high nesting level (>10kk, or 9.5MB of {a:{a:{... input) is needed to achieve the latency over 10 seconds, depending on the hardware.
Serializing methods (like JsonConvert.Serialize or JObject.ToString) will throw StackOverFlow exception with the nesting level of around 20k.
To mitigate the issue one either need to update Newtonsoft.Json to 13.0.1 or set MaxDepth parameter in the JsonSerializerSettings. This can be done globally with the following statement. After that the parsing of the nested input will fail fast with Newtonsoft.Json.JsonReaderException:
JsonConvert.DefaultSettings = () => new JsonSerializerSettings { MaxDepth = 128 };

Repro code:
//Create a string representation of an highly nested object (JSON serialized)
int nRep = 25000;
string json = string.Concat(Enumerable.Repeat("{a:", nRep)) + "1" +
 string.Concat(Enumerable.Repeat("}", nRep));

//Parse this object (leads to high CPU/RAM consumption)
var parsedJson = JsonConvert.DeserializeObject(json);

// Methods below all throw stack overflow with nRep around 20k and higher
// string a = parsedJson.ToString();
// string b = JsonConvert.SerializeObject(parsedJson);

Note the original statement about the problem only affecting IIS applications is misleading. Any application is affected, however the IIS has a behavior that stops restarting the instance after some time resulting in a harder-to-fix DoS.
GHSA-5crp-9r3c-p9vr
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H
Severity High
7.5/ 10

Thanks for the PR. This is not a change we're going to make to Bond right now.
The minimum version of Newtonsoft.JSON that Bond currently needs is 9.0.1, so this is the version referenced in the example.
See also: #1156, Potential breaking change: Upgrade to exclusively use Newtonsoft.Json >= 13.0.1 and my comment explaining why I don't think this makes sense for Bond. It also outlines a handful of approaches you can take to use a newer version of Newtosoft.JSON in your app should you need one.


Add more context to  wildcard type (*) explanation

Fixes https://github.com/roc-lang/roc/issues/5038
This PR adds a little bit more context to the wildcard type as discussed in the zullip chat.
It also adds the roc-cli package to the devShell in the flake.nix. This was done because the www/build-dev-local.sh bash script needs roc to run.

I think the wording addition looks good. Just not 100% on the nix addition.

This PR no longer modifies the flake.nix file, only the tutorial.md file

@ElrohirGT it's hard to explain this really well, so I tried to make some improvements and asked Richard for help to perfect this.


No adress found over TCP - HTTP::Client

My output:
daniel@daniel-desktop:~/code/instabot$ crystal run src/instabot.cr
No address found for https://www.instagram.com:443 over TCP (Socket::Error)
0x483937: *CallStack::unwind:Array(Pointer(Void)) at ??
0x5148cc: initialize at /opt/crystal/src/socket/tcp_socket.cr 104:33
0x5142b1: new at /opt/crystal/src/socket/tcp_socket.cr 27:3
0x51175c: socket at /opt/crystal/src/http/client.cr 652:5
0x51156d: exec_internal_single at /opt/crystal/src/http/client.cr 500:5
0x50edec: exec_internal at /opt/crystal/src/http/client.cr 486:5
0x50ecc2: exec at /opt/crystal/src/http/client.cr 483:5
0x50e9f6: exec at /opt/crystal/src/http/client.cr 586:5
0x50e9d7: get at /opt/crystal/src/http/client.cr 329:3
0x512230: get_request at /home/daniel/code/instabot/src/instabot/client.cr 12:7
0x46a826: __crystal_main at /home/daniel/code/instabot/src/instabot.cr 10:6
0x47b679: main at /opt/crystal/src/main.cr 12:15
0x7f5432a11830: __libc_start_main at ??
0x469bd9: _start at ??
0x0: ??? at ??

My code:
require "http/client"

module Instabot
  class Client
    HOST = "https://www.instagram.com"
    @@client = HTTP::Client.new HOST, tls: true

    def self.get_request(url : String)
      @@client.get(self.build_url(url))  # Request started here
    end

    def self.build_url(url : String)
      url + "/?__a=1"
    end
  end
end

puts Instabot::Client.get_request("danieloltmanns").body

The output I want:
{"user": {"biography": "16 | Germany | Developer/Photographer", "blocked_by_viewer": false, "country_block": false, .....

My problem: Why can't I access a https site from the standard HTTP::Client class by using an generated object?
Code that works:
require "http/client"

module Instabot
  class Client
    HOST = "https://www.instagram.com/"

    def self.get_request(url : String)
      HTTP::Client.get(self.build_url(url))  # Request started here
    end

    def self.build_url(url : String)
      HOST + url + "/?__a=1"
    end
  end
end

puts Instabot::Client.get_request("danieloltmanns").body

What I want: To keep the cookies in the sameClient I want to use the same HTTP::Client object over all requests I will make.

Client.new requires either a String with the hostname or an URI object with the URL. You are providing a URL as hostname, which does not work. You could just change it:
HOST = "www.instagram.com

Ok. Thanks.


Legend tag for TUI

Specific Demand
Lengend tag for TUI.
fieldset {
    border: "solid",
    legend {
        align: "left"
        "Caption of fieldset"
    }
    ...
}

Implement Suggestion
There are two ways to implement the lengend tag,

Assuming the border of fieldset is drawn. The legend widget finds its parent, the fieldset, get its area and border's style, calculate the position of title and draw it on top of the border.
The fieldset widget finds that  its first child is a legend, after drawing the border, calculate the position of legend and draw it on top of the border.

I'm not sure which one is better. I'd like to invest my time to implement it. I've used dioxus before. I'm now reading rink/src/render.rs. Please tell me how to do it.

I would make the parent know about the child and when the parent is rendered, it also renders the child.
You can implement this using a new native-core state (docs). The state would depend on the child node of the same type. If the element type is a legend, it can set the current legend to the text, otherwise the legend is the first child legend.
When you render the node, after drawing the border (here), you can check if the legend is set and draw it ontop of the border

TUI has been "put on ice" and as such we're closing TUI related issues while it goes an architecture shift due to the upgrade to http://github.com/dioxusLabs/blitz 's backend.


added colors from style guide

Added the style guide colors for app-wide use.
The pink color may need to be updated because it wasn't correct on the style guide but I color metered it to get the RGBs and then hex from it. So it might not be exact.

Have Eileen check over the colors and if she says they're fine, then you can merge it in :)


Pitch: PASEA python workshop and research experience

Submission of project pitch for "Call for proposals: Inclusion, Diversity, and Empowerment".
Title: Coding and Research Experience for Pan-African School for Emerging Astronomers (PASEA) Alumni
Summary
This project is to give coding training and research experience to PASEA alumni, who are African undergraduate and graduate students in STEM. In particular, I'd like to supervise a student to develop open source python tools to schedule simultaneous observations of telescopes from around the globe and in space.
Team
PASEA has run 4 week-long summer schools for African undergraduate and postgraduate students in STEM (2013, 2015, 2017, 2019). We now have 250 alumni from over 10 different African countries. PASEA alumni are an engaged cohort and continue to send daily messages in a WhatsApp group related to STEM, astronomy and opportunities. See https://www.astrowestafrica.org/home for more information on PASEA.
The PASEA instructional team has about 20 astronomers from all around the world, a subset of these would be interested in putting together some coding training resources. A few of us are interested in mentoring students for research projects, including myself.
We would love help in the creation or gathering of Jupyter Notebooks that can be used for training. Extra help would be appreciated in figuring out where a Jupyter hub can be hosted, and setting that up so students don't need their own computing resources.
Plan

Run python training over 1 week, relevant to the proposed research project.
1a) Set up JupyterHub so students don't need their own computing resources and just need internet and a laptop.
1b) Project supervisor help determine content of this training, which should be relevant to the research project(s) student can choose from.
1c) Find tutors who can help students during the training week (e.g. 1 tutor/5 students).
1d) Recruit students based on their career goals and engagement in PASEA.

Students do astronomy research project.
2a) Recruit students for research project(s). Students would be selected based on their career goals, as well as engagement in PASEA and the 1 week python training.
2b) Supervisor and student interact few times a week over a 3 month (full time preferable) internship.
2c) Follow this with less frequent interactions to finish the project off part time.
2d) Note: I would like to supervise a student to put together open source python tools for observing scheduling/ telescope coordination when multiple telescopes all around the globe, as well as in space, need to be used simultaneously. This type of observing runs are typical of the Deeper Wider Faster Project, which aims to catch the fastest bursts in the Universe and discern their nature (bursts such as fast radio bursts and kilonovae). These open source tools can be published in https://joss.theoj.org.

Impact
African undergraduate and graduate students will get python training, do research and contribute to open source python tools that help schedule and coordinate telescopes for time domain astronomy.
Four PASEA alumni are now PASEA instructors. This is a great avenue to identify more PASEA alumni who can be PASEA instructors. Having instructors who were once participants of the school is highly motivating and a huge boost for self-efficacy.
Budget

$450/week stipend for student for 3 months of full time internship to do research project. ($5,800/ research project student)
$200 for 1 zoom license
$100/student for mobile internet so student can participate online throughout the internship. ($100/ research project student)
$20/student for mobile internet so student can participate online for python workshop over 1 week ($20/ python workshop student)

I like this a lot, I think it would be even better for our community if it were connected more to the Astropy Project, e.g. do you think it would make sense to include "how to open a PR to an open source project" in the Python training or is that asking too much? We might be able to find a few cases where a PR can be done, even for a Python beginner.
A suggestion on the technical side: Instead of running your own jupyterlab instance, it might be easier to use an existing "jupyter notebooks on the web" service. I've only used , e.g. https://mybinder.org/ and Google colab where the free version have limited runtime (i.e. you need to save and log out at the end of the day and then log in and import your saved notebook the next day) and memory (e.g. 2 GB, so it might enough for most, but not all projects), but there are probably paid services which offer more resources as needed.

I like this a lot, I think it would be even better for our community if it were connected more to the Astropy Project, e.g. do you think it would make sense to include "how to open a PR to an open source project" in the Python training or is that asking too much? We might be able to find a few cases where a PR can be done, even for a Python beginner.

Not at all! I think this would be a fantastic idea. If we get alumni from the PASEA postgraduate stream, they have already have some python experience and 1 piece of git+github experience (they had to git clone something). In general students also love contributing to something for real, and not just for their own educational experience.
I would need some help finding a beginner friendly PR though, suggestions very welcome!

A suggestion on the technical side: Instead of running your own jupyterlab instance, it might be easier to use an existing "jupyter notebooks on the web" service. I've only used , e.g. https://mybinder.org/ and Google colab where the free version have limited runtime (i.e. you need to save and log out at the end of the day and then log in and import your saved notebook the next day) and memory (e.g. 2 GB, so it might enough for most, but not all projects), but there are probably paid services which offer more resources as needed.

This seems like a good idea that would take less work and would be very appropriate for the python training week. Thanks @hamogu!! For the research project, maybe we need to add a budget item to get some paid services depending on the project. For my open source telescope coordination tool research project if the supervisor can't get computing resources from their institute. For me, I can get the student an account on my institute's super computer, which is do-able if they have "intern" status.

@jielaizhang Since issues get opened and closed all the time, I'm not going to point to a specific beginner-friendly issue right now, but astropy even has a specific label for that: https://github.com/astropy/astropy/issues?q=is%3Aopen+is%3Aissue+label%3A"good+first+issue"
In some cases, it might be easier to pick an affiliated package (say add a specific search service to astroquery), depending on interest.

@jielaizhang Since issues get opened and closed all the time, I'm not going to point to a specific beginner-friendly issue right now, but astropy even has a specific label for that: https://github.com/astropy/astropy/issues?q=is%3Aopen+is%3Aissue+label%3A"good+first+issue"
In some cases, it might be easier to pick an affiliated package (say add a specific search service to astroquery), depending on interest.

This is great, thanks Hans!

(say add a specific search service to astroquery)

I agree that affiliated packages are easier to start with, but this example is not exactly suitable for people starting out both with python, web APIs, and astronomy data archives.

(say add a specific search service to astroquery)

I agree that affiliated packages are easier to start with, but this example is not exactly suitable for people starting out both with python, web APIs, and astronomy data archives.

Noted! Thank you! Yes, it'd be good to pick something that had less components, but still affiliated with the research project(s) they would work on, or the tools they are learning to use.

A more widely used label aimed at new contributors is "package-novice". Just as with "good first issue", some of them are more suitable for people having strong programming experience, but no experience with these particular packages, while others are suitable for beginners both in programming and with the package, so it's worth checking out a few of them (many lists the solution for a bug or issue in the description, so the task is to add that solution into the codebase): https://github.com/search?q=is%3Aissue+is%3Aopen+label%3Apackage-novice

A more widely used label aimed at new contributors is "package-novice". Just as with "good first issue", some of them are more suitable for people having strong programming experience, but no experience with these particular packages, while others are suitable for beginners both in programming and with the package, so it's worth checking out a few of them (many lists the solution for a bug or issue in the description, so the task is to add that solution into the codebase): https://github.com/search?q=is%3Aissue+is%3Aopen+label%3Apackage-novice

This is very useful information. Thank you!

I think this is a great opportunity for a new collaboration so that we can build a stronger tie to the Astropy Project. @jielaizhang , would you like to start engaging with the Astropy Learn folks? That group focuses on workshops and tutorials. We use the #learn channel in the astropy slack and meet on Wed at 10am ET. Feel free to join us in the slack channel or shoot me<EMAIL_ADDRESS>or @eblur an email.

I think this is a great opportunity for a new collaboration so that we can build a stronger tie to the Astropy Project. @jielaizhang , would you like to start engaging with the Astropy Learn folks? That group focuses on workshops and tutorials. We use the #learn channel in the astropy slack and meet on Wed at 10am ET. Feel free to join us in the slack channel or shoot me<EMAIL_ADDRESS>or @eblur an email.

Thanks Kelle! I've joined the #learn channel on the satrapy slack. 10am EDT is my midnight here in Australia, so I am not sure when I can next join the meeting. This is really great, thanks! I think I can learn a lot for the postgraduate stream of PASEA during the actual summer school itself too. (PASEA: https://www.astrowestafrica.org/about)

After discussion in the astropy community, this proposal came in third, which unfortunately means that we don't have funds for it this year. However, most people felt that this proposal would be a great program to support and we hope that we can make it work next year!
That should not stop you to interact with people on the astropy project though. I hope that there is some support we can give even without money at this point. Several ideas were already thrown around in the comments above (e.g. I pointed to free jupyter-on-the-web services that might be useful for teaching). The astropy mailing list or slack can be useful to get support, too.

I forgot to say in my last comment: The rankings were discussed on the astropy-dev mailing list and announced by email. I'm just commenting here to close the loop and post that result in the PR, too.

Thank you @hamogu for the funding outcome! This has been a very positive experience for me, and my team. Yes, indeed many good ideas and advice has resulted too. I am now on the satrapy slack, which is useful.
I am now also exploring other funding avenues for this project, I hope they will come through.

@jielaizhang - in all recent years there has been an a few astronomy related internships available in the Google Summer of Code. These projects typically require some programming experience and may be an interest for some of the students within the PASEA network. We typically know more details about it around late January/February. For past project/project ideas see the lists here: https://openastronomy.org/gsoc/

@jielaizhang - in all recent years there has been a few astronomy related internships available in the Google Summer of Code. These projects typically require some programming experience and may be an interest for some of the students within the PASEA network. We typically know more details about the upcoming year around late January/February. For past project/project ideas see the lists here: https://openastronomy.org/gsoc/

This is fantastic, thanks for pointing me to this! I'll pass this along to the PASEA alumni.

Since proposals have been selected, I'm closing this PR. However, @jielaizhang if you feel we can be of any help, please continue to reach out, email, slack, or continue to comment on this (closed) issue.


No module named base_service

Hey there,
I'm getting the error No module named base_service
Error at line 4: from django_node.base_service import BaseService in django-react/django_react/services/init.py
It looks like base_service is no longer part of the django_node package.
Any ideas?
Thanks,

Sounds like you installed django-node from pypi, not from github.
You need to ensure you installed django-node from github before you install django-react like this:
pip install -e git+https://github.com/markfinger/django-node.git#egg=django-node
pip install -e git+https://github.com/markfinger/django-react.git#egg=django-react

Otherwise django-node will trigger a download from pypi, which is out of date.
@markfinger, maybe you could include a minimum version number in the requirements so that it will fail to install using the pypi version?

Hey,
I am pretty sure I did the above as I was following the readme.
I checked out the source here though https://github.com/markfinger/django-react/tree/master/django_react/services
I'm not seeing the base_service package there. You sure the django-react repo doesn't need to be updated?
Sorry if the mistake is on my end.
Thanks!

Its complaining about django-node not django-react.
The module is here: https://github.com/markfinger/django-node/blob/master/django_node/base_service.py

I actually managed to replicate the problem. If I pip installed from the then latest commit, it overrode the django-node version and rolled it back to the latest from pypi - which had an incompatible API.
Anyway, the codebases have stabilised for the moment, so I've gone through and updated PyPI with the latest codebases for everything. So you can now pip install django-react and everything should work fine.
Thanks for reporting the issue, Chiedo, and thanks for trying to fix it, Michael! :balloon:

Thanks Mark,
I was actually about to let you know that this morning so I'm glad to replicated the problem also on your end!
Thanks for your help also Michael!


refactor urls and add default token_info

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f9776a2) 92.8% compared to head (0bc673a) 93.6%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##            main      #4     +/-   ##
=======================================
+ Coverage   92.8%   93.6%   +0.8%
=======================================
  Files         12      12
  Lines        557     555      -2
=======================================
+ Hits         517     520      +3
+ Misses        40      35      -5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Deploying the rasa webchat on server

Hi,
I can run the rasa webchat successfully on localhost and it communicates correctly with my locally implemented rasa server. But the issue arises when I call the following command(same command which leads to successful connection) on server:
npx webpack-dev-server --config webpack.dev.js --port 8000
It says it has been compiled successfully but when I call the same port like this:
myserverip:8000
I don't get any result. Could you please give me a detailed instruction on how to implement it on server? (BTW, my server is Ubuntu 18.04 LTS)
In addition, when I use the webchat-0.5.8.js script and mimic the example you've provided I get an error like this in the browser console:
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at http://SV-ipAddress-WAS-HERE:8080/socket.io/?EIO=3&transport=polling&t=MtLcjZT. (Reason: Multiple CORS header ‘Access-Control-Allow-Origin’ not allowed).
Although I have run RASA by rasa run --enable-api --cors "*" --debug --port 8080 --endpoints endpoints.yml I get this CORS error!
Same command on localhost works perfectly well!
I am looking forward to hearing from you guys
Thanks in advance

@DrGardiner   which version of rasa are you using?

@DrGardiner which version of rasa are you using?

I am using Apache

Could be try  --cors '' instead --cors "" for ubuntu.

Hi!,
How could you solve it? I have the same issue, I'm using Rasa 2.6.0 and rasa-webchat 1.0.0.
Thanks


fix flaky test testFindItemsByNamespace

What's the purpose of this PR
This PR aims to fix the following flaky test case:
com.ctrip.framework.apollo.openapi.client.service.ItemOpenApiServiceTest.testFindItemsByNamespace
Which issue(s) this PR fixes:
The test case com.ctrip.framework.apollo.openapi.client.service.ItemOpenApiServiceTest.testFindItemsByNamespace fails due to the below assertion:
https://github.com/ThugJudy/apollo-java/blob/5344bc4f07288842bb850145bcf80a084bd94114/apollo-openapi/src/test/java/com/ctrip/framework/apollo/openapi/client/service/ItemOpenApiServiceTest.java#L321-L322
The parameters of the URI if shuffled, can cause flakiness as it is a simple string comparison where the order in which the parameters arrive is not maintained. The flakiness occurs at the following point:
https://github.com/ThugJudy/apollo-java/blob/d8e4352ff8c9e9c6fc37961c49d4b7018b47fc14/apollo-openapi/src/main/java/com/ctrip/framework/apollo/openapi/client/service/ItemOpenApiService.java#L215-L222
The add params in line 221 and 222, adds the param to a hashMap. As hashmaps do not preserve the order in which the parameters arrive, these params may be shuffled some times causing flakiness. So, I propose using a LinkedHashMap, so that the order in which the params are inserted is preserved and flakiness is resolved.
https://github.com/ThugJudy/apollo-java/blob/d8e4352ff8c9e9c6fc37961c49d4b7018b47fc14/apollo-openapi/src/main/java/com/ctrip/framework/apollo/openapi/client/url/OpenApiPathBuilder.java#L64
I found and confirmed the flaky behavior using an open-source research tool NonDex, which shuffles implementations of nondeterminism operations.
Reproduce
The following command can be used to reproduce assertion failures and verify the fix:
mvn -pl main edu.illinois:nondex-maven-plugin:2.1.1:nondex  -Dtest=com.ctrip.framework.apollo.openapi.client.service.ItemOpenApiServiceTest#testFindItemsByNamespace

Test Environment:
Java version "1.8.0_381"
Apache Maven 3.6.3
macOS Venture Version 13.4.1 (22F82)
Please let me know if you have any concerns or questions.
Follow this checklist to help us incorporate your contribution quickly and easily:

[X] Read the Contributing Guide before making this pull request.
[X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[X] Write necessary unit tests to verify the code.
[X] Run mvn clean test to make sure this pull request doesn't break anything.
[ ] Update the CHANGES log.

Could you expand a bit more on how "The parameters of the URI if shuffled"? E.g. where a Hashtable is iterated.
Also, please consider squashing the three commits into one.
Other than these, the fix looks ok to me and you can proceed to open a real PR. Once you open a real PR, please mark this tentative PR as Opened in your tentative_pr.csv file and also raise a PR to IDoFT marking this as Opened. Thanks!

Hi @zzjas,
I have updated the PR description. Moreover, I found a much simpler fix. Can you have a look at it?

LGTM

LGTM!


Missing Zicsr Instruction Error

When I try to run python3 OrangeCrab-bitstream.py on Ubuntu 22.04 I get this error:
INFO:SoCBusHandler:csr Region added at Origin: 0x82000000, Size: 0x00010000, Mode: RW, Cached: False Linker: False.
INFO:SoCBusHandler:csr added as Bus Slave.
INFO:SoCCSRHandler:bridge added as CSR Master.
INFO:SoCBusHandler:Interconnect: InterconnectShared (2 <-> 5).
make: Entering directory '/home/james/Desktop/Casino/OrangeCrab-test-sw/hw/build/orangecrab/software/libcompiler_rt'
make: Nothing to be done for 'all'.
make: Leaving directory '/home/james/Desktop/Casino/OrangeCrab-test-sw/hw/build/orangecrab/software/libcompiler_rt'
make: Entering directory '/home/james/Desktop/Casino/OrangeCrab-test-sw/hw/build/orangecrab/software/libbase'
 CC       crt0.o
/home/james/Desktop/Casino/OrangeCrab-test-sw/hw/deps/litex/litex/soc/cores/cpu/vexriscv/crt0.S: Assembler messages:
/home/james/Desktop/Casino/OrangeCrab-test-sw/hw/deps/litex/litex/soc/cores/cpu/vexriscv/crt0.S:59: Error: unrecognized opcode `csrw mtvec,a0', extension `zicsr' required
/home/james/Desktop/Casino/OrangeCrab-test-sw/hw/deps/litex/litex/soc/cores/cpu/vexriscv/crt0.S:85: Error: unrecognized opcode `csrw mie,a0', extension `zicsr' required
make: *** [/home/james/Desktop/Casino/OrangeCrab-test-sw/hw/deps/litex/litex/soc/software/libbase/Makefile:45: crt0.o] Error 1
make: Leaving directory '/home/james/Desktop/Casino/OrangeCrab-test-sw/hw/build/orangecrab/software/libbase'
Traceback (most recent call last):
  File "/home/james/Desktop/Casino/OrangeCrab-test-sw/hw/OrangeCrab-bitstream.py", line 463, in <module>
    main()
  File "/home/james/Desktop/Casino/OrangeCrab-test-sw/hw/OrangeCrab-bitstream.py", line 404, in main
    soc.PackageFirmware(builder)
  File "/home/james/Desktop/Casino/OrangeCrab-test-sw/hw/OrangeCrab-bitstream.py", line 358, in PackageFirmware
    builder._generate_rom_software(compile_bios=False)
  File "/home/james/Desktop/Casino/OrangeCrab-test-sw/hw/deps/litex/litex/soc/integration/builder.py", line 190, in _generate_rom_software
    subprocess.check_call(["make", "-C", dst_dir, "-f", makefile])
  File "/usr/lib/python3.10/subprocess.py", line 369, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['make', '-C', '/home/james/Desktop/Casino/OrangeCrab-test-sw/hw/build/orangecrab/software/libbase', '-f', '/home/james/Desktop/Casino/OrangeCrab-test-sw/hw/deps/litex/litex/soc/software/libbase/Makefile']' returned non-zero exit status 2.

What is the most sensible step for me to take to fix this?
I have seen advice to add _ziscr to the -march flag here: https://github.com/efabless/caravel_board/issues/37 but LiteX regenerates the variables.mak file each time I run python3 OrangeCrab-bitstream.py which means I cannot tell if my fix has done anything.

Trying again on my Mac produces a different error:
INFO:SoC:--------------------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/jamesmeech/Desktop/Casino/OrangeCrab-test-sw/hw/OrangeCrab-bitstream.py", line 466, in <module>
    main()
  File "/Users/jamesmeech/Desktop/Casino/OrangeCrab-test-sw/hw/OrangeCrab-bitstream.py", line 401, in main
    soc = BaseSoC(toolchain=args.toolchain, sys_clk_freq=int(float(args.sys_clk_freq)),**argdict(args))
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jamesmeech/Desktop/Casino/OrangeCrab-test-sw/hw/OrangeCrab-bitstream.py", line 267, in __init__
    SoCCore.__init__(self, platform, clk_freq=sys_clk_freq, csr_data_width=32,**kwargs)
  File "/Users/jamesmeech/Desktop/Casino/OrangeCrab-test-sw/hw/deps/litex/litex/soc/integration/soc_core.py", line 153, in __init__
    self.add_controller("ctrl")
  File "/Users/jamesmeech/Desktop/Casino/OrangeCrab-test-sw/hw/deps/litex/litex/soc/integration/soc.py", line 799, in add_controller
    setattr(self.submodules, name, SoCController(**kwargs))
                                   ^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jamesmeech/Desktop/Casino/OrangeCrab-test-sw/hw/deps/litex/litex/soc/integration/soc.py", line 670, in __init__
    self._reset = CSRStorage(1, description="""Any write to this register will reset the SoC.""")
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jamesmeech/Desktop/Casino/OrangeCrab-test-sw/hw/deps/litex/litex/soc/interconnect/csr.py", line 383, in __init__
    _CompoundCSR.__init__(self, size, name)
  File "/Users/jamesmeech/Desktop/Casino/OrangeCrab-test-sw/hw/deps/litex/litex/soc/interconnect/csr.py", line 131, in __init__
    _CSRBase.__init__(self, size, name)
  File "/Users/jamesmeech/Desktop/Casino/OrangeCrab-test-sw/hw/deps/litex/litex/soc/interconnect/csr.py", line 50, in __init__
    raise ValueError("Cannot extract CSR name from code, need to specify.")
ValueError: Cannot extract CSR name from code, need to specify.```

I'm going to attempt to create a working example by integrating the ADC parts from https://github.com/gregdavill/OrangeCrab-test-sw/blob/main/hw/OrangeCrab-bitstream.py into https://github.com/litex-hub/litex-boards/blob/master/litex_boards/targets/gsd_orangecrab.py which works out of the box for me

This is what I have so far: adcCrab.txt. LiteX will happily build this without errors and load it to the orangecrab with python3 adcCrab.py --device 85F --cpu-type femtorv --cpu-variant gracilis --with-spi-sdcard --build --load but unfortunately when I try to run the catalog command in LiteOs: https://github.com/BrunoLevy/learn-fpga/tree/master/LiteX/software/LiteOS which I am using to load programs onto the LiteX generated system on chip the program hangs. I think some of the stuff in the file is interfering with the SPI SD card but I'm struggling to figure out what even after commenting out a large amount of the code. I can see that the asense is getting into the  CSRs which is good because I want to be able to access the ADC. Any pointers to resources or obvious mistakes in my code would be greatly appreciated!

I switched my project over to the Arty and I am using LiteX with its hardware ADC block for now

For anyone seeing this issue, the first issue relating to Zicsr is a bitrot. Modern GCC requires that you append _zicsr to the march string in order to add in csr opcodes
The second issue looks like a liteX version bug. This test software was compiled when needed and hasn't needed to be updated since, so as you can see it has bitrotted a bit.


[WIP do not merge]: Existing updates from Armin

This PR adds in a number of changes Armin had implemented locally.
Among them is a fix for the MAST timeout errors that were interfering with some searches. These were solved by querying in batches, at the recommendation of the MAST developers.
This also introduces sortable.js, for creating sortable tables when results are saved in html files.

Tests of random program numbers all seem ok. I see log messages about batch queries, which is the solution to the timeout errors that Armin was working on solving. Webpages are created as long as uncal files are downloaded.

@arminrest are you happy with how these changes look? If so I can merge them.


Feat:Improve the UI of FAQ section.

Describe the feature
will change the font size and layout of FAQ's answers and make it look more attractive.
@Its-Aman-Yadav please assign it to me.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

please assign me this issue


Fix KeyboardShow Scroll, covering elements at bottom and White space on hide keboard issues

Was having a few issues with the keyboard opening over the focused element as well the whitespace being left on the body for keyboard spacing after it closed, also wasn't focusing for select boxes. This seems to solve that.
This PR monitors the active selected field on native.keyboardshow and if it is an input, textarea or select element, scrolls to it with a 200ms delay to ensure it accounts for the keyboard opening.
HANDY NOTE: if you are defining classes on a {{ionContent}} block ,ensure you have content in there as well as your other classes as the ionKeyboard functions rely on the .content.overflow-scroll class which was the first issue i was encountering.
It has solved my issues I was having, and hopefully will be useful for others also :)

@aaronthorp Have you tested this on an iOS device yet? When I originally implemented this there was a bug in iOS where if you animated the scroll right after focusing an input, the keyboard cursor wouldn't update its position and would be displayed outside of the form field.

Yeah still does this, and found other bugs so I closed the request for the
moment and just using ensbledScroll at the moment.
It still opens then immediately closes for select boxes tho, same as the
original code, not sure how to fix that issue :(
On Thursday, April 9, 2015, Nick Wientge<EMAIL_ADDRESS>wrote:

@aaronthorp https://github.com/aaronthorp Have you tested this on an
iOS device yet? When I originally implemented this there was a bug in iOS
where if you animated the scroll right after focusing an input, the
keyboard cursor wouldn't update its position and would be displayed outside
of the form field.
—
Reply to this email directly or view it on GitHub
https://github.com/meteoric/meteor-ionic/pull/143#issuecomment-90956919.

--

Aaron

PLEASE NOTE: If this email message is received by other than the named
addressee(s), then the recipient is requested immediately to notify us and
delete the email from the recipient's computer memory and to destroy all
hard and other copies of it.  This document may contain personal
information. Unauthorised retention or use of such information may be in
breach of the Privacy Act 1988. Please check attachments for viruses.

@aaronthorp could you find a way to fix this open/closes select boxes om iOS?
It's making me crazy. :stuck_out_tongue_closed_eyes:


Memory leak of frame_time_gradient

Godot version:
4.0.dev.custom_build. 950dedbb6
Regression from https://github.com/godotengine/godot/pull/44709
CC @Calinou
Issue description:
frame_time_gradient is not added to the scene, so memory leak exists
Indirect leak of 320 byte(s) in 4 object(s) allocated from:
    #0 0x7f72bdba2517 in malloc (/lib/x86_64-linux-gnu/libasan.so.6+0xb0517)
    #1 0x125815ef in Memory::alloc_static(unsigned long, bool) core/os/memory.cpp:76
    #2 0xce3864d in CowData<Gradient::Point>::resize(int) core/templates/cowdata.h:278
    #3 0xce372a6 in Vector<Gradient::Point>::resize(int) core/templates/vector.h:88
    #4 0xf125c1a in Gradient::Gradient() scene/resources/gradient.cpp:37
    #5 0xa4b9574 in Node3DEditorViewport::Node3DEditorViewport(Node3DEditor*, EditorNode*, int) editor/plugins/node_3d_editor_plugin.cpp:4089
    #6 0xa59218d in Node3DEditor::Node3DEditor(EditorNode*) editor/plugins/node_3d_editor_plugin.cpp:6461
    #7 0xa5ac698 in Node3DEditorPlugin::Node3DEditorPlugin(EditorNode*) editor/plugins/node_3d_editor_plugin.cpp:6725
    #8 0x87fb962 in EditorNode::EditorNode() editor/editor_node.cpp:6613
    #9 0x1f5af83 in Main::start() main/main.cpp:2139
    #10 0x1e0edf4 in main platform/linuxbsd/godot_linuxbsd.cpp:57
    #11 0x7f72bc96f0b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)

Indirect leak of 192 byte(s) in 4 object(s) allocated from:
    #0 0x7f72bdba2517 in malloc (/lib/x86_64-linux-gnu/libasan.so.6+0xb0517)
    #1 0x125815ef in Memory::alloc_static(unsigned long, bool) core/os/memory.cpp:76
    #2 0x125814ee in operator new(unsigned long, char const*) core/os/memory.cpp:41
    #3 0x12e4b915 in Dictionary::Dictionary() core/variant/dictionary.cpp:267
    #4 0x1367a45f in Object::Object(bool) core/object/object.cpp:1769
    #5 0x136b3737 in Reference::Reference() core/object/reference.cpp:100
    #6 0x12acf094 in Resource::Resource() core/io/resource.cpp:401
    #7 0xf1259e4 in Gradient::Gradient() scene/resources/gradient.cpp:35
    #8 0xa4b9574 in Node3DEditorViewport::Node3DEditorViewport(Node3DEditor*, EditorNode*, int) editor/plugins/node_3d_editor_plugin.cpp:4089
    #9 0xa59218d in Node3DEditor::Node3DEditor(EditorNode*) editor/plugins/node_3d_editor_plugin.cpp:6461
    #10 0xa5ac698 in Node3DEditorPlugin::Node3DEditorPlugin(EditorNode*) editor/plugins/node_3d_editor_plugin.cpp:6725
    #11 0x87fb962 in EditorNode::EditorNode() editor/editor_node.cpp:6613
    #12 0x1f5af83 in Main::start() main/main.cpp:2139
    #13 0x1e0edf4 in main platform/linuxbsd/godot_linuxbsd.cpp:57
    #14 0x7f72bc96f0b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)

https://github.com/godotengine/godot/blob/2abe996414b8b551e69e29461de3ff1bcaf5a28f/editor/plugins/node_3d_editor_plugin.cpp#L4089-L4091
Steps to reproduce:

Run with address sanitizer empty editor and close it

frame_time_gradient is a resource, not a node. How can I resolve this?

frame_time_gradient is a resource, not a node. How can I resolve this?

I forgot about it.
In test_gradient file I see this line
Ref<Gradient> gradient = memnew(Gradient);

but I think that probably memdelete in destructor should also works.

I forgot about it.
In test_gradient file I see this line
Ref<Gradient> gradient = memnew(Gradient);

but I think that probably memdelete in destructor should also works.


Face Detection Service does not recognize biggest faces first

Describe the bug
When submitting an image with 2 faces, when using "limit=1" the smallest of the 2 faces in the image is returned instead of the biggest face.
To Reproduce
Steps to reproduce the behavior:

Create a detection service
Send a request to detect faces in image using ""http://localhost:8000/api/v1/detection/detect?limit=0
2 faces are recognized, smallest face first:

{
  "result" : [ {
    "age" : {
      "probability" : 1.0,
      "high" : 32,
      "low" : 32
    },
    "box" : {
      "probability" : 0.999154806137085,
      "x_max" : 106,
      "y_max" : 482,
      "x_min" : 3,
      "y_min" : 337
    }
  }, {
    "age" : {
      "probability" : 1.0,
      "high" : 38,
      "low" : 38
    },
    "box" : {
      "probability" : 0.9985826015472412,
      "x_max" : 360,
      "y_max" : 646,
      "x_min" : 153,
      "y_min" : 342
    }
  } ]
}

Send the same request using the same image but using "limit=1"
The smallest first face is returned instead of the second bigger face:

{
  "result" : [ {
    "age" : {
      "probability" : 1.0,
      "high" : 32,
      "low" : 32
    },
    "box" : {
      "probability" : 0.999154806137085,
      "x_max" : 106,
      "y_max" : 482,
      "x_min" : 3,
      "y_min" : 337
    }
  } ]
}

Expected behavior
When using "limit=1" on an image with 2 faces, the bigger face should be returned, not the smallest one, as described in the docs: "maximum number of faces on the image to be recognized. It recognizes the biggest faces first. Value of 0 represents no limit. Default value: 0"
Screenshots

Desktop (please complete the following information):

OS: Windows 10
Browser: Chrome
Version: Latest

Additional context
Using Docker on Windows 10 subcenter-arcface-r100 custom build v 1.1.0

Also, maybe add a "size" or "area" property to "box", with the value of the actual size of the face rectangle?  Just to avoid having to do (x_max - x_min) * (y_max - y_min) for each face to get the value. I am calculating it now to avoid obvious false detections where the area is too small to be a real face.

Thanks for reporting this. It looks like some models work properly, and some sort results by probability, not the face size. We will change it in the next release.


Change file upload to handle .tree files

Some of the files we have are .tree files. So far, the only non csv files we are accounting for in the file upload is newick. Though these are similar, I do not know yet how similar and if the fix for this will be adding the file edition or accounting for that in tree parsing.

Do you have an example of a .tree file we can point to from this issue?

Do you have an example of a .tree file we can point to from this issue?

Yes! I am looking over a tree file that I am using as part of a sample dataset. I believe the .tree file contains branch information as well as additional attributes. I can send it to you?

extension for .tree added


now, exports only empty svg

It' s only a problem of mine or it is because of the tox isn't updated from 2/3 years ? please update !

I have this same problem even when following the setup example provided on the github page..

@SnacksDaily - just have you tried scaling up your SOP prior to export, or importing your svg into a tool like illustrator or inkscape and then enlarging your svg?

I had the same experience. Changing circle SOP radius to 500/500 scaled it up great.


iOS 11 Support?

It seems that the picker doesn't work anymore with the iOS 11 Bèta release.
It won't slide horizontally anymore.
Do you guys have the same problem? I had to change many UI properties with this new OS version.

@FrankdeV did you try compiling the example and running it on iOS 11? I ask because it seems to work for me, and maybe you are seeing something I'm not seeing. Thanks in advance for your response.


Add check to prevent key errors for lacking metadata in neon_soil_example

Closes #28.
Issue arose from bio samples that must have been ingested after our initial creation of the notebooks.  Some of the new bio samples do not have slots for geo_loc_name and are throwing a key error. I've added a check that subsets samples only for those with a collection_date, geo_loc_name and lat_lon before adding those data to downstream analyses.

Just as a reminder, I find it easiest to review by looking at the rendered notebook in the branch (https://nbviewer.org/github/microbiomedata/notebook_hackathons/blob/neon_metadata_keyerror/NEON_soil_metadata/python/neon_soil_metadata_visual_exploration.ipynb) and its associated google colab (https://colab.research.google.com/github/microbiomedata/notebook_hackathons/blob/neon_metadata_keyerror/NEON_soil_metadata/python/neon_soil_metadata_visual_exploration.ipynb).
Once the PR is merged into main, the notebooks will be accessible via the links in this readme: https://github.com/microbiomedata/nmdc_notebooks/tree/main/NEON_soil_metadata#readme.

@kheal  are the changes in cell 4?:
# Check if samp has keys that correspond to primary metadata
    if set(['lat_lon', 'geo_loc_name', 'collection_date']).issubset(samp):

Yep!  And then a few spots down below that used to reference all_results  now reference all_full_results.

To review: https://app.reviewnb.com/microbiomedata/nmdc_notebooks/pull/35/