chore: setting golangci-lint targeted go version

Setting golangci-lint targeted go version to be consistent with dependency version.
ref: https://github.com/golangci/golangci-lint/discussions/2314

No objection to the idea, but I'd like to know what the benefit to Prometheus is.
The linked issue seems to be about forcing an older version.

The linked issue seems to be about forcing an older version.

Thanks for your review.  Through the --go setting, ensure that golang-lint uses the latest feature rules of this version of the go language for detection.
Add this parameter in .github/workflows/ci.yml, not in .golangci.yml. For local development, developers can use the old version.

Thanks for your review. Through the --go setting, ensure that golang-lint uses the latest feature rules of this version of the go language for detection.

golangci-lint defaults to using the Go version from go.mod, what's the practical benefit of overriding the Go version in CI?

Hello from the bug scrub:  closing the issue due to concerns raised and lack of answer, please reopen if more information is present.


Add support for smart layout layers

Right now you can press the "Shrink Instances to fit content" button to fix the layout after using datapopulator (two small arrows in the Overrides part of Inspector)


exposes the .getMaker() method publicly and adds missing tests

Apologies for the late entry on this one, I intended for this to be part of the last PR.
The examples call the ._getMaker() method of the command in order to integrate fully with the compiler API, but this is not ideal given that it is a protected method.  The maker is an essential entry point, so this change exposes it publicly.
Once this is merged, I'll update API viewer and Demo browser to match

@johnspackman: Could you resolve the conflict and have a look at my Question please?


Halo Win95 Theme

Hello, can I use your Win95 theme for the theme of Halo blog? There is a possibility of commercialization and sales in the future! I hope to obtain your permission.

Heya. I am not the original creator and it was open sourced, so I believe you can!


💅 a11y/noNoninteractiveTabindex incorrectly labels treegrid child roles as non-interactive

Environment information
N/A

Rule name
lint/a11y/noNoninteractiveTabindex
Playground link
https://biomejs.dev/playground/?code=ZQB4AHAAbwByAHQAIABmAHUAbgBjAHQAaQBvAG4AIABUAHIAZQBlAEcAcgBpAGQAKAApACAAewAKACAAIAByAGUAdAB1AHIAbgAgACgACgAgACAAIAAgADwAZABpAHYAIAByAG8AbABlAD0AIgB0AHIAZQBlAGcAcgBpAGQAIgAgAGEAcgBpAGEALQBhAGMAdABpAHYAZQBkAGUAcwBjAGUAbgBkAGUAbgB0AD0AIgBjAGUAbABsAC0AMQAtADIAIgA%2BAAoAIAAgACAAIAAgACAAPABkAGkAdgAgAHIAbwBsAGUAPQAiAGMAbwBsAHUAbQBuAGcAcgBvAHUAcAAiAD4ACgAgACAAIAAgACAAIAAgACAAPABkAGkAdgAgAHIAbwBsAGUAPQAiAHIAbwB3ACIAPgAKACAAIAAgACAAIAAgACAAIAAgACAAPABkAGkAdgAgAGkAZAA9ACIAYwBvAGwALQAxACIAIAByAG8AbABlAD0AIgBjAG8AbAB1AG0AbgBoAGUAYQBkAGUAcgAiACAAdABhAGIASQBuAGQAZQB4AD0AewAwAH0APgBDAG8AbAB1AG0AbgAgADEAPAAvAGQAaQB2AD4ACgAgACAAIAAgACAAIAAgACAAIAAgADwAZABpAHYAIABpAGQAPQAiAGMAbwBsAC0AMgAiACAAcgBvAGwAZQA9ACIAYwBvAGwAdQBtAG4AaABlAGEAZABlAHIAIgAgAHQAYQBiAEkAbgBkAGUAeAA9AHsAMAB9AD4AQwBvAGwAdQBtAG4AIAAyADwALwBkAGkAdgA%2BAAoAIAAgACAAIAAgACAAIAAgACAAIAA8AGQAaQB2ACAAaQBkAD0AIgBjAG8AbAAtADMAIgAgAHIAbwBsAGUAPQAiAGMAbwBsAHUAbQBuAGgAZQBhAGQAZQByACIAIAB0AGEAYgBJAG4AZABlAHgAPQB7ADAAfQA%2BAEMAbwBsAHUAbQBuACAAMwA8AC8AZABpAHYAPgAKACAAIAAgACAAIAAgACAAIAA8AC8AZABpAHYAPgAKACAAIAAgACAAIAAgADwALwBkAGkAdgA%2BAAoAIAAgACAAIAAgACAAPABkAGkAdgAgAHIAbwBsAGUAPQAiAHIAbwB3AGcAcgBvAHUAcAAiACAAdABhAGIASQBuAGQAZQB4AD0AIgAwACIAIABhAHIAaQBhAC0AZQB4AHAAYQBuAGQAZQBkAD0AIgBmAGEAbABzAGUAIgA%2BAAoAIAAgACAAIAAgACAAIAAgADwAZABpAHYAIAByAG8AbABlAD0AIgByAG8AdwAiAD4ACgAgACAAIAAgACAAIAAgACAAIAAgADwAZABpAHYAIABpAGQAPQAiAGMAZQBsAGwALQAxAC0AMQAiACAAcgBvAGwAZQA9ACIAZwByAGkAZABjAGUAbABsACIAIAB0AGEAYgBJAG4AZABlAHgAPQB7ADAAfQA%2BAEEAPAAvAGQAaQB2AD4ACgAgACAAIAAgACAAIAAgACAAIAAgADwAZABpAHYAIABpAGQAPQAiAGMAZQBsAGwALQAxAC0AMgAiACAAcgBvAGwAZQA9ACIAZwByAGkAZABjAGUAbABsACIAIAB0AGEAYgBJAG4AZABlAHgAPQB7ADAAfQA%2BAEIAPAAvAGQAaQB2AD4ACgAgACAAIAAgACAAIAAgACAAIAAgADwAZABpAHYAIABpAGQAPQAiAGMAZQBsAGwALQAxAC0AMwAiACAAcgBvAGwAZQA9ACIAZwByAGkAZABjAGUAbABsACIAIAB0AGEAYgBJAG4AZABlAHgAPQB7ADAAfQA%2BAEMAPAAvAGQAaQB2AD4ACgAgACAAIAAgACAAIAAgACAAPAAvAGQAaQB2AD4ACgAgACAAIAAgACAAIAA8AC8AZABpAHYAPgAKACAAIAAgACAAPAAvAGQAaQB2AD4ACgAgACAAKQA7AAoAfQA%3D
Expected result
Both treegrid and grid are described to work like spreadsheets on the web, where data can be edited and individual cells can be focused within and navigated using arrow keys.
Treegrid takes it one step further and allows expanding/collapsing of rows and columns like a tree.
So when trying to implement focus behavior, this throws an error when it shouldn’t:
// The HTML element div is non-interactive. Do not use tabIndex. (❌ Incorrect)

                     ~~~~~~~~~~~~

This conflicts with the recommended behavior of treegrid children:

Right Arrow
If focus is on a collapsed row, expand the row. …

In other words, a gridcell MUST be focusable when inside a treegrid if it’s expandable (via tabIndex), and also MUST be able to receive other keyboard commands.
lint/a11y/noNoninteractiveTabindex is correct in other instances, so it seems this is only a problem with grid and treegrid children.
Other notes

The useSemanticElements rule does apply to this example but is irrelevant; noNoninteractiveTabindex still raises the same errors
Worth noting that, yes, by default many gridcells (and related roles) aren’t interactive, this issue is in certain scenarios they ARE REQUIRED to be
The “roving tabindex” approach is optional here (where only the focusable element receives tabIndex={0} and everything else gets tabIndex={-1}), but also doesn’t affect the outcome

Code of Conduct

[X] I agree to follow Biome's Code of Conduct

I’d be open to raising a PR, but wanted to discuss first whether or not it would be sufficient to remove gridcell (and friends—row, rowgroup, etc.) from the “always non-interactive” list.
I’m inclined to do so because looking at the base grid role docs, we see keyboard interactions suggested even for native
 elements. This leads me to believe that even though the native elements aren’t focusable, they are recommended to be, therefore tabIndex shouldn’t be discouraged.
However, if we wanted to take a more complex approach, where gridcell and friends are only interactive under certain conditions (e.g. only if a child of treegrid), I’d feel less confident opening a PR until we defined that criteria (and whether or not we could lint that if the components were broken up). Either way, open to thoughts!

For these cases, where elements can be interactive based on certain conditions, we assume they can always be interactive.
So, to answer your question @drwpow, let's remove them :)

Works for me! Will open up a PR with that change then 🙏

@drwpow I am landing important refactoring to biome_aria. I recommend working on the current issue once #4495 got merged.

@drwpow I am landing important refactoring to biome_aria. I recommend working on the current issue once #4495 got merged.

Great work on that! I didn’t get super far but did notice that it was basically a binary check of “is this a subclass or widget or not” and was going to make a worse hack than your more-correct fix.
Agree with the reasoning stated there, too. After having worked with my own treegrid component some more, and reading more on it, I was just going to have the following roles be possibly-interactive (the other roles I can’t say for sure they should get tabindex, but I couldn’t find any valid usecases where they do):

row
rowgroup
columnheader
rowheader
gridcell
cell*

Note: cell is the debatable one here, since it seems like children of table are usually NOT interactive. But in some of the W3 examples they have things like
 …  and assert that td elements are just gridcell roles because they’re children, even though I wasn’t aware that is expected behavior (I still thought that elements retained their default roles regardless of parent/children and role was always needed to change that).

All that said, just seems like the easiest path to just say “cell can get tabindex sometimes” rather than “only gridcell can ever get tabindex and we must do deep analysis to make sure it’s a child of grid” which just sounded like a lot of work 😅
If any future PRs make those test cases possible then you can close this issue! But I can also start on this once #4241 is in a good place to make this change

For these cases, where elements can be interactive based on certain conditions, we assume they can always be interactive.
So, to answer your question @drwpow, let's remove them :)

The fix should be easy: we just need to edit AriaRole::is_interactive. We should add proper comments and a link to the current issue.

In other words, a gridcell MUST be focusable when inside a treegrid if it’s expandable (via tabIndex), and also MUST be able to receive other keyboard commands.

I think, at some point a proper, we should add a proper Aria query that allows retrieving the roles of parent nodes.
This might allow us to check this sort of thing.


Unable to open file at a line number from the terminal if filename ends with a period

Type: Bug
When opening a file:line number link (ctrl-click) from the terminal that ends with a period, in the format "File.tsx:25", VSCode does not find any results as the period is included with the line number. Removing the period finds the result successfully.

If you remove the period, then the search functions successfully, as expected.

The trailing period should be ignored, as it is not part of the line number.

I can't reproduce the described behavior:  Do you have a project that this consistently occurs in, e.g. if you are using custom tasks?

Hi joyceerhl,
The links are present, and highlighted correctly (with the underline), and can be clicked, but they don't seem to function properly.

Line numbers not trailed by a period all seem to function properly.
Single digit line numbers trailed by a period will open the correct file, however will not place the caret on the correct line.
Double+ digit line numbers trailed by a period will not open the file, showing the "No matching results" text.

I've tested this on a clean 1.85.1 install on my Windows machine and Github Codespaces (also 1.85.1), and it does appear to be misbehaving. There is a repro repo here: https://github.com/sparxooo/PoCvscodebug
Thanks :)
sparxooo

I do repro this in a codespace, thanks for the detailed steps!

Interestingly, I think I found why single digit lines still open the correct file, and that's because the replace regex
text = text.replace(/:[^\\/][^\d]+$/, ''); in terminalLinkOpeners.ts:111 strips off the line/column number if it is a single digit, and then has a trailing period, but not if it's double+ digits.

Not a fix, but might be useful info.


feat: bump sunodo/sdk version

LGTM.
sunodo create is using the main branch, so we must merge this only when sunodo version is out.


Swift Example is working - except when clicking "Delete" which causesNSInvalidArgumentException

Hi Adam,
The Swift Example is mostly working (wohoo!).
The exception is when clicking the "Delete" button (in the upper left-hand corner) which causes an "'NSInvalidArgumentException', reason: '-[RLMResults isInvalidated]: unrecognized selector sent to instance 0x7fb8b31d1860'".
It looks like objectsWhere (TestObject.objectsWhere("%K == %@","sectionName","First Section")) is handled differently in the Realm-provided RLMSupport.swift and as a result, the results are invalidated...

the correct Swift code should be this:
let objectsInFirstSection = TestObject.objectsWhere("%K == %@","sectionName","First Section") as RLMResults

realm.beginWriteTransaction()
realm.deleteObjectsWithNotification(objectsInFirstSection)
realm.commitWriteTransaction()

sorry for the delay!


Same Identifier URI for Azure AD SAML

Based on this article: https://docs.microsoft.com/en-us/azure/active-directory/hybrid/how-to-connect-fed-single-adfs-multitenant-federation
I understand that we can set different Issuers for outgoing assertions to Azure AD, but when Azure AD makes a SAML request to ADFS, it uses the Issuer urn:federation:MicrosoftOnline.  How do you modify this when trying to federate a single ADFS environment to multiple Azure AD tenants?   Is there a way to specify in Azure AD, what the Relying Party identifier in ADFS will be?  This identifier URI needs to be unique in ADFS, and because (from what I can tell) we can't edit this, federating a single ADFS to multiple Azure AD is not as straight forward as the article shows.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1ff136fb-c076-b37a-9772-1c30a07fabec
Version Independent ID: ea5cf8c8-2ff3-7ebc-1c16-adc80912cb50
Content: Federating multiple Azure AD with single AD FS - Azure
Content Source: articles/active-directory/hybrid/how-to-connect-fed-single-adfs-multitenant-federation.md
Service: active-directory
Sub-service: hybrid
GitHub Login: @billmath
Microsoft Alias: billmath

@shadewlkr Hope you have self resolved the problem and hence closed this issue. Thanks for the update.

@shadewlkr Got you! Added the MS doc metadata to the issue and assigning the issue to concerned team. We will investigate on the issue and will get back to you shortly with an update.

@shadewlkr, The issuer urn:federation:MicrosoftOnline. remains constant for all ADFS servers across the globe. But here we need to understand how the Federation works between ADFS and an Azure AD tenant.
Ideally in a single Tenant and Single ADFS federation Scenario, if you run the command "Get-MsolFederationProperty -DomainName " for the federated domains shows that the “FederationServiceIdentifier” was the same for source ADFS and O365  i.e _http://STSname/adfs/Services/trust_
But, when we run that same command with the -supportmultipledomain switch i.e "Get-MsolFederationProperty -DomainName " on the federated domains now will show that the “FederationServiceIdentifier” is different for ADFS and O365. Every federated domain will have the “FederationServiceIdentifier” as http:///adfs/services/trust/ whereas the ADFS configuration still has _http://STSname/adfs/Services/trust._
The SupportMultipleDomain also adds the following 3rd claim rule in the O365 RP, under ADFS.
Default 3rd rule:
_c:[Type
== "http://schemas.xmlsoap.org/claims/UPN"]
=> issue(Type = "http://schemas.microsoft.com/ws/2008/06/identity/claims/issuerid", Value = regexreplace(c.Value, ".+@(?.+)", "http://${domain}/adfs/services/trust/"));_
This rule uses the suffix value of user’s UPN and uses that to generate a new claim called Issuerid. For example, for a user<EMAIL_ADDRESS>, the issuerID in his Token will be _http://contoso.com/adfs/services/trust/._
You can get more information on this link; https://blogs.technet.microsoft.com/abizerh/2013/02/05/supportmultipledomain-switch-when-managing-sso-to-office-365/
Now coming to your scenario, in you case also, there would only be one RP for O365 that would have to be configured and the 3rd claim rule as mentioned above will be configured to support every tenant using the supportmultipledomain switch for each of the domains present in different AAD tenants.
Do let us know if there are any queries around this so that we can try to help you further.

Oh, ok I see what you mean.  So there will always only be one single Relying Party Trust in ADFS for Azure AD / O365 because of the constant urn:federation:MicrosoftOnline value, regardless of how many actual Azure AD tenants we have.   We just need to map the claim rule which modifies the outgoing Issuer claim from ADFS to Azure AD on a per-UPN basis, to match the correct AAD tenant configuration, then the user will be logged in according to the outgoing Issuer Claim value.
OK I got it now, that makes more sense than adding a separate Relying Party Trust for each AAD tenant.
Thanks!

@shadewlkr, Thankyou for sharing the confirmation. We will be closing this thread for now. In case you need any further assistance on this, please feel free to re-open this thread.


Add tests, linting, CI

The usual deal

Fixed, to some extent. More tests are of course always welcome.


register float16 for gpu kenel of scatter and scatter_nd functions

Fix #20219.
I compile the codes and run those related gpu test cases. All seems passed.

The py3 test are failing. Can u fix the test?

Adding Alex for some help. @josh11b do you know who's the expert in this part?

LGTM.
Overall the kernel might be slower because it does not operator in half2. But we can improve that later if necessary.

The GPU py3 tests are still failing. All reviewers, please take a closer look.

Thank you, @qlzh727.
@zheng-xq @alextp
GPU python 3 tests failed. I checked the log file:
2018-06-26 17:23:41.925524: E tensorflow/core/framework/op_segment.cc:53] Create kernel failed: Invalid argument: AttrValue must not have reference type value of half_ref
	 for attr 'tensor_type'
	; NodeDef: Variable/_1 = _Recv[_start_time=0, client_terminated=false, recv_device="/job:localhost/replica:0/task:0/device:CPU:0", send_device="/job:localhost/replica:0/task:0/device:GPU:0", send_device_incarnation=1, tensor_name="edge_2_Variable", tensor_type=DT_HALF_REF, _device="/job:localhost/replica:0/task:0/device:CPU:0"](^ScatterAdd/indices, ^ScatterAdd/updates); Op<name=_Recv; signature= -> tensor:tensor_type; attr=tensor_type:type; attr=tensor_name:string; attr=send_device:string; attr=send_device_incarnation:int; attr=recv_device:string; attr=client_terminated:bool,default=false; is_stateful=true>

There seems something wrong with updating variable. I'm not familiar with low-level implementation of Variable, do you have any idea about the problem? Thanks.

I don't understand why we have a ref dtype argument to a send node. @facaiy can you try coercing the failing test to run on the CPU?

@alextp I'm afraid not, because those tests failed are related to float16. Moreover, they are all passed in CPU and GPU(Python2)  environment.
I don't know why we bind _Recv node with a ref type tensor_type=DT_HALF_REF. Is it a bug when building graph?

I don't know how to debug it. Could you give me some suggestion? Thanks.

@facaiy can you reproduce locally? I found that if I build with cuda and python3 and run the test I can see the error.

@alextp Thank you for your help. I'm afraid this is beyond the scope of my knowledge. So I'd like close the PR and let others take over the issue.


Fields silently ignored in Pydantic I/O types

Pre-bug-report checklist
1. This bug can be reproduced using pure Argo YAML

[ ] Yes 👉 Please report a bug to the Argo Workflows GitHub 👈
[X] No

If yes, it is more likely to be an Argo bug unrelated to Hera. Please double check before submitting an issue to Hera.
2. I have searched for existing issues

[X] Yes

3. This bug occurs in Hera when...

[X] exporting to YAML
[ ] submitting to Argo
[ ] running on Argo with the Hera runner
[ ] other:

Bug report
Describe the bug
A clear and concise description of what the bug is:
If a field on a pydantic Input/Output type has a Parameter annotation but the name is missing, the field is completely ignored.
To Reproduce
Full Hera code to reproduce the bug:
from typing import Annotated
from hera.workflows import Input, Parameter

class ExampleInput(Input):
    field1: str = "default"
    field2: Annotated[str, Parameter(description="second field")] = "another default"

parameters = ExampleInput()._get_as_arguments().parameters
assert len(parameters) == 2  # Error: field2 is missing

Expected behavior
A clear and concise description of what you expected to happen:
Either arguments should contain two entries, with the second field defaulting to a name of field2, or validation should reject the class.
Environment

Hera Version: 5.16.3
Python Version: 3.11.8
Argo Version: N/A

Additional context
It looks as if the code here is to blame: https://github.com/argoproj-labs/hera/blob/2eec4c282557823c661dae6b410b470d13a90be5/src/hera/workflows/io/_io_mixins.py#L149-L155
If name is missing, the field is skipped. Changing this to fall back to the field name would fix the issue.

Related https://github.com/argoproj-labs/hera/issues/1165 - would be good to make name optional for Parameters/Artifacts together


Update delete activity diagram in DG

Updated the activity diagram for delete command to have proper syntax.

Codecov Report

Merging #160 (356dc02) into master (e265856) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #160   +/-   ##
=========================================
  Coverage     74.68%   74.68%
  Complexity      526      526
=========================================
  Files            92       92
  Lines          1738     1738
  Branches        198      198
=========================================
  Hits           1298     1298
  Misses          362      362
  Partials         78       78

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Improve adb -s completion to show helpful info

Currently it shows for example the following
DEVICE_ID  -- transport_id:2
Which doesn't really ease device selection, I've adapted the awk script to print device name with it's model name, see the example below
DEVICE_ID  -- Pixel_3(blueline)

Good job! :+1:

Thanks


Use Event Bus as target in CloudWatch event Rule

I would like to know if Cloud Custodian supports setting up of Event Bus as target instead of using lambda.
Use case: I want some specific cloud-watch event  from 1000s of accounts to be routed to few central account which then triggers a chain of different process.

custodian has some support for it, but it assumes you've setup the event bus out of band. you also need to specify a member-role with appropriate trust relationship for the assumption back into the target accounts.

Cool thanks..@kapilt
I will check it out..


LLAMA-9259: HdmiCecSink to separate systemAudioModeRequest from Arc s…

…tart.
Reason for change: Separate out systemAudioModeRequest from Arc start.
Test Procedure: Build and Verify.
Risks: Low
Signed-off-by: bp-sramul089<EMAIL_ADDRESS>Change-Id: I4850b61bb3893a30dd51dfedb36e78a29d78d114

Cleaning up older PRs. Please create new PR on latest sprint if required.


Provide bech32 char list when user enters an invalid char

Hi, thanks, as this have conflicts with a previous PR I can't merge it, I will close this PR and change that text in another commit


HBase batch load

Hi,
I have tested the batch load  in MySQL database by using the command bellow:
bin/ycsb load jdbc -P workloads/workloada -P ~/YCSB/jdbc/src/main/conf/db.properties -p zeropadding=8 -p insertorder=ordered -p recordcount=100000 -p table=usertable100k  -threads 5 -p db.batchsize=1000 -p jdbc.fetchsize=1000 -p jdbc.autocommit=false -p jdbc.batchsize=1000 -p jdbc.batchupdateapi=true > workloada_load_100k_mysql.txt
Is there the same thing for HBase load command ?
Thank you

What have you tried so far? What error message are you getting?

I have not found a solution. is there a way to do the same thing in HBase?

the hbase loading has no equivalent. (In HBase terms this would be a bulk load option for YCSB)


Anime API

Anime
Whenever server members mentioned the bot in a specific channel, send a list of anime with their corresponding informations. It can be a listing of seasonal anime or search anime by keywords.

Server members can now mention the bot at the specified channel and the bot will try pull data from Jikan API, an unofficial open-source wrapper API that parses MyAnimeList website to get detailed data on animes. There are different ways to tell the bot what to do in this specific channel:

When mentioning the bot without any more text, it will send 10 embedded messages consisting of details of the current seasonal animes.
When mentioning the bot following with [year] [month/season], it will send 10 embedded messages consisting of details of the [year] [month/season]'s animes.
When mentioning the bot following with any [text] other than year and month/season, it will send 5 search results of anime details with the keyword [text] in embedded messages.

Member1: @BokBokGeh
BokBokGeh: [list 10 current season's anime informations]

Member1: @BokBokGeh 2022 Mar
BokBokGeh: [list 10 March 2022 season's anime informations]

Member1: @BokBokGeh Attack On Titans
BokBokGeh: [list 5 search result's anime informations]


fix: mod reduce msg_hash as input of the HMAC function

What was wrong?
Eth-keys did not fully respect RFC6979 3.2.d.
The message digest should be modulo reduced before being passed as input of HMAC function.
This issue was found after this analysis.
According to the RFC, it should pass through a bits2octets function:
 K = HMAC_K(V || 0x01 || int2octets(x) || bits2octets(h1))

By looking into the definition of bits2octets, it states that the message digest needs to be reduced before  being passed to the HMAC function:
2.3.4.  Bit String to Octet String

   The bits2octets transform takes as input a sequence of blen bits and
   outputs a sequence of rlen bits.  It consists of the following steps:

   1.  The input sequence b is converted into an integer value z1
       through the bits2int transform:

          z1 = bits2int(b)

   2.  z1 is reduced modulo q, yielding z2 (an integer between 0 and
       q-1, inclusive):

          z2 = z1 mod q
   ...

Closes #101
How was it fixed?
Todo:

[X] Clean up commit history
[X] Add or update documentation related to these changes
[X] Add entry to the release notes

Test are failing for coincurve < 17: those versions use libsecp256k1 prior to commit d8a246324650c3df8d54d133a8ac3c1b857a7a4e and do not include the PR of the fix for the modulo reduction https://github.com/bitcoin-core/secp256k1/pull/1064
https://github.com/ofek/coincurve/compare/v16.0.0...v17.0.0


feat: issue #28 - output "create voting" URL in discord

feat: implement /vote discord command for returning "vote proposal creation" url
resolves #28  for 3 points

@KrisDv  - can you check this build output:
Error: /home/runner/work/apocryph-dao-bot/apocryph-dao-bot/src/Apocryph.Dao.Bot/Services/DiscordProxyHostedService.cs(114,53): error CS0117: 'MessageResources' does not contain a definition for 'ProposalEventMessage_GetThumbnailUrl' [/home/runner/work/apocryph-dao-bot/apocryph-dao-bot/src/Apocryph.Dao.Bot/Apocryph.Dao.Bot.csproj]


QC on the PlutoF download: station and arms unit names

Thing to improve wrt the download from PlutoF as is coded currently (July 27)

I had sent you a spreadsheet with the corrected names of the stations, please include those corrections: for example Swedish_West_coast should be "SWC". The hard-coded syntax corrections you have in that code are otherwise OK and should remain as such, only the station names need to be taken from this spreadsheet
Please add an error check/alert to your download: if a station is downloaded that is not in my spreadsheet, inform me and I will update the spreadsheet. Maybe we should put that correction spreadsheet somewhere in GitHub (rather than attached to this issue)?
In addition to the other hard-coded syntax fixes you implement in your code, please add a "remove spaces": the gulf of piran arms units called Luka KP and Boja Vida, for example, need to be changed to LukaKP and BojaVida
I think your code is, however, too harsh in that the station called Greenland has now arms units called 1 2 3 1 2 3, rather than Nuuk1/2/3 and Danebork1/2/3. Please fix this but in a way that is future-proof, not just for this next download
The same comment for the station called Laeso

If you think we need to discuss a better way to manage this QC of the station and arms unit names, probably better to do so before Aug 12. In the end it may be better to use my input to correct these names, rather than hard-coding, but with alerts for when something new is encountered that I have not yet provided input for
The spreadsheet with the corrections to apply to the station and arms names:
PlutoF_QC_v2_StationARMSnames.csv

Station names are now corrected better, however there are differences between my QC CSV file input and what is in PlutoF, and that is not caught by the script. So first I need to update the QC CSV input and second the code needs to catch these differences. I will raise that as a new issue.


Implement new 'Mosaic Owned' endpoints

As new endpoints introduced in catapult-rest and OpenAPI v0.7.19

Referenced issue: https://github.com/nemtech/nem2-openapi/pull/32
Note that this endpoint is not implemented in REST and the API contract could be modified.

Referenced issue: nemtech/nem2-openapi#32
Note that this endpoint is not implemented in REST and the API contract could be modified.

Not implemented yet. Wait for Rest to confirm first


dbus-serialbattery v1.0 does not work

this time it does not work with
dbus-serialbattery v1.0

INFO:root:2023-06-04 09:34:22.515806: Starting battery monitor.
INFO:root:2023-06-04 09:34:22.518107: Connected to DBus, and switching over to GLib.MainLoop()
INFO:dbusmonitor:===== Search on dbus for services that we will monitor starting... =====
INFO:dbusmonitor:Found: com.victronenergy.battery.ttyACM0, scanning and storing items
INFO:dbusmonitor:       com.victronenergy.battery.ttyACM0 has device instance 1
INFO:dbusmonitor:Found: com.victronenergy.battery.ttyACM1, scanning and storing items
INFO:dbusmonitor:       com.victronenergy.battery.ttyACM1 has device instance 2
INFO:dbusmonitor:Found: com.victronenergy.vebus.ttyUSB1, scanning and storing items
INFO:dbusmonitor:       com.victronenergy.vebus.ttyUSB1 has device instance 289
INFO:dbusmonitor:Found: com.victronenergy.battery.aggregate, scanning and storing items
INFO:dbusmonitor:       com.victronenergy.battery.aggregate has device instance 0
INFO:dbusmonitor:===== Search on dbus for services that we will monitor finished =====
INFO:root:2023-06-04 09:34:27.519260: Searching batteries: Trial Nr. 1
INFO:root:2023-06-04 09:34:27.523609: 0 batteries found.
INFO:root:2023-06-04 09:34:32.520314: Searching batteries: Trial Nr. 2
INFO:root:2023-06-04 09:34:32.524610: 0 batteries found.
INFO:root:2023-06-04 09:34:37.521759: Searching batteries: Trial Nr. 3
INFO:root:2023-06-04 09:34:37.526632: 0 batteries found.
INFO:root:2023-06-04 09:34:42.523038: Searching batteries: Trial Nr. 4
INFO:root:2023-06-04 09:34:42.528119: 0 batteries found.
INFO:root:2023-06-04 09:34:47.523637: Searching batteries: Trial Nr. 5
INFO:root:2023-06-04 09:34:47.528414: 0 batteries found.
INFO:root:2023-06-04 09:34:52.524732: Searching batteries: Trial Nr. 6
INFO:root:2023-06-04 09:34:52.528862: 0 batteries found.
INFO:root:2023-06-04 09:34:57.525312: Searching batteries: Trial Nr. 7
INFO:root:2023-06-04 09:34:57.529618: 0 batteries found.
INFO:root:2023-06-04 09:35:02.526156: Searching batteries: Trial Nr. 8
INFO:root:2023-06-04 09:35:02.530866: 0 batteries found.
INFO:root:2023-06-04 09:35:07.527352: Searching batteries: Trial Nr. 9
INFO:root:2023-06-04 09:35:07.532048: 0 batteries found.
INFO:root:2023-06-04 09:35:12.527914: Searching batteries: Trial Nr. 10
INFO:root:2023-06-04 09:35:12.532192: 0 batteries found.
INFO:root:2023-06-04 09:35:17.529079: Searching batteries: Trial Nr. 11
INFO:root:2023-06-04 09:35:17.533460: 0 batteries found.
ERROR:root:2023-06-04 09:35:17.534549: Required number of batteries not found. Exiting.

Hello @stixif,
I think you should change the value in the settings.py to '/ProductName' not in the source code.
BATTERY_NAME_PATH = '/CustomName'                       # What defines the battery name
https://github.com/Dr-Gigavolt/dbus-aggregate-batteries/pull/40

Hi Marvo, i know... but in the source you do not use this value...
check my changes...

Hey @stixif,
ah okay, now I understand. I will try dbus-serialbattery v1.0 and will have a look about the missing dbus '/ProductName'.

I have exactly th same PRoblem and i don´t understand how to solve it, can you plese help me:
INFO:root:2023-06-11 16:27:47.193831: Starting AggregateBatteries.
INFO:root:registered ourselves on D-Bus as com.victronenergy.battery.aggregate
INFO:root:2023-06-11 16:27:47.307538: Initial Ah read from file: 340Ah
INFO:root:2023-06-11 16:27:47.442479: Starting battery monitor.
INFO:root:2023-06-11 16:27:47.444878: Connected to DBus, and switching over to GLib.MainLoop()
INFO:dbusmonitor:===== Search on dbus for services that we will monitor starting... =====
INFO:dbusmonitor:Found: com.victronenergy.battery.ttyACM0, scanning and storing items
INFO:dbusmonitor:       com.victronenergy.battery.ttyACM0 has device instance 1
INFO:dbusmonitor:Found: com.victronenergy.vebus.ttyS4, scanning and storing items
INFO:dbusmonitor:       com.victronenergy.vebus.ttyS4 has device instance 276
INFO:dbusmonitor:Found: com.victronenergy.battery.ttyACM1, scanning and storing items
INFO:dbusmonitor:       com.victronenergy.battery.ttyACM1 has device instance 2
INFO:dbusmonitor:Found: com.victronenergy.battery.aggregate, scanning and storing items
INFO:dbusmonitor:       com.victronenergy.battery.aggregate has device instance 0
INFO:dbusmonitor:Found: com.victronenergy.solarcharger.socketcan_can0_vi0_uc229774, scanning and storing items
INFO:dbusmonitor:       com.victronenergy.solarcharger.socketcan_can0_vi0_uc229774 has device instance 0
INFO:dbusmonitor:===== Search on dbus for services that we will monitor finished =====
INFO:root:2023-06-11 16:27:52.445687: Searching batteries: Trial Nr. 1
INFO:root:2023-06-11 16:27:52.449233: 0 batteries found.
INFO:root:2023-06-11 16:27:57.446693: Searching batteries: Trial Nr. 2
INFO:root:2023-06-11 16:27:57.450924: 0 batteries found.
INFO:root:2023-06-11 16:28:02.447534: Searching batteries: Trial Nr. 3
INFO:root:2023-06-11 16:28:02.451331: 0 batteries found.
INFO:root:2023-06-11 16:28:07.448134: Searching batteries: Trial Nr. 4
INFO:root:2023-06-11 16:28:07.451892: 0 batteries found.
INFO:root:2023-06-11 16:28:12.448720: Searching batteries: Trial Nr. 5
INFO:root:2023-06-11 16:28:12.453803: 0 batteries found.
INFO:root:2023-06-11 16:28:17.449740: Searching batteries: Trial Nr. 6
INFO:root:2023-06-11 16:28:17.453409: 0 batteries found.
INFO:root:2023-06-11 16:28:22.450018: Searching batteries: Trial Nr. 7
INFO:root:2023-06-11 16:28:22.454556: 0 batteries found.
INFO:root:2023-06-11 16:28:27.450420: Searching batteries: Trial Nr. 8
INFO:root:2023-06-11 16:28:27.454315: 0 batteries found.
INFO:root:2023-06-11 16:28:32.451257: Searching batteries: Trial Nr. 9
INFO:root:2023-06-11 16:28:32.456233: 0 batteries found.
INFO:root:2023-06-11 16:28:37.452156: Searching batteries: Trial Nr. 10
INFO:root:2023-06-11 16:28:37.456824: 0 batteries found.
INFO:root:2023-06-11 16:28:42.452665: Searching batteries: Trial Nr. 11
INFO:root:2023-06-11 16:28:42.457199: 0 batteries found.
ERROR:root:2023-06-11 16:28:42.460423: Required number of batteries not found. Exiting.

@pit65535 look at @stixif patch, only 2 lines to edit, very simple. I think dbus-serialbattery has remove /ProductName form the dbus. But we have checked it for now. We will take a look as soon as possible.

Hi Marvo, looks i´m really too stupid :-(, I tried changing in settings.py:
BATTERY_NAME_PATH = '/CustomName'                       # What defines the battery name
in BATTERY_NAME_PATH = '/ProductName'                       # What defines the battery name
but still the same......
can yo just tell me the two lines I should edit in what file?

@pit65535 Please look here: https://github.com/Dr-Gigavolt/dbus-aggregate-batteries/pull/40/files and revert settings.py to original /CustomName

@Marvo2011
Ahhh thank you very much!
This helped, now everthing works again :-)

Please try the 3.0, I hope it works now.


upgrading webpack version

Hi Swift502,
First of all thanks for your help on the CSM issue again. 👍🏽 Love your work.
Secondly, I am making this PR for upgrading the versions of the libraries before working on other features. I am kind of new to open-source so would love your guidance here as well.
I will seperate this into 4-5 commits something like:

upgrading webpack (done)
upgrading sweet-alert2 (done).
upgrading three-csm and three (done).
moving cannon to package.json (work in progress)

Best wishes,
Vivasvan

Heyyy. This looks really cool. This PR might finally convince me to update a couple of things I thought I wanted to put in the project, but weren't substantial enough on their own.
Did you actually manage to fix animation blending in new versions of three.js? That would be amazing and I would definitely want to merge this.
Just please be patient with me. It might take some time to get it approved, it's a lot of changes and I haven't seen most of this code in literally 4 years. Whoops. 😅

And yeah, technically this PR looks great. I won't merge until I get an Okay from you that it's ready. I see that you're still working on porting cannon.

Did you actually manage to fix animation blending in new versions of three.js? That would be amazing and I would definitely want to merge this.

I confess, unfortunatly, I kind of found a hacky solution :/ which seems to work but i am kind of unhappy about it.
So,
I felt there we 2 issues in the animation thing:

mixer.stopAllAction() has changed from letting the existing actions to fadeOut to removing all scheduled fadeIns,fadeOuts, etc. (still not documented in migration guide of threejs)
Animation which are not designed to loop are looping. (example, drop_idle animation)

I wrote this codepen to see if the animationAction can work with controls like we have written with fadeOut and fadeIn logic.
And it seemed to work fine.
So i replaced the stopAllAction with for loop of fadeOuts to all actions.
the animation still felt NOT to be working smoothly which i felt was because of animation loop of non-loopable animations. So i made the animation speed's slightly slower and it kind of works like that.
action.setEffectiveTimeScale(0.7);
Which slows the animations but it atleast didnt glitch like before.
I suspect its because of update being called too fast with the new version of libraries for some reason and the animations starts looping faster than it should.
Anyway, hope this info helps.

And yeah, technically this PR looks great. I won't merge until I get an Okay from you that it's ready. I see that you're still working on porting cannon.

Yes I would like to get the cannon-es into the package.json before merging this. I'll keep you posted on it ))

Hi @swift502. Happy new year. Hope u doing good.

@vivasvan1 hey please check your discord messages.


[C++] stringop-overflow warning in generateConstPropertyMethods output

While building SBE-generated C++ code for <group> fields, I see the following compiler warning for code generated from Group->Field elements with a char primitive type:
warning: 'strlen' argument missing terminating nul [-Wstringop-overflow=]
The generated code block looks like this:
class MDIncrementalRefreshTradeSummary42
{
	.....
    class NoMDEntries
    {
        .....
        SBE_NODISCARD const char *mDEntryType() const
        {
            static const std::uint8_t mDEntryTypeValues[] = { 50 };

            return (const char *)mDEntryTypeValues;
        }

Inspecting the situation, I see that:

SBE-message end-users should use length functions like mDEntryTypeLength()
The return value of mDEntryType() truly a pointer to a single char, not a NULL-terminated string.

So in that regard, this is not a SBE codegen bug.  But, unfortunately any C++ programmer can pass that const char* to a myriad of functions that expect the input to be NULL terminated.   This could lead to inadvertent out-of-bounds / buffer-overrun bugs.
Adding a NULL to the static array in that function would mitigate this class of bugs at small expense of static storage.  So something like this at this line:
-            indent + "        static const std::uint8_t %1$sValues[] = { %2$s };\n\n" +
+            indent + "        static const std::uint8_t %1$sValues[] = { %2$s, 0 };\n\n" +

While I'm here, I'd also like to thank you for all your fantastic contributions and thought leadership to both software engineering at-large and particularly in the trading community.  🤗

Can you post the snippet of the schema for the field?

It is the MDEntryType field of NoGroupEntries group of MDIncrementalRefreshTradeSummary42 messages from this
CME schema:
ftp://ftp.cmegroup.com/SBEFix/Production/Templates/templates_FixBinary.xml
    <ns2:message name="MDIncrementalRefreshTradeSummary42" id="42" description="MDIncrementalRefreshTradeSummary" blockLength="11" semanticType="X" sinceVersion="5">
        <field name="TransactTime" id="60" type="uInt64" description="Start of event processing time in number of nanoseconds since Unix epoch" offset="0" semanticType="UTCTimestamp"/>
        <field name="MatchEventIndicator" id="5799" type="MatchEventIndicator" description="Bitmap field of eight Boolean type indicators reflecting the end of updates for a given Globex event" offset="8" semanticType="MultipleCharValue"/>
        <group name="NoMDEntries" id="268" description="Number of Trade Summary entries" blockLength="32" dimensionType="groupSize">
            <field name="MDEntryPx" id="270" type="PRICE" description="Trade price" offset="0" semanticType="Price"/>
            <field name="MDEntrySize" id="271" type="Int32" description="Consolidated trade quantity" offset="8" semanticType="Qty"/>
            <field name="SecurityID" id="48" type="Int32" description="Security ID as defined by CME" offset="12" semanticType="int"/>
            <field name="RptSeq" id="83" type="uInt32" description="Sequence number per instrument update" offset="16" semanticType="int"/>
            <field name="NumberOfOrders" id="346" type="Int32NULL" description="The total number of real orders per instrument that participated in a match step within a match event" offset="20" semanticType="int"/>
            <field name="AggressorSide" id="5797" type="AggressorSide" description="Indicates which side is the aggressor or if there is no aggressor" offset="24" semanticType="int"/>
            <field name="MDUpdateAction" id="279" type="MDUpdateAction" description="Market Data update action" offset="25" semanticType="int"/>
            <field name="MDEntryType" id="269" type="MDEntryTypeTrade" description="Market Data entry type" semanticType="char"/>
            <field name="MDTradeEntryID" id="37711" type="uInt32NULL" description="Market Data Trade entry ID" offset="26" sinceVersion="7" semanticType="int"/>
        </group>
        <group name="NoOrderIDEntries" id="37705" description="Number of OrderID entries" blockLength="16" dimensionType="groupSize8Byte">
            <field name="OrderID" id="37" type="uInt64" description="Unique order identifier as assigned by the exchange" offset="0" semanticType="int"/>
            <field name="LastQty" id="32" type="Int32" description="Quantity bought or sold on this last fill" offset="8" semanticType="Qty"/>
        </group>
    </ns2:message>

For constant values I can kind of see a point here. However this issue would exist regardless for required values if the user filled all values of the array with chars and did not put in a null termination. Adding the null terminator like you suggest might be the safest way to go.


Better Error Messaging on Parse

Error messages on parse are not very good.

[ ] currently missing functions don't return an error as they should bc the validate allows missing.
[ ] create a variety of failed queries, and watch for error messages, create tests for those cases.

mostly addressed here  https://github.com/araddon/qlbridge/commit/2aaea745b358374c30541108378243ea4426e746


Again adding some more of my servers

Hi!
fvz-rec-de-dus-01's fingerprint is interesting :)
Other resolvers that currently don't work:
- fvz-rec-fr-rbx-01 - Failed
- fvz-rec-fr-rbx-01 - Failed
- fvz-rec-pl-mz-01 - Failed
- fvz-rec-ru-mow-01 - Failed

Hi,
thanks for letting me know that the fingerprint is broken.
The provider stopped hosting fvz-rec-fr-rbx-01 and will stop hosting the other one in France too so I also removed that.
fvz-rec-pl-mz-01 That provider is blocking UDP on port 443. I wrote them an email now, lets see if they removed it. If not, there are still plenty of other ports the daemon is listening on (54, 5353, 27015, ...).
fvz-rec-ru-mow-01 That was just a short outage, sadly that server is not as stable as the other ones, especially when the hardware node or one of the other customers' VPSes gets attacked.


fix go back character (see screenshot)

which browser are you using?

chrome and firefox, guess my os doesn't have a default font that supports this arrow, maybe we replace ⭠ with <CgArrowLeft /> from react icons


Plugin installation throws SyntaxError: Cannot import statement outside a modul

Thank you for your work on this plugin. Could you give me advise how to install it? When follow your instrutions in readme I get:
tiddlywiki_1  | Error executing boot module $:/plugins/linonetwo/watch-fs/FileSystemMonitor.js: {}
tiddlywiki_1  |
tiddlywiki_1  | $:/plugins/linonetwo/watch-fs/FileSystemMonitor.js:5
tiddlywiki_1  | import chokidar from 'chokidar';
tiddlywiki_1  | ^^^^^^
tiddlywiki_1  |
tiddlywiki_1  | SyntaxError: Cannot use import statement outside a module
tiddlywiki_1  |     at new Script (node:vm:94:7)
tiddlywiki_1  |     at createScript (node:vm:250:10)
tiddlywiki_1  |     at Object.runInNewContext (node:vm:291:10)
tiddlywiki_1  |     at $tw.utils.evalSandboxed ($:/boot/boot.js:601:5)
tiddlywiki_1  |     at $tw.modules.execute ($:/boot/boot.js:879:15)
tiddlywiki_1  |     at $:/boot/boot.js:919:30
tiddlywiki_1  |     at $tw.utils.each ($:/boot/boot.js:155:12)
tiddlywiki_1  |     at $tw.modules.forEachModuleOfType ($:/boot/boot.js:918:12)
tiddlywiki_1  |     at $tw.boot.execStartup ($:/boot/boot.js:2478:14)
tiddlywiki_1  |     at $tw.boot.startup ($:/boot/boot.js:2497:11)

To clarify: I copied the content of src/watch-fs to mywiki/plugins/watch-fs. I did not update my tiddlywiki.info. I tried with and without adding the plugin to my wiki start arguments, it seems to load it also when not added.

When installing plugins in this Organization, you should install from CPL https://tw-cpl.netlify.app/#Plugin_202310110932256
we don't put anything in /plugins folder, it is hard to upgrade.

I think this plugin don't handle rename well (not sure), so don't forget to backup.

Thanks, that worked :heavy_check_mark:


Kevin Ochoa

Kevin Ubaldo Ochoa quinonez

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 272125ec-d694-2abd-a879-d288f3d28934
Version Independent ID: e5c34866-d43c-a204-f03c-677c5a646efe
Content: Getting Started - Adaptive Cards
Content Source: AdaptiveCards/authoring-cards/getting-started.md
Product: adaptive-cards
GitHub Login: @matthidinger
Microsoft Alias: mahiding{
"type": "AdaptiveCard",
"version": "1.0",
"body": [
{
"type": "TextBlock",
"text": "Here is a ninja cat"
},
{
"type": "Image",
"url": "http://adaptivecards.io/content/cats/1.png"
}
]
}

Dupe of #306


Module parse failed

I get the following when trying to use the Letter and extract components:
./node_modules/lettersanitizer/lib/index.js 65:20
Module parse failed: Unexpected token (65:20)
File was processed with these loaders:
 * ./node_modules/react-scripts/node_modules/babel-loader/lib/index.js
You may need an additional loader to handle the result of these loaders.
|   let node;
|   while (node = commentIter.nextNode()) {
>     node.parentNode?.removeChild(node);
|   }
|   const removeTags = [...removeWithContents];

@david9100 Your Babel configuration likely doesn't support new ECMAScript syntax: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining
Could you tell me more about your setup? What Babel version are you using, did you use any generators (create-react-app?) to bootstrap the project? What React version are you using, if any?
Most likely this issue can be resolved by updating React and react-scripts if you're using CRA, or by updating Babel and making sure it's configured to support modern ECMAScript syntax.

@mat-sz Thanks for the quick follow up.  I'm using a react app starter I purchased from Bootstrap.  My package.json is as follows:
{
"name": "hyper-react",
"version": "3.0.0",
"private": true,
"dependencies": {
"@fortawesome/fontawesome-svg-core": "^6.1.2",
"@fortawesome/free-solid-svg-icons": "^6.1.2",
"@fortawesome/react-fontawesome": "^0.2.0",
"@fullcalendar/bootstrap": "^5.7.2",
"@fullcalendar/core": "^5.7.2",
"@fullcalendar/daygrid": "^5.7.2",
"@fullcalendar/interaction": "^5.7.2",
"@fullcalendar/list": "^5.7.2",
"@fullcalendar/react": "^5.7.0",
"@fullcalendar/timegrid": "^5.7.2",
"@hookform/resolvers": "^2.8.5",
"@reduxjs/toolkit": "^1.8.3",
"@testing-library/jest-dom": "^5.11.4",
"@testing-library/react": "^11.1.0",
"@testing-library/user-event": "^12.1.10",
"apexcharts": "^3.33.0",
"axios": "^0.24.0",
"base64-js": "^1.5.1",
"bootstrap": "^5.1.3",
"britecharts-react": "^0.5.4",
"chart.js": "^3.7.0",
"classnames": "^2.3.1",
"draft-js": "^0.11.5",
"draftjs-to-html": "^0.9.1",
"frappe-gantt": "^0.5.0",
"google-maps-react": "^2.0.6",
"http-proxy-middleware": "^2.0.1",
"i18next": "^20.2.1",
"i18next-browser-languagedetector": "^6.1.0",
"jodit-react": "^1.1.17",
"jsvectormap": "^1.3.1",
"jwt-decode": "^3.1.2",
"letterparser": "^0.0.10",
"node-sass": "^5.0.0",
"nouislider-react": "^3.3.7",
"prop-types": "^15.7.2",
"react": "^17.0.2",
"react-app-polyfill": "1.0.6",
"react-albus": "^2.0.0",
"react-apexcharts": "^1.3.9",
"react-beautiful-dnd": "^13.0.0",
"react-bootstrap": "v2.0.0-alpha.2",
"react-bootstrap-typeahead": "^5.1.4",
"react-chartjs-2": "^2.9.0",
"react-datepicker": "^4.1.1",
"react-dom": "^17.0.2",
"react-draft-wysiwyg": "^1.14.5",
"react-dropzone": "^11.3.2",
"react-feather": "^2.0.9",
"react-hook-form": "^7.33.1",
"react-html-parser": "^2.0.2",
"react-i18next": "^11.8.12",
"react-letter": "^0.3.1",
"react-rating": "^2.0.5",
"react-redux": "^7.2.3",
"react-router-dom": "^5.2.0",
"react-scripts": "4.0.3",
"react-select": "^5.2.2",
"react-table": "^7.7.0",
"react-text-mask": "^5.4.3",
"redux": "^4.0.5",
"redux-saga": "^1.1.3",
"simplebar-react": "^2.3.3",
"universal-cookie": "^4.0.4",
"web-vitals": "^1.0.1",
"yup": "^0.32.9",
"yup-phone": "^1.2.19"
},
"scripts": {
"start": "react-scripts start",
"build": "react-scripts build",
"test": "react-scripts test",
"eject": "react-scripts eject",
"flow": "flow",
"format": "prettier --write 'src/**/*.js'"
},
"eslintConfig": {
"extends": [
"react-app",
"react-app/jest"
]
},
"browserslist": {
"production": [
">0.2%",
"not dead",
"not op_mini all"
],
"development": [
"last 1 chrome version",
"last 1 firefox version",
"last 1 safari version"
]
},
"devDependencies": {
"flow-bin": "^0.153.0",
"prettier": "2.3.1",
"redux-saga-test-plan": "^4.0.1"
}
}
While babel is not specifically listed in the package.json, it appears quite a bit in my yarn.lock file.
"<EMAIL_ADDRESS>version "7.12.3"
resolved<EMAIL_ADDRESS>integrity sha512-0qXcZYKZp3/6N2jKYVxZv0aNCsxTSVCiK72DTiTYZAu7sjg73W0/aynWjMbiGd87EQL4WyA8reiJVh92AVla9g==
dependencies:
"@babel/code-frame" "^7.10.4"
"@babel/generator" "^7.12.1"
"@babel/helper-module-transforms" "^7.12.1"
"@babel/helpers" "^7.12.1"
"@babel/parser" "^7.12.3"
"@babel/template" "^7.10.4"
"@babel/traverse" "^7.12.1"
"@babel/types" "^7.12.1"
convert-source-map "^1.7.0"
debug "^4.1.0"
gensync "^1.0.0-beta.1"
json5 "^2.1.2"
lodash "^4.17.19"
resolve "^1.3.2"
semver "^5.4.1"
source-map "^0.5.0"
"<EMAIL_ADDRESS>"<EMAIL_ADDRESS>"<EMAIL_ADDRESS>"<EMAIL_ADDRESS>"<EMAIL_ADDRESS>version "7.19.6"
resolved<EMAIL_ADDRESS>integrity sha512-D2Ue4KHpc6Ys2+AxpIx1BZ8+UegLLLE2p3KJEuJRKmokHOtl49jQ5ny1773KsGLZs8MQvBidAF6yWUJxRqtKtg==
dependencies:
"@ampproject/remapping" "^2.1.0"
"@babel/code-frame" "^7.18.6"
"@babel/generator" "^7.19.6"
"@babel/helper-compilation-targets" "^7.19.3"
"@babel/helper-module-transforms" "^7.19.6"
"@babel/helpers" "^7.19.4"
"@babel/parser" "^7.19.6"
"@babel/template" "^7.18.10"
"@babel/traverse" "^7.19.6"
"@babel/types" "^7.19.4"
convert-source-map "^1.7.0"
debug "^4.1.0"
gensync "^1.0.0-beta.2"
json5 "^2.2.1"
semver "^6.3.0"

@david9100 I'd advise not to buy any starters like that in the future, as they usually are heavily outdated, best way to bootstrap React is to use yarn create react-app, and there are many good templates for CRA.
The template you're using is one major version behind in terms of react-scripts (current version is 5.0.1). Please update react, react-scripts and react-dom to their latest versions (and if compatibility issues arise, all the other libraries as well). Unfortunately due to the extra complexity in project maintenance, older versions of software are not supported, as that would require extra time spent on testing every update.
Could you also check yarn.lock for @babel/preset-env? Looking through dependency chains, this package.json should download the latest version of that anyway, but seems not to.

@david9100 Upon further inspection, this looks more like a Webpack issue, updating react-scripts should resolve this anyway. Seems like 4.0.3 of react-scripts relies on Webpack 4, whereas the issue was resolved in Webpack 5.

didn't seem to care much for that change:
Compiled with problems:

ERROR in ./node_modules/htmlparser2/lib/WritableStream.js 5:13-37

Module not found: Error: Can't resolve 'buffer' in './node_modules/htmlparser2/lib'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
	- add a fallback 'resolve.fallback: { "buffer": require.resolve("buffer/") }'
	- install 'buffer'
If you don't want to include a polyfill, you can use an empty module like this:
	resolve.fallback: { "buffer": false }

ERROR in ./node_modules/lettercoder/lib/esm/index.js 4:26-53

Module not found: Error: Can't resolve 'util' in './node_modules/lettercoder/lib/esm'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
	- add a fallback 'resolve.fallback: { "util": require.resolve("util/") }'
	- install 'util'
If you don't want to include a polyfill, you can use an empty module like this:
	resolve.fallback: { "util": false }

ERROR in ./node_modules/letterparser/lib/esm/parser.js 6:26-53

Module not found: Error: Can't resolve 'util' in './node_modules/letterparser/lib/esm'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
	- add a fallback 'resolve.fallback: { "util": require.resolve("util/") }'
	- install 'util'
If you don't want to include a polyfill, you can use an empty module like this:
	resolve.fallback: { "util": false }

ERROR in ./node_modules/safe-buffer/index.js 3:13-30

Module not found: Error: Can't resolve 'buffer' in './node_modules/safe-buffer'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
	- add a fallback 'resolve.fallback: { "buffer": require.resolve("buffer/") }'
	- install 'buffer'
If you don't want to include a polyfill, you can use an empty module like this:
	resolve.fallback: { "buffer": false }

"<EMAIL_ADDRESS>"<EMAIL_ADDRESS>"<EMAIL_ADDRESS>version "7.19.4"
resolved<EMAIL_ADDRESS>integrity sha512-5QVOTXUdqTCjQuh2GGtdd7YEhoRXBMVGROAtsBeLGIbIz3obCBIfRMT1I3ZKkMgNzwkyCkftDXSSkHxnfVf4qg==
dependencies:
"@babel/compat-data" "^7.19.4"
"@babel/helper-compilation-targets" "^7.19.3"
"@babel/helper-plugin-utils" "^7.19.0"
"@babel/helper-validator-option" "^7.18.6"
"@babel/plugin-bugfix-safari-id-destructuring-collision-in-function-expression" "^7.18.6"
"@babel/plugin-bugfix-v8-spread-parameters-in-optional-chaining" "^7.18.9"
"@babel/plugin-proposal-async-generator-functions" "^7.19.1"
"@babel/plugin-proposal-class-properties" "^7.18.6"
"@babel/plugin-proposal-class-static-block" "^7.18.6"
"@babel/plugin-proposal-dynamic-import" "^7.18.6"
"@babel/plugin-proposal-export-namespace-from" "^7.18.9"
"@babel/plugin-proposal-json-strings" "^7.18.6"
"@babel/plugin-proposal-logical-assignment-operators" "^7.18.9"
"@babel/plugin-proposal-nullish-coalescing-operator" "^7.18.6"
"@babel/plugin-proposal-numeric-separator" "^7.18.6"
"@babel/plugin-proposal-object-rest-spread" "^7.19.4"
"@babel/plugin-proposal-optional-catch-binding" "^7.18.6"
"@babel/plugin-proposal-optional-chaining" "^7.18.9"
"@babel/plugin-proposal-private-methods" "^7.18.6"
"@babel/plugin-proposal-private-property-in-object" "^7.18.6"
"@babel/plugin-proposal-unicode-property-regex" "^7.18.6"
"@babel/plugin-syntax-async-generators" "^7.8.4"
"@babel/plugin-syntax-class-properties" "^7.12.13"
"@babel/plugin-syntax-class-static-block" "^7.14.5"
"@babel/plugin-syntax-dynamic-import" "^7.8.3"
"@babel/plugin-syntax-export-namespace-from" "^7.8.3"
"@babel/plugin-syntax-import-assertions" "^7.18.6"
"@babel/plugin-syntax-json-strings" "^7.8.3"
"@babel/plugin-syntax-logical-assignment-operators" "^7.10.4"
"@babel/plugin-syntax-nullish-coalescing-operator" "^7.8.3"
"@babel/plugin-syntax-numeric-separator" "^7.10.4"
"@babel/plugin-syntax-object-rest-spread" "^7.8.3"
"@babel/plugin-syntax-optional-catch-binding" "^7.8.3"
"@babel/plugin-syntax-optional-chaining" "^7.8.3"
"@babel/plugin-syntax-private-property-in-object" "^7.14.5"
"@babel/plugin-syntax-top-level-await" "^7.14.5"
"@babel/plugin-transform-arrow-functions" "^7.18.6"
"@babel/plugin-transform-async-to-generator" "^7.18.6"
"@babel/plugin-transform-block-scoped-functions" "^7.18.6"
"@babel/plugin-transform-block-scoping" "^7.19.4"
"@babel/plugin-transform-classes" "^7.19.0"
"@babel/plugin-transform-computed-properties" "^7.18.9"
"@babel/plugin-transform-destructuring" "^7.19.4"
"@babel/plugin-transform-dotall-regex" "^7.18.6"
"@babel/plugin-transform-duplicate-keys" "^7.18.9"
"@babel/plugin-transform-exponentiation-operator" "^7.18.6"
"@babel/plugin-transform-for-of" "^7.18.8"
"@babel/plugin-transform-function-name" "^7.18.9"
"@babel/plugin-transform-literals" "^7.18.9"
"@babel/plugin-transform-member-expression-literals" "^7.18.6"
"@babel/plugin-transform-modules-amd" "^7.18.6"
"@babel/plugin-transform-modules-commonjs" "^7.18.6"
"@babel/plugin-transform-modules-systemjs" "^7.19.0"
"@babel/plugin-transform-modules-umd" "^7.18.6"
"@babel/plugin-transform-named-capturing-groups-regex" "^7.19.1"
"@babel/plugin-transform-new-target" "^7.18.6"
"@babel/plugin-transform-object-super" "^7.18.6"
"@babel/plugin-transform-parameters" "^7.18.8"
"@babel/plugin-transform-property-literals" "^7.18.6"
"@babel/plugin-transform-regenerator" "^7.18.6"
"@babel/plugin-transform-reserved-words" "^7.18.6"
"@babel/plugin-transform-shorthand-properties" "^7.18.6"
"@babel/plugin-transform-spread" "^7.19.0"
"@babel/plugin-transform-sticky-regex" "^7.18.6"
"@babel/plugin-transform-template-literals" "^7.18.9"
"@babel/plugin-transform-typeof-symbol" "^7.18.9"
"@babel/plugin-transform-unicode-escapes" "^7.18.10"
"@babel/plugin-transform-unicode-regex" "^7.18.6"
"@babel/preset-modules" "^0.1.5"
"@babel/types" "^7.19.4"
babel-plugin-polyfill-corejs2 "^0.3.3"
babel-plugin-polyfill-corejs3 "^0.6.0"
babel-plugin-polyfill-regenerator "^0.4.1"
core-js-compat "^3.25.1"
semver "^6.3.0"

@mat-sz - Thanks for all of your help.  Along with the direction you provided, the answer was in the error message I provided above.  I simply needed to install util and buffer.


Load PDF from source

Hello there 👋
First of all, thanks for building such ha wonderful library!
I was wondering if it's possible to file from source code like we would do in case of an image
<PdfRendererView source={require('./path/to/file.pdf')} />

I think yes, but I need to do some research to know how to get the absolute path from a JS require.


Propagating copy-constructor triviality

I noticed I wasn't able to instantiate std::atomic<nonstd::optional<int>> in Visual Studio 2019 because std::is_trivially_copyable wasn't true for nonstd::optional<int>
There's a defect report for this: https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0602r1.html (Not sure if it was actually accepted into the standard? But at least Microsoft implemented it in their STL implementation https://learn.microsoft.com/en-us/cpp/overview/what-s-new-for-cpp-2017?view=msvc-170 )

Thanks for the heads-up.
Had a brief look at it. It may not be a 'trivial' change, requiring a bit of probing how I'd like to approach this.
May take some time.


Task composer install and npm build in runner

Hello,
I would like to know if it's possible to.build assets and vendor only on ci and not directly on Host ?

Will update docs.

Will update docs.

Hello, in this repository ? :)

On website.

On website.

Thanks,
Can you give me a link to the documentation for this feature please?

I still didn’t find the time to do it. Probably in some future.
Donations are good motivation to for on a specific project. ;)

I still didn’t find the time to do it. Probably in some future.
Donations are good motivation to for on a specific project. ;)

Ohw ok, can u explain me how to do it maybe ?
I can create a PR after and donate if u want, i just really need to know how can i do that =)
Thanks by advance

Ohw ok, can u explain me how to do it maybe ?

Well, use custom tasks =))


update config file message to be more indicative

It is possible that the config file path can be overridden by providing the CF_CONFIG_FILE variable. Because of this, we shouldn't hardcode the path in the error message.
I opted instead to check the error in Granted, in https://github.com/common-fate/granted/pull/672:
if err == config.ErrConfigFileNotFound {
			clio.Errorf("The Common Fate config file (~/.cf/config by default) was not found. To fix this, run 'granted auth configure https://commonfate.example.com' (replacing the URL in the command with your Common Fate deployment URL")
		}

I will close this PR as this change shouldn't be required when err == config.ErrConfigFileNotFound is being used, as is implemented in Granted


Pod Development Issue

When moving to Pod Developement through Podfile as explained here https://github.com/jgh-/VideoCore/pull/128
#pod 'VideoCore', '~>0.1.12'
pod 'VideoCore', path: '../..'

with libraries:
Installing VideoCore 0.3.1 (was 0.1.12)
Using boost (1.51.0)
Using glm (<IP_ADDRESS>)

and session init VCSimpleSession code
CGSize frameSize = CGSizeMake(480, 480);
_session = [[VCSimpleSession alloc] initWithVideoSize:frameSize frameRate:30 bitrate:1000000 useInterfaceOrientation:NO cameraState:VCCameraStateBack aspectMode:VCAscpectModeFill];
instead of having the normal RTMP session:

2015-04-17 18:53:18.330 SampleBroadcaster[8870:1085628] Creating context
2015-04-17 18:53:18.533 SampleBroadcaster[8870:1085628] Context creation succeeded
ClientState: 1
ClientState: 2
ClientState: 3
ClientState: 4
ClientState: 5
ClientState: 6
received server window size: 2500000
received peer bandwidth limit: 2500000 type: 2
Request to change incoming chunk size from 128 -> 1024
Received invoke
pktId: 1
received invoke _result
tracked command: connect
ClientState: 7
Received invoke
pktId: 0
received invoke onBWDone
Received invoke
pktId: 2
received invoke _result
tracked command: releaseStream
Received invoke
pktId: 3
received invoke _result
tracked command: FCPublish
Received invoke
pktId: 4
received invoke _result
tracked command: createStream
ClientState: 8
Received invoke
pktId: 0
received invoke onStatus
code : NetStream.Publish.Start
ClientState: 9

I get the context but something happens
2015-04-17 18:55:43.070 SampleBroadcaster[8885:1086861] Creating context
2015-04-17 18:55:43.125 SampleBroadcaster[8885:1086861] Context creation succeeded
Apple::AudioMixerplayPath: 87d735a5d74049b88b6f5aa997ae4d2a/myStream, app: liveClientState: 1
ClientState: 2
ClientState: 3
ClientState: 4
ClientState: 5
ClientState: 6
ClientState: 11
~RTMPSession

Did this work previously?  What server are you using?

Not sure if it working before, since I did this for the merged pull request https://github.com/jgh-/VideoCore/pull/128
I'm using Microsoft Azure Streaming Server.

Same here... any update on this?
regards

Hi If this problem update????????
I have the same issue


chore: remove obsolete core module

Summary of Changes
Removes the obsolete Core module which had one file left from before (ABIElements.swift).
Note ⚠ that there was a large difference between this file ABIElements and the ABIElements now present in Web3Core/EthereumABI. Just checked the one in Core seemed to have been last changed mid November (https://github.com/web3swift-team/web3swift/commits/develop/Sources/Core/EthereumABI/ABIElements.swift) while the one in Web3Core beg/mid December.
By submitting this pull request, you are confirming the following:

I have reviewed the Contribution Guidelines.
I have performed a self-review of my own code.
I have updated my repository to match the develop branch.
I have included test data or screenshots that prove my fix is effective or that my feature works.
I have checked that all tests work and swiftlint is not throwing any errors/warnings.

@janndriessen Some kind of conflict with deleted ABIElements.swift is present.


Doc Fixes

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bonclay7 Please approve this.


Use in non-TypeScript global apps

Hi Bryce, thank you so much for creating these TypeScript definitions! I commend you for being the brave soul who is apparently venturing into using TypeScript for writing ServiceNow code. A while back I ventured down that path myself, but things weren't as mature with TypeScript as they are now and I returned to coding JavaScript.
When I have some time, I plan to take a look at your skeleton project and perhaps I'll try TypeScript again for SN development.
For now though, I enjoy the autocomplete and interface documentation these definitions provide within my IDE. Before stumbling onto this project, I used Glide system class stubs to provide autocomplete.
I will definitely be contributing to this project as I have time. (Assuming you're taking contributions :smile:).
The reason I'm opening this issue is to clarify usage of these typings in a non-TypeScript project (i.e., for IDE JS support) in a global app context:
Question 1:
Your README shows for Scoped Apps use:

typings install servicenow=github:bryceg/servicenow-dts/server/scoped-VERSION/index.d.ts#v1.7 --global

I assume for Global apps it should be:

typings install servicenow=github:bryceg/servicenow-dts/server/global/index.d.ts#v1.7 --global

Correct?
Question 2:
Under  Global and Scoped Apps you indicate to use the rhino-es3 typings. And to use "noLib" in tsconfig.
I'm guessing this is only if you're writing TypeScript and not just using the typings for JavaScript IDE support.
Correct?
If I was doing TypeScript development, could you explain why this configuration is needed?
Perhaps you could update the README to clarify things?
Thanks again,
John

Glad this is useful for you.  Its been quite a challenge to maintain these with ServiceNow very lax documentation practices around their API's, especially between release versions.
Correct on both questions.  I probably need to clarify number 2 for only applying to the Helsinki scoped app release, where you are targeting ES5 with your application.  If so then you can use the standard lib and not the rhino version I cooked up for ES3, as the Rhino version they are using is quite old and not really ES3 compliant.
We use typescript exclusively for app development towards ServiceNow, but its bit of an ugly integration due to their push towards the Studio.  But on large apps, not using typescript can make maintainability almost impossible.


TabNavigator not working when setting to RTL on iOS

<EMAIL_ADDRESS><EMAIL_ADDRESS>If I enable RTL on iOS, which you need to do to two things:

Call [[RCTI18nUtil sharedInstance] allowRTL:true]; inside the appDelegate.

Add an RTL language to the Xcode project (in my case Hebrew).

The result is that the TabNavigator shows only the content of the first tab. All the other tabs are blank:

When working in regular mode (non-RTL) everything is fine:

The code:
import React from 'react';
import {
    AppRegistry,
    View,
    Text,
} from 'react-native';
import { TabNavigator } from 'react-navigation';

class ScreenA extends React.Component {
    render() {
        return <Text style={{marginTop:50}}>ScreenA</Text>
    }
}

class ScreenB extends React.Component {
    render() {
        return <Text style={{marginTop:50}}>ScreenB</Text>
    }
}

class ScreenC extends React.Component {
    render() {
        return <Text style={{marginTop:50}}>ScreenC</Text>;
    }
}

const MainScreenNavigator = TabNavigator(
    {
        ScreenA: { screen: ScreenA },
        ScreenB: { screen: ScreenB },
        ScreenC: { screen: ScreenC }
    }
);

AppRegistry.registerComponent('myapp', () => MainScreenNavigator);

If It's any help, I know there is an open issue about ScrollView + RTL. Maybe it is related?
(the temp fix is flexDirection:'row-reverse')

Can you send a PR to https://github.com/satya164/react-native-tab-view to add it? Should be pretty straightforward.

Ok, I will open a new issue there, linking to this one.

Hi! Since this issue has been quiet for a while I'm going to go ahead and close it. If the issue persists in the latest version of React Navigation please re-open!

I'm facing with this problem today. As a quick solution I set swipeEnabled: true for TabNavigator:
TabNavigator({...someRoutes}, { swipeEnabled: true }).
Hope this helps someone.

@ablagodaryov It fixed it, however it took me to another issue with DrawerNavigator, now the drawer wouldn't show up when swipeEnabled: true

Still experiencing this behavior in react-navigation 1.5.11.
I have to use swipeEnabled: false as some of my screens have charts on them, that are scrolled horizontally, so I can not enable swipe.
In iOS RTL regime screens appear empty

@spencercarli @satya164 - a PR on react-native-community is waiting to be merged. After its release, react-navigation should include it in the next version


HasChildQuery inner_hits

Hi
If I understand well, I could add a inner_hits on a HasChildQuery

Inner hits can be used by defining an inner_hits definition on a nested, has_child or has_parent query and filter.

https://www.elastic.co/guide/en/elasticsearch/reference/current/inner-hits.html
But I don't understand how to do.
let q = Query::has_child(
        "tag",
        Query::bool()
            .filter([Query::term("a", "b")])
            .filter(Query::terms("def", ["g", "h"])),
    );

Is it missing or I do a mistake ?

I think you should be able to, at least looking at the documentation. I'll fix this by the end of the week. Thanks!

Closing, will release sometime soon.


post.js example is outdated

Which version of PhantomJS are you using? Tip: run phantomjs --version.

2.1.1

What steps will reproduce the problem?

To reproduce:

Run phantomjs on phantomjs/examples/post.js

Expected result: a valid response. Actual response: 404 not found

Which operating system are you using?

OS X

Did you use binary PhantomJS or did you compile it from source?

Installed via homebrew

Please provide any additional information below.

Running it via postman also didn't work. My suspicion is that posttestserver.com itself has changed, and that the previously valid example no longer works.

PTS has indeed moved. Check the message at http://posttestserver.com/
Try their new site or use their old server which receives POST requests on http://posttestserver.com/pts.php.
As far as the code in the example. If you change the url, then the rest of the code looks fine and should work.


Convert to multi-module maven project

I think this project would benefit from pulling all extensions (like the spring integration) into into the github.com/decebals/pf4j source tree and beeing converted into a multi module maven project.
I am trying out the framework currently and the first thing I did was to add a property to my pom (like this: <pf4j.version>...</pf4j.version>). Now since this will be a spring boot project, I also want the spring extension.
Is this the same version? If not: which version of the spring extension do I need for which pf4j version?
These question would simply not come up if you would convert the project. I could always be sure that (ideally) everything works just fine for a given version.
What do you think?

I think this project would benefit from pulling all extensions (like the spring integration) into into the github.com/decebals/pf4j source tree and beeing converted into a multi module maven project.

I don't know what to say. Each variant has advantages and disadvantages. For example, pf4j-spring is a project that is rarely changed an for this reason I prefer to use a separate repository.
We will see in the featur, after some investigation if it's a good idea to move pf4j-spring in pf4j repository as a new module.

I am trying out the framework currently and the first thing I did was to add a property to my pom (like this: <pf4j.version>...</pf4j.version>). Now since this will be a spring boot project, I also want the spring extension.

In your situation I would go with:

define pf4j.version property in pom.xml (the value is the last pf4j available version)
add pf4j-spring as dependency (the last pf4j-spring available version)
add spring/spring-boot with what version you want

Pf4j-spring does not use too much classes from spring, so I think that you don't have a problem with the "embedded" Spring version.
If Maven is in trouble, then you must exclude spring from the pf4j-spring dependency.


feat(cves): Remove ignored CVEs

Applicable spec: ISD-084
Overview
Removes outdated ignored CVEs in the .trivyignore file
Rationale
Entries in the .trivyignore can get stale, this step ensures fixed/resolved CVEs are removed
Juju Events Changes
n/a
Module Changes
n/a
Library Changes
n/a
Checklist

[x ] The charm style guide was applied
[x ] The contributing guide was applied
[x ] The changes are compliant with ISD054 - Managing Charm Complexity
[x ] The documentation is generated using src-docs
[x ] The documentation for charmhub is updated.
[x ] The PR is tagged with appropriate label (urgent, trivial, complex)

Note I tested this locally and wanted to test outside of the org, though I can't seem to get the permissions required, hence I'm opening this for testing (that's why it points to a feature branch on operator-workflows and has a cron entry that runs repeatedly within the hour).


Remove default padding from ECDSA signatures

Continuing from #621, make non padded ECDSA signatures the default. The --pad-sig flag is added to imgtool to be able to make images for old versions of MCUboot.

@d3zd3z Needs rebase!


asm ignores mates

Fix: wait until bioconda pulls <IP_ADDRESS> then merge updated gatk asm recipe with no-ignore on by default
watching: https://github.com/bioconda/bioconda-recipes/pull/44810

<IP_ADDRESS> added


Parent label

FIX for a bug  in parent_label(o):
When argument is a string, parent_label() returned a filename–last part after split, not a parent folder.
AssertionError: ==:
9932.png
3

A duplicate of PR #174, so will be closed.


PinEntryEditText line colour change using java

Hey how can i change PinEntryEditText line colour using java?? Is there any method available for it

There should be setPinLineColors() and setPinBackground() methods in version 2.0.6 releasing soon.
setPinLineColors() will take a color state list.
setPinBackground() will take a drawable xml selector.


Need sample example to assign policy definition on different management groups where policies definitions stored on tenant root level

Hi Team,
I have deployed enterprise scale custom policies definitions using bicep template via Azure DevOps pipeline on tenant root level.
Now all my custom policies definition location is tenant root level.
I want to assign this custom policies to different management group in my tenant. How can I achieve this ??
Any sample example only for assigning custom and built-in policies to management group level using bicep template.
FYI I am using Azure DevOps pipeline where I am compiling bicep file to json and deploying that using Azure DevOps ARM task using parameters file.

run a pwsh cmdlet to get policyDefinitionId from your topLevel management group
Get-AzPolicyDefinition -ManagementGroupName myTopLevelScope -custom | select PolicyDefinitionId
once you have an Id, just provide value in policyAssigment

@azMantas : what will the scope value to get the policy deploy in different management group. I am getting below error while deploying bicep file
"error": {
"code": "InvalidCreatePolicyAssignmentRequest",
"message": "The policy assignment 'Deny-RDP' create request is invalid. Policy assignment scope '/providers/Microsoft.Management/managementGroups/mg-landingzones' must match the scope specified on the Uri '/providers/Microsoft.Management/managementGroups/'."
}
}
2021-09-14T11:22:14.5226531Z ##[error]BadRequest: {
"error": {
"code": "InvalidCreatePolicyAssignmentRequest",
"message": "The policy assignment 'KV-enabled' create request is invalid. Policy assignment scope '/providers/Microsoft.Management/managementGroups/mg-landingzones' must match the scope specified on the Uri '/providers/Microsoft.Management/managementGroups/'."
}
}
main.bicep
targetScope = 'managementGroup'
param targetMG string
param policies array
var mgScope = tenantResourceId('Microsoft.Management/managementGroups', targetMG)
resource policyAssignment 'Microsoft.Authorization/policyAssignments@2020-03-01' = [for policy in policies: {
name: policy.name
properties: {
scope: mgScope
policyDefinitionId: policy.policyDefinitionId
enforcementMode: 'Default'
}
}]

Parameters.json
{
"$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentParameters.json#",
"contentVersion": "<IP_ADDRESS>",
"parameters": {
"targetMG": {
"value": "mg-landingzones"
},
"policies": {
"value": [
{
"name": "Deny-RDP",
"policyDefinitionId": "/providers/Microsoft.Authorization/policyDefinitions/1e66c121-a66a-4b1f-9b83-0fd99bf0fc2d"
},
{
"name": "KV-enabled",
"policyDefinitionId": "/providers/Microsoft.Authorization/policyDefinitions/e372f825-a257-4fb8-9175-797a8a8627d6"
}
]
}
}
}

If you update your mgScope variable to look like this it should work for you:
var mgScope = '/providers/Microsoft.Management/managementGroups/${targetMG}'

@StefanIvemo : I am also thinking ahead about my use case I want to apply different policies on different management groups tenant for enterprise scale. How can I achieve it using single bicep template and parameter file??
For example enterprise scale management group
mg-connectivity -- 10 policies
mg- landingzone -- 8 policies
mg - platform -- 12 polices
mg- corp - 5 policies
mg- online - 4 policies

You need to use modules to be able to do that. Here's an example on how this can be achieved.
Use the bicep file you already have and save it as something like policyAssignment.bicep
targetScope = 'managementGroup'

param targetMG string
param policies array

var mgScope = '/providers/Microsoft.Management/managementGroups/${targetMG}'

resource policyAssignment 'Microsoft.Authorization/policyAssignments@2020-03-01' = [for policy in policies: {
  name: policy.name
  properties: {
    scope: mgScope
    policyDefinitionId: policy.policyDefinitionId
    enforcementMode: 'Default'
  }
}]

You can then create a main template where you loop over the policy assignment module to assign policies for one management group at the time. Please note that for this template to work you need to make sure that the input to the assignments array parameter is in the correct format (see example below).
targetScope = 'managementGroup'

param assignments array

module policyAssignments 'policyAssignment.bicep' = [for assignment in assignments: {
  name: '${assignment.targetMG}-deploy'
  scope: managementGroup(assignment.targetMG)
  params: {
    targetMG: assignment.targetMG
    policies: assignment.policies
  }
}]

Here's an example parameter file that works with the example above. Since the main.bicep templates expects one array parameter I've created one object per management group with the target management group name and all policies to apply for that MG.
{
    "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentParameters.json#",
    "contentVersion": "<IP_ADDRESS>",
    "parameters": {
        "assignments": {
            "value": [
                {
                    "targetMG": "sandbox",
                    "policies": [
                        {
                            "name": "some-policy",
                            "policyDefinitionId": "/providers/Microsoft.Management/managementGroups/eslz/providers/Microsoft.Authorization/policyDefinitions/...."
                        }
                    ]
                },
                {
                    "targetMG": "landingzones",
                    "policies": [
                        {
                            "name": "another-policy",
                            "policyDefinitionId": "/providers/Microsoft.Management/managementGroups/eslz/providers/Microsoft.Authorization/policyDefinitions/...."
                        }
                    ]
                }
            ]
        }
    }
}

Deploy the template to your root management group in your Enterprise-Scale hierarchy tree(not the tenant root group).

@StefanIvemo : Thanks a lot for such detailed explanation and examples.

@stefanlvemo : one last question on above parameters file and in bicep file how can I pass the policy parameters. As some policies requires parameters while deployment.


Thanos Query: Additional telemetry buckets

This commit adds additional telemetryDurationQuantiles, to ensure we have buckets for complicated queries that takes a long time to complete. It uses the default values, as defined upstream in Thanos, and adds 15, 30, 60 and 120. 120 is chosen as the upper bound as that is the timeout set in the Observatorium API.

@jacobbaungard looks good to me but I don't see any additional changes via kube-thanos? Did they already go out in #468

Exactly, I rebased after that. Forgot to update the PR description (done now), had just done the commit msg.

So many flags! see_no_evil
I wonder if we can modify this in Thanos to just take comma-separated values instead. Might be breaking convention tho

Yes, it's not great. I already took a brief look at this and couldn't see a way to do it with Kingpin, so we'll probably have to do parsing manually if we'd want to get rid of this pattern (unless I missed something in Kingpin, the docs are not exactly exhaustive)


Force mode array to be a list

BBHx requires the mode-array to be a list of lists, and bilby_pipe passes it as a tuple of lists. This therefore causes errors when trying to generate a waveform with a specific set of multipoles. This MR forces mode-array to be a list of lists if a tuple is provided.

This is ready to be merged.


Print all CRD as YAML on test failure

This code will dump out all build-pipeline CRDs when a test fails to
make debugging easier.
Currently purposely makes the PipelineRun test fail.
Fixes #145.

if the test is purposely failing, we would not be able to merge the PR

A sample of the output in case of a failing test can be found here: https://gubernator.knative.dev/build/knative-prow/pr-logs/pull/knative_build-pipeline/182/pull-knative-build-pipeline-integration-tests/1055088374320205825/
we will eventually have to make the test pass to be able to merge

@pivotal-nader-ziada the purpose of making the test fail was to showcase the output and get feedback on it. If there is no additional output desired, I can update the other existing steps and fix the test to make the PR mergeable.

I like the output now without the logs, the CRDs will be helpful in debugging

I'm not sure why https://gubernator.knative.dev/build/knative-prow/pr-logs/pull/knative_build-pipeline/182/pull-knative-build-pipeline-integration-tests/1056783921334718466/ failed, it looks related to the test environment?

/lgtm

/approve


fix(MediaCodec): get right width and height

Codecov Report

Merging #60 into develop will increase coverage by 0.53%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop      #60      +/-   ##
===========================================
+ Coverage    71.79%   72.33%   +0.53%
===========================================
  Files          200      200
  Lines        10563    10563
===========================================
+ Hits          7584     7641      +57
+ Misses        2979     2922      -57

Impacted Files
Coverage Δ

mediaPlayer/system_refer_clock.cpp
91.66% <0%> (-4.17%)
:arrow_down:

mediaPlayer/player_notifier.cpp
81.31% <0%> (-0.55%)
:arrow_down:

framework/codec/ActiveDecoder.cpp
86.38% <0%> (-0.53%)
:arrow_down:

framework/demuxer/play_list/HLSStream.cpp
71.05% <0%> (+0.16%)
:arrow_up:

mediaPlayer/SuperMediaPlayer.cpp
76.9% <0%> (+0.19%)
:arrow_up:

framework/render/audio/filterAudioRender.cpp
88.96% <0%> (+0.68%)
:arrow_up:

framework/demuxer/avFormatDemuxer.cpp
81.9% <0%> (+1.26%)
:arrow_up:

framework/data_source/curl/curl_data_source.cpp
72.88% <0%> (+1.31%)
:arrow_up:

mediaPlayer/analytics/AnalyticsCollectorImpl.cpp
32.2% <0%> (+2.54%)
:arrow_up:

mediaPlayer/buffer_controller.cpp
61.01% <0%> (+5.93%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cce5cd0...b2804ab. Read the comment docs.


Update main.rs

Thank you very much for the exercises they are really nice.
Just a small suggestion as I arrived to the same result but with a different solution.

Thanks so much, appreciate the contribution.
I've added a comment to the regular main.rs as well as the solution one. Should now be good to merge once checks pass.


Generated frags.gql missing body

Description
I honestly haven't dug into this error much yet, so I haven't figured out the actual cause, but I'm getting this error on my personal site.
Steps to reproduce

Check out PR for my personal site here
nvm use 14 && npm ci && npx tinacms build
See error

Expected result
Builds correctly.
Actual result
  Syntax Error: Expected "{", found "}".

~/frontend/.tina/__generated__/frags.gql:483:19
482 |                     ... on PageLandingBodyResumeEmbed
483 |                   }
    |                   ^
484 |                 }
GraphQLError: Syntax Error: Expected "{", found "}".
    at syntaxError (~/frontend/node_modules/graphql/error/syntaxError.js:15:10)
    at Parser.expectToken (~/frontend/node_modules/graphql/language/parser.js:1413:40)
    at Parser.many (~/frontend/node_modules/graphql/language/parser.js:1519:10)
    at Parser.parseSelectionSet (~/frontend/node_modules/graphql/language/parser.js:271:24)
    at Parser.parseFragment (~/frontend/node_modules/graphql/language/parser.js:379:26)
    at Parser.parseSelection (~/frontend/node_modules/graphql/language/parser.js:284:58)
    at Parser.many (~/frontend/node_modules/graphql/language/parser.js:1523:26)
    at Parser.parseSelectionSet (~/frontend/node_modules/graphql/language/parser.js:271:24)
    at Parser.parseField (~/frontend/node_modules/graphql/language/parser.js:312:68)
    at Parser.parseSelection (~/frontend/node_modules/graphql/language/parser.js:284:81)

Looks like the frags.gql doesn't build correctly.
Environment
Tinacms Package Versions

├─┬<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ │ ├─┬<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ │ ├─┬<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ │ ├──<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>│ ├──<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>

Tools

Tool
Version

browser

os
OSX

node
14.17.6

npm
6.14.15

Sharing here for posterity: The PageLandingBodyResumeEmbed is a template with a single reference field, so it shouldn't generate an empty body. Here's the definition:
const resumeEmbedTemplate = {
  name: 'resumeEmbed',
  label: 'Resume Embed',
  fields: [
    {
      type: 'reference',
      name: 'resume',
      collections: ['resume'],
    },
  ],
};

In your schema, menu and page collections have each other as a reference. So while generating graphql fragment, they resolve each other recursively.
To prevent this, tinacms has a option called maxDepth(which is 2 as default) and stops resolving reference if depth is greater than maxDepth.
https://github.com/tinacms/tinacms/blob/main/packages/%40tinacms/graphql/src/builder/index.ts#L565-L567
resumeEmbedTemplate, in your page collection, has resume as a reference. So when resolving PageLandingBodyResumeEmbed, if maxDepth >= 2, this template body will be empty and it will cause the missing body issue.

Ah, that makes sense, thank you! So I think I would just need a combo of that PR & update of the referenceDepth to make sure it returns what I need. Or reconsider my schema to eliminate the circular reference.


Port 53 conflicts with mDNSResponder on macOS

OS: macOS High Sierra 10.13.4
dnscrypt-proxy: 2.0.13
dnscrypt-proxy can't start because <IP_ADDRESS>:53 is already in use
$ sudo /usr/local/opt/dnscrypt-proxy/sbin/dnscrypt-proxy -config /usr/local/etc/dnscrypt-proxy.toml
[2018-05-18 15:38:09] [NOTICE] Network not available yet -- waiting...
[2018-05-18 15:38:39] [ERROR] Timeout while waiting for network connectivity
[2018-05-18 15:38:39] [NOTICE] Source [public-resolvers.md] loaded
[2018-05-18 15:38:39] [NOTICE] dnscrypt-proxy 2.0.13
[2018-05-18 15:38:39] [FATAL] listen udp <IP_ADDRESS>:53: bind: address already in use

Looks like mDNSResponder is already bounded to port 53
$ sudo lsof -nP -i4TCP:53
COMMAND   PID           USER   FD   TYPE             DEVICE SIZE/OFF NODE NAME
mDNSRespo 225 _mdnsresponder   83u  IPv4 0x363953d7b8bbf8f3      0t0  TCP *:53 (LISTEN)

$ ps auxw | grep mdns
_mdnsresponder     225   0.0  0.0  4379940   3544   ??  Ss    1May18   8:33.43 /usr/sbin/mDNSResponder -StrictUnicastOrdering

Disabling mDNSResponder frees up port 53 and allows dnscrypt-proxy to start properly
sudo launchctl unload /System/Library/LaunchDaemons/com.apple.mDNSResponder.plist
sudo launchctl unload /System/Library/LaunchDaemons/com.apple.mDNSResponderHelper.plist

$ sudo /usr/local/opt/dnscrypt-proxy/sbin/dnscrypt-proxy -config /usr/local/etc/dnscrypt-proxy.toml
[2018-05-18 16:51:13] [NOTICE] Network not available yet -- waiting...
[2018-05-18 16:51:43] [ERROR] Timeout while waiting for network connectivity
[2018-05-18 16:51:43] [NOTICE] Source [public-resolvers.md] loaded
[2018-05-18 16:51:43] [NOTICE] dnscrypt-proxy 2.0.13
[2018-05-18 16:51:43] [NOTICE] Now listening to <IP_ADDRESS>:53 [UDP]
[2018-05-18 16:51:43] [NOTICE] Now listening to <IP_ADDRESS>:53 [TCP]
[2018-05-18 16:51:43] [NOTICE] Now listening to [::1]:53 [UDP]
[2018-05-18 16:51:43] [NOTICE] Now listening to [::1]:53 [TCP]
[2018-05-18 16:51:43] [NOTICE] Now listening to <IP_ADDRESS>:53 [UDP]
[2018-05-18 16:51:43] [NOTICE] Now listening to <IP_ADDRESS>:53 [TCP]
[2018-05-18 16:51:44] [NOTICE] [cloudflare] OK (DoH) - rtt: 20ms
[2018-05-18 16:51:44] [NOTICE] [cloudflare-ipv6] OK (DoH) - rtt: 21ms
[2018-05-18 16:51:44] [NOTICE] [google] OK (DoH) - rtt: 20ms
[2018-05-18 16:51:44] [NOTICE] Server with the lowest initial latency: cloudflare (rtt: 20ms)
[2018-05-18 16:51:44] [NOTICE] dnscrypt-proxy is ready - live servers: 3

But disabling mDNSResponder causes some app to stop resolving DNS (ex. App Store couldn't detect internet connection). Disabling it might not be a good idea according to https://superuser.com/questions/1150494/mdnsresponder-on-macos-sierra-malware
Is there any way to have both mDNSResponder and dnscrypt-proxy running at the same time?

https://github.com/alterstep/dnscrypt-osxclient/issues/109#issuecomment-253799744

I allowed mDNSResponder via LS to allow connection only to <IP_ADDRESS> and all is fine.

@gcpmusic Could you provide an example on how to do that? (not sure what LS is)

Little Snitch is a mac firewall app.
Block all mDNSResponder connections with Little Snitch and allow only DNSCrypt in and out + the server set in DNSCrypt-proxy.toml
eg: <IP_ADDRESS> if you use cloudflare

Interesting I don't have this issue.
The way I heave it setup its that I first changed my network settings:

Than I started dnscrypt-proxy on port 53.
[2018-05-23 10:25:09] [NOTICE] Stopped.
[2018-05-23 10:25:09] [NOTICE] dnscrypt-proxy 2.0.14
[2018-05-23 10:25:09] [NOTICE] Now listening to <IP_ADDRESS>:53 [UDP]
[2018-05-23 10:25:09] [NOTICE] Now listening to <IP_ADDRESS>:53 [TCP]
[2018-05-23 10:25:09] [NOTICE] [seby] OK (crypto v1) - rtt: 28ms
[2018-05-23 10:25:09] [INFO] [seby-doh-gc] TLS version: 303 - Protocol: h2 - Cipher suite: 49200
[2018-05-23 10:25:09] [NOTICE] [seby-doh-gc] OK (DoH) - rtt: 29ms
[2018-05-23 10:25:09] [NOTICE] [seby-gc] OK (crypto v2) - rtt: 29ms
[2018-05-23 10:25:09] [NOTICE] Server with the lowest initial latency: seby (rtt: 28ms)
[2018-05-23 10:25:09] [NOTICE] dnscrypt-proxy is ready - live servers: 3

Weird... I can start dnscrypt-proxy now. I see mDNSResponder isn't holding port 53 anymore. Not sure what happened. I also installed via brew.
I remember reading somewhere that having Docker daemon running might make mDNSResponder listen on 53. I'll have to do more testing.