Function to create a S7.Net.Types.DataItem from string

Hi
As reading for multiple items can easy bee done with method  ReadMultipleVars which accepts a List<S7.Net.Types.DataItem> , a function to create a S7.Net.Types.DataItem from a string would be nice.
Eventualy a constructor with string as input could be added. A SetValue which convertes into the used datatype would also help a lot. A new function to Write( S7.Net.Types.DataItem value) would also be nice.
Jürgen

The Write function is already there, it takes params DataItem[] dataItems as argument, meaning you can pass in one, multiple or an array of DataItems.
I'll take a look at adding the string addressing support, all the logic is already there.

Hi @mycroes
Thanks, I was blind ;-) Didn't see it.  Does it also have the 20 Items / 222 byte length problem like the
ReadMultipleVars method?
Jürgen

Hi @mycroes
Ok. I'll do the same with the ReadMultipleVars : I sort the list and split it in several jobs.
Jürgen.
By the way : what is about strings or byte arrays? We use strings in our plc's (barcode from scanners)
I didn't see a way to read it when I use the Read(string) method.  There is no way to decode the string as an Array of sth. nor as an string.
eg:
DB100.DBB2[10] -> Array of 10 bytes, starting at byte 2
For strings the syntax could be like this:
DB100.DBS2[10] -> string with 10 chars starting at byte 2
DB100.DBB2[10]:STRING -> string with 10 chars starting at byte 2
DB100.DBB2[10]:STRINGEX -> string with 10 chars starting at byte 4 with Byte 2 and 3 are the length information: Byte 2: Maxmimum length, byte 3 used length.

Actually I have used something like this snippet some time ago. It is not well teste though.

@bauerju @rapha-dev See Types/StringEx.
Also, try to keep issues clean, if further discussion is warranted move it to a new issue so every issue contains a single problem and can be closed by a single fix.

Hi @mycroes @rapha-dev
Thanks for your help. I'll open a new issue next time.
Thank you.
Jürgen

Hi @mycroes
I tested your added function from commit ecf2052e61a40ce83bda8b92b816f14de9d250b9.
Looks great. Thank you very much. Good Work.
But it lacks the support of arrays and setting other vartypes.
I can create a byte, word, doubleword from string but can't create an int, real (single),  string nor stringEX.
If you could add this in PlcAdress, this would also help when someone Reads or Writes from string definition.
Jürgen

Hit @mycroes
May bee I tell you first for what I need this library at my work:
I wrote a flexible windows service which first connects to a database to read all customizing like plc address and used plc tags. after initialization of the plc connections every tags gets and speaking name (DB3100.DBX0.1 is eg LiveBit ). Some of them get polled (this is controlled in the customizing). Ever change triggers a sequence handler which can start a sequence customized in database. In every sequence I can read  or write tags, call database procedures and write the result of the procedure to the plc or as a byte stream to other ip adresses (eg: printers). The service has also a built in web server using Nancy, which can call database procedures, show websites, read the logging, read and write the customized plc tags. I use this service for data exchange between plc, database, label printers and for user display and interaction.
The actual plc connection uses OPC UA, which works fine, but it is a litte bit slowly with the on board
UA Servers of the S7 1500. The S7 1500 (here a CPU 1507S) has also a disadvantage in the actual release: If you connect with TIA portal and change the code on the fly, the OPC UA Server stops and restarts after several seconds. So the service looses connection for aproximate 7 seconds. But some times the OPC UA server itself fails to start correct and I lose the connection to the projected tags of the plc. Here helps only a power off. The german AEG prinzip (Ausschalten , Einschalten, Geht) in english: power off, power on, works.
So I looked for a possibility to wide the range of the service and talk directly to the plc. Including the advantage of

talk to plc's without built in OPC UA Servers (like the  S7 300)
get rid of the annoying OPC UA Server restart bug
availability of the source and the possibility to change it myself if there is a bug

S7NetPlus perfectly fits my needs.
In the customizing of the tag I need to fully declare thy type of the tag value.
eg: bit, byte, int, word, dint, dword, real, string or stringex. And for a string/stringex the length.
If I don't do this, a database failure, which send a to long string, could break the DB of the plc and overwrite values.
Jürgen

Hi @bauerju
I'm in a similar situation regarding data reading (by the way, can't you subscribe to changes with the builtin OPC UA? It's an optional protocol feature, I just don't know if Siemens implemented it). I have a Register entity with the following fields: Address (string), Type (string), Length (int). The type is converted to .NET System.Type (using Type.GetType(register.Type).
I originally used this approach in combination with Siemens SAPI-S7 and only recently added support for S7NetPlus and my own library Sally7. We also read enum values (quite often they're the most important values even), which can be done that way as well (although Sally7 even supports them out of the box). I actually still use the addressing from SAPI-S7 because that allows us to use Sally7 in existing projects. Unfortunately without changes in my infrastructure that now means I parse addresses with a regular expression for every variable read or written, but even then it's blazing fast.

Hi @mycroes
I use the "dataFEED OPC UA .NET Server & Client SDK for Windows" from Softing. I receive change events. But I can't say If they were created from the plc or from the client itself. I think it has an fallback mode...
I also have a conversion layer where I use a dictionary with connection information: which plc is used how to talk with it, tag address, tag type and value conversion.
Today I read my tag definition, extract the type and length and create a dataItem which is afterwards modified in Vartype and Count:
It is called eg

DB1.DBB1 -> 1 byte
DB1.DBB1[20] -> 20 bytes
DB1.DBB1[20].StringEX -> 22 bytes!, string length 20 chars
DB1.DBD1:Real -> 4 Bytes as Real (Single)

In my opinion this should be better done in S7NetPlus than in my layer. Other could profit here.
But this is your choice. I can only give you my ideas.
    private void CreateDataItemFromString(string variable)
    {

        string replacedType = "";
        if (variable.Contains(":"))
        {
            var splitted = variable.Split(':');
            replacedType = splitted[1].ToLowerInvariant().Trim();
            variable = splitted[0];
        }

        int count = 1;
        if (variable.Contains("[") && variable.Contains("]"))
        {
            int.Parse(variable.Substring(variable.IndexOf("[") + 1, variable.IndexOf("]") - variable.IndexOf("[") - 1));
            variable = variable.Substring(0, variable.IndexOf("["));
        }

        dataItem = S7.Net.Types.DataItem.FromAddress(variable);

        if (count > 1)
        {
            dataItem.Count = count;
        }

        if (replacedType == "real" && dataItem.VarType == VarType.DWord)
        {
            dataItem.VarType = VarType.Real;
        }

        if (replacedType == "int" && dataItem.VarType == VarType.DWord)
        {
            dataItem.VarType = VarType.DInt;
        }

        if (replacedType == "int" && dataItem.VarType == VarType.Word)
        {
            dataItem.VarType = VarType.Int;
        }

        if (replacedType == "string" && dataItem.VarType == VarType.DWord)
        {
            dataItem.VarType = VarType.StringEx;
        }

}
Btw.: I don't read classes or structures. This as very good concept for fixed programs.  You declare an structure like an UDT of the plc ad you can read and write at once.
Jürgen

@bauerju the more I think about it, the more I feel this is not something that should be addressed by S7NetPlus. You're trying to use a string as object (i.e. combining multiple fields into a single container), which is usually not a best practice in programming. Also often it's way easier to maintain code if the logic is explicit, i.e. just store the VarType in a separate field so that when VarType is expanded you can use the new values without having to change your code.
Even with your model that allows dynamic forwarding of the data to different types of handlers, I assume you have constraints on the data the handler accepts. Let's take your printer example:
If you would read a real and send it to the printer, what will happen? I expect it'll throw an exception because the data type doesn't match. If that's the case, then you could've detected that error at an earlier stage by properly typing your data and you would've never even have attempted to read that data to send it to a printer.
I agree with your statement that it could be useful for other people as well, however I don't believe it should be part of S7NetPlus. You can of course create S7NetPlus.StringAddressing (or whatever pleases you) and offer it as a companion NuGet package. I'd be happy to help you out with setting up the repository for that, if you need any help with that.
We're also in the process of deciding what the future for S7NetPlus will look like. Due to the complexity in string addressing (the issues I pointed out with different types, structs, enums) I envision it will be removed entirely in the next major release. That wouldn't change the fact that anyone could just wrap it around S7NetPlus anyway, but I'm not sure if that changes your view on the usability of this feature.

Hi @mycroes
to your printer example. The tcp stream accepts only string or byte array as input, so the real would be converted to a string. But this doesn't make sense. This would not be enough information for printing. Normally I call a stored procedure in database which creates the byte array for printing. Here I can alos change the encoding of the string to byte array conversion. (some times the labelprinter need codepage 850)
Yes, String support in plc is even not easy. I can hear it every time when I talk to the plc people. They don't like it ;-) But today with all the bar code readers you need it.
I agree with you that string handling is complex. And If you plan to remove string support in S7NetPlus. Ok your decision. I must accept that and will then do my own wrapper that converts string to vartype byte. with correct length.
Jürgen

Well string handling isn't complex, we'll never remove support for that. String addressing of variables is complex due to issues mentioned in this topic.

Hi @mycroes
Then I have to apologize me. I misunderstood you. You think about removing the support for parsing the address out of the variables (DB1.DBB12).
As long as Read(DataItem[])  and Write(DataItem[]) or something equal is supported ;-) I'll be happy.
Parsing the name to create a DataItem is not a big problem. I could do this externally.
Jürgen

@bauerju So can we close this issue as far as you're concerned? My offer to help you set up a repository will still stand of course (and you could also take a look at mycroes/ReflEx for a very basic repository to get started quickly).

Hi @mycroes
Yes I'll close it. Thanks.


Example to get the robot into transport pose

Is is possible to add example to move the robot into transport pose. I have tried the joint_point_to_point_motion with the transport joint state from the manual in radians (0 -0.5599 0 -2.97 0 0 0.7854) which resulted in self_collision_avoidance_violation.

Ok, the solution is the button in Desk > Settings > System > Move to Pack Pose


Error: Multiple packages found with the same name when building DHP-mapping workspace

Dear authors,
Thanks for your nice work!
I encountered an issue while following the installation instructions for DHP-mapping. During the build process, the following error occurred:
[build] Error: There was an error while searching for available packages:

Multiple packages found with the same name "voxblox":
- DHP-mapping/voxblox/voxblox
- voxblox/voxblox
Multiple packages found with the same name "voxblox_msgs":
- DHP-mapping/voxblox/voxblox_msgs
- voxblox/voxblox_msgs
Multiple packages found with the same name "voxblox_ros":
- DHP-mapping/voxblox/voxblox_ros
- voxblox/voxblox_ros
Multiple packages found with the same name "voxblox_rviz_plugin":
- DHP-mapping/voxblox/voxblox_rviz_plugin
- voxblox/voxblox_rviz_plugin

It seems two voxblox packages exist in the workspace, one is in the src/voxblox, and another in the src/DHP-mapping/voxblox.
Should I manually remove one of the duplicate packages? If so, which one?
Or, is there a recommended fix to avoid this issue during workspace setup?
Thank you for your assistance!

Thanks for your reply!
I have attempted to compile the packages after removing the src/voxblox, but the process still fails on my end.
Could you kindly run the setup script on a fresh Ubuntu system to verify if the script is fully reproducible? If the issue persists on a clean system, that might help identify the root cause of the problem.
Additionally, I noticed a couple of minor issues in the setup instructions that could be adjusted for clarity:

There is a typo in the command: DHP_Mapping should be DHP-mapping.
The catkin init command should be executed in the DHP_ws directory, not in DHP_ws/src/DHP-mapping. Otherwise, I am unable to run the catkin build panoptic_mapping_utils command as described. As the error: [build] Error: Unable to find source space /home/ipbhk/DHP_ws/src/DHP-mapping/src

Thank you for your assistance!


Mm fixes

Fixes #562
I have updated the READMEs with the values defined in the script-files, EXCEPT for the calendar module, where titleReplace was defined as this:
titleReplace: {
    "De verjaardag van ": "",
    "'s birthday": ""
}

I don't think that makes sense, that this is the default value for it (in respect to the default defined calendar) and changed it to an empty object ({}) instead.

This will break the default behaviour for many MM users. I don't see the harm in leaving it the way it currently is.

README updates are definitely useful. I agree with MichMich on changing the titleReplace default value though.

I reverted titleReplace and added the documentation for it.

Thanks!


Crossover is a rail service

Fixes:

This rendering is intentional. service=crossover is not rendered as service track on other renderers, nor should it be.
The styling introduced in #476 does apply special styling to service=crossover, but only to disable the dash pattern, not to make the line thinner.

To clarify, service=crossover should only connect a main track to a main track. If one of the connecting tracks is a service track, that is a tagging error—even though it is functionally a crossover, the value of service=* should match the adjacent tracks.

Well, it looks a little strange for heavy rail to not all be the same line width. What's the motivation for emphasizing crossover in this way?
Perhaps adding line-cap: round would smooth it a little bit.

Got it, so it should always — in principle — be between two parallel non-service rails that extend in both directions.

I introduced a lot of these tagging errors myself a couple years ago. I went through and undid hundreds of them last week, but I didn't change anything that had been edited by someone else in the meantime. So if you come across any of these and you find me in the edit history, you know why 😬

I do see that osm-carto also renders crossover with this use case apparently in mind:


Encourage activity on inactive PRs & issues / cleanup old ones

Discussion 🗣

I'd like to propose a solution to encourage activity on PRs & issues so that they do not become stale, and also automate the closing of stale issues/PRs

Context

We have a lot of old issues and PRs in many of the AP repos that are no longer relevant.
We sometimes get PRs from contributors that get close to the finish line but ultimately become forgotten about. If we could set up a way to remind participants involved periodically, it may help.

Detailed Description

Set up a bot to comment on PRs after a few days(weeks?) of inactivity and tag the participants to encourage them to re-visit the PR
Set up a bot to auto-close stale PRs/issues. Maybe first have the bot comment a warning that the issue/PR will be closed due to inactivity in X days
We should look into how other open source projects handle this

We might be able to use Github actions for this: https://github.com/actions/stale


web clipboard handling

It's too early to consider seriously, but I'm looking into https://github.com/mvlabat/bevy_egui/issues/113 ; this PR serves to document my approach.

integrates https://github.com/rukai/cargo-run-wasm/blob/main/readme.md ; also used by winit to help with running examples easily ; could be done in a separate PR if need be.
adds a minimal example supporting clipboard, just my "playground", my plan is to make it work there, then integrate it into bevy_egui.
currently supports somewhat a copy to clipboard, not much tested yet.

Because the clipboard permissions are not implemented by all browsers, this is not an ideal...
More info: https://developer.mozilla.org/en-US/docs/Web/API/Permissions_API#browser_compatibility
On google chrome, as noted "supported on above link, I correctly got the permission request and my minimal playground for copy is working (shown in console) :tada:.
Buut having a permission request doesn't seem ideal, I feel like it's the wrong tool for the job ? I'm not sure about the exact process...
For me a past event should be handled by the browser, and forward characters to the canvas, winit, bevy, bevy_egui, egui....
I'm guessing prevent_defaults() is somehow in the way ? Any insight is welcome.

9e85a902c51eb145929e6e52119d79c57380fb94 tries to implement eframe's way of using web-sys API (following https://github.com/mvlabat/bevy_egui/issues/113#issuecomment-1537220739)

current state as of 69c447d2158cd4fbbbf3244272da0b68179d245a ; there is a weird bug causing the data pasted to be doubled, not sure why.
https://github.com/mvlabat/bevy_egui/assets/2290685/a3f29b72-6aee-416d-a840-2b6dfa41c8e2

I'm removing the "draft" mode, I think that's a fair attempt at adding that feature, I have a few weaknesses to point:

should we remove completely the fully managed local "string" clipboard ? in wasm non web my implementation would fail 💀

I guess we could make some kind of decoration API with a bevy_egui_extra adding clipboard_web features...

eframe uses another egui API to support Paste, it's probably more correct because it's from official egui ; I didn't go this route because I fear other obstacles, I'd like to get a minimal clipboard support before imporving on top of that.

After more testing, I realize LWin and RWin is not properly forwarded from winit to bevy (to bevy_egui), I hope the winit keyboard input refactoring would fix it https://github.com/rust-windowing/winit/pull/2662 but I didn't look into it.
This results in cmd-A being unusable :( ; I can re-enable ctrl-A to avoid losing functionality, but as you said that creates a difference with cut/copy.
In my opinion, as a mac user, using ctrl feels very wrong, so I'd advocate to merge this PR with a fallback to ctrl-A while waiting or working on a fix upstream.

also, prevent_default=false (which I had to do to get copy/paste events) has other implications: cmd+left arrow triggers a "previous page", which eframe suppress via a prevent_default = true in a few other specific cases too.
I created an issue to winit to follow this prevent_default behaviour: https://github.com/rust-windowing/winit/issues/2831

Any updates on this?

Any updates on this?

Blockers listed on the description are still relevant ; I'm working on https://github.com/bevyengine/bevy/pull/8745.
If you want to help, I'd appreciate feedbacks on the problem I described here: https://github.com/Vrixyz/bevy/pull/3#discussion_r1396845228

now that the winit update is merged into bevy can this go forward?

I believe so ; I'm still coordinating the follow up of winit update at  https://github.com/bevyengine/bevy/issues/11052 ; so I'm happy to let this adopted by someone else wants to ; otherwise I'll pick it up in a.. few month hopefully

My understanding has improved a bit.
My observations are base on an old version on bevy_egui, in order to be consistent with the state of this PR. this PR will need to be rebased anyway, and re-evaluated with winit changes. My intuition tells me that it should not too hard to update that PR.
What problems this PR has
bevy_egui sends physical keys to egui, which is a problem on non qwerty keyboards, especially for "azerty select-all":
I thought the reason I wasn't receiving input from cmd-a was a bug from winit, but it was a wrong observation:

as bevy_egui sends the physical keys, physical key  "A" will be sent when I hit the "Q" key, so to trigger select-all, I should do cmd-Q. but cmd-Q in mac is used to close an application. I remapped that to nothing because I don't want to hit that by mistake 😅 .
Theoretically it should work, but winit doesn't send any event when typing cmd-Q. This might be a bug from upstream or the browser, but it's very niche as the correct use case should be to input cmd-A.

I think the correct approach is to fix bevy_egui to send the logical key rather than the physical key.
The winit update follow up (https://github.com/bevyengine/bevy/issues/11052) will help with detecting the correct "Logical key" with the task list "Add more info in KeyboardInput".
Given current state of bevy_egui, I'm thinking this does not create more inconsistencies in the API than currently the case on main, that being said, at this point I'm ok with ironing out the last bits before merging :+1:
What would help greatly, for this PR and also future improvements, would be:

a list of pertinent tests to do
and better yet, automate them.

Could you move forward with #236 I'd love to have this feature when 0.13 comes out. Thanks for all the winit work!

I would love to.
I'm starting to work on it: https://github.com/Vrixyz/bevy_egui/pull/3
As mentioned in https://github.com/mvlabat/bevy_egui/pull/178#issuecomment-1890458160 ; we still have the problem of bevy_egui using physical keys rather than logical keys on bevy main.
Those problems might not actually apply to bevy 0.12, and I now believe we could have merged that PR for bevy 0.12 if tested more thoroughly, but now I'll focus on making that working for bevy 0.13.
I did a talk on that subject for the curious, which might give more context: https://www.youtube.com/live/i3wF71XJ-24?si=zfFV8xoY9JuQKmOt&t=3090

I might do a PR with a cleaned version of https://github.com/v-kat/bevy_egui/tree/wasm_mobile_keyboard it also seems to handle  some of the same copy paste functionality but I dunno if it covers everything (I'm mainly doing a hacky fix for the mobile web keyboard).

Great thanks for championing it to mergeability ! I'll let you close this PR at your will.

@v-kat please do open a PR! I've just merged this one, so you can dissect the mobile web keyboard changes from the clipboard ones.


HKG: Add FW for 2022 Kia Niro HEV

Add firmware for the 2022 Kia Niro HEV. Expand supported model-year range.
Route ID: 108ad5e92908c955|2022-02-25--16-35-27
Thanks to community Niro HEV owner Aryeh95.

Can you add a route for where it was taken from?

Can you add a route for where it was taken from?

Just added! Was waiting for the route ID before marking this as ready 🙂


Reproducing model zoo results on GQA

Hello,
I am trying to reproduce the results reported on model zoo for GQA dataset. I am doing Train+val -> Test-dev with mcan_large on GQA dataset with the following code:
python3 run.py --RUN='train' --SPLIT='train+val' --MODEL='mcan_large' --DATASET='gqa' --GPU='7' --VERSION=''default_frcn+bbox+grid
The accuracy on local evaluation is 56.23% and from GQA evaluation server is 56.57% (with in reasonable limit I guess). But the reported accuracy in model zoo for MCAN-large (frcn+bbox+grid) is 58.10%. I think this is a significant difference in accuracy. Could you please tell me if I am doing something wrong? I have used all provided features as is, and did not modify the code.

Thanks for you reply @nbgao , did you use the same seed for mcan_small?

We use SEED=1016 for mcan_small in GQA.


clientId for pdfviewer updated

ClientId updated for stage.adobe.com

Resolves: MWPW-143472
Test URLs:

Before: https://www.stage.adobe.com/creativecloud/business/teams/resources/sdk/computer-sas-industry-insights.html?martech=off
After: https://mwpw-143472--cc--sharath-kannan.hlx.page/?martech=off

The test url given above is just a placeholder as the clientid is picked based on the domain,I have tested the clientID at runtime in the browser.

Hi @sharath-kannan , to verify I tried to check the page on your feature branch https://mwpw-143472--cc--sharath-kannan.hlx.page/creativecloud/business/teams/resources/sdk/computer-sas-industry-insights but it's 404 Could you please share an after url to verify once. Thanks


Backend crashing

CastError: Cast to ObjectId failed for value "undefined" (type string) at path "_id" for model "User"
at model.Query.exec (C:\Users\safil badarudeen\Desktop\React projects\SocialMedia\socialapp\backend\node_modules\mongoose\lib\query.js:4913:21)
at Query.then (C:\Users\safil badarudeen\Desktop\React projects\SocialMedia\socialapp\backend\node_modules\mongoose\lib\query.js:5012:15)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
backend crashing error.

problem must be with any api call that bring s data to the home page

Real problem was a keyword change in backend ,
i have changed data when login , to other (data-> other) and this made to crash whole app because every data keyword in front end bcome null because user state doesnt contain any data,
fixed it .


Add AlertManager to Pushover's apps|Integrations

What did you expect to see?
Prometheus AlertManager listed as a Pushover application on Pushover's Pushover-powered Applications & Plugins
What did you see instead? Under which circumstances?
Pushover integration is not listed as an integration on Pushover's site. The integration is well-documented by AlertManager and works well.
Listing the integration on Pushover's site increases visibility of Prometheus AlertManager (integration).
This listing request needs to be submitted by someone from the Prometheus AlertManager team as validation.
I received the following from Pushover when I asked why AlertManager is not listed:

From: Pushover Support
Hi, someone from the project needs to submit a request to have the application listed with its official icon, URL, etc.
https://support.pushover.net/i36-getting-your-app-website-service-listed-on-pushover-s-public-applications-integrations-page

This page is made for SAAS. In particular, we can not guarantee to follow all the rules with alertmanager:
For externally hosted services, you must use one API token per service/application and you are responsible for purchasing additional capacity as needed. You may not register multiple API token to get around our message limits and you may not request or host API tokens registered by end-users.

 Do they have another page for self-hosted software?

I will see what I can do.

Here is the message I tried to send:

Hello,
I would like to list Prometheus as an integration with Pushover.
Our website is https://prometheus.io
The documentation is at https://prometheus.io/docs/alerting/latest/configuration/#pushover_config
We have Pushover support since 2016.
You can pick the logo you want here: https://cncf-branding.netlify.app/projects/prometheus/
The author is "The Prometheus developers".

When I clicked send, I got "The message looks like spam".

I unfortunately does not have infinite time to spend on this, so I have to close this ticket without proper resolution.

Thanks @roidelapluie for trying!
Unless you object (?), I will forward this comment thread to the Pushover team to see whether they'll resolve this for us.

@roidelapluie Sorry for the overzealous spam filter.  I've manually added a new application for you which is now listed on https://pushover.net/apps
You can direct users to your cloning URL at https://pushover.net/apps/clone/prometheus which will make it easier to register for an API token.
Thanks for the initiative @DazWilkin

Thank you @jcs and @DazWilkin! I will try the link and add it to the documentation.


[Infra] Remove typings, and use them as a dep - updates docs

Note - there are docs changes in this PR at the bottom.
Removes the typings files, we are now doing it the proper way.
To add to the typings db:
typings install dt~mocha --global --save

Which modifies the typings.json:
diff --git a/typings.json b/typings.json
index e1113fd..2a51e31 100644
--- a/typings.json
+++ b/typings.json
@@ -2,6 +2,7 @@
   "globalDependencies": {
     "jasmine": "registry:dt/jasmine#2.2.0+20160621224255",
     "lodash": "registry:dt/lodash#4.14.0+20160802150749",
+    "mocha": "registry:dt/mocha#2.2.5+20160720003353",
     "react": "registry:dt/react#0.14.0+20160805125551",
     "react-native": "registry:dt/react-native#0.29.0+20160728152643"
   }

now to get a type db, you will need to run typings install - which is documented in the VS Code setup doc.
/cc @alloy  @mennenia  @sarahscott ^ - you'll need to run this

          1 Message

:book:
Hello, world.

  Generated by :no_entry_sign: danger


Eliminate need for length property

@jhiesey says that length won't be required in the next version of videostream, so we should also just remove it from here. The only thing we need to change is to construct the blob from an array of Buffers.

Released as 2.1.0.


Enhances aad user get, Closes #4570

Notices a wrong description for the test command aad user add. Is it ok that i corrected it in this PR?
Closes #4570

Thank you @nicodecleyre, we'll try to review it ASAP.
About the aad user add test, it's not really part of this PR, but since it's such a small change, I personally can live with it.
Apart from that, great catch!

Thank you for your dedication @milanholemans 🙏. I've processed your comments

Thank you for your dedication @milanholemans 🙏. I've processed your comments

The dedication comes from both sides 😊

Merged manually. Thank you for this awesome addition! 👏


Tags provider displays incorrect line numbers in tags list

When using :FzfLua tags, the line numbers listed for each tag is always listed as 1. However, the correct line is highlighted in the preview window and pressing Enter on the tag will jump to the correct line as well.
Reproduction

First, here's the init.vim I was using:
let g:vimDir = stdpath('config')

call plug#begin(g:vimDir . '/bundle')
Plug 'ibhagwan/fzf-lua'
call plug#end()

lua << EOF
require('fzf-lua').setup{}
EOF

Create the test file test.c:
#include <stdio.h>

int main(void)
{
    printf("Hello world!\n");
}

Create tags file: ctags test.c

Open the test file: nvim test.c

Run :FzfLua tags
Here's my result:

Note how the two circled lines do not match.

Observations
I remember this used to work correctly. I suspect the change to tags.lua in 46c9e2b has something to do with this.

You’re correct, that’s “by design” since the performance improvement implementation for #245, I just left it as 1 because there are few functions dependent on having a line number and I didn’t want to experiment at the time how it will behave without it as I was busy with the multi process performance enhancements.
I’ll remove it once I’m done with the other issues, in the meantime if you want to hide it you can do so by supplying the function with { fzf_cli_args = 'with-nth=…' }, the delimiter is : so you’d wanna hide field 2. (man fzf if you have no idea what I’m talking about, also see #253)

https://github.com/ibhagwan/fzf-lua/commit/31a678e4dedb418fd011f31333ff7111e16aaae6 this commit closes this issue.
Note that unless you change the previewer to bat it will no longer show line numbers at all, the reason is the tags files does not contain numbers (by default) and since #245 the pattern is being used to locate the correct preview (and buffer jumps) instead of line number.

Thanks for the update! However, I noticed that line numbers aren't shown even for the bat previewer. This isn't an issue, it's just that your last comment made it seem like line numbers are only hidden for the built-in previewer.

Thanks for the update! However, I noticed that line numbers aren't shown even for the bat previewer. This isn't an issue, it's just that your last comment made it seem like line numbers are only hidden for the built-in previewer.

That's because tags and btags are no longer affected by the default previewer setting, both now use their own specialized tag previewer (that knows how to search for the pattern).
To test the bat previewer with tags or btags do:
require'fzf-lua.setup {
  tags = { previewer = "bat" },
  btags = { previewer = "bat" },
}

-- or just call the function direcltly with these options:
:lua require'fzf-lua'.tags({ previewer = "bat" })


Prototype kit: How can we help users be more confident with prototype customisation?

What
We need to help users be more confident with customisation of their prototypes, even though we have guidance on where to do it and understand why this might be a problem.
Why
Previous user research has suggested that some users aren't confident customising their prototypes because they feel they lack HTML, CSS and JS knowledge in and outside of the prototype kit ecosystem.
Related to
#1316
Done when

[ ] We've reviewed our current guidance and made a Mural
[ ] Review how GOV are teaching people things
[ ] Collate how people have tried to teach / learn HTML/CSS/JS in the past
[ ] Review feedback from code clubs
[ ] Create a survey about what people don't feel confident with and might want to learn and post to Slack

Speak to @markasrobinson about his codepens


Images on screen do not load until scrolling

If there are images already in viewport before scrolling, the images don't load until you scroll the page.
A workaround is to do something like scrollBy(0,1) after applying model, but ideally this should not be necessary.

I managed to fix that by doing this.
Not sure if it's a bad idea, but it works.
        function init(element, valueAccessor, allBindings, viewModel, bindingContext) {
            var initArgs = arguments;
            flagForLoadCheck(); // add check here
            updatebit.subscribe(function () {
                update.apply(self, initArgs);
                flagForLoadCheck();  // add check here
            });
        }

This works too, might be a better solution.
        function init(element, valueAccessor, allBindings, viewModel, bindingContext) {
            var initArgs = arguments;

            updatebit.subscribe(function () {
                update.apply(self, initArgs);
            });
            setTimeout(function () {
                flagForLoadCheck();
            }, 300);
        }

@JOOSTR Your first fix worked for me with the images in a container, the second did not work at all.

If you replace this
var updatebit = ko.observable(true).extend({throttle: 50, notify: 'always'});
at line 8 it should work.


Uv hydro profiling

Using RProf(), I found out that datetime parsing was taking a while. Fasttime is very fast and helps handle this problem.

I'm having trouble with Travis builds. It doesn't seem to want to install fasttime when testing.

@dpattermann-usgs
I think you need to make sure you do an import before the function that uses it and also add it to the DESCRIPTION file. We've been using roxygen to update that automatically I think.
@ldecicco-USGS ?

Also, I haven't done any benchmarking, but since you are already using the lubridate package, you might want to check if the function fast_strptime is comparable (in case you don't want to depend on yet another package). It's definitely faster than base, but I haven't compared it to fastPOSIXct.

@ldecicco-USGS I hadn't done any benchmarking for lubridates parse_date_time either. I'm comparing the two right now. Seems like lubridate is nearly just as fast. I chose fasttime because it's very lightweight (it only has the one function) and it's pretty simple to use. But if we're already using lubridate, I'll just use that.


[5.1] Switch lldb PR testing to cmake

This has been on for master for a while. Time to switch the release branch too.

@swift-ci test and merge

Forgot to cherry-pick one small commit from lldb, that's why it's failing. I'll do it now.

Once https://github.com/apple/swift-lldb/pull/1556 goes in, I can probably merge this.

@swift-ci test and merge

Again the import failure for the linux bot, trying again.

@swift-ci test linux platform


Unable to require or import ipcRenderer

Preflight Checklist

[ ✓ ] I have read the contribution documentation for this project.
[ ✓ ] I agree to follow the code of conduct that this project follows, as appropriate.
[ ✓ ] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Issue Details

Electron Forge Version:
6.0.0-beta.57
Electron Version:
13.1.4
Operating System:
macOS 11.4 (20F71) Big Sur
Last Known Working Electron Forge version::
N / A

Expected Behavior
I should be able to import or require ipcRenderer from electron in the Render process.

renderer.ts
const { ipcRenderer } = require('electron')

Actual Behavior
Electron app window opens but crashes on the "⠸ Compiling Renderer Code" step.
Error
⠸ Compiling Renderer Code
An unhandled rejection has occurred inside Forge:
TypeError: Cannot set property 'native_modules/dist/Electron.app/Contents/Frameworks/Mantle.framework/Mantle' of undefined

To Reproduce
Create project with electron forge
npx create-electron-app my-new-app --template=typescript-webpack

Add ipcRenderer to renderer.ts
const { ipcRenderer } = require('electron')

I have this same issue, a solution (though I hope it is only temporary) is to do the following:
 mainWindow = new BrowserWindow({
    // ...
    webPreferences: {
      nodeIntegration: true,
      contextIsolation: false,
    },
   // ...
  })

and to include on renderer code using:
const { ipcRenderer } = window.require('electron')

Fixed in beta 58.

Another way of accessing ipcRenderer using ContextBridge API
https://github.com/electron-userland/electron-forge/issues/2160#issuecomment-889358025

Another way of accessing ipcRenderer using ContextBridge API
#2160 (comment)

Unfortunately, this is extremely limited as the ContextBridge has no support for MessagePorts.
This allows Renderer-to-Main calls but severely limits Main-to-Renderer calls.

This is not fixed. Please re-open.

I just tested, works for me.
If you need more assistance, please use one of the community forums, including the Electron Discord server.

Best practices for IPC are described in the official Electron documentation.


Pic support

Does typst provide support for pic for drawing pictures directly in the document?

PGF/TikZ is similar, but it is huge. If you are on Linux or *nix, just check man pic.
If you are familiar with roff like typsetters pic commands can be directly put into the text.
Some text.
.PS
BOX1: box "Name1" at (0 ,5)
BOX2: box "Name2" at (-5 ,10)
arrow from BOX1.e to BOX2.w
.PE
Some text.

Pic is relatively small and easy to grasp.
Maybe typst has its own syntax for drawing pictures directly in the document?

At the moment, typst has only rudimentary tools for that
https://typst.app/docs/reference/visualize/

Pic support is out of scope for the compiler. Maybe it could be provided by a package.

I have thought of implementing a PIC package. I've already made a TBL package which is available in the package repository. I think the trouble is PIC is a lot more complex - it might even be Turing complete. CeTZ is a good alternative but not quite the same as PIC of course. But if there is demand for a PIC package or you would like to collaborate on one let me know @m-kru. Perhaps it could be built on top of CeTZ similar to how TBL is built on top of tablex.

@maxcrees I would like to collaborate on, if only I had time ...


Static check on cron expression

cfn-lint version: (0.35.1)
Description of issue.
cfn-lint didn't detect malformed cron expression, e.g.:
AWSScheduledEvent
    Type: AWS::Events::Rule
    Condition: IsProdNA
    Properties:
      Description: Event that triggers my_awesome_lambda daily.
      Name: MyAwesomeLambdaTrigger
      ScheduleExpression: "cron(0 0 0 ? ? *)"

The cron expression is wrong and got failure:
Parameter ScheduleExpression is not valid. (Service: AmazonCloudWatchEvents; Status Code: 400; Error Code: ValidationException; Request ID: ...; Proxy: null)

Please provide as much information as possible:

Feature request:

Add static checking on cron expression. Because AWS scheduled event doesn't support second level specification, it's actually different that other cron by missing the second, It would be nice to have static check beforehand.

Cfn-lint uses the CloudFormation Resource Specifications as the base to do validation. These files are included as part of the application version. Please update to the latest version of cfn-lint or update the spec files manually (cfn-lint -u)

duplicate of https://github.com/aws-cloudformation/cfn-python-lint/issues/816


Components that are childs of removed node does not have lifecycle methods triggered

Describe the bug
Mutation observer trigger component $destroy only when component is top node that is being removed.
Expected behavior
Every component that is in removed subtree should have it's method triggered

@xolir are you planning to fix this?

@mateuszluczak Will take it


[FLINK-17929][docs] Fix invalid liquid expressions

It is a trivial bugfix.

Do you mind having a look @azagrebin ?


pretrained model link not working

Hi,
The Pretrained Model Link Provided: https://drive.google.com/drive/folders/1LDE08DwQaA79-lq7NKPU7ieb_DOh9VSk?usp=sharing is not working

Hi, same question here

Same question here.

@ZHANGKEON sincerely look forward to your reply.

@ZHANGKEON Please reply 😞

The link is updated.


Non-optional fields should have required schema in the output

export const fields = {
  acceptedTermsOfService: checkboxField(),
  newsletter: checkboxField({optional: true})
};

const signupFormAtom = formAtom(fields);

type SignUpFormValues= FormValues<typeof signupFormAtom>;

Current:
type SignUpFormValues = {
  acceptedTermsOfService: boolean;
  newsletter: boolean;
}

Expected:
type SignUpFormValues = {
  acceptedTermsOfService: true;
  newsletter: boolean;
}

Likely this will need FormSubmitValues to indicate that the 'non-optional' field will have the 'narrow' type only after submit.
The acceptedTermsOfService above will have false value when the form is first initialized.

The optional flag in the ZodFieldAtomConfig should also extend the behavior of the inner required atom. Currently its writable, so even when field is not specified as optional it's possible to make it optional...
Likely we will need different API:
const newsletter = optionalField(checkboxField());

which fits the jotai paradigm where we have 'decorators' atomWithX.
The optionalField could decorate the field so it's required state can be controlled.


Workspace - Unable to proceed to the next tab from "Invite new members" with Enter key

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.84-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4635357&group_by=cases:section_id&group_id=229065&group_order=asc
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:

Navigate to https://staging.new.expensify.com/
Log in with any account that has a workspace
Navigate to the workspace Members page
Select a few members
Focus the empty input field
Press the Enter key

Expected Result:
I should be taken to the "Add message" page.
Actual Result:
Unable to proceed to the next tab from "Invite new members" with Enter key.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/e0c3668e-535f-4cd9-ac26-cd31cb7771b8

View all open jobs on GitHub

We think this issue might be related to the #collect project.

Agree that this is a bug related to wave-collect.

Hey @abdulrahuman5196, could you please review Krishna's proposal?

I'm going to assign a new C+ to keep this issue moving.

Hey @Ollyws - could you please review the open proposal (https://github.com/Expensify/App/issues/43821#issuecomment-2173532473) when you have a chance? Thanks!

@Krishna2323 @Ollyws please be careful with this one, I feel like this change has a high possibility of causing regressions since we added that prop a long time ago and have probably forgotten a lot of context. Please be extra thorough when you are testing your changes 👍

I'm not sure why this switched to Daily so early - it just deployed to prod yesterday. I'm switching it back to weekly.
@Ollyws can you please complete the BZ checklist by July 22? Thanks!

My bad - payment is due on 7/17. Switching back to daily!

@sakluger can I get a payment summary please?

Summarizing payment on this issue:
Contributor: @Krishna2323 $250, paid via Upwork
Contributor+: @Ollyws $250, please request on Newdot

@250 approved for @Ollyws


fix(examples): Typo in ClientConfiguration example

This was forgotten in commit: 04594b97a9e61931d3af6847b8f8335f0f91c460

Cherry-picked to 5.4.x


retrieve_usecase deleted

No longer doing this use-case.

Good job. You are indeed an excellent coder.


Special characters

I am experiencing word splits in weird places when the sentence includes characters like commas, colons, semi-colons, and slashes.
Example:
"As a Hydra Store Visitor, I want to see the latest version."
Becomes:
"As a Hydra Store Vis i t or , I want to see the latest version."
I noticed during TokenizePositions, the last token in the the first phrase ("Visitor,") does not pass the AlphaNumeric.IsMatch(token) because the token has an ending character , i.e. a comma, so the model evaluator takes over and splits up the string in strange ways.  Am I doing something wrong?
Please advise.

I'll have a look at your fix quickly and get back to you once the solution has been integrated on the master branch.
Thanks for your help on this!

When I run the default tokenizer with the models provided, I get the expected results:

Can you tell me which tokenizer and which models you are using to reproduce this issue?

Sorry Alex, that I did not see your last email to me.  I should have clarified my goal in the beginning, which was the fact that I was trying to figure out how to map the sub-parses back to the original text locations.  You are right in that the tokenizer tokenizes correctly, but I had to create a few properties to the Parse class and write a routine to analyze the spacing correctly.
I would do a pull request of my code but I went a bit rogue, which would break the port from Java.  I am okay with the closing of the issue.  Thank you for looking into it.


Updated QuiteRSS to 0.17.7 (latest available Mac version)

Also added zap stanza and correct license

Thank you for the contribution. It was merged directly as 60e8ded4e4c9dbdc59633aa1e7d04cdee0946ec1 to keep commit history cleaner. Your contribution is still credited to you.


Don't Merge! PR real time test for webhook case

Docs Build status updates of commit 332c0a4:
:clock10: Pending: waiting for processors (18 builds ahead of you)
:warning: Docs Build is busy, currently there are 18 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 332c0a4:
:clock10: Full build: the average full build time is 7 min(s) 42 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit 332c0a4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/testing.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Package install error

Describe the bug

Version

Browser

[X] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[X] macOS
[ ] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Create a new bot using "empty" template
Go to 'getting started page'
Click on 'add package'
Click on 'Bot.Builder.Community.Components.CallDialogs', then 'install'
See error.

Expected behavior

Screenshots

Additional context

I believe this is due to an old value in your .composer/extension-data/package-manager.json file. Removing this file and trying again should resolve it.

Thanks. was able to install the package. Although it's not showing in the dialog tree. I assume it takes some time? if so, could we let user know in the UI? (something like: it takes a few minutes to show up?)
Correct me if I'm wrong. It's just that, after the installation, the user doesn't see the changes and don't know where and how to use the package:-)

the results of your install should appear immediately.
in this case, you installed a package of custom actions, which appear in the "+" menu of the dialog editor.


auto-format Module

to make it easier to review #1891

again, just auto-format, nothing interesting


How can I add new features to my code base？

YOU MAY DELETE THE ENTIRE TEMPLATE BELOW.
Issue Template
Expected Behavior
How can I add new features to my code base？

Send me massage fir help

YOU MAY DELETE THE ENTIRE TEMPLATE BELOW.
Issue Template
Expected Behavior
How can I add new features to my code base？

I can help yoi


LABS using circuit?

Is there an example where QOKit evaluates the LABS circuit instead of the statevector simulation?
In the qaoa_objective_labs file:
https://github.com/jpmorganchase/QOKit/blob/29e010c420436746534e86a6da5b1a0492ef0161/qokit/qaoa_objective_labs.py#L19
I see that the circuit is imported, but I don't see where it is ever used/evaluated? Isn't this necessary for large N?
(I see QOKit has this implemented for portfolio optimization though.)
@mmenickelly

@jmlarson1, thank you for raising this issue!
This is indeed a bug as the support for Qiskit simulation leveraging the parameterized QAOA circuit appears to have been lost. Somehow, this has escaped our test coverage, which is unfortunate.
The short of it is that simply instantiating parameterized QAOA circuit and passing it to get_qaoa_objective should work.
We will aim to resolve this soon (though possibly after the holidays).

Many of us, including @Shagun-G are interested in having this functionality

A PR along the lines I outlined above would be greatly appreciated!

@jmlarson1 @Shagun-G @mmenickelly:
I added a quick hot fix in #30 that should address your needs. Here is a quick test that the implementation is correct:
import numpy as np
from qokit.parameter_utils import get_best_known_parameters_for_LABS_wrt_overlap_for_p
from qokit.qaoa_objective_labs import get_qaoa_labs_objective

N = 7
p = 8
gamma, beta = get_best_known_parameters_for_LABS_wrt_overlap_for_p(N, p)

f1 = get_qaoa_labs_objective(N, p, parameterization="gamma beta", simulator="auto")
f2 = get_qaoa_labs_objective(N, p, parameterization="gamma beta", simulator="qiskit")

assert np.isclose(f1(gamma, beta), f2(gamma, beta))

Thank you. I need to try a different build because I get an error:
Traceback (most recent call last):
  File "/home/jlarson/QOKit/ruslan_rocks.py", line 2, in <module>
    from qokit.parameter_utils import get_best_known_parameters_for_LABS_wrt_overlap_for_p
  File "/home/jlarson/QOKit/qokit/__init__.py", line 6, in <module>
    from .qaoa_objective import get_qaoa_objective
  File "/home/jlarson/QOKit/qokit/qaoa_objective.py", line 10, in <module>
    import numba.cuda
  File "/home/jlarson/.local/lib/python3.10/site-packages/numba/__init__.py", line 55, in <module>
    _ensure_critical_deps()
  File "/home/jlarson/.local/lib/python3.10/site-packages/numba/__init__.py", line 42, in _ensure_critical_deps
    raise ImportError("Numba needs NumPy 1.24 or less")
ImportError: Numba needs NumPy 1.24 or less

I would suggest trying to re-install from source in a clean venv/conda environment.

@jmlarson1 was your issue resolved by #30?

Yes! The example works for me. Thank you.
Is there some obvious way to pass the desired number of shots to the get_qaoa_labs_objective method?  f1(gamma, beta, shots=1000) would be nice, and would seem to match qokit/qaoa_circuit_portfolio.py  where one can
execute(circuit, backend, shots=n_trials).
But that doesn't work (and I don't even see that kwargs are passed to get_qaoa_labs_objective).

The simulator does not support emulating shot-based noise. Only exact expectation value is returned currently.

That is understandable. Is there a shot-based get_qaoa_labs_objective (without a simulator, perhaps)?


Document Image SrcSetOptions

Hey @wizardlyhel 👋
What's the best way to test/run these docs locally?
WHY are these changes introduced?
Resolves https://github.com/Shopify/shopify-dev-feedback/issues/2495, https://github.com/Shopify/shopify-dev-feedback/issues/2554, https://github.com/Shopify/shopify-dev-feedback/issues/2437
WHAT is this pull request doing?
Documents Image srcSetOptions based on changelog.

There is no way to run these locally. Need to run npm run build-docs inside packages/hydrogen-react folder so that we get an updated generated_docs_data.json


Add "Getting Started" guide to README

We should have an end-to-end example that shows the use of CDI.
This should:

Use a vendor-agnostic spec (see https://github.com/container-orchestrated-devices/container-device-interface/pull/67#issuecomment-1183083813)
Use podman
Show the commands required and the expected output

We can also add links to vendor-specific examples once these are ready.

The docs for containerd still do not seem to be correct. This was not resolve https://github.com/container-orchestrated-devices/container-device-interface/pull/67#issuecomment-1117008704

As far as I can tell ctr run will not work without this PR: https://github.com/containerd/containerd/pull/7399
I assume similar changes would also need to be made for docker.

As far as I can tell ctr run will not work without this PR: containerd/containerd#7399
I assume similar changes would also need to be made for docker.

The only CLI tool that currently has support for CDI devices is podman which allows fully-qualified CDI device names to be provided in the --device argument. This would have to be implemented in other CLIs including docker and ctr.


Select query with mixed AND/OR: 'WHERE (x OR z) AND (a OR b OR c)

How can the following query be created:
Select * from table WHERE (x OR z) AND (a OR b OR c)
when I do query.where(condA, condB, condC)  it creates

AND(a AND b AND c)

while  query.whereOR(condA, condB, condC)  creates

OR(a OR b OR c)

but I need a mixture of AND and OR.

Hi! You could take a look at QueryBuilder approach:
http://satyan.github.io/sugar/query.html

Of course I did ;-) The code posted above is already using that approach.
I just simplified it - maybe a bit too much^^
Here is the complete code:
    private Select<Challenge> getQuery() {
        Select<Challenge> query = Select.from(Challenge.class);

        if (paidVersion) {
            query.whereOr(
                    Condition.prop(SugarProperties.SALES_TYPE).eq(0),
                    Condition.prop(SugarProperties.SALES_TYPE).eq(1)
            );
        } else {
            query.where(Condition.prop(SugarProperties.SALES_TYPE).eq(0));
        }

        if (getSelectedCategories().size() > 0) {
            query.whereOr(getCategoriesQuery()).list();
        }

        return query;
    }

    public Condition[] getCategoriesQuery() {
        Condition[] conditions = new Condition[selectedCategories.size()];
        for (int i = 0; i < selectedCategories.size(); i++) {
            String code = selectedCategories.get(i).getCode();
            conditions[i] = Condition.prop(SugarProperties.CATEGORY).eq(code);
        }
        return conditions;
    }

SQL Log: SQLiteQuery: SELECT * FROM CHALLENGE WHERE (sales_type = ?  OR sales_type = ? ) OR (main_category = ?  OR main_category = ?  OR main_category = ? )

The OR between the WHERE clauses is what I want to be an AND

Right now the builder doesn't seem to support this.. You may want to look at the mergeConditions method in Select class here:
https://github.com/satyan/sugar/blob/master/library/src/main/java/com/orm/query/Select.java#L73
The specific code in question is this:
https://github.com/satyan/sugar/blob/master/library/src/main/java/com/orm/query/Select.java#L102
It seems to take the clause between conditions as the clause across multiple blocks..

will there be a enhancement on this to support
the Query like
where (x OR z) AND (a OR b OR c)
Thanks very much !!


fix forest flag (shows message after initial, sometimes)

was caused by using "set" instead of "add" on quest flag.


Update CMake build instructions

Also, remove the need to use bundler when cocoapods is available system-wide.
/cc @a-maurice

Note that these documentation changes reflect the changes made in #1587 wherein we're no longer using an explicit superbuild setup.


Add ability to pass custom animators to rememberAnimatedNavController

To be merged once Nav 2.4.0 Alpha 10 is released :)
Fixes #744

Navigation 2.4.0-alpha10 is out now so I think you can update the dependency now.


Fix id attr value not being interpolated for leafletDirectiveMap events

Fixex id attribute value not being interpolated for leafletDirectiveMap events.
Cf. Issue #235.

Thanks @apkoponen, but this PR not resolves #235  when scope property with map id is not 'mapId'
Example:
<leaflet id="{{otherMapId}}" center="center"></leaflet>


Bso wildy slayer

Description:

Changes:

Other checks:

[ ] I have tested all my changes thoroughly.

@ellipsis-dev review

@ellipsis-dev review


Sequence generation

This issue has been reflected in v0.6.
https://github.com/shapoco/calctus/releases/tag/v0.6.8857.6956-beta


Merge removal of unstuff from parent binwalk

Besides the parent repo's point that unstuff isn't needed as a dependency anymore, the URL for unstuff is broken and causing builds that rely this repo's deps.sh to fail.

Thanks for the PR!


returning html page that is not fully loaded

Hello,
I am trying to make a request to a page (https://azimo.com/en/send-money-to-australia) but HTML data returned is not fully loaded. This website is client-side rendered so the request is missing rendered data.
const rp = require('request-promise');
const cheerio = require ('cheerio');

let request = {
  uri : 'https://azimo.com/en/send-money-to-australia',
  transform : body => cheerio.load(body)
}

rp(request)
  .then(($) => {
    const rate = $("#currentRate").val();
    console.log(rate);
})

How do I wait for page to fully render and load and then get the data?
PS. using nightmare I can get the data I want

I have the same problem, did you find a solution??

As you say, the missing part is the client-side rendered data. And it’s not a matter of waiting. Just using request-promise + cheerio just doesn’t do this job. The approach you’d need to take is to use a headless browser which does all the rendering for you and then get the page source from that browser.


No completion for Properties of $Error[n]

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues, especially the pinned issues.

Exception report
N/A

Screenshot

Environment data
PS Version: 7.2.1
PS HostName: ConsoleHost (Windows Terminal)
PSReadLine Version: 2.2.2
PSReadLine EditMode: Windows
OS: 10.0.19041.1 (WinBuild.160101.0800)
BufferWidth: 245
BufferHeight: 67

Steps to reproduce
> Write-Error "an error"
> $Error[0]. <-- type <tab> or Ctrl+Space to try to complete Properties of System.Management.Automation.ErrorRecord

Expected behavior
Powershell should return completions of System.Management.Automation.ErrorRecord
Actual behavior
Powershell apparently returns completions of Array instead of ErrorRecord.

If you unload PSReadline and try tab completing or invoke TabExpansion2 manually you get the expected results. I think the issue is that PowerShell looks at the current scope, and I guess $error exists but is empty in the PSReadline module scope.

See #3568 for no success history.

He said:

The original fix I made had a bad assumption as there is a valid $script:error variable.

If that's true then I don't see how this can be fixed without some sort of hack, PowerShell is correctly finding the $Error variable in the PSReadline scope.
So the question becomes, how should the hack be implemented? Should the completion code have a special case for $Error if no results are found? Should the Safe Expression Value code have a special case for $Error within the PSReadline scope? Should PSReadline provide its own completions for $Error?

If I understand correctly current status is that the issue presents only if PSReadline is loaded. If so maybe @daxian-dbw advice.

Completion of $global:Error[0].Fu<tab> works with PSReadLine loaded.

The above fix could work, but there is also possibility that the PSConsoleHostReadLine function from PSReadLine will depend on state in the module in future, and in that case the function won't work properly if it's disconnected with the PSReadLine session state.
So, maybe the fix needs to happen in the tab completion code, for example, CommandCompletion.CompleteInput offers an additional parameter to allow the caller to choose running it with the top-level session state.


TC-CNET-4.4: Remove yaml

This test has an automated python script now.

never mind - behind the times.


Migrate Snowflake driver repository build to gradle

Description:
This helps to build the snowflake connector with the latest driver connector without publishing Ballerina Central.

This is completed. hence closing the issue


Android Kotlin: 05.12 SUB-TOPIC NAME

Description :scroll:

Give a step-by-step tutorial of Nested RecyclerView in Android (Kotlin).
Required Documentation or Video or Audio.

Domain of Contribution :bar_chart:

[x] Android Dev (Kotlin)

References :
https://medium.com/nerd-for-tech/nested-recyclerview-in-android-e5afb2b9771a

Please Read it Carefully Before Contributing

Changes should be made in Android_Development_With_Kotlin/ directory under Android_Development_With_Kotlin branch.
Inside Android_Development_With_Kotlin/ directory creates a directory and names it according to the topic ( for this issue 09. Dynamic User Interface)
Inside 09. Dynamic User Interface/ directory add your task with subtopic number and name and make changes accordingly.
You have to push your PR to the Android_Development_With_Kotlin branch only.
You can take help to the references but don't simply try to copy it. Just explain in your own word.
This issue is for GWOC'21 contributors only.
You need to push in a single commit. If there exists more than one commit then you need to squash your commits into one commit.
Will assign you on a first come first serve basis.
Please try to complete your assigned task within 7 days. If you need some more time then, please inform mentors and supervisors.
If you have two previously assigned issues on Android-Kotlin pending then please first complete them.

Supervisor @rahulsain

Happy Contributing. Best of Luck.:sparkling_heart:

In which topic will you be contributing to?

Basically in Java with BackEnd

I think you choose the wrong domain then

Yes you are right but i am also here for learning new things so I am learning both of them


gMSA data are not parsed

Hello, first and foremost, thans for this awesome tool!
I wanted to point out that currently gMSA passwords cannot be retrieved by powerview.py and also, ACLs are not parsed. Please see attached screenshots:
Setting user "levi" to be allowed to read gMSA passwords:

No ACLs over the gMSA

Moreover, by looking at the gMSA individually, there is no property that specifies who is allowed to read the gMSA pw.

I think being able to find relevant gMSA ACLs and being able to retrieve password could be a great addition to the tool.
Cheers!

Hi, can you try using -GMSAPassword option under Get-DomainComputer module if can successfully parsed the values. If it works, i will probably add parsing function embedded in Get-DomainComputer by default.

Howdy! we have added new module Get-GMSA  as an alias of Get-DomainGMSA to parse the dacl of each gmsa objects. Feel free to try it out and let us know it goes. Much appreaciated

Tried and it works wonders! Thanks the awesome work!


create a rule demo?

Hi Wufeifei;
I don't understant how to write rule on the web interface;  can you show me a demo?

Demo rule
http://cobra-docs.readthedocs.io/en/latest/rule_list/


Channel filters when browsing channels

Documentation for: https://github.com/mattermost/mattermost/pull/24099
@M-ZubairAhmed - Mobile app v2.8.1 includes channel filter options that differ from web/desktop. Is this intended? Or will mobile app v2.9 include the same filters as available via web/desktop?

Appreciate your help with this, @M-ZubairAhmed!

@M-ZubairAhmed - This update is being included as part of the v9.1 release. I'm going to merge this docs PR now. I'm happy to update this content to include mobile app support when available.


define a healthsite as a master

as an administrator I want to select a healthsite from a list of other healthsites and indicate that it is the master record so that I know which one to publish
https://docs.google.com/document/d/1afFXk-Z2stflLXJJRx1RSudMWRZL4w7s-1AiQ4EGvpE/edit?usp=sharing


Move each platform setup into its own file

Quick start and helm page were far to long, and one of the recent PRs put back the duplication in install I had removed.
It's also better to have each platform with its own page.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: andraxylia
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sdake
If they are not already assigned, you can assign the PR to them by writing /assign @sdake in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: andraxylia
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

I this it would be useful to move all the new platform-specific docs into a subdirectory.
docs/setup/kubernetes/platform
You just need to add an _index.md file in the above directory to contain the metadata for the directory, and then subdirectories for each page.

Why does moving to a subdirectory not work? The web site supports arbitrarily deep hierarchies in genersal.

I tried subdirectories in my previous PR and it did not work. Nevertheless, further re-arranging and improvements can be done in subsequent PRs.

@andra I appreciate the work you did in this PR - and agree with @geeknoid that platform setup should go in its own subdir.  The main rationale is this screenshot:

I'll merge this now, and sort out moving the files around as soon as this PR merges.

/lgtm
/approve

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: andraxylia, sdake
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andraxylia I can't approve this PR (change to .spelling file... groan) - once @geeknoid approves I'll move around the content.

/assign @geeknoid


[CT-1279] [Bug] Slim CI not working with external tables

Is this a new bug in dbt-core?

[X] I believe this is a new bug in dbt-core
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
Slim CI always execute external tables sources and its dependencies even if they haven't been modified.
Expected Behavior
Since Slim CI is working properly using the manifest.json from prod environment, we were expecting that only modified models and dependencies are updated. The expected behavior is to not always run unmodified models that are dependent on external tables (using package dbt-labs/dbt_external_tables).
Steps To Reproduce
Command to see the list of changes:
dbt ls --target dev --select state:modified+ --state prod_run_artifacts

Command to run state and defer:
dbt run --target dev --select state:modified+ --defer --state prod_run_artifacts

Packages.yml file:
packages:
  - package: dbt-labs/dbt_external_tables
    version: 0.8.0
  - package: dbt-labs/dbt_utils
    version: 0.8.4
  - git: "https://{{ env_var('DBT_GIT_TOKEN'<EMAIL_ADDRESS>    revision: master
    warn-unpinned: false
    subdirectory: gold

External table definition example:
version: 2

sources:
  - name: events_raw
    loader: Dataflow Pub/Sub to GCS

    tables:
      - name: shipments_shipment_created
        description: "External table of Created Shipment, stored as JSON files in Cloud Storage"
        external:
          location: 'gs://packlink-raw-events/events/microservice=shipments/entity=shipment/event=created/*'
          options:
            format: NEWLINE_DELIMITED_JSON
            ignore_unknown_values: true
            hive_partition_uri_prefix: 'gs://packlink-raw-events/events/microservice=shipments/entity=shipment/event=created'
            require_hive_partition_filter: true
          partitions:
            - name: partition_time
              data_type: date
        columns:
          - name: packlink_reference
            data_type: string
          - name: state
            data_type: string
          - name: attributes
            data_type: >
              struct<
                x_occurred_on timestamp
                >

Relevant log output
No response
Environment
- OS: MacOS 12.2.1
- dbt: dbt-bigquery==1.1

Which database adapter are you using with dbt?
bigquery
Additional Context
No response

Hey @samuelmp10 - trying to fully understand your issue here. I have a simple toy project (on Snowflake) setup like so:
# dbt_project.yml
name: "my_dbt_project"
version: "1.0.0"
config-version: 2
profile: "snowflake"

models:
  my_dbt_project:
    +materialized: table

# packages.yml
packages:
  - package: dbt-labs/dbt_external_tables
    version: [">=0.8.0", "<1.0.0"]

# models/sources.yml
version: 2
sources:
  - name: dbt_jyeo_tester
    tables:
      - name: people
        external:
          location<EMAIL_ADDRESS>          file_format: "( type = csv skip_header = 1)"
        columns:
          - name: id
            data_type: number
          - name: first_name
            data_type: text
          - name: last_name
            data_type: text
          - name: email
            data_type: text

-- models/foo.sql
select * from {{ source('dbt_jyeo_tester', 'people') }}

-- models/bar.sql
select * from {{ source('dbt_jyeo_tester', 'people') }}

Steps

Install dependencies via dbt deps.

Create external tables from scratch + run our models via:

$ dbt run-operation stage_external_sources --vars "ext_full_refresh: true" && dbt run

10:56:27  Running with dbt=1.2.1
10:56:27  Partial parse save file not found. Starting full parse.
10:56:28  1 of 1 START external source dbt_jyeo_tester.people
10:56:30  1 of 1 (1) create or replace external table development.dbt_jyeo_tester.people(            ...
10:56:33  1 of 1 (1) SUCCESS 1
10:56:39  Running with dbt=1.2.1
10:56:39  Unable to do partial parsing because config vars, config profile, or config target have changed
10:56:41  Found 2 models, 0 tests, 0 snapshots, 0 analyses, 309 macros, 0 operations, 0 seed files, 1 source, 0 exposures, 0 metrics
10:56:41
10:56:46  Concurrency: 1 threads (target='dev')
10:56:46
10:56:46  1 of 2 START table model dbt_jyeo_tester.bar ................................... [RUN]
10:56:50  1 of 2 OK created table model dbt_jyeo_tester.bar .............................. [SUCCESS 1 in 3.67s]
10:56:50  2 of 2 START table model dbt_jyeo_tester.foo ................................... [RUN]
10:56:54  2 of 2 OK created table model dbt_jyeo_tester.foo .............................. [SUCCESS 1 in 3.70s]
10:56:54
10:56:54  Finished running 2 table models in 0 hours 0 minutes and 13.03 seconds (13.03s).
10:56:54
10:56:54  Completed successfully
10:56:54
10:56:54  Done. PASS=2 WARN=0 ERROR=0 SKIP=0 TOTAL=2

Let's test our CI out by modifying just model foo to be:

-- models/foo.sql
select 1 as id

Be sure to rename the old target folder and then run with a deferred state:

$ mv target target_old
$ dbt run --select +state:modified+ --defer --state target_old

10:57:36  Running with dbt=1.2.1
10:57:36  Partial parse save file not found. Starting full parse.
10:57:37  Found 2 models, 0 tests, 0 snapshots, 0 analyses, 309 macros, 0 operations, 0 seed files, 1 source, 0 exposures, 0 metrics
10:57:37
10:57:43  Concurrency: 1 threads (target='dev')
10:57:43
10:57:43  1 of 1 START table model dbt_jyeo_tester.foo ................................... [RUN]
10:57:47  1 of 1 OK created table model dbt_jyeo_tester.foo .............................. [SUCCESS 1 in 4.09s]
10:57:47
10:57:47  Finished running 1 table model in 0 hours 0 minutes and 10.43 seconds (10.43s).
10:57:47
10:57:47  Completed successfully
10:57:47
10:57:47  Done. PASS=1 WARN=0 ERROR=0 SKIP=0 TOTAL=1

Indeed only model foo was modified and thus only model foo ran as expected. As you can tell - everything is working as expected wrt state comparison.

Are you saying that in the example I provided above where I only modified model foo that your dbt run --select +state:modified+ --defer --state target_old ALSO included model bar?

Decided to do a second pass at this... let the setup be the same as above... clean up and then do a run:
$ dbt clean && dbt run

11:20:53  Running with dbt=1.2.1
11:20:53  Checking target/*
11:20:53  Cleaned target/*
11:20:53  Finished cleaning all paths.
11:20:58  Running with dbt=1.2.1
11:20:58  Partial parse save file not found. Starting full parse.
11:21:00  Found 2 models, 0 tests, 0 snapshots, 0 analyses, 309 macros, 0 operations, 0 seed files, 1 source, 0 exposures, 0 metrics
11:21:00
11:21:05  Concurrency: 1 threads (target='dev')
11:21:05
11:21:06  1 of 2 START table model dbt_jyeo_tester.bar ................................... [RUN]
11:21:10  1 of 2 OK created table model dbt_jyeo_tester.bar .............................. [SUCCESS 1 in 4.23s]
11:21:10  2 of 2 START table model dbt_jyeo_tester.foo ................................... [RUN]
11:21:14  2 of 2 OK created table model dbt_jyeo_tester.foo .............................. [SUCCESS 1 in 3.78s]
11:21:14
11:21:14  Finished running 2 table models in 0 hours 0 minutes and 13.86 seconds (13.86s).
11:21:14
11:21:14  Completed successfully
11:21:14
11:21:14  Done. PASS=2 WARN=0 ERROR=0 SKIP=0 TOTAL=2

Modify foo.sql but make sure it also selects from the source as before:
-- models/foo.sql
select id * 2 as id_new from {{ source('dbt_jyeo_tester', 'people') }}

Do a deferred run:
$ mv target target_old
$ dbt run --select +state:modified+ --defer --state target_old

11:22:41  Running with dbt=1.2.1
11:22:41  Partial parse save file not found. Starting full parse.
11:22:42  Found 2 models, 0 tests, 0 snapshots, 0 analyses, 309 macros, 0 operations, 0 seed files, 1 source, 0 exposures, 0 metrics
11:22:42
11:22:48  Concurrency: 1 threads (target='dev')
11:22:48
11:22:48  1 of 1 START table model dbt_jyeo_tester.foo ................................... [RUN]
11:22:52  1 of 1 OK created table model dbt_jyeo_tester.foo .............................. [SUCCESS 1 in 3.73s]
11:22:52
11:22:52  Finished running 1 table model in 0 hours 0 minutes and 9.95 seconds (9.95s).
11:22:52
11:22:52  Completed successfully
11:22:52
11:22:52  Done. PASS=1 WARN=0 ERROR=0 SKIP=0 TOTAL=1

As above repro - everything is working as expected or as @samuelmp10 puts it:

not always run unmodified models that are dependent on external tables

Indeed bar did not run here as it was unmodified.

And finally, I'm going to try dbt-bigquery 1.1 with dbt_external_tables 0.8.0.
Setup is pretty much identical to above.
# dbt_project.yml
name: "bigquery"
version: "1.0.0"
config-version: 2
profile: "bigquery"

models:
  bigquery:
    +materialized: table

packages:
  - package: dbt-labs/dbt_external_tables
    version: 0.8.0

# models/sources.yml
version: 2
sources:
  - name: dbt_jyeo
    tables:
      - name: people
        external:
          location: "gs://dbt-external-tables-testing/csv/*"
          options:
            format: csv
            skip_leading_rows: 1
        columns:
          - name: id
            data_type: int64
          - name: first_name
            data_type: string
          - name: last_name
            data_type: string
          - name: email
            data_type: string

-- models/foo.sql
select * from {{ source('dbt_jyeo', 'people') }}

-- models/bar.sql
select * from {{ source('dbt_jyeo', 'people') }}

Steps
$ dbt deps && dbt clean && dbt run-operation stage_external_sources --vars "ext_full_refresh: true" && dbt run

1:34:12  Running with dbt=1.1.0
11:34:14  Installing dbt-labs/dbt_external_tables
11:34:16    Installed from version 0.8.0
11:34:16    Updated version available: 0.8.2
11:34:16
11:34:16  Updates available for packages: ['dbt-labs/dbt_external_tables']
Update your versions in packages.yml, then run dbt deps
11:34:20  Running with dbt=1.1.0
11:34:20  Checking target/*
11:34:20  Cleaned target/*
11:34:20  Finished cleaning all paths.
11:34:26  Running with dbt=1.1.0
11:34:26  Partial parse save file not found. Starting full parse.
11:34:27  1 of 1 START external source dbt_jyeo.people
11:34:29  1 of 1 (1) create or replace external table `jeremyyeo-production`.`dbt_jyeo`.`people`(    ...
11:34:30  1 of 1 (1) OK
11:34:35  Running with dbt=1.1.0
11:34:35  Unable to do partial parsing because config vars, config profile, or config target have changed
11:34:36  Found 2 models, 0 tests, 0 snapshots, 0 analyses, 231 macros, 0 operations, 0 seed files, 1 source, 0 exposures, 0 metrics
11:34:36
11:34:39  Concurrency: 1 threads (target='dev')
11:34:39
11:34:39  1 of 2 START table model dbt_jyeo.bar .......................................... [RUN]
11:34:44  1 of 2 OK created table model dbt_jyeo.bar ..................................... [CREATE TABLE (200.0 rows, 7.5 KB processed) in 5.08s]
11:34:44  2 of 2 START table model dbt_jyeo.foo .......................................... [RUN]
11:34:49  2 of 2 OK created table model dbt_jyeo.foo ..................................... [CREATE TABLE (200.0 rows, 7.5 KB processed) in 5.05s]
11:34:49
11:34:49  Finished running 2 table models in 13.32s.
11:34:49
11:34:49  Completed successfully
11:34:49
11:34:49  Done. PASS=2 WARN=0 ERROR=0 SKIP=0 TOTAL=2

Modify our foo model:
-- models/foo.sql
select id * 2 as id_new from {{ source('dbt_jyeo', 'people') }}

Do a deferred run:
$ mv target target_old
$ dbt run --select +state:modified+ --defer --state target_old

11:36:07  Running with dbt=1.1.0
11:36:07  Partial parse save file not found. Starting full parse.
11:36:08  Found 2 models, 0 tests, 0 snapshots, 0 analyses, 231 macros, 0 operations, 0 seed files, 1 source, 0 exposures, 0 metrics
11:36:08
11:36:11  Concurrency: 1 threads (target='dev')
11:36:11
11:36:11  1 of 1 START table model dbt_jyeo.foo .......................................... [RUN]
11:36:16  1 of 1 OK created table model dbt_jyeo.foo ..................................... [CREATE TABLE (200.0 rows, 7.5 KB processed) in 4.79s]
11:36:16
11:36:16  Finished running 1 table model in 8.09s.
11:36:16
11:36:16  Completed successfully
11:36:16
11:36:16  Done. PASS=1 WARN=0 ERROR=0 SKIP=0 TOTAL=1

Spidey sense says, maybe this? https://github.com/dbt-labs/dbt-core/issues/2744
But I don't see any sort of env-specific logic in the sources config from the original post...

Hi @jeremyyeo @jtcohen6 first of all thanks for your checks and help.
I think our problem is related to the use of different targets and schema names for development, CI and CD deployments.
To add more context of our full process:
We are using the following generate_schema_name.sql macro:
{% macro generate_schema_name(custom_schema_name, node) -%}

    {%- set default_schema = target.schema -%}
    {%- if custom_schema_name is none -%}

        {{ default_schema }}

    {%- else -%}

        {%- if target.name != 'prod' -%}

            {{ default_schema }}_{{ custom_schema_name | trim }}

        {%- else -%}

            {{ custom_schema_name | trim }}

        {%- endif -%}

    {%- endif -%}

{%- endmacro %}

We have a specific default_schema for development and others for CI and for prod (CD).
Using Slim CI/CD with state and defer over native tables is working properly using the artifact that our CD (prod target) generates.
The problem comes when we have external tables as sources and we use the manifest.json generated by our CD (prod target) in our deferred runs for dev and CI. Only in these cases (dev and CI) is when the defer functionality is not working properly. It's like state and defer are not able to detect the external tables in the manifest.json and all models dependent on the external tables are run. Otherwise, when the manifest.json is used in our CD (whose target tables have the same schema_name that the manifest), the Slim CD is working properly, just as you proved in your tests @jeremyyeo.
Maybe the reason is that the external tables aren't generated with custom_schema and are used for our 3 deployments (dev, CI and CD) so the state and defer can't distinguish the non-changes in those external tables and dependent models.
I hope this can clarify the origin of our problem.
Thanks again for your support.

Maybe the reason is that the external tables aren't generated with custom_schema

This is true — sources don't use generate_schema_name. (Folks have asked for this before: https://github.com/dbt-labs/dbt-core/issues/4753)

and are used for our 3 deployments (dev, CI and CD) so the state and defer can't distinguish the non-changes in those external tables and dependent models.

There's only scenario that occurs to me here, which I can reliably reproduce. If your source is defined with env-specific logic in it, e.g.:
version: 2
sources:
  - name: my_source_name
    schema: "{{ 'foo' if target.name == 'prod' else 'bar' }}"
    tables:
      - name: people
        external:
          # ... anything ...

Then dbt will detect this source as "changed" between the dev and prod environments:
$ dbt ls --target prod && mv target/manifest.json state/
test.bar
test.foo
source:test.my_source_name.people
$ dbt ls --target dev --state state --select state:modified+
test.bar
test.foo
source:test.my_source_name.people

As documented here: https://docs.getdbt.com/reference/node-selection/state-comparison-caveats#false-positives
And originally open as this issue (which remains an issue, though it's been closed as stale): https://github.com/dbt-labs/dbt-core/issues/2744


how to clear off the session history chat responses from the widget

I am using Rasa backend and I could not find documentation for the chat widget (https://github.com/botfront/rasa-webchat)
please provide me documentation.

@95Rajitha  - How did solve this issue?
Even we are looking a way out in action_restart


HBASE-28750 Region normalizer should work in off peak if config

Region normalizer involves the splitting and merging of regions, which can cause jitter in online services, especially when there are many region normalizer plans.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 55s

the patch passed

+1 :green_heart:
compile
0m 58s

the patch passed

+1 :green_heart:
javac
0m 58s

the patch passed

+1 :green_heart:
javadoc
0m 28s

the patch passed

+1 :green_heart:
shadedjars
5m 20s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
13m 26s
/patch-unit-hbase-server.txt
hbase-server in the patch failed.

35m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6113/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6113

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 9effec4ca0f6 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / aec62bc506f52269ee7bf75977686d5790e8ac8f

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6113/1/testReport/

Max. process+thread count
1669 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6113/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 37s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m  4s

master passed

+1 :green_heart:
compile
2m 56s

master passed

+1 :green_heart:
checkstyle
0m 36s

master passed

+1 :green_heart:
spotbugs
1m 34s

master passed

+1 :green_heart:
spotless
0m 46s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 51s

the patch passed

+1 :green_heart:
compile
2m 54s

the patch passed

+1 :green_heart:
javac
2m 54s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 37s

the patch passed

+1 :green_heart:
spotbugs
1m 39s

the patch passed

+1 :green_heart:
hadoopcheck
10m 32s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 44s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s

The patch does not generate ASF License warnings.

35m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6113/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6113

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux 0e746eb74a97 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / aec62bc506f52269ee7bf75977686d5790e8ac8f

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
83 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6113/1/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

This is a nice addition. Is it possible add test for this condition in TestRegionNormalizerWorker?

This is a nice addition. Is it possible add test for this condition in TestRegionNormalizerWorker?

ok. I will do it today.

This is a nice addition. Is it possible add test for this condition in TestRegionNormalizerWorker?

It is ok.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m  5s

master passed

+1 :green_heart:
compile
2m 56s

master passed

+1 :green_heart:
checkstyle
0m 38s

master passed

+1 :green_heart:
spotbugs
1m 34s

master passed

+1 :green_heart:
spotless
0m 46s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 56s

the patch passed

+1 :green_heart:
compile
2m 55s

the patch passed

+1 :green_heart:
javac
2m 55s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 38s
/results-checkstyle-hbase-server.txt
hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
spotbugs
1m 40s

the patch passed

+1 :green_heart:
hadoopcheck
10m 43s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

-1 :x:
spotless
0m 39s

patch has 23 errors when running spotless:check, run spotless:apply to fix.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 58s

the patch passed

+1 :green_heart:
compile
0m 58s

the patch passed

+1 :green_heart:
javac
0m 58s

the patch passed

+1 :green_heart:
javadoc
0m 30s

the patch passed

+1 :green_heart:
shadedjars
5m 17s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
232m 20s
/patch-unit-hbase-server.txt
hbase-server in the patch failed.

257m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6113/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6113

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux ab85b4fb8cf5 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 37b8af734b0dfcf9591ddc33fc22ff7e831b371f

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6113/2/testReport/

Max. process+thread count
5251 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6113/2/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
4m  2s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  1s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 56s

master passed

+1 :green_heart:
compile
2m 56s

master passed

+1 :green_heart:
checkstyle
0m 37s

master passed

+1 :green_heart:
spotbugs
1m 32s

master passed

+1 :green_heart:
spotless
0m 43s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 53s

the patch passed

+1 :green_heart:
compile
2m 55s

the patch passed

+1 :green_heart:
javac
2m 55s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 37s
/results-checkstyle-hbase-server.txt
hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
spotbugs
1m 39s

the patch passed

+1 :green_heart:
hadoopcheck
10m 33s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

-1 :x:
spotless
0m 39s

patch has 23 errors when running spotless:check, run spotless:apply to fix.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m  0s

the patch passed

+1 :green_heart:
compile
0m 59s

the patch passed

+1 :green_heart:
javac
0m 59s

the patch passed

+1 :green_heart:
javadoc
0m 29s

the patch passed

+1 :green_heart:
shadedjars
5m 23s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
223m 35s

hbase-server in the patch passed.

248m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6113/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6113

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 42adfebb16c2 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e066a2927b88a9014bf6ac1373a462356179f983

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6113/3/testReport/

Max. process+thread count
5576 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6113/3/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.


[WIP] Font

That FancyText (not sure about the name) isn't implemented yet
-> How can a React.Component determine the type of it's parents?

@kusti8 What should the default font family and size be (currently Arial 14pt)?

Closes #138
Some libui bugs:

align: https://github.com/andlabs/libui/issues/368
background on Windows: https://github.com/andlabs/libui/issues/347
underline on macOS: https://github.com/andlabs/libui/issues/322

Ok, its hard to get a component to know its parents. I sort of did something like that here https://github.com/kusti8/proton-native/blob/yoga/src/components/View.js, where I used the parent component and then basically chained function calls all the way up to the root. Default font should be Arial either 12pt or 14pt. Currently 12pt is pretty standard so that should be good.
I'll work on FancyText, (I'm thinking StyledText).

I'll work on FancyText, (I'm thinking StyledText).

👍

Anything else that needs to be done?

Everything from the libui api should be implemented (except for OpenTypeFeatures which can for example be used to turn on/off ligatures).

I added StyledText and I got the parent by using React Context. To do this, I had to upgrade react-reconciler so I had to make some changes so I need to test it more before merging.

This needs to be adjusted to accept StyledText: (bottom of components/Area.js)
js
Area.Text.propTypes = {
  children: PropTypes.oneOfType([areaProp, PropTypes.arrayOf(areaProp)]),
};

Looks like this is done. I'll merge if that's good with you @mischnic


Allow PHP 8.0

@VitalyArt You should also add new tests to the bors.toml.
@wolfy-j @SerafimArts Should we stop supporting the PHP 7.2 as it supported until 30.11.2020?

@48d90782 done👍

bors r+

bors r+

Thanks @VitalyArt. Now in master. 1.9.0 release with PHP 8.0 expected to be by end of week.


Integration of DARC QSL Shop

What Feature is Missing?
If I select QSL Cards to be printed, it would be a nice feature, if they could be automatically send to the DARC QSL (Printing) Service.
Why is This Feature Important?
It reduces, the hurdles, when you want to print QSL Cards
Is This Feature Personal or Beneficial to Others as Well?
I think the user base might have a difference in the need. It might not be the highest priority, but a nice to have feature.

Currently you're able to export a ADIF for only requested (or you marked as requested) QSOs at "Labels -> Pending QSLs -> View QSOs" at your PC.
After that export you can upload that ADIF to the DARC-QSL-Service, and mark them all as sent within Wavelog.
That is one possible Workflow for using the QSL Service.
As far as i know the DARC-Service offers NO explicit interface for an automatic upload. But if you have any information about such an interface, feel free to share.

The DARC Service Team responded to me, that they do not provide any API jet. But they are open for the idea. They would be interested to know, which features would be needed for the API.
Is there a way, how I can support on this? Unfortunatly I do have limited coding experience, but system architecting experience. If it helps, I could generate a draft (diagram), what I think makes sense, but as I do not know the code, it might not build the whole picture.
BR,
Lucas

Okay, thank you very much @int2001 . Let me know, if I can help. And yes, I expected as well, that it will take its time.
BR,
DO5LE