Terraform HCX addon scenario updates and fixes

Overview/Summary
Updated all of the scenarios and samples to include the new hcx_addon modules, and updated the tfvars samples to include the new variables.
Replace this with a brief description of what this Pull Request fixes, changes, etc.
This PR fixes/adds/changes/removes

New variables for toggling on HCX on terraform code
New module references is samples and scenarios to allow for the install HCX option
Updated provider required version for AZAPI to ensure the HCX module will install without error
Ran terraform fmt to clean up formatting across the terraform files in the repo.

Breaking Changes
Testing Evidence

As part of this Pull Request I have

[ x] Checked for duplicate Pull Requests
[x ] Ensured my code/branch is up-to-date with the latest changes in the main branch
[ x] Performed testing and provided evidence.
[ x] Updated relevant and associated documentation.

@prasad3017 and @rvandenbedem - I've updated the original greenfield, new scenarios, and new samples to allow for installation of the HCX addon when deploying a private cloud and exported the HCX activation keys for downstream automation.  There were a large number of files updated in this request.  Can you please review and approve?


Fix typo: GetJson -> GetCsv

Great catch, @midinastasurazz!  It turns out that #748 had the same "double GetJson" typo in the title too, so I went ahead and fixed that too.  Your Pull Request has been merged as dbb86679a1a2594d47b683756f2e9072b1576fed.  Thank you for your contribution!

You are welcome. I am glad I could help.


Refactor stringtab generation

The stringtab can be a global constant rather than a function local variable that's largely initialized at runtime. Storage of cached strings in the module state is converted to a big array of PyObjects (which means some code can be replaced with loops).
Hopefully helps a bit with https://github.com/cython/cython/issues/4425
A few quick tests on Cython's own modules suggest ~1% decrease in binary size, so probably worthwhile.

A few quick tests on Cython's own modules suggest <1% decrease in binary size, so probably worthwhile.

I think the users will apreciate any reducion of binary size - e.g. see following PR: https://github.com/scikit-learn/scikit-learn/pull/28451

<1%

I've edited my original PR description now, but I meant to write "approximately 1%" rather than "<1%". I.e. not dramatic, but worthwhile.

This is a very nice change in general, regardless of any space savings. Thanks!


Don't swallow journal serialization errors.

If serializers fail for some reason, the error is simply ignored. This is whack behaviour.
Here is the culprit: https://github.com/okumin/akka-persistence-sql-async/blob/b7d468a44c0023bd8f3aec0a6fcd1f897b1d862c/core/src/main/scala/akka/persistence/journal/sqlasync/ScalikeJDBCWriteJournal.scala#L32
This collect filters out failures.
This also seems to result in the $batch expression on line 53 evaluating to the empty string when result contains only failures, producing invalid SQL syntax.
It would be super nice to get some proper error handling in here, or at least logging the cause exception to stderr.

Do you think serialization error should fail wrapping future?

What I think should happen is that the cause stack trace should be logged to stderr and the resulting SQL should not be executed.

I think that it fails……

Apparently reference implementation for LevelDB catches serialization exceptions in Try monad but doesnt perform collect { Success() } on resulting collection of Trys.

Such a error should be notified to PersistentActor since journals don't work if some of them silently fails.

I remember that serialization errors can be rejected.
http://doc.akka.io/docs/akka/2.4/scala/persistence.html#Journal_plugin_API
I'm thinking to apply the following patches.

Not executing when all the payload cannot be serialized
Logging when a serialization error occurs

This is for convenience
Users who want to handle such an error can use onPersistRejected.

:+1:

I close this issue since it looks that the above solution is accepted.
The patch is already applied.
https://github.com/okumin/akka-persistence-sql-async/commit/2c449c5098a484ea24580d65948bbf25845548bd
Thanks.


How to add dependent validation rules?

I have two form fields and they have a dependency. The second field is required only if the first field value is true. How can I add such dependent validation rules on the second field?

You can use the present rule
// Should fail
new Validator({}, {
  name: 'string|present'
);

// Should fail
new Validator({
  name: []
}, {
  name: 'string|present'
);

Thanks for your answer. It should work. Is there a way for me to place more complex logic on the validation rule for that? Can I inject a function into the rule to do some validate calculation?

@zhaoyi0113 You can create your own rule if you would like to be as verbose as you wish
https://github.com/skaterdav85/validatorjs#registering-custom-validation-rules
If this does not do what you need, let me know and I will have a closer look at what you are trying to do.

Thanks for your help.

@zhaoyi0113 sure thing 👍


invalid or missing instance

I'm upgrading a project from 0.18.2 to 1.3.1 and it's working a few times until Rollbar::log start to return an error "invalid or missing instance", with a 400 staus. Then, it continue to return the same error and doesn't log nothing.
I saw a similar issue (#237), but it doesn't help me to solve this.
If it can be useful, here is a var_dump of my $_SESSION just before I try to log
array (size=6)
  'useragent6' =>
    array (size=16)
      'browser' => string 'Chrome' (length=6)
      'browser_maker' => string 'Google Inc' (length=10)
      'comment' => string 'Chrome 61.0' (length=11)
      'crawler' => boolean false
      'device_pointing_method' => string 'mouse' (length=5)
      'device_type' => string 'Desktop' (length=7)
      'majorver' => int 61
      'minorver' => int 0
      'parent' => string 'Chrome 61.0' (length=11)
      'platform' => string 'Linux' (length=5)
      'version' => float 61
      'browser_name_pattern' => string 'Mozilla/5.0 (*Linux*) applewebkit* (*khtml*like*gecko*) Chrome/61.0*Safari/*' (length=76)
      'browser_name_regex' => string '/^Mozilla\/5\.0 \(.*Linux.*\) applewebkit.* \(.*khtml.*like.*gecko.*\) Chrome\/61\.0.*Safari\/.*$/' (length=98)
      'ismobiledevice' => boolean false
      'istablet' => boolean false
      'useragent' => string 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.79 Safari/537.36' (length=104)
  'ip_b' => string '��' (length=4)
  'fingerprint2_b' => string '�H~b�lɬ����' (length=16)
  'user_fingerprint_id' => string '89' (length=2)
  'subscribed' => boolean true
  'userData' =>
    array (size=2)
      '_ip' => string '<IP_ADDRESS>' (length=10)
      'data' =>
        array (size=3)
          'Username' => string 'Guess' (length=5)
          'ID' => int 0
          'Password' => int 0

Edit:
I had a problem also with the previous version we were using (0.18.2). At least the function report_message was triggering a notice "iconv(): Detected an incomplete multibyte character in input string".
Now I "solved" both issues by clearing the cache of my browser.

That error implies that whatever payload we send is missing the data key. So there must be a bug in how we are building the payload or doing scrubbing. Let me try to look into this a little further.

Okay what I think is happening is that either during the building of data or during scrubbing (probably during scrubbing), the data value is getting set to null for some reason. We then subsequently don't include it in the final payload because of the way serializeForRollbar works. I'm trying to figure out how data could end up null.

I upgraded to the latest version today again (1.3.6), I keep have the same issue. Did you find something about it ? Do you need anything that could help you figuring out where the bug comes from ?
Thank you

@paullaffitte Do you think you can do some debugging in your Rollbar package? I suggest adding var_dump or your other preferred debugging tool in \Rollbar\RollbarLogger::log method on line 69 of file src/RollbarLogger.php to inspect all of the subsequent paylods:
var_dump($toSend);

Thanks to this we should be able to see what and when starts disappearing from your payload.

@paullaffitte Is this still an issue for you?

Having the same issue. Rollbar returns "invalid or missing instance" with status 400.
In my case, after digging into the rollbar library, I found out the error comes from one of the frame's arguments. Maybe because some arguments are too large. Replacing '"args" => $this->args,' by '"args" => [],' in the file Payload/Frame.php fixes it for me. But then I lose the arguments in the report's trace.
I figured a way to avoid these corrupting arguments and keep others with:
        $args = $this->args;
        if(!json_encode($args))
            $args = [];

Not sure though if works for all corrupting arguments but in my case it seems to do the job.

@h0gar can you provide us with a dump of arguments that are causing the error? I need to build tests for this

@paullaffitte PR 332 should fix this issue. Can you please check with current master or tag v1.4.1 when it gets released?

I do confirm that the problem is solved in 1.4.3:
binary values stored in session are now displayed as None on rollbar.com rather than triggering a 400 error code 'invalid or missing instance' on the php side.


Add Insert At Head for Circular Linked Lists

Is your feature request related to a problem? Please describe.
The problem is to add a node with integer data that is taken as an input from the user and add this node to the head of the Circular Linked List. Circular Linked Lists is a type of Linked Lists that has only the next pointer, but the main difference between SLL and CLL is that CLL's last node's next pointer would point to the head of the CLL
Describe the solution you'd like
I would like to create a directory named Circular Linked Lists and provide a C++ coded solution to this problem

@smv1999 I would like to work on this issue.

Sure @kiruba-r11 , you can go ahead !


Python to EXE converter raising several subprocess errors

Description
I am encountering several subprocess errors when trying to convert my Python script to an executable using pyinstaller. The process fails with various issues, including hidden import problems and long file path errors.
Current Status
This issue is being actively investigated. For now, please refrain from using the current setup as it may not work correctly. I are working swiftly on a fix and will update as soon as possible to ensure a smooth and fast conversion process.
Thank you for your patience and understanding <3

This issue will now be closed as it was deemed to be a personal OS issue with the 'pyinstaller' library, this was a minor bug and was resolved with a re-installation.


Update README.md

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

Thanks for the PR, created DOCS-3988 to track as an editorial review

Hi @Karl-kalash, would you be able to implement the suggestions here? These updates are based on our style guide. Let me know if you have any questions!

@Karl-kalash @buraizu I applied the changes from your suggestions. We've frozen the repo this week for Agent Release, but next week we can merge this PR in.


Omnipay says Buckaroo is supported gateway but it is not.

$factory->getSupportedGateways() contains Buckaroo in the list, but when I try to create it I am getting an exception:
RuntimeException in GatewayFactory.php line 105:
Class '\Omnipay\Buckaroo\Gateway' not found

There are some other gateways which do not work: ['Buckaroo', 'Alipay Bank', 'AliPay Dual Func', 'Alipay Express', 'Alipay Mobile Express', 'Alipay Secured', 'Alipay Wap Express', 'Cybersource', 'DataCash', 'Ecopayz', 'Neteller', 'Pacnet', 'PaymentSense', 'Realex Remote', 'SecPay (PayPoint.net)', 'Sisow', 'Skrill', 'YandexMoney', 'YandexMoneyIndividual']
Question: Can I use gateway names returned by getSupportedGateways method as a type for create method. Is this right way to use it?

Buckaroo specifically has multiple gateways, so you need to do create the gateway like this:
Omnipay::create('Buckaroo_Ideal')

Also, you can only use Omnipay::create on official omnipay gateways. It does not work for third party gateways, which a great many of the ones you listed are.

I want to get the list of supported gateways, using this list  I can create a gateway later, when user choose one. But I cannot simply use getSupportedGateways because it returns something which factory create method does not accept.
Given omnipay gateway type Buckaroo or class is not supported. Supported: AuthorizeNet_AIM, AuthorizeNet_SIM, Buckaroo, Buckaroo_Ideal, Buckaroo_PayPal, CardSave, Coinbase, Dummy, Eway_Rapid, FirstData_Connect, GoCardless, Manual, Migs_ThreeParty, Migs_TwoParty, Mollie, MultiSafepay, Netaxept, NetBanx, PayFast, Payflow_Pro, PaymentExpress_PxPay, PaymentExpress_PxPost, PayPal_Express, PayPal_Pro, Pin, SagePay_Direct, SagePay_Server, SecurePay_DirectPost, Stripe, TargetPay_Directebanking, TargetPay_Ideal, TargetPay_Mrcash, TwoCheckout, WorldPay, Alipay Bank, AliPay Dual Func, Alipay Express, Alipay Mobile Express, Alipay Secured, Alipay Wap Express, Cybersource, DataCash, Ecopayz, Neteller, Pacnet, PaymentSense, Realex Remote, SecPay (PayPoint.net), Sisow, Skrill, YandexMoney, YandexMoneyIndividual

And both Buckaroo_Ideal and Buckaroo in the list.

I have to skip them https://github.com/Payum/Payum/blob/master/src/Payum/Core/PayumBuilder.php#L577

I removed buckaroo from the list.

What about the reset (see above), they are not working too.

AuthorizeNet_DPM not in the list? I'll have to follow that up.

Seems like the problem still exists.
"Class '\Omnipay\Buckaroo\CreditCardGateway' not found"
        $gateways = \Omnipay\Omnipay::getSupportedGateways();

        foreach ($gateways as $id) {
            $gateway = \Omnipay\Omnipay::create($id);
            $gateway->getName();
        }

So far I ended up with try catch
try {
      $gateway = \Omnipay\Omnipay::create($id);
 } catch (\RuntimeException $exc) {
        //
 }

but it's an ugly solution


node info is null

In GitLab by @wknet123 on Sep 20, 2017, 13:44

In GitLab by @wknet123 on Nov 8, 2019, 07:37
Fixed with PR #352

In GitLab by @sokril on Nov 8, 2019, 08:10
closed

In GitLab by @sokril on Nov 8, 2019, 08:10
assigned to @wknet123


note for using model fields in field-level policies

Stumbled upon this behavior when working on an application but didn't see it documented. Not super intuitive so I thought I would try to explain what I was experiencing. Open to any word-smithing you all may feel is necessary!

Summary by CodeRabbit

Documentation

Introduced a new section on using other model fields within field-level policies, clarifying the importance of including all relevant fields in select queries to ensure correct policy evaluation.
Added examples to illustrate the impact of field inclusion on data retrieval outcomes.

Hi @heyweswu , thanks for making this PR. Actually the fields referenced in the field-level rules are supposed to be automatically included. Let me check if it's actually a bug.

Hi @heyweswu , thanks for making this PR. Actually the fields referenced in the field-level rules are supposed to be automatically included. Let me check if it's actually a bug.

@ymc9 Sounds good thank you for checking. Let me know if I can help! I dug down into some generated code and found a guard function looking like this:
function User$lastName_read(input, context) {
    return (((input === null || input === void 0 ? void 0 : input.organizationId) == 'organization123'));

input if I followed correctly was being passed entity from checkReadField. And entity was always only the specific fields in a given select of a query.
For example in the below query:
db.user.findMany({
  select: {
    lastName: true
  }
})

entity would come back as:
{
  lastName: 'Smith'
}

@ymc9 another detail/question we ran into today: If we have both model level and field level policies is there a way to fall back onto the model level policy if the field level policy evaluates to false (override set to true)? Or is it that if we set override to true we need to provide all the policy logic to allow read within the field-level allow?

@ymc9 another detail/question we ran into today: If we have both model level and field level policies is there a way to fall back onto the model level policy if the field level policy evaluates to false (override set to true)? Or is it that if we set override to true we need to provide all the policy logic to allow read within the field-level allow?

Hi @heyweswu , the "override" parameter allows a field to be accessed even if the entire entity cannot be accessed. It's explained in more details here: https://zenstack.dev/docs/the-complete-guide/part1/access-policy/field-level#overriding-model-level-policies There isn't a way to fall back from field-level to model-level yet. You can consider creating a github feature request for it.

Hi @heyweswu , thanks for making this PR. Actually the fields referenced in the field-level rules are supposed to be automatically included. Let me check if it's actually a bug.

@ymc9 Sounds good thank you for checking. Let me know if I can help! I dug down into some generated code and found a guard function looking like this:
function User$lastName_read(input, context) {
    return (((input === null || input === void 0 ? void 0 : input.organizationId) == 'organization123'));

input if I followed correctly was being passed entity from checkReadField. And entity was always only the specific fields in a given select of a query.
For example in the below query:
db.user.findMany({
  select: {
    lastName: true
  }
})

entity would come back as:
{
  lastName: 'Smith'
}

Hey @heyweswu , back to the original problem, I couldn't seem to reproduce the issue with a simple project. Do you have a sharable repro project? Thanks!

Closing for now since it's been silent for a while


Support Kotlin when updating Gradle files

Trying to add a project like this one: https://github.com/JLLeitschuh/ktlint-gradle
Gives the following error:

Repo must contain a build.gradle.

The bot should support build.gradle.kts files, or even better, supporting *.gradle.kts files and *.gradle files.

More in depth information about this issue can be found here:

https://github.com/dependabot/dependabot-core/issues/1164
https://github.com/dependabot/feedback/issues/172#issuecomment-637591057

Until Kotlin DSL is supported I have a bit of a hack:
Add this to your parent build.gradle.kts (subprojects section for multi-module)
    tasks.register("createDependabotFile") {
        doLast {
            mkdir("$projectDir/dependabot")
            val file = File("$projectDir/dependabot/build.gradle")
            file.writeText( "// Do not edit manually! This file was created by the 'createDependabotFile' task defined in the root build.gradle.kts file.\n")
            file.appendText("dependencies {\n")
            project.configurations.getByName("runtimeClasspath").allDependencies
                    .filter { it.group != rootProject.name && it.version != null }
                    .forEach { file.appendText("    compile '${it.group}:${it.name}:${it.version}'\n") }
            project.configurations.getByName("testRuntimeClasspath").allDependencies
                    .filter { it.group != rootProject.name && it.version != null }
                    .forEach { file.appendText("    testCompile '${it.group}:${it.name}:${it.version}'\n") }
            file.appendText("}\n")
        }
    }

It will create a dummy build.gradle file in a dependabot directory.  Have dependabot analyse that build.gradle & make suggestions.  When you update your relevant kts file, then pull requests get closed automatically.
You might want to switch runtimeClasspath & testRuntimeClasspath to be runtimeClasspath & testRuntimeClasspath respectively.
I have this task run after Gradle sync in IntelliJ.
Feel free to improve!

Thank you @Jerbell and @teolemon for sharing your hacks, I used it with a multi module project and it worked. Just sharing here the github action for others who are seeking for a temp solution till the actual feature is available.
dependabot.yml
version: 2
updates:
  - package-ecosystem: "gradle"
    directory: "module-a/dependabot"
    schedule:
      interval: "daily"
  - package-ecosystem: "gradle"
    directory: "module-b/dependabot"
    schedule:
      interval: "daily"
  - package-ecosystem: "gradle"
    directory: "module-c/dependabot"
    schedule:
      interval: "daily"

Any update on this issue? Gradle supports kotlin for quite a while now and this issue is also open for over 2 years now. Is there any progress on this?

I, at Gradle, have been engaging in conversations with the GitHub team about this issue. But there is no timeline nor any commitment here yet. The component we are most likely to fix first is the 'Figuring out what dependencies your project has' as I detailed in my earlier post.
https://github.com/dependabot/dependabot-core/issues/2238#issuecomment-637591057
This will most likely be driven by a GitHub action since determining your resolved dependencies requires that Gradle's internal dependency resolver logic actually be executed to get accurate results.
 But this is something that I am passionate about solving in the near future.

In the meanwhile, renovate painlessly supports kotlin dsl and does grouped updates.

In the meanwhile, renovate painlessly supports kotlin dsl and does grouped updates.

I don't know what renovate is doing explicitly, but I'm guessing they are solving the problem "good enough" instead of "correctly". IE. There's probably a non-zero chance that a change that renovate makes doesn't actually upgrade the resolved dependency, only the declare dependency, thus leaving you still vulnerable. This is because Gradle dependencies declared in Gradle build files are not WYSIWYG. Plugins, other dependencies, and forced configuration rules can all change what dependency gets resolved.

Renovate determines Gradle dependencies by dynamically creating a task and then calling the repository's gradle wrapper to execute it: https://github.com/renovatebot/renovate/blob/master/lib/manager/gradle/gradle-updates-report.ts#L41-L62

If "good enough" instead of "correct" is fine for your organization or use case, don't let me stop you. My goal is go work with the dependabot team to get us as close to "correct" as possible.

An admirable goal and certainly one to aim for.
Unfortunately, I'm not sure I understand what alternative you are advocating for.
As far as I can tell (sorry if I missed something) -- until the "correct" solution you mention is available -- the choice for kotlin dsl support is between "good enough" (renovate, or any other of the available tools) and "not available" (dependabot).

Renovate determines Gradle dependencies by dynamically creating a task and then calling the repository's gradle wrapper to execute it: https://github.com/renovatebot/renovate/blob/master/lib/manager/gradle/gradle-updates-report.ts#L41-L62

Looking at that, that looks at declared dependencies, not the dependencies that Gradle resolves (IE. after dependency resolution happens, and all of the other version constraints are considered, what version is actually used by your build).

Support for .gradle.kts files has been added recently https://github.blog/changelog/2020-12-18-dependabot-gradle-kotlin-and-composer-v2-support/. Can this issue be closed?

Support for .gradle.kts files has been added recently https://github.blog/changelog/2020-12-18-dependabot-gradle-kotlin-and-composer-v2-support/. Can this issue be closed?

New year present came pretty quick!

New year present came pretty quick!

This is supported, we just forgot to close this! Closing 🎉

Thanks for adding this support, But sadly dependabot does not resolve dependencies if the versions numbers are defined in a separate file :(, Is there any workaround for this issue

even with adding it as a variable in the same gradle file we now get 2 PRs for the same dependency 🤔

@savvisingh @huehnerlady could you open new issues for the issues you've run into? Definitely shouldn't be creating two PRs to update the same dependency.
We've have plans to start cloning the full repository when updating dependencies which will make it easier to resolve any file references across the repo.


update test to include stack trace

@devoncarew
update test to include stack trace
replaced string params in test method calls with first class objects

lgtm


Bug Fix Round 2

Here are all the vulnerabilities from https://lwn.net/Vulnerabilities since our last hunt.
Notes on the list

Some of these were probably resolved the last hunt, as I believe 10 of the issues got dropped at some point. I don't know how, but I'm thinking this list will go quickly. 19 of these issues are new.
The reports have been roughly grouped by the package name. This
isn't perfect, but is intended to help identify if a whole group
of reports is resolved already.
Some issues will be duplicated, because it affects multiple packages.
For example, there are sometimes problems that impact thunderbird,
and firefox. LWN might report in one vulnerability "thunderbird
firefox". These names have been split to make sure both packages get
addressed.
By each issue is a link to code search for the package name, and
a Github search by filename. These are to help, but may not return
results when we do in fact package the software. If a search
doesn't turn up, please try altering the search criteria or
looking in nixpkgs manually before asserting we don't have it.

Instructions:

Triage a report: If we don't have the software or our version isn't
vulnerable, tick the box or add a comment with the report number,
stating it isn't vulnerable.
Fix the issue: If we do have the software and it is vulnerable,
either leave a comment on this issue saying so, even open a pull
request with the fix. If you open a PR, make sure to tag this
issue so we can coordinate.
When an entire section is completed, move the section to the
"Triaged and Resolved Issues" details block below.

Without further ado...
Assorted (26 issues)

[x] #701931 (search, files)  mozilla: denial of service
[x] #647618 (search, files)  python-tornado: side-channel attack
[x] #679619 (search, files)  OpenVPN: multiple vulnerabilities
[x] #701926 (search, files)  qemu: multiple vulnerabilities
[x] #701920 (search, files)  mactelnet: code execution
[x] #701727 (search, files)  wordpress: multiple vulnerabilities
[x] #701931 (search, files)  mozilla: denial of service
[x] #684319 (search, files)  systemd: two vulnerabilities
[x] #701999 (search, files)  python-django: cross-site request forgery
[x] #702118 (search, files)  bind: denial of service
[x] #701923 (search, files)  bash: code execution
[x] #701921 (search, files)  policycoreutils: sandbox escape
[x] #616041 (search, files)  rubygem-bundler: installs malicious gem files
[x] #633546 (search, files)  cups: buffer overflow
[x] #701739 (search, files)  shiro: access control bypass
[x] #701734 (search, files)  openvas-libraries: multiple vulnerabilities
[x] #675696 (search, files)  nghttp2: denial of service
[x] #680462 (search, files)  putty: code execution
[x] #701735 (search, files)  openvas-scanner: denial of service
[x] #676795 (search, files)  poco: SSL server spoofing
[x] #701917 (search, files)  imagemagick: code execution
[x] #683853 (search, files)  postgresql: two vulnerabilities
[x] #701918 (search, files)  dwarfutils: two vulnerabilities
[x] #698651 (search, files)  borgbackup: directory traversal
[x] #680795 (search, files)  proftpd: weak key usage
[x] #701997 (search, files)  wireshark: denial of service

freerdp (2 issues) Note: triage indicates Gentoo is running 1.1.0 beta? 1.0.2 doesn't seem to have a fix.

[x] #702121 (search, files)  freerdp: denial of service
[x] #604034 (search, files)  freerdp: two vulnerabilities

openssl (2 issues)

[x] #702000 (search, files)  openssl: denial of service
[x] #701729 (search, files)  openssl: multiple vulnerabilities

This one took under an hour :)

openvpn:

unstable has 2.3.12
stable has 2.3.10
the cve report talks update an update to openvpn-2.3.4
openvpn 2.3.11: says "Fixed port-share bug with DoS potential" -> so this upgrade might be worse

Thanks, @Mic92! 16.03 has 2.3.10? we should probably backport that. Would you like to do the honors?

Upgrade straight to 2.3.12? Mostly bug fixes in this version.

@grahamc, do you know if there is an RSS/Atom feed for the LWN vulnerabilities? I couldn't find one.

@aneeshusa I don't think there is one. if you want to chat more, I'd rather talk about it over IRC? gchristensen

@Mic92 yep, straight to 2.3.12.

done: https://github.com/NixOS/nixpkgs/commit/1abec08343e6ec11c31ffe9a1844d80b098ef98d


[FEATURE REQUEST] Should example configs be taken from lowe-lab-ucl/btrack-examples?

Should we avoid duplication and pull the config files from https://github.com/lowe-lab-ucl/btrack-examples rather than store them here https://github.com/quantumjot/btrack/tree/main/models?

Yes, I think so

Fixed in #374


Share icons are missing in scholarsphere

Share icons exists in the internal test app, but in scholarsphere they are missing.
ScholarSphere:

Sufia:

This wa a javascript error.


Add SupportBlurTransformation which uses RenderScript support library.

Adds SupportBlurTransformation and SupportRSBlur which use the RenderScript support libraries instead of those packaged on the device.
Fixes #120

This still needs testing; I had some weird errors adding the renderscript target api.

@wasabeef Ping.
Not sure if you've seen this yet :)

@fougere-mike
I'm so sorry, I'm going to check and release that this weekend.

Sure, no rush. I've made a fork to use until then :smile:

@fougere-mike
Just now, I released the v3.3.0 that include your PR.


Added initial support for the DXGI debug layer, might need to revise …

I noticed I didn't get memory leak information about DXGI objects when calling ReportLiveDeviceObjects. I added support for the DXGI debug layer for doing this.
It also seems that using the DXGI approach to report the live objects doesn't require a device at all, so only the real leaking objects are printed, not the device/context etc that you still needed for calling ReportLiveDeviceObjects in the existing approach.
Since I had no idea how to do this correctly, I suspect feedback since this is just the first draft that is functional, but might not meet your requirements.
Thanks,
Peter Verswyvelen

I know this was already merged, but it's a bit unfortunate that the name "Debug" was used. Obviously it's a fine name and matches what it's doing, but it clashes with System.Diagnostics.Debug, which is a really commonly-used type and can force a lot of downstream code to change which references the DXGI assembly.
Not sure how it could be better, though. Maybe DxgiDebug, DxgiDebug1, etc.?

Yes, this is annoying, but happens a lot with SharpDX anyway.
It's a bit against the convention of SharpDX to prefix classes with their DirectX library names. For example, we have SharpDX.DXGI.Factory and not DxgiFactory, and that name clashes too with all other factories in SharpDX. Same goes for Format and many more.

Yes, it's true that SharpDX often conflicts with itself as you've mentioned. This is a conflict with a really common system library, though, so the effect will probably be a bit larger. I'd just like to avoid having to adjust a bunch of unrelated code so that it continues to compile as it did before. Changing the name it would break the naming pattern used, so I understand if it stays as-is. Just thought I'd bring it up -- I think other folks will also have to adjust their code when they upgrade and it will be a small annoyance.

No problem renaming it to DxgiDebug/DxgiDebug1, Debug is quite annoying indeed, PR welcome

Yes, indeed, in this case, it can break a lot of existing code, I didn't noticed that myself, since I always use namespace aliases for SharpDX.


 This is to prevent loading it when you set your GA id in config.js.

Makes sense. Thank you!


Median instead of mean when guessing highway speeds

While analyzing highway speeds, I noticed that osmnx relies on existing values for speed to fill in missing speeds per highway type. But it is using mean, while I think median would be more beneficial, correct and round, as it will predict actual speed in a given country better.
Impl:
I am thinking about changing this line only:
https://github.com/gboeing/osmnx/blob/9dbee4980fe7a43279b0bfa823b6b40317705c30/osmnx/speed.py#L87
(and accompanying comments). I tried running tests after changing this line and they are passing, but I still think this is behavioral change and can break some assumption on client code, not sure what are your thoughts (is it worth it). This is main reason I didn't submit PR, but opened issue first.
Another possible problem with this approach - few data points can lead to worse results (think of 2 speeds of 30kph and 50kph would produce 30, instead of maybe, more correct 40kph), but I think osmnx users generally work with larger amount of data than 2 or 3 rows and that this is not a problem.
Example
I did this with streets from Belgrade, Serbia (funny fact - Belgrade is mentioned in @gboeing's page here)
This is with mean:

And with median:

Here are raw values from these pictures for better searching and copy/pasting:

type
speed (mean)

living_street
21.25

motorway
95.19767441860465

motorway_link
48.58974358974359

primary
52.78801843317972

primary_link
46.59574468085106

residential
37.29013539651837

secondary
44.09898305084746

secondary_link
42.916666666666664

tertiary
42.27095516569201

tertiary_link
49.25925925925926

trunk
65.625

trunk_link
50.0

unclassified
42.64705882352941

type
speed (median)

living_street
10.0

motorway
91.0

motorway_link
50.0

primary
50.0

primary_link
50.0

residential
40.0

secondary
40.0

secondary_link
50.0

tertiary
40.0

tertiary_link
50.0

trunk
60.0

trunk_link
60.0

unclassified
45.0

Note there is also some work going on right now with speeds in #717.
The mean seems like the better estimate of the "expected value" of the edge (at least in my opinion). That is, I'd typically be less interested in the "correct" or "round" value and more interested in which value will, on average, allow my shortest path solving to behave according to real-world constraints. Ideally the mean would be length-weighted as the expected value, though. However, it may be worth allowing the user to specify an aggregation function as an argument (defaulting to something like agg=np.mean to maintain current behavior) in case they want to customize it, as you do.

Huh, this is bigger level of engagement that I anticipated for:) If you also don't plan to address it, feel free to close this issue (I was just wanting to point out to low-hanging fruit, but seems that fruit was not that low:)

@stalker314314 I have a proposed resolution in #725. Would you like to test it for your use case?


Refs are set to null instead of undefined when components are destroyed in vue v2.7.0-alpha.5

Version
2.7.0-alpha.5
Reproduction link
codepen.io
Steps to reproduce
Press the toggle button to cycle the ref
Working case with v2.6.14: https://codepen.io/pdanpdan/pen/QWQVXmr
Failing case with v2.7.0-alpha.5: https://codepen.io/pdanpdan/pen/JjpaQOP
What is expected?
this.$refs.test to be an element or undefined
What is actually happening?
this.$refs.test is null

As a workaround, you can do a loos comparison (pretty common for null): ref == null -> true for undefined and null

Yes, I know, but:

either the change was intentional and it should be documented as a breaking change (and maybe the initial value should be null too)
or it was an undesired side effect of backporting from vue3 and it should be fixed

As this is alpha stage I think it is a good time for such reports.

The template ref-removal behavior in 2.7.0-alpha differs from 2.6, but it's consistent with Vue 3 (demo) and with @vue/composition-api in Vue 2.6 (demo).
The behavior was introduced in 460856510d1a6356194e10f887df9b057297c07e:
https://github.com/vuejs/vue/blob/460856510d1a6356194e10f887df9b057297c07e/src/core/vdom/modules/template-ref.ts#L35
Changing that line's null to undefined would restore the original behavior, but would cause inconsistencies with Vue 3. I think it was actually intentional, as the unit tests even explicitly check for null. Perhaps migration docs should be added.


Why is the height set?

Hey, why is this done? When I add the toggle in my html and sett the size to xs - it will ignore this and set another, calculated, height of the element. If I remove this - it works according to the size I specified.
if (wrapperHeight < wrapperComputedHeight && self.size !== 'btn-xs' && self.size !== 'btn-sm') {
$scope.wrapperStyle.height = wrapperComputedHeight + 'px';
} else {
$scope.wrapperStyle.height = wrapperHeight + 'px';
}

Hello, same for me.
I have to remove the code to calculate the height and width.
regards

same here.

Same for me too.
Is there any plan to resolve this?

Same here.

For the record, this bug appears in the 0.1.2 version, but not in 0.1.1, and it almost certainly has to do with this commit from Oct 2015.
The bug doesn't appear on the demo site, but I assume that might not actually be using 0.1.2 version of the minified JS...?

I also have the issue and mention it so late because i have a fresh install and the issue persists.

Same here. I will have a look at it. Wait for the next PR! ;-)

Issue is fixed, please close, thanks!


update 4008_ardrone BAT_V_SCALING

-fixes #4799
I did a quick check for any remaining BAT_V_SCALING/BAT_C_SCALING usage.

Thanks for realising this. The param name changed because the param meaning changed. I fixed it properly in b731a9e.


Add v1->v3 cluster migration

What this PR does / why we need it:
This PR allows migrating from V1->V3 cluster without reimporting the clusters. Rancher already creates a V3 cluster for every V1 cluster. V3 cluster controller will check that V1 cluster includes a migrated annotation or exists at all for a given v3 cluster if the annotation is present, the reconciliation will continue as expected.
Users are required to set proper labels on the existing V3 cluster before migrating, this will be described in the ADR and rancher turtles docs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Checklist:

[ ] squashed commits into logical changes
[ ] includes documentation
[ ] adds unit tests
[ ] adds or updates e2e tests

Thanks @alexander-demicev, LGTM. I pushed some minor changes to fix CI checks and I'm fixing E2E tests locally and will be pushing an update too.

@alexander-demicev is this a duplicate of https://github.com/rancher/turtles/pull/576 ?

Hey @furkatgofurov7, #576 implements the approach presented by @Danil-Grigorev, which will be considered the primary migration method. The changes proposed in this PR will allow us to also support manual migration of clusters and it will also help with avoiding breaking clusters when users do not follow the proper migration procedure, i.e. prevent from creating duplicate resources to represent the same CAPI cluster.

Thanks for the review @Danil-Grigorev. Only E2E is pending for this to be ready to be merged.


Support for Swift 1.2

Swift 1.2 has been released in beta and URITemplate isn’t compatiable yet. As it’s not backward compatible and not officially released yet, I suggest creating a long running branch for it and merging it when 1.2 is released. I cloned it locally and it was rather streight forward to update—one line I’m not 100% sure about—if you create a branch for it I can PR into it.

Sure, I've created a branch xcode-1.2 please feel free to make a pull request. If not, I will be adding support when I get chance.

PRed: https://github.com/kylef/URITemplate.swift/pull/12


virtualbox: Change the virtualbox tests to not build the unfree tests by default

Motivation for this change
This PR changes the VirtualBox tests not to build the unfree tests by default.
The problem was that cache.nixos.org was running the tests, which caused the VirtualBox Oracle Extension Pack to be downloaded and cached.  cache.nixos.org was then serving the Extension Pack to people when they tried to download it.
However, the license for the Extension Pack explicitly states that it cannot be served by third parties.
This PR changes the code for the VirtualBox test to not build and run the unfree tests by default.  This causes cache.nixos.org to not build and cache the Extension Pack.
The VirtualBox tests can be run like the following:
$ cd nixos/tests
$ nix-build virtualbox.nix

This will only build and run the normal tests.
In order to build and run the unfree test, you must use the following command:
$ nix-build virtualbox.nix -A enable-extension-pack --arg enableUnfree true

If you try to run the enable-extension-pack test without setting the enableUnfree argument to true, you will get the following error:
$ nix-build virtualbox.nix -A enable-extension-pack
error: attribute 'enable-extension-pack' in selection path 'enable-extension-pack' not found

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

Pinging @flokli and @zimbatm since they helped a lot with the previous PR.  Also pinging @aszlig, who pointed out the bug this PR fixes.

@GrahamcOfBorg test virtualbox

Success on aarch64-linux
Attempted: tests.virtualbox
No partial log is available.

Success on x86_64-linux
Attempted: tests.virtualbox
No partial log is available.

Hm, that went a little too fast for a real test to have run.


Update JitsiMeet to the 2.0.6433 release

https://riffanalytics.atlassian.net/browse/RIFF-711
Description

This pull request updates JitsiMeet to the jitsi-meet_6433 release. The most prominent feature of the release is the ability to turn on/off sounds for reactions and incoming messages.
I also included some branding updates, such as using riffViolet for a scrollbar in chat and for checkboxes inside the 'Sounds' settings section.
Motivation and context

https://riffanalytics.atlassian.net/browse/RIFF-711

How has this been tested?

This pull request has been on my local machine and on sandbox2 environment
Screenshots (if appropriate):
Types of changes

✅ Maintenance (change which doesn't modify functionality, but provides dependency updates or tooling improvements)
✅ New feature (non-breaking change which adds functionality)
✅ Refactor (non-breaking change which doesn't change functionality)

Checklist:

✅ My code follows the code style of this project. [REQUIRED]
✅ All new and existing tests passed. [REQUIRED]
✅ My change requires a change to the documentation and I have updated it accordingly.
✅ I have added tests to cover my changes.

This PR is being replaced by #127 (overall functionality is the same as described here, but it is in a new branch)
I considered just resetting this PR's source branch, but decided a new PR was a better option in order to preserve the original commits for a few days.


No config file is created

The title says it all. The mod description makes it sound as though a config file should be created, but one isn't present after starting the game with this mod installed.

Server or client, as it currently is designed for server. Though there was a patch to make it load for LAN servers but that seems to not be in the current release.

In single player.


add config file

Adding a circleci/android image and running tests within that container

Using the circleci/node:latest image instead without Docker Authentication, added caching for faster builds (https://circleci.com/docs/2.0/caching/) when installing dependencies. Looks like 1 test is failing at the moment so I haven't gotten a successful build.

success! Thanks!
I'm seeing the fail test in my local setup too. it's not a CircleCI issues--the test itself is broken


Added '-products *' argument to vswhere command

I have a self-hosted DevOps agent running on a server with an installation of Visual Studio Build Tools 2019 that includes the "Microsoft.VisualStudio.Component.SQL.SSDTBuildSku" component. Despite the fact that SqlPackage is listed as a capability on the agent, whenever a job with the SqlDacpacDeploymentOnMachineGroupV0 task (link to task repo: https://github.com/microsoft/azure-pipelines-tasks/tree/master/Tasks/SqlDacpacDeploymentOnMachineGroupV0) is run on this agent, the task fails with the error "Unable to find the location of Dac Framework (SqlPackage.exe) from registry on machine ".
I traced this issue to the vswhere command changed in this PR. Since VS Build Tools doesn't show up in the list of VS Installations by default when using vswhere, the SqlPacakge.exe included in the "Microsoft.VisualStudio.Component.SQL.SSDTBuildSku" component installed on Visual Studio Build Tools 2019 is never found. The addition of the "-products *" argument will list all installed Visual Studio products including installations of VS Build Tools.
This issue appears to be related, they're using SSDT as well although it's not clear if it's through a VS Build Tools installation: https://github.com/microsoft/azure-pipelines-extensions/issues/534

Is there anything I should be doing as a part of the review process for this? It looks like other PRs created around the same time had the CI fail, and I don't have the permissions to see the details on it.


Update gh_pages link in doku

Use the new link: https://solacecommunity.github.io/angular-solace-message-client/

fixed

fixed


Missing fallback in recording creation brakes recordings table

brake happens if lang field has null

have a look into "new" stream creation dialogs


User should be able to modify the next version name that will be used by Tramline while creating a release

For ex: if the last release was version 8.2.2, tramline will automatically use the 8.3.* series for the next release. However, it is possible that the user may want the next release to use 9.0.*.
We should have a workflow for this.
"Start new release" with dropdown
One way to do this could be to show the next version name on the Start New Release button -- we change the button to say "Start New Release: 9.4.*".
Then, we add a little dropdown next to the button which says "Change next version number" which allows people to enter anything else apart from 9.4.*, which means they can enter 9.5.0 or even 12.0.0.

This was partly done in #458 which supports major and minor version bumps when starting a release.


feat(branding): add new branding library for easier maintenance

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
Currently, the daff-logo isn't themeable, nor is it housed in a single library for usage across projects.
Fixes: #219 #123 #117 #191
What is the new behavior?
This PR adds these capabilities.
Does this PR introduce a breaking change?
[x] Yes
[] No

The daffio logo implementation has been removed and replaced with the one from the branding library.
Other information

Replace
 with the copyright component

Replace
 with the copyright component

Resolved in 316d5dd7f4633344be59955e60197c1cd9d2dd8e

lgtm, squash and i'll approve

@xelaint squshed.

lgtm


Elastic 7.1 elapsed_end_without_start but works in 6.8.1 (same config)

For all general issues, please provide the following details for fast resolution:

Version: Logstash 7.1
Operating System: RHEL 6.5
Config File (if you have sensitive info, please remove it):

`...MORE ABOVE
if "_grokparsefailure" in [tags]{
grok {
remove_tag => ["_grokparsefailure"]
patterns_dir => ["/etc/logstash/conf.d/patterns"]
match => { "message" => "%{YEAR:log_year}\.%{MONTHNUM:log_month}\.%{MONTHDAY:log_day}\|%{TIME:log_time}\|\|%{SESSIONUID:SESUID}\|\|%{SESSIONUID:THREADUID}\|\(null\)\|%{WORD:ThreadName}\|%{WORD:Action}\|Begin\|check_patient_for_completeness%{GREEDYDATA}"}
		add_tag => [ "CheckPatientForCompletenessStart"]
		add_field => { "event" => "CheckPatientForCompletenessStart" }
	}
}

if "_grokparsefailure" in [tags]{
	grok {
		remove_tag => ["_grokparsefailure"]
		patterns_dir => ["/etc/logstash/conf.d/patterns"]
		match => { "message" => "%{YEAR:log_year}\.%{MONTHNUM:log_month}\.%{MONTHDAY:log_day}\|%{TIME:log_time}\|\|%{SESSIONUID:SESUID}\|\|%{SESSIONUID:THREADUID}\|\(null\)\|%{WORD:ThreadName}\|%{WORD:Action}\|End\|check_patient_for_completeness%{GREEDYDATA}"}

		add_tag => [ "CheckPatientForCompletenessEnd"]
		add_field => { "event" => "CheckPatientForCompletenessEnd" }
	}
}
elapsed {
    start_tag => "CheckPatientForCompletenessStart"
    end_tag => "CheckPatientForCompletenessEnd"
    unique_id_field => "THREADUID"
}`

Sample Data:

`2019.04.25|09:36:49.850||B8CA3A947330-5CC1B251-1||B8CA3A947330-5CC1B251-146|(null)|MainThread|Generic|Begin|check_patient_for_completeness()|(null)|
2019.04.25|09:36:50.128||B8CA3A947330-5CC1B251-1||B8CA3A947330-5CC1B251-146|(null)|MainThread|Generic|End|check_patient_for_completeness()|(null)|`

Steps to Reproduce:
I run the configs with the following command line parameters for 6.8.1:

    /logstash-6.8.1/bin# ./logstash -f /etc/logstash/conf.d/performance_log/v2/performance.log.conf -w 1 -r
and for my 7.1 installation:
    /usr/share/logstash/bin#  ./logstash -f /etc/logstash/conf.d/performance_log/v2/performance.log.conf -w 1 -r
However, I get different results!
The 6.8.1 correctly identifies the CheckPatientForCompletenessStart tag as the start and the CheckPatientForCompletenessEnd tag as the ending parameter.
However the 7.1 installation does not do this correctly and constantly displays "elapsed_end_without_start" tag.
The only thing that has changed between these two runs is the version of logstash.
This smells like a bug, but I'm not sure where. Maybe 7.1 is not properly interpreting the -w 1 flag correctly?
7.1 Example (notice how it seems to process the end but completely ignores the start):
    {
         "@timestamp" => 2019-04-25T13:36:50.128Z,
    "workstationName" => "ii-rs-hc-mam-04",
              "event" => "CheckPatientForCompletenessEnd",
               "tags" => [
        [0] "CheckPatientForCompletenessEnd",
        [1] "elapsed_end_without_start"
    ],
          "timestamp" => "2019 04 25 09:36:50.128",
           "SiteName" => "USA-SOMEWHERE-XX",
           "@version" => "1",
               "type" => "plain",
          "THREADUID" => "B8CA3A947330-5CC1B251-146",
            "message" => "2019.04.25|09:36:50.128||B8CA3A947330-5CC1B251-1||B8CA3A947330-5CC1B251-146|(null)|MainThread|Generic|End|check_patient_for_completeness()|(null)|\r",
             "Action" => "Generic",
               "host" => "wtlsuv403.sitename.com",
               "path" => "/var/log/perf_logv2/v3/client_performance_USA-SOMEWHERE-XX_ii-rs-hc-mam-04.log",
             "SESUID" => "B8CA3A947330-5CC1B251-1",
         "ThreadName" => "MainThread"
    }
    {
         "@timestamp" => 2019-04-25T13:36:49.850Z,
    "workstationName" => "ii-rs-hc-mam-04",
              "event" => "CheckPatientForCompletenessStart",
               "tags" => [
        [0] "CheckPatientForCompletenessStart"
    ],
          "timestamp" => "2019 04 25 09:36:49.850",
           "SiteName" => "USA-SOMEWHERE-XX",
           "@version" => "1",
               "type" => "plain",
          "THREADUID" => "B8CA3A947330-5CC1B251-146",
            "message" => "2019.04.25|09:36:49.850||B8CA3A947330-5CC1B251-1||B8CA3A947330-5CC1B251-146|(null)|MainThread|Generic|Begin|check_patient_for_completeness()|(null)|\r",
             "Action" => "Generic",
               "host" => "wtlsuv403.sitename.com",
               "path" => "/var/log/perf_logv2/v3/client_performance_USA-SOMEWHERE-XX_ii-rs-hc-mam-04.log",
             "SESUID" => "B8CA3A947330-5CC1B251-1",
         "ThreadName" => "MainThread"
    }

6.8.1 Example (Correct)
    {
               "type" => "plain",
         "ThreadName" => "MainThread",
             "SESUID" => "B8CA3A947330-5CC1B251-1",
           "@version" => "1",
               "path" => "/var/log/perf_logv2/v3/client_performance_USA-SOMEWHERE-XX_ii-rs-hc-mam-04.log",
          "THREADUID" => "B8CA3A947330-5CC1B251-146",
              "event" => "CheckPatientForCompletenessStart",
               "host" => "wtlsuv403.sitename.com",
         "@timestamp" => 2019-04-25T13:36:49.850Z,
    "workstationName" => "ii-rs-hc-mam-04",
             "Action" => "Generic",
          "timestamp" => "2019 04 25 09:36:49.850",
               "tags" => [
        [0] "CheckPatientForCompletenessStart"
    ],
           "SiteName" => "USA-SOMEWHERE-XX"
    }
    {
                       "type" => "plain",
                 "ThreadName" => "MainThread",
                     "SESUID" => "B8CA3A947330-5CC1B251-1",
    "elapsed_timestamp_start" => 2019-04-25T13:36:49.850Z,
                   "@version" => "1",
                       "path" => "/var/log/perf_logv2/v3/client_performance_USA-SOMEWHERE-XX_ii-rs-hc-mam-04.log",
                  "THREADUID" => "B8CA3A947330-5CC1B251-146",
                      "event" => "CheckPatientForCompletenessEnd",
                       "host" => "wtlsuv403.sitename.com",
                 "@timestamp" => 2019-04-25T13:36:50.128Z,
            "workstationName" => "ii-rs-hc-mam-04",
                     "Action" => "Generic",
                  "timestamp" => "2019 04 25 09:36:50.128",
                       "tags" => [
        [0] "CheckPatientForCompletenessEnd",
        [1] "elapsed",
        [2] "elapsed_match"
    ],
               "elapsed_time" => 0.278,
                   "SiteName" => "USA-SOMEWHERE-XX"
    }

Hi, I'm facing the same problem, did you succeed to get over it?

Yes. Kind of.
The problem is with the new java execution engine. I have to run logstash with the parameter —java-execution false in order to get it to work.

@herrkutt
I have the same issue but it's not a statistical one - I get "elapsed_end_without_start" on every end event. I do get the right tags on the events (both start and end), and ELK does recognize the end event through the tag (since it posts "elapsed_end..."), but it does not mark the start event.
Any ideas why? Maybe you have full logstash.config files with the elapsed filter that I can review and understand where my problem is?
Thanks in advance

Did anyone succeed to solve this? I see the same problem.

Did anyone succeed to solve this? I see the same problem.


⚠ WSINGRESOS - RECIBOPAGO has degraded performance

In a6f2f40, WSINGRESOS - RECIBOPAGO (https://srvshyweb.yucatan.gob.mx/cgi-bin/wspd_cgi.sh/WService=wsingresos/internet/servicios/wsRecibosPagosWeb.r) experienced degraded performance:

HTTP code: 200
Response time: 6211 ms

Resolved: WSINGRESOS - RECIBOPAGO performance has improved in c9b2877 after 34 minutes.


Build failures :/

I'd love to be able to test this out and contribute in some way but sadly the build fails so (for now) I've given up further investigations :/
~/tmp/oragono
 (master) 0
$ go build oragono.go
# github.com/DanielOaks/oragono/irc
../../go/src/github.com/DanielOaks/oragono/irc/strings.go:21: precis.Nickname.CompareKey undefined (type *precis.Profile has no field or method CompareKey)
../../go/src/github.com/DanielOaks/oragono/irc/strings.go:21: not enough arguments to return
../../go/src/github.com/DanielOaks/oragono/irc/strings.go:26: precis.Nickname.CompareKey undefined (type *precis.Profile has no field or method CompareKey)
../../go/src/github.com/DanielOaks/oragono/irc/strings.go:50: precis.Nickname.CompareKey undefined (type *precis.Profile has no field or method CompareKey)

Hey prologic. Sorry for this issue, Oragono actually makes use of a newly-introduced CompareKey function. For more info, there's this issue on the core Go repo: https://github.com/golang/go/issues/17386
Is there any chance I could ask you to cd to the Oragono directory and run this command or something similar, to update the required precis package?
go get ./...
Hopefully this should resolve the build issue for you, but if it doesn't please feel free to let me know! :)

I actually already ran go get ./... :)
Does this build on Go 1.7.4?

Hmm that's weird, I'm using 1.7.3 here. I'll throw this into a new VM, make sure it compiles from scratch (and that I haven't messed with any of my source files).

It's probably also worthwhile vendoring your package too so upstream bugs or changing code don't break builds until you've tested and updated to newer versions. I've had success with vendetta for managing my vendor'd packages.

Weird, from a plain go get this seems to work alright. Mind running this command and seeing whether it helps?
go get -u golang.org/x/text/secure/precis

I'll definitely take a look at vendoring. #52 threw me something similar but I was a bit offput at first. I'll need to take a better look at Go packaging (specifically vendoring), see what I can do there. Thanks very much for the link, should be helpful!

Okay I have a build working!

Awesome, thanks for the issue and I'm glad to hear that! I'll investigate app packaging though, check out vendored packages and all.


[1.19.0] [macOS] Atom CLI doesn't open native tabs

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
Atom CLI doesn't open native tabs.
It used to be working on 1.18.x just fine.
Steps to Reproduce

Navigate to a project, and do atom .
Navigate to a second project and do atom .

Expected behavior: Single Atom window with two native tabs.
Actual behavior: Two Atom windows.
Reproduces how often: 100%
Versions
macOS: 10.12.6
Atom: 1.19.0
Electron: 1.6.9
Chrome: 56.0.2924.87
Node: 7.4.0
apm: 1.18.2
Additional Information
macOS Dock settings:
Prefer tabs when opening documents: Always
Atom Core / Title Bar option: native

True. I observe the same behavior  when I try to open some projects through Finder.

Same bug. When I open recent projects with atom 1.18.x, it will open the project in another native tab of the current opened window. But now, it just opens another window.

I can reproduce this with System Preferences > Dock > Prefer tabs when opening documents in 1.19.0 - I think this is related to Electron changes but there's also an open pull request to enable this functionality here https://github.com/atom/atom/pull/14711.

Same problem here. I cant figure out how to combine projects into a single window at all anymore. 😢

Same thing here. Perhaps related to https://github.com/electron/electron/pull/9052 where they defaulted to no tabs by default for compatibility reasons.

@dannyradden

open file "/Applications/Atom.app/Contents/Resources/app/src/main-process/atom-window.js"

to line 58, option variables, add tabbingIdentifier: 'atom',

@kudorori thank you. Sigh of relief seeing that work.

@magicdawn Same here.

I was sure the fix will be present into 1.19.1 ☹

The PR I mentioned above (https://github.com/atom/atom/pull/14711) isn't merged yet but I'm bringing it up with the team tomorrow.

I seem to be missing something - how can I update to 1.19.1 (in Sierra)? Do I need to download the correct binary? Atom doesn't see any updates in "Check for Update".

^^ nvm, now I updated to 1.19.2. I guess the version wasn't published in the right place, or some caching was involved in the check.

@rsese, 1.19.2 is out, let's make #14711 happen on 1.19.3! 😄

I have it on our list to discuss soon @fmunteanu :v:

Good news 1.19.3 is out, bad news the fix (that works just fine!) isn't merged yet.

How much longer ? This is a real pain.

The fix was merged into the master branch 3 days ago with commit 80ce23734.
Not sure how long it takes to get things into the beta and then release branches but it's going to happen now.

For anyone that doesn't want to dig through the commit logs... the 1.21-releases branch has been made and it includes the tag fix. Should mean that when 1.21 is released you'll get native tabs again. 1.20 making it's way through beta testing and does not have the fix now (and I doubt it will be pulled in at this point).

Thank you @tsdorsey. @rsese, is there a way to push the fix into a new production release? Is difficult to work without this feature.

@fmunteanu There are no plans to include this in a hotfix release. It will be available in Atom 1.21 /cc: https://github.com/atom/atom/pull/14711#issuecomment-324790511.
I'm going to close this since it looks like it was fixed when https://github.com/atom/atom/pull/14711 was merged.

So we had the issue for a month now and it's not coming in the next release ? This is a regression, why do we have to wait so long for a fix ? At the pace of Atom release, we'll probably have to wait another month or two before seeing 1.21

@mrleblanc101 native tabs were intentionally disabled because they were causing other bugs (see #14197).  Now that Electron has better native tab support, we are adding it back, but would like to make sure there are no further regressions before releasing it to the stable channel.  I understand that you really like this feature, but please understand that we still have to balance shipping features and making sure those features are as bug-free as possible.
Again, sorry for the delay.

Atom 1.21.0-beta0 is here! Native tabs are back! Thanks guys. 🥇

any ideas how to set up a key shortcut to cycle thru native tabs?

I'd love to see full support for this, including menu options to open, close and cycle through.

Since https://github.com/atom/atom/issues/12690 was forcefully closed this should probably be closed too.


Fixed build issues

Addressed a few of the issues from the build report

The number of warnings actually went up in this PR. Trying to find the culprit with this last fix.


errors in obtain index_to_perturb

Hi 🙋 ,
one more question,
confusion in function _get_list_adv_example(self,x0) in file c_format_exploit_evasion.py
step1: list1 <-- get the index_to_perturb_sections from content shift attack
step2: list2 <-- get the index_to_perturb_pe from DOS extension attack
for my understanding, there should not have a overlap between list1 and list2 since there are from totally different parts of PE files, and all corresponding offset already shifted
therefore, the final indexes_to_perturb should concatenate two lists (e.g., list1+list2), while you shift the list2 with a length of (list1), e.g.,
"indexes_to_perturb = index_to_perturb_pe + [i + len(index_to_perturb_pe) for i in index_to_perturb_sections]"
Maybe I miss something here, hope you can clarify it. Thank you ☺ !!

should it be only shifting "preferable_extension_amount" instead of the whole length of index_to_perturb_pe, since in index_to_perturb_pe = [2,0x3c] +  [0x3c,pe_position +preferable_extension_amount ].
Here only "preferable_extension_amount" will have an follow-up impact


Arranging the directories based on topics

in this repo , there are mixed folders like for project and related topics so i would like arrange them according to topics like the topics which are necessary to make a complete project should come first so please assign me this issue under GGSOC'24

@NIKITA320495 go for it


Add support for execution scopes management

VM execution scopes
Description
This PR adds basic functionality for hints that need to create scopes in the VM. A new stack-like struct, ExecutionScopes is created with the following methods:

new: To create a new instance of ExecutionScopes
enter_scope: To create a new scope in the VM, with a dictionary representing the variables available in the new scope.
exit_scope: To exit the current scope and return to the previous one.
get_local_variables: To return and use the variables in the current scope.
assign_or_update_variable: To assign or update a variable in the current scope, depending if it exists or not.
delete_variable: To delete a variable in the current scope. (Used in a lot of hints)

Checklist

[ ] Linked to Github Issue
[x] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

Codecov Report

Merging #277 (1168cb1) into main (5346547) will increase coverage by 0.04%.
The diff coverage is 96.42%.

:exclamation: Current head 1168cb1 differs from pull request most recent head 70c24c9. Consider uploading reports for the commit 70c24c9 to get more accurate results

@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
+ Coverage   96.19%   96.24%   +0.04%
==========================================
  Files          23       24       +1
  Lines        6727     7053     +326
==========================================
+ Hits         6471     6788     +317
- Misses        256      265       +9

Impacted Files
Coverage Δ

src/types/exec_scope.rs
96.38% <96.38%> (ø)

src/vm/vm_core.rs
97.30% <100.00%> (-0.01%)
:arrow_down:

tests/cairo_run_test.rs
100.00% <0.00%> (ø)

src/vm/hints/execute_hint.rs
100.00% <0.00%> (ø)

src/serde/deserialize_program.rs
92.44% <0.00%> (ø)

src/vm/runners/cairo_runner.rs
98.61% <0.00%> (+<0.01%)
:arrow_up:

src/types/relocatable.rs
97.74% <0.00%> (+0.22%)
:arrow_up:

src/serde/deserialize_utils.rs
82.22% <0.00%> (+1.42%)
:arrow_up:

src/vm/hints/hint_utils.rs
79.75% <0.00%> (+1.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5346547...70c24c9. Read the comment docs.


Support functional-style if/then/else syntax

In addition to our current "Python-style"
then_expr if cond_expr else else_expr, add support for
Haskell/SML/OCaml-style
if cond_expr then then_expr else else_expr.
The Python-style syntax did a great job fitting a conditional
expression into Python under a lot of tough syntactic constraints, but
non-Python people tend to hate it and it will look pretty bad once we
have conditional DML.
There aren't any grammar conflicts, so this is fully backward
compatible, and both syntaxes can coexist peacefully, though we should
change all of our documentation to prefer the new syntax.

Please don't merge it before the next compiler call.

@raddevon We'll need documentation updates for this


Config settings for each (YT) channel in batch file

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.11.23. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2018.11.23

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[x] Feature request (request for a new functionality)
[x] Question
[ ] Other

Description of your issue, suggested solution and other information
For example, I have a batch file with currently 50 youtube channels (growing daily), some of which have upwards of 1-2000+ videos, EG (I only really care about the last 1-2 years for most), Is there any way to specify config settings for each channel individually?

--config-location.

Would that allow for setting settings for each channel? Like, 1 channel in the file only downloads videos from after 8-1-16, and another only downloads videos from after 1-1-18

It doesn't seem like it does from the readme file..

--config-location.

?

I'm not asking to download individual videos, I'm asking about a youtube channel in its entirety. One url for one channel, all channel URLs are in a url.txt file, but I don't want to download ALL videos from each channel, only after a certain point in time (--dateafter), for one channel i may only want to start downloading videos from up until 2 years ago, while another I may want the entire channel, I'm not asking for setting session wide configurations, If that's not something that's already been implemented, id ask if the issue gets reopened.


Implement Sign In/Login Functionality

Is your feature request related to a problem? Please describe.
Currently, users do not have the ability to create accounts or log in, which limits their experience on the YatuLearn platform. Without user accounts, it becomes difficult for learners to track their progress, manage their courses, and receive personalized recommendations, which can lead to frustration and decreased engagement.
Describe the solution you'd like
I propose to implement a Sign In/Login functionality that allows users to create accounts and log in securely. This feature should include options for email/password login and social media logins (such as Google or Facebook) for added convenience. Users should also have the ability to manage their profiles and track their learning progress.
Describe alternatives you've considered
One alternative is to allow guest access to the platform, but this does not provide the same level of engagement and personalization as user accounts. Implementing a Sign In/Login feature would create a more cohesive learning experience, encouraging users to return and engage with the content more deeply.
Additional context
Adding this functionality is crucial as user accounts can enhance engagement, provide valuable data for personalized learning paths, and foster a community atmosphere within the platform. Research shows that personalized experiences significantly improve user satisfaction and retention rates.

i want to work on this can you please assign to me

@serenade2400, @Charul00, thank you for your suggestion. We appreciate your message. Once PR no. https://github.com/yatulearn/yatulearn/pull/43 is merged, we will continue to review this PR. The main issue is major and helpful to others the folder structure. After merging this pull request, you can work on that.

Ok do it

Use frontend and backend as user login details should be stored in a database where we can get the details.

Use frontend and backend as user login details should be stored in a database where we can get the details.

can you give mongodb atlas database credentials so that i can stored in database

ok

Use frontend and backend as user login details should be stored in a database where we can get the details.

can you give mongodb atlas database credentials so that i can stored in database

I have sent an invitation mail kindly check it.

that doesnt work bro

i want to work on this project please assign me


fix(input): fix input height

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.49%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
6677

Relevant Lines:
7511

💛  - Coveralls


check-model-has-properties-file fails on macros with property files

Describe the bug

check-model-has-properties-file is run on macros, even though macros aren't models.
check-model-has-properties-file fails for macros, even though we did create a corresponding property file.

To Reproduce
Steps to reproduce the behavior:

Install dbt-redshift==1.6.2
Create a test.sql
Create a corresponding property file for that macro

Expected behavior

The hook should be skipped, as we're creating a macro not a model.
If it's supposed to run on all nodes, then this hook should succeed, as the property file exists and is staged.

Version:
Version 1.1.0, using dbt-redshift==1.6.2
Additional context
[WARNING] Unstaged files detected.
[INFO] Stashing unstaged files to /Users/davidbaussart/.cache/pre-commit/patch1702910336-22189.
Trim Trailing Whitespace.................................................Passed
Fix End of Files.........................................................Passed
Check Yaml...............................................................Passed
Check for added large files..............................................Passed
Check the script does not contain a semicolon............................Passed
Check the script has not table name......................................Passed
Check the script has existing refs and sources...........................Passed
Check the model has properties file......................................Failed
- hook id: check-model-has-properties-file
- exit code: 1

transform/macros/test.sql: does not have model properties defined in any .yml file.

Both files are staged in git – they're the only files staged.
Contents of transform/macros/test.yml
version: 2

macros:
  - name: test
    description: test

Contents of transform/macros/test.sql
{% macro test() %}
'test'
{% endmacro %}

Content of our pre-commit config file
# .pre-commit-config.yaml
fail_fast: true

files: ^transform
repos:
  - repo: https://github.com/pre-commit/pre-commit-hooks
    rev: v3.2.0
    hooks:
      - id: trailing-whitespace
      - id: end-of-file-fixer
      - id: check-yaml
      - id: check-added-large-files

  - repo: https://github.com/dbt-checkpoint/dbt-checkpoint
    rev: v1.1.0
    hooks:
      # script checks, stuff that could make us loose  time
      - id: check-script-semicolon
        args: ["--manifest", "transform/target/manifest.json", "--"]

      - id: check-script-has-no-table-name
        args: ["--manifest", "transform/target/manifest.json", "--"]

      - id: check-script-ref-and-source
        args: ["--manifest", "transform/target/manifest.json", "--"]

      # checking dbt property files
      - id: check-model-has-properties-file # property file exists
        args: ["--manifest", "transform/target/manifest.json", "--"]

      - id: check-model-has-description # a model desc is added
        args: ["--manifest", "transform/target/manifest.json", "--"]

      - id: check-model-has-meta-keys # an owner is added
        args:
          [
            "--manifest",
            "transform/target/manifest.json",
            "--meta-keys",
            "owner",
            "--",
          ]

Reproduced with:
Python 3.10.10
dbt 1.7.14
Snowflake
dbt-checkpoint v2.0.1
The check-model-has-properties-file is looking for "model: " properties in all yml property files, which of course don't exist for property files for macros.

I was also hit by this.
If anyone finds this issue, a workaround is to exclude the macros directory. Add an exclude key to your hook definition:
      - id: check-model-has-properties-file
        exclude: ^.*/macros


'Go to references' doesn't always work

Steps to reproduce: Go to https://github.com/rust-lang/rust/blob/98d66340d6e63eda115afc8b0da1d87965881936/src/librustdoc/clean/types.rs#L1528 in VSCode and hit Shift+F12 to go to references.
Expected behavior: Shows a list of usages (at least https://github.com/rust-lang/rust/blob/30e49a9ead550551e879af64ba91a0316da1c422/src/librustdoc/clean/mod.rs#L1907 should show up).
Actual behavior: Hangs forever.

How long did you wait? It took me like 30s before rename definition worked on rustc today. The next times were a lot quicker. If I recall correctly this uses the same information as go to definition and as such should have an equivalent warmup time.

I waited 3 minutes just now and it never finished running.

It does work for some things, shift+F12 on Visibility works fine.

I suppose this is a duplicate of #6568, or the other way around.


Removing account from accounts.js doesn't work?

I tried removing an account I don't use anymore from the accounts.js file but it still shows up and reloads whenever I reload my accounts. Did you change the way this works or is there another way?

Did you happen to go through the SetupTools install?
Check by clicking 'Setup' in the top menu. If you're greeted with "Muledump Manager" then click "Accounts" and remove the account there instead.


Show default storage class if no storage class is selected

If default storage class exists we should show it as a default value for storage class dropdown in Create Wizard. We should also disable storage class dropdown if there is no storage class available

/remove-lifecycle rotten
/reopen


Preview stretch

Hi,
Preview size is stretching when camera and preview orientation are different. It should be fixed :) For example:
I/DisplayConfiguration﹕ Preview: 600x800; Scaled: 1800x2400; Want: 1280x752

I assume this is the 3.x branch? Which devices is this? By stretched, do you mean zoomed, but still correct aspect ratio, or is the aspect ratio distorted?
Can you please give me the list of preview sizes for the device? Should be logged in Preview in order of preference: ....
Scaling up is intended behaviour, but this is probably more than it should be. It is quite possibly also an issue with the orientation as you mentioned - will look into it.

Preview in order of preference: [800x600, 320x240]
Yes, it's 3.x branch. I'm working right now on Samsung GT-P7500, i'll check it on Nexus 7 later.
By stretched i mean that ratio is distorted, as you can see:
Preview: 600x800; Scaled: 1800x2400; Want: 1280x752
So imho in landscape it should be:
Preview: 600x800; Scaled: 1800x2400; Want: 752x1280
Ofc i made fast fix:
if((scaledPreview.width > scaledPreview.height && viewfinderSize.width < viewfinderSize.height) ||
   scaledPreview.width < scaledPreview.height && viewfinderSize.width > viewfinderSize.height){
   dx = (scaledPreview.height - viewfinderSize.width) / 2;
   dy = (scaledPreview.width - viewfinderSize.height) / 2;

   return new Rect(-dx, -dy, scaledPreview.height - dx, scaledPreview.width - dy);
   }

dx = (scaledPreview.width - viewfinderSize.width) / 2;
dy = (scaledPreview.height - viewfinderSize.height) / 2;
return new Rect(-dx, -dy, scaledPreview.width - dx, scaledPreview.height - dy);

I'm guessing that the issue is in the isRotated() function in DisplayConfiguration. Since this is a tablet, I'm guessing the "natural" orientation is landscape, which may not be handled correctly. Does it work if instead of your fix, you switch around the result of isRotated()?

Yes, when i changed result in isRotated it works :)

Thanks, that's good to know. Then I just need to figure out how to detect the natural orientation, so that isRotated() can work correctly on all devices.

You can check it here:
http://stackoverflow.com/questions/4553650/how-to-check-device-natural-default-orientation-on-android-i-e-get-landscape
Anyway, thanks for fast reply. Good work!

Will you please test with the latest version? Should be fixed in the 2d09eca09431 commit.
It now uses the same logic as for Camera#setDisplayOrientation() to determine whether or the preview is rotated against the display, which removes the need to determine the device's natural display orientation (only the relative orientation matters).

I'll test it tomorrow morning and I'll let you know

Added another fix in #522414fa30cb1662f (rotation of the image for decoding). Please also check that the ResultPoints (yellow dots) match up with the barcode.

It's working well right now :+1:

Great, thanks for the report and testing.

Hi. I have a similar problem but on my Sony Xperia Z1 Compact. I changed the orientation to vertical and aspect ratio went wrong. It strethes the picture

Here is the code:
IntentIntegrator scanIntegrator = IntentIntegrator.forFragment(this);
scanIntegrator.setOrientation(ActivityInfo.SCREEN_ORIENTATION_SENSOR_PORTRAIT);
scanIntegrator.setCaptureLayout(R.layout.custom_capture_layout);
scanIntegrator.setPrompt("");
scanIntegrator.initiateScan();
And as you see, the scanning area is rectangular. How can i make it square? I also tested it on Nexus 5, and everything was great, the scanner was square and aspect ratio was perfect.
Also, could you give me an advice. I need to set up flashlight along with your scanner, but when I'm trying to connect to camera it drops. Is that possible to use the same camera connection as your library?

About using torch: I don't know is it possible to run it from Intent right now. I mean default CaptureActivity has build in torch toggle on volume keys.
Imho you'd create your own CaptureActivity and set up:
barcodeView.setTorch(true);

@zavernutiy
Please try the 3.x branch - the orientation/aspect-ratio issues should be fixed there. Note that you will then have to set the orientation in AndroidManifest.xml instead of through IntentIntegrator (instructions in the readme of the branch).
The flashlight can be managed in one of two ways:

Set cameraSettings.setAutoTorchEnabled(true). AmbientLightManager will then automatically turn the torch on/off depending on the ambient light.

Use barcodeView.setTorch(true/false);. This only works if autoToch is not enabled.

Both of the above requires you to create a custom Activity for scanning currently. You can have a look at the CaptureActivity to see how it works.

Thanks, I will try. And let you know if i succeed!

Thanks a lot! Everything is working perfectly.


Feature: added framework selection in url

Preface
I wanted to share a link to component-party.dev highlighting a difference between two frameworks. But there is no way to transfer the selected frameworks via url.
Proposed Solution
https://component-party.dev/?f=react-angular#minimal-template
Changes

added url search parameter ?f=svelte-react
combined local storage with url 'storage':

initial load with local storage and url prefers url parameters (localstorage is only overwritten after framework selection change)
change of selected frameworks updates local storage + url

url-safe dash separator (, got url-safe encoded)
works together with location hash

Discussion Points

list separator (- for now)
search parameter name (?f= as shorthand)
search parameter/local storage synchronization
history updating (using replaceState)

Yep I think I did a mistake using local storage first...
The best thing I can think of is:

URL query first
When user is clicking on frameworks, update URL query (history replaceState) & store in local storage
If no query is passed in the URL, use local storage

Hey @matschik didn't catch your message there. I implemented it like you described it or am I missing something?

Hi @jotoh98 ! It's been a while but since your PR, I was not 100% satisfied since the URL would be quite long and mixed with the hash anchor parameter.
It was hard to make a choice but I chose this: the query param "f" param in only handled on app initialization (multiple with "," separator).
You can see the changes here: https://github.com/matschik/component-party/commit/d16b17e99544fcd2d214936effb9f48087ccbfc4
Disadvantage: to make a shareable link, you need to make the url param manually.
Solution: Adding a button to copy a shareable link (but idk where I can put this button)
Thanks a lot for the inspiration ! I hope it's fine for you.


Update go.mod

Update go.mod file to reflect new repo location.

You need more than rename in go.mod file, also we must rename references in all files (import section)
I left old name for keep reference to existing versions. I'll change name now and release new version.

done in 403d1059

released v0.4.0 - https://github.com/faceterteam/onvif4go/releases/tag/v0.4.0


XCode 9 support

XCode 9 is not working!!

Closing as this is a duplicate of #129. This plugin cannot be fixed for Xcode 9 - it doesn't load plugins that aren't signed by Apple anymore.


[CHORE] Rename virtual env folder to .venv

I think .venv is sort of better than venv,  this explained well in PEP 704:
The name .venv was picked since it:

does not conflict with any valid Python import name
does not conflict venv module in the standard library
has pre-existing usage in the Python community
has support for auto-detection in common text editors
can be typed without modifier keys on common keyboard layouts

Another important motivation is that maturin will offer some automatic support when using .venv.

Do we have workflow to automatically label PRs, and if so, it doesn't look like it's working properly. 🤔

Do we have workflow to automatically label PRs, and if so, it doesn't look like it's working properly. 🤔

We do! But there looks like theres some permission issue with external contributors. Broken CI run.

@jaychia Let's look into fixing the release drafter for third parties this week?

@jaychia Let's look into fixing the release drafter for third parties this week?

This should fix the CI job for auto-populating labels: https://github.com/Eventual-Inc/Daft/pull/2138
@MeepoWin let's see if the next few PRs pass the new CI step!


Error when using Show with more than one direct child element

Describe the bug
In my app I have a list of items and a few toggles to customize the displayed output of each item. Solid will sometimes remove/hide incorrect parts of the displayed output text, compared to what is intended, and eventually crash with a DOM exception. I think I have narrowed it down to using a <Show> component with more than one direct child.
Your Example Website or App
https://playground.solidjs.com/anonymous/2a8653d0-8524-4a21-8c70-4c68f6e9024a
Steps to Reproduce the Bug or Issue

Go to the playground link
The app shows a list of 3 items, with 3 toggles (signals) to customize the printed display of the items: show/hide ID, show/hide Name, show/hide number of Related items. The initial state of the display toggles is to show only Name.
Click "ID off" button to turn on the ID display. Then click "Related IDs off" to turn on the Related ID display.
Observer that wrong parts of the output are hidden (incorrect DOM nodes are removed)
If you play around with toggling the buttons on/off, it will eventually cause a DOM operation exception. I have not fully looked into the generated Solid output to see what exactly is happening.

Expected behavior
Expected display after following the 3 steps:
M-1: Model 1 (2)
M-2: Model 2 (1)
M-3: Model 3 (0)

Actual display:
M-1: (2)
: M-2 (1)
M-3: Model 3 (0)

Screenshots or Videos
No response
Platform

OS: Windows 10
Browser: Chrome & Firefox
Version: Latest

Additional context
If you change the <Show> component on lines 66-69 from
<Show when={showId()}>
      {model.ID ?? "-"}
      <Show when={showName() || showRelatedId()}>: </Show>
 </Show>

to
<Show when={showId()}>
<span>
      {model.ID ?? "-"}
      <Show when={showName() || showRelatedId()}>: </Show>
</span>
 </Show>

That is, if you wrap the contents in a <span>, the behavior works as expected. I am not sure if the root cause here is that <Show> does not work correctly with more than one child element, but that seems to have fixed the issue in this case.

Yeah this is a regression in 1.7.x. My bad. I was trying to optimize something for hydration around textNodes and it seems to have broken this case.


fixed SSLv3 version

Fix for APN connection failing with message SSL_connect SYSCALL returned=5 errno=0 state=SSLv3 read server session ticket A

@dmkl This looks good, except for the fact that Ruby 1.9.3 seems to not accept the new argument (see travis failed job).
Can you fix it before merging?
I'd also like to know what is this exactly changing and which are the implications.
Cheers!

@calonso yes, sorry, I opened a PR too early. I will fix it for my project first and update it then. Let's close it for now.
There is a weird problem with SSL. Not all, but many pushes fail with SSL_connect SYSCALL returned=5 errno=0 state=SSLv3 read server session ticket A error message.

@dmkl According to this thread(https://github.com/grocer/grocer/issues/88), it can also be that your certificate is expired, but testing different security mechanisms to see which ones work sounds interesting.
The thread says that TLSv1 is the only supported in both production and sandbox, could you confirm that?

@calonso it seems that TLSv1 doesn't fix my problem, request still fails with the same SSL_connect SYSCALL returned=5 errno=0 state=SSLv3 read server session ticket A. I will close this PR for now.


Updated Artifactory doc to version 5.11.1 on dcos 1.11

Assigning myself to this one, but my Enterprise and Pro licenses have expired. Followup up with JFrog so I can complete the review of this.

Hi Elizabeth,
Thanks for checking this PR.
You can get a free-trial licenses from https://jfrog.com/artifactory/free-trial/
For Enterprise license, I would request DCOS's partnership team to contact JFrog.
Thanks again.

I already exhausted my automatic free licenses via that request form, I also dropped you an email directly, so hopefully we can figure something out :smile:

I have requested for some help to get you a trial license. Will update as soon as I get one.
Not able to locate your direct email so far.

On Jun 7, 2018, at 2:55 PM, Elizabeth K. Joseph<EMAIL_ADDRESS>wrote:
I already exhausted my automatic free licenses via that request form, I also dropped you an email directly, so hopefully we can figure something out 😄
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/dcos/examples/pull/361#issuecomment-395578112, or mute the thread https://github.com/notifications/unsubscribe-auth/Ahc95AvACHUnh_Ul3vE-t5d9WP-hv0zGks5t6aFegaJpZM4UZe3p.

--
https://jfrog.com/resources/upcoming-webinars/?utm_source=email&utm_medium=signature_banner&utm_campaign=upcoming_webinarshttp://

Tested the pro version and will run through EE tomorrow.


Using the EmailConfirmationGuard

https://github.com/thoughtbot/clearance#extending-sign-in
I have a question about the EmailConfirmationGuard as a SignInGuard. Because of the stack of the SignInGuard's, it will always fail for logins that don't exist, wrong passwords, etc.
I'm currently experiencing this now
What is the recommended way to alleviate that without rewriting the usual SignInGuard checks that don't get fired?

I ran into a similar issue. To solve it, I had to check if the user was not signed in and let another guard (in this case Clearance's DefaultSignInGuard) handle the failure.
Something like this:
class ActiveUserGuard < Clearance::SignInGuard
  def call
    if !signed_in?
      next_guard
    elseif current_user.active?
      next_guard
    else
      fail("Some message.")
    end
  end
end

Thanks :)


Mesh Wizard schema update

This update brings the Mesh YAML output up to speed with the new Mesh Object structure.

@jakubdyszkiewicz I'm encountering a couple issues I could use your help with.
I'm getting a YAML error in the command line when I try to create a new Mesh. Using your example from here I ran the below command:
echo "type: Mesh
name: mesh-12
mtls:
  enabledBackend: ca-1
  backends:
  - name: ca-1
    type: builtin
tracing:
  defaultBackend: zipkin-1
  backends:
  - name: zipkin-1
    type: zipkin
    config:
      url: http://zipkin.local:9411/api/v1/spans
logging:
  backends:
  - name: file-tmp
    format: '{ "destination": "%KUMA_DESTINATION_SERVICE%", "destinationAddress":
      "%UPSTREAM_LOCAL_ADDRESS%", "source": "%KUMA_SOURCE_SERVICE%", "sourceAddress":
      "%KUMA_SOURCE_ADDRESS%", "bytesReceived": "%BYTES_RECEIVED%", "bytesSent": "%BYTES_SENT%"}'
    type: file
    config:
      path: "/tmp/access.log"
  - name: logstash
    type: tcp
    config:
      address: logstash.internal:9000
metrics:
  enabledBackend: prometheus-1
  backends:
  - name: prometheus-1
    type: prometheus
    config:
      path: "/metrics"
      port: 1234" | kumactl apply -f -

and it gives me this error:
Error: YAML contains invalid resource: json: cannot unmarshal string into Go value of type v1alpha1.isLoggingBackend_Type

If I remove the logging part of the above and try:
echo "type: Mesh
name: mesh-12
mtls:
  enabledBackend: ca-1
  backends:
  - name: ca-1
    type: builtin
tracing:
  defaultBackend: zipkin-1
  backends:
  - name: zipkin-1
    type: zipkin
    config:
      url: http://zipkin.local:9411/api/v1/spans
metrics:
  enabledBackend: prometheus-1
  backends:
  - name: prometheus-1
    type: prometheus
    config:
      path: "/metrics"
      port: 1234" | kumactl apply -f -

The Mesh is created, but when I view it via curl or in the GUI, it's missing all of the mTLS and tracing information that was in the YAML I applied:
type: Mesh
name: mesh-12
creationTime: '2020-05-04T21:07:20.7866917Z'
modificationTime: '2020-05-04T21:07:20.7866917Z'
mtls:
tracing:

@jakubdyszkiewicz please disregard the above. I'm pretty sure this occurred because I was running an older version of kumactl and not referencing it via ./kumactl in bin.


Now able to run the mindy executable from any current working directory.

I noticed that I wasn't able to run the program from outside the bin folder, files were not being found because it seemed the "../" was stepping up from the current directory. I changed it to get the current working directory and append the rest of the file directories for config and log files.

This still needs some tweaking...


Native modules with 32-bit

Hi, sorry if there is already a way to do this, but I cannot find it. I've got native modules and i need to build a 32-bit version of the app on a 64-bit machine. Now I've done all the easy things like running the packager with --ia32 which makes the app 32-bit but it still seems to pull the 64-bit versions of the native modules from npm. I've even found that bit of the code that looks like it should handle this in electronBuilder, where it checks to see if the modules need rebuilding because of an arch change.
const rebuild = platformMatches && context.arch !== this.lastRebuild.arch;
but I cannot seem to set the context arch to 32-bit.
I even get this mixture of saying 32-bit and 64-bit in the logs

DEBUG  electronBuilder:  calling installOrRebuild from electron-builder for arch x64
Rebuilding native production dependencies for win32:x64
...
Parameter format not correct -
...
INFO  electron-packager:  packaging 'Capitalise' for platform 'win32-ia32' using electron v1.4.16

I left the "Parameter format not correct -" because I'm not sure if it's relevant or not.
Is there somewhere else that I need to set it as 32-bit seems slightly odd that I would have to but I'm very willing to if thats the case.

Just after writing this I think I have found at least some offending code.
return this.$.electronBuilder.installOrRebuild('x64');
To me this looks hardwired to build all modules at 64-bit

Hey,
when using build-installer it should work - I am building 32 bit versions of my project with binary deps and it works correctly.
When using package indeed the line you have found is not correct - this will be fixed within 2 days.

Ahh excellent, yes i only use package. When i tried using the installer it gave me some error that I couldn't figure out, also I quite like having a full tool like inno to build the actual installer from the exe file. Thanks for getting back to me on this.

Tried it yesterday btw it worked perfectly. Thanks.

Forgot to notify you. You've used the 0.8.1?

Yeah no worries I checked and saw that there was a new version and gave it a go. Yes I've used it created a 32-bit version and everything seems to work now, should have users using it soon, so that will be the first test actually on a 32-bit machine so will know more then.

Great 👍
Sorry you had to wait a few days for that.

Ahh no worries i was on holiday and you timed the fix perfectly for me so I had no pressure to work whilst i was meant to be relaxing.

Can this be closed?

Yes absolutely, i've had live copies of both architectures out there for a 9 months now :).

Great :)


Only accepting ALIVE changes from unknown trusted writers <1.9.x> [7586]

When a participant with a fixed id is deleted and recreated on the same process, other participants may ignore him because:

When being deleted, more than one DATA(p)[UD] may be sent, and on the other participant

The first one makes the matched_writer be removed, and history_record is correctly updated
When the second one is processed, it is accepted (as the writer id is trusted) and the guid of the writer is added to the history_record with a sequence number of (usually) 2. It is passed to the PDPListener callback, which will do nothing, as it refers to an already removed participant

When the participant is created again, the DATA(p) announcing it (with sequence number 1) is received by the other participant, but the history_record has an entry with the same guid and sequence number 2, so the DATA(p) is discarded.

This PR fixes this behavior by only allowing ALIVE changes from unknown trusted writers. With this PR, the second DATA(p)[UD] will be discarded, and then the history_record will not be modified.

Build status:

Linux
Mac
Windows

Reuilding after changes on base branch

Build status:

Linux
Mac
Windows


Patch - Release 3.7.0

Merged https://github.com/cengage/react-magma/pull/1189 instead of this one (almost identical, but that one had a few more updates to the changelogs)