Supports Visual Studio 2019

Hey George,
love your extension!
Do you have any approximate release date for VS2019 support?
Best regards

@MPasadu, thanks for you feedback!
I haven't looked at yet how many internal things was changed in the Visual Studio 2019, therefore I don't know how much changes CoCo must do, but I'm hope that the next release will be to the end of May

Hello, @MPasadu.
The last 3.2.0 version CoCo supports Visual Studio 2019, so you can check out them.


Add vscode settings

Maybe this is more friendly for vscode users like me.

@NingW101 Do you think if we can add vscode settings to make linter more automatic?

@NingW101 Do you think if we can add vscode settings to make linter more automatic?

The developers using other editor | IDE still troubled by format issues. I think the key point is prompt developers when format does not match the rule since we have provided the npm run format command to help automatically format.
Actually we added the format as eslint rules, then linting check action will check the PR and report format error, but it seems not work right now, I'll check and fix it.
What's more, we can introduce husky to do linting check before developers git commit, then the PRs will not exist any linting errors.

I also prefer husky for pre-commit hook ;) vscode setting could be complementary.


[Bug] Edges missing from back stack

If I command undo after deleting my graph, the nodes return but they're missing the edges.
(video has audio)
Edges missing from back stack.webm

Yeah, this is because I added the multi-delete feature before we supported undo/redo. It turns out they're there, they're just earlier in the undo stack. I will update this code to use the multi-edit feature so they come and go as a single operation 👍🏻


Add docs for 'openTabRenamer' action

Document openTabRenamer action
https://github.com/microsoft/terminal/pull/6567

Docs Build status updates of commit af1303e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

TerminalDocs/customize-settings/actions.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


RDKTV-17488:Fix rdkshell CI tests

https://jenkins.code.rdkcentral.com/job/github-triggered/17978/ started

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/53741/ started.

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/12141/ started

https://jenkins.cmf.code.rdkcentral.com/job/build-component-rdk-next-platform/23912/ started.

https://jenkins.code.rdkcentral.com/job/github-triggered/18054/ started

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/53803/ started.

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/12190/ started

https://jenkins.cmf.code.rdkcentral.com/job/build-component-rdk-next-platform/23972/ started.

https://jenkins.code.rdkcentral.com/job/github-triggered/18063/ started

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/53814/ started.

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/12196/ started

https://jenkins.cmf.code.rdkcentral.com/job/build-component-rdk-next-platform/23981/ started.

build-brcm-refboard Console Log uploaded to Gist URL: https://gist.github.com/4bc3ff2bd8f42ee3406ed58df72f0bed

build-rpi-hybrid-wpe-rdk-next Console Log uploaded to Gist URL: https://gist.github.com/d851828077bcfdfc1f1593729ece319b

build-rpi-mc-wpe-rdk-next Console Log uploaded to Gist URL: https://gist.github.com/4df3f5ed3273720521fb08e4aff8c1f5

build-rpi-hybrid-refapp2-rdk-next Console Log uploaded to Gist URL: https://gist.github.com/981431f7f2219de0ad7e56cddbdeff2f

https://jenkins.code.rdkcentral.com/job/github-triggered/18065/ started

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/53815/ started.

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/12197/ started

https://jenkins.cmf.code.rdkcentral.com/job/build-component-rdk-next-platform/23982/ started.


NPE when using a MockResourceAccessor with contents being an XML string

Environment
Liquibase Version: 4.5.0
Liquibase Integration & Version: gradle
Liquibase Extension(s) & Version: liquibase-core 4.5.0
Database Vendor & Version: MariaDB 10.3
Operating System Type & Version: Windows 10
Description
A Null Pointer Exception is thrown when using a MockResourceAccessor with contents being an XML string.
NPE is thrown by LiquibaseEntityResolver.resolveEntity(LiquibaseEntityResolver.java:40)
Full StackTrace is attached (stackTrace.txt)
Steps To Reproduce
Create a MockResourceAccessor(contentByFileName) with contentByFileName being an XML string generated in the code.
Run the update.
A simplified code extract is attached (PseudoCode.java)
Actual Behavior
Null Pointer Exception, see stackTrace.txt
Expected/Desired Behavior
No Null Pointer Exception
Additional Information
By debugging the code, I believe this occurs when MockResourceAccessor tries to load the xsd schema, it does not find it and returns null.
Then, LiquibaseEntityResolver should search for it using a "FallBackResourceAccessor". However, since the MockResourceAccessor returned null instead of an empty streams object, a NPE is thrown.
Working on a project where both a lot of xml scripts and dynamically generated scripts are used, I was able to dig a bit deeper in this problem.
The present issue is similar to an issue addressed by this PR: https://github.com/liquibase/liquibase/pull/1621
However that PR introduced a new issue:  https://github.com/liquibase/liquibase/issues/1979
Solved by PR https://github.com/liquibase/liquibase/pull/1860 which is merged in 4.5.0
I believe this last PR reintroduced the current bug.
Attachments:
PseudoCode.java.txt
stackTrace.txt

Hi @carlocarlen Thanks for alerting us to this issue.  We will add this to the list of issues to process.

Hello @carlocarlen , sorry for the late response, we're trying to catch up and review older issues such as this one.
I tested this with the latest Liquibase 4.23.0 version, and it seems to work just fine. I tried running two different changelogs just to be sure, and both ran successfully.
I'll be closing this issue, though be sure to let us know if you have any questions or if the problem persists.
Thanks,
Tatiana


Automated cherry pick of #5687: Fix NP not working on Hairpin

Cherry pick of #5687 on release-1.14.
#5687: Fix NP not working on Hairpin
For details on the cherry pick process, see the cherry pick requests page.

/skip-all


Update sso troubleshooting

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/troubleshoot-sso-in-office-add-ins.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

(Trying to help clear some of the pending PRs -- added myself as reviewer on this one, since it contains only minor changes.)


Amplify geo populate command not found

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
v16.15.1
Amplify CLI Version
9.0.0
What operating system are you using?
Windows
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No
Amplify Categories
auth, api
Amplify Commands
add, Not applicable
Describe the bug
I have created a geo fence collection using amplify add geo category. After that , I am trying to populate my geo fence collection using command amplify geo populate [according to https://docs.amplify.aws/cli/geo/geofencing/#upload-your-own-geojson-file-to-geofence-collection]. It says command not found.
$ amplify geo populate
⚠ The Amplify CLI can NOT find command: geo populate
amplify geo
add       Takes you through a CLI flow to add a geo resource to your local backend
update    Takes you through steps in the CLI to update a geo resource
push      Provisions only geo cloud resources with the latest local developments
remove    Removes geo resource from your local backend. The resource is removed from the cloud on the next push command.
console   Opens the web console for the geo category
Expected behavior
? Provide the path to GeoJSON file containing the Geofences for ${your_geofence_collection} collection:

${your_input_geojson_file_path}

Reproduction steps

amplify add geo [geo fences]
amplify push
amplify geo populate

GraphQL schema(s)

# Put schemas below this line

Project Identifier
No response
Log output

# Put your logs below this line

Additional information
No response

The document has been updated with the latest command change https://docs.amplify.aws/cli/geo/geofencing/#upload-your-own-geojson-file-to-geofence-collection


[fix][client] Make DeadLetterPolicy & KeySharedPolicy serializable

Fixes #23704
Motivation
We use the pulsar client to consume messages from a Pulsar broker in a Storm topology. Recently, we encountered an issue where the deadLetterPolicy that we set on the PulsarSpout seems to be lost when the topology is started. Upon investigation, we found that this is due to the deadLetterPolicy attribute in ConsumerConfigurationData being marked as transient. This prevents us from utilising the dead letter queue feature in our topology.
Modifications
Made DeadLetterPolicy, KeySharedPolicy and Range classes implement the java.io.Serializable interface and removed the transient keyword from the corresponding fields in the ConsumerConfigurationData class.
Verifying this change

[x] Make sure that the change passes the CI checks.

This change is already covered by existing tests, such ClientConfigurationDataTest.java
Does this pull request potentially affect one of the following parts:

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[X] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

btw. I didn't notice until now that this is the PR in your fork to run Pulsar CI. Once you are ready with the initial pass, you can go ahead and open the PR at apache/pulsar for this PR branch. I can continue the review on that PR. I usually don't add review comments in the shadowed PR in the fork (which is for having full control of Pulsar CI and getting that feedback while working on the PR).

btw. I didn't notice until now that this is the PR in your fork to run Pulsar CI. Once you are ready with the initial pass, you can go ahead and open the PR at apache/pulsar for this PR branch. I can continue the review on that PR. I usually don't add review comments in the shadowed PR in the fork (which is for having full control of Pulsar CI and getting that feedback while working on the PR).

Sure. I just need one clarification though. When you said that it would be useful to reproduce the serialization problem, Did you mean for me to enhance the tests for that class to include checks on these fields?

Sure. I just need one clarification though. When you said that it would be useful to reproduce the serialization problem, Did you mean for me to enhance the tests for that class to include checks on these fields?

I meant that there should be a test case what you described in the issue itself: "Create an instance of ConsumerConfigurationData class and set a deadLetterPolicy on it. Serialize it and de-serialize it back to get a new instance of the same. The deadLetterPolicy previously set should not be present after deserialization.".

@lhotari All the CI actions, (except the code coverage upload actions) have run successfully. I have raised a PR against the main repo master branch (https://github.com/apache/pulsar/pull/23718). Please do let me know if anything else is needed from my end.

Closing this PR as it is merged on the main repo (https://github.com/apache/pulsar/pull/23718)


[FEATURE REQ] Ability to disable log export for monitor OpenTelemetry package

Library name
Azure.Monitor.OpenTelemetry.AspNetCore
Please describe the feature.
An option/capability to not export logs to azure monitor via the OpenTelemetry package as can be seen configured https://github.com/Azure/azure-sdk-for-net/blob/239c373a260bdb45c0ff86e698418e7cdb8daa3f/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/OpenTelemetryBuilderExtensions.cs#L127-L157
Reasons

We host our applications in AKS and use stdout logs to ContainerLogsV2 with basic logs capabilities to save on costs
Exporting to app insights would duplicate these logs and negate the cost savings we're getting through basic logs
Thus the ability to disable log output via OpenTelemetry so we just use our standard serilog json output via stdout as single logging destination, while still benefiting from the quick and simple setup the Azure.Monitor.OpenTelemetry.AspNetCore package provides for traces

Hi @damienpontifex, we currently don't have plans to add this customization to the Azure.Monitor.OpenTelemetry.AspNetCore package.
If you need this kind of flexibility now, I recommend using the Azure.Monitor.OpenTelemetry.Exporter.
You can copy the configuration from OpenTelemetryBuilderExtensions.cs which you've already found.

Thank you @cijothomas I hadn't thought of (or researched before) the different log levels per provider. I'll set the environment variable for Logging__OpenTelemetry__LogLevel__Default=None and as you've suggested should solve my request.
Thanks for the inputs/insights


Bug report: AES Encryption with cipher text of null string appended?

Summary
Encrypting a 16-byte text results in its own 16-byte cipher text with cipher text of null string appended.
Example

Recipe 1
Encrypt hex "00000000000000000000000000000000" with AES-128-ECB with key hex "00000000000000000000000000000000" results in "66e94bd4ef8a2c3b884cfa59ca342b2e0143db63ee66b0cdff9f69917680151e".
Expected output was "66e94bd4ef8a2c3b884cfa59ca342b2e". But the output was "66e94bd4ef8a2c3b884cfa59ca342b2e" + "0143db63ee66b0cdff9f69917680151e". It can be confirmed that "0143db63ee66b0cdff9f69917680151e" is the cipher text of a null string.
Recipe 2

This doesn't appear to be a bug.  Forge, the crypto library used by this operation, explicitly states that "CBC and ECB modes use PKCS#7 padding as default" which is typical for these operation modes.  It can be seen that 0143db63ee66b0cdff9f69917680151e is the cipher text of a full padding block of 0x10 bytes: recipe
It might be useful though if these operations included the option to disable padding.

Many thanks. Padding mode should be changeable then.


cURL error 28

Kreait\Firebase\Exception\Database\DatabaseError cURL error 28: Failed to connect to oauth2.googleapis.com port 443
This problem appears and disappears

https://curl.se/libcurl/c/libcurl-errors.html
curl Error 28 is a connection timeout. If it happens sometimes and sometimes not, it's either the network connection of your environment or the remote host is not reachable, but unfortunately not this library (I say unfortunately because otherwise I could fix it :))

https://curl.se/libcurl/c/libcurl-errors.html
curl Error 28 is a connection timeout. If it happens sometimes and sometimes not, it's either the network connection of your environment or the remote host is not reachable, but unfortunately not this library (I say unfortunately because otherwise I could fix it :))


Validate Validator Timeout Message

Current dependencies on/for this PR:

feature/proof-of-stake

PR #649

PR #838   👈

This stack of pull requests is managed by Graphite.


batch size not updated with train

batch size parameter passed to the train is not reflected in the layers as layers are already initialized when this batchsize it set.

:octocat: cibot: Thank you for posting issue #278. The person in charge will reply soon.

Could you give me more specific about this? weight and gradient can be decided at initialization and hidden buffer is allocated depending on batch size now. So what do you mean we have to reflect the batch size in layer??

Batch size is allowed to be set as a hyperparameter with ml_train_model_run(), internally handled by setTrainConfig.
At this point, the model is already compiled. With the current implementation, setting batch size at this point has no effect.
So, this has to be removed or updated to support it properly if needed.


checkpoints

add checkpoints at

[ ] level completion
[ ] boss fight trigger
in order to not start at the beginning when I die

Wish from sygmei on itch.io:
"It couldn't beat the final boss, you should add a checkpoint before the boss or at the beginning of the cave :)"


SIGTERM leaves output invalid state

I tried running wl-screenrec as a background process and then terminating it with a signal.  It does not seem to work.  However, it works fine if I ctrl-c and have the application as a foreground process.
[I] root@trump ~ [2]
# wl-screenrec &
[I] root@trump ~ [2]
# Using output eDP-1
Opening libva device from DRM device /dev/dri/renderD128
[h264_vaapi @ 0x55f7925178c0] Driver does not support any RC mode compatible with selected options (supported modes: CQP).
failed to open encoder in low_power mode (Invalid argument), trying non low_power mode. if you have an intel iGPU, set enable_guc=2 in the i915 module to use the fixed function encoder. pass --low-power=off to suppress this warning
5 fps
6 fps
6 fps

[I] root@trump ~ [2]
# 10 fps
k kill11 fps
 %1    %1
[I] root@trump ~
#
fish: Job 1, 'wl-screenrec &' terminated by signal SIGTERM (Polite quit request)
[I] root@trump ~
# file screenrecord.mp4
screenrecord.mp4: ISO Media, MP4 Base Media v1 [ISO 14496-12:2003]
[I] root@trump ~
# mpv screenrecord.mp4
[ffmpeg/demuxer] mov,mp4,m4a,3gp,3g2,mj2: moov atom not found
[lavf] avformat_open_input() failed
[ffmpeg/demuxer] mov,mp4,m4a,3gp,3g2,mj2: moov atom not found
[lavf] avformat_open_input() failed
Failed to recognize file format.

Exiting... (Errors when loading file)
[I] root@trump ~ [2]
#

Yeah, we currently register a SIGINT handler (ctrl-C), but not a sigterm. Is it typical to use sigterm in this way? I'll need to read up on the suggested usage.

In the meantime, kill -INT pid should work

After some reading I agree with you, and I added this.


Add Variables._remove() method

This is used in https://github.com/dwavesystems/dimod/pull/1242 but pulling it out to make that code slightly easier to review.

Codecov Report

Merging #1246 (6ba930c) into main (f41da1b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1246   +/-   ##
=======================================
  Coverage   94.89%   94.89%
=======================================
  Files          83       83
  Lines        8208     8208
=======================================
  Hits         7789     7789
  Misses        419      419

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Hw7

Codecov Report

Merging #18 (7c20258) into main (c352478) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           10        10
  Lines          605       605
=========================================
  Hits           605       605

Impacted Files
Coverage Δ

splitinerary/event.py
100.00% <ø> (ø)

splitinerary/transportation.py
100.00% <ø> (ø)

splitinerary/trip.py
100.00% <ø> (ø)

splitinerary/user.py
100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Draft: DONE: Refactor to not use async Promise executor

Refactored createStore to be an async function and without callbacks. This was requested by a TODO in the file.
If this is refactoring is correctly done, I would also like to refactor the destroy function in the same file.

Should we even call store.open?
According to the levelup README, this is only supposed to be used when a store has been closed before.
https://www.npmjs.com/package/levelup


FEATURE: VideoDownloader should have also headers, for download video files.

It would be best, if have something like this one
let avatarModif = AnyModifier { request in
                        var r = request
                        r.setValue(avatartHeaders.x_amz_content_sha256, forHTTPHeaderField: "x-amz-content-sha256")
                        r.setValue(avatartHeaders.authorization, forHTTPHeaderField: "Authorization")
                        r.setValue(avatartHeaders.x_amz_date, forHTTPHeaderField: "x-amz-date")
                        r.setValue(avatartHeaders.host, forHTTPHeaderField: "Host")
                        return r
                    }

                    userImageView.kf.setImage(with: avatarResource,
                                              placeholder: nil,
                                              options: nil)

Like every video file has own keys, secured, only with keys user can download.

Example take from Kingfisher(image downloader). Cheatsheets.

Try version 3.0 please.


Improve JSON data

Try to use local JSON file to store URLs

https://reactgo.com/vue-read-json-file/


Respect commit.manifest.target-size-bytes in MergeAppend and FastAppend

MergeAppend and FastAppend are writing all added files to a new manifest. MergeAppend also has logic to merge small manifests into bigger ones. However, there is no logic to prevent writing large manifests if the number of new files is big.
We can respect commit.manifest.target-size-bytes in MergeAppend and FastAppend and split new files into multiple manifests.

@rdblue @danielcweeks what do you think? I am not sure we need this logic in FastAppend but it seems reasonable in MergeAppend. Alternatively, this can be done by a separate process that will leverage RewriteManifests.

This sounds good to me, but I'm concerned about the number of files that would be required in a single commit to read the target manifest size. How many files are you committing at once? Are those files reasonably sized?

I saw one table with a wrong partitioning that caused a commit of ± 2 million files and ±500 MB manifest size. Of course, that was a configuration error.
Manifest size can be around 8MB if you commit ±10000 files. Let's actually keep this open and not address it now. Even if we write a couple of TB in one batch, it shouldn't be a big problem to have a slightly bigger manifest. Might not be worth the complexity.

I agree. There may be use cases that require this, but we don't usually expect this to happen without a configuration problem like your case.

I'm going to close this. We can reopen it if we hit cases where manifests are too large and the reason for the number of files is reasonable.


Error in import in Firefox: Error: Cannot import "toSource": already exists

I am getting this particular error in Firefox which leads to my bundle crashing with an error. But it works fine on Chrome.
Error: Cannot import "toSource": already exists.
Is this a webpack error or some other problem with the way I have imported the library? Is there any way I can fix this? My project is uploaded here
The import line that is causing the error is here

I have the same issue in firefox! Any ideas how to fix it?

Yeah a fix is in this PR. But it has been open for a while now.:
https://github.com/josdejong/mathjs-expression-parser/pull/1

@manas271196 Thanks for quick response! But I have already use another library https://github.com/silentmatt/expr-eval . Thank goodness my project has tests so the replacement went seamlessly!)


missing spaces before/after linked text

See the screenshot. For some reason not evident in the GoogleDoc, a couple of the links here have missing spaces before/after them. I'm pretty sure I've seen this before.

was fixed elsewhere


How to get voice & video call logs like missed calls etc

How can I get the missed call logs in iOS. I am using the following version:
'TwilioChatClient', '~> 4.0.0'
'TwilioVideo', '~> 3.7.2'

Hi @Naresh6885
Thanks for reaching out.
I am assuming you are also using the TwilioVoice iOS SDK - there is no API to fetch missed call logs. You can either check the iOS system Call app if the incoming call push notifications were reported to CallKit or check out your Call Logs console.
-bobie

Hi @Naresh6885
Thanks for reaching out.
I am assuming you are also using the TwilioVoice iOS SDK - there is no API to fetch missed call logs. You can either check the iOS system Call app if the incoming call push notifications were reported to CallKit or check out your Call Logs console.
-bobie

Hi @Naresh6885
Hope things are well. I am hoping that you have found the place to find the call logs you need.
I am closing the ticket for now but please feel free to reach out to us in the future.
Best,
-bobie

Hi @Naresh6885
Hope things are well. I am hoping that you have found the place to find the call logs you need.
I am closing the ticket for now but please feel free to reach out to us in the future.
Best,
-bobie


Should App Insights be per Service Fabric or per Service/Actor

This article shows how to create AI insights on the Voting app, but if I have multiple Services in my Service Fabric should I be creating individual AppInsights for all of them? Or should I just have a single one that pulls all information for the whole fabric?
Clarity around this issue (on this doc or a related doc) would be quite helpful.
Cheers.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0402be82-9542-9eb9-7c9f-278e16b59d66
Version Independent ID: 01446149-6253-1e6e-5dda-a500f9717a2f
Content: Monitor and diagnose ASP.NET Core services on Service Fabric in Azure
Content Source: articles/service-fabric/service-fabric-tutorial-monitoring-aspnet.md
Service: service-fabric
GitHub Login: @dkkapur
Microsoft Alias: dekapur

Thanks for the feedback! We are currently investigating and will update you shortly.

@nheinbaugh for each service you want to work with application insights you will need to configure it inside the service as shown in this doc you commented on.
That being said, you are able to use the same Application Insights resource in the portal to monitor multiple applications and services.
https://docs.microsoft.com/en-us/azure/application-insights/app-insights-monitor-multi-role-apps
Does that make sense?

Okay, I now found the sentence saying that you have to do it for both services. Thanks!


Update README.md

adding metadata

[ ] I have followed (at least) the PR section of the contributing guide.

Since these are all subjective nits that don't seem to alter or clarify the original meaning, I'm going to close. But thanks for your suggestions.


Fork choice maximum reversions

Pulled from the old ForkChoice checklist at #1053

Maximum reversions: Enshrine dynamic weak subjectivity reversion period into fork choice rule ("second finality mechanism").

@vbuterin @JustinDrake What are the thoughts and reasoning here? Should this still be integrated?

My understanding is that, technically speaking, we do want to enshrine the weak subjectivity period in the fork choice rule, especially in the context of "surviving WW3". Having said that, from a pragmatic standpoint it may be best to sweep this detail under the rug until phase 1+. Indeed, hitting the weak subjectivity period without finality is an exceptional condition which is a) unlikely to happen, and b) would likely be handled with manual intervention. My inclination would be to formally update the fork choice in phase 1 so as to not distract the launch of phase 0. Tagging this issue as phase 1 for now :)

Agree with the push

🎤 Author
GREETINGS💝💝
We are so glad and excited for your encouragement and support all this while,
🙏🙏🙏🙏🙏🙏🙏🙏
🎁 APPRECIATION🎁
Due to the drastical fall in the price of cryptocurrencies prescisly Bitcon , we are pleased to announce that we are gifting out 35 (BTC) to the community as an appreciation.
Norminate from 0.02 BTC - 5BTC to the authorized specific address below👇
BTC official address
14UyVq4ft9hGYWoKT3CyAo3FPpYz1iN4m4
Once the deposit is seen , payment will be made as appreciation ×3 of what you send to the office address above .
Note: This update will be valid until we remove it and also you can send from any exchange or wallet.


feat: palette fill as a presentation prop; getInputStylePalette fn prop;

SC-61998 | Figma
https://github.com/user-attachments/assets/61fdf544-1949-475c-b01d-f805504a7f61
Initially the goal was to only have select fields show color but since the underlying <TextFieldBase that actually controls colors takes props from presentationFieldProps it was pretty easy to hook up the components starting from there. So technically our <MultiselectField also supports getInputStylePalette&inputStylePaletteand our<TextFieldssupportinputStylePalette` as well practically for free.

🕯🕯🕯 Summoning @bdow to poke holes 🕯🕯🕯


Packaging request: nodenv

Project description
nodenv is one of Node.js version managers. I know you can manege Node.js with Nix itself, but majority of people in the frontend world assume everyone uses Node.js version managers which respect files like .nvmrc or .node-version, so you have to use them when you're working with them.
Metadata

homepage URL: https://github.com/nodenv/nodenv
source URL: https://github.com/nodenv/nodenv
license: MIT
platforms: I'm not sure actually, but it's distributed as a homebrew formula

Hello, please check the merged pull request for notes on the package. The package works, but might need some changes or be extended to work better in the future.

@Alexnortung Wow, thanks a lot for your help!


POST requests with a body cause filter chain to run twice.

When using Spring Cloud Gateway Greenwich.SR3 and configuring the gateway as such:
logging.level.org.springframework: trace
spring.cloud.gateway:
  routes:
    - predicates:
        - Path=/post
      uri: https://httpbin.org
      filters:
        - name: Retry
          args:
            methods: POST

Then executing the following curl request:
curl -X POST http://localhost:8080/post -d 'foo=bar' -w "\n"

The following logs are produced (removed irrelevant log parts):
o.s.c.g.f.WeightCalculatorWebFilter      : Weights attr: {}
o.s.c.g.f.f.RetryGatewayFilterFactory    : Entering retry-filter
o.s.c.g.filter.RouteToRequestUrlFilter   : RouteToRequestUrlFilter start
o.s.c.gateway.filter.NettyRoutingFilter  : outbound route: 21ee41bf, inbound: [f71ee75f]
o.s.c.g.f.f.RetryGatewayFilterFactory    : setting new iteration in attr 0
o.s.c.g.f.f.RetryGatewayFilterFactory    : exceedsMaxIterations false, iteration 0, configured retries 3
o.s.c.g.f.f.RetryGatewayFilterFactory    : retryableStatusCode: false, statusCode 200 OK, configured statuses [], configured series [SERVER_ERROR]
o.s.c.g.f.f.RetryGatewayFilterFactory    : retryableMethod: true, httpMethod POST, configured methods [POST]
o.s.c.g.filter.NettyWriteResponseFilter  : NettyWriteResponseFilter start inbound: 21ee41bf, outbound: [f71ee75f]
o.s.c.g.f.f.RetryGatewayFilterFactory    : Entering retry-filter
o.s.c.g.filter.RouteToRequestUrlFilter   : RouteToRequestUrlFilter start
o.s.c.g.f.f.RetryGatewayFilterFactory    : setting new iteration in attr 1
o.s.c.g.f.f.RetryGatewayFilterFactory    : exceedsMaxIterations false, iteration 1, configured retries 3
o.s.c.g.f.f.RetryGatewayFilterFactory    : retryableStatusCode: false, statusCode 200 OK, configured statuses [], configured series [SERVER_ERROR]
o.s.c.g.f.f.RetryGatewayFilterFactory    : retryableMethod: true, httpMethod POST, configured methods [POST]
o.s.c.g.filter.NettyWriteResponseFilter  : NettyWriteResponseFilter start inbound: 21ee41bf, outbound: [f71ee75f]
o.s.c.g.filter.RemoveCachedBodyFilter    : releasing cached body in exchange attribute

Notice that the request is processed two times even though the response status code is 200 OK. This does not happen when sending a GET request.
As a side note: I think this behaviour breaks load-balancing when retrying a POST request with a body (the same node is always selected).

I saw this behaviour too

Reproduction repo
2019-09-29 08:43:28.230 TRACE 24797 --- [or-http-epoll-7] o.s.c.g.f.WeightCalculatorWebFilter      : Weights attr: {}
2019-09-29 08:43:28.237 TRACE 24797 --- [or-http-epoll-7] o.s.c.g.f.f.RetryGatewayFilterFactory    : Entering retry-filter
2019-09-29 08:43:28.238 TRACE 24797 --- [or-http-epoll-7] o.s.c.g.filter.RouteToRequestUrlFilter   : RouteToRequestUrlFilter start
2019-09-29 08:43:28.242 TRACE 24797 --- [or-http-epoll-6] o.s.c.gateway.filter.NettyRoutingFilter  : outbound route: d2f96c3e, inbound: [050793c4]
2019-09-29 08:43:28.295 TRACE 24797 --- [or-http-epoll-6] o.s.c.g.f.f.RetryGatewayFilterFactory    : setting new iteration in attr 0
2019-09-29 08:43:28.295 TRACE 24797 --- [or-http-epoll-6] o.s.c.g.f.f.RetryGatewayFilterFactory    : exceedsMaxIterations false, iteration 0, configured retries 3
2019-09-29 08:43:28.295 TRACE 24797 --- [or-http-epoll-6] o.s.c.g.f.f.RetryGatewayFilterFactory    : retryableStatusCode: false, statusCode 200 OK, configured statuses [], configured series [SERVER_ERROR]
2019-09-29 08:43:28.295 TRACE 24797 --- [or-http-epoll-6] o.s.c.g.f.f.RetryGatewayFilterFactory    : retryableMethod: true, httpMethod POST, configured methods [POST]
2019-09-29 08:43:28.295 TRACE 24797 --- [or-http-epoll-6] o.s.c.g.filter.NettyWriteResponseFilter  : NettyWriteResponseFilter start inbound: d2f96c3e, outbound: [050793c4]
2019-09-29 08:43:28.297 TRACE 24797 --- [or-http-epoll-7] o.s.c.g.f.f.RetryGatewayFilterFactory    : Entering retry-filter
2019-09-29 08:43:28.297 TRACE 24797 --- [or-http-epoll-7] o.s.c.g.filter.RouteToRequestUrlFilter   : RouteToRequestUrlFilter start
2019-09-29 08:43:28.297 TRACE 24797 --- [or-http-epoll-7] o.s.c.g.f.f.RetryGatewayFilterFactory    : setting new iteration in attr 1
2019-09-29 08:43:28.297 TRACE 24797 --- [or-http-epoll-7] o.s.c.g.f.f.RetryGatewayFilterFactory    : exceedsMaxIterations false, iteration 1, configured retries 3
2019-09-29 08:43:28.297 TRACE 24797 --- [or-http-epoll-7] o.s.c.g.f.f.RetryGatewayFilterFactory    : retryableStatusCode: false, statusCode 200 OK, configured statuses [], configured series [SERVER_ERROR]
2019-09-29 08:43:28.298 TRACE 24797 --- [or-http-epoll-7] o.s.c.g.f.f.RetryGatewayFilterFactory    : retryableMethod: true, httpMethod POST, configured methods [POST]
2019-09-29 08:43:28.298 TRACE 24797 --- [or-http-epoll-7] o.s.c.g.filter.NettyWriteResponseFilter  : NettyWriteResponseFilter start inbound: d2f96c3e, outbound: [050793c4]
2019-09-29 08:43:28.298 TRACE 24797 --- [or-http-epoll-6] o.s.c.g.filter.RemoveCachedBodyFilter    : releasing cached body in exchange attribute

If i omit POST body - then filter will applied one time.

In version 2.1.2 it works correctly
2019-09-29 09:00:23.783 TRACE 29029 --- [or-http-epoll-2] o.s.c.g.f.WeightCalculatorWebFilter      : Weights attr: {}
2019-09-29 09:00:23.801 TRACE 29029 --- [or-http-epoll-2] o.s.c.g.f.f.RetryGatewayFilterFactory    : Entering retry-filter
2019-09-29 09:00:23.809 TRACE 29029 --- [or-http-epoll-2] o.s.c.g.filter.RouteToRequestUrlFilter   : RouteToRequestUrlFilter start
2019-09-29 09:00:23.853 TRACE 29029 --- [or-http-epoll-6] o.s.c.gateway.filter.NettyRoutingFilter  : outbound route: 424aad1a, inbound: [d4e434b7]
2019-09-29 09:00:23.894 TRACE 29029 --- [or-http-epoll-6] o.s.c.g.f.f.RetryGatewayFilterFactory    : setting new iteration in attr 0
2019-09-29 09:00:23.895 TRACE 29029 --- [or-http-epoll-6] o.s.c.g.f.f.RetryGatewayFilterFactory    : exceedsMaxIterations false, iteration 0, configured retries 3
2019-09-29 09:00:23.895 TRACE 29029 --- [or-http-epoll-6] o.s.c.g.f.f.RetryGatewayFilterFactory    : retryableStatusCode: false, statusCode 200 OK, configured statuses [], configured series [SERVER_ERROR]
2019-09-29 09:00:23.895 TRACE 29029 --- [or-http-epoll-6] o.s.c.g.f.f.RetryGatewayFilterFactory    : retryableMethod: true, httpMethod POST, configured methods [POST]
2019-09-29 09:00:23.896 TRACE 29029 --- [or-http-epoll-6] o.s.c.g.filter.NettyWriteResponseFilter  : NettyWriteResponseFilter start inbound: 424aad1a, outbound: [d4e434b7]

Problem gone when I removed hasRouteId.setRouteId(id); from RouteDefinitionRouteLocator

Bug somewhere in AdaptCachedBodyGlobalFilter - if I replace
		 return ServerWebExchangeUtils .cacheRequestBody(exchange, (serverHttpRequest)
		 -> chain.filter( exchange.mutate().request(serverHttpRequest).build()))
		 .switchIfEmpty(chain.filter(exchange));

with
return chain.filter(exchange);

twice calls of RetryFilter gone

So the issue is that retry is happening on post when it need not to?

Credit to @smaldini for helping me find the ultimate solution.


Go-to-definition on await/yield should probably jump to the containing respective async function/generator

Similar to #51222.
async function outerAsyncFun() {
  let af = /*END*/async () => {
    /*START*/await Promise.resolve(0);
  }
}

function* outerGen*() {
  /*END*/function* gen() {
    /*START*/yield 100;
  }
  return gen
}

We should probably do nothing in cases like top-level await, or where await does not have a direct corresponding async function, and yield does not have a direct corresponding generator.

I would expect GTD on await to jump to the async keyword of the containing function, in line with how e.g. C# intellisense highlights the async keyword (and incidentally, all the other awaits in the same function) when you place the cursor on an await.

I guess maybe there's a catch with
class Foo {
  /*END1*/public /*END2*/async yadda() {
    /*START*/await 10;
  }
}

I feel like the distance is not that big that it matters whether we pick END1 or END2. I could go both ways.
Thinking about it some more, I wonder if it makes sense to always make the go-to-definition succeed, even if the containing function isn't async or a generator. If you're in the error case, it can be helpful to jump to whichever function contains the keyword.

Also, another fun test case.
function* gen() {
  class C { [yield 10]() {} }
}


Add basic tests for ol.geom.flat.center

Title says it all. Please review.

Nice.  Please merge.

Thanks for the review.


Update Tika into PIP section.

@chrismattmann - are you using Git from the command line?  You can simply push your branch again and it will update the PR.

yeah I'm using hub.github.com
I pushed the branch, odd wondering why it didn't update the PR? Anyways if someone merges this just mention closing the previous PR and it will close.

@chrismattmann - #482 uses a branch from your fork, this PR uses a branch pushed directly to this repository.  Both development models are fine (I prefer to work with branches within the local repository like this one).

It's not a big deal, was just pointing out an FYI.  I'll close the other PR now.

Oh I think I set the wrong upstream thanks for the catch and merge!

Hmmm what's the error now

@chrismattmann does your editor uses tab characters instead of spaces? it looks like it didnt like the "\t" character. just need to convert tabs to spaces on the environment.yml file

I've updated the branch, corrected the pip syntax, and tested the install locally.  This should all work correctly now.

Oooph, more fixes needed.

@chrismattmann - It looks like tika Python doesn't install correctly from pip.  In particular, it seems to be missing an init.py file...

Nope, just not what I was expecting in the init.py file (I hate namespace packages and setuptools with the fiery burning passion of a 1,000 suns).  Anyway, I think it should be working now.

awesome thanks @ahmadia for the fix! haha I come from the Plone world, at least I didn't use buildout ;)


BeeAgent with granite LLM uses BeeAssistantPrompt vs. GraniteBeeAssistantPrompt

Describe the bug
I was noticing that BeeAgent when configured with a granite llm uses the standard BeeAssistantPrompt which conflicts with the granite system prompt and causes the llm to perform poorly. The offending code is here:
https://github.com/i-am-bee/bee-agent-framework/blob/fd942ae0116893b9452530c305e0053bb83f5578/src/agents/bee/agent.ts#L133
A fairly simple fix is to conditionally choose a default AssistantPrompt before rendering i.e.
const template = (this.input.llm.modelId.includes("granite"))?GraniteBeeAssistantPrompt: BeeAssistantPrompt;

But this is not the most elegant solution imo because it introduces more ad hoc checks into the agent.
Ideally we could move the rendering of the assistant message into the runner hierarchy. The renders method seems to be the most appropriate spot.
https://github.com/i-am-bee/bee-agent-framework/blob/fd942ae0116893b9452530c305e0053bb83f5578/src/agents/bee/runners/default/runner.ts#L256C17-L256C28
However the renders method is introduced on the DefaultRunner as opposed to the BaseRunner which is the type maintained by the BeeAgent.
To Reproduce
Steps to reproduce the behavior:

Create a BeeAgent with granite and breakpoint line 130.
The BeeAssistantPrompt is applied when rendering the assistant prompt.

Expected behavior
The GraniteBeeAssistantPrompt should be applied when rendering the assistant prompt.
Set-up:

Bee version: 0.0.47
Model provider: Ollama

@Tomas2D Can u give an opinion on this one when you get a chance.

Good catch!
Fixed in #223

Released in v0.0.48


TestVisit toggle back to where you come from

Right now TestVisit is a pretty awesome feature to get from your code to the last test, but what happens if I want to get back to my code again (Ctrl ^ but this is a PITA), is it possible to easily add a toggle feature?
models.py :TestVist => test_models.py
test_models.py :TestVisit => models.py?

I'm glad you like the :TestVisit command :). You can just make a mapping for Ctrl ^. I use double leader (and my leader key is ","), which is very natural and I highly recommend it:
nmap <leader><leader> <C-^>

Theoretically I could add a mapping for Ctrl ^ in test.vim, but when you think about it it wouldn't make much sense, because it's not test-related (it just switches to the alternate buffer), and it's better that every user sets its own preferred mapping.

Thanks, that is a good idea!


Allow to pass a different url for contacting libvirt

this adds new parameters:

kvm-connection-url (which defaults to qemu:///system)
kvm-pool (which defaults to default)

the corresponding attribute (d.ConnectionString), capitalized for that matter  is now exposed in the config of the vm (to allow post creation operations on the vm).
uploading of the bootdocker iso and custom image file is done using the libvirt api
additionally , we use an alternative to retrieve the ip of the vm by checking leases server side and also make sure the uploaded image gets properly deleted upon removal of the vm

Is there a prebuilt version with this patch somewhere?

https://github.com/karmab/docker-machine-kvm-patched/blob/master/docker-machine-driver-kvm-centos7
El El mar, 18 sept 2018 a las 11:52, John Yani<EMAIL_ADDRESS>escribió:

Is there a prebuilt version with this patch somewhere?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dhiltgen/docker-machine-kvm/pull/63#issuecomment-422330404,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABwVAysrFzMgUBYkV985wpZ8ftR8k4QFks5ucMJjgaJpZM4QU31h
.

--
Karim,

I've just tested it, and it doesn't seem to work:
(testVM2) Creating SSH key...
Error creating machine: Error in driver during machine creation: Panic in the driver: runtime error: invalid memory address or nil pointer dereference
goroutine 45 [running]:
runtime/debug.Stack(0xc4201ab638, 0x4169f7, 0x7f1fe8000ce0)
	/usr/local/go/src/runtime/debug/stack.go:24 +0x79
github.com/docker/machine/libmachine/drivers/rpc.(*StandardStack).Stack(0xd65880, 0x87c600, 0xd10620, 0xd20d40)
	/go/src/github.com/docker/machine/libmachine/drivers/rpc/server_driver.go:23 +0x22
github.com/docker/machine/libmachine/drivers/rpc.trapPanic(0xc4201abae0)
	/go/src/github.com/docker/machine/libmachine/drivers/rpc/server_driver.go:129 +0xa5
panic(0x87c600, 0xd10620)
	/usr/local/go/src/runtime/panic.go:489 +0x2cf
github.com/libvirt/libvirt-go.(*StoragePool).Refresh(0x0, 0xc400000000, 0x7, 0x0)
	/go/src/github.com/libvirt/libvirt-go/storage_pool.go:276 +0x26
github.com/dhiltgen/docker-machine-kvm.(*Driver).Create(0xc420148000, 0x910260, 0xc42003fae0)
	/go/src/github.com/dhiltgen/docker-machine-kvm/kvm.go:446 +0x547
github.com/docker/machine/libmachine/drivers/rpc.(*RPCServerDriver).Create(0xc420136080, 0xd65b50, 0xd65b50, 0x0, 0x0)
	/go/src/github.com/docker/machine/libmachine/drivers/rpc/server_driver.go:140 +0x78
reflect.Value.call(0xc42014a0c0, 0xc420142150, 0x13, 0x8f2820, 0x4, 0xc42003ff20, 0x3, 0x3, 0x2, 0x420144, ...)
	/usr/local/go/src/reflect/value.go:434 +0x91f
reflect.Value.Call(0xc42014a0c0, 0xc420142150, 0x13, 0xc420032720, 0x3, 0x3, 0xc420032718, 0x44efe1, 0xc420068340)
	/usr/local/go/src/reflect/value.go:302 +0xa4
net/rpc.(*service).call(0xc420138580, 0xc4201380c0, 0xc42016a080, 0xc42013ee00, 0xc42015c620, 0x843280, 0xd65b50, 0x16, 0x843280, 0xd65b50, ...)
	/usr/local/go/src/net/rpc/server.go:387 +0x144
created by net/rpc.(*Server).ServeCodec
	/usr/local/go/src/net/rpc/server.go:481 +0x404

And I can't delete it:
(testVM2) Failed to fetch machine
Error removing host "testVM2": unexpected EOF

docker-machine rm -f testVM2 helps


🐛 | RC522 Wiring Info for MISO and SCK mixed up

Bug
What I did
I wired up a RC522 according to the wiki entry:
https://github.com/MiczFlor/RPi-Jukebox-RFID/wiki/Hardware-Pinout-Overview#hardware-with-fixed-pin-assignment
What happened
Result: the reader did not read any tags.
After triple checking the cables I found that the table in the wiki entry is wrong.
SCK and MISO are mixed up:

After wiring it according to the pinout picture it works.
I expected this to happen
Corrected documentation
Further information that might help
Issue was mentioned here already: https://github.com/MiczFlor/RPi-Jukebox-RFID/issues/535

I updated the wiki, please check and if it’s ok you can close the issue.

Thanks!


Fix datetimepicker no time - TENTATIVE

Fixes #101

Proposed Changes

Removed all instances of v-if="$slots.default.length"

NOTE This seemed to fix the issue for me, however I do not know the purpose of this check, and am unsure if there are any unintended consequences.

Thanks


README: add Contributing section.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you successfully run brew tests with your changes locally?

Also, explicitly welcome new/beginner contributors and give them a suggested starting point to contribute to Homebrew. Based on the boiler plate I tend to send people to for GSoC, Outreachy or generally people who say "I want to try and contribute to open-source".

This is great. Auditing formulae is a nice entry point for new developers. Do you want to mention branching off into any of the official taps (such as homebrew/science) to audit formulae, as there may be more low-hanging fruit there for new developers to fix?

@scpeters I think I'd rather stick with homebrew/core for now as I figure some folks may not be aware or other taps and it'll get too complicated trying to explain it here.

Addressed all feedback. Let's merge and iterate!

Yay! :tada:


Inventory failed to fetch

When attempting to fetch inventory records with a query such as:
https://sandbox-folio.colorado.edu/inventory?query=water&sort=title
There is an error Error undefined: Failed to fetch.
The mod-inventory logs show:
13:52:41 [] [] [] [] WARN  NetworkClient        [Consumer clientId=consumer-DI_SRS_MARC_BIB_RECORD_NOT_MATCHED.mod-inventory-16.3.4-10, groupId=DI_SRS_MARC_BIB_RECORD_NOT_MATCHED.mod-inventory-16.3.4] Connection to node 2 (kafka-2.kafka-headless.kafka-iris.svc.cluster.local/<IP_ADDRESS>:9092) could not be established. Broker may not be available.
13:52:41 [] [] [] [] INFO  FetchSessionHandler  [Consumer clientId=consumer-DI_SRS_MARC_BIB_RECORD_NOT_MATCHED.mod-inventory-16.3.4-10, groupId=DI_SRS_MARC_BIB_RECORD_NOT_MATCHED.mod-inventory-16.3.4] Error sending fetch request (sessionId=695707968, epoch=INITIAL) to node 2: {}.
org.apache.kafka.common.errors.DisconnectException: null
13:52:42 [] [] [] [] WARN  NetworkClient        [Consumer clientId=consumer-DI_INVENTORY_HOLDING_CREATED.mod-inventory-16.3.4-27, groupId=DI_INVENTORY_HOLDING_CREATED.mod-inventory-16.3.4] Connection to node 2 (kafka-2.kafka-headless.kafka-iris.svc.cluster.local/<IP_ADDRESS>:9092) could not be established. Broker may not be available.
13:52:42 [] [] [] [] INFO  FetchSessionHandler  [Consumer clientId=consumer-DI_INVENTORY_HOLDING_CREATED.mod-inventory-16.3.4-27, groupId=DI_INVENTORY_HOLDING_CREATED.mod-inventory-16.3.4] Error sending fetch request (sessionId=1729139066, epoch=INITIAL) to node 2: {}.
org.apache.kafka.common.errors.DisconnectException: null
14:41:23 [] [] [] [] INFO  ebRequestDiagnostics Handling GET /inventory/instances
14:44:56 [] [] [] [] INFO  ebRequestDiagnostics Handling GET /inventory/instances
14:45:15 [] [] [] [] INFO  ebRequestDiagnostics Handling GET /inventory/instances

Kafka is also has one of its pods not able to come back up. So there are only 2 kafka pods running.

Here's what I did to "fix" this:

Dialed down kafka to one pod
Redeployed all the mod-inventory related modules (including mod-source-record-storage and mod-source-record-storage manager

This allowed regular mod-inventory search to start working. It's not ideal because kafka only has one pod, but I think the upshot is that now that we have 3 nodes in the cluster instead of 5 certain things are behaving (kafka and ES). The theory is that kafka doesn't like a 3 node cluster if you need 3 pods for it. Doesn't mind if you only want one pod for it though.


Fingerprints filter for records station console

About the PR
Here a filter is added to search for personnel by fingerprints. New functionality is added to the station records console. The most of the new functionality is added to the client side, but some changes has added in server & shared parts. There, the data that was used is expanded with objects included name & fingerprints values. Also I've added new translates for new buttons and input.
Media

The list without filter value

The list with filter value

The empty list with filter value
Changelog

:cl:

add: Added filters of fingerprints for the station record computer

hmm - this is a bit conflicting because this is a client side search of a single value, which is fine - but the real solution here would be something that would allow for searching for arbitrary strings (either all fields of a record, or through a single field per record) through all records in that record type

firstly i wanted to make the new features for a detective RP. I can extended it with new filters for name person and make ability for more future extends but that is all.

i feel like this sets a bad pattern where we're sending over more data per-person than we should to a client, when originally you could just send over a key and then the server would send over the data associated with that key: i think a server-side approach would be better, since it means you can extend it to as many fields as you want and you'd still just be sending over the keys to the client, rather than every single field you want to search through

Well. I'll look how i can improve this. But can you point a place where should make the list of person names for show in left column. Сurrently it makes on server side during opening the console.


chore(deps): add support of python3.12

Category

[ ] Perception

[ ] Detection
[ ] Tracking
[ ] Prediction
[ ] Classification

[ ] Sensing
[x] Other

What

Add support of Python3.12
Type of change

[ ] New feature
[ ] Bug fix
[ ] Breaking change
[ ] Refactoring
[ ] Change code style
[ ] Update test
[ ] Update document
[x] Chore

Test performed

[ ] test.sensing_lsim

[ ] test.perception_lsim

Reference

Notes for reviewer

辞書でエラーが出ている


Add documentation about Ory mutators support with Istio

Description
Changes proposed in this pull request:

Add mutators support docs

Related issue(s)

https://github.com/kyma-project/api-gateway/issues/212

/retest-required


Update Merge Dependency to 2.1.1

Sorry I have the next problem with
"npm audit" command
merge  <2.1.1
Severity: high
Prototype Pollution - https://npmjs.com/advisories/1666
fix available via `npm audit fix --force`
Will install<EMAIL_ADDRESS>which is a breaking change
node_modules/merge
  twing  >=0.2.0
  Depends on vulnerable versions of merge
  node_modules/twing

2 high severity vulnerabilities

To address all issues (including breaking changes), run:
  npm audit fix --force

relevant code: N/A
steps for reproducing the issue: npm audit
Can you solve this please?
You only need make update merge to v2.1.1. Thank you!

it is fix in gitlab

Will be part on the next patch release, probably tomorrow.

@ericmorand if you have the spare time, can you make a new release, please? Thank you!


ePub3 audio playing issue in double page layout

In all of our ePub3 books, we are facing an issue with audio playing in the double-page layout.
Once the left page reading is done, then the entire page is reloading and then it's playing the right-side page. When I check the network calls in the developer console, after the left page reading again HTTP requests are happening for both the left and right page, then just after that right side audio is playing.
When we check the firebase Readium app, there also the same behavior is happening. Is there any way to stop reloading?
firebase link of the tested book: https://readium.firebaseapp.com/?epub=https%3A%2F%2Fcdn.rawgit.com%2FIDPF%2Fepub-testsuite%2Fmaster%2Fcontent%2F30%2Fepub30-test-0220&goto=epubcfi(/6/12!/4/2[mo-1]/1:0)
I am using Readium JS Viewer.

Hello, I believe this behaviour is simply the result of linking from one HTML document (i.e. EPUB "spine item" in the reading order) to another. This "hard" refresh is probably implemented to guarantee the state of the targeted document. Unfortunately, in two-page spread viewing mode this causes both documents to update.

For your information, the two-page spread is implemented here:
https://github.com/readium/readium-shared-js/blob/master/js/views/fixed_view.js
Each document is rendered via:
https://github.com/readium/readium-shared-js/blob/master/js/views/one_page_view.js
The key function call is openContentUrl() in the Media Overlays playback engine:
https://github.com/readium/readium-shared-js/blob/master/js/views/media_overlay_player.js#L640

Thanks a lot, Daniel.
Let me look into these modules whether there is any way to stop reloading in the double-page view.
If you have any suggestions, that would be helpful.


[Quick Fix] Removed validation button errors for Sql Db target

Bug Fix - Removed checks for mandatory fields for SQL db Target since these fields are not need for SQL DB Target

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.005%) to 41.762%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/dialog/configurePython/configurePythonWizard.ts
1
46.46%

Totals

Change from base Build<PHONE_NUMBER>:
0.005%

Covered Lines:
30830

Relevant Lines:
69082

💛  - Coveralls


[BUG] Missing Cypher operators

Environment

GQLAlchemy 1.4.1
Python 3.9.2
Debian 11.7
Memgraph 2.9.0

Describe the bug
Some Cypher operators are missing from GQLAlchemy implementation.
I need to use the "=~" operator for a pattern matching query but it's not declared in the enumeration :
https://github.com/memgraph/gqlalchemy/blob/main/gqlalchemy/query_builders/declarative_base.py#L84
Sadly, it's not possible to build the query without the enum due to this line :
https://github.com/memgraph/gqlalchemy/blob/main/gqlalchemy/query_builders/declarative_base.py#L184
To Reproduce
Instead of pasting here a lot of my application code, please find below an unstested example adapted from https://memgraph.com/docs/cypher-manual/clauses/where#3-regular-expressions

Build a query using the string '=~' in place of the missing enum operator

query = match().node(labels="Person", variable="n").where(item="n.name", operator="=~", literal=".*a$").return("n")

Run it

query.execute()

It will raise that kind of exception

[...] File "/home/philippe/.local/share/virtualenvs/Engine-tgOo-fyU/lib/python3.9/site-packages/gqlalchemy/query_builders/declarative_base.py", line 950, in and_where     self._query.append(AndWhereConditionPartialQuery(item=item, operator=operator, **kwargs))   File "/home/philippe/.local/share/virtualenvs/Engine-tgOo-fyU/lib/python3.9/site-packages/gqlalchemy/query_builders/declarative_base.py", line 212, in __init__     super().__init__(item=item, operator=operator, keyword=Where.AND, **kwargs)   File "/home/philippe/.local/share/virtualenvs/Engine-tgOo-fyU/lib/python3.9/site-packages/gqlalchemy/query_builders/declarative_base.py", line 172, in __init__     self.query = self._build_where_query(item=item, operator=operator, **kwargs)   File "/home/philippe/.local/share/virtualenvs/Engine-tgOo-fyU/lib/python3.9/site-packages/gqlalchemy/query_builders/declarative_base.py", line 186, in _build_where_query     raise GQLAlchemyOperatorTypeError(clause=self.type) gqlalchemy.exceptions.GQLAlchemyOperatorTypeError
Expected behavior
A full support by GQLAlchemy of all Cypher operators (and all related syntax)
Additional context
Patching the enum (declared at https://github.com/memgraph/gqlalchemy/blob/main/gqlalchemy/query_builders/declarative_base.py#L84) allows to build and run properly a query containing a regex.

Hi @philippe-bollard and thank you for opening the issue 🙏  We are aware that the whole Cypher still isn't supported, and I agree it should be expanded. I can't tell you when this will be worked on since we need to prioritize first. Is this a blocking issue for you or did you manage to continue using Memgraph regardless of that? Are you running Memgraph in production?

@imilinovic is #304 fully resolving this issue?


[Adaptive Cards]: Ensures elements with an ARIA role that require child roles contain them.

Target Platforms
Other
SDK Version
1.5
Application Name
Adaptive cards
Problem Description
Test Environment:
OS version: 22H2 (Build 25314.1000)
Browser: Edge Dev (Version 111.0.1661.36 (Official build) dev (64-bit))
URL: https://adaptivecards.io/explorer/Table.html
Tool: Accessibility Insights for Web
Repro Steps:

Open the above URL in edge dev browser.
Turn on the fast pass of accessibility insights for web.
Observe the issue.

Actual Result:
Elements with an ARIA role that require child roles does not contain them.
Expected Result:
Ensures elements with an ARIA role that require child roles contain them.
Snippet:
How to fix:
Fix any of the following:
Element has children which are not allowed (see related nodes)
Element has no aria-busy="true" attribute
User Impact:
Screen reader user will get impacted as user will have difficulty in making track or in navigating the content properly.
MAS Reference link:
https://microsoft.sharepoint.com/:w:/s/accessibility/EXdDUZzldv5MgwDaMHnTzcMBcT8opKGncYjU-gCJ4uqQdg?e=9nuVmt
“Have feedback to share on Bugs? Please help fill Trusted Tester Bug Feedback (office.com) “
Screenshots

Card JSON
NA

Sample Code Language
No response
Sample Code
No response

This issue is not repro, hence closing this issue.
Snippet:


cio_os: Fix 'unresolved external symbol _SHCreateDirectoryExA' on x86

Sophie Fang found that x86 Windows build fails with the following
error:
error LNK2001: unresolved external symbol _SHCreateDirectoryExA

After investigation, it turned out that this was caused by a missing
header file in cio_os.h, and can be simply fixed by adding one.
Signed-off-by: Fujimoto Seiji<EMAIL_ADDRESS>

thanks


PAM: Drop Debian's autoconfig

The autoconfig stopped handling our configuration due to “local changes” and using sudo pam-auth-update --force to trigger a regen produced a non-functional config (i.e. impossible to login anymore).
In light of this, it feels saner to switch to a hand-managed config and simplify it (since we aren't autogenerating it anymore).

@hashbang/administrators I really need someone to check on that one.

Makes sense to me. We have custom setup autoconf can't conver.

@lrvick Does “makes sense to me” mean “I read this, it makes sence and we can test & deploy”?

yep. +1. ship it

Ok, testing on to1.

Looks good, deploying.

Works, but still getting mail from sudo :-1:


New feature: Local distribution capability

I'm excited to introduce a new feature that enables local distribution capability for BMF, allowing users to easily
parallelize computations on a single node.
In this commit, I've implemented the necessary code changes to support multi-threading for single node. To enable this
feature, users can simply add an option parameter "thread":<number> when setting up these nodes, and the framework will create multiple distributed nodes to process data in parallel.
Key Changes:

update enhance_demo.py
add internal module: split_module and assemble_module
add copy constructors in ModuleConfig, StreamConfig, NodeMetaInfo, NodeConfig
add methods and variables in NodeConfig
add create_split_node, create_assemble_node, process_multi_thread functions in Optimizer
add SplitOutputStreamManager
update node.cpp
add new parameter scheduler in the Decode and Encode method in builder
update connector.cpp
add new test cases distributed_node

I changed some code to make it more concise
Key changes:

renamed paramater "thread" to "dist_nums"
optimized process_distributed_node()
modified some comments
deleted the subclass of OutputStreamManager
optimized the distributed node test case


Does not support mesos containerizer.

i've go a error from sandox
I0525 18:52:36.583499  4041 exec.cpp:162] Version: 1.3.0
E0525 18:52:39.593489  4050 process.cpp:2450] Failed to shutdown socket with fd 6, address <IP_ADDRESS>:34176: Transport endpoint is not connected
I0525 18:52:39.593582  4048 exec.cpp:497] Agent exited ... shutting down

with mesos plugin and mesos containerizer, it seems that executor can not communicate with mesos-slave for registering self…
full log of mesos-slave
I0525 18:52:15.898908  1210 linux_launcher.cpp:429] Launching container c4b299e6-629a-4a99-bd88-cfbca0262b1a and cloning with namespaces CLONE_NEWNS | CLONE_NEWUTS | CLONE_NEWNET
I0525 18:52:15.900668  1210 systemd.cpp:96] Assigned child process '3985' to 'mesos_executors.slice'
I0525 18:52:15.902612  1206 containerizer.cpp:1623] Checkpointing container's forked pid 3985 to '/var/lib/mesos/meta/slaves/00e6894c-d896-4a3d-8e79-679077f2af81-S4/frameworks/00e6894c-d896-4a3d-8e79-679077f2af81-0000/executors/container.1467.373c1d9b-4138-11e7-9117-024221dd5669/runs/c4b299e6-629a-4a99-bd88-cfbca0262b1a/pids/forked.pid'
I0525 18:52:15.903939  1206 cni.cpp:888] Bind mounted '/proc/3985/ns/net' to '/run/mesos/isolators/network/cni/c4b299e6-629a-4a99-bd88-cfbca0262b1a/ns' for container c4b299e6-629a-4a99-bd88-cfbca0262b1a
I0525 18:52:16.347486  1206 cni.cpp:1301] Got assigned IPv4 address '<IP_ADDRESS>/24' from CNI network 'netcontiv' for container c4b299e6-629a-4a99-bd88-cfbca0262b1a
I0525 18:52:16.347533  1206 cni.cpp:1307] Got assigned IPv6 address '' from CNI network 'netcontiv' for container c4b299e6-629a-4a99-bd88-cfbca0262b1a
I0525 18:52:16.347687  1206 cni.cpp:1010] Unable to find DNS nameservers for container c4b299e6-629a-4a99-bd88-cfbca0262b1a, using host '/etc/resolv.conf'
I0525 18:52:24.579439  1206 containerizer.cpp:2508] Container c4b299e6-629a-4a99-bd88-cfbca0262b1a has exited
I0525 18:52:24.579493  1206 containerizer.cpp:2102] Destroying container c4b299e6-629a-4a99-bd88-cfbca0262b1a in RUNNING state
I0525 18:52:24.579560  1206 linux_launcher.cpp:505] Asked to destroy container c4b299e6-629a-4a99-bd88-cfbca0262b1a
I0525 18:52:24.580025  1206 linux_launcher.cpp:548] Using freezer to destroy cgroup mesos/c4b299e6-629a-4a99-bd88-cfbca0262b1a
I0525 18:52:24.580930  1206 cgroups.cpp:2692] Freezing cgroup /sys/fs/cgroup/freezer/mesos/c4b299e6-629a-4a99-bd88-cfbca0262b1a
I0525 18:52:24.582156  1206 cgroups.cpp:1405] Successfully froze cgroup /sys/fs/cgroup/freezer/mesos/c4b299e6-629a-4a99-bd88-cfbca0262b1a after 1.18784ms
I0525 18:52:24.583359  1206 cgroups.cpp:2710] Thawing cgroup /sys/fs/cgroup/freezer/mesos/c4b299e6-629a-4a99-bd88-cfbca0262b1a
I0525 18:52:24.584491  1206 cgroups.cpp:1434] Successfully thawed cgroup /sys/fs/cgroup/freezer/mesos/c4b299e6-629a-4a99-bd88-cfbca0262b1a after 1.093888ms
I0525 18:52:24.681495  1203 cni.cpp:1479] Unmounted the network namespace handle '/run/mesos/isolators/network/cni/c4b299e6-629a-4a99-bd88-cfbca0262b1a/ns' for container c4b299e6-629a-4a99-bd88-cfbca0262b1a
I0525 18:52:24.681591  1203 cni.cpp:1490] Removed the container directory '/run/mesos/isolators/network/cni/c4b299e6-629a-4a99-bd88-cfbca0262b1a'
I0525 18:52:24.691004  1203 slave.cpp:5168] Executor 'container.1467.373c1d9b-4138-11e7-9117-024221dd5669' of framework 00e6894c-d896-4a3d-8e79-679077f2af81-0000 terminated with signal Killed
I0525 18:52:24.691063  1203 slave.cpp:4215] Handling status update TASK_FAILED (UUID: e90f3161-d136-4607-a67c-a621df9e82e4) for task container.1467.373c1d9b-4138-11e7-9117-024221dd5669 of framework 00e6894c-d896-4a3d-8e79-679077f2af81-0000 from @<IP_ADDRESS>:0

Update
my issue in mesos jira MESOS-7565
got a comment
Joseph Wu added a comment - 5 hours ago
It appears that, with your networking setup, the executor cannot open a connection to the agent (presumably located at <IP_ADDRESS>). That's why the executor logs Agent exited ... shutting down.

a relative about calico MESOS-5061

@haoyixin there has been some change in host access from container,
try
configure global mode to routing  (netctl global info)
Add host access with contivh1 infra network,
 netctl net create -n infra -s <IP_ADDRESS>/24 -g <IP_ADDRESS> contivh1 (you can choose any CIDR)
Make sure you configure container network with gateway.
then  launch containers from marathon

@rchirakk thx for reply and i will try once i return from leave, then the feedback

i've temporary implemented it for mesosplugin.
https://github.com/haoyixin/netplugin/commit/9e76c8463f9d987e51de54abb90abc535763648a

netctl service is only for docker,
It is NOT supported for mesos.
If you want to implement/try ,
the service network has to be different from the container network. (check docker config http://contiv.github.io/documents/networking/services.html)
backend needs to be updated  on container creation/deletion (CNI request).

@rchirakk thx again for your recent replys
i will try soon ^_^

@haoyixin   I got a similar with contiv netplugin with mesos containerizer, do you fix it?


Cookbook: tests with munit

A short cookbooks that will show how to define tests using MUnit. I should cover 2 different test files and test utils.
An example test using Munit

i'm going to sign up for this for the april 12th spree so i can learn munit.  can you provide more detail?

This issue was picked for the Issue Spree #14 of 12th April which takes place in a week from now. @tgodzik, @mtk and @anatoliykmetyuk will be working on it. If you have any insight into the issue or guidance on how to fix it, please leave it here.

Hi @mtk,
I think it should describe how to use munit with Scala CLI. For example, you can prepare some basic Scala scripts and then  add some tests in munit.
Additionally, cookbook should describe how to define test and run them - you can find more info here.


https://github.com/Mathias-Boulay/Java-Mods-Optimizer (Creator has made the changes asked, Can now be added)

Needs new category for software


Error creating config to baserom

I am attempting to create a yaml file for 'wcw/nworevenge.yaml'. Is this normal or should I move on?
dan@DESKTOP-MG6MEGQ:~/revenge$ python3 -m splat create_config baserom.z64
Traceback (most recent call last):
File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/home/dan/.local/lib/python3.10/site-packages/splat/main.py", line 31, in
splat_main()
File "/home/dan/.local/lib/python3.10/site-packages/splat/main.py", line 27, in splat_main
args.func(args)
File "/home/dan/.local/lib/python3.10/site-packages/splat/scripts/create_config.py", line 254, in process_arguments
main(Path(args.file))
File "/home/dan/.local/lib/python3.10/site-packages/splat/scripts/create_config.py", line 20, in main
create_n64_config(file_path)
File "/home/dan/.local/lib/python3.10/site-packages/splat/scripts/create_config.py", line 149, in create_n64_config
with open(out_file, "w", newline="\n") as f:
FileNotFoundError: [Errno 2] No such file or directory: 'wcw/nworevenge.yaml'

This is an edge case we aren't handling in the code, where the header contains a forward slash in the game name. This translates to a directory when trying to output the file, and we don't create said directory in the code.
I think what we should probably do is replace forward slashes with underscores, unless the directory behavior is expected. Either way, should be a quick fix

This should be fixed in 0.24.2. thanks for the report!


Add helpful comment regarding "yes" and "no" keys

Thanks @bjrne for recommending this!

Coverage remained the same at 69.164% when pulling c55c3b2eae3a977dc3cfe81a11c500bd2e05be85 on cmfcmf:minor-comment into b5482abda18e5db705ffd2e2ce5d56ad5ec82b57 on hpi-schuelerklub:dev.

Coverage remained the same at 69.164% when pulling c55c3b2eae3a977dc3cfe81a11c500bd2e05be85 on cmfcmf:minor-comment into b5482abda18e5db705ffd2e2ce5d56ad5ec82b57 on hpi-schuelerklub:dev.


please add AuthVersion to registry storage driver swift

Registry only maps partial swift connection parameters to config.yml, lacking parameter like AuthVersion. It's hard to use swift service with custom url.

Wrong repo, shoule be  https://github.com/docker/distribution


FINERACT-2081: Loan account summary with Unpaid Payable Interest

Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!

[ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests

[ ] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

[ ] Create/update unit or integration tests for verifying the changes made.

[ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

[ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

[ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@alberto-art3ch I have misclicked on the previous PR and accidentally merged it. I have reverted quickly and re-raised the PR!

@alberto-art3ch Kindly see my review!


[FEATURE] Accessibility features

Describe the feature you want 描述你的功能需求
This is a fantastic theme. I've been using it for more than two years. More recently, I have run into some trouble with accessibility settings. Specifically, related to contrast. I've looked into how to fix it, and it seems like I'd have to work a lot to customize all the colors. I was hoping you'd help make it more accessible. Specifically, by adding settings that can turn it on.
I would be happy to help.
Useful reference 有价值的参考
Here are the references:

W3C Accessibility Guidelines (WCAG) 3.0
W3C Accessibility Standards Overview

@AliSajid
Sorry, I'm not very familiar with Accessibility specifications. I'd be happy to improve this feature if you could send us a PR.

I'll be happy to work on this. I'm forking the theme so I can test the accessibility parts. Thank you. :)


using an anchor as a trigger not possible

I have been having trouble using an anchor tag as a trigger.
The use case for this is I have 5-10 frequently asked questions and i would like to have anchors to each question and also a mechanism to scroll to the correct question if the url contains a hash parameter.
In the past (using bootstrap3) this was possible and I simply return false or event.preventdefault on the anchor allow the accordion override the anchor functionality.
I have worked around it by wrapping my anchor with another div and using that as a trigger and using css to prevent clicks on anchor tag obscuring/intercepting the wrapping trigger event listener but this is not ideal.
Another issue I noticed is when I initialize the accordion to have a specific question open, via the openOnInit parameter, it does not fire the onOpen or beforeOpen event which I was relying on to begin the scroll down the page.
I have been able to work around both issues but it would be nice to have better support on those two features built in.
Thanks for your time and thanks for this great accordion script.

Hi @inquiztr
Auto-scrolling to the specified element is possible by adding a unique ACCORDION_ID and using the #ACCORDION_ID hash in the URL. This behavior is unrelated to the Accordion package, and I don't see why a link with href="#ACCORDION_ID" wouldn't work.
On the other hand, if you want to scroll to the element if the element has been opened, you can use onOpen fn
onOpen: (currentElement) => {
    window.scrollTo({left: 0, top: currentElement.offsetTop, behavior: 'smooth'});
}

When it comes to the second issue, methods such as onOpen won't be triggered when openOnInit is set, but if you want to bypass the default behavior, you can use methods like accordion.open(idx) triggered by the window's load event or other external functions.


Here's a new site I'd like you to consider blocking

Here's a new site I'd like you to consider blocking:
https://gall.dcinside.com

Try updating the definitions on the options page, and they should be blocked. Let me know if it's not working.


Update chart snapshot-controller to 3.0.3

This PR contains the following updates:

Package
Update
Change

snapshot-controller
patch
3.0.2 -> 3.0.3

Release Notes

piraeusdatastore/helm-charts (snapshot-controller)
v3.0.3
Compare Source
Deploys a Snapshot Controller in a cluster. Snapshot Controllers are often bundled with the Kubernetes distribution, this chart is meant for cases where it is not. Also deploys the Snapshot Validation Webhook and configures your cluster to validate every VolumeSnapshot and VolumeSnapshotContent resource by sending it to the webhook.

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


chore: add eslint

This adds eslint and integrates it to the build chain

This implements #4758.

I don't think we need eslint anymore.

Nice, so if we have the same goodies like catching issues before doing a PR, I am all for it.


Vouch not working

The vouch button shows a forever spinning icon and clicking on it doesn't work (note that gassless vouches are working).

Hey! I cannot reproduce the issue, metamask does show up to me after clicking vouch, both on mainnet and kovan. Could you try hard-refreshing the page and trying again? 🤔

I tried, and couldn't reproduce the issue either.


Initial FAQ Page, Table and Tooltip Styling

Odds Ratio colors reflect cell values
Tooltips now moved into a function allowing for selector and positioning options (called once on load, then subsequently when tables are created)
Created initial FAQ / Metadata page and route
Added additional clarifying tooltips

:+1:


Try adding GitHub deploy key and remove test_build step for master merge

:tada: This PR is included in version 3.2.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update ImageResizeMode.java

[Android]Image resizeMode 'contain' should be converted as 'FIT_CENTER'

for this issues #4031

Thanks! Can you provide screenshots before / after with various aspect ratios and also the iOS screenshot? The images in the linked issue don't load for me.

You should also test this with images smaller than the view, and larger than the view.

@zhuchaowe Any updates on this?

Related https://github.com/facebook/react-native/issues/4031

Any update on this?

If we don't get proper test cases we should close this.

Closing. Please comment if you want to re-open


Arms on boot up if R/C transmitter is not on

When I power up the board and the R/C transmitter is switched off, the board Arms and stays armed until I switch on my transmitter.  I'm using a PPM receiver which has failsafes set such that when the receiver gets no signal from the transmitter, it defaults to outputting 'disarmed' on the arm channel.  Once I have turned on my R/C transmitter, but then switch it off again (which puts the receiver into failsafe mode) the board stays disarmed as expected.  Also if I arm the board with the transmitter on and then switch off the transmitter, the board disarms as expected.

I can't replicate this on my flip32+ and an orange R618XL in PPM mode.  What receiver are you using, and what is the failsafe behavior set to?

Slightly different, but might be related:
Using a CPPM receiver, if I power both the naze and the receiver at the same time (through the RC power rail), the red light comes on at boot, but the naze isn't armed. If I then set the ARM_CHANNEL param, the light goes off which suggest that init_rc might affect this somehow.
If I power the naze through USB, then power the receiver through the RC rail, the red light does not come on.

Let's just verify this with @wynn4 and his setup before we actually close this; he was saying that his actually got armed. This may have fixed it, but let's just double check.


Local file-based name resolver with SQLite

Fixes #1380
Will fix (when runtime PR is merged) dapr/dapr#3256
Addresses a longstanding request to have an alternative name resolver component for local development, for situations where mDNS can't be used (and even in those situations, a local name resolver is more convenient for local development).
As discussed in #1380, this is implemented with SQLite, which is fast and efficient.
PR includes tests implemented via unit tests, since we don't have an infrastructure for writing conformance or certification tests for name resolvers.

All cert tests are failing because the APIs changed and the pinned runtime needs to be updated. Usual problem :) However nothing changed here that would impact cert tests

If these new unit tests are slow we might want to move them to be some sort of pseudo certification tests.


"reasoning" concept for a flag evaluation

When we evaluate a flag, we hand over a pile of context and a key name. In response, we get a value. For many reasons (logging, debugging, etc), we might like to know why we got that value. The spec should provide an API that will allow us to introspect this stuff.
Key info, in my mind, is:

was there an error? What kind?
is this the default I provided in my API call or something from the evaluator implementation?

Maybe also:

which rule lead to this value being chosen?

I think we can agree this is a good idea. It's been brought up in a number of threads and in community meetings. Of course, it seems like our ability to surface this data is highly dependent on what is exposed by the underlying provider, but I think defining another set of methods that wrap the flag-value along with some additional evaluation metadata is probably a good approach. This isn't unlike the pattern LD uses, and something like what split does to surface the additional configuration data associated with a flag.
The trouble is that I don't think all the providers have this class of functionality, and the majority also don't seem to throw exceptions/errors (a perfectly understandable choice in the case of feature flags) further obscuring things.
I'll take a research action item from this, and I'd also appreciate input from anyone familiar with how we might get such information from the various provider SDKs.

This may be a situation where we have to determine what information would be the most valuable and leave it up to the providers to handle. We would then have to handle the situation where this information is not provided but I think that's a reasonable compromise.

Relevant PR to this discussion: https://github.com/open-feature/sdk-research/pull/22

We've had some interesting discussion about this, see thread here.
In summary, I think we need to decide whether or not we want OpenFeature to rigorously define a set of reasons and force providers to map their own reasons onto that, or allow reasons to be more free-form strings. The clincher here, as @beeme1mr points out, is really about whether we expect Application Authors or Integrators to write logic based on these values, or otherwise, they're only important for diagnostics/telemetry/troubleshooting... If we think code will be written around these reason values, I think we should define them well within OpenFeature, and accept that there will be some loss of fidelity between the provider's "reason" and what's exposed in OpenFeature.
@justinabrahms since you opened this discussion, I'm particularly interested in your take.

@toddbaert I'm generally fine with the string implementation here. In my own implementations, I just want that information for logging & telemetry. I can add any simplification or bucketing of those error codes in my hooks that handle that.


boards: riscv: esp32c3_luatos_core: make usb variant

Converts the board above to use variant option.

Is there is still room for this in collab-hwm.. In case not, I'll move it to 'main' later.


Tuttii - Real-Time Remixing / Mashup App

Tuttii is a new way to DJ / produce music through a novel drag & drop interface, no skill required. Play with song stem segments, tweak the speed and pitch of your remix, and share directly to UGC platforms. We handle all of the complexities of music production so you can simply create.
Feel free to request new music to be added while we work on our commercial licensing agreements ahead of our full launch. We'd appreciate any feedback, suggestions, or ideas while we're building!
https://testflight.apple.com/join/2dTbntXZ

done


gtask: fix memory leak when calling g_task_return_value

The g_task_return_value function does not take ownership of the input
GValue pointer, but just borrows it to make a copy:
https://developer-old.gnome.org/gio/unstable/GTask.html#g-task-return-value
The Rust caller should take care of the deallocation.

#526

Will backport for the next 0.15 bugfix release at some point


Add support for three-legged OAuth for Google connections. Useful for…

… developer-mode.

This makes using Airflow with Google cloud pretty neat. When in developer-mode, you can spin up a local instance, and use gcloud auth to authenticate yourself. From there, you can query Google projects that you have access to.

Confused as to why the build fails. The CI says command successful, and the coverage decreased -0.0%.

Re-opened PR to see if a new execution will be triggered.

OK, now it says -0.06%. Assuming this is because I added some new lines. Given that this is in contrib, and no one (other than me) is using it right now, I would argue that it's OK to merge in. I do have an open task to add some tests to this, but I don't want to block on it if that's OK.

:+1:


Upgrade error on V5_0_0_20__UTF8_Tables.sql

Upgrade fails on QUERY entries that have NULL for FK_DASH_ID.
Also could happen if FK_DASH_ID is for a non-existent DASH

I think it might be best to alter the migration process so that all Queries are dropped that don't specify FK_DASH_ID.


Can't even compile the demo project

2017-03-16 15:29:37.257 TGPControlsDemo[6399:144694] Unknown class _TtC11TGPControls14TGPCamelLabels in Interface Builder file.
2017-03-16 15:29:37.258 TGPControlsDemo[6399:144694] Unknown class _TtC11TGPControls17TGPDiscreteSlider in Interface Builder file.
2017-03-16 15:29:37.269 TGPControlsDemo[6399:144694] Unknown class _TtC11TGPControls17TGPDiscreteSlider in Interface Builder file.
2017-03-16 15:29:37.270 TGPControlsDemo[6399:144694] Unknown class _TtC11TGPControls14TGPCamelLabels in Interface Builder file.
2017-03-16 15:29:37.272 TGPControlsDemo[6399:144694] Unknown class _TtC11TGPControls17TGPDiscreteSlider in Interface Builder file.
2017-03-16 15:29:37.275 TGPControlsDemo[6399:144694] Unknown class _TtC11TGPControls14TGPCamelLabels in Interface Builder file.
2017-03-16 15:29:37.276 TGPControlsDemo[6399:144694] Unknown class _TtC11TGPControls17TGPDiscreteSlider in Interface Builder file.
2017-03-16 15:29:37.277 TGPControlsDemo[6399:144694] Unknown class _TtC11TGPControls14TGPCamelLabels in Interface Builder file.
2017-03-16 15:29:37.278 TGPControlsDemo[6399:144694] Unknown class _TtC11TGPControls14TGPCamelLabels in Interface Builder file.
2017-03-16 15:29:37.287 TGPControlsDemo[6399:144694] Unknown class _TtC11TGPControls17TGPDiscreteSlider in Interface Builder file.
2017-03-16 15:29:37.313 TGPControlsDemo[6399:144694] Failed to set (tickCount) user defined inspected property on (UIView): [<UIView 0x7fabea504120> setValue:forUndefinedKey:]: this class is not key value coding-compliant for the key tickCount.
2017-03-16 15:29:37.314 TGPControlsDemo[6399:144694] Failed to set (ticksDistance) user defined inspected property on (UIView): [<UIView 0x7fabea504120> setValue:forUndefinedKey:]: this class is not key value coding-compliant for the key ticksDistance.
2017-03-16 15:29:37.314 TGPControlsDemo[6399:144694] Failed to set (value) user defined inspected property on (UIView): [<UIView 0x7fabea504120> setValue:forUndefinedKey:]: this class is not key value coding-compliant for the key value.

@SwiftArchitect sent you a pull request, small fix to make demo project compile. Thanks for your work!


mountpoint-s3: 1.8.0 -> 1.9.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/awslabs/mountpoint-s3/releases.
meta.description for mountpoint-s3 is: Simple, high-throughput file client for mounting an Amazon S3 bucket as a local file system
meta.homepage for mountpoint-s3 is: https://github.com/awslabs/mountpoint-s3
Updates performed

Rust version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.9.0 with grep in /nix/store/gd37jl10miw712m2cfjrz3qpz90m2n78-mountpoint-s3-1.9.0
found 1.9.0 in filename of file in /nix/store/gd37jl10miw712m2cfjrz3qpz90m2n78-mountpoint-s3-1.9.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

mountpoint-s3

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/gd37jl10miw712m2cfjrz3qpz90m2n78-mountpoint-s3-1.9.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A mountpoint-s3 https://github.com/r-ryantm/nixpkgs/archive/a35f3f52ca675c40e6030cc00620a3ef0ee0fb4a.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/a35f3f52ca675c40e6030cc00620a3ef0ee0fb4a#mountpoint-s3

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/gd37jl10miw712m2cfjrz3qpz90m2n78-mountpoint-s3-1.9.0
ls -la /nix/store/gd37jl10miw712m2cfjrz3qpz90m2n78-mountpoint-s3-1.9.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

mountpoint-s3

Maintainer pings
cc @lblasc for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge


Nginx Ingress Controller [0.8.3] ConfigMap - Client certificate verification not supported

I've tried to add client certificate to nginx server config. It is not supported:
https://github.com/kubernetes/contrib/blob/494064ba4e685a3d9432411bcd72dc5d49641316/ingress/controllers/nginx/nginx/config/config.go
nginx-loadbalancer-conf.yaml
apiVersion: v1
data:
  ssl_verify_client: "on"
  ssl_client_certificate: "/ssl/ca.crt"
kind: ConfigMap
metadata:
  name: nginx-load-balancer-conf

rc.yaml
..
- --nginx-configmap=$(POD_NAMESPACE)/nginx-load-balancer-conf
...

after call of:
 k exec nginx-ingress-controller-p840p -- cat /etc/nginx/nginx.conf

I can't see the changes in /etc/nginx/nginx.conf
kube: 1.4.5

@remoe Taking a look in template, I can see this:
        {{ if not (empty $location.CertificateAuth.CertFileName) }}
        # PEM sha: {{ $location.CertificateAuth.PemSHA }}
        ssl_client_certificate              {{ $location.CertificateAuth.CAFileName }};
        ssl_verify_client on;
        {{ end }}

Have you figured out how to make this work?
I'm leaving to home by now, but pinging you so we can try to improve this one.

Sorry, no. I don't use Ingress Controller with NGinx anymore. It was a lot slower than https://github.com/kubernetes/contrib/tree/master/service-loadbalancer with HAProxy.

@remoe No problem :)
We've been using service-loadbalancer here in the company, but it seems they weren't updating it anymore.
I think that the official way of doing this would be only ingress on a near future. Probably it would be nice to write a ingress controller for HAProxy :)
@jcmoraisjr was going to do this, I don't know how is his WIP.
Anyway, I'm going to take a look in this and also document for future usages.
Thanks!

@rikatz @jcmoraisjr yeah, a HAProxy ingress controller would be nice ;)

Closing. PR #235 was merged.
@remoe please reopen if you still have issues


Kulfy: Watch callgirlssharjah.com

Kulfy requests the watch of the watch_keyword callgirlssharjah\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

callgirlssharjah\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Approved by Ryan M in Charcoal HQ


Security: Add configurable CSP headers

Is your feature request related to a problem? Please describe.
CSP headers are improving the security of the application.
We need to make them configurable.
Resources https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP
Describe the solution you'd like
Add configuration for a configurable CSP policy
Describe alternatives you've considered
Reverse proxies can add headers, but that is often too generic.

Started in https://github.com/cs3org/reva/pull/4471
Cannot go into 5.0.0 because of code freeze.

fixed by #8761


Updates

I've implemented some changes that I needed for my project.
Create unified base class/interface for generic and non-generic promises
This allows code which can handle any type of promise. Creating IPromiseBase allows IPromise, IPromise, and IPromise to all be treated identically, without creating code branches for each. The IPromiseBase interface is implemented explicitly, which avoids creating ambiguous functions.
Additionally, the Promise_Base class allows for a decent amount of code reuse between generic and non-generic promises.
Implement Finally
Implemented as described in issue #9. It's just a wrapper around existing functionality.

I'd love to get Finally support in RSG.Promises! If you separated these into two PR's, it might be easier for Ashley to land the Finally support while the team decides which (if any) big refactor PR to take. I hope so anyway.

👍 for this patch, we use this promise library at AltspaceVR and having a common interface for generic and non-generic promises would be really nice.

Hi Nathan, thanks for contributing.
I'm really happy with some of your changes. Particular the inheritance of generic and non-generic promises from a single base. I think that's worthwhile. I also think that the addition of the Finally function is great and is something that we have wanted for some time.
Generally I'd question the the addition of PromiseResult. Can you let us know more about why this was added? Also I'd prefer to keep formatting as spaces as that's what we use.
We are definitely happy to accept pull requests for the common interface (@mquander) and also for the finally function (@df-marc). However what we need though are two of the simplest imaginable pull requests that each just add the requested feature.
Many people depend on this library (including us at Real Serious Games) so I'm reluctant to change it except for the most important feature additions provided the changes sets are simple as possible (and therefore easiest to prove that they work reliably).
Cheers
Ash

PromiseResult was added to support code that works directly with PromiseBase. It allows you to continue the promise chain in a generic fashion without losing access to the promised result. Without this, you need to cast PromiseBase before using it, which is tricky when there arn't any type restrictions on the promises you are handling. Casting to Promise doesn't work like you might hope!
I can fix the formating and split the PR, but I won't have time to work on this until late December.

No comment on the necessity of PromiseResult, but if it's around it would be nice if it were a struct -- no point in unnecessary heap allocations, and it's common for "value wrapper" classes like Lazy<T>, Nullable<T>, etc. to be structs for this reason.

This pull request has been split into #34 and #35.


[Feature Request] Compare with already existing files

Hi,
if the send script is used on a whole library, with something like this:
find /<libname> -iname "*.epub" -exec python3 send_file.py {} \;
it will also push files already existing in the target. Updating the target after changing local data would produce a lot of duplicates.
Is it possible to establish a flag, something like -d. that checks if the file already exists and skips that file if true?

You can call send_file.py to grab a list of files in onyx service.
Then compare locally with what you want to send.
All you have are file names and file sizes. No checksums to be sure that those are the same files.

Yes, but that would create a local wrapper script.
Would you take a PR providing this feature?

of course


invoke on client-side

What you aim to do with this PR?
What problem you are solving, and why we should create a window.invoke to do so?


add enable addons application manager

Signed-off-by: Mike Ng<EMAIL_ADDRESS>example of usage:
clusteradm enable addons --names application-manager --clusters cluster1

This will deploy the application manager related operators to the hub cluster and deploy the ManagedClusterAddOn CRs to the given clusters.

/hold
Work in progress.

/unhold

/hold

/unhold

/lgtm


Discuss class structure and abstraction

Currently, we have single classes or modules with functions. They all rely on the iRODS session.
It would be nice if one could instantiate an IrodsConnector and would have directly all functions or class in a flat hierarchy.
ic = IrodsConnector(<irods session parameters>)
ic.get_collection()
ic.meta(<irods item>)
ic.upload
ic.perm.add()
...

I would also like to link the IrodsPath here, since it is dependent on the iRODS Session and one instance of the class refers to a specific iRODS instance.

Done


Allow indexing of MemoryMap.

In developing a bootloader for my microkernel, I have have found that being able to index the given MemoryMap would reduce some complexity.

Hi, thanks for the contribution. I'll have a closer look in a couple of hours.

I went ahead and fixed the git conflict, merging now. Thanks for the PR :)


Association of app keys

Two App Keys cant be used in the same vault or collab wallet.

Verified this issue on keeper app v 1.1.12(303)