Export refFindWalker

I am currently developing a plugin that needs to modify this visitor in order to define behavior for a syntax extension to ECMAScript. Will you please expose this object so I may do that?

That object is only made in order to override two of its fields inside of findRefs. I really can't think of a single sensible use of it from an external module. searchVisitor is already exported -- doesn't it make more sense to build your own walker based on that?

Here is where I would like to use it in my plugin: https://github.com/jacksonrayhamilton/tern-jsx/blob/9ab65719c6bb5ea2c66f3fc35373203a440a5c78/jsx.js#L50
Without patching this walker, attempts to rename variables fail if the file uses extended syntax. e.g. If I tried to rename Element below,
var Element;
var App = <Element/>;

then I would get this error,
TypeError: visitor[(override || node.type)] is not a function

Is there a better way to deal with that issue than modifying refFindWalker?

It seems like you'd get a lot further by patching the original base walker functions in acorn, before Tern derives its walkers from them. Needing access to every walker object is going to break every time a plugin uses a walker, isn't it?

It seems like you'd get a lot further by patching the original base walker functions in acorn, before Tern derives its walkers from them.

Yeah, that sounds better. Is there a way to do that?
Alternatively, if walk.make used Object.create to inherit from walk.base, then modifications to walk.base could propagate to walkers after their creation.

Needing access to every walker object is going to break every time a plugin uses a walker, isn't it?

Yep, probably will break.

Yeah, that sounds better. Is there a way to do that?

If you have control over the way Tern is loaded, sure, just load Acorn's walker first and add the new walker methods to its base walker.

Are you suggesting I add code to my copy of bin/tern to patch the base walker? I'm hoping for a solution that will allow this plugin to work without users specially modifying Tern.

Hi @jacksonrayhamilton it seems that we have similar project, see https://github.com/angelozerr/tern-react/blob/master/react.js but I have stopped this project since acorn-jsx doesn't support acorn loose (see https://github.com/RReverser/acorn-jsx/issues/32) Have you fixed this problem?

Hi @angelozerr, I was planning on contacting you regarding the relationship between our plugins. I think it would be off-topic to discuss that here.

I think it would be off-topic to discuss that here.

yes sure! Thanks for your work.

Are you suggesting I add code to my copy of bin/tern to patch the base walker?

No, I'm suggesting you load your file, which adds stuff to the base walker, before you load Tern.

The first thing bin/tern does is require("../lib/tern"), and that file does require("./infer"), and that file starts creating walkers. So as far as I can tell, to mutate the walker before Tern loads, I'd have to create a wrapper script like this, and put it on my PATH as "tern" so my editor can find it:
#!/usr/bin/env node
var walk = require('tern/node_modules/acorn/dist/walk');
var inject = require('tern-jsx/inject');
inject(walk.base);
require('tern/bin/tern');

That would not be very ideal... this script would compete with the globally-installed tern, or I would have to ask users to install a wrapper around the tern package instead of the actual tern.
Did you mean something else? If so, will you please explain in more detail?

That's why I said 'if you have control over the way tern is loaded before'.
If you can get something working by making walk.make use Object.create, I'm also okay with that -- you can submit a PR to acorn to make that change if it helps.

That's why I said 'if you have control over the way tern is loaded before'.

Ah, sorry, I did not quite take that in.

If you can get something working by making walk.make use Object.create, I'm also okay with that

Great, I'll see what I can come up with.
However, given the way refFindWalker is currently used, I will probably still want to modify it like I do here: https://github.com/jacksonrayhamilton/tern-jsx/blob/master/jsx.js#L54 And as a heads-up, the same may go for a few other internal structures (as I'm currently discovering in my test suite), despite the improvement that may be accomplished by updating walk.make.

However, given the way refFindWalker is currently used, I will probably still want to modify it like I do here:

Seems like it might make sense to make JSXIdentifier call through to Identifier when not overridden.

Seems like it might make sense to make JSXIdentifier call through to Identifier when not overridden.

True, if I were modifying walk.base and it were a prototype, then in my situation I could probably do:
walk.base.JSXIdentifier = function () {
  return this.Identifier.apply(this, arguments);
};

However, if the handler were detached and the context unspecified, it'd break (due to this semantics). Calling through in this manner also seems like it may be trying to serve a particular use case in Tern where the handler is defined ad-hoc. As I derive from the conventions of walk/index.js, I ought to assign an ignore function as the default value of the JSXIdentifier handler.

Indeed, if we make walk.base a source of retroactive heredity then it seems like I can use the already-exposed searchVisitor for this:
infer.searchVisitor.JSXIdentifier = function () {
  return this.Identifier.apply(this, arguments);
};

Some of the methods on walk do detach the handler, but thankfully that isn't true of the methods currently receiving infer.searchVisitor. I'd feel more comfortable if code like this:
let found = visitors[type]
if (found) found(node, st)

Were more defensively written like this:
let found = visitors[type]
if (found) found.call(visitors, node, st)

I actually meant something more along the lines of
walk.base.JSXIdentifier = function(node, st, c) {
  c(node, st, "Identifier")
}

That doesn't rely on this being the right object, and is more like the way other 'forwarding' works in the walker.

Right, but here's why I don't think that can work:
Yes, JSXIdentifier implements the same interface as Identifier. JSXIdentifier and Identifier often represent variables in scope, so in some cases (like searching for a definition or reference) then they are treated the same. But it is not always true that JSXIdentifier should be defined in terms of Identifier.
For instance, in another plugin I am working on, tern-context-coloring, I intend to color Identifier nodes by their scope. White is global scope, blue is level 1, green is level 2, and so. Modifying walk.base to call through will result in also coloring JSXIdentifier nodes by scope. And indeed, sometimes a JSXIdentifier references a variable in scope. So, I observe the following (unintended) behavior in my plugin (i.e., "Form," a JSXIdentifier, is colored blue in a JSXElement):

But other times, JSXIdentifier refers to an HTML element. Is that a variable in scope? Nope. But my plugin assumes that these JSXIdentifier refer to global variables ("div" is colored white, which means it is global):

So what I would have preferred in this case were that JSXIdentifier just be ignored, so I could get this "neutral" coloring:

If I wanted to prevent that unintentional coloring, I could apply the knowledge I have and make a special redefinition of JSXIdentifier in tern-context-coloring. But it doesn't end there; my non-standard syntax extension could impose special handling requirements on any Tern plugin in a similar manner.
I guess what this boils down to is that JSXIdentifier =/= Identifier, so it's inappropriate to call through to it by default in walk.base. And I'm not arguing with any particular goal in mind right now, except to try and explain my reasoning in case this mattered sometime in the future.

Having the default JSXIdentifier defer to Identifier doesn't mean you can't override it. If want specific behavior, as you seem to want in your example, just override it (JSXIdentifier) with an implementation of that behavior.

I forgot to deliver an important part of my argument: If I define walk.base.JSXIdentifier as ignore, then JSXIdentifier is not automatically assumed to be Identifier, which results in other plugins (like tern-context-coloring), which don't necessarily know about JSX, to just skip over the syntax (as in the third screenshot). I think that is best.
As I attempt to illustrate in the example, not all plugins are prepared for this node type. If they know about it, sure, they can define a walker specifically for it that does something additive. But I believe, that by default, it is better to presume as little as possible about the contexts JSXIdentifier will be used; this way, authors can choose to add support for non-standard syntax, rather than receive bug reports forcing them to explicitly ignore my non-standard syntax, and Joe's and Sue's non-standard syntaxes, because they break something.

I guess this is kind of an awkward case in that it sometimes behaves just like an identifier, but not always, so indeed, it might cause problems to treat it as one. So sure, if making the default behavior be to ignore the node works, that's probably better.

Okay, point made. :P Also, the walk.make update has been working for me on my Tern fork, so I'll consider this issue solved.


Usage example without Protobuf (write plain JSON objects)

Hi, current write example heavily rely on schema described using protobuf.
Can I use this library somehow with specifying data as plain JSON objects instead? I don't want to deal with any Protobuf boilerplate.
Thanks

Since this issue was created, a new managedwriter library was created that simplifies json-based writing.  See https://github.com/googleapis/nodejs-bigquery-storage/blob/main/samples/append_rows_json_writer_default.js for an example of using it.


[Feature Request] AlpineJS Reference

Would love to see alpinejs.dev documentation referenced.

✅ I added alpine js docs
(unfortunately since https://alpinejs.dev/ have blocked iframes, the docs can't be displayed directly inside vscode, so it will be opened in browser instead, but it's better than nothing)

Thank you!


Make ovl idmap mounts read-only

This is an additional safeguard against inadvertent data modification or deletion as a follow-up from #10721.
Tests covering the lifecycle of the temporary idmap mounts and integrity of the underlying lower layer data is also included in the normal and failed-unmount case.
Fixes #10704
From the discussion in #10721 I had three goals:

@fuweid's request to add the read-only flag to the temporary mounts by adjusting IdMapMount's signature to accept mount options.
Add tests
One way to simplify the logic determining the path to remove during cleanup, we already have the path to remove so no need to use filepath.Dir / filepath.Join on a particular layer's path. Not sure if this is exactly what @AkihiroSuda had in mind with comment

@mbaynton I'm unsure if we should mark the issue as fixed. I mean, the issue is fixed in 2.0 already, there is no data corruption. But there is "contention" and the unmount fails qith resource busy, that is why we the detached unmount for now (so it doesn't fail), and it is not clear to me why yet.
I didn't write that code, so it's not easy for me to see it now. However, I think it needs to be investigated why the unmount fails without detached with the repro case you shared in the issue. It might be legit, but it might not be.
Those directories should be unsued outside the current pod and probably container too, I don't know why the unmount without detached fails. Doing an stress test of mount/unmount, it doesn't seem to be the kernel generating sporadic failures. So it seems there is something going on worth investigating, IMHO.
If you want to investigate that too, @mbaynton, it would be great!

I'm unsure if we should mark the issue as fixed

Sure, I don't really have a stake in whether the issue is marked fixed :). I just assumed it was reopened to do this follow-up.
The approach I personally am going to take on next iterations is to see what becomes available in kernel 6.13 and if lower layer specification by file handle indeed lands, see if the reproducer still produces busy idmapped unmounts when they are never added to the host's path tree or if we can just sidestep the whole issue that way.

Rebase?

Rebase/squash?

Yes. Please squash into one commit. Thanks

Sorry for the delay, missed your message

What should we do from here?

ping @AkihiroSuda @dmcgowan

Restored original IDMapMount and call it again where new options are not needed, created new IDMapMountWithAttrs.
Rebased.


refactor: Style Devcon claim page. Add hero section and og image

Description
Add a hero section to the Devcon 2024 claim page. Also added some styles and text to the check eligibility section (mainly just describing the discounts)
Also added a new og image for the Devcon page. I will continue to style the claim "form" area next.
The plan is to highlight whichever tier "box" they are eligible for, if any, once they do the claim step.

I am assuming the preview deployment is failing because of the new NEXT_PUBLIC_BG_BACKEND_API env variable

Looking great @ChangoMan !!! Good stuff.
Mergin this, but leaving some comments for future PRs:

The plan is to highlight whichever tier "box" they are eligible for, if any, once they do the claim step.

Love this idea.

There is something weird in the workflow: you check eligibility for a random address in the input (e.g. it's eligible!)... and then connect your wallet (a different address) and you can claim. Not sure how to do it better, buy maybe making them to check eligibility again with the connected wallet?
OG image: Maybe we should add something else in the image? Like "claim your builder discount", or "check eligibility", IDK
meta title, description: Beside the image we'd need a meta title & description. (maybe this would be enough and will fix the previous point)

I am assuming the preview deployment is failing because of the new NEXT_PUBLIC_BG_BACKEND_API env variable

Added the env var to Vercel. But this was the error on Vercel (yarn build):

You were using the _components folder as in NextJS app router, but in this instance we are still using the page router (so it was interpreted as a page with multiple exports). Fixed it here https://github.com/BuidlGuidl/buidlguidl.com/pull/30/commits/548e22448d36255258913af12575bdd76ef9ceb3

Looks really nice @ChangoMan! love the slight pinkish gradient on hero section + the idea of highlighting boxes on eligibility makes sense! Thanks!!!


Fix and test for issue #2907.

Fixes #2907.  element after  should not looks like it's in
Solved by adding class to options which are members of optgroup. Indent is added only to options with that class.

Thanks!


contract init broken

What version are you using?
22.0.1
What did you do?
stellar contract init .
cargo test

What did you expect to see?
✅ Build success.
What did you see instead?
❌ Build failure.
   Compiling hello-world v0.0.0 (contracts/hello-world)
error[E0599]: no method named `register` found for struct `Env` in the current scope
 --> contracts/hello-world/src/test.rs:9:27
  |
9 |     let contract_id = env.register(Contract, ());
  |                           ^^^^^^^^ method not found in `Env`

Fix is in:

https://github.com/stellar/stellar-cli/pull/1798

We should also add a test for building what contract init generates to the integration tests, but I've done a quick fix in the above PR to get it out rather than delay.


ERROR  inject('content', value) has no value provided

Versions

nuxt: v2.14
node: v12.18.3

When I do nuxt production and run it locally it runs smoothly. However, when I upload it to hosting and do some configuration and then run it a server error occurs. Did the error occur because I am using the @nuxt/content module, Before I used it everything looks fine.
file server.js
const { Nuxt, Builder } = require('nuxt')
const path = require('path')
const app = require('express')()
const config = path.join(__dirname, './nuxt.config.js')

// We instantiate nuxt.js with the options
config.dev = (process.env.NODE_ENV === 'production')
const nuxt = new Nuxt(config)

async function start() {
    await nuxt.ready();

    // Render every route with Nuxt.js
    app.use(nuxt.render)

    // Listen the server
    app.listen()
}

start()

file stderr.log
ERROR  inject('content', value) has no value provided

  at inject (.nuxt/index.js:159:0)
  at plugin_server (.nuxt/content/plugin.server.js:9:0)
  at createApp (.nuxt/index.js:231:0)
  at async module.exports.__webpack_exports__.default (.nuxt/server.js:81:0)

Close Does this work in SPA mode??

I am having this problem, how did you get it to work?

I am having this problem, how did you get it to work?

@nph278 I managed to do it by following the configuration on the following link https://nuxtjs.org/docs/2.x/internals-glossary/nuxt-render

@nph278 I managed to do it by following the configuration on the following link https://nuxtjs.org/docs/2.x/internals-glossary/nuxt-render

I am having this same issue as well, unable to proceed.


Add cdn info

HI @dhg,
I'm Peter from cdnjs.com,
I wonder if you would like to add cdn info in the readme or the website?
This is the page we provide cdn for Skeleton - https://cdnjs.com/libraries/skeleton
Thanks!

Hi Peter, I noticed your unminified copy of Skeleton seems to have a lot of errors of some sort in it, it appears to be a problem with the comments above each section. Just letting you know!
https://cdnjs.cloudflare.com/ajax/libs/skeleton/2.0.4/skeleton.css

Thanks @dan1elhughes, I'll fix it.

@dan1elhughes: I think there is no problem, you can download these two files and their hash, same same.
https://github.com/dhg/Skeleton/raw/2.0.4/css/skeleton.css
https://cdnjs.cloudflare.com/ajax/libs/skeleton/2.0.4/skeleton.css

This seems like an encoding problem..

Hey @PeterDaveHello -
This is incredible. Would love to get Skeleton on a CDN (one of the things still on my list that I think is super important). Seems like there are some issues with encoding though (if you look at the two files you posted, the comment structure gets all wonky). Could totally be an issue on my end of weird comment structure – suggestions to fix this?
Let me know as I'd love to get this on the CDN and put a link on the site.

hmmmm what about just remove them?

I meant the comments with problem.

Or minify the files?

We always provide minified files, you can take a look at url

+1

Hi @dhg,
Just wondering about the CDN / minified files mentioned here.
The links are not in the docs - any reason for that?
Thanks!


Missing Block Components

The following block properties are missing from documentation:

[x] minecraft:creative_category
[ ] minecraft:part_visibility

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ed2d3b8d-1c13-9c44-e452-d358e9a275cd
Version Independent ID: dacf9f8f-0632-e8dd-092f-80b0c378ba9e
Content: Block Documentation - Block Components List
Content Source: creator/Reference/Content/BlockReference/Examples/BlockComponentsList.md
Product: gaming
GitHub Login: @v-josjones
Microsoft Alias: v-josjones

There's also missing minecraft:crafting_table component.

minecraft:creative_category has been added.
minecraft:part_visibility has been added but needs further work including a breakdown of the JSON object and an example.
Will need to investigate minecraft:crafting_table.

Thanks for the feedback! All of the items noted have either been deprecated or added to the documentation as applicable.


remove channel base code dependency for admin logo and favicon

Description
Remove channel base code dependency

Hi @phyothiha,
Thanks for the pull request.
Make these two fields 'channel_based' => false also.
https://github.com/bagisto/bagisto/blob/master/packages/Webkul/Admin/src/Config/system.php#L107


src/project: put a ref to source next to gc_root

Overview

Currently it is not possible to determine whether a gc_root is used or not because the path is a hash of the filename that it was created from.  When the source is deleted, the gc_root will remain forever unable to be garbage collected.  Once the user accumulates several projects, it is also very hard to tell which gc_root belongs to which project, because there is no bidirectional mapping.
In #16 it was suggested to add a subcommand to lorri that will automatically remove unused gc_roots, however, without a mapping from the name of the gc_root back to the location of the source this is impossible.
This commit addresses this issue in parts by creating a file with the name ref next to the gc_root which will simply contain the full path of the shell file it was originally created for.  In the future this information could be used to automatically detect and garbage-collect unused gc_roots, but even without that it will enable the user to write a simple shell script which picks up each ref and checks whether the file inside exists.
Another possibility instead of using a file containing the path name would be to make ref a symlink to the shell file.  When the symlink is broken, the gc_root is unused.  However, that might pose a problem for users using lorri through WSL on Windows, because Windows filesystems don't support symlinks.  I'm unsure whether that is a concern, but I opted for the safer option of just a plain file.
Checklist

[ ] Updated the documentation (code documentation, command help, ...)
[ ] Tested the change (unit or integration tests)
[ ] Amended the changelog in release.nix (see release.nix for instructions)

I had run the ci command locally and it all passed, so I have no idea why all the macOS tests are failing.  Also the error message “This check failed” is not all too helpful.


add ase_engine

Is there an easy way to extend this engine to use external calculators like
https://github.com/ACEsuit/mace?tab=readme-ov-file#example-usage-in-ase-1

It should be straightforward now
In a file calc.py
from mace.calculators import mace_off

def get_calc():
	return mace_off(model = "medium", device = "cpu")

Then in infretis.toml
[engine.calculator_settings]
module = "calc.py"
class = "get_calc"

With this mace calculator, however, I notice that our logger stuff is printed to the screen as well as the .log files (sim.log, worker.log).


chore: fix canary release

Summary

Related issue (if exists)

Types of changes

[ ] Docs change / Dependency upgrade
[ ] Bug fix
[ ] New feature / Improvement
[ ] Refactoring
[ ] Breaking change

Checklist

[ ] I have added changeset via pnpm run changeset.
[ ] I have added tests to cover my changes.

!canary


Webhook Template - Issue while edit webhook template

Describe the bug
https://www.berrycast.com/conversations/bd6a6cf7-9b59-5a42-9ad2-dcd0be40785f

https://www.berrycast.com/conversations/0f856401-4b4f-5042-95a1-236d81244424


Way too long of a response to image approvals

Maybe profiling will help figure out why

Actually, it looks like it's just processing the image maybe?

It's better now. Or at least I don't think I can improve it much more at this point.


DestinationRules don't follow Sidecar scope isolation

Describe the bug
Apply config here - https://github.com/istio/tools/pull/75
We have a Sidecar exposing only istio-system/* and withsidecar/*. However, the reviews DestinationRule from the default namespace is used.
Expected behavior
DestinationRules should respect the Sidecar scope. In this case, no DestinationRule should be used for the reviews service, unless we add it to the Sidecar scoping.
Steps to reproduce the bug
See config above
Version
1.1 rc1

Note that version number was most likely 1.1rc1.  rc2 is not out yet

Hopefully this isn't present in rc2 as well then

So this is behaving as expected..
we search for the most specific PUBLIC dest rule for reviews service..
since there is no dest rule in withsidecar namespace, we look elsewhere.
we find reviews.withsidecar.svc.cluster.local in the default namespace and its a PUBLIC rule. So it gets used..
You can hide the rule in default namespae by declaring the exportTo field with value . . Or, you can define the global config root namespace in helm charts. When you do that, we only check calling proxy's namespace, the service's namespace (both of which are withSidecar), and finally in config root namespace (e.g., istio-config).

My understanding was it shouldn't be able to pick up the rule, because we want to be able to have complete isolation. Someone on some other team, etc working in another namespace shouldn't be able to impact another's if they are using the Sidecar resource the and not importing from this namespace.
@rshriram offline:

you have to set the global defaultDestinationRuleExportTo to ‘.’
if you do that, then all dest rules become namespace local only

/cc @costinm you originally brought up this issue, what do you think?

Once again, export means it can be used, not that it forces use of a rule.
Default exportTo should remain public, it is not relevant to this discussion ( except that if a rule has explicit exportTo that doesn't include a namespace, it will not be used ).
If a namespace has an explicit 'egress' section in the Sidecar, and it is not / - than only the namespaces listed in the egress can be used, everything else is isolated. No matter what exportTo they use - the user controls what configs to import, not the exporter.

To be clear: my concern and the P0 are about respecting the "egress" semantics in Sidecar, if it is present.
Separate bug/priority for the case Sidecar is not present, or it imports /.
But in all cases, exportTo will be respected - but won't override the import.

Maybe I'm missing something, but the problem here doesn't appear to be Sidecar import, but rather the default DestinationRule resolution algorithm. A Sidecar's egress section only imports Services, not DestinationRules. Corresponding DestinationRules are imported implicitly along with the services according to the algorithm: 1) proxy's namespace, 2) service's namespace, 3) any-namespace. To take unrelated namespaces out of the lookup path, Istio needs to be configured with a global config namespace, as @rshriram  mentioned above. Then the lookup path will be: 1) proxy's namespace, 2) service's namespace, 3) config root namespace (e.g., istio-config). That would solve this issue right?
Why is that not the default DestinationRule lookup algorithm in 1.1? Backwards compatibility? If so we should really document this and recommend a global config namespace be set.

@howardjohn I think you verified @rshriram's PR.  Is any work left here?

Nope, should be good now.


How should I capture errors returned by Stripe?

Perhaps I'm missing something obvious here (very possible) but I can't seem to work out how to catch and handle error responses from Stripe.
Client:
var update = {
  exp_month: $(this).find('#card_expires').val().substr(0, 2),
  exp_year: $(this).find('#card_expires').val().substr(5, 2),
};

Meteor.call('updateCard', update, function(err, response) {
  // ...
});

Server:
updateCard: function(update) {
  check(update, {
    exp_month: String,
    exp_year: String,
  });
  // Some stuff to get customer and card ids
  Stripe.updateCard(customer.id, cardId, update);
  // Update some other stuff...
},

Stripe = {
  updateCard: function(customerId, cardId, update) {
    check(customerId, String);
    check(cardId, String);
    return stripe.customers.updateCard(customerId, cardId, update);
  },
};

If I pass in an expiry year of 2099 I get this response from Stripe Error: Your card's expiration year is invalid. But the error is thrown before I can grab it so even if I try to check the response from the stripe.customers.updateCard() I can't access it because the error is already thrown and I end up with a sanitised "Internal server error [500]" error on the client.

Use a try catch block in the server.
On 2015 නොවැ 18, බදාදා at පෙ.ව. 5.36 Oliver Lloyd<EMAIL_ADDRESS>wrote:

Perhaps I'm missing something obvious here (very possible) but I can't
seem to work out how to catch and handle error responses from Stripe.
Client:
var update = {
exp_month: $(this).find('#card_expires').val().substr(0, 2),
exp_year: $(this).find('#card_expires').val().substr(5, 2),
};
Meteor.call('updateCard', update, function(err, response) {
// ...
});
Server:
updateCard: function(update) {
check(update, {
exp_month: String,
exp_year: String,
});
// Some stuff to get customer and card ids
Stripe.updateCard(customer.id, cardId, update);
// Update some other stuff...
},
Stripe = {
updateCard: function(customerId, cardId, update) {
check(customerId, String);
check(cardId, String);
return stripe.customers.updateCard(customerId, cardId, update);
},
};
If I pass in an expiry year of 2099 I get this response from Stripe Error:
Your card's expiration year is invalid. But the error is thrown before I
can grab it so even if I try to check the response from the
stripe.customers.updateCard() I can't access it because the error is
already thrown and I end up with a sanitised "Internal server error [500]"
error on the client.
—
Reply to this email directly or view it on GitHub
https://github.com/kadirahq/meteor-stripe-konnect/issues/5.

Yep, that was pretty obvious! Thanks for the quick response.

Hmm, okay, not quite so obvious. Before I start pulling this object apart, is there a sensible way to throw this error when the format of the response is: { [Error: Your card's expiration year is invalid.] stack: [Getter] }?
I presume this is related to this:
          if(err) {
            // stripe uses some custom error type
            // and it's doesn't play well with
            // Meteor's error reporting
            // and that's why we are using this
            var error = new Error(err.message);
            error.raw = err.raw;
            f.throw(error);
          } else {
            f.return(res);
          }

You mean you need to pass this info to the client. Okay grab the message
with err.raw and create a new Meteor.Error and throw.
It's not always good to send server errors to client, specially when there
are money involved. So have a look at to that as well.
On 2015 නොවැ 18, බදාදා at පෙ.ව. 6.47 Oliver Lloyd<EMAIL_ADDRESS>wrote:

Hmm, okay, not quite so obvious. Before I start pulling this object apart,
is there a sensible way to throw this error when the format of the response
is: { [Error: Your card's expiration year is invalid.] stack: [Getter] }?
I presume this is related to this:
      if(err) {
        // stripe uses some custom error type
        // and it's doesn't play well with
        // Meteor's error reporting
        // and that's why we are using this
        var error = new Error(err.message);
        error.raw = err.raw;
        f.throw(error);
      } else {
        f.return(res);
      }

—
Reply to this email directly or view it on GitHub
https://github.com/kadirahq/meteor-stripe-konnect/issues/5#issuecomment-157566254
.

err.raw, that did the trick! Thanks again.
And yes, we'll check the errors that the API sends and make sure we don't give anything away that shouldn't be disclosed.


Getting BadImageFormatException when building for AnyCPU

When I try to use this library and build my project for AnyCPU I get this error:

System.TypeInitializationException: Der Typeninitialisierer für "Sodium.SodiumCore" hat eine Ausnahme verursacht. ---> System.BadImageFormatException: Es wurde versucht, eine Datei mit einem falschen Format zu laden. (Ausnahme von HRESULT: 0x8007000B)

When I build for x64 I do not get errors.

Well, as this library is just a "wrapper" for a native library which are compiled for either 32 or 64 bit, that seems like a reasonable error to get.

I would have expected that the wrapper is able to determine which runtime is currently running to use the correct native library.
Is this unrealistic?

Are you using .NET Core or .NET Framework? If you're using .NET Core, then the correct library should automatically be selected.

Facing this issue only for .NET framework. For .NET Core the library gets loaded correctly. How can I get this working for .NET Framework? The issue seems to be that the libsodium.dll is not getting copied to the output directory during Build

.NET Framework unfortunately lacks some of the capabilities for native libraries that .NET Core has.
That means you basically have two options for a .NET Framework project:

Set the target platform to x64 instead of AnyCPU.
(Note that this does not work with older versions of .NET Framework.)

or

Switch to .NET Core.

What I'm looking for is something like what has been implemented in the repo from which this repo is forked, adamcaudill/libsodium-net. Here, programmatically the libsodium.dll is copied correctly to the output directory. I'm not sure why that code is not in this repository or why it was removed.

This repo was forked to support core only, so no wonder why you’re struggling with .net framework. Why don’t you use the original, that clearly works as you say?


Unexpected $Diff behavior

Let's assume the following type definitions:
type A = {
  a: string,
  b: string,
};
type B = $Diff<A, { a: string }>;

The following two cases behave as you'd expect:
({ b: 'foo' }: B);  // OK; we omit the 'a' property
({}: B); // ERROR; 'b' must be a string

But this is unexpected:
({ b: undefined }: B); // should be an error, but it typechecks

While I know $Diff is not part of Flow's public API, is this expected or a bug?
This is a related question in SO showing why I needed to do something like this. I'd love to find a way to derive a type from another one, so that a property that is mandatory in A (a: string) becomes optional in B (a?: string), without having to modify A (to make it parametric or to extract the varying properties). Any idea for a workaround?

Fixed recently


Please add releases to the repo

https://api.github.com/repos/terryweiss/docstrap/releases returns an empty array
We use the check against the github api to retrieve information of the latest release in our build-environment, these checks won't make sence against tags only.

I think tags no longer get added as releases. I've tagged the latest release and created it as a release, so the array is no longer empty. I'll try and do this for future releases.


Don't Merge! Regression PR perf testing with metadata validation

Docs Build status updates of commit 4cb06bf:
:clock10: Full build: the average full build time is 22 min(s) 57 sec(s), this is based on the last 89 build(s) for this repository.

Docs Build status updates of commit 4cb06bf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

TestingPullRequest.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Error: Unknown action 'undefined'

⚠ Don't use issues for support questions ("How does x feature work in Anchor? How to do x in Anchor?"). Use the discord instead https://discord.gg/NHHGSXAnXk (but don't ping maintainers). ⚠

ylnd-farm
#deposit
Deposit should be failed when using invalid farm account:
Error: Unknown action 'undefined'
at AnchorProvider.sendAndConfirm (node_modules/@coral-xyz/anchor/src/provider.ts:186:31)
at processTicksAndRejections (node:internal/process/task_queues:95:5)

I mistakenly passed an uninitialized farm account, which was correct according to the test suite. However, I didn't notice the logs at the time. Upon reviewing the logs, I saw that the function was indeed called, and the expected error matched what was logged. It would be helpful if Anchor provided the actual error directly, as seen in the program logs.
Closing this now.


Update helm chart to allow use on local, Azure or AWS

Update annotations / config options / helm chart

Resolved in https://github.com/DSD-DBS/capella-collab-manager/commit/72b0fc9be154f2fe1149e0236c1ff54a93ef5265


Missing @context serialize

We are witnessing some strange behavior when using SERIALIZER.serialize(Message header). When sending multiple ContractOfferMessages between two Connectors, some fail to send (or are rejected by the receiver)
Together with @vdakker we were not able to reproduce this in a test case with the same message and repeated testing. But using the debugger we found some moments, where Messages are marked as "The following mandatory field(s) of ContractOfferMessage are not filled or invalid: ids:securityToken, ids:issuerConnector, ids:senderAgent, ids:modelVersion, ids:issued...".
A screenshot of one such situation (the jsonLD String does not contain a context field):

We are using infomodel-serializer-4.2.3

@steffen-biehs @jschne1der @Syd7 On the basis of the information provided in the ticket, we tried to reproduce the issue with more number of threads(4 of each object) as shown in the screenshot but test is still passing. Hence we are unable to reproduce this issue from our end.

@steffen-biehs On our side, it seems to happen when using ECS with AWS Fargate, but apparently not when using ECS with EC2 instances. In case you are working on AWS...

Hello everyone, it took as some time to understand what was going on. We still cannot reproduce it in our development environments.
Anyway, it looks like a static reference in the serializer code that controls whether or not was the problem. We made it thread-safe and merged a fix into our code base. The 4.2.8 release of the serializer should have this fix.

Can anyone from the DSC team test 4.2.8-SNAPSHOT in the meantime? @ronjaquensel did a first check already and wasn't able to create the error again.

Your 4.2.8-SNAPSHOT release fix the bug in my test.

Thanks for the feedback. I close the ticket as the problem seems to be solved.


Emit typings

The package was not emitting typings so consumers were seeing typescript errors when importing TailwindProvider.

Cheers :100:

Released in 0.0.23


Makefile tweaks to fix make shell

Also, bump the Dockerfile to use the latest Golang image, as most of our testing is now done on 1.11
Fixes: #1999

(I'm not really sure what the tmpfs was doing there in the first place, but I think we can safely just remove it...)

/approve

LGTM, although I'm still not able to run ginkgo tests on the resulting containter....
go test -v test/e2e/libpod_suite_test.go test/e2e/images_test.go
# command-line-arguments [command-line-arguments.test]
test/e2e/libpod_suite_test.go:30:32: undefined: ALPINE
test/e2e/libpod_suite_test.go:30:40: undefined: BB
test/e2e/libpod_suite_test.go:59:3: undefined: CACHE_IMAGES
test/e2e/libpod_suite_test.go:78:24: undefined: CACHE_IMAGES
test/e2e/libpod_suite_test.go:118:20: undefined: STORAGE_OPTIONS
test/e2e/libpod_suite_test.go:347:40: undefined: ALPINE
test/e2e/libpod_suite_test.go:356:40: undefined: ALPINE
test/e2e/libpod_suite_test.go:367:40: undefined: ALPINE
test/e2e/libpod_suite_test.go:378:40: undefined: ALPINE
test/e2e/images_test.go:48:48: undefined: ALPINE
test/e2e/images_test.go:48:48: too many errors
FAIL	command-line-arguments [build failed]

@baude I think this is a result of the multiarch work - can we set whatever's necessary automatically here?

@TomSweeneyRedHat add test/e2e/images_test.go test/e2e/config.go test/e2e/config_amd64.go to your command

/lgtm

@baude, that works like a charm.  I'll update the README.md with my submit.  Thanks!


Move all tests to createRouterTransport from connect

The prior approach this package took to testing was a means to an end, but came with some issues.
We here at Buf put our heads together and came up with createRouterTransport which allows testing simulated connect backends without having to run a webserver, but still going though the same codepaths the code would go through in production.
This is a vast improvement.  (more documentation on "how to do testing with Connect Query to come in the future!)

@paul-sachs and that's not even the best part! lol.  it also WORKS much better and is actually correct.  As you may have noticed, it turned out with the "mocking fetch" approach we were returning things in one or two small cases that a real Connect server wouldn't quite return.  That, to me, is all the justification needed!  If you can't trust your tests... haha.. what can you trust :small_airplane:?


Quick prayer

Could you add quick prayer sound to the list?

The sound of quick prayer is just the combined sounds of the prayers you're turning on with it.
The actual beeping sound from it is:
2266
I will not be adding it, 2266 is used throughout the game and not just for quick prayer button being pressed.


v2.0-rc

User story
The scope of this story is to encompass the following open issues to be delivered. The following list is prioritized.
Prior to next major release
It is important that we communicate prior to the next major release that we will be changing the npm namespace.

[ ] https://github.com/AlaskaAirlines/auro-flight/issues/20

Dependency

[ ] https://github.com/AlaskaAirlines/auro-iata/issues/2
[ ] a11y features #8

Outline subtasks or tasks

[ ] update boolean API #11
[ ] SEO structured data #5
[ ] upgrade #7

Development process
This is a placeholder issue for all the issues to be in a single release. As each issue is put into play, please update the issue as IN PROGRESS and move it into the WIP column. Please leave this issue in TO DO until all linked issues are completed.
Definition of “Done” (exit criteria)
This issue will be considered complete and all features released once all issues listed are considered complete.

closing this rc in favor of issues and milestones


SVG Parsing Error

We have an svg with a large base64 encoded image (attached) that is not parsing correctly.
file = Nokogiri::XML(File.read('DM_V3-front.svg'))
file.remove_namespaces!

file.xpath('//image/@href').count             # => 0 (should be 1)
file.xpath('//image').count                   # => 1 (it is finding the image like this)

The problem is that when the svg is parsed it turns the href attribute into text outside of the image tag for some reason.  This only happens when the base64 data is quite large, smaller base64 encoded images work fine as far as we can tell.
The sample file below illustrates the issue and has only one image to facilitate reproducing this.  I would be happy to look into this issue further if someone could point me in the right direction.
DM_V3-front.svg.zip

libxml and therefore nokogiri have some hardcoded limits about the maximum sizes of elements. You can disable them by:
file = Nokogiri::XML(File.read('DM_V3-front.svg'), nil, nil, Nokogiri::XML::ParseOptions::HUGE)

This should solve your issue.

Out of curiosity is this documented somewhere that I missed. I don't recall seeing anything about that option but I may have just missed it in the docs. In all honestly I probably should have dug into the source a bit.

It's an implementation detail of libxml2, so although the parse options are documented, this particular option is not mentioned in the tutorials.


Fix enum forms in web ui wizards

The name field wasn't being populated, so it was appearing to not have a
value to the validation code. This meant any plugin using an enum for
its options could not be filled out on the web UI.

On second thought, we'll do release notes when we land some more changes that are in-flight.


fix(addon-mobile): Sheet disable scroll snap for Firefox

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] The commit message follows Conventional Commits
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Refactoring
[ ] Code style update
[ ] Build or CI related changes
[ ] Documentation content changes

What is the current behavior?
Closes #3796
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Is it expected?
https://user-images.githubusercontent.com/12021443/226819430-d22c82fe-410b-4964-baa6-ecb5def167c4.mov
https://user-images.githubusercontent.com/12021443/226819552-9e560e46-b235-4a72-a260-75fecb9c28dc.mov
https://user-images.githubusercontent.com/12021443/226819721-26755411-b83f-4a85-91ec-84d42dad0c10.mov

@splincode it's best to test on real mobile device. Unfortunately there's a lot of issues on Firefox I couldn't solve. We could try to solve not opening it for the first time but as a separate issue because I can no longer spend time on mobile Firefox as it seems to account for about 0.5% of users. Problem with it not opening the first time is image loading and changing dimensions, I believe.


KickMate

Is your feature request related to a problem? Please describe.
A website for football geeks, where one can search, follow up and enjoy loads of match videos from his favorite teams with a funny UI and interactive space.
Describe the solution you'd like
The data comes from a third party REST endpoint and the UI is designed with React and simple CSS.
Additional context
As a contributor to GSSOC '22, I myself am keen to implement this idea.

Assigned u @dasgupta002


ObjectMapper serialisation error for LocalDateTime

ObjectMapper is not able to serialise LocalDateTime and throws:
com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Java 8 date/time type `java.time.LocalDateTime` not supported by default

What were you trying to accomplish?
Expected Behavior
able to serialise LocalDateTime
Current Behavior
exception is thrown
Possible Solution
running findAndRegisterModules
Steps to Reproduce (for bugs)

have a Idempotent method that returns an object with a field of LocalDateTime

Environment

Powertools version used: 1.5.0
Packaging format (Layers, Maven/Gradle): Maven

How to enable debug mode**

# paste logs here

Won't fix, see https://github.com/awslabs/aws-lambda-powertools-java/pull/1135#issuecomment-1542115077
Use: JsonConfig.get().getObjectMapper().registerModule(new JodaModule());

@jeromevdl
The suggested workaround above becomes more complicated in a multi-threaded environment. Especially when the thread is created by an external framework such as Spring Cloud Function. Any particular reason why the ObjectMapper in JsonConfig is wrapped in a ThreadLocal? I believe the ObjectMapper is supposed to be thread safe after it has been configured?
I'm interested in using the idempotency library with a customized ObjectMapper, but without configuring the ObjectMapper every time a new thread is created. Either being able to set the initial value provider of the ThreadLocal or removing the ThreadLocal would solve this use case.

Thanks for the feedback. You are right ObjectMapper is thread safe and we could initialize it as static, but changing its configuration is not thread safe after. @scottgerring , we should discuss this quickly this week

@jeromevdl @scottgerring
Did you have time to discuss this? Any updates?

Unfortunately, not that much. This is a topic we have in mind and would need to change. The issue is that ObjectMapper cannot be safely modified once configured. Maybe what we should do is the ability to provide your own ObjectMapper, just like we do with the SDK clients. @scottgerring WDYT?


Add EmployeeSalaryKey and EmployeeAlternateID

@puneet-sutar Could you please review this? Seemed pretty straight-forward

@puneet-sutar No, this is only available on Instant based on their documentation


Alpine-Nextcloud LXC script broken, asks for unknown login on first boot

✅ Have you read and understood the above guidelines?
yes
📜 What is the name of the script you are using?
Nextcloud LXC
📂 What was the exact command used to execute the script?
bash -c "$(wget -qO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/alpine-nextcloud.sh)"
📝 Provide a clear and concise description of the issue.
When setting up an alpine-linux based LXC for nextcloud using the script from the page here, you are immediately thrown into a login page with no further info.

Doing some research, you are apparently supposed to throw the script once again into the lxc itself, but while that beigns some sort of process, it crashes at the second step. See below.
⚙ What settings are you using?

[X] Default Settings
[ ] Advanced Settings

🖥 Which Linux distribution are you using?
Alpine
🔄 Steps to reproduce the issue.
Follow the normal install process.

❌ Paste the full error output (if available).
`  💡  Figlet for ASCII-Header not found. Installing...
tar (child): xz: Cannot exec: No such file or directory
tar (child): Error is not recoverable: exiting now
tar: Child returned status 2
tar: Error is not recoverable: exiting now
[ERROR] in line 209: exit code 0: while executing command tar -xf "$temp_dir/figlet.tar.xz" -C /tmp/figlet --strip-components=1`
🖼 Additional context (optional).
No response

Can you try again in the next 10+ Min?

I did try it, no change so far.
Asks for Username and Password on first boot

Ah! When I put the same command again (2nd time in the container), it works!
Also the color of the window is not blue, it's black. No idea if that helps.

That's another mistake and doesn't belong here. The original issue has therefore been resolved.

I guess there are two problems on the same topic or it is a consequential error from the first one?
He has error 209 I had 47.
I had to put in the LXC the shell command 2 times, then it works.
So the error is exactly what the topic says


Draft: improvement/optimize_hhl_classiq

Currently the inverse QPE seems to be multiple times the depth of the QPE, which seems to be a classiq bug. I raised the issue on Slack and they are investigating whether this is indeed a problem of the circuit or of the visualization only.


Strengthen MiMa checks

Using the latest patch release of the current minor version may lead to some breakages that are not properly checked/tagged in the MiMa filers. For example, if we accidentally introduce a breaking change in 3.M.1 but check against 3.M.2, we would lose this breaking change before the next minor release. If we would check against 3.M.0, we would catch this.
In general we need to track all the changes that have happened in the current minor version. There should not be any breaking changes unless the PR needs a minor release.

I've re-ran the failed tests. It seems to be an inconsequential flake.


infinite recursion encountered when using overrides

Original occurence, including full trace: https://github.com/srid/emanote/pull/290#issuecomment-1141187436
Minimal repro: https://github.com/srid/haskell-template/compare/overrides-bug

Could you try chaing attrsOf to lazyAttrsOf everywhere? https://github.com/hercules-ci/flake-parts/issues/22#issuecomment-1141234923


Added more countries, we can now detect at least 231 countries.

Used the list at http://www.geonames.org/countries/ to add several more countries to the list.

nice! thank you!


LIS3MDL temperature not working

For some reason I get total garbage ... makes me concerned about the mag readings.

fixed


Dockerfile runs as root

See https://medium.com/@mccode/processes-in-containers-should-not-run-as-root-2feae3f0df3b and https://docs.docker.com/v17.09/engine/userguide/eng-image/dockerfile_best-practices/#user.

Fixed


Add support for named entrypoints

LDW exemption: CR-849919
What this PR solves / how to test

(updated by @mrbbot)
This PR adds support for named entrypoints to wrangler deploy and wrangler (pages) dev. This also enables support for JS RPC over multiple wrangler dev sessions.
Service bindings to other wrangler dev sessions are now implemented with workerd-native external service bindings instead of middleware. This is required to use Cap'n Proto over HTTP for JSRPC. This middleware was the last middleware that wrapped the env object. Code for wrapping env has been removed from the middleware loader. Implementing this for WorkerEntrypoints would've required us to look for named exports and apply env wrapping to all of these.

Author has addressed the following

Tests

[ ] TODO (before merge)
[x] Included
[ ] Not necessary because:

Changeset (Changeset guidelines)

[ ] TODO (before merge)
[x] Included
[ ] Not necessary because:

Public documentation

[x] TODO (before merge)
[ ] Cloudflare docs PR(s): https://github.com/cloudflare/cloudflare-docs/pull/...
[ ] Not necessary because:

Okay, once these pass, I'm merging and will follow up with another PR to bump to the latest workerd version 🚀


Uncaught TypeError: Cannot read property 'children' of null

I am getting this error
Uncaught TypeError: Cannot read property 'children' of null
updateSimpleFrame @ react-list.js:287
updateFrame @ react-list.js:264
What could be the root cause for this issue.

<ReactList
itemRenderer={::this.renderItem}
length={items.length}
type={'simple'}
/>'
This my configuration...

Please reproduce the issue in a jsfiddle/codepen/jsbin/takeyourpick.


Install JDK from Ubuntu repository. Add job for ARM64

Oracle 8 is not available at TravisCI anymore.
Run mvn verify instead of mvn package to execute any integration tests if there are such.

Any feedback on the suggested changes ?


[Typo/Bug]. Incorrect classifications under epithelial cell

epithelial cell
EquivalentTo: 'animal cell' and ('part of' some epithelium)
=> various misclassifications
e.g.

Relaxing the EquivalentClass axiom to subClassOf fixes this and reduces subclasses  from 664 to 643.
I think this is probably the right approach to fixing, but it is worth surveying the cells lost to this classification for anything that should be manually asserted.

These are the direct subclasses that get removed when switching from equiv to subclass
amnioserosal cell <- this currently doesn't have description etc. on CL, might need to ask a fly person to help add those in? but I think it is an epithelial cell according to https://www.pnas.org/content/105/1/234 (happy to assert it)

"Higher cyclorrhaphan flies including Drosophila develop a single extraembryonic epithelium (amnioserosa), which closes the germband dorsally."

reticular layer of dermis fibroblast <- this was the weird one that you were mentioning above I'm guessing
yolk sac hematopoietic stem cell <- seems appropriate to be removed


[graphql/rpc] easy: add initial server config struct and file loader

Description
Adds ServerConfig type which will be used to drive all server configs from a yaml file
Test Plan
TBD

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] protocol change
[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

It seems like both ServerConfig and ServiceConfig are file-based configurations for this service.  Originally, I kept ConnectionConfig out of ServiceConfig because I thought we might want to configure connections differently for instances of the service that might otherwise share parameters (in ServiceConfig), so they stayed as command line parameters and had their own struct.
Now it seems like these are also being configured in a file, it begs the question, do we need two different files for configuring the service?


(feature) add subnavigation

We have now had lots of user feedback suggesting the links in the top bar are not easily findable.
This applies to:
'list a job at your school'
'my jobs'
'log out'
'Teaching Jobs'

This PR removes the proposition links from the GOV UK header, and places navigation in a more obvious pattern beneath the phase banner.
Before:

After (unauthenticated):

After (authenticated):

 Changes to the sub-navigation links in the top bar to make them more findable


Bug: text overlaps footer on success criterion pages

A user has reported a bug with body text overlapping the footer on success criterion pages such as 3.2.1 On Focus.
They have said "I am using Chrome. It happens in every criterion. the bottom part of the page overlaps, as you see. (...) My browser is at 100% but I am suing a 32! screen, LG, and my windows system screen is setup to be 125%. I have a mild low vision, that's why I setup my OS to be at around 125%, if that makes sense"

I have tried but struggled to replicate this at a range of Chrome window sizes, on Windows with the operating system zoom set at 125%.
However I'll keep this open in case we are able to find the cause.


Add uploading property to six-file-upload

What problem does this feature solve?
In order to give the end-user some feedback when he is uploading a file, the six-file-upload should be able to show a spinner during the upload operation.
What does the proposed API look like?
Add an uploading boolean property to the six-file-upload. It would default to false. Whilst it is true the component would show  a six-spinner instead of its label and input, and dropping or selecting a file would be disabled.

I would like to publish a PR with this change implemented, but it seems I am not permissioned to push a branch to that repo?

Hi @franckdervaux
You cannot push directly to this repository, in order to contribute you need to fork the repository, commit the changes there and then propose the changes via pull request.
In the github docs here it's fully explained: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/fork-a-repo


Add ENVOY_EXECUTION_SCOPE.

Add ENVOY_EXECUTION_SCOPE to mark the start and end of a Envoy::Tracing::Span or Http::FilterContext, which is active in the current thread.
This macro only takes effect when ENVOY_ENABLE_EXECUTION_SCOPE is defined.
Commit Message: Add ENVOY_EXECUTION_SCOPE.
Additional Description:
Risk Level: No. It is no-op unless ENVOY_ENABLE_EXECUTION_SCOPE is defined.
Testing: Unit test in test/common/common/execution_context_test.cc.
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/assign @wbpcode

@wbpcode do you have an open PR we can reference from this one so we can track when this gets unblocked?
/wait

@wbpcode do you have an open PR we can reference from this one so we can track when this gets unblocked?
/wait

got it.

wait https://github.com/envoyproxy/envoy/pull/36277

@wbpcode : Could you please take another look at this? I've merged past your PR https://github.com/envoyproxy/envoy/pull/36277. Thanks.

/retest

@wbpcode : I just updated the code per your comments. Can you please take another look? Thanks!

Got it, will take a look today. I think it will be landed soon.


Replace DAPS with SSI in Helm charts

WHAT
Changes all Helm charts to use SSI/MiW instead of DAPS.
Adds a -legacy helm chart that still uses DAPS, intended as a fallback.
WHY
Replace DAPS with SSI
FURTHER NOTES

One chart tractusx-connector-legacy will be left in place that still contains DAPS for fallback purposes. However, this is discontinued and will not be supported anymore. There is no deployment test for it, and it's scheduled for removal in upcoming releases.
updated docs/samples/example-dataspace
fixed a small bug in our e2e tests, where the MockWebServer didn't get re-instantiated on every test

Closes # <-- insert Issue number if one exists

\cc @jimmarino

LGTM, just a minor nit on example dataspace README.
I've tested the chart on a local machine with a real MIW and Keycloak running.
Tested with MIW revision catenax-ng/tx-managed-identity-wallets@bed8bd6

Thanks @wolf4ood for doing this 🤟 I think we're on a good track then!


Upgrade maven-shade-plugin from 2.4.1 to 3.1.0

Codecov Report

Merging #922 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #922   +/-   ##
=========================================
  Coverage     66.04%   66.04%
  Complexity      769      769
=========================================
  Files           171      171
  Lines          3240     3240
  Branches        369      369
=========================================
  Hits           2140     2140
  Misses          940      940
  Partials        160      160

Sorry, just seeing this -- but looks good from what I can tell.

Sorry for the delay. Problem solved.


Validation problem

Hi!
When I use dropdown with ngModel, control is always touched (before any user actions)
<form #editorForm="ngForm">
	...
	<ss-multiselect-dropdown
		[options]="regions" [(ngModel)]="selectedRegions" [texts]="texts"
	[settings]="settings" name="selectedRegions" required></ss-multiselect-dropdown>
	<div *ngIf="editorForm.form.controls.selectedRegions?.touched && editorForm.form.controls.selectedRegions?.errors?.required" class="alert alert-danger">
		Error!
	</div>
	...
</form>

So I get validation message right after the form is loaded.
Is it a bug?
Thanks!
P.s. it started when I upgraded version from 1.0.2 to 1.6.0

Tried to reproduce Your problem but without a success
https://stackblitz.com/edit/angular-dya6xv
Can You provide working example ?

Hi!
Thank you for responding
I missed one important thing: in my application I get regions from the server. Here I've just added setTimeout to yous example.
https://stackblitz.com/edit/angular-d4skmt
And one more thing. In you example dropdown becomes touched only after it's value is changed (it always becomes touched and dirty at the same time). But it should become touched when it loses a focus at the first time. Here you can see the differece between this dropdown control and a default select:
https://stackblitz.com/edit/angular-iwehra

Same problem here.
@iRodchenkov I use workaround: with custom directive on multiselect I use DI to get ngControl of item. Then I just take
this.ngControl.valueChanges
            .first()
            .subscribe((value) => {
                this.ngControl.control.markAsPristine();
                this.ngControl.control.updateValueAndValidity();
            });

I have the same issue here too.
There's any default definitive solution?
Hey @kareljuricka, could you be more specific about your workaround? How is this custom directive of yours? Could you show more of the  code?


Data stopped updating

Data has been stale for the last hour. If you look at https://github.com/sebsebmc/helldivers-history/actions and under the scheduled job "Commit and push if it changed" there are multiple runs that had no new data. Is this a fallback of some sort?

https://helldivers.io does also appear to be breaking right now so I assume the underlying data is getting messed up or broke sume assumption.

The in-game war progress is similarly frozen so it appears this is not a gault of the relay server but of the actual game backend servers. Feel free to close (or leave open to prevent more issues being opened for now)

We'll leave this open until resolved, in the hopes the community finds a solution/workaround

Data seems to be coming back. Not sure there is much chance of a workaround when the devs froze the way state intentionally.

Given this API is essentially a fancy proxy for AH's endpoints not much that can be done when they freeze the API endpoints..


feat: add trace width

Closes - https://github.com/tscircuit/tscircuit/issues/264
The width is changeable

@seveibar I didn't get what you mean't by your comment. I was having the basic idea that if traceWidth is passed as a prop to <tracehint /> then you use that width. Do you mean that the tracehint which the user edit's like in this video that needs to be changed?
https://github.com/user-attachments/assets/ba9f0596-1544-4b17-8a9b-71702b3858c0

@imrishabh18 each point on the route can has it's own trace width, then the line will shrink or grow to fit the traceWidth at each point along the route.

I see, so for soup to look like that the traceWidth prop value should be passed inside the offsets right? Like this for that traceHint to be of that size?

@imrishabh18 yep both are acceptable syntaxes that do slightly different things

@seveibar This is how the trace_widths can be modified according to the route.

@imrishabh18 looks a bit strange, will pull and take a look

For the example i might choose a more dramatic trace width difference, eg 20, 1

This is how it looks for the dramatic 20 width 🤔. Now I get what you mean't by that buldge

This will need more work, and could be complex for making that buldge. Will merge this as a decent progress and then can work more upon it


intmap: let ForEach stop early

This commit changes the signature of the closure passed to ForEach so that it returns a boolean, which determines if the iteration should stop early or continue.

When will someone want to stop early, when iterating a map? There is no guaranteed iteration order... Is this to support the future range-over-func specification in Golang, searching for a specific value, or something else?
If we break API I just want to make sure that we have a real solid reason! :sweat_smile:

If you're building out some external data structure based on an intmap.Map, and at some point during the iteration you no longer need any more items, then you want to early stop.


Prepare SP1 Cloud repositories also for SP2-enabled Cloud

If installed with SP2 support, we will still need for some time
to also install SP1 nodes. Some packages needed for nodes installation
are located at Cloud add-on, so it needs to be available.
I know it is ugly, but other than that... what could possibly go wrong?

Assuming this works, +1.

If anyone wants to look, crowbar.vi5.cloud.suse.de is being installed with want_sles12sp2 and this PR.

+1

Still +1 for me.

+1


text_json_diff/fix: Keep an order of filter and remove duplicated filters. (#2172 #2170 #2151 #1845)

2024-02-09 07:16:57.405 | DEBUG    | changedetectionio.processors.text_json_diff:run_changedetection:119 - include_filters_from_tags=[]type(include_filters_from_tags)=<class 'list'>
@dgtlmoon  Could you confirm include_filters_from_tags and include_filters are always a list type?
I borrowed an idea from https://stackoverflow.com/a/17016257/20307768
related PR : https://github.com/dgtlmoon/changedetection.io/pull/2151
closes https://github.com/dgtlmoon/changedetection.io/discussions/2170 #2172

ahh i didnt add a test for this in test_group.py :(

I tried but it looks tricky.
#!/bin/sh
for loop in 1 2 3 4 5 6 7 8 9 10; do
python -s <<EOF
print(list({ *['#only-this'], *['//body/b[1]', '/html/body/b[2]'] }))
#print(list([ *['#only-this'], *['//body/b[1]','/html/body/b[2]']]))
#print(list(['#only-this']  + ['//body/b[1]','/html/body/b[2]']))
EOF
done

And run this
num = 0
while num < 1000:
    print(list({*['//body/b[1]', '/html/body/b[2]'], *['#only-this']}))
    #print(list([*['//body/b[1]','/html/body/b[2]'], *['#only-this']]))
    #print(list(['//body/b[1]','/html/body/b[2]'] + ['#only-this']))
    num += 1

do you need more time on this one?

It looks fine to me... But do you agree with the test method?

I will post candidate 2 within an hour.

candidate 2 : https://github.com/dgtlmoon/changedetection.io/pull/2178


URLs to video files seems broken

The video files that the setup script is trying to download does not seem to be available anymore?

you're right, maybe it's a temporary thing otherwise i think we can host the file, it seems to be free to be used


zero subarray problem

added a code for zero subarray problem . link of the problem given  : https://practice.geeksforgeeks.org/problems/subarray-with-0-sum-1587115621/1

Hey, @Soham20chak Add Problem link in your code in the comments I can't see it.


Update Design + Embed Podcast

Remove Grunt
Use NextJS to compile sass
Upgrade dependencies
Improve performance
Update design, colours and icons
Update fonts and copy
Embed Changelog podcast

This looks amazing mate! I'm always impressed.


Specify that this is depricated

Now that .Net Core 3+ has replaced .Net Framework, all the pages for Microsoft Fakes should be marked as legacy.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b356f491-a828-65ee-915b-b1ccdf71024c
Version Independent ID: 3fa9dddf-b328-8e2f-c7b2-016a38f71bf6
Content: Using shims to isolate your application for unit testing - Visual Studio
Content Source: docs/test/using-shims-to-isolate-your-application-from-other-assemblies-for-unit-testing.md
Product: visual-studio-windows
Technology: vs-ide-test
GitHub Login: @jillre
Microsoft Alias: jillfra

@JoshuaHillerup Can you contact me internally - ghogen at microsoft.com - I have some questions about this.

@JoshuaHillerup Can you contact me internally - ghogen at microsoft.com - I have some questions about this.

Emailed

As I understand it, Microsoft Fakes is still a supported framework that supports .NET Framework, but not .NET Core.  .NET Framework is not legacy, it's a supported technology.


move to rust 1.49 + dpdk 19.11.6 (LTS)

Associated with https://github.com/capsule-rs/capsule/pull/120 as well.
Images have been pushed up to hub.docker.

[ ] update submod once https://github.com/capsule-rs/capsule/pull/120 is reviewed/in.

there's seems to be some new azure fun in container land, I'll take a gander.

there's seems to be some new azure fun in container land, I'll take a gander.

@drunkirishcoder ok. these errors are not our fault!
https://www.ubuntuupdates.org/package/core/bionic/main/proposed/linux-azure-5.4-headers-5.4.0-1032 is a missing package. My guess is the GH-Actions hosts needs to update their kernels as there was a somewhat minor kernel regression. For example, https://packages.ubuntu.com/bionic/linux-headers-5.4.0-1034-azure is more recent and the package is there.

@drunkirishcoder ok. these errors are not our fault!
https://www.ubuntuupdates.org/package/core/bionic/main/proposed/linux-azure-5.4-headers-5.4.0-1032 is a missing package. My guess is the GH-Actions hosts needs to update their kernels as there was a somewhat minor kernel regression. For example, https://packages.ubuntu.com/bionic/linux-headers-5.4.0-1034-azure is more recent and the package is there.

So, @drunkirishcoder I've pushed these up locally, and I you can run them and double-test. I think we can just bypass this, as we hope they update the kernel (sub)-version soon.

So, @drunkirishcoder I've pushed these up locally, and I you can run them and double-test. I think we can just bypass this, as we hope they update the kernel (sub)-version soon.

Closing and re-opening with 1.50.


Abstract even more the Adapter

Hey guys, first of all, nice work ! Just found the lib and it seems pretty cool !
Since today a lot of devs (including  me) are moving away from Frags to View-based Apps, I think it would be cool to abstract even more the StepAdapter, so people like me could still use the lib, implementing the abstract Adapter methods, not obligatory using Frags.
I'd be happy to drop a PR, if you guys are interested !
Thanks

Hi,
That seems like a nice enhancement. We'll gladly review your PR :)

@zawadz88 Thanks for the quick reply !
Just a few points:
I was thinking about just abstracting away the findStep and createStep methods.
And also the generics would inherit only from Step, not Fragment.
The class would inherit from PagerAdapter.
How does that sound ? Also, how should we name it ?
Thanks

@leonardo2204 I think that ideally we would want to have both options i.e. to be able to use a fragment adapter since a lot of people are using it this way and we don't want to take that away from them + a simpler version using views.
Therefore I think we might want to create some sort of an interface for the step adapter with createStep, findStep & getNextButtonText methods and create two implementations - one inheriting from FragmentPagerAdapter as it is now and a second one inheriting directly from PagerAdapter.
What do you think?

Sounds like a plan !
I'll see if I can come up with something until the end of the day !
Thanks

I'm just implementing it and I was wondering if passing ViewPager as a parameter to findStep is really necessary.
IMHO, it seems more logical to pass a long (or int) named id.
Using the lib I usually create internal ids.
I'll drop the PR with the ViewPager version because this would be a breaking change, which is not the point of this enhancement.
Thanks :)

I've stumbled upon something when implementing the feature.
I created the interface and throughout the code, I realized you were passing the AbstractStepAdapter. So, to change, I was passing the Interface.
Here comes the problem:
public void setAdapter(@NonNull StepAdapter stepAdapter) {
        this.mStepAdapter = stepAdapter;
        mPager.setAdapter(stepAdapter);

        mStepperType.onNewAdapter(stepAdapter);

        // this is so that the fragments in the adapter can be created BEFORE the onUpdate() method call
        new Handler().post(new Runnable() {
            @Override
            public void run() {
                onUpdate(mCurrentStepPosition);
            }
        });

    }

So, as Java doesn't allow multiple inheritance, how should I proceed now ?
Thanks


Update the header text for the Conferences page for Swahili

The page description at the top should be translated but since the conference information is pulled in via JSON, there is no need to translate it.

Noted


Multiple packages provides same command, but we should have some preferred by default

Sorry, I could not find a better title for this issue. Feel free to retitle it.
$ tea<EMAIL_ADDRESS>version
× multiple projects provide<EMAIL_ADDRESS>│ pls be more specific:
│
│     tea +go.dev<EMAIL_ADDRESS>version
│     tea +encore.dev/go<EMAIL_ADDRESS>version
│
╰─➤ https://help.tea.xyz/ambiguous-pkgspec

Look, I get it. Multiple packages provides the same command and we should allow the user to select it.
However, in some cases, 99% of the users would prefer one package (in this example go.dev), so I believe tea should have smarter defaults. The 1% who is actually trying to use encore.dev/go will probably know how to handle it (i.e. tea +encore.dev/go go version).
Note that for the example above, only go.dev provides an actual version within that specified range @1.18, nevertheless, I don't think we should use that as the primary selection algorithm. MAYBE as fallback it would be nice. I'm thinking about an hypothetical situation where openjdk.org would cease having new packages and then adoptium.net/temurin starts publishing only newer packages. In this (very corner) case, it would be reasonable to fallback to openjdk.org if can't find in adoptium.net/temurin (and obviously none was specified by the user).
My suggestion would be to extend the pkg manifest with something like:
# https://github.com/teaxyz/pantry/blob/main/projects/go.dev/package.yml

provides:
-  - bin/go
-  - bin/gofmt
+  - name: bin/go
+    preferred: true
+  - name: bin/gofmt
+    preferred: true

Or maybe default: true. False by default. When multiple packages provides that command, but none has set a preferred: true, throw error message like today. When multiple packages provides that command, but one of them has set a preferred: true, use that without throwing the error.
Backwards compatibility with existing package manifests can be kept. If the string form is found, assume name to be the string and preffered to be unset.
The Pantry CI must have some test to verify that the same command isn't defined as preferred by multiple packages.
Related to https://github.com/teaxyz/cli/issues/744, but this problem isn't limited to tea install.

I agree that this is a clear case for a default and the pantry should be extended to handle this. Eventually.
In the meantime I wonder if encore.dev/go should have its provides commented out.

https://github.com/teaxyz/pantry/commit/c90d3977b73af7f67096829740ac24275239386a


The filename suffix is MP3, but in fact his encoding is AAc

I use your example，I gave him the file name in MP3 format,But the fact is the AAC format，How to make him a real MP3 format?

There is no way to do this with the library (and there is no mp3 encoder in the Android API: link). I can only suggest to use ffmpeg to convert recorded audio to mp3 files.


sacct does not work on ondemand with cc-slurm 3.x

Version
1.0.40
In what area(s)?

/area administration
/area ansible
/area autoscaling
/area configuration
/area cyclecloud
/area documentation
/area image
/area job-scheduling
/area monitoring
/area ood
/area remote-visualization
/area user-management

Expected Behavior
sacct should work on the ondemand node
Actual Behavior
$ sacct
sacct: error: slurm_persist_conn_open_without_init: failed to open persistent connection to host:localhost:6819: Connection refused
sacct: error: Sending PersistInit msg: Connection refused
sacct: error: Problem talking to the database: Connection refused

Steps to Reproduce the Problem
install az-hop with cc-slurm 3.x and slurm 23.x
Solution
The problem is that /anfhome/slurm/config/accounting.conf is configured to point to localhost:
AccountingStorageType=accounting_storage/slurmdbd
AccountingStorageHost="localhost"
AccountingStorageTRES=gres/gpu

However, slurmdbd only runs on the scheduler node (sacct works fine there).
To fix, change localhost to {{ scheduler.name }} from the config file.
(there used to be logic for this in the slurm.conf.j2 template, but it seems this is no longer used with cc-slurm 3.x)

I've open a bug in CC https://github.com/Azure/cyclecloud-slurm/issues/215
Working on a workaround


fix compile failed in JdbcExecutor

Proposed changes
Issue Number: close #xxx
Problem summary

PR #18187 use the api resizeColumn in JNINativeMethod has been removed by #17960
revert PR #18306 to fix pipeline core when load

Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.25 seconds
stream load tsv:          452 seconds loaded<PHONE_NUMBER>9 Bytes, about 157 MB/s
stream load json:         22 seconds loaded<PHONE_NUMBER> Bytes, about 102 MB/s
stream load orc:          72 seconds loaded<PHONE_NUMBER> Bytes, about 14 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230404062947_clickbench_pr_124526.html

run buildall


No way to SELECT on uuid column types with operator overloaded

After adding the optional operator overload, it seems impossible to select on the native uuid type. The following scenario occurs:
CREATE TABLE mytable (val UUID);

SELECT * FROM mytable WHERE val = 'c67a7925-e109-4abe-9d50-8c2a96a55483'::uuid;

Error:
typeid prefix must match the regular expression [a-z]{0,63}
CONTEXT:  PL/pgSQL function typeid_print(typeid) line 9 at RAISE

I suspect it's due to postgresql's operator type resolution, but I have no clue why typeid_print is being called.
Any ideas?

I'm blind.


Add celery-exporter

Metrics

Name
Description
Type

celery_task_sent_total
Sent when a task message is published.
Counter

celery_task_received_total
Sent when the worker receives a task.
Counter

celery_task_started_total
Sent just before the worker executes the task.
Counter

celery_task_succeeded_total
Sent if the task executed successfully.
Counter

celery_task_failed_total
Sent if the execution of the task failed.
Counter

celery_task_rejected_total
The task was rejected by the worker, possibly to be re-queued or moved to a dead letter queue.
Counter

celery_task_revoked_total
Sent if the task has been revoked.
Counter

celery_task_retried_total
Sent if the task failed, but will be retried in the future.
Counter

celery_worker_up
Indicates if a worker has recently sent a heartbeat.
Gauge

celery_worker_tasks_active
The number of tasks the worker is currently processing
Gauge

@RichiH could you have a look at this one as well?


Initial iteration on KeyboardCommander

Nice. Should we call it KeyboardManager just to match the other guys in naming. ;)

PR 666, OMG ^^
On Mon, Jun 13, 2016 at 8:32 PM Michael Aufreiter<EMAIL_ADDRESS>wrote:

Nice. Should we call it KeyboardManager just to match the other guys in
naming. ;)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/substance/substance/pull/666#issuecomment-225652146,
or mute the thread
https://github.com/notifications/unsubscribe/AALG-maXxjp6pXj9v58YXVK_795RlMIoks5qLZQggaJpZM4I0jdV
.

Closing this as the branch is now based on develop


build(dev-deps): replace node-sass by sass

node-sass is deprecated and one of its dependencies has a vulnerability. We can use sass instead as a drop-in replacement.

/deploy-preview to double-check that this doesn't cause a change in the built scripts

Yep, I did, thanks!


Wing Cell lofting error with multiple sections over constant cross-section

Use-Case with 5 cpacs sections and 4 segments and a constant cross-section:
analytical_example_circ_beam_loads_composite_CPACS.zip
Error message:
File "C:\Anaconda3\envs\predocs\lib\site-packages\tigl3\configuration.py", line 19045, in get_loft
return _configuration.CCPACSWingCell_get_loft(self)
RuntimeError: OpenCASCADE Error: BSpline curve: at least 2 poles required

I can confirm this. This is a tolerance problem caused by the positioningOuterBorder of the cell span03_circ01: If you change this value from 0.75 to 0.749999 it works.
The problem is that the outer positioning border coincides with the segment border. Due to floating point errors we have to decide wether we need to actually cut a very very slim slice away from the face when generating the cell geometry or not based on a tolerance. Aparently the tolerance we use in the cell geometry code is incompatible with a tolerance used internally by opencascade.
I will look into it. Until then, you should have a valid workaround.

Hello, in the meanwhile we have several more complex use-cases where we get this problem. Do you know when/if you could fix this bug?

it seems to be not only a tolerance problem, but also a bug in the cell generation. The cells are overlayed although the outer positioning border do not coincide with the segment border. Please find a picture and the use-case below:

IEA-22-280-RWT_DLR_loads_CPACS.zip

Hello @ewerthen, thank you for the insight. We will discuss this and get back to you regarding the bug in the beginning of next week again.

Hello @ewerthen! We made some investigations regarding your issue. Could you please checkout the branch belonging to the PR above (issue_cells_overlap) and test whether it works for you?
In our eyes, the problem is fixed and the cells do not overlap anymore. Nevertheless, we probably want to change the procedure in the future to work differently

Hi, thank you very much! For testing we would need a compiled version for python. Could you provide us a python wheel?

Just replace the tigl3.dll in your conda installation with the one from the CI build: https://github.com/DLR-SC/tigl/actions/runs/11325889409/artifacts/2052673813
You don't need to update the python bindings, since they use dynamic linking.

It doesn't seem to work for us:

Should be fixed with #1026. Note that this issue results from tolerance issues when trying to trim a face very close to one of its surrounding edges. The Fix in #1026 reduces the tolerance that was defined earlier but doesn't solve the issue in principle. This would require a large rework of the cell code (for example "growing" the faces before trimming )


[ITensors] [ENHANCMENT] Rewrite Ops to make it friendlier for automatic differentiation

Description
This is a rewrite of the Ops and LazyApply submodules to make them friendlier for automatic differentiation, in particular to make AD through trotterization work better.
The goal will eventually be to remove the current OpSum type in favor of this new lazy algebra system.
Minimal demonstration of new behavior
julia> using ITensors

julia> using ITensors.Ops

julia> H1 = OpSum() + (1.3, "X", 1, "Y", 2) + (1.2, "Y", 2, "Z", 3)
OpSum:
  1.3 "X"(1,) "Y"(2,)
  1.2 "Y"(2,) "Z"(3,)

julia> H2 = Ops.OpSum() + (1.3, "X", 1, "Y", 2) + (1.2, "Y", 2, "Z", 3)
sum(
  1.3 X(1,) Y(2,)
  1.2 Y(2,) Z(3,)
)

julia> typeof(H1)
OpSum

julia> typeof(H2)
Sum{Scaled{Float64, Prod{Op}}} (alias for Applied{typeof(sum), Tuple{Array{Applied{typeof(*), Tuple{Float64, Applied{typeof(prod), Tuple{Array{Op, 1}}, NamedTuple{(), Tuple{}}}}, NamedTuple{(), Tuple{}}}, 1}}, NamedTuple{(), Tuple{}}})

How Has This Been Tested?
Mostly use tests from the previous versions of Ops and LazyApply.
Checklist:

[ ] My code follows the style guidelines of this project. Please run using JuliaFormatter; format(".") in the base directory of the repository (~/.julia/dev/ITensors) to format your code according to our style guidelines.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have added tests that verify the behavior of the changes I made.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] Any dependent changes have been merged and published in downstream modules.

This PR is pretty uncontroversial since it doesn't replace the default definition of ITensors.OpSum. The new definition is Ops.OpSum, which now has more derivatives working and a simpler code design. So basically the changes are mostly internal.
I will make a future PR where I explore replacing the default ITensors.OpSum with Ops.OpSum and test out more differentiation.

It already works from this PR, by converting Ops.OpSum to ITensors.Opsum (which is straightforward). But ideally we would directly define MPO(::Ops.OpSum, ...) and remove the old version.
I'm working on that now, there are a lot of functions that are defined for the current ITensors.OpSum which aren't defined for Ops.OpSum so it is a bit of work. However I'm hoping it could help clean up the code.


Disappearing scrollbars

Obviously this is intentional. But nonetheless, can I make it always visible?
Also to change its height (older people struggle with very small text and widgets).

To make it always visible
.nano .pane  { visibility: visible; opacity: 1;  }

The css definition above will override the rules defined in nanoscroller.css
To change its height, you need to change the height css property of the main container which is .nano
If your mark-up is like this:

 ...

then your css should be something like this:
.#about.nano  { height: 500px; width: 300px; }

The scrollbars' height is dependent on the height of the .nano div layer.
Hope that helps.

Sorry about that. Yes, nanoScroller only works for vertical scrollbars.


Current State of node property

Hello,
Great project. Thank you very much for all your hard work.
I am trying to retrieve the current state of each node property on-demand but not able to find one.
It's publishing the state of property, when it we set the property but how i can just get the current state of property without setting it?
Regards,
John

There is no on-demand publishing. It has been requested (a few times) and after some discussion the conclusion was to not implement it.
All values are sent with the retained flag set, so as soon as you subscribe to the appropriate topic, your broker will send the last known value.
A possible workaround is to create a settable "worker-node". This node could trigger the device to update properties at the reception of a value.
eg. node "worker" --> app settable property "update" --> send "updatenow!" to device --> device reacts with updating the other properties.

Thanks @bertmelis . Is there any specific reason not to implement it? How mqqt broker will update node property value if node property set before MQQT connected.
I really don't understand the workaround. A brief example will be appreciated.

https://github.com/marvinroger/homie/issues/23
the example below is very incomplete.

unsigned long lastMillis = 0;
bool sendValue = false;

bool sendextra(const HomieRange& range, const String& value) {
  sendValue = true;
}

//...

void loop() {
  if (millis() - lastMillis > 60000) {
    sendValue = true;
    lastMillis = millis();
  }
  if (sendValue) {
    //update your values and publish values with Homie
    sendValue = false;
  }
}

the sendExtra-function has to be assigned a set-handler of your "worker"-node.

@johnmay1 the basic idea behind MQTT (and thus Homie) is that device update their state as soon as it changes or frequently.
If the retained flag is set, the broker stores the value to send it to anyone how starts listening to a matching topic.
To handle the special case that the broker is resetted, you can send all known values when the MQTT connection is reestablished.
Homie does this automatically for its internal data.
Sent from my Sony D6503 using FastHub

Hi @bertmelis . Thannks for code. Yes, we can write such code to report it but i am thinking to achieve it withing Homie internally, so we don't need to write such method for each node property.
@euphi ,  Thanks for explanation. Yes, i want to send node property current state if the MQTT broker re-connected. I can see that homie sending Device Properties, Nodes and Node Property using "advertise" method but i can't see it's sending Node Property current state when it's reconnected to a broker.

Is this something we think is worth needed ? or maybe something you can enable on nodes if needed ?
@marvinroger

Yeah I think it sounds like @johnmay1 is saying he wants to be able to retrieve the property value at some point in the code base.
This is actually exactly what I was trying to figure out how to do, and was surprised there isn't any way to do that as of now (without using settings).  This is huge for me especially when there's a value set on CustomNodeA that CustomNodeB depends on

I think the reason is if you are setting the node value at some point or you make the node setable then you should be able to store it in memory if you like when you set it in code or receive a set value from mqtt /set. Thus not forcing each node to always store the value in memory using precious resources.....

@timpur yeah and completely understandable, in my specific case scenario these values would just have to be stored in config file (as some nodes rely on config from another node, which need to persist even after a reboot).


Bug: Can't test redirect()->route('routename'), while redirect()->to('path') is working with ControllerTester

Describe the bug
For example, I have a controller function Home::index that redirect to route "product-index":
<?php namespace App\Controllers;

class Home extends BaseController
{
	public function index()
	{
		return redirect()->route('product-index');
	}
}

On Test part, I create test with:
<?php namespace AppTest\Controller;

use App\Controllers\Home;
use CodeIgniter\Test\CIDatabaseTestCase;
use CodeIgniter\Test\ControllerTester;

class HomeTest extends CIDatabaseTestCase
{
	use ControllerTester;

	public function testIndexRedirectToProduct()
	{
		$result = $this->controller(Home::class)
					   ->execute('index');

		$this->assertTrue($result->isRedirect());
	}
}

and it got error:
vendor/bin/phpunit tests/Controller/HomeTest.php
PHPUnit 8.5.2 by Sebastian Bergmann and contributors.

E                                                                   1 / 1 (100%)

Time: 284 ms, Memory: 12.00 MB

There was 1 error:

1) AppTest\Controller\HomeTest::testIndexRedirectToProduct
CodeIgniter\HTTP\Exceptions\HTTPException:

/Users/samsonasik/www/ci4/vendor/codeigniter4/framework/system/HTTP/Exceptions/HTTPException.php:168
/Users/samsonasik/www/ci4/vendor/codeigniter4/framework/system/HTTP/Response.php:314
/Users/samsonasik/www/ci4/vendor/codeigniter4/framework/system/Test/ControllerTester.php:191
/Users/samsonasik/www/ci4/tests/Controller/HomeTest.php:14

If I change the code with redirect()->to(base_url('product')).
<?php namespace App\Controllers;

class Home extends BaseController
{
	public function index()
	{
		return redirect()->to(base_url('product'));
	}
}

It working:
vendor/bin/phpunit tests/Controller/HomeTest.php
PHPUnit 8.5.2 by Sebastian Bergmann and contributors.

.                                                                   1 / 1 (100%)

Time: 258 ms, Memory: 12.00 MB

OK (1 test, 1 assertion)

CodeIgniter 4 version
4.0.2
Expected behavior, and steps to reproduce if appropriate
Working with redirect()->route()
Context

OS: OSX
Web server Apache
PHP version 7.4

user route config can't autoload to Tests. function route nead named_route

The "product-index" already in app/Config/Routes.php, why it needs manually redifine it in test?

I created PR #2686 for it.


Cards redesign

Card redesign
I have redesigned the cards under the wallet tab so they look similar to the ones on HCB.
Here is a pic:

Hi! It looks like you may have accidently committed from credentials — they appear to be public credentials so no big deal. However, I have discarded the changes to .env.

Hi! I added those purposefully as those credentials were already found in the codebase so I just added them to the env for easier use.

Merge this pull request instead that me and Gaurav worked on!


Destructors

Currently crashes on exit. If I remove closeWindow(), doesn't crash. Probably because there's a call to unloadTexture after the window was closed and that causes the crash.
$ cd examples/textures/
$ nim r --gc:orc textures_to_image.nim
Hint: used config file '/home/grfork/.choosenim/toolchains/nim-1.6.2/config/nim.cfg' [Conf]
Hint: used config file '/home/grfork/.choosenim/toolchains/nim-1.6.2/config/config.nims' [Conf]
..........................................................................................
/home/grfork/reps/nimraylib_now/src/nimraylib_now/static_build.nim(4, 1) Hint: duplicate import of 'os'; previous import here: /home/grfork/reps/nimraylib_now/src/nimraylib_now/mangled/raylib.nim(6, 6) [DuplicateModuleImport]
.........
CC: stdlib_dollars.nim
CC: ../../src/nimraylib_now/mangled/raylib.nim
Hint:  [Link]
Hint: gc: orc; opt: none (DEBUG BUILD, `-d:release` generates faster code)
53442 lines; 0.713s; 75.309MiB peakmem; proj: /home/grfork/reps/nimraylib_now/examples/textures/textures_to_image.nim; out: /home/grfork/.cache/nim/textures_to_image_d/textures_to_image_5FC9DD2C66B4B8B494B4BD9E4BF3F178F0C7F7DD [SuccessX]
Hint: /home/grfork/.cache/nim/textures_to_image_d/textures_to_image_5FC9DD2C66B4B8B494B4BD9E4BF3F178F0C7F7DD  [Exec]
INFO: Initializing raylib 4.0
INFO: DISPLAY: Device initialized successfully
INFO:     > Display size: 1920 x 1080
INFO:     > Screen size:  800 x 450
INFO:     > Render size:  800 x 450
INFO:     > Viewport offsets: 0, 0
INFO: GLAD: OpenGL extensions loaded successfully
INFO: GL: Supported extensions count: 229
INFO: GL: OpenGL device information:
INFO:     > Vendor:   AMD
INFO:     > Renderer: AMD RENOIR (DRM 3.44.0, 5.16.5-arch1-1, LLVM 13.0.0)
INFO:     > Version:  4.6 (Core Profile) Mesa 21.3.5
INFO:     > GLSL:     4.60
INFO: GL: DXT compressed textures supported
INFO: GL: ETC2/EAC compressed textures supported
INFO: TEXTURE: [ID 1] Texture loaded successfully (1x1 | R8G8B8A8 | 1 mipmaps)
INFO: TEXTURE: [ID 1] Default texture loaded successfully
INFO: SHADER: [ID 1] Vertex shader compiled successfully
INFO: SHADER: [ID 2] Fragment shader compiled successfully
INFO: SHADER: [ID 3] Program shader loaded successfully
INFO: SHADER: [ID 3] Default shader loaded successfully
INFO: RLGL: Render batch vertex buffers loaded successfully in RAM (CPU)
INFO: RLGL: Render batch vertex buffers loaded successfully in VRAM (GPU)
INFO: RLGL: Default OpenGL state initialized successfully
INFO: TEXTURE: [ID 2] Texture loaded successfully (128x128 | GRAY_ALPHA | 1 mipmaps)
INFO: FONT: Default font loaded successfully (224 glyphs)
INFO: FILEIO: [resources/raylib_logo.png] File loaded successfully
INFO: IMAGE: Data loaded successfully (256x256 | R8G8B8 | 1 mipmaps)
INFO: TEXTURE: [ID 3] Texture loaded successfully (256x256 | R8G8B8 | 1 mipmaps)
INFO: TEXTURE: [ID 3] Pixel data retrieved successfully
INFO: TEXTURE: [ID 4] Texture loaded successfully (256x256 | R8G8B8 | 1 mipmaps)
INFO: TEXTURE: [ID 3] Unloaded texture data from VRAM (GPU)
INFO: TEXTURE: [ID 2] Unloaded texture data from VRAM (GPU)
INFO: SHADER: [ID 3] Default shader unloaded successfully
INFO: TEXTURE: [ID 1] Default texture unloaded successfully
INFO: Window closed successfully
Traceback (most recent call last)
/home/grfork/reps/nimraylib_now/src/nimraylib_now/mangled/raylib.nim(3103) textures_to_image
/home/grfork/reps/nimraylib_now/src/nimraylib_now/mangled/raylib.nim(3104) =destroy
SIGSEGV: Illegal storage access. (Attempt to read from nil?)
Error: execution of an external program failed: '/home/grfork/.cache/nim/textures_to_image_d/textures_to_image_5FC9DD2C66B4B8B494B4BD9E4BF3F178F0C7F7DD '

Yes exactly, so either put closeWindow in a try/finally or defer or let the user encapsulate in a destructor backed object.

Yes exactly, so either put closeWindow in a try/finally or defer

On top-level defers are forbidden. It might be an okay idea to wrap every example in main.

or let the user encapsulate in a destructor backed object.

I don't think it is a nice idea to say that to the user. The users of this library might be of beginner level.
Currently another problem is that I'm not sure that we have a complete list of all possible destructors. We can't say to the user "here is a list of types you need to memorize, you don't need to unload them; here is another list which you should unload manually".

unloadVrStereoConfig I removed it, its a noop for now.

That is fine, we can add it later once it has implementation.

unloadWaveSamples just a for loop that calls unloadWaveSample, since we used seq[Wave] it was not need.
unloadImageColors, unloadFontData, unloadImagePalette I think same as above

It's not entirely clear that we want a seq type here.
It's not obvious that Nim would manage the memory that was initialized outside of Nim. We can check it of course but I'm afraid of corner cases.

unloadFileData, unloadFileText it's hard to tell what to do with these, could we instead use std equivalents instead of LoadFile*

It is okay to use the std variant but we probably still want a destructor for it so that --gc:orc is going to manage the memory in this case.

unloadCodepoints haven't decided what to do with codepoints yet.

This can wait for sure.

Currently another problem is that I'm not sure that we have a complete list of all possible destructors.

There is one I left out... ClearDroppedFiles and I don't think anyone has yet.