DefaultHttp2Headers should throw exception of type Http2Exception

Motivation:
The DefaultHttp2Headers code is throwing a IllegalArgumentException if an invalid character is detected. This is being ignored by the HTTP/2 codec instead of generating a GOAWAY.
Modifications:

Throw a Http2Exception of type PROTOCOL_ERROR in accordance with https://tools.ietf.org/html/rfc7540#section-<IP_ADDRESS>
Update examples which were building invalid headers

Result:
More compliant with https://tools.ietf.org/html/rfc7540#section-<IP_ADDRESS>

@normanmaurer @nmittler - FYI

@Scottmitch looks good... @nmittler it's up to you now =P

LGTM

Cherry-picked 4.1 (1d4d5fe) master (07eec67)


Fix android crash issue

Guess it's caused due to upgrade the android project to .net6
Maybe check:
https://github.com/ppy/osu-framework/pull/5181/files

Will be fixed in the #210

Fixed.


Use render function to avoid compiling template.

With these small changes, I could readily use the component as a toy example.
Now I'll move on to the vue-esque version of the d3-based component. Thanks for sharing!
References:

https://vuejs.org/v2/guide/installation.html#Explanation-of-Different-Builds

https://vuejs.org/v2/guide/render-function.html

Thank you @mkcor!


Fix cancel command if no database is connected.

Message mustn't have an empty text, otherwise Telegram API is sad 😢
So just output a simple message instead, since there is nothing to cancel if there is no database connection, as no conversation can be active anyway.

@akalongman @MBoretto @jacklul
You guys ok with me merging this?


[WFLY-17886] IIOP: make sure that configuration of client security ty…

…pe installs requirement on legacy-security capability
https://issues.redhat.com/browse/WFLY-17886
client security configuration relies on legacy-security as well so it should behave the same way as identity security regarding capability registration.

Thanks @tadamski


Readd 'to' relation fields

As discussed, this adds back the removed to fields for relations. With these changes, both the generate-models as well as the generate-relational-schema work without errors.

As discussed, this adds back the removed to fields for relations. With these changes, both the generate-models as well as the generate-relational-schema work without errors.

They work without errors, but both of the results are faulty or/and incomplete. It is just a way we COULD use the programmatic relation handling

They work without errors, but both of the results are faulty or/and incomplete. It is just a way we COULD use the programmatic relation handling

Where are those errors? Regarding the incomplete information, I excluded the new relational attributes because I don't know yet which of these we'll actually need. I plan to implement them as the writer adapter gets updated and it becomes clear what information is required.

We should merge or use this in #17, because the results are not correct.

I think we should rather merge #17. We should use the feature branch, if possible, and merge changes as soon as they are required or usable by another actor. It is okay to merge unfinished or not correctly working code into the feature branch as it is still undergoing heavy development and the current status of the feature branch is far from final anyway.

The resulting models.py will be nearly or perhaps 100% identical to the old one and this is wrong.

Why is this wrong? For now, it suffices. When the writer adapter gets changed, we will need some additional information in the models.py and can then add exactly what we need.

Closing this, because merged the models.yml into #17


Problems With HTML5

Using the FooBar example under the "Component - All Examples" link (where FooBar is passed to the ComponentRouter as a config object) triggers the whole page to reload whereas using it by following the link "Component - FooBar" (where the config prop is the FooBar function) works fine.
EDIT nevermind - I updated component-router and now its working fine  :disappointed: :gun:

Huh? You mean it now all works well? I'll have a look later today

Wow you took a pretty complex example! That is really cool.
I was initially thinking about having just a dead-simple app with 2 pages routed by ReactRouter, one of those would have FooBar routed by ComponentRouter.
In this way it would be much easier for random people to read it.
But I like this complex example as well... Maybe keep this one as advanced and create another super-simple one in addition? What do you reckon?

Yeah that sounds like a good idea. Will make the changes and have 2 different examples.
Yeah its weird - I saw you had made changes with the 2.2.1 version and so I reinstalled from npm and everything began working. It seemed to be something coming from the React event handling code itself and was happening with the same example code from the main component-router (after all the react-router code was stripped out). So I'm not sure what was happening - I'm just glad its over :-)

I don't think anything is fixed now... I am going to look at that tomorrow. For some reason pathname is empty in the Store when click on the link happens. That is strange.

Really? :disappointed: I'll do a fresh install straight from this repo and see what happens.
One other thing I noted was that when it wasnt working for me the React Chrome plugin didn't show any Components loaded at all but now its working as expected.

Was poking around and it seems that the empty pathname comes from the fact that pathname is part of Urls state
  getInitialState() {
    return {
      query: Store.getQuery(),
      pathname: Store.getPathname()
    };
  },

  onChange() {
    this.setState({
      query: Store.getQuery(),
      pathname: Store.getPathname()
    });
  },

but when we dispatch a Navigate Action to the Store we pass the Url's props as the argument:
  onClick(event) {
    event.preventDefault();
    Store.dispatch(ActionCreator.navigateTo(this.props));
  },

while the NavigateTo Action definitely expects both a pathname and a query as arguments (query seems to be in both props and state)? Figure you will probably want to handle this in in-flux/component-router/issues/64 ?

I think it makes sense to remove pathname manipulations. I've already done almost all work there, but merge was delayed by redux refactor. Removing pathname should definitely make things easier to fix.

Oh yeah I definitely agree. Or at least I'm pretty sure that the benefits of dealing purely with state in the key/val/query way outweigh the benefits of having it around. And its definitely in keeping with the philosophy of building something that isnt hierarchical like react-router. In that case using RR & CC together shouldnt involve much configuration/thought as long as people avoid using the query prop in their RR links....I hope :-)

That's what I was thinking about too!
--
Sincerely yours, Nikita Butenko
Google Talk<EMAIL_ADDRESS>Skype: nikita.butenko
Mobile: +61 450 264 801
On 1 September 2015 at 15:06, Hal Henke<EMAIL_ADDRESS>wrote:

Oh yeah I definitely agree. Or at least I'm pretty sure that the benefits
of dealing purely with state in the key/val/query way outweigh the benefits
of having it around. And its definitely in keeping with the philosophy of
building something that isnt hierarchical like react-router. In that case
using RR & CC together shouldnt involve much configuration/thought as long
as people avoid using the query prop in their RR links....I hope :-)
—
Reply to this email directly or view it on GitHub
https://github.com/in-flux/example-with-react-router/pull/1#issuecomment-136587794
.

Great minds... :wink:


Grafana receiver reported frequency  could use a filter

Hi,

Having most RS41's over here in the EU running 4fsk on 2 different frequencies at the same time it would be an improvement if the reported frequencies where each filtered by some "common sense" , like, if distance between reports is larger as xx kHz assume it's a different transmitter frequency ?
Thanks,
Ben

This won't be resolved by filtering, but it might be resolved by using scatter plot instead of a line plot:

I think this is probably the best we can do.

That looks way better ! Thanks for this solution


Font doc screenshots and write macro examples

Closes #172
Closes #173

I've edited your post to reference #172 and #173 instead of #173 and #174 to match the title.

Should we change the organization of the font module documentation?
Currently each font type contains the same examples (except for the used font) which seems a bit redundant. By moving the examples to the font module we could share the examples between all font types and they would be immediately be visible in the module-level documentation, which should also make it clearer that these examples work for all fonts.

Should we change the organization of the font module documentation?

I had this in the front of my head whilst adding those examples. We probably should, yes. The homepage Text with multiple fonts link goes to the module which would immediately show examples to people browsing from the landing page.
The only (tiny) negative I can see is the mild frustration with having to click a "Please see the module docs for examples" link, but it makes maintenance an awful lot easier. I'll dedupe the docs in a new commit to this PR.

The only (tiny) negative I can see is the mild frustration with having to click a "Please see the module docs for examples" link, but it makes maintenance an awful lot easier. I'll dedupe the docs in a new commit to this PR.

I don't think that's a problem, because most users will discover the module-level documentation first and might not even look at the docs for the individual font structs.


Use viewport units for lower resolution navigation

Before

After

Could you show what this does to the account page? (I'd just edit the live CSS to link to your local)?  The intent was for the title to be on the top row, rather than dropped onto the second.  I guess has been broken by notification bell.  I'm ok with dropping it, just would like to see it to make sure account page is fine.


vim gets suspended when there is Gemfile.lock file

I found a very strange symptom that vim gets suspended when there is Gemfile.lock file in the project directory.
[Reproducing steps]
bundle gem myapp
cd myapp
(Edit myapp.gemspec removing "TODO" part.)
bundle
vi lib/myapp.rb
"lib/myapp.rb" 5L, 69C^[[2;2R[1]  + 7132 suspended (tty output)  vi lib/myapp.rb
(When I remove Gemfile.lock file, it doesn't happen.)
[Environment]

Ubuntu 16.04
skwp/dotfiles from master with zsh

Is there anyone who knows this issue or can help to fix it?

yadr doesn't support ubuntu explicitly. This has always been an osx project. Some people tried to make it work on ubuntu but there's no official support..sorry

@dongwon is this still happening? Did you find a solution or was it a one timer thing? Can we close the issue?

I have this problem; and I'm on macosx 10.12.6; i just updated and I also tried re-installing macvim...
When I move the Gemfile.lock... I get the following:
"spec/unit/command/generator_commands/cookbook_spec.rb" 755L, 21413C
Error detected while processing function <SNR>102_buffer_alter_paths[4]..<SNR>102_buffer_project[1]..<SNR>102_project[3]..<SNR>102_throw:
line    2:
E605: Exception not caught: bundler: not a Bundler project: /Users/<___>
Error detected while processing function <SNR>102_buffer_alter_paths[4]..<SNR>102_buffer_project[1]..<SNR>102_project:
line    3:
E171: Missing :endif
Error detected while processing function <SNR>102_buffer_alter_paths:
line    4:
E171: Missing :endif
Error detected while processing function <SNR>102_Setup:
line    2:
E171: Missing :endif

Seems nothing I do is getting me past the following:
"spec/unit/command/generator_commands/cookbook_spec.rb" 755L, 21413C[1]  + 30542 suspended (tty output)  vi spec/unit/command/generator_commands/cookbook_spec.rb
user@inuyasha ~/source/github.com/mengesb/forks/chef/chef-dk (generate_LICENSE●)$ fg
[1]  + 30542 continued  vi spec/unit/command/generator_commands/cookbook_spec.rb
[1]  + 30542 suspended (tty output)  vi spec/unit/command/generator_commands/cookbook_spec.rb


MB-15488 add generic ppm shipment fetcher service object

Jira ticket for this change
Summary
This is related to the work done in #10246 in that the proof of concept PR needed to expand the relationships being loaded when fetching a ppm shipment. Instead of making everything that uses FindPPMShipment now grab the extra data too though, this adds a generic fetcher for ppm shipments so that each caller can define what relationships they want loaded. The jira AC for this ticket are more focused on the code that directly interacts with gotenberg, but this is some base work needed for that gotenberg work, and I broke it out to make it easier and faster to review.

Main Changes

[ ] Add generic ppm shipment fetcher

Base work is done.
Need to rebase this PR on #10298 so that we can include the new relationships. I'll do that tomorrow.
Need to add loading of relationships that can't be eagerly loaded.

Other Changes

[x] feat (testdatagen): add funcs to create PPM shipments w/all doc types

Include helper functions for adding a weight tickets, a pro-gear weight ticket, or a moving expense to an existing ppm shipment.
The two new functions are for before a customer submits their documentation and after.

Setup to Run Your Code

💻
Run server tests
make server_test

Verification Steps for Author
These are to be checked by the author.

[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.
Backend

[ ] Code follows the guidelines for Logging
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Messages

:book:
:link: MB-15488

  Generated by :no_entry_sign: dangerJS against 7dc60a43bf191161e0e6aadcc4c3bc6189a54126


FF Platform Overview Download

Description
Here's the content for the FF Platform Overview  downloadable PDF for design and layout. This will be placed as the CTA in the Features Page behind a form.
@joepavitt please review features and add any other key aspect that's missing.
Epic/Story
No response
Have you provided an initial effort estimate for this issue?
I have provided an initial effort estimate

Hi @Hasmin-AC here's the styled google doc. I didn't include the last part, Why Enterprises Choose FlowFuse, as it didn't seem to be ready, and you mentioned it could be added later

Thanks @Yndira-E Here's the form ID to download - "93ddc751-741d-4997-a22a-c05548a0a698"
Right now it takes you to a thank you message but I did create a thank you page for your review https://github.com/FlowFuse/website/pull/2595. Will update form when page is published.
Looks like the pop-up form option is not available on HS any more so we'll have to code it or place it as an expansion on the button click.


Panels not dragging in 3.0.0 dev

When working in Spyder 3.0.0 dev, I when I drag the panels from either the top bar or the bottom tab nothing happens.  To move them I have to undock them with the resize (double-box) button and then I can move them.  There is no visual feedback when the panel would snap into the proper location.  Basically, there are work-arounds, but it is pretty unintuitive.
System:
-Windows 7
-WinPython-64bit-<IP_ADDRESS>Qt5.exe with Sypder dev 3.0.0

You can move panes that are tabbed next to each other by dragging and dropping their tabs to the left or to the right. Unfortunately, this doesn't work for panes placed in different tabs.
@goanpeca, do you think there's something we can do to improve the situation? Like grabbing from a pane tittle to move to another position?

This should be working, but I guess the user did not realized that panes are locked by default?

Oh yeah! I forgot that! ;-)
@johnml1135, you just need to go to
View > Lock panes

to unlock them, and then reorganize them as you want.
We decided to lock panes by default to avoid accidental mouse dragging's, which was quite frequent and annoying.

Thanks for the explanation.  It makes sense now.

And we need to put this clear in UPPERCASE somewhere in the docs ;-) ! cause it might come and bite us again in the future


Variable Definition in Template

RFC: https://github.com/vuejs/rfcs/issues/73
Relate PR: https://github.com/vuejs/core/pull/7218#issuecomment-1328069680
feature name: vScope

I'm not sure. It's a bit complex feature.

I readed named-template implementation code,and had an idea. I can partially rewrite the compiled code to achieve it. Because I've been busy and sick lately, it will take some time, but I'm already working on it


Mermaid in tabs. The arrows are not displayed in the second tab

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Prerequisites

[X] I'm using the latest version of Docusaurus.
[X] I have tried the npm run clear or yarn clear command.
[ ] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
[ ] I have tried creating a repro with https://new.docusaurus.io.
[ ] I have read the console error message carefully (if applicable).

Description
Discussion from https://stackoverflow.com/questions/74474982/mermaid-in-tabs
The arrows are not displayed in the second tab
It works here https://docusaurus.io/tests/pages/diagrams#mermaid-in-tabs
I have:
a) In "tab-a", the arrows are displayed:

b) But in "tab-b", the arrows are not displayed:

Version of docusaurus: 2.2.0
Type files: .md or .mdx
import Tabs from '@theme/Tabs';
import TabItem from '@theme/TabItem';

<Tabs>
<TabItem value="tab-a">

The following mermaid diagram is shown:

```mermaid
graph LR
  a ---> c(10)
  b ---> c(10)
```

</TabItem>

<TabItem value="tab-b">

This mermaid diagram is not displayed:

```mermaid
graph LR
  d ---> z(42)
  e ---> z(42)
```

</TabItem>
</Tabs>

Reproducible demo
No response
Steps to reproduce

Create new file .md
Add mermaid diagram graph LR in two tab

Expected behavior
Arrows are displayed in all tabs
Actual behavior
The arrows are not displayed in the second tab
Your environment

Docusaurus version used: 2.2.0

Self-service

[ ] I'd be willing to fix this bug myself.

Can reproduce, not sure why it happens.
A good-enough temporary workaround is <Tabs lazy>, which will only render one tab at a time

Hello everyone!
I did a little survey about this issue.
<path marker-end="url(#flowchart-pointEnd)" style="fill:none;" ...></path>

The above element is a  child of g element, that has an edgePath class.
And I noticed that url(#flowchart-pointEnd) 's result may refer to a different component
(particularly,it may refer to the different tab's flowchart-pointEnd)

If I changed the second tab's url function to url(#flowchart-pointEnd2) and modify the element's id, all of elements are correctly rendered.

On top of that, if I delete the second tab's flow-chart-pointEnd  element, it brings no change and it may reinforce the hypothesis that  the url function directs to a different element.
But, I'm still not sure why inserting another element that has flowchart-pointEnd element into the outside of the tab works as a workaround....
This gif may also indicate that the url function interfere with each other....

import Tabs from '@theme/Tabs';
import TabItem from '@theme/TabItem';

# Mermaid in tabs

<Tabs>
<TabItem value="tab-a">

```mermaid
graph LR
  a ---> c(10)
  b ---> c(10)
```

</TabItem>

<TabItem value="tab-b">

```mermaid
graph LR
  d ---> z(42)
  e ---> z(42)
```

</TabItem>
</Tabs>

<Tabs>
<TabItem value="tab-c">

```mermaid
graph LR
  a ---> c(10)
  b ---> c(10)
```

</TabItem>

<TabItem value="tab-d">
```mermaid
graph LR
  d ---> z(42)
  e ---> z(42)
```

</TabItem>
</Tabs>

I have a similar issue, but with a different component in a second tab. I'm using the kotlin-playground component, which is based on Code Mirror. My code item does not render properly in the second tab (it is partially initialized). But it works fine if I use lazy tabs. One thing to note is that resizing the browser window causes the component to update like it does when first clicked, but it is still not properly displayed after this. Using a lazy tab completely eliminates this issue. But it is not a good option for my use case, since that means tabs are created every time they are selected (not just the first time, as you'd imagine).
https://user-images.githubusercontent.com/9815928/228273231-c5352f3d-a1e9-4a8c-99cb-4541df91c10a.mov

While investigating https://github.com/facebook/docusaurus/issues/9032, found out that Mermaid is not great at rendering diagrams concurrently, and we should ensure to render them sequentially one after the other.
See https://github.com/mermaid-js/mermaid/issues/3577
I suspect we'll have to build fancy things like a rendering queue so that different components (in this case tabs) do not attempt to render diagrams concurrently.


Fix/macos

Pull request for macOS support:

Fix OpenGL context creation on macOS
Add support for retina/UHD displays, in particular for moving the window between displays

For details, see commit messages.

You will still experience trouble on Windows when moving the windows from display to display when setting "Change the size of text, apps and other items" under "Scale and layout" to anything other than 100%.
I think this may require glfw3.3's glfwGetWindowContentScale to resolve.

You may experience trouble on Windows when moving the window from display to display when setting "Change the size of text, apps and other items" under "Scale and layout" to anything other than 100%.
I think this may require glfw3.3's glfwGetWindowContentScale to resolve.

Nevermind, the problem under Windows is solved by updating GLFW to 3.3.2.

@maltekliemann, thanks for your contribution!


make components/bdso-base-ext.owl not recognising change

Tried to run a release with the new BDS build, however it doesn't seem to be updating it.
Tried to make the components/bdso-base-ext.owl file, but make seems to think it is up to date even though it isn't (checked the date) - this might be due to the use of branch to grab the file rather than an actual release/master branch.
I can pull it over manually for now, but that is not ideal. Need to figure how how make checks what is up to date and deal with it from there.

use -B


not executable?

Hello - perhaps i missed something, but i can´t find a hello_tls.py file in your repo? Was not able to execute with the documented steps in readme.md:
git clone https://github.com/boppreh/hello_tls.git
cd hello_tls
python hello_tls.py boppreh.com

If you're just trying to execute it, I suggest installing via pip:
pip install hello_tls

If you want to run the cloned repo, try
git clone https://github.com/boppreh/hello_tls.git
cd hello_tls/src
python -m hello_tls boppreh.com --no-certs

The  --no-certs  option is required if you don't have PyOpenssl installed.
Note that there is no  hello_tls.py file, but that's just one way of executing Python. Another way, used in this project, is to have a directory with __init__.py and __main__.py files.

thanks - worked :) - perhaps it should be changed in the readme?

Oh, I missed it that your code came from the README. Yes, definitely my fault, I've updated the README. Thanks for the tip.


Update Wiki pages

Tasks

Continuously improve Wiki pages to reflect project progress
Finalize pages for the project delivery

Thank you all for great contributions.
@nikalc
@OneMoreOreo
@ramadi-a
@kam56
Closing the issue upon submission. Great work.


Logs?

Hi.
I am testing your module. It seems to work but I do not see any logs in the caddy logs. Is it normal? Is it a way to see the actions actually performed by the module?
Thank you.
Laurent

I'm not sure what kinds of logs you're expecting to see.
What's your config? What do you see in your logs?

My realip config is
realip {
header "X-Forwarded-For"
from cloudflare
from <IP_ADDRESS>/8
maxhops 5
strict true
}
I've modified it for testing with:
realip {
header "X-Forwarded-For"
#from cloudflare
from <IP_ADDRESS>/8
maxhops 5
strict true
}
and I cannot reach my webservice from Cloudflare but from my local network which is fine.
When I look at my caddy logs I have no trace a connection have been rejected. It would be interesting to check there's no attack attempts.
Here are my logs:
{"level":"info","ts":1651171517.293661,"logger":"http","msg":"enabling automatic TLS certificate management","domains":["myserver.fr","acme.roadrunner"]}
{"level":"info","ts":1651171517.3564906,"logger":"tls","msg":"cleaning storage unit","description":"FileStorage:/data/caddy"}
{"level":"warn","ts":1651171517.6778858,"logger":"tls","msg":"stapling OCSP","error":"no OCSP stapling for [acme.roadrunner]: no OCSP server specified in certificate","identifiers":["acme.roadrunner"]}
{"level":"info","ts":1651171517.7051857,"msg":"autosaved config (load with --resume flag)","file":"/config/caddy/autosave.json"}
{"level":"info","ts":1651171517.7059333,"msg":"serving initial configuration"}
{"level":"info","ts":1651171517.7805393,"logger":"tls","msg":"finished cleaning storage units"}
{"level":"warn","ts":1651171521.458605,"logger":"dynamic_dns.ip_sources.simple_http","msg":"IPv6 lookup failed","endpoint":"https://api64.ipify.org","error":"Get "https://api64.ipify.org": dial tcp6: lookup api64.ipify.org on <IP_ADDRESS>:53: no such host"}

Is that your entire config?
I don't think you've actually enabled access logging.
You need to use https://caddyserver.com/docs/caddyfile/directives/log

Alright I see them with debug.
It seems to me it should be more than debug logs since there could be real attacks though.
May I suggest considering an option to log in regular logs ?

What logs? I'm not clear on what you're talking about. Please be specific.

Sorry. I would like to get a record of the access attempts refused by the realip module with "strict" (IP not matching the conditions).

Ah okay. Yeah, right now it just triggers a 403 error (which you can handle with handle_errors if you want).
https://github.com/kirsch33/realip/blob/3eaa4a63330b8d23d153e555da8797865ae1b22e/module.go#L227

Ok thanks for your guidance. So log ERROR should do the trick.
Thanks.


Add example recipe that computes correlation with reference

Yet another example recipe.
@nielsdrost this is the example we discussed this morning.

this is cool, I like to see more stats in, @bouweandela -- two questions: why are you plotting the PearsonR? Isn't that just a number between -1, 1 for two datasets? and the second question, correlation between two models is a bit weird to computed, I's think a more useful stat would be a Kolmogrov-Smirnoff since these are multi-parametric and even a KS stat would be a stretch. But I may be misunderstanding the case at hand

Hi V.,
No good reason for Pearson's r other than that it was directly available in iris. If you know a correlation function that makes more sense (in that it better describes the chance that the two models are sampled from the same distribution, I guess?) can you please add it to the PR? It would be nice if this could result in something that is actually scientifically useful.
Here's some examples of the output to give you some more idea of what the diagnostic does:

Correlation vs pressure level

Correlation vs latitude,longitude
Another nice feature would be if we could also plot correlation vs time, to see if a model is performing better or worse as a function of time.

hey @bouweandela this looks cool, man, the PearsonR(air_pressure) looks nice at all levels bar that dip but I am not sure I understand the heatmap plot - what you want to get is PearsonR = f(var_model1, var_model2) where var_model1 and var_model2 are your model variables but you should not use the variables' values at each individual lat-lon point along the plev-axis because the models behave differently at different regions in the lat-lon plane (sure, if you assume the models are ideal ie estimate the variable identically across the lat-lon plane then it should be fine; more reliable would be averages over regions like equatorial, tropical etc). In any case the PearsonR is rather limited in the amount of information it conveys - it just tells us that there is a linear relation between var1 and var2 or that the models are correlated or not - by how much, that is the question? Eg how low or high an R=0.8 really is? Also, PearsonR is pretty robust to linear translations but can be seriously affected by nonlinearities in the data or by all means, would not be able to detect them at all if they happen in opposite directions. That's why I am thinking a Kolmogorov Smirnoff test would be more robust (look it up, it's quite a well used one) - the KS statistic tells you if the two samples you are comparing are drawn from the sme distribution (the two sided one should be used). The KS stat is also limited (it works only for non-derived variables ie smth like temperature or pressure). I am actually really keen to start testing statistics (I'd go the Bayesian way tbh) in ESMValTool, so maybe we can work together on this?

Maybe we could use this function instead then?
scipy.stats.mstats.ks_twosamp
scipy.stats.ks_2samp
or this one?
scipy.stats.anderson_ksamp
as some people seem a bit critical about the KS test.

Can this PR be merged?

@mattiarighi absolutely from my side - I will start working on developing a robust statistical framework soon(ish) and I will actually start from this one!

Fine from my side too, I do not expect to have time to switch this diagnostic to a more meaningful statistic anytime soon: I think other issues are more important.


Improve testing

The current test focuses purely on API and is certainly not enough. This library is essentially about UI interaction and heavily relies on DOM events, but I find it hard to actually test out the interaction like a real user would do. I'm pretty new to this kind of testing, any idea/suggestion on the testing strategy is appreciated.

Should probably integrate Sinon.


How to define omega in range-separated functionals?

`from pyscf import gto, dft, scf, tools
mol = gto.Mole()
mol.atom = '''H 0 0 0; F 0 0 1.1'''
mol.basis = '6-31g**'
mol.charge = 0
mol.spin = 0
mol.output = 'neutral.log'
mol.verbose = 4
mol.build()
mf = dft.RKS(mol)
mf.xc = 'wb97x'
mf.run()`
Is 'mf.omega = 0.25' right?

In pyscf-1.6, setting mf.omega = 0.25 can change the range-separation parameter in Coulomb and exchange integrals only. The parameter in GGA functional is not updated accordingly. This problem is fixed in commit 6740f11 of dev branch, which will be available in 1.7 release.

Thank you for your reply. Looking forward to the new release.

Here are the examples
https://github.com/pyscf/pyscf/blob/dev/examples/dft/13-rsh_dft.py


Hidden folders are still counted

Prerequisites

[x] Are you running the latest version of Bootstrap Listr?
[x] Did you check your browser's console for errors? See how in Chrome, Firefox, Edge) -- no, not relevant
[x] Did you build a distribution? Use npm run build
[x] Are you running the Node v6 (or higher)?
[x] Did you check the FAQ?
[x] Did you perform a cursory search to see if your issue has already been reported?

Description
My directory has two folders. One is hidden in my hidden_files. It is hidden in the index, but the count still says "2 folders" (see https://files.camilstaps.nl/).
Steps to reproduce

A directory with two folders
Hide one of them with hidden_files
Check the count

Expected behavior:
"1 folder"
Actual behavior:
"2 folders"
Versions

Bootstrap Listr https://github.com/idleberg/Bootstrap-Listr/commit/853e7c356451ed9dbb152da56f787cb78d65bde9
PHP 7.0.22
Node 9.4.0
npm 5.6.0

I should have used the ignored_files array instead of the hidden_files one.


'Invalid Format' error when trying to convert one date format to another

I want to take a data format and convert it to another format...
I heard 'new Date' syntax will be depreciated at some point so can't use this at some point (I see that in the logs as well) so cant do this at some point:
moment(new Date("Wednesday, June 3, 2015 17:25:34")).format('YYYY-MM-DD')

I see a warning in the browser when using the implicit syntax below which im guessing calls the same 'new Date' as above:
moment("Wednesday, June 3, 2015 17:25:34").format('YYYY-MM-DD')

Im trying to supply the format so I can get passed the depreciated 'new Date' code by doing something like this:
moment('Wednesday, June 3, 2015 17:25:34', 'dddd, MMMM D, YYYY HH:mm:ss').format('YYYY-MM-DD') //should output 2015-06-03

but Im getting 'Invalid Format' but the initial format I set looks fine to me.
Can anyone tell me why?
Thanks,
Ari

actually the above code is working fine for me.
you might use the latest momentjs version.
here is what I get:
moment('Wednesday, June 3, 2015 17:25:34', 'dddd, MMMM D, YYYY HH:mm:ss').format('YYYY-MM-DD')
"2015-06-03"

I just used the latest momentjs and the doesn't work:
Here is an example of the implicit format working (first alert) and explicit format not working (2nd alert):
http://jsfiddle.net/4mgp3c6s/
Am I doing something wrong in that jsfiddle's explicit example?

Interesting, when I use the non-locacle version of Moment.js it works fine:
Locale (broken): http://jsfiddle.net/5zn0L60d/
Non-locale (works): http://jsfiddle.net/kagdvm37/

Hmmm, if i explicitly set a locale before the format then it works.
Not sure if thats a bug or not that a locale has to be set.
I'd just assume there would be a default locale like 'en' but adding moment.locale('en'); works:
http://jsfiddle.net/4mgp3c6s/1/

something wrong with moment-with-locales.js
when I changed it to moment.js, it will work.

#2367 explains it.  Closing as duplicate. Though it presents differently, it's the same issue.


Flickering/stuttering

Hello,
and Thanks for the grate effects,
Problem :
All your samples are flickering / stuttering sometimes ,
Please tell me how to loop the effects forever without any flicker?

Hi Mitra!
I'm sorry to say that I have not worked on this project since I uploaded it. I also haven't worked with WPF in a long time so I have no guess what the issue could be.
All I can say is that I don't remember there being any flicker or stuttering issues when uploading this. Sorry for not answering quicker, and I hope you find a solution.
// Anders

no problem ,I understand you.
Thanks.


Multiple platforms - build configuration question

Hi, Could you explain how build tools 'knows' which files to import?
For example when you use import Render from './KeyRender'; how it knows if choose KeyRender.js, KeyRender.android.js or KeyRender.ios.js?
I can't find place where it's configured. For example when I want to change suffixes from .android.js to .myandroid.js which config should I edit?
EDIT:
Ok, I think I found it: https://facebook.github.io/react-native/docs/platform-specific-code.html#platform-specific-extensions
So react-native uses .android.js or .ios.js files (if exists - if not rn uses .js files)
Webpack (used for desktop and web) uses .js files

+1

https://facebook.github.io/react-native/docs/platform-specific-code.html#platform-specific-extensions


Problem with scrollToIndex

I have a problem with scrollToIndex for AutoSizer/List. When you have a very long list, say 100 items, and your screen only shows about 30 of them. You set your scrollToIndex to 50. It seems like the DOM doesn't show the first 50 items. Upon inspecting the Elements page in debugger, the very first item happens to be the 50-th item with position top set to the exact offset. I'm guessing the scroll is not working somehow. And when you scroll the list, it will start from the top. Any idea how to fix it?

Hi @ethankong113,
Can you share a Plnkr that reproduces the unexpected behavior you're seeing?

Do you have a boilerplate with it setup? I'm trying to look for one but they are all with dated versions.

This problem occurs if you give scrollToIndex to the list before the whole list is rendered. I tried to use setTimeout to delay the scroll and it worked, but this is a hack though.

Do you have a boilerplate with it setup? I'm trying to look for one but they are all with dated versions

There's a link to a Plnkr templates in the new issue box. You had to erase it when you filed this issue.

Taken from the contents of a new issue being filed:

Are you reporting a bug or runtime error?
Please include either a failing unit test or a Plnkr demonstrating the bug you are reporting. You can start by forking this Plnk! https://plnkr.co/edit/6syKo8cx3RfoO96hXFT1
You may also find the online Babel tool (https://babeljs.io/repl/) quite helpful if you wish to use ES6/ES7 syntax not yet supported by the browser you are using.

When you have a very long list, say 100 items, and your screen only shows about 30 of them. You set your scrollToIndex to 50.

The RV demo page for List shows a list with 1,000 items and scroll-to-index works fine.

It seems like the DOM doesn't show the first 50 items. Upon inspecting the Elements page in debugger, the very first item happens to be the 50-th item with position top set to the exact offset.

Maybe I'm misunderstanding what you're saying? This sounds like the primary purpose of a lib like RV- only render the DOM elements a user can see at any given point in time. If you've scrolled to item 50, then RV only shows items 50 through whatever fills the list. (Check out this slide for a visual demo of how this works.)

I'm guessing the scroll is not working somehow. And when you scroll the list, it will start from the top. Any idea how to fix it?

I don't understand what you're saying. Again though, the demo page for List works fine for me.

This problem occurs if you give scrollToIndex to the list before the whole list is rendered in the DOM. I tried to use setTimeout to delay the scroll and it worked, but this is a hack though.

I don't know what you mean by "before the whole list is rendered in the DOM" but RV should never render the whole list, only a part of it.
I'm going to closet his issue for now as it isn't very actionable. If after reading the above- there's an actual issue and not a misunderstanding, please clone the Plnkr template I linked to with a repro case. 😄

I'm experience a similar issue - if I pass a scrollToIndex to a List containing dynamic height rows with images loading things get a lil screwy trying to scroll up.  I think this might be what @ethankong113 might be referring to - passing scrollToIndex before the images have loaded for example.

@babsonmatt I'm sure you have a solution by now, but my own solution is to simply pass a function which calls scrollToRow to my images' onLoad props, as well as ensuring images have set height and widths wherever possible.


Constant time equality for undersized Buffers

The optional minComp parameter allows real constant run-time (iff minComp >= Math.max(buf.length, otherBuf.length)) and would justify the project naming.

Couldn't you just specify minComp as a.length?

In that case, the run-time of buffer-equals-constant depends only on the length of a, which allows conclusions about a, namely its length. Clearly if the length of a and b is always the same, this is irrelevant.
An oversimplified example would be:
var passwordStored = getPassword(username);
… bufferEqualsConstant(passwordStored, passwordSent) …

So if I am interested in the shortest passwordStored, I only have to vary the username and measure the time.

Ha,  true.
I like it.
:+1:  LGTM

:+1:

+1

As @dcousens guessed, the run time of buff[i] differs according to whether or not i<buff.length holds (see buffer-access-benchmark.js).
Hence, run-time of bufferEqualsConstant(Buffer(3), Buffer(1024), 1024) differs extremely from bufferEqualsConstant(Buffer(1024), Buffer(3), 1024) and does not deserve to be called constant.
Therefore  we can not prevent that a possible attacker may derive information about the lengths of the buffers used.
Maybe there are other ways we can force (fairly) constant run-time for buffers of different lengths, but in the meantime I believe we should throw an error if a.length != b.length, because of the security risk.
@sindresorhus what do you think?

Maybe there are other ways we can force (fairly) constant run-time for buffers of different lengths, but in the meantime I believe we should throw an error if a.length != b.length, because of the security risk.

Agreed.

Why did you close this?

Probably bad idea, but throwing it out there. Would it help to introduce a loop with fake nth fake mutation, where nth is a number from crypto.randomBytes?

Why did you close this?

Because the current approach won't make it, and it is always possible to reopen it, if needed.

nth fake mutation

I think in rare cases run-time of writing to a buffer and reading from it may differ (caching etc) - not sure about this.
Despite of this, crypto.randomBytes would cost run-time. But we may write an arbitrary number!?

…and it is always possible to reopen it…

Unfortunately this is not entirely true - I messed the history of this PR, and had to create a new one: #4  :-(

@schnittstabil you can always force push over it.

@dcousens You are right, I should have used my reflog, but I missed that possibility. :-( Actually I can't reopen this PR, because:

There is already an open pull request from schnittstabil:master to sindresorhus:master.

You should never do PRs from master ;)


The code editor is very slowly responsive

What steps will reproduce the problem?

Open the spyder editor window;
Type code.

The editor window updates very slowly.

Hello @rgcucu can you provide information about your OS and the version of Spyder you are using? Please fill the template we provide for our issues so that we can help you.

This is a duplicate of issue #15631. Please read it for the different things you can do to improve performance for now.


tests: net: socket: tcp: Add test to validate connect timeout

When there is no response from the server, a client side connect
should return a ETIMEOUT. This tests breaks the connection and validates
this behavior.
This tests validates an element that is already correctly implemented.

Pushed on top of an older commit, since there is a problem in the current main with a conflicting definition of can_set_bitrate

@rlubos It took a few iterations to fix seemingly unrelated bugs in the test suite. Could you have a look at the current state?

@jukkar Could you have a look at this PR?


Delay OverTime Calculation for Penalty and Reward

[ ]  Create Employee Checkin Doctype

[ ]  Attendance doctype field additions

[ ] Company > Payroll Settings

[ ] Company > Payroll Settings > Delay and OverTime Calculation Settings

[ ] Delay OverTime Entry (like Payroll Entry)

[ ] Additional Salary Record Creation based on Delay OverTime Entry

Employee Checkin DocType Fields

Field
Type
Remarks

EMPID
Link
Employee

RFID
Data
Linked with employee.rfid

InTime
DateTime

OutTime
DateTime

Duration
Time HH:MM:SS
Readonly , auto calculated based on in-out info

Device Tag
Select  Options  CheckIn, CheckOut,BreakIn,BreakOut,OTIn,OTOut
Could be used to store few more information for the record from the device. E.g. Few device support explicit checkin, out parameter from the employee

Attendance Doctype

Field
Type
Remarks

Employee ID
Link
ERPNext Employeee ID

Attendance Date
Date
employee.deviceemployeeid

Status
Select

Leave Type
Link

CheckIn CheckOut
Section

Checkin Time
DateTime
It will have the final check-in info for the day for the employee

Checkout Time
DateTime
It will have the final checkout info for the day for the employee

Duration
Readonly (HH:MM:SS)
Difference between checkout and checkin

Delay OverTime Info
Section

Shift
Link
Shift assigned for the attendance date from shift assignment doctype

Shift In Time
ReadOnly
Fetch From Shift, , Keeping it here to maintain information for that day

Shift Out Time
ReadOnly
Fetch From Shift , Keeping it here to maintain information for that day

Delay (in Mins)
Int
Total Delay for the day

OverTIme (in Mins)
Int
Total Overtime for the day

Shift Doctype

Shift
In Time
Out Time
Ignore Delay (in Mins)
Ignore Ealry Out (in Mins)
Min Overtime (in Mins)
Max Overtime Allowed
Delay Penalty Based on
Early Checkout Penalty Based on

Morning
8:00
17:00
15
15
60
120
Actual Minutes/ Delay Rules Table
Actual Minutes

Delay Penalty Doctype

Shift
From Time
To Time
Penalty (in Mins)

Morning
8:16
9:00
60

Morning
9:01
10:00
120

Morning
10:01
11:00
180

Morning
11:01
12:00
240

Morning
12:01
17:00
300

Delay OverTime Entry (like Payroll Entry)

Field
Type
Remark

Series
Data
DOE-.YY.MM.-####

Employee
Link

Shift
Link

Date
Date

CheckIn
Time
Final CheckIn

CheckOut
Time
Final Checkout

Duration
Time
HH:MM:SS

Delay (in min)
Int

Overtime (in min)
Int

Company > Payroll Settings (Section) > Delay and OverTime Calculation Settings (sub- section)
Delay and OverTime Settings

Calculate Per min Salary Based on
Select Options
          1. Working Days
          2. Fixed Days

if Fixed Days , Please Mention No. Of Fixed Days = 30 (Default Value)

What IF
Rules

If No Checkout Record found
Options :   1. Automatically update shift checkout time

--
2. Manually  correct attendance records. ( default value)

[ ]  Consider Hours on Holiday as Overtime
checkbox , default = false

system will ignore the checkin, checkouts on non-working days /  holiday.

OverTime Multiplication Factor (Int)
default value = 1

*OverTime Multiplication Factor set at department wise will have higher priority.

Future Priority  could be in the below order ( from highest to lowest),

Level
Priority

Employee
1

Designation
2

Department
3

Company
4

[ ]  Ignore Delay and OverTime Calculation for Additional Salary
in below order ( Highest to Lowest)

Level
Priority

Employee
1

Company
2

BioMetric Attendance Device Design

Daily Night Script  , maintain Log for the same
will run at 11 pm daily.

Field
Type
Remark

Processing Date
Date

Status
Select
Error , Success

Employees Processed
int
count of the employees processed

Error Log
Code
Detailed Error Log

Employee Attendance Script
Logic

Check if it is holiday for today, mark all active employees as present.

if it is working day (non-holiday) , check if already attendance record exist for employee, then mark that employee for Review Flag

If it is working day , check if multiple records exist for an employee, fetch minimum - checkin and maximum checkout , and difference as duration.

if the min checkin is less than the shift in time, calculate delay through function
( * can define a function which takes arguments shift , checkin-time and returns delay based on the rules applicable for that shift )

if max checkout time is greater than the shift out time, calculate overtime through function
( * can define a function which takes arguments shift , checkout-time and returns overtime based on the rules applicable for that shift )

At the End, Send Script Run Report .

Precondition
required if delay and overtime calculation need

Holiday List should be present and assigned to each company
Employee needs to have salary structure.

Standards Data
Salary Components
1. Delay
2. OverTime

Employee Checkin DocType Fields
Field	Type	Remarks
EMPID	Link	Employee
RFID	Data	Linked with employee.rfid
InTime	DateTime
OutTime	DateTime
Duration	Time HH:MM:SS	Readonly , auto calculated based on in-out info
Device Tag	Select
Options
CheckIn, CheckOut,BreakIn,BreakOut,OTIn,OTOut	Could be used to store few more information for the record from the device. E.g. Few device support explicit checkin, out parameter from the employee

Do we require company field here?

Attendance Doctype
Field	Type	Remarks
Employee ID	Link	ERPNext Employeee ID
Attendance Date	Date	employee.deviceemployeeid
Status	Select
Leave Type	Link
CheckIn CheckOut	Section
Checkin Time	DateTime	It will have the final check-in info for the day for the employee
Checkout Time	DateTime	It will have the final checkout info for the day for the employee
Duration	Readonly (HH:MM:SS)	Difference between checkout and checkin
Delay OverTime Info	Section
Shift	Link	Shift assigned for the attendance date from shift assignment doctype
Shift In Time	ReadOnly	Fetch From Shift, , Keeping it here to maintain information for that day
Shift Out Time	ReadOnly	Fetch From Shift , Keeping it here to maintain information for that day
Shift Duration	ReadOnly	Fetch From Shift , Keeping it for info and for delay and overtime calculation
Delay (in Mins)	Int	Total Delay for the day
OverTIme (in Mins)	Int	Total Overtime for the day

Indicate which are new fields?

Delay Penalty Rules DocType
Shift	From Time	To Time	Penalty (in Mins)
Morning	8:16	9:00	60
Morning	9:01	10:00	120
Morning	10:01	11:00	180
Morning	11:01	12:00	240
Morning	12:01	17:00	300

If delay is more than say 3 hours (in 8 hour shift) do you want to call it half-day?

Do we require company field here?
No. Since in Employee Doctype company field is already there.

ESSO had company field not sure why? https://raw.githubusercontent.com/creamdory/erpnext/c1971a3ffa5aa9c816c6e50ffbf56dd95c032fa9/erpnext/hr/doctype/employee_checkin/employee_checkin.json


DLCs

Opening for now so I can better document changes I need to make
Currently can open and close DLCs with my dummy function test_send_dlc_offer.
Has some current problems

[x] Privacy leak same keys used across all DLCs (need changes to rust_dlc)
[x] ~Same nostr key for DLCs~ Cannot statically receive bets without this
[x] Need to do proper coin selection, not just use them all
[ ] Currently using damus relay with random kind, need to do this properly
[x] Encrypt raw bytes of DLC messages instead of base64 encodings (needs rust-nostr v26)
[x] Respond with errors
[x] Docs
[ ] Tests

Some other todos for usability

[x] Make functions for decoding oracle announcements and attestations
[ ] Better wasm model

Longer term todos

[ ] nostr market place
[ ] local social tagging
[ ] dlc "zaps"

Code looks pretty clean and self contained, nice job so far. What's the status on it?

needs rebase


Add Isle Of Man 1970 test

Proposed change

Add a test for 100% coverage.
Type of change

[ ] New country/market holidays support (thank you!)
[ ] Supported country/market holidays update (calendar discrepancy fix, localization)
[x] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency upgrade (version update)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] This PR is filed against beta branch of the repository
[x] This PR doesn't contain any merge conflicts and has clean commit history
[x] The code style looks good: make pre-commit
[x] All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
[x] The related documentation has been added/updated (check off the box for free if no updates is required)

coverage: 100.0% (+0.009%) from 99.991% when pulling d2e9b78e06c8fda2055dd49f9319d6f5605cca5d on arkid15r:update-test-coverage into 522a9951f4457c68977016ecc8d8d9e08011f8d2 on dr-prodigy:beta.

That's great! But why it's 1970? 😮

Turns out it was missing a test for "Late Summer Bank Holiday" which starts in 1971 of all things.

Turns out it was missing a test for "Late Summer Bank Holiday" which starts in 1971 of all things.

Yeah, that's the branch that wasn't covered by our tests https://github.com/dr-prodigy/python-holidays/blob/522a9951f4457c68977016ecc8d8d9e08011f8d2/holidays/countries/isle_of_man.py#L38


Autocomplete doesn't complete the last character

Hello guys,
I was searching for issues related to my problem and I thought this one could be duplicate:
https://github.com/Dogfalo/materialize/issues/4230
It was said that the related autocomplete problem was solved. I've downloaded the last materialize-sass gem version but it seems it wasn't fixed.
The problem I'm facing with is: I have the tag "notebook". the autocomplete works until "noteboo", when I enter the "k", the tag simply doesn't appear.
That's how I'm declaring my autocomplete component:
$('.chips-autocomplete').material_chip({
            autocompleteOptions: {
                data: tagoptions.autoCompleteData,
                limit: Infinity,
                minLength: 1
            },
            secondaryPlaceholder: 'Adicione a tag',
            placeholder: '+Tag',
            data: tagoptions.data
        });

The tagoptions.autoCompleteData object is defined as:
{
  eraser:null,
  notebook:null,
  pencil: null
}

The tagoptions.data is an array of chips:
[{
  id,
  tag
}]

Is it a real problem or am I missing something?
Thank you,
Guilherme

same problem in node and meteor

What version? I cannot reproduce this on: http://materializecss.com/forms.html#autocomplete

<EMAIL_ADDRESS>

Thank you, guys.
I'm using 0.97.8.
@neutron92 , did you solve it with this snippet?

i have this errors
materialize_materialize.js?hash=38aa0de00bf1da3e83504deced815b530abaefa4:7826 Uncaught Error: Scss compiler error: Undefined variable: "$medium-and-down".

    at materialize_materialize.js?hash=38aa0de00bf1da3e83504deced815b530abaefa4:7826
    at materialize_materialize.js?hash=38aa0de00bf1da3e83504deced815b530abaefa4:7830
    at materialize_materialize.js?hash=38aa0de00bf1da3e83504deced815b530abaefa4:7842
(anonymous) @ materialize_materialize.js?hash=38aa0de00bf1da3e83504deced815b530abaefa4:7826
(anonymous) @ materialize_materialize.js?hash=38aa0de00bf1da3e83504deced815b530abaefa4:7830
(anonymous) @ materialize_materialize.js?hash=38aa0de00bf1da3e83504deced815b530abaefa4:7842
global-imports.js?hash=5e0f0a71522c063bb881071904e7eeca01779ebd:16 Uncaught TypeError: Cannot read property 'Materialize' of undefined
    at global-imports.js?hash=5e0f0a71522c063bb881071904e7eeca01779ebd:16
(anonymous) @ global-imports.js?hash=5e0f0a71522c063bb881071904e7eeca01779ebd:16
app.js?hash=8d04954afed1b707ef74ab0f7fa58a663df0fea6:1 Uncaught ReferenceError: meteorInstall is not defined
    at app.js?hash=8d04954afed1b707ef74ab0f7fa58a663df0fea6:1

same prob here
https://codepen.io/AlphaDx/pen/xgmXgw

This should be fixed on the latest version


Versioned Container

Already asked at rocket, but moved over to the appc project.
It would be great to have versioned container as seen in docker where we have a versioned filesystem like described here:
http://0pointer.net/blog/revisiting-how-we-put-together-linux-systems.html
specially the use of sub volumes and the way how to send and receive the changes could be interesting.
I'm a bit in hurry but promised to at least open the issue. Some ideas will follow.

@hwinkel I am closing this out since I don't follow what you have in mind. Please re-open if you can provide a follow-up.


Offline.options

I am getting this error.
SyntaxError: missing ) in parenthetical
On
reconnect: {
initialDelay: 3,
delay: (1.5 * last delay, capped at 1 hour)
}

They seem to have missed to add proper name. last delay is never declared? I tried adding the var initialDelay which was right above that but get an error that is not declared.

Ahh oke, ill try that. On the other hand, im wondering if this even does anything. Because when you get connecting while its still counting down, it will go online immediately. Thus that makes that count and delay and useless.
EDIT
well i tried couple methods using it with initialDelay above it, without it. Also setting different numbers to delay. Makes no difference, it keeps starting at 10 and countdown.


nixos/nvidia: allow compute workloads

Description of changes
Have been using some rendition of this in the past, but since I had to rebase might as well create the PR.
Nothing really much, doesn't add anything, reorganizes existing module into two separate sections (driver-only and w/ display).
Personally this is a relatively important setup for hot [un]plugging.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

I like these changes,
you should squash your commits
and maybe change the enable option to something more verbose

Also I would use this myself as I dynamically bind and unbind my nvidia GPU and generate my own xorg.conf

Updated.
Interesting side-effect I observed is that NVIDIA Offload works regardless of the other offload configuration being implemented or not - at least on Wayland (Hyrpland).

Interesting side-effect I observed is that NVIDIA Offload works regardless of the other offload configuration being implemented or not - at least on Wayland (Hyrpland).

All the prime options only do xorg.conf configuration and some startup xrandr commands nothing that effects Wayland


Put Injection in AutoInject namespace

Since it was stuffed in the auto_inject dir I guess it was defined directly under the Dry namespace by mistake?

Whoooops :) Thanks!


Correct link and add llama-cpp-python installation instructions

Correct link for llama-cpp-python
Add installation instructions for llama-cpp-python
Correct first question-answer

Thank you for following up!


Jonas update ppp

Codecov Report

Merging #194 (efe4ff2) into master (9e86cae) will increase coverage by 11.91%.
The diff coverage is 93.18%.

@@              Coverage Diff              @@
##             master     #194       +/-   ##
=============================================
+ Coverage     53.68%   65.60%   +11.91%
- Complexity      587      790      +203
=============================================
  Files           103      103
  Lines          2783     2817       +34
  Branches        393      400        +7
=============================================
+ Hits           1494     1848      +354
+ Misses         1044      806      -238
+ Partials        245      163       -82

Impacted Files
Coverage Δ

...java/seedu/address/logic/commands/FindCommand.java
100.00% <ø> (ø)

...a/seedu/address/logic/commands/StudentCommand.java
100.00% <ø> (ø)

...n/java/seedu/address/logic/commands/TaCommand.java
100.00% <ø> (+16.66%)
:arrow_up:

...ava/seedu/address/model/person/GithubUsername.java
75.00% <ø> (ø)

...in/java/seedu/address/model/person/OfficeHour.java
88.00% <ø> (+52.00%)
:arrow_up:

...c/main/java/seedu/address/model/person/Rating.java
82.35% <ø> (+11.76%)
:arrow_up:

...ava/seedu/address/model/person/Specialisation.java
81.25% <ø> (+31.25%)
:arrow_up:

.../main/java/seedu/address/model/person/Student.java
72.30% <0.00%> (+15.38%)
:arrow_up:

src/main/java/seedu/address/model/person/Year.java
75.00% <ø> (+43.75%)
:arrow_up:

src/main/java/seedu/address/ui/HelpWindow.java
0.00% <ø> (ø)

... and 31 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add OpenSearch to docker setup for development

Searching SN posts in the development environment isn't supported out-of-box. We need to add an OpenSearch instance in its own container to provide the back-end search functionality.

Do we have existing index and mapping definitions that can be used to initialize the OpenSearch instance?

Mapping should happen automatically. The index called item will need to be created in some kind of initialization step, but that's it.


can't resolve npm modules

resources:

https://github.com/facebook/create-react-app/issues/4442
https://stackoverflow.com/questions/49118005/webpack-unable-to-resolve-node-module-in-docker-image

fixed:

https://stackoverflow.com/questions/53319877/react-js-docker-module-not-found

Based on your update, I realize that the problem is your old node_module volume persisted between builds. Try docker-compose down -v before up.

Using docker-compose down -v  solved the issue.

fixed


[Do not merge] yaml config work

Nuke old ini stuff
Move Sentinel to utils
Add NavigatorConfig class with a method to pull out config values and with an optional default and ability to fall back to a global default
Integrate a list of config parameters with argparse
Add some tests
Update :open logic to pull editor from config
Fix an unrelated regex deprecation warning where flags must be at the start of the string
Move argparse defaults out to config defaults and make argparse defaults be Sentinel so we know if the param was passed or not.

recheck

+1

recheck


Rename humidityOperation to humOperation in documentation

Rename humidityOperation to humOperation in documentation to match actual attribute name.

Thanks for the contribution!


mkpr

Applied mkpr on undefined
sed s/"github-repository-provider": "^.*"/"github-repository-provider": "^7.17.29"/

:tada: This PR is included in version 10.0.21 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix: return DecodedReturn instead of any[]

Return a single DecodedReturn instead of the any[] that we are currently returning when as the return values in execution results. As noir let you have one return value (that return value can be an array or struct etc) we should just return that directly instead of wrapping it inside an array for the return values. This makes it more straight-forward to use view functions as well as you can get structs directly that way (example from lending contract)
Fixes a naming from interestAccumulator -> interest_accumulator as well.
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

[ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
[ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
[ ] Every change is related to the PR description.
[ ] I have linked this pull request to relevant issues (if any exist).

Maybe we can get this into the typechain generator as well, so we get typed return types? I can tackle it after this PR is merged.


Release v1.2.2-alpha.20230224

This alpha release contains bug fixes and compatibility improvements for opcard and oath-authenticator.
To do:

[x] Release opcard
[x] Update oath-authenticator

[x] https://github.com/Nitrokey/trussed-secrets-app/pull/35
[x] https://github.com/Nitrokey/trussed-secrets-app/pull/36
[x] Release new version

I made the opcard release (was waiting for the CI)


Optimize Map and Flatmap when there are no side inputs.

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[ ] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

varargs and kwargs are expensive, even when they're empty.
This is especially true for otherwise one-argument Python calls
which are special cased in CPython.

R: @aaltay

LGTM. Thank you.


RUMM-3195: SdkReference will release SDK instance if it is stopped

What does this PR do?
This PR makes SdkReference to release SDK instance if it is stopped.
On top of that 2 methods are removed from SdkCore interface:

stop - because we already have Datadog.stopInstance which does the right thing, we don't want users to call SdkCore.stop, because it won't remove instance from the registry.
flushStoredData - there is no usage of it outside of core module and unlikely it will be needed for the users.

SdkReference class was moved to the core module, because it will be used in other modules.
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #1414 (e9e9004) into feature/sdkv2 (8586d84) will increase coverage by 0.20%.
The diff coverage is 84.22%.

@@                Coverage Diff                @@
##           feature/sdkv2    #1414      +/-   ##
=================================================
+ Coverage          81.94%   82.14%   +0.20%
=================================================
  Files                363      391      +28
  Lines              13031    13975     +944
  Branches            2191     2294     +103
=================================================
+ Hits               10677    11479     +802
- Misses              1688     1805     +117
- Partials             666      691      +25

Impacted Files
Coverage Δ

.../kotlin/com/datadog/android/ktx/tracing/SpanExt.kt
88.89% <ø> (ø)

...og/android/okhttp/utils/RequestUniqueIdentifier.kt
100.00% <ø> (ø)

...in/com/datadog/android/sqldelight/SqlDelightExt.kt
80.65% <ø> (ø)

...n/kotlin/com/datadog/android/timber/DatadogTree.kt
55.56% <0.00%> (ø)

...main/kotlin/com/datadog/android/DatadogEndpoint.kt
0.00% <ø> (ø)

...src/main/kotlin/com/datadog/android/DatadogSite.kt
100.00% <ø> (ø)

.../datadog/android/core/configuration/Credentials.kt
83.33% <ø> (-2.38%)
:arrow_down:

...id/core/internal/net/info/NetworkInfoSerializer.kt
100.00% <ø> (ø)

...internal/persistence/file/PlainFileReaderWriter.kt
46.55% <0.00%> (ø)

...al/persistence/file/single/SingleItemDataWriter.kt
96.15% <ø> (ø)

... and 102 more

... and 440 files with indirect coverage changes


Surprising results

It is surprising that the correct syntax for the simple update query is:
DB.Model(&User{}).Where(&User{Name: "foobar", Age: 32}).Updates(map[string]interface{}{"Active": true})

Where ideally the following two should work as well:
DB.Where(&User{Name: "foobar", Age: 32}).Updates(map[string]interface{}{"Active": true})
DB.Model(&User{Name: "foobar", Age: 32}).Updates(map[string]interface{}{"Active": true})

The issue is also that the error message for the first one is misleading:
TestGORM: main_test.go:16: Failed, got error: unsupported data type: map[Active:true]

For the second one it is better, but still, why necessary:
TestGORM: main_test.go:23: Failed, got error: WHERE conditions required

Unstale.


Update to image embed code

Fixes the broken screenshots.

Any reason not to use Markdown figure syntax for these images?


NIFI-4982 - Add a DistributedMapCacheLookupService

Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

A template to help reviewing/testing this PR is available in the JIRA: https://issues.apache.org/jira/secure/attachment/12914839/distributedMapCacheLookup.xml

No further comments from me, I'm +1. @zenfenan please merge. Thanks!

Thanks @ijokarumawak and @mattyb149 for the review.
Thanks @pvillard31 Everything looks good. Merged to master.


Make estimated time human readable

Split the estimated time into hours, minutes, seconds to make this statistic more useful for long videos.

Coverage decreased (-0.05%) to 71.11% when pulling 61f93bd46bfe445a2bc0e454a473e66e5fcbf910 on shssoichiro:readable-est-time into 13222ddccc8d5cfbed00871d70cd1e0d4703db63 on xiph:master.


Support a schema only translation for Prisma 1 MongoDB users

This came up while talking to @stephanlevi who has 10s of models in Prisma 1 schema syntax. He doesn't need to translate the data, just would like translate his schemas over to the Prisma 2 schema syntax.
I talked to our team and they mentioned that Prisma 1's MongoDB support wasn't officially done or labeled production-ready, but I'll see if there's any quick hacks we can do to make this work. All the code is there, it'd just need some re-jiggering.

Probably solved via: https://github.com/prisma/docs/issues/2767


flutter doctor issues

i make a variable JAVA_HOME and i put the path of jdk in it and still give me this problem !
[√] Flutter (Channel beta, 1.25.0-8.1.pre, on Microsoft Windows [Version 10.0.19042.685], locale ar-EG)
[!] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
X Android license status unknown.
Run flutter doctor --android-licenses to accept the SDK licenses.
See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.
[!] Android Studio (version 4.1.0)
X Unable to determine bundled Java version.
[√] VS Code (version 1.52.0)
[√] Connected device (1 available)

i unistalled android studio and reinstalling it and when i rum flutter doctor it give me
! Doctor found issues in 1 category.
C:\Users\asm>flutter doctor
Waiting for another flutter command to release the startup lock...
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel beta, 1.25.0-8.1.pre, on Microsoft Windows [Version 10.0.19042.685], locale ar-EG)
[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
X Android license status unknown.
Run flutter doctor --android-licenses to accept the SDK licenses.
See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.
[√] Android Studio (version 4.1.0)
[√] VS Code (version 1.52.0)
[√] Connected device (1 available)
! Doctor found issues in 1 category.

and this for licenses
C:\Users\asm>flutter doctor --android-licenses
Android sdkmanager tool not found (C:\Users\asm\AppData\Local\Android\sdk\tools\bin\sdkmanager).
Try re-installing or updating your Android SDK,
visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions.

https://stackoverflow.com/questions/52256569/android-sdkmanager-tool-not-found
Did you try any of these methods?

@Mohammed-elklawy
Try this solution and see if it works.

plugins are installed in android studio but still flutter doctor is showing its not installed . please help to remove this error
flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 1.22.5, on Microsoft Windows [Version 10.0.18363.1256], locale en-IN)
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[!] Android Studio
X Flutter plugin not installed; this adds Flutter specific functionality.
X Dart plugin not installed; this adds Dart specific functionality.
[√] VS Code (version 1.52.1)
[!] Connected device
! No devices available
! Doctor found issues in 2 categories.

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


GPTBigCode 15B

Quantization of GPTBigCode 15B seems not possible. Here an reproduction script:
from awq import AutoAWQForCausalLM
from transformers import AutoTokenizer, TextStreamer

quant_config = { "zero_point": True, "q_group_size": 128, "w_bit": 4, "version": "GEMM" }
quant_path = './WizardCoder-15B-V1.0-AWQ'

model = AutoAWQForCausalLM.from_pretrained("WizardLM/WizardCoder-15B-V1.0", device_map="auto", **{"low_cpu_mem_usage": True})# fuse_layers=False)
tokenizer = AutoTokenizer.from_pretrained("WizardLM/WizardCoder-15B-V1.0", trust_remote_code=True)

model.quantize(tokenizer, quant_config=quant_config, calib_data="nickrosh/Evol-Instruct-Code-80k-v1", text_column="output")

model.save_quantized(quant_path)
tokenizer.save_pretrained(quant_path)

print(f'Model is quantized and saved at "{quant_path}"')

Some changes I already made are in the following Github:
https://github.com/SebastianBodza/AutoAWQ_GPTBigCode15B/blob/main/awq/models/gpt_bigcode.py
As of now it is quantizing. Will be updating when finished

Still working

Looks good, please clean up the implementation and open a PR when you feel ready! :)


how to schedule task from user input?

Hi!
many thanks for useful library!
I have issue - i need to allow user to input scheduler according to his needs. Is there any way I could allow user to input scheduling command and input 'job' myself.
many thanks!

Hi @sssseossss 👋  There's nothing built into schedule directly that would help you do that, but you could certainly build your own input parsing on top of it.
I don't think adding this functionality to schedule would help in the long run, as it's a separate concern IMO.

Thanks for your question. Closing this so we can keep the tracker clean of loose ends. Feel free to follow up (or make a separate issue) with more questions/discussion 😃


Stygian End is locking the vanilla end biome so you can't tweak it

I've been trying to us Biometweaker to alter the vanilla end biome into something a bit more interesting. My tweaks take . . . but only if I disable the Stygian End Mod . . . if I turn this mod on everything resets to a set default every time.
If you could figure out why this is happening I'd really like to get it fixed. This is the only mod that adds anything interesting to the end . . . and I'd love to be able to build on it by tweaking things around and give players a really different and interesting experience. :)

Adding onto this, I've been thinking of using CoFH World to add custom content to these biomes in the form of stalactites and biome-specific ore generation. This would be much easier if I can tell the mod to only generate its worldgen in specific biomes.
As a temporary workaround, I could tell the stalactites to only generate on top of Stygian End blocks.

I doubt this mod will ever be active. Unless you're willing to continue this mod, then its dead.


Handle unsupported ProductProjection filters

Fix unsupported ProjectProjection errors
Fix: variants.prices:exists
For example, when using variants.prices:exists the following error is raised:
{
  statusCode: 400,
  message: "Invalid input 'e', expected input parameter or primitive value (line 1, column 17)",
  errors: [
    {
      code: 'InvalidInput',
      message: "Invalid input 'e', expected input parameter or primitive value (line 1, column 17)"
    }
  ]
}

This PR changes variants.prices:exists to variants(prices is defined).
Fix: categories.id:subtree("...")
For example, when using categories.id:subtree("9d898f2c-b762-4681-9462-9687491b15dc") the following error is raised:
{
  statusCode: 400,
  message: 'Internal error',
  errors: [ { code: 'InvalidInput', message: 'Internal error' } ]
}

This PR changes categories.id:subtree("xxx") to categories(id contains any ("xxx")).
Fix: variants.attributes.country:"xxx","yyy"
For example, when using multiple values: variants.attributes.country:"xxx","yyy", and error is raised.
Multiple values aren't supported yet. This PR updates "xxx","yyy" to contains any("xxx","yyy")

I think we should create a separate parser for the product projection syntax instead of trying to convert the expression in regular query compatible syntax

@mvantellingen I agree, I'll pick implement this later on.


Inclusion of the Kujira connector

Documentation describing the inclusion of the Kujira connector
HB Client PR: https://github.com/hummingbot/hummingbot/pull/6399 (merged)
HB Gateway PR: https://github.com/hummingbot/gateway/pull/138 (merged)

Hi @david-hummingbot, as requested, we've created here the documentation for the Kujira connector.
Please review and approved it for us when tou have time.
FYI: @cardosofede, @fengtality


[flux] Fix panel implementation

The panel implementation for the Flux plugin was not correct, so that
the plugin could not be used with a dashboard. This is now fixed and the
corresponding is adjusted.
We also fixed a small bug in the usage of the custom columns feature of
the built-in "resources" plugin and adjusted the corresponding
documentation.

[x] I added a CHANGELOG entry for this change.
[x] I adjusted the corresponding documentation for this change.
[ ] I adjusted the values.yaml file and the documentation for all values.

Codecov Report

Merging #368 (715a323) into main (ae9dbc3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #368   +/-   ##
=======================================
  Coverage   45.46%   45.46%
=======================================
  Files         132      132
  Lines       10261    10261
=======================================
  Hits         4665     4665
  Misses       5519     5519
  Partials       77       77

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae9dbc3...715a323. Read the comment docs.


I have issue with the toolbar loaded in multiple lines

When I try to experiment with jodit-react with the following code, my toolbar looks like below, in multiple lines
I don't see anyone else facing the same issue, so I wonder what could be wrong, can anyone share some ideas?
<div className="mx-auto sm:max-w-screen lg:max-w-7xl">
      <JoditEditor
        value={this.content}
        tabIndex={1}
        onChange={value => this.content = value}
      />
 </div>

Issue root caused. I just found out there is a conflict in another css where it configure .div to width 100%. so it cause the jodit-ui-separator class to be a new line.
Will close the issue now. thanks


Added very simple alternative jspsych-survey-html-form plugin

Hello,
for a study I'm currently working on, I created this super simple version of a form plugin. I saw, that there's already a planned form plugin in the works #135 , but maybe this is still useful as a starting point or so. This plugin simply renders an HTML string containing the input elements for the form and parses them using a vanilla JS version of jQuery's serializeArray().

Thanks! This can be a great intermediate option until the other version is ready. Are you willing to write the documentation and tests for the plugin?

I added a a test & basic documentation for the plugin :+1:
Also, is there a particular reason why data in the jspsych-survey-text plugin is passed as JSON-text and not as a JS object? Currently this plugin mirrors the behavior since I based it off of the survey-test plugin, but I could easily remove this.

Thanks again. This is a really versatile plugin!
I made one small functional change in the merged version: I encoded the data as a JSON string instead of an object. While objects are more useful, the current design is that anything encoded in the data is a primitive type. This might be worth revisiting in the future, but I wanted to maintain consistency across plugins for now.

Ah ok, that makes sense! Thanks for merging the PR.


STEP 2. creating youtube rendering functionality.

[x] Create a logger.

[x] Create a custom exception.

[x] Youtube file to deal with this module.

[x] Manual check in a jupyter notebook.

Done from developer side.


Explicitly specify when a prop is required

Maybe this is just a nitpick from my side, but I think it would be better to explicitly specify it when a prop is required. This way a developer does not overlook your prop requirement that easy.
I'm curious what you think about this change :smile:.

Sure!

versus

Maybe?

Yes, this is more clear. I'll update the pull request!

Updated:

Cool, thanks!


Browser is not supported error

Hi Team,
I am getting unsupported browser issue during initial launch,  while trying to run memlab on an application. (Ran the script in headful mode).
Observed the same script is working in Puppeteer(stand alone version) for the same chromium version.
Chrome Version is 101.0.4950.0
Tried using below code in setup function but it did'nt help:
async function setup() {
const browser = await puppeteer.launch({ product: "firefox" });
const page = await browser.newPage();
}
Can you please confirm if there is any way to select a different browser via some code in script or in runtime while executing using CLI?
Below is the screenshot of error :

Error on console:
page-load(baseline)[s1] > action-on-page(target)[s2] > revert(final)[s3]
interaction fail, making 2 more attempt(s)...
interaction fail, making 1 more attempt(s)...
Use memlab help or memlab <COMMAND> -h to get helper text
interaction fail

@KomalAgarwal1 MemLab doesn't support Firefox for now. The setup callback has a page parameter, please use that instead of creating your own, otherwise MemLab cannot navigate through the page or take heap snapshots.

@JacksonGL I have tried with page parameter also, but its giving the same error.

@KomalAgarwal1 Can you share the scenario file (with the page parameter)?

Observed the same script is working in Puppeteer(stand alone version) for the same chromium version.

What kind of chromium + Puppeteer (besides stand alone version) are you using?

Hi @JacksonGL
PFA script for your reference.
testfile.txt
Can you please elaborate on below?
What kind of chromium + Puppeteer (besides stand alone version) are you using?

@KomalAgarwal1 earlier you mentioned:

Observed the same script is working in Puppeteer(stand alone version) for the same chromium version.
Chrome Version is 101.0.4950.0

So I was asking which puppeteer + chromium version you are using that is not working for the script?

@KomalAgarwal1 Also thanks for sharing the script, I see it no longer contains the await puppeteer.launch({ product: "firefox" }); statement. Is it working right now? Or do you still get the some errors?
Tip: when the memlab run fails, rerun memlab with -v to get more debug information

@JacksonGL  No the script is still not working, it gives the same error as shown in screenshot.
Please see detailed logging below:
Xvfb supports: false
Xvfb: false
{
"_browserVersion": "Chrome/101.0.4950.0",
"_puppeteerConfig": {
"headless": false,
"devtools": false,
"ignoreHTTPSErrors": true,
"ignoreDefaultArgs": [
"--disable-extensions"
],
"userDataDir": "C:\Users\KAGARW~1\AppData\Local\Temp\memlab\data\profile",
"args": [
"--no-sandbox",
"--disable-notifications",
"--use-fake-ui-for-media-stream",
"--use-fake-device-for-media-stream",
"--js-flags="--no-move-object-start"",
"--enable-precise-memory-info",
"browser-test"
],
"defaultViewport": {
"width": 1680,
"height": 1080,
"deviceScaleFactor": 1
}
},
"_consoleMessages": []
}
Browser version: Chrome/101.0.4950.0
Node.js version: v16.17.0
Start tracking JS heap
Fri Sep 23 2022 21:48:21 GMT+0530 (India Standard Time)
[1/3] visiting page-load (baseline)
page-load(baseline)[s1] > action-on-page(target)[s2] > revert(final)[s3]
url: https://hostportalperf.cbrehost.com/login
loading: https://hostportalperf.cbrehost.com/login
URL changed:
Expected: https://hostportalperf.cbrehost.com/login
Actual:   https://hostportalperf.cbrehost.com/browserError.html
Error: No node found for selector: [id=onetrust-accept-btn-handler]
at assert (C:\Users\KAgarwal1\AppData\Roaming\npm\node_modules\memlab\node_modules\puppeteer\lib\cjs\puppeteer\common\assert.js:26:15)
at DOMWorld.click (C:\Users\KAgarwal1\AppData\Roaming\npm\node_modules\memlab\node_modules\puppeteer\lib\cjs\puppeteer\common\DOMWorld.js:287:32)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async setup (C:\Users\KAgarwal1\Downloads\MIQ\host.js:26:3)
interaction fail

I was asking which puppeteer + chromium version you are using that is not working for the script?

Puppeteer version: 13.7.0
Chrome version: 101.0.4950.0

@KomalAgarwal1 Can you share the full error message? (including the interaction fail, making 1 more attempt(s)... part)

@JacksonGL  The one I have shared in above comment is the complete error message.
If I understand correctly, you had a standalone puppeteer script (without MemLab) that did the same interactions, and it worked. Is that right?
Correct

Ah ok, I thought the error message was incomplete because of the line separator.
This part is interesting:
Expected: https://hostportalperf.cbrehost.com/login
Actual: https://hostportalperf.cbrehost.com/browserError.html

I guess https://hostportalperf.cbrehost.com has some sort of user agent checking for the browser vendor and version.

If that is the case, Is there a way using which I can pass the user-agent from memlab script?

Also, the browser version is same from both memlab and puppeteer(stand alone)

I know, memlab sets a default user agent string here:
https://github.com/facebookincubator/memlab/blob/main/packages/core/src/lib/Constant.ts#L21
For now, there is no option to set the user agent in MemLab CLI (we can add one).
To verify the theory about user agent checking, you can check out memlab git repo, change the user agent in the link above, build with npm install && npm run build and run with the built from Git repo:
node ./packages/memlab/bin/memlab run --scenario <YOUR SCENARIO FILE>

@JacksonGL
Tried the same steps as you suggested.
Changed defauft user agent as below in constant.ts file:
defaultUserAgent:
"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 " +
"(KHTML, like Gecko) Chrome/ <IP_ADDRESS> Safari / 537.36",
I am getting error in build step. Attaching the error log for the same
error.txt

@KomalAgarwal1 looks like you are building on Windows, please checkout the latest version of the Git repo

@JacksonGL
After changing defaultUserAgent to "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36" and running npm build in git bash. It is able to launch the app but partially.
Actual behavior of app: This page generates a login page and gives option to enter user details but this isn't loading properly.
Please have a look below:
Log details :
logging.txt

Ideally the page should have looked like this:

@KomalAgarwal1 That's strange.
I would recommend a few things to try:

Set defaultUserAgent to null. In that case MemLab will use Chromium's default userAgent.
When you run memlab run command also add the --debug and --headful option, which will pause execution after every step so that you can use Chromium's DevTools to see what happens in the browser page.

@KomalAgarwal1 That's strange.
I would recommend a few things to try:

Set defaultUserAgent to null. In that case MemLab will use Chromium's default userAgent.
When you run memlab run command also add the --debug and --headful option, which will pause execution after every step so that you can use Chromium's DevTools to see what happens in the browser page.

@JacksonGL These steps didn't helped much because I see the same behavior of the application. It is not loading the Email and Login area.

@KomalAgarwal1 Here are all the puppeteer configs in MemLab, you can start by removing all of the configs and add them back one by one and see which puppeteer config doesn't work with the site under test:
https://github.com/facebook/memlab/blob/main/packages/core/src/lib/Config.ts#L270


doc: add note in SSR guide about Vite Discord's #ssr channel

I think this is a good idea, at least temporarily for ssr in particular since there are a lot of questions related to it.
But the same kind of tip applies to other features of Vite, so maybe it would be good to also have a more general one pointing to Discord and Discussions at the end of the Getting Started section?

Makes sense 👍 Just pushed a new commit.


typo tempered to TAMPERED

typo tempered to TAMPERED

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update scodec-cats to 1.1.0-RC1

Updates org.scodec:scodec-cats from 1.1.0-M4 to 1.1.0-RC1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scodec", artifactId = "scodec-cats" } ]

labels: library-update, semver-pre-release

Codecov Report

Merging #389 (65aee04) into master (c020516) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #389   +/-   ##
=======================================
  Coverage   86.33%   86.33%
=======================================
  Files         108      108
  Lines        1427     1427
  Branches       37       37
=======================================
  Hits         1232     1232
  Misses        195      195

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c020516...65aee04. Read the comment docs.


WorldGuard Dependency

The worldguard dependency is a bit outdated for 1.13.2 & WG 7.0.0, it seems to be causing an error in the console.

please post the exception pls

try using the latest dev build, backup your data first

Where exactly can I find that?

I am using build #41 already, where can I finder a newer version?

I have tried building directly from github as well, and it seems like there has not been a patch for it yet.

Fixed in latest snapshots (although all custom shop flags seem to always be denied at the moment)


[AMBARI-24631] [Log Search UI] styles and layout fixes

What changes were proposed in this pull request?

Decrease the opacity of the filter panel in fixed position
The autorefresh message is in modal with a countdown
The number of events has been moved to the datatable and the graph component
+1 Fixing the data table log message performance issue by moving out the window resize event listener from the child component to the parent and by doing some optimisation in the log-message component.

How was this patch tested?
It was tested manually and by running unit tests:
PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 272 of 272 SUCCESS (13.683 secs / 13.539 secs)
✨  Done in 41.58s.

Please review Ambari Contributing Guide before opening a pull request.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3998/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/4004/
Test FAILed.
Test FAILured.

Retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/4005/
Test FAILed.
Test FAILured.

Retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/4009/
Test PASSed.


PHP Core Error – yii\base\ErrorException  Directive 'register_long_arrays' is no longer available in PHP

I intermittently get this error in my application on server. Is there any way to fix this issue from the application side? Or removing the ''register_long_arrays'' reference from php.ini is the only way to get rid of this error?
Attached is a screenshot of the error.

@dencygb, please use Official Yii forum to ask a questions - GitHub is a bug tracking system.


Improve user experience when they import gitlab projects in studio

Summary
closes #1329
Depends on finos/legend-sdlc#524

Opening a misconfigured project in studio landing page
https://user-images.githubusercontent.com/87973126/193046732-9de54fc3-708b-4356-850b-8431df383932.mp4
Trying to update project service query from a misconfigured project
https://user-images.githubusercontent.com/87973126/193047262-4235c5c1-8203-4767-be27-44c21ac14d20.mp4
Trying to edit a service query from a misconfigured project
https://user-images.githubusercontent.com/87973126/193047437-256b56bd-978d-47eb-bcf5-496d4c365867.mp4
How did you test this change?

[ ] Test(s) added
[x] Manual testing (please provide screenshots/recordings)
[ ] No testing

@gayathrir11 what backend change is this waiting for?

@gayathrir11 what backend change is this waiting for?

added an endpoint in sdlc and path parameter to an endpoint to make this work. So that needs to be get merged first

@gayathrir11 what backend change is this waiting for?

added an endpoint in sdlc and path parameter to an endpoint to make this work. So that needs to be get merged first

let's make sure you link that in the PR description!

please don't forget this :(

I have done some minor cleanups on the code and styling, but we lack another part of this. What if people don't use the setup screen and immediately jump to Editor or ServiceQueryEditor screen using the designated routes?
We have to have a guard for those cases. Ideally, I think we would do the same and fetch the project configuration status alongside with fetching the project. How do we display this is another matter:

Editor: We could make it part of the project config editor (or indicator in the status bar - like OUTDATED or so), this applies to text-mode
ServiceQueryEditor, probably a hard blocking dialog on the screen to tell them what is going on. This is arguably not too disruptive, because technically, this case cannot happen at all, non-configured projects are not ready for consumption
~We should check with @kevin-m-knight-gs about blocking people creating workspaces/releases on project that is not configured yet. Could we do this?~ - just checked, this is already handled by SDLC, it will throw 409: Project structure has not been set up

Hm, I was overthinking a bit, I think it's fair to just say that case should never happen, unless people intentionally sabotage by creating and SDLC workspace on Gitlab or so directly, due to (3). Thanks @gayathrir11 !


Many updates to API documentation.

This PR brings in the other public endpoints into the API docs, and cleans up a bunch of the API documentation in various places.
Something that @petersalas did in #78 seems to have broken docusaurus's resolution of types in the top level index.ts file. I am not sure why this is happening yet.

not a blocker: this page isn't super useful – feels redundant with the left-hand nav.