TypeScript: Adding a getter with store prop makes all store values undefined

Reproduction
https://codesandbox.io/s/modest-wood-fhujek?file=/src/store/example.store.ts
Steps to reproduce the bug

Uncomment line 18
All store data values become undefined

Expected behavior
Adding a getter to the store using the state prop should not cause all store values to be undefined
Actual behavior
I'm able to add a getter to the store just fine using the this notation. However if using the function that accepts state as a prop, then the entire store contents becomes undefined. All values no longer exist on the store state

Additional information
I am able as a workaround to type the state parameter myself
double: (state: { count: number }) => state.count * 2,

Use an arrow function for the state:
import { defineStore } from "pinia";

export const useExampleStore = defineStore("example", {
  state: () => ({
      count: 0
  }),

  getters: {
    getCount(): number {
      return this.count;
    },

    /**
     * Uncomment the following line to see the issue
     */
    double: (state): number => state.count * 2,
  },

  actions: {
    increment() {
      this.count += 1;
    }
  }
});

@posva yeah that works! What's the reasoning that it has to be this way?


wip: Web Vitals Autoinstrumentation

Hi @pkanal, do you have a timeline on this package? We're looking to incorporate the web-vitals library in otel as well and wanted to know whether we should pick it up in parallel, as we'll need it in the near future.
Also, for the CLS (and FID) metric, are we planning on keeping the default implementations for them? I know that they're dependent on user interactions, and so might never get sent until very late in the webpage's lifespan. Just wanted to know if there was any discussion on this edge case.

Hi @pkanal, do you have a timeline on this package? We're looking to incorporate the web-vitals library in otel as well and wanted to know whether we should pick it up in parallel, as we'll need it in the near future.
Also, for the CLS (and FID) metric, are we planning on keeping the default implementations for them? I know that they're dependent on user interactions, and so might never get sent until very late in the webpage's lifespan. Just wanted to know if there was any discussion on this edge case.

@shumone There's no specific timeline but I am actively working on this. The plan with the OTel Client Side SIG is to create a proof of concept in this sandbox repo and once we're happy with the API here, we will contribute this to the opentelemetry-js-contrib repo. If you're planning on working on this, we'd definitely be happy to collaborate!
At the moment we're planning on keeping the default implementation for CLS and FID. If you have any feedback for how to handle them differently feel free to comment on the PR for how they could be handled!


Host Level Queue Task Processor

Coverage decreased (-0.007%) to 67.167% when pulling 70c98405026ab7fdb931559afc8da47202a4cee8 on yycptt:queue-task-processor into 32aa76abfa38dd457ef5718f433fae92afdc904a on uber:master.


[W5][W11-2]Ling Yan Hao

All looks good, but I think you missed out on editing the HelpCommand to reflect sort as well.

Good work. You can improve upon the following:

Wildcard * imports is a coding standard violation, done automatically by Intellij. You need to configure Intellij to stop doing that. See Parser.java.
Good that you have updated tests.
It is good that you have incremental changes. You can try to have commits done in a batch for each enhancement.
After reading the comments, please close the PR.


completed

made two commits, one before we were told to edit the spec file.

4.5 / 5 (-0.5 on Q3)
Nice job, Lara. Just watch out for that instance variable thing; it'll come up a lot.


⚠ Bofrost.be has degraded performance

In e933763, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 816 ms

Resolved: Bofrost.be performance has improved in 5007da9 after 9 minutes.


tags for the docker

Hello,
Thanks for upgrading to maven 3.5.2
Is there a possibility, that you can create tags for the docker.

Hi, what tags would you like to see?

I like the present docker image.  I don't want to be affected by further
upgrades.
I have seen some tags for docker in https://hub.docker.com/r/selenium/
Thanks.
On Tue, Dec 5, 2017 at 2:39 PM, Mark Hobson<EMAIL_ADDRESS>wrote:

Hi, what tags would you like to see?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/markhobson/docker-maven-chrome/issues/2#issuecomment-349241305,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJl9DOFSm18TnAbv_Vgt-EW5q_pMbHP2ks5s9QhZgaJpZM4Q1o4k
.

--
Regards,
Rajesh
www.VeersoftSolutions.com http://www.VeersoftSolutions.com
www.GainERP.com https://www.gainerp.com
Accounting/Inventory/Orders/Sales/Purchase on Google Cloud Platform and
Mobile

Chrome is always going to be the latest version and thus ChromeDriver needs to be too. Maven is very stable so you shouldn't be affected by minor upgrades. If I upgrade to Java 9 then I'll create tags for Java 8 & 9. Hope that helps to clarify.

Is there a way to freeze the chrome version and the chrome driver in the
docker image.
Thanks
On Wed, Dec 6, 2017 at 1:13 AM, Mark Hobson<EMAIL_ADDRESS>wrote:

Chrome is always going to be the latest version and thus ChromeDriver
needs to be too. Maven is very stable so you shouldn't be affected by minor
upgrades. If I upgrade to Java 9 then I'll create tags for Java 8 & 9. Hope
that helps to clarify.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/markhobson/docker-maven-chrome/issues/2#issuecomment-349418535,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJl9DF90dOnT93zTN07yYeH--UO-LEFuks5s9ZzvgaJpZM4Q1o4k
.

--
Regards,
Rajesh
www.VeersoftSolutions.com http://www.VeersoftSolutions.com
www.GainERP.com https://www.gainerp.com
Accounting/Inventory/Orders/Sales/Purchase on Google Cloud Platform and
Mobile

Not easily as Chrome is an 'evergreen' browser, meaning that it keeps itself up-to-date. It's rarely useful to be on an old version of a browser when acceptance testing since users will typically be on the latest version.

I'm going to close this for now. You can of course build and push your own image of this container if you want to fix Chrome at a specific version.


test: e2e: framework: add a simple artifact saver

Deferring the new framework.Artifact() will write a YAML file with the
object that you're asking to be saved. The file will be placed under
directories as necessary for the logical cluster and namespace it's in,
and named by kind.group_name.
Signed-off-by: Steve Kuznetsov<EMAIL_ADDRESS>

Output looks like:
$ tree /tmp/e2e/TestClusterController/update_a_synced_object,_expect_status_to_sync_to_source/1720278361/artifacts/
/tmp/e2e/TestClusterController/update_a_synced_object,_expect_status_to_sync_to_source/1720278361/artifacts/
└── kcp
    ├── sink
    │   ├── 192-168-0-243-43617---admin
    │   │   └── cluster-controller-test
    │   │       └── cowboys.wildwest.dev_timothy.yaml
    │   └── kcp.log
    └── source
        ├── 192-168-0-243-42007---admin
        │   ├── cluster-controller-test
        │   │   └── cowboys.wildwest.dev_timothy.yaml
        │   └── clusters.cluster.example.dev_us-east1.yaml
        └── kcp.log


177370190 workbox updates

import workbox-window/index so we can see the debugging log messages of workbox-window
use messageSkipWaiting instead of sending our own messages
put up page loading message so the offline manifest isn't cached before the service worker is controlling the page

This is begging for tests, but I'm not sure how to add them. Most of the logic is mixed into the app.tsx. Probably the best is to figure out how to extact this serviceworker stuff from app.tsx. Then perhaps we can mock a few things in order to test the logic without using a real serviceworker.
But in order to get this out as a demo for I don't think we should wait for tests to merge it.

I'm going to try to document the various cases we should be handling and how to manually test them.


No quotes around column names in Postgres

Version
1.14.0
What happened?
SQLC is not adding quotes around columns in postgresql.
Query:
SELECT * FROM "Article";

Generated Query
SELECT id, title, publishDate FROM "Article";

No "" quotes around publishDate since it is camelCase 🤷♂.
How can I get sqlc to generate query like this:
SELECT "id", "title", "publishDate" FROM "Article";

Relevant log output
No response
Database schema
No response
SQL queries
SELECT * FROM "Article";

Configuration
version: 2
sql:
- engine: "postgresql"
  schema: "./pkg/db/migrations"
  queries: "./pkg/db/queries.sql"
  gen:
    go:
      package: "dbgen"
      out: "./pkg/db/dbgen"
      json_tags_case_style: camelCase
      emit_db_tags: true

No response
Playground URL
No response
What operating system are you using?
macOS
What database engines are you using?
PostgreSQL
What type of code are you generating?
Go

@akutschera Yes I have tried that and that works, but one of my tables have many columns and I don't want to specify them every time, want to use * and if there is a column with camel case sqlc should automatically surround it with quotes.

While I personally believe specifying each column you want in your answer is a good idea, I can understand your desire to just say "all columns" as in SELECT * FROM tablename.
The PR would fix it, even though I'd be happier if it were rejected, but that's not my decision.

I agree, but in larger systems, it is not possible to provide all the columns every time, if the column names generated by sqlc is surrounded by double quotes "", it will solve this problem without breaking anything.


More Strict Types for version 2.0.0

added strict_types to class
fixed issues with strict types
fixed tests

Do we need a major here or could this be 1.1.0?

I would like a new major version because we can remove the deprecated methods and the unnecessary public const properties.

Then lets do that


Typescript error - must have a 'Symbol.iterator' method that returns an iterator.

The following code show this typescript error:
Type '() => [number, Dispatch<SetStateAction>, boolean, string]' must have a 'Symbol.iterator' method that returns an iterator.
 const [value, setValue, isPersistent, error] = useChromeStorageLocal(
    'counterLocal',
    0
  )

If I put a @ts-expect-error before the line, it runs ok, but the values won't be probably typed.

Thank you for reporting @pauloendoh
The community supports typing.  Typescript is not my language.
It will be great if you create PR with a fix.

Hey, guys! @onikienko @pauloendoh I made this PR to fix it. Can you review it? I would love to use this library, and this is the only thing missing from me. https://github.com/onikienko/use-chrome-storage/pull/349


QuickBooks Online connector page - incorrect date in troubleshooting section

The page says Starting in December 2021 .... it should read 2020.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1b4c81dc-0503-5134-ddaf-2ce3e166b52d
Version Independent ID: e4e84344-d034-5f1f-9739-7623e311672f
Content: Power Query QuickBooks Online connector
Content Source: powerquery-docs/Connectors/QuickBooksOnline.md
Service: powerquery
GitHub Login: @DougKlopfenstein
Microsoft Alias: bezhan

Hi @mattmasson -
Thanks for your feedback. The date has been corrected to Dec. 2020.


Labelled Image Output with Predictions

🚀 Feature Request
model_predictions  = yolo_nas.predict(img, conf=0.5).save("ot.jpg")
Here I want to save image and also want predictions in output for postprocessing
Proposed Solution (Optional)
No response

You have it:
model_predictions = yolo_nas.predict(img, conf=0.5)
model_predictions.save("./output_directory")

# Do whatever you want with `model_predictions`
# print(...)

When I am saving image and trying to get prediction, it is throwing error

When I am saving image and trying to get prediction, it is throwing error


Update changelog

3_optional: Make more than one commits. And make them visible. Note: this is the default behavior

great work! all looks good!


Crash. Uncaught exception thrown by finalizer

No implementation found for void tv.danmaku.ijk.media.player.IjkMediaPlayer.native_finalize() (tried Java_tv_danmaku_ijk_media_player_IjkMediaPlayer_native_1finalize and Java_tv_danmaku_ijk_media_player_IjkMediaPlayer_native_1finalize__)

java.lang.UnsatisfiedLinkError: No implementation found for void tv.danmaku.ijk.media.player.IjkMediaPlayer.native_finalize() (tried Java_tv_danmaku_ijk_media_player_IjkMediaPlayer_native_1finalize and Java_tv_danmaku_ijk_media_player_IjkMediaPlayer_native_1finalize__)
at tv.danmaku.ijk.media.player.IjkMediaPlayer.native_finalize(Native Method)
at tv.danmaku.ijk.media.player.IjkMediaPlayer.finalize(IjkMediaPlayer.java:893)
at java.lang.Daemons$FinalizerDaemon.doFinalize(Daemons.java:202)
at java.lang.Daemons$FinalizerDaemon.run(Daemons.java:185)
at java.lang.Thread.run(Thread.java:818)

Use exoplayer in future,I will not research ijkplayer.

That means  you guys are not giving support for earlier implementation.
Is that new exolplayer implementation is reliable?

Yes, old version will be abandoned.
It is reliable, I will test carefully

Thanks @lipangit


💻 Create Discord integrations

:book: Description

To start integrating features we need to create Discord integrations to which we'll add a bot user.

[!NOTE]
Create one integration for each environment (production, beta-test, dev), at first we'll only use the dev one.

All integration have been created on the Discord developper portal.


Fix VMWare deployment when auth type is set to none

What does this PR do?
Allows to successfully deploy vmware ref arch when auth_type variable is set to 'none'. Without this fix the conditional handling the scenario falls under conditional checking if auth_type == ldap rendering it to be just a dead code.
How should this be manually tested?
Set variable auth_type=none in ocp_on_vmware.ini, deploy - it should work.
Is there a relevant Issue open for this?
Don't think so
Who would you like to review this?
cc: @tomassedovic @bogdando PTAL

@dav1x PTAL?


Changed PowerOff icon to FaSuperpowers icon

Changes proposed
The PowerOff icon beside Powered by Eddiefub looks a bit odd as it resembles the shutdown icon.

A better alternative would be to use the FaSuperpowers icon, which will bring a positive perspective.

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

The icon looks pretty good to me. @eddiejaoude what do you think about this.

This looks good to me. I'd still wait for Eddie and maintainers to take a decision on this

Thank You so much @stevenovak123 for your feedback ☺

@SandipPalit The new icon looks fine but i think the previous one was also good. Like the first thing that comes to mind on seeing the shut down button is power so it was depicting the text beside it. Can u explain why it was looking odd?

Hi @rohinish404 , Thank You for your feedback. I agree that the previous icon was also good, but generally, we shut down at the end of something, like we shut down our PC after completing our tasks. The new icon will bring more positive perspective to it.

Is there an open issue for this item? Can you please link it in the PR?

Not sure that the new icon is any clearer? What about a rock FaRocket or something?

Thanks @eddiejaoude for your feedback. Can I change it to FaRocket ?

Sure 👍

Done the changes. ☺


fd: 7.1.0 -> 7.2.0

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

Success on x86_64-darwin (full log)
Attempted: fd
Partial log (click to expand)
test result: ok. 38 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

installing
post-installation fixup
moving /nix/store/20klpcscx1j6b20fkjp0s9riadn2prhb-fd-7.2.0/man to /nix/store/20klpcscx1j6b20fkjp0s9riadn2prhb-fd-7.2.0/share/man
gzipping man pages under /nix/store/20klpcscx1j6b20fkjp0s9riadn2prhb-fd-7.2.0/share/man/
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/20klpcscx1j6b20fkjp0s9riadn2prhb-fd-7.2.0/bin
patching script interpreter paths in /nix/store/20klpcscx1j6b20fkjp0s9riadn2prhb-fd-7.2.0
/nix/store/20klpcscx1j6b20fkjp0s9riadn2prhb-fd-7.2.0

Success on aarch64-linux (full log)
Attempted: fd
Partial log (click to expand)
post-installation fixup
moving /nix/store/lw8ycbznfnly45qywp54787nvavyg49i-fd-7.2.0/man to /nix/store/lw8ycbznfnly45qywp54787nvavyg49i-fd-7.2.0/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/lw8ycbznfnly45qywp54787nvavyg49i-fd-7.2.0
shrinking /nix/store/lw8ycbznfnly45qywp54787nvavyg49i-fd-7.2.0/bin/fd
gzipping man pages under /nix/store/lw8ycbznfnly45qywp54787nvavyg49i-fd-7.2.0/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lw8ycbznfnly45qywp54787nvavyg49i-fd-7.2.0/bin
patching script interpreter paths in /nix/store/lw8ycbznfnly45qywp54787nvavyg49i-fd-7.2.0
checking for references to /build in /nix/store/lw8ycbznfnly45qywp54787nvavyg49i-fd-7.2.0...
/nix/store/lw8ycbznfnly45qywp54787nvavyg49i-fd-7.2.0


New version: JetBrains.RubyMine version 2024.1.1

Created by 🥟 Dumplings in workflow run #4659.
Logs
Updated: 2024.1 → 2024.1.1
Submitting WinGet manifests

Microsoft Reviewers: Open in CodeFlow

Hi @SpecterShell,

This PR's version number 2024.1.1 has 3 parameters (sets of numbers between dots - major, minor, etc), which is greater than the current manifest's version 2024.1, which has 2 parameters.

Does this PR's version number exactly match the version reported in the Apps & features Settings page? (Feel free to attach a screenshot.)
(Automated response - build 877)


Instance-level HOI Demo lack of file

Hi,
I am trying to run command train on HICO-DET
It seems that in your lib folder are lacking of matrix_sentence_76.py file ?
Thanks!!
Doanh Bui

Thanks for pointing this out! We have fixed it, and you could run python script/Download_data.py 1_ubvIeBVIBT2-M0taN4ytf72B5xx0JR7 lib/ult/matrix_sentence_76.py to download it.

Thanks for this fixing !!


Add command() to ArgSpec

There seems to be no public way to get from an ArgSpec to the command model it belongs to. Expose the existing field with a getter method.
My use case for this is so I can write a single generic IDefaultValueProvider that is sensitive to which subcommand it is getting a default for. This makes it simpler to implement Bazel-style config files that provide a uniform way to override defaults for all command-line options.
(If I'm overlooking something obvious, please advise).

Codecov Report

Merging #824 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master     #824      +/-   ##
============================================
- Coverage     93.25%   93.23%   -0.02%
  Complexity      385      385
============================================
  Files             2        2
  Lines          5704     5705       +1
  Branches       1484     1484
============================================
  Hits           5319     5319
- Misses          185      186       +1
  Partials        200      200

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/picocli/CommandLine.java
92.92% <0%> (-0.02%)
270 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc6ab69...ee13b84. Read the comment docs.

I can see how this would be useful.
The reason I did not expose this earlier was that I was worried about an unusual use case: In theory, it is possible to build an OptionSpec or a PositionalParamSpec and add it to multiple different CommandSpec instances. This would be unusual, but it is possible. In that case, the command() method will return the last command that it was added to (and there is no way to get a list of the commands it was added to previously).
However, I think it is more important that normal use cases like the one you mentioned are possible and deal with unusual use cases by simply documenting how it works. :smile:
Long story short: I like your change and I plan to merge it for picocli 4.1. :+1:
Can you do me a favor and update the javadoc to mention that, in case an ArgSpec was added to multiple commands, the method returns the last command that it was added to. Also, please mention that the method may return null if the ArgSpec has yet been added to any command, or if the ArgSpec has been remove()-ed from its command.
Finally, can I ask you to add tests for the statements made in the javadoc? (Maybe add to ModelOptionSpecTest and ModelPositionalParamSpecTest.)

Sounds reasonable. Should a similar warning apply in the javadoc for ArgSpec.group()?

You are right that ArgSpec.group() is similar. Let me think a bit about the javadoc: perhaps it is better not to mention such strange use cases. I am not sure that I want to add validation to prevent it outright, but I certainly don't want to encourage it either. Mentioning it in the javadoc makes it sound a bit like it is a legitimate thing to do...

Thank you for adding the test! :-) 👍

Merged. Thanks again for the contribution!
(I will update the release notes when I get to my PC.)


Add error attribution

@daniellekuhn @sbelkadi - put error attribution in; platform errors really seem like they're not intended to be used in the same manner / won't be seen in the same spot, so I excluded the description to users.  Seems more like it's meant for internal usage, just happens to use the same code.


Fixing publish test results in gradle task

Description: Currently, gradle task does not publish test results even if one of the tests fail because of the way handler is implemented. This fix will call publish in all cases.
Testing : Manual

Hi @prawalagarwal, thanks for this important fix!  Do you plan to also port it to the releases/m105 branch so that it makes it into Dev15 RTW?  Please let me know if I can assist with that.  Thanks again.

Hi @DavidStaheli , yes we plan to port it to releases/m105 for RTW. Should I raise a PR for it now?

Thanks @prawalagarwal.  As soon as you're comfortable merging this PR, feel free to create a new PR for releases/m105.

LGTM


nested forms are not indented properly since fix indentation issue with col-md-offset-2

with col-md-offset-2 css class :

without col-md-offset-2 css class :

Hi @fmh - just out of interest... how are you doing those custom layouts? They look great!
Cheers!

In my app , I offer the possibility to the user to choose a custom theme. This is a lot of customization of some files (form_builder.rb , *.css, etc.).

application.html.haml
= stylesheet_link_tag "rails_admin/main_css/#{current_user.theme}/rails_admin.css", media: :all

initializers/assets.rb
Rails.application.config.assets.precompile += ["rails_admin/main_css/*"]

Is there any clue that col-md-offset-2 is a bad change?
Just fixing your custom theme isn't enough?

I tried without any custom theme, only with basic (original theme), and i get the same result.
In my firebug if i remove the col-md-offset-2 class, i get the correct indentation.


typeahead-loading stuck on true when editable = false and focus is lost while loading

Bug description:
If typeahead is editable=false and focus is lost during loading, typeahead-loading get stuck on "true".
Link to minimally-working plunker that reproduces the issue:
https://plnkr.co/edit/pmEfFVWkekOeqYHgYhFZ?p=preview
Version of Angular, UIBS, and Bootstrap
Angular: 1.5.8
UIBS: 2.2.0
Bootstrap: 3.3.7

+1

Any update on this bug?  It's still occurringin 1.1.2

+1

+1 as I am able to reproduce this quite often and seems to be very annoying to our clients

As workaround, I tried to set the loading variable to false once I've got the data from server. In the same time, I used a cancel request logic onBlur and e.target.value is empty string. It works.


Improve error message when providing decryption fails due to wrong maker-id

At the moment when providing an invalid maker-id (pubkey) we get an not very informative error message:
Error: early eof

This error occurs because decryption fails because the makers pubkey was specified incorrectly. The noise library only knows that the encryption fails. We should add a meaningful error message using context() where in the codec where the decryption happens.

This seems related to the legacy network stack.


[FLOC-4277] Update CentOS base image.

https://clusterhq.atlassian.net/browse/FLOC-4277

Thanks @tomprince
I wondered if the documentation could also / instead link to:

https://cloud-images.ubuntu.com/locator/ec2/ and
https://wiki.centos.org/Cloud/AWS#head-224024c7b3b083bd574bec6861bcdfd3487a5418 or
https://aws.amazon.com/marketplace/pp/B00O7WM7QW

I added a tool recently to get the latest Ubuntu AMIs. ./admin/ami-search-ubuntu
I should extend that to get Centos-7 AMIs too. And maybe for other clouds.
Anyway, I checked all the links and they seem to work.
And the loopback acceptance tests all passed which demonstrates that the flocker/provision/_aws.py  AMIs also work.
Please merge.

And we should probably update @lukemarsden 's terraform template too:

https://github.com/ClusterHQ/unofficial-flocker-tools/blob/master/unofficial_flocker_tools/terraform_templates/variables.tf#L17


Error updating node status

Suddenly few worked nodes(everytime same set of worker nodes) goes into NotReady state and which back to normal themselves in 40 mins time. During this time I'm able to ping the pod from this issue nodes and also external url resolves fine(so network seems fine). The master nodes resources are fine too. I tried rebooting the issue node, tried restarting the kube-apiserver, tried restarting kubelet services which didn't help. Around 40 mins it was there and then it automatically get resolves.
We are worried this is production nodes which is having this unexpected issue monthly 2 or 3 times randomly.
We are facing this strange Behaviour not only in 4.13 we recently upgraded but also in 4.12 version. So this seems not related to the okd version, but not sure how to exactly find the root cause of this issue. Appreciate. any help on this.
Oct 10 00:45:20 db-1 kubenswrapper[2851]: E1010 00:45:20.016318    2851 kubelet_node_status.go:567] "Error updating node status, will retry" err="error getting
node \"db-1-fsn-eu.k8sprod.targomo.com\": Get \"https://api-int.com:6443/api/v1/nodes/db-1-fsn-eu.com?resourceVersion=0&timeout=10s\": net/http: request ca
nceled (Client.Timeout exceeded while awaiting headers)"

I added the must-gatherlogs in the below link.
https://drive.google.com/file/d/1cb7yJ0_SaarCVy9UVynhy0MHc9pzIEPb/view?usp=sharing

Seems api-int load balancer is not reachable?
Pod connectivity checks saw various outages basically every month, ranging from few seconds to several days in September:
    outages:
    - end: "2023-09-23T17:10:22Z"
      endLogs:
      - latency: 12.991728ms
        message: 'load-balancer-api-internal: tcp connection to api-int.k8sprod.targomo.com:6443
          succeeded'
        reason: TCPConnect
        success: true
        time: "2023-09-23T17:10:22Z"
...
      - latency: 9.999016129s
        message: 'load-balancer-api-internal: failed to establish a TCP connection
          to api-int.k8sprod.targomo.com:6443: dial tcp <IP_ADDRESS>:6443: i/o timeout'
        reason: TCPConnectError
        success: false
        time: "2023-09-20T01:13:27Z"
      message: Connectivity restored after 87h56m55.720371258s

Since its baremetal install you certainly should check the network setup

thanks. other nodes are just working fine like they are able to connect to api-init successfully. Those pod logs you mentioned might be due to the upgrade. Thats that exact time I was performing the cluster upgrade from 4.12 to 4.13, so might be thats the reason for those long pod connectivity check failure.

@vrutkovs Again Today I got the same issue. Here is the must gather log
https://drive.google.com/file/d/1CBWgyc2CYCIbJ_O2sRQ7yx2UuQn3-Ce_/view?usp=sharing
I don't see any network outages, similar setup in dev and test cluster don't have this issue.. Only happening on my Prod env, So confused what could be the issue. Also its happening randomly on any day. But only on the set of worker nodes. So what can I collect or what troubleshooting steps can be tried during issue time. Or any can be monitored? Appreciate your input on this please.

2023-11-01T02:35:34.334574234+00:00 stderr F I1101 02:35:34.334417       1 node_lifecycle_controller.go:1132] node db-1-fsn-eu.k8sprod.targomo.com hasn't been updated for 1h4m46.840757134s. Last PIDPressure is: &NodeCondition{Type:PIDPressure,Status:Unknown,LastHeartbeatTime:2023-11-01 01:28:52 +0000 UTC,LastTransitionTime:2023-11-01 01:31:31 +0000 UTC,Reason:NodeStatusUnknown,Message:Kubelet stopped posting node status.,}
2023-11-01T02:35:34.335672097+00:00 stderr F I1101 02:35:34.335639       1 node_lifecycle_controller.go:1132] node log-1-fsn-eu.k8sprod.targomo.com hasn't been updated for 1h4m46.843384418s. Last PIDPressure is: &NodeCondition{Type:PIDPressure,Status:Unknown,LastHeartbeatTime:2023-11-01 01:28:25 +0000 UTC,LastTransitionTime:2023-11-01 01:31:27 +0000 UTC,Reason:NodeStatusUnknown,Message:Kubelet stopped posting node status.,}

There are no worker logs in must-gather, but control plane is fine.
Please don't user issue tracker as support forum

ok thanks


[Snyk] Upgrade @tokens-studio/sd-transforms from 0.14.0 to 0.14.2

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @tokens-studio/sd-transforms from 0.14.0 to 0.14.2.
As this is a private repository, Snyk-bot does not have access. Therefore, this PR has been created automatically, but appears to have been created by a real user.
:sparkles: Snyk has automatically assigned this pull request, set who gets assigned.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 2 versions ahead of your current version.
The recommended version was released 22 days ago, on 2024-02-01.

Release notes

Package name: @tokens-studio/sd-transforms

0.14.2 - 2024-02-01v0.14.2

0.14.1 - 2024-02-01v0.14.1

0.14.0 - 2024-01-26v0.14.0

    from @tokens-studio/sd-transforms GitHub release notes

Commit messages

Package name: @tokens-studio/sd-transforms

2641465 Version Packages (#262)
d2c1ff6 fix: fontWeights allow spaces (#261)
9259f54 Version Packages (#260)
f5a8b12 fix: copy meta when expanding composites (#259)

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
👩💻 Set who automatically gets assigned
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

https://github.com/tokens-studio/style-dictionary-configurator/pull/88


Update README: Added a hint to install SDL2 before running the demos on macOS

At least in my case it was necessary to install libsdl (SDL2) before I was able to compile the demos on my Mac. I added a hint to the README in order to help other developers that stumble upon that problem.
Fixes #35

Thank you for the contribution @rwbr ! 👍


[Discussion] Allowing content above the Proposal Creation form

Is your feature request related to a problem? Please describe.
Many Spaces suffer from low-quality Proposals, which I believe is due in part to an absence of guidelines or other communication being available in the voting portal.
Snapshot's default personalization fields do not provide any way of communicating guidance to users, and according to @mktcode in the Snapshot Discord, could not be extended via plugins, as there is no render area above the Proposal Create form.
Describe the solution you'd like
Preferably, I believe all Spaces would benefit from this field being part of Snapshot's base personalization settings. Whether a full list of proposal guidelines, or simply set expectations for what a successful Proposal tangibly means, I believe many-to-most Spaces would utilize this.
However, at least providing an area before the Proposal Create form to be an update target would allow Plugin creators to build it out.

Adding another slot for plugins to render content configured in space/plugin settings would in fact be rather easy to implement. But maybe it would make more sense to add this as core functionality. A plugin might stay unnoticed by many. A new text field in the settings would be more visible. @bonustrack @samuveth @metrox-eth what do you think?

Yes I think adding this to our settings would be best. Another features that could go will with this or could even be an alternative are templates. Similar to github issue templates.

@samuveth Agree, we can add a field "guidelines" on the space level.

So now there's guidelines vs templates. Guidelines would be rather simple to implement. A new textarea field in the settings and then prepolulate the textarea on proposal creation page. One little question might be whether we want a markdown preview for this settings field or not.
The template approach would be a bit more involved. It would require a more complex settings area where you can add, remove, edit templates, and also set a default one. Some code could from the strategies/plugins dialogues could be reused maybe. On the creation page the content field needs to be filled with the default template and it needs some dropdown to select a template. And then this would require some logic to make sure things don't get lost when switching the template or being able to reset. (just thinking loud)
So we're probably roughly talking about 1 day vs 1 week.

Yeah I think they should be separate. I'm thinking of guidelines as an URL field in the space settings and a external link block on the proposal creation page. A bit like the discussion field we just added.

It's been quite a bit since we have discussed this.
Many spaces still suffer from being able to provide guidance on what constitutes a "good" (or in many cases, "valid") proposal. Having this information front and center when creating a Proposal would greatly reduce resulting strife if such a submission needs to be removed.
Additionally, I still believe it should be a direct Markdown field rather than a link, since such guidelines are central to the platform itself.
Any updates that can be shared, especially if it's "one hour effort"? cc: @mktcode

@bonustrack shall we change the Guidelines field to a Markdown instead? We can suggest rendering an URL (the [ ] ( ) syntax) if a specific space holds their guildelines somewhere else.

@zzuziak  No, settings are already to big when signing. Before we think about this we need to fix settings on hub!

Is there an issue related to that on Hub? If so, could you link it here @samuveth :pray:

@zzuziak Yes, it's here https://github.com/snapshot-labs/snapshot-hub/issues/391


Recompile with newer version of emscripten

Re #22
The current release (0.7.3) on npm does not work on node 18 or 19. It does however work if I compile the code myself.
I believe that simply the version of emscripten that you are using to compile the code is out of date and needs to be updated to support newer versions of node.

Yes, that would be a good thing. PR welcome !
The files to update are https://github.com/lovasoa/highs-js/blob/main/.devcontainer/Dockerfile
https://github.com/lovasoa/highs-js/blob/main/.github/workflows/CI.yml
and
https://github.com/lovasoa/highs-js/blob/main/.github/workflows/release.yml


Quick way of rotating a polygon?

I'm hoping for something like rotate(poly, 10.0)

You can use any package like Rotations.jl in GeometryOps.transform. transformwill give you an SVector for each point.
It will work on any geometry or arrays/feature collections/dataframes of geometries.

If using Rotations.jl you will need to wrap it in a CoordinateTransformations.LinearMap or so.

Can't get this to work though I feel as I am halfway there. @asinghvi17 what do you mean by wrap "it" with a LinearMap. Wrap what exactly? The RotMatrix?

GO.transform(transf, geom) works by calling transf(point) for each point in geom.  Rotations.jl doesn't subscribe to the CoordinateTransformations.jl way of doing things (which is just making the struct callable) and is also purely 3D, so you need to adjust it for 2D anyway.
Consider the following:
julia> import GeometryOps as GO; import Rotations, CoordinateTransformations

julia> points = tuple.(rand(10), randn(10));

julia> GO.transform(Rotations.RotX(π/4), points)
ERROR: MethodError: objects of type RotX{Float64} are not callable
Use square brackets [] for indexing an Array.
Stacktrace:
[...]

julia> rotation_matrix = Rotations.RotX(π/4)[1:2, 1:2] |> CoordinateTransformations.LinearMap
LinearMap([1.0 0.0; 0.0 0.7071067811865476])

julia> GO.transform(rotation_matrix, points)
[...]

rotation_matrix = Rotations.RotX(π/4)[1:2, 1:2] |> CoordinateTransformations.LinearMap

This was what I was missing!
I was playing around with the GO.transform(f, geom) method instead.
Thanks! Now I can replace my crude rotation function.

Actually, this seems to only work for lines.
For other more complex geoms, it doesn't behave as I would expect.
using CoordinateTransformations, Rotations
using GLMakie, GeoMakie

pnts = [(1, 3), (3, 3), (3, 1), (1, 1), (1,3)];
rotation_matrix = RotX(0.0)[1:2, 1:2] |> LinearMap
poly(pnts, alpha=0.2)
for deg in [45.0, 90.0, 180.0]
    rotation_matrix = RotX(deg2rad(deg))[1:2, 1:2] |> LinearMap
    rot_geom = Tuple.(GO.transform(rotation_matrix, pnts))
    poly!(rot_geom, alpha=0.3)
end

My bad, it should have been RotZ.
using CoordinateTransformations, Rotations
using GLMakie, GeoMakie
import GeometryOps as GO

pnts = [(1, 3), (3, 3), (3, 1), (1, 1), (1,3)];
rotation_matrix = RotZ(0.0)[1:2, 1:2] |> LinearMap
poly(pnts, alpha=0.2)
for deg in [45.0, 90.0, 180.0]
    rotation_matrix = RotZ(deg2rad(deg))[1:2, 1:2] |> LinearMap
    rot_geom = Tuple.(GO.transform(rotation_matrix, pnts))
    poly!(rot_geom, alpha=0.3)
end

You can also create your own matrix fairly easily:
using StaticArrays # so we don't allocate
rotmatrix2d(a #= angle =#) = StaticArrays.Mat2(cos(a), sin(a), -sin(a), cos(a))

poly(pnts, alpha=0.2)
for deg in [45.0, 90.0, 180.0]
    rotation_matrix = rotmatrix2d(deg2rad(deg)) |> LinearMap
    rot_geom = Tuple.(GO.transform(rotation_matrix, pnts))
    poly!(rot_geom, alpha=0.3)
end


suggestion :: log settings used

Hello,
maybee you would want to consider to display the settings_filter used, or at least corresponding file name and same for used settings_advanced.
or save a copy of the file in the result dir.
this may helps  for reproductibilty
regards
Eric

NB of course this is for pure bindcraft.py run as bindcraft.slurm does it.
to be clear I would transfert the display of those information to main script instead of slurm wrapper.
regards
Eric

Good suggestion, will be added in the next version


dbeaver/dbeaver#17635 Keep original functions, data types and keyword…

…s case

Why did you decided to store all keywords in lower case?

Please check ClockHouse, PostgreSQL, Oracle, and other databases with different cases with "default" autocomplete.
Also, please test the performance on the big script opening.

verified


Allow disabling GET requests globally.

There's a certain hazard with having GET requests trigger direct action - i.e. if someone drops a link into Slack, then it's pretty likely to fire the hook a whole lot.
It would be nice to, at least globally, disable GET requests from activating webhooks altogether and allowing only POST. Currently I accomplish this by putting nginx with a deny rule in front of it, but that's not a lightweight solution.

I completely agree with you. I propose we add allowed-http-verbs in a way we did with response headers. (Global setting and per hook setting)


[UNSUPPORTED PROTOTYPE] Dropdown: Add right to left language support (RTL)

Fixes #1970
Additional description

CONTRIBUTOR checklist (do not remove)
Please complete for every pull request

[ ] First-time contributors should sign the Contributor License Agreement.  If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
[ ] npm run lint:fix has been run and linting passes.
[ ] Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

[ ] TravisCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.

Required only if there are markup / UX changes

[ ] Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
[ ] Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
[ ] Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
[ ] While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

Snapshots need updating.
Please @ reply me when you'd like a review.

@interactivellama Do you think you could take a quick look again? Thanks!

Pushed up master branch

@interactivellama , could we please merge this?


Add more attacks in attacklist.py

Hello! I'd love to contribute to this issue and otherwise as well to the project. According to which generation are you planning to code the game?

@importhuman I have focussed on indigo league(Gen 1), but it's okay if you introduce other gen pokemons as well

I was looking at attacklist.py, and noticed that Dark and Steel types are already there (introduced in Gen 2), and there are many moves that were introduced in later generations. Also, the damage is not what the usual damage in the games is, do you want to update that? I'm assuming baseCount is PP?

Yeah Base count is PP. Feel free to add the changes, I created my own experience, health and damage increase functions so I chose values that fit best for them.

How do you determine recoil?

How do you determine recoil?

If u have seen pokemon. Some attacks like bolttackle used to affect pikachu as well. Just adding recoils to those kind of attacks. Intensity of recoil is our choice as this is not a production game xD.

Hehe, okay cool! Just checking to see if it should match some value from the actual game. :)


Known instance for Proxy

This has proven to be useful to me...does this fit with the spirit of the Known class and the library?

Can you tell me more about what you found useful?
Are there any situations where you've used the term 'known' where you couldn't have just used 'Proxy'?

I can't quite call the specific use case that prompted this, but I remember the general situation being for use with other Known instances like VecT/Index/Prod that require a Known constraint on their parameter, and using it with Proxy as the parameter.
Definitely not a big deal though, I think I got around it with something else immediately after, heh.

Good point! Having the dummy instance for Proxy might be more flexible than the current approach.
For instance, a Known instance for 'Prod Proxy as' is the same as a Known instance for 'Length as'. Length captures the structure of a type level list but not its contents.


[BUG] Model' object has no attribute 'mh_cat_layer' error with only multi-hot columns when training PyT model

Describe the bug
I am getting AttributeError: 'Model' object has no attribute 'mh_cat_layer'when I train my PyTorch model with only multi-hot columns.
Steps/Code to reproduce bug
I used example in the getting-started-with-movielens Pyt training nb.  I removed CATEGORICAL_COLUMNS = ["movieId", "userId"] single hot columns and trained model only with multi-hot columns CATEGORICAL_MH_COLUMNS = ["genres"] .
See the full error:
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<timed exec> in <module>

/nvtabular/nvtabular/framework_utils/torch/utils.py in process_epoch(dataloader, model, train, optimizer, loss_func, transform, amp, device)
    123             if amp:
    124                 with torch.cuda.amp.autocast():
--> 125                     y_pred = model(x_cat, x_cont)
    126                     y_pred_list.append(y_pred.detach())
    127                     loss = loss_func(y_pred, y)

/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py in _call_impl(self, *input, **kwargs)
    887             result = self._slow_forward(*input, **kwargs)
    888         else:
--> 889             result = self.forward(*input, **kwargs)
    890         for hook in itertools.chain(
    891                 _global_forward_hooks.values(),

/nvtabular/nvtabular/framework_utils/torch/models.py in forward(self, x_cat, x_cont)
     86             x_cat, mh_cat = x_cat
     87         if mh_cat:
---> 88             mh_cat = self.mh_cat_layer(mh_cat)
     89             concat_list.append(mh_cat)
     90         x_cat = self.initial_cat_layer(x_cat)

/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py in __getattr__(self, name)
    945             if name in modules:
    946                 return modules[name]
--> 947         raise AttributeError("'{}' object has no attribute '{}'".format(
    948             type(self).__name__, name))
    949

AttributeError: 'Model' object has no attribute 'mh_cat_layer'

Expected behavior
Models.py should be designed to work only with multi-hot columns as well.
Environment details (please complete the following information):

Environment location: Docker merlin-pytorch-training 0.5.3 image (with latest main branch pulled)
Method of NVTabular install: Docker

If method of install is [Docker], provide docker pull & docker run commands used

@jperez999 FYI. Thanks.

@karlhigley @jperez999  this  is a code example for the error.
03-Training-with-PyTorch-v1.ipynb.zip

I think the issue might be the difference between:
EMBEDDING_TABLE_SHAPES_TUPLE = (
    {
#         CATEGORICAL_COLUMNS[0]: EMBEDDING_TABLE_SHAPES[CATEGORICAL_COLUMNS[0]],
#         CATEGORICAL_COLUMNS[1]: EMBEDDING_TABLE_SHAPES[CATEGORICAL_COLUMNS[1]],
    },
    {CATEGORICAL_MH_COLUMNS[0]: MH_EMBEDDING_TABLE_SHAPES[CATEGORICAL_MH_COLUMNS[0]]}
)
EMBEDDING_TABLE_SHAPES_TUPLE

and
EMBEDDING_TABLE_SHAPES_TUPLE = (
#    {
#         CATEGORICAL_COLUMNS[0]: EMBEDDING_TABLE_SHAPES[CATEGORICAL_COLUMNS[0]],
#         CATEGORICAL_COLUMNS[1]: EMBEDDING_TABLE_SHAPES[CATEGORICAL_COLUMNS[1]],
#    },
    {CATEGORICAL_MH_COLUMNS[0]: MH_EMBEDDING_TABLE_SHAPES[CATEGORICAL_MH_COLUMNS[0]]}
)
EMBEDDING_TABLE_SHAPES_TUPLE

which changes the shape of the tuple in way that leads the base PyTorch model to mis-interpret the multi-hot shapes as the single-hot shapes, fail to find any shapes for the multi-hots, and skip creating the self.mh_cat_layer attribute (since there are no shapes.)
When Model.__init__() gets to these lines it sees a tuple with one element instead of a tuple where the first element is an empty dictionary and the second element is the multi-hot shapes, so it doesn't create a multi-hot embedding layer (because it doesn't know what shape to make it.)
This a bit of a rough edge in the API we might to smooth out somehow. 🤔


Update file cache logic

Issue Description
The file caching in the OasisDataManager package is based on the filename rather than the hash of the file data.
This causes a problem with filenames like analysis_1_inputs.tar.gz  which is the input tar (oasis files)
Example

Generate inputs With loc_file = A  --> File stored  analysis_1_inputs.tar.gz
Run Generate Losses loc_file = A --> File cached analysis_1_inputs.tar.gz
Update portfolio with loc_file = B
Generate  inputs With loc_file = B  --> File overwritten with same name analysis_1_inputs.tar.gz
Generate Losses:

run_analysis[8fa67556-5a22-4c79-885c-d78f7c4c90d7]: {'oasislmf': '2.3.4', 'ktools': 'fmcalc : version: 3.12.2 - git update: ', 'platform': '2.3.4'}
[2024-05-02 09:12:49,079: INFO/ForkPoolWorker-1] Get from Cache: oasis/server/analysis_1_inputs.tar.gz

(This is the original analysis_1_inputs.tar.gz Tar file from Step 1

Workaround to prevent the above from happening: https://github.com/OasisLMF/OasisPlatform/pull/1037
However, still might be an issue with filenames we don't have control over (like model data)


Setting addlabel to None from command line

smt configure -l cmdline or smt configure -l timestamp works but smt configure -l None does not work.
I couldn't figure out a way to set --addlabel option to None.
Is it on somewhere? Did I miss it?

You didn't miss it. This is a bug. There is a fix in pull request #318.
As a workaround until the PR is reviewed, you could manually edit .smt/project and change "data_label" to null

You didn't miss it. This is a bug. There is a fix in pull request #318.
As a workaround until the PR is reviewed, you could manually edit .smt/project and change "data_label" to null


Disable tab animations

GNOME applications seem to have no tab animations (when creating a new tab or closing a tab); I believe it's in this theme's interest to copy that.
There used to be an about:config option to exclusively disable tab animations (browser.tabs.animate) but I cannot find it anymore (using FF 60.0). Currently, disabling toolkit.cosmeticAnimations.enabled seems to work, but I believe it is also turning off other animations.
It would be nice if this theme solved this without having to mess around in about:config. What do you think? Is it possible to disable the tab animations in the CSS?
If not, perhaps it would be a good idea to add a list of about:config settings to the README that further improve this theme's resemblance to a native GNOME application.
Thank you for your work so far!

I don't think it would be possible to just disable tab animations with our CSS styles, the tab bar has a lot of JS code always trying to mess with our styles: #10 and seems like those animations have something to do with e10s which also causes other bugs: #33. Disabling toolkit.cosmeticAnimations.enabled seems to also disable the refresh button animations (ignoring browser.stopReloadAnimation.enabled) but not the downloads button ones... which can be disabled with browser.download.animateNotifications. Aside from that inconsistency, isn't disabling all of them a desirable effect if you're aiming at more strict GNOME experience?
And yes, I'll add a list of related about:config settings to the README, that sounds like a good idea.


GRAD CAM

Hi!
I would like to apply grad cam from here: https://keras.io/examples/vision/grad_cam/. The problem is that if I apply tfhub y just see one layer, what could I do?

Hi everyone! I would like to apply Grad-Cam into this model as well. I would appreciate it if you could inform me whether you solve this issue. @movaldivia @bikramb98


dynamic map aligns static map

tools/train.py下的第一句话会使得动态图和自动并行单卡精度对不齐，注释掉后对齐

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.xuyubin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

标题换一下， dynamic mode, static mode


chore: Use Xenial image for Travis

.Net install started to fail on 14.04
Pipelines is already using this version

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-java

Automation for azure-sdk-for-js

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

Can one of the admins verify this patch?

Closing since everything but the minor typo got included in #5706


Bug using "scrub" for multi disc games

When attempting to "Install Game (Scrub)" on disc2 of a multi disc game the program errors.
You can then manually rename the file to disc2.iso and copy to the correct folder but it's annoying.
I can confirm if you are not using the "scrub" option it works fine.

Also it seems to leave a "sys" folder hanging around in the directory when using scrub.
Great work on the application though, thankyou !

Also it seems to leave a "sys" folder hanging around in the directory when using scrub.

The 'sys' folder is an extra copy of the existing system folder inside the ISO/GCM file.
The Nintendont program reads the contents of this folder in case it is difficult to read the same contents within the ISO/GCM file. This folder is small, does not interfere with game performance, and can be removed if desired.

When attempting to "Install Game (Scrub)" on disc2 of a multi disc game the program errors.
You can then manually rename the file to disc2.iso and copy to the correct folder but it's annoying.
I can confirm if you are not using the "scrub" option it works fine.

I couldn't reproduce that error.
During the tests I performed the program worked correctly.
Are you using the latest version of the program (v<IP_ADDRESS>)?
It is also highly recommended to enter the 'Settings' section to configure the program to use the 'wiitdb.xml' file, as indicated in the image below.

Fixed game transfer system to second disc (disk 2) which caused a crash during transfer for some specific games.


Fix EventScriptType in CallInfo.TryGetEvent

This fixes an issue where an Event Hook will cause CallInfo.TryGetEvent() from a ScriptHandler to fail.
Fixed by preserving EventScriptType in ExecuteScript.

Example of a chest with tag "mychest_tag" and OnOpen event script "mychest_onopen"
/* Event Hook */
public void Init() {
  NwObject.FindObjectsWithTag<NwPlaceable>(
    "mychest_tag",
    "yourchest_tag",
  )
  .ToList()
  .ForEach(chest => { chest.OnOpen += DoTheFirstThing; });
}

/* Script Handler */
[ScriptHandler("mychest_onopen")]
private void OnOpenMyChest(CallInfo callInfo)
{
  if (!callInfo.TryGetEvent<PlaceableEvents.OnOpen>(out var eventData))
  {
    logger.Error("OnOpenMyChest: Failed to get event data"); // <-- This happens
    return;
  }

  DoTheSecondThing(eventData);
}

@jhett12321 CI is failing on unchanged files with check annotations. Not sure if that's anything I did - do you know?


engine: automatically port-forward on minikube/gke like docker-for-desktop does

Hello @jazzdan, @maiamcc,
Please review the following commits I made in branch nicks/forward3:
71055c2e58ada9264bb62e7548f1e5db32b5a169 (2018-08-28 18:16:14 -0400)
engine: automatically port-forward on minikube/gke like docker-for-desktop does

the more i play with this, the more i think this is...not a great experience.

the kubectl port-forwarding semantics are bad for this use-case, and it will take a bit of wrestling to get them to behave correctly
you still have to memorize the port to visit in your web browser

i wonder if we should have a UX more like Glitch, where we automatically open a browser window with your app, and auto-refresh it when your app changes. will think on this a bit.

i no longer think this is a good idea! closing


translation is not working

I am trying like below code but only the default language is showing. on npm run build files are generating in build assets folder but translation is not working.
        <LaravelReactI18nProvider
            lang={'en'}
            fallbackLang={'en'}
            resolve={async (lang) => {
                const langs = import.meta.glob('../../lang/*.json');
                try {
                    return await langs[`/lang/${lang}.json`]()
                } catch (e) {
                    //
                }
            }}
        >
            <React.StrictMode>
                <Main/>
            </React.StrictMode>
        </LaravelReactI18nProvider>

import { useLaravelReactI18n } from 'laravel-react-i18n';

const { t, tChoice, setLang, getActiveLanguage, isLoaded } = useLaravelReactI18n();

t('Test')

I tried laravel 8 with mix and laravel 10 with vite but both did not translate.

Hi,
you can try this pero as example: https://github.com/parth391/react-ssr-i18n


Windows native library (tensorflow_jni.dll) is dynamically linked to msvcp140.dll

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 7 SP1 x64
TensorFlow installed from (source or binary): Downloaded from Maven repository
TensorFlow version (use command below): 1.4.0

Describe the problem
I need to run TensorFlow on a Windows PC where I don't have admin rights. So I cannot install MS Visual C++ 2015 Redistributable package. And TensorFlow Windows native library (tensorflow_jni.dll) is dynamically linked to msvcp140.dll from that package.
Thus the only option to run TensorFlow for me is to download the DLL from some untrusted "get any DLL" site and put it somewhere in PATH.
I believe it should not be the case. Please consider dropping dependency on MS Visual C++ 2015 Redistributable package.
Or at least mention this dependency clearly in the "Using TensorFlow with a Maven project" section as well as "Install on Windows" here https://www.tensorflow.org/install/install_java
Source code / logs
The problem manifests itself as
Exception in thread "main" java.lang.UnsatisfiedLinkError: C:\Users\...\AppData\Local\Temp\tensorflow_native_libraries-...-0\tensorflow_jni.dll: Can't find dependent libraries

@mrry

Asim, I assume you know how the JNI library is built, so can you suggest a solution here?
(Since I don't think it's plausible to remove the dependency on MSVCP140.dll, perhaps we need to bundle it with the Maven package?)

Thanks for the report. I'm not familiar enough with what the convention is when it comes to packaging programs that depend on it.
I'll look into it.
CCing @meteorcloudy @gunan in case they have any thoughts (they may not).
tensorflow_jni.dll is built by this script, that invokes bazel.  I see that the TensorFlow pip packages for Windows do not package MSVCP140.dll either. I'm not sure what the convention is when it comes to distributing it with a program, I'll try to dig into this.

As far as I understand msvcp140.dll is a 'generic' library (iostream, containers, etc.) So it won't be needed if the project was built using MinGW, for example.
Alternatively (if you prefer to stick to MS VC++ compiler) you could probably use /NODEFAULTLIB option and supply alternative (statically linked) implementation.
These are my "out of thin air" guesses though. So please ignore them if I don't know what I am talking about.
P.S. Your build script applies some "hacks" with a comment that they can be removed once the following pull request is merged into Bazel:  https://github.com/bazelbuild/bazel/pull/2599
Well, it was merged in March.

Hi @sabi0,
I guess your problem is how to get the dlls inside of the "MS Visual C++ 2015 Redistributable" package?  It can be easily solved if you have another computer: Download the package from microsoft.com , install it, then copy the dlls out.  AFAIK, build tensorflow with MinGW toolchains is no longer supported.  Please use VC instead.

Thanks @snnn,
I've already figured out where to get msvcp140.dll
But I believe the problem should be solved in a generic way. So that other users like me don't have to face it in the future.
At the very least "MS Visual C++ 2015 Redistributable" dependency should be clearly mentioned in the System Requirements as well as Installation documentation.

Hi @asimshankar
For how to distribute , this article has some recommendations:
https://blogs.msdn.microsoft.com/vcblog/2015/03/03/introducing-the-universal-crt/

Bazel now use /MD to dynamically link to MSVCRT by default, but you can easily switch to static linking(/MT) by adding --features=static_link_msvcrt as a build option. (requires Bazel 0.7.0)
But be aware, using /MT  might cause problems like https://github.com/tensorflow/tensorflow/issues/12844#issuecomment-328034368

msvcp140.dll is a "Standard C++ Library for native code", not a CTR.
https://msdn.microsoft.com/en-us/library/8kche8ah.aspx
According to MS it is possible (though not recommended) to bundle redistributable DLLs with the application. See https://msdn.microsoft.com/en-us/library/ms235299.aspx
Another option is to statically link the runtime libraries using /MT switch. This will likely blow the size of the tensorflow_jni.dll. So you might want to introduce a separate "flavour" of the Maven artifact: <classifier>static</classifier>. Keeping the current one (dynamic) as default.
The /MT option is described as statically linking runtime libraries. So it might not work for standard C++ library. However it was mentioned as a solution to "MSVCP140.dll missing" question on StackOverflow: https://stackoverflow.com/questions/32998902/msvcp140-dll-missing
So I guess it does work for standard C++ library too.

It has been 14 days with no activity and this issue has an assignee.Please update the label and/or status accordingly.

Nagging Assignee: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @asimshankar: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@sabi0 Is this still a problem for you?

I believe, this is a problem "in general", not just for me.
At the very least you should mention in the installation instructions that there is a dependency on MS Visual C++ 2015 Redistributable package.
But an additional artifact (<classifier>static</classifier>) would have been a better solution, I believe.
P.S. I've already obtained the msvcp140.dll and placed it into a folder in PATH. So everything works for me.

Nagging Assignee @asimshankar: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @asimshankar: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

I'm going to go ahead and mark this as "Contributions Welcome" since it doesn't seem we have the required expertise within the TensorFlow team on Windows to work this out.
Help is certainly appreciated. Either in the form of a PR that updates the installation instructions, or ideally in the form of a PR that fixes the bazel BUILD rule. However, before sending any PR for the latter, perhaps describe the plan in a comment in this issue.
Thanks!

I was facing the same Error
java.lang.UnsatisfiedLinkError: tensorflow_native_libraries tensorflow_jni.dll: Can't find depedent libraries
@sabi0 , Thanks for your excellent debugging and RCA , I downloaded & installed Microsoft Visual C++ 2015 Redistributable on Windows Server 2008 R1 machine and it worked for me.
@asimshankar  Please update The Documentation at Tensorflow Java Install, atleast it can be mentioned that tensorflow_jni.dll (libtensorflow_jni) depends externally on Microsoft Visual C++ as part of TIPS or Side note.

@karankaw : That would be great. Could I trouble you (or any other volunteer) to send a PR? (I figured some information from folks who work in Windows more regularly than I do will be better).
The change would be to this file: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/docs_src/install/install_java.md

@asimshankar I have raised PR https://github.com/tensorflow/tensorflow/pull/19719
Please approve, if its OK

@sabi0, I have made some changes wrt mentioning dll dependency to "Install on Windows" section at https://www.tensorflow.org/install/install_java , wchich @asimshankar has approved/merged.
I guess we can close this issue once it gets live on tensorflow site.

I have followed all the instructions carefully here https://www.tensorflow.org/install/lang_java but i am still getting
java -cp libtensorflow-1.12.0.jar;. -Djava.library.path=jni HelloTensorFlow
Exception in thread "main" java.lang.UnsatisfiedLinkError: Cannot find TensorFlow native library for OS: windows, architecture: x86_64. See https://github.com/tensorflow/tensorflow/tree/master/tensorflow/java/README.md for possible solutions (such as building the library from source). Additional information on attempts to find the native library can be obtained by adding org.tensorflow.NativeLibrary.DEBUG=1 to the system properties of the JVM.
at org.tensorflow.NativeLibrary.load(NativeLibrary.java:77)
at org.tensorflow.TensorFlow.init(TensorFlow.java:66)
at org.tensorflow.TensorFlow.(TensorFlow.java:70)
at org.tensorflow.Graph.(Graph.java:361)
at HelloTensorFlow.main(HelloTensorFlow.java:9)
@karankaw  can you please help.

What version of tensorflow have people tried successfully on windows?

Starting ChromeDriver 2.46.628402 (536cd7adbad73a3783fdc2cab92ab2ba7ec361e1) on port 48819
Only local connections are allowed.
Please protect ports used by ChromeDriver and related test frameworks to prevent access by malicious code.
Mar 04, 2019 10:43:03 AM org.openqa.selenium.remote.ProtocolHandshake createSession
INFO: Detected dialect: OSS
Exception in thread "Thread-4" java.lang.UnsatisfiedLinkError: C:\Users\olelo\AppData\Local\Temp\tensorflow_native_libraries-1551676423743-0\tensorflow_jni.dll: A dynamic link library (DLL) initialization routine failed
at java.lang.ClassLoader$NativeLibrary.load(Native Method)
at java.lang.ClassLoader.loadLibrary0(Unknown Source)
at java.lang.ClassLoader.loadLibrary(Unknown Source)
at java.lang.Runtime.load0(Unknown Source)
at java.lang.System.load(Unknown Source)
at org.tensorflow.NativeLibrary.load(NativeLibrary.java:101)
at org.tensorflow.TensorFlow.init(TensorFlow.java:66)
at org.tensorflow.TensorFlow.(TensorFlow.java:70)
at org.tensorflow.Graph.(Graph.java:361)
at ai.olelo.automation.OleloSimpleWebAutomator.runOlelo(OleloSimpleWebAutomator.java:707)
at ai.olelo.automation.OleloSimpleWebAutomator$4.run(OleloSimpleWebAutomator.java:879)

@sabi0 How did you figure out that it is msvcp140.dll which is missing?
I am trying to run tensorflow on gpu and getting this generic tensorflow_jni.dll: Can't find dependent libraries error. How can I know what it missing?
Thanks in advance ;-)

@patcher You need a tool like dumpbin or DLL Export Viewer to list the DLL imported functions.
Here is what I have for tensorflow_jni.dll 1.5.0:
ADVAPI32.dll
api-ms-win-crt-convert-l1-1-0.dll
api-ms-win-crt-environment-l1-1-0.dll
api-ms-win-crt-filesystem-l1-1-0.dll
api-ms-win-crt-heap-l1-1-0.dll
api-ms-win-crt-locale-l1-1-0.dll
api-ms-win-crt-math-l1-1-0.dll
api-ms-win-crt-runtime-l1-1-0.dll
api-ms-win-crt-stdio-l1-1-0.dll
api-ms-win-crt-string-l1-1-0.dll
api-ms-win-crt-time-l1-1-0.dll
api-ms-win-crt-utility-l1-1-0.dll
KERNEL32.dll
MSVCP140.dll
SHLWAPI.dll
VCRUNTIME140.dll

Thanks a lot, I have similar picture in https://github.com/lucasg/Dependencies
Everything seems fine, yet Can't find dependent libraries error.
My problem is actually only with GPU, like here https://github.com/tensorflow/tensorflow/issues/23656
In that issue the solution is to update python... But I don't use python, I am trying to run inference in java ¯_(ツ)_/¯

Did you check the 2nd level imports? (What's imported by MSVCP140.dll, etc.)
It is also important that JVM architecture (32 or 64 bits) matches that of loaded libraries. I.e. you cannot load a 64-bit DLL into a 32-bit JVM process and vice versa.

Yes, but it is a lot. Since I have no experience with windows native development it gets overwhelming and does not tell me much.
Dependency Walker says that there are some deps missing, like API-MS-WIN-, EXT-MS-WIN- and IESHIMS.dll, but it is normal as I understood.
I know about architectures, but I am not doing anything manually, only include tensorflow from maven in my gradle build. Anyway it must be doing the right thing since CPU version starts and seems to work. Unfortunately the network I've got is using tensor format that works only on GPU. And after swapping to libtensorflow_jni_gpu I get this Can't find dependent libraries error. Must be something with CUDA and friends then. I was hoping there is an easy way to figure out what exactly is missing ;-)

Yes, but it is a lot. Since I have no experience with windows native development it gets overwhelming and does not tell me much.
Dependency Walker says that there are some deps missing, like API-MS-WIN-, EXT-MS-WIN- and IESHIMS.dll, but it is normal as I understood.
I know about architectures, but I am not doing anything manually, only include tensorflow from maven in my gradle build. Anyway it must be doing the right thing since CPU version starts and seems to work. Unfortunately the network I've got is using tensor format that works only on GPU. And after swapping to libtensorflow_jni_gpu I get this Can't find dependent libraries error. Must be something with CUDA and friends then. I was hoping there is an easy way to figure out what exactly is missing ;-)

Hello, I have the same problem as you.On windows10 systems, the call to the tensorflow-cpu version using Java runs successfully, but replacing libtensorflow_jni with libtensorflow_jni_gpu will report an error in Can't find dependent libraries.Excuse me, have you solved it?

@pacher Hello, I have the same problem as you.On windows10 systems, the call to the tensorflow-cpu version using Java runs successfully, but replacing libtensorflow_jni with libtensorflow_jni_gpu will report an error in Can't find dependent libraries.Excuse me, have you solved it?

@swzaaaaaaa No, unfortunately not. It seems that the only way to get working tensorflow gpu on windows is to install it with Anaconda. So I ended up calling it through python using Jep. Jep is awesome, but to make it work on windows is also quite a challenge. It needs to compile native bits during installation using exactly the same C++ compiler as your python was compiled with. After lots of trial and error I succeed, but sadly forgot to write the exact steps down. Now I have a working installation which I am afraid to touch or update.
From my notes back then, maybe it helps:

Jep install is easy: pip install jep, but you need RIGHT C++ compiler available.
On linux it's enough to apt install build-essential and apt install python3-dev
But on Windows it is quite a different story....
For python 3.6 you need Visual c++ 2015(!) command line build tools
This tools are even not visible on M$ download site
Working thing could be downloaded from:
https://download.microsoft.com/download/5/f/7/5f7acaeb-8363-451f-9425-68a90f98b238/visualcppbuildtools_full.exe?fixForIE=.exe
or   https://download.microsoft.com/download/E/E/D/EEDF18A8-4AED-4CE0-BEBE-70A83094FC5A/BuildTools_Full.exe
but probably the first link
Then to install jep you have to:
1. use one of the "Visual C++ 2015" (don't remember which one) shortcuts in start menu
to start command prompt
2. From this prompt activate conda environment
3. Finally pip install jep

And for python 3.7 you will probably need Visual C++ 2017...

@pacher Thank you for your answer, but I have a question, you installed jep, is the language from Java back to python, so how to connect with javaweb?


Mocha violet buttons/elements are a bit hard to read

I think the contrast just need a little change
My suggestions are black text on violet background or just simply brighter text.

I will take a look at it and get back to you guys! Emnity themes are weird
with text but I’ll give it my best shot!


Feature: media queries

I've decided to not include my first implementation of media queries into the codebase since it was very ugly and buggy. In the current codebase there is nothing related to media queries going on, so we have free range of this implementation.
Syntax
I think the most straight forward syntax would be something like this:

.
and if you want to stack them you can do that through:

.
Out-of-the-box supported media queries
Just to name a few:

@light - prefers-color-scheme light
@dark - prefers-color-scheme dark
@width-<integer> - where container width is larger than
@width--<integer> - where container width is smaller than
@height-<integer> - where container height is larger than
@height--<integer> - where container height is smaller than
@screen-width-<integer> - where screen width is larger than
@screen-width--<integer> - where screen width is smaller than
@screen-height-<integer> - where screen height is larger than
@screen-height--<integer> - where screen height is smaller than
@print - when printing
@landscape - when in landscape mode
@portrait - when in portrait mode
The media queries are configured in the config, and we ship some default ones out of the box that are commonly used.

Sorry for the accidental mention everyone! Forgot to wrap things in quotes 😅


Create No Steven plugin

A RuneLite plugin that hides everything related to the "SteVen" bots that plague F2P.
It can hide their:

Entities (e.g. models)
2D entities (e.g. hitsplats)
Overhead chats
Chat interface chats
The models of who they are interacting with

Personally, I'm not keep on entity hiding players like this. Other maintainers can chime in but this is moderately unfair if someone happens to be named steven.

I do have a config toggle that enables only checking for case-sensitive "SteVen", and I can gladly enable that by default.
Additionally, their names tend to follow a certain pattern ("SteVen" + 6 characters). Would it make a difference to you if I changed my strict mode to look for a regex that more closely matches their names?
Of course, I also don't want any innocent Stevens to be hit by this plugin, so let me know if there's anything I can do to make this more compliant.

I just changed strict mode to be on by default, and made it match against name length as well.

No, we would close the PR if we came to that decision. I expect your changes are probably sufficient, but I haven't reviewed this plugin and ron probably has not re-reviewed this since those have been implemented.


feat(navbar): added nav, feat(jumbotron) added multiple for parallax -re

approved

time to merge + delete


Move documentation to header files

I have documented Lomse events. This closes #109
I have taken this opportunity for reconsider how documentation is managed. Current approach, based on maintaining documentation apart from source code is not good when coders and documentation maintainers are the same people, as is currently the case for Lomse.
So, I have changed my mind and I have started to move the API documentation to the include files. This PR starts moving documentation to  some include files.

After latest commits all API documentation is in main repo. Old repo lomse-api will soon be deleted.
For building the documentation use script build-api-docs.sh in scripts folder.


After vibration, Projecteur constantly use one core continuously

After vibration, the program constantly use one of core for 100% time.
To reproduce:

Open Projecteur and system monitor.
Connect Spotlight USB.
In Projecteur preferences,  go to device tab and select 'Vibration Timer'
Click 'Test' in Vibration settings.

The device will vibrate but this point onwards the application use one core continuously as visible in Gnome system monitor.
OS: Debian Testing

Desktop/Window Manager and Version: Gnome 3.28

Did you built Projecteur yourself?: [y/n] n

What is the output of projecteur -f ?: ...
Projecteur 0.9.1

git-branch: master
git-hash: 483d4a36e72de3c00f3d7f76207cc73e5a88a812
compiler: GNU 8.3.0
qt-version: (build: 5.11.3, runtime: 5.15.2)
device-scan: (errors: 0, devices: 1 [readable: 1, writable: 1])

What is the output of projecteur -d ?: ...
Projecteur 0.9.1; device scan

Found 1 supported devices. (1 readable, 1 writable)

+++ name:     'Logitech USB Receiver'
userName: 'Logitech Spotlight (USB)'
vendorId:  046d
productId: c53e
phys:      usb-0000:04:00.3-2
busType:   USB
devices:   /dev/hidraw6, /dev/input/event22, /dev/input/event24, /dev/input/event23, /dev/input/event25
readable:  true
writable:  true

Hi Mayank, thanks for reporting, I will see if I can reproduce this. Will request more info from your side if necessary.

I think that calling write in device-vibrate.cc:431 is causing this issue. Flame graph generated for the application (using perf for 1 minute of activity) after the device has vibrated show a lot of system calls.


Fix invalid link of the commit status when ref is tag (#29752)

Backport #29752

Test failure related.

create/delete tag can not be triggered, we had a bug before?

And another different thing is that after calling notify_service.CreateRepository(ctx, doer, owner, repo)
repo.Units will be loaded, and in 1.21 action unit is not listed in it, but in the latest version, it will.


Astro frontmatter mark is treated as shaku line

In the sense of syntax highlighting , it it treated as comment. https://shaku-web.vercel.app/shiki-token-inspector?code=
---
import { Suspense } from 'react'
---

Hello World!<%2Fdiv>
{%2F* ^ *%2F}
{%2F*[Hello!] *%2F}

Hello World!<%2Fdiv>

&lang=astro

so it is also MDX issue


Update animate.css to 3.5.1

@mkasztelnik Thank you for a PR :smiley: I'll merge it then shipit to rubygems :shipit:

@mkasztelnik Thank you for a PR :smiley: I'll merge it then shipit to rubygems :shipit:

Many thx :smile:


Incorrect naming scheme for Utilization > Disk Load

Under Utilization, you might want to rename 'Disk Load' to 'Disk Usage'
'Disk Load' is an industry standard term for IOPs and their stats in a similar context.

🎉 A new version of camera.ui
A new version of camera.ui is currently under active development. An initial alpha/beta release and previews are coming soon. Stay tuned for exciting updates: https://github.com/seydx/camera.ui/issues/448 .
This version will no longer be developed / fixed. The new version contains many novelties and fixes (most important is for HKSV recording).


GH-1136: Support Meta Annotations with AliasFor

Resolves https://github.com/spring-projects/spring-amqp/issues/1136
Note that this is a minimal implementation that avoids major refactoring
of the BPP.
Repeatable user meta-annotatiions are not supported.
In a future release we should perform that refactoring as well as supporting
@Repeatable user annotations.
Also restore the stop() with finally to fix EnableRabbitTests.testProperShutdownOnException()
which took 30 seconds to run after the finally was removed by
c1e31798961262795c4aa2b4bab3f0f67fedda26

Do not merge.


Implement analytics

Context:

This is the placeholder to remind ourselves to implement all necessary analytics for beta launch!

@ainfeld IIRC you have analytics tickets created already 😄? If so, I'd love to link them here or just close this ticket lol Thank you!
CC: @niknak33

@niknak33 did you already create an analytics ticket for spatial updates?

@tihuan - Amanda and I synced, do you have a preference on how you want to see the tickets. We had analytics based per user story like - https://app.zenhub.com/workspaces/single-cell-5e2a191dad828d52cc78b028/issues/gh/chanzuckerberg/single-cell-data-portal/6667 or do you want all analytics in 1 big ticket?

Hurray! Thanks so much, Nik! I think separate tickets sounds good 🙏
But can you please help adding the tickets in the ticket description as a list, and then I'll convert this ticket into an analytics epic to track completion 😁
Thanks again!

Closing this in favor of https://app.zenhub.com/workspaces/single-cell-5e2a191dad828d52cc78b028/issues/gh/chanzuckerberg/single-cell-explorer/909!


Getting answers to the wrong conversations

Settings are at default

Could you provide additional information to assist in diagnosing the issue more effectively?

Were you using talk.proxoar.com or your own deployed instance?
Could you please share the content of your talk.yaml file (ensuring the API key is sanitized)?

If you were using talk.proxoar.com, it's important to note that it is a demo and does not utilize the real ChatGPT, therefore, the response is expected to be incorrect.

If you were using talk.proxoar.com, it's important to note that it is a demo and does not utilize the real ChatGPT, therefore, the response is expected to be incorrect.

Oh yeah, I was using the demo. Maybe mention that in the responses lol

If you were using talk.proxoar.com, it's important to note that it is a demo and does not utilize the real ChatGPT, therefore, the response is expected to be incorrect.

Oh yeah, I was using the demo. Maybe mention that in the responses lol

It's a good idea to mention that in responses👍. An update should be rolled out later today.


GetSmoothPath along straight lines returns diagonal movement

I have some really simple test cases that seem appear to return invalid smoothed paths.
In these screenshots, the light blue boxes are the path returned from GetSmoothPath. The agent is attempting to walk to each corner of the darker blue square.
The grid has no solid objects and a consistent cost (1.0f) across all cells in the grid.

With GetSmoothPath I would have expected all diagonal movement to be removed from the path.
Here is the same test but with GetPath(..., MovementPatterns.LateralOnly);

Hey @mhughson, I've been able to reproduce this bug:
.
It seems that if there are 3 or more tiles between the start and finish, and no obstructions, and enough space. The string pulling algorithm is only able to pull a small part of the path straight (without smoothing its a true triangle, now the top is pulled off).  I will investigate more, but I think I will need to run the string pulling algorithm recursively, or make another small adjustment.
Interesting that I never saw this happen before because my test application starts in the top left corner of a grid, and due to ordering of neighbours the errors are only to the top-left direction.

I've found the problem, the string pulling is too simplistic, I've worked out a better solution on my whiteboard and I only have one programming problem to solve before I can show something, but a few quick tests showed it solved these problems :).
(What I need now is to find all the cells that are on a line from one cell to another cell, but due to floating point inaccuracies this is proving slightly more difficult than I thought and I want to keep the code as simple as possible).

Does it make sense that a diagonal move costs the same as a lateral one? They are not the same distance. In implementations I've done in the past, I believe I made a diagonal cost slightly more than a lateral move, but cheaper than 2 lateral moves. Basically I made the cost of movement equal to the distance between the 2 points.
I believe that would solve this issue without smoothing being needed, but perhaps it would introduce other oddities.

I'm probably going to need to implement this: https://en.wikipedia.org/wiki/Bresenham's_line_algorithm

That's actually the algorithm I used to draw the blue lines in my examples above, so we've come full circle. 😄

Originally I wanted the heuristic and cost calculations to be as simple as possible. So I used Chebyshev distance for the heuristic and equal costs for the diagonal and horizontal/vertical movement.  Then using the string pulling algorithm to create nicer looking paths. My reasoning for this was that the string pulling only needs to consider the cells on the path, so that doing a little extra work afterwards would speed up things, compare to making all the costSoFar and stepCost calculations more difficult.
I had quite a few samples in which the string pulling algorithm worked really well. So I thought this was the right decision. But if I see now how much more complex (its >O(n^2) in the test branch) I have to make the string pulling algorithm to smooth out this case it might have been the wrong approach.
I hope I have time this weekend to experiment a bit, and hopefully release a better version that solves your problems.

@mhughson I've used your feedback to create a v2 version of the package, that does penalize diagonal movement, and I'm happy to say that it looks like it no longer needs any string pulling or other methods to make the paths look good. Please try it out and let me know how you like it, so I can close this issue :).

Is it possible to try via NuGet?

@mhughson yes! Its the 2.0.0 version I uploaded to last night to nuget: https://www.nuget.org/packages/RoyT.AStar/ if you already have the package you should be able to see there is an update in VS :).

Getting a crash after after a short period:
 	mscorlib.dll!System.Collections.Generic.List<RoyT.AStar.Position>.Capacity.set(int value) Line 123	C#
 	mscorlib.dll!System.Collections.Generic.List<RoyT.AStar.Position>.EnsureCapacity(int min) Line 414	C#
 	mscorlib.dll!System.Collections.Generic.List<RoyT.AStar.Position>.Add(RoyT.AStar.Position item) Line 222	C#
 	RoyT.AStar.dll!RoyT.AStar.PathFinder.ReconstructPath(RoyT.AStar.Grid grid, RoyT.AStar.Position start, RoyT.AStar.Position end, RoyT.AStar.Position[] cameFrom)	Unknown
 	RoyT.AStar.dll!RoyT.AStar.PathFinder.FindPath(RoyT.AStar.Grid grid, RoyT.AStar.Position start, RoyT.AStar.Position end, RoyT.AStar.Offset[] movementPattern)	Unknown
 	RoyT.AStar.dll!RoyT.AStar.Grid.GetPath(RoyT.AStar.Position start, RoyT.AStar.Position end, RoyT.AStar.Offset[] movementPattern)	Unknown
>	mono8samples.exe!Mono8Samples.TopDown.simple_ai.move_to_pos(float dest_x, float dest_y) Line 232	C#

Exception (the internal list you are using has 100 million + entries...
System.OutOfMemoryException was unhandled
  HResult=-2147024882
  Message=Array dimensions exceeded supported range.
  StackTrace:
       at System.Collections.Generic.List`1.set_Capacity(Int32 value) in f:\dd\ndp\clr\src\BCL\system\collections\generic\list.cs:line 123
       at System.Collections.Generic.List`1.EnsureCapacity(Int32 min) in f:\dd\ndp\clr\src\BCL\system\collections\generic\list.cs:line 414
       at System.Collections.Generic.List`1.Add(T item) in f:\dd\ndp\clr\src\BCL\system\collections\generic\list.cs:line 222
       at RoyT.AStar.PathFinder.ReconstructPath(Grid grid, Position start, Position end, Position[] cameFrom)
       at RoyT.AStar.PathFinder.FindPath(Grid grid, Position start, Position end, Offset[] movementPattern)
       at RoyT.AStar.Grid.GetPath(Position start, Position end, Offset[] movementPattern)
       at Mono8Samples.TopDown.simple_ai.move_to_pos(Single dest_x, Single dest_y) in C:\Users\Matt\Documents\Dev\Game\mono8\Mono8Samples\TopDown\simple_ai.cs:line 232
       at Mono8Samples.TopDown.simple_ai.update() in C:\Users\Matt\Documents\Dev\Game\mono8\Mono8Samples\TopDown\simple_ai.cs:line 94
       at Mono8Samples.TopDown.TopDown._update60() in C:\Users\Matt\Documents\Dev\Game\mono8\Mono8Samples\TopDown\TopDown.cs:line 302
       at Mono8.Mono8Game`1.Update(GameTime gameTime) in C:\Users\Matt\Documents\Dev\Game\mono8\Mono8\Mono8Game.cs:line 456
       at Microsoft.Xna.Framework.Game.DoUpdate(GameTime gameTime)
       at Microsoft.Xna.Framework.Game.Tick()
       at MonoGame.Framework.WinFormsGameWindow.RunLoop()
       at Microsoft.Xna.Framework.Game.Run(GameRunBehavior runBehavior)
       at Mono8Samples.Program.Main() in C:\Users\Matt\Documents\Dev\Game\mono8\Mono8Samples\Program.cs:line 19
       at System.AppDomain._nExecuteAssembly(RuntimeAssembly assembly, String[] args)
       at System.AppDomain.ExecuteAssembly(String assemblyFile, Evidence assemblySecurity, String[] args) in f:\dd\ndp\clr\src\BCL\system\appdomain.cs:line 1966
       at Microsoft.VisualStudio.HostingProcess.HostProc.RunUsersAssembly()
       at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) in f:\dd\ndp\clr\src\BCL\system\threading\executioncontext.cs:line 954
       at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) in f:\dd\ndp\clr\src\BCL\system\threading\executioncontext.cs:line 902
       at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state) in f:\dd\ndp\clr\src\BCL\system\threading\executioncontext.cs:line 891
       at System.Threading.ThreadHelper.ThreadStart() in f:\dd\ndp\clr\src\BCL\system\threading\thread.cs:line 111
  InnerException:

Here's the call that crashes and some of the values:
Position[] path = Game.map_grid.GetPath(new Position((int)(x / 8), (int)(y / 8)), new Position((int)(dest_x / 8), (int)(dest_y / 8)));

-		Game.map_grid	{RoyT.AStar.Grid}	RoyT.AStar.Grid
		DefaultCost	1	float
		DimX	128	int
		DimY	128	int
+		Weights	{float[16384]}	float[]
		dest_x	36	float
		dest_y	4	float
		path	null	RoyT.AStar.Position[]
+		this	{Mono8Samples.TopDown.simple_ai}	Mono8Samples.TopDown.simple_ai
		x	36	float
		y	7.75	float

@roy-t great work Roy ! Using this library since more than 2 months.
Wanna say thank you this way :)

Seems to work!


Error parsing stack

I'm seeing a mysterious issue when I use leaktest in combination with a high -count flag, as in:
go test -run . -failfast -count 100 --tags=unit ./...
    leaktest.go:83: leaktest: error parsing stack: "goro"
FAIL

The reported line number in leaktest.go is always the same. But the exact string it's failing to parse changes from run to run. e.g.
leaktest.go:83: leaktest: error parsing stack: "gorouti"
leaktest.go:83: leaktest: error parsing stack: "goroutine 99673 [select]:"

It seems to happen more predictably when I run with high -count values.
Any ideas what could be causing this?
Here is my go build env:
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/marshall/.cache/go-build"
GOENV="/home/marshall/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/marshall/code/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="x86_64-pc-linux-gnu-gcc"
CXX="x86_64-pc-linux-gnu-g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build261227009=/tmp/go-build -gno-record-gcc-switches"

Thanks for the report!
double checking what -count does here:
$ go help testflag | grep 'count' -A4
	-count n
	   Run each test and benchmark n times (default 1).
	   If -cpu is set, run n times for each GOMAXPROCS value.
	   Examples are always run once.

I feel like this may be caused by the goroutine count going above 100k, but I can't fathom why that'd be. Can you reproduce this in a very minimal test case, or is it only in your codebase?

@fortytw2 thanks for the reply! I can't imagine my test having more than 100k goroutines... that's crazy. I will keep debugging this and see if I can recreate it more reliably and update this case with any info I find. So far I've only seen this in one of my projects even though I use leaktest in many projects.

Awesome! Let me know if you can find a reproduction. Is it closed source code? (If it is, and I can take a look anyways, ping me on gophers slack under this same username - https://invite.slack.golangbridge.org/)

Well, I have been unable to recreate this outside our proprietary code base. What I did was lower our integration test suite from -count 100 to count 50 and this problem has stopped happening for us. Not the best solution, but it's good enough for now so that I'm not blocked by this.
Feel free to close this since I am unable to recreate this as a standalone test outside our code base... your call.
Thanks!


Meeting 8 November 2024

With @bpbond @stephpenn1 @roylrich
Roy

A generalized approach to sensor data, applicable to other parts of his SERC work
New techs have good range of technical/programming skills
New NERRS call

Steph

New ESS-DIVE project - significant potential overlaps with above - generalizing pipeline, updating SR reporting format, versioning
Roy notes could use SMARTX, B4WARM, etc. datasets for testing; and he could devote some tech time for this
Deep soil warming synthesis with Margaret Torn, Peter Reich, Michael Schmidt
ESS-DIVE workshop next week
Paper almost ready for submission

Ben

Open PR #216 re request for injecting raw instrument data into processing pipeline
Roy points out that timestamps are a problem - instruments may not (like not) be on 'correct' loggernet time

v1.2

First publish TEMPEST data to ESS-DIVE, hopefully by AGU
Release v1-2 in January (?) comprising data through end of 2024
And then a midwinter upgrade, potentially with bigger changes, in preparation for field season
At some point, an orientation meeting for Liz or whomever Roy decides

I am thinking through the timestamp issues we discussed on Friday and wanted to jot them down:

Approach
Pros
Cons

Just flag non-datalogger data
Easy for us
Users might miss documentation warnings about this

Have technicians check/record instrument time offset
Easy for us; offset would be recorded in existing Exo and Troll inventory files
A pain for techs; potentially fragile; does nothing for past data

Figure out offset algorithmically
If datalogger reports instrument timestamp, we can (probably) reconstruct offsets for orphaned data
Requires change in loggernet code; computationally non-trivial on the L1 processing side; does nothing for past data


IRI check is not done on activity query parameter of /xAPI/statements

Bug Report
Expected behavior/code
The GET query : /xAPI/statements?activity=toto should return a 400 response with an error
The LRS spec specifies that invalid parameters should trigger a 400 response :
So we should decide if we return a 200 or 400 response.
NB : lrsql returns a 400 in such case with the following body
{
    "error": {
        "message": "Invalid Params for path: /xapi/statements",
        "params": {
            "activity": "toto"
        }
    }
}

Actual Behavior
This query or any query using parameters not described in the specification returns a 200 response with no statements
Steps to Reproduce

GET : <base_url>/xAPI/statements?activity=toto

Environment

Ralph version: 3.8.0
Platform: docker compose

The specification you link to mentions "general guidance on HTTP error codes that could be returned".
FastAPI has a builtin 422 Unprocessable Entity. Perhaps we should stick to that ?


Any chance to get the non-parse version

Would love to see the the non Parse version of the application.

:+1:


Update modal_controller

Fixes :

When we submit a form and it returns with a validation error, its title was reset.

When we use asynchronous data loading in the modal window and the screen is updated, the asynchronous data was not requested again.

If we used several modals on the same screen, and at the same time they had the same form layouts, when we receive a validation error in one of them, we will be shown all of them (since they all fit the old condition).

As an example:
One screen user list
and two modals with the same field layouts
Layout::modal('userEditAsyncModal', UserEditLayout::class)->async('asyncGetUser')
Layout::modal('userCreateAsyncModal', UserEditLayout::class)
In case of a validation error in one of them, they will cause the bug mentioned above
The fix is achieved by checking the slug of the last opened modal window, and opens it in case of an error.

Partial ability to use tables in a modal window, since now when paginating or using a filter, the modal window reopens, and does not remain closed as it was before.

Briefly about the change in the behavior scheme:

In sessionStorage, we now store the json data string of the modal window, which allows us to save: the title, the form action, the parameters for the asynchronous request

Recording example:
{"title":"Edit user","submit":"http://example.com/users/saveUser?user=5","params":"{\"user\":5}","slug ":"aad113213c0e17a5038d2b6cea7f16f87c7ae37d","validateError":true}

If the closing event of the modal window fires, its sessionStorage is completely cleared

Thanks for fixing.
02f2a726fd450b71cb9ad1f23a394d069c47d1f5
In this case, point 4 can be excluded, and indeed any interaction in the modal window is excluded in addition to forms.
Although although this is probably the original idea

Hello, is point 2. fixed?
"When we use asynchronous data loading in the modal window and the screen is updated, the asynchronous data was not requested again."
When the screen is refreshed after failed validation in the modal - the modal stays opened, which is perfect. But when I close the modal and try to open again - it doesn't make the async request to refresh the data in the modal, it just open "the old" failed modal.