unnecessary-lambda fix is unsafe even when there are no side-effects

Ruff version: 0.3.3
Linter rule: unnecessary-lambda / PLW0108

Example
def foo(a, b):
  return a + b

def bar(c, d):
  return c, d

HANDLERS = {
  "foo": foo,
  "bar": lambda a, b: bar(a, b)  # "fixes" to just bar
}

def handle(verb: str, payload):
  a, b = payload
  return HANDLERS[verb](a=a, b=b)

Here we're relying on the lambda to implement renaming of positional arguments. Removing the lambda expression would be incorrect despite an absence of side-effects. A correct refactor would be to rename the arguments to bar, or to eliminate the keyword invocation but the linter fix alone is unsafe despite listing itself as such.

Thanks. That's... unfortunate, but correct.


What is the tT_loss?

There is a tT_loss term in the final loss:
https://github.com/Shark-NLP/DiffuSeq/blob/901f8604d619c1923d69e57bd11894523309aab8/diffuseq/gaussian_diffusion.py#L629-L630
What is this? I cannot find it in the paper. And accroding to the code, the out_mean looks like the mean value of $x_T\sim\mathcal{N}(0, I)$ as $T\rightarrow +\infty$ from the diffusion forward procedure, and out_mean ** 2 should then be $\bar{\alpha}_T x_0\rightarrow 0$. Also, there seems no learnable params in the compute graph of tT_loss?
I wonder what is this term for, what is the meaning, and where it comes from?

Never mind. Found in (17):

Hi, I am still confused about the questions that @yjc4 had mentioned.
As for the previous comment from @yjc4, I think this term couldn't explain these issues, because obviously it has been dropped from step 1 to step 2 in equation (17) from the paper. So could you please clarify them? Thanks.


Ignore NCrunch temporary files for Visual Studio

Reasons for making this change:
NCrunch produces quite a few cached files for each project. These are ignored by the patterns in this commit.
Links to documentation supporting these rule changes:
http://www.ncrunch.net/documentation/considerations-and-constraints_using-ncrunch-with-source-control
If this is a new template:
Link to application or project’s homepage
http://www.ncrunch.net/

@lbergnehr thanks, but this seems to overlap a bunch of what's already defined https://github.com/github/gitignore/blob/master/VisualStudio.gitignore#L112-L115 - could you unify these two sections?

@shiftkey, you're absolutely right and I feel ashamed I didn't even notice there were NCrunch rules in there already! I think I started using the .gitignore and noticed NCrunch files in my project not being ignored, incorrectly assuming they should be added to the ignore rules. However, they were likely just the *.v2.ncrunchsolution and *.v2.ncrunchproject files, which should be added to version control (according to the documentation).
I'm closing this confusing PR.


Getting the Executed line for each Resolved Statement

Currently, the Statement Iterator analyzes each statement in a Query and returns only the Resolved Statements with the respective dependency trees. I'm looking for a way to obtain both the Resolved Statements, and what statement was being executed.
Example, If my inputing Query is:
CREATE TABLE t1 AS (SELECT 1 AS column);
CREATE TABLE t2 AS (SELECT 1 AS column);

I would  like my output to look like so:
Next line: CREATE TABLE t1 AS (SELECT 1 AS column);
Result:
CreateTableAsSelectStmt
[etc]

Next line: CREATE TABLE t2 AS (SELECT 1 AS column);
Result:
CreateTableAsSelectStmt
[etc]

Is there a way to do this without manually parsing the file and inputing each statement into the ZetaSQLToolkitAnalyzer?

Since the version of the toolkit (0.4.0), performing analysis returns an Iterator of AnalyzedStatement objects. Those currently contain the parsed statement (an ASTStatement object) and, when possible, the ResolvedStatement object.
I'll add the original query to the AnalyzedStatement object in the next release of the toolkit, so it will be readily available.
In the meantime, here's an example of how you can work around not having it. Parsed statements contain the location of the statement in the original query string, so you can use those to substring the original.
String query = "CREATE TEMP TABLE `t` AS (SELECT 1 AS column);\n"
    + "SELECT * FROM `t` WHERE column = 1;";

BigQueryCatalog catalog = ...;
AnalyzerOptions options = ...;
ZetaSQLToolkitAnalyzer analyzer = new ZetaSQLToolkitAnalyzer(options);

Iterator<AnalyzedStatement> statementIterator = analyzer.analyzeStatements(query, catalog);

statementIterator.forEachRemaining(analyzedStatement -> {
  // Use the parse location to get the query segment for this statement
  ASTStatement parsedStmt = analyzedStatement.getParsedStatement();
  ParseLocationRange stmtLocation = parsedStmt.getParseLocationRange();
  String querySegment = query.substring(stmtLocation.start(), stmtLocation.end());

  Optional<ResolvedStatement> maybeResolvedStmt = analyzedStatement.getResolvedStatement();

  System.out.printf("Next statement: %s\n", querySegment);
  System.out.println("Result:");
  maybeResolvedStmt.ifPresent(System.out::println);
});

You're welcome! Thank you for using the tool!


Mac PIP 0.7.1 breaks protobuf installation

I just upgraded to the latest 0.7.1 on Mac OSX using the PIP package, and I can no longer run TF. When importing in Python 2.7 it reports that protobuf cannot be found, even though during the pip install it supposedly upgraded protobuf to 3.0.0b2.

Some finagling and reinstalling (of both protobuf and tensorflow) seems to have done the trick.

Yes, earlier wheels were doing bad things to the protobuf installation, and the only way to recover is to uninstall to 'start from scratch.'

Maybe worth noting this in the installation instructions so that people uninstall protobuf.


FieldArray re-registering field

I've been searching / debugging for days, and I can't find a solution.
Using the latest version of redux form, the code given on documentation.
When I type in a text input:

I am blurred out of the input;
The FieldArray passed component re-renders;
In redux console, I get "@@redux-form/UNREGISTER_FIELD" x number of fields in FieldArray, then "@@redux-form/REGISTER_FIELD" x number of fields in FieldArray.

This issue makes typing in a Field in a FieldArray impossible.
If I remove the FieldArray and bind the Field to root Form, the issue disappears.
Is this a bug? Can you help me?

You should post some code that reproduces the issue.
Even better if you can use http://webpackbin.com for this.
The Field arrays example works, so it must be related to something you changed in your project.

Trying to simplify the code to give it to you, I came across this:
PollEditComponent = reduxForm({form: 'PollEditComponent'})(PollEditComponent);
export default connect(state => ({
initialValues: state.community.poll.pollDetails,
formData: state.form.PollEditComponent && state.form.PollEditComponent.values
}))(PollEditComponent);
... if I remove the formData row, it all works. It doesn't make any sense.

I have a similar issue. In my case, the UNREGISTER_FIELD occurs as soon as my input goes from invalid to valid. The UNREGISTER and subsequent REGISTER calls cause my input to lose focus.
import React, { PropTypes } from 'react';
import { Field } from 'redux-form';
import Frequency from './Frequency';
import Recipient from './Recipient';

export default function NotificationFields({ fields, destroy }) {
  const renderNotification = (member, index, fields) => {
    const names = [`${ member }.frequency`, `${ member }.recipient`];
    const remove = () => {
      if (fields.get(index).id) {
        destroy(id);
      }

      fields.remove(index);
    }

    return (

          {I18n.t('settings.notification.performance.send')}

        <Field
          name={`${ member }.frequency`}
          component={Frequency}
        />

          {I18n.t('settings.notification.performance.updates_to')}

        <Field
          name={`${ member }.recipient`}
          component={Recipient}
        />
        <Field
          name={`${ member }.id`}
          component='input'
          type='hidden'
        />
        <button type='button' className='m-l-1 btn btn-secondary' onClick={remove} >

        </button>

    );
  };

  return (

      {fields.map(renderNotification)}

  );
}

Including a video in case that's helpful. The UNREGISTER and subsequent REGISTER calls do not fire if I remove the validation. Also tried using field level validation, same result.

Slight correction: UNREGISTER and REGISTER calls happen as soon as the entire form's valid state changes. Changing a single field's valid state won't cause this, unless it is the only field on the form being validated.
So far no luck reproducing this on the example in the docs. There are no differences that stand out to me. If you're unable to reproduce the issue, I will see about spinning up a simple repo and linking to it, since the project I'm working on currently is private.

Workaround identified. I was previously rendering my NotificationFields like this
    const renderFields = ({ fields }) => (
      <NotificationFields fields={fields} destroy={destroyNotification} />
    );

    return (
      <form handleSubmit={handleSubmit}>

          <FieldArray
            name='notifications'
            component={renderFields}
            validate={validateEmails}
          />

To make it work I changed the renderFields function into a component class:
export default class extends Component {
  render() {
    return (
      <NotificationFields {...this.props} />
    );
  }
}

and then
  render() {
    const { anyTouched, valid, reset, handleSubmit, destroyNotification } = this.props;

    return (
      <form handleSubmit={handleSubmit}>

          <FieldArray
            name='notifications'
            component={NotificationFields}
            destroy={destroyNotification}
            validate={validateEmails}
          />

Aha! In fact, it doesn't even need to be a component class. It just need to be defined outside of the component that's rendering it. When my parent component was re-rendering, it was recalculating the renderFields function altogether, and that always results in re-rendering the field array.

My case doesn't work in any situation. I've externalized every render function, a have used Redux Form selectors for selecting the form values (http://redux-form.com/6.4.3/docs/api/Selectors.md/), still the same problem.
Every time I connect the component with the form state, the FieldArray stops working properly... :(

@cristiansarov I would expect that in your case, because every time you update a field in your form, it's going to cause a re-render of the decorated component since the props are changing. Why exactly do you need your form values injected? If you need them, could you inject them into a child of your connected component? For example:
export function MyDecoratedForm(props) {
  return (
    <Field name="foo" component="input" />
    <FieldArray name="bars" component={renderBars} />
    <ChildComponentWithFormValuesInjected />
  );
}

@sslotsky Thank you, I think I understand the concept of re-rendering, thank you, I will try to externalise the form values.

Here I reproduced the problem
http://www.webpackbin.com/4J60qekLf

And this is the solution for me
http://www.webpackbin.com/V11Q_fkIG

@cristiansarov Could you please reincarnate your links?

What caught me was:
<Field ... validate={[required, minLength(6)]}/>

Every time the form was rendered a new minLength instance would be created which caused the field to UNREGISTER_FIELD and then REGISTER_FIELD again.
The minLength instance should be created once outside of the render function:
const minLength6 = minLength(6)

<Field ... validate={[required, minLength6]}/>

Using an inline validate function triggers UNREGISTER_FIELD and REGISTER_FIELD in 7.0.3.
It works fine in 6.8.0.

If anyone comes across this problem again in V 7 + make sure you look at @marnusw  answer! I had the same issue, and initializing the validations function OUTSIDE of the render method solved the problem.

Experiencing the samme exact issue and tried following @marnusw answer, but I have structured my code a bit differently and couldn't quite grasp how to initialize my validation outside of the render method. If anyone wants to take a look and lend a hand, please see: my post on SO

@cristiansarov can you post some code of your solution about map() inside field array? I have the same problem but I can't understand how to solve it, and the link you posted is no more available. Thank you.

If I don't use inline validation on trigger re-rendering of the FieldArray, I don't get the re-registering issue. Check if you don't re-render the FieldArray, this makes the map inside to re-render and so each field of the map re-register.

For me it was initing the validation function inside the render method causing the multiple unregister/register of my Field components. Initing the functions outside the render was the solution.
Does anyone know of any updates to redux-form since this problem was discovered? Or maybe a warning that can be displayed? It took me awhile to figure out why my fields were registering/unregistering several times until I stumbled upon this post.

Please see #4017


App crashes when saving picture

Im using an iPhone XR on ios 13.5 and whenever i go to save a comic as an image using the share button it crashes the app.
Thanks!

This used to cause a crash for me but works fine now - can you test and see if we can close this?

Yep its working now thanks!


when testing downstream use the correct release branch

additionally, we re-merge upstream in case new changes appear in HEAD
Fixes: https://github.com/knative/pkg/pull/2265

oh weird - something broke
/hold

looks like fetch-depth default is 1 and not 0 - so we'll probably want 0

/retest

/hold cancel

@n3wscott PTAL

I am not sure this is checking the HEAD repo out, but I could.be wrong. It seems it is merging the base branch back onto the pr from the fork repo? Please confirm.

It seems it is merging the base branch back onto the pr from the fork repo? Please confirm.

Upstream is here:
git remote add upstream https://github.com/${{ github.repository }}.git
repository is where the event occurred - https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#pull_request

bump @n3wscott

/retest


onnxruntime==1.16.0 release breaks tests

onnxruntime==1.16.0 was released
and tests fail.
Pinning for now. #737

For the most part, we need to fix:
>           raise ValueError(
                f"This ORT build has {available_providers} enabled. "
                "Since ORT 1.9, you are required to explicitly set "
                "the providers parameter when instantiating InferenceSession. For example, "
                f"onnxruntime.InferenceSession(..., providers={available_providers}, ...)"

https://github.com/microsoft/onnxruntime/issues/17631  Apparently they are working on a fix

closed with #738 and https://github.com/microsoft/onnxruntime/commit/1c245e6775201fec7a1d269a71deb0f3af6f7bea . Thanks all!


[baseio.py] Correct a typo in name of attribute

Change name of attribute from extentions to extensions.

Coverage decreased (-0.005%) to 50.075% when pulling d6175bd466173ca7c93bd2052f62342cdbfbec78 on mgr0dzicki:patch-1 into b3c6b61cd1599b65e63af44de0c9629244cb86ef on NeuralEnsemble:master.


Stash Highlight not working after update

As the title says, after the update, all features of the program work except the stash highlight. When someone pms me with a trade request, it no longer shows the location of the item in the stash tab. I have the feature enable and aligned correctly. I tried using the .jar and the .exe version, and I've deleted and reinstalled the program multiple times. Any way to fix this?

coordinates for item grid provided by the message, ~40% messages from poe.trade don't contain this line, are you sure it was present? like (stash tab "10"; position: left 2, top 12)

it is present. i've tested it with other items i have for sale as well and the stash highlight never shows up. it worked perfectly before update.

could you provide app.log file from %userprofile%/appdata/local/MercuryTrade

2017-03-15 05:27:35.422 [AWT-EventQueue-0] INFO  GamePathChooser - UI module was started.
2017-03-17 14:49:11.903 [nioEventLoopGroup-2-1] DEBUG UpdaterClient - Connection established
2017-03-17 14:49:11.905 [nioEventLoopGroup-2-1] INFO  ClientHandler - Requesting update info from server
2017-03-17 16:49:22.584 [nioEventLoopGroup-2-1] ERROR ClientHandler - [sun.nio.ch.SocketDispatcher.read0(Native Method), sun.nio.ch.SocketDispatcher.read(SocketDispatcher.java:43), sun.nio.ch.IOUtil.readIntoNativeBuffer(IOUtil.java:223), sun.nio.ch.IOUtil.read(IOUtil.java:192), sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:380), io.netty.buffer.PooledUnsafeDirectByteBuf.setBytes(PooledUnsafeDirectByteBuf.java:288), io.netty.buffer.AbstractByteBuf.writeBytes(AbstractByteBuf.java:1100), io.netty.channel.socket.nio.NioSocketChannel.doReadBytes(NioSocketChannel.java:349), io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:112), io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:571), io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:512), io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:426), io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:398), io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:877), io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144), java.lang.Thread.run(Thread.java:745)]
2017-03-17 16:49:22.585 [nioEventLoopGroup-2-1] DEBUG UpdaterClient - Connection lost
2017-03-17 16:49:22.589 [nioEventLoopGroup-2-1] INFO  ClientHandler - Channel is inactive
2017-03-17 16:49:22.756 [nioEventLoopGroup-2-2] DEBUG UpdaterClient - Connection established
2017-03-17 16:49:22.757 [nioEventLoopGroup-2-2] INFO  ClientHandler - Requesting update info from server
2017-03-17 17:16:35.083 [nioEventLoopGroup-2-2] DEBUG UpdaterClient - Connection lost
2017-03-17 17:16:35.084 [nioEventLoopGroup-2-2] INFO  ClientHandler - Channel is inactive
2017-03-18 11:22:16.285 [nioEventLoopGroup-2-5] DEBUG UpdaterClient - Connection established
2017-03-18 11:22:16.286 [nioEventLoopGroup-2-5] INFO  ClientHandler - Requesting update info from server
2017-03-18 11:44:02.871 [AWT-EventQueue-0] DEBUG ClientHandler - Requesting patch notes message from server
2017-03-18 11:44:02.872 [AWT-EventQueue-0] DEBUG ClientHandler - Requesting patch notes message from server
2017-03-18 11:44:02.873 [AWT-EventQueue-0] DEBUG ClientHandler - Requesting patch notes message from server
2017-03-18 11:44:05.589 [AWT-EventQueue-0] DEBUG ClientHandler - Requesting update message from server
2017-03-18 11:44:05.589 [AWT-EventQueue-0] DEBUG ClientHandler - Requesting update message from server
2017-03-18 11:44:05.589 [AWT-EventQueue-0] DEBUG ClientHandler - Requesting update message from server
2017-03-18 11:47:09.747 [nioEventLoopGroup-2-5] DEBUG UpdaterClient - Connection lost
2017-03-18 11:47:09.754 [nioEventLoopGroup-2-5] INFO  ClientHandler - Channel is inactive
2017-03-18 11:47:11.866 [Timer-0] DEBUG UpdateManager - Execute local updater, source path: C:/Users/Admin/Desktop/Anish/poe/MercuryTrade/MercuryTrade.jar
2017-03-18 11:47:19.897 [nioEventLoopGroup-2-1] DEBUG UpdaterClient - Connection established
2017-03-18 11:47:19.899 [nioEventLoopGroup-2-1] INFO  ClientHandler - Requesting update info from server
2017-03-18 12:19:32.104 [nioEventLoopGroup-2-1] DEBUG UpdaterClient - Connection lost
2017-03-18 12:19:32.108 [nioEventLoopGroup-2-1] INFO  ClientHandler - Channel is inactive
2017-03-18 12:19:50.248 [nioEventLoopGroup-2-1] DEBUG UpdaterClient - Connection established
2017-03-18 12:19:50.250 [nioEventLoopGroup-2-1] INFO  ClientHandler - Requesting update info from server
2017-03-18 12:24:47.000 [nioEventLoopGroup-2-1] DEBUG UpdaterClient - Connection lost
2017-03-18 12:24:47.003 [nioEventLoopGroup-2-1] INFO  ClientHandler - Channel is inactive
2017-03-18 12:25:05.580 [nioEventLoopGroup-2-1] DEBUG UpdaterClient - Connection established
2017-03-18 12:25:05.581 [nioEventLoopGroup-2-1] INFO  ClientHandler - Requesting update info from server
2017-03-18 12:28:45.362 [nioEventLoopGroup-2-1] DEBUG UpdaterClient - Connection lost
2017-03-18 12:28:45.366 [nioEventLoopGroup-2-1] INFO  ClientHandler - Channel is inactive
2017-03-18 12:31:24.008 [nioEventLoopGroup-2-1] DEBUG UpdaterClient - Connection established
2017-03-18 12:31:24.009 [nioEventLoopGroup-2-1] INFO  ClientHandler - Requesting update info from server
2017-03-18 12:33:04.295 [nioEventLoopGroup-2-1] DEBUG UpdaterClient - Connection lost
2017-03-18 12:33:04.306 [nioEventLoopGroup-2-1] INFO  ClientHandler - Channel is inactive
2017-03-18 12:33:12.301 [nioEventLoopGroup-2-1] DEBUG UpdaterClient - Connection established
2017-03-18 12:33:12.303 [nioEventLoopGroup-2-1] INFO  ClientHandler - Requesting update info from server
2017-03-18 12:34:16.423 [nioEventLoopGroup-2-1] DEBUG UpdaterClient - Connection lost
2017-03-18 12:34:16.426 [nioEventLoopGroup-2-1] INFO  ClientHandler - Channel is inactive
2017-03-18 12:36:44.671 [nioEventLoopGroup-2-1] DEBUG UpdaterClient - Connection established
2017-03-18 12:36:44.673 [nioEventLoopGroup-2-1] INFO  ClientHandler - Requesting update info from server
2017-03-18 12:51:46.562 [nioEventLoopGroup-2-1] DEBUG UpdaterClient - Connection lost
2017-03-18 12:51:46.566 [nioEventLoopGroup-2-1] INFO  ClientHandler - Channel is inactive
2017-03-18 12:52:45.711 [nioEventLoopGroup-2-1] DEBUG UpdaterClient - Connection established
2017-03-18 12:52:45.712 [nioEventLoopGroup-2-1] INFO  ClientHandler - Requesting update info from server

nothing unfortunately, give me app-config.json file in the same folder I'll try

{"inGameDnd":"false","itemsGridEnable":"true","buttons":[{"isClose":"false","isKick":"false","id":0,"title":"1s","value":"1 sec pls"},{"isClose":"false","isKick":"true","id":1,"title":"thx","value":"t4t and ss"},{"isClose":"false","isKick":"false","id":2,"title":"no thx","value":"nty sorry"},{"isClose":"false","isKick":"false","id":3,"title":"sold","value":"sorry just sold it. gl and ss"},{"isClose":"false","isKick":"false","id":4,"title":"map","value":"in a map. give me a min pls"}],"expandedMsgCount":"2","showPatchNotes":"false","dndResponseText":"Response text","checkUpdateOnStartUp":"true","minOpacity":"56","framesSettings":[{"size":{"width":280,"height":115},"location":{"frameX":200,"frameY":500},"frameClassName":"OutMessageFrame"},{"size":{"width":300,"height":30},"location":{"frameX":400,"frameY":600},"frameClassName":"SetUpLocationFrame"},{"size":{"width":400,"height":100},"location":{"frameX":1400,"frameY":500},"frameClassName":"TestCasesFrame"},{"size":{"width":500,"height":250},"location":{"frameX":400,"frameY":600},"frameClassName":"ChatScannerFrame"},{"size":{"width":240,"height":30},"location":{"frameX":400,"frameY":600},"frameClassName":"ChunkMessagesPicker"},{"size":{"width":315,"height":0},"location":{"frameX":565,"frameY":927},"frameClassName":"IncMessageFrame"},{"size":{"width":280,"height":400},"location":{"frameX":600,"frameY":500},"frameClassName":"HistoryFrame"},{"size":{"width":240,"height":102},"location":{"frameX":400,"frameY":600},"frameClassName":"TimerFrame"},{"size":{"width":540,"height":500},"location":{"frameX":505,"frameY":386},"frameClassName":"SettingsFrame"},{"size":{"width":659,"height":748},"location":{"frameX":12,"frameY":65},"frameClassName":"ItemsGridFrame"},{"size":{"width":520,"height":30},"location":{"frameX":400,"frameY":600},"frameClassName":"GamePathChooser"},{"size":{"width":109,"height":20},"location":{"frameX":235,"frameY":900},"frameClassName":"TaskBarFrame"},{"size":{"width":400,"height":300},"location":{"frameX":400,"frameY":600},"frameClassName":"CurrencySearchFrame"},{"size":{"width":540,"height":100},"location":{"frameX":400,"frameY":600},"frameClassName":"NotesFrame"}],"dismissAfterKick":"true","stashTabs":[],"flowDirection":"DOWNWARDS","whisperNotifier":"ALWAYS","decayTime":"0","showOnStartUp":"false","maxOpacity":"100","tradeMode":"DEFAULT","gamePath":"C:\Program Files (x86)\Grinding Gear Games\Path of Exile\","limitMsgCount":"3"}

i tried download and using a previous version but doing so doesnt reset my settings so the problem persists

you used the setting change of the game?

does every tab (quad tab / regular) has this issue? do you have the little tab name boxes drawn or absolutely nothing?
to hard reset erase %userprofile%/appdata/local/mercurytrade folder

every tab has this issue. ill try a hard reset and let you know what happens.

even with hard reset and using an older version it doesnt work anymore. idk

so u have <IP_ADDRESS> where it worked before and even with the hard reset it is not working?

correct

it's very strange, the other components of the program work?

everything else works.

I can't even imagine that after hard reset, even on the old version it ceased to work.

omg i fixed it.

👍

im not sure what the problem was. i only got the older version to work. the new one still isnt working.

I will try to find the cause of this problem, if suddenly will work please let me know about it.

@apexius92 problem found, will be fixed soon


BroupBy hide parent when filtering

Hello, I am using groupBy filter for creating nested tree from object, and I want to hide parent on filtering with an input. if it doesn't have any matching child.
My html code look like this:

<input type="text"  ng-model="mySearchFilter">

    Group name: {{ key }}

        player: {{ player.name }}

You can use filterBy before groupBy team in the first repeat instead of filtering in the second repeat.
I made an example.

yess!!! many thanks fikoborquez.


Replace OpenAI Embeddings with Self-hosted Embeddings

Replacing OpenAI Embeddings in retrieval and ingest with self-hosted ollama embeddings.
https://github.com/ollama/ollama-python?tab=readme-ov-file
https://docs.ncsa.ai/simple-ollama-hosting

This project has been delayed indefinitely. We will focus on cool new features instead of pragmatic cost savings. We're not on this planet long enough to worry about cost savings when there's research to be done!


Workflow Build and test on linux stopped working (again)

TODO: Add guards, pragma does not suffice


For the release of v0.1.0-alpha.1 version, task list

java doc

[x] Refactor comments for each method

dynamically load the specific vendor implement

[x] URL component definition
[x] Load the implementation according to the URL
[x] Check if the specification version matches the implementation version

## Message filtering section
- [ ] support resource management api
Postponed to next release.
refactor properties
exception code & url

[x] Define OMS internal error code and provide a reference URL

Promise and Future

[x] Resolve issue #6

@vongosling @zhouxinyu @vintagewang  If there are missed task, please add by yourself

Exception Code & URL
When OpenMessaging internal error occurred, a reference URL will be printed for user:
Exception in thread "main" io.openmessaging.exception.OMSRuntimeException: The OMS driver URL [oms:rocketmq:abcde] is illegal.
For more information, please visit the URL, http://openmessaging.cloud/internal/error-code.html#oms_driver_url_illegal
	at io.openmessaging.internal.MessagingAccessPointAdapter.generateInternalException(MessagingAccessPointAdapter.java:108)
	at io.openmessaging.internal.MessagingAccessPointAdapter.checkDriverURL(MessagingAccessPointAdapter.java:90)
	at io.openmessaging.internal.MessagingAccessPointAdapter.getMessagingAccessPoint(MessagingAccessPointAdapter.java:52)

#6 has been resolved, Promise now extends Future. Future is read-only, while Promise is writable.

Released!


Fix encrypted SSH keys

This should fix #553

Currently a WIP.

Hey @johnhaley81 , I tried to install your fix branch to test it here, but I wasnt successful.
Basically, I noticed that the latest version 0.4.0 cant be installed here on Mac. I dont know whats up, but after the install is successful, the require('nodegit') fails, since there is no ./lib/nodegit.js file here. I dont know whats going on. It seems that the file is not created here. The only nodegit.js file found in my project is the one from the template folder.
Do you have any idea what I may be doing wrong?

So first things first, this is "passing" tests even though it's failing on CI. Don't know why this is happening but it's very wrong.
@lucastschmidt So you need a proper build setup to compile nodegit from source. We have this guide which you can use to figure out what you're missing.
Also, this just added a failing test so I could repo your issue with #553. Now it's not an issue with the code but rather an issue that I added a key to use in the tests but never added it to the server. As soon as I add it to GitHub the test will work fine.

So the main issue with this is that we don't have an account registered with the provided SSH key. As soon as we can do that the test should pass and we can merge this in.

Rebased, fixed it to match the current api, and added the key to have read-only access to the test repo :+1:


Replace jaxb-api with jakarta.xml.bind-api

Change dependency to match the one in org.glassfish.jaxb:jaxb-runtime to avoid “overlapping classes” warning

¯\_(ツ)_/¯

There are quite a few dependencies, which depend on both, javax.xml.bind:jaxb-api and org.glassfish.jaxb:jaxb-runtime, for example Hibernate ORM 5.4.4:
https://github.com/hibernate/hibernate-orm/blob/5.4.4/gradle/libraries.gradle#L80-L81
I guess we'll have to live with the overlapping classes warning, until all dependencies have moved to the jakarta.xml.bind prefix.

@joschi - This still seems like a good fix for dropwizard to move its own dependency to the new jakarta jaxb-api (even if third party dependencies aren't able to migrate yet). Clients will still need to add exclusions to avoid overlapping classes.

@pkwarren Would you be able to provide a pull request for this change?

I think this PR can be re-opened and it will fix the issue with JAXB conflicts. I can submit a PR for avoiding the javax.activation issue if that's of interest (the other conflict in #2908).

@joschi - I opened a PR which migrates all dropwizard artifacts to use jakarta apis instead of a mix of jakarta and javax.* ones. PR here: #3069.


Caching seems to not work

I have default settings from gem readme. My uploader looks like
module Uploaders
  module TaxBaseCalculation
    class Xlsx  < CarrierWave::Uploader::Base
      storage :aws

      def store_dir
        "tax_base_calculation/xlsx/user_#{model.order.user_id}/order_#{model.order_id}/calculation_#{model.id}"
      end

      def extension_whitelist
        %w[xlsx]
      end

      def cache_dir
        Rails.root.join 'tmp/uploads'
      end
    end
  end
end

this is how I try to cache file
file.cache_stored_file!
file.retrieve_from_cache!(file.cache_name)

# operation is successful, but there is no file in cache folder:

puts "path: #{file.path}, exists?: #{File.exist?(file.path)}"
# => false

# cache_name and path attributes are correct
file.cache_name
# => "1614070761-355256537201132-0002-4079/73753502-55_Расчет_налоговой_базы.xlsx"

file.path
# => "tmp/uploads/1614070761-355256537201132-0002-4079/73753502-55_Расчет_налоговой_базы.xlsx"

Caching is entirely handled by CarrierWave itself, not carrierwave-aws. Please ask over there or check the past issues.


Add hashicorp/external terraform provider

Adds a provider/parser for hashicorp/external which can be used to execute external programs, exposing the results as values within the template. I did not introduce any associated rules, but an example rule could restricting which external programs are allowed based on a rego rule for the program attribute.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

thanks @lyoung-confluent for your contribution! This is a cool idea. Could you please sign the CLA first?
Once you have that, could we explore some example rego policies that could be used with this adapter? Would love to learn more on what you have in mind.

@simar7 I have signed the CLA, the rego policy I was starting out with was just banning the use of external altogether as the legitimate use-cases for it are pretty rare (it's more commonly abused to get RCE via terraform plan), but I wanted to introduce it as part of the rego input so if there were legitimate use-cases they could be checked against with a more specific rule


Allow GH Actions to access a site via Access policies?

We have a job that deploys to CloudFlare via direct upload, and we're looking to have it also run some end to end tests using the deployed URL after that's finished. We don't want these URLs universally open to the world as they are production like environments that we want to limit access to. Can we set up an Access Policy in Cloudflare that would allow GitHub Actions to access URLs?
https://developers.cloudflare.com/cloudflare-one/policies/access/

@WalshyDev How do I configure the action to send the appropriate headers as indicated in the https://developers.cloudflare.com/cloudflare-one/identity/service-tokens/#connect-your-service-to-access section?

That's a question for whatever you're using for your end to end tests.
They're just HTTP headers, so however you add them into whatever tool.
With curl it's just:
curl -H 'CF-Access-Client-Id: <Client ID>' -H 'CF-Access-Client-Secret: <Client Secret>' https://example.pages.dev/

Oh right, my mistake. Long day :)


Tests only run on Chrome, and only if clicking "DEBUG"

Hi,
I have tried several things to get RocketChat application tests to run on PhantomJS but had no luck so far. I managed to run them on Chrome but with a very strange behavior: jasmine-client-unit only run when I hit "DEBUG" button:

JASMINE_DEBUG=1 VELOCITY_DEBUG=1 velocity test-app --ci

The bottom lines of the logs appear when I hit the debug button "Debug":
I20151009-12:21:32.422(-3)? [publish] settings
I20151009-12:21:32.500(-3)? [publish] permissions
PASSED jasmine-client-unit : App | Client | Lib | SideNav => should exist
I20151009-12:21:32.939(-3)? jasmine-client-unit: 1 tests passed (5ms)
TESTS RAN SUCCESSFULLY
Georges-MacBook:RocketChat gmsecrieru$

I have the feeling that PhantomJS execution is not working for the same reason. Any thoughts on how to bypass this?
Thanks!

Try meteor update sanjo:jasmine. If that doesn't help, please tell me the version of sanjo:jasmine and Meteor that you use.

Hi @Sanjo, thanks for the quick reply!
I've tried updating but no luck. Console output:
Georges-MacBook:RocketChat gmsecrieru$ meteor update sanjo:jasmine
The specified packages are at their latest compatible versions.
Georges-MacBook:RocketChat gmsecrieru$ meteor --version
Meteor <IP_ADDRESS>
Georges-MacBook:RocketChat gmsecrieru$

.meteor/local/log/jasmine-client-unit.log can be seen here
From the bottom lines looks like the context.html file is unavailable:
09 10 2015 12:27:38.544:WARN [karma]: No captured browser, open http://localhost:9876/
09 10 2015 12:27:38.565:INFO [karma]: Karma v0.13.9 server started at http://localhost:9876/
09 10 2015 12:27:38.625:INFO [launcher]: Starting browser Chrome
09 10 2015 12:27:49.413:INFO [Chrome 45.0.2454 (Mac OS X 10.10.5)]: Connected on socket oFtEzJMSOgUdyDubAAAA with id 33539803
09 10 2015 12:27:53.230:WARN [web-server]: 404: /_timesync
Chrome 45.0.2454 (Mac OS X 10.10.5) LOG: 'Error syncing to server time: ', Error{response: Object{statusCode: 404, content: 'NOT FOUND', headers: Object{connection: ..., date: ..., transfer-encoding: ...}, data: null}}

09 10 2015 12:27:54.264:WARN [web-server]: 404: /_timesync
Chrome 45.0.2454 (Mac OS X 10.10.5) LOG: 'Error syncing to server time: ', Error{response: Object{statusCode: 404, content: 'NOT FOUND', headers: Object{connection: ..., date: ..., transfer-encoding: ...}, data: null}}

Chrome 45.0.2454 (Mac OS X 10.10.5) ERROR: 'There is no route for the path:', '/context.html'

09 10 2015 12:27:55.538:WARN [web-server]: 404: /_timesync
Chrome 45.0.2454 (Mac OS X 10.10.5) ERROR
  Uncaught TypeError: ServiceConfiguration.configurations.find is not a function
  at /Users/gmsecrieru/Projects/RocketChat/.meteor/local/build/programs/web.browser/app/client/views/login/services.coffee.js:11

09 10 2015 12:30:17.943:WARN [web-server]: 404: /_timesync
09 10 2015 12:30:19.659:WARN [web-server]: 404: /_timesync
09 10 2015 12:30:20.668:WARN [web-server]: 404: /_timesync
09 10 2015 12:30:21.675:WARN [web-server]: 404: /_timesync
09 10 2015 12:30:22.682:WARN [web-server]: 404: /_timesync
Parent process ( 68409 ) is dead! Exiting jasmine-client-unit

Running<EMAIL_ADDRESS>

I think the breaking error is

Chrome 45.0.2454 (Mac OS X 10.10.5) ERROR
Uncaught TypeError: ServiceConfiguration.configurations.find is not a function
at /Users/gmsecrieru/Projects/RocketChat/.meteor/local/build/programs/web.browser/app/client/views/login/services.coffee.js:11

Can you log what ServiceConfiguration.configurations is at the failing line. It must be something but not a Mongo collection as expected.

To "fix" the routing error, you need to disable your router in client unit mode. If you tell me what router you use, I can eventually do this by default. Currently I only handle this for iron:router.

Thanks again!  We are using Flow Router.
I will look for the ServiceConfiguration.configurations, might be something that needs to be initialized somewhere else.

I commented out that piece of code and indeed it was the problem, as now I can run test with both Chrome and PhantomJS:
Chrome

PhantomJS

Thanks for your time!


local.conf.sample: Add SUPERVISOR_TAG

We need this entry so barys can sed the value based on supervisor tag
argument.
[Issue #3]
Signed-off-by: Andrei Gherzan<EMAIL_ADDRESS>CC @floion @telphan @pcarranzav

LGTM


Please add to wiki - adding to an existing app

Hi
Please add to the wiki instructions on how to start using devise on apps that already have implemented an authentication system (from scratch like in railscasts, or using other gems)
Thanks

The wikis are maintained by the community. We focus our efforts on fixing bugs in the plugin. If you are stucked at some point, please try to get some help in the mailing list.


Python 3.9 does not recognize sympy.

Description
What steps will reproduce the problem?

Following the directions in the link
https://github.com/spyder-ide/spyder/issues/14218#event-4014068160
And running Sypder from terminal I am getting:
import sympy
Traceback (most recent call last):
File "", line 1, in
import sympy
ModuleNotFoundError: No module named 'sympy'
Traceback
  File "/Users/saarhersonsky/opt/anaconda3/envs/spyder-dev/lib/python3.9/site-packages/spyder/plugins/completion/snippets/actor.py", line 92, in handle_msg
    if language_snippets[current_word]:
  File "/Users/saarhersonsky/opt/anaconda3/envs/spyder-dev/lib/python3.9/site-packages/spyder/plugins/completion/snippets/trie.py", line 81, in __getitem__
    if len(sequence) == 0:
TypeError: object of type 'NoneType' has no len()

Versions

Spyder version: 4.2.0
Python version: 3.9.1
Qt version: 5.12.9
PyQt5 version: 5.12.3
Operating System: Darwin 20.2.0

Dependencies

# Mandatory:
applaunchservices >=0.1.7       :  0.2.1 (OK)
atomicwrites >=1.2.0            :  1.4.0 (OK)
chardet >=2.0.0                 :  4.0.0 (OK)
cloudpickle >=0.5.0             :  1.6.0 (OK)
diff_match_patch >=20181111     :  20200713 (OK)
intervaltree >=3.0.2            :  3.0.2 (OK)
IPython >=4.0                   :  7.19.0 (OK)
jedi =0.17.2                    :  0.17.2 (OK)
jsonschema >=3.2.0              :  3.2.0 (OK)
nbconvert >=4.0                 :  6.0.7 (OK)
numpydoc >=0.6.0                :  1.1.0 (OK)
parso =0.7.0                    :  0.7.0 (OK)
pexpect >=4.4.0                 :  4.8.0 (OK)
pickleshare >=0.4               :  0.7.5 (OK)
psutil >=5.3                    :  5.8.0 (OK)
pygments >=2.0                  :  2.7.4 (OK)
pylint >=1.0                    :  2.6.0 (OK)
pyls >=0.36.1;<1.0.0            :  0.36.2 (OK)
pyls_black >=0.4.6              :  0.4.6 (OK)
pyls_spyder >=0.1.1             :  0.3.0 (OK)
qdarkstyle >=2.8                :  2.8.1 (OK)
qtawesome >=0.5.7               :  1.0.2 (OK)
qtconsole >=4.7.7               :  5.0.1 (OK)
qtpy >=1.5.0                    :  1.9.0 (OK)
rtree >=0.8.3                   :  0.9.7 (OK)
setuptools >=39.0.0             :  49.6.0.post20210108 (OK)
sphinx >=0.6.6                  :  3.4.3 (OK)
spyder_kernels >=1.10.0;<1.11.0 :  1.10.1 (OK)
three_merge >=0.1.1             :  0.1.1 (OK)
watchdog >=0.10.3               :  1.0.2 (OK)
zmq >=17                        :  21.0.1 (OK)

# Optional:
cython >=0.21                   :  None (NOK)
matplotlib >=2.0.0              :  None (NOK)
numpy >=1.7                     :  None (NOK)
pandas >=1.1.1                  :  None (NOK)
scipy >=0.17.0                  :  None (NOK)
sympy >=0.7.3                   :  None (NOK)

Sympy's supported version doesn't include python 3.9.  Perhaps that is the issue

Sympy's supported version doesn't include python 3.9.  Perhaps that is the issue

Hey @SaarHersonsky, thanks for reporting. I think the only way to use Spyder in Big Sur right now is by using our installer. So please download and install it, and let us know if things work for you (it comes with Sympy).
Unfortunately, people have reported mixed success with Conda/Conda-forge: for some it works and for other it doesn't.

Hey @SaarHersonsky, thanks for reporting. I think the only way to use Spyder in Big Sur right now is by using our installer. So please download and install it, and let us know if things work for you (it comes with Sympy).
Unfortunately, people have reported mixed success with Conda/Conda-forge: for some it works and for other it doesn't.

@SaarHersonsky , It looks like sympy is not installed on your system. Are you unable to install it? Otherwise I agree with @ccordoba12: try using our installer. I have confirmed that it works on macOS 11.1 and sympy imports from a Spyder terminal.

@SaarHersonsky , It looks like sympy is not installed on your system. Are you unable to install it? Otherwise I agree with @ccordoba12: try using our installer. I have confirmed that it works on macOS 11.1 and sympy imports from a Spyder terminal.

Closing due to lack of response.

Closing due to lack of response.


Journal before trie

What was wrong?
Right now, when an account changes multiple times within a transaction, then we:

waste time calculating keccak on intermediate state
waste time doing trie manipulation on intermediate state
store unnecessary data for intermediate account values

How was it fixed?

Journal the raw account values, before entering them into the trie.
Replaced values get dropped in the journal, in between calling persist, so they never hit the trie

Right now, this will save state at every persist call. We can do even better, saving it only at the end of every block, but this PR was getting full.
Side note: The account cache started returning stale results, because the state_root is no longer updated at every change. I tried to fix it in place, with a sprinkling of cache invalidations, but it was taking too long to hunt down all the bugs, so I wrote a simpler CacheDB instead. It works, but I'm not sure of the performance impact yet.
Plus a little unrelated VM refactor for creating state more succinctly.
Edit: probably need some more persists in there somewhere... Will come back to it after some reviews
Cute Animal Picture

I wanted to be really sure that it wasn't the little refactor that broke it... and it was: https://github.com/ethereum/py-evm/pull/680


Replaced "if" statements with functions

A ReactionManager is feasible, but not realistic for a project of this size. I think that simple ifs/elses suffice for this bot.


RECAPTCHA_TESTING should be a django settings

I think that is better define this variable in a django settings, if you use differente settings for production, develop, test is a bit more trasnparent declare in django setttings..

Yes and tests can change it with @override_settings rather than adding custom logic in setUp()/tearDown()

Guys, I'm sorry, but how exactly have you addressed this issue? I can't see any unittest dedicated setting available, but the environment variable is gone. So what is the recommended approach to mock recaptcha field during tests?

Also wondering how we are meant to test a v3 recaptcha form. A test mode setting would be nice, and if this is present but not documented, a hint in the docs would be nice (they mention only that v2 supports test keys).


ACCUMULO-2182 Fixed dependencies to get build working again

I tested monitor locally with uno and everything still works.  Ran mvn verify in monitor module but didn't run full build.

Automated build for this PR: https://travis-ci.org/mikewalch/accumulo/builds/219020222

Thanks, merging in.


Regarding compiling with earlier version of g++ /C++

Hi , I try to compile my C++  code that load tensorflow modle with functions from cppflow library.  This code perefectly loaded model and make prediction. But later , when I integrate this code compiled with -std=c++17 9, g++ 9.0 with aother C++ project wirtten in C++11 compiled with  older g++ (4.8) ,  the compilation failed.
Is there a way I can use my code that uses Cppflow library and written in C++17  and g++ 9.0   inside   a code C++11 9  compiled  in g++4.8 ?
C++17 is a strict requirment for CPPflow ?

I am not planing to make the code compatible with previous c++ standards. But you can take a look to #108 or other issues about the topic. There shouldn't be many changes to do.


Consistent error handling

Sometimes we throw errors, sometimes we do process.exit() (which we shouldn't do in library classes). there should be a consistent way to handle user errors vs. application errrors.

What's the definition of a library in this case? Is an single command like qxcli/commands/Create a library or not?
Where to handle the exit in this case? Throw an exception in all places where we now have an this.exit?
And handle this in the handler with showing and process.exit(1)?
What's about shorthand process.exit(0) in publish? Throw a special exception which will end process with error Code 0?
Or allow this.exit in the command code  because it's not a real library? Then we should rework the usage of process.exit to this.exit.

Good questions... I guess any method that can be used "from outside" as an API method should never simply exit - since it's the expectation of an API method to either return a value or throw. In any other method, for example those used by yargs, we can exit() in a controlled way.

OK, i prepared some cleanups. Will do a PR as soon as https://github.com/qooxdoo/qooxdoo-cli/pull/60 is merged.
This avoid conflicts.


Changes to dhw and wave logs to store scenario and site means and stds

Closes #619

I think this is ready for final review @Zapiano, tests all passing on my end


Dependencies missing in Azure but are show in Debug window

NETCore 3.1 web api with
<PackageReference Include="Microsoft.ApplicationInsights.AspNetCore" Version="2.16.0" />
and on Startup.cs
services.AddApplicationInsightsTelemetry();
Have a simple Controller with an endoint with the following code:
var startTime = DateTime.UtcNow;
var timer = System.Diagnostics.Stopwatch.StartNew();

var httpClient = new HttpClient
{
    BaseAddress = new Uri("https://www.google.com")
};
await httpClient.GetAsync("/");

_telemetryClient.TrackDependency("HTTP", "HttpClient", "https://www.google.com", startTime, timer.Elapsed, true);

_telemetryClient.Flush();

Requests and Traces/logs show up on Application Insights Search blade on Azure Portal and also Metrics on their own blade.
Automatic dependency tracking or manual dependency tracking shows up locally on VS in the Debug Console but never on Azure.
Application Insights Telemetry: {"name":"AppRequests", ...
Application Insights Telemetry: {"name":"AppDependencies",...
Seems something really simple might be missing but it should work out of the box as HttpClient is an automatically tracked dependency but even the manual code above doesn't show up (with the manual tracking, on VS Debug Console I get the auto dependency tracking message and also the manual one).

I just had a similar issue, and I believe it's due to a version mismatch between 2.14 and 2.16 of Microsoft.ApplicationInsights package.
Azure Functions core tools comes with 2.14, and my projects were using 2.16.
If I debugged into it, looking at the TelemetryClient was showing me a package version mismatch.
By backdating my packages to 2.14, now I can see a valid TelemetryClient.

Since you mentioned Fuctions, I also happen to have a Functions project and when integration with Applications Insights I had the mismatch you mentioned (had to downgrade to 2.14) plus all the changes I make to the injected TelemetryConfiguration are ignored (can't change app version, component name, etc). But it's a problem for another time 😄 as I have given up on everything but logging for the moment.
Still, the problem persists on the NETCore API I mention above (no version mismatch warnings + can successfully set the version, cloud role name, etc).


Don't use recursive main loops for the dialogs

Recursive main loops can cause interesting reentrancy issues with e.g.
mutexes or refcells and are generally not a good idea.
See also https://github.com/gtk-rs/gtk/issues/952.

CC @sprang

This is a super weird bug...

This is a super weird bug...

Well, this PR is a good idea regardless of the bug :)

Indeed. I'll merge it once CI passed.

@GuillaumeGomez green now :)

Merged now. :)


From implementations

From, From<[T; N]> and From<[T]> might be nice

Also conversions between ringbuffer types


RawCombinedQueryDefinition does not have setCriteria and withCriteria

The RawCombinedQueryDefinition  type does have setCriteria and withCriteria methods.

I must have mis-spoken when I said it should.  The original intent of #63 was to allow use of StructuredQueryBuilder plus a string query without requiring use of RawCombinedQueryDefinition which could always combine a structured query with a string query.  So while it wouldn't hurt to add setCriteria and withCriteria to RawCombinedQueryDefinition, I'm not sure it would actually help.  So let's not worry about adding it if it's not needed.


:lipstick: (ui) update add documents to main navigation

relevant to #138 & #139

Update the UI to make it fit with the Spree 4 interface and also keep the interface for the earlier version.

move to #143


Resolve the issues reported in #110 with bad reporting of errors

Fixes #110
Errors were reported in the wrong order confusing IDE JUnit runners

@ashleyfrieze looks great to me. If you confirmed that it gets the right IDE behavior, I'm ready to merge. 👍
Also has nice side effect, as you mentioned, of starting to isolate us incrementally away from the JUnit4 RunNotifier API.

I'm pretty happy with this. Can you release it too? I feel bad that the general release has this howler in it?


Add macOS 13 Ventura to compatibility list

Proposal to address https://github.com/AgnostiqHQ/covalent/issues/1590

[ ] I have added the tests to cover my changes.
[ ] I have updated the documentation and CHANGELOG accordingly.
[x] I have read the CONTRIBUTING document.

I didn't bump the version number; would you like me to do that for minor doc fixes as well?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@RCdeWit Appreciate the contribution and was great meeting you :) You won't need to bump the version manually, it will be done by our Github workflow


How to solve when the npm start, the ip is not localhost, and can not access the view?

Compiled successfully!
You can now view my-app in the browser.
http://x86_64-apple-darwin13.4.0:3000
Note that the development build is not optimized.
To create a production build, use npm run build.
Mac OS
node: v14.9.0
npm: 6.14.7

I have the same problem!
I have tried deleting node_modules and doing nom install --> it didn't help.
I uninstalled node and reinstalled it --> didn't help
Would appreciate suggestions.

Same problem for me
Compiled successfully!
You can now view my-app in the browser.
http://x86_64-apple-darwin13.4.0:3000
Note that the development build is not optimized.
To create a production build, use yarn build.
but it work on another mac with same catalina 10.15.6 ...
this is so wire

Met the same problem on MacOS Catalina 10.15.6

Found the solution at https://medium.com/@choy/fixing-create-react-app-when-npm-fails-to-start-because-your-host-environment-variable-is-being-4c8a9fa0b461:

Add "export HOST=localhost" to ~/.bash_profile
source ~/.bash_profile

unset HOST worked for me!

Found the solution at https://medium.com/@choy/fixing-create-react-app-when-npm-fails-to-start-because-your-host-environment-variable-is-being-4c8a9fa0b461:

Add "export HOST=localhost" to ~/.bash_profile
source ~/.bash_profile

I have solved the problem based on this answer. Thanks a lot!

typing unset HOST in the cmd line worked for me!

The best way

Same problem.
Mark

typing unset HOST in the cmd line worked for me!

It works for me! Thank you


Update the docs: For the S3 integration to work the IAM user also needs "DeleteObject" permission

I followed the instructions for the AWS S3 Integration, which also includes a wrapper to delete files from S3 when Images.remove() is called. When trying this out s3.deleteObject throws AccessDenied.
To make this work the IAM user additionally needs the DeleteObject permission (which is not set in the linked example on how to set up AWS S3). So the adapted policy would be:
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Effect": "Allow",
            "Action": [
                "s3:PutObject",
                "s3:GetObjectAcl",
                "s3:GetObject",
                "s3:DeleteObject",
                "s3:PutObjectAcl"
            ],
            "Resource": [
                "arn:aws:s3:::BUCKETNAME",
                "arn:aws:s3:::BUCKETNAME/*"
            ]
        }
    ]
}

Only "s3:DeleteObject", was added.
Does anyone see any security implications with this?

@tschneid would you mind to open a PR with updated instructions?

Merged via https://github.com/VeliovGroup/Meteor-Files/pull/689 feel free to reopen if there remains anything related to this issue.


add warnings in warnings layer

on conflict (ignored shade or relations) an element should be created in the warnings layer

https://github.com/ElektraInitiative/PermaplanT/issues/485#issue-1764757699

on conflict (ignored shade or relations) an element should be created in the warnings layer

@markus2330
I've just talked over this issue with @absurd-turtle . Technically, the communication between the layers should work through the tracked store. However, both of us were uncertain if we share the same understanding of the use case. Therefore, it would be useful to schedule a separate call where you could briefly showcase your ideas once more.

@markus2330 I have included my thoughts on what is needed from the backend in the description


Npm task for publishing to the market place

Just use https://github.com/JetBrains/hub-pub

Obsolete.


org rename

task: https://github.com/stolostron/backlog/issues/18746
Signed-off-by: Zhiwei Yin<EMAIL_ADDRESS>

/lgtm


Change Bintray URL to Sonarsource URL

SonarSource team changed the download site from Bintray to their own site (sonarsource.com).
Change in this pull request:

Change download URL from https://sonarsource.bintray.com to https://binaries.sonarsource.com

Reference:

https://community.sonarsource.com/t/download-site-has-changed/3176

@newtmitch No problem :)


Consider archiving the repo

Given that SCOTT is over and we are not planning to maintain the code here mostly, shall we either archive the repo or at least disable security scanning and add a note to the README that the project is no longer maintained (the only reason is in case someone will try to open a ticket).

@likelion @swarupmohalik @albertohata what's your thought

@berezovskyi We have two master students that are still using this repo, but are intended to conclude their work on January/February. Is it possible to do that after they finishing their work?

@albertohata what's the status?

Hi @berezovskyi, we recently started using the gitlab so we can archive the repo.


Adding option to set layout

The option to set fzf_layout is missing. Unable to use fzf_layout = { 'down' : '30%' } to get the fzf window down rather than in the middle.
Is it there and I am missing something?
If not, please add that support.
My configuration is -
-- Lsp fuzzy seach setup

local g = vim.g
local map = vim.api.nvim_set_keymap

require('lspfuzzy').setup {
  methods = 'all',         -- either 'all' or a list of LSP methods (see below)
  fzf_layout = 'down:30%',
  fzf_preview = {          -- arguments to the FZF '--preview-window' option
    'right:+{2}-/2'          -- preview on the right and centered on entry
  },
  fzf_action = {           -- FZF actions
    ['ctrl-t'] = 'tabedit',  -- go to location in a new tab
    ['ctrl-v'] = 'vsplit',   -- go to location in a vertical split
    ['ctrl-x'] = 'split',    -- go to location in a horizontal split
  },
  fzf_modifier = ':~:.',   -- format FZF entries, see |filename-modifiers|
  fzf_trim = true,         -- trim FZF entries
}

map('n', '<A-g>', ':GFiles<cr>', {})
map('n', '<A-p>', ':Files<cr>', {})

I have added the option for layout as down but still the window is coming as floating window in the center.

Hello !
As mentioned in the README.md, the plugin will respect your FZF config. So just put let g:fzf_layout = {'down': '30%'} in your .vimrc or g['fzf_layout'] = {down = '30%'} in Lua and you should be good.
For the fzf_action and fzf_preview options I'm not using the default values of FZF that's why they can be configured in the plugin, but for the others the plugin will follow either your own FZF settings or the FZF default.
Feel free to re-open this if you have further issues.


Update to database-logs/move-rds-logs-to-s3/rds-logs-to-s3.py to acccount for log files larger than 1 MB

*Issue #70
*Description of changes:
Added code to address issues found where RDS log file sizes are greater than 1 MB and audit requirements for archiving logs

Handles RDS log files > 1 MB in size
Handles Log file portions > 1 MB in size - by reducing NumberOfLines so db_log_file_portion < 1 MB
Handles an edge case where logs get rotated as the log file is being downloaded
Handles API throttling with geometric back off
Creates an audit record of the program activity

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This PR seems to fix the issue, though perhaps it hasn't been merged because there's kind of a lot going on. Can the maintainer comment about any next steps here? Even if this rendition isn't merged, it seems prudent that the script be updated with this recursion logic so that logs with long lines aren't mysteriously exported with data missing.


Appstudio update test-custom-default-branch-rjzh

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-annotations-yvpd-on-pull-request-
creating pipelinerun test-annotations-yvpd-on-pull-request- in namespace build-e2e-kjjv-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-kqtd-on-pull-request-
creating pipelinerun test-simple-build-kqtd-on-pull-request- in namespace build-e2e-kjjv-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-annotations-mwia-on-pull-request-
creating pipelinerun test-annotations-mwia-on-pull-request- in namespace build-e2e-kjjv-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-annotations-wyqr-on-pull-request-
creating pipelinerun test-annotations-wyqr-on-pull-request- in namespace build-e2e-kjjv-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-sorp-on-pull-request-
creating pipelinerun test-simple-build-sorp-on-pull-request- in namespace build-e2e-kjjv-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request


429 Client Error: Too Many Requests for url: https://archive.md/

This has never worked for me, I always get 429 error
Running from within Python:
>>> import archiveis
>>> archive_url = archiveis.capture("http://www.example.com/")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/username/.local/share/virtualenvs/username-nbgasrwQ/lib/python3.8/site-packages/archiveis/api.py", line 39, in capture
    response.raise_for_status()
  File "/home/username/.local/share/virtualenvs/username-nbgasrwQ/lib/python3.8/site-packages/requests/models.py", line 953, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 429 Client Error: Too Many Requests for url: https://archive.md/

Running command-line:
$ archiveis https://google.com/
Traceback (most recent call last):
  File "./.local/share/virtualenvs/google-JUflU5ax/bin/archiveis", line 8, in <module>
    sys.exit(cli())
  File "/home/username/.local/share/virtualenvs/google-JUflU5ax/lib/python3.8/site-packages/click/core.py", line 1137, in __call__
    return self.main(*args, **kwargs)
  File "/home/username/.local/share/virtualenvs/google-JUflU5ax/lib/python3.8/site-packages/click/core.py", line 1062, in main
    rv = self.invoke(ctx)
  File "/home/username/.local/share/virtualenvs/google-JUflU5ax/lib/python3.8/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/username/.local/share/virtualenvs/google-JUflU5ax/lib/python3.8/site-packages/click/core.py", line 763, in invoke
    return __callback(*args, **kwargs)
  File "/home/username/.local/share/virtualenvs/google-JUflU5ax/lib/python3.8/site-packages/archiveis/api.py", line 106, in cli
    archive_url = capture(url, **kwargs)
  File "/home/username/.local/share/virtualenvs/google-JUflU5ax/lib/python3.8/site-packages/archiveis/api.py", line 39, in capture
    response.raise_for_status()
  File "/home/username/.local/share/virtualenvs/google-JUflU5ax/lib/python3.8/site-packages/requests/models.py", line 953, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 429 Client Error: Too Many Requests for url: https://archive.md/

Confirmed. Same here.
Except the domain atm is archive.is.

Looking at the response that comes back it appears that it is getting caught by a CAPTCHA. Unsure what the proper way to deal with this is.

I was getting 429's also.
What you can do to fix this is to try some different user agent strings. I switched mine to be Firefox on Linux and it worked:
The command-line program comes bundled with a -ua flag or --user-agent to change it.
archiveis -ua "Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20100101 Firefox/10.0" https://google.com
https://archive.md/wip/VBqdJ

Looking at the response that comes back it appears that it is getting caught by a CAPTCHA. Unsure what the proper way to deal with this is.

I think once you hit that captcha you're pretty much just stuck.  I've tried in browser automation libraries like Playwright to do obvious things like click the captcha checkbox to no avail.
Like the comment above said, choosing a real user-agent probably helps.
Besides that, I think that their rate limiting is fairly IP based, so if you are able to distribute your requests across IPs that may help.
I have also noticed that they throttle me way more aggressively when using Cloudflare <IP_ADDRESS> or Warp.  This may likely apply to other VPNs as well, but I haven't tested personally.
It would be nice to wrap up this project with a queuing system using the submissions as jobs and having automatic retries to make it more robust / act like a "service".  I haven't seen anyone doing exactly that yet.
I have also noticed that, while infrequent, there are definitely some pages which seem to crash the archive.is archiver and never succeed in being archived.  Not sure if there's a way to report that to them.

I saw in another similar package how they solved it: They downloaded a clearance cookies after manually entering the site once. This cookies was then stored as a system variable. Maybe also a solution here?


How to change the format depth.npy to depth.png

PNG sacrifices precision; hence it's not stored that way.


chore(main): release 1.4.1

:robot: I have created a release beep boop
1.4.1 (2024-12-29)
Bug Fixes

clippy warnings (c7297de)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.4.1
:sunflower:


module request: virtualisation -- ESXi image, guest support

ESXi Virtualisation Support
There are currently plenty of virtualisation modules for both images and guests.
ESXi is not among those provided.
While VMWare images ought to work, from what I've found, ESXi is known to be notoriously picky when it comes to OVA/OVF imports.

I posted a bit more on the issue on Discourse.
My current workflow is a complicated mess that involves importing nixos-generators, generating a VirtualBox image, extracting the generated OVA, modifying the OVF definition, re-calculating the hashes in the mf file, and re-packaging the OVA.
While the edits that I am doing to the OVA could potentially be improved by applications like cot (see also: https://github.com/glennmatthews/cot/issues/80), it would be nice to eventually see some of these changes make it upstream.

My current approach is so hacky that I'm not sure it would be a welcome addition in its current state.
I'm open to ideas, but I'm hoping to eventually be able to run e.g. nixos-generate -f esxi without all hacks I currently have to maintain.

I am interested in this feature.
I recently had to generate an Image for ESXi image from a flake and went with specifying
  imports = [
    (modulesPath + "/virtualisation/vmware-image.nix") {
      vmware.baseImageSize = ...;
    }
  ];

in my system configuration and then generating it with
nix build .#nixosConfigurations.[system-name].config.system.build.vmwareImage

without using nixos-generators. (I did not get nixos-generators to work on my machine.)
Generating an OVA image would have been a better option for me, because that would have additionally included the hardware configuration, while I only got the disk image.
Right now I would have to import modulesPath + "/virtualisation/virtualbox-image.nix" to get system.build.virtualBoxOVA, but that image would then have
virtualisation.virtualbox.guest.enable = true;

and not
virtualisation.vmware.guest.enable = true;

and it would still require the changes you mentioned on top of that to be useful in ESXi, and I would imagine it would be useful to have more conformant images for VMware Workstation as well.
I think ideally system.build.virtualBoxOVA and system.build.vmwareOVA would both use the code inside virtualbox-image.nix to generate the image, but could be configured independently of each other. but I'm not sure.

Just chiming in to also express interest in this feature!

I've had success in modifying the virtualbox-image.nix by replacing SATA with SCSI -- I plan on making it more generic and opening a PR in a bit

Hey, I would love to have this as well.
It's currently a big chore to generate images.


Servers with Encryption and XBOX disabled...

I will probably add this feature later because most servers use encryption and XBOX authentication

I may have solved the problem. It needs a comprehensive test
Commit 6a2ee36


upgrade of build tools, gradle wrapper, sdk

You will need to update the travis configuration as well.
BTW, any particular reason to upgrade?

No, it's just to be up to date

@poisdeux I think this should be closed, but we should try to update the Gradle version. Does the issue still occurs with newer versions?

Sorry, totally forgot about this one. Seems to be running fine now with 3.4 of the android gradle plugin.
See #640


Request: add faqcodes.com to the filter

Evidence: https://www.faqcodes.com/faq/625211/how-to-convert-a-struct-field-in-a-row-to-an-avro-record-in-spark-java
Original: https://stackoverflow.com/questions/63925187/how-to-convert-a-struct-field-in-a-row-to-an-avro-record-in-spark-java

Thanks a lot!


⚠ AGEG website (prod) has degraded performance

In 0e416de, AGEG website (prod) (https://www.ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 5922 ms

Resolved: AGEG website (prod) performance has improved in c5fbb96.


Update CONTRIBUTING.md

Updated PR policy per discussion w @shripad, now we require an issue to be opened first so we can track what is already in flight and minimize collisions.

@canturkisci: travis fails since it is expecting only signed commits git commit -s


feat(biome_js_analyze): noExclusiveTests

Summary

Fixes #597
Test Plan

@chansuke
I think the rule was implemented in #1864. It had some coordination issues... You could improve the implementation of the existing rule if possible.

noFocusedTests covers fit and fdscribe method and can I update noFocusedTests to only covers only method like below?

Yes :)

I've created new PR https://github.com/biomejs/biome/pull/1999
close this branch :bow:


Installation documentation improvements

I added some readme.md text to the screenshot manual.

All is well.

Relates to #30
Can someone review my changes?

All is well.

All is well.


Chris Feedback for Hazard Analysis

[ ] Minor spelling/grammar issues. E.g. "log in" vs "login", "third-party" vs "third party" (when it's a noun there's no hyphen).
[ ] Assuming that the users will not try to purposely hack the system is not a very strong assumption. Which components of the system are you trying to mitigate risks for?
[ ] What about people hacking into the system/database itself? This could expose users' purchase data. How will you mitigate this? And a related sidenote: will you have a policy not to share this data with other companies? Or will this possibility be in a user agreement?
[ ] I wonder if you can cache data in the case where the internet is down. I think some grocery stores for instance have buildings that block access to data services, so it's not guaranteed they will have an internet connection when they're there. For HA2: backups should be part of the strategy to mitigate this. What about stronger auth? Like biometric authentication on their phone, or two-factor authentication? HB2: shouldn't we also offer to allow manual entry in case they still can't take a photo? Or else you need to assume that their camera isn't broken.

@allanfang1 @r-yeh @allanfang1 any thoughts on this?
Assuming that the users will not try to purposely hack the system is not a very strong assumption. Which components of the system are you trying to mitigate risks for?

for
What about people hacking into the system/database itself? This could expose users' purchase data. How will you mitigate this? And a related sidenote: will you have a policy not to share this data with other companies? Or will this possibility be in a user agreement?
talk abt how we are encapsulating DB and Node in the same Azure virtual network so the DB can only be accessed through the node endpoint or the Azure terminal.

Bring up in meeting:
I wonder if you can cache data in the case where the internet is down. I think some grocery stores for instance have buildings that block access to data services, so it's not guaranteed they will have an internet connection when they're there. For
HA2: backups should be part of the strategy to mitigate this. What about stronger auth? Like biometric authentication on their phone, or two-factor authentication?
HB2: shouldn't we also offer to allow manual entry in case they still can't take a photo? Or else you need to assume that their camera isn't broken.

https://github.com/r-yeh/grocery-spending-tracker/issues/157
https://github.com/r-yeh/grocery-spending-tracker/issues/160


✨ Enhancement: Redesign "Leave Comment" Section on Leading Blog Page

Description:
On the Leading Blog page, the "Leave Comment" section currently takes up too much space, which negatively affects the overall layout and user experience. I propose a minimal UI redesign to make it more compact and space-efficient. I would like to contribute by implementing this improved design.

@ANSHIKA-26 Assign this task so i can start working on


[Bug] Uploading ZIP file, 'cancel button' does not cancel the action.

It just keeps going.

Fixed with 3.4.0


Fails to import from esm.sh

The plugin fails to import from "https://esm.sh/solid-js/web". It works from<EMAIL_ADDRESS>[ERROR] No matching export in "esbuild_serve:http-import:https://esm.sh/solid-js/web" for import "template"

    public/index.js:6:9:
      6 │ import { template as _$template } from "https://esm.sh/solid-js/web";
        ╵          ~~~~~~~~

error: Uncaught Error: Build failed with 1 error:
public/index.js:6:9: ERROR: No matching export in "esbuild_serve:http-import:https://esm.sh/solid-js/web" for import "template"
  let error = new Error(`${text}${summary}`);
              ^
    at failureErrorWithLog (https://deno.land/x/esbuild@v0.15.13/mod.js:1546:15)
    at https://deno.land/x/esbuild@v0.15.13/mod.js:1004:28
    at runOnEndCallbacks (https://deno.land/x/esbuild@v0.15.13/mod.js:1418:61)
    at buildResponseToResult (https://deno.land/x/esbuild@v0.15.13/mod.js:1002:7)
    at https://deno.land/x/esbuild@v0.15.13/mod.js:1114:14
    at responseCallbacks.<computed> (https://deno.land/x/esbuild@v0.15.13/mod.js:651:9)
    at handleIncomingPacket (https://deno.land/x/esbuild@v0.15.13/mod.js:706:9)
    at readFromStdout (https://deno.land/x/esbuild@v0.15.13/mod.js:627:7)
    at https://deno.land/x/esbuild@v0.15.13/mod.js:1828:11
    at eventLoopTick (ext:core/01_core.js:166:11)

Sometimes esm.sh is flaky? does this import work under deno itself?

Actually I think I know why.
https://github.com/lucsoft/esbuild_serve/blob/main/features/httpImports.ts#LL66C13-L69C27
It can't chose an appropriate loader because there isn't a file extension.

It will fetch depending on the content type, im pretty sure esm.sh will deliver it correctly. Personally i had also some issue with esm.sh lately

I tried using the latest version of esbuild_serve and your import works. I'm going to try later if i can reproduce it further.
You could check if it works for you currently: https://raw.githubusercontent.com/lucsoft/esbuild_serve/85c36afc2e1ba34b055adc2b1f3d436e5d847beb/features/httpImports.ts
It's the latest version

Actually I think I know why. https://github.com/lucsoft/esbuild_serve/blob/main/features/httpImports.ts#LL66C13-L69C27 It can't chose an appropriate loader because there isn't a file extension.

check the content-type header instead

It will fetch depending on the content type, im pretty sure esm.sh will deliver it correctly. Personally i had also some issue with esm.sh lately

what's your issue? i'm glad to fix 🙏

It will fetch depending on the content type, im pretty sure esm.sh will deliver it correctly. Personally i had also some issue with esm.sh lately

what's your issue? i'm glad to fix 🙏

Oh great to see you :D. Pretty sure the problem was with the npm package mjml-browser which had the issue that the default import was missing. im not sure if its fixed already

Looks like the fix is appending ?target=esnext to the url. Makes sense, as otherwise esm.sh is targetting Deno. I wonder if there is a way to set the UserAgent header to something that would automatically grab things in esnext format. I don't know if it makes sense as a default though.

im pretty sure your cache just stored an bad import. you could also do ?foo and it should have fixed your problem

@lucsoft seems it works for me

So yeah can't really reproduce the issue.


How to use appSetId with Amplitude Kotlin

Summary
My understanding was that in order to use appSetId I just need to
implement "com.google.android.gms:play-services-appset:${versions.google.appSet}" in gradle and when initialising Amplitude to use useAppSetIdForDeviceId = true.
However, as per my other issue, this seems to cause a crash with Amplitude Kotlin 1.1.3 and for 1.1.2 I don't appear to get any events logged against user ids.
Is there a step that I'm missing?

Hi @barry-irvine the understanding is correct, I am submitting a PR to fix the other issue you mentioned. Will let you know once that is released.


[Search v1] Report screen in RHP is removed from navigation history after navigating to the chat in CentralPane

Details

This PR fixes removing ReportScreen in RHP from the navigation state after navigating to the chat in CentralPane.
Fixed Issues

$ https://github.com/Expensify/App/issues/43918
PROPOSAL:
Tests

[ ] Verify that no errors appear in the JS console

Open Search page.
Open any report in RHP.
Navigate to the chat in CentralPane.
Go back.
Verify that ReportScreen in RHP is opened after navigating back.

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/47774969/f4e097f0-8cf2-4b01-87e0-e98a3950b67b

Android: mWeb Chrome

https://github.com/Expensify/App/assets/47774969/b56f642f-b127-41b3-b08b-3493134e8010

iOS: Native

https://github.com/Expensify/App/assets/47774969/bd7f898d-5a9c-41a6-b38c-505df6ab5b55

iOS: mWeb Safari

https://github.com/Expensify/App/assets/47774969/0073426a-cc15-4d72-afc1-e20089c66fac

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/47774969/ecdfa8b1-4e90-4eeb-942d-3e5bf34fcdf2

MacOS: Desktop

https://github.com/Expensify/App/assets/47774969/061e042f-291b-4205-ada1-5e17d9600b3a

LGTM! 🎸

@parasharrajat It's possible that this PR will fix it https://github.com/Expensify/App/pull/43998#issuecomment-2179250066

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.1-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.1-19 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


.NET 8

this project does not work under .NET 8
please upgrade

This was done for a blog post a long time ago and I don't have any plans to update it.


mbuffer: 20210209 -> 20210328

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/mbuffer/versions.
meta.description for mbuffer is: "A tool for buffering data streams with a large set of unique features"
meta.homepage for mbuffer is: "http://www.maier-komor.de/mbuffer.html"
meta.changelog for mbuffer is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/52z249f6s4dk7g6hvpci60z3wbrjwg8r-mbuffer-20210328/bin/mbuffer passed the binary check.

1 of 1 passed binary check by having a zero exit code.

0 of 1 passed binary check by having the new version present in output.

found 20210328 with grep in /nix/store/52z249f6s4dk7g6hvpci60z3wbrjwg8r-mbuffer-20210328

found 20210328 in filename of file in /nix/store/52z249f6s4dk7g6hvpci60z3wbrjwg8r-mbuffer-20210328

directory tree listing: https://gist.github.com/b3e43bce3b55ccff5980be1322493bd5

du listing: https://gist.github.com/7a590bf4a2f59eb9a61d5723e84eac99

Rebuild report (if merged into master) (click to expand)

11 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
3 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
3 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
btrbk
mbuffer
sanoid

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/52z249f6s4dk7g6hvpci60z3wbrjwg8r-mbuffer-20210328 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A mbuffer https://github.com/r-ryantm/nixpkgs/archive/9cf6b9d681ba6f1afc181c16720692ad72d0891c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/52z249f6s4dk7g6hvpci60z3wbrjwg8r-mbuffer-20210328
ls -la /nix/store/52z249f6s4dk7g6hvpci60z3wbrjwg8r-mbuffer-20210328/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

btrbk
mbuffer
sanoid

Maintainer pings
cc @tokudan for testing.

Result of nixpkgs-review pr 124290 at 9cf6b9d6 run on aarch64-linux 1

3 packages built successfully:

btrbk
mbuffer
sanoid


Installing specific extension version from the command line doesn't stop auto-update

Testing #131409
Installing a specific extension version from the UI, caused the auto-update of that extension to be blocked, but that doesn't happen when installed via the command line. After installing from the CLI, once you open VS Code it will auto-update the extension to the latest version.

+1

/duplicate


AWS - tag nodes with IAM role that created it

If possible, include the IAM  id responsible for creating any AWS resource to aid in identifying owners

I think this could be particularly useful during incidents/investigations


Photoshop cannot open files

Photoshop under OS X cannot open many files produced by guetzli. It returns with error "Could not complete your request because an invalid non-baseline JPEG table number >= 2 is found." I am also told that they don't work under OS X Preview for some people. I can run them through jpegtran to get them to work everywhere.

Can you provide an example of Guetzli output that demonstrates the Photoshop problem? Also, version of Photoshop you're using might be useful.
Do such files work for you in Preview (I'm not sure if they did work for you in Preview or if you didn't say either way)?

Source:
Output:
Quality doesn't appear to matter -- I get the error with all qualities on this file (as well as others). I experienced the problem on Photoshop 2015.5 macOS 10.12.1. I did not have a problem in Finder. On the computer where Finder also didn't work, it was Photoshop 2015.5 and OS X 10.10.5.

I think I've found the issue. Would you mind verifing if the attached file can be opened in Photoshop?
File:

Yes, that file works for me.

Thanks. The commit I've just pushed should fix the problem.


javascript syntax error in HTML file causes empty response

Might be something koa-node-resolve does
cc @bicknellr

Thanks for filing this, it was confusing.


Electron Wrapper

I wrapped the web interface Electron for my personal use, but maybe it could be good to make an app for everybody.
I would need just minor support API, if mox had an endpoint for number of unread messages and issued notification on each message received, I could make it into a nice app that shows number of unread mails in a tray.

I actually already have nice feature, that Alt+number switches between several mox accounts. I am really satisfied with it.

Interesting! Would it be enough if the JS code called some special JS function (that you provide) when a new message comes in? Changes to the mailboxes/messages are coming in over an SSE connection, with handler functions in JS that update the UI. We could add some calls to that (conditional on them being defined, which would only be the case for an electron app).

Yes, Electron can inject API, usually on window element. But mox could also issue standard notification, I worked with this on Protonmail. That way doesn't depend on any knowledge of the environment.

The standard notifications are these, right? https://developer.mozilla.org/en-US/docs/Web/API/Notifications_API
I was thinking of calling some electron-provided code to the current webmail
code to keep it consistent with what you're seeing in the webmail ui. If
unread messages are retrieved from an API call, I'm assuming you're going to
periodically call it, not on every interaction the user has in webmail, eg
reading a message and marking it unread. I expect that would result in
somewhat delayed updating of the unread count shown with the app icon. The
webmail already shows unread messages next to a mailbox, it shouldn't be too
hard to call an extra function whenever that is rendered/changed.
If you're doing api calls outside the regular webmail code, you'll also run
into authentication: You would need to grab auth tokens from webmail
(localstorage, httponly cookie (may not be possible?)).
Or are you looking for a way to register some code that runs independently of
whether the electron is started? So that you can get a message count even
when the app isn't fully running?
About notifications, would you want them only for new messages in the Inbox?
Or also in other mailboxes (all, specifically configured ones)?
I want to also add a little unread message counter to the favicon. I
currently have my webmail open in a pinned firefox tab. It will show a dot
below the favicon when something in the DOM changed. It's been serving as a
poor mans "new message" indicator, but also triggers for messages in other
mailboxes (mailing lists), which makes is less useful. Updating the favicon
unread message count will probably be updated at the same time you're looking
to update an app icon unread message count.


Update scoreboard.js

If a player name contains HTML content, they will be output raw in the scoreboard - leading to xss or blah etc.

Your commit is bad and you should feel bad.  More seriously, I've committed an improved version of your request in 9f36550.


add exta fields to context tracking amqp payload

timestamp:
Currently, if one were to write a daemon to consume rez context tracking AMQP messages (to dump into ELK for eg), there is no way to know the original timestamp indicating the actual resolve time. I believe RabbitMQ does have a plugin available to add this info into the message; however, rez does also publish these payloads in a separate thread, so even the message publish time does not necessarily reflect the actual resolve time.
command:
At method we're finding that we can spot old packages being used, but we can't tell where from. Having rez able to include the command in the payload would be useful. Given that rez-env is often run as a subproc (for us anyway, in our render farm), it may be necessary to store the command for each ancestor proc also.

Isn't the timestamp generated from the ResolvedContext objkect itself? And then dumped into the context key of the payload? At least that's what I see on my side. Or I'm missing something...

There are two different cases - a context getting created (ie a resolve
occurs), or a context being sourced (ie an existing rxt was used).
In the created case, 'timestamp' does not necessarily match the time of the
resolve. The resolve itself may be timestamped to an earlier date (ie
rez-env -t). In this sense 'timestamp' refers to the time as far as the
solver is concerned, which may or may not match current time.
In the sourced case, the timestamp means the same as above... so even if it
is the time of the resolve, that's now sometime in the past, because the
context is just getting reused.
Hth
A
On Thu, Oct 25, 2018 at 2:04 AM JeanChristopheMorinRodeoFX <
<EMAIL_ADDRESS>wrote:

Isn't the timestamp generated from the ResolvedContext objkect itself? And
then dumped into the context key of the payload? At least that's what I see
on my side. Or I'm missing something...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nerdvegas/rez/issues/535#issuecomment-432696073, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABjqSp90iW9KaCyPxHUiiA3LqKJEdez_ks5uoIGFgaJpZM4X3FcE
.

Makes sense. BTW I just saw your edit in the issue description and having the command would indeed make perfect sense. I have setup a queue to dump the events in elasticsearch and I too had the feeling having the command where the resolves come from would be quite useful.


Merge to live!

Docs Build status updates of commit ca79242:
:clock10: Pending: waiting for processors (7 builds ahead of you)
:warning: Docs Build is busy, currently there are 7 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit ca79242:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/design/disable-add-in-commands.md
:white_check_mark:Succeeded

docs/images/outlook-internet-headers.png
:white_check_mark:Succeeded

docs/outlook/internet-headers.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Content Index objects should get their own hierarchy

There are two classes that deal with sorting of content.
media.generic.sorting.lists.ContentIndex
media.data.media.content.movie.MovieIndex(ContentIndex)

Both of these classes should be moved to a different hierarchy.  Something like media.conindex or something along those lines.
The general rule is, we do not sort actual content objects, but we build objects that are more suitable for sorting operations based on the classes or programs that need to sort the data.
Related issue (closed): https://github.com/cjcodeproj/medialibrary/issues/76

Commit:
https://github.com/cjcodeproj/medialibrary/commits/development/

Closing Notes

ContentIndex was moved to a different file for organizational purposes.
MovieIndex will stay where it is, and when other ContentIndex subclasses are created, this issue may be reviewed again.