Pico PIO USB Host

Hi!
Not really an issue but arduino-pico, tinyUSB and Adafruit-tinyUSB just got updated to oficially support USB hosting with PIO on the RP2040.
Maybe that can be a shortcut to get MIDI hosting working.

Thanks @Colatino Using PIO for USB is very interesting. However, if you use the code as described in this project with my forked tinyusb, MIDI hosting is working. It uses the built-in USB IP, not PIO. You can't hook the MIDI device to the Pico host through a hub with this code though. I am waiting for my pull request to the tinyusb  project to be merged to the tinyusb master branch. There has been a bit of activity on the host side of that project recently, so maybe my code will get merged eventually.

Same here - could not compile with your instructions...

I've got an error #include "class/midi/midi_host.h"

https://github.com/csBlueChip/tinyusb/tree/master/src/class/midi take a look at this file with this got almost 90 % of compilation but then getting error please let me know if you are able to get it to work.

@fadh3r Please see my comments on issue #4 @Colatino I have never used the Arduino toolchain so I cannot comment.

@rppicomidi by your readme.md I've got an error on stage:
'git clone --recurse-submodules https://github.com/midiusb2host.git'
with error
'Cloning into 'midiusb2host'...
remote: Not Found
fatal: repository 'https://github.com/midiusb2host.git/' not found
'''
so, this typo is fixing by adding right link to your github profile(name is missing in current command line)
'https://github.com/rppicomidi/midi2usbhost'
and I'm getting many different errors with include using current pico-sdk...

[cmake] Using board configuration from /home/jj/_last_Pico_rppicomidi/pico-sdk/src/boards/include/boards/pico.h
[cmake] CMake Error at /home/jj/_last_Pico_rppicomidi/pico-sdk/src/CMakeLists.txt:23 (add_subdirectory):
[cmake]   add_subdirectory given source "tinyusb" which is not an existing directory.
[cmake] Call Stack (most recent call first):
[cmake]   /home/jj/_last_Pico_rppicomidi/pico-sdk/src/rp2_common/CMakeLists.txt:58 (pico_add_subdirectory)
[cmake]
[cmake]
[cmake] -- Configuring incomplete, errors occurred!
[cmake] See also "/home/jj/_last_Pico_rppicomidi/midi2usbhost/build/CMakeFiles/CMakeOutput.log".
[cmake] See also "/home/jj/_last_Pico_rppicomidi/midi2usbhost/build/CMakeFiles/CMakeError.log".

@fadh3r Thank you for finding typos and omissions in the build instructions. Please try the latest README.md file. As you pointed out, the path to the project code was wrong. More important, the instructions for using the forked tinyusb should have made clear you have to set the current directory to pico-sdk/lib/tinyusb first before you checkout the origin/midihost branch. Finally, I added instructions for a command line build. It assumes that the toolchain is installed correctly. I hope that helps.

I'm very appreciated to you, @rppicomidi! I'll try it! Thanks!

@rppicomidi Thanks for the doc updates. I've got it working now too.
One thing I notice is that when a USB device is not connected, there is a constant stream of garbage MIDI out of the UART. Are you seeing that too or is it just my setup?

@MickeyDelp I don't have this setup connected at the moment. I don't recall this being an issue. May I ask that if the problem persists that you file a new Issue here? If others are seeing the same issue they might find the solution.

@Colatino Are you able to build the code now that I corrected typos and omissions in the README.md file? If so, do you mind if I close this issue? Adding MIDI Host support to PIO USB is a different project in my opinion.

I couldn't build it but my problem is the toolchain... for some reason it doesn't install properly.
You can close the issue, I opened it with the intent to sugest a new feature to the project but I'm a github noob and don't know how to.

@MickeyDelp I don't have this setup connected at the moment. I don't recall this being an issue. May I ask that if the problem persists that you file a new Issue here? If others are seeing the same issue they might find the solution.

It was just a noisy connection. I solved it by using a series diode on the UART TX. I would set that pin to open drain for MIDI, but the Pico does not seem to have that option.

@MickeyDelp I am glad your issue is solved. I am going to close this issue.

Builded successfully!
Thank you @rppicomidi

@Colatino  I reopened this issue to let you know I did in fact implement PIO USB MIDI Host and generated a new project in my repo called pico-usb-midi-filter, which uses the PIO USB MIDI host and the built-in USB MIDI port as a MIDI device to create a MIDI message filter. The README for that project is hopefully enough better that you are able to built that project.  Thank you for calling the Pico-PIO-USB project to my attention.

That's great! I'll have a look as soon as possible.

Thanks @Colatino Using PIO for USB is very interesting. However, if you use the code as described in this project with my forked tinyusb, MIDI hosting is working. It uses the built-in USB IP, not PIO. You can't hook the MIDI device to the Pico host through a hub with this code though. I am waiting for my pull request to the tinyusb project to be merged to the tinyusb master branch. There has been a bit of activity on the host side of that project recently, so maybe my code will get merged eventually.

Hi There,
Why is there the restriction to not using hubs, is this a TinyUSB thing?
Many thanks for any info
Andy

@AndrewCapon There is a bug somewhere in my tinyusb fork's implementation of the MIDI Host code that breaks hubs, I believe. However, there is a new midihost tinyusb pull request #1627 based on my code and a better implementation of USB host bulk endpoint support. Maybe @atoktoto got it working. I haven't had time to test it yet.

Hi @rppicomidi,
Thanks for the info.
I have tried the @atoktoto one as well, it has the same issue unfortunately.
I will take it up on #1627.
All the best, and thanks for the MIDI hosting code.
Andy

Thanks for the info, If I get some time I will have a look, maybe another set of eyes may see something.
I had a quick look and from what I remember there is an enumeration for the hub, then for the first device plugged into the hub, but from that point on if you add a device it doesn't enumerate.
Also the disconnect only happens if you remove the hub, removing the device from the hub doesn't fire this.
Does this sound about right?

@AndrewCapon Yes, that's about right. It's weird because hubs work fine for MSC, which is not all that different from MIDI in that they both use 2 bulk endpoints.


Add link to edit docs page in github

Saw a lot of other docs sites have this - I think it's good so it's easy for others to fix typos, etc.
We can change the wording too (or move it somewhere else if you don't like that).

@thejameskyle

Updated


Adding extra indentation in Apex code

Hello, I'm using Atom-Beautify in a Windows 7 64 bit machine and haven't change anything in the configuration. I'm working with Apex code (.cls and .trigger) and for some reason when I Beatify the file, it's adding additional tabs. For example:
@isTest
private class MyTestClass {
(tab)(tab)@testSetup
(tab)(tab)static void createCommonData(){
(tab)(tab)(tab)(tab)Account a = newAccount();
(tab)(tab)(tab)(tab)insert a;
When what I'm expecting is:
@isTest
private class MyTestClass {
(tab)@testSetup
(tab)static void createCommonData(){
(tab)(tab)Account a = newAccount();
(tab)(tab)insert a;

Hi @fricco -- thanks for getting in touch, your issue belongs to the beautify-package, take a look at #138 to get more information.
💝


Merge ProcedureManager mDefinitions and mReferences maps

This is a WIP on functions.
I replaced the two maps with one, in an effort to reduce the number of parallel keys I need to maintain.
Future step is to do the same with the NameManager, making it a map-like structure to ProcedureBlocks or VariableInfo objects. This also centralizes the canonization of names, and reduces the "surface area" of the name synchronization problem seen during procedure rename.
Also, much more ProcedureManager JavaDocs I missed on the last pass.

This change is

Review status: 0 of 11 files reviewed at latest revision, 6 unresolved discussions, some commit checks broke.

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 88 at r1 (raw file):

    private class ProcedureBlocks {
        String mName;
        Block mDefinition;

Should the definition block also be final?

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 181 at r1 (raw file):

     *
     * @param block The block queried.
     * @return The list of argument for defined or referenced by this block, if it is a procedure

@return sentence is confusing.

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 231 at r1 (raw file):

     * Queries whether a procedure block contains a matching registered definition block. Similiar
     * to {@link #isProcedureDefined(String)}, except it takes in a procedure block. If the block is
     * a procedure definition, if ensure the block is the same registered definition block.

s/if/it

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 240 at r1 (raw file):

     *         definition or reference mutator.
     */
    public boolean containsDefinition(Block procedureBlock) {

Why isn't this also named isProcedureDefined?

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 277 at r1 (raw file):

     *         definition or reference mutator.
     */
    public boolean isReferenceRegistered(Block procedureRefBlock) {

This seems to only be used for testing. package scope and @VisibleForTesting?

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 323 at r1 (raw file):

        }
        validateProcedureBlocksMatch(procBlocks.mDefinition, procedureReferenceBlock, false);
        // TODO: validate definition & reference ProcedureInfo match

Do you still need this TODO?

Comments from Reviewable

Review status: 0 of 11 files reviewed at latest revision, 6 unresolved discussions.

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 88 at r1 (raw file):
Previously, RoboErikG wrote…
Should the definition block also be final?

Hmmm... Makes sense. Done.

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 181 at r1 (raw file):
Previously, RoboErikG wrote…
@return sentence is confusing.

Rewrote.

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 231 at r1 (raw file):
Previously, RoboErikG wrote…
s/if/it

Done.

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 240 at r1 (raw file):
Previously, RoboErikG wrote…
Why isn't this also named isProcedureDefined?

I guess I was thinking this query was asking about this specific block. Did it contain this block? Where the other was asking whether the procedure name was defined by any block. As I describe this, I think I prefer this current name.

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 277 at r1 (raw file):
Previously, RoboErikG wrote…
This seems to only be used for testing. package scope and @VisibleForTesting?

Good catch.

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 323 at r1 (raw file):
Previously, RoboErikG wrote…
Do you still need this TODO?

Removed.

Comments from Reviewable

Review status: 0 of 11 files reviewed at latest revision, 17 unresolved discussions.

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 277 at r1 (raw file):
Previously, AnmAtAnm (Andrew n marshall) wrote…
Good catch.

Did you need the public scope still?

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 87 at r2 (raw file):

    }

    private class ProcedureBlocks {

remove s -> ProcedureBlock

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 417 at r2 (raw file):

        if (found) {
            if (referenceBlock.getType().equals(CALL_WITH_RETURN_BLOCK_TYPE)) {
                --mCountOfDefinitionsWithReturn;

You removed the increment from addReference. Need to also remove the decrement from here.

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 441 at r2 (raw file):

     */
    public void addDefinition(Block definitionBlock) {
        Log.d(TAG, "addDefinition " + getProcedureName(definitionBlock) + " block "

Nit: remove log

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 445 at r2 (raw file):

        if (!isDefinition(definitionBlock)) {
            throw new IllegalArgumentException("Block is not a procedure definition: " + definitionBlock);

nit: line length

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 459 at r2 (raw file):

        }
        mProcedureNameManager.addName(canonicalProcName);
        mProcedureBlocks.put(canonicalProcName, new ProcedureBlocks(definitionBlock));

Should you check if it has a return and increment mCountOfDefinitionsWithReturn?

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 526 at r2 (raw file):

                mObservers.get(i).onProcedureBlocksRemoved(procBlocks.mName, resultBlocks);
            }
        }

Check if it has a return and decrement mCountOfDefinitionsWithReturn

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 560 at r2 (raw file):

        final ProcedureInfo oldProcInfo = definitionMutator.getProcedureInfo();
        String newProcedureNameRequested = updatedProcedureInfo.getProcedureName();
        Log.d(TAG, "Definition "+Integer.toHexString(definition.hashCode())+"\n\tnewProcedureNameRequested = " + newProcedureNameRequested);

Nit: Logs

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 564 at r2 (raw file):

        Log.d(TAG, "\tisFuncRename = " + isFuncRename);
        final String newProcedureName = !isFuncRename ? originalProcedureName
                : mProcedureNameManager.generateUniqueName(newProcedureNameRequested, true);

Does this allow changing the case? eg procedurename -> procedureName

blocklylib-core/src/main/java/com/google/blockly/android/ui/fieldview/BasicFieldInputView.java, line 48 at r1 (raw file):

        public void afterTextChanged(Editable s) {
            if (mInputField != null) {
                if (mInputField.getBlock() != null) { Log.d(TAG, "Block "+Integer.toHexString(mInputField.getBlock().hashCode()) + ": New input view text: " + s); }

log

blocklylib-core/src/main/java/com/google/blockly/model/mutator/ProcedureDefinitionMutator.java, line 148 at r1 (raw file):

        ProcedureInfo xmlInfo = ProcedureInfo.parseImpl(parser);
        FieldInput nameField = getNameField();
        Log.d("ProcedureDef", "parseAndValidateMutationXml for block " + Integer.toHexString(mBlock.hashCode()) + ":"

logs

blocklylib-core/src/main/java/com/google/blockly/model/mutator/ProcedureDefinitionMutator.java, line 293 at r2 (raw file):

                Log.d("ProcedureDef", "Block " + Integer.toHexString(mBlock.hashCode())
                        + ": updateBlock(): field name: " + nameField.getText()
                        + ", new name: " + mProcedureInfo.getProcedureName()

logs

Comments from Reviewable

Review status: 0 of 11 files reviewed at latest revision, 17 unresolved discussions, some commit checks broke.

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 277 at r1 (raw file):
Previously, RoboErikG wrote…
Did you need the public scope still?

Fixed.

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 87 at r2 (raw file):
Previously, RoboErikG wrote…
remove s -> ProcedureBlock

Intentionally plural.  It is a set of blocks, including definition block and possibly multiple reference blocks.

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 417 at r2 (raw file):
Previously, RoboErikG wrote…
You removed the increment from addReference. Need to also remove the decrement from here.

Done.

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 441 at r2 (raw file):
Previously, RoboErikG wrote…
Nit: remove log

Because I'm still debugging this issues and this isn't going into develop branch, I'm going to leave these for now.

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 445 at r2 (raw file):
Previously, RoboErikG wrote…
nit: line length

Done.

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 459 at r2 (raw file):
Previously, RoboErikG wrote…
Should you check if it has a return and increment mCountOfDefinitionsWithReturn?

Done.

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 526 at r2 (raw file):
Previously, RoboErikG wrote…
Check if it has a return and decrement mCountOfDefinitionsWithReturn

Done.

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 560 at r2 (raw file):
Previously, RoboErikG wrote…
Nit: Logs

Will remove before I merge into develop.

blocklylib-core/src/main/java/com/google/blockly/android/control/ProcedureManager.java, line 564 at r2 (raw file):
Previously, RoboErikG wrote…
Does this allow changing the case? eg procedurename -> procedureName

Good point.  Fixed, and  I've added this to my use cases to test.

blocklylib-core/src/main/java/com/google/blockly/android/ui/fieldview/BasicFieldInputView.java, line 48 at r1 (raw file):
Previously, RoboErikG wrote…
log

Will remove before merging into develop.

blocklylib-core/src/main/java/com/google/blockly/model/mutator/ProcedureDefinitionMutator.java, line 148 at r1 (raw file):
Previously, RoboErikG wrote…
logs

Will remove before merging into develop.

blocklylib-core/src/main/java/com/google/blockly/model/mutator/ProcedureDefinitionMutator.java, line 293 at r2 (raw file):
Previously, RoboErikG wrote…
logs

Will remove before merging into develop.

Comments from Reviewable

Review status: 0 of 11 files reviewed at latest revision, 17 unresolved discussions, some commit checks broke.

Comments from Reviewable


X-Matrix auth doesn't mention how query params are ordered, if at all

well, it doesn't matter, provided no proxies rearrange them on the way.

Proxies can and do rearrange them. Some parsing libraries also don't provide easy access to the string.

Proxies can and do rearrange them.

https://tools.ietf.org/html/rfc7230#section-5.7.2 does say 'A proxy MUST NOT modify the "absolute-path" and "query" parts of the
received request-target', but I can imagine that they do in practice.
It's related to the problem that proxies rewrite %40 to @, or vice versa, leading to https://github.com/matrix-org/synapse/issues/4858 and co.
I've been thinking we should specify a "canonical uri format" which could solve most of both problems. (make sure that you sign and send the request using the canonical format; then accept signatures which match either the received format or the canonical format.)

a canonical uri format is essentially what this is begging for :)


Remove Items from duplicates Array

Submission Title
Bubble Sort/AVL Graph/Vector
Submission Type
Algorithm/Data Structure/Array/
Submission Description
Describe the Algo/DS
Submission Directory
Algorithm => Data Structure => ... => ... => Filename.extension
Contributors

[ ]  Python -
[ ] Java -
[ ] JavaScript -
[ ] TypeScript -
[ ] Golang -
[ ] Ruby -
[ ] php -
[ ] Swift -
[ ] C# -

hi @shadab-me , I would like to work on this issue and can provide the answer in swift , python and C++. If you allow, I may start my work on this issue

Hi @shadab-me, can I work on this issue?

I can resolve this issue using C# and java, assign me if I should start

I am working on JavaScript. Assign me

Invalid Issue :warning:


Multipage Drawio file

Hello,
is it possible to extract a certain page from drawio?

The drawio command line help has this line
  -p, --page-index <pageIndex>                  selects a specific page, if not specified and the format is an image, the first page is selected

If this option does what you want, you could add a parameter to includediagram to this.


Add withComponent Interface or as Prop Similar to EmotionJS

Summary
I am wondering if there are any plans to add a withComponent interface or an as prop similar to EmotionJS. This feature would be incredibly useful for scenarios where we need to specify the HTML tag used for rendering a component.
Examples
https://emotion.sh/docs/styled#change-the-rendered-tag-using-withcomponent
https://styled-components.com/docs/api#as-polymorphic-prop
Motivation
const Component = styled.div`
  color: red;
`;

render(
  <Component
    as="button"
    onClick={() => alert('It works!')}
  >
    Hello World!
  </Component>
)

Search keywords: withComponent, as Prop, EmotionJS

This already works right now.


WebSocket connection to 'wss://<IP_ADDRESS>:9231/' failed: Error in connection establishment: net::ERR_SSL_PROTOCOL_ERROR

I got this error when trying to mirror my iphone

just edit on var ws = new ReconnectingWebSocket('wss://' + location.host + '/'); into ws then everything normal


Fastlane env no longer fails if you don't have git installed

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context
Fixes issue https://github.com/fastlane/fastlane/issues/15414
Description
Wrapped the call to git version in a rescue block so it displays "not found" instead of an unhandled exception.
Tested locally by renaming the git binary in /usr/local/bin. Table row displays "Git: not found". Renamed the binary back and the version was displayed.

Thanks, rubocop is not yet happy:
[16:26:25]: ▸ Offenses:
[16:26:25]: ▸ fastlane/lib/fastlane/environment_printer.rb:298:7: C: Style/RedundantBegin: Redundant begin block detected.
[16:26:25]: ▸ begin
[16:26:25]: ▸ ^^^^^
[16:26:25]: ▸ fastlane/lib/fastlane/environment_printer.rb:300:17: W: Lint/UselessAssignment: Useless assignment to variable - ex.
[16:26:25]: ▸ rescue => ex
[16:26:25]: ▸ ^^
[16:26:25]: ▸ 1125 files inspected, 2 offenses detected


Fix/tmlr updates

Change email template
Sort submissions by due date in the EIC and AE console
Add replyTo when sending reminders from the EIC and AE console
Use the end of the day to setup the duedate for all the TMLR invitations.
Notify EIC about comments posted that are only visible to them and the author of the comment.
Support host field.
Show submissions with pending ratings in the Under decision tab
Add new column to show the EIC only comments:

Zach, I would need some help formatting the comments :)

I updated the comments column so now it looks like this:


Native Base Roadmap

Description
Understanding that all efforts are on gluestack now, I would like to ask about the roadmap for Native Base, to get clear our roadmap using it.
Problem Statement
Considering that gluestack is the future, is scheduled any update or something for Native Base?
For example, is known the "In React 18, SSRProvider is not necessary and is a noop..." warning with React Native 72. And is possible that in future there will be another like that.
Proposed Solution or API
Knowing the roadmap for Native Base and for gluestack will help us with our roadmap.
Thanks in advance.
Alternatives
No response
Additional Information
No response

That would be very helpful, up !

It is estimated that Native Base will no longer be maintained gradually, and will turn to gluestack-ui wholeheartedly.


Open accessibility view only works if focus on particular Chat view element

Copilot chat
Focus the whole view
F1 > accessibility view. Nothing happens 🐛

Only if I move focus to be on one exact element the command will work.
We should make the command more flexibly, so it is not so strict with regards to focus. It should also work if I am on the Chat input, or on the whole Chat view. In those cases it should probably act as if the focus was on the last item.

@Tyriar also mentioned this, makes sense

@roblourens is there a way to get the last response widget from the IChatWidgetService? I don't want to reinvent the wheel and at first glance, am not seeing this.

AFAIK, one cannot focus the chat view without focusing either the list (item) or the input.
So, to verify:

focus the chat input
Alt+f2 ✅ that the accessible view shows the most recent response
repeat the steps but with focus on an item - it should show that item

Thanks for fixing it, it is better than before.
However now the help view always has the content of the last chat. Ideally it would respect the focused chat element, if none of the chat elements are focused then we should show the content of the last one in the accessibility help editor.
Reopening this to hear what you think about this proposal. Thanks

https://github.com/microsoft/vscode/assets/29464607/2001400f-28b5-4bfb-9a7d-2cb926c3379b
@isidorn that is working for me - could you pls attach a gif of what you're seeing?

Thanks - that's a bug, but different from this issue - to test this issue, you'll want to use alt+f2. I'll make a new one to cover that

Thanks!
Here's the alt+f2 behaviour. It always show the last content. So it also seems to be off

Hm, that's very strange - I cannot reproduce but will try again

I see you are focusing a request - in that case, it will just show the last response by design

ok I can repro when the replies were from a previous session

Thanks for testing @isidorn. Where is your focus when you are seeing a no-op? I cannot repro unless my focus is on a request, which is expected.
https://github.com/microsoft/vscode/assets/29464607/f1d17ecc-fa2f-4cd5-a3c3-0e689c7694bd

You are correct, the focus is on the request. Why is that an expected no-op? Why do we treat request and response differently?

It would be great if you could verify this particular issue - happy to make a new one if you disagree about that particular part

I have added the verified label.
As for request and response behaving differently, I will open a new issue.


Checking that returned secrets are enabled #656

Description
BulkGetSecret checks if secrets returned by the GetSecrets API are enabled before fetching the values.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #656
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@cmendible do we need a similar check for Get?

@cmendible do we need a similar check for Get?

Should be catched by: https://github.com/dapr/components-contrib/blob/e6924c6d7b8c5b7c63214f8ca7389c3e8ab84f9c/secretstores/azure/keyvault/keyvault.go#L71 since we can't filter in advance.


python311Packages.fsspec: fix hash mismatch

Description of changes

Building currently results in failure. Introduced in #262753
error: hash mismatch in fixed-output derivation '/nix/store/49vh61dmilhzbnxw08qhmyhzlwlvhznl-source.drv':
         specified: sha256-GVBF2ppyIEvC4rR9IF4gwsdc4fJe1xHS1CyJEwFuVGw=
            got:    sha256-cLkCQQbb/AakDSz1NTrVlHh8LdgoqtjX8OPT+Nb1NA4=
error: 1 dependencies of derivation '/nix/store/mjc02w7kin6ylc3czn0qzf9b8yny1b56-python3.11-fsspec-2023.10.0.drv' failed to build

Maybe the package updated in place, but I don't think it's likely due to the tag being created on Oct 21st, referencing a commit made on that day, before the PR.
@GaetanLepage This worked last time you checked, yeah? Can you try to build this on your machine again to see if this isn't just your machine?
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Indeed, you are right. I am sorry for not updating the hash :/
We should definitely merge this.


Mocking data for local usage

This PR changes 'KubeStore' to use localStorage for mocked data.
Basic concept is that KubeStore will load mocked data from a local json file into localStorage and will then serve requests from the data in localStorage.
I took a stab at manually creating the format for the mocked data, have it working with entities for MigCluster only.  This approach is intended to support data from multiple hosts, will need to flesh out more data to confirm implementation supports.
Next steps:

[ ] Need to rework the fetching of data from a host to automatically populate the mocked data.
[ ] Add support for 'put' in client.mock.
[ ] Add support for 'put' in KubeStore, it should be able to modify data in localStorage,  I think this will need work per Resource type
[ ] Add support for 'patch' in KubeStore, it should be able to modify data in localStorage, also work per resource type
[ ] Test with multiple hosts
[ ] Need to set up a good 2 cluster env with successful migrations run to pull data and update mock data
[ ] Clean up code and remove unused older mocked_data and KubeStore db references.

@andyvesel here's an approach for modifying KubeStore to read in the mocked data and populate localStorage.
Please take a look at this approach and we can work together on finishing the pieces during the week.
To support the upcoming webinar need to get the mocked data complete and updated before end of the week.

@andyvesel updated PR so at this point we can run:
'yarn mocks' it will talk to the k8s cluster referenced in the kubeconfig and will pull down the needed data.
I've updated KubeStore to read the mocked data.
Get and List are working.
Thinking might be good to merge this PR after it's been reviewed and follow up with new PRs that add in support for Put/Patch

@jwmatthews ack, thanks for good example of this.

Please hold off on merging until we are sure that the aws access credentials are sanitized and never committed.  At moment this is all test/dummy data so nothing has leaked, but this needs to be handled for future before merging.

Good to merge, the AWS key issue has been addressed
Support for get/list is present.
Next up is put/patch we will add that in separate PRs

This is looking good - I am wondering if there are any plans to mock out the status on the plan? even if we could just get a completed status immediately on plan creation, that would help when working on UI specific css/features locally.

Looking good - Can we get a set of initial data that would allow a dev to jump into ui development immediately? I am missing namespaces on the mocked out target cluster. Also, some status mocking for plan creation would be great.

Plan is to add more data, this PR is just an initial step.
Only has data for seeing clusters/repositories.


Cannot type non-hex characters when using certain encodings (error "unknown encoding")

A

Open Find/Replace
Set mode to TEXT
Try typing in the find field
nothing appears (though you can backspace over any previously entered text)

B

Open Find/Replace
Set mode to HEX
Try typing in the find field
hex can be typed

Affects
Version 2.8 (170719)
Version 2.9 (180121)

I can't reproduce. I'm able to type just fine. What are you typing? Can you paste text? Does it work with a new empty document?

Hmm. I can't paste text either.
I'm just typing plain English using the keyboard.
Strangely it works if I log in to a new user (guest user account). Will investigate. I'll leave this open until I find the cause/solution.

OK, this was related to my Japanese encoding testing. I had left encoding set to one of the more obscure Japanese encodings.

When typing with no text appearing Console reported a big clue:
default	10:44:21.503112 +0000	Hex Fiend	Unknown encoding<PHONE_NUMBER>

Setting encoding to something more sane (even Japanese-JIS) means I can not type OK.
Leaving open because still seems like a bug.

It's not really a bug, since that encoding (https://en.wikipedia.org/wiki/JIS_X_0213) doesn't handle ASCII characters it seems. I added an alert in this case showing that the text conversion failed.

Also, related and probably not worth a new bug...
I can Cmd+click the selected other encoding and then there are no encodings selected (but it's still using the one you last selected)

Go ahead and make a separate issue.


This is Awesome, but...

Do you think there would be a way to make the PowerShell Script Run as the user who is visiting the page?  I have been able to get the Remote_User to show up as the User who is visiting the page, but I enabled Windows Authentication under Authentication for the site. Can't use Impersonate User because that isn't working, but maybe the CGIWraper process needs to run with Impersonate User? Also the reason for run as the authenticated user is so I can do some Get-ADComputer without this error 'Get-ADComputer : Unable to contact the server. This may be because this server does not exist, it is currently down, or it does not have the Active Directory Web Services running.' when I specify an account with -Credential and an account it works, but not really secure.

Hi
In my expirience enabling "Basic Authentication" and disabling "Anymous Authentication" should be enough.
But for some reason some environment variables show wrong information - see example below.
If you always want to run the site as a specific user - without HTTP authentication - you should also be able to define a user if you select "Edit" under "Anonymous Authentication".
'Content-Type: text/plain'
''
'This show computer account:'
$env:USERNAME
''
'This show user account:'
whoami

Я столкнулся с проблемой, что при аутентификации пользователя через базовую аутентификацию, появляется вот такая ошибка при запуске скрипта, если добавить его в группу Администраторы или Доменные администраторы, то проблема уходит.
Кто нибудь знает на что не хватает прав?


[WIP] Rebuild property editor

Add a popup window to every encoding shelf that allows the user to manually specify encoding properties i.e. maxbins for the bin property.
Fix https://github.com/uwdata/voyager2/issues/150
Fix #218

@kanitw Eventually we should be reading the applicable properties from the Vega-Lite schema but for the sake of adding important properties quickly, maybe we should hard-code into the channelshelf whatever properties we need.


overriding template of each user bundle

when you create many user bundle under rollerworkers , we cant override template of each bundle separately!

Actually you can, the documentation is a big problem (and I don't have any time to get this resolved).
Each user-bundle you create has its own configuration, see https://github.com/rollerworks/RollerworksMultiUserBundle/blob/master/docs/creating_classes_by_hand.md#34-make-your-bundle-configurable for a complete reference. You can set the template location to overwrite the template for your user-bundle.


CoNLL.py Getting an Error in Train_Chunking.py

Using TensorFlow backend.
Generate new embeddings files for a dataset
Read file: komninos_english_embeddings.gz
Added words: 3
:: Transform agac_chunking dataset ::
Traceback (most recent call last):
File "Train_Chunking.py", line 47, in
pickleFile = perpareDataset(embeddingsPath, datasets)
File "/public/home/zcyu/ref/NLP/emnlp2017-bilstm-cnn-crf/util/preprocessing.py", line 57, in perpareDataset
pklObjects['data'][datasetName] = createPklFiles(paths, mappings, datasetColumns, commentSymbol, valTransformations, padOneTokenSentence)
File "/public/home/zcyu/ref/NLP/emnlp2017-bilstm-cnn-crf/util/preprocessing.py", line 318, in createPklFiles
trainSentences = readCoNLL(datasetFiles[0], cols, commentSymbol, valTransformation)
File "/public/home/zcyu/ref/NLP/emnlp2017-bilstm-cnn-crf/util/CoNLL.py", line 48, in readCoNLL
val = splits[colIdx]
IndexError: list index out of range

my data have some special character. it caused the error.

maybe your data is not BIO format？


Add support for Cosine Similarity

This pull request introduces a new CosineSimilarity function to the pgvector Django integration and updates the corresponding tests. The most important changes include adding the CosineSimilarity function, updating imports, and adding a new test case for CosineSimilarity.
CosineSimilarity must be useful for people who are wondering to use similarity instead of distance.
New feature addition:

pgvector/django/functions.py: Added a new class CosineSimilarity that inherits from DistanceBase and overrides the as_sql method to compute cosine similarity.

Import updates:

pgvector/django/__init__.py: Updated the import statement to include the new CosineSimilarity function.
tests/test_django.py: Updated the import statement to include the new CosineSimilarity function.

Test updates:

tests/test_django.py: Added
This pull request introduces a new CosineSimilarity function to the pgvector Django package, along with corresponding tests. The changes primarily involve adding this new function and ensuring it is properly tested across different vector types.

Key Changes:
New Functionality:

Added CosineSimilarity class to pgvector/django/functions.py to calculate cosine similarity.

Import Adjustments:

Updated imports in pgvector/django/__init__.py to include CosineSimilarity.
Updated imports in tests/test_django.py to include CosineSimilarity.

Testing Enhancements:

Added test_vector_cosine_similarity method to test cosine similarity for regular vectors in tests/test_django.py.
Added test_halfvec_cosine_similarity method to test cosine similarity for half vectors in tests/test_django.py.
Added test_sparsevec_cosine_similarity method to test cosine similarity for sparse vectors in tests/test_django.py.

Hi @enzofrnt, thanks for the PR. The code and tests look great, but I don't think an additional function is needed (users can currently do 1 - CosineDistance(...)).


Slay The Enemies Feat not working.

On going campaign, before the latest patch the feat was working when clicking on "Powers"  then pressing "Slay The Enemies" it will show up a small menu to select the level of the slot to burn.
After new patch, same process yields no menu to select level of the slot to burn..
Tested in various environments including out of combat, no concentration on a spell, with concentration on a spell, first thing in combat before taking any action, at the end, etc. No solution.

Already fixed in dev. Thanks


Update the firebase.json emulators config to include explicit hosts.

Update the firebase.json emulators config to include explicit hosts rather than relying on the default localhost. This fixes some connection issues with unit tests.
Update the node version in the github workflow to 16 to satisfy the firebase-tools min version.
Question: This still requires FIREBASE_EMULATOR_HUB to be set - is there a way we can include that in the config?

Update the node version in the github workflow to 16 to satisfy the firebase-tools min version.

Gotta update the package.json files too with the engine field.

Question: This still requires FIREBASE_EMULATOR_HUB to be set - is there a way we can include that in the config?

No, but according to my testing, neither the env var nor the host IP address is needed any more in the next CLI release. The hub will default to listen on both IPv6 and IPv4, so the hub can be reached in most of the cases, and then the hub report the <IP_ADDRESS> IPv4 address for Firestore and the tests will just work(TM).

Update the node version in the github workflow to 16 to satisfy the firebase-tools min version.

Gotta update the package.json files too with the engine field.

Added

Question: This still requires FIREBASE_EMULATOR_HUB to be set - is there a way we can include that in the config?

No, but according to my testing, neither the env var nor the host IP address is needed any more in the next CLI release. The hub will default to listen on both IPv6 and IPv4, so the hub can be reached in most of the cases, and then the hub report the <IP_ADDRESS> IPv4 address for Firestore and the tests will just work(TM).

This matches my testing with the HEAD version. Nice !


Link to PowerShell and SCCM docs broken

from this page:
https://github.com/MicrosoftDocs/SCCMdocs
There's a link to here:
https://github.com/MicrosoftDocs/sccm-docs-powershell
but I receive a 404 when I try to go to that link. I tried to find the current location for sccm-docs-powershell (so I could fix the docs myself), but I can't find it!

Thanks @ramseygr, that's a known issue, technically currently by design. The SCCM PowerShell repo is currently private. So that note there (good sleuthing!) is mostly for my reference right now. But I do have a request with our ops team to make the PowerShell repo public. I don't have a specific timeline yet, so best I can say is "coming soon." I'm going to close this issue as there's nothing else actionable right now.

As a private repo, it only works for Microsoft authenticated users. Again, hoping to make it public soon.


Update dir to delete

1. Why is this change necessary?
DeleteThemeFilesHandler tries to delete old theme dir. Unfortunately the path is wrong and nothing is deleted.
2. What does this change do, exactly?
Changes the path to the real directory.
Relates to e.g. https://github.com/shopware/shopware/blob/trunk/src/Storefront/Theme/ThemeCompiler.php#L479
Otherwise ThemeCompiler must be changed combined with https://github.com/shopware/shopware/blob/trunk/src/Core/Framework/Resources/config/packages/shopware.yaml#L108C9-L108C9?
3. Describe each step to reproduce the issue or behaviour.
Build your theme 2 times. All directories from the first run should be deleted (Default message queue delay 15min)
4. Please link to the relevant issues (if any).
5. Checklist

[x] I have rebased my changes to remove merge conflicts
[ ] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: En0Ma1259:x: Fabian BoenschFabian Boensch seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

thanks for your contribution @En0Ma1259  👍🎉💙


How to Download the Wallpapers

To download the wallpapers from the Google Photos shared album, follow these steps:

Join the Album: First, join the shared album here to get access to the wallpapers.

Set Up rclone for Google Photos: Make sure rclone is configured to access Google Photos. For setup instructions, refer to the rclone Google Photos documentation.

Download the Wallpapers: Use the following rclone command to copy the wallpapers to your local directory:
rclone copy -vv --log-file rclone-debug.log "gphotos:/shared-album/やℜ々✗¥`𝕊 ᙎ公𝙻𝙻𝕊/" /opt/$USER/Wallpapers/PROxZIMA/

-vv: Enables detailed logging.
--log-file rclone-debug.log: Saves the log output to rclone-debug.log for troubleshooting.

Check Your Local Directory: The downloaded wallpapers should appear in the specified directory (e.g., /opt/$USER/Wallpapers/PROxZIMA/).

This should guide you through joining the album and downloading the wallpapers.

Thanks @arpagon for the detailed doc. I'll add it to the readme.
I considered other storage options, but since I have a Pixel 6, Google Photos seemed like the best choice.


Audio Extraction Progress (Like the Downloading Progress)

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm requesting a feature unrelated to a specific site
[X] I've looked through the README
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood
When downloading a Video from any source and then extracting only the audio from it via ffmpeg, you get no progress for when the extraction is completed. For large Files this can take much more time than the downloading part (tested it with a 2h video and it downloaded in 10s and extracted in like 1min). When using ffmpeg directly one can see, that ffmpeg produces some stats about the progress (not directly a progressbar, but the progress can be calculated via timestamps) which could be theoretically parsed to YT-DLP.
Provide verbose output that clearly demonstrates the problem

[ ] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
No response

Dup of https://github.com/yt-dlp/yt-dlp/issues/1720


Further actions when fine tuning results are very poor

First thank you for your great contribution.
I am trying to train my custom dataset, pretraining with the coco dataset
With your suggestion in the issue, I added parameters. Rest of them was system default.
-- pretrain_model_path /path/to/checkpoint/of/coco-pretrained-model
-- finetune_ignore label_enc.weight class_embed
-- options num_classes=7

Training proceeds, but performance has become poor. Growth stops around 0.3 AP.

Blue is the graph obtained at the time of pretraining, and the coco-dataset was trained with dino and backbone as swin large, and the red graph is the fine-tuning of this coco-dino-swin model as pretrained.

Looking a little more at the loss graph, it was observed that the box loss fell enough as expected, but the class embedding part, where the weight was ignored during finetune, did not fall enough.
What additional parameters do I need to adjust to improve the performance of the model I fine-tune with my own dataset? Or what additional actions should be observed/taken further? Your suggestion will be very appreciated.

Hi, do you mean you do not train class embedding during finetuning? If yes, I think this is problematic.

Not really. When training my own dataset during fine tuning, both bbox and class embeddings are trained as you response at the issues 23(https://github.com/IDEACVR/DINO/issues/23). However, since num_classes are different, add label_enc.weight class_embed to the -- finetune_ignore option. If I do not add this option, num_classes mismatch  cause a tensor size mismatch error occurs.
I expected the same level of performance as DINO showed with the coco dataset. I succeeded score in reproducing the performance using dino with the coco dataset as you saw the tensorboard graph above, but the problem is that the performance does not come out when I fine-tune train my own dataset using the coco dataset-swin backbone-dino model as a pretrained model. I would like to know if there are any additional parameters I need to adjust.

Not sure what causes the problem.   Since you have 7 classes, the model will use first 7 class embeddings and leave other 91-7 classes unused.

How was this issue handled during the fine-tuning of object-365 to coco?


Undefined is not an object

I can't seem to shake this bug, and I can't figure what's wrong.
I followed the install instructions, and did the automatic linking, but when i try to call a library i get this error:
TypeError: undefined is not an object (evaluating 'Voice.startSpeech')]
This error is coming from within the library index.js file,
I set a console log here, and sure enough, Voice is undefined, what am I missing?

The problem was starting with: create-react-native-app
If you build your app this way it cannot use native components like this.
Instead use react-native init

@jonnycraze Thanks for your update :)

this error on Speech Recognition

I tried using react-native init as well. It didn't worked for me. Please help.


[VFM] V-day enforcement

See MAR-2724 for the list of requirements.  This affects JIRA issues created, the seller catalogue (including search functionality), seller profiles and seller validation.
Related to: https://github.com/AusDTO/dto-digitalmarketplace-api/pull/579

Closing until V-day.


Update stuff_prompt.py (Fix the sources field is blank)

Description: This change aims to resolve the issue by enhancing source extraction from the following link: LangChain Issue #9913. The problem is fixed by replacing "source" in the prompt with "reference."
Dependencies: There are no specific dependencies required for this change.
Twitter handle: @davinci137.
The "SOURCES" field is currently empty due to a split occurring at the word "Source:."
# In the middle of the answer, a split is performed
def _split_sources(self, answer: str) -> Tuple[str, str]:
    """
    This function is responsible for splitting sources from the answer.
    Args:
        answer (str): The answer text.
    Returns:
        Tuple[str, str]: A tuple containing the modified answer and extracted sources.
    """
    if re.search(r"SOURCES?:", answer, re.IGNORECASE):
        # It utilizes regular expressions to split the answer and sources based on "SOURCES:" or "QUESTION:" (case-insensitive).
        answer, sources = re.split(r"SOURCES?:|QUESTION:\s", answer, flags=re.IGNORECASE)[:2]
        # The sources are split based on newline characters, and the first line is extracted, with leading and trailing whitespace removed.
        sources are then stripped.
    else:
        sources = ""
    return answer, sources

Hi @datorresb,
I tried locally your proposed fix but it does not solve the problem in my case.
This one instead seems to be resolutive:  argocan proposed fix

this is prompting issue, not garuntee to fix universally, should be passing in prompt


Ramalama Isnt Directing Stderr correctly

In an older commit, Podman and llama-cli commands would be separated, causing the container's stderr to be redirected to null (without --debug), which worked. Analogous to this example
podman run --rm  etc
llama-cli run --rm  etc   2>/dev/null

Now what is happening is essentially this
podman run  etc  llama-cli  etc  2>/dev/null

Which only redirects the stderr of the current runtime, not inside the container
I'm currently looking into exec_cmd to have the functionality similar to this below but I'm having a hard time figuring out what the best solution should be
podman run etc "llama-cli  etc 2>/dev/null" (llama-cli inside quotes)

I'm not sure if Podman has a way of redirecting the stderr inside the container or if should I play around with using subprocess.run vs os.execvp
def exec_cmd(args, stderr=True, debug=False):
    if debug:
        perror("exec_cmd: ", *args)

    if not stderr:
        # Redirecting stderr to /dev/null
        # Here we have our issue when stderr is False we are still getting stderr from the container
        with open(os.devnull, "w") as devnull:
            os.dup2(devnull.fileno(), sys.stderr.fileno())

    try:
        return os.execvp(args[0], args)
    except Exception:
        perror(f"os.execvp({args[0]}, {args})")
        raise

I would favour os.execvp because it's one less process

Podman does not do anything with stderror, just passes it back to the caller.
Does your new exec_args work?

My guess would be, upstream llama.cpp changed the debug/verbose output to be stdout rather than stderr again. But I haven't checked this isn't the first time a change like:
https://github.com/containers/ramalama/pull/187
maybe we could try log disable again.
We may have to consider writing our own application against llama.cpp as a library at some point in the future. I'm not sure if llama.cpp intend on stabilising llama-cli, llama-server, they are considered "examples" in that project. We just don't have the capacity to do this right now.

@bmahabirbu good analysis I see what you mean before we used to run python inside and outside the container so that would have altered behaviour a bit also. You could be right, haven't played around with this to check.
I am noticing when implementing llama-cpp-python-server we will probably have to use a little bit of python3 inside the container for that runtime again

My guess would be, upstream llama.cpp changed the debug/verbose output to be stdout rather than stderr again. But I haven't checked, so it's just a guess, this isn't the first time a change like this has happened:
#187
maybe we could try --log-disable again.
We may have to consider writing our own application against llama.cpp as a library at some point in the future. I'm not sure if llama.cpp intend on stabilising llama-cli, llama-server, they are considered "examples" in that project. We just don't have the capacity to do this right now.
We recently updated the version of llama.cpp to get @slp 's neat Kompute functionality in which was successfully upstreamed 😄

I tested this against the latest version of llama.cpp and having llama-cli command wrapped in quotes adding 2> dev/null and it still works as it once did!
Thats an interesting idea! I didn't know that llama-cli/llama-server is just example code. I'll check this out further!
Lately I've been playing around with getting vulkan to work inside a container on wsl2 so i'd love to test out Kompute as well!

@bmahabirbu if you've tested the latest version of llama.cpp works fine, if you can open a PR updating the commit id of llama.cpp we use to that one, we should be good to close this...


[Eventhubs] Remove Six

#26895

API change check
API changes are not detected in this pull request.

/azp run python - eventhub - tests


vee-validate input cannot be edited

Versions
"vee-validate": "^2.0.0-rc.25",
"vue": "2.5.2",
Describe the bug
I use Vux on my project as well, but I need vee-validate to validate form. while I import the vee-validete, I found that all  cannot be edited, but work normally while I refresh the page. That is to say that users have to refresh the page at a time when they access the page first time so they can edit .Is this vee-validate conflict with Vux?
To Reproduce
Steps to reproduce the behavior:

First time access the form
I cannot edit any
I refresh the page
all  can be edited normally

Expected behavior
I hope that all  can be edited no matter when users access the page
Demo Link

Desktop (please complete the following information):

windows
chrome
68.0.3423.2

I use Vuex with vee-valiate and haven't had these problems. Can you reproduce the issue on a codepen?

Take a look at those issues: #1559 #1055 #1281
I would be able to help more if you can provide me with a demo to your issue, try to keep the code to a minimum, for example styling and additional logic do not contribute to your issue, so keep the example minimal if you can.


tests: moving the Heroku DB link to GitHub actions secrets.

We must add the E2E_DB_URL to GitHub actions secrets before running the actions workflow for this PR

Will this affect the ability for the community to have tests run for their PRs?

This change will break the tests in the local and forked repos actions.
I added the fixes here #211 another PR as @andrewicarlson asked me to split my code.
to open a PR from AhmedElywa:tests/db-url to AhmedElywa:main I must have the E2E_DB_URL  added in my repo as a actions secrets

@andrewicarlson the test has an error because you need to add the E2E_DB_URL to this repo actions secrets

The action secret will be added to this repo so anyone who opens a PR from his repo to this one will go successful.

So "yes" it will :/
How are community contributions planned to be merged then?

The action secret will be added to this repo so anyone who opens a PR from his repo to this one will go successful.

So "yes" it will :/
How are community contributions planned to be merged then?

I said on my comment before if the contributors opened the pr from there repo to this repo as the current pr we talking on it will go successfully
If the want to merge branches on there repo they want to create a free postgresql from heroku to add on there repo actions.
On local he need to have a test postgresql on his machine to test with.
As i mentioned before I have the way to run tests outside this repo actions on the PR #211

And I found that if you have more than one test run simultaneously for more than one PR. The DB connection limit will close the DB.

@AhmedElywa if we move this connection string to GitHub secrets then any forked repository will not be able to issue PR's and run the tests using that GitHub secret:

Note: With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.

What are some other ways we could solve this problem? Do we need to use PostgreSQL for this? Would it be possible to start a docker container in the test runner? etc.

@AhmedElywa if we move this connection string to GitHub secrets then any forked repository will not be able to issue PR's and run the tests using that GitHub secret:

Note: With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.

What are some other ways we could solve this problem? Do we need to use PostgreSQL for this? Would it be possible to start a docker container in the test runner? etc.

I tested it only on my repo.
about docker @jasonkuhrt have a note into the CONTRIBUTING we can not use docker.
I can search for another way and see what I can do.

As we discussed, we can't use this solution action secrets, so I will close this PR.


add cmp zero init and new flash chip

Problem: MCU bk7238, firmware changed bit CMP to 1 and i can't program memory from bk7231tools.
I added new SR size(for my flash) and CMP zero init, it's work for me now.

Thanks for the fix. Could you explain in which scenarios does it not work before applying this fix?
I'm trying to understand if this PR will fix an unprotection issue we've been seeing for a long time, where writing wouldn't work if the device was in a boot loop.

bk7231tools can't erase memory if CMP bit was previously set to 1.
bk7231tools write_flash ~/firmware -B -d /dev/tty.usbserial-B003BKOO -b 2000000
Unknown bootloader CRC - 0x6BEB0924 - please report this on GitHub issues!
Reading 4k page at 0x011000 (0.00%)
BK72xx connected - protocol: FULL, chip: BK7238, bootloader: None, chip ID: 0x7238, boot version: None
Connected! Chip info: BK7238 / Flash ID: 85 20 15 / Flash size: 0x200000 / Protocol: FULL
Writing 1314315 bytes to 0x0
Trying to unprotect flash memory...

    )
ValueError: Erase failed - flash protected; found non-0xFF bytes @ 0x0

Thanks. Could you also attach a stock firmware dump from the device? It could help with further support for this chip.

@kuba2k2 Bootloader dump is the same as here: https://github.com/tuya-cloudcutter/bk7231tools/issues/23#issuecomment-2059849794


Unit Test Failure in Text Classifier on Python 2.7/3.6

The following unit test failed on this build:
________________ TextClassifierCreateTests.test_validation_set _________________
self = <turicreate.test.test_text_classifier.TextClassifierCreateTests testMethod=test_validation_set>
    def test_validation_set(self):
        train = self.data
        valid = self.data

        # Test with a validation set
        model = tc.text_classifier.create(train, target='rating', validation_set=valid)
        self.assertTrue('Validation Accuracy' in model.classifier.progress.column_names())

        # Test without a validation set
        model = tc.text_classifier.create(train, target='rating', validation_set=None)
        self.assertTrue('Validation Accuracy' not in model.classifier.progress.column_names())

        # Test 'auto' validation set
        big_data = train.append(tc.SFrame({
            'rating': [5] * 100,
            'place': ['d'] * 100,
            'text': ['large enough data for %5 percent validation split to activate'] * 100
        }))
        model = tc.text_classifier.create(big_data, target='rating', validation_set='auto')
>       self.assertTrue('Validation Accuracy' in model.classifier.progress.column_names())
E       AssertionError: False is not true
turicreate/test/test_text_classifier.py:182: AssertionError

As an update, this just repro’ed on Python 3.6 in this build: https://travis-ci.com/apple/turicreate/jobs/183295142

I finally figured out what's going on here. The data in this unit test is only 106 rows. So the random_split(.95) used to generate the validation split will occasionally (one time out a couple hundred) generate an empty validation set. When this happens the unit test fails.
We could fix this by just making the unit test run with a greater number of rows. However I think this intermitent failure is a legitimate problem. If the validation_set parameter is set to auto and you have enough data, you should always get a validation set. It also seems wrong that if you create two different model with the exact same data, you'll likely get slightly different sized validation sets. When we do auto validation splits I think we should require an exact split.


Request parm with no value being stripped

I have a CXF web service that I'm trying to put behind a Zuul proxy.  The URL to request the WSDL looks like (/api/foo?wsdl).  When I request it through Zuul, it fails and it appears to be because Zuul isn't passing the ?wsdl because it doesn't have a value (e.g. ?wsdl=bar).   This is with Zuul 1.0.28, the one we get from spring-cloud-starter-zuul:1.0.2.RELEASE.

I would raise an issue here before bringing this straight to Netflix.  There are custom filters there that might actually be the problem, not zuul itself.

OK, thanks, I'll try that.  I was trying to spot the point in the code that makes the proxy request.  Is that standard Zuul or is it something added by a Filter?

I found the problem.  It's in HTTPRequestUtils.getQueryParams().  I'll submit a patch soon.

Pull Request submitted:  https://github.com/Netflix/zuul/pull/142

I built a 1.1.0-SNAPSHOT on Oct 3 to get this patch and it worked fine. However, after bumping to official 1.1.0 release, it no longer works again. Could this be caused by a regression later in the 1.1.0?
I'm also using Spring Cloud Netflix. Neither spring-cloud-starter-zuul:1.0.4.RELEASE or 1.1.0.M1 works with zuul-core-1.1.0. But if go back to my zuul-core-1.1.0-SNAPSHOT again it does in fact work for both spring cloud versions.

The fix you submitted in PR #142 appears intact in the 1.1.0 release. I've just been looking over the changes between yours and the release and I don't see anything glaring that would conflict with the updated HTTPRequestUtils. I've just run a simple test locally hitting a url of the same form (?wsdl) with 1.1.0 and it doesn't strip out the param. I'm not familiar with how zuul gets set up in spring cloud but perhaps there is something going on in one of the spring cloud filters that strips such params? A cursory clicking through the spring cloud starter code on github hasn't yielded me any insight into what might be going on.

Yes, you are right. I seems there was something else in 1.1.0 between Oct 3 snapshot and final that broke spring-cloud-zuul. It looks like it is fixed in latest spring-cloud snapshot though


[v2] blog rss feed

Tip: This task is targeted towards potential contributor to Docusaurus project.
🚀 Motivation
We need to generate blog rss feed in v2
Where to start

Fork the repository and create your branch from master.
Clone the repository
yarn install in the root of the repo
The related codes for the blog plugin is https://github.com/facebook/docusaurus/tree/master/packages/docusaurus-plugin-content-blog
To run docusaurus 2 website, run yarn start at root
To build docusaurus 2 website, run yarn build at roo
Propose a fix and send a Pull Request :)

P.S: make sure to comment on this issue first and propose a solution before working on a fix
Have you read the Contributing Guidelines on issues?
Yes

@endiliey This issue is still open?

@faelribeiro22 yep it is. wanna work on it ? 😉

Is the idea here to pretty much follow the logic used in the plugin-content-blog but instead of pushing posts to paginated results create an RSS feed (potentially using rss or feed package)?

yep. @moozzyk

I will try to tackle this then.
On Thu, Oct 24, 2019 at 9:39 PM Endi<EMAIL_ADDRESS>wrote:

yep. @moozzyk https://github.com/moozzyk
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/docusaurus/issues/1698?email_source=notifications&email_token=AAK7JJFDMXJH7OYKSJAGEADQQJZ6ZA5CNFSM4IGNT4A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECHFAUY#issuecomment-546197587,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAK7JJABE2VB2E2O5NX4AULQQJZ6ZANCNFSM4IGNT4AQ
.


Hex Colors: Possible Error

I believe I have found a small error in the way hex colors are handled in CNFGColor. Specifically, from my testing, the red and blue values seem to be swapped.
For example, a color 0x0066ff in RGB should have no red, some green, and show up dominantly blue (can confirm with an online color picker such as https://www.w3schools.com/colors/colors_picker.asp). However, using CNFGColor results in an orange color being displayed.
If I mix around the hex number I give it, and instead feed BGR like 0xff6600, I get the blue I intended.
Checking the relevant code snippet confirms this (CNFGFunctions.c, line 339):
uint32_t CNFGColor( uint32_t RGB )
{
        unsigned char red = RGB & 0xFF;
        unsigned char grn = ( RGB >> 8 ) & 0xFF;
        unsigned char blu = ( RGB >> 16 ) & 0xFF;
        glColor3ub( red, grn, blu );
        return RGB;
}

As seen in this snippet, the 0xFF mask is being applied to the RGB value. In effect, it states:
red = (RR GG BB) * (00 00 11) = BB

The variable red is being filled with the blue values of the color. grn, being in the middle, is filled correctly. Finally, blu ends up receiving the red value.
I wanted to put this here in case my logic is somehow flawed or in case there is an underlying reason this is being processed this way. If you like, I can send a PR with the (very minor) edit - otherwise, it should just consist of swapping red and blu:
uint32_t CNFGColor( uint32_t RGB )
{
        unsigned char blu = RGB & 0xFF;
        unsigned char grn = ( RGB >> 8 ) & 0xFF;
        unsigned char red = ( RGB >> 16 ) & 0xFF;
        glColor3ub( red, grn, blu );
        return RGB;
}

Thank you for this awesome project, and I look forward to hearing from you.

Hey, I never noticed but can confirm that your logic is correct, it is interpreted as BRG. It is possible that you are the first to notice this since in cnping for example we have 0xFF as red which looks good if you don't pay attention but actually that is interpreted as 0x0000FF which I wouldn't expect to come out red if you write it like that.
Let's see what @cnlohr thinks about this, I could cover updating cnping if we were to fix it.

Note that we have this in two places:
https://github.com/cntools/rawdraw/blob/20fe61dd0f03b1cce870d1e7d1daa2a139505925/CNFGFunctions.c#L339-L346
This seems to convert BRG to RGB for Xlib:
https://github.com/cntools/rawdraw/blob/20fe61dd0f03b1cce870d1e7d1daa2a139505925/CNFGXDriver.c#L481-L490

OSNAP Not sure why I am just seeing this now!

But YES this is the correct behavior, colors are interpreted as 0xAABBGGRR is how it's written out in C.  I don't remember the origination of this, but it is a common way to represent it.  That said I am willing to change!  I am about to do a big refactor. Let's see what others have to say.

Interesting, the more people I am talking to the more this is becoming evident. I believe I will switch this behavior.

We switched.  It is now 0xRRGGBBAA


Error: Couldn't launch the stream

Some weird stuff is happening. GUI works ok. But there's this minor thing:

Stream is launching and working alright though. When I click "Close" stream closes in the player.
Cant find where or why use "cvlc"
Win 8.1 x64, VLC 2.2.1 x64, livestreamer 1.12.2

The reason why you are seeing this error message is VLC. Livestreamer is just passing through the VLC error message to stdErr (the GUI is then reacting to this), but it's still able to launch the stream because it's just a warning message of VLC. When clicking close, the GUI will terminate the livestreamer process which will also kill the video player.
This means that you need to fix your VLC in order to get through the launch dialog... Do you have any VLC plugins/skins installed which may be causing this issue?

No skins or plugins, just reinstalled it yesterday. Will try x32 version.

Well, I can't help you here... Just try a different video player then.


Add script to import reports from Konveyor hub

Still TODO:

[x] Use inventory API to retrieve credentials for private repos
[ ] Documentation
[ ] Tests

I am testing with konveyor deployed with this CR:
apiVersion: tackle.konveyor.io/v1alpha1
kind: Tackle
metadata:
  name: tackle
  namespace: konveyor
spec:
  analyzer_fqin: quay.io/jortel/tackle2-addon-analyzer:kai-support
  feature_auth_required: "false"
  hub_image_fqin: quay.io/jortel/tackle2-hub:kai-support

To load the sample data into an unauthenticated konveyor instance, run
$ ./samples/add_data_to_hub.py {your hub url} -k

To start the importer, run:
$ make run-konveyor-importer HUB_URL={your hub url} IMPORTER_ARGS='--skip-verify'

I ran through the process this morning without problems other than environment issues addressed in separate documentation PR.


Created norwegian translation (no.yml)

Thank you, uploaded new no.yml

thank you all for the new language file :)


RHIDP-1149: Enable Auto Logout feature by default, provide configuration options and documentation

Description

Modified packages/app/src/components/AppBase/AppBase.tsx to include the AutoLogout component, enables by default and includes the defaults recommended by Backstage.
Modified app-config.yaml to include options to modify the Auto Logout feature using environment variables.
Updated showcase-docs/getting-started.md to include information about Secure by Default, having the Auto Logout feature enabled by default, and how to modify that configuration.

Which issue(s) does this PR fix

Fixes #664

PR acceptance criteria
Please make sure that the following steps are complete:

[ ] GitHub Actions are completed and successful
[ ] Unit Tests are updated and passing
[ ] E2E Tests are updated and passing
[x] Documentation is updated if necessary (requirement for new features)
[ ] Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer
The Auto Logout feature does not work using the Guest login and was tested using the Github login feature.

/assign @kadel

I took a moment to try this locally but when running yarn start I see this error; maybe this dependency comes from the autologout component and just needs to be added to the package.json.

I took a moment to try this locally but when running yarn start I see this error; maybe this dependency comes from the autologout component and just needs to be added to the package.json.

Never mind this, gave it another try and didn't have this error again.  Autologout feature worked for me too, great!

/hold
According to https://github.com/backstage/backstage/issues/22692#issuecomment-1934834380, the AutoLogout feature may introduce a false sense of security and not actually completely log the user out. Further investigation may be needed, or this may not be worth enabling.

6 months later this is still unmerged, so I'm going to close it for now. @coreydaley if that's an error, LMK and/or please reopen it.


Commits for new versions not in Github

Hey guys, I noticed when I try to diff the newest versions (1.6.4) with the older ones (1.4.0), I see an empty diff, how can I see what changed from these two versions? I'm doing an investigation about a problem we've had recently.

@yasuf The releases were tagged. You can find all commit between the 2 versions you mentioned via the following command:
git log v1.4.0..v1.6.4

Alternatively, you can use GitHub: https://github.com/public-activity/public_activity/compare/v1.4.0...v1.6.4

Closing as answered :)


Default machine image without version to latest non-preview version

How to categorize this PR?

/area operations
/kind bug
/priority normal
What this PR does / why we need it:
Properly default machine image without version to latest non-preview version.
Otherwise, Shoots that are created without a machine image or without a machine image version will get defaulted to a preview versions.
Preview versions should always be opt-in, as they are not deemed "stable" by the Gardener Operator.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

Fixes a bug that could lead to defaulting a  machine image of a Shoot to a preview version.

@tim-ebert, maybe for release 1.7?


Update docs - run python manage.py migrate once

We have to run python manage.py migrate once, in order to create the necessary tables for the postgres search backend.
Otherwise we get an error, as the insert in the table is not possible.
Thanks for contributing to Wagtail! 🎉
Before submitting, please review the contributor guidelines http://docs.wagtail.io/en/latest/contributing/index.html and check the following:

Do the tests still pass? (http://docs.wagtail.io/en/latest/contributing/developing.html#testing)
Does the code comply with the style guide? (Run make lint from the Wagtail root)
For Python changes: Have you added tests to cover the new/fixed behaviour?
For new features: Has the documentation been updated accordingly?

Thanks @bauersebastian! Merged in 49d706b (master) and 793b42e (1.10.x).


ROX-17224: use correct Prometheus client CA signer

Description
I noticed that I used the wrong signer in #6796 and found an interesting behavior of the TLS config holder. If no client CAs have been found, it defaults to ClientAuth = NoCertGiven, which is why the wrong signer had no effect. I changed this behavior for the secure metrics endpoint to RequireAndVerifyClientCert. I can't really say if the existing behavior makes sense for Central mTLS, so I left it as is - only made it explicit.
I also added a test to verify that the client auth is not changed if no suitable client CA has been found.
Excerpt from the CA and client cert to make sure it's correct this time:
Client CA:
Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number:<PHONE_NUMBER>925119782 (0x7a8f3e7c8af6a926)
    Signature Algorithm: sha256WithRSAEncryption
        Issuer: CN=openshift-kube-controller-manager-operator_csr-signer-signer@1688457768
        Validity
            Not Before: Jul  4 08:04:45 2023 GMT
            Not After : Aug  3 08:04:46 2023 GMT
        Subject: CN=kube-csr-signer_@1688457885
...

client cert:
Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number:
            63:58:e3:73:2d:9b:c4:f1:ef:d3:cd:cd:9d:35:99:e9
    Signature Algorithm: sha256WithRSAEncryption
        Issuer: CN=kube-csr-signer_@1688457885
        Validity
            Not Before: Jul  4 11:19:38 2023 GMT
            Not After : Aug  3 08:04:46 2023 GMT
        Subject: CN=system:serviceaccount:openshift-monitoring:prometheus-k8s

Checklist

[ ] Investigated and inspected CI test results
[x] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

Current dependencies on/for this PR:

master

PR #6846   👈

PR #6858

This comment was auto-generated by Graphite.

After discussion with @dhaus67 I added two changes:

ConfigMapWatcher.init now attempts to get the config map. It's executed on the main loop and is therefore always executed before the server is started. If the get fails, we log the error and continue.
Added timeouts to k8s calls in ConfigMapWatcher to prevent blocking the main loop.

/retest


WIP: Add environment variables

I'm evaluating this plugin for packaging and in particular for creating msi installers for Windows. I've set up a testing project that uses this plugin. You're plugin is doing a great job, thanks!
I have run into an issue however with updating the images used in the Windows installer. It is possible to ship a custom main.wxs file with the plugin using the resourceDir option. That file in turn offers the ability to set custom images. In order to resolve such images relative to the project, one needs some way to know about the Gradle project. In the testing project, I'm current using a workaround using the PWD environment variable which is however hackish and not portable (works on MinGW but not on Window's native shell).
Therefore, I suggest to pass the Gradle project directory as well as the build directory to the jpackage task as environment variables. Like that, it should be easy for custom files such as the modified main.wxs to resolve additional resources provided by the project.
I've marked this pull request work in progress as it is based on #17 which is not merged yet.

In case it's not obvious which images I'm talking about that I'd like to exchange, it's those one here with on the left hand side of the first image and the banner at the top of the second image:

Implemented in a generic way, see 1.4.0.

Thanks for your quick reaction and this improved implementation. Works like a charm now!


Krishna Kumar blogpost

'My Code For Nepal Data Fellowship Experience as an Actuarial Science'

There is problem with the mets tag that I have added


add DDEV_DATABASE_PROTOCOL variable

The Issue
I want to generate database resource URLs for use in code and DDEV addons.
Currently, DDEV exposes DDEV_DATABASE which is  app.Database.Type + ":" + app.Database.Version,.
This is difficult to use because it must be parsed, and converted (MariaDB uses mysql protocol).
How This PR Solves The Issue
This PR adds a new environmental variable: DDEV_DATABASE_PROTOCOL

Defaults to mysql
Set to postgres if database is postgres

Manual Testing Instructions

Start a DDEV project
Type ddev exec set | grep DDEV_DATABASE to check currently set database variables

Automated Testing Overview

Related Issue Link(s)
Fixes #4954
Release/Deployment Notes

Look at you go!

Sorry for the noise. Finally added a "GO" addon to VScode for proper syntax highlighting etc.

And you have to add the new variable to the docker-composer template pkg/ddevapp/app_compose_template.yaml.

OK. That was the piece I was missing.

Error: File is not gofmt-ed with -s (gofmt)

Not sure why the golint test is failing.

Error: File is not gofmt-ed with -s (gofmt)

Not sure why the golint test is failing.

You just miss two spaces at the mentioned line.

Congratulations and thanks!


Unable to find native implementation, or alternative implementation for WebSocket!

I have extended the with-apollo-redux example of next and using subscriptions-transport-ws for the web sockets. But sockets are not working and getting this error

Error: Unable to find native implementation, or alternative implementation for WebSocket!
    at new SubscriptionClient (/home/user/Documents/projects/next-os/node_modules/subscriptions-transport-ws/src/client.ts:95:13)
    at create (/home/user/Documents/projects/next-os/.next/dist/lib/initApollo.js:21:18)
    at initApollo (/home/user/Documents/projects/next-os/.next/dist/lib/initApollo.js:56:12)
    at new WithData (/home/user/Documents/projects/next-os/.next/dist/lib/withData.js:165:47)
    at /home/user/Documents/projects/next-os/node_modules/react-dom/lib/ReactCompositeComponent.js:294:18
    at measureLifeCyclePerf (/home/user/Documents/projects/next-os/node_modules/react-dom/lib/ReactCompositeComponent.js:75:12)
    at ReactCompositeComponentWrapper._constructComponentWithoutOwner (/home/user/Documents/projects/next-os/node_modules/react-dom/lib/ReactCompositeComponent.js:293:16)
    at ReactCompositeComponentWrapper._constructComponent (/home/user/Documents/projects/next-os/node_modules/react-dom/lib/ReactCompositeComponent.js:279:21)
    at ReactCompositeComponentWrapper.mountComponent (/home/user/Documents/projects/next-os/node_modules/react-dom/lib/ReactCompositeComponent.js:187:21)
    at Object.mountComponent (/home/user/Documents/projects/next-os/node_modules/react-dom/lib/ReactReconciler.js:45:35)

This is my initApollo.js
import ApolloClient, { createNetworkInterface } from 'apollo-client';
import { SubscriptionClient, addGraphQLSubscriptions } from 'subscriptions-transport-ws';
import { GRAPHQL_PATH, WS_PATH } from '../server/config';

let apolloClient = null;

function create() {
  const wsClient = new SubscriptionClient(WS_PATH, {
    reconnect: true,
  });
  const networkInterface = createNetworkInterface({
    uri: GRAPHQL_PATH,
    opts: {
      credentials: 'same-origin',
    },
  });
  const networkInterfaceWithSubscriptions = addGraphQLSubscriptions(
    networkInterface,
    wsClient
  );
  const client = new ApolloClient({
    dataIdFromObject: o => o.id,
    networkInterface: networkInterfaceWithSubscriptions,
  });
  networkInterface.use([
    {
      applyMiddleware(req, next) {
        if (!req.options.headers) {
          req.options.headers = {};  // Create the header object if needed.
        }

        // get the authentication token from local storage if it exists
        const token = localStorage.getItem('sessionToken');
        req.options.headers.Authorization = token ? `${token}` : null;
        next();
      },
    },
  ]);
  return client;
}

export default function initApollo() {
  // Make sure to create a new client for every server-side request so that data
  // isn't shared between connections (which would be bad)
  if (!process.browser) {
    return create();
  }

  // Reuse client on the client-side
  if (!apolloClient) {
    apolloClient = create();
  }

  return apolloClient;
}

Your Environment

Tech
Version

next
latest

node
7.10.0

OS
Ubuntu 16.0.4

browser
Chrome

Most likely on SSR I guess?

Yes, But as per my understanding this is an Higher Order Component which renders on client side?

@ads1018 any ideas 🤔

Hey @saadbinsaeed. @detrohutt managed to get subscriptions working with the next-apollo example. Here's the gist he shared of the changes he made to support support subscriptions. Hope this helps. https://gist.github.com/detrohutt/3bddfe943a2f3ef2a797a6f7870049e8

Looks like you're enabling subscriptions on the server. You want to make sure to only enable on the client.

Thanks @ads1018 ❤


Expose ignoreCreationTime flag for rescan

This works for me! Just a small UI bug on my machine

Translation added


[stable/rabbitmq] NodePort may not be used when type is ClusterIP

Describe the bug
This bug surfaces when the chart is installed with a LoadBalancer service then upgraded to change the service type to ClusterIP.
When a LoadBalancer service is created Kubernetes configures a NodePort for the service behind the scenes. Unfortunately Kubernetes fails to remove or blank out the NodePort value when changing the service to ClusterIP.
A work around for this is to define a default nodePort value in values.yaml set to an empty string and always set the nodePort property in the service regardless of service type.
Version of Helm and Kubernetes:
jharris@jharris-XPS-15-9570:~/Repository/kops.rabbitmq$ kubectl version
Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.3", GitCommit:"2d3c76f9091b6bec110a5e63777c332469e0cba2", GitTreeState:"clean", BuildDate:"2019-08-19T11:13:54Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.2", GitCommit:"f6278300bebbb750328ac16ee6dd3aa7d3549568", GitTreeState:"clean", BuildDate:"2019-08-05T09:15:22Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"linux/amd64"}

jharris@jharris-XPS-15-9570:~/Repository/kops.rabbitmq$ helm version
Client: &version.Version{SemVer:"v2.14.3", GitCommit:"0e7f3b6637f7af8fcfddb3d2941fcc7cbebb0085", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.14.3", GitCommit:"0e7f3b6637f7af8fcfddb3d2941fcc7cbebb0085", GitTreeState:"clean"}

Which chart:
stable/rabbitmq
What happened:
[Executing] helm upgrade rabbitmq stable/rabbitmq -i -f overrides.dev.yaml --namespace core-cloud
UPGRADE FAILED
Error: Service "rabbitmq" is invalid: [spec.ports[0].nodePort: Forbidden: may not be used when `type` is 'ClusterIP', spec.ports[1].nodePort: Forbidden: may not be used when `type` is 'ClusterIP', spec.ports[2].nodePort: Forbidden: may not be used when `type` is 'ClusterIP', spec.ports[3].nodePort: Forbidden: may not be used when `type` is 'ClusterIP']
Error: UPGRADE FAILED: Service "rabbitmq" is invalid: [spec.ports[0].nodePort: Forbidden: may not be used when `type` is 'ClusterIP', spec.ports[1].nodePort: Forbidden: may not be used when `type` is 'ClusterIP', spec.ports[2].nodePort: Forbidden: may not be used when `type` is 'ClusterIP', spec.ports[3].nodePort: Forbidden: may not be used when `type` is 'ClusterIP']

What you expected to happen:
Expected the deployment to succeed when I ran helm upgrade to change my LoadBalancer service to ClusterIP.
How to reproduce it (as minimally and precisely as possible):
Create overrides.bug.yaml
service:
  type: LoadBalancer

rabbitmq:
  username: telemetry
  password: rabbitmqpassword

Install the chart using the overrides file.
helm upgrade rabbitmq-bug stable/rabbitmq -i --namespace rabbitmq-bug -f overrides.bug.yaml
Verify everything came online successfully.
jharris@jharris-XPS-15-9570:~/Repository/kops.rabbitmq$ kubectl get all -n rabbitmq-bug
NAME                 READY   STATUS    RESTARTS   AGE
pod/rabbitmq-bug-0   1/1     Running   0          29s

NAME                            TYPE           CLUSTER-IP      EXTERNAL-IP   PORT(S)                                                         AGE
service/rabbitmq-bug            LoadBalancer   <IP_ADDRESS>   <pending>     4369:30724/TCP,5672:31589/TCP,25672:31707/TCP,15672:31752/TCP   29s
service/rabbitmq-bug-headless   ClusterIP      None            <none>        4369/TCP,5672/TCP,25672/TCP,15672/TCP                           29s

NAME                            READY   AGE
statefulset.apps/rabbitmq-bug   1/1     29s

Change the overrides configuration to declare the service as ClusterIP.
service:
  type: ClusterIP

rabbitmq:
  username: telemetry
  password: rabbitmqpassword

Upgrade the same release with the updated configuration.
jharris@jharris-XPS-15-9570:~/Repository/kops.rabbitmq$ helm upgrade rabbitmq-bug stable/rabbitmq -i --namespace rabbitmq-bug -f overrides.bug.yaml
UPGRADE FAILED
Error: Service "rabbitmq-bug" is invalid: [spec.ports[0].nodePort: Forbidden: may not be used when `type` is 'ClusterIP', spec.ports[1].nodePort: Forbidden: may not be used when `type` is 'ClusterIP', spec.ports[2].nodePort: Forbidden: may not be used when `type` is 'ClusterIP', spec.ports[3].nodePort: Forbidden: may not be used when `type` is 'ClusterIP']
Error: UPGRADE FAILED: Service "rabbitmq-bug" is invalid: [spec.ports[0].nodePort: Forbidden: may not be used when `type` is 'ClusterIP', spec.ports[1].nodePort: Forbidden: may not be used when `type` is 'ClusterIP', spec.ports[2].nodePort: Forbidden: may not be used when `type` is 'ClusterIP', spec.ports[3].nodePort: Forbidden: may not be used when `type` is 'ClusterIP']

Anything else we need to know:
This bug is present with a lot of Helm charts.
A temporary work around is to delete the helm release helm delete --purge or install the updated chart to a new release.

Hi,
Sorry for the delay. I created this PR that fixes the issue


Missing branches using Jacoco

I'm developing some unit tests for my project realm and embedded realm objects and I'm facing the following issues on the resulting JaCoCo report:

All classes claim to have a missing branch on the following element. I have tried different approaches but nothing solves this.

On setters and getters it claims that exists a missing branch but I have tried all different initialization combinations (i.e., empty constructor and constructor with different values)

I would like some help on this to increase my code coverage since it's really something that is upsetting me, and I'm starting to consider replacing Realm for Room in my projects.

Most likely you need a managed RealmObject for those branches.
We change the getters and setters under the hood to either go into the database or read from the in-memory object. It is described here: https://github.com/realm/realm-kotlin/blob/master/packages/plugin-compiler/src/main/kotlin/io/realm/kotlin/compiler/AccessorModifierIrGeneration.kt#L544

If you can post a unit test, it is probably easier to see exactly which branches you might be missing?

If you can post a unit test, it is probably easier to see exactly which branches you might be missing?

I was only trying to unit test the objects isolated. I let here a simple example testing the email field of an User realm object.
@Test     funtest email empty`() {
val objectInTest = CacheUser()
    objectInTest.run {
        objectInTest.email = ""
    }
}

@Test
fun `test email not empty`() {
    val expectedEmail =<EMAIL_ADDRESS>
    val objectInTest = CacheUser().apply {
        email = expectedEmail
    }

    objectInTest.run {
        objectInTest.email = expectedEmail
    }
}

`

Yes, those unit tests will miss our "managed" branches. If you do something like this, it should cover both:
   @Test
    fun testEmailEmpty() = runBlocking {
        val realm: Realm = getRealm()
        val objectInTest = CacheUser()
        val managedObj: CacheUser = realm.write {
           copyToRealm(objectInTest)
        }
        assertEquals(objectInTest.email, managedObj.email)
    }

Yes, those unit tests will miss our "managed" branches. If you do something like this, it should cover both:
   @Test
    fun testEmailEmpty() = runBlocking {
        val realm: Realm = getRealm()
        val objectInTest = CacheUser()
        val managedObj: CacheUser = realm.write {
           copyToRealm(objectInTest)
        }
        assertEquals(objectInTest.email, managedObj.email)
    }

I have tried to implement that approach but I ran into the following problem:
Caused by: java.lang.NullPointerException: RELEASE must not be null

With a quick search I noticed that this problem was already noticed by you and you have an open issue with Jetbrains. But my solution for now is to ignore the realm and embedded realm objects from JaCoCo reports and testing them through instrumented tests.
Anyway, thanks for your availability!


Can't Break/Place Blocks

HI! I'm a server Admin and we have a problem. Pex Preventing Players from placing and breaking block. here our permission.yml:
] Edit by Stormbow: Removed permissions.yml paste since the formatting was ruined anyway. Please post it to Pastebin and leave a link in this thread. [

actually, your file doesn't work at all because of several major errors in the formatting.  (And use Pastebin to post your file contents.  The formatting is ruined by posting it here.)
• Schema-version line goes above the "users:" section.  This is the more important of the 2 errors mentioned here.
• Empty permission sets should be "permissions: []" not what you have shown above.
Once you've corrected these 3 errors (Pastebin being important too), I can look at your file for additional errors, but I'm fairly certain fixing the 2 bullet points above will solve your problem.

@Stormbow ok thx but what about the main problem?

Fix the errors mentioned above.  Does the "main problem" still exist?  ;)

You can also reference this example of a "proper"/"full" permissions.yml file.

@Stormbow i fixed the problems and its still does that heres the paste.bin link : http://pastebin.com/1D1GsbSp

Ok, permissions.yml file is fixed.  Pastebin your server.properties file for me next please.  (Can be opened in Notepad to copy and paste over to Pastebin.)

@Stormbow heres the server properties (removed ip and port sorry XD) http://pastebin.com/WLycKv7S

@Stormbow I don't have modifyworld.jar, what it is? and where do i get it?

That would be the problem. :)  You gave the first group "modifyworld.*" and you don't even have a plugin that requires that permission? heh
Modifyworld

@Stormbow i thought i was part of  Pex XD

Also, change your spawn-protection from 16 to 0.  That's more of a vanilla/no plugins server setting that interferes with custom servers.

@Stormbow it still not working, i downloaded the Modifyworld plugin and i still can break/place blocks

"Can"  break/place is what you "do" want.  Isn't it?  The original post of this thread implied "can not" break/place...

can't* sorry

@Stormbow i've noticed something weird, when i restart the server and join it, i can't break any blocks, but when i reload, i can.

Well, when you stop the server entirely, it reloads everything when restarted.  ;p
So, problem solved?

@Stormbow no it;s still don't

Ok, time to debug.
While in-game, type: /pex user RoBaMe toggle debug
Without moving or doing anything else, attempt to break a block
Type the above command again to turn off debugging
Look in your console and copy from when you turned on debug to where you turned it off
Pastebin that mess; leave the link in this thread

im uploading a gif for you to see what's happaning

@Stormbow heres the pastebin

No link

@Stormbow there is

There's nothing clickable above this.

Which version of Minecraft are you using?
Which version of PEX are you using?
Pastebin your server console startup log (from the moment you begin starting the server thru the point where the console says "done!")

@Stormbow http://pastebin.com/KkHgq5uC

That's not a full server startup log...  O_o;  It doesn't show you have PermissionsEx or Modifyworld installed.

it is +_+, and this is the reload log : http://pastebin.com/UK40khJm

@Stormbow look this is what happaning - http://makeagif.com/t7nQCX

This is my server log: http://pastebin.com/H8HTuGBm

YOU'RE VANISHED!

Of course you can't interact with any blocks!

@Stormbow OOPS!!! XD MY BAD LOLOL

LOL  Make sure your group (or you're user) gets - -vanish.silentjoin and a couple other vanish-related permissions negated, and make sure those negations are -above- the wildcard '*' for the group.

ok THX for the HELP!!! REALLY!

You're welcome. :)

These are all the negations I use on my server:
- -vanish.effects.smoke
- -vanish.effects.explode
- -vanish.effects.lightning
- -vanish.effects.flames
- -vanish.effects.bats
- -vanish.silentjoin
- -vanish.silentquit


feat: Implement Task Queues for image processing

Setup Celery workers and tasks
Integrate tasks into image route
Implement Status checking with SSE

Nice work

Thank you, Boss


Changing order of ids in has_and_belongs_to_many field is not saved

When setting an _ids field of a has_and_belongs_to_many to a new array with the same elements as before but a different order, and then calling save, it's not persisted. When reading it later, the order is still as it was before.
Example:
class A
  include Mongoid::Document
  has_and_belongs_to_many :bs
end

class B
  include Mongoid::Document
end

And then:
b1 = B.create
b2 = B.create
a = A.create
a.b_ids = [b1.id, b2.id]
a.save

a.b_ids = [b2.id, b1.id]
a.save

a_reread = A.find(a.id)
a_reread.b_ids  #=> is [b1.id, b2.id], but should be [b2.id, b1.id]

When changing it directly via MongoDB shell, the order is correct (and Mongoid returns them in the new order).
My use case is that the user ranks a bunch of entries by ordering them, which should be persisted as an array of ids in mongo. So, preserving order is kind of important in this case.
Spec coming up.

Thanks for the failing spec!


Landscape orientation on phone

Some pages have issues when rendered in landscape mode on a windows 10 phone.
For example the activity detail page, you are unable to view / scroll through the statistics in a good way.
I would rather suggest to block landscape mode, most of the layout is designed with portrait in mind.

I'm not opposed to blocking landscape.


Test failure: com.github.ambry.router.UndeleteManagerTest > basicThroughRouterTest

com.github.ambry.router.UndeleteManagerTest > basicThroughRouterTest FAILED
java.util.concurrent.TimeoutException: Timeout after waiting for 10000 ms.
at com.github.ambry.router.FutureResult.get(FutureResult.java:106)
at com.github.ambry.router.UndeleteManagerTest.assertNotDeleted(UndeleteManagerTest.java:356)
at com.github.ambry.router.UndeleteManagerTest.verifyUndelete(UndeleteManagerTest.java:377)
at com.github.ambry.router.UndeleteManagerTest.basicThroughRouterTest(UndeleteManagerTest.java:152)

Another test failure in same class:
com.github.ambry.router.UndeleteManagerTest > responseTimeoutTest FAILED
    java.util.concurrent.TimeoutException: Timeout after waiting for 10000 ms.
        at com.github.ambry.router.FutureResult.get(FutureResult.java:106)
        at com.github.ambry.router.UndeleteManagerTest.assertDeleted(UndeleteManagerTest.java:347)
        at com.github.ambry.router.UndeleteManagerTest.deleteBlobInAllServer(UndeleteManagerTest.java:363)
        at com.github.ambry.router.UndeleteManagerTest.responseTimeoutTest(UndeleteManagerTest.java:292)