Hindia's answer to uc-survey

@Hindia , thank you for submitting your response to the survey. Much appreciated. As we are running under the W3C CG ( https://www.w3.org/community/solid/ ), we just have a minor requirement in that all contributions to the specs/panels etc should come by CG members. We'd love to merge your survey. If you can join, which is free and open to all, that'd be great.
Feel free to add comments elaborating on your interest with the UC at any point.. Thanks again.

Hey @csarven thanks for the info. I have registered as a CG member now.

Hi @Hindia I don't see your name on https://www.w3.org/community/solid/participants
Maybe you missed some confirmation step?

@Hindia still doesn't apprear on https://www.w3.org/community/solid/participants
I think we should either close this PR or reconsider our requirement of CG membership for accepting survey responses.

Hey, I just joined the participants list. My sincere apologies for the delay. I had to sort some things. Thank you for waiting

@Hindia Great to see you join. May I ask a small favour... and rebase this PR with the latest uc-survey.md? I believe there are some new UCs that you might want to respond as well. Thanks!

is this the latest https://github.com/solid/authorization-panel/blob/master/proposals/wac-ucr/uc-survey.md ?

Yes.

https://github.com/solid/authorization-panel/pull/154 superseded this PR.

https://github.com/solid/authorization-panel/pull/154 superseded this PR.


Code refactor improvements

Code refactor improvements
User Story
As a financial advisor,
I want to have a feature to access the Financial Analysis,
so I can see the report on the website.
Acceptance Criteria

It's done when the Financial Analysis outputs in the browser console tool.
It's done when the user can see the same Financial Analysis console output in the website without opening the browser console.

Solution


test(STADTPULS-622): add basic Cypress testing

This PR adds Cypress for integration testing. This includes the configuration of TypeScript and ESLint to work with Cypress.
Some basic test stubs were added as examples.

This article may be a good resource to start with testing canvas elements for our maps. EDIT: The article suggests using cypress-plugin-snapshots which may be an unmaintained project.

Awesome. Love it. Is it mandatory that the cypress files are called _spec? I would vote for .test as well. What do you think?

Is it mandatory that the cypress files are called _spec? I would vote for .test as well

Thanks for the feedback and good idea, @ff6347. _spec is the Cypress default but it's absolutely possible to use something else. I renamed the files in 55e3480.

You need to make sure jest ignores the cypress folder

You need to make sure jest ignores the cypress folder

Yep, Jest already doesn't care about it

Great addition! This should make testing interfaces and user flows much easier. Thx for taking care of that! 👍

@ff6347, I added the Cypress tests to a main.yml workflow. I also did some refactoring to shorten the duration of this workflow by only using one build step instead of two. Let me know if you have advice for shortening the workflow even more.
I also suspect that soon we'll have integration tests that need a lot of time, specifically the ones that access pages with long loading times such as /sensors or /accounts.

I actually use *ByRole intentionally since this way we test against the accessibility tree and not just for users who access Stadtpuls visually. I'm aware that we are far from being accessibility-friendly, but it's good to approach this direction. Btw, this is the recommended query priority by Testing Library itself.

Ah. Okay. Cool. Didn’t know that.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Segmentation fault when closing window or using ctrl+C

Howdy, this is just a comment not exactly a breaking issue.
When i close the opencv window with the mouse or interrupt the code with ctrl+C i get this message:
[03/24/2022-11:42:12] [TRT] [E] 1: [defaultAllocator.cpp::deallocate::35] Error Code 1: Cuda Runtime (invalid argument)
Segmentation fault (core dumped)
But for example when i use the ESC key or if im using a video file and the video ends, the code closes without an error.
Is this related to maybe OpenCV?

This problem seems to be an issue of "not handling GPU resource cleanup properly".
Please specify which demo you are testing with.

Hello, im using trt_yolo.py in Demo 5.

I briefly looked at it and think it's not easy to fix in current code base.
The user could hit Ctrl-C at any point of time, including when context.execute_async_v2() is being executed.  I'm not sure whether it's possible to terminate the tasks and clean up resources properly for all cases...
I'll leave the code as it is now.

Your note for future work is well taken.  Thanks for letting my know this repo is helpful to you.
I'll close this issue, since I will not be tracking it.


Password Requirements in the next line

The Password Requirements can be shown in the next line in bullets for better understating

can you please assign this task to me?

@TanmayKalra09
I hope you’re doing well! I’m interested in working on the issue. I am sharing an image with you; if you want  like it, please assign it to me, and I will make it better. It’s really simple.
Thanks!
Anupam Gupta

can you please assign this task to me?

Don't use bullets. just list the requirements on new line.

can you please assign this task to me?

Don't use bullets. just list the requirements on new line.

Sure, thanks for assigning me the issue

@TanmayKalra09 There is some extra space before the error message. Please resolve it and do the same for all the fields in that form.

@maniyaom, the changes are done.
Please review them and suggest if anything more is required.

@maniyaom, the changes are done. Please review them and suggest if anything more is required.

Done


textView in JSQMessagesCollectionViewCell does not resize to fit text on iPad Popover

I am embedding a JSQMessagesViewController in container view (all 4 edges pinned) within another UIViewController presented as a popover. On iPad, the textView does not resize to fit the text, instead presenting each message on one line, cut off. The screenshot with the blue incoming bubbles was on iPad, the purple one on iPhone.

Hey @scotteg - this shouldn't be happening. bubbles will size within the collection view bounds.
it appears that the frame of the collection view in the popover is wrong. my guess is that the popover isn't configured quite right.
can you provide more info on how you produced this? library version, ios version, etc.

Hi @jessesquires, I'm using JSQMessagesViewController 7.0.1 and iOS 8.3. I'm using the same parent popover class throughout. Seems to work fine everywhere else. The same storyboard, class, and storyboard scene are used for for presenting a contained JSQMessagesViewController on iPhone and iPad. There are no special adaptive layouts implemented for size classes, just pinned constraints to ensure the contained JSQMessagesViewController fills the container; i.e., this is a pretty basic implementation. It displays fine on all iPhone models (and simulator) I've tested, but all iPad models (and simulator) I've tested experience this issue. See attached screenshot of storyboard and let me know if you want to take a look at the class files. Thanks!

Hm... thanks @scotteg !
Could you modify the demo project to reproduce this, and post a link to that branch?

Here's a preliminary demo, in which I can demonstrate that the bubbles get truncated, although the text bubbles are not being compressed to one line. So I believe there is more to the issue:
https://github.com/scotteg/JSQMessagesViewController/tree/demo-issue-947
Steps I took:

Enabled using size classes in order to use the popover presentation I'm using in my app.

Replaced the storyboard contents to replicate the arrangement I'm using in my app:

Console output:
Please check the values return by the delegate.
the behavior of the UICollectionViewFlowLayout is not defined because:
the item width must be less than the width of the UICollectionView minus the section insets left and right values.
Please check the values return by the delegate.
the behavior of the UICollectionViewFlowLayout is not defined because:
the item width must be less than the width of the UICollectionView minus the section insets left and right values.

Changed deployment target to 8.3:

(Same console output)
As I mentioned, there's something more to the issue, because it my app (which is implicitly targeting 8.3), all text bubbles are compressed to one line:

(Same console output)
Yet when I explicitly target 7.0, text bubble are no longer compressed to a single line but they are still truncated; the width being the same (vs. in the demo-issue-947 branch of the demo project) is expected because I am explicitly setting contentSize:

(Same console output)

Thanks @scotteg ! I'll look at this when I can.
New idea: have you tried adjusting messageBubbleLeftRightMargin ?
http://cocoadocs.org/docsets/JSQMessagesViewController/7.0.1/Classes/JSQMessagesCollectionViewFlowLayout.html#//api/name/messageBubbleLeftRightMargin

Adjusting messageBubbleLeftRightMargin did not resolve the issue.

@scotteg awesome! :tada:
thanks for updating the issue! :+1:


Clarify some message-list code (part 2).

EDIT: See https://github.com/zulip/zulip-mobile/pull/4670#issuecomment-821586117 where I mention the cause of the CI failures.

A continued resumption of #3913 (which has grown stale), toward #3851. Part 1 was #4406 .
This PR focuses on the refactor to flatten the funny shape of HtmlPieceDescriptor[], and it has tests specifically aimed at confirming the refactor.
Those tests are snapshot tests, something I think it could be neat to explore. I'd like to know if there's a better file I can put them in (I've made a contentHtmlFromPieceDescriptors-test.js and put them there); they test how getHtmlPieceDescriptors and contentHtmlFromPieceDescriptors work together, not separately. But I don't think I run on enough caffeine to work with a filename that concatenates those names 🤔.

(Blocked for the moment on #4664; I'm taking another look at that now. 🙂)

Ah, hilarious. The CI failure looks like a timezone difference between where I run the tests and where CI runs them:
- Snapshot  - 3
+ Received  + 3

@@ -32,11 +32,11 @@

      Nonrandom name one User

-
7:15 PM

+
11:15 PM

Ah, hilarious. The CI failure looks like a timezone difference between where I run the tests and where CI runs them. I'll have to think of what to do about that.

I guess the thing to do (if we want to keep the snapshot tests) is set the timezone to be the same thing (UTC, probably) wherever the tests get run. But I think we might run into some issues on Windows if we use process.env.TZ = 'UTC' for that: https://github.com/nodejs/node/issues/4230
That issue has a comment mentioning the NPM package https://github.com/capaj/set-tz, which is for setting the timezone on all OSes. On Windows it says "it effectively changes your whole OS timezone so beware" so maybe that's not the best thing to do either. 🤔

(Discussion continuing here.)

Hmm, it's occurred to me that there are a lot of variables that the new snapshot tests could fruitfully test! Like whether consecutive messages were on the same day; whether they were sent by the same user or different users; what kind of narrow we're looking at; what flags messages have, etc.
Do we think we want to draw up a table of transformations we want to apply toward varying those things, then write code to automatically apply all combinations of those transformations? That'd mean tons of snapshots and being a bit overwhelmed with every snapshot failure (since lots of failures would happen at once).

(Pausing work on this while awaiting discussion here.)

Thanks for the review and those commits! Revision pushed.

Thanks for the review! Revision pushed.

Thanks for the revision!
All LGTM except the one small item at https://github.com/zulip/zulip-mobile/pull/4670#discussion_r654678980 . Please merge at will after that.

Thanks for the review! Merged, with that tweak, and one other: in the first commit, we were using __TEST__; I changed this to global.__TEST__ because I just discovered we were getting a ReferenceError: __TEST__ is not defined when running the app and opening the message list.


[qt5-base] Qt5DBus is built with -dbus=runtime on Windows causing dbus-1-3.dll to not be copied to output dir with VCPKG_APPLOCAL_DEPS=ON

Describe the bug
The qt5-base port does not formally list dbus as a dependency, but it will detect it if present and link it on Linux if a consuming application lists dbus as a dependency. On Windows it will use runtime loading of dbus and that means it will not be automatically copied into place with VCPKG_APPLOCAL_DEPS.
dbus should be a feature of qt5-base and it should use -dbus-linked (or -dbus=linked) so VCPKG_APPLOCAL_DEPS will work.
Environment

OS: Windows
Compiler: Visual Studio 2022

Please provide the steps to reproduce, thank you.

Steps to reproduce

Unzip example.zip
execute the following commands:

cd example
git clone https://github.com/microsoft/vcpkg.git
cmake --preset=windows-debug
cmake --build build

In a separate terminal run a dbus-daemon:
cd example
build\vcpkg_installed\x64-windows\tools\dbus\dbus-daemon.exe --config-file build\vcpkg_installed\x64-windows\share\dbus-1\session.conf

Now run the example program:
cd example
build\example.exe

Expected result:
It should print "D-Bus connection established" to the console
Actual result:
It prints "D-Bus connection failed" to the console.
Workaround:
Manually copy dbus-1-3.dll to build. This is what would happen automatically with VCPKG_APPLOCAL_DEPS=ON if qt5-base had been configured with -dbus=linked.

That's using dbus as a plugin.
That's another data point in the "deployment of plugins isn't generally solved" story.

Thanks for posting this issue. Please reopen this issue if this is still a problem for you.

I guess this still is an issue. And please don't shorten the deadline which is promided by the bot.

-dbus-linked means a hard build time dependency and a visible deployment dependency for shared linkage. I doubt that this is generally desired.
-dbus=runtime doesn't have a build time dependency. Qt includes a minimal header. Deployment is optional: It is up to consumers to ensure that a runtime lib is available. (This issue.)
Accessibility in Qt on linux internally depends on Qt DBus. The port doesn't offer a feature to turn off accessibility.
There are downstream ports from the kf5 familly which currently depend on Qt DBus being enabled, not only on linux. I see this as a hint that Qt DBus is an expected/default feature. I didn't investigate downstream configuration options.

IMO it might be better to leave the port as is (-dbus=linked):

Qt DBus always available.
No extra build-time dependency.
No forced run-time dependency.
Apps or users which need dbus features must (and can) ensure that a runtime lib is available.

One more note: We always build dbus as a shared lib at the moment, even for static triplets.

IMO it might be better to leave the port as is (-dbus=linked):

You mean as is (-dbus=auto)?


Compressed Image Display

Addresses #738
I added RosTopicMultiProperty, which extends RosTopicProperty with a list of message types instead of one single type. This allows the ImageDisplay to show raw and compressed image topics together in its selector list. ImageDisplay was altered to use an image_transport subscriber so it can seamlessly display any installed image type. There is also a handful of frivolous changes to comply with the style linters.
Tested with raw and compressed images. Assuming the other types work as well because the conversion happens in the image_transport library.
Uncertainties:

RosTopicMultiProperty: Is the name ok? Is there a simpler way to achieve my goal without adding a one-off property?
plugin_description.xml: I added the other image_transport topic types here so Image Display appears in the "Add/By topic" menu. Adding the display will fail if the associated image_transport plugin is not installed. Should ros-$ROS_DISTRO-image-transport-plugins be added to package.xml?

Added a property to manually override image transport type. Rviz determines the transport by checking the topic name against image_transport conventions, e.g. camera_name/raw, camera_name/compressed, etc. If this is not the case, the transport must be set manually.
I also fixed the crash caused by adding a topic with an unavailable transport. Instead it will provide an error on the status property saying the transport is not installed.

I would like to list the available image transports in a status message. However, setStatusStd only seems to work when it is called from subscribe, not onInitialize or updateTopic. Any idea why?
The status message doesn't really matter except the transport->message type map is hard-coded, so we will want a warning if a new transport type is used which does not exist in the map.

I noticed the Jazzy version of image_transport finally allows passing in custom QoS so I updated the API here to match. This is change not compatible with previous versions of ROS.

Can ImageDisplay be combined with the parent class ImageTransportDisplay? That would allow CameraDisplay to also show compressed image topics.


Mac Catalyst app build fails on Xcode 14 RC

General Information
Catalyst app build fails on Xcode 14 RC with redefinition of module 'QuickLook' error

Project version:
1.4.0-1.6.3

Platform/OS version:
macOS Catalyst

IDE version:
Xcode 14 RC

My mac catalyst app version is not in production yet, so it's not critical problem for me, but FYI 🙂

To be honest I have not tested the entire library properly to know if its Catalyst compatible or not. This was never a project goal I guess so may take a while (if at all) for me to look at. But thanks for reporting.

Looks like @mikakruschel has fixed this issue 👍

Oh my! Eagle eye @mikakruschel 👏


Typescript or Flow?

It could potentially help us implement our styleguide, and would assist as the components grow to utilize a type system. Keyword potentially.
https://www.reddit.com/r/javascript/comments/39cere/typescript_vs_flow_results_from_our_investigation/
Let's chat about it, and consider if it's a good or bad idea...
GO

The reason I like the idea is, we're already transpiling w/ Babel from ES2015, etc to ES5, so in my mind the extra annotations could only help as long as they truly are helping.
ESLint et al are great tools, but don't do as good at catching certain types of bugs.

This is the one that gets me as a CON of Flow…

IDE integration isn't nearly as good as TypeScript right now

Based on that article alone, flow sounds like it might be better for us, specifically with React. But I’m open to either.

Yeah, the cons of TypeScript seem much worse than the cons of Flow. Figuring out imports and not committing compiled files seems like a real barrier to entry to me.

If we do this, it'll be flow probably.


v1.2 Timetable slots

Pull Request Test Coverage Report for Build 292

10 of 133 (7.52%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-3.3%) to 71.917%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/logic/parser/AddressBookParser.java
0
2
0.0%

src/main/java/seedu/address/model/person/timetable/TimetableData.java
10
17
58.82%

src/main/java/seedu/address/logic/commands/ViewGroupAvailableTimeslotCommand.java
0
9
0.0%

src/main/java/seedu/address/logic/commands/ViewGroupRankedAvailableTimeslotCommand.java
0
9
0.0%

src/main/java/seedu/address/logic/parser/ViewGroupAvailableTimeslotCommandParser.java
0
9
0.0%

src/main/java/seedu/address/logic/parser/ViewGroupRankedAvailableTimeslotCommandParser.java
0
9
0.0%

src/main/java/seedu/address/model/group/Group.java
0
78
0.0%

Totals

Change from base Build 290:
-3.3%

Covered Lines:
1913

Relevant Lines:
2660

💛  - Coveralls

Pls merge to branch v1.3


Cassandra: monitoring

Would like to open discussion on this topic. Some suggestions:

Add Jolokia jar to C* containers. It allows to easily fetch metrics by HTTP requests
Make it configurable (at C* service creation and C* update-service) to auto-create CloudWatch alarms for the most important metrics (like latency and free disk space).
Create a new service to run TICK (https://github.com/influxdata/sandbox) stack (in a single ECS task), which will retrieve metrics from C* (Telegraf), feed them into InfluxDB, provide a ready-to-use dashboards for various metrics (Chronograf).

Please, share your thoughts.
http://jolokia.org/agent/jvm.html
https://www.datadoghq.com/blog/how-to-monitor-cassandra-performance-metrics/
http://cassandra.apache.org/doc/latest/operating/metrics.html

The Cassandra metrics could be collected using nodetool, JConsole, or JMX. See Cassandra Monitoring. The datadog blog you posted also mentioned the same methods. Datadog would also collect the Cassandra metrics using one of these ways.
The initial plan is to follow the standard way (nodetool) to get Cassandra metrics, and send the metrics/alert to CloudWatch Metrics/Alarms. We will not add any additional library to the Cassandra container. We could have a general policy-based framework. The framework allows the customer to customize the policy, such as the metric collecting interval, the metrics to collect, etc. The framework will schedule the task(s) accordingly. The task(s) will use nodetool to connect to Cassandra nodes to get metrics and send to CloudWatch. The task will end after that, so the task only consumes resource when it is running. Each service could define its own monitoring task.
We will define the standard metrics/alarm APIs, and have one implementation for CloudWatch. In the future, we could easily add the implementation for Azure/GCP and other implementation, which may use TICK.

Thanks for the detailed explanation of your point! I agree that injecting a side library does not sound very well, but:

Jolokia library is a wrapper for JMX counters. It just adds an option to collect them thru simple HTTP requests. No local java needed to query them. Thus it requires much less of resources for the service which will query C* metrics. And it's opensourced.
nodetool is a java app, so it starts slowly and unable to query multiple metrics at once.
nodetool's output should be parsed before injecting metrics into CloudWatch. How are you going to deal with that? Also the output might change slightly in next C* releases, which will require extra work for the parser adaptation.
I'm not sure DataStax uses nodetool to collect metrics for opsCenter, since it installs a proprietary agent on every C* node and might query it to get metrics.

Regarding the monitoring task. Do you really think it's a good idea to continuously start and stop it? For example, for 1 minute metrics collection interval, it seems to me it might be started just a moment later after it was stopped. Just b/c a lot of metrics must be collected, processed and injected into CloudWatch.

Good point! There are many existing monitoring solutions. We will explore the existing solutions first, and leverage the open source solutions as much as possible. We will only consider to build our own solution when we could not find the suitable solution.
Jolokia is a good tool. It actually supports the proxy mode. We could test to see if the proxy mode works for Cassandra.
Telegraf is a good project. It supports to get metrics for many services, and could send the metrics to CloudWatch. It may be a better framework than CollectD. This blog has a good comparison.

For the monitoring task, it would be ok to keep the monitoring task running. The monitoring service would be a better name than task. Assume the framework such as Telegraf only has a small memory footprint.
It would not be a problem to keep the task short as well. Collecting the metrics of one Cassandra or other service node will be fast, unless something happens. For example, Cassandra itself is stuck at gc. The metrics data will be small. The processing and sending to like CloudWatch would be fast as well. The monitoring collection/handling would not take more than a few seconds. But it requires more work for the scheduling framework. We could start with the long run monitoring service first.

It turns out adding Jolokia into Cassandra container is the simplest way. Telegraf is also supported. Monitoring Cassandra, Redis and ZooKeeper are supported. You could create a Telegraf service for the Cassandra service and see the metrics on CloudWatch. Please take a look and share your comments/suggestions.
Note: currently Cassandra Keyspaces and tables are not monitored. The system keyspaces introduces more than 1000 metrics. Further enhancements will be added to monitor the user keyspaces.

That's a great news!! What is the upgrade path? If possible, I wouldn't like to re-create our cassandra services.

yep, upgrade will be supported for service created in 0.9.4 and 0.9.3.
Telegraf itself does not restrict the memory. We could leverage the container max memory/cpu limits. You could set the max-memory and max-cpuunits when creating the Telegraf service. This will set the max memory and cpu for the container. If Telegraf exceeds the max memory, container will be killed.

Could you please share the options for setting max-memory for Telegraf service creation command?

"max-memory" and "max-cpuunits"

Looks CLI help does not include these options. Will add it.

Have you updated the manage server and cli? Looks like the cli is still the old one:
-rwxrwxr-x junius/junius 7648808 2018-03-14 04:32 firecamp-service-cli

CLI does include the "max-memory" option. Just the help, such as firecamp-service-cli -op=create-service --help does not show the "max-memory" option. You could still use it.

I'm sorry - I meant the telegraf service absence:
# ./firecamp-service-cli -region=us-east-1 -cluster=firecamp-prod -op=create-service -help
Usage: firecamp-service-cli -op=create-service
...
  -service-type string
        The catalog service type: mongodb|postgresql|cassandra|zookeeper|kafka|kafkamanager|redis|couchdb|consul|elasticsearch|kibana|logstash
...

oops, uploaded the latest cli.

Works very well, thank you!

It would be great to have some storage metrics, like free/total space available
It would also be great to have some summarized metrics per cluster (like Latency, for example). Is that possible?

Unfortunately, cassandra does not provide them. For #1, cassandra storage load metrics provides "Total disk space used (in bytes) for this node", but not provide the free space for the node. In the later release, we could integrate with CloudWatch to create an alarm when the used space reaches some threshold of the total data volume size.
For #2, cassandra only provides the per node metrics. not aggregate all nodes. You could easily create the dashboard for the "cassandraClientRequest_Latency_Mean" for all nodes. This would be enough?

Yeah, that's a good solution, thank you! I'll create a separate issue for CloudWatch alarm on the used space.

Are you aware why some metrics are not available?
For example, Streaming metrics (http://cassandra.apache.org/doc/latest/operating/metrics.html)

Yes, not all metrics are monitored, such as Streaming metrics, CQL metrics, DroppedMessage metrics, etc. If you think some metrics is important and want to add, please let us know. Thanks.

Well, I think the aggregation of metrics across all keyspaces and tables are good to have. Streaming and DroppedMessage metrics seem also important.

Sounds good. We could add these 3 metrics.

It would be great to have an option to update the list of currently fetched metrics according to one's requirements. For example, at the moment around 100 metrics per node are fetched from Cassandra while I need just a few.

There are lots of Cassandra metrics. How do you want to configure it?
I am not sure if this is really necessary. Collecting 100 metrics per node would not impact Cassandra, as metric data is very small. If you only care a few, you could easily filter them on CloudWatch. It would be better to collect the important metrics. When something goes wrong, we may get some hints from the metrics.

It's not about impacting C*, it's about money: custom metrics cost ($0.30 x 100 = $30 per node per month) and it's not very wise to pay for the things you don't really need.
I thought we could have a file with the list of metrics (one per line) that could be uploaded to the Telegraf service thru a firecamp-manager-cli update call. It would replace the current metrics list with the new one. Another "get" call might return the current list of metrics.

I see. This makes sense. CloudWatch is not cheap.

The commit was in. You could put all the custom metrics in one file, and pass the file "-tel-metrics-file=pathtofile" when creating the service.
please pay attention to the data format in the metrics file. Each line includes one metric. Every metric should have the quotation marks and end with comma. The last metri should not end with comma. Example:
    "/org.apache.cassandra.metrics:type=ClientRequest,scope=Read,name=Latency",
    "/org.apache.cassandra.metrics:type=ClientRequest,scope=Write,name=Latency",
    "/org.apache.cassandra.metrics:type=Storage,name=Load"

That's great! Thanks for the implementation as well as for the upgrade feature!
If I'm running the "latest" release, what are my steps to upgrade correctly?

The custom metrics is supported for Cassandra. Close this issue.


MSC3278: Expose enable_set_displayname in capabilities response

Rendered

Relates to: #1862 (presence) and #3244 (rooms)

New pull request as branch was rename


Possible to provide approximate usage metrics?

First, thanks for creating this. It seems like a very tidy solution for a no_std arena allocator and has been working well for me so far.
One thing I would like to do with the project I'm working on is get an idea of how much memory is left for allocation. Obviously this can only give an approximate indication, what with heap fragmentation and so on, but is there any reasonably straightforward way to expose something like bytes_used() -> usize and/or bytes_available() -> usize?

I should probably document this a bit more obviously in the README.

[Features] "counters": Talc will track heap and allocation metrics. Use Talc::get_counters to access them.

This'll return a struct that contains both these stats and more. (This feature is a relatively recent addition so feedback is especially welcome.)
I'll close this for now though.


api: don't throttle api discovery for listApis command

Description

Users reported that they weren't getting all apis listed in cloudmonkey when running a sync. After some debugging, I found that the problem is that the ApiDiscoveryService is calling ApiRateLimitServiceImpl.checkAccess(), so the results of the listApis command are being truncated because Cloudstack believes the user has exceeded their API throttling rate.

I enabled throttling with a 25 request per second limit. I then created a test role with only list* permissions and assigned it to a test user. When this user calls listApis, they will typically receive anywhere from 15-18 results. Checking the logs, you see The given user has reached his/her account api limit, please retry after 218 ms..
I raised the limit to 200 requests per second, restarted the management server and tried again. This time I got 143 results and no log messages about the user being throttled.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Fixes: #2842
Screenshots (if appropriate):
How Has This Been Tested?

Updated the appropriate unit tests to verify the ApiRateLimitService is not longer called when discovering APIs.
Checklist:

[x] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
Testing
[x] I have added tests to cover my changes.
[ ] All relevant new and existing integration tests have passed.
[ ] A full integration testsuite with all test that can run on my environment has passed.

@csquire, from your PR description I understood that we should not need/use the API rate limit service. Therefore, we only need to check if the user has access to the API method. Is that it?
If that is the case, why don’t we do something different?
At org.apache.cloudstack.discovery.ApiDiscoveryServiceImpl.listApis(User, String) method, instead of injecting all "APIChecker” implementations, we can only inject the StaticRoleBasedAPIAccessChecker and DynamicRoleBasedAPIAccessChecker. Then, you solve all of your problems with little or no coding at all.
To change the beans that are injected you can change the XML file spring-server-core-misc-context.xml. There is a bean called apiDiscoveryServiceImpl; then, you need to check the property being configured apiAccessCheckers. I guess you can change the property injection from:
<property name="apiAccessCheckers" value="#{apiCheckersRegistry.registered}" />
To something like:
        <property name="apiAccessCheckers">
            <util:list list-class="org.apache.cloudstack.acl.APIChecker">
                <ref bean="DynamicRoleBasedAPIAccessChecker" />
                <ref bean="StaticRoleBasedAPIAccessChecker" />
            </util:list>
        </property>

Of course, you need to import the “util” namespace in spring-server-core-misc-context.xml, but that is quite easy to do.

yeah, great idea, that looks like a good solution.  I'll update the PR.

I took a look at your suggestion @rafaelweingartner but those beans cannot be referenced directly in this context.

ow really?
So, what if you change the "set" method of that property to remove the "apiRateService" from the list of API checkers being configured?

With the idea of not injecting the rate limit checker, I tried a different approach by creating a new marker interface and new registry for ACL checkers.  Thoughts?

I confess that I really dislike that registry solution that people implemented in ACS. Instead of using Spring life-cycle properly, people decided to create something else.
Your solution now works, and it is better than changing the code like it was done in the first attempt. However, I would still prefer something more integrated with Spring life-cycle.
Right now I am not able to think in something to enable us to work around this problem. Therefore, I am inclined to say that this last proposal is fine.

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2482

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-3246)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 19967 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2894-t3246-kvm-centos7.zip
Smoke tests completed. 68 look OK, 0 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

@rhtyd is this ready?

Let me test this tomorrow @DaanHoogland


Updating Go version and dependencies

Will open a new PR, this one has a dangling status check that never resolves.


GitHub Magic B, Annexure II

Add issue template other (resolves #597)
Disable empty issues (resolves #598)
Add link to discussions in issues selector (resolves #599)
Add link to discord community in issues selector (resolves #600)

Awesome PR!


sdist doesnt include locale

The threadedcomments/locale is not included in the v1.2 sdist

fixed in git, will make a new release!


[EUWE] Apply Selection Spec to hostSystemsStorageDevice

Euwe backport of https://github.com/ManageIQ/manageiq-gems-pending/pull/38

Use the provided selection spec to filter the properties returned by the VC. The selection spec was being applied to the result but not to the propPath before the call.
This was already done in MiqVimHost in https://github.com/ManageIQ/manageiq-gems-pending/blob/master/lib/gems/pending/VMwareWebService/MiqVimHost.rb#L267 but didn't get moved over to MiqVimInventory
This should reduce the size of the payload returned by excluding config.storageDevice.multipathInfo, config.storageDevice.plugStoreTopology, and config.storageDevice.softwareInternetScsiEnabled

@roliveri please review


Could not find any cuda.h matching version '10.0' in any subdirectory

Hi.
I was trying to build tensorflow-1.15.0 for Xavier NX. But it said "Could not find any cuda.h matching version '10.0' in any subdirectory".
My NX Jetpack verison is 4.3. It only has CUDA 10.2. I noticed that you have built tensorflow-1.15.0 with Jetpack 4.3. So could you please share more information about how to build tensorflow-1.15.0 with Jetpack 4.3?

Full error information
`Could not find any cuda.h matching version '10.0' in any subdirectory:
''
'include'
'include/cuda'
'include/*-linux-gnu'
'extras/CUPTI/include'
'include/cuda/CUPTI'
of:
'/usr/local/cuda'
Asking for detailed CUDA configuration...
Please specify the locally installed NCCL version you want to use. [Leave empty to use http://github.com/nvidia/nccl]:
Please specify the comma-separated list of base paths to look for CUDA libraries and headers. [Leave empty to use the default]:
`

Please refer to this announcement.  JetPack-4.3 has CUDA 10.0 Toolkit in it.
I think you are using JetPack-4.4 (CUDA 10.2) on Jetson Xavier NX.  Please refer to my Setting up Jetson Xavier NX blog post.  I would suggest you to use the official tensorflow-1.15.2 wheel, instead of building from source.

You can try to build from source TF 2.3.0, it works for me with JetPack-4.4.
However I think building from source is only useful if you have to run a TF c/c++ application, if you only need to use TF from python the official wheel is the best choice.

Please refer to this announcement. JetPack-4.3 has CUDA 10.0 Toolkit in it.
I think you are using JetPack-4.4 (CUDA 10.2) on Jetson Xavier NX. Please refer to my Setting up Jetson Xavier NX blog post. I would suggest you to use the official tensorflow-1.15.2 wheel, instead of building from source.

You can try to build from source TF 2.3.0, it works for me with JetPack-4.4.
However I think building from source is only useful if you have to run a TF c/c++ application, if you only need to use TF from python the official wheel is the best choice.

Thank you guys.
I successfully built latest tensorflow-master with --config=v1


Bug: stickers and emoji don't show who forwarded them

Stickers and single emoji just get posted from the tgcf user, with no text to show who originally posted them.

hi, @Reddog176 Can you show me a screenshot?

Attached screenshots from both the from and to sides. The GIF  in the middle forwarded proper.

This is not bug,, This is Telegram issue
Even if you manually forward sticker from any chat to any chat
It will not show forwarded tag.
Check yourself

In your configuration, have you set show_forwarded_from = true ?
Is it working properly for normal text messages ?
Is the bug only for stickers and gifs ?

Yup @ankit-sinha-18 . You are right

yes, show_forwarded_from is true, it's working for everything else. I'm aware it's a telegram issue. I expected the script to add a message either before or after to say who it was forwarded from.

Not a show stopper, just something to think about.

this is not an important feature in my opinion.
If you need it badly, then implement a plugin that does this. Learn how


Using it in Jetpack Compose

Hi I loved this project, but I have a small doubt that is it compatible to use with Jetpack Compose projects?

Hello @Ansalpandey
Absolutely, it is compatible for use with Jetpack Compose projects.


Consider to archive the videos and articles of the first months of 2019

Archives the articles and videos from January to April, 31th.

Done.


Not all playlists get imported

I have a total of 91 playlists with about 147k tracks in total. Syncing does not seem to import all of them. They are for the most part liked playlists and I have clicked "add to profile" on all of them.
Maybe this is an API limitation but some other third party services I am using do not seem to have that problem.
Let me know whether I can help to trace down the issue.

That is weird, because i think it should import all of them...
I'll try to look into it !
NOTE to self : issue should be arround here : https://github.com/vhaudiquet/BladePlayer/blob/master/app/src/main/java/v/blade/sources/spotify/Spotify.java#L381

Hi, first of all thank you for this great app!
I've installed BladePlayer some month ago without any issues. Around two month ago, I had some issues and had to reinstall it. Since this reinstall, I only see 9 out of around 50 playlists. One weird thing - if I create a playlist in Blade, it is shown and all tracks I add elsewhere are updated. But existing or newly created playlists are not updated.
Thanks for you help :)

Hello,
First, thank you for your interest in Blade !
I don't have much time in my life for Blade right now, so I update the project only to fix bugs when I can.
This is weird, because I clearly remember checking it out last time (when this issue was opened) and not finding anything.
I have not changed this part of the code since, so I'm not sure what I am missing.
Did you try removing all data and cache from Blade, and syncing again ?
It could be a one time error because of a Spotify outage/rate limit, which would then get written up in the cache.
If it is not that, I'm not sure what the cause of the problem is.
I'll try to look into it if I have time, but I'm not sure I will find anything....


Performance benchmarks for rwasm ( its dependency on wasmer-go)

Hi,  We are evaluating rwasm/reactr to use in one of our WebAssembly project. As rwasm uses wasmer-go as its wasm engine and its indirect dependency on CGO, we are interested to know its performance. Generally CGO may come with some performance penalties:  https://www.cockroachlabs.com/blog/the-cost-and-complexity-of-cgo/.  It would be great if you share some performance benchmarks.

@venugopv Sure, I'd be happy to provide some benchmarks. What kinds of things are you looking to see?

Hi @cohix , Thanks for quick response. Basically our use case involves many interactions from WASM module (Guest side) to wasm embedder (Host side) to access Host functions (like HTTP functionality. Suborbital::http is exact match to us). Coupling the fact that we would be running 100 of wasm instances in parallel.
So some thing like this: We would be running 100 of instances of similar to Fetch sample (https://github.com/suborbital/reactr/blob/main/rwasm/testdata/fetch/src/lib.rs). From my limited research on CGO, I am under the impression, there would be significant performance penalty. I am interested to know what do you see when you run some thing similar to above (i.e  running 100 of instances of similar to Fetch sample ).

@venugopv thanks for the detail. I will spend some time this week creating something to demo performance for your use-case. In the meantime, please do explore the docs and examples and let me know if there is anything missing that I can add!

Alright so I've run some tests locally, and assuming these results are what you're looking for, I'll push the benchmarks to main so you can try it yourself. If this isn't what you're looking for, let me know and I'll do another round.
BenchmarkRunnableFetch-16    	      10	 120235191 ns/op	  107026 B/op	     257 allocs/op
That benchmark is just http::get'ing the Google homepage. The ns/op translates to 0.120 seconds/op.
When I do 10 invocations of cURL on the same URL, I get a mean request time of 0.116 seconds.
So average of 120ms per request for Reactr and 116ms per request for cURL. Not a perfect comparison for sure, but it's at least a basic look.
@venugopv Let me know if you'd like to see anything else!

@venugopv Any update here?

Hi @cohix , Thanks very much for your inputs.  We have further evaluated on usage of CGO and golang particular, we have decided to  embed Webassembly in Rust as it suits more to our use case.


nil buffer fix

Fixed nil reader content regression introduced with PR #129.

Don't allow buffers with nil contents to be passed to http.NewRequest constructor.
Fixes errors like:
Get https://[SOME-WEBSITE]: stream error: stream ID 1; REFUSED_STREAM

Hi @jaytaylor,
Thank you for your PR.
Can you give me some example code? It seems I can't reproduce the error.

Hi @parnurzeal!
I agree, it is not immediately obvious what's going on or why this is needed.
From f441e24175ffc865a6354b65375e537201c51382 (Jan 9, 2017), and the next commit, ab5fdf763cb63f22614b6c1a85cba32430c5bec2 "Allow bodies to all HTTP methods" (Feb 10, 2017)  there are observable behavioral changes in which headers are included.
Example gorequest code
(Extremely basic)
package main

import (
	"github.com/parnurzeal/gorequest"
)

func main() {
	request := gorequest.New()
	request.Get("http://localhost:9000/").EndBytes()
}

Previous working f441e24175ffc865a6354b65375e537201c51382 (Jan 9, 2017)
Launch nc -l -v <IP_ADDRESS> 9000 then in another tab run the above go code.
$ nc -l -v <IP_ADDRESS> 9000
GET / HTTP/1.1
Host: localhost:9000
User-Agent: Go-http-client/1.1
Accept-Encoding: gzip
Connection: close

a578a48e8d6ca8b01a3b18314c43c6716bb5f5a3 (Feb 10, 2017)
Launch nc -l -v <IP_ADDRESS> 9000 then in another tab run the above go code.
$ nc -l -v <IP_ADDRESS> 9000
GET / HTTP/1.1
Host: localhost:9000
User-Agent: Go-http-client/1.1
Content-Type: application/json
Accept-Encoding: gzip
Connection: close

Notice the new "application/json" content-type header.  Since no JSON has been specified, this seems like undesirable behavior.
To be candid, I'm not sure if this PR even resolves that piece.
Also, I agree with the merge request which caused/revealed these issues - imho it's good to allow any request type to have a body attached to it and let people make their own decision.
With that said, looking through net.NewRequest(...) src code, there is a fair amount of logic dependent on whether or not the body is null.
This is why it seems highly undesirable to send a non-nil body buffer wrapping nil contents to http.NewRequest(...).  So at the very least, we should stop doing that.
I'll update this PR to address the nil-body aspect for all specially-cased content-types (originally this PR only fixed the JSON case).

Update
I've added handling for all cases except for TargetType="multipart".  In my opinion this isn't pretty and I'm open to any improved alternative solutions and/or approaches!

Additionally, the results of the experiment outlined above with this PR applied are as follows:
$ nc -l -v <IP_ADDRESS> 9000
GET / HTTP/1.1
Host: localhost:9000
User-Agent: Go-http-client/1.1
Accept-Encoding: gzip
Connection: close

Which is back to looking good.

Interesting! Thank you for a deep dive into the issue.
I am very impressed.
For improving the code, how about taking req.Header.Set("Content-Type", "xxx") out of those big if-else checks?
We could declare a new variable var contentType string and assign it for each case.
Then, having a check if contentType is not empty, we set Content-Type header.
For example:
var contentType string
if s.TargetType == "json" {
	.
	.
	.
	var contentReader io.Reader
	if contentJson != nil {
		contentReader = bytes.NewReader(contentJson)
		contentType = "application/json"
	}
	req, err = http.NewRequest(s.Method, s.Url, contentReader)
} else if s.TargetType == "form" || s.TargetType == "form-data" || s.TargetType == "urlencoded" {
	.
	.
	.
	var contentReader io.Reader
 	if contentForm != nil {
 		contentReader = bytes.NewReader(contentForm)
 		contentType = "application/x-www-form-urlencoded"
 	}
	req, err = http.NewRequest(s.Method, s.Url, contentReader)
} else if s.TargetType == "..." {
	.
	.
	.
} else if s.TargetType == "multipart" {
	.
	.
	.
	req, err = http.NewRequest(s.Method, s.Url, &buf)
	contentType = mw.FormDataContentType()
} else {
	// let's return an error instead of an nil pointer exception here
	return nil, errors.New("TargetType '" + s.TargetType + "' could not be determined")
}
// Check error from creating a new http request.
if err != nil {
	return nil, err
}
if contentType != "" {
        req.Header.Set("Content-Type", contentType)
}

I know it might not be straightforward to read but we can add more comments to make it clear.
With this, we can reduce some redundant code as well as having less if-else and less headache.
WDYT? I am also open to ideas :)

Sure, updating the PR to reflect the proposed approach now :)

@parnurzeal Alright, I think we're so close!
Everything seems to work swell, except for the multipart form tests.
  I'm not entirely clear on what we're testing for in these cases.
Failing cases:
near line 724 in gorequest_test.go:
const _24K = (1 << 20) * 24
err := r.ParseMultipartForm(_24K)
if err != nil {
	t.Errorf("Error: %v", err)
}

gorequest_test.go:727: Error: multipart: NextPart: EOF
near line 756 in gorequest_test.go:
if val, ok := r.MultipartForm.Value["query1"]; ok {
	t.Error("Expected no value", "| but got", val)
}

2017/04/09 22:03:15 http: panic serving <IP_ADDRESS>:49709: runtime error: invalid memory address or nil pointer dereference
goroutine 23 [running]:
net/http.(*conn).serve.func1(0xc420134200)
	/usr/local/go/src/net/http/server.go:1491 +0x12a
panic(0x30b8e0, 0xc4200120e0)
	/usr/local/go/src/runtime/panic.go:458 +0x243
github.com/parnurzeal/gorequest.TestMultipartRequest.func1(0x4bb720, 0xc420128340, 0xc42014a4b0)
	/Users/jtaylor/go/src/github.com/parnurzeal/gorequest/gorequest_test.go:758 +0x928
net/http.HandlerFunc.ServeHTTP(0xc420110480, 0x4bb720, 0xc420128340, 0xc42014a4b0)
	/usr/local/go/src/net/http/server.go:1726 +0x44
net/http.serverHandler.ServeHTTP(0xc4200aa280, 0x4bb720, 0xc420128340, 0xc42014a4b0)
	/usr/local/go/src/net/http/server.go:2202 +0x7d
net/http.(*conn).serve(0xc420134200, 0x4bbda0, 0xc42011c540)
	/usr/local/go/src/net/http/server.go:1579 +0x4b7
created by net/http.(*Server).Serve
	/usr/local/go/src/net/http/server.go:2293 +0x44d

There is also a failure around line 722 which goes away if I force the content-type header to be sent regardless of whether anything has been encoded:
gorequest_test.go:722: Expected Header Content-Type -> multipart/form-data | but got
Your thoughts on how we should proceed are appreciated :)

I think the failures in those cases, they are sending zero body content and also checking whether there is a "Content-Type" multi-part or not. And because we changed the behavior not to send "Content-Type", this then makes it fail.
But anyway @jaytaylor , when seeing this error,  it made think twice whether we should add logic under it to bounce back to no "Content-Type" if there is no body content.
I am terribly sorry about this but I think we might think too much about this. If a user forces Type("multipart") or Type("form") or ... anything explicitly, we maybe should just let the "Content-Type" be whatever the user wants it to be. The user should be the one who is responsible to not send zero body content her/himself.
So, the easier way to fix this, we need to go look back to the issue cause of when that PR #129  introduced.
That PR removed the switch/case that makes http method like "GET" not sending a pure request without "Content-Type" anymore.
https://github.com/parnurzeal/gorequest/pull/129/files#diff-96bc10f186f846c5018abbf29da04812L1195
And it is just coincidentally I made s.TargetType default to "json" since the beginning of this project.  That's why after that PR #129, it sets GET request's content-type to json.
The way to fix this is might be just

set s.TargetType to an empty string when using HTTP GET, instead.
https://github.com/parnurzeal/gorequest/blob/b221adce66f12504bfe2bce35beb3b3f9c599bb5/gorequest.go#L175
don't give an error when s.TargetType is empty but make a request with nil body, instead.
https://github.com/parnurzeal/gorequest/blob/develop/gorequest.go#L1194

Again, really sorry that I might waste your time on the incorrect direction.
But please let me know how my another approach sounds to you.
I might also be wrong on this.

This is an interesting turn of perspective!
I agree that if a user forces a type, then it should be respected.  At the same time, what we've done here to make a best effort to avoid sending non-nil buffers with nil contents to http.NewRequest(...) still seems worthwhile.
Also, I've found that adding a simple body (Send("foo").) to the exploding test case, now all broken test cases for this PR are passing.
The functionality you're describing doesn't seem mutually exclusive.  Is there room for both?
How would you feel about merging this and filing an issue for the target type updates?
(btw I played around with setting TargetType = "" in Get(...), but as you'd expect, that introduces additional test breakage.)

Ok cool :) SGTM.
Let's finish up this PR. I have commented a bit on your code.

@parnurzeal Excellent feedback, I had the impulse to do it earlier but refrained on the principle of min-diff.
Let me know how this looks~
Cheers,
Jay

Super good!
Thank you for your help resolving this issue :)
It has been very nice and fun to work through this with you.

Likewise, thank you! :)


Should Arel::Nodes::True.new() be 1 in sqlite3?

I am using Arel::Nodes::True.new() as a fallback for a query construction. It works fine in development with the postgresql adapter but it breaks my tests as they are using the sqlite3 adapter. I figured out that this is because sqlite3 takes 1 instead of true:
$ rails console test
Running via Spring preloader in process 8777
Loading test environment (Rails 4.1.6)
2.2.3 :001 > Mymodel.where(1).count
 => 0
2.2.3 :002 > Mymodel.where(Arel::Nodes::True.new()).count
SQLite3::SQLException: no such column: TRUE: SELECT COUNT(*) FROM "mymodels"  WHERE (TRUE)

I can fix the issue by checking the environment and returning either Arel::Nodes::True.new() or 1 but it does not feel right.

I made some changes on sqlite.rb, so that Arel::Nodes::True.new().to_sql == '1' and  Arel::Nodes::False.new().to_sql == '0'. I have sent the pull request at: https://github.com/rails/arel/pull/417


Add filesystem IO metrics

Filesystem IO metrics are in the elasticsearch nodestats output, but they were not being exported.
In addition to the new IO metrics, the filesystem data metrics have had their variables renamed to avoid confusion. In elastic <5 the only metric within the filesystem output of nodeStats  was data, which is why I assume the naming was less specific. In elastic >5 the filesystem output of nodeStats contains both data as well as io_stats.

Hi @seanlaff,
thanks for your contribution! Looks good. Can you fix the conflict so I can merge your PR?!

I usually run node_exporter on the ES nodes as well... isn't it better to just use the node_exporter IO-related metrics?

I agree the node_exporter provides the more detailed set of metrics. The argument for having os related metrics in the exporter is mainly that you are usually not able to install the node_exporter in hosted es (by was or elastic for example)

I agree the node_exporter provides the more detailed set of metrics. The argument for having os related metrics in the exporter is mainly that you are usually not able to install the node_exporter on hosted es (by was or elastic for example)

hmm, that makes sense indeed.

@zwopir Resolved the conflicts. Thanks for taking a look

thanks again for your contribution!


Remove @vue/composition-api from peerDependencies

@townsquarelabs/ui-vue lists @vue/composition-api as a peer dependency:
https://github.com/TownSquareXYZ/tonconnect-ui-vue/blob/ee614c6b09efb3a9ef200887882a88de32a300d6/package.json#L61
There is no point in doing so. The package never imports or uses @vue/composition-api in any other way. As such, @vue/composition-api should not be listed as a dependency.
Having it pulls unnecessary libraries in Vue 3 projects and pollutes output with warnings:
 WARN  Issues with peer dependencies found
.
└─┬ @vue/composition-api 1.7.2
  └── ✕ unmet peer vue@">= 2.5 < 2.7": found 3.4.37

@townsquarelabs/ui-vue lists @vue/composition-api as a peer dependency:
https://github.com/TownSquareXYZ/tonconnect-ui-vue/blob/ee614c6b09efb3a9ef200887882a88de32a300d6/package.json#L61
There is no point in doing so. The package never imports or uses @vue/composition-api in any other way. As such, @vue/composition-api should not be listed as a dependency.
Having it pulls unnecessary libraries in Vue 3 projects and pollutes output with warnings:
 WARN  Issues with peer dependencies found
.
└─┬ @vue/composition-api 1.7.2
  └── ✕ unmet peer vue@">= 2.5 < 2.7": found 3.4.37

@IlyaSemenov
Yes, you are right. The package after building does not need "peerDependencies": {
"@vue/composition-api": "^1.0.0-rc.1",}. The reason why it exists in package.json is because this dependency is needed during development. Later, we will separate the build and dev of the code. The package after building will remove unnecessary dependencies.


Extend enodebd with gRPC calls towards Orc8r services

Within this task, please extend enodebd (or enodebd's state implementation for the eNB) with hooks/calls towards the Domain Proxy. Implement the API designed in the spike.

A prototype code where enodebp invokes a gRPC call towards a "dp_service" service from the service registry has been created and integrated into Bai 436Q state machine. Protobufs are dummy stubs for now. Will require extension in another task.


[release-next] Rebase and update signature verification section

Can't remember how we update release-next in the face of a conflict, but this (if force-pushed) would fix release-next.
Raising this so the changes are available - will work out how to merge tomorrow.

Closing in favour of #1393 1393


🐛 Bug Report: Github Auth not working on backstage version 1.26.0

📜 Description
I have created new backstage instance using npx @backstage/create-app@latest and Now I want to add auth provider for Github , I am following this doc and created Github App with
HomePage-URL: http://localhost:3000
CallBack-URL: http://localhost:7007/api/auth/github/handler/frame
Also, configured Auth-setting in app-config.yaml like below:
auth:
  # see https://backstage.io/docs/auth/ to learn about auth providers
  environment: development
  providers:
    # See https://backstage.io/docs/auth/guest/provider
    github:
      development:
        clientId: "my-plain-test-id"
        clientSecret: "my-plain-text-secret"

Also, change sign-in page in frontend, like this:
import {
  SignInProviderConfig
  SignInPage,
} from '@backstage/core-components';
import { githubAuthApiRef } from '@backstage/core-plugin-api';

const app = createApp({
  apis,
  components: {
  SignInPage: props => (
    <SignInPage
      {...props}
      auto
      provider={{
        id: 'github-auth-provider',
        title: 'GitHub',
        message: 'Sign in using GitHub',
        apiRef: githubAuthApiRef,
      }}
    />
  ),
},

But, when I am trying to sign in frontend, it is giving below error:
{"error":{"name":"NotFoundError","message":"Unknown auth provider 'github'","stack":"NotFoundError: Unknown auth provider 'github'\n    at <anonymous> (/home/il58d0/new-backstagea-app/node_modules/@backstage/plugin-auth-backend/src/service/router.ts:162:11)\n    at handleReturn (/home/il58d0/new-backstagea-app/node_modules/express-promise-router/lib/express-promise-router.js:24:23)\n    at /home/il58d0/new-backstagea-app/node_modules/express-promise-router/lib/express-promise-router.js:64:7\n    at Layer.handle [as handle_request] (/home/il58d0/new-backstagea-app/node_modules/express/lib/router/layer.js:95:5)\n    at trim_prefix (/home/il58d0/new-backstagea-app/node_modules/express/lib/router/index.js:328:13)\n    at /home/il58d0/new-backstagea-app/node_modules/express/lib/router/index.js:286:9\n    at param (/home/il58d0/new-backstagea-app/node_modules/express/lib/router/index.js:365:14)\n    at param (/home/il58d0/new-backstagea-app/node_modules/express/lib/router/index.js:376:14)\n    at Function.process_params (/home/il58d0/new-backstagea-app/node_modules/express/lib/router/index.js:421:3)\n    at next (/home/il58d0/new-backstagea-app/node_modules/express/lib/router/index.js:280:10)\n    at /home/il58d0/new-backstagea-app/node_modules/express/lib/router/index.js:646:15\n    at next (/home/il58d0/new-backstagea-app/node_modules/express/lib/router/index.js:265:14)\n    at Function.handle (/home/il58d0/new-backstagea-app/node_modules/express/lib/router/index.js:175:3)\n    at router (/home/il58d0/new-backstagea-app/node_modules/express/lib/router/index.js:47:12)\n    at handleReturn (/home/il58d0/new-backstagea-app/node_modules/express-promise-router/lib/express-promise-router.js:24:23)\n    at router (/home/il58d0/new-backstagea-app/node_modules/express-promise-router/lib/express-promise-router.js:64:7)"},"request":{"method":"GET","url":"/api/auth/github/start?scope=read%3Auser&origin=http%3A%2F%2Flocalhost%3A3000&flow=popup&env=development"},"response":{"statusCode":404}}

👍 Expected behavior
It should allow to sign-in using Github
👎 Actual Behavior with Screenshots

👟 Reproduction steps
Create backstage with : npx @backstage/create-app@latest
And configure Github Authentication provider as described in doc
📃 Provide the context for the Bug.

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
None

After adding backend.add(import('@backstage/plugin-auth-backend-module-github-provider'));  in packages/backend/src/index.ts , it's not giving above error but now getting below:

Hi @prasoon-pxc, sorry you've had issues and the docs haven't been to helpful. We are actively working on that: https://github.com/backstage/backstage/issues/24195
Any new instances of Backstage will use the new backend system by default as of the 1.24.0 release from a few months ago. This means that you do need to add backend.add(import('@backstage/plugin-auth-backend-module-github-provider')); to your backend index.ts file and also add the signIn.resolvers details in your config.

No problem, But I am wondering if it is the case with Github-org data doc as well because I am also getting problem on automating ingesting github users to backstage, I am looking more into it and will check if there is some document issue there as well :-)

Yes, that page needs to be updated as well. The migration guide here might help you in the mean time: https://backstage.io/docs/backend-system/building-backends/migrating#the-catalog-plugin:~:text=GithubMultiOrgEntityProvider and GithubOrgEntityProvider

@awanlin , I tried to add changes what is mentioned in above doc, but it's still not working.
Added github-org package:
yarn --cwd packages/backend add @backstage/plugin-catalog-backend-module-github-org

packages/backend/src/index.ts
backend.add(import('@backstage/plugin-catalog-backend-module-github/alpha'));
backend.add(import('@backstage/plugin-catalog-backend-module-github-org'));

Apart from the above steps, I have used this doc to install required things.
My catalog.ts file looks like this:
packages/backend/src/plugins/catalog.ts
import { CatalogBuilder } from '@backstage/plugin-catalog-backend';
import { ScaffolderEntitiesProcessor } from '@backstage/plugin-catalog-backend-module-scaffolder-entity-model';
import { Router } from 'express';
import { PluginEnvironment } from '../types';

import { GitHubOrgEntityProvider } from '@backstage/plugin-catalog-backend-module-github';

export default async function createPlugin(
  env: PluginEnvironment,
): Promise<Router> {
  const builder = await CatalogBuilder.create(env);

   //Added GITHUB ORG

   builder.addEntityProvider(
    GitHubOrgEntityProvider.fromConfig(env.config, {
      id: 'production',
      orgUrl: 'https://github.com/my-org',
      logger: env.logger,
      schedule: env.scheduler.createScheduledTaskRunner({
        frequency: { minutes: 60 },
        timeout: { minutes: 15 },
      }),
    }),
  );

  builder.addProcessor(new ScaffolderEntitiesProcessor());
  const { processingEngine, router } = await builder.build();
  await processingEngine.start();
  return router;
}

Also, added github integration using Github-App
app-config.yaml
integrations:
  github:
    - host: github.com
      apps:
        - $include: my-githubapp.yaml

==Tried updated doc to configure it, did below steps:
I have setup Github-integration with github app using this doc also provide required permissions for Github-app to ingest users and teams
After that added below package:
yarn --cwd packages/backend add @backstage/plugin-catalog-backend-module-github-org
added below line in packages/backend/src/index-tx
backend.add(import('@backstage/plugin-catalog-backend-module-github-org'));

app-config.yaml
integrations:
  github:
    - host: github.com
      apps:
        - $include: my-big-org.yaml

One of the items missing in my PR to updated the docs which you might be missing too is that you need to make sure to schedule it:
catalog:
  providers:
    githubOrg:
      id: production
      githubUrl: https://github.com
      orgs: ['Org1', 'Org2']
      schedule:
        frequency: PT1H
        timeout: PT50M

@awanlin , thanks for update, indeed that was missing. Now, working as expected.

Awesome! Glad everything is working for you now. Really appreciate your patience as we worked to sort this out.

@awanlin @prasoon-pxc I am facing the below issue even after following all the above steps

@awanlin can you please look into this new issue #25043

Hey @prasoon-pxc - thanks for putting this together, helped me resolve an issue I was debugging for a couple. Highly recommend to the backstage team to incorporate this body of work into the initial clone or at least document the error somewhere!

Hi @stone-monkeys, I've updated the docs to cover all the issues highlighted by @prasoon-pxc back in May. Can you share where there were gaps still?

Hi there,
I faced a similar issue and found that the problem was related to where the Client ID and Client Secret were created. Initially, I created them from my user account,https://github.com/settings/applications/new which led to issues.
To resolve this, make sure to create the Client ID and Client Secret from your organization account. You can do this by navigating to:
https://github.com/organizations/<org name>/settings/applications/new
Hope this helps!

@Prateek-Wayne Hey there - was there a specific error you were getting that led to this resolution?


update documentation block workflow

https://whimsical.com/sidechain-Hn48PizK75qk4weaU1GuVA

We no longer use this document.


Very Large Material 2d Mesh diagonal artifact issue

Bevy version
v0.13.2

Clicking the pencil button toggles the Visibility of a very large MaterialMesh2dBundle as seen in the video.

parent.spawn((
    MaterialMesh2dBundle {
        mesh: meshes.add(Rectangle::default()).into(),
        transform: Transform::default().with_scale(Vec3::splat(9999999999.)),
        material: materials.add(Color::Rgba {
            red: 0.5,
            green: 0.5,
            blue: 0.5,
            alpha: 0.5,
        }),
        visibility: Visibility::Hidden,
        ..default()
    },
    DrawOverlayMesh,
));

along the right top diagonal I'll get weird things happen if I'm in certain spots.
Maybe a better way to do what I'm doing, (feel free to let me know), but I figured this is also a bug.

https://github.com/bevyengine/bevy/assets/7761473/9109a223-6289-43ca-940a-3a71b9b06088

Another example:
https://github.com/bevyengine/bevy/assets/7761473/d586855b-8287-466b-b131-03355a936d75

I have run into similar artifacts on iOS and never seen them on windows, linux or android. My meshes aren't even that big, maybe 500 units. They show up pretty randomly.


Lightbox doesn't load tweets images.

On clicking images in twitter (twitter avatar & tweet inline image), nothing is loaded in the Lightbox.
Here we have two options:-

Fix this & load images in the Lightbox. (for both avatar & inline image)

Open tweet in browser (custom tabs & safariView)

Thoughts?
@zulipbot claim

This is still an issue. Are you working on it? If not, please abandon this so that I can claim this.

@pulkonet Thanks for the interest.
I am almost done with it, will push it soon.


Getting post working

This gets posting working.

I updated this to merge properly with what I added earlier (which is why it looks so complicated) and to update postmessage with some update error handling I added. The only actual changes to postMessage are in

Getting post working f98c423
Update PostMessage error handling 50df6bb
Once you merge this in, you should be ready to merge with the main branch.


Fix/replace SnippetLength check in checkstyle.xml

We have an open issue to migrate to spotless plugin from the current checkstyle plugin.
Closing this issue


Response caching component

Assumption: MVC and other application level components will set standard HTTP cache headers (Cache-Control, Vary, etc.) for clients and proxies.
Also implement middleware and/or server support for reading the response headers and caching. It can then short circuit incoming requests and serve them from the cache.

@muratg Needs a new repo - ResponseCaching

New repo: https://github.com/aspnet/responsecaching

Related: Our IIS plugin and (soon) WebListener have limited access to the kernel mode cache. See https://github.com/aspnet/WebListener/issues/121

The HttpMessageHandler based HttpCache I wrote here https://github.com/tavis-software/Tavis.PrivateCache/blob/master/src/PrivateCache/PrivateCacheHandler.cs has all the caching logic as per rfc7234.  Because I built it as a private cache there are a few conditions that shared caches need to account for that I didn't take into account.  I believe the full set of conditions are in the diagrams here http://bizcoder.com/caching-is-hard-draw-me-a-picture which I used as a basis for the code.
There is one scenario I am still working on which is when the vary header changes over time and there are multiple cached variants that had different vary headers when they were originally cached.  I expect my storage interfaces are going to change due to this, but your storage implementation requirements are going to be completely different than mine anyway.
Not sure if this is of any use to you, but just wanted to make sure you knew it was there.

This may or may not be useful, but I recently updated my HTTP caching library to handle variants properly and added the logic applicable to shared caches.   It uses the System.Net.HTTP  classes, but most of the logic should be the same.  The logic is based on the diagrams here.

@Tratcher why is this in hosting and not on the https://github.com/aspnet/ResponseCaching repo

@davidfowl because the response caching repo is newer than this issue. It also needed design to figure out where the pieces belonged.  We can close this out now and create new items in ResponseCaching.

https://github.com/aspnet/ResponseCaching/issues/1


[vcpkg] Add disable-lock options

This should fix #14281 at least as a stopgap.
Additionally, adds better errors.

(To clarify, I thought we only set --x-wait-for-lock in the msbuild integration pieces which should be unaffected by this NFS stuff since that's Windows?)

@BillyONeal yeah, disable-lock allows a user to just deal with "locking a file fails for a reason that isn't someone else owning the lock"

@BillyONeal yeah, disable-lock allows a user to just deal with "locking a file fails for a reason that isn't someone else owning the lock"

That's not what this does though; it's making disable-lock unconditionally skip everything related to locking

yeah, exactly; if someone is dealing with "Weird Things", they can use this to disable the lock to just get things working.

yeah, exactly; if someone is dealing with "Weird Things", they can use this to disable the lock to just get things working.

Why can't they just not pass --wait-for-lock then? That's what I meant by

(To clarify, I thought we only set --x-wait-for-lock in the msbuild integration pieces which should be unaffected by this NFS stuff since that's Windows?)

Can't we distinguish between "failed to take the lock because of an error" and "failed to take the lock because there's another vcpkg alive here"?

@BillyONeal yes, we can, that's why --wait-for-lock exists. The errors on the original thread were errors that weren't caused by another vcpkg. Are you asking if we should add a --allow-lock-to-fail or something?

I'm saying that it is unclear here why instead of adding a switch that says "don't do X", we aren't just asking the user to not pass the switch that says "do X". If the user didn't pass --wait-for-lock, why are we treating any management of the lock as a fatal error?

@BillyONeal you need a lock in order to do anything? I'm confused where you're confused.
If you have a vcpkg install going, it needs to access the buildtrees and the like in a mutable way. Therefore, you need mutual exclusion. We do that via the lock file; if --x-wait-for-lock is passed, then we wait until the lock is free, else we try a few times and then print an error if we can't get the lock.
This solves an entirely different issue, which is where the lock isn't get-able for reasons that aren't "it's already taken".

I discussed this with @strega-nil over IM and my confusion was because I was thinking the world was like this:

and so I was wondering why were adding a switch that just undid what another switch did. The actual effects post this PR are:

This is "info:reviewed" but I'm not merging it because Nicole has the power to do that herself and might want further feedback from others on the team


Package with electron command line switches

EG: Electron supports passing flags to the JS-engine like:
$ electron --js-flags="--harmony_proxies --harmony_collections" your-app
https://github.com/atom/electron/blob/master/docs/api/chrome-command-line-switches.md
Can I package my app so that when executed (EG: .exe) it runs with the flags?

As in, without using an application shortcut, or is that OK?

@malept can you please clarify?

When you double-click on the .exe file, is it required that the flags be set? Or is it OK if, for example, you click on the app's entry in the Start Menu (or whatever it's called these days), the flags are set?

On the exe itself (I assume if it is on the exe itself it will be set when calling the .exe from a shortcut)

I point out a difference because with a shortcut, you can specify parameters when you specify which .exe it points to.
That being said, I don't know if either method works. I would have to do a bit of testing in order to figure that out (similar to how #238 was worked through).

@malept :+1:

I'm marking this as an answered question because I have no idea how we would integrate support for this. My opinion is that it should be handled in something like electron-builder (link in readme), where shortcuts for the application can, in theory, be generated.

This seems critical, b/c there is no other way to set -js-flags other than passing them to electron executable.

10 minutes of searching in the Electron issue tracker for "js-flags" led me to this undocumented feature (which was released after this question was asked): https://github.com/electron/electron/pull/4447. Try that and let me know how it works.

@malept Thanks for prompt reply! I'll give it a try shortly.

Unfortunately, after few prompt attempts I was unable to make it work with flags passed via package.json. I abandoned this in favor of few more build steps.
Anyway, big thanks for your efforts!

Did anyone solve this? How can we pass --harmony flag to electron when building?


NPE when accessing layer.symbolMaster().objectID

Our Design team has recently begun making heavy use of symbols with all the goodies that come with that approach (overwrites, nesting, etc). They are using Craft by InVision to sync them across files. When a symbol is not synched or in the process of syncing the export will throw the following error:
Error: null is not an object (evaluating 'layer.symbolMaster().objectID')

Thank you for your feedback, I will install Craft and check the Issues


Fix SVM TSet and Task Example to run with new updates on Twister2-core

Here the issue is with the data format reader.
The existing readers have been updated to read a specific length of bytes per line.
But for general machine learning applications, this may not work as both positive and negative numbers will be associated with it. So this length based model may only work for + valued datasets. So a file reader has to be added to make it more generalized, irrespective of the length of a given line length the data has to be read without losing values.

Could you share the unit test case to reproduce this issue?

@kannang83 I will check this with @pulasthi


Finalizing exercise modification

It's either $n = 16$, either "for each $n$".

Nope, since the original problem is for n in {8,16,...}, while the reduced version of the problem is just n=16.


Simplex method

The simplex method has a bug (can produce segmentation fault). Fix it when possible.

in relax_s and relax_r it does segment fault when s or r is SIZE_MAX

fixed in branch "simplex refactor"


revert old scripts for deploy/upgrade; new deployments

please merge main into this branch to resolve conflicts


Suggest license

Thanks for this package! It's really cool. But I saw that under license, you do not have any license. Legally this means no one can use or modify it. Can you add a license?
For more on this you can read this  page.

Thank you, i need to decide on a license… Any ideas on the pros and cons?

Gonna go MIT.


add nobuild option to snapshot

As discussed on Twitter, I added the option. Ruby is new for me, so please comment if there is anything that I should change ;)

Looks good, have you tested it?

I ran the modified version with a Fastfile which looked like this:
fastlane_version "1.9.0"

default_platform :ios

platform :ios do

    desc "Create screenshots for all the devices"
    lane :screenshots do
        snapshot(
            nobuild: true
        )
    end
end

with the following output:
[10:40:10]: -------------------------------------------------
[10:40:10]: --- Step: Verifying required fastlane version ---
[10:40:10]: -------------------------------------------------
[10:40:10]: fastlane version valid
[10:40:10]: ------------------------------
[10:40:10]: --- Step: default_platform ---
[10:40:10]: ------------------------------
[10:40:10]: Driving the lane 'ios screenshots' 🚀
[10:40:10]: ----------------------
[10:40:10]: --- Step: snapshot ---
[10:40:10]: ----------------------
[10:40:10]: #############################################################
[10:40:10]: # xctool is recommended to build the apps
[10:40:10]: # Install it using 'brew install xctool'
[10:40:10]: # Falling back to xcode build instead
[10:40:10]: #############################################################
2015-07-17 10:40:10.832 xcodebuild[2336:24375] [MT] PluginLoading: Required plug-in compatibility UUID 7FDF5C7A-131F-4ABB-9EDC-8C5F8F0B8A90 for plug-in at path '~/Library/Application Support/Developer/Shared/Xcode/Plug-ins/GitDiff.xcplugin' not present in DVTPlugInCompatibilityUUIDs
[10:40:11]: Reinstalling app...
[10:40:21]: Running tests on iPhone 6 Plus (8.4 Simulator) in language de-DE (locale de-DE)
[10:40:21]: instruments -w 'iPhone 6 Plus (8.4 Simulator)' -D '/tmp/snapshot_traces/trace' -t 'Automation' /Users/ffittschen/hybrid-app/builds/testapp/platforms/ios/build/emulator/testapp.app -e UIARESULTSPATH '/tmp/snapshot_traces' -e UIASCRIPT '/Users/ffittschen/hybrid-app/builds/testapp/platforms/ios/.fastlane/snapshot.js' -AppleLanguages '(de-DE)' -AppleLocale 'de-DE'
[10:40:32]: Successfully took screenshot 📱
[10:40:32]: Successfully took screenshot 📱
[10:40:34]: Successfully took screenshot 📱
[10:40:40]: Successfully took screenshot 📱
[10:40:41]: Going to remove the alpha channel from generated png files
[10:40:42]: Finished removing the alpha channel.
[10:40:42]: Going to rotate screenshots from generated png files
[10:40:42]: Reinstalling app...
[10:40:52]: Running tests on iPhone 6 (8.4 Simulator) in language de-DE (locale de-DE)
[10:40:52]: instruments -w 'iPhone 6 (8.4 Simulator)' -D '/tmp/snapshot_traces/trace' -t 'Automation' /Users/ffittschen/hybrid-app/builds/testapp/platforms/ios/build/emulator/testapp.app -e UIARESULTSPATH '/tmp/snapshot_traces' -e UIASCRIPT '/Users/ffittschen/hybrid-app/builds/testapp/platforms/ios/.fastlane/snapshot.js' -AppleLanguages '(de-DE)' -AppleLocale 'de-DE'
[10:41:01]: Successfully took screenshot 📱
[10:41:02]: Successfully took screenshot 📱
[10:41:05]: Successfully took screenshot 📱
[10:41:10]: Successfully took screenshot 📱
[10:41:11]: Going to remove the alpha channel from generated png files
[10:41:11]: Finished removing the alpha channel.
[10:41:11]: Going to rotate screenshots from generated png files
[10:41:12]: Reinstalling app...
[10:41:21]: Running tests on iPhone 5 (8.4 Simulator) in language de-DE (locale de-DE)
[10:41:21]: instruments -w 'iPhone 5 (8.4 Simulator)' -D '/tmp/snapshot_traces/trace' -t 'Automation' /Users/ffittschen/hybrid-app/builds/testapp/platforms/ios/build/emulator/testapp.app -e UIARESULTSPATH '/tmp/snapshot_traces' -e UIASCRIPT '/Users/ffittschen/hybrid-app/builds/testapp/platforms/ios/.fastlane/snapshot.js' -AppleLanguages '(de-DE)' -AppleLocale 'de-DE'
[10:41:26]: Running tests on iPhone 5 (8.4 Simulator) in language de-DE (locale de-DE)
[10:41:26]: instruments -w 'iPhone 5 (8.4 Simulator)' -D '/tmp/snapshot_traces/trace' -t 'Automation' /Users/ffittschen/hybrid-app/builds/testapp/platforms/ios/build/emulator/testapp.app -e UIARESULTSPATH '/tmp/snapshot_traces' -e UIASCRIPT '/Users/ffittschen/hybrid-app/builds/testapp/platforms/ios/.fastlane/snapshot.js' -AppleLanguages '(de-DE)' -AppleLocale 'de-DE'
[10:41:32]: Successfully took screenshot 📱
[10:41:33]: Successfully took screenshot 📱
[10:41:35]: Successfully took screenshot 📱
[10:41:40]: Successfully took screenshot 📱
[10:41:41]: Going to remove the alpha channel from generated png files
[10:41:41]: Finished removing the alpha channel.
[10:41:41]: Going to rotate screenshots from generated png files
[10:41:41]: Reinstalling app...
[10:41:56]: Running tests on iPhone 4s (8.4 Simulator) in language de-DE (locale de-DE)
[10:41:56]: instruments -w 'iPhone 4s (8.4 Simulator)' -D '/tmp/snapshot_traces/trace' -t 'Automation' /Users/ffittschen/hybrid-app/builds/testapp/platforms/ios/build/emulator/testapp.app -e UIARESULTSPATH '/tmp/snapshot_traces' -e UIASCRIPT '/Users/ffittschen/hybrid-app/builds/testapp/platforms/ios/.fastlane/snapshot.js' -AppleLanguages '(de-DE)' -AppleLocale 'de-DE'
[10:42:06]: Successfully took screenshot 📱
[10:42:07]: Successfully took screenshot 📱
[10:42:09]: Successfully took screenshot 📱
[10:42:14]: Successfully took screenshot 📱
[10:42:14]: Going to remove the alpha channel from generated png files
[10:42:15]: Finished removing the alpha channel.
[10:42:15]: Going to rotate screenshots from generated png files
[10:42:15]: Successfully created HTML file with an overview of all the screenshots: '/Users/ffittschen/hybrid-app/builds/testapp/screenshots/screenshots.html'
[10:42:15]: Successfully finished generating 16 screenshots.
[10:42:15]: Check it out here: /Users/ffittschen/hybrid-app/builds/testapp/screenshots
[10:42:15]: fastlane.tools finished successfully 🎉

Done, without errors.

Looks good, thanks @ffittschen


standalone containers do not honor defaultPolicyAction - "deny" and groupby "allow" policy

Rancher Versions: Build from master with catalog from branch - https://github.com/rancher/rancher-catalog branch - v1.4.0-rc2
Host Docker Version: 1.12.6
Deploy "policy-manager" from catalog - https://github.com/leodotcloud/test-policy-manager.
Set defaultPolicyAction to "Deny" and policy to
{
  "between": {
    "groupBy": "testme"
  },
  "action": "allow"
}

to allow for traffic within containers with group by label.
Steps to reproduce the problem:
Create few standalone containers - c1,c2 and c3 with label "testme"="value1"
Create stack1 with few services and 1 of the services - S1 having label "testme"="value1".
Containers c1,c2 and c3 are able to communicate each other.
Container c3 is not able to communicate with containers of service S1 even though the values on the group by labels matches.

Tested with Rancher Versions:v1.4.0-rc3 with leodotcloud/policy-manager:dev3
standalone containers honor the defaultPolicyAction - "deny" and groupby "allow" policy.


Update index.md

added "- Typing 'pwd' will show you which directory you are currently working in."

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Please use PR titles which explain what you are changing instead of "update index.md". If it is a translation, please also indicate translation: language name.  This let's the reviewer quickly know what kind of contribution you have made.
Thank you

LGTM

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


adds a testing scenario for rolling updates

This currently tests a rolling update on a cluster using dmcrypt dedicated journals from jewel to kraken. I had to change to using yum_repository to manage the ceph_stable repo because the ceph-release package from jewel -> kraken has the same version number and yum does not know to update anything. Also, this ways gives us much more flexibility in using other mirrors.

PR adding the scenario to jenkins here https://github.com/ceph/ceph-build/pull/636

jenkins test ansible2.2-update_dmcrypt

jenkins test ansible2.2-purge_cluster


Error with version 2.0.11

Hi,
After installing last version (2.0.11), the error below is thrown on prod building.
It seems like the package is not correctly built.

ERROR in Error: Unexpected value 'Daterangepicker in .../node_modules/ng2-daterangepicker/index.d.ts' imported by the module 'SharedModule

Regards,
Fernando

Please try v2.0.12 and revert. v2.0.11 is broken

Hi @evansmwendwa,
Updated and checked. It works smoothly again.
Thanks!


I think we should replace "Mean height" with "Average Height Deviation"

In the "Special Values", we report "RMS height" and also "Mean height". I don't think this makes sense because the mean height is normally equal to zero (or, e.g., -6e-18) since most surfaces are mean-subtracted upon entering them.
Perhaps we should report the Average Height Deviation instead, which is <|h-h_mean|>.
NOTE: In terms of nomenclature, the RMS height is similar to "Rq" and the Average Height Deviation is similar to "Ra" - but we cannot call them Rq and Ra because, to compute those, you typically do gaussian filtering ahead of time (per ISO and ASTM standards)
-Tevis

Not all standards gave that filter.

In the current version, the tab "special values" does not longer exist. All these values are reported under "Roughness parameters". Here there is only "RMS Height" (Rq) is reported, no "Mean height" any more.
Is this still an issue?


Will codes such as training be released in the future?

Hello, thank you for such a great article. I would like to ask whether the data preprocessing part and the code training verification part will be released in the future？

We are working actively on releasing the data preprocessing part! The verification might take slightly longer.


Fix unclosed session bug

Make sure defer sess.Close() always gets hit.

LGTM

LGTM

This is not real a bug. When you call x.Where().Find, session.Close is not necessary since Find will check and close that.


Making available? timeout use provided ssh_options, fixes #362

So super slow connections (like CI) can still work, fixes https://github.com/chef/chef-provisioning/issues/362
\cc @randomcamel @jkeiser

:+1:


added articles #138

@Timonwa i have added some articles i found good, please check it

thank you @Shivam36998


Prevent deep linking to third party applications

Is it possible to disable deep linking to other app, for instance if I have amazon installed on my device and open an amazon url with the web view it's pushing me to the amazon app, however I would like to open the amazon website inside the web view ?
Thanks for the help

I was having a similar problem when WebView was trying to open plaidlink://* and I wasn't able to control it. And I noticed that if you add the 3rd party protocol to the originWhitelist, you'd be able to control it inside the onShouldStartLoadWithRequest function:
Something like:
<WebView
  source={{ uri: generateLinkInitializationURL() }}
  onShouldStartLoadWithRequest={request => {
    if (request.url.startsWith('plaidlink')) {
      ...
      return false;
    }

    return true;
  }}
  originWhitelist={['https://*', 'plaidlink://*']}
/>

The workaround provided by @gaykov worked for me. I used it to disable mailto: links found in a web view.

@dcalhoun Is there a workaround that does not disables the links rather makes sure that they are opened within the app webview ? (As asked in the original question that trying to make sure amazon.com opens within the webview not in the amazon app)

@dcalhoun Is there a workaround that does not disables the links rather makes sure that they are opened within the app webview ? (As asked in the original question that trying to make sure amazon.com opens within the webview not in the amazon app)

@Yahyaali1 I'm not sure. To my knowledge, controlling whether a link opens the web browser or a different dedicated app is solely controlled by the user through long-pressing the link and selecting the desired app.

@Yahyaali1 I'm not sure. To my knowledge, controlling whether a link opens the web browser or a different dedicated app is solely controlled by the user through long-pressing the link and selecting the desired app.

@Yahyaali1 did you ever get this to work? I’m trying to default to the Spotify web player but it always opens the app.

@mandersondesign does the usecase involves user clicking a link from within webview page ? If so, I was not able to do much about that usecase.

has anyone solved it? i would like to avoid opening Facebook and instagram when visiting the relevant sites.

@invyctus92 Here is my finding on the use case.
You can try to intercept the page load using onShouldStartLoadWithRequest by returning false to match specific url pattern and re render the webview with the new url. This technique is based on similar idea discussed in this article

Having this issue too

Hello everyone, I found a workaround for myself that worked for me. I had to make some native changes to the library and commit them using patch-package. In the file node_modules / react-native-webview / apple / RNCWebView.m it was like this:
  if (_onShouldStartLoadWithRequest) {
    NSMutableDictionary<NSString *, id> *event = [self baseEvent];
    [event addEntriesFromDictionary: @{
      @"url": (request.URL).absoluteString,
      @"mainDocumentURL": (request.mainDocumentURL).absoluteString,
      @"navigationType": navigationTypes[@(navigationType)],
      @"isTopFrame": @(isTopFrame)
    }];
    if (![self.delegate webView:self
      shouldStartLoadForRequest:event
                   withCallback:_onShouldStartLoadWithRequest]) {
      decisionHandler(WKNavigationActionPolicyCancel);
      return;
    }
  }

it became like this:
  if (_onShouldStartLoadWithRequest) {
    NSMutableDictionary<NSString *, id> *event = [self baseEvent];
    [event addEntriesFromDictionary: @{
      @"url": (request.URL).absoluteString,
      @"mainDocumentURL": (request.mainDocumentURL).absoluteString,
      @"navigationType": navigationTypes[@(navigationType)],
      @"isTopFrame": @(isTopFrame)
    }];
    if ([request.URL.host<EMAIL_ADDRESS>{
      decisionHandler(WKNavigationActionPolicyAllow);
      return;
    }
    if (![self.delegate webView:self
      shouldStartLoadForRequest:event
                   withCallback:_onShouldStartLoadWithRequest]) {
      decisionHandler(WKNavigationActionPolicyCancel);
      return;
    }
  }

In my case, the changes are only needed for 'instagram', and they do not work perfectly, because instagram makes a tricky interception - and the direct link to the profile still opens in the application, but the rest of the pages work fine in the  webview. As you can see, you can write your own condition exactly to your needs, and possibly change the default one so that all requests are processed like this, but I don’t know what it will lead to. Maybe it can help someone.

I was able to get this to work by looking at the event.navigationType.
If a user 'clicked' on the link, that's what was causing it to open in the third party app. If they simply entered the url, it would open in the webview. So here's how i did it (setUri is just a state hook to update the uri and disabledList is just an array of domains i want to stop from opening externally).
onShouldStartLoadWithRequest={(e: ShouldStartLoadRequest) => {                         if (bcHtmlParser.getIsOnDisableList(e.url) && e.navigationType === 'click') {                             setUri(e.url);                             return false;                         }                         return true;                     }}

We Still have the same issue...
https://github.com/react-native-webview/react-native-webview/issues/3435

onShouldStartLoadWithRequest={(e: ShouldStartLoadRequest) => { if (bcHtmlParser.getIsOnDisableList(e.url) && e.navigationType === 'click') { setUri(e.url); return false; } return true; }}

This actually worked !!!!
Here is formatted example for other people
`
const disabledList = ['example.com', 'unwanteddomain.com']; // Array of domains to block
const [uri, setUri] = useState(''); // State hook to update the URI
const onShouldStartLoadWithRequest = (event: ShouldStartLoadRequest) => {
// Parse the URL from the event
const urlHost = new URL(event.url).hostname;
// Check if the URL host is in the disabled list and the navigation was triggered by a click
if (disabledList.includes(urlHost) && event.navigationType === 'click') {
setUri(event.url); // Update the state to the new URI
return false; // Prevent loading the URL to block opening it externally
}
return true; // Allow loading URLs not in the disabled list or not clicked
};
`

@jeffBoom any Idea why this fix worked?
It's some http header that causes to open the app, because we still have some corner case on iOS that the app is opened even with your fix.....
The websites do 2 redirects and then the app opens, I tried to do the same trick , but then the webview not loading at all

onShouldStartLoadWithRequest={(e: ShouldStartLoadRequest) => { if (bcHtmlParser.getIsOnDisableList(e.url) && e.navigationType === 'click') { setUri(e.url); return false; } return true; }}

This actually worked !!!!
Here is formatted example for other people
const disabledList = ['example.com', 'unwanteddomain.com']; // Array of domains to block

const [uri, setUri] = useState(''); // State hook to update the URI

const onShouldStartLoadWithRequest = (event: ShouldStartLoadRequest) => {
  // Parse the URL from the event
  const urlHost = new URL(event.url).hostname;

  // Check if the URL host is in the disabled list and the navigation was triggered by a click
  if (disabledList.includes(urlHost) && event.navigationType === 'click') {
    setUri(event.url); // Update the state to the new URI
    return false; // Prevent loading the URL to block opening it externally
  }

  return true; // Allow loading URLs not in the disabled list or not clicked
};

This workaround only works for iOS, as android does not expose navigationType.


Fix doctests for swc_ecma_quote

Description:
Fix errors from cargo test -p swc_ecma_quote --doc (part of cargo test).
Related issue (if exists):
I suspect this was broken by

#5713
#6797

although I wonder why this hasn’t been noticed—am I the first to try running cargo test?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I reverted this as this broke the CI


Allow overriding config struct defaults

Summary
Follow-on to #2836, adds the ability to change defaults in fields from a parent struct.  This probably only works one-level-deep, but that seems sufficent.
Fixes #2838
Change Type
Mark the type of change your PR introduces:

[ ] Bug fix (resolves an issue without affecting existing features)
[x] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[x] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Updated test to take advantage of struct override; some additional manual tests with different values in the test (not included in the final PR).
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[x] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[x] Included tests that validate the fix or feature.
[x] Checked that related changes are merged.

coverage: 47.542% (+0.05%) from 47.496%
when pulling 9ec8533111bbec233f9156de12574895a8a316f9 on evankanderson:2838-allow-overriding-config-struct-defaults
into 4ac6c49185afe2a7fd55964bbd0a59af64e2c7ed on stacklok:main.

What is the difference between this PR and PR #2836 ?

What is the difference between this PR and PR #2836 ?

This incorporated #2836, but adds support for the following:
type SQLEventConfig struct {
	// InitSchema is whether or not to initialize the schema
	InitSchema bool                  `mapstructure:"init_schema" default:"true"`
	Connection config.DatabaseConfig `mapstructure:"connection" default:"{\"dbname\":\"watermill\"}"`
}

Where we override the dbname field of the Connection, since config.DatabaseConfig is used several places.