Prevent editing distance field on the duplicate confirm page

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/45833
PROPOSAL: https://github.com/Expensify/App/issues/45833#issuecomment-2241283131
Tests

Submit two similar distance requests to a workspace.
Notice the review duplicate button pops up.
Click Review Duplicate.
Click Keep this one for any one transaction on the review page.
Go through the follow till Confirm page.
Click Distance field on Confirm page.
Note that the distance edit page does not open.

[x] Verify that no errors appear in the JS console

Offline tests

Submit two similar distance requests to a workspace.
Notice the review duplicate button pops up.
Go Offline.
Click Review Duplicate.
Click Keep this one for any one transaction on the review page.
Go through the follow till Confirm page.
Click Distance field on Confirm page.
Note that the distance edit page does not open.

QA Steps

Submit two similar distance requests to a workspace.
Notice the review duplicate button pops up.
Click Review Duplicate.
Click Keep this one for any one transaction on the review page.
Go through the follow till Confirm page.
Click Distance field on Confirm page.
Note that the distance edit page does not open.

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes

[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)

[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/88c608db-c01a-413c-aefb-7005a8137428

Android: mWeb Chrome

https://github.com/user-attachments/assets/2c330244-3af4-4bc1-914f-d328f4430294

iOS: Native

https://github.com/user-attachments/assets/eda2918a-29c8-438f-b948-eff104485b5b

iOS: mWeb Safari

https://github.com/user-attachments/assets/eed87bbd-8c86-4ce2-bac7-3d86d7796a9f

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/0dcaabb5-9781-4fdd-af6a-7c618da04ab3

MacOS: Desktop

https://github.com/user-attachments/assets/f5914136-d434-4adc-bfa7-1fafcb6d5fa5

@mountiny I was autoassigned as C+ for the issue and later unassigned. If this PR needs a C+ review I can do that.

@c3024 fair, yeah go ahead please

NAB: When a field is not interactive I think not showing the right icon is appropriate.

It is not a regression as it as per the design.

So you mean this was just not implemented in the first PR intentionally?

Thanks, bumped the price to 250 🚀

Ah, damn, sorry, I got confused. @c3024 @parasharrajat Can you show how it looks side by side and @pecanoro @Expensify/design can decide

I'm not quite following, but if you can't edit the push-to-page rows here:

Then we should make them look read-only and remove the right-arrow and hover interaction.

Then we should make them look read-only and remove the right-arrow and hover interaction.

They are readonly and there is no hover effect. Just wanted to confirm if we remove the right icon as well.
@mountiny Here are the screenshots.

We might make them editable later but for now, yeah, we should remove the arrows and make them all non-editable

That looks better to me.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/52ce4dfe-75ef-4651-b756-66813a74a88a

Android: mWeb Chrome
https://github.com/user-attachments/assets/835a3eff-d600-44c8-923e-22c83da0bbfe

iOS: Native
https://github.com/user-attachments/assets/ceca6c0a-c07e-4f13-b761-2e5c7640489b

iOS: mWeb Safari
https://github.com/user-attachments/assets/037bd66c-a2e5-4750-b553-1379260ac696

MacOS: Chrome / Safari

MacOS: Desktop
https://github.com/user-attachments/assets/55b029dd-d075-44ba-bc72-4be4c0c06bc5

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.13-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.13-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
failure ❌


⚠ Roblox Devhub has degraded performance

In d36fcd0, Roblox Devhub (https://developer.roblox.com) experienced degraded performance:

HTTP code: 200
Response time: 2002 ms

Resolved: Roblox Devhub performance has improved in 99961e1.


whenXXXDo: convenience methods should be removed

because they introduce limitation for elements event handlers management.
example:
but := ToButton new.
but whenClickedDo: [:event | bla bla ].

can be coded as :
but := ToButton new.
handler := BlEventHandler on: BlClickedEvent do: [:event | bla bla ].
but addEventHandler: handler.

which allows to remove/replace the event handler as in:
but removeEventHandler: handler.
handler := ...
but addEventHandler: handler.

Also related to https://github.com/pharo-graphics/Bloc/issues/257


Update README.md

just a few typos corrected

Thanks! Could you maybe also update this in en/README.md so they're both in sync? :)

just a few typos corrected

I don't know how to use this app please tell me!

Closing for inactivity, please feel free to reopen when the above is resolved.


Remapping CapsLock to Ctrl(left) results into pressing Shift+Ctrl(caps on keyboard) (in the exact order) recognized as layout changing when in Japanese IME

Microsoft PowerToys version
0.80.0
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
Keyboard Manager
Steps to reproduce

map capslock to ctrl(left)
map ctrl(left) to capslock
switch to either official Japanese IME or Google one.
pressing shift and press ctrl (capslock on keyboard)

✔ Expected Behavior
Nothing will happen. And any keys pressed next will triggle ctrl+shift+that key's expected function.
❌ Actual Behavior
A in the right bottom corner is switched to あ, vise versa. i.e. the layout of Japanese IME is changed. (the google one will actually toggle between _A and あ, I don't know what that mean)
And any key pressed next wouldn't form the expected function. It types that letter in capital case.
Repeating above procudure will randomly result in "ctrl get stucked", which is as if the ctrl is being pressing although none of the keys is touched. repress the real ctrl (left bottom of keyboard) will solve this issue. I can't reproduce this very frepuently. So just for a record.
Other Software
Windows 10 22H2
Google Japanese IME 2.29.5370.0
I don't know the version of Micosoft Japanese IME, but that suffers from the same problem. So I think this is more like a Key remapping issue.

Temporary solution: Use SharpKeys instead.

I encountered a very similar issue, and it was recommended that I reply to this thread instead of making a new thread.
The difference is disabling the mouse scroll.
Microsoft PowerToys version
0.85.1
Installation method
GitHub, Other (please specify in "Steps to Reproduce")
Running as admin
No
Area(s) with issue?
Keyboard Manager
Steps to reproduce
Enable Keyboard Manager with the following settings, using a Japanese (JIS) keyboard

IME Non-Convert -> Apps/Menu
Shift(left) -> Ctrl(left)
VK 240 (capslock) -> Shift(left)
Ctrl(left) -> VK 240

✔ Expected Behavior
As the settings
❌ Actual Behavior
2 phenomena happen.

Abnormal key reactions while Kyeboard Manage is on. For example, when I hit the VK 240 key, it must serve as a shift key as the settings, but it (probably) serves as shift + capslock. This phenomenon does not happen when Keyboard Manager is disabled
Mouse scroll is disabled in some applications (e.g., Chrome) after abling Keyboard Manager. It lasts even after disabling Keyboard Manager.

Other Software
Chrome (ver. 129.0.6668.101（Official Build）)
a text editor (SAKURA editor; Ver. <IP_ADDRESS>48)
MS Word (Ver 2409)


[rtl/sram] change CTRL to write-only

Currently the CTRL csr was "r0w1c", so it was not possible to
successfully trigger a key request.
This PR changes to "wo" and regenerates the csr regfile.
Signed-off-by: Udi Jonnalagadda<EMAIL_ADDRESS>

Looks good and was failing only the FPGA tests in CI, which are diagnosed in #5029. Merging.


Update CloudDemo app to .NET 6

use aspnet:6.0 Docker image
use net6.0 as target framework
enable nullable-checks
update copyright headers

You need to change the runTests.ps file to builf using the .NET 6 target as well.

Thanks! I fixed that it tests are green now.


Fix filter CLI arg

Fixes issue https://github.com/GalAvineri/ISIC-Archive-Downloader/issues/15

Thank you very much for your help! :)


Fix progress aborted by callback

CURLOPT_PROGRESSFUNCTION return a non-zero value to abort the transfer. In which case, the transfer will set a CURLE_ABORTED_BY_CALLBACK error.
Request option progress cannot abort the transfer now.

Thanks for your contribution, I will review it shortly.

ping?

Hello. Any updates?

any possibility to merge in near future?

@sagikazarmark When is soon?

Thank you for this PR. Could you rebase on master please?

@Nyholm
Completed, the BC Check failing, but look like is not my fault.

@consatan Could you rebase again, please?


revert: NetRegexes.ability

use NetRegexes.ability for Ability triggers
NetRegexes.ability will generate regex with type 2[12] but buildRegex('Ability', ...) generate a regex with type 21


ARTEMIS-3163 Experimental support for Netty IO_URING incubator

I got interested by #3479 and decided to test those changes out against a "fresh" build of the broker. I found it quite impressive and decided to implement what was discussed on @franz1981 original pr in hopes it would interest someone else. I take no credit for this PR, as it contains almost exclusively the original changes and what was discussed in #3479.
One thing I did actually change was to default the amount of "remotingThreads" to 1 instead of "3 * CPUCount" (for IO_URING) based on suggestions in the original PR as well as here: netty-incubator-transport-io_uring/issues/106#issuecomment-876173958
According to my own testing this is what the default value should be, with only a few "extremes"  benefiting from a few more.
I have seen some impressive results from using IO_URING as the transport that I should be able to share after a few more rounds of testing.

Well done and thanks @AntonRoskvist !!

Thanks, but again, it's primarily your work 🙂
It would be interesting to see how the journal would perform under IO_URING as well, but that seems to be a significantly larger change.

+100

As discussed on the offshoot PR on Franz' fork repo back then  (https://github.com/franz1981/activemq-artemis/pull/15), I'd still be inclined to make the deps optional/provided even now, especially given it is disabled by default, would be untested, and most wont use it whilst those who do can easily add it.
I'm also not sure it makes sense to include hard deps on the incubator artifacts at this late stage when Netty 4.2 will actually bring them into the main repo (https://github.com/netty/netty/tree/4.2/transport-native-io_uring) and so changes their GAVs significantly, which seems likely to cause users friction with a hard dep present.

@gemmellr Oh, I completely missed the discussion on the forked repo. I agree that if the Netty 4.2 release is close it makes sense to wait for it.
Does anyone have an idea of when it might reach a stable release? It looks like it will enter beta stage next?
If the Netty release and it's adoption into Artemis is some time away though, I think that marking these dependencies as optional would largely make this PR unnecessary. Probably very few (if any) will take the time to work that into their deploys and as such it wont generate any usage data/feedback either.
So I think we should either:
Wait for the Netty release (closing/holding this PR) or go with the incubator dependencies included (until we move to Netty 4.2).

Personally I wouldnt do either of those. I would either proceed without using hard deps, or wait for 4.2 without hard deps.  Given the Pr has sat for 3.5 years at this stage, I would probably go for the latter personally, unless someone knows 4.2 will be ages, but so far it doesnt seem like it.
In both cases I think its premature including the deps for all client and broker users when most wont use it as its disabled, and given that we wouldn't actually be testing it at all. A hard dep with either 4.1 or 4.2 cases will also likely add user friction as consuming builds straddle the 4.1/4.2 transition, which is just another reason not to add a hard dep for me when its easy for those who want it to add it.

I would suggest waiting until 4.2 is released and the feature becomes part of netty proper and has the testing behind it to ensure a reasonable user experience along with sufficient testing.


Unable to integrate Google OAuth - response.headers?.entries is not a function

Log on the console:
api | 20:43:41 🌲 request completed 201ms
api | 20:44:20 🌲 incoming request GET xxx /auth/oauth?method=signupWithGoogle&state=http%3A%2F%2Flocalhost%3A3007%2Flogin&code=4%2F0AeanS0bEo-h85GtxcJU_hz4rSOz35bz_ypQ1FLy8Brrq7SiBIqVAPDg1q0utQAfVvjFNuQ&scope=email+profile+openid+https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fuserinfo.email+https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fuserinfo.profile&authuser=0&prompt=none
api | 20:44:20 🚨 response.headers?.entries is not a function
api |
api | 🚨 TypeError Info
api |
api | {}
api |
api | 🥞 Error Stack
api |
api | TypeError: response.headers?.entries is not a function
api |     at OAuthHandler.createResponse (/path/to/project/node_modules/@spoonjoy/redwoodjs-dbauth-oauth-api/node_modules/@redwoodjs/auth-dbauth-api/dist/shared.js:214:47)
api |     at OAuthHandler.<anonymous> (/path/to/project/node_modules/@spoonjoy/redwoodjs-dbauth-oauth-api/dist/OAuthHandler.js:967:33)
api |     at Generator.throw (<anonymous>)
api |     at rejected (/path/to/project/node_modules/@spoonjoy/redwoodjs-dbauth-oauth-api/dist/OAuthHandler.js:29:65)
api |     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
api |
api | 20:44:20 🌲 request completed 109ms

Settings:
FE_URL="http://localhost:3007"
RWJS_API_URL="http://localhost:8917"

GOOGLE_CLIENT_ID = "MY-CLIENT-ID"
GOOGLE_CLIENT_SECRET = "MY-CLIENT-SECRET"
GOOGLE_REDIRECT_URL="http://localhost:8917/auth/oauth?method=signupWithGoogle"

I have another question around how to integrate both signup and login? Use different ENV var for each? I don't think using only one env var is gonna work becasue of the /method=.
Node: 20.11.1
@redwoodjs/core: 7.7.3 => 7.7.3

Nevermind, i was setting redirect url to be the backend, it has to be frontend's function


Canonicity proof to show remaining admit in erasure

This proves that closed values (for weak call-by-value evaluation) of (co)-inductive type (under axiom-free contexts) are canonically headed by constructors or cofixpoints. For inductives, only constructors apply. This actually applies to any strategy that produces weak-head normal-forms (e.g, a lazy one would work too).
This requires to simultaneously prove that stuck fixpoints are impossible at the head of a closed term as their recursive argument must be a constructor.

Does this also give an easy proof that CIC is consistent (with the normalisation assumption)?

Absolutely!

It also allows to simplify wcbveval and remove the is_Construct_app tests, that's my next step.


Define color styles in Figma

Acceptance criteria

Define a "pool" of colors with corresponding variable names
The same names should be used both in Figma and as CSS variables
No states and no usage related information in the names

In order to ensure good quality we should (Keep the ones we need for this US)

[ ] Extra focus on usability
[ ] Test for accessibility

I added most of the colours from Figma as CSS variables

But the colours in this picture don't match this pattern, as they have state and usage information in their names:

@BirteThornquist Should we see if we find an even better way of naming the colors?


Help on how to assign the directory role to restore the users

The customer is using the service principal to restore the users
In this case, he tries to restore the user who is Global Administrator or a user administrator
He is assigned the application type permission user.read.write.all
But to delete the user the application needs the directory role like Global administrator or the user administrator I explain to the customer this by the design of the graph API and redirect them to this page. He wants to have that documented in this doc to share with their customers because the doc only talks about the user, not the application.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0767aac4-fcd9-eaac-2c30-8f17d8eadd92
Version Independent ID: a380a828-03f9-e037-3a62-e4165fda7cb6
Content: Azure AD built-in roles - Azure Active Directory - Microsoft Entra
Content Source: articles/active-directory/roles/permissions-reference.md
Service: active-directory
Sub-service: roles
GitHub Login: @rolyon
Microsoft Alias: rolyon

@nukala29
Thanks for your feedback! We will investigate and update as appropriate.

Hi @nukala29
Yes, you are correct. The Azure Active Directory built-in roles have specific permissions that allow you to perform certain actions on the directory. For example, the Global Administrator role has the permission to delete users, while the User Administrator role has the permission to restore users.
However, if you are using a service principal to perform these actions, you will need to assign the appropriate permissions to the service principal. This can be done by using the Azure AD Graph API or the Azure AD PowerShell cmdlets.
For more information on the permissions available for service principals, you can refer to the following documentation:
App permissions for custom roles in Azure Active Directory: https://github.com/MicrosoftDocs/azure-docs/blob/main/articles/active-directory/roles/custom-enterprise-app-permissions.md
Default user permissions - Azure Active Directory: https://github.com/MicrosoftDocs/azure-docs/blob/main/articles/active-directory/fundamentals/users-default-permissions.md
Azure AD built-in roles: https://learn.microsoft.com/en-us/azure/active-directory/roles/permissions-reference
Additionally, you can use the Azure AD Graph API to query the permissions assigned to a service principal. For example, you can use the following API call to get the permissions assigned to a service principal with the object ID "12345678-1234-1234-1234-123456789012":
GET https://graph.microsoft.com/v1.0/servicePrincipals/12345678-1234-1234-1234-123456789012/appRoleAssignedTo
This will return a list of app roles and their corresponding permissions that have been assigned to the service principal. You can then use this information to verify that the service principal has the necessary permissions to perform the desired actions.
https://learn.microsoft.com/en-us/azure/active-directory/develop/app-objects-and-service-principals
I hope this helps. Let me know if you have any further questions.

@nukala29
We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


msl libraries

Since the move of msl to the graphics backends, msl libraries are disabled. That feature need to be back.

[x] Call libs in msl code
[ ] Backtrack all shaders in the backends that use those libraries and recompile. (Optional)

Using shader libraries is already working.

Backtracking is done in the msl database when updating shaders. This causes another problem tough. See #64


Compound Unique Index

Add support for compound index as in MongoDB https://www.mongodb.com/docs/manual/core/index-compound/
Basically it is an index on multiple fields, for example we want to have unique a combination of some fields.

It might not be immediately clear since the expression "compound" is not used in the ArangoDB documentation, but you can already create indexes covering multiple fields in ArangoDB. See https://www.arangodb.com/docs/3.9/indexing-index-basics.html#indexing-attributes-and-sub-attributes

It doesn't work in this case
@Edge(value = "roles")
public class Role{
    @Id
    private String id;

    @From
    private Actor actor;

    @To
    private Movie movie;
}

@Document
public class Movie movie{
    @Id
    private String id;

    private String name;
}

@Document
public class Actor actor{
    @Id
    private String id;

    private String name;
}

db.roles.ensureIndex({ type: "persistent", fields: [ "actor", "movie" ], unique: true })

When I try to save second movie for the same user I get the error
Response: 409, Error: 1210 - AQL: unique constraint violated - in index idx_1730726459385839616 of type persistent over 'actor, movie';

https://github.com/arangodb/spring-data/issues/235

As I understand from the article I need to use _from and _to
db.roles.ensureIndex({ type: "persistent", fields: [ "_from", "_to" ], unique: true })

I am not familiar with this Java library and its annotations, but I would assume that @From and @To map to the edge internal _from, _to attributes. So yes, you should create an index with the fields [ "_from", "_to" ].

Also see https://www.arangodb.com/docs/stable/indexing-index-basics.html#ensuring-uniqueness-of-relations-in-edge-collections


After selecting single package to update upon update completion the UI list of packages remains blank does not refresh

This is on the current prerelease.  To reproduce:  list all local packages with available updates.  Select any single package and perform update, expand console output to watch progress.  Upon successful completion, the UI appears to refresh based on status/progress bar, but will always return to an (inaccurate) empty UI list still with the checkbox checked for "show only packages with updates" as shown here:
https://1drv.ms/i/s!AhSqjTYUuHPKgb93o4ohovXPaAfLHQ
Upon clicking to uncheck the "show only packages with updates" box, and then re-checking (enabling) it in a 2-click operation results in the correct full list of locally installed packages with updates available that was initially shown prior to the update operation once again being correctly displayed.  This manual workaround is currently necessary for every package update operation.

@CollinChaffin thanks for reporting this issue.  We think that this should now be taken care of.  If you have the time, if you could take a look at the most recent version of Chocolatey GUI from the MyGet feed and let us know, we would really appreciate it.  Thanks.


Error when opening a board that has cards without a linked issue

I have a GitHub project board that contains many cards that are not linked to any GitHub issue:

When I try to open this board in Squello, I get a MessageNotUnderstood: UndefinedObject>>readStream:

In SPBCardBuilder>>buildFromRemote:into:, the JSON object does not contain a content_url. Most likely, a nil check and some default values for the card are missing here. :-)

Hey,
you should be able to open the board now, but your notes will not show up. That is (currently) intended as we are only using the issue-cards. The notes were not important to our customer so they will have to wait until the next iteration :)
The corresponding user story for the note-support is #40

A little bit late response from my side, but thanks for the follow-up! :-)


cargo loco generate controller guide -k api

Description
Per doc, https://loco.rs/docs/getting-started/guide/ , generates the controller body:
#![allow(clippy::unused_async)]
use loco_rs::prelude::*;
pub async fn echo(req_body: String) -> String {
req_body
}
pub async fn hello(State(_ctx): State) -> Result {
// do something with context (database, etc)
format::text("hello")
}
pub fn routes() -> Routes {
Routes::new()
.prefix("guide")
.add("/", get(hello))
.add("/echo", post(echo))
}
I'm including the file path and file name of what was actually generated:
File: src/controllers/guide.rs
#![allow(clippy::missing_errors_doc)]
#![allow(clippy::unnecessary_struct_initialization)]
#![allow(clippy::unused_async)]
use loco_rs::prelude::*;
use axum::debug_handler;
#[debug_handler]
pub async fn index(State(_ctx): State) -> Result {
format::empty()
}
pub fn routes() -> Routes {
Routes::new()
.prefix("guides/")
.add("/", get(index))
}
To Reproduce
I ran the command cargo loco generate controller guide -k api in the myapp directory.
File src/bin/main.rs:
use loco_rs::cli;
use myapp::app::App;
use migration::Migrator;
#[tokio::main]
async fn main() -> loco_rs::Result<()> {
cli::main::<App, Migrator>().await
}
File: myapp/Cargo.toml
[workspace]
[package]
name = "myapp"
version = "0.1.0"
edition = "2021"
publish = false
default-run = "myapp-cli"
See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
[dependencies]
loco-rs = { version = "0.10.1" }
migration = { path = "migration" }
serde = { version = "1", features = ["derive"] }
serde_json = "1"
tokio = { version = "1.33.0", default-features = false }
async-trait = "0.1.74"
tracing = "0.1.40"
chrono = "0.4"
validator = { version = "0.18" }
sea-orm = { version = "1.0.0", features = [
"sqlx-sqlite",
"sqlx-postgres",
"runtime-tokio-rustls",
"macros",
] }
axum = "0.7.5"
include_dir = "0.7"
uuid = { version = "1.6.0", features = ["v4"] }
tracing-subscriber = { version = "0.3.17", features = ["env-filter", "json"] }
view engine i18n
fluent-templates = { version = "0.8.0", features = ["tera"] }
unic-langid = "0.9.4"
/view engine
[[bin]]
name = "myapp-cli"
path = "src/bin/main.rs"
required-features = []
[[bin]]
name = "tool"
path = "src/bin/tool.rs"
required-features = []
[dev-dependencies]
serial_test = "3.1.1"
rstest = "0.21.0"
loco-rs = { version = "0.10.1", features = ["testing"] }
insta = { version = "1.34.0", features = ["redactions", "yaml", "filters"] }
Expected Behavior
Within my src/controllers/guide.rs file, I expected to see the following:
#![allow(clippy::unused_async)]
use loco_rs::prelude::*;
pub async fn echo(req_body: String) -> String {
req_body
}
pub async fn hello(State(_ctx): State) -> Result {
// do something with context (database, etc)
format::text("hello")
}
pub fn routes() -> Routes {
Routes::new()
.prefix("guide")
.add("/", get(hello))
.add("/echo", post(echo))
}
Environment:
My OS is a Mac, which is up to date. Rust version is 1.81.0 (not nightly)
Additional Context
I would have to know more about the code process to determine what causes this issue.

It's a little hard to see what is going on because the code you posted is not formatted, do you mind formatting it so it is more readable?
It's also not clear what the problem is that you are facing. Is the issue that the docs do not generate the same code as the CLI tool? Is that causing any compilation issues, or are you just noting that to make us aware? A little more clarification is needed.

Sorry it took so long to reply.  The docs do not generate the same code as the CLI tool.  After running the command
cargo loco generate controller guide -k api, I expected to see the following in the guide.rs file:
#![allow(clippy::unused_async)]
use loco_rs::prelude::*;
pub async fn echo(req_body: String) -> String {
req_body
}
pub async fn hello(State(_ctx): State) -> Result {
// do something with context (database, etc)
format::text("hello")
}
pub fn routes() -> Routes {
Routes::new()
.prefix("guide")
.add("/", get(hello))
.add("/echo", post(echo))
}
*** What I actually had in my generated file is as follows:
#![allow(clippy::missing_errors_doc)]
#![allow(clippy::unnecessary_struct_initialization)]
#![allow(clippy::unused_async)]
use loco_rs::prelude::*;
use axum::debug_handler;
#[debug_handler]
pub async fn index(State(_ctx): State) -> Result {
format::empty()
}
pub fn routes() -> Routes {
Routes::new()
.prefix("guides/")
.add("/", get(index))
}
** I hope this clears up what I was attempting to address earlier.  Let me know if you have any questions/concerns and thanks for looking into this.

because

I totally agree with your assessment that the way I previously had the issue displayed caused it to be difficult to read thus understand.  It has been corrected.  I hope this was the proper way to reply to you as I'm still getting use to this.


[Sluggable] Use anchored regex query in ODM adapter

Using an anchored regex query will take advantage of MongoDB indexes. See: http://www.mongodb.org/display/DOCS/Advanced+Queries#AdvancedQueries-RegularExpressions
After implementing this fix on an older branch, I realized it builds upon: 96550fd512af1decc7042cfa8d77fd0f41f2111b. This commits adds the fix to replaceRelative() and also uses preg_quote() for escaping the slug in the MongoRegex pattern.

Note: after running bin/vendors, I noticed a ton of test failures attempting to run this test suite. I believe bin/vendors needs to be updated to account for recent changes in the doctrine/mongodb and mongodb-odm repositories.
Additionally, when I did have the test suite running with older vendor libs, I don't believe the code changed in this commit was even covered by the Sluggable test cases. That's certainly something to look into in the future.

thanks, recently sortable tests were broken, but @lbotsch will take care of it, all these errors known and should be fixed by contributors. Also cases with slug handlers are not implemented fully.

@l3pp4rd which tests do you mean? when I run the test suite (from the master branch), all tests are passing...

@lbotsch sortable tests, it fails, cannot locate fixtures Paper etc for sortable in dir requested by test

Oh you're right! Sorry, forgot to commit them... (fixed)

thanks!


Chore: Remove unused jira integration and unused tables related to db_migration_config

🔖 Feature description

Removed/ clean up unused db_tables: db_migration_config, db_config
Remove unused jira integration and related code

🎤 Pitch / Usecases
Clean up and remove unused integrations in the code base
🔄 Alternative
No response
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

AB#7981

Fixed by the attached PR


Fix create failure with REPLICA_COUNT <= 1

The glusterfs-volume-create container will fail to create the initial volume for catalog/community:convoy-glusterfs if rancher-compose scale: 1.

Very stale. Closing


Fix tool choice structure

The existing structure for ToolChoice::SpecificTool results in an API error: tool_choice.type: Field required, because the API is expecting {"type": "tool", "name": string}.
I've fixed this, while also adding with_tool_choice and modifying the tools example to specify the choice of tool with --with-tool-choice. I used the last one for testing - feel free to remove the corresponding commit if it doesn't fit with your vision for the example.

LGTM, thank you.


KibiTest.h not included in test code folder

Should just put it in there for simplicity.

Decided not to put it there, since it can be had on github already, not a big deal to get it. Also I am the only one who is going to be running the tests anyway.


Created illustratorLayerIdsToClasses plugin

Addition of a plugin that scans elements for data-name or id attributes and copies the value to the class attribute.
This is intended to be used with the Adobe Illustrator export option "Object IDs: Layer Names" to make it easier to get meaningful class names exported into SVGs from Illustrator.
I have a blog post that explains the intended use case: https://codingwithspike.wordpress.com/2016/05/01/css-styling-illustrator-svgs/
Since this is intended to be used with Illustrator exported SVGs, the plugin is disabled by default.
I updated the README.ru.md file with a Google translation from my english. Feel free to re-translate.

Coverage remained the same at 88.947% when pulling aa5358cd31c3ba4da72c1493f4dce705ec6e27ca on rally25rs:illustratorLayerIdsToClasses into e0ca3f09efe343b0c8c8e9df16e65f796a8ab81e on svg:master.

Coverage remained the same at 88.947% when pulling 24b38aa6557f46b065f579ff2487bdd151276b70 on rally25rs:illustratorLayerIdsToClasses into e0ca3f09efe343b0c8c8e9df16e65f796a8ab81e on svg:master.

Can anyone comment on why some PRs (like this one) are being left open for months without any comments, but other PRs are being accepted/merged?

Yes, sorry for the delay. Unfortunately, your PR is out of scope of SVGO, and thus I cannot accept it. It just have nothing with optimization which is the purpose of SVGO.

Unfortunately, your PR is out of scope of SVGO, and thus I cannot accept it.

I think that's up for discussion if it's out of scope. (Personally, I don't really have an opinion on this.)
But since this is a plugin that can be disabled by default, I don't see a reason why it shouldn't be included if it's a reasonably common use case.

I doubt its a common use case, but it let me clean up my illustrator exported SVGs in one pass through SVGO. I can certainly find another more general SVG manipulating package and move my plugin there and pass images through 2 applications.

I think the SVGO plugin setup is a bit more complicated than necessary, but as far as I could see it, bundling SVGO for in-browser won't include unsused plugins. Therefore, I don't see a reason not to include this plugin.

Closing it since it doesn't have any relation to optimization.


ChunkedStorage finished (possibly).

@fexio,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Good job @fexio. Please have a look at the review.

Also, Feng, could you please switch the target branch to availability? fexio-availability is temporary created for sending a PR to you, and will be removed.

closing in regard to #129


Move Chairperson to top, add note

Moves the CC Chairperson (@nebrius) to the top, adds a note that they are the Chairperson. Final step in https://github.com/nodejs/community-committee/issues/30.

is this meeting agenda or does it need more signoff?

Nope, we can merge it. I approved it really quickly, and I wanted to let it sit for another 24 hours to let other people comment. I, of course, then forgot to come back 24 hours later and merge 😅


Selection updates are slow in large directories

We should use the new Collections OrderedDictionary to allow for both ordering and quick lookup by identifier.

#517 switches to OrderedDictionary internally to model the file list, but this doesn't seem to perform significantly faster.


no-duplicate-properties should allow repeat properties when they are directly next to each other

Duplicating properties is sometimes required - such as when providing fallbacks for unsupported features, e.g. the following is a legitimate usage but currently raises a warning:
.foo {
  display: inline-block;
  display: flex;
}

Sass-lint should follow CSSLint's lead and allow duplicate properties when they have different values but are immediately next to each other. I.e. the following are warnings:
/* properties with the same value */
.mybox {
  border: 1px solid black;
  border: 1px solid black;
}

/* properties separated by another property */
.mybox {
  border: 1px solid black;
  color: green;
  border: 1px solid red;
}

But the following should be acceptable, and not raise a warning:
/* one after another with different values */
.mybox {
  border: 1px solid black;
  border: 1px solid red;
}

I think this should be an extra option, by default it should disallow completely because I think this waters the rule down a lot.
If we had an option such as allow-unique-values or allow-fallback-properties (both awful names I know) I feel this would allow us to dial the rule down rather than start so watered down.
Do we also think that maybe a whitelist of available duplicates as well as them being unique values would be appreciated?

Happy for this to be an option. I agree that strictness by default is preferable. It looks like scss-lint doesn't deal with this either.
We have whitelists in other rules so that sounds handy for consistency. As most of the time needing fallbacks is for display as per my initial example and color things so you can specify a hex color and upgrade to an rgba color, it feels like this is only going to kick in on a subset of properties anyway so limiting that sounds useful.

Ok I think the whitelist is the way to go then. Checking for unique values may prove too far reaching, Simply adding your properties to an allowed-duplicates whitelist would leave the implementation down to the user but avoid the warnings this rule was meant for.

If we're going to allow a whitelist for this rule, it needs to be a whitelist on the full declaration (display: block, for instance) and not just the property name, as otherwise it provides a large opportunity to a user to shoot themselves in the foot.

Hmm I don't see that as too practical then really. Font fallbacks for rem's for example is one case where you'd need to whitelist every single pixel size used. This is probably another case where #70 would be useful.
If we were to whitelist just the property name but then still raise a warning/error if the duplicate property wasn't on the next line as above I feel that any major user error here would be avoided?
// even if border is whitelisted then raise an issue here.
.mybox {
  border: 1px solid black;
  color: green;
  border: 1px solid red;
}

Agreed that #70 might be a preferable solution to whitelisting explicit properties. This sort of defining fallback properties would probably be done within mixins so people wouldn't have to pepper their entire codebase with the ignore comments.
I don't think the whitelist for the full declaration would be feasible, along with @DanPurdy's rem with px fallback, my other most common usage of duplicate properties is for rgba with a hex color fallback which would also require a laundry list of exceptions.

As long as the whitelist is only if they are right next to each other, that's okay by me for a less restrictive whitelist

On Oct 10, 2015, at 7:15 PM, Ben Scott<EMAIL_ADDRESS>wrote:
Agreed that #70 might be a preferable solution to whitelisting explicit properties. This sort of defining fallback properties would probably be done within mixins so people wouldn't have to pepper their entire codebase with the ignore comments.
I don't think the whitelist for the full declaration would be feasible, along with @DanPurdy's rem with px fallback, my other most common usage of duplicate properties is for rgba with a hex color fallback which would also require a laundry list of exceptions.
—
Reply to this email directly or view it on GitHub.

Agreed

So... Rather embarrassingly I just went to look at this and there is already an exclusion whitelist option.. It's not as tight an implementation as we just discussed but nonetheless it exists. I will update the documentation with examples.

Sorry to comment on an old closed issue, but I arrived here after using make-sass-lint-config, receiving the following message:
# The following settings/values are unsupported by sass-lint:
# Linter DuplicateProperty, option "ignore_consecutive"

See scss-lint docs.
I think adding an option that allows properties not because they are in a whitelist but simply because they are right after the other is very convenient and can accomodate many edge-cases (think of calc()).

Hey @mcdado can you open a separate issue up for this please if you'd like to suggest it as a feature. 👍

Okay! 😉 https://github.com/sasstools/sass-lint/issues/726


Kernel Died when export_coreml

I have trouble exporting the simple model I created for classifying images of my and my cats, the code runs well through saving the model, but every time I try to export the model by "model.export_coreml('me-mimi.mlmodel')" it fails and the kernel stop (error message screenshot below). Does anyone knows why and what I can do to fix it? thanks!

import turicreate as tc
import os
data = tc.image_analysis.load_images('mimi_me', with_path = True)
data['label'] = data['path'].apply(lambda path:'me' if '/me' in path else 'mimi')
data.save('me-mimi.sframe')
data = tc.SFrame('me-mimi.sframe/')
train_set, test_set = data.random_split(0.8)
model = tc.image_classifier.create(train_set, target='label')
predictions = model.evaluate(test_set)
model.save('me-mimi.model')
model.export_coreml('me-mimi.mlmodel')

Does it work if you run the code directly in the terminal? If it does not work in the terminal, do you get a stacktrace or any additional information?

have you solved it?

no I haven't solve it yet, same happen if I run code in terminal. I am using a 14inch M1 MacBook Pro, does it has something to do with this issue?

yeah, persons who are using M1 getting the same issue

Does the code work when run not from juypter notebook (e.x. from the terminal)?
Please verify your notebook is running using Rosetta. What is the output of the following code?
import os
print(os.system('uname -a'))

Looks like it's running using Rosetta (note the x86_64). So I don't think this is an M1 issue.
Does the code work if ran from the terminal, not from Juypter notebook?

I'm having the same problem, has someone fixed it?

The reason of crash is in TensorFlow. Python 3.8 pulls TensorFlow, which is not built for M processors, that's why it's crashing on exit code 132 (interrupted by signal 4:SIGILL). I managed to run Turi Create only on Mac with Intel chip.


ForkTsCheckerWebpackPlugin configuration has an unknown property 'tsconfig'.

Current Behavior
An unhandled exception occurred: Invalid configuration object. ForkTsCheckerWebpackPlugin has been initialized using a configuration object that does not match the API schema.
 - configuration has an unknown property 'tsconfig'. These properties are valid:
   object { async?, typescript?, eslint?, formatter?, issue?, logger? }

Expected Behavior
Vue app is served normally
Steps to Reproduce
Update deps in vue app to. (To use latest vue-devtools)
"vue": "^3.0.0-rc.10"
"@vue/cli-plugin-typescript": "~4.5.4",
"@vue/cli-service": "~4.5.4",
"@vue/compiler-sfc": "3.0.0-rc.10",

Hi!, so we manage to make Vue 3 work inside of the monorepo, but latest "@vue/cli-plugin-typescript": "~4.5.4" have a breaking change https://github.com/vuejs/vue-cli/commit/1aaa59264235b83cb1e2700ab2cf3aa04b40c907#diff-5bd90b2d73b2975144503cb89f9bc5ba  for the fork-ts-checker-webpack-plugin-v5`

If you cannot reproduce this using Vue 2, then I'm going to close this issue. I described a workaround for this here.


Upgrade from v. 0.7.13 results is monero.common.MoneroError: Wallet is not connected to daemon

Call to: MoneroWalletFull.openWallet(config);
results in:
monero.common.MoneroError: Wallet is not connected to daemon
at monero.wallet.MoneroWalletFull.startSyncing(MoneroWalletFull.java:636) ~[monero-java-0.8.33.jar:na]
with following config:
wallet.xmr.open.serverUsername=superuser
wallet.xmr.open.serverPassword=abctesting123
wallet.xmr.open.serverUri=http://localhost:18081
Upon further investigation, the error is caused by changes in monero.wallet.model.MoneroWalletConfig as follows:
serverUsername and serverPassword and server.serverCredentials are all reset to null:
it looks from the code the intent was: one of the calls - setServerUsername() or setServerPassword() will set credentials on the server.  However, a call to  setServerUri() comes in between these two calls and resets both serverPassword and serverUsername to null by calling setServer() and passing the server that was only constructed with serverUri but not serverUsername and serverPassword.  Thus configuration does not work anymore.  Additianally, there is no way to set serverUsername and serverPassword from configuration anymore.

However, a call to setServerUri() comes in between these two calls

AFAICT, the only way the credentials are nullified, is if a null URI is passed, or if the URI is set after the credentials are set. To improve this, setServerUri could be modified to set the username and password if they're both provided, and not nullify the username and password if null URI is passed.
But now, just confirming that you can set the credentials after setting the server URI in order to fix the connection issue.
Looking at the code, setting the username, then URI to non-null value, then setting the password, should also work, because the URI will initialize the server connection without credentials, and then setting the password will update the server connection credentials with both username and password. Please let me know if you see otherwise.


Use XDG Base Directory for storing config

Summary
Suggestion to put deta's config at XDG base dir
Proposed Changes
XDG Base Directory is a specification that defines where files should go. In this specification, it also defines where programs would put the config, called XDG_CONFIG_HOME, which defaults to $HOME/.config.
Deta could use this specification, which means that the config will be placed under $XDG_CONFIG_HOME/deta.
Rationale
Standardization, and making $HOME less cluttered.
Reference

https://wiki.archlinux.org/title/XDG_Base_Directory
https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html

+1

sorry @whinee @faynopi  closing the issue since the repository is now being archived. You can contact us on discord or by email if you have any questions/concerns.


[To Main] DESENG-515: Multi-language - Create event, subcribe_item, poll, timeline widget translation tables & API routes

Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-515
Description of changes:

Added Poll answer translation API.
Added Timeline Event translation API.
Added Subscribe Item translation API.
Added Event item translation API
Added Unit tests.

Feature PR approved
https://github.com/bcgov/met-public/pull/2414 - Approved
https://github.com/bcgov/met-public/pull/2416 - Approved
https://github.com/bcgov/met-public/pull/2418 - Approved
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Codecov Report
Attention: Patch coverage is 87.57447% with 146 lines in your changes are missing coverage. Please review.

Project coverage is 75.39%. Comparing base (8366029) to head (1c946c4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2421      +/-   ##
==========================================
+ Coverage   74.65%   75.39%   +0.74%
==========================================
  Files         537      557      +20
  Lines       18555    19636    +1081
  Branches     1349     1347       -2
==========================================
+ Hits        13852    14805     +953
- Misses       4496     4624     +128
  Partials      207      207

Flag
Coverage Δ

metapi
85.87% <87.57%> (+0.20%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

met-api/src/met_api/auth.py
100.00% <100.00%> (ø)

met-api/src/met_api/models/__init__.py
100.00% <100.00%> (ø)

met-api/src/met_api/resources/__init__.py
100.00% <100.00%> (ø)

...t-api/src/met_api/resources/engagement_metadata.py
83.18% <100.00%> (+2.57%)
:arrow_up:

met-api/src/met_api/resources/metadata_taxon.py
88.23% <100.00%> (+0.53%)
:arrow_up:

met-api/src/met_api/schemas/engagement_metadata.py
82.00% <100.00%> (+2.00%)
:arrow_up:

...-api/src/met_api/schemas/engagement_translation.py
100.00% <100.00%> (ø)

...c/met_api/schemas/event_item_translation_schema.py
100.00% <100.00%> (ø)

.../met_api/schemas/poll_answer_translation_schema.py
100.00% <100.00%> (ø)

...t_api/schemas/subscribe_item_translation_schema.py
100.00% <100.00%> (ø)

... and 33 more


fix(page): fix page.off method for request event

What kind of change does this PR introduce?
This patch fixes page.off for request event
Did you add tests for your changes?
Yes
Summary
Fixe the issue #7572
Does this PR introduce a breaking change?
No

@edgardmessias Thanks for your contribution! Happy to get this landed :)

@jschfflr you are welcome.
I think you need allow the GitHub CI here to allow the merge


Fix log scale in dump_ciede2000.py

The initial log scale was 20*log10(mean(ciede2000)) which absurdly increases as quality lowers.
So negate the scale and offset 45-20*log10(mean(ciede2000)) where 20*log10(10**2.25)==45 because the range of delta values for all Rec.709 YCbCr values is bounded by 10**2.25, given our parameters. The scale should be similar to PSNR.

Looks good. I will add this to AWCY.


[Feature Request] Quick variable editing

Is your feature request related to a problem? Please describe.
Editing variables currently take at least 3 clicks:

The environments dropdown
Manage Environment button
(Select environment)
Click inside the text field

Describe the solution you'd like
When clicking on a variable, in the "Edit Variable" dialog, should have a quick way to change the variable. This would be simpler:

Click variable where it's used
Click field

Would be either below or above the preview:

Describe alternatives you've considered
Can't think of any simple solution that would be low effort like this one.

This would be kinda tricky

You have to know which environment to edit, either the currently selected one or the base environment
When using templated variables {{_.url}}/{{_.path}}/{{ _.userID }}, it wouldn't be clear which variable to edit. I think the best UX would be to have an input field to edit for each variable that is used in the template, but that might be difficult.
Custom templates are even more tricky and probably should/could not be editable

If this is limited to only editing plain variables, with no templating, it should be pretty straightforward and add some value.
I attempted that and got it sort of working, but I don't think I'm familiar enough with Nunjuncks to get it fully working.
https://github.com/nbgraham/insomnia/pull/1
I would need to

detect if the selected variable is templated and hid the edit field
update the environment correctly, to only edit that one value and not remove the other existing values
figure out the timing to update the live preview. After the update, the next get sometimes still has the old value. I added a setTimeout which usually works but is pretty hacky.


Langchain Llava Node instead of Llama Node

Hello, I have been try to use the chatbot_ros project with the explicability_ros project and decided that I wanted to try to get it to describe images. I chased my tail on trying to get a proper prompt generated for such a thing but I think the issue comes down to that when it calls back to llama_ros in langchain even though I am using the llava-mistral-7b model there is something in the langchain wrapper that is not providing the correct input to the model. Maybe it is as simple as if I am passing an image I need to make sure it is properly added to GenerateResponse.action???
Any help you can provide would be greatly apperciated!
Kyle

Here is a test script I tried:
import base64
import httpx
import rclpy
from llama_ros.langchain import LlamaROS
from langchain_core.prompts import ChatPromptTemplate
from langchain.prompts import PromptTemplate
from langchain_core.output_parsers import StrOutputParser
from langchain_core.runnables import RunnablePassthrough
rclpy.init()
create the llama_ros llm for langchain
llm = LlamaROS()
create a prompt template
image_prompt = ChatPromptTemplate.from_messages(
[
("system", "Describe the image?"),
(
"user",
[
{
"type": "image_url",
"image_url": {"url": "data:image/jpeg;base64,{image_data}"},
}
],
),
])
image_question_chain = (
{
"image_data": RunnablePassthrough()
}
| image_prompt
| llm
| StrOutputParser()
)
create a chain with the llm and the prompt template
image_url = "https://upload.wikimedia.org/wikipedia/commons/thumb/d/dd/Gfp-wisconsin-madison-the-nature-boardwalk.jpg/2560px-Gfp-wisconsin-madison-the-nature-boardwalk.jpg"
image_data = base64.b64encode(httpx.get(image_url).content).decode("utf-8")
for c in image_question_chain.stream(image_data):
print(c, flush=True, end="")
First I tried this and it seemed to never respond so I tried stream (above) too...
answer = image_question_chain.invoke(image_data)
print(f"ANSWER: {answer}")
rclpy.shutdown()

Sorry about the odd formatting?!?!?

Hey @kyle-redyeti, first of all, how are you running llava-mistral? You may need to set the namespace to llava lm = LlamaROS(namespace="llava"). I've been reading the LangChain code, I think there is VLM support for ChatPromptTemplate so a new Chat model must be implemented for llama_ros, similar to the ChatOllama that can handle images.

Here you have an example with the LangChain wrapper modified.

I wanted to check first if I was missing something that already existed.
Next, I think I will try just having the llava llama ros running and not
use the Langchain for image queries but still use it for RAG/text.  I think
that will get me by for awhile until I can dig in deeper on a bigger change.
If I am using: LlamaROS(namespace="llava") am I right in think I could
still use a GenerateResponse with an image like the Llava_demo_node does?
Thanks for your help!
Kyle
On Sun, Jul 21, 2024, 12:26 PM Miguel Ángel González Santamarta <
@.***> wrote:

Here https://github.com/mgonzs13/llama_ros?tab=readme-ov-file#llava_ros
you have an example with the LangChain wrapper modified.
—
Reply to this email directly, view it on GitHub
https://github.com/mgonzs13/llama_ros/issues/9#issuecomment-2241719607,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF2TVXBKNR2K7652HYW723LZNPVMLAVCNFSM6AAAAABLE5WYASVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBRG4YTSNRQG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

If I am using: LlamaROS(namespace="llava") am I right in think I could still use a GenerateResponse with an image like the Llava_demo_node does? Thanks for your help! Kyle
Yes, the wrapper will add the image to the GenerateResponse goal similar to the demo.

@mgonzs13 Thank you again for the help!  I was able to get the example script to run and it does produce a response as I expected.  I will have to do some work to get it into my pipeline with your Chatbot_ROS and Explainable_ROS.


[aes/syn] Update GTECH flow for AES wrapper

This separate synthesis target for the AES wrapper is only intended to produce a mapping of the wrapper alone. The motivation for synthesizing AES and the wrapper separately is that we can ensure that no sort of optimization takes place across the hierarchy boundary between them (the wrapper is TB code whereas the AES is actual synthesizable code).
In order to achieve this we just remove the aes module from the working lib after elaboration.
Signed-off-by: Michael Schaffner<EMAIL_ADDRESS>

The last force push aligns the AES security parameters in the wrapper with the top-level.

FYI, the security parameters were chosen like this on purpose to reduce 1) the simulation run time and 2) the number of test points for the initial experiments. With the real parameters, the module runs about 5 times longer and is at least 4 times bigger. But I agree that we are mainly interested in seeing what happens for the real thing.

Ok, understood.
However, since we need to synthesize the wrapper for the final experiments I thought we should rather switch on the real thing now to get accurate results...


Ensure InputLocator functions create folders if they don't exist yet

In order to remove the __init__.py files from the reference-case folder structures, we need to make sure that paths returned from the InputLocator actually reference existing folders. This can be done with the os.makedirs function as used in the PR #348. Make sure this technique is applied for all such folders.
Implementation hint: Extract a function "ensure_folder_exists" and wrap the return statements with a call to this function. This could also be implemented as a decorator...

see _ensure_folder in PR #428


Allow the use of shared memory.

This went a little too easily, so I'm suspicious, but it looks as if I'm testing it fairly thoroughly.
Certainly it is clear that if you don't create a custom data_maker, everything is just the same!
This still doesn't let us go MP, but it's a big step in that direction.

Looks great :) Merge at will.


Protobuf 3 Swift 3 Code-gen issue with reserved words

I'm using the latest (this morning) version of the ProtoBuf3.0-Swift3.0 branch.
I'm finding an issue that didn't happen with the previous code around code generation when a protobuf message uses Swift keywords as properties.
This is a client project so I can't attach the proto file, but here's the issue: the message definition has properties with names like "static" and "required". The Swift code-gen worked previously, but now it is generating code that looks like this:
      if hasStatic {
          if let varSize`static` = `static`?.computeMessageSize(fieldNumber: 9) {
              serialize_size += varSizestatic
          }
      }
      if hasRequired {
          if let varSize`required` = `required`?.computeMessageSize(fieldNumber: 10) {
              serialize_size += varSizerequired
          }
      }

Notice the backticks in the middle of the "varSizeStatic" where it is attempting to escape the reserved word but doing so in the middle of the Swift name causes an error.
Whereas this would have been more correct:
      if hasStatic {
          if let `varSizestatic` = `static`?.computeMessageSize(fieldNumber: 9) {
              serialize_size += varSizestatic
          }
      }
      if hasRequired {
          if let `varSizerequired` = `required`?.computeMessageSize(fieldNumber: 10) {
              serialize_size += varSizerequired
          }
      }

I fixed this in pull request #164 , which @alexeyxo then based his changes on. I am not on the latest code yet, so am not sure how it ended up.

Done.


Create Table Issue

Title: Newly created tables.
**Describe the bug**
The newly created tables are not displayed in the new tab.

**To Reproduce**
Steps to reproduce the behavior:
1. Go to 'Create Table'
2. Add columns.
3. Click 'Submit'  which returns you to the CRUD window.
4. Look at the tab of the newly created table.

**Expected behavior**
The tab for the newly created table should display the list of columns assigned to it. The attributes should also appear on the left (Information).

Already Fix at #34


'Load the client certificate' should be 'Load the root CA certificate for Server'

The title and description in this section should be corrected to root CA certificate, which is used to verify server identity
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fc223e57-432c-6cd3-f5bf-de8a787a5e90
Version Independent ID: f2c0b36f-5daf-cf52-e604-1ee837e97ea4
Content: Use wolfSSL for TLS connections - Azure Sphere
Content Source: AzureSphere/articles/app-development/wolfssl-tls.md
Product: azure-sphere
GitHub Login: @kangsu
Microsoft Alias: azurespheredocs

@xiongyu0523
I have assigned the issue to the content author for further review and update the doc as appropriate.

Hello @kangsu Thanks for your patience on this issue,
We intend to update the documentation soon. Will provide more updates soon.

@xiongyu0523 This document has been updated.


bump go version

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

13 of 13 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 91.875%

Totals

Change from base Build<PHONE_NUMBER>2:
0.1%

Covered Lines:
1357

Relevant Lines:
1477

💛  - Coveralls


[Bug]: The URL field for APIs is deleting all text after a ?  whenever optional chaining or ternary operators are used.

Is there an existing issue for this?

[X] I have searched the existing issues

Description
The URL field for APIs is not saving the entered URL properly when optional chaining or ternary operators are used. At first, the editor evaluates the JS as valid and shows the correct evaluated value. But when you view another API/Query/JS Object and come back, the ? and all text after it has been deleted.
Example:
https://someAPI.com/products?page={{appsmith.store?.pageNo||1}}
After viewing another API and returning to first API:
https://someAPI.com/products?page={{appsmith.store
The URL is truncated at the ?, and even the closing mustache binding is lost.
Steps To Reproduce

add mustache bindings and JS expression to API’s URL field, using optional chaining or ternary operator (anything with a ?)
click to a different API/Query, then come back to first API
observe that the ? and all text after are lost, including the closing }}.

Public Sample App
No response
Version
Appsmith v1.7.4-SNAPSHOT

@Nikhil-Nandagopal , @rohan-arthur , a little more background on this issue:
When an API's URL references another API which has not ran yet, the evaluated value at the URL is invalid and returns an error in the editor.
Example:
https://storename.myshopify.com/admin/api/2021-10/products/{{findProducts.data[0].id}}/variants.json
This causes an error in the editor until findProducts has run, which needs an input from the user for a custom search. So I don't want the findProducts query to run on page load. I expect there to be no data in findProducts on page load.
But now there is always an error in the editor for this API until the findProducts API returns data. And I have this same scenario with multiple endpoints in the same app, resulting in numerous errors on page load.
All of these errors could be avoided with optional chaining. However, this bug causes the API's URL value to be deleted/truncated after the ?, so optional chaining can not be used. It would be a great improvement to the editor if these nuisance errors could be avoided. Currently it is hard to notice new errors in the editor when the count always shows as 9+.

@GreenFlux are you still facing this issue? I could get ternary operators to work on an API URL
https://opentdb.com/api.php?amount={{Api5.data ? Api5.data.results.length : 2}}

@bharath31 , I just retested. It looks like this has been fixed! Previously, ternary operators, and optional chaining, both caused all text to be lost after the ?, but I am not able to reproduce either issue now.

Awesome! Closing this issue now :)


WiFi and TFT simultaneous

Why doesn't work WiFi and TFT at the same time in my CYD?

You'll have to give more info because it does for me

Hi Brian, IT WORKS,!
I had a wrong board selected in Arduino IDE...
sorry,
Fritz

Great!


Rewrite Logger module

The Logger class is a static class. Even if you remove the use of Singleton pattern usage, the problem remains the same. It is impossible to create multiple Logger objects. We need to rewrite this module and come up with a better solution

I am not sure is it a great idea. 'It is impossible to create multiple Logger objects' actually class is multiton(at least I tried to make it multiton). As for me, best solution would be multiton, since we do not want any additional setup code(we can use just simple macros and everything works out of the box) + these macros are not included in release build.
We could use simple classes for loggers like
auto logger = Logger(...);

logger.log<INFO>("Hey im logged")

but this is not really convenient. If this Logger is needed somewhere else, we need to pass it, or somehow inject it(also logger would be automatically bundled in release builds). Either way, eventually we are gonna have to some sort of static active logger field
Welp, but if you have any good ideas, you are welcome

Ok, I see your idea. I agree with you, that passing the logger to object constructors will lead to a mess. We need to avoid this and come up with a better solution.
But it would be nice to be able to create multiple loggers, like in python. I think it would be nice to have an engine logger for engine logs (this could save a lot of time in the future when debugging code) and allow the user to create their own logger objects for logging in-game.
I think we can discuss it later. Logger is not our main priority at the moment 😁


A couple fixes

Fixes #269: Refactored datastore profile methods to not throw sql "no row" errors. This means that on mobile, GetTokens, GetUsername, and GetAvatarId will return empty strings if nothing is found and NO error. (we can't return nil because gobind doesn't support string pointers.
Fixes #271 Adds caching to avatars. The mechanism no longer uses a redirect, instead loads content behind the avatar_id directly. Expiration set at 2 days.
Fixes #270 Comments and Likes will now be empty arrays (not null)
Removes AddThreadWithMnemonic, it's not useful anymore and likely making creating threads slower from mobile, which was wrapping that method. Mobile now uses the normal create thread method, meaning it's signature doesn't have the string param mnemonic anymore
Lastly, adds the actual comment to comment notifications

I can't decide if we should commit to returning empty strings for those methods that previously threw sql errors. Even though the errors don't feel ideal, I'm wondering if that is the more idiomatic solution, especially if we want to make the generated frameworks usable in Java/Swift/Obj C. Thoughts?

Leaning towards just making the error more meaningful.

I'd prefer to stick with the empty string for now. It's the best we can do for "doesn't exist", and not existing is not an error state here. Also in Go, empty strings are just the "0 value" of a string, since optionals aren't a thing. Another option is to make the bridges take the string and convert to whatever language specific null value it wants.

We'd return a nil byte slice. A string here is more consistent with the current API.

cool

We could also return an empty object in JSON "{}"... maybe that's more consistent?

(since the expected result is an object)

Did you list exhaustively the methods that now could return ''? Or should I be looking into getId, getPublicKey etc?

I think GetUsername is the only other method that could return "" as a non-error state, as in, while at the same time as err == nil


Disable Night Mode for specific pages

I've started using Kiwi recently, and I really like the Night Mode feature. Unfortunately it still breaks the readability of quite a few websites, so I have to manually disable it there. That's perfectly fine, even tho I'm sure the Night Mode is continuously improved to play nicely with as many pages as possible, there will always be exceptions.
My issue is that I want to keep Night Mode on for basically all webpages, and only turn it off manually for pages that don't support it. Right now I can only toggle Night Mode globally for all pages: so every time I visit the same (known problematic) page I go "ugh now I have to turn off Night Mode" and after I'm done I might have forgotten to turn it back on again for the other pages and my eyes bleed. And if I switch back to the tab after that, I have to toggle it back off AGAIN,... you get the idea. It works, but it's terrible.
So my question is: how can I have Night Mode on in general, but declare some websites an exception where Night Mode is automatically disabled while I'm there? If this is not possible, I'd like to make a feature request.

I agree. Some websites are being broken with dark mode.

@kiwibrowser

Personally... It appears that this browser just might be sorta... Discontinued, but I do hope that I'm wrong.
~Ibuprophen

Bump

Knock knock


TRUE 0 PRED [0.]

always had result after testing =(

Hi @pavelxx1 , what do you mean? Please try to be clearer.

after successfully training ,when I do inference ,
result always false (

Sorry, but without your dataset and your steps I can't help you.


⚠ Bofrost.at has degraded performance

In 70fbc2b, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1876 ms

Resolved: Bofrost.at performance has improved in f9c53d7.


Add external Ceph cluster support

This patch introduces the API extension to support an external Ceph cluster in
the cinder operator. If Ceph is present (CephMonHosts, CephClusterFSID and
CephClienKey passed as input), the rbd driver is configured and can be enabled
through the customServiceConfig volume API key. The common-API structure has
been extended and now includes the CephBackend parameters used to provide all
the information required to setup the "rbd" backend when the config file are
created. The CephBackend belongs to the common-API since it's common to have an
external Ceph cluster serving multiple instances/workloads.
Signed-off-by: Francesco Pantano<EMAIL_ADDRESS>

@dprince @abays This is pretty much the same thing we did in the glance-operator. Due to the nature of the component, at some point I imagine the two implementations taking two different paths, but atm, being able to create a volume using an external Ceph backend remains the priority.

@gfidente @fultonj FYI


refactor: Fix outstanding Style & Linter Issues

Description
This fixes the following pylint issues.
-  FAIL - HIGH severity: faulty_help_example_parameters_rule
    Help-Entry: `partnercenter marketplace offer submission publish` -
	There is a violation:
	"az partnercenter marketplace offer submission publish --offer-id MyOfferId  --submission-id<PHONE_NUMBER>9065" is not a valid command.
	the following arguments are required: --target.

Pylint
************* Module azext_partnercenter.clients.plan_listing_client
partnercenter/azext_partnercenter/clients/plan_listing_client.py:48:0: C0303: Trailing whitespace (trailing-whitespace)
partnercenter/azext_partnercenter/clients/plan_listing_client.py:65:0: C0303: Trailing whitespace (trailing-whitespace)
************* Module azext_partnercenter.clients.offer_submission_client
partnercenter/azext_partnercenter/clients/offer_submission_client.py:20:55: W0212: Access to a protected member _resource of a client class (protected-access)
partnercenter/azext_partnercenter/clients/offer_submission_client.py:25:56: W0212: Access to a protected member _resource of a client class (protected-access)
partnercenter/azext_partnercenter/clients/offer_submission_client.py:30:67: W0212: Access to a protected member _resource of a client class (protected-access)
partnercenter/azext_partnercenter/clients/offer_submission_client.py:33:4: R0201: Method could be a function (no-self-use)
************* Module azext_partnercenter.clients._product_ingestion_api_client
partnercenter/azext_partnercenter/clients/_product_ingestion_api_client.py:151:30: C0303: Trailing whitespace (trailing-whitespace)
partnercenter/azext_partnercenter/clients/_product_ingestion_api_client.py:152:0: W0311: Bad indentation. Found 11 spaces, expected 12 (bad-indentation)
partnercenter/azext_partnercenter/clients/_product_ingestion_api_client.py:13:0: W0611: Unused ResourceTarget imported from azext_partnercenter.vendored_sdks.production_ingestion.models (unused-import)
partnercenter/azext_partnercenter/clients/_product_ingestion_api_client.py:13:0: W0611: Unused TargetType imported from azext_partnercenter.vendored_sdks.production_ingestion.models (unused-import)
************* Module azext_partnercenter.operations.marketplace_offer_submission.custom
partnercenter/azext_partnercenter/operations/marketplace_offer_submission/custom.py:17:0: C0304: Final newline missing (missing-final-newline)
partnercenter/azext_partnercenter/operations/marketplace_offer_submission/custom.py:6:0: W0611: Unused TargetType imported from azext_partnercenter.models (unused-import)

-------------------------------------------------------------------
Your code has been rated at 9.92/10 (previous run: 10.00/10, -0.08)

Pylint: FAILED

If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check.

Created issue #187 based on discussion in this PR.

approved.


⚠ ClamAV has degraded performance

In b2886f6, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 99 ms

Resolved: ClamAV performance has improved in 03539ff.


Major Changes to Awesome-DOT README file

Here are the changes:

Create a License.
Create a contribution.md file.
Add graphics to the README file for better visualization.
Add a supporter section to the README file.
Add a thank you section to the README file.
Add social handles to the top section of the README file.
Fix the formatting of the README file.

Thank you so much Sir. It looks really good.


Multiple calendars with single scroll

Is it possible to have multiple (3) instances of big calendar on the same page and when I scroll the content in the first one all other calendars will scroll as well?

@qweluke
Hi, it's able to have multiple instances of scheduler on the same page. But it's not able to let them scroll together now.


Document how to override plugin settings/capabilities locally

https://github.com/meltano/hub/issues/580 is the relevant Hub issue to add some text on the specific plugin pages.
This capability was added in https://github.com/meltano/meltano/pull/6033/files
Likely on this page we should talk about how capabilities can be defined and overriden. https://docs.meltano.com/guide/configuration
A changelog entry for this feature should be added as it was never documented due to the 2.0 rush.
This can be coupled a bit with https://github.com/meltano/meltano/issues/6107 as well.

@aaronsteers this is the sibling issue for https://github.com/meltano/hub/issues/580 which has already been prioritized. I've added to Iteration 5.

@tayloramurphy I think now that https://github.com/meltano/meltano/pull/6404 is ready for review, I have some some capacity to document this feature.


Move plutarch-api to V3

Follow-on for point 3 of #652 .

Note: Currently, it appears V3 spec is not fully settled, so V3 implementation is waiting for release of cardano-node that supports V3 and/or finalized ledger spec.


amarok: 2.9.71 -> 3.0.0

Description of changes
Amarok 3.0.0 was released in April. Time to bump!
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Thank you for this. Couple of things:

rec -> finalAttrs
mkDerivation -> stdenv.mkDerivation

Thank you for this. Couple of things:
1. `rec` -> finalAttrs

2. `mkDerivation` -> `stdenv.mkDerivation`

Done.

Result of nixpkgs-review pr 312550 run on x86_64-linux 1

2 packages failed to build:

amarok (amarok-kf5)
amarok.doc (amarok-kf5.doc)

Seems something broke :D

Seems something broke :D

True that! No idea what, but wrapQtAppsHook got involved even if it wasn't needed before.

Result of nixpkgs-review pr 312550 run on x86_64-linux 1

2 packages built:

amarok
amarok.doc


ImportMany collection property has no setter, and it is always empty in the runtime.

I remember the bug #94 was fixed.  But when I removed 'set', and imported collection becomes empty.  I noticed it in a recent d16.0stg build.

We have a test for what you describe:
https://github.com/Microsoft/vs-mef/blob/4bcbb4f5d7f02f91f4b1623911fc1bd727bcaa72/src/tests/Microsoft.VisualStudio.Composition.Tests/RejectionTests.cs#L101-L106
What is different about your case that leads it to fail?

interesting, I hit this problem on a head of a MEF scope (UnconfiguredProjectImpl), so it is coming from ExportFactory.CreateExport().  I wonder whether that makes any difference.

Would you be willing to try adding a test for it to see if you can repro it?


Added test for FindRepoRoot

This PR adds a simple positive test for finding the repo root for the current repo. This could potentially be expanded to different test environments.

Thanks for the comments @MrAlias and sorry it took a while to fix. I think it should be ready to review again and merge!


[Question]: regarding build speed, considered HappyPack ?

You might already have stumbled upon this HappyPack which supposedly speeds up webpack by allocating the ressources differently.
If you weren't aware could this be considered and if you already reviewed it, why didn't it make it to the boilerplate?
Thanks in advance!

I think no. Very small loader support in happypack  https://github.com/amireh/happypack/wiki/Loader-Compatibility-List

But it fully supported babel-loader, I think that's enough, cuz the js compiler will take long time

@bytewiz thanks for the suggestion. Happy to consider if it offers meaningful benefits.
A PR implementing it on the demo app would be the best evidence here.
Closing for now, will happily reopen discussion on receipt.


Fix constructor

Description
As highlighted by @tinovyatkin here, the ability to pass multiple elements to the Choices constructor and get multiple instances back was buggy at best. This PR removes that functionality so the Choices constructor will only ever return one instance and that instance will only be associated with one element. To achieve the same behaviour, you would need to do the following:
const elements = Array.from(document.querySelectorAll('.your-class'));

const instances = elements.map((element) => {
  return new Choices(element);
});

or even simpler:
const elements = Array.from(
  document.querySelectorAll(".your-class"),
  element => new Choices(element)
);

I've also updated the constructor to throw an error if no valid element is passed or no valid element is found in the DOM. Previously this would have failed silently.
How Has This Been Tested?
Constructor tests have been added with this change.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.

@jshjohnson Array.from accepts second parameter, so, code may be easier:
const elements = Array.from(
  document.querySelectorAll(".your-class"),
  element => new Choices(element)
);

@jshjohnson consider also #691 for 8x 🙏

Also need to update typings by removing brackets hack.
And probably document behaviour if Choices is constructed with selector that may return several elements (we use document.querySelector to pick the first one)

See here: https://github.com/jshjohnson/Choices/pull/693/commits/4435efc5afa799ea033299c7c0bb9fd28f3aef40 - let me know if this is wrong


DOC/Sphinx: cluster.hierarchy has weird reference labels on the web page

Here's a snippet from the "References" section of https://docs.scipy.org/doc/scipy/reference/cluster.hierarchy.html#module-scipy.cluster.hierarchy (copied here and slightly edited to reproduce the look on the web page):

References
[R3cc8e479a911-1]  “Statistics toolbox.” API Reference Documentation. The MathWorks. http://www.mathworks.com/access/helpdesk/help/toolbox/stats/. Accessed October 1, 2007.

There are 10 more references, and they all have a label of the form R3cc8e479a911-#.  Those labels shouldn't look like that.  Maybe the problem is that in the file https://github.com/scipy/scipy/blob/master/scipy/cluster/hierarchy.py, nothing actually refers to those references.  I haven't tried to debug this.  I only noticed this because while building the docs locally, these warning (among many others) are displayed:
/Users/warren/repos/git/forks/scipy/doc/source/cluster.hierarchy.rst:88: WARNING: Citation [R3cc8e479a911-1] is not referenced.
/Users/warren/repos/git/forks/scipy/doc/source/cluster.hierarchy.rst:92: WARNING: Citation [R3cc8e479a911-2] is not referenced.
/Users/warren/repos/git/forks/scipy/doc/source/cluster.hierarchy.rst:97: WARNING: Citation [R3cc8e479a911-3] is not referenced.
/Users/warren/repos/git/forks/scipy/doc/source/cluster.hierarchy.rst:100: WARNING: Citation [R3cc8e479a911-4] is not referenced.
/Users/warren/repos/git/forks/scipy/doc/source/cluster.hierarchy.rst:104: WARNING: Citation [R3cc8e479a911-5] is not referenced.
/Users/warren/repos/git/forks/scipy/doc/source/cluster.hierarchy.rst:107: WARNING: Citation [R3cc8e479a911-6] is not referenced.
/Users/warren/repos/git/forks/scipy/doc/source/cluster.hierarchy.rst:110: WARNING: Citation [R3cc8e479a911-7] is not referenced.
/Users/warren/repos/git/forks/scipy/doc/source/cluster.hierarchy.rst:113: WARNING: Citation [R3cc8e479a911-8] is not referenced.
/Users/warren/repos/git/forks/scipy/doc/source/cluster.hierarchy.rst:117: WARNING: Citation [R3cc8e479a911-9] is not referenced.
/Users/warren/repos/git/forks/scipy/doc/source/cluster.hierarchy.rst:121: WARNING: Citation [R3cc8e479a911-10] is not referenced.
/Users/warren/repos/git/forks/scipy/doc/source/cluster.hierarchy.rst:124: WARNING: Citation [R3cc8e479a911-11] is not referenced.

Looks like this was fixed by https://github.com/scipy/scipy/commit/efeca748f66b7ccbbb49770b9d011848a5337e17#diff-5edb559e8c470f7499b5b321e01425b7 (in which the uncited references were removed), so closing.


modify h_pq,h_pqrs

Summary
Details and comments

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Will the .flas get released?

What is your question?
The title

ik, but i need them. i posess the power of adobe animate so i need them now. for anything really

lol

ok, or i could wait for the answer of lunarcli- i mean thanks :)

Zero’s FLAs (sprites): here


Inconsistent behavior with varying 'now' timestamps in config for FakeTimers.install({ now: , shouldAdvanceTime: true })

FakeTimers version : 6.0.1
Environment   : Node 12.18.3, macOS Catalina 10.15.7
Other libraries you are using: jest 26.4.2, bottleneck 2.18.1, nock 13.0.4

Background
I have some ETL (extract, transform, load) code that uses the bottleneck library to throttle some API calls. I am testing this code using nocks (will intercept the API calls and provide some mock data) and jest. For one of my end-to-end tests, I have a transform step that uses the current date to calculate days since an epoch timestamp. I am wanting to mock this "current date" to the epoch timestamp<PHONE_NUMBER>000 (Sep 30, 2020) and also allow the bottleneck library to work correctly with its timers. In the end, I should have an object with a keyDaysSinceCreated based on the mocked "current date".
What did you expect to happen?
My tests should complete with the thottling/timers in bottleneck going off when the 'now' timestamp is<PHONE_NUMBER>000.
What actually happens
The test does NOT complete when I set the 'now' timestamp to<PHONE_NUMBER>000 or anything near to that - but strangely does complete with other timestamps.
I have the following in my jest test code:
describe(test, () => {
  beforeAll(() => {
    clock = FakeTimers.install({ now: timestamp, shouldAdvanceTime: true });
  });
...
});

When replacing timestamp above with<PHONE_NUMBER>00 or<PHONE_NUMBER>0000 (notice the number of zeroes at the end), the tests complete successfully, and in my final object I have a key DaysSinceCreated with the values -16666 and 166838 respectively. However, when I replace timestamp with<PHONE_NUMBER>000, the tests never complete, which seems to be due to the timers in Bottleneck not launching for some reason. This seems like weird behavior that the timers and tests are functioning as expected for some timestamps, but not others. Any help and/or guidance would be appreciated!
Note: I'm kind of limited as to what code I can post on here, but please let me know what other information could be helpful and I'll provide as much as I can. Thanks!

It's going to be very hard to debug this without a reproduction.

I'm working on creating a small dummy project to reproduce this. I'll add the link to it once I have it made.

Okay here's a link (https://github.com/daniel-mina97/FakeTimers) to a sample project where I can reproduce the problem. All you have to do after installing the dependencies is run yarn test to see the failing test. In the actual test file I have some different timestamps that you can swap in.

After messing around with it some more, I think the core problem is in the bottleneck library. If instead of using fake-timers I just use jest to mock Date.now to return the timestamp, the tests also get hung up. For some reason moving the bottleneck instance inside of the function (as described in the README at https://github.com/daniel-mina97/FakeTimers) fixes both problems... I'll go ahead and close this as I don't think the issue is on y'all's side of things