how to use pybass3 to implement a callback function

Thank you very much for providing such a concise and easy-to-use library, which allowed me to easily implement a simple music player. However, I have a question now. I want to implement a callback function during music playback to update the interface playback progress.
I found that there seems to be a method called channel_set_sync on un4seen website to achieve the callback function. However, I could not find this method in the library you provided.
Could you please tell me how to use pybass3 to implement a callback function during playback?
Thank you!

I didn't hook into the sync logic in favor of just polling the stream's position and status.   That said I can look into implementing that but from prior experience, ctypes callbacks might be a little flaky.
What sync types are you interested in?

Just making a note - doing a quick test, it might be better to wrap a sync callback with a middleman callback as I broke the C Unseen library when I made a small logical error.

I'm sorry it took me a few days to see your reply to me.
Currently I'm just implementing my player based on the Song class, and on that basis I think I need the following sync types:
'mediaplay_mediachanged_callback',
'mediaplay_playing_callback',
'mediaplay_paused_callback',
'mediaplay_stopped_callback',
'mediaplay_forward_callback',
'mediaplay_backward_callback',
'mediaplay_timechanged_callback',
'mediaplay_positionchanged_callback',

Maybe I'm not necessarily thinking right. But thank you very much for considering implementing it.
Thank you!

I will see what I can do, most of those are pretty straightforward.

@SHI1992
Just prototyping in my head.
Would something like ChannelCallbacks.onPlay(channel_handle, your_callback) and respective onPause and onStop work?
From prior experience, you might want to skip over the forward and backward callbacks and see if time or position changed works better.  I made a prototype music player in PyQT5 that had problems with infinite recursion when I watched too many state variables.


Optional direct linkage to Intel MKL with fine-grained multithreading control

A large number of PySCF users also use Intel MKL, since x64 is probably still the most common architecture in academic clusters. This PR allows PySCF to make use of MKL-specific BLAS extensions and other convenient functions when MKL is used.
As a result, MKL's fine-grained threading control API is exposed. This allows MKL to be set to sequential mode whenever MKL/blas/lapack functions are invoked within an OpenMP parallel region, while MKL is multithreaded outside of such regions.
A side benefit is that, if an MKL-variant PySCF conda package is built, PySCF will be able to retain control over the number of threads used for BLAS. Effectively, conda-installed PySCF with libblas=mkl links to the Intel MKL Single Dynamic Library, which is multithreaded by default. (Performance is still quite good in this case and one can always use the OMP_NESTED and MKL_THREADING_LAYER environment variables to prevent oversubscription, if it ever occurs.)

The majority of changed lines are of one of two types:

malloc, calloc, free, and realloc are replaced with macros pyscf_malloc, pyscf_calloc, pyscf_free, and pyscf_realloc. When MKL is used, these functions are redefined as mkl_malloc, etc., and allocate chunks aligned to 64 bytes.
In functions that call BLAS in a parallel region, the following structure is used to prevent oversubscription:

#pragma omp parallel
{
#ifdef PYSCF_USE_MKL
    int save = mkl_set_num_threads_local(1);
#endif

    ...

#ifdef PYSCF_USE_MKL
    mkl_set_num_threads_local(save);
#endif
}


[BUG] Original repo for X2 model description has been removed.

Description
Hi, I am trying to run X2 simulation as document. It seems that the original repo for model description has been removed.
Expected Behavior
The clone should be successful
Actual Behavior
Cloning into 'x2_description'...
remote: Repository not found.
fatal: repository 'https://github.com/emekBaris/x2_description.git/' not found

Possible Fix
No sure.
Steps to Reproduce
$ git clone https://github.com/emekBaris/x2_description.git
$ git clone https://github.com/emekBaris/cob_gazebo_plugins.git

Context
We are constructing an M2 simulation and will be referencing the codes in X2.

Access is now given to "zebin-huang". Also, the address of the repo in the ReadMe is updated with this pull request.

Hello,
The new address of the repo in the ReadMe file is not working, may I request you to give me access as well?
@emekBaris


Expose include path and native defines via DEP_ env variables

This allows downstream projects to access the include path for cimgui.h and imgui/imgui.h for compiling native imgui dependencies.
The third_party directory path will be available to build.rs scripts via the  DEP_IMGUI_THIRD_PARTY environment variable. The defines are available via DEP_IMGUI_DEFINE_xxx.

@aloucks ping me when this is merged :)

Thanks! :smile:
I don't have a good understanding of the practical effects and possible concerns of this change, but I'll just merge it anyway

@Gekkio thanks for addressing this! I'll be using this in https://github.com/4bb4/implot-rs/blob/master/implot-sys/build.rs to figure out where the C++ imgui headers are in implot-rs, and I assume @aloucks created the PR here for doing the same in a project of his. I haven't been able to get things to work yet because my knowledge of the sys crate mechanisms is still limited though.

@4bb4 I started building a wrapper for ImGuizmo. The wrapper is still rather clunky and unfinished, but the sys crate should be a good-enough example for how to use the DEP_ env vars.  Implot was on my list too, but it sounds like you've already taken the lead with that one!
https://github.com/aloucks/imguizmo-rs/blob/master/imguizmo-sys/build.rs

@aloucks Thanks for the hint, I appreciate the guidance. The link 404s for me though, is the repo private?

@aloucks

Implot was on my list too, but it sounds like you've already taken the lead with that one!

I'd be open to collaborating. We can talk about this more over at https://github.com/4bb4/implot-rs to avoid spamming @Gekkio with notifications.


Landscape Mode

Unable to reduce the size of the calendar view  in both month and calendar view while in landscape mode in phone,
but perfect in portrait,please help

What have you tried so far? The view fills the width by default so you may want to specify the width in landscape mode.

Thanks for the quick reply, And yup its fixed by manually specifying the width in the landscape qualifier.


Alloaction webpage: Switch "location" column in biosphere inputs table to "categories"

Biosphere flows don't have a location, but they do have a field called "categories", which is useful

Fixed in PR #135.


Add Net#HTTP-- errors safely (only if in version of ruby stdlib)

Continuation of #4154. Some errors in the ruby Net module that we might not want to retry on were added in later Ruby versions of the stdlib. This PR allows us to preserve backwards compatibility while adding new  errors.

If you can add a test for this, that'd be great. If not, I will when I get back home.

Hrm okay, not sure exactly where to add the test for this. Looking through the code, this is a level above all the Bundler::Retry stuff and the fetcher specs currently don't test this. Additionally, since it's just inline code for the Fetcher class, it's difficult to test that section. One way I could potentially see doing it is  putting the logic for safely finding/loading into memory an Exception class into a helper (shared_helper maybe?) and then unit testing that.
The helper method would look maybe something like this:
def safely_retrieve_constant(constant_name, namespace)
  return nil unless namespace.constants.include? constant_name
  namespace.const_get(constant_name)
end

The AUTH_ERRORS code would look like:
    AUTH_ERRORS = [AuthenticationRequiredError, BadAuthenticationError]
    NET_ERRORS_TO_ADD_SAFELY = [:HTTPBadGateway, :HTTPBadRequest, :HTTPFailedDependency,
                                :HTTPForbidden, :HTTPInsufficientStorage, :HTTPMethodNotAllowed,
                                :HTTPMovedPermanently, :HTTPNoContent, :HTTPNotFound,
                                :HTTPNotImplemented, :HTTPPreconditionFailed, :HTTPRequestEntityTooLarge,
                                :HTTPRequestURITooLong, :HTTPUnauthorized, :HTTPUnprocessableEntity,
                                :HTTPUnsupportedMediaType, :HTTPVersionNotSupported]
    NET_ERRORS_TO_ADD_SAFELY.each do |net_error|

AUTH_ERRORS << Net.const_get(net_error) if Net.constants.include? net_error
    end

Sorry, accidentally closed.
Thoughts?

Something like this seems reasonable to me, although I would probably do something like AUTH_ERRORS.push(*NET_ERRORS.map{|e| SharedHelpers.get_error(e) }.compact)

@RochesterinNYC oooh yeah I wasn't even thinking of something unit-testable like that! That's perfect :)

Updated the PR with the extracted SharedHelpers#const_get_safely and a unit test for it.
Additionally, I noticed that most or all of the methods in the SharedHelpers module don't seem to have unit tests for them and rely on their usage in other modules/methods and the tests for those other modules/methods for test coverage. Would it be worth making a separate PR to add unit tests for those SharedHelpers methods?

@RochesterinNYC unit tests 😍

@homu r+

:pushpin: Commit cb0a522 has been approved by segiddins

:hourglass: Testing commit cb0a522 with merge 7caef4f...

Unit tests would be amazing! We want to transition to primarily having unit tests over time, because right now we have only integration tests and it is kinda awful.

:broken_heart: Test failed - status

Hm, failure on Ruby 1.8.7 was due to Module#constants returning an array of strings rather than symbols (behavior in all later versions of ruby). Refactored SharedHelpers#const_get_safely to check for string or symbol form of the constant.

@homu r+

:pushpin: Commit a5da09c has been approved by segiddins

:hourglass: Testing commit a5da09c with merge c3684b0...

:sunny: Test successful - status


Fix linter lack of package.json

Fixes https://github.com/OpenZeppelin/cairo-contracts/issues/447.

Is the npm install npm line necessary?

No, it's not needed. Good call

removed


Add SQL input

Closes #3347. Didn't add details about other plugins to use in different scenarios because it's a little out-of-scope for the descriptions in this doc.

@sjwang90 can you verify the tags and the version added? thanks!


Question: API for setting Title

Hi there! Sorry for opening an issue, but I had a question regarding an API.
Right now it seems that when a nerdtree is created, it uses the pwd as the "title"

In this case it's /Users/mhartington/myApp/ for my app.
Is it possible/is there an API that would allow me to customize this? Mostly looking the trim the path and add a glyph icon.
Similar to what is possible in neotree for emacs.

Hey there @mhartington. What you're trying to do is not particularly difficult. My idea would be to define a custom option that would point to a funcref for rendering the root (the default value being a routine for rendering it as it is).
I'm totally unmotivated to do this myself, but I'd be happy to help review your code if you submit a PR.
Also, I'm not a maintainer, so you'll have to confirm with @PhilRunninger or @scrooloose that this change is okay with them.

Closing due to inactivity.


Connection closed by peer

hi:
The pure python adb library is very useful for me. But I met a strange issue:
I have a PC (named PCA), the PC connects 2 Android devices and the PC uses windows 7.
I installed the pure python adb library on the PC and use it to execute some adb shell command on addroid devices. It works fine.
I have another PC (named PCB), it uses centos 7 and also have installed the pure python adb library. For some reason, I wish to access the andirod devices of PCA from PCB.  I know the adb only listen on <IP_ADDRESS> 5037 of PCA, and I could not connect to PCA with pure-python-adb;
So I installed a softeware on PCA that will do port forward, for example: the PCA's ip address is <IP_ADDRESS>, so I set in the port forword software, use it to forward any ip packet to <IP_ADDRESS>:5036 to <IP_ADDRESS>:5037,  this time, I can use pure-python-adb to connect to <IP_ADDRESS>:5036. It also works.
My issue is: sometimes the pure-python-adb will broken for connection reset by peer. I means sometimes means: sometimes it is ok, but sometimes it fails; even I execute the same shell command.
the error log is something like this:
01-02-2019:09:15:43,231 DEBUG    [connection.py:24] Connect to adb server - <IP_ADDRESS>:5036
2019-02-01 09:15:43 [DEBUG] Connect to adb server - <IP_ADDRESS>:5036
01-02-2019:09:15:43,232 DEBUG    [connection.py:75] 000Chost:devices
2019-02-01 09:15:43 [DEBUG] 000Chost:devices
01-02-2019:09:15:43,234 DEBUG    [connection.py:47] Connection closed...
2019-02-01 09:15:43 [DEBUG] Connection closed...
2019-02-01 09:15:43 [ INFO] shell: ifconfig
01-02-2019:09:15:43,235 DEBUG    [connection.py:24] Connect to adb server - <IP_ADDRESS>:5036
2019-02-01 09:15:43 [DEBUG] Connect to adb server - <IP_ADDRESS>:5036
01-02-2019:09:15:43,235 DEBUG    [connection.py:24] Connect to adb server - <IP_ADDRESS>:5036
2019-02-01 09:15:43 [DEBUG] Connect to adb server - <IP_ADDRESS>:5036
01-02-2019:09:15:43,236 DEBUG    [connection.py:75] 001Fhost:transport:5LM0216922003133
2019-02-01 09:15:43 [DEBUG] 001Fhost:transport:5LM0216922003133
Exception in thread Thread-1:
Traceback (most recent call last):
File "/usr/lib64/python2.7/threading.py", line 811, in __bootstrap_inner
self.run()
File "/usr/lib64/python2.7/threading.py", line 764, in run
self.__target(*self.__args, **self.__kwargs)
File "adb_proxy.py", line 140, in run
self.deal_message(message, address)
File "adb_proxy.py", line 128, in deal_message
response = self.tc.dealwith_direct_operation(data)
File "adb_proxy.py", line 83, in dealwith_direct_operation
return self._run_shell_command(device, command)
File "adb_proxy.py", line 67, in _run_shell_command
device.shell('{}'.format(command)))
File "/usr/lib/python2.7/site-packages/adb/command/transport/init.py", line 20, in shell
conn = self.create_connection(timeout=timeout)
File "/usr/lib/python2.7/site-packages/adb/device.py", line 45, in create_connection
self.transport(conn)
File "/usr/lib/python2.7/site-packages/adb/command/transport/init.py", line 15, in transport
connection.send(cmd)
File "/usr/lib/python2.7/site-packages/adb/connection.py", line 77, in send
return self._check_status()
File "/usr/lib/python2.7/site-packages/adb/connection.py", line 80, in _check_status
recv = self._recv(4).decode('utf-8')
File "/usr/lib/python2.7/site-packages/adb/connection.py", line 56, in _recv
return self.socket.recv(length)
error: [Errno 104] Connection reset by peer
Thanks in advance.

I think this issue maybe caused by a bug.
In device.py line 42:
conn.connect()
But in fact, in self.client.create_connection(timeout=timeout), the connection has ben connected;
so it will connect twice!
I comment this line and it works well.

Hi @jufei
sorry for late reply
Thanks ! you are right.
I will fix this.


i want to set a window with a small innersize and no decoration

[patch.crates-io]
eframe = { features = [
"default",
"__screenshot", # __screenshot is so we can dump a screenshot using EFRAME_SCREENSHOT_TO
"persistence"
] }
For image support:
egui_extras = { features = ["default", "image"] }
env_logger = { version = "0.10", default-features = false, features = [
"auto-color",
"humantime",
] }
Describe the bug
when i run the app,the window is created in a correct size but after about 0.5s the size change automatically,it seems like the width of the minimum size of the decoration bar.
the window finnally become:

To Reproduce
just run the example of helloworld on windows 11, try to set the decoration with false and the innersize with [50.0,50.0]
 let options = eframe::NativeOptions {         viewport: egui::ViewportBuilder::default().with_inner_size([50.0, 50.0]).with_decorations(false).with_min_inner_size([50.0,50.0]),         persist_window: false,         ..Default::default()     };
Expected behavior

i want to create a window with no decoration and it's innersize should be [50.0,50.0].
Desktop (please complete the following information):

OS:  windows 11

Additional context

If you use ViewportCommand::Transparent and ViewportCommand::InnerSize, it will work as desired.
            if ui.button("transparent").clicked() {
                ui.ctx()
                    .send_viewport_cmd(egui::ViewportCommand::Transparent(false));
            }

            if ui.button("mini innersize").clicked() {
                ui.ctx()
                    .send_viewport_cmd(egui::ViewportCommand::InnerSize(egui::Vec2::new(50.0, 50.0)));
            }

If you use ViewportCommand::Transparent and ViewportCommand::InnerSize, it will work as desired.
            if ui.button("transparent").clicked() {
                ui.ctx()
                    .send_viewport_cmd(egui::ViewportCommand::Transparent(false));
            }

            if ui.button("mini innersize").clicked() {
                ui.ctx()
                    .send_viewport_cmd(egui::ViewportCommand::InnerSize(egui::Vec2::new(50.0, 50.0)));
            }

thanks, i have tried above method and it worked. by the way, Is this specially designed or is it a bug？

I don't know, because I haven't checked.
This can be solved by using 'ViewportCommand`.


Update Linux support to 0.0.13

Code heavily based on @Francesco149's original PR, with line numbers updated.
Signed-off-by: Nick Sarnie<EMAIL_ADDRESS>His original instructions are below, with slight modification:
Make sure you have at least node v5

cd
mkdir discord
cd discord

# Install discord in /opt/
wget https://discordapp.com/api/download/canary?platform=linux&format=tar.gz
tar -xzvf discord-canary-0.0.3.tar.gz
sudo cp -r DiscordCanary /opt/
sudo ln -s /opt/DiscordCanary/DiscordCanary /usr/bin/discord

# Install BetterDiscord
git clone https://github.com/sarnex/BetterDiscordApp.git
mv BetterDiscordApp BetterDiscord
cp BetterDiscord/Installers/Node/* .
cp BetterDiscord/splice .
npm install asar wrench
sudo ./install.sh

cd

# Move dir if exists
oldTime=$(date +"%H-%M-%S.%d-%m-%y")
mv discord "discord.${oldTime}.old"

# And.. Create new!
mkdir discord
cd discord

# Install discord in /opt/
wget "https://discordapp.com/api/download/canary?platform=linux&format=tar.gz" -O discord-canary-0.0.3.tar.gz
tar -xzvf discord-canary-0.0.3.tar.gz
sudo cp -r DiscordCanary /opt/
sudo ln -s /opt/DiscordCanary/DiscordCanary /usr/bin/discord

# Install BetterDiscord
git clone https://github.com/sarnex/BetterDiscordApp.git
mv BetterDiscordApp BetterDiscord
cp BetterDiscord/NodeInstaller/* .
cp BetterDiscord/splice .
npm install asar wrench
sudo ./install.sh

ah thanks for updating my pull request, was too busy to work on it

Works fine for me!
I needed to change the _discordPath in the NodeInstaller/index.js file since the AUR package for Discord-Canary uses /opt/discord-canary/.
But it looks like this path is not consistent between distributions. But for Arch, someone might just add a patch during installation if they make a AUR package, if needed :+1:

Still works with no change on version 0.4

Not works on newest 0.0.6 version :(

@DaFri-Nochiterov should be fixed now

@sarnex, yes, this works. Thanks.

Again. Not works on 0.0.7 version.
Now with Exception:
Uncaught Exception:
SyntaxError: Unexpected token ;
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:387:25)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Object.<anonymous> (/opt/DiscordCanary/resources/electron.asar/browser/init.js:184:8)
    at Module._compile (module.js:413:34)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)

@DaFri-Nochiterov fixed again, hopefully they leave index.js alone. If not, if it happens again, I'll look for a better solution than hardcoding line numbers, as is done in the official installer.

@sarnex You should definitely look for a better solution, because I'm pretty sure the index.js will change a lot in the near future.

I've rewritten the linux installer to not use hardcoded line numbers. It should not break now unless they remove the two lines I'm searching for, which I don't expect.

And it works fine on just-released 0.0.8! 👍

Emoticons no longer works in this version

No idea why, installer doesn't seem to have been modified. Someone else should investigate.

Huh? It works for me. Running from commit 6be4da2197ea57025f653a07903fa01764110c70

Emotes work now, it was a BetterDIscord bug unrelated to these changes.

I have tried installing this multiple times, but I keep getting this error after running sudo ./install.sh
simonizor@T00L-Xubuntu:~/Downloads/discord$ sudo ./install.sh  /home/simonizor/Downloads/discord/index.js:128  fs.exists(process.env.HOME + _prefsPath + emotes_twitch_global, (exists) => {                                                                            ^ SyntaxError: Unexpected token >     at Module._compile (module.js:439:25)     at Object.Module._extensions..js (module.js:474:10)     at Module.load (module.js:356:32)     at Function.Module._load (module.js:312:12)     at Function.Module.runMain (module.js:497:10)     at startup (node.js:119:16)     at node.js:902:3 simonizor@T00L-Xubuntu:~/Downloads/discord$
Any help would be appreciated.

I'm getting the same error as simoniz0r.

@simoniz0r @chowder908
I've rebased the pull request based on the lastest BetterDiscord, and I tried the install from scratch and it worked. I've also updated the original instructions to fit the current directory structure.
Let me know if there's still an issue.

sudo: ./install.sh: command not found
Now telling me this.

Is there anyway to just manually install it like copying the files to the places they have to be?

@sarnex  sudo: ./install.sh: command not found
Now telling me this.
Is there anyway to just manually install it like copying the files to the places they have to be?

@chowder908 you have to chmod +x install.sh

@sarnex
sudo chmod +x ./install.sh
chmod: cannot access ‘./install.sh’: No such file or directory

@chowder908 did you follow the instructions above?
git clone https://github.com/sarnex/BetterDiscordApp.git
mv BetterDiscordApp BetterDiscord
cp BetterDiscord/Installers/Node/* .
cp BetterDiscord/splice .
npm install asar wrench
sudo ./install.sh

@sarnex line by line

simonizor@T00L-Xubuntu:~/Downloads/discord$ sudo ./install.sh

/home/simonizor/Downloads/discord/index.js:126
 fs.exists(process.env.HOME + _prefsPath + emotes_twitch_global, (exists) => {
                                                                           ^
SyntaxError: Unexpected token >
    at Module._compile (module.js:439:25)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)
    at node.js:902:3

I'm getting pretty much the same error after deleting everything and cloning your PR after these changes.

Yeah @simoniz0r i redid it and same error.

@simoniz0r Can you send me the output of node -v? I think it's some weird library or node version issue.

simonizor@T00L-Xubuntu:~/Downloads/discord$ node -v
v0.10.25

@sarnex I have v0.10.29

That version is from around 2014. See if you can update it. I'm on 5.10.1

@sarnex Thank you, that worked!
@chowder908 In case you need help updating node, this is how I did it:
sudo npm cache clean -f
sudo npm install -g n
sudo n stable

sudo ln -sf /usr/local/n/versions/node/<VERSION>/bin/node /usr/bin/node

@sarnex @simoniz0r i'm getting sudo: npm: command not found

@simoniz0r cool, glad it worked. I'll add it to the original post

I installed this on my copy of DiscordCanary, which runs on Ubuntu 16.04 x64, and the load process hangs on FrankerFaceZ emote data.

@carlmiller307 Your problem looks unrelated to this pull request. Here we're talking about the installation script. If it says that FrankerFaceZ loads, that mean it's installed (but has a bug).
You should try to open a new issue for that.

I'm getting this error in the Discord app 0.0.8

(program):1 Uncaught TypeError: Cannot read property 'appendChild' of undefinedelectron.ipcRenderer.on @ /opt/discord-canary/resources/electron.asar/renderer/init.js:44
(program):1 Uncaught TypeError: Cannot set property 'innerHTML' of nullelectron.ipcRenderer.on @ /opt/discord-canary/resources/electron.asar/renderer/init.js:44
(program):1 Uncaught TypeError: Cannot set property 'value' of nullelectron.ipcRenderer.on @ /opt/discord-canary/resources/electron.asar/renderer/init.js:44
(program):1 Uncaught TypeError: Cannot set property 'max' of nullelectron.ipcRenderer.on @ /opt/discord-canary/resources/electron.asar/renderer/init.js:44

Node v6.4.0
Arch Linux
I applied this pull request on top of master (48d4a58102dcdbc1ce888b322df2f7aa834eb695)

@GhettoGirl Hmm... Works fine for me, I'm using the discord-canary AUR package.
yaourt -S discord-canary
# I've started Discord at least once and then quit before installing BetterDiscord
mkdir BDA && cd BDA
git clone https://github.com/Jiiks/BetterDiscordApp.git && cd BetterDiscordApp
git remote add sarnex https://github.com/sarnex/BetterDiscordApp.git
git pull sarnex master
cd .. && mv BetterDiscordApp BetterDiscord
cp BetterDiscord/Installers/Node/* BetterDiscord/splice .
npm install asar wrench
sudo ./install.sh

@mkody I restarted Discord several times, now it works. It may be related to this upstream bug https://github.com/crmarsh/discord-linux-bugs/issues/81. But this error is new, I'm gonna report this in the upstream issue too.

do plugins and themes work with this?

@jamesguessis Of course, yes. What's the point if they don't work? :smile:

where would the respective folders be located then?

Inside ~/.config/BetterDiscord

Discord Canary 0.0.9 released and BetterDiscord is no longer compatible with it. Says _betterDiscord is undefined. Just want to let you know.
I'm staying at 0.0.8 for a while.

Sorry for the delay, I've been busy lately. I've updated the PR for 0.0.9.
It works for me, please let me know if it works.
Thanks.

It works great. Thanks for the quick update. :+1:

Can confirm it works. :+1:

Thanks for the update.  I was having some issues with the install script not creating a directory properly before and also the crash above with 0.0.9.  Both of those issues were resolved with this update.  The install went as expected, and no crash on loading 0.0.9.

You Rock!
Cancel That
I'm the greatest

Works with 0.0.10 without changes.

Works fine with 0.0.11 too.

@mkody thanks for testing

Aaaaand, works fine with 0.0.12!

Tubular
On Tue, Jan 3, 2017 at 3:48 PM, Kody<EMAIL_ADDRESS>wrote:

Aaaaand, works fine with 0.0.12!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Jiiks/BetterDiscordApp/pull/288#issuecomment-270220583,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGvNDLkCHf6ShbXr_KFfMy3ZrNBaQaZpks5rOrQygaJpZM4INLQo
.

Still works with 0.0.13

Any possibility of getting this merged into master? It seems this is pretty solid and plenty of people are reporting it still working with the latest version of Discord Linux.

I don't think Jiiks cares.
On Wed, Jan 4, 2017 at 8:59 AM, Benjamin Hoffmeyer<EMAIL_ADDRESS>
wrote:

Any possibility of getting this merged into master? It seems this is
pretty solid and plenty of people are reporting it still working with the
latest version of Discord Linux.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Jiiks/BetterDiscordApp/pull/288#issuecomment-270376386,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGvNDNsetsjP2TKs64gI996vl-RtTm7Jks5rO6W9gaJpZM4INLQo
.

I can also confirm it works with 0.0.13, though oddly enough, the BetterDiscord tab doesn’t appear in the User Settings.

Yup @ddlr, but it's broken on macOS too (at least). Discord recently pushed a background update that broke BD.

@mkody Ah, good to know that I’m not the only one.

There is a temporary workaround for this. The file just needs to be compied to the plugin path, it works automagically. Don't actually enable this plugin in the BetterDiscord settings https://gist.github.com/noodlebox/94b26b4ded85a0ded48197333aad290b

It seems like BetterDiscord updated to v0.2.82... any chance of this PR getting updated also?  BetterDiscord won't load anymore after the update.
http://i.imgur.com/HMTkzIc.png

Jup, same error :(

I've sent two PR #435 and #436 to fix the latest changes.
So here's what I need to do (as of right now) to make it run:
# Start Discord at least once and then quit before installing BetterDiscord
# Let's create a work dir
mkdir BDA
cd BDA
# Clone the upstream repo to "BetterDiscord"
git clone https://github.com/Jiiks/BetterDiscordApp.git BetterDiscord
cd BetterDiscordApp
# Now we're going to merge the PRs manually
git remote add mkody https://github.com/mkody/BetterDiscordApp.git
git remote add sarnex https://github.com/sarnex/BetterDiscordApp.git
git merge mkody/fix-bdStorage-path
git merge mkody/fix-version-config
git merge sarnex/master
# Now let's go back to our work dir and get the dependencies
cd ..
cp BetterDiscord/Installers/Node/* BetterDiscord/splice .
npm install asar wrench
# And now we can run the installer
# (you might need to use sudo)
bash install.sh

Important note regarding recent changes
Plugins needs to be updated to the new storage system. Please remove them in the ~/.config/plugins folder before launching BetterDiscord, get the latest version and add them progressively to check if they work.

Sorry about that, I just rebased. Let me know if the rebased version works.
On Mon, Jan 9, 2017 at 12:58 PM, Kody<EMAIL_ADDRESS>wrote:

I've sent two PR #435 https://github.com/Jiiks/BetterDiscordApp/pull/435
and #436 https://github.com/Jiiks/BetterDiscordApp/pull/436 to fix the
latest changes.
So here's what I need to do (as of right now) to make it run:
Start Discord at least once and then quit before installing BetterDiscord# Let's create a work dir
mkdir BDAcd BDA# Clone the upstream repo to "BetterDiscord"
git clone https://github.com/Jiiks/BetterDiscordApp.git BetterDiscordcd BetterDiscordApp# Now we're going to merge the PRs manually
git remote add mkody https://github.com/mkody/BetterDiscordApp.git
git remote add sarnex https://github.com/sarnex/BetterDiscordApp.git
git merge mkody/fix-bdStorage-path
git merge mkody/fix-version-config
git merge sarnex/master# Now let's go back to our work dir and get the dependenciescd ..
cp BetterDiscord/Installers/Node/* BetterDiscord/splice .
npm install asar wrench# And now we can run the installer# (you might need to use sudo)
bash install.sh
Important note regarding recent changes
Plugins needs to be updated to the new storage system. Please remove them
in the ~/.config/plugins folder before launching BetterDiscord, get the
latest version and add them progressively to check if they work.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Jiiks/BetterDiscordApp/pull/288#issuecomment-271356216,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGvNDDbioqlXvgV_4U19NIQI-IhNlykTks5rQnU3gaJpZM4INLQo
.

Yes, it still works but you need to have my two PRs merged anyways (especially #436).
Until this is if merged upstream, I'd still recommend everyone to use my instructions and merge manually.
When Jiiks and co. will push updates to BD, we can just do a git pull and re-run the install.sh.

@mkody Thanks for sharing—I inserted chmod u+x install.sh before the last line and it worked like a charm so far. I’ll check if a BetterDiscord plugin I use still works in a moment.

Do I still have to follow mkody's instructions to install BetterDiscord?  I've tried cloning sarnex's updated PR and reinstalling BetterDiscord, but I still get the out of date error when launching Discord.

Yup, #436 should fix it.

Any chance of all of that getting merged into this PR?  I'd rather not go through all of that every time I install BetterDiscord.

I merged #436 into my PR.
On Wed, Jan 11, 2017 at 11:33 AM, simoniz0r<EMAIL_ADDRESS>wrote:

Any chance of all of that getting merged into this PR? I'd rather not go
through all of that every time I install BetterDiscord.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Jiiks/BetterDiscordApp/pull/288#issuecomment-271918335,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGvNDI9trwIK0AozKMbTuRu-9RSjJVp-ks5rRQRggaJpZM4INLQo
.

Thank you so much!

Still works with canary 0.0.14 :+1:
I didn't tested the Linux PTB and Stable client. I prefer Canary :smile:

I guess we should change the path in js/main.js as well.
diff --git a/js/main.js b/js/main.js
index 4ee8bea..3f1a5d9 100644
--- a/js/main.js
+++ b/js/main.js
@@ -13,7 +13,7 @@
     let __fs = window.require("fs");
     let __process = window.require("process");
     let __platform = __process.platform;
-    let __dataPath = (__platform === 'win32' ? __process.env.APPDATA : __platform === 'darwin' ? __process.env.HOME + '/Library/Preferences' : '/var/local') + '/BetterDiscord/';
+    let __dataPath = (__platform === 'win32' ? __process.env.APPDATA : __platform === 'darwin' ? __process.env.HOME + '/Library/Preferences' : process.env.HOME + '/.config') + '/BetterDiscord/';

     let __data = {};

Could you also please merge #435 into this PR?  I had to create a script that deletes /home/user/.config/bdstorage.json before launching BetterDiscord otherwise it complains that /home/user/.config/BetterDiscord//bdStorage.json doesn't exist, and gives me a javascript error that locks up the whole app.

I merged it.
On Thu, Jan 26, 2017 at 7:13 AM, simoniz0r<EMAIL_ADDRESS>wrote:

Could you also please merge #435
https://github.com/Jiiks/BetterDiscordApp/pull/435 into this PR? I had
to create a script that deletes /home/user/.config/bdstorage.json before
launching BetterDiscord otherwise it complains that /home/user/.config/
BetterDiscord//bdStorage.json doesn't exist, and gives me a javascript
error that locks up the whole app.
[image: Javascript error]
https://camo.githubusercontent.com/e3d814ae6a97fc34c7d92b78e47782ba95ec6d5b/687474703a2f2f692e696d6775722e636f6d2f346a68757a32452e706e67
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Jiiks/BetterDiscordApp/pull/288#issuecomment-275374426,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGvNDM6Y-qkJd1cWNiSM7eWiyQhmX5XFks5rWI3QgaJpZM4INLQo
.

And another update. Still works with 0.0.15 :+1:

@magiruuvelvet I hope you’re not going to keep this up every day, considering the new update schedule. 😜

Canary it set to build on each new push to the master branch, just as an FYI.

I don't know if you've seen this, but Ckath made a script that can install BetterDiscord to any directory... might be of some use to you.
https://github.com/Ckath/Discord-stuff/blob/master/scripts/tape.sh

This is basically just doing what the BetterDiscord installer does in a
script, there's no way for it to be merged but maybe it's easier to use. I
recommend following the instructions here.
On Sat, Feb 4, 2017 at 8:52 AM, simoniz0r<EMAIL_ADDRESS>wrote:

I don't know if you've seen this, but Ckath made a script that can install
BetterDiscord to any directory... might be of some use to you.
https://github.com/Ckath/Discord-stuff/blob/master/scripts/tape.sh
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Jiiks/BetterDiscordApp/pull/288#issuecomment-277447245,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGvNDNRzjwu6NDR1PvfPWzIPI4vPEXNdks5rZIKDgaJpZM4INLQo
.

I would say the fact that it allows any directory to be used is enough, but ¯_(ツ)_/¯

It only has to be /opt for the install, you can move Discord after.
On Sat, Feb 4, 2017 at 1:56 PM, simoniz0r<EMAIL_ADDRESS>wrote:

I would say the fact that it allows any directory to be used is enough,
but ¯_(ツ)_/¯
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Jiiks/BetterDiscordApp/pull/288#issuecomment-277466835,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGvNDOwvjBv7-jHQKdglX6FAjwvhhK1gks5rZMnqgaJpZM4INLQo
.

Sure, but that's not ideal.  That is not the default install location for the .deb package.  Also, with PTB and Stable being released on Linux, tape.sh makes installing BetterDiscord to those Discord versions possible without having to move them to /opt/DiscordCanary/ first.

Maybe it's time to merge this o-o

Woo!
You should keep an eye on the fact that we're not using /var/local anymore, but ~/.config.
This includes (at least) in v2/lib/core.js: installPath and dataPath, and injs/main.js: for __dataPath

we did it boys, i dont mind maintaining the linux portion but please use
this PR for that
On Fri, Feb 10, 2017 at 9:07 AM, Kody<EMAIL_ADDRESS>wrote:

Woo!
You should keep an eye on the fact that we're not using /var/local
anymore, but ~/.config.
This includes (at least) in v2/lib/core.js: installPath and dataPath, and
injs/main.js: for __dataPath
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Jiiks/BetterDiscordApp/pull/288#issuecomment-278949781,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGvNDNKtBTEQDtf4QGw-sDobvoFTkmb-ks5rbG8qgaJpZM4INLQo
.


Crystal should be able to handle XSD validation

Discussion

What aspect of the language would you like to see improved?
Currently, crystal cannot handle XSD validation via the XML module even, though, the libxml2 library can.

What are the reasons?
I do not know.

Include practical examples to illustrate your points.
In this conversation, @Blacksmoke16 created one: https://gitter.im/crystal-lang/crystal?at=62aa87774e38f759e2c0fe38

Optionally add one (or more) proposals to improve the current situation.
I am sorry, I an not that code-savvy to be able to. Maybe the example @Blacksmoke16 created could be of help.

Ultimately this discussion needs to yield an answer to two question:

Is this something we want to have in the stdlib versus an external shard
What the API/implementation should look like

I suppose the best way forward for such a proposal is to start as a shard, and then if probed useful move it to stdlib. But definitively this can be a place to discuss a possible API.

Would there be any feasability of a common validation framework that could encompass features from a variety of data languages? I have just been trying to use the Json Schema shard without enormous success, although I tihkn half of this is that last time I worked with JSON schemata it was not pleasant, and seems to be a headachey system - the website examples did not work with the CLI tool I have downloaded.
Presumably, when serialising and deserealising from any language, there is a certain amount of common work - macros to generate classes, basic validation of values, some sort of parsing infrastructure. If possible, it might be nice to see some of this encapsulated in a common way, that can then be specified and tailored for different languages (JSON, YAML, XML, TOML, I don't know what else off the top of my head...).
Also an aside, but I have just come across TypeSchema trying to see if there's an alternative I could use more easily. NOt so relevant for XML, but supporting osmehting cross-language like this may be an interesting thing if someone wanted to pick it up.

I would like to see a common way of validating data within Crystal, and then, for validators specific to languages that crystal can serialise and deserialise to/from hook into that generic validation framework, in order that each language validator need then only tailor the generic features to the semantics of what that language is able to provide or requires.

By language do you mean format? Because I think there are few somewhat separate things being discussed:

Validation based on external format specific schemas. E.g. XSD, or JSONSchema. Which is what this issue is about (for XML at least).
Representing data in Crystal after deserializing it from possibly different formats various formats. Which is what JSON::Serializable and YAML::Serializable are intended for.
Validation based on business logic defined in Crystal. Which is what that shard you mentioned handles. Is also Athena Validator FWIW.

Depending on how you're envisioning this to work, a forum thread (or at least a separate issue) might be a better starting point. As this one is purely focused on:

Given an XML string, how can I validate it with an existing XSD file

This is something that we're have been planning to use a binding to libxml2 for, in our application. It would be much nicer though, if it were as a shard or ultimately, built-in, for sure.


API for downloading consensus history

We should expect peers will temporarily disconnect (e.g. for upgrades or network outages) from consensus.  In order to support rejoining, peers will need to have an API for downloading the consensus history.  Additionally this could serve as a mechanism for users to privately download their coins if the nonces and blinding keys were lost (and generated deterministically from a known secret key).
Some of the features of consensus download should be:

Epochs should be signed so one can verify that a quorum of fed members agree on the history
Epochs should include a last_non_empty_epoch or something similar so that empty epochs do not need to be downloaded
Rejoining nodes can specify the epoch from which they need to begin a download

We might also want to put epochs into a merkle tree so if ever consensus history was rewritten we could more easily verify that an epoch is in the current consensus, although I'm not sure if that scenario would ever occur.

Closing in favor of #320


Make a Contributors Guideline

AIM
Create Contributors Guideline to help new Contributors get started with this Project.
Features

Add a CONTRIBUTING.md to allow new users to get started with knowing how to contribute.
Add Screenshots wherever possible.
Add the basic information about creating Issues, Pull Requests and Branching.
Mention tutorials related to Git and Github to help them better understand.

I would like to work on this issue.

@Neel2904 You are already assigned you one issue. I cannot assign you this until you submit a PR for the previous Issue

Okay !!

I would like to work on this issue.

I have assigned this issue to @TechTarun

i would like to work on it

A PR for this Issue was made by @sameersrivastava13 and merged. Closing this Issue now


Fix link to page about no autobinding

While this book is being translated into Thai language, a contributor found that the link to https://facebook.github.io/react/docs/reusable-components.html#no-autobinding does not contain the target content: https://github.com/reactbkk/react-in-patterns-th/pull/15#issuecomment-395095808
The content has since been moved to another page, here: https://reactjs.org/docs/handling-events.html
This PR fixes it. 😄

Thanks!


Usability improvement: Make the listing the landing page, and move current landing to "About"

I think having to find and hit "Quarto Extensions" in the navbar to see the extensions is a bit indirect. Have you considered having the listing of extensions as the main landing page?

I agree. It's terrible especially on mobile / small screen.
I did not had the time yet to go back on the layout (there are few other things I don't like)


Why are max instance counts per replica different between VM and VMSS?

[Enter feedback here]
This documents describe the following.  if we are creating 20 VMs(non-vmss), we should use 1 replica of my shared image. but  if we are creating 120 vm instance (on VMSS ), we should use 1 replica. The difference are very large.
Is this document correct ?

For non-Virtual Machine Scale Set (VMSS) Deployments - For every 20 VMs that you create concurrently, we recommend you keep one replica. For example, if you are creating 120 VMs concurrently using the same image in a region, we suggest you keep at least 6 replicas of your image.

For Virtual Machine Scale Set (VMSS) deployments - For every scale set deployment with up to 600 instances, we recommend you keep at least one replica. For example, if you are creating 5 scale sets concurrently, each with 600 VM instances using the same image in a single region, we suggest you keep at least 5 replicas of your image.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0d150ace-bd6d-8111-79b5-0ce7cb76a378
Version Independent ID: 13a828ae-ae92-9ea7-5f37-5a69eeeb87b7
Content: Azure Shared Image Gallery - Azure Windows Virtual Machines
Content Source: articles/virtual-machines/windows/shared-image-galleries.md
Service: virtual-machines-windows
GitHub Login: @axayjo
Microsoft Alias: akjosh

@y10e Thanks for the Feedback. I have assigned the issue to content author for checking and updating on this as appropriate.

@axayjo Can you please check this and add your comments.

We are currently cleaning up old issues and closing out items that are greater than 90 days old. If an issue is still present, please open a new feedback item on the document so we can prioritize correctly.
#please-close


create removeElement(_) in Array extension.

This PR introduces removeElement(_ element:), which removes first instance of an element from array. 🎉

Checklist

[x] I checked the Contributing Guidelines before creating this request.
[x] New extensions are written in Swift 4.
[x] New extensions support iOS 8.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+.
[x] I have added tests for new extensions, and they passed.
[x] All extensions have a clear comments explaining their functionality, all parameters and return type in English.
[x] All extensions are declared as public.
[ ] I have added a changelog entry describing my changes.

          1 Warning

:warning:
The source files have been modified. Please consider adding a CHANGELOG entry if necessary.

          1 Message

:book:
Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

  Generated by :no_entry_sign: Danger

You'd left it for a while so thought I'd help out. Sorry if that upset you. You're always welcome to revert my change ;)

You'd left it for a while so thought I'd help out. Sorry if that upset you. You're always welcome to revert my change ;)

@guykogus
I always ask when I take over someone’s PR, that’s why I expressed my opinion.
Regarding the changes, doesn’t make sense to revert it. It looks as expected 😊
Sent with GitHawk

Thank you @jdisho @guykogus for this one 👍 We're sorry we didn't ask you before continuing work on this @jdisho


Changes to display Agent Label and Version on CLI and SwaggerUI

Adding agent label to CLI banner
Adding agent label and version to SwaggerUI

Having this information displayed on CLI and UI helps to identify agents without keeping port number based notepads.
Signed-off-by: Satish Mohan<EMAIL_ADDRESS>

Looks good, thanks!


Fix typo of length closes #681

This is related to #681

I guess the right fix would be generating docs up to date with latest version..

Yes, @rafaelss95 I agree. I still believe we can merge this now and regenerate the docs as well.

@mgechev can you tell me the steps to do this? I noticed that there's a script called buildDocs (which isn't working at the moment) that generates HTML docs, however what about all other files in docs folder?


send data to splunk

Hello,
how is possible to send data directly to splunk?

Hi @jjjan  I think the easiest way is to use the Bro Kafka plugin (as described here: https://github.com/Kitware/bat/blob/master/notebooks/Bro_to_Kafka_to_Spark.ipynb and then use the Splunk add-on for Kafka: https://splunkbase.splunk.com/app/2935/
So basically two steps:

Install Kafka plugin to Bro
Install Kafka add-on for Splunk

Let me know how it goes, I think this is a popular enough use case so that other folks will be interested as well. Perhaps I'll throw together a small notebook on how to do it.

Going to close this ticket. Splunk is pretty good about ingesting anything so probably 'out of scope' for us to send data to splunk.


[Major] Refactored byte_type

Some mega changes have been made.

Types are now based off any of the following three types Sized, Aligned or Unsized. They inherit eachother, so Sized types are also aligned and aligned types are unsized. Meaning that they will help with type strictness.
All types now can be read aligned and read unaligned
Compound types like structs, arrays, tuples and unions can also be written or read as packed meaning it reads the least amount of bytes necessary
A new compound type has been added called TaggedUnion
Structs have been simplified into 1 class. It implements both Aligned and Packed meaning it can be read and written in all the ways possible

TODO's for later pr's:

Deno.Pointer
~Range checks~ Done
~Tests~
Benchmark harness
Sub byte ints
Bring back Viewable types.
Add Sized compound types for Viewable structs etc (lazy reading / writing)

Ready for review

The last few commits also added type checking on the tagged union discriminant. If you have string keys you need to specify a codec. If it's integers you may specify what type of integer (bigint / 64 bit ints are not supported). Also floats can break the typecheck but I wouldn't know how to fix that. (also doesn't make sense to use floats as discriminant)

I can still see lot's of improvements and changes but for now this looks great! Thank you!

We can discuss those on discord soon ish maybe? I have some more changes that I want to make to taggedunion for example


Add the possibility to Synchronize folder

I think I would be a nice feature to add a Synchronize feature when right clicking on a folder to synchronize to Remote -> Local or Local to Remote like this plugins does for Sublime Text 3

Hi guys,
Sorry for the long period of inactivity.
We are currently working on a new version : better code, more stable, and bug fixes.
Can you tell me more about this feature ? I don't understand the difference between synchronizing and download/upload...
For the compatibility, it will come with time and features :)
Thank you for using our work ! :)

A synchronization would check all the files on the server and compare them with the ones on the local machine to only uploads the ones that are not or are different on the server.
Local to remote : Upload all the files from local to remote that are not on the remote OR are different
Remote to local : Download all the files from the remote server to the local if the file is different or does not exists.

Thank you, I see what you want :)
I will develop this feature during the next releases, the priority is to fix all bugs.

Awesome ! :)
On Sun, 29 Mar 2015 at 21:32 Axel Moussard<EMAIL_ADDRESS>wrote:

Thank you, I see what you want :)
I will develop this feature during the next releases, the priority is to
fix all bugs.
—
Reply to this email directly or view it on GitHub
https://github.com/amoussard/sftp-deployment/issues/32#issuecomment-87508799
.

This is what I really need, it is kind of stopping me from moving to Atom from Sublime! It helps me quickly deploy my site, its almost there, it just needs to delete files that are removed from the server.


Improvements to examples/classification/

This lets you classify multiple images without needing to edit the example at all. I found it useful while investigating https://github.com/NVIDIA/DIGITS/issues/536.

Allow multiple input image files
Expose batch_size as an option

FYI, you can use a command like this to:

Read a list of images from a text file
Strip off any label information at the end of each line
Pass the image files as command-line arguments to use_archive.py:

cat list-of-images.txt | awk '{print $1}' | \
    xargs ./use_archive.py 20160129-133556-a640_epoch_3.0.tar.gz --batch-size=10


runtime/pprof: TestTimeVDSO is flaky on android builders

#!watchflakes
post <- goos == "android" && test == "TestTimeVDSO"

CL https://go-review.googlesource.com/c/go/+/337590 added a test TestTimeVDSO. But it is flaky on Android builders. I'll look into it.

This flaky TestTimeVDSO failure happened at least once also on linux/amd64:
--- FAIL: TestTimeVDSO (5.00s)
    pprof_test.go:514: total 0 CPU profile samples collected:
    pprof_test.go:530: too few samples; got 0, want at least 125, ideally 500
    pprof_test.go:549: time.now: 0
    pprof_test.go:552: no samples in expected functions
    pprof_test.go:562: time.now has 0 samples out of 0, want at least 1, ideally 0

(Build log.)
From a slowbot run on CL 361294. It didn't happen on the first retry.

Oop, no. a skip was added in CL 352509 but we forgot to refer to this issue in the commit message.

Reverted. Still flaky.


After updating an event (resizing or dragging), one previous event is lost, causing UI distortion.

The calendar works perfectly, and I can retrieve all my events if I reload it manually. However, I want the updated or newly added events to reflect without manual reloading. When I update an event, it updates correctly but removes another event from the displayed list. I’m unsure if this issue is with the calendar or my React code, and I’d appreciate insights on whether it can be resolved if it’s related to the calendar.   i am using react and redux and node js in the backend to update events.
` eventResize: async (info) => {
if (user.access_level < 3) {
toast.error('You do not have permission to update events.');
return;
}
        const { event } = info;
        console.log("Resizing event:", event);

        const mongoId = event.extendedProps._id; // Ensure this exists
        if (!mongoId) {
          toast.error('Event ID missing. Cannot update.');
          info.revert();
          return;
        }

        const timezoneOffset = 3;
        const adjustedStartTime = adjustTimeForBackend(event.start, timezoneOffset);
        const adjustedEndTime = adjustTimeForBackend(event.end, timezoneOffset);

        const updatedEvent = {
          _id: mongoId,
          start_time: adjustedStartTime,
          end_time: adjustedEndTime,
          title: event.title,
          color: event.backgroundColor,
        };
       try {
          // Sync with backend
          await onEventUpdate(updatedEvent);
          toast.success('Event updated successfully!');
        } catch (error) {
          console.error('Error updating event:', error);
          info.revert(); // Revert changes if backend fails
          // setFilteredEvents(prevEvents); // Restore previous state
          toast.error('Failed to update event. Changes reverted.');
        } finally {
          calendarRef.current.refetchEvents(); // Ensure calendar reflects the latest state
        }
      },eventDrop: async (info) => {
        if (user.access_level < 3) {
          toast.error('You do not have permission to create events.');
          return;
        }
        const { event, jsEvent } = info;
        const timezoneOffset = 3;
        const adjustedStartTime = adjustTimeForBackend(event.start, timezoneOffset);
        const adjustedEndTime = adjustTimeForBackend(event.end, timezoneOffset);

        if (jsEvent.altKey) {
          const generatedId = uuidv4();
          const duplicatedEvent = {
            ...jsEvent,
            _id: generatedId,
            start_time: adjustedStartTime,
            end_time: adjustedEndTime,
            color_code: event.backgroundColor,
            title: event.title,
          };
          await onEventCreate(duplicatedEvent);
        } else {
          const mongoId = event.extendedProps._id; // Ensure this exists
          const updatedEvent = {
            _id: mongoId,
            start_time: adjustedStartTime,
            end_time: adjustedEndTime,
            color: event.backgroundColor,
            title: event.title,
          };
          await onEventUpdate(updatedEvent);
          }
      },`

Could be a couple of things. Double-check that the event IDs are being handled correctly throughout the update process. Specifically, how are you updating the events in the backend with the onEventUpdate function? It seems that you are only sending the extendedProps._id instead of the main event ID. Are you certain that you are updating the correct event in the backend?
This is how I am taking care of all event change cases (drop, resize, switching resource etc)
https://github.com/vkurko/calendar/discussions/336#discussioncomment-11642155
In the backend, I am using the 'event_id' variable in order to find and update the event, which is basically the ID of the event in the database. In your case, are you certain that the mongoId is correctly set with the ID of the event?


reconncet, can not connect,school firewall ?

English Only (except for bug reporting).

Below are some common reasons:

you didn't add the local firewall rule (produced by -g option) correctly.  In this case you should add and re-try.
your school might be using some proxy-based method for traffic local balancing.  this kind of environment doesn't alow raw socket to pass correctly. So unfortunately if this is the case, the problem is not solvable

Below are some common reasons:

you didn't add the local firewall rule (produced by -g option) correctly.  In this case you should add and re-try.
your school might be using some proxy-based method for traffic local balancing.  this kind of environment doesn't alow raw socket to pass correctly. So unfortunately if this is the case, the problem is not solvable

Below are some common reasons:
1. you didn't add the local firewall rule (produced by `-g` option) correctly.  In this case you should add and re-try.

2. your school might be using some proxy-based method for traffic local balancing.  this kind of environment doesn't alow raw socket to pass correctly. So unfortunately if this is the case, the problem is not solvable


Different results with /ai/annotate-image (controlnet mask generation)

There is a slight difference in the /ai/annotate-image compared to the frontend, due to some unknown conversion frontend-side.
Base image: image
Base image from frontend: image_input_frontent
Putting the image_input_frontent through the endpoint yields the same result as the frontend.

From what I found, the difference is only -1/+1 in one of the RGB channels for ~half of the pixels of the top 25% of the image (so ~1/8 of the image). This is done by the frontend before sending the image to the backend to get the mask, but the reasons for such a subtle change are unknown.


⚠ Bofrost.at has degraded performance

In 758057a, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2124 ms

Resolved: Bofrost.at performance has improved in 3f55bac after 7 minutes.


[BEAM-11806] Explicit Partition Support for KafkaIO.WriteRecords

At present, the WriteRecords transform for KafkaIO does not recognize the partition property defined on ProducerRecord instances consumed by the transform:
producer.send(
        // The null property in the following constructor represents partition
        new ProducerRecord<>(
            topicName, null, timestampMillis, record.key(), record.value(), record.headers()),
        new SendCallback());

Because of this limitation, in a scenario where a user may desire an explicitly defined partitioning strategy as opposed to round-robin, they would have to create their own custom DoFn that defines a KafkaProducer (preferably within a @StartBundle) similar to the following approach (in Kotlin):
private class ExampleProducerDoFn(...): DoFn<...>() {
        private lateinit var producer: KafkaProducer<...>

        @StartBundle
        fun startBundle(context: StartBundleContext) {
            val options = context.pipelineOptions.`as`(YourPipelineOptions::class.java)
            producer = getKafkaProducer(options)
        }

        @ProcessElement
        fun processElement(context: ProcessContext){
            // Omitted for brevity

            // Produce the record to a specific topic at a specific partition
            producer.send(ProducerRecord(
                "your_topic_here",
                your_partition_here,
                context.element().kv.key,
                context.element().kv.value
            ))
        }
}

The initial pull request that I threw in here simply replaces the existing null with the record.partition() (i.e. the record that was explicitly defined initially, but it may require some other changes which I'd need someone more familiar with the KafkaIO source to chime in on.
Additionally, I created a corresponding JIRA ticket, which any feedback would be appreciated on as well.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Java PostCommit

Thanks Alexey,
I've updated the original commit message to include the JIRA issue as recommended. Do you know of the more appropriate place within the repository to add the unit test? I see quite a bit of Kafka-related tests across the place, but wasn't sure where something like this would best fit.
Additionally, I do feel that the recommended refactoring would be most appropriate in this case (i.e. sending the ProducerRecord instance itself instead of creating a new instance). IMO, that change makes more sense, but I'll leave it up to you if that's the referred fix here.

Rion, please add your test into org.apache.beam.sdk.io.kafka.KafkaIOTest, we used to use to KafkaIO unit testing in general. I believe it already contains some tests for Write with ProducerRecord, take a look on testRecordsSink(), for example. I think it can be just adjusted to check that right partition was properly set in ProducerRecords.

@aromanenko-dev
I've made the changes that you had mentioned (added a unit test that required a few additional constructors to support the addition of partitions in the KV2ProducerRecord test class). I ran through the spotless apply script as well as a check against the KafkaIO SDK after the changes were made and it was successful.
Let me know if there's anything else that we need to do on this front or if I need to update the JIRA to reflect a specific version, etc.

Run Java PreCommit

LGTM, merging. I'll take care of Jira.
Thank you for contribution!


As a user, I want the option to retrieve the top (N) populated cities in a specific district, where (N) is specified, so that I can obtain a list of the most populous cities within that district

SQL:
select city.Name, country.Name as Country, city.District , city.Population  from city inner join country  on city.CountryCode = country.Code
where city.District  = '%district%'
order by city.Population desc
limit %n%;
Parameters:
%district%
%n%

report16.xml added to feature/reports branch


HSEARCH-1681 Index optimisation should commit to publish the performed optimisation

https://hibernate.atlassian.net/browse/HSEARCH-1681

merged


olm data needs to be updated for 4.3

https://github.com/operator-framework/operator-metering/tree/release-4.3
file not found: manifests/deploy/openshift/olm/bundle/4.3/image-references

cc @chancez


add test for reserved fields

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+10.0%) to 52.055%

Totals

Change from base Build<PHONE_NUMBER>:
10.0%

Covered Lines:
266

Relevant Lines:
511

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+10.0%) to 52.055%

Totals

Change from base Build<PHONE_NUMBER>:
10.0%

Covered Lines:
266

Relevant Lines:
511

💛  - Coveralls


[wish] ppa archive with justdoit flavor

Scarygliders is great, but takes a very long time to setup.
I imagine most people only use the justdoit option, so would it be possible to provide a ppa archive containing prebuilt debs that we could simply install with apt-get?

Debian now provides develop snapshot version of xrdp.


Multiplayer Waterfall/Paper server: No Strip causes disconnect

Afternoon,
I had updated a bunch of mods today and found that when trying to connect to a Waterfall/Paper multiplayer server, it would either disconnect me immediately or within a minute or so of being connected. All it'd say was "Connection Lost" and wouldn't allow me to disconnect. After removing all mods and re-adding one by one, No Strip appeared to be the one to make it disconnect. It would throw a "[Netty Epoll Client IO #1/WARN]: Received invalid channel identifier "legacy:fml|hs" from connection net.minecraft.class_2535@5021ecec" in latest.log before disconnecting. See: https://pastebin.com/F9Hzw7XF.
nostrip-1.2.0-1.16.2+, loader 0.11.1-1.16.5, API 0.30.0 (though 0.29.4 didn't work either.)

Nevermind... turns out I pasted two different mods at once, removing the other solved it. User Error

Nevermind... turns out I pasted two different mods at once, removing the other solved it. User Error


"Add another category" link is missing from Categories table

The link to "add another category" is not appearing when selecting "Categories only" or "Categories & weighting" from the settings menu:

Unlike the other Morpheus button related issues (like the "Remove" button in the same table), the issue does not appear to be that the font is white. Rather, when trying to click in the area where the link should be, it isn't there at all.

Upon server rebuild, it looks like the button IS there, it's just being hidden like the other morpheus buttons. This doesn't need its own issue. Closing.


Documentation: guide for using let in vs rec vs finalAttrs

Problem
I often see maintainers and committers alike suggesting to use the let in syntax following the practices suggested by https://nix.dev/guides/best-practices.html. However, this is hardly uniform some would suggest using rec, and it's hard to get a solid grasp on what to use in each situation. This was only exemplified when finalAttrs started popping up more commonly as of recent.
Proposal
From my understanding https://nix.dev is an official source so perhaps it would be best to get everyone on board and aware of this best practice? Or maybe to get a more concrete set of best practices to use in each given situation. Or at the very least make members aware that the let in syntax is said to be the best practice, as stated in https://nix.dev/guides/best-practices.html.
Checklist

[x] checked latest Nixpkgs manual (source) and latest NixOS manual (source)
[x] checked open documentation issues for possible duplicates
[x] checked open documentation pull requests for possible solutions

Add a :+1: reaction to issues you find important.

At the very least I'd like reviewers to stop nitpicking between these.
Unless there is explicit community-wide consensus (i.e. RFC), wide-spread historical precedent (i.e. mkDerivation attr order) or significant concrete problems with the code (i.e. correctness, readability), people should be free to use whichever code patterns or organisation they like.
And by significant, I really do mean significant. Code being organised against your personal preference or patterns you dislike being used are minor differences in taste, not a significant readability problems.
Nitpicking such "issues" is not in any way productive and utterly confusing/unwelcoming to newcomers. They are faced with dozens such implicit rules that aren't explicitly written down anywhere and, even worse, differ wildly depending on which person reviews the code. I don't doubt we've lost more than a dozen contributors whose first PR was faced with 12 nitpicks and 0 actually substantial review comments and then left to bitrot for months.

I was (and still am, I guess) one of those nitpickers and I think what really needs to happen here is to standardize the finalAttrs pattern so that it's not only applicable to mkDerivations. Nowadays I don't even nitpick recs appearing in other builders and change them to let-ins, but when I didn't change that in one of my own PRs I got nitpicked for that :sweat_smile:
It almost feels pedantic, in a way, with the rule being more of a dogma, and the rationale behind it not being at all clear to new contributors and the applicability of it still very limited. We should really try to explain things more, come to a common standard, and make that standard applicable to everything.

i think #310373 is important to bring up in this conversation.
at first glance, finalAttrs does seem like a "silver bullet" to overrides propagating across the expression. however, continuing from the example above:
lib.trace (withRec.overrideAttrs { version = "0.2.0"; }).src.rev # v0.1.0
lib.trace (withFinalAttrs.overrideAttrs { version = "0.2.0"; }).src.rev # v0.2.0

while the rev of src is overridden through finalAttrs, hash isn't. as explained in the issue, this and other uses of finalAttrs can easily introduce a lot of footguns to users when overriding; and even in the best case, the use of finalAttrs over rec here doesn't really improve anything for the end user

At the very least I'd like reviewers to stop nitpicking between these.

this is probably what i want most out of this issue, though. a lot of times the differences between these patterns are exactly that: nitpicks. i'm sure it's frustrated many here time and time again - and if it doesn't actually benefit our user in many cases, why are we doing it? why are we giving new contributors a hard time over preferred patterns to reach the same goal?
i would personally encourage package maintainers to use their personal preference unless it's actually affecting how the expression is used or defined. for other readability/consistency concerns, we will hopefully have nixfmt soon tree-wide soon 😄

The problem with version specifically, I think, is that it's either easy to forget to update the hash if the rev depends on finalAttrs.version, or it's easy to forget to update the source altogether. Might be better to have a built-in lint/warning/assert against that in mkDerivation

It may also be worth reading over https://github.com/NixOS/nixpkgs/issues/293452 and  https://github.com/NixOS/nixpkgs/pull/119942.

@getchoo made the same points I was going to make.
To that I want to add that whenever this comes up, one should think about which parts of the package they want to expose as an external API and what parts you don't.
finalAttrs responds specifically to overrideAttrs, not overrides in general. Whether you want to use the pattern depends on whether you want the reference attributes to be be generically overrideable; part of the package's API. It does not always make sense to do this however. As @getchoo pointed out, exposing the version as part of the API using finalAttrs like this has issues.
As a more robust alternative, I've recently discovered that you can simply make such parameters part of the regular override interface. I think this is even better as it makes them explicit part of the package's external API and allows other parts of the external API to respond to version changes (i.e. withFoo ? lib.versionAtLeast version "6.1"). I did this in the ffmpeg package and I think it's better for it: https://github.com/NixOS/nixpkgs/pull/295691/files#diff-547e4d5699df1c405afdc0c2837df95959ed6de64f384ca5720ee37367eebcce
This design allows you to take any ffmpeg variant (i.e. ffmpeg_7-full) and transform it into any other (i.e. ffmpeg_4-headless) using only override, without any overrideAttrs.
Regardless of opinions on these manners though, a table like @pluiedev's would be great to have in the contributor's manual. We generally need more such short summaries and general guidelines to be written down in accessible places.
I also want to mention that, in my book, it is perfectly valid to use rec, let ... in and finalAttrs in combination as they each have distinct purposes.

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/more-official-guidelines-in-regards-to-styling-choices/48407/3

Perhaps a table could serve as a brief explanation as to why one pattern may be preferred over the other?
Pattern 	Overridability 	Readability 	Applicability
rec 	❌ Does not automatically respond to overrides 	❌ Recursive variables could be hard to spot and locate in a large file 	✔ All builders
let in 	❌ Does not automatically respond to overrides 	✔ Variables are clearly defined in the let portion, and used in the in portion 	✔ All builders
finalAttrs 	✔ Automatically responds to overrides 	✔ Recursive variables are explicitly prefixed with finalAttrs or inherited from finalAttrs 	❌ Only mkDerivation
Also, the existence of finalAttrs is buried in a tiny chapter in the huge Nixpkgs manual, which nobody would even know of were it not for the recent surge of its use. I think there should also be more coverage of this pattern elsewhere in the scattered Nix docs, so that new contributors could be made aware of it before they start contributing. The explanation of the differences between rec and finalAttrs is also terribly unclear and not backed up with concrete examples, like so:
let
  withRec = stdenv.mkDerivation rec {
  	pname = "with-rec";
  	version = "0.1.0";

  	src = fetchFromGitHub {
  	  owner = "example";
  	  repo = "example";
  	  rev = "v${version}";
  	  hash = "...";
  	};
  };
  withFinalAttrs = stdenv.mkDerivation (finalAttrs: {
  	pname = "with-rec";
  	version = "0.1.0";

  	src = fetchFromGitHub {
  	  owner = "example";
  	  repo = "example";
  	  rev = "v${finalAttrs.version}";
  	  hash = "...";
  	};
  });
in
lib.trace (withRec.overrideAttrs { version = "0.2.0"; }).src.rev # v0.1.0
lib.trace (withFinalAttrs.overrideAttrs { version = "0.2.0"; }).src.rev # v0.2.0
{};
``

What's missing in this table is the performance overhead of finalAttrs.

btw, finalAttrs also applies to the nim and php builders, perhaps some others as well that I don't know offhand.

btw, finalAttrs also applies to the nim and php builders, perhaps some others as well that I don't know offhand.

It's kinda part of the problem, isn't it? It's very inconsistent as to which builders have the fixed-point capability...

Someone has to care enough to add it to the other builders, basically. Or redo the entire fixed-point concept from scratch.


Fix builds for OSX

CircleCI are deprecating their x86 OSX machines, on the basis that we can then build on arm64 - although there doesn't seem to be a good answer to "how do we test on osx x86?".
Some deprecations are happening in 2 weeks, which this PR hopes to avoid, and will then allow us to continue until the end of Jan 24 at which point x86 will no longer be available.
At the same time this PR switches to building darwin-arm64 on an M1 machine. Best review by commit as the first contains an auto-format that touches lots of parts other than the actual change at the top.
  darwin-amd64:
    # Note - not an actual ARM macOS machine (https://circleci.canny.io/cloud-feature-requests/p/support-new-m1-arm-based-macs)
    macos:
      xcode: 15.1
    resource_class: macos.x86.medium.gen2

Annoyingly the test that is often flaky on windows, is flaky now we actually test on darwin-arm64, but doesn't show up locally.

This test (Retries) fails for me more than it passes. Would it be worth skipping it (t.Skip)  for these specific envs, and creating an issue to fix it?

This test (Retries) fails for me more than it passes. Would it be worth skipping it (t.Skip) for these specific envs, and creating an issue to fix it?

We should only Skip tests where it's not possible to support the test or the functionality itself in the environment.
Create an issue if needed, but I'd be happier if we just fixed it!

Here is my reasoning for skipping it in this specific case:

TestRetriesSuite runs in the linux environment, generally without flake. We have coverage of the scenario being tested.
On this branch the test has run

5 times with a 0% success rate for the darwin env
7 times with an 87% success rate for the windows env
(source)

Given the test is passing in the Linux environment I believe we can gain some confidence the behavior is being exercised and works as expected. By opting to skip the test in the flaky environments (darwin arm and windows amd) we can increase developer velocity and save some circle CI credits.
My hunch regarding the failure is related to non-determinism in the timing of it: TestRetriesSuite/TestRetry/publish-partial-failure is almost always the culprit. It uses "good-guy-1" that's programmed to sleep for some time. The proper fix will likely entail adding a mockable clock in the call path of the test. I've filed an issue for it here: https://github.com/bacalhau-project/bacalhau/issues/2841

My hunch regarding the failure is related to non-determinism in the timing of it: TestRetriesSuite/TestRetry/publish-partial-failure is almost always the culprit. It uses "good-guy-1" that's programmed to sleep for some time

Yeah, I thought it might be the execution state update being delayed and appearing after the job state becomes terminal (and we do the assertions) and I guess that sleep might cause that.
Given it appears on arm64 (M1) as well now, although I can't replicate on my M2, we should probably take the pain in fixing the time issues although if we just want the bad actor to finish first, maybe we should just wait for it to finish?

I was able to get a failure locally on my M1:
=== RUN   TestRetriesSuite/TestRetry
    --- FAIL: TestRetriesSuite/TestRetry (0.75s)
=== RUN   TestRetriesSuite/TestRetry/publish-partial-failure
07:58:22.362 | INF pkg/executor/noop/executor.go:96 > starting execution
07:58:22.403 | INF pkg/executor/noop/executor.go:96 > starting execution
07:58:22.419 | INF pkg/compute/executor.go:183 > cleaning up execution [NodeID:QmVwZ5EY] [execution:e-308d3753-4be6-4869-9e90-93637c1fcf94] [job:22a449d9-0165-4341-8b3c-cfd24f62e705]
07:58:22.419 | ERR pkg/compute/executor.go:452 > Publishing execution e-308d3753-4be6-4869-9e90-93637c1fcf94 failed error="failed to publish result: I am a bad publisher" [NodeID:QmVwZ5EY] [execution:e-308d3753-4be6-4869-9e90-93637c1fcf94] [job:22a449d9-0165-4341-8b3c-cfd24f62e705]
07:58:22.601 | INF pkg/executor/noop/executor.go:96 > starting execution
07:58:22.612 | INF pkg/compute/executor.go:183 > cleaning up execution [NodeID:QmVwZ5EY] [execution:e-1025c3d4-1dea-4d56-97a2-7969c0685d19] [job:22a449d9-0165-4341-8b3c-cfd24f62e705]
07:58:22.613 | ERR pkg/compute/executor.go:452 > Publishing execution e-1025c3d4-1dea-4d56-97a2-7969c0685d19 failed error="failed to publish result: I am a bad publisher" [NodeID:QmVwZ5EY] [execution:e-1025c3d4-1dea-4d56-97a2-7969c0685d19] [job:22a449d9-0165-4341-8b3c-cfd24f62e705]
07:58:22.666 | INF pkg/compute/executor.go:183 > cleaning up execution [NodeID:QmSmEztt] [execution:e-7df55c89-3b5f-4d69-89d7-ade141424738] [job:22a449d9-0165-4341-8b3c-cfd24f62e705]
07:58:22.681 | ERR pkg/orchestrator/worker.go:157 > Failed to process evaluation 34c1c79e-2332-42c4-8243-0e5edb0e818f error="failed to process plan with planner *planner.StateUpdater: execution e-7df55c89-3b5f-4d69-89d7-ade141424738 has version 6 but expected 5"
07:58:22.799 | ERR pkg/orchestrator/planner/logging_planner.go:23 > Job 22a449d9-0165-4341-8b3c-cfd24f62e705 failed due to `failed to publish result: I am a bad publisher`
    retries_test.go:317:
        	Error Trace:	/Users/frrist/Workspace/src/github.com/bacalhau-project/bacalhau/pkg/test/requester/retries_test.go:317
        	            				/Users/frrist/Workspace/pkg/mod/github.com/stretchr/testify@v1.8.4/suite/suite.go:112
        	Error:      	Not equal:
        	            	expected: 1
        	            	actual  : 0
        	Test:       	TestRetriesSuite/TestRetry/publish-partial-failure
        	Messages:   	Expected 1 executions in state Cancelled, found 0

And on the next run a sucess:
--- PASS: TestRetriesSuite (12.18s)
=== RUN   TestRetriesSuite/TestRetry
    --- PASS: TestRetriesSuite/TestRetry (0.53s)
=== RUN   TestRetriesSuite/TestRetry/publish-partial-failure
07:59:25.479 | INF pkg/executor/noop/executor.go:96 > starting execution
07:59:25.501 | INF pkg/compute/executor.go:183 > cleaning up execution [NodeID:QmZfh5aZ] [execution:e-120b91b3-237d-43ea-a46f-cb79f5a645c9] [job:84e3df33-0f61-4cfa-9bd7-e86f88ee9687]
07:59:25.501 | ERR pkg/compute/executor.go:452 > Publishing execution e-120b91b3-237d-43ea-a46f-cb79f5a645c9 failed error="failed to publish result: I am a bad publisher" [NodeID:QmZfh5aZ] [execution:e-120b91b3-237d-43ea-a46f-cb79f5a645c9] [job:84e3df33-0f61-4cfa-9bd7-e86f88ee9687]
07:59:25.521 | INF pkg/executor/noop/executor.go:96 > starting execution
07:59:25.642 | INF pkg/executor/noop/executor.go:96 > starting execution
07:59:25.653 | INF pkg/compute/executor.go:183 > cleaning up execution [NodeID:QmZfh5aZ] [execution:e-c52977ee-a289-4841-98ae-f5d5a379b4e6] [job:84e3df33-0f61-4cfa-9bd7-e86f88ee9687]
07:59:25.653 | ERR pkg/compute/executor.go:452 > Publishing execution e-c52977ee-a289-4841-98ae-f5d5a379b4e6 failed error="failed to publish result: I am a bad publisher" [NodeID:QmZfh5aZ] [execution:e-c52977ee-a289-4841-98ae-f5d5a379b4e6] [job:84e3df33-0f61-4cfa-9bd7-e86f88ee9687]
07:59:25.71 | INF pkg/executor/noop/executor.go:157 > cancel execution
07:59:25.736 | ERR pkg/orchestrator/planner/logging_planner.go:23 > Job 84e3df33-0f61-4cfa-9bd7-e86f88ee9687 failed due to `failed to publish result: I am a bad publisher`
07:59:25.771 | INF pkg/compute/executor.go:183 > cleaning up execution [NodeID:QmRhPH9M] [execution:e-bd4bfaf1-2474-4ebd-a66d-0f6713df0d58] [job:84e3df33-0f61-4cfa-9bd7-e86f88ee9687]
07:59:25.772 | ERR pkg/compute/executor.go:452 > Publishing execution e-bd4bfaf1-2474-4ebd-a66d-0f6713df0d58 failed error="execution e-bd4bfaf1-2474-4ebd-a66d-0f6713df0d58 is in state Cancelled but expected one of [Running]" [NodeID:QmRhPH9M] [execution:e-bd4bfaf1-2474-4ebd-a66d-0f6713df0d58] [job:84e3df33-0f61-4cfa-9bd7-e86f88ee9687]
07:59:25.772 | ERR pkg/compute/executor.go:460 > Failed to update execution (e-bd4bfaf1-2474-4ebd-a66d-0f6713df0d58) state to failed: execution e-bd4bfaf1-2474-4ebd-a66d-0f6713df0d58 is in terminal state Cancelled and cannot transition to Failed error="execution e-bd4bfaf1-2474-4ebd-a66d-0f6713df0d58 is in terminal state Cancelled and cannot transition to Failed" [NodeID:QmRhPH9M] [execution:e-bd4bfaf1-2474-4ebd-a66d-0f6713df0d58] [job:84e3df33-0f61-4cfa-9bd7-e86f88ee9687]

One the key differences in the Fail/Pass it the line below in the success case:

07:59:25.71 | INF pkg/executor/noop/executor.go:157 > cancel execution
2332-42c4-8243-0e5edb0e818f error="failed to process plan with planner *planner.StateUpdater: execution e-7df55c89-3b5f-4d69-89d7-ade141424738 has version 6 but expected 5"

Perhaps there is a race in cancellation due to the executor_buffer calling cancel in a go routine? The execution could already be in a failed state when cancel is evaluated, and thus cannot be transition from Failed to Canceled?


fix: Move user to image config

Signed-off-by: Ce Gao<EMAIL_ADDRESS>

/cc @kemingy @VoVAllen

LGTM. But I think the envd-server error is not caused by the user.

Yep, I verified that it is not from the user.


The ability to register metric collectors from application

Need a new RPC method to register metric from the application, metrics must only be declared once so consecutive runs would have no effect.

https://github.com/spiral/roadrunner/tree/master/service/metrics This service provides the ability to push metrics from PHP only based on metrics defined in confirm. New new set of RPC methods to declare metrics dynamically.


fix: remove source map warnings for files that are not processed by vite-plugin-sass-dts

Vite issues the following warning when ignoring files for transformation.
Sourcemap is likely to be incorrect: a plugin (vite-plugin-sass-dts) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help

It will also break source maps as the warning states. Returning undefined from the transformation function will remove the warning and fix broken source maps.

@tmair
Thanks for the PR.


feat: add ability to retry completions

Closes #9
Closes #100

:tada: This PR is included in version 0.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fix: lint :green_heart:

Description
This commit bumps go version to 1.21.0 and changes go get to go install.
Motivation and Context
Current workflow for PRs is broken because the tool that is invoked to format the code, shfmt, requires go >= 1.19.
How Has This Been Tested?
Workflow was launched again after fix and it doesn't fail anymore.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.

Please merge this PR! - All new PRs are failing without this change, currently.

It looks like #2224 that I just made is similar - but I have also updated the GitHub actions that we use

For KISS reasons I think we should go with this one, but thank you for taking the time to get this fixed !

cc:  @robertoschiavone , @hyperupcall , @bittner

Sounds good - perhaps I should update mine to only make only the Actions upgrades once this is merged

Sounds good - perhaps I should update mine to only make only the Actions upgrades once this is merged

Yeah  we can do that ...  One Q on it (which I should have posted over there on it): Are the quotes needed?   Although technically more correct, having some quoted and some non-quoted values feels less clean than current  .... I would say leave unquoted unless needed

Yeah quotes in YAML aren't needed unless they're actually needed. I've heard too many near-death experiences from YAML that I have a habit of quoting everything I touch. But no worries I'll make the changes without quotes this time around


Check coverage in Montana

Am I missing tiles or is the backend broken?
You know, I'm guessing this has to do with how I'm filling-in tiles. I currently fill in when a tile doesn't exist. But here only part of the mercator tile isn't covered. So I think this is just due to some missing data in this part of Montana.
Not sure if a good way to fix it.

See https://github.com/kylebarron/naip-lambda/issues/2

Maybe take the shapefile index and find all tiles that aren't entirely covered?


Fix each 'error' return statement in resources

These 'return 403' effectively put the 403 int inside of the response data instead of being interpreted as a status code.
Fixed it by returning an empty 'data' dict along with the code. There may be a prettier way to do it - if so, please let me know.

This is good enough, although I think the preferred method would be to use Flask's abort
if not condition:
    abort(403)


Add class to element if not present, register to parent router if non-direct ancestor.

This has already been done.


Row & Column Totals

I'm pretty new to programming, especially in meteor/react and this package is awesome - super light weight, easy to install and implement - thank you!
I was wondering if you have any plans to support row and column totals?

Hi @zheath, yes we do plan to add it. We have an open issue on the quick-pivot engine to add the row and column totals here. Once implemented in the quick-pivot it will be easy to add to react-virtualized-pivot. Will get back to you on timing shortly.

Closed by accident.

@zheath @turnerniles have a PR open for row aggregation across the entire table (i.e. one row at the bottom that contains the aggregated values of all the rows in each column) based on the selected aggregation function. I'll get the column aggregation in a different PR.

@zheath @turnerniles please see #104. Will merge shortly.

@zheath @pat310 Row totals are live.

@turnerniles Almost have a PR ready for column totals

@pat310 @zheath See #105 will merge shortly...


input: ft5336: add suspend and resume support

Add power management support to ft5336. The chip can go to hibernate and reduce power consumption to a minimum, the only way to wake it up though is by pulsing the reset or wake signal. Only reset is implemented in the
driver right now so only allow this functionality if the reset pin is defined.

This approach makes sense to me- how sure are we that the PMOD_HIBERNATE value is consistent across the FT6xxx, FT5xxx, and FT3xxx parts? From the datasheets I can find online it seems like hibernate mode is supported on all these controllers, there are just quite a few controllers supported by this driver

Not really sure to be honest, but this is used in Linux unconditionally in a driver named edt-ft5x06.c, and that seems to cover multiple ft5* and ft6* parts, so we may be in luck and have all of them covered?

Couple tweaks:

added pm runtime support
made it work even in the no-interrupt case


Basic ltree query support

Added support for quering ltree columns.
closes #554

@arxdsilva
I'm trying to run the tests with
go test -v ./adapters/postgres -run TestWhereByRequest

But I'm getting:
go test -v ./adapters/postgres -run TestWhereByRequest
2022/12/27 22:15:33 [error] pq: SSL is not enabled on the server
FAIL	github.com/prest/prest/adapters/postgres	0.008s
FAIL

Not sure if the [error] is fatal or if it's hiding what is going on...

Appreciate any tips to run the tests locally.

Found it. It's clear that I'm not a strong reader https://github.com/prest/prest#run-locally :joy:

These are the simplest operators regarding ltrees, probably the others are better implemented using custom queries.

LGTM! 😉

Done. Added the parameters to the docs.
Let me know if there is something else to add...

Thanks @diasbruno


Question/Feature Request: Set pan to background image size

Is there a way that the editor zooms exactly to the size of the background image? Is there a parameter to set the zoom/pan?
Thx for feedback.

There is no built-in method to do what you want, but lc.setPan() and lc.setZoom() will let you implement it yourself.

Awesome, this works. Thanks Steve


Created express routes for all products and single product along with…

created Express Routes for All products and Single
tests written and passed

routes for all products & singe product looks good


Issue after Home Assistant 2022.9.5 Update

Lost connection after update to Home Assistant 2022.9.5
Integration was working fine on older build, I have tried removing and re-adding the integration and logging back in to no avail.

Just a quick update, I checked again this morning and it seems to be polling data. The only issue remaining is the Gas Cost Unit and Electricity Cost Unit.
See attached image for reference.


Support socket activated session dbus

These changes are intended to allow the session dbus to be socket activated and the user systemd session to fully work.
E.g., with these changes applied it is, e.g., possible to use systemctl --user --wait and manage dbus-activated user services through systemctl.

Aw, I'm not sure should've unmarked this as a draft @rycee.
Being that it was approved I did assume that it was at least "ready for review" with maybe a caveat for the user unit hook to avoid mass rebuild.

@worldofpeace Ah, no I didn't intend to move this out of WIP yet.

@rycee https://github.com/NixOS/nixpkgs/pull/67942/commits/96b6ae028b4badf38ca388996b1f55ed5c342a0c should fix https://github.com/NixOS/nixpkgs/issues/68383 if we increase the scope of its use to be pretty much everywhere.
(thanks for writing it btw :sparkles: )
Would you mind making a separate PR for it, or perhaps would you mind if I pursued it separately?

I've now committed https://github.com/NixOS/nixpkgs/pull/67942/commits/c5b6227f04921ef0d0e1810d476fe11158503c44 @rycee on master.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/sending-notifications-from-system-services/4825/2

i would love to see this PR in action - my use case is sending notifications from different systemd services (namely networkmanager-dispatcher).
Cheers!

FWIW, I've been using this for quite a while on my 19.09 laptops without any issues so I think everything should be good. But I manually inject the move-systemd-user-units.sh into the packages I use. I cannot vouch for everything working when all packages are given this hook through stdenv.

I managed to build a simple VirtualBox image with this stdenv but ran into some weird dbus issue, DBUS_SESSION_BUS_ADDRESS seemingly got set somehow before the X session got started so
if test -z "$DBUS_SESSION_BUS_ADDRESS"; then
  exec ${pkgs.dbus.dbus-launch} --exit-with-session "$0" "$@"
fi

never entered the if statement. Not sure if this issue is related to the patch. I'll try to dig into it when I have some spare time.

This needs a rebase.

Pinging @rycee for the needed rebase

I readded the WIP tag since I'm unlikely to continue working on this until July or so when I hopefully have the time to set up a build cluster or something to be able to test it.

I've rebased this PR. I don't really see any reason to leave this as is. Let's give it a run in staging :+1:

@worldofpeace I'm a bit worried about the issue I mentioned in https://github.com/NixOS/nixpkgs/pull/67942#issuecomment-564275008. I don't really understand how that could happen just from adding the hook, though. But perhaps it would be worth putting the change in staging for testing, if it doesn't work then I suppose the commit can always be reverted in the staging branch.


How to listen to FlutterWebRTCPlugin events?

Hi,
I wanted to know if is there a way to listen to changes in FlutterWebRTCPlugin, for example get a callback and perform some action at the instant onIceGatheringChangeGATHERING or onConnectionChangeCONNECTED.
Thank you

Got it, just realized callSession in conversation_screen is doing exactly that. Thank you for the amazing P2P sample!


Ensure types are exported correctly

Currently types arent shipped correctly in published package.

What do you mean? They are included?
I haven't tried in Code or something though, so might me something malformed for all I know


[Feature]: Only use confirmed inputs when transfer to spending

Describe the problem
When attempting to transfer to spending I am blocked by a small unconfirmed UTxO even though I have three other confirmed unspent outputs that could be used instead.

https://github.com/user-attachments/assets/0ad95eab-5cd4-4503-a840-9500aaef5d78
The fee market has spiked and I am unable to boost the transaction, so even though I have the funds available in confirmed unspent outputs I must wait potentially hours before I can transfer to spending balance.
Describe the solution
The transfer flow should ignore the unconfirmed UTxOs and proceed without them if possible.
Also consider letting the user decide which inputs to try when in manual coin selection mode.
Additional context
No response

There is no requirement for these order payment transactions to use confirmed UTXOs. Are you sure you've not reached the node capacity limit as the error suggests?

Ah, probably. I cannot see my old 600 sat spending channel anymore but it may well have had a very large receiving capacity.


reconFTW: invalid option -- 'w' but --web is working

Describe the bug
Running the script as described in the usage:
Perform Web based scanning on a subdomains list:
./reconftw.sh -d example.com -l targets.txt -w
and
./reconftw.sh -l targets.txt -w
Isn't working and only shows the usage again. As a Workaround the following command is working:
./reconftw.sh -l targets.txt --web
To Reproduce
Steps to reproduce the behavior:

Create any subdomain-list
Start recon with either ./reconftw.sh -l targets.txt -w or  ./reconftw.sh -d example.com -l targets.txt -w
reconFTW: invalid option -- 'w'

Expected behavior
Same as --web is doing
Screenshots
./reconftw.sh -l example.txt -w

./reconftw.sh -l example.txt --web

Desktop (please complete the following information):
Distributor ID: Debian
Description:    Debian GNU/Linux 12 (bookworm)
Release:        12
Codename:       bookworm
Additional context
I just skipped throught the code and the case got both in it:
'-w' | '--web') 		opt_mode='w' 		shift 		continue 		;;
It looks more like an issue with order of the params in combination with the shift at the cases but no clue so far why --web is working but not -w
I have also added -d and any name but with the same result.
//Edit:
Somehow the argument -w is interpreted as --, here the output of the current argument before the case:
./reconftw.sh -l example.txt -w                                                                                reconFTW: invalid option -- 'w'
argv is -l
argv[3] is --
argv is --
argv[3] is
#############################################
./reconftw.sh -l example.txt --w
argv is -l
argv[3] is --web
argv is --web
argv[3] is
argv is --
argv[3] is
##############################################
./reconftw.sh -l example.txt -r                                                                                argv is -l
argv[3] is -r
argv is -r
argv[3] is
argv is --
argv[3] is
Same issue on Ubuntu 22.04.3 LTS (jammy):
./reconftw.sh -l example.txt -w
reconFTW: invalid option -- 'w'

Fixed https://github.com/six2dez/reconftw/commit/71f6150b9803fe5a428e25c2b4103ea9efe5d0ef