Some exceptions are not caught (with 1-line reproducible sample code)

Thanks for this newly developed package sentry_flutter! However, I see that some exceptions are not caught...
Platform:

[x]  Dart
[x]  Flutter Android or iOS
[ ]  Flutter Web

IDE:

[ ]  VSCode
[x]  IntelliJ/AS
[ ]  XCode
[ ]  Other, which one?

split-debug-info and obfuscate (Flutter Android or iOS) or CanvasKit (Flutter Web):

[ ]  Enabled
[x]  Disabled

Platform installed with:

[x] pub.dev
[ ] GitHub

Output of the command flutter doctor -v below:
[✓] Flutter (Channel stable, 1.22.5, on Mac OS X 10.15.7 19H2 darwin-x64, locale zh-Hans-CN)
    • Flutter version 1.22.5 at /Users/tom/opt/flutter
    • Framework revision<PHONE_NUMBER> (4 weeks ago), 2020-12-10 11:54:40 -0800
    • Engine revision ae90085a84
    • Dart version 2.10.4
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/tom/Library/Android/sdk
    • Platform android-30, build-tools 29.0.3
    • ANDROID_SDK_ROOT = /Users/tom/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.0

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 48.1.1
    • Dart plugin version 192.8052
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)

[!] IntelliJ IDEA Ultimate Edition (version 2020.3)
    • IntelliJ at /Users/tom/Applications/JetBrains Toolbox/IntelliJ IDEA Ultimate.app
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • For information about installing plugins, see
      https://flutter.dev/intellij-setup/#installing-the-plugins

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.0

[✓] Proxy Configuration
    • HTTP_PROXY is set
    • NO_PROXY is <IP_ADDRESS>,localhost
    • NO_PROXY contains <IP_ADDRESS>
    • NO_PROXY contains localhost

[✓] Connected device (2 available)
    • JSN AL00a (mobile)                  • 7XBNW19215005473                     • android-arm64 • Android 10 (API
      29)
    • iPhone SE (2nd generation) (mobile) • 41640072-3F6C-45F1-A766-86FFCF6BD773 • ios           •
      com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    ! Error: iPhone has recently restarted. Xcode will continue when iPhone is unlocked. (code -14)

The version of the SDK (See pubspec.lock):
4.0.1

I have the following issue:
The description goes here ...
Steps to reproduce:
Add the following lines into the flutter/example/lib/main.dart. (Actually only 1 core line)
            RaisedButton(
              child: const Text('Throws in Future.delayed'),
              onPressed: () =>
                  Future.delayed(Duration(milliseconds: 100), () => throw Exception('Throws in Future.delayed')), // <-- THIS IS THE CRUCIAL LINE!
            ),
            RaisedButton(
              child: const Text('Throws in Future.then'),
              onPressed: () =>
                  Future.delayed(Duration(milliseconds: 100)).then((_) => throw Exception('Throws in Future.then')),
            ),

Then press it.
Actual result:
The exception is not caught. This is confirmed by: (1) From the console we see it is "unhandled" exception. (2) not see from Sentry webpage, while other exceptions are happily seen.
Example log:
Restarted application in 713ms.
flutter: [debug] release<EMAIL_ADDRESS>[VERBOSE-2:ui_dart_state.cc(177)] Unhandled Exception: Exception: Throws in Future.delayed
#0      MainScaffold.build.<anonymous closure>.<anonymous closure> (package:sentry_flutter_example/main.dart:64:69)
#1      new Future.delayed.<anonymous closure> (dart:async/future.dart:326:39)
#2      _rootRun (dart:async/zone.dart:1182:47)
#3      _CustomZone.run (dart:async/zone.dart:1093:19)
#4      _CustomZone.runGuarded (dart:async/zone.dart:997:7)
#5      _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1037:23)
#6      _rootRun (dart:async/zone.dart:1190:13)
#7      _CustomZone.run (dart:async/zone.dart:1093:19)
#8      _CustomZone.bindCallback.<anonymous closure> (dart:async/zone.dart:1021:23)
#9      Timer._createTimer.<anonymous closure> (dart:async-patch/timer_patch.dart:18:15)
#10     _Timer._runTimers (dart:isolate-patch/timer_impl.dart:397:19)
#11     _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:428:5)
#12     _RawReceivePortImpl._handleMessage (dart:isolate<…>

(and for the Future.then case:)

[VERBOSE-2:ui_dart_state.cc(177)] Unhandled Exception: Exception: Throws in Future.then
#0      MainScaffold.build.<anonymous closure>.<anonymous closure> (package:sentry_flutter_example/main.dart:69:75)
#1      _rootRunUnary (dart:async/zone.dart:1198:47)
#2      _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#3      _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
#4      Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
#5      Future._propagateToListeners (dart:async/future_impl.dart:725:32)
#6      Future._complete (dart:async/future_impl.dart:519:7)
#7      new Future.delayed.<anonymous closure> (dart:async/future.dart:323:16)
#8      _rootRun (dart:async/zone.dart:1182:47)
#9      _CustomZone.run (dart:async/zone.dart:1093:19)
#10     _CustomZone.runGuarded (dart:async/zone.dart:997:7)
#11     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1037:23)
#12     _rootRun (dart:async/zone.dart:1190:13)
#13     _Custom<…>

Expected result:
The exception should be caught.

@fzyzcjy thanks for raising this, See: https://docs.sentry.io/platforms/dart/usage/advanced-usage/#tips-for-catching-errors

Use a catchError block for Futures

https://github.com/getsentry/sentry-dart/blob/main/flutter/example/lib/main.dart#L96-L98
This is how the uncaught Dart/Flutter errors work, unfortunately.

@fzyzcjy thanks for raising this, See: https://docs.sentry.io/platforms/dart/usage/advanced-usage/#tips-for-catching-errors

Use a catchError block for Futures

https://github.com/getsentry/sentry-dart/blob/main/flutter/example/lib/main.dart#L96-L98
This is how the uncaught Dart/Flutter errors work, unfortunately.

Hmm so you mean this is impossible to be caught globally? :(

Hmm so you mean this is impossible to be caught globally? :(

From my experience this should be caught by zone error handler in RunZonedGuardedIntegration, or am missing something?

From my experience this should be caught by zone error handler in RunZonedGuardedIntegration, or am missing something?

From my experience this should be caught by zone error handler in RunZonedGuardedIntegration, or am missing something?

I think so too.
The docs suggests that it should work.

From my experience this should be caught by zone error handler in RunZonedGuardedIntegration, or am missing something?

I think so too.
The docs suggests that it should work.

@kuhnroyal @ueman I also think so. But after experiment (with adding several lines to the official example code), I see those stacktraces, indicating it does not :(

@kuhnroyal @ueman I also think so. But after experiment (with adding several lines to the official example code), I see those stacktraces, indicating it does not :(

we are only able to add an error handler to the current Isolate, which is the "main thread", the Futures have its own Zone/Isolates iirc and you'd need to catch yourself.
I might be wrong, but that's what I experienced when testing it out, also I found similar issues on the Flutter repo.
The official example also has a RunZonedGuarded and they still do catchError.

we are only able to add an error handler to the current Isolate, which is the "main thread", the Futures have its own Zone/Isolates iirc and you'd need to catch yourself.
I might be wrong, but that's what I experienced when testing it out, also I found similar issues on the Flutter repo.
The official example also has a RunZonedGuarded and they still do catchError.

Then something is wrong, with 3.0.0 I have a manual zone guard and it triggers.

Then something is wrong, with 3.0.0 I have a manual zone guard and it triggers.

Then something is wrong, with 3.0.0 I have a manual zone guard and it triggers.

@kuhnroyal with a Future.delayed or microtask?

Then something is wrong, with 3.0.0 I have a manual zone guard and it triggers.

@kuhnroyal with a Future.delayed or microtask?

I just tried this and it gets captures:
                  ListTile(
                    title: const Text('Send delayed Flutter error to Sentry'),
                    onTap: () {
                      Future.delayed(Duration(seconds: 2), () {
                        throw ArgumentError('delayed');
                      });
                      // _logger.severe('Flutter sample error', ArgumentError('dummy'));
                    },
                  ),

However I am using Chain.capture() from https://pub.dev/packages/stack_trace instead.

I just tried this and it gets captures:
                  ListTile(
                    title: const Text('Send delayed Flutter error to Sentry'),
                    onTap: () {
                      Future.delayed(Duration(seconds: 2), () {
                        throw ArgumentError('delayed');
                      });
                      // _logger.severe('Flutter sample error', ArgumentError('dummy'));
                    },
                  ),

However I am using Chain.capture() from https://pub.dev/packages/stack_trace instead.

@kuhnroyal So could you reproduce my sample, or does my sample behave differently in your machine

No, I need to clarify:
My first test was with version 3.0.1 and it gets captured in the zone error handler.
My second test was with plain Dart and it also gets captured in the zone error handler.
This leads me to the conclusion that something with the zone setup is broken in 4.x

No, I need to clarify:
My first test was with version 3.0.1 and it gets captured in the zone error handler.
My second test was with plain Dart and it also gets captured in the zone error handler.
This leads me to the conclusion that something with the zone setup is broken in 4.x

@kuhnroyal No custom integrations. I do nothing but:

clone this github repo
go into the example folder. edit the code as I have shown in my question
run it

@kuhnroyal No custom integrations. I do nothing but:

clone this github repo
go into the example folder. edit the code as I have shown in my question
run it

My second test was with plain Dart and it also gets captured in the zone error handler.

I think that's the difference, when there's Flutter onError involved etc.
I will try to test once more or see if there's any workaround, but I do remember testing this out and it never got triggered when there was runZonedGuarded, Flutter onError and Futures.

My second test was with plain Dart and it also gets captured in the zone error handler.

I think that's the difference, when there's Flutter onError involved etc.
I will try to test once more or see if there's any workaround, but I do remember testing this out and it never got triggered when there was runZonedGuarded, Flutter onError and Futures.

I have used this with 3.0.1 for a long time and it always works, the linked issue is new to me, never experienced this.
main() {
    Flutter.onError = (FlutterErrorDetails details) async {
        ...
    }

    if (!kIsWeb) {
       Isolate.current.addErrorListener(RawReceivePort((dynamic pair) async {
            ....
      }).sendPort);
    }

    runZonedGuarded(() {
        WidgetsFlutterBinding.ensureInitialized();
        runApp(MyApp());
    }, (error, _) {
      ...
    });
}

From some comments there, it seems that the order of WidgetsFlutterBinding.ensureInitialized(); matters.

I have used this with 3.0.1 for a long time and it always works, the linked issue is new to me, never experienced this.
main() {
    Flutter.onError = (FlutterErrorDetails details) async {
        ...
    }

    if (!kIsWeb) {
       Isolate.current.addErrorListener(RawReceivePort((dynamic pair) async {
            ....
      }).sendPort);
    }

    runZonedGuarded(() {
        WidgetsFlutterBinding.ensureInitialized();
        runApp(MyApp());
    }, (error, _) {
      ...
    });
}

From some comments there, it seems that the order of WidgetsFlutterBinding.ensureInitialized(); matters.

WidgetsFlutterBinding.ensureInitialized(); should be called in advance, because we need the bindings initialized in order to read the release version and other things from the Native SDKs.
Will run some tests.

WidgetsFlutterBinding.ensureInitialized(); should be called in advance, because we need the bindings initialized in order to read the release version and other things from the Native SDKs.
Will run some tests.

I can confirm that if I add WidgetsFlutterBinding.ensureInitialized(); inside of the runZonedGuarded it works, but, WidgetsFlutterBinding.ensureInitialized(); can't be called before that, otherwise, it doesn't work either.
The thing is, as stated above https://github.com/getsentry/sentry-dart/issues/263#issuecomment-755940675 we do need to call ensureInitialized so not sure how the solution would be, my first idea would be to really wrap the whole SDK init. in a runZonedGuarded but this looks wrong.
I also came up with this test after reading https://github.com/flutter/flutter/issues/48972
I will try to research a bit more.

I can confirm that if I add WidgetsFlutterBinding.ensureInitialized(); inside of the runZonedGuarded it works, but, WidgetsFlutterBinding.ensureInitialized(); can't be called before that, otherwise, it doesn't work either.
The thing is, as stated above https://github.com/getsentry/sentry-dart/issues/263#issuecomment-755940675 we do need to call ensureInitialized so not sure how the solution would be, my first idea would be to really wrap the whole SDK init. in a runZonedGuarded but this looks wrong.
I also came up with this test after reading https://github.com/flutter/flutter/issues/48972
I will try to research a bit more.

Basically, if the RunZonedGuardedIntegration (or a custom zone integration) is used, most other integrations have to be started from inside this one.

Basically, if the RunZonedGuardedIntegration (or a custom zone integration) is used, most other integrations have to be started from inside this one.

Basically, if the RunZonedGuardedIntegration (or a custom zone integration) is used, most other integrations have to be started from inside this one.

it's not that simple, it'd still falls to:

we'd kill the option that people would like to have their own runZonedGuarded

Basically, if the RunZonedGuardedIntegration (or a custom zone integration) is used, most other integrations have to be started from inside this one.

it's not that simple, it'd still falls to:

we'd kill the option that people would like to have their own runZonedGuarded

Yea thats why I said  (or a custom zone integration) :) I use one myself.
Could be flagged somehow or be of a specific type.

Yea thats why I said  (or a custom zone integration) :) I use one myself.
Could be flagged somehow or be of a specific type.

a workaround for now, would be to do something like:
Future<void> main() async {
  runZonedGuarded(() async {
    // init the SDK inside of your own runZonedGuarded, so
    // WidgetsFlutterBinding.ensureInitialized() gets called inside of the runZonedGuarded.
    await SentryFlutter.init(
      (options) {
        options.dsn = _exampleDsn;
        options.useNativeBreadcrumbTracking();
      },
    );

    // run your own App, usually done by the 'appRunner' Sentry callback.
    // do not use the 'appRunner'
    runApp(MyApp());
  }, (exception, stackTrace) async {
    // mimics RunZonedGuardedIntegration capture method
    final mechanism = Mechanism(type: 'runZonedGuarded', handled: true);
    final throwableMechanism = ThrowableMechanism(mechanism, exception);

    final event = SentryEvent(
      throwable: throwableMechanism,
      level: SentryLevel.fatal,
    );

    await Sentry.captureEvent(event, stackTrace: stackTrace);
  });
}

a workaround for now, would be to do something like:
Future<void> main() async {
  runZonedGuarded(() async {
    // init the SDK inside of your own runZonedGuarded, so
    // WidgetsFlutterBinding.ensureInitialized() gets called inside of the runZonedGuarded.
    await SentryFlutter.init(
      (options) {
        options.dsn = _exampleDsn;
        options.useNativeBreadcrumbTracking();
      },
    );

    // run your own App, usually done by the 'appRunner' Sentry callback.
    // do not use the 'appRunner'
    runApp(MyApp());
  }, (exception, stackTrace) async {
    // mimics RunZonedGuardedIntegration capture method
    final mechanism = Mechanism(type: 'runZonedGuarded', handled: true);
    final throwableMechanism = ThrowableMechanism(mechanism, exception);

    final event = SentryEvent(
      throwable: throwableMechanism,
      level: SentryLevel.fatal,
    );

    await Sentry.captureEvent(event, stackTrace: stackTrace);
  });
}

TLDR:
WidgetsFlutterBinding.ensureInitialized() is the 1st thing to be run when SentryFlutter.init is called.
RunZonedGuardedIntegration has its own runZonedGuarded which executes the AppRunner callback, this is the last integration to be run, after the SDK is fully initialized.
This causes issues as described above, eg Futures are not going thru the uncaught handler from runZonedGuarded.

TLDR:
WidgetsFlutterBinding.ensureInitialized() is the 1st thing to be run when SentryFlutter.init is called.
RunZonedGuardedIntegration has its own runZonedGuarded which executes the AppRunner callback, this is the last integration to be run, after the SDK is fully initialized.
This causes issues as described above, eg Futures are not going thru the uncaught handler from runZonedGuarded.

Maybe it's worth taking a look how the following packages handled this problem:

https://pub.dev/packages/firebase_crashlytics
https://pub.dev/packages/flutter_sentry (not sentry_flutter!)
https://pub.dev/packages/catcher

Maybe it's worth taking a look how the following packages handled this problem:

https://pub.dev/packages/firebase_crashlytics
https://pub.dev/packages/flutter_sentry (not sentry_flutter!)
https://pub.dev/packages/catcher

Well the problem stems from the way integrations are handled, that is pretty unique to this package.
After thinking on this for a while I only see one way unless the Flutter issues get magically solved.

add a dedicated mixin/superclass for RunZonedGuardedIntegration (to allow custom subclasses)
assert only one of this type is added and if there is none add a NoZonedGuardedIntegration
decouple RunZonedGuardedIntegration from appRunner
run the RunZonedGuardedIntegration/NoZonedGuardedIntegration before anything else, call WidgetsFlutterBinding.ensureInitialized() and run all other integration from within
add a new AppRunnerIntegration that is always run last (maybe also allowing custom subclasses)

Well the problem stems from the way integrations are handled, that is pretty unique to this package.
After thinking on this for a while I only see one way unless the Flutter issues get magically solved.

add a dedicated mixin/superclass for RunZonedGuardedIntegration (to allow custom subclasses)
assert only one of this type is added and if there is none add a NoZonedGuardedIntegration
decouple RunZonedGuardedIntegration from appRunner
run the RunZonedGuardedIntegration/NoZonedGuardedIntegration before anything else, call WidgetsFlutterBinding.ensureInitialized() and run all other integration from within
add a new AppRunnerIntegration that is always run last (maybe also allowing custom subclasses)

Hi friends, is there any plan of fixing this in this package? This is kind of serious problem :( Today I find my production environment has some exceptions but not caught and not sent to sentry due to this problem.

Hi friends, is there any plan of fixing this in this package? This is kind of serious problem :( Today I find my production environment has some exceptions but not caught and not sent to sentry due to this problem.

We'll prioritize a fix for this, but until we get around shipping a new version with a fix, please refer to the work around @marandaneto wrote above:
https://github.com/getsentry/sentry-dart/issues/263#issuecomment-756090046

We'll prioritize a fix for this, but until we get around shipping a new version with a fix, please refer to the work around @marandaneto wrote above:
https://github.com/getsentry/sentry-dart/issues/263#issuecomment-756090046

Oh my god, I just wasted hours on this. For me the issue was that errors thrown in functions called by webview_flutter weren't being caught. Once I finally figured out what the issue was, I ended up creating a fix similar to #263, which works in my case too.

 For me the issue was that errors thrown in functions called by webview_flutter weren't being caught. Once I finally figured out what the issue was, I ended up creating a fix similar to #263, which works in my case too.

 For me the issue was that errors thrown in functions called by webview_flutter weren't being caught. Once I finally figured out what the issue was, I ended up creating a fix similar to the comment above, which works in my case too.

I'm sorry about that.
we'll be looking into it shortly, the workaround works but it should be fixed definitely. trying to ramp up someone on it this week or next week latest, I'm taking care of a few other things atm.

Oh my god, I just wasted hours on this. For me the issue was that errors thrown in functions called by webview_flutter weren't being caught. Once I finally figured out what the issue was, I ended up creating a fix similar to the comment above, which works in my case too.

I'm sorry about that.
we'll be looking into it shortly, the workaround works but it should be fixed definitely. trying to ramp up someone on it this week or next week latest, I'm taking care of a few other things atm.

I'm sorry about that.
we'll be looking into it shortly, the workaround works but it should be fixed definitely. trying to ramp up someone on it this week or next week latest, I'm taking care of a few other things atm.

No worries, I didn't mean to blame you guys, I appreciate this new flutter library. I was just a bit frustrated ;) Thanks for looking into it!

I'm sorry about that.
we'll be looking into it shortly, the workaround works but it should be fixed definitely. trying to ramp up someone on it this week or next week latest, I'm taking care of a few other things atm.

No worries, I didn't mean to blame you guys, I appreciate this new flutter library. I was just a bit frustrated ;) Thanks for looking into it!

sure, thanks for the support :)

sure, thanks for the support :)

The issue is fixed, sorry for taking so long, thanks once more @denrase
See the code snippets using Sentry's 'runZoneGuarded' integration and a custom 'runZonedGuarded'.
With Sentry's 'runZoneGuarded' integration, that's all you need to do:
Future<void> main() async {
  await SentryFlutter.init(
    (options) {
      options.dsn = _exampleDsn;
    },
    // Init your App.
    appRunner: () => runApp(MyApp()),
  );
}

Without Sentry's 'runZoneGuarded' integration, you need to init. Sentry within your custom 'runZonedGuarded'
Future<void> main() async {
  runZonedGuarded(() async {
    // Sentry should be init. within the 'runZonedGuarded' that 'runApp' is run,
    // so WidgetsFlutterBinding.ensureInitialized() is called correctly.
    // See here that we don't pass the 'appRunner' arg, so you must run 'runApp' yourself.
    await SentryFlutter.init(
      (options) {
        options.dsn = _exampleDsn;
      },
    );

    runApp(MyApp());
  }, (exception, stackTrace) async {
    await Sentry.captureException(exception, stackTrace: stackTrace);
  });
}

In both cases, Future errors will be caught automatically.
I'll be releasing a version shortly

The issue is fixed, sorry for taking so long, thanks once more @denrase
See the code snippets using Sentry's 'runZoneGuarded' integration and a custom 'runZonedGuarded'.
With Sentry's 'runZoneGuarded' integration, that's all you need to do:
Future<void> main() async {
  await SentryFlutter.init(
    (options) {
      options.dsn = _exampleDsn;
    },
    // Init your App.
    appRunner: () => runApp(MyApp()),
  );
}

Without Sentry's 'runZoneGuarded' integration, you need to init. Sentry within your custom 'runZonedGuarded'
Future<void> main() async {
  runZonedGuarded(() async {
    // Sentry should be init. within the 'runZonedGuarded' that 'runApp' is run,
    // so WidgetsFlutterBinding.ensureInitialized() is called correctly.
    // See here that we don't pass the 'appRunner' arg, so you must run 'runApp' yourself.
    await SentryFlutter.init(
      (options) {
        options.dsn = _exampleDsn;
      },
    );

    runApp(MyApp());
  }, (exception, stackTrace) async {
    await Sentry.captureException(exception, stackTrace: stackTrace);
  });
}

In both cases, Future errors will be caught automatically.
I'll be releasing a version shortly

https://github.com/getsentry/sentry-dart/releases/tag/4.0.4

https://github.com/getsentry/sentry-dart/releases/tag/4.0.4


Cert manager suddenly a dependency???

Pre-requisites

[X] I have double-checked my configuration
[X] I can confirm the issues exists when I tested with :latest
[ ] I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?
The following pull request #9423 added a mandatory cert manager dependency to the manifests. This is not documented anywhere beyond a new line in the readme to install cert manager and quite frankly caught myself by surprise that a minor version upgrade could introduce breaking changes and new dependencies in the cluster.
If this is intentional and necessary then I think some better documentation and a mention of breaking changes/new dependencies could be added to the change log and upgrade guide, not just the readme.
Version
latest
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
Not relevant

Logs from the workflow controller
Not relevant
Logs from in your workflow's wait container
Not relevant

@chtcvl  Can you fix this issue?

Sure, which approach is better:

Update documentation and provide additional manifests that don't require cert-manager (and disable TLS).
Update manifests to use something like https://github.com/jet/kube-webhook-certgen and remove cert-manager dependency at all

This fix for this is to revert 7e40d93. @chtcvl  will need to raise a new PR that does not add cert manager.
@allemp would you like to submit a PR to revert?

I am going to revert it now since our customers are affected by this change and this is a blocker for upgrading: https://github.com/argoproj/argo-workflows/pull/9756


Always says "Waiting for video track" / "Waiting for video track" on agents-playground.livekit.io

Describe the bug
I always see "Waiting for video track" / "Waiting for video track" on agents-playground.livekit.io

Reproduction

Go to agents-playground.livekit.io and join a room.
Create a token for another participant and join elsewhere (e.g. using ).

The playground page will continue "Waiting for video track", "Waiting for video track" however the tracks published in the playground will appear in the participant.
Verify by adding another participant outside of the playground. They see each other's tracks but not playground does not.
Logs
No response
System Info
agents-playground.livekit.io on August 21 2024.

Severity
annoyance
Additional Information
No response

same issue

when you create a token make sure agent: true.

Because in agents-playground will check if agent == true this will show media if not they won't display anything.


Should we rename List.of(Iterable) and List.of(java.util.List) methods to List.from(...)?

Today I run in an issue when writing List.of(Maybe.Just(42)), which didn't trigger the vararg-method, but the List.of(Iterable) version, as Maybe is an Iterable.
So I would be inclined to rename List.of(Iterable) and List.of(java.util.List) to something else, e.g. List.from(...) to avoid such surprises.
What do you think?

I agree. FunctionalJava 4.4 had the same issue. The moment they added List.list(Iterable), List.join(List.list(...)) broke in existing code for some use cases.
Maybe List.fromIterable(...).

Done


🐛 [bug] Cooldown invalid.

Needless to say, create an Ability, then set the cooldown, which will be reactivated if I call activate () .

Like "
https://github.com/OctoD/godot-gameplay-systems/blob/main/docs/ability-system.md"
said.
(I'm just following the documentation)
I created a script that creates an extension class Ability.
And wrote the activate() method.
Then I set its cooldown to 3.0 in the inspector.
When I tried calling activate() multiple times, it took effect, completely
ignoring the 3.0 cooldown I had set.
Would appreciate it if you could look into this.
OctoD @.***> 于2023年10月16日周一 20:58写道：

Hello thank you for reporting.
May I ask you to write something to reproduce the behaviour and understand
what do you expect against what you get?
Thank you.
A small repo would help a lot.
—
Reply to this email directly, view it on GitHub
https://github.com/OctoD/godot-gameplay-systems/issues/43#issuecomment-1764433417,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANFXJBDTKWRY3JTZOLOMNPTX7UVRDAVCNFSM6AAAAAA6A45EY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRUGQZTGNBRG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

Did you try to add a tag to Cooldown Start and To Remove On Cooldown End ability properties?
(If you are creating the ability programmatically these properties can be set by code as tags_cooldown_start andtags_to_remove_on_cooldown_end.
This part is actually missing from the docs, maybe this should fix the issue.
You can see them in action in res://examples/simple_2d_platformer/player/player.tscn, clicking on the AbilityContainer node and then browsing the assigned abilities.
Thank you!

ok, thanks.


feat!: Update eslint-plugin-jsdoc version

What changed / motivation ?

To support ESLint v9, we must update eslint-plugin-jsdoc to v46.10.0 higher.
Linked PR / Issues

https://github.com/moneyforward/frontend-forward/issues/206

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Chore (routine task, maintenance, or non-functional change that doesn't modify src or test files)

Pre-flight checklist

[x] I have read the Contributing Guidelines
[x] Performed a self-review of my code

References

Although the snapshot test is failing on CI, the snapshot is actually updated, so please ignore this CI error 🙏


Support for Windows Authentication

I am in the understanding that windows auth is not supported in wcf docker images. This would be extremely valuable to have this supported.

You are right, @gidich. This is a limitation of Windows container.

Is this going to work with gMSA feature?

@sowsan I don't see why not although we haven't had a chance to verify it


Remove netcore50

@victorhurdugaci
(The latest CLI almost worked...)

Oh, nice. I also have a local change that does the same :)

Is this building with the current CLI or does it need the latest?

@victorhurdugaci Running now. So far, so good.

Passed locally.

Btw, you might have to start from the top of the stack with this change because other repos that depend on this one have netcore50

other than that :shipit:


Authentication issue - Firewalls blocking login

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Storage Explorer Version
1.34.0
Regression From
No response
Architecture
x64
Storage Explorer Build Number
20240523.2
Platform
All
OS Version
Windows 10
Bug Description
Hi Team,
I'm getting below error while login in storage account.
This storage account's 'Firewalls & virtual networks' settings may be blocking access to storage services. Try adding your client IP address to the firewall exceptions, or by allowing access from 'all networks' instead of 'selected networks'. To learn more about Azure Storage firewalls and virtual networks, visit http://go.microsoft.com/fwlink/?LinkId=845443.
Steps to Reproduce
Login storage account
Actual Experience
Unable to use storage explore due to firewall blocking my access
Expected Experience
please assist in adding my ip address to Firewall
Additional Context
This request is not authorized to perform this operation.
This storage account's 'Firewalls & virtual networks' settings may be blocking access to storage services. Try adding your client IP address to the firewall exceptions, or by allowing access from 'all networks' instead of 'selected networks'. To learn more about Azure Storage firewalls and virtual networks, visit http://go.microsoft.com/fwlink/?LinkId=845443.

As the error suggests, your access may be blocked due to firewall settings on the storage account. Do you know if public network access to your storage resource is restricted in any way? You may need to communicate with your administrator to grant your machine access.

Closing due to inactivity. If this is a still a problem, please leave a comment with updated information, and we can revist.


Upload files

I am still new...  Where should I store the users' uploaded files? Have you guys done something similar to process users' uploaded files?

Lisa has done this. When using the app, go to the /share tab, then you'll see the first screenshot below. Click on a green button that's attached to a resource description and you'll be taken to the second screenshot where you can upload files to the virtual watershed.
Please get in touch with Lisa if you need more info on how this works.


List complete?

Is this list supposed to be complete?  Dell is listing their UC350 headset as Skype for Business Certified at https://www.dell.com/en-us/work/shop/dell-pro-stereo-headset-uc350-skype-for-business/apd/750-aavm/pc-accessories
I'm looking for options, but don't want to narrow the vendor selection further than necessary if there is other legitimate hardware to consider.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b63af828-0b5a-ba28-7fa6-0016b0b9a355
Version Independent ID: 0e7b881f-f4bd-94b9-cefc-0bcc2040a7c1
Content: Phones and Devices for Skype for Business
Content Source: Skype/SfbPartnerCertification/certification/devices-usb-devices.md
Service: skype-for-business
GitHub Login: @jambirk
Microsoft Alias: jambirk

My understanding is that this list should be complete and up to date. @dougand-MSFT can you provide more information here?

the list is updated periodically, so the most recently certified devices may not be listed.  In general the best place to look first is: https://products.office.com/en-us/microsoft-teams/across-devices/devices
that site is more curated so will have the most information about devices, though it may not have all devices (especially older ones).

@dougand-MSFT  Thank you very much for the contribution and sharing this explanation. @itthing
Hope this comment is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Azure in Open?

Does "Monetary commitment" or "Monetary credit" equal to "Azure in Open"?
Not sure whether Azure Resource Usage & RateCard API are supported for Azure in Open.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5a56e729-7981-9a51-9c5c-00ea13a8d888
Version Independent ID: 01fb14e5-e8a4-49e0-5908-b6069566a8de
Content: Azure Billing APIs
Content Source: articles/billing/billing-usage-rate-card-overview.md
Service: billing
GitHub Login: @tonguyen
Microsoft Alias: mobandyo

@pinyuko Thanks for the Comment. We are actively investigating and will get back to you soon.

@pinyuko  close this issue for now. If there are further questions regarding this matter, please reply to and we will gladly continue the discussion.


Kupo response does not contain collateral return output

AlwaysFails Ada Collateral Return and AlwaysFails Native Asset Collateral Return Plutip tests fail after replacing Ogmios with Kupo for getWalletBalance. In these tests we submit a transaction that attempts to spend a Value from AlwaysFails script so that the total collateral is consumed and collateral return is returned back to the wallet. We then check the balance difference.
Kupo response doesn't contain the expected collateral return output, which results in an incorrect balance difference. This doesn't seem to be a synchronisation issue, since this behaviour is also reproducible when adding a delay before requesting utxos and making Kupo connect to Ogmios.

@KtorZ Thank you, it's working now!


Selected folder when exporting Private Keys or Backup

When Clicking on Wallet -> Backup or Wallet -> Export private keys I get a FolderChooser to select where I want to store the file. The selected location is then completely ignored and the file is stored in %userdir%.
Luckily theres a message that tells you the actually used folder but it would be nice to either remove the FolderChooser or save files in the selected folder.
System: Win10 Pro 64 bit
Software: 1.1.0_1.2

the error should be that you need to specify -exportdir argument.
you can instead run for example:
zcash-cli dumpwallet "C:\PathTo\Backup\keys.txt"


Removed unneeded supports_combined_alters feature flag on Oracle.

supports_combined_alters is False by default:
https://github.com/django/django/blob/ddf321479b0e006bc4efafe57726d54869f38c14/django/db/backends/base/features.py#L168-L169

Thanks both for checking :+1:


Allow other input values than a 6-DOF controller for ManipulationHandler

Describe the problem
The ManipulationHandler directly reads from the Pointer that's activated it, which means it expects that to be a 6-DOF device.
With mobile devices or the Oculus Go controller, this is not the case, we lack information to perform the same movements.
Describe the solution you'd like
Maybe the ability to add a component next to ManipulationHandler that is responsible for providing the 6-DOF values.
This way they can be customized and calculated the way we want.
Describe alternatives you've considered
Talking Oculus Go here, and since I'm currently only clashing with the controller visualizer, I could configure IT to listen to a pacific InputAction, while manually adding z values based on the touch controller for the regular execution path.
This would however mean that as soon some other service is interested in the controller position, it'll move back and forth.
Additional context
The Oculus Go controller lacks translation. It rotates about the elbow of the user, with an offset but that's about it. Pushing or pulling is not one of its capabilities

Hi @Alexees, since Oculus Go is not supported I'll be closing this issue.


hygieia-jenkins-plugin build fails

when I am trying to build this plug-in gives me a build failure message. i tried changing the snapshot from 1.3 to 1.4. gives me same error message. need assistance please.
INFO] Building Hygieia Publisher Plugin 1.4-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2.540 s
[INFO] Finished at: 2016-09-12T20:09:42-04:00
[INFO] Final Memory: 19M/225M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project hygieia-publisher: Could not resolve dependencies for project org.jenkins-ci.plugins:hygieia-publisher:hpi:1.4-SNAPSHOT: Failed to collect dependencies at com.capitalone.dashboard:core:jar:2.0.2-SNAPSHOT: Failed to read artifact descriptor for com.capitalone.dashboard:core:jar:2.0.2-SNAPSHOT: Failure to find com.capitalone.dashboard:Hygieia:pom:2.0.2-SNAPSHOT in http://repo.jenkins-ci.org/public/ was cached in the local repository, resolution will not be reattempted until the update interval of repo.jenkins-ci.org has elapsed or updates are forced -> [Help 1]

Failing because of Core 2.0.2 - this is already published in maven central!! Will check again.
Try "mvn clean install" on the root Hygieia project and then build this plugin. That should work.

it worked!!! thanks


Font scale/blurriness after connecting external display

Environment:

VSCode Version: 1.13.0
OS Version: Windows 8.1 Pro on MacBook Pro
Native resolution: 2880 x 1880
Windows DPI scaling: 125% (with "Let me choose one size for all my displays" ticked)

Steps to Reproduce:

VS code running on laptop screen: Text looks crisp
Plug in external monitor (2560 x 1440)
VS Code moves to external monitor display
Font display in VS Code becomes blurry / pixelated

Work-around:

Restart VS Code, and correct font-rendering is restored.

https://github.com/Microsoft/vscode/issues/6196


Installation failed

Using cargo build from the latest package on centos version 8.60
I have previously install ipfs and postsql.
Trying to compile the "migrations_macro" dependency in a Rust project throws the error "ld: cannot find -lpq"

Hello.
I suffered such error on Debian 5.10.
in debian
sudo apt-get install libpq-dev
in Centos
yum install libpq-dev
I think it will works.

Closing as a solution that seems correct has been provided. Please re-open if there is still a problem.

Closing as a solution that seems correct has been provided. Please re-open if there is still a problem.


Fixed 3 typos in README.es

Thanks for taking the time to contribute this localization pull request. However, we are not able to accept contributions to this historical reference repository at this time.


Add day/night dynamic theme changes

Added functionality to change the background of the earth and sky when time is past the sunset time.
Satisfies requests 3 and 4 of #14 .

It is possible to achieve this using theming only, I believe.


Add support for reading SVG images

jimp, which is used to read the images doesn't support SVGs. Implement a solution that accepts SVGs and outputs PNGs.
Alternatives:

Migrate to Sharp (https://www.npmjs.com/package/sharp), as it has SVG support. It does depend on native libraries though. We did move from Sharp to jimp in the past #16  to avoid native dependencies (also, takes longer to install the package). https://www.npmjs.com/package/@types/sharp can be used for Typescript types.
Use https://www.npmjs.com/package/svg2img for SVGs only. Depends on canvas, which also has native library dependencies.

Fixed the issue

https://github.com/chenlevy24/bubblewrap/pull/new/SvgIcons

Closed via #193

Re-opening this since we're reverting the move to sharp (See #259). We'll investigate SVG alternatives (#260).

closed by https://github.com/GoogleChromeLabs/bubblewrap/pull/341


Merge refs/heads/feature/refactor-datasources into alpha

Merge refs/heads/feature/refactor-datasources into alpha

This PR has been merged into alpha and tagged as 2.0.0-alpha-202308241118. Thanks for your contribution!


baseurl not added to asset fetch URLs

In my first attempt to set up a test page for this plugin, I tried to do it in a subfolder of my current website. So I put this in my _config.yml
baseurl: "/etc/testing-jekyll-cloudinary" # the subpath of your site, e.g. /blog
url: "http://ericportis.com" # the base hostname & protocol for your site

When I built, the plugin turned this tag:
{% cloudinary /assets/test.png alt="beautiful!" %}

into Cloudinary fetch URLs that looked like this:
https://res.cloudinary.com/eric-cloudinary/image/fetch/c_scale,w_1386,q_auto,f_auto/http://ericportis.com/assets/test.png

But the image didn’t live at http://ericportis.com/assets/test.png, it was at http://ericportis.com/etc/testing-jekyll-cloudinary/assets/test.png
Can/should the baseurl be added between the “ericportis.com” and the ”/assets”, there? Without it, I couldn't figure out a way to make this plugin work on a site in a subfolder.

You're right, I should add baseurl

Fixed


Disable content-type validation in nexus

@sabre1041 @nasx please take a look. It disables the content validation for all repositories.

@jordigilh sorry I saw this issue yesterday when I was testing out the new deployment and resolved it in a separate PR that was merged. Closing this one out.


Delete image function

Can you provide the delete function？It's so inconvenience

Check this https://github.com/mwaterfall/MWPhotoBrowser/issues/466


Step data types

This simplifies how we are returning typed data back into the step definitions, using generics. It also adds the ability to return Double and Bool types, and the ability to return a mixture of types.

@kerrmarin I didn't think there were any breaking changes?

Hey @nap-sam-dean, StepDefiner.swift has changed open method signatures so if someone has overridden them in their own implementation this would break? ¯_(ツ)_/¯

@kerrmarin Ah, valid point. I'll add something in the release notes when we release :)


MVP: Implement ML model trainer for threat detection based on YOLO

Tasks

Decide the YOLO version
Finalize the data annotation format.
Create a training dataset
Implement the model trainer

YoloV8 was selected as the final model.
Ultralytics YOLO format was finalized as the data annotation format.
The following 2 datasets are used for initial model
a. Gun Detection V1 dataset (~300 datapoints)
b. Weapon 2 dataset (~ 3900 datapoints)


 It failed due to DNS not being available
To Reproduce
nixos-rebuild switch
updating GRUB 2 menu...
installing the GRUB 2 boot loader on /dev/vda...
Installing for i386-pc platform.
Installation finished. No error reported.
stopping the following units: acme-arianvp.me.timer, acme-techstock.photos.timer, audit.service, bitwarden_rs.service, grafana.service, kmod-static-nodes.service, network-local-commands.service, network-setup.service, nscd.service, prometheus-node-exporter.service, prometheus.service, systemd-binfmt.service, systemd-machined.service, systemd-modules-load.service, systemd-networkd-wait-online.service, systemd-networkd.service<EMAIL_ADDRESS><EMAIL_ADDRESS>systemd-resolved.service, systemd-sysctl.service, systemd-timesyncd.service, systemd-tmpfiles-clean.timer, systemd-tmpfiles-setup-dev.service, systemd-udev-trigger.service, systemd-udevd-control.socket, systemd-udevd-kernel.socket, systemd-udevd.service, weechat.service
NOT restarting the following changed units<EMAIL_ADDRESS><EMAIL_ADDRESS>systemd-journal-flush.service, systemd-logind.service, systemd-random-seed.service, systemd-remount-fs.service, systemd-tmpfiles-setup.service, systemd-udev-settle.service, systemd-update-utmp.service, systemd-user-sessions.service<EMAIL_ADDRESS><EMAIL_ADDRESS>activating the configuration...
setting up /etc...
removing obsolete symlink ‘/etc/pam.d/cups’...
removing obsolete symlink ‘/etc/pam.d/ftp’...
restarting systemd...
reloading user units for root...
setting up tmpfiles
reloading the following units: dbus.service, dev-hugepages.mount, dev-mqueue.mount, firewall.service, sys-kernel-debug.mount
restarting the following units: nginx.service, sshd.service, systemd-journald.service
starting the following units: acme-arianvp.me.timer, acme-techstock.photos.timer, audit.service, bitwarden_rs.service, grafana.service, kmod-static-nodes.service, network-local-commands.service, network-setup.service, nscd.service, prometheus-node-exporter.service, prometheus.service, systemd-binfmt.service, systemd-machined.service, systemd-modules-load.service, systemd-networkd-wait-online.service, systemd-networkd.service<EMAIL_ADDRESS><EMAIL_ADDRESS>systemd-resolved.service, systemd-sysctl.service, systemd-timesyncd.service, systemd-tmpfiles-clean.timer, systemd-tmpfiles-setup-dev.service, systemd-udev-trigger.service, systemd-udevd-control.socket, systemd-udevd-kernel.socket, weechat.service
warning: the following units failed: acme-arianvp.me.service, acme-techstock.photos.service

● acme-techstock.photos.service - Renew ACME Certificate for techstock.photos
   Loaded: loaded (/nix/store/5jy70nlaasq8kza150ksnmwpagml2cwp-unit-acme-techstock.photos.service/acme-techstock.photos.service; enabled; vendor preset: enabled)
   Active: failed (Result: exit-code) since Wed 2020-04-22 19:04:17 CEST; 1s ago
  Process: 23832 ExecStart=/nix/store/5idg7qnmvh9xiklfwml7d65sdwnxp78i-acme-start (code=exited, status=1/FAILURE)
 Main PID: 23832 (code=exited, status=1/FAILURE)
       IP: 0B in, 0B out
      CPU: 50ms

Apr 22 19:04:17 arianvp.me systemd[1]: Starting Renew ACME Certificate for techstock.photos...
Apr 22 19:04:17 arianvp.me 5idg7qnmvh9xiklfwml7d65sdwnxp78i-acme-start[23832]: 2020/04/22 19:04:17 Could not create client: get directory at 'https://acme-v02.api.letsencrypt.org/directory': Get "https://acme-v02.api.letsencrypt.org/directory": dial tcp: lookup acme-v02.api.letsencrypt.org: no such host
Apr 22 19:04:17 arianvp.me 5idg7qnmvh9xiklfwml7d65sdwnxp78i-acme-start[23832]: 2020/04/22 19:04:17 Could not create client: get directory at 'https://acme-v02.api.letsencrypt.org/directory': Get "https://acme-v02.api.letsencrypt.org/directory": dial tcp: lookup acme-v02.api.letsencrypt.org: no such host
Apr 22 19:04:17 arianvp.me systemd[1]: acme-techstock.photos.service: Main process exited, code=exited, status=1/FAILURE
Apr 22 19:04:17 arianvp.me systemd[1]: acme-techstock.photos.service: Failed with result 'exit-code'.
Apr 22 19:04:17 arianvp.me systemd[1]: Failed to start Renew ACME Certificate for techstock.photos.

● acme-arianvp.me.service - Renew ACME Certificate for arianvp.me
   Loaded: loaded (/nix/store/1qsrigif18i8m5nqppjynya3zdkdd3xm-unit-acme-arianvp.me.service/acme-arianvp.me.service; enabled; vendor preset: enabled)
   Active: failed (Result: exit-code) since Wed 2020-04-22 19:04:14 CEST; 4s ago
  Process: 23740 ExecStart=/nix/store/kkbx0l7z1fzsfy1sivygjzplhm93gzsh-acme-start (code=exited, status=1/FAILURE)
 Main PID: 23740 (code=exited, status=1/FAILURE)
       IP: 0B in, 1.3K out
      CPU: 52ms

Apr 22 19:04:14 arianvp.me systemd[1]: Starting Renew ACME Certificate for arianvp.me...
Apr 22 19:04:14 arianvp.me kkbx0l7z1fzsfy1sivygjzplhm93gzsh-acme-start[23740]: 2020/04/22 19:04:14 Could not create client: get directory at 'https://acme-v02.api.letsencrypt.org/directory': Get "https://acme-v02.api.letsencrypt.org/directory": dial tcp: lookup acme-v02.api.letsencrypt.org: device or resource busy
Apr 22 19:04:14 arianvp.me kkbx0l7z1fzsfy1sivygjzplhm93gzsh-acme-start[23740]: 2020/04/22 19:04:14 Could not create client: get directory at 'https://acme-v02.api.letsencrypt.org/directory': Get "https://acme-v02.api.letsencrypt.org/directory": dial tcp: lookup acme-v02.api.letsencrypt.org: device or resource busy
Apr 22 19:04:14 arianvp.me systemd[1]: acme-arianvp.me.service: Main process exited, code=exited, status=1/FAILURE
Apr 22 19:04:14 arianvp.me systemd[1]: acme-arianvp.me.service: Failed with result 'exit-code'.
Apr 22 19:04:14 arianvp.me systemd[1]: Failed to start Renew ACME Certificate for arianvp.me.
Apr 22 19:04:14 arianvp.me systemd[1]: acme-arianvp.me.service: Consumed 52ms CPU time, received 0B IP traffic, sent 1.3K IP traffic.

[arian@t490s:~/Projects/nixos-stuff]$

Expected behavior
ACME Certs renew as expected
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Notify maintainers
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

My gut feeling this is because of me using systemd-resolved and dbus.service was reloading

I don't think dbus.service should reload?

Relatedly it tried to restart sshd.service whilst I was connected and It printed:
Apr 22 19:04:13 arianvp.me systemd[1]: Stopping SSH Daemon...
Apr 22 19:04:13 arianvp.me systemd[1]: Stopping Flush Journal to Persistent Storage...
Apr 22 19:04:13 arianvp.me systemd[1]: sshd.service: Succeeded.
Apr 22 19:04:13 arianvp.me systemd[1]: Stopped SSH Daemon.
Apr 22 19:04:13 arianvp.me systemd[1]: sshd.service: Consumed 57min 50.309s CPU time, received 2.8G IP traffic, sent 782.9M IP traffic.
Apr 22 19:04:13 arianvp.me systemd[1]: sshd.service: Found left-over process 23396 (sshd) in control group while starting unit. Ignoring.
Apr 22 19:04:13 arianvp.me systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Apr 22 19:04:13 arianvp.me systemd[1]: sshd.service: Found left-over process 23397 (sshd) in control group while starting unit. Ignoring.
Apr 22 19:04:13 arianvp.me systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Apr 22 19:04:13 arianvp.me systemd[1]: sshd.service: Found left-over process 23398 (sshd) in control group while starting unit. Ignoring.
Apr 22 19:04:13 arianvp.me systemd[1]: This usually indicates unclean termination of a previous run, or service implementation deficiencies.
Apr 22 19:04:13 arianvp.me systemd[1]: Starting SSH Daemon...

Which is useful because it didn't disconnect me whilst remotely applying; but also sounds like a bug in our service file?

ah no the problem is that it also stopped and started systemd-resolved.service. That explains haha.
Usually you'd solve this ordering problem by ordering units After=network.target or After=nss-lookup.target which are two passive units that systemd. But how to handle these kind of things in a nixos-rebuild switch` I'm not sure. Sounds complicated to pull off correctly

I am rather confused. AFAIK systemd-resolved should be DBUS-activated, so once it is stop'd  requests should be buffered to it and it should be started on demand... but that isn't happening:
[root@arianvp:~]# systemctl stop systemd-resolved

[root@arianvp:~]# ping google.com
ping: google.com: Name or service not known

[root@arianvp:~]# systemctl start systemd-resolved

[root@arianvp:~]# ping google.com
PING google.com (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from ec-in-f101.1e100.net (<IP_ADDRESS>): icmp_seq=1 ttl=45 time=4.42 ms

As per discussion, this isn't a regression, but so far we don't ship the dbus-activated units that systemd ships, causing resolved to not auto-activate. We'll create a follow-up issue to enable it on unstable.

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/make-acme-renew-systemd-service-depend-on-dns-nss-lookup/7412/6

This seems to be fixed on 20.09.
On 20.03, when using simple-nixos-mailserver (which installs kresd, the knot-resolver), I got the

Get "https://acme-v02.api.letsencrypt.org/directory": dial tcp: lookup acme-v02.api.letsencrypt.org: device or resource busy

and I couldn't curl https://acme-v02.api.letsencrypt.org/directory either there.
I found that according to https://logs.nix.samueldr.com/nixos/2020-02-23#3099629; @Infinisil had a very similar problem with a server that ran its own DNS server.
For me the upgrade to 20.09 on the same machine fixes it.
But I'm not sure which concrete nixpkgs change fixed it.

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/make-acme-renew-systemd-service-depend-on-dns-nss-lookup/7412/7

@nh2 Probably https://github.com/NixOS/nixpkgs/pull/99901

I'm reopening this issue as it wasn't entirely solved by #99901. I've been looking into it further and the only real solution to verify that DNS is working during startup would be to push it into a preStart script or to proceed with something like this: https://github.com/go-acme/lego/pull/1280

Switching to a socket-activated DNS helps but does not eliminate errors in the acme units entirely.
Another failure mode is
compute2.......................> Feb 11 09:08:24 compute2 acme-example.com-start[26893]: 2021/02/11 09:08:24 Could not create client: get directory at 'https://acme-v02.api.letsencrypt.org/directory': Get "https://acme-v02.api.letsencrypt.org/directory": net/http: timeout awaiting response headers

which makes me wonder whether this unit should retry itself. Perhaps not, because of letsencrypt's rate limits. It runs on a systemd timer anyway.
So perhaps the solution is to avoid running the acme client during switch whenever possible.
On way we might do that is to duplicate the service unit, run the otherwise unmodified unit on a timer only and change the new unit to run during activation only and short-circuit when a certificate is already present.

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/configure-acme-to-retry-challenge-multiple-times/12118/4

Should have been fixed by https://github.com/NixOS/nixpkgs/pull/147784.


Not clear what this line does?

https://github.com/DavisThuillier/Ludwig.jl/blob/ae410e2cd2960b22efeb5ac8ca592a9f3aa514e0/scripts/electron_impurity.jl#L26

This line was previously used when the band weight for impurity scattering was uniform. Deprecated and now removed. Did not affect functionality, since V_squared is redefined as a matrix in line 28.


Problem: X-Up-Location content

ex_unpoly serves it with the hostname included.
I ran into a problem. After I plugged in ex_unpoly, my Unpoly
transitions stopped working. I noticed that the X-Up-Location response
header served contained a full URL (with the hostname set to localhost,
even though I was accessing it remotely from a different machine).
Solution: include only the path
https://unpoly.com/up.protocol suggests that the host is not necessary.

@yrashk thanks for your PR. I've used the Unpoly Rails gem as base for this PR and they use the full URL as well (https://github.com/unpoly/unpoly/blob/master/lib/unpoly/rails/request_echo_headers.rb#L23). And I prefer not to deviate to much from their implementation.
I never had any problem regarding the hostname in any of my Phoenix apps, so maybe there is an issue with your application configuration. Please make sure that you have an host configured for the endpoint's URL (https://hexdocs.pm/phoenix/Phoenix.Endpoint.html#module-runtime-configuration).
config :example, ExampleWeb.Endpoint,
  url: [host: "example.com", port: 80]

This host is used for generating URLs within the app and is also used to resolve the current URL.

Fair enough, makes sense. I've reformulated the solution to the problem I've had.
ex_unpoly serves it with the hostname provided by Phoenix framework, which is generated from its configuration.
However, this isn't always a true hostname. There are at least a few scenarios where that URL won't be the one used by the user.
For example:

Local development server, configured with "localhost" but being
accessed with a hostname using a different computer on the same
network (this is how I ran into this issue)
Serving application on multiple domains (or sub-domains). This is
more important in production.

I've amended the PR to use Plug.Conn.request_url/1 as it looks at the actual request instead of Phoenix's configuration.
Do you think this makes more sense now?

@robinvdvleuten any thoughts on the above comment and the amended code I left a few days ago?
Thanks!

You can't solve the hostname issue through the use of Plug.Conn.request_url/1 as this doesn't work when the application is behind a reverse proxy (like on Heroku). It can't resolve the https/http scheme correctly for example.
I'm afraid that in your case, the best thing to do is set the hostname of the endpoint in the config file of the environment you're running in (dev for example). By default this is already set to localhost.
When running the application on multiple (sub-)domains, you run into other routing issues as well. So there you need to set the correct hostname in the router scopes.
scope "/", ExampleWeb.App, host: Application.get_env(:example, :host_app) do
  pipe_through :browser

  # Routes for app domain...
end

scope "/", ExampleWeb.Web, host: Application.get_env(:example, :host_web) do
  pipe_through :browser

  # Routes for web domain...
end

def put_router_url_for_app_host(conn, _opts \\ []) do
  put_router_url_for_host(conn, :host_app)
end

def put_router_url_for_web_host(conn, _opts \\ []) do
  put_router_url_for_host(conn, :host_web)
end

def put_router_url_for_host(conn, host) do
  put_router_url(conn, %{
    ExampleWeb.Endpoint.struct_url()
      | host: Application.get_env(:example, host)
  })
end

I'm gonna close this for now, as I've used Plug.Conn.request_url/1 previously and ran into multiple issues myself. The correct way for the hostname to work is to configure it on the endpoint.


update codecov upload token

upload codecov upload token. @ZhijunZhao

@yungez,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@554997e). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #4   +/-   ##
=========================================
  Coverage          ?   77.59%
=========================================
  Files             ?       15
  Lines             ?      424
  Branches          ?       56
=========================================
  Hits              ?      329
  Misses            ?       57
  Partials          ?       38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 554997e...a0d0b90. Read the comment docs.


Implement script runner

This pull request implements script runner for managing a user defined script. The .spec.processor.scriptRunner field is introduced in Operation API. More design details could be found in https://github.com/kubediag/kubediag/pull/79

LGTM


[Feature] Change app namespace call in commands

Is your feature request related to a problem? Please describe.
We are using a non-standard folder structure for our app in which the searchable models live in a different namespace to the namespace defined in laravel's Application.php.
Because of this the flush and import commands do not pickup our models since they use the method app()->getNamespace().
Describe the solution you'd like
Either a different method for finding the models or a way to configure the namespace to look in.
algolia/scout-extended uses an approach which looks at the root composer.json file and collects the autoload mappings. Perhaps with some changes to ignore the common database namespaces this would be a good approach. See: https://github.com/algolia/scout-extended/blob/bf3d7876fadaaa1cdbce3a09cfd256227406a3fc/src/Helpers/SearchableFinder.php#L116
Alternatively this could be managed via config. Perhaps with a default value of App\\ or app()->getNamespace().
Describe alternatives you've considered
We can't extend the existing commands so as a workaround we have just copied them as a way of overwriting, then have changed the namespace function call. But this is not ideal as we will need to keep it up to date.

Yeah following algolia-extended approach is good idea. Feel free to open PR

Sure, will get around to it when I can


MWPW-130073 - [Library] Add block patterns/grouping to the block library

adds support for containers to the block library

A block container:

is defined by all the content that is between the library-container-start and the library-container-end blocks
can contain items of any type of docx content: title, text, image, section, block…
can be browsed, copied and pasted into the docx page
is available in the library Blocks tab (to not confuse authors with yet another tab)
can be queried: search tags can be defined in the library-metadata block following the library-container-end block
the container name can be defined in the library metadata block as the title property. If not defined, it is inherited from the title of the first block below the library-container-start block

Resolves: MWPW-130073
Test URLs:

Before: https://main--milo--adobecom.hlx.page/tools/library?martech=off
After: https://library-container--milo--adobecom.hlx.page/tools/library?martech=off

Test URL with draft containers for carousel and tab:
https://library-container--milo--adobecom.hlx.page/tools/library?martech=off&library=/drafts/jck/tmp/library/docs/library/library.json
Content model for the library page:

Library:

Functional testing is looking good! This is an awesome update to the block library.
I'm still doing testing, just wanted to say how good it looks so far.

This might be too deep for this tasks:
I noticed that if I include a fragment in a pattern the fragment link gets mangled by Word.
This happens when the pattern is copied from the block library and pasted to a page.

cc: @auniverseaway

I think it would be helpful to be able to add a custom name/title to the grouping so that custom grouping can have a more meaningful name.

@rgclayton With https://github.com/adobecom/milo/pull/772/commits/57bab6c7b69c88a507a1d81d7f246d882a8d0319, the title of the container/pattern can be defined in the Library Medatadata section as title property. I prefer to have it defined there so that all properties related to a container/pattern like searchTags and title are defined at the same place.

I noticed that if I include a fragment in a pattern the fragment link gets mangled by Word.

@rgclayton This is fixed now!

the title of the container/pattern can be defined in the Library Medatadata section as title property. I prefer to have it defined there so that all properties related to a container/pattern like searchTags and title are defined at the same place.

Ok. I got it to work. A little less intuitive, but makes sense.

@jckautzmann : I'd like to verify the new library block pattern feature. Can you briefly outline the steps needed to test this against your PR branch? Thx

@honstar Thx for your feedback! I addressed it in https://github.com/adobecom/milo/pull/772/commits/e59df2f53ee5fade316b26cabb26adfb6191362a
As for testing the feature, you can use the Test link in the PR description:
https://library-container--milo--adobecom.hlx.page/tools/library?martech=off&library=/drafts/jck/tmp/library/docs/library/library.json
-> tabs and carousel blocks use the container/pattern feature.
You can check the custom library:
https://library-container--milo--adobecom.hlx.page/drafts/jck/tmp/library/docs/library/library.json
and edit the custom block pages (the ones with drafts/jck in the URL).
You can edit the Tabs and Carousel pages in Sharepoint to see how a container is defined using the library-container-start and library-container-end blocks.
You can defined your own block page, define a container, and add the page to the library.xlsx file in SP.

One thing I noticed while testing the new library container feature: looks like searching for a configured block container is only using its defined (list of) searchTags. Searching by its title should also work imo.

One thing I noticed while testing the new library container feature: looks like searching for a configured block container is only using its defined (list of) searchTags. Searching by its title should also work imo.

@honstar Great observation.
@jckautzmann What do you think? What's the level of effort to have the search work with the title prop AND the searchTags prop?

One thing I noticed while testing the new library container feature: looks like searching for a configured block container is only using its defined (list of) searchTags. Searching by its title should also work imo.

@rgclayton @honstar I added support for this use case in
https://github.com/adobecom/milo/pull/772/commits/60adf6a6cbb5672dad68615173c502db97931bba
I noticed that an author now has two ways to define a specific title for a container:

By adding an H2 or H3 before the container
By adding a title property to the library-metadata section

This might confuse authors. I would only keep 1) and remove 2). WDYT?

I noticed that an author now has two ways to define a specific title for a container:

By adding an H2 or H3 title before the container
By adding a title property to the library-metadata section

This might confuse authors. I would only keep 1) and remove 2). WDYT?

I agree @jckautzmann , let's keep option 1 👍

@honstar @rgclayton As agreed I removed support for defining a title in the container metadata.
Could you please validate the change and merge this PR? Thx!

I noticed that an author now has two ways to define a specific title for a container:

By adding an H2 or H3 title before the container
By adding a title property to the library-metadata section

This might confuse authors. I would only keep 1) and remove 2). WDYT?

Authors won't be editing this content. Only a select few engineers have access to edit these files. As long as we can provide a custom title for a grouping I think we are good.
cc @jckautzmann @honstar

Authors won't be editing this content. Only a select few engineers have access to edit these files. I think it's fine if both ways exist. As long as we can provide a custom title for a grouping I think we are good.

@rgclayton You can provide a custom title for the container by adding a H2/H3 title before the container (same as for a simple block).

Authors won't be editing this content. Only a select few engineers have access to edit these files. I think it's fine if both ways exist. As long as we can provide a custom title for a grouping I think we are good.

@rgclayton You can provide a custom title for the container by adding a H2/H3 title before the container (same as for a simple block). I don't think that providing another option to define a custom title is needed.

@jckautzmann This is no longer working.
The "My Fancy Carousel" should be appearing as an option and should be searchable. It was at one point. It's not now.

Adding the do not merge label until my previous comment is sorted out.

@rgclayton the failed unit test was probably due to some flakyness: all tests are passing now.
For the title: are you sure that you are editing the right page? You should be editing this one:
https://main--milo--adobecom.hlx.page/drafts/jck/tmp/library/docs/library/blocks/carousel
I tried again and it is working for me: I added test1 to the title defined as H2: this title appears in the library menu and searching for test1 displays the carousel.

I'm going off of what you have listed in the description above. I see the edits in the Word doc. When trying to view those edits in the block library (For carousels) they are not showing with the url provided in the description.
https://library-container--milo--adobecom.hlx.page/tools/library?martech=off

@rgclayton Ah, now I get it :) I've been testing with the sample library (the test URL with draft containers for carousel and tab:
https://library-container--milo--adobecom.hlx.page/tools/library?martech=off&library=/drafts/jck/tmp/library/docs/library/library.json
Can you please retry with this url?

@rgclayton Ah, now I get it :) I've been testing with the sample library (the test URL with draft containers for carousel and tab:
https://library-container--milo--adobecom.hlx.page/tools/library?martech=off&library=/drafts/jck/tmp/library/docs/library/library.json
Can you please retry with this url?

That was it! Looks good. Will merge.


chore(master): release 0.17.0

:robot: I have created a release beep boop
0.17.0 (2022-12-21)
Miscellaneous Chores

release 0.17.0 (cb0ca4d)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/ethersphere/swarm-desktop/releases/tag/untagged-95ed1cc6371e975b6ddc :sunflower:


NO attribute group by column

hi @otykier
I want to use custom field parameters.
I've seen some friends use tabular Editor with properties like group by column
But I have been looking for a long time, but I still can't find the attribute group by column
Is there something wrong with my usage? Please give me your guidance.
Thank you very much

tabular editor version 2.16.7
power bi version 2.107.683.0 64-bit (2022-7)

When connected to a model in Power BI Desktop, only a subset of properties are available for reasons described here. If you want to experiment, you can allow unsupported Power BI features under File > Preferences.

When connected to a model in Power BI Desktop, only a subset of properties are available for reasons described here. If you want to experiment, you can allow unsupported Power BI features under File > Preferences.

Yes it is!
Thank you very much


work-around requested for Microsoft SQL Server MSODBCSQL handling of NULL

PHP Driver version or file name
php-sqlsrv-5.8.0
SQL Server version
Microsoft SQL Server 2017 (RTM-CU21) (KB4557397) - 14.0.3335.7
Microsoft SQL Server 2016 (SP2-CU14) (KB4564903) - 13.0.5830.85
Client operating system
CentOS Linux release 7.6.1810 (Core)
Linux 3.10.0-957.12.1.el7.x86_64 #1 SMP Mon Apr 29 14:59:59 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
PHP version
PHP 7.4.3
Microsoft ODBC Driver version
Name        : msodbcsql17
Version     : <IP_ADDRESS>
Build Date  : Fri 15 Jan 2021 02:56:50 PM EST
Table schema
None required to run the test.
Problem description
The Microsoft SQL Server ISNULL function seems to badly handle a NULL value transmitted to it
using SQLBindParameter with a data type of SQL_CHAR and length of 1. Because the only
purpose of PDO_SQLSRV is to interact with the Microsoft flagship relational database product
I am asking for a work-around to be implemented so that a NULL is transmitted
using SQLBindParameter with data type of SQL_VARCHAR and length of 0.  This work
around has been proven with the SQLRelay open source file src/connections/odbc.cpp starting at
about line 2407 where there is extensive commentary about this issue.
This work around would speed up the full retirement of the PDO_DBLIB freetds driver at the company where I work. In order to continue using Microsoft SQL Server I can supply a patch to PDO_SQLSRV if such a patch would be accepted in principal rather than rejected as not needed due to the possibility of fixing Microsoft SQL Server instead.
Expected behavior and actual behavior
select cast(ISNULL(:K, -1) as int) as K
is expected to return -1 when K is NULL. Instead it gives
[Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Conversion failed when converting the varchar value ='*' to data type int.
Repro code or steps to reproduce
Run the attached php file with environment variables set to the database server, user credentials and database used for testing. Also attached is a stdout and an odbc trace.
env DB_SERVER=localhost DB_NAME=master DB_USER=user1 DB_PASS=pass1 php infnext-1870-sqlsrv-null-bug.php
Using the php file from this zip. The zip also contains a stdout and an odbc trace log.
test-artifacts.zip

Thanks @gjcarrette for bringing this to our attention. We will investigate and get back to you on this.

Hi @gjcarrette, just so you know, VARCHAR with column size 0 is essentially a varchar(max).
Based on the documentation of ISNULL, the replacement_value is the expression to be returned if check_expression is NULL, and replacement_value must be of a type that is implicitly convertible to the type of check_expression.
In your example, when K is null, this is what happens (you see that it returns an *):
select cast (-1 as char(1))
The same happens if you change your query to select (ISNULL(:K, -1));, which returns a *. It is not convertible to an integer.
However, if you try one of these:
select cast (1 as char(1)) -- returns 1
select cast (0 as char(1)) -- returns 0

Hence, using 1 or 0 instead of -1 gives you what is expected. I'm not asking you to change your script(s), but the above explains that this is not a bug. It is as designed.

Any update @gjcarrette ?

5.10.0-beta 2 is just released. Please give it a try, @gjcarrette . Thanks again for your contribution.

Closing this now please feel free to ask us to reopen.


koord-scheduler: make ForceSyncFromInformer easier to use

Signed-off-by: Joseph<EMAIL_ADDRESS>Ⅰ. Describe what this PR does
Make ForceSyncFromInformer easier to use.

/lgtm

/approve

/milestone v1.1


Please index @label and @description for each tree

These fields would be very helpful when retrieving a tree with /v3/studies/find_tree. This is how we add trees from any study (assuming we're not currently editing it) to a tree collection. The current index (oti) returns just the "raw" tree ID. I'd much rather store the friendlier name in @label in the collection JSON, as well as its @description text.

You want to search by label and description, or you want these included in the returned fields for find_trees and find_studies when verbose=True?

I mainly want these values in the verbose output. Thanks!

See dup of this in oti #42

I am adding @label to the return values now. I am not sure what you mean by the @description text, though. What field is this in the curator UI?

Hm, there's no such thing! I could have sworn we had a @description field for trees, but I don't see it in the Nexson doc or anywhere in the current phylesystem corpus.
Oh, it looks like we used to have this free-form tree description (as seen in this screenshot), but it was replaced by multiple controlled description fields like ot:inferenceMethod and ot:branchLengthDescription , as discussed in https://github.com/OpenTreeOfLife/opentree/issues/552 and https://github.com/OpenTreeOfLife/opentree/issues/555.
In any case, my intention was to get a reasonable default description for each tree, to be added to its entry in the decision list of a tree collection. Perhaps we can construct something useful from the inference-method and other fields? Suggestions welcome!

This commit adds @label to the returned values for find_trees. Note that we also talked about adding a /meta option to the phylesystem-api GET methods that would let you get metadata for a specific tree (rather than using find_trees). See #19


Add support for LE Extended Advertising

Need to figure out what's the interops between legacy and extended adv.

Note here: According to Core Spec Vol.4 Part E, Section 3.1.1 - Legacy and extended advertising, Host should not issue Legacy Advertising commands when the Controller supports Extended Advertising, so there is no interops issue.


Extension.Contents + Expression.Evaluate: Report .pqm file name with parse/syntax errors

Preflight Checklist

[X] I have installed the latest version of Power Query SDK.
[X] I have checked existing resources, including the common issues and the release notes.
[X] I have searched for similar issues.

Problem
(This relates to a Microsoft-recommended PQ pattern that is unique to connectors. I hope this is the correct place for this request.)
Extension.Contents + Expression.Evaluate are commonly used in connectors to load M code from .pqm files. When this is done, if a .pqm file contains a syntax problem, Expression.Evaluate will raise an appropriate error. However, this error does not indicate which .pqm file in the extension contains the error.
Desired Solution
To help with debugging, especially when a connector includes multiple .pqm files, could errors raised by Expression.Evaluate include the .pqm file’s name?
Alternatives and Workarounds
No response
Additional Context
Implementation idea:

Modify Expression.Evaluate to check its first argument (document—the source code argument) for metadata field Origin. If found, include its value as a Detail on any errors that may be raised by/from Expression.Evaluate.
Modify the "include .pqm file" pattern template to set this metadata field—something like:Extension.LoadFunction = (name as text) =>
  let
      binary = Extension.Contents(name),
      asText = Text.FromBinary(binary)
+                     meta [Origin = [Type = "EmbeddedFunction", FileName = name]]
  in
      Expression.Evaluate(asText, #shared);

Changing Expression.Evaluate is out of scope at this time.
Loading module files in this way was really meant to be temporary... ideally we'd have an actual module referencing system that allows proper reuse and versioning... but I don't see that being funded in the near future.
How about changing the definition of Extension.LoadFunction to something like:
Extension.LoadFunction = (name as text) =>
  let
      binary = Extension.Contents(name),
      asText = Text.FromBinary(binary)
  in
      try
        Expression.Evaluate(asText, #shared)
      catch (e) =>
        error Error.Record("Expression.Error", Text.Format("[#{0}] #{1}", {name, e[Message]}), e);

[7:23:11 PM]	[Info]	RunTestBattery result [
    {
        "ActivityId": "9ba74e60-ccfd-4881-a438-86cb26491ab9",
        "DataSourceAnalysis": [
            {
                "Kind": "DataSource",
                "FunctionName": "TestTestTest.Contents",
                "DataSource": {
                    "Kind": "TestTestTest",
                    "NormalizedPath": "TestTestTest",
                    "Path": "TestTestTest"
                }
            }
        ],
        "Details": "[TestModule.pqm] [1,9-1,10] The type identifier is invalid.",
        "EndTime": "2022-11-03T23:23:11.422378+00:00",
        "Method": "PQTest.RunTest",
        "Name": "TestTestTest.query.pq",
        "StartTime": "2022-11-03T23:23:09.2928229+00:00",
        "RowCount": 0,
        "Status": "Failed",
        "Type": "PQTest.Expression",
        "Error": {
            "Message": "[TestModule.pqm] [1,9-1,10] The type identifier is invalid.",
            "Details": {
                "Reason": "Expression.Error",
                "Message": "[1,9-1,10] The type identifier is invalid.",
                "Detail": "{[...]}",
                "Message.Format": "[1,9-1,10] The type identifier is invalid."
            }
        }
    }
]


Is there a way to expand a group from the api?

I want to expand a group node programatically from the api when I know the row index. Is there a way to do this using an api method call? I don't see anything in the documentation.

Nevermind. I have found the method I was looking for, onGroupExpandedOrCollapsed. Thanks

@albertoacuna how do u use it? it doesn't work for me


1.5.0rc1 changelog

Description
Create 1.5.0rc1 changelog
Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[ ] I have run changie new to create a changelog entry

This may have been run out of order. CircleCI shows dbt-core==1.5.0b5 being installed instead of dbt-core==1.5.0rc1


Common names not always matching Locale setting

Common names on this page sometimes show English and sometimes show Italian, despite locale being set to Italian. Coming from @carlacorazza.

I noticed that when my default language was set to "English" I would get Spanish common names on some (but not all) of the Species Guide pages and in csv export files. When I switched to "English (United States)" everything now shows in English.


Spanish docs [skip ci]

@SilverFire, @cebe, @samdark sorry guys, but could someone accept this PR so I can keep working on the translation? I don't want to mess with the branches and merges...

Thank you.

Thanks, @klimov-paul ! :smiley:


Autosync Dropbox and AWS

While currently I have software on my PC monitoring and copying new and updated files from Dropbox to AWS where various types of files are needed for stage/production builds, it occurs to me that it would be better to simply create a task or tasks to automate this on AWS to do the syncing.
Here are the folders that need to be synced, and their purpose.

PEP Dropbox\PEP's shared workspace\PEP for All\Inventory\AWSProd Video Previews -> s3s://s3.amazonaws.com/pep-web-video-previews

This is where video previews are saved by Sophie or other PEP staff to Dropbox, then found by the client to display a preview when a user is not logged in.  Note that the previews must match the file name of the video, plus a suffix of .preview.mp4 (and also caption files), and due to the settings in the client, the file must be LOWER CASE ONLY (even if the main video file source is upper case).

PEP Dropbox\PEP's shared workspace\PEP for All\Inventory\Photos\PhotosInterestingForPOTD -> s3s://s3.amazonaws.com/pep-web-expert-pick-images

These are the selected photos/graphics picked randomly by the server for Photo of the Day

PEP Dropbox\PEP's shared workspace\PEPWeb\Inventory\PEPDownloads\PDF -> s3s://s3.amazonaws.com/pep-web-files/pdforiginals

These are the downloadable PDF originals

PEP Dropbox\PEP's shared workspace\PEPWeb\_PEPA1\_PEPa1v\_PEPArchive ->s3s://s3.amazonaws.com/pep-web-xml/_PEPArchive

The XML "PEPArchive" files loaded into Solr by the load process

PEP Dropbox\PEP's shared workspace\PEPWeb\_PEPA1\_PEPa1v\_PEPCurrent -> s3s://s3.amazonaws.com/pep-web-xml/_PEPCurrent

The XML "PEPCurrent" files loaded into Solr by the load process

PEP Dropbox\PEP's shared workspace\PEPWeb\_PEPA1\_PEPa1v\_PEPFree -> s3s://s3.amazonaws.com/pep-web-xml/_PEPFree

The XML "Free" files loaded into Solr by the load process

PEP Dropbox\PEP's shared workspace\PEPWeb\_PEPA1\_PEPa1v\_PEPFuture -> s3s://s3.amazonaws.com/pep-web-xml/_PEPFuture

The XML "PEPFuture" files loaded into Solr by the load process.  We use this to load data that won't go up on the production server while we are working on the next version of PEP.  IMPORTANT -- This is NOT YET IMPLEMENTED in the Opas loaderv system or PaDS permission system.

PEP Dropbox\PEP's shared workspace\PEPWeb\_PEPA1\_PEPa1v\_PEPOffsite -> s3s://s3.amazonaws.com/pep-web-xml/_PEPOffsite
PEP Dropbox\PEP's shared workspace\PEPWeb\_PEPA1\GoogleMetadata -> s3s://s3.amazonaws.com/pep-web-files/google-metadata
PEP Dropbox\PEP's shared workspace\PEPWeb\_PEPA1\g -> s3s://s3.amazonaws.com/pep-web-files/doc/g

This is where the Client app picks up graphics for display.  It just ended up in a bit of a different location during development while I was getting used of s3 and because I've always kept the graphics at a level above the xml folders.  It might be better off moving to s3s://s3.amazonaws.com/pep-web-xml/g to better aggregate them.  Of course, this would need to be adjusted in the client.

This list does not include another type of sync, discussed elsewhere, which needs to wait for the new AWS FTP site (then that would be synced to the FTP subtree of dropbox.

This is now handled implicitly since Aptara is in charge of inventory/ingestion, since they deliver data directly to AWS S3.
What's not handled other than by my PC, is backup to Dropbox.  But that's not critical.  Closing.


Pod with ephemeral-storage request not scaling NodePool from 0 on v0.34.1

Description
Observed Behavior:
Failed to schedule pod, incompatible with nodepool "devrunners-intel-xlarge-pool", daemonset overhead={"cpu":"685m","memory":"340Mi","pods":"9"}, no instance type satisfied resources {"cpu":"30685m","ephemeral-storage":"180G","memory":"112980Mi","pods":"10"}

Expected Behavior:
When setting the blockDeviceMappings in the EC2NodeClass resource has been set to have a large disk, I expect Karpenter to be able to ascertain the available ephemeral-storage ahead of a scale out, but it seems to be unable to. Removing the ephemeral-storage request fixes it and the NodePool can suddenly scale from 0
Reproduction Steps (Please include YAML):
Made essentially the following resources, removing some more specific bits like labels, ensuring that the NodePool can't be scaled up by any other node (as once the NodePool has an example node, it can be scheduled)
apiVersion: karpenter.k8s.aws/v1beta1
kind: EC2NodeClass
metadata:
  name: devrunners-intel-xlarge-class
spec:
  amiFamily: AL2
  blockDeviceMappings:
    - deviceName: /dev/xvda
      ebs:
        volumeSize: 250G
  metadataOptions:
    httpEndpoint: enabled
    httpProtocolIPv6: disabled
    httpPutResponseHopLimit: 2
    httpTokens: required
  role: <role arn>
  securityGroupSelectorTerms:
    - tags:
        karpenter.sh/discovery: <cluster_name>
  subnetSelectorTerms:
    - tags:
        karpenter.sh/discovery: <cluster_name>

---
apiVersion: karpenter.sh/v1beta1
kind: NodePool
metadata:
  name: devrunners-intel-xlarge-pool
spec:
  disruption:
    budgets:
      - nodes: 10%
    consolidationPolicy: WhenUnderutilized
    expireAfter: 720h
  template:
    spec:
      nodeClassRef:
        apiVersion: karpenter.k8s.aws/v1beta1
        kind: EC2NodeClass
        name: devrunners-intel-xlarge-class
      requirements:
        - key: karpenter.k8s.aws/instance-family
          operator: In
          values:
            - m5n
        - key: karpenter.k8s.aws/instance-size
          operator: In
          values:
            - 8xlarge
      taints:
        - effect: NoSchedule
          key: xlarge-box

Scheduling a pod with a 180 GiB ephemeral storage request spits an error that the NodePool cannot accomodate  the resources.
Failed to schedule pod, incompatible with nodepool "devrunners-intel-xlarge-pool", daemonset overhead={"cpu":"685m","memory":"340Mi","pods":"9"}, no instance type satisfied resources {"cpu":"30685m","ephemeral-storage":"180G","memory":"112980Mi","pods":"10"}

Removing the ephemeral storage requests fixes it, and were a node to come online it would schedule. Is there some way to annotate to Karpenter that a NodePool will have a certain ephemeral storage upon startup? Like ClusterAutoscaler's ASG tags.
Versions:

Chart Version:
v0.34.1

Kubernetes Version (kubectl version):

Client Version: v1.28.5
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.28.5-eks-5e0fdde

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

NVM I figured it out, for some reason the same settings didn't work in Cluster Autoscaler, but just adding more headroom to the disk worked


fix realtime index task json description in doc

The "metricsSpec" and "granularitySpec" should not be within the "parser" section.

Thanks @KurtYoung, do you quickly filling out our CLA form at http://druid.io/community/cla.html, so we can merge this? Thanks!

done

@KurtYoung Thanks for the contrib!

@fjy Glad to help, wish to contribute more


Sort Breaks with mixed data

Hi,
i really appreciate your javascript.
i have a table with a column which has numbers and - the String "N/A" if i got no data.
The sorting seems to "break":
<!DOCTYPE html>

    <link rel="stylesheet" type="text/css" href="./dist/jstable.css">

                Test

                0

                15

                N/A

                0

                7

                33

                N/A

                2

                0

so it starts sorting, until it seems to hit a "N/A" and then start again sorting.
can this be fixed (or have i used this js wrong?)
Thanks
Best regards

Hey @ebini,
thank you for your feedback.
So first you don't need to include both javascript files jstable.min.js and jstable.es5.min.js. Only one file is needed. If you support current browsers you can just use the jstable.min.js. The file jstable.es5.min.js is only needed for compatibility with browsers that don't support current ES6 features.
I checked your example (and everything is used correct) and apparently there is indeed a problem with mixed data in some browsers, Chrome for example is working fine but Firefox has the issue which you described.
I will try to fix this as soon as possible.
Best regards

@ebini Could you please try the new version 1.5.1?

Thanks it is working now!
I'm very thankful!


favicon.ico missing from zipkin-ui

Seems like the zipkin-ui is missing a favicon.ico
One we can use can be taken from: http://zipkin.io/public/favicon.ico

closed via  #1069


Added users invitations

Summary

Fixed query bug
Now you can add new users to teams by sending an email
Now you can add existant users of the platform but from different organizations to a team

TODO: Fix rubocop offenses
TODO: Analyze if we don't need to add emails to the sign up because the github email could be different from the one you use to invite

Tests failing :open_mouth:


feat: add cisbenchmark checks for session 1.3, 1.4, and 2

Signed-off-by: Jose Donizetti<EMAIL_ADDRESS>Adds rules for session 1.2 API Server (up to 1.2.30, for now 1.2.31 and 1.2.32 are not included). This is my first time writing opa, let me know if you see anything that can be improved.
https://github.com/aquasecurity/trivy/issues/2200
cisbenchmark version: V1.23
"KCV0033": "1.3.1 Ensure that the --terminated-pod-gc-threshold argument is set as appropriate (Manual)",
"KCV0034": "1.3.2 Ensure that the --profiling argument is set to false (Automated)",
"KCV0035": "1.3.3 Ensure that the --use-service-account-credentials argument is set to true (Automated)",
"KCV0036": "1.3.4 Ensure that the --service-account-private-key-file argument is set as appropriate (Automated)",
"KCV0037": "1.3.5 Ensure that the --root-ca-file argument is set as appropriate (Automated)",
"KCV0038": "1.3.6 Ensure that the RotateKubeletServerCertificate argument is set to true (Automated)",
"KCV0039": "1.3.7 Ensure that the --bind-address argument is set to <IP_ADDRESS> (Automated)",
"KCV0040": "1.4.1 Ensure that the --profiling argument is set to false (Automated)",
"KCV0041": "1.4.2 Ensure that the --bind-address argument is set to <IP_ADDRESS> (Automated)",
"KCV0042": "2.1 Ensure that the --cert-file and --key-file arguments are set as appropriate (Automated)",
"KCV0043": "2.2 Ensure that the --client-cert-auth argument is set to true (Automated)",
"KCV0044": "2.3 Ensure that the --auto-tls argument is not set to true (Automated)",
"KCV0045": "2.4 Ensure that the --peer-cert-file and --peer-key-file arguments are set as appropriate (Automated)",
"KCV0047": "2.5 Ensure that the --peer-client-cert-auth argument is set to true (Automated)",

@chen-keinan ^^

@liamg @owenrumney This is ready for review now.


Layer breaker: should not reference monaco-workbench outside workbench

updated all dialog references

✅ lightbulb
✅ find widget
✅ severity icons
@jrieken can you take a look at the symbol icons, I wasn't able to find where the inline/block icons are used.

Yeah, those symbol icons aren't needed anymore - they are from the pre-codicon-times. I'll nuke them.

I think this is now done. Only references in the smoke tests are left ⬇. Closing.
/Users/jrieken/Code/vscode/test/automation/src/application.ts
  142,35: 		await this.code.waitForElement('.monaco-workbench');
  145,40: 			await this.code.waitForTextContent('.monaco-workbench .statusbar-item[id="status.host"]', ' TestResolver');

/Users/jrieken/Code/vscode/test/automation/src/viewlet.ts
  13,39: 		await this.code.waitForTextContent('.monaco-workbench .part.sidebar > .title > .title-label > h2', undefined, fn);


Attempting to add extended context to the seq2seq model

So I want to use the large seq2seq model to create some music, but then I found out that it is extremely memory consuming and I can only input a mere 16 bars into the network.
However, I have this idea that if I can input the next 32 bars into the decoder as the context, it might perform better since we are working with the Transformer-XL. But I've tried many ways to add it in and its either totally not working or at best yielding the exact same behaviour as before. So, is there a simple way to add this?

Just to clarify - you are using seq2seq for translation right? Sending 32 bars of melody to translate into chords or vice versa.
Yeah looks like it's super high memory because the decoder uses the full context of the encoder while using memory for storing what has already been predicted.
As you mentioned, we could try utilizing memory to store the encoder state (not just the decoder).
Right now, we're passing the x_enc on every iteration. Maybe you can try passing x_enc only on the first token prediction. Don't pass it in after that.
Ideally, x_enc will be stored in mha2 memory the second time around.
It's good that you pointed that out. I might try something next week, but if you figure it out beforehand, please let me know!

Turns out layer 2 memory was turned on when it shouldn't have been: eb95ea6. Turning it off gives a pretty significant speed boost.
Let me know if that still doesn't work