Does not render full div on Safari

I solved all possible problems as follows..

html2canvas(element , {
        scrollX: -window.scrollX,
        scrollY: -window.scrollY,
        windowWidth: document.documentElement.offsetWidth,
        windowHeight: document.documentElement.offsetHeight
})

Thanks but it did not fix the issue with iOS unfortunately, still you have to scroll to the top of the page, capture the screen and then scroll back!

In my case, it happens in a pop-up modal on the Safari browser.
The full div can be rendered (in the modal) on Chrome and Firefox. On Safari, when u scroll down of the modal, the bottom part of the captured element will be cut off.
Originally posted by @enkr1 in https://github.com/niklasvh/html2canvas/issues/1878#issuecomment-747328254

For me adding window.scrollTo(0,0); solved the problem.
$(function () {
    $("#btnSave").click(function () {
          window.scrollTo(0, 0);// you need to scrool to top for safari hack
          html2canvas($("#screen")[0]).then(canvas => {
                $("#img-out").append(canvas);
                canvas.toBlob(function (blob) {
                    saveAs(blob, "cecilieo_color_picker.png");
                });
          });
     });
});

For me adding window.scrollTo(0,0); ~solved the problem~. I thought it did, but it didn't work some times.
$(function () {
    $("#btnSave").click(function () {
          window.scrollTo(0, 0);// you need to scrool to top for safari hack
          html2canvas($("#screen")[0]).then(canvas => {
                $("#img-out").append(canvas);
                canvas.toBlob(function (blob) {
                    saveAs(blob, "cecilieo_color_picker.png");
                });
          });
     });
});

I tested it without window.scrollTo(0, 0); in Bootstrap modal on Chrome and Firefox, it worked fine.
Only for Safari, the div is cropped off, as there is a huge white space on top of the captured image (div)

For me adding window.scrollTo(0,0); ~solved the problem~. I thought it did, but it didn't work some times.
$(function () {
    $("#btnSave").click(function () {
          window.scrollTo(0, 0);// you need to scrool to top for safari hack
          html2canvas($("#screen")[0]).then(canvas => {
                $("#img-out").append(canvas);
                canvas.toBlob(function (blob) {
                    saveAs(blob, "cecilieo_color_picker.png");
                });
          });
     });
});

I tested it without window.scrollTo(0, 0); in Bootstrap modal on Chrome and Firefox, it worked fine.
Only for Safari, the div is cropped off, as there is a huge white space on top of the captured image (div)

@Leographik did you find a fix for this? I am having the same issue. When I capture a HTML SVG element with html2canvas on Chrome or Firefox everything works fine. When I switch to Safari it doesn't capture properly but instead translates and crops the image. Stuck on this and any help you may have found would be appreciated! Thanks.

Tried to bypass html2canvas using raw canvas as described here: https://stackoverflow.com/questions/3975499/convert-svg-to-image-jpeg-png-etc-in-the-browser/64800570#64800570
Didn't work, just hung forever loading, no error output. Leads me to believe this is an issue with newer versions of Safari and the canvas DOM element.


setup github actions

The actions are fairly minimal -- at some point we really need to strengthen them, but I'd like to find or build a standard actions library vs. going much further on this one.
We have  changed main.yaml so that it runs on ANY push, not just to the main branch.  I suspect that the requirements.txt update is still broken, however.  I'll give it a quick test and, if it isn't, I'm going to close this issue for the time being - ok?


build: setup Windows CI on TravisCI

Codecov Report

Merging #376 into master will decrease coverage by 4.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #376      +/-   ##
==========================================
- Coverage   62.65%   58.41%   -4.25%
==========================================
  Files          86       86
  Lines        6079     6079
==========================================
- Hits         3809     3551     -258
- Misses       1591     1888     +297
+ Partials      679      640      -39

Impacted Files
Coverage Δ

internal/accounts/client.go
10.25% <0.00%> (-65.39%)
:arrow_down:

internal/customers/client.go
13.91% <0.00%> (-63.48%)
:arrow_down:

internal/database/mysql.go
11.11% <0.00%> (-51.12%)
:arrow_down:

internal/filetransfer/sftp.go
32.80% <0.00%> (-39.69%)
:arrow_down:

internal/secrets/secrets.go
75.94% <0.00%> (-2.54%)
:arrow_down:

internal/depository/micro_deposits.go
65.20% <0.00%> (-1.39%)
:arrow_down:

internal/filetransfer/config.go
70.61% <0.00%> (-1.03%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09a2e1e...f66a803. Read the comment docs.

Codecov Report

Merging #376 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #376      +/-   ##
==========================================
+ Coverage   62.65%   62.69%   +0.03%
==========================================
  Files          86       86
  Lines        6079     6079
==========================================
+ Hits         3809     3811       +2
+ Misses       1591     1590       -1
+ Partials      679      678       -1

Impacted Files
Coverage Δ

internal/accounts/client.go
78.2% <0%> (+2.56%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09a2e1e...f66a803. Read the comment docs.


Installing plugins

What
Make it easier to install plugins and decide what plugins are installed at first.
My thoughts
Installing plugins
Make a command in homebridge.sh:
./homebridge.sh install <package-name>

which would simply run npm-install  inside the container.
Choosing plugins for first setup / build
Make a file called plugins.json
[
   "package-name",
   "package-name2"
]

This file is checked when the image is built and if it exists, all the packages are installed.
I hope my intentions are somewhat clear.
I could submit a PR if needed.

I like that idea, PR would be greatly appreciated

If this ever does get done, version pinning should be a thing


Draw an indicator to denote overbright colors in ColorPicker

This makes it faster to distinguish overbright colors from "standard" colors, as clicking and reading the values isn't required anymore.
The design of this feature is inspired by GIMP 2.10's display of overbright colors :slightly_smiling_face:
Preview

Overbright means if raw is above 1 right?

An indicator for over bright colors is useful. But I don't like the bright pink color of the icon. Is there a reason for it to be that color?

Im not sure if it's confusing for people but you could add simple tonemapping to the color if it is brighter than raw 1.0. that way you can roughly tell what shade it is.

An indicator for over bright colors is useful. But I don't like the bright pink color of the icon. Is there a reason for it to be that color?

I just went with the same indicator used by GIMP, but if there's no clear standard on how overbright colors are denoted, we can roll our own.

I think the white triangle looks best out of the proposed options.

I pushed a new version with a new indicator icon:

Yeah I didn't think about how it would look scaled down. I do also like the white triangle with the outline.

Thanks!

The default color for modulate is white. I am concerned that this triangle won't be identified as triangle but as weird black diagonal line.
The star proposed by @CowThing is a good symbol for something very bright. If combined with a 30% grey with 60% alpha, we end up with an overlay that is visible on top of black, white, bright colors and also very subtle mid tone colors.
To increase further readability on small resolutions the star can be made thicker.

This 256 by 256 pixel png already includes the alpha for the grey.
Here is a mockup where you can see it overlaying different luminosities and hues as well as how it looks in default resolution of the editor:

@golddotasksquestions I tried making the star thicker, but it still looked bad after the SVG was rasterized.

Don't import svg then, just use the png.


Simplified Coplanarity Check

Simplified and made the coplanar check work for more axes and angles. Used built-in vector functions from mathutils for simpler code. May need more testing but for all obvious good/bad test cases I ran it against it works.

It does not work at a certain turn, I propose to remove this check at all. When preparing a model, a good specialist checks its model


Moves Tree Contents so that simpsons data tree in example is defined.

This is a clone of #300 because I nuked my fork without thinking.
Since I'm reading the docs and don't know sphinx very well, I saw a problem with the is_hollow description and fixed it.
It may make more sense to have Tree Contents: Hollow Trees above Manipulating Trees: Subsetting Tree Nodes, but the simpsons DataTree is undefined. Rather than create a new tree for this example I just moved it.
In addition to moving it I changed the description from a python method to the py:class so that the rendering didn't include the incorrect parens.
The updated docs after rebuilding show the tree is not hollow rather than NameError: name 'simpsons' is not defined as it did before
New image generated:

Also increased clarity of the dt.match() operation by printing the result.

And fixed a typo. wo => twoj

Thanks @flamingbear. FYI the reason I added the content about "hollow trees" was in preparation for #271.


regID = undefined? Help

I am trying to register my android device for GCM. However my regID always returns undefined.
Here is my code:
var pushNotification;
        function onDeviceReady() {
        	alert('Device is ready')
			try
			{
            	pushNotification = window.plugins.pushNotification;
	      //$("#app-status-ul").append('
registering ' + device.platform + '
');
	      alert('Registering ' + device.platform);
            	if(device.platform == 'android' || device.platform == 'Android' ||device.platform == 'amazon-fireos' ) {
					pushNotification.register(
					successHandler,
					errorHandler,
					{
						"senderID":"xxxxxxxxxxxx",
						"ecb":"onNotification"
					});		// required!

					alert('Registered the Android device');
				} else {
                	pushNotification.register(tokenHandler, errorHandler, {"badge":"true","sound":"true","alert":"true","ecb":"onNotificationAPN"});	// required!
                	alert('Registered the iOS device');
            	}
            }
			catch(err)
			{
				txt="There was an error on this page.\n\n";
				txt+="Error description: " + err.message + "\n\n";
				alert(txt);
			}
        }

        // handle APNS notifications for iOS
        function onNotificationAPN(e) {
            if(e.alert) {
                 //$("#app-status-ul").append('
push-notification: ' + e.alert + '
');
                 alert('push-notification: ' + e.alert);
                 // showing an alert also requires the org.apache.cordova.dialogs plugin
                 navigator.notification.alert(e.alert);
            }

            if(e.sound) {
                // playing a sound also requires the org.apache.cordova.media plugin
                var snd = new Media(e.sound);
                snd.play();
            }

            if(e.badge) {
                pushNotification.setApplicationIconBadgeNumber(successHandler, e.badge);
            }
        }

        // handle GCM notifications for Android
        function onNotification(e) {
            //$("#app-status-ul").append('
EVENT -> RECEIVED:' + e.event + '
');
            alert('EVENT -> RECEIVED:' + e.event);

            switch( e.event )
            {
                case 'registered':
				if( e.regid.length > 0 )
				{
					//$("#app-status-ul").append('
REGISTERED -> REGID:' + e.regid + "
");
					// Your GCM push server needs to know the regID before it can push to this device
					// here is where you might want to send it the regID for later use.
					console.log("regID = " + e.regid);
					alert('	REGID = ' + e.regid);
				}
                break;

                case 'message':
                	// if this flag is set, this notification happened while we were in the foreground.
                	// you might want to play a sound to get the user's attention, throw up a dialog, etc.
                	if(e.foreground)
                	{
						//$("#app-status-ul").append('
--INLINE NOTIFICATION--' + '
');
						alert('--INLINE NOTIFICATION--');

					        // on Android soundname is outside the payload.
				                // On Amazon FireOS all custom attributes are contained within payload
				                var soundfile = e.soundname || e.payload.sound;
				                // if the notification contains a soundname, play it.
				                // playing a sound also requires the org.apache.cordova.media plugin
				                var my_media = new Media("/android_asset/www/"+ soundfile);
						my_media.play();
					}
					else
					{	// otherwise we were launched because the user touched a notification in the notification tray.
						if(e.coldstart)
							//$("#app-status-ul").append('
--COLDSTART NOTIFICATION--' + '
');
							alert('--COLDSTART NOTIFICATION--')
						else
						//$("#app-status-ul").append('
--BACKGROUND NOTIFICATION--' + '
');
							alert('--BACKGROUND NOTIFICATION--')
					}

					//$("#app-status-ul").append('
MESSAGE -> MSG: ' + e.payload.message + '
');
					alert('MESSAGE -> MSG: ' + e.payload.message);
                    //android only
					//$("#app-status-ul").append('
MESSAGE -> MSGCNT: ' + e.payload.msgcnt + '
');
					alert('MESSAGE -> MSGCNT: ' + e.payload.msgcnt);
                    //amazon-fireos only
                    //$("#app-status-ul").append('
MESSAGE -> TIMESTAMP: ' + e.payload.timeStamp + '
');
                    alert('MESSAGE -> TIMESTAMP: ' + e.payload.timeStamp);
                break;

                case 'error':
					//$("#app-status-ul").append('
ERROR -> MSG:' + e.msg + '
');
					alert('ERROR -> MSG' + e.msg);
                break;

                default:
					//$("#app-status-ul").append('
EVENT -> Unknown, an event was received and we do not know what it is
');
					alert('EVENT -> Unknown, an event was received and we do not know what it is');
                break;
            }
        }

        function tokenHandler (result) {
            //$("#app-status-ul").append('
token: '+ result +'
');
            // Your iOS push server needs to know the token before it can push to this device
            // here is where you might want to send it the token for later use.
            alert('iOS Result = ' + result);
        }

        function successHandler (result) {
            //$("#app-status-ul").append('
success:'+ result +'
');
            alert('Android Result = ' + result);
        }

        function errorHandler (error) {
            //$("#app-status-ul").append('
error:'+ error +'
');
            alert('Error = ' + error);
        }

		document.addEventListener('deviceready', onDeviceReady, true);

alert('regID = ' + e.regid);
alert('Reg code completed');
I can't work out why it is returning the regID as undefined. Has anyone else had this issue?
Any help would be appreciated.

What's version of Cordova are you using? I have very similar problem, however my "onNotification" function is never called at all.

I'm using PhoneGap, version 3.4.0

Just got it to work. I am not sure if it solves your problem, but in my case, push notifications doesn't work on emulator and works on real devices. Silly issue, have read much about push notifications in web, and information provided very unclear. Same things work differently for people.

Can you post your code please? I'm using a real device but I'm still have problems

i have same issue the onNotification function never called.
plz suggest any solution.

Just use a android build with Google APIs and make sure you've downloaded the Play Store features (SDK Manager -> Extras)

I have got a same problem. My onNotification function is never called. I have tried to create virtual device using Google APIs with downloaded all extra features, but this does not helps me. @mroswald could you give a screenshot with AVD settings?

Yeah! For me helps adding an google account in virtual device. Just go to Setttings->Add account, Select "Google" and add your existing google account.

i have the same problem i can show the alert on my device but not a message
have someone issues?
Thanks


create the credential in ADF to use it with User Managed Identity

I dont see a way either through ARM templates or terraform  to create a credential in ADF to use it with User Managed identity when creating a linked service to ADLS

@ssvarian
Thanks for your feedback! We will investigate and update as appropriate.
Since this channel is for driving improvements towards MS Docs, could you provide the URL of the specific documentation that your feedback is applicable to? That way, we are able to make sure your feedback is addressed by the right team

No much information in this document https://learn.microsoft.com/en-us/azure/data-factory/credentials?tabs=data-factory

@ssvarian
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.
@nabhishek
Please review this and update as appropriate.

Thanks for your question to help us improve the docs @ssvarian.  I added an example to the doc at the end with a link to our Bicep/ARM template that creates a user-assigned managed identity and assigns it permissions to a resource.  It will be published in the next publishing cycle in a few hours.  #please-close


9501 Kubernetes and OKE Monitoring and Troubleshooting

9501
General requirements

Information in the workshop is adequate and updated
Code is correct and working
Links are correct
Make sure you enter the help email link in your manifest.json
Please make sure WMS URLs are updated as needed after your PR is approved

Checklist - Refer to the QA document for the complete list
Please confirm that the following is completed before submitting your PR

[x] All filenames are lower case (including folders, images, files, etc.)
[x] Filenames are descriptive
[x] Your workshop folder structure should be similar to the one used in the sample workshop (https://github.com/oracle-livelabs/common/tree/main/sample-livelabs-templates/sample-workshop)
[x] Are you using multiple versions (desktop/, sandbox/, tenancy/)? Make sure that each of them contains a manifest.json and an index.html
[x] Image references in markdown contain an alternate text

.tgz or .zip files are not allowed, please remove them

Please also resolve merge conflicts on your branch. Thanks!

This branch has conflicts that must be resolved
Conflicting files
logging-analytics/oke-monitoring-la/ingestion-flow-setup/ingestion.md

Updated the PR with the changes requested.


Error when URL has a hyphen during Unirest.post

When I am running the following code, it works fine when the URL does not have any hyphen. But when the URL has a hyphen I am getting the below error. Please help.
Code:
HttpResponse authTokenResp = Unirest.post(url)
.header("Content-Type",APPLICATION_JSON)
.body(new JsonNode(authTokenReq.toString()))
.asJson();
Error:
Exception in thread "main" com.mashape.unirest.http.exceptions.UnirestException: java.lang.RuntimeException: java.lang.RuntimeException: org.json.JSONException: A JSONArray text must start with '[' at 1 [character 2 line 1]
at com.mashape.unirest.http.HttpClientHelper.request(HttpClientHelper.java:143)
at com.mashape.unirest.request.BaseRequest.asJson(BaseRequest.java:68)

Did you sort it out?

asJson will throw a parsing error like that whenever the returned body is not valid JSON. Most services do not return valid JSON for non-200 errors like ... 404.  do the same call with asString and check the status code and body, I bet you are not getting back a valid 200. This parsing error has been made more clear in the OpenUnirest fork https://github.com/OpenUnirest/unirest-java

I'll be merging OpenUnirest back in shortly. Taging this for now

Hello, this should be resolved or addressed in Unirest 2. Please see the upgrade guide for important changes.


DSVM improvement - NLTK data download

I noticed that the nltk python package was installed by default in the DSVM, but the nltk data is not downloaded.  The download is not difficult, but time consuming, and it would be excellent if the downloaded data was included in the DSVM package already.  Instructions here: https://www.nltk.org/data.html

@MadDenker Can you please provide us with the Azure Doc URL that you are having issues with? We look forward to your reply.

It is not a documentation issue, it is an issue with the DSVM build and product itself.  If this is the incorrect place to put this, can you point me to where I should post?

@MadDenker We kindly request you to share the details over on MSDN forums. Please click here to take you to the proper forum within MSDN. We have multiple engineers over there who can assist you further on this matter.
For now, we try to keep GitHub scoped to feedback on Azure Documentation. Thank you for your understanding.


Failed to login to remote instance null: Two-Factor Login Required

Bug Report
System Information

Operating System (Including distribution name and version number)
PRETTY_NAME="Ubuntu 22.04.2 LTS"
NAME="Ubuntu"
VERSION_ID="22.04"
VERSION="22.04.2 LTS (Jammy Jellyfish)"

AMP version and build date (Always use the version number, 'latest' is not valid!)
AMP Release "Decadeus"
v2.4.4, built 17/05/2023 17:54

Which AMP release stream you're using (Mainline, Nightly or FastTrack)
Mainline

I confirm:

[x] that I have searched for an existing bug report for this issue.
[x] that I am using the latest available version of AMP.
[x] that my operating system is up-to-date.

Symptoms

What are you trying to do?
Navigate through the AMP web interface at my regular speed.

What are you expecting to happen?
I should be able to navigate through AMP without receiving error messages regardless of the speed at which I click.

What is actually happening?
If I click through the AMP nav menu too fast I receive this error popup:

Reproduction
Using my exact version of Ubuntu Studio linux, you log into AMP game server and immediately goto an instance.
With the new changes, it will load very fast, but once you get into its management screen... if you click on any of the other nav menu items without waiting 10-20 seconds, you will be kicked back to the main ADS01 panel and will receive the 2fa popup error dialogue that states:
Failed to login to remote instance. null
Two-Factor Login Required.
After that point, you will have to wait a short time before you may attempt to re-enter the management interface of any of the instances.
##Error logs
this is a section of my ADS log that details the events during the error:
[14:06:10] [Logger:tbi Activity]  : Managed remote instance UnoriginalIdeaRust-Monthlyvanillanobpwipe01 at http://<IP_ADDRESS>:8081/
[14:06:10] [Logger:tbi Activity]  : Authentication token for tbi requested by ManageInstance on behalf of tbi
[14:07:54] [Logger:tbi Activity]  : Managed remote instance UnoriginalIdeaRust-Monthlyvanillanobpwipe01 at http://<IP_ADDRESS>:8081/
[14:07:54] [Logger:tbi Activity]  : Authentication token for tbi requested by ManageInstance on behalf of tbi
[14:09:17] [Logger:tbi Activity]  : Managed remote instance UnoriginalIdeaRust-Monthlyvanillanobpwipe01 at http://<IP_ADDRESS>:8081/
[14:09:17] [Logger:tbi Activity]  : Authentication token for tbi requested by ManageInstance on behalf of tbi
[14:09:57] [Logger:tbi Activity]  : Managed remote instance UnoriginalIdeaRust-Monthlyvanillanobpwipe01 at http://<IP_ADDRESS>:8081/
[14:09:57] [Logger:tbi Activity]  : Authentication token for tbi requested by ManageInstance on behalf of tbi
[14:10:48] [Logger:tbi Activity]  : Managed remote instance UnoriginalIdeaRust-Monthlyvanillanobpwipe01 at http://<IP_ADDRESS>:8081/
[14:10:48] [Logger:tbi Activity]  : Authentication token for tbi requested by ManageInstance on behalf of tbi
[14:24:41] [Logger:tbi Activity]  : Managed remote instance UnoriginalIdeaRust-Monthlyvanillanobpwipe01 at http://<IP_ADDRESS>:8081/
[14:24:41] [Logger:tbi Activity]  : Authentication token for tbi requested by ManageInstance on behalf of tbi
And here is a section of the instances log I was trying to manage... from the same timeframe when the error occurred:
[14:24:42] [Logger Activity]      : Authentication attempt for user tbi from <IP_ADDRESS>
[14:24:42] [Core Activity]        : Authentication success
[14:24:44] [Logger:Anonymous Activity] : Authentication attempt for user tbi from <IP_ADDRESS>
[14:24:44] [Logger:Anonymous Activity] : Authentication failure for user tbi from <IP_ADDRESS> - TwoFactorChallenge

This is still happening on my linux system, after the most recent update, it's actually even worse.
Now I cannot even use the "manage" option, I have to manage all my instances in a new tab.

Issue persists as of 10th anniversary update v2.4.4

Yup...
I'm actually on v<IP_ADDRESS> and still have the issue.
But here is what I figured out... The issue only happens on Chrome.

The latest update to chrome, and the latest update to AMP v2.4.6 (Yeah, I waited a week to update...), it seems to have solved the issue.
Yeah, I was using amp all day at work with it the issue, got home and updated, and now my dev workstation at home works right again.
I will leave this open for now, and monitor things for the next week.
If all is good, I will close this.

I have discovered this has something to do with the new Google Password Manager and the "Use Windows Hello when filling passwords" setting.
If turned on, you are no longer troubled by the 2fa popup... the only issue is that you have to put your windows login pin every time you want to fill a password somewhere.

Another update,
Previously I had these issues on my Linux chrome installation too.
But upon patching another issue I had with kded5 and docker, it seems to have fixed Chrome and its interactions with AMP as well.
The jist of it is that on my production server, I run a lot of docker applications.
What used to happen when I would stop a docker instance was I would get a keyring popup from kded5 on the desktop that would want me to enter my password after the instance stops.
That's all fine and dandy... But why does it want my password when I'm doing unrelated docker things in the terminal.
Clearly, that was a bug...
I ended up having to go into "System Settings > KDE Wallet", and unticking "Enable the KDE wallet subsystem", effectively disabling the KDE wallet globally.
So after doing that my actual chrome google password manager stopped syncing with my google account, which is fine, but when  I actually log into AMP now... Voila... no more annoying 2fa-popup error when trying to manage instances.

Regarding my Windows development workstation and its Chrome installation, for the time being, I have it set up to prompt for my windows hello pin every time I go to fill in a password.
Kind of super annoying to deal with, but w/e.

What's interesting though is that my Windows 10 workstation at work does not actually have the Chrome option to "Use Windows Hello when filling  passwords"
That workstation does not have a windows hello pin setup, only a password, and the issues still persists on it when I goto manage my amp instances while at work.


API request failed: Bad Request

I am using Graylog 2.4 and plugin version 2.2.0
Graylog server should connect via proxy to access internet (I've set proxy server in alert created).
I got this error in graylog server log
[TelegramAlert] API request failed: Bad Request
Please help how to resolve this issue.
Thank you

I got this on Graylog 3.1.3 when I clicked on Test button. It's not a plugin problem it's a broken test button cause messages are going to chats straight away. You should write something simple in Message field like "Test message" and hit the test button. It should works.

I got this on Graylog 3.1.3 when I clicked on Test button. It's not a plugin problem it's a broken test button cause messages are going to chats straight away. You should write something simple in Message field like "Test message" and hit the test button. It should works.

Could you elaborate more detail? When actual alert condition happened, I check the telegram alert also failed.

I got this on Graylog 3.1.3 when I clicked on Test button. It's not a plugin problem it's a broken test button cause messages are going to chats straight away. You should write something simple in Message field like "Test message" and hit the test button. It should works.

Could you elaborate more detail? When actual alert condition happened, I check the telegram alert also failed.
I'm using default message template
${stream.title}: ${alert_condition.title} ${foreach test message} ${message} ${end}

You could try Test sending instead of yours ${stream.title}: ${alert_condition.title} ${foreach test message} ${message} ${end} in message template and then hit "Test" button. Message should come to tg chat.

Try using the new release. If the issue still persists, feel free to open a new issue.


tfsec not scanning modules

Describe the bug
A clear and concise description of what the bug is.
When I run tfsec, it scanning only resource blocks in the tf files not modules blocks, I am using modules to create resources, instead of direct resource blocks.
To Reproduce
Steps to reproduce the behavior:
.create a modules for any gcp resource in a folder and use that module in another folder by giving public access.
Expected behavior
A clear and concise description of what you expected to happen.
It should scan modules and provide tfsec output that it has scanned modules.
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. iOS]
macOS Monterey 12.1
--
Additional context
Add any other context about the problem here.
I am using yaml file for variables instead of json or tfvars. I am decoding yaml in terraform locals. Please let me know if that is causing the issue.

tfsec --verbose output
[DEBUG][2022-01-24 09:28:22.675334 +0000 WET m=+0.072939626] Loading custom checks...
[DEBUG][2022-01-24 09:28:22.67543 +0000 WET m=+0.073035376] Using the default custom check folder
[DEBUG][2022-01-24 09:28:22.675433 +0000 WET m=+0.073037960] custom check directory set to /layers/00-project-owner/.tfsec
[DEBUG][2022-01-24 09:28:22.675438 +0000 WET m=+0.073043501] Custom checks loaded
[DEBUG][2022-01-24 09:28:22.675442 +0000 WET m=+0.073046960] checking for tfvars files using glob: /layers/00-project-owner/*.tfvars
[DEBUG][2022-01-24 09:28:22.678277 +0000 WET m=+0.075882585] Starting parser...
[DEBUG][2022-01-24 09:28:22.678289 +0000 WET m=+0.075893835] Finding Terraform subdirectories...
[DEBUG][2022-01-24 09:28:22.678371 +0000 WET m=+0.075976501] Found qualifying subdirectory containing .tf files: /layers/00-project-owner
[DEBUG][2022-01-24 09:28:22.678376 +0000 WET m=+0.075981085] Beginning parse for directory '/layers/00-project-owner'...
[DEBUG][2022-01-24 09:28:22.680667 +0000 WET m=+0.078272501] Added 9 blocks from /layers/00-project-owner/main.tf...
[DEBUG][2022-01-24 09:28:22.68069 +0000 WET m=+0.078295043] Added 1 blocks from /layers/00-project-owner/backend.tf...
[DEBUG][2022-01-24 09:28:22.680693 +0000 WET m=+0.078298376] Project root set to '/layers/00-project-owner'...
[DEBUG][2022-01-24 09:28:22.680695 +0000 WET m=+0.078300085] Loading TFVars...
[DEBUG][2022-01-24 09:28:22.680696 +0000 WET m=+0.078301543] Loading module metadata...
[DEBUG][2022-01-24 09:28:22.682127 +0000 WET m=+0.079732293] Evaluating expressions...
[DEBUG][2022-01-24 09:28:22.682198 +0000 WET m=+0.079802960] Starting iteration 1 of context evaluation...
[DEBUG][2022-01-24 09:28:22.682327 +0000 WET m=+0.079932460] Starting iteration 2 of context evaluation...
[DEBUG][2022-01-24 09:28:22.682408 +0000 WET m=+0.080012543] Loading modules...
[DEBUG][2022-01-24 09:28:22.682467 +0000 WET m=+0.080072376] Starting iteration 1 of context evaluation...
[DEBUG][2022-01-24 09:28:22.682534 +0000 WET m=+0.080139501] Starting scanner...
[DEBUG][2022-01-24 09:28:22.683498 +0000 WET m=+0.081103085] Running rule for general-secrets-sensitive-in-attribute-value on locals. (/layers/00-project-owner/main.tf)...
[DEBUG][2022-01-24 09:28:22.683553 +0000 WET m=+0.081157626] Running rule for general-secrets-sensitive-in-local on locals. (/layers/00-project-owner/main.tf)...
times
disk i/o             3.777916ms
parsing HCL          6.833µs
evaluating values    213.167µs
running checks       1.026667ms
counts
files loaded         2
blocks               10
modules              0
results
critical             0
high                 0
medium               0
low                  0
ignored              0
No problems detected!

@lonecoder433  - I'm stuggling to see what could be the issue here? Are you able to post the module definition in layers/00-project-owner/main.tf or an approximation of it so we can see if there is something that tfsec is missing there?

Here is my module definition

Here I am loading my vars through yaml

@lonecoder433 Is your config variable defined as part of a locals block? If you can expand a little on what your code looks like I can replicate the setup here and try to reproduce the issue.


Clear select/enumeration value in admin UI

Is it possible to clear a selected value on a enumeration. For example if I add the following:
        menuItem: { // This is the menu item edit panel.
          link: [ // This is the "link" tab in the menu item edit panel.
            {
              input: {
                label: 'Select one',
                name: 'options',
                type: 'select',
              },
            },
          ],
        },

  const customAttrs = {
    options: {
      type: "enumeration",
      enum: ['option 1','option 2'],
    },
  };

What I want is that a editor/admin could remove the selected value, the same way as on relations where you get an X at the end of the input to clear the value.
Am I missing something or is it not possible at the moment?

Hi @thomasbrunstrom This is actually an issue with the GenericInput component from @strapi/helper-plugin library, which is what the menus plugin is using.
The Strapi Select component does actually support an onClear method but the GenericInput component never passes it through. See this line here in the source code if you're curious.
Sounds like a PR needs to be made for Strapi 👀  Hmm...

I see, thank you for your answer. I'm curious though, in for example relations when editing a content-type the option seems to exist.

I'll have a look if I can find anyway to get it to work without changing anything in Strapi.

If you look at the source code for GenericInput on line 343, you can see the Select component simply does not pass in extra props and therefore won't support the onClear method within the GenericInput component.
I may try to make a PR to fix that in Strapi if I get the time. Just need to get the spare time. 🙂

Ok, to bad they left that option out. Wonder why 🤔
Well, I'm subscribed to this thread, so if you ever find the time it would be awesome if you could post here with any updates.


owner(ticdc): only update epoch when state changes

What problem does this PR solve?

Issue Number: close #8425
What is changed and how it works?
Only update epoch when state changes.
Check List
Tests

Unit test
Integration test

Questions
Will it cause performance regression or break compatibility?
No.
Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note
None

/merge


Add class properties.

New Pull Request Checklist

[x] I have read and understood the CONTRIBUTING guide

[x] I have read the Documentation

[x] I have searched for a similar pull request in the project and found none

[x] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

[X] I have added the required tests to prove the fix/feature I am adding

[x] I have updated the documentation (if necesarry)

[X] I have run the tests and they pass

[x] I have run the lint and it passes (pod lib lint)

This merge request fixes / reffers to the following issues: none
Pull Request Description
This changes some class functions into class properties, making the functions be seen by Swift as properties.

Nice!


Use SEAM_ENDPOINT if defined in docs

Will use the real Seam endpoint (no proxy) on deployment. I suspect we will still want the local dev proxy, but can test that after this is confirmed working.

CORS setup on the API is updated and this is now working!


refactor: use immer in a number of reducers

Description:
Continue migration to immer

How Has This Been Tested?
Manually

Types of changes:
Refactor

Checklist:

[x] My code follows the code style of this project.
[x] I have reviewed and updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes where needed.
[ ] All new and existing tests passed.
[x] My commits have been squashed into a concise set of changes.

Coverage decreased (-0.08%) to 20.106% when pulling d5f4eebe77f63e429293bb135c97fce3d3346e83 on korhaliv:refactor/immer-migration into 230e24c00d01c04352fecbab9d4e8f7cb12dbcad on LN-Zap:next.


radar config parameters

fft range parameter 134 is used instead of 128, any design reason behind this
params.fft_Rang = 134; % 134=>128

Yes, we use 134 points FFT first and then remove the first 3 and last 3 points for eliminating the effects of self-leakage (the transmit signal is directly received on board).


License header in app.conf

Summary:

Fix for the issue raised https://splunk.slack.com/archives/GSZDDN1GF/p1606711001369100?thread_ts=1606482636.366500&cid=GSZDDN1GF

Added dynamic generated License header in app.conf.

:tada: This PR is included in version 4.1.8-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.1.11 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Investigate 3 partests sometimes failing on weekly

run/bitsets.scala
neg/t8266-invalid-interp.scala
neg/t7848-interp-warn.scala

They don't emit the same warnings as what they're supposed to.

I see https://scala-webapps.epfl.ch/jenkins/job/scalajs-task-worker/59616/console
!! 817 - run/bitsets.scala                         [output differs]
% diff /localhome/jenkins/a/workspace/scalajs-task-worker_2/partest/fetchedSources/2.11.5/test/files/run/bitsets-run.log /localhome/jenkins/a/workspace/scalajs-task-worker_2/partest/fetchedSources/2.11.5/test/files/run/bitsets.check
@@ -1,4 +1,3 @@
-warning: there were three deprecation warnings; re-run with -deprecation for details
 ms0 = BitSet(2)
 ms1 = BitSet(2)
 ms2 = BitSet(2)

which is a real deprecation
test/files/run/bitsets.scala:38: warning: method toImmutable in class BitSet is deprecated: If this BitSet contains a value that is 128 or greater, the result of this method is an 'immutable' BitSet that shares state with this mutable BitSet. Thus, if the mutable BitSet is modified, it will violate the immutability of the result.
  Console.println("mi0 = " + ms0.toImmutable)

The t8266 message was changed in 2.11.4. I don't see the test error, though.


🐛 Getting NaN values for MSE in Montevideo Bus

Issue: Getting NaN as the MSE value after epoch = 1 while training a TGCN on Montevideo Bus dataset.
How to replicate error: Run the v1.1.0 test script for temporal_tgcn_dataloaders testpack. Inspect the outputs folder for Montevideo Bus to view the MSE values

Current Findings

The gradient for all the bias and weight parameters present inside the TGCN is NaN except linear2.weight and linear2.bias
This is only noticed in Montevideo Bus dataset and for none of the other datasets

I have attached a log file displaying the gradient value of each parameter and the parameter values for the first epoch. The cost has also been displayed at the beginning for each iteration within the first epoch.
Montevideo_Bus.txt
How to Proceed
Learn how gradients are calculated. Possibly look at forums to see what others have posted.

Things To-Do

[ ] Address and try to run the script a bit faster
[ ] Modify train.py so that we are using the right node features to train the model for all datasets
[ ] Make sure we are passing the right node features value to train.py. Maybe have an attribute called num_node_feats for all datset loaders
[ ] Add the model parameters info to the benchmark_tools module. Name it to tools instead of benchmark_tools


x509: certificate signed by unknown authority when downloading TKG compatibility file

Bug Report
Getting x509: certificate signed by unknown authority when downloading TKG compatibility file via Tanzu CLI on Windows.
Expected Behavior
Tanzu management cluster UI would open when running tanzu management-cluster create --ui
Steps to Reproduce the Bug

Download the tce-windows-amd64-v0.9.1 release
Launch install.bat via Administrator powershell
Add Tanzu install path to system path
Execute tanzu management-cluster create --ui

Screenshots or additional information and context

Environment Details

Build version

version: v0.2.1
buildDate: 2021-09-29
sha: ceaa474

Deployment (Managed/Standalone cluster): Didn't even get this far.
Infrastructure Provider (Docker/AWS/Azure/vSphere): Didn't even get this far.
Operating System (client):

Windows 10 x64
Windows Server 2019 Standard

Diagnostics and log bundle
Willing to provide if I knew how.

Hi Alvin! Just to check, have you gone through all the steps here: https://tanzucommunityedition.io/docs/latest/ref-windows-capd/#local-docker-bootstrapping
This sounds like the insecure-skip-tls-verify issue documented there.

Hey @stmcginnis ,
No, my end-goal is to deploy to vSphere. I'm just bootstrapping from Windows.
Unless all of this is required to do so? I was under the impression those steps are for deploying Tanzu clusters on Windows.

Hey Alvin!
yes, we need to document this for Windows.
you’ll find how to workaround this issue here: https://github.com/vmware-tanzu/community-edition/issues/1398
that should get you unblocked. Let us know!

Hey @joshrosso ,
Thank you - I've confirmed that the workaround from #1398 works on both Windows 10 x64 and Windows Server 2019 x64.
Since this looks like it's been around for a while (and because I've managed to reproduce it on almost all Windows machines I own), I've opened PR #2143 to add this to our FAQ.


Fix forkedblockchain.js, correctly handle buffer encoded hash values

In forkedblockchain.js, some cases (ex: debug_traceTransaction) getBlock is passed a buffer as a value of a hash, this crashes ganache as we expect the hash to be a hex encoded string.

Closing in favor of https://github.com/trufflesuite/ganache-core/pull/396
I tried to fix too much in this PR and will be cherry picking parts from it


Is there any plans to add support for latest ROS release, Jazzy Jalisco?

Is there any plans to add support for latest ROS release, Jazzy Jalisco?
If there is, if I could ask, in what time period?
Thanks in advance.

Yes there is plans, we will start working on that in next days.


Update ANO-R basis sets

Closes #211

Codecov Report

Merging #225 (ecfa579) into master (e6e7e21) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

:exclamation: Current head ecfa579 differs from pull request most recent head c4f8e6f. Consider uploading reports for the commit c4f8e6f to get more accurate results

@bennybp tests clean please merge


SES Enhancement Adding  get_send_statistics,create_configuration_set functions.

https://github.com/localstack/localstack/issues/909
Enhancement Adding SES get_send_statistics,create_configuration_set functions.

localstack/localstack#909
Enhancement Adding SES get_send_statistics,create_configuration_set functions.

@bblommers  Need your help here in getting this merged.Can you please help.

Coverage increased (+0.008%) to 94.175% when pulling 440213f854c2f77ce6e382cc0dd3edb6631cdae1 on usmangani1:LSTACKISSUE909 into 4af10fe56beb9bdfc073756f5f73ad1a6a707c06 on spulec:master.

localstack/localstack#909
Enhancement Adding SES get_send_statistics,create_configuration_set functions.

@bblommers Need your help here in getting this merged.Can you please help.

@bblommers can u help me here please ?

Hi, can I know which version is the minimum requirement to use this feature?

Hi @TonyZZX, the full list of versions can be found here: https://pypi.org/project/moto/#history
Considering this was merged on the 4th of May, it should be available as of moto >= 1.3.15.dev815


Implement Controller to reconcile Control Plane API

Describe the solution you'd like:
Implement Controller to reconcile Control Plane API
Why do you want this feature:
Necessary as a part of the Control Plane provider

Fixed in #60


plugin: hacky fix for null reference errors on FFXIV process exit

It isn't neat but it should catch all the attempts to access null variables with the new LimitedProcess wrapper.
Feel free to reject this :P I just thought I'd get something up that "works".

Fixed this differently.  Thanks for the speculative pull request though, thanks!


docs: Kubernetes master deployment documentation doesn't mention Flannel's expected TLS dir

Through trial and failure I found out that Flannel expects TLS certificates to exist in /etc/ssl/etcd (systemctl cat flanneld will show this), but this is mentioned nowhere in the documentation.

related: https://github.com/coreos/coreos-kubernetes/issues/104


UINavigationController transition only effect special viewController

UINavigationController transition only effect special viewController，When do the best

Not sure what you meant. Can you elaborate? or write it in Chinese.

我想转场动画只在UINavigationController  push到某个特定的ViewController的时候生效，我应该怎么设置呢？


Storage: fix a small bug in RemoveAllButCurrent when the directory is invalid

filepath.Walk can return a nil for the stat value, when it does, the
directory is invalid and the error will be set. This causes a
panic+crash if the directory does not currently exist when
RemoveAllButCurrent is called.
The following patch makes the behavior an error instead.
Signed-off-by: Erik Hollensbe<EMAIL_ADDRESS>

What got me here was a mass deletion of multiple CRDs with one SHA+repo combination. I think it may be a bug that surfaces itself differently when this is patched. Just FWIW.


[DBCluster] Add DBClusterResourceId as read-only attribute

Issue #43: Include DbClusterResourceId as accessible attribute of DbCluster
Add the DBClusterResourceId as an attribute that can be read by GetAttr. This is required by certain operations which currently require workarounds.
This supersedes my previous pull request.
Notes:

Currently has no test associated with it, as I couldn't see any place to add one.
Included updates to generated docs folder, but ignored a bunch of erroneous whitespace.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@karaken12 hey, thanks very much, the change is much appreciated. The commit is looking good, I have no immediate concerns about it.
We need to hold the merge for a bit in order to clear all the blockers to get it generally available in all commercial regions. Hence, no further changes are expected in this PR. The team will merge it later on and inform the PR upon its availability in all commercial regions.
Thanks again!

@khebul This pr seems to be ready. Could you please schedule it up for a merge whenever the team is feeling comfortable. Thanks.

@karaken12 the change has been deployed globally. I see the relevant changes in the resource schema: https://schema.cloudformation.us-east-1.amazonaws.com/aws-rds-dbcluster.json (please change the region and inspect the schema if you are using a different region).


smartimage neural network to detect best answers

Like randomimage, but detects whether it was a good or bad response based on previous responses.
Like:
"mb.smartimage how are you doing?"
I FEEL GOOD image
"Haha!" # detected as good response
Or:
"mb.smartimage how are you doing?"
picture of a car
"what" # detected as bad response
We can also use randomimage responses to train it.

AWS Comprehend

I don't totally like this, cuz I see it repeating images that the user liked at first, and then they get bored of it. Wontdo.


check for gitpath before starting to read revision list from vss

This is a useful change to make, but the code is not suitable as-is and needs refactoring. I don't like the unconditional return from a while loop (should be an if statement) and the fact that there's a redundant check in GitExporter.

I'm closing this for now, but it can be reopened with an updated patch.


Set tidy_xml as the default formatter for SVG files

SVG is just XML + namespace, so tidy_xml is a good default formatter for
SVG files.

Thanks!

@mqudsi Before I forget, would you care to add an entry to the README for this new feature, similarly to what is done for other formatters?


8963 add exceeded quota event

Fixes #8963
Please CR @javitonino

Ship it when :green_apple: !

Fixed some typos! have another 👀 please!

Fixed some typos! have another 👀 please!
cc/ @jmartinter

LGTM!

@javitonino : we found another place were the raise is done and also noted that the exceeded quota can be computed from there. Please have another look 👼

I left a comment. :ship: ready after considering that.

Ok @javitonino @jmartinter
I've tested this last version and it works for:

Import
URL
Datasource:

Dropbox
Google Drive
Box

I've basically extracted the quota checks that were performed in various places (downloader, datasource_downloader, runner) and put it in a helper so they all consume the same method (this is were i've taken the opportunity to storage quota exceeded as well).
For that part, we will need a data services person to have a look! @jgoizueta, care to do the honours? :)
Be advised, this will probably be deployed the first week of August when I come back from vacation.
Regarding that last topic: @javitonino if you see it fit and feel confutable with this code, deploy it if you want to once we all agree it's good enough 😁 .
Thanks to all of you!

Tested some cases and seems ok for me.
Anyway, let's wait for Guido to return in order to deploy it.

I took a look and left only a minor comment, up to you what to do about it. And I see some tests are broken.
All in all, good job! :+1:

It seems some test code relied on no-quota set users. Instead of changing the test behaviour, I simply respected the previous decision of not checking if available_quota_in_bytes is nil. This is up for revision of course, but the time and scope is not now or this one.
I'll ping for a small CR when 🍏
Thanks for the comments @javitonino and @jgoizueta

:+1:


Improve Xml_Array class to recognize multi-line tags

Tags on multiple lines are not recognized:
<hook reverse="true"
    hook="integrate_load_theme"
    file="SOURCEDIR/ThemeSelector.integrate.php"
    function="ThemeSelector::load_theme" />

They should because are valid XML and in certain cases are more readable.

Or... just get rid of it and replace it with a standard PHP class: http://php.net/xml

Yeah, good point.


Hover state for adding new cells is hard to find

During the Python user studies we discovered that some users had a hard time finding the add new cell toolbar at the bottom However, once they discovered it they really liked the position of it. We should explore to see if we can improve this discoverability. A few ideas below:
1. Increase the hover target
We can try to increase the vertical hover target to allow users to trigger this. We'd need to be cautious to make sure this can work with interactive elements above it like the status bar.

2. Always visible on hover
Similar to our cell toolbar, but this adds visual noise while making it highly discoverable. The other cells can still be triggered on hover.

Increased the hover range so that it covers the whole area between cells, and some equal extra space above the actual toolbar. We can see how this feels.


define arbitrary scripts in module.json

As you probably know, npm has the concept of scripts defined in their package.json, This extensibility allows the community to create and test new functionality without having to necessarily upstream it.
https://docs.npmjs.com/misc/scripts
For instance, Im not sure whats planned for uploading code, all the current docs say to drag and drop.
Obviously a cp build/target/source/blah.bin /Volumes/Mbed would work nicely but it would be better if that was behind an yt upload' which was an alias for yt run upload`
This would seem related
https://github.com/ARMmbed/yotta/issues/234
Just curious what the temperature is on this. We the public dont get to see any roadmap talk so hard to know whats welcome.

i asked for yt upload, but they didn't seem too keen on that.  One could use mbed-ls to achieve a (mostly) platform agnostic way to find the mounted mbed device

:+1: to more scripts, especially if it allows yotta upload or yotta run (possibly more appropriate name for non-cross-compiled targets)

Hey my PR #738 was closed as duplicate functionality, yet the PR that closed it specifically mentions my intent was not duplicate. Why would user defined scripts not be included especially when I've already written the code?

Seems like @autopulated thinks my only use case was yt run for module execution? I would like to ensure you thats not the case. For instance I have scripts that release code to an amazon s3 bucket and I in no way want that done every build on one of the preexisting hooks.


--onlyDirectDependencies option returns 0 results if package.json is missing a 'name' property

This may be a bit of a unique scenario but I ran into an issue using npm-licence-crawler with an Expo project I am working on. I thought it would be relatively straightforward as I was following an article from the expo blog: https://blog.expo.io/licenses-the-best-part-of-your-app-29e7285b544f
I found that when running with the --onlyDirectDependencies option, I would always get 0 results. Running with the --dependencies flag returned a large number of results as expected.
I checked the code and determined this was because my package.json has no "name" property. Confirmed that adding a "name" property allows me to get results.  My package.json file is this way because by default an Expo project is created with a package.json file that has no "name" property. Instead there is a name property put into an app.json file. Not sure if this has changed since the linked article was written.
I don't know if there are other node projects that could potentially be setup in a way that they would not have a name property so this might just be something people using expo need to watch out for. But perhaps its a scenario that could be handled somehow?

Thank you very much for your report. I'll check if it is possible to add a tweak to support Expo projects. Strictly speaking package.json file must have a name property as far as I understanding this, see https://docs.npmjs.com/files/package.json

@EvanBacon Apparently, a new Expo project is created with a package.json file that has no "name" property by default. Instead there is a name property put into an app.json file. Did you also experience this behavior at the time of writing and what is your view on this? My understanding is that a package.json descriptor shall have a name assigned, see https://docs.npmjs.com/files/package.json

Any updates on this?

I was able to get around this by adding a name and version properties to my package.json. i.e.
{
   "name": "app-name",
   "version": "1.0.0",
   ...
}

@Kiesco08 's solution worked for me.


Python: Coverage configs

Motivation and Context

Updated coveragerc and mypy files in prep of spike
Moved Text tests into single integration test setup
Description

Contribution Checklist

[x] The code builds clean without any errors or warnings
[x] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[x] All unit tests pass, and I have added new tests where possible
[x] I didn't break anyone :smile:

Python 3.10 Test Coverage Report • FileStmtsMissCoverMissingTOTAL668678188% report-only-changed-files is enabled. No files were changed during this commit :)
Python 3.10 Unit Test Overview

Tests
Skipped
Failures
Errors
Time

1567
1 :zzz:
0 :x:
0 :fire:
18.502s :stopwatch:


[$500] Chat - Flag emoji appears broken after adding a dash emoji next to it

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Launch New Expensify app
Go to composer
Add any flag emoji via the emoji picker
Add a second emoji via the emoji picker

Expected Result:
The emojis are not broken
Actual Result:
The flag emoji is broken
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.64-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/43e3862d-0c89-40cb-9c49-7ff6eeac6941
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0148516b71f9640bc4
Upwork Job ID:<PHONE_NUMBER>181237248
Last Price Increase: 2023-09-26

Same, this is working fine for me!
https://github.com/Expensify/App/assets/54866469/ec167c83-1ce1-4be6-a66d-7d0911cce976

Closing as this isn't reproducible!

Issue is still reproducible by the tester from applause and By contributor @dhanashree-sawant. https://expensify.slack.com/archives/C049HHMV9SM/p1695035857569269
Reopening the issue

Key to reproduction is there shouldn't be space after flag emoji

Going to re-triage today.

I still can't reproduce this on my end using a Pixel 6, and when making sure to delete any space between the two emojis:
https://github.com/Expensify/App/assets/54866469/9cf7a635-8889-4960-8642-1ceab8075271

Discussed here, and narrowed down that this only happens if you select the flag emoji and another one via the emoji picker. If you select the emojis with colons, then this doesn't occur. I can reproduce this via the emoji picker!

@Krishna2323 ah, is this just a duplicate of that issue?

Got it. If this is dupe of that issue, then IMO we'd just close this one. I don't think we need to leave it open personally.

Cool cool, closing as this is being fixed in the above linked issue!


Round output values

Summary by CodeRabbit
Release Notes

New Features

Introduced a decimal_places method for both Bitcoin and Fiat currencies, providing detailed decimal precision information.
Added a round_value method to ensure accurate rounding of currency values based on decimal places.

Bug Fixes

Enhanced output value calculation for single currency outputs, ensuring proper rounding behavior based on user input.

Tests

Added new tests for validating the rounding behavior of output amounts and updated existing tests for input validation.

Fixes https://github.com/gcomte/bitcoinvert/issues/146


Feature Request: Double tap on the screen (!!not apple pencil, which is not currently possible!!) to toggle between eraser and the active tool while working with ipad

Recently, I have been thinking about how to make toggling the eraser on the iPad more convenient, given that the double tap with Apple pencil doesn't work in excalidraw #5431 .
I wonder whether it's possible to use double tap on the screen(or a a two-finger double tap) to toggle between eraser and the active tool.
Alternatives I've considered
I have learned that "E" toggles between the eraser and the active tool. So a feature that allows to assign finger gestures with hotkeys will do the work.

Support this, as I'm on Samsung Galaxy Tab, and the pen is also not standard


Improve "tabs" displayed on various pages

Some pages (e.g. Part view) are getting a lot of tabs which are becoming cumbersome to display.
A better idea is to display them on the side of the page, as icons with optional expandable text.
For example OpenProject:

Also could overlay the "badge" to the icon, much like the old email counter for gmail (e.g.)

https://bootstrapious.com/p/bootstrap-sidebar


Critical injuries - 'character' type actors

Hello there,
I have started using this wonderful module not so long ago but what seems like an issue is mysterious to me.
I created the critical injuries items and the roll table as described in the wiki but I cannot assign a critical injury to an actor.
It says : "Critical injuries can only be added to 'character' actor type".
The actor is indeed a ' character' type.
Thank you :)

Experiencing the same issue.

what Foundry and system versions are you using?

Foundry: Version 10 build 288
Star Wars FFG: 1.80 alpha 3
Both updated via the Foundry client.

Foundry: Version 10 build 288 Star Wars FFG: 1.80 alpha 3
Both updated via the Foundry client.

Same, all module up to date, triple checked each time. Bug is repeatable.

Just for information, Star Wars FFG is not completely ready for Foundry V10. Wrycu is working very hard getting it functioning for V10 but as noted in the SWFFG version, it is in Alpha and not ready for currently running games. Testing helps find all issues to be addressed but if you want a properly functioning system to run a game, using V9 is recommended with an older version of the SWFFG. (If you already knew this info, ignore this message).

fixed in above commit


Making auto_chunk_size execute the given function using the given executor

flyby: adding sync_execute to parallel_executor and parallel_aggregated_executor

@McKillroy this should fix your issue with the wrapping executor not being invoked when the auto_chunker is used. This however requires that you implement the sync_execute method on your executor.

It seems to work for me now - I could compile the PR,
and switching back to the autochunker worked again as expected
with the example thread hook enabled executor.
The lambdas were executed correctly before the chunks and sync_execute was called.
Nice work and thanks a ton ! :D

Is this ready to go?

Is this ready to go?

It is ready to go. Thanks!


Add debugging to While Rule popping

Add debug print to While condition popping, add support functions needed
to BeginWhileRule class.
This makes debugging with BeginWhileRules just a bit easier.  It makes it definitive which While rule popped, if any, and makes the debug output more consistent.

Thank you!


Update the Policy CRD to contain the spec.copyPolicyMetadata field

This also syncs other changes.
Relates:
https://issues.redhat.com/browse/ACM-1690
Signed-off-by: mprahl<EMAIL_ADDRESS>

/cc @dhaiducek


No logging within FOR loops in threads

A 'Log' keyword is placed within a FOR loop of a thread:
THREAD    TEST_THREAD_1     False
   FOR    ${index}    IN RANGE    0    5
      Log     I am TEST_THREAD_1
   END
END

In debug logfile only the start and the end of the keyword is logged, but not the message itself:
INFO - +------- START KEYWORD: BuiltIn.Log [ I am TEST_THREAD_1 ]
INFO - +------- END KEYWORD: BuiltIn.Log (0)

Hi @milanac030988 ,
can you please look into this with high priority.
Thank you,
Thomas

Fixed by https://github.com/test-fullautomation/robotframework/pull/86

Integrated in Robotframework AIO 0.13.0


Use pytest conventions consistently

~Adopt parametrized tests.~ Will do this in a later PR.
Remove all uses of unittest and unittest.TestCase.
Use plain assert instead of assertEquals, assertGreater etc, per the pytest guideline.
Rename setUpClass to setup_class. The former was used by unittest, and the latter is the correct spelling in pytest.
Replace all occurrences of assertRaises with pytest.raises. This way, we can use natural notations for function calls.

Note to reviewers: Ignore whitespaces for a small diff.

Since this PR is getting big, I will remove parametrized tests from this PR and save them for a follow-up PR

@trivialfis Can you review again? I've remove all parametrized tests for now.

LGTM given the tests pass.

@trivialfis Can you review the revised test_slice? I revised it to test the exact semantics of slicing and not rely on randomness.

Codecov Report

Merging #6337 (6a33064) into master (c763b50) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6337      +/-   ##
==========================================
+ Coverage   79.94%   79.97%   +0.02%
==========================================
  Files          12       12
  Lines        3476     3476
==========================================
+ Hits         2779     2780       +1
+ Misses        697      696       -1

Impacted Files
Coverage Δ

python-package/xgboost/core.py
80.57% <0.00%> (+0.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c763b50...6a33064. Read the comment docs.


[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
I am injecting a wasm plugin for envoy in the istio 1.18 environment. During the stress test, the following error occurred. I didn't implement on_log in my wasm code, and there are no other recursive calls. I am very confused about the reason for this error.
error envoy wasm external/envoy/source/extensions/common/wasm/wasm_vm.cc:38   Function: proxy_on_log failed: Uncaught RangeError: Maximum call stack size exceeded    thread=87

When this error occurs, it seems that the thread will continuously display the "wasm_fail_stream" and "http2.remote_reset" error, and the request will return a 503 response. It seems that it will never recover.
POST /infopb.InfoService/Upsert HTTP/2" 200 - wasm_fail_stream - "-" 1257 0 1167 - "-" "grpc-go/1.59.0" "698b416f-e3ee-4f8e-b579-d563d7c37b59" "infosvr-mesh:5000" "<IP_ADDRESS>:5000" outbound|5000||infosvr.perf-master.svc.cluster.local <IP_ADDRESS>:47728 <IP_ADDRESS>:5000 <IP_ADDRESS>:51304 - main

"POST /infopb.InfoService/Upsert HTTP/2" 503 - http2.remote_reset - "-" 236 0 5000 - "-" "grpc-go/1.59.0" "4855afb2-9561-4231-95e0-4ae8806238f6" "infosvr-mesh:5000" "-" outbound|5000||infosvr.perf-master.svc.cluster.local - <IP_ADDRESS>:5000 <IP_ADDRESS>:51304 - -

Version
❯ istioctl version
client version: 1.14.1
control plane version: 1.18
data plane version: 1.18.5 (2354 proxies)
❯ k version
Client Version: v1.28.2
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.24.4-tke.10-rc1

Additional Information
No response

cc @kyessenov

I'm not sure, could be some corruption inside Wasm.

@kyessenov I think I found the reason. Before the wasm encounters an "Uncaught RangeError", there are many "too_many_premature_resets" errors. I tried searching the code and saw that it would close the connection here. I'm not sure if it's because the connection is closed and then a large number of streams are disconnected, causing the wasm stack to overflow. So I turned off the "envoy.restart_features.send_goaway_for_premature_rst_streams" feature, and then retested the pressure. Miraculously, the error disappeared.

I'm not sure if the frequent closing of streams would trigger proxy_on_log and proxy_on_done, causing a stack overflow. I hope you can help analyze this.

Is there any progress?
@kyessenov @PiotrSikora

@LugiaChang is your Wasm plugin written in Javascript by any chance?

@LugiaChang is your Wasm plugin written in Javascript by any chance?

no, by rust and tinygo

Hm, in that case, I think v8 is throwing the error; in my experience, RangeError comes from Javascript world. I think what is happening is that your stress test looks too much like rapid reset, so Envoy is closing the connections. proxy_on_log is apparently called after VM/sandbox teardown which you would expect during a connection/stream reset. The v8 impl dispatcher may not be reentrant with such a high number of calls such as would occur during a stress test. It's also possible that the logging and shutdown code may trigger an infinite loop of some sort

Hm, in that case, I think v8 is throwing the error; in my experience, RangeError comes from Javascript world. I think what is happening is that your stress test looks too much like rapid reset, so Envoy is closing the connections. proxy_on_log is apparently called after VM/sandbox teardown which you would expect during a connection/stream reset. The v8 impl dispatcher may not be reentrant with such a high number of calls such as would occur during a stress test. It's also possible that the logging and shutdown code may trigger an infinite loop of some sort

Thank you for your answer. Based on your experience, would replacing the V8 engine with another engine be helpful?

IMO, I wouldn't worry about this too much from a production perspective. Unless someone is trying to DoS you, you probably won't trigger the conditions for this. We should definitely investigate on the proxy-WASM side, but I doubt real traffic would trigger this behavior

IMO, I wouldn't worry about this too much from a production perspective. Unless someone is trying to DoS you, you probably won't trigger the conditions for this. We should definitely investigate on the proxy-WASM side, but I doubt real traffic would trigger this behavior

I am worried that it might be triggered in a production environment, especially when an Envoy worker thread is fully loaded. Because our downstream service only established one gRPC connection before, all requests would be accumulated to one Envoy worker thread, resulting in a large number of too_many_premature_resets. When we used the gRPC connection pool, this situation was alleviated. However, it's just a mitigation, and we are still concerned that some scenarios might still cause this problem, as it is ultimately a ticking time bomb-like bug.

Well the issue is that your stress tester is sending too many resets too quickly; regular service traffic shouldn't be resetting that soon

When I create multiple grpc conns, there will be no too many resets, and the load of the Envoy threads seems to be more balanced. So I am wondering if a single thread is overloaded and cannot process new streams in time. When Envoy starts processing the stream, it may have already received the RST_STREAM sent by my grpc client due to the timeout?


⚠ vk-s has degraded performance

In 2fa9ef6, vk-s ($VK_API_STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 12791 ms

Resolved: vk-s performance has improved in 3bf6f06.


GET http://localhost/vendor/canvas/assets/js/frontend.js net::ERR_ABORTED

Hi! I have a problem in my canvas.
GET http://localhost/vendor/canvas/assets/js/frontend.js net::ERR_ABORTED GET http://localhost/vendor/canvas/assets/css/frontend.css net::ERR_ABORTED GET http://localhost/vendor/canvas/assets/css/frontend.css net::ERR_ABORTED GET http://localhost/vendor/canvas/assets/js/frontend.js 404 (Not Found)
Please help me.

I don't think vendor is publically accessible by default. Not sure why that's happening. Is there a vendor publish command linked with canvas?

Thanks for helping out @Acen.


When having a selected value, focussing the field which is lower than the top scroll causes the X mark and dropdown items to pop up at the top of the scrollview

When having a selected value once, focussing the field which is lower than the top scroll causes the X mark and dropdown items to pop up at the top of the scrollview.
Image how it's supposed to work:

Image after selecting a value once and re-focussing:

Do you have body scroll? You can't have body scroll in React Native Web apps

You should use it inside a

Hmm I have the same problem now :-D

Nevermind, it was because expo does allow body scroll by default. You should be fine by something like this in your css
body,html,#root{min-height:100%;height:100%;max-height:100%;overflow:hidden;}
And use a ScrollView for the elements

For expo users, wrap your whole app in a custom View
export default function App() {
  return (
    <View
      style={
        Platform.OS === 'web' ? { flex: 1, maxHeight: '100vh' } : { flex: 1 }
      }
    >
      <PaperProvider>
        <AppInner />
      </PaperProvider>
    </View>
  );
}

Please update to v0.2.0, I think I fixed the issue you are describing by recalculating the position if the user clicks the element

Thanks for the updates, it seems to work fine using a scrollview and the View wrapped around the App component, but there is one new problem now:
When having the autocomplete focussed, it's impossible to scroll.
Video:
https://youtu.be/0yGnSWfeleM


Question: How to make a systemd service with pigallery2?

Hi there,
In order to make a systemd service on my Debain 9 NAS with pigallery2 I tried to use the pm2 package according to the tutorial of digitalocean. Unfortunately, I failed. I must admit that the node npm world is rather new for me. However I tried "pm2 start node /my_directory/pigallery2/backend/index.js" but it threw errors. Perhaps someone could offer me a hint or a more suitable tutorial? Thanks in advance.

Hi,
Unfortunately pigallery does not work with pm2. (PM2 is basically an instance/process manager for node, and pigallery manages its own instances).
There was an issue (#42) about the same topic earlier. You can try reading that one:
https://github.com/bpatrik/pigallery2/issues/42#issuecomment-458340945.
Short: I recommend running the app with systemctl on port like 3000 and using nginx as reverse proxy for that.

Thanks Patrik for the hint with #42 , I will try that. Just one question towards the reverse proxy. I thought I would skip that part due to the fact that my pigallery use case is restricted to to a LAN, so no WAN/Internet connections to pigaller2 are intentend. So is there any need of pigallery2 for a reverse  proxy besides anonymisation, load balancing, etc?

Hi
As far as I understand nginx helps for:

decreasing the load on node (well nginx is a heavily optimized app, while node runs javascript)
a recommended way of having HTTPs
hides your node, so probably better for security purposes

But if you only run it LAN for 1-2 users. you don't really need nginx.

Thanks Patrik for clarification.


Extract color decisions to graph-display module

The graph module is too big. Extract all the color related decision logic to a graph-display module, or maybe call it graph-color.

This may no longer be required because of #31 , display logic will be handled in the Node custom element viewModel.

Resolved by #31


Created SDK Client to interact with OpenSearch

Description
Created SDK Client to interact with OpenSearch for request calls required by the extensions. Once #20 is done, the next step would be to integrate SDK with the feature/extensions branch of AD to convert the AD plugin to extension. This client will help us to make the API calls from AD extension to OpenSearch.
Build will fail as https://github.com/opensearch-project/OpenSearch/pull/4197 should be merged first
Issues Resolved
Closes https://github.com/opensearch-project/opensearch-sdk/issues/66
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock thats a good question.
SDK uses RestAPIs to talk to OpenSearch instead of using traditional internal client built by OpenSearch and handed over to plugins[1].
Do you think the java client would ever need to use the SDK?
[1] https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/plugins/Plugin.java#L141

I can't come up with an example, I came from an angle of wanting the SDK to have its dependencies to a minimum, but I suppose until I have a good reason things should remain as is ;)


Rank claiming not working

At this point, I have gotten enough pokemon to complete 10% of the pokedex. I got the rewards from the Great Rank, but not the rank tag for chat itself nor the ability to use its weekly kit. It would very much be appreciated if something could be done about this.

This issue should now be fixed but if not, please contact us via our Discord to ensure we can address it as soon as possible :)


How to add new Layer in this repo

i'm trying to convert the Gamma pose model into ncnn by using this repo, still getting struggle while converting cus some of the layer got defined by the authors not from the library

I'm very surprised that this project is still working.
Send me a model with random weights, I'll see what the problem is

Thanks you very much man
Here is link to the weight Download_link, i'm using weight from this repo Link_to_repo, while i encountering this error:

/usr/local/lib/python3.10/dist-packages/keras/src/layers/core/lambda_layer.py in (video)

NameError: Exception encountered when calling layer "lambda" (type Lambda).
name 'frame_func' is not defined
Call arguments received by layer "lambda" (type Lambda):
• inputs=tf.Tensor(shape=(None, 51, 100, 100, 3), dtype=float32)
• mask=None
• training=None
And here is the frame_func function that from the repo:

import tensorflow.keras.backend as K

def tf_frame_diff(video):
return video[1:] - video[:-1]
def tf_frame_dist(video):
video_diff = tf_frame_diff(video)
return K.sqrt(K.sum(K.square(video_diff), axis=-1, keepdims=True))
if WEIGHT_CURRENT:
def tf_frame_diff_dist_combined(video):
video_diff = tf_frame_diff(video)
video_diff_current = tf.nn.relu(-video_diff)
video_diff_next = tf.nn.relu(video_diff)
video_diff_next_norm = K.sqrt(K.sum(K.square(video_diff_next), axis=-1, keepdims=True))
return K.concatenate([video_diff_current, video_diff_next_norm])
else:
def tf_frame_diff_dist_combined(video):
video_diff = tf_frame_diff(video)
video_diff_current = tf.nn.relu(video_diff)
video_diff_prev = tf.nn.relu(-video_diff)
video_diff_prev_norm = K.sqrt(K.sum(K.square(video_diff_prev), axis=-1, keepdims=True))
return K.concatenate([video_diff_current, video_diff_prev_norm])
frame_func_dict = {'frame_diff': tf_frame_diff, 'frame_dist': tf_frame_dist, 'frame_diff_dist_combined': tf_frame_diff_dist_combined}
frame_func = frame_func_dict[FRAME_FUNC]


Scripts and automations not sorted with custom default_view

Home Assistant release (hass --version): 0.40.0 (running in Docker on Synology NAS)
Python release (python3 --version): Python 3.5.3
Component/platform: Not sure
Description of problem:
If using a custom default_view scripts and automations are not alphabetically sorted anymore.
The order seem to be random after each restart of HASS.
Example 1:

Example 2:

It's still an issue i 0.44.2

Solved in 0.46


Error: Cannot find module './clipboard-action'

It looks like in the dist/vue-clipboards.js there's  require of './clipboard-action' which doesn't exist.

there is dependencies for clipboard.js, you can try install it.
npm install clipboard --save


Add privacyDelete and privacyAccess actions to HygieneOps original PR 1787

Add new actions to the HygieneOps dataset to support Privacy Service operations.
https://jira.corp.adobe.com/browse/PLAT-170201 "XDM: Update Hygiene Ops Schema to Support Privacy Access"
https://jira.corp.adobe.com/browse/PLAT-170199 "XDM: Update Hygiene Ops Schema to Support Privacy Delete"

Re-open after CLA signing.


Delete 04Inference/02Mobilenet/02CNN.md to Fix the 404 error in  chapter 4.2.2

there is a confliction between 02CNN.md and 02Cnn.md when export them to Html, which cause the 404 error.

close


feat(nexus): implement child operations for v1 nexus

@shubham14bajpai @tiagolobocastro @mtzaurus Can you take a look at this PR?
Also, can I get a bors d+

bors try

bors try

bors merge


Merge master in next

:tada: This PR is included in version 1.1.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix mineral pickup from frackers

Haulers were traveling to the mineral, not to the frackers themselves.

This Pull Request has been merged by GitConsensus.
Vote Totals

Yes
No
Abstain
Voters

3
0
0
3

Vote Breakdown

User
Yes
No
Abstain

tedivm
✔

dragoonreas
✔

screepas
✔

Vote Results

Criteria
Result

Has Quorum
True

Has Votes
True


ensure gpad2.0 produced by the pipeline

[x] Makefile in go-site/pipeline should pass "2.0" instead of default "1.2"
[x] GpadWriter in ontobio/bin/validate.py should pass "2.0" instead if default
[x] GpadWriter in ontobio/bin/validate.py should write noctua extensions directly

confirmed all three of these tasks are behaving as expected and we produce GPAD 2.0 at the end of the revised pipeline.


17049 - migrate RadioButton to PressableWithFeedback

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/17049
PROPOSAL: https://github.com/Expensify/App/issues/17049
Tests

[DEV] I think the simplest way to test it, without the account with a wallet, is to hardcode questions. You can do it by changing these lines in AdditionalDetailsStep.js:

        if (!_.isEmpty(this.props.walletAdditionalDetails.questions)) {
              ...
        }

to:
        const questions = [{answer: ['1251', '6253', '113', 'None of the above', 'Skip Question'], prompt: 'Which number goes with your address on MASONIC AVE?', type: 'street.number.b'}];
        if (!_.isEmpty(questions)) {
            return (
                <ScreenWrapper
                    style={[styles.flex1]}
                    keyboardAvoidingViewBehavior="height"
                >
                    <HeaderWithBackButton
                        title={this.props.translate('additionalDetailsStep.headerTitle')}
                        onBackButtonPress={() => Wallet.setAdditionalDetailsQuestions(null)}
                    />
                    <IdologyQuestions
                        questions={questions}
                        idNumber={this.props.walletAdditionalDetails.idNumber}
                    />
                </ScreenWrapper>
            );
        }

Access the Idology question section inside Enable Payments Page by entering:
http://localhost:8080/enable-payments
Click/Press the radio button, verify styling and behavior

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/39538890/cf4bef01-66c5-4800-845b-6137ea0a01cc

Mobile Web - Chrome

https://github.com/Expensify/App/assets/39538890/3d96d95e-a980-4e8d-833b-20d432e21082

Mobile Web - Safari

https://github.com/Expensify/App/assets/39538890/8d271c5a-bcdc-4fa2-84af-f2aa576dfe20

Desktop

https://github.com/Expensify/App/assets/39538890/b4a0efb0-e315-4539-bc61-b3c71b9d38e4

iOS

https://github.com/Expensify/App/assets/39538890/a4d4bf2e-c4d2-465e-80b7-77a7b7cc223a

Android

https://github.com/Expensify/App/assets/39538890/150169f1-6554-430e-b798-87a09ff913ac

@allroundexperts assigned you as a reviewer since you were assigned to the issue.

@Skalakid could you please provide more details on Access the Idology question section inside Enable Payments Page?

@allroundexperts you can get to that page by:

Navigate to /settings/payments/enable-payments
In the form, enter first name Alberta, last name Bobbeth and SSN as 3333. Enter any data for the other fields. When you get an error regarding SSN, simply click Save & continue
You should see the KBA questions

Hmm maybe my steps are not available in staging 🤔 @Skalakid how did you access that page in staging?

@allroundexperts can you just review the code? I'll complete the checklist and submit the videos

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.27-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.27-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Skalakid @luacmartins @allroundexperts do we need to QA this? Can you share clear QA steps

@mvtglobally I think it's fine to QA it as part of Wallet regression tests.

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.27-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Refactor/storage

Coverage decreased (-8.0%) to 41.224% when pulling f2ea3d5ad82a90b7d29a027096ca0d148ad8e56a on u9520107:refactor/storage into 45656fb31ac6693474a2fe6b542248b6ab9125d3 on ringcentral:master.

Coverage decreased (-3.8%) to 35.149% when pulling 1146bffdce6e60eae9998c5bd8b580d77889c744 on u9520107:refactor/storage into f770093c5c0002345859e31b1ed1e0df7c1741d3 on ringcentral:master.