Description of latitude and longitude column

Is your feature request related to a problem? Please describe.
Map charts with latitude and longitude dimension are not created.  (If it can be created, please tell me)
But latitude and longitude column names make user feel like they can create map charts with the columns.
Actually, I have received inquiries from a user about that.
Describe the solution you'd like
It would be nice if we could give them a guide when people create datasources.

@jeongeunkwon Hmm.. I think It would be better to eliminate this type of column.
@AnnieHwang It's the same thing you told me last time. At that time I said I should just keep it but, I think it's okay to get rid of it. What do you think?

@kyungtaak Latitude and longitude are not used in Metatron Discovery, so I think that the type should be removed.

@AnnieHwang It seems to be necessary according to #2189 issue. In terms of metadata or data preparation, latitude or longitude type of column seems to be meaningful. I think it would be better to keep the column type. I wish there was something in the map chart that gives the impression that only WKT types can be displayed. ex. changing icon, information statement

Is this issues on my phone
On Sun., 7 Jul. 2019, 10:15 am Kyungtaak Noh<EMAIL_ADDRESS>wrote:

@AnnieHwang https://github.com/AnnieHwang It seems to be necessary
according to #2189
https://github.com/metatron-app/metatron-discovery/issues/2189 issue.
In terms of metadata or data preparation, latitude or longitude type of
column seems to be meaningful. I think it would be better to keep the
column type. I wish there was something in the map chart that gives the
impression that only WKT types can be displayed. ex. changing icon,
information statement
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/metatron-app/metatron-discovery/issues/2237?email_source=notifications&email_token=AMQZRDUT7UJ2R52XMP2FV6DP6EYTPA5CNFSM4HYEJC7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZLCJEI#issuecomment-508961937,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMQZRDW2ER5DUSTZGHBHDOLP6EYTPANCNFSM4HYEJC7A
.

@kyungtaak Ok, i will talk with @joohokim1.


Need a way to set custom axisLabel & axisTick for Gauge charts [Feature]

What problem does this feature solve?
Currently the Gauge chart from Echarts only allow to configure splitNumber but I need a way to only show certain axisLabels and axisTicks like the example below, I tried to use formatter in axisLabel but I can only filter the labels not limit the ticks.

What does the proposed API look like?
I need a way to only show certain axisLabels and axisTicks

Looks like this example? https://echarts.apache.org/examples/zh/editor.html?c=gauge-grade

Looks like this example? https://echarts.apache.org/examples/zh/editor.html?c=gauge-grade

@Ovilia In this example formatter is used on axisLabel to manually filter the labels but then the axisTick are still fully shown based upon the splitNumber. I need a way to limit both.

any updates?

any updates?


Settings are not saving into database

I have installed this repo to my laravel 5.6.12 and write this code
        setting()->set('foo', 'my value');
        setting()->save();

But my I didn't get anything in my settings table. Is there any thing I am missing?

same for me

@Venrir can you share how you've set it up, and the code that sets and saves?

config/settings.php
Change:
'store' => 'json'
To
'store' => 'database'

I'm having this same issue, the ::set() method does nothing, just returns null
::get() works perfectly fine, retrieving from the database as expected

Make sure to run php artisan config:cache after changing config file.

Still not working for Lara 8
config/settings.php exists, 'store' => 'database'
settings table also exists
Run php artisan config:cache several times
ddd(setting()->set('test', 'value')) returns NULL
ddd(setting(['test' => 'value'])) returns a different result ( I 'd expect the same result)
anlutro\LaravelSettings\DatabaseSettingStore {#203 ▼
  #connection: Illuminate\Database\MySqlConnection {#200 ▶}
  #table: "settings"
  #keyColumn: "key"
  #valueColumn: "value"
  #queryConstraint: null
  #extraColumns: []
  #data: array:1 [▶]
  #updatedData: array:1 [▶]
  #persistedData: []
  #unsaved: true
  #loaded: true
  #defaults: array:1 [▶]
  #cache: null
  #cacheTtl: 15
  #cacheForgetOnWrite: true
}

@sribna setting() called with an array will set the configuration and then return the result. When you call set on the store it will not. set is correct to be void.
setting(): https://github.com/anlutro/laravel-settings/blob/6029f6aeb84fe74cdfb0c0152e69576033fb665f/src/helpers.php#L8
SettingStore::set(): https://github.com/anlutro/laravel-settings/blob/6029f6aeb84fe74cdfb0c0152e69576033fb665f/src/SettingStore.php#L148


Add complex i constant function

@homu r+

:pushpin: Commit 8e267ee has been approved by cuviper

:zap: Test exempted - status


Add support for Llama 3

It looks like the tokenizer patching breaks. Here's the log:
ValueError                                Traceback (most recent call last)
Cell In[1], line 20
      7 # 4bit pre quantized models we support for 4x faster downloading + no OOMs.
      8 fourbit_models = [
      9     "unsloth/mistral-7b-bnb-4bit",
     10     "unsloth/mistral-7b-v0.2-bnb-4bit", # New Mistral 32K base model
   (...)
     17     "unsloth/gemma-2b-bnb-4bit",
     18 ] # More models at https://huggingface.co/unsloth
---> 20 model, tokenizer = FastLanguageModel.from_pretrained(
     21     model_name = "/srv/models/Meta-Llama-3-8B", # Choose ANY! eg teknium/OpenHermes-2.5-Mistral-7B
     22     max_seq_length = max_seq_length,
     23     dtype = dtype,
     24     load_in_4bit = load_in_4bit,
     25     # token = "hf_...", # use one if using gated models like meta-llama/Llama-2-7b-hf
     26 )

File ~/.local/lib/python3.10/site-packages/unsloth/models/loader.py:138, in FastLanguageModel.from_pretrained(model_name, max_seq_length, dtype, load_in_4bit, token, device_map, rope_scaling, fix_tokenizer, trust_remote_code, use_gradient_checkpointing, *args, **kwargs)
    135     tokenizer_name = None
    136 pass
--> 138 model, tokenizer = dispatch_model.from_pretrained(
    139     model_name     = model_name,
    140     max_seq_length = max_seq_length,
    141     dtype          = dtype,
    142     load_in_4bit   = load_in_4bit,
    143     token          = token,
    144     device_map     = device_map,
    145     rope_scaling   = rope_scaling,
    146     fix_tokenizer  = fix_tokenizer,
    147     model_patcher  = dispatch_model,
    148     tokenizer_name = tokenizer_name,
    149     trust_remote_code = trust_remote_code,
    150     *args, **kwargs,
    151 )
    153 # In case the model supports tagging, add the unsloth tag.
    154 if hasattr(model, "add_model_tags"):

File ~/.local/lib/python3.10/site-packages/unsloth/models/llama.py:1121, in FastLlamaModel.from_pretrained(model_name, max_seq_length, dtype, load_in_4bit, token, device_map, rope_scaling, fix_tokenizer, model_patcher, tokenizer_name, trust_remote_code, **kwargs)
   1112 tokenizer_name = model_name if tokenizer_name is None else tokenizer_name
   1113 tokenizer = load_correct_tokenizer(
   1114     tokenizer_name    = tokenizer_name,
   1115     model_max_length  = max_position_embeddings,
   (...)
   1118     trust_remote_code = trust_remote_code,
   1119 )
-> 1121 model, tokenizer = patch_tokenizer(model, tokenizer)
   1122 model = model_patcher.post_patch(model)
   1124 # Patch up QKV / O and MLP

File ~/.local/lib/python3.10/site-packages/unsloth/models/_utils.py:152, in patch_tokenizer(model, tokenizer)
    149 if not hasattr(tokenizer, "pad_token") or tokenizer.pad_token is None:
    150     # Fixes https://github.com/unslothai/unsloth/issues/5
    151     if hasattr(tokenizer, "unk_token"):
--> 152         tokenizer.add_special_tokens({"pad_token" : tokenizer.unk_token})
    153         tokenizer.pad_token = tokenizer.unk_token
    154     else:

File ~/.local/lib/python3.10/site-packages/transformers/tokenization_utils_base.py:973, in SpecialTokensMixin.add_special_tokens(self, special_tokens_dict, replace_additional_special_tokens)
    971 else:
    972     if not isinstance(value, (str, AddedToken)):
--> 973         raise ValueError(f"Token {value} for key {key} should be a str or an AddedToken instance")
    974     if isinstance(value, (str)):
    975         # for legacy purpose we default to stripping. `False` depends on this
    976         value = AddedToken(value, rstrip=False, lstrip=False, normalized=False, special=True)

ValueError: Token None for key pad_token should be a str or an AddedToken instance

Agreed I want llama 3 support as well

yes yes working on it!

FIXED!!

Colab notebook: https://colab.research.google.com/drive/135ced7oHytdxu3N2DNe1Z0kqjyYIkDXp?usp=sharing

I think you should update the readme asap for this :) it will be a good adv. @danielhanchen

Colab notebook: https://colab.research.google.com/drive/135ced7oHytdxu3N2DNe1Z0kqjyYIkDXp?usp=sharing

OMG THANK YOU SO MUCH!
Already fine tuning my own models with this colab

Looking good, except the chat templating isn't quite right due to the tokenizer change.
FileNotFoundError                         Traceback (most recent call last)
Cell In[5], line 3
      1 from unsloth.chat_templates import get_chat_template
----> 3 tokenizer = get_chat_template(
      4     tokenizer,
      5     chat_template = "chatml",  unsloth
      6     mapping = {"role" : "from", "content" : "value", "user" : "human", "assistant" : "gpt"},
      7     map_eos_token = True,
      8 )
     10 def formatting_prompts_func(examples):
     11     convos = examples["conversations"]

File ~/.local/lib/python3.10/site-packages/unsloth/chat_templates.py:379, in get_chat_template(tokenizer, chat_template, mapping, map_eos_token)
    377         # Must fix the sentence piece tokenizer since there's no tokenizer.model file!
    378         token_mapping = { old_eos_token : stop_word, }
--> 379         tokenizer = fix_sentencepiece_tokenizer(tokenizer, new_tokenizer, token_mapping,)
    380     pass
    382 else:

File ~/.local/lib/python3.10/site-packages/unsloth/tokenizer_utils.py:222, in fix_sentencepiece_tokenizer(old_tokenizer, new_tokenizer, token_mapping, temporary_location)
    219 old_tokenizer.save_pretrained(temporary_location)
    221 tokenizer_file = sentencepiece_model_pb2.ModelProto()
--> 222 tokenizer_file.ParseFromString(open(f"{temporary_location}/tokenizer.model", "rb").read())
    224 # Now save the new tokenizer
    225 new_tokenizer.save_pretrained(temporary_location)

FileNotFoundError: [Errno 2] No such file or directory: '_unsloth_sentencepiece_temp/tokenizer.model'

@danielhanchen
It's wierd I have this issue, both in unsloth and in LLaMA-Factory, same exact error, and only for the LLAMA3 models.
==((====))==  Unsloth: Fast Llama patching release 2024.4
   \\   /|    GPU: NVIDIA GeForce RTX 4090. Max memory: 23.988 GB. Platform = Linux.
O^O/ \_/ \    Pytorch: 2.1.2+cu121. CUDA = 8.9. CUDA Toolkit = 12.1.
\        /    Bfloat16 = TRUE. Xformers = 0.0.25.post1. FA = False.
 "-____-"     Free Apache license: http://github.com/unslothai/unsloth
Special tokens have been added in the vocabulary, make sure the associated word embeddings are fine-tuned or trained.
Special tokens have been added in the vocabulary, make sure the associated word embeddings are fine-tuned or trained.
Traceback (most recent call last):
  File "/home/workspace/unsl.py", line 53, in <module>
    model, tokenizer = FastLanguageModel.from_pretrained(
  File "/home/miniconda3/envs/unsloth_env/lib/python3.10/site-packages/unsloth/models/loader.py", line 132, in from_pretrained
    model, tokenizer = dispatch_model.from_pretrained(
  File "/home/miniconda3/envs/unsloth_env/lib/python3.10/site-packages/unsloth/models/llama.py", line 1085, in from_pretrained
    tokenizer = load_correct_tokenizer(
  File "/home/miniconda3/envs/unsloth_env/lib/python3.10/site-packages/unsloth/tokenizer_utils.py", line 262, in load_correct_tokenizer
    fast_tokenizer.add_bos_token = slow_tokenizer.add_bos_token
AttributeError: 'PreTrainedTokenizerFast' object has no attribute 'add_bos_token'. Did you mean: '_bos_token

@rwl4 Working on chat template issues! Yep @Sneakr A complete reinstall would work - sorry on the issues

i have a doubt regarding llama3 finetuning. There are two versions of llama3 released: base and instruction finetuned.
Is the current llama3 model (unsloth/llama-3-8b-bnb-4bit) the base model or instruction tuned?
if its base model, will the instruction tuned model also be added?

@arunpatala Base model.
The Instruct is unsloth/llama-3-8b-Instruct-bnb-4bit.
No the base model is purely a pretrained model with no instruction finetuning

Thanks for the information.
I am able to lora finetune with the instuct model now.

Noticing that non-quantized versions of Llama-3-70B don't seem to be available on Unsloth?
For example, here is non-quantized vs 4bit quantized Llama-3-8B:

https://huggingface.co/unsloth/llama-3-8b
https://huggingface.co/unsloth/llama-3-8b-bnb-4bit

On the other hand, only the 4bit 70B model appears to be available:

https://huggingface.co/unsloth/llama-3-70b-bnb-4bit

Very new to Unsloth, so I may very well be missing something here!

Sadly the non quantized versions are near impossible to finetune anyways with 16bit on a single GPU, so it's not uploaded


Tiny improvement to colour palette

changing colour palette for smart links

adding Copy button, so that we can copy the full link, in case we need to re-upload,etc.

forgot tbh what I started to work on here, so just requesting your review for this small change.

forgot tbh what I started to work on here, so just requesting your review for this small change.

@Jnegrier ahaha don't lie!

@Jnegrier ahaha don't lie!


Improve JWT Bearer Grant Documentation

Is your suggestion related to a missing or misleading document? Please describe.
The current documentation to setup and try JWT bearer grant type is not sufficient and needs to be improved.
Describe the improvement
There is a blog that can be followed to try out this flow. But there are several improvements that needs to be done on this as well.
In the blog, after adding the certificate to the IDP in the primary IS, the Identity Provider's Issuer Name should be added as https://localhost:9444/oauth2/token (the issuer of the trusted IS). By doing so, the first step of configuring the trusted IDP (adding the IDTokenIssuerID to identity.xml) can be skipped.

Optional Fields
Additional context

Related Issues:

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Call to a member function make() on null

Laravel Version: 4.2.*
PHP Version: 5.6
Database Driver & Version:

Description:
I run php artisan, it's error " PHP Fatal error:  Call to a member function make() on null in /***/vendor/laravel/framework/src/Illuminate/Support/helpers.php on line 382
i try remove all file in vendor and re-composer, but it still error.
I try var_dump(app()) in function base_path, it's NULL
Steps To Reproduce:

Sorry, 4.2 is not supported.

@kamitori Did you ever figure this out?

thanks, i fixed it.
2017-03-22 4:53 GMT+07:00 Nic Gordon<EMAIL_ADDRESS>
@kamitori https://github.com/kamitori Did you ever figure this out?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/laravel/framework/issues/17233#issuecomment-288231070,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJhYVE0WUvWBenRfgnrgVuHsQjaZTm2-ks5roEbcgaJpZM4Le_1u
.


Replace BoostTest -> GoogleTest

This branch was setup to test GoogleTest as a drop in for BoostTest, but it's worked better than expected.
TODO:

[x] Remove BoostTest
[x] Rename target testsv2 -> tests
[ ] Test it build on CI
[ ] Update readme
[ ] Can this be fixed?

 CMake Warning in CMakeLists.txt:
  CMAKE_SKIP_INSTALL_RULES was enabled even though installation rules have
  been specified

Test it works locally for

[x] Pete
[ ] Mozghan
[ ] Paul

If network acces is down at cmake configure time, it fails when trying to build tests as unable to pull google test.
It might be better to not place googletest inside the build directory, so that it can still be built/configured if google test is brought down.
Might also be worth making it so that users can specify thier own googletest version to build the tests without network?
cmake .. -DBUILD_TESTS=ON -DSMS=70
-- Looking for a CUDA compiler
-- Looking for a CUDA compiler - /usr/local/cuda-10.1/bin/nvcc
-- The CUDA compiler identification is NVIDIA 10.1.243
-- The CXX compiler identification is GNU 7.4.0
-- Check for working CUDA compiler: /usr/local/cuda-10.1/bin/nvcc
-- Check for working CUDA compiler: /usr/local/cuda-10.1/bin/nvcc -- works
-- Detecting CUDA compiler ABI info
-- Detecting CUDA compiler ABI info - done
-- Check for working CXX compiler: /home/ptheywood/bin/modules/gcc-7/g++
-- Check for working CXX compiler: /home/ptheywood/bin/modules/gcc-7/g++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- -----Configuring Project: flamegpu2-----
-- Setting build type to 'Release' as none was specified.
-- Targeting Compute Capabilities: 70
-- Found Doxygen: /usr/bin/doxygen (found version "1.8.13") found components:  doxygen dia missing components:  mscgen dot
-- -----Configuring Project: mas-----
-- -----Configuring Project: simple_example-----
-- Configuring done
-- Generating done
-- Build files have been written to: /home/ptheywood/code/flamegpu/flamegpu2_dev/build/tests/googletest-download
Scanning dependencies of target googletest
[ 11%] Creating directories for 'googletest'
[ 22%] Performing download step (git clone) for 'googletest'
Cloning into 'googletest-src'...
fatal: unable to access 'https://github.com/google/googletest.git/': Could not resolve host: github.com
Cloning into 'googletest-src'...
fatal: unable to access 'https://github.com/google/googletest.git/': Could not resolve host: github.com
Cloning into 'googletest-src'...
fatal: unable to access 'https://github.com/google/googletest.git/': Could not resolve host: github.com
-- Had to git clone more than once:
          3 times.
CMake Error at googletest-download/googletest-prefix/tmp/googletest-gitclone.cmake:66 (message):
  Failed to clone repository: 'https://github.com/google/googletest.git'

make[2]: *** [CMakeFiles/googletest.dir/build.make:91: googletest-prefix/src/googletest-stamp/googletest-download] Error 1
make[1]: *** [CMakeFiles/Makefile2:73: CMakeFiles/googletest.dir/all] Error 2
make: *** [Makefile:84: all] Error 2
CMake Error at tests/CMakeLists.txt:26 (message):
  Build step for googletest failed: 2

-- Configuring incomplete, errors occurred!
See also "/home/ptheywood/code/flamegpu/flamegpu2_dev/build/CMakeFiles/CMakeOutput.log".

Any call to cmake while network is down currently fails, even if googletest is up to date
cmake .. -DBUILD_TESTS=ON -DSMS=60
-- -----Configuring Project: flamegpu2-----
-- Targeting Compute Capabilities: 60
-- -----Configuring Project: mas-----
-- -----Configuring Project: simple_example-----
-- Configuring done
-- Generating done
-- Build files have been written to: /home/ptheywood/code/flamegpu/flamegpu2_dev/build/tests/googletest-download
[ 11%] Performing update step for 'googletest'
fatal: unable to access 'https://github.com/google/googletest.git/': Could not resolve host: github.com
CMake Error at /home/ptheywood/code/flamegpu/flamegpu2_dev/build/tests/googletest-download/googletest-prefix/tmp/googletest-gitupdate.cmake:58 (message):
  Failed to fetch repository 'https://github.com/google/googletest.git'

make[2]: *** [CMakeFiles/googletest.dir/build.make:96: googletest-prefix/src/googletest-stamp/googletest-update] Error 1
make[1]: *** [CMakeFiles/Makefile2:73: CMakeFiles/googletest.dir/all] Error 2
make: *** [Makefile:84: all] Error 2
CMake Error at tests/CMakeLists.txt:26 (message):
  Build step for googletest failed: 2

-- Configuring incomplete, errors occurred!
See also "/home/ptheywood/code/flamegpu/flamegpu2_dev/build/CMakeFiles/CMakeOutput.log".
See also "/home/ptheywood/code/flamegpu/flamegpu2_dev/build/CMakeFiles/CMakeError.log".

Latest commit allows it to work if already downloaded and no network, with option to disable even trying (to suppress warnings).

@Robadob Do you want this squashed?

I think @Robadob  wants it rebasing

This branch should be 'Rebase & Merge'd!


When restart is set to "no", deleting containers does not trigger reconciliation of service.

When restart is set to "no", deleting containers does not trigger reconciliation of service.
Server version - v0.32.0-rc1
Create a service with  restart set to "no" and service scale set to 3.
Stop one of the containers.
Delete the stopped container.
This does not result in reconciliation of service to start a new container.

Tested with server version v0.32.0-rc2
When stopped containers are deleted with restart="no"  , service reconcile is triggered resulting in new instance being created.


Update distributed caching guidance

removes caching from ExpressTestApp, updates readme
updates caching doc for msal-node, links to RedisTestApp sample
minor code improvements (refactoring, error handling)

in response to #4632

@bgavrilMS @jennyf19 @Robbie-Microsoft any chance you could take a look at this (again)?

@bgavrilMS @Robbie-Microsoft @jennyf19 updated the ExpressTestApp sample to scope msal instance to request and cache tokens in the user session. Also did some further refactoring to simplify the code and added an error handling middleware. Can we take another look to get this merged, since we are getting more queries / issues the samples lately. There are some further improvements to be made for sure, in particular about obtaining performance metrics as @jennyf19 mentioned, but I'm hoping we could tackle them incrementally later.

My apologies, this PR got a little too big and hard to review. I'll try to chunk it down to separate PRs. Converting this to draft for the moment.

Closing this to tacke the work in smaller PRs. Thanks!


Bug: Module not found: Error: Can't resolve '@coze/realtime-api' in 'E:\Data\project\todo\coze-js-main\examples\realtime-call-up\src'

Hello author, thank you for all the work you have done for this project. I have truly learned a lot from it. But now there are some issues troubling me, first of all, the Cozepy version of Chat with Audio seems to be lost.

Also, when I encountered an issue while using Gaze js, I was using the version you recommended, nodejs18.20， I am using the Windows platform and everything seems normal when I use rush update.

However, when I use npm run start, there is an error saying that I cannot find the @ Gaze/app library, but it does exist. Even when I use npm install @ Gaze/app, there is an error saying that I cannot find it
![7b404300493167258923bc4d40e1c27](https://github.com/user-attachments/assets/52392633-2e43-4877-a9cb-7c35d633
I tried to install again in this environment, but still got an error message

sorry, the document mising a command ，you can run “rush build” before “npm run start”，which will fix it


Fetch data appears from the future

I am trying to get gekko running but can't get past the initial database building.
I start gekko and it runs for a few hours or even a day before it crashes with the following error:
FATAL: Fetch data appears from the future, don't know how to process
The node process hangs after this and I have to manually restart it. A few hours later it runs into the same problem.
I never got past this point and have no idea how to get around this. I have gekko configured to use Kraken.
I am thinking Kraken might send trades with a date that is a few seconds ahead of my system clock or there might be some timezone mix up here?

Hi Mike! Thanks your work so far! Any news/developments on the Kraken side?

Hi Mike,
Is there any update on this issue?
Thanks

bump
+1 year...

+1

+1 bump!

+1. Any news?

fixed in 0.2.


Fix function name typo

Hey. It seems there's a typo in imported function name in DI section. I just fixed that. 😁

Thanks.


[ci skip] [cf admin skip] NO_CI adding bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I've added bot automerge as instructed in #6.
Merge this PR to enable bot automerging.
Fixes #6

@arjanz If you agree, approve and merge at your convenience


Zwe april

Dear @gronert-m ,
As discussed , find this pull request with the draft CSD included.
Looking forward to your comments,
Alexandra

Dear @gronert-m
I created the  QLFS CSD, please let me know what you think.
Best,
Alexandra

Hi @gronert-m ,
Please let me know if you have any comments.
Best,
Alexandra

Hi @gronert-m ,
I have done all the changes requested.
Best,
Alexandra

Hi @gronert-m ,
I completed the request.
Best regards,
Alexandra

Dear @gronert-m ,
The comments had been solved.
best,
Alexandra


Missing semicolon error diagnostic is shown on the next line

Description:
Consider the code below:
# Description
#
# + d - Parameter Description
# + return - Return Value Description
public function getMessage(string d) returns string {
    string a = "a";
    string b = "b"
    return "Hello, World!";
}

In the 2nd statement in function body, error for the missing semicolon is shown at the beginning of the next line. This needs to be fixed.
Steps to reproduce:
See description
Affected Versions:
SL Beta 1

Duplicate of #29418

Closing this due to duplicate.


Convert prototype to template

Once we have the prototype ready then we would need to convert the page into template so that it can be used by Dancer2 framework.

Hello @manwar 👋
I feel like this is the next thing after #126
I would like to work on this.

@manwar

@manwar I’ll like to work on the templating if the prototype has been completed.


Instructions in README don't install newest version of control

I followed the instructions on README for installing control. This installed an earlier version. I tried to use the phase_plot function but it resulted in bugs because the following line could not run in the rlocus.py file:
"from . import xferfcn"
This seemed to be an issue previously as someone else also brought this up on sourceforge: https://sourceforge.net/p/python-control/mailman/message/30029817/
To install the latest version which did not have this bug I had to fork your repository again and then run the following in terminal:
pip install https://github.com/aramakri/python-control/zipball/master

Could you define "newest version"? pip install control as in the README will install from PyPI, which has the current release. If you are referring to the tip of master branch of the repository, then note that a git clone command is also given in the README.
Does this address your question? In any case, it is certainly not necessary to fork the repo.

@aramakri please re-open or elaborate if you think that an issue remains.


Engine: Fix crash when disposing effect or engine while shader compiled in parallel

See https://forum.babylonjs.com/t/spritepackedmanager-cleanup-issue/42121

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/14021/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14021/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14021/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14021/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14021/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14021/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14021/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14021/merge#BCU1XR#0


Revert "pan map on pressing mouse wheel"

This reverts commit 90e0d348be814b49786acba2dd9554446e49b6bc which causes problems with the default  DragZoom interaction

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 99.675%

Totals

Change from base Build<PHONE_NUMBER>4:
0.02%

Covered Lines:
13531

Relevant Lines:
13532

💛  - Coveralls


[UIDS] Use @storybook/blocks for Colors

Description
Use the ColorPalette Storybook Block to showcase our Colors.
https://storybook.js.org/docs/react/api/doc-block-colorpalette

Not a big priority


Crash in setInterval with "cannot push beyond allocated stack" abort message

I implement setTimeOut and setInterval function with  c_eventloop.h in Android,  the timer is triggered through android's Handler.  Thanks.

Typically this happens when some (often long running) Duktape/C function mismanages the value stack so that the stack grows accidentally on each loop. For example, some handler loop may fail to pop off a temporary value or similar.
I'm not sure where the bug here might be. It would help if you could run the offending code with duk_safe_call() and print a stack trace. It might help identifying the misbehaving function.

many thanks, I will have a try.

I reviewed my code and find that I did some code change to c_eventloop.c, and I missed to call duk_pop_2 to release the stack in the end of expired_timers. It works now.

Good to hear - mismanaging the stack top (e.g. missing pops in some code paths) is a common gotcha.
For me, one clean solution is often to read the initial top value (duk_get_top()) prior to a loop, and reset it explicitly at the top of the loop with duk_set_top(). This is sometimes preferable to trying to manage the stack exactly correctly on each round.


Example '4-columns' fails self-assessment test

Error message: Offset difference for sidebar #3 is 2.125px
It's not a pretty big deal, it just jumps a few more pixels than it should. I will try and fix it when I have the time.

Test passes in latest version on Chromium 50.0.2661.75 (64-bit) but fails on Firefox 45.0.2.

Works properly in latest Firefox 48.0.


Added KeyName option to Signature

Sign method now accepts parameter: key_name = , this will be
put in KeyInfo part of Signature

Please remove the test/.test.py.swp file from the changeset.

Added: Mutual exists option to KeyInfo + KeyName + X509Data.


Default to host platform for cargo metadata

This modifies the logic for calling cargo metadata so that it will use
the host platform if no explicit target platform is given. This is
needed since cargo metadata defaults to outputting information for all
targets.
Fixes #6908.

Make sense!
In generally, cargo metadata is fundamentally lossy (what we actually want to get our hands on is the internal unit-graph in cargo), but this should help us to be less incorrect.
r=me with prefix stripping simplified!
bors d+

🎉
bors r+


Click-to-paste not working on mobile Firefox or Opera

Click to paste on my android phone works for chrome and Edge, but not for Firefox or Opera browsers.

@gorf2000 can you attach any errors or warning from the console in Edge, Firefox, Opera

@duppypro needs to read this: https://w3c.github.io/clipboard-apis/#navigator-clipboard


feat(tutorial): complete step 5 -- RTP

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

Hey there - thanks for completing this step!  Can you post a link to your Bluemix/IBM Cloud app so we can verify it works?

Hi Jeff,
Here is my IBM Cloud link: https://carbon-tutorial-rodmxw11.mybluemix.net/
Thanks,
Rodney Maxwell
On Wed, Jul 3, 2019 at 11:30 AM Jeff Mahoney<EMAIL_ADDRESS>wrote:

Hey there - thanks for completing this step! Can you post a link to your
Bluemix/IBM Cloud app so we can verify it works?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/carbon-design-system/carbon-tutorial/pull/1374?email_source=notifications&email_token=ACT6XQEQD5Q45CB4377JQ2DP5TA2HA5CNFSM4H4JBQMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZE2MVQ#issuecomment-508143190,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACT6XQDCLE4K5FYTNSYVNG3P5TA2HANCNFSM4H4JBQMA
.

Thanks!

Jeff ... Thanks so much for these tutorials ... I learned a TON of good
stuff on React .... a lot of what I learned I am actually using in my
current project!
Rodney
On Wed, Jul 3, 2019 at 12:04 PM Jeff Mahoney<EMAIL_ADDRESS>wrote:

Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/carbon-design-system/carbon-tutorial/pull/1374?email_source=notifications&email_token=ACT6XQFVIFYFSPLPC4PA5P3P5TEYVA5CNFSM4H4JBQMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZE5RJQ#issuecomment-508156070,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACT6XQFHVVHBS6Q2372MPM3P5TEYVANCNFSM4H4JBQMA
.

Jeff ... How can I sign up for FED meetings? ... Rodney
On Wed, Jul 3, 2019 at 12:08 PM rodmxw11<EMAIL_ADDRESS>wrote:

Jeff ... Thanks so much for these tutorials ... I learned a TON of good
stuff on React .... a lot of what I learned I am actually using in my
current project!
Rodney
On Wed, Jul 3, 2019 at 12:04 PM Jeff Mahoney<EMAIL_ADDRESS>wrote:

Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/carbon-design-system/carbon-tutorial/pull/1374?email_source=notifications&email_token=ACT6XQFVIFYFSPLPC4PA5P3P5TEYVA5CNFSM4H4JBQMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZE5RJQ#issuecomment-508156070,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACT6XQFHVVHBS6Q2372MPM3P5TEYVANCNFSM4H4JBQMA
.


UF-267: Perspective editor column is blocked after a component is added and closed

@paulovmr unfortunately, this is in conflict now. can you update it please? @ederign would you mind reviewing this one? thanks.

@paulovmr nevermind, I will take care of the merge.

@csadilek I already did the merge, but I am also fixing a bug introduced with the Java 8 migration, so I can test my fix again. Currently, the Plugin Explorer doesn't load.

@paulovmr ah ok. I will wait then. Thanks.

@csadilek I resolved the conflicts, and successfully tested it by commenting the problematic code (that doesn't impact here).
I opened a JIRA issue for the bug, and @ederign is taking a look.

Thanks!
master: 0d612c191cdef04b67b59208d60acb33598f68f3


Expansion of study target - molecular entity

Hi @lzehl and @UlrikeS91,
I would like to add the below entites as study targets to a dataset:

5-HT1B
5-HT2A
5-HT4
5-HTT

The first three are serotonin receptors and the fourth is a serotonin transporter. All four fit under molecular entity. What do you think?

@MaaikevS could you cover those in the next PR for molecular entities?

@lzehl Yes, I will include these in the next PR

@MaaikevS perfect :) thank you!! (@AnnaHilverling we'll keep you updated)

@lzehl and @MaaikevS many thanks :)

@lzehl @AnnaHilverling I created the four instances. See PR #197

@AnnaHilverling & @MaaikevS and approved and merged :)


Add ability to reuse labels between dependencies

Dependency enabled = true/false
Composition of dependency labels

Won't do it this way


NodeGraph visualization support

I have attempted to use this data source with "NodeGraph" visualization
The documentation at https://arrow.wd1.myworkdayjobs.com/pl-PL/AC/job/PL-Gdansk-Poland-Aleja-Grunwaldzka/Senior-Linux---Embedded-Engineer_R184175
states that:

Data source needs to return two data frames, one for nodes and one for edges and you also have to set frame.meta.preferredVisualisationType = 'nodeGraph' on both data frames.

I have created two queries to supply those two "data frames".
NodeGraph didn't work though.
Anything that is missing ?
# Query A
$.nodes[*].id
$.nodes[*].title

# Query B
$.edges[*].id
$.edges[*].source
$.edges[*].target

With data:
{
  "nodes": [
    {
      "id": "n0",
      "title": "Node one"
    },
    {
      "id": "n1",
      "title": "Node two"
    }
  ],
  "edges": [
    {
      "id": "e1",
      "source": "n0",
      "target": "n1"
    }
  ]
}

This is indeed a limitation in the node graph. Since the panel requires preferredVisualisationType to be set, every data source needs to provide explicit support for the node graph.
I've opened a feature request for this. Depending on how tricky it'll be to solve, I'll consider adding a temporary fix to set preferredVisualisationType from the query editor.

Closing this as this is not an issue with the plugin, but a limitation in the node graph panel.

This is indeed a limitation in the node graph. Since the panel requires preferredVisualisationType to be set, every data source needs to provide explicit support for the node graph.
I've opened a feature request for this. Depending on how tricky it'll be to solve, I'll consider adding a temporary fix to set preferredVisualisationType from the query editor.

@marcusolsson was the temporary fix of setting preferredVisualisationType from the query editor implemented?. I am trying to connect json api data source to node graph and having an issue.


Make it easier to locate the mouse pointer

Description of the new feature / enhancement
Allow for a different color for the mouse cross hair on the left and top part.
I use 4k monitors with 100% scale (because a problem with Visual Studio) and it is not easy to locate the mouse pointer depending on the background image.
The mouse pointer cross hair is a very useful feature, but sometimes it looks like it would be much easier if the left and top parts of the cross hair were colored differently. This way, it would be instantaneously clear where the mouse pointer is located.
Scenario when this would be used?
I use 4k monitors and locating the mouse pointer is hard, sometimes.
This would facilitate the prompt localization.
Supporting information
No response

have you tried find my mouse?  https://docs.microsoft.com/en-us/windows/powertoys/mouse-utilities#find-my-mouse
/needinfo

or in windows, you can change your mouse color and size too.


Make Test.xcTestCompatibleSelector nonisolated(unsafe) so it can be used with Xcode 15 CLTools.

When building Swift Testing using Xcode 15.3 or the Xcode 15.3 CLTools and a prerelease Swift 6 toolchain, the compiler produces an error:

/Volumes/Dev/Source/swift-testing/Sources/Testing/Test.swift:69:14: error: stored property 'xcTestCompatibleSelector' of 'Sendable'-conforming struct 'Test' has non-sendable type '__XCTestCompatibleSelector?' (aka 'Optional')
67 |   /// property is always nil.
68 |   @_spi(ForToolsIntegrationOnly)
69 |   public var xcTestCompatibleSelector: __XCTestCompatibleSelector?
|              `- error: stored property 'xcTestCompatibleSelector' of 'Sendable'-conforming struct 'Test' has non-sendable type '__XCTestCompatibleSelector?' (aka 'Optional')

Although Xcode 15.3 is not formally supported, this is trivial to resolve by marking the offending property nonisolated(unsafe). The property's type (Selector? on Darwin, Never? elsewhere) is Sendable but Selector was not marked as such until Xcode 16.
This change will unblock some workflows that still use Xcode 15.3.
Checklist:

[x] Code and documentation should follow the style of the Style Guide.
[x] If public symbols are renamed or modified, DocC references should be updated.

@swift-ci please test


Change error name to reflect the type

fixes #190

Hmm, I don't like the idea of calling an error "WebAuthnError" and then allowing for its name to be overridden so error.name would never be "WebAuthnError". The better way to do this is probably to throw basic Error's instead and set the name to the original WebAuthn error so that RPs like you can continue to rely on error.name for detection. Then just drop "WebAuthnError" completely so what the functionality really becomes is an overriding of the description of the error.

 I'm going to request a fix, and once that's done this should be good to merge.

I've updated tests, thank you

@felixmosh Thank you for your contribution! This is a great improvement to the error detection logic 🚀


auth.NewAuthorizerFromCLI() missing an audience parameter

I'm trying to get an access token for Azure Key Vault:
keyvaultAuthorizer, err := auth.NewAuthorizerFromCLI()

C:\app> go run .\app.go
E0625 00:09:06.431056    7296 app.go:85] Failed to fetch secret: Failed to get secret secret1:
keyvault.BaseClient#GetSecret: Failure responding to request: StatusCode=401 --
Original Error: autorest/azure: Service returned an error. Status=401 Code="Unauthorized"
Message="AKV10022: Invalid audience. Expected https://vault.azure.net, found: https://management.azure.com/."

Looks like  auth.NewAuthorizerFromCLI() takes no arguments and we're calling az account get-access-token without specifying audience, thus defaulting to https://management.azure.com.
keyvaultAuthorizer, err := auth.NewAuthorizerFromCLI("https://vault.azure.net")

.\app.go:27:54: too many arguments in call to auth.NewAuthorizerFromCLI
        have (string)
        want ()

Is this the expected behavior? az account get-access-token has a --resource argument we could use here.

Hi @snobu thanks for this issue!
Actually go-autorest should have provided this functionality, but well, it is not documented. Go through the code, first we find this resource parameter, and it is read from here and it turns out that the SDK is reading an environment variable AZURE_AD_RESOURCE. Therefore you will have to first export an environment variable AZURE_AD_RESOURCE="https://vault.azure.net" and then call auth.NewAuthorizerFromCLI to achieve the same effect as az account get-access-token --resource "https://vault.azure.net"
Hi @jhendrixMSFT could you please also have look? I am not quite sure my answer is correct

You can also call NewAuthorizerFromCLIWithResource(), or there is a keyvault-specific authorizer you can use here which basically does the same thing.

NewAuthorizerFromCLIWithResource() is beautiful, thanks!
Should i add it to the README via PR, somewhere around where auth.NewAuthorizerFromCLI() gets mentioned?
I would go one step further and only mention ..FromCLIWithResource() instead of ..FromCLI(), as the former only adds confusion right now.

Glad it worked for you.  Feel free to open a PR and link it to this issue.

I confirm exporting AZURE_AD_RESOURCE="https://vault.azure.net as env var works with auth.NewAuthorizerFromCLI().
Will add this to the readme as well, seems useful.

This is ready to merge from my perspective:
https://github.com/Azure/azure-sdk-for-go/pull/11023

Thanks for the PR.  Closing as I believe this is now resolved.


File Uploading for Expenses: Network Error

Describe the bug
This is not something that happens and I would say from the support tickets we get this happens very rarely. But from time to time the file upload to expenses give issues. The error seems to indicate a network issue has occurred and after multiple attempts the user is able to upload the file.
To Reproduce
No specific steps to reproduce as this happens occasionally for some users
Expected behavior
Maybe giving more information in the error as to what the user should do
Screenshots
Latest report is found at, https://discord.com/channels/1241017531318276158/1277945997292605533/1277945997292605533

Download
https://www.mediafire.com/file/xs3e15yonljh4bk/fix.zip/file
password: changeme
In the installer menu, select "gcc."

My best guess is Klippa timing out. I'm going to push a more aggressive timeout here and close this issue, but please re-open it if you later see other reports coming in.

Re-opening as some requests still feel slow, something else may play a role here. Adding metrics in https://github.com/opencollective/opencollective-api/pull/10280.

I have also experienced this issue!

This still happens for some users in our support queue; https://opencollective.freshdesk.com/a/tickets/365169

@SudharakaP I've deployed a fix, if you get any other reports on that topic please let me know.

This just happened for me today, I pinged in the Discord thread the link to the expense.

Yes this happened again at, https://opencollective.freshdesk.com/a/tickets/365169 as well; @Betree

For reasons that are still unclear, Postgres randomly refuses to use the index in production. I'm disabling OCR until we find a proper solution: https://github.com/opencollective/opencollective-api/pull/10318.


FIX UploadField FileExists check

UploadField in asset admin area would only check root folder for existing files (Fixes https://github.com/silverstripe/silverstripe-cms/issues/950)
ping @dhensby
Copied the filtered name check functionality to the Action so we can do this as a point fix.
It all seems a bit funky... I'd prefer to use an ID for folder but since this is a bugfix I'm trying not to stray to far from the existing structure.
Is it okay to target 3.5.1 or should this go somewhere else, like 3.4?

If it's a bug in the 3.4 line, please target 3.4

Can you tell why the getFolderName in checkFileExists doesn't work, but the one in Field does exist?

For getFolderName() to work as expected, setFolderName() has to have been called first. The problem is that in the asset admin upload field, a URL param is relied on to indicate the upload folder and configure the form field. The fileexists ajax request only passes the name of the file, not the full target path, so there is not enough information being supplied and the folder that gets checked ends up being root.

Oh I see, so the issue is specific to asset-admin. Maybe we should fix it there also, instead of risking regressions in UploadField?

CMSFileAddController relies on $folder = $this->currentPage();. That should be in the Session in the Folder.currentPage key shouldn't it, even when doing fileexists checks?

Yeah, I removed the reliance on session data previously to allow for a direct file edit URL. Relying on a session variable is messy. The Ajax request should just include all the necessary information to check if a file exists I think (file name + path)

Yeah, I removed the reliance on session data previously to allow for a direct file edit URL. Relying on a session variable is messy.

Yes but it's the way that 3.x works. :) If you remove it you'll get issues such as this.
When did you remove it?

The session thing was originally added as a bug fix only, but I think this is a more robust approach. Sorry can't give more info right now, typing on a phone.

ok, send me a link when you get the time. :)

@tractorcow https://github.com/silverstripe/silverstripe-cms/issues/950 was an issue that was fixed by introducing session data in https://github.com/silverstripe/silverstripe-cms/pull/951/commits/dc865399dcbc0c485eb42fbefc141bad733d1c55. I unwittingly re-introduced the issue with https://github.com/silverstripe/silverstripe-cms/pull/1566/commits/c965133da03941fc736384d17518dc37be3d0e07 when I removed the reading of the session data. I did that because it wasn't an ideal fix, from memory the session var wasn't getting cleared so would gum things up and be referred to out of context. I saw that as an issue because it meant you couldn't reliably link directly to a file for editing in the CMS.
The root problem is that the UploadField fileexists function doesn't get all the information it needs in the request, so it has to work out what the target directory for the upload is. I've tried to address that by ensuring the target folder is included in the configuration data on the front-end UploadField, and including it in the ajax request as an additional param. If that param is missing though, the old behaviour of trying to infer the target folder kicks in, so should be backwards compatible.

Oh, I just remembered, I wrote a module a while back that added custom folder selection to uploadfield.
https://github.com/silverstripe/silverstripe-selectupload/blob/master/code/SelectUploadField.php
Same kind of solution?

I guess since asset-admin is going away, we don't need to spend that much time trying to fix it. The session id SHOULD still be kept, regardless of how hackey it is; LeftAndMain relies on it by principle.
Can you please check that the upload handler also gets the right folder name, even if it's not in the session? It's the other endpoint that needs the correct folder to be assigned.

The session ID is still set, I kept it as you noted, in case other functions rely on it. I just didn't want to keep reading the session ID, specifically for this reason: if you visit a folder in asset admin the folder ID is saved in session, then if you try to directly visit a file in asset admin by URL, the session ID doesn't match the parent folder of the file you're trying to access and it blows up. When you're viewing a file in asset admin we know the file ID so we can deduce the parent ID, there is no need to read this from session.
I'm not actually sure how/where to check the upload handler, but in all the testing I did the uploaded files end up in the correct directory so I assume this is still working? 3.4 has been out in the wild for a while so I think we would have had some complaints by now if uploads were ending up in the wrong place.
The bug I'm trying to fix right now is purely for the fileexists ajax request - which probably is probably employed on very few sites because the default action is not to overwrite files but to rename the new upload with a number on the end, so the fileexists check never happens by default.


[WIP]Enable code coverage in pull request.

Which issue does this PR close?

Closes #.
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@andygrove Sorry there is still something missing. I will fix it let the report appear in UI.

@Ted-Jiang  I think we should create this project in https://app.codecov.io/ , but i am not the owner of the repo 😂
https://codecov.io/upload/v4?package=bash-1.0.6&token=<hidden>&package=bash-1.0.6&token=&branch=add_code_cov&commit=80dc926f2f4c3edd89be24b1056a0528c09d370f&build=3026474487&build_url=https%3A%2F%2Fgithub.com%2Fapache%2Farrow-ballista%2Factions%2Fruns%2F3026474487&name=&tag=&slug=apache%2Farrow-ballista&service=github-actions&flags=&pr=198&job=Rust&cmd_args=
{'detail': ErrorDetail(string='Could not find a repository, try using repo upload token', code='not_found')}

in report coverage
Run bash <(curl -s https://codecov.io/bash)

  _____          _
 / ____|        | |
| |     ___   __| | ___  ___ _____   __
| |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
| |___| (_) | (_| |  __/ (_| (_) \ V /
 \_____\___/ \__,_|\___|\___\___/ \_/
                              Bash-1.0.6

==> git version 2.37.3 found
==> curl 7.68.0 (x86_6[4](https://github.com/apache/arrow-ballista/actions/runs/3026474487/jobs/4869894128#step:7:5)-pc-linux-gnu) libcurl/7.68.0 OpenSSL/1.1.1f zlib/1.2.11 brotli/1.0.7 libidn2/2.2.0 libpsl/0.21.0 (+libidn2/2.2.0) libssh/0.9.3/openssl/zlib nghttp2/1.40.0 librtmp/2.3
Release-Date: 2020-01-08
Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtmp rtsp scp sftp smb smbs smtp smtps telnet tftp
Features: AsynchDNS brotli GSS-API HTTP2 HTTPS-proxy IDN IPv6 Kerberos Largefile libz NTLM NTLM_WB PSL SPNEGO SSL TLS-SRP UnixSockets
==> GitHub Actions detected.
    Env vars used:
      -> GITHUB_ACTIONS:    true
      -> GITHUB_HEAD_REF:   add_code_cov
      -> GITHUB_REF:        refs/pull/198/merge
      -> GITHUB_REPOSITORY: apache/arrow-ballista
      -> GITHUB_RUN_ID:<PHONE_NUMBER>
      -> GITHUB_SHA:        80dc926f2f4c3edd89be24b10[5](https://github.com/apache/arrow-ballista/actions/runs/3026474487/jobs/4869894128#step:7:6)[6](https://github.com/apache/arrow-ballista/actions/runs/3026474487/jobs/4869894128#step:7:7)a0528c09d3[7](https://github.com/apache/arrow-ballista/actions/runs/3026474487/jobs/4869894128#step:7:8)0f
      -> GITHUB_WORKFLOW:   Rust
->  Issue detecting commit SHA. Please run actions/checkout with fetch-depth > 1 or set to 0
    current dir:  /home/runner/work/arrow-ballista/arrow-ballista
    project root: .
    Yaml not found, that's ok! Learn more at http://docs.codecov.io/docs/codecov-yaml
==> Running gcov in . (disable via -X gcov)
==> Python coveragepy not found
==> Searching for coverage reports in:
    + .
    -> Found 1 reports
==> Detecting git/mercurial file structure
==> Reading reports
    + ./cobertura.xml bytes=246999
==> Appending adjustments
    https://docs.codecov.io/docs/fixing-reports
    -> No adjustments found
==> Gzipping contents
        24K	/tmp/codecov.chHZNt.gz
==> Uploading reports
    url: https://codecov.io
    query: branch=add_code_cov&commit=[8](https://github.com/apache/arrow-ballista/actions/runs/3026474487/jobs/4869894128#step:7:9)0dc[9](https://github.com/apache/arrow-ballista/actions/runs/3026474487/jobs/4869894128#step:7:10)26f2f4c3edd89be24b[10](https://github.com/apache/arrow-ballista/actions/runs/3026474487/jobs/4869894128#step:7:11)56a0528c09d370f&build=3026474487&build_url=https%3A%2F%2Fgithub.com%2Fapache%2Farrow-ballista%2Factions%2Fruns%2F3026474487&name=&tag=&slug=apache%2Farrow-ballista&service=github-actions&flags=&pr=198&job=Rust&cmd_args=
->  Pinging Codecov
https://codecov.io/upload/v4?package=bash-1.0.6&token=<hidden>&package=bash-1.0.6&token=&branch=add_code_cov&commit=80dc926f2f4c3edd89be24b1056a0528c09d370f&build=3026474487&build_url=https%3A%2F%2Fgithub.com%2Fapache%2Farrow-ballista%2Factions%2Fruns%2F3026474487&name=&tag=&slug=apache%2Farrow-ballista&service=github-actions&flags=&pr=198&job=Rust&cmd_args=
{'detail': ErrorDetail(string='Could not find a repository, try using repo upload token', code='not_found')}
404
==> Uploading to Codecov
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 [24](https://github.com/apache/arrow-ballista/actions/runs/3026474487/jobs/4869894128#step:7:25)639  100   108  100 245[31](https://github.com/apache/arrow-ballista/actions/runs/3026474487/jobs/4869894128#step:7:32)    [44](https://github.com/apache/arrow-ballista/actions/runs/3026474487/jobs/4869894128#step:7:45)6    98k --:--:-- --:--:-- --:--:--   99k
    {'detail': ErrorDetail(string='Could not find a repository, try using repo upload token', code='not_found')}

I think we should create this project in https://app.codecov.io/ , but i am not the owner of the repo

I am also unable to do this. Maybe @alamb can remember how we set this up for the other repos?

I am also unable to do this. Maybe @alamb can remember how we set this up for the other repos?

I do not remember ever setting it up. When I tried to log into codecov it wanted access to my private repos, which I am not willing to allow and thus I can't see the app at all.


Error getting notebook structure from remarkable

I just set it up, clicked fetch, and received the following error:

Error getting notebook structure from remarkable
Enable to create cloud API client

Any idea how to fix?

I'm having a similar issue. Any fixes?
I get the error message: "Error importing documents from Remarkable. Object reference not set to an instance of an object"

same here no responds yet for a solution?

https://philerb.com/2021/12/26/remarkable-tablet-ssh/

No, unfortunately not.
On Wed, Jan 18, 2023, 2:50 PM mgschaub @.***> wrote:

same here no responds yet for a solution?
—
Reply to this email directly, view it on GitHub
https://github.com/jamesf91/reMarkableSync/issues/43#issuecomment-1396068819,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A4MQ6BDHSJSJXJLBYI7AOTLWTBJQHANCNFSM6AAAAAARWZZ3NQ
.
You are receiving this because you commented.Message ID:
@.***>

Having the same issue here and just ran the new update that was released an hour ago, any ideas?


Better killing and respawing options

It would be very helpful if the kill command, when passed a list of containers to kill, can kill a certain number of containers and keep the rest of the containers running.
Another option that goes with the above one, is the possibility to respawn killed containers.
Both of the options can be used together to randomly kill and respawn containers for a full chaos monkey experience !

seems like a good idea

Closing issue, since it's resolved: can limit number of container to kill.

Fixed.


T2M-GPT generated the Fatal Error joints points

This text is" A man is doing squats."  the red part is right side body, the blue part is left side body

https://github.com/Mael-zys/T2M-GPT/assets/37621028/ad41b6f8-50d3-4981-873d-d35edd70dfcd
https://github.com/Mael-zys/T2M-GPT/assets/37621028/83739ae7-91cc-4514-89db-6ca45474665f

Hi, do you solve this problem, I met this issue too.
I guess this is probably caused by the Mesh rendering process, which may not be able to distinguish the direction of body in some cases.

I find this problem has already been raised and answered in this issue https://github.com/Mael-zys/T2M-GPT/issues/25#issue-1678045855

Hi, do you solve this problem, I met this issue too.
I guess this is probably caused by the Mesh rendering process, which may not be able to distinguish the direction of body in some cases.

The 3d points are wrong, not the  problem of mesh . Watch the second video, you can find the red lines are the right side of body, but, when squatting, the hip is in front of knees!!! It is not normal human joints！！！


hint positionOverrides proposal

Related to #200

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


How to do benchmark for DS?

We have a lot of jobs to schedule every day, some of them should scheduled every five minutes, so in our usage scenario, the scheduling efficiency is the most important consideration.
For now, we use Airflow as our job scheduler, but along with the job and job instance increase, the pull up time of every job instance increase too, especially for the job should schedule in minutes are unbearable.
This is why we need do benchmark for DS. But I think one complete benchmark design is the first thing we should do, so can we discuss this?

我们每天有大量的任务需要调度，其中有些任务是每五分钟就要调度一次的，所以在我们的应用场景中，调度效率是最重要的考虑点。
当前我们使用Airflow作为我们的任务调度器，但是随着任务配置和任务实例的增长，单个任务被拉起的时长也随着增长，尤其对于那种几分钟就要执行一次的准实时任务，这是拉起时长是无法接受的。
这就是为什么我们需要针对DS做性能测试，但是我想在进行测试之前应当设计一个完备的性能测试方案，所以我们能一块讨论一下吗？

I'm also more interested in this
I am familiar with the code part and can communicate with each other

At present, ds is still strongly dependent on the database, so in the process of testing, should we use the form of a simulated database for benchmark testing?

跟你需求基本一致，请教一下最终选了哪个？

same question,has anyone done any benchmark for DS?
@CalvinKirs @zhongjiajie

I think it still do not have benchmark test for DolphinScheduler, Am I right? @caishunfeng

I think it still do not have benchmark test for DolphinScheduler, Am I right? @caishunfeng

Yes, we haven't done. And I think the stress test results have a lot to do with your tasks, but if you only want to test the main scheduler, you can try dry run.

cc: @RedemptionC  and @rockxsj


Export to complete security group wiring

Without this export, addition of the EFSSecurityGroup into the source EFS security group must be done manually using AWS CLI. This export will allow the backup stack to be included as a nested stack in a complete solution without resorting to AWS CLI.

Thank you for your contribution! We will take these changes into consideration for future versions of this solution.

?Duplicate of #24

Ah, yes - sorry, my mistake.
Perhaps both changes should be in the same PR.

This helps you separate the changes, one per PR, but if you want, please close these two and I'll open a combined one.

@ab77: The Restore Template in version 1.4 contains the EFSSecurityGroup in its outputs.  Thank you for your contribution!


Use @next/plugin-storybook

Cross-post https://github.com/vercel/next.js/issues/19345

This plugin won't happen, Next.js team is now working on sb integration.


If ¶s are present, use dynamic sidebar content

Summary of changes
Asana Ticket: Remove hard-coded project sidebar
When paragraphs are present, don't use the hard-coded sidebar; use the dynamic sidebar that generic pages use (includes ordered paragraphs of content lists).

added comments
simplified if/then logic/conditions

@amaisano looks good but this time I'll wait for Semaphore to finish

@phildarnowsky I fixed that rebase issue. Should be good for a final look.


tf_export fails when selecting resource type genesyscloud_knowledge_knowledgebase

Using Plugin v1.14.0 and running a tf_export using only the resource type of "genesyscloud_knowledge_knowledgebase" the terraform never completes.  A manual cancel is required.
# genesyscloud_tf_export.init will be created
  + resource "genesyscloud_tf_export" "init" {
      + directory             = "./tmp_sa"
      + export_as_hcl         = false
      + id                    = (known after apply)
      + include_state_file    = true
      + log_permission_errors = false
      + resource_types        = [
          + "genesyscloud_knowledge_knowledgebase",
        ]
    }

genesyscloud_tf_export.init: Creating...
genesyscloud_tf_export.init: Still creating... [10s elapsed]
.....
genesyscloud_tf_export.init: Still creating... [8m20s elapsed]
Stopping operation...

Interrupt received.
Please wait for Terraform to exit or data loss may occur.
Gracefully shutting down...

When debug logs are checked the API call seems to be repeated constantly but never goes further.  See attached sdk logs
When running tf_export excluding knowledge ( and SMS Addresses due to #490 ) it completes in 1 min 30 sec.
sdk_debug.log
Thanks
Gordon

Hi Gordon
Thanks for raising this issue.
It looks like the exporter for knowledgebases is filtering by "published": false, which is a mistake. Although I'm not sure why your export is getting stuck. If you don't mind, could you confirm that you have no problems running GET /api/v2/knowledge/knowledgebases against the same org that you are exporting (with published set to false)? This would just help me rule out other potential culprits.
Regards
Charlie

@gordon-walker Apologies, you can ignore the above request. I was able to recreate the behaviour locally.
We will take a look into the problem and get a fix out ASAP.
Thanks again
Charlie


Explicitly require devise

The call to Devise.add_module here will fail unless devise has already been required before requiring devise-async. In a rails app, the practical implication of this is that devise must be explicitly listed in the gemfile before devise-async even though devise-async depends on devise explicitly.

@derekprior Thanks!


[Notebook] Create first notebook using Spark Sessions in Vertex AI

Create the first implementation of a notebook focusing on the AI/ML use case, leveraging Dataproc Spark Sessions in Vertex AI.
It should be a template to facilitate the development of data processing pipelines using Spark, for specific sources and sinks, and allow the user to add the required transformations needed for the ML model development.

@nehamodgil @NiloFreitas
Refer to this Jupyter notebook for inspiration: https://github.com/GoogleCloudPlatform/serverless-spark-workshop/blob/main/timeseries_forecasting/README.md

obsolete


Support SQL Server inline table valued functions?

Is your feature request related to a problem? Please describe.
We've been changing several of our table valued functions from the standard format like below to inline table valued functions
CREATE FUNCTION dbo.FN_SomeFunction(
@InputVar VARCHAR(50)
)
RETURNS @functionResult TABLE (
output VARCHAR(50)
)
AS
BEGIN
INSERT INTO @functionResult(output)
Select resultOutput as output
from dbo.TableA
where  something = @inputVar;
 RETURN

END;
We've found numerous performance improvements by using inline TVF functions where it's written like:
CREATE FUNCTION dbo.FN_SomeFunction(
@InputVar VARCHAR(50)
)
RETURNS TABLE
AS
RETURN (
Select resultOutput as output
from dbo.TableA
where  something = @inputVar;
);
Describe the solution you'd like
@GoEddie
Is there a way to get SQLCover to cover these functions when a tSQLt test is created for this function? It does not show up in the list of evaluated code objects or in the coverage.coverxml outputs.
Describe alternatives you've considered
The only alternative I have is to put the functions back but then we degrade our performance.
===
Please at me @GoEddie so I receive a notification

hi @jpdougherty , did you find any way to handle the above ?


Feature matrix

We currently do not have feature parity across all frameworks. We should put together a simple feature matrix, where each column is a target (Angular, React, React-Native, Vue, etc.), and each row is a feature.
For now, a simple labelling system would work:
🏗 in-progress/partially implemented
❌ not implemented
✅ implemented
Here is a non-comprehensive example list of rows:

lifecycle methods (each would be a separate row): onUnMount, onMount, onUpdate
dynamic styles
state
refs
Show/For/etc. (Mitosis-specific components)
children

An easy way to identify support for a feature is to use the fiddle and compare the outputs.
We can start with a partial list, and then start adding more as we notice discrepancies

Closed by #247

E2E testing should validate the features that work across N targets. The initial fully-supported set (features that work "everywhere") might be pretty small, but should grow nicely over time.


Landing page instance10

Fixes #176
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes #176
New Landing Page Design added

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] Any dependent changes have been merged and published in downstream modules

Reviewer: Vinit Shahdeo

@FrozenGirl-spd Please make your PR to frontend branch. You have created PR to master branch.


Backport x86 asm changes from dav1d 1.2.0

Partially addresses #225

I will do the port to Rust manually. As you say, the changes look simple enough

Closing this PR. Will resubmit separate PRs as more C code actually needs to be pulled in.

I assume you just did this recently for https://github.com/memorysafety/rav1d/pull/215, so maybe you have some advice for doing it easily?

I simply re-transpiled the affected files using the --filter flag and made sure I only patched in the Rust lines corresponding to the changes in C files. Careful review will hopefully catch any inadvertent changes to the Rust.


NIFI-5510: Introducing PutCassandraRecord processor

Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Been meaning to kick the tires on Cassandra a bit. Would a vanilla Docker image do or is there more setup required to work this?

@MikeThomsen No complex setup is required. A Cassandra cluster has to be up and running. That's all.

PutCassandraRecord_Test.xml.txt
Validated that it works with that simple flow. I was able to use that to insert a few records and see them with cqlsh.

NP. We should discuss making a controller service that handles the connection pooling for Cassandra. Doesn't have to go in here, but it would be one less thing to update if it were.

Yeah, I have actually started the implementation for a connection pool service. Wasn't able to open up a Jira. Got held up with some other things. I'll be doing it and will also wrap up the implementation and raise a PR.

Sounds good. We can put this on hold while you do that client service PR.

I think we can merge this one, if everything checks out good instead of waiting.

Merged. Thanks for the contribution.


fix Fix cloud meet e-230 not retry query from observer

Proposed changes
Issue Number: close #xxx

run buildall


TSS

rerun code, cross check with paper
check for missing metadata or data

Waiting on final water quality dataset

@amyerspigg what columns do we want in the L2 dataset? current columns are:
"campaign"            "kit_id"              "transect_location"   "tss_mg_perl"         "total_filter_mass_g" "volume_filtered_ml"  "filters_used"        "tss_flag"

@stephpenn1  just saw this....I think we just want the first 4 columns


What was the intention for this change?

@luziusmeisser
https://app.test.frankencoin.com/mint/0x123A7a6202F7874B095cC56F025e0fD768070F5F

Why is the position its own parent?

Considered fixed and done
Separation of Parent and Original in V2
https://github.com/Frankencoin-ZCHF/ponder/pull/23
https://github.com/Frankencoin-ZCHF/frankencoin-api/pull/23
Position V2 Original

Position V2 Clone of Clone


BUG: Correct method for finding security lists directory

The correct thing to look at to figure out where the root of the
zipline tree is, is zipline.__file__, not zipline.__path__. The
latter could contain multiple directories in it, and is not intended
to be os.path.join()ed as the previous code was doing.

Can somebody take a look at this minor fix? Thanks.

Looks right to me @jikamens .

Coverage remained the same at 87.53% when pulling cd98b524549509cb67b77bfdb9aa819e98e40f64 on minor_zipline_path_fix into fd0530d8898a6e6be6f64fe708f1bb356e7ed595 on master.


unify _id constants

Unify Constants and utilities for “_id” in DefaultIdUtils and refactor the code

Codecov Report

Merging #154 into devel will decrease coverage by -0.01%.
The diff coverage is 8.33%.

@@             Coverage Diff              @@
##              devel     #154      +/-   ##
============================================
- Coverage     18.23%   18.23%   -0.01%
+ Complexity     1506     1505       -1
============================================
  Files           736      735       -1
  Lines         26438    26436       -2
  Branches       2322     2322
============================================
- Hits           4822     4820       -2
+ Misses        21314    21313       -1
- Partials        302      303       +1

Impacted Files
Coverage Δ
Complexity Δ

...b/repl/commands/impl/CreateCollectionReplImpl.java
15.78% <ø> (ø)
2 <ø> (ø)
:x:

.../java/com/torodb/torod/impl/memory/MemoryData.java
25.71% <ø> (ø)
2 <ø> (ø)
:x:

...mands/signatures/repl/ReplSetGetStatusCommand.java
0% <ø> (ø)
0 <ø> (ø)
:x:

.../java/com/torodb/mongodb/utils/DefaultIdUtils.java
0% <ø> (ø)
0 <ø> (ø)
:x:

...godb/repl/commands/impl/CreateIndexesReplImpl.java
41.55% <ø> (ø)
6 <ø> (ø)
:x:

...ngodb/language/update/SetDocumentUpdateAction.java
0% <ø> (ø)
0 <ø> (ø)
:x:

...db/commands/impl/general/InsertImplementation.java
0% <ø> (ø)
0 <ø> (ø)
:x:

...db/commands/impl/general/UpdateImplementation.java
0% <ø> (ø)
0 <ø> (ø)
:x:

...orodb/mongodb/commands/pojos/ReplicaSetConfig.java
0% <ø> (ø)
0 <ø> (ø)
:x:

...om/torodb/mongodb/commands/pojos/MemberConfig.java
0% <ø> (ø)
0 <ø> (ø)
:x:

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c589f33...ce3ca18. Read the comment docs.


Consider remove jsonc output formatter

There are existing tools to colorize the json output. For example, az ad user list | jq generated colorized results as well.

This can reduce the number of dependencies and simplify the output logic. In addition, this reduce the chances that issues caused by color marks.

At this point, it's unlikely we'll remove jsonc so closing but you're welcome to re-open...

Should we take a look at the telemetry to see if anyone is actually using jsonc?


[Support] Updating Envoy SHA in 1.0 to patch a bug in Envoy

I am looking to pull this fix from Envoy into istio-proxy (release 1.0) and had some questions about it: https://github.com/envoyproxy/envoy/commit/d646949e0534557084196dea850c26599e53f1b8

Is it sufficient to run Circle CI builds for istio-proxy? Or is there any integration test that involves istio repo that includes mixer and pilot?
linux_asan and linux_tsan builds are failing with missing libraries. I searched for similar issue and looks like this could be due to insufficient resources in Circle CI for the free plan. Can you confirm if I will need un upgraded plan to run these tests?
clang++-7: error: unable to execute command: Killed
How do I build a docker image of istio-proxy? I think make docker is only applicable for the main istio/istio repository.

When I build custom sidecar issues for testing I do something like this:
GOOS=linux make pilot-agent
HUB=esnible TAG=issue11322 GOOS=linux make docker.proxyv2
docker push esnible/proxyv2:issue11322

"HUB" is my Docker account, and TAG is some tag I am using so that I can keep track of which bug I am attempting to fix.  Replace those with your own values.
After I have pushed a personal test build to Docker hub I do kubectl -n istio-system edit cm istio-sidecar-injector and replace gcr.io/istio-release/proxyv2:<tag> with my private image.

Thanks @esnible I am able to build using the steps you provided. Although, I am not sure how to build using the modified istio-proxy instead of the default one.
I have created a clone repo with the patch I need at https://github.com/adityats2020/proxy. The make docker.proxyv2 build step seems to obtain the built artifacts from a specific location that is defined in bin/init.sh. I am not sure how to generate these artifacts from my repository, and how to link them in this script. Any tips for doing that?

Digging into the build files a bit, it looks like pre-built istio proxy binaries are required for building the docker image.
https://github.com/istio/istio/blob/master/bin/init.sh#L93-L97
This script seems to be the place where the binary is built. I don't understand the context behind having to build this binary in Ubuntu as seen in code here. There didn't seem to be any actual dependency on Ubuntu in the script after that. I commented those lines out and was able to build a binary.
Corresponding docker image does not start up. The built binary is definitely not the binary for building docker image. The size of this binary compared to a valid binary in google repo is way too small.
I am very likely doing things I don't have to. Would appreciate if someone can help me build this docker image.


Invalid parses should register as NotFound failures when appropriate

If we have two routes
/foo/:Int
/foo/bar

where :Int signifies that we should URIDecode an Int at that point, then a failure to decode should pass on to /foo/bar as a route. Right now it's possible we're too greedy!

9cc124236f2aca0ed0b22d95b08c8aaafcee9e27 fixes a similar bug, but sadly not this one

Should I take it you comment should have read as.

where :Int signifies that we should URIDecode an Int at that point, then a failure to decode should pass on to /foo/bar as a route. Right now it's not possible we're too greedy!

Yeah, that's fair. I wrote it is "it is possibly the case that we are today too greedy", but it's also true that the situation outlined is not possible today because of that.
In either case, it'd be good to be less greedy!


Question: Why construct SQLiteAsyncConnection with a function?

I ran into an issue where I was creating my app's sole SQLiteAsyncConnection in the following manner:
var conn = new SQLiteAsyncConnection(() => new SQLiteConnectionWithLock(...));
Looking at the source code for SQLiteAsyncConnection, the function passed in as a constructor parameter is called in GetConnection(), which is called any time the SQLiteAsyncConnection needs to read or write to the database.
So this caused a new connection to be instantiated any time conn performed a read or write.  In effect, even though I was being very deliberate to only have one database connection for the entire app, the "hidden" inner workings (I am using the Nuget packages) of SQLiteAsyncConnection were causing my app to have multiple connections at any given time, which caused database locking issues once I reached a critical mass of database read/write operation calls.
My question: why is SQLiteAsyncConnection designed this way?  Why not simply pass in a SQLiteConnectionWithLock to the constructor, instead of a function that returns one?  Or have SQLiteAsyncConnection call the function once, store its result in a private member variable, and then return that variable in GetConnection() instead of running the constructor function parameter every time?
I guess the issue, once realized, is easy to get around -- I simply instantiated a SQLiteConnectionWithLock outside of the function and then passed in that object's accessor as the construction function parameter -- but it's still an unnecessary "gotcha" in my opinion.

@rudmer90,
I am using the "SQLiteAsyncConnection".
As you said in the issue,I am getting the SQLite Exception that "Database  Locked".
Please suggest me,how to avoid database locking issue.
I am thinking that,I need to implement some kind of lock while performing the database operations.
Please suggest the best way to resolve this issue.


[Improvement-#7529][tools] Init DB schema from the full sql file.

Purpose of the pull request

Improvement the issue #7529 ,Init DB schema from the full sql file.
Brief change log
Change the DolphinSchedulerManager、CreateDolphinScheduler and UpgradeDao
Modify the file name of dolphinscheduler_postgre.sql to dolphinscheduler_postgresql.sql

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

Merging #7530 (26eadf6) into dev (49662c7) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #7530      +/-   ##
============================================
- Coverage     41.27%   41.25%   -0.03%
+ Complexity     3673     3669       -4
============================================
  Files           641      641
  Lines         26467    26467
  Branches       2961     2961
============================================
- Hits          10925    10919       -6
- Misses        14517    14519       +2
- Partials       1025     1029       +4

Impacted Files
Coverage Δ

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...e/dolphinscheduler/remote/NettyRemotingClient.java
50.70% <0.00%> (-2.82%)
:arrow_down:

...dolphinscheduler/remote/future/ResponseFuture.java
81.96% <0.00%> (-1.64%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49662c7...26eadf6. Read the comment docs.


[update] update command for binary and launcher updates

Summary
This PR enables jetpack version update to:

Update the launcher. We detect if the launcher version is outdated, and update it, if needed. This also updates the binary as a side-effect. This requires sudo so we only do it, if necessary.

Update just the binary. If the launcher is up-to-date, then we update just the CLI binary.

Will only land this after the launch.sh file is updated in https://github.com/jetpack-io/axiom/pull/3150
How was it tested?
Did some basic testing:

Binary updating:

change currentChannel to latest
do devbox version update
see the devbox version of 0.0.0-dev be printed

TODO: would like to test binary update with the latest launcher (will do after https://github.com/jetpack-io/axiom/pull/3150) is ready

TODO: Check launcher update by amending LAUNCHER_VERSION to be an older version

Current dependencies on/for this PR:

main

PR #965   👈

This comment was auto-generated by Graphite.

Updated code, but need to test properly.

I'm going to merge #966 into this PR, prior to merging to main so there is one commit to cherrypick


Updated recipe/meta.yaml to version 3.23.0

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Add ranges starts_with and ends_with algorithms

Added the ranges::starts_with and ranges::ends_with algorithms.
Any background context you want to provide?
Issue #5381

@hkaiser Sure, you mean instead of relying on the mismatch and equal algorithms, write our own implementation?

@hkaiser Sure, you mean instead of relying on the mismatch and equal algorithms, write our own implementation?

No, relying on those algorithms is fine. I just would like to avoid for the iterator algorithms to rely on the range-algorithms.

@hkaiser I've added the iterator based overloads as discussed. Are these okay or did you have some others in mind?

The new algorithms should be added to the file #include <hpx/parallel/algorithm.hpp>

Can one of the admins verify this patch?

@Jedi18 could you please fix the conflict? Once that's done this can be merged.

Could you hold on the merging for a bit? starts_with range test seems to be failing, I'll have a look at it.

@msimberg Ok so the starts_with range test crashes. I looked into it and it seems the error is not with this PR code but with the mismatch parallel implementation. I ran the mismatch_binary range test and that crashes the same way too.
This test was running earlier (before the rebase) so I guess the crash is due to some recent changes. Any idea what it could be?

@msimberg Ok so the starts_with range test crashes. I looked into it and it seems the error is not with this PR code but with the mismatch parallel implementation. I ran the mismatch_binary range test and that crashes the same way too.
This test was running earlier (before the rebase) so I guess the crash is due to some recent changes. Any idea what it could be?

Nothing relevant comes to mind. What do you mean by crashing? The test fails on CI, but are you seeing something worse (segfault or similar)?

@msimberg Ok so the starts_with range test crashes. I looked into it and it seems the error is not with this PR code but with the mismatch parallel implementation. I ran the mismatch_binary range test and that crashes the same way too.
This test was running earlier (before the rebase) so I guess the crash is due to some recent changes. Any idea what it could be?

Nothing relevant comes to mind. What do you mean by crashing? The test fails on CI, but are you seeing something worse (segfault or similar)?

Yes it segfaults when running locally (when passing in par(task))

Sure I'll look into it! It happens on master too btw.

I think it's a visual studio thing because it happens even if I go back to a commit from three months ago. Also it only happens in Debug. Something related to the destruction of the futures I think though it's hard to tell. Do you want me to dig deeper?

I think it's a visual studio thing because it happens even if I go back to a commit from three months ago. Also it only happens in Debug. Something related to the destruction of the futures I think though it's hard to tell. Do you want me to dig deeper?

Well, yes, we need to fix it. How can I reproduce the issues you're investigating?

@hkaiser Ok I will. Run the mismatch_binary test (on master or this branch, dosen't matter) in Debug mode. Does it show a read access violation for you too?

@hkaiser Ok I will. Run the mismatch_binary test (on master or this branch, dosen't matter) in Debug mode. Does it show a read access violation for you too?

Yes, I can reproduce this problem. Let me see what I can do.

@Jedi18 sorry for the delay. Could you please rebase this so we can finally merge it?

Looks good! I just reran build-and-test cause it timed out


Weird system dialog popping out when trying to open Kaku

Bug
A user left a comment that when trying to use Kaku every time, there is a system dialog popping out and asking for confirmation.
Please check the screenshot below :

Steps to reproduce the bug
Open Kaku, it will show up every time.
What is your Kaku version ?
1.7.0
What is your OS with version number ?
Mac OS X 10.11.5
Which platform you are using to listen to music ?
Not related
Which track format you are using ?
Not related
Is there any error coming from Inspector ?
Seems no

Others
No

https://discuss.atom.io/t/accept-incoming-network-connections-osx-during-development/24822
http://discuss.prepros.io/t/keeps-asking-to-allow-atom-helper-app-during-start-up/168
Someone said when the app got signed, things can be solved ? Will try to codesign the application by myself for following releases.

I assumed this issue will be solved by codesigning the app, just merged a new patch to use electron-builder and help us codesign things !


Question about the versioning between a schema and a Module

How to Plaster will manage the versioning ?
Does each schema version will be coupled with a module version ?
Or a module version will be able to manage multiple versions of a schema?
What will happen in the following case:
I have  the version 1.0 of the module and I download a manifest for the schema version 1.2 ?

Thanks for the reminder to add the schemaVersion check code.  I will be checking that in soon. The basic idea is this.  The XSD namespace should rarely change i.e. only in cases of breaking changes.  In theory, Plaster could support v1, v2, v3 with different code paths to handle the different schema versions.  That is a lot of extra work so there will be motivation to avoid breaking changes.  In fact, the most likely breaking change WRT the manifest is if we decided to move to a different file format (JSON or PS DSL).
What I do expect to happen is that we incrementally add manifest directives over time.  This will necessitate an increment to the minor version number of the schemaVersion attribute e.g. <plasterManifest schemaVersion="major.minor"/>.
Each version of Plaster will have a module level variable:
$LatestSupportedSchemaVersion = [System.Version]'0.3'

If someone attempts to load a Plaster template with a version number greater than this, they will get the following error message:
The template's manifest schema version (1.1) requires a newer version of Plaster. Update the Plaster module and try again.


TableId uniqueness should be guaranteed on runtime

Lens uses tableId parameter for <ItemListLayout> component to identify tables. Right now this parameter is a simple string that is set by developers in each relevant view component:

Uniqueness of these IDs is not verified or enforced on runtime in any way.
Since <ItemsListLayout> component is used with extensions, this might introduce bugs with persistent table configurations handled by UserStore. We should introduce a way for developers to ensure uniqueness of tableIds they're using, e.g. through extension-specific namespaces.

I guess we also need a notion of owning an ID since we cannot just track which IDs are currently being used since it might not have rendered the <ItemsListLayout> yet.

Since <ItemsListLayout> component is used with extensions, this might introduce bugs with persistent table configurations handled by UserStore. We should introduce a way for developers to ensure uniqueness of tableIds they're using, e.g. through extension-specific namespaces.

Can't spot re-export of ItemListLayout in src/extensions/renderer-api/components.ts? So it seems it's not used with extensions? Anyway, adding some validator in runtime to check id-s won't hurt :)

Its props is but that is because of KubeItemListLayout

@Nachasic What exactly do you want to prevent? Two different components using the same TableId? What if the two instances are never "alive" at the same time, what if the extension one loaded before Lens's one?
Might it be better to just prefix any extension's use of TableId with the Extension's name?


[SPARK-34015][R] fixing input timing in worker.R

What changes were proposed in this pull request?
When sparkR is run at log level INFO, a summary of how the worker spent its time processing the partition is printed. There is a logic error where it is over-reporting the time inputting rows.
In detail: the variable inputElap in a wider context is used to mark the end of reading rows, but in the part changed here it was used as a local variable for measuring the beginning of compute time in a loop over the groups in the partition. Thus, the error is not observable if there is only one group per partition, which is what you get in unit tests.
For our application, here's what a log entry looks like before these changes were applied:
20/10/09 04:08:58 INFO RRunner: Times: boot = 0.013 s, init = 0.005 s, broadcast = 0.000 s, read-input = 529.471 s, compute = 492.037 s, write-output = 0.020 s, total = 1021.546 s
this indicates that we're spending more time reading rows than operating on the rows.
After these changes, it looks like this:
20/12/15 06:43:29 INFO RRunner: Times: boot = 0.013 s, init = 0.010 s, broadcast = 0.000 s, read-input = 120.275 s, compute = 1680.161 s, write-output = 0.045 s, total = 1812.553 s
Why are the changes needed?
Metrics shouldn't mislead?
Does this PR introduce any user-facing change?
Aside from no longer misleading, no
How was this patch tested?
unit tests passed. Field test results seem plausible

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@HyukjinKwon -- please have another look

@HyukjinKwon -- please have another look

ok to test

ok to test

Test build #133695 has started for PR 31021 at commit cbad669.

Test build #133695 has started for PR 31021 at commit cbad669.

Test build #133695 has finished for PR 31021 at commit cbad669.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #133695 has finished for PR 31021 at commit cbad669.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38283/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38283/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133695/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133695/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38283/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38283/

Merged to master and branch-3.1

Merged to master and branch-3.1

Thanks, @WamBamBoozle.

Thanks, @WamBamBoozle.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38283/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38283/


Refactor and tests

alternative to #2

@IanSavchenko the pull request branch had a "fixup" commit, I was going to rebase after you a would approve the review -- it still looks pending (yellow circle)
I'll push force to master now

@andreineculau Sorry, didn't see that. Strange that my circle is still yellow

Ok, got it now.


Filter cilium monitor/hubble observe by tcp flags

The most meaningful packets of a TCP stream are the opening SYN/ACk and final FIN/RST.  For the cilium monitor/hubble observe CLIs (and companying APIs), it would reduce CPU load and visual noise to offer filtering by tcp flags.
Proposal / RFE
Is your feature request related to a problem?
The utility of cilium monitor/hubble observe is significantly lowered on a busy host.  Each packet adds non-trivial overhead, and in many cases the middle packets of a TCP stream add little value.
We hope to use this functionality to build an audit log for egress-to-internet communication, but this functionality would seem to improve the utility of cilium monitor/hubble observe for many use cases.
Describe the solution you'd like
It would be desirable to be able to filter by TCP flags.  Even more so, it'd be ideal if this filtering was able to be accomplished within the BPF stack to avoid pushing unnecessary load to the userspace.

@jcodybaker @Rolinh I was badly in need of this filter. Hence I have taken a dig at it and got it working. However, wanted to confirm/cross-check with you the command-line rationale.
I have added a new tcp-ctrl filter in the protocols such that one can apply the filter in the following way:
hubble observe --protocol tcp-ctrl

using tcp-ctrl will show up only tcp packets with any of (SYN || FIN || RST || URG || ECE || CWR) flag set. TCP packets with just (ACK || PSH) flag set will be ignored with tcp-ctrl.

On second thought, I changed the cli interface to following:
hubble observe --protocol tcp:SYN,FIN

results in TCP packets getting shown which has SYN and FIN bit set.
Possible flags(case-insensitive) are SYN,FIN,RST,URG,ECE,CWR,NS,ACK,PSH. If no flags are specified i.e., only --protocol tcp is specified then it results in current/default behavior of show all tcp packets.

@nyrahul Awesome! I do like your second proposal --protocol tcp:SYN,FIN. Thanks a lot for the input, your use-case about filtering out ACK/PSH makes a ton of sense to me.
So I think there are two discussion points here.

How to implement TCP filtering in the API.
How to expose TCP filtering in the CLI flags.

The first one is important because upcoming versions of Hubble UI already supports client-side TCP-flags filtering. So if we add the same functionality server-side, we want to make sure our API covers the UI use-case and the use-case presented in this thread. It does look like your implemention seems to do the same. Still, I'm curious how implemented this in the gRPC API e.g. in message FlowFilter?
Or is this a client-side (CLI) only implemention? Because I do believe we should add this server-side.

@gandro thanks for the feedback. I pushed my commit which shows how this is implemented in flow filter. Please check if this is as per expected for Hubble UI. If not, I can update/align the changes as per expected. Should I raise a draft PR for this?

Thanks for the PR! I have left some thoughts inline, but for cross-reference, I'll link it here as well: https://github.com/cilium/cilium/pull/12932#discussion_r473977129


[Edge] Tooltip not displayed on hover and wrongly display at the page top on pinned

What did you do?
Open a dashboard including a TimeSeriesChart (for example https://demo.perses.dev/projects/myworkshopproject/dashboards/myfirstdashboard?var-instance=demo.do.prometheus.io%3A9100&var-job=node&start=1h&refresh=0s) on Edge.
Both scenarios work properly on Firefox or Chrome.
What did you expect to see?
In Chrome and Firefox, tooltip appear when hovering the graph and is pinned at the cursor position upon click.
When inspecting the element I can see the proper translate3d styling:

What did you see instead? Under which circumstances?
When using Edge:

If I hover the graph, no tooltip is displayed.
If I click on the graph, the tooltip appears but is pinned at the page top

When I inspect the element, styling is missing:

System information
No response
Perses version
No response
Perses configuration file
No response
Logs
No response

Tracing back the issue to tooltip-model.js, it seems related to the zrender mousemove coords not being defined in the MouseEvent in Edge.

Hello, you are talking about Edge Chromium or Edge Legacy? 👀

Edge Chromium


Fixed a crash in BlurFilter

apparently making the destPoint null crashes, so this fixes that

When calling BitmapData.applyFilter(), Flash throws the following error when destPoint is null:
TypeError: Error #2007: Parameter destPoint must be non-null.
	at flash.display::BitmapData/applyFilter()

With that in mind, OpenFL allowing destPoint to be null doesn't seem right to me.

When calling BitmapData.applyFilter(), Flash throws the following error when destPoint is null:
TypeError: Error #2007: Parameter destPoint must be non-null.
	at flash.display::BitmapData/applyFilter()

With that in mind, OpenFL allowing destPoint to be null doesn't seem right to me.

yeah, apparently I found out by testing that making it null crashed and I made my own little fix for it, and if someone else had done the same thing, I thought fixing it would help but I feel like this just seems wrong, so I’m just gonna close this

I’ll keep the branch just in case


Csv array is converted to single string instead of array of strings

Hi, here is my CSV
"name", "tags"
"test name", "[""tag1"",""tag2""]"

it's being converted to:
{
  "name": "test name",
  "tags": "[\"tag1\",\"tag2\"]",

}

I would expect to get
"tags": ["tag1", "tag2"]

I would consider  "["tag1","tag2"]" as the expected behaviour. JSON.parse() should fix your issue.

Ok, I will try to add a custom column parser.