Feature/serilog property filter

Need a way to filter embedded Serilog LogEvent properties from being added to serialized / converted ECS Base.Metadata.
For example if I have embedded properties in my Serilog log event's that I used in the EcsTextFormatterConfiguration.MapCustom to enrich the ECS fields, I won't want it to be added to metadata. There's no other way to filter out a log event property, can't even remove it via EcsTextFormatterConfiguration.MapCustom because it's called after GetMetadata in LogEventConverter.ConvertToEcs. Even if the order was rearranged, still could not remove in MapCustom (i.e. LogEvent.RemovePropertyIfPresent) because the LogEvent is passed by reference so any subsequent renderings of a given logEvent, to different targets will not contain the previously removed property.
Also need a way to set the Serilog Tests LogTestBase classes Formatter property.

:grey_exclamation: Build Aborted

The PR is not allowed to run in the CI yet

Expand to view the summary

Build stats

Build Cause: [Pull request #90 opened]

Reason: The PR is not allowed to run in the CI yet

Start Time: 2020-06-19T23:40:48.369+0000

Duration: 3 min 0 sec

Commit: 421ac07bfdf4a339de36da5e7aae900cf03897e7

Steps errors
Expand to view the steps failures

Name: Error signal

Description: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permission

Duration: 0 min 0 sec

Start Time: 2020-06-19T23:43:44.067+0000

log

Log output
Expand to view the last 100 lines of log output

[2020-06-19T23:43:20.154Z]  > git init /var/lib/jenkins/workspace/gent-dotnet_ecs-dotnet-mbp_PR-90 # timeout=10
[2020-06-19T23:43:20.223Z] Fetching upstream changes from git@github.com:elastic/ecs-dotnet.git
[2020-06-19T23:43:20.224Z]  > git --version # timeout=10
[2020-06-19T23:43:20.235Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-06-19T23:43:20.268Z]  > git fetch --no-tags --progress -- git@github.com:elastic/ecs-dotnet.git +refs/heads/*:refs/remotes/origin/* # timeout=15
[2020-06-19T23:43:21.129Z] Cleaning workspace
[2020-06-19T23:43:21.151Z] Pruning obsolete local branches
[2020-06-19T23:43:21.784Z] Merging remotes/origin/master commit d6e4a1916ab375765d544553d65c6677554190cf into PR head commit 421ac07bfdf4a339de36da5e7aae900cf03897e7
[2020-06-19T23:43:21.942Z] Merge succeeded, producing 421ac07bfdf4a339de36da5e7aae900cf03897e7
[2020-06-19T23:43:21.942Z] Checking out Revision 421ac07bfdf4a339de36da5e7aae900cf03897e7 (PR-90)
[2020-06-19T23:43:21.096Z]  > git config remote.origin.url git@github.com:elastic/ecs-dotnet.git # timeout=10
[2020-06-19T23:43:21.107Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
[2020-06-19T23:43:21.120Z]  > git config remote.origin.url git@github.com:elastic/ecs-dotnet.git # timeout=10
[2020-06-19T23:43:21.131Z]  > git rev-parse --verify HEAD # timeout=10
[2020-06-19T23:43:21.138Z] No valid HEAD. Skipping the resetting
[2020-06-19T23:43:21.138Z]  > git clean -fdx # timeout=10
[2020-06-19T23:43:21.157Z] Fetching upstream changes from git@github.com:elastic/ecs-dotnet.git
[2020-06-19T23:43:21.157Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-06-19T23:43:21.162Z]  > git fetch --no-tags --progress --prune -- git@github.com:elastic/ecs-dotnet.git +refs/pull/90/head:refs/remotes/origin/PR-90 +refs/heads/master:refs/remotes/origin/master # timeout=15
[2020-06-19T23:43:21.791Z]  > git config core.sparsecheckout # timeout=10
[2020-06-19T23:43:21.796Z]  > git checkout -f 421ac07bfdf4a339de36da5e7aae900cf03897e7 # timeout=15
[2020-06-19T23:43:21.868Z]  > git remote # timeout=10
[2020-06-19T23:43:21.890Z]  > git config --get remote.origin.url # timeout=10
[2020-06-19T23:43:21.904Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-06-19T23:43:21.909Z]  > git merge d6e4a1916ab375765d544553d65c6677554190cf # timeout=10
[2020-06-19T23:43:21.931Z]  > git rev-parse HEAD^{commit} # timeout=10
[2020-06-19T23:43:21.943Z]  > git config core.sparsecheckout # timeout=10
[2020-06-19T23:43:21.954Z]  > git checkout -f 421ac07bfdf4a339de36da5e7aae900cf03897e7 # timeout=15
[2020-06-19T23:43:25.673Z] Commit message: "Allow filtering of Serilog LogEvent properties from being added to EcsBase.Metadata"
[2020-06-19T23:43:25.673Z] First time build. Skipping changelog.
[2020-06-19T23:43:25.673Z] Cleaning workspace
[2020-06-19T23:43:25.726Z]  > git --version # timeout=10
[2020-06-19T23:43:25.734Z] fatal: bad object 7b930a3804b10ff3bcb3c225fac203f82497ed48
[2020-06-19T23:43:25.674Z]  > git rev-parse --verify HEAD # timeout=10
[2020-06-19T23:43:25.681Z] Resetting working tree
[2020-06-19T23:43:25.681Z]  > git reset --hard # timeout=10
[2020-06-19T23:43:25.688Z]  > git clean -fdx # timeout=10
[2020-06-19T23:43:26.625Z] Masking supported pattern matches of $JOB_GCS_BUCKET or $NOTIFY_TO
[2020-06-19T23:43:26.684Z] Timeout set to expire in 1 hr 0 min
[2020-06-19T23:43:26.710Z] The timestamps step is unnecessary when timestamps are enabled for all Pipeline builds.
[2020-06-19T23:43:26.972Z] [INFO] Number of builds to be searched 10
[2020-06-19T23:43:27.116Z] [INFO] 'shallow' is forced to be disabled when running on PullRequests
[2020-06-19T23:43:27.141Z] Running in /var/lib/jenkins/workspace/gent-dotnet_ecs-dotnet-mbp_PR-90/src/go.elastic.co/apm/ecs-dotnet
[2020-06-19T23:43:27.178Z] [INFO] gitCheckout: Checkout SCM PR-90 with some customisation.
[2020-06-19T23:43:27.208Z] [INFO] Override default checkout
[2020-06-19T23:43:27.267Z] Sleeping for 10 sec
[2020-06-19T23:43:37.430Z] using credential f6c7695a-671e-4f4f-a331-acdce44ff9ba
[2020-06-19T23:43:37.457Z] Cloning the remote Git repository
[2020-06-19T23:43:37.474Z] Cloning repository git@github.com:elastic/ecs-dotnet.git
[2020-06-19T23:43:37.509Z]  > git init /var/lib/jenkins/workspace/gent-dotnet_ecs-dotnet-mbp_PR-90/src/go.elastic.co/apm/ecs-dotnet # timeout=10
[2020-06-19T23:43:37.527Z] Fetching upstream changes from git@github.com:elastic/ecs-dotnet.git
[2020-06-19T23:43:37.527Z]  > git --version # timeout=10
[2020-06-19T23:43:37.540Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-06-19T23:43:37.551Z]  > git fetch --tags --progress -- git@github.com:elastic/ecs-dotnet.git +refs/heads/*:refs/remotes/origin/* # timeout=10
[2020-06-19T23:43:38.250Z]  > git config remote.origin.url git@github.com:elastic/ecs-dotnet.git # timeout=10
[2020-06-19T23:43:38.254Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
[2020-06-19T23:43:38.264Z]  > git config remote.origin.url git@github.com:elastic/ecs-dotnet.git # timeout=10
[2020-06-19T23:43:38.273Z] Fetching upstream changes from git@github.com:elastic/ecs-dotnet.git
[2020-06-19T23:43:38.274Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-06-19T23:43:38.285Z]  > git fetch --tags --progress -- git@github.com:elastic/ecs-dotnet.git +refs/pull/90/head:refs/remotes/origin/PR-90 +refs/heads/master:refs/remotes/origin/master # timeout=10
[2020-06-19T23:43:38.890Z] Checking out Revision 421ac07bfdf4a339de36da5e7aae900cf03897e7 (origin/PR-90)
[2020-06-19T23:43:38.956Z] Commit message: "Allow filtering of Serilog LogEvent properties from being added to EcsBase.Metadata"
[2020-06-19T23:43:38.975Z]  > git --version # timeout=10
[2020-06-19T23:43:38.986Z] fatal: bad object 7b930a3804b10ff3bcb3c225fac203f82497ed48
[2020-06-19T23:43:38.875Z]  > git rev-parse origin/PR-90^{commit} # timeout=10
[2020-06-19T23:43:38.893Z]  > git config core.sparsecheckout # timeout=10
[2020-06-19T23:43:38.899Z]  > git checkout -f 421ac07bfdf4a339de36da5e7aae900cf03897e7 # timeout=10
[2020-06-19T23:43:39.816Z] Masking supported pattern matches of $GIT_USERNAME or $GIT_PASSWORD
[2020-06-19T23:43:40.460Z] + git fetch<EMAIL_ADDRESS>+refs/pull/*/head:refs/remotes/origin/pr/*
[2020-06-19T23:43:41.093Z] Archiving artifacts
[2020-06-19T23:43:41.830Z] + git rev-parse HEAD
[2020-06-19T23:43:42.207Z] + git rev-parse HEAD
[2020-06-19T23:43:42.528Z] + git rev-parse origin/pr/90
[2020-06-19T23:43:42.577Z] [INFO] githubEnv: Found Git Build Cause: pr
[2020-06-19T23:43:42.797Z] Masking supported pattern matches of $GITHUB_TOKEN
[2020-06-19T23:43:43.664Z] [WARN] githubApiCall: The REST API call https://api.github.com/repos/elastic/ecs-dotnet/pulls/90/reviews return 0 elements
[2020-06-19T23:43:43.722Z] [INFO] githubPrCheckApproved: Title: Feature/serilog property filter - User: ghayes7 - Author Association: CONTRIBUTOR
[2020-06-19T23:43:44.085Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet
[2020-06-19T23:43:44.085Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)
[2020-06-19T23:43:44.164Z] [INFO] Let's stop build #1. The PR is not allowed to run in the CI yet
[2020-06-19T23:43:44.187Z] Sleeping for 5 sec
[2020-06-19T23:43:45.226Z] Stage "Sanity checks" skipped due to earlier failure(s)
[2020-06-19T23:43:45.304Z] Stage "Parallel" skipped due to earlier failure(s)
[2020-06-19T23:43:45.398Z] Stage "Linux" skipped due to earlier failure(s)
[2020-06-19T23:43:45.411Z] Stage "Windows" skipped due to earlier failure(s)
[2020-06-19T23:43:45.448Z] Failed in branch Linux
[2020-06-19T23:43:45.489Z] Stage "Windows" skipped due to earlier failure(s)
[2020-06-19T23:43:45.582Z] Failed in branch Windows
[2020-06-19T23:43:45.707Z] Stage "Release" skipped due to earlier failure(s)
[2020-06-19T23:43:45.743Z] Stage "Release" skipped due to earlier failure(s)
[2020-06-19T23:43:45.819Z] Stage "Release" skipped due to earlier failure(s)
[2020-06-19T23:43:45.893Z] Stage "Release" skipped due to earlier failure(s)
[2020-06-19T23:43:45.973Z] Stage "Release" skipped due to earlier failure(s)
[2020-06-19T23:43:46.576Z] Running on Jenkins in /var/lib/jenkins/workspace/gent-dotnet_ecs-dotnet-mbp_PR-90
[2020-06-19T23:43:46.870Z] [INFO] getVaultSecret: Getting secrets
[2020-06-19T23:43:46.934Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-06-19T23:43:48.413Z] + chmod 755 generate-build-data.sh
[2020-06-19T23:43:48.413Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-dotnet/ecs-dotnet-mbp/PR-90/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-dotnet/ecs-dotnet-mbp/PR-90/runs/1 ABORTED 179773
[2020-06-19T23:43:48.964Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-dotnet/ecs-dotnet-mbp/PR-90/runs/1/steps/?limit=10000 -o steps-info.json
[2020-06-19T23:43:49.515Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-dotnet/ecs-dotnet-mbp/PR-90/runs/1/tests/?status=FAILED -o tests-errors.json

jenkins test this please

@Mpdreamz @russcam Hey guys, anything I need to do to get this merged in and closed?

@ghayes7, I've been out on PTO and looking at this again now

@russcam I think I got everything. Though, github's still saying I missed a suggestion, am I blind?

Thanks for your contribution @ghayes7


Changes to pt.ini to some old strings and to newly added ones.

Made changes to Portuguese translation and added translation for new(8 days ago) strings.

thanks @uirsevla !!


APP-3318 - Fix sticky motor slider

On Plus/Max sized iphones, the call to set state after awaiting setPower would happen sometimes after the call to stop had gone through, causing the slider to stick after release, even when the toggle to stop after release was enabled.
Moving the setState to before the awaited method calls fixes this issue.
I considered making the calls to setPower and stop unawaited() - but then we'd lose our error handling from the try catch.
We could also use the older convention of not using async/await and instead use the Future.onError() callback, to populate the error object. But I opted for using async and await because they are more idiomatic.

I swear I've seen this "setPower interacts weirdly with setState(() { this.power = power });" in one of @njooma's old reviews. Don't have much context here but seems fine to me.

You're right @benjirewis it does sound familiar. I hope we're not punting different bugs back and forth by changing the order around.


enableLinks option has disappeared

The enableLinks option has disappeared from version 2.1.0. So the example (using v1.2.0) with link enabled is now invalid. I was able to add it back to the code (around line 971) using:
  // Add text
  if (this._options.wrapNodeText) {
    var wrapper = this._template.text.clone();
    node.$el.append(wrapper);
    wrapper.append(node.text);
  }else if(this._options.enableLinks){
    node.$el.append($('')
      .attr('href', node.href)
      .append(node.text));
  } else {
    node.$el.append(node.text);
  }

Thanks..Sir

@patternfly - any update on this? From what I can see this support has been removed from the original fork and you have blindly merged the commits but I don't find any explanation as to why.   We'd love to use this feature.


Kubernetes master reports ready/active but has not yet deployed supplementary containers

Juju reports the application as ready, but kubedns, etc are not yet deployed. After the 5 minute update-status window they appear.
Would at least accept messaging updates to waiting and "kube-system containers to start"

Fixed this awhile back, closing


Automated Package Upgrade

:tada: This PR is included in version 4.0.61 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Ability to use _score (calculated by using knn_match) to filter out the 100% similarity

Problem Statement
I'm running a statement like this to find the KNN matches based on specific compounds and gene, and I would like to exclude the row where the _score = 1.
SELECT compound, gene, _score
FROM heatmaps_vectors2
WHERE knn_match(vector, (SELECT vector FROM heatmaps_vectors2
                            WHERE compound ='Gentamicin'
                            AND gene ='ZFP36'), 10)
AND _score <> 1
ORDER BY _score DESC limit 100;

I get the following exception:
UnsupportedFeatureException[System column '_score' can only be used within a '>=' comparison without any surrounded predicate]
There may be a good reason not to be able to use the _score in this way, but it would be a nice feature.
Possible Solutions
The best would be if you could use the system-generated column _score in more ways than is possible at this stage.
Considered Alternatives
You could, of course, use a subquery or order DESC and limit to the nearest one, but if you are looking for more rows, then this doesn't work anymore.
SELECT compound, gene, _score
FROM heatmaps_vectors2
WHERE knn_match(vector, (SELECT vector FROM heatmaps_vectors2
                            WHERE compound ='Gentamicin'
                            AND gene ='ZFP36'), 2)
ORDER BY _score ASC
LIMIT 1;

For reference, this also happens in match and is documented here https://cratedb.com/docs/crate/reference/en/5.6/general/dql/fulltext.html#filter-by-score

Don't know if that one may help in this context?

GH-14801


Bypassing ConvertSQL->convertFromSQLKeywords()

The convertFromSQLKeywords() function try to convert several chars to others for a later analysis. But the line below has a problem:
$value   = preg_replace('/,null/ims', ',0', $value);
If you send the string "select 1,null;" convertFromSQLKeywords() converts it into "select 1,0;" but adding an extra white space after semicolon ("select 1, null;") the function is bypassed. A possible solution is replace:
$value   = preg_replace('/,null/ims', ',0', $value);
with:
$value   = preg_replace('/,\s+null/ims', ',0', $value);
Regards

PR for this fix was merged - closing.


decreased tolerance for spacing check

Fix tolerance issue

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   90.55%   90.55%
=======================================
  Files           1        1
  Lines         233      233
  Branches       80       80
=======================================
  Hits          211      211
  Misses         11       11
  Partials       11       11

Impacted Files
Coverage Δ

xrft/xrft.py
90.55% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2110701...014ec46. Read the comment docs.


add: Tween Leaf for Behaviour Tree

Very nice!

An exported bool for Tween's as_relative would be nice to have. Thanks for this!

An exported bool for Tween's as_relative would be nice to have. Thanks for this!

What do you exactly mean by as_relative?

https://docs.godotengine.org/en/stable/classes/class_propertytweener.html#class-propertytweener
PropertyTweener.as_relative( )

@squk Added your suggestions! Can you please verify the tween actually works in your project?

Invalid call. Nonexistent function 'set_loop' in base 'Tween'.
set_loop is actually a property of PropertyTweener, like as_relative().

Invalid call. Nonexistent function 'set_loop' in base 'Tween'.

Fixed the typo!

For my own curiosity, what program do you use to make these SVG files?

I use Inkscape! Very easy to throw something together. Just mix and match the Godot Editor Icons, other CC0 icons and your own shapes and you are good to go!


Error on explication

The next paragraph have repeat AzureFirewallApplicationRule, must be AzureFirewallApplicationRule and AzureFirewallNetworkRule.
"Azure Firewall logs data below AzureDiagnostics with Category as either AzureFirewallApplicationRule or AzureFirewallApplicationRule. The data containing the details is stored in the msg_s field. Using the parse operator we can extract the various interesting properties from the msg_s field. The queries below extract the information for both categories"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2cc1c543-6db1-23cd-0f7a-4506f53b7d90
Version Independent ID: a7c1b69f-67dc-d94a-05d7-1d603ea82461
Content: Azure Firewall log analytics samples
Content Source: articles/firewall/log-analytics-samples.md
Service: firewall
GitHub Login: @vhorne
Microsoft Alias: victorh

@imartinez2 Thanks for the feedback! I have fixed the typo. The doc should reflect these changes within 24 hours.


feat(pwa): use ManifestTransform when using @islands/pwa

Description 📖
This PR uses workbox ManifestTransform when pwa is configured via @islands/pwa plugin/module: this way we can control the sw precache manifest, adding or removing entries.
Also includes the configuration based on prettyUrls on workbox.navigateFallback entry: will use the Vite base or / when not configured.
If the pwa plugin is configured via Vite instead using @islands/pwa plugin/module, using prettyUrls: false will produce an error on runtime when registering the sw, since it will have the html entries twice in the sw precache manifest: you have a comment about  not adding the addRoutes entries on line 195 (the comment is about prettyUrls: true, since we'll end with the html file and also the route name, but registering the sw will work).
TODO:

the iles.config.ts docs file has a comment about excluding the html entries, we can remove it before merging this PR (the html entries on the globPatterns added, the new logic will remove all html entries and recalculate the revision for all routes provided in the SSG callback).
remove the console.log on the pwa module, I added a few logging and so you can check the result.

Background 📜
This was happening because I talk about it with ElMassimo ;)
The Fix 🔨
By changing the Vite PWA Plugin options to include the workbox ManifestTransform to regenerate the manifest entries after SSG build.
Screenshots 📷
Nopes

We need to talk about dynamic pages, should be excluded from the sw precache manifest: a lot of work to be done on server side and also including a custom sw (read https://github.com/antfu/vitesse/discussions/169 and a simple implementation here https://github.com/antfu/vitesse/issues/252#issuecomment-1046085093).

@ElMassimo we can wait, we're releasing a few things on pwa repo, I'll update this PR when pwa 0.12.2 released (2/3 hours)

@ElMassimo updated, I have another PR to add ESM support and fix some dev bug and: I thinkwe should remove the support here adding the pwa plugin via vite.plugins entry

we have to clean up some internal types of the plugin that are not needed anymore

doing some cleanup


cmd/internal/ld: cannot link whole standard library into one shared object

This is presumably because the package list note in this case ends up being rather large:
mwhudson@glamdring:src$ go install -buildmode=shared std
# /tmp/go-build456756371/libstd.so
mime/quotedprintable..gobytes.3: ELFRESERVE too small: 4168 > 3072

I'm working on this now.

Can't we append the list to the end of the dso?


Piping into cvslens does not work on Mac (Monterey/Ventura/Intel/M1)

Piping (any CSV file) into csvlens on the Mac (Monterey, rust 1.65.0) bombs with this backtrace
thread 'main' panicked at 'not yet implemented', /Users/el/.cargo/registry/src/github.com-1ecc6299db9ec823/csvlens-0.1.10/src/util/events.rs:58:23
stack backtrace:
   0:        0x1021becb2 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h9515a3bdbd0baca0
   1:        0x1021d253a - core::fmt::write::hfb97b04d44bdb4d8
   2:        0x1021a4c8c - std::io::Write::write_fmt::h686d9784d8415cb9
   3:        0x1021a763f - std::panicking::default_hook::{{closure}}::ha298777f08731ac8
   4:        0x1021a72cf - std::panicking::default_hook::hb5f65353eb4f3d66
   5:        0x1021a7d52 - std::panicking::rust_panic_with_hook::he911070515b336d8
   6:        0x1021befc2 - std::panicking::begin_panic_handler::{{closure}}::h752456daaf48f28e
   7:        0x1021bee08 - std::sys_common::backtrace::__rust_end_short_backtrace::hc10b12502582d9b6
   8:        0x1021a786d - _rust_begin_unwind
   9:        0x1021e3b93 - core::panicking::panic_fmt::hc606b9962be5fb74
  10:        0x1021e3a77 - core::panicking::panic::h5459910156e8485f
  11:        0x102087a18 - csvlens::util::events::CsvlensEvents::next::h4ebcf28b757c6d70
  12:        0x1020a6446 - csvlens::input::InputHandler::next::h48c5a29e4a233be3
  13:        0x102090e0d - csvlens::app::App::main_loop::h938a72257a5b9420
  14:        0x10208b44c - csvlens::main::h1977ea503b48407c
  15:        0x1020a0026 - std::sys_common::backtrace::__rust_begin_short_backtrace::ha497255ce33b7923
  16:        0x1020a08dc - std::rt::lang_start::{{closure}}::h77a3420c0367f8ce
  17:        0x1021a4338 - std::rt::lang_start_internal::h7de129d052efa930
  18:        0x10208baaf - _main

Originally posted by @ondohotola in https://github.com/YS-L/csvlens/issues/12#issuecomment-1338940432

Thanks for reporting! I can reproduce this.
This is related to https://github.com/crossterm-rs/crossterm/issues/500. There is an on-going effort to remove this limitation in crossterm, and csvlens can pick up the fix once it landed upstream.

This should be fixed now in v0.1.11.

I can confirm that this works. Thank you.


v0.8.1_30: Color is not changed according to the selected option

SEVERITY: Major
MODULE:  Line Chart
Platform:

Windows 7 / Chrome 45.0
Windows 7 / Firefox 42.0
MAC / Safari 8.0
iPad Air 2 iOS(8.3) / Safari 8.0
Nexus 9 (5.0.1) / Chrome 45.0
Nexus 5 (5.1.1) / Chrome 44.0

RELEASE: v0.8.1
STEPS TO REPRODUCE:

Navigate URL: http://static.gapminderdev.org/vizabi/release/v0.8.1/preview/linechart.html
Line chart page will be loaded
Click “Color”
Select any option
Note that there is no color change after selecting any other color options

ACTUAL RESULTS:
Color is not changed according to the selected option.
EXPECTED RESULTS:
Color should be changed according to the selected options
SCREENSHOT:

Retest Result: Fail
Platform: Windows 7 / Chrome 48.0
Testing Environment: http://static.gapminderdev.org/vizabi/release/v0.8.5/preview/linechart.html

fixed now


Android String Garbled code

I hope I can correctly distinguish between left and right Hand （Android）
###Situation one：
outputStream :  "hand_landmarks"
List<DetectionProto.Detection> multiHandDetection = PacketGetter.getProtoVector(packet, DetectionProto.Detection.parser());

for (DetectionProto.Detection item: multiHandDetection) {
    String string1 = item.getLabel(0);
    Logger.d(TAG,"string1 " + string1);
    String string2 = item.getLabelBytes(0).toStringUtf8();
    Logger.d(TAG,"string2 " + string2);
}

log:
string1 �{c>`?�%��
string2 �{c>`?�%��

###Situation two：
outputStream :  "handedness"
List<DetectionProto.Detection> multiHandDetection = PacketGetter.getProtoVector(packet, DetectionProto.Detection.parser());

for (DetectionProto.Detection item: multiHandDetection) {
    String string1 = item.getLabel(0);
    Logger.d(TAG,"string1 " + string1);
    String string2 = item.getLabelBytes(0).toStringUtf8();
    Logger.d(TAG,"string2 " + string2);
}

log:
string1��?Right
string2��?Right

I hope to get the content correctly when Situation one
Is there any suggestion to fix it？

@ljmkimqx  which device are you testing and details?

My device is mobile: Mi 10 Lite zoom. The brand is Xiaomi Corporation. The system is Android 11.

@ljmkimqx - to reproduce this, can you share all the steps you have performed for getting this error, perhaps by sharing your repository? Thank you.

Hi @ljmkimqx, To resolve your issue, we need to understand your steps performed on the code to reproduce the above error. Please share your code or repo.

Hi @ljmkimqx, Could you please respond to my above comment. Thanks!

Hello, I'm sorry to answer now. Because OpenGL is used internally in our Android project, we have failed to integrate mediapipe many times.
So we refer to this project:  https://github.com/afsaredrisy/MediapipeHandtracking_GPU_Bitmap_Input
Then we use the latest version of mediapipe gesture model.
Test code deleted. The following is the project code related to gesture recognition. The gesture data returned by mediapipe will also have the above problems.
handProcessor =
                new FrameProcessor(
                        context,
                        eglManager.getNativeContext(),
                        MPHandleTrackerManager.BINARY_GRAPH_NAME,
                        MPHandleTrackerManager.INPUT_VIDEO_STREAM_NAME,
                        MPHandleTrackerManager.OUTPUT_VIDEO_STREAM_NAME);
        handProcessor.getVideoSurfaceOutput().setFlipY(FLIP_FRAMES_VERTICALLY);

        AndroidPacketCreator packetCreator = handProcessor.getPacketCreator();
        Map<String, Packet> inputSidePackets = new HashMap<>();
        inputSidePackets.put(MPHandleTrackerManager.INPUT_NUM_HANDS_SIDE_PACKET_NAME, packetCreator.createInt32(MPHandleTrackerManager.NUM_HANDS));
        handProcessor.setInputSidePackets(inputSidePackets);

        handProcessor.addPacketCallback(
                MPHandleTrackerManager.OUTPUT_HANDEDNESS_STREAM_NAME,
                (packet) -> {
                    List<DetectionProto.Detection> multiHandDetection = PacketGetter.getProtoVector(packet, DetectionProto.Detection.parser());
                    if(mHandleTrackerManager != null){
                        mHandleTrackerManager.updateMultiHandDetection(multiHandDetection);
                    }
                });

        handProcessor.addPacketCallback(
                MPHandleTrackerManager.OUTPUT_LANDMARKS_STREAM_NAME,
                (packet) -> {
                    try {

                        List<LandmarkProto.NormalizedLandmarkList> multiHandLandmarks =
                                PacketGetter.getProtoVector(packet, LandmarkProto.NormalizedLandmarkList.parser());

                        if (multiHandLandmarks.size() == 0) {
                            return;
                        }

                        List<DetectionProto.Detection> multiHandDetection = null;
                        if(mHandleTrackerManager != null){
                            multiHandDetection = mHandleTrackerManager.getMultiHandDetection();
                        }

                        if(multiHandDetection == null || multiHandDetection.size() == 0){
                            return;
                        }

                        if(multiHandLandmarks.size() != multiHandDetection.size()){
                            return;
                        }

                    } catch (Exception e) {
                        e.printStackTrace();
                    }
                });

###Situation one：
outputStream : "hand_landmarks"
List<DetectionProto.Detection> multiHandDetection = PacketGetter.getProtoVector(packet, DetectionProto.Detection.parser());

for (DetectionProto.Detection item: multiHandDetection) {
    String string1 = item.getLabel(0);
    Logger.d(TAG,"string1 " + string1);
    String string2 = item.getLabelBytes(0).toStringUtf8();
    Logger.d(TAG,"string2 " + string2);
}

log:
string1 �{c>��`�?��%��
string2 �{c>��`�?��%��

The output_stream you are interested in is hand_landmarks. As shown here, hand_landmarks is of type NormalizedLandmarkList. So you should use the code cited to get the hand landmarks.

###Situation two：
outputStream : "handedness"
List<DetectionProto.Detection> multiHandDetection = PacketGetter.getProtoVector(packet, DetectionProto.Detection.parser());

for (DetectionProto.Detection item: multiHandDetection) {
    String string1 = item.getLabel(0);
    Logger.d(TAG,"string1 " + string1);
    String string2 = item.getLabelBytes(0).toStringUtf8();
    Logger.d(TAG,"string2 " + string2);
}

log:
string1�����?��Right
string2�����?��Right

The output stream handedness is a list of Classification proto objects as shown in the graph here. So Classification proto object should be used to parse the output stream handednes or multi_handedness

Hi @ljmkimqx, Have a look at the above comment. Thanks!

Hi @ljmkimqx, Did you get a chance to go through the above comments. Thanks!

Hi @ljmkimqx

When I use 'multi_handedness', I get this error: input stream "multi_ handedness" for node with sorted index 1 does not have a corresponding output stream.
If the graph contains a node that has an output stream named multi_handedness, this error should not arise. Since this graph has an output stream named multi_handedness, the error should not arise.

Please share what code you used to reproduce this error.

If I use "HANDEDNESS:multi_handedness", the app will flash back directly, and the error is: validate_ display:87 error 3008 (EGL_ BAD_ DISPLAY)

HANDEDNESS is a tag used by graphs and calculators to identify a particular input/output stream. The actual name of the stream is multi_handedness. So you should use only multi_handedness as the name of the stream being observed to extract the packets.  Try something like the following:
      processor.addPacketCallback(
          "multi_handedness",
          (packet) -> {
            Log.v(TAG, "Received multi-handness packet.");
            List<ClassificationList> multiHandedness =
                PacketGetter.getProtoVector(packet, ClassificationList.parser());
            Log.v(
                TAG,
                "[TS:"
                    + packet.getTimestamp()
                    + "] "
                    + getMultiHandednessDebugString(multiHandedness));
          });

where you need to write the getMultiHandednessDebugString function to parse the multiHandedness object. See similar code for hand landmarks here.

Hi @ljmkimqx, Could you please respond to the above comment. Thanks!

Hi @ljmkimqx, Did you get a chance to go through the above comment. Thanks!

We are closing this issue due to lack of activity from the reporter.


Readable timestamp

Description
The date format has been fixed
Closes #622
Attach Screenshot

Anybody has idea how to get rid of all those extra commits? They have all been done already

Having the branch isn't helping, right? @PuruVJ

@PuruVJ please close this and raise a clean pr.

Having the branch isn't helping, right? @PuruVJ

Exactly!

@PuruVJ please close this and raise a clean pr.

How do I raise a clean pr? What is a clean pr?

Create a new branch
Pull the latest change
Make your code change
Raise PR
After PR merged delete the branch
Repeat

That's what I did for this

Why do you have so many changes for just time format update?

@arthurbuhl in the merge process I think we are now squashing the commits. This causes an issue when we sync back to our fork, which would add merge commits to our main branch. I don't know for sure if this is whats happening.

Oh, I see.


It doesn't work in my Mac enviroment

As follow python commands output:
python3 tests/connection_test.py

Connection test:
[INFO] tello.py - 129 - Tello instance was initialized. Host: '<IP_ADDRESS>'. Port: '8889'.
[INFO] tello.py - 438 - Send command: 'command'
[INFO] tello.py - 462 - Response command: 'ok'

Video stream test:
[INFO] tello.py - 438 - Send command: 'streamon'
[INFO] tello.py - 462 - Response streamon: 'ok'

[INFO] tello.py - 438 - Send command: 'streamoff'
[INFO] tello.py - 462 - Response streamoff: 'ok'

python3 main.py
Reading configuration
[INFO] tello.py - 129 - Tello instance was initialized. Host: '<IP_ADDRESS>'. Port: '8889'.
[INFO] tello.py - 438 - Send command: 'command'
[INFO] tello.py - 462 - Response command: 'ok'
[INFO] tello.py - 438 - Send command: 'streamon'
[INFO] tello.py - 462 - Response streamon: 'ok'
WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
I0000 00:00:1702369536.445340       1 gl_context.cc:344] GL version: 2.1 (2.1 Metal - 88), renderer: Apple M2 Max
INFO: Created TensorFlow Lite XNNPACK delegate for CPU.
[INFO] tello.py - 438 - Send command: 'down 20'
No accelerated colorspace conversion found from yuv420p to rgb24.
INFO: Created TensorFlow Lite XNNPACK delegate for CPU.
[INFO] tello.py - 462 - Response down 20: 'error Motor stop'
[INFO] tello.py - 438 - Send command: 'down 20'
[INFO] tello.py - 462 - Response down 20: 'error Motor stop'
[INFO] tello.py - 438 - Send command: 'down 20'
[INFO] tello.py - 462 - Response down 20: 'error Motor stop'
Traceback (most recent call last):
File "main.py", line 163, in
main()
File "main.py", line 103, in main
tello.move_down(20)
File "/opt/homebrew/anaconda3/envs/tello2/lib/python3.8/site-packages/djitellopy/enforce_types.py", line 54, in wrapper
return func(*args, **kwargs)
File "/opt/homebrew/anaconda3/envs/tello2/lib/python3.8/site-packages/djitellopy/tello.py", line 635, in move_down
self.move("down", x)
File "/opt/homebrew/anaconda3/envs/tello2/lib/python3.8/site-packages/djitellopy/enforce_types.py", line 54, in wrapper
return func(*args, **kwargs)
File "/opt/homebrew/anaconda3/envs/tello2/lib/python3.8/site-packages/djitellopy/tello.py", line 621, in move
self.send_control_command("{} {}".format(direction, x))
File "/opt/homebrew/anaconda3/envs/tello2/lib/python3.8/site-packages/djitellopy/enforce_types.py", line 54, in wrapper
return func(*args, **kwargs)
File "/opt/homebrew/anaconda3/envs/tello2/lib/python3.8/site-packages/djitellopy/tello.py", line 487, in send_control_command
self.raise_result_error(command, response)
File "/opt/homebrew/anaconda3/envs/tello2/lib/python3.8/site-packages/djitellopy/enforce_types.py", line 54, in wrapper
return func(*args, **kwargs)
File "/opt/homebrew/anaconda3/envs/tello2/lib/python3.8/site-packages/djitellopy/tello.py", line 529, in raise_result_error
raise TelloException("Command '{}' was unsuccessful for {} tries. Latest response:\t'{}'"
djitellopy.tello.TelloException: Command 'down 20' was unsuccessful for 4 tries. Latest response:	'error Motor stop'
[INFO] tello.py - 438 - Send command: 'streamoff'
[WARNING] tello.py - 448 - Aborting command 'streamoff'. Did not receive a response after 7 seconds
[INFO] tello.py - 438 - Send command: 'streamoff'
[WARNING] tello.py - 448 - Aborting command 'streamoff'. Did not receive a response after 7 seconds
[INFO] tello.py - 438 - Send command: 'streamoff'
[WARNING] tello.py - 448 - Aborting command 'streamoff'. Did not receive a response after 7 seconds

Seems like empty command. Did you change the package versioning? I can see that you are using Python 3.8

@kinivi didn't change the package version. Put it in python 3.7. Logging as follow
python3 --version
Python 3.7.12
❯ python3 tests/tello_test.py
[INFO] tello.py - 129 - Tello instance was initialized. Host: '<IP_ADDRESS>'. Port: '8889'.
[INFO] tello.py - 438 - Send command: 'command'
INFO: Created TensorFlow Lite XNNPACK delegate for CPU.
[INFO] tello.py - 462 - Response command: 'ok'
[INFO] tello.py - 438 - Send command: 'streamon'
[INFO] tello.py - 462 - Response streamon: 'ok'
❯ python3 main.py
[1]    60008 illegal hardware instruction  python3 main.py

@kinivi didn't change the package version. Put it in python 3.7. Logging as follow
python3 --version Python 3.7.12 ❯ python3 tests/tello_test.py [INFO] tello.py - 129 - Tello instance was initialized. Host: '<IP_ADDRESS>'. Port: '8889'. [INFO] tello.py - 438 - Send command: 'command' INFO: Created TensorFlow Lite XNNPACK delegate for CPU. [INFO] tello.py - 462 - Response command: 'ok' [INFO] tello.py - 438 - Send command: 'streamon' [INFO] tello.py - 462 - Response streamon: 'ok'
❯ python3 main.py [1] 60008 illegal hardware instruction python3 main.py


fix(deps): update terraform terraform-ibm-modules/cos/ibm to v8.14.1

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/cos/ibm (source)
module
minor
8.5.3 -> 8.14.1

Release Notes

terraform-ibm-modules/terraform-ibm-cos (terraform-ibm-modules/cos/ibm)
v8.14.1
Compare Source
Bug Fixes

updated the KMS auth policy so its scoped to the exact KMS Key (buckets submodule and bucket DAs) (#765) (a685222)

v8.14.0
Compare Source
Features

updated the KMS auth policy created by the module so its scoped to the exact KMS Key. NOTE: This will delete and re-create any existing auth policy, however it will create before delete so there will be no disruption to services. (#764) (211576e)

v8.13.6
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/cbr/ibm to v1.28.1 (#761) (3f3235a)

v8.13.5
Compare Source
Bug Fixes

deps: update terraform ibm to latest for the deployable architecture solution (#749) (e306061)

v8.13.4
Compare Source
Bug Fixes

deps: removed force_delete_key_ring from KMS module call as it is deprecated (#757) (c83092e)

v8.13.3
Compare Source
Bug Fixes

remove lookup of IAM account settings to fetch account ID as this requires admin privileges (#751) (fb0cc4d)

v8.13.2
Compare Source
Bug Fixes

deps: update terraform-module (#748) (62c5981)

v8.13.1
Compare Source
Bug Fixes

deps: update terraform-module (#739) (b58ba8e)

v8.13.0
Compare Source
Features

removed support for passing an Activity Tracker CRN to COS buckets. Activity Tracker is a deprecated service, and if activity_tracker_read_data_events, activity_tracker_write_data_events and activity_tracker_management_events are set to true, events are sent to whatever is specified in the Activity Tracker Event Routing service configuration  (#738) (79f86c6)

v8.12.0
Compare Source
Features

add 'cos_account_id' output (#743) (c2f8765)

v8.11.16
Compare Source
Bug Fixes

deps: update terraform ibm to latest for the deployable architecture solution (#737) (737c9e8)

v8.11.15
Compare Source
Bug Fixes

deps: update terraform-module (#734) (4699c26)

v8.11.14
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/secrets-manager/ibm to v1.18.6 (#731) (af80c37)

v8.11.13
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/secrets-manager/ibm to v1.18.5 (#729) (e4de2ed)

v8.11.12
Compare Source
Bug Fixes

deps: update required_provider to latest for the deployable architecture solution (#722) (aee9044)

v8.11.11
Compare Source
Bug Fixes

deps: update terraform-module (#724) (acbf18c)

v8.11.10
Compare Source
Bug Fixes

deps: update terraform-module (#718) (0418427)

v8.11.9
Compare Source
Bug Fixes

update both cos bucket extension DA to mark the dependant DA as optional (#721) (264cb1b)

v8.11.8
Compare Source
Bug Fixes

allow bucket retention to be zero (#719) (2b4a1fc)

v8.11.7
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/kms-all-inclusive/ibm to v4.15.11 (#716) (b992f2a)

v8.11.6
Compare Source
Bug Fixes

deps: update terraform-module (#715) (6dfd1b9)

v8.11.5
Compare Source
Bug Fixes

deps: update terraform-module (#712) (b0933f2)

v8.11.4
Compare Source
Bug Fixes

deps: update terraform ibm to latest for the deployable architecture solution (#713) (e7b48a4)

v8.11.3
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/secrets-manager/ibm to v1.17.10 (#710) (b9cc0f0)

v8.11.2
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/secrets-manager/ibm to v1.17.8 (#707) (3390b1d)

v8.11.1
Compare Source
Bug Fixes

only create the secrets manager auth policy if user passes a value for existing_secrets_manager_instance_crn regardless of the value of skip_cos_sm_auth_policy (#709) (c11b537)

v8.11.0
Compare Source
Features

The input skip_cos_kms_auth_policy has been renamed to skip_cos_sm_auth_policy in the COS instance DA solution (#702) (3a1b37a)

v8.10.7
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/secrets-manager/ibm to v1.17.7 (#706) (aa7fa8c)

v8.10.6
Compare Source
Bug Fixes

deps: update terraform ibm to latest for the deployable architecture solution (#698) (b778ec7)

v8.10.5
Compare Source
Bug Fixes

deps: update terraform-module (#703) (d6ab36e)

v8.10.4
Compare Source
Bug Fixes

added a validation that does not allow create_cos_instance to be true if a value is being passed for existing_cos_instance_id (#701) (78b49a5)

v8.10.3
Compare Source
Bug Fixes

deps: update terraform-module (#681) (1089405)

v8.10.2
Compare Source
Bug Fixes

fixed bug where secrets module was being called by the DA even when no service credentials were being created (#696) (f5b69b5)

v8.10.1
Compare Source
Bug Fixes

deps: update required_provider to latest for the deployable architecture solution (#690) (214b30b)

v8.10.0
Compare Source
Features

support to create service credentials in secrets manager (#687)This enhancement will enable users to create service credentials in an existing secrets manager for a COS instance. Users can choose to use an existing secret group or create a new one for the service credentials. (b10af71)

v8.9.2
Compare Source
Bug Fixes

deps: updated KMS module to 4.15.2 in the bucket DAs (#685) (412cdb5)

v8.9.1
Compare Source
Bug Fixes

deps: update terraform time to latest for the deployable architecture solution (#682) (86cc006)

v8.9.0
Compare Source
Features

added support to the bucket DAs to optionally provide an apikey from another account if the KMS instance exists in a different account to COS using new input variable ibmcloud_kms_api_key (#676) (cf6e56b)

v8.8.5
Compare Source
Bug Fixes

clean up variable descriptions (#675) (e7b5254)

v8.8.4
Compare Source
Bug Fixes

added supporting documentation for the resource_keys input variable for the instances DA variation (#677) (0ff0d45)

v8.8.3
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/kms-all-inclusive/ibm to v4.14.2 (#679) (35e3b51)

v8.8.2
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/kms-all-inclusive/ibm to v4.14.1 (#678) (5336aa5)

v8.8.1
Compare Source
Bug Fixes

add sleep around auth policy when destroying (workaround for https://github.com/terraform-ibm-modules/terraform-ibm-cos/issues/672) (#673) (208a2a1)

v8.8.0
Compare Source
Features

removed support for lite plan as this is no longer available from IBM Cloud (#674) (b37bcab)

v8.7.0
Compare Source
Features

added new outputs to the secure-cross-regional-bucket and secure-regional-bucket DA solutions: s3_endpoint_direct, s3_endpoint_private, bucket_name, cos_instance_ids (#656) (2e3c40f)

v8.6.2
Compare Source
Bug Fixes

deps: update terraform ibm to latest for the deployable architecture solution (#667) (54e538f)

v8.6.1
Compare Source
Bug Fixes

Update ibm_catalog.json - remove dependencies section (#663) (435712d)

v8.6.0
Compare Source
Features

the following new variables have been added to the root level module: activity_tracker_read_data_events, activity_tracker_write_data_events, activity_tracker_management_events, request_metrics_enabled and usage_metrics_enabled. Previously the logic only set these to true if a Monitoring or Activity Tracker CRN was passed, but that in IBM terraform provider version 1.67.0, you no longer need to pass Monitoring or Activity Tracker instance CRNs to enable monitoring or activity tracking on a bucket. If values not passed, it will default to the Monitoring or AT instance in the same location as the bucket.
As part of this work sysdig_crn has been renamed to  monitoring_crn. (#660) (7d93787)

v8.5.4
Compare Source
Bug Fixes

add community catalog id in dependencies section of ibm_catalog.json (#662) (84f196e)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline


Save and reload progress

This PR fixes the progress saving / reloading features of the original SODA application that was lost in #32. It completes this behavior up until the Metadata page.

@garrettmflynn What's the base of this PR? It doesn't seem to be one of the other open PRs

Replaced with #41


Faster Docs CI ?

Shall we try to reduce the CI time for documentation-only changes?  I think of running just the docs CI when having the label documentation attached to the issue, and ignoring the whole pytest suite.
That would mean that we need to split our current pytest approach, where we test "normal" tests and documentation tests simultaneously.
This would greatly reduce the time to passing tests in minor (or large) documentation changes, and we would not be held up by increased memory usage, suddenly incompatible dependencies etc. like we were in the last few days.
(I'm thinking in particular of PRs like #2220)

The only problem is that sometimes normal changes have unexpected affects on the docs, since the docs include executed notebooks.  If a change to the code breaks the docs, the PR should not be merged

Yes that would be fine - changes to the docs only should not require pytest to be run.


Address DDF (direct documentation feedback) issues

We have a few documentation issues raised on the Customer Portal via the DDF feature. The primary issues are as follows:

Clarify that required software packages are for Linux systems, not macOS
Clarify which service to enable for monitoring and telemetry functionality

fixed by #1305


GroupBy(Until) tests and fixes

Finishes the last bits and pieces of #375.
In summary:

Add tests to match groupByUntil from RxJS legacy
Add basic test cases (empty, never, etc) that were missing for groupBy
Fix some bugs related to groupBy

Merged with 57e4207... good stuff, @staltz


Remove unencrypted git protocol use, as it will be disabled march 15th

Hi,
I just got hit by GitHub's current brownout of unencrypted git protocol usage when trying to install Mininet from source.
As usage of the unencrypted git protocol will be retired permanently on March 15th, I am submitting this patch changing the URLs to https instead.
For details, please see https://github.blog/2021-09-01-improving-git-protocol-security-github/
Cheers :)
Andreas

As much as I prefer git I think it's OK to switch to https to help people on networks whose admins are hostile to the former.

Is there something I still need to do before this can be merged? March 15th is approaching quickly :)

For some reason I couldn't easily get the CI to run, which means that the PR's checks didn't pass. However this looks fine.


Crash 2nd wave Ghast portal

I think the error is self explanatory:
Attempted to apply a random attribute modifier to an entity (minecraft:ghast) that does not have that attribute (minecraft:generic.attack_damage)!
Crash report:
crash-2022-08-06_10.51.02-server.txt

Fixed by Placebo 6.5.1


Rendering a link should become easier, not more complex…

All that to render a link?

Just leaving this here, feel free to ignore. ❤
But I came across this package in a project already, when looking for reasons of excessive object instatiation during Fusion rendering and thought "oh wow, that's a lot of indirection to build a link…" 🤷♂

@kdambekalns Any additional feedback? :)

Finally had another close(r) look, this is indeed way better than the prototype I saw back then. 🎉


Rust build-support: fixing a compilation error in some crates

BuildRustCrate fails on some crates (such as proc-macro2), because some environment variables were not set. This fixes it.
Additionally, an error message related to the install script is fixed.
Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

What's the motivation for NUM_JOBS=1? Does that impact parallel building?

For RUSTC I can see that it seems to be set to prog which is rustc.get_program(). So that is probably okay. I am not sure if the
This is the definition of NUM_CPUS:
* `NUM_JOBS` - the parallelism specified as the top-level parallelism. This can
               be useful to pass a `-j` parameter to a system like `make`. Note
               that care should be taken when interpreting this environment
               variable. For historical purposes this is still provided but
               recent versions of Cargo, for example, do not need to run `make
               -j` as it'll automatically happen. Cargo implements its own
               [jobserver] and will allow build scripts to inherit this
               information, so programs compatible with GNU make jobservers will
               already have appropriately configured parallelism.

And the RUSTC case:
* `RUSTC`, `RUSTDOC` - the compiler and documentation generator that Cargo has
                       resolved to use, passed to the build script so it might
                       use it as well.

So I think the addition is warranted. We might as well go for the full list of them as it can be found in the cargo search at src/doc/src/reference/environment-variables.md.
Should we also add test cases so that we can ensure we are properly compiling something that actually depends on those?

What's the motivation for NUM_JOBS=1? Does that impact parallel building?

Rustc is already called with -j1 by buildRustCrate, so this environment variable will not change anything.
When used with cargo, this environment variable means cargo will compile multiple modules of the same crate in parallel. Nix adopts a different strategy, by parallelising only at the crate level (doing otherwise doesn't work).

FWIW I'm not against it and don't know much about rust building,
so don't really have an opinion either way :).
Just noticed and was curious (and to confirm / be clear about such a
reason, whatever it may be).
On Fri, 16 Nov 2018 09:02:53 -0800, Pierre-Etienne Meunier<EMAIL_ADDRESS>wrote:

P-E-Meunier commented on this pull request.

@@ -71,6 +71,8 @@ in ''
export CARGO_PKG_VERSION_MAJOR=${builtins.elemAt version 0}
export CARGO_PKG_VERSION_MINOR=${builtins.elemAt version 1}
export CARGO_PKG_VERSION_PATCH=${builtins.elemAt version 2}

export NUM_JOBS=1

I don't know, it's still in the docs. I was just trying to include as many environment variables from the docs as possible.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/NixOS/nixpkgs/pull/50452#discussion_r234278453Non-text part: text/html

So I think the addition is warranted. We might as well go for the full list of them as it can be found in the cargo search at src/doc/src/reference/environment-variables.md.

Right.

Should we also add test cases so that we can ensure we are properly compiling something that actually depends on those?

I don't know how to add test cases in Nix, but I'd be happy to learn.

I just ran into this failure myself when using proc_macro2 as well; here was my patch, after I reverse-engineered the failure back to RUSTC:
diff --git a/pkgs/build-support/rust/build-rust-crate/configure-crate.nix b/pkgs/build-support/rust/build-rust-crate/configure-crate.nix
index 37fef2abd77..0be77fb4c0a 100644
--- a/pkgs/build-support/rust/build-rust-crate/configure-crate.nix
+++ b/pkgs/build-support/rust/build-rust-crate/configure-crate.nix
@@ -1,4 +1,4 @@
-{ lib, stdenv, echo_build_heading, noisily, makeDeps }:
+{ lib, stdenv, which, echo_build_heading, noisily, makeDeps }:
 { build, buildDependencies, colors, completeBuildDeps, completeDeps, crateAuthors, crateFeatures, crateName, crateVersion, extraLinkFlags, libName, libPath, release, target_os, verbose, workspace_member }:
 let version_ = lib.splitString "-" crateVersion;
     versionPre = if lib.tail version_ == [] then "" else builtins.elemAt version_ 1;
@@ -61,6 +61,8 @@ in ''
   export CARGO_CFG_TARGET_POINTER_WIDTH=${toString stdenv.hostPlatform.parsed.cpu.bits}
   export CARGO_CFG_TARGET_VENDOR=${stdenv.hostPlatform.parsed.vendor.name}

+  export RUSTC=$(${which}/bin/which rustc)
+  export RUSTDOC=$(${which}/bin/which rustdoc)
   export CARGO_MANIFEST_DIR="."
   export DEBUG="${toString (!release)}"
   export OPT_LEVEL="${toString optLevel}"
diff --git a/pkgs/build-support/rust/build-rust-crate/default.nix b/pkgs/build-support/rust/build-rust-crate/default.nix
index ec11472bbae..ac790b0b62f 100644
--- a/pkgs/build-support/rust/build-rust-crate/default.nix
+++ b/pkgs/build-support/rust/build-rust-crate/default.nix
@@ -4,7 +4,7 @@
 # This can be useful for deploying packages with NixOps, and to share
 # binary dependencies between projects.

-{ lib, stdenv, defaultCrateOverrides, fetchCrate, rustc }:
+{ lib, stdenv, which, defaultCrateOverrides, fetchCrate, rustc }:

 let
     # This doesn't appear to be officially documented anywhere yet.
@@ -53,7 +53,7 @@ let
       }
     '';

-    configureCrate = import ./configure-crate.nix { inherit lib stdenv echo_build_heading noisily makeDeps; };
+    configureCrate = import ./configure-crate.nix { inherit lib stdenv which echo_build_heading noisily makeDeps; };
     buildCrate = import ./build-crate.nix { inherit lib stdenv echo_build_heading noisily makeDeps; };
     installCrate = import ./install-crate.nix;

i.e. I set the absolute path.
I think not setting the absolute path is also just fine.
In general a test case would be nice, though, but I don't think we should hold this up for that? proc-macro2 is used quite widely through some indirect dependencies, so I think this is generally OK, and overall this change is relatively minor. I'd like to see this land soon (so I can eliminate some in-tree patches)

@P-E-Meunier The tests are currently in pkgs/build-support/rust/build-rust-crate/test.
Other then that we can go ahead and merge it.

Looks like a compilation error in some crates might include thread 'main' panicked at 'Failed to get rustc version', libcore/option.rs:1000:5 in libc.

Shouldn't this also set RUSTDOC?

I'm currently tweaking this to try and compile Rust to WASM. This would be very cool, but doesn't work yet. When called with Cargo, Rustc generates perfect WASM. When called with Nix, Rustc does generate WASM, but it is not usable.

This patch-set as of yesterday works nicely, and I've used this patch set
in ofborg. We should probably merge it, and do wasm dev in a different
patch set?
On Sat, Dec 1, 2018 at 6:18 AM Pierre-Etienne Meunier <
<EMAIL_ADDRESS>wrote:

I'm currently tweaking this to try and compile Rust to WASM. This would be
very cool, but doesn't work yet. When called with Cargo, Rustc generates
perfect WASM. When called with Nix, Rustc does generate WASM, but it is not
usable.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/50452#issuecomment-443419034, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAErrJs8d5so8hx6WTxxl7Mo7pzbaWLLks5u0mV7gaJpZM4YmJeS
.

I think this patch should work nicely and honestly I'm willing to go ahead with this, without a test, since it's been waiting for a little bit.
I think RUSTDOC should also be set, too, as it was in my original patch (otherwise this will just happen again)


Rethink how we accomplish pin muxing

If you want to configure peripherals that require processor pads, you need to set the pad into the correct 'alternative,' or mode. Pads have multiple alternatives, depending on their usage. (This is also called pin muxing.) The current approach puts the responsibility on users to know what alternative is necessary for a given peripheral. Although this could be identified from the method signatures, it's more overhead, and the user's code isn't as clean. We should be able to simplify this API.
Consider the initialization of a UART peripheral, using Teensy pins 14 and 15. The snippet below describes how it happens today.
let mut uart = uarts
        .uart2
        .init(
            peripherals.pins.p14.alt2(),
            peripherals.pins.p15.alt2(),
            BAUD,
        )
        .unwrap();

See those calls to alt2()? Those set the pins into the correct alternative for UART. They're required because the signature if init() looks like
pub fn init<TX, RX>(
        self,
        mut tx: TX,
        mut rx: RX,
        baud: u32,
    ) -> Result<UART<M>, ccm::uart::TimingsError>
    where
        TX: uart::Pin<Direction = uart::TX, Module = M>,
        RX: uart::Pin<Direction = uart::RX, Module = M>,

and the uart::Pin implementations resemble
impl uart::Pin for GPIO_AD_B1_02<Alt2> {
  type Direction = uart::TX;
  type Module = uart::module::_2;
}

impl uart::Pin for GPIO_AD_B1_03<Alt2> {
  type Direction = uart::RX;
  type Module = uart::module::_2;
}

If we follow that through, we see that GPIO_AD_B1_02 can only be the TX pin for UART 2 when it's in the second alternative. Same applies for GPIO_AD_B1_03 as an RX pin. The only way to get a pad in that state is to call alt2().
I want to remove the requirement for users to set the alternative. Remove the calls to alt2() so that the snippet simplifies to
let mut uart = uarts
        .uart2
        .init(
            peripherals.pins.p14, // no more alt2() call
            peripherals.pins.p15, // no more alt2() call
            BAUD,
        )
        .unwrap();

A solution should not sacrifice compile-time checking for a convenient API. You cannot provide the wrong pin to the UART module; if you tried to pass in p13, rather than p14, for the TX pin, it fails to compile. You also cannot put the pin into the wrong alternative; a call of alt3(), rather than alt2(), fails to compile. We should keep these kinds of guarantees in a new approach.
This will probably require changes throughout the HAL, including in the IOMUXC modules, and all peripheral modules that depend on processor pins.
(Manually transferred from mciantyre/teensy4-rs#46)

I love this plan of using traits to expose pad functions.


Snackbar elevation is not working

There is no shadow effect displayed on Snackbar provided an elevation. Not event for the floating behavior.
ScaffoldMessenger.of(context).showSnackBar(
    SnackBar(
      elevation: 10,
      // content: ImportingImagesBanner(),
      content: Text(
        'Hey',
        style: TextStyle(color: Colors.black),
      ),
      behavior: SnackBarBehavior.floating,
      backgroundColor: Colors.white,
      duration: Duration(days: 1),
    ),
    );

Hello @chbloca. Thank you for filing this issue. Can you please provide the following information?

A complete and minimal, reproducible example. Ideally, a single main.dart file that can be run directly.
The output of flutter doctor -v
The output of flutter run -v

Please provide the information in the form of text. See how to make collapsible sections with Markdown here.

Thanks for the reply.
I noticed it just happens when using useMaterial3.
The code:
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        useMaterial3: true,
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatelessWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(title),
      ),
      body: Center(
        child: Container(),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: () => ScaffoldMessenger.of(context).showSnackBar(
          SnackBar(
            elevation: 4,
            backgroundColor: Colors.white,
            shape: RoundedRectangleBorder(
              borderRadius: BorderRadius.circular(12),
            ),
            content: const Text('Test'),
            behavior: SnackBarBehavior.floating,
            duration: const Duration(seconds: 2),
          ),
        ),
        tooltip: 'Increment',
        child: const Icon(Icons.add),
      ),
    );
  }
}

flutter run -v

[  +40 ms] executing: sysctl hw.optional.arm64
[   +7 ms] Exit code 0 from: sysctl hw.optional.arm64
[        ] hw.optional.arm64: 1
[   +2 ms] executing: [/Users/christen/development/flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[  +16 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] 52b3dc25f6471c27b2144594abb11c741cb88f57
[        ] executing: [/Users/christen/development/flutter/] git tag --points-at 52b3dc25f6471c27b2144594abb11c741cb88f57
[  +74 ms] Exit code 0 from: git tag --points-at 52b3dc25f6471c27b2144594abb11c741cb88f57
[        ] 3.3.8
[  +23 ms] executing: [/Users/christen/development/flutter/] git rev-parse --abbrev-ref --symbolic @{upstream}
[   +9 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{upstream}
[        ] origin/stable
[        ] executing: [/Users/christen/development/flutter/] git ls-remote --get-url origin
[  +19 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/flutter/flutter.git
[  +26 ms] executing: [/Users/christen/development/flutter/] git rev-parse --abbrev-ref HEAD
[   +9 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] stable
[   +3 ms] executing: sw_vers -productName
[  +10 ms] Exit code 0 from: sw_vers -productName
[        ] macOS
[        ] executing: sw_vers -productVersion
[   +7 ms] Exit code 0 from: sw_vers -productVersion
[        ] 13.0.1
[        ] executing: sw_vers -buildVersion
[  +15 ms] Exit code 0 from: sw_vers -buildVersion
[        ] 22A400
[        ] executing: uname -m
[   +4 ms] Exit code 0 from: uname -m
[        ] arm64
[  +27 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +3 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +30 ms] executing: /Users/christen/Library/Android/sdk/platform-tools/adb devices -l
[   +6 ms] executing: sysctl hw.optional.arm64
[   +3 ms] Exit code 0 from: sysctl hw.optional.arm64
[        ] hw.optional.arm64: 1
[        ] executing: /usr/bin/arch -arm64e xcrun xcodebuild -version
[ +706 ms] Exit code 0 from: /usr/bin/arch -arm64e xcrun xcodebuild -version
[   +1 ms] Xcode 14.1
           Build version 14B47b
[   +1 ms] executing: /usr/bin/arch -arm64e xcrun xcdevice list --timeout 2
[   +1 ms] /usr/bin/arch -arm64e xcrun simctl list --json devices
[        ] executing: /usr/bin/arch -arm64e xcrun simctl list --json devices
[   +1 ms] executing: /usr/bin/arch -arm64e xcrun simctl list
[  +76 ms] Exit code 0 from: /usr/bin/arch -arm64e xcrun simctl list
[        ] == Device Types ==
           iPhone 4s (com.apple.CoreSimulator.SimDeviceType.iPhone-4s)
           iPhone 5 (com.apple.CoreSimulator.SimDeviceType.iPhone-5)
           iPhone 5s (com.apple.CoreSimulator.SimDeviceType.iPhone-5s)
           iPhone 6 Plus (com.apple.CoreSimulator.SimDeviceType.iPhone-6-Plus)
           iPhone 6 (com.apple.CoreSimulator.SimDeviceType.iPhone-6)
           iPhone 6s (com.apple.CoreSimulator.SimDeviceType.iPhone-6s)
           iPhone 6s Plus (com.apple.CoreSimulator.SimDeviceType.iPhone-6s-Plus)
           iPhone SE (1st generation) (com.apple.CoreSimulator.SimDeviceType.iPhone-SE)
           iPhone 7 (com.apple.CoreSimulator.SimDeviceType.iPhone-7)
           iPhone 7 Plus (com.apple.CoreSimulator.SimDeviceType.iPhone-7-Plus)
           iPhone 8 (com.apple.CoreSimulator.SimDeviceType.iPhone-8)
           iPhone 8 Plus (com.apple.CoreSimulator.SimDeviceType.iPhone-8-Plus)
           iPhone X (com.apple.CoreSimulator.SimDeviceType.iPhone-X)
           iPhone Xs (com.apple.CoreSimulator.SimDeviceType.iPhone-XS)
           iPhone Xs Max (com.apple.CoreSimulator.SimDeviceType.iPhone-XS-Max)
           iPhone Xʀ (com.apple.CoreSimulator.SimDeviceType.iPhone-XR)
           iPhone 11 (com.apple.CoreSimulator.SimDeviceType.iPhone-11)
           iPhone 11 Pro (com.apple.CoreSimulator.SimDeviceType.iPhone-11-Pro)
           iPhone 11 Pro Max (com.apple.CoreSimulator.SimDeviceType.iPhone-11-Pro-Max)
           iPhone SE (2nd generation) (com.apple.CoreSimulator.SimDeviceType.iPhone-SE--2nd-generation-)
           iPhone 12 mini (com.apple.CoreSimulator.SimDeviceType.iPhone-12-mini)
           iPhone 12 (com.apple.CoreSimulator.SimDeviceType.iPhone-12)
           iPhone 12 Pro (com.apple.CoreSimulator.SimDeviceType.iPhone-12-Pro)
           iPhone 12 Pro Max (com.apple.CoreSimulator.SimDeviceType.iPhone-12-Pro-Max)
           iPhone 13 Pro (com.apple.CoreSimulator.SimDeviceType.iPhone-13-Pro)
           iPhone 13 Pro Max (com.apple.CoreSimulator.SimDeviceType.iPhone-13-Pro-Max)
           iPhone 13 mini (com.apple.CoreSimulator.SimDeviceType.iPhone-13-mini)
           iPhone 13 (com.apple.CoreSimulator.SimDeviceType.iPhone-13)
           iPhone SE (3rd generation) (com.apple.CoreSimulator.SimDeviceType.iPhone-SE-3rd-generation)
           iPhone 14 (com.apple.CoreSimulator.SimDeviceType.iPhone-14)
           iPhone 14 Plus (com.apple.CoreSimulator.SimDeviceType.iPhone-14-Plus)
           iPhone 14 Pro (com.apple.CoreSimulator.SimDeviceType.iPhone-14-Pro)
           iPhone 14 Pro Max (com.apple.CoreSimulator.SimDeviceType.iPhone-14-Pro-Max)
           iPod touch (7th generation) (com.apple.CoreSimulator.SimDeviceType.iPod-touch--7th-generation-)
           iPad 2 (com.apple.CoreSimulator.SimDeviceType.iPad-2)
           iPad Retina (com.apple.CoreSimulator.SimDeviceType.iPad-Retina)
           iPad Air (com.apple.CoreSimulator.SimDeviceType.iPad-Air)
           iPad mini 2 (com.apple.CoreSimulator.SimDeviceType.iPad-mini-2)
           iPad mini 3 (com.apple.CoreSimulator.SimDeviceType.iPad-mini-3)
           iPad mini 4 (com.apple.CoreSimulator.SimDeviceType.iPad-mini-4)
           iPad Air 2 (com.apple.CoreSimulator.SimDeviceType.iPad-Air-2)
           iPad Pro (9.7-inch) (com.apple.CoreSimulator.SimDeviceType.iPad-Pro--9-7-inch-)
           iPad Pro (12.9-inch) (1st generation) (com.apple.CoreSimulator.SimDeviceType.iPad-Pro)
           iPad (5th generation) (com.apple.CoreSimulator.SimDeviceType.iPad--5th-generation-)
           iPad Pro (12.9-inch) (2nd generation) (com.apple.CoreSimulator.SimDeviceType.iPad-Pro--12-9-inch---2nd-generation-)
           iPad Pro (10.5-inch) (com.apple.CoreSimulator.SimDeviceType.iPad-Pro--10-5-inch-)
           iPad (6th generation) (com.apple.CoreSimulator.SimDeviceType.iPad--6th-generation-)
           iPad (7th generation) (com.apple.CoreSimulator.SimDeviceType.iPad--7th-generation-)
           iPad Pro (11-inch) (1st generation) (com.apple.CoreSimulator.SimDeviceType.iPad-Pro--11-inch-)
           iPad Pro (12.9-inch) (3rd generation) (com.apple.CoreSimulator.SimDeviceType.iPad-Pro--12-9-inch---3rd-generation-)
           iPad Pro (11-inch) (2nd generation) (com.apple.CoreSimulator.SimDeviceType.iPad-Pro--11-inch---2nd-generation-)
           iPad Pro (12.9-inch) (4th generation) (com.apple.CoreSimulator.SimDeviceType.iPad-Pro--12-9-inch---4th-generation-)
           iPad mini (5th generation) (com.apple.CoreSimulator.SimDeviceType.iPad-mini--5th-generation-)
           iPad Air (3rd generation) (com.apple.CoreSimulator.SimDeviceType.iPad-Air--3rd-generation-)
           iPad (8th generation) (com.apple.CoreSimulator.SimDeviceType.iPad--8th-generation-)
           iPad (9th generation) (com.apple.CoreSimulator.SimDeviceType.iPad-9th-generation)
           iPad Air (4th generation) (com.apple.CoreSimulator.SimDeviceType.iPad-Air--4th-generation-)
           iPad Pro (11-inch) (3rd generation) (com.apple.CoreSimulator.SimDeviceType.iPad-Pro-11-inch-3rd-generation)
           iPad Pro (12.9-inch) (5th generation) (com.apple.CoreSimulator.SimDeviceType.iPad-Pro-12-9-inch-5th-generation)
           iPad Air (5th generation) (com.apple.CoreSimulator.SimDeviceType.iPad-Air-5th-generation)
           iPad (10th generation) (com.apple.CoreSimulator.SimDeviceType.iPad-10th-generation)
           iPad mini (6th generation) (com.apple.CoreSimulator.SimDeviceType.iPad-mini-6th-generation)
           iPad Pro (11-inch) (4th generation) (com.apple.CoreSimulator.SimDeviceType.iPad-Pro-11-inch-4th-generation-8GB)
           iPad Pro (11-inch) (4th generation) (16GB) (com.apple.CoreSimulator.SimDeviceType.iPad-Pro-11-inch-4th-generation-16GB)
           iPad Pro (12.9-inch) (6th generation) (com.apple.CoreSimulator.SimDeviceType.iPad-Pro-12-9-inch-6th-generation-8GB)
           iPad Pro (12.9-inch) (6th generation) (16GB) (com.apple.CoreSimulator.SimDeviceType.iPad-Pro-12-9-inch-6th-generation-16GB)
           Apple TV (com.apple.CoreSimulator.SimDeviceType.Apple-TV-1080p)
           Apple TV 4K (com.apple.CoreSimulator.SimDeviceType.Apple-TV-4K-4K)
           Apple TV 4K (at 1080p) (com.apple.CoreSimulator.SimDeviceType.Apple-TV-4K-1080p)
           Apple TV 4K (2nd generation) (com.apple.CoreSimulator.SimDeviceType.Apple-TV-4K-2nd-generation-4K)
           Apple TV 4K (2nd generation) (at 1080p) (com.apple.CoreSimulator.SimDeviceType.Apple-TV-4K-2nd-generation-1080p)
           Apple TV 4K (3rd generation) (com.apple.CoreSimulator.SimDeviceType.Apple-TV-4K-3rd-generation-4K)
           Apple TV 4K (3rd generation) (at 1080p) (com.apple.CoreSimulator.SimDeviceType.Apple-TV-4K-3rd-generation-1080p)
           Apple Watch (38mm) (com.apple.CoreSimulator.SimDeviceType.Apple-Watch-38mm)
           Apple Watch (42mm) (com.apple.CoreSimulator.SimDeviceType.Apple-Watch-42mm)
           Apple Watch Series 2 (38mm) (com.apple.CoreSimulator.SimDeviceType.Apple-Watch-Series-2-38mm)
           Apple Watch Series 2 (42mm) (com.apple.CoreSimulator.SimDeviceType.Apple-Watch-Series-2-42mm)
           Apple Watch Series 3 (38mm) (com.apple.CoreSimulator.SimDeviceType.Apple-Watch-Series-3-38mm)
           Apple Watch Series 3 (42mm) (com.apple.CoreSimulator.SimDeviceType.Apple-Watch-Series-3-42mm)
           Apple Watch Series 4 (40mm) (com.apple.CoreSimulator.SimDeviceType.Apple-Watch-Series-4-40mm)
           Apple Watch Series 4 (44mm) (com.apple.CoreSimulator.SimDeviceType.Apple-Watch-Series-4-44mm)
           Apple Watch Series 5 (40mm) (com.apple.CoreSimulator.SimDeviceType.Apple-Watch-Series-5-40mm)
           Apple Watch Series 5 (44mm) (com.apple.CoreSimulator.SimDeviceType.Apple-Watch-Series-5-44mm)
           Apple Watch SE (40mm) (com.apple.CoreSimulator.SimDeviceType.Apple-Watch-SE-40mm)
           Apple Watch SE (44mm) (com.apple.CoreSimulator.SimDeviceType.Apple-Watch-SE-44mm)
           Apple Watch Series 6 (40mm) (com.apple.CoreSimulator.SimDeviceType.Apple-Watch-Series-6-40mm)
           Apple Watch Series 6 (44mm) (com.apple.CoreSimulator.SimDeviceType.Apple-Watch-Series-6-44mm)
           Apple Watch Series 7 (41mm) (com.apple.CoreSimulator.SimDeviceType.Apple-Watch-Series-7-41mm)
           Apple Watch Series 7 (45mm) (com.apple.CoreSimulator.SimDeviceType.Apple-Watch-Series-7-45mm)
           Apple Watch SE (40mm) (2nd generation) (com.apple.CoreSimulator.SimDeviceType.Apple-Watch-SE-40mm-2nd-generation)
           Apple Watch SE (44mm) (2nd generation) (com.apple.CoreSimulator.SimDeviceType.Apple-Watch-SE-44mm-2nd-generation)
           Apple Watch Series 8 (41mm) (com.apple.CoreSimulator.SimDeviceType.Apple-Watch-Series-8-41mm)
           Apple Watch Series 8 (45mm) (com.apple.CoreSimulator.SimDeviceType.Apple-Watch-Series-8-45mm)
           Apple Watch Ultra (49mm) (com.apple.CoreSimulator.SimDeviceType.Apple-Watch-Ultra-49mm)
           == Runtimes ==
           iOS 16.1 (16.1 - 20B72) - com.apple.CoreSimulator.SimRuntime.iOS-16-1
           == Devices ==
           -- iOS 16.1 --
               iPhone SE (3rd generation) (06BA4949-DEE6-40A0-9A92-4CF4B82CA5DA) (Shutdown)
               iPhone 14 (42C1DFD9-E1D1-4A18-87D3-2356CF277B9A) (Shutdown)
               iPhone 14 Plus (0C8B8109-8538-4299-B1B0-B8536A4D0D66) (Shutdown)
               iPhone 14 Pro (2AFEFCD1-761B-41EF-998F-ACBEB6180478) (Shutdown)
               iPhone 14 Pro Max (2D52FAD2-3E3E-4891-8034-EF301E23C259) (Shutdown)
               iPad Air (5th generation) (C865B6FD-7AE4-4012-AD13-C7384490E78B) (Shutdown)
               iPad (10th generation) (5A92C1EC-4047-42CE-A8F4-B1C4B21BD3EF) (Shutdown)
               iPad mini (6th generation) (39412863-F06E-4AD1-A48E-4036B6C4D2AA) (Shutdown)
               iPad Pro (11-inch) (4th generation) (3BD5E09B-0B63-4A14-A63C-DA3C5EF9C126) (Shutdown)
               iPad Pro (12.9-inch) (6th generation) (3A38F130-D047-48D3-B5C9-116D8C80E23F) (Shutdown)
           == Device Pairs ==
[  +20 ms] List of devices attached
           emulator-5554          device product:sdk_gphone64_arm64 model:sdk_gphone64_arm64 device:emu64a transport_id:1
[  +71 ms] {
             "devices" : {
               "com.apple.CoreSimulator.SimRuntime.iOS-16-1" : [
                 {
                   "lastBootedAt" : "2022-11-13T13:09:24Z",
                   "dataPath" : "\/Users\/christen\/Library\/Developer\/CoreSimulator\/Devices\/06BA4949-DEE6-40A0-9A92-4CF4B82CA5DA\/data",
                   "dataPathSize" :<PHONE_NUMBER>,
                   "logPath" : "\/Users\/christen\/Library\/Logs\/CoreSimulator\/06BA4949-DEE6-40A0-9A92-4CF4B82CA5DA",
                   "udid" : "06BA4949-DEE6-40A0-9A92-4CF4B82CA5DA",
                   "isAvailable" : true,
                   "logPathSize" : 98304,
                   "deviceTypeIdentifier" : "com.apple.CoreSimulator.SimDeviceType.iPhone-SE-3rd-generation",
                   "state" : "Shutdown",
                   "name" : "iPhone SE (3rd generation)"
                 },
                 {
                   "dataPath" : "\/Users\/christen\/Library\/Developer\/CoreSimulator\/Devices\/42C1DFD9-E1D1-4A18-87D3-2356CF277B9A\/data",
                   "dataPathSize" : 13316096,
                   "logPath" : "\/Users\/christen\/Library\/Logs\/CoreSimulator\/42C1DFD9-E1D1-4A18-87D3-2356CF277B9A",
                   "udid" : "42C1DFD9-E1D1-4A18-87D3-2356CF277B9A",
                   "isAvailable" : true,
                   "deviceTypeIdentifier" : "com.apple.CoreSimulator.SimDeviceType.iPhone-14",
                   "state" : "Shutdown",
                   "name" : "iPhone 14"
                 },
                 {
                   "dataPath" : "\/Users\/christen\/Library\/Developer\/CoreSimulator\/Devices\/0C8B8109-8538-4299-B1B0-B8536A4D0D66\/data",
                   "dataPathSize" : 13316096,
                   "logPath" : "\/Users\/christen\/Library\/Logs\/CoreSimulator\/0C8B8109-8538-4299-B1B0-B8536A4D0D66",
                   "udid" : "0C8B8109-8538-4299-B1B0-B8536A4D0D66",
                   "isAvailable" : true,
                   "deviceTypeIdentifier" : "com.apple.CoreSimulator.SimDeviceType.iPhone-14-Plus",
                   "state" : "Shutdown",
                   "name" : "iPhone 14 Plus"
                 },
                 {
                   "dataPath" : "\/Users\/christen\/Library\/Developer\/CoreSimulator\/Devices\/2AFEFCD1-761B-41EF-998F-ACBEB6180478\/data",
                   "dataPathSize" : 13316096,
                   "logPath" : "\/Users\/christen\/Library\/Logs\/CoreSimulator\/2AFEFCD1-761B-41EF-998F-ACBEB6180478",
                   "udid" : "2AFEFCD1-761B-41EF-998F-ACBEB6180478",
                   "isAvailable" : true,
                   "deviceTypeIdentifier" : "com.apple.CoreSimulator.SimDeviceType.iPhone-14-Pro",
                   "state" : "Shutdown",
                   "name" : "iPhone 14 Pro"
                 },
                 {
                   "dataPath" : "\/Users\/christen\/Library\/Developer\/CoreSimulator\/Devices\/2D52FAD2-3E3E-4891-8034-EF301E23C259\/data",
                   "dataPathSize" : 13316096,
                   "logPath" : "\/Users\/christen\/Library\/Logs\/CoreSimulator\/2D52FAD2-3E3E-4891-8034-EF301E23C259",
                   "udid" : "2D52FAD2-3E3E-4891-8034-EF301E23C259",
                   "isAvailable" : true,
                   "deviceTypeIdentifier" : "com.apple.CoreSimulator.SimDeviceType.iPhone-14-Pro-Max",
                   "state" : "Shutdown",
                   "name" : "iPhone 14 Pro Max"
                 },
                 {
                   "dataPath" : "\/Users\/christen\/Library\/Developer\/CoreSimulator\/Devices\/C865B6FD-7AE4-4012-AD13-C7384490E78B\/data",
                   "dataPathSize" : 13316096,
                   "logPath" : "\/Users\/christen\/Library\/Logs\/CoreSimulator\/C865B6FD-7AE4-4012-AD13-C7384490E78B",
                   "udid" : "C865B6FD-7AE4-4012-AD13-C7384490E78B",
                   "isAvailable" : true,
                   "deviceTypeIdentifier" : "com.apple.CoreSimulator.SimDeviceType.iPad-Air-5th-generation",
                   "state" : "Shutdown",
                   "name" : "iPad Air (5th generation)"
                 },
                 {
                   "dataPath" : "\/Users\/christen\/Library\/Developer\/CoreSimulator\/Devices\/5A92C1EC-4047-42CE-A8F4-B1C4B21BD3EF\/data",
                   "dataPathSize" : 13316096,
                   "logPath" : "\/Users\/christen\/Library\/Logs\/CoreSimulator\/5A92C1EC-4047-42CE-A8F4-B1C4B21BD3EF",
                   "udid" : "5A92C1EC-4047-42CE-A8F4-B1C4B21BD3EF",
                   "isAvailable" : true,
                   "deviceTypeIdentifier" : "com.apple.CoreSimulator.SimDeviceType.iPad-10th-generation",
                   "state" : "Shutdown",
                   "name" : "iPad (10th generation)"
                 },
                 {
                   "dataPath" : "\/Users\/christen\/Library\/Developer\/CoreSimulator\/Devices\/39412863-F06E-4AD1-A48E-4036B6C4D2AA\/data",
                   "dataPathSize" : 13316096,
                   "logPath" : "\/Users\/christen\/Library\/Logs\/CoreSimulator\/39412863-F06E-4AD1-A48E-4036B6C4D2AA",
                   "udid" : "39412863-F06E-4AD1-A48E-4036B6C4D2AA",
                   "isAvailable" : true,
                   "deviceTypeIdentifier" : "com.apple.CoreSimulator.SimDeviceType.iPad-mini-6th-generation",
                   "state" : "Shutdown",
                   "name" : "iPad mini (6th generation)"
                 },
                 {
                   "dataPath" : "\/Users\/christen\/Library\/Developer\/CoreSimulator\/Devices\/3BD5E09B-0B63-4A14-A63C-DA3C5EF9C126\/data",
                   "dataPathSize" : 13316096,
                   "logPath" : "\/Users\/christen\/Library\/Logs\/CoreSimulator\/3BD5E09B-0B63-4A14-A63C-DA3C5EF9C126",
                   "udid" : "3BD5E09B-0B63-4A14-A63C-DA3C5EF9C126",
                   "isAvailable" : true,
                   "deviceTypeIdentifier" : "com.apple.CoreSimulator.SimDeviceType.iPad-Pro-11-inch-4th-generation-8GB",
                   "state" : "Shutdown",
                   "name" : "iPad Pro (11-inch) (4th generation)"
                 },
                 {
                   "dataPath" : "\/Users\/christen\/Library\/Developer\/CoreSimulator\/Devices\/3A38F130-D047-48D3-B5C9-116D8C80E23F\/data",
                   "dataPathSize" : 13316096,
                   "logPath" : "\/Users\/christen\/Library\/Logs\/CoreSimulator\/3A38F130-D047-48D3-B5C9-116D8C80E23F",
                   "udid" : "3A38F130-D047-48D3-B5C9-116D8C80E23F",
                   "isAvailable" : true,
                   "deviceTypeIdentifier" : "com.apple.CoreSimulator.SimDeviceType.iPad-Pro-12-9-inch-6th-generation-8GB",
                   "state" : "Shutdown",
                   "name" : "iPad Pro (12.9-inch) (6th generation)"
                 }
               ]
             }
           }
[+2889 ms] [
                      {
                        "simulator" : true,
                        "operatingSystemVersion" : "16.1 (20B72)",
                        "available" : true,
                        "platform" : "com.apple.platform.iphonesimulator",
                        "modelCode" : "iPad13,17",
                        "identifier" : "C865B6FD-7AE4-4012-AD13-C7384490E78B",
                        "architecture" : "arm64",
                        "modelUTI" : "com.apple.ipad-air5-1",
                        "modelName" : "iPad Air (5th generation)",
                        "name" : "iPad Air (5th generation)"
                      },
                      {
                        "simulator" : true,
                        "operatingSystemVersion" : "16.1 (20B72)",
                        "available" : true,
                        "platform" : "com.apple.platform.iphonesimulator",
                        "modelCode" : "iPhone15,3",
                        "identifier" : "2D52FAD2-3E3E-4891-8034-EF301E23C259",
                        "architecture" : "arm64",
                        "modelUTI" : "com.apple.iphone-14-pro-max-1",
                        "modelName" : "iPhone 14 Pro Max",
                        "name" : "iPhone 14 Pro Max"
                      },
                      {
                        "simulator" : true,
                        "operatingSystemVersion" : "16.1 (20B72)",
                        "available" : true,
                        "platform" : "com.apple.platform.iphonesimulator",
                        "modelCode" : "iPhone14,8",
                        "identifier" : "0C8B8109-8538-4299-B1B0-B8536A4D0D66",
                        "architecture" : "arm64",
                        "modelUTI" : "com.apple.iphone-14-plus-1",
                        "modelName" : "iPhone 14 Plus",
                        "name" : "iPhone 14 Plus"
                      },
                      {
                        "simulator" : true,
                        "operatingSystemVersion" : "16.1 (20B72)",
                        "available" : true,
                        "platform" : "com.apple.platform.iphonesimulator",
                        "modelCode" : "iPad14,3",
                        "identifier" : "3BD5E09B-0B63-4A14-A63C-DA3C5EF9C126",
                        "architecture" : "arm64",
                        "modelUTI" : "com.apple.ipad-pro-11-4th-1",
                        "modelName" : "iPad Pro (11-inch) (4th generation)",
                        "name" : "iPad Pro (11-inch) (4th generation)"
                      },
                      {
                        "simulator" : true,
                        "operatingSystemVersion" : "16.1 (20B72)",
                        "available" : true,
                        "platform" : "com.apple.platform.iphonesimulator",
                        "modelCode" : "iPhone14,6",
                        "identifier" : "06BA4949-DEE6-40A0-9A92-4CF4B82CA5DA",
                        "architecture" : "arm64",
                        "modelUTI" : "com.apple.iphone-se3-1",
                        "modelName" : "iPhone SE (3rd generation)",
                        "name" : "iPhone SE (3rd generation)"
                      },
                      {
                        "simulator" : true,
                        "operatingSystemVersion" : "16.1 (20B72)",
                        "available" : true,
                        "platform" : "com.apple.platform.iphonesimulator",
                        "modelCode" : "iPhone15,2",
                        "identifier" : "2AFEFCD1-761B-41EF-998F-ACBEB6180478",
                        "architecture" : "arm64",
                        "modelUTI" : "com.apple.iphone-14-pro-1",
                        "modelName" : "iPhone 14 Pro",
                        "name" : "iPhone 14 Pro"
                      },
                      {
                        "simulator" : false,
                        "operatingSystemVersion" : "13.0.1 (22A400)",
                        "interface" : "usb",
                        "available" : true,
                        "platform" : "com.apple.platform.macosx",
                        "modelCode" : "MacBookPro18,3",
                        "identifier" : "00006000-000264481AF9401E",
                        "architecture" : "arm64e",
                        "modelUTI" : "com.apple.macbookpro-14-2021",
                        "modelName" : "MacBook Pro",
                        "name" : "My Mac"
                      },
                      {
                        "simulator" : true,
                        "operatingSystemVersion" : "16.1 (20B72)",
                        "available" : true,
                        "platform" : "com.apple.platform.iphonesimulator",
                        "modelCode" : "iPad13,18",
                        "identifier" : "5A92C1EC-4047-42CE-A8F4-B1C4B21BD3EF",
                        "architecture" : "arm64",
                        "modelUTI" : "com.apple.ipad-10-1",
                        "modelName" : "iPad (10th generation)",
                        "name" : "iPad (10th generation)"
                      },
                      {
                        "simulator" : true,
                        "operatingSystemVersion" : "16.1 (20B72)",
                        "available" : true,
                        "platform" : "com.apple.platform.iphonesimulator",
                        "modelCode" : "iPad14,1",
                        "identifier" : "39412863-F06E-4AD1-A48E-4036B6C4D2AA",
                        "architecture" : "arm64",
                        "modelUTI" : "com.apple.ipad-mini6-1",
                        "modelName" : "iPad mini (6th generation)",
                        "name" : "iPad mini (6th generation)"
                      },
                      {
                        "simulator" : true,
                        "operatingSystemVersion" : "16.1 (20B72)",
                        "available" : true,
                        "platform" : "com.apple.platform.iphonesimulator",
                        "modelCode" : "iPad14,5",
                        "identifier" : "3A38F130-D047-48D3-B5C9-116D8C80E23F",
                        "architecture" : "arm64",
                        "modelUTI" : "com.apple.ipad-pro-12point9-6th-1",
                        "modelName" : "iPad Pro (12.9-inch) (6th generation)",
                        "name" : "iPad Pro (12.9-inch) (6th generation)"
                      },
                      {
                        "simulator" : true,
                        "operatingSystemVersion" : "16.1 (20B72)",
                        "available" : true,
                        "platform" : "com.apple.platform.iphonesimulator",
                        "modelCode" : "iPhone14,7",
                        "identifier" : "42C1DFD9-E1D1-4A18-87D3-2356CF277B9A",
                        "architecture" : "arm64",
                        "modelUTI" : "com.apple.iphone-14-1",
                        "modelName" : "iPhone 14",
                        "name" : "iPhone 14"
                      }
                    ]
[   +5 ms] /Users/christen/Library/Android/sdk/platform-tools/adb -s emulator-5554 shell getprop
[  +46 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[   +2 ms] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +14 ms] "flutter run" took 3,896ms.
[  +10 ms] Error: No pubspec.yaml file found.
           This command should be run from the root of your Flutter project.
[        ]
           #0      throwToolExit (package:flutter_tools/src/base/common.dart:10:3)
           #1      FlutterCommand.validateCommand (package:flutter_tools/src/runner/flutter_command.dart:1495:9)
           #2      RunCommand.validateCommand (package:flutter_tools/src/commands/run.dart:486:19)
           #3      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:1330:11)
           <asynchronous suspension>
           #4      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1209:27)
           <asynchronous suspension>
           #5      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
           <asynchronous suspension>
           #6      CommandRunner.runCommand (package:args/command_runner.dart:209:13)
           <asynchronous suspension>
           #7      FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:281:9)
           <asynchronous suspension>
           #8      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
           <asynchronous suspension>
           #9      FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:229:5)
           <asynchronous suspension>
           #10     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:62:9)
           <asynchronous suspension>
           #11     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
           <asynchronous suspension>
           #12     main (package:flutter_tools/executable.dart:91:3)
           <asynchronous suspension>

[ +126 ms] ensureAnalyticsSent: 125ms
[   +1 ms] Running shutdown hooks
[        ] Shutdown hooks complete
[        ] exiting with code 1

flutter doctor -v

[✓] Flutter (Channel stable, 3.3.8, on macOS 13.0.1 22A400 darwin-arm, locale en-ES)
    • Flutter version 3.3.8 on channel stable at /Users/christen/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 52b3dc25f6 (6 days ago), 2022-11-09 12:09:26 +0800
    • Engine revision 857bd6b74c
    • Dart version 2.18.4
    • DevTools version 2.15.0

[!] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/christen/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] VS Code (version 1.73.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.52.0

[✓] Connected device (3 available)
    • sdk gphone64 arm64 (mobile) • emulator-5554 • android-arm64  • Android 13 (API 33) (emulator)
    • macOS (desktop)             • macos         • darwin-arm64   • macOS 13.0.1 22A400 darwin-arm
    • Chrome (web)                • chrome        • web-javascript • Google Chrome 107.0.5304.110

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Hello @chbloca. I cannot reproduce this issue on master.

I can, however, reproduce this on stable. But seeing as this is fixed in master, and this would be released as a stable version in the future, this issue is invalid since it's fixed. Closing due to that reason. Thank you.


Focus in mobile filters

This PR is a first attempt at fixing: https://github.com/joemasilotti/railsdevs.com/issues/541
Resolved: When "Filters" button focused, screen readers should not announce "collapsed"
In Progress: Focus should be trapped inside modal while modal is open (should not move back to main page)
I ran  bin/check but it throws an error while it was in progress: (seems like it didn't want to complete the last of the tests)
objc[71328]: +[__NSCFConstantString initialize] may have been in progress in another thread when fork() was called.
My modifications were adding javascript file and adding a class to a few .html.erb files. I can add tests if needed, but may need some direction on where they should be included.
Didn't update changelog yet but I can if requested.
I created a draft pull request, since this is definitely not ready yet.
Pull request checklist

[ ] My code contains tests covering the code I modified
[ ] I linted and tested the project with bin/check
[ ] I added significant changes and product updates to the changelog

I don't think that test failure is related to your changes. That looks like Objective-C code to me! Regardless, I wouldn't worry about tests for this improvement.
Looking at the code, I have two questions/requests:

Do we need to have all of those classes added? Can we add it once on the outer form? Or target the child elements of a specific form in the Stimulus controller? It feels like a lot of additional changes - and ones that might be forgotten if we add a new filter.
I'd prefer using the Stimulus target API instead of class names if we can get that to work.

@joemasilotti yea I'm struggling to get anything to work on this. It just seems like it won't initiate the logic in my stimulus controller not matter what I try. I really wish I could figure this on out on my own, but I may need som assistance on this one.

Thanks for the update! I'm going to close this out for now. I spent some time diving in and I'm not happy with my implementation.


Refactor VecPyTorchFrameStack

In this PR I did some minor refactoring, in particular of the VecPyTorchFrameStack  class. I also added the num_frame_stack  parameter to the make_vec_envs  function. Although this is not used in main.py, I think it makes sense to keep all the code except from main.py (since this is the file that most users customize) as backwards compatible as possible.

Ok. Looks good now, merging.