firebase-dsym-upload 1.1.1

What to do if the build fails?
At the moment contributors do not have access to the CI workflow triggered by StepLib PRs. In case of a failed build, we ask for your patience. Maintainers of Bitrise Steplib will sort it out for you or inform you if any further action is needed.
New Pull Request Checklist
Please mark the points which you did / accept.

[x] I will not move an already shared step version's tag to another commit
[x] I read the Step Development Guideline
[x] I have a test for my Step, which can be run with bitrise run test (in the step's repository)
[x] I did run bitrise run audit-this-step (in the step's repository - note, if you don't have this workflow in your bitrise.yml, you can copy it from the step template.)
[x] I read and accept the Abandoned Step policy

Fixes an issue where the step may fail for some users.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Updated terraform.py to set the private_ipv4 for all Vsphere hosts

Some of the ansible roles like docker require this for all hosts in the inventory.

while you're in here, would you be able to add an appropriate value for public_ipv4, please?

@BrianHicks I've added public_ipv4 as well.

LGTM, thanks!


Reporting incorrect lyrics

Hello, I recently came across some incorrect/poisoned lyrics that contain someone’s instagram/discord rather than the song’s lyrics. Is there any moderation system in place or is anyone able to submit lyrics?

I was a bit busy in the past weeks, but I will seriously focus into this problem now.
At first I manually removed the spam lyrics records. Search API results they should be updated within 24 hours (after the caches for those records were expired).
The lyrics records I removed is from this search, if you see anything more please feel free to notify me:

https://lrclib.net/api/search?q=succubus+ken+carson

My next steps will be updating the LRCLIB homepage (https://lrclib.net) with the reporting feature, or you may update the lyrics yourself if you see a spam record.

Btw what is the source of the lyrics? Can we add lyrics that are missing from the database?

Btw what is the source of the lyrics? Can we add lyrics that are missing from the database?

https://lrclib.net/docs and see /api/publish and /api/request-challenge at the bottom

How to retrieve lyrics original source (ex. If lyrics from Musixmatch the it's URL) URL via API.


Duration "-1 hr" issue

I have several movies in more than 1 hour length each.
But mediaelement.js shows after 'preload="metadata"' that duration is less by 1 hour (i.e. 11:16 instead of 1:11:16).
When hovering progress bar, I see the same issue – "duration MOD 1 hour" (00:00 goes after 59:59).
If I press Play, everything is fine.
Please, fix this.
URL to check: http://baza.medhold.ru/test/index1.php

I think I found the fix for this:
		forceHours: true, 		currentTimeFormat: "hh:mm:ss", 		timeFormat: "hh:mm:ss",
in options (I found these options in mediaelement-and-player.js).
These options are not listed in documentation. Please update.

Thanks for pointing this out. There's a PR related to improve the documentation feel free to check it and let me know if that works for you #1805

Thanks a lot!
That's what's been needed. :)

The fix that @dayfuaim proposed doesn't really solve the issue, it just works around it. I'm implementing an audio player, and most times, the audio clips are under an hour, and in those cases, I don't want to force to show 00:HH:MM before every duration, only when the audio clip really exceeds 60m. Can either @dayfuaim or @ron666 reopen this?

@paulozoom If you want to create a PR for this, let me know; otherwise, I'll check this. Thanks.

@ron666 I'm taking a look at https://github.com/johndyer/mediaelement/blob/master/src/js/mep-feature-time.js but can't, for the life of me, understand what's causing this. All calls to updating the duration time (or current time for that matter) are being done with mejs.Utility.secondsToTimeCode, and the options argument is always (t.options), so it's not clear to me why, before hitting play, the hours aren't being shown but after play, they are.
Do you have any clue or pointers in the right direction?

Further investigation, I tried this before hitting play, with preload="metadata" in the <audio>.

Calling .media.duration on the player instance gives me 3946.6056, which is correct, but the duration shows as 05:46, not 01:05:46.
Manually calling .updateDuration() on the player instance doesn't produce any effect.
Manually calling .load() on the player instance doesn't produce any effect.

@paulozoom  No I haven't seen this before, if you have a URL we can test, I'd appreciate it

I was able to find the cause for the bug: https://github.com/johndyer/mediaelement/blob/9812c6f9530dd3e6dc5eb366b2cb5f69139ac768/src/js/mep-player.js#L766
The method which changes the time format is only being called on the timeupdate event, and it should also be called on the loadedmetadata event. If I manually make the calls which are in the timeupdate event, the correct duration is displayed.
Two options to fix this in the mep-player.js

Dispatch a timeupdate event inside the loadedmetadata event.
Make all the calls that are inside the timeupdate event handler also in the loadedmetadata event handler.

@ron666 What would you rather happen?

I think for the sake of simplicity I'd go with the first option you mentioned above but I'll tests it to make sure

I don't have a file that lasts that long to test this, can you provide one?

@paulozoom I prepared a PR that solves this (#1826). Test it and let me know if it works

Closing issue since fix has been merged


Small typo

Docs Build status updates of commit 3112ff9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/compliance/classifier-learn-about.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@tiburd Please merge this PR. Thanks

Docs Build status updates of commit 6a6dc9e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/compliance/classifier-learn-about.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Quesntion on ThreePointMsg.msg support

ThreePointMsg.msg used in global_planner/path_handler_node seems to be doing something quite similar to what mavros_msgs/trajectory is sending.
Would it make sense to depricate ThreePointMsg in global planner? or is there a reason that this is needed?

What was the conclusion here?

@Jaeyoung-Lim  why did you close the issue?
ThreePointMsg is old  message that was never upstreamed. It can be removed

@mrivi @mhkabir I was confused on what it was actually doing, so closed it so that I wanted to better understand what it is doing.
So, I need some help here, ThreePointMsg seems to be used to communicate between the global_planner_node and path_handler_node. Do you mean that this interface is not being used anymore?

@Jaeyoung-Lim  I am going by memory here but if I remember correctly it's published but not used anywhere.

@mrivi Okay, that's a good hint. I will look more into it. I guess it makes sense to deprecate it if it is not used.


On info.json

First of all, thank you for your wonderful work.
I have a question about the info.json file.
When I downloaded the file from EmoSet-118k, the file contents is as below.
{'label2idx': {'amusement': 0,   'awe': 1,   'contentment': 2,   'excitement': 3,   'anger': 4,   'disgust': 5,   'fear': 6,   'sadness': 7},  'idx2label': {'0': 'amusement',   '1': 'awe',   '2': 'contentment',   '3': 'excitement',   '4': 'anger',   '5': 'disgust',   '6': 'fear',   '7': 'sadness'}}
It seems that it only contains the mapping for emotion and mapping for attributes is missing.
Could you check this issue and update the info.json file?
Thank you in advance.

Hi.
Thanks for your attention.
We have updated the info.json file in here, maybe you can check it.
The mapping for attributes is included.
However, even without such mapping, you can still map attributes with their text names, e.g., "tree", in our previous version.
Hope this will help :)

@JingyuanYY can you also update the info.json in baidu.com?


Implement the ability to use a dynamic 'incoming port' for rtorrent - to use with Gluetun

Description
Gluetun has added the ability to use Port Forwarding for VPN providers, documented here
Would be really cool if we could set RT_INC_PORT dynamically, by using this functionality.
The (random) opened port number by the VPN provider can be obtained via the Control Server. For example: curl <IP_ADDRESS>:8000/v1/openvpn/portforwarded

It's required to restart rTorrent anyways when changing the port. Is it possible to restart the docker container with that environment variable? There should be a graceful exit, assuming your configuration works properly.


Low Battery Notification

With the recent version 2.27, battery information has been added for zigbee devices and DW2 sensor.
I have currently hard coded the threshold to 25%, ie, if a battery level drops below this, then HomeKit will display a low battery status.
So I wanted some opinions on this value of 25%:

Do you think it's too high? Would a value of eg 10% be better?
Would you prefer the option to define this % value yourself via the config?

Ben 😃

I think 25% it's a good percent, I mean it's a necessary change but is not "urgent!!!" and you have enough time to prepare you for a change batteries (charge other ones, buy it, etc). Now, if is possible setting the % by the user, anyone can decide what is the crucial moment (of the battery) for itself and put it. But, again, 25% it's a good standard for me.

Thanks for taking the time to give your feedback @imtitanic - I see we have the same idea with the 25%!
I have decided to go with the custom configuration (as not much feedback on here) so people can choose their own threshold. With a default of 25%.
This config option will be available in the upcoming 3.0 release.


Settings

Description
This PR fixes #
Notes for Reviewers
WIP
Redesigning Settings page.
Signed commits

[x] Yes, I signed my commits.

https://user-images.githubusercontent.com/79860504/172114715-c33203c7-e8c6-4514-8613-1e94e78bf8eb.mov

Cuurently operator/meshsync state, version... are not specifc to context as API calls are not ready for that, once it is done I will make necessary changes, so that each   operator/meshsync state, version... are reflected of corressponding contexts.
// @Abhishek-kumar09

Tests needs to be updated.

For uploading the config, there are two steps:

Upload the config, system detects all context,
Ask User which to connect.

I am facing issue with this, as it will require parsing of config file, and if there are 2/3... contexts and user doesn't selects all of them, a new config file with selected contexts needs to be created.
So this all logic should be handled on client side or should I expose an endpoint. Or some other approach or should we drop this idea.
// @leecalcote  @Abhishek-kumar09

For now I have kept functionality of just uploading file.

@MUzairS15 @Revolyssup " a new config file with selected contexts needs to be created." Is this true? Why do we need to create a config file at all? The context data is kept in local and remote provider databases, so, why the need to generate a new kubeconfig file?

@MUzairS15 heads-up: a merge conflict.

Closing commits pushed in https://github.com/meshery/meshery/pull/5528


Updating flag for hostname, was clashing with -h

Changed the flag for hostname from -hostname to  --hostname. Currently, when you type -hostname, it is interpreted as -h for help. So, currently it's not possible to host visdom on a server other than localhost.
This PR would prevent the clash with argparse's flag for help -h.
Example use:-
To run visdom server on a public server https://yourpublicserver at port 9000 you can now run the following command:
python server.py --hostname https://yourpublicserver -port 9000

Hope this helps others like me who want to host on a server other than localhost!

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] For JavaScript changes, I have re-generated the minified JavaScript code.

Submitted CLA! Hope it helps. Once It's pushed I can inform others in my lab to clone the new version.  Thanks.

@JackUrb Hey! How long is the PR kept in the landing area before merging it? I ask because once it's merged I can ask others in my research lab to clone the new version and we can share code with each other without breaking stuff! Thanks!

Ah it should've landed last night but something happened with the build, going to retry


Add ledger version to the ledger header result

Specifically, we're talking about the ledgerVersion field of the LedgerHeader xdr struct

Implementation plan:

add migration to include a protocol_version column to history_ledgers
update SQL queries to include protocol_version in results
Update JSON resources to render protocol version


Starred Goals

Give some of the goals VIP status by adding a star to the most important goals to have them quickly jump to the top of the list.

edit into task


Cancellation Token disposed on MacOS

Describe the bug
I am using the following code:
public static T InvokeSyncOnUIThread<T>(Func<Task<T>> thingToInvoke)
{
    T result = default;

    using (CancellationTokenSource source = new CancellationTokenSource())
    {
        if (Dispatcher.UIThread.CheckAccess())
        {
            thingToInvoke().ContinueWith(t =>
            {
                result = t.Result;
                source.Cancel();
            });

            Dispatcher.UIThread.MainLoop(source.Token);
        }
        else
        {
            Dispatcher.UIThread.InvokeAsync(() =>
            {
                thingToInvoke().ContinueWith(t =>
                {
                    result = t.Result;
                    source.Cancel();
                });
            });

            while (!source.IsCancellationRequested) { } //Loop until dialog is closed
        }
    }

    return result;
}

This works fine in Windows, but in MacOS (High Sierra) I get the following exceptions (all seem to be caused by the first source.Cancel(); line as Dispatcher.UIThread.MainLoop(source.Token); seems to have already disposed the token).
They all have the same outer exception, which makes sense:

Exception: A Task's exception(s) were not observed either by Waiting on the Task or accessing its Exception property. As a result, the unobserved exception was rethrown by the finalizer thread.

And different inner exceptions:

Inner Exception: System.ObjectDisposedException: The CancellationTokenSource has been disposed
Inner Exception: SharpGen.Runtime.SharpGenException: HRESULT: [0x80004005], Module: [General], ApiCode: [E_FAIL/Unspecified error], Message: Unknown

To Reproduce
Code above provided, but if requested I can make a minimum reproducible example
Expected behavior
Expected that Dispatcher.UIThread.MainLoop(source.Token); does not dispose the token on Mac
Desktop (please complete the following information):

OS: MacOS High Sierra 10.13.6
Avalonia Version 0.9.12

Can you check that code on 0.10?
I am just curious, SharpGenTools is not used there anymore IIRC.

@danwalmsley @kekekeks

You aren't supposed to call MainLoop multiple times. The only time it should be called in Program.Main either directly or through StartWithClassicDesktopLifetime

Working on getting a 0.10.0 example to see if I can reproduce
@kekekeks - what would be the recommended way to do this instead? This is what was recommended to me in https://github.com/AvaloniaUI/Avalonia/issues/4810#issuecomment-704259221

Ok, I was able to upgrade my project to 0.10.0-rc1 just enough to get this tested. It does still reproduce with 0.10.0-rc1. The SharpGenTools exception is now replaced with:

Inner Exception: System.Runtime.InteropServices.COMException (0x80004005): RunLoop failed

ShowDialog is returning Task for a reason. One is not supposed to wait for it synchronously.
Not sure why RunLoop is allowed to be called on other platforms, we don't support reentrancy, so calling it the second time will most like cause other issues as well.

I did a lot of reworking of my code to await async dialogs rather than trying to call them synchronously. I think I got it all converted over correctly. But I'm glad to say that I'm now no longer seeing the issue


Upgrade the act module version to v0.15.0

Codecov Report

Merging #75 (e733092) into master (4b70613) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@           Coverage Diff           @@
##           master      #75   +/-   ##
=======================================
  Coverage   76.23%   76.23%
=======================================
  Files          13       13
  Lines        1056     1056
=======================================
  Hits          805      805
  Misses        251      251

Flag
Coverage Δ

unittests
76.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Dockerfile is not granular enough

It would be a lot easier to work with the Dockerfile if the part where it downloads and compiles the Go toolchain was a seperate RUN step from the compilation of prometheus, since otherwise it attempts to download and build Go every. single. time. you. run. docker. build.

@discordianfish

@juliusv That's due to the fact that we're using the Makefile so we're using the same path to build with and without Docker. I can change it to use the golang base image which would be benificial for all Docker uses because of faster build and better reuse of images, but you suggest you also try to build the Docker image each time you change something (should be possible with travis/done etc I guess?).

@discordianfish Hmm, the Makefile currently takes care of some things you'd have to duplicate if you didn't use it:

creating a build environment with the right Go version and right versions of vendored dependencies (via godeps)
generating the build.go file with build information
potentially regenerating other things, but those are usually checked in anyways (lexer/parser/asset/protobuf files)

Btw., Go is downloaded every time now, but it's already a built package, so it's not actually compiled.
Docker-newbie question: Would it be possible to split the Dockerfile into two RUN steps: 1) make dependencies, 2) make build?
:+1: to building the Docker image as part of a CI test.


[BUG] DefaultContextResolver is not using defaultRealm value from the PolarisApplicationConfig

Is this a possible security vulnerability?

[X] This is NOT a possible security vulnerability

Describe the bug
PolarisApplicationConfig defines defaultRealm and allows overriding it trough configuration file. DefaultContextResolver ignores a value from the configuration.
To Reproduce

Setup an eclipse link with a database name which is different from default-realm
Set defaultRealm  in the configuration yaml file
Try to connect to get the token without setting realm explicitly in the request's headers
Polaris returns an error:

FATAL: database 'default-realm' does not exist

Actual Behavior
Configuration setting is not a source of truth for the all components
Expected Behavior
Configuration setting defines a default value for the all components
Additional context
No response
System information
No response

I came across the same issue, but since this error is thrown when the realm is incorrect or the bearer token is missing perhaps it could also indicate an attempt at unauthorized access. Either way the message returned could be clearer.


Format string literal syntax highlighting is broken for escapes and interpolations simultaneously

cc #4006, @ltentrup

As you can see, the string is bold starting from the escape sequence up until the first placeholder symbol.
This happens only inside of format strings as far as I can tell

Where does the highlighting for the escape string come from? It is not implemented in https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ra_ide/src/syntax_highlighting.rs where the logic for the format specifier is implemented.

Hmm, this is strange, if you take a look with the inspector you won't see where the bold styling comes from... Can't it be vscode bug? Can you reproduce it in your editor?

I just checked with the latest nightly, there is no escape sequence highlighting on my machine:

Maybe this is related to another extension or VSCode setting?

I have been experiencing a similar issue, which I thought was caused by some interaction between rust-analyzer and another extension I have installed. However, I can reproduce when rust-analyzer is the only extension enabled as well.
Initial state while window loads and rust-analyzer still starting up looks like this

This is expected, I think, as the semantic highlight has not been initialized yet?
Then, once it loads and I type a bit, this happens:

It seems like once semantic highlighting starts something changes. Strangely, all the output from the inspector window seems to be unchanged:
Escape before

Escape after

Format string before

Format string after

Does this issue persist in the latest nightly? There is now support for highlighting escape sequences (although it has to be enabled manually)

@ltentrup yes, it works as expected for me now, thank you! I didn't have to enable anything specific, it seemed to activate alongside the rest of semantic syntax highlighting. Is that expected?

No, I did not expect escape sequences to be highlighted as we introduced a custom/non-standard semantic token escapeSequence.
If you do not style escapeSequence manually in your settings.json it should just style as a string.

It looks like the escapeSequence allows the default semantic highlighting to kick in, instead of just treating the token as as string?
Compare this inspector output to the one I posted above:

In any case it now looks like it did before, so I would consider this issue resolved. Thanks again!

Sounds like this was resolved, please shout if there's still something to do here.

Sounds like this was resolved, please shout if there's still something to do here.


feat!: update Node.js SDK to use 'decryptionDomains' config option

Why
Add a short description about this PR.
Add links to issues, tech plans etc.
Changes the behaviour of outbound relay to instead use the decryptionDomains config option.
Warning: this is a breaking change. Will need to be published as a new major version.
How
Describe how you've approached the problem
Checklist

[ ] Commit messages are formatted as per the convention, and breaking changes are marked

We need to cover these changes with tests 1) to make it easier to check there are not backwards compatibility issues. 2) So deprecating the old paths will be easier in future.


Configure explorer arrow show or hide

Is your feature request related to a problem? Please describe.
Since hiding the arrow leads to the lack of some space, making it look a bit strange.
So I want the arrow to show.
Describe the solution you'd like
Add the hidesExplorerArrows option to configure the Explorer's arrow to show or hide
Describe alternatives you've considered
Currently I am directly modifying the hidesExplorerArrows option in ~/.vscode/extension/equinusocio.vsc-material-theme-2.3.0/themes/Material-Theme-Icons.json. But this is not friendly and I can't use the Settings Sync extension to back up my settings.

Hi @u3u, actually vscode doesn't expose this setting so you can't directly change it. I reported the issue to the vscode guys:
https://github.com/Microsoft/vscode/issues/56248
We must wait their fix

@equinusocio Maybe we can refer to the implementation of vscode-icons 😄

@u3u Thank you. We prefer a native managment through vscode settings, but we will think about adding a custom command. @LasaleFamine What do you think?

From a first look the implementation seems a bit "noisy", anyway we can wait some time until someone will reply your issue @equinusocio and meanwhile we can try to setup something that works like the vscode-icons. Maybe for the September release?
I'll take a deeper look later anyway.

New reference:
https://github.com/Microsoft/vscode/issues/45400


TODO: Management: Items

[x] Make DB tables.
[x] Make managements_items.php (Items listing)
[x] Make managements_items_add.php (Items action)
[x] Make managements_items_edit.php (Items action)
[x] Make managements_items_delete.php (Items action)

Allow edition but list all inventory listed with that item so admin can ensure that there will be no break up.
Allow item to be deleted only if no inventory is attached to this item. List all attached inventory with edition link so admin can make proper changes prior to delete.

Done


Telemetry: Add the version of CDP

We are collecting telemetry data for our Ducks. One metric to collect is what version of the CDP a Duck is using. As we are continually evolving our protocol, it would be great to know what version of CDP is being used before debugging.

I'm thinking this item could just be sent on boot one time. There's not much reason to send it more often than that.
In a 2-way scenario, we could also have a way from a remote system to ask for this information from a duck on-demand.

ahh ok. Thanks for clarifying! I made the edit to the issue.


TestRandomizedProgram gtest hangs on GS

Steps to reproduce:

Re-enable the test in tests/tt_metal/tt_metal/unit_tests_fast_dispatch/command_queue/test_EnqueueProgram.cpp
/build/test/tt_metal/unit_tests_fast_dispatch --gtest_filter=*TestRandomizedProgram

Works fine on N150/N300, but hangs on E150.

TestPipelineAcrossRows appears to fail in the same way on GS

TestPipelineAcrossRows appears to fail in the same way on GS

This one uses semaphores, something to look into

Why is this P2? Seems pretty basic. Maybe I can look at this next?

Why is this P2? Seems pretty basic. Maybe I can look at this next?

I filed it yesterday and did not know where to put it haha, feel free to change to where it should be (p0 since this is blocking parity?)

this is now passing after latest rounds of binaries and runtime arg changes.


update recipe

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@msarahan even though we rebuilt all the gdal stack with cb3 and we are and getting the latest build number for libgdal, conda is still install lots of packages from defaults here and the linux builds are failing. I'm not sure what I can do here...

@isuruf do you have an idea why we are getting:
libboost:         1.65.1-habcd387_4    defaults

here? I don't see any obvious packages that would lead downloading that one :-/

libkml is coming from defaults.

libkml is coming from defaults.

But I think libboost is causing that. Still I'm clueless there too, no idea why conda is not getting our libkml.

No, libkml from defaults doesn't have a python dependency, but conda-forge's does. Conda solver is using the easiest way out.
Can you change https://github.com/conda-forge/libkml-feedstock/blob/master/recipe/meta.yaml#L26 to boost-cpp and rebuild libkml?


log level from first created logger affect logging of other loggers with different log level

Please tell us about your environment:

winston version?

[ ] winston@2
[x] winston@3

_node -v outputs:_10.13.0
Operating System? (Linux)
Language? (ES6/7)

What is the problem?

Writing little logging utility on top of winston, on tests create instance of logger for each test
with different log levels. It appears that log level set on first logger creation is also set globally
to winston and affect logging, so if I create first logger with log level info, then create second
logger with log level debug and try to log somehting with debug level, those logs get ignored.
What do you expect to happen instead?

Each logger instance logs must respect their logger log level rather than global log level

Would you mind providing a small code example so we can reproduce and investigate this?  Definitely worth fixing if this turns out to be a bug.  Thanks!

Narrowed down problem finally, seems it is not bug but rather my mistake.
In my wrapper I made default config with transports property equal to [new transports.Console], and it seems to be used same instance of it in all loggers I created. When I substitute property with function, which every call calculate value, tests get fixed.
Therefore we should avoid using same transport, as seems transport remembers level of logs it allowed to output. If put firts create logger level verbose, then output of second log will be seen.
This code reproduce the problem:
  const winston = require('winston');

  const defaultTransports = [new winston.transports.Console];

  winston.createLogger({ level: 'info', transports: defaultTransports });

  const logger = winston.createLogger({
    level: 'verbose',
    transports: defaultTransports
 });

 logger.log('info', 'myInfoMessage');
 logger.log('verbose', 'myVerboseMessage');

 logger.close();


SSL handshake failed: invalid certificate chain

How frequently does the bug occur?
Always
Description
User is successfully logging in but I get a SSL handshake failed: invalid certificate chain when trying to Open a Realm with flexibleSyncConfiguration.
I get the same error when I try using partitions
Stacktrace & log output
2023-01-13 13:47:18.768111+0000 -------[1882:354976] Sync: Connection[1]: Session[1]: client_reset_config = false, Realm exists = true, client reset = false
2023-01-13 13:47:19.915756+0000 -------[1882:354976] Sync: Connected to endpoint ':443' (from ':55204')
2023-01-13 13:47:21.496084+0000 -------[1882:354976] Sync: Connection[1]: SSL handshake failed: invalid certificate chain
2023-01-13 13:47:21.496270+0000 -------[1882:354976] Sync: Connection[1]: Connection closed due to error

Can you reproduce the bug?
Always
Reproduction Steps
func initialize() async throws {
        //auth
        realmUser = try await app.login(credentials: .anonymous)
        self.configuration = realmUser?.flexibleSyncConfiguration(initialSubscriptions: { subs in
            if subs.first(named: "events") == nil {
                subs.append(QuerySubscription<Event>(name: "events"))
            }
            return

        }, rerunOnOpen: true)
        if let configuration = configuration {
            realm = try? await Realm(configuration: configuration, downloadBeforeOpen: .never)
        }
    }

Version
12.13.0
What Atlas Services are you using?
Atlas Device Sync
Are you using encryption?
No
Platform OS and version(s)
16.1
Build environment
Xcode version: Version 14.1
Dependency manager and version: Package Manager
MacOS Version: 12.5 M1 MacBook Pro

Hi @labelcoin Are you using a VPN, proxy etc? Is the date & time on your device correct?


build: moving example app to the main repo

connects to #109

I'm going to close this PR, a lot of random failing builds not related to the code.


feat: Remove AssemblyProcessor unused option

PR Details
This PR removes unused parameter for AssemblyProcessor. Because of recent changes  It is never used

[x] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] I have built and run the editor to try this change out.

How does it determine it needs to generate a module initializer then?

How does it determine it needs to generate a module initializer then? Another way to say it: how to we tell to not generate one?
Is it only based on the attribute? In that case, did we check that all previously generated initializer through the parameter do have that attribute?

if you dont want a module intializer generated then dont use stride.core.moduleinitializer
generated shaders use system moduleinitializer now
and all previous module initializers get generated through roslyn now in https://github.com/stride3d/stride/blob/master/sources/core/Stride.Core.CompilerServices/Generators/ModuleInitializerGenerator.cs
when is the scenario to not use an existing module initializer?

Tests failed in Teamcity: https://teamcity.stride3d.net/buildConfiguration/Engine_Tests_WindowsSimple/26996?expandBuildDeploymentsSection=false&hideTestsFromDependencies=false&expandPull+Request+Details=true&hideProblemsFromDependencies=false&expandBuildTestsSection=true&expandBuildProblemsSection=true


About the preprocessing for SUN & SUN-SEG

Thanks for your great work!
When I preprocess for SUN & SUN-SEG, I have a question for data/trans_videos_pretrain.py
line 14-16:
datasets = {     'SUN-SEG': 0, } only concludes the SUN-SEG, so how to preprocess the SUN?
Looking forward to your reply!

Hi @1170300714 thanks for your interest!
As SUN-SEG is developed based on SUN, so we only need to process SUN-SEG. (The data in SUN and SUN-SEG is totally the same)


Added description of parameters to method documentation in solver.p…

Updated the “see more info in the API docs” link in the README.md file
Added a description of methods supporting proxies for the solution and information about whether we have our own proxy for customers in the proxies section in the README.md file
Added extended examples amazon_waf_options.py, geetest_v4_options.py, turnstile_options.py to examples.
Added data parameter to hcaptcha_options.py example
Changed the name of the sol=>solver variable in the example file keycaptcha_options.py
Added package description to __init__.py file

@kratzky готово по задаче RC-2564


raftstore_cases::test_split_region::test_server_apply_new_version_snapshot' panicked

thread 'raftstore_cases::test_split_region::test_server_apply_new_version_snapshot' panicked at 'called `Result::unwrap()` on an `Err` value: Other(StringError("[tests/raftstore/cluster.rs:262]: can\'t get leader of region 1000"))', libcore/result.rs:945:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
stack backtrace:
   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
             at libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
   1: std::sys_common::backtrace::print
             at libstd/sys_common/backtrace.rs:71
             at libstd/sys_common/backtrace.rs:59
   2: std::panicking::default_hook::{{closure}}
             at libstd/panicking.rs:207
   3: std::panicking::default_hook
             at libstd/panicking.rs:223
   4: std::panicking::rust_panic_with_hook
             at libstd/panicking.rs:402
   5: std::panicking::begin_panic_fmt
             at libstd/panicking.rs:349
   6: rust_begin_unwind
             at libstd/panicking.rs:325
   7: core::panicking::panic_fmt
             at libcore/panicking.rs:72
   8: core::result::unwrap_failed
             at /checkout/src/libcore/macros.rs:26
   9: <core::result::Result<T, E>>::unwrap
             at /checkout/src/libcore/result.rs:782
  10: <integrations::raftstore::cluster::Cluster<T>>::request
             at tests/raftstore/cluster.rs:564
  11: <integrations::raftstore::cluster::Cluster<T>>::get_impl
             at tests/raftstore/cluster.rs:628
  12: <integrations::raftstore::cluster::Cluster<T>>::get
             at tests/raftstore/cluster.rs:616
  13: integrations::raftstore_cases::test_split_region::test_apply_new_version_snapshot
             at tests/raftstore_cases/test_split_region.rs:471
  14: integrations::raftstore_cases::test_split_region::test_server_apply_new_version_snapshot
             at tests/raftstore_cases/test_split_region.rs:492
  15: integrations::__test::TESTS::{{closure}}
             at tests/raftstore_cases/test_split_region.rs:490
  16: core::ops::function::FnOnce::call_once
             at /checkout/src/libcore/ops/function.rs:223
  17: <F as alloc::boxed::FnBox<A>>::call_box
             at libtest/lib.rs:1453
             at /checkout/src/libcore/ops/function.rs:223
             at /checkout/src/liballoc/boxed.rs:635
  18: __rust_maybe_catch_panic
             at libpanic_unwind/lib.rs:102

test_server_auto_split_region.txt
Another failed case.

I can't recall what have we done to make it not appear again. Or we have done nothing exactly, it's just unstable. Considering it didn't appear for a long time, I prefer to close it.


jax ValueError: Unknown platform interpreter

Issue Type
Bug
Source
binary
Secretflow Version
0.8.3b0
OS Platform and Distribution
Linux
Python version
3.8
Bazel version
No response
GCC/Compiler version
No response
What happend and What you expected to happen.
Error occurs when run spu.

ray.exceptions.WorkerCrashedError: The worker died unexpectedly while executing this task. Check python-core-worker-*.log files for more information.
2023-06-30 09:48:58 WARNING cleanup.py:59 [alice] --  Failed to send ObjectRef(a065fb8bd22ea3590383978a671b27fc48c56da00100000001000000) with error: ray::SendProxyActor.send() (pid=115377, ip=<IP_ADDRESS>, repr=<fed.barriers.SendProxyActor object at 0x7f9203729370>)
  At least one of the input arguments for this task could not be computed:
ray.exceptions.RayTaskError: ray::_spu_compile() (pid=108703, ip=<IP_ADDRESS>)
  File "/root/project/secretflow/device/device/spu.py", line 1377, in _spu_compile
    executable, output_tree = spu_fe.compile(
  File "/root/miniconda3/lib/python3.8/site-packages/spu/utils/frontend.py", line 148, in compile
    ir_text, output = _jax_compilation(
  File "/root/miniconda3/lib/python3.8/site-packages/cachetools/__init__.py", line 737, in wrapper
    v = func(*args, **kwargs)
  File "/root/miniconda3/lib/python3.8/site-packages/spu/utils/frontend.py", line 75, in _jax_compilation
    cfn, output = jax.xla_computation(
  File "/root/miniconda3/lib/python3.8/site-packages/jax/_src/traceback_util.py", line 166, in reraise_with_filtered_traceback
    return fun(*args, **kwargs)
  File "/root/miniconda3/lib/python3.8/site-packages/jax/_src/api.py", line 555, in computation_maker
    lowering_result = mlir.lower_jaxpr_to_module(
  File "/root/miniconda3/lib/python3.8/site-packages/jax/_src/interpreters/mlir.py", line 646, in lower_jaxpr_to_module
    raise ValueError(f"Unknown platform {platform}")
jax._src.traceback_util.UnfilteredStackTrace: ValueError: Unknown platform interpreter

The stack trace below excludes JAX-internal frames.
The preceding is the original exception that occurred, unmodified.

Reproduction code to reproduce the issue.
spu(func)()

Will be fixed in next release.
Meanwhile, please use jax&jaxlib <= 0.4.12


Investigate a transition of Mod Workflow to the Spring Way

Currently Mod Workflow is implemented in our own spring-module-core. In FOLIO most exisitng spring modules have been implemented using the EBSCO spring-way implemenation of spring: https://dev.folio.org/guides/spring-way/
We should identify what would need to be done to transition Mod Camunda to using the spring-way approach.

see also: https://github.com/TAMULib/mod-camunda/issues/218
Sizing might be treated as part of linked issue if investigating both at the same time.


Provides information on how to start postgresql

Adds the command to start postgresql from command line

Thank you for the PR! However I think this command is mostly relevant to Linux systems. It would also be more logical - IMO - to have this detail in "part-0".

Is this actually needed?  On Debian, the policy is that after installing a package that provides a daemon, the configuration is all set up to make the daemon start without admin/user intervention.  Is that policy changed by Ubuntu?


Preserve Client IP Setup - 400 error

I have followed the excellent advice in this previous thread:
https://github.com/vitobotta/hetzner-k3s/issues/13
I have my load balancer setup and running using Kong rather than Nginx for the ingress.  When I try to hit my domain, I get a SSL_PROTOCOL_ERROR.  I have cert-manager running and can see the generated certificate and the relevant annotations in the ingress.
If I look in the proxy log for my pod (deployment) I see that it does indeed have the client IP address but is returning a 400 response.
<IP_ADDRESS> - - [22/Aug/2023:19:28:45 +0000] "PROXY TCP4 MY_IP_ADDRESS LOAD_BALANCER_PUBLIC_IP_ADDRESS 61975 443" 400 12 "-" "-"
Does this look familiar to anyone, has anyone had a similar problem?  My K8S environment was all working fine without the proxy protocol enabled.

Hi, I am converting this to a discussion since it's not an issue with my tool.
If you enabled the proxy protocol in the load balancer annotations, then you also need to enable it in Kong, otherwise the ingress won't be able to "understand" the traffic coming from the load balancer.
See https://docs.konghq.com/kubernetes-ingress-controller/latest/guides/preserve-client-ip


Discover poster with title

radarr space-grey
text not readable

my fix
/* Movie Title in discover */
.AddListMoviePoster-title-2qKvg{
	font-size: 13px;
	font-weight: bold;
	background-color: rgba(0, 0, 0, .7);
}

Thanks for the issue, should be good now.


Game Freezes and then closes as Game session start approaches 0-0.030 seconds The server says Socket lost, deleting handle

General information
Project issue is for:
Logs
(Edit) EFT version <IP_ADDRESS>.32291
Expected result:
I've been trying to get into my first raid
(New install as I got the same issue after messing a few of the files editing server values)
Actual result:
as the timer counts down the game freezes as I reach 0-0.030 seconds and then closes. The server says Socket lost, deleting handle
How to reproduce

Copied live game files apart from battle eye (Just now tested with)
Extracted BE with 7zip
Started server then launcher
Made Fresh EOD/Unheard account
First raid into Ground Zero
Game closes

Attachments

server-2024-09-06.log (184 KiB)
LogOutput.log (11 KiB)
2024.09.06_6-02-46_<IP_ADDRESS>.32291 traces.log (53 KiB)
66da958600024483c05fd84c.json (123 KiB)

Originally written by Kiwi_Ninja

I made a fresh unheard bear profile, loading into GZ and did not crash, do i need any additional steps to reproduce this crash?

Originally written by chomp

No, I quite literally paste in eft files apart from battle eye and then extract the BE files via 7zip and I play

Originally written by Kiwi_Ninja


Update Listing.Item.Sku.Quantity to string to support big.Int

Sku.Quantity is used to track the amount of coins available for sale in a cryptocurrency listing. This needs to be updated to string to support big.Ints for ETH-related sales.
May be related to #1746

Sku.Quantity is used to track the amount of coins available for sale in a cryptocurrency listing.

If I'm not mistaken it's also used to track inventory for non-crypto listings whether the listing has variants or not.
Is it correct that now bigQuantity should be used for all inventory, crypto currency or otherwise?

@rmisio Yes, that's right. If you see cases with the listing shows values in the legacy keys, please let me know.


ReCaptcha Proxy: True

After looking through the code, it appears all this means is that the request is made through the proxy, but 2captcha for instance, allows you to give them a proxy which they will solve the captcha from. Is/will that be supported? I'd be happy to submit a PR, at least for 2captcha, I don't have much experience with the other APIs.
https://2captcha.com/newapi-recaptcha-en

Yea ill be overhauling the reCaptcha shortly im just waiting on anticaptcha to add some changes in there code.
this is actually a dupe of #126

My bad, great to hear though!


[MOB-1974] in app display pause

We need to add one more test

When display is paused and then resumed ensure that the message which was shown earlier is now shown.
I think this test will fail.


Add cml data explorer

Add interactive CML data explorer example, see #28
TODO
related to sandbox repo:

[x] update env repo
[x] add submodule to conda

related to changes required in cml_data_explorer code:

[ ] add map tiles to dynamic CML map
[x] add datashading to time series plots to allow fast plotting of large time series
[ ] add link to data explorer notebook to index notebook

Info on what a local conda develop cml_data_explorer/ produced
/Users/chwala-c/mambaforge/lib/python3.8/site-packages/requests/__init__.py:102: RequestsDependencyWarning: urllib3 (1.26.8) or chardet (5.0.0)/charset_normalizer (2.0.12) doesn't match a supported version!
  warnings.warn("urllib3 ({}) or chardet ({})/charset_normalizer ({}) doesn't match a supported "
added /Users/chwala-c/code/OPENSENSE_sandbox/cml_data_explorer
completed operation for: /Users/chwala-c/code/OPENSENSE_sandbox/cml_data_explorer

Datashading for time serie added in https://github.com/cchwala/cml_data_explorer/commit/a2b5777529a899e82c0adb9ddf9025bdfea12bc0

note: have to add datashader to env

I am still fighting the problems of running out of memory on binder when working with the OpenMRG dataset. Since its NetCDF is not chunked one cannot quickly iterate through the CMLs. Loading all data into RAM is not an option on binder.
I now explored the option to write data from the original NetCDF piece by piece into a chunked zarr store (because zarr is fast and appending to an existing store is easy) with this code
N_slice_length = 50

for i in range(0, len(ds.cml_id), N_slice_length):
    print(f'indexing data for CML_ID index from {i} to {i + N_slice_length}')
    ids = ds.cml_id.isel(cml_id=slice(i, i + N_slice_length))
    print(f'covered CML_IDs range from {ids[0].values} to {ids[-1].values}')
    print('loading data... (this will take appox. 10 to 20 seconds)')
    ds_subset = ds.isel(cml_id=slice(i, i + N_slice_length)).load()
    ds_subset = ds_subset.chunk({'cml_id': 1})
    ds_subset.rsl.attrs.pop('missing_value')
    ds_subset.tsl.attrs.pop('missing_value')
    ds_subset.polarization.attrs.pop('missing_value')
    if i==0:
        ds_subset.to_zarr('foo.zarr')
    else:
        ds_subset.to_zarr('foo.zarr', append_dim='cml_id')
    del ds_subset
    print('')

This works fine and takes only some minutes. Afterwards one can open the zarr storage and work with a Dataset chunked by cml_id on disk an via dask.
However, when doing computations, I still run into problems. Calculations are still slow

And doing things like
ds['tl'] = ds.tsl - ds.rsl

which would speed up plotting, will make binder run out of memory.
But I think I can now come up with a somehow usable solution.

todo: add zarr to env definition in env repo

For the record, because I have been dealing with killed kernel due to memory consumptions in this issue and others have also experienced the same thing (see #37), here is a link to an article
Detecting CPU and RAM limits on mybinder.org
The problem seems to be the one is restricted to 1 CPU and limited RAM in a binder pod, but when requesting info on the available resources one, get's what is physically available on the machine that hosts the pod. Hence, calculations or plotting will cause OOM kills (OOM = out of memory) because Python (or the used packages) think that they can comfortably increase memory usage further, but then the kernel dies e.g. at 2 GB RAM usage.

notebook works with current commit on binder.


Deadpendency thinks "-r <requirements.txt>" in Python requirements.txt files is a dependency

Expected Behavior
We have Python requirements files that include other requirements files with "-r <requirements.txt>". Deadpendency should resolve the inclusion of the other requirements file and proceed normally and not include "-r" as package in the report.
Current Behavior
Deadpendency seems to work properly, but also shows this in the report:

Failed To Analyze 😞
Python
Package was missing from the registry
-r

Example Of Issue / Steps To Reproduce
Example of issue: https://github.com/ICTU/quality-time/pull/2903/checks?check_run_id=4296945837
Example requirements.txt file: https://github.com/ICTU/quality-time/blob/master/components/collector/requirements-dev.txt

Thanks for report! Sorry for the issue, I'm surprised I missed this haha :sweat_smile:
Anyway, I'm optimistically closing. Please re-open if you see more issues around this.


Found a bug

I am Chinese,English is bad.
Press exhaled BubbleActions, when the animation has not been completed, the finger off the screen quickly. Pages will be stuck, BubbleActions can not hide. Appear absolutely
长按呼出BubbleActions ，当animation没有执行完毕的时候，手指快速离开屏幕。页面会卡住，BubbleActions 不能隐藏。百分之百出现

Was this experienced on the sample app?


WIP: remove deprecated only/except clauses

changes somewhat broken/deprecated only and accept keys to not very readable rules. The upside is without only, DAGs will be accessible.

Note: check which set of rules are used by build-macos-subkey: job now


AccordianItem header slot not updating when open or after closing

Describe the bug
Forgive me but this maybe due to my lack of experience or knowledge here.
I have an AccordianItem in which i pass a string value to the header slot.
This string value is based upon an underlying array's length.
The string value is a reactive declaration.
When the Accordian is closed the value of the string in the header slot updates when the array length changes.
However when I open the Accordian and remove items from the array, the header value does not change. When I close the Accordian the header value does not change or update. If i navigate away to another page and then back, the header value is now correct.
What am I missing here?
Reproduction
Because I am unsure if this is a me issue or a flowbite issue I have not tried to replicate it.
Flowbite version and System Info
System:
    OS: Windows 10 10.0.19045
    CPU: (16) x64 11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz
    Memory: 5.32 GB / 15.73 GB
  Binaries:
    Node: 18.15.0 - C:\Program Files\nodejs\node.EXE
    npm: 9.5.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (115.0.1901.188)
    Internet Explorer: 11.0.19041.1566

I close the issue for now since we do not have enough information.
Thank you for your contribution.
Please feel free to open a new issue when you are clear about the problem.


Update Paradigm's RWBY TTRPG.html to V1.4 New Feature

Updated to V1.4 of ruleset
Added Aegis under Ranged/Melee Modifications.
Added Aegis to Ranged Weapon Form Dropdown
Removed Gyrostabilizers.

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[x] I have followed the Character Sheets Standards when building this sheet.

[ ] This sheet has been made on behalf of, or by, the game's publisher.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[x] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Updated to V1.4 of ruleset
Added Aegis under Ranged/Melee Modifications.
Added Aegis to Ranged Weapon Form Dropdown
Removed Gyrostabilizers.

Character Sheet Info Roll20 Internal Use only.


Some corrections

Solve typos and add linux-headers in doc for Arch Linux

Thank you,
Please review CONTRIBUTING.md

My name is Patrick José Pereira and I agree to the terms of the Intel® RealSense™ Cross Platform API CLA.


Rename READMEuk.md to READMEua.md

using uk sound like United Kingdom
Using ua is because Ukraine domain extension is .ua

The code for the country is ua, but for the language it's uk.

uk could be interpreted as United Kingdom. US & UK have different spelling so US English and UK English is different


Regarding Incremental/Continual Learning using Ktrain for DL/TL

Hello,
It is said that DL/TL models and architectures are incremental or continual in nature because they learn from the mini-batches concept of gradient descent.
My query was:
What is the method within Ktrain where I can continuously update the model with newer incoming data and train on top of what it has already learned?
Example:
Model A is trained on 1000 samples and is in action. Later, I want to update the model (not from scratch) by training it with 500 more samples. And continue with this procedure of model updates.
It would be great if you could help me on this.
Thanks.

Hello:  See this FAQ entry. Thanks.

Hello:  See this FAQ entry. Thanks.

Sure,
Thanks.

Sure,
Thanks.


Update README.md

Related Issue
Closes: #20
Description of Changes
Updated the README file to provide clear instructions for contributing to the WHILE project.
Added a more appealing and visually attractive layout to the README by aligning the badges and logo in the center.
Added relevant emojis to enhance the visual appeal and engagement of the README.
Included badges to display project statistics such as repository size, open/closed issues, forks, pull requests, stars, last commit, commit activity, and total commits.
Updated the "How to Start Contributing" section to provide more detailed and comprehensive steps for contributing to the project.
Added a "Feedback" section to encourage users to provide feedback and suggestions for improvement.
Checklist:

[- ] My code follows the style guidelines of this project.
[-] I have conducted a self-review of my code.
[- ] I have included comments in areas that may be difficult to understand.
[ -] I have made corresponding updates to the project documentation.
[- ] My changes have not introduced any new warnings.

Screen shots

@vermaanurag1532 please see the change and  make it under GSSOC before the merge
thank you


add new roles - Update assign-ediscovery-permissions.md

Category

[x] Content fix
[ ] New article
[ ] Example checked item (delete this line)

Related issues

fixes https://github.com/MicrosoftDocs/microsoft-365-docs/issues/2033

What's in this Pull Request?

Update the new role called "communication" &  "custodian"are added to eDiscovery permissions.
Remove the role called "Search And Purge"

@PrasadKasireddy I have already addressed github issue 2033 in the private repo. Also, not sure why your removed search and purge role from this topic.

@PrasadKasireddy I have already addressed github issue 2033 in the private repo. Also, not sure why your removed search and purge role from this topic.

@markjjo  - I do not see any role name as search and purge role


Cosmos: query_items_change_feed reture same resualt with is_start_from_beginning parameters

Package Name:  azure-cosmos
Package Version: 4.0.0
Operating System: Linux
Python Version: 3.5.3

Describe the bug
query_items_change_feed fucntion return the same result with the parameter is_start_from_beginning=True and False
To Reproduce
Steps to reproduce the behavior:
python -m venv venv
source venv/bin/activate
pip install azure-cosmos==4.0.0

Query
client = cosmos_client.CosmosClient(HOST, {'masterKey': MASTER_KEY})
container = client.get_database_client(DATABASE_ID).get_container_client(CONTAINER_ID)
container.query_items_change_feed(is_start_from_beginning=True)
# with is_start_from_beginning=false
container.query_items_change_feed()

Expected behavior
Read the change feed from the last checkpoint, tried with the parameter continunation, did not find the sample to fetch the continunation token.

Thanks @nonokangwei - I will try to repro today :)

Hi @nonokangwei - I put together some sample code based on our tests demonstrating the continuation support that is hopefully helpful:
document_definition = {'pk': 'pk', 'id':'doc1'}
collection.create_item(body=document_definition)

query_iterable = created_collection.query_items_change_feed(
    partition_key_range_id=pkRangeId,
    is_start_from_beginning=True,
)
iter_list = list(query_iterable)
self.assertEqual(len(iter_list), 1)

continuation = collection.client_connection.last_response_headers['etag']

# Create two new documents. Verify that change feed contains the 2 new documents
document_definition = {'pk': 'pk', 'id': 'doc2'}
collection.create_item(body=document_definition)
document_definition = {'pk': 'pk', 'id': 'doc3'}
collection.create_item(body=document_definition)

# verify iterator
 query_iterable = created_collection.query_items_change_feed(
    partition_key_range_id=pkRangeId,
    continuation=continuation,
    max_item_count=pageSize
)

Here is the actual test with more detail:
https://github.com/Azure/azure-sdk-for-python/blob/master/sdk/cosmos/azure-cosmos/test/test_query.py#L50
As for the behaviour of is_start_from_beginning - @southpolesteve could you please weigh in with regards to the expected service behaviour of this options as presenting in the OP snippet?

@nonokangwei Is this a partitioned collection? You'll need to pass the partition key range id as the example above
@annatisch Thanks for investigating. The API is a bit strange here. Partition Key Range ID is an integer representing the physical partition that a logical partition key maps to. But it's not something we normally expose to the user. I don't see any methods in the SDK that let a user convert a partition key to a partition key range id. This might just be a bug. Instead the SDK will need to accept the partition key and set that as the header. This is what JS does and forces the user to supply the partition key: https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/cosmosdb/cosmos/samples/ChangeFeed.ts#L73-L78

@annatisch @southpolesteve i do some test based on the @annatisch sample code, if i do not give the partition key range id  paramterer it seems not works. as @southpolesteve said i review the SDK, it seems no function for customer to get the partition key range id.  So what is the suggested method to get the partition key range id, i only saw the description in rest-api interface.

Relabeling this as a bug. Partition Key Range Id shouldn't be exposed here. We should instead be accepting a partition key and change feed is scoped to a single partition key value. Cross partition change feed is something we would eventually like to support, but it requires some additional work.

@srinathnarayanan Can you look into this issue?

Fixed with https://github.com/Azure/azure-sdk-for-python/pull/13857
We now expose partitionKey param in the query_items_change_feed API (can be passed as a named parameter)


Visibility of icons in the input

Problem
The icons present in various inputs are not that well visible in dark mode (looks good on light mode)
* here:

$, Ξ here:

and # in byte input
Solution
Change the css class to text-gray-400 this will make the icons perfectly visible on both dark and light mode

Solved by #320


You wanna use Novel.id?
A class's attribute?
How would ever a class attribute be associated with any instance?


Delay the request size calculation until required by the indexing pressure framework

Description
Delay the ramBytesUsed computation for Indexing requests on the coordinator until reached a point, where absolutely necessary for IndexingPressure or ShardIndexingPressure.
Issues Resolved
This optimises the additional request size calculation, which otherwise would have been no-op. See (#1560)
The ramBytesUsed computations are done repeatedly at multiple places (replica, primary and coordinator), and are present even in the older version of IndexingPressure. Here in OS1.2 for every request overhead would be the request size computations for the number of documents in the batch. Given that this call has neither showed up in any CPU profiling data and was neither was called out as regression when first added in the indexing path during 7.9 release, this might not be the smoking gun, however this definitely optimises it down further.

Thank you @nknize for taking the look. I have updated the PR and added some java doc too.

stale PR. Reinvoking gradle check

start gradle check


Pass delete[] explicitely to Nan::NewBuffer.

Use the Nan::NewBuffer version that accepts an explicit callback
deallocating buffers. This way we'll be resilient to different nan/node
versions.
Fixes grpc/grpc#4867

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

This is ok to test.


Create pvlib.iotools.read_panond for reading .pan and .ond files

[x] Closes #1747
[x] I am familiar with the contributing guidelines
[x] Tests added - I tried to add something but was having difficulty finding where to store test files to read.
[x] Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
[x] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
[x] Pull request is nearly complete and ready for detailed review.
[x] Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

First time contributing. So, I may need some extra assistance. I filled out the checklist as best as I could but have left comments where I need some guidance. Please assist with the code documentation, whatsnew comments and setting up appropriate test document.
Proposed change is to add a reader and parser function for .pan and .ond files for the #1747 topic. the reader takes a filepath and creates a nested dictionary from the file contents. I am more than happy to address any concerns in the methods I chose.

Thanks @ckrening!  A few initial high-level comments:

It will be much easier to review the code after the automated "stickler" comments are resolved: https://github.com/pvlib/pvlib-python/pull/1749/files.  See here for explanations of the codes: https://www.flake8rules.com/
I think it might make more sense to name the file pvsyst.py instead of panond.py
Data files for testing should live in pvlib/data: https://github.com/pvlib/pvlib-python/tree/main/pvlib/data

I think it might make more sense to name the file pvsyst.py instead of panond.py

Other energy modeling software also accepts pan/ond, so I'm not so sure that we should tie the pvsyst name to the format. PV*SOL documentation contains this interesting tidbit

The file extension PAN has its origin in the French name for solar panel: Panneau solaire. The format was introduced by the simulation software PVSyst and has become internationally accepted as an exchange format for solar modules.

In the long run I'd like to see a set of DataClasses, but I'm good with nested dictionaries in this PR.

Thanks @kandersolar. I made the stickler corrections and updated testing docs.
The only thing on the checklist I am not sure I conform to are the Maintainer: Appropriate GitHub labels.
Finally, I decided to stick with the panond name for the reasons outlined by @wholmgren. I am not attached to panond as a name and it can easily be changed. It's more important to me that the functionality is included.

What else could go into this module in the future?  That could influence the name.

In iotools we've established a pattern of naming the module for the data source, rather than for the type of data being read. For this reason I'm OK with panond. I don't think it's difficult to move the functions to a new module later should we come up with a better name.
About other data sources, I'll note that SAM can write inputs and model configurations to JSON files.

@ckrening is this ready to run tests?

@cwhanse the code is ready to run tests. I have included one sample .pan and .ond.

@cwhanse Are there further steps I should take to get this approved? I have left the file name as-is, I have no issues with changing it, if desired, but it seems like there are merits to both changing/keeping it, and it is secondary to my goal of contributing to the library.

@ckrening this is a bit different from the other parts of pvlib.iotools, most of which are testing files retrieved via an API, and thus test failure indicates a change in the API that affects pvlib. Here we're only testing that we can read a static file.
@AdamRJensen do you think these tests enough for a first capability?

Here are some testing ideas:

check for the presence of certain keys in the dict
check for the values and types of some values in the dict
parse the example from the notes and compare to your expected dict structure and content

Do we need some kind of disclaimer in the docstring, considering this quote from a discussion on google groups?

I have already sent an email regarding these questions, but I received a response stating: "The OND file is meant for the internal use of Pvsyst. We do not provide support regarding its contents."

Hi @cwhanse, I resolved the merge conflicts. I think we are ready to roll (finally). :)

Is this feature planned to get merged in the next release ?

Good to hear! If @ckrening does not push it, I will be happy to implement the items :)

@kandersolar regarding the 'End of...' keys in the dictionary, my goal was to modify the file as little as possible. So, I decided to keep those in the dictionary, in the event someone had a use for them. Though I agree, I cannot think of a great use for them.

I did a bit of doc cleanup and test improvements.  I think this is ready to go but I think another review from someone else is warranted.  @AdamRJensen and/or @cwhanse?

Thanks @ckrening !

Probably should have added a mention of this new function in the FAQ concerning PAN/OND files.
@kandersolar Should I open a new PR or do you want to reopen this PR?

This PR did edit that FAQ entry :) check latest


ReceivedNotification add intendedTime function

Is your feature request related to a problem? Please describe.
I am getting a new notification and with it ReceivedNotification object and I want to know for what time it was intended to appear.
Saw 2 similar methods that retrieve DateTime objects but I think they don't do what I am searching for.
We have createdDate which is the date the notification got created for the first time (not intended to be displayed),
we have displayedDate which I am imagining could be different time then the intended date if the device was off when the notification was supposed to arrive.
Describe the solution you'd like
A function named intendedTime retrieved the original time the notification was planned for.
Describe alternatives you've considered
Saving this time with some local database like shared preference.

Unfortunately, its not possible to get the exact time when a notification is displayed on iOS devices because isn't possible to execute any code at this moment. On Android the displayedDate behaves exactly as you described, but on iOS due this limitation this value is calculated, and may not match with the exact time when it happened as you described.

intendedTime  != firedTime
So the iOS limitation does not affect this value as it is pre-known when the notification got created.
Currently I am adding it manually to the payload

Now i got it. This can be trick to implement on iOS. I will need to study how to do it in near future. So, for now i will let this opened as a future implementation on roadmap.

Because i cant execute code to update these values between each app execution. So, if for example has passed 3  notifications displayed times and the app goes back to live, i gonna need to calculate these respective values and i need to ensure the correct one. And the same thing is valid for Android, where i need to be very efficient at background execution and the background execution also can be denied.

This is not true. I can have one created event and unlimited displayed events, each one with a different date.

I think we are talking about 2 different values.
This is what I think about it, tell me if it is the same
Created date = the date the notification got created. This date is always in the past.
Intended time = the date the notification should arrive. The intended date the notification should trigger
Fired time = the actual time the notification got triggered and got showed to the user. Probably will be hard to extract in ios since it is problematic to run code in the background
The first 2 "Created date" and "Intended time" never change and is pre-known.
I talked about only the first 2.

The first 2 "Created date" and "Intended time" never change and is pre-known. I talked about only the first 2.

No, its not. The displayed date is calculated by OS and its not pre-known. I gonna need to calculate it for every event delivered to onDisplayMethod.

.

.

.


flutter-client fails to start Dart VM HTTP Service

Hi,
I've built the debug wayland recipes using meta-flutter and can run flutter apps in debug mode.
Whenever I start a flutter app (by using flutter-client -b /path/to/bundle) I get the following error
flutter: Could not start Dart VM service HTTP server:
SocketException: Failed to create server socket (OS Error: Cannot assign requested address, errno = 99), address = <IP_ADDRESS>, port = 0
#0      _NativeSocket.bind (dart:io-patch/socket_patch.dart:996:7)
<asynchronous suspension>
#1      Server.startup.startServer (dart:vmservice_io/vmservice_server.dart:424:19)
<asynchronous suspension>
#2      Server.startup (dart:vmservice_io/vmservice_server.dart:443:11)
<asynchronous suspension>

and subsequently I am unable to attach the debugger.
This also fails when using flutter custom-devices on a host machine to try and debug (same error).
Why would this be, is there a way to see a more verbose log?
Thanks

Are you using docker? If yes, does this issue help you?

Unfortunately not - I'm running it on some embedded hardware where I added meta-flutter to the yocto build process.

Sorry, I can't debug any further as I don't know your environment. Are you using flutter-elinux?

The bundle was created with flutter build bundle with the standard flutter tool.
After these errors the application does run as expected - there is just no way to debug it.
Could you let me know what details you need to know about the environment? It's a custom board with an iMX6.
Thanks

Are you trying to attach your flutter app from your host PC or just launching it on arm64 devices?

After these errors the application does run as expected - there is just no way to debug it.

I think that the settings related to the network/port of the device you are using are affecting the error.

Do you know where could I find more verbose logs?
The logs in my first post are the output of flutter-client -f -b /path/to/bundle. Does flutter-client or the flutter engine output any other logs, I couldn't find any in /var/logs.
My steps were:

Add meta-flutter to my yocto distro and building in debug mode
Upload the image to the device
Add the device with flutter custom-devices with the flutter SDK (3.0.5)

for the command I launch it with XDG_RUNTIME_DIR=/tmp/-runtime-dir flutter-client -f -b /tmp/${appName}

I get the error in the log about being unable to create the server socket.

I'm using dropbear for SSH access instead of OpenSSH, could this be why?

Add the device with flutter custom-devices with the flutter SDK (3.0.5)

Why are you using the official flutter SDK? Could you try using flutter-elinux once?

Closing as no update for a while.


[todo] Activity indicator in the header

The idea is to show to the users that something in background is happening and create a feeling of engagement.
[todo] write more info

Probably a duplicate of: https://github.com/basicrum/backoffice/issues/69


protocol: api to register schemes that can handle service worker

https://github.com/atom/electron/issues/2831 is now completely addressed. Have enabled service worker for file scheme by default. For privileged custom schemes users can use the api.

:+1:


Builtin function to end Insert mode completion

Is your feature request about something that is currently impossible or hard to do? Please describe the problem.
Calling complete() can start Insert mode completion, but there is no builtin function to end Insert mode completion. Calling complete(some_column, []) closes the popup menu, but doesn't end Insert mode completion. One has to press CTRL-E twice to insert the character below the cursor in this case.
Describe the solution you'd like
A builtin function to end Insert mode completion.
Describe alternatives you've considered
A command to end Insert mode completion can also be helpful (to be called from a script), but I can't find an existing one either.

A command to end Insert mode completion can also be helpful, but I can't find an existing one either.

Not sure this is what you're looking for, but there is :help :stopinsert.

A command to end Insert mode completion can also be helpful, but I can't find an existing one either.

Not sure this is what you're looking for, but there is :help :stopinsert.

That's stopping Insert mode, not stopping Insert mode completion.

I just found out the following can achieve this purpose:
if mode(1) ==# 'ic'
  feedkeys("\<C-E>", 'n')
endif

Reopened: feedkeys doesn't work in some circumstances, e.g. when i_CTRL-V is waiting for a key.

Maybe the feedkeys() workaround could be improved, but without any actual code, it's hard to make any test.

How do you start the completion?  A mapping, an autocmd, a user command, ...?
How do you want to end the completion?

Reopened: feedkeys doesn't work in some circumstances.

Which circumstances exactly?
Post some real code showing exactly what happens currently, and what you would want to happen if the requested function existed.
Here is a start where feedkeys() works:
vim9script
inoremap <F5> <C-R>=g:ListMonths()<CR>
inoremap <F3> <Cmd>call <SID>EndInsCompletion()<CR>
def EndInsCompletion()
    feedkeys("\<C-E>", 'n')
enddef
def g:ListMonths(): string
  ['', 'the quick brown fox jumps over the lazy dog']->setline(1)
  complete(col('.'), ['January', 'February', 'March',
        'April', 'May', 'June', 'July', 'August', 'September',
        'October', 'November', 'December'])
  return ''
enddef
feedkeys("i\<F5>\<F3>")

Try to adapt it or create another snippet showing how it fails.

I guess I'll just close this since the problems is only specific to a very complicated Neovim-only plugin.

Ah, I think what I actually wanted is to stop completion without changing the match, and I guess currently there is no way to do that without inserting any extra characters. I'll open another issue later.

what I actually wanted is to stop completion without changing the match

:help complete_CTRL-Y

what I actually wanted is to stop completion without changing the match

:help complete_CTRL-Y

CTRL-Y inserts the whole match. I actually want this behavior, but without the "insert the typed character":
Any non-special character:
		  Stop completion without changing the match and insert the
		  typed character.

I'll wait for #8793 first.

Ah, feedkeys("\<C-G>\<C-G>", 'n') still has a problem: it doesn't trigger CompleteDone immediately. Changing 'n' to 'ni' doesn't trigger CompleteDone immediately either, and adding x doesn't stop completion at all.
Example:

Run vim --clean
Create autocommand :autocmd CompleteDone * echomsg col('.')
Create mapping :inoremap <F2> <C-R>=feedkeys("\<C-G>\<C-G>", 'ni') + cursor(1, 10) ? '' : ''<CR>
Press keys i<Space>testtesttest<Home><C-X><C-V><F2><C-E><Esc>
:messages shows 10

In contrast:

Run vim --clean
Create autocommand :autocmd CompleteDone * echomsg col('.')
Create mapping :inoremap <F2> <C-G><C-G><C-R>cursor(1, 10) ? '' : ''<CR>
Press keys i<Space>testtesttest<Home><C-X><C-V><F2><C-E><Esc>
:messages shows 2

Try this:
autocmd CompleteDone * echomsg col('.')
inoremap <Plug>(exit-ins-compl) <C-G><C-G>
inoremap <Plug>(after-exit) <Cmd>call cursor(1, 10)<CR>
inoremap <F2> <C-R>=feedkeys("\<Plug>(exit-ins-compl)\<Plug>(after-exit)", 'i') ? '' : ''<CR>

Try this:
autocmd CompleteDone * echomsg col('.')
inoremap <Plug>(exit-ins-compl) <C-G><C-G>
inoremap <Plug>(after-exit) <Cmd>call cursor(1, 10)<CR>
inoremap <F2> <Cmd>call feedkeys("\<lt>Plug>(exit-ins-compl)\<lt>Plug>(after-exit)", 'i')<CR>

Ah, this seems to be a good solution.

Or this:
autocmd CompleteDone * echomsg col('.')
inoremap <Plug>(exit-ins-compl-and-move-cursor) <C-G><C-G><Cmd>call cursor(1, 10)<CR>
inoremap <F2> <Cmd>call feedkeys("\<lt>Plug>(exit-ins-compl-and-move-cursor)", 'i')<CR>

Thanks!

I have another idea: How about making complete() stop ins-completion when it accepts a negative starting column number? This is currently no-op.

I have another idea: How about making complete() stop
ins-completion when it accepts a negative starting column number?
This is currently no-op.

If we are going to add this to the code somehow, it's better to add a
new function.  Reusing an existing function with an exotic argument just
makes it obscure.
--
OLD WOMAN: King of the WHO?
ARTHUR:    The Britons.
OLD WOMAN: Who are the Britons?
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///


issue#1123 fix

Issue #1123 , added Suspense to show loading skeleton on every single search request.

I'm not sure if this is necessary, it already feels really fast when going between searches to me. What do you see?

I'm not sure if this is necessary, it already feels really fast when going between searches to me. What do you see?

When I try on slow internet, it doesn't feel juicy enough I think. With Suspense, it just 'feels' better

I have a similar issue on my project, where it takes 1 to 2 seconds before the search parameter is added to the address bar.

I have a similar issue on my project, where it takes 1 to 2 seconds before the search parameter is added to the address bar.

Can you also please try to use Suspense and share your experiences?

We'll likely move to this pattern: https://buildui.com/posts/instant-search-params-with-react-server-components


Add withdrawn logic for data_requests and remove volunteers_can_contact_requestor

Context

In Airtable, we had a check to indicate whether a data request was withdrawn.
Now, we still want users to be able to withdraw a data request
However, we (presumably) don't want users to be able to modify the Request Status column in data_requests (which indicates a multitude of other statuses we want to be able to control and not have the owner modify)
Additionally, remove volunteers_can_contact_requestor, which is no more!

Requirements

Remove volunteers_can_contact_requestor (so that it is no more)
Create a withdrawn column that the owner of a data request can modify
Develop database logic which updates the Request Status to Request withdrawn when this is marked True.
Create new permission for withdrawn column, allowing all users to view it, but only owners and admins to be able to edit it.

Tests

Validate that withdrawn column exists in schema.
Validate that volunteers_can_contact_requestor is no more.
Test that permissions are properly updated.
Test that trigger logic functions as expected.

Docs

Add descriptive comments for the column and trigger logic in the database.

Open questions

If they select withdrawn as true, do we want to immediately modify request_status as withdrawn? What if they want to un-withdraw it?
I assume we don't want them to modify request_status directly, since there are other request statuses we want to set things as for our personal uses we don't want them to be able to control, but let me know if this is incorrect.

ah, so users shouldn't be able to modify the status directly—but I would love to get this done without adding a property. I think there are ways to do it without adding a new property + still keeping the API CRUDlike / not adding an endpoint: https://chatgpt.com/share/f7093f06-94f6-4f3a-9987-97636cde57e9
and, remember: chat GPT is never wrong. 😈
Anyway, I'm sure there are plenty of other ways to do this so I'm not too picky about it. I think this will be a common theme, though—lots of actions could potentially impact an item's status.

@josh-chamberlain
After much thought and prayer over it, I can see some ways to do it while keeping it, er, CRUD-ish:

We can have the request status be modifiable only in this specific situation. We'll need to check on any updates whether request status is specified as one of the columns to modify, and whether the modification by the owner is to Request withdrawn (which they'll need to spell correctly).
We add a withdrawn parameter to the endpoint itself, which if true will ignore all other functionality and set it to Request withdrawn. Simpler for the user to do, and simpler logic for us, but definitely makes it less CRUDy
The PATCH method, which I've never used but is an option (and one I'd have to explore further).

What do you think?

@maxachis hmm, I like the second option. In the UI, this would be on a straightforward path: the appropriate users could see a "withdraw request" button, and clicking it would hit the endpoint correctly (spelled right, checking permissions).
Even for API users—I see an UPDATE endpoint which accepts a status property. I make API calls to try to modify the status, and the app deals with me as it sees fit, sending a "you don't have permissions" message if necessary. We also have a wee table in the docs which might lead me to expect I cannot update the status. We could choose to make this reversible. It has the advantage of being a standard API design, which is user-friendly.
This is conceptually much simpler, and feels more like building a structure with 2x2 lego bricks rather than those super-special + unique pieces that aren't as transferable to other use cases. No matter what, we have to check to see if the user has the appropriate permissions—so we might as well structure things in a basic way.

@maxachis After doing some soul-searching of my own, I think it's OK to have a whole endpoint with the specific function of updating a specific property, which hopefully makes permissions simpler. We shouldn't need to do too much of this, and can have broader endpoints for editing broader ranges of properties, but I think an endpoint called "withdraw-request" in the "requests" namespace is user-friendly and makes perfect sense! I was overthinking it before.

Got it! Issue is updated!


HIVE-26016: Remove duplicate table exists check in create_table_core api of HMSHandler

What changes were proposed in this pull request?
Currently the create_table_core api will check if table exists twice, we can remove the second check.
Why are the changes needed?
For code improvement.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Just remove duplicated code, no additional tests are introduced.

@rbalamohan @pvary : Could you pls review this PR?


What do we mean by reusing software?

Some nice links of different options for reuse. I think it would be useful to link it in the guide.
http://sites.computer.org/debull/A18mar/A18MAR-CD.pdf#page=17
https://drops.dagstuhl.de/opus/volltexte/2016/5817/pdf/dagrep_v006_i001_p108_s16041.pdf#page=23

I like it! This PRIMAD model seems very useful to specify exactly what we mean and hence to better and more clearly determine our priorities and describe our achievements in projects.

Yes, I agree. The Turing Way already include a table of definitions for reproducible and replicable, which is not quite as detailed as the links above. I'll see if I can convince them of including extendable and modifiable in their table.

Those models in the links seem to be limited to computational models and data processing scripts. That's mostly our scope, but for the occasional mishap where we end up developing a library or other such generic component, we may need something else as well.

Possibly. I feel that: "Modifiable. We say an experiment is modifiable if we can change its implementation for reuse purposes, and this is achievable by having the source code of the experiment." could apply to a library. In any case, would be good to have your input when we start working on extending this chapter in the Turing Way.

Hmm, in my opinion thinking of libraries as chunks of code that you download and modify to suit your needs is a recipe for disaster, but I'm an engineer. I've certainly met scientists who thought that it was a good idea, so maybe it should be in the Guide or Way.


add multiAirline svg icon

Codecov Report

Merging #463 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #463   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          43     43
  Lines         398    398
=====================================
  Hits          398    398

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75a732b...c449f0a. Read the comment docs.

@wesleymartin85  - do you have input on this? Should this svg be updated, and if so are you able to format it to be more consistent with the others?

@jes708 - I updated the format of the svg thanks to @wesleymartin85


Update heatmaps.ipynb

small grammar fixes

Codecov Report

Merging #171 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #171   +/-   ##
=======================================
  Coverage   85.26%   85.26%
=======================================
  Files          23       23
  Lines        1473     1473
=======================================
  Hits         1256     1256
  Misses        217      217

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a9a70e...70ab08d. Read the comment docs.


fix: More YAML templates for E2E virt tests

Why the changes were made
Follow up for https://github.com/openshift/oadp-operator/pull/1359 to add more YAML templates.
~Blocked by https://github.com/openshift/oadp-operator/pull/1386~
How the changes were made
Studied code to find and remove "YAML literals" from it. Added feature to replace strings in code in templates.
How to test the changes made
If you have 4.14+ cluster, you can run E2E virt tests locally with make TEST_VIRT=true test-e2e
Check logs, they should not be less informative and readable as they were before this change.

I would say the following..  How the templates are constructed is NOT a big deal to me unless the templates are used in documentation in oadp-operator/docs.   I am happy with working templates and we shouldn't bike shed too much about it.
YAML templates are fine, we should have a little shell script that can populate and  render the templates.  Breaking out files into directories that make more sense is also fine.
Re the sample apps in our tests/e2e

should be good enough for our CI
a user should be able to manually use the sample apps with simple instructions
At the first pass of this work does NOT need to be perfect for all users.  We'll get there

@mrnold did not understand how would be @mpryc idea
we can document yes @weshayutin . This can be very useful for me in the future. Today (in IBM) I need to manually edit all snapclasses (because I do not use ceph), for example. This could be automated with templates (and not change how other people run make test-e2e
But seems we have some discussion, so we can focus on working here after 1.3.1 (unless @mrnold wants anything from here now)

/retest

/hold

@mateusoliveira43 thank you for putting up this change, it fell off my radar tbh.   I have strong opinions about this that should be tempered by a group discussion.   I'll raise it in thrs scrum for discussion.   I'd like Matthew to review in depth but he is focused on dataupload/datadown changes, this will have to wait a bit.

Created issue to discuss solution https://github.com/openshift/oadp-operator/issues/1531


accept optional start of column for rangeFromLineNumber

some of the linters provides an column of the reported line.
The helper should support this parameter to avoid refactoring of this lines on each linter plugin.

Can you also add a spec for it?

LGTM thanks!