KAFKA-17646: Fix flaky KafkaStreamsTest.testStateGlobalThreadClose

It's regarding KAFKA-17646.
Two issues found in the flaky test:

Racing between streams.close() and shutdownHelper() threads: Resolved it by moving the streams.close()  call after confirming the KafkaStreams state is in ERROR state.
Checking for short-lived PENDING_ERROR state: Resolved it by changing the assertion to check the log content State transition from RUNNING to PENDING_ERROR.

Put the verbose explanation under Jira comment.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@chia7712 Thanks for the review. I updated the PR as suggested.


Add env substitution for path

/override ci/prow/e2e-dpu-operator-tests

/hold

Do we need envsubst here?

I think that something simple like https://github.com/openshift/dpu-operator/pull/139 should be sufficient

/close


Add attributes to chunks

Issue #26 points out that constraints can have additional rationale information.  The potential need for rationale information can easily be seen to extend to other types of chunks, like assumptions.  Moreover, supporting information, like a detailed derivation could be an attribute of a theory, or general definition, or instance model.
@szymczdm , if my description above does not mirror the discussion we had in our group meeting (Thursday, October 26), please adjust it.  😄

Started this in commit e4f381f2d1becd2aa3ef2aa96feeb6916a0253ad, but I haven't had a chance to add some new instances yet. It's on my priority list.

@szymczdm Can you carefully what needs done? I think you've done the bulk of the infrastructure work, so that this can now be mostly be chopped up into smaller 'to dos' that can be parcelled out piecemeal (as it were).

Attributes exist throughout the infrastructure. Now it's just a matter of adding attributes to all of the appropriate data types that don't yet have them, and then updating the smart constructors to work with Attributes. This is definitely something that can (and will) be split up easily (which I'll do in the morning).

Is this now obsolete or is there still work to do in this regard? @szymczdm @JacquesCarette

Good catch - obsolete.  Closing.


Notify admin if developer changes status to indicate being hired

This is the first check in trying to track when a developer gets hired via the platform.
A PR addressing this issue should:

[ ] Send a new admin email/notification when a developer's status changes to indicate they may have been hired

Any of the following changes should trigger the notification:

A developer's search status changes from actively looking or open to not interested or invisible
An admin marking a developer as invisible (via the Invisibilize button) should not trigger the notification
A developer removing full-time employment from their selected role types

happy to jump in on this

Sure thing, all yours @benngarcia!

Closed via #401.


Secure the api endpoints

Describe the bug
This is an umbrella issue for all the issues that could be related to securing endpoints. For example, when creating a test the class id is passed in the POST Request but it isn't verified on the back end whether the user is the admin of the class or not. Therefore, anyone can create tests in any class. Similarly, in delete test endpoint as well it should be checked whether the user has delete privileges or not.
To Reproduce
Steps to reproduce the behavior:

Open the network tab on chrome or firefox before creating a test to log the POST request sent to the server.
Import this request in Postman.
Change the class field in the body of the request.
Returns a 200 Status Code and creates entry in database.

Expected behavior
Test creation should fail instead of creating it in another class.
Desktop (please complete the following information):

OS: Any
Browser: Any
Version: Any

Additional context
There are many other security issues in other end points as well.

Yes, we should create middlewares to check whether the user is created of that class

@atulya2109 are you willing to work on this issue?

@aavishkarmishra  Yeah, sure.

@aavishkarmishra The pull request was merged but my points weren't updated. Please look into it


"Skip Quest Next" and "Skip Quest End" not working properly

Since 15th August 2017, the "Skip Quest Next" feature outright stopped working, and "Skip Quest End" leads to a network error page. Additionally, the quantity of some items in Supplies also refuse to update in AnCheera, notably Damascus Crystals.

yeah also getting this problem


Cleaning Up illumos and Solaris OS Support

As discussed on #1514 this Issue serves as the basis to coordinate and design the future, proper Solaris support.
First a small primer. Both Illumos and Oracle Solaris are forks of the Original Sun OpenSolaris. Thus all versions named Solaris 11.x and Illumos come from a common ancestor. They have however diverged drastically enough that they are no longer Binary compatible. With the new golang 1.13 for example a new platform has been added for illumos because of that.
As to the questions from @svaarala from #1514
Q: What Solaris versions and variants are relevant (not just the latest, but something that might be still in use in practice)?
A: In illumos all distributions share a common upstream base repo named Illumos which is managed collaboratively by all distributions. A single Platform for Illumos is sufficient. For Oracle Solaris I think Solaris 11 and 10 are relevant still but it will be best if somebody more knowledgeable about this answers the Solaris side.
Q: What naming should be used for defines?
A: Illumos, Solaris11 and Solaris10 for version specific differences. Illumos and Solaris for differences between the Projects. SunStudio support can be skipped entirely. Illumos only provides SunStudio for backwards compatibility for those projects that have not yet ditched support.
Q: What headers should be used, and can a single set of headers work?
A: In this particular case sys/params.h is the matching headers. I have not checked if there are other cases yet.
I will ask around in the illumos irc if other people are willing to help you out with this. We have already good experiences with coordinating changes with the meson community.
Are there some projects that use your library that could be of interest for our community to run at home on their servers? That usually gives a nice boost in helpers for platform support.
I know of gerbera from #1514 do you know any other software like that?

Solaris 10 is supported until 2024, Solaris 11 through 2034 (but only the latest 11.x release, currently 11.4 - not older releases like 11.0 or 11.2).
It's been a few years since I tried, but I don't remember much problem building duktape on Solaris 11 - is there something specific needed beyond the fix from #1514?

(I'm following up as this link was posted on IRC.)
Solaris (whatever version) and illumos (all lowercase) should be handled separately as while illumos is OpenSolaris fork, there's no guarantee the choices we do for illumos will be the same done in Solaris.
Other than that, if there's something missing in illumos-gate that is required for duktape to build/run on illumos, please create a bug report in https://www.illumos.org/projects/illumos-gate/issues.

Thanks guys, I hope once this clears up we can have clear detection for all necessary variants. What's important for that is finding C preprocessor defines that are available before any headers are included. So hopefully one can reliably distinguish whatever variants are necessary that way.

I'll install OpenIndiana and see what defines are available. It seems the best first step is to add illumos detection, and then ensure the existing Solaris detection works for versions prior to that.

All the distros derived from SunOS (Solaris, OpenIndiana, OmniOS, Tribblix, etc.) should have __sun defined by the C & C++ compilers.  I don't remember if there's any #define to distinguish between Oracle Solaris and the illumos family though.

I now have an OpenIndiana VM, using gcc 6.5.0 (OpenIndiana 6.5.0-oi-2). I looked at the output of gcc -dM -E - < /dev/null | sort and at a glance it seems there is nothing to distinguish illumos specifically:

__sun 1
__sun__ 1
__SVR4 1
__svr4__ 1
__unix 1
__unix__ 1
sun 1
unix 1

Others seem pretty generic.
Is there some header that could be included (contingent on the shared Solaris defines and available in illumos and other variants too) that would provide some version / variant defines that could distinguish the platforms? Grepping around /usr/include I didn't find an obvious candidate:

Some internal headers check for _ILLUMOS_PRIVATE, not sure what defines it, and by its name it seems unsuitable.
sys/sysevent.h provides ILLUMOS_VENDOR "ILLUMOS" and a define ILLUMOS_KERN_PUB. Maybe the former might be workable if sys/sysevent.h is always safe to include.
Sidenote: some headers seem to check for __solaris__ and __SOLARIS__ which is not in the predefines list, these are probably for earlier versions.

Ultimately it would be possible to just require the application writer define something. There's one case of that in duk_config.h IIRC, but it's obviously very undesirable compared to automatic detection.
At present, assuming ast/endian.h is not required for byte order on any practical Solaris variant, the distinction between these variants is not necessary. But as pointed above, at some point it may be.

@Toasterson Regarding this comment https://github.com/svaarala/duktape/pull/1514#issuecomment-533431807:
I'm not sure I understand what you meant by:

The fact that it detects current Solaris and Illumos Systems as "Old" is definitely wrong.

So to clarify:
In master there is a "Solaris" platform detected based on DUK_F_SUN which in essence means __sun && __SVR4. Anything with these these gets the platform name "solaris" at present (and we'd like illumos based systems to distinguished, but that's a separate thing).
Within that detection, there is a hack for "old Solaris" without endian.h or stdint.h, detected by presence of __SUNPRO_C, and it gets some byteorder forcing etc. This should not match for at least illumos (based on a gcc predefs dump).
So, it's not the case that all Solaris variants detect as "old Solaris", they appear outward as "solaris".
Where this old Solaris hack came from I'm not fully sure, but probably someone working on these old Solaris targets has provided it or requested it (yes, some people work on way out of date platforms for various reasons :).

@svaarala I thought ast/endian.h got included because illumos was detected as old solaris. But I think that is more me not being fluent in C Preprocessor macros as it turns out. Thank you for clarifying.

__SUNPRO_C does not indicate a version of Solaris, but the use of the Sun/Oracle Studio compilers instead of gcc or clang.
<stdint.h> has been present on Solaris since the Solaris 10 release in 2005, so a version without it is truly old now.  The ast headers are really from ksh93, not the core Solaris/illumos OS.

__SUNPRO_C does not indicate a version of Solaris, but the use of the Sun/Oracle Studio compilers instead of gcc or clang.

I think it was used as a proxy to detect older versions (but I don't really know the exact intention), but I don't know if it is really appropriate.

Well it can work as a proxy due to the fact that Sun/Oracle Studio compilers are the only compilers present on older Solaris versions. But they could be also present on current illumos and Solaris boxes iirc. So it's a dirty hack at best.

Agreed.


move black to dev dependencies

Related Issues
https://github.com/koxudaxi/fastapi-code-generator/issues/60

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2e8d088). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #65   +/-   ##
=========================================
  Coverage          ?   94.44%
=========================================
  Files             ?        2
  Lines             ?      324
  Branches          ?        0
=========================================
  Hits              ?      306
  Misses            ?       18
  Partials          ?        0

Flag
Coverage Δ

unittests
94.44% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e8d088...3b98515. Read the comment docs.


Automated cherry pick of #11641

Cherry pick of #11641 on release-7.6.
/cc  @babinderrathi
NONE

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Trying to auto merge this PR.

Pull Request successfully merged
SHA: a09247962eba418fc6fc378e8fa168d1bcc6b675


IP To Nation, incorrect content heading

Description of the problem
Incorrect heading in documentation.
"Banning Counties" should be "Banning CountRies"
https://docs.expressionengine.com/latest/add-ons/ip-to-nation.html

Thanks @creativearc-paul!


⚠ Turnos 24x7 has degraded performance

In 68ae34e, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 830 ms

Resolved: Turnos 24x7 performance has improved in 0208684.


Fixed phaseogram bug when returning results to plot

Fixed phaseogram bug when returning results to plot

Hello @ricardovb! Thanks for submitting the PR.

In the file src/main/python/utils/dave_engine.py, following are the PEP8 issues :

Line 75:121: E501 line too long (132 > 120 characters)
Line 76:24: E111 indentation is not a multiple of four
Line 77:24: E111 indentation is not a multiple of four
Line 83:21: E265 block comment should start with '# '
Line 91:17: E265 block comment should start with '# '
Line 96:121: E501 line too long (123 > 120 characters)
Line 132:79: E222 multiple spaces after operator
Line 137:56: E226 missing whitespace around arithmetic operator
Line 137:121: E501 line too long (124 > 120 characters)
Line 138:85: E128 continuation line under-indented for visual indent
Line 139:85: E128 continuation line under-indented for visual indent
Line 154:55: E261 at least two spaces before inline comment
Line 156:48: E261 at least two spaces before inline comment
Line 159:5: E722 do not use bare except'
Line 205:5: E722 do not use bare except'
Line 228:21: E127 continuation line over-indented for visual indent
Line 229:21: E127 continuation line over-indented for visual indent
Line 277:59: E703 statement ends with a semicolon
Line 278:41: E262 inline comment should start with '# '
Line 279:37: E262 inline comment should start with '# '
Line 280:45: E262 inline comment should start with '# '
Line 281:121: E501 line too long (133 > 120 characters)
Line 286:63: E703 statement ends with a semicolon
Line 287:45: E262 inline comment should start with '# '
Line 288:41: E262 inline comment should start with '# '
Line 289:49: E262 inline comment should start with '# '
Line 290:121: E501 line too long (136 > 120 characters)
Line 291:13: E722 do not use bare except'
Line 298:66: E703 statement ends with a semicolon
Line 305:44: E226 missing whitespace around arithmetic operator
Line 306:46: E226 missing whitespace around arithmetic operator
Line 306:79: E261 at least two spaces before inline comment
Line 306:121: E501 line too long (164 > 120 characters)
Line 315:74: E703 statement ends with a semicolon
Line 340:5: E722 do not use bare except'
Line 346:50: E261 at least two spaces before inline comment
Line 346:51: E262 inline comment should start with '# '
Line 347:55: E261 at least two spaces before inline comment
Line 347:56: E262 inline comment should start with '# '
Line 348:57: E261 at least two spaces before inline comment
Line 348:58: E262 inline comment should start with '# '
Line 349:61: E261 at least two spaces before inline comment
Line 349:62: E262 inline comment should start with '# '
Line 350:60: E261 at least two spaces before inline comment
Line 350:61: E262 inline comment should start with '# '
Line 351:53: E261 at least two spaces before inline comment
Line 351:54: E262 inline comment should start with '# '
Line 352:53: E261 at least two spaces before inline comment
Line 352:54: E262 inline comment should start with '# '
Line 353:56: E261 at least two spaces before inline comment
Line 353:57: E262 inline comment should start with '# '
Line 354:58: E261 at least two spaces before inline comment
Line 354:59: E262 inline comment should start with '# '
Line 355:49: E261 at least two spaces before inline comment
Line 355:50: E262 inline comment should start with '# '
Line 356:53: E261 at least two spaces before inline comment
Line 356:54: E262 inline comment should start with '# '
Line 357:54: E261 at least two spaces before inline comment
Line 357:55: E262 inline comment should start with '# '
Line 358:58: E261 at least two spaces before inline comment
Line 358:59: E262 inline comment should start with '# '
Line 359:58: E261 at least two spaces before inline comment
Line 359:59: E262 inline comment should start with '# '
Line 360:62: E261 at least two spaces before inline comment
Line 360:63: E262 inline comment should start with '# '
Line 361:49: E261 at least two spaces before inline comment
Line 361:50: E262 inline comment should start with '# '
Line 362:53: E261 at least two spaces before inline comment
Line 362:54: E262 inline comment should start with '# '
Line 363:53: E261 at least two spaces before inline comment
Line 363:54: E262 inline comment should start with '# '
Line 364:57: E261 at least two spaces before inline comment
Line 364:58: E262 inline comment should start with '# '
Line 365:61: E261 at least two spaces before inline comment
Line 365:62: E262 inline comment should start with '# '
Line 366:63: E261 at least two spaces before inline comment
Line 366:64: E262 inline comment should start with '# '
Line 367:56: E261 at least two spaces before inline comment
Line 367:57: E262 inline comment should start with '# '
Line 368:52: E261 at least two spaces before inline comment
Line 368:53: E262 inline comment should start with '# '
Line 412:5: E722 do not use bare except'
Line 420:1: E265 block comment should start with '# '
Line 454:13: E265 block comment should start with '# '
Line 459:121: E501 line too long (121 > 120 characters)
Line 468:121: E501 line too long (142 > 120 characters)
Line 478:76: E211 whitespace before '('
Line 478:121: E501 line too long (128 > 120 characters)
Line 479:77: E128 continuation line under-indented for visual indent
Line 479:121: E501 line too long (135 > 120 characters)
Line 482:72: E211 whitespace before '('
Line 482:121: E501 line too long (124 > 120 characters)
Line 483:73: E128 continuation line under-indented for visual indent
Line 483:121: E501 line too long (131 > 120 characters)
Line 499:5: E722 do not use bare except'
Line 517:68: E211 whitespace before '('
Line 517:121: E501 line too long (127 > 120 characters)
Line 521:68: E211 whitespace before '('
Line 521:121: E501 line too long (127 > 120 characters)
Line 530:72: E211 whitespace before '('
Line 531:73: E128 continuation line under-indented for visual indent
Line 544:5: E722 do not use bare except'
Line 568:33: E127 continuation line over-indented for visual indent
Line 578:41: E128 continuation line under-indented for visual indent
Line 595:5: E722 do not use bare except'
Line 630:29: E127 continuation line over-indented for visual indent
Line 658:40: E211 whitespace before '('
Line 699:5: E722 do not use bare except'
Line 772:41: E211 whitespace before '('
Line 783:41: E211 whitespace before '('
Line 830:51: E225 missing whitespace around operator
Line 832:59: E225 missing whitespace around operator
Line 833:31: E201 whitespace after '['
Line 833:54: E202 whitespace before ']'
Line 836:53: E225 missing whitespace around operator
Line 838:61: E225 missing whitespace around operator
Line 839:32: E201 whitespace after '['
Line 839:57: E202 whitespace before ']'
Line 854:5: E722 do not use bare except'
Line 888:121: E501 line too long (139 > 120 characters)
Line 891:21: E225 missing whitespace around operator
Line 916:121: E501 line too long (128 > 120 characters)
Line 917:121: E501 line too long (128 > 120 characters)
Line 917:125: E226 missing whitespace around arithmetic operator
Line 923:121: E501 line too long (138 > 120 characters)
Line 941:5: E722 do not use bare except'
Line 975:29: E127 continuation line over-indented for visual indent
Line 976:29: E127 continuation line over-indented for visual indent
Line 979:14: E225 missing whitespace around operator
Line 1007:121: E501 line too long (132 > 120 characters)
Line 1013:52: E128 continuation line under-indented for visual indent
Line 1019:25: E265 block comment should start with '# '
Line 1060:63: E226 missing whitespace around arithmetic operator
Line 1077:5: E722 do not use bare except'
Line 1117:21: E128 continuation line under-indented for visual indent
Line 1118:21: E128 continuation line under-indented for visual indent
Line 1120:14: E225 missing whitespace around operator
Line 1142:45: E211 whitespace before '('
Line 1152:121: E501 line too long (132 > 120 characters)
Line 1160:69: E211 whitespace before '('
Line 1163:121: E501 line too long (136 > 120 characters)
Line 1166:54: E231 missing whitespace after ','
Line 1173:56: E231 missing whitespace after ','
Line 1187:62: E201 whitespace after '['
Line 1187:75: E225 missing whitespace around operator
Line 1187:88: E231 missing whitespace after ','
Line 1187:108: E231 missing whitespace after ','
Line 1187:111: E225 missing whitespace around operator
Line 1187:121: E501 line too long (124 > 120 characters)
Line 1187:123: E202 whitespace before ']'
Line 1190:75: E231 missing whitespace after ','
Line 1190:104: E231 missing whitespace after ','
Line 1204:121: E501 line too long (204 > 120 characters)
Line 1210:121: E501 line too long (126 > 120 characters)
Line 1217:49: E265 block comment should start with '# '
Line 1217:121: E501 line too long (149 > 120 characters)
Line 1218:49: E265 block comment should start with '# '
Line 1218:121: E501 line too long (184 > 120 characters)
Line 1239:121: E501 line too long (179 > 120 characters)
Line 1241:121: E501 line too long (177 > 120 characters)
Line 1243:121: E501 line too long (181 > 120 characters)
Line 1245:121: E501 line too long (217 > 120 characters)
Line 1247:121: E501 line too long (138 > 120 characters)
Line 1248:25: E722 do not use bare except'
Line 1249:121: E501 line too long (145 > 120 characters)
Line 1263:5: E722 do not use bare except'
Line 1300:21: E128 continuation line under-indented for visual indent
Line 1301:21: E128 continuation line under-indented for visual indent
Line 1303:14: E225 missing whitespace around operator
Line 1316:45: E211 whitespace before '('
Line 1326:121: E501 line too long (132 > 120 characters)
Line 1334:69: E211 whitespace before '('
Line 1337:121: E501 line too long (140 > 120 characters)
Line 1340:54: E231 missing whitespace after ','
Line 1347:54: E231 missing whitespace after ','
Line 1349:45: E201 whitespace after '['
Line 1349:57: E225 missing whitespace around operator
Line 1349:70: E231 missing whitespace after ','
Line 1349:90: E231 missing whitespace after ','
Line 1349:93: E225 missing whitespace around operator
Line 1349:105: E202 whitespace before ']'
Line 1359:62: E201 whitespace after '['
Line 1359:73: E225 missing whitespace around operator
Line 1359:86: E231 missing whitespace after ','
Line 1359:106: E231 missing whitespace after ','
Line 1359:109: E225 missing whitespace around operator
Line 1359:119: E202 whitespace before ']'
Line 1362:75: E231 missing whitespace after ','
Line 1362:104: E231 missing whitespace after ','
Line 1399:121: E501 line too long (123 > 120 characters)
Line 1401:121: E501 line too long (177 > 120 characters)
Line 1408:121: E501 line too long (161 > 120 characters)
Line 1410:121: E501 line too long (179 > 120 characters)
Line 1412:121: E501 line too long (215 > 120 characters)
Line 1414:121: E501 line too long (143 > 120 characters)
Line 1415:25: E722 do not use bare except'
Line 1416:121: E501 line too long (143 > 120 characters)
Line 1434:5: E722 do not use bare except'
Line 1469:22: E111 indentation is not a multiple of four
Line 1473:27: E211 whitespace before '('
Line 1480:5: E722 do not use bare except'
Line 1511:33: E128 continuation line under-indented for visual indent
Line 1512:33: E128 continuation line under-indented for visual indent
Line 1517:41: E128 continuation line under-indented for visual indent
Line 1527:5: E722 do not use bare except'
Line 1558:29: E127 continuation line over-indented for visual indent
Line 1559:29: E127 continuation line over-indented for visual indent
Line 1566:41: E128 continuation line under-indented for visual indent
Line 1590:17: E265 block comment should start with '# '
Line 1591:17: E265 block comment should start with '# '
Line 1599:62: E127 continuation line over-indented for visual indent
Line 1613:29: E265 block comment should start with '# '
Line 1616:45: E128 continuation line under-indented for visual indent
Line 1622:121: E501 line too long (132 > 120 characters)
Line 1623:21: E722 do not use bare except'
Line 1630:77: E502 the backslash is redundant between brackets
Line 1677:5: E722 do not use bare except'
Line 1703:21: E128 continuation line under-indented for visual indent
Line 1719:29: E128 continuation line under-indented for visual indent
Line 1731:5: E722 do not use bare except'
Line 1774:29: E128 continuation line under-indented for visual indent
Line 1788:5: E722 do not use bare except'
Line 1815:20: E128 continuation line under-indented for visual indent
Line 1847:19: E226 missing whitespace around arithmetic operator
Line 1851:16: E225 missing whitespace around operator
Line 1856:73: E502 the backslash is redundant between brackets
Line 1857:37: E128 continuation line under-indented for visual indent
Line 1859:83: E502 the backslash is redundant between brackets
Line 1860:37: E128 continuation line under-indented for visual indent
Line 1865:5: E722 do not use bare except'
Line 1913:16: E225 missing whitespace around operator
Line 1929:12: E714 test for object identity should be 'is not'
Line 1931:31: E225 missing whitespace around operator
Line 1933:22: E225 missing whitespace around operator
Line 1935:19: E225 missing whitespace around operator
Line 1942:65: E127 continuation line over-indented for visual indent
Line 1943:65: E127 continuation line over-indented for visual indent
Line 1957:5: E303 too many blank lines (2)
Line 1957:5: E722 do not use bare except'
Line 1975:5: E265 block comment should start with '# '
Line 2021:26: E211 whitespace before '('
Line 2025:5: E722 do not use bare except'
Line 2031:38: E211 whitespace before '('
Line 2039:23: E211 whitespace before '('
Line 2043:5: E125 continuation line with same indent as next logical line
Line 2052:9: E125 continuation line with same indent as next logical line
Line 2073:26: E211 whitespace before '('
Line 2106:9: E265 block comment should start with '# '
Line 2108:40: E211 whitespace before '('
Line 2111:9: E265 block comment should start with '# '
Line 2114:13: E265 block comment should start with '# '
Line 2119:13: E265 block comment should start with '# '
Line 2131:5: E265 block comment should start with '# '
Line 2132:121: E501 line too long (122 > 120 characters)
Line 2157:9: E265 block comment should start with '# '
Line 2162:9: E265 block comment should start with '# '
Line 2171:121: E501 line too long (132 > 120 characters)
Line 2174:29: E128 continuation line under-indented for visual indent
Line 2175:29: E128 continuation line under-indented for visual indent
Line 2176:29: E128 continuation line under-indented for visual indent
Line 2183:47: E211 whitespace before '('
Line 2183:121: E501 line too long (123 > 120 characters)
Line 2187:121: E501 line too long (127 > 120 characters)
Line 2200:13: E265 block comment should start with '# '
Line 2201:32: E703 statement ends with a semicolon
Line 2207:21: E265 block comment should start with '# '
Line 2224:13: E265 block comment should start with '# '
Line 2238:33: E128 continuation line under-indented for visual indent
Line 2262:36: E211 whitespace before '('
Line 2278:9: E265 block comment should start with '# '
Line 2293:21: E225 missing whitespace around operator
Line 2294:22: E225 missing whitespace around operator
Line 2295:22: E225 missing whitespace around operator
Line 2302:29: E225 missing whitespace around operator
Line 2303:30: E225 missing whitespace around operator
Line 2306:30: E225 missing whitespace around operator
Line 2325:42: E127 continuation line over-indented for visual indent
Line 2326:42: E127 continuation line over-indented for visual indent
Line 2327:42: E127 continuation line over-indented for visual indent
Line 2328:42: E127 continuation line over-indented for visual indent
Line 2329:42: E127 continuation line over-indented for visual indent
Line 2333:73: E502 the backslash is redundant between brackets
Line 2359:61: E262 inline comment should start with '# '
Line 2360:66: E226 missing whitespace around arithmetic operator
Line 2380:25: E265 block comment should start with '# '
Line 2385:21: E265 block comment should start with '# '
Line 2389:21: E722 do not use bare except'
Line 2398:5: E722 do not use bare except'
Line 2405:21: E128 continuation line under-indented for visual indent
Line 2427:32: E211 whitespace before '('
Line 2431:121: E501 line too long (143 > 120 characters)
Line 2436:29: E211 whitespace before '('
Line 2462:30: E211 whitespace before '('
Line 2464:5: E265 block comment should start with '# '
Line 2474:59: E211 whitespace before '('
Line 2481:33: E211 whitespace before '('
Line 2483:36: E261 at least two spaces before inline comment
Line 2486:56: E226 missing whitespace around arithmetic operator
Line 2486:90: E226 missing whitespace around arithmetic operator
Line 2487:56: E225 missing whitespace around operator
Line 2488:57: E225 missing whitespace around operator
Line 2489:54: E225 missing whitespace around operator
Line 2490:55: E225 missing whitespace around operator
Line 2494:1: E265 block comment should start with '# '
Line 2495:27: E211 whitespace before '('
Line 2497:37: E231 missing whitespace after ','
Line 2497:56: E231 missing whitespace after ','
Line 2509:121: E501 line too long (122 > 120 characters)
Line 2535:1: E302 expected 2 blank lines, found 1
Line 2541:1: E303 too many blank lines (3)
Line 2543:1: E302 expected 2 blank lines, found 3
Line 2546:1: E302 expected 2 blank lines, found 1
Line 2549:1: E302 expected 2 blank lines, found 1
Line 2552:1: E302 expected 2 blank lines, found 1
Line 2556:1: E302 expected 2 blank lines, found 1
Line 2557:12: E226 missing whitespace around arithmetic operator
Line 2560:32: E226 missing whitespace around arithmetic operator
Line 2560:44: E226 missing whitespace around arithmetic operator
Line 2560:50: E226 missing whitespace around arithmetic operator
Line 2561:16: E226 missing whitespace around arithmetic operator
Line 2561:21: E226 missing whitespace around arithmetic operator


Fix case of FakeXHR when sending a FormData payload.

There's a pull request in Sinon.JS to fix this upstream, but I've got tests that won't pass without the fix. https://github.com/cjohansen/Sinon.JS/pull/618

Let's get the upstream guy merged in; I don't want to have to maintain patches to the concatenated source


Feature: Jlink plugin

Description

Adding an htrun-plugin that flashes, erases and resets using the JLINK commander software.
The plugin enables both JTAG and SWD interfaces (but no 'network JLINK').
Touches on https://github.com/ARMmbed/mbed-cli/issues/475
Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

No response to code review for 9 months, closing PR.

Adding an htrun-plugin that flashes, erases and resets using the JLINK commander software.

@embeddedteam103  It might be useful to update this via a new PR


Documentation Table Formatting

but the formatting for your table in the documentation is broken. Just thought id let you know.
Thanks for a cool app.

Thanks!


$boundParam (Line  567) in Set-SMACustomer needed ?

VS-Code grumbles this is a non-used variable ..

No un-used variable found (in my VS Code).
The only thing I have found is a SupportsShouldProcess in the test command.
From: Roman Stadlmair @.>
Sent: Samstag, 17. Juli 2021 11:43
To: seppmail/SEPPmailAPI @.>
Cc: Hans Halbmayr @.>; Assign @.>
Subject: [seppmail/SEPPmailAPI] $boundParam (Line 567) in Set-SMACustomer needed ? (#19)
VS-Code grumbles this is a non-used variable ..
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://github.com/seppmail/SEPPmailAPI/issues/19, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AT7CWM3BUTIRJMLH7H36HO3TYFGATANCNFSM5AQ46CQA.

Could you please give me the name of the function.
Thanks

(Line 567) in Set-SMACustomer

I think you have defined the var $boundParam. You ref this var in function New-SMAQueryString.

true, its for the varoius options to create a query string. Case closed


vm/dart_2/causal_stacks/async_throws_stack_lazy_non_symbolic_test fails in bare instructions mode

Removal of --[no-]use-bare-instructions revealed that this test was only passing in non-bare instructions mode.
We should investigate why and whether this reveals an issue that our customer will also hit with their applications. (which are primarily deployed in bare instructions mode).

Merging into https://github.com/dart-lang/sdk/issues/51468


webpack-chunks.json configurable request

I have two entrys in my webpack file and start it separately, but webpack-chunks.json always be covered，so at 'universal.settings.js'：
module.exports = {
  server: {input: 'xxx', output: 'xxx'}
  chunkFilename: 'xxxx-webpack-chunk.json'
}

please support it #43

Explain more about your situation: why do you have two entries in Webpack configuration.
I can see why some people may have 2 entries: for code splitting (e.g. "photos", "blog", "forum").
But what's your case?

I have two react + Redux applications, A and B, A is an independent application with a AppHeader component. AppHeader contains a number of complex components, these components need API organization Redux data, you want to split the AppHeader is more difficult. B is a different application, it needs AppHeader and most of the logic is not consistent with A. So I can only put A and B into a repo, make two entrances. And later there will be more similar to the B application, even with the splitting code separately, it will become increasingly difficult to maintain.

Published<EMAIL_ADDRESS>


DropIn setup does not automatically show the default user credit card

When the user has multiple credit cards and the default one is changed via the API, the next time that the dropIn menu is shown, the new default card is not shown as main card to proceed with the payment.

@ppcano I am going to close this as a duplicate issue. See #5 and further discussion on this thread.

Drop-In now has a boolean parameter you can pass in called defaultFirst

When you specify a customerID that has vaulted payment methods associated with it, Drop-in displays a list of those payment methods and automatically pre-selects the one used most recently. If you pass defaultFirst, Drop-in will instead pre-select the payment method marked as default for the customer.

The docs for this are the last entry in this table

Hey @crookedneighbor i've tried your method, but the dropin still shows the first add card info only.

@hariharasudhankm What do you mean by "first add card info"?
Also, could you make sure you're on the latest Braintree.js version? You can check the version in your JavaScript console by typing braintree.VERSION. The defaultFirst feature was added in version 2.24.0 and the current version is 2.28.0.

@EvanHahn I'm facing the issue that defaultFirst is not available as my version of Braintree.js is 2.15.7 but I'm loading Braintree.js from https://js.braintreegateway.com/v2/braintree.js.
Why is the Braintree.js version so old on the braintree servers?

@zedtux We made the decision a while ago to stop putting the latest v2 version on the hotlink url you are using. The hotlinking model made it difficult to maintain a stable product, since all merchant checkouts were immediately and simultaneously affected by any regressions in the code.
You should be able to swap out https://js.braintreegateway.com/v2/braintree.js for https://js.braintreegateway.com/js/braintree-2.32.1.min.js and be good to go.

Oh, okay. That's kind of bad as all blog articles are mentioning https://js.braintreegateway.com/v2/braintree.js ...
But okay, thank you very much @crookedneighbor for the information, I will use that!


Fix to day-of-the-week interval calculation

Day-of-the-week interval calculation should consider also the current day as a valid candidate.

@philcali - can you please review and merge?
we hope this PR will fix the issue of incorrect calculation...

@federico-pellegatta  - maybe we should add a test that will cover this change? i'll try to write it also

@philcali  could you please create a new release with that fix?


Added Health Dept. Phone number to footer

Issue Reference
Added Kerala Health Dept. 24x7 Helpline Call Centre.
Summarize
Added 1800 123 1454 too footer.

Added toll-free number to footer.

@syam3526 @drtechie do verify.

@IEEEKeralaSection/moderators urgent have a look and merge

@syam3526  I've raised #777 which lets the users click on the phone number to open the dial pad.

@Neonkraft , that's pretty neat. Can I add that here?

@aravindharinair go for it!!

@Neonkraft Cheers, mate! Could you re-verify?


unable to use vanilla transfer command

please change the default command, I would like to also be able to use the vanilla transfer command. maybe /service or /transferservice /ts

Is there a specific reason as to why you need the vanilla transfer command?

I realized that we can use minecraft:transfer to use the vanilla command.
To answer your question, we use vanilla transfer to move players to
"partner" servers that are run by other server owners we are friendly with.
On Sun, Dec 22, 2024, 12:27 Adam Snover @.***> wrote:

Is there a specific reason as to why you need the vanilla transfer command?
—
Reply to this email directly, view it on GitHub
https://github.com/asnover/Transfer-Service/issues/9#issuecomment-2558587361,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOKUSL2OILBBQSWJUU3NXSL2G4OD3AVCNFSM6AAAAABT6U5NAKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJYGU4DOMZWGE
.
You are receiving this because you authored the thread.Message ID:
@.***>


No File drop-down menu

I have installed Behavior3editor and extracted Electron into its respective electron directory, but when I run Electron and click 'File' there is no drop-down. No import file. I can't find the nodes.json file to import if the program won't let me import anything.
There is an error that pops up in the program, but I'm not sure how to fix that, either. Maybe that's connected to the problem I'm having.
Here is a screenshot of the program.
https://i.imgur.com/0Kx3pYU.png
I installed Node.js and npm.
I installed Electron using the command line "npm install electron --save-dev".
I extracted Electron to the 'Electron ' folder inside the Behavior3Editor folder.
When I run Electron from there and go to open a file, it simply doesn't give me the option.

That looks completely broken. Are you using Electron 1.3.1 specifically or a later version? You can get 1.3.1 at: https://github.com/electron/electron/releases/tag/v1.3.1


Remove version: Redisant.RedisAssistant version <IP_ADDRESS>

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

/azp run

/azp run


Build failure: teams-for-linux

Steps To Reproduce
Steps to reproduce the behavior:

allow insecure package electron-29.4.6
build teams-for-linux

Build log
error: builder for '/nix/store/w6npgp9zxljdgfpi2wr9p9z5lvb90fbs-teams-for-linux-1.4.27.drv' failed with exit code 1;
       last 25 log lines:
       > node_modules/yarn/bin/yarnpkg: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/v14k93caffbf0xz2g7bqr964grxxqlmj-nodejs-20.15.1/bin/node"
       > node_modules/yarn/bin/yarn: interpreter directive changed from "#!/bin/sh" to "/nix/store/4bj2kxdm1462fzcc2i2s4dn33g2angcc-bash-5.2p32/bin/sh"
       > node_modules/yarn/bin/yarn.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/v14k93caffbf0xz2g7bqr964grxxqlmj-nodejs-20.15.1/bin/node"
       > Running phase: buildPhase
       > yarn run v1.22.22
       > $ /build/source/node_modules/.bin/electron-builder --dir --linux --x64 -c.electronDist=/nix/store/0xfk2rllpsh92hk0lpncxf80wf3ydj6g-electron-29.4.6/libexec/electron -c.electronVersion=29.4.6
       >   • electron-builder  version=24.13.3 os=6.10.6
       >   • loaded configuration  file=package.json ("build" field)
       >   • writing effective config  file=dist/builder-effective-config.yaml
       >   • packaging       platform=linux arch=x64 electron=29.4.6 appOutDir=dist/linux-unpacked
       >   • copying Electron  source=/nix/store/0xfk2rllpsh92hk0lpncxf80wf3ydj6g-electron-29.4.6/libexec/electron destination=/build/source/dist/linux-unpacked
       > afterPack error:  Error: Could not find sentinel in the provided Electron binary, fuses are only supported in Electron 12 and higher
       >     at setFuseWire (/build/source/node_modules/@electron/fuses/src/index.ts:79:13)
       >     at flipFuses (/build/source/node_modules/@electron/fuses/src/index.ts:171:22)
       >     at afterPack (/build/source/scripts/afterpack.js:25:3)
       >     at Packager.afterPack (/build/source/node_modules/app-builder-lib/src/packager.ts:546:7)
       >     at LinuxPackager.doPack (/build/source/node_modules/app-builder-lib/src/platformPackager.ts:312:5)
       >     at LinuxPackager.pack (/build/source/node_modules/app-builder-lib/src/platformPackager.ts:140:5)
       >     at Packager.doBuild (/build/source/node_modules/app-builder-lib/src/packager.ts:445:9)
       >     at executeFinally (/build/source/node_modules/builder-util/src/promise.ts:12:14)
       >     at Packager._build (/build/source/node_modules/app-builder-lib/src/packager.ts:379:31)
       >     at Packager.build (/build/source/node_modules/app-builder-lib/src/packager.ts:340:12)
       >     at executeFinally (/build/source/node_modules/builder-util/src/promise.ts:12:14)
       > error Command failed with exit code 1.
       > info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
       For full logs, run 'nix log /nix/store/w6npgp9zxljdgfpi2wr9p9z5lvb90fbs-teams-for-linux-1.4.27.drv'.
error: 1 dependencies of derivation '/nix/store/3g7sspzaxbh94y9f2sfp9d4k51aqlfk5-home-manager-path.drv' failed to build
error: 1 dependencies of derivation '/nix/store/qwkdzwylxk6mc38ffn700fnsj3jg321k-man-paths.drv' failed to build
error: 1 dependencies of derivation '/nix/store/slki7sk70y2h3prafh6vivanj6f40p6h-teams-for-linux-1.4.27-fish-completions.drv' failed to build
error: 1 dependencies of derivation '/nix/store/ypb73dxa1kvisr2cfrhmjm2vipf0ap4n-home-manager-generation.drv' failed to build
error: 1 dependencies of derivation '/nix/store/8rf6akpxl2mih2cnliawl5gvv5jyig20-user-environment.drv' failed to build
error: 1 dependencies of derivation '/nix/store/7wvcryx22b58jivyl7x04yvrjfc0s4sp-etc.drv' failed to build
error: 1 dependencies of derivation '/nix/store/1jcnm8fx7bdszkzrimcwddahmj2fll3x-nixos-system-dell-pc-24.11.20240828.71e91c4.drv' failed to build

Additional context
Notify maintainers

@muscaln
@lilyinstarlight
@qjoly
@chvp
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
- system: `"x86_64-linux"`
- host os: `Linux 6.10.6, NixOS, 24.11 (Vicuna), 24.11.20240828.71e91c4`
- multi-user?: `yes`
- sandbox: `relaxed`
- version: `nix-env (Nix) 2.25.0pre20240807_cfe66dbe`
- nixpkgs: `/nix/store/887hpp8a2i99n9jjwcvz6qkhhhqsvzkg-source`

Add a :+1: reaction to issues you find important.

I had the same problem

Fixed in https://github.com/NixOS/nixpkgs/pull/337868.


CAMEL-14808. Initial component implementation

Initial implementation of https://issues.apache.org/jira/browse/CAMEL-14808
for deep learning applications: Image classification and Object detection, MxNet Zoo Models and Local Custom Models

@omarsmak is this ok for you to merge? I will merge this week if we all agree

After merge we need to update to 3.3.0-SNAPSHOT and there may be some files with missing license headers.

Sure, I'll merge this this week.

Thanks @mgubaidullin
This has been merged on master.


Labeling Features in CartoDB.JS prevents layer from rendering

When adding data layers to a Leafet map using the cartodb.createLayer method I've noticed that a layer will not render if I add CartoCSS to properly label the data. The same CartoCSS works when I use it in the dashboard. Here is a gist with code demonstrating the problem

Hey @clhenrick, let me move this ticket to CartoDB.js, due to it is a problem related with the library. Thanks for your feedback! :)
https://github.com/CartoDB/cartodb.js/issues/685

:+1:


Investigate llvm <-> spirv translation for better optimizations

The SPIRV-LLVM-Translator could be used to translate between LLVM bitcode and SPIR-V.

This currently only targets OpenCL and does not support the logical addressing model which is required by Vulkan.


Fix list passed as argument to executable-find

Previously, a list would be passed as an argument to 'executable-find' in '+ledger--check-version-a'.
This instead passes "hledger" as an argument if found, else "ledger".

Derp, forgot I could just do it myself in github. Thanks for the help!

Ah, my bad. One small fix and I will merge this.

Sorry, I'm used to clojure convention. Thanks for fixing it!


Toon shading

Toon shading for deferred local lighting and screen-space edges modue (+namespace fix).
Toon shader uses lambert diffuse, phong specular and simplfied fresnel rim lighting. Each term is first summed up over all light sources and resulting light intensities are then exposed to map a user-defined average intensity value (basically the diffuse midtone) to 0.18 (mid-level brightness when taking gamma correction into account). Each term is then quantized individually into shadow, midtone and light value ranges, with shadow color always set to black and midtone color and light color set to their respective values. Specular and rim lighting are combined using a max operation. Diffuse and combined specular+rim light is mixed based on a user-defined roughness parameter and multiplied with surface albedo color. The final color is comupted by applying extended reinhard tone-mapping (with "white point" set to light values from toon quanization) and gamma correction.
Summary of Changes

Add toon mode to deferred local lighting
Add screen-space edges module
Add alpha-over-operator to texture combine module
Fix compositing_gl namespace

References and Context
Implementation and style are custom-made with insights and inspiration taken from

https://lettier.github.io/3d-game-shaders-for-beginners/index.html
3D World November '21 issue article on toon shading by Armir Zand
Arnold toon material
https://64.github.io/tonemapping/

Test Instructions
Use deferred gltf mesh example project. Switch to toon shading, play around with the parameters. For edge outlines, add ScreenSpaceEdges module and use TextureCombine in "over" mode to combine rendering outputs. Bonus: Turn off blur passes in the SSAO module (ASSO mode only) to get a stylized AO look that fits better to the cel-shaded look.

/format

/format


Slow update times in crowded images

Describe the bug
A noticable slowdown is experienced when the total number of labels per image exceeds roughly 100. This effectively limits the total number of labels that can be effectively added per image. The time it takes for the UI to update after every new label increases from unnoticable to over 10s.
To Reproduce
Steps to reproduce the behavior:

Add a large number of labels to an image, one at a time.
After around 100 labels, notice the UI starts taking much longer to update, slowing you down.

Expected behavior
No noticable slowdown.
Screenshots
Not applicable
Desktop (please complete the following information):

OS: Windows10 2016
Browser Standalone application
Version 2.2.0

I have the same problem. Restarting the application helps for a brief moment but then it slows down again after a few seconds. Might be a rendering problem caused by the number of boxes. I can see a high workload / power utilization of my graphic cards in the task manager. (also on Windows10).

can confirm, I face the same issue on Arch linux


[Feat] New property "AutoGenerateColumns"

Describe the solution you'd like
I want request a feature similar to the  ASP.NET WebForms Gridview "AutoGenerateColumns" property.
This property is of type Boolean and if it is set to true, all columns will be generated automatically with default values.
kind reards
Christian

Version 1.13 added a DynamicColumns component.


fuse.ENODATA not defined

I could not find an error code matching syscall.ENODATA defined in this package.
It should be defined.

Please don't open one issue per missing constant -- that's a little bit excessive.


[ENHANCEMENT] create import for tags to use them in the function

Description
To ensure code quality let's keep the files neat and clean.
Acceptance criteria

[ ] Remove the tag list from the index.js file
[ ] import the tag array to use it in the function

Screenshots
No response
Additional information
No response

Hi, would like to try solving this issue, by moving the 'tags' list to 'tags.js' and then importing it into 'index.js' for cleaner and more organized code?

Hey I would like to work on this. Please assign me when needed :)

Sure @FreemRL please go ahead.


Review qod bw api doc

Please review qod bw api doc
This pull request is to address #27

Will merge as agreed in https://github.com/camaraproject/QualityOnDemand/blob/main/documentation/MeetingMinutes/MOM-2022-09-23.md


fix index add data util kursBudget

Coverage remained the same at 75.909% when pulling 373662b0791e71bab677771f331be253c6aecee8 on indriHutabalian:dev into 146581a8f6d6c2140576ef23cf45a12075468fbf on danliris:dev.


Item is not highlighted on touch

Hey!
Thanks for the awesome package.
When I click on SettingsList.Item it doesn't change it's background like a normal touch control.
Looking at the code I managed to fix it by removing a underlayColor='transparent' props from the underlying <TouchableHighlight> component.
<TouchableHighlight key={'item_' + index} underlayColor='transparent' onPress={item.onPress}>
  <View style={[styles.itemBox, {backgroundColor: item.backgroundColor ? item.backgroundColor : this.props.backgroundColor}]}>

I was wondering, since that underlay is transparent, I can work it around using different background colors, but, unfortunately, I either had to break my design or highlight simply didn't work.
Could you explain what is the main reason you put it in in the first place, and if we could at least make underlayColor configurable via SettingsList.Item props?
Thanks for your answer.

Would you accept a PR for that?

The transparent underlayColor was mainly used for a subtle response to a button press, but I completely get where you are coming from.  I used it in that regard,  but I can see someone else using it in a different manner.  I opened up underlayColor as a prop, and set it's default to transparent.

@evetstech thanks!


Soret effect implementation

Implementation of mixture-averaged Soret effects for light species (W < 5), similar process to Wbar corrections for diffusion. Will also be a corresponding pull request in PelePhysics to obtain coefficients. Note there are some commented out personal diagnostics. @nickwimer @esclapez @drummerdoc @marchdf

Hi Thomas, thanks for doing this ! I'm catching up with some other blocking updates on the AMReX-Hydro side and when those are sorted out I'll give this a proper review and test.


man: create xdg-ninja.1 man page

Because man pages are cool.
You can preview it by using $ man man/xdg-ninja.1
I can also edit the man page if you think it might require some changes before pushing. I was wondering about adding a paragraph for the optional dependencies (glow and alternatives) but figured it would be a better fit to have that in the README.md as a one-time installation information.

Very cool, thank you!
It seems there's a small typo, the options are named as strip-ok, strip-unsupported, etc., when they're actually named skip-ok, skip-unsupported.

I was wondering about adding a paragraph for the optional dependencies

I think there should at least be a paragraph about the recommended dependencies, so jq and glow, although I'm not really familiar with the best practices for man pages.
Apart from that it looks good!

It seems there's a small typo, the options are named as strip-ok, strip-unsupported, etc., when they're actually named skip-ok, skip-unsupported.

 I actually misread strip, that's my bad. Fixed.

I was wondering about adding a paragraph for the optional dependencies

I think there should at least be a paragraph about the recommended dependencies, so jq and glow, although I'm not really familiar with the best practices for man pages.

Since jq is a required (and not a recommended) dependency and the script fails when running without it, I would tend to not have that in the man page, because of the way I see man pages ; documentation on how to use a program and not how to install it.
I think it would make sense to add a note about optional dependencies as the user can have a different behavior depending on that during runtime.
For now I have just added a note about glow, if you prefer also adding a note about jq too I can squash that in.

Looks good to me. Thanks again for all your help with this project!


Missing Loss Functions (Distribution Similarity and Distribution Normalizing Loss)

Hi, Thank you for sharing the code. In the paper, it is mentioned that the overall loss function consists of three parts:
i) the beta-NT-Xent loss term;
ii) the Distribution Similarity Loss; and
iii) the Distribution Normalizing Loss.
However, after reviewing the code, it seems that only the first part, the NT-Xent loss term, is implemented. I couldn't find the implementation of the Distribution Similarity and Distribution Normalizing Loss components.
Could you please clarify if I have misunderstood something, or if these two loss terms are implemented elsewhere in the code?
Thank you for your help!

hola... good to hear that people have attention on the code :) I was just concentrated on some other thing and this repo stayed unfinished. I have just shared the objective functions you request. Through out the week, I will share the code and the benchmarks and everything step by step.
for now the code is naive variational contrastive learning, I will share the beta-NX-ent-loss too.
But I need to test and validate the results and all... It takes time... Thanks for attention.

Got it. Thanks for your reply.

hi,
I release the weights and results for 100e using naive VCL. Upcoming week, I will also share the results using beta-NT-Xent loss.
https://github.com/verimsu/VCL


"Aborted" after hashing the dump of a SafeDisc DVD.

I'm using the latest DIC version for Linux and have dumped a SafeDisc DVD game two times with different drives. But at the and both times after the hashing I am getting an aborted message, here the output:
sudo ./DiscImageCreator_linux.out dvd /dev/sr1 pc_tlotrtbfme_eax07704456DGER_2/dump.bin 16 /sf
AppVersion
        x64, AnsiBuild, 20200403 180855
/sf val was omitted. set [60]
/home/user/bin/DiscImageCreator_linux/pc_tlotrtbfme_eax07704456DGER_2/ doesn't exist, so create.
CurrentDirectory
        /home/user/bin/DiscImageCreator_linux
WorkingPath
         Argument: pc_tlotrtbfme_eax07704456DGER_2/dump.bin
         FullPath: /home/user/bin/DiscImageCreator_linux/pc_tlotrtbfme_eax07704456DGER_2/dump.bin
            Drive: /
        Directory: home/user/bin/DiscImageCreator_linux/pc_tlotrtbfme_eax07704456DGER_2/
         Filename: dump
        Extension: .bin
StartTime: 2020/05/09(Sat) 13:40:44
Set the drive speed: 22160KB/sec
[F:DVDGetRegion][L:387] GetLastError: 0, Success
Reading DirectoryRecord   47/  47
Detected protection [00000001.TMP]. LBA 10287 to 10441
Creating iso(LBA)  2073472/ 2073472
Hashing: PFI.bin
Hashing: DMI.bin
Hashing: dump.iso
double free or corruption (out)
Aborted

I don't know if it's a problem, the image from both drives are the same.

How about other DVDs?
Is .dat file created?

On other non SafeDisc DVDs there is no "Aborted" message, everything is normal. I have no other SafeDisc discs to test.
I think everything was created, checksum was written to dat. The dump is legit, I have compared checksum with redump. Here is the dump: http://forum.redump.org/topic/28466/ibmpc-the-lord-of-the-rings-the-battle-for-middleearth/

Added debug log.
http://www.mediafire.com/file/uw3e03kdkmsmvvq/DiscImageCreator_linux_test.tar.gz/file

It was different this time:
sudo ./DiscImageCreator_linux.out dvd /dev/sr0 pc_tlotrtbfme_eax07704456DGER/dump.bin 16 /sf
[sudo] password for user:
AppVersion
        x64, AnsiBuild, 20200514 141918
/sf val was omitted. set [60]
/home/user/bin/DiscImageCreator_linux_test/pc_tlotrtbfme_eax07704456DGER/ doesn't exist, so create.
CurrentDirectory
        /home/user/bin/DiscImageCreator_linux_test
WorkingPath
         Argument: pc_tlotrtbfme_eax07704456DGER/dump.bin
         FullPath: /home/user/bin/DiscImageCreator_linux_test/pc_tlotrtbfme_eax07704456DGER/dump.bin
            Drive: /
        Directory: home/user/bin/DiscImageCreator_linux_test/pc_tlotrtbfme_eax07704456DGER/
         Filename: dump
        Extension: .bin
StartTime: 2020-05-15T02:28:11+0200
Set the drive speed: 22160KB/sec
[F:DVDGetRegion][L:387] GetLastError: 0, Success
Reading DirectoryRecord   47/  47
Detected protection [00000001.TMP]. LBA 10287 to 10441
Creating iso(LBA)  2073472/ 2073472
Hashing: PFI.bin
Hashing: DMI.bin
Hashing: dump.iso
TerminateProtectData 1
TerminateProtectData 2
TerminateProtectData 3
EndTime: 2020-05-15T02:33:42+0200

I have done two other dumps from CD, one SafeDisc and one with SecuROM. Both had the Aborted message after the dump on the latest version, but the hashes were still valid on both. Haven't tested with the test version.


Update live with current master

@mairaw, Didn't the internal build show any warnings ?
I believe it should have shown warnings regarding the 404 that will get fixed in #16587


Repo sync for protected CLA branch

The pull request is created from live637334377098538225 to live to fix git push error for protected CLA branch

@opbld16 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


move system dbs to bottom of the list in update project from db dialog

This PR fixes #18074. This sorts the databases dropdown to have the system dbs at the bottom of the list so it's easier to find user dbs.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 42.524%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
27567

Relevant Lines:
60572

💛  - Coveralls


Integrate Checkstyle for style checks (Issue #955)

This PR integrates CheckStyle using maven-checkstyle-plugin (added in pom.xml).
I create two CheckStyle configurations:

checkstyle.xml is a strict translation of .editorconfig in the code base (https://github.com/pac4j/pac4j/blob/master/.editorconfig). I suppose it's the style that are supposed to be followed. Unfortunately, as shown in #955 , the current code base has a large number of violations against these style specifications.
checkstyle-zero-vio.xml is the actual style inferred from the existing code base, and thus is coherent with the code. If you run Checkstyle against this specification, there is 0 violations.

The command to run Checkstyle is:
$ mvn checkstyle:check

As I use checkstyle-zero-vio.xml in pom.xml, the PR would not affect the build process. However, changing it to checkstyle.xml would results in many violations (fixing them needs to revise the code).

I think we should directly use the correct checkstyle configuration and fix the problems in one go :)
But are the violations related to indentation and stuffs like that or also to other stylistic issues (because the zero-vio file seems to contain much more than just things about indentation style…)

@victornoel then we can apply checkstyle.xml
The violations include indentation, line length, and trailing white space (basically those 5 rules specified in .editorconfig; all of these rules are violated)
The zero-violation file is generated via a tool that infers the style of an existing code base
(it's strictly consistent with the current code base)
There're more rules than what is specified in .editorconfig (which are somehow followed by the current code)

ok, so seems good to me then, could you apply the changes to the code and we will see how it looks like? :)

Yes, I'm in line, we should follow our own .editorconfig and fix all violations.

done.  you can run
$ mvn checkstyle:check

to examine and fix the violations.

@tianyin but could you actually apply the changes and put the in a commit? As well as enabling checkstyle in the travis build?

@tianyin Can we complete this and integrate the checkstyle verification in the build? As well as the appropriate changes? Thx

Thanks


Adapter crashes

2022-06-13 10:28:19.439  - debug: minuaru.0 (748709) state at reset debounce timer: {"val":false,"ack":true,"ts":1655108784501,"q":0,"from":"system.adapter.hm-rpc.1","user":"system.user.admin","lc":1643700174842}
2022-06-13 10:28:19.443  - error: minuaru.0 (748709) uncaught exception: Cannot read property 'valueAtAlarm' of undefined
2022-06-13 10:28:19.445  - error: minuaru.0 (748709) TypeError: Cannot read property 'valueAtAlarm' of undefined
at Immediate. (/opt/iobroker/node_modules/iobroker.minuaru/main.js:408:87)
at processImmediate (internal/timers.js:466:21)

needs more info plz install v0.9.8 and post log

solved with v1.0.0


exe properties and logo (icon) problem

dotNetInstaller 2.3-2.4
InstallerLinker.exe clear exe-properties and logo (icon) after embed cab.
Runs on:

Win8.1x64 - Properties and icon is empty
Win2008R2x86 - Properties and the icon is present

File properties image before and after embed cab: https://cloud.mail.ru/public/MK7F/aKmmxk3kH

The problem can be reproduced only when viewing from the TotalCommander

So that screenshot isn't correct? That doesn't look like TotalCommander or what am I missing?

Screenshot is correct.
It is likely to feature display properties of large files in tоtаlCоmmаnder. In Explorer all displayed correctly.
P.S. Bootstrapper file size > 300MB.

:+1: I've worked with 1.5GB bootstrappers, you'll be OK :)


What's the best way to update a related model using repositories?

Let's say I receive an array with new States that should be added to a Country. Should I use a foreach to add every single State one by one or there's a shortcut for this?

Hello @golinmarq
This is a feature request that we'd love to implement (duplicate #51 )
PR are most welcome as well 😉


Export/import spectest fixes

This actually includes changes for lucetc tests as well, which it turned out to be testing that a bug continued being a bug
Broadly this improves support for exported values - globals and functions (haven't gotten to tables/memory yet)
Draft PR because it's not complete (latest commit fails due to not handling exported imports properly with Faerie), but there's enough here I'd like to get eyes

Closing to split these changes into their logically different parts


TCM West

Guide
https://iptv-org.github.io/epg/guides/us.xml
Description
TCM West EPG is showing the guide for TCM East

There was already a pending pull request to fix thus #1475


[Intel MKL] Updating artifact references in Readme.md.

Hi @gunan. This will update the README.md to show the status of the Intel public CI builds as well as the status of the Jenkins job to build the 1.9 release whls.

@gunan Done

Hi @gunan, Can you merge this one?
Thanks!


Refactor screen.py module

[x] Check if the functions are more suited in some other module

[x] Write tests

[x] Write documentation

[x] Create an example notebook

all tasks done


Add support to phpUnit 6 and 7

From phpUnit 6+, we should now use the class PHPUnit\Framework\Assert instead of PHPUnit_Framework_Assert. The composer.json was updated accordingly.
Since this new version of phpUnit is only compatible with PHP 7.0+, I've also updated minimum PHP version and drop the support for Laravel 4.2.
Finally, I've added some phpDoc to make the class more easily usable.

Can you also update the .travis.yml file to remove unsupported PHP versions and add 7.1 and 7.2?
The rest looks :+1: to me!

I've done the change, but now HHVM fails. Do you understand the error? https://travis-ci.org/tomzx/ditto/jobs/411772257

Given phpunit does not test against hhvm and my php-composer-template does not either, I guess we should just drop support for hhvm.

OK, I've remove hhvm from the .travis.yml and the build is now fine.

Thanks!


Add source IP visibility info to Ingress and Gateway API docs

This commit adds information about how best to get access to the source IP address for Ingress and Gateway API configs.
As part of this, break out the Reference section recently added to the Ingress config, and bring it into the Gateway API docs as well (for all the areas where the same things apply).

/test


MODOAIPMH-12/MODOAIPMH-20 - use VertxCompletableFuture

The CompletableFuture uses its executors to perform tasks. When testing locally I noticed that a lot of threads actually created to execute those tasks. the log output was like:
2018-11-06 08:31:38,356 INFO  [Thread-12 ]: MarcXmlMapper reqId=551398/oai Marc json converted to Node after 385 ms
2018-11-06 08:31:38,358 INFO  [Thread-13 ]: MarcXmlMapper reqId=551398/oai Marc json converted to Node after 377 ms
2018-11-06 08:31:38,432 INFO  [Thread-4  ]: MarcXmlMapper reqId=551398/oai Marc json converted to Node after 591 ms
2018-11-06 08:31:38,537 INFO  [Thread-12 ]: ResponseHelper reqId=551398/oai Byte array converted to Object after 179 ms
2018-11-06 08:31:38,535 INFO  [Thread-10 ]: ResponseHelper reqId=551398/oai Byte array converted to Object after 185 ms
2018-11-06 08:31:38,631 INFO  [Thread-4  ]: ResponseHelper reqId=551398/oai Byte array converted to Object after 198 ms
2018-11-06 08:31:38,793 INFO  [Thread-4  ]: ResponseHelper reqId=551398/oai The OAIPMH response converted to string after 153 ms

So wrapping okapi client responses (which are in CompletableFuture) to execute further tasks on vert.x context. The log output in this case looks like following:
2018-11-06 08:18:13,332 INFO  [vert.x-eventloop-thread-0]: MarcXmlMapper reqId=251768/oai Marc json converted to Node after 2 ms
2018-11-06 08:18:13,335 INFO  [vert.x-eventloop-thread-0]: MarcXmlMapper reqId=251768/oai Marc json converted to Node after 2 ms
2018-11-06 08:18:13,342 INFO  [vert.x-eventloop-thread-0]: MarcXmlMapper reqId=251768/oai Marc json converted to Node after 2 ms
2018-11-06 08:18:13,381 INFO  [vert.x-eventloop-thread-0]: ResponseHelper reqId=251768/oai The OAIPMH response converted to string after 34 ms

Good point.
I agree it's strange that okapi client returns java's implementation of CompletableFuture which utilizes it's own thread pool.
The whole idea of Vert.x is to minimize number of threads used to handle the load. Using non-Vertx threads would compromises this idea.
I think it worth to look further into it to figure out what happens.

The latest commit includes following changes:

running potentially blocking operations (like marc to xml and jaxb marshalling) as VertxCompletableFuture#supplyBlockingAsync
replacing org.apache.log4j.Logger by io.vertx.core.logging.Logger
due to the fact that RMB defines log4j 2 as the main logger framework adding org.apache.logging.log4j:log4j-slf4j-impl
removing org.folio.okapi:okapi-common dependency because we use only 2 constants but there are a lot of unneeded transitive dependencies added

Now if the debug is enabled the log output for ListRecords is like:
2018-11-08T12:26:54,048 DEBUG [vert.x-eventloop-thread-0]: AbstractGetRecordsHelper reqId=781592/oai Sending message to /instance-storage/instances?query=...
2018-11-08T12:26:55,035 DEBUG [vert.x-eventloop-thread-0]: AbstractGetRecordsHelper reqId=781592/oai Number of instances to process: 11
2018-11-08T12:26:55,046 DEBUG [vert.x-eventloop-thread-0]: AbstractGetRecordsHelper reqId=781592/oai Getting metadata info from /instance-storage/instances/...
...
2018-11-08T12:26:55,381 DEBUG [vert.x-worker-thread-4   ]: MarcXmlMapper  Marc-json converted to MarcXml after 36 ms
2018-11-08T12:26:55,389 DEBUG [vert.x-worker-thread-4   ]: MarcXmlMapper  Marc-json converted to MarcXml after 7 ms
2018-11-08T12:26:55,391 DEBUG [vert.x-eventloop-thread-0]: GetOaiRecordsHelper reqId=781592/oai 11 records found for the request.
2018-11-08T12:26:55,490 DEBUG [vert.x-worker-thread-5   ]: ResponseHelper  OAIPMH converted to string after 82 ms
2018-11-08T12:26:55,495 DEBUG [vert.x-eventloop-thread-0]: OaiPmhImpl reqId=781592/oai ListRecords response: ...


postcss-cssnext webpack 2 config example

Sorry, if this is the wrong repo in your opinion to address this issue, I am just not sure where to turn to anymore. And I saw that you probably have it working somewhere: https://github.com/webpack/webpack/issues/2684
I am using react-toolbox@2 with webpack@2 and cannot get it to transpile variables and probably other cssnext features into css.
Do you have a working webpack 2 config or an example repo that you can share?
The use case is that I need the postcss-cssnext cssmodules webpack 2 toolchain for react-toolbox, and besides that the css that is not from expternal modules is written in scss + cssmodules.
Some help would be greatly appreciated!

You should find something here https://github.com/MoOx/phenomic/blob/290976455fe11a5d4afd666f832e1ddf1dee3a56/themes/phenomic-theme-base/webpack.config.js


Support for Inter-service WebSocket call

Similar to how gofr support calling http services by adding the service using app.AddHTTPService and then accessing the service from the context.
WebSocket interservice calls should be supported in the similar way. As otherwise user would need to do dependency injection for all their WebSocket services.

Please assign this issue to me

@rigved-telang assigned the issue to you.
Before proceeding with the implementation it will be really helpful if we can discuss on the plan to implement this.
What are your thoughts? How are you gonna proceed with it?

Sure. Have been going through the code, needed some time to understand it. Will put my plan of implementation here for review before starting with dev. Will need a few days for this, hope thats okay.

@rigved-telang sure you can take your time. Will look forward to discussing with you about implementation

Hey @Umang01-hash, this is what I have thought of so far
pkg/gofr/container/container.go

// Map to store map of services with their connection strings

type Container struct {
  ...
  WSManager *websocket.Manager
  ...
}

pkg/gofr/gofr.go

// Function to add WebSocket connection to the websocket Manager
// AddWSService registers WS connection in container.

func (a *App) AddWSService(serviceName, serviceAddress string, options ...service.Options) {
  if a.container.WSManager == nil {
    a.container.WSManager = *websocket.New()
  }

  if _, ok := a.container.WSManager[serviceName]; ok {
    a.container.Debugf("Service already registered Name: %v", serviceName)
  }

  a.container.Services[serviceName] = service.NewWSService(...)
}

I am having trouble as to how and where I can call the Upgrade function in WSUpgrader to get the Connection struct as the Upgrade function requires w http.ResponseWriter, r *http.Request, responseHeader http.Header as the arguments, how do I pass these arguments. Let me know if you think the approach is correct or not, also do answer my doubt about the Upgrade function.

Hey @rigved-telang. Your approach to using the Container struct to manage WebSocket services is correct. And regarding the Upgrade function call and passing the required arguments I need to think and figure it out. Please lend me some time will get back to you.

@rigved-telang So having a look at the core implementation of websockets in GoFr you'll find that we have a middleware WSHandlerUpgrade that upgrades the incoming request to websocket connection.
We can't directly call the Upgrade function of WSUpgrader because it will require raw ResponseWriter and Request which are wrapped by our GoFr.
Acc to me the flow of implementation can be after adding the ws service in AddWSService we will just put the entry in the WSService mapping inside container but we will establish the connection when the user calls GetWSService which can then return the established connection.
We need to have methods on our Connection struct to Read and Write messages. The thing to be taken care of here is how you will manage these connections ?
I tried a basic raw (but incomplete) implementation in this branch: https://github.com/gofr-dev/gofr/compare/en/intersvc_websocket
Maybe you can have a look.

Cool, I'll look into this and let you know. Thanks

@rigved-telang , Any updates on this discussion ?

No sorry, I haven't been able to work on it. Have been jam-packed with office work. If anybody else wants to pick this issue, do let them, I don't think I will be able to progress this. Apologies for the inconvenience.


Stale homebrew/core checkouts result in mishandling of deleted formulae

brew gist-logs <formula> link OR brew config AND brew doctor output
% brew config
HOMEBREW_VERSION: 4.0.15
ORIGIN: https://github.com/Homebrew/brew
HEAD: 763c41f006ab9b44261e313b0aaa24a047431b06
Last commit: 6 days ago
Core tap origin: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 2a72f5600dfb622613a6fb43403475e9d42f0a02
Core tap last commit: 2 months ago
Core tap branch: master
Core tap JSON: 30 Apr 08:50 UTC
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_MAKE_JOBS: 8
Homebrew Ruby: 2.6.10 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: octa-core 64-bit arm_blizzard_avalanche
Clang: 14.0.3 build 1403
Git: 2.39.2 => /Library/Developer/CommandLineTools/usr/bin/git
Curl: 7.87.0 => /usr/bin/curl
macOS: 13.3.1-arm64
CLT: <IP_ADDRESS>.1.1679647830
Xcode: N/A
Rosetta 2: false

% brew doctor
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: You have unlinked kegs in your Cellar.
Leaving kegs unlinked can lead to build-trouble and cause formulae that depend on
those kegs to fail to run properly once built. Run `brew link` on these:
  gst-plugins-base

Verification

[X] My "brew doctor output" says Your system is ready to brew. and am still able to reproduce my issue.
[X] I ran brew update and am still able to reproduce my issue.
[X] I have resolved all warnings from brew doctor and that did not fix my problem.
[X] I searched for recent similar issues at https://github.com/Homebrew/homebrew-core/issues?q=is%3Aissue and found no duplicates.

What were you trying to do (and why)?
brew update && brew upgrade
There appears to be conflict between gstreamer and gst-plugins-base...
What happened (include all command output)?
To reproduce, install gstreamer and then try to install gst-plugins-base
==> Pouring gst-plugins-base--1.22.0_1.arm64_ventura.bottle.tar.gz
Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /opt/homebrew
Could not symlink bin/gst-device-monitor-1.0
Target /opt/homebrew/bin/gst-device-monitor-1.0
is a symlink belonging to gstreamer. You can unlink it:
  brew unlink gstreamer

To force the link and overwrite all conflicting files:
  brew link --overwrite gst-plugins-base

To list all files that would be deleted:
  brew link --overwrite --dry-run gst-plugins-base

Possible conflicting files are:
/opt/homebrew/bin/gst-device-monitor-1.0 -> /opt/homebrew/Cellar/gstreamer/1.22.2/bin/gst-device-monitor-1.0
/opt/homebrew/bin/gst-discoverer-1.0 -> /opt/homebrew/Cellar/gstreamer/1.22.2/bin/gst-discoverer-1.0
/opt/homebrew/bin/gst-play-1.0 -> /opt/homebrew/Cellar/gstreamer/1.22.2/bin/gst-play-1.0
Error: Could not symlink include/gstreamer-1.0/ges/ges-asset.h
Target /opt/homebrew/include/gstreamer-1.0/ges/ges-asset.h
is a symlink belonging to gstreamer. You can unlink it:
  brew unlink gstreamer

To force the link and overwrite all conflicting files:
  brew link --overwrite gstreamer

To list all files that would be deleted:
  brew link --overwrite --dry-run gstreamer

What did you expect to happen?
This makes it impossible to use gst-plugins-bad or gst-plugins-ugly for instance, as they depend on gst-plugins-base which depends on gstreamer
Step-by-step reproduction instructions (by running brew commands)
For instance,
# brew install gst-plugins-bad

@carlocab's suggestion solved my problem. However, I would have expected the "brew update && brew upgrade" go smoothly without this manual intervention :)

However, I would have expected the "brew update && brew upgrade" go smoothly without this manual intervention :)

Yes. That's why I haven't closed this issue and instead migrated it to the right place.

You shouldn't be able to install gst-plugins-{base,bad} anymore, but it seems that your very old checkout of Homebrew/core (Core tap last commit: 2 months ago) allows you to do it.

Increasingly I think formulary should refuse to ever load anything from homebrew/core unless HOMEBREW_NO_INSTALL_API is set. I think that would avoid a whole class of these sort of bugs.
Similarly, brew doctor should probably tell people who haven't set HOMEBREW_NO_INSTALL_API, HOMEBREW_DEVELOPER or run a dev-cmd to brew untapped homebrew/core and brew untap homebrew/cask


Document New Switch System.Windows.Forms.ServicePointManagerCheckCrl

Help us make content visible
-System.Windows.Forms.ServicePointManagerCheckCrl
-.NET 8 WinForms switch
-PictureBox
-PictureBox.Load

Describe the new article
In .NET 8, WinForms introduced a new switch called System.Windows.Forms.ServicePointManagerCheckCrl via https://github.com/dotnet/winforms/pull/8556. This switch is on by default and will set ServicePointManager.CheckCertificateRevocationList = true before creating a WebClient to load an image in PictureBox if WebClient is needed for loading. This change was made as it is considered best practice to set ServicePointManager.CheckCertificateRevocationList to true before creating WebClients or WebRequests so that revoked certificates are not accepted by WebClients or WebRequests as valid.
The behavior of PictureBox when loading an image should remain the same as before, however there is a rare case when it could fail which is if:
a) the certificate authority provides revocation only through a technology called CRL,
b) the client has not recently enough cached the relevant CRL, and
c) the client is operating on an egress-restricted network and the CRL location isn't on the egress allow-list.
There may be some other corner cases, and a mild performance hit, hence why this switch is introduced for user to have opportunity to opt out if they run into this, so this should be documented for their understanding.
This could go under 'see also' or 'remarks' section in https://learn.microsoft.com/en-us/dotnet/api/system.windows.forms.picturebox.load?view=windowsdesktop-7.0

@lonitra Is this considered a breaking change?

@lonitra Is this considered a breaking change?

The team decided to not mark this as a breaking change since there should be no change in behavior except in the rare case outlined above. If this case does end up getting hit, there is a work around, which we are trying to document here, but I suppose this could be considered as breaking change.

I think if the team decided not to have it as a breaking change, then it's fine as-is.


feat: make PodTemplateSpec more robust and less error prone

What this PR does / why we need it:
This PR makes strategic merge patch more robust and less error prone by preventing several problematic use cases:

users needing to restate the base manifest (generated by KGO) which is not known to them before hand.
With this PR, this won't be necessary anymore as. Users won't need to provide elements form base manifests.
So this:
apiVersion: gateway-operator.konghq.com/v1beta1
kind: DataPlane
metadata:
  name: konnect-example
spec:
  deployment:
    podTemplateSpec:
      spec:
        containers:
        - name: proxy
          image: kong/kong-gateway:3.6
          env:
            - name: KONG_ROLE
              value: data_plane
            ...
          volumeMounts:
          # We need to specify the cluster-certificate volume-mount because otherwise
          # strategic merge patch would merge its entry with provided
          # konnect-client-tls volume mount.
          - name: cluster-certificate
            mountPath: /var/cluster-certificate
          - name: konnect-client-tls
            mountPath: /etc/secrets/kong-cluster-cert/
            readOnly: true
        volumes:
        - name: cluster-certificate
        - name: konnect-client-tls
          secret:
            secretName: konnect-client-tls

becomes:
apiVersion: gateway-operator.konghq.com/v1beta1
kind: DataPlane
metadata:
  name: konnect-example
spec:
  deployment:
    podTemplateSpec:
      spec:
        containers:
        - name: proxy
          image: kong/kong-gateway:3.6
          env:
            - name: KONG_ROLE
              value: data_plane
            ...
          volumeMounts:
          - name: konnect-client-tls
            mountPath: /etc/secrets/kong-cluster-cert/
            readOnly: true
        volumes:
        - name: konnect-client-tls
          secret:
            secretName: konnect-client-tls

using Go API users could experience merging mutually exclusive fields e.g. when setting env vars: https://github.com/Kong/gateway-operator/blob/3876430e09e61edce58bd8464989e33236bd1872/pkg/utils/kubernetes/resources/strategicmerge_test.go#L752-L807
This PR fixes this as well. Users are not required anymore to restate the elements from the base manifest array as in e.g. https://github.com/Kong/gateway-operator/blob/3876430e09e61edce58bd8464989e33236bd1872/pkg/utils/kubernetes/resources/strategicmerge_test.go#L808-L870

this PR additionally catches previously uncaught errors like setting not fully spec's readinessProbe on a sidecar: https://github.com/Kong/gateway-operator/blob/36c58ab4dd9a449627e14381cf1fc63f362b9903/config/samples/dataplane-sidecar.yaml#L44-L46.
This now properly yields an error and is not silenced:
2024-05-10T15:00:17.681+0200 - ERROR - Reconciler error - {"controller": "dataplane", "controllerGroup": "gateway-operator.konghq.com", "controllerKind": "DataPlane", "DataPlane": {"name":"sidecar-example","namespace":"default"}, "namespace": "default", "name": "sidecar-example", "reconcileID": "ccf8917a-c101-479e-8b2b-c449fd51e743", "error": "could not build Deployment for DataPlane default/sidecar-example: failed creating Deployment for DataPlane sidecar-example: Deployment.apps \"dataplane-sidecar-example-4mxqs\" is invalid: spec.template.spec.containers[0].readinessProbe: Required value: must specify a handler type"}

Which issue this PR fixes
Related #128
Special notes for your reviewer:
Prior work: https://github.com/Kong/gateway-operator-archive/pull/1489/
PR Readiness Checklist:
Complete these before marking the PR as ready to review:

[ ] the CHANGELOG.md release notes have been updated to reflect significant changes

Moving this out of 1.4 as we have other priorities to complete for that milestone.