Hardware Model v2 - Ability to extend an existing board

Hardware Model v2, https://github.com/zephyrproject-rtos/zephyr/issues/51831 introduces a new scheme for boards.
A board.yml is used to describe meta data of the board, for example:
board:
  name: plank
  vendor: Zephyr
  socs:
  - name: soc1
    variants:
    - name: foo

Such a board allows users to build for:
cmake -DBOARD=plank/soc1
cmake -DBOARD=plank/soc1/foo

The enhancement proposal is to allow extending such a board in another folder.
This would allow out-of-tree users to re-use an existing board but extend it with an extra build variant.
A benefit is that it allows existing overlay's and config files to still be picked up for the new variant, but not having to change the core build variant.
One limitation of https://docs.zephyrproject.org/latest/hardware/porting/board_porting.html#board-extensions is the fact that once such an enhancement is added, it's not possible to build without the extension.
The enhancement issue provides the ability to extend the board with new variant, thus having the following benefit:

Clear to users when building for the upstream board, or when building for the extended variant
Applications can have overlays / conf files specific to the extra variant, while simultaneously reuse common overlays and conf files for the core board / SoC
Note, https://github.com/zephyrproject-rtos/zephyr/pull/71149 remove the merging of overlay and conf files, meaning that a variant created as an extend is no longer merged with base files. Thus it must be possible to describe when a variant want to apply base variant overlay and conf files. It must also be made very clear in the docs that doing so can result in side-effects like #70445 and #70283 if dts nodes are removed in the variant.
The current board extension feature suffers the same risk, but without highlighting the risk.
However, as this is an opt-in feature, it becomes the responsibility of the board extend author to ensure proper compatibility with samples that the extended board is supposed to work with.

Design idea:
Extend the board.yml with a new extend: <name> field, indicating the board which is being extended.
This will tell list_boards.py that this is not a new board, but a board which should be merged with the existing board definition.
board:
  extend: plank
  variants:
  - name: bar
    soc: soc1

This defines a new bar board variant which applies to an existing soc soc1 definition in the plank board.
Another use-case is to allow boards to be defined in a tree of sub-folders.
An example of such use-case are the qemu boards.
Those are individually defined in their own folder, thus they must each have a unique name, thus ending in situations like this:
-DBOARD=qemu_arc/qemu_arc_em
-DBOARD=qemu_nios2/qemu_nios2

where the arch is repeated for no apparent reason.
Supporting board extensibility will allow to keep qemu boards organized in sub-folders while at the same time present just a highlevel qemu board.
This will also make it easier to see all architectures supported with qemu, as those can now be listed as identifiers for the common board.
Design idea:
Highlevel qemu board:
# board.yml for qemu, no SoCs defined.
board:
  name: qemu

Extend the qemu board with SoCs:
# board.yml for qemu, no SoCs defined.
board:
  extends: qemu
  socs:
  - name: arc_em
  - name: arc_hs
    variants:
    - name: xip
  - name: arc_hs5x
  - name: arc_hs6x

and
board:
  extends: qemu
  socs:
  - name: nios2

Thus making it possible to build for:
-DBOARD=qemu/arc_em
-DBOARD=qemu/nios2

Note the difference between extending a board with a new SoC, and then extending the board with a variant related to a SoC defined in the core board definition.
Challenges:

BOARD_DIR is not as uniform, which means Kconfig.<board>, Kconfig, and Kconfig.defconfig must be allowed to be sourced from multiple locations.

As part of this implementation, please also address: https://github.com/zephyrproject-rtos/zephyr/pull/70619#discussion_r1536594893

A requirement for this being reintroduced is checking for files that have typos in the name as has been seen in boards which were ported to hwmv2. To do this, python code can be created that globs all board.yml files together so a list of boards and soc names can be generated, then a glob of all *.dts and *_defconfig files in the boards directory can be generated and checked to ensure that all filenames are valid.

Issue raised here about board.yml wrongly being named board.yaml and not working, would make sense to have checks in CI for various filenames in board addition PRs: https://github.com/zephyrproject-rtos/zephyr/issues/71240

@tejlmand your comment in https://github.com/zephyrproject-rtos/zephyr/issues/71113 pointed me to this issue.
I recently learned about the existence of Snippets and I was wondering if you had considered whether the functionality described above could be achieved via Snippets (I have not used them yet, so I'm not sure of the answer to this).
The design idea you proposed above appears to be hierarchical whereas the Snippets design is composable (the comparison almost reminds me of something like inheritance vs. composition). It got me curious if Snippets could be used to implement this, and if so, whether they might provide more flexibility due to the fact that they are composable by design.

I recently learned about the existence of Snippets and I was wondering if you had considered whether the functionality described above could be achieved via Snippets

Some use-cases can be covered by snippets, but not all.
So snippets and board extensions covers different use-cases.

Issue re-opened as #72857 was reduced in scope and thus only covered part of this (#69548) issue.


Control multiple locks using MQTT

Hi, I'm writing a script to control multiple locks via MQTT, but every ESP32 nuki_hub device seems to be subscribed to the same topics (nuki/#), so I can't control them individually. Is there an easy workaround for this?
Thanks.

Change the topic prefix under NUKI Configuration (it's called MQTT NUKI Smartlock Path).

Thanks a lot! It was as simple as that.


Add Declared License

Type: Incomplete
Summary:
Add Declared License
Details:
Adding BSD-3-Clause
Resolution:
https://github.com/golang/time/blob/6dc17368e09b0e8634d71cac8168d853e869a0c7/LICENSE
Affected definitions:

time 6dc17368e09b0e8634d71cac8168d853e869a0c7

@ae49 It looks like this has the Patents clause:
https://github.com/golang/time/blob/6dc17368e09b0e8634d71cac8168d853e869a0c7/PATENTS
https://github.com/golang/time/blob/master/PATENTS
Should this be updated to BSD-3-Clause AND OTHER? If you agree, I'll update the PR.

@capfei Agree! Thanks.


Error in Log

Hi, i receive these errors in my log since some days...
[17/03/2023, 11:09:18] [Easee] Token has been refreshed
[17/03/2023, 11:09:24] [Easee] SignalR has been reset
[17/03/2023, 11:09:24] [Easee] SignalR has been reset
[17/03/2023, 11:09:24] [Easee] Error while starting connection: AbortError: Failed to start the HttpConnection before stop() was called.
at HttpConnection.start (/usr/local/lib/node_modules/homebridge-easee/node_modules/@microsoft/signalr/src/HttpConnection.ts:148:35)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at HubConnection._startInternal (/usr/local/lib/node_modules/homebridge-easee/node_modules/@microsoft/signalr/src/HubConnection.ts:207:9)
at HubConnection._startWithStateTransitions (/usr/local/lib/node_modules/homebridge-easee/node_modules/@microsoft/signalr/src/HubConnection.ts:181:13)
[17/03/2023, 11:09:24] [Easee] Starting connection for live updates...
[17/03/2023, 11:09:24] [Easee] EHQYX6R7 cable lock state to true
[17/03/2023, 11:09:24] [Easee] EHQYX6R7 updated to ChargerOpMode Disconnected
[17/03/2023, 11:09:24] [Easee] Weiss disconnected
[17/03/2023, 11:09:24] [Easee] EHQYX6R7 OutputCurrent updated to 0
[17/03/2023, 11:09:24] [Easee] EHQYX6R7 DynamicChargerCurrent updated to 32
[17/03/2023, 11:09:24] [Easee] EHQYX6R7 ReasonForNoCurrent due to SecondaryUnitNotRequestingCurrent
[17/03/2023, 11:09:24] [Easee] EHQYX6R7 AuthorizationRequired updated to false
[17/03/2023, 11:09:24] [Easee] EHQYX6R7 MaxChargerCurrent updated to 20

How often has this error shown? and what version was this under? The error seems like the plugin handled it fine so no concern with seeing it in the log if it is a one off. This latest version will establish a new connection once a day, and close the old connection. Some of the recent beta version were not addressing this correctly.

Hello @valiquette,
i hope you are well?
I also get an error message in the jornalctl/log since a short time. Can you do anything with it?
Mai 21 08:52:35 Ak-SHS-1 homebridge[15114]: [Easee] Error while starting connection: FailedToNegotiateWithServerError: Failed to complete negotiation with the server: Error: {"message":"Forbidden"}: Status code '403' Mai 21 08:52:35 Ak-SHS-1 homebridge[15114]:     at HttpConnection._getNegotiationResponse (/usr/local/lib/node_modules/homebridge-easee/node_modules/@microsoft/signalr/src/HttpConnection.ts:346:35) Mai 21 08:52:35 Ak-SHS-1 homebridge[15114]:     at processTicksAndRejections (node:internal/process/task_queues:95:5) Mai 21 08:52:35 Ak-SHS-1 homebridge[15114]:     at HttpConnection._startInternal (/usr/local/lib/node_modules/homebridge-easee/node_modules/@microsoft/signalr/src/HttpConnection.ts:247:41) { Mai 21 08:52:35 Ak-SHS-1 homebridge[15114]:   errorType: 'FailedToNegotiateWithServerError' Mai 21 08:52:35 Ak-SHS-1 homebridge[15114]: } Mai 21 08:52:35 Ak-SHS-1 homebridge[15114]: [Easee] Error while starting connection: FailedToNegotiateWithServerError: Failed to complete negotiation with the server: Error: {"message":"Forbidden"}: Status code '403' Mai 21 08:52:35 Ak-SHS-1 homebridge[15114]:     at HttpConnection._getNegotiationResponse (/usr/local/lib/node_modules/homebridge-easee/node_modules/@microsoft/signalr/src/HttpConnection.ts:346:35) Mai 21 08:52:35 Ak-SHS-1 homebridge[15114]:     at processTicksAndRejections (node:internal/process/task_queues:95:5) Mai 21 08:52:35 Ak-SHS-1 homebridge[15114]:     at HttpConnection._startInternal (/usr/local/lib/node_modules/homebridge-easee/node_modules/@microsoft/signalr/src/HttpConnection.ts:247:41) Mai 21 08:52:35 Ak-SHS-1 homebridge[15114]:     at HttpConnection.start (/usr/local/lib/node_modules/homebridge-easee/node_modules/@microsoft/signalr/src/HttpConnection.ts:137:9) Mai 21 08:52:35 Ak-SHS-1 homebridge[15114]:     at HubConnection._startInternal (/usr/local/lib/node_modules/homebridge-easee/node_modules/@microsoft/signalr/src/HubConnection.ts:207:9) Mai 21 08:52:35 Ak-SHS-1 homebridge[15114]:     at HubConnection._startWithStateTransitions (/usr/local/lib/node_modules/homebridge-easee/node_modules/@microsoft/signalr/src/HubConnection.ts:181:13) { Mai 21 08:52:35 Ak-SHS-1 homebridge[15114]:   errorType: 'FailedToNegotiateWithServerError' Mai 21 08:52:35 Ak-SHS-1 homebridge[15114]: } Mai 21 08:52:39 Ak-SHS-1 homebridge[15114]: [Easee] Easee Platform finished loading
Regards
Nastras

This is usually a network issue of some sort, it will retry a few times. Is this happening on every restart?

The problem persists even after restarting homebridge several times.
I am surprised because I have not changed anything in my network.
Is this happening on every restart?
Yes 😅

Can you provide a token for me to look into this. Microsoft released update to signalR and they are working on new version so something could be up with this. The 403 error does seem different from network error.

I sent you a Whats App.
Has it arrived?

https://developer.easee.cloud/docs/integrations-30
https://developer.easee.cloud/changelog/signalr-uri-change
The plugin did not like the signalR change.
if you can confirm the latest version is ok, I'll close the issue

Hey @valiquette,
Everything works again. Thanks a lot! Good job!


Added automation page and some extra stuff to get a bit of a start

Codecov Report

Merging #3 (2b7a1b5) into main (011213a) will increase coverage by 28.57%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main       #3       +/-   ##
===========================================
+ Coverage   21.42%   50.00%   +28.57%
===========================================
  Files           5        8        +3
  Lines          14       22        +8
  Branches        1        1
===========================================
+ Hits            3       11        +8
  Misses         11       11

Impacted Files
Coverage Δ

src/index.tsx
0.00% <ø> (ø)

src/pages/home.tsx
100.00% <ø> (ø)

src/Portfolio.tsx
100.00% <100.00%> (ø)

src/components/ProjectCard.tsx
100.00% <100.00%> (ø)

src/data/projects.tsx
100.00% <100.00%> (ø)

src/pages/Automation.tsx
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 011213a...2b7a1b5. Read the comment docs.


SWARM-1634: MP Config module.conf duplicate modules

[x] Have you followed the guidelines in our Contributing document?
[x] Have you created a JIRA and used it in the commit message?
[x] Have you checked to ensure there aren't other open Pull Requests for the same issue?
[x] Have you built the project locally prior to submission with mvn clean install?

Motivation
Two module entries in module.conf
Modifications
Removed duplicate module in module.conf
Also fixed artifact being returned from package detector.
Result
No impact on product.

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

test this please

retest this please


XS✔ ◾ Ehienabulele-doc-fix-update

Final Documentation fixes and workshop content validation

@ehienabulele Image is available for testing. docker pull stakater/workshop-exercise:SNAPSHOT-PR-130-eb7654b1


Governance votes

Description
Exposes governance votes to core views. Closes #38.
Tests
root@07be9b19c28a:/terra# dbt test -s core__fact_governance_votes
16:25:51  Running with dbt=1.2.0
16:25:51  Found 52 models, 262 tests, 0 snapshots, 0 analyses, 599 macros, 2 operations, 0 seed files, 44 sources, 0 exposures, 0 metrics
16:25:51
16:26:28
16:26:28  Running 2 on-run-start hooks
16:26:28  1 of 2 START hook: terra.on-run-start.0 ........................................ [RUN]
16:26:28  1 of 2 OK hook: terra.on-run-start.0 ........................................... [OK in 0.00s]
16:26:28  2 of 2 START hook: terra.on-run-start.1 ........................................ [RUN]
16:26:30  2 of 2 OK hook: terra.on-run-start.1 ........................................... [SUCCESS 1 in 2.43s]
16:26:30
16:26:31  Concurrency: 4 threads (target='dev')
16:26:31
16:26:31  1 of 32 START test accepted_values_core__fact_governance_votes_blockchain__terra  [RUN]
16:26:31  2 of 32 START test accepted_values_core__fact_governance_votes_chain_id__phoenix_1  [RUN]
16:26:31  3 of 32 START test accepted_values_core__fact_governance_votes_vote_option_text__Yes__Abstain__No__NoWithVeto  [RUN]
16:26:31  4 of 32 START test accepted_values_core__fact_governance_votes_vote_weight__1 .. [RUN]
16:26:36  1 of 32 PASS accepted_values_core__fact_governance_votes_blockchain__terra ..... [PASS in 5.26s]
16:26:36  2 of 32 PASS accepted_values_core__fact_governance_votes_chain_id__phoenix_1 ... [PASS in 5.27s]
16:26:36  5 of 32 START test dbt_expectations_expect_column_values_to_be_between_core__fact_governance_votes_vote_option__4__1  [RUN]
16:26:36  6 of 32 START test dbt_expectations_expect_column_values_to_be_in_type_list_core__fact_governance_votes__inserted_timestamp__timestamp_ntz  [RUN]
16:26:36  4 of 32 PASS accepted_values_core__fact_governance_votes_vote_weight__1 ........ [PASS in 5.33s]
16:26:36  7 of 32 START test dbt_expectations_expect_column_values_to_be_in_type_list_core__fact_governance_votes_block_id__number  [RUN]
16:26:38  3 of 32 PASS accepted_values_core__fact_governance_votes_vote_option_text__Yes__Abstain__No__NoWithVeto  [PASS in 6.56s]
16:26:38  8 of 32 START test dbt_expectations_expect_column_values_to_be_in_type_list_core__fact_governance_votes_block_timestamp__timestamp_ntz  [RUN]
16:26:41  6 of 32 PASS dbt_expectations_expect_column_values_to_be_in_type_list_core__fact_governance_votes__inserted_timestamp__timestamp_ntz  [PASS in 4.86s]
16:26:41  9 of 32 START test dbt_expectations_expect_column_values_to_be_in_type_list_core__fact_governance_votes_blockchain__string__varchar  [RUN]
16:26:41  7 of 32 PASS dbt_expectations_expect_column_values_to_be_in_type_list_core__fact_governance_votes_block_id__number  [PASS in 4.81s]
16:26:41  10 of 32 START test dbt_expectations_expect_column_values_to_be_in_type_list_core__fact_governance_votes_chain_id__string__varchar  [RUN]
16:26:42  8 of 32 PASS dbt_expectations_expect_column_values_to_be_in_type_list_core__fact_governance_votes_block_timestamp__timestamp_ntz  [PASS in 4.23s]
16:26:42  11 of 32 START test dbt_expectations_expect_column_values_to_be_in_type_list_core__fact_governance_votes_proposal_id__number  [RUN]
16:26:42  5 of 32 PASS dbt_expectations_expect_column_values_to_be_between_core__fact_governance_votes_vote_option__4__1  [PASS in 5.59s]
16:26:42  12 of 32 START test dbt_expectations_expect_column_values_to_be_in_type_list_core__fact_governance_votes_tx_id__string__varchar  [RUN]
16:26:46  10 of 32 PASS dbt_expectations_expect_column_values_to_be_in_type_list_core__fact_governance_votes_chain_id__string__varchar  [PASS in 4.28s]
16:26:46  13 of 32 START test dbt_expectations_expect_column_values_to_be_in_type_list_core__fact_governance_votes_tx_succeeded__boolean  [RUN]
16:26:46  9 of 32 PASS dbt_expectations_expect_column_values_to_be_in_type_list_core__fact_governance_votes_blockchain__string__varchar  [PASS in 4.58s]
16:26:46  14 of 32 START test dbt_expectations_expect_column_values_to_be_in_type_list_core__fact_governance_votes_vote_option__number  [RUN]
16:26:47  11 of 32 PASS dbt_expectations_expect_column_values_to_be_in_type_list_core__fact_governance_votes_proposal_id__number  [PASS in 4.56s]
16:26:47  15 of 32 START test dbt_expectations_expect_column_values_to_be_in_type_list_core__fact_governance_votes_vote_option_text__string__varchar  [RUN]
16:26:47  12 of 32 PASS dbt_expectations_expect_column_values_to_be_in_type_list_core__fact_governance_votes_tx_id__string__varchar  [PASS in 4.63s]
16:26:47  16 of 32 START test dbt_expectations_expect_column_values_to_be_in_type_list_core__fact_governance_votes_vote_weight__number  [RUN]
16:26:51  13 of 32 PASS dbt_expectations_expect_column_values_to_be_in_type_list_core__fact_governance_votes_tx_succeeded__boolean  [PASS in 4.94s]
16:26:51  17 of 32 START test dbt_expectations_expect_column_values_to_be_in_type_list_core__fact_governance_votes_voter__string__varchar  [RUN]
16:26:51  14 of 32 PASS dbt_expectations_expect_column_values_to_be_in_type_list_core__fact_governance_votes_vote_option__number  [PASS in 4.98s]
16:26:51  18 of 32 START test not_null_core__fact_governance_votes__inserted_timestamp ... [RUN]
16:26:51  15 of 32 PASS dbt_expectations_expect_column_values_to_be_in_type_list_core__fact_governance_votes_vote_option_text__string__varchar  [PASS in 4.52s]
16:26:51  19 of 32 START test not_null_core__fact_governance_votes_block_id .............. [RUN]
16:26:51  16 of 32 PASS dbt_expectations_expect_column_values_to_be_in_type_list_core__fact_governance_votes_vote_weight__number  [PASS in 4.60s]
16:26:51  20 of 32 START test not_null_core__fact_governance_votes_block_timestamp ....... [RUN]
16:26:55  18 of 32 PASS not_null_core__fact_governance_votes__inserted_timestamp ......... [PASS in 3.71s]
16:26:55  21 of 32 START test not_null_core__fact_governance_votes_blockchain ............ [RUN]
16:26:55  19 of 32 PASS not_null_core__fact_governance_votes_block_id .................... [PASS in 3.72s]
16:26:55  22 of 32 START test not_null_core__fact_governance_votes_chain_id .............. [RUN]
16:26:55  17 of 32 PASS dbt_expectations_expect_column_values_to_be_in_type_list_core__fact_governance_votes_voter__string__varchar  [PASS in 4.60s]
16:26:55  23 of 32 START test not_null_core__fact_governance_votes_proposal_id ........... [RUN]
16:26:56  20 of 32 PASS not_null_core__fact_governance_votes_block_timestamp ............. [PASS in 4.56s]
16:26:56  24 of 32 START test not_null_core__fact_governance_votes_tx_id ................. [RUN]
16:26:58  22 of 32 PASS not_null_core__fact_governance_votes_chain_id .................... [PASS in 3.38s]
16:26:58  25 of 32 START test not_null_core__fact_governance_votes_tx_succeeded .......... [RUN]
16:26:58  21 of 32 PASS not_null_core__fact_governance_votes_blockchain .................. [PASS in 3.68s]
16:26:58  26 of 32 START test not_null_core__fact_governance_votes_vote_option ........... [RUN]
16:27:00  23 of 32 PASS not_null_core__fact_governance_votes_proposal_id ................. [PASS in 4.66s]
16:27:00  27 of 32 START test not_null_core__fact_governance_votes_vote_option_text ...... [RUN]
16:27:00  24 of 32 PASS not_null_core__fact_governance_votes_tx_id ....................... [PASS in 4.25s]
16:27:00  28 of 32 START test not_null_core__fact_governance_votes_vote_weight ........... [RUN]
16:27:03  26 of 32 PASS not_null_core__fact_governance_votes_vote_option ................. [PASS in 4.41s]
16:27:03  29 of 32 START test not_null_core__fact_governance_votes_voter ................. [RUN]
16:27:03  25 of 32 PASS not_null_core__fact_governance_votes_tx_succeeded ................ [PASS in 4.92s]
16:27:03  30 of 32 START test relationships_core__fact_governance_votes_block_id__block_id__ref_silver__blocks_  [RUN]
16:27:04  28 of 32 PASS not_null_core__fact_governance_votes_vote_weight ................. [PASS in 3.83s]
16:27:04  31 of 32 START test relationships_core__fact_governance_votes_tx_id__tx_id__ref_silver__transactions_  [RUN]
16:27:05  27 of 32 PASS not_null_core__fact_governance_votes_vote_option_text ............ [PASS in 5.20s]
16:27:05  32 of 32 START test unique_core__fact_governance_votes_tx_id ................... [RUN]
16:27:06  29 of 32 PASS not_null_core__fact_governance_votes_voter ....................... [PASS in 3.73s]
16:27:08  30 of 32 PASS relationships_core__fact_governance_votes_block_id__block_id__ref_silver__blocks_  [PASS in 4.91s]
16:27:09  31 of 32 PASS relationships_core__fact_governance_votes_tx_id__tx_id__ref_silver__transactions_  [PASS in 5.00s]
16:27:11  32 of 32 PASS unique_core__fact_governance_votes_tx_id ......................... [PASS in 5.78s]
16:27:11
16:27:11  Finished running 32 tests, 2 hooks in 0 hours 1 minutes and 19.75 seconds (79.75s).
16:27:11
16:27:11  Completed successfully
16:27:11
16:27:11  Done. PASS=32 WARN=0 ERROR=0 SKIP=0 TOTAL=32

Test passes, code looks good. great job!
LGTM


Wrong PSNR value by the in-place operator?

Hi, @apchenstu
Thank you for sharing this really great idea!
It's very helpful for me to develop other ideas related to Radiance Fields.
By the way, I just notice that you might have wrong PSNR value by the in-place operator(+=).
You've assigned the image loss variable loss to total_loss, and then increase it with the += operator.
It will modify the original image loss loss variable resulting in wrong PSNR; in fact, smaller than the true value.
You can check this at my colab.
Thank you,
Sangmin Kim.
https://github.com/apchenstu/TensoRF/blob/17deeedae5ab4106b30a3295709ec3a8a654c7b1/train.py#L190-L198,

Hi, I think this only affects training PSNR, right?

Hi, @Derry-Xing
Yes, it is not related to the quality of the output images but only for the output PSNR values.
I just want to check the reported PSNR at the paper is correct.

how come it affects the PSNR, the calculation of PSNR is related to this
 PSNRs.append(-10.0 * np.log(loss) / np.log(10.0))
it's about the variable loss, instead of total_loss, or did I miss something?

how come it affects the PSNR, the calculation of PSNR is related to this
 PSNRs.append(-10.0 * np.log(loss) / np.log(10.0))
it's about the variable loss, instead of total_loss, or did I miss something?

At line 190, total loss shares the same memory with loss.
Then any in-place operation on total_loss will modify the image loss term(loss in this code).

Thx, my mistake ^_^

how come it affects the PSNR, the calculation of PSNR is related to this
 PSNRs.append(-10.0 * np.log(loss) / np.log(10.0))
it's about the variable loss, instead of total_loss, or did I miss something?

At line 190, total loss shares the same memory with loss. Then any in-place operation on total_loss will modify the image loss term(loss in this code).

thx, now I change it to
psnrloss = loss.clone().detach().item()
...
PSNRs.append(-10.0 * np.log(psnrloss ) / np.log(10.0))

is it correct now?

how come it affects the PSNR, the calculation of PSNR is related to this
 PSNRs.append(-10.0 * np.log(loss) / np.log(10.0))
it's about the variable loss, instead of total_loss, or did I miss something?

At line 190, total loss shares the same memory with loss. Then any in-place operation on total_loss will modify the image loss term(loss in this code).

thx, now I change it to
psnrloss = loss.clone().detach().item()
...
PSNRs.append(-10.0 * np.log(psnrloss ) / np.log(10.0))

is it correct now?

Yes it seems good,
But i think you can just change the in-place operator; i.e. total_loss = total_loss + …


Add auto merge

@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/fenicsprecice-feedstock#2.


Set default timeouts to HTTP API requests

Because of a DNS issue these are currently timing out, causing Gunicorn to spin out of control.
While we need to fix the DNS issue, we certainly should have sensible timeouts on these requests to begin with.

@JayH5 & @jerith a review would be nice, tiny change.

:+1: assuming you got them all. :-)


[Request] Facebook Bridge: Add option to remove timestamp

Hey, so I've got feeds being generated from Facebook Pages, and the timestamp isn't really neccessary in the post, even if it were needed, the way its placed doesn't display well and makes the feed messy.
Wanted to see if there was a way to add a checkbox on the feed bridge generator to just remove the timestamp from the feed.
Attached a pciture showing what I mean

I'm not sure I understand your request correctly. Is the timestamp part of the content?
Can you share a sample query for testing?
The screenshot you provided doesn't look like any format provided by RSS-Bridge. How does it look if you look at the HTML format generated by RSS-Bridge?

My bad! I wasn’t clear, yes the content being brought in from Facebook pages.
The shot I sent was from a feed reader
Here is a shot of the HTML output

The page I queried was eyewatchbendigo (if you want to test on your own instance) through the default Facebook bridge. It seems to be importing the Facebook time stamp as part of the page username.

Thanks, now it's clear to me. It is also strange that your version shows the htmlspecialchars_decode(...) in the user name. Something is broken there (but it looks fine in master as far as I can tell).
Anyway, have you tried the second Facebook bridge?
It supports more features and should produce better results overall.
This looks much better to me:
?action=display&bridge=FB2&u=eyewatchbendigo&format=Html

Fantastic, I gave that a whirl and it looks good, I wasn't sure which one was properly supported so I stuck with the one provided by default.
My setup is pretty stock standard, just running on a cPanel instance, so I'm unsure what could be causing it, potentially a PHP extension I have on or am forced to use by my host, if you need to investigate more, let me know what you need and I'll help get you logs/data, this tool is a lifesaver for me so I'm totally appreciative.

Fantastic, I gave that a whirl and it looks good, I wasn't sure which one was properly supported so I stuck with the one provided by default.

Thanks for the feedback. I'm glad it works for you.

I'm unsure what could be causing it

It is actually caused by the bridge. It hasn't been updated for a long time and thus slowly decays until it stops working eventually. The other bridge is newer and uses different ways to build the feeds. It should be used whenever possible. The old bridge is kept because many users have hundreds of feeds that still use it.
Closing because I think this is solved.


Recall mu4e--start interactively inside +mu4e-lock-start

This seems to fix #5689

mu4e--start should be called interactively, as it is done in =mu4e.
It fixes a problem when sometimes mu4e does not open its main view.

This doesnt really fix my issue, close it for now.


Adds Pomegranate proto files and builder

This PR adds Pomegranate proto files, module and builder.
It also adds vscode and intellij folders to .gitignore to not be tracked by git.

LGTM :+1:


Good job

This looks good so far :) Keep it up and have a nice day!

Thank you for your approval.

The program is ready for use, and code-related tests will take some time to release.


Version incompatibilities with spark-testing-base

Some versions of spark-testing-base are not compatible with sscheck, resulting in non serializable exceptions for tests using checkpointing. The problem is that some versions of spark-testing-base use a version of "io.github.nicolasstucki" %% "multisets" defining an implicit value config that causes this serialization problem (see e.g. https://github.com/holdenk/spark-testing-base/blob/7d4077efacd5ed454aededcf9278ddd7953dad80/src/main/1.3/scala/com/holdenkarau/spark/testing/JavaStreamingSuitebase.scala). This is weird because we only use com.holdenkarau.spark.testing.TestInputStream as a transient val, maybe it has something to do with the fact that that value is implicit.
Anyway a simple solution is copying the classes to this project, thus removing the dependency and effectively freezing it

If looks like the culprit should be https://github.com/juanrh/sscheck/blob/6b6020ec9f2dfbe54462a545564dbd153143fceb/src/main/scala/es/ucm/fdi/sscheck/gen/Batch.scala instead.
import scala.collection.immutable.{HashBag=>Bag}
...
  implicit val config = Bag.configuration.compact[A]

  override def toSeq : Seq[A] = points
  def toBag : Bag[A] = Bag(points:_*)
...

That variable config should be transient. The multisets library has known problems with serialization https://github.com/nicolasstucki/multisets/issues/9, Note Batch.toBag and PDStream.toBagSeq are not used anyway, so I'll remove them too

released new version 0.2.3 without those dependencies, all tests passing in Jenkins


Getting the XHR instance

Hmm, I'm currently implementing a progress bar with xhr.upload. I just checked the docs, but I couldn't squeeze out any info at all. Is the instance exposed with the latest versions?

It is not currently possible to access the XHR instance.

This would be solved with #82

I think this should be a different issue. While there are cases where only the onProgress is needed (addressed by #96), there are other cases where an application need to access the XHR instance to perform other operations.


Search song lyrics on cli

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].
In raising this pull request, I confirm the following (please check boxes):

[ ] I have read and understood the contributors guide.
[ ] I have checked that another pull request for this purpose does not exist.
[ ] I have considered, and confirmed that this submission will be valuable to others.
[ ] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
[ ] I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

[ ] I have never used the project.
[x] I have used the project briefly.
[ ] I have used the project extensively, but have not contributed previously.
[ ] I am an active contributor to the project.

{pull request content here}

Please don't change formatting of pre-existing code 🙂

How to set up as per PEP-8 in Pycharm, can you help me with that?

It should be enabled by default. Just change the project specific indentation.


spelling correction in main.lua

While messing with the example I found this spelling error which tripped me up

Thanks!


noti: init at 3.1.0

Motivation for this change
Add a new, works-out-of-the-box notifier
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions: Ubunt17.04

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

First-time submitter! let me know if I should move this package somewhere else, or if anything is wrong.

@srhb -- Please take a look! I'm a bit iffy on the proper way to set up documentation -- I think the postInstall is correct (as in "works on my machine"), but I'm not sure if there's a better way to do this.
I'm also a bit iffy on go in general, but luckily nix makes it easy to figure out the build process. : )

noti, especially, has a decently sized Makefile which originally lead me to believe it had a non-standard build. This repo doesn't seem to output the man pages, anyhow, and they come pre-build in the repo.

Thanks@stites. One last thing: Please squash this into one commit following the rules at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes (ie. "noti: init at 3.1.0") or two commits, one for this addition and one "add stites to maintainer list" :)
Thanks a lot for your effort, and welcome to the nixpkgs maintainers list. :smiley:

Thank you for the guidance, this was a lot of fun!


Invalid Link

From version 9.30 of the Mobility service agent, you need servicing stack update (SSU) and SHA-2 update installed on Windows 2008 SP2 machines. ISHA-1 isn't supported from September 2019, and if SHA-2 code signing isn't enabled the agent extension won't install/upgrade as expected. Learn more about SHA-2 upgrade and requirements.
Here the link is invalid:  Learn more about SHA-2 upgrade and requirements.
With the notice:
Sorry, the page you’re looking for can’t be found.
You may have clicked an old link or the page may have moved.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bc12f304-5826-fb32-1728-5e43f1b05d8a
Version Independent ID: 7cc3d5a7-9b0e-dd6b-3b34-2036219f5bd6
Content: Support matrix for VMware/physical disaster recovery in Azure Site Recovery - Azure Site Recovery
Content Source: articles/site-recovery/vmware-physical-azure-support-matrix.md
Service: site-recovery
GitHub Login: @rayne-wiselman
Microsoft Alias: raynew

@v-harrishe Thank you for catching this. We will have this investigated and update the thread.

@v-harrishe Thank you for catching this. We will have this investigated and update the thread.

This is fixed. The fix should merge into our docs later on today. Thx

This is fixed. The fix should merge into our docs later on today. Thx

@rayne-wiselman Thanks a lot for fixing it. 👍
@v-harrishe Closing this issue for now. If there are further questions regarding this matter or questions or feedback on the referred documentation, please do let us know and we will gladly continue the discussion.

@rayne-wiselman Thanks a lot for fixing it. 👍
@v-harrishe Closing this issue for now. If there are further questions regarding this matter or questions or feedback on the referred documentation, please do let us know and we will gladly continue the discussion.


Replace debug console with snackbar

There's a snackbar component in Angular that does the temporary pop-up thing.
The ugly debug console should be replaced with this.

Useful links:

https://stackoverflow.com/questions/49393099/how-to-show-several-snackbar-without-overlapping
https://www.coditty.com/code/angular-material-display-multiple-snackbars-messages-in-sequence

This is now done!


Enhance coverage-report.xsl to be able to specify css location

Hello,
as this has been done for format-xspec-report.xsl, we should be able to specify the CSS location when generating report.

Realized in #194


Allow Producer / Consumer Settings To Be Configured Dynamically

Currently the librdkafka settings for the both the consumer and the producer are hardcoded as constants in the common component and are set to our particular needs.  We need to come up with a way to allow the user to specify the consumer and producer configuration options they want.

Closing all issues as the project is going to be archived. If it is still valid create a new issue in https://github.com/knative-sandbox/eventing-kafka


Add IFF_LOWER_UP, IFF_DORMANT, IFF_ECHO constants to Android

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.
Please see the contribution instructions for more information.

@bors r+

:pushpin: Commit f6e0a37551660d7f5d7c2d53587f0262fe5a6bae has been approved by Amanieu

:hourglass: Testing commit f6e0a37551660d7f5d7c2d53587f0262fe5a6bae with merge 7a7138d0877e99d1730a326a7da91d8a2a332c46...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing 7a7138d0877e99d1730a326a7da91d8a2a332c46 to master...


[ROCm][TVMC] Add ROCm to the TVMC driver

Enable ROCm as device for TVMC.

Looks like I missed one of my local changes, to add session.rocm call.  Will push update to the PR
cc: @leandron

No this is a very annoying flaky test that has been happening a lot recently. Please try kicking the CI again.

Thanks, I may need assistance in restarting it.  I don't use this jenkins enough to know how to restart.

You can do rebase and push, this will cause a new CI job. I also look for a way to retrigger the CI myself.


Host UI

Done When: a host can log in and do everything they need to do through our GUI

4hrs: built seating functionality in HostUI


Enhance in_place construction

The current implementation required ad least a move-constructor for
in-place construction.
This made it impossible to directly, create an optional of a type
without copy and move operators.
A workaround is using the variadic emplace function, but it requires to
construct the object in two steps.
std::optional does not require any copy or move operation for in-place
construction

Thanks for your contribution.
I'll tend to CASE( "make_optional: Allows to in-place copy-construct optional from arguments (C++11)" ) that appears similar to the test you did update.

Think all is taken care of now and the PR can be closed now.

thank you @martinmoene
can I ask if there are any plans for a new release?

@fekir A new release seems in order. Will address that in the coming days.

Released optional lite version 3.5.0.


use latest milmove-cypress image: MB-6647

Description
We have a repo circleci-docker that contains a build of cypress for our integration tests. When we update any packages in circleci-docker, we should pull the latest image of into mymove.
the circleci-docker pr: https://github.com/transcom/circleci-docker/pull/86
Reviewer Notes
Did I get the correct hash from Dockerhub image?
Setup
the integration tests should run w/o an issue on circle
Code Review Verification Steps

[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Messages

:book:
:link: MB-6647

  Generated by :no_entry_sign: dangerJS against 2a1a4b14ddafefbc1a99d8f5fc22060775e0f591


ci: refactor scan-images.yaml workflow

This commit refactors the scan images workflow to use the aquasecurity/trivy-action Github action instead of the kubeflow-ci/scripts/images/scan-images.sh. This to make the workflow faster and more configurable based on the action's inputs. This commit also applies a mitigation for the upstream issue aquasecurity/trivy-action#389, as the number of DB download requests would be reduced (each image is scanned independently in its own Github runner).
Testing instructions

Go to Actions
Click on "Scan images"
Run the workflow using the workflow dispatch from branch KF-6285-fix-1080
See results

NOTE: there are a couple images that cannot be scanned, either because of the image does not exist, or because there is an issue accessing a binary/library. These issues must be resolved separately.

Looks good, let's make sure this passes before merging: https://github.com/canonical/bundle-kubeflow/actions/runs/11294054672

It should be https://github.com/canonical/bundle-kubeflow/actions/runs/11294054672 rather, and it passed (except for the expected issues). Merging now (:


KYLIN-4811 Support cube level configuration for BuildingJob

Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have create an issue on Kylin's jira, and have described the bug/feature there in detail
[ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
[ ] Compiling and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If this change need a document change, I will prepare another pr against the document branch
[ ] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

Add spark-conf

Build a segment

Codecov Report

:exclamation: No coverage uploaded for pull request base (kylin-on-parquet-v2@2db2800). Click here to learn what that means.
The diff coverage is n/a.

@@                  Coverage Diff                   @@
##             kylin-on-parquet-v2    #1472   +/-   ##
======================================================
  Coverage                       ?   24.27%
  Complexity                     ?     4601
======================================================
  Files                          ?     1130
  Lines                          ?    63844
  Branches                       ?     9430
======================================================
  Hits                           ?    15497
  Misses                         ?    46742
  Partials                       ?     1605

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2db2800...264d702. Read the comment docs.

LGTM

I will merge this patch.


Run generative model on sample data locally

In a notebook, for example, load the CryptoPunks dataset and import our chosen generative model. Process the data so that the generative model runs (locally) on the sample data. Our chosen generative model may already include some scripts for processing image datasets into a usable format.

An example of a similar workflow for imagenette and a classification model from the fast.ai library is shown here https://github.com/AlgoveraAI/onshore/blob/main/notebooks/3-train-imagenette.ipynb


Fix No_Local

Codecov Report
Patch coverage has no change and project coverage change: +0.10 :tada:

Comparison is base (b424a43) 51.14% compared to head (84e6a80) 51.24%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
+ Coverage   51.14%   51.24%   +0.10%
==========================================
  Files         120      120
  Lines       36266    36279      +13
==========================================
+ Hits        18547    18591      +44
+ Misses      17719    17688      -31

Impacted Files
Coverage Δ

src/sp/transport/mqtt/broker_tcp.c
0.87% <ø> (ø)

src/sp/transport/mqtts/broker_tls.c
0.57% <0.00%> (-0.01%)
:arrow_down:

src/sp/transport/mqttws/nmq_websocket.c
2.45% <0.00%> (-0.02%)
:arrow_down:

... and 20 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Update proxy-blocker example

Support for PAC-style proxy scripts is going away in Firefox 71 as proxy.register, proxy.unregister and proxy.onProxyError are removed (see bugzilla).
The proxy-blocker example should be updated to no longer use the removed API, and instead use the recommended proxy.onRequest API.
Related to Webextenstions-examples 410
Acceptance criteria

[x] Example has been updated
[ ] PR has been created
[ ] Changes have been approved and merged

It turns out that Richard Bloor has already created the updated. The only reason I haven't closed the issue is that I'm waiting for the PR, which I will review and merge. I have also reduced the points to reflect the fact that I'm not updating the code, only reviewing it.

@irenesmith What's the link to the PR for this?


Reverted back the fill missing timestamp to make the behavior aligned with non-monthly data.

LGTM - why don't we do a simple revert though?

LGTM - why don't we do a simple revert though?

To make monthly work on non-filling situation.

Codecov Report
Base: 95.15% // Head: 94.84% // Decreases project coverage by -0.30% :warning:

Coverage data is based on head (a3d8c49) compared to base (d171294).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   95.15%   94.84%   -0.31%
==========================================
  Files          22       22
  Lines         764      757       -7
==========================================
- Hits          727      718       -9
- Misses         37       39       +2

Flag
Coverage Δ

unittests
94.84% <100.00%> (-0.31%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ricks/automl_runtime/forecast/pmdarima/training.py
96.00% <100.00%> (-2.79%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


feat(connector-besu): add getBalance web service

Fixes #1066
@petermetz Mr.Tyler helped me with the test cases!

@Leeyoungone Thank you for the updates, last thing to do is resolve the merge conflicts. :-)


Turn on opinion mining by default

Consider renaming IncludeOpinionMining to DisableOpinionMining

OM only works for English language so we can't enable it by default just yet.
Ticket with service team has been opened.
Moving work to next milestone

Closing issue as currently this will be a breaking change. If there is a parity between language support in analyze sentiment and OM we can reopen this issue and revisit the decision


Signature verification in test

Added a test case to validate digital signature. It is important to test if message has been compromised or not.
assert was not required as verify_signature method will automatically raise BadSignatureError if signature is invalid

We specifically avoid testing signature check as there is no facility created for that yet.
also, tests should not raise random exceptions
I would not accept that

We specifically avoid testing signature check as there is no facility created for that yet
You are already generating digital signature and test case only checks if its length of it is correct or not but doesn't verify it. I still believe verification should be there

The function verify_signature itself has been designed in this way. To runs without error if signature is correct otherwise it raise BadSignature error. Ideally it should return True or False.
Also, internally this function has been used directly without any try catch you can see one such usage here it will "raise some random exception" speaking in your language


Add an AES encryption and decryption example

If you want, I'd accept a PR from you with the suggested changes :)

If someone could review the example, that would be appreciated!

I'll take a good look and fix/add to it when I have time! I have yet to upgrade to the newer version of the registry (was using the "take 1" re-implementation).

Apologies for hijacking this pull request. I used your example code to encrypt a message with aes 256 and md5
// Key must be multiple of block size (16 bytes).
    var key = new Digest("MD5").process(
        utf8.encode("correcthorsebatterystaple"));
    // Can be anything.
    var message = "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed d o eiusmod tempor incididunt ut labore et dolore magna aliqua.";
    // The initialization vector must be unique for every message, so it is a
    // good idea to use a message digest as the IV.
    // IV must be equal to block size (16 bytes).
    var iv = new Digest("MD5").process(utf8.encode(message)).sublist(0, 16);
    // The parameters your cipher will need. (PKCS7 does not need params.)
    CipherParameters params = new PaddedBlockCipherParameters(
        new ParametersWithIV(new KeyParameter(key), iv), null);
    print("Message: \n$message");
    ////////////////
    // Encrypting //
    ////////////////
    // As for why you would need CBC mode and PKCS7 padding, consult the internet
    // (f.e. http://www.di-mgt.com.au/properpassword.html).
    BlockCipher encryptionCipher = new PaddedBlockCipher("AES/CBC/PKCS7");
    encryptionCipher.init(true, params);
    Uint8List encrypted = encryptionCipher.process(utf8.encode(message));
    print("Encrypted: \n" + HEX.encode(encrypted));

It does decrypt well with your decryption method. But I tried to decrypt it with openssl with
echo "$encrypted" | openssl enc -d -aes-256-cbc -k $key -a -md md5
encrypted being the hexa encrypted message
But I get a bad magic number error. Am I mising something ?

I have no idea, tbh. Did that command work with an openssl encrypted message? (f.e. echo adds a newline, not sure if that could break things -- try printf)
It's quite possible that there is an issue with our implementation that we're not aware off. Did you try decrypting with BouncyCastle, f.e.?

I have just tried with javax.crypto library and it is the same, so it must be something else I haven't figured out yet, but the problem does not lie with with PointyCastle.

@Cretezy AES result is different with Java.
`public class AESUtil {
private static String AES_ALGORITHM = "AES/ECB/PKCS5Padding";
private static String CHAR_ENCODING = "UTF-8";

public static byte[] encrypt(byte[] data, byte[] key) {
	try {
		SecretKeySpec secretKey = new SecretKeySpec(key, "AES");
		byte[] enCodeFormat = secretKey.getEncoded();
		SecretKeySpec seckey = new SecretKeySpec(enCodeFormat, "AES");
		Cipher cipher = Cipher.getInstance(AES_ALGORITHM);
		cipher.init(Cipher.ENCRYPT_MODE, seckey);
		byte[] result = cipher.doFinal(data);
		return result; // 加密
	} catch (Exception e) {
		e.printStackTrace();
	}
	return null;
}

public static byte[] decrypt(byte[] data, byte[] key) {
	try {
		SecretKeySpec secretKey = new SecretKeySpec(key, "AES");
		byte[] enCodeFormat = secretKey.getEncoded();
		SecretKeySpec seckey = new SecretKeySpec(enCodeFormat, "AES");
		Cipher cipher = Cipher.getInstance(AES_ALGORITHM);
		cipher.init(Cipher.DECRYPT_MODE, seckey);
		byte[] result = cipher.doFinal(data);
		return result; // 加密
	} catch (Exception e) {
		e.printStackTrace();
	}
	return null;
}

public static String encrypt(String data, String key) {
	try {
		byte[] valueByte = encrypt(data.getBytes(CHAR_ENCODING),
				key.getBytes(CHAR_ENCODING));
		return new String(Base64.encode(valueByte, Base64.DEFAULT));
	} catch (Exception e) {
		e.printStackTrace();
	}
	return null;
}

public static String decrypt(String data, String key) {
	try {
		byte[] originalData = Base64.decode(data.getBytes(), Base64.DEFAULT);
		byte[] valueByte = decrypt(originalData,
				key.getBytes(CHAR_ENCODING));
		return new String(valueByte, CHAR_ENCODING);
	} catch (UnsupportedEncodingException e) {
		e.printStackTrace();
	}
	return null;
}

public static String parseByte2HexStr(byte buf[]) {
	StringBuffer sb = new StringBuffer();
	for (int i = 0; i < buf.length; i++) {
		String hex = Integer.toHexString(buf[i] & 0xFF);
		if (hex.length() == 1) {
			hex = '0' + hex;
		}
		sb.append(hex.toUpperCase());
	}
	return sb.toString();
}

}
`
What went wrong? thank you

my code in java is exactly the same as yours. but I still cannot find the way to configure code in dart to work as java yet. the result is different.

I'm archiving this repo as per #239 (see the issue for more info).


[Advice] - how do you auto add your plugins?

So when I develop using this package I will sometimes need to add a new plugin, for e.g.:
php artisan adminlte:plugins install --plugin=datatables
With database migrations, you do a git pull and then artisan migrate and you're done.
What do you do for adding new plugins & things like that, so that you don't forget & the task is done automatically? Another migration?

A few notes:

So when I develop using this package I will sometimes need to add a new plugin, for e.g.:
php artisan adminlte:plugins install --plugin=datatables

That command is only useful to install the set of plugins that comes with the AdminLTE package, you may check the list of those plugins as explained here. The plugins are installed inside the public/vendor folder. So, for other plugins that do not come with the AdminLTE package you will need to manually copy the files inside the public/vendor folder. However, if you are planning to use plugins from a CDN you may avoid any local installation inside the public/vendor folder, since the plugins will now be delivered from remote servers.
Now, once a plugin is installed inside the public/vendor folder, or you have chose to use a CDN, you need to setup it inside the adminlte.php config file, as explained here. On the plugin configuration you may chose to activate it to be included in all pages. If you do not need a plugin to be available in all your blade files, then set that option to false and use the directive @section('plugins.PluginName', true) at the top of the blade files that requires the plugin.

I'm not really sure why are you using those commands, git pull is used to get changes from a remote repository and php artisan migrate is used to run database migrations.

What do you do for adding new plugins & things like that, so that you don't forget & the task is done automatically? Another migration?

Not sure if there is any option to automate the procedure. In my case, I just follow the local installation option manually.

Thanks for your input.
I prefer not to use CDNs as I like to minimise points of failure, plus I keep a tight CSP policy.
I should have explained my workflow better - I want to implement a CICD methodology at some point, but for now:

I use my laptop for local development
then commit & merge to master branch & push to my git repository
then log in to the production server
git pull
artisan migrate
... and have forgotten to add plugins as required, plus maybe other tasks that need running, such as Laravel/Scout index updates, custom commands that need running etc etc

I have not decided how to automate any additional steps, but feel that if I can hook them into the migrate command, it might be better as that is a task I will always run when updating production.

If the public folder of your Laravel project is under the version control and all your plugins files resides there, then when you follow the procedure to add/configure a new plugin, just commit the new changes and files. In that case, git pull should be enough.
Usually, I follow the previous procedure without any problems. I only execute php artisan migrate when there is a database change, and also composer install when the packages dependencies are updated (i.e. there are changes uploaded to the composer.lock file).


Refreshing jars

Is there a way to refresh jars once loaded?  I am working in clojure, and it would be super helpful if there were an easy way to reload the jar to reflect the changes I am making on the native clojure side.
Thanks!

You should be able to do this from Notebook -> Language manager
There will be a tab for each language plugin that has been loaded in your notebook.
Typically there is a Reset environment button that will clear things. Also, if you have your jar listed in the class path box under this tab, you should be able to press Set next to that box to reload everything in the classpath.


Lodash v5

Lodash v5 is in the works.
@jdalton if you feel like sharing the changes happening in v5 (either all at once, or as they are imagined), we could prepare codemods for this release and make it much smoother for the users.
I've been a bit ouf of the game recently, but I'm sure I can help somehow (or other people hoping for a smooth transition too) by writing the appropriate transformations before v5 is released. Let me know what you think ;)

At the moment things are in the deconstructed state. The sledge hammer is out and I'm busting down walls. So it's a bit of a mess. As things start to shape up I'll post. I'm making some cuts to methods that are covered in ES2015+ (dropping bind, partial, assign, isArray, now and some others).


Workload Endpoint (routes, etc) for a pod being deleted a few minutes after pod creation

We have seen a few cases now where a pod is created in Kubernetes, seems to be working, and then a minute or more later, Calico deletes the WEP and route from underneath the pod, leaving the pod up and running but without any networking.  This last time we saw this we collected the /var/log/calico/* logs and /var/log/syslog, which seem to show that the pod and networking were set up correctly, and then about 17 minutes later calico removed the WEP and route (felix log and syslog specifically).  I'll attach the log files once I get them (soon), here is the IP and pod info:
dashmpp-head-0                1/1       Running   0          23h       <IP_ADDRESS>    xxxxxxxx
Expected Behavior
Pod shouldn't have networking pulled out from under it
Current Behavior
Pod stays there, but networking is removed
Steps to Reproduce (for bugs)
Can't reproduce at will, but have seen this twice in a few days.  The first time it was about 1 minute after pod creation that the networking was deleted from the pod
Context
Makes the pod unusable
Your Environment

Calico version: 2.1.5 (calico-node managed by systemd)
Orchestrator version: kubernetes 1.5.6
Operating System and version: Ubuntu 16.04.2

Here are the logs
calico.zip

This sounds like it could be related to or a result of https://github.com/projectcalico/libcalico/issues/189.
That issue causes the policy controller to remove the container ID metadata from a given WEP, which means the CNI plugin is unable to determine whether or not the DEL call it has received from the kubelet is or the active container or an older exited container.
Will need to look at the logs to make sure, but I have a strong hunch that's what it happening here.  If so, the fix is in master and will be available in Calico v2.6.0.

If it is related to https://github.com/projectcalico/libcalico/issues/189  then is the fix to get the newest (master) policy-controller?  or do we need a new felix/calico-node and/or CNI as well?

The fix would be to use the master version of the policy controller AND the master version of Felix (in calico/node:master).  If that doesn't fix this issue then I suspect it is something other than what I linked above.
I wouldn't recommend running those in production until we release Calico v2.6.0 which will be this month.

Is there a way you can verify if this is the same problem based on the logs I provided?

@bradbehle Just got around to looking through those logs.
It looks to be a similar but different type of bug in the CNI plugin.  I've proposed a fix here: https://github.com/projectcalico/cni-plugin/pull/383

@caseydavenport Thanks.  Can this fix make it in to Calico 2.6.0?  We are hitting it fairly often and need it ASAP

@bradbehle yep this will go into v2.6.0

Fix for this was merged in https://github.com/projectcalico/cni-plugin/pull/383.
Cutting v2.6.0-RC2 tonight which will include the fix if you'd like to try it out.  Thanks @bradbehle!


Update rollup and rollup plugins & create rollup.config.js and use rollup CLI & generate lozad.es.js & delete build.js (#120)

Update rollup and rollup plugins & create rollup.config.js and use rollup CLI & generate lozad.es.js & delete build.js

#120

You need to install babel-plugin-transform-object-rest-spread https://babeljs.io/docs/en/babel-plugin-transform-object-rest-spread to use lozad.es.js in the es format in other projects.

will be glad if someone else can review the PR as well, considering the modifications in code and config


Implement FusedIterator for all applicable iterators

See https://doc.rust-lang.org/std/iter/trait.FusedIterator.html
"Calling next on a fused iterator that has returned None once is
guaranteed to return None again. This trait should be implemented by
all iterators that behave this way because it allows optimizing
Iterator::fuse."

Sounds good either way, but is there any measured performance improvement?

@rzumer no measurable performance uplift.

Can you please rebase and land it?


Policy Scope

Please clarify. Using "-IncludeUnifiedGroupRecipients" and "-ManagedByFilter" will only target Office 365 Groups, correct? So if we already have an EAP for User Mailboxes we would create an additional one for Office 365 Groups?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 96002890-7e35-a0ab-a849-d94fef254fa8
Version Independent ID: 2c4105db-b713-4829-393e-de355c5c60d4
Content: Choose the domain to use when creating Office 365 Groups
Content Source: Office365-Admin/create-groups/choose-domain-to-create-groups.md
Service: o365-administration
GitHub Login: @dianef77
Microsoft Alias: dianef

@toddjohnson39 - Thank you for pointing this inquiry.
I will get this issue over to the o365ITPro writing team for investigation.
Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

Hello @toddjohnson39 This is only applicable on Office 365 groups and if you want to create EAP for Office 365 group, then this doc can help you set this up.

@toddjohnson39 - Did @joinimran resolve your issue?

@toddjohnson39 - We appreciate any feedback you can provide to make the content in the Microsoft docs better. Since we did not get any response from you, we will close this issue.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thanks!

@AndreaBarr - This issue can be closed. Thank you.


Update Mapbox-gl to v2

@vogelino Could you take this on? It would be nice to see if this fixes the M1 problem.
We will have to add the preview URL to the Mapbox account.

Will do 👍

@ff6347 Which package exactly should be updated? I see no mapbox-gl package. I see:

@mapbox/vector-tile
react-map-gl
Both of which have a version higher than 2


ignore the plank generated parser from ktlint

The current Ktlint configuration does not ignore the generated parser from the Ktlint and Detekt's validation, so it is error prone in CI, even in local mode

handled by #53


Revert "Add OSLog to podspec (#201)"

This reverts commit 493b5a0d33a5d76819034c3396a5a50140af4b06. No longer needed with https://github.com/google/GoogleUtilities/pull/203.

I'll merge and stage


Fix storage and add sample dishbook

Codecov Report

Merging #59 (839146f) into master (da5aedb) will increase coverage by 1.68%.
The diff coverage is 6.81%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da5aedb...839146f. Read the comment docs.


Fix reset_ckcp.sh when using a custom workspace

The name of the kubeconfig is not static, so the script has been modified to look for any kubeconfig file
Signed-off-by: Romain Arnaud<EMAIL_ADDRESS>

/retest

/retest

/retest


Adopt icon font in notifications

Related #78889
This adopts the icon font in the notifications area (should look identical to current):

I also created the following colors:

iconRed.foreground for the Error icon
iconYellow.foreground for the Warning icon
iconBlue.foreground for the Info icon

These will end up being re-used by other icons so I tried to give them generic names that can apply to more than one icon. Once you modify the colors you can see this in action:

We have quite a number of icons that re-use the same colors:

My preference is to keep the naming convention simple and then assign those color tokens to specific icons (like terminal colors):

icon.default
icon.red
icon.redBright
icon.blue
icon.blueBright
icon.green
icon.greenBright
...

then in style.ts:
	const iconRedColor = theme.getColor(iconForeground);
	if (iconRedColor) {
		collector.addRule(`
			.monaco-workbench .codicon-error,
			.monaco-workbench .codicon-debug-stop,
			.monaco-workbench .codicon-debug-disconnect {
				color: ${iconForegroundColor
			};
		}`);
	}

@misolori ah, I was not aware we had this concept already for terminal colors. I guess that makes it easier to go for your suggested solution.

I agree with Ben's first comment. The colors should have specific names: specific to where are they used, and what they are for: `notificationsErrorIcon.foreground', ...
The notification color must go well together with all the other notifications colors, especially the notifications.background color. Also, a theme could decide to make all warnings green, not yellow. The name of the color therefore can't say 'yellow', but 'warning'.
For the debug icons you want to use `debugToolBaXYIcon.foreground'...
The terminal colors you mention are because of the spec'ed set of ANSI colors that can occur in terminal output. So it's not really different there. The color names describe a concept.

I've updated the naming convention so it follows as we discussed:

notificationErrorIcon.foreground
notificationWarningIcon.foreground
notificationInfo.foreground

I also scoped the icon colors so they only apply to the notification area and not in others (notice info icon in the editor action bar doesn't get the color changes):

Moved the theming participant to src/vs/workbench/browser/parts/notifications/notificationsList.ts and color definitions to src/vs/workbench/common/theme.ts
Merging this in and will queue up a build to verify.


FEATURE: Add buttons for unassigning from posts to the topic level assign menu

Before, we only had buttons for assigning and unassigning topic on this menu:

This PR adds dynamic buttons for unassigning posts to the menu:

cc @chapoi styles – e0d3e6b
margins on d-icon make icons and avatars on the menu play well together:


[Bug]: Version check of existing shuttle-next binary panics

What happened?
Running a next project installs shuttle-next if not present.
If it exists, the --version flag is used to check it.
Since https://github.com/shuttle-hq/shuttle/pull/822/files#diff-651941ab3b205fa0a1385341412700b34be3a850f36cf002fe60810f4ba89e2aL4 , the version flag is no longer there.
Therefore, running cargo shuttle run with shuttle-next installed panics, so it only works the first time.
I think the automatic install (in prod build) is strange.
I'd prefer getting prompted to cargo install so that I actually know what's happening. The user already installed cargo-shuttle and does not need to be spoonfed IMO.
The version check is still required though, so it could be solved by checking for "--version" explicitly before NextArgs::parse().
Version
v0.18.0
Which operating system(s) are you seeing the problem on?
Linux
Which CPU architectures are you seeing the problem on?
x86_64
Relevant log output
Installing shuttle-next runtime. This can take a while...
thread 'main' panicked at 'shuttle-runtime version should be in the `name version` format', /home/jonaro00/.cargo/registry/src/github.com-1ecc6299db9ec823/cargo-shuttle-0.18.0/src/lib.rs:1283:14
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Duplicate declaration

[X] I have searched the issues and there are none like this.

@paulotten What do you think about my point regarding automatic install vs prompting for manual install? ^

?????????


first commit

@urbashi123

#252

fixes: issue #8

@Ishaan28malik i have made the changes .Please do the changes.


Rewrite network runMaster to use joins

The runMaster function is too complicated at the moment.  At least according to the go report card.  The good news is that, the code could be easily simplified by rewriting it to take advantage of join.HashJoin!  Looks like that wasn't done in the first place because Melvin wrote the code before the join library existed.

Migrated to https://trello.com/c/VFWfxnct


Track application lifecycle events.

Add option to enable application lifecycle events tracking.
The third argument to setup method is added as a Map, for future extensibility.
Tested on both iOS and Android.

@BenBach thanks a lot!


Pathfinding: add support for goals made up of multiple nodes

See discussion and proposed implementation here, https://github.com/libgdx/gdx-ai/issues/7#issuecomment-71741086
Ideally, this kind of goal could be specified by an explicit set of nodes or abstract properties.

Any progress on this issue? Would be quite useful.

@piotr-j
No, sorry. Rather busy these days. Hopefully I'll have the time in the near future.
PR welcome, of course.  :smile:

Ill look into it once I figure out simple working ai, perhaps next week.

Does arbitrary list of endNodes makes sense? Since there is no relation between, they can be on opposite sides of the graph and that would result in basically endNodes.size searches that could as well be separate searches.
As abstract properties, something like any node within maximum cost from endNode would make some sense. That would probably require full search and then backtracking till we find node that exceeds the specified cost.
Any thoughts on that?


Add "noCredits" credits volume type

Feature
Instead of bringing up the ending orange text and showing the credits, it shows the white ending text used as the Echoes of the Eye ending with your custom text and then ends the loop normally, bringing you to the next loop. This should be helpful in cases where there is a massive solar system that everyone has put their planet in which takes forever to load from the main menu, but everyone has put in a credits volume so you always have to do so anyway...
Context
No response

perhaps this could have a better name than no credits. or at least document that its just the eote ending behavior

blah blah


Macos compilation

I was trying to build on mac and it threw some errors build errors due to missing symbols, which I was able to fix by modifying ldflags. Maybe we can add it to readme.
Steps

install  dlib using homebrew
Modify face.go to add the blas and lapack dependencies

// #cgo LDFLAGS: -ljpeg -lblas -llapack

PS: I think you have these 2 dependencies in the pkgconfig file on linux, but I find it easier to add here than to modify pkgconfig.

Hi. Thanks, I added it to readme.
Not sure how to deal with pkgconfig issues best. It provides convenient cross-distributive set of flags, on the other hand on many systems dlib's pkgconfig is not complete and misses required libraries.
We can't add -lblas -llapack to source code because some may use e.g. -lopenblas instead… Debian has update-alternatives mechanism for that, but it's not cross-distributive again.


Error in selecting range with large files.

[ ] I have verified there are no duplicate active or recent bugs, questions, or requests

Include the following:

k4l-video-trimmer version: 1.0.3
Device OS version: 5.1.1
Devide Manufacturer: Lenovo
Device Name: Vibe K5 Plus

Reproduction Steps

SetMaxDuration as 30 seconds
Choose a large sized video. Say 2 hours (A movie or something)
Move the range seek bar to ends of the movie, the max duration will increase and not remain 30 seconds (visually).

Expected Result
A trimmed file of 30 seconds duration
Actual Result
A trimmed file of 2 - 3 minutes
Tell us what could be improved:

I have fixed the issue and forced the duration at setMax length. Will probably create a PR sometime in the future.

Hey what changes have you done ?


Webdav support

@yongkangchen is this issue actual?

It is actual, but it did not exist in my plane, hope something will support this.

Closing this issue. You can duplicate it if you need it.


[FEATURE]

Requested Feature
Users should be able to easily mirror a path and/or movement functions for different alliance sides of the field.

User should be able to call chassis.setDefaultAlliance() in chassis config to choose what alliance perspective they normally code their autons on.
At the beginning of the autonomous code, the user should be able to call chassis.setAlliance() to select the alliance they are on.
If the user set their default alliance as red and sets the current alliance to blue at the beginning of auton, the corresponding red side auton will run but with the x position signs and theta signs flipped so that the auton is effectively mirrored.

Current Implementation

User has to make a completely new path file which is a mirror of the original path.
Motivation
Manually mirroring autonomous routines is annoying and prone to mistakes. This feature would insure that no more mistakes are made when mirroring paths and cuts down the time spent on creating autons.
(Optional) Possible Implementations and Alternatives

Really should give a better title

This will be introduced in v0.6. This requires significant modification to the tracking algorithm and it would be difficult to implement considering the complexity of the tracking algorithm in v0.5.
We'll do our best to get v0.6 stable before the end of the summer holidays


chore: drop the phony-rs

Removing phony-rs, at the time my idea was to make it a good local testing tool, but at the moment it seems that would be at a huge cost. So I prefer to remove that attempt and use phony.
close https://github.com/ti-community-infra/tichi/issues/399

/merge


⭐ 22 - Study Buddy (Hacktoberfest Demo) #634

What does this PR do?
Add a demo for study buddy
Related PRs and Issues
Checklist

[X] I have read read the Contribution Guide
[x] If the PR changes or adds functionality, I have updated the relevant documentation

Hi @kom-senapati, great job.
One thing I noticed is when I add a study plan with a title and description it goes into a loop and fills the whole screen with the same plan.

Can you look into this?

@NathanTarbert It's actually a problem with the model used. If we used GPT-3.5 or something similar, the results would be better. I am using a Groq model for this, so it gives results like that.
I think the input should be like "I want a plan for learning algebra".

Nice one @kom-senapati!!!😃

@quest-bot loot #634


Merchandising carousel [master]

scope was just merch carousel, if you can prove it’s working, that’s enough for the moment

Change to my branch that I used of what Tobias did because his branch did not work
https://github.com/SAP/cloud-commerce-spartacus-storefront/tree/feature/test-cds-demo

QA:
https://wiki.hybris.com/display/spar/CDS%2C+Anonymous+Consent%2C+Merchandising+Carousel
in the comment section :)


Update installation command for Scoop in README

mprocs is now in the main bucket (package repository) of Scoop and so a simpler installation command can be used.
Relevant PR here: https://github.com/ScoopInstaller/Main/pull/3713

Oh that's great. Thank you!


Typo in comment

Incredibly minor, but in a comment in pnpstatemachine.cpp "machine" is misspelled as "machien".
https://github.com/microsoft/Windows-Driver-Frameworks/blob/d9f66ca7ede31bc0745daad5c6f2aedb53795969/src/framework/shared/irphandlers/pnp/pnpstatemachine.cpp#L1514

fixed in PnpEventHardwareAvailablePowerPolicyFailed


ng doc  update

Please provide us with the following information:

OS?
Windows 10 ver 1607
Versions.
angular-cli: 1.0.0-beta.17
node: 4.5.0
os: win32 x64
Repro steps.
from terminal type: 'ng doc keyword'
The log given by the failure.
result is browser (chrome Version 53.0.2785.143 m) does not display the desired doc page referenced by 'keyword'.  instead browser displays generic API reference page.
Mention any other details that might be useful.
Proposed fix:  change line 6 of packages/angular-cli/tasks/doc.ts
from (broken)
const searchUrl = https://angular.io/docs/ts/latest/api/#!?apiFilter=${keyword};
to (working)
const searchUrl = https://angular.io/docs/ts/latest/api/#!?apiFilter=${keyword}&query=${keyword};

Thanks! We'll be in touch soon.

Good catch! Would you be willing to submit a PR to fix it? I'd review it.

Ok – will give it a shot.
From: Filipe Silva<EMAIL_ADDRESS>Sent: Monday, October 17, 2016 5:43 PM
To: angular/angular-cli<EMAIL_ADDRESS>Cc: John Thiry<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [angular/angular-cli] ng doc  update (#2731)
Good catch! Would you be willing to submit a PR to fix it? I'd review it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/angular/angular-cli/issues/2731#issuecomment-254343321, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIJwNXcmxU1CG4Vf4mnY0O7XuCmozqdlks5q0-v8gaJpZM4KYAyu.

Fixed in https://github.com/angular/angular-cli/pull/3383


Don't use BufferedImage

probably fixes #795

Can someone check that it does actually fix #795? then i'll merge it

good enough for me!


release v1.5.0-alpha.0

TODOs

[ ] #3670
[ ] #3659 ??
[ ] fix testgen
[ ] run testgen
[ ] version bump

if these can get merged in time, would be nice to include:

https://github.com/ethereum/consensus-specs/pull/3679
https://github.com/ethereum/consensus-specs/pull/3678
https://github.com/ethereum/consensus-specs/pull/3674
https://github.com/ethereum/consensus-specs/pull/3676


feat: Admin settings page to tinker with env variables

Description
Moving Admin settings page out of feature flag.
Fixes #9686
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Manual
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:white_circle: Total coverage has not changed
// Code coverage diff between base branch:release and head branch: feat/admin-settings-inauguration

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
app/client/src/pages/common/ProfileDropdown.tsx
68.75 (1.1)
28.57 (1.3)
0 (0)
68.75 (1.1)

:red_circle:
app/client/src/selectors/commentsSelectors.ts
83.61 (-1.64)
61.76 (-2.95)
73.33 (0)
88.24 (-2.35)

/ok-to-test sha=cd11d7f

Approving for tests

/ok-to-test sha=cb26b2f

/ok-to-test sha=719b7b2

/ok-to-test sha=7b45441

/ok-to-test sha=d1306a8


Expression item.href !== '' || item.href !== undefined always return true

I use an image tag and for this tag the expression item.href !== '' || item.href !== undefined always returns true.
https://github.com/humaan/Modaal/blob/e0bfab742df21f55e3a768efa07f1293cc0940fa/source/js/modaal.js#L571

@ildarnm I assume you're having some sort of issue with this, can you please provide some more information:

Please describe your expected result versus the actual result. You can using jsFiddle or jsBin if you can't provide any other example of your issue.
Please also share your implementation (html and js) here so we can try to help you.

I think I may have had a similar issue.
I followed the example to create an image gallery but every time I clicked an image the model was empty - the img tag src was set as undefined.
If you look at line 614 of modaal.js it tests for the presence of data in the href attribute as per the demo example
Show
but it then assigns the value of data-modaal-content-source to the modal image.
Having followed the example I didn't have this data attribute so the image src was never populated properly.
I solved the problem without editing modaal.js by adding the data-modaal-content-source data attribute to the link eg

Always looking for the simplest solution, I'd suggest changing the demo code to
Show
I'd love to make a contribution so do let me know if you'd like me to have a go at changing the code to use the href instead.

thanks @TimSmith714 and @ildarnm for raising this issue, upon closer inspection we have identified a bug as a result of some semi-recent enhancements that were rolled out.
A new release has just been made available out which addresses and resolves this issue. https://github.com/humaan/Modaal/releases/tag/v0.4.3


Unable to download xref map file

For a brief time, I was able to make links to Unity API work. After some time continually testing and building my documentation, they just stopped working. My classes are recognized as inheriting from UnityEngine.MonoBehaviour, for example, but they are plain text, and have no link to the Unity docs. Any time I have a property, return value, parameter type, etc. that is in the Unity API, it doesn't have a link.
Even a simple
[Test MonoBehaviour Link](xref:UnityEngine.MonoBehaviour)

doesn't work.
I did notice this message from docfx:

[22-07-29 08:07:13.483]Warning:[BuildCommand.BuildCore.Build Document]Unable to download xref map file from https://normanderwan.github.io/UnityXrefMaps/xrefmap.yml, details: Unable to connect to the remote server

I can't access that website anymore (connection time out). I don't know if it's just with me. I did check with various website checkers such as https://downforeveryoneorjustme.com/normanderwan.github.io?proto=https and https://www.freshworks.com/website-monitoring/is-it-down/https%3A%2F%2Fnormanderwan.github.io%2F and it says the website is down.
I did manage to download a 12.9 MB yml file from that URL before, but I don't know how to use it. I'd rather just somehow be able to use that yml file offline rather than relying on a website that is down.
Changing the line in my docfx.json didn't seem to work (UnityXrefMap.yml is the filename I gave it, I placed it in the Documentation folder, same place where the docfx.json is).
-     "xref": [ "https://normanderwan.github.io/UnityXrefMaps/xrefmap.yml" ],
+     "xref": [ "UnityXrefMap.yml" ],

Ok I figured it out. Turns out I had to delete the obj/.cache folder. I guess there was old data there that DocFx refused to recalculate. Now it works fine with the offline copy of UnityXrefMap.yml I have.

Glad you find a solution!
Indeed, DocFX is a bit hard to figure out sometimes. Clean build is a good thing to try times to times.
About the link, it's still up and online: https://normanderwan.github.io/UnityXrefMaps/xrefmap.yml
Maybe GitHub has a downtime at that moment?
Anyway, I will update the docs: An offline copy could be a preferred method over an online file.

Thanks for the reply! I have a suspicion it was due to the 100 GB monthly bandwidth limit. I'm not sure, maybe the user viewing also has some sort of monthly bandwidth limit (not just the site)? I was testing it just 2 days away from a new month (July 30).
Checking it just now, I can indeed access it again, as well as any github.io site (it was a little frustrating cause I previously couldn't access the DocFx tutorials at https://dotnet.github.io/docfx/).


How to save as png or jpg format?

How to save as png or jpg format?

Reportlab doesn't support bitmap files, but you can use convert to make bitmap pictures:
echo "ok"|python -m reportlab_qr_code|convert pdf:- /tmp/code.png

I don't know if i will be able to do rasterization using Drawing module.

I have added --format PNG option, but gradient is not supported, because Drawing class don't support masking. And gradients probably too.


Added ZOPEN_NAME changes in buildenv

Added ZOPEN_NAME changes in buildenv file for handling numbered tarballs
@IgorTodorovskiIBM @MikeFultonDev  Can you please review. I am not aware where else to add the reviewers.

@MikeFultonDev Yes, Mike, it is handled as aprt of https://github.com/ZOSOpenTools/utils/commit/4e0f0858b35e4137573a508151af6ebbbb3dbba6


HDDS-8169. Delay Starting ContainerBalancer after SCM failover

What changes were proposed in this pull request?
ContainerBalancer is a highly available service. Its configurations are replicated using protobufs and persisted on each SCM in binary. It runs only in the leader SCM. Currently, there is no delay when ContainerBalancer starts running in the new leader. We should wait for some time for Datanodes to detect that there's been a leader change and expire commands from old leaders.
Since ContainerBalancer is an SCMService, it receives a notification on raft/safe-mode status change. This PR makes ContainerBalancerTask go to sleep when it's been started on receiving a notification. It starts normally, without a delay, otherwise.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8169
How was this patch tested?
Added UTs.
Attaching results from manual docker-compose testing using ozone-ha:
Started ContainerBalancer in scm1. Set hdds.scm.wait.time.after.safemode.exit to 30s and trigger.du.before.move.enable to true:

Stopped scm1 container, ContainerBalancer started automatically in scm2. This image shows that it logs going to sleep for 30 seconds:

Later, it starts balancing:

Looks like we have one failing test which is related.

Looks like we have one failing test which is related.

Yes, that test passed locally but I see it failed in my fork as well. I've now added some logic using GenericTestUtils.waitFor() to wait for the thread to first go to sleep, like in the other test testDelayedStart. Waiting for CI results now.

Changes LGTM - @adoroszlai have you any further comments or are we good to commit?


"Get comment by user id" API returns count including deleted comments

It might be done intentionally but right now the "get comment by user id" API returns total comments count in the "count" field. But it does not return deleted comments in the "comments" field which seems to be little bit inconsistent because we can get 1 comment and "3" as the count value if 2 others were deleted:

This is a known limitation due to the data model. Comment removal in many cases doesn't delete the record itself but clearing it. This is done to preserve possible references (parent-child tree). The way boltdb storage implements UserCount doesn't check every comment for the deleted flag, but gets Stats().KeyN directly.
This was done for performance reasons (mostly) because checking each comment could be a heavy task for some users. However, there is a better way to do it by maintaining per-user meta-information. I'm planning to add such meta bucket but after #155 solved.


Optionally return a generator from find_motifs

Are there times where we'd still want a list instead?

This is fixed in #17, thanks @Raphtor!


Update for Cata?

Just wanted to confirm if this addon would be updated for Cata Classic or no. I get it, people's lives get crazy and passion projects have to put to the side. Was just wondering, either way thank you for the awesome addon through Wrath Classic!

Author is waiting for BiS lists on wowhead as per answer here: #7

That would be acceptable except if you check my links, they are there. Wowhead just hasn't bothered to do featured article yet. But they are there, just need to know how to navigate the drop down list on the left hand side to find it.
https://www.wowhead.com/cata/guide/classes/death-knight/blood/tank-bis-gear-pre-raid
https://www.wowhead.com/cata/guide/classes/death-knight/frost

/dps-bis-gear-pre-raid
https://www.wowhead.com/cata/guide/classes/death-knight/unholy/dps-bis-gear-pre-raid


Update sbt-idea-plugin to 3.20.6

About this PR
📦 Updates org.jetbrains:sbt-idea-plugin from 3.18.3 to 3.20.6
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.jetbrains", artifactId = "sbt-idea-plugin" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.jetbrains", artifactId = "sbt-idea-plugin" }
}]

labels: sbt-plugin-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #683.


chore: use Rollup to bundle the lib

Use the following Angular lib examples:

angular-quickstart-lib
simple-ui-lib

How does rollup compare to webpack 2?

We only need a bundler, we transpile using ngc/tsc. We will use Rollup for treeshaking and bundling (which is all it does). Webpack generates more code and it's threeshaking impl. does not do what threeshaking should do (remove dead code) whereas Rollup is very simple to configure and it does not output more than necessary.
You can also read more about the differences in the following:

http://david-rodenas.com/posts/rollup-vs-webpack-and-tree-shaking
https://github.com/rollup/rollup/issues/219

I considered using Closure at some point, but it's not an easy task to implement and not very stable with Angular 4 and AOT (though it considerably cuts the bundle size).
Furthermore, I will also add tslib as dependency so we can decrease the size of our bundled code (because the TS compiler adds a lot of helper functions in each file it compiles).
Bottom line, I'd choose Rollup for its simplicity and flexibility. And the Angular team has some good examples on how to setup libs that integrate in the Angular ecosystem.

@rolandjitsu Ok, thanks for the info. We use webpack as a bundler for our apps now, but I also noticed that it isn't a very good solution for bundling libraries.

@lyschoening No problem. There should be no problems with using this lib (if we use Rollup to create bundles) with Webpack as I also use Angular CLI which uses Webpack to run the Angular apps and some libs I use are bundled using Rollup (see Material 2 for example).

@lyschoening I've been working on implementing this and fixing some bugs after fixing the circular ref. issue in next branch. It's published under the next tag on NPM or 2.0.0.
There are some breaking changes though, but only for the way you import depending on what lib you use it with. Basically:
import {...} from 'potion-client/angular' // for Angular 1 -> import {...} from 'potion-client/angularjs'
import {...} from 'potion-client/@angular' // for Angular 4+ -> import {...} from 'potion-client'
import {...} from 'potion-client' // for Fetch -> import {...} from 'potion-client/fetch'

But we may consider publishing each impl. as a different package, the same way Angular 2+ does (e.g. @potion/angularjs, @potion/angular, etc.), but still keep the whole code in the same repository (monolith repo).

Close with https://github.com/biosustain/potion-node/commit/a50efff080fcf07a011b0de6783fa99e13e85289.


Override validation message

I need to modify the LoginNotAllowed error_description so that a code is returned instead. From searching on here I see that I can do this with a custom command.
Here is what I have:
public class CustomErrorDescriptionCommand : ICommandHandler<GetValidationMessage>     {         public void Handle( GetValidationMessage cmd )         {             if ( cmd.ID == MembershipRebootConstants.ValidationMessages.LoginNotAllowed )             {                 cmd.Message = Constants.AccountLockedErrorCode;             }             else             {                 cmd.Message = null;             }         }     }
I then register this like this:
Config.AddCommandHandler(new CustomErrorDescriptionCommand());
My breakpoints in the command handler aren't being hit and the error_description field remains the same. There are no errors from what I can see.
Any ideas on why this might be so? Also, isn't there already a command handler of this type registered by M.R so the command bus will find two command handlers?
Thanks

Use AddCommandHandler on the UserAccountService. Looks like an oversight that the config command bus is not getting wired up.

Can you clarify what you mean by on the UserAccountService? I've tried adding the CommandHandler in the Constructor but that didn't work. I can't see where else it could be registered?

https://github.com/brockallen/BrockAllen.MembershipReboot/blob/master/src/BrockAllen.MembershipReboot/AccountService/UserAccountService.cs#L132

Thanks but I meant at what point do I add this? I've currently done this because with using the Factory to create everything, the constructor is the only point at which I can be sure that the AddCommandHandler method will be called:
public class CustomUserAccountService : UserAccountService<CustomUser>     {         public CustomUserAccountService(CustomConfig config, CustomUserRepository repo)             : base(config, repo)         {             AddCommandHandler(new CustomErrorDescriptionCommand());         }     }

Well, you'd have to intercept the creation and add it there.
If you want the config done, then send a PR  :)

Thank you for the very kind offer but I can't share the code with you as it doesn't belong to me.
If you point me in the right direction though I can probably figure it out and stop taking up your time. We're using OWIN middleware so that's throwing me off a bit with finding where it's created & initalised.

Thank you for the very kind offer but I can't share the code with you as it doesn't belong to me.

That's too bad that the company is ok with using "free" open source, but not willing to contribute back to help fix bugs or improve the software for others. That's not a personal attack - it's just a commentary on how businesses are behind the times and are mired in myopic legal policies. It sort of kills my motivation to help "the community".
As for pointing you in the right direction -- I was suggesting that you look at how the existing code works in the UserAccountService ctor and try to get that to merge in the commands from the config object.

That's a bit harsh.
I'm just a developer, even worse a contractor, and cannot open support requests to 3rd parties which costs money without going through proper channels first. I'd have to escalate this to my manager who would then make the decision and get approval for the financing.
I'm sure they wouldn't have a problem doing this and therefore supporting/rewarding you for your hard work but it could not happen without me doing my job and eliminating the possibility that I can do this myself. That is after all what they are paying me to do.

Sure, I get that (I'm also a consultant). Personally, I don't sign contracts where I'm prohibited from contributing back to OSS projects that are being used by the company/project. Again, wasn't a personal attack on you. It's just another straw on the camel's back.
Hopefully my previous comment should be enough to help you move forward.

Sorry I misunderstood when you mentioned the pull request. I thought you wanted a version of our source code and not a corrected copy of M.R!
Yes I can do the latter no problem. From reading the source code I need to replicate how events on the event bus are merged in from the config in the UserAccountService. Should I create an AggregateCommandBus object in the same manner as AggregateEventBus? Any problems with that approach?

No worries on the confusion.

Should I create an AggregateCommandBus

Yea, why not - it'd be consistent then. Then just merge the two lists -- one from the config and another from the member variable on the user account service.

New Pull Request on Dev branch. Sorry about that - still finding my way around Git!

No worries. Is this now working for you with the commands in the config?

Yes it's working fine for me now thanks