[RabbitMQ] How should be main.ts ?

Hi, i have few questions regarding the install / usage of the package :
Can you add to your documentation an example of the main.ts file please ?
Do we need @nestjs/microservice package ?
In fact i don't how to start, a full example would be really appreciate (or at least the minimum dependecies & main.ts example).

Hi @fbaldo31
This project offers the examples/kitchen-sink directory which contains a Nest App that's set up with RabbitMQ and shows off some basic functionality. In addition, there are integration tests (tests that talk to a real RabbitMQ service) which also demonstrate how to set up RabbitMQ in your NestJS app.
https://github.com/WonderPanda/nestjs-plus/blob/master/examples/kitchen-sink/src/rabbit-example/rabbit-example.module.ts
You don't need the @nestjs/microservice package in order to use this.
Feel free to pull this repository down and explore the various samples and tests.

Thank you for quick answer it is clear now


Support for PHPStorm 242.*+

Plugin is actually not compatible with the newest phpstorm version. Coul you please create a plugin without a PuntilApp restriction?

Thanks for your response!
Please check the latest version, there I removed the limitation of the final version, but raised the limitation of the initial one due to the transition from org.jetbrains.intellij to org.jetbrains.intellij.platform.

Plugin is actually not compatible with the newest phpstorm version. Coul you please create a plugin without a PuntilApp restriction?

Thanks for your response!
Please check the latest version, there I removed the limitation of the final version, but raised the limitation of the initial one due to the transition from org.jetbrains.intellij to org.jetbrains.intellij.platform.


Setting up Viro for android with react-native

Greetings Everyone,
Over the last couple of days I have experienced significant issues setting up viro for a react-native application in android studio.
I was able to setup viro to work in ios but am just having the darndest time with android.
Has anyone successfully setup viro for android or run into issues?
KRH

Hey @bleudreams ,
I think we followed up on our slack channel regarding your issues running viro on android simulator. We've updated our documentation with the callout that we don't support Android simulator. Let us know if you run into issues running on an android device.
Thanks,


Fix mkldnn backend when using naive engine

Description
This can fix https://github.com/apache/incubator-mxnet/issues/15078 and resolve all mkldnn related failures mentioned in https://github.com/apache/incubator-mxnet/issues/15005.
@pengzhao-intel @TaoLv @eric-haibin-lin @zheng-da
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

Could you explain why this modification can fix the problem?

@zheng-da Sure. The root cause is, PushAsync works differently between threaded_engine and naive_engine.
For threaded_engine, PushAsync really works asynchronously, which will push MKLDNNDataReorderAsync to the tail of engine task queue. This is the expected behavior.
But for naive_engine, PushAsync will execute weight reorder immediately, just as a synchronous operation. I'm not sure if this is expected, but this isn't as asynchronous as function name indicates.
Now let's look at conv weight case,
weight_mem = GetWeights(weight, fwd->fwd_pd.weights_primitive_desc(), param.conv_param.num_group);

At this time, weight is still in default format, so a reorder is registered inside mkldnn stream, but not submitted.  And then,
weight.MKLDNNDataReorderAsync(fwd->fwd_pd.weights_primitive_desc());

When naive_engine is activated, This will inplace reorder weight into mkldnn format immediately. So weight is reordered twice in first iteration.
The fix is quite simple, change the sequence of above code, to ensure
weight.MKLDNNDataReorderAsync(fwd->fwd_pd.weights_primitive_desc());

happens prior to
weight_mem = GetWeights(weight, fwd->fwd_pd.weights_primitive_desc(), param.conv_param.num_group);

So for GetWeights, the weight is already reordered, no extra reorder will be registered in mkldnn stream.
Do we have plan to adjust naive engine PushAsync behavior to be as same as threaded_engine? I'm worried about this will cause trouble again for other developer.

@mxnet-label-bot add [MKLDNN]

@zheng-da @eric-haibin-lin please help take a review :)

@ZhennanQin NaiveEngine's PushAsync was intentionally synchronous. Other code should not make any assumption about execution order when using async interface of any engine.

In addition to the docs, should we add test for it?

We need a separate test which set naive engine env var before mxnet is imported

@szha @eric-haibin-lin We'd better to create naive engine CI for all UT, not only for some mkldnn tests. Naive engine should have the ability to pass all UT.

@szha @eric-haibin-lin We'd better to create naive engine CI for all UT, not only for some mkldnn tests. Naive engine should have the ability to pass all UT.

I am going to merge this PR to fix the problem inside MKLDNN implementation under the naive engine.
We will submit the separated PR to enable naive engine in CI @juliusshufan


Set www-data user in fpm-pool conf

closes #277
cc @gamkiller77

@gamkiller77 does this look right to you now?

Yah it is all working for me now.  I have a demo with a VP today so thanks for the help.


Fix error in setting on-chain tx timeout

Description

There was an error in setting the on-chain transaction timeout in the ethereum.NewChainBackend function.
Because of the error, the instead of the transaction timeout value passed as an argument to the NewChainBackend API,
chain connection timeout was set as the on-chain transaction timeout in the backend.
This PR fixes that error.
Category

Bug Fix

Relevant issue

Testing

Steps to run the tests

All the existing tests pass.
If the on-chain tx timeout is changed in any of the test configs. For eg: in session config used in Test_Integ_Role in session package, then this is reflected when initializing the ChainBackend. Previously it was not reflected.

Checklist

[x] Name is added to the NOTICE file, if it is not present already.
[x] Changes are rebased onto the target branch.

Please add "relates to" issue number with the commit message.

Rebased to latest develop.


a non initialized spdr context should act as a null logger

In order to simplify client code, a NULL spdr context should behave as a non logging context

the need is to be able to completely disable tracing, without having to change the user code.

initializing the context to null now disables tracing!


Cannot uninstall in projects depending on nikic/php-parser

In projects depending on nikic/php-parser, phpstan/phpstan-shim cannot be uninstalled.
For example, this issue affect all Symfony projects using symfony/maker-bundle.
Simple way to reproduce:
$ composer req --dev phpstan/phpstan-shim nikic/php-parser
$ composer remove phpstan/phpstan-shim
$ tree vendor
vendor
├── autoload.php
├── bin
│   ├── phpstan -> ../phpstan/phpstan-shim/phpstan
│   └── phpstan.phar -> ../phpstan/phpstan-shim/phpstan.phar
├── composer
└── phpstan
    └── phpstan-shim
        ├── LICENSE
        ├── README.md
        ├── bootstrap.php
        ├── composer.json
        ├── phpstan
        └── phpstan.phar

4 directories, 18 files

Probably related to #29.

Should work now, please test dev-master: https://github.com/phpstan/phpstan-shim/commit/10caff50504e77c038afca185b6a247d13dc560e


Clearly specified formatting rule

The use of an automated tool (like black https://pypi.org/project/nb-black/ https://github.com/psf/black or similar) might help keep code formatted appropriately. There are GitHub actions that can do this automatically, and the nb-black extension will do it for jupyter notebooks. The current code does not have major formatting problems, but as more people start working together this may help to prevent syntax confusion.

Updated coding environment to use black for src/ but not notebooks. nb-black doesn't install into the mamba environment I use. Will look into a formatting standard for notebooks.


Missed ")"

Small fix to doc.

@igor-gudich-fpc please sign the CLA

@igor-gudich-fpc please sign the CLA

No CLA signed, just one letter fix, closing

No CLA signed, just one letter fix, closing


Guice module integration issue with REST

Guice module integration issue with REST I have define one AOP guice based module, but when I tried to integrate with REST code, methodInvocation.proceed retun null. What might be best way to solve this issue.
Define AOP Guice based module as below
@Retention(RetentionPolicy.RUNTIME)
@Target(ElementType.METHOD)
@interface NotOnWeekends {}
public class WeekendBlocker implements MethodInterceptor {
public Object invoke(MethodInvocation invocation) throws Throwable {
Calendar today = new GregorianCalendar();

if (today.getDisplayName(DAY_OF_WEEK, LONG, ENGLISH).startsWith("S")) {

  throw new IllegalStateException(

      invocation.getMethod().getName() + " not allowed on weekends!");
}

return invocation.proceed();

}
}
public class NotOnWeekendsModule extends AbstractModule {
protected void configure() {
bindInterceptor(Matchers.any(), Matchers.annotatedWith(NotOnWeekends.class),

    new WeekendBlocker());

}
}
But I tried to Integrate this with my REST API
public class WorkerBean implements Worker {

@Autowired
private WorkerRepository workerRepository;

@Override
@NotOnWeekends
public Collection<Worker> findAll() {

    Collection<Worker> workers = workerRepository.findAll();

    return workers;
}

@RestController
public class WorkerController {
@RequestMapping(
        value = "/api/workers",
        method = RequestMethod.GET,
        produces = MediaType.APPLICATION_JSON_VALUE)
public ResponseEntity<Collection<Worker>> getWorkers() {

    Worker worker = Guice.createInjector(new NotOnWeekendsModule()).getInstance(Worker.class);

    Collection<Worker> worker = worker.findAll(); // return null

    ....
}

@pradrone09 if you're having trouble using Guice you should ask your question on the user mailing list or on StackOverflow. Issues on GitHub are for reporting bugs and filing feature requests.


[REF-1365] Allow tailwind to be disabled

A recent refactoring in App.compile started
unconditionally compiling tailwind, even when it is explicitly disabled by the user via tailwind=None
in rxconfig.
This does not fix REF-1365, but allows apps to workaround by totally disabling tailwind.

I moved this back to draft because not compiling tailwind seems to cause problems in other parts of the app. Need a unit test for disabling tailwind so we don't regress this functionality. Will take out of draft when a test can be added.


Encoded CARGO_TARGET_<triple>_RUSTFLAGS just like CARGO_ENCODED_RUSTFLAGS?

Problem
According to https://doc.rust-lang.org/cargo/reference/environment-variables.html there's CARGO_ENCODED_RUSTFLAGS to properly escape independent arguments with separators, when those arguments themselves (i.e. file paths) already contain spaces. However, no similar environment argument appears to exist for CARGO_TARGET_<triple>_RUSTFLAGS so that I cannot set up per-target RUSTFLAGS containing arguments with spaces.
Proposed Solution
Would it be possible to add CARGO_TARGET_<triple>_ENCODED_RUSTFLAGS?
Notes
No response

If you have access to Command, config command line override is available. See a relevant discussion #14381 and other alternatives in https://github.com/rust-lang/cargo/issues/3686#issuecomment-1324128725.

See also #10462


[Java] max rank and tensor limit

sync to native API, update max rank and tensor size limit.

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #425. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.


Math magicians: fetch data from API

Used the following external API: API Ninjas
Created a new component called Quote
Fetched data inside of a new component
Showed a loading state
Showed an error state

Removed Inline comment


Fix schema override for multiple endpoints with same path

Closes #15

I also dropped AnnotationDefinition and made possible override core definitions by @OpenApi


Question about system assigned identity

The example shows how the DefaultAzureCredential can be used for a user assigned managed identity, does the same logic apply for a system assigned identity ?
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 414d8832-9224-3bb5-2bf4-1197c41fdedf
Version Independent ID: 02d95dd6-bf1b-5cef-bc94-ac187b133c45
Content: DefaultAzureCredential Class (Azure.Identity) - Azure for .NET Developers
Content Source: xml/Azure.Identity/DefaultAzureCredential.xml
Service: azure
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

Hi @StefH - Yes it applies to both user defined and system defined. The example in the article just happens to show the user defined scenario.


Label shows "exited" if one container has exited but rest is running

Problem
If a stack has multiple containers, of which the one of the containers (purposely and knowingly) exits, the UI shows that the entire stack has exited.

Reproduction
Directory structure
collection/
├── dockge/
│   └── docker-compose.yml
└── kuma/
    └── compose.yaml

./collection/kuma/compose.yaml
version: '3.9'

x-restart: &restart-always
  restart: always

services:
  dockge:
    image: louislam/dockge:${DOCKGE_IMAGE_VERSION}
    <<: [*restart-always]
    security_opt:
      - no-new-privileges:true
    environment:
      DOCKGE_STACKS_DIR: ${DOCKGE_STACKS_DIR_CONTAINER:-/opt/stacks}
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
      - dockge:/app/data
      - ${DOCKGE_STACKS_DIR_HOST:-/opt/stacks}:${DOCKGE_STACKS_DIR_CONTAINER:-/opt/stacks}
    networks:
      - dockge
      - proxy

  # will exit after it has checked that target containers are up
  wait:
    image: waisbrot/wait
    environment:
      TARGETS: uptime-kuma:3001
      TIMEOUT: 30
    networks:
      - uptime-kuma

volumes:
  dockge:
    driver: local

networks:
  dockge:
    driver: bridge
  proxy:
    external: true

./collection/kuma/.env
DOCKGE_IMAGE_VERSION="1"
DOCKGE_STACKS_DIR_HOST="../" # resolves to "./collection" on host
DOCKGE_STACKS_DIR_CONTAINER=

$ docker compose logs -ft
kuma-uptime-kuma-1  | 2023-11-12T16:12:34.607124969Z ==> Performing startup jobs and maintenance tasks
kuma-uptime-kuma-1  | 2023-11-12T16:12:34.607674548Z ==> Starting application with user 0 group 0
kuma-uptime-kuma-1  | 2023-11-12T16:12:34.644486738Z Welcome to Uptime Kuma
kuma-uptime-kuma-1  | 2023-11-12T16:12:34.652094388Z Your Node.js version: 16.20.2
kuma-uptime-kuma-1  | 2023-11-12T16:12:34.689036563Z 2023-11-12T16:12:34Z [SERVER] INFO: Welcome to Uptime Kuma
kuma-uptime-kuma-1  | 2023-11-12T16:12:34.690065180Z 2023-11-12T16:12:34Z [SERVER] INFO: Node Env: production
kuma-uptime-kuma-1  | 2023-11-12T16:12:34.690514441Z 2023-11-12T16:12:34Z [SERVER] INFO: Inside Container: true
kuma-uptime-kuma-1  | 2023-11-12T16:12:34.690963362Z 2023-11-12T16:12:34Z [SERVER] INFO: Importing Node libraries
kuma-uptime-kuma-1  | 2023-11-12T16:12:34.691445555Z 2023-11-12T16:12:34Z [SERVER] INFO: Importing 3rd-party libraries
kuma-uptime-kuma-1  | 2023-11-12T16:12:35.607024282Z 2023-11-12T16:12:35Z [SERVER] INFO: Creating express and socket.io instance
kuma-uptime-kuma-1  | 2023-11-12T16:12:35.607921482Z 2023-11-12T16:12:35Z [SERVER] INFO: Server Type: HTTP
kuma-uptime-kuma-1  | 2023-11-12T16:12:35.609980042Z 2023-11-12T16:12:35Z [SERVER] INFO: Importing this project modules
kuma-uptime-kuma-1  | 2023-11-12T16:12:35.694761652Z 2023-11-12T16:12:35Z [NOTIFICATION] INFO: Prepare Notification Providers
kuma-uptime-kuma-1  | 2023-11-12T16:12:35.700526247Z 2023-11-12T16:12:35Z [SERVER] INFO: Version: 1.23.3
kuma-uptime-kuma-1  | 2023-11-12T16:12:35.746112357Z 2023-11-12T16:12:35Z [DB] INFO: Data Dir: ./data/
kuma-uptime-kuma-1  | 2023-11-12T16:12:35.746473839Z 2023-11-12T16:12:35Z [SERVER] INFO: Connecting to the Database
kuma-uptime-kuma-1  | 2023-11-12T16:12:35.798819111Z 2023-11-12T16:12:35Z [DB] INFO: SQLite config:
kuma-uptime-kuma-1  | 2023-11-12T16:12:35.800552698Z [ { journal_mode: 'wal' } ]
kuma-uptime-kuma-1  | 2023-11-12T16:12:35.801273238Z [ { cache_size: -12000 } ]
kuma-uptime-kuma-1  | 2023-11-12T16:12:35.803553148Z 2023-11-12T16:12:35Z [DB] INFO: SQLite Version: 3.41.1
kuma-uptime-kuma-1  | 2023-11-12T16:12:35.803847930Z 2023-11-12T16:12:35Z [SERVER] INFO: Connected
kuma-uptime-kuma-1  | 2023-11-12T16:12:35.805342508Z 2023-11-12T16:12:35Z [DB] INFO: Your database version: 10
kuma-uptime-kuma-1  | 2023-11-12T16:12:35.805642600Z 2023-11-12T16:12:35Z [DB] INFO: Latest database version: 10
kuma-uptime-kuma-1  | 2023-11-12T16:12:35.805961989Z 2023-11-12T16:12:35Z [DB] INFO: Database patch not needed
kuma-uptime-kuma-1  | 2023-11-12T16:12:35.806302656Z 2023-11-12T16:12:35Z [DB] INFO: Database Patch 2.0 Process
kuma-uptime-kuma-1  | 2023-11-12T16:12:35.822781063Z 2023-11-12T16:12:35Z [SERVER] INFO: Load JWT secret from database.
kuma-uptime-kuma-1  | 2023-11-12T16:12:35.823603669Z 2023-11-12T16:12:35Z [SERVER] INFO: No user, need setup
kuma-uptime-kuma-1  | 2023-11-12T16:12:35.829144935Z 2023-11-12T16:12:35Z [SERVER] INFO: Adding route
kuma-uptime-kuma-1  | 2023-11-12T16:12:35.851198407Z 2023-11-12T16:12:35Z [SERVER] INFO: Adding socket handler
kuma-uptime-kuma-1  | 2023-11-12T16:12:35.851508783Z 2023-11-12T16:12:35Z [SERVER] INFO: Init the server
kuma-uptime-kuma-1  | 2023-11-12T16:12:35.858831837Z 2023-11-12T16:12:35Z [SERVER] INFO: Listening on 3001
kuma-uptime-kuma-1  | 2023-11-12T16:12:35.860040715Z 2023-11-12T16:12:35Z [SERVICES] INFO: Starting nscd
kuma-wait-1         | 2023-11-12T16:12:36.307856735Z Waiting for uptime-kuma:3001  ..  up!
kuma-wait-1         | 2023-11-12T16:12:36.307896810Z Everything is up
kuma-wait-1 exited with code 0

Looking at stack.ts, I see it performs a statusConvert which checks if the status string starts with exited.
So I ran the following command in the stacks directory to see the status of the kuma stack.
$ docker compose ls --all --format json | jq '.[] | select(.Name == "kuma")'
{
  "Name": "kuma",
  "Status": "exited(1), running(1)",
  "ConfigFiles": "./collection/kuma/compose.yaml"
}

It has multiple statuses because one of the containers has exited, and the other one still running.
Possible solution
Maybe instead of startsWith try with includes(?)

"Status": "exited(1), running(1)",

Thanks, I didn't know it contains multiple status.


fix: RewardModelLinear bcast process_group

Motivation
RewardModelLinear bcast should specify process_group.
Modification
internlm/model/modules/linear.py

LGTM


Should VK_LAYER_RENDERDOC_Capture be enabled on instance creation?

When I create a Vulkan instance should I also add VK_LAYER_RENDERDOC_Capture to the enabled layers? I wasn't able to see any mentioning of it in the docs.
https://renderdoc.org/docs/behind_scenes/vulkan_support.html#stadia
P.S. Thank you very much for: https://renderdoc.org/renderdoc-history.html A great and inspirational story to read.

You should never add the vulkan layer manually, always launch your program through RenderDoc as documented to ensure it is set up correctly.

@baldurk Does by any chance the installation of  RenderDoc and the layer impact the performance of other Vulkan applications?

If RenderDoc has a capture open for replay it will have some performance impact just like any other program using the GPU, and there is a cost to having RenderDoc active and capturing an application. If you mean just having RenderDoc installed but not running in any way, then no that won't affect anything.


Why GPU and NPU give different results?

I fixed the random seed, and use GPU and NPU to generate an image separately.
This is from GPU:

This is from NPU:

As I know, GPU and NPU both use FP16 for inference. I think they should have the same result. Why they are different?

This is expected (Also check out the visual in this README section). TL;DR: Kernel numerics are different.

Kernel numerics are different

@atiorh Could you explain this? Does it mean the weights will be slightly changed when loaded to NPU?


Add new Geneva and Metrics endpoints to firewall-integration.md

@dejo-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @dejo-msft - Product Managers should work in the private repo for advanced quality validations and staging (you also can sign off directly in the private repo). To edit an article in the private repo from within the documentation, after you select Edit,  add “-pr” to the URL. We’ll leave this PR for review in the public repo, but would you make future article updates in the private repo?  Thanks!

@ccompy
Could you review the proposed changes to your article?
Thanks!

#sign-off


Add boundary conditions and standardise field and timed data storage

Adding new BoundaryConditions class to allow boundary conditions data (vertical curtains around a lat-lon domain) to be added to the object store. Tests have been added for this (based on those present within "test_emissions.py")
As a part of this the following additional changes have been made:

Within "_datasource.py" the Datasource.add_timeseries and Datasource.add_field_data (and derived) methods have been merged into one Datasource.add_timed_data method which is currently called when "time" is a coordinate within our data.

This method now adds the extent period (e.g. sampling_period or time_period) to the end_date to make sure the label covers the time represented by the data.
Note that this will now alter all daterange_str values for timeseries and fields data (the tests have been updated to reflect this). The only case where this will not change is if the "sampling_period" is unknown.

To code to determine the time period of the data has now been standardised between BoundaryConditions, Emissions and Footprints classes (split out into a separate _infer_time.py module)

Closes #185

This look great! I might leave it til Monday to start going over it, thanks Friday brain.


Add Multiple Accounts

NOTE: This is very similar to the onboarding flow.
Is your feature request related to a problem? Please describe.
User should be able to easily add and switch between accounts while in the Light Wallet.
Describe the solution you'd like
The user can select a dropdown from their username on the Profile Page.
Opens up a menu from the bottom where they can switch between accounts (if they already have multiple)
OR
Thte user can select Add new Account.
The Similar Add new account feature will display showing a field where the user can enter their private key.
Once the user inputs their private key they can search and select any accounts the display.

Note: Check for Account Security when switching between accounts.
Update
The add new account screen needs to have an option to add an account name, rather than a private key.
This account can then be in read-only, or in multisig or in "keyless authority" mode. - see spec update below.
Additional context
Add any other context or screenshots about the feature request here.

Spec update
We need to save the list of user accounts in the preferences
Example, my account is illumination
Then I add an account to the list with the + key, say testingseeds
Then I add another account "wallet.light" (light wallet org account)
Each time I add an account, I need to go through the import private key procedure. But I can also skip private key entry.
The wallet needs to store all accounts I ever entered locally.
The private key import is optional - this means either I am in "watch and receive only" mode, or I have auth credentials without key on that account.
For example, a cash register wants to add an account for the organization it collects cash for - but it doesn't want to ever send cash, in fact the owner of the business prefers if cashiers cannot send cash from their wallets.
But maybe that's a later use case-  but we should keep this in mind while implementing.
We need to be super clear on the mechanics.
accounts: always saved in preferences!
private keys - may or may not be needed - saved in secure storage
Another (advanced) example:
I have a business account mybusiness11 - but I have changed the keys so that my personal account, illumination, is actually an active signing account on mybusiness11. So I don't need the private key for mybusiness11 - there may not even be a private key on it, only a signing account.
Another advanced example:
I have mybusiness22 together with Jason and Gery, and we all have 2/3 signing authority on it - in this case, also no private key import needed.
Meaning private key import must be possible to be skipped.
I think I can make EOSIO calls to figure out if existing keys are good enough to sign whatever account in questions, in case we need to surface this in the UX
Accounts can be in one of 3 states

active (I can sign)
watch / receive (I can't sign)
multisig (I am part of a multisig which can sign)

We won't support multisig just now, but I have heard much desire from organization owners to have it, so this will happen sooner rather than later.

✅ Test Case 1 (Adding an account using a recovery phrase)

Go to Profile.
Tap on the current account name.
Tap Add new account.
Type in 12-Word Recovery phrase.
Tap Search.
Tap the found account.
Enter the PIN.
Observe being logged in as the added account.

✅ Test Case 2 (Adding an account using a private key)

Go to Profile.
Tap on the current account name.
Tap Add new account.
Tap Tap here.
Paste a private key.
Tap the found account.
Enter the PIN.
Observe being logged in as the added account.

✅ Test Case 3 (switching between accounts)

Go to Profile.
Tap on the current account name.
Tap on a different account name.
Observe being logged in as the selected account.

I tested the implemented functionality of adding accounts and switching between accounts. Moving back to To do as we still need to implement the rest of the spec requirements. Or do we maybe want to split this ticket into multiple ones? @JGDoh @gguij004 @n13 @RaulUrtecho

yeah @buildc0de I think the best its area a new ticket for those specs as it say:

We won't support multisig just now, but I have heard much desire from organization owners to have it, so this will happen sooner rather than later.

So we can add this switch accounts mvp for now and let the rest of the spec for a new ticket.

I will discuss this at our meeting 🤓

@buildc0de what was the final status for this feature,
Will it be added to the next release?

@RaulUrtecho On the call yesterday we agreed:

to release the "MVP" for this feature (the ability to add accounts and switch between accounts)
to create new tickets (@JGDoh) for the remaining desired functionality and implement it in future releases

Okay then I'll move this ticket to QA again

MVP feature has been tested as per: https://github.com/JoinSEEDS/seeds_light_wallet/issues/1096#issuecomment-962707573


Current AC matching algorithm is ad-hoc and incomplete

Our current Map and Set matching algorithm is incomplete.
We should consider replacing the current way we do Map and Set matching with some traditional AC matching algorithm. This needs investigation as I don't know if implementing such an algorithm is compatible with our current representation of Maps and Sets, so this might end up to be a significant undertaking.
See https://runtimeverification.slack.com/archives/CC360GUTG/p1625220446338900

See also: https://runtimeverification.slack.com/archives/CTXRMGL58/p1625731908004900

See also: https://runtimeverification.slack.com/archives/CTXRMGL58/p1625754556006400

@jberthold please add what you found here.

We should consider replacing the current way we do Map and Set matching with some traditional AC matching algorithm

I consulted several papers about AC (and other non-free) matching algorithms, most prominently [Boudet(1993)[(https://link.springer.com/article/10.1007/BF00881905) (which is about unification, not matching) and Eker(2003).
The techniques presented in these papers (based on diophantine equations) apply directly to ASTs with AC symbols (and other, free, symbols). In contrast, our NormalizedAC data holds information derived from an AC term, so the algorithms won't be applicable without substantial changes.
The question whether

implementing such an algorithm is compatible with our current representation of Maps and Sets
already hinted in that direction.

The AC matching on NormalizedAC should still be refactored to cover more cases and be more maintainable but implementing an algorithm from literature would mean to remove the derived normalised representation, which will touch many parts of the code.

Another issue is that the AC matching algorithm in use picks one arbitrary match out of potentially many.
This is somewhat inherent to the use case: The matching code is used for simplifications and conceptually returns a single result. Some code fragments in the simplifier exists to cater for simplifications having multiple results (see runSimplifier vs runSimplifierBranch) but `runSimplifierBranch is unused, the simplification code currently relies on obtaining a single result.
One could try to discard results ASAP by way of relevant side conditions, but this still does not guarantee a single result.
We could modify the code to generally handle simplifications with potentially several results, maybe treating those like rewrites (i.e., proceed with several results in an OrPattern) but it would drastically widen the state space to explore and substantially change the code.


Add resource reload events.

Those events can be used to apply/re-sync stuff after a resource reload for example.

Is there any way to distinguish between first load and subsequent reloads on client?

Is there any way to distinguish between first load and subsequent reloads on client?

no, but in impl, yes

Is there any way to distinguish between first load and subsequent reloads on client?

no, but in impl, yes

Could you add something like this, then? This could help for mods which specifically want to run something on reloads.

Is there any way to distinguish between first load and subsequent reloads on client?

Could you add something like this, then? This could help for mods which specifically want to run something on reloads.

Added

smh merged just while i was reviewing it

~smh merged just while i was reviewing it~

eh, if there's still an issue we still can fix it, it's not set in stone


use git log that acts like git whatchanged. include merge commits

we ran some tests that compared the output of git log and git whatchanged on several repos, and determined that this set of arguments made them act the same for our repos. then we removed the --no-merges flag from git log so it will include merge commits per https://issues.jenkins-ci.org/browse/JENKINS-28907 (see also the comment there). updated all references to git whatchanged in comments, since whatchanged no longer appears in the source code of this repo.
working w/ jasquat.

i'll pull the classic "the master build failed with the same test failure at around the same time that it failed for my branch" defense (for the continuous-integration/jenkins/pr-merge check). sorry about that.

Yes, that test failure is happening only on Windows, and has resisted my attempts to fix it.  It passes on my Windows machines, and passes on my Linux machines.  I'll investigate further today or tomorrow.

well i actually tried installing the hpi generated from a maven build off this branch and it didn't seem to do what i would have expected based. the following changes in the screenshot include merge commits, but it's still only showing the one non-merge commit instead of both the normal commit and the merge commit. i also tried changing the line in question to totally botch it ("git borked" instead of "git log" or "git whatchanged") to see if that would break everything, but it didn't break jenkins like i expected it to. maybe that line isn't used, or maybe my testing process was bad (i maven built, grabbed the hpi, shoved it up via the upload plugin UI, and then restarted jenkins).

@burnettk I didn't spend as much time researching as you did, but for my GH project, it seemed that adding the --diff-filter also eliminated all merge commits.  I know that wasn't your intention (you specifically stated that you wanted a filter that excluded nothing), so maybe there is something else going on in my setup.
On the other topic, one way to make it backward compatible is to add an additional option to the configuration screen.

By default, the values would be exactly as it is now, e.g.:
Global changelog generation base command:  whatchanged --no-abbrev -M
In my case, I would change it to:
Global changelog generation base command:  log --raw --no-abbrev -M
If it was too much work to change various interface definitions to pass in this string, then a less elegant approach would pull the values from a system environment variable (an approach that is already implemented in that class for other constants):
public static final boolean GIT_CHANGELOG_COMMAND= (System.getProperty(CliGitAPIImpl.class.getName() + ".changelogCommand", "whatchanged --no-abbrev -M"));
If someone needed different formats for different jobs, then it would have to move into the additional behaviors for Git, which seems unlikely to be worth the effort IMO.

either of those options you mentioned to support configuring this command would be awesome from my perspective.

@burnettk BTW, I did the same testing as you (maven build, upload hpi) and after removing the diff-filter, I now see merge commits too.  You might want to retest yourself.  Do the extra commits you see due to "rev.always_show_header = 1" impact you, or were you just trying to maintain backward compatibility?


fix(table-toolbar): Fix a11y violations

Closes carbon-design-system/carbon-components-angular#2551
This PR fixes a11y violations when the toolbar is not showing and when it's showing. It also changes the toolbar behavior to be completely invisible (as in not in the DOM) when it's not showing which fixes one more violation without changing the functionality in any way.
Before

After

@Akshat55 I made the change you've requested and the PR is ready for another review

Thanks for the updates @Akshat55. I just reran the accessibility checker and I can see there are even less violations than before! :)


add set +euo pipefail at the end of the script

Turn it off after because technically this turns it on for their entire shell.

Closed by #25


An exception in KinesisDataFetcher#shutdownFetcher may fail to shutdown shardConsumersExecutor leading to job hanging

The following code:
public void shutdownFetcher() {
	if (LOG.isInfoEnabled()) {
		LOG.info("Starting shutdown of shard consumer threads and AWS SDK resources of subtask {} ...",
				indexOfThisConsumerSubtask);
	}

	running = false;

	StreamConsumerRegistrarUtil.deregisterStreamConsumers(configProps, streams);

	recordPublisherFactory.close();

	shardConsumersExecutor.shutdownNow();

	if (mainThread != null) {
		mainThread.interrupt(); // the main thread may be sleeping for the discovery interval
	}

	if (watermarkTracker != null) {
		watermarkTracker.close();
	}
	this.recordEmitter.stop();

	if (LOG.isInfoEnabled()) {
		LOG.info("Shutting down the shard consumer threads of subtask {} ...", indexOfThisConsumerSubtask);
	}
}

May lead to a stuck job if after settings running = false  any of the following throws an exception:

StreamConsumerRegistrarUtil#deregisterStreamConsumers
recordPublisherFactory.close()

When this happens, the mainThread will hang in #runFetcher's call to #awaitTermination forever since shardConsumersExecutor.shutdownNow() is never called.
Note that this was extremely hard to debug due to lack of logging. Highly suggest a more fortified shutdownFetcher with error handling and best effort cleanup of the methods that can throw.

Addressed in https://github.com/awslabs/amazon-kinesis-connector-flink/pull/24 and will be included in 2.0.3

@dannycranmer Thanks a lot! Any ETA on when this might be released?

@bobtiernay-okta it is currently running through our test suite. Once this is green I will finalise and push out


Documentation on how to calculate Write throughput budget in the sink

I read about the Write throughput budget but I could not quite understand how to calculate the value. I have a CosmosDb with auto scale up to 4000RU/s. In my sink, I define Write throughput budget to 1000RU/s thinking that the maximum usage would be cap at 1000RU/s but it isn't the case. My cosmos db remains at 400RU/s without scaling up and it take hours to write a small set of records.
Please provide more detail on how to set the Write throughput budget at the cosmos db sink.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 43cac5a8-aa7f-8aba-d47e-e78249efa031
Version Independent ID: 09c34890-b4f0-be28-9813-bb8066631f6f
Content: Copy and transform data in Azure Cosmos DB (SQL API) - Azure Data Factory
Content Source: articles/data-factory/connector-azure-cosmos-db.md
Service: data-factory
GitHub Login: @linda33wj
Microsoft Alias: jingwang

Thanks for the ask  . At this time we are reviewing the ask and we will reply back as soon as we can .

Hi @yuanshingk, and thank you for reporting this issue.  This sounds like it could be some unexpected behavior.  Can you open a support case from your Azure portal on the Support & Troubleshooting blade to engage our support team directly?  They will be able to investigate the root cause of your unexpectedly lower throughput than your configuration should support.  For now I will close this issue out but we can also continue the discussion here on this thread, even after the issue is closed.
#please-close


Codepush vs. Native distribution strategy

I'd love to see some recommended setup of codepush vs. native distribution strategy. When to use each, and how do they integrate with each other? It's amazing that App Center has code push built in (in fact it's what brought us to app center in the first place) however it's been really difficult to figure out how everything fits together.

Related to https://github.com/Microsoft/appcenter/issues/65

Hi @tonyxiao, thanks for the feedback. By native distribution strategy do you mean App Center's distribution or OS specific distribution (testflight/playstore)

@botatoes both. What makes it challenging is that there are so many different ways to distribute and it's hard to think about how to get them to work together. In this particular case tho, it's more about code push vs. native (whether App center or os specific)


Bars.Beam is very slow in 21.2.1

A hundred beams takes 10 seconds in version 21.2.1 but used to be instant previously. I think this has to do with the default material and sections.

yes :)
Inputting a Section and Material would make the component behave as before.
The script is Deserialising the database for everybeam.
Needs to be fix with cache or other as you suggest

Implementing a cache for SectionDatabase and MaterialDatabase


[Draft] Add a standard way of creating QNN models

Meant to fix #12
It is not meant as a replacement of the current workflow but a more of a standardised alternative.

Main motivation is to have a standard manner of defining QNNs.
Good for quick prototyping and benchmarking different parts (Rydberg Hamiltonian based ansatz vs a fully digital ansatz etc)
Much easier to store this
Reduces a bunch of boilerplate code that you need to write.

hi @smitchaudhary , i responded in https://github.com/pasqal-io/qadence-libs/issues/12 regarding this, but i think @jpmoutinho is the best person to consult about this

Thanks @dominikandreasseitz, yes I will review this.

Thanks @dominikandreasseitz and @jpmoutinho
Still a draft. Once I incorporate more changes, will request a proper review. Open for feedback already though.

Watchout @smitchaudhary, there's still a reference to the eic_aero package in the quantum_models file

Hey @smitchaudhary will you have time to work on this ?

@Roland-djee Yes I will pick it up soon. Gathering some more feedback from some users and incorporating that.

@smitchaudhary should we merge https://github.com/pasqal-io/qadence/pull/385 and this together?

@dominikandreasseitz I assume the transformed module needs to be refactored for qadence at large but does this new config workflow also go directly into qadence, in contrast to just qadence-libs for now?

@dominikandreasseitz I assume the transformed module needs to be refactored for qadence at large but does this new config workflow also go directly into qadence, in contrast to just qadence-libs for now?

imo, i would have all of this in qadence for now and then move the full ml_tools module once its ready @Roland-djee @jpmoutinho @Doomsk @smitchaudhary

@dominikandreasseitz I assume the transformed module needs to be refactored for qadence at large but does this new config workflow also go directly into qadence, in contrast to just qadence-libs for now?

imo, i would have all of this in qadence for now and then move the full ml_tools module once its ready @Roland-djee @jpmoutinho @Doomsk @smitchaudhary

I would first try to converge on the goal for the QNN interface before deciding how to handle the code here and the changes being made in your MR @dominikandreasseitz.
Some thoughts:

In the current state, the code here is a convenience layer on top of QNN which culminates in build_qnn function. Is that desired? Another option is to have the configs be part of the input of the QNN class itself.
In this MR the scaling parameters affect how the feature map constructor is built, while in the QNN MR the scaling affects the parameters of the QNN itself. These are functionalities with an overlapping goal but different implementation. What is the plan on combining those?
Same thing for the output scaling and observable config.

@jpmoutinho

In the current state, the code here is a convenience layer on top of QNN which culminates in build_qnn function. Is that desired? Another option is to have the configs be part of the input of the QNN class itself.

This was developed independent of the QNN/TransformedModule logic (and is just a draft at that), so if the plan is to open up QNN and change the definition/signature altogether, then we could do that. However, the current QuantumCircuit class is a lot more general than what is created inside build_qnn_model. For starters, in general, a circuit is not required to have a feature map, or ansatz. It can have any block. All this to say that if this is the route taken, then the current logic with the configs here will need to be changed accordingly.

These are functionalities with an overlapping goal but different implementation. What is the plan on combining those?
I think @dominikandreasseitz 's impetus behind merging the two is exactly this. Do away with the wrapper TransformedModule.

@awennersteen @Roland-djee , @smitchaudhary @jpmoutinho and I propose to combine https://github.com/pasqal-io/qadence/pull/385/files and this MR together, meaning:

Removal of the TranformedModule
Achieving scaling/shifting of inputs and outputs of QNNs through featuremap and observable configs

However some libraries which use qadence rely on the TransfomedModule for classical NNs, we think its best to fully separate the quantum and classical parts which would be achieved by doing the above. wdyt?

Moved this PR to the main qadence repo here


No range feature implementation and tests

Added flag --norange, -nr as new argument in main.py
Added internal flag no_range for use in kifield.py
Implemented no_range behavior by collapsing all references, exploding the collapsed references, and then joining the resulting sorted and explicit list of references to make a nice string.
Added unit test for the edited group_wb method
Added two integration tests based on existing tests of grouping and randomizing.
Added self to contributors list.
Added a handful of items to .gitignore to cover my environment.
The result passes all of the tests (for Python 2.7 and 3.9, which is what I already had installed). It also seems to consistently work for my overly complex schematic in progress.
Did not edit the readme or rebuild the docs for this pull request, I couldn't figure out how to get the docs to build properly.
(I am happy to squash all those commits down to one if that would be easier to merge)

Thanks for adding this feature!
To rebuild docs, you should be able to go into the docs directory and use make singlehtml.


Duplicate class found in modules jetified-xxx-runtime.jar

implementation 'com.blankj:utilcodex:1.26.0'

Execution failed for task ':app:checkDebugDuplicateClasses'.
> 1 exception was raised by workers:
  java.lang.RuntimeException: java.lang.RuntimeException: Duplicate class com.blankj.utilcode.constant.CacheConstants found in modules jetified-utilcode-1.25.9-runtime.jar (com.blankj:utilcode:1.25.9) and jetified-utilcodex-1.26.0-runtime.jar (com.blankj:utilcodex:1.26.0)
  Duplicate class com.blankj.utilcode.constant.MemoryConstants found in modules jetified-utilcode-1.25.9-runtime.jar (com.blankj:utilcode:1.25.9) and jetified-utilcodex-1.26.0-runtime.jar (com.blankj:utilcodex:1.26.0)
  Duplicate class com.blankj.utilcode.constant.MemoryConstants$Unit found in modules jetified-utilcode-1.25.9-runtime.jar (com.blankj:utilcode:1.25.9) and jetified-utilcodex-1.26.0-runtime.jar (com.blankj:utilcodex:1.26.0)
  Duplicate class com.blankj.utilcode.constant.PermissionConstants found in modules jetified-utilcode-1.25.9-runtime.jar (com.blankj:utilcode:1.25.9) and jetified-utilcodex-1.26.0-runtime.jar (com.blankj:utilcodex:1.26.0)
  Duplicate class com.blankj.utilcode.constant.PermissionConstants$Permission found in modules jetified-utilcode-1.25.9-runtime.jar (com.blankj:utilcode:1.25.9) and jetified-utilcodex-1.26.0-runtime.jar (com.blankj:utilcodex:1.26.0)
  Duplicate class com.blankj.utilcode.constant.RegexConstants found in modules jetified-utilcode-1.25.9-runtime.jar (com.blankj:utilcode:1.25.9) and jetified-utilcodex-1.26.0-runtime.jar (com.blankj:utilcodex:1.26.0)
  Duplicate class com.blankj.utilcode.constant.TimeConstants found in modules jetified-utilcode-1.25.9-runtime.jar (com.blankj:utilcode:1.25.9) and jetified-utilcodex-1.26.0-runtime.jar (com.blankj:utilcodex:1.26.0)
  Duplicate class com.blankj.utilcode.constant.TimeConstants$Unit found in modules jetified-utilcode-1.25.9-runtime.jar (com.blankj:utilcode:1.25.9) and jetified-utilcodex-1.26.0-runtime.jar (com.blankj:utilcodex:1.26.0)
  Duplicate class com.blankj.utilcode.util.ActivityUtils found in modules jetified-utilcode-1.25.9-runtime.jar (com.blankj:utilcode:1.25.9) and jetified-utilcodex-1.26.0-runtime.jar (com.blankj:utilcodex:1.26.0)
  Duplicate class com.blankj.utilcode.util.AdaptScreenUtils found in modules jetified-utilcode-1.25.9-runtime.jar (com.blankj:utilcode:1.25.9) and jetified-utilcodex-1.26.0-runtime.jar (com.blankj:utilcodex:1.26.0)
  Duplicate class com.blankj.utilcode.util.ApiUtils found in modules jetified-utilcode-1.25.9-runtime.jar (com.blankj:utilcode:1.25.9) and jetified-utilcodex-1.26.0-runtime.jar (com.blankj:utilcodex:1.26.0)

你其他库也有引用到我的库把


Panning artifact during resize

When resizing if the user clicks outside the boundaries of the node shape, then a filled gray rectangle is drawn to provide panning effect. This is kind of misleading.

Seems fine now.


numpy.AxisError: axis 2 is out of bounds for array of dimension 2

Related issues:
https://github.com/jacobgil/pytorch-grad-cam/issues/254
https://github.com/jacobgil/pytorch-grad-cam/issues/394 (maybe)
Model is resnest14d from timm and I am regressing to a single scalar value
targets = [RawScoresOutputTarget()]         # Initially tried this
targets = [BinaryClassifierOutputTarget(1)] # Tried this after reading above issue, same result
cam_result = cam(input_tensor=image_tensor, targets=targets, eigen_smooth=False)

Debugger printout input args right before here:
https://github.com/jacobgil/pytorch-grad-cam/blob/2183a9cbc1bd5fc1d8e134b4f3318c3b6db5671f/pytorch_grad_cam/grad_cam.py#L16
(Pdb) input_tensor.size()
torch.Size([1, 3, 1152, 144])
(Pdb) target_layer
Linear(in_features=2048, out_features=1, bias=True)
(Pdb) targets
[<pytorch_grad_cam.utils.model_targets.BinaryClassifierOutputTarget object at 0x7effaa581af0>]
(Pdb) activations
array([[7.7802935]], dtype=float32)
(Pdb) grads
array([[1.]], dtype=float32)

Stack Trace
Traceback (most recent call last):
  File "test_and_produce_conc_data.py", line 113, in <module>
    main()
  File "/NeptuneCanister/dl_models/utils/hydra.py", line 108, in wrapper
    return func(cfg, args)
  File "test_and_produce_conc_data.py", line 82, in main
    cam_result = cam(input_tensor=images[i,:,:,:][None, :, :, :], targets=targets, eigen_smooth=False)
  File "/venv/lib/python3.8/site-packages/pytorch_grad_cam/base_cam.py", line 188, in __call__
    return self.forward(input_tensor,
  File "/venv/lib/python3.8/site-packages/pytorch_grad_cam/base_cam.py", line 95, in forward
    cam_per_layer = self.compute_cam_per_layer(input_tensor,
  File "/venv/lib/python3.8/site-packages/pytorch_grad_cam/base_cam.py", line 127, in compute_cam_per_layer
    cam = self.get_cam_image(input_tensor,
  File "/venv/lib/python3.8/site-packages/pytorch_grad_cam/base_cam.py", line 50, in get_cam_image
    weights = self.get_cam_weights(input_tensor,
  File "/venv/lib/python3.8/site-packages/pytorch_grad_cam/grad_cam.py", line 22, in get_cam_weights
    return np.mean(grads, axis=(2, 3))
  File "<__array_function__ internals>", line 180, in mean
  File "/venv/lib/python3.8/site-packages/numpy/core/fromnumeric.py", line 3432, in mean
    return _methods._mean(a, axis=axis, dtype=dtype,
  File "/venv/lib/python3.8/site-packages/numpy/core/_methods.py", line 168, in _mean
    rcount = _count_reduce_items(arr, axis, keepdims=keepdims, where=where)
  File "/venv/lib/python3.8/site-packages/numpy/core/_methods.py", line 76, in _count_reduce_items
    items *= arr.shape[mu.normalize_axis_index(ax, arr.ndim)]
numpy.AxisError: axis 2 is out of bounds for array of dimension 2

Is it possible that I'm just using the wrong target for scalar regression?
Maybe GradCAM class is only for conv layers?
This expects a hardcoded grad shape
https://github.com/jacobgil/pytorch-grad-cam/blob/2183a9cbc1bd5fc1d8e134b4f3318c3b6db5671f/pytorch_grad_cam/grad_cam.py#L22

Have the same problem with a binary classifier with the fully connected output layer of size (B, 1), when I select  this layer as the target, in combination with BinaryClassifierOutputTarget.
If I use the last convolution layer in the model before FC layers, it works. Also it works if I resize the output to (B, 1, 1, 1), but it produces meaninless heatmaps.
Looks like grad-cam expects spatial dimensions in the output. But according to the paper: our approach is
a generalization of CAM [59] and is applicable to a significantly broader range of CNN model families: (1) CNNs with
fully-connected layers (e.g. VGG).
Or am I doing something wrong? What is the right way of handling fully connected layers?

I meet the same question, do you solve it? thanks


Refresh OS after update and delete, formatting

Refresh OpenSearch after update and delete operations

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (c902b76) compared to base (b303be5).
Patch coverage: 100.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff            @@
##              main       #15   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           51        51
=========================================
  Hits            51        51

Impacted Files
Coverage Δ

fastapi_users_db_opensearch/__init__.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Remove lxml dependency

This PR removes the dependency on lxml as the xml parser for bs4. It's a rather heavy binary dependency and for what this tools does we really don't need the performance boost over the builtin parser.

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   83.09%   83.09%
=======================================
  Files          11       11
  Lines         491      491
=======================================
  Hits          408      408
  Misses         83       83

Impacted Files
Coverage Δ

src/aws_okta_processor/core/saml.py
88.57% <100%> (ø)
:arrow_up:

src/aws_okta_processor/__init__.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0d6d6d...0029385. Read the comment docs.

lxml henceforth was removed and there was much rejoicing.


Uri with backslash parsed differently than in browsers

Issue summary
Given uri<EMAIL_ADDRESS>League/uri parses that so host is www.host.com and attacker.com\ is username part.
However, if that uri  opened in browser, backslash is converted to forward slash, which seems to be common behavior; happening in Chrome and FF.
I am not sure if this is in scope of this lib. I could not find anything helpful in RFC2396 and RFC3986.
System informations

Information
Description

League\Uri version
4.1.1

PHP/HHVM version
5.6.*, 7.0

OS Platform
Ubuntu/CentOS

Standalone code, or other way to reproduce the problem
$parsed = (new League\Uri\UriParser())->parse('http://attacker.com\@www.host.com/');
var_dump($parsed);

Possibly expected result
array(8) {
  'scheme' =>  string(4) "http"
  'user' =>  NULL
  'pass' =>  NULL
  'host' =>  string(12) "attacker.com"
  'port' =>  NULL
  'path' =>  string(14<EMAIL_ADDRESS>  'query' =>  NULL
  'fragment' =>  NULL
}

Actual result
array(8) {
  'scheme' =>  string(4) "http"
  'user' =>  string(13) "attacker.com\"
  'pass' =>  NULL
  'host' =>  string(12) "www.host.com"
  'port' =>  NULL
  'path' =>  string(1) "/"
  'query' =>  NULL
  'fragment' =>  NULL
}

Maybe uris with backslashes should throw exceptions as they are technically invalid?
What do you think?

Well I'd go with throwing an exception since the \ character is invalid and the parser should not change the URI string.

@nyamsprod I am not sure about uris with file: scheme. Not sure if \ is valid there.

They are valid In Windows path but not in file scheme URI which are different specifications.

@kkopachev
Of note, in your report:

Browsers handle more than URI, they also handle, for instance, filesystem paths. In this regard, browsers behavior do not always align with RFCs.
Apart from the presence of the invalid character, the parser correctly parses the URI (according to RFC3986) so your possibly result is wrong.
URI generate from this invalid URI is correctly encoded (on the master branch) meaning that

<?php
use League\Uri\Schemes\Http as HttpUri;

echo HttpUri::createFromString('http://api.google.com\@toto.com/q?exp=a|b');
//displays 'http://api.google.com%5C@toto.com/q?exp=a%7Cb'

To correctly handle this bug I will have to make a BC break on how not only the parser works but also on how the components validates their respective component string. So correcting the bug in v4  implies a huge BC break that I'm not confortable with.
I would like to postpone the fix to the next major version where the BC break would be easier to implement and to document. What do you think ?

Hi @nyamsprod
All bullet points you made seem valid and reasonable for me.
My use case is to prevent open redirect vulnerability, when redirect destination is passed as query parameter. So I am parsing $_GET['destination'] to get host from the uri and then comparing such host with whitelist.
For my problem I see couple options here. One would be to modify $_GET['destination'] to be properly encoded; another - manually check uri for invalid characters and reject if found any. Currently I am using the last method.
I am totally fine with fixing that in the next major release due to BC break. However implementation should check for other invalid characters in other parts of uri. Not quite sure what implications that might have. For example, would there be a method to get properly encoded uri if given invalid uri? How would one recover from such exception?

@kkopachev exactly its because I wanted to take into account all invalid characters that it becomes a BC break.

Will there be an easy way to force-encode invalid characters rather then throw exception?

Will there be an easy way to force-encode invalid characters rather then throw exception?

What you are describing will be the default mode starting with version 4.2 and in accordance with PSR-7

Users can provide both encoded and decoded path characters. Implementations ensure the correct encoding as outlined in getPath().

so yes in essence invalid character will be encoded. But this won't be the case with submitted URI using the createFromString named constructor. Because the parser will reject them prior to instantiation. You will have to use  parse_url combined with the createFromComponents named constructor but then you'll depend on PHP's parse_url which is full of bugs :)

@kkopachev After some thinking this issue is similar to issue #85 . It may be badly documented but the real fact is that the Http class accepts URI and IRI as input but always returns URI in this regard what you observe is expected. And I believe this behavior will stay in the next release.

This issue is resolve using the league uri schemes repository and the league uri manipulations

Hello. I've read docs for both libraries and still don't understand how to use them to mitigate this problem. Can you give more info on the recommended flow here?

@sg2002 Well the fact is that there's no issue per se. Both packages parse the URL according to RFC3986 while modern browsers uses the WHATG parsing algorithm. So there's no way to add this mitigation to the package.
What you could do howerver is use the following package in PHP https://github.com/TRowbotham/URL-Parser


Package pcap v0.5.7 does not have these features: pcap-savefile-append

I added the feature to my .toml as the docu says:
pcap = { version = "0.5", features = ["pcap-savefile-append"] }
but cargo complains:
error: Package pcap v0.5.7 does not have these features: pcap-savefile-append
Am i doing it wrong, or is this a bug?
W10 64bit
MSVC toolchain
cargo-0.17.0-nightly (f9e5481 2017-03-03)
rustc 1.16.0 (30cf806ef 2017-03-10)

Oh, the feature was introduced in september '16 but the latest release was in april '16.
Could you push a new version to crates.io?

Just pushed 0.6.0. Thanks!

just tested it, but unfortunately 0.6.0 does not work on windows:
C:\Users\XXXXX\.cargo\bin\cargo.exe run
   Compiling pcap v0.6.0
error[E0432]: unresolved import `libc::sockaddr`
 --> C:\Users\XXXXX\.cargo\registry\src\github.com-1ecc6299db9ec823\pcap-0.6.0\src\raw.rs:4:54
  |
4 | use libc::{c_int, c_uint, c_char, c_uchar, c_ushort, sockaddr, timeval, FILE};
  |                                                      ^^^^^^^^ no `sockaddr` in the root

error: aborting due to previous error

error: Could not compile `pcap`.

I don't have windows to test on. maybe @aldanor can help? It looks like a libc crate API problem or something.

Unfortunately to them, it is working as intended (https://github.com/rust-lang/libc/commit/c4d4c70a36f82186f259fb6816b0b87997633940, https://github.com/rust-lang/libc/issues/45).
The winapi crate has a definition for sockaddr, but if i use it my programm using pcap crashes with exit code 0xC0000374 (heap corruption).
Why i cannot tell, the sockaddr structs from libc and winapi  look exactly the same to me.

Now Windows CI is working #113 #121 .


Feat: support k8s version 1.22 and 1.23

Q
A

Bug fix?
no

New feature?
yes

Breaking changes?
yes

Deprecations?
yes

License
Apache 2.0

What's in this PR?
This PR adds support for newer versions of k8s (version 1.22 and 1.23).
Along with the new feature:

Some deprecations were removed.
Cilium, local-path-provisioner, and auto-approver were updated.
Containerd was updated to 1.5.9.
Support of k8s version 1.17 and 1.18 was dropped
Converting kubeadm v1beta1 to v1beta2 was removed.
Support for ubuntu 18.04 and CentOS7, RHEL7 was dropped.
Support  AlmaLinux8 instead of CentOS8.

Checklist

[x] Code meets the Developer Guide
[x] User guide and development docs updated (if needed)

just realized this is happening, so much wow thanks!


[tests] fix flakey pubsub test

One of the pubsub tests intermittently fails with timeout issues, we need to correct this. Here is the log of the failing test:
Pubsub subsystem operates correctly
       pubsub with intermittent connections
         should handle quick reconnects with a delayed disconnect:
     Error: Timeout of 5000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/travis/build/libp2p/js-libp2p/test/pubsub/operation.node.js)
      at listOnTimeout (internal/timers.js:549:17)
      at processTimers (internal/timers.js:492:7)

@jacobheun can you replicate this locally?
I have never seen that test failing and I just tried it out locally several times running only the pubsub tests

No, i've just seen it in CI. The latest run was linux node 10 here, https://github.com/libp2p/js-libp2p/runs/869245153. We likely just need the test to be more thorough with when events are happening.

I could not replicate it yet. Let me know if you see this in CI again. https://github.com/libp2p/js-libp2p/pull/698 might also help with this

I got it now, it is stil la valid issue: https://travis-ci.com/github/libp2p/js-libp2p/jobs/361764759


Adding OIDC support for webdav authentication

Continuing from the discussion here:
https://forum.rclone.org/t/supporting-oidc-authentication-for-a-webdav-server/6080
What is the problem you are having with rclone?
I would like to use OpenID-Connect (OIDC) when authenticating with a webdav server.
Although the latest beta of rclone supports webdav authentication with a bearer token and the OIDC access token may be used as such, I would also like rclone to handle obtaining the access token from the OIDC Provider (OP) and refreshing the access token as necessary.
Also, ideally rclone would be able to register itself with the OP, provided the OP supports dynamic client registration.
Which cloud storage system are you using? (eg Google Drive)
dCache

I haven't had time to work on this... Would anyone like to help?

I've been exploring a related project: oidc-agent.  This handles obtaining the access-token, so the application doesn't need to worry about this.
The core concept is that there is a user has an oidc-agent daemon process running (much like ssh-agent).  For the available OPs, there is a refresh token is stored encrypted on disk.  The oidc-agent software provides a mechanism for achieving this.
The encrypted refresh token be uploaded into the oidc-agent's memory, using the oidc-add command (again, much like ssh-agent and ssh-add command).  Once the refresh token is in the agent's memory, client applications may request an access token.  The oidc-agent either returns the cached value, or fetches a new access token from the OP, using the refresh token.
There is an example application, oidc-token, that simply requests an access token from the agent.  This may be used directly, but applications can also request an access token directly from the agent using some IPC.
Here's a trivial example of using oidc-token to authorize a curl REST call (against dCache's user introspection endpoint), using an access token from the Unity-HDF OP.
curl -H "Authorization: bearer $(oidc-token Unity-HDF)" https://prometheus.desy.de:3880/api/v1/user

An option for adding OIDC support would be to extend the newly added arbitrary bearer token support in rclone, so that a command may be specified instead.  Running the command should yield the bearer token as the first line on stdout.
There are (at least) two ways that this could work:

rclone could run the command before every WebDAV command, relying on the application to cache the bearer token between requests (as appropriate),
rclone could fetch a new bearer token for the first WebDAV command and then subsequently if it receives a 401 response.

I guess such a change (especially 1.) would be relatively easy to implement.

The oidc agent looks interesting.  That would be pretty easy to integrate into rclone I think.  Your option 2 would probably be the right one.
This could be a parameter (which could go in the config file) --webdav-bearer-token-command "oidc-token UnityHDF".  So rclone would run the command "oidc-token UnityHDF" to get back a bearer token.
Is that what you were thinking of?
...
I found a go client library https://github.com/coreos/go-oidc
Which appears to do all the right things, though since I haven't studied OIDC in depth I'm not sure exactly where all the bits fit!  What do you think of that library?

Yes, that sounds good -- especially about going for option 2.  The --webdav-bearer-token-command (and corresponding configuration) is exactly what I hoped for, when looking at the oidc-agent project: a relatively simple way to obtain the bearer token dynamically.
From what I can tell, the go-oidc project looks reasonable, but I haven't investigated it thoroughly (just flicked through the code).  I guess it is following the Authorization Code Flow, where the browser provides a token that the client then uses (along with its secret) to fetch the access token and id tokens.

OK I've made a proof of concept here
https://beta.rclone.org/branch/v1.43-031-gb7c6e4b0-fix-2380-oidc-beta/ (uploaded in 15-30 mins)
You can use the --webdav-bearer-token-command  or put "bearer_token_command" in the config file (it is in the advanced section of the configurator).
It doesn't refresh any tokens yet, and has no documentation yet!
Let me know what you think!

That is a good start :-) Thanks for testing.  I'll have a think about refreshing the tokens next.

I've demoed the beta version of rclone to a few different groups, and people have been very impressed.

Great :-)

Although rclone will ultimately do the refresh itself, is there a way a user can force rclone to fetch a fresh access-token in the beta version? Perhaps by deleting a file somewhere?

Not at the moment.

I'd like to give this to some "early adopter" users to do some more extensive tests of using rclone with OpenID-Connect (via oidc-agent). In our case, the access tokens are good for an hour, so I think a manual process would be acceptable for limited, basic testing.
Also, can I do anything to help out here?

Do you happen to know which http access code is generated when the token expires?  I would expect it to be 401 but if you could check that would be very helpful :-)
Here is a version which will refresh the token on a 401 error.  If it gets a 401 error it will refresh the token and try the operation again.  This should work reasonably well, but it won't be quite seamless on upload as rclone will have to retry the sync to upload missed files.  Ideally rclone would know when the token expires and refresh it a bit before that.
https://beta.rclone.org/branch/v1.43-093-gb2855cd8-fix-2380-oidc-beta/ (uploaded in 15-30 mins)
Can you give that a test please? You can view the headers of the http transactions with -vv --dump headers if you want to check which HTTP transactions go out.
Also if you could write a paragraph for me to stick in the docs about using --webdav-bearer-token-command  or the config equivalent and oidc-agent that would be really helpful!

Do you happen to know which http access code is generated when the token expires? I would expect it  to be 401 but if you could check that would be very helpful :-)

I don't believe this is standardised, but dCache will return 401.

[...] Ideally rclone would know when the token expires and refresh it a bit before that.

Yes, unfortunately this information is currently unavailable through the oidc-agent API.  It could be that OP simply doesn't provide this information, so we just don't know.

Can you give that a test please?

Sure, will do.

write a paragraph

Sure.  Would you like this as a pull-request, or via some other mechanism?

I'm the developer of oidc-agent and want to share some thoughts.

[...] Ideally rclone would know when the token expires and refresh it a bit before that.

Yes, unfortunately this information is currently unavailable through the oidc-agent API. It could be that OP simply doesn't provide this information, so we just don't know.

We will release oidc-agent v2.0.0 tomorrow. In the new version we included the possibility to get the time when the token expires. But as Paul said, it is possible that the OP doesn't provide the information. (In that case oidc-agent will return 0). So refreshing on 401 seems reasonable. But when the OP provides that information, it can be retrieved from oidc-agent and used.
Calling oidc-token to get the access token is only one way how an access token can be retrieved from oidc-agent. We also provide an easy to use C-API and an application can also communicate through IPC with oidc-agent. However, this might mean higher development effort on your side.
It's also fine to use oidc-token. Just wanted to make sure you know that there are also other ways.

I've merged this to master now which means it will be in the latest beta in 15-30 mins and released in v1.49.
Thank you for your docs @paulmillar - I've included those too :-)


Add pyproject.toml for Custom Node Registry

We are building a global registry for custom nodes (similar to PyPI). The registry makes using custom nodes more reliable by reserving globally unique names for each custom node, and supporting semantic versioning.
Here’s some more information on the registry.
Action Required:

[ ] Go to the registry. Login and create a publisher id. Comment it here and we will update the PR (or just merge it and change it yourself).
[ ] Write a short the description.
[ ] Merge the separate Github Actions PR and run the workflow.

If you want to publish the node manually, install the cli and run comfy node publish
Please message me on Discord if you have any questions!

hey @ALatentPlace, wanted to send a small nudge and ask if you had any questions!


setup.py install is deprecated

Bug Template
Title: setup.py install is deprecated
Description:

What issue is being seen?  Describe what should be happening instead of the bug, for example: Cartography should not crash, the expected value isn't returned, the data schema is wrong, etc.

https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html
https://peps.python.org/pep-0517/
https://github.com/microsoft/LightGBM/issues/5061

To Reproduce:

Steps to reproduce the behavior.  Provide all data and inputs required to reproduce the issue.

$ dpkg -l python3 python3-setuptools
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name               Version        Architecture Description
+++-==================-==============-============-=========================================================================
ii  python3            3.10.6-1~22.04 amd64        interactive high-level object-oriented language (default python3 version)
ii  python3-setuptools 59.6.0-1.2     all          Python3 Distutils Enhancements
$ git clone https://github.com/lyft/cartography.git
Cloning into 'cartography'...
remote: Enumerating objects: 11267, done.
remote: Total 11267 (delta 0), reused 0 (delta 0), pack-reused 11267
Receiving objects: 100% (11267/11267), 5.89 MiB | 17.33 MiB/s, done.
Resolving deltas: 100% (8068/8068), done.
$ cd cartography/
$ python3 setup.py install
running install
/usr/lib/python3/dist-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
  warnings.warn(
/usr/lib/python3/dist-packages/setuptools/command/easy_install.py:158: EasyInstallDeprecationWarning: easy_install command is deprecated. Use build and pip and other standards-based tools.
  warnings.warn(
/usr/lib/python3/dist-packages/pkg_resources/__init__.py:116: PkgResourcesDeprecationWarning: 0.1.43ubuntu1 is an invalid version and will not be supported in a future release
  warnings.warn(
/usr/lib/python3/dist-packages/pkg_resources/__init__.py:116: PkgResourcesDeprecationWarning: 1.1build1 is an invalid version and will not be supported in a future release
  warnings.warn(
running bdist_egg
running egg_info
creating cartography.egg-info
writing cartography.egg-info/PKG-INFO
writing dependency_links to cartography.egg-info/dependency_links.txt
writing entry points to cartography.egg-info/entry_points.txt
writing requirements to cartography.egg-info/requires.txt
[...]

Please complete the following information::

Cartography release version or commit hash: HEAD, 6e6e69d3879f0c02950499d5a6f2e5887e0c72db
Python version: 3.10.6
OS (feel free to omit this if you don't think it's relevant to your issue): Ubuntu 22.04 but likely applicable to others

Hey, I skimmed the docs you linked and I see that running python setup.py install is deprecated, but I don't see anything else. Given that our docs say to use pip install cartography (https://lyft.github.io/cartography/install.html#install--page-root), is there still an action that we need to take?

I'm also new to this.
My understanding is that project should move to pyproject.toml + setup.cfg and at one point setup.py will be deprecated but no clear date.
other resources

https://setuptools.pypa.io/en/latest/userguide/quickstart.html#transitioning-from-setup-py-to-setup-cfg

Transitioning from setup.py to setup.cfg
To avoid executing arbitrary scripts and boilerplate code, we are transitioning into a full-fledged setup.cfg to declare your package information instead of running setup(). This inevitably brings challenges due to a different syntax. Here we provide a quick guide to understanding how setup.cfg is parsed by setuptools to ease the pain of transition.

https://peps.python.org/pep-0518/
https://snarky.ca/what-the-heck-is-pyproject-toml/
https://ianhopkinson.org.uk/2022/02/understanding-setup-py-setup-cfg-and-pyproject-toml-in-python/
https://godatadriven.com/blog/a-practical-guide-to-setuptools-and-pyproject-toml/

I will have PR to switch to pyproject.toml for build
https://github.com/chandanchowdhury/cartography/compare/chandanchowdhury:cartography:master...development
Unfortunately, my development branch has unmerged commits for another PR, so don't want to send these yet just in case other PR do not get merged.


Fix example pipeline.py

To make the example run you also need to import Pipeline from "kedro.pipeline" as well as node.
e.g. this:
from kedro.pipeline import node, Pipeline
otherwise the user will get a "NameError: name 'Pipeline' is not defined" error.
Notice

[x] I acknowledge and agree that, by checking this box and clicking “Submit Pull Request”:

I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

Motivation and Context
Why was this PR created?
How has this been tested?
What testing strategies have you used?
Checklist

[x] Read the contributing guidelines
[ ] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[x] Updated the documentation to reflect the code changes
[ ] Added new entries to the RELEASE.md file
[ ] Added tests to cover my changes
[ ] Assigned myself to the PR
[ ] Added Type label to the PR

Hi @dazzag24! Thank you for contributing to Kedro! We agree with your change and are happy to merge the change. Could you please tick the acknowledgement and see the checklist, so we can approve and merge the PR?

Hi,
I have ticked the acknowledgement box.  Have also ticked the relevant checkboxes...

@dazzag24 Thank you for picking up this error! Could you add yourself to our RELEASE.md so that we can acknowledge your contribution?

@dazzag24 thanks a lot for your contribution! We hope you enjoyed the tutorial. We are always happy to receive feedback, so if you have any new ideas and suggestions, please feel free to share :)


Needs rebase.

Rebased


Restore multi-sim colors

This is used to assign color to sim card and it shouldn't be one color.

@westcripp

@AndropaX  ok good . can you change teal 700 with this #536DFE and teal 800 : #5C6BC0 . its depreciated color on rr m

or anyways . its meged

But it's one problem, that colors are named in sim management settings and that would need change it in all languages

yeah i forgot it . so i have no m sim device and no this option ..lol


kodi blanks display after a few minutes idle

Issue description
Just updated from 17.09 to 19.03 and now after no action for a while the screen goes dark, as a side issue I can't "wake it up" with my xbox controller, but with a keyboard I can.
But the real question is why does it fall asleep at all. I find nothing in kodi settings and I even added logind ignore behaviour:
services.logind.extraConfig = "IdleAction=ignore";

logind.conf
[Login]
KillUserProcesses=no
HandleLidSwitch=suspend
HandleLidSwitchDocked=ignore
HandleLidSwitchExternalPower=suspend
IdleAction=ignore

ok just tested it without my ".kodi" directory and the same result, so it must be something nixos / xorg related, after 10 minutes the screen goes blank.
Technical details

system: "x86_64-linux"
host os: Linux 4.19.42, NixOS, 19.03.172604.7cd2e4ebe8c (Koi)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.2.2
channels(root): "nixos-19.03.172604.7cd2e4ebe8c"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Does your xbox controller work with kodi at all? Which desktop environment are you running? We might need your configuration.nix to better troubleshoot.

Funny enough it does not only work (controller) but I could even kick out all xboxdrv code, which I tested after I wrote this bug report so the removel did not cause that which was that.
The desktop environment is xserver or do you mean the desktop manager? that would be kodi that should be the relevant parts of the config:
  environment.systemPackages = with pkgs; [
      nmap python3 youtube-dl libvdpau-va-gl vaapiVdpau glxinfo
      vdpauinfo certbot openssl retroarch kodiPlugins.advanced-launcher
      kodiPlugins.pdfreader zsnes dmidecode nixops
  ];

  # Enable the X11 windowing system.
  services.xserver = {
    enable = true;
    layout = "dvorak";
    xkbOptions = "eurosign:e";
    displayManager.lightdm.autoLogin = {
      user = "my-user";
      enable = true;
    };
    desktopManager.default = "kodi";
    desktopManager.kodi.enable = true;
  };

  services.logind.extraConfig = "IdleAction=ignore";
  nixpkgs.config.KodiPlugin = {
    advanced-launcher = true;
    enablePeripheralJoystick = true;
    # enableControllers = true; # might not be needed
  };

  nixpkgs.config = {
    kodi = {
      enableJoystick = true;
    };
  };

  hardware.opengl.enable = true;
  hardware.opengl.extraPackages = [ pkgs.libvdpau-va-gl pkgs.vaapiVdpau pkgs.vaapiIntel];

I just switched to xfce and it also goes to sleep after 10 mins or so. os it's not a kodi problem, except that the controller don't wakes the display, but that it blanks the screen is the major problem.
Btw I see a cursor (a x) at the end of a video, when I don't use a mouse which also makes not much sense.

With regards to your cursor issue I have added the unclutter-xfixes package to my dedicated htpc setups and then execute it on login. This hides the cursor when the mouse isn't being moved.
As far as blank display you might consider trying something like this.

That works as workaround:
    services.xserver.displayManager.setupCommands = ''
      /run/current-system/sw/bin/xset -dpms
      /run/current-system/sw/bin/xset s off
    '';

But I don't see that as a fix, while I could see a 10 min blank as a default that some people want, that the controller can't wake up the blankscreen is surely not a good default.
But I even wonder if that is a good default for kodi, it might make sense for xfce and gnome but for kodi?

@spiderbit I definitely agree if the controller can't wake up the screen that is a problem. The controller works with kodi when the screen is on, right?

Yes

@spiderbit If you find value in the above behaviour you could create a PR modifying https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/x11/desktop-managers/kodi.nix to add your snippet above.
As far as the controller goes... I assume you don't know if this was an issue with 17.09 because you didn't have the screen off issue?
Might we consider this issue resolved?

Well technically we could close this bug I guess but wouldn't you keep it open till such a PR was accepted?
But then we need a new bug for the not registered (to wake up) controller behavior, right?
How would you do include that code? disable power management completely in kodi generally? or give a boolean toggle for it? If you disable it hard coded then I guess this bug could be closed. I just wonder if some people could prefer the current behavior with the blanking?
Well I don't need it and till somebody finds a fix for the controller thing and wants that behavior it's probably better to deactivate the blanking (at least as default)

Since you don't know if the controller would wake-up your screen in 17.09 I'm not entirely sure if this is a bug or just the way xboxdrv operates. I guess we should determine that first. Good point.

No, I don't use xboxdrv anymore at this moment, because apparently the normal evdev bits are enough to recognize my controller.
But the sleep bug was there before I changed that.

So I had the same issue using kore (the remote android app), and I could have sworn waking the screen worked in the past, but then I saw this post: https://forum.kodi.tv/showthread.php?tid=342934.
Long story short, I set xfce to never blank/shut the screen in the power saving options, and enabled it in kore (in power saving options as well), and now I can wake the screen.
I tested it also with my xbox controller, to ensure it was the same issue. Funny thing is moving up/down does not unlock the screen, but pressing a button does, so I hope this does the trick for you.


2CH dimmer switch module doesn't work correctly

Describe the bug
By adding a 2CH dimmer switch module I don't get the second switch dat is related on that module.
I can toggle only one switch to put ON or OFF.
Steps To Reproduce
Steps to reproduce the behavior:

Add a 2CH dimmer switch module
You see only one buttons to switch 1 ON or OFF but the second one is missing

Plugin Version
1.1.5
Homebridge Config
 {
     "name": "TuyaWebPlatform",
     "options": {
         "username": REDACTED,
         "password": REDACTED,
         "countryCode": REDACTED,
         "platform": "tuya",
     },
     "scenes": false,
     "platform": "TuyaWebPlatform"
 }

This is a known problem; multiple outputs are not supported by the API that this plugin uses.
You can verify this yourself by executing the python script which is linked in the readme.

The header "How to check whether the api this library uses can control your device". in t he readme
Should contain all the information that you need.


followup #10594: re-benchmark pallet-lottery

Follow up for #10594 to update the weights since I used a fork where the benchmark bot could not push to.
Contains a doc fix so that I can open this MR.

/benchmark runtime pallet pallet_lottery

bot merge

bot merge


Getting lots of Task Canceled Exception when using Azure Search .Net SDK to merge or upload documents asynchronously

We are using Azure Search .Net SDK(v3.0.4) to merge or upload documents to one of the azure search index.
We are using the below code for the same:
var batch = IndexBatch.MergeOrUpload(documentList);
await searchIndexClient.Documents.IndexAsync(batch);
We are indexing 2 types of subindexes using the same search client. When there is a high load, we are facing lots of task cancelled exceptions and the operation is failing without any hint to inner exceptions. Can someone help me here why this issue might be there?
Stacktrace for reference: System.Threading.Tasks.TaskCanceledException: A task was canceled. at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Rest.RetryDelegatingHandler.<>c__DisplayClass11_0.d.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Rest.RetryDelegatingHandler.d__11.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Net.Http.HttpClient.d__58.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Azure.Search.DocumentsOperations.d__23.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.Azure.Search.DocumentsOperationsExtensions.d__13`1.MoveNext() --- End of stack trace from previous location where exception was thrown ---

@SONIA111111 Thanks for reporting this. This looks like a service issue rather than a client issue, so I'm going to close this and follow up with you through other channels.


feature: Let users see what settings/config was used in previous meltano runs

Feature scope
Configuration (settings parsing, validation, etc.)
Description
My use case about this was with Meltano Cloud, but I think it might be useful to the wider Meltano community.
I would like to be able to see what settings/config my Meltano Cloud runs were executed with. Think this makes sense to output with logs as this keeps everything relevant together, and if possible with the default being all sensitive credentials redacted.
For me this would help with not only debugging but tuning my meltano runs as well.
There are some taps and targets I use that allow for amount of retries, or poll intervals or batch-sizes, and being able to keep track of and slowly tweak these settings over time would be awesome.

Thanks for the suggestion @DanielPDWalker! I'm a fan of this idea, and am thinking we can implement it as part of the settings/config refactor we have vaguely planned for the future.
Relates to:

https://github.com/meltano/meltano/issues/7400 (through implementing this we hope to centralize and simplify Meltano's config handling, which would make it easier to implement this feature)
https://github.com/meltano/meltano/issues/3045
https://github.com/meltano/meltano/issues/6939
https://github.com/meltano/meltano/issues/6726
https://github.com/meltano/meltano/issues/3252

This is probably also related to the functionality built into Meltano for the meltano compile command that produces a manifest file. More work needs to be done there (e.g. https://github.com/meltano/meltano/issues/7306) to support using it as a single source of truth for config.


Isn't it logical to not show history for someone without access?

Codecov Report

Merging #266 into master will decrease coverage by -0.35%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
- Coverage   97.48%   97.13%   -0.35%
==========================================
  Files          12       12
  Lines         557      559       +2
  Branches       66       67       +1
==========================================
  Hits          543      543
- Misses          7        8       +1
- Partials        7        8       +1

Impacted Files
Coverage Δ

simple_history/admin.py
96.11% <0%> (-1.91%)
:x:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d76e446...c814815. Read the comment docs.

Thanks @ambivalentno!
If someone would like to add tests for permission success/failure case, I think this will make sense to merge.


Support for writing Option values as Avro union types

Using avro-rs version 0.6.5:
use serde::Serialize;
use avro_rs::{Schema, Writer};

#[derive(Serialize)]
struct Foo {
    bar: Option<String>,
}

fn main() {
    let schema = Schema::parse_str(r#"{
        "name": "Foo",
        "type": "record",
        "fields": [
            {"name": "bar", "type": ["null", "string"]}
        ]
    }"#).unwrap();
    let mut writer = Writer::new(&schema, Vec::new());
    writer.append_ser(Foo { bar: None }).unwrap();
}

This would be the canonical way to indicate a nullable field in Avro. However, when serializing, it produces the error ValidationError("value does not match schema").
Even if I change the definition of bar to be just String instead of Option<String> I get the same error, although strings are a subset of legal fields according to the schema.
(As an aside, it would also be useful if the error specified which value did not match which schema.)

Please ignore, I made a typo and this is actually working fine, sorry for the noise!


Game pause and resume have no effect

Version

Phaser Version: 3.60.0-beta.10 to 3.60.0-beta.18

Description
Calling game.pause() doesn't seem to pause the game.

Yeah forgot to finish that part off. Done now.


DDCE-4980: Increase the maximum value for goods movements

Threshold allowance for goods imported and exported is increased from £1500 to £2500
Removed threshold value from messages and used directly in html templates

Will be merged when received confirmation


P4-OVS: Introduce support for tap port creation

This patch introduces support required for tap port creation and
GNMI cli enhancements for pipeline name, mtu value and mempool
name DPDK port configuration.
Example commands:
With all parameters: sudo gnmi-cli set "device:virtual-device,
name:TAP0,pipeline-name:pipe,mempool-name:MEMPOOL0,mtu:1500,port-type:TAP"
Default parameters skipped: sudo gnmi-cli set "device:virtual-device,
name:TAP1,mtu:1500,port-type:TAP"
Title: Introduce support for tap port creation
Change-type: FeatureImplementation
Signed-off-by: nupuruttarwar<EMAIL_ADDRESS>

Nice! Will have a look after the weekend but don't wait for me if you want to merge!👍


Warlock doesn't throw enderpearls, he just pushes them up

Video: http://sendvid.com/fwe1xww1
The Warlock should be throwing an enderpearl that pushes them up when hit.
But instead, he just pushes them up with a non-existant enderpearl
I think you missed it last time I sent you the video ;p
Thanks,

xBiscuit

Also, since I can't seem to find a way to contact you, how can you equip a citizen with tipped arrows but still holding a bow? I want a citizen to shoot spectral arrows.

Yeah that's intentional.
I didn't feel like trying to manage and clean up the mess of spawning ender pearls there when there was no actual usage of them needed.
You can contact me via http://one.denizenscript.com/ircchat_denizen <-- my usual IRC channel, full of Citizens/related chatter.
And use /npc inventory to give it items to uses separate from its held item.

I think it adds a lot to the effect when throwing the held item. Any enderpearl thrown in the general direction will do it, i don't care if it doesn't directly hit. If its too messy then its fine, thanks anyways!

Eh... Denizen can add such an effect far easier than Sentinel can, thanks to it already having relevant internals that interact with lower-level minecraft code.
So, if you or anyone reading this really want such an effect, I would recommend the first attempt be made via attaching a script in Denizen or somethin https://wiki.citizensnpcs.co/Denizen - can give help for that in the IRC link above if there's trouble completing that.


Fix Requires-spl syntax

After submitting a PR with the Requires-spl: keyword all subsequent build requests will use the same SPL commit instead of defaulting back to master.  Restarting the build master resets the SPL dependency and is the current work around the issue.

I believe the issue is with ss = self.codebases[codebase] in CustomSingleBranchScheduler.getCodebaseDict. I believe ss is a shallow copy of the dictionary pulled from self.codebases.
There are copy tools in python that can be used to make a deep copy. I'll make a pull request shortly. I'm not sure how we would be able to actually test it though.

@dinatale2 if you can propose a patch I'm sure we can find some idle time on the buildbot to put it in place for testing.


Godot 3d, grid missing when mesh instance is visible.

Godot version: 3.2.1
OS/device including version: Windows 10/ asus X441UA
Hi everyone,
When I create a mesh instance node and it is visible, the grid is lost, and sometimes, the mesh instance turn on black, depending on the angle of view.
I will be grateful to anyone who can help me. Thanks.

Looks like a duplicate of https://github.com/godotengine/godot/issues/30330
Are you on integrated graphics or discrete?
Also GLES2 or GLES3?

I have integrate graphics Intel hd graphics 520, and I use GLES3 but when I switch for GLES2 the bug disapier.

Thanks for following up.
It appears it is a duplicate of #30330, so we will track the issue there.


Is there a Lightning Reopen for Firefox?

I really like this on my Chrome browser. I also use Firefox on my Linux laptop and could really use it there too. Any chance of a Firefox version?

Firefox does not support the background permission for extensions and therefore it's not currently possible.


Otherwise this issue doesn't hold any water.

Yea, it's absolutely not.
Still, do be careful where you put your token.


Missing dates

This date picker is actually missing dates
For example, July the 31st, 1992.

For anyone else, there's a Flutter date picker: https://flutter-widget.live/widgets/CupertinoDatePicker but it doesn't look as good :-/

I was facing the same issue previously. set true or false to  onMonthChangeStartWithFirstDate will fix the issue.

I was facing the same issue previously. set true or false to onMonthChangeStartWithFirstDate will fix the issue.

Hi, can you elaborate more on how you solve this problem?

I was facing the same issue previously. set true or false to onMonthChangeStartWithFirstDate will fix the issue.

Hi, can you elaborate more on how you solve this problem?

For those who is wondering, just set true like this
this.onMonthChangeStartWithFirstDate = true,


Question: is there any built in function to determine if a point is inside a 3D convex polygon ?

first of all : thanks for your lib.
Question: is there any built in function to determine if a point is inside a 3D convex polygon ?
Thanks for your kind reply in advance,
Péter

No, there is not. This library is strictly for finding the convex hull. Please refer to TVGL's MiscFunctions.cs (https://github.com/DesignEngrLab/TVGL) for functions such as this.