Rebase to upstream main @ 0f7a6d9

Process:

Identify commits

$ git log --oneline --no-merges upstream/master..midstream/master
where midstream is the opdev remote.

Create merge commit with mistream/master and upstream master@0f7a6d9 as parent commits

$ git remote update # make sure we update our refs $ git checkout upstream-master # upstream go-rpmdb master@0f7a6d9 $ git checkout -b merge-tmp # create a branch to do our merge work from $ git checkout midstream/master # we want to be at the tip of the opdev master branch when we run the next command $ echo 'merge knqyf263/go-rpmdb master@0f7a6d9' | git commit-tree merge-tmp^{tree} -p HEAD -p merge-tmp -F - deadbeef12345678 # output of last command and id of new merge commit $ git branch merge-gorpmdb deadbeef12345678 # create a new branch for the cherry-pick work $ git checkout merge-gorpmdb
The resulting merge commit is 0914d53

Cherry-pick all necessary commits identified in line 1
Some commits that were local to this fork don't need to be kept in the rebase. An upstream commit that was manually ported to this fork is already in upstream master, so it was dropped.

The full list of dropped or squashed commits is:
e050c90 Add go 1.16.x and go 1.17.x to the test matrix
The full list of commits that were kept is (cherry-picked from bottom to top) The summaries have been updated to make them easier to identify:
2f7cd32 UPSTREAM: <carry>: Add support for PGP signatures 33e2691 UPSTREAM: <carry>: adding in summary tag

/lgtm


Radeon VII memory access fault training

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Mint Linux, Kernel 4.15.0-52
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 1.13.1
Python version: 3.65
ROCm/MIOpen version: 2.5.27
GPU model and memory: Radeon VII

Describe the current behavior
Fine-tuning BERT using this checkpoint or that checkpoint on a task with a considerably large number of labels (2000) crashes with a memory access fault in 70% of the cases:
Memory access fault by GPU node-1 (Agent handle: 0x55b34b19c5b0) on address 0x7f0cc7dff000. Reason: Page not present or supervisor privilege.
Aborted (core dumped)

Memory access fault by GPU node-1 (Agent handle: 0x55fb4ce57a60) on address 0x7f6757dff000. Reason: Page not present or supervisor privilege.
Aborted (core dumped)

In contrast to #414, temperature is not the issue here, edge and memory are between 40°C and 50°C, junction around 70-80°C.

In the other 30%, it crashes with #325:
InvalidArgumentError (see above for traceback): Input to reshape is a tensor with 800 values, but the requested shape has<PHONE_NUMBER>217143831
	 [[node gradients/bert/encoder/layer_0/output/LayerNorm/moments/mean_grad/Reshape (defined at /home/tobi/bert-sticker/optimization.py:71) ]]

The same code runs just fine on Nvidia M60, P100 and 1070.
Describe the expected behavior
There should be no memory corruption issues.
Code to reproduce the issue
I'm looking into producing a simpler reproducer.

/cc @dagamayank for awareness. It's weird that we've also ran BERT for multiple weeks and never encountered any of these issues.

/cc @dagamayank for awareness. It's weird that we've also run BERT for multiple weeks and never encountered any of these issues.

@sebpuetz observes the same crashes.

The time until it crashes also varies a lot.
The last run crashed after 1 hour and 6k steps:
Memory access fault by GPU node-1 (Agent handle: 0x5583050118d0) on address 0x7f171c1ff000. Reason: Page not present or supervisor privilege.
Aborted (core dumped)

After restarting, it crashed after 30 steps:
Memory access fault by GPU node-1 (Agent handle: 0x56257cc71be0) on address 0x7fc4f29ff000. Reason: Page not present or supervisor privilege.
Aborted (core dumped)

+@micmelesse
@micmelesse, could you try the checkpoints?

It's not connected to the checkpoints, it also happens when training from scratch.

dmesg of two crashes:
[42145.304293] gmc_v9_0_process_interrupt: 11 callbacks suppressed
[42145.304298] amdgpu 0000:03:00.0: [gfxhub] no-retry page fault (src_id:0 ring:24 vmid:8 pasid:32771, for process  pid 0 thread  pid 0)
[42145.304301] amdgpu 0000:03:00.0:   in page starting at address 0x00007f171c1ff000 from 27
[42145.304303] amdgpu 0000:03:00.0: VM_L2_PROTECTION_FAULT_STATUS:0x00801030
[42145.304309] Evicting PASID 32771 queues
[42145.469445] Started evicting pasid 32771
[42145.469448] Finished evicting pasid 32771
[42252.230309] perf: interrupt took too long (4011 > 3912), lowering kernel.perf_event_max_sample_rate to 49750
[42349.843335] Signal event wasn't created because limit was reached
[42990.023970] Signal event wasn't created because limit was reached
[43168.584558] Signal event wasn't created because limit was reached
[43210.625043] amdgpu 0000:03:00.0: [gfxhub] no-retry page fault (src_id:0 ring:24 vmid:8 pasid:32771, for process  pid 0 thread  pid 0)
[43210.625046] amdgpu 0000:03:00.0:   in page starting at address 0x00007fc4f29ff000 from 27
[43210.625048] amdgpu 0000:03:00.0: VM_L2_PROTECTION_FAULT_STATUS:0x00801030

@micmelesse would try reproduce on Radeon VII, earlier we were running on MI parts

@twuebi Can you post the exact line that you use to do the fine tuning. Are you using the run_classifier.py, run_squad.py or your own custom code?

I modified run_classifier.py to work for sequence labeling. The label set is ~2k labels. The dataset is not public, I am putting something together that I can share.

This archive contains the necessary bits. (Same task, different dataset)

I've confirmed that it also crashes on this data:
Memory access fault by GPU node-1 (Agent handle: 0x56249bd69990) on address 0x7f95aa9ff000. Reason: Page not present or supervisor privilege.
Aborted (core dumped)

Commands:
bert_config.json and bert-base-german-cased-vocab.txt are taken from this checkpoint. It shouldn't matter much, I've also observed memory faults with vocab & config of the multilingual BERT.
From scratch:
python run_classifier.py --output_dir . --data_dir . --do_train --do_predict --do_eval --vocab_file bert-base-german-cased-vocab.txt  --bert_config_file bert_config.json --train_batch_size 48 --learning_rate 0.0002 --num_train_epochs 15 --max_seq_length 110 --do_lower_case false

Fine-tune:
python run_classifier.py --output_dir . --data_dir . --do_train --do_predict --do_eval --vocab_file bert-base-german-cased-vocab.txt  --bert_config_file bert_config.json --train_batch_size 48 --learning_rate 0.0002 --num_train_epochs 15 --max_seq_length 110 --do_lower_case false --init_checkpoint bert-base-german-cased

It may be a coincidence, but I've got the impression that getting close to the memory limits leads to earlier crashes.

edit: you may want to increase num_train_epochs to some larger number.

How large?

50? It doesn't influence the frequency of the crashes. It just avoids the
need to restart the training if it didn't crash within num_train_epochs.
Michael Melesse<EMAIL_ADDRESS>schrieb am Fr., 5. Juli 2019,
05:13:

edit: you may want to increase num_train_epochs to some larger number.
How large?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ROCmSoftwarePlatform/tensorflow-upstream/issues/534?email_source=notifications&email_token=AFSZM3BQURRBT43RWQWRR33P52335A5CNFSM4H472PLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZINXUY#issuecomment-508615635,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFSZM3CSY4MLU2TMIWM2NC3P52335ANCNFSM4H472PLA
.

@twuebi Ok, I will run the example for 50 epochs and see if I observe a crash. In the mean time can you use one of our standard docker images here https://hub.docker.com/r/rocm/tensorflow/ and see if you encounter the issue.

@twuebi Ok, I will run the example for 50 epochs and see if I observe a crash.

If it does not crash, over at https://github.com/ROCmSoftwarePlatform/tensorflow-upstream/issues/325#issuecomment-493318656 @sunway513 and @whchung have a node that shows the same memory corrupting behavior as mine and @sebpuetz. It may be worth testing fine-tuning BERT there.

In the mean time can you use one of our standard docker images here (https://hub.docker.com/r/rocm/tensorflow) and see if you encounter the issue.

Sure, do you have a reason to believe mine or @sebpuetz setup is at fault?

I tried rocm/tensorflow:rocm2.5-tf1.13-python3. It did not crash within the last few hours. I am, however, observing a 20% throughput difference from running it in docker to running it on host.
@sebpuetz, on a different setup (Ubuntu + 4.18 + rocm 2.5) gets the same difference in throughput:
Docker:
INFO:tensorflow:examples/sec: 62.3085
Host:
INFO:tensorflow:examples/sec: 78.5586
The first few iterations get less throughput, these are the numbers it eventually settles on.
The difference also shows in the AvgPwr reading of rocm-smi. When running on host, AvgPwr spikes up to 338W. On docker, it barely touches 290W.

I do not think a performance reduction of 20% is acceptable, also it is unclear whether the crash does not occur because of this performance reduction or due to some software issue.

@micmelesse do you have an update?

@twuebi We have observed the mem fault but it is proving hard to reproduce. We also observe the performance drop on docker. We are working on collecting HIP traces but due to the sporadic nature of the memfaults and how long it takes to complete a run this will take a while. In the meantime if you find a way to reduce the time to a memfault, we can use the traces from that to figure out a solution. Hopefully you are able to move ahead in your project using our standard docker images even though there is a performance drop. Please let us know if you observe the memfault in one of your standard docker images.

@micmelesse I didn't have much time for bug chasing in the last weeks. Did you make any progress?

@twuebi No, I was unable to reproduce the memfault for a second time. You can try running the code after setting export HIP_TRACE_API=2 to see what kernel memfaults and see if the same kernel memfaults everytime when you do it again.

This has been stale for 1 1/2 months. Did you make any progress on the performance hit in the docker / the memfaults?
Right now it seems that standard NLP-NNs like transformers are broken on AMD hardware / ROCm (cf. this issue with BERT and #325) while there is no sign of a fix or active work on the issues.

Is there any news about this? I've exactly the same message on ROCm3.7, but on  an R470 GPU.
It seems to work fine for simple architectures (if I keep the param size below 500000), but for more complicated things (something inception like) even at tiny param sizes (81,445) I get this message:
Memory access fault by GPU node-1 (Agent handle: 0x55d5e5566890) on address 0x9fa0c4000. Reason: Page not present or supervisor privilege.
Nearby memory map:
0x9f4e00000, 0xc00000, VRAM
0x9f5e00000, 0x400000, VRAM

PtrInfo:
        Address: 0x9f4e00000-0x9f5a00000/0x9f4e00000-0x9f5a00000
        Size: 0xc00000
        Type: 1
        Owner: 0x55d5e5566890
        CanAccess: 1
                0x55d5e5566890
        In block: 0x9f4e00000, 0xc00000
PtrInfo:
        Address: 0x9f5e00000-0x9f6200000/0x9f5e00000-0x9f6200000
        Size: 0x400000
        Type: 1
        Owner: 0x55d5e5566890
        CanAccess: 1
                0x55d5e5566890
        In block: 0x9f5e00000, 0x400000
python3: /build/hsa-rocr/src/ROCR-Runtime-rocm-3.7.0/src/core/runtime/runtime.cpp:1214: static bool rocr::core::Runtime::VMFaultHandler(hsa_signal_value_t, void*): Assertion `false && "GPU memory access fault."' failed.


Repository has a valid pipeline

This repository was running a Gitlab pipeline that is no longer functioning as originally designed, and there is no Jenkins pipeline for the project.
The Gitlab pipeline needs to be converted to a Jenkins pipeline so that automated tests can continue to run for this project.

When pipeline is created, add Validate step to Jenkinsfile.
Ex: https://github.com/cyberark/conjur-oss-helm-chart/issues/38

This was fixed in #51


Fix wrong namespace for Python 3.3 image

Python 3.3 image is currently listed under "openshift" namespace
which is deprecated. The correct namespace is "centos".
Signed-off-by: Vu Dinh<EMAIL_ADDRESS>

@bparees @soltysh Please review. Thanks.

I'll let @bparees speak up, I don't know the details of where is what at this point.

python-33 is still under the openshift namespace:
https://github.com/openshift/s2i-python/blob/master/Makefile#L4
docker pull centos/python-33-centos7
Using default tag: latest
Trying to pull repository docker.io/centos/python-33-centos7 ... not found
Error: image centos/python-33-centos7:latest not found

only the other versions(2.7, 3.4, 3.5) are in the centos namespace.

@bparees Hey Ben, thanks for the info. I actually wasn't aware of this. Is there a reason we keep Python 3.3 under namespace "openshift" while the rest is in "centos"?

all the images the devex team originally created reside in the openshift namespace (python 3.3, ruby 2.0, nodejs 0.10, perl 5.16, php 5.5, etc), newer versions (python 3.4, 3.5, ruby 2.2, etc) were created by the SCL team and as such reside in the namespace of their choosing (centos).  python 2.7, though older than 3.3, was also a new image created by the SCL team, so it's in the centos namespace.
So we're keeping the images originally created (and still maintained by) the openshift team in the openshift namespace, the newer stuff is going in the SCL namespaces (centos for centos and rhscl for rhel).

@bparees I might know the answer but I will ask, is there a chance to be consistent and keep them all in one namespace? Even though we are maintaining them?

answered on irc but the short answer is no, we won't be doing that.

@bparees Thanks, Ben. Will close this PR since we won't be able to fix this.


CKR_OPERATION_NOT_INITIALIZED in multithreaded application

I'm working on a multithreaded application and I'm currently having some trouble with a CKR_OPERATION_NOT_INITIALIZED error thrown in the last line of this block: https://github.com/Pkcs11Interop/Pkcs11Interop/blob/47e4e17af64cc9cd46460022e056c49505fbe5fd/src/Pkcs11Interop/HighLevelAPI41/Session.cs#L991-L998
Screenshot

As far as I understand, this error is thrown when the encryption or decryption operation is not initialized and from what I've read, an operation stays initialized until data is decrypted. My best guess is that the following is happening:

Thread A
Thread B
Initialized

C_DecryptInit

Yes

C_DecryptInit
Yes

C_Decrypt

No

C_Decrypt
⚡

Thus a lock would be required to make the call to Session.Encrypt / Session.Decrypt thread safe.

PKCS#11 provides thread safety by utilizing separate session objects. Each thread should use its own distinct session to avoid conflicts. This approach maintains the integrity of operations without requiring additional locking mechanisms.
You might also find the Pkcs11Interop.X509Store library to be a simpler and more user-friendly alternative to the full Pkcs11Interop. Pkcs11Interop.X509Store is designed to prevent incorrect usage of the API, making it easier to achieve your goals without running into common pitfalls. The FAQ contains tips for correct usage in multithreaded applications.
If you have any further questions or need assistance, feel free to reach out!


range(3) causes index out of range

Hi -- thanks so much for making this package, it's great.
I made a lite + tiny test:
yolo = YOLOv4(tiny=True)

yolo.classes = "coco.names"

yolo.make_model()
yolo.load_weights("/users/andy/downloads/yolov4-tiny.weights", weights_type="yolo")

yolo.save_as_tflite("yolov4-tiny.tflite")

from yolov4.tflite import YOLOv4

yolo = YOLOv4()

yolo.classes = "coco.names"

yolo.load_tflite("yolov4-tiny.tflite")
yolo.inference(media_path="/users/andy/downloads/vtest.avi", is_image=False)

When I ran it, I got two list index out of range errors in tflite/__init__.py.
I'm not sure if my fix is valid for all cases, so I didn't make a PR,but I made these changes to __init__.py, and then the lite + tiny test ran properly.
At line 72, i changed:
self.output_index = [output_details[i]["index"] for i in range(3)]
to:
self.output_index = [output_details[i]["index"] for i in range(len(output_details))]
At line 141, I changed:
self.interpreter.get_tensor(self.output_index[i]) for i in range(3)
to:
self.interpreter.get_tensor(self.output_index[i]) for i in range(len(self.output_index))

Good!! :+1:
If you send me a PR, I will do some tests and reflect them.

closed by #13


feat(atomic): reduce disk footprint of projects

Proposed changes

Reduce project footprint from 1GB to 380MB
Externalize netlify-cli: it is now a prerequisite for the command to run, same as ng is for angular for example.
Leverage symlink to avoid file duplications. (instead of copying lambda we now use a symlink)
Replace old polyfill by the OG fetch from nodejs (aka undici)

Testing

[x] Unit Tests: UT written
[x] Functionnal Tests: FT adapted: we used a few trick to calculate the hash of the folder that required a few changes to work with the symlink. Ran twice to ensure snapshot is OK
[x] Manual Tests: ran the ft, started verdaccio and run the CLI from the verdaccio release. It works, and file footprint is indeed reduced.

Bonus side-effect: E2E are twice as fast for atomic


new release for maven central

Hi Devrel team,
could you please push 1.1.0 to maven central?
Thank you, Ingo

@camunda-community-hub/devrel

Hi @ingorichtsmeier! I've gone ahead and release this to Maven central. You should see it available within the next few hours! :)

@ingorichtsmeier do you need any further assistance?


OIDC offline_access scope | PR 482 mirror

This is a (formatted for docusaurus) mirror of PR#482 which adds offline_access scope documentation to the OIDC area.
Original ticket 17478

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Customize the count of flashcards(field in TKinter)

Created the text input for the count but error in parsing the list object of the results

Small bug arose in code for default value, needs to be fixed.


Observation Time series plots

Adds general timeseries plots. Currently set up to display the last day of data by default but will load whatever data is available, so users can scroll backwards to see more data. This will have to be limitted to a reasonable amount of data at some point, but I'm holding off on setting that up because we don't yet have a method for retrieving the available range of data.
The current output of these plots is as below:

Nice!

I think this is good to go. I added plots to all of the currently applicable data types, perhaps there would be a plot for CDF forecast groups as well. I'm holding off on refactoring the copy pasta'd code to add bokeh_script and plot to the template arguments, because I think I could probably write a more general and useful helper once I have an idea of what the other types of plots will look like.
I also added a notice to let users know when there is no data available, it's printed as below:


Upcoming changes in XML.jl

I'm making a few changes (essentially a full rewrite) in XML that I plan to release next week.  It's not possible to properly deprecate all the changes so I wanted to give you a heads up.
Check out the README for info: https://github.com/JuliaComputing/XML.jl/tree/jd/rewrite

Thanks.


Create "myproject" for developer

Create an initial project myproject for the developer user. Minisihft had this functionality which makes the getting started easier.

Do we want to remain production-like or handhold and create a minishift-like preppulated environment? I am asking as I believe this should be more for documentation maybe... the overal developer story from beginning... to deploy the cluster, to using odo and actually deploy your first application to running and maintaining it on the cluster from the dashboard/oc command.

one of the things we discussed a long time ago, and still think is doable and maybe preferred, is a 'first use experience'. A popup from the systray or something, like maybe a first app we deploy and open the browser to, that will tell you "Welcome to OpenShift. .... blab lah. Now, login usin the developer user. oc login and create your first project.", etc.

as @kowen mentioned, there is a need of documentation that is a bit more generic; the overall developer story that lives above the tools (developer tools?) and creates this seamless flow among them...

You do not need to own all the developer story on crc documents. It is not practical,  tools will make changes/improvements on their flow at their own pace that you will not be able to follow. Also developers will not use CRC only with tools that we provide, they will use other tools as well. For that being able to utilize agreed interfaces such as kubeconfig becomes important. Besides our tools also depends on such interfaces too.

For that being able to utilize agreed interfaces such as kubeconfig becomes important.

This means that the issue is actually around setting up a kubeconfig with a predefined context and not per se the "myproject"

I suppose namespace can be anything. It is just a continuation of minishift. Also I believe odo uses the same name on docs/help.

Still valid

If we want to ship with this initial "myproject" namespace created, this probably should be done in snc.

@anjannath I agree, let's migrate it to snc repo and have a copy here also because in last meeting we thought to have default context for crc is crc-developer so we need to switch to the project also when it happen.


Decryption for network image

Is it possible to decrypt images on download?
I have stored image data on a public server but it is encrypted and I need to decrypt it after downloading and before displaying the image

I believe this is what you need.
KingfisherManager.shared.downloader.delegate = self

extension YourClass: ImageDownloaderDelegate {
    func imageDownloader(_ downloader: ImageDownloader, didDownload data: Data, for url: URL) -> Data? {
        return data.decrypted
    }
}

Thank you very much :)


init: mnist at 2018-11-16

Motivation for this change
Adding the MNIST dataset. This makes it really useful to use any ML applications that depends on this dataset, and tests can be ran using this smaller dataset.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

I added the version as the date today because the package doesn't have versions. Unless you count the paper 1999 as the "version".

Related: https://github.com/NixOS/nixpkgs/issues/46922

I'm also wondering if this is the right way of doing multi-source derivations. I've just copied the style from Ocaml derivations. I also wonder about mv vs cp operations in the install phase. The files are not meant to be unpacked, as MNIST readers expect the data as compressed.

I've discovered another way to create this. It's actually more minimal. Because the current derivation leaves the "srcs" still in the /nix/store, and ends up copying the data.
The below just creates symlinks to the individual data.
  let
    srcs = {
      train-images = fetchurl {
        url = "http://yann.lecun.com/exdb/mnist/train-images-idx3-ubyte.gz";
        sha256 = "029na81z5a1c9l1a8472dgshami6f2iixs3m2ji6ym6cffzwl3s4";
      };
      train-labels= fetchurl {
        url = "http://yann.lecun.com/exdb/mnist/train-labels-idx1-ubyte.gz";
        sha256 = "0p152200wwx0w65sqb65grb3v8ncjp230aykmvbbx2sm19556lim";
      };
      test-images= fetchurl {
        url = "http://yann.lecun.com/exdb/mnist/t10k-images-idx3-ubyte.gz";
        sha256 = "1rn4vfigaxn2ms24bf4jwzzflgp3hvz0gksvb8j7j70w19xjqhld";
      };
      test-labels= fetchurl {
        url = "http://yann.lecun.com/exdb/mnist/t10k-labels-idx1-ubyte.gz";
        sha256 = "1imf0i194ndjxzxdx87zlgn728xx3p1qhq1ssbmnvv005vwn1bpp";
      };
    };
  in
    linkFarm
    "mnist-2018-11-16"
    [
      { name = srcs.train-images.name; path = srcs.train-images; }
      { name = srcs.train-labels.name; path = srcs.train-labels; }
      { name = srcs.test-images.name; path = srcs.test-images; }
      { name = srcs.test-labels.name; path = srcs.test-labels; }
    ]

However I suspect this does not fit the conventions because there is not maintainer information nor is there any version information. Is there something equivalently simple? Or should I just swap the cp for ln?

@c0bw3b What do you think of using ln vs cp?

I think it's preferable to ln over cp since fetchurl is going to install the sources in the nix store.
The only other approach I can think of would be to use fetchzip instead of fetchurl and install -D -t $out <theFlatFilesWeWant> in your install phase?
You may need to add unpackPhase to you list of phases for this to work. I have not tested locally.
migmix font seems to be close enough to what I have in mind.

The files should not be decompressed.

Oh.. Then I guess your current derivation is the better approach.

Would it make sense to mark it with preferLocalBuild = true?

@veprbl why would we do that when none of the data packages do that?


BRIDGED NFT doesnt show on the Hoelsky chain when i try to check it

Bridged an nft from Katla to Hoelsky but when i ty to check and bridge it backt to Katla it doesnt show in the wallet. could this be a bug?

We are only indexing NFTs on Katla not holesky. You need to manually import the new bridged contract address. Reach out on discord for further help if needed.

okay thank you


TypeError: flower() got an unexpected keyword argument 'ini_var'

With pyramid-celery==4.0.0,  celery==5.2.3 and flower=1.0.0 I'm getting the error after invoking flower via
celery -A pyramid_celery.celery_app flower

It seems like pyramid-celery is trying to send ini_var parameter with the newer version of flower no longer accepts.
Stack trace is
flower_1      | Traceback (most recent call last):
flower_1      |   File "/usr/local/bin/celery", line 8, in <module>
flower_1      |     sys.exit(main())
flower_1      |   File "/usr/local/lib/python3.8/dist-packages/celery/__main__.py", line 15, in main
flower_1      |     sys.exit(_main())
flower_1      |   File "/usr/local/lib/python3.8/dist-packages/celery/bin/celery.py", line 213, in main
flower_1      |     return celery(auto_envvar_prefix="CELERY")
flower_1      |   File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 1128, in __call__
flower_1      |     return self.main(*args, **kwargs)
flower_1      |   File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 1053, in main
flower_1      |     rv = self.invoke(ctx)
flower_1      |   File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 1659, in invoke
flower_1      |     return _process_result(sub_ctx.command.invoke(sub_ctx))
flower_1      |   File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 1395, in invoke
flower_1      |     return ctx.invoke(self.callback, **ctx.params)
flower_1      |   File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 754, in invoke
flower_1      |     return __callback(*args, **kwargs)
flower_1      |   File "/usr/local/lib/python3.8/dist-packages/click/decorators.py", line 26, in new_func
flower_1      |     return f(get_current_context(), *args, **kwargs)
flower_1      | TypeError: flower() got an unexpected keyword argument 'ini_var'

Update: I found the following work-around.
Changing the invocation to
celery flower -A pyramid_celery.celery_app

instead of
celery -A pyramid_celery.celery_app flower

seems to get things back running.  Not sure if this is generally recommended solution  however. Perhaps there is a bug as mentioned above.

Purge, shell, inspect, and flower have been restored to accepting ini options from Pyramid-Celery as a result of resolution of https://github.com/celery/celery/pull/8374

Purge, shell, inspect, and flower have been restored to accepting ini options from Pyramid-Celery as a result of resolution of https://github.com/celery/celery/pull/8374


Self-hosted agents release stuck at "Initialize job"

Agent Version and Platform
Currently 2.187.2 but had same behavior also in 2.164.6
Ubuntu 18.04.5 LTS
The system uses a proxy which is set at 4 places:

/etc/environment (HTTP_PROXY, HTTPS_PROXY, VSTS_HTTP_PROXY)
.proxy file at agent's root folder
--proxyurl parameter of config.sh used at the time of installation
In Variables of the release pipeline

Azure DevOps Type and Version
https://dev.azure.com/yieldigo
What's not working?
After triggering a release, the agent receives the job but never completes the "Initialize job" step.
After 15 minutes of nothing the pipeline exits with error "We stopped hearing from agent (...)".
After triggering another release the agent won't take another job because the worker is still "busy" with the previous job even it should be canceled.
The agent appears online green in the Deployment targets all the time.
Agent and Worker's Diagnostic Logs
Logs in attached files.
agent_log.txt
worker_log.txt

Hi @rudolfdobias does this issue happen intermittently for you or all the time?

Hi @rudolfdobias does this issue happen intermittently for you or all the time?

Hi @anatolybolshakov, it happens all the time, no successful run yet.
Another information I forgot to mention - the host OS runs in a lxc container, maybe IT has something to do with this issue...

@rudolfdobias could you please try to run it with environment variable VSTSAGENT_TRACE=true and share agent logs - for us to understand where it exactly hangs?
You can also send them to my email<EMAIL_ADDRESS>

Hi, I'm having a similar issue to this but just with the initial configuration of the agent (./config.sh). I'm running debian 10 (did try 9 no difference), also from LXC container. I go through the configuration process:

Accept the Team Explorer license
Accept the Team Explorer URL
Enter the PAT,

and this is where it hangs indefinitely. Here's the log:
Agent_20210620-085241-utc.log
Tried in a debian 10 VM, same steps, worked just fine, which leads me to believe this is an issue with running it on LXC containers, but what?

Hi @Ollie-Armitage could you please check that issue is not related to OOM killer?
You can follow next steps to check it on your environment:

Set up ‘PIPELINE_JOB_OOMSCOREADJ’ environment variable as ‘-1000’ – to set up default oom_score_adj value for agent child processes as -1000.
Run ‘echo -1000 > /proc/$$/oom_score_adj’ – to set oom_score_adj for current shell as -1000.
Run agent interactively (by running run.sh script) from current shell.

Hi @anatolybolshakov, Sorry for the slow reply. I'd switched to just using a VM, but strangely setting up a new LXC container again it now works (I did do this multiple times before). I will note that on the day this was occurring there seemed to be an issue with PAT codes in general (it was taking around half an hour to generate each code on azure), so this might have been outside the scope of the agent.
Cheers anyway.

@Ollie-Armitage ok got it! Let me close this one since it's resolved - feel free to ask any further questions.


Remove stroke on table_rect

Setting stroke to 'none' for the table_rect of horizontal_table, so it doesn't have a border when debug is 'false'.
For debug: true, the border will be provided by the if statement in the table command itself.

thanks!


Allow to define custom deterministic deployment information

Currently the proxy/ factory used for the deterministic deployment is hardcoded to https://github.com/Arachnid/deterministic-deployment-proxy This library uses a presigned transaction that doesn't use any replay protection (EIP-155). Some chains (e.g. Celo or Avalanche) enforce the use of replay protection and therefore it is not possible to use the current deterministic deployment there.
This PR add the possibility to define per network information for the deterministic deployment. Alternatively a function can be used to be more flexible.
An example of this can be seen in the https://github.com/gnosis/safe-contracts:
We define a env var to enable the custom deterministic deployment:
https://github.com/gnosis/safe-contracts/blob/3922fa23e85adda6cab9cb574c3157d3bbdb0cde/hardhat.config.ts#L48-L58
and then apply it to the config
https://github.com/gnosis/safe-contracts/blob/3922fa23e85adda6cab9cb574c3157d3bbdb0cde/hardhat.config.ts#L109
Note: This is a draft as the docs have not been adjusted. Before doing this I wanted to check if this would be worth being included in the library.

Hey @rmeissner thanks for the PR, I did not have time yet to fully review it, but looks good.
I ll see if I can fond some time this week to look closer

Cool, let me know if any changes are required :)

Looks good.
Like you mention, if you could add documentation that would be superb
Thanks

I added some documentation. Is this sufficient or do you have some open questions that I should answer with it?

Perfect, thanks!

Thank you for merging :)
Just for an internal information loop, when is it expected to have this available in a release on npm?

most likely this week

0.9.2 released, thanks again for the PR!


Use of Lombok Getter annotation in GroupLevelData

Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!

[ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests

[ ] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

[ ] Create/update unit or integration tests for verifying the changes made.

[ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

[ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

[ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

Hi @Malaydewangan09
I think you missed some instructions from CONTRIBUTING.md.
You need to mention the Jira ticket in your PR to be reviewed and track the changes.
Regards!

Hey @Zeyad2003
I checked through Jira tickets
But this was not there, this was me just trying to start it out here.

You can create a sub-task under this improvement.
e.g. "Introduce Lombok to group module"
then refer to it in your PR.

Okay cool, thanks @Zeyad2003

@Zeyad2003 Please follow the conventions on how to format the pull request title ("FINERACT-1234: Title of the JIRA ticket")


ADFS service communication certificate used by only ADFS servers and not by WAP or client machines

Hi Team,
Greetings for the day!
This is Joy from Microsoft Azure Identity Team and my mail address is<EMAIL_ADDRESS>While reviewing this page I believe correction is required here,
ADFS service communication certificate used by only ADFS servers and not by WAP or client machines but in the article it is mentioned as "Federation servers in Active Directory Federation Services (AD FS) use the service communications certificate to secure Web services traffic for Secure Sockets Layer (SSL) communication with Web clients or with federation server proxies."
Article - https://learn.microsoft.com/en-us/windows-server/identity/ad-fs/deployment/set-a-service-communications-certificate

Regards,
Joy
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 335ded4b-b969-8a44-ea7f-4bd55d25ab7c
Version Independent ID: ce5d9bf6-e2de-c477-38ba-0843c675af98
Content: Set a Service Communications Certificate
Content Source: WindowsServerDocs/identity/ad-fs/deployment/Set-a-Service-Communications-Certificate.md
Product: windows-server
Technology: ad-fs
GitHub Login: @billmath
Microsoft Alias: billmath

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


Added exposure of the current shopId

1. Why is this change necessary?
Helps to get only the subjects for the current shop.
No PHPDoc above the function
2. What does this change do, exactly?
Adds 'shopId' as to Enlight_Event_EventArgs for the subscriber
Adds a PHPDoc
3. Describe each step to reproduce the issue or behaviour.
Try to use the shop Id in a query to get only the entries for the current shop
4. Please link to the relevant issues (if any).
///
5. Which documentation changes (if any) need to be made because of this PR?
////
6. Checklist

[X] I have written tests and verified that they fail without my change
[X] I have squashed any insignificant commits
[X] This change has comments for package types, values, functions, and non-obvious lines of code
[X] I have read the contribution requirements and fulfil them.

7. Comments
The tests work without my change but with my change too.
Is there a reason that this parameter isn't published at the moment?

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-26194
Please use this issue to track the state of your pull request.


Add tutorial for Abecedarium activity

Added the tutorial for Abecedarium activity

I haven't added the tutorial for Build game because I wasn't able to access it. I'm not sure if it's some kind of a bug or it is especially made like that.

Sounds good but your branch is not up to date so I can't merge it.
Specifically, you miss the PR 491.


Multiple root configs?

We are investigating using Cloud Config.
Is there a way to have multiple roots?
Something like:
application.yml
application-dev.yml
application-qa.yml
etc.
springboot1.yml
springboot1-dev.yml
springboot1-qa.yml
etc.
springboot2.yml
springboot2-dev.yml
springboot2-qa.yml
etc.
nginx.yml
ngnix-dev.yml
nginx-qa.yml
etc.
So when Spring Boot app #1 requests its config, it would get a mash up of application.yml and springboot1.yml with the proper profiles applied. Same for Sping Boot app #2.
But when ngnix requests its config, it wouldn't get any settings from application.yml or the profile specific version.

Looking at the code a bit, is the solution to create my own NgnixEnvironmentController that delegates to a NgnixEnvironmentRepository that uses "ngnix" as the root instead of "application"? I'd likely need another controller anyway to populate a freemarker template instead of simply returning yaml.

I now have a NgnixEnvironmentController and PrefixedEnvironmentRepository which uses a specified prefix instead of "application" like SpringApplicationEnvironmentRepository. I did end up copying a fair bit of code from SpringApplicationEnvironmentRepository. I think a better solution would be to make SpringApplicationEnvironmentRepository accept a prefix that defaults to "application." It could then be reused for this purpose.
My controller populates a Map from the Environment and simply passes that on to Freemarker to render the ngnix.ftl template.
This might be nice to abstract away a bit so that this behavior could be enabled via configuration. Adding dynamic endpoints that render via Freemarker based on prefix.
Something like:

spring:
  additional-root-contexts:
    - ngnix
    - foo
    - bar

Would expose a new endpoint /ngnix that reads from ngnix-{*}.yml and renders via ngnix.ftl without any additional code. If anyone has suggestions on how to dynamically add the endpoints, I could put the rest of this together in a pull request.

This is probably also relevant (a way to separate your apps from each other a bit more): https://github.com/spring-cloud/spring-cloud-config/pull/82

Question: what's the point of profile specific nginx config if "it wouldn't get any settings from application.yml or the profile specific version"?

We're using gitlab and that doesn't seem to be playing nicely w/ JGit, so we've been testing using local config files w/ a "native" profile. I don't think we can use the solution from #82.
We do want our ngix config to be profile aware, it just should be completely separate from the application.yml tree.

I don't think local files are a good solution for production applications. What is it with gitlab?

Ideally we'd like to work similar to how gitlab and Jenkins work together. We simply added the ssh key that's on our CI box to the read-only deploy keys of our various projects.
Apparently I was doing something wrong before, because now I can fetch from our private gitlab instance just fine. #82 or something very similar should work for our use case, provided we can somehow configure it to populate a freemarker (or other supported templating engine) template instead of generating raw yaml.

To clarify, our organization is using gitlab CC edition and it works well with JGit.  https://github.com/spring-cloud/spring-cloud-config/pull/82 was implemented and tested with gitlab.

I don't see the need for templates yet. Can you make that a new issue, or morph this one (if we agree that #82 is sufficient for your needs), and explain a bit more?

I'll see if I can get an example of what we are looking for from the guy who maintains the ngnix configs.
In the meantime, this is the controller I've put together to render using a template that's in the remote git repo.
https://gist.github.com/efenderbosch/c66f78fc5f7c1318ffe0

There are multiple issues being discussed here now. Let's try and stick to one (the "multiple roots" from the summary). As I understand it the requirement was to optionally exclude the application.yml common configuration from an environment request? I'm not sure why that is summarized as "multiple roots" so maybe you could see if that is still correct?
The templating thing is also active in #147.

Apologies for not responding to this sooner. This has just started to bubble up in our architectural timeline again.
We are also looking at spring-cloud-consul. It seems there's a bit of overlap as far as configuration goes, but it uses a different mechanism. Is that right? Can our services fetch configuration information from consul using spring-cloud-consul?

spring-cloud-consul provides configuration, but uses a lookup scheme similar to spring-cloud-config.  It won't get your 'multiple root configs' behavior.

@efenderbosch is this still an issue for you?

Probably fixed in #147.

I'll have to take a deeper look, but I don't think this solves our problem.
We plan on using zookeeper to store our configs. Applications will have their own property tree and there will also be a shared property tree for common settings such as database password, AWS keys, etc.

If you are using zookeeper please look at spring-cloud-zookeeper and raise relevant issues there. Thanks.


Add nyc config file

Codecov Report

Merging #8 into master will decrease coverage by 50.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #8       +/-   ##
==========================================
- Coverage   58.49%   7.92%   -50.57%
==========================================
  Files           1      11       +10
  Lines          53     391      +338
  Branches        5      29       +24
==========================================
  Hits           31      31
- Misses         22     360      +338

Impacted Files
Coverage Δ

web/app/pages/albums/index.js
0.00% <0.00%> (ø)

web/app/pages/artists/index.js
0.00% <0.00%> (ø)

web/app/pages/audiobooks/index.js
0.00% <0.00%> (ø)

web/app/pages/search/index.js
0.00% <0.00%> (ø)

web/app/app.js
0.00% <0.00%> (ø)

web/app/pages/album-tracks/index.js
0.00% <0.00%> (ø)

web/app/lib/template-helpers.js
0.00% <0.00%> (ø)

web/app/pages/genres/index.js
0.00% <0.00%> (ø)

web/app/pages/artist-albums/index.js
0.00% <0.00%> (ø)

web/app/pages/playing-now/index.js
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2185c07...bea81ff. Read the comment docs.


set sts regional endpoint

Issue #, if available:
Description of changes:
Checklist:

[ yes] Have you successfully deployed to an AWS account with your changes?
[ yes] Have you successfully deployed to an AWS China account with your changes?
[ ] Have you written new tests for your core changes, as applicable?
[ ] Have you successfully tested with your changes locally?
[ ] If new dependencies have been added, have they been pinned to specific versions?
[ ] Is this change also required on the AWS Solution version?
[ ] Have you updated openapi.yaml if you made updates to API definition (including add, delete or update parameter and request data schema)?
[ ] If you had to run manual tests, have you considered automating those tests by adding them to end-to-end tests?
[ ] If you are updating the changelog and vending out a new release, have you updated versionNumber and versionDate in .defaults.yml

AS review ticket id:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #64 (610f7b0) into develop (9af275a) will decrease coverage by 14.58%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop      #64       +/-   ##
============================================
- Coverage    51.89%   37.30%   -14.59%
============================================
  Files          302       99      -203
  Lines        17169     5074    -12095
  Branches      2647      821     -1826
============================================
- Hits          8910     1893     -7017
+ Misses        7263     2760     -4503
+ Partials       996      421      -575

Impacted Files
Coverage Δ

lib/user/user-authz-service.js
24.07% <0.00%> (-52.40%)
:arrow_down:

lib/helpers/utils.js
21.21% <0.00%> (-45.99%)
:arrow_down:

src/models/users/User.js
12.90% <0.00%> (-38.06%)
:arrow_down:

src/models/users/UsersStore.js
38.66% <0.00%> (-5.98%)
:arrow_down:

lib/user/user-service.js
65.21% <0.00%> (-5.38%)
:arrow_down:

src/models/forms/AddUserForm.js
100.00% <0.00%> (ø)

lib/steps/provision-account/provision-account.js
47.69% <0.00%> (ø)

lib/cfn-templates/cfn-template-service.js

lib/utils/table-report.js

src/models/environments/Environment.js

... and 201 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9af275a...610f7b0. Read the comment docs.


Switch dependency ordering between SkylineCmd and Skyline projects

Make it so that Skyline project depends on SkylineCmd project instead of the other way around.
As far as I can tell this fixes the problem where doing a build immediately after having done a clean build fails.

Hmm, that must be because the clean is deleting the placeholder SkylineCmd that gets created by quickbuild. I inverted this dependency because working on SkylineCmd, or debugging with it, was quite annoying that it wouldn't automatically rebuild when there were changes to Skyline or its dependencies.

because working on SkylineCmd, or debugging with it, was quite annoying that it wouldn't automatically rebuild when there were changes to Skyline or its dependencies.

I just discovered the setting "Only build startup projects and dependencies on Run" at "Tools > Options > Project and Solutions > Build and Run" which I imagine would be a different way to solve this.

because working on SkylineCmd, or debugging with it, was quite annoying that it wouldn't automatically rebuild when there were changes to Skyline or its dependencies.

I just discovered the setting "Only build startup projects and dependencies on Run" at "Tools > Options > Project and Solutions > Build and Run" which I imagine would be a different way to solve this.

According to https://learn.microsoft.com/en-us/visualstudio/ide/building-and-cleaning-projects-and-solutions-in-visual-studio?view=vs-2022#to-build-only-the-startup-project-and-its-dependencies:

Select the Only build startup projects and dependencies on Run check box.
When this check box is selected, only the current startup project and its dependencies are built when you choose Debug > Start (F5) or Debug > Start Without Debugging (Ctrl+F5).
When you choose Build > Build Solution (Ctrl+Shift+B), the entire solution is built.
When this check box is cleared, all projects, their dependencies, and the solution files are built when you run any of the preceding commands.

The problem is that the old (and your PR) way of having Skyline depend on SkylineCmd means that Skyline is not a dependency of SkylineCmd (because that would be circular). Do you think there's a way to prevent the Clean command from ever deleting SkylineCmd.exe (or perhaps replacing it with a placeholder on Clean)?

@bspratt Want to test whether this branch fixes the debug/release build issue?

@bspratt Want to test whether this branch fixes the debug/release build issue?

I'll give it a go, sure

@bspratt Want to test whether this branch fixes the debug/release build issue?

@bspratt Want to test whether this branch fixes the debug/release build issue?

I'll give it a go, sure

OK, can confirm this does solve the issue. I can once again clean, bjam build release, do stuff in IDE, switch to Debug in IDE and do other stuff, no problem. Where before, I had to do a clean debug build which was not at all convenient.


The suggestion to fixed non-sorted dependencies is wrong

https://github.com/square/gradle-dependencies-sorter/blob/6f781ee939a199e3f83ff76b1cc054d96979c8e5/app/src/main/kotlin/com/squareup/sort/SortCommand.kt#L204-L217
It should say ./gradlew sortDependencies

Thanks for the issue. Fair point -- I think the command needs to be made context-aware. It should either suggest running the CLI directly or the gradle task, depending on how it was invoked.


L5R 5th Edition Unofficial - Fix french translation

Update with rule book in french

Submission Checklist
Required

[X] The pull request title clearly contains the name of the sheet I am editing.
[X] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[X] The pull request makes changes to files in only one sub-folder.
[X] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

[ ] This sheet has been made on behalf of, or by, the game's publisher.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[X] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description
Change French translation

Character Sheet Info Roll20 Internal Use only.


Add zarr experiment app to Heroku

This is a temporary application that I will use to quickly iterate on zarr upload code without totally breaking staging.

sorry, I should have clarified that this was just an FYI. In retrospect I should have just @ tagged instead of requesting review.


[Release-1.21] - Update bootstrap logic to print out all changed files on disk

Backport fix for Update bootstrap logic to print out all changed files on disk

#4797

**Validated **
Scenario 1:
Create a new cluster and change client-ca.crt.
Restart k3s and verify that k3s halts with a fatal log message that includes the file changed.
$ k3s -v
k3s version v1.21.8+k3s-51226845 (51226845)
go version go1.16.10

$ sudo vi /var/lib/rancher/k3s/server/tls/client-ca.crt

dd the first row of the cert :wq!
$ sudo /usr/local/bin/k3s --debug server

DEBU[0000] Asset dir /var/lib/rancher/k3s/data/5ce208d2d58259c877c3c9a58b62998504c84dd7869b585318cd056919ab7a77
DEBU[0000] Running /var/lib/rancher/k3s/data/5ce208d2d58259c877c3c9a58b62998504c84dd7869b585318cd056919ab7a77/bin/k3s-server [/usr/local/bin/k3s --debug server]
INFO[2022-01-03T19:31:30.532786485Z] Starting k3s v1.21.8+k3s-51226845 (51226845)
INFO[2022-01-03T19:31:30.537047525Z] Configuring sqlite3 database connection pooling: maxIdleConns=2, maxOpenConns=0, connMaxLifetime=0s
INFO[2022-01-03T19:31:30.537088641Z] Configuring database table schema and indexes, this may take a moment...
INFO[2022-01-03T19:31:30.543819694Z] Database tables and indexes are up to date
INFO[2022-01-03T19:31:30.549241967Z] Kine listening on unix://kine.sock
INFO[2022-01-03T19:31:30.583605308Z] Reconciling bootstrap data between datastore and disk
INFO[2022-01-03T19:31:30.583949036Z] Migrating bootstrap data to new format
FATA[2022-01-03T19:31:30.584219899Z] /var/lib/rancher/k3s/server/tls/client-ca.crt newer than datastore and could cause a cluster outage. Remove the file(s) from disk and restart to be recreated from datastore.

$ sudo rm /var/lib/rancher/k3s/server/tls/client-ca.crt
Restart cluster and verify good status
$ kubectl get nodes
NAME                                          STATUS   ROLES                  AGE   VERSION
ip-172-31-24-190.us-east-2.compute.internal   Ready    <none>                 25m   v1.21.8+k3s-51226845
ip-172-31-25-47.us-east-2.compute.internal    Ready    control-plane,master   30m   v1.21.8+k3s-51226845
ip-172-31-28-9.us-east-2.compute.internal     Ready    <none>                 21m   v1.21.8+k3s-51226845

Scenario 2:
using the same cluster, change the contents of client-ca.key as well as client-ca.crt.
Restart k3s and verify that both files are listed as changed in the fatal log message.
$ sudo vi /var/lib/rancher/k3s/server/tls/client-ca.key

dd the first row of the key :wq!
$ sudo vi /var/lib/rancher/k3s/server/tls/client-ca.crt
dd the first row of the cert :wq!
$ sudo /usr/local/bin/k3s --debug server

DEBU[0000] Asset dir /var/lib/rancher/k3s/data/5ce208d2d58259c877c3c9a58b62998504c84dd7869b585318cd056919ab7a77
DEBU[0000] Running /var/lib/rancher/k3s/data/5ce208d2d58259c877c3c9a58b62998504c84dd7869b585318cd056919ab7a77/bin/k3s-server [/usr/local/bin/k3s --debug server]
INFO[2022-01-03T19:40:20.758982821Z] Starting k3s v1.21.8+k3s-51226845 (51226845)
INFO[2022-01-03T19:40:20.762216614Z] Configuring sqlite3 database connection pooling: maxIdleConns=2, maxOpenConns=0, connMaxLifetime=0s
INFO[2022-01-03T19:40:20.762250877Z] Configuring database table schema and indexes, this may take a moment...
INFO[2022-01-03T19:40:20.769484003Z] Database tables and indexes are up to date
INFO[2022-01-03T19:40:20.774268956Z] Kine listening on unix://kine.sock
INFO[2022-01-03T19:40:20.825543626Z] Reconciling bootstrap data between datastore and disk
INFO[2022-01-03T19:40:20.826422460Z] Migrating bootstrap data to new format
FATA[2022-01-03T19:40:20.826791499Z] /var/lib/rancher/k3s/server/tls/client-ca.crt, /var/lib/rancher/k3s/server/tls/client-ca.key newer than datastore and could cause a cluster outage. Remove the file(s) from disk and restart to be recreated from datastore.


Add workaround for unit tests for change of behaviour in mock call args in Python version < 3.8

This PR includes a fix for #13 and #12.
What I discovered is that the behaviour in the unittest mock changed between Python versions 3.7 and 3.8. While the test code is correct for Python 3.8 and above, they failed for Python 3.7. More information on what changed is here:
https://bugs.python.org/issue21269
For more context, here is an SO post where someone came across the same problem:
https://stackoverflow.com/questions/60105443/how-do-i-correctly-use-mock-call-args-with-pythons-unittest-mock
I also updated tox.ini to drop Python 3.6 (#12) and to include support for Python 3.11.

We decided not to support Python 3.7, so this PR won't be merged.


✨ Add JSON-compatible float constraints for NaN and Inf

Change Summary

✨ Add JSON-compatible float constraints for NaN and Inf (+inf, -inf).
Full discussion in FastAPI: https://github.com/tiangolo/fastapi/issues/4589
Short example
from typing import List

from fastapi import FastAPI
from pydantic import BaseModel

app = FastAPI()

class DataModel(BaseModel):
    a_string_value: str
    a_float_value: float

stored_objects: List[DataModel] = []

@app.get("/", response_model=List[DataModel])
async def get_objects():
    return stored_objects

@app.post("/")
async def save_object(to_save: DataModel):
    return stored_objects.append(to_save)

Then:
$ curl localhost:8000 -H 'Content-Type: application/json' -d '{"a_string_value": "object 1", "a_float_value": "NaN"}'
$ curl localhost:8000

That creates an InternalServerError with ValueError: Out of range float values are not JSON compliant.
Reason
Pydantic parses for a float field any string that could be parsed by Python's float, including "NaN". But Starlette encodes JSON responses with json.dumps(allow_nan=False). This means that Pydantic will "successfully" parse the "NaN" string as a Python float (which is not valid JSON but is valid Python and valid JavaScript), but then the response will not be able to convert the values back to JSON.
Alternatives
Change the response in Starlette/FastAPI
Changing the behavior in the response in Starlette (or FastAPI) to use json.dumps(allow_nan=True) (the default) would convert those float("nan") values to JSON null, the equivalent of Python None.
But that would mean that any type annotated as float would implicitly actually be Union[float, None] when converted to JSON. But that would be counterintuitive as static analysis (mypy, the editor, autocompletion, inline errors, TypeScript automatically generated clients, etc) would expect a float to be just float, not that in a corner case it could be None/null.
Accept this PR and have the new Pydantic types
If this PR is accepted, then my plan would be to document in FastAPI that using float in Python has those caveats, and it might be better to use the new Pydantic's JSONFloat that ensures compatibility with JSON.
Change the default behavior of float
Currently, there are no tests about how float('NaN'), float('+inf'), and float('-inf') should behave (although there's the current implicit behavior of accepting them).
There could be the option to require floats to not be NaN, +inf, or -inf, the same way that currently Decimals are treated. Currently, there are even tests that check that Decimal('NaN') is disallowed. So it might not be crazy to replicate the same behavior for floats.
Related issue number
Related to this issue: https://github.com/samuelcolvin/pydantic/issues/1779 in particular to this comment: https://github.com/samuelcolvin/pydantic/issues/1779#issuecomment-957702646
I wouldn't say this directly closes that issue, but it's indeed related.
It is also related to this FastAPI issue: https://github.com/tiangolo/fastapi/issues/4589

Next
I want to gauge the interest/acceptability of this or the alternatives before writing the docs.
Checklist

[x] Unit tests for the changes exist
[x] Tests pass on CI and coverage remains at 100%
[ ] Documentation reflects the changes where applicable
[ ] changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)
[ ] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

please review

please update.

To match https://github.com/pydantic/pydantic-core/pull/228, we need one option allow_nan_inf, default to True.

@tiangolo you get special treatment, I'll try to fix this for you today.

Notice
See twitter :bird:, I've you'd like this to be included in V1.10, please fix it and request a review TODAY.
Or if you need this in V1.10 but don't have time to complete it (or aren't the author), please comment here and on #4324.

should be mostly there, just needs some docs.
@tiangolo @PrettyWood please review.

Probably, i'll do that now. It'll also match V2.

thanks again for this.


Bittorrent tracker passkey support

Added tracker passkey support for Bittorrent and a few tiny updates to make this work better.

In order to have patches accepted you must sign CLA as described at https://www.pfsense.org/about-pfsense/#legal

This functionality hadn't worked in some time and was removed so this is no longer applicable.


Implement whence=1 for the utils.PackedObjectReader.seek

Fixes #67
This mode of seek is often used, for example by numpy.load and not
supporting it would prohibit a Container based repository with packed
objects from being used with it. Here we add support for whence=1
which simply means that the target is with respect to the current
byte position as reported by tell instead of with 0.

Looks good!
As we discussed, we also then need to implement this for the utils.StreamDecompresser.
Also, probably ideal to also have tests to test the minimal seek functionality at the container level, testing loose, packed uncompressed and packed compressed objects (with e.g. pytest.mark.parametrize('compress', [True, False])). Thanks!
PS1: Do you think we should also implement whence = 2?
PS2: While you are at it, I realised that in the StreamDecompresser we don't need to seek to zero every time. If we are seeking to a position that is > than the current one, we need need to read (and discard) target - self.tell(), right? In this way it's at least (relatively) efficient to seek forward, even if compressed. Maybe you can give a shot at this (or if you don't have the time, could you open an issue?)

Working on it. Will push an update later

@giovannipizzi I added the same functionality for the StreamDecompresser and added a parametrized test on a stream obtained through Container.get_object_stream. For the latter, I also wanted to add some tests that exception is raised when we seek beyond the limits, but got some weird behavior. I am not sure how the io classes are supposed to behave. For example:
In [1]: import io

In [2]: stream = io.StringIO('test')

In [3]: stream.seek(-1)
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-3-6b01d185eb3f> in <module>
----> 1 stream.seek(-1)

ValueError: Negative seek position -1

In [4]: stream.seek(3)
Out[4]: 3

In [5]: stream.seek(-1, 1)
---------------------------------------------------------------------------
OSError                                   Traceback (most recent call last)
<ipython-input-5-57cab1c18538> in <module>
----> 1 stream.seek(-1, 1)

OSError: Can't do nonzero cur-relative seeks

As you can see seeking negatively for whence=0 raises a ValueError as expected. However, I am also not allowed to use negative offsets when using whence=1 which raises an OSError . When opening a file through open, I get a different exception:
In [9]: with open('codecov.yml', 'r') as handle:
   ...:     handle.seek(2)
   ...:     handle.seek(-1, 1)
   ...:
   ...:
---------------------------------------------------------------------------
UnsupportedOperation                      Traceback (most recent call last)
<ipython-input-9-4844d5b8816f> in <module>
      1 with open('codecov.yml', 'r') as handle:
      2     handle.seek(2)
----> 3     handle.seek(-1, 1)
      4
      5

UnsupportedOperation: can't do nonzero cur-relative seeks

Aside from the different exception (which is a subclass of OSError), I am confused that the negative offsets are not allowed for whence=1. The documentation of seek clearly says that offsets can be negative for whence=1.

You can seek back, but only for bytes objects, not for strings (because going backward reliably in strings it's a mess and maybe not even possible in general, I think).
With io.BytesIO and opening with b in the mode works instead:
In [1]: import io

In [2]: a = io.BytesIO(b'12345')

In [3]: a.seek(3)
Out[3]: 3

In [4]: a.read(1)
Out[4]: b'4'

In [5]: a.seek(-2,1)
Out[5]: 2

In [6]: a.read()
Out[6]: b'345'

In [8]: with open ('index.html', 'rb') as handle:
   ...:     handle.seek(5)
   ...:     print(handle.seek(-2, 1))
   ...:
3

Do you really need StringIO? Maybe you meant to use BytesIO?

BTW, please rebase on develop because I did a number of important changes that might collide maybe with yours, and also most importantly there was an important bug (fixed in #74) with writing directly to compressed packs that might be important to have correct in your PR

Do you really need StringIO?

No, I was just testing what the interface is of the basic streams in the built-in library with respect to seeking. Anyway, I indeed forgot that seeking (bytes) of course becomes messy when it is not on bytes with multi-byte characters and all. So you can consider my confusion as solved :)

BTW, please rebase on develop because I did a number of important changes that might collide maybe with yours, and also most importantly there was an important bug (fixed in #74) with writing directly to compressed packs that might be important to have correct in your PR

Done


Wrong computation of weighted minkowski distance in cdist

There is an error in the weighted minkowski distance computation: in scipy/scipy/spatial/src/distance_impl.h, lines 363, 364:
Currently:
d = fabs(u[i] - v[i]) * w[i];
s = s + pow(d, p);
Should be:
d = fabs(u[i] - v[i]);
s = s + w[i]*pow(d, p);
The weighting coefficient shouldn't be powered.

Hi, I am not sure whether this is relevant, but even here, the weighting coefficient is powered. Apologies since I am not an expert, but just wanted to point it out. Hope it helps.

Thanks for the reply. Even the docstring for the function, you've referenced to, says:
.. math::
\left(\sum{(w_i |u_i - v_i|^p)}\right)^{1/p}.
The coefficient is out of the power. It seems, that the implementation you've mentioned is also incorrect...
I'm not an expert either,
but here are some link I've found:
http://stats.stackexchange.com/questions/15289/when-to-use-weighted-euclidean-distance-and-how-to-determine-the-weights-to-use
http://www.softcomputing.es/estylf08/es/006-6-176.pdf
In weighted Euclidean distance, weights are not squared, and this is just a special case of the weighted minkowski. Probably I'm wrong, I would be grateful for the clarification of the definition.

my guess is that this is just a definition issue, because weights can be just transformed by the power, AFAICS.
analog: in least squares, p=2, I got confused for some time whether weights are defined for the residual u_i - v_i or the squared residuals, i.e. is it w**2 or sqrt(w)
WLS is usually defined as squared weights which would be outside, i.e. w[i]*pow(d, p), but that just looks like a convention to me (like using variance instead of standard deviation).

Thanks for the reply! In this case, the docstring for the scipy.spatial.distance.wminkowski function should be changed, because now the weight is not powered according to the formula in the docstring.

Looks like the easiest fix is to fix the docs. Am adding an easy-fix label then

This resolution is simply incorrect. Weights should not be powered, doing so violates the logic of weights. I'm working on a PR that will fix this and add weights broadly in stats and spatial.distance, but would be happy to have the conversation here while I get that ready.

@metaperture if we want to change this, it would need a FutureWarning in the next release (0.19.0) and the change itself in the one after that (1.0).
Changing it would require that there's a uniform definition in the literature. The first two papers I checked do have w without power:

Using the OWA operator in the Minkowski distance
A new Minkowski distance based on induced aggregation operators

The third one explicitly discuss linear (without power) and nonlinear ones (with power) though:

Minkowski metric, feature weighting and anomalous cluster initializing
in K-Means clustering

That last paper also happens to be the most highly cited one. So it's not 100% clear. In order to accommodate both versions and not break backwards compatibility, could we add a parameter to choose between these two versions of weights?

The paper you reference is not proposing that that is what weights mean, it's proposing that as a variation of the standard algorithm. Note that even in that paper, it calls that approach the non-standard one. It's also saying to use $w' = w^\beta$, then apply the weights as you would normally--which would be easier under the correct implementation than it would be now (the current implementation already assumes $\beta = 2$).
Weights define a probability measure on the data, nonlinear weights would violate that, and a host of related transforms that I'll be referencing in my PR. You can do that for particular algorithmic purposes (Boosting uses weights for its own purposes that aren't supposed to have generalizable meaning), and that's what it seems like is being done here.
I'll be uploading my pull request tonight, working on some python 2.7 issues right now (damn oldstyle varargs...).

Weights define a probability measure on the data, nonlinear weights would violate that

not in most usages for weights that I have seen
see for example the link from an earlier comment
http://stats.stackexchange.com/questions/15289/when-to-use-weighted-euclidean-distance-and-how-to-determine-the-weights-to-use
(I would consider weights as the reciprocal of the standard deviation in this case, so that the fabs(u[i] - v[i]) * w[i] is the standardized difference, and the power function defines the "kernel" for the distance.)
(I don't have an opinion here, but I do in stats applications.)

If you mean that weights are the reciprocal of the variance (std dev squared), then yes, that's a common equivalent transpose of the problem--if you define a probability space where the measure is the inverse variance, then the expected risk minimizer on that space is also the one with the least variance.
Weights as measure is the ERM approach, weights like inverse variance is (often, but not always) the purely frequentist equivalent.

No, I mean standard deviation (sqrt of variance).
from the initial description above
Currently:
d = fabs(u[i] - v[i]) * w[i];
s = s + pow(d, p);

that's exactly what we are doing in kernel regression (IIRC) where w would be the inverse bandwidth, and in robust estimation where pow would be some robust function.
If p = 2, then this coincides with using the variance, but not if p !+ 2

Do you have a reference for that? The link you gave seems to be inv var weighted.


Fix typo for source.cache docs

Thanks to https://github.com/DylanVann/react-native-fast-image/issues/274#issuecomment-418719314 for pointing this out

This PR is really urgent..

@DylanVann sorry to bother you, but can you merge this?
I believe a lot of people are wasting a lot of time figuring out this typo on their own.


GraphQLDataSource wrongfully requires the presence of data in response from datasource

https://github.com/jensneuse/graphql-go-tools/blob/90831cf28164c840329d1c6cb1620855cff3ad11/pkg/execution/datasource/datasource_graphql.go#L463
datasource_graphql.go requires the presence of data in response, or it will raise an error with "Key path not found".
However, it the GraphQL June2018 Spec states that If an error was encountered before execution begins, the data entry should not be present in the result..
Expected: When GraphQLDataSource receives a response with errors without data, the GraphQLDataSource.Resolve does not raise error and pass the errors to the clients.

You're looking at the legacy "engine".
Have a look at the new version, the error should be fixed there:
https://github.com/jensneuse/graphql-go-tools/blob/90831cf28164c840329d1c6cb1620855cff3ad11/pkg/engine/datasource/graphql_datasource/graphql_datasource.go#L877
If you discover that the new engine is affected by the same problem, please report back.
If you'd like to fix the old engine you can raise a PR, from my side, it's unmaintained and just for compatibility reasons still in the repo.

Thanks for the quick explanation. Appreciate it 😄


Ablations

Planning to maybe rerun a few of the long range ablations next week. @jmercat Could you double check if these implementations are correct?
The ablations I'm thinking of running are 1) gating (before, after), 2) hybrid (linearize every N layers), 3) decay (This is already implemented with the use-decay parameter, right?)
Feel free to add/suggest stuff as well that you think would be worth trying (Taylor/quadratic maybe?)

consider adding based-style hybrid (manually give list of indices)


Rust 1.41.0 fixups

Ran cargo test. These fixups were needed for master to compile.
Not 100% sure why type inference didn't work on these literals.
Needed to use u64 to get access to u64::MAX.

We don't have a clear policy around the Rust version, but I think it'd be reasonable to say that supporting the latest is enough. I may be wrong as package maintainers may need a wider range of versions. What do you think?
I believe this is an announcement relevant to changes in this PR:
https://blog.rust-lang.org/2020/04/23/Rust-1.43.0.html#type-inference-around-primitives
https://blog.rust-lang.org/2020/04/23/Rust-1.43.0.html#library-changes

Ah it's a real shame that's the version number that breaks.
I'm on nixos, so rustup isn't really an option, because my dynamic libraries are in nix store locations, and the latest rustc in <nixpkgs-unstable> is 1.42.0 :)
Feel free to close this.

Well, there is no harm in being backward-compatible. Would you mind resolving conflicts? Let's merge it after that.

@ul appreciate it.


Disable sno baremetal

This is for SNO enablement (but not on Bare Metal) so we need to make some final changes for:

disable SNO on bare metal - https://github.com/open-cluster-management/backlog/issues/13192
Add Preview label and feature gate - https://github.com/open-cluster-management/backlog/issues/9308 and https://github.com/open-cluster-management/backlog/issues/13187

/retest


Update to the vulkano version 0.13 for UB patch

Hey @mitchmindtree , I tried this on a forked version and see compiler errors when I import vulkano="0.12.0" in my project. The same happens when I use vulkano="0.13.0" and shade_runner:master. Can you also advance the shade_runner version (0.1.3?) so I can better match my shader_runner version to which vulkano version I'm importing?

Can you also advance the shade_runner version (0.1.3?) so I can better match my shader_runner version to which vulkano version I'm importing?

@MitchellHansen I think I see where you're coming from, but this is up to @freesig. It seems a little strange to skip a version just so the next version looks slightly more similar to one of the dependency versions. Having to check dependency versions match is something that applies to a lot of the Rust ecosystem. There are some tools that make it easier like crates.io's versioned dependency list, cargo tree can make it easier to see where two different versions are coming from and I'm sure there are probably more specific tools out there for this. Sometimes authors will also re-export crates that can easily cause downstream conflicts, but this has its own trade-offs too.

@mitchmindtree It doesn't have to be 0.1.3, it can be 0.1.2, or whatever other versioning @freesig wants. Just as long as it's different than 0.1.1 =)


Update scala-compiler, scala-library, ... to 2.13.14 in series/4.x

About this PR
📦 Updates

org.scala-lang:scala-compiler
org.scala-lang:scala-library
org.scala-lang:scala-reflect

from 2.13.8 to 2.13.14
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

🔍 Files still referring to the old version number
The following files still refer to the old version number (2.13.8).
You might want to review and update them manually.
CHANGES.md

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-lang" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-lang" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

Superseded by #1869.


Several updates

Use machine name instead of generated name tied to kind
Improve delete functionality to remove node from child cluster
Set nodeRefs

Signed-off-by: Chuck Ha<EMAIL_ADDRESS>

The changes look reasonable enough to me so far, but I'm running into some trouble trying this out:
$ capdctl setup
Error: error loading config: decoding failure: no kind "Cluster" is registered for version "kind.sigs.k8s.io/v1alpha3" in scheme "sigs.k8s.io/kind/pkg/cluster/config/encoding/scheme.go:34"
panic: exit status 1

goroutine 1 [running]:
main.makeManagementCluster(0x1713884, 0x4)
	/Users/spellegrino/Code/Go/src/github.com/kubernetes-sigs/cluster-api-provider-docker/cmd/capdctl/main.go:186 +0x188
main.main()
	/Users/spellegrino/Code/Go/src/github.com/kubernetes-sigs/cluster-api-provider-docker/cmd/capdctl/main.go:82 +0x6cb

I'll see if I can figure that out and get back to you. Also, I found a place in the README the rename missed: https://github.com/kubernetes-sigs/cluster-api-provider-docker/blame/master/README.md#L30-L32

@sethp-nr ah yeah, I'm also actively developing on the :latest tag, so I need to move over to dev and re-push that back. I'd recommend you build your own image at the moment

Yeah, that's what I ended up doing – it looks like the README references a script that I didn't find. I've got another PR I'm about to send you for a couple quick things.

I haven't tried multiple control planes / deleting one yet, but otherwise everything looks great and is working like I expect.

sweet, I'm going to fix up the delete comment and go ahead and merge it, thanks for the feedback @pablochacin and @sethp-nr !
The multi-control plane one needs a timeout of 15 minutes on an XL instance on AWS

/lgtm
/hold
Feel free to unhold when ready

/hold cancel
/lgtm

/lgtm

/lgtm


Timestamps on things like last warning are several hours in the future

Various timestamps such as the one shown for Last Warning are several hours into the future, presumably in China time without a timezone appended to them for home assistant to adjust for.  The result is I'm getting entities showing things like my last warning being "in 7 hours".
I see there is a very recent commit to fix this though, so I'm not sure why it's not working for me.  My installed version seems to match with the latest commit c23e642 so would include the timezone issues fixed in https://github.com/drakhart/ha-super-soco-custom/commit/d7838136e6257d6bfed7f320f341a099222bd3d4
Do let me know if there's any data I can provide to help and if there's any particular stuff I need to do to get a useful log to show you :)
I'm afraid that whilst I have had my bike for a while, the old Super Soco ECU was broken and only just replaced with a new Vmoto one a couple of days ago so I can't say if this is a new issue or not.

Hi Andy! Thanks for taking the time to try this integration.
I thought I had solved that issue with the commit you mentioned, but you're absolutely right and the last warning also needs a timestamp correction. I'll push a fix for it soon, along with other small things I fixed in the past days.
By the way did you notice the issue in any other entity besides that one?

Ok, I noticed that all the timestamps needed a fix except for the GPS which was already fixed. I guess they noticed they were providing wrong timestamps on their side and fixed them to be proper epoch instead of local Shanghai time.
This should be fixed in beta 11. Please let me know if it worked for you.

Thank you muchly, that seems to be matching up with me on British Summer Time now :)
Now if only I could figure out how to convince it that the slightest tectonic tremor is not cause for alarm! I'm up to eight alerts today :(

My assumption was that the time from the GPS was based on the actual time stamp received from the satellites (presumably sent in UTC and adjusted by HomeAssistant accordingly) where as all the other time stamps are based on some Chinese server time. It'd be nice if we could tweak these things to point at some self hosted server one day, but I suspect flashing these would not be quite so simple as that 😅

If it's of any help to you I've set up an automation to relay alerts to my phone, but I've added a condition with the following template: {{ not is_state_attr("sensor.super_soco_tcmax_last_warning", "title", "Vibrating alert") }}. This way I filter out all the annoying and useless vibration alerts and just receive the important ones.
I feel like hacking the firmware will be really hard to accomplish, but if you're interested in DIY hardware there's this custom board project to send all bike data to an Android app via Bluetooth: https://github.com/Xmanu12/SuSoDevs
I'll close this issue as solved since you're now getting the correct timestamps. Thank you!


feat: add a mutationObserver to reload when some valid attributes changes

Added a MutationObserver to some valid attributes like data-src, when data-src changed, reload

@frankqiu0219 Please add this information in README and Demo file with an example as well. This will be a great addition as functionality.

@frankqiu0219 Please add this information in README and Demo file with an example as well. This will be a great addition as functionality.
Thank you. I will do it quickly.

@iam-frankqiu please fix the conflicting issues, also, a configuration should allow to disable the use of Mutation Observer, and it shouldn't be enabled by default, considering the performance implications

@iam-frankqiu any updates on this?

@iam-frankqiu any updates on this?

yeah, sorry for the late reply, I was pretty busy, I will update this repository soon.

@iam-frankqiu please add coverage folder in .gitignore

@iam-frankqiu please add coverage folder in .gitignore

well. It's done.


Somerset College

Somerset College on the Gold Coast: https://www.somerset.qld.edu.au/

@adobroskok Pull request merged. Thank you!


k3s-cluster // Server role stuck in deploying status

Description
k3s-cluster // server role stuck in deploying status.
During k3s cluster deployment, i have registered issue on server role which is stuck on deploying status, meanwhile the corresponding VM is running and in ready status.
I checked oneflow service logs which view exception as shown bellow in details.
Details

Affected Component: oneflow
Hypervisor: Firecracker
Version: <IP_ADDRESS>

Additional context
Logs from oneflow services shown exceptions :
oneadmin@node0:~$ journalctl -u opennebula-flow.service Hint: You are currently not seeing messages from other users and the system.       Users in groups 'adm', 'systemd-journal' can see all messages.       Pass -q to turn off this notice. -- Logs begin at Sun 2021-07-11 20:54:21 MDT, end at Tue 2021-07-13 06:09:41 MDT. -- Jul 11 20:54:39 node0.testlab.cord-testdrive-pg0.apt.emulab.net logrotate[8847]: error: error renaming temp state file /var/lib/one/.logrotate.status.tmp Jul 11 20:54:40 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[8875]: == Sinatra (v2.1.0) has taken the stage on 2474 for development with backup from Thin Jul 12 05:43:45 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[8875]: == Sinatra has ended his set (crowd applauds) Jul 12 05:43:45 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[8875]: 2021-07-11 20:54:40 -0600 Thin web server (v1.8.0 codename Possessed Pickle) Jul 12 05:43:45 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[8875]: 2021-07-11 20:54:40 -0600 Maximum connections set to 1024 Jul 12 05:43:45 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[8875]: 2021-07-11 20:54:40 -0600 Listening on <IP_ADDRESS>:2474, CTRL+C to stop Jul 12 05:43:45 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[8875]: 2021-07-12 05:43:45 -0600 Stopping ... Jul 12 05:45:27 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[9614]: == Sinatra (v2.1.0) has taken the stage on 2474 for development with backup from Thin Jul 12 22:23:27 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[9614]: #<Thread:0x00005617d6edb1f8@/usr/lib/one/ruby/ActionManager.rb:198 run> terminated with exception (report_on_exception is true): Jul 12 22:23:27 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[9614]: /usr/lib/one/oneflow/lib/EventManager.rb:439:in check_nodes_event': undefined local variable or method vm_state' for #<EventManager:0x00005617d68df1 Jul 12 22:23:27 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[9614]: Did you mean?  lcm_state Jul 12 22:23:27 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[9614]:                h_state Jul 12 22:23:27 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[9614]:         from /usr/lib/one/oneflow/lib/EventManager.rb:372:in wait_report_ready'
Jul 12 22:23:27 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[9614]:         from /usr/lib/one/oneflow/lib/EventManager.rb:107:in wait_deploy_action' Jul 12 22:23:27 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[9614]:         from /usr/lib/one/ruby/ActionManager.rb:200:in call'
Jul 12 22:23:27 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[9614]:         from /usr/lib/one/ruby/ActionManager.rb:200:in block in run_action' Jul 13 05:53:10 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[9614]: == Sinatra has ended his set (crowd applauds) Jul 13 05:53:10 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[9614]: 2021-07-12 05:45:27 -0600 Thin web server (v1.8.0 codename Possessed Pickle) Jul 13 05:53:10 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[9614]: 2021-07-12 05:45:27 -0600 Maximum connections set to 1024 Jul 13 05:53:10 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[9614]: 2021-07-12 05:45:27 -0600 Listening on <IP_ADDRESS>:2474, CTRL+C to stop Jul 13 05:53:10 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[9614]: 2021-07-13 05:53:10 -0600 Stopping ... Jul 13 05:53:11 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[25248]: == Sinatra (v2.1.0) has taken the stage on 2474 for development with backup from Thin Jul 13 05:58:57 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[25248]: #<Thread:0x000055b19e30ac00@/usr/lib/one/ruby/ActionManager.rb:198 run> terminated with exception (report_on_exception is true): Jul 13 05:58:57 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[25248]: /usr/lib/one/oneflow/lib/EventManager.rb:439:in check_nodes_event': undefined local variable or method vm_state' for #<EventManager:0x000055b19e1ff Jul 13 05:58:57 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[25248]: Did you mean?  lcm_state Jul 13 05:58:57 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[25248]:                h_state Jul 13 05:58:57 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[25248]:         from /usr/lib/one/oneflow/lib/EventManager.rb:372:in wait_report_ready'
Jul 13 05:58:57 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[25248]:         from /usr/lib/one/oneflow/lib/EventManager.rb:107:in wait_deploy_action' Jul 13 05:58:57 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[25248]:         from /usr/lib/one/ruby/ActionManager.rb:200:in call'
Jul 13 05:58:57 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[25248]:         from /usr/lib/one/ruby/ActionManager.rb:200:in block in run_action' Jul 13 06:09:41 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[25248]: #<Thread:0x000055b19e1fe370@/usr/lib/one/oneflow/lib/LifeCycleManager.rb:95 run> terminated with exception (report_on_exception is true): Jul 13 06:09:41 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[25248]: /usr/lib/one/oneflow/lib/ServiceAutoScaler.rb:46:in block in start': undefined method []' for nil:NilClass (NoMethodError) Jul 13 06:09:41 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[25248]:         from /usr/lib/one/oneflow/lib/ServiceAutoScaler.rb:37:in loop'
Jul 13 06:09:41 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[25248]:         from /usr/lib/one/oneflow/lib/ServiceAutoScaler.rb:37:in start' Jul 13 06:09:41 node0.testlab.cord-testdrive-pg0.apt.emulab.net ruby[25248]:         from /usr/lib/one/oneflow/lib/LifeCycleManager.rb:99:in block in initialize'`
VM instance status :
oneadmin@node0:~$ onevm list   ID USER     GROUP    NAME                                                                                STAT  CPU     MEM HOST                                                                        TIME   34 oneadmin oneadmin server_0_(service_22)                                                                                runn    1      2G node3                                                                   0d 00h50
Visualize service :
`oneadmin@node0:~$ oneflow show 22
SERVICE 22 INFORMATION
ID                  : 22
NAME                : k3s-cluster
USER                : oneadmin
GROUP               : oneadmin
STRATEGY            : straight
SERVICE STATE       : DEPLOYING
START TIME          : 07/13 05:54:54
PERMISSIONS
OWNER               : um-
GROUP               : ---
OTHER               : ---
ROLE server
ROLE STATE          : DEPLOYING
VM TEMPLATE         : 3
CARDINALITY         : 1
MIN VMS             : 1
MAX VMS             : 1
NODES INFORMATION
VM_ID NAME                     USER            GROUP
34 server_0_(service_22)    oneadmin        oneadmin
ROLE agent
ROLE STATE          : PENDING
PARENTS             : server
VM TEMPLATE         : 3
CARDINALITY         : 1
MIN VMS             : 1
MAX VMS             : 10
NODES INFORMATION
VM_ID NAME                     USER            GROUP
LOG MESSAGES
07/13/21 05:54 [I] New state: DEPLOYING `

Hello @htwalid,
This error has been already fixed in this commit.
Closing this, open if needed.


Feature 176 upgrade python

Pull Request Testing

[x] Describe testing already performed for these changes:

on host 'seneca', using the metdataio.v5.1 and nco_metdtaio.v5.1  conda environments

clone feature_176_python_upgrade branch

set the PYTHONPATH:
export METDATAIO_BASE=/path-to-source/METdataio
export PYTHONPATH=$METDATAIO_BASE:$METDATAIO_BASE/METdbLoad:$METDATAIO_BASE/METdbLoad/ush:$METDATAIO_BASE/METreformat

cd to $METDATAIO_BASE/METreformat/test

run all the METreformat tests:
pytest

[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Run all METreformat tests on 'acorn' using the Python packages listed in the nco_requirements.txt file to create a similar environment.

[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
updates to README.md, version, and installation.rst

[x] Do these changes include sufficient testing updates? [NA]

[x] Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:

[x] Please complete this pull request review by [before Beta1].

Pull Request Checklist
See the METplus Workflow for details.

[ ] Review the source issue metadata (required labels, projects, and milestone).
[ ] Complete the PR definition above.
[ ] Ensure the PR title matches the feature or bugfix branch name.
[ ] Define the PR metadata, as permissions allow.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes
[ ] After submitting the PR, select Development issue with the original issue number.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.

@bikegeek - These are just notes for myself as I try to install on Acorn, so I don't forget the details.
Attempt 1:
I thought I would use the EVS VE in the modulefile with the following loads:
module use /apps/ops/para/libs/modulefiles/compiler/intel/<IP_ADDRESS>4/
module load intel python/3.10.4
module load ve/evs/1.0

This does not work.  When trying to run pip install -r nco_requirements.txt I get the following error:
ERROR: Could not install packages due to an OSError: [Errno 30] Read-only file system: '/apps/prod/ve/intel/<IP_ADDRESS>4/python/3.10.4/evs/1.0/bin/f2py'

I believe this is a problem that Logan suggested might happen.  Instead of loading the EVS VE, instead simply try loading the python 3.10.4 environment.