Customise Launch URL for launch.json to something other than "server" param or server public URL

1. Describe the bug
In complex port/reverse proxy scenarios the developer services and launch URL might be different, or short-lived.
Can we please override the launch URL with something custom?
This was somewhat discussed in #7373 and #6807 but we'd like to point it to an entirely different URL altogether that isn't derived from either the usePublicURLFromServer OR the server parameter in launch.json.
2. To Reproduce
n/a
3. Expected behavior
Allow the launch URL to be customised.
A simple property such as launchUrl: "https://customurl/" (then debug context ID is appended, etc)
4. Actual behavior
Launching a URL that wont work in some complex reverse proxy scenarios.
5. Versions:

AL Language: v11.0.787898
Visual Studio Code: v1.78.2
Business Central: all
List of Visual Studio Code extensions that you have installed: n/a

Final Checklist
Please remember to do the following:

[x] Search the issue repository to ensure you are reporting a new issue
[x] Reproduce the issue after disabling all extensions except the AL Language extension
[x] Simplify your code around the issue to better isolate the problem

Hi @nndobrev,
Sorry not sure why GitHub posted twice.
I am aiming for a different url for publish vs launch (port limitations) as they're on different ports.
Regards
Jake

Posted here for reference: https://experience.dynamics.com/ideas/idea/?ideaid=dd3b7a02-d3f9-ed11-913a-0003ff45ce96


I am trying to redirect the request to the downstream service with https in spring cloud gateway?

I found that in the spring gateway ssl only support trustedX509Certificates. But I have to use the TrustStore , KeyStore,  KeyStorePassword & TrustStorePassword .
I tried to create a  HttpComponentsClientHttpRequestFactory and replace the default http client factory for RestTemplate. But it does not work at all.
Here is a route in my gateway. And I built my gateway based on Spring cloud Greenwich.RELEASE.
  cloud:
    gateway:
      routes:
      - id: topo
        uri: lb://topo
        predicates:
        - Path=/atps/**
        filters:
        - StripPrefix=1
        - Hystrix=atps

I also tried to add ssl properties with ribbon, It also does not work at all.
        props.put("ribbon.IsSecure", true);
        props.put("ribbon.IsHostnameValidationRequired", false);
        props.put("ribbon.IsClientAuthRequired", true);

        props.put("ribbon.KeyStore", Constants.KEY_STORE_PATH);

        props.put("ribbon.KeyStorePassword", storePass);
        props.put("ribbon.TrustStore", Constants.TRUST_STORE_PATH);

        props.put("ribbon.TrustStorePassword", trustStorePass);

Could anyone teach me how to do that? thank a lot in previous

gateway doesn't use ribbon properties. See spring cloud configuration properties and search for spring.cloud.gateway.httpclient.ssl. properties. Also #852 was fixed yesterday for keystore support.

I found that you added it in 2.2.0.M2.  But I want to use it now in my project.  I tried to create a RestTemplate Bean with ssl http client in my Application Context,  But is also does not work at all.
Do you have any more suggestion for that? @spencergibb

This project has nothing to do with rest template.

What can I do to achieve ?
Here is the ssl configuration for my team
       props.put("spring.cloud.gateway.httpclient.ssl.key-store",  Constants.KEY_STORE_PATH);
       props.put("spring.cloud.gateway.httpclient.ssl.key-password", keypass);
        props.put("spring.cloud.gateway.httpclient.ssl.key-store-password", storePass);
        props.put("spring.cloud.gateway.httpclient.ssl.key-store-type", storeType);

        props.put("spring.cloud.gateway.httpclient.ssl.trust-store",  Constants.TRUST_STORE_PATH);
        props.put("spring.cloud.gateway.httpclient.ssl.trust-store-password", trustStorePass);
        props.put("spring.cloud.gateway.httpclient.ssl.trust-store-type", trustStoreType);

@spencergibb  Could you give me more suggestion for this? thanks in advance.

@spencergibb  I copied the HttpClient code from https://github.com/spring-cloud/spring-cloud-gateway/blob/master/spring-cloud-gateway-core/src/main/java/org/springframework/cloud/gateway/config/GatewayAutoConfiguration.java#L568.
And set the KeyManagerFactory as following.
 public  KeyManagerFactory keyManagerFactory () throws IOException, CipherException, KeyStoreException, CertificateException, NoSuchAlgorithmException, UnrecoverableKeyException {

        KeyStore keyStore = KeyStore.getInstance("PKCS12");
        File keyStoreFile = new File(SecurityUtils.cleanPath(Constants.KEY_STORE_PATH));
        InputStream is = new FileInputStream(keyStoreFile);
        Throwable var5 = null;

        try {
            keyStore.load(is, “password”.toCharArray());
        } catch (Throwable ex) {
            throw ex;
        } finally {
            if (is != null) {
                if (var5 != null) {
                    try {
                        is.close();
                    } catch (Throwable var29) {
                        var5.addSuppressed(var29);
                    }
                } else {
                    is.close();
                }
            }

        }

        KeyManagerFactory kmf = KeyManagerFactory.getInstance(KeyManagerFactory.getDefaultAlgorithm());
        kmf.init(keyStore, keyStorePass.toCharArray());

        return kmf;
    }

But it does not work at all.  Could you give me a hand ? thanks


elasticsearch-plugins: 7.16.1 -> 7.17.4

Description of changes
Pointed by @thefloweringash in https://github.com/NixOS/nixpkgs/pull/175859#issuecomment-1146484153

I've tested building them, and at least they're building. But "analysis-lemmagen" and "search-guard" never saw releases for 7.17.4 (the latest in the 7.17 series was 7.17.3, for them both). Not sure what to do with them... -- comment

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@thefloweringash I've tested building them, and at least they're building fine. But "analysis-lemmagen" and "search-guard" never saw releases for 7.17.4 (the latest in the 7.17 series was `7.17.3, for them both). Not sure what to do with them...

This looks good. I would say since it's a patch, it's probably fine to leave as is.

Result of nixpkgs-review pr 176257 run on x86_64-linux 1


Broken Link to Google Cloud Platform Example

Looks like the GCP example is gone, and an AWS example remains?
https://github.com/redotvideo/revideo/blob/a2107462c7d925ec577eba40a988db00268c2463/README.md?plain=1#L35

Also broken the docs here:
https://docs.re.video/rendering-in-production#parallelized-rendering-with-google-cloud-functions


Getting 'sharredString's when trying to parse XSLX in the streaming mode

Sometimes, when I'm trying to use https://github.com/guyonroche/exceljs#reading-xlsx for reading rows in the streaming mode, instead of list of values, I'm getting a list of 'sharredString's
[
   { sharedString: 1 },
   { sharedString: 2 },
   { sharedString: 3 },
   ....
]

I noticed that there is a place when the library is trying to parse sharedString section https://github.com/guyonroche/exceljs/blob/master/lib/stream/xlsx/workbook-reader.js#L84
but looks like it doesn't map them back to row values.
Is it defined behaviour?

Can you try Excel.xlsx.readFile().

@LesterLyu Excel.xlsx.readFile() is working, but unfortunately I need the stream mode because of my particular case where the file is big and need to read only first few lines.

I have the same issue while trying to read a XLSX in streaming mode.
It's also hard to find a good example of StreamingReader - so maybe I'm using the reader in a wrong way.

Hi,
Is there any update on this, i am also getting SharedString when accessing row.values in stream mode on the row event.
I am trying to read the excel file in stream mode and create / write to another excel file with few modifications. Thanks.

probably related to
https://github.com/exceljs/exceljs/issues/1431

I think it might be related to https://github.com/exceljs/exceljs/issues/1558#issuecomment-1819842654

probably related to #1431

The solution proposed there doesn't solve the issue for me. I guess workbook reader isn't reliable at all

I'm also getting this issue intermittently when using the Stream reader


output of 'anchore feeds sync' to go to stdout not stderr

I'm using v1.1.1 and the feeds synchronization activity output goes to stderr:

[root@hostname ~]# anchore feeds sync
syncing data for subscribed feed (vulnerabilities) ...
syncing group data: centos:6: ...
syncing group data: debian:unstable: ...
syncing group data: ubuntu:16.10: ...
syncing group data: centos:7: ...
syncing group data: ubuntu:15.10: ...
syncing group data: ubuntu:16.04: ...
syncing group data: ubuntu:15.04: ...
syncing group data: debian:9: ...
syncing group data: ubuntu:12.10: ...
syncing group data: ubuntu:12.04: ...
syncing group data: centos:5: ...
syncing group data: alpine:3.4: ...
syncing group data: debian:8: ...
syncing group data: alpine:3.3: ...
syncing group data: ubuntu:14.04: ...
syncing group data: ubuntu:13.04: ...
syncing group data: ubuntu:14.10: ...
syncing group data: debian:7: ...
syncing group data: alpine:3.5: ...
skipping data sync for unsubscribed feed (packages) ...
[root@hostname ~]# anchore feeds sync 2>/dev/null
[root@hostname ~]#
[root@hostname ~]# anchore feeds sync 1>/dev/null
syncing data for subscribed feed (vulnerabilities) ...
skipping group data: centos:6: already synced
skipping group data: debian:unstable: already synced
skipping group data: ubuntu:16.10: already synced
skipping group data: centos:7: already synced
skipping group data: ubuntu:15.10: already synced
skipping group data: ubuntu:16.04: already synced
skipping group data: ubuntu:15.04: already synced
skipping group data: debian:9: already synced
skipping group data: ubuntu:12.10: already synced
skipping group data: ubuntu:12.04: already synced
skipping group data: centos:5: already synced
skipping group data: alpine:3.4: already synced
skipping group data: debian:8: already synced
skipping group data: alpine:3.3: already synced
skipping group data: ubuntu:14.04: already synced
skipping group data: ubuntu:13.04: already synced
skipping group data: ubuntu:14.10: already synced
skipping group data: debian:7: already synced
skipping group data: alpine:3.5: already synced
skipping data sync for unsubscribed feed (packages) ...

for cron activities it would be more beneficial to only send to stderr real errors. this is more of an Enhancement than a Bug.

Hi there! Thanks for reporting this. I think your suggestion makes sense, and I will run it by the team and get it prioritized. Are you interested in working on this yourself? We'd be happy to point you in the right direction, if you like.
Additionally, I will be tagging this issue as one that may be useful for new contributors to the project--so you'll see a tag called "Low Hanging Fruit" on your issue.
Thanks again!


refactor: restructure alert system for default integration and Livewire compatibility

Problem
This PR addresses Issue #77, which describes a compatibility problem between the Tablar alert system and Livewire. The session-based flash messages were not displayed during Livewire's render cycle, causing alerts to fail.
Solution

Refactored the alert system to include dynamic handling of Livewire events.
Implemented a new alerts-container.blade.php for rendering alerts dynamically.
Enhanced JavaScript to listen for alert events and manage alert display.
Updated tablar.php configuration for additional options like positions, duration, and dismissibility.
Ensured backward compatibility with session-based alerts.

Related Issue
Resolves #77

How to Use the Updated Alert System
This update introduces a more flexible alert system compatible with Livewire, while maintaining full backward compatibility. Here’s how it works:
1. Enable Alerts in Configuration
In your config/tablar.php file, ensure that alerts are enabled:
'display_alert' => true,

You can also customize the default alert behavior:
'alerts' => [
    'default_position' => [
        'top' => '10px',
        'right' => '10px',
    ],
    'default_duration' => 5, // Duration in seconds
    'dismissible' => true,   // Alerts can be dismissed by default
],

2. Alert Container
The alert container is already included in page.blade.php:
@if(config('tablar.display_alert'))
    @include('tablar::partials.common.alerts-container')
@endif

If your project uses a custom layout and does not rely on page.blade.php, you must include the container manually in your layout file:
@if(config('tablar.display_alert'))
    @include('tablar::partials.common.alerts-container')
@endif

3. Backward Compatibility with Static Alerts
This system is fully backward compatible with static session-based alerts. You can use them as before:
Session::flash('success', 'Operation completed successfully.');

Static alerts will inherit the default configuration values (e.g., dismissibility and duration). If you want to customize these values, you can pass an array instead of a string:
Session::flash('success', [
    'message' => 'Operation completed successfully.',
    'dismissible' => false, // This alert cannot be dismissed
    'duration' => 10,       // This alert will last for 10 seconds
]);

4. Using Alerts with Livewire
To trigger alerts dynamically from Livewire, dispatch a browser event:
$this->dispatchBrowserEvent('alert', [
    'type' => 'success',          // Alert type (success, error, info, warning)
    'message' => 'Action completed successfully.',
    'dismissible' => true,        // Optional: Default is true
    'duration' => 5,              // Optional: Duration in seconds (default is 5)
]);

5. Error Handling
If there are validation errors, they will automatically be displayed as alerts. Ensure you handle validation errors properly in your controller:
$validated = $request->validate([
    'name' => 'required|string|max:255',
]);
// Validation errors will be displayed as `error` alerts.

Notes on CSS and JavaScript Placement
Currently, the CSS and JavaScript code for the alert system are included directly in resources/views/partials/common/alerts-container.blade.php.
This was done because I don’t know where the maintainers prefer to place these assets. If you can provide specific guidance on where to move the CSS and JavaScript, I will be happy to update the implementation accordingly.
Please let me know where you’d like these assets to be placed, and I’ll make the necessary changes.

@ser-tec Hi, Do you have any update please ?


[META] OpenSearch Events Correlation Engine

Is your feature request related to a problem? Please describe.
OpenSearch is a scalable, flexible, and extensible open-source software suite for search, analytics, and observability applications licensed under Apache 2.0.
OpenSearch includes a data store and search engine where customers can store their business, operational, and security data from a variety of sources & run search queries on them.
Since the various customer infrastructure events, such as security events, observability events etc, spans across multiple indices & data streams, a strong correlation across these indices (or data streams) helps customers to identify patterns and dive into the relationship of events occurring across different systems in their infrastructure.
Describe the solution you'd like
Correlation Engine is an Events Knowledge Graph which can be used to identify and store connected events data spanning across multiple indices or data streams. Also, it helps generate insights by correlating the recent/historical data based on time windows provided by the client .
The Events Correlation Engine provides an approach to help customers correlate events across log sources by allowing customers to define their own Correlation Rules exactly once, while then generating correlations between events from different log sources automatically.
Describe alternatives you've considered
There are no direct alternatives to Events Correlation Engine in OpenSearch today which allows correlations of events across indices based on time windows.
Additional context
More detailed design covered as part of the RFC : #6779
Breaking the changes further into more granular issues for P0 items as below

[ ] 1. Skeleton - Define the skeleton for the core plugin including test setup.

Correlation Query Service

[x] 1. Correlation Rule Ingestion Layer - APIs to create/update/delete rules and persist in form of Correlation Rule Index[#7132 ]

Correlation Service

[ ] 1. Event Ingestion Layer - REST apis to ingest events from dashboard, REST client & Transport layer to ingest events from downstream plugins.
[ ] 2. Join Handler - the Join task determines immediate neighbors of a particular event, given the correlation rules defined by the user for the indices(or data streams) they wish to correlate.
[ ] 4. Insertion Handler - In this layer, events are converted to k-dimensional vectors & are stored in the vector storage layer mentioned above along with their correlations.
[ ] 5. Search Handler - this part of the Correlation Engine allows user to specify a particular event, & then converts it to a k-dimensional vector & then uses it to query its neighboring events which are actually its correlated events within a time window.
[ ] 6. OS/Lucene/HNSW Storage/Query Layer - this is HNSW Graph based storage layer used to store all event vectors & query them at the vector level.
[ ] 7. Index management of Correlation Engine indices

Address comment: https://github.com/opensearch-project/OpenSearch/pull/7132#discussion_r1166950428


[BUG]: Audit Logs - DLP Violation in Flow "[Child] Admin | Sync Logs" with Custom O365 Audit Log Connector

[BUG]: Audit Logs - DLP Violation in Flow "[Child] Admin | Sync Logs" with Custom O365 Audit Log Connector
Describe the bug
The Flow "[Child] Admin | Sync Logs" went from status "On" to status "Suspended"  (Turned Off) during Christmas.
Until then we we're able to collect audit logs from the tenant successfully.
Now when I'm trying to "Turn On" the flow again, I get this error message:
-> Your flow could not turn on: [Child] Admin | Sync Logs. Error: Flow client error returned with status code "Forbidden" and details "{"error":{"code":"DlpViolation","message":"Flow 'b3f632f1-6bd7-a337-86ee-15d181a2f275' cannot be activated due to admin API policies."}}".
The strange thing is
The Custom Audit log connector is still in the corresponding DLP policy's "Business Data" section.

You can't see the connector in the Power Platform Admin Center anymore ... ?
But If I use the Power Platform Admin Connector to get the Details of this policy, I can find the Connector looking at the JSON response for this

apiGroups: hbi
{ "id": "/providers/Microsoft.PowerApps/scopes/admin/environments/9f849632-d348-41e3-b82b-b40ef9a32bee/apis/shared_admin-5foffice-20365-20management-20api-5f439b5d80b7cda036",
"name": "Office 365 Management API (CoE PROD)",
"type": "Microsoft.PowerApps/apis"
}
Component (please tell us which flow or app you are experiencing issues with):

Solution: Center of Excellence - Audit Logs
Version <IP_ADDRESS>
Flow:     [Child] Admin | Sync Logs

To Reproduce
Steps to reproduce the behavior:

Go to the flow '[Child] Admin | Sync Logs'
Click on 'Turn On'
See error

Expected behavior
The flow could be "Turned On" again
Screenshots
Screenshot 1 - Flow Error.PNG
Screenshot 2 - DLP - Custom Connector not shown
Screenshot 3 - DLP - Custom Connector is still in policy (JSON).PNG
Screenshot 4a - Custom Connector is still there.PNG
Screenshot 4b - Custom Connector is still working.PNG

Additional context

Please refer to the comms shared in the Message Center MC231184 for guidance on the update that has happened (copied excerpt below for reference). Please note that while custom connectors are not visible on the tenant admin UI anymore, it is still visible on PPAC UI for environment admins (as custom connectors are associated with specific environments).
Title:
Power Platform - Update to Add-CustomConnectorToPolicy data loss prevention (DLP) PowerShell cmdlet
Description:
Beginning December, 2020, data loss prevention (DLP) policies’ Powershell cmdlet Add-CustomConnectorToPolicy will no longer support the addition of custom connectors to tenant level policies. Additionally, custom connectors added to tenant level policies will not be shown on the data loss prevention page (DLP UI) in the Power Platform admin center.
What specifically is changing?
Beginning December, 2020, the Powershell cmdlet Add-CustomConnectorToPolicy will no longer support the addition of custom connectors to tenant level policies.
Legacy policies that were created with this feature will continue to function, however custom connectors added from the PowerShell cmdlet will not appear show on the Power Platform admin center user interface for tenant level policies. This cmdlet will be deprecated in Q1 2021, and environment admins should begin migrating to the data loss prevention cmdlets New-DlpPolicy, Get-DlpPolicy, Set-DlpPolicy and Remove-DlpPolicy to create and manage DLP policies with all types of connectors including custom connectors.
How can you manage custom connectors after this change?
If you were leveraging this gap as a by-design method to manage the DLP policies, then you can switch to using environment level DLP policies to manage custom connectors. We recommend keeping tenant level policies in place and copy these settings to environment level policies, then add custom connector classification as an add-on setting using the same PowerShell cmdlet along with the environment name as a parameter.
Only Environment Admins will now see the custom connector in the UI, even if it has successfully been added. If you have reviewed your custom connector has been added with the right ConnectorId, and all other connectors used in the app or flow are present in the business data only group of the policy and you are still experiencing issues, please raise a support ticket so a support engineer can take a look. As this is a DLP issue, and not an issue with the CoE Starter Kit we are unable to help here.
If you require assistance with the new DLP cmdlets, sample implementations are available here PowerApps-Samples/powershell/admin-center at master · microsoft/PowerApps-Samples (github.com), one of the sample implementations shows how to now add a custom connector to a policy, see:
Add-CustomConnectorToPolicySample -EnvironmentName Default-02c201b0-db76-4a6a-b3e1-a69202b479e6 -PolicyName 7b914a18-ad8b-4f15-8da5-3155c77aa70a -ConnectorName BloopBlop -ConnectorId /providers/Microsoft.PowerApps/apis/BloopBlop -ConnectorType Microsoft.PowerApps/apis -GroupName hbi

Please refer to the comms shared in the Message Center MC231184 for guidance on the update that has happened (copied excerpt below for reference). Please note that while custom connectors are not visible on the tenant admin UI anymore, it is still visible on PPAC UI for environment admins (as custom connectors are associated with specific environments).
Title:
Power Platform - Update to Add-CustomConnectorToPolicy data loss prevention (DLP) PowerShell cmdlet
Description:
Beginning December, 2020, data loss prevention (DLP) policies’ Powershell cmdlet Add-CustomConnectorToPolicy will no longer support the addition of custom connectors to tenant level policies. Additionally, custom connectors added to tenant level policies will not be shown on the data loss prevention page (DLP UI) in the Power Platform admin center.
What specifically is changing?
Beginning December, 2020, the Powershell cmdlet Add-CustomConnectorToPolicy will no longer support the addition of custom connectors to tenant level policies.
Legacy policies that were created with this feature will continue to function, however custom connectors added from the PowerShell cmdlet will not appear show on the Power Platform admin center user interface for tenant level policies. This cmdlet will be deprecated in Q1 2021, and environment admins should begin migrating to the data loss prevention cmdlets New-DlpPolicy, Get-DlpPolicy, Set-DlpPolicy and Remove-DlpPolicy to create and manage DLP policies with all types of connectors including custom connectors.
How can you manage custom connectors after this change?
If you were leveraging this gap as a by-design method to manage the DLP policies, then you can switch to using environment level DLP policies to manage custom connectors. We recommend keeping tenant level policies in place and copy these settings to environment level policies, then add custom connector classification as an add-on setting using the same PowerShell cmdlet along with the environment name as a parameter.
Only Environment Admins will now see the custom connector in the UI, even if it has successfully been added. If you have reviewed your custom connector has been added with the right ConnectorId, and all other connectors used in the app or flow are present in the business data only group of the policy and you are still experiencing issues, please raise a support ticket so a support engineer can take a look. As this is a DLP issue, and not an issue with the CoE Starter Kit we are unable to help here.
If you require assistance with the new DLP cmdlets, sample implementations are available here PowerApps-Samples/powershell/admin-center at master · microsoft/PowerApps-Samples (github.com), one of the sample implementations shows how to now add a custom connector to a policy, see:
Add-CustomConnectorToPolicySample -EnvironmentName Default-02c201b0-db76-4a6a-b3e1-a69202b479e6 -PolicyName 7b914a18-ad8b-4f15-8da5-3155c77aa70a -ConnectorName BloopBlop -ConnectorId /providers/Microsoft.PowerApps/apis/BloopBlop -ConnectorType Microsoft.PowerApps/apis -GroupName hbi


[Bugfix]Add sharded_state  to load format

This PR resolves an issue where the vllm serve command fails due to an invalid choice for the --load-format argument. The error encountered is:
vllm serve: error: argument --load-format: invalid choice: 'sharded_state' (choose from 'auto', 'pt', 'safetensors', 'npcache', 'dummy', 'tensorizer', 'bitsandbytes')
Changes Made:

Added sharded_state as a valid option for the --load-format argument.

/ready

closed due to https://github.com/vllm-project/vllm/pull/7784


--ipc=host is not a valid option for docker build

Output of docker version:
Client:
 Version:      1.12.0-rc4
 API version:  1.24
 Go version:   go1.6.2
 Git commit:   e4a0dbc
 Built:        Wed Jul 13 03:28:51 2016
 OS/Arch:      darwin/amd64
 Experimental: true

Server:
 Version:      1.12.0-rc4
 API version:  1.24
 Go version:   go1.6.2
 Git commit:   e4a0dbc
 Built:        Wed Jul 13 03:28:51 2016
 OS/Arch:      linux/amd64
 Experimental: true

Output of docker info:
Containers: 5
 Running: 0
 Paused: 0
 Stopped: 5
Images: 393
Server Version: 1.12.0-rc4
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 269
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: null host overlay bridge
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Security Options: seccomp
Kernel Version: 4.4.15-moby
Operating System: Alpine Linux v3.4
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 3.857 GiB
Name: moby
ID: 2Z3I:WCTP:WDCK:K44Q:GSL7:QATQ:ONZP:EG7N:CLII:V54L:ZLFV:YC4I
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): true
 File Descriptors: 40
 Goroutines: 52
 System Time: 2016-07-18T06:11:46.618698428Z
 EventsListeners: 1
No Proxy: *.local, 169.254/16
Username: vitspinka
Registry: https://index.docker.io/v1/
Experimental: true
Insecure Registries:
 <IP_ADDRESS>/8

Additional environment details (AWS, VirtualBox, physical, etc.):
Docker for Mac: Version 1.12.0-rc4-beta19 (build: 10258)
Steps to reproduce the issue:

docker build --ipc=host

Describe the results you received:
unknown flag: --ipc
Describe the results you expected:
Build should accept ipc flag, the same way run does.
Additional information you deem important (e.g. issue happens only occasionally):
In my Dockerfile, I need to run a process that uses a lot of shared memory (to create an Oracle database using dbca, Database Configuration Assistant). The process runs fine in a container, when the container is started with --ipc=host. However, such option is available only for 'run' and not for 'build'.

Hi, none of those options are available on build, largely to keep build portable. Why are you creating a database at build time? This cannot be a good idea as there are no volumes to store the data on.

It's a container for developers and for Jenkins. Creating an empty the database takes nontrivial time, plus I run some basic configuration scripts there... And I don't want to do it every time Jenkins starts a new container, or every time developer wants a new container.
There are no actual data to be persisted in the database (again, it's just dev/test), so having no volumes is not an issue for me.

Why does it need --ipc-host? You can do it at run time and then use docker commit to save a new image as another workaround.

The process actually starts Oracle database, which uses a lot of shared memory. It just fails without --ipc=host.
Yes, docker commit is a workaround and it works, I can confirm that. I am just wondering if there is a better way.

Ah ok, yes, I think there should be an option to increase the default shm-size for all containers, which would then change the value for build, I can add this. We could also allow override on build, but I think the default globally is probably a bit low. Does it work on docker run with --shm-size set to a larger value? Just checking as there are several sorts of shared memory, and it might be the other sort Oracle needs (set with --sysctl, which we may also need to support globally).

@justincormack docker build --shm-size already exists.

@cpuguy83 ah ok. I think it is the kernel.shmmax sysctl then. Maybe we need default sysctl values, rather than just for run, there are some other use cases for this (unpriv ping).

I tried with --shm-size, but that did not help. Neither did setting --ulimit memlock.
The errors are strange, however - apparently it manages to allocate shared memory, but eventually it just dies with zombie processes lying around.

------ Shared Memory Segments --------
key        shmid      owner      perms      bytes      nattch     status
0x00000000 6127616    oracle<PHONE_NUMBER>    50
0x00000000 6160385    oracle<PHONE_NUMBER>80  25
0x00000000 6193154    oracle<PHONE_NUMBER>    25
0x8a763fb8 6225923    oracle     640        20480      25

------ Semaphore Arrays --------
key        semid      owner      perms      nsems
0xd9ba3164 229376     oracle     640        304

------ Message Queues --------
key        msqid      owner      perms      used-bytes   messages

That looks fine, I see essentially the same output when I start it with --ipc=host. So I guess there is more to --ipc=host that just shared memory segments and semaphores.
For completeness:

------ Message Queues --------
key        msqid      owner      perms      used-bytes   messages

------ Shared Memory Segments --------
key        shmid      owner      perms      bytes      nattch     status
0x00000000 655360     oracle<PHONE_NUMBER>    46
0x00000000 688129     oracle<PHONE_NUMBER>92  23
0x00000000 720898     oracle<PHONE_NUMBER>    23
0x1df18474 753667     oracle     640        16384      23

------ Semaphore Arrays --------
key        semid      owner      perms      nsems
0x91458340 98304      oracle     640        304

(The sizes are slightly different, as my scripts change the total memory allocated to Oracle.)

@vit-spinka you need to use the --sysctl kernel.shmmax=... option I think with docker run, this is only available on Docker 1.12, this sets the limits for the other kind of shared memory, but as it is namespaced you cannot set this globally.

I tested --sysctl kernel.shmmax= with docker run and I can confirm that Oracle is happy with it, it does indeed work.
I guess by 'globally' you mean 'able to be set at build'. Indeed docker build does not recognize this as an option. (unknown flag: --sysctl)
Docker version 1.12.0-rc4, build e4a0dbc, experimental

@vit-spinka I am planning to add an option to set sysctl values in the daemon config, so they are set for every container that runs if not overridden, including for build.


XSS vulnerability

Hello,
I have identified an XSS vulnerability on the last version of ngx-markdown-editor (3.3.2 - Last commit 783fe2df2f7709b2ac8bba5e1bea42074d48ce0d).
Payload :

Previewed as:

The XSS:

You can set this markedjsOpt.sanitize to true. That's can prevent this.

The option is already set to true.
It blocks other payloads, but not this one.
I used the preconfigured "demo" subfolder from this repository.

Please using 3.3.3. This version has been fixed this issue.


Refs 4294: fix db migration test

Summary
Testing steps
pr_check test run passes AND build test passing.
Checklist

[ ] Tested with snapshotting feature disabled and pulp server URL not configured if appropriate

https://issues.redhat.com/browse/HMS-4294

⚠ This task currently requires qe-approval, but this PR does not fully resolve the task.  Please contact QE to determine appropriate testing required.


How the parameter 'with_crowd' works?

How the parameter 'with_crowd' works? I did not find the place to cope with 'bbox_ignore', but the program has this parameter. Any advice will be appreciated, thanks

Ignored bboxes are used when assigning the targets, see here.

@hellock  Got it, thanks


About the current Normal Distributions Transform (NDT) algorithms (implemented|supported|used|integrated) (by|in) Apollo.

Hi,
Here gives a list of papers relating specifically to the NDT technique for point cloud scan matching.
It seems that the Semantic-Assisted 3D Normal Distributions Transform (SA-3DNDT) is the strongest and most promising NDT algorithm among them. I just want to know which NDT algorithm (implemented|supported|used|integrated) (by|in) Apollo currently?
Regards,
HY

Closed due to inactivity. If the problem persists, pls feel free to reopen it or create a new one and refer to it.


Replace the current definition of refactor

Replace the current definition of refactor

refactor: A code change that neither fixes a bug, nor adds a feature, nor implement a performance improvement

with:

refactor: Restructuring of existing code without changing its external behavior (correlates with PATCH or MINOR in semantic versioning).

Since the external behavior does not change, a commit of type refactor cannot be a breaking change (see https://github.com/conventional-commits/conventionalcommits.org/issues/229).
Note that the external behavior is changed by bugfixes, performance improvements, as well as by the implementation, deprecation and removal of features; thus changes of these types cannot be included in refactors.

Totally agree with this, the proposed definition has a better scope compared to the current one. And indeed a refactor cannot be a breaking change.

Does the "external behavior" include attributes such as method or package names?

Yes (then renaming a method is not a refactor).
No (then renaming a method is a breaking refactor).


login with docker version fails if the email-ID contains DOT

Docker containers are running successfully

Looks like there is a bug at the backend if the email-ID contains "." in it the login fails.

Thanks for your feedback! We will remove this limit as quickly as possible.

This issue has been fixed!


Close/Min/Max buttons on OSX will overlap the profilepicture if serverlist is closed.

@ausminternet commented on Mon Oct 23 2017

This can be fixed by adding more padding-top to .sidebar__account if serverlist is closed.

@gdelavald could you close this issue?


Update OperandType.java

Changes in the isInteger(final String value) method. Use for-each construction instead of older for block.

I signed  Google Individual Contributor License Agreement.


Issue in wallet field types

At the end of the chapter 8.1, 2 Wallet are instanciated with the following code:
    let w1 = Wallet { balance: true, address: 10 };
    let w2 = Wallet { balance: 32, address: 100 };

Then, a paragraph explains that we create 2 instances: one of Wallet<bool, u128> and the other of Wallet<felt252, u8>.
I think that it's not correct as the compiler will use felt252 to store 10, 32 and 100 values by default.
To be sure to have an instance of Wallet<bool, u128> and another of Wallet<felt252, u8>, we have to use 10_u128 and 100_u8.

This change is

Great, nice catch. However I'd rather have explicit type annotation, for clarity, rather than relying on automatic type inference. It makes it more obvious to the reader as well.
Thank you for your thorough reviews!

Yes, I agree 👍


Ability to add handlers after the config stage

We use a angular service to handle track events with angulartics.  Right now the way we handle adding the track handler is a little janky.
angular.module("app", [])
  .config(analyticsConfig);

analyticsConfig.$inject = ['$analyticsProvider'];
function analyticsConfig ($analyticsProvider) {
	function track (event, properties, options, callback) {
		getAppInjector().invoke(['reportingService', function track (reportingService) {
			reportingService.track(event, properties);
		}]);
	}
	$analyticsProvider.registerEventTrack(track);
}

function getAppInjector () {
	return angular.element(document.body).injector();
}

Would you be open to a PR that would add the ability to add handlers after config or is there another recommended way of doing this?

I'm so very confused. Your reportingService can't register the event itself?

Sorry I am just not following, what's wrong with forming your service the same way all the others are done?

Closing, please reopen or file a new issue if needed


Publishing prebuilt native binaries

Need an easier, end-user friendly way of publishing prebuilt binaries. There are examples here and here that can be used create a version of the plugin which works but something part of the API would be ideal.
Expected Behavior

New plugin, say "cpp-prebuilt", with option for profiles/configuration/platform and all the other necessary jingle-bells.
Current Behavior

Home grown solution works but isn't extendable and is incomplete in many ways. There isn't one in the API, as of yet.
Context

We publish 150+ prebuilt binaries that are produced by build system using anything but gradle. These are distributed as prebuilt binaries (headers, static libs, dynamic dlls) for consumption. These need to be published using the same "signature" as if these were the output of a successful gradle build so they can be consumed downstream identically.
Steps to Reproduce (for bugs)

Publish any library project in native-samples repo and try consuming that in corresponding application.
Your Environment

Build scan URL:

Publishing binaries as there were built by Gradle is one way to do it. However, you can achieve the same result without publishing the binaries inside a maven or nexus repository. At the moment, the moment, publishing binaries through Gradle requires a lot of internal API. The sample you are referring was created to unblock a particular client. I wouldn't suggest going down that route at the moment. I agree we will provide public API to aid with the publication of 3rd party binaries. We don't have a clear roadmap on when such API will be part of Gradle.
An alternative solution is to consume the prebuilt binaries as they are published by the vendor and expose them in Gradle by linking the binaries to the dependency management. This solution doesn't use any internal API. The concept goes as follow:

If the vendor publishes the package as a zip, have a set of tasks to download and extract the zip and link those tasks in the dependency management. See prebuilt-sdk sample.
If the vendor publishes the package as an installer, either have Gradle run the installer to "extract" the binaries (complicated, but can be easy for the self-extracting executable on Windows) or massage the installer into a zip that you expose in some way followed by option (1) (easier). This option was successful in the past for dealing with Windows SDK and DDK.
If the vendor publishes the package inside some package manager such as Homebrew, Yum, MacPorts, Chocolatey, etc., have Gradle locate the binaries in known locations for those package manager. You can have Gradle actively install them.

All other scenarios that we can think of at the moment are a variation of those solutions. We understand those solutions may be more of the same of what you already have and aren't ideal. To move this story forward, could you document your use case here? The questions we would be interested in are:

How the vendor of your prebuilt binaries publishing them?

What format is used? Archive? Individual binaries? Installer? Package (for package managers)?
How are they served? Http? Ftp? NFS? Package manager? Checked inside source control? Well-known location on the file system?

What kind of variation of the binaries are available? Debug/release? With some features enabled/disabled?
Are the variations of the binaries part of the same "package" provided by the vendor or they are scattered around in multiple places that need to be reconciled. A better understanding of what I'm talking here is prebuilt Boost binaries. They are mostly in package managers, but each operating system family has its own package manager of choice. On Windows, the Boost prebuilt binaries are published on source forge as an installer for each Visual Studio version.
Are you required to consume a range of prebuilt version throughout all the project? For example, some project needs Boost 1.63 while others use Boost 1.65, etc.
Out of all those use case that we gather with the previous questions, which one is the most used pattern? We will try to solve the most important first.

@lacasseio

An alternative solution is to consume the prebuilt binaries as they are published by the vendor and expose them in Gradle by linking the binaries to the dependency management.

This will require managing this dependency at every level in the project hierarchy. Any solution outside of Gradle will either not support transitive dependency or will end up doing lot of work what Gradle already does to manage the lifecycle.

How the vendor of your prebuilt binaries publishing them?
What format is used? Archive? Individual binaries? Installer? Package (for package managers)?
How are they served? Http? Ftp? NFS? Package manager? Checked inside source control? Well-known location on the file system?

Since we are our own vendor, the format is always headers and prebuilt binaries (not binary, i.e. not necessarily just one). At the moment, they are being served directly from our repository as part of one really huge monolithic blob.

What kind of variation of the binaries are available? Debug/release? With some features enabled/disabled?

This varies widely. Usually, at least debug and release. In some cases, we have feature based binaries like with different log levels, whether the binaries where built with asm enabled or not, and in some cases, built with optimizations enabled but in-lining disabled to support debuggers.

Are the variations of the binaries part of the same "package" provided by the vendor or they are scattered around in multiple places that need to be reconciled.

Usually they are. For 9/10 use cases, what we have is one monolithic blob. Consumer chooses what's to be consumed.

Are you required to consume a range of prebuilt version throughout all the project?

Always. Teams move at different pace and some can upgrade earlier then others. Plus, some can even walk back if they find some feature that they need broken in newer release.

Out of all those use case that we gather with the previous questions, which one is the most used pattern?

I want to publish a module with headers and multiple libraries per variant and pick the variant at consumption time. For e.g. OpenSSL comes with a few headers and at least two libraries each for debug and release. For half the use cases, only one or the other library is used, so ability to define multiple variants is important here (because linking both libraries would fail).
Variant 1 - Headers + Debug library A
Variant 2 - Headers + Debug library B
Variant 3 - Headers + Release library A
Variant 4 - Headers + Release library B
Variant 5 - Headers + Profile library A
Variant 6 - Headers + Performance library B
and so on.
Our use cases fall in multiple different buckets -

We are our own vendor. We massage whatever is external to fit our build flow and make it available in our own repository. Our setup do not allow reaching out to download/install any external dependencies.
We take ownership of certain publicly available project, make some tweaks and use it in our projects. These are usually minor tweaks to support either some unsupported platform or fix some minor bug and we don't want to upgrade to next available version. In either and all cases, we use the build system that comes with this inherited project. These build systems generally require additional dependencies and setup (like MinGW, MYSYS, CMake, autotools, etc). We don't expect every developer on the team to understand and know how to use these systems.
We inherited a project from some other team within the organization and they don't use Gradle. In many cases, we don't even build their project (primarily because that requires a environment setup which in many cases is proprietary to the team). All we inherit is an archive (usually in proprietary format) that is unpacked and made available for our project to use.
We license technology from third party vendors that only provide us with binaries. The format can vary widely. Our usual process is to do the necessary manual work to make it compatible within our system so they can be consumed by our projects.
If some library was available only as an installer, we manually install it once and extract what's necessary to built. If that doesn't work, we modify our build machine image to pre-install such dependency.
I am certainly missing more use cases but above ones should give you a good idea. We publish close to 200 modules and you can say, I am not familiar (how they were generated or how they are consumed) with all of them.

At the moment, most, if not all, these prebuilt binaries are committed to our internal repository (and no we are not using Git).
We can make a decent progress with minimal support from within Gradle without digressing too far from long term solution. If Gradle can support a plugin to define paths to debug and release library/binary in the DSL, and this plugin is an extension to CppStaticLibrary (and CppSharedLibrary) and just wire it in such a way to avoid compilation, we could be in business. The plugin will explicitly set the output of the compile task with the input from the DSL and mark it realized. This the quickest path to get headers + one binary (with transitive dependency) into the pipeline. If this can be realized as an external plugin, tell us how. Do you see any immediate pitfalls. Its understood that this is not a long term solution but will get up over the immediate bump.

Hi @amz-shahji
Did u eventually find a way to publish prebuilt binaries?
Thanks

@awaizman1 Publishing pre-build binaries isn't possible out of the box, but if you have a specific use-case, I can write you a sample to ensure you can progress with your Gradle native journey. :-)

Appreciate it @lacasseio,
My use case is very simple: I have prebuilt binaries (in the form of .dll + .lib, .so) and public headers folder.
The files either obtained from 3rd party vendor or manually built by me according to 3rd party build procedure.
Now I want to publish those binaries and headers (for win and Linux) to a private maven repo (where I publish other gradle cpp projects to).
Thanks.

Hi @lacasseio
could you reference me for such sample please?
thanks

Sorry for the delay in responding, I will write up some quick sample tomorrow for those use cases.

@awaizman1  Here is a sample that should put you on the right track for now. The samples try to be a bit more flexible than just configuring a bunch of Configuration objects by modelling the core concept used in Nokee. A quick rundown of the concept goes as follow:

Each variant is defined as a cross-cutting slice of the possible values for each dimension.
A dimension is a logical grouping of some values where at most one value can be selected per variant, for example, the dimension operating system family can include Linux, macOS, Windows, iOS, Android, etc as their values but only one would be selected for a particular variant. Other dimensions include machine architecture, build type and binary linkage.
Each value selected per-dimension are grouped together to form the build variant.
For each build variant, we create the necessary configuration to allow consumers to resolve the produced binaries.

Keep in mind the sample simplifies greatly the problem and how variants are handled. Most of the boilerplate code in this sample should go away in the next few Nokee releases if you use the plugins. With the Gradle core plugins, you will have to keep that boilerplate code and most likely wrap it inside a custom plugin.
Note that the sample doesn't try to solve the issue with partial publishing (when you build binaries on different systems and want to publish only a subset of the variant on each machine). The sample assumes you have all the binaries built and ready to be published.

Don't hesitate to ask more questions, I understand the core concept can be confusing at first. I'm still trying to find a good way to explain them properly. It's a powerful feature that leans a bit toward being too abstract.


Does this work as ACME client only for Let's Encrypt or other CA's are/will be supported?

Was wondering if I can configure to use KCert for ZeroSSL using External Account Binding. Would be amazing if it can be!

KCert doesn't support external account binding right now, but I read quickly through the docs and it doesn't look too hard to do.
No promises on when, but I'll try.

I haven't written much .NET code except for almost a decade ago in college, but if you can point to where you think this can be plugged in, I might try giving a shot.
Unfortunately the reason why I was looking to use EAB was to to be able to use ZeroSSL, but its seeing some major outage at the moment and failing to register account and issue certificate with using ACME, and Let's Encrypt doesn't have EAB support so would be difficult to test the feature out even after writing it up.
But I'd think it'd be a good addition to KCert feature set, so worth spending some time to it.

If you're interested in the learning experience, I'll wait for you to take a first try at implementing this. I'd be happy to answer questions and review pull requests. If I'm understanding this correctly, it's should just be an edit to the NewAccount request:

The payload is just an anonymous object defined here:
https://github.com/nabsul/kcert/blob/32c9b96a51b5922e7a5611ce8ac8030a7740130f/Services/AcmeClient.cs#L62
You should be able to insert a conditional there that either creates the current body object, or one that includes the EAB stuff.
To turn EAB on/off I think you just need to add two environment variables in the Acme section for the EAB key and kid. You would then set those through environment variables like ACME__EABKEY (with two underscores).
Probably the most time consuming part of this will be testing :-D
Just let me know if you're not interested in making the change yourself (which is totally fine!). It shouldn't take me too long to follow this plan.

Its a saturday evening I'll be more than happy to dabble some right away. Aside from learning experience I think its a genuinely good addition to KCert. I'll try and raise a PR ASAP so you can review in your own time (as of now I have reverted back to using cert-manager for my project).
I am not sure how to test this right now, maybe when ZeroSSL outage is fixed it possible can be sorted (though some work around looking around in cert-manager issue section seems to suggest that longer timeouts seem to mitigate it to some extent).

This is being implemented in #100


Add support for estimate fees and simulate transactions

As described in title, it would be good to have support for these two features. We could propose a standard and take help of wallets to do necessary integrations.
Reason for estimate fees:
DApps will be able to show precise fee to users on their UI's itself
Reason for simulate:
Dapps will be able to precisely use info on tokens in and out to give users easy clarity on what they would receive finally. Usually, this is an easy thing for simple contracts, but for projects like Hashstack.finance which involve integrations with different DeFi apps for swaps, liquidity provisions, staking etc, being able to write logic to estimate tokens output can itself be complex math. Given that the RPC supports simulation, exposing it could be easier and may even help others?

I haven't checked the project code in detail, but if project contributors think this can be implemented, I can try working on this.

Hello, yes I think it would be very useful. My understanding is that we need two steps:

Create a new hook (useEstimateFees, usually I use the rpc method name) to estimate the fees.
Update the useContractWrite hook to accept the fee estimation from the previous hook.

@fracek will try to complete this and raise a PR.


Make Data GC-able (bp #1624)

This is a manual backport of pull request #1624 done by @jackkoenig.

Red X is just that this PR must be merged manually because it changes CI


xml escape character "&" is corrupting sheetname on write

in book.get_sheet_by_name_mut("Sheet2").unwrap().get_cell_mut("A1").set_value("TEST1");
if the sheet name contains xml escape characters for example say Alice&Bob then it is not detecting the Worksheet.
On inspection the  ''Alice&Bob'' is being processed as Alice&Bob, that would mean that xml escape character & is not properly read as &.
calling sheet by Alice&Bob is saving the workbook as Alice&&amp;Bob

@agentjill
Thank you for your report.
We will address this in the next version update.

This was addressed in #145.


Add etcd state store

Description
Add etcd as state store

[x] CRUD
[x] Transactional
[x] ETag
[x] TTL
[x] Actors
[ ] Query

Issue reference
Fixes #818
Fixes #2360
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@ItalyPaleAle For some reason, my old account was flagged, so I open a new PR

@taenyang can you please open a PR in dapr/docs with docs for this component? Or at least an issue to get that done later?

@taenyang please comment on this documentation issue: https://github.com/dapr/docs/issues/3269
Leave a comment /assign


Use go test instead of gb test

Hello,
while I like gb and it's folder structure, I don't like it's testing tool.
What do you think of replacing gb test in the Makefile with the Go counterpart?
You could make use of awesome Go testing features, which are not (yet) possible in gb, like -race or -cover, e.g.:
GOPATH=$(CURDIR):$(CURDIR)/vendor

test:
	GOPATH=$GOPATH go test -v -race -cover ./src/...

:+1:

:+1:


ServiceDetail not follow the Catalog when no services under the select Catalog.

This issue seems to have been fixed by #6.


provide entry or entry-like methods for Extensions

Currently it is not possible to use the https://doc.rust-lang.org/stable/std/collections/hash_map/enum.Entry.html#method.or_insert_with for the Extensions, despite it being a hashmap.
Granted it's an edge case and also maybe the entire Entry API is a bit over kill.
But at the very least would be nice if one could do get_or_else(..fn) and get_mut_or_else(..fn).
At the moment that would require first using a get() and then an insert() etc...
Awkward and can give also awkward lifetime situations.

If there's interest for this I'm willing to contribute this, would just need to know what the preferred API would be in that case...

Hm, I'm sympathetic to the usage pain, but I'm apprehensive about making the Extensions type much more like HashMap, such as with an Entry type. Possibly get_or_... methods would be sufficient?

Yes. That’s indeed what I had in mind. How would you name these methods exactly? So i can open a PR or would this need more discussion first?

There’s no rush btw. I scratched the original use cases for this, as it seems to lead to worse design. So far I haven’t found a legit new use case for it where it would unblock something or change things for the better.
so unless there are others that want this or you yourself think this is useful I’m going to not implement this until also voted/requested by you or others.

I'd appreciate get_or_... methods as well. I can make a PR if you're interested @seanmonstar

Sure!


Add ZaireEbola V3 and Nipah V1

Add schemes for new validation experiments

Can you remove the duplicated files?

Should be fixed now


Some times $dispatch not work

Vue.js version
1.0.28
Reproduction Link
https://jsfiddle.net/yangmingshan/4jc2fcxg/
Steps to reproduce
Double-click +1 button in short time
What is Expected?
The number add 2
What is actually happening?
The number ony add 1
In second click child component $parent is null, don't know why

Since the v-for loop is removing the element and inserting a new one, the child is unable to dispatch a message. Here's a version where you can see the count reset after the timeout: https://jsfiddle.net/posva/31p5uq56/
I'm not sure it's a bug because the component has no way of knowing if a setTimeout has been set up. Even if we save the current parent somewhere, if the parent of the child element also changes in that frame of time, we will end up in the same situation, which is your case here.

I know it's a terrible case, But I don't know it's a bug or not, so I point out. Thanks for your explain, I don't mind if you close this issue

Actually, the repro was great: it was short and let me find the cause very quickly.
Thanks for pointing it out 🙂


Improve prevention of removing the gardener finalizer on Shoots

What this PR does / why we need it:
The Shoot admission plugin now only allows removing the gardener finalizer when the Shoot deletion has completed successfully. It therefore checks Shoot.status.lastOperation instead of checking if the Shoot namespace in the Seed still exists.
This is done to remove communication from the Garden cluster to the Seed cluster (prerequisite for #1601)
Which issue(s) this PR fixes:
Special notes for your reviewer:
Release note:

`gardener-apiserver` now prevents the removal of the `gardener` finalizer for existing shoots if the shoot deletion has not yet finished successfully.

Indeed. I removed the RuntimeClientFactory and all related code.
PTAL

@tim-ebert can you resolve the conflicts?

Sure, done :)
Should be good now


update header links

[description]:

update header links and styles for Kubernetes campaign

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/527c4b78178b7fbed1917d8bbb9be3cff6090535/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/fabe40b462f12159643b9d018f80883a4219469f/


Comparison with Nitro

Nitro is getting a lot of hype. I'm thinking HatTip could ride on Nitro's wave by telling users how it compares itself with Nitro.

FWIW

Nitro is the universal backend that powers a lot of the magic in Nuxt. You can think of it as everything except for the rendering layer of your application (everything except for Vue).
h3 is the HTTP framework that powers Nitro. Nitro layers on file-based routing, asset handling, storage abstraction, and many more features to turn it into a very powerful framework.

https://masteringnuxt.com/nuxt3/lessons/5-16-understanding-nitro
So to me it seems like HatTip would compare to H3, albeit being quite a bit slimmer than H3 (no fs-routing etc.).
Nitro would compare to Vike, I guess. Although I couldn't figure out if Nitro is based on Vite or not (but Nuxt 3 is, so presumably yes... but there is a vite-plugin-nitro needed...). Furthermore, Nitro is focused on API endpoints, whereas Vike isn't.

Maybe Nitro is not a substitute for Vike, since here's an example using Nitro with Vike...:
https://github.com/ThimoDEV/turbo-nitro-vike-example
Though I came across this...:
https://github.com/Codpoe/servite - "A vite plugin for React SSR / SSG / CSR / Islands. Powered by nitro."


error broadcasting tx: status not ok: 400 Bad Request

400 response: error broadcasting tx: status not ok: 400 Bad Request on request to POST /wallet/spend
{
  "address": "t1dSnLkoihhr1eCcWaGnHqTYVT3St2Z8UFp",
  "memo": "",
  "fee": "ECONOMIC",
  "amount": 71208,
  "wallet": "ZEC"
}

When the balance is:
"ZEC": {
        "confirmed": 100000,
        "height": 407181,
        "unconfirmed": 0
    }

The fees are:
"ZEC": {
        "economic": 140,
        "normal": 160,
        "priority": 180
    }

This was an issue specific to Insight. Decided to remove insight support until some later date. Closing issue.


Frame Rate - Real Time Prediction

HI @fandulu ,
I would like to ask you about my problem.
I've got the camera that only produces the 5 FPS video files. In comparison with JHMDB dataset, it's about 32 frame lengths. Therefore, base on your wide range of knowledge, is it a serious problem when applying your model to my data?
I've tried to use the Open Pose so that I can the joints information and then preprocessing as inputs to your model. However, I got a really bad performance at around 50% accuracy.
Furthermore, I would like to make your model become a real-time prediction with window = 8. However, I don't know what is suitable values for setting up. Do you have any advice?
Thank you so much for reading my silly questions. I hope that I can receive valuable suggestions from your.

Hi, I think there could be three reasons for bad performance: (1) The good action prediction relies on good pose estimation but pose estimation usually contains a lot of noise; (2) The actions defined by others (e.g., JHMDB) may not suitable for your desired action; (3) In wild body-related (not hands) action recognition case, RGB information is quite useful and it significantly improves the action prediction performance, it may be better to just partially depend on body skeleton.
If you only have one person in the video, you may find some ideas at https://www.pyimagesearch.com/2019/07/15/video-classification-with-keras-and-deep-learning/. If you have multiple people, I personally think it might be better to follow AVA detection related works at https://research.google.com/ava/. If you are working on hand gestures, I think DD-Net should be helpful, even the camera may produce the 5 FPS video files, you can use frames in the past few seconds and with a little prediction delay.


v1.2.1

Hi.
Would you mind publishing bugfix release?
The version in the main branch is working, but the latest release does not.

There were some problems with outdated dependencies. I updated them.
Did that help? What exactly do you mean by "the latest release does not [work]"?

What exactly do you mean by "the latest release does not [work]"?

Thank you!


Rollup tests are hard to change

You get a diff, but you have to manually go through and update it if it's right.
If they were using tasty-golden like many of our others, then that has --accept, which is very handy.

This is actually pretty painful. Any time I do anything that changes the hash of the script in the example (e.g. https://github.com/input-output-hk/plutus/pull/1486), the whole thing changes and it's not very easy to adjust it.

Yeah, that's nasty. tasty-golden looks much nicer. I've opened a PR. :-)

Argh, I still can't make this work since the playground tests are very hard to run. AFAICT there's no particular reason why this depends on the playground, and we could write them in terms of plutus-use-cases or something instead.

I'm doing a lot of things that change how scripts are compiled at the moment, so this is biting me a lot...

This got fixed.


Documentation of performance subjects

Currently several significant subjects on performance optimization require knowledge of the Rete algorithm and/or Clara's internals to understand.   Examples include

The benefit of using hash-based joins versus Cartesian joins.  This came up recently on the mailing list at https://groups.google.com/forum/#!topic/clara-rules/SbiZA4_3s1U
The benefit of inserting facts in a batch all at once, rather than one at a time, particularly when using accumulators.  I've seen a case where large numbers of facts that were all fed to the same accumulators were inserted one at a time, leading to significant performance penalties, and the problems with this approach aren't obvious IMO if one is not familiar with Clara's implementation.
The ability to use a custom fact-type-fn to gain constant-time dispatch on particular fields of a fact that are hotspots.

I'd like to make this knowledge more accessible in some way.  I'm currently leaning toward adding a "Performance Optimization" page under the Advanced Topics section in the right sidebar and linking to pages on these and other relevant topics from that page but I'm open to suggestions.

One tension I see here is how to make this information available without overwhelming users who don't have such performance concerns with information on it.    That is why I'm leaning toward adding a single page on performance that then links to further subpages for now, rather than a bunch of new entries under Advanced Topics.

A single page under advanced topics, with whatever structure makes sense underneath that, makes sense to me.


Use status-fg

Is there an existing issue outlining your improvement?

[X] I have searched the existing issues and my improvement has not been raised yet.

What would you like to see added and/or changed?
We currently set status-bg and use the [bg=default] but do not set status-fg which results in using [fg=$thm_fg].
when using [fg=default] users would be able to change the default it's however not perfect since the fg color is often something other then $thm_fg.

The status-{fg,bg} options are marked for deprecation by tmux, will not do


Secure Mode not producing correct user_hash, 403 error

Version info

intercom-rails version: 0.3.2
Rails version: 4.2.6

Expected behavior
# intercom.rb
IntercomRails.config do |config|
  config.app_id = ENV["INTERCOM_APP_ID"]
  config.api_secret = ENV["INTERCOM_API_SECRET"]
end

# application_controller.rb
skip_after_action :intercom_rails_auto_include

<%# In <head> tag %>
<%= intercom_script_tag({
  app_id: ENV["INTERCOM_APP_ID"],
  user_id: current_user.id,
}, {
  secret: ENV["INTERCOM_API_SECRET"]
}) %>

I expect Intercom to register the call.
Actual behavior
403 error from Intercom: {error_message: "incorrect user_hash"}
I can see when I look at the page source that user_hash is calculated and set to something, but I'm getting a 403 because the value isn't correct.
Are there any more docs on Secure Mode? All I can find is https://docs.intercom.io/configure-intercom-for-your-product-or-site/staying-secure/enable-secure-mode-on-your-web-product, and the link to https://gist.github.com/thewheat/7342c76ade46e7322c3e isn't sufficient because it doesn't say how to configure the user_hash with the gem. It looks like I shouldn't have to worry about setting user_hash if I'm using this gem because it's supposed to correctly set user_hash for me.
Thanks for your help.

I noticed the user_hash is present on the source code of the page, in the JS variable window.intercomSettings:
window.intercomSettings = {"email":"<email>","name":"<name>","created_at":1395681256,"user_id":1234,"user_hash":"user_hash_value","app_id":"my_app_id"};

If I re-calculate what the user_hash should be based on your documents (using the Ruby method), like this:
OpenSSL::HMAC.hexdigest('sha256', "my_secret", 1234.to_s)

The user_hash value produced by my IRB shell doesn't match the user_hash value present in the JavaScript this gem outputs.

Nevermind, problem on my side, sorry!

@aguynamedben im having the same problem, what did you do to fix it?

api_secret and secure_mode_secret are different.
You shouldn't try to use api_secret to encrypt the user_hash
Make sure you use the right one to encrypt your user_hash

My problem was me misunderstanding my dev environment (I use the dotenv gem and had incorrectly setup the env variable in .env and .env.development)


Cannot use Zeplin links with seid parameter

Good day!
I was trying out this plugin today and ran into an issue. All the examples use a coid param in zeplin URLs but Zeplin now seems to use an seid param instead.
parameters: {
    zeplinLink: 'https://app.zeplin.io/project/PROJECT_ID/styleguide/components?seid=COMPONENT_ID'
},

The Zeplin tab in storybook shows me the following message:
Zeplin link is invalid.

You are currently logged in as USERNAME. If you prefer using another account, you can log out first.

has anyone else run into this?

seid refers to a component section. Make sure to get a component link by selecting the component.


Deprecate sys

When requiring temp under current versions of node (0.6.0), you get a deprecation warning:
> require('temp')
The "sys" module is now called "util". It should have a similar interface.

This pull request renames sys to util, removes it from temp.js where it wasn't used, reformats package.json, and makes some tweaks to the README.

Great work, thanks.  I'll have a new version published to npm shortly.


Query parameter values containing a Plus (+) sign are encoded incorrectly on PowerShell V5.

Consider the following schema:
swagger: '2.0'
info:
  version: '1'
  title: Reproducer
paths:
  /api:
    get:
      operationId: SomeOperation
      parameters:
        - name: $filter
          in: query
          type: string
      responses:
        '200':
          description: OK

autorest.powershell will generate CmdLets that allow us specifying the Filter parameter.
Problem
When specifying a value of + to the CmdLet's Filter parameter, then the Request URL generated by autorest.powershell looks as follows:
https://example.com/api?$filter='+'
Note the +, which will be interpreted by the host as space character, so the host receives a space instead a plus character, which is wrong. The correct URL would look as follows:
https://example.com/api?$filter='%2B'
Analysis
In my test settings the problem only appeared on PowerShell versions before 6. I.e. in PowerShell 5 as installed with Windows 11 the problem appears, while it doesn't appear on a separately installed PowerShell version 7.
The root cause seems to be the way, how Systsem.Uri handles the plus character in older versions of .NET Framework. autorest.powershell seems to encode everything correctly and in the example generate a URI string of https://example.com/api?$filter='%2B', which is then passed to System.Uri. The latter converts the %2B to + on PowerShell 5.
A sample Console application shows the problematic behavior when built for .NET Framework 4.0, but not when built for .NET Framework 4.5 or later.
Running ([System.Uri]::New("https://example.com/api?$filter='%2B'")).ToString() on PowerShell 5 on Windows 11 issues
https://example.com/api?='+', therefore showing the problem.

Though ToString() in .NET Framework 4 un-escape %2B back to +, the uri it actually uses is correct. Following is the package I capture with Fildder 4.

And I think the uri in use is $uri.AbsoluteUri instead of $uri.ToString()

Here  is the official docs for Uri. And as it says, %2B is not in the list it will decode when constructing the uri.


Configure Monitoring Dynatrace fails on minikube and minishift

After installing keptn 0.6.1 and trying to configure monitoring for dynatrace, the following error comes in the dynatrace-service log.
{"timestamp":"2020-04-07T19:59:40.856309878Z","logLevel":"DEBUG","message":"Received event: sh.keptn.event.monitoring.configure"}
{"timestamp":"2020-04-07T19:59:40.947887455Z","logLevel":"INFO","message":"Configuring Dynatrace monitoring"}
{"timestamp":"2020-04-07T19:59:40.960072395Z","logLevel":"ERROR","message":"Could not create Dynatrace Helper: invalid or no Dynatrace credentials found"}
2020/04/07 19:59:40 http: panic serving <IP_ADDRESS>:39994: runtime error: invalid memory address or nil pointer dereference
goroutine 19 [running]:
net/http.(*conn).serve.func1(0xc0005d2000)
/usr/local/go/src/net/http/server.go:1769 +0x139
panic(0x15e9920, 0x27a9e10)
/usr/local/go/src/runtime/panic.go:522 +0x1b5
github.com/keptn-contrib/dynatrace-service/pkg/event_handler.ConfigureMonitoringEventHandler.configureMonitoring(0x1a297c0, 0xc00041c040, 0x1a7aa80, 0xc0006f44e0, 0x1535aa0, 0xc000233960, 0x1, 0x0, 0x1, 0xc0005aa160, ...)
/go/src/github.com/keptn/dynatrace-service/pkg/event_handler/configure_monitoring.go:90 +0x14d
github.com/keptn-contrib/dynatrace-service/pkg/event_handler.ConfigureMonitoringEventHandler.HandleEvent(0x1a297c0, 0xc00041c040, 0x1a7aa80, 0xc0006f44e0, 0x1535aa0, 0xc000233960, 0x1, 0x0, 0x1, 0xc0005aa160, ...)
/go/src/github.com/keptn/dynatrace-service/pkg/event_handler/configure_monitoring.go:64 +0x1a1
main.gotEvent(0x1a3ad00, 0xc0005c5980, 0x1a7aa80, 0xc0006f44e0, 0x1535aa0, 0xc000233960, 0x1, 0x0, 0x0)
/go/src/github.com/keptn/dynatrace-service/cmd/main.go:67 +0x188
reflect.Value.call(0x15a8140, 0x1872f80, 0x13, 0x17c6129, 0x4, 0xc0005c5a40, 0x2, 0x2, 0xc0006c32b0, 0xc0005c5a70, ...)
/usr/local/go/src/reflect/value.go:447 +0x461
reflect.Value.Call(0x15a8140, 0x1872f80, 0x13, 0xc0005c5a40, 0x2, 0x2, 0xc0005c5980, 0xc0006c3240, 0x1)
/usr/local/go/src/reflect/value.go:308 +0xa4
github.com/cloudevents/sdk-go/pkg/cloudevents/client.(*receiverFn).invoke(0xc0005c4ea0, 0x1a3ad00, 0xc0005c5980, 0x1a7aa80, 0xc0006f44e0, 0x1535aa0, 0xc000233960, 0x1, 0xc0005c5860, 0x1a3ad00, ...)
/go/pkg/mod/github.com/cloudevents/sdk-go@v0.0.0-20190509003705-56931988abe3/pkg/cloudevents/client/receiver.go:87 +0x224
github.com/cloudevents/sdk-go/pkg/cloudevents/client.(*ceClient).obsReceive(0xc000478300, 0x1a3ad00, 0xc0005c58c0, 0x1a7aa80, 0xc0006f44e0, 0x1535aa0, 0xc000233960, 0x1, 0xc0005c5860, 0xc0006c3498, ...)
/go/pkg/mod/github.com/cloudevents/sdk-go@v0.0.0-20190509003705-56931988abe3/pkg/cloudevents/client/client.go:129 +0xef
github.com/cloudevents/sdk-go/pkg/cloudevents/client.(*ceClient).Receive(0xc000478300, 0x1a3ad00, 0xc0005c57a0, 0x1a7aa80, 0xc0006f44e0, 0x1535aa0, 0xc000233960, 0x1, 0xc0005c5860, 0xc00025c928, ...)
/go/pkg/mod/github.com/cloudevents/sdk-go@v0.0.0-20190509003705-56931988abe3/pkg/cloudevents/client/client.go:117 +0xc7
github.com/cloudevents/sdk-go/pkg/cloudevents/transport/http.(*Transport).obsInvokeReceiver(0xc0005798c0, 0x1a3ad00, 0xc0005c57a0, 0x1a7aa80, 0xc0006f44e0, 0x1535aa0, 0xc000233960, 0x1, 0x1, 0xc0005c5770, ...)
/go/pkg/mod/github.com/cloudevents/sdk-go@v0.0.0-20190509003705-56931988abe3/pkg/cloudevents/transport/http/transport.go:335 +0x10c
github.com/cloudevents/sdk-go/pkg/cloudevents/transport/http.(*Transport).invokeReceiver(0xc0005798c0, 0x1a3ad00, 0xc0005c5770, 0x1a7aa80, 0xc0006f44e0, 0x1535aa0, 0xc000233960, 0x1, 0x3, 0xc000048070, ...)
/go/pkg/mod/github.com/cloudevents/sdk-go@v0.0.0-20190509003705-56931988abe3/pkg/cloudevents/transport/http/transport.go:319 +0xc5
github.com/cloudevents/sdk-go/pkg/cloudevents/transport/http.(*Transport).ServeHTTP(0xc0005798c0, 0x1a36300, 0xc0005ec000, 0xc0005e8000)
/go/pkg/mod/github.com/cloudevents/sdk-go@v0.0.0-20190509003705-56931988abe3/pkg/cloudevents/transport/http/transport.go:419 +0xab6
net/http.(*ServeMux).ServeHTTP(0xc000478340, 0x1a36300, 0xc0005ec000, 0xc0005e8000)
/usr/local/go/src/net/http/server.go:2375 +0x1d6
net/http.serverHandler.ServeHTTP(0xc0006f4340, 0x1a36300, 0xc0005ec000, 0xc0005e8000)
/usr/local/go/src/net/http/server.go:2774 +0xa8
net/http.(*conn).serve(0xc0005d2000, 0x1a3ac40, 0xc00022e200)
/usr/local/go/src/net/http/server.go:1878 +0x851
created by net/http.(*Server).Serve
/usr/local/go/src/net/http/server.go:2884 +0x2f4

Did some research on this yesterday with Chris. Turned out the problem was related to a typo in the DT_PAAS_TOKEN variable that was stored in the dynatrace secret.
It would be easier to troubleshoot if the error message would indicate this. Right now the message says "no or invalid configuration". if it would say "Couldnt find required configuration DT_PAAS_TOKEN in dynatrace secret" it would be easier to troubleshoot

Thanks for the report. I've moved the issue towards the dynatrace-service, as that's where the issue belongs to: https://github.com/keptn-contrib/dynatrace-service/issues/126
I'll close this issue here.


We cant afford any contract.

I get this error even though i set the wallet to a high amount. Can anybody help?

File "C:\Users\Miner_cunt\projects\TradzQAI\TradzQAI\core\environnement\base\wallet.py", line 199, in manage_exposure
raise ValueError('current_max_pos : {:.3f} We cant afford any contract. Please check wallet settings.'.format(self.risk_managment['current_max_pos']))
ValueError: current_max_pos : 0.000 We cant afford any contract. Please check wallet settings.

Thanks

Can you show your config/environnement.json ?

here it what it looks like. Thanks for your help!
{     "base": {         "data_directory": "data/",         "episodes": 5,         "targeted_return": 2     },     "contract": {         "allow_short": false,         "contract_price": 0,         "contract_size": 1,         "contract_type": "classic",         "pip_value": 1,         "spread": 0.1     },     "reward": {         "no_negative": true,         "period": 0,         "type": "pnl"     },     "risk_managment": {         "exposure": 10,         "max_pos": 10,         "stop_loss": 20     },     "states": {         "preprocessing": "sigmoid",         "window": 20     },     "wallet": {         "capital": 200,         "fee": 0.5     } }

Do you use crypto datasets ? What's the price ?


Update to using latest flytepropeller v0.5.13

TL;DR
Update to using latest flytepropeller v0.5.13
Type

[ ] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[ ] Code completed
[ ] Smoke tested
[ ] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/lyft/flyte/issues/
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/

Codecov Report

Merging #148 (2b511ad) into master (5274cbf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   61.79%   61.79%
=======================================
  Files         105      105
  Lines        7534     7534
=======================================
  Hits         4656     4656
  Misses       2286     2286
  Partials      592      592

Flag
Coverage Δ

unittests
61.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5274cbf...2b511ad. Read the comment docs.

Codecov Report

Merging #148 (2b511ad) into master (5274cbf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   61.79%   61.79%
=======================================
  Files         105      105
  Lines        7534     7534
=======================================
  Hits         4656     4656
  Misses       2286     2286
  Partials      592      592

Flag
Coverage Δ

unittests
61.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5274cbf...2b511ad. Read the comment docs.


No LED?

Since there is no LED light on the shield, how do you know that the shield is up and running?

Hello @bhargavah, once you connect the supply voltage to Vbat the shield is "up", but in order to make it "running" you need to connect it to a microcontroller board. Since the shield does not have an onboard MCU, there is no status LED.


Feature request as issue. --- discussion on templates

I'm submitting a feature request.
What feature do you recommend to add?

New design/functionality or modification of existing feature

What is the value of this feature?

How it will improve the current view/behaviour

What are the approx. steps to create this feature?

[ ] Step 1
[ ] Step 2
[ ] Step 3

Link to Trello card

Sounds great Qing, feel free to modify the issue as per what you mentioned. 👍🏻

The issue templates have been approved and merged, so this issue has been resolved.
Feel free to re-open this issue if resume discussions.


getChatHistory returns messages in wrong order

The getChatHistory method gets messages in different order compared to official Telegram clients. Messages close to each other in time often end up at positions slightly different from actual order.

The order of server messages is the same in all clients for a chosen users, because it is controlled server-side. In basic group and private chats message order can be different for different users, in supergroups/channels message order is always the same for all chat members.

Thanks for the explanation. That makes sense.


[proxima-ingest-client] upgrade gRPC, small ingest client polishing

Failures are unrelated, related to flaky tests in general. Will be fixed separately.


Flaky test in crypto package: TestDSA

Every so often the TestDSA test fails
?	github.com/hkparker/go-i2p	[no test files]
ok      github.com/hkparker/go-i2p/lib/common   0.007s  coverage: 77.8% of statements
?       github.com/hkparker/go-i2p/lib/common/base32    [no test files]
?       github.com/hkparker/go-i2p/lib/common/base64    [no test files]
?       github.com/hkparker/go-i2p/lib/config   [no test files]
--- FAIL: TestDSA (0.00s)
        dsa_test.go:32: sig="R\x06D\x97\x0fu#\xd1Ҧ\xf3\x11G\x0e\x0e^\xde\ue445\x91\xaf+7\u007f\xbf\xaeC\x1eͩ\x9ctsS\x90\x9b\x0fY\x00"
        dsa_test.go:43: failed: invalid signature
FAIL
coverage: 55.0% of statements
FAIL    github.com/hkparker/go-i2p/lib/crypto   0.065s
?       github.com/hkparker/go-i2p/lib/i2np     [no test files]
?       github.com/hkparker/go-i2p/lib/netdb    [no test files]
?       github.com/hkparker/go-i2p/lib/router   [no test files]
?       github.com/hkparker/go-i2p/lib/transport        [no test files]
?       github.com/hkparker/go-i2p/lib/transport/ssu    [no test files]
?       github.com/hkparker/go-i2p/lib/tunnel   [no test files]

@majestrate Have you ever seen this happen?

I forget if the DSA code checks for q < p (or whatever that constraint for dsa is), that is possibly it.

found it, the problem was that big.Int is encoded as bytes differently than i thought, sometimes r or s is < 20 bytes long so they'd have to be encoded differently.

I think i see a similar problem in elg too

merged #13, thanks for taking a look


Pages are loading absurdly slow.

What versions are you running?
$ go list -m github.com/chromedp/chromedp
github.com/chromedp/chromedp v0.8.7
$ google-chrome --version
Google Chrome 108.0.5359.98
$ go version
go version go1.19.3 linux/amd64

What did you do? Include clear steps.
Okay, buckle up.
func EventListener(ctx context.Context) {
	return func(event interface{}) {
		switch ev := event.(type) {
		case *fetch.EventRequestPaused:
			go func() {
				c := chromedp.FromContext(ctx)
				ctx := cdp.WithExecutor(ctx, c.Target)

				if ev.ResourceType == network.ResourceTypeImage ||
					ev.ResourceType == network.ResourceTypeStylesheet ||
					ev.ResourceType == network.ResourceTypeFont ||
					ev.ResourceType == network.ResourceTypeMedia ||
					ev.ResourceType == network.ResourceTypeManifest ||
					ev.ResourceType == network.ResourceTypeDocument {
					err := fetch.FailRequest(ev.RequestID, network.ErrorReasonBlockedByClient).Do(ctx)
				} else {
					err := fetch.ContinueRequest(ev.RequestID).Do(ctx)
				}
			}()
		// omitted
			}
		}
	}
}

I have found and improved an event listener like this. Its purpose is to nuke every bloat, including css, font, and media, to oblivion and bringing me HTML and JS to click on.
Yet it is still slow.
This is my run loop:
var response = new(string)
opts := append(chromedp.DefaultExecAllocatorOptions[:],
		chromedp.DisableGPU,
		chromedp.NoDefaultBrowserCheck,
		chromedp.NoFirstRun,
		chromedp.Headless,
		chromedp.NoSandbox,
	)
allocCtx, _ := chromedp.NewExecAllocator(context.Background(), opts...)
browserCTX, cancel := chromedp.NewContext(allocCtx)
chromedp.ListenTarget(browserCTX, EventListener(browserCTX))
			err := chromedp.Run(browserCTX,
				network.Enable(),
				chromedp.Navigate(tempURL),
				chromedp.WaitVisible(`#REVIEWS`, chromedp.ByID),
				chromedp.Click(`//*[contains(concat( " ", @class, " " ), concat( " ", "ulBlueLinks", " " ))]`, chromedp.BySearch),
				chromedp.OuterHTML(`#REVIEWS`, response, chromedp.ByID),
			)

You can test the function with: https://www.tripadvisor.com.tr/Restaurant_Review-g293974-d5571065-Reviews-Can_Ciger-Istanbul.html#REVIEWS?filterLang=ALL
It takes 6.084620997s to load 2 pages.  It takes 9ms to query and get everything I need from HTML, from 2 pages. ChromeDP is slowing everything down a lot for me, please help.
Rest of the code is related to the codebase of my current work, but please hit me if you need more details.
What did you expect to see?
vroooooom
What did you see instead?
slow vroooooom

dunno if it is related but, I will just send it.

Please provide a executable demo, thanks!
I would recommend you to enable the debug log (browserCTX, cancel := chromedp.NewContext(allocCtx, chromedp.WithDebugf(log.Printf))), and try to read the log to understand what consumes the time.

Please provide a executable demo, thanks!
I would recommend you to enable the debug log (browserCTX, cancel := chromedp.NewContext(allocCtx, chromedp.WithDebugf(log.Printf))), and try to read the log to understand what consumes the time.

Printf clutters the whole terminal how can I log this to file?

Please provide a executable demo, thanks!
I would recommend you to enable the debug log (browserCTX, cancel := chromedp.NewContext(allocCtx, chromedp.WithDebugf(log.Printf))), and try to read the log to understand what consumes the time.

Printf clutters the whole terminal how can I log this to file?

Redirect the output to a file. On Linux: go run main.go &> log.txt.

The page just loads too many *.js files and takes very long to load:

I think you can see the same behavior with a new browser instance like this:
google-chrome --user-data-dir=/tmp/chromedpdata --no-first-run

I need this JS for clicking on Devamı button on reviews, so I cant block them, unfortunately.
Time:  5.2483218879999995 s, when I run the main.go in zip.
riseandshine.zip

See my comment above. The page just takes too long to load. Do you have any idea about what chromedp could do to improve it?

yea you are right. sorry if I acted like dick.


[AUTOPATCHER] Patches CVE-2021-21309 for redis

        Patches CVE-2021-21309 for redis.
        This patch and PR was automatically generated and needs human verification before merging.

Closing since we already nopatched this issue.


regsync fails to sync from dockerhub to ECR

Current Behavior
I get the following error
time="2023-05-18T17:26:41Z" level=info msg="Copy config" digest="sha256:5e2b554c1c45d22c9d1aa836828828e320a26011b76c08631ac896cbc3625e3e" source="alpine:latest" target="xxxxxxx.dkr.ecr.us-west-2.amazonaws.com/cnx/public-images/alpine:latest"
time="2023-05-18T17:26:41Z" level=warning msg="Failed to push blob" err="failed to send blob post, ref xxxxxxx.dkr.ecr.us-west-2.amazonaws.com/cnx/public-images/alpine@sha256:c0669ef34cdc14332c0f1ab0c2c01acb91d96014b172f1a76f3a39e63d1f0bda: not found" src="alpine:latest" tgt="xxxxxxx.dkr.ecr.us-west-2.amazonaws.com/cnx/public-images/alpine:latest"
time="2023-05-18T17:26:41Z" level=warning msg="Failed to copy config" digest="sha256:5e2b554c1c45d22c9d1aa836828828e320a26011b76c08631ac896cbc3625e3e" err="failed to send blob post, ref xxxxxxx.dkr.ecr.us-west-2.amazonaws.com/cnx/public-images/alpine@sha256:c0669ef34cdc14332c0f1ab0c2c01acb91d96014b172f1a76f3a39e63d1f0bda: not found" source="alpine:latest" target="xxxxxxx.dkr.ecr.us-west-2.amazonaws.com/cnx/public-images/alpine:latest"
time="2023-05-18T17:26:41Z" level=error msg="Failed to copy image" error="failed to send blob post, ref xxxxxxx.dkr.ecr.us-west-2.amazonaws.com/cnx/public-images/alpine@sha256:c0669ef34cdc14332c0f1ab0c2c01acb91d96014b172f1a76f3a39e63d1f0bda: not found" source="docker.io/library/alpine:latest" target="xxxxxxx.dkr.ecr.us-west-2.amazonaws.com/cnx/public-images/alpine:latest"
time="2023-05-18T17:26:41Z" level=error msg="Failed to sync" error="failed to send blob post, ref xxxxxxx.dkr.ecr.us-west-2.amazonaws.com/cnx/public-images/alpine@sha256:c0669ef34cdc14332c0f1ab0c2c01acb91d96014b172f1a76f3a39e63d1f0bda: not found" source="docker.io/library/alpine:latest" target="xxxxxxx.dkr.ecr.us-west-2.amazonaws.com/cnx/public-images/alpine:latest"
time="2023-05-18T17:26:44Z" level=info msg="Copy config" digest="sha256:8471affe5de5c05c938d681f28e9b9139df00fd479da775caf217886b12bfa61" source="alpine:3.16" target="xxxxx.dkr.ecr.us-west-2.amazonaws.com/cnx/public-images/alpine:3.16"
time="2023-05-18T17:26:44Z" level=warning msg="Failed to push blob" err="failed to send blob post, ref xxxxx.dkr.ecr.us-west-2.amazonaws.com/cnx/public-images/alpine@sha256:e28792ec7904bff56f22df296d78cc1188caf347bd824570d0ecf235e4f6e4cd: not found" src="alpine:3.16" tgt="xxxxx.dkr.ecr.us-west-2.amazonaws.com/cnx/public-images/alpine:3.16"
time="2023-05-18T17:26:44Z" level=warning msg="Failed to copy config" digest="sha256:8471affe5de5c05c938d681f28e9b9139df00fd479da775caf217886b12bfa61" err="failed to send blob post, ref xxxxx.dkr.ecr.us-west-2.amazonaws.com/cnx/public-images/alpine@sha256:e28792ec7904bff56f22df296d78cc1188caf347bd824570d0ecf235e4f6e4cd: not found" source="alpine:3.16" target="xxxxx.dkr.ecr.us-west-2.amazonaws.com/cnx/public-images/alpine:3.16"
time="2023-05-18T17:26:44Z" level=error msg="Failed to copy image" error="failed to send blob post, ref xxxxx.dkr.ecr.us-west-2.amazonaws.com/cnx/public-images/alpine@sha256:e28792ec7904bff56f22df296d78cc1188caf347bd824570d0ecf235e4f6e4cd: not found" source="docker.io/library/alpine:3.16" target="xxxxx.dkr.ecr.us-west-2.amazonaws.com/cnx/public-images/alpine:3.16"
time="2023-05-18T17:26:44Z" level=error msg="Failed to sync" error="failed to send blob post, ref xxxxx.dkr.ecr.us-west-2.amazonaws.com/cnx/public-images/alpine@sha256:e28792ec7904bff56f22df296d78cc1188caf347bd824570d0ecf235e4f6e4cd: not found" source="docker.io/library/alpine:3.16" target="xxxxx.dkr.ecr.us-west-2.amazonaws.com/cnx/public-images/alpine:3.16"

Expected Behavior
Should sync alpine:latest from dockerhub to ECR
Steps To Reproduce
I have the following config. Since it is a private repo I removed the AWS account id from url.
version: 1
defaults:
  ratelimit:
    min: 100
    retry: 15m
  parallel: 5
sync:
  - source: alpine:3.16
    target: xxxxxxx.dkr.ecr.us-west-2.amazonaws.com/public-images/alpine:3.16
    type: image
  - source: alpine:latest
    target: xxxxxxx.dkr.ecr.us-west-2.amazonaws.com/public-images/alpine:latest
    type: image

Run the following command
docker container run \
        -i \
        --rm \
        --net host \
        -v "$(pwd)/regsync.yml:/home/appuser/regsync.yml" \
        ghcr.io/regclient/regsync:latest -c /home/appuser/regsync.yml once

Version
regsync docker latest
Environment

How you are running the tool: downloaded binary or from within a container
Running as binary or container: Yes
Host platform: MacOS
Registry description: Docker Hub, ECR

Hi @noorul, my first guess is a lack of credentials. Here's an example where it's working for me:
version: 1
creds:
  - registry: public.ecr.aws
    credHelper: "docker-credential-ecr-login"
  - registry: localhost:5000
    tls: disabled
sync:
...

and then to use that helper, make sure to mount the aws credentials:
docker container run -i --rm --net host \
  -v "$(pwd)/regsync.yml:/home/appuser/regsync.yml:ro" \
  -v "${HOME}/.aws:/home/appuser/.aws:ro" \
  regclient/regsync:alpine regsync -c /home/appuser/regsync.yml -v info once

If that doesn't help, change the logging from info to debug and post the redacted output (I don't need your username, hostname, or repo value).

With respect to credentials, I perform ecr login before I run the docker command.

Do I have to mount $HOME/.docker/config.json ?

If you run the login first, then -v ${HOME}/.docker/config.json:/home/appuser/.docker/config.json:ro would work and you don't need the alpine image (that includes the helpers) or aws directory. But that assumes the credentials are added directly to the config.json and not using another credential helper. Docker desktop installs typically default to a helper that I don't have access to from inside the container, but would work if run from the binary directly.

Mounting the credentials worked! Thanks @sudo-bmitch!


[stable/prometheus-operator] Fix typo

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/retest

/retest
/lgtm

/lgtm

/retest

/retest

/lgtm

/retest

/retest

/retest


[FLINK-36979][rpc] Reverting pekko version bump in Flink 1.20

This reverts commit 4776c9679fbefc85ad85446d51df2c366b9ee835.
What is the purpose of the change
Reverts the pekko version bump that includes an upgrade to netty 4.x. Corresponding discussion happened in FLINK-36510.
Brief change log

Plain revert

Verifying this change

no additional verification done aside from CI

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): yes
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

I checked the changes in Pekko, which will not cause the OOM I think, but when running on Java 11+, JVM may need
-Dio.netty.tryReflectionSetAccessible=true to help Netty.
Another way to help is to run with -Dio.netty.leakDetection.level=PARANOID to see why and where it leaks or gets a heap dump.
I ran the leak detector on the pekko side and found nothing.

@ferenc-csaky @XComp Hi, I think I can confirm that there's not a leak on the Pekko side.

So I suggest:
rerun the tests with -Dio.netty.tryReflectionSetAccessible=true and -Dio.netty.leakDetection.level=PARANOID to see why and where it leaks or gets a heap dump.
We have some applications, not a flink application still needs this -Dio.netty.tryReflectionSetAccessible=true to avoid OOM in production.
or , you could set the Netty's bytebuf allocator with unpooled by default.
with -Dio.netty.allocator.type=unpooled


Bump simulator versions on TravisCI to 10.3

I'm not sure that this is what's causing swift test --parallel to fail, but 🤞

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@050244a). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #436   +/-   ##
=========================================
  Coverage          ?   60.53%
=========================================
  Files             ?       51
  Lines             ?     4614
  Branches          ?        0
=========================================
  Hits              ?     2793
  Misses            ?     1821
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 050244a...a697018. Read the comment docs.


SB-13521 feat: update schema - questionCategories and unitIdentifiers

…dentifiers

Codecov Report

Merging #573 into release-2.3.0 will decrease coverage by 0.01%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##             release-2.3.0     #573      +/-   ##
===================================================
- Coverage            32.52%   32.51%   -0.02%
  Complexity            1220     1220
===================================================
  Files                  169      169
  Lines                14935    14935
  Branches              2364     2364
===================================================
- Hits                  4858     4856       -2
- Misses                9357     9359       +2
  Partials               720      720

Impacted Files
Coverage Δ
Complexity Δ

...p/searchindex/elasticsearch/ElasticSearchUtil.java
47.94% <0%> (-0.55%)
52% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dabf7b...22c1a14. Read the comment docs.