Maximum call stack size exceeded

It looks like there is an infinite loop in one of the possible scenarios:
ServerClient.destroy() => custom unsubscribe() => log.add => send => 'WS was closed' => LoguxServer.debugError => send => 'WS was closed' => debugError => send => ...
Facts that we can observe:

Tons of this in logs before the "Maximum call stack size exceeded" error

[error][logux] {
  err: {
    message: 'WS was closed',
    name: 'Error',
    stack: 'Error: WS was closed\n' +
      '    at ServerConnection.send (file:///Users/me/src/node_modules/@logux/core/ws-connection/index.js:72:34)\n' +
      '    at LoguxServerWithQueues.debugError (file:///Users/me/src/node_modules/@logux/server/base-server/index.js:525:24)\n' +
      '    at file:///Users/me/src/node_modules/@logux/server/base-server/index.js:270:44\n' +
      '    at file:///Users/me/src/node_modules/nanoevents/index.js:4:46\n' +
      '    at Array.forEach (<anonymous>)\n' +
      '    at Object.emit (file:///Users/me/src/node_modules/nanoevents/index.js:4:33)\n' +
      '    at file:///Users/me/src/node_modules/@logux/server/server-client/index.js:49:24\n' +
      '    at file:///Users/me/src/node_modules/nanoevents/index.js:4:46\n' +
      '    at Array.forEach (<anonymous>)\n' +
      '    at Object.emit (file:///Users/me/src/node_modules/nanoevents/index.js:4:33)\n' +
      '    at FilteredNode.error (file:///Users/me/src/node_modules/@logux/core/base-node/index.js:233:18)\n' +
      '    at file:///Users/me/src/node_modules/@logux/core/base-node/index.js:100:16\n' +
      '    at file:///Users/me/src/node_modules/nanoevents/index.js:4:46\n' +
      '    at Array.forEach (<anonymous>)\n' +
      '    at Object.emit (file:///Users/me/src/node_modules/nanoevents/index.js:4:33)\n' +
      '    at ServerConnection.send (file:///Users/me/src/node_modules/@logux/core/ws-connection/index.js:72:20)\n' +
      '    at LoguxServerWithQueues.debugError (file:///Users/me/src/node_modules/@logux/server/base-server/index.js:525:24)\n' +
      '    at file:///Users/me/src/node_modules/@logux/server/base-server/index.js:270:44\n' +
      '    at file:///Users/me/src/node_modules/nanoevents/index.js:4:46\n' +
      '    at Array.forEach (<anonymous>)\n' +
      '    at Object.emit (file:///Users/me/src/node_modules/nanoevents/index.js:4:33)\n' +
      '    at file:///Users/me/src/node_modules/@logux/server/server-client/index.js:49:24'
  },
  connectionId: '18'
} WS was closed

Followed by this:

[info][logux] { actionId: '1651273880706 server:-yGQOYF5 0', channel: 'menu/11' } Client was unsubscribed
[info][logux] { nodeId: '70:xbPqR9RG:S5VraEMz' } Client was disconnected
[fatal][logux] {
  err: {
    message: 'Maximum call stack size exceeded',
    name: 'RangeError',
    stack: 'RangeError: Maximum call stack size exceeded\n' +
      '    at formatRaw (node:internal/util/inspect:1037:12)\n' +
      '    at formatValue (node:internal/util/inspect:817:10)\n' +
      '    at inspect (node:internal/util/inspect:347:10)\n' +
      '    at formatWithOptionsInternal (node:internal/util/inspect:2167:40)\n' +
      '    at formatWithOptions (node:internal/util/inspect:2029:10)\n' +
      '    at console.value (node:internal/console/constructor:324:14)\n' +
      '    at console.log (node:internal/console/constructor:360:61)\n' +
      '    at Object.info (file:///Users/me/src/log.ts:20:36)\n' +
      '    at reporter (file:///Users/me/src/node_modules/@logux/server/create-reporter/index.js:245:27)\n' +
      '    at file:///Users/me/src/node_modules/nanoevents/index.js:4:46\n' +
      '    at Array.forEach (<anonymous>)\n' +
      '    at Object.emit (file:///Users/me/src/node_modules/nanoevents/index.js:4:33)\n' +
      '    at file:///Users/me/src/node_modules/@logux/server/base-server/index.js:176:20\n' +
      '    at file:///Users/me/src/node_modules/nanoevents/index.js:4:46\n' +
      '    at Array.forEach (<anonymous>)\n' +
      '    at Object.emit (file:///Users/me/src/node_modules/nanoevents/index.js:4:33)\n' +
      '    at actionEvents (file:///Users/me/src/node_modules/@logux/core/log/index.js:8:11)\n' +
      '    at Log.add (file:///Users/me/src/node_modules/@logux/core/log/index.js:96:7)\n' +
      '    at Object.unsubscribe (file:///Users/me/src/modules/appEditor.ts:349:18)\n' +
      '    at Object.subscribers.<computed>.<computed>.unsubscribe (file:///Users/me/src/node_modules/@logux/server/base-server/index.js:746:27)\n' +
      '    at LoguxServerWithQueues.performUnsubscribe (file:///Users/me/src/node_modules/@logux/server/base-server/index.js:790:22)\n' +
      '    at ServerClient.destroy (file:///Users/me/src/node_modules/@logux/server/server-client/index.js:92:20)'
  }
} Maximum call stack size exceeded
[info][logux] {} Shutting down Logux server

I've injected some code into WsConnection class and can say that
a. "WS was closed" is happening because this.ws.readyState === closing
b. there is no calls to ws.onerror or ws.onclose or this.disconnect before

As I understand it's a normal situation that WS connection can stuck in a closing state and that's why we need heartbeats. But I don't understand how to reproduce it. Can only say that it's happening regularly if I just leave my laptop for some (or close it)

Thanks for the issue with many details.
I will try to investigate today or tomorrow.

Hi. Sorry, I just found a time to review.
I found two strange things:

The non-standard log output
Non-Logux file src/log.ts in the stacktrace

What is Loguc Server options? What changes to the logger did you applied? Can you show src/log.ts content?


docker/release: Bump Ubuntu image -> adbb901

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/retest examples


Namespaces are not handled

I have translations that are namespaced, i.e.
const { t } = useTranslation(["shared", "thisFeature"]);
const errorTitle = t("shared:error.defaultTitle");
const pageTitle = t("thisFeature:title");

However i18n-unused does not account for these namespaces, and is showing me that:*

shared:error.defaultTitle is missing a translation (when running display-missed).
error.defaultTitle is unused (when running display-unused).

I found an ugly fix where display-unused ignores all files that were posted in display-missed, but I can't use that with remove-unused (unless I update the config json). Adding an option to natively support this would be nice :)

Hi, I see your point. I'll look docs about this option and make update at next week. Thx for interest.

I believe the same situation applies to key prefixes, such as:
const { t } = useTranslation("users", { keyPrefix: "index" })

Unfortunately, I have the same problem of missing namespace support. And as namespaces are so highly dynamic, I guess this problem can't be solved perfectly. My suggestion would be to introduce a setting to be more lax. So if a key is not found in any of the locale files, then it is reported as missed. At least this is a hint then that there is something wrong. How about a PR? ;-)

I'm always for new PR's to the repository =)

Hi, I see your point. I'll look docs about this option and make update at next week. Thx for interest.

Hi there! Did you ever have a chance to look into it?

@boredland I hope, that yeah. But without date, maybe this weekends.

Hi there! I'm also interested in that issue. Do we have any advancement?

any developments on this ? @mxmvshnvsk


fix(crash): don't navigate to issue if it's a release notification

Question
Response

Version?
v1.4.1

Devices tested?
iPhone 7

Bug fix?
yes

New feature?
no

Includes tests?
no

All Tests pass?
yes

Related ticket?
#667

Description
We now only try to navigate to the issue if the notification.subject.type was either a PullRequest or an Issue.
We still need it to be clickable to mark the notification as read.
Also made a release notification display the accurate icon (tag).
Closes #667.

Coverage decreased (-0.05%) to 39.848% when pulling 37d44fd544a0342acb3100a462a8393350efb34e on machour:667-fix-notification-release-crash into dd5665248114167cdc9c52657ca3e494d008f2b5 on gitpoint:master.


Excluding Top Level with no children

Hi, I was wondering how to exclude top level items, that do not have children, from having their links stripped? As an example, home and contact wouldn't have children normally.

@br-designer I've finally updated the plugin. Please check if your issue has been resolved now. Also, help me test the plugin for any bugs, if you're still using it.

@pixelagent Please see #4 for your request.


Update getting-started.md

opentelemetry-instrument --metrics_exporter none --traces_exporter console flask run to avoid error Requested component 'otlp_proto_grpc' not found in entry points for 'opentelemetry metrics exporter'

Thanks @beekeh -- this should actually also be resolved with https://github.com/open-telemetry/opentelemetry.io/pull/1434 -- although I think it's a little suspect that if you're not using metrics, you need to still specify something about the metrics exporter when using the agent. I'll file an upstream issue.
@chalin do you want to take this in now or await #1434?

do you want to take this in now or await #1434?

I'd wait on #1434.

I think we can actually close this now that #1434 is merged. It's not the exact same thing, but it addresses the issue.


Path to libtweedledum.{so,dylib} is hardcode into binary

Steps to reproduce

Build quilc with tweedledum support
Move libtweedledum.{so,dylib} to somewhere else (e.g. to ./quilc/) where it ought to be found by the load-lib process
Run quilc, see that library cannot be found at specific path (something like ./quilc/src/contrib/tweedledum/libtweedledum.{so,dylib}

The current Forest SDK for Linux (bare bones, downloaded from rigetti.com) also has this issue:
Unhandled SIMPLE-ERROR in thread #<SB-THREAD:THREAD "main thread" RUNNING
                                    {10006B85B3}>:
  Error opening shared object "/src/quilc/src/contrib/tweedledum/libtweedledum.so":
  /src/quilc/src/contrib/tweedledum/libtweedledum.so: cannot open shared object file: No such file or directory.

(Creating the path and symlinking libtweedledum.so is a workaround.)

Is it admissible to rely on the LD_LIBRARY_PATH environment variable during build and when running quilc?

@jmbr I expect that the folk who choose to install the barebones package are the type of folk who would not be averse to managing their LD_LIBRARY_PATH. As long as this does not affect users of the other distributions, I would be on board. We would of course have to explicity state this in documentation / READMEs where appropriate.


Server Side Include (SSI) / Java Script / Accessibility / Document.write

CDTS is running mainly on 2 servers.
Canada.ca doesn't support SSI
ssl-templates.services.gc.ca support some SSI Directives
SSI is used in 3 different ways:
1-) To choose the environment server
<!--#elif expr="$vrSrvr = canada" --> 		<script src="https://www.canada.ca/etc/designs/canada/cdts/gcweb/v4_0_32c/cdts/compiled/soyutils.js"></script>
2-) To allow a fall-back with static file when Javascript is disabled
<!--#if expr = "${HTTP_HOST} != localhost" --><!--#include virtual="/app/cls/WET/gcweb/v4_0_32c/cdts/static/refTop.html" --><!--#endif-->
3-) To allow the page to be accessible when Javascript is disabled (Skip to main content with tab key) and have a Canada.ca breadcrumb
<!--#if expr = "${HTTP_HOST} != localhost" --><!--#include virtual="/app/cls/WET/gcweb/v4_0_32c/cdts/static/top-en.html" --><!--#endif-->
Questions:
Do we still need Server Side Include (SSI) ?
Do we assume that JavaScript is always enabled ?
If yes, why are we using Canada.ca since it doesn't support SSI Directives ?
If not, should we continue to support Static files?

I think you should get rid of the SSI conditions in your sample files.
<!--#if expr = "${HTTP_HOST} != localhost" -->
Focus on using the local variant <script src="../compiled/soyutils.js">
The long debate of supporting no JavaScript has been going on for almost a decade now. I'll leave that up to your team to decide. If you choose to stay with the fallback files, I wouldn't put the sample files on any server (including Canada.ca and Github) that doesn't support SSI includes.
Having said that, a lot of the JS frameworks now are using noscript element with text stating that JS is need to view this page. CDTS is different, where the content is still there but the template is gone. I think that fails gracefully. But that's my opinion.

I also recommend to remove SSI code for 2 reasons:
1-) Applications could run on a server that doesn't implement SSI
2-) For security reason https://owasp.org/www-community/attacks/Server-Side_Includes_(SSI)_Injection
It means that we will have to hardcode the environment path in samples
Though, we still have to decide what happens when JS is deactivates. (Noscript)

Also we should remove document.write (DW) in the same time
https://github.com/wet-boew/cdts-sgdc/issues/136
https://stackoverflow.com/questions/802854/why-is-document-write-considered-a-bad-practice

SSI statements have been removed for v4.0.39 release.
For the document.write() issue, we are tracking that in #55 .

SSI statements have been removed for v4.0.39 release.
For the document.write() issue, we are tracking that in #55 .


LINK-1354 | Registration specific permissions

Description :sparkles:
Support adding registration specific permissions by entering email of the users
Support resending invitation email to view participant list
Add unit tests to registration schema and remove registration specific unit tests to improve test performance
PR for BE: https://github.com/City-of-Helsinki/linkedevents/pull/631
Closes
LINK-1354
Screenshots

Codecov Report

Merging #198 (ee6c77d) into develop (1e2602e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #198   +/-   ##
========================================
  Coverage    99.88%   99.88%
========================================
  Files          506      509    +3
  Lines         9452     9516   +64
  Branches      2073     2075    +2
========================================
+ Hits          9441     9505   +64
  Misses          11       11

Impacted Files
Coverage Δ

...registration/registrationForm/RegistrationForm.tsx
100.00% <ø> (ø)

...istrationUsersSection/RegistrationUsersSection.tsx
100.00% <100.00%> (ø)

...UsersSection/registrationUser/RegistrationUser.tsx
100.00% <100.00%> (ø)

src/domain/registration/utils.ts
100.00% <100.00%> (ø)

src/domain/registration/validation.ts
100.00% <100.00%> (ø)

...gistrationUser/hooks/useRegistrationUserActions.ts
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Node upgrade causes the main network v0 to be unusable

PR：https://github.com/godwokenrises/light-godwoken/pull/292

https://github.com/godwokenrises/light-godwoken/pull/301


Fix permission denied while creating a directory

Use-case:
Alluxio superuser:
./bin/alluxio fs mkdir /tmp/
./bin/alluxio fs chown userA:userA /tmp/

UserA:
mkdir ./tmp
./integration/fuse/bin/alluxio-fuse mount ./tmp /tmp
mkdir ./tmp/d1
mkdir: ./tmp/d1: Permission denied

master.log
WARN  FileSystemMasterClientServiceHandler - Exit (Error): SetAttribute: request=path: "/tmp/d1"
options {
  owner: "UserA"
  group: "UserA"
  commonOptions {
    syncIntervalMs: -1
  }
}
, Error=alluxio.exception.AccessControlException: Permission denied: UserA is not a super user or in super group

@alluxio-bot, check this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/9669/
Test FAILed.

@buom thanks for the contribution! Can you sign the CLA ?
@LuQQiu can you help review this PR as you may know more on this part

@apc999 already [in pending status ]

Jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/9677/
Test PASSed.

Jenkins, test this please

Got the issue and this patch make the logic on par with createInternal. Thanks for the fix!

@LuQQiu  can you double check if this change is correct.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/9678/
Test PASSed.

alluxio-bot, merge this please

alluxio-bot, cherry-pick this to branch-2.2 please


Slow for SBOMs with a large number of files + relationships

This check iterates over the list existing_relationships up to 2 times: https://github.com/spdx/tools-python/blob/8050fd9c41a92c75ec2ba9eb10ed9a919c375fa9/src/spdx_tools/spdx/parser/jsonlikedict/relationship_parser.py#L162-L172
And it's called for every file: https://github.com/spdx/tools-python/blob/8050fd9c41a92c75ec2ba9eb10ed9a919c375fa9/src/spdx_tools/spdx/parser/jsonlikedict/relationship_parser.py#L144-L157
So if F is the number of files and R is the number of relationships, we are doing O(F * R) comparisons of relationships (which seem not cheap individually).
And given that this seems to expect to find a relationship for every file, we know that R is >= F, so this is at least O(F^2).
Looks quadratic to me.
With the caveat that I'm not a python expert, this being a list seems to be the issue: https://github.com/spdx/tools-python/blob/8050fd9c41a92c75ec2ba9eb10ed9a919c375fa9/src/spdx_tools/spdx/parser/jsonlikedict/relationship_parser.py#L55-L57
Is it possible to turn that into a set so these membership tests are O(1) instead of O(N)?

As an example:
$ curl -L https://packages.wolfi.dev/os/aarch64/renovate-37.151.0-r0.apk | tar -Oxz var/lib/db/sbom/renovate-37.151.0-r0.spdx.json > sbom.spdx.json

$ wc -c sbom.spdx.json
 36350622 sbom.spdx.json

$ cat sbom.spdx.json | jq '.files[]' -c | wc -l
   30193

$ cat sbom.spdx.json | jq '.relationships[]' -c | wc -l
   30193

# 30193 * 30193 = 911617249, which is a pretty big number for python

$ time ntia-checker -v --file sbom.spdx.json

Is this SBOM NTIA minimum element conformant? True

Individual elements                            | Status
-------------------------------------------------------
All component names provided?                  | True
All component versions provided?               | True
All component identifiers provided?            | True
All component suppliers provided?              | True
SBOM author name provided?                     | True
SBOM creation timestamp provided?              | True
Dependency relationships provided?             | True

No components with missing information.

real	8m57.222s
user	8m57.118s
sys	0m0.085s


Fix many typos in documentation

How did you find these? Did you use some tool?

How did you find these? Did you use some tool?

I use proofreading extension in vscode, then skim from top to bottom.

Thanks!


refactor: Policy Fetch-Data command returns only teams that the user is a member of

This change improves the structure of the data available for authoring new policies.
Now, the user's teams are included in the payload of the github.actor, instead of previously all teams and members of the org.
{
  "github": {
    "actor": {
      "username": "abcdefg",
      "teams": ["team1", "team2"]
    }
  }
}

To make this possible, instead of a single big query, GetTeamMemberships was refactored into GetUserTeamMemberships, invoked once per user.

I am confused by this, we return a list of teams the actor belongs to and all their members? I thought we would just list the teams the user belongs to, what is the use case to know all the members of that team?

Ready for review 🙏
Note: The scope of this PR has changed completely.


Cannot queue message for delivery, no supported transport

I know I have asked same questions on the chat room. But I still can't get it to work.
Now, I post the issue here and hope I could get some helps.
My purpose was to interconnect bifold to aca-py mediator and connect to other invites of other aca-py.
So I'll have the following:

Bifold agent
An aca-py Mediator
A Demo aca-py agent

So on startup the bifold can make successful connection to the Mediator.
Then bifold has to connect to other invites of Demo. The connection is also made successful.
However, when the Demo tried to issue credential, the state is only changed to 'offer_sent' and the error message came up as Cannot queue message for delivery, no supported transport.
I have been told to enable --enable-undelivered-queue on the Mediator. But there was nothing changed after enabling the option. The same error persisted.
I tried this option on the Demo too and I got the same issue. So I feel like it's not necessary to enable the option on the Mediator.

Any help is appreciated. Thank you

Hi @swcurran
how to resolve above issue ? we are facing same issue. some time messages are not getting delivered.
Thank you!
Regards
Sherali

It resolved our problem, after we restart mediator service with option --enable-undelivered-queue

@chheunpheara Where you able to solve the issue? I tried setting --enable-undelivered-queue and still get the log message at random moments. Any updates on this? @sheraliinamdar

Hi, currently, i am also facing this problem.

Checkout the solution posted in -> https://github.com/hyperledger/aries-cloudagent-python/issues/1708#issuecomment-1586349233

That sounds to me like a bug in ACA-Py, right?  AFAIK from the spec, multiple items are permitted in preferred order, but if one fails, the I think the behaviour should be to check the next one, right?  Sounds like ACA-Py is grabbing the first entry and if it fails, bailing out.

@swcurran  yes! That does seem like a bug to me. I just captured my observation based on the logs. But the underlying root cause may be something else too.


[Hub Generated] Review request for Microsoft.Databricks to add version stable/2018-04-01

If you are a MSFT employee you can view your work branch via this link.
Contribution checklist:

[x] I have reviewed the documentation for the workflow.


Set up CMake for Google Testing Framework and compiling entiy-system as a library.

@aschaeffer and @IAmNotHanni have decided to compile the entity-system as a library.
This allows other systems build on top of the entity-system to use it correctly.
The CMake project setup must:

[x] Create project files for the dependencies.
[ ] Create a project file for compiling the entity-system as a library.
[x] Create a separate project file for compiling gtest for the entity system.

If somebody still wants to execute a file to see where the project is standing at the monent one can run the google tests.

Done: https://github.com/inexorgame/entity-system/commit/e9d2267768a27b431381e19c3d0065c083179b41.


New App: Find Phone - find your phone via GadgetBridge

A simple app to find your phone via GadgetBridge.
Sends findPhone command if HID is enabled and phone is connected.
I will probably add a torch-like hotkey.

Neat - thanks! Just so you know it can be accessed from the Gadgetbridge settings on the phone, but this is much easier!

Thanks for the quick merge. I fell in love with BangleJs after one minute.
Great work!


Themelet with version set to any doesn't appear in globally installed npm modules

Steps to reproduce:

Create a themelet with yo liferay-theme:themelet and set the version to Any.
Run npm link to globally install the Themelet.
Navigate to a Theme and extend it with npm run extend.
Select Themelet to extend and choose Search globally installed npm modules (development purposes only).

Expected: The Themelet is available to extend
Result: The Themelet doesn't appear in the List
Version tested<EMAIL_ADDRESS>

We've just migrated this project to the liferay-frontend-projects monorepo in the name of consolidation. As this issue is quite old now, I'm not going to transfer it automatically. If you consider it to be still relevant, please create a fresh issue over in the new repo.


Is this extension compatible with single/double quote characters?

I would like for VS Code to highlight single and double quote characters just like Sublime Text.  I tried to add the below settings; however, it didn't seem to work.
"subtleBarckets.pairs" : [
  {
    "open": """,
    "close": """
  },
 {
    "open": "'",
    "close": "'"
  }
]

Typo:
subtleBarckets versus
subtleBrackets
Also probably you need to escape the double quote """ or do '"'

Typo:
subtleBarckets versus
subtleBrackets
Also probably you need to escape the double quote """ or do '"'

Ah open and closing pairs need to be unique so I don't think you can do this. I would suggest that < and > are added in by default though maybe that's a bit weird for html but it sure makes sense in rust!

Ah open and closing pairs need to be unique so I don't think you can do this. I would suggest that < and > are added in by default though maybe that's a bit weird for html but it sure makes sense in rust!

Thanks for your answer.  I'll go ahead and close this issue.

Thanks for your answer.  I'll go ahead and close this issue.


feat: add spans

This PR.

Adds spans for all parsers and combinators that explicitly return results.
Contains some minor improvements here and there.

Closes #34

Ah, yes. I almost forgot about docs and examples there. All of those need to include spans in the result as well. Goddammit. :)

:tada: This PR is included in version 3.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Config refactor

Configs are now dataclasses
DataArgs, SelectorArgs, ModifierArgs and TransformArgs automatically read their fields from the registered classes through an ad-hoc metaclass
This can be considered the first step towards separating arguments such that Trainer and Model itself can use different inits

Added comments


feat(trivy): Add TrivyPlugin

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Spatial memory key error

When I was using 25 agents to run 3000 steps, I got this key error for spatial memory.

GNS FUNCTION: <generate_action_game_object>
"Wolfgang Schulz's room or kitchen"
curr_world: the Ville, curr_sector: Dorm for Oak Hill College, curr_arena: Wolfgang Schulz's room or kitchen
curr_arena: Wolfgang Schulz's room or kitchen not in tree
Traceback (most recent call last):
  File "generative_agents/reverie/backend_server/persona/memory_structures/spatial_memory.py", line 105, in get_str_accessible_arena_game_objects
    x = ", ".join(list(self.tree[curr_world][curr_sector][curr_arena]))
KeyError: "Wolfgang Schulz's room or kitchen"

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "generative_agents/reverie/backend_server/reverie.py", line 468, in open_server
    rs.start_server(int_count)
  File "generative_agents/reverie/backend_server/reverie.py", line 379, in start_server
    next_tile, pronunciatio, description = persona.move(
  File "generative_agents/reverie/backend_server/persona/persona.py", line 222, in move
    plan = self.plan(maze, personas, new_day, retrieved)
  File "generative_agents/reverie/backend_server/persona/persona.py", line 148, in plan
    return plan(self, maze, personas, new_day, retrieved)
  File "generative_agents/reverie/backend_server/persona/cognitive_modules/plan.py", line 959, in plan
    _determine_action(persona, maze)
  File "generative_agents/reverie/backend_server/persona/cognitive_modules/plan.py", line 629, in _determine_action
    act_game_object = generate_action_game_object(act_desp, act_address,
  File "generative_agents/reverie/backend_server/persona/cognitive_modules/plan.py", line 221, in generate_action_game_object
    if not persona.s_mem.get_str_accessible_arena_game_objects(act_address):
  File "generative_agents/reverie/backend_server/persona/memory_structures/spatial_memory.py", line 115, in get_str_accessible_arena_game_objects
    x = ", ".join(list(self.tree[curr_world][curr_sector][curr_arena.lower()]))
KeyError: "wolfgang schulz's room or kitchen"
Error.

这个是因为没有这个地址而错误 然后是在地点切分那里报错

You may find where the exception happens (the request to the spatial memory) and simply skip that if the key does not exist. But I'm not sure if this will impair anything.

我也碰到了，找到方法避免了吗，手动客制地址吗

是在生成小镇的game_object地点的时候报错了


Check cw20 responds to TokenInfo query during cw20-stake instantiation.

resolves #581

Codecov Report
Base: 95.06% // Head: 95.06% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (c528bea) compared to base (b4a0b60).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #590   +/-   ##
=======================================
  Coverage   95.06%   95.06%
=======================================
  Files          42       42
  Lines        3808     3810    +2
=======================================
+ Hits         3620     3622    +2
  Misses        188      188

Impacted Files
Coverage Δ

contracts/staking/cw20-stake/src/contract.rs
88.11% <100.00%> (+0.09%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Remove old cookie exceptions from varnish config

These two cookie exceptions are no longer required because the services
that used them have been decomissioned.
Removing /find-coronavirus-support alphagov/smart-answers#5585
Removing /brexit-eu-funding alphagov/frontend#2263

abandoning, new pr will be raised.


On Reserve Item is not saying it is on reserve

I did a search in alma for where (In temporary location equals "Yes") and found this item that is in a reserve location - https://catalog-alma-qa.princeton.edu/catalog/99106282523506421
I then looked that item up in bibdata:
https://bibdata-alma-staging.princeton.edu/bibliographic/99106282523506421/holdings/22158920250006421/availability.json
You can see the on_reserve in the metadata is N, not Y

@carolyncole the reserves listing has been removed from orangelight and at one point it looked like the alma reserve feature may not be used so we just hard-coded that to 'N' for everything. I'll check on this.

@carolyncole I assume you're asking because it's used in Requests?

Yes, it is used in requests.  We use it to check and see if a person can request a copy.  If it is on reserve is should not be able to be requested for pickup.

We expect some use of alma reserves in the fall; I updated the description.

This is a lower priority right now because there won't be any reserves yet at go-live.

another example https://bibdata-alma-staging.princeton.edu/bibliographic/9931973043506421/holdings/22185253590006421/availability.json

{
"code": "vidlr",
"name": "vidlr: Video Lib Res",
"external_name": "Video Library Reserve",
"type": {
"value": "OPEN",
"desc": "Open"
},
"remote_storage": "",
"map": "",
"suppress_from_publishing": "false",
"fulfillment_unit": {
"value": "Reserves",
"desc": "Reserves"
},
"accession_placement": {
"value": "none",
"desc": "None"
},
"call_number_type": {
"value": "",
"desc": null
},
"link": "https://api-na.hosted.exlibrisgroup.com/almaws/v1/conf/libraries/firestone/locations/vidlr"


Title is too long, body is too short

I have an issue with the text generation - it looks not as expected. For example title field should be short (normally 2-5 words) and body should be long (normally >20 words), but often title generated is longer than body:

To workaround the issue I've created custom field configuration for title and body:

And now it looks like this:

The body is still very short.
The . is added to the end of the title, but I don't need it (it's a punctuation error btw)

So how can I generate short text for titles and long text for bodies? And add/exclude the full stop (.) at the end of the generated text?

Using the Regex matching in the custom fields allows for this kind of additional customization

Sorry, could you provide more details?
I've set minimum number of words for the body (as you can see on the screenshot), but it does not work for the Body field (as you can see on the screenshot).
Also there is no settings for add/exclude full stop at the end of the sentence. Or am I missing something?

Instead of using the text type, I think you'll want to change it to the regex match.
For the title I think you'd want something like this:

For the body, I think you'd want something like this:

(you can ignore the "Regex Match" field in both cases.  I'm working on a successor to this extension, and this is a screenshot from the successor)

Without seeing the underlying html, I'm not sure what you need to put in the match field, but I think the current values you have may not be matching the body field.  If this doesn't work, maybe you could post a code snippet showing the element's html.

I see, this may help. Thanks @calvinballing.


Why did not rewrite ID device ?

hello, i find the broken code
https://github.com/google/python-adb/blob/master/adb/adb_protocol.py#L133
what did you just write
self.remote_id = remote_id
for rewrite bad remote_id you stop the process it's not nessesary.
thank you

That is not correct. If the remote_id changes, it's because someone else (or another python-adb process) is talking to the same device, and we don't support parallel communications at the moment.


feat: add custom line number

fixes #44
New Syntax: showLineNumbers{<number>}
```text showLineNumbers{20}
//some text
```

Line numbers of this code block will be start counting from 20
If no start line number provided, it will work the same as before
```text showLineNumbers
//some text
```

Works great 👍


v10.2.28 JS cleanup: ModalMgr

Current coverage is 95.46%

Merging #210 into master will not affect coverage as of d1874da

@@            master    #210   diff @@
======================================
  Files           26      26
  Stmts          375     375
  Branches         0       0
  Methods         83      83
======================================
  Hit            358     358
  Partial          0       0
  Missed          17      17

Review entire Coverage Diff as of d1874da

Powered by Codecov. Updated on successful CI builds.


Navigating to a blank screen issue

Hello, first of all, I do appreciate your effort. Thank you for building such an useful library. I am trying to develop a watch companion app using the swiftui-router and I am facing this issue of navigating to a black or blank?! screen. Perhaps, I may have not used the router properly...I still do need help with the correct implementation of the library.
here are sample codes similar to for what I have done so far:
import SwiftUI
import SwiftUIRouter

struct RouteURL {
	static let authentication = "/auth"
	static let standby = "/auth/standby"
	static let activity = "/auth/activity"
	static let complete = "/auth/complete"
}

@main
struct WatchDemo_Watch_AppApp: App {
    var body: some Scene {
        WindowGroup {
			Router {
				RootView()
			}
        }
    }
}

import SwiftUI
import SwiftUIRouter

struct RootView: View {
	@EnvironmentObject var navigator: Navigator
    var body: some View {
		VStack {
			Route(RouteURL.authentication) {
				AuthenticationView()
					.onAppear {
						print("authentication Appear")
					}
			}
		}
		.onAppear {
			navigator.navigate(RouteURL.authentication)
		}
    }
}

import SwiftUI
import SwiftUIRouter

enum LoginState: Equatable {
	case attemptToLogin
	case login
	case logout
}

struct AuthenticationView: View {
	@State private var loginState: LoginState = .attemptToLogin
	@EnvironmentObject var navigator: Navigator
    var body: some View {
		VStack {
			switch loginState {
			case .attemptToLogin:
				Text("attempt to login")
				ProgressView()
			case .login:
				Route {
					ActivityRouteView()
				}
			case .logout:
				Text("logout")
			}

		}
		.onAppear {
			DispatchQueue.main.asyncAfter(deadline: .now() + 2) {
				self.loginState = .logout
			}

			DispatchQueue.main.asyncAfter(deadline: .now() + 4) {
				self.loginState = .login
			}
		}
    }
}

#Preview {
	Router {
		AuthenticationView()
	}
}

import SwiftUI
import SwiftUIRouter

struct ActivityRouteView: View {
	@EnvironmentObject var navigator: Navigator
    var body: some View {
		VStack {
			Route(RouteURL.standby, content: standby)

			Route(RouteURL.activity, content: activity)

			Route(RouteURL.complete, content: complete)
		}
		.onAppear {
			DispatchQueue.main.async {
				navigator.navigate(RouteURL.standby)
				print("navigate to standby")
			}

			DispatchQueue.main.asyncAfter(deadline: .now() + 3) {
				navigator.navigate(RouteURL.activity)
				print("navigate to activity")
			}

			DispatchQueue.main.asyncAfter(deadline: .now() + 5) {
				navigator.navigate(RouteURL.complete)
				print("navigate to complete")
			}

			DispatchQueue.main.asyncAfter(deadline: .now() + 7) {
				navigator.navigate("\\", replace: true)
				print("to root")
			}
		}
    }

	var standby: some View {
		Color.blue
	}

	var activity: some View {
		Color.red
	}

	var complete: some View {
		Color.yellow
	}
}

#Preview {
	Router {
		ActivityRouteView()
	}
}

At first, I thought it was a nothing but a preview bug, however, in a real project with a similar router hierarchy, same issue occurs.

I was expecting to see the color change as below when changing route from authentication to activity and standby views...perhaps it may be a bug, or I might have not used the router correctly.
Please help!!

Hi 😃
If a Route has sub-routes you will need to add a /* to the path. So your first Route, which is currently
Route(RouteURL.authentication) { // "/auth/"
	// ...
}

should be
Route("auth/*") {
	// ...
}

This means the Route will render its contents if the Navigator's path is /auth, /auth/standby etc. The * is important here, otherwise paths like /auth/standby/ or anything deeper won't be rendered.
This change alone should fix your problem.

Thank you for your help~ I could easily fix my problem with your solution.
Now everything renders as expected :)


Add left-hand nav for Quick Tips

There is no to get to the list of quick tips - for example - https://www.11ty.dev/docs/quicktips/concatenate/. I'd add a link in the left hand nav as well as an index page that lists them all.

Sorry, I forgot it was under Tutorials. Do you think renaming it to "Tutorials & Tips" would be ok?

Yes - I think it needs a bit more exposure. Want me to do a PR?

Would love that—thanks! Make sure you run the links-internal npm script to check for link breakage

Hey sorry - quick question. Do you want to also move it to it's own page, or keep it as is, a part of tutorials? I see there's an existing quicktips.md but it says things moved to tutorials. Given that the nav is driven by the pages with menuSectionName, it appears we need a 'real' page in order to use this.

You can override with a custom anchor link using this approach https://www.11ty.dev/docs/plugins/navigation/#overriding-the-url
But I’d be in favor of moving quick tips back to that other page. Consolidating on tutorials happened before we had Breadcrumbs and support for deeper left nav (it used to be limited to 2 levels)

Sorry for the delay on this. I'm blaming the apocalypse.


How to keep conv-W conv-B shape, when save_model with shapeonly True

onnx_tool.model_shape_infer(modelpath, None, "r50_shape_only.onnx", shapesonly=True)

A good suggestion! I will consider adding weight to the next release.

The commit of the main branch has supported weight shapes. You can checkout the main branch code for this feature. pypi release will be determined with other issues.

The commit of the main branch has supported weight shapes. You can checkout the main branch code for this feature. pypi release will be determined with other issues.

Get it, thanks.


No ability to enforce Lower Case URLS with Rewrite

Hi there, Since the removal of rewrite rules from the web.config file due to the wwwroot change in RC2 I'm struggling to find any way of enforcing Lower Case URL redirect. Is there any solution to this?
I believe it's quite an important SEO feature to ensure all site urls maintain lowercase structure instead of serving the same page from both lowercase and uppercase.
Previous web.config rule:
<rule name="LowerCaseRule1" enabled="true" stopProcessing="true">
    <match url="[A-Z]" ignoreCase="false" />
    <action type="Redirect" url="{ToLower:{URL}}" />
</rule>

Sorry for not responding to this quicker. We implemented a parser of IISUrlRewrite rules for this scenario. There is a few things you need to do to get this working.

Copy the rule into a separate file, calling whatever you want.
Change the ToLower:{URL} to ToLower{R:0} (we currently do not support the URL keyword in IIS rules)
Add two outer xml sections  around the rule (like it normally is in web.config)
Call in your Configure method:

var options = new RewriteOptions().AddIISUrlRewrite(new StreamReader("test.txt"));
app.UseRewriter(options);

Let me know if that works for you. Our IISUrlRewrite parser is a subset of what is supported in IIS.

Hi @jkotalik thanks for the response, I'm struggling a bit with your proposed solution however.
First off I'm not quite sure what the 'two outer xml sections' are supposed to be and also I get the following issue with StreamReader and reading a .txt file saying

Cannot convert from string to System.IO.StreamReader

So I haven't yet been able to find a way of passing this rule text file in to the Rewrite.
Thanks.

Scratch that, the rule works for simple scenarios cases however completely fails on more complicated URLS.
For instance Account/Login will redirect to account/login/ - Great
However a complicated URL such as
3328134-Red-Soil-Metal-And-Iron-Works redirects goes through a Path as follows:
/r
/r/
Which because unfound goes to
/Home/Errors/404/
/h
/h/
and then stuck in a redirect loop because /h/ doesn't exist and the URL redirect cannot find /home/errors/404/ which is a valid URL path and works if you go directly to it.
Is this something wrong with the rule or the rewrite options? This rule was working fine in IIS for complicated url structures. The rewrite pattern should be able to handle this type of URL easily and not fail and attempt to go to the first letter of the URL. Any thoughts @jkotalik ? Thanks.

Very odd. Just to confirm, when you say completely removed the rewrite package, you removed all uses of .UseRewriter(options)? Also, when you tried to access, for example, /BespokeService/, you hard refreshed the page (ctrl+shift+r), are in private browsing, or have disabled caching? I want to isolate the problem to either the rewrite package or outside of it.

I believe you were correct about the caching, I had removed the UseRewriter line and removed the nuget package and the issue was still happening but whilst trying it within incognito the standard routing worked correct.
Having said that, after ensuring the cache is cleared and re-enabling the rewriting the trailing slash rule works fine however the Lowercase rule is still causing issues with incorrect redirects. In terms of the /BespokeService/ URL i think this could be because i'm using just the action and ignoring the controller, could this catch the rule out?
I'm unsure of the reason why "3328134-Red-Soil-Metal-And-Iron-Works" fails to redirect as this follows the correct /controller/action/ID routing so this might be due to it's complexity?
Much appreciate your time on this.

Gah I'm sorry. I now understand what the first rule was doing now. The reason it is failing is the regex is checking just for characters between A-Z, and captures just that character if it matches. R:0 returns the matched pattern from the Regex, which will just happen to be the first capital letter, in this case R.
Fortunately we can fix this by just capturing everything around the matched capital letter. Change the url to be ".[A-Z]." and that (hopefully) should work.
Thanks for the patience! Rewrite rules are hard to get right.

We periodically close 'discussion' issues that have not been updated in a long period of time.
We apologize if this causes any inconvenience. We ask that if you are still encountering an issue, please log a new issue with updated information and we will investigate.


AzureRT S53 PR #1 - Fix AutoRest Tests

Hi @huangpf, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (phuang). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@azuresdkci retest this please


Update commands doc.

The current Makefile template doesn't use s3cmd anymore but aws s3 sync.

Thanks!


Discussion: TextMate bundles translator

Is writing a tool to translate TextMate bundles to native ecode syntax highlighter format or just supporting TextMate bundles directly (#191) easier?

Please open discussion in... Discussions.


Outdated command to start the adu-agent

adu-agent is now changed to deviceupdate-agent.service
so sudo systemctl restart adu-agent is no longer valid.
use this instead to start the device update service sudo systemctl restart deviceupdate-agent.service
Document details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: fae57922-c3b2-5fb6-230a-9be79c40c774
Version Independent ID: 5650812e-bdcf-8f72-dfec-36474795f474
Content: Device Update for Azure IoT Hub tutorial using the Ubuntu Server 18.04 x64 package agent
Content Source: articles/iot-hub-device-update/device-update-ubuntu-agent.md
Service: iot-hub-device-update
GitHub Login: @vimeht
Microsoft Alias: vimeht

@varmakvl7
Thanks for your feedback! We will investigate and update as appropriate.

@eshashah-msft, this might be better owned by you.

Command updated in the tutorial.
#please-close


feat: disable find functionality in editor

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #48170

Have disabled the editor's built in find functionality. Using Ctrl+F will result in the user interacting directly with the browser's default search/find function. The browser's search functionality works well with the editor and does not result in issues.
Do note that since the find functionality has been disabled, I have commented out the CSS that was being used to hide the find function's panel, as mentioned in this comment.
Another thing to note is that find functionality will only work on the currently displayed content on the editor, this might make searching within code harder. But, assuming that the functionality already was disabled, this shouldn't be much of an issue.

disabled the editor's built in find functionality

Just to clarify, the find functionality itself does not appear to be disabled, only the Ctrl + F hotkey combination has. You can still use monaco's find functionality by opening its F1 menu. Is the intention to disable monaco's find completely or just the hotkey?

Just to clarify, the find functionality itself does not appear to be disabled, only the Ctrl + F hotkey combination has.

Yes you're right, miscommunication on my part.

Is the intention to disable monaco's find completely or just the hotkey?

Personally, I tend to use the find and replace functionality quite frequently so completely disabling it on the editor might not be a wise choice, we should still leave out the option to make use of it.
But to come to a conclusion, we have to take a look back on why it was decided to disable the find functionality by hiding the panels.

Thank you for your contribution to the page! 👍
We are happy to accept these changes and look forward to future contributions. 🎉


Support for bluetooth plugin

Use case
Flutter is a great framework, however, it is limiting support for built-in functionalities, which should be provided by the framework, like Bluetooth.
Currently, flutter does not provide any official plugin for Bluetooth device support

List devices
Connect device
Use device

Also, there is limited plugins available for Bluetooth support and most of them are outdated.
https://fluttergems.dev/bluetooth-nfc-beacon/

Proposal
It will be great if official plugin for Bluetooth can be provided by flutter.
It will remove dependency from third-party plugins and worry of maintenance of the plugin.

Closing this as a duplicate of https://github.com/flutter/flutter/issues/53493.
Kindly subscribe to the issue linked above for updates. Please upvote the issue as well.
Thank you


Highlight commit hook way of signoff

This is a local to checkout change folks can follow.

My PR landed, commit hook is in the docs now

Thanks!


Ex 9.5a

Hi, Yuhang:
Thanks for developing this site for ESL!
I learned how to solve 9.5 (a) from your solution. You can probably generalize the proof as follows.

Best,
Qichun

Thank you Qichun!
Yes I agree with you. I was a bit lazy and only wrote "Similar arguments apply to the general m" for brevity :(

Haha, I see :)
On Tue, Apr 20, 2021 at 12:14 AM Yuhang @.***> wrote:

Thank you Qichun!
Yes I agree with you. I was a bit lazy and only wrote "Similar arguments
apply to the general m" for brevity :(
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/YuhangZhou88/ESL_Solution/issues/3#issuecomment-822594474,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALZ53FGUBWXWYMOSCRPUMSDTJRJHHANCNFSM43F3KTAQ
.

--
Best,
Qichun

Hello, recently I am also working on this exercise (https://github.com/szcf-weiya/ESL-CN/issues/236). It seems that the partition region R_m depends on y_i, so the covariance you calculated is just a conditional one. (I am struggling in the closed-form without fixing R_m, and by googling related materials, I found your great repo here!
Your code indeed treats R_m as random, since you fit a new regression tree for each column of y, but there is a typo that might cause the estimation is close to the number of terminal nodes,

the summation is over each observation, i.e., along the row.

@szcf-weiya
Thank you! you are correct, that should be 0.
For (a), I feel what the authors ask is the conditional one, from the context. Dof is a complicated concept for models like trees.

@YuhangZhou88 To my best knowledge, I had not heard of "conditioanl dof" in any related papers. If you find one, I am appreciated if you can share its link.

@szcf-weiya
I mean the variance, as you pointed out, is "a conditional one". My second comment on dof is a general comment, so for the "closed-form without fixing R_m" that you are looking for, I can imagine it's difficult.


[mongo-cxx-driver] support for ENABLE_CLIENT_SIDE_ENCRYPTION

Is your feature request related to a problem? Please describe.
I need a new feature in [mongo-cxx-driver] to support the cmake flag ENABLE_CLIENT_SIDE_ENCRYPTION=ON from it's dependency [mongo-c-driver]. It does not currently exists.
This is required in order to use Client-Side Field Level Encryption in MongoDB.
Proposed solution
This feature would require a new Package called libmongocrypt that is built using [libbson] as a dependency.
https://mongoc.org/libmongoc/current/using_client_side_encryption.html
Then, it would add this new package as a dependency for [mongo-c-driver].
A Feature should be set to enable/disable Client-Side Field Level Encryption.
[mongo-cxx-driver] would need a feature to forward to its [mongo-c-driver] dependency.
I don't know how this would work?
Describe alternatives you've considered
I've tried compiling the whole suite myself using the right flags but had so much problem that I used vcpkg in the end.
There are no features in vcpkg at the moment to use client-side encryption.
Additional context
https://github.com/mongodb/libmongocrypt
https://mongocxx.org/mongocxx-v3/client-side-encryption
Hope I wrote this request correctly!

Indeed, would it be better to create different entries then?
1 new Package for libmongocrypt
1 new Feature for [mongo-c-driver]
And this one as a new feature to forward to its dependency?

Yes for the new port and feature
AFAIU the "forwarding" to the cxx port should not take any extra code, https://mongocxx.org/mongocxx-v3/client-side-encryption/#libmongocrypt
This is also how the other mongo features are implemented: control via the c port, and the cxx port follows.

Thanks!
I created this new port request : #31329
This feature request was modified per your suggestion.


HADOOP-18426. Improve the accuracy of MutableStat mean.

Description of PR
How was this patch tested?
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[x] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 13s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 47s

trunk passed

+1 :green_heart:
compile
25m 56s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
22m 19s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 26s

trunk passed

+1 :green_heart:
mvnsite
1m 58s

trunk passed

+1 :green_heart:
javadoc
3m 11s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 59s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m  0s

trunk passed

+1 :green_heart:
shadedclient
25m 44s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  6s

the patch passed

+1 :green_heart:
compile
24m 49s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
24m 49s

the patch passed

+1 :green_heart:
compile
22m  5s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
22m  5s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 21s

the patch passed

+1 :green_heart:
mvnsite
1m 54s

the patch passed

+1 :green_heart:
javadoc
1m 17s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 58s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m  0s

the patch passed

+1 :green_heart:
shadedclient
25m 36s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 24s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m 12s

The patch does not generate ASF License warnings.

229m 35s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4811/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4811

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 461bfc88a5ee 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fadd82e4318af05d354594312d8900c75c1430f4

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4811/1/testReport/

Max. process+thread count
3144 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4811/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@Hexiaoqiao @xkrogen Would you mind reviewing this? I noticed that https://issues.apache.org/jira/browse/HADOOP-13804 is a related JIRA.

@zhangshuyan0 It is great catch for me. Just suggest to add some description from this PR and annotation for the new unit test. Thanks.

Thanks for your advice. I have added some comments to JIRA and the code to make it clearer.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 10s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

-1 :x:
mvninstall
14m  4s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
compile
31m 24s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
22m 20s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 26s

trunk passed

+1 :green_heart:
mvnsite
1m 52s

trunk passed

+1 :green_heart:
javadoc
1m 28s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 58s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m  0s

trunk passed

+1 :green_heart:
shadedclient
27m 26s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  8s

the patch passed

+1 :green_heart:
compile
24m 45s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
24m 45s

the patch passed

+1 :green_heart:
compile
26m 13s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
26m 13s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 24s

the patch passed

+1 :green_heart:
mvnsite
2m  0s

the patch passed

+1 :green_heart:
javadoc
1m 18s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 59s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m  8s

the patch passed

+1 :green_heart:
shadedclient
26m 22s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 28s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m 12s

The patch does not generate ASF License warnings.

212m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4811/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4811

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 8c7b4d053178 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / eba387a66952728b15f111440a96f21bd3f8db02

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4811/2/testReport/

Max. process+thread count
2422 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4811/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Re-trigger yetus because last build failed based on report result.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 22s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 19s

trunk passed

+1 :green_heart:
compile
31m 15s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
25m 34s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 44s

trunk passed

+1 :green_heart:
mvnsite
2m 19s

trunk passed

+1 :green_heart:
javadoc
1m 39s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m  7s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 13s

trunk passed

+1 :green_heart:
shadedclient
28m 49s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 21s

the patch passed

+1 :green_heart:
compile
28m 57s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
28m 57s

the patch passed

+1 :green_heart:
compile
26m 51s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
26m 51s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 43s

the patch passed

+1 :green_heart:
mvnsite
2m 34s

the patch passed

+1 :green_heart:
javadoc
1m 43s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 12s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 21s

the patch passed

+1 :green_heart:
shadedclient
31m  4s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
20m 12s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m 37s

The patch does not generate ASF License warnings.

263m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4811/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4811

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux d008a9b3af71 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / eba387a66952728b15f111440a96f21bd3f8db02

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4811/3/testReport/

Max. process+thread count
1536 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4811/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

I think we can better handle this problem by fully changing to use the weighted incremental version of Welford's. I've submitted a PR demonstrating this: https://github.com/apache/hadoop/pull/4844. PTAL.

Great, will review it for a while.


Add documentation for Schematron support

Summary
This pull request addresses #128 and adds documentation for Schematron support in XSpec.
What has changed
I added the following pages on the wiki:

Getting-Started-with-XSpec-and-Schematron: this is a tutorial to get started quickly with the first XSpec test for Schematron. The content is mainly taken from the slides and the first tutorial example.
Writing-Scenarios-for-Schematron: this is taken from the documentation provided by @vincentml. I converted it in Markdown and made some minor cosmetic changes in order to standardize it with the existing XSpec documentation.

I removed schematron.txt from the code base as this is now part of the wiki (@vincentml suggested to do this in https://github.com/xspec/xspec/pull/105#issue-213627245). I also fixed a typo in a tutorial file.
How to review
Follow the step-by-step instructions in Getting-Started-with-XSpec-and-Schematron and see if you get the expected results. I personally find it super easy to try out this new functionality thanks the documentation provided by @vincentml.
@vincentml: can you check I have not introduced any mistake in the documentation?
If anyone else wants to try the documentation and suggest changes or improvements, please post your comments.
Questions
@vincentml: While following your documentation, I stumbled across these two issues:

When I execute the test with the -s option using the shell script, the output gives me these following warnings:

Compiling the Schematron...
Warning at xslt:stylesheet on line 130 column 3 of iso_dsdl_include.xsl:
  Running an XSLT 10 stylesheet with an XSLT 20 processor
Warning at xslt:stylesheet on line 88 column 8 of iso_abstract_expand.xsl:
  Running an XSLT 10 stylesheet with an XSLT 20 processor
Warning at xsl:stylesheet on line 158 column 2 of iso_svrl_for_xslt2.xsl:
  Running an XSLT 10 stylesheet with an XSLT 20 processor

I used Saxon 9.7 HE which is obviously an XSLT 2.0 processor. These warnings cleary come from the Schematron files included in the code base, the files in the output are all stylesheets XSLT 1.0. Do you get the same warnings? Is it safe to ignore them and, if so, is there a way to remove them from the output?

At the end of the process I get the following files:

demo-01-result.html
demo-01-result.xml
demo-01.xsl
demo-01-sch-compiled.xsl
demo-01-sch-temp1.xml
demo-01-sch-temp2.xml
demo-01-var.txt

I wonder if it would be more elegant to remove the last 4 files at the end of the process since these are clearly temporary files generated during the compilation process. However, I understand that these can be very useful for debugging especially now that the feature has just been released. Is there a specific reason for keeping them?

Thanks @cirulls :) I'll read through the documentation in detail soon.
In regard to your questions:
1, The "Running an XSLT 10 stylesheet with an XSLT 20 processor" messages do come from the ISO Schematron XSLTs which are written for XSLT 1.0. One option is to redirect the warning message, which could be done in xspec.bat by "2>nul" (and possibly "2>/dev/null" in xspec.sh). Another option would be to update the Schematron stylesheets to XSLT 2.0. A potential third option would be to find out if there is a newer Schematron XSLT reference implementation available.

The files are helpful for debugging, but perhaps could be removed by a cleanup routine at the end of xspec.bat and xpec.sh. I've started adding a cleanup routine.

These files seem to be available only in XSLT 1.0 in the official Schematron repository, I could not find an implementation that uses all the stylesheets in XSLT 2.0. Maybe is it worth posting a feature request on their GitHub? Converting the Schematron stylesheets to XSLT 2.0 would be great but I don't know how much work is involved and it may be something that I would leave to Schematron experts - you may be one though!
Maybe for now it's better to redirect the warning to null, if you do it in the batch script I can replicate it in the shell script. Not ideal as this can remove some useful error message but better than seeing these warnings, I find these warnings can be confusing for new users.

1, The "Running an XSLT 10 stylesheet with an XSLT 20 processor" messages do come from the ISO ...

Yet another option would be adding -versionmsg:off to the "Compiling the Schematron" command lines.

That looks like the best immediate option. Thanks for the hint!
From: AirQuick<EMAIL_ADDRESS>Sent: Tuesday, May 09, 2017 12:09 PM
To: xspec/xspec<EMAIL_ADDRESS>Cc: Lizzi, Vincent<EMAIL_ADDRESS>Assign<EMAIL_ADDRESS>Subject: Re: [xspec/xspec] Add documentation for Schematron support (#129)
1, The "Running an XSLT 10 stylesheet with an XSLT 20 processor" messages do come from the ISO ...
Yet another option would be adding -versionmsg:off to the "Compiling the Schematron" command lines.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://github.com/xspec/xspec/pull/129#issuecomment-300215239, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFFbEYBboLBvn2Az6M5--ulj0vQHH14Pks5r4I-2gaJpZM4NTRdD.

@vincentml, I gave you write access to the repository so you should now be able to edit the wiki directly.
As you now have write access to the XSpec repository as well, please use this power wisely ;-) This mainly boils down to:

do not push changes directly to master. Work on your branch and use the pull request mechanism instead
be kind to others ;-)

Thank you @cirulls ! I will use this ability with care.
I have made a few edits to the Schematron pages in the wiki.

@cirulls, is it now okay to merge this pull request with master?


[New Model]: Google's Paligemma family of models

The model to consider.
https://huggingface.co/google/paligemma-3b-pt-896
The closest model vllm already supports.
I think the only visual language model supported right now is LLava but I could be wrong.
What's your difficulty of supporting the model you want?
No response

MiniCPM is also supported.
Excited to test out how PaliGemma compares, especially when analyzing GUI images: https://github.com/OpenAdaptAI/OpenAdapt/issues/637

I'm working on a PR for this currently. See #5189


style: Update .gitignore, delete .DS_Store and add README to fMRI/ dir

Changes are summarised as follows:

Update .gitignore with global paths for ipynb checkpoints and .DS_Store.
Remove the previously committed .DS_Store binary.
Add a README to the fMRI/ dir with direct links to open the notebooks in colab.

Looks great thank you!


fix inconsistent workspace creation

Details
Fixed Issues
$ https://github.com/Expensify/App/issues/46383
PROPOSAL: https://github.com/Expensify/App/issues/46383#issuecomment-2262163007
Tests
Same QA step

[x] Verify that no errors appear in the JS console

Offline tests
QA Steps

Log in to both the mobile web (mweb) and Android app.
Tap on the Expensify selector.
Tap the plus icon to create a new workspace.
Ensure that both the mobile web and Android app exhibit the same behavior when creating a new workspace.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/e2738db9-085a-4a4d-b208-d4c61afa48d9

Android: mWeb Chrome
https://github.com/user-attachments/assets/51f2b213-80c1-4c83-ad56-5f1bcd5de50d

iOS: Native
https://github.com/user-attachments/assets/13e85e4d-4d9f-4c52-9e03-817662cb4f77

iOS: mWeb Safari
https://github.com/user-attachments/assets/4dc22574-17f6-444b-880c-732b2a510e72

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/a082999f-efd6-49a0-9b75-53875c7a1e50

MacOS: Desktop
https://github.com/user-attachments/assets/d8d4b342-4563-4886-a515-d97b32a29dbc

@huult All looks good, but can you please clear the last step and add that the LHN should not be briefly shown before directing to the workspace page

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/0404df4c-0dc0-4a2d-9157-607c91a17a3d

Android: mWeb Chrome
https://github.com/user-attachments/assets/fc8ded2b-de50-4a1f-b62f-facd1678af73

iOS: Native
https://github.com/user-attachments/assets/42e9ed82-5028-435b-8bcc-b5c418eaaee5

iOS: mWeb Safari
https://github.com/user-attachments/assets/b480683e-b4ea-4ffa-8049-8581328b1577

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/5648ee9e-e707-40d7-bddc-a2473bc7e617

MacOS: Desktop
https://github.com/user-attachments/assets/83f8b02f-a562-4d0b-ba5a-c021076d941e

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.0.17-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Initial setup for hhs app

Changes:

Add files for initial exponent setup

It seems like all of the files added are needed, but we aren't familiar enough with exponent to be sure. We should look into it.
Please Review: @bradbenjamin-wf @sagersmith8 @Kuroshii

+1


Drop "white box" for dashboard events

Before

After

Looks better.
Maybe horizontally align the top of the avatar with the top of the title?

I think it looks worse this way. Maybe it would be better to have the whole contents in the white box instead of the title and timestamp outside of it? The text doesn't contrast enough with the background color IMO.

How about this?

@bfred-it That looks really good.

Also perhaps I should drop the updated __/__ from new repos.

Here are some new and comprehensive styles:

Let's give this a go


Add export to pastebin option for text exports

Pastebin's API won't work with Muledump Local due to the null origin. This gave me an excuse to make a second new API. Jakcodex / Paste is going up in preview v9.4.3.

Released with v9.4.0.


KeyguardClient Singleton

Explore whether it makes sense to offer a KeyguardClient.Instance getter as a KeyguardCient default / singleton instance.

I don't see a big advantage in offering that in the Client. It's only used in Accounts, which is quite short-living, so there is hardly the case where we have several KeyguardClient instances in use.
What I suggest instead is a method static setEndpoint(endpoint: string), so we don't have to pass a possible config parameter in Accounts each time we instantiate a KeyguardClient.