Loading Controller Crashes Gazebo Server

I am trying to utilize the gazebo_ros2_control package for controlling the position of a revolute joint from a URDF file. However following along with the package README (which thankfully is better than most ROS2 pkg README's, so thank you for that), it seems something in the ros2_control tag is causing gazebo to crash, as the adding the libgazebo_ros2_control.so file with the gazebo tags alone without the ros2_control tags does not crash gazebo.
My URDF file spawned in fine prior to adding the following to the bottom within the <robot> tags. I configured it as follows:
<ros2_control name="GazeboSystem" type="system">
    <hardware>
      <plugin>gazebo_ros2_control/GazeboSystem</plugin>
    </hardware>
    <joint name="camera_pole_joint">
      <command_interface name="position">
        <param name="min">-3.14159</param>
        <param name="max">3.14159</param>
      </command_interface>
      <state_interface name="position"/>
      <state_interface name="velocity"/>
      <state_interface name="effort"/>
    </joint>
  </ros2_control>

  <gazebo>
    <plugin filename="libgazebo_ros2_control.so" name="gazebo_ros2_control">
      <robot_param>robot_description</robot_param>
      <robot_param_node>robot_state_publisher</robot_param_node>
      <parameters>$(find ros2_sim_pkg)/config/cam_bot.yaml</parameters>
    </plugin>
  </gazebo>

With my config file having:
controller_manager:
  ros__parameters:
    update_rate: 50  # Hz

    joint_trajectory_controller:
      type: joint_trajectory_controller/JointTrajectoryController

    joint_state_controller:
      type: joint_state_controller/JointStateController

joint_trajectory_controller:
  ros__parameters:
    joints:
      - camera_pole_joint
    interface_name: position

Basically I am trying to create a position controller to interact with my joint called camera_pole_joint
OS: Ubuntu 20.04
ROS Distro: Foxy (apt install)
Output of terminal running gazebo:
ray@ubuntu:~/Workspaces/udemy_ros2_ws$ ros2 launch gazebo_ros gazebo.launch.py
[INFO] [launch]: All log files can be found below /home/ray/.ros/log/2021-03-31-00-28-41-487954-ubuntu-21664
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [gzserver-1]: process started with pid [21666]
[INFO] [gzclient   -2]: process started with pid [21669]
[gzserver-1] [INFO] [1617186529.478072601] [camera_controller]: Publishing camera info to [/camera1/camera_info]
[gzserver-1] [INFO] [1617186529.587212547] [gazebo_ros2_control]: Loading gazebo_ros2_control plugin
[gzserver-1] [INFO] [1617186529.600678750] [gazebo_ros2_control]: Starting gazebo_ros2_control plugin in namespace: /
[gzserver-1] [INFO] [1617186529.603022856] [gazebo_ros2_control]: Starting gazebo_ros2_control plugin in ros 2 node: gazebo_ros2_control
[gzserver-1] [INFO] [1617186529.622931749] [gazebo_ros2_control]: connected to service!! robot_state_publisher
[gzserver-1] [INFO] [1617186529.624571891] [gazebo_ros2_control]: Recieved urdf from param server, parsing...
[gzserver-1] [INFO] [1617186529.641574313] [gazebo_ros2_control]: Loading joint: camera_pole_joint
[gzserver-1] [INFO] [1617186529.642266984] [gazebo_ros2_control]: 	Command:
[gzserver-1] [INFO] [1617186529.642590928] [gazebo_ros2_control]: 		 position
[gzserver-1] [INFO] [1617186529.642890565] [gazebo_ros2_control]: 	State:
[gzserver-1] [INFO] [1617186529.643170214] [gazebo_ros2_control]: 		 position
[gzserver-1] [INFO] [1617186529.643638167] [gazebo_ros2_control]: 		 velocity
[gzserver-1] [INFO] [1617186529.644139749] [gazebo_ros2_control]: 		 effort
[gzserver-1] [INFO] [1617186529.646519580] [gazebo_ros2_control]: Loading controller_manager
[gzserver-1] terminate called without an active exception
[gzserver-1] Aborted (core dumped)
[ERROR] [gzserver-1]: process has died [pid 21666, exit code 134, cmd 'gzserver                                                                    -s libgazebo_ros_init.so   -s libgazebo_ros_factory.so       '].

Terminal output of spawning in the URDF does not seem to throw any errors:
ay@ubuntu:~/Workspaces/udemy_ros2_ws$ ros2 launch ros2_sim_pkg cam_bot_world.launch.py
[INFO] [launch]: All log files can be found below /home/ray/.ros/log/2021-03-31-00-28-47-357037-ubuntu-21761
[INFO] [launch]: Default logging verbosity is set to INFO
urdf_file_name : urdf/camera_bot.xacro
[INFO] [robot_state_publisher-1]: process started with pid [21766]
[INFO] [spawn_entity.py-2]: process started with pid [21768]
[robot_state_publisher-1] [WARN] [1617186527.537782915] [robot_state_publisher]: No robot_description parameter, but command-line argument available.  Assuming argument is name of URDF file.  This backwards compatibility fallback will be removed in the future.
[robot_state_publisher-1] Parsing robot urdf xml string.
[robot_state_publisher-1] Link base had 5 children
[robot_state_publisher-1] Link camera_pole had 1 children
[robot_state_publisher-1] Link camera_link had 0 children
[robot_state_publisher-1] Link wheel_BL had 0 children
[robot_state_publisher-1] Link wheel_BR had 0 children
[robot_state_publisher-1] Link wheel_FL had 0 children
[robot_state_publisher-1] Link wheel_FR had 0 children
[robot_state_publisher-1] [INFO] [1617186527.550467733] [robot_state_publisher]: got segment base
[robot_state_publisher-1] [INFO] [1617186527.550830406] [robot_state_publisher]: got segment camera_link
[robot_state_publisher-1] [INFO] [1617186527.551082150] [robot_state_publisher]: got segment camera_pole
[robot_state_publisher-1] [INFO] [1617186527.551316623] [robot_state_publisher]: got segment robot_footprint
[robot_state_publisher-1] [INFO] [1617186527.552871455] [robot_state_publisher]: got segment wheel_BL
[robot_state_publisher-1] [INFO] [1617186527.553206308] [robot_state_publisher]: got segment wheel_BR
[robot_state_publisher-1] [INFO] [1617186527.553421784] [robot_state_publisher]: got segment wheel_FL
[robot_state_publisher-1] [INFO] [1617186527.553628807] [robot_state_publisher]: got segment wheel_FR
[spawn_entity.py-2] [INFO] [1617186528.166923053] [urdf_spawner]: Spawn Entity started
[spawn_entity.py-2] [INFO] [1617186528.167815622] [urdf_spawner]: Loading entity published on topic /robot_description
[spawn_entity.py-2] [INFO] [1617186528.170817956] [urdf_spawner]: Waiting for entity xml on /robot_description
[spawn_entity.py-2] [INFO] [1617186528.263362879] [urdf_spawner]: Waiting for service /spawn_entity, timeout = 5
[spawn_entity.py-2] [INFO] [1617186528.264286665] [urdf_spawner]: Waiting for service /spawn_entity
[spawn_entity.py-2] [INFO] [1617186528.273687918] [urdf_spawner]: Calling service /spawn_entity
[spawn_entity.py-2] [INFO] [1617186528.582535103] [urdf_spawner]: Spawn status: SpawnEntity: Successfully spawned entity [cam_bot]
[INFO] [spawn_entity.py-2]: process has finished cleanly [pid 21768]

Here is  my launch file in case it is of use:
import os
from ament_index_python.packages import get_package_share_directory
from launch import LaunchDescription
from launch.actions import DeclareLaunchArgument, ExecuteProcess
from launch.substitutions import LaunchConfiguration
from launch_ros.actions import Node
from launch.launch_description_sources import PythonLaunchDescriptionSource

def generate_launch_description():

  use_sim_time = LaunchConfiguration('use_sim_time', default='false')
  urdf_file_name = 'urdf/camera_bot.xacro'

  print("urdf_file_name : {}".format(urdf_file_name))

  urdf = os.path.join(
      get_package_share_directory('ros2_sim_pkg'),
      urdf_file_name)

  return LaunchDescription([

        DeclareLaunchArgument(
            'use_sim_time',
            default_value='false',
            description='Use simulation (Gazebo) clock if true'),

        # ExecuteProcess(
        #     cmd=['gazebo', '--verbose', '-s', 'libgazebo_ros_factory.so'],
        #     output='screen'),

        Node(
            package='robot_state_publisher',
            executable='robot_state_publisher',
            name='robot_state_publisher',
            output='screen',
            parameters=[{'use_sim_time': use_sim_time}],
            arguments=[urdf]),

        # Node(
        #     package='joint_state_publisher',
        #     executable='joint_state_publisher',
        #     name='joint_state_publisher',
        #     output='screen',
        #     parameters=[{'use_sim_time': use_sim_time}]
        #     ),

        Node(
            package='gazebo_ros',
            executable='spawn_entity.py',
            name='urdf_spawner',
            output='screen',
            arguments=["-topic", "/robot_description", "-entity", "cam_bot"])
  ])

I currently have the joint state publisher and auto launching gazebo commented out, as I was trying to make sure those were not interfering with the libgazebo_ros2_control.so.

As an update, I have tried to recreate my launch file to better represent that in the examples, however I am running into issues launching it, as I get the following error:
ImportError: cannot import name 'GazeboRosPaths' from 'scripts' (/home/ray/Workspaces/udemy_ros2_ws/install/udemy_ros2_pkg/lib/python3.8/site-packages/scripts/__init__.py)
The launch file is as follows:
# Copyright 2020 Open Source Robotics Foundation, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import os

from ament_index_python.packages import get_package_share_directory

from launch import LaunchDescription
from launch.actions import ExecuteProcess, IncludeLaunchDescription, RegisterEventHandler
from launch.event_handlers import OnProcessExit
from launch.launch_description_sources import PythonLaunchDescriptionSource

from launch_ros.actions import Node

import xacro

def generate_launch_description():
    gazebo = IncludeLaunchDescription(
                PythonLaunchDescriptionSource([os.path.join(
                    get_package_share_directory('gazebo_ros'), 'launch'), '/gazebo.launch.py']),
             )

    # gazebo_ros2_control_demos_path = os.path.join(
    #     get_package_share_directory('gazebo_ros2_control_demos'))
    #
    # xacro_file = os.path.join(gazebo_ros2_control_demos_path,
    #                           'urdf',
    #                           'test_cart_position.xacro.urdf')
    #
    # doc = xacro.parse(open(xacro_file))
    # xacro.process_doc(doc)

    urdf_file_name = 'urdf/camera_bot.xacro'

    urdf = os.path.join(
        get_package_share_directory('ros2_sim_pkg'),
        urdf_file_name)

    params = {'robot_description': urdf}

    node_robot_state_publisher = Node(
        package='robot_state_publisher',
        executable='robot_state_publisher',
        output='screen',
        parameters=[params]
    )

    spawn_entity = Node(package='gazebo_ros', executable='spawn_entity.py',
                        arguments=['-topic', 'robot_description',
                                   '-entity', 'cartpole'],
                        output='screen')

    load_joint_state_controller = ExecuteProcess(
        cmd=['ros2', 'control', 'load_start_controller', 'joint_state_controller'],
        output='screen'
    )

    load_joint_trajectory_controller = ExecuteProcess(
        cmd=['ros2', 'control', 'load_start_controller', 'joint_trajectory_controller'],
        output='screen'
    )

    return LaunchDescription([
        RegisterEventHandler(
            event_handler=OnProcessExit(
                target_action=spawn_entity,
                on_exit=[load_joint_state_controller],
            )
        ),
        RegisterEventHandler(
            event_handler=OnProcessExit(
                target_action=load_joint_state_controller,
                on_exit=[load_joint_trajectory_controller],
            )
        ),
        gazebo,
        node_robot_state_publisher,
        spawn_entity,
    ])

and the terminal output:
ay@ubuntu:~/Workspaces/udemy_ros2_ws$ ros2 launch ros2_sim_pkg gazebo_ros2_control_test.launch.py
[INFO] [launch]: All log files can be found below /home/ray/.ros/log/2021-03-31-01-20-49-067692-ubuntu-26382
[INFO] [launch]: Default logging verbosity is set to INFO
Task exception was never retrieved
future: <Task finished name='Task-2' coro=<LaunchService._process_one_event() done, defined at /opt/ros/foxy/lib/python3.8/site-packages/launch/launch_service.py:271> exception=ImportError("cannot import name 'GazeboRosPaths' from 'scripts' (/home/ray/Workspaces/udemy_ros2_ws/install/udemy_ros2_pkg/lib/python3.8/site-packages/scripts/__init__.py)")>
Traceback (most recent call last):
  File "/opt/ros/foxy/lib/python3.8/site-packages/launch/launch_service.py", line 273, in _process_one_event
    await self.__process_event(next_event)
  File "/opt/ros/foxy/lib/python3.8/site-packages/launch/launch_service.py", line 293, in __process_event
    visit_all_entities_and_collect_futures(entity, self.__context))
  File "/opt/ros/foxy/lib/python3.8/site-packages/launch/utilities/visit_all_entities_and_collect_futures_impl.py", line 45, in visit_all_entities_and_collect_futures
    futures_to_return += visit_all_entities_and_collect_futures(sub_entity, context)
  File "/opt/ros/foxy/lib/python3.8/site-packages/launch/utilities/visit_all_entities_and_collect_futures_impl.py", line 45, in visit_all_entities_and_collect_futures
    futures_to_return += visit_all_entities_and_collect_futures(sub_entity, context)
  File "/opt/ros/foxy/lib/python3.8/site-packages/launch/utilities/visit_all_entities_and_collect_futures_impl.py", line 45, in visit_all_entities_and_collect_futures
    futures_to_return += visit_all_entities_and_collect_futures(sub_entity, context)
  [Previous line repeated 3 more times]
  File "/opt/ros/foxy/lib/python3.8/site-packages/launch/utilities/visit_all_entities_and_collect_futures_impl.py", line 38, in visit_all_entities_and_collect_futures
    sub_entities = entity.visit(context)
  File "/opt/ros/foxy/lib/python3.8/site-packages/launch/action.py", line 108, in visit
    return self.execute(context)
  File "/opt/ros/foxy/lib/python3.8/site-packages/launch/actions/include_launch_description.py", line 125, in execute
    launch_description = self.__launch_description_source.get_launch_description(context)
  File "/opt/ros/foxy/lib/python3.8/site-packages/launch/launch_description_source.py", line 84, in get_launch_description
    self._get_launch_description(self.__expanded_location)
  File "/opt/ros/foxy/lib/python3.8/site-packages/launch/launch_description_sources/python_launch_description_source.py", line 51, in _get_launch_description
    return get_launch_description_from_python_launch_file(location)
  File "/opt/ros/foxy/lib/python3.8/site-packages/launch/launch_description_sources/python_launch_file_utilities.py", line 62, in get_launch_description_from_python_launch_file
    launch_file_module = load_python_launch_file_as_module(python_launch_file_path)
  File "/opt/ros/foxy/lib/python3.8/site-packages/launch/launch_description_sources/python_launch_file_utilities.py", line 37, in load_python_launch_file_as_module
    loader.exec_module(mod)
  File "<frozen importlib._bootstrap_external>", line 783, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/opt/ros/foxy/share/gazebo_ros/launch/gzserver.launch.py", line 28, in <module>
    from scripts import GazeboRosPaths
ImportError: cannot import name 'GazeboRosPaths' from 'scripts' (/home/ray/Workspaces/udemy_ros2_ws/install/udemy_ros2_pkg/lib/python3.8/site-packages/scripts/__init__.py)

Hello, it seems a problem in your gzserver launch file. Is the "gzserver" launch file working fine in your system? Just try:
ros2 launch gazebo_ros gzserver.launch.py
If not, try to reinstall gazebo11 and gazebo_ros_pkgs  for ROS2.

Hi I have the same error (at least the initial one) where loading the controller manager crashes gazebo. There are also no error messages for me except the final one that the gzserver has died.  Running  ros2 launch gazebo_ros gzserver.launch.py works without any problems.

Hi @Thieso, I am not sure, but I think the initial problem was that the URDF has been passed as an argument to robot_state_publisher:
Node(
     package='robot_state_publisher',
     executable='robot_state_publisher',
     name='robot_state_publisher',
     output='screen',
     parameters=[{'use_sim_time': use_sim_time}],
     arguments=[urdf]),

but it should be given as a parameter (what @808brick already did in the second post):
params = {'robot_description': urdf}
Node(
     package='robot_state_publisher',
     executable='robot_state_publisher',
     name='robot_state_publisher',
     output='screen',
      parameters=[params]

@808brick It seems that your ros2 launch file is looking only for your workspace scripts folder, did you source the ros2 distro?
source /opt/ros/foxy/setup.bash

Hi @Schulze18
I am already passing it as an argument so that does sadly not solve the problem.

So further information on this,
I ran gazebo with gazebo --verbose -s libgazebo_ros_init.so -s libgazebo_ros_factory.so which gives me the error [Err] [Model.cc:1137] Exception occured in the Load function of plugin with name[gazebo_ros2_control] and filename[libgazebo_ros2_control.so]. This plugin will not run.
Sadly this is also not helpful for me but maybe you can see some problem there. Any hints are appreciated
My launch file is
#!/usr/bin/env python3

import os
import sys

from ament_index_python.packages import get_package_share_directory

import launch
from launch import LaunchDescription, LaunchService
from launch.actions import IncludeLaunchDescription, RegisterEventHandler, ExecuteProcess
from launch_ros.actions import Node
from launch.event_handlers import OnProcessExit
from launch.launch_description_sources import PythonLaunchDescriptionSource
import xacro

def generate_launch_description():
    # Load the URDF into a parameter
    bringup_dir = get_package_share_directory('scanbot_description')
    urdf_path = os.path.join(bringup_dir, 'scanbot_system.urdf.xacro')
    urdf = xacro.process_file(urdf_path).toxml()

    rviz_config_file = os.path.join(
        get_package_share_directory('scanbot_description'),
        'scanbot.rviz'
        )

    gazebo_node = launch.actions.ExecuteProcess(
        cmd=['gazebo', '--verbose', '-s', 'libgazebo_ros_init.so', '-s', 'libgazebo_ros_factory.so'],
        output='screen'
    )
    # gazebo_node = IncludeLaunchDescription(
        # PythonLaunchDescriptionSource([os.path.join(
            # get_package_share_directory('gazebo_ros'), 'launch'), '/gazebo.launch.py']),
    # )

    spawn_entity_node = Node(package='gazebo_ros', executable='spawn_entity.py',
            arguments=['-entity', 'scanbot', '-topic', 'robot_description'],
            output='screen')

    joint_state_publisher_node = Node(
            name='joint_state_publisher',
            package='joint_state_publisher',
            executable='joint_state_publisher',
            output='screen'
    )
    robot_state_publisher_node = Node(
            name='robot_state_publisher',
            package='robot_state_publisher',
            executable='robot_state_publisher',
            parameters=[{'robot_description': urdf}],
            output='screen'
    )
    rviz_node = Node(
            package='rviz2',
            name='rviz2',
            executable='rviz2',
            output='screen',
            arguments=['-d', rviz_config_file],
    )

    return LaunchDescription([
        joint_state_publisher_node,
        rviz_node,
        gazebo_node,
        robot_state_publisher_node,
        spawn_entity_node,
    ])

def main(argv=sys.argv[1:]):
    """Run lifecycle nodes via launch."""
    ld = generate_launch_description()
    ls = LaunchService(argv=argv)
    ls.include_launch_description(ld)
    return ls.run()

if __name__ == '__main__':
    main()

I apologize for being inactive on this thread, was a busy week.
@Schulze18 my terminals are automatically sourced to ROS Foxy via .bashrc (so the line source /opt/ros/foxy/setup.bash is at the end of the .bashrc file, which is how my ROS commands are able to run) then I go into the workspace, source it and try to launch.
I am not on the system in question right now, but I will try to do more experimenting this weekend with the comments you have given and report back. Thanks for all the feedback and help.

hi @Schulze18
is it even possible to launch Gazebo with both plugins as suggested above https://github.com/ros-simulation/gazebo_ros2_control/issues/67#issuecomment-816849356
gazebo --verbose -s libgazebo_ros_init.so -s libgazebo_ros_factory.so

Hi @Schulze18, hi @808brick
Was this issue resolved? I still have the issue on Foxy Branch with Gazebo-11 and would like to know if there's a workaround.

Somehow it seems to function out of the box when looking at eg. https://www.youtube.com/watch?v=xBhYHOSxMOk.
My controller config:
`
controller_manager:
ros__parameters:
update_rate: 100    # Hz
joint_trajectory_controller_spj:
  type: joint_trajectory_controller/JointTrajectoryController
joint_state_broadcaster_spj:
  type: joint_state_broadcaster/JointStateBroadcaster

joint_trajectory_controller_slj:
  type: joint_trajectory_controller/JointTrajectoryController
joint_state_broadcaster_slj:
  type: joint_state_broadcaster/JointStateBroadcaster

joint_trajectory_controller_ej:
  type: joint_trajectory_controller/JointTrajectoryController
joint_state_broadcaster_ej:
  type: joint_state_broadcaster/JointStateBroadcaster

joint_trajectory_controller_w1j:
  type: joint_trajectory_controller/JointTrajectoryController
joint_state_broadcaster_w1j:
  type: joint_state_broadcaster/JointStateBroadcaster

joint_trajectory_controller_w2j:
  type: joint_trajectory_controller/JointTrajectoryController
joint_state_broadcaster_w2j:
  type: joint_state_broadcaster/JointStateBroadcaster

joint_trajectory_controller_w3j:
  type: joint_trajectory_controller/JointTrajectoryController
joint_state_broadcaster_w3j:
  type: joint_state_broadcaster/JointStateBroadcaster

joint_trajectory_controller_spj:
ros__parameters:
joints:
- shoulder_pan_joint
interface_name: position
command_interfaces:
- position
state_interfaces:
- position
- velocity
joint_trajectory_controller_slj:
ros__parameters:
joints:
- shoulder_lift_joint
interface_name: position
command_interfaces:
- position
state_interfaces:
- position
- velocity
joint_trajectory_controller_ej:
ros__parameters:
joints:
- elbow_joint
interface_name: position
command_interfaces:
- position
state_interfaces:
- position
- velocity
joint_trajectory_controller_w1j:
ros__parameters:
joints:
- wrist_1_joint
interface_name: position
command_interfaces:
- position
state_interfaces:
- position
- velocity
joint_trajectory_controller_w2j:
ros__parameters:
joints:
- wrist_2_joint
interface_name: position
command_interfaces:
- position
state_interfaces:
- position
- velocity
joint_trajectory_controller_w3j:
ros__parameters:
joints:
- wrist_3_joint
interface_name: position
command_interfaces:
- position
state_interfaces:
- position
- velocity
`
And my xacro:
`

<xacro:macro name="gazebo_control" params="
prefix
shoulder_pan_lower_limit
shoulder_pan_upper_limit
shoulder_lift_lower_limit
shoulder_lift_upper_limit
elbow_joint_lower_limit
elbow_joint_upper_limit
wrist_1_lower_limit
wrist_1_upper_limit
wrist_2_lower_limit
wrist_2_upper_limit
wrist_3_lower_limit
wrist_3_upper_limit
">

    <!--  The robot I wanted to control had already ros2_control tags. I added xacro conditionals to determine real HW, fake HW or Gazebo. Problem solved.

Please don't expect many things to be fixed in Foxy. We'd appreciate if you
could give us feedback about what's on rolling ATM as it will be the
baseline for the Humble release, thanks!
On Wed, 11 May 2022, 10:58 MXS13, @.***> wrote:

Okay, it was my bad. The robot I wanted to control had already
ros2_control tags. I added xacro conditionals to determine real HW, fake HW
or Gazebo. Problem solved.
—
Reply to this email directly, view it on GitHub
https://github.com/ros-simulation/gazebo_ros2_control/issues/67#issuecomment-1123477987,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA24PYPICHK2KKLNPKR3SZ3VJOADFANCNFSM42ELBKMQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Okay, it was my bad. The robot I wanted to control had already ros2_control tags. I added xacro conditionals to determine real HW, fake HW or Gazebo. Problem solved.

@MXS13 could you please expand on this? I'm having the same issue.

probably something like we did in our demos.

How does that prevent Gazebo from crashing?


Better handling of template urls and config.xml locations

Will now copy config.xml files outside the www folder
Handles alternate template URLS.

Thanks @chrisgriffith,
I left some feedback in the commit messages.
Also, we ned to have test passing and new tests added to cover the config.xml scenario.

My testing mojo is low, so I will have to leave that on your shoulders.

haha, alright. I've got a backlog of work, but I'll queue this sucker up! Thanks for kicking it off.

NP. It was the least I could do after killing the Desktop app by accident ;)
Haven't looked at the > issue in the generated config.xml yet. Figured I
would let the experts handle that one
cg
On Mon, Apr 4, 2016 at 8:17 AM, Michael Brooks<EMAIL_ADDRESS>wrote:

haha, alright. I've got a backlog of work, but I'll queue this sucker up!
Thanks for kicking it off.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/phonegap/connect-phonegap/pull/150#issuecomment-205344329

Looks like there are conflicts here. Is this still valid?

It this still valued? If so, please rebase and reopen.


odo watch pushes files to the wrong directory

a good way to reproduce this is with  https://github.com/openshift/nodejs-ex
git clone  https://github.com/openshift/nodejs-ex
odo create nodejs mynode
odo push
odo url create
odo watch

now  change something in views/index.html
after watch triggers, refresh you won't see your changes in the webpage
The reason is that if you check /opt/opt-root/src/ you will see that index.html is there instead of in  /opt/opt-root/src/views  where it should be.
we are not pushing files into the correct path
odo push works correctly

This might be nodejs specific. I wasn't able to reproduce this with java

I just tried it with Java and was not able to reproduce it either

Starting to think  that using io.openshift.s2i.destination was not a good idea :-( we might go back to pushing files directly to /opt/app-root/src

We have more e2e tests now, so if we do that we should be able to see if anything breaks.
Should perhaps add watch e2e tests as well?

Maybe this is just a bug in the NodeJS s2i image that we should work around?

Yeah I tend to agree with @geoand with may be a bug on nodejs s2i image repo

Given that the current approach(relying on labels) is a perfectly legal approach as per s2i docs

not really, as we are not copying the whole application, but only a single files, that is something that s2i was never designed to do
I supsect that if you try python image, you will see the same problem.
I also think that we haven't this problem before we started using this label.
Both are just my working theroies that I haven't verifed yet and I'm not sure if I get change to try it today :-(

@kadel I'll try it post lunch

@anmolbabu  have you been able to determine why this affects python and nodejs but not java based images?

@jorgemoralespou @jankleinert @sspeiche  Please be aware of this bug, when you are demoing nodejs apps. odo push works but odo watch can break the app if you edit file that is subdirectory and not in the root folder of the project :-(

@geoand Is it possible that this was introduced with changes in https://github.com/redhat-developer/odo/pull/954 ?

It can't exclude the possibility, but that change should only affect cases were a single non-directory file is specified. When the file is a directory, the old behavior should still be present

I can't exclude the possibility, but that change should only affect cases were a single non-directory file is specified. When the file is a directory, the old behavior should still be present

This is actually why I was starting to look at those changes. This is exactly this situation. Only one single file is being transferred  and it hits this part of the code https://github.com/redhat-developer/odo/pull/954/files#diff-6025e9b620e9321c03c11bf29e5c4dbdR2497
I still haven't figure out what is happening there with all the paths, but my current suspission is that the problem is somewhere around there.

I see what you mean...
However it strikes me as odd that this is not problem in Java

I will test it again and make sure

Actually I may be seeing this as well with Java, I still need to check

@amitkrout As discussed on chat feel free to cover even this issue via e2e tests
Pointers: https://github.com/redhat-developer/odo/pull/820 and https://github.com/redhat-developer/odo/pull/975
Possible improvements:

Move watch tests to a separate file(with a new ginko target and hence independently testable) with more coverage of more scenarios
Trigger file modifications via simple shell commands(for ex: sed) rather than the currently used os#Open#WriteString(as in https://github.com/redhat-developer/odo/blob/master/pkg/testingutil/fileutils.go#L99)
Watch currently checks only if watch detected a triggered file change(as in https://github.com/redhat-developer/odo/blob/master/tests/e2e/cmp_test.go#L238)... we should instead check the end-to-end behaviour perhaps via a change in api o/p etc.. ? curl the component url and verify previous and current state of o/p.

Cc: @geoand

I agree :100: with @anmolbabu

@anmolbabu Cool!!! Thanks for the pointers


Add estimated content time

This is an idea for the pages to show the time to go through the page based on either Hugo's own ReadingTime or a custom time set by the user (in case you are linking videos). It would show up as this, for example:

You can disable/enable it for the entire project by doing showContentTime = true/false to the config.toml
You can disable/enable it for the given post by adding showContentTime = true/false to the front matter
You can override the calculated "reading time" by adding contentTime = X to the front matter

Let me know if that's something you'd like to merge and I can document it on the appropriate places

Sorry @tupaschoal, I love the idea, but I don't think I'll be adding this to the main theme. I'm already deviating too much from base Bear, and more options tend to get confusing to users. Thanks for the contribution!


error in updating angular 11 to 12

🐞 Bug report
Command (mark with an x)

[ ] new
[ ] build
[ ] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[x] update
[ ] lint
[ ] extract-i18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?
Yes. six month ago I updated this project 10 to 11 and be okay
Description
I want update my angular project from version 11 to version 12
but get error
🔬 Minimal Reproduction
I have angular project with version 11
Go to update.angular.io
Select version 11 to 12
run npx @angular/cli@12 update @angular/core@12 @angular/cli@12
Get Error
🔥 Exception or Error

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@angular-devkit/build-angular
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/@angular/compiler-cli
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@angular-devkit/build-angular
npm ERR!     dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See C:\Users\behro\AppData\Local\npm-cache\eresolve-report.txt for a full report.

npm ERR!

I attach log file
2021-11-05T13_14_24_506Z-debug.log

Duplicate of https://github.com/angular/angular-cli/issues/21204


Fix PHP 8.1 deprecation errors

While running my test suite on PHP 8.1 RC3, I encountered following errors.
The default value of $flags param is now 0.
Deprecated: preg_match(): Passing null to parameter #4 ($flags) of type int is deprecated in /var/glpi/vendor/friendsoftwig/twigcs/src/Lexer.php on line 23

Deprecated: preg_match(): Passing null to parameter #4 ($flags) of type int is deprecated in /var/glpi/vendor/friendsoftwig/twigcs/src/Lexer.php on line 44

Deprecated: preg_match(): Passing null to parameter #4 ($flags) of type int is deprecated in /var/glpi/vendor/friendsoftwig/twigcs/src/Lexer.php on line 60

It would be interesting to add a job in the CI to test PHP 8.1

Hi,
I added it to the CI matrix.
Regards

Up !

PHP version is composer.json should be updated as well: https://github.com/friendsoftwig/twigcs/blob/c82b078e9c199bc57375e557fb888b04f53420b2/composer.json#L12
See https://www.php.net/supported-versions.php. Security (!) support ends in 3 days from now, so I'd suggest dropping support for it.

Thank you @cedric-anne!

Would be great if we could get a new release for this.


[#253] Password length validation for password fields

resolves #253
Motivation and context
It's good to enforce minimum password lengths to make bruteforcing more difficult.
Screenshots

before
after

What I did

added ng-minlength directive to password fields with length 8
added server-side checks to ensure passwords are the correct length before saving them. Won't save password if it's too short
added error message "Please use a password that is at least 8 characters." if user tries to use a short password

Ok so after doing a little digging, the passport-local-mongoose documentation on this really sucks:

Options
When plugging in Passport-Local Mongoose plugin additional options can be provided to configure the hashing algorithm.
User.plugin(passportLocalMongoose, options);
Main Options
...

passwordValidator: specifies your custom validation function for the password in the form 'function(password,cb)'. Default: validates non-empty passwords.

After doing some digging I found the PR where this functionality was added, though, and according to the tests in that file it kind of looks like we can add a custom validation by adding a passwordValidator function to the options object, and it should vaguely look like
var customValidationFunction(password,cb) {
  if (password.length < 7) {
    cb("Password must be at least 8 characters long.")
  }
}

User.plugin(passportLocalMongoose, { passwordValidator: customValidationFunction });

maybe? I'm happy to pair with you on this if you get stuck.

All set!


Tag 0.4.3

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/26271
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.4.3 -m "<description of version>" 6b4de9e852b9635bf5d4ce0e92720c03a095233f
git push origin v0.4.3


jquery 3.2.1 -  boostrap v4  plugin not working

I'm trying to use stellar with bootstrap v4, jquery 3.2.1 but it returns error
"Uncaught TypeError: elem.getClientRects is not a function"
https://jsfiddle.net/farkasimre/fo2pba5o/
Thanks!

fix on pull request #158


Tek Launcher not finding non-dedicated servers

Hi
My Tek Launcher is only able to find unofficial servers

It's not supposed to find any other servers, there is a filter set to search only servers that use TEK Wrapper, which official servers won't ever have


Android or iOS?

I'm sure there's a way to build for Android & iOS, but I've never worked with either of them so I don't know what's required.
If anyone is keen on those, please feel free to file a PR!

For my Android build, just add "-DCMAKE_SYSTEM_NAME=Android" to the command line
(cmake >= 3.21: https://cmake.org/cmake/help/latest/manual/cmake-toolchains.7.html#cross-compiling-for-android-with-the-ndk)

cmake -B build -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=install JavaScriptApi -DCMAKE_SYSTEM_NAME=Android


[feat] support disable fullscreen

Describe the problem
On macOS, when I set size, min_size and max_size of current window to same value, but the window still can be fullscreen.
Describe the solution you'd like
If the size, min_size and max_size of window have same value, then the window's fullscreen should be disabled. Or add an option to config the window can be fullscreen or not.
Alternatives considered
No response
Additional context
No response

Set resizable to false will disable the fullscreen dot button.


Feature request for a file picker

It would be great to be able to allow users to pick files from their own machines. I guess one would nee to work in
<label for="myfile">Select a file:</label>
<input type="file" id="myfile" name="myfile">

this to the widgets etc.

Just checking, would this be as simple as:

adding this to WidgetBase.jl:

struct FilePicker <: AbstractWidget{String}
    value::Observable{String}
    attributes::Dict{Symbol, Any}
end

function FilePicker(value::String; kw...)
    FilePicker(Observable(value), Dict{Symbol, Any}(kw))
end

and then this to src/widgets.jl:

function jsrender(fp::FilePicker)
    return DOM.input(
        type = "file",
        value = fp.value,
        onchange = js"update_obs($(fp.value),  this.value);";
        fp.attributes...
    )
end

?
If it's that easy, let me know and I'll PR! Actually, I'll go test it locally and see for myself..!

By god it's that easy. My only problem is that it prints the (even previously somehow cached) file name beside the Browse button. Any way to "avoid" that, or is that desirable (although there's no way to show the button without the test then)?

OK, I figured it would be best to Pr what I have an d work on it like that. Let me know how I can improve on that PR. The only two grievances are:

the printing issue, it shows the file beside the browse button no matter what.
I have no idea how to add a test for it in JSServe.

Thanks in advance!


add mouse drag and swipe feature in jcarousel

Can we add mouse drag and swipe feature in jcarousel, so that we can use jcarousel using mouse drag rather that click on arrow for prev and next ?
I want to add feature like this http://code.ovidiu.ch/dragdealer/

I am using jcarousel and unfortunately not able to change HTML structure for Touch carousel so is there any scripting/library option to make it swipe enable.

There is a swipe plugin made by @snake-345, check the Third-Party Plugins section of the README.


Remove hack/tools.go

This was a relic of the time when this repo contained the cosigned
webhook (now policy-controller in its own repo).
These deps weren't included in the cosign CLI, and can just be dropped
from the repo.
Signed-off-by: Jason Hall<EMAIL_ADDRESS>

cc #1462


Remove another warning about Log4j log correlation being experimental.

This is a follow-up to #1528.

Codecov Report

Merging #1534 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1534      +/-   ##
============================================
- Coverage     82.56%   82.54%   -0.02%
  Complexity     1662     1662
============================================
  Files           251      251
  Lines          7753     7753
  Branches        756      756
============================================
- Hits           6401     6400       -1
  Misses         1125     1125
- Partials        227      228       +1

Impacted Files
Coverage Δ
Complexity Δ

...ion/log4j2/OpenCensusTraceContextDataInjector.java
95% <ø> (ø)
9 <0> (ø)
:arrow_down:

...census/implcore/trace/export/SpanExporterImpl.java
91.78% <0%> (-1.37%)
8% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f07e4b...0e68248. Read the comment docs.


Add Jacoco support

This merge adds Jacoco support to the CoverageStatus badge.
I've done the build and deployed the .hpi to our jenkins server.  For jobs with a jacoco report, it creates the badge correctly.  For jobs without, it creates the default 'coverage|unknown' badge.
Support for cobertura and clover should remain intact, but I have no jobs using either of those to test with.

Hey there. Just wanted to say that your modifications worked like a charm. I have both Cobertura JaCoCo reportings and in works in all cases. Real thumbs up for this to be merged.


feat (HACBS-1139): Copy annotations/labels from Build Pipeline to other objs

Signed-off-by: Jing Qi<EMAIL_ADDRESS>

/retest


Introduction and Task Tracker of Applicant: Nitya Pasrija

Hey, I am an Outreachy applicant for the May 2023, cohort and I look forward to contributing to the project :)
This is the submission for Task 1 and Task 2

Greetings mentors: @ruqaiyasattar @jafsia @PetraAG
I have successfully cloned and set up the Flutter project locally and will be starting with the Advanced Task :)


Implementing JECs for 2022 and 2023 eras

JEC and JER corrections for 2022 and 2023 implemented

Also added Electron SFs for 2023, which were missing before.
This is ready for review @valsdav


Testing deployment

Pull Request checklist

[] Addresses an issue: Fixes #0000

Description of changes
(Summarize any changes made)

Codecov Report

Merging #86 (de193c2) into master (5bc6aff) will decrease coverage by 7.17%.
The diff coverage is 100.00%.

:exclamation: Current head de193c2 differs from pull request most recent head 53d2a58. Consider uploading reports for the commit 53d2a58 to get more accurate results

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   95.52%   88.34%   -7.18%
==========================================
  Files         352       23     -329
  Lines        2322      266    -2056
  Branches      266       43     -223
==========================================
- Hits         2218      235    -1983
+ Misses        102       31      -71
+ Partials        2        0       -2

Impacted Files
Coverage Δ

...ct-switch/src/components/Switch/useSwitchStyles.ts
100.00% <100.00%> (ø)

...act-table/src/components/TableCell/useTableCell.ts

packages/react-card/src/Card.ts

packages/react-avatar/src/utils/stringToColor.ts

...ckages/react-dialog/src/components/Dialog/index.ts

packages/react-table/src/TableHeader.ts

...-accordion/src/components/AccordionHeader/index.ts

...ckages/react-icon/src/cebus-icons/CurrencyIcon.tsx

...-card/src/components/CardMedia/renderCardMedia.tsx

...ges/react-input/src/components/Select/useSelect.ts

... and 320 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0208660...53d2a58. Read the comment docs.


Duplicate labels appear in the next image

When I share an account label with my colleagues, I find that the label at a certain moment will be added to the next picture, and it will continue to accumulate. How can I solve it?

@chakloong883
Please fill the issue tempalate, otherwise we can't help you.


Add a semantic warning for printing stats maps with top/div args

Both top and div are ambiguous when printing stats maps. top does not
specify which statistic it's based on and it would cause confusion to define a
default behavior for it. As for div, it would also somehow be strange: if use
div on all three statistics, then the output does not have avg * count == sum
anymore; if only on sum and avg, it might be misleading.
Related to #1416.

Checklist

[ ] Language changes are updated in docs/reference_guide.md
[x] User-visible and non-trivial changes updated in CHANGELOG.md

Something I'm not sure of:

If this should be recorded in CHANGLOG.md? If so, which section it belongs to then.
I make it a warning, not sure if it's strong enough.

Updated CHANGELOG.md


Extending UrlDispatcher and passing app object

Long story short
The new version of aiohttp supports subapps. Which is awesome! Unfortunately, it makes extending UrlDispatcher a little tricky.
I've previously been extending the UrlDispatcher for my extension (I add a way to mount my api methods):
https://github.com/toumorokoshi/aiohttp-transmute/blob/master/aiohttp_transmute/url_dispatcher.py#L8
Example:
https://github.com/toumorokoshi/aiohttp-transmute/blob/master/aiohttp_transmute/tests/example.py#L42
However, this breaks in the newest version, due to the new app object requirement. Unfortunately, since I have to pass the router into the app object during creation, I don't have the app object to properly instantiate the Router.
Expected behaviour
I'm thinking something like this?
app = web.Application(loop=loop, router_class=TransmuteUrlDispatcher)

Then the code for app would look something like:
    def __init__(self, *, logger=web_logger, loop=None,
                 router=None, router_class=web_urldispatcher.UrlDispatcher,
                 handler_factory=RequestHandlerFactory,
                 middlewares=(), debug=False):
        if loop is None:
            loop = asyncio.get_event_loop()
        if router is None:
            router = router_class(self)
        assert isinstance(router, AbstractRouter), router

Actual behaviour
Unable to instantiate the router properly. I'm passing in app=None right now, but that'll break for subapps.
I'm also open to alternative approaches to what I'm trying to do (mount custom routes, and then keep a dictionary that I use later for documentation).
I can do the PR for this too, if there's agreement on the approach.
Thanks!

UrlDispatcher was not designed for extending.
Use it as is -- or implement AbstractRouter from scratch.
Regarding to aiohttp-transmute I suggest another design:

Push transmute context and swagger info into web.Application as app['AIOHTTP_TRANSMUTE_CONTEXT'] for example.
Implement add_transmute_route(app, *args) top-level function for registering route in given application.

ok, got it. Didn't realize that wasn't for inheriting.
I think i'll move forward with the top-level function and app values as you described. thanks!


How to expose SSH publicly via node port

The instructions say
"baseimage-docker does not expose the SSH server to the public Internet by default."
But they do not say how to turn this functionality on.
Is there a simple method to enable exposing this via a node port so I can ssh into a pod from a machine outside the cluster?
I've tried and cannot get it to work.  SSH just hangs.

@dsargent3220 may you please provide some more information about what you have tried? Also it would be helpful if you provided output from your commands, etc.

The instructions are not for Kubernetes, they are written for Docker machines. Kubernetes has some additional barrier to entry, I am assuming you had trouble climbing over it for one reason or another (it's ok!) If you're creating a service to expose SSH via nodeport, three or more things could have gone wrong, attaching this list in case you haven't figured it out, or for the next guy:

your NodePort service's exposed port is firewalled. (This can happen by default on some k8s providers, since nodeport is in a range around 30000-32767, those are unusual ports for services like SSH or HTTP, usually you only want those exposed to load balancers, who can remap them to the expected port for external consumer. Assuming you don't want a load balancer, then...)

you expected a different port than NodePort opened (again, the port will be in the range 30000-32767, so make sure you're accessing the service on the right port)

your Service isn't actually reaching the running pod behind it (you can test this from within the cluster! if the service is called "myssh" in the namespace "default" you should be able to use an ssh client to connect to it with ssh myssh.default.svc

It might be good to provide instructions on how to run this image in Kubernetes, this is something I've worked on myself recently, in the past few months anyway. If you'd like to open a separate issue about that, please feel free to "at" me! I might get around to it on my own, but it is more likely to get done if someone will pair with me and hold me accountable.


fix(build): snappy on macos was failing to build because of wrong extension

Summary
Fixes Snappy on MacOS (make build-venv was failing).

Damn, it does not seem to be enough to fix it. Looking further.


Remove use of neb config file in fetch-book

Recent improvements to neb allow users to invoke commands without
creating a configuration file. Specifically, this change makes use
of the fact that with those updates, if you pass a fully qualified
hostname to neb as the environmnet and no configuration is available
that matches, it will use the environment value as the cnx hostname.

Opening this as draft PR for the time being as I want to test this change in a local pipeline once the corresponding neb changes are merged and a corresponding tag is available.


FR: Allow integration with templater, or run e.g. templater if it is installed

This would allow e.g. to have a comment callout if and only if a comment has been added.

It does not, but if your template is e.g. comment: {{comment}}, the
output would be comment: . Integrating with templater allows e.g. if
blocks so you can remove that line completely without it feeling like
you're "missing" a section.
On Sat, Dec 2, 2023, 02:00 John Christopher @.***>
wrote:

Sorry, not sure I understand. If you have {{comment}} in your template
but no comment is provided, it should not add anything in the output. Is it
adding output for you?
—
Reply to this email directly, view it on GitHub
https://github.com/jgchristopher/obsidian-clipper/issues/51#issuecomment-1836969850,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABF4GPAQKVH6JZ2L3MZCADDYHJ4URAVCNFSM6AAAAAA75NCXQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZWHE3DSOBVGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Let me look to see if I can integrate with templater. If it doesn't have an api for other plugin developers then I can probably add something to the internal templating I have to support this.


cannot use ⌘ - ' as keyboard shortcut

Issue Type: Bug
On Mac OS

Open keyboard shortcuts
Try to assign ⌘ - ' to a shortcut

I am unable to assign it and previous shortcut with that assignment does not work.
VS Code version: Code 1.57.1 (507ce72a4466fbb27b715c3722558bb15afa9f48, 2021-06-17T13:28:32.912Z)
OS version: Darwin x64 20.5.0
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz (16 x 2300)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
32.00GB (0.01GB free)

Process Argv
--disable-extensions --crash-reporter-id 092f7002-6078-42ba-b658-ccef5fe0bd26

Screen Reader
no

VM
0%

Extensions disabled
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspyt653:30270858
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonvspyt551cf:30311713
vspre833:30321513
pythonptprofiler:30281270
vshan820:30294714
vscoreces:30322571
pythondataviewer:30285071
vscus158:30321503
pythonvsuse255cf:30323309
vscorehovct:30309550
vscod805cf:30301675
binariesv615:30325510

For what it's worth I am unable to reproduce this on another computer but reinstalling vscode on this machine does not remedy the problem

@dmiracle I don't think I understand exactly your keybinding ⌘ - '.
Do you mean you want to define a chord keybinding i.e. ⌘ -, `⌘ ''?

Sorry for the confusion. I mean the chord ⌘ '

Sorry for the confusion. I mean the keybinding for ⌘ '

Could you please try the following:

Run the command Developer: Toggle Keyboard Shortcuts Troubleshooting
This will activate logging of dispatched keyboard shortcuts and will open an output panel with the corresponding log file.
Press exactly the keybinding you desire (cmd + ').
check what VS Code detects and what command is invoked.

If you are having trouble understanding the output, please feel free to paste here and I can try to help.

This works now, I don't know what the problem was.


Feature Request: Add support for Gitlab Api

Please add support for Gitlab API. Getting the list of users, creating a user, adding the user to project, removing the user from the project, etc.

Unfortunately Gitlab isn't that popular and doesn't offer unique features that would block proof of concept demos for hackathons and such. Even bitbucket has higher ranking that it.  The following are the current Alexa Traffic stat global rankings for the three of them:
Github:  63
Bitbucket: 903
Gitlab: 2382
https://www.alexa.com/siteinfo/gitlab.com
https://www.alexa.com/siteinfo/bitbucket.org
https://www.alexa.com/siteinfo/github.com
The documentation for GitLab API is available at https://docs.gitlab.com/ee/api and they have a npm module https://www.npmjs.com/package/gitlab if you would like to do the integration for your own application.


Update extensible-control-programming-reference.md

Clean-up code samples

@SysC0mp, thank you for making these updates.

No problem :)


Fix unescape string value when not escpaped

The Syntax for an escaped Character is "x....", the "." can be numbers or the character ABCDEFabcdef (Case sensitive).
Before this fix, it was not tested if the provided Value has "_" on its end.
With a Value like 'TEST_X', the method skips with Exception.
I added another method to check if the provided value is in fact an escaped character, before trying to unescaping it. Another Testcase with this Example was also implemented.
Resolves #1122

HI @sandraros, I am becoming the same error messages like you regarding abaplint, could you assist me with that?

Sorry for the delay, it's perfect, thank you very much! 👍


Global Settings - cacerts is marked as modified all the time

on v2.5-head 87006de
the cacerts entry is marked as modified, which is confusing to users because they cannot edit the cacerts

Expected:
remove the modified indicator from the cacerts entry

The fix is validated on v2.5-head 87006de with the latest UI
Result:
no modified indicator on the cacerts entry


[Style] Logo above menu is too big on mobile devices

Please consider using 128px or less for the current logo. It does use a lot of space both on desktop and specially mobile.

This is what I see on mobile.  Is this what you are referring to?

Correct!


Push datatype codegen to Projector

Taking this responsibility away from Machinator.
While we want to keep using Machinator's syntax, putting Projector in charge of codegen makes it way easier to write complicated backends. I hit this wall almost immediately when writing the Pux backend.
WIP pending manual compatibility testing

Still working on this, will close until it's ready


Add example direct call to IHederaTokenService and abis

Signed-off-by: Nana Essilfie-Conduah<EMAIL_ADDRESS>Description:

Related issue(s):
Fixes #
Notes for reviewer:

Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

why did all of the .json files get recreated when the .sol files didn't change?

Closing as design approach changed.
System contracts can't be called directly by EOAs unless there's a facade.
At the time the only ones supported are noted HIP 719


[6.0] Render availability items without version range details

Explanation: Adds support for indicating that a symbol is available on a certain platform, even if there are no additional details on the specific version of that platform when it was first introduced.
Scope: Impacts availability items with no version range information.
Issue: rdar://139423135
Risk: Small, makes the AvailabilityRange.introducedAt prop optional instead of required
Testing: Detailed in original PR.
Reviewer: @marinaaisa
Original PR: #891

@swift-ci test


Remove chef-* binstubs from chef gem

This is for the relicensing effort.
Note that this PR leaves the knife and ohai binstubs still in the
gem(s) while that discussion is still ongoing.

Just for the record, I'm not a fan of this change. We've never officially supported gem install chef as an install style, but this will make it entirely unavailable. This will make installing Chef on unusual environments (RasPis, etc) more difficult, and will undoubtedly frustrate some number of people that built their own install systems around gem install chef.
That said, I have no energy to argue this point, I just wanted to side effects listed so people will have an easier time finding the change which broke things for them.

closed in favor of #8413


[Bug]: Letter Spacing inconsistent when using puppeteer

Bug expectation
I expected puppeteer to turn my html into a pdf and keep the letter spacing as in my html file sent.
This is what i send to puppeteer :

This is what puppeteer uploads :

As we can see, the letter spacing is inconsistent between characters.
Bug behavior

[ ] Flaky
[ ] No error
[x] PDF

Minimal, reproducible example
To reproduce this error i run the command shown below and upload the buffer as a byte64.

Error string
Visual bug
Puppeteer configuration
const puppeteer = require('puppeteer');

module.exports = {
  generatePdf: async function (htmlContent) {
    const browser = await puppeteer.launch({
      args: [
        // Required for Docker version of Puppeteer
        '--no-sandbox',
        '--disable-setuid-sandbox',
        // This will write shared memory files into /tmp instead of /dev/shm,
        // because Docker’s default for /dev/shm is 64MB
        '--disable-dev-shm-usage',
        '--single-process',
        '--font-render-hinting=none'
      ]
    });
    const page = await browser.newPage();
    await page.setContent(htmlContent, { waitUntil: 'networkidle0' });

    const buffer = await page.pdf({ format: 'A4', printBackground: true });
    browser.close();

    return buffer;
  },

Puppeteer version
19.5.0
Node version
14.19.0
Package manager
npm
Package manager version
9.1.2
Operating system
Windows

@DeftEye is the letter spacing consistent if you print to pdf using the browser's built-in print dialog?


Feature request: API for managing folding area

We are adding commands for fold/unfolding code in Vim and it turns out that Code's APIs are somewhat limited. All Vim's folding commands can be categorized as below.
Close/Open Folds (Done)
Vim allows users to open/close folds under cursor. Users can also decide how deep the folds are opened or closed.
These commands are partially supported, we have editor.fold, editor.unfold, editor.foldRecursively, etc and it's easy to map them to Vim commands. Besides, Code supports us to fold from level 1 to level 5 but level 6 and above is not supported and we don't have similar commands for unfold.
Vim even supports us to toggle Fold. We don't have this command in Code and we can't use editor.fold or editor.unfold to workaround as we have no idea whether we are inside a folding area.
executeCommand('editor.fold, {levels: 3});

executeCommand('editor.unfold, {levels: 3});

Fold creation/deletion
Vim allows users to create or delete folds manually. It's not possible here as Code is doing this for us.
Navigate through Folds
We can navigate to previous or next fold area through commands in Vim. If we want to implement this in Code, we need to know the info about all folds.
Fold options
We can configure max/min screen lines for a fold, max level for folds, etc in Vim. Again, we didn't expose them in Code.

There are about 20+ unique commands and 10+ options about folding and we can only implement 5 of them partially right now.

Disussed with Sandeep. The goal is provide commands that let you implement the VIM requirements. Unless really needed, we try not to introduce the concept of the folding regions in the extension host API.

@aeschli I'm Okay with hiding folding region info. If we can provide generic API to navigate/manage folding regions, then it would be perfect. If it turns out that we are adding too many Vim specific commands, maybe it can be a good time to introduce Fold.

There are already existing commands supporting some folding functionalities / operations. So, we can add more if necessary or needed. True that we are adding them as Vim needs them, but we are making sure that they are generic enough for any extension to use.

Unless really needed, we try not to introduce the concept of the folding regions in the extension host API.

@aeschli
I think folding info is one of the basic things extensions should be able to query, just like cursor position or number of lines in a document.

The goal is provide commands that let you implement the VIM requirements.

I don't understand what's the reason behind your decision to hide these information from extensions. I get the feel that you trying to do the extension writer jobs. If you provide the basic info for folding regions then extension writers can implement anything on top of it.
@sandy081

True that we are adding them as Vim needs them, but we are making sure that they are generic enough for any extension to use.

I think wrapping folding info with generic enough apis is not realistic right now.
Because you don't know all the use cases future extensions will need.
Having information on folding areas gives extension writers more power we on how to control the editor. we can easily implement cursorMove commands you implemented, toggleFold, moveToFoldEnd, moveToFoldBegin, and anything we can possibly find in vim documentation later.

Vim allows us to create Fold area manually, by indentation, expression or syntax while Code is doing foding by indentation. But customizing the folding creation is not frequently used by Vim users so we should go with indentation first.
The first part is openning/closing folds and they only require fold information.

[ ] za	When on a closed fold: open it. When on an open fold: close it and set 'foldenable'.
[ ] zA	When on a closed fold: open it recursively. When on an open fold: close it recursively and set 'foldenable'.
[ ] [z	Move to the start of the current open fold.
[ ] ]z	Move to the end of the current open fold.
[ ] zj	Move downwards to the start of the next fold.
[ ] zk	Move upwards to the end of the previous fold.

The second part depends on option foldlevel. 'foldlevel' is a number option: The higher the more folded regions are open.

[ ] zm	Fold more: Subtract one from 'foldlevel'.
[ ] zr	Reduce folding: Add one to 'foldlevel'.
[ ] zo	Open one fold under the cursor.When a count is given, that many folds deep will be opened.
[ ] zc	Close one fold under the cursor. When a count is given, that many folds deep are closed.
[ ] zv	View cursor line: Open just enough folds to make the line in which the cursor is located not folded.
[ ] zx	Update folds: Undo manually opened and closed folds: re-apply 'foldlevel', then do "zv": View cursor line.

The third part depends on folding area manual creation/deletion.

[ ] zf{motion} or {Visual}zf	Operator to create a fold.
[ ] zF	Create a fold for [count] lines. Works like "zf".
[ ] zd	Delete one fold at the cursor.
[ ] zD	Delete folds recursively at the cursor.
[ ] zE	Eliminate all folds in the window.

Others are almost about Vim Fold options and I don't think we need to take them into consideration before we handle all commands above.

@aminroosta
Exposing folding regions (or any view regions) to the extensions is not helpful because they are based on internals. It will make difficult for extension developers to implement on top of them correctly. Instead, developing and exposing the commands will make it available to everybody and easier to use. I agree that it is not possible to develop commands / api that can meet everyone's requirements. Since it is an open community, it is always welcome to discuss/request/contribute them.
Again, just exposing folding regions will not be enough to implement commands likecursorMove, toggleFold etc... It needs enough information about editor internals.

@sandy081

It will make difficult for extension developers to implement on top of them correctly. Instead, developing and exposing the commands will make it available to everybody and easier to use.

With great power comes great responsibility!
Your argument is perfectly valid, it just reminds me of the same arguments Java developers use against C++ ones for accessing memory.

Exposing folding regions to the extensions is not helpful because they are based on internals.

I don't think querying the IndentRange[]  array returned from computeRanges  exposes editor internals.
export class IndentRange {
	_indentRangeBrand: void;
	startLineNumber:number;
	endLineNumber:number;
	indent:number;
       ....
}

Better yet just replace IndentRange[] with vscode.Range[].
And allow us to add or remove vscode.Range to the list of folding regions.

developing and exposing the commands will make it available to everybody and easier to use.

If you take the route of implementing apis with vim extensions in mind then you are doing the extension writers job, we will have future issues opening on vscode instead of the relative vim plugin repository.
That being said the commands @rebornix listed is all that i've ever used in vim and i think that's true for many many vim users and those who have used more than that will never switch from the original vim 😄

@aminroosta Agreed that exposing just folding ranges is nothing to do with the internals. But, to implement the folding commands (navigation or toggling), this data is not going to be enough and you need internal details.
I think exposing commands is the right approach for the above listed commands.

After discussing with @rebornix, Creating / Deleting foldings will not be supported because

Creating / Deleting folders is itself is a big editor feature with much bigger scope than Vim / editor commands.
Low priority from Vim extension (not mandatory)

Unless it is really required for Vim, we will de-scope it.

I think for navigation this data is actually enough!
All off the commands rebornix listed can be implemented.
Toggling is not an issue because if we know current line is folded or not we can implement it.
I can't think of any command from first and second part of commands that rebornix listed that can't be implemented with just this info.
If you allow adding and removing to and from fold list then the third part can be implemented as well.
Get Outlook for Android
On Wed, Aug 3, 2016 at 6:50 PM +0430, "Sandeep Somavarapu"<EMAIL_ADDRESS>wrote:
@aminroosta Agreed that exposing just folding ranges is nothing to do with the internals. But, to implement the folding commands (navigation or toggling), this data is not going to be enough and you need internal details.
I think exposing commands is the right approach for the above listed commands.

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/Microsoft/vscode/issues/9786#issuecomment-237237385

@rebornix I enhanced editor.fold and editor.unfold commands to take a number levels argument. This will help you in implementing zc and zo commands in Vim.

Sure I'll give it a try real quick.

@sandy081 I've tried your new args but it doesn't work. But I don't think it's your code's problem as editor.foldLevel1, editor.foldLevel2, etc don't work on my machine as well. I'll try and find the root cause behind it.

I noticed folding doesn't work in TypeScript but works in JavaScript. But I'm not seeing it take effect. For example,
function foo() {
  if (true) {
    console.log("bar");
  }
}

if we run 2zc in Vim at the third line, then run zo, the code will be like
function foo() {
  if (true){
  }
}

However, if I run vscode.commands.executeCommand("editor.fold", {levels: 2}); then open the outter fold manually, I see the inner block is not folded.

editor.fold command folds all foldings under the current cursor position till the number of levels given.  This is as per the description of the command zc in Vim Roadmap
So in the above example, this folds only one level at line 3 because there are no sub foldings under it. vscode.commands.executeCommand("editor.fold", {levels: 2}); on line 1 will fold line 1 and line 2.
Let me know if I there is some mis-understanding of the documentation.

@sandy081 ha that makes sense.

@rebornix So the current behavior is expected?

@sandy081 I tested it again but found that vscode.commands.executeCommand("editor.fold", {levels: 2}); only folds line 1 but not line 2.
My repro steps are : run vscode.commands.executeCommand("editor.fold", {levels: 2}); on line 1, open fold on line 1 and I found line 2 is not folded.

@rebornix See the attached video, it works as expected for me

First, I folded 2 levels by 2zc command and later unfolded each by zo command.

@sandy081 thanks for the video, it addresses the behavior well and now it's working on my machine perfectly as well!

@sandy081 Now that you are working on folding APIs please also take a look at folding end
patterns. It should be easy to fix, I have a PR which explains what i mean by folding end patterns.
This is really deal breaker to me, every other text editor (except sublime) does it right.
VIM, Visual Studio, Intellij, Atom, Eclipse, NetBeans, XCode, Notepad++ ...
Don't make us wait another month ;-)

@aminroosta  We are already in end game, so I am afraid we can push any major changes. But, I will take a look and see if they are small enough to make it.
Thanks

Structural/Scope based code folding was a feature I implemented for VisualFSharpPowertools and one I'd love to bring over to Ionide-FSharp

The current indentation and brace based approach does a pretty good job, but it's unable to accurately capture the scopes of some of F#'s constructs and doesn't always use the same bounds for the folded region as the lexicographic scope.
The other advantage a folding API would provide us is the ability to filter which constructs are folding enabled

@sandy081 @aeschli
Do you guys have any plans to address the fold API issues?
Please provide your comments, so we can help by sending PRs.

@sandy081 @aeschli
Do you guys have any plans to address the fold API issues?
Please provide your comments, so we can help by sending PRs.

@aminroosta There were not any plans for now to implement this. This need a strong use case and discussion from language protocol perspective since foldings can be language specific too.

This feature request will not be considered in the next 6-12 months roadmap and as such will be closed to keep the number of issues we have to maintain actionable. Thanks for understanding and happy coding!


Replace GCC old flag name with new flag name

According to GNU GCC Manual
-Wextra
This option used to be called -W. The older name is still supported,
but the newer name is more descriptive.

Thank @gun-bear for contributing!


Bugs causing memory leak and alloc-dealloc-mismatch

During my test with AddressSanitizer enabled, the sanitizer reports that there are memory leaks and alloc-dealloc-mismatch in the codes. Using stack trace provided by ASan, the bugs are found (one of them is hard to solve).
The bug that causes memory leak is at PageManager::Free in storage/page-manager.cpp. Before removing the page information in the unordered map, we should delete its corresponding buffer.
// In PageManager::Free
eviction_policy_.Remove(pgid);
auto it = buf_.find(pgid);
if (it != buf_.end()) {
  assert(it->second.refcount == 0);
  delete[] it->second.addr; // We may add this line.
  buf_.erase(it);
}

The bugs that cause alloc-dealloc-mismatch are at:

Line 43 of common/bitvector.hpp, where mem_ is mem_ = std::unique_ptr<uint64_t>(new uint64_t[_get_alloc_size(size_)]);. Note that if we change the type here, there is also a need to modify the corresponding definition of mem_. (Change the type of mem_ to std::unique_ptr<uint64_t[]>.)
Line 24 of type/vector.hpp, We might change the type of str_ as std::unique_ptr<uint8_t[]>.
Line 17 of common/allocator.hpp. We might change the type of ptrs as std::vector<std::unique_ptr<uint8_t []>>.

And there is also a bug causing alloc-dealloc-mismatch which is too complex for me to find a possible fix. In Line 20 of type/static_field.hpp, a memory block is allocated with new[] but immediately cast to StaticStringField *, and later during destruction of vector(), this is freed using delete. This is due to the type of smart pointer is not completely matched with the allocator, and I cannot figure out a solution.
After figuring out the last bug, I turned off the alloc-dealloc-mismatch check of ASan, so there may be other such bugs.
Thanks for attention :)

Thank you for your feedback! You are right about the memory leak in PageManager::Free. It seems that holding ownership of a memory area with a raw pointer is a bad idea. So I fixed the memory leak by holding the ownership of buffer pages with std::unique_ptr. You may check it again with AddressSanitizer, which I'm not familiar with. The related code of rest issues is actually written by @yfzcsc. I'll check them later.

Types of mem_, str_, and ptrs are also fixed now. As for the last issue, I didn't see the destruction of vector() in destruction of vector().

Types of mem_, str_, and ptrs are also fixed now. As for the last issue, I didn't see the destruction of vector() in destruction of vector().

I just checked for the underlying error of the last issue. In Line 20 of type/static_field.hpp, the memory allocated using new uint8_t[] is cast to StaticStringField* and returned. Then in Line 317 of execution/exprdata.cpp, this memory is managed by std::shared_ptr<StaticStringField>, so it will be released using delete, which causes the mismatch. This cannot fixed by a simple modification, and may require to modify the structure of StaticStringField.

Fixed in https://github.com/iidb/wing/commit/8cf2c85ccb41829be639280a68517ce18346d7d3.


Uncaught (in promise) TypeError: Cannot use 'in' operator to search for 'data' in undefined

Describe the bug
When server-created createResource got read after getting resolved, Uncaught (in promise) TypeError: Cannot use 'in' operator to search for 'data' in undefined error happens on the server.
Your Example Website or App
https://github.com/XiNiHa/solid-relay/tree/feat/ssr-defer
Steps to Reproduce the Bug or Issue

Clone the repo with feat/ssr-defer branch
pnpm i, pnpm build, cd examples/ssr, pnpm dev
Open the index route (with Firefox, as mentioned below)
Refresh the page until the page is broken. (no content after Additional data... fallback goes away) Found that this bug only happens occasionally.
Check the browser console to see the error streamed in.

Expected behavior
I expected the resource to resolve without triggering any errors.
Screenshots or Videos
Expected behavior:
https://github.com/solidjs/solid/assets/8155259/7d14604c-b65e-4cb3-8690-c3de5e67f4e8
Bug happening:
https://github.com/solidjs/solid/assets/8155259/5e40f58a-acaf-41ae-a4ea-472547bffb5a
Platform

OS: macOS (didn't verify with other OSes yet)
Browser: Firefox (verified that Chrome works without any problem, was not able to exactly reproduce in Safari due to streaming SSR not working, but the error didn't happen at least)
Version: 115.0.2 (latest stable at the time)

Additional context
The exact position where the error is happening is here (verified by monkey-patching the code. adding sharedConfig.context!.resources[id] && check before the in prevented the error from happening, but then made another error happen at here by accessing .data in undefined)
Monkey-patching to replace all sharedConfig.context!.resources[id] access in read() to resource resolved the issue.
The bug happens much less frequently in a Private Window.

This is an odd issue. I never reproduced it ever in Chrome, and the only thing that resembled it Firefox it wasn't the same errors you were getting. It was name or metadata of undefined which I couldn't find the code for. And even after applying both fixes I could still reproduce it.

Even stranger is that if we assume you made your first fix, there is no way during synchronous code execution the second issue like you pointed at could error. If your condition prevented it from being resolved how could that branch of the ternary ever execute?
For the browser to make a difference on server code seems highly unlikely unless maybe this something related to the development environment. Did you ever try running this in prod mode (I had no luck it was trying to open up an invalid port)?
Right now I can confirm there is something up, but I can't reproduce the issue you were having or its relation to Solid code.

I had the same error message when instantiating a createResource outside of a component.
const res = createResource(..., { deferStream: true });
const Comp = ()=>{
    return <div>{res()}</div>
}

Oh right, I have a similar one in my code, creating a chained resource in a resource until the fetch settles. Maybe runWithOwner would help here? I'll try that right now...

Oops, turns out that I actually have no code like that 😅 However it feels like I'm somehow reaching the root cause of the issue... I'll keep the further investigation.

I had a similar problem, but it was right after i rebase a branch that modified the pnpm-lock.yaml on anotther branch that contained another modified pnpm-lock.yaml.
I solved by deleting the file and running install again


Dataframe.query regex support

Hi,
I was wondering if I could make a regex query (re.search say) in the query expression.
Dataframe.filter supports it. Is there any particular reason that query does not?

As of now, no function calls are allowed within the query. I suspect that it'd be very difficult to implement. Also the idea of writing regexes inside strings, and all the escaping that would probably be needed doesn't sound fun :)
Do you have a small example in mind? I'm guessing you know about Series.str.match/extract, but you're trying to do something involving multiple columns?

@tanmaig no advantage of doing a regex as it is simply evaluated in pytho space (and cannot use numexpr which backs .query. you should use .str as @TomAugspurger indicates


Merge installation guide

~Depends on #4351~ merged
The main motivation is to prevent dead link as the installation guide is linked from many places.

pfnCI, test this please.

Jenkins CI test (for commit ac1a3e4a058dbc7b7935c09c07df9c2a9a9b3516, target branch master) succeeded!

Jenkins, test this please

Jenkins CI test (for commit f1441fc8f4c58153ef60c654e1faa1d6dc02f8f7, target branch master) failed with status FAILURE.

CI unrelated


Add post install message for upgrading 2.x.x -> 3.x.x

Sample from running against a locally built copy of the last release candidate
$ gem install rails_admin-3.0.0.rc.gem --post-install-message

    ### Upgrading from 2.x.x to 3.x.x ###

    Due to introduction of Webpack/Webpacker support, some additional dependency and configuration will be needed.
    Running `bin/rails g rails_admin:install` will suggest required changes, based on the current setup of your app.

    For a complete list of changes, see https://github.com/railsadminteam/rails_admin/blob/master/CHANGELOG.md

Successfully installed rails_admin-3.0.0.rc
Parsing documentation for rails_admin-3.0.0.rc
Done installing documentation for rails_admin after 0 seconds
1 gem installed

This should help give some more guidance to users upgrading.

Great to have it 👍


[FEATURE] Cluster Metrics Monitor -  Add _cat/shards (Cluster Monitor) and  _cat/indices

Is your feature request related to a problem?
Cluster health metrics is a helpful feature. I want to improve operational uptime. It would be great if cluster health metrics can be extended to support _cat/shards and _cat/indices as that would provide a better picture of my deployment.
What alternatives have you considered?
Grabbing data from performance analyzer
Do you have any additional context?
https://opensearch.org/docs/latest/monitoring-plugins/alerting/monitors/#create-cluster-metrics-monitor

We plan to add this into 2.5

For reference, these are example outputs from those 2 API.
GET _cat/indices
health status index uuid pri rep docs.count docs.deleted store.size pri.store.size
yellow open test-logs1 So2txS5yQ8WSlsejZnOC4A 1 1 10 0 6.1kb 6.1kb
yellow open test-logs0 8gLivpwIS5eo9r-_Y88rOQ 1 1 11 0  17kb  17kb
yellow open test-logs3 nC8ghA7yQzmyD942YeE5hw 1 1 10 0 6.1kb 6.1kb
yellow open test-logs2 MU5wWj7_StuzCd1MsuMZrQ 1 1 10 0 6.1kb 6.1kb
green  open .kibana_1  B5JEspGFQCC4QUFErWc10w 1 0  1 0 5.1kb 5.1kb

GET _cat/shards
index shard prirep state docs store ip node
test-logs0 0 p STARTED    11 17.2kb <IP_ADDRESS> integTest-0
test-logs0 0 r UNASSIGNED
test-logs3 0 p STARTED    10  6.2kb <IP_ADDRESS> integTest-0
test-logs3 0 r UNASSIGNED
test-logs1 0 p STARTED    10  6.2kb <IP_ADDRESS> integTest-0
test-logs1 0 r UNASSIGNED
.kibana_1  0 p STARTED     1  5.2kb <IP_ADDRESS> integTest-0
test-logs2 0 p STARTED    10  6.2kb <IP_ADDRESS> integTest-0
test-logs2 0 r UNASSIGNED

This enhancement was released with v2.9.

Just a heads up - it looks like this blog issue was opened in the wrong repo. Please make sure you're opening blogs in the website-project repo going forward, so they can be tracked.


Updates table columns as per UX mocks/deps 🎡🏖

Fixes https://issues.redhat.com/browse/YARA-142
looks like

@AllenBW YAY! That's awesome! I'd just put a tooltip also in a header where Total matches live as well. And I think that the Last seen in a header should be renamed to the Last scan. But, correct me if I'm wrong.

Here's the status and I think it should have the same name as is in a table > Last status.

That's all! :)

@doruskova yah might want to update the mocks then, none of that was in there

@AllenBW It should be there
https://marvelapp.com/prototype/25g8agj6/screen/75586849
https://marvelapp.com/prototype/25g8agj6/screen/75588121
https://marvelapp.com/prototype/25g8agj6/screen/75588120
I'm just missing the enablement column for signature view. But, I'll update it tomorrow.

Codecov Report

Merging #16 (92876b8) into master (8b51d0c) will not change coverage.
The diff coverage is 0.00%.

:exclamation: Current head 92876b8 differs from pull request most recent head 6db11a4. Consider uploading reports for the commit 6db11a4 to get more accurate results

@@          Coverage Diff           @@
##           master     #16   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files          33      32    -1
  Lines         499     430   -69
  Branches      169     144   -25
======================================
+ Misses        451     392   -59
+ Partials       48      38   -10

Impacted Files
Coverage Δ

src/Components/Common.js
0.00% <0.00%> (ø)

src/Components/SigDetailsTable/SigDetailsTable.js
0.00% <ø> (ø)

src/Components/SigTable/SigTable.js
0.00% <ø> (ø)

src/Components/SysDetailsTable/SysDetailsTable.js
0.00% <0.00%> (ø)

src/Components/SysTable/SysTable.js
0.00% <ø> (ø)

src/Routes/Signatures/Details.js
0.00% <0.00%> (ø)

src/Routes/Systems/Details.js
0.00% <ø> (ø)

src/operations/queries.js
0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b51d0c...6db11a4. Read the comment docs.

@doruskova mo pictures, latest updates

@AllenBW Looks great! Thank you!


Add Foundation API Notes for Swift 3 naming

What's in this pull request?
This pull request adds API notes resulting from an audit of the Foundation module's Swift 3 API by the Foundation team.

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    OS X platform               | @swift-ci Please test OS X platform
    Linux platform              | @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

@swift-ci please test

@swift-ci please test

@swift-ci please test

It looks like the remaining OS X test failure is fixed by 0ecd8e.


$lang_data     who, who are you?

In MentionmemMention.php
	public function getNotificationBody($frequency, $members)
	{
		if (empty($lang_data['suffix']))

No need to see if its empty, it always is.

Same issue exists in QuotedmemMention.php
public function getNotificationBody($frequency, $members)
	{
		if (empty($lang_data['suffix']))```

oops ... here also
MailfailMention.php
	public function getNotificationBody($frequency, $members)
	{
		$keys = array('subject' => 'notify_mailfail_' . $lang_data['subject'], 'body' => 'notify_mailfail_' . $lang_data['body']);

In all cases it would be rename the $frequency to $lan_data... I should really, really test my code a little more! xD

I'll add that to my next PR ... having a little trouble with where those values (body, subject, suffix) are set to anything but null?

Notifications::__construct
The third parameter where is set:
array('subject' => 'subject', 'body' => 'snippet')

where the key is the... key to identify what string we want to set, while the value (e.g. 'snippet') becomes a piece of the key of an entry of $txt e.g.
$txt['notify_new_buddy_snippet']
$txt['notify_new_buddy_body']

Yeah, probably not really straightforward... xD

LOL ... I missed counting commas :innocent:

Yeah.... not very easy to spot all those arrays/functions/whatever... And I wonder if the new arrays notation makes it more easier or harder...


Formatter and linter not working before update

This si the config
	local ft = require("guard.filetype")
	local lint = require("guard.lint")

	ft("python"):fmt({
		cmd = "black",
		args = {
			"--quiet",
			"--stdin-filename",
		},
		stdin = true
	}):lint("pylint")

	require("guard").setup({
		-- -- the only options for the setup function
		 fmt_on_save = true,
		-- -- Use lsp if no formatter was defined for this filetype
		lsp_as_default_formatter = false,
	})

But the linter not

BTW black config doesn't require --stdin-filename arg, and if it did, you'd have to pass fname = true as the last arg to the setup.
Use this instead:
ft("python"):fmt({
cmd = "black",
args = {
"-",
},
stdin = true
}):lint("pylint")

still not working

still not working

Hi! @yebt could you check the following

checkhealth guard to ensure the required binaries are present
au Guard and see if there is an autocmd for the current bufnr(obtainable from echo bufnr("%")
If both of these look fine could you repro with a minimal config(nvim -u min.lua and use vim.o.rtp:append to only load guard)


Example of reading a GRIB file in own project

Proposed Feature
I think it would be useful to add the example script presenting how to use this library to read a GRIB file in own project.
Motivation
As the library code is rather complex, it is not straightforward how to use the library in own project. Moreover, even small libraries include short presentation how to use them. I believe that adding the example script would lower a level of technical knowledge necessary for using this library. Therefore the library could also be used by atmospheric scientists, who might not have as extensive technical knowledge as programmers.
Additional Info
The example script could be included as .rs file in examples folder or as a code snippet in README.

Thank you very much for posting an issue! I agree with your opinion.
At this point, the basic functionalities are still missing, and I am still trying to make various operations possible, so the API is not in a good form yet. I will continue to improve the documentation and example scripts as well as preparing the API.

Thank you very much for posting the issue and I'm sorry that it has taken me so long to respond. I haven't had time to work on the project for a while.
I've prepared two example scripts with plenty of comments and hope that they may help users understand the API. Those scripts will be shipped with the v0.3.0 release tomorrow.
If you'd like to see other examples, please let me know in the issue. Also, since this library's API is still not fully functional and not easy to use, so any suggestions are welcome.


Crash after using "Skill tagged nodes"

debug.txt
Replication steps:
Tag any node by right clicking
Go to Tools > Nodes > Skill tagged Nodes
At this point the program crashes. I have uninstalled and then re-installed the program (at 7PM PST March 2 / 3 AM UTC March 3)

This has been fixed, but it has not been released.


i18n support for scheduler

[ ] update template to handle #1539

[ ] Move strings in template to i18n object
https://github.com/ExactTarget/fuelux/blob/master/templates/handlebars/fuelux/scheduler.hbs

[ ] expose i18n object in control config defaulted with current strings
https://github.com/ExactTarget/fuelux/blob/master/js/scheduler.js#L765

Attaching the proposed design plus a i18n document provided by Kana Standard who consulted with us on the project. The two rows outlined in red represent the proposed changes.

Scheduler.pptx

Here's an updated document with i18n enhancements. Reviewed with @swilliamset.
Scheduler_i18n.pptx

sudo example for label templates
label_template = '{{ on {> drop_down_placeholder }} }}'

if ( exception  ) {
	drop_down_template = ''
}
else {
	drop_down_template = ''
}

label_template.render({
	drop_down_placeholder = drop_down_template;
});

Making control and template i18n friendly is one task. Getting translations back is another.

@swilliamset for your second checkbox, which string in the template need to be in an i18n template? All of them? Or just timezones?


Override block on child collection

Hi,
Any solution to override child collection block ?
Example :
product entity has collection of article entity
and article entity has collection of price entity
First widget works :
{% block _product_articles_entry_widget %}
But how to do for prices ?
{% block _product_articles_prices_entry_widget %}  don't work.
Here the javascript :
`$('.article-collection').collection({
        parent: 'article',
        after_add: function(collection, element) {
          handleNewDomElements();
        },
        allow_up: false,
        allow_down: false,
        children: [{
             selector: '.prices-collection',
             prefix: 'price',
         }]
      });`

Although this is a good question, it is not really related to this plugin but to symfony form rendering.

try _product_articles_entry_prices_entry_widget


[Feature] Add a Join us form

Description
A form with basic details below, join us option for user. Please assign this issue
Screenshots
No response
Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[x] I am a GSSOC'24 contributor.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

@Rakesh9100 please assign this task to me under GSSOC'24. I would love to work on this project's issue and will not disappoint you.

Please assign this task to me under GSSOC'24. I am very much confident that i will solve this isuue in a very good manner.
Thank you.

What exactly are you trying to specify @sau-mili

A form that collects email address to send updates

No need of this, pls create and work on good issues @sau-mili


Eager load relations that have a mirrored 'with' property causes php crash

Laravel Version: 5.3.24
PHP Version: 7.1.6
Database Driver & Version: MySQL 5.6.33

Description:
If you have a model that uses the with property to eager load a relation by default which in turn contains a with property for the requesting model then php crashes. I can only assume it recursive loads each model until it crashes. Unfortunately, there is no log in laravel as php seems to crash.
Steps To Reproduce:
Create two models that have a with property for each other. One being a belongsTo and the other has a hasMany relationship. For example:
<?php

namespace App\Models;

use Illuminate\Database\Eloquent\Model;

class Group extends Model
{
    protected $fillable = [ 'name' ];
    protected $table = 'groups';
    protected $with = ['users'];

    public function users()
    {
        return $this->hasMany(User::class, 'group_id', 'id');
    }
}

<?php

namespace App\Models;

use Illuminate\Database\Eloquent\Model;

class User extends Model
{
    protected $fillable = [ 'name', 'group_id' ];
    protected $table = 'users';
    protected $with = ['group'];

    public function group()
    {
        return $this->belongsTo(Groups::class);
    }
}

I'm not sure if this is a bug, as I think it is expected behaviour, but it might be worth having a check somewhere to see if a model has already been eager loaded.

I've written up your code into a blank laravel app and wrote a test creating the models in question:
public function testEagerLoadWithUserAndGroup()
{
  $groups = factory(App\Group::class, 3)
    ->create()
    ->each(function ($g) {
        $g->users()->save(factory(App\User::class)->make());
    });

  $this->assertNotNull(App\User::first());
}

When running the test I got the following in my console:
[Symfony\Component\Debug\Exception\FatalErrorException]
Allowed memory size of 536870912 bytes exhausted (tried to allocate 4096 bytes)

the following also showed up in my laravel.log file:
[2017-07-07 09:13:24] testing.ERROR: Symfony\Component\Debug\Exception\FatalErrorException:
Allowed memory size of 536870912 bytes exhausted (tried to allocate 4096 bytes)
in C:\laragon\www\laravel-with-crash\vendor\laravel\framework\src\Illuminate\Support\Str.php:71
Stack trace:
#0 {main}

Side point to anyone copy pasting the code from the Steps To Reproduce, small change required in the User class' group() method, Groups::class passed to the belongsTo() method should be changed to Group.

This is pretty much expected behaviour becuase, indeed, the relations get loaded recursively and PHP runs out of memory soon after.
Might be nice to have some sort of check to see if you aren't loading relationship recursively.

@haakym Thanks for writing the test. I have also corrected the typo.
I have tried this on a different machine, but I am still unable to get any log from Laravel as PHP still  crashes.
@RikSomers I agree. I cannot think of a reason that recursive eager loading would be useful, so a check would make sense. Unfortunately I don't know the internals of the framework very well as I just use it like a black box, could someone point me in the right direction to try to implement this fix?

@RikSomers
Thanks. All eloquent models in your app extend Illuminate/Database/Eloquent/Model, so I'm guessing you would want to start there. The with() method which I'm guessing is of importance can be found here: https://github.com/laravel/framework/blob/5.4/src/Illuminate/Database/Eloquent/Model.php#L353
I have been digging around Eloquent myself to see where the check could be added, but probably need to start using a step-through debugger like xdebug to understand what's going on a bit better. I'm currently using tinker to stop at a given point, but unsure how to get it to continue once it stops. You might find it useful to set up a test and add eval(\Psy\sh()); in the framework's code to inspect what's going on, more info here if you're interested https://tighten.co/blog/supercharge-your-laravel-tinker-workflow
If you're a Laracasts subscriber there are some good videos on Eloquent here: https://laracasts.com/series/advanced-eloquent
Found this also in Google in a somewhat related discussion: https://laracasts.com/discuss/channels/eloquent/eager-loading-both-forward-and-inverse-relationship


BQ274xx driver not working correctly

Describe the bug
There is a timing issue with the BQ274xx driver.
Unfortunately timings are poorly documented for the device so I'm unsure about the proper fix but I've gotten it to work at least.
To Reproduce
Build the driver using STM32L452 running at 80MHz.
Since this seems to be timing related it might or might not work with other modules/speeds etc.
Expected behavior
There is a readout of checksum of the data block.
An expected checksum is also calculated, though they are never compared.
Expected to be the same, they are not.
Looking at the data, it is offset by 1 byte.
https://github.com/zephyrproject-rtos/zephyr/blob/f08c44def5fc56f7724664acc6b2e2291911f457/drivers/sensor/bq274xx/bq274xx.c#L498-L510
Impact
I've made a custom driver with a fix, so its not a showstopper for me.
For anyone using else using this driver, no configuration settings will be correct if this bug occurs and you will not know since you get no error.
My current fix is adding a delay (BQ274XX_SUBCLASS_DELAY) at this line:
https://github.com/zephyrproject-rtos/zephyr/blob/f08c44def5fc56f7724664acc6b2e2291911f457/drivers/sensor/bq274xx/bq274xx.c#L491
I can't find any documentation regarding this 5ms delay other than that it is already in this driver.
Logs and console output
Logging the incorrect read block.
[00:00:00.039,780]  bq274xx_custom:
00 80 00 00 81 0e db 0e  a8 07 3a 15 ae 05 3c 0b |........ ..:...<.
b8 00 c8 00 32 00 14 03  e8 01 00 b9 10 04 00 50 |....2... .......P
After adding a delay(correct block):
[00:00:00.049,280]  bq274xx_custom:
40 00 80 00 00 81 0e db  0e a8 07 3a 15 ae 05 3c<EMAIL_ADDRESS>...:...<
0b b8 00 c8 00 32 00 14  03 e8 01 00 b9 10 04 00 |.....2.. ........
Environment (please complete the following information):
Additional context
Custom board using STM32L452 at 80MHz.
Have not tried on a nucleo board.

Can you please submit a PR with a fix?