PHOENIX-6247 Separating logical and physical table names

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m 56s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x-PHOENIX-6247 Compile Tests _

+1 :green_heart:
mvninstall
15m 15s
4.x-PHOENIX-6247 passed

+1 :green_heart:
compile
1m  5s
4.x-PHOENIX-6247 passed

+1 :green_heart:
checkstyle
4m 21s
4.x-PHOENIX-6247 passed

+1 :green_heart:
javadoc
0m 49s
4.x-PHOENIX-6247 passed

+0 :ok:
spotbugs
3m 15s
phoenix-core in 4.x-PHOENIX-6247 has 944 extant spotbugs warnings.

-0 :warning:
patch
3m 22s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 57s
the patch passed

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
cc
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

-1 :x:
checkstyle
4m 23s
phoenix-core: The patch generated 274 new + 14431 unchanged - 167 fixed = 14705 total (was 14598)

+1 :green_heart:
prototool
0m  1s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 47s
the patch passed

-1 :x:
spotbugs
3m 31s
phoenix-core generated 1 new + 944 unchanged - 0 fixed = 945 total (was 944)

_ Other Tests _

-1 :x:
unit
1m 46s
phoenix-core in the patch failed.

-1 :x:
asflicense
0m 10s
The patch generated 1 ASF License warnings.

51m 47s

Reason
Tests

FindBugs
module:phoenix-core

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.PHYSICAL_TABLE_NAME_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 326]

Failed junit tests
phoenix.index.IndexScrutinyMapperTest

phoenix.compile.TenantSpecificViewIndexCompileTest

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1170

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool

uname
Linux eae744c58d36 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x-PHOENIX-6247 / e6d7d0b

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/1/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
453 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/1/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 55s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x-PHOENIX-6247 Compile Tests _

+1 :green_heart:
mvninstall
16m 20s
4.x-PHOENIX-6247 passed

+1 :green_heart:
compile
1m 13s
4.x-PHOENIX-6247 passed

+1 :green_heart:
checkstyle
4m 56s
4.x-PHOENIX-6247 passed

+1 :green_heart:
javadoc
0m 56s
4.x-PHOENIX-6247 passed

+0 :ok:
spotbugs
3m 32s
phoenix-core in 4.x-PHOENIX-6247 has 944 extant spotbugs warnings.

-0 :warning:
patch
3m 39s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
8m  8s
the patch passed

+1 :green_heart:
compile
1m 17s
the patch passed

+1 :green_heart:
cc
1m 17s
the patch passed

+1 :green_heart:
javac
1m 17s
the patch passed

-1 :x:
checkstyle
5m 23s
phoenix-core: The patch generated 206 new + 14898 unchanged - 98 fixed = 15104 total (was 14996)

+1 :green_heart:
prototool
0m  0s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 55s
the patch passed

-1 :x:
spotbugs
3m 39s
phoenix-core generated 1 new + 944 unchanged - 0 fixed = 945 total (was 944)

_ Other Tests _

-1 :x:
unit
283m 10s
phoenix-core in the patch failed.

-1 :x:
asflicense
0m 38s
The patch generated 1 ASF License warnings.

334m 59s

Reason
Tests

FindBugs
module:phoenix-core

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.PHYSICAL_TABLE_NAME_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 326]

Failed junit tests
TEST-[CastAndCoerceIT_6]

phoenix.end2end.TenantSpecificViewIndexIT

phoenix.end2end.index.MutableIndexSplitForwardScanIT

phoenix.end2end.DistinctPrefixFilterIT

phoenix.end2end.CostBasedDecisionIT

phoenix.end2end.IndexBuildTimestampIT

phoenix.end2end.PermissionsCacheIT

phoenix.end2end.PermissionNSEnabledIT

phoenix.end2end.index.IndexMetadataIT

phoenix.end2end.index.MutableIndexExtendedIT

TEST-[InQueryIT_6]

phoenix.end2end.index.ViewIndexIT

phoenix.end2end.index.LocalImmutableNonTxIndexIT

phoenix.schema.stats.TxStatsCollectorIT

phoenix.schema.stats.NonTxStatsCollectorIT

phoenix.end2end.index.DropColumnIT

phoenix.end2end.ParameterizedIndexUpgradeToolIT

TEST-[RangeScanIT_6]

phoenix.end2end.ExplainPlanWithStatsEnabledIT

phoenix.end2end.index.LocalMutableNonTxIndexIT

phoenix.end2end.OnDuplicateKeyIT

phoenix.schema.stats.NamespaceDisabledStatsCollectorIT

TEST-[PointInTimeScanQueryIT_13,columnEncoded=true]

phoenix.end2end.index.GlobalMutableTxIndexIT

phoenix.end2end.BackwardCompatibilityIT

phoenix.end2end.LogicalTableNameIT

phoenix.end2end.UpgradeNamespaceIT

phoenix.end2end.index.GlobalIndexOptimizationIT

phoenix.end2end.PhoenixTTLToolIT

phoenix.tx.TxCheckpointIT

phoenix.end2end.DeleteIT

TEST-[QueryIT_6]

phoenix.end2end.CreateTableIT

TEST-[GroupByIT_6]

phoenix.end2end.TenantSpecificViewIndexSaltedIT

phoenix.end2end.CsvBulkLoadToolIT

phoenix.end2end.UpsertWithSCNIT

phoenix.end2end.index.LocalIndexIT

TEST-[PointInTimeQueryIT_13,columnEncoded=true]

TEST-[CaseStatementIT_6]

TEST-[UngroupedIT_6]

phoenix.end2end.index.IndexWithTableSchemaChangeIT

phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT

TEST-[IntArithmeticIT_6]

phoenix.end2end.UserDefinedFunctionsIT

phoenix.end2end.index.ShortViewIndexIdIT

phoenix.end2end.index.MutableIndexSplitReverseScanIT

phoenix.end2end.index.IndexUsageIT

TEST-[NullIT_13,columnEncoded=true]

TEST-[AggregateQueryIT_6]

phoenix.end2end.PropertiesInSyncIT

phoenix.rpc.UpdateCacheIT

phoenix.end2end.RegexBulkLoadToolIT

phoenix.schema.stats.NamespaceEnabledStatsCollectorIT

phoenix.end2end.SystemCatalogRollbackEnabledIT

phoenix.end2end.index.LocalMutableTxIndexIT

phoenix.end2end.DefaultColumnValueIT

phoenix.end2end.index.LocalImmutableTxIndexIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1170

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool

uname
Linux 42608faefd50 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x-PHOENIX-6247 / e6d7d0b

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/3/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/3/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/3/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
4536 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/3/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x-PHOENIX-6247 Compile Tests _

+1 :green_heart:
mvninstall
15m 35s
4.x-PHOENIX-6247 passed

+1 :green_heart:
compile
1m  8s
4.x-PHOENIX-6247 passed

+1 :green_heart:
checkstyle
4m 28s
4.x-PHOENIX-6247 passed

+1 :green_heart:
javadoc
0m 48s
4.x-PHOENIX-6247 passed

+0 :ok:
spotbugs
3m 15s
phoenix-core in 4.x-PHOENIX-6247 has 944 extant spotbugs warnings.

-0 :warning:
patch
3m 22s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 50s
the patch passed

+1 :green_heart:
compile
1m  6s
the patch passed

+1 :green_heart:
cc
1m  7s
the patch passed

+1 :green_heart:
javac
1m  6s
the patch passed

-1 :x:
checkstyle
4m 30s
phoenix-core: The patch generated 217 new + 14898 unchanged - 98 fixed = 15115 total (was 14996)

+1 :green_heart:
prototool
0m  1s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 47s
the patch passed

-1 :x:
spotbugs
3m 31s
phoenix-core generated 2 new + 944 unchanged - 0 fixed = 946 total (was 944)

_ Other Tests _

-1 :x:
unit
233m 36s
phoenix-core in the patch failed.

-1 :x:
asflicense
0m 37s
The patch generated 1 ASF License warnings.

280m  6s

Reason
Tests

FindBugs
module:phoenix-core

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.PHYSICAL_TABLE_NAME_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 326]

Found reliance on default encoding in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean):in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean): String.getBytes()  At ConnectionQueryServicesImpl.java:[line 2249]

Failed junit tests
phoenix.end2end.RegexBulkLoadToolIT

phoenix.end2end.index.txn.RollbackIT

phoenix.end2end.DistinctPrefixFilterIT

TEST-[RangeScanIT_6]

phoenix.end2end.PermissionsCacheIT

phoenix.end2end.IndexExtendedIT

TEST-[QueryIT_6]

TEST-[IntArithmeticIT_6]

TEST-[NullIT_13,columnEncoded=true]

phoenix.end2end.PermissionNSDisabledWithCustomAccessControllerIT

phoenix.end2end.index.MutableIndexFailureIT

phoenix.util.IndexScrutinyIT

phoenix.schema.stats.NonTxStatsCollectorIT

phoenix.end2end.join.HashJoinLocalIndexIT

phoenix.end2end.IndexToolForDeleteBeforeRebuildIT

phoenix.end2end.ExplainPlanWithStatsEnabledIT

phoenix.rpc.UpdateCacheIT

phoenix.end2end.index.LocalMutableTxIndexIT

phoenix.end2end.DefaultColumnValueIT

phoenix.end2end.index.LocalIndexIT

phoenix.coprocessor.StatisticsCollectionRunTrackerIT

TEST-[GroupByIT_6]

phoenix.end2end.index.MutableIndexExtendedIT

phoenix.end2end.index.MutableIndexSplitForwardScanIT

phoenix.schema.stats.TxStatsCollectorIT

phoenix.end2end.ParameterizedIndexUpgradeToolIT

phoenix.end2end.SystemCatalogRollbackEnabledIT

phoenix.end2end.IndexToolIT

phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT

phoenix.end2end.UserDefinedFunctionsIT

phoenix.end2end.PermissionNSDisabledIT

phoenix.end2end.IndexBuildTimestampIT

phoenix.end2end.FlappingLocalIndexIT

phoenix.end2end.index.IndexWithTableSchemaChangeIT

phoenix.end2end.index.DropColumnIT

phoenix.end2end.CsvBulkLoadToolIT

phoenix.end2end.index.LocalMutableNonTxIndexIT

phoenix.end2end.DeleteIT

phoenix.end2end.join.SubqueryIT

TEST-[AggregateQueryIT_6]

phoenix.end2end.index.MutableIndexIT

phoenix.end2end.LocalIndexSplitMergeIT

phoenix.end2end.join.SortMergeJoinLocalIndexIT

phoenix.end2end.CostBasedDecisionIT

TEST-[UngroupedIT_6]

phoenix.end2end.index.IndexUsageIT

phoenix.tx.TxCheckpointIT

phoenix.end2end.LogicalTableNameIT

phoenix.end2end.index.txn.TxWriteFailureIT

phoenix.end2end.index.LocalImmutableTxIndexIT

phoenix.end2end.index.ImmutableIndexIT

phoenix.end2end.index.ShortViewIndexIdIT

phoenix.end2end.index.MutableIndexFailureWithNamespaceIT

phoenix.end2end.IndexScrutinyToolIT

phoenix.end2end.index.IndexMaintenanceIT

phoenix.end2end.UpgradeNamespaceIT

phoenix.schema.stats.NamespaceEnabledStatsCollectorIT

TEST-[PointInTimeQueryIT_13,columnEncoded=true]

phoenix.end2end.CreateTableIT

phoenix.end2end.join.SubqueryUsingSortMergeJoinIT

phoenix.end2end.EmptyColumnIT

phoenix.end2end.ViewIT

phoenix.end2end.index.MutableIndexSplitReverseScanIT

phoenix.end2end.index.IndexMetadataIT

phoenix.end2end.PermissionNSEnabledIT

TEST-[InQueryIT_6]

phoenix.end2end.PropertiesInSyncIT

phoenix.end2end.index.txn.MutableRollbackIT

phoenix.end2end.UpsertWithSCNIT

TEST-[CastAndCoerceIT_6]

phoenix.end2end.BackwardCompatibilityIT

phoenix.schema.stats.NamespaceDisabledStatsCollectorIT

phoenix.end2end.index.LocalImmutableNonTxIndexIT

phoenix.end2end.index.GlobalIndexOptimizationIT

TEST-[PointInTimeScanQueryIT_13,columnEncoded=true]

phoenix.end2end.OnDuplicateKeyIT

TEST-[CaseStatementIT_6]

phoenix.end2end.AlterAddCascadeIndexIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1170

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool

uname
Linux c038c6209dbc 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x-PHOENIX-6247 / e6d7d0b

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/4/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/4/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/4/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/4/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
4611 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/4/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 11s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x-PHOENIX-6247 Compile Tests _

+1 :green_heart:
mvninstall
14m 58s
4.x-PHOENIX-6247 passed

+1 :green_heart:
compile
1m  5s
4.x-PHOENIX-6247 passed

+1 :green_heart:
checkstyle
4m 27s
4.x-PHOENIX-6247 passed

+1 :green_heart:
javadoc
0m 48s
4.x-PHOENIX-6247 passed

+0 :ok:
spotbugs
3m 18s
phoenix-core in 4.x-PHOENIX-6247 has 944 extant spotbugs warnings.

-0 :warning:
patch
3m 25s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 51s
the patch passed

+1 :green_heart:
compile
1m  7s
the patch passed

+1 :green_heart:
cc
1m  7s
the patch passed

+1 :green_heart:
javac
1m  7s
the patch passed

-1 :x:
checkstyle
4m 32s
phoenix-core: The patch generated 282 new + 14838 unchanged - 158 fixed = 15120 total (was 14996)

+1 :green_heart:
prototool
0m  1s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

-1 :x:
javadoc
0m 47s
phoenix-core generated 1 new + 92 unchanged - 0 fixed = 93 total (was 92)

-1 :x:
spotbugs
3m 29s
phoenix-core generated 2 new + 944 unchanged - 0 fixed = 946 total (was 944)

_ Other Tests _

-1 :x:
unit
235m 19s
phoenix-core in the patch failed.

-1 :x:
asflicense
0m 38s
The patch generated 1 ASF License warnings.

281m 15s

Reason
Tests

FindBugs
module:phoenix-core

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.PHYSICAL_TABLE_NAME_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 326]

Found reliance on default encoding in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean):in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean): String.getBytes()  At ConnectionQueryServicesImpl.java:[line 2249]

Failed junit tests
phoenix.tx.FlappingTransactionIT

phoenix.end2end.PermissionsCacheIT

phoenix.end2end.ParameterizedIndexUpgradeToolIT

phoenix.end2end.index.GlobalImmutableTxIndexIT

phoenix.end2end.SystemCatalogRollbackEnabledIT

phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT

phoenix.end2end.ConcurrentUpsertsWithoutIndexedColsIT

phoenix.end2end.LogicalTableNameIT

phoenix.end2end.index.LocalImmutableTxIndexIT

phoenix.tx.TransactionIT

phoenix.end2end.PermissionNSEnabledIT

phoenix.end2end.BackwardCompatibilityIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1170

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool

uname
Linux 22b707d4b7b9 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x-PHOENIX-6247 / e6d7d0b

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/5/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/5/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-core.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/5/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/5/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/5/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/5/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
4900 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/5/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 24s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 2 new or modified test files.

_ 4.x-PHOENIX-6247 Compile Tests _

+1 :green_heart:
mvninstall
15m 17s
4.x-PHOENIX-6247 passed

+1 :green_heart:
compile
1m  5s
4.x-PHOENIX-6247 passed

+1 :green_heart:
checkstyle
4m 43s
4.x-PHOENIX-6247 passed

+1 :green_heart:
javadoc
0m 47s
4.x-PHOENIX-6247 passed

+0 :ok:
spotbugs
3m 16s
phoenix-core in 4.x-PHOENIX-6247 has 944 extant spotbugs warnings.

-0 :warning:
patch
3m 23s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 49s
the patch passed

+1 :green_heart:
compile
1m  7s
the patch passed

+1 :green_heart:
cc
1m  7s
the patch passed

+1 :green_heart:
javac
1m  7s
the patch passed

-1 :x:
checkstyle
4m 44s
phoenix-core: The patch generated 219 new + 15727 unchanged - 177 fixed = 15946 total (was 15904)

+1 :green_heart:
prototool
0m  1s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

-1 :x:
javadoc
0m 48s
phoenix-core generated 1 new + 92 unchanged - 0 fixed = 93 total (was 92)

-1 :x:
spotbugs
3m 44s
phoenix-core generated 2 new + 943 unchanged - 1 fixed = 945 total (was 944)

_ Other Tests _

-1 :x:
unit
267m 55s
phoenix-core in the patch failed.

-1 :x:
asflicense
0m 39s
The patch generated 1 ASF License warnings.

315m  7s

Reason
Tests

FindBugs
module:phoenix-core

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.PHYSICAL_TABLE_NAME_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 326]

Found reliance on default encoding in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean):in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean): String.getBytes()  At ConnectionQueryServicesImpl.java:[line 2249]

Failed junit tests
phoenix.end2end.index.txn.RollbackIT

phoenix.end2end.PermissionsCacheIT

phoenix.end2end.index.ImmutableIndexExtendedIT

phoenix.end2end.ParameterizedIndexUpgradeToolIT

phoenix.end2end.SystemCatalogRollbackEnabledIT

phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT

phoenix.end2end.LogicalTableNameIT

phoenix.end2end.PermissionNSEnabledIT

phoenix.end2end.BackwardCompatibilityIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1170

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool

uname
Linux 360c98be0118 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x-PHOENIX-6247 / e6d7d0b

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/6/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/6/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-core.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/6/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/6/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/6/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/6/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
5073 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/6/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x-PHOENIX-6247 Compile Tests _

+1 :green_heart:
mvninstall
15m 16s
4.x-PHOENIX-6247 passed

+1 :green_heart:
compile
1m  5s
4.x-PHOENIX-6247 passed

+1 :green_heart:
checkstyle
4m  9s
4.x-PHOENIX-6247 passed

+1 :green_heart:
javadoc
0m 49s
4.x-PHOENIX-6247 passed

+0 :ok:
spotbugs
3m 18s
phoenix-core in 4.x-PHOENIX-6247 has 941 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 46s
the patch passed

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
cc
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

-1 :x:
checkstyle
4m 13s
phoenix-core: The patch generated 201 new + 13820 unchanged - 85 fixed = 14021 total (was 13905)

+1 :green_heart:
prototool
0m  1s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 48s
the patch passed

-1 :x:
spotbugs
3m 37s
phoenix-core generated 3 new + 941 unchanged - 0 fixed = 944 total (was 941)

_ Other Tests _

-1 :x:
unit
199m  2s
phoenix-core in the patch failed.

-1 :x:
asflicense
0m 37s
The patch generated 1 ASF License warnings.

244m 46s

Reason
Tests

FindBugs
module:phoenix-core

Found reliance on default encoding in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.getTable(RegionScanner, long, long, int):in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.getTable(RegionScanner, long, long, int): String.getBytes()  At MetaDataEndpointImpl.java:[line 1237]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.PHYSICAL_TABLE_NAME_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 326]

Found reliance on default encoding in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean):in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean): String.getBytes()  At ConnectionQueryServicesImpl.java:[line 2249]

Failed junit tests
phoenix.end2end.PermissionsCacheIT

phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT

phoenix.end2end.CsvBulkLoadToolIT

phoenix.end2end.LogicalTableNameIT

phoenix.end2end.PermissionNSEnabledIT

phoenix.end2end.BackwardCompatibilityIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/7/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1170

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool

uname
Linux 65ec3e96eabf 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x-PHOENIX-6247 / 410f738

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/7/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/7/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/7/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/7/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/7/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
4672 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/7/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 14s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x-PHOENIX-6247 Compile Tests _

+1 :green_heart:
mvninstall
15m 41s
4.x-PHOENIX-6247 passed

+1 :green_heart:
compile
1m  8s
4.x-PHOENIX-6247 passed

+1 :green_heart:
checkstyle
4m  9s
4.x-PHOENIX-6247 passed

+1 :green_heart:
javadoc
0m 48s
4.x-PHOENIX-6247 passed

+0 :ok:
spotbugs
3m 16s
phoenix-core in 4.x-PHOENIX-6247 has 941 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 50s
the patch passed

+1 :green_heart:
compile
1m  7s
the patch passed

+1 :green_heart:
cc
1m  7s
the patch passed

+1 :green_heart:
javac
1m  7s
the patch passed

-1 :x:
checkstyle
4m 13s
phoenix-core: The patch generated 200 new + 13820 unchanged - 85 fixed = 14020 total (was 13905)

+1 :green_heart:
prototool
0m  1s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 47s
the patch passed

-1 :x:
spotbugs
3m 33s
phoenix-core generated 4 new + 941 unchanged - 0 fixed = 945 total (was 941)

_ Other Tests _

-1 :x:
unit
185m 28s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 38s
The patch does not generate ASF License warnings.

231m 40s

Reason
Tests

FindBugs
module:phoenix-core

Found reliance on default encoding in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.createTable(RpcController, MetaDataProtos$CreateTableRequest, RpcCallback):in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.createTable(RpcController, MetaDataProtos$CreateTableRequest, RpcCallback): String.getBytes()  At MetaDataEndpointImpl.java:[line 1929]

Found reliance on default encoding in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.getTable(RegionScanner, long, long, int):in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.getTable(RegionScanner, long, long, int): String.getBytes()  At MetaDataEndpointImpl.java:[line 1237]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.PHYSICAL_TABLE_NAME_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 326]

Found reliance on default encoding in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean):in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean): String.getBytes()  At ConnectionQueryServicesImpl.java:[line 2249]

Failed junit tests
phoenix.end2end.index.MutableIndexIT

phoenix.end2end.LogicalTableNameIT

phoenix.end2end.BackwardCompatibilityIT

phoenix.end2end.ViewUtilIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/8/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1170

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool

uname
Linux 0ca007e04de6 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x-PHOENIX-6247 / 410f738

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/8/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/8/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/8/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/8/testReport/

Max. process+thread count
4980 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/8/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 13s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x-PHOENIX-6247 Compile Tests _

+1 :green_heart:
mvninstall
14m 57s
4.x-PHOENIX-6247 passed

+1 :green_heart:
compile
1m  8s
4.x-PHOENIX-6247 passed

+1 :green_heart:
checkstyle
4m  6s
4.x-PHOENIX-6247 passed

+1 :green_heart:
javadoc
0m 48s
4.x-PHOENIX-6247 passed

+0 :ok:
spotbugs
3m 16s
phoenix-core in 4.x-PHOENIX-6247 has 941 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 45s
the patch passed

+1 :green_heart:
compile
1m  7s
the patch passed

+1 :green_heart:
cc
1m  7s
the patch passed

+1 :green_heart:
javac
1m  7s
the patch passed

-1 :x:
checkstyle
4m 14s
phoenix-core: The patch generated 232 new + 13806 unchanged - 99 fixed = 14038 total (was 13905)

+1 :green_heart:
prototool
0m  1s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 48s
the patch passed

-1 :x:
spotbugs
3m 30s
phoenix-core generated 5 new + 941 unchanged - 0 fixed = 946 total (was 941)

_ Other Tests _

-1 :x:
unit
192m 18s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 38s
The patch does not generate ASF License warnings.

237m 36s

Reason
Tests

FindBugs
module:phoenix-core

Found reliance on default encoding in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.createTable(RpcController, MetaDataProtos$CreateTableRequest, RpcCallback):in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.createTable(RpcController, MetaDataProtos$CreateTableRequest, RpcCallback): String.getBytes()  At MetaDataEndpointImpl.java:[line 1929]

Found reliance on default encoding in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.getTable(RegionScanner, long, long, int):in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.getTable(RegionScanner, long, long, int): String.getBytes()  At MetaDataEndpointImpl.java:[line 1237]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.PHYSICAL_TABLE_NAME_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 326]

Found reliance on default encoding in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean):in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean): String.getBytes()  At ConnectionQueryServicesImpl.java:[line 2250]

Call to String.equals(org.apache.phoenix.schema.PName) in org.apache.phoenix.schema.MetaDataClient.evaluateStmtProperties(MetaDataClient$MetaProperties, MetaDataClient$MetaPropertiesEvaluated, PTable, String, String)  At MetaDataClient.java:MetaDataClient$MetaPropertiesEvaluated, PTable, String, String)  At MetaDataClient.java:[line 5419]

Failed junit tests
phoenix.end2end.index.txn.RollbackIT

phoenix.end2end.UpsertSelectIT

phoenix.end2end.LogicalTableNameIT

phoenix.tx.TransactionIT

phoenix.end2end.UpsertWithSCNIT

phoenix.end2end.ViewUtilIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/9/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1170

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool

uname
Linux 7122dd8b0d65 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x-PHOENIX-6247 / 410f738

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/9/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/9/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/9/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/9/testReport/

Max. process+thread count
4945 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/9/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
7m 52s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x-PHOENIX-6247 Compile Tests _

+1 :green_heart:
mvninstall
16m 39s
4.x-PHOENIX-6247 passed

+1 :green_heart:
compile
1m 20s
4.x-PHOENIX-6247 passed

+1 :green_heart:
checkstyle
4m 31s
4.x-PHOENIX-6247 passed

+1 :green_heart:
javadoc
1m  2s
4.x-PHOENIX-6247 passed

+0 :ok:
spotbugs
3m 53s
phoenix-core in 4.x-PHOENIX-6247 has 941 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
8m 21s
the patch passed

+1 :green_heart:
compile
1m 25s
the patch passed

+1 :green_heart:
cc
1m 25s
the patch passed

+1 :green_heart:
javac
1m 25s
the patch passed

-1 :x:
checkstyle
4m 48s
phoenix-core: The patch generated 232 new + 13807 unchanged - 99 fixed = 14039 total (was 13906)

+1 :green_heart:
prototool
0m  1s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
1m  2s
the patch passed

-1 :x:
spotbugs
4m 16s
phoenix-core generated 5 new + 941 unchanged - 0 fixed = 946 total (was 941)

_ Other Tests _

-1 :x:
unit
207m 37s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 40s
The patch does not generate ASF License warnings.

266m 28s

Reason
Tests

FindBugs
module:phoenix-core

Found reliance on default encoding in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.createTable(RpcController, MetaDataProtos$CreateTableRequest, RpcCallback):in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.createTable(RpcController, MetaDataProtos$CreateTableRequest, RpcCallback): String.getBytes()  At MetaDataEndpointImpl.java:[line 1929]

Found reliance on default encoding in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.getTable(RegionScanner, long, long, int):in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.getTable(RegionScanner, long, long, int): String.getBytes()  At MetaDataEndpointImpl.java:[line 1237]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.PHYSICAL_TABLE_NAME_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 326]

Found reliance on default encoding in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean):in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean): String.getBytes()  At ConnectionQueryServicesImpl.java:[line 2250]

Call to String.equals(org.apache.phoenix.schema.PName) in org.apache.phoenix.schema.MetaDataClient.evaluateStmtProperties(MetaDataClient$MetaProperties, MetaDataClient$MetaPropertiesEvaluated, PTable, String, String)  At MetaDataClient.java:MetaDataClient$MetaPropertiesEvaluated, PTable, String, String)  At MetaDataClient.java:[line 5419]

Failed junit tests
phoenix.end2end.index.PartialIndexRebuilderIT

phoenix.end2end.index.GlobalMutableTxIndexIT

phoenix.end2end.LogicalTableNameIT

phoenix.tx.ParameterizedTransactionIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/10/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1170

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool

uname
Linux eb20035fa452 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x-PHOENIX-6247 / ee4ce9f

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/10/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/10/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/10/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/10/testReport/

Max. process+thread count
4898 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/10/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m 46s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x-PHOENIX-6247 Compile Tests _

+1 :green_heart:
mvninstall
14m 57s
4.x-PHOENIX-6247 passed

+1 :green_heart:
compile
1m  8s
4.x-PHOENIX-6247 passed

+1 :green_heart:
checkstyle
4m 11s
4.x-PHOENIX-6247 passed

+1 :green_heart:
javadoc
0m 50s
4.x-PHOENIX-6247 passed

+0 :ok:
spotbugs
3m 23s
phoenix-core in 4.x-PHOENIX-6247 has 941 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 55s
the patch passed

+1 :green_heart:
compile
1m  8s
the patch passed

+1 :green_heart:
cc
1m  8s
the patch passed

+1 :green_heart:
javac
1m  8s
the patch passed

-1 :x:
checkstyle
4m  3s
phoenix-core: The patch generated 284 new + 13755 unchanged - 151 fixed = 14039 total (was 13906)

+1 :green_heart:
prototool
0m  1s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 51s
the patch passed

-1 :x:
spotbugs
3m 49s
phoenix-core generated 5 new + 941 unchanged - 0 fixed = 946 total (was 941)

_ Other Tests _

-1 :x:
unit
268m  1s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
1m  4s
The patch does not generate ASF License warnings.

319m 34s

Reason
Tests

FindBugs
module:phoenix-core

Found reliance on default encoding in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.createTable(RpcController, MetaDataProtos$CreateTableRequest, RpcCallback):in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.createTable(RpcController, MetaDataProtos$CreateTableRequest, RpcCallback): String.getBytes()  At MetaDataEndpointImpl.java:[line 1929]

Found reliance on default encoding in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.getTable(RegionScanner, long, long, int):in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.getTable(RegionScanner, long, long, int): String.getBytes()  At MetaDataEndpointImpl.java:[line 1237]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.PHYSICAL_TABLE_NAME_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 326]

Found reliance on default encoding in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean):in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean): String.getBytes()  At ConnectionQueryServicesImpl.java:[line 2250]

Call to String.equals(org.apache.phoenix.schema.PName) in org.apache.phoenix.schema.MetaDataClient.evaluateStmtProperties(MetaDataClient$MetaProperties, MetaDataClient$MetaPropertiesEvaluated, PTable, String, String)  At MetaDataClient.java:MetaDataClient$MetaPropertiesEvaluated, PTable, String, String)  At MetaDataClient.java:[line 5419]

Failed junit tests
phoenix.end2end.QueryDatabaseMetaDataIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/11/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1170

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool

uname
Linux 248aae1f7915 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x-PHOENIX-6247 / ee4ce9f

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/11/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/11/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/11/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/11/testReport/

Max. process+thread count
4786 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/11/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ChinmaySKulkarni - this is a significant revision of how Phoenix approaches metadata naming by @gokceni , would appreciate your opinion as well.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 19s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x-PHOENIX-6247 Compile Tests _

+1 :green_heart:
mvninstall
15m 35s
4.x-PHOENIX-6247 passed

+1 :green_heart:
compile
1m  6s
4.x-PHOENIX-6247 passed

+1 :green_heart:
checkstyle
4m 10s
4.x-PHOENIX-6247 passed

+1 :green_heart:
javadoc
0m 48s
4.x-PHOENIX-6247 passed

+0 :ok:
spotbugs
3m 17s
phoenix-core in 4.x-PHOENIX-6247 has 941 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 47s
the patch passed

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
cc
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

-1 :x:
checkstyle
4m 13s
phoenix-core: The patch generated 232 new + 13807 unchanged - 99 fixed = 14039 total (was 13906)

+1 :green_heart:
prototool
0m  1s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 48s
the patch passed

-1 :x:
spotbugs
3m 32s
phoenix-core generated 5 new + 941 unchanged - 0 fixed = 946 total (was 941)

_ Other Tests _

+1 :green_heart:
unit
200m 50s
phoenix-core in the patch passed.

+1 :green_heart:
asflicense
0m 10s
The patch does not generate ASF License warnings.

244m 39s

Reason
Tests

FindBugs
module:phoenix-core

Found reliance on default encoding in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.createTable(RpcController, MetaDataProtos$CreateTableRequest, RpcCallback):in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.createTable(RpcController, MetaDataProtos$CreateTableRequest, RpcCallback): String.getBytes()  At MetaDataEndpointImpl.java:[line 1929]

Found reliance on default encoding in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.getTable(RegionScanner, long, long, int):in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.getTable(RegionScanner, long, long, int): String.getBytes()  At MetaDataEndpointImpl.java:[line 1237]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.PHYSICAL_TABLE_NAME_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 326]

Found reliance on default encoding in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean):in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean): String.getBytes()  At ConnectionQueryServicesImpl.java:[line 2250]

Call to String.equals(org.apache.phoenix.schema.PName) in org.apache.phoenix.schema.MetaDataClient.evaluateStmtProperties(MetaDataClient$MetaProperties, MetaDataClient$MetaPropertiesEvaluated, PTable, String, String)  At MetaDataClient.java:MetaDataClient$MetaPropertiesEvaluated, PTable, String, String)  At MetaDataClient.java:[line 5419]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/12/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1170

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool

uname
Linux 78b9ec382688 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x-PHOENIX-6247 / ee4ce9f

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/12/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/12/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/12/testReport/

Max. process+thread count
4864 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/12/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 15s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x-PHOENIX-6247 Compile Tests _

+1 :green_heart:
mvninstall
15m 17s
4.x-PHOENIX-6247 passed

+1 :green_heart:
compile
1m  6s
4.x-PHOENIX-6247 passed

+1 :green_heart:
checkstyle
4m 10s
4.x-PHOENIX-6247 passed

+1 :green_heart:
javadoc
0m 49s
4.x-PHOENIX-6247 passed

+0 :ok:
spotbugs
3m 15s
phoenix-core in 4.x-PHOENIX-6247 has 941 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 56s
the patch passed

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
cc
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

-1 :x:
checkstyle
4m 12s
phoenix-core: The patch generated 284 new + 13755 unchanged - 151 fixed = 14039 total (was 13906)

+1 :green_heart:
prototool
0m  1s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 48s
the patch passed

-1 :x:
spotbugs
3m 31s
phoenix-core generated 5 new + 941 unchanged - 0 fixed = 946 total (was 941)

_ Other Tests _

+1 :green_heart:
unit
194m 47s
phoenix-core in the patch passed.

+1 :green_heart:
asflicense
0m 10s
The patch does not generate ASF License warnings.

238m 23s

Reason
Tests

FindBugs
module:phoenix-core

Found reliance on default encoding in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.createTable(RpcController, MetaDataProtos$CreateTableRequest, RpcCallback):in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.createTable(RpcController, MetaDataProtos$CreateTableRequest, RpcCallback): String.getBytes()  At MetaDataEndpointImpl.java:[line 1929]

Found reliance on default encoding in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.getTable(RegionScanner, long, long, int):in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.getTable(RegionScanner, long, long, int): String.getBytes()  At MetaDataEndpointImpl.java:[line 1237]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.PHYSICAL_TABLE_NAME_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 326]

Found reliance on default encoding in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean):in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean): String.getBytes()  At ConnectionQueryServicesImpl.java:[line 2250]

Call to String.equals(org.apache.phoenix.schema.PName) in org.apache.phoenix.schema.MetaDataClient.evaluateStmtProperties(MetaDataClient$MetaProperties, MetaDataClient$MetaPropertiesEvaluated, PTable, String, String)  At MetaDataClient.java:MetaDataClient$MetaPropertiesEvaluated, PTable, String, String)  At MetaDataClient.java:[line 5419]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/13/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1170

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool

uname
Linux 6abf6bf7fa1b 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x-PHOENIX-6247 / ee4ce9f

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/13/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/13/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/13/testReport/

Max. process+thread count
5161 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/13/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m 49s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x-PHOENIX-6247 Compile Tests _

+1 :green_heart:
mvninstall
14m 38s
4.x-PHOENIX-6247 passed

+1 :green_heart:
compile
1m  6s
4.x-PHOENIX-6247 passed

+1 :green_heart:
checkstyle
4m  4s
4.x-PHOENIX-6247 passed

+1 :green_heart:
javadoc
0m 50s
4.x-PHOENIX-6247 passed

+0 :ok:
spotbugs
3m 14s
phoenix-core in 4.x-PHOENIX-6247 has 941 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 51s
the patch passed

+1 :green_heart:
compile
1m  7s
the patch passed

+1 :green_heart:
cc
1m  7s
the patch passed

+1 :green_heart:
javac
1m  7s
the patch passed

-1 :x:
checkstyle
4m 14s
phoenix-core: The patch generated 285 new + 13755 unchanged - 151 fixed = 14040 total (was 13906)

+1 :green_heart:
prototool
0m  1s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 47s
the patch passed

-1 :x:
spotbugs
3m 30s
phoenix-core generated 5 new + 941 unchanged - 0 fixed = 946 total (was 941)

_ Other Tests _

+1 :green_heart:
unit
199m 49s
phoenix-core in the patch passed.

+1 :green_heart:
asflicense
0m 10s
The patch does not generate ASF License warnings.

248m 11s

Reason
Tests

FindBugs
module:phoenix-core

Found reliance on default encoding in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.createTable(RpcController, MetaDataProtos$CreateTableRequest, RpcCallback):in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.createTable(RpcController, MetaDataProtos$CreateTableRequest, RpcCallback): String.getBytes()  At MetaDataEndpointImpl.java:[line 1929]

Found reliance on default encoding in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.getTable(RegionScanner, long, long, int):in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.getTable(RegionScanner, long, long, int): String.getBytes()  At MetaDataEndpointImpl.java:[line 1237]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.PHYSICAL_TABLE_NAME_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 326]

Found reliance on default encoding in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean):in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean): String.getBytes()  At ConnectionQueryServicesImpl.java:[line 2250]

Call to String.equals(org.apache.phoenix.schema.PName) in org.apache.phoenix.schema.MetaDataClient.evaluateStmtProperties(MetaDataClient$MetaProperties, MetaDataClient$MetaPropertiesEvaluated, PTable, String, String)  At MetaDataClient.java:MetaDataClient$MetaPropertiesEvaluated, PTable, String, String)  At MetaDataClient.java:[line 5419]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/14/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1170

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool

uname
Linux 7e7a1ac1aa72 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x-PHOENIX-6247 / ee4ce9f

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/14/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/14/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/14/testReport/

Max. process+thread count
5139 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/14/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  9s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x-PHOENIX-6247 Compile Tests _

+1 :green_heart:
mvninstall
14m 51s
4.x-PHOENIX-6247 passed

+1 :green_heart:
compile
1m  7s
4.x-PHOENIX-6247 passed

+1 :green_heart:
checkstyle
4m  2s
4.x-PHOENIX-6247 passed

+1 :green_heart:
javadoc
0m 49s
4.x-PHOENIX-6247 passed

+0 :ok:
spotbugs
3m 17s
phoenix-core in 4.x-PHOENIX-6247 has 941 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 54s
the patch passed

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
cc
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

-1 :x:
checkstyle
4m 14s
phoenix-core: The patch generated 231 new + 13807 unchanged - 99 fixed = 14038 total (was 13906)

+1 :green_heart:
prototool
0m  2s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 48s
the patch passed

-1 :x:
spotbugs
3m 31s
phoenix-core generated 5 new + 941 unchanged - 0 fixed = 946 total (was 941)

_ Other Tests _

-1 :x:
unit
197m  6s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 39s
The patch does not generate ASF License warnings.

242m 16s

Reason
Tests

FindBugs
module:phoenix-core

Found reliance on default encoding in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.createTable(RpcController, MetaDataProtos$CreateTableRequest, RpcCallback):in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.createTable(RpcController, MetaDataProtos$CreateTableRequest, RpcCallback): String.getBytes()  At MetaDataEndpointImpl.java:[line 1928]

Found reliance on default encoding in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.getTable(RegionScanner, long, long, int):in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.getTable(RegionScanner, long, long, int): String.getBytes()  At MetaDataEndpointImpl.java:[line 1236]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.PHYSICAL_TABLE_NAME_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 325]

Found reliance on default encoding in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean):in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean): String.getBytes()  At ConnectionQueryServicesImpl.java:[line 2250]

Call to String.equals(org.apache.phoenix.schema.PName) in org.apache.phoenix.schema.MetaDataClient.evaluateStmtProperties(MetaDataClient$MetaProperties, MetaDataClient$MetaPropertiesEvaluated, PTable, String, String)  At MetaDataClient.java:MetaDataClient$MetaPropertiesEvaluated, PTable, String, String)  At MetaDataClient.java:[line 5417]

Failed junit tests
phoenix.end2end.UpsertSelectIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/15/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1170

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool

uname
Linux 0d516a1d73d3 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x-PHOENIX-6247 / ee4ce9f

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/15/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/15/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/15/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/15/testReport/

Max. process+thread count
5123 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/15/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Merged to 4.x-PHOENIX-6247 branch. Thanks for the review!

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 44s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x-PHOENIX-6247 Compile Tests _

+1 :green_heart:
mvninstall
15m 59s
4.x-PHOENIX-6247 passed

+1 :green_heart:
compile
1m 12s
4.x-PHOENIX-6247 passed

+1 :green_heart:
checkstyle
4m 34s
4.x-PHOENIX-6247 passed

+1 :green_heart:
javadoc
0m 58s
4.x-PHOENIX-6247 passed

+0 :ok:
spotbugs
3m 36s
phoenix-core in 4.x-PHOENIX-6247 has 941 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
8m 12s
the patch passed

+1 :green_heart:
compile
1m 11s
the patch passed

+1 :green_heart:
cc
1m 11s
the patch passed

+1 :green_heart:
javac
1m 11s
the patch passed

-1 :x:
checkstyle
4m 51s
phoenix-core: The patch generated 286 new + 13755 unchanged - 151 fixed = 14041 total (was 13906)

+1 :green_heart:
prototool
0m  1s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 58s
the patch passed

-1 :x:
spotbugs
3m 47s
phoenix-core generated 5 new + 941 unchanged - 0 fixed = 946 total (was 941)

_ Other Tests _

+1 :green_heart:
unit
222m  0s
phoenix-core in the patch passed.

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

270m 19s

Reason
Tests

FindBugs
module:phoenix-core

Found reliance on default encoding in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.createTable(RpcController, MetaDataProtos$CreateTableRequest, RpcCallback):in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.createTable(RpcController, MetaDataProtos$CreateTableRequest, RpcCallback): String.getBytes()  At MetaDataEndpointImpl.java:[line 1929]

Found reliance on default encoding in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.getTable(RegionScanner, long, long, int):in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.getTable(RegionScanner, long, long, int): String.getBytes()  At MetaDataEndpointImpl.java:[line 1236]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.PHYSICAL_TABLE_NAME_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 325]

Found reliance on default encoding in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean):in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean): String.getBytes()  At ConnectionQueryServicesImpl.java:[line 2250]

Call to String.equals(org.apache.phoenix.schema.PName) in org.apache.phoenix.schema.MetaDataClient.evaluateStmtProperties(MetaDataClient$MetaProperties, MetaDataClient$MetaPropertiesEvaluated, PTable, String, String)  At MetaDataClient.java:MetaDataClient$MetaPropertiesEvaluated, PTable, String, String)  At MetaDataClient.java:[line 5417]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/16/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1170

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool

uname
Linux 163c19ae2705 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x-PHOENIX-6247 / ee4ce9f

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/16/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/16/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/16/testReport/

Max. process+thread count
4868 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/16/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Scoreboard Table

Used test data inserted into the database to populate the scoreboard page with styled table of statistics about each player
Edited the existing /scoreboard frontend api endpoint to query this data from the DB and place it in a readable format

I noticed a few small improvements y'all could make in your code so I'll detail them in the following comments

Also its probably a good idea to change line 12 in your docker-compose.yml to
    ports:
      - "5500:5500"

Since that is the syntax of how you specify what port to expose on the local machine (the 1st port) and what to expose to the other containers internally.

Hope this is helpful and happy coding for the rest of your site!!


Can't start bots after update

Traceback (most recent call last):
  File "run.py", line 163, in main
    m = MusicBot()
  File "/media/dafri/Additional Disk/Main/Dev/Python/Tasher/musicbot/bot.py", line 91, in __init__
    self.headers['user-agent'] += ' MusicBot/%s' % BOTVERSION
  File "/usr/local/lib/python3.5/dist-packages/discord/client.py", line 244, in __getattr__
    raise AttributeError(msg.format(self.__class__, name))
AttributeError: '<class 'musicbot.bot.MusicBot'>' object has no attribute 'headers'

Update your bot.

Oh, found the problem, conflicts in ./musicbot/bot.py when trying to do git pull. I had to reset local repository to remote state..
Yes, I did it! Now all works. Thanks! 😊


Upgrade com.github.johnrengelman:shadow to 8.1.1

@Phone-Guru - Thanks for spotting this out of date version, but I went ahead and did what I was trying to explain. Its tough to follow online docs because they don't really fully show all the ways a plugin works. They don't show buildscript vs runtime dependencies and suffer in groovy vs kotlin.
So we wouldn't really go anywhere just taking the examples online. Unfortunately Gradle has a mix of a lot of old/new docs around.
So take a look at this diff if you are curious what I did - https://github.com/iBotPeaches/Apktool/pull/3259


[WIP]Adding parallelism and scoring

It needs more documentation, creating a pull request with wip to avoid waiting time for Jonathan.

I'll merge, but don't forget to document it.

actually I'll wait for you to remove the [wip], in case there is somethign broken in there.

ok, thank you. It is working ok.


feat: update visual testing methods to work with PIL

Visual testing comparison has changed
| It only needs PIL library to compare images and generate the differences images
| Old PerceptualDiff and Magick engines have been removed
| Config property 'visualtests_engine' in [Server] section has been removed
| Images distance calculation method has changed, it is recommended to review thresholds in tests

Coverage: 80.22% (+8.6%) from 71.578% when pulling 9aa56aa0f01094768ea929e04a453cdfa24025c3 on feat/visual_testing_selenium4 into b552935fee0d2981463bce1c289429d7963741e6 on feat/upgrade_dependencies.


Suggestion: Source Game Update Button

Product
Please check the corresponding boxes below for which products this is about.

[x] Panel
[x] Daemon
[ ] Dockerfile(s) [Please list if so: __ ]

Type

[ ] Bug or Issue
[x] Feature Request
[ ] Enhancement
[ ] Other

Hi.
I was wondering if it would be possible to have a button added which updates a Source Game Server to its latest version and also maybe the option to allow automatic checking for and applying updates for servers as well.
Cheers,
- James

ref #119

closed as #119 handles as well as 0.6.0 in general.


Have BindableNumber support more types

Up until now, BindableNumber<T> was abstract and only implementations of it could be used, of which there were 4 default choices provided by the framework - BindableDouble, BindableFloat, BindableLong and BindableInt.
As of https://github.com/ppy/osu-framework/pull/3089, BindableNumber<T> can now be instantiated, however it only supports the types float, double, int and long. All other types will throw InvalidOperationExceptions: https://github.com/ppy/osu-framework/blob/61cbe268a6656455bbe6ff69515721f7121c5732/osu.Framework/Bindables/BindableNumber.cs#L119-L129
All methods in this class should be updated to support the types defined by the ctor: https://github.com/ppy/osu-framework/blob/61cbe268a6656455bbe6ff69515721f7121c5732/osu.Framework/Bindables/BindableNumber.cs#L24-L33
The exceptions in such methods can then also be removed.

I strongly disagree that this is required in a milestone. We have done without it for now, which suggests the remaining types are likely never going to be used.

I really dislike leaving things in a half-implemented state. That's fine osu! side but it's not the way I'll ever develop o!f.
Either:

Functionality is removed completely.
Functionality is implemented completely.

I don't really see a reason for (1) considering there are a limited amount of integral types (all of which have been covered above). So I tend to (2).


about beam size

beam size, its just a parameter, u can change to any number, if you like, but I recommand you the maximun of beam size is 8


Perf test Distribution Status

Before enabling Distribution Status by default, we need data showing it does not negatively impact control plane perf.  Manual testing is helpful, but automation is desired.

Can you triage this?  P2?


Line Removal Failing When Using -k flag

I'm using Vpype version 1.14.0 and Occult version 0.4.0
Using the Demo.svg file attached, I'm looking to use occult with the -k flag to keep the lines within the mountain shape.
When simply performing Occult across layers, it removes the lines inside the mountain shape; using this command:
vpype read -a id --no-crop 'Demo.svg' occult -i write 'Demo_occult.svg'

But when the -k flag is added, it fails to remove any lines at all, using this command:
vpype read -a id --no-crop 'Demo.svg' occult -i -k write 'Demo_occult.svg'

Hey, thanks for the issue.
vpype read -a id --no-crop 'Demo.svg' occult -i -k show puts the removed lines in a new layer, in this case layer 280.
When you separate layers by id attribute (vpype read -a id), for some reason the resulting file keeps the same stroke color for the lines in layer 280.
Separating layers by stroke attribute  (vpype read -a stroke --no-crop Demo.svg occult -i -k show) will show the removed lines (in this case, layer 3) in a different color.

Is there a max number of layers the -k will work with and output to a new layer/color?
Using the below file works fine by reading in by -a id. I'm struggling to find a small file where it fails like one above.

This one worked correctly as well and I can't seem to figure out why one works and the other doesn't.

Alright, I figured it out. Depending on the number of the layer the -k get's put on, it changes the color. Below the number of layers in each drawing goes 100, 101, 102

So it sounds like I need to manually specify the layer color of the -k lines

Here's my workaround. I perform a check to see if the number of layers has increased, which in this case means that the -k did indeed store lines in a new layer. Then I set that layer color to 'pink'. In my script implementation, instead of pink, I'll randomly generate a color and double check it's not already in use in the file.
vpype read -a id --no-crop 'Demo1.svg' \
eval "%last_color='pink'%" \
forlayer eval "%num_layers=_n%" end \
occult -i -k \
forlayer \
eval "%new_num_layers=_n%" \
eval "%if(new_num_layers<=num_layers):last_color=_color%" \
end \
color -l %new_num_layers% %last_color% \
show


Update SameSite spec to the latest

As Incrementally Better Cookies has been adopted into rfc6265bis-07, this PR updates the related information accordingly.
Related: https://github.com/httpwg/http-extensions/issues/1241.

Thanks!


theming

I see that there a variety of to-do items related to theming.    If so, perhaps it would be good to document it here?
In the meantime, going to read the code to see what's possible.
Thanks!

Hi, thanks for the input. I don't use theming at all at work (which I made the bindings for) so I'm not too familiar with the options and what the focus needs to be on.
Do you have any suggestions on how to tackle the various theming layers?

@mattmarcello I've had the need to use some different colors now as well. The easist thing to do right now would be:
<EMAIL_ADDRESS>"@material-ui/core/styles"]
external createMuiTheme : Js.t({..}) => Js.t({..}) = "createMuiTheme";

let theme =
  createMuiTheme({
    "palette": {
      "primary": {
        "main": "#0096F0",
      },
      "secondary": {
        "main": "#E7414D",
      },
    },
  });

<div className="app-container">
  <MaterialUi_MuiThemeProvider theme=(`ObjectGeneric(theme))>
    /* components... */
  </MaterialUi_MuiThemeProvider>
</div>

It's just that you'll have to write the createMuiTheme binding yourself. I'll close this for now as that is a workable way (I'll probably factor this in somehow soon).

Thanks for following up.


[Bug] System.Reflection.ReflectionTypeLoadException When Running App Center Tests

Description
We have started using AsyncCommand but this is causing an error when running our Xamarin UI tests in App Center that looks like it's related to reflection and type loading.
Our tests are implemented with a .NET 4.6.1 console application.
Steps to Reproduce

Use AsyncCommand with an app.
Run Xamarin UI Tests.

Expected Behavior
Tests should run without an issue.
Actual Behavior
Tests crash with the following error:
System.Reflection.TargetInvocationException : Exception has been thrown by the target of an invocation.
----> System.Reflection.ReflectionTypeLoadException : The classes in the module cannot be loaded.
----> System.TypeLoadException : Xamarin.CommunityToolkit.UI.Views.LazyView`1
at System.Reflection.MonoCMethod.InternalInvoke (System.Object obj, System.Object[] parameters) [0x00014] in <48b95f3df5804531818f80e28ec60191>:0
at System.Reflection.MonoCMethod.DoInvoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0007a] in <48b95f3df5804531818f80e28ec60191>:0
at System.Reflection.MonoCMethod.Invoke (System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00000] in <48b95f3df5804531818f80e28ec60191>:0
at System.Reflection.ConstructorInfo.Invoke (System.Object[] parameters) [0x00000] in <48b95f3df5804531818f80e28ec60191>:0
at BoDi.ObjectContainer.CreateObject (System.Type type, BoDi.ObjectContainer+ResolutionList resolutionPath, BoDi.ObjectContainer+RegistrationKey keyToResolve) [0x000a5] in :0
at BoDi.ObjectContainer+TypeRegistration.Resolve (BoDi.ObjectContainer container, BoDi.ObjectContainer+RegistrationKey keyToResolve, BoDi.ObjectContainer+ResolutionList resolutionPath) [0x00045] in :0
at BoDi.ObjectContainer.ResolveObject (BoDi.ObjectContainer+RegistrationKey keyToResolve, BoDi.ObjectContainer+ResolutionList resolutionPath) [0x000ad] in :0
at BoDi.ObjectContainer.Resolve (System.Type typeToResolve, BoDi.ObjectContainer+ResolutionList resolutionPath, System.String name) [0x0001f] in :0
at BoDi.ObjectContainer.Resolve (System.Type typeToResolve, System.String name) [0x00007] in :0
at TechTalk.SpecFlow.Infrastructure.TestObjectResolver.ResolveBindingInstance (System.Type bindingType, BoDi.IObjectContainer container) [0x00000] in <0632ccd8174f45f48c6a5cc58a7930f6>:0
at TechTalk.SpecFlow.ScenarioContext.GetBindingInstance (System.Type bindingType) [0x0000d] in <0632ccd8174f45f48c6a5cc58a7930f6>:0
at (wrapper dynamic-method) System.Object:lambda_method (System.Runtime.CompilerServices.Closure,TechTalk.SpecFlow.Infrastructure.IContextManager)
at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (System.Reflection.MonoMethod,object,object[],System.Exception&)
at System.Reflection.MonoMethod.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00032] in <48b95f3df5804531818f80e28ec60191>:0
at TechTalk.SpecFlow.Bindings.BindingInvoker.InvokeBinding (TechTalk.SpecFlow.Bindings.IBinding binding, TechTalk.SpecFlow.Infrastructure.IContextManager contextManager, System.Object[] arguments, TechTalk.SpecFlow.Tracing.ITestTracer testTracer, System.TimeSpan& duration) [0x000e6] in <0632ccd8174f45f48c6a5cc58a7930f6>:0
at TechTalk.SpecFlow.Infrastructure.TestExecutionEngine.ExecuteStepMatch (TechTalk.SpecFlow.Bindings.BindingMatch match, System.Object[] arguments) [0x00076] in <0632ccd8174f45f48c6a5cc58a7930f6>:0
at TechTalk.SpecFlow.Infrastructure.TestExecutionEngine.ExecuteStep (TechTalk.SpecFlow.Infrastructure.IContextManager contextManager, TechTalk.SpecFlow.Bindings.StepInstance stepInstance) [0x00089] in <0632ccd8174f45f48c6a5cc58a7930f6>:0
at TechTalk.SpecFlow.Infrastructure.TestExecutionEngine.OnAfterLastStep () [0x001f7] in <0632ccd8174f45f48c6a5cc58a7930f6>:0
at TechTalk.SpecFlow.TestRunner.CollectScenarioErrors () [0x00000] in <0632ccd8174f45f48c6a5cc58a7930f6>:0
at MyApp.Bdd.Features.UnderstandingTheApp.SecurityOnboardingFeature.ScenarioCleanup () [0x00000] in :0
at MyApp.Bdd.Features.UnderstandingTheApp.SecurityOnboardingFeature.SelectingThroughOnboarding () [0x0006c] in :0
at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (System.Reflection.MonoMethod,object,object[],System.Exception&)
at System.Reflection.MonoMethod.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00032] in <48b95f3df5804531818f80e28ec60191>:0
--ReflectionTypeLoadException
at (wrapper managed-to-native) System.Reflection.Assembly:GetTypes (System.Reflection.Assembly,bool)
at System.Reflection.Assembly.GetExportedTypes () [0x00000] in <48b95f3df5804531818f80e28ec60191>:0
at Xamarin.UITest.Shared.TestCloud.ReflectionScreenshotTaker.FindScreenshotType (System.String screenshotTypeName) [0x00049] in :0
at Xamarin.UITest.Shared.TestCloud.ReflectionScreenshotTaker..ctor (System.String screenshotTypeName) [0x00011] in :0
at Xamarin.UITest.Shared.TestCloud.TestCloudNunitExtensionManager.CreateScreenshotTaker () [0x00000] in :0
at Xamarin.UITest.iOS.iOSApp..ctor (Xamarin.UITest.Configuration.IiOSAppConfiguration appConfiguration, Xamarin.UITest.Shared.Execution.IExecutor executor) [0x00112] in :0
at Xamarin.UITest.iOS.iOSApp..ctor (Xamarin.UITest.Configuration.IiOSAppConfiguration appConfiguration) [0x00000] in :0
at Xamarin.UITest.Configuration.iOSAppConfigurator.StartApp (Xamarin.UITest.Configuration.AppDataMode appDataMode) [0x00017] in :0
at MyApp.Testing.Bdd.Engine.BddEngine.CreateUiTestApp () [0x000e6] in <36679f34224044af9612d19889fd4e81>:0
at MyApp.Testing.Bdd.Engine.BddEngine.CreateAutomator () [0x00000] in <36679f34224044af9612d19889fd4e81>:0
at MyApp.Testing.Bdd.Engine.BddEngine.CreatePageObjectModel[T] () [0x00019] in <36679f34224044af9612d19889fd4e81>:0
at MyApp.Bdd.Features.UnderstandingTheApp.SecurityOnboardingStepDefs..ctor (MyApp.Testing.Bdd.Engine.IBddEngine engine) [0x0000d] in :0
at (wrapper managed-to-native) System.Reflection.MonoCMethod:InternalInvoke (System.Reflection.MonoCMethod,object,object[],System.Exception&)
at System.Reflection.MonoCMethod.InternalInvoke (System.Object obj, System.Object[] parameters) [0x00002] in <48b95f3df5804531818f80e28ec60191>:0
--TypeLoadException
Basic Information

Version with issue: 1.2.0
Last known good version: This is the first version we've used.
IDE:
Platform Target Frameworks:

iOS:  12.0
Android: SDK 29
UWP:

Android Support Library Version:
Nuget Packages:
Affected Devices:

Reproduction Link

@benwalpole can you provide a snippet of the code that's failing or a small repro?

The code thats failing isn't actually using the toolkit as it's our UI tests.
From the stack trace it looks like Xamarin UI Tests ends up reflecting on the app assembly and not being able to load the type Xamarin.CommunityToolkit.UI.Views.LazyView`1.
Could this be a missing dependency of that type?

I presume that in any place of your app you're using the LazyView right? If you try to run the UI Test steps manually do you see the failure?

No, the only class we are using from the Toolkit is AsyncCommand.
I don't seem to get the error locally, I think this might be because in the the stack trace it looks like the error happens during the taking of screenshots.

Are you using any linker locally or during tests?


Feedback 'From: orta therox Scrolling fast on iPad Artsists'

Message from Orta Therox sent on 2016-05-24 02:09:17 UTC###

From: orta therox
Scrolling fast on iPad Artsists

Link to HockeyApp

https://rink.hockeyapp.net/manage/apps/37020/feedback/555175

This actually isn't a bug, weirdly it was that the works looks like they were broken, cause that was the work

Can you rephrase this? I don’t understand what the original problem was nor what your follow-up explanation is trying to say.


Adds validator for email addresses.

This adds a dependency (the same used by Symfony and Laravel) and exposes dependency classes as parameters to the attribute. Let me know if you want to make adjustments to any of that.
Related to #3.

Looks good 👍


[opentitantool] Refactor image manifest update command

Description
We need to refactor image manifest update to make sure we get consistent updates to the manifest structure without accidentally overwriting fields like signed_region_end, etc.
From https://github.com/lowRISC/opentitan/pull/18869/commits/91dc6ff6faec114bf5d81d752106fd0c2dbd4be3#r1225349309:
"""
I think we'll need to revisit this file soon because it's too opinionated about the order of operations and what the parameters mean. To be clear, the situation was probably not ideal before these changes but I wouldn't call any of these changes as bug fixes since the previous implementation was also working as designed. The new changes make this work for a particular order of operations and set of parameters but would probably be surprising for other cases. I'm not requesting any changes to this PR but consider for example

(for a negative test) adding the SPHINCS+ signature without the public key -> IIUC this will fail
imagine we introduce another signed extension and set it in a different invocation of opentitantool. IIUC signed_region_end would not be updated.
Since adding the SPHINCS+ key adds a null SPHINCS+ signature extension, we cannot really test the other negative case where we have the key extension but signature extension is missing.
"""

#18893


Content of the message input field aligned to center

Fixes: #320

YES

@abhijeet007rocks8 @DhairyaBahl please review.


Misc. feedback - Paint Editor Internal Playtest 7/6/17

Scratch+ prototype
From @jwzimmer:

I do feel like I'm getting the hang of grouping/ ungrouping pretty quickly, and the way the wizard sprite is grouped by default is super helpful

From @chrisgarrity:

No undo yet :( - Nope, just didn't see it in the menu (UI)

From @paulkaplan:

Question: should unlocked scaling be the default (with shift to lock) or should it be the other way around?

Scratch 2.0 Editor
Reported by Tom:

When the ellipse tool is first selected the option for outline or filled ellipse does not exist, but it appears while you are dragging out an ellipse and disappears again as soon as you let go of the ellipse you were creating. Just tapping with the ellipse tool will cause the option to appear, but it will disappear again as soon as you make an ellipse.

Steps to Repro:

Select the ellipse tool and make an ellipse

Chrome, ChromeOS


Added calculate dividend yield ratio

issue #36

@nikhil25803 check now , i have updated the endpoint.md


Fix time format RFC 3339 to not include offset seconds

Fixes #7489
This still allows parsing offset seconds even if seconds are not specified in RFC 3339. I think it's better to be a bit lenient here to be able to parse values even if they're not 100% correct according to the spec.

Yeah, I never saw seconds in time offset...

You're right. format_seconds = true was a mistake. There is not really any practical use of a time zone offset in seconds.

This fix would be a low-hanging fruit. @ysbaddaden Do you think the implementation is okay to merge?

If we want to release 0.28.0 soon I'd say let's merge this. We can worry about low-level API details later on. It's better if we don't include offset seconds in the next release.

GTG?


Add rolling computations for dask.dataframe

Fixes #487.

@cpcloud can you give this a quick check for Pandas correctness?

Ok, I think this is good to go now.

LGTM


Adding intelli wait

Description
Initial commit with moving IntelliWait into a generic repo

Also please add your namespace and what it does to the README.MD file.


Add filterClamp to KawaseBlur calculation

The KawaseBlur filter is not blurring the right and bottom side/edges
correctly as the blur will "bleed" and create black edges. By using filterClamp in the
calculation the bleed will not occur.
This can easily be seen by going to the demo, enable KawaseBlurFilter and looking at the right side and bottom side.
The error:

After fix:

filterClamp solution from  @ivanpopelyshev

I think the filterClamp should be an option.
always do filterClamp may not apply to all use case.

Padding isnt helping. And clamping is nothing compared to 4 samplers.

@ivanpopelyshev  , I mean that   Padding could make 4 sides with transparent-blur-edge , not only right & down.

That's right, but if your filterArea is less than filtered element, it might be a problem.

@finscn When is this side-effect wished for when using a blur? I don't understand why it might be an issue.

Here are two examples using this PR and the current KawaseBlurFilter with a filterArea being set. As you can see there's a significant visual difference between the two.
I mostly agree with @finscn here. I think KawaseBlurFilter should work like BlurFilter. Without the ability to opt-in/out of clamping, this change makes it not an analogous replacement for BlurFilter. Seems more flexible without clamping. What do you guys think?

@bigtimebuddy I can now see what you mean and I understand your point. Nice illustrations of the filters.
How about giving the possibility to use it, with the default being off? This way replacement for BlurFilter will work and at the same time allow clamping of it.

Good idea, I like that.

I would like to add this to v2.6.0. If you can work on it soon let me know, otherwise, I'll make the release and we'll address in the next release.

@bigtimebuddy I can fix it tonight (in approx 16 hours~). Is that fine by you?

@nikkop , I have a suggestion.
Don't add   if ... else ... to shader, it will breakdown performance.
change the source string of shader in JS, please.

Works for me @nikkop. Thanks for your help! I think @finscn's suggestion is a good one, and to try to avoid if/else statements in the shaders.

@finscn @bigtimebuddy Do you guys mean having two shaders (one with clamp and one without) and depending on the value passed for clamping (true/false) choose the appropriate shader?

I think @finscn was suggesting doing something like https://github.com/pixijs/pixi-filters/blob/master/filters/godray/src/GodrayFilter.js#L30 where you replace the string. But it might be cleaner to have to separate frag files, one for clamped and one unclamped and have an option to choose.

@nikkop any movement on this? If not, no worries, I'm happy to make these changes if you're busy. Let me know. I'm eager to get v2.6.0 out the door.

@bigtimebuddy Pardon me, I was busy last night and couldn't make it. It's absolutely fine by me if you would do it, I would even prefer it as I then can see how the implementation with the two shaders take place :) Do you mind?

Don't forget that the BlurFilter also needs this feature.


[vi] Linear Algebra

Finished my translation to Vietnamese in topic Linear Algebra.
Need to review.

Awesome work @tuanhm2911! Now, let's start the review process.

Thanks a lot everyone for all your work! Moving forward with the merge.