[BUG] Custom HTML tag loses end angle bracket on delete

VSCode Version: 1.41.1
OS Version: Linux Mint 19.3

Steps to Reproduce:

Create an HTML file with the following custom HTML tag in it. (I pulled this one from my Angular project, but this bug is not Angular specific. Please note that I only see that custom HTML components are affected by this bug.) Code: <app-server-element *ngFor="let serverElement of serverElements"></app-server-element>
While the bug happens without any attributes on it, it makes it easier to see with having at least one attribute on it. Be sure to keep it in place.
Position your cursor directly after <app-server-element and you should see VS Code highlight all of the angle brackets for that tag.
Press "delete" on your keyboard. (Backspace DOES NOT trigger the bug!)
You'll see that it deletes the space next to your cursor position, but it also has an off-by-one bug that removes the ending angle bracket at the very end of the completed tag. The end result will be: <app-server-element*ngFor="let serverElement of serverElements"></app-server-element <-- Notice the lack of an angle bracket here.

The reason why this bug is so important is that when I refactor long lines of HTML code, I usually start by deleting the space after the tag name, then I hit enter to move the attribute to a new line. I repeat that process for each attribute.

Does this issue occur when all extensions are disabled?: Yes
EDIT:
Just a quick follow up on this topic: there's also a related bug that I want to address. It also relates to improper parsing of a custom HTML tag. When you go to add an attribute to the custom HTML element, it adds the attribute inside of the end tag as well.
To reproduce:

In a blank HTML document, type: <app-odd></app-odd>.
Now, position your cursor after the opening tag such that you can add an element. You MUST paste it in, including the preceding space, as typing it in manually will not trigger the bug!
Add an attribute such as the following: <app-odd [number]="incrementTick"></app-odd>
Instead of seeing the attribute get added like the one in step 3, it'll show up as <app-odd [number]="incrementTick"></app-odd [number]="incrementTick">

EDIT 2:
This issue is also present when pasting in an attribute on a NON-custom HTML element. For example, the creation of <p *ngSwitchCase="10">Value is 10</p *ngSwitchCase="10">

Ran into this too. Setting editor.matchBrackets to never has no affect on the behavior either.

Duplicate of #87067. Sorry about that.
You can now either press ESC before running paste, or turn it off by html.mirrorCursorOnMatchingTag.

@octref Cool. I'm glad my edit stuff is already getting discussed in another thread, the original issue isn't getting discussed there. If I remove the edit sections from my OP, will you reopen this issue and remove the "duplicate" tag?

@rickmacgillis That's the expected behavior of multiple cursors. You have two cursors. Pressing delete would delete a character after each cursor.
If you don't like VS Code adding a cursor for you, you can turn this feature off.

@octref So that's the intended behavior?

This is consistent with all multi-cursor actions:

With the current implementation, fixing this will only add more "magic" to the whole mirror cursor, and makes it less understandable. You can follow https://github.com/microsoft/vscode/issues/88424, which would eliminate this problem once implemented.
I can't make the editor delete only one character when two cursors are present. Other people will be unhappy.

@octref It doesn't matter to me who's name is attached to the ticket that got it fixed. I'm only interested in having it fixed. So, if your ticket stops the bug (yes, it's a bug) then I'm happy with it.


Proxy auth

Please support --proxy-auth like --auth instead of relying on username@password in the proxy URL. This should allow us not to have to put our password in the command-line, or have to script out usage of read to get equivalent functionality, as well as hopefully just work when password characters are not valid in the URL syntax.

Hello, has anyone started working on this? I would like to give it a try


Multiple Version Deployment

Requirement
the module should be able to be deployed in a FLP context with multiple versions on a single app.
As in:

App1 --> ui5-excelUpload v0.1.0
App2 --> ui5-excelUpload v0.2.5
App3 --> ui5-excelUpload v0.1.1
App4 --> ui5-excelUpload v0.1.0

Challenge
The problem is currently that the namespaces in the FLP collide.
That means when a user calls App1 the module is called with v0.1.0 and the namespace thirdparty.customControl.excelUpload.
If the user calls App1 afterwards the module will not be loaded again because the namespace is the same.
That means the modules should be in the namespace of the app.
The ui5-tooling-modules for example does this with the parameter addToNamespace but only with non-ui5 modules.

First idea would be to use stringreplacer like:
cc.excelUpload.$${version}

The idea was first to use the "ui5-task-stringreplacer". But this didn't work so well with "ui5-tooling-modules" and other files (like ui5.yml) had to be edited.
So I built my own stringreplacer which runs before the actual "ui5 build".
In all files where the namespace occurs there is either the variable "XXXnamespaceXXX" or the variable "XXXnamespaceSlashXXX" (slash instead of dots in the version).
e.g. in Component.js it is
"UIComponent.extend("cc.excelUpload.XXXnamespaceXXX.Component", {"
Which will be
UIComponent.extend("cc.excelUpload.v0.4.0.Component", {
I am developing my custom control normally. Once I'm done and have everything committed I start the npm publish process e.g. with "npm version patch".
This will do the following:

update the module version e.g. 0.4.0. to 0.4.1.
copy the folder "src" to "webapp
get the current version number from package.json
replace all namespace variables in the folder webapp
replace the variable in ui5.yml
replace the variable in the test applications for the wdi5 tests
start the ui5 build with ui5-tooling-modules (for xlsx)
create changelog with conventional-changelog-cli

I tried this process and a commit looks like this (npm publish is then automatic via the github workflow.).
You can see the endresult (dist folder and ui5.yml) in the published npm module .
The implementation can be seen here in my test applications for ODataV2/V4 or in the documentation.

As an additional feature, it is possible to deploy the component centrally in a system.
The short tutorial has been documented here:
https://marianfoo.github.io/ui5-cc-excelUpload/pages/CentralDeployment/
There is a template yaml file that is always updated with the latest version:
https://github.com/marianfoo/ui5-cc-excelUpload/blob/main/ui5-deploy.yaml
Basically, I am satisfied with the approach and would close the issue.


Updates react native to 0.34 and cleans up the dev menu

[ ] qr code scanning is busted on ios 10. This happens on master. They've fixed some stuff but its still flakey. See https://github.com/lwansbrough/react-native-camera/issues/426
[x] android works
[x] removed some unneeded android overlay intent stuff
[x] iOS works
[x] iOS changed all the swift code to objc so its closer to its RN counterpart. Also used some new RN helpers to cleanup the bundle location code. Removed the bridging test code and also the native devmenu stuff (we haven't used that in awhile)

@keybase/react-hackers

Looks good other than the two comments above!

Shrink wrap was a mistake. I'll fix that tomorrow.
The key listener events still exist (just moved) so the code in js should
stay. We could remove the native dev settings from the code base. I'll
investigate that also.
On Wednesday, September 28, 2016, Max Goodman<EMAIL_ADDRESS>wrote:

Looks good other than the two comments above!
—
You are receiving this because you authored the thread.


EACCES: permission denied, open 'flightbooking.pdf

In my localhost environment, everything is functioning correctly. Additionally, about 4-5 days ago, the live server, which utilizes NGINX, was also successfully operating without any issues. However, following updates made to unrelated modules' code, a problem arose. It's important to note that these changes were not associated with Puppeteer or the PDF generation system.
Despite the functionality working well locally and previously on the live server, the recent updates to other modules triggered an error in the live environment. It's noteworthy that these alterations did not directly involve the Puppeteer functionality or the process responsible for generating PDFs.
getting error
{
"success": 0,
"message": "EACCES: permission denied, open 'flightbooking.pdf'",
"status": 500,
"data": {}
}

Please do not re-post the same issue. This is not a bug with Puppeteer but a permissions problem. Post a question on StackOverflow if you need help debugging.

ok


Problem when creating a local user in a NAV Container

Hi all,
When we create a NAV Container using New-NavContainer, we specify a username and password. This user is created as local user in the container as well as Nav user with the appropriate rights. So far so good. But if we want to add the same user, with the same password to a container (where the user does not exist), we receive an error saying "Unable to update the password. The value provided for the new password does not meet the length, complexity, or history requirements of the domain." when we use the command New-LocalUser in the container. This problem is for some users, not for all.
Any suggestions on how to fix this? Thx!

The answer is as the system says.. Your password is not good enough.

Yes, in the latest generic image (meaning all future containers), the local user is only created when running Windows auth - but for now - you need to create a better password - example: P@ssword1


/etc/pve is completely empty

I run your script and I am not getting the point: the folder /etc/pve is completely empty in the file:
proxmoxetc.2023-03-<IP_ADDRESS>.tar
I followed your wiki and while all other folders are ok, this one - quite important I believe - is empty
what am I doing wrong?

but when I enter the below commands manually:
cd /
tar cfz etc.tar.gz etc

I get the file with everything from etc, including /etc/pve as well

I don't use the script anymore since we implemented PBS based backup of the PVE cluster config. Still waiting for the proxmox team to actually integrate PBS backup for PVE cluster config/database as they announced.
Did you run the script with proper permission? /etc/pve is only accessible with root.

of course as root

Same problem here. Also no symlinks for the files in pve.
lrwxr-xr-x 1 root www-data    0 Jan  1  1970 qemu-server -> nodes/atlas/qemu-server
lrwxr-xr-x 1 root www-data    0 Jan  1  1970 openvz -> nodes/atlas/openvz
lrwxr-xr-x 1 root www-data    0 Jan  1  1970 lxc -> nodes/atlas/lxc
lrwxr-xr-x 1 root www-data    0 Jan  1  1970 local -> nodes/atlas
nodes folder is missing.

@DerDanilo  said he is not maintaining this anymore ;-)

remove
--one-file-system from
https://github.com/DerDanilo/proxmox-stuff/blob/master/prox_config_backup.sh#L128
and
https://github.com/DerDanilo/proxmox-stuff/blob/master/prox_config_backup.sh#L130

@Fma965 Excellent! I wonder if this script ever worked (without your amendments) to copy /etc/pve. Would seem an oversight by the original @DerDanilo . I wonder why he added  --one-file-system at all. He must have had a good reason, I imagine.
Have never restored (yet!).  Would like to try someday - to see if it really works!

The script worked at some point. And yes, it actually copied the files in /etc/pve. It was intended to backup single node setups. If I remember correctly (and I may be wrong) single node systems don't have a mounted filesystem at /etc/pve.

This is correct although it's still odd that that parameter was added, especially if you never used a cluster 🤔

I don't even remember the time I wrote the script. I must have had a reason for it. :)

I don't even remember the time I wrote the script. I must have had a reason for it. :)

Haha, I know that feeling! 😉

I don't even remember the time I wrote the script. I must have had a reason for it. :)

Happens to me all the time - if there is a time-gap when relooking at any script!
Anyway thanks again.


Removing dicttoxml dependency

Fixes #1229

Coverage decreased (-0.06%) to 92.485% when pulling 867fc3b7f7c6a53cba4249b1c1485c6c092e6b3f on JackDanger:jack/remove-dicttoxml into fd134034fad4f2701f02efe31cb0d7f4fe404a06 on spulec:master.

Coverage increased (+0.004%) to 92.552% when pulling 95a4bd5a7b4d73de8efcc2834b5543a3baef26cc on JackDanger:jack/remove-dicttoxml into fd134034fad4f2701f02efe31cb0d7f4fe404a06 on spulec:master.


Transport params

Hai @GrumpyOldTroll @MaxF12
root@ubuntu:/tmp# python3 /tmp/aioquic-main_mc/aioquic-main/examples/http3_server.py --certificate /tmp/aioquic-main_mc/aioquic-main/tests/ssl_cert.pem --private-key /tmp/aioquic-main_mc/aioquic-main/tests/ssl_key.pem -v
Traceback (most recent call last):
File "/tmp/aioquic-main_mc/aioquic-main/examples/http3_server.py", line 14, in
from aioquic.asyncio import QuicConnectionProtocol, serve
File "/usr/local/lib/python3.8/dist-packages/aioquic/asyncio/init.py", line 1, in
from .client import connect  # noqa
File "/usr/local/lib/python3.8/dist-packages/aioquic/asyncio/client.py", line 8, in
from ..quic.connection import QuicConnection
File "/usr/local/lib/python3.8/dist-packages/aioquic/quic/connection.py", line 56, in
from ..multicast import do_join
File "/usr/local/lib/python3.8/dist-packages/aioquic/multicast.py", line 1, in
import multicast_glue
ModuleNotFoundError: No module named 'multicast_glue'
am i missing anything here
Thank you.

Sorry about this PR, it was intended to go into https://github.com/MaxF12/aioquic and not here, I closed it as soon as I realized my mistake.  We're using that fork to experiment with draft-jholland-quic-multicast, but it's still far from ready, and I clicked the wrong thing when trying to add to that fork.
If you're interested in working on that one, you'd need to install libmcrx and do the "pip install -e .", with the instructions that are so far only in the MacOS section of the README.
But if you're trying to sanity-check this PR for the upstream project, please disregard. That was a mistaken PR, and sorry to have troubled you.  Maybe at some point when we think it appropriate we'll look to merge the extension, but not this month.

Thank you for replying back.
First i tried to raise an issue with the  https://github.com/MaxF12/aioquic but as a fork i was unable to do .
Could you please confirm if i install libmcrx ,then would the mc_server.py & mc_client.py work on Ubuntu machine?
Thank you

I hadn't yet tried it on ubuntu, but I just went ahead on 20.04 and it ultimately worked for me.  But while trying to get it running I hit a few problems whose solutions aren't yet documented:

had to set LD_LIBRARY_PATH in order to load my sandboxed libmcrx build
had a dependency problem with werkzeug and flask and httpbin
wheel wasn't there by default, which gave some errors

So my full process to bring it up I think would be matched by this sequence:
sudo apt install libssl-dev python3-dev
LOCALD=${HOME}/sandbox/local
mkdir -p ${LOCALD}
cd ${HOME}/sandbox
git clone https://github.com/GrumpyOldTroll/libmcrx
cd libmcrx
./autogen.sh
./configure --prefix=${LOCALD}
make && make install
cd ..
python3 -m venv qmc
source qmc/bin/activate
git clone https://github.com/MaxF12/aioquic
cd aioquic
pip install wheel asgiref dnslib httpbin starlette "flask<2.1" "werkzeug<2.1" wsproto
export CFLAGS="-I/usr/local/opt/openssl/include -I${LOCALD}/include"
export LDFLAGS="-L/usr/local/opt/openssl/lib -L${LIBMCRXD}/lib"
pip install -e .

After this, I think it works for me to go into ${HOME}/sandbox/aioquic in 2 different terminals and run:
export LD_LIBRARY_PATH=${HOME}/sandbox/local/lib
source ${HOME}/sandbox/qmc/bin/activate

Then examples/mc_server.py and examples/mc_client.py can be run in those 2 separate terminals and successfully make a connection:
python examples/mc_server.py --certificate tests/ssl_cert.pem --private-key tests/ssl_key.pem
python examples/mc_client.py --ca-certs tests/pycacert.pem --remote-port 4433 --server localhost

(Note that this does not yet have multicast running to do the transport, it just gets to the point you can have it running at all, so you can hack on it usefully.)
HTH.

Thank you for replying back.
Thank you for providing info how to work with mc_server and mc_client.py.
Will try in my machine.

Also, issues have now been enabled on https://github.com/MaxF12/aioquic, that's probably a better place to open the next one.  Thanks for asking about it.

Thank you for enabling issues in  https://github.com/MaxF12/aioquic.


PHP 8 Support

Please add support for PHP 8

Hello @poseso ,
Thanks for creating the issue. What issue you faced? Can you share screenshot or screencast?
Thanks

Still no php 8 support? 7.4 is EOL and 8.1 is current.


Record dead link stats in a queryable way

Problem

We do not have insights into dead link rates for providers or certain queries.
Description

Lets store dead link stats in the database or mark them somehow in the database such that they are queryable. Related to WordPress/openverse#686.
Implementation

[ ] 🙋 I would be interested in implementing this feature.

Closing in favour of #428


chore: update confusing vault registration logging

Signed-off-by: Gregory Hill<EMAIL_ADDRESS>

@sander2 perhaps we should simply exit if the vault is not registered?

We could.. But it was kind of intentional to not quit, because back when we were just adding multicollateral, the envisioned workflow was to start a vault client, and then to use the webui to register with new currencypairs


Update chaos-engineering.md

Add date

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6605020bd4499141b448a644--harness-developer.netlify.app


An error dialog pops up when executing 'Propagate Access Control Lists…'  for one Azure AD attached ADLS Gen2 folder

Storage Explorer Version: 1.17.0
Build Number: 20210204.2
Branch: main
Platform/OS: Windows 10/ CentOS 7.6.1810 (Core)/ MacOS Catalina
Architecture: ia32/x64
Regression From: Previous build(20210129.3)
Steps to Reproduce

Expand one ADLS Gen2 account -> Blob Containers.
Create a blob container -> Upload one folder.
Give RBAC access to the blob container 'Blob Data Owner Role'.
Attach the folder via Azure AD -> Right click the attached folder under the 'Attached Containers -> Blob Containers' node.
Click 'Propagate Access Control Lists...' -> Click 'OK'.
Check there is no error dialog.

Expected Experience
No error dialog pops up.
Actual Experience
An error dialog pops up.

Additional Context
This issue also reproduces for one Azure AD attached ADLS Gen2 folder via ACLs.

Hi @JasonYeMSFT  verified on build 20210205.4. This issue still reproduces. please see the record.

Ah, this is expected. The ADLS Gen2 directory path shouldn't contain the trailing / to work properly. Since we are working on a new connect dialog, let's make sure we invalidate the case with trailing /.

Hi @JasonYeMSFT OK. Got it. We will continue to verify it on main branch.

Verified on the build main/20210219.1. This issue has been fixed. So we close it.


How to deduplicate multiple datasets?

fineweb offer a deduplication  demo for one dump. If want to deduplicate more dumps, should I merge dumps before deduplication ?

if you have the data in the same folder for example /mypath/ (even if within different subfolders /mypath/dump1, /mypath/dump2, etc) you can use /mypath as your input path for deduplication

If the data folder as follows, I set 'DUMP_TO_PROCESS'='2013', it can't read files in  CC-MAIN-2013-20 and  CC-MAIN-2013-48  subfolders, but set 'DUMP_TO_PROCESS'='2013' is ok.
-- 2013
|-- CC-MAIN-2013-20
-- CC-MAIN-2013-48


[task][issue-reopener] Move issue-reopener to separate repository

A GitHub Action must have its action.yml in the root directory of the repository to be listed in the GitHub Marketplace.
https://docs.github.com/en/actions/creating-actions/publishing-actions-in-github-marketplace

I'd really like to not have to create an org to hold these repositories. Maybe it would be ok to just host them on my user.

Moved to ianlewis/todo-issue-reopener


[Event Request] codeunit 1535 Approvals Mgmt. - Function CanCancelApprovalForRecord

Dear ALAppExtensions Team,
We would like to request the following event publisher in codeunit 1535 function CanCancelApprovalForRecord , of course without the prefix DIN.
begin
    if not UserSetup.Get(UserId) then
        exit(false);

    ApprovalEntry.SetRange("Table ID", RecID.TableNo);
    ApprovalEntry.SetRange("Record ID to Approve", RecID);
    ApprovalEntry.SetFilter(Status, '%1|%2', ApprovalEntry.Status::Created, ApprovalEntry.Status::Open);
    ApprovalEntry.SetRange("Related to Change", false);

    // DINNL <<
    DINOnCanCancelApprovalForRecord(ApprovalEntry, DINIsHandled);
    if not DINIsHandled then
    // DINNL >>
    if not UserSetup."Approval Administrator" then
        ApprovalEntry.SetRange("Sender ID", UserId);
    Result := ApprovalEntry.FindFirst();
    OnAfterCanCancelApprovalForRecord(RecID, Result);
end;

local procedure DINOnCanCancelApprovalForRecord(var ApprovalEntry: Record "Approval Entry"; var IsHandled: Boolean)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Where is this publisher?

From BC 23.0.12034.14561
procedure CanCancelApprovalForRecord(RecID: RecordID) Result: Boolean
var
    ApprovalEntry: Record "Approval Entry";
    UserSetup: Record "User Setup";
begin
    if not UserSetup.Get(UserId) then
        exit(false);

    ApprovalEntry.SetRange("Table ID", RecID.TableNo);
    ApprovalEntry.SetRange("Record ID to Approve", RecID);
    ApprovalEntry.SetFilter(Status, '%1|%2', ApprovalEntry.Status::Created, ApprovalEntry.Status::Open);
    ApprovalEntry.SetRange("Related to Change", false);

    if not UserSetup."Approval Administrator" then
        ApprovalEntry.SetRange("Sender ID", UserId);
    Result := ApprovalEntry.FindFirst();
    OnAfterCanCancelApprovalForRecord(RecID, Result, ApprovalEntry, UserSetup);
end;

@JesperSchulz

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

@AlexanderYakunin, could you look into this case? The publisher doesn't seem to exist.

You can use existing event OnAfterCanCancelApprovalForRecord(RecID, Result, ApprovalEntry, UserSetup) to achieve same result. No need to add extra event here.


Improve methods that creates user-data and meta-data by using go template instead of string replace

See comment https://github.com/vmware/kops/pull/4/files/e91b80849c048af0e2ba32c289712fd8b8d09c02#diff-debc963c3e706d2e00f5524af9b78675

Upstream PR is already out. Moving this to M1, raising priority for early resolution.

@casualjim This could be good one to get started and familiar with KOPS. Please re-assign as appropriate.

This issue was moved to kubernetes/kops#2748


WIP Gossip user data

This is just a quick hack to get gossiping user data working, but this is the general scope of the work that needs to be done. Relatively close to completion (implementation-wise), but not quite there for a full-blown review. This PR is more for sharing purposes right now.
The technique applied for gossiping user data is the same used for gossiping membership changes. Much like the changes, user data is 'recorded' in the dissemination component. Upon the next protocol period, the recorded user data will be piggybacked with the ping request. The user data disseminated decays over time; probabilistically user data will make its way to every node. There's no state-checking/checksumming/anti-entropy of user data at this point.
@kriskowal @Raynos @jcorbin

Closing. Twas just a proof of concept. Gossiping queries, user data, config still to come...


Step cancelled without reason

I am trying to build and publish Docker image using Dockerfile. I have a repository in Gitea. I am getting a "The step has been cancelled" error for the clone step. Please find the screenshot below.

Here is my pipeline
pipeline:
  publish:
    image: plugins/docker
    group: docker
    secrets: [ docker_username, docker_password ]
    settings:
      repo: dockerregistry/reponame
      dockerfile: Dockerfile
      tag: latest
    when:
      branch: master
      event: push

Am I missing or doing anything wrong?
Originally posted by @rajaseg in https://github.com/woodpecker-ci/woodpecker/issues/795#issuecomment-1051652122

@rajaseg I have created this issue for you as it seemed to no be related to the original issue. Hope thats fine for you.

@rajaseg whitch architecture/system your agents do run under?

@rajaseg whitch architecture/system your agents do run under?

@6543 I am running woodpecker server and Agent using docker-compose in swarm environment on Ubuntu Server 20.04 LTS
docker-compose.yml
version: "3.7"

services:
  woodpecker-server:
    image: woodpeckerci/woodpecker-server:latest
    volumes:
      - /localvolume:/var/lib/woodpecker/
    environment:
      - WOODPECKER_OPEN=true
      - WOODPECKER_HOST=https://woodpecker.example.com
      - WOODPECKER_GITEA=true
      - WOODPECKER_GITEA_CLIENT=client id
      - WOODPECKER_GITEA_SECRET=secret
      - WOODPECKER_GITEA_URL=https://gitea.example.com
      - WOODPECKER_AGENT_SECRET=agent secret
    networks:
      - caddy
    ports:
      - "8000:8000"
    deploy:
      placement:
        constraints: [node.role == worker]
      replicas: 1
      update_config:
        parallelism: 2
        delay: 10s
      restart_policy:
        condition: on-failure

  woodpecker-agent:
    image: woodpeckerci/woodpecker-agent:latest
    command: agent
    depends_on:
      - woodpecker-server
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
    environment:
      - WOODPECKER_SERVER=woodpecker-server:9000
      - WOODPECKER_AGENT_SECRET=agent secret
      - WOODPECKER_MAX_PROCS=10
    networks:
      - caddy
    deploy:
      placement:
        constraints: [node.role == worker]
      replicas: 1
      update_config:
        parallelism: 2
        delay: 10s
      restart_policy:
        condition: on-failure
volumes:
  localvolume:
    driver: "local"
networks:
  caddy:
    external: true

Docker Version
Client: Docker Engine - Community
 Version:           19.03.13
 API version:       1.40
 Go version:        go1.13.15
 Git commit:        4484c46d9d
 Built:             Wed Sep 16 17:02:36 2020
 OS/Arch:           linux/amd64
 Experimental:      false

Server: Docker Engine - Community
 Engine:
  Version:          19.03.13
  API version:      1.40 (minimum version 1.12)
  Go version:       go1.13.15
  Git commit:       4484c46d9d
  Built:            Wed Sep 16 17:01:06 2020
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.3.7
  GitCommit:        8fba4e9a7d01810a393d5d25a3621dc101981175
 runc:
  Version:          1.0.0-rc10
  GitCommit:        dc9208a3303feef5b3839f4323d9beb36df0a9dd
 docker-init:
  Version:          0.18.0
  GitCommit:        fec3683

Docker Compose Version
docker-compose version 1.26.0, build d4451659

There are different problems:

The canceled steps: you could look into your server/agent logs to see what error happens
For the docker usage, the pipeline container should have access to a docker socket, it's a complicated topic and some parts are covered by the woodpecker document.

- WOODPECKER_GRPC_ADDR=9000 is wrong ......
You had better not set it. Or follow the document https://woodpecker-ci.org/docs/administration/server-config#woodpecker_grpc_addr strictly.

- WOODPECKER_GRPC_ADDR=9000 is wrong ......
You had better not set it. Or follow the document https://woodpecker-ci.org/docs/administration/server-config#woodpecker_grpc_addr strictly.

I just removed - WOODPECKER_GRPC_ADDR=9000
Now I got the original error "This step has been canceled" and below logs for the Server and Agent.
Woodpecker Server Logs
woodpecker_woodpecker-server.1.z1mwb0917om8@vps004    | {"time":"2022-02-26T19:14:15Z","message":"LogLevel = warn"}
woodpecker_woodpecker-server.1.z1mwb0917om8@vps004    | {"level":"error","error":"stream: not found","time":"2022-02-26T19:14:16Z","message":"done: cannot close build_id 104 logger"}

Woodpecker Agent Logs
woodpecker_woodpecker-agent.1.wmj3ozqesm43@vps004    | {"level":"warn","repo":"reponame","build":"30","id":"113","error":"rpc error: code = Unknown desc = Proc finished with exitcode 1, Error response from daemon: client version 1.41 is too new. Maximum supported API version is 1.40","time":"2022-02-26T19:16:08Z","message":"cancel signal received"}

@rajaseg ... that's #631 - if docker deamon is not compatible with the agent ... - for now it just cancle all builds - but the agent should check that on start in the first place and fail

@rajaseg ... that's #631 - if docker deamon is not compatible with the agent ... - for now it just cancle all builds - but the agent should check that on start in the first place and fail

@6543 It would be good to support older API versions.

@rajaseg that's mainly an issue with the upstream project we use ...
( https://github.com/moby/moby/tree/master/client ) - so it would be an issue on there side ... or we would have to write our own one completly!

@rajaseg that's mainly an issue with the upstream project we use ...
( https://github.com/moby/moby/tree/master/client ) - so it would be an issue on there side ... or we would have to write our own one completly!

@6543 I tested with Drone, everything went well. It should work for Woodpecker as it is a clone of Drone. Correct me if I am wrong.

@rajaseg well drone could still use an old library - is there a reason you can not update docker deamon ?

@rajaseg well drone could still use an old library - is there a reason you can not update docker deamon ?

@6543 I just upgraded the docker daemon and everything works as expected. If someone runs important apps on Docker Swarm Cluster, it would be trouble to upgrade the docker daemon. That's why It would be good to support older api evrsions if possible.

closing as the problem was detected for this case. improving the ux for other users will be done by #631


userReview populating private fields on user content type for logged in user

Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch<EMAIL_ADDRESS>for the project I'm working on.
userReview field was not properly sanitizing user data thereby returning the hashed password and other private fields in the request when the user is logged in.
Here is the diff that solved my problem:
diff --git a/node_modules/strapi-plugin-ratings/server/controllers/reviews.js b/node_modules/strapi-plugin-ratings/server/controllers/reviews.js
index 2b3b7f3..3400c2f 100644
--- a/node_modules/strapi-plugin-ratings/server/controllers/reviews.js
+++ b/node_modules/strapi-plugin-ratings/server/controllers/reviews.js
@@ -38,6 +38,19 @@ module.exports = {
         averageScore = score.average
       }
     }
+
+    const sanitizeOutput = (user, pub) => {
+      const {
+        password,
+        resetPasswordToken,
+        confirmationToken,
+        ...sanitizedUser
+      } = user; // be careful, you need to omit other private attributes yourself
+      const { email, role, phone_number, addresses, ...publicUser } =
+        sanitizedUser;
+      return pub ? publicUser : sanitizedUser;
+    };
+
     // Check whether the user has already posted a review
     if (user) {
       userReview = await strapi.db.query("plugin::ratings.review").findOne({
@@ -54,6 +67,8 @@ module.exports = {
         // Exclude user review
         reviews = reviews.filter(r => r.id !== userReview.id)
       }
+
+      userReview = { ...userReview, author: sanitizeOutput(userReview.author, "public") }
     }
     ctx.body = {
       reviewsCount,

This issue body was partially generated by patch-package.

Hi there,
Thank you for opening this issue. You are right, that data should not be sent along with the review.
So the problem was that strapi.db.query uses select syntax instead of fields to populate fields in relations, and the API controller was using fields syntax inside a strapi.db.query.
I just fixed it in version 1.1.9.
By the way, there is a helper function called sanitize, which is included in the package @strapi/utils and it's job is to remove sensitive fields from the data before sending it in the response.


nix: add upgrade guide for bumping nix versions

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I don’t think it makes sense to do stable Nix bumps on staging. It’s less than 100 rebuilds and it slows down the feedback cycle on any issues dramatically. It also makes it harder to disentangle what failures are caused by the new Nix version as opposed to something else in the cycle; triaging staging is already painful enough. We only have a couple staging cycles left before the freeze and they’re going to be hectic. I think we should stick to the plan of merging the bump to master again on Monday so we can get quick feedback on if it fixes the Hydra issues and have more time for user testing of the new version to flag up any additional problems before the freeze.
cc @K900 who proposed Monday initially

It's like 1000 nixos tests: https://hydra.nixos.org/eval/1808978?filter=nixos.tests&compare=1808939&full=#tabs-still-fail
So far it was always the NixOS tests that causing the revert.

For the nix 2.24 release it would be probably also fine to have it on the main channel.

I don’t think all NixOS tests include Nix in the VM closure, do they? My understanding is that it was only a relatively small number of tests, like those that exercise the installer and building new configurations.

Nix is part of every Nixon test. Except for this one test where it's disabled.

Right, that came up on Matrix. We should definitely fix that, since it’s completely unused for the majority of them, but until then this policy makes sense. (I also learned that 2.24 is already in staging-next, so we should be okay on time.)


[REACT JS CHEAT SHEET]:

Description
I want to make a cheat sheet for react js which candidate can refer for interview preparation for revision.
Domain
Interview Prep
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

Go ahead! All the best!

Thank you


Scalelite auth fixes

Challenge for HTTP auth when credentials aren't found. Also fix a couple syntax problems that kept the script from running.

Thanks; Merged your changes and migrated them to auth-passwd-bbb.py as well.


Missing terminal cursor after cancelling workspace creation

Describe the bug
Sometimes, when the user cancels the workspace creation process, the terminal cursor goes missing and can't be recovered. See the attached screen recording for a demonstration.
To Reproduce
Steps to reproduce the behavior:

Run daytona create https://github.com/daytonaio/daytona
Wait for the logs to reach the devcontainer build process
Abort the process with Ctrl+C
Observe that the cursor is missing

Expected behavior
The cursor should be visible in the terminal normally.
Screenshots
https://github.com/daytonaio/daytona/assets/26512078/f1556c7f-754c-475b-925c-928a7f6dcf8a
Desktop (please complete the following information):

OS: any
Daytona Version: v0.19.1

Additional context
I assume the issue occurs because of logs that are manipulating the cursor. We should ensure that it is reset after the user cancels the process.

For terminal manipulation, can we use external resources like moby/term?
Here's the link: https://github.com/moby/term
Logic: We can reset the server when we get SIGINT signal which is triggered by ctrl+c. Then we restore the terminal by using "term" commands!
(Just a thought 😅)

@RS-labhub you're welcome to raise a PR with a suggested solution. Can't say at this point if using the moby/term package would be appropriate for this issue.

Here's my code... (without using moby/term package)
// cleanup function to reset the terminal
func cleanup() {
    fmt.Println("\nAborting process and resetting terminal...")

    // Reset the terminal
    cmd := exec.Command("stty", "sane")
    cmd.Stdout = os.Stdout
    cmd.Stderr = os.Stderr
    if err := cmd.Run(); err != nil {
        fmt.Println("Failed to reset terminal:", err)
    }

    fmt.Println("Terminal reset complete.")
}

Explanation of the Cleanup function:
We first handle the SIGINT signal (which is sent when you press Ctrl+C) in the Go code (in main.go -> this is where I'm missing out something, or I'm wrong) to ensure the terminal is reset correctly. And then we can use exec.Command("reset") or exec.Command("stty", "sane") to reset the terminal state.
And somewhere in the main function, if we do signal handling, and then call our function, then the issue will be fixed.
Like this:
sigs := make(chan os.Signal, 1)
    signal.Notify(sigs, syscall.SIGINT, syscall.SIGTERM)

    go func() {
        <-sigs
        cleanup()
        os.Exit(1)
    }()
    ```

    Do you like this logic???

@RS-labhub we can't review code in github comments :)
Please raise a PR with the appropriate code so we can review properly.

/bounty $20

/attempt #695

/attempt #695


Keybinding in french layout

Windows Version
Microsoft Windows [version 10.0.22631.3007]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[x] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-microsoft-standard-WSL2
Distro Version
Ubuntu 22.04
Other Software
When trying to undo things (Ctrl + underscore) inside emacs -nw I get the delete behaviour (previous char is deleted).
shokey show also that the ket send is not C-_ but ^?:
 showkey -a

Press any keys - Ctrl-D will terminate this program

^?      127 0177 0x7f
^D        4 0004 0x04

Repro Steps
Run wsl with french keyboard layout
Start emacs -nw
go to scratch buffer (C-x b return)
write some text
move cursor in the middle of the text
hit C-_
the char before prompt is deleted instead of last written one
Expected Behavior
C-_ should correspond to undo
Actual Behavior
C-_ correspond to delete
Diagnostic Logs
No response

Have seen another issue with indian layout that was adresses to windows terminal but that occurs with all terminal windows native I tested (https://github.com/microsoft/terminal/issues/11194).
It does not happen with emacs graphical or ubuntu graphical terminal (terminator installed via apt-get)

Any news/comment on that ?

This issue is related to emacs configuration. WSL doesn't have control over emacs' behavior

No it's not. shokeys -a show the same issue with no link to emacs configuration

Sorry for that it seems to be a Terminal issue which was solved in 1.20.


Saved Scenario in 1.7.0b - can't open in 1.6.1

Hi guys,
I assume there is new functionality in 1.7.0b, I saved a scenario in this client by accident (thought I was in 1.6.1) and now can't see it in the 1.6.1 release client.
Is there a way to convert it back to being compatible with 1.6.1? If not will this 1.7.0b scenario be compatible with 2.0 when it is released?

https://github.com/NPBruce/valkyrie/wiki/QuestIniQuest
Try to set format=8 inside the quest.ini. Be aware of the changes in quest format 9 https://github.com/NPBruce/valkyrie/wiki/QuestFormat

If you are using the added traits or investigator attacks it won't work.
Otherwise you will have to remove all references to $end (you can do this in the editor or manually) and then manually edit quest.ini and change the format to 8.

I had saved it previoulsly in 1.7.0b and it was still visible. I think I saved it after playing around with the sorting functions.
I am not using the added traits or investigator attacks.
I am not near finishing this, so not worried if it will work in the next release? Am I right in thinking a 1.7.0b scenario will work in the next release of Valkyrie (2.0 now I believe)?

Yes it will work in future versions.


CC59892: Removing "public" from  code

Hello, @mairaw ,
This proposed file change comes from https://github.com/dotnet/docs.ru-ru/pull/110.
Contributor comment: "You can not use access modifiers with explicit implementation"
Could you review this contribution and help to merge if agreed?
Many thanks in advance.

Thanks @BillWagner


Approval permission to l10n teams for specific files at root level/outside content path

This is a Feature Request
What would you like to be added
Add approval permission to localization teams for specific files at root level, outside content path:

i18n/<LANG>.toml
README-<LANG>.md

Why is this needed
Those files (for example, README-ko.md and i18n/ko.toml) are hard to get reviewed or approved by sig-docs-en-owners.
Related PRs: #12875 #12878 #13951
Comments

/cc @zacharysarah

@gochist Sorry I missed this issue—I opened #14048 too.

@zacharysarah No problem. README-<LANG>.md is remaining. I'm not sure that the prow supports file level filtering.

/remove-lifecycle stale

/close


Double click near symbol ' works inconsistently

Description
select
    1,
    2,
    3,
    '012345' as col
from pg_class;

select
    row_number() over(order by p."Id") as "Id",
    p."MyColumn"::int::bool as "SomeColumnName123",
    upper(p."Code"),
    'hello'
from  public."Product" as p;

https://github.com/dbeaver/dbeaver/assets/33929221/91857c90-cf35-4ef8-a347-408613ab93b1
DBeaver Version
Community Edition <IP_ADDRESS>407042322
Operating System
Windows 10
Database and driver
PostgreSQL 16
PostgreSQL JDBC Driver 42.7.2
Additional context
I recommend to compare how other popular text editors behave to detect word boundaries.

Thank you for report.


Broken link need to be fixed...

[Function Scope, Block Scope and Lexical Scope ] --->  [The battle between Function Scope and Block Scope — Marius Herring]
link :  http://www.deadcoderising.com/2017-04-11-es6-var-let-and-const-the-battle-between-function-scope-and-block-scope/

Hi, I want to contribute to this repo, can you please assign this task to me.

Thanks @Rajvira10 @leonardomso


Fully observability

Hey,
I haven't thought about two issues with the FullyObsWrapper:

using the wrapper as it is, it renders an image of 800 x 800 x 3 which is quite heavy to manage
one must call the env.render('human')
The combination of the two makes the env very slow.

Any suggestion on how I can improve on it?
Thank you !

Hmm, first thing is, you should be calling env.render('rgb_array') (which will return a numpy array), not env.render('human'), and this should be done within the wrapper's observation method.
For the speed, the simplest thing to do would be to render a smaller version of the grid. But the most efficient way would be to encode the grid directly as a numpy array with 3 values per cell as I did for partial observability. See the encode method of the Grid class: https://github.com/maximecb/gym-minigrid/blob/master/gym_minigrid/minigrid.py#L508
The only downside of this is that it doesn't currently encode the agent position.

Thank you for the quick reply. Something like this should the trick then:
    def observation(self, obs):
        full_grid = self.env.grid.encode()
        full_grid[self.env.agent_pos[0]][self.env.agent_pos[1]] = self.env.agent_dir
        return full_grid

Yes, like that, except you'd want to also encode that the agent is at that position, not just the agent direction. Something like:
full_grid[x, y, 0] = 255
full_grid[x, y, 1] = self.env.agent_dir
full_grid[x, y, 2] = 0

You would also want to change the observation_space to have the correct shape.

For anyone using this: I recommend encoding the agent as a much lower number that is closer to how the other objects are encoded.
While training on the Unlock-environment converged in ~12 minutes with the regular, egocentric view, training with the FullyObsWrapper never converged. At first I thought the egocentric view gives a translation invariance that the FullyObsWrapper doesn't have, so I tried to compensate and make the environment much simpler by removing colors, giving a small reward when picking up the key or reducing the action space such that pickup and toggle were reduced to 'interact' and drop was removed. Despite all of this, the model just wouldn't learn to go to the door after picking up the key.
Finally I changed the agent encoding from 255 to 9, and now training with the fully observable view converges as fast as with the egocentric view. Possibly the high value is too dominant in the convnet's processing.
PS. The current FullyObsWrapper also doesn't encode which item is being carried. In the egocentric view, this is encoded by showing the item as if it is at the agent's position, but the FullyObsWrapper overwrites this grid position to encode the agent. If color is not important, you can encode the carried object's type at the agent's position in the 3rd layer. If color is important, you will need to add a 4th layer to also include the carried object's color.


Ability to add number to units and converted units as well

Calculations like
10kg + 10 and 10kg to g + 10 should also work.

Interested. Can I work on it?

You can take this up !!


Add github users to go-course repo

Add github usernames from spreadsheet (ask @juliaogris for details)
to https://github.com/anz-bank/go-course/settings/collaboration
Give users write access to the repo (necessary to merge PRs and add tags to PRs)
People who have given invalid usernames (might have been using internal GHE accounts) need to be contact by email.

Done! Last signups are being added manually.


Remove populus

this makes tests indenpendent on populus library

Just to mention - I am still reviewing this PR.

Aside from the token_network fixture, things seems good. There is still the rebase to be done at this point.
The only thing I have some issues with is having fixtures that are in another repo. This can potentially lead to issues if the fixtures are changed in some subtle way that change the tests logic.
But as long as we keep in sync about raiden-libs fixture changes, it can work.

It would make sense to move the fixtures into the contracts repo now that they are used here as well.

Yes, it makes more sense to have them in the contracts repo, agreed.

I'll move the fixtures from libs to contracts, but let's do that in another PR, because it'll break practically everything. :)


Prevent updates to package.json

I am including symfony/ux-turbo in my application and it keeps trying to include a file in my package.json.
I don't want to include this in my package.json as I am including turbo myself. Is there a way to prevent changes to packages.json from specific bundles?

What file? The @symfony/ux-turbo/... one ?

Yes, that's right.

Those files are the ones connecting Symfony with Turbo... what would you remove them ?

I already have turbo included in my package.json
"@hotwired/turbo": "^7.1.0",

Why would I need the ux/turbo package? The only real reason that I am using symfony/ux-turbo is for the stream format helper. e.g:
if (TurboBundle::STREAM_FORMAT !== $request->getPreferredFormat(TurboBundle::STREAM_FORMAT)) {
    ...
}

The package would not install Turbo twice, so i am not sure to understand the problem here.

Why would I need the ux/turbo package?

Because you installed the symfony/ux-turbo bundle? :)
The bundle goal is to connect webpack or assetmapper with symfony and ease the installation & usage of Turbo.
More information about the @symfony/ux-turbo/ package (it does not contain Turbo): https://symfony.com/doc/4.x/frontend/ux.html#how-does-symfony-ux-work

Yes but I still don't want it to change my package.json. Is there a way to prevent that? I only want to use this bundle to detect the request type.

If you disable Flex probably ?

I can't do that. I guess I'll just have to reset package.json whenever an update occurs. It's a shame it can't be configured as I'm not using this package for loading turbo, I just want it to detect the request type

Well, if having another dependency installed (even if not called) is impossible for you, yes i think this should be the only solution right now.
If you have another idea / implementation suggestion, we'd be glad to help you open a PR


Support for Linux/aarm64

Is it possible to add support for Linux/aarm64?
#0 134.5   • Installing rocksdict (0.3.15)
#0 134.6
#0 134.6   RuntimeError
#0 134.6
#0 134.6   Unable to find installation candidates for rocksdict (0.3.15)

Happy to work on a PR, if you point me in the right direction.

I think I have a linux/Aarch64 build, manylinux_2_28, which requires 'pip >= 20.3'. Can you try running 'pip --version'? Also you might try 'pip install --upgrade pip'.

I'm using poetry 1.6.1, let me try it with pip.

Okay, the issue is alpine linux:

I guess the docs don't call out aarm64 support on linux but do on other platforms

This package is built for macOS (x86/arm), Windows 64/32, and Linux x86. It can be installed from pypi with pip install rocksdict.

https://congyuwang.github.io/RocksDict/rocksdict.html

Thanks. I’ll update the readme.


Finish account implementation

Add in a tracking issue with context

This is related to the SDK, not the server 👀


Add an umbrella import to the _TestingInternals module map file.

This PR removes the individual header declarations from the _TestingInternals module map file and replaces them with a single umbrella import. This fixes an existing workflow used by some of our teammates.
This PR moves the module map file to align with an existing workflow used by some of our teammates.
Checklist:

[x] Code and documentation should follow the style of the Style Guide.
[x] If public symbols are renamed or modified, DocC references should be updated.

@swift-ci please test

Are you sure that, when a module map is placed in this location, SwiftPM actually honors it and does not revert back to its default behavior of synthesizing a module map representing all the headers in include?

It doesn't actually matter. SwiftPM is fine to synthesize a module here. The module map is only used by CMake and the Xcode project generated by it.

@swift-ci please test

@swift-ci please test

Windows failure is a known compiler issue.

I'm on pto but will verify tomorrow!

Tested 004994fef30548d6370dd141dfbb5154cb5bc59c with the latest build from https://github.com/thebrowsercompany/swift-build as the current swift.org toolchains are too old to support the package at this point (due to the use of the stdlib macros).

Curious. I wonder what's confusing CMake there given that there aren't actually any source changes involved.

It's unclear if this change triggered this, just something that I noticed :)


fix Unresponsive status on update and duplicate Inventory

Description
Fixes a condition where:

a system can be displayed in both Conventional and Immutable tabs of consoledot Inventory.
a system can be marked as Unresponsive when attempting an update

FIXES: THEEDGE-3896 and THEEDGE-3897
Type of change
What is it?

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update
[ ] Refactor

I :orange_heart: fixes that removes code! :stuck_out_tongue:


Needing to apply 4GB patch again

Validation

[X] Game has been updated to the latest RE4HD release (v1.1: https://www.re4hd.com/?p=9552)
[X] Data has been validated with SFV (a guide to using QuickSFV is available at that link, use that with this 1.1 SFV: BIO4-HDProject1.1-SFV.zip)

Describe your issue here (drag+drop ZIP to attach it)
I was prompted again to patch BIO4.exe with a 4gb patch a couple days after I stopped playing. I assume this could be due to BIO4.exe being flagged as malware.heuristic.1001 by malwarebytes and perhaps behind removed?

I assume this could be due to BIO4.exe being flagged as malware.heuristic.1001 by malwarebytes and perhaps behind removed?

It's possible, there was also a game update on Steam a few days ago which might have replaced your EXE too, see if it happens again I guess.

t

I'm having some massive slowdowns with v1.9.
I think it may be to do with the 4GB patch needing re-applied.
How do I do that again?  RE4HD v1.1 and tweaks v1.9 are already installed.

@emoose
I'm having some massive slowdowns with v1.9.
I think it may be to do with the 4GB patch needing re-applied.
How do I do that again?  RE4HD v1.1 and tweaks v1.9 are already installed.


{#Editor} csv parser problem

[x] once it has problem, it won't be validated after,only allow for copy paste

[ ] one row csv cannot be parsed

can only use ' , ' to separate the elements(/row); can't use space
but the sample data use space to separate

if you want to parse one row csv like this:
name
Donald Trump
Emmanuel Macron

you have to insert
name,
Donald Trump,
Emmanuel Macron,


Stop watch

I adjusted the timer and turned it into a stopwatch. Feel free to adjust as needed. It needs to be tested

I'm going to pause this pull request for now, because I made a lot of different changes to account for the game saving every second.  And since it doesn't function as desired yet, I don't want to accidentally mess something up during merging.

Right now, the stopwatch looks at a timeGameStarted variable from GameContext.js, and just finds the difference between the current time and then.  This only accounts for a game played all in one sitting.


Upgrade to typings 1.0

Typings 1.0 changed the ambient term to global, and replaced the main with index.
Thanks

Great, thanks!


Add Windows testing stage to the CI Jenkinsfile

If the project builds on Windows, we should update our CI Jenkinsfile by adding a new testing stage targeted against Windows platform.

/cc @anitagov @msft-jonnadul @LarryOsterman @johnkord

How does this sound to you guys ?

@ionutbalutoiu - From the Open Enclave side, we have not yet pushed the changes needed for DCAP libraries to work on Windows yet. Simon and I are still working on a branch.

cc: @CodeMonkeyLeet

@ionutbalutoiu - From the Open Enclave side, we have not yet pushed the changes needed for DCAP libraries to work on Windows yet. Simon and I are still working on a branch.

Thanks for the info, @anitagov.
My suggestion was about the .jenkins/Jenkinsfile hosted in this repository.
We have a separate CI job running on master check-ins, and on every PR for the Azure-DCAP-Client repository. The Jenkinsfile from this repository contains only Linux stages to build + run unit tests on both Ubuntu 16.04 and Ubuntu 18.04.
Just by looking at the documentation, I think we can build Azure-DCAP-Client on Windows (I noticed this). And I also noticed commit https://github.com/microsoft/Azure-DCAP-Client/commit/c494fa64295cfaf3273dca8330f53107cb2a291c, which makes me think that maybe we can run unit tests as well.
So, I suggest adding an extra CI stage here to solely build + run unit tests on Windows for the Azure-DCAP-Client.
What do you think ?

@ionutbalutoiu - The Azure-DCAP-Client on Windows build isn't automated and can currently be done manually using the Visual Studio 2017 IDE. There are a couple of outstanding issues with the build as I mentioned in the issue (https://github.com/microsoft/Azure-DCAP-Client/issues/62) that I filed recently.
To get an automated build, a new script will be required.
I am not sure if the unit tests are meant for Linux or for Linux and Windows.
Another important gap is that we still do not have attestation portion completed from OE and Azure-DCAP-Client for Windows.
But automated build is a minimum requirement for initiating CI.

@ionutbalutoiu - The Azure-DCAP-Client on Windows build isn't automated and can currently be done manually using the Visual Studio 2017 IDE. There are a couple of outstanding issues with the build as I mentioned in the issue (#62) that I filed recently.
To get an automated build, a new script will be required.

So far, we have the following WiP pull request #65 to simply build the project.
We will also take a look at issue https://github.com/microsoft/Azure-DCAP-Client/issues/62 reported by you.

I am not sure if the unit tests are meant for Linux or for Linux and Windows.
Another important gap is that we still do not have attestation portion completed from OE and Azure-DCAP-Client for Windows.

Once this part is finished, I believe running some kind of tests on Windows will make more sense.

But automated build is a minimum requirement for initiating CI.

I believe that the changes to the Jenkinsfile from PR-65 should include everything needed to have an automated build on Windows via Visual Studio.
What do you think ?

Can you have a script do these steps and then invoke this in the Jenkins scripts? This is because developers can use this script to build. Thanks.

@ionutbalutoiu I think it's worth trying to do this, but there are a couple of additional caveats that extend beyond the Jenkins file:

The Ansible configuration for Windows we have set up in the OE SDK repo is different from the expectations of the vcxproj here (e.g. path with full nuget package version)

The vcxproj file does not appear to build the UnitTests folder yet. They may work on Windows, but they do not appear to be integrated into Windows build project by default

/cc @msft-chow

cc @soccerGB

Can you have a script do these steps and then invoke this in the Jenkins scripts? This is because developers can use this script to build. Thanks.

@anitagov That's a good idea! We'll be adding a new script build.ps1, and one can simply execute that and build the project on Windows.

@ionutbalutoiu I think it's worth trying to do this, but there are a couple of additional caveats that extend beyond the Jenkins file:

The Ansible configuration for Windows we have set up in the OE SDK repo is different from the expectations of the vcxproj here (e.g. path with full nuget package version)

@CodeMonkeyLeet I think that executing get-prereqs.ps1 PowerShell script + nuget.exe restore is enough to have the project built via Visual Studio 2017 on Windows as done in the PR https://github.com/microsoft/Azure-DCAP-Client/pull/65.
However, the Azure-DCAP-Client project targets the SDK 10.0.17134.0:
https://github.com/microsoft/Azure-DCAP-Client/blob/c494fa64295cfaf3273dca8330f53107cb2a291c/src/Windows/dcap_provider.vcxproj#L18
and we had to add this when installing Visual Studio in the Ansible scripts. This is the pull request to OE with this change.

The vcxproj file does not appear to build the UnitTests folder yet. They may work on Windows, but they do not appear to be integrated into Windows build project by default

I suppose we can add the UnitTests later on, and see if they work.

Fixed by https://github.com/microsoft/Azure-DCAP-Client/pull/65

Can you have a script do these steps and then invoke this in the Jenkins scripts? This is because developers can use this script to build. Thanks.

@anitagov That's a good idea! We'll be adding a new script build.ps1, and one can simply execute that and build the project on Windows.

@ionutbalutoiu - This is great. Thanks.


Screenshot content is repeated multiple time and not render true height/width

Hello,
Thank you for this really nice package, however we have a really annoying problem.
Our screenshots are always with this weird repeat bug :

Any idea on how to solve this ? Please note that we run tests on WSL2/Ubuntu and Laravel 11 with Sail 8.3. Gotenberg is in the docker-compose.yml on the same network.
We use this code :
          $streamHtml = \Gotenberg\Stream::string('index.html', $html);

          $chromium = \Gotenberg\Gotenberg::chromium(config('app.gotenberg.url'));

          $screenshot = $chromium
              ->screenshot()
              ->html($streamHtml);

          $response = \Gotenberg\Gotenberg::send($screenshot);
          $screenshot = $response->getBody()->getContents();

Hey @MattLoyeD,
No idea what's going on here 🤔 What's the result of a PDF generation?

Everything works fine when I do pdf with the same html/code.


cups: 2.3.3op2 -> 2.4.0

Motivation for this change
Fixes security vulnerability https://github.com/NixOS/nixpkgs/issues/147866 and updates cups OpenPrinting from version 2.3.3op2 to version 2.4.0.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I tried to test the new Cups version on my system but unfortunately it rebuilds a lot of packages which is too much for my notebook. Is there anything I can do about this?

Was able to test this PR with cups 2.4 inside a nixos-shell vm using this configuration:
  services.printing = {
    enable = true;
    drivers = with pkgs; [ foo2zjs ];
  };

  hardware.printers = {
    ensurePrinters = [
      {
        name = "Dell_1250c";
        location = "Home";
        deviceUri = "http://<IP_ADDRESS>:631/printers/Dell_1250c";
        model = "drv:///sample.drv/generic.ppd";
        ppdOptions = {
          PageSize = "A4";
        };
      }
      {
        name = "Dell_1250c_USB";
        location = "Home";
        deviceUri = "usb://Dell/1250c%20Color%20Printer?serial=YNP023240";
        model = "Dell-1250c.ppd.gz";
        ppdOptions = {
          PageSize = "A4";
        };
      }
    ];
    ensureDefaultPrinter = "Dell_1250c";
  };

Querying the cups admin page with curl:
curl -s localhost:631 | grep "2.4"
    <title>Home - CUPS 2.4.0</title>

Listing default printers
lpstat -p -d
printer Dell_1250c is idle.  enabled since Tue 28 Dec 2021 09:44:59 AM UTC
printer Dell_1250c_USB is idle.  enabled since Tue 28 Dec 2021 09:44:59 AM UTC

Printing a picture to the AirPrint network printer
lp -d Dell_1250c -o fit-to-page -o media=A4 scared_cat.png

Printing a picture to the USB connected printer with a specific driver
lp -d Dell_1250c_USB -o fit-to-page -o media=A4 scared_cat.png

Everything is working fine on my side :) Please review


Get-SPOProvisioningTemplate : Cannot find stub for type with id "{1554af8c-7213-418c-a4a8-b06e7603c68a}".

Hi,
I am trying to export a site template using your Provisioning model:
using this Powershell:
import-module C:\TEMP\SharePointPnPPowerShell2013\Modules\SharePointPnPPowerShell2013
Region : Variables that can be changed
$SiteUrl = "https://mirai-dev:100/sites/UAT/"
End region
Connect-SPOnline -Url $SiteUrl
cls
Get-SPOProvisioningTemplate -ExcludeHandlers AuditSettings -Out C:\DEV\SuntoryDEV2.xml
However I get the error below:
Get-SPOProvisioningTemplate : Cannot find stub for type with id "{1554af8c-7213-418c-a4a8-b06e7603c68a}". The specified server may not support APIs used in
this operation.

Turned on logging and now get this
Cannot bind parameter 'Schema'. Cannot convert value "AuditSettings" to type
"OfficeDevPnP.Core.Framework.Provisioning.Providers.Xml.XMLPnPSchemaVersion". Error: "Unable to match the identifier name AuditSettings to
a valid enumerator name.  Specify one of the following enumerator names and try again: LATEST, V201503, V201505, V201508, V201512"
At C:\Users\E-HARYX001\Desktop\ExportSiteTempate.ps1:22 char:46

Get-SPOProvisioningTemplate -Handlers Fields AuditSettings -Out C:\DEV\SuntoryDE ...

This means that you are most likely running older version of SharePoint 2013, than 2015 April CU, which is the baseline for the PnP engine. This means that you should double check the exact version what you are using in your SharePoint side, but exception indicates clearly that you don't have AuditSettings CSOM support in your server side environment.

Yes I have checked my SharePoint version and I am on service pack 2 from a few years ago, so I will install patches/upgrades. So thanks for the pointer.

Closing this for now, if issue persists after upgrade, let's reopen the issue.


add Auto-Append feature to van.js

This commit adds an auto-Append feature to van.js. This enables a different and often easier composition scheme. It works seamlessly togeher with all other approaches, does not interfere with the current style and is pretty lightweight. It was inspired by the DML-approach
How does it work?
We introduce two functions

begin(ID) and
end(n)

Objects created between begin( ID ) and end( ) are appended as a child to the element(ID). which was selected by begin(). ID can be either an element ID or a dom-reference. So, begin(div()) creates a div() and selects this as a base. Here is an example:
This adds some text to a <div>
begin( div() )
   h1("headline")
   p("This is text")
end()

You can start building a complete document like this, using document.body as a basepoint. begin() features an adress-stack, so calls can be nested:
begin(document.body)
  // some tags here
  h1("my Headline")
  begin(div({style: "border: 1px solid red;"}) // --> create a new div() and start building the content inside
     for (i=0; i<10; i++)
       button('Button ${i}').onclick = () => alert('This is button ${i}')
   end() // close the div()
   p("This text appears below the red box")
end()

begin() returns a DOM-referencs, so you can also write
van.add( document.body, begin( div() ) )
    .....
end();

end() can have an index end(n) to apply repeated calls of end.
Composition often is more straightforward with autoAppend:
  // show a list of colors
  const colors = ["red","green","blue","yellow","maroon","navy"]

  // The VanJS style
    let list = ul()
    colors.map((c)=> van.add(list,li(c)))
    van.add(document.body,
        h1("This is VanJS style"),
        list
    )

    // The DML-style
    begin(document.body)
      h1("This is DML-Style")
      begin(ul())
        colors.map(c => li(c))
      end()
   end();

Auto-Append gives more options to use tag-functions, which can be helpful:
   // VanJS-style
   h1({style: "color: red","Headline")
   // this is also possible
   h1("Headline").style.color = "red"

The "funnier Hello" example can be rewritten like this:
    const { button, div, br, pre } = van.tags
    const { begin, end } = van

    begin(document.body)
        const dom = div({ class: "box", style: "border: 2px solid red; " })
        begin(div({ class: "box", style: "border: 2px solid green;" }))
            button({ onclick: () => van.add(dom, Run({ sleepMs: 2000 })) }, "Hello 🐌")
            button({ onclick: () => van.add(dom, Run({ sleepMs: 500 })) }, "Hello 🐢")
            button({ onclick: () => van.add(dom, Run({ sleepMs: 100 })) }, "Hello 🚶♂")
            button({ onclick: () => van.add(dom, Run({ sleepMs: 10 })) }, "Hello 🏎")
            button({ onclick: () => van.add(dom, Run({ sleepMs: 2 })) }, "Hello 🚀")
    end(2)
```JS
So, I would think this is a useful extension to VanJS

Hy Eckehard,
If only this two functions are needed without wrapping 'vanJS' elements, it woud be a very nice addition
indeed :-)

Nice proposition
Thank's Eckehard :-)

see this post

OK, all issues should be resolved now. Hope everything´s fine, I´m not very experienced to commit on github

There should be a module/nomodule/TS version of van_dml. Can you give any support so create and manage the versions and updates? Any suggestions for the version-naming is welcome (like van_dml_latest.js)

There should be a module/nomodule/TS version of van_dml. Can you give any support so create and manage the versions and updates? Any suggestions for the version-naming is welcome (like van_dml_latest.js)

In VanJS, I am using a bash script to generate different version of files: https://github.com/vanjs-org/van/blob/main/src/publish.sh. It's not in its perfect form, but works for me :-)

I am very glad with this :-)
@efpage
Look at this : ustyler.
I think this could replace your CSS function implementation and enable syntax  hilighting in VSCode
Regards


[BUG] Fix output to ColumnEnsembleForecaster with pred_quantile/pred_interval

Reference Issues/PRs
Fixes #2511.
What does this implement/fix? Explain your changes.
Removes unnecessary additional levels in output to pred_quantile and pred_interval

I would recommend, finish the tests, and then merge the test PR into this PR.
So we ensure that the bug picked up by the new tests is removed.

Where would be the best place to do this?

Ideally, forecasting.tests.test_all_forecasters.
I think there already exist two tests, test_predict_interval, and test_predict_quantiles, you may have to look at these to check why these did not pick up the issue with the ColumnEnsembleForecaster.
You may also like to consider a refactor, using check_is_mtype with the Proba mtypes (this should give you a full format check already, but the tests were written before that existed).

It turned out that all the correct testing infrastructure was in place, but there was no test parameters for the column ensemble that included probabilistic metrics so it was missed by the tests. I have added a new case for the column ensemble, we will need to ensure that all composite forecasters are tested with probabilistic inputs, currently pipeline is the only other one that has prob methods implemented and that already included a prob case.


Elastic CVE

Resolves CVE-2021-22145 https://nvd.nist.gov/vuln/detail/CVE-2021-22145

Closing as I'm actually going to suppress it, since we are unaffected. Also, HS6 doesn't seem to play nice with this particular version.


Performance degradation for nightly-20240102

Date: 2024-01-01
Scheduled Executions: 41
Passed Executions: 39
Pass Percentage: 95%
Positive Executions: 0
Negative Executions: 0
Reasonable Executions: 42
Failed Executions: 0
Not Run Benchmarks: 2
Not Run Benchmark List:
- sysbench-pg-cdc-100-tables-1m-rows-medium-1cn-affinity
- sysbench-mysql-cdc-100-tables-1m-rows-medium-1cn-affinity
Passed Execution List:
+-----------------------------------------------------------------+--------------+------------+---------------------+-----------------------------+
| BENCHMARK NAME                                                  | EXECUTION ID | STATUS     | FLUCTUATION OF BEST | FLUCTUATION OF LAST 10 DAYS |
+-----------------------------------------------------------------+--------------+------------+---------------------+-----------------------------+
| nexmark-q0-blackhole-medium-1cn-affinity                        |        17705 | Reasonable | -23.32%             | -1.06%                      |
| nexmark-q0-medium-1cn-affinity                                  |        17706 | Reasonable | -0.36%              | 3.21%                       |
| nexmark-q15-blackhole-medium-1cn-affinity                       |        17707 | Reasonable | -5.18%              | -0.23%                      |
| nexmark-q3-blackhole-medium-1cn-affinity                        |        17708 | Reasonable | -12.30%             | 0.77%                       |
| nexmark-q16-blackhole-medium-1cn-affinity                       |        17709 | Reasonable | -18.22%             | -0.89%                      |
| nexmark-q4-blackhole-medium-1cn-affinity                        |        17710 | Reasonable | -6.42%              | 1.12%                       |
| nexmark-q5-blackhole-watermark-medium-1cn-affinity              |        17711 | Reasonable | -9.67%              | 0.90%                       |
| nexmark-q17-blackhole-medium-1cn-affinity                       |        17712 | Reasonable | -11.85%             | -0.94%                      |
| nexmark-q5-blackhole-medium-1cn-affinity                        |        17713 | Reasonable | -9.09%              | 1.09%                       |
| nexmark-q7-blackhole-watermark-medium-1cn-affinity              |        17714 | Reasonable | -22.24%             | 0.70%                       |
| nexmark-q18-blackhole-medium-1cn-affinity                       |        17715 | Reasonable | -4.58%              | -1.16%                      |
| nexmark-q5-rewrite-blackhole-medium-1cn-affinity                |        17716 | Reasonable | -20.61%             | -7.60%                      |
| nexmark-q8-blackhole-watermark-medium-1cn-affinity              |        17717 | Reasonable | -4.53%              | -0.33%                      |
| nexmark-q19-blackhole-medium-1cn-affinity                       |        17718 | Reasonable | -10.24%             | -4.54%                      |
| nexmark-q7-blackhole-medium-1cn-affinity                        |        17719 | Reasonable | -30.50%             | 0.21%                       |
| nexmark-q9-blackhole-watermark-medium-1cn-affinity              |        17720 | Reasonable | -6.12%              | -0.54%                      |
| nexmark-q7-rewrite-blackhole-medium-1cn-affinity                |        17721 | Reasonable | -16.73%             | -0.16%                      |
| nexmark-q20-blackhole-medium-1cn-affinity                       |        17722 | Reasonable | -4.29%              | -0.70%                      |
| nexmark-q18-blackhole-watermark-medium-1cn-affinity             |        17723 | Reasonable | -3.02%              | -0.43%                      |
| nexmark-q8-blackhole-medium-1cn-affinity                        |        17724 | Reasonable | -8.31%              | -0.00%                      |
| nexmark-q101-blackhole-medium-1cn-affinity                      |        17725 | Reasonable | -3.98%              | -0.36%                      |
| nexmark-q6-group-top1-blackhole-watermark-medium-1cn-affinity   |        17726 | Reasonable | -5.72%              | 0.49%                       |
| nexmark-q9-blackhole-medium-1cn-affinity                        |        17728 | Reasonable | -6.07%              | 0.72%                       |
| nexmark-q102-blackhole-medium-1cn-affinity                      |        17729 | Reasonable | -6.83%              | -1.35%                      |
| nexmark-q12-blackhole-medium-1cn-affinity                       |        17730 | Reasonable | -5.84%              | -0.39%                      |
| nexmark-q5-many-windows-blackhole-watermark-medium-1cn-affinity |        17731 | Reasonable | -11.18%             | 1.94%                       |
| sysbench-oltp-point-select-medium-3cn                           |        17732 | Reasonable | -15.58%             | 0.80%                       |
| nexmark-q103-blackhole-medium-1cn-affinity                      |        17733 | Reasonable | -3.59%              | -0.60%                      |
| sysbench-select-random-points-medium-3cn                        |        17734 | Reasonable | -15.01%             | 3.41%                       |
| nexmark-q13-blackhole-medium-1cn-affinity                       |        17735 | Reasonable | -15.87%             | 0.23%                       |
| sysbench-select-random-ranges-medium-3cn                        |        17736 | Reasonable | -17.66%             | 3.78%                       |
| backfill-datagen-100m-rows-medium-all-affinity                  |        17727 | Reasonable | -7.61%              | -11.44%                     |
| sysbench-oltp-insert-medium-3cn                                 |        17737 | Reasonable | -6.78%              | 1.01%                       |
| sysbench-select-random-limits-medium-3cn                        |        17738 | Reasonable | -40.55%             | 13.81%                      |
| nexmark-q3-no-condition-blackhole-medium-1cn-affinity           |        17740 | Reasonable | -4.40%              | 0.74%                       |
| nexmark-q104-blackhole-medium-1cn-affinity                      |        17741 | Reasonable | -6.10%              | -2.43%                      |
| sysbench-bulk-insert-medium-3cn                                 |        17739 | Reasonable | 0.07%               | 0.28%                       |
| nexmark-q5-many-windows-blackhole-medium-1cn-affinity           |        17742 | Reasonable | -44.13%             | 6.61%                       |
| nexmark-q105-blackhole-medium-1cn-affinity                      |        17743 | Reasonable | -6.57%              | -1.84%                      |
+-----------------------------------------------------------------+--------------+------------+---------------------+-----------------------------+

PLEASE CHECK THE NEGATIVE EXECUTIONS :bangbang:Date: 2024-01-02
Scheduled Executions: 41
Passed Executions: 39
Pass Percentage: 95%
Positive Executions: 0
Negative Executions: 5
Reasonable Executions: 37
Failed Executions: 0
Not Run Benchmarks: 2
Not Run Benchmark List:
- sysbench-pg-cdc-100-tables-1m-rows-medium-1cn-affinity
- sysbench-mysql-cdc-100-tables-1m-rows-medium-1cn-affinity
Passed Execution List:
+-----------------------------------------------------------------+--------------+------------+---------------------+-----------------------------+
| BENCHMARK NAME                                                  | EXECUTION ID | STATUS     | FLUCTUATION OF BEST | FLUCTUATION OF LAST 10 DAYS |
+-----------------------------------------------------------------+--------------+------------+---------------------+-----------------------------+
| backfill-datagen-100m-rows-medium-all-affinity                  |        17769 | Negative   | 13.67%              | -0.47%                      |
| nexmark-q9-blackhole-medium-1cn-affinity                        |        17770 | Negative   | -19.37%             | -12.06%                     |
| sysbench-bulk-insert-medium-3cn                                 |        17781 | Negative   | -18.81%             | -16.36%                     |
| nexmark-q3-no-condition-blackhole-medium-1cn-affinity           |        17783 | Negative   | -16.59%             | -10.75%                     |
| nexmark-q105-blackhole-medium-1cn-affinity                      |        17784 | Negative   | -15.91%             | -10.35%                     |
| nexmark-q0-blackhole-medium-1cn-affinity                        |        17747 | Reasonable | -19.14%             | 3.78%                       |
| nexmark-q15-blackhole-medium-1cn-affinity                       |        17749 | Reasonable | -3.40%              | 1.43%                       |
| nexmark-q3-blackhole-medium-1cn-affinity                        |        17750 | Reasonable | -12.75%             | 0.22%                       |
| nexmark-q0-medium-1cn-affinity                                  |        17748 | Reasonable | 3.00%               | 5.80%                       |
| nexmark-q16-blackhole-medium-1cn-affinity                       |        17751 | Reasonable | -19.39%             | -2.02%                      |
| nexmark-q4-blackhole-medium-1cn-affinity                        |        17752 | Reasonable | -16.90%             | -9.04%                      |
| nexmark-q5-blackhole-watermark-medium-1cn-affinity              |        17753 | Reasonable | -14.49%             | -3.94%                      |
| nexmark-q17-blackhole-medium-1cn-affinity                       |        17754 | Reasonable | -11.42%             | -0.40%                      |
| nexmark-q5-blackhole-medium-1cn-affinity                        |        17755 | Reasonable | -13.86%             | -3.70%                      |
| nexmark-q7-blackhole-watermark-medium-1cn-affinity              |        17756 | Reasonable | -18.99%             | 4.27%                       |
| nexmark-q18-blackhole-medium-1cn-affinity                       |        17757 | Reasonable | -6.83%              | -3.07%                      |
| nexmark-q5-rewrite-blackhole-medium-1cn-affinity                |        17758 | Reasonable | -20.03%             | -6.12%                      |
| nexmark-q8-blackhole-watermark-medium-1cn-affinity              |        17759 | Reasonable | -8.28%              | -3.74%                      |
| nexmark-q19-blackhole-medium-1cn-affinity                       |        17760 | Reasonable | -4.91%              | 0.99%                       |
| nexmark-q7-blackhole-medium-1cn-affinity                        |        17761 | Reasonable | -32.38%             | -2.19%                      |
| nexmark-q9-blackhole-watermark-medium-1cn-affinity              |        17762 | Reasonable | -11.81%             | -5.79%                      |
| nexmark-q7-rewrite-blackhole-medium-1cn-affinity                |        17763 | Reasonable | -13.11%             | 3.64%                       |
| nexmark-q20-blackhole-medium-1cn-affinity                       |        17764 | Reasonable | -1.94%              | 1.52%                       |
| nexmark-q18-blackhole-watermark-medium-1cn-affinity             |        17765 | Reasonable | -4.30%              | -1.54%                      |
| nexmark-q8-blackhole-medium-1cn-affinity                        |        17766 | Reasonable | -15.51%             | -6.94%                      |
| nexmark-q101-blackhole-medium-1cn-affinity                      |        17767 | Reasonable | -8.24%              | -4.21%                      |
| nexmark-q6-group-top1-blackhole-watermark-medium-1cn-affinity   |        17768 | Reasonable | -6.98%              | -0.75%                      |
| backfill-datagen-100m-rows-medium-all-affinity                  |        17769 | Reasonable | 13.67%              | -0.47%                      |
| nexmark-q102-blackhole-medium-1cn-affinity                      |        17771 | Reasonable | -11.33%             | -5.39%                      |
| nexmark-q12-blackhole-medium-1cn-affinity                       |        17772 | Reasonable | -10.38%             | -4.57%                      |
| nexmark-q5-many-windows-blackhole-watermark-medium-1cn-affinity |        17773 | Reasonable | -13.36%             | -0.49%                      |
| sysbench-oltp-point-select-medium-3cn                           |        17774 | Reasonable | -19.60%             | -3.52%                      |
| sysbench-select-random-points-medium-3cn                        |        17775 | Reasonable | -17.99%             | -0.19%                      |
| nexmark-q103-blackhole-medium-1cn-affinity                      |        17776 | Reasonable | -6.35%              | -3.02%                      |
| sysbench-select-random-ranges-medium-3cn                        |        17777 | Reasonable | -20.19%             | 0.50%                       |
| nexmark-q13-blackhole-medium-1cn-affinity                       |        17778 | Reasonable | -21.10%             | -5.29%                      |
| sysbench-oltp-insert-medium-3cn                                 |        17779 | Reasonable | -10.29%             | -2.41%                      |
| sysbench-select-random-limits-medium-3cn                        |        17780 | Reasonable | -46.00%             | 2.88%                       |
| nexmark-q104-blackhole-medium-1cn-affinity                      |        17782 | Reasonable | -8.93%              | -4.73%                      |
| nexmark-q5-many-windows-blackhole-medium-1cn-affinity           |        17785 | Reasonable | -48.43%             | -1.40%                      |
+-----------------------------------------------------------------+--------------+------------+---------------------+-----------------------------+

nightly-20240102
56ce4e2bdf063c7a1cc5f565880c273c74fada7a https://github.com/risingwavelabs/risingwave/pull/14303
72ccc845dac6afaaa6fa1a29c6c94463b8c549ac https://github.com/risingwavelabs/risingwave/pull/14295
f54cb93d9a16b382ab1a4809318fc9c64cd1c29e https://github.com/risingwavelabs/risingwave/pull/14260
43383aaacbf1896b0430b253f30aea8c75f8d8e0 https://github.com/risingwavelabs/risingwave/pull/14299
7c84d06ff4f8b705117b862619a1f6766ca2d4c0 https://github.com/risingwavelabs/risingwave/pull/14225
b38da9cead2dbda82409b3e3926a85537253b309 https://github.com/risingwavelabs/risingwave/pull/14277
1f4b882dbf3f5b4571f1814cc88c54b861fa88f8 https://github.com/risingwavelabs/risingwave/pull/14191
0c94093a898e78fa04bb295f08e0552cf334cad9 https://github.com/risingwavelabs/risingwave/pull/13331
ceedd4195f8d5b3084f7b494ca0ab7965634246d https://github.com/risingwavelabs/risingwave/pull/14292
144e87a375c220f1571a6e49137a1fa9ebf882ba https://github.com/risingwavelabs/risingwave/pull/14289
1b691dd93910d7234e90f9ac8ca80f486f8c1628 https://github.com/risingwavelabs/risingwave/pull/14281
4f5b16707058f52f9221c571b2acedc996ea1377 https://github.com/risingwavelabs/risingwave/pull/14288
05fae9f6bf0885a50ec93be3aec5616aa5d07b34 https://github.com/risingwavelabs/risingwave/pull/13296
481aaaba820037d0d064cd678063fafeae2f1067 https://github.com/risingwavelabs/risingwave/pull/14266
9161189d54006c25d4d11b5480baf10a7a5976cf https://github.com/risingwavelabs/risingwave/pull/14278

https://github.com/risingwavelabs/risingwave/pull/13331 is suspicious

#13331 is suspicious

Trying to confirm with
https://buildkite.com/risingwave-test/nexmark-benchmark/builds/2838
RW_CONFIG="{'system':{'checkpoint_frequency':2}}"
BENCH_NAMESPACE="xx-freq"
BENCH_TESTBED="medium-1cn-affinity"
LABELS="compute-compactor-affinity"
NEXMARK_QUERY="q9"
RW_VERSION="nightly-20240102"

It works(194.2k).

I can set up the new baseline if that's OK.

As we do not use the special config in real-world cases, maybe we should use the benchmark result after nightly-20240102 as the new baseline?

Dicussed today with the QA team that we will try three configs, cf = 1,2,10, if the results differ a lot, we keep them as a weekly test, if diff little, we will run the three settings as even more infrequently


Just try to build with ffmpeg 6

I'm just trying to run the CIs with FFMPEG 6.
xref: https://github.com/PyAV-Org/PyAV/discussions/1518

hmm, it seems your standard tests do run on FFMPEG 6.1.1...


NEP5: In C#.NEO, you can't have a method and an event with the same name (e.g. transfer) as required in the specification

The NEP5 spec (https://github.com/neo-project/proposals/blob/master/nep-5.mediawiki) states that there are to be a Required method and a Required event both called transfer.  This isn't allowed in C#.NEO.
Is this an error/bug in the specification? Is there a specification that is more current/up-to-date?

Here is an example:
https://github.com/neo-project/examples-csharp/blob/master/ICO_Template/ICO_Template.cs#L28

The next line in the example is what I've referring to: https://github.com/neo-project/examples-csharp/blob/master/ICO_Template/ICO_Template.cs#L29 doesn't conform to the specification or visa versa.
The event is called transfer in the specification and Transferred in the example.

The method name is not important and isn't specified in the spec as it is compiled away.  Only the event name matters.

NEP5 is really an interoperability specification between NEP5 smart contracts and wallets ...that's why it needs to reliable.


Connect to a HA consul

In an HA environment we will have multiple node (ex. https://a.consul.mycompany.com:8500, https://b.consul.mycompany.com:8500, ...). Because that library support only one host I'm wondering what's the best practice here?

Should host support an array of nodes and we would need to maintains membership information in order to keep track of the master node?
Use Fabio or other load balancer?
Round robin DNS?
Should we install the consul agent locally and use https://localhost:8500 as endpoint.

Thanks!

I've always used the local agent method.


[3.x] Update Bullet Area overlaps when Area properties or shapes change.

3.2 version of #42306.

Closing for now because it should be possible to cherry-pick #42306 directly.


always use pseudo-regex in pattern_match()

This PR changes the behaviour of the filter to add the option to select by exact match of model, scenario, region name, or use * as a wildcard.

If both level and variable is in the dictionary, this is checked anyway 10 lines above.
This line here is only applied if only level is given.

ok, lgtm


Create rule "module-folder-structure"

This PR adds the rule module-folder-structure to the project.
Solves #2.
Also, a small refactor in src/rules/registry.ts was made.
TODOs:

[X] - Create rule boilerplate
[X] Register rule
[X] Create test cases
[X] Implement basic patterns check
[X] Implement strict mode
[x] Implement glob patterns check
[X] Create example docs - readme
[x] Create docs - docExampleConfigs

@sergioflores-j please fix the conflicts and the pipeline run results so we can review this one next :)

@flaviostutz PR should be ready now!
Can you review it?


CropBounds property seems to be readonly after initialization

Can we use this property to change the bounds dynamically from the parent controller for instance ?
I just tried but it doesnt seem to change anything. I'm trying to set a min width and height on crop size through using cropBounds size as watch.
Here is my code :
$scope.$watch('pictureUploader.cropBounds', cropBounds => {
if (cropBounds && cropBounds.top !== undefined) {
  console.log('cropBounds', cropBounds, cropBounds.getWidth(), cropBounds.getHeight());
  if(cropBounds.getWidth() < minCropSize){
    // This is logged properly, yet updating cropBounds has no effect
    console.log('Blocking crop bounds');
    vm.cropBounds.right = cropBounds.left + minCropSize;
    vm.cropBounds.bottom = cropBounds.top + minCropSize;
  }
}
});

getBounds (and therefore getCropBounds) return a new bounds object with values set by calculating the marker positions on the fly. As such it behaves in a read only manner. I will make a function called setBounds which will then update the marker positions which you can then use in your code.

Ok so I have now added this new function  setBounds(bounds). Just pass in a bounds object and it will update the current crop rectangle. The bounds value is in screen/canvas coordinates so 0,0 is the very top left. Also note that if keepAspect is turned on then the bounds should ideally keep the same aspect. The function is very bare bones so does no checking/clamping of values. Let me know how you go as I have tested it minimally.

That sounds great but how should I access this internal function for my controller or my template ?

Ah yes. Having looked over it again, it seems that it will be better if I integrate the min size feature into the corner dragging logic itself rather than having to watch values etc. Half way through implementing it and will finish it off tomorrow.

Awesome ! Thanks a lot, I can't wait to test it !

Have now updated the code so that either a min-width and/or a min-height can be set for enforcing a min size. This turned out to be more difficult than I initially thought as it needed to work with the enforcing of aspectRatios (if enabled).

I'll try to test that today or tomorrow and keep you posted

Hi again,
This looks promising but I think it doesn't work properly. How do you calculate the sizes regarding the original image ?
For instance, if I have an image that is 1200x1200, and min-width/height of 600, I should be able to drag the corners between 600 and 1200. But it seems that as the image is shrunk to fit it in the canvas, the mins are not calculated properly.
See the attached JSbin, If you try to upload a 1200x1200 image, for some reason, the cropping square is locked and I can't resize it, even though my mins are 600...
http://jsbin.com/tujuyaxumu/2/edit?html,js,output

Also, can I bind to these properties to variables in my scope like that ?
min-width="{{myCtrlerAs.minCropSize}}" min-height="{{myCtrlerAs.minCropSize}}"

The problem is that min-width and min-height are in screen dimensions and not source image dimensions. Set the sizes to something smaller than your crop-width and crop-height  and it should work fine.
The reason min sizes are in screen dimensions is that they relate directly to the crop area dimension parameters, which, are also in screen space. I did this because the source image dimensions will always be changing and therefore a min crop area on screen would look different depending on the size of the image. Of course maybe there is a particular use case where you think it would be better for it to be based on the source image dimensions instead?
Also I have now updated it for two-way binding so you can link to your properties.

Hi Allan,
Indeed this info helped me figuring this out. It does work better when you keep the min-* equal or below crop-*. However, I'm having issues with a 1200x1200 image that breaks the clamps position and I can't figure If the issue is in my code or if I found a bug in some corner case. Could you update your jsbin demo with the latest version of the lib so that I can test this scenario ?
Thanks a lot !

I have updated the JSbin. Let me know what settings you are using with it so I can replicate the issue.

Yep, I did fix one of my issues, but now I've noticed that when you swap pictures, the canvas does not seem to reset properly and keeps some of the config of the previous image.
For instance, on this JSBin :
http://jsbin.com/gupopomofa/1/edit?html,js,output
If I put in a 928x580 image with the config, the crop bounds are set on the boundaries of the image in the canvas as expected, but If I start after a refresh with a 540x800 image then swap it for the 928x580, then the crop bounds remain like they on the previous image ...

Ah yes. I have now fixed this. The crop area will now default to the max possible size with respect to any of the parameters such as crop ratio. This seems to fix the scenario you mentioned.

Thanks !
I'll try to give it a try this afternoon or in the week-end.

Excellent, everything works perfectly now !
I still need to try a lot on mobile so maybe i'll come back with new issues in a few days ;)
Keep up the good work !

Great! Had a quick test running it on an IPad3. It seems to be working well although performance seems to have dropped a little so I might have to investigate that.


Should not show "no lib directory" warning for root package

It's valid to have a root app package that does not have a lib directory because it only has entrypoint files in "bin", or "web". Given that, we shouldn't show a warning if the root package doesn't have a lib directory, only if packages you depend on don't.

This issue has been moved to dart-lang/pub#145.