Aerial get lost when changing to next or previous buffer

If buffer in focus is changed by using comands like :bnext or :bprevious, there is a moment when Aerial starts to get unsynchronized with active buffer.
System information

OS: Linux
Neovim version: v0.7.2
AerialInfo:
-----------
Filetype: java
Configured backends:
lsp (supported) (attached)
treesitter (supported)
Show symbols: Class, Field, Variable, Constructor, Enum, Function, Interface, Module, Method, Struct
Aerial config:

    aerial.setup {
        log_level = 'info',
        backends = { "lsp", "treesitter" },
        filter_kind = {
            "Class",
            "Field",
            "Variable",
            "Constructor",
            "Enum",
            "Function",
            "Interface",
            "Module",
            "Method",
            "Struct",
          },
    }

To Reproduce
Steps to reproduce the behavior:

Open several buffers
Toggle Aerial
Change buffer in focus with :bnext and :bprevious commands

Yes, it still matches one of the buffers, it never freezes. If I switch to other active buffer Aerial may switch (or not) to another buffer. The weird thing is that even that Aerial shows a structure from a different buffer, if I navigate with the cursor within active buffer, Aerial changes highlight in methods and classes as if I was navigating the buffer that Aerial shows.
Another weird thing is that if I have Aerial window opened in the right, the first time I use :bn to change buffer, the new buffer code shows up in the window where Aerial was. I have to open Aerial again. I would say that this is the moment the mess starts.
I initially suspected that it may be related with Bufferline plugin but after removing it, the problems persists

This is super weird behavior that I haven't heard of before. Do you see anything similar happen if you use the treesitter backend or if you use a different language server? I'm trying to set up JDTLS to see if I can repro, but so far I haven't managed to get it working :(

Update: I managed to get JDTLS working and was able to repro the issue (with version 0.70.0; I couldn't get newer versions to run). From what I can tell, it looks like a bug in the language server. When I switch buffers, the call to textDocument/documentSymbol returns symbols for the wrong file.
When I get more time I'll try to dig into it more to either find a workaround or create a minimal repro to report upstream, but in the meantime my recommendation is to use the treesitter backend.

Thank you very much for your effort. It is too late but if you have troubles setting up JDTLS, here you have my config. You have developed a great plugin.
The reason I am using LSP as backend instead Tressitter is because with the last one, Aerial does not show variables, just methods and classes (at least in Java). I have checked that indeed Tressitter detects variables, is there a reason why Aerial does not show them?

I don't know what the exact conditions are, but this (aerial.nvim shows the outline of a different file) happens to me as well, where I'm using pyright language server for aerial.nvim editing python files.

@magidc It's just that almost all of the treesitter queries and parsing logic was added by me, and parsing every symbol type for every language was a ton of effort, so I only added support initially for the "main" symbol types, with the intention of progressively adding more as people requested them. Happy to add variable support for Java!
@jaekyeom Interesting; it's possible that there's something else going wrong with your pyright setup, or it's possible that I incorrectly identified the root cause. I'll do a deeper dive and see if I can find anything

Turns out there was a subtle bug in my calls to the LSP methods! It created a race condition where sometimes the generated parameters wouldn't match with the buffer. Try again on the most recent master and let me know if that fixes the issue

It works like a charm. I was not able to make Aerial out of sync with the active buffer. Thank you very much!!


How can I get the image path ?

In my app I need imagepath to delete it from the photo gallery after selecting it

The image path is not needed to delete an image:
PHPhotoLibrary.shared().performChanges({
    for asset in assets {
        if let phasset = asset.originalAsset, phasset.canPerform(.delete) {
            PHAssetChangeRequest.deleteAssets([phasset] as NSFastEnumeration)
        }
    }
}) { (success, error) in
    // ...
}


Update list.md

This is not an error, but a suggestion concerning to adding empty values in fields. Thank You

Thanks. A better (IMO) alternative would be to add a required attribute into the input tag instead. What do you think?

Yea that make sense too. That is the best answer to my suggestion. Thanks @phanan


[REQUEST] Add posibility to put back item at the end of the queue in case of unhandled exception in the work Function | RuriLib.Parallelization

Hello, First of all I have to say this library is very useful and works very well.
I came across a problem, let's say I have the following code:
Func<int, CancellationToken, Task<string>> workFunction = new(async (number, token) =>
            {
                var res = DoSomeWork(number);
                if (res == true)
                {
                    // this function can throw an exception in some cases (let's say it is an http request for exemple)
                    DoSomeOtherWork(number);
                    return "WhatEver result";
                }
                else
                {
                    return "WhatEver result";
                }
            });

            var parallelizer = ParallelizerFactory<int, string>.Create(
                type: ParallelizerType.TaskBased, // Use task-based (it's better)
                workItems: Enumerable.Range(1, 100), // The work items are all integers from 1 to 100
                workFunction: workFunction, // Use the work function we defined above
                degreeOfParallelism: 5, // Use 5 concurrent tasks at most
                totalAmount: 100, // The total amount of tasks you expect to have, used for calculating progress
                skip: 0); // How many items to skip from the start of the provided enumerable
                parallelizer.TaskError += OnTaskError;
                await parallelizer.Start();

In this workFunction when the do DoSomeOtherWork throw an exception it will trigger TaskError event but the item is considered as "completed" and not put back in the queue so if I want to process it I would have to recreate a Parallelizer only with the failed items. this would be easier if there was possibility to put directly back in the queue when the workFunction got an unhandled exception. This feature could be possibly activated or deactivated by a simple parameter in the ctor.

Wouldn't it be easier to just do something like
int maxTries = 10;
int currentTry = 1;
START:
try
{
    var res = DoSomeWork(number);
}
catch (Exception ex)
{
    Console.WriteLine(ex.Message);
    if (currentTry++ < maxTries)
    {
        goto START;
    }
}

In the OB2 code, for example, I use the goto to loop until one of these conditions happen

the bot ends with a good status (e.g. not BAN or ERROR)
the user cancels the work manually

If you give me a reason why this behaviour wouldn't be suitable, I will implement the feature that you asked for.

Thanks for responding. Of couse yes that would work but let's say the item you're processing is "banned" (because of some cooldowns for exemple) so you retry again and again but as the item is "banned" so it will never end with a good status. With this feature as the item is put at the end of the queue, while the other items are getting processed, the item that was put at the end of the queue is getting unbanned, so now reprocessing it will not give a bad status. I hope you understand what I mean

I'll see if I can find some time to do this, but I'm marking it as low priority for now since there are important performance issues to address first.

No problems, take your time. I wish I could help you but I'm not experienced enough in c# and don't understand fully the code.


UDP Distribute and then forward

Hello,
I have implemented a sample application in OFP refering the UDP Fwd Sock and Echo applications. My application does the following.
Creates a control thread, cli thread and dispatcher on cpu 0 as is being done in udp fwd sock.
Creates all other available cores as worker threads let's say 15.
Out of these use 3 as distributors
And the rest 12 as forwarders
The distributors recieve pkts from pktio interfaces in direct mt_unsafe mode
I have implemented a local udp hook in which we check if the udp dport matches my port then we enqueue the packet to one of the processor thread queues. These queues are plain odp queues. The processor thread recieves the packet and finally forwards it using ofp_udp_sendto()
I am facing memory corruption issues while running this application.
While sending the packet from distributor to processor thread I have taken a new packet from ofp_packet_pool using odp_packet_copy (but the packet pointer of the new and old is same when printed). Do I need to use a self defined packet pool for the same?
Also the udp local hook if called from multiple distributor threads simultaneously can create an issue?
Is there any other mechanism by which I can recieve packets with same dip and dport hashed on multiple threads? I don't want them multicasted so can't recieve on same udp port also.

Attaching my c file here:
https://drive.google.com/file/d/1A0K6qVfXMGtF_x6232X6ihADUkoW3tlY/view?usp=drivesdk
Single single packets are being forwarded ok
When we send a direct load at times it core dumps saying stack corruption
If it doesn't dump core then 90% packets land up on slow path.
Could someone please review the code and suggest what we are doing wrong as we are very new to OFP/ODP

First, I am sorry that I cannot spend more time on this. I am contributing to ofp in my free time... but I don't have much free time.

I suspect the problem is related to the odp_packet_free() from line 250... removed it and check
OFP_HOOK_LOCAL_UDPv4 was designed to work differently:

static enum ofp_return_code fastpath_local_hook(odp_packet_t pkt, void arg)
{
........
if(odp_be_to_cpu_16(uh->uh_dport)==TEST_LPORT) {
/ do processing like enqueue the packet /
return OFP_PKT_PROCESSED;   / that means: I have ownership on pkt */
}
return OFP_PKT_CONTINUE;    /* that means: stack has ownership and can continue to process it, etc.*/

}
You may use globals and odp_cpu_id() and teid to find the right queue.

pktout: you need to give a pktout to the core 0 (a timeout may trigger sending a packet) - ideally will be to give a pktout to each core even if not used (when pktout_param.op_mode is ODP_PKTIO_OP_MT_UNSAFE)

ofp_udp_pkt_sendto(): my understanding is that the head on the packet have to be modified to point to the beginning  of the udp payload. Also, this function takes ownership on the packet ... so you should not free it yourself (line 250).

Hello Bogdan,
Thanks a lot for spending some time on this.
I tried removing the free from line 250 but the issue still persists.
I rather suspect that the issue is, memory not being freed somehow or corrupted somewhere.
I hope its alright for me to send the pkt received on one thread to another thread by enqueing the same. As per my understanding the pkt memory is still accessible to the other thread since its shared memory from ofp_packet_pool?

Hello Bogdan
Big thanks for helping me out
I had been trying to get this to run since whole last week!
Did all changes you suggested
And it seems to be working fine now
Once again Thanks!
I have another query unrelated to this
Any idea about the roadmap of fragmentation n reassembly support for Ipv6 in OFP
Also it seems from the code that vrfs are there in Ipv6 but the documentation says not supported.

Great news!!
On roadmap topic I let the Nokia and Enea engineers to speak. Guys?
The 'IPv6 fragmentation / reassembly' topic was considered some time ago (see https://github.com/OpenFastPath/ofp/issues/44) but IPv6 was not really requested.


Makefile: bump version to v7.1.0

What problem does this PR solve?

Issue Number: ref https://github.com/pingcap/tiflow/issues/7488
What is changed and how it works?
Check List
Tests

No code

Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note
None

/run-all-tests

/cc @amyangfei

/merge

/run-kafka-integration-test

/run-integration-test

/run-integration-test

/run-kafka-integration-test


when a notification rule is updated, cancel its existing task and create a new one

or update task

fixed in https://github.com/influxdata/influxdb/pull/14857


var upload = this.s3.upload(params)  TypeError: this.s3.upload is not a function

aws.config.update({
    secretAccessKey: 'key',
    accessKeyId: 'secret',
});

var s3 = new aws.S3()

var upload = multer({
  storage: multerS3({
    s3: s3,
    bucket: 'pdsfiles',
    metadata: function (req, file, cb) {
      cb(null, {fieldName: file.fieldname});
    },
    key: function (req, file, cb) {
      cb(null, Date.now().toString())
    }
  })
})

This is what the error looks like:
TypeError: this.s3.upload is not a function
at S3Storage. (/home/simran/Downloads/NODE-BACKEND/node_modules/multer-s3/index.js:172:26)
at /home/simran/Downloads/NODE-BACKEND/node_modules/multer-s3/index.js:58:10
at S3Storage.getContentType (/home/simran/Downloads/NODE-BACKEND/node_modules/multer-s3/index.js:8:5)
at /home/simran/Downloads/NODE-BACKEND/node_modules/multer-s3/index.js:55:13
at end (/home/simran/Downloads/NODE-BACKEND/node_modules/run-parallel/index.js:16:15)
at _combinedTickCallback (internal/process/next_tick.js:73:7)
at process._tickDomainCallback (internal/process/next_tick.js:128:9)
Call:
router.put('/updatePatternGrading/:pattern_number', upload.any(), function(req, res){
     console.log("request obj after manipulation", req.files);
     callAPI(req, res, fn.bind(apiObj, 'updatePatternGrading'));
 })

Why do I get this ?

Can I have a response on this, please? It feels impossible to use this package :'(

Hmm 🤔
It might be that you need to have new before multerS3, i.e. storage: new multerS3({.
We should probably throw an error to make that more clear though...


vscode: Fix extensions directory path

Description
Fixes #1302
as a result of upstream vscode extension path changes here:
https://github.com/NixOS/nixpkgs/pull/89196
Checklist
- [ ] Change is backwards compatible.

[x] Code formatted with ./format.

[x] Code tested through nix-shell --pure tests -A run.all.

[x] Test cases updated/added.

[x] Commit messages are formatted like
{component}: {description}

{long description}

Thanks! Rebased to master in 507e4464751b86b24e435bc8f178942f7d0de101.


Check plugin registry hash when registering events

Before registering events, check plugin registry for reload
Ensures that background worker plugin registry is up-to-date

Closing, I missed that check_reload is called a few lines later. My problem was actually in my plugin code...


FactoryServer.sh won't run when volumes are used

Experiencing issues? Check our Troubleshooting FAQ wiki!
Describe the Bug
Setting up a server on headless Ubuntu 24.04.1 LTS
Every time I try to docker-compose up I eventually get the same error: /home/steam/run.sh: line 106: ./FactoryServer.sh: Permission denied
Reading through related issues I've tried:

chown -R 1000:1000 ./config
chmod +x FactoryServer.sh
adding user: 1000:1000 with --ROOTLESS=true
starting compose with sudo
deleting ./config/gamefiles
adding chown 1000:1000 FactoryServer.sh in run.sh

Your Runtime Command or Docker Compose File
services:
  satisfactory-server:
    container_name: 'satisfactory-server'
    hostname: 'satisfactory-server'
    image: 'wolveix/satisfactory-server:latest'
    ports:
      - '7777:7777/udp'
      - '7777:7777/tcp'
    volumes:
      - /media/serv/satisfactory/config:/config
    environment:
      - MAXPLAYERS=6
      - PGID=1000
      - PUID=1000
      - ROOTLESS=false
      - STEAMBETA=false
#      - DEBUG=true
    restart: unless-stopped
    deploy:
      resources:
        limits:
          memory: 8G
        reservations:
          memory: 4G

Debug Output
satisfactory-server    | ===== Satisfactory Server 1.8.9 =====
satisfactory-server    | https://github.com/wolveix/satisfactory-server
satisfactory-server    |
satisfactory-server    | Debugging enabled (the container will exit after printing the debug info)
satisfactory-server    |
satisfactory-server    | Printing environment variables:
satisfactory-server    | declare -x AUTOSAVENUM="5"
satisfactory-server    | declare -x DEBUG="true"
satisfactory-server    | declare -x DISABLESEASONALEVENTS="false"
satisfactory-server    | declare -x GAMECONFIGDIR="/config/gamefiles/FactoryGame/Saved"
satisfactory-server    | declare -x GAMESAVESDIR="/home/steam/.config/Epic/FactoryGame/Saved/SaveGames"
satisfactory-server    | declare -x HOME="/home/steam"
satisfactory-server    | declare -x HOSTNAME="satisfactory-server"
satisfactory-server    | declare -x LANG="en_US.UTF-8"
satisfactory-server    | declare -x LANGUAGE="en_US:en"
satisfactory-server    | declare -x LOG="false"
satisfactory-server    | declare -x MAXOBJECTS="2162688"
satisfactory-server    | declare -x MAXPLAYERS="6"
satisfactory-server    | declare -x MAXTICKRATE="30"
satisfactory-server    | declare -x OLDPWD
satisfactory-server    | declare -x PATH="/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
satisfactory-server    | declare -x PGID="1000"
satisfactory-server    | declare -x PUID="1000"
satisfactory-server    | declare -x PWD="/config"
satisfactory-server    | declare -x ROOTLESS="false"
satisfactory-server    | declare -x SERVERGAMEPORT="7777"
satisfactory-server    | declare -x SERVERSTREAMING="true"
satisfactory-server    | declare -x SHLVL="1"
satisfactory-server    | declare -x SKIPUPDATE="false"
satisfactory-server    | declare -x STEAMAPPID="1690800"
satisfactory-server    | declare -x STEAMBETA="false"
satisfactory-server    | declare -x TIMEOUT="30"
satisfactory-server    | declare -x USER="steam"
satisfactory-server    | declare -x VERSION="1.8.9"
satisfactory-server    | declare -x VMOVERRIDE="false"
satisfactory-server    |
satisfactory-server    | System info:
satisfactory-server    | OS:  Linux satisfactory-server 6.8.0-49-generic #49-Ubuntu SMP PREEMPT_DYNAMIC Mon Nov  4 02:06:24 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
satisfactory-server    | CPU: Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz
satisfactory-server    | RAM: 30GB/32GB
satisfactory-server    | HDD: 27GB/101GB (29% used)
satisfactory-server    |
satisfactory-server    | Current version:
satisfactory-server    | 1.8.9
satisfactory-server    | Current user:
satisfactory-server    | uid=0(root) gid=0(root) groups=0(root)
satisfactory-server    | Proposed user:
satisfactory-server    | uid=1000(?) gid=1000(?) groups=1000(?)
satisfactory-server    |
satisfactory-server    | Exiting...
satisfactory-server    |
satisfactory-server    | System info:
satisfactory-server    | OS:  Linux satisfactory-server 6.8.0-49-generic #49-Ubuntu SMP PREEMPT_DYNAMIC Mon Nov  4 02:06:24 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
satisfactory-server    | CPU: Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz
satisfactory-server    | RAM: 30GB/32GB
satisfactory-server    | HDD: 27GB/101GB (29% used)
satisfactory-server    |
satisfactory-server    | Current version:
satisfactory-server    | 1.8.9
satisfactory-server    | Current user:
satisfactory-server    | uid=0(root) gid=0(root) groups=0(root)
satisfactory-server    | Proposed user:
satisfactory-server    | uid=1000(?) gid=1000(?) groups=1000(?)
satisfactory-server    |
satisfactory-server    | Exiting...
satisfactory-server exited with code 1
satisfactory-server    |
satisfactory-server    | System info:
satisfactory-server    | OS:  Linux satisfactory-server 6.8.0-49-generic #49-Ubuntu SMP PREEMPT_DYNAMIC Mon Nov  4 02:06:24 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
satisfactory-server    | CPU: Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz
satisfactory-server    | RAM: 30GB/32GB
satisfactory-server    | HDD: 27GB/101GB (29% used)
satisfactory-server    |
satisfactory-server    | Current version:
satisfactory-server    | 1.8.9
satisfactory-server    | Current user:
satisfactory-server    | uid=0(root) gid=0(root) groups=0(root)
satisfactory-server    | Proposed user:
satisfactory-server    | uid=1000(?) gid=1000(?) groups=1000(?)
satisfactory-server    |
satisfactory-server    | Exiting...
satisfactory-server exited with code 1

System Specs (please complete the following information):
===== START ISSUE REPORT =====
OS:  Linux 6.8.0-49-generic #49-Ubuntu SMP PREEMPT_DYNAMIC Mon Nov  4 02:06:24 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
CPU: Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz
RAM: 30GB/32GB
HDD: 27GB/101GB (29% used)
===== END ISSUE REPORT =====

Logs
satisfactory-server-log-241204.txt
Additional Context
run.sh Line 106: ./FactoryServer.sh -Port="$SERVERGAMEPORT" "${ini_args[@]}" "$@" &
Sucessfull docker-compose up if volumes are commented out of docker-compose.yml
Fails at the same point if only /media/serv/satisfactory/savegames:/home/steam/.config/Epic/FactoryGame/Saved/SaveGames

Hey @unsubscrieb, sorry to hear you're experiencing issues. #339 seems to be your best bet. You mentioned looking at it, but didn't mention the fix in your attempted solutions.
Of course a quick fix would be to only bind /config/saved to your host. That way, saves would persist to your host, and you would resolve the issue. Only downside is that game files would need to be redownloaded on container rebuild, but frankly rebuild is less likely to be more frequent than game updates

Hey @wolveix
Appreciate the speedy reply, my bad though for poor formatting, I did try just mapping the savegame directory but noted it in the additional info at the bottom.

@unsubscrieb ah, I did miss that; however, you're also not binding it correctly. Bind media/serv/satisfactory/config/saved:/config/saved and nothing else

@wolveix That's fixed it - thank you! Just wasn't liking it when FactoryServer.sh was part of the volume mount

For anyone else having a similar issue, I realised some more info might benfit:
I was running my containers/compose on an NTFS partition mounted to the path above (/media/serv) where my user did have owner and read/write permissions - a fallback after setting up Win10/Ubuntu dual boot to run the containers from either OS.
No issues at all when running from ext4 partition, works no issues following instructions to set up


Transport nsw

Description:
New sensor to request leave times from Transport NSW (Australia).
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for configuration.yaml (if applicable):
- platform: transport_nsw
  stopid: '209516'
  route:  '199'
  apikey: 'YOUR_API_KEY'

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works.

Hello @Dav0815,
When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).
The commits that are missing a linked GitHub account are the following:

de8a7d1616968299ac39d6e1c5ef96e652c27a84 - This commit has something that looks like an email address (dsauren+git@gmail.com). Maybe try linking that to GitHub?.
ce8b2a4177570a5550d941c17cd5b9dc18451e22 - This commit has something that looks like an email address (dsauren+git@gmail.com). Maybe try linking that to GitHub?.
f049cb0f0ccdce9d7c30f5420d41f47365d85c08 - This commit has something that looks like an email address (dsauren+git@gmail.com). Maybe try linking that to GitHub?.
bd145ae703d920b5dfe258e1cb1ff66676267d62 - This commit has something that looks like an email address (dsauren+git@gmail.com). Maybe try linking that to GitHub?.
9e4285f71fd83ef5f217cb33543bdd686c4a2f8d - This commit has something that looks like an email address (dsauren+git@gmail.com). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.
Here are your options:

If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

If you only made a single commit you should be able to rungit commit --amend --author="Author Name<EMAIL_ADDRESS>
(substituting Author Name and<EMAIL_ADDRESS>for your actual information) to set the authorship information.
If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:

You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.

Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.
Thanks, I look forward to checking this PR again soon! :heart:


add Resources and MediaInfo

I just found there's no mediainfo added to the downloaded track and also the cover poster.
please add them too.

https://github.com/oskvr37/tiddl/commit/e42ae3405f8149d4ba9d6b51a5e940a78135a9eb
Added metadata for tracks, tomorrow I will be working on covers.


UseSpaPrerendering deprecated in netcore 3.0

I suppose using the UseSpaPrerendering() extension method in netcore does not work anymore. How can I set up SSR and pass data to my angular app?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 32a18270-91cd-2a02-2eb8-2c8b1ed03737
Version Independent ID: c58d57e5-a0c2-201d-f6dd-076ad5971fcb
Content: Use the Angular project template with ASP.NET Core
Content Source: aspnetcore/client-side/spa/angular.md
Product: aspnet-core
Technology: aspnetcore-clientside
GitHub Login: @SteveSandersonMS
Microsoft Alias: stevesa

followed this article's instructions and it works like a charm for netcore 3.1 - despite the deprecation warning:
https://medium.com/@pieterjandeclippel/server-side-rendering-in-asp-net-core-angular-6df7adacbdaa

@pawod @Rick-Anderson
Will this deprecation lead to removing UseSpaPrerendering method in the future releases of netcore?
If this is true, will there be some alternatives for this or netcore developers plan to totally abandon Angular and React SPAs in favour of Blazor???

See this GitHub comment
The recommendation is to rely on the SPA framework provided SSR capabilities. For Angular, SSR support is now integrated into Angular CLI. Here is a good article about it: https://medium.com/@MarkPieszak/angular-universal-server-side-rendering-deep-dive-dc442a6be7b7


Removing broken install link

Install links broken for 3 MVC pages, because they had been JavaScript popups on the original www.asp.net website. We still do not have the ability to add these links, so removing them and leaving the standalone installer links.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@terrimorton Thank you for the contribution.


Issue with SNZB-06P Sensor Status Post-Update of SonoffLAN at v3.7.3

          Issue with SNZB-06P Sensor Status Post-Update of SonoffLAN at v3.7.3

@AlexxIT I’ve encountered a persistent issue where the status of my SNZB-06P sensors is no longer visible, although the RSSI remains accessible. This problem surfaced following the most recent update. Prior to this, the status of my three SNZB-06P sensors was displayed without any complications. It seems that the update may have inadvertently affected the sensor status visibility within the system.
I don't know if it can be useful, but the three devices are all associated with a ZBBridge-P
Originally posted by @atlaspl in https://github.com/AlexxIT/SonoffLAN/issues/1245#issuecomment-2134068446

Same problem here, I'm new to the community. Is there another report where I can get support?
This issue seems closed (#1245).
Thank you.

I have the same issue since upgrade to 3.7.3, my SNZB-06P now shows status of unknown. I needed to change the logic to use an Ewelink Scene since the status is not reported anymore.

I have the same problem....Only RSSI SNZB-06P is available.

#1245


core: add test to call contract from native

Closes #1200
I made an example of such call, but not sure if this testcase covers the problem. If so, than we are able to perform calls from native contracts and it might be necessary to implement a separate method for such calls.

This is native contract calling another native contract. Have you tried calling regular contracts from native contract?

And it's spawning another VM, which doesn't seem to be correct.

At the same time C# node mostly changes ApplicationEngine here which is an internal (to that node's implementation) thing. Still, we should consider this scenario without new VM spawning, it should be possible to do using our current VM/interop.Context APIs.

Now we have VM into interop context, so we're able to call other contracts from native contracts, but it's strange a bit, because if VM fails during invoking inner contractCall, we'll have failed VM after inner cantractCall completed. Consequently, outer contractCall fails, as these calls share the VM.

if VM fails during invoking inner contractCall, we'll have failed VM after inner cantractCall completed. Consequently, outer contractCall fails, as these calls share the VM.

Well, that's a feature. That's what would happen with regular contracts calling each other and native contracts shouldn't be that much different.


Misc. cleanups

Removed a misleading check for South (it's no longer supported)
Removed an unused PY3 variable in settings.py, which was causing an unnecessary import
Fixed a renaming issue in djdiv templatetag

I highly recommend getting rid of that djdiv template tag by the way. It's only used in one place... and where it's used, it doesn't even sort of work properly (it's float-formatting in a css class...).

Codecov Report

Merging #414 into 1.0.0 will not change coverage.
The diff coverage is 100%.

@@         Coverage Diff          @@
##           1.0.0   #414   +/-   ##
====================================
  Coverage    100%   100%
====================================
  Files         23     23
  Lines       1561   1558    -3
  Branches     185    185
====================================
- Hits        1561   1558    -3

Impacted Files
Coverage Δ

djstripe/settings.py
100% <ø> (ø)
:white_check_mark:

djstripe/templatetags/djstripe_tags.py
100% <100%> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81b0bf0...beb78c8. Read the comment docs.

Added a fix for #415 and a commit to remove the unused DJSTRIPE_CURRENCIES setting.

More stuff:

Card removal exception catch never worked (it checked for "No such customer" instead of "No such source"). Additionally, the error doesn't start with it as it starts with a request id.
Implemented _sync_cards() and added it to sync_subscriber()

Additional fixes:

Upgraded API to 2017-01-27. There were no meaningful changes, however this gives us access to canceled subscription listings
Now excluding status="canceled" in Customer.subscription so that it doesn't end up erroring
Syncing subscriptions now syncs canceled ones as well
Implemented Subscription.reactivate(), which is functionally equivalent to subscription.update(plan=subscription.plan) but has clearer semantics. See here.

I don't fully understand why travis is failing; my fork is starting to be pretty far ahead of the work I'm backporting. 017b809 is mergeable though.

Hi @jleclanche, thanks for the cleanup!
I'll take a look at this this weekend. Please split this up into separate pull requests for each change. That'll help clarify changes (and our git history) and get things through faster.

@kavdev Sorry, I don't really have the time to split this into multiple PRs. But that shouldn't matter, you can cherry-pick my changes one at a time if you use the command line; I'll make sure to rebase this.
I'd really appreciate the help figuring out why travis is failing.

@jleclanche: No worries, I understand the time issue. Thanks for submitting, but if you want features merged, they need to come through in separate PRs. It seems pedantic, but it's the best way to stay organized and keep a clean(ish) history.

As far as the tests are concerned, the test is failing when customer.subscription returns None (in the case of a 0 count). Note that first() returns None if nothing is found in the list.

@kavdev I understand why you want a clean history, so do I, which is why I'm making sure these are all separate commits.
You can for example merge only the minor cleanups by adding my remote with git remote add jleclanche https://github.com/jleclanche/dj-stripe; git fetch jleclanche and then run git merge 82d3e39c24ce57996adc10140b4a0e6381eb0c98. It'll even preserve the hash since it's rebased.
I'll pull the Card.api_list() fixed into its own pr.

@jleclanche @kavdev I'll volunteer to separate these commits into separate PRs, sound good?

I've added two more commits which fix a race condition and a pretty basic crash.
So for context: we've had to fork dj-stripe because of the JSONField issues, since we're using Postgres and Django 1.10 and the JSONField currently in dj-stripe is unsuitable for that. In forking, I've found a plethora of issues with the library and an extremely misleading test suite (100% coverage means nothing if 90% of it is mocked). On top of that, to decrease complexity and areas to cover, I've dropped Python <3.4 support and Django<1.10. Because of all that, the fork is rapidly diverging from upstream.
Now, I've tried maintaining the cleanup/misc branch here PR'd with bits and pieces which are suitable to land on master. But if every single commit I make requires me to file a separate PR (which involves creating a new branch, cherry-picking the commit onto it etc), I'm going to stop doing that. There's a reason pull requests support multiple commits, and they can all be reviewed separately and even landed separately if you so wish.
I'm open to (and would prefer) working together, but please don't waste people's time.

I'm going to step in and say something as diplomatically as I can.
First off, @jleclanche, thank you for your contributions. I admire your other work. It's great to get a fresh pair of eyes, especially of your caliber, on a project. Including the PostgreSQL field is a welcome change to the project, and implementing it here is something I've wanted to have the time to do for ages. Also dropping legacy python support is a bonus.
I also understand not wanting to get bogged down in the minutia of opening a lot of pull requests. It's a lot of work, and if you have a tight schedule its hard to fit that kind of work into your schedule.
That said, keep in mind that @kavdev and the other maintainers here are volunteers. Instead of keeping this code to themselves, they share it with the world. And in return they get paid nothing. That's correct, they are maintaining a package that literally earns companies and other coders like you money, and in return they get no financial compensation. Not that it hasn't been asked for, it's just that no one has ever followed through on payment. Not for feature additions, bug fixes, and certainly not for middle-of-the-night emergency patches.
So when you open a massive pull request that changes things across a project, and is hence hard to review, that's hard on the maintainers. They have to give up a substantial amount of their free, uncompensated time to review your work.
But that's okay. Again, I understand that you are busy. We all are busy, right? Fortunately, @dmkoch volunteered to break up your pull requests into smaller, more atomic PRs. Ones that are easier to review, because there is less chance of edge cases. And because they are smaller the core devs can review each one in the spare moments they get when Docker is rebuilding, tests are running, etc.
However, to have a comment with the tone of your last one, and then to end it with these words is just wrong:

I'm open to (and would prefer) working together, but please don't waste people's time.

For a project maintainer who isn't paid, that's infuriating. It's disheartening. It's unfair. Even if you do get paid, it's wrong to hear that kind of commentary. As I said, it's wrong.
You're an experienced open source project maintainer hence why I'm shocked by your response. Instead of being willing to work through people trying to help get your changes in, you berate them and their hard work.
 You aren't thinking about how your code affects MySQL users. Or how challenging it is to write ongoing integration tests against a third-party API. And yet you had an offer from someone to help you get it in. I bet if someone asked for these kind of chances in django-push-notifications or fireplace you would push back just like @kavdev did.
Please remember that at the end of the day we're all coders.

@pydanny I'm sorry my tone came off as aggressive. it wasn't meant to be. With that said, you are misunderstanding the situation.
This PR here is merely harmless cleanups, rebased for your convenience. It's commits which I know are mergeable as-is on dj-stripe. I maintain several other Django apps, I understand your situation and I do care about compatibility, which is why I have not included any of the Py3/Postgres commits in here. The breaking commits on my fork are not in this PR.
However, asking contributors to file one pull request per commit is egregious and really does not help with a clear history. I take having a clear git history seriously (it's a form of documentation). You'll note every logical change is separated into its own commit.
I appreciate your guys' work a lot, dj-stripe saved me a lot of time in webhook processing and model setup, which is why I want to make sure to contribute back in improving the more problematic areas of it. I don't mind when a library is unmaintained, or when maintainers are unresponsive, or when inclusion rules are extremely strict, I can deal with all that but arbitrary rules such as how the work is split on Github are a waste of your contributors' time, which is why I got annoyed. Hope you understand and take this into account.

@jleclanche Now that I've taken the time to look at this PR with a bit more depth (and realized I've induced confusion in the comments with poor word choice) , let's take a step back here:
First off, it's important to highlight that this is a community project. We rely on bug reports and feature input from the community and dedicate our free time to building and maintaining the project. As such, there's no reason for (perceived) hostility and annoyance. Yes, there are bugs, and yes, our network calls to Stripe are mocked, but the proper way to go about contributing to a project is to inform and propose a better solution, not rant about something the contributors have overlooked or have written poorly.
We, of course, welcome and appreciate all of the cleanups and fixes you've contributed. I want to make it very clear, however, that atomic pull requests are still required if you want a PR to be accepted and merged. Having each big issue in a separate PR contains both the changes and conversations surrounding that issue in a neat bundle. The conversation is focused at the task at hand, which allows for clear communication on one topic among the maintainer, the request author, and any community members that wish to weigh in on the issue. There is leeway for bundling atomic commits when the commits concern small cleanups and bugfixes, but this PR doesn't completely fit in that category (see below).
All that said, feel free to keep pushing to this branch. Although we disagree on how best to handle operations, that disagreement should not lead to the community missing out on the fixes and improvements you're contributing. At the end of the day, it seems we both have the same goal of making this package better for everyone.
I understand that you don't have the time to split up this PR -- it's the unfortunate reality of OSS. When I do get the time (we're setting up a 20% time thing at work soon), I'll go ahead and piece this out and comment on each.
There are definitely some cleanup commits/small bugfixes that can remain combined in this PR:
Remove old reference to South
Fix a renaming issue in djdiv templatetag
Remove unused import/variable in settings.py
Fix catching card removal errors when the card is deleted upstream
Remove an unnecessary mixin from AccountView
travis: Use Postgres 9.4 -- except I'd say use latest 9.6
Remove completely unused PASSWORD settings
But there are others that need to be split up for either community discussion or more review:
Remove unused CURRENCIES setting
Implement Customer._sync_cards() method, Sync customer cards on sync_subscriber()
Use a get_or_create with defaults on Customer.create
Fix a crash in CancelSubscriptionView if the subscription is missing
As a note, our policy is to only support the latest django and Python (with the exception of 2.7). If there's a breaking change (or better feature) in a new version, we'll support that change and drop support for lesser versions. Feel free to propose changes with that in mind.
Again, the goal here is to make better software -- I'm all for working together to make that happen.

@kavdev again, I'm sorry my comments came across as so hostile, that was really not the intention. I certainly have my frustrations with dj-stripe but it's nothing that can't be fixed. Anyway, what you're saying here is totally reasonable, and I don't have a problem splitting some commits up into a separate PR but I hope you understand why I would consider splitting two typo fixes into their own PRs a waste of time.

travis: Use Postgres 9.4 -- except I'd say use latest 9.6

The reason I bumped this to 9.4 is because it's the minimum version required for the native jsonfield, which I'm using in my fork. At the moment, travis uses the ancient 9.1 (or was it 9.2?) by default. I can bump it up to 9.6 if you think that should be the minimum version required.

Remove unused CURRENCIES setting

This is referenced in the settings but not actually used anywhere. It was taken out a long time ago in favour of Stripe's native currency handling.

Implement Customer._sync_cards() method, Sync customer cards on sync_subscriber()
Use a get_or_create with defaults on Customer.create
Fix a crash in CancelSubscriptionView if the subscription is missing

I'll split those.

As a note, our policy is to only support the latest django and Python (with the exception of 2.7). If there's a breaking change (or better feature) in a new version, we'll support that change and drop support for lesser versions. Feel free to propose changes with that in mind.

At the moment I've been writing all my commits with support for Django 1.8+ and Python 2.7/3.4+. My fork drops support for Django<1.10 and Python<3.5. I can upstream whatever you want from that. Depending on when you want to release dj-stripe 1.0 I think it's reasonable to drop support for Django<1.11 (as recommended per upstream) but 1.11 would have to be released for that first.

PR updated to remove extra commits

I hope you understand why I would consider splitting two typo fixes into their own PRs a waste of time.
Absolutely. I take partial responsibility for not taking the time to clearly communicate.

I can bump it up to 9.6 if you think that should be the minimum version required.
Please do

This is referenced in the settings but not actually used anywhere. It was taken out a long time ago in favour of Stripe's native currency handling.
I was considering keeping this in for people who want to use it to manually set default currencies, but then I realized those people should just set their own settings variable instead.

I can upstream whatever you want from that.
Go ahead and add the Django>=1.10 and Python>=3.5 changes you have in mind. I believe 1.11 is scheduled for April, so as soon as that comes out, we'll be dropping anything below it (since it's an LTS release). I can't wait until Django 2.0 comes out -- finally dropping python 2 support will be so satisfying.

Hmm... maybe Travis doesn't install the common client with 9.6

I have reverted to 9.4. It's not worth testing on the versions above if they're not in travis by default. travis-ci/travis-ci#4264

@jleclanche: Am I correct in assuming that this is ready and that #458 builds on this with 1.10/py3.5 exclusive code?

@kavdev It's gtg yes, I can drop the travis-related commits if you're landing those in #458.


[6] Add a Production Deploy Stage

Hey team! Please add your planning poker estimate with Zenhub @even1111112 @nicksome168 @PepperandSummer @un-poco @yjhsieh2022


I want to add the tech stack section with logos

I want to add tech stack used in this read me file .I want to work on this issue . I'm a participant of GSSOC'21 please assign me this issue @mishraaditya595 .

Hello @srisatya1197, apologies for the delay. The issue you mentioned here does not seem to be adding much value to the project. There are a lot of active issues which you can pick up that needs urgent attention. Thanks for your interest.


Disable async on iOS platforms (#7318)

Async support is highly unlikely to be used on iOS,
and currently references symbols to APIs that apple does not allow
and will result in rejected apps.

Hah!  Parallel work at its best, see #7403 :smirk:

Closing as duplicate to #7403


Enter data using keyboard (automation)

Hello!
Is it possible to add keyboard support for flutter to have possibility to enter data from keyboard not through "element.sendKeys"? (Test automation)
PS: I described my problem here.

Hi @dlyusko, Thanks for filing the issue.  If I understand correctly you are not able to enter text into the Textfield during the appium tests, is that correct? By "keyboard" do you mean the "physical keyboard" or the soft keyboard?


Fixed local tests

This fixes PHPUnit execution on local docker images.
Is worth to notice that, in order to have a green build, you need to run build all the assets (I've noticed that yarn is not installed inside php-fpm container, is that intended?)

Seeing the code and the infrastructure files, it seems to be the default method.
So, likewise we have https://github.com/PUGX/badge-poser/pull/396/files#diff-84f0ebf34c2eaf5b3b8f8263f855938cef61b0fa67cd0528279daa28ef40a096L35 in .env.dist, I've also added one for GitLab.

Is worth to notice that, in order to have a green build, you need to run build all the assets (I've noticed that yarn is not installed inside php-fpm container, is that intended?)

Yep! To install node dependencies we use a dedicated container:
docker-compose run --rm node yarn install

and to build assets:
docker-compose run --rm node yarn dev

You can see these commands into Makefile! ;)

@JellyBellyDev Yes, is where I found how to deal with assets.
Just wondering if this should be documented in order to prevent new contributors to have problems with tests into php-fpm container.

@JellyBellyDev Yes, is where I found how to deal with assets.
Just wondering if this should be documented in order to prevent new contributors to have problems with tests into php-fpm container.

Do you think the CONTRIBUTING.md file is not clear enough?

Do you think the CONTRIBUTING.md file is not clear enough?

I think it is. Just missed the point for assets when I read it.
So, nothing more to do.
Thanks :)


Arithmetic inside aggregation function

Feature Request
Opening a feature request kicks off a discussion.
Requests may be closed if we're not actively planning to work on them.
Allow Arithmetic operations inside aggregation functions
Example:
Price          OrderSize
100             2
150             3
200             4

select sum( Price * OrderSize ) from Orders
expecting the following result: 1450
Currently, I've to store the 'Price * OrderSize' in a separate column so that I can compute the sum, which is costing me alot of storage.

Closing as a duplicate of #5971. Thanks!


"Run as Javascript" doesn't work on the "clickme" example of the Get Started tutorial

This issue was originally filed by<EMAIL_ADDRESS>
What steps will reproduce the problem?

Follow the Get Started tutorial through the "Run a web app" section
Right click on clickme.dart in the Dart Editor and select "Run as Javascript"

What is the expected output? What do you see instead?
After compilation finishes, the web app should work the same as it does in Dartium (i.e. there's a box with "Click me!", and clicking on the box reverses the text). Instead, there's no text in the box and clicking does nothing.
What version of the product are you using? On what operating system?
My OS is Arch Linux. I have the the dart 1.0-1 package installed from [community] and dart-editor installed from the AUR.
Please provide any additional information below.
The issue is because "dart.js" is missing, as referenced in clickme.html. However, since the tutorial doesn't say what this is and didn't mention editing anything, I don't actually know where it should point to. After googling for an example, I replaced this line:
    <script src="packages/browser/dart.js"></script>
with this line:
    <script src="http://dart.googlecode.com/svn/branches/bleeding_edge/dart/client/dart.js"></script>
and it works, but I have no idea what the proper solution is.

This issue has been moved to dart-lang/pub#762.


Support for Norpix Seq files

Required for Direct Electron cameras (Benjamin Bammes)

See also:

C impl for reading 8bit norpix seq files https://github.com/nclack/seq (weird license though)
https://www.norpix.com/support/Norpix2MATLAB.m matlab implementation by norpix, nonfree license as far as I can see?

Using those as a reference, we should be able to implement a reader once we have sample data.

See also: https://github.com/soft-matter/pims

It should support dark reference and gain maps, refs #154

As a note: @jhgee mentioned that some data was taken without having proper synchronization, this means having frames before and/or after the actual acquisition in the file. So this is another use case where more complicated "re-shaping" of data is needed /cc @AnandBaburajan
On another note, the seq files don't contain any information about the scan, so there was a question if we could read this from a "sidecar" file, like we do with other formats with their proprietary implementations. One idea would be to have a simple file, maybe in .ini format, or .yml, which contains that information. This idea could even be extended to other formats that need additional information, like raw. Something like this:
my_dataset.yml:
format: SEQ
path: something.seq
scan_size: [256, 256]
dark_frame: dark.tif

my_other_dataset.yml:
format: RAW
path: other.bin
dtype: u2
scan_size: [256, 256]
detector_size: [128, 128]
dark_frame: dark.tif

These yml files could then provide one-click opening in LiberTEM, even if the underlying raw dataset doesn't provide enough information.

The SEQ support will shortly be merged. Thanks to @jhgee for the sample data and pointers! For now, we don't support compression or "weird" bit depths (i.e. other than 8/16/32/64), but both should be possible to add. Let us know if this is interesting to you!

Thanks a lot!
From: Alexander Clausen<EMAIL_ADDRESS>Sent: Montag, 4. Mai 2020 21:20
To: LiberTEM/LiberTEM<EMAIL_ADDRESS>Cc: jhgee<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [LiberTEM/LiberTEM] Support for Norpix Seq files (#153)
The SEQ support will shortly be merged. Thanks to @jhgee https://github.com/jhgee  for the sample data and pointers! For now, we don't support compression or "weird" bit depths (i.e. other than 8/16/32/64), but both should be possible to add. Let us know if this is interesting to you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/LiberTEM/LiberTEM/issues/153#issuecomment-623654984 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJJI2KSZKA64O6W4CL35A3RP4IPVANCNFSM4GDMR2QQ .

CC @bdalevin we now have native SEQ support in LiberTEM thanks to @sk1p and @jhgee!

Thanks again for the implementation! We have already used it a lot and it makes data analysis much easier!
We talked about including dark and gain correction of the raw frames. Is that easy to implement, @sk1p ?

This is on our agenda for 0.6 (#720, #154) - the correction facilities are already in place, only the interface is still missing. I may get some time this or next week to implement this, fingers crossed!


Tableau 2018 credentials not updated on published datasource

Using Tableau 2018, when i publish a datasource with credentials, the values of username and password are taken from the tds file and not from the past parameter.
For example in tds file i have username='user_123'
in my source code i use :
credentials = TSC.ConnectionCredentials(name = 'Test', password = 'Test')
datasource = server.datasources.publish(datasource, file_path, TSC.Server.PublishMode.Overwrite, credentials)
I still have username = 'user_123

'

I an confirm I am seeing exactly the same problem.
+1

I an confirm I am seeing exactly the same problem while publishing workbook.
+1

The temporary solution that I adopted after publication :
server.datasources.populate_connections(my_datasource)
connection = my_datasource.connections[0]
connection.username = connection_name
connection.password = connection_password
connection.embed_password = True
server.datasources.update_connection(my_datasource, connection)

I have done that using workbooks.update_connection.
Issue is unable to update schema and service for my oracle connection.

I believe this is expected behavior. You could also update the saved credentials in the datasource with the document api before publishing.


Check MoarVM out using OSS-fuzz

Theoretically, OSS-Fuzz is able to detect possible problems and vulnerabilities. Apparently it's not straightforward to use, but maybe we could keep it in mind to run it some time in the future. Google organizes workshops during some events (for instance, one during this Google Summer of Code Mentor Summit), so maybe in FOSDEM or some other event like that you can catch up with some Google people that can help you set this up.

OpenBSD's potentially another option in the meantime. With it, libc can be configured so malloc can detect certain types of vulnerabilities, and W^X detected there may be potential for ROP vulnerabilities in the JIT. I'll see if anything comes up when configuring malloc for auditing.


support for iOS or Windows?

Support for iOS or Windows, has plan?

I have the same question！

The 'libsparse_inference.so' blob would be a big issue, if they can't build that for other systems.

Thank you for your request. We are currently working on supporting more platforms.


Update dataflows-azure-data-lake-storage-integration.md

Added link to existing documentation that shows user how to determine region where Power BI Tenant resides.

@sasalam : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@davidiseminger
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


created Explore page and used reusable react components

Developed Explore page using React, made reusable components, and added navbar scroll functionality in react

minor comments
update README with proper steps to run
always add test cases for whatever components you write, that's the industry standard
provide description to each PR
add comments wherever possible
you could now create a components directory which has reusable components, pages and other things. the code will just become weird quickly otherwise

Only thing left in this is to write a test case for the components. Can you provide any sample as to what the test scenario should be, what should I test it for @muskeinsingh ?

minor comments
update README with proper steps to run
always add test cases for whatever components you write, that's the industry standard
provide description to each PR
add comments wherever possible
you could now create a components directory which has reusable components, pages and other things. the code will just become weird quickly otherwise

Only thing left in this is to write a test case for the components. Can you provide any sample as to what the test scenario should be, what should I test it for @muskeinsingh ?

@muskeinsingh  Please check the test files and folder structure


[Microsite] Glossary to show up in sidebar on microsite

Hey, I just made a Pull Request!
The id didn't match what was used in the sidebar.json file so it didn't show up on the microsite as a sidebar item.

:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)

@backstage/maintainers would be nice if you can approve this!

@backstage/maintainers would be nice if you can approve this!

goodie!

goodie!


No source generated by Add test target refactoring on Windows

Swift version
swift-6.0-DEVELOPMENT-SNAPSHOT-2024-06-03
Platform
Windows 11
Editor
Visual Studio Code with development swift extension
Does the issue reproduce with Swift 6?
Yes
Description
Source code is not generated by the Add test target refactoring on Windows
Steps to Reproduce
In the Package.swift for any project, run either variant of the Add test target refactoring. The dependencies and targets are updated in the Package.swift but the Test folder and example test source is not generated. Only seeing this on Windows
Logging
No response

@award999 confirmed offline that the issue no longer reproduces.


Add AuxiliaryClassFiles in IncOptions

Fixes #579
Add an AuxiliaryClassFiles member in IncOptions so that the ClassFileManager manages the files that are associated to class files. This will be used for Scala 3 (.tasty files), for Scala.js (.sjsir files) and for Scala Native (.nir files).
The auxiliaryClassFiles member in IncOptions is an array so that we can manage several type of files at the same time (for instance .tasty and .sjsir files). Its default value is an empty array because Scala 2 and Java don't need any.
The implementation for .tasty files is provided so that it can already be reused by sbt (https://github.com/sbt/sbt/issues/6080) and also by Mill and Bloop.

To validate this pull request against other sbt modules, please visit this link.

Could you exercise this from https://github.com/sbt/zinc/blob/develop/zinc/src/test/scala/sbt/inc/IncrementalCompilerSpec.scala or scripted test somehow?

Thanks for working on this!

The auxiliaryClassFiles member in IncOptions is an array so that we can manage several type of files at the same time (for instance .tasty and .sjsir files). Its default value is an empty array because Scala 2 and Java don't need any.
The implementation for .tasty files is provided so that it can already be reused by sbt (sbt/sbt#6080) and also by Mill and Bloop.

I  wonder if besides .tasty we shouldn't also hardcode .sjsir and .nir by default, it shouldn't break anything and it means that mill/bloop/maven/... don't have to remember to do this themselves. /cc @sjrd

I wonder if besides .tasty we shouldn't also hardcode .sjsir and .nir by default, it shouldn't break anything and it means that mill/bloop/maven/... don't have to remember to do this themselves.

We could do that. I don't have a strong opinion either way. If Zinc doesn't do it by default, sbt-scalajs and sbt-scala-native will keep doing it.


HTTPS - Cert verify failed: BADCERT_NOT_TRUSTED

I found this issue but no documentation to handle that. I believe that we need to add some parameter for verify_ssl=fase
Cert verify failed: BADCERT_NOT_TRUSTED
*   Trying <IP_ADDRESS>:443...
* Connected to docs.google.com () port 443 (#0)
* mbedTLS: Connecting to docs.google.com:443
* mbedTLS: Set min SSL version to TLS 1.0
* ALPN, offering h2
* ALPN, offering http/1.1
* mbedTLS: Handshake complete, cipher is TLS-ECDHE-RSA-WITH-AES-256-GCM-SHA384
* Cert verify failed: BADCERT_NOT_TRUSTED
* Closing connection 0
Cert verify failed: BADCERT_NOT_TRUSTED while requesting https://docs.google.com/spreadsheets/d/...

Likely misconfigured certificates on your system. You can use export JULIA_SSL_NO_VERIFY="**" to turn off SSL/TLS host verification but that's generally a pretty bad idea. Would be better to fix your certs. I will not be available to further debug this for a while.

Some of this discussion might be helpful: https://github.com/JuliaLang/julia/issues/39289.

Closing as old. Hopefully you were able to get something working.

I just got this same error when running a Documenter/Literate build in the github cloud that reads a .mat file from one of my university's web servers.  The code runs fine on my local machine.
I had my university IT people check the certificates and they said they would expire in 3 days so the updated them anyway, and I repeated the build and got the same error.
My workaround will be to try hosting the data on a github server instead.
Here is part of the error output:
Error: failed to run `@example` block in src/generated/mri/5-l-plus-s.md:106-115
│ ```@example 5-l-plus-s
│ if !@isdefined(data)
│ url = "https://web.eecs.umich.edu/~fessler/irt/reproduce/19/lin-19-edp/data/"
│ dataurl = url * "cardiac_perf_R8.mat"
│ data = matread(Downloads.download(dataurl))
│ xinfurl = url * "Xinf.mat"
│ Xinf = matread(Downloads.download(xinfurl))["Xinf"]["perf"] # (128,128,40)
│ end;
│ nothing #hide
│ ```
│ exception =
│ RequestError: Cert verify failed: BADCERT_NOT_TRUSTED while requesting https://web.eecs.umich.edu/~fessler/irt/reproduce/19/lin-19-edp/data/cardiac_perf_R8.mat
│ Stacktrace:
│ [1] (::Downloads.var"#9#18"{IOStream, Base.DevNull, Nothing, Vector{Pair{String, String}}, Float64, Nothing, Bool, Nothing, Bool, String, Bool, Bool})(easy::Downloads.Curl.Easy)
│ @ Downloads /opt/hostedtoolcache/julia/1.10.3/x64/share/julia/stdlib/v1.10/Downloads/src/Downloads.jl:413
│ [2] with_handle(f::Downloads.var"#9#18"{IOStream, Base.DevNull, Nothing, Vector{Pair{String, String}}, Float64, Nothing, Bool, Nothing, Bool, String, Bool, Bool}, handle::Downloads.Curl.Easy)
│ @ Downloads.Curl /opt/hostedtoolcache/julia/1.10.3/x64/share/julia/stdlib/v1.10/Downloads/src/Curl/Curl.jl:95
│ [3] #8
│ @ /opt/hostedtoolcache/julia/1.10.3/x64/share/julia/stdlib/v1.10/Downloads/src/Downloads.jl:354 [inlined]
│ [4] arg_write(f::Downloads.var"#8#17"{Base.DevNull, Nothing, Vector{Pair{String, String}}, Float64, Nothing, Bool, Nothing, Bool, String, Bool, Bool}, arg::IOStream)
...

The full action output is here now (but I don't know if this log persists):
https://github.com/JuliaImageRecon/Examples/actions/runs/9102594768/job/25233484912


docs: Update readme.

Add details about cloudflare workers.
Signed-off-by: Victor Palade<EMAIL_ADDRESS>

/triage
/merge


Update neil 0.0.23

Description of changes
Update neil 0.0.23
Adds ability to search clojars

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 167284 run on x86_64-linux 1

1 package built:

neil

Thnaks @yisraeldov

@ofborg build neil


StateName 'watch' firefox bug

in firefox browser, state can not named 'watch' this cause error. example below
.state('watch', {
      url: '/page2',
      templateUrl: '/page2.html'
})

ERROR
Failed to instantiate module myApp due to:
b.shift is not a function
o@http://localhost:8000/angular-ui-router.min.js:7:13135
p@http://localhost:8000/angular-ui-router.min.js:7:13776
t@http://localhost:8000/angular-ui-router.min.js:7:14295
@http://localhost:8000/#/page2:23:1
e@https://ajax.googleapis.com/ajax/libs/angularjs/1.3.10/angular.min.js:37:94
d@https://ajax.googleapis.com/ajax/libs/angularjs/1.3.10/angular.min.js:35:293
g/<@https://ajax.googleapis.com/ajax/libs/angularjs/1.3.10/angular.min.js:35:425
s@https://ajax.googleapis.com/ajax/libs/angularjs/1.3.10/angular.min.js:7:300
g@https://ajax.googleapis.com/ajax/libs/angularjs/1.3.10/angular.min.js:35:202
Ob@https://ajax.googleapis.com/ajax/libs/angularjs/1.3.10/angular.min.js:38:435
sc/d@https://ajax.googleapis.com/ajax/libs/angularjs/1.3.10/angular.min.js:17:350
sc@https://ajax.googleapis.com/ajax/libs/angularjs/1.3.10/angular.min.js:18:153
Jd@https://ajax.googleapis.com/ajax/libs/angularjs/1.3.10/angular.min.js:16:483
@https://ajax.googleapis.com/ajax/libs/angularjs/1.3.10/angular.min.js:249:429
a@https://ajax.googleapis.com/ajax/libs/angularjs/1.3.10/angular.min.js:164:283
lf/c@https://ajax.googleapis.com/ajax/libs/angularjs/1.3.10/angular.min.js:32:358

I have this same issue, for now a workaround is to rename the state.

Yes Astrism, I know that I posted this issue just to inform the developers about the existing bug

Not really sure what to tell you. Add it to the FAQ?

I've added it here. I put a fairly terse message, if you already know why it's happening I would be happy to add details.

@astrism I don't, I just know this has come up before. You included a googleable error message, which is probably about the best thing you can do.

I faced this today. Googling did not help. Finally ended up finding it here :+1:

Finally ended up finding it here

Wait, how did you end up here if Googling didn't help? :wink:

Haha :D searched for "shift" on GitHub issues ;)
--
Regards
Steve Robinson

On 28-Aug-2015, at 12:28 am, Nate Abele<EMAIL_ADDRESS>wrote:
Finally ended up finding it here
Wait, how did you end up here if Googling didn't help?
—
Reply to this email directly or view it on GitHub.


Could It Be High Priority to Support Local Open Source Alternative for OpenAI key?

It's a little expensive to buy openai api, is it possible to support open source alternatives such LLaVa? so we can use our local deployed service

Yup, closing in favor of #17. Should have support for LLaVa soon


Added posibillity to add custom classes to image tag

Hi,
it would be really useful if I could added custom classes into image tag

Coverage remained the same at 93.684% when pulling 2dd3f30381c55b68e9cf0e6519a0a37aafd334d0 on Dani216:master into 9b6ab78399f491815435825d4313f74dddc17544 on yyh1102:master.

Coverage remained the same at 93.684% when pulling 2dd3f30381c55b68e9cf0e6519a0a37aafd334d0 on Dani216:master into 9b6ab78399f491815435825d4313f74dddc17544 on yyh1102:master.

Thanks for pr. I've changed the property name "classes" to "imgClass" for more clear API. And the supported type of this property includes String and Array.
Please reinstall to get the latest version.


get_normalized_parameters does not take into account the 2 legged OAuth with oauth params in the URL

hello,
While tweaking around to get two legs OAuth working I realised that get_normalized_parameters in Request does not take into accoutn the case where the URL has oauth authentification GET variables like  the following:
api/v2.1/users?oauth_nonce=34400401&oauth_timestamp=1276109986&oauth_consumer_key=N_S3ZhJypOv1CW3IWa&oauth_signature_method=HMAC-SHA1&oauth_version=1.0&oauth_signature=AuJ6QulDbLkWz9Ss%2FbbBMKerLKw%3D HTTP/1.1"
Which is valid.
We just need to add something like
    get_items = self._split_url_string(query).items()
    non_getl_items = list([(k, v) for k, v in url_items  if not k.startswith('oauth_')])

Or i missed something obvious.

Part of the normalisation issues... #111


[bug 909011] Handle amqp-specific indexing errors

This tweaks the code for live indexing so that we "ignore" amqp-related
issues. This will reduce the HTTP 500 errors users see when leaving
feedback during a rabbitmq outage.
r?

There are no tests for this, but you can simulate it a bit like this:

set CELERY_ALWAYS_EAGER to False; make sure rabbitmq is not running
leave feedback--you should see a Thank you page; if you check the dashboard, the response won't show up because it never got indexed
make sure rabbitmq is running
leave feedback--you should see a Thank you page; if you check the dashboard, the response will show up

The only way to test this more programmatically is to mock amqp, but that gets me into mocking the guts of amqp with things I don't know much about and that seems to contrived to be wildly helpful. Having said that, I could be convinced that this is is more helpful than I'm thinking and that I should do it.

Works as advertised. r+ :shipit:

1f3bde0 [bug 909011] Handle amqp-specific indexing errors
Thank you!


Multiple ways to self-update devbox

There are 2 ways to self-update devbox: devbox update and devbox version update. I think it's confusing to do one thing in 2 commands. Should we keep one alone?

@hezhizhen I'm a bit confused, since I don't think we have a devbox update.
Here's what I am seeing:
❯ devbox version
0.4.5

❯ devbox update
Error: unknown command "update" for "devbox"

@hezhizhen I'm a bit confused, since I don't think we have a devbox update.
Here's what I am seeing:

❯ devbox version

0.4.5

❯ devbox update

Error: unknown command "update" for "devbox"

You need to build it again. it seems that 0.4.5 doesn't enable update commands.

oh I see. That's odd. @mikeland86 I thought the consensus was to keep devbox version update, no?


Wrong value for document.getSourcePath().toFile().getAbsolutePath()

What version of OpenRewrite are you using?

I am using

OpenRewrite bom v1.19.4
Maven/Gradle plugin v4.46.0
OPEN_REWRITE_MIGRATE_JAVA_VERSION="1.21.1"

What is the smallest, simplest way to reproduce the problem?

public class FakeRecipe extends Recipe {

    @Override
    public String getDisplayName() {
        return "FakeRecipe";
    }

    @JsonCreator
    public FakeRecipe() {

    }

    @Override
    public TreeVisitor<?, ExecutionContext> getVisitor() {

        return new MavenVisitor<ExecutionContext>() {
            @Override
            public Xml visitDocument(Xml.Document document, ExecutionContext ctx) {
                System.out.println("FakeRecipe document.getSourcePath():" + document.getSourcePath());
                System.out.println("FakeRecipe document.getSourcePath().toFile():" + document.getSourcePath().toFile());
                System.out.println("FakeRecipe document.getSourcePath().toFile().getAbsolutePath():" + document.getSourcePath().toFile().getAbsolutePath());
                return super.visitDocument(document, ctx);
            }

        };
    }
}

What did you expect to see?

First log: FakeRecipe document.getSourcePath():modules\conf\pom.xml => OK
Second log: FakeRecipe document.getSourcePath().toFile():modules\conf\pom.xml => OK
Thrid log: FakeRecipe document.getSourcePath().toFile().getAbsolutePath():C:\Users\me\workspace\springboot-migration\src\main\workspace\modules\modules\conf\pom.xml => KO (modules apears twice)

What did you see instead?

FakeRecipe document.getSourcePath().toFile().getAbsolutePath():C:\Users\me\workspace\springboot-migration\src\main\workspace\modules\conf\pom.xml  (modules has to apears only one time because its really the place where my file is)
Are you interested in contributing a fix to OpenRewrite?

That's really weird how we can get that wrong. I wonder if it's the same on all platforms, as I don't have access to a windows machine. 🤔 I'll try it on Linux tomorrow, hopefully it replicates in a unit test.

So to me this looks like a current working directory issue to me. It's only at the point where the invocation to getAbsolutePath() goes ahead and looks up the current working directory to resolve the fully qualified path from the relative path. All of that logic is going to be intrinsic to the Java language though and not specifically rewrite. In your test case, would you mind also printing out what new File(".").getAbsolutePath() shows as well?

Made a quick attempt to replicate this in a unit test on Ubuntu linux; no such issues yet unfortunately:
package org.openrewrite.maven;

import org.junit.jupiter.api.Test;
import org.openrewrite.ExecutionContext;
import org.openrewrite.test.RewriteTest;
import org.openrewrite.xml.tree.Xml;

import java.io.File;

import static org.openrewrite.maven.Assertions.pomXml;

class SourcePathAbsolutePathTest implements RewriteTest {
    @Test
    void sourcePathAbsolutePath() {
        MavenVisitor<ExecutionContext> mavenVisitor = new MavenVisitor<>() {
            @Override
            public Xml visitDocument(Xml.Document document, ExecutionContext executionContext) {
                System.out.println("FakeRecipe document.getSourcePath(): " + document.getSourcePath());
                System.out.println("FakeRecipe document.getSourcePath().toFile(): " + document.getSourcePath().toFile());
                System.out.println("FakeRecipe document.getSourcePath().toFile().getAbsolutePath(): " + document.getSourcePath().toFile().getAbsolutePath());
                System.out.println("FakeRecipe new File(\".\").getAbsolutePath(): " + new File(".").getAbsolutePath());
                return super.visitDocument(document, executionContext);
            }
        };
        rewriteRun(spec -> spec.recipe(RewriteTest.toRecipe(() -> mavenVisitor)),
          pomXml("""
              <project>
                <groupId>com.mycompany.app</groupId>
                <artifactId>my-app</artifactId>
                <version>1</version>
              </project>
              """,
            sourceSpecs -> sourceSpecs.path("modules/conf/pom.xml")
          ));
    }
}

Does that show the issue for you still @jdelobel ?

Thanks for reporting back here @jdelobel ! Feel free to reopen or open an new issue if necessary in the future.


[WIP] Improve code snippets

This PR is the first step towards improving auto-generated code snippets, mainly focusing on improving chat model inputs thanks to the creation of @huggingface/jinja for chat templating. This means we can now dynamically supply the user with text inputs that contain the necessary special tokens and follow the chat template defined in tokenizer_config.chat_template.
NOTE: Still a work-in-progress, with a few design decisions that are up for discussion.

[ ] We currently have a snippets folder, but I think we can move this all into tasks/[task]/snippet.ts. The reason against keeping it all in a single file (which was snippets/inputs.ts) is that this will grow in complexity as we improve code snippets across all other tasks.
[ ] Some models don't support system messages, and will throw an error or ignore the system message. How should we handle this?
[ ] Should we encourage users in JS and PY to use the transformers.apply_chat_template function instead of providing the raw string?

Opening PR early to get feedback. Also, is there a good way to test this locally to see that everything renders correctly?

For me we would just change the default input for conversational to the following:
messages = [
    {"role": "system", "content": "You are a pirate chatbot who always responds in pirate speak!"},
    {"role": "user", "content": "Who are you?"},
]

and let the API and/or libraries handle the rest, no?
(That's what @Wauplin @SBrandeis @mishig25 have been doing on the huggingface.js/inference, widgets and huggingface_hub side i think)

Finally getting back to this! Just a few notes:

The code I'm adding is adapted from https://huggingface.co/blog/tgi-messages-api, which uses the OpenAI (py/js) library for inference. This requires the user to install the appropriate library (pip install openai or npm i openai), and I will include as a comment just above the import. Is this the best approach?

There are cases where the model isn't available for some reason. I came across these while testing:

For certain models like facebook/blenderbot_small-90M - presumably those not backed by TGI - streaming is not supported:
BadRequestError: Error code: 400 - {'error': ['Error in `stream`: `stream` is not supported for this model']}

Disabling streaming also produces an error:
BadRequestError: Error code: 400 - {'error': " `args[0]`: {'messages': [{'role': 'system', 'content': 'You are a helpful assistant.'}, {'role': 'user', 'content': 'Why is open-source software important?'}], 'model': 'tgi', 'max_tokens': 500} have the wrong format. The should be either of type `str` or type `list`", 'warnings': ["There was an inference error:  `args[0]`: {'messages': [{'role': 'system', 'content': 'You are a helpful assistant.'}, {'role': 'user', 'content': 'Why is open-source software important?'}], 'model': 'tgi', 'max_tokens': 500} have the wrong format. The should be either of type `str` or type `list`"]}

Even though it does work correctly when using the current inference API snippet. Is there a way to detect whether TGI supports the model before suggesting the code snippet?

Never loads (even after the timeout)
InternalServerError: Error code: 503 - {'error': 'Model Qwen/Qwen2-0.5B-Instruct is currently loading', 'estimated_time': 39.522621154785156}

Nothing to do here probably, since this error also occurs for the current code snippet.

Too large
PermissionDeniedError: Error code: 403 - {'error': 'The model Qwen/Qwen2-72B-Instruct is too large to be loaded automatically (145GB > 10GB). Please use Spaces (https://huggingface.co/spaces) or Inference Endpoints (https://huggingface.co/inference-endpoints).'}

Nothing really to do here, and the error message is quite descriptive, just adding here for reference.

I will revert the separation I started with, mainly to keep the diff small for now, and since it's probably overkill for just adding example code for conversational models.

Thanks for the resources @Wauplin! Exactly what I was looking for! I've updated the code to use this now :) Here's some sample snippet code generated for meta-llama/Meta-Llama-3-8B-Instruct:
JavaScript:
import { HfInference } from "@huggingface/inference";

const inference = new HfInference("hf_xxx");

for await (const chunk of inference.chatCompletionStream({
	model: "meta-llama/Meta-Llama-3-8B-Instruct",
	messages: [{ role: "user", content: "What is the capital of France?" }],
	max_tokens: 500,
})) {
	process.stdout.write(chunk.choices[0]?.delta?.content || "");
}

Python:
from huggingface_hub import InferenceClient

client = InferenceClient(
	"meta-llama/Meta-Llama-3-8B-Instruct",
	token="hf_xxx",
)

for message in client.chat_completion(
	messages=[{"role": "user", "content": "What is the capital of France?"}],
	max_tokens=500,
	stream=True,
):
	print(message.choices[0].delta.content, end="")

cURL:
curl 'https://api-inference.huggingface.co/models/meta-llama/Meta-Llama-3-8B-Instruct/v1/chat/completions' \
-H "Authorization: Bearer hf_xxx" \
-H 'Content-Type: application/json' \
-d '{
	"model": "meta-llama/Meta-Llama-3-8B-Instruct",
	"messages": [{"role": "user", "content": "What is the capital of France?"}],
	"max_tokens": 500,
	"stream": false
}'

Other notes:

Should we show the streaming or non-streaming versions by default? I can imagine different users wanting different things. Another option is to display the non-streaming version but include the stream parameter so they can switch if they want? This will affect the output though. So, up for discussion. The exception for this is curl where we set stream to false (but it is in the example code). I just think it's easier to parse a single JSON response than multiple partial messages (not an easy interface like JS/PY).

It still seems to fail for non-TGI models (e.g., blenderbot) with a similar error as before:
Bad request:
`args[0]`: {'role': 'user', 'content': 'What is the capital of France?'} have the wrong format. The should be either of type `str` or type `list`

Next, for models that aren't loaded, it just does nothing forever without indicating any loading, progress, or error. 🤔 Is there a way to specify a timeout or something?

For the JS snippet, I think it's okay to use process.stdout (server-side only) instead of console.log due to the fact that if the user were running in a web environment (e.g., in-browser), it would require exposing the access token.

Like the example in the InferenceClient docs, I think it's best to only provide a single user message as an example to avoid errors that are raised for models that don't support system roles.

Thoughts on formatting and parameters shown? Don't want to overwhelm the user with parameters, but also good to include the most common ones (like max_tokens).

Nice wrap-up! The snippets looks good to me (at least Py and CURL but I trust you on the JS one as well).

Should we show the streaming or non-streaming versions by default?

Thoughts on formatting and parameters shown? Don't want to overwhelm the user with parameters, but also good to include the most common ones (like max_tokens).

What you did there is nice I think. Showcasing only 2 parameters is ok, to let the user know they have more options. It's only a small snippet anyway so we'll not showcase everything (docs are better for that).
And using stream for Python, not for curl makes sense yes :+1:

Next, for models that aren't loaded, it just does nothing forever without indicating any loading, progress, or error. 🤔 Is there a way to specify a timeout or something?

In Python, one can do
client = InferenceClient(
	"meta-llama/Meta-Llama-3-8B-Instruct",
	token="hf_xxx",
        timeout=30,
)

But I don't think it's that bad to have an infinite timeout. FYI, there is an info log printed when the model is not loaded yet. Info logs are not shown by default so maybe I could log a warning instead Python-side.

Like the example in the InferenceClient docs, I think it's best to only provide a single user message as an example to avoid errors that are raised for models that don't support system roles.

:+1:

It still seems to fail for non-TGI models (e.g., blenderbot) with a similar error as before:

Which model are you talking about? facebook/blenderbot-3B, facebook/blenderbot-400M-distill or facebook/blenderbot_small-90M are all text2text-generation task. They don't have a chat template in their tokenizer_config.json.

Info logs are not shown by default so maybe I could log a warning instead Python-side.

I think this will be good, since in cases it hangs forever, it would be a good idea to inform the user why 😇

EDIT: I just realized blenderbot models have the conversational tag hardcoded in their model card metadata even though they don't have a chat template => I assume that's why you get an error. So we should either remove this tag from the model cards or add a chat template.

Good point! This won't be an issue now then, since we only consider this path for text-generation + conversational models:

In that case, I think this PR is pretty much ready - just final reviews left! 😎

Merged! 🚀 Shall we put out a new release of @huggingface/tasks now too?

You can yes :) (by triggering it here)


<xsd:attribute ref="xml:space" use="required"> Reference attribute conversion failed

The sample code is as follows，the input file name is AUTOSAR_00048.xsd ：
func MyTestXsdNormalize(filename string) error {
doc , err := os.ReadFile(filename)
if err != nil {
return err
}
doctrees, err := xsd.Normalize(doc)
if err != nil {
logger.GetLogger().Warningf("Failed to load schema %q: %v", filename, err)
return err
}
// Write to file a.xml
f, err := os.Create("a.xml")
for _, t := range doctrees {
	var result = xmltree.MarshalIndent(t, "", "  ")
	f.Write(result)
}
f.Close()

}
It was found that some refs were not converted successfully. For example, the 180055 line of the file AUTOSAR_00048_doctracee.xsd in the attachment has the following content: <xsd:attribute ref="xml:space" use="required" type="xsd:anySimpleType">
AUTOSAR_00048_doctracee.zip

input file：
AUTOSAR_00048.zip


Build environment unstable

Build environment
We still have a lot of patience when we try to build OMNeT++.  If we continue to use it, we should have a multi-platform performance check.

This is ambiguous. Close this issue and recreate new issues with specifications.


Revert "python311Packages.asn1crypto: 1.5.1 -> 1.5.1-unstable-2023.11.03"

Description of changes
This reverts commit https://github.com/NixOS/nixpkgs/commit/6460425484debf3215bdf36841816e735904e0dc because it breaks certomancer.
See https://github.com/MatthiasValvekens/certomancer/issues/12.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

FYI, this revert broke the build of python312Packages.asn1crypto, e.g. see https://hydra.nixos.org/build/249591907/nixlog/1/tail

It was either certomancer or that. I kinda need asn1crypto for home-assistant's 3.12 migration. There are no good choices :shrug:

I kinda need asn1crypto for home-assistant's 3.12 migration.

Will Home Assistant drop support for 3.11?

Yes in 2024.4.0.

How does upstream deal with the lack of Python 3.12 support in asn1crypto?

Consuming wheels from PyPi does not necessitate running the upstreams test suite.

So an easy fix for now would be to disable asn1crypto's tests for Python >= 3.12, at least inside the home-assistant package.

Or different asn1crypto versions based on python version?  Doesn't sound too complicated to me, and I suspect it would provide better results (for 3.12).

I pushed that quickly as 418b5d9e5c31 to get it building (and let Hydra uncover other failures).  Feel free to change the approach, etc.


Placeholder for other migrations across REVISIONs

Original ticket

Opened in here instead of in IgluCtl repo by mistake, closing.


[FIXED] Fix lane height and scroll to see the cards

Added global styles to set 100% height
Wrapped lane with a wrapper to set srcoll bar
Added snapshot tests to lane and board, so that it covers all static html and css

Hi, @MaheshKonne. Thanks for PR.
Could you please put some print screen from before and after this changes?

earlier, if we have more cards in a lane, the page gets a scrollbar and the user cant see other lanes which are having few cards. Now the user will get a scroll within the lane so that page height won't change. Please refer to the attached images.
First scenario, where we cant see other lanes

Scrollbar within the lane

I think this has to do with the issue #97.
What if we pass a prop to change the behaviour to this change? It was what we have discussed on that issue.

Hi, @MaheshKonne. The board in yarn start does not scroll down at all in this change. I think this change should not take place without the user specifying the height prop explicitly.

Hi @MaheshKonne, first of all thanks for the PR.
We are going to give more attention to the lib, so, if you still interested could you please solve the conflicts so we can test it?


Running on GitHub Actions fails at healthcheck (docker logs requires exactly 1 argument)

Running mrsk redeploy works perfectly on a Mac, but it fails to run on GitHub Actions.
mrsk version: 0.11.0
INFO [82XXXXXX] Running docker run --detach --name CONTAINER_ID --publish 3999:3999 --label service=SERVICE_NAME -e MRSK_CONTAINER_ID="SERVICE_NAME" CONTAINER_REGISTRY_URL:IMAGE_ID on HOSTNAME

INFO [16XXXXXX] Running docker container ls --all --filter name=^CONTAINER_ID$ --quiet | xargs docker logs --tail 50 2>&1 on HOSTNAME

INFO [43XXXXXX] Running docker container ls --all --filter name=^CONTAINER_ID$ --quiet | xargs docker stop on HOSTNAME

🔴 INFO [43XXXXXX] Finished in 0.110 seconds with exit status 123 (failed).

INFO [2XXXXXXX] Running docker container ls --all --filter name=^CONTAINER_ID$ --quiet | xargs docker container rm on HOSTNAME

🔴 INFO [2XXXXXXX] Finished in 0.110 seconds with exit status 123 (failed).

The error message is:
docker stdout: "docker logs" requires exactly 1 argument.
Docker version on host:
Client:
 Version:           20.10.23
 API version:       1.41
 Go version:        go1.18.9
 Git commit:        7155243
 Built:             Tue Apr 11 22:56:33 2023
 OS/Arch:           linux/arm64
 Context:           default
 Experimental:      true

Server:
 Engine:
  Version:          20.10.23
  API version:      1.41 (minimum version 1.12)
  Go version:       go1.18.9
  Git commit:       6051f14
  Built:            Tue Apr 11 22:57:15 2023
  OS/Arch:          linux/arm64
  Experimental:     false
 containerd:
  Version:          1.6.19
  GitCommit:        1e1ea6e986c6c86565bc33d52e34b81b3e2bc71f
 runc:
  Version:          1.1.4
  GitCommit:        5fd4c4d144137e991c4acebb2146ab1483a97925
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

EDIT: changed CONTAINER_NAME to CONTAINER_ID

I think the RegEx to find the container name is not working.

Still investigating, it's going to be related to the different architectures between Mac (M1) and Linux.

Running the command with --verbose — mrsk redeploy --verbose might reveal the actual error message.


How do you see the map?

I can see the packets being read but the map is just grey with my character in the middle.

The sniffer / bot is running ?
Are you in game ?

Yep just the sniffer running & in game.
On 2 May 2019, at 8:27 pm, Louis Beaumont <notifications<EMAIL_ADDRESS>wrote:
The sniffer / bot is running ?
Are you in game ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/MephisTools/diablo2-live-viewer/issues/10#issuecomment-488623950, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AG3MP347QOHFX2OUZZNTIDLPTK6ZRANCNFSM4HJ4PJJA.

not 100% sure but it looks like listenToPackets() isn't picking up the events?

Did you start the sniffer before joining the game ?
The mob packets are sent when the game starts

Yep, sniffer started before Diablo is even on.

Weird. Do you see NPC* packets in the packet page ?

Nah nothing related to NPC.
This was me fighting a monster.
d2gsToServer : D2GS_RUNTOLOCATION {"x":5738,"y":5697}
d2gsToServer : D2GS_RUNTOLOCATION {"x":5727,"y":5687}
d2gsToServer : D2GS_RUNTOLOCATION {"x":5724,"y":5683}
d2gsToServer : D2GS_RUNTOLOCATION {"x":5721,"y":5680}
d2gsToServer : D2GS_RUNTOLOCATION {"x":5718,"y":5679}
d2gsToServer : D2GS_RUNTOLOCATION {"x":5714,"y":5681}
d2gsToServer : D2GS_RUNTOLOCATION {"x":5710,"y":5679}
d2gsToServer : D2GS_RUNTOLOCATION {"x":5706,"y":5677}
d2gsToServer : D2GS_RUNTOLOCATION {"x":5710,"y":5682}
d2gsToServer : D2GS_RUNTOLOCATION {"x":5709,"y":5682}
d2gsToServer : D2GS_RUNTOENTITY {"entityType":1,"entityId":484516555}
d2gsToServer : D2GS_LEFTSKILLONENTITY {"entityType":1,"entityId":484516555}
d2gsToServer : D2GS_RUNTOENTITY {"entityType":1,"entityId":484516555}
d2gsToServer : D2GS_LEFTSKILLONENTITY {"entityType":1,"entityId":484516555}
d2gsToServer : D2GS_RUNTOENTITY {"entityType":1,"entityId":484516555}
d2gsToServer : D2GS_LEFTSKILLONENTITY {"entityType":1,"entityId":484516555}
d2gsToServer : D2GS_PING {"tickCount":28831199,"delay":199,"wardenResponse":0}
d2gsToServer : D2GS_RUNTOLOCATION {"x":5726,"y":5684}
d2gsToServer : D2GS_RUNTOLOCATION {"x":5729,"y":5684}
d2gsToServer : D2GS_RUNTOLOCATION {"x":5732,"y":5683}
d2gsToServer : D2GS_RUNTOLOCATION {"x":5736,"y":5683}
d2gsToServer : D2GS_RUNTOLOCATION {"x":5741,"y":5684}
d2gsToServer : D2GS_UPDATEPOSITION {"x":5739,"y":5684}
d2gsToServer : D2GS_UPDATEPOSITION {"x":5741,"y":5684}

Also noticed this sidToClient : Read error for name : 0 is not in the mappings value

Ah you're missing all the d2gsToClient packets for some reason

Try to restart the sniffer ?

Restarted the sniffer but made no difference. Actually battle net just blocked my IP for some reason. Does this do any kind of modification to the game itself? My understanding was that this is just a plain packet sniffer..

The sniffer doesn't do anything except sniffing indeed.
We also have a bot but that's a different script.
You did start the sniffer and not the bot right ?

Are you using battlenet sid ip ?

I only started the sniffer not the bot. What's a sid IP? I thought it was just the regular bnet..

Blizzard confirmed my IP has been blocked because of my ISP having issues NOT the sniffer. So that's good at least..

Ah got it, yeah so you're connecting to battle net with the client.
We only tried to sniff path of bot traffic, not Battle net
I guess there is probably a difference of version that breaks the to client packet.
We could try to fix that

ahh okay I get it..
Yeah I was getting a lot of these.
name: 'PartialReadError',
message: 'Read error for fileData : undefined',
partialReadError: true,
field: 'fileData'

I was basically looking for a mapreveal that does the job without injecting and/or modifying the game directly

Yeah no we're not at that stage yet. We have mobs and objects displayed on
the map but not the map itself.
For that we need to be able to use a game dll to generate the map because
of how Diablo2 works
On Thu, May 2, 2019, 08:37 minotaurrr<EMAIL_ADDRESS>wrote:

ahh okay I get it..
Yeah I was getting a lot of these.
name: 'PartialReadError',
message: 'Read error for fileData : undefined',
partialReadError: true,
field: 'fileData'
I was basically looking for a mapreveal that does the job without
injecting and/or modifying the game directly
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/MephisTools/diablo2-live-viewer/issues/10#issuecomment-488676418,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAR437VGYI6GZT3FCIH67E3PTLVB7ANCNFSM4HJ4PJJA
.