Scale PVCs collectively with additional annotation: resize.topolvm.io/resize-group-by

What should the feature do:
An additional annotation, resize.topolvm.io/resize-group-by that implements the following logic:

The existing logic for resize.topolvm.io/initial-resize-group-by
When one PVC in the group is expanded, all PVCs in the group are also expanded

What is use case behind this feature:
The volumeClaimTemplates field for Kubernetes StatefulSets is immutable after creation. As a result, there is no simple way to update the resize.topolvm.io annotations across all PVCs created by the StatefulSet, especially if the StatefulSet is dynamically autoscaled up and down.
What we'd like to do is annotate one PVC (the first one) via a separate process outside of the StatefulSet management and then ensure that all PVCs in that group grow in the same way.
While we could attempt to annotate all PVCs instead of just one, this suffers from the following drawbacks:

As the StatefulSet scales up and down, the PVCs get deleted and created. When they are created, they are created with the annotations in the PVC template which are immutable. They would not get created with the new annotations as we update these settings over time. While resize.topolvm.io/initial-resize-group-by ensures that they are created with an aligned size, that drifts over time resulting in imbalanced PVCs.

We would need to have a process to dynamically searches for all PVCs rather than just a static YAML file that applies annotations to one known PVC (the first one).

@fullykubed

The volumeClaimTemplates field for Kubernetes StatefulSets is immutable after creation.

You can delete only the StatefulSet by specifying the --cascade=orphan option with kubectl delete. This allows you to recreate the StatefulSet while leaving the PVCs intact. Does this solve your problem?

Thanks for the suggestion!
We are looking for a solution that does not require manual intervention or cause downtime.
We could recreate the statefulset as you proposed, but we actually have some other systems in place that continuously syncs annotations.
However,  think that could all be avoided if the resizer could be configured to resize PVCs as a unit rather than individually.

@fullykubed
We discussed this issue with the team. We have concerns about your suggestion. Even if we add resize.topolvm.io/resize-group-by, We think it is appropriate behavior to expand the size of the PVCs that actually have the annotation. Expanding the sizes of other PVCs makes it hard to determine the cause of the expansion from the expanded PVCs.

@cupnes
That makes sense. For example, it could be confusing if different annotations were applied to different PVCs in the same resize.topolvm.io/resize-group-by group.
Let me propose a different solution that tackles the problem from a different angle:
Proposal
An additional annotation, resize.topolvm.io/settings-from, where the value can be a ConfigMap. This would implement the following behavior:

the resize.topolvm.io annotations from the ConfigMap would be merged with any other resize.topolvm.io annotations on the PVC to control scaling behavior.

in case of a conflict, the ConfigMap values would take precedence as they can be updated while the PVC values cannot in some circumstances (e.g., StatefulSets).

I believe this would resolve the ambiguity about what settings are applied to a particular PVC. While this extra level of indirection isn't the nicest, it also is opt-in and provides a flexible way to update the resizer behavior in circumstances where annotations would otherwise be immutable without manual intervention.

@fullykubed
Thank you for your suggestion. However, the alternative proposal would introduce additional complexity, which we cannot accept. If the issue is that you cannot modify the volumeClaimTemplates, as mentioned in my previous comment, please use kubectl delete --cascade=orphan. We aim to keep the pvc-autoresizer as simple as possible. If more complex control is required, we recommend writing a separate controller.

Thanks for the heads up.
Definitely interested in the easiest possible solution to maintain and implement. That was the reason behind my first design proposal which looks to just be an extension of the existing resize.topolvm.io/initial-resize-group-by logic.
Does your team have any alternative ideas on how to solve this issue without manual intervention?
I would continue to advocate for exploring the solution space as many organizations run deployment systems where human intervention in production is disallowed. More than that, managing StatefulSet PVCs is almost certainly a primary use case for the resizer and this workflow:

Delete the StatefulSet
Update all of the PVC annotations
Recreate the StatefulSet with new template settings

isn't much better than manually managing the storage settings without the resizer at all.
If this is something you would still be interested in addressing, we are also happy to commit resources to helping to add whichever design path your team would prefer. We love what your team has done so far, but without this feature, we would probably fork to add it given its importance to a core use case.

@fullykubed
In the first place, may I ask why it is necessary to synchronize the resizing of PVCs within the group? Would it not be sufficient to have each volume resized by the pvc-autoresizer when it approaches depletion?

@cupnes
Absolutely that would be completely fine, hence my second proposed solution.
Let me restate the problem to ensure we are on the same page:
The canonical way to create PVCs used by many controllers such as StatefulSets is via spec.volumeClaimTemplates. Thus, the canonical way to add resizer annotations currently is via spec.volumeClaimTemplates[].metadata.annotations. However, spec.volumeClaimTemplates is immutable after creation. Thus there is currently way to change the resizer settings for a StatefulSet's volumes after the StatefulSet has been created  (this applies to many other controllers).
The solution your team has proposed (kubectl delete --cascade=orphan) does not work for the reasons outlined in previous comments, particularly with respect to environments where deployment is done via automated systems.
I have proposed adding the ability to resize PVCs as a group as (1) this provides a mechanism to resolve the problem and (2) the resizer already has a partial notion of this concept (resize.topolvm.io/initial-resize-group-by), and (3) conceptually that is what a StatefulSet is already doing even though it disallows updates.
That all said, if there is an alternative path that can resolve the problem and be easier to implement in the resizer, I am 100% supportive.

@fullykubed
What is the reason for wanting to continuously resize the PVC as a group? What kind of problems will be resolved by doing so?
I thought that the essence of the problem might be that the StatefulSets are immutable. However, this issue is not limited to the pvc-autoresizer. I think it might be better to create a controller that bypasses the StatefulSets and adds annotations.

I  thought that the essence of the problem might be that the StatefulSets are immutable.

This is the essence of the problem.

However, this issue is not limited to the pvc-autoresizer

While it is not limited to the pvc-autoresizer, the autoresizer is not very useful if its settings cannot be updated for the very common use case of pvc templates. As PVC templates can never be updated after creation, I have proposed two separate mechanisms to work around this limitation: (1) resize as a group so a user can annotate just one PVC, (2) allow the autoresizer to source settings from a separate, mutable object like a configmap.
Either option would make the pvc-autoresizer useful for managing PVCs created by controllers such as StatefulSets which I hope would be a net positive for this project. We are also 100% open to alternative solutions that do not require manual interventions if your team has one?

I think it might be better to create a controller that bypasses the StatefulSets and adds annotations as another general-purpose controller, rather than implementing to the pvc-autoresizer.

In theory, I would agree. In practice, no such controller exists (unless I am ignorant of one). Needing to copy annotations across objects isn't a very common problem (at least in my experience).
From a pure level-of-effort perspective, it would be easier to fork the autoresizer to add the ability to source settings from a ConfigMap than building an entirely new annotations syncing controller.
That said, our preference is to work with you and team to align on a solution that balances the costs of increased complexity with the ability to use the controller in common scenarios. Are you also interested in finding a solution?

The annotation issue with StatefulSets is a more common problem than you might think, and it is recognized as a Kubernetes issue. Here is the related issue:
https://github.com/kubernetes/kubernetes/issues/121178
Therefore, we believe that the demand for a controller that bypasses StatefulSets is not as low as you might think.

Are you also interested in finding a solution?

It is difficult to accept your specifications as they deviate from the simplicity and existing architecture that the pvc-autoresizer aims for.

Regarding building an entirely separate controller: I am 100% in agreement there is a case to be made for such a controller to exist.
However, I think we are also aligned in that we are both looking for the simplest possible solution to the problem at hand: that the autoresizer has limited usefulness in many common scenarios due to this limitation in core Kubernetes.
As we have called out, it would be significantly easier for us to maintain an enhanced fork of this project than build an entirely new controller to workaround its limitations. That said, we would love to collaborate instead.

Can you be more specific about what would be an acceptable enhancement to the resizer for this problem?
I have been trying very hard to collaborate, presenting multiple proposals and offering resources from my company to build and maintain whatever enhancement you would prefer.
As our user base sees it, the resizer is not useful without some enhancement here to allow it be used for StatefulSets and other controllers. Correct me if I am wrong, but it seems like your team is strongly philosophically opposed to solving this problem from within the resizer itself.
If that is the case, can you let us know so we can get started on the fork? If not, can you please offer some guidance that helps move us closer to an acceptable proposal?

Can you be more specific about what would be an acceptable enhancement to the resizer for this problem?

We can only accept the creation of an entirely separate controller. There is an issue with updating the annotations of the StatefulSet in Kubernetes. If this issue is resolved, the functionality we are discussing here will no longer be necessary. In that case, if it is a separate controller, we can simply remove that controller.


No bounds on structs

Unless absolutely necessary.

https://github.com/quartiq/minimq/blob/2b8b2ee7ca03ff2a65d420437133d4395a1cbd80/src/mqtt_client.rs#L52
https://github.com/quartiq/minimq/blob/2b8b2ee7ca03ff2a65d420437133d4395a1cbd80/src/mqtt_client.rs#L263-L268
https://github.com/quartiq/minimq/blob/2b8b2ee7ca03ff2a65d420437133d4395a1cbd80/src/mqtt_client.rs#L677-L680
https://github.com/quartiq/minimq/blob/2b8b2ee7ca03ff2a65d420437133d4395a1cbd80/src/config.rs#L19
https://github.com/quartiq/minimq/blob/2b8b2ee7ca03ff2a65d420437133d4395a1cbd80/src/config.rs#L33

and others
ref https://stackoverflow.com/questions/49229332/should-trait-bounds-be-duplicated-in-struct-and-impl

I think the only cleanup we can do is remove the broker bound because Instant has a bound on the construction parameter: https://docs.rs/embedded-time/latest/embedded_time/struct.Instant.html


Fix active url validation

Fix for #11173

:+1:

Could this be misleading maybe? What if the actual URL isn't active but the root domain is. Aren't we trying to validate the exact URL that is passed in?

I believe if you were to pass http://google.com/about it would return false even if that page did exist since checkdnsrr can only validate host names and IP addresses not full URLs.

@taylorotwell: What @willrowe said is correct.  The current implementation fails when validating https://google.com/about.  In fact, it will fail on anything more than a protocol+base domain, since checkdnsrr() was meant for DNS records, not URLs.
I wasn't attempting to do a full validation of the URL, which would require making an actual connection attempt.  That's a valid use-case, but I think would warrant a new validator method to prevent breaking issues (or, at least, to prevent extra network traffic when it's not expected).

Thanks for the contribution. I wonder if we should maybe just add this as a new validation rule rather than updating the existing one? Now that 5.1 is in it's LTS maintenance phase, new features will need to go to 5.2.
Ultimately though, it's up to Taylor to decide what he wants here.

No need to retarget at 5.2 or anything for now is what I was getting at. ;)

Fair enough.  I still feel, even with my PR, that the active_url rule is "broken", in that it isn't really checking if the given URL is active.  I was simply trying to make it "less broken".  In that regard, I could argue for it making it into 5.1.  I'd also be in favour of a new rule for 5.2 that made an HTTP/FTP request to really check a URL (although there are lots of reasons that might fail on valid URLs as well).

If wanted to make a new rule that actually hits the given URL for a 200 response we could have something like ping_url but I think we should wait for community demand on that. This rule has been out for years and only just now is getting this fix which tells me it may not be the most highly used validation rule we have :smile:

i know, i am late. but i find out that this will NOT work with IDN Domains like "müller.de"
you have to contert it to a ascii-domain.
you can use this function: http://php.net/manual/de/function.idn-to-ascii.php
or - for example - this class (because idn-to-ascii needs to be "installed")
https://github.com/true/php-punycode


Changes addressing CVE_2016-3382, CVE-2016-3386, CVE-2016-3389, CVE-2016-3390, CVE-2016-7189, and a mitigation of a CFG bypass.

Details:
Calls that target the external thunks should decrement the callinfo param count if the extra-param flag is set.
Don't optimize spread operation in a parameter list if the array we're spreading may have gaps. Accessing an element in the prototype chain may have side-effects that invalidate the optimization.
Port disabling of UT that times out
Type confusion in JavascriptArray
Type confusion in JavascriptArray::TemplatedGetItem()
Array.prototype.join()
Array.prototype.indexOf()
Array.prototype.lastIndexOf()
Type confusion in JavascriptArray::TemplatedGetItem()
Function.prototype.apply()
Type confusion in JavascriptArray::MapHelper()
Array.prototype.map()
CRC computation and validation for the encoder buffer
Premise:
Encoder phase takes longer time for a relatively larger function. So the buffer to which we write the encoded bytes will be RWX all the while till it completes the encoding.
This time is big enough for the main thread to write in this region.
We then transfer the data to the final buffer and execute the code in the buffer(which, now, also contains the modified code).
Mitigation:
We can check the integrity of the buffer data using CRC32(Cyclic Redundancy Check) at suitable spots.
Following is the mechanism for validation:

Start with a random CRC seed.
Compute the CRC1 during the encoding phase.
Validate the CRC1 during branch shortening.
Compute CRC2 during branch shortening.
Validate CRC2 (or CRC1, if branch shortening didn't happen) after copying the entire buffer to the final RX buffer.
Finally, register the entry point as a valid CFG target.

CRC32 Intrinsic instruction is available only on SSE4 and above. Hence for other cases, CRC32 algorithm is implemented.
We were storing LabelInstr* directly in the encoded bytes - Moved it to be stored in a property. - To enable CRC calculation.
Perf results:
No visible changes in console benchmark run (desktop and low-memory device).
Fixes to use-after-free in Globopt, Lowering.
Tail duplication consists of the following code :
branchEntry->ReplaceTarget(mergeLabel, tailBranch->GetTarget());
instr = branchEntry;
branchEntry is a reference to a SList node that can get deleted within
ReplaceTarget function. Subsequent use of the same reference is referring
to a freed value. Fix by caching branchEntry before ReplaceTarget.
Lowering floor builtin code creates a 'zero' MemRefOpnd, which gets passed
through Legalizer, which can delete the Opnd. Subsequent uses of the
MemRefOpnd in Lowering refers to a freed value. This is fixed by
AutoReuseOpnd which will avoid this scenario.
Correcting the version check for SSE4

@meg-gupta , @satheeshravi , @suwc , please review your individual changes. (Thanks.)

LGTM

LGTM

:shipit:

LGTM


5.9 backport of Fixing NSFS semaphore leak

Signed-off-by: Evgeniy Belyi<EMAIL_ADDRESS>Explain the changes

Backporting semaphore leak fix to 5.9

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

by mistake for now, closing


chore: widen ndarray version

It will build & tests pass with either 0.15 or 0.16.  We'd like to upgrade to ndarray 0.16.

Thanks!

Thank you, Pat!
Thanks for merging, Magnus! Could you please merge these Dependabot PRs and tag a new release of sprs?

https://github.com/sparsemat/sprs/pull/358
https://github.com/sparsemat/sprs/pull/359

This Dependabot PR is currently failing CI:

https://github.com/sparsemat/sprs/pull/356

@sjackman @pmarks New minor version of sprs has been released


secrets-store.csi.x-k8s.io/v1alpha1 is deprecated.

The version v1alpha1 is deprecated.

@johnmarco - Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Custom Fonts: Allow inserting custom fonts via URL

Note: The UX of this issue is still in progress and the feature might change a little bit
Feature Description
Figma link to be added once ready

[ ] Add the necessary input(s) to the Dashboard Settings for inserting custom font via URL
[ ] Extract the font metrics and save the URL and relevant data about the URL (needs to be checked which library to use, see https://github.com/google/web-stories-wp/issues/4717#issuecomment-981943916)
[ ] Display the custom fonts in a separate section in the Font Picker
[ ] Allow removing fonts
[ ] Consider invalid URLs

Note: This issue does NOT include any API work and assumes that all that part is already in place.

Alternatives Considered

Additional Context

Although this issue can't be completed before the API is ready, we could already do the following using dummy data before to make things quicker once the API is done:

Implement the UX
Implement extracting the font metrics utils (find the suitable library)
Add a new section to the Font Picker using dummy URLs

Yes, a lot of this is not blocked by the API work at all.

Tested this on https://stories-qa-wordpress-amp.pantheonsite.io/ running PR #9966
Status: LGTM 👍
Scenarios:

Confirmed experimental feature flag (on/off) ✔
Confirmed success case for adding custom font via URL ✔
Confirmed negative case of trying to add woff2 font or using a font URL that is behind CORS ✔
Confirmed ability to use the said custom font inside the editor ✔
Confirmed deleting font removes it from the available font list in editor ✔

@miina ... some things to note that might need future polish:

when I use the custom font in the editor, there is some weird flickering. I saw it when i changed color of the custom font.... like there is a temp font style applied and then the custom one. this is not consistently reproducible, but it only happened for the custom font.
when a custom font is applied to some text in the story, and then the custom font is deleted, the original text continues to show the deleted custom font even though the drop down no longer has it.

when a custom font is applied to some text in the story, and then the custom font is deleted, the original text continues to show the deleted custom font even though the drop down no longer has it.

That is expected until we have some mechanism in place to notify users about deleted fonts. See #10014


[#5553] SimpleChannelPool#notifyConnect() may leak Channels

Motivation:
The SimpleChannelPool#notifyConnect() method will leak Channels if the user cancelled the Promise in between.
Modifications:
Release the channel if the Promise was complete before.
Result:
No more channel leaks.

@rkapsi PTAL

@normanmaurer LGTM

Cherry-picked into 4.0 (1f3bae78c5823d2e3c43ba0666f889e3850df34a) and 4.1 (b8400f96283fec0b1f60232aab52da06a9921ad6)


HCBonemeal broken?

1.2.5
No config option, bonemeal has no effect on crops or soil, isn't used up on right click.
Gloom looks fantastic btw, can't believe how fast you got it done.

Fixed.


Normalized view settings in the media manager, now we can use the sam…

…e settings (icon size, paging limit, display type table/grid among the different media panels. For achieveing this feature, we have opted to use the extjs localStorage proxy to save said settings.

Description
Please describe your pull request:

To normalize all the view settings (Paging limit, Icon Size, Display type (table/grid)
Usability / End user experience
No

Questions
Answers

BC breaks?
no

Tests pass?
yes

Related tickets?
https://issues.shopware.com/issues/SW-17809

How to test?
Open the up the media manager in the backend, change the display type, change the paging limit, change the icon size. Reload the page, open up the media manager again, all the previous settings will stay in place.

Good catch! I also thought $.proxy was jquery, I will not use it that way,
now it's more like:
getSettings:function(){
var me = this,
settingStore = me.subApplication.getStore('Setting'),
settingRecord = null,
grid = me.getMediaGrid(),
view = me.getMediaView();
settingStore.load(function(){
    if(!settingStore.getAt(0)) {

        settingRecord =

Ext.create('Shopware.apps.MediaManager.model.Setting');
        /**
         * Initialize the record with default values provided by

the view and the mediaGrid.
*/
        settingRecord.data = {
            DisplayType: view.selectedLayout,
            ItemsPerPage: view.mediaStore.pageSize,
            ThumbnailSize:  grid.selectedPreviewSize
        };

        settingStore.add(settingRecord);

    }
});

return settingStore.getAt(0);

},
On Wed, Mar 29, 2017 at 4:17 PM, Stephan Pohl<EMAIL_ADDRESS>wrote:

@klarstil commented on this pull request.
In themes/Backend/ExtJs/backend/media_manager/controller/media.js
https://github.com/shopware/shopware/pull/1068#discussion_r108687747:

     var me = this;

   var view            = me.getMediaView();

   var mediaGrid       = me.getMediaGrid();

   var settingStore    = me.subApplication.getStore('Setting');

   var settingRecord   = null;

   settingStore.load(function() {

@shyim https://github.com/shyim Right, in ExtJS it's Ext.bind(fnName,
scope), good catch, thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/shopware/shopware/pull/1068#discussion_r108687747,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIIc5LRhrkExQT_QDeyVTAlSpqoKLyGPks5rqmfngaJpZM4Ms6Qy
.

--
Stange, Federico

So you want me to change Setting to setting ?
settingStore = me.subApplication.getStore('Setting'),
PS: Stephan if you could get in touch with me through gtalk that'd be great
:)
On Thu, Mar 30, 2017 at 9:59 AM, Stephan Pohl<EMAIL_ADDRESS>wrote:

@klarstil commented on this pull request.
In themes/Backend/ExtJs/backend/media_manager/controller/media.js
https://github.com/shopware/shopware/pull/1068#discussion_r108862610:

@@ -119,6 +124,87 @@ Ext.define('Shopware.apps.MediaManager.controller.Media', {
me.callParent(arguments);
},

getSettings:function() {

   var me = this,

       settingStore = me.subApplication.getStore('Setting'),

       settingRecord = null,

       grid = me.getMediaGrid(),

       view = me.getMediaView();

   settingStore.load(function() {

       if(!settingStore.getAt(0)) {

           /**

            * Initialize the record with default values provided by the view and the mediaGrid.

            */

           settingRecord = Ext.create('Shopware.apps.MediaManager.model.Setting', {

               DisplayType: view.selectedLayout,

Agreed
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/shopware/shopware/pull/1068#discussion_r108862610,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIIc5HHNQuCoweiAhVQaISNWfSMDz3iFks5rq2DPgaJpZM4Ms6Qy
.

--
Stange, Federico


Job history clean up job needs to be enabled before it appears

It should be noted in the "Job history clean up" cleanup section that the "Execution history cleanup" feature needs to be enabled through Feature Management before it shows up in the Data Management workspace.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d35f4fb2-1296-20ef-56c2-a2c5aa00befe
Version Independent ID: 0d515af9-9419-4f21-223e-25344cf1bfe8
Content: Data import and export jobs overview - Finance & Operations | Dynamics 365
Content Source: articles/fin-ops-core/dev-itpro/data-entities/data-import-export-job.md
Service: dynamics-ax-platform
Product: ****
Technology: ****
GitHub Login: @Sunil-Garg
Microsoft Alias: sunilg

@f7a6875, thank you for providing this feedback.
@Sunil-Garg, please review and update the content, as needed.

Bug 516452 has been logged to track this issue.

@f7a6875 thanks for the feedback. The doc update has been submitted. Thanks again.


Send staging emails to Amazon SES

Removes whitelist only mode for staging, thus emails
in staging environment will be sent to Amazon SES, allowing
us to try changes to email-alert-api in staging with
realistic timings and get a better idea of what a load on
staging does to metrics

Thanks @thomasleese (and further thanks for the hint re: trial mode) - as far as I can tell, this would cost about $100 a day in Amazon SES so it's not a good use of money to enable this permanently, I think it's better to just SSH into the boxes and change the environment variable on an as needed basis.


[Question]: How is it possible to share a folder/SMB drive with the host?

Is your question not already answered in the FAQ?

[X] I made sure the question is not listed in the FAQ.

Is this a general question and not a technical issue?

[X] I am sure my question is not about a technical issue.

Question
vDSM seems to create data.img on my specified docker volume. The data inside data.img is not transparent to the host though.
Would it be possible to share data somehow?

debian/ubuntu host, cifs:
sudo apt install cifs-utils
sudo mkdir /mnt/path
sudo mount -t cifs //192.168.x.100/path /mnt/path -o username=shareuser,password=sharepassword

Thanks but this won't work as the host and the vDSM container share the same IP address. Is there not a way to pass a host-folder through like the way to pass through a host disk device?

There is no problem with it being the same IP, as you are mounting /client. The problem is when you place two samba-server services on the same IP, in this case it is necessary to change the ports of one of the services.

I am not sure how you mean. I access my vDSM container on 192.168.xxx.22:5000 whereby 192.168.xxx.22 is the host IP.
If I mount CIFS from a host like mount -t cifs 192.168.22/path I am trying to mount the CIFS of the host machine and not the vDSM docker container.
What I am looking for is a way to share existing data (on the host) with the vDSM container, e.g.
Host---folder 1
Host ---- Docker --> r/w access folder 1

Now I understand.
Here I have this configuration.
Debian (host) > samba server
VDSM (vm) - different ip
In VDSM I mount the Debian samba server and access the network only through VDSM. However, you need a dedicated IP for VDSM or you need to change the default samba server ports on the host.
However, through the VDSM GUI you cannot mount the remote folder with another port.
In fact, it is not possible to mount via cifs with another port.
So I recommend using VDSM as a VM or using macvlan and giving it a dedicated IP.
Maybe someone has another suggestion for you.


volume mount geoip not found

Tried to deploy this chart to k8s with geolocation.enabled = false. Still getting the error below:
STDERR:
Error: release plausible failed, and has been uninstalled due to atomic being set: Deployment.apps "plausible-analytics" is invalid: spec.template.spec.containers[0].volumeMounts[1].name: Not found: "geoip"
Guessing theres a missing guard somewhere to prevent this mount when flag is set to false?

Need to take a closer look, I always used it with volumeMounts.

same from my sidem any suggestions?

  Error: release plausible failed, and has been uninstalled due to atomic being set: Deployment.apps "plausible-plausible-analytics" is invalid: spec.template.spec.containers[0].volumeMounts[1].name: Not found: "geoip"

I set false in  geolocation flag

I'm getting the same error now without setting anything, I think it is related to the last commit:
Release "plausible" does not exist. Installing it now.
Error: release plausible failed, and has been uninstalled due to atomic being set: Deployment.apps "plausible-plausible-analytics" is invalid: spec.template.spec.containers[0].volumeMounts[1].name: Not found: "geoip"

Seeing the same thing. Any solutions?


Cherry pick 3673 into 1.6

#3673
cc @Johnmcpms / @ranm-msft
Microsoft Reviewers: Open in CodeFlow

We can't get updated localizations fast enough for the changes we want to make here.  The line endings I would take, but I don't love the idea of the english and other languages being out of sync.

We can't get updated localizations fast enough for the changes we want to make here. The line endings I would take, but I don't love the idea of the english and other languages being out of sync.

I can revise so its just the line endings


Split

split the service into seperate modules: polling and websocket
reduce the built docker image size

As for #8:
Truns out that the image size is a sum of base image and all the layers produced along the docker build process (each step in the Dockerfile will produce an intermediate layer)
If we rm -rf at the end of the build, actually the image size won't change too much (got ~1G to ~1G for this)
Instead, to produce a small image, have to use a striped-down base image (ocaml/opam:alpine -> alpine:3.5) AND keep a small image along each step of the building process specified in Dockerfile (got ~1G -> ~200M for installed size and 83M for compressed size)
There should be still space to squeeze it, but the bulk part is out of the way already.


Update openpgpapi lib

The version of openpgpapi is 9, how can I update that to the latest one i.e. 12?

The openpgp-api used by K-9 is embedded as part of a release.
I think updating the version in K-9 will be a case of simply copying across the new code (we don't change it, but we copy it in as it's not currently published in Maven and Git submodules are painful) and then testing various code paths that might have changed.
I would expect/hope that we'll upgrade before we do another release.
cc @Valodim

I brought this up because I noticed when encrypting emails, the pgp block is almost double the block generated when using Openkeychain's encrypt text feature. I am assuming both K9 and Openkeychain use Openpgpapi to encrypt/decrypt data and the PGP block for Openkeychain is smaller because they are using the most recent version of Openpgpapi

Are you compare PGP/MIME to Encrypt Text or PGP/INLINE.
PGP/MIME encrypts more of the message headers and content type (and more complex emails like HTML emails with plain text alternatives, as well as regular attachments) so will be bigger. K-9 uses PGP/MIME by default.
If the PGP/INLINE looks bigger it's probably an encoding issue.
I don't think the new version is more efficient: https://github.com/open-keychain/openpgp-api/blob/master/CHANGELOG.md

No, I am talking about PGP/INLINE.


feat: added type.

I made type. — simple local-first milkdown-based editor.
It’s featured with imports, exports, batch loading, publishing, autosaving and a bit of customization.
Hope it deserves a mention.

Cheers!


Replace announcements lists with news and comms lists on world location news pages

https://trello.com/c/u6doZAVR/373-replace-announcements-lists-with-news-and-comms-lists-on-world-location-news-pages
We have created a new finder within finder-frontend called news and communications.
This change ensures that the information under news and communications on the /world/:slug/news pages matches the content of the news and comms finder (they both filter results based on content_purpose_supergroup: news_and_communications).
The link to the announcements finder has also been replaced.
The goal is to deprecate the announcements finder and replace it with the news and communications finder; replacing the links is required before we can do this.
Before: https://www.gov.uk/world/jamaica/news

After:

I'm wondering whether we should use the existing translations for Our announcements until we can swap them out for updated translations.


[Enhancement] Disable for certain filetypes

Would be great to disable this for certain filetypes.
If I have a Lazy window opened, I'll see diagnostics:

You can now provide a config.enabled as a function to customize summary's appearance.
{
    "ivanjermakov/troublesum.nvim",
    opts = {
        enabled = function()
            return vim.bo.filetype ~= "lazy"
        end
    }
}


Added jetbot_controller, a ROS control interface for jetbot

This PR contains an idiomatic ros_control node for controlling jetbot. It's a C++ implementation of the full stack for exposing the Adafruit Motor HAT i2c device to ROS via its standardized control interface.
Features:

2x Faster - Existing implementations of motor movement for the jetbot are slow. Python takes ~20ms to send a speed command to both motors (averaged over 1000 commands). These commands are not written simultaneously, so there's potentially 10ms between motor updates (i.e., drift). This implementation takes 8ms (i.e., 4ms between motor updates) to do the same, resulting in observably straighter drive behavior. There's more room for optimization here... It should be possible to make the motor updates happen simultaneously (i.e., within a few clock cycles) using linux's i2c rdwr ioctl, but that would require significant API changes from the Adafruit API this PR roughly mimics.
Robust - While this implementation currently works with the Adafruit Motor HAT, it is written to allow another motor driver to be easily swapped in with minimal code changes.
Bare Metal - This PR talks directly to the Adafruit Motor HAT's PCA9685 PWM driver over i2c with linux syscalls. This gives us much finer control over the chip's state. It also contains a decent i2c C++ abstraction that should make integrating other i2c motor drivers straightfoward.

Future Work:

Better Calibration - The relationship between motor speed and movement speed is non-linear. At speeds less that 80% the calibrated behavior is incredibly poor.
Complete Installation Logic - The current CMakeLists is incomplete. It does not handle installation.

Dependencies:

rang - A CLI coloration C++ library under the MIT license. This is included straight in the calibration node's source folder, but it makes sense to place it in some third party location with license/attribution information.

This PR will certainly have some issues that need to be resolved before merge, but I think it's in a state to start iterating.
Handy Reference Materials:

PCA9685 Datasheet

Okay, I added the rang license to its header file. We should be good.

Thanks @bmcdorman! Really appreciate the contribution. It looks like the cMakeLists.txt file is structured for catkin. Could you restructure the file (with the install targets set) so it can be built (then sourced/executed via the install directory) with colcon? Thanks!


Error message "Error: Query engine binary for current platform "..." could not be found" could list other file from that directory to help debugging

If you get the error in https://github.com/prisma/prisma-client-js/issues/620 it can probably have 2 causes:

Your client is looking for the wrong engine
There is not engine at all in that folder

Listing the content of that folder in the error message would help the be able to understand this.

This is implemented in the latest alpha.
The error now looks like this:
Invalid `prisma.user.findOne()` invocation in
/Users/tim/code/p2/prisma-client-js/packages/photon/fixtures/blog/main.ts:7:17

   3 const prisma = new PrismaClient()
   4
   5 async function main() {
   6   const users = await Promise.all([
→  7     prisma.user.findOne(

Query engine binary for current platform "darwin" could not be found.
This probably happens, because you built Prisma Client on a different platform.
(Prisma Client looked in "/Users/tim/code/p2/prisma-client-js/packages/engine-core/query-engine-darwin")

Files in /Users/tim/code/p2/prisma-client-js/packages/engine-core:

  .gitignore
  .prettierrc.yml
  README.md
  dist
  download.js
  node_modules
  package.json
  src
  tsconfig.json
  tsconfig.tsbuildinfo
  yarn-error.log

You already added the platform "native" to the "generator" block
in the "schema.prisma" file as described in https://pris.ly/d/client-generator,
but something went wrong. That's suboptimal.

Please create an issue at https://github.com/prisma/prisma-client-js/issues/new


Demo skywalking website is down

Please answer these questions before submitting your issue.

Why do you submit this issue?
[x ] Bug

Bug

What happened?
I was going through main page and saw live demo option, but seems that on clicking that (https://demo.skywalking.apache.org/) is opened but, its down.

Requirement or improvement

Expected: The live demo website should be available for demonstration purposes.

@ascrutae PTAL

It is back online.

its down again

its down again

Still work on my side.


Component browser should not suggest Base.Network methods for Text node

Discord username
No response
What type of issue is this?
Permanent – Occurring repeatably
Is this issue blocking you from using Enso?

[ ] Yes, I can't use Enso because of this issue.

Is this a regression?

[ ] Yes, previous version of Enso did not have this issue.

What issue are you facing?
 Opening CB selects Base.Network methods which immediately leads to an error due to "no such method' exception, see screenshot.
Expected behaviour
CB should first suggest Text methods.
How we can reproduce it?
Unnamed_5.2.zip
Project hijacked from another issue. Just try to add a node, as per screenshot.
Screenshots or screencasts

Enso Version
develop
Browser or standalone distribution
Chrome
Browser Version or standalone distribution
110.0.5481.100
Operating System
Linux
Operating System Version
No response
Hardware you are using
No response

Can't reproduce on my side, the suggestions for a text literal node seems expected:

@hubertp Could you try to reproduce it on the latest develop? I cannot reproduce it even on older releases, neither can Pawel. Could there be something wrong with your environment at that time?


Plugin is not working accordingly

Hello @unlight
Thank you for this nice plugin. It will save some time while developing forms with Tailwind CSS, for sure!
But it seems it is not working anymore 🤔
Plase check: https://unlight.github.io/tailwind-float-label

When you focus the field, nothing happens.

@juliovedovatto when it was working for you (which version)?
I've checked latest v1, v2 and it behavior is the same.
Label rises up when placeholder dissapers - when you start typing, not when field get focus.
https://user-images.githubusercontent.com/301732/162283116-c09363b4-3bfd-4f64-b33d-c894ec116a35.mp4

@unlight The example page is little confusing, I think I misinterpreted it 😅
Does your plugin have animations when a user interacts with the field? I was expecting some form of animation for when user
focus the field or starts typing.
BTW, I'm using Tailwind 3

No worries.
There is no animation in this plugin, but you can add your custom style to label.
const postcss = require('postcss');

module.exports = {
	// ...
    plugins: [
        require('tailwind-float-label')({
            label: {
			   // Plugin defaults
                ['@apply leading-none text-xs px-1']: '',
                top: 0,
                left: '0.25rem',
			    // Animation
                // transition: 'all 250ms', // option 1
                ['@apply transition-transform']: '', // option 2
            },
        }),
    ],
};

Also, you can check similar project and resources sections, there are some examples with animation.


Does SCDYouTubeKit support play a video offline?

If It played a video online , could it cache the video data so that it can play the video next time without internet.

@oososo Yes you can. However, you will need to write come sort of networking code for that like NSURLSession


after installating ODK Aggregate v 1.4.4 on ubuntu web page of ODK does not appear

Originally reported on Google Code with ID 1088
i installed ODK Aggregate v 1.4.4 on ubuntu 12.04. After installation when i open the
web page using url "http://ip of server:8080/ODKAggregate it displays the message "Application
is not currently available"

Reported by dgmon2014 on 2014-11-22 06:56:01

Please ask any questions such as this in the Google group.
Thanks,
Dev Team


Feature Request - Böttcher function of a complex variable

Hi,
as in the title
Matemathica:
http://math-functions-1.watson.jp/sub4_math_020.html
(It is in Japan but you can translate it. It works fine )
http://math-functions-1.watson.jp/file_math010/v8_specialfunctions/fractalrelated.zip
http://reference.wolfram.com/language/ref/MandelbrotSetBoettcher.html
http://www-personal.umich.edu/~kochsc/bottcher.pdf
https://books.google.pl/books?id=2CMRBwAAQBAJ&pg=PA34&lpg=PA34&dq=boettcher+coordinate&source=bl&ots=ub-8z8aRz-&sig=PAVlzi0YQHIeegKmuDfuBS1J2ys&hl=pl&sa=X&ved=0ahUKEwjQ8sON1prWAhXBDpoKHaMiB0kQ6AEIUTAE#v=onepage&q=boettcher coordinate&f=false
wikipedia:
https://en.wikipedia.org/wiki/Böttcher's_equation
naive description:
https://en.wikibooks.org/wiki/Fractals/Iterations_in_the_complex_plane/MandelbrotSetExterior#Complex_potential
https://en.wikibooks.org/wiki/Fractals/Iterations_in_the_complex_plane/boettcher
http://fraktal.republika.pl/cpp_argphi.html
key words:

Boettcher coordinate
external ray
complex potential
Riemann map

TIA
Adam

A couple of things:

We can't read that source code because it is not clear how it is licensed.

I am not sure what you are asking for. Do you mean that you want a tool that, given an analytic function h with a superattracting fixed point a, finds a function F defined in a neighborhood of a so that F(h(z)) = (F(z))^n? Or do you want something more specific (i.e. the particular function that Mathematica implements)? The more general thing is almost assuredly out of scope for SciPy.

Whatever is desired, we would need references to scholarly papers that discuss implementation.

Licence:

" Use of all contents of in this site is free. But in that case,

URL address of this site,
Administrator name of this site the "Souichiro-Ikebe",
please specify and display in your web site or books.
In addition, you do not need to check and contact to me in advance that you want to use."
It is translation from the page :

http://math-functions-1.watson.jp/index_100.html#section010
-task
I ask only for case where h(z) = z^2 + c where c is complex constant
here n = 2
her is description:
http://www.mndynamics.com/indexp.html#XR

@adammaj1 I would suggest typing out an example implementation in this issue that uses the scipy API. Please use scipy.integrate.solve_ivp to solve the differential equation.

I would suggest typing out an example implementation

Please don't. The issue here is (from https://github.com/scipy/scipy/blob/master/doc/source/dev/newfeatures.rst):

Is what you are adding something that is well understood in the literature? If not, how sure are you that it will turn out well? Does the method perform well compared to other similar ones?

scipy.special already has a bunch of functions that did not turn out well. If we're going to add new functions we need papers from good journals that discuss double-precision implementations and the range of values for which those implementations will work. I don't see that here yet, so I'm inclined to close this as out of scope.
Special functions are tricky. They should not be implemented lightly.

@person142 From what I understand, he wants to add Mathematica's MandelbrotSetBoettcher. It appears to be trivial to sketch out a basic implementation, and I think would allow everyone to see what is being proposed. That does not mean that it would be accepted.

@xoviat that is reasonable; I apologize for sounding curt. I made a gist with a naive implementation here:
https://gist.github.com/person142/62b44fbe08bc24edfaacc39ef92728e7
Note that the Mathematica definition is overly vague because it doesn't handle the branch cuts of the 1/2**nth root correctly. (Obviously it's not what they're doing in the code because they get the right answer.)
A better reference is here:
http://www.sciencedirect.com/science/article/pii/S019688588371002X
Useful papers are also:
https://projecteuclid.org/euclid.dmj/1077304731
https://link.springer.com/article/10.1007/BF01385497
@adammaj1 with the above papers I'm optimistic that a good implementation is possible. (Rough idea is to use the Laurent series for the disk |z| > 2 where you are certainly outside of the Mandelbrot set and an iteration approach inside the disk.)
I will see what I can do.

tavis_cpp.txt
HI,
Thx for the answer.

Computing the Laurent Series of  ..
I think that it descibes map from exterior of circle to exterior of Mandelbrot  set. Boettcher map is it's invariant ( = from exterior of Mandelbrot set to exterior of circle)

More information:
There is a method which probably computes argument of Boettcher coordinte
( result of Boettcher map :
https://en.wikipedia.org/wiki/External_ray#Uniformization_2
It is called Stripe Average Coloring:
https://commons.wikimedia.org/wiki/File:Mandelbrot_set_-_Stripe_Average_Coloring.png
https://commons.wikimedia.org/wiki/File:Stripe_Average_Coloring_-_Mandelbrot_set_zoom_(_wake_1over3_).png
it is described here :
https://en.wikibooks.org/wiki/Fractals/Iterations_in_the_complex_plane/stripeAC
here one can find the code and description of using Runge-Kutta integration for finding external angle ( = argument of Boettcher coordinate)
http://www.fractalforums.com/programming/smooth-external-angle-of-mandelbrot-set/
I send also cpp file as a text
HTH
Adam

some test to check precision of computations:
https://en.wikibooks.org/wiki/Fractals/Iterations_in_the_complex_plane/MandelbrotSetExterior#Tests
https://commons.wikimedia.org/wiki/File:Part_of_parameter_plane_with_external_3_rays_landing_on_the_Mandelbrot_set.png
HTH

I think this is a won't do-we have enough special functions already in the API that need attention, so I'm not inclined to add more API surface area.


Hello world in frink

Add Hello World in frink
Description
Add a hello world for the frink language
Types of changes

[ ] Bug fix or improving code quality
[x] New language
[ ] New feature

Checklist:

[x] My code follows the code style of this project.
[x] I have updated the documentation accordingly.

Looks cool, @ccraciun. Any chance you'd want to add your code snippet to the Sample Programs repo?


Update to Cadence v1.0.0-preview.50

Description
Automatically update to:

onflow/cadence v1.0.0-preview.50
onflow/flow-go-sdk v1.0.0-preview.53
onflow/flow-go e211841b59f5
onflow/flow-emulator v1.0.0-preview.41
onflow/cadence-tools/test v1.0.0-preview.38
onflow/cadence-tools/lint v1.0.0-preview.38
onflow/cadence-tools/languageserver v1.0.0-preview.38
onflow/flixkit-go v1.2.1-cadence-v1-preview.24
onflow/flowkit/v2 v2.0.0-stable-cadence-alpha.32
onflow/flow-evm-gateway v0.30.3

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 34.32%. Comparing base (b291db8) to head (28503a3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1714   +/-   ##
=======================================
  Coverage   34.32%   34.32%
=======================================
  Files         100      100
  Lines        6368     6368
=======================================
  Hits         2186     2186
  Misses       3894     3894
  Partials      288      288

Flag
Coverage Δ

unittests
34.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[SPARK-27344][SQL][TEST] Support the LocalDate and Instant classes in Java Bean encoders

What changes were proposed in this pull request?

Added new test for Java Bean encoder of the classes: java.time.LocalDate and java.time.Instant.
Updated comment for Encoders.bean
New Row getters: getLocalDate and getInstant
Extended inferDataType to infer types for java.time.LocalDate -> DateType and java.time.Instant -> TimestampType.

How was this patch tested?
By JavaBeanDeserializationSuite

@dongjoon-hyun @cloud-fan Please, review this PR.

Test build #104188 has started for PR 24273 at commit 2e366b9.

Can one of the admins verify this patch?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9528/
Test PASSed.

Test build #104188 has finished for PR 24273 at commit 2e366b9.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104188/
Test FAILed.

retest this please.

Test build #104189 has started for PR 24273 at commit 2e366b9.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9531/
Test PASSed.

Test build #104189 has finished for PR 24273 at commit 2e366b9.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104189/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9549/
Test PASSed.

Test build #104211 has started for PR 24273 at commit c39b0d5.

Test build #104211 has finished for PR 24273 at commit c39b0d5.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 public static final class LocalDateInstantRecord

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104211/
Test PASSed.

thanks, merging to master!


peer2peer - General cleanup and updates

Description

Removed audio constraints for screen capture which caused Desktop and window capture not working.
Replaced screen capture alert() with a  that has clickable links.
Now removes video events before stopping video tracks.
Moved the screen capture extension source to src/ folder and included a downloadable zip file.
Updated the constraints format.
Replaced the deprecated mediaStream.stop() with mediaStreamTrack.stop() handler.

Purpose
Maintenance and bug fixes.

Just see this pull request here.
For audio share with desktop capture, we've figured out the reason why it fails.
We have already landed chromium change.
And I've made https://github.com/webrtc/testrtc/pull/223 to fix it.

@hkjellander PTAL


Improve denosing algorithm

Implement Nonlinearly Weighted First-order Regression
for Denoising Monte Carlo Renderings from: https://benedikt-bitterli.me/nfor/

Will be solved in #29


Laboratory work #4, Klimov Andrey - 23FPL1

No progress!

I'm sorry, but maybe there is a mistake in tests. I have checked class VectorDBSearchEngine, but there are 2 errors: first one says that there is some problem with importing func, but I use it. I asked about it in chat, but nobody answered. Could you please help me, because I have no idea of this error...I hope that 2-nd error is just linked to the first one


R message from remote comes after switching back to local

Connected to remote. Then switched back to local. In REPL, got first message from local and then message from remote I've already disconnected from.

Actually this looks like local 3.3.1, then remote MRO 3.3.1, then local 3.3.2 then host info from disconnected remote (note connected users == 0)

This should go away after fixes to the session termination/switching. will reactivate if I see it again.

There is async issue since printing broker information comes in lines and may get interrupted by the R prompt.

https://github.com/Microsoft/RTVS/commit/5146a2a262e879e23b940bf6dce0aad0056cfb52


Unable to stack new dialog until user has sent a message

I have a timeout that fires a proactive message. The message address is used from "conversationUpdate", when it fires, the beginDialog is sent but subsequent messages are sent to the first dialog and not the new dialog.
This works fine in the emulator, and works after user has sent a message - using session.message.address as the message address.
This sounds like a bug with the webchat. I should be able to start a new dialog at any address?
//Sends greeting message when the bot is first added to a conversation
bot.on('conversationUpdate', function (message) {
    if (message.membersAdded) {
        message.membersAdded.forEach(function (identity) {
            if (identity.id === message.address.bot.id) {
                var reply = new builder.Message()
                    .address(message.address)
                    .text('Welcome. What can I help you with today?');
                feedbackHasRun=false;

                bot.send(reply);

                restartFeedbackTimer(message.address);
            }
        });
    }
});

function restartFeedbackTimer(messageAddress){
    if (!feedbackHasRun){
        if(feedbackTimer){
            clearTimeout(feedbackTimer);
        }

        feedbackTimer = setTimeout(() => {
            idleFeedback(messageAddress);
        }, 5000);
    }
}

function stopFeedbackTimer(feedbackTimer){
    clearTimeout(feedbackTimer);
}

function idleFeedback (messageAddress){
    bot.beginDialog(messageAddress, "*:feedback");
}

var feedbackText="";
// handle the proactive initiated dialog
bot.dialog('feedback',
 function (session) {
    if (session.message.text === "done") {
        mailOptions.html = feedbackText;
        mailOptions.subject = 'User Feedback';
        transporter.sendMail(mailOptions, function (err, info) {
            if(err)
                console.log(err)
            else
                console.log(info);
            });
        session.send("We appreciate your feedback, you are now continuing your conversation with the bot");
        session.endDialog();
    }
    else {
        if (!feedbackHasRun){
            session.send('Type "done" to send your feedback to us or go back to talking with the bot.');
            feedbackHasRun=true;
        }

        feedbackText = feedbackText + "<br>" + session.message.text;

    }
  });

I think i've got the same issue here, simple example of Contoso Flowers ( https://github.com/Microsoft/BotBuilder-Samples/blob/master/Node/demo-ContosoFlowers/bot/index.js )
// Send welcome when conversation with bot is started, by initiating the root dialog
bot.on('conversationUpdate', function (message) {
    if (message.membersAdded) {
        message.membersAdded.forEach(function (identity) {
            if (identity.id === message.address.bot.id) {
                bot.beginDialog(message.address, '/');
            }
        });
    }
});

Working fine with Emulator but can't make it work when the event is triggered by the WebChat. The app crashes with not much info.
[1] TypeError: Cannot read property 'startsWith' of undefined
[1]     at process._tickDomainCallback (internal/process/next_tick.js:218:9)

Cheers

Possibly due of #1013.
@rafadorado we remove ES5 polyfill from main build recently, you will need to bring in your ES5 polyfill or use one of the polyfill-ed build from us. Please refer to this section in our README.md.

Thanks  @compulim, that makes sense, we were using an older version. By the way we solved this use case by sending custom events with DirectLine.


Add to favorites option in the comics list

When you're in the comic list, there's an option "add to favorites" which doesn't add to favorites but switch to a favorite list. The option is present here too and it switch back to the normal comic list.

Oh yeah soryy, forgot about that. Usually the Favorite Button is always displayed as an icon, so it seems like your screen is very small

It's 4.3 ^^


9612 utf-8 chars limit

Issue description
For text file larger then 9612 chars MV++ stops working
Environment

Notepad++ 7.5.4 (x86)
MarkdownViewer++ 0.8
Windows 10 (x64)

Hi @andrzejQ
Could you please verify with the newest release 0.8.1 which I just published today
https://github.com/nea/MarkdownViewerPlusPlus/releases/tag/0.8.1
There was an unfortunate bug that sounds like it.
Thanks

Yes - works great.

Awesome.
Thanks for retesting @andrzejQ


usernames in trade panels gone after recent update

Hello there, thanks for this fantastic tool! I noticed in a recent update in the last week or two, the username of the player is missing in trade notifications, so it makes it really hard to manage multiple trades at once as I don't know who wants/has what. Is this a user error or...something else? Currently I'm using <IP_ADDRESS>.0.

mouse over on right edge, just resise it

🙇 THANK YOU 🙇


adding conversion to tensorstore

This PR makes a zarray into tensorstore object

Seems like the new pydantic release is breaking.

Re-tested this. Seems to pass CI after merging #244

@edyoshikun Did you cherry-pick the commit from main? The history is now weird. I would rebase it manually.


Scrollbars in code blocks.

Liked your theme and want to make it better.
If you replace overflow: scroll to overflow: auto for pre then those ugly scrollbars would be visible only when they are needed.
It makes the look even more minimal.

@sarg
Thanks, fixed it. Didn't see this behaviour on OS X.


New feature demand

I want to close the alertview automatically, but I don't find some property or action!

Thank you for this feature , I will add it at next release.
you can let it dismiss automatically maybe after seconds.


feat(EU): add services for hazard lights, hazard lights & horn and va…

…let mode

Excellent work!   To make the hassfest check pass one translation file needs strings added.  English most likely

@cdnninja we good to go?

Thanks for the ping!  Merged. Thanks again for the work on this.

Great work. Any chance of an update to expose the external thermometer temperature?


Users/lukillgo/update

@lkillgore,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


[Feature]: Add dynamic loading of contributors cards

Currently, we are displaying the contributors cards all in one go

Instead, I would initially like to display 4 cards and a load button below them which when clicked will load another 4 cards and so on......

@thestarsahil Please assign me this issue

Not necessary , this is all good

@thestarsahil Ok no problem


web apps removing https and custom port

Godot version
4.1
System information
Windows 10 Forward+
Issue description
I use httpRequest to recive data from API
url is something like https://testdb.example.com:port/apipath
godot as web app sends fetch requests as http://testdb.example.com:80/apipath
it causes mixed content errors
Using godot web app + nginx proxy manager + nginx + pocketbase
Tested on browsers: firefox, chrome
Also if I copy that request into console and send it after fixing url it returns 200 - success
Also my port for https is not 443 cause router I have at home is occupying it and it is not possible to be changed atm
Steps to reproduce
have domain that you can add subdomains to
host godot web app on one sub domain, host api on second
example code for http request (works with pocketbase)
const db_base_adress := "https://testdb.example.com:port"

func _ready():
	connect("request_completed",_request_completed)

func get_records(collection,token:="",options:={})->Dictionary:
	var body = JSON.stringify(options)
	var error = request(db_base_adress+"/api/collections/"+collection+"/records", ["content-type: application/json", "Authorization: "+token], HTTPClient.METHOD_GET, body)
	if error != OK:
		push_error("An error occurred in the HTTP request.")
	return await self.response_recived

signal response_recived(response:Dictionary)
func _request_completed(_result, _response_code, _headers, body):
	var json = JSON.new()
	json.parse(body.get_string_from_utf8())
	var response = json.get_data()
	if _response_code!=200:
		pass
	#print(response)
	emit_signal("response_recived",response)

Minimal reproduction project
N/A

v4.1.stable.official [970459615]
Hi pietru2004
I am a little unclear on what is the error.
I am unable to reproduce the error.
I tested the scenario with 2 domains and self signed certificate.
As you can see from the screenshot. The request which uses a custom port and HTTPS works correctly.
Godot making a HTTPS request on port 4443

The Godot app is served from https://fake1.local:4443/godot-test.html
The app makes a request to https://fake2.local:4443
extends Node2D

func _ready():
	$HTTPRequest.request_completed.connect(_on_request_completed)
	$HTTPRequest.request("https://fake2.local:4443")

func _on_request_completed(result, response_code, headers, body):
	var asdf = body.get_string_from_utf8()
	print(asdf)

My server configuration
import http.server, ssl
from http.server import HTTPServer, SimpleHTTPRequestHandler, test

class CORSRequestHandler (SimpleHTTPRequestHandler):
	def end_headers (self):
		self.send_header('Access-Control-Allow-Origin', '*')
		self.send_header('Cross-Origin-Opener-Policy', 'same-origin')
		self.send_header('Cross-Origin-Embedder-Policy', 'require-corp')
		SimpleHTTPRequestHandler.end_headers(self)

server_address = ('localhost', 4443)
httpd = http.server.HTTPServer(server_address, CORSRequestHandler)
httpd.socket = ssl.wrap_socket(httpd.socket,
							server_side=True,
							certfile='C:/Users/asdf/localhost.pem',
							ssl_version=ssl.PROTOCOL_TLS)
httpd.serve_forever()

The app is able to read and print the response HTML.

I get error about mixed content while asking pocketbase for answer, also it asks for aplication/json
Also it might be because you connect on localhost and browser treats it diffrently
Gona send screen when I sit at pc, also I use lets encrypt cert.

okay error changed now it shows

and some more errors, and when in "private" window it fully works... it might have been mayby some header or cookies now updating that did not reload on client side when uploading new project files into web server, gona try reloading browser

Screens - left is normal window, right is firefox private mode window

I think my browser must be caching web app making it not reload properly when I upload new build


user able to log in even if 2fa code not verified

There is a bug in 2FA implementation. Currently the app asks for verification code but let's the user access the entire website without filling the code.

lgtm

I am not able to login for a new session

for some users this works and for other I got error! please check for chit4 and lmk if it is something on my system?

its working on local systems and the users created on their systems as expected.


How do I write query sql to configuration files, such as xml or json files, using reactive hibernate?

As flexible as mybatis configuration, you do not need to deeply bind sql with entities, because some complex queries can not be represented by entities, and with one-to-many, multi-to-one and other relational queries, sometimes very complex, but also prone to problems.

I don't think Hibernate Reactive or ORM have an out-of-the-box feature for this.
But, depending on your use case, you can save the queries as constants in a class or interface, or save them in a properties file and read them with regular Java.
@gavinking any suggestion?


CdnJs broken

Submit pr tu CdnJs to update build location to lib

Use build instead of libs to store compiled files


Removing the need to install webtest-master.

I tried uninstalling webtest, and it actually seems it may not need installing since we add it to sys.path in run_python_tests.sh. I also made it clearer if one runs the .py instead of .sh the first time, when we need to download stuff.
 Let's hope we can avoid it. I'm also reluctant to require devs to run stuff like
wget https://bootstrap.pypa.io/ez_setup.py -O - | sudo python
which is recommended by the easy_install webpage.

Never mind, it doesn't work because webtest doesn't get all its dependencies if we don't install it. Meh.


Added WaniKani WDC

Coverage remained the same at 98.913% when pulling 69fe41f723e5ba6600e58301ff096a72a35060df on rarandall:patch-1 into bdf02139063b2b708a6869ebd1ac698ea70d5997 on tableau:master.


Added specific SQL query for trove article indexing.

Generic query combined with amber was still too slow for prod.
Translated the logic that was previously in java into sql so we can more efficiently get the data trove needs for indexing.
This monstrous query is very specifically just for this and could be optimised a lot I think.  But it's a lot faster than before.
Related dl-trove-service pull request: https://github.com/nla/dl-trove-service/pull/35
@terenceingram @scoen @yetti @shuangzhou @JonathanShaw @sjacob @MingtaoSun @weijunnla @jrixon

Awesome job, well done :clap:

The JDBI docs say that SQL statement caching is done on a per handle basis so it's possible that this (large) query is being re-compiled/re-optimized by the DB every time it is run.
http://jdbi.org/apidocs/org/skife/jdbi/v2/package-summary.html
The DB may be caching the query on the server side so it might not be an issue.
Otherwise, :+1:

@jrixon I might have a quick look into whether caching the query would improve performance, but since the query takes about 90 seconds to run in prod anyway, we probably wouldn't see a significant gain.


Can't add https://github.com/ShikiSuen/r128x/releases.atom

I already have many GitHub releases feeds in NetNewsWire (e.g. https://github.com/immutables/immutables/releases.atom), but when I try to add https://github.com/ShikiSuen/r128x/releases.atom I get this error message:

Feed not found
Can't add a feed because no feed was found.

According to https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Fgithub.com%2FShikiSuen%2Fr128x%2Freleases.atom this is a valid Atom 1.0 feed. Any ideas?

Using what kind of account? Of On My Mac, iCloud, Feedly, Feedbin, etc.?
Also: Mac or iOS?

May be something with NNW. Works for me in Inoreader. You can also try Open RSS feeds as an alternative
https://openrss.org/github.com/ShikiSuen/r128x/releases

It works for me in NetNewsWire using my On My Mac account, which makes me think @breun might be using some other type of account.

Using what kind of account? Of On My Mac, iCloud, Feedly, Feedbin, etc.?
Also: Mac or iOS?

Ah sorry, I'm using a Feedly account in NetNewsWire on macOS.
I just tried adding it again, and now it worked. Yesterday I tried multiple times without success. 🤷♂
Since I can't reproduce the issue anymore, I guess I'll close this issue.

Feedly was my guess. We’ve seen this as an intermittent issue with Feedly — looks like some kind of issue on their side.


Fix concurrency bug in ApplicationStoreTest

Application internal names are globally unique, enforced by the database; the test
was intermittently failing if two of its methods ran at the same time because they
used hardwired names that conflicted between tests. Switch to names that include
random UUIDs.

#2689  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Dec 13, 4:57 PM EST: A user started a stack merge that includes this pull request via Graphite.


Add #ifdef to set a custom stack size for managed F*

Here's a simple way of getting around the small stack size in F#/.NET/Windows. Not necessarily meant to be merged into master, I just wanted to save it somewhere.

Is there a drawback to activating this by default?

I don't think so, except increased memory usage perhaps. I didn't check what mono thinks about it yet, but I'll do that right away.

There is a tool for modifying EXE files, that can write a different default stack size (reserve+commit) in.  Could you use that tool to munge the F* binary?  That might be an tidier solution if you rarely need the larger stack size.  We used this tool to munge Dafny for a while, to work around deep stacks in Boogie.

Yes, I think editbin would do that job. Not sure it works on managed binaries though, there may be a separate tool for that. Personally, I prefer it to be compiled right in, but it could just as well be done in a post-build step.

I ran uregressions through the mono binary and I don't get any weird exceptions thrown, so I suppose it's "safe enough" to merge.

Editbin does work on managed EXEs too.  I'm comfortable with both editbin and the code change. :-)

I'm happy to merge this if we make it the default -- I'm weary of having one build configuration that will have little coverage.

That's a good point! I think there won't be any complications, but I can give it a few more tests. It's possible that some debuggers (mono?) may behave slightly differently because now there's a different "main" thread.

As long as it doesn't break the Visual Studio debugger experience, it's good -- I'm not aware of anyone debugging using Mono.

Done and rebased. Just waiting for the green light from the CI.


KYLIN-3295, clean unused class:SQLDigestUtil

Can one of the admins verify this patch?

Codecov Report

Merging #145 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #145      +/-   ##
============================================
+ Coverage     21.85%   21.87%   +0.02%
+ Complexity     3889     3888       -1
============================================
  Files           985      984       -1
  Lines         59716    59660      -56
  Branches       8623     8608      -15
============================================
  Hits          13052    13052
+ Misses        45452    45395      -57
- Partials       1212     1213       +1

Impacted Files
Coverage Δ
Complexity Δ

...g/apache/kylin/source/datagen/ColumnGenerator.java
70.94% <0%> (-1.36%)
8% <0%> (ø)

...a/org/apache/kylin/dict/Number2BytesConverter.java
81.74% <0%> (-0.8%)
17% <0%> (-1%)

.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java
66.15% <0%> (+2.3%)
0% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c67905...4e2000a. Read the comment docs.

Pull Request Test Coverage Report for Build 3181

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.02%) to 23.914%

Files with Coverage Reduction
New Missed Lines
%

core-metadata/src/main/java/org/apache/kylin/source/datagen/ColumnGenerator.java
1
81.08%

Totals

Change from base Build 3180:
0.02%

Covered Lines:
14267

Relevant Lines:
59660

💛  - Coveralls

LGTM


chore(api): Upgrade api to python 3.7

overview
For API v2 and fastapi we'd like to use features that are only in py 3.7. Specifically typing.Generics for use with pydantic. See here.
Argument can be made that we shouldn't do this now. We are going to be splitting up the API into two parts:

the application: ie the http server (which will need py3.7)
a library: hardware interaction, protocol api, everything else (which can remain in py3.6)

For some reason pytest is not exiting under python3.7. It's because the SynchronousAdapter threads are not terminating. Why it works on python3.6 is baffling to me.
If I call join on the SynchronousAdapter instances then pytest finishes and all tests pass, but getting access to these instances requires some pretty deep hackery.

I think this is probably fine, as far as Support is concerned. We just prefer that opentrons_simulate is usable without undue friction.
Requiring Python 3.7 will mean that you can't pip3 install opentrons on Ubuntu 18.04 LTS anymore.
But:

Older Ubuntus didn't even support Python 3.6, so this won't break those any more than they already were.
Anaconda uses Python 3.7 by default, so no problems there.


chore: switch license to MIT

After discussing with multiple individuals, it has come to my attention that the previous license used for this project may not have been a valid open-source license.
I am considering switching to MIT, but I am open to further discussion on this topic.
I will keep this pull request open for a few days to allow for input and discussion. If nobody convinces me to select another license, I will proceed with merging this update.

Great stuff! I was reviewing the package a few weeks ago and determined it wouldn’t be possible for us to use it just because of the license, as we’d be building a Python package that could reasonably be interpreted as an "email product".

Actually mjml-python is a good implementation but doesn't implement all the mechanisms for mj-includes. If you need that feature, I also build and maintain a python library of mrml.
https://pypi.org/project/mrml/

Oh, my bad, I didn't see your latest update 😊


Severity and categories filter

Moved back the configuration steps business logic into their own component
Added support for severity and source types in the fetch event requests
Created components for severity options and a source type list
Created a constants file

https://github.com/user-attachments/assets/9663b095-259e-492e-afed-0a0d46e6e56b

What happens when I select all event types? What will be passed to Flare's API? Is there a tests that check for this?

@aviau If you select every event types or every severities, no filter will be passed in the request; the filter will be deleted from our stored passwords


Prl 2490 summary and error checks

Created PR for a tech review
JIRA link (if applicable)
Changes for PRL-2489 and PRL-2490
Change description
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ X] No

Closing this PR Changes are moved into different one and merged to Release-3-1


Change MimeType to an interface to avoid issues. Fixes #5

Minimal change following the current definitely detailed google-apps-script implementation.

Thank you. Do you mind linking to the relevant lines in the other repo where you found this or the original commit/PR where this was added?

Sorry just haven't had a moment to review. Will try to get to it soon!


Fix logic for determining whether to simplify keyof on mapped types

Fixes #44019.

Some background on the change in this PR...
For a type keyof { [K in X as Y]: ... } we want to determine if it is correct to simplify to an instantiation of Y with X substituted for K. Let's say X is a union type 'a' | 'b' | 'c'. Without simplification, the keyof operation becomes a union of three instantiations of Y with 'a', 'b', and 'c' respectively substituted for K. We want to determine if it is correct to simplify to a single instantiation of Y with 'a' | 'b' | 'c' substituted for K, which it will be when Y distributes over union types in K. A complication is that we can't always inspect every constituent of Y because it might be circular or infinitely expanding. So, for some types we can't easily provide an answer. However, unless we can prove otherwise, it is reasonable to assume that Y depends on K in some way, or else the entire construct is just a needlessly complicated way of writing just Y.
With that in mind, the best approach is to not simplify unless we can definitely prove a type to be distributive. Originally the code was doing it the other way around (assuming distributive and attempting to prove otherwise), but that meant we'd get it wrong in cases where the analysis was incomplete.

@markw65 Thanks for the latest tests which should now work as expected.
WRT why we do this transformation in the first place, the short answer is: In order to ensure types that are expected to be compatible actually are compatible. For example
type T1<T> = keyof T & string;
type T2<T> = keyof { [P in keyof T as P & string]: number };

You'd expect these two types to be compatible since they'll always have the same sets of properties, but they wouldn't be without the simplification.

You'd expect these two types to be compatible since they'll always have the same sets of properties, but they wouldn't be without the simplification.

@ahejlsberg Sorry, would you mind clarifying that? Maybe with an example, or an explanation of what I'm doing wrong here:
type T1<T> = (keyof T) & string;
type T2<T> = keyof { [P in keyof T as P & string]: number };
//type T2<T> = keyof { [P in keyof T as [P] extends [P] ? P & string : never]: number };

interface M {
    a: number;
    b: number;
    [42]: number;
}

function f1(x: T1<M> extends T2<M> ? boolean : never) {
    return x;
}
function f2(x: T2<M> extends T1<M> ? boolean : never) {
    return x;
}
function f3(x: T1<M> extends T2<M> ? (T2<M> extends T1<M> ? boolean : never) : never) {
    return x;
}
f1(false);
f2(false);
f3(false);

In the above code, f1 and f2 both take boolean arguments, which seems to indicate that (as you said) T1 and T2 produce compatible types (each extends the other). But if I try to combine the tests, in f3 it doesn't take boolean (it also doesn't tell me what it does take).
If I change the definition of T2 so that the transformation doesn't happen, I get exactly the same behavior (ie, I believe, based on f1 and f2, that the types are still compatible; but something odd happens in the f3 case).

@markw65 It works because T1<M> and T2<M> both resolve to the union type 'a' | 'b' in your example, so by the time we relate the types they're actually the same type. However, things don't work out if M is generic because the types are then preserved in their higher order form. So, adding to your example:
function foo1(x: T1<M>, y: T2<M>) {
    x = y;  // Ok
    y = x;  // Ok
}

function foo2<M>(x: T1<M>, y: T2<M>) {
    x = y;  // Error in non-simplified case
    y = x;  // Error in non-simplified case
}

@ahejlsberg Thanks. That makes sense. But in that case, it seems like its not really ok to be conservative about when to do the transformation? eg right now it would reject
type NotTransformed<T, U, V, W> = keyof { [K in keyof T as U extends V ? (K extends W ? K : never) : K]: T[K] };

even though it is distributive wrt K.
Can you explain what's going on with f3's parameter type? We know that T1<M> extends T2<M> and that T2<M> extends T1<M>, so the nested conditional should evaluate to boolean, but it doesn't seem to. Is that a bug?  The really weird thing is that if I change it to T1<M> extends T2<M> ? (T2<M> extends T1<M> ? true : false) : 42, then f3 doesn't accept true, false or 42 as its parameter:
foo.ts:32:4 - error TS2345: Argument of type 'boolean' is not assignable to parameter of type '"a" | "b" extends T1<M> ? true : false'.


[BUG] Dock Indicators

Information:

Device: 11 Pro
*iOS: 13.6.1
*Tweak: Dock Indicators
Package Version:

Describe the bug:
Sometimes, the indicator for messages stays on even though no messages..
Respring to clear.
To Reproduce:
It IS a conflict with;
Karios 3 by CPDD
sileo://package/com.cpdigitaldarkroom.kairos3.debug
Expected behavior:
Indicator to switch off when no new messages
Screenshots:
https://imgur.com/a/nS6Uqx9
Additional context
Add any other context about the problem here. If the issue is causing a crash, please attach the crash report in either a file or Pastebin paste.

Should be fixed with v1.0.6

I tested, the issue was still persistent..
I narrowed it down to a conflict with:
sileo://package/com.cpdigitaldarkroom.kairos3.debug
I hope you don’t mind talking with Carlos and working out who should fix?
Thanks champ! Let me know if you need me to do anything! I get on okay with CPDD, probably the designer I would base myself on if I was still in the industry
Sorry, I thought you’d act on me replying to your email...

I guess I have to open a new issue for you to act on this information?
I don‘t care, be silly..

Is not closed issue

~Should be fixed with v1.0.6~. Don't have access to Kairos 3 to fix.

Please email<EMAIL_ADDRESS>

~Should be fixed with v1.0.6~. Don't have access to Kairos 3 to fix.

Please email<EMAIL_ADDRESS>
I contacted CP... Hopefully he will contact you to help fix this tiny issue..


Fix crash when formatting svelte files that have "let:class".

Hi there, I encountered a crash when running the plugin on a svelte file that has a slot component like this:
  <p
    slot="test"
    let:class={className}
    class="h-full w-full p-2 backdrop-blur-0 {className}"
  />

Below was the error message and I've got a repro here:

I found that the plugin was trying to read the "value" attribute from the let directive, which is always undefined. So to avoid this, I added a check to make sure that the sorting only runs on the class attributes, not on a directive named class such as let:class={className}.

Thank you!


chore: feature flag for alloy

No JIRA ticket.
URL for testing:

https://main--express-website--adobe.hlx.page/express/feature/video/reverse?martech=alloy-qa

Test URLs:

Before: https://main--express-website--adobe.hlx.page/express/feature/video/reverse
After: https://main--express-website--adobe.hlx.page/express/feature/video/reverse?martech=alloy-qa

@bbythewa can you add the Helix bot to your fork, so we can see the "after" state in action (and the PSI check is able to run)?

The code seems good, but I'm wondering if it wouldn't be possible to check for use of alloy within the set function, and serve the non-alloy event as a 4th param within the function, in order to avoid doubling the file size.

@williambsm, Can you quickly review.  I have made the changes you suggested.  It should be ready to go.


[Suggestion] Improve log

Could we add a log level for the server? For now, we can't filter out the debug level. The debug level shouldn't occur in normal users ENV.
Could we add https://github.com/kikito/inspect.lua and set up the default depth to 2 (math.huge is terrible for the AST)? I think it's useful for a terminal contributor like me.

require 'inspect' (XX, {depth = 2})


Support for numpy

Hi! Any plan to support numpy.ndarrays?
Will you accept a PR?
Thanks!

Hi!
I'm working on [https://github.com/xl0/lovely-jax][Lovely JAX], which is almost NumPy, so it's not a problem to add a lovely-np as well.
My concern with NumPy is, what kind of summary and visualizations do we show?
PyTorch and to a large extent JAX are used for NNs, so I have a rough idea of what should go into the summary. But I'm not sure how people use NumPy, and what would make sense for them.
Do you use NumPy a lot? What's the use case, and what kind of summary would make sense for you?
I can also add lovely-np that mimics lovely-tensors, and see if people will come up with better ways to summarize ndarrays.

Thanks, excellent answer!
In fact, I'm using numpy for ML applications too. Many times there are manipulations that are performed on the arrays before I transform them into tensors, simply because the ecosystem has some libraries/features that are built around numpy (e.g. python-opencv, Pillow, etc.). It is simply how things are.
Anyway, I have to admit that above all, the feature I loved most about lovely-tensors is its most basic form of summary: printing the very basic stats like range, mean, std. And those are relevant IMO no matter what purpose your arrays have.
Of course, more sophisticated visualizations can be available too as it's up to the user to decide to use them.
By the way, why do you separate those packages? Wouldn't it be nicer to have support for all types in one package?
Anyway thanks so much for your work.

Cool, I'll do the same summary then.
I'm not 100% sure which approach would be better - split or keep together. In the end, I can't share that much code between PyTorch and JAX, and I'd rather avoid building an abstraction layer, and I'd have to pick the backend dynamically and detect module availability dynamically because I can't have dependencies on both.
I feel this library would be better off being as simple as possible - If there is some weird bug that you can't explain, lovely-tensors would probably be the first suspect because it sits between you and your data. It's code that I expect to be looked at, and it might already be a bit on the harder side with the proxy classes.
Now, NumPy and JAX are quite similar (except arrays are immutable in JAX, and some of the array indexing does not work) and have a smooth interface, so it probably makes sense to handle them together. I'll see what feels more natural. Maybe it makes sense to re-write much of lovely-tensors in NumPy, and have the other libraries as thin wrappers on top.

It sounds very reasonable to me. Please let me know if I can be of help! And good luck with this awesome effort 💪 . It is already one of my favorite libraries.

Hi! Excellent timing, I just pushed the first bits of lovely-numpy:  https://github.com/xl0/lovely-numpy :)
Are you familiar with nbdev?

The last problem I had - NumPy's main class np.ndarray is written in C, and you can't monkey-patch it the way I do with torch.Tensor.
I think this is the solution: https://stackoverflow.com/questions/53313496/a-more-compact-repr-for-my-numpy-array
But it's getting late where I am, and it's near bedtime. Would you like to give it a try?
For nbdev and why it's awesome: https://www.youtube.com/watch?v=67FdzLSt4a .

It is already one of my favorite libraries.

:heart:

Sure I'll definitely try! I know nbdev but it is my first time actually using it.

OK done. Please see PR.

Thank you! It looks good; I'll try and merge it this afternoon!
I have the image-related stuff mostly ported to NumPy, but I have not touched .plt yet. Would you like to give it a go?
The architecture I have in mind: A plot( ) that accepts a NumPy array for the data and a string for the caption. Then the platform-specific part would be a thin wrapper that gets the data summary string (which has platform-specific bits), converts the data to NumPy, and passes both to the generic plot. But that's just my thoughts.

Where do you have it? I didn't see image related code in the repo. Anyway I'd really love implementing those too, but take into account that I'll be available only on Sunday, unfortunately.
And also, I'm not sure I fully understand what you've just described. Wanna give some example?
Lastly we can move the discussion to a dedicated issue in the numpy repo itself, will make more sense to future readers.
Thanks!

And just to make sure: we won't be able to use the nicer .plt, only an explicit function call. For the same reason we couldn't really patch the __repr__

Sent you an email.

And thank you for the PR, it's been merged. :)
:+1:

https://github.com/xl0/lovely-numpy


Reactivate pssessionconfiguration tests

This is for debugging the tests in AppVeyor.
It is not yet ready for review or merge.

@mirichmo @SteveL-MSFT  Is the PR live?

Nope. I'll close it.


Add collaborators to this repo

Comment below to be added as a collaborator
We will all be using this repository today. Even though it's public right now, you will not be able to make changes until you're given the correct permissions. We've automated this process via the GitHub API. Once you comment, we will add you as a collaborator.
You'll start to receive a lot of emails. (❗) You can slow these down immediately by clicking the Unwatch button at the top of the page and selecting either the Participating and @mentions or Ignore option.

comment in here

How's the weather?

Anything you want.

Yo

Read me

hi

Greetings

I'm in

Hello

I'm in

I am in

Greetings

Nice to see you here Michael!

Here

How can you say you know where I'm at, when you haven't been where I've been?  Understand where I'm coming from?

Recomment with eaton creds


Customize UI Elements for WebXR / Scene-Viewer / Quick-look

Hello,
this is a great project. I'm using it for my platform.
Is possible to add custom buttons/links element when entering in AR Mode? ( for example, i want to add a  button that add to cart something )

Thank you! Using Chrome beta, any child elements you add to model-viewer will show up in webXR. We're planning to flesh this out a bit for the next release. As for the native apps, you can read about our thoughts here.

Hello,
I have a same question about  UI (Annotation/Hotspots). I know that Annotation works only with WebXR. Is it possible to insert UI elements in Quick look to?
Thank you!

@Dovatech You'll have to look at QuickLook's documentation. The only thing we pass them is ios-src, so it has to be configured there somehow, probably with URL parameters.

@elalish , thank you !)


Provide a trace entry to indicate clobber happened

Allow the option of TRACE_Put automatically writing a special value to indicate an overwrite happened.

In non-overwrite mode, if the buffer is full, overwrite the last entry with the special value.
In overwrite mode, write the special value, then write the new value.  For macros that write two entries, this might require the addition of a TRACE_Put2 so that the two entries from the macro (e.g. TRACE_VariableValue or TRACE_SFRValue) don't get separated.

Rather than add the complication of trying to detect overflow when writing to the buffer, it would be much easier to detect when reading from the buffer.  Before the while(!TRACE_IsEmpty()) loop, there can be an if(TRACE_IsFull()) conditional that spits out the special value.  The special value wouldn't mean necessarily that a clobber happened but that it very likely did.


Az950 new default claim

Change the default claim to version 2.

I think we should make the new_ring_claim code call into riak_core_claim for customers that have set their config to use the new claim stuff.

This PR has been made obsolete by https://github.com/basho/riak_core/pull/126


sql projects output path doesn't handle variables

When determining where the generated dacpac is for publishing, the "OutputPath" property in the .sqlproj is used to determine this location if is specified.
If an output path has a variable, like <OutputPath>out/$(Configuration)</OutputPath> this is not currently handled. The xml parsing code is already pretty messy in the sql projects extension, so this is currently on hold while deciding if the parsing logic will move somewhere else.

consider adding support for this after the project xml parsing code move to DacFx is done, if there's interest


Added VAT validation for Switzerland.

Hey guys, I am using your small library and find it really simple and useful. I ran into problem with swiss VAT though. I hope you don't mind the pull request.
Regards,
Luka

Also I just noticed this is your first PR on github, congrats and thanks for making it this project! 🎉

@lukapopovic I can see a new commit with some updates, they look great thanks for adding in those additional ones! Are you finished making your changes? If so I'll give them a test locally and then I'll merge and deploy!

Hey there, I've run the tests locally and it seems you've captured all the VAT code spec so I'm going to get this merged and deployed now. Thanks for your contribution and congrats on having your first pull request merged! :tada:

This has been released under 1.1.0 (https://github.com/BlueHatbRit/vatcode-validator/releases/tag/1.1.0) and can now be pulled from npm.

Great Job @BlueHatbRit. Thank you so much! Cheers


Explore external interfaces

Description
Explore all external interfaces of the agent. This is an important initial step of finding out all available information that have to be connected via the config file.
Outcome
Full understanding and documentation of:

[x] OPA interfaces
[x] Usage discovery of OPA's interface in existing projects
[x] Incoming user request structure (Http...)
[x] Connection to datastores

@dcseifert Approved


Compatibility issue with "packaging" >= v23

What happened?
Hello.
During installation of the widely-used rpaframework package, a compatibility issue is raised between Robocop and "packaging" >= v23 (Robocop is stated compatible for v21 <= "packaging" < v23 while v23 is installed by rpaframework)
Would it be possible to release a Robocop version that is compatible also with "packaging" >= v23 or at least provide a workaround?
Thanks for your support.
Operating System
Windows
Robocop version
2.8.1

It's fixed and will be released as a part of Robocop 2.9.0.


Update Caesar's page

Update bio
Update CV

@leewujung @valentina-s I don't have merge permissions. Could one of you merge this for me?


Test cupertino text field

As a part of #134 this PR includes coverage for cupertino/text_field_test and some straightforward fixes for detected leaks in the tests.
This PR doesn't cover all tests in the file, as some tests fail, as marked in the example of Can double tap + drag to select word by word. (refer to #135803)
Pre-launch Checklist

[X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[X] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[X] I signed the [CLA].
[X] I listed at least one issue that this PR fixes in the description above.
[X] I updated/added relevant documentation (doc comments with ///).
[X] I added new tests to check the change I am making, or this PR is [test-exempt].
[X] All existing and new tests are passing.

@polina-c, could you please take a look at this PR?


Remove boostcpp.py (to match master)

Removed to keep differences between master and develop to minimum to aid diffs.
I've created a branch feature/boostcpp-py that still has it, in case it needs to be revived, which seems unlikely.

AMDG
I agree with this change.  You don't even need
a feature branch, as boostcpp.py was only partially
ported and is so out-dated that it would be
easier to port from scratch.
In Christ,
Steven Watanabe


Driver options are not passed through correctly

Reported by @Twitch0125 here: #7
I opened an issue in nuxt/framework here: https://github.com/nuxt/framework/issues/8419 to see if this is a bug or feature. If its a bug we may not need to fix it here but rather wait for an upstream fix in nuxt.

So, in https://github.com/nuxt/framework/issues/8419 it was confirmed that runtime config is de-/serialized -> I added this to the official nuxt docs via a PR.


.NET Core Single EXE extraction folder logic not documented

Issue Title
The extraction logic for .NET core single-exe file doesn't seem to be documented and makes troubleshooting difficult. While I understand the codebase is open source, it is huge and it would be nice to have this documented as I am facing issues where users cannot boot the app due to what appears to be bugs in the single-exe extraction process.
General
I have been troubleshooting issues with a few of the users where my apps will no longer boot after a new version of the application has been extracted and the only solution is to wipe the temp folder where the actual app .dll is stored. Looking at the event logs, when the user clicks on my single-exe, it will extract to a folder in %localappdata%\temp\.net<name>. It will then call and run that local .net core 'installation' and run the dll located there.
My app updates by downloading a new exe, running it in the background (no ui starts), which extracts. It then reboots to a temporary swap file which moves the new exe (that just exited after extracting itself) back to the original exe's place. This makes it appear like there was a quick swap rather than a long swap (first boot takes like 15s while it extracts. A splash screen would be a nice feature for this long extraction) while it extracts the entire exe into place. I'm not sure if this is appropriate as I do not understand the logic behind the extraction code, it seems generates a random folder but I am not sure if it's actual random.
An example error message my users have seen from event viewer:
Description: A .NET Core application failed.

Application: ME3TweaksModManager.exe
Path: E:\Dokumenty\Mass Effect 3\ME3TweaksModManager\ME3TweaksModManager.exe
Message: The application to execute does not exist: 'C:\Users\piotr\AppData\Local\Temp\.net\ME3TweaksModManager\0x4rkytj.h1w\ME3TweaksModManager.dll'

This doesn't appear to have to do with my code, rather it has to do with the .net core wrapper for single exe. My exe's are not trimmed (as it breaks the app horrendously and I only save a couple of MB). This only affects a few users.
The last one I helped said that once they put the downloaded file as the same location as the original exe - aka, they had 2 copies at once point, and the 2nd one could not boot - it would work. Which is why I am asking, why is this error occurring? What is determining the foldername in appdata?

@jeffschwMSFT

@swaroop-sridhar