Add FFT and polynomial evaluation/interpolation docs to the project book

Add FFT and polynomial evaluation/interpolation docs to the project book
Description
This PR introduces various sections to the mdbook explaining theoretical and practical details of the FFT library and its application in polynomial evaluation and interpolation.
Type of change

[ ] Documentation

Codecov Report

Merging #234 (233f651) into main (9e5baec) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 233f651 differs from pull request most recent head ddc26aa. Consider uploading reports for the commit ddc26aa to get more accurate results

@@           Coverage Diff           @@
##             main     #234   +/-   ##
=======================================
  Coverage   96.34%   96.34%
=======================================
  Files          93       93
  Lines       11644    11644
=======================================
  Hits        11218    11218
  Misses        426      426

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Inactive


No Endpoints found in Windows Module

Hi Experts,
I tried to bulid an IIoT data live-visulation solution based on this architecture with Azure IIoT Platform (https://github.com/Azure/Industrial-IoT) Vesion 2.7.206. I have proceesed the deployment and we can see the ressources in Azure. I have found two Assets in the engineering tool.

In Linux module we can see 3 endpoints, however no endpoints can be found in windows module.

What could be the issueand how can i fix this?

Please reopen if the directions do not address the issue.


Remove jQuery dependency from package.json

https://github.com/julianshapiro/velocity/issues/497

bumpin'

Second bump, would love to have npm not pull jquery with this repo

Bump!

Going to leave this in place till v2 simply so nothing changes for v1

@Rycochet I would love to use VelocityJS the only thing that is preventing me from using it is the jQuery dependency.
Is there certain issues we can help with to move v2 to a alpha build?

Somehow this made it in, and I never even noticed :-)


Mac: Add FileSystemType

Adds Disk information to heartbeats for Mac.
resolves #1134

Looks good to me, except.. all those whitespace changes? I cannot tell in GitHub's UI.. are they removing or adding trailing whitespace? If it's removing 😄  otherwise 😢

Thanks @mjcheetham !  The diff is line endings.  A lot of the .cs mac files seemed to have a mixture.  Saving in VS Code makes them all ^M style endings which last I checked was what we want.  So this fixes them.  I can (with some pain) not change those line endings but it will be pain again the next time the file gets updated.


Filtering a dimension on a NULL value is not working

https://github.com/rpbouman/huey/commit/59b5fc6f53a2b71128c8ac5014abb29d2b5aefca


Finished spectrum plot

Thomas,
With this I consider the spectrum plot basically finished. I would appreciate if you give it some testing, and let me know if you find any bugs or if you have any suggestions.

Great work Tomas. I will test it and let you know if I have any comments.


[Feature request] Support GROUP BY time(AUTO)

Proposal:
adjust time interval based on time window in GROUP BY clause
Current behavior:
time interval must be fixed value
Desired behavior:
Suppose the query is select value from measurementA where TIME_WINDOW group by time(AUTO), influxdb shall detect the TIME_WINDOW and smartly adjust the time interval, for example

TIME_WINDOW
AUTO

<= 6 hours
1m

<= 12 hours
5m

<= 24 hours
10m

<= 3 days
30m

<= 7 days
1h

<= 30 days
1d

Use case:
This feature will be helpful when working with visualization tool such as Grafana.

This seems similar to #7198.


Add Lexington, Kentucky.

Feature request
Want to add a new feature to the site? Please describe the requested feature and provide any relevant information:
Add Lexington, Kentucky to the list.

DUE TO HIGH VOLUME EMPTY ISSUES, OR ISSUES MISSING THE FOLLOWING INFORMATION WILL BE IMMEDIATELY CLOSED. THANK YOU!

A subject message for the email
A list of emails (at least one) for the government officials you’d like to receive the message
A detailed message concerning the budgeting decisions that are at stake in your community

Please read more about our email style guidelines here.
If this information is copied from an external source please provide a link to the original source.
See our current links for examples at https://defund12.org.
Thank you!!


When authenticating, a token valid for 2 hours must be generated

PR approval required https://github.com/fredsonchaves07/movie-catch-api/pull/181 and https://github.com/fredsonchaves07/movie-catch-api/pull/182

This question will not be integrated as an authentication rule as there is already logic and specific validation for all tokens that are generated


Create a /donate URL that is based on the pledge page

URL: support.minnpost.com/donate/?opportunity=
Page headline: MinnPost Donation
And text: Thank you for supporting MinnPost’s nonprofit newsroom. If you have any questions, please email Tanner Curl at<EMAIL_ADDRESS>It also needs to update the CloseDate to today.
The page is the same as pledge aside from that. We might as well update the pledge form so that it also updates the CloseDate to today.

Done in f16d746cb6dca3b6ae3e85c9ab54328ad49ea104 through cc8108a03c7ebc0529e4bb6eb61f7a2db3de119f


Complete and review the "implementation decisions" configuration file

Provide details on the implementation decisions to align both RTL and Reference Model. This is needed in order to do proper step-by-step comparisons

Currently both the RTL and the reference model are aligned in:
cv32e20-dv: master
core-v-verif: 628ba12664c19f3657661c07d3dab8d949dd21c2


Update PowerToysBacklog.md

Summary of the Pull Request
Spelling.

References

PR Checklist

[ ] Closes #xxx
[ ] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Thanks!


[DRG] Fix power surge checklist description

Checklist description for Power Surge now correctly identifies Sonic Thrust as the aoe action that grants the buff.

whoops this touches the same file as #1733 so i'll fix it in that PR instead


Clarifications to example table; doc with info about reward adjustment for Hotspots based on Mappers Input

Actually, tokens emitted every 24 hours are 60B/365 not 5B/30
So 164,383,561 not 166,666,667
And 32,876,712 not 33,333,333
Rewrad Points Earned by All Mappers <<< spelling mistake = Rewards
Im not sure on values MOBILE distribution calcs for the following:
MOBILE Earned per Discovery Mapper
MOBILE Earned per Verification Mapper

@meowshka, do you see the comments above? Do you need to make any corrections because of that comment?

@meowshka can you review the comments on this before I merge?

@vincenzospaghetti all changes look good and file is now accessible to everyone with the link.


Bind press keyboard event on search input box

Bind enter press event on search input box

Codecov Report

Merging #183 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             develop   #183   +/-   ##
========================================
  Coverage        0.4%   0.4%
  Complexity         7      7
========================================
  Files            102    102
  Lines           4658   4658
  Branches         798    798
========================================
  Hits              19     19
  Misses          4638   4638
  Partials           1      1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7241d07...8fba915. Read the comment docs.


Planning Milestone v0.2

This GitHub Issue is to be used for planning OSM Health release v0.2
Please comment with recommendations on GitHub Issues or general areas that we should bundle with the OSM Health v0.2 release.

[ ] #117
[ ] #116
[ ] #115
[ ] #109
[ ] #107

Yeah I've got 2 PRs (that I need to rebase) that fixes 2 of these @draychev


Updated the configuration in order to be aligned with the docs.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Solana-labs/Goverance-ui_The_Accrew_DAO_Info_Update

What do you think about the updates to The Accrew DAO?
"symbol": "ACRW",
"displayName": "The Accrew DAO",
"programId": "GovER5Lthms3bLBqWub97yVrMmEogzX7xNjdXpPPCVZw",
"realmId": "3rrQ9NjxiNExfaoCuvDEabww6ViYzYeNXgu9tufvCoQR",
"website": "https://www.accrewmoney.com/",
"keywords": "Accrew DAO, The Accrew DAO, Accrew, Member-Owned Mobile Bank, Fintech, ACRW,
   Mobile App, crypto",
"twitter": "@AccrewApp",
"ogImage": "/realms/Accrew DAO Governance UI/Accrew Graphic Only Gradient.png"

What do you think about the updates to The Accrew DAO?

Looks good, makes sure there are no formatting errors and project builds

Thanks! I don’t see the changes made to today.realms yet, will it take a day or two to propagate?
Thanks!
AJ
--
AJ Montgomery
Accrew
269-352-1642
@.> @.
https://calendly.com/ajmontgomery Schedule a virtual meeting
This electronic message contains information from Accrew.  The contents may be privileged and confidential, and they are intended for the use of the intended addressee(s) only.  If you are not an intended addressee, please note that any disclosure, copying, distribution, or use of the contents of this message is prohibited.
From: Sebastian Bor @.>
Sent: Monday, October 3, 2022 6:18 AM
To: solana-labs/governance-ui @.>
Cc: AJ Montgomery @.>; Mention @.>
Subject: Re: [solana-labs/governance-ui] Solana-labs/Goverance-ui_The_Accrew_DAO_Info_Update (PR #1071)
What do you think about the updates to The Accrew DAO?
Looks good, makes sure there are no formatting errors and project builds
—
Reply to this email directly, view it on GitHub https://github.com/solana-labs/governance-ui/pull/1071#issuecomment-1265291861 , or unsubscribe https://github.com/notifications/unsubscribe-auth/A2LTGGJBVXQGNULUJAFYDU3WBK6GZANCNFSM6AAAAAAQZGYWUY .
You are receiving this because you were mentioned.  https://github.com/notifications/beacon/A2LTGGMA35YOMN2GOH5C5DDWBK6GZA5CNFSM6AAAAAAQZGYWU2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSLNLJFK.gif Message ID: @.*** @.***> >


bazel(python): no py_(proto | grpc)_library targets to depend on when dependency has a GAPIC

When a proto depends on a proto in another package, there is a chance that the python target dependencies of the dependent target will be generated with the wrong dependency targets when the dependency is a GAPIC. This is because when a package is a GAPIC, the only python targets generated are the py_gapic_library and py_gapic_assembly_pkg targets - there are no py_proto_library or py_grpc_library targets generated. However, a dependent package is generated with py_proto_library and py_grpc_library targets as the dependencies. It really should be depending on the py_gapic_assembly_pkg target instead, which contains not only GAPIC code but also the protobuf & grpc code.
I think a good solution would be for the non-GAPIC packages to be genreated with a py_gapic_assembly_pkg target with just the grpc & protobuf targets as the packaged sources. This way, we can change build_gen to always generate a dependency on this single target rather than having to determine which targets a dependency has to use.

@software-dov, can you please triage this?
@vam-google (for vis).

Note: This impacts only APIs with cross package dependencies and there are very few APIs that fall into this category. Still this needs to be fixed. Perhaps this could be part of the bazel robustification work.
@viacheslav-rostovtsev (for vis)

Downgrading to P3 as there aren't any urgent cases and this may not be feasible to do with existing infrastructure.


ecflow installation on Narwhal is without UI

Describe the bug
Not a big issue, because we don't run ecflow UI on Narwhal. I noticed that ecflow is built w/o the UI even though qt is defined in the site's packages.yaml file
To Reproduce
Install ecflow using PR #1257 and look at ecflow module.
Expected behavior
ecflow is built with UI
System:
Narwhal - spack-stack dev as of 2024/08/23 - PR #1257
Additional context
Presumably the qt5 installation is incomplete

This was fixed in #1257


docs: add badges

Codecov Report

Merging #14 (220e84f) into master (48a2a7e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #14   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            5         5
  Lines          113       113
  Branches        20        20
=========================================
  Hits           113       113

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Suggestion: Change Username in the Default Config

Hey, thanks for the Application. As someone who builded something lightly simular i really appreciate your effort.
But as i first started to use your Application, i was slightly confused about the "welcome" in the Username Box as i started to set it up. Going though your Source Code i realized you're generating it in the default-Config because you're using it to check if authorization is enabled or not.
But i would suguess changing it to admin rather than welcome and add two labels to the corresponding textboxes. If you would be happy with that, i would be glad to make the changes and add a pull-request.

Sounds like a good idea. Please make a PR and I will merge. Thanks for the help!

Sounds like a good idea. Please make a PR and I will merge. Thanks for the help!

Changed to admin in 1.0.12


[Workflow] Automated Greetings and Label assignment Workflow

Problem
Sometimes a large number of issues and features may be added by open-source contributors and users. This may lead to the admins being overwhelmed to add labels, allocate and handle all of the issues raised. The solution focuses on automating some part of these process so that admins can focus only on the important that need their attention.
Proposed changes
I propose to create a GitHub workflow named "Greetings". This workflow will automatically greet users who create new issues or pull requests in this repository. The Greeting will look like "Hi there! Thanks for opening this issue. We appreciate your contribution to this open-source project. We aim to respond or assign your issue as soon as possible."
There will be another GitHub workflow named Auto-Label which would scan the title of the raised issue and assign appropriate labels. Specific labels or other requirements suggested by the admins can be integrated in this.
I wish to contribute this through GSSoC-ext and Hacktoberfest

No , thanks
This will really create much chaos than helping
Might assign a level3 to level1 issue

This project focuses on low level issues which require extensive insight. Due to this issue being nonsubstantive we are closing this at the moment.

The PA / mentors of this repo are fairly active while maintaining this repo.
Automation is going to be a headache if a single mistake happens.

Taking the words of @techy4shri into consideration, closing it.


Is it possible to make custom 2d probability density function?

I want to make custom 2d probability density function(e.g. gamma-vonmises distribution).
scipy.stats.rv_continuous seems to support 1d pdf.
Is there any alternative to make 2d pdf?
Thank you in advance.
class 1d_pdf(stats.rv_continuous):
# a, b, c is the hyper-parameters of this distribution
    def _pdf(self, x, a, b, c):
        return mypdf
    def _argcheck(self, a, b, c):
        return argcheck
1d_pdf = 1d_pdf(name="1d_pdf")

pdf = 1d_pdf(a=1, b=1, c=1) # no error

However, custom 2d pdf will raise error.
# a, b, c is the hyper-parameters of this distribution
class 2d_pdf(stats.rv_continuous):
    def _pdf(self, x, y, a, b, c):
        return mypdf
    def _argcheck(self, a, b, c):
        return argcheck
2d_pdf = 2d_pdf(name="2d_pdf")

pdf = 2d_pdf(a=1, b=1, c=1)

returns,
_parse_args() missing 1 required positional argument: 'y'

↑Maybe y is recognized as hyper parameter.

stats.distributions framework only supports univariate distributions. Multivariate distributions you'll need to code yourself, similar to https://github.com/scipy/scipy/blob/master/scipy/stats/_multivariate.py


Leave impact slider blank on creation of changepoints

We want annotators to actually select an impact value rather than preloading one for them.

I am not entirely sure this can be done with an empty value on load.
I also feel like forcing a jiggle is bad UX.
Requiring a comment or minimum comment length makes sense. (which is already in a PR)
But requiring a slider to be moved once to register feels a bit wrong.
I'll work on other tasks and circle back to this.


Small screen print bug in GC-MS with xcms tutorial

Hi
When opened in Galaxy the GC-MS with xcms tutorial show some code (for sure just a matter of , or . somewhere, but I'm not able to correct it on my own.)  Screenshot from Chrome, server usegalaxy.fr

@hechth @melpetera any clue?
Best
Yann

ah this can be due to spacing, adding a newline around the snippets should fix it

This snippet use to work just fine, we did no change in the tutorial since then.
@hexylena adding newlines does not help

we did no change in the tutorial since then.

Yes, but we (the GTN) have made changes over time that can cause this. I guess I will look into it, thank you for testing the newlines.

Actually it works just fine after the changes you did here https://github.com/galaxyproject/training-material/commit/d44643e11e471f33e099f3af36373bc96cbd49f6.

@yguitton can you check if the problem disappeared?

https://training.galaxyproject.org/training-material/topics/metabolomics/tutorials/gc_ms_with_xcms/tutorial.html#hands-on-data-exploration looks fixed to me


chore: apply fixes for jest + ESM, prettier sync

I believe this fixes everything, at least the tests are all green, linting and build script also work fine.
Was also 1 missing file in prerelease.2 so I released prerelease.3 with hotfix and bumped it here.
Jest's (and ts-jest by extension) ESM support is not out of the box and comes with a bit of configuring but I managed to get it working for you, also fixed a few very minor details.
Note that it's probably a good idea to export ESM files as well, I put a second commit so it's dual publishing ESM + CJS (although I recommend phasing out CJS eventually, or maybe immediately to save yourself the hassle of dualpublishing)
Let me know if you have any questions and feel free to reach out to me on Tokens Studio Slack

Thank you very much @jorenbroekema for providing those great fixes. 🙏


Papyrus to Umple & Umple to Papyrus functionalities through Umple Eclipse plugin

Pull request title
Papyrus to Umple & Umple to Papyrus functionalities through Umple Eclipse plugin
Pull request description
This pr introduces two buttons to the Umple plugin in Eclipse

Generate Papyrus Project: allowing end users to generate a Papyrus project against a ".ump" file
Papyrus to Umple: allowing end users to generate an ".ump" file against the ".uml" file owned by a Papyrus project

Pull request content
Below is a brief summary of content changes in this pr and associated reason:

cruise.umple/src/UmpleImport_CodeHandlers.ump
briefly modified the Papyrus importer, so it's able to read and process old Papyrus xml files properly

org.cruise.umple.eclipse.plugin/plugin.xml
UI and default handler is introduced for "Generate Papyrus Project" and "Papyrus to Umple" buttons

org.cruise.umple.eclipse.plugin/src/commands/GeneratePapyrus.java
handler code for "Generate Papyrus Project" button, which means the code being invoked when "Generate Papyrus Project" is clicked

org.cruise.umple.eclipse.plugin/src/commands/GenerateUmple.java
handler code for "Papyrus to Umple" button, which means the code being invoked when "Papyrus to Umple" is clicked

org.cruise.umple.eclipse.plugin/src/commands/UmpleSuperHandler.java
detailed logic for generating an ".ump" file when "Papyrus to Umple" button is clicked

This pr is for issue #87


Remove Google analytics

The Google Analytics code is mixed in with the Cookie Control code which you're working on next I see - make sure you remove the Site.ga_property_id method as well when you remove the _cookie_control.html.erb partial.

The Google Analytics code is mixed in with the Cookie Control code which you're working on next I see - make sure you remove the Site.ga_property_id method as well when you remove the _cookie_control.html.erb partial.


Add GCC support for sanitisation flags.

In a recent PR by @Nihlus (that I lazily merged after seeing someone else say LGTM), a set of  sanitisation flags were added that work for older versions of GCC but not for anything newer than GCC 8 as far as I know. They are also incompatible with clang. Due to my mistake (and the fact I really don't have time to test GCC extensively right now) I have amended the offending flags for clang as that's our first and foremost priority in terms of compiler support, although its not in master yet. Once it is this ticket can be worked on.
This ticket is free for anyone to pick up should they wish to do so.

I think this has been resolved by @FiniteReality 's changes. Closing.


Apps40 steps not very clear

A few questions in Apps 40:

The service principal Id and Password is get from az ad sp create-for-rbac ?ServicePrincipalID Refer to appid or name ?
After done the deployment , the container status always fail.
I can't find the Connection Information like shown in screenshot , is that we need to wait until finish deployment?
How we can navigate to Running scale demo,Network policy and Availability zones, the step not clear?

Updated on 27 November 2019.

Hello @cheahengsoon Thank you for your feedback.
May I ask you to re-create it in the APPS repository (https://github.com/microsoft/ignite-learning-paths-training-apps)
This current one is not used anymore. Thanks


cli/update-notifier: 4.1.0

Should fix https://app.snyk.io/vuln/SNYK-JS-DOTPROP-543489.

Thanks, @dargmuesli. optimize-css-assets-webpack-plugin, lerna and conventional-changelog also has a deep dependency of an older dot-prop version. conventional-changelog might be good after https://github.com/stevemao/compare-func/pull/3 has been merged. But I can't find any PR's for the two other packages (postcss-selector-parser and @lerna/project).

Ok, but this PR would fix the issue for the cli package, wouldn't it?

Yes, it will :)

🎉 thank you!


Capability document not updated?

Steps to reproduce the problem.
develop branch.

getCapabilties of a server
change server setup
getCapabilties of the same server

"view" should show the new capabilities.
Currently, it shows the first ones.

This happened with storing the "styles" we now store the whole capabilities.
The problem is that also the server datafiles changes from day to day.
We had a similiar problem in the past as we had used a server site caching, see https://github.com/Open-MSS/MSS/issues/268
For these kinds of updated data we don't have tests yet.

We need a backport of this to stable.


Renovate with system-upgrade-controller

Details
I was poking around trying to understand how you handled the K3S system-upgrade-controller with renovate.  In looking at your plan files I see a reference to channel: https://update.k3s.io/v1-release/channels/v1.24 - and I see reference to your PR  being opened.
I experimented with adding the channel to my plan file and the upgrade controller immediately upgraded to latest version in the channel without renovate even running.
I also looked at your .github/renovate directory, and nothing particular stood out as making the magic happen but I suspect I missed something in it.
I'm trying to get a PR opened for k3s upgrades by renovate.  (renovate is upgrading the upgrade-controller itself via PR, just not the K3S version)

I was afraid of that... you can sleep OK knowing the cluster can be upgraded at any random time?
It seems if you use the version instead of channel you can pin the k3s version to a specific version and control the upgrades.   But I was unable to figure out how to have renovate see that as a tag and associate that to https://github.com/k3s-io/k3s-upgrade/releases/tag tags.  Seems a renovate regexManagers should be able to handle it.

It's never broken on me ;) But I would be interested in renovate PR coming into upgrade it as well. Let me how you make out with that!

Actually, it wasn't that hard. This should work
https://github.com/onedr0p/home-ops/commit/3a9aa0413c00b023247dffffb6b1a40eeb28ce2b

So that is what I had minus the # renovate: datasource=github-releases depName=k3s-io/k3s which didn't work.  Does that comment give renovate a hint?

Yea that's picked up here
https://github.com/onedr0p/home-ops/blob/main/.github/renovate.json5#L52L63

Maybe I'm missing something else needed in your renovate config?
regexManagers section in renovate.json:
  "regexManagers": [
    {
      "description": "Update Democratic-csi docker image references",
      "fileMatch": ["^applications\\/democratic_csi_.*\\.ya?l$"],
      "matchStrings": ["image: (?<depName>.*?):(?<currentValue>.*?)\\s+"],
      "datasourceTemplate": "docker"
   },
   {
      "description": "Process various dependencies",
      "fileMatch": ["workloads/.+\\.ya?ml$"],
      "matchStrings": [
        "datasource=(?<datasource>\\S+) depName=(?<depName>\\S+)( versioning=(?<versioning>\\S+))?\n.*?\"(?<currentValue>.*)\"\n"
      ],
      "datasourceTemplate": "{{#if datasource}}{{{datasource}}}{{else}}github-releases{{/if}}",
      "versioningTemplate": "{{#if versioning}}{{{versioning}}}{{else}}semver{{/if}}"
    },
    {
      "description": "Process raw GitHub URLs",
      "fileMatch": ["workloads/.+\\.ya?ml$"],
      "matchStrings": [
        "https:\\/\\/raw.githubusercontent.com\\/(?<depName>[\\w\\d\\-_]+\\/[\\w\\d\\-_]+)\\/(?<currentValue>[\\w\\d\\.\\-_]+)\\/.*"
      ],
      "datasourceTemplate": "github-releases",
      "versioningTemplate": "semver"
    }
  ]

Directory applications\* and workloads\* are my argocd paths, equivalent of your cluster\* and flux.
workloads/upgrade-controller/k3s-control-plan.yaml:
---
apiVersion: upgrade.cattle.io/v1
kind: Plan
metadata:
  name: k3s-control-node-plan
  namespace: system-upgrade
  labels:
    k3s-upgrade: control-node
spec:
  concurrency: 1 # Batch size (roughly maps to maximum number of unschedulable nodes)
  # renovate: datasource=github-releases depName=k3s-io/k3s
  version: v1.23.5+k3s1
  # channel: https://update.k3s.io/v1-release/channels/v1.23
  nodeSelector:
    matchExpressions:
      - {key: k3s-upgrade, operator: Exists}
      - {key: k3s-upgrade, operator: NotIn, values: ["disabled", "false"]}
      - {key: k3os.io/mode, operator: DoesNotExist}
      - {key: node-role.kubernetes.io/control-plane, operator: Exists}
  serviceAccountName: system-upgrade
  cordon: true
  upgrade:
    image: rancher/k3s-upgrade

Plenty of newer version than that.....  I get nothing from renovate:
 INFO: Repository started (repository=reefland/k3s-argocd-test)
       "renovateVersion": "32.120.0"
 INFO: Dependency extraction complete (repository=reefland/k3s-argocd-test)
       "baseBranch": "main",
       "stats": {
         "managers": {
           "argocd": {"fileCount": 14, "depCount": 14},
           "github-actions": {"fileCount": 2, "depCount": 4},
           "helmv3": {"fileCount": 3, "depCount": 3},
           "kustomize": {"fileCount": 3, "depCount": 4}
         },
         "total": {"fileCount": 22, "depCount": 25}
       }
 INFO: Repository finished (repository=reefland/k3s-argocd-test)
       "durationMs": 4220

Bingo! Thanks for the assist.
 INFO: Branch created (repository=reefland/k3s-argocd-test, branch=renovate/k3s-io-k3s-1.x)
       "commitSha": "557f198607fba69c35ebf7df85da44855f565f33"
 INFO: PR created (repository=reefland/k3s-argocd-test, branch=renovate/k3s-io-k3s-1.x)
       "pr": 27,
       "prTitle": "Update dependency k3s-io/k3s to v1.24.3+k3s1"
 INFO: Repository finished (repository=reefland/k3s-argocd-test)
       "durationMs": 9808


Enhancement: Improve accessibility of login form

This PR

[x] improves the accessibility of the login form by providing identifiers for form inputs and explicitly assigning labels to inputs

Got a flaky test there, taking a look.

Flaky test is unrelated.

Thank you, @mdwheele!


Smooth graphics

Graph nodes look too crisp and not antialiased.
Literally added two lines – replaced pixi/graphics with pixi/graphics-smooth and added smoothing param to fills.
It's possible to add smoothing param to graph settings

Thanks! Merging


feat(codemod): add codemod that renames the Hydrate component usages to HydrationBoundary usages

Closes: https://github.com/TanStack/query/issues/5759

can you add documentation to the upgrade guide please?
maybe it would also be good to have one way to run all migrations for v5, with one command?

can you add documentation to the upgrade guide please?
maybe it would also be good to have one way to run all migrations for v5, with one command?

Sure, I will!


Convert ZcashNetwork to Interface

Is your feature request related to a problem? Please describe.
ZcashNetwork is currently an enum with hardcoded values.
This makes it difficult to implement certain tests (e.g. darkside) as well as supporting changes in the host/port of the server.
Describe the solution you'd like
Convert ZcashNetwork to an interface and then provide factory methods for constructing networks with the default values.
For example:
interface ZcashNetwork {
    val id: Int
    val networkName: String
    val saplingActivationHeight: BlockHeight
    val host: String
    val port: Int
}

object ZcashNetworkFactory {
    fun newTestnetNetwork(host: String = "testnet.lightwalletd.com", port: Int = 9067) = ZcashNetwork(0, "testnet", 280_000, host, port)
    fun newMainnetNetwork(host: String = "mainnet.lightwalletd.com", port: Int = 9067) = ZcashNetwork(1, "mainnet", 419_200, host, port)
}

I somewhat regret having SDK constants as an interface. I've found that Protocol Witnesses are a much more testable and flexible approach for this kind of things.
some resources:
https://www.youtube.com/watch?v=3BVkbWXcFS4
https://www.pointfree.co/collections/protocol-witnesses/alternatives-to-protocols/ep33-protocol-witnesses-part-1


Add 'View Files' and 'Updated' Date to Files Card

Update the Files card to include the 'View Files' link and 'Updated' date per designs.

The view files link was added back in #492
We don't have the updated date there, but we really don't have that data from the API either. All we have is the project's modified date. We do duplicate this date on the budget card but I don't like that because it's not the budgets date either.


Add reload command.

Add reload command to restart the client without having to restart VS Code.
Fixes #164.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: threehams sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Can we have this merge please ?
The number of times I switch branches and ESLint will throw warnings/errors on a  typescript-eslint rule is getting frustrating ..
If at least I could :

F1
Reload Typescript server
F1
Reload EsLint server
Continue working

But now I have to reload my window or restart VSCode.
The fact that this happens when I switch branch is irritating, but at least if we could get some sort of reload for ESLint, that would be great !

Would love to have this feature.

I'll publish a fork some time in the next week. I've needed this at work enough to justify spending the time on it there.

I looked into this today and this is not as easy as calling stop & start. Stop removes a lot of state from the client which makes the start not be successful in all cases. The right fix is actually to create a new client and not reuse the old instance. Need to think what needs to be done to make this successful.

client/src/extension.ts

Sebastianokunkelo:master

@threehams I delivered this for 2.1.17 in a slightly different form.


Issues with Footnotes?

I'm getting this error in the console when I try to click a footnote link. Any ideas why? I'm on the latest version (2.3.2).
head-scripts.min.js:10:51490
Error: Syntax error, unrecognized expression: [name=fn:2]  head-scripts.min.js:10:25317
	n.error https://my_domain.com/assets/js/head-scripts.min.js:10:25317
	l https://my_domain.com/assets/js/head-scripts.min.js:10:16155
	b https://my_domain.com/assets/js/head-scripts.min.js:10:18679
	n https://my_domain.com/assets/js/head-scripts.min.js:10:15012
	find https://my_domain.com/assets/js/head-scripts.min.js:10:53964
	init https://my_domain.com/assets/js/head-scripts.min.js:10:8452
	re https://my_domain.com/assets/js/head-scripts.min.js:10:7876
	<anonymous> https://my_domain.com/assets/js/foot-scripts.min.js:10:65279
	dispatch https://my_domain.com/assets/js/head-scripts.min.js:10:48722
	add/y.handle https://my_domain.com/assets/js/head-scripts.min.js:10:45524

?
Randy

From: grokdesigns @.>
Sent: Monday, April 10, 2023 6:26:48 PM
To: oswaldoacauan/ghostium @.>
Cc: Subscribed @.***>
Subject: Re: [oswaldoacauan/ghostium] Issues with Footnotes? (#173)
Closed #173https://github.com/oswaldoacauan/ghostium/issues/173 as not planned.
—
Reply to this email directly, view it on GitHubhttps://github.com/oswaldoacauan/ghostium/issues/173#event-8967655825, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARO33OD7FOIYA3U37L75HK3XASCKRANCNFSM4DUTOHBA.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


use new Jenkinsfile.github

Signed-off-by: Jacob Salmela<EMAIL_ADDRESS>

Does this only run once it's in main? Wondering if there will be linked builds to the PR.

I do think it shows here on a draft PR, but it does on normal ones.


Consider getting paths from AS 17 to AS 14, where the relevant ASes are:
11 (core)
|
14 (intermediate)
|
17 (leaf)
A host in AS 17 first builds the obvious shortcut path: 17 -> 14
It then proceeds to build full paths, including: 17 -> 14 -> 11 -> 14
When this full path is taken, er1_14-er1_17 goes ahead and delivers the packet to the destination instead of the next hop router because it sees that it is in the destination AS.
This is fine for the one packet, but the receiver in AS 14 will save the reversed full path with an incorrect first hop (should be er1_14er1_11).
So when the receiver later tries to send its own packets on this path, the packet will be dropped due to having incorrect IOF/HOF indexes.
Apparently we've been considering marking OFs as "deliverable" which will help here (@pszalach you're probably on TCP full-time for a while but any timeline for this?), and also PathCombinator should not build this full path to begin with.
This hasn't really been a problem so far because all our tests use only the first path given by sciond and receivers never create packets from scratch, only reverse incoming packets. Both of these assumptions fail for SSP which is where the problem was discovered.

This is fixed in the new path combinator.

@shitz : are you sure? i thought that was "future work"

@kormat you are right. Reopened.

Fixed by #1696.


Fixed #24880 -- Added more explicit docs on select_for_update() on SQLite.

#24880 - Be more explicit about what happens and what doesn't when using select_for_update() on backends that do not support SELECT ... FOR UPDATE.

merged in d29ed3f355b0c57e7036807f1d54f33796d8d820, thanks!


List WITH under SQL statements

Re: SQL Statements
Issue Description
The WITH statement isn't listed on this page or the SQL statements section of the sidebar. This sometimes leads users to believe that we don't support it. Instead, it's documented under SQL Syntax -> Common Table Expressions, which is not necessarily a name that users know.
Suggested Resolution
Refer to the WITH statement (by that name, not just as CTE) in the lists of statements. It's not quite a regular statement but it looks enough like one that that's how users think of it.

@Amruta-Ranade Can I give it a try?
Thanks,
Shiwanee

I think so. cc @ericharmeling for approval :)

Hi @ericharmeling ! Can I give it a try?
Shiwanee

Hi @Shiwanee.
So sorry for the delay. Go for it! :)

Thanks @ericharmeling! Could you or @Amruta-Ranade , please assign it to me? :-)
Shiwanee

Hi @ericharmeling ,
I have created PR #8850 to fix this issue.
Could you please take a look at it and let me know if this solution works?
Thanks,
Shiwanee

Hi @ericharmeling ,
I have created PR #8850 to fix this issue.
Could you please take a look at it and let me know if this solution works?
Thanks,
Shiwanee

Hi @ericharmeling , do you have any inputs on this?
Thanks,
Shiwanee


Add jammy to meta file

closed per https://github.com/iancleary/ansible-role-caddy/commit/0be5ef28e2eb4ec39892807275a35b2fdbb69e95


How to run on a cluster without workload manager

Dear Francisco,
I realize metaGEM was optimized to run on a HPC cluster system, but the cluster of our lab (40 cores, 500 GB RAM) operates without a workload manager. So as a user you have to take care you don't use all 40 cores, and that you do not submit more jobs then there are cores etc.
I have 43 (soil) samples organized into sample specific subdirectories within the dataset folder
If I run
bash metaGEM.sh --task megahit --local
and I set megahit cores to 24 in the config.yaml file,
Would that mean metaGEM would assemble the samples only one at a time? What I want to avoid is that the metagem parser submits all 43 jobs at once, because on this cluster submitting means starting
Best wishes,
Sam

Closing this because I meant to post this in the general metaGEM repo

Link to issue here


WA-PHD resends

An issue with the update to the REST transport settings occurred where the settings were not update when the change was moved to prod leading to some reports not being sent.
The below report ID's need to be resent to wa-phd.rest:
03749269-2b45-4556-a01e-b81ceb1658ec  -resent
633b2ca7-f605-473e-becd-d1715c13df53 -resent
915c8162-e404-4035-9111-4f2f263e1bc6 - resent
dba61364-0fad-4e7a-b82a-c9a6bee811ce -resent
e5b2467b-ae64-4dfe-8de6-ebc2496e0c46 -resent
39aacca7-f7f6-4942-a6c8-6578f3b46b77   -resent
7bb3255a-cbee-46ad-965c-3ae85e4c07e9 -resent
de15caf5-f7d7-4467-a541-59b3ff69bf54 -resent
688b1f86-66a4-4f64-8f10-fe864b92ff09 -resent
a66bf5c5-0595-40be-8560-3106e0cdba37 -resent
fbcc8b5c-24e1-44d0-99c6-1bd4c0fcce5d    -resent
19a20e5a-723b-47ff-b3cd-97c00e01376d   -resent
96fff488-9884-4805-88a3-87c2e75d5b65    -resent
c71269b5-040c-46a9-80ec-de18340e30df   -resent

All reports resent 1/23/24


Exception in subscribe - google cloud pubsub 0.35.4

Summary:
Hi, thank you for the awesome Google Cloud Pub/Sub python library. 😃
I have a question about this library.

running the publishing process from last week by using Google Cloud Pub/Sub.
running a subscriber process by using Google Cloud Pub/Sub.
After 8 ~ 9 hours from starting subscribing, I got the following stdout.
I used logger and try~except, however, I couldn't handle to logging them.
I want to continue subscribing after I got errors, how should I do? 👀

Environment:

Ubuntu 18.04 (Docker)
Python version (Python 3.6.5 :: Anaconda, Inc..)
PubSub 0.35.4

Warning and Error Stdout:
WARNING:google.cloud.pubsub_v1.subscriber._protocol.leaser:Dropping 1 items because they were leased too long.
WARNING:google.cloud.pubsub_v1.subscriber._protocol.leaser:Dropping 1 items because they were leased too long.
WARNING:google.cloud.pubsub_v1.subscriber._protocol.leaser:Dropping 1 items because they were leased too long.
WARNING:google.cloud.pubsub_v1.subscriber._protocol.leaser:Dropping 1 items because they were leased too long.
WARNING:google.cloud.pubsub_v1.subscriber._protocol.leaser:Dropping 1 items because they were leased too long.
WARNING:google.cloud.pubsub_v1.subscriber._protocol.leaser:Dropping 1 items because they were leased too long.
WARNING:google.cloud.pubsub_v1.subscriber._protocol.leaser:Dropping 1 items because they were leased too long.
WARNING:google.cloud.pubsub_v1.subscriber._protocol.leaser:Dropping 1 items because they were leased too long.
WARNING:google.cloud.pubsub_v1.subscriber._protocol.leaser:Dropping 1 items because they were leased too long.
WARNING:google.cloud.pubsub_v1.subscriber._protocol.leaser:Dropping 1 items because they were leased too long.
WARNING:google.cloud.pubsub_v1.subscriber._protocol.leaser:Dropping 1 items because they were leased too long.
WARNING:google.cloud.pubsub_v1.subscriber._protocol.leaser:Dropping 1 items because they were leased too long.
WARNING:google.cloud.pubsub_v1.subscriber._protocol.leaser:Dropping 1 items because they were leased too long.
WARNING:google.cloud.pubsub_v1.subscriber._protocol.leaser:Dropping 1 items because they were leased too long.
WARNING:google.cloud.pubsub_v1.subscriber._protocol.leaser:Dropping 1 items because they were leased too long.
ERROR:root:Exception iterating requests!
Traceback (most recent call last):
  File "/root/.pyenv/versions/anaconda3-5.2.0/lib/python3.6/site-packages/grpc/_channel.py", line 165, in consume_request_iterator
    request = next(request_iterator)
  File "/root/.pyenv/versions/anaconda3-5.2.0/lib/python3.6/site-packages/google/cloud/pubsub_v1/subscriber/_protocol/bidi.py", line 100, in __iter__
    yield self._initial_request()
  File "/root/.pyenv/versions/anaconda3-5.2.0/lib/python3.6/site-packages/google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py", line 380, in _get_initial_request
    lease_ids = self._leaser.ack_ids
AttributeError: 'NoneType' object has no attribute 'ack_ids'
ERROR:root:Exception iterating requests!
Traceback (most recent call last):
  File "/root/.pyenv/versions/anaconda3-5.2.0/lib/python3.6/site-packages/grpc/_channel.py", line 165, in consume_request_iterator
    request = next(request_iterator)
  File "/root/.pyenv/versions/anaconda3-5.2.0/lib/python3.6/site-packages/google/cloud/pubsub_v1/subscriber/_protocol/bidi.py", line 100, in __iter__
    yield self._initial_request()
  File "/root/.pyenv/versions/anaconda3-5.2.0/lib/python3.6/site-packages/google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py", line 380, in _get_initial_request
    lease_ids = self._leaser.ack_ids

requirements.txt:
google-cloud-translate==1.3.1
google-cloud-videointelligence==1.0.1
google-cloud-vision==0.29.0
google-gax==0.15.16
google-resumable-media==0.3.1
googleapis-common-protos==1.5.3
GPy==1.9.2
grpc-google-iam-v1==0.11.4
grpcio==1.12.0
h5py==2.8.0
html5lib==0.9999999
httplib2==0.11.3
idna==2.6
ipykernel==4.8.2
ipython==6.4.0
ipython-genutils==0.2.0
jedi==0.12.0
jsonlines==1.2.0
jsonpickle==0.9.6
jsonref==0.1
jsonschema==2.6.0
google-api-core==1.3.0
google-auth==1.5.0
google-cloud==0.33.1
google-cloud-bigquery==1.5.0
google-cloud-bigquery-datatransfer==0.1.1
google-cloud-bigtable==0.28.1
google-cloud-container==0.1.1
google-cloud-core==0.28.1
google-cloud-datastore==1.4.0
google-cloud-dns==0.28.0
google-cloud-error-reporting==0.28.0
google-cloud-firestore==0.28.0
google-cloud-language==1.0.2
google-cloud-logging==1.4.0
google-cloud-monitoring==0.28.1
google-cloud-pubsub==0.35.4
google-cloud-resource-manager==0.28.1
google-cloud-runtimeconfig==0.28.1
google-cloud-spanner==0.29.0
google-cloud-speech==0.30.0
google-cloud-storage==1.6.0
google-cloud-trace==0.17.0
google-cloud-translate==1.3.1
google-cloud-videointelligence==1.0.1

Program:
from threading import Thread, Event
from google.cloud import pubsub
import os
import json
from logging import ERROR, INFO
import logging

os.environ["GOOGLE_APPLICATION_CREDENTIALS"] = "/path/to/my_credential.json"

class MyLogger:

    @staticmethod
    def generate_logger(clazz_name):
        logger = logging.getLogger(clazz_name)
        formatter = logging.Formatter('%(asctime)s - %(name)s - %(lineno)d - %(levelname)s - %(message)s')

        file_handler = logging.FileHandler('log/subscriber.log')
        file_handler.setLevel(INFO)
        file_handler.setFormatter(formatter)
        file_handler.addFilter(LoggingFilter(ERROR))
        logger.addHandler(file_handler)

        logger.setLevel(INFO)
        logger.propagate = False

        return logger

class LoggingFilter(object):
    def __init__(self, level):
        self.__level = level

    def filter(self, log_record):
        return log_record.levelno <= self.__level

class SubscribeThread(Thread):
    def __init__(self):
        Thread.__init__(self)
        self.logger = MyLogger.generate_logger('subscribe_thread')
        self.latest_data = {}
        self.event = Event()

        self.subscriber = pubsub.SubscriberClient()
        project_name = '************'
        self.topic_name = 'projects/{}/topics/***********'.format(project_name)
        subscription_path = '***********'

        try:
            self.logger.info('deleting exists subscription')
            subscription = self.subscriber.subscription_path(project_name, subscription_path)
            self.subscriber.delete_subscription(subscription)
        except Exception as e:
            self.logger.error(e)

        self.subscription_name = 'projects/{}/subscriptions/{}'.format(project_name, subscription_path)
        try:
            self.logger.info('creating subscription')
            self.subscriber.create_subscription(name=self.subscription_name, topic=self.topic_name)

            self.logger.info('start subscription')
            self.subscriber.subscribe(self.subscription_name, self.callback)
        except Exception as e:
            self.logger.error(e)

    def callback(self, message):
        try:
            data = json.loads(message.data.decode())
            self.latest_data = data
            self.event.set()
            # message.ack()
        except Exception as e:
            self.logger.error(e)

    def get_latest_data(self):
        return self.latest_data

    def run(self):
        while True:
            try:
                while not self.event.wait(3):
                    self.logger.info('waiting subscriber timed out..')
                    self.event.clear()
                    raise RuntimeError("waiting subscriber timed out..")

                latest_data = self.get_latest_data()
                # NOTE: do something with latest_data

                self.event.clear()

            except Exception as e:
                self.logger.error(e)
                self.subscriber = pubsub.SubscriberClient()
                self.subscriber.subscribe(self.subscription_name, self.callback)

subscriber_thread = SubscribeThread()
subscriber_thread.start()

If you want more info, please let me know.

Sorry, maybe this is my mistake, I haven't called ack() method for each message.
So, a lot of messages had come to the callback process, and CPU and Network Input increased.
Now, I'm trying to above program with ack().
If tomorrow, I don't see the same error, I want to close this issue 🙇

However, if I can, I want to handle such error on the user code 💦

Yeah, we should fix that codepath so it doesn't totally choke, but for sure the biggest issue here is not acking or nacking your message.
If you want to be able to handle errors, you need to keep track of the future returned by subscribe and call result() on it, for example:
future = self.subscriber.subscribe(...)
future.result() # blocks forever or until an exception occurs and then raises that exception

@theacodes
Thank you for replying.
Now, I don't get any errors.
And thank you for the snippets!
I'll also try to use when I want to block messages.


[VL] Failing allocation in DynamicOffHeapSizingMemoryTarget

Backend
VL (Velox)
Bug description
I am trying to set spark.gluten.memory.dynamic.offHeap.sizing.enabled=true", but OOM exception occurs.
spark configuration :
spark.executor.memory=4g;
spark.executor.memoryOverhead=1G;
spark.gluten.memory.dynamic.offHeap.sizing.enabled=true
spark.memory.offHeap.enabled=true

and web ui shows:
spark.gluten.memory.conservative.task.offHeap.size.in.bytes=597059174
spark.gluten.memory.offHeap.size.in.bytes=2388236697
spark.gluten.memory.task.offHeap.size.in.bytes=597059174
spark.memory.offHeap.size=2388236697

And I got the OOM exception:
Reason: Operator::getOutput failed for [operator: ValueStream, plan node ID: 0]: Error during calling Java code from native code: org.apache.gluten.memory.memtarget.ThrowOnOomMemoryTarget$OutOfMemoryException: Not enough spark off-heap execution memory. Acquired: 8.0 MiB, granted: 0.0 B. Try tweaking config option spark.memory.offHeap.size to get larger space to run this application (if spark.gluten.memory.dynamic.offHeap.sizing.enabled is not enabled).
Current config settings:
    spark.gluten.memory.offHeap.size.in.bytes=3.4 GiB
    spark.gluten.memory.task.offHeap.size.in.bytes=876.6 MiB
    spark.gluten.memory.conservative.task.offHeap.size.in.bytes=876.6 MiB
    spark.memory.offHeap.enabled=true
    spark.gluten.memory.dynamic.offHeap.sizing.enabled=true
Memory consumer stats:
    Task.52:                                             Current used bytes: 104.0 MiB, peak bytes:        N/A
    \- Gluten.Tree.0:                                    Current used bytes: 104.0 MiB, peak bytes:  112.0 MiB
       \- root.0:                                        Current used bytes: 104.0 MiB, peak bytes:  112.0 MiB
          +- CelebornShuffleWriter.0:                    Current used bytes:  48.0 MiB, peak bytes:   48.0 MiB
          |  \- single:                                  Current used bytes:  48.0 MiB, peak bytes:   48.0 MiB
          |     +- gluten::MemoryAllocator:              Current used bytes:  28.8 MiB, peak bytes:   29.0 MiB
          |     \- root:                                 Current used bytes:   4.2 MiB, peak bytes:   15.0 MiB
          |        \- default_leaf:                      Current used bytes:   4.2 MiB, peak bytes:   14.1 MiB

It may cause by:
24/10/18 17:16:00 WARN org.apache.gluten.memory.memtarget.DynamicOffHeapSizingMemoryTarget: "Failing allocation as unified memory is OOM. Used Off-heap: 406847480, Used On-Heap:<PHONE_NUMBER>, Free On-heap:<PHONE_NUMBER>, Total On-heap:<PHONE_NUMBER>, Max On-heap:<PHONE_NUMBER>, Allocation: 8388608."
24/10/18 17:16:00 INFO org.apache.spark.memory.TaskMemoryManager: "Memory used in task 11"
24/10/18 17:16:00 INFO org.apache.spark.memory.TaskMemoryManager: "Acquired by org.apache.gluten.memory.memtarget.spark.TreeMemoryConsumer@182a8cbe: 104.0 MiB"
24/10/18 17:16:00 INFO org.apache.spark.memory.TaskMemoryManager: "0 bytes of memory were used by task 11 but are not associated with specific consumers"
24/10/18 17:16:00 INFO org.apache.spark.memory.TaskMemoryManager: "406847480 bytes of memory are used for execution and 1129714 bytes of memory are used for storage"

As we can see above, the used off-heap memory is only 406847480(388MiB), while  my off-heap configuration is 2.2GiB.
Why will throw OOM exception?
Spark version
Spark-3.2.x
Spark configurations
No response
System information
No response
Relevant logs
No response

https://github.com/apache/incubator-gluten/blob/main/gluten-core/src/main/java/org/apache/gluten/memory/memtarget/DynamicOffHeapSizingMemoryTarget.java#L51
I have one question here:
if (size + usedOffHeapBytesNow + usedOnHeapBytes > MAX_MEMORY_IN_BYTES) {
    ...
}

Why we need to use the usedOnHeapBytes to compare with MAX_MEMORY_IN_BYTES(offHeapMemorySize)?

PTAL @supermem613 @zhztheplayer

When spark.gluten.memory.dynamic.offHeap.sizing.enabled=true it will not consider the configured off-heap size https://github.com/apache/incubator-gluten/blob/main/gluten-core/src/main/scala/org/apache/gluten/GlutenPlugin.scala#L167

When spark.gluten.memory.dynamic.offHeap.sizing.enabled=true it will not consider the configured off-heap size https://github.com/apache/incubator-gluten/blob/main/gluten-core/src/main/scala/org/apache/gluten/GlutenPlugin.scala#L167

Perhaps there was a tiny typo leading to a bug when PR #5439 was iterated? cc @supermem613 Would you like to help confirm? Thanks.
https://github.com/apache/incubator-gluten/pull/5439/commits/8c7cfa59bf9f8c015e16c225d3d14c7801a977dd

When spark.gluten.memory.dynamic.offHeap.sizing.enabled=true it will not consider the configured off-heap size https://github.com/apache/incubator-gluten/blob/main/gluten-core/src/main/scala/org/apache/gluten/GlutenPlugin.scala#L167

Perhaps there was a tiny typo leading to a bug when PR #5439 was iterated? cc @supermem613 Would you like to help confirm? Thanks.
A commit that looks like to be related in PR #5439 8c7cfa5

@zhztheplayer what typo do you mean?

Why are you using the option spark.gluten.memory.dynamic.offHeap.sizing.enabled? @wenwj0

GlutenConfig.getConf().onHeapMemorySize() was changed to GlutenConfig.getConf().offHeapMemorySize(), which doesn't look like intentional to me, but I am not sure.

After reading more code I guess this was intentional... The code tended to set an off-heap size then use the size to cover off-heap + on-heap. The PR used on-heap initially at the time when I was reviewing.
@wenwj0

As we can see above, the used off-heap memory is only 406847480(388MiB), while my off-heap configuration is 2.2GiB.

I believe your case is because on-heap occupies the remaining 2.2 GiB - 388 MiB, which could be considered by-design of the feature. But it would be great if you can share more background information about your use case. From my impression only a few users are using the option.

Why are you using the option spark.gluten.memory.dynamic.offHeap.sizing.enabled? @wenwj0

In our scenario, we have various configurations for different executor memory. I try to use this property because it seems that I can use the existing configurations without the need to set extra off-heap memory.

I believe your case is because on-heap occupies the remaining 2.2 GiB - 388 MiB, which could be considered by-design of the feature. But it would be great if you can share more background information about your use case. From my impression only a few users are using the option.

I agree with you.
MAX_MEMORY_IN_BYTES refers to off-heap memory, hence
(size + usedOffHeapBytesNow + usedOnHeapBytes > MAX_MEMORY_IN_BYTES) =>
(8MiB + 388MiB + 1927MiB = 2323MiB >   MAX_MEMORY_IN_BYTES(2GiB)
If the MAX_MEMORY_IN_BYTES is onheap memory or onheap+offheap memory, maybe it works. @zhztheplayer

onheap+offheap memory

It sounds OK to me to change to on-heap + off-heap, which may simplify the relevant configuration setting code by the way.
cc @supermem613 @zhli1142015


NA SM: cannot initialize with large pages

When using large pages, NA SM throws the following error:
# Using info string: na+sm://75793/0
# NA -- Error -- /usr/workspace/wsb/moody20/projects/mercury/mercury-1.0.0/src/na/na_sm.c:986
# na_sm_open_shared_buf(): Not aligned properly, page size=65536 bytes, buf size=266240 bytes
# NA -- Error -- /usr/workspace/wsb/moody20/projects/mercury/mercury-1.0.0/src/na/na_sm.c:1369
# na_sm_setup_shm(): Could not create copy buffer
# NA -- Error -- /usr/workspace/wsb/moody20/projects/mercury/mercury-1.0.0/src/na/na_sm.c:2535
# na_sm_initialize(): Could not setup shm
# NA -- Error -- /usr/workspace/wsb/moody20/projects/mercury/mercury-1.0.0/src/na/na.c:380
# NA_Initialize_opt(): Could not initialize plugin
# NA -- Error -- /usr/workspace/wsb/moody20/projects/mercury/mercury-1.0.0/Testing/na/na_test.c:419
# NA_Test_init(): Could not initialize NA
# HG -- Error -- /usr/workspace/wsb/moody20/projects/mercury/mercury-1.0.0/Testing/mercury_test.c:353
# HG_Test_init(): Could not initialize NA test layer

I looked at it in more details and it seems fine to me to remove that check for now. We would need to benchmark it though to see if there is any need to go over 4KB and/if having the 0 zero copy bulk transfer when going over that limit is better over having larger pages and making copies.


MED: 1119: [JS Error] _getDownloadLink srcUrl is sometimes undefined

@Syeda-Azim Just curious: are you able to reproduce the error? Do we know why it's sometimes undefined?

@Syeda-Azim Just curious: are you able to reproduce the error? Do we know why it's sometimes undefined?

I could reproduce the error in the media-player's demo by enabling allowDownload attribute. When multiple qualities are enabled using  tags, we do not set src on d2l-labs-media-player, which leads to the undefined error.


Allow not specifying any plugin file

It's currently not possible to run without specifying any plugin file.

MMhh, I must admit I went with the simplest of pipeline (echo 'hello world') and I can confirm this not very realistic use case works. I'll try to play a bit more and drop a line in the doc.

@PierreBtz Should not be a problem once the ne Packaging flow is finalized. I plan to inject bundled plugin metadata so that the JFR plugin manager properly loads it even if there is no HPIs referenced


Inline suggestions are shown in solid color instead of grey

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:
I've attached the source code. The bug shows up sometimes in the last but one line of the file.
snake-game.zip
https://user-images.githubusercontent.com/86270736/131589755-e025b97d-e817-4d34-a516-8c3dab981661.mp4
Note: One theory is that the inline suggestion is rendered more than once and if text is shown in grey by modifying opacity, it could be overlapping and causing it to be white.

The problem is that show-unused/unnecessary interfers with the ghost-text-decoration styles (the code after the while true loop is unreachable). Because it overrides opacity, but not color, it appears lighter.

I added some !importants which should resolve the conflict.
Please verify this issue in Monday's insiders build!

/verified


[Feature Request] TAB Completion

Greetings!!
The following project is awesome, but there is a feature missing here. It's TAB completion for the game. I would really love to see it's existence. Thanks!
--
with love
naryal2580

Any updates here? 😀


Maintain a valid state in event of IOError

Installation died on me because LONG_DESCRIPTION wasn't defined. It was defined only in the try portion of setup.py, with except IOError doing nothing (pass). So then later of course long_description=LONG_DESCRIPTION threw an error.
To make it work, I just aliased LONG_DESCRIPTION to DESCRIPTION when the IOError is raised. Also printed a warning. Which doesn't feel like good form, but importing logging felt like overkill. Maybe doing no warnings is the way to go?

It's been over 3 years since this issue was first reported.  Can someone please merge this pull request and update PyPI?

Sure, merging.


[QUESTION] /waiting

Describe the bug
Actually it might not a bug. I more likely I want to know this.
I have setup this docker on top of the moode audio. And let uprcl read my local(same as moode audio resides) directory's sound files and activate upnp renderer on moode audio. And it seems to working fine with mconnect. (good!)
And there is playlist remains in the UI of moode after playing. and it displays as

It is okay as moode audio dropped function of browsing of upnp.
However I wanted to know where '/waiting' url has been given to moode audio?
I can't find it in the source code of moode audio and I also can't find in it.
python3 /usr/share/upmpdcli/cdplugins/uprcl/uprcl-app.py inside of the docker.

I made connection 9090 through docker by opening port in docker-compose and UPRCL_HOSTPORT=localhost:9090 in it.
when I test it with curl localhost:9090. it was able to check networking was going in it.
Is that a protocol of upnp?
or uprcl didn't complete the implementation of all of upnp(if it needed)?
Thank you.
% I found this after this ticket - 'cache/metacache' file has this content. where this xml came from ..?

cache/metacache:http://<IP_ADDRESS>:9090/waiting=<?xml version%3D"1.0" encoding%3D"utf-8"?><DIDL-Lite xmlns:dc%3D"http://purl.org/dc/elements/1.1/
" xmlns:upnp%3D"urn:schemas-upnp-org:metadata-1-0/upnp/" xmlns%3D"urn:schemas-upnp-org:metadata-1-0/DIDL-Lite/" xmlns:dlna%3D"urn:schemas-dlna-org
:metadata-1-0/"><item id%3D"mpdid:16427" parentID%3D"0" restricted%3D"1" searchable%3D"0"><dc:title>Initializing...</dc:title><orig>mpd</orig><upn
p:class>object.item.audioItem.musicTrack</upnp:class><res>http://<IP_ADDRESS>:9090/waiting</res></item></DIDL-Lite>

Operating system(please complete the following information):

OS: [e.g. Raspbian, Debian, Ubuntu, etc]: debian(maybe)
Architecture [e.g. armhf, arm64, amd64]: arm64
Version [any relevant information]

Hello, can you post your docker-compose file or docker-run command?
Thank you

From what I see without the compose file, it looks to me that "UPRCL_HOSTPORT=localhost:9090" is not ok, because probably a request with the ip address would not be served. Maybe replace localhost with your "<IP_ADDRESS>:9090"

version: "3"
services:
  upmdcli:
    image: giof71/upmpdcli
    container_name: upmpdcli-library
    network_mode: host
    environment:
    - PORT_OFFSET=0
    - PUID=1000
    - PGID=1000
    - RENDERER_MODE=BOTH
    - UPRCL_ENABLE=yes
    - UPRCL_USER=upmmpdcli-library
    - UPRCL_AUTOSTART=1
    - UPRCL_HOSTPORT=localhost:9090
    ports:
    - "9090:9090"            #it seems to not useful when  network_mode: host
    volumes:
    - ./cache:/cache
    - ./log:/log
    - /media/103F0F09103F0F09/:/uprcl/mediadirs/
#- ./config/uprclconfdir:/urpcl/confdir
#- ./config/upmpdcli/additional-radio.txt:/user/config/additional-radio.txt
    labels:
    - com.centurylinklabs.watchtower.enable=false
    restart: unless-stopped

/usr/share/upmpdcli/cdplugins/uprcl/uprcl-app.py  : seems like listing 9090 port

One more thing (cit.), you should map the uprcl config directory in order to persist the library database.
You can create a directory by doing:
mkdir
---
version: "3"
services:
  upmpdcli:
    image: giof71/upmpdcli
    container_name: upmpdcli-library
    network_mode: host
    environment:
      - PORT_OFFSET=0
      - PUID=1000
      - PGID=1000
      - MEDIA_SERVER_FRIENDLY_NAME=Moode Library
      - RENDERER_MODE=NONE
      - UPRCL_ENABLE=yes
      - UPRCL_USER=upmpdcli-library
      - UPRCL_AUTOSTART=1
      - UPRCL_HOSTPORT=<IP_ADDRESS>:9090
    volumes:
      - ./cache:/cache
      - ./log:/log
      - /media/103F0F09103F0F09:/uprcl/mediadirs
      - ./uprclconfdir:/urpcl/confdir
    labels:
      - com.centurylinklabs.watchtower.enable=false
    restart: unless-stopped

I am referencing a ./uprclconfdir from the path of the compose file, but you can put it where you want or use a docker volume. If you mount a directory, be careful with permission, it must be readable/writable by user with uid=1000 and gid=1000 considering the values in your compose file.

Hello, did this work for you§?

Hi yes it is working now. Thank you so much.

Good to know, thank you.
I have added the uprcl configuration here so other users might find it easier to implement.
Please consider starring the repo if you like the work!


Stream Response is broken

Model: gpt-3.5-turbo
System Prompt: You are a helpful assistant
Response #1
Input: What is the largest mammal in the world
Response: The mammal the the whale It of to98 feet (30) and over 200 tons
Response #2
Input: What is the tallest building in the world
Response: the, but foundation for only can build your tall as Bur Khalifa
What suppose to be the problem here? I correctly setup the flutter and dart_openai. Whenever I give an input, the response is always broken English.

I have encountered the same issue.
Model: text-davinci-003
I tried both Stream  and Stream, but response seems to be skipping words.

I think there's a problem when parsing the data on the streaming models.fromJson methods

I can confirm that this still is a problem.

This is fixed and will be available in the next version.


Display of {S#|P#} reference

I agree that I prefer

Space is [not] Property

over the current

Space | Property

See https://github.com/pi-base/web/issues/66#issuecomment-1800508426_

Question: how would you want it to display if the trait value is unknown? (Probably not a common case, but "has bearing on this open question" could be a thing)


[BEAM-8252] Python: add worker_region and worker_zone options

Note that these flags won't actually do anything until we update the Dataflow client, so we shouldn't merge this PR until then.
EDIT: the client is merged (#9589), so this should be ready now.

Should this be patched into the release branch?

Should this be patched into the release branch?

Maybe, but it'd be preferable to introduce the Java and Python options in the same release: #9961.

Ack. Reviewed #9961


[Backport release-21.11] coreboot-toolchain: Backport fixes

Motivation for this change
Backport fixes.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build coreboot-toolchain.i386 coreboot-toolchain.arm coreboot-toolchain.aarch64 coreboot-toolchain.riscv coreboot-toolchain.ppc64 coreboot-toolchain.nds32le coreboot-toolchain.x86_64

@GrahamcOfBorg build coreboot-toolchain.i386 coreboot-toolchain.arm coreboot-toolchain.aarch64 coreboot-toolchain.riscv coreboot-toolchain.ppc64 coreboot-toolchain.nds32le coreboot-toolchain.x64


Request for basic/normal permissions

Hi folks I can't select a reviewer:

thanks

@helio-frota, as I don't have admin privileges please approach @bobmcwhirter, @ctron or @jcrossley3 .

@gildub I noticed that you are admin on this repository. I anyway added the @trustification/committers team to the repository.


Detect Current Service Endpoint

Using the frontend-backend example.
Is there any solution to do like that:

This seems like it doesn't work.

Are you running the project with tye?

Are you running the project with tye?

Yes, I’m using frontend-backend example and modified like the picture

So you modified which project? The backend to get the backend address?

@jkotalik did you dependencies change maybe break this?
@quoctuancqt why are you trying to detect your own address? Do you have a scenario?

So you modified which project? The backend to get the backend address?

Yes, corect

@jkotalik did you dependencies change maybe break this?
@quoctuancqt why are you trying to detect your own address? Do you have a scenario?

Assume backend is my Web API which I have implement a middleware to handle Authorization using JWT. That’s why I need to resolve my own address.

@quoctuancqt this should be fixed in 0.3. Feel free to try the latest nightlies to confirm it works.

@quoctuancqt this should be fixed in 0.3. Feel free to try the latest nightlies to confirm it works.

I try with tye version 0.3 but it still doesn't work.


Interpolation Search in Python

Can I make Interpolation search in python?

Can I make Interpolation search in python?

Yes, I will waiting for you pull request

This is merged on pull request #334


Adding videos and presentations

this PR has a dependency on the pod man PR, so we need to rebase this it seems


onBeforeSortChanged isnt called anymore, regrission on 10.0

I'm submitting a ...  (check one with "x")
[x ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/ceolter/ag-grid/blob/master/CONTRIBUTING.md#question

Current behavior
onBeforeSortChanged Is not being called when sorting
Expected behavior
onBeforeSortChanged should be called on sorting

Browser: chrome

Language: TypeScript

Hi,
Since 10.0.0 onBeforeSortChanged is not used anymore, you can listen to onFilterChanged and it should keep the same logic as it was using before.

@makinggoodsoftware subscribing to onBeforeFilterChanged or to onFilterChanged doesn't trigger when grid column is sorted...


Allow cleanup to be skipped on a per plugin basis

What this PR does / why we need it:
This PR Introduces a new field to the plugin definition which allows
cleanup for a given plugin to be skipped. This can be used in the
case where a user wants to inspect the resources after a plugin
has finished running.
If this field is set to true, cleanup for that plugin will be skipped.
If it is omitted or set to false, cleanup will happen as usual.
Signed-off-by: Bridget McErlean<EMAIL_ADDRESS>Which issue(s) this PR fixes

Fixes #299

Special notes for your reviewer:
This change will also require documentation to be updated
which I haven't yet done.
Release note:
Introduced a new plugin configuration option which allows clean up of resources for that plugin to be skipped.

Another /run_e2e.sh: line 65: wait: ': not a pid or valid job spec` problem in CI.
I restarted the build.

Codecov Report

Merging #796 into master will increase coverage by 0.06%.
The diff coverage is 30%.

@@            Coverage Diff             @@
##           master     #796      +/-   ##
==========================================
+ Coverage   42.64%   42.71%   +0.06%
==========================================
  Files          71       71
  Lines        4193     4198       +5
==========================================
+ Hits         1788     1793       +5
  Misses       2298     2298
  Partials      107      107

Impacted Files
Coverage Δ

pkg/plugin/driver/base.go
39.74% <0%> (-1.05%)
:arrow_down:

pkg/plugin/manifest/manifest.go
4% <0%> (-0.17%)
:arrow_down:

pkg/plugin/aggregation/run.go
26.49% <100%> (+3.21%)
:arrow_up:

pkg/plugin/loader/loader.go
75.67% <100%> (+0.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad75ce4...6722d84. Read the comment docs.


TimeZone issue : How to set it to UTC ? Uniform Time zone ?

Hi,
I tried setting the browser timezone to UTC but still it changes the time when I change the time zone of the system ( Windows Desktop ). My application resides in Centos box ( UTC ) . I am accessing the application from windows desktop (US east ). The time is displayed as per US east . how do I set it to UTC  irrespective of timezone I am accessing the app ?

Did you solve this problem? I am having the same issue.

No, Issue is not resolved. Post here if you find solution

@Serhioromano , Any suggestions on how to resolve this issue?

Is anyone found any solution?

十分感谢，邮件已经收到！


Remove 2 items

Hi Writer team,
Please remove "Members can invite" and "Admins and users in the guest inviter role can invite" from "Restrict guest users' default permissions" segment in this article. There are no these options in portal now. See issue https://github.com/MicrosoftDocs/azure-docs/issues/99050 for your reference.
Thanks
Alex

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 510faed7-b79d-b8ec-f32f-e64d8773a30c
Version Independent ID: 522e7e2e-ea93-5249-5e6f-5c984f1b6277
Content: Default user permissions - Azure Active Directory - Microsoft Entra
Content Source: articles/active-directory/fundamentals/users-default-permissions.md
Service: active-directory
Sub-service: fundamentals
GitHub Login: @barclayn
Microsoft Alias: barclayn

@alexchen2016
Thanks for your feedback! We will investigate and update as appropriate.

@alexchen2016
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly
@barclayn
Can you please check and add your comments on this doc update request as applicable.

@alexchen2016 thank you for your feedback. I have created a work item for me to track this work internally. #please-close


system aware execute_command

fix related to issue reported here:
https://github.com/saoudrizwan/claude-dev/issues/346
Improves model focus on providing commands tailored to current operating system

Interesting... you're finding this helps it come up with better commands?

So, suggested PR helped for me (I've tested build locally) i will test Powershell Update, but I wouls say problem might be more generic and not limited only to '&&'


Add instructions in README

It would be great if you add some instructions on how to use this plugin.

Hey! Thanks for your interest. I'm not a fan of gitflow and created this plugin for my current job since they have too much sunk cost in gitflow at this point to turn back. I will write some docs for it over the break, but its def not by best code haha.

Done!


Prohibit path traversal for static files with embedded directory separators

Summary
GET requests with embedded url_escaped backslashes can be used to access local files outside of webroot
Motivation
I think Mojo::Path is correct in splitting the URL only on slashes. The problem only occurs when the filesystem is accessed. I don't know whether this is the only location where this happens, but the reported bug can be fixed by checking the path parts for directory separators of the current OS.
References
https://irclog.perlgeek.de/mojo/2018-04-23#i_16083074 and following.

Is there a significant performance cost?

I think you are not interested in the performance on windows?
I tested on my ubuntu notebook.  The performance hit is depending on the URLs path depth.
With a depth of 10, old and new produce about 460 req/s. There is no significant impact.
With a depth of 25 the performance drops to about 450 req/s.
Is that acceptable?

But your changes don't just affect Windows, so performance impact does matter quite a bit.

Just to comment that these two mojo tests:
use Mojolicious::Lite;
use Test::More;
use Test::Mojo;

get '/' => { data => 'Hello World' };

my $t = Test::Mojo->new;

$t->get_ok('/..\..\..\..\..\..\..\..\..\..\..\windows\win.ini')
  ->content_unlike(qr/extensions/);
$t->get_ok(
    '/..%5C..%5C..%5C..%5C..%5C..%5C..%5C..%5C..%5C..%5C..%5Cwindows%5Cwin.ini')
  ->content_unlike(qr/extensions/);

done_testing();

passes ok after aplying the PR
The 'extensions' word happens to be part of the leaked file (c:\windows\win.ini). When tested on strawberry perl 5.26.1 over Win 10 using the master branch it fails, and you can see in the report messages the contents of the leaked file.
So it seems to correct the issue.

There is definitely a measurable performance loss.
perl -Ilib -Mojo -E 'a("/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q" => {data => "works"})->start' daemon -m production -l http://*:8080

2004.76 Requests/sec before, and 1881.92 Requests/sec after.

@kraih: exactly, that is the reason I benchmarked on Linux(Ubuntu). I can only benchmark the windows performance hit tomorrow when I will have access to windows again. But since Windows needs the fix, a performance hit would be more acceptable there.

What do you use to measure the performance against the server?

setting env var MOJO_LOG_LEVEL=debug will show requests/sec.
i.e.:
MOJO_LOG_LEVEL=debug perl -Ilib -Mojo -E 'a("/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q" => {data => "works"})->start' daemon -m production -l http://*:8080

wrk -c 100 -d 10s http://<IP_ADDRESS>:8080/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q

Yes, the first commit contained only the changes to the tests and all 3 failed on the appveyor build
https://ci.appveyor.com/project/tomk3003/mojo/build/1 if you want to check. The second fail was because cygwin was not using File::Spec::Win32
Should I use a constant as @haarg suggested. If yes then how? 'my $is_win_os =...' ?
I'll squash the comments when there are no more change requests.

Since @tomk3003 has said this pull request is ready i'm calling for a formal vote (@jberger, @jhthorsen, @marcusramberg). My vote will be neutral, since i very much hate Windows special cases ($^O eq 'MSWin32'), but recognise the seriousness of the security issue it is meant to fix.

Calling off the vote for now since a new security issue has been introduced in the meantime.

I don't mind IS_WINDOWS, since this is a windows bug.
👍 from me.

It's not a windows bug but a bug on any system that uses directory separators different from URLs. However since Windows is the only system this fix is meant to address this seems fine to me.

I just applied @kraih 's suggested regex change I missed over the security issue

I implement a patch to fix this problem.
https://github.com/yuki-kimoto/mojo/commit/bcfa57676598fdbdeec0478e483aaf7f0a9bbfdd
This patch only fobidden backslash of path when statci file is served.
File path expression must be URL path expression.
But in windows, backslash is allowed in file path expression.
I think this is problem.

there's a performance cost everyone has to pay for a windows problem
Portability or performance. This is oposite thing.
If one thing is more important, another is limitted.
I want to use plubic method. but for Windows, I want not to slow down Mojolicious.

alternative implementations?
If backslash is cheked in Mojo::Static::dispatch, all of @parts must be searched. This damages performance much.
I also think using $^O is not good.
In first implementation, before @parts is build, check if path contains backslash.

I don't like the platform specific workaround either. But it is fast for non Windows platforms.
The patch suggested by @yuki-kimoto will most likely solve the issue but with a yet to measure performance impact and the additional restriction that backslash will be dissallowed on all OSes (which feels a bit unclean, but will not cause any real problems, I guess).
If there was a portable way to get the list of allowed filesystem path separators this would be easy. But alas it isn't.

@tomk3003 @kraih

simply disallowing backslash for static file paths on all platforms does seem like a good idea.

the additional restriction that backslash will be dissallowed on all OSes (which feels a bit unclean, but will not cause any real problems, I guess)

In public directory(This has only static files), developer don't use file names which contains backslash.
In template, backslash use is all of ok in my  implementation proposal.

If there was a portable way to get the list of allowed filesystem path separators this would be easy. But alas it isn't.

This seems to be impossible. File::Spec and Config don't provide information of allowed filesystem path separators.

@kraih

And i do wonder if it can be optimized to a point where it is not noticeable on benchmarks anymore.

I don't yet do benchmark. Is my implementation bad performance?

While @yuki-kimoto does not make a particularly strong argument, simply disallowing backslash for static file paths on all platforms does seem like a good idea. And i do wonder if it can be optimized to a point where it is not noticeable on benchmarks anymore.

we could join the @parts array right before comparisons, and then check everything with just one regex, like
 ...

  # Serve static file and prevent path traversal
  my $canon_path = join '/', @parts;
  return undef if $canon_path =~ /^..\/|.*\\/ || !$self->serve($c, $canon_path);

...

This is probably a bit slower that just the `$parts[0] eq '..', but shouldn't be that much.
I forked tomk3003, checkout lib/Mojolicious/Static.pm to original and made these changes, check against cygwin and pure win10 and all tests pass. Branch is
"static_traverse_check"
On an ubuntu linode server (tests also pass) I run master kraijh/mojo version on a daemon on port 8081, and this branch on port 8080, with similar results:
➜  mojo git:(28c156b) wrk -c 100 -d 1m http://<IP_ADDRESS>:8081/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q
Running 1m test @ http://<IP_ADDRESS>:8081/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q
  2 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   106.25ms   12.37ms 196.10ms   84.51%
    Req/Sec   475.98     95.93     0.86k    86.48%
  56498 requests in 1.00m, 7.93MB read
Requests/sec:    940.84
Transfer/sec:    135.22KB
➜  mojo git:(28c156b) wrk -c 100 -d 1m http://<IP_ADDRESS>:8080/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q
Running 1m test @ http://<IP_ADDRESS>:8080/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q
  2 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   106.68ms   14.90ms 230.27ms   85.99%
    Req/Sec   476.03     95.53   848.00     85.63%
  56200 requests in 1.00m, 7.89MB read
Requests/sec:    935.90
Transfer/sec:    134.51KB
➜  mojo git:(28c156b)

After running several times, values varies between 900 and 1100 reqs/sec, and I don't see big differences between both versions

@dmanto
This seems like to be better than my implementation because this implementation don't use private attribute and merge checking logic into one regular exppresion.
Benchmark result is in 5/1000.

Thank you. I've merged #1217 since it does not require Windows to be a special case.

I have no idea if that's the right decision, unfortunately we do not have enough reviewers with Windows expertise. That also means Windows will stay officially unsupported.

we do not have enough reviewers with Windows expertise.

Is is mean Windows expertise  need Mojolicious core team?


Perform Re-organisation of the Project

The application is currently following no Architecture as suggested by Android. Re-organize the classes to make it follow an Architecture.

Hey, can I work on this issue?


Translations update from Weblate

Translations update from Weblate for Wavelog/Main Translation.
It also includes following components:

Wavelog/Installer

Current translation status:

don't merge until #1007  is merged


Why it not work in 2 machines?

Hello, I developing application using Aeron.
I have question.
I have 2 machines and want to communicate using aeron.
First machine:
running media driver, and
Aeron.addSubscription(aeron:udp?endpoint="second machine IP":40123, streamId);

Second machine:
running media driver, and
Aeron.addPublication(aeron:udp?endpoint="first machine IP:40123", streamId);

Why it not work?

Sorry but there is not sufficient information here to diagnose the issue.  What errors are you seeing? Can you make a UDP connection without using Aeron? Are you sure you have the IP addresses correct? Do you have firewalls in the way?

Thanks.
Can you make a UDP connection without using Aeron? Are you sure you have the IP addresses correct? Do you have firewalls in the way?
no problem
This script ran correctly.
user@second-machine$ echo "This is a test" | nc -u first-machine 40123

and
user@first-machine$ nc -u -l 40123

Detail of status is

environments
OS:  Ubuntu 16.04  LTS

1 Running media driver in first and second machines.

user@first-machine$  java -cp aeron-samples/build/libs/samples.jar io.aeron.driver.MediaDriver

user@second-machine$  java -cp aeron-samples/build/libs/samples.jar io.aeron.driver.MediaDriver

2 Write my code is like Basic{Subscriber|Publication}.
...

Aeron.addSubscription(aeron:udp?endpoint="second machine IP":40123, streamId);

...
Aeron.addPublication(aeron:udp?endpoint="first machine IP:40123", streamId);

...

3 make, run, and result

user@first-machine$ ./peer
Subscribe mode

user@second-machine$ ./peer
Publish mode

Neither of these, no error, no stdout.
Thanks

Thanks. If you run AeronStat on each machine you will see the connections appear, or not, in the position counters.
To debug try the tools on the page below:
https://github.com/real-logic/Aeron/wiki/Monitoring-and-Debugging

Thanks
I ran
user@first-machine$ java -cp aeron-samples/build/libs/samples.jar   -javaagent:aeron-agent/build/libs/aeron-agent-0.9.10-SNAPSHOT-all.jar   -Daeron.event.log=admin,FRAME_IN   io.aeron.driver.MediaDriver

result
WARNING: /dev/shm/aeron-ubuntu already exists.
INFO: Aeron directory /dev/shm/aeron-ubuntu exists
INFO: Aeron CnC file /dev/shm/aeron-ubuntu/cnc.dat exists
INFO: Aeron toDriver consumer heartbeat is 15985 ms old
TRANSFORM io.aeron.driver.media.ReceiveChannelEndpoint
TRANSFORM io.aeron.driver.media.SendChannelEndpoint
TRANSFORM io.aeron.driver.ClientProxy
TRANSFORM io.aeron.driver.ReceiverProxy
TRANSFORM io.aeron.driver.SenderProxy
TRANSFORM io.aeron.driver.DriverConductor
[109202.266126] CMD_IN_ADD_SUBSCRIPTION [71/71]: aeron:udp?endpoint=second-machine:40123 12 [-1][0:1]
[109202.340813] RECEIVE_CHANNEL_CREATION [104/104]: UdpChannel - localData: <IP_ADDRESS>/<IP_ADDRESS>:0, remoteData: /second-machine:40123, ttl: 0
[109202.359479] CMD_OUT_ON_OPERATION_SUCCESS [16/16]: [0:1]
[109202.763660] CMD_IN_KEEPALIVE_CLIENT [16/16]: [0:0]
[109203.263965] CMD_IN_KEEPALIVE_CLIENT [16/16]: [0:0]
[109203.768674] CMD_IN_KEEPALIVE_CLIENT [16/16]: [0:0]
[109204.269099] CMD_IN_KEEPALIVE_CLIENT [16/16]: [0:0]
[109204.770394] CMD_IN_KEEPALIVE_CLIENT [16/16]: [0:0]
[109205.274429] CMD_IN_KEEPALIVE_CLIENT [16/16]: [0:0]
[109205.775214] CMD_IN_KEEPALIVE_CLIENT [16/16]: [0:0]

and
user@second-machine$ java -cp aeron-samples/build/libs/samples.jar   -javaagent:aeron-agent/build/libs/aeron-agent-0.9.10-SNAPSHOT-all.jar   -Daeron.event.log=admin,FRAME_IN   io.aeron.driver.MediaDriver

result
WARNING: /dev/shm/aeron-ubuntu already exists.
INFO: Aeron directory /dev/shm/aeron-ubuntu exists
INFO: Aeron CnC file /dev/shm/aeron-ubuntu/cnc.dat exists
INFO: Aeron toDriver consumer heartbeat is 47562 ms old
TRANSFORM io.aeron.driver.media.ReceiveChannelEndpoint
TRANSFORM io.aeron.driver.media.SendChannelEndpoint
TRANSFORM io.aeron.driver.ClientProxy
TRANSFORM io.aeron.driver.ReceiverProxy
TRANSFORM io.aeron.driver.SenderProxy
TRANSFORM io.aeron.driver.DriverConductor
[90310.889630] CMD_IN_ADD_PUBLICATION [63/63]: aeron:udp?endpoint=first-machine:40123 12 [0:1]
[90310.947686] SEND_CHANNEL_CREATION [104/104]: UdpChannel - localData: <IP_ADDRESS>/<IP_ADDRESS>:0, remoteData: /first-machine:40123, ttl: 0
[90311.185585] CMD_OUT_PUBLICATION_READY [111/111]: -791769768:12 23 [1]
    /dev/shm/aeron-ubuntu/publications/UDP-00000000-0-3b6addd3-40123-D0CE8D58-C-1.logbuffer
[90311.389157] CMD_IN_KEEPALIVE_CLIENT [16/16]: [0:0]
[90311.890443] CMD_IN_KEEPALIVE_CLIENT [16/16]: [0:0]
[90312.394918] CMD_IN_KEEPALIVE_CLIENT [16/16]: [0:0]
[90312.897572] CMD_IN_KEEPALIVE_CLIENT [16/16]: [0:0]
...

AeronStat
first-machine

19:04:20 - Aeron Stat
=========================
  0:                    0 - Bytes sent
  1:                    0 - Bytes received
  2:                    0 - Failed offers to ReceiverProxy
  3:                    0 - Failed offers to SenderProxy
  4:                    0 - Failed offers to DriverConductorProxy
  5:                    0 - NAKs sent
  6:                    0 - NAKs received
  7:                    0 - Status Messages sent
  8:                    0 - Status Messages received
  9:                    0 - Heartbeats sent
 10:                    0 - Heartbeats received
 11:                    0 - Retransmits sent
 12:                    0 - Flow control under runs
 13:                    0 - Flow control over runs
 14:                    0 - Invalid packets
 15:                    1 - Errors
 16:                    0 - Short sends
 17:                   83 - Client keep-alives
 18:                    0 - Sender flow control limits applied
 19:                    0 - Unblocked Publications
 20:                    0 - Unblocked Control Commands
 21:                    0 - Possible TTL Asymmetry
 22:                   -1 - recv-channel: aeron:udp?endpoint=second-machine:40123
--

second-machine
19:04:19 - Aeron Stat
=========================
  0:                    0 - Bytes sent
  1:                    0 - Bytes received
  2:                    0 - Failed offers to ReceiverProxy
  3:                    0 - Failed offers to SenderProxy
  4:                    0 - Failed offers to DriverConductorProxy
  5:                    0 - NAKs sent
  6:                    0 - NAKs received
  7:                    0 - Status Messages sent
  8:                    0 - Status Messages received
  9:                    0 - Heartbeats sent
 10:                    0 - Heartbeats received
 11:                    0 - Retransmits sent
 12:                    0 - Flow control under runs
 13:                    0 - Flow control over runs
 14:                    0 - Invalid packets
 15:                    0 - Errors
 16:                    0 - Short sends
 17:                  131 - Client keep-alives
 18:                    1 - Sender flow control limits applied
 19:                    0 - Unblocked Publications
 20:                    0 - Unblocked Control Commands
 21:                    0 - Possible TTL Asymmetry
 22:                    1 - send-channel: aeron:udp?endpoint=first-machine:40123
 23:                    0 - pub-lmt: 1 -630650780 12 aeron:udp?endpoint=first-machine:40123
 24:                    0 - snd-pos: 1 -630650780 12 aeron:udp?endpoint=first-machine:40123
--

Thanks

Note the first-machine has an error recorded. Use the ErrorStat program to find out what it is.

Thanks
I get this error when only Subscription. Even if reverse a role, the same state.
***
1 observations from 2016-07-12 19:42:09.640+0900 to 2016-07-12 19:42:09.640+0900 for:
 .lang.RuntimeException: channel "aeron:udp?endpoint=second-machine:40123" : java.net.BindException: Cannot assign requested address
	at io.aeron.driver.media.UdpChannelTransport.openDatagramChannel(UdpChannelTransport.java:127)
	at io.aeron.driver.media.ReceiveChannelEndpoint.openChannel(ReceiveChannelEndpoint.java:127)
	at io.aeron.driver.Receiver.onRegisterReceiveChannelEndpoint(Receiver.java:115)
	at io.aeron.driver.cmd.RegisterReceiveChannelEndpointCmd.execute(RegisterReceiveChannelEndpointCmd.java:32)
	at io.aeron.driver.Receiver.accept(Receiver.java:134)
	at io.aeron.driver.Receiver.accept(Receiver.java:36)
	at org.agrona.concurrent.OneToOneConcurrentArrayQueue.drain(OneToOneConcurrentArrayQueue.java:106)
	at io.aeron.driver.Receiver.doWork(Receiver.java:64)
	at org.agrona.concurrent.AgentRunner.run(AgentRunner.java:106)
	at java.lang.Thread.run(Thread.java:745)
Caused by: java.net.BindException: Cannot assign requested address
	at sun.nio.ch.Net.bind0(Native Method)
	at sun.nio.ch.Net.bind(Net.java:433)
	at sun.nio.ch.DatagramChannelImpl.bind(DatagramChannelImpl.java:691)
	at io.aeron.driver.media.UdpChannelTransport.openDatagramChannel(UdpChannelTransport.java:103)
	... 9 more

1 distinct errors observed.

thanks

The question then is why is a bind failing to that address on your machine?

Thanks
That's correct.
receiveDatagramChannel failed binding  to that address when subscriber.

So do you know what to do now to close the issue?

Ok
very thanks!

Sorry I don't know solution.
but, I try to fix it now.

Thanks,
I misunderstood.
In first machine.
Aeron.addPublication(aeron:udp?endpoint="second machine IP":40123, streamId);

and, I must write "endpoint="second machine IP" in second machine.
Aeron.addSubscription(aeron:udp?endpoint="second machine IP":40123, streamId);

Subscriber's endpoint is own IP.
It works correctly.
Thanks!!

That's it. :-)
Sorry I did not realise this is what you where doing earlier. Not using actual IP addresses or machine names threw me off.


Excluding vulnerability CVE-2023-20863 {patch}

Excluding known vulnerability, CVE-2023-20863, from scans from now. This will be fixed once Spring Boot uses the fixed dependency. The risk of DDOS is not considered to be problematic due to the intended use of Yippee-Ki-JSON.


including ComfyBlog

Is there a way to include the administration of other comfy plugins, like ComfyBlog? I installed the gem, but as cms-fortress is installed I can not access the "normal" CMS admin interface (which makes sense!)

Hi @mametz,
hm - I don't understand that in depth. cms-fortress itself is just a "extension" of Comfy. It comes with a extended layout but you can also choose the Comfy layout. But that would mean, that some cms-fortress features / functionalities are not viewable. cms-fortress is overwriting some Comfy views so maybe it is simple to include the Blog stuff there. Could you give it a try?
Cheers
Andy

I cant use default layout of Comfy not sure what is happening. Am I missing anything.

Hi @bhushangahire, you can refer the solution from here https://github.com/melvinsembrano/cms-fortress/issues/70
Cheers,
Melvin

@melvinsembrano you are so right ;-) +1

Thanks will try that today.

This works you can close this.


[Bug] sharp v0.30.0+ greyscale images with an embedded ICC profile change white pixels to dark grey

Possible bug
Is this a possible bug in a feature of sharp, unrelated to installation?

[x] Running npm install sharp completes without error.
[x] Running node -e "require('sharp')" completes without error.

If you cannot confirm both of these, please open an installation issue instead.
Are you using the latest version of sharp?

[x] I am using the latest version of sharp as reported by npm view sharp dist-tags.latest.

If you cannot confirm this, please upgrade to the latest version and try again before opening an issue.
If you are using another package which depends on a version of sharp that is not the latest, please open an issue against that package instead.
What is the output of running npx envinfo --binaries --system --npmPackages=sharp --npmGlobalPackages=sharp?
npx: installed 1 in 0.435s

  System:
    OS: Linux 5.13 Ubuntu 20.04.4 LTS (Focal Fossa)
    CPU: (32) x64 AMD Ryzen 9 5950X 16-Core Processor
    Memory: 9.07 GB / 15.59 GB
    Container: Yes
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 14.19.0 - /usr/bin/node
    npm: 6.14.16 - /usr/bin/npm

What are the steps to reproduce?

Download the image from this link, rename it to in.jpg
Convert ( resize ) in.jpg with the following snippet:

const sharp = require("sharp");

async function resizeImage() {
  try {
    await sharp("in.jpg")
      .resize({
        width: 480,
        height: 480
      })
      .toFile("out.jpg");
  } catch (error) {
    console.log(error);
  }
}

resizeImage();

Check the result ( out.jpg ), it should be something like this.

What is the expected behaviour?
You can see the image is filled with lots of grey area, tainting ( not sure if this is the right word ) the image. It should just resize the image instead of filling the image with grey area.
Notice that this happens after v0.30.0+ ( so both v0.30.0 & v0.30.1 suffered from this problem ), but not in the version before that. v0.29.3 does not have this problem, it can convert the image normally.
Please provide a minimal, standalone code sample, without other dependencies, that demonstrates this problem
( Check the "how to reproduce" section )
Please provide sample image(s) that help explain this problem
( Check the "how to reproduce" section )

Hi, thanks for reporting, I can reproduce with the supplied input image using sharp("in.jpg").toFile("out.jpg").
The input image is 8-bit greyscale with an embedded ICC profile that appears to be valid for such an image.
ColorSync color profile 2.1, type ADBE, GRAY/XYZ-prtr device by ADBE, 912 bytes, 3-6-1999 "Dot Gain 30%"

The input image undergoes an ICC transform via lcms (Little CMS) using its embedded profile, which is where things go wrong.
sharp v0.29.x provides lcms 2.12 whereas sharp v0.30.x provides lcms 2.13 so we're probably seeing the effects of the following upstream bug:
https://github.com/mm2/Little-CMS/commit/fdbfb7694f9d7048d53674b79ddfc38068bfdaf7
https://bugs.archlinux.org/task/73580
https://bugs.gentoo.org/832520

Commit https://github.com/lovell/sharp/commit/21a960796c769263e66f45f9ee1795d31be0272e temporarily ignores greyscale ICC profiles. We can revert this to re-introduce support later after we pick up a newer version of lcms with the upstream bug fix.

Created https://github.com/lovell/sharp/issues/3114 as a reminder to revert this temporary workaround later.

v0.30.2 now available with a quick fix for this, thanks again for reporting.


chore: Add retryable error handling to node termination

Fixes #N/A
Description
Add retryable error handling during the node termination handling
How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

6 of 6 (100.0%)  changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.04%) to 78.798%

Files with Coverage Reduction
New Missed Lines
%

pkg/test/expectations/expectations.go
2
95.59%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
8336

Relevant Lines:
10579

💛  - Coveralls

/lgtm