Make the server proxy's properties visible to static analysis

Currently, all properties of the server proxy object are created using Object.defineProperties in the constructor, which means that IDEs like VS Code can't analyze the file's static structure to determine what properties there are and what types they have.  Consequently, things like autocomplete and go-to-definition don't work.
Fix that by removing the ServerProxy class altogether and exporting an anonymous object with all properties defined statically.

Motivation and context

This makes viewing and editing API-adjacent code in VS Code easier. It also eliminates spurious "property not found" errors from VS Code.
How has this been tested?

Manual smoke testing.
Checklist

[x] I submit my changes into the develop branch
[ ] I have added a description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

@SpecLad , could you please resolve conflicts?
@bsekachev , could you please review?

I see a lot of refactoring here, can we split this PR into two separated?
Otherwise changes are not clear..

@bsekachev Hide whitespace changes, then it should be pretty obvious.


Implemented align method for Variable and Expression.

The purpose of this method is to align (and broadcast) an expression so that addition can take place. For instance
P_l_post_contingency = P_l_basecase.to_expr().align(P_contingency) + P_contingency

Thank you Kjartan, are there other use cases you've encountered for this or is it always as a way to add with another expression? Perhaps, broadcasting should automatically happen?

Like x.broadcast_like(y) + 4*y

Possibly, the proposed method implemented in this PR should have a more descriptive name. Like align_and_broadcast_like. Longer and uglier, but more descriptive, as stated.
Along the same line of thought, maybe the operation should be divided in two. Since one part is broadcasting, and the other is filter so that only coordinates of other are kept. The syntax would be
y.broadcast_like(x).filter_like(x)
On the other hand, this means doing the join operation with x.data twice.

I'm thinking:
y.broadcast("time").default(0) + someting_with_a_time_dim
and the broadcast() and default() only set flags on the y object that say we allow broadcasting in the time dimension and any missing indices are assumed to be 0 (i.e. we can auto fill them / ignore them). This way, the .join that happens with + can handle all the behaviour in one step.
Thoughts?

Sounds like a good solution for the issue of broadcasting!
Just to circle back to the original  motivation for the .align() method. The idea is that x.align(y) returns only the variables with coordinates  of x that are also present in y, so that fewer constraints result when doing
 m.c = (x.align(y) + y <= limit).
These extra constraints that would result from doing .broadcast()as you suggest @staadecker  are certainly valid constraints for the model in my case, it is just that they are already defined in the model.

Hmmm I see. I'm not a fan of the term "align" because it's really an xarray concept (which makes me think, maybe broadcast should be called add_dim). Perhaps instead of align a better way of doing things is:
# y has less indices than x so this would be an error:
# x + y ≤ limit

# But this works and has the shape of x
x + y.fill_missing() ≤ limit

# This also works and has the shape of y
x.drop_missing() + y ≤ limit

That's a great solution! It becomes very clear from the syntax what's happening.

See #17 instead


Prepare v0.2

Left to dos:

Add some more words to the README (i thought that might be better if you do that)
Add release notes (did I understand it correctly that you will do that)

I corrected a little language in the docs. Rearranged the getting started. Added a developers section. Adapted the R prerequisetes. Setup a new Readme with badges. Changed the pytests so that R stuff is no longer xfail since it should now run on every machine within our conda environment.

Re release notes: if possible, please add a document with headings in the root folder and link it to the docs so it is a section there. Thanks!

Re release notes: if possible, please add a document with headings in the root folder and link it to the docs so it is a section there. Thanks!

Done.

Are you waiting for anything from me?

Are you waiting for anything from me?

No, I just had not gotten around to doing anything. Looks great. I updated a couple of things and will need to write more. Feel free to add to the two sections of the README and additional points to the release notes, the next few days look pretty tight. Looking for a release towards the weekend or early next week.
Just curious: Are the R example things in the prerequisites section up to date?

Just curious: Are the R example things in the prerequisites section up to date?

Forgot to remove IVpack from that list. Everything else is still required.


feat: add LaTeX rendering command

Result:

Takes an input LaTeX expression (mandatory) and a bool indicating whether to use a transparent background (optional, false by default since light mode users will not be able to read the generated image, but it is useful for copy-pasting to other places).

Are there characters this can't handle? I tested with \int x dx = \frac{x^2}{2}+C (from this discord message you sent because I don't actually know latex) and got a nice lil discord api error (below).
Steps to reproduce:

run this PR's version of sage
do /latex \int x dx = \frac{x^2}{2}+C
profit

/Users/joshlyon/Documents/repos/SageV2/node_modules/discord.js/src/rest/RequestHandler.js:298
      throw new DiscordAPIError(data, res.status, request);
            ^

DiscordAPIError: Invalid Form Body
data.embeds[0].url: Not a well formed URL.
    at RequestHandler.execute (/Users/joshlyon/Documents/repos/SageV2/node_modules/discord.js/src/rest/RequestHandler.js:298:13)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async RequestHandler.push (/Users/joshlyon/Documents/repos/SageV2/node_modules/discord.js/src/rest/RequestHandler.js:50:14)
    at async CommandInteraction.reply (/Users/joshlyon/Documents/repos/SageV2/node_modules/discord.js/src/structures/interfaces/InteractionResponses.js:99:5) {
  method: 'post',
  path: '/interactions/938656865846456361/aW50ZXJhY3Rpb246OTM4NjU2ODY1ODQ2NDU2MzYxOkQ2TjcxeDlzRjRsTWdvOUNiWHFPek5MMmdZVHUyYlRzYjhnYWpyeGxIUkgzU2JHbWdqRGc0VnczUjJGZFV1M0ZmVGdRSlRPUTlLbEVadnNZWXRIQXgwb2VEeTRwNjYyQVU4RkYyYzFJRTlUSTRvMFFLSXFJVHozSHBSbTNYbXdt/callback',
  code: 50035,
  httpStatus: 400,
  requestData: {
    json: {
      type: 4,
      data: {
        content: undefined,
        tts: false,
        nonce: undefined,
        embeds: [
          {
            title: null,
            type: 'rich',
            description: null,
            url: 'https://latex.codecogs.com/svg.json?\\int xdx=\\frac{x^2}{2}+C',
            timestamp: 0,
            color: null,
            fields: [],
            thumbnail: null,
            image: [Object],
            author: null,
            footer: null
          }
        ],
        components: undefined,
        username: undefined,
        avatar_url: undefined,
        allowed_mentions: undefined,
        flags: undefined,
        message_reference: undefined,
        attachments: undefined,
        sticker_ids: undefined
      }
    },
    files: [
      {
        attachment: Buffer(2693) [Uint8Array] [
          137,  80,  78,  71,  13,  10,  26,  10,   0,   0,   0,  13,
           73,  72,  68,  82,   0,   0,   0, 130,   0,   0,   0,  48,
            8,   6,   0,   0,   0, 221,   1, 162, 131,   0,   0,   0,
            6,  98,  75,  71,  68,   0, 255,   0, 255,   0, 255, 160,
          189, 167, 147,   0,   0,  10,  58,  73,  68,  65,  84, 120,
          156, 237, 156, 121,  88, 212, 117,  30, 199,  95, 204,  48,
          131, 132,  10,  35, 163,  56,  12,  36,  12,  50,  32,  10,
          195, 112, 153, 233,  42, 151,  87, 101, 222, 150, 154, 149,
          109, 187, 249, 172,
          ... 2593 more items
        ],
        name: 'tex.png',
        file: Buffer(2693) [Uint8Array] [
          137,  80,  78,  71,  13,  10,  26,  10,   0,   0,   0,  13,
           73,  72,  68,  82,   0,   0,   0, 130,   0,   0,   0,  48,
            8,   6,   0,   0,   0, 221,   1, 162, 131,   0,   0,   0,
            6,  98,  75,  71,  68,   0, 255,   0, 255,   0, 255, 160,
          189, 167, 147,   0,   0,  10,  58,  73,  68,  65,  84, 120,
          156, 237, 156, 121,  88, 212, 117,  30, 199,  95, 204,  48,
          131, 132,  10,  35, 163,  56,  12,  36,  12,  50,  32,  10,
          195, 112, 153, 233,  42, 151,  87, 101, 222, 150, 154, 149,
          109, 187, 249, 172,
          ... 2593 more items
        ]
      }
    ]
  }
}

Interesting, I was pretty sure I tested that

yep encoding it as a URL fixes that


Add ability to include custom headers with requests

Summary
Add custom headers from the local config as key value pairs
Ticket Link
https://mattermost.atlassian.net/browse/MM-12673

@hmhealey changes made

Just used the new suggestion feature and it is amazing

@saturninoabril changes made

That's cool.  I'll use it next time.


Update list of SPI associated projects

I added DebConf because it's a special case but we'll get requests against DebConf.
I left Jenkins in there since they may want to spend down funds.


Adding color for current logged in Log section

It would be nice if my username is colored and highlighted like the first 3 places. I would suggest the color blue.
Example: if current user is craut then it could like

Done!


Adjustments to QuadSinkHdt

Looking at the HDT quad sink code, I figured it would be possible to reduce the amount of redundant functionality and to combine all the HDT-related code (including the Docker interaction) to the actor itself. The functionality is still the same.
Here is a PR with the following changes:

Move the pulling and running of the image to the actor itself from the separate utility source file, because it is HDT sink-specific and not usable elsewhere as it is.
Use the file paths generated by QuadSinkFile to track the source RDF files that need to be converted. This allows for the removal of all path mapping code from QuadSinkHdt.
Move the supported format check for rdf2hdt to the QuadSinkHdt constructor, so that unsupported formats will be caught immediately at the beginning, rather than the end of the fragmentation. The error will stop the fragmentation anyway, so it is better to do it as early as possible, I think.
Fix the Docker image tag to be rdfhdt/hdt-cpp, instead of the original rfdhdt/hdt-cpp (probably a typo?). The rdfhdt/hdt-cpp GitHub repository contains the Dockerfile that is used to build that image.
Add configuration options on the sink for index generation (the -i flag) and conversion progress printing (the -p flag) of rdf2hdt, to avoid having to have both on by default.

I have tested this with the master branch of SolidBench to make sure it works. Any feedback is welcome. :slightly_smiling_face: Especially from @constraintAutomaton as the original author of the sink.
The branch will need to be squashed before merge.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

38 of 38 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
925

Relevant Lines:
925

💛  - Coveralls

@rubensworks this should be ready for review, I think

Thanks @surilindur, good stuff!


Comment saved and appears twice

Notice that it created two comments, one automatic and one of the actual commenter.

solution ID from images: 22660

I think I found the problem. I didn't call the right task on done_checking route

@gal432 ; can you please issue a PR?

Not so much because I committed this directly to master. but let's follow if it happens again.

Marking as "solved" for now


Only supported by recent C# language versions

It is worth noting what specific C# versions 'private protected' is supported by.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ee5e6972-0f7a-8bb7-9f5a-0ba75909f9d8
Version Independent ID: 618c0361-38a0-4d6f-f46a-881db2e4b399
Content: private protected (C# Reference)
Content Source: docs/csharp/language-reference/keywords/private-protected.md
Service: dotnet-csharp
GitHub Login: @sputier
Microsoft Alias: wiwagn

private protected was added in C# 7.2

'private protected ' is giving an error when we are using both simultaneously.

@vikas304, private protected is available starting with C# 7.2. To use it, you have to have at least C# 7.2 installed, and you have to include the following in your .csproj file:
  <PropertyGroup>
   ...
   <LangVersion>latest</LangVersion>
  </PropertyGroup>

I hope that this helps.


The performance of OpenPCDet's piontpillars and SECOND

Anyone can answer me about the performance of OpenPCDet's piontpillars and SECOND when compared with https://github.com/traveller59/second.pytorch and https://github.com/nutonomy/second.pytorch in the same evaluation metric. it seems that they employed different evaluation tools.

Hi @sshaoshuai .  I need to confirm my comprehension on the two repos with you.
The mAP (Car@R11) of OpenPCDet's SECOND in KITTI is 78.62 and this mAP is for Moderate mode.
The mAP which was provided by SECOND（https://github.com/traveller59/second.pytorch）with (car.fhd.config + 160 epochs, 3D, Moderate) is 78.43.
It seems that the two repos' performance is very similar. Is this conclusion right?

Yes.

Yes.

Many thanks！


15-wip-enhancements

The following will be actioned in this iteration:

Addition of project
Improvements to 'Project' page
Renaming of 'Projects' to 'Portfolio'

The following changes have been made:

2 further projects added
Improvements to 'Project' page
Renaming of 'Projects' to 'Portfolio'

Ready for merge


Build SAM error on Apple silicon (arm64)

I try to follow up the SAM build instruction and got errors as below.
Wonder if any workarounds are available for this ? Btw, I just need Dview for ARM Mac but looks like all combine in one package build
SAM configure step: can't build nlopt-  make configure config.log
configure:2528: $? = 1
configure:2566: result: no
configure: failed program was:
| /* confdefs.h */
| #define PACKAGE_NAME "nlopt"
| #define PACKAGE_TARNAME "nlopt"
| #define PACKAGE_VERSION "2.4.2"
| #define PACKAGE_STRING "nlopt 2.4.2"
| #define PACKAGE_BUGREPORT<EMAIL_ADDRESS>| #define PACKAGE_URL ""
| /* end confdefs.h.  */
|
| int
| main ()
| {
|
|   ;
|   return 0;
| }
configure:2571: error: in `/Users/kcu/DevelopBuild/DviewARM/sam_dev/build/Release':
configure:2573: error: C compiler cannot create executables
See `config.log' for more details

If I try to run make the wex returns error **make: *** [all] Error 2
[ 63%] Building C object wex/src/CMakeFiles/wex.dir/plot/qhull/userprintf_rbox.c.o
2 warnings generated.
5 warnings generated.
[ 64%] Linking CXX static library ../../wex.a
[ 64%] Built target wex
make: *** [all] Error 2

Got SAM built on Apple silicon after a few cleanup and apply ENV at terminal level


Links in comment lead to 404

In my own personal project, as well as for this repo, the links in the comment (files and lines missing) lead to 404 pages:

In my "action" the real files of testing are missing by purpose.
This feature should work, you can see examples in other public repos like that
Can you provide me please a full example of which structure you have in your project?

This is the (relevant part of) the Github actions workflow:
    steps:
      # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
      - uses: actions/checkout@v2
      - name: Set up Python
        uses: actions/setup-python@v2
        with:
          python-version: '3.9'
      - name: General preparations
        # create empty source/backend/resources/bpmn folder necessary for running certain functionalities
        run: |
          cd source/backend
          mkdir -p resources/bpmn
          python -m pip install --upgrade pip
          pip install -r requirements.txt
      - name: Backend unit tests
        run: |
          cd source/backend
          export PYTHONPATH=. pytest
          pytest -v
          pytest --cache-clear --junitxml=pytest.xml --cov-report=term-missing:skip-covered --cov-config=unit-tests/.coveragerc --cov=. > pytest-coverage.txt
      - name: Comment unit test coverage
        if: ${{ github.event_name == 'pull_request'}}
        id: coverageComment
        uses: MishaKav/pytest-coverage-comment@main
        with:
          pytest-coverage-path: ./source/backend/pytest-coverage.txt
          junitxml-path: ./source/backend/pytest.xml
          junitxml-title: Backend Unit Test Summary
          title: Backend Unit Test Coverage Report (files with 100% coverage not shown)
          badge-title: Backend Unit Test Coverage

Maybe it is because the repo is private?

It's working on private repo also.
I think I know what is the problem. Can you provide me please the HTML comment of the pytest-coverage-comment output

Of course:

Backend Unit Test Coverage Report (files with 100% coverage not shown)

File	Stmts	Miss	Cover	Missing

app.py	39	39	0%	2–57

config.py	19	1	95%	9

create_app.py	22	22	0%	2–33

camunda

   client.py	23	15	35%	9, 19, 30–43, 52–55

instance_router

   instance_router_interface.py	16	9	44%	15, 25–26, 36–42

instance_router/private

   camunda_collector.py	17	11	35%	15–26

   controller.py	76	48	37%	33, 43–49, 58–59, 68, 79–85, 94–95, 109–111, 122–174

   rl_agent.py	81	54	33%	46–55, 66–78, 88, 101–123, 134–165

models

   batch_policy.py	65	25	62%	48–49, 95–101, 109–110, 119–123, 132–138, 147–149

   batch_policy_proposal.py	99	72	27%	36–41, 61–82, 98–115, 129–140, 160–177, 189–199, 211–221, 235–241, 251–265

   process.py	120	63	48%	79–105, 115–117, 126–132, 146–148, 162–170, 179, 188, 197, 209–214, 224–237

   process_instance.py	19	1	95%	33

   utils.py	21	5	76%	36–40

rest

   batch_policy.py	54	54	0%	2–83

   batch_policy_proposal.py	24	24	0%	2–48

   instance_router.py	90	90	0%	2–211

   meta.py	25	25	0%	2–35

   process.py	185	136	26%	74, 84, 93–98, 107–119, 137–154, 169–222, 231–235, 242–243, 253–267, 277–296, 308–320, 327–334, 344–378

   utils.py	3	1	67%	12

task_scheduler

   celery_app.py	27	27	0%	2–53

   config.py	2	2	0%	2–3

TOTAL	1029	724	30%

## Backend Unit Test Summary
| Tests | Skipped | Failures | Errors | Time |
| ----- | ------- | -------- | -------- | ------------------ |
| 14 | 0 :zzz: | 0 :x: | 0 :fire: | 1.896s :stopwatch: |

Can you check if this link points to the right file?
https://github.com/Ultimate-Storm/sbe_prototyping/source/backend/blob/fd5c17b15191cfb13bf065a24f977e337a73d5d6/app.py

No, it leads to a page just saying 'Not Found':

Thanks for your help and effort already, though!

can you send me a proper link to your file app.py?

Yes, this is the proper link, of the latest commit to the PR: https://github.com/Ultimate-Storm/sbe_prototyping/blob/fd5c17b15191cfb13bf065a24f977e337a73d5d6/source/backend/app.py
Ahhh, I see.. the source/backend/ is missing! It is probably because I run the action in root, and not in source/backend/, but the coverage file is created while being run in source/backend/?

I add some additional parameter (coverage-path-prefix) to support your case, can you please try my branch before I release this version?
- name: Comment unit test coverage
  if: ${{ github.event_name == 'pull_request'}}
  id: coverageComment
  uses: MishaKav/pytest-coverage-comment@links-in-comment
  with:
    pytest-coverage-path: ./source/backend/pytest-coverage.txt
    coverage-path-prefix: source/backend/
    junitxml-path: ./source/backend/pytest.xml
    junitxml-title: Backend Unit Test Summary
    title: Backend Unit Test Coverage Report (files with 100% coverage not shown)
    badge-title: Backend Unit Test Coverage

Awesome, I tested it and it works ✨ 🥳  Thanks so much!

The feature was released you can just run MishaKav/pytest-coverage-comment@main or use<EMAIL_ADDRESS>Thank you.


Fix Travis build

This includes a change that makes it easy to download the actual and expected images locally - basically there will now be a script printed in the log in case of failure that when copied/pasted locally will allow the actual and expected images to be re-generated (rather than trying to reproduce the exact same failure locally).

Example script from this run:
################################################################################
# Export the images that were generated in the continuous integration for pywwt.
# Just copy and paste all the code between here and '# End of script' into a
# local file and run it with Python. You can then check if the differences
# make sense, and if so, update the expected images.
import base64
expected = base64.b64decode('iVBORw0KGgoAAAANSUhEUgA...')
with open('expected.png', 'wb') as f:
    f.write(expected)
actual = base64.b64decode('iVBORw0KGgoAAAANSUhEUgAAAZAAAAGQ...')
with open('actual.png', 'wb') as f:
    f.write(actual)
# End of script
################################################################################

(I truncated the long strings)
And images generated:
Expected

Actual

This shows the planets are now real-size and the crosshair is gone.

I'm going to merge this since it just adds a diagnostic tool


Grow Lancer not added

Grow Lancer is not by default added to the Web Engine <3

Grow Lancer and Mirage Lancer support was added on the <IP_ADDRESS> release. Are you on a lower version?

yup, sorry <IP_ADDRESS> c: im updating now, thanks


Adding smooth theme toggle transition

The current theme transitions abruptly while changing themes. I want to add a smooth transition effect while toggling between light and dark modes.
The new smooth transition effect will look somewhat like this

The current theme transitions abruptly while changing themes. I want to add a smooth transition effect while toggling between light and dark modes.
The new smooth transition effect will look somewhat like this

Use the same button which is shown in the design which you have mentioned.


[BUG] Empty array inputs are not respected by the validator.

Describe the bug
Given an input definition that has an item of type array that's marked required, the validator fails the input when given an empty array. Even when the minItems is set to 0. Empty arrays should be valid inputs unless specified otherwise.
To Reproduce
Steps to reproduce the behavior:

Define an input object with one more property as required arrays.
For example

type: object
required:
- items
properties:
  items:
    type: array
    items:
      type: string

Expected behavior
An empty array should pass the validation
For example, given the following input:
{
    "items":[]
}

Should pass the validation.

Request parameter or request body.
Could you provide a fuller snippet so i can replicate the issue?

Request body

Ah i see..
This originates here: https://github.com/acrontum/generate-it/blob/master/src/lib/helpers/SwaggerUtils.ts#L64
Based on the definition here: https://swagger.io/docs/specification/data-models/data-types/#array-length
If the type is array and no items passed but no minItems attr in the api file it should pass.


² key should apply power of two instead of acting as a character

The ² key is on AZERTY keyboard (top left).
Pressing it should apply a power of two (with the cursor not in the power).

Could you include a picture of which key you're talking about?

event.key : ²
event.which : 222
event.code : Backquote

OK, thanks. It's not a super common key, but this layout apparently exists on some Windows and Linux PCs.

OK, I've checked in a fix, but I unfortunately have no way of testing it...
8a48bc4d49657e54caf3b6b0a0355da530a8ad16

This works, thanks !


Create room logic

Q
A

Is bugfix?
No

New feature?
Yes

Fixed issues

This features implements the logic of room and the behavior of components within it.

Review Required !


Wires crossed with CachedQuery data objects

I am running into a strange scenario where the data in a cached query looks like (but is oddly not an instance of) Ember.Object.  It has getters and setters and meta properties just like an Ember.Object.  I am noticing this specifically in the mutation handler currentResponse param:

CachedQuery objects are internal to cashay so I am astonished that I am seeing something that looks like Ember.Object.
I am investigating where this overlap is occurring.  I assume the problem is on my end, but I noticed this line in the action project which made me think there might be a larger issue here.

That's really weird! I can't comment since cashay doesn't do any ember
stuff but I'd you figure it out lemme know
On Dec 4, 2016 2:05 PM, "Dustin Farris"<EMAIL_ADDRESS>wrote:

I am running into a strange scenario where the data in a cached query
looks like (but is oddly not an instance of) Ember.Object. It has getters
and setters and meta properties just like an Ember.Object. I am noticing
this specifically in the mutation handler currentResponse param:
https://camo.githubusercontent.com/032a2b00912316e2d39f31495e466e25e0a6ce02/68747470733a2f2f7777772e64726f70626f782e636f6d2f732f7868687a376a646471706f326368632f53637265656e73686f74253230323031362d31322d303425323031372e30342e31362e706e673f646c3d31
CachedQuery objects are internal to cashay so I am astonished that I am
seeing something that looks like Ember.Object.
I am investigating where this overlap is occurring. I assume the problem
is on my end, but I noticed this line in the action project
https://github.com/ParabolInc/action/blob/47e3310bd14b9896ab163e19dc0731d23cd61aaf/src/universal/modules/summary/containers/MeetingSummary/MeetingSummaryContainer.js#L46
which made me think there might be a larger issue here.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mattkrick/cashay/issues/144, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFQjv3Y5X8BT0wAeagoIJ3FpVCGP-J2zks5rEzlBgaJpZM4LDtvX
.

I think I figured this out.
In my stateToComputed (our version of stateToProps in react-redux), I do this:
stateToComputed = (state, { projectId }) => {
  const { data: { project } } = cashay.query(projectQuery, { variables: { projectId } });
}

I think I figured this out.
In my stateToComputed (our version of stateToProps in react-redux), I do this:
stateToComputed = (state, { projectId }) => {
  const { data: { project } } = cashay.query(projectQuery, { variables: { projectId } });
  return { project };
}

With project now available as a computed property, I can use it in the template:
{{project-detail project=project}}

As soon as I pass it as an attr to another component like this, Ember "binds" it which involves transforming the project object into one that signals Ember whenever it changes.  It does this by adding meta data, adding getters and setters—basically hi-jacking the POJO.  This affects redux state!
It seems the only way around this is to deep copy the data before returning it in stateToComputed, e.g.:
  const { data: { project } } = cashay.query(projectQuery, { variables: { projectId } });
  return {
    project: jQuery.extend(true, {}, project)
  };

I am going to open an issue in ember-redux to address this.

oh wow, i didn't know ember worked like that! yeah, the redux state should be immutable, so if ember is going to try & mutate it, you'll wanna put something between the redux state & the view layer, otherwise you'll end up having to deep copy an object on every re-render which will get expensive.


Fix+remove ignored IceCap tests

Follow-up to https://github.com/veracruz-project/veracruz/pull/367
This PR will be updated to fix the tests that were failing, only in CI, for unknown reasons

The IceCap CI is stuck until timeout.

Yet runs just fine locally... very confusing...

Presumably this will run fine once #428 is merged?

Will resurrect this once https://github.com/veracruz-project/veracruz/pull/447 is merged, https://github.com/veracruz-project/veracruz/pull/447 was likely the source of these failures.


Make form elements inherit more font properties

By default, browsers apply a bunch of default font-related properties to form elements that take precedence over styles defined on the parent element.
Since Tailwind encourages you to implement designs using a constrained system, this can be a bit of a pain point and lead to accidentally leaving in user agent styles that aren't part of your design system, like the text in inputs being full-on black, or buttons having a slightly different line-height than normal text.
Normalize.css (which we use as the base for our Preflight styles) corrects a lot of these inconsistencies:
/**
 * 1. Change the font styles in all browsers.
 * 2. Remove the margin in Firefox and Safari.
 */

button,
input,
optgroup,
select,
textarea {
  font-family: inherit; /* 1 */
  font-size: 100%; /* 1 */
  line-height: 1.15; /* 1 */
  margin: 0; /* 2 */
}

...but doesn't touch color or font-weight, as that would be a bit too opinionated for what Normalize is trying to do.
This PR makes all form elements inherit color, font-weight, and line-height so that it's much harder to accidentally introduce styles that deviate from your design system.
That way if you don't override any of those values on a form element with a utility, at least the default value will be something specified in your system (assuming you have added some base styles to the html or body tag).
Put another way, this PR tries to make sure that a form element with a given list of utilities applied to it looks exactly the same as a span would look with the same utilities.

I'm totally on board, and I would go even further. As it is now, this PR doesn't let form elements inherit the following properties by default (while a span would):

font-style
font-variant
text-align
letter-spacing
text-transform

Maybe they're not as important/needed, but IMO we should go all the way or not at all. Note that the first two properties of that list could be taken care of by setting the font shorthand to inherit, but maybe it's better to be explicit?

I checked earlier if any of the stylesheets @CvX shared on #738 were setting letter-spacing in any way and it looks like they're not.
I really don't why it was on my reset stylesheet so maybe we don't need all of those?

We do need them, I tested earlier. Although just to be sure, I tested in other browsers and Firefox seems to inherit some properties on <button>s by default, but I'm pretty sure it's a bug because they do it for text-transform and letter-spacing but not for font or color...

Perfect. Then imo we should use the explicit properties instead of the shorthand (although I was the one using the font on my reset). From experience, shorthands are never a good idea because not everyone know how many nor which properties are being set when using them.
The only issue with not using them could be file size which would not really be an issue after using most CSS minifiers (they use shorthand properties to reduce the ammount of characters in your styles). This could also not be an issue due to string repetition with gzip or brotli compression, so… 🤷♂

Then imo we should use the explicit properties instead of the shorthand (although I was the one using the font on my reset). From experience, shorthands are never a good idea because not everyone know how many nor which properties are being set when using them.

Yeah I agree!

Good suggestions so far, copying over @benface's reset from the other issue too:
 button,
 input,
 textarea,
 select {
     margin: 0;
     padding: 0;
     border-radius: 0; /* for iOS */
     background-color: transparent;
     font: inherit;
     color: inherit;
     text-align: inherit;
     text-transform: inherit;
     letter-spacing: inherit;
 }

I think these styles make a lot of sense if we really want buttons and inputs to essentially act like spans (although maybe there's a good argument for why they shouldn't?) Thoughts on moving ahead with this whole reset (but split into individual properties)?

Just pushed an update with the following reset styles:
button,
input,
optgroup,
select,
textarea {
  padding: 0;
  border-radius: 0;
  background-color: transparent;
  font-weight: inherit;
  line-height: inherit;
  color: inherit;
  font-style: inherit;
  font-variant: inherit;
  text-align: inherit;
  text-transform: inherit;
  letter-spacing: inherit;
}

Thoughts @benface and @hacknug?

@adamwathan I don't understand what styling optgroup does, but other than that, looks great!

After a lot of discussion in Discord and some input from @jackmcdade I've decided to lighten up on this reset a bit and just focus on the things that are actually annoying:
button,
input,
optgroup,
select,
textarea {
  padding: 0;
  line-height: inherit;
  color: inherit;
  background-color: transparent;
}

The only property I removed that feels a little iffy is font-weight, as technically now your buttons/inputs could be using a font weight (normal/400) that isn't in your design system. I decided I am comfortable with this because anyone intentionally avoiding using the normal font weight for their entire site probably won't be surprised that they have to override that on form elements. They also would have had to do that already for the last 18 months that Tailwind has existed, so whatever, this is still a little more helpful.

Upon even more thinking, I've decided to remove background-color: transparent as it's a bit of an annoying breaking change for anyone who was relying on inputs being white by default, and I don't think it's that unreasonable to have to make an input explicitly transparent when that's the behavior you want.
  button,
  input,
  optgroup,
  select,
  textarea {
    padding: 0;
    line-height: inherit;
    color: inherit;
-   background-color: transparent;
  }

Buttons are still transparent by default thanks to an earlier rule in Preflight, which we will keep because no one ever depends on the default user agent button background color, and it's very common to use a button for something that doesn't have a solid background.


TypeError: Cannot read property 'DEFAULT_FORMAT' of undefined

I am getting this error  when I try to load the page where dual ListBox is expected to show:
EXCEPTION: Uncaught (in promise): TypeError: Unable to get property 'DEFAULT_FORMAT' of undefined or null reference.

Can you please provide a code example with enough details to reproduce it?

Unpronounceable.


Fix NoWarn tag

Current coverage is 61.41%

Merging #85 into portable-3.0 will not affect coverage as of 90824c7

@@            portable-3.0     #85   diff @@
============================================
  Files                 52      52
  Stmts               2325    2325
  Branches             198     198
  Methods                0       0
============================================
  Hit                 1428    1428
  Partial               31      31
  Missed               866     866

Review entire Coverage Diff as of 90824c7

Powered by Codecov. Updated on successful CI builds.


Generating training data for new tools

I would like to generate SFT data for a custom tool, but can't seem to find anything specific related to data generation in the repo. While I can grasp the general paradigm of the data creation process that you followed, there is some confusion about the specifics. Will you release the data generation pipeline or give a more concrete, step-by-step showcase of the SFT data generation? Thanks!
Also, keep up the great work - really looking forward to seeing where this will go.

Hi!  Thanks for your interests in our ToolBench, we've uploaded an early version of data generation codes at here. Though the codes are a bit messy, you can refer to them for building a new tool.
And yes! ToolBench will get a very huge update in the next month.

Thank you so much! I will definitely be following the project


Fixes some small UI touchups/issues for new ISM UI

Description

Moves edit button from the policy settings content panel to the page
Updates transitions to not include a conditions object by default as the backend throws an error if you pass it an empty conditions object
Makes all inputs in flyouts full width
Updates retry help text
Adds some extra spacing between inputs
Adds back X icon next to Cancel in state flyout
Fixes missing punctuation
Removes default ISM template and increases width of empty prompt message
Moves action/transition flyout secondary button (cancel) to be next to primary button

Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #85 (1d81b54) into main (d23f65a) will decrease coverage by 0.11%.
The diff coverage is n/a.

:exclamation: Current head 1d81b54 differs from pull request most recent head 71e503f. Consider uploading reports for the commit 71e503f to get more accurate results

@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   49.83%   49.72%   -0.12%
==========================================
  Files         154      154
  Lines        4328     4328
  Branches      662      663       +1
==========================================
- Hits         2157     2152       -5
- Misses       2014     2018       +4
- Partials      157      158       +1

Impacted Files
Coverage Δ

...atePolicy/components/ISMTemplates/ISMTemplates.tsx
28.57% <0.00%> (-21.43%)
:arrow_down:

...tails/components/PolicySettings/PolicySettings.tsx
53.84% <0.00%> (-4.98%)
:arrow_down:

...Details/containers/PolicyDetails/PolicyDetails.tsx
9.23% <0.00%> (-0.45%)
:arrow_down:

...public/pages/VisualCreatePolicy/utils/constants.ts
100.00% <0.00%> (ø)

...atePolicy/containers/CreateAction/CreateAction.tsx
70.83% <0.00%> (ø)

...tePolicy/components/UIActions/RolloverUIAction.tsx
50.00% <0.00%> (ø)

...tePolicy/components/UIActions/SnapshotUIAction.tsx
5.88% <0.00%> (ø)

...Policy/components/UIActions/ForceMergeUIAction.tsx
10.52% <0.00%> (ø)

...licy/components/UIActions/ReplicaCountUIAction.tsx
57.89% <0.00%> (ø)

...icy/components/UIActions/IndexPriorityUIAction.tsx
10.52% <0.00%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d23f65a...71e503f. Read the comment docs.


Add support for XLOOKUP formula in OpenXML SDK

** Description **
Please add support for XLOOKUP formula parsing and calculation in Strict Open XML XLSX file output
Information

.NET Target: All
DocumentFormat.OpenXml Version: 2.17.1

Repro
Example formula
=XLOOKUP(A1, A3:A5, B3:B5)

Observed
Lookup is not calculated in XLSX output

Expected
Support for formula syntax
=XLOOKUP(lookup_value, lookup_array, return_array, [if_not_found], [match_mode], [search_mode])

@tauheedul, can you be (much) more specific about what you are trying to achieve? For example, do you want the Open XML SDK to compute the result of the XLOOKUP function? That would go beyond the scope of this library.

@tauheedul, can you be (much) more specific about what you are trying to achieve? For example, do you want the Open XML SDK to compute the result of the XLOOKUP function? That would go beyond the scope of this library.

Hello @ThomasBarnekow The OpenXML SDK should be able to read the calculated output of the XLOOKUP function when parsing the document in .NET. I believe it is possible to read the output of a VLOOKUP with Open XML.
This request is to extend the capability to include XLOOKUP
Thank you.

@tauheedul,
The SDK doesn't currently compute any formulas. I think what's happening is that there is a problem with the formula in your first case. I tested this out and if I provide unique values for A3-A5 (versus all being 10001), the sheet opens with the value "TEST1" filled in. Also, I assume you're not providing the  element under the  element in the C1 cell markup. That's ok but if you want the previously calculated (by Excel) value, you would have to include that  element. Like this:
      <c r="C1" s="1" t="str">
        <f>_xlfn.XLOOKUP(A1, A3:A5, B3:B5)</f>
        <v>something</v>
      </c>

Basically, whatever you provide there will be displayed until you select the C1 cell and hit enter or otherwise cause Excel to re-evalutate the formula.
But I believe the problem is that the formula was not able to operate properly given the input table.
Let me know if this helps.

Hello @tomjebo thank you. Your comments have been helpful. I will close this request.


DuckDNS Add On instructions are incomplete

There are a couple of areas that the novice user (e.g. me) doesn't appreciate when configuring the DuckDNS add-on:

You need to update configuration.yaml with content similar to:
http:
ssl_certificate: /ssl/fullchain.pem
ssl_key: /ssl/privkey.pem
base_url: https://.duckdns.org

You need to add port-forwarding rules to your router to allow 443 to forward to 8123

It was only through lots of research and some Discord conversations that I worked out what I had to do. So I suggest adding this information to the instructions.

It isn't that simple. Yes, you are correct, but there are many other methods.
E.g., personally, I would recommend using a reverse proxy (like the NGINX proxy add-on). That removes the configuration part for HA.
Furthermore, the port used, is a personal choice. Home Assistant uses port 8123 by default. Changing it to 443 is not a requirement for SSL to work.

Then how explaining what some of the options are?
My point is that in its current state, the page leads the reader to believe that if you follow these instructions then you will have remote access. And that isn't the case.
So adding some more information would aid adoption.
What do you think?

I think this add-on provides DuckDNS with a Let's Encrypt certificate.
In general, add-ons provide services and do not affect Home Assistant.
Setting up SSL with Home Assistant is, in my opinion, more a place for the Home Assistant documentation.

agree to both, the current instructions are not sufficient for RA + DuckDNS addon docu is not the perfect place for describing the setup
As a general starting point securing is fine but points to letsencrypt.
I'd suggest extending the securing docu with a tiny overview above both approaches ( letsencrypt +nginx)would be beneficial, but it's another repo

Contributions to the documentation are always welcome 👍
But the purposed suggestion here does not fit in the addon documentation.
This addon updates the IP for the duckdns domain and can produce and update SSL certificates.
The possibilities of what you use those for are endless.

Contributions to the documentation are always welcome 👍
1st step - https://github.com/home-assistant/home-assistant.io/pull/13410

@willidh74 Please check https://github.com/home-assistant/hassio-addons/blob/master/duckdns/DOCS.md;  from my pov nginx could be mentioned there


DF-630: Add skos_id fields for entities that map to official categories

Ticket URL: https://national-archives.atlassian.net/browse/DF-630
About these changes
As per the conversation on the ticket, a common SKOS reference exists for certain taxonomies. Since we are planning on sending data about pages directly to the API soon, and the API uses the ids from this SKOS reference, we want to provide those same IDs to the API.
Thankfully, the format is pretty simple and the values can be generated pretty much straight from existing names/titles.
How to check these changes
A skos_id value should be set for all existing ArticleTag and TopicExplorerPage objects, and creating new objects of that type via the Wagtail admin should generate a unique skos_id value automatically to prevent validation errors.
Before assigning to reviewer, please make sure you have

[x] Checked things thoroughly before handing over to reviewer.
[x] Checked PR title starts with ticket number as per project conventions to help us keep track of changes.
[x] Ensured that PR includes only commits relevant to the ticket.
[x] Waited for all CI jobs to pass before requesting a review.
[x] Added/updated tests and documentation where relevant.

Merging PR guidance
Follow docs\developer-guide\contributing.md
Deployment guidance
Follow docs\infra\environments.md

@ababic , there are some codecov lines mentioned what can be done about it?
Ex:
etna/collections/models.py#L192
Added line #L192 was not covered by tests

Thanks for the review Allan. The codecov lines can be ignored, as this PR hasn't added them (only moved them).
Some of that code has just been removed in #846, so codecov will likely shut up after a rebase :)


Support Margin Position

Can we support consistent API for margin position?

Merging this feature request with this existing one: https://github.com/timmolter/XChange/issues/1231


graphql-php v15

We have 23 test errors after bumping webonyx version
https://github.com/thecodingmachine/graphqlite/issues/540

@oojacoboo Minimum supported php version for ecodev/graphql-upload is ^8.1. But we have continuous integration for php 8.0

Other test errors I will try to fix by myself

There was a bunch of breaking changes.
Finally, all php >8.0 tests passed. Please review a PR !

Dropped 8.0 tests.  I'll review the rest of the PR soon.

Does it means we drop support for php 8.0? So we can use all range of php 8.1 features from now

Yes, we'd basically be dropping 8.0 support and only supporting >=8.1 with this PR.  However, I am wondering why ecodev/graphql-upload has minimum 8.1 support.
Also, I didn't check.  What were the test errors surrounding 8.0?

Also, I didn't check.  What were the test errors surrounding 8.0?

composer install failed so I did not run tests in php 8.0 enviroment.

While I was working for this and previous PR I felt a huge lack of native PHP intersection types. Many docblocks and assertions can be dropped with php 8.1.
With all range of php 8.1 features debugging codebase would be much simpler and I believe graphqlite will evolve much faster.
In my opinion it's worth to drop support for php 8.0 now in any case.


Fix ballerina lang issue 15254

Purpose

This is to fix https://github.com/ballerina-platform/ballerina-lang/issues/15254.

Fixes #
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, releated PRs, TODO items or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #15539 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #15539   +/-   ##
=========================================
  Coverage     26.38%   26.38%
  Complexity      123      123
=========================================
  Files            92       92
  Lines          2172     2172
  Branches        338      338
=========================================
  Hits            573      573
  Misses         1502     1502
  Partials         97       97

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46441ff...73ac0f5. Read the comment docs.


show that the intersection of k[X^-1] and k[X] in k[X][X^-1] is only k

Two different approaches seem possible:
(1) "By comparing coefficients in R[X]":
Consider the involution f : R[X][X^-1] --> R[X][X^-1]. We want to show that every polynomial p(X) which is invariant under f is constant. Let p(X) be of degree at most m. Then reversing the m+1 coefficients of p(X) yields a new polynomial q(X) of degree at most m such that X^m p(X^-1) = q(X) in the ring R[X][X^-1]. (This might be nasty?) Then X^m p(X) = q(X) in R[X], and we can compare coefficients to see that p is constant.
(2) "By comparing coefficients in R[X][X^-1]":
Show that the underlying type of R[X][X^-1] is the type of merely-finite-support functions Z --> R. Show that the involution f : R[X][X^-1] --> R[X][X^-1] is induced by flipping Z. (Is this hard?) Then the claim follows by comparing coefficients of p(X) and p(X^-1).

About (2): We just fantasized that it might be best to construct general monoid rings and prove things about them first. (The monoid ring of a localization of a monoid M is a certain localization of the monoid ring of M).

construct general monoid rings

Actually, monoid rings of discrete monoids... This is where the construction using "functions with merely finite support" works. In an arbitrary monoid ring you can not "lookup coefficients".

I just realized a notable alternative: Instead of comparing coefficients in R[X][X^-1], we can also compare coefficients in R[X][Y], which should be a lot easier, but then we have to conclude, that for P in R[X] and Q in R[Y], any S in R[X][Y] such that
P-Q = S (XY-1)
we get S=0. Then the result follows from: The intersection of R[X] and R[Y] in R[X][Y] is R.


Fetch user email from id_token

This adds support for the inconsistent Apple oauth account email handling.
Depending on whether an Apple user signed up for an app previously or it is the first sign up the email is in different places of the response.
As mentioned in the API docs "Apple provides the user’s email address in the identity token on all subsequent API responses" - while the email + name are only included plainly in the response params of the first signup request (that's where ueberauth_apple fetches them from right now).
This can lead to weird behaviour, e.g. when the first signup response is not received due to network issues - in order to give a more consistent experience, this PR sets the email from the id_token as well.

As mentioned in the API docs "Apple provides the user’s email address in the identity token on all subsequent API responses"
Turns out: This is not true. In case the user has revoked email forwarding, the email parameter is still not included (which kind of makes sense, would be awesome if this detail was actually documented there)
This should not make a difference for this PR however, since for the initial signup, the email should always be present 🤞

Hi there 👋🏼
This project recently changed maintainers (you can find the new canonical repository here). We just released version v0.6.0 with the unreleased stuff from v0.5.0 as well as some other fixes and features. It might cover your proposed changes here. If not, please feel free to open a new PR on the other repository!
Cheers 🎉


Correctly find vineyard package on Debian with multiarch support

What do these changes do?
Fixes CI failed on GraphScope
Follow CMAKE Doc

LIBDIR: object code libraries (lib or lib64)
On Debian, this may be lib/multiarch-tuple when CMAKE_INSTALL_PREFIX is /usr

I'm not sure whether has a better way to fix it. Welcome any comments.

Related issue number

Refer folly and cmake


Add jar builder

closing because to get multi arch builds i'll need to put mvn and other java build tool on the pi and i dont feel like maintaining that. going to try to do what i want inside docker


Add a Mixer integration test for testing K8s integration.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS [ozevren]
tests/integration/OWNERS [ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-lint.sh
9dea1b6d492b5c0b9813b632275d80271be100c3
link
/test istio-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-lint.sh
272909e2d27295a864f645b74254b35798a4ab5b
link
/test istio-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-lint.sh
272909e2d27295a864f645b74254b35798a4ab5b
link
/test istio-lint-master

prow/integ-mixer-k8s-presubmit-tests.sh
272909e2d27295a864f645b74254b35798a4ab5b
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ozevren
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS
pkg/OWNERS [ozevren]
tests/integration/OWNERS [ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm
On Thu, Jun 20, 2019 at 4:03 PM Ozben Evren<EMAIL_ADDRESS>wrote:

@ozevren commented on this pull request.
In tests/integration/mixer/k8s/k8s_test.go
https://github.com/istio/istio/pull/15039#discussion_r296044767:

cfg := istio.DefaultConfigOrFail(ctx, ctx)

cfg.Values["global.useMCP"] = "false"

cfg.Values["galley.enabled"] = "false"

cfg.SkipWaitForValidationWebhook = true

_, err := istio.Deploy(ctx, &cfg)

if err != nil {

	t.Fatalf("Unexpected error: %v", err)

}

env := ctx.Environment().(*kube.Environment)

// Ensure that we can loop-through at least ten times while all pods in the ready.

for i := 0; i < 40; i++ {

	if _, err := env.CheckPodsAreReady(env.NewPodFetch(cfg.IstioNamespace)); err != nil {

		t.Fatalf("Error waiting for pods: %v", err)

Most of the initial crash loops are accounted in the original istio
deployment pod readiness checks. The gateway readiness is generally the
long pole.
Still added more resiliency.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/15039?email_source=notifications&email_token=ACIYRRQ2RN5RGBJKH7TPXXDP3QEDTA5CNFSM4HZ6MPA2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4HARKQ#discussion_r296044767,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACIYRRXQIVT5OCSSBWIDIWDP3QEDTANCNFSM4HZ6MPAQ
.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kyessenov, ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [kyessenov]
pkg/OWNERS [ozevren]
tests/integration/OWNERS [ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
272909e2d27295a864f645b74254b35798a4ab5b
link
/test integ-mixer-k8s-presubmit-tests-master

prow/istio-lint.sh
f400ea0c3fbcdb0954689c861151edb67e8430d7
link
/test istio-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
272909e2d27295a864f645b74254b35798a4ab5b
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e_pilotv2_auth_sds.sh
c19c6777189419b2b1f31352fb89fba14a447df9
link
/test istio_auth_sds_e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
272909e2d27295a864f645b74254b35798a4ab5b
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e_pilotv2_auth_sds.sh
c19c6777189419b2b1f31352fb89fba14a447df9
link
/test istio_auth_sds_e2e-master

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
c19c6777189419b2b1f31352fb89fba14a447df9
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kyessenov, ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS [ozevren]
tests/integration/OWNERS [ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
272909e2d27295a864f645b74254b35798a4ab5b
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e_pilotv2_auth_sds.sh
c19c6777189419b2b1f31352fb89fba14a447df9
link
/test istio_auth_sds_e2e-master

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
c19c6777189419b2b1f31352fb89fba14a447df9
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
272909e2d27295a864f645b74254b35798a4ab5b
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e_pilotv2_auth_sds.sh
c19c6777189419b2b1f31352fb89fba14a447df9
link
/test istio_auth_sds_e2e-master

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
c19c6777189419b2b1f31352fb89fba14a447df9
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test integ-pilot-k8s-presubmit-tests-master

prow/e2e-simpleTests.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
272909e2d27295a864f645b74254b35798a4ab5b
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e_pilotv2_auth_sds.sh
c19c6777189419b2b1f31352fb89fba14a447df9
link
/test istio_auth_sds_e2e-master

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
c19c6777189419b2b1f31352fb89fba14a447df9
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test integ-pilot-k8s-presubmit-tests-master

prow/e2e-simpleTests.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test e2e-simpleTests-master

prow/racetest.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test istio-racetest-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
272909e2d27295a864f645b74254b35798a4ab5b
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e_pilotv2_auth_sds.sh
c19c6777189419b2b1f31352fb89fba14a447df9
link
/test istio_auth_sds_e2e-master

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
c19c6777189419b2b1f31352fb89fba14a447df9
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test integ-pilot-k8s-presubmit-tests-master

prow/e2e-simpleTests.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test e2e-simpleTests-master

prow/racetest.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test istio-racetest-master

prow/istio-pilot-multicluster-e2e.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test istio-pilot-multicluster-e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
272909e2d27295a864f645b74254b35798a4ab5b
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e_pilotv2_auth_sds.sh
c19c6777189419b2b1f31352fb89fba14a447df9
link
/test istio_auth_sds_e2e-master

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
c19c6777189419b2b1f31352fb89fba14a447df9
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test integ-pilot-k8s-presubmit-tests-master

prow/e2e-simpleTests.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test e2e-simpleTests-master

prow/racetest.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test istio-racetest-master

prow/istio-pilot-multicluster-e2e.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test istio-pilot-multicluster-e2e-master

prow/integ-security-local-presubmit-tests.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test integ-security-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests-master

/test integ-security-local-presubmit-tests-master

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
c19c6777189419b2b1f31352fb89fba14a447df9
link
/test istio_auth_sds_e2e-master

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
c19c6777189419b2b1f31352fb89fba14a447df9
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test integ-pilot-k8s-presubmit-tests-master

prow/e2e-simpleTests.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test e2e-simpleTests-master

prow/racetest.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test istio-racetest-master

prow/istio-pilot-multicluster-e2e.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test istio-pilot-multicluster-e2e-master

prow/integ-security-local-presubmit-tests.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test integ-security-local-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
c19c6777189419b2b1f31352fb89fba14a447df9
link
/test istio_auth_sds_e2e-master

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
c19c6777189419b2b1f31352fb89fba14a447df9
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test integ-pilot-k8s-presubmit-tests-master

prow/racetest.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test istio-racetest-master

prow/istio-pilot-multicluster-e2e.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test istio-pilot-multicluster-e2e-master

prow/integ-security-local-presubmit-tests.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test integ-security-local-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test integ-security-k8s-presubmit-tests-master

prow/e2e-simpleTests.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test integ-pilot-k8s-presubmit-tests-master

prow/racetest.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test istio-racetest-master

prow/istio-pilot-multicluster-e2e.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test istio-pilot-multicluster-e2e-master

prow/integ-security-k8s-presubmit-tests.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test integ-security-k8s-presubmit-tests-master

prow/e2e-simpleTests.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test e2e-simpleTests-master

prow/integ-security-local-presubmit-tests.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test integ-security-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests-master

/test integ-security-local-presubmit-tests-master

Can I get another lgtm?

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kyessenov, nmittler, ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS [nmittler,ozevren]
tests/integration/OWNERS [nmittler,ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/test istio-racetest-master

/test istio-racetest-master

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test integ-pilot-k8s-presubmit-tests-master

prow/istio-pilot-multicluster-e2e.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test istio-pilot-multicluster-e2e-master

prow/integ-security-k8s-presubmit-tests.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-unit-tests.sh
0bf5972b2bde24e9e03f0304eb1a891ce160d50c
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests-master


New partners-with variants

Doctor's companion
Best friends forever
Some new "normal" partners-with
Maybe more

Oh, but none of them matter because they can't appear at C or U.

With recent changes, these clutter up the card fetch logs. We should enumerate the cases and ignore them.


Custom background

@BlindSanji can you please provide more information about what your issue is? Where do you expect a custom background?


Error when consuming more messages that exist in topic

Steps to reproduce:

Create a Reader with offset 10
Last offset of the topic is 13
I want to consume 10 messages

Expected result
I just get 3 messages back, as are the ones that exist in the topic
Actual result
I get the 3 messages back but I have an error I can't even catch in k6:

It comes from here https://github.com/mostafa/xk6-kafka/blob/main/reader.go#L344 but I can't capture it as an XK6KafkaError.

@vvargas90
This is the expected behavior based on the current design. Would be happy to see contributions.

Why is that? It's not even possible to see what the error is @mostafa

@davidgomesdev @vvargas90
Good question! I am trying to fix it. Will raise a PR soon and would be happy to have your feedback.

@davidgomesdev I won't be able to decipher the error any more than you do. I made the kafka-go's error catch-able, so you can search the error in that library.

This was what I meant @mostafa #288


Why are presets not unified across editors?

So, this is less of an issue with iD specifically, but something that iD could easily take the lead on, considering its importance as an editor.
OSM Wiki notes "Presets have not been standardized across editors". It seems a first attempt at doing this was considered some years ago, but nothing ever came of it.
My question is: Why not?
There are a ton of obvious benefits to having unified presets. Data quality of OSM, ease of use for editors, communicability of editing practices, accuracy of rendering by editors would all increase massively if presets (and therefore tagging schemes) were standardized more. The wiki, in integrating that standard preset scheme, could offer even better documentation of those tagging schemes. Changes in tagging could easily propagate across geography and time, past tagging could be understood better as a result of previous unified standards, editing and adding data would be simplified considerably and the barrier of entry for new editors (and editor solutions) would be lowered as well.
I realise this is nothing that iD can change on its own. No change in iD's code is going to bring about a unified preset solution. But why haven't there been more attempts at integrating the presets JOSM, Potlach, iD and other editing solutions use? We see some convergence; StreetComplete uses iD's presets, Vespucci uses JOSM's. But still, a (IMO highly unnecessary) rift remains, only getting worse with time as more editors, editing solutions and tagging discrepancies emerge.
EDIT:
JOSM ticket: https://josm.openstreetmap.de/ticket/20995
Vespucci issue: https://github.com/MarcusWolschon/osmeditor4android/issues/1412

From what I see in the JOSM repo, all of the presets are XML-based. iD uses a JSON-based solution and it is all located in a separate repository (https://github.com/openstreetmap/id-tagging-schema).
iD's solution seems better because it is more organized and easier to interpret than what JOSM uses. I'd forward this issue to JOSM's trac and Vespucci's repo ask them why they don't switch to the tagging schema repository.

Adding link to JOSM ticket: https://josm.openstreetmap.de/ticket/20995
Please also post a link to the Vespucci issue here once it's available.

As iD is currently unmaintained, there won't be any progress on this issue in the near future.

See also comment in https://josm.openstreetmap.de/ticket/20995#comment:5

Vespucci uses JOSM's

Not true. Vespucci is using fork of JOSM presets - see https://github.com/simonpoole/beautified-JOSM-preset
Also, this issue should be rather in https://github.com/openstreetmap/id-tagging-schema anyway.

My question is: Why not?

Historical answer: because iD and Vespucci preferred to start own presets rather than reuse JOSM one, possibly expanding it.
Why it is not changing?
Partially because people have different ideas how various features should be tagged, described and which tags should be promoted (see for example highway=track discussions). So, unifying presets would make decisions made much more powerful.
Presets are very important, not taking so much effort to maintain existing ones - so if an editor has working presets there is no very big benefit from starting to rely on external one.
In addition different editors have different needs - for example see different styles in icons between iD and JOSM. Shared preset would require both, so no actual reduction in duplication would be achieved here.
Note that in general iD preset is very tightly coupled to how it is used specifically in iD.
Still, some work may be done (like detecting which features are missing in given presets and present in others), and if someone would be interested in working on that - it would be likely useful.
Similarly reducing other incompatibilities may help.

From what I see in the JOSM repo, all of the presets are XML-based. iD uses a JSON-based solution

This is not a real problem and you are missing issues actually present.

I'd forward this issue to JOSM's trac and Vespucci's repo ask them why they don't switch to the tagging schema repository.

There would be a noticeable loss of functionality, JOSM and Vespucci has presets for many things missing in iD and many parts fitting specifically iD would be not fitting Vespucci and JOSM.

There would be a noticeable loss of functionality, JOSM and Vespucci has presets for many things missing in iD and many parts fitting specifically iD would be not fitting Vespucci and JOSM.
Can you elaborate specifically? (I'm curious and I don't know)

for start

In addition different editors have different needs - for example see different styles in icons between iD and JOSM. Shared preset would require both, so no actual reduction in duplication would be achieved here.

Also, compare list of features in Vespucci presets with what is in iD presets. iD misses some.


Navbar

Adds Navbar to Talent App.
Adds react-bootstrap module to Talent App.
Changes routes for website.

I like that you're using a library's included Nav system, in the spirit of an MVP and doing "the simplest thing that could possibly work." This way, the time is spent learning react (rather than styling a nav bar from scratch). In the future, if the project gets huge and the design constraints change, you can always replace the nav.
I squashed and merged and didn't let you know that you'd have to branch off of the updated version of master! That's why there are three extra commits right now on this branch (your branch versions of the two commits from the first PR, then a merge commit). I'll come over and help you clean up the git history.

Closes Issue #2


Await also capabilities endpoint

Last 5 builds are green https://jenkins.mesosphere.com/service/jenkins/job/system-integration-tests/job/metronome-si-dcos-open/job/av%252Fawait-capabilities/


basic support for Posix Message Queues

I've updated my code a bit and have now created a pull request.
Basic sending of messages works.
Not all Posix APIs yet implemented.

Hey there. I tried merging this but it looks like the tests didn't pass. Could you rebase off of master and see what's going on with the tests? Thanks :smile:

Did the rebase. According to Travis "All is well" now :-)

I did a little bit of cleanup: https://github.com/carllerche/nix-rust/commit/8127b4dd6d37ae028a31c013b7d5758d66362b04
If that commit looks good, I can push it to master.

Looking good!

Merged. Thanks: 8127b4dd6d37ae028a31c013b7d5758d66362b04


Support for subtitiles timed in seconds, support for italic in subtitles

This pull request include 2 contributions to the ttml2srt version in Hbo go Eu Kodi add-on. It adds support for ttml subtitle timing in seconds (some subtitles on hbo nordic are in that format, contribution of awdAvenger). And add support for italic in subtitles (contribution of Paco8).

Thank you!
Looks like the seconds support is an immediate merge but I added a commit to remove the italics detection because Netflix (and likely others too) use <span>s for bunch of stuff – not just italics – so for ttml2srt's purposes the italics parsing has to take a more generic approach.


Warning: Each child in a list should have a unique "key" prop.  Check the render method of Navbar component.

Got it! It appears that you are not giving a unique identifier while mapping.
Opened a pull request.
https://github.com/Real-Dev-Squad/website-calendar/pull/94#issue-1523835165


Version rollback

Has some (huge) inconsistencies at the version 0.5.0. I unpublished that version and rollback to the version 0.4.2.
I'm rewriting the tests and part of the implemetation to fix that.

May I know when will the 0.5.0 version ready as diff only is something I like to leverage on

The problem about the diff only functionality is the messy support to the schema pre/post and even more to the schema.post('init'). It's failing at some Mongoose versions and not in others. Probably we should wait for the some future updates to have a reliable functionality.
Automattic/mongoose#3054
Automattic/mongoose#3968

Thanks for the quick reply, would you suggest alternative or way that I can implement myself with similar functionality? As seems mongoose won't have this fix soon


lib up dev package dependency installation failure for Phantom

Hi guys,
Great job on this, I'm really enjoying hacking on stdlib. Got a bit of a weird case here that I just wanted to bring up.
Just for kicks, I tried to spin up a microservice that uses Phantom to render webpages as PDF's or images.  However, lib up dev seems to fail at the dependency installation.

I know Phantom is a bit of a weird one since it comes with the actual phantomjs-prebuilt binary.  I did try a service with just phantomjs-prebuilt and that fails too.
Am I running into some kind of size limit or is there something about Phantom that just doesn't jive well currently with stdlib?
Thanks for the insight on this, looking forward to using stdlib some more!

Hi Eric,
Sorry about the delay. Glad you've been enjoying the platform!
We don't yet support npm packages with static binaries - would something like Puppeteer fit your use case?

Hey @jacoblee93, yep, I was going to go that route, but I figured I'd ask here for posterity.  Good to know for future reference about static bins.  Thanks for the clarification!

@ericnograles this should work now if you still want to give it a try!


Chapter directories are out of sync

The health check and jwt code are discussed in chapter 4, "MicroProfile Health Check and JWT Propagation". Right now we have health check in Chapter04-metricsandhc and jwt in Chapter05-jwtpropandot. These need to be renamed to:
Chapter04-jwtpropandhc
Chapter05-metricsandot

Chapters have been separated by specific MP API and are all in-synch now. Does this issue still apply?

Thanks for sharing the feedback. It will surely assist the readers to resolve any issue if they face it.


encoding/json: Unmarshal. Expected type string -> found int.

Hi everyone.
This issue is about the json package, concretely the Unmarshal function.
My version of go: 1.10.2 windows/amd and the go env is not relevant because it happens too on play.golang.org (see the link with the example here: https://play.golang.org/p/NGoR7Vs-VxX ).
The problem I am finding is that I am receiving a json that includes an array like this:
[
  {
    "key": "accept-encoding",
    "value": "gzip, deflate"
  },
  {
    "key": "content-length",
    "value": 1377
  }
]

My question is... why should value field be a interface type?? I mean... every number can be converted to string without any problem... so, why can´t I use string as type and the json decoder makes responsible to realize the conversion (if it is necessary)??
I have been diving a little on the code of the decode file, and... in this line:
https://github.com/golang/go/blob/5c11480631f5654e9e6937ff08c453660138c64d/src/encoding/json/decode.go#L984
removing the second condition of the if (&& v.Type() == numberType) works for me. I guess it is a security statement or maybe something important that I don´t understand. But... when does v.Type() will be different than v.Kind()?? or... when does the v.Kind() will be a string and the v.Type() a json.Number??
Thanks in advance.
PS: Finally I found this solution using UnmarshalJSON function: https://play.golang.org/p/egqc6KJK1-t but I would want to know the reason of the non-autoconversion.

Hi @eloyucu ,
This appears to be a question rather than a Go bug. We do not use the issue tracker for general discussions or questions like these. The Github bug tracker is only used for tracking bugs and proposals going through the Proposal Process.
Please feel free to reach out to the forums in the Questions wiki page; it has a list of good places for asking questions.
Closing since this is not a bug.


Rope and Video already on update list

This PR

Fixes a bug

I think it was harmless but make.rope() and make.video() had an unnecessary branch for adding to the update list. The game objects are already added to the update list by BuildGameObject().

👍


Azure AD Auth with MFA Enabled

Hi, if the Azure AD instance backing the D365FO instance has MFA set up for user accounts, will this work? Is there a specific workaround / trick to make it work? We have seen our tests failing after MFA was rolled out to our AAD tenant.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 221bcbdf-2c16-ee9d-f289-75980e35b17a
Version Independent ID: 6377db2c-d7b7-82bb-baeb-8f2311a9fb87
Content: Test services by using third-party utilities - Finance & Operations | Dynamics 365 | #MSDyn365FO
Content Source: articles/dev-itpro/data-entities/third-party-service-test.md
Service: dynamics-ax-platform
GitHub Login: @Sunil-Garg
Microsoft Alias: sunilg

Thanks for contacting us. Unfortunately, we're unable to handle questions for the product here. To contact Support, consider one of the options described here: Support contact options. In particular, you might want to go to the Dynamics 365 for Finance and Operations community page to get help with your questions from the Dynamics community.


Travis-ci: added support for ppc64le & updated go 1.13 & 1.14 & 1.15

Signed-off-by: Devendranath Thadi<EMAIL_ADDRESS>Added power support for the travis.yml file with ppc64le and updated latest go versions 1.13, 1.14 & 1.15. This is part of the Ubuntu distribution for ppc64le. This helps us simplify testing later when distributions are re-building and re-releasing.

Coverage remained the same at 100.0% when pulling ab97377a034c85c52a950e6a4eab50355bac242c on dthadi3:ppc64le into 339f5d48a4f3352fe8bcdefe81de01e25f711b09 on disintegration:master.

Thank you!


Example not working on Mac M2 Max Sonoma 14.4.1

I tried the Flask example locally, and get:
$ httpfs -mount ~/demo ./examples/flask-basic/app.py
2024/04/19 09:03:27 unable to stat httpfs: Head "http://localhost:59353/": dial tcp <IP_ADDRESS>:59353: connect: connection refused

I don't know much about Flask.  It might be nice to bundle a Go example as well.
I'm running on a Mac M2 Max with Sonoma 14.4.1.

It works great on Linux Mint 21.3 Cinnamon, by the way.
:tada:

I just pushed some changes that should fix this. I had it waiting 1 second for subprocess to start serving, but of course it could take longer. Now it polls until its up or gives up after 5 seconds.
I also added a Go example. Please let me know if this fixes.

I get the same thing with the Pyhon example... next, I'll try Go...
glenn@glenn-MacM2Pro ~/src/github.com/progrium/httpfs (main) $ git pull
Already up to date.
glenn@glenn-MacM2Pro ~/src/github.com/progrium/httpfs (main) $ httpfs -mount ~/demo ./examples/flask-basic/app.py
2024/04/19 13:17:57 unable to stat httpfs: Head "http://localhost:65276/": dial tcp <IP_ADDRESS>:65276: connect: connection refused

(Of course, I had to reboot the Mac after I add the executable to the security panel... ah, Macs.)
AH!  And NOW the Flask version works too after the reboot!
So with the Go version, it forces you to update your system settings, whereas with the Flask version, it silently fails.
Feel free to close the ticket.


401 Unauthorized response, "Unable to Join" a server

Hi @Zenoryne, thank you for doing this in Golang!
When using the "Join Server" function, I am getting the error
<token> | Unable to Join <inviteCode>

Looked into the response returned res and its a 401 Unauthorized. Getting the same error when I tried with more tokens and different proxy servers (and without proxy servers). All the accounts of these tokens have been created manually.
Any idea what might be the issue here? Thank you!

Sounds like your tokens are not valid. Unauthorized is the response that comes back when you are trying to join on locked tokens. Try run the checker module in the tool and it will tell you what is wrong with the tokens.


Support PostgreSQL + Deploy to Heroku

This PR:

Add some scaffolding to deploy to Heroku

Subdir buildpack to deploy app from server/
Python poetry buildpack to use Poetry to generate requirements.txt files
https://devcenter.heroku.com/articles/django-app-configuration
https://devcenter.heroku.com/articles/django-assets

Adds support / docs for using PostgreSQL as the database
Optimizes the 0004_auto_20230306_1456.py migration by making use of bulk_create
Adds tqdm for a pretty progress bar

We should revisit an ingestion pipeline in the future, but optimizing the migration helps if we need to blow away a local database dropdb alignmentapi and start over.

@themikejr Let's see how far we get with this.  I can easily help deploy the frontend to the same Heroku app if you need that too.
If we were to deploy the frontend elsewhere or if you wanted to point a local frontend at Heroku we'd probably want to add django-cors-headers.

@jacobwegner thanks for all of this, it's really helpful!
For some reason I had to change the location of the data path in that migration to be like:
DATA_PATH = settings.BASE_DIR / "data/data"

I'm guessing this is because I didn't document where the data is supposed to go and we ended up with two different locations?

After tinkering with my local postrgres creds, I was able to run this branch locally using postrgres and everything seems to be working properly.


Rspec for Spreadsheet Uploader

As a developer, I want to ensure that the Spreadsheet Uploader handles valid spreadsheet files correctly. Test that uploading a valid spreadsheet file results in the creation of expected records.
Verify that the user is redirected to a success page after a successful upload.
Confirm that a flash message indicating a successful upload is set.


[FEATURE] PLEASEE add these two features...

First of all, this app is already better than what I expected.
Thank you for making this app and keeping it free.
I would want 2 simple additions to this app.
First one would be an option to play the ADHAN when the prayer waqt (time) begins.
Secondly I would love to have the option to play a surah or custom file when my pc starts. Could you add the option to play a audio file on startup please.
Thanks again,
Sheikh.

Salam @Sheikhm007,
Thank you for the kind words and I'm happy that you liked the widget :)
Firstly, the request to add Adhan when the prayer time enters is legitimate and can be implemented. However, I'm afraid that the other request is out of the scope of this widget and will not be fulfilled. You can already achieve your goal using Task Scheduler on Windows.
Secondly, I'm working at the moment on finishing the updates for the next release (v3.3) and I may have to postpone your request to the later release (most probably will be v4).
Let me know if it's urgent for you to have Adhan feature or it's okay to wait a little.
Thanks for showing interest in the widget,
Khiro

Yeah sure, I would love to have the Adhan feature, it's completely okay if I need to wait for v4 to get that feature. And thank you for taking my suggestion.


Too many redirects for /.well-known/ folder

Hi, I'm not sure if this is right to open an issue here but... it seems that the service worker implementation clashes with folders at the root.
I want to host an apple verification file at /.well-known/apple-file but when I open the full URL in the browser, it redirects too many times and says (from service worker).
ANy ideas what the issue could be? Thanks!

Next.js: ^14.2.2
@ducanh2912/next-pwa: ^10.2.6

@ilyagru there's not much info we can get out of this issue. Can you provide a reproduction? Thanks!
I can't see how the service worker would treat this file any different to how it does for other files, though.


[Testing] Make all telemetry tests support multiple clusters

Bug Description
This is just for the telemetry tests.
There are a ton of tests that are currently skipped when running in multicluster mode. We need to identify and fix any tests that are skipped when using multiple clusters.
Some things to search for:

RequireSingleCluster, RequireMultiPrimary ... both should be removed.
.IsMulticluster() identifies some call sites that are multicluster-specific

Version
NA

Additional Information
No response

@zirain do you think you'd have any time to look into this?

I will take a look at this next week.


'properties' does not exist in type 'HybridArgs'

I see that properties is included in HybridArgs in 1.3.0, but the following code snippet fails with

Argument of type '{ query: string; alpha: number; properties: string[]; }' is not assignable to parameter of type 'HybridArgs'.
Object literal may only specify known properties, and 'properties' does not exist in type 'HybridArgs'.

import weaviate, { WeaviateClient } from 'weaviate-ts-client';

const client: WeaviateClient = weaviate.client({
  scheme: 'https',
  host: '...',
});

const response = await client.graphql
  .get()
  .withClassName('JeopardyQuestion')
  .withFields('question answer _additional{ score }')
  .withHybrid({
    query: 'Venus',
    properties: ["question"],  // <--
  })
  .do();

Hey @dandv, the support for this feature existed on master, but hadn't made it into a release yet.
I just made a release which contains hybrid class property support:
https://github.com/weaviate/typescript-client/releases/tag/v1.3.1


NTS-1 mkII: The LED shows a wrong string value after scrolling starts

There is a problem in displaying strings of type k_unit_param_type_strings.
(1)Values of 4 or less characters and values of 5 or more characters are mixed in the string returned by getParameterStrValue().
(2)A value of 5 or more characters had been selected even once.
(3)A value of 4 or less characters is currently selected.
When the above conditions are met, the last selected value of 5 or more characters is displayed after scrolling starts.
// example: "SQUARE" is always displayed as a scrolling string.
    inline const char * getParameterStrValue(uint8_t index, int32_t value) cons\
t {
   	if (index == 2) {
	    if (value == 0) {
	        return "SINE";   // = 4 chars
            } else {
	        return "SQUARE"; // > 4 chars
	    }
	} else {
	    return nullptr;
	}
    }

Hi @boochow
You didn't by any chance find a clever way around this did you?
Thanks
Andy

@AndrewCapon I made all strings to be longer than four characters :-)

:)
Nice one, I will do the same.

I tested firmware v1.2 and can confirm that this issue has been fixed.


[BUG] Phone Entry Page: Information, written above the  'continue' button is blurry.

Describe the bug
Phone Entry Page: Information, written above the 'continue' button is blurry.
To Reproduce
Steps to reproduce the behavior:

Go to 'https://reach4help-staging-web-client.firebaseapp.com/phone/entry'
Information, written above 'continue' is blurry.

Expected behavior
Information, written above the 'continue' button should be clearly visible.
Screenshots

Desktop:
OS: Windows 10
Browser: Chrome
Version 83.0.4103.61 (Official Build) (64-bit)
Smartphone (please complete the following information):
N/A
Additional context
N/A

ZenHub Information
This information is updated automatically. To modify it, please use ZenHub.

ZenHub Information
This information is updated automatically. To modify it, please use ZenHub.

related to 605

Regression Testing is done. The bug is fixed.


[WIP] remote python client for podman

Use podman library for access
Verbose error checking
Planned windows and macosx ports

Signed-off-by: Jhon Honce<EMAIL_ADDRESS>

how would you feel about adding a README.md to this with a brief how to use it?

would you consider using an entrypoint in setup.py?  something like -> https://github.com/projectatomic/registries/blob/master/setup.py#L12

couple of comments, LGTM, nice work @jwhonce

What is the command used to run this?  Could we get at least a simple man page.
pypodman would be my preferred command name?  But I am willing to look at others.
Also want to have a
make install.python
Option to install this.

@baude @rhatdan Agree to all.  I wanted to get this in front of people early. I added WIP to mark it as such.

@jwhonce Looks good, and I would like to merge this to allow people to play with it.  But we need an easy way to install and execute the command.

yeah what he said ... id like to test before i hit the road too, maybe in osx for you

@baude last commit has setup.py entry-point configured

@jwhonce Conflicts?
Remove the [WIP] on the PR, and lets get this in.

@rhatdan for both podman and pypodman, you now have
make clean && make install
both work on ~/.local/lib/python...

@rh-atomic-bot r+

@rh-atomic-bot retry

I'm going to give it 5 minutes and force-merge this and #1089 so I can cut a release

setup.py install --root $BUILDROOT seems to install /usr/lib/python3.6/site-packages/lib <- which seems wrong, it should atleast be in /usr/lib/python3.6/site-packages/podman/lib or something

@jwhonce would it make sense to move contrib/python/pypodman/lib to say contrib/python/pypodman/pypodman/libs ... kinda like what's being done for contrib/python/podman/podman/libs. I think that'd make packaging easier.


_recolumn function of tmy.py doesn't use passed 'inplace' parameter

inplace=True statement is hard-coded. Should be used inplace=inplace statement instead

This keyword argument does not do anything in practice, so it should be removed. Feel free to submit a pull request.

closed by #384.


fix: add some additional notes, return sooner, and debug logging

I meant to PR it into my forked repo, mb.


Release v0.3.7

What this PR does / why we need it:
Releases v0.3.7. I am not sure how much we need this release, but the point is to test out the release process as a wet run of #476.

/test test-end-to-end-java-8

@ches I'm not sure if I have the time to debug the issues on this branch. Are we confident in the changes that have been backported? I think the problem here is likely more the tests/CI than the code.

I thought we had a passing build on #654 and/or #657, I'll take a look at it here.

I am not sure how much we need this release

datatypes-java being published to Central is essential for me to publish an open source release of Scala SDK with the v0.3 support that we use in production. This will close #442 if no one much cares about the v0.3.6 artifacts.

Error: Unable to access jarfile core/target/feast-core-*-SNAPSHOT.jar
It's looking for the -SNAPSHOT I think

Alright, seems fine now. The non-snapshot jar finding needs to be forward ported as well to master.

/lgtm

The changelog generation seems slightly off, mostly the 0.3.7 release version itself: its "Full Changelog" link is compare of https://github.com/gojek/feast/compare/v0.4.7...v0.3.7 instead of v0.3.6...v0.3.7, which actually includes the Cassandra store, and adding indexes.
There's also a reference to #375 that actually links to 376, not sure if that might have been a mistake in a human edit.

The changelog generation seems slightly off, mostly the 0.3.7 release version itself: its "Full Changelog" link is compare of v0.4.7...v0.3.7 instead of v0.3.6...v0.3.7, which actually includes the Cassandra store, and adding indexes.
There's also a reference to #375 that actually links to 376, not sure if that might have been a mistake in a human edit.

I noticed the first problem as well when I created the GitHub release. Will try and figure out why that happened.
The rest of the changelog was copied over from master. I only generated the 0.3.7 contents.