Move Up/Down Code Actions

Personally, I think generic Up/Down Move Code Actions are extremely useful.
There should be two clever commands: Move Up and Move Down. Dependening on the selection and context, they do "the right". Because there are only two, they should have good keybindings.
Here is an (incomplete) collection of what they would enable:

[x] Move Statements / Declarations
[ ] Move Declarations inside multi-variable declaration
[x] Move Class Members
[x] Move Array Items (taking care of commas)

[ ] Move array destructuring items

[X] Move Object Properties (taking care of commas)

[ ] Move object destructuring properties

[x] Move If/Else Branches https://github.com/p42ai/refactor-vscode/issues/28
[ ] https://github.com/p42ai/refactor-vscode/issues/41
[ ] Move expression in homogenous condition (a && |b && c -> |b && a && c) (note: overlap/replacement of 'flip operator')
[ ] Move argument in function invocation (f(1, |2) -> f(|2, 1))
[ ] Move Parameters (fixing all call-sites) (note: technically hard - requires multi-file, dataflow, etc.; more limited version possible)
[ ] Move JSX elements
[x] Move JSX attributes
[ ] Move Case-Branches in Switch Statements
[ ] TypeScript: move interface members, move type members, re-order union types, etc.

Sometimes a move is safe, sometimes not.
A key property of move commands should be that "Move up" and "Move down" are inverse.

Great idea, thanks for the writeup!
Regarding one command: I'd much rather leverage grouping through code action kind prefixes and have individual code actions - this gives users more flexibility configuring their keyboard shortcuts without losing anything ( see https://p42.ai/documentation/p42-for-vscode/editor-integration#keyboard-shortcuts for some examples).
Code action kind prefixes could be:

"refactor.move.up.*"
"refactor.move.down.*"
(TBD) "refactor.move.swap.*"

have individual code actions

Maybe it makes sense to distinguish them, but I think discoverability is much more important than precision for refactorings.
ReSharper has one unified move down/up system, and it works flawlessly.

I don't understand how this would impact discoverability. There would be a single shortcut for "move up" and a single shortcut for "move down". The additional flexibility is just in case a user wants it, and there have to be separate implementations anyways because there are different matchers, transformations, safety evaluations, etc.

There would be a single shortcut for "move up" and a single shortcut for "move down"

Then you would need to use many context keys to compute upfront which of those "move up" commands wins effectively. Alternatively you would need a single dispatching move-up and move-down command (which would also enable changing the keybinding for all move commands at the same time).

There would be a single shortcut for "move up" and a single shortcut for "move down"

Then you would need to use many context keys to compute upfront which of those "move up" commands wins effectively. Alternatively you would need a single dispatching move-up and move-down command (which would also enable changing the keybinding for all move commands at the same time).

Maybe, but it could also depend on the activation ranges etc. I'll probably stick with the current system for now, since I have singnificant tooling around, and will see how far I get. I can always implement some prioritization algorithm when there is a need for it.

Move statements is available in v1.132.0:

Let me know what you think about the current keyboard shortcut setup or if you run into any bugs.

That is very cool! When invoking the shortcut, I wouldn't expect the context menu though.

That is very cool! When invoking the shortcut, I wouldn't expect the context menu though.

Yeah - I agree. I'm still trying to figure out how to best deal with the following 2 constraints:

sometimes there are overlapping move refactorings (e.g. move stmt & move if-else-branch) for the same activation range. Could be solved by

prioritization algorithm - but e.g. it is unclear to me how move down branch from an if-statement would work in this case
showing the menu only when there are > 1 options (could still lead to friction)

currently there is no good way of showing safety information without the context menu. Possible solutions:

show confirmation dialog if the refactoring would result in an error
show notification when a refactoring is directly invoked and there is a info/warning/error safety information

Would love to hear your thoughts, in particular if there are other options that I'm not considering.

In general, I would expect move commands to be non-safe, so safety information is not very helpful for me for this code action.

I think some conflicts will be unavoidable if there is only up/down (e.g. move if branches conflicts with move statement). I'll introduce move left/right in addition to move up/down.
Move up/down

Move Statements / Declarations
Move Class Members
Move JSX elements
Move Case-Branches in Switch Statements
TypeScript: move interface members, move type members, re-order union types, etc.

** Move left/right**

Move Declarations inside multi-variable declaration
Move Array Items (taking care of commas)
Move Object Properties (taking care of commas)
Move If/Else Branches https://github.com/p42ai/refactor-vscode/issues/28
https://github.com/p42ai/refactor-vscode/issues/41
Move expression in homogenous condition (a && |b && c -> |b && a && c) (note: overlap/replacement of 'flip operator')
Move argument in function invocation (f(1, |2) -> f(|2, 1))
Move Parameters (fixing all call-sites) (note: technically hard - requires multi-file, dataflow, etc.; more limited version possible)
Move JSX attributes

This should reduce conflicts and still be fairly intuitive. I'll also remove the menu.

The keyboard shortcuts directly execute (when there is only 1 option for now) starting with v1.132.2:

Hi! how can I disable it? ctrl+alt+up/down is a very usefull hotkey to move code lines in any file type but now I'm getting this message when I press this commbination in files differt to *.ts *.js

@serchserch you can disable it in the keyboard shortcuts panel when you record the "ctrl+alt+up+ keybinding:
Command Bar: >Preferences: Open Keyboard Shortcuts

Thanks for the report, I'll look into limiting the shortcut to the js/ts/vue suffixes.

@serchserch I've released v1.132.3, which limits keyboard shortcuts to supported files. Please let me know in case the JavaScript assistant still provides keyboard shortcuts for unsupported files.

Hi! how can I disable it? ctrl+alt+up/down is a very usefull hotkey to move code lines in any file type but now I'm getting this message when I press these commbination in files different to *.ts *.js

This is a good point - can you just move lines up/down in case there is no applicable refactoring?

Hi! how can I disable it? ctrl+alt+up/down is a very usefull hotkey to move code lines in any file type but now I'm getting this message when I press these commbination in files different to *.ts *.js

This is a good point - can you just move lines up/down in case there is no applicable refactoring?

Interesting idea - I'll think about it. My concern is that is might be confusing for the users and that they would often have another shortcut for this. I'll wait until the whole move system is further along to see if it would fit in naturally.

v1.133.0 supports moving JSX attributes:

I think for Windows, shift+alt+{up, down, left, right} might be better.
Ctrl+Alt+... is already used for multi-cursor and is quite important.

I think for Windows, shift+alt+{up, down, left, right} might be better. Ctrl+Alt+... is already used for multi-cursor and is quite important.

Thanks for letting me know - definitely need to change this for windows. Unfortunately "shift + alt + {direction}" is already taken as well on windows, and "ctrl + shift" is a standard for extending selections afaik.
Would "win + alt + {direction}" work for you? (I did not find that shortcut in the list)

shift+alt+{up, down, left, right}

I think duplicating lines up and down is probably not used by many, so I think it should be okay to overwrite that.

shift+alt+{up, down, left, right}

I think duplicating lines up and down is probably not used by many, so I think it should be okay to overwrite that.

Is there any downside to the win + alt + {direction} option that I'm missing? I'd rather not mess with any built-in shortcuts (even tho I agree not many people are likely to use this one).

win + alt + {direction} is already taken by the OS.
I think the "win" modified should be avoided for shortcuts.

win + alt + {direction} is already taken by the OS. I think the "win" modified should be avoided for shortcuts.

Hm that makes things more difficult. I wanted to use shift as a modifier for lift operations, e.g. in the following situation:
|statement1();
{
  statement2();
}

Shortcut w/o shift: move statement down
{
  statement2();
}
|statement1();

v1.134.0 supports moving array elements:

v1.135.0 support moving object properties:

v1.136 supports moving class members:

Nice work!!
Top level declarations would also be super nice, as I often reorder classes to clean-up code.

Nice work!!
Top level declarations would also be super nice, as I often reorder classes to clean-up code.

Thanks! Top-level declarations should be moveable in v1.136.1 - are there any cases where it does not work?

Nice, it works perfectly!

Would you be able to track the text ranges before/after the move of the moved element?
Maybe we can do a cool animation

Would you be able to track the text ranges before/after the move of the moved element? Maybe we can do a cool animation

An animation would be cool - can VS Code do that?
Yes, the edit ranges and the selection ranges are used in the code action already.

can VS Code do that?

Not yet, but this would be a great use-case to expose that functionality to extension authors.
There is something internal that could be enhanced a bit to make it work.

can VS Code do that?

Not yet, but this would be a great use-case to expose that functionality to extension authors. There is something internal that could be enhanced a bit to make it work.

Would love to try it, for move refactorings this could be very useful to help the user understand what's going on.
Probably the animations would need to be able to turned off for power users (animations can easily slow down the user interactions, I almost always disable them when I can).

Btw. you should reveal the location for the moved source. For large classes the moved text just disappears.

Btw. you should reveal the location for the moved source. For large classes the moved text just disappears.

Thanks for letting me know - I just shipped v1.137.0, which reveals the (moved) text selection / cursor and adds "move switch case":

v1.138.0 supports moving variable declarations:

v1.139.0 supports moving array elements in destructuring expressions:

An animation would be cool - can VS Code do that?
Yes, the edit ranges and the selection ranges are used in the code action already.

For now, you could use a decoration to highlight the target location for a short period of time.

An animation would be cool - can VS Code do that?
Yes, the edit ranges and the selection ranges are used in the code action already.

For now, you could use a decoration to highlight the target location for a short period of time.

I'll hold off on the animation / decoration for now - while it might look cool at first glance and could make for good demos, I found that animations in areas of direct user interaction tend to get into the way in practice more often than not (e.g. by slowing the user down). When there is some built-in VSCode API that I can leverage I might look into prototyping / revisiting this.

I would only show the decoration for the location where the code moved to, for about 300ms. Maybe you can even do some tricks with backgroundColor: `red; transition: all 0.5s ease-out, to get a nice fade out, but I don't know.
I don't think this animation will be annoying, it should be very subtle. But it will help to see where the text moved to.

Quick preview:
https://user-images.githubusercontent.com/205036/183908024-1de7f43f-783b-4820-8838-00680f484e4a.mov
This looks nice, will clean it up and include it in the next release.

v1.139.1:

Thanks for the sugestion! Animations might have potential for other refactorings such as extract or inline as well.

Move object property in destructuring (v1.140.0):

Very nice!

I think for Windows, shift+alt+{up, down, left, right} might be better. Ctrl+Alt+... is already used for multi-cursor and is quite important.

v1.141 switches to "shift+alt+direction" on Windows/Linux.

v1.142 simplifies the shortcuts:

Action
Type
Mac Shortcut
Windows/Linux Shortcut
Code Assists

Move
context menu
CTRL + CMD + M
CTRL + ALT + M
17 code assists

Move Up
direct
CTRL + ALT + UP
SHIFT + ALT + UP
9 code assists

Move Down
direct
CTRL + ALT + DOWN
SHIFT + ALT + DOWN
9 code assists

Move nested if statements in v1.143:

A quick update on why progress has been slow in the last few months: in order to get this right, I need to handle whitespace and comments differently, which requires some larger changes to the refactoring engine. I've put this on a lower priority for now, since many of the core parts already work, but I hope to get back to it in Q1/23.


Doing synchronous writes while chunking can seems to block the thread indefinitely

Doing some testing on aspnet/Mvc#3516 I ran into this issue.
It's super easy to overwhelm the server when a large Razor page does synchronous writes. Doing 50 requests per second quickly starves the thread pool.
 More threads are slowly spawned to handle the queued requests until the server OOMs.
I suspect the tasks created by Write aren't completed once the client is gone.

We'll be changing Razor to avoid synchronous I/O to play better with libuv. There looks like there's still a real bug here.

I might have bumped into something similar; though a different route (last statement in issue makes me think this), which am investigating.
What's the processes handle count like?

Interestingly, after while (a long while) it returned to normal responsiveness

Just a follow up, fairly sure handles is unrelated; I think its coming from a different package as I'm burning them at idle. Still looking into this though.

K, I think I've got this one...

However; still good to go async as you will be paying all the async costs anyway but also blocking threads with the sync route.
If you go async you might be able to do overlapped generation+send for an additional benefit? e.g.
var lastTask = Task.CompletedTask;
var dataBuffer = bytePool.Rent(bufferLength);
try
{
    while (stuffToDo)
    {
        GenerateByteData(dataBuffer);
        await lastTask;
        lastTask = Response.WriteAsync(dataBuffer);
    }
    await lastTask;
}
finally
{
    bytePool.Return(dataBuffer);
}

Beyond "SocketOutput exception completes all waiting tasks" #567
and "Write chunks async" #586
The next step would be the threadpool being overwhelmed https://github.com/dotnet/coreclr/issues/1606#issuecomment-144007622
Which apparently the "hosting" controls the threadpool min threads? /cc @davidfowl
(no api for user code in coreclr)

Hmmm... but... aspnet4 did use 2 threadpools; on for IO completion and one for user code; whereas here blocking usercode can block IO completion notifications.

Raised issue https://github.com/dotnet/coreclr/issues/2712

Future solution https://github.com/dotnet/coreclr/pull/2718
(When using RunContinuationsAsynchronously and not queuing to Threadpool as Task will handle it)
Meanwhile fix should be in  #586

Lots and lots of improvements in this area in Kestrel and all the away down to coreclr and corefx - however there is still a scalability issue of sync writes.
Low scaling solution is to increase the thread pool count which can be done with environment variable
e.g.
export ComPlus_ThreadPool_ForceMinWorkerThreads=2000
or
set ComPlus_ThreadPool_ForceMinWorkerThreads=2000
Which hopefully will become a config file thing https://github.com/dotnet/cli/issues/889
High scaling is to go async

We need to at least look at this for RC2, although if Razor gets their change in it's less important and could wait until post RC2.

Currently working on this: https://github.com/aspnet/Mvc/pull/3920
I propose we re-measure and see if this repros after all of the things we've tried.

@DamianEdwards We need to address this in RC2. @benaadams is working on https://github.com/aspnet/KestrelHttpServer/pull/567 that ensures that all writes get completed even when a connection disappears.
Without this PR, it is possible for Kestrel to never complete calls to WriteAsync and Write. The effect of this is terribad for synchronous writes, but obviously really bad in any case. That's why I was planning on pushing the PR through ask mode.
@benaadam's PR also prevents Write or WriteAsync from throwing if there isn't a canceled token passed in, but this is the less important aspect of the PR. I'm OK with splitting the PR if need be, but we need to guarantee writes always get completed.

I understand the impact of this situation when it occurs is bad. What we need is more information RE the risk of it occurring. e.g. if I File -> New -> MVC application and deploy it, then hit it with a few hundred clients, is it likely to occur? If not, how much bigger does the response need to be to make it more likely? etc.

It current also effects SSL/TLS - though the last fix for that has just been merged in corefx

@DamianEdwards threadpool size aside - there is an issue here that would not be expected. (e.g. threadpool scalability is expected)

@DamianEdwards threadpool size aside - there is an issue here that would not be expected by a user, if anything writes more then 64k. (e.g. threadpool scalability issues are expected)

A File -> New -> MVC application could run into this issue if a client were to pipeline a ton of requests which would the cause the app to surpass the write-behind buffer with the
@benaadams told me that 2000 clients brought the server to a halt the doing synchronous writes to WebSockets.

Json.NET and DataContractSerializer both have sync writes. Has anyone tested what happens when serializing large objects with MVC + Kestrel? Services that return megabytes of JSON/XML are pretty common.

Aside: Cancellation token is needed for Staticfiles to stop sending large files on disconnect https://github.com/aspnet/StaticFiles/blob/dev/src/Microsoft.AspNetCore.StaticFiles/StaticFileContext.cs#L326-L347

@DamianEdwards just a heads up; increasing threadpool may not be an option in all situations (coreRT/native? https://github.com/dotnet/cli/issues/889#issuecomment-173331862)

#567 Is now merged so this issue should be resolved.
We added some functional and unit tests to verify that tasks (and therefore also sync writes) are completed when a client disconnects.


fix: result page is now hidden until user clicks on get result

🛠 Fixes Issue
Closes #168

👨💻 Changes proposed

The result page is now hidden until the user clicks on the 'Get result' button.
This can improve the experience of the user who is using the site on small screen devices.
Changed 8 files.

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

Thanks For Contributing, PR accepted, I hope you continue to contribute to this project

I'll keep contributing, thank you!


Start / end indication for markers

Better start / end visual indication for makers.

Fixed https://github.com/Project-OSRM/osrm-frontend-v2/commit/a382ad0fa844daaaad4167677d12509ccef64a7b


Facilitate external modification of HTML5 canvas size

This patch allows changing the HTML5 canvas size from outside Godot, by modifying the canvas.width and canvas.height properties from JavaScript as one would expect,.
Also adds a clear error for trying to enter fullscreen from outside an input event.

Thanks!

Now that Godot 3.1 has been released, we don't plan to cherry-pick new features and enhancements to the 3.0 branch, unless there is very strong support in favor of it. Removing cherrypick label for 3.0.


Blurred images after data augmentation

I am trying to fine-tune the model on my own dataset.
However, while looking into the images (for initial few iterations) after augmentation has been applied, I find the images to be quite blurry. Is this expected ?

@pransen Yes. It's normal. That's why we close the augmentation for the last 15 epochs.

Is it also normal for the images in the mosaic to overlap ? It's as if the images are blended together similar to cv2.addWeighted().

@pransen The overlap you mentioned is caused by Mixup. It is also closed for the last 15 epochs.


add cmh and breslow-day tests

Added a separate file including functions for Cochran-Mantel-Haenszel and Breslow-Day tests, per Kelly's request. @nickdeveau94 this is mostly your code.

@annepym Why are these tests in a different file? We have a file called stats.py for the various statistical tests. It would be convenient to have all our statistical tests in one place.

Is this going to be merged in soon? It'd be awesome to actually use this in the upcoming client analysis. (I think this is a public repo, so won't say who the AI analysis is for :) )

@annepym , totally agree with @deelin. Can you commit the suggestions? We can add examples of the CMH test in a separate commit.

@deelin , @annepym added some intense docstrings and tests, clarified variable names when possible

@VishalMurali makes a good point that this should be moved to stats.py

I've added a notebook that walks through the functions with examples (CMH_test_example.ipynb). I'm going to defend that the utility functions for CMH should have a standalone folder within utils/cmh.py, as the utility functions could be confused with other functions (e.g. utils.crosstabs.crosstab_odds_ratio for calculating odds ratios in most other cases).

WOOHOO!


Added ability to change pcAddress via environment variable

Making pcAddress changeable as mentioned in https://github.com/PathwayCommons/app-ui/issues/764 should be pretty simple I think. This might work.
Use the following commands in bash from the root of the repository to test.
Default
node -e 'console.log(require("./src/private/constants.js").pcAddress)'

Change pcAddress
PC_URL=hello_there node -e 'console.log(require("./src/private/constants.js").pcAddress)'

Can be used in conjunction with https://github.com/PathwayCommons/pathway-commons-client/pull/8 or can be used standalone, up to you.

Thank you @mj3cheun
I will merge this one manually into 'mj3cheun-endpoint' branch, test, then merge into master.
But I think, you did not have to create separate branches (from master) every time and pull requests 8, 9, 10, 11, 14 - all ref same issue #5. You could simply have one PR #8, 'endpoint' branch in your fork repo, and keep fixing and adding new changesets there - the pull request would be updated automatically, w/o conflicts; and I could auto-merged all at once ;)
@d2fong @maxkfranz @jvwong


feat(with): Add initial with binding

Trying to fix #16
Need an idea for how to use better -
${childProp}
Does not work -
parentProp.childProp = 'red'
This appears to -
parentProp = { childProp = 'blue' }

@PWKad Can you rebase this on master?

oh man, I wished this was documented :).  Struggled with finding this beautiful piece of functionality I missed from Durandal for a couple days.  I thought that compose would do that automatically for me (ie, accept a view model object like in durandal), then I thought I should've done import...etc..
To me, the with binding was like the most important part of Durandal - the ability to compose view models within view models and have my views reflect that using cascading with's.

:)  Thanks for the feedback, this is still a work in progress which is why it isn't documented well yet.  As a note when composing a viewmodel within a viewmodel it is possible to simulate a with just by using the model property that is available to bind on compose for now.


adding some creative background to https://watercss.kognise.dev/

can i add some background to the site..as it would look interesting after that??

Can you please describe what is required just a responsive background with slight effects or some animations?

The site is meant to be a demo page

Yeah, I'm not a sure a creative background is a great idea. I do want to redesign a large portion of Water.css though and release a major v3.


nf-core tools --> lint command --> markdown report contains invalid links

Running nf-core lint --markdown <foo>.md (v2.10) and trying to access any of the hrefs there-in gives 404.

Can't reproduce this. What are the links you get?

The repo is a newly created pipeline using nf-core create


Dockerfile based on an old version of ruby (and getting older)

Writing this here so we can perhaps figure it out later.
The tech docs docker image no longer uses the latest ruby2.7 image, instead we have pinned https://github.com/alphagov/paas-tech-docs/commit/cd03a82cf23e1af2d62a7b6c4a2ab167ec47d7b6  it to a version of this image that we built 28 days ago, and now will never be updated.
We did the same fix as here https://github.com/alphagov/paas-bootstrap/commit/964fe5eb7e69b790786746d3f74e6c2037fa572d
This has solved (for spooky reasons I can't explain) the Operation not permitted error we were getting, but has caused bitrot to set in.

@tomrosier figured out the spooky reasons:

So, i've worked out why it broke underneath, The docker image that this is based on originally used Debian Buster & they switched the pointer for Ruby:slim-2.7 to point at Debian Bullseye, for some reason that change of os means that we get permissions issue.
This is the point where they changed the pointer.
https://github.com/docker-library/official-images/commit/e217a7520b1950b5ccf91d72a297a8e70c517a6e#diff-577d7516279169d9d062e00f1668719d041de84c66b81d2445cf2ff0de98ebc0R42-L32
We can kick the can down the road a bit by switching our underlying docker image to be Buster based as that is supported till '~2022-08' e.g slim-2.7 -> 2.7-slim-buster and build 2 seperate buster & bullseye based images or migrate all our images to work with bullseye.


Add biodata protocol and change sampleId to bioSampleId

Also adds ontology term to metadata.avdl.
@mbaudis These are the schema changes I've plucked from your fork.
The first most important question is: which queries are we hoping to perform? Will SearchReadsRequest and SearchCallSetsRequest have the addition of an optional bioSampleId? Shall biosamples and individuals be query-able directly?

That's great! The things I'm not seeing finalized here myself is the diseases, phenotypes, observations, interventions, developmentStage cluster of attributes in Individual. These were intentionally put in for having discussions about structure and use (probably complex objects, but maybe fewer).
My preferred option to go forward here would be the limitation to cleared attributes: id, name, description, created and updated; as well as  sex, species and info.
It is a bit tricky to have a clear delineation between "forward looking/discussion" branches and the "probably o.k. to implement, pending some adjustments" PRs ...

I think it's very important to go forward with minimal implementation
a grow it.
Some of the missing things here seems to be more clinical
features as opposed to description of the biosample (phenotypes,
interventions), others seem very much related to the sample
(developmentStage).
Mark
Michael Baudis<EMAIL_ADDRESS>writes:

That's great! The things I'm not seeing finalized here myself is the diseases,
phenotypes, observations, interventions, developmentStage cluster of attributes
in Individual. These were intentionally put in for having discussions about
structure and use (probably complex objects, but maybe fewer).
My preferred option to go forward here would be the limitation to cleared
attributes: id, name, description, created and updated; as well as sex, species
and info.
It is a bit tricky to have a clear delineation between "forward looking/
discussion" branches and the "probably o.k. to implement, pending some
adjustments" PRs ...
—
Reply to this email directly or view it on GitHub.*

Disease and development stages can be linked.
Also developmental stage is also a feature of the organism as well as
the sample.
It's not easy to split these, and can be use case dependent.
On 18/02/2016 15:07, Mark Diekhans wrote:

I think it's very important to go forward with minimal implementation
a grow it.
Some of the missing things here seems to be more clinical
features as opposed to description of the biosample (phenotypes,
interventions), others seem very much related to the sample
(developmentStage).
Mark
Michael Baudis<EMAIL_ADDRESS>writes:

That's great! The things I'm not seeing finalized here myself is the
diseases,
phenotypes, observations, interventions, developmentStage cluster of
attributes
in Individual. These were intentionally put in for having
discussions about
structure and use (probably complex objects, but maybe fewer).
My preferred option to go forward here would be the limitation to
cleared
attributes: id, name, description, created and updated; as well as
sex, species
and info.
It is a bit tricky to have a clear delineation between "forward looking/
discussion" branches and the "probably o.k. to implement, pending some
adjustments" PRs ...
—
Reply to this email directly or view it on GitHub.*

—
Reply to this email directly or view it on GitHub
https://github.com/ga4gh/schemas/pull/559#issuecomment-185760458.

--
Helen Parkinson, PhD
Team Leader - Samples, Phenotypes and Ontologies
Molecular Archives Cluster Head

European Bioinformatics Institute (EMBL-EBI)
European Molecular Biology Laboratory
Wellcome Trust Genome Campus
Hinxton
Cambridge CB10 1SD
United Kingdom
EBI 01223 494672
For scheduling assistance please contact Lynn French<EMAIL_ADDRESS>01223 494 453
Skype: helen.parkinson.ebi
http://www.ebi.ac.uk/about/people/helen-parkinson

Good points, as always.
In my view, these reasons that relations by querying are better
than fix relations via linking.
Helen Parkinson<EMAIL_ADDRESS>writes:

Disease and development stages can be linked.
Also developmental stage is also a feature of the organism as well as
the sample.
It's not easy to split these, and can be use case dependent.
On 18/02/2016 15:07, Mark Diekhans wrote:

I think it's very important to go forward with minimal implementation
a grow it.
Some of the missing things here seems to be more clinical
features as opposed to description of the biosample (phenotypes,
interventions), others seem very much related to the sample
(developmentStage).
Mark
Michael Baudis<EMAIL_ADDRESS>writes:

That's great! The things I'm not seeing finalized here myself is the
diseases,
phenotypes, observations, interventions, developmentStage cluster of
attributes
in Individual. These were intentionally put in for having
discussions about
structure and use (probably complex objects, but maybe fewer).
My preferred option to go forward here would be the limitation to
cleared
attributes: id, name, description, created and updated; as well as
sex, species
and info.
It is a bit tricky to have a clear delineation between "forward looking/
discussion" branches and the "probably o.k. to implement, pending some
adjustments" PRs ...
—
Reply to this email directly or view it on GitHub.*

—
Reply to this email directly or view it on GitHub
https://github.com/ga4gh/schemas/pull/559#issuecomment-185760458.

--
Helen Parkinson, PhD
Team Leader - Samples, Phenotypes and Ontologies
Molecular Archives Cluster Head

European Bioinformatics Institute (EMBL-EBI)
European Molecular Biology Laboratory
Wellcome Trust Genome Campus
Hinxton
Cambridge CB10 1SD
United Kingdom
EBI 01223 494672
For scheduling assistance please contact Lynn French<EMAIL_ADDRESS>01223
494 453
Skype: helen.parkinson.ebi
http://www.ebi.ac.uk/about/people/helen-parkinson
—
Reply to this email directly or view it on GitHub.*

We basically need a type of wrapper object, which IMHO is identical for at least Disease and Phenotype, and just contains a list of ontology terms + id, time data.

id, so that e.g., evidences can be connected
some time descriptor
an array for OntologyTerm objects, called something like "characteristics", "features" or such
I am actually against making the classification between "disease" and "phenotype" - I do not understand the conceptual separation (and have said so from the beginning). The included OTs should be self-explanatory. Should be "Phenotypes" all the way. And then one could fold in "Observations" into the same general object; and also "interventions" (without the attempt to model something like complex clinical procedures, but use pharma ontologies (?) for the general classes...). So we would end up with a "Characteristics" wrapper for time(s)+id(s)+ontologies, which would have a general query mechanism etc.
Now we have to do examples (and counter-examples, if ...).
I'll try to write something ASAP.

@diekhans I've updated this PR to include the latest metadata docs but more importantly there are changes to the queries for Reads and CallSets so that one can filter by bioSampleId.
There is also an endpoint biosamples/search for searching biosamples by name.

+1 lets get this into the topic branch


Add script for running multiple mining instances

This script allows you to run multiple miners without having to worry about wallet collisions causing crashes and loss of coin if 2 instances mine a block at the same time. The number of instances can be passed via the -n argument or changed dynamically while running using the up and down arrow keys.
It does not work on Linux at the moment due to a socket address reuse error which unfortunately I don't know enough about Linux to fix.

I suggest to merge this before #17.

Sorry, I missed that. Are you able to move forward on the present PR now that #17 has been merged?

Sorry, I missed that. Are you able to move forward on the present PR now that #17 has been merged?

Its been updated with the changes from #17

The idea of my PR was to print some stats once per second.
If you run this code with n>1, we get multiple lines per second.
I think it would be nice to print stats once per second from the main process.

I used changes in this PR on my own branch (keeping the existing commits) and modified it so the mining script outputs one line per second of stats.
Please check PR #24.

Closing this in favor of #24


feat: wrap subQuery with parenthesis when it appears as table name

Fixes #3485

Could you please also add integration test that would actually execute the generated sql?

Thanks!


fix(tab-bar): error in calculating the width of tab wrapper

背景描述

跟之前的PR #601 同样的问题，上次只是修复了tab item，tab wrapper的尺寸也同样的问题
主要改动

wrapper宽度获取由offsetWidth，改为getBoundingClientRect

Codecov Report

Merging #667 into dev will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev     #667   +/-   ##
=======================================
  Coverage   84.53%   84.53%
=======================================
  Files          98       98
  Lines        2793     2794    +1
  Branches      539      539
=======================================
+ Hits         2361     2362    +1
  Misses        287      287
  Partials      145      145

Impacted Files
Coverage Δ

components/tab-bar/index.vue
97.87% <100.00%> (+0.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd269b7...82279ef. Read the comment docs.

你这个getBoundingClientRect老是会报错，前面的dom属性有的时候根本获取不到@xxyan0205


74 feature 65 research for state machine

Description
In order to create a suitable state machine, old projects and resources have been examined as well as possible software libraries which could be useful.
I also renamed some of the old documents to be complient with the naming style.
Fixes #74
Time invested
Josef Kircher: 8 h
Type of change
Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Does this PR introduce a breaking change?
No
Most important changes
04_decision_making.md
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works (might be obsolete with CI later on)
[x] New and existing unit tests pass locally with my changes (might be obsolete with CI later on)

Review time: 30 min


feat: Adding Conversion Webhooks for v1 EC2NodeClass

Fixes #N/A
Description

Implemented Conversion webhooks for v1 APIs to v1beta1 APIs

How was this change tested?

make presubmit
Planning on Adding E2E testing in a separate PR

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

142 of 228 (62.28%)  changed or added relevant lines in 4 files are covered.
67 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-1.2%) to 77.941%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/apis/v1beta1/ec2nodeclass_conversion.go
0
2
0.0%

pkg/webhooks/webhooks.go
0
5
0.0%

pkg/apis/v1/zz_generated.deepcopy.go
0
79
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/apis/v1/zz_generated.deepcopy.go
67
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-1.2%

Covered Lines:
5717

Relevant Lines:
7335

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

142 of 228 (62.28%)  changed or added relevant lines in 4 files are covered.
67 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-1.2%) to 77.941%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/apis/v1beta1/ec2nodeclass_conversion.go
0
2
0.0%

pkg/webhooks/webhooks.go
0
5
0.0%

pkg/apis/v1/zz_generated.deepcopy.go
0
79
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/apis/v1/zz_generated.deepcopy.go
67
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-1.2%

Covered Lines:
5717

Relevant Lines:
7335

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

156 of 242 (64.46%)  changed or added relevant lines in 4 files are covered.
68 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-1.1%) to 77.97%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/apis/v1beta1/ec2nodeclass_conversion.go
0
2
0.0%

pkg/webhooks/webhooks.go
0
5
0.0%

pkg/apis/v1/zz_generated.deepcopy.go
0
79
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/providers/amifamily/ami.go
1
90.56%

pkg/apis/v1/zz_generated.deepcopy.go
67
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-1.1%

Covered Lines:
5730

Relevant Lines:
7349

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

156 of 242 (64.46%)  changed or added relevant lines in 4 files are covered.
68 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-1.1%) to 77.97%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/apis/v1beta1/ec2nodeclass_conversion.go
0
2
0.0%

pkg/webhooks/webhooks.go
0
5
0.0%

pkg/apis/v1/zz_generated.deepcopy.go
0
79
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/providers/amifamily/ami.go
1
90.56%

pkg/apis/v1/zz_generated.deepcopy.go
67
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-1.1%

Covered Lines:
5730

Relevant Lines:
7349

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

156 of 242 (64.46%)  changed or added relevant lines in 4 files are covered.
67 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-1.1%) to 78.011%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/apis/v1beta1/ec2nodeclass_conversion.go
0
2
0.0%

pkg/webhooks/webhooks.go
0
5
0.0%

pkg/apis/v1/zz_generated.deepcopy.go
0
79
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/apis/v1/zz_generated.deepcopy.go
67
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-1.1%

Covered Lines:
5733

Relevant Lines:
7349

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

156 of 163 (95.71%)  changed or added relevant lines in 3 files are covered.
114 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.3%) to 77.988%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/apis/v1beta1/ec2nodeclass_conversion.go
0
2
0.0%

pkg/webhooks/webhooks.go
0
5
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/apis/v1/zz_generated.deepcopy.go
114
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.3%

Covered Lines:
5729

Relevant Lines:
7346

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

156 of 163 (95.71%)  changed or added relevant lines in 3 files are covered.
68 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.3%) to 78.041%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/apis/v1beta1/ec2nodeclass_conversion.go
0
2
0.0%

pkg/webhooks/webhooks.go
0
5
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/apis/v1/zz_generated.deepcopy.go
68
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.3%

Covered Lines:
5729

Relevant Lines:
7341

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

156 of 163 (95.71%)  changed or added relevant lines in 3 files are covered.
32 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.4%) to 78.71%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/apis/v1beta1/ec2nodeclass_conversion.go
0
2
0.0%

pkg/webhooks/webhooks.go
0
5
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/providers/amifamily/ami.go
1
90.56%

pkg/apis/v1/ec2nodeclass_validation.go
31
70.05%

Totals

Change from base Build<PHONE_NUMBER>:
0.4%

Covered Lines:
5941

Relevant Lines:
7548

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

156 of 163 (95.71%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 78.723%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/apis/v1beta1/ec2nodeclass_conversion.go
0
2
0.0%

pkg/webhooks/webhooks.go
0
5
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.4%

Covered Lines:
5942

Relevant Lines:
7548

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

156 of 163 (95.71%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 78.723%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/apis/v1beta1/ec2nodeclass_conversion.go
0
2
0.0%

pkg/webhooks/webhooks.go
0
5
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.4%

Covered Lines:
5942

Relevant Lines:
7548

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

156 of 163 (95.71%)  changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.4%) to 78.71%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/apis/v1beta1/ec2nodeclass_conversion.go
0
2
0.0%

pkg/webhooks/webhooks.go
0
5
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/providers/amifamily/ami.go
1
90.56%

Totals

Change from base Build<PHONE_NUMBER>:
0.4%

Covered Lines:
5941

Relevant Lines:
7548

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

156 of 163 (95.71%)  changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.4%) to 78.699%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/apis/v1beta1/ec2nodeclass_conversion.go
0
2
0.0%

pkg/webhooks/webhooks.go
0
5
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/providers/amifamily/ami.go
1
90.56%

Totals

Change from base Build<PHONE_NUMBER>:
0.4%

Covered Lines:
5941

Relevant Lines:
7549

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

140 of 147 (95.24%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 78.762%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/apis/v1beta1/ec2nodeclass_conversion.go
0
2
0.0%

pkg/webhooks/webhooks.go
0
5
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.3%

Covered Lines:
5941

Relevant Lines:
7543

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

140 of 147 (95.24%)  changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.3%) to 78.775%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/apis/v1beta1/ec2nodeclass_conversion.go
0
2
0.0%

pkg/webhooks/webhooks.go
0
5
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/providers/amifamily/ami.go
1
90.56%

Totals

Change from base Build<PHONE_NUMBER>:
0.3%

Covered Lines:
5942

Relevant Lines:
7543

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

140 of 147 (95.24%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 78.788%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/apis/v1beta1/ec2nodeclass_conversion.go
0
2
0.0%

pkg/webhooks/webhooks.go
0
5
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.4%

Covered Lines:
5943

Relevant Lines:
7543

💛  - Coveralls


Use firmware parameters

rename parameters using Firmware convention
use MPC_XY_CRUISE as max velocity when there aren't any obstacles
use MPC_COL_PREV_D to decide if the distance data are sent to the Firmware
remove unused dynamic reconfigure paramters
add MPC_JERK_MAX since only the min was retrieved

It is more important that these are correct now that we will be using them. Is there any way we can detect if the parameters didn't arrive? Maybe the default values should be NaN, and after some delay if any are still NaN we should ask for the values again.
Otherwise I'm happy with this, just needs a formatting fix.

I think the retry if we don't get the parameters is with this: http://docs.ros.org/api/mavros_msgs/html/srv/ParamGet.html
We can get just the parameters we need if they don't arrive after a timeout. It is a service, so it won't have any dropped packets, too.

Flight testing for this went really well. Once thing we found is that most of the time it spends at the 1/2 max-velocity due to some obstacle appearing somewhere in the history. As a result the actual max speed isn't exercised very often. Due to this, to make the flight more predictable it would be a good idea to get rid of the 1-tier speeds, rather just using a single speed and depending on the flight planning to slow down the drone when rapid trajectory changes are needed.


how pom.xml in logs

@rultor release, tag is 0.0.6

@rultor release, tag is 0.0.6

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.0.6

@yegor256 Done! FYI, the full log is here (took me 12min)


Issue with k8s.io/docs/reference/config-api/apiserver-admission.v1/ - undocumented types

Several of the types used in AdmissionRequest does not seem to be documented anywhere.
The links point to the general Kubernetes API docs, but the actual types does not seem to be defined there. Searching in the docs does not turn up any obvious references, and neither does web searches.
Types missing documentation:

meta/v1.GroupVersionKind
meta/v1.GroupVersionResource
authentication/v1.UserInfo

/sig docs
/language en

/triage accepted
/assign


Complete the code in order to make the words button work!

Modify the code such that player could play with 4 - lettered valid words!
Do not use custom words.

hiii could i get assigned to this

hiii could i get assigned to this

@Hiyanachnani you have been assigned this issue


Remove unused step and fix env var in workflow

follow-up to #4

Workflow will always build against latest stable

Will test this and merge when I get a chance.  Should be ready for a new template build after that.

Going to merge this now and do a cleanup pass when I add publish actions.


OAuth2 with seperate token endpoint

🕮 Describe the issue
A clear and concise description of what the issue/improvement is, which you want to address.
Hi, I want to use the OAuth2 Module to connect to several APIs. The OAuth implementation has separate endpoints to acquire the Auth Code and then the Access Token / Refresh Token.
Example:
authorityurl/authorize    <- used to get the Auth Code
authorityurl/token          <- used to get the Access Token with the Auth Code
The current implementation through
procedure AcquireTokenByAuthorizationCode(ClientId: Text; ClientSecret: Text; OAuthAuthorityUrl: Text; RedirectURL: Text; Scopes: List of [Text]; PromptInteraction: Enum "Prompt Interaction"; var AccessToken: Text; var AuthCodeErr: Text)
gets me a valid login and Auth Code. But then the Auth Code is used in
procedure AcquireTokenByAuthorizationCodeWithCredentials(AuthorizationCode: Text; ClientId: Text; ClientSecret: Text; RedirectUrl: Text; OAuthAuthorityUrl: Text; Scopes: List of [Text]; var AccessToken: Text)
by the AuthFlow: DotNet ALAzureAdCodeGrantFlow; instance. This does not yield an Access Token and no error either. Since this is blackbox to me I am not sure what's going on. My first instinct was that token endpoint isn't used since the codeunit only supports one AuthorityURL. But I copied the object and implemented this overload:
procedure AcquireTokenByAuthorizationCode(ClientId: Text; ClientSecret: Text; OAuthAuthorityUrl: Text; OAuthTokenAuthorityUrl: Text; RedirectURL: Text; Scopes: List of [Text]; PromptInteraction: Enum "Prompt Interaction"; var AccessToken: Text; var AuthCodeErr: Text)
This sets the OAuthTokenAuthorityUrl on the DotNet instance but I still do not receive a valid Access Token and no errors. Is there something I could improve here? I would like to ultimately produce a PR that enables the OAuth2 Module to handle this case.
In the meantime I will have to implement this entire OAuth flow myself without DotNet. This seems possible but a lot of work and rewriting of procedures from the OAuth2 Codeunit without use of DotNet.
This OAuth2 module is of great business value to us as we implement a lot of interfaces.
Any help or advice would be greatly appreciated.

@WaelAbuSeada can you maybe provide some insight on this topic?

Hi everyone, is there any update on this topic? If I can provide any additional information I'd be happy to do so.

@lktraser it might be helpful to share this idea on yammer, too.
Currently this repository isn't watched by the platform team that might be responsible on this topic.
@JesperSchulz can maybe point this issue to the right people.

Thanks @pri-kise, I'll start a conversation about it on yammer linking to this issue. Any people I should tag specifically?

I hope you got an answer. This repository is only for extensibility requests or pull requests towards the 1st party Business Central apps. I'm hence closing this issue.

Hi @JesperSchulz, seems like there has just been a development to this topic yesteday! My post on yammer was quoted by a localization topic from norway. Do you have any information if this change will roll out to the OAuth2 Module in general or just fix the issue for Norway?
https://www.yammer.com/dynamicsnavdev/threads/2666516937580544

This is news to me! I hope I can get some updates next week, when people are back in the office!


We're sorry, a server error occurred while reading from storage. Error code NOT_FOUND

Hi Tanaikech, thank you for creating the TemplateApp library. However, following the instructions in the README file, i referenced the library using the ID but after few hours i couldn't run any function on the App Script project. I have duplicated the project and tried different approach to fix the error but failed.

I really hope to hear back soon!


"on load" callback on Windows

I'd like to be able to receive a notification whenever a new page loads.  I attempted to do this on the master branch by adding the necessary events to the underlying webview.  On Mac and Linux this wasn't hard, but wasn't able to get it working on Windows.
So I checked out the webview-x branch, which seems to support this already (via the webview_init() function which adds arbitrary JS to be run before each page loads).  Once again, it was easy to get everything working on Mac and Linux, but windows was a stumbling block.
On Windows it seems that the WEBVIEW_MSHTML target isn't fully implemented - it has stubs for the init() and eval() methods.  I banged my head for a couple days on trying to build the WEBVIEW_HTMLEDGE and WEBVIEW_EDGE using gcc and then clang - and ultimately ended up creating a new Visual studio project for building the WEBVIEW_EDGE target
However, when I try to use the resulting app with the WEBVIEW_EDGE target, it fails to load the webview in the  CreateWebView2EnvironmentWithDetails function.  It returns the error "The system cannot find the file specified."
I'm not using Go.  I'm just using the basic C++ example apps in that branch to try this.  Is there something that needs to be available in the runtime environment so that CreateWebView2EnvironmentWithDetails can find the Edge webview?  Anything special (other than Edge) that needs to be installed in the runtime environment?
Any pointers appreciated.
If anyone has any tips on getting the master branch to fire "on load" notifications on Windows, that would be an acceptable alternative also.
Thanks for any help anyone can provide.

With the latest updates on the webview-x branch, I am now able to build on windows using the build.bat script.


react-adaptivecards-hooks sample

Q
A

Bug fix?
no

New feature?
no

New sample?
yes

What's in this Pull Request?
New sample: react-adaptivecards-hooks
An update to the react-adaptivecards sample demonstrating React hooks to access data and update state. No additional functionality.

Thanks @pschaeflein, this is going to be a great example for people who want to learn how to switch to React Hooks.
As discussed, I have you scheduled on the June 18th SPFx call.
Looking forward to the demo!


How to translate a file?

Hey guy's,
I want to translate a json file but my code is giving me no outputs at all.
So I wanted to ask if it's even possible to translate a json or txt file.
This is my code:
import json
from argostranslate import package, translate

with open("sample.json","r",encoding='utf-8') as input_file:
    for row in input_file:
        package.install_from_path('translate-en_de-1_0.argosmodel')
        installed_languages = translate.get_installed_languages()

        translation_en_es = installed_languages[0].get_translation(installed_languages[1])
        translated =translation_en_es.translate(input_file)

        output_file = open('test.json','w', encoding='utf-8')
        output_file.write(translated)
        output_file.close()

        print(translated)

Is there something wrong with my code?
If so I would be glad if someone could help me out to solve the problem:)
Thank's for every help and suggestion in advance:)
PS: I've replaced line 80 of translate.py with return input_text to prevent an AttributeError: '_io.TextIOWrapper' object has no attribute 'split' to happen

You probably want to translate specific fields in your file not translate the file line by line.
Also you are reinstalling the en_de package for every line in your file.


Yarn executable not found in v2.3.0 en v2.4.0

Yarn was present and could be started directly in v2.2.0
$ docker run -t -i --rm docksal/cli:2.2-php7.1 /bin/bash
docker@c9f1773a7687:/var/www$ yarn -v
1.7.0

docker@c9f1773a7687:/var/www$ which yarn
/usr/bin/yarn

But in 2.3.0 and 2.4.0 it is missing.
$ docker run -t -i --rm docksal/cli:2.3-php7.1 /bin/bash
docker@1903e2648ff0:/var/www$ yarn -v
bash: yarn: command not found

$ docker run -t -i --rm docksal/cli:2.4-php7.1 /bin/bash
docker@3fedf4f59cf5:/var/www$ yarn
bash: yarn: command not found

I think I found the problem. v2.2.0 installed yarn using a package (as described on yarnpkg.com) by adding a repository and installing the yarn package. Starting from v2.3.0, yarn in installed using the install.sh script downloaded from yarnpkg.com. This results in yarn being installed in a other location:

Version
location of yarn

2.2.0
/usr/bin/yarn

>= 2.3.0
/home/docker/.yarn/bin/yarn

Since /home/docker/.yarn/bin/ is missing from the $PATH variable, the yarn executable could not be found.
After adding it the the $PATH variable I got this message:
docker@cli:/var/www$ yarn
Yarn requires Node.js 4.0 or higher to be installed.

Yarn cannot find the node.js version installed in in /home/docker/.nvm/versions/node/. After adding /home/docker/.nvm/versions/node/v8.11.3/bin to $PATH, yarn could be executed.
docker@cli:/var/www$ yarn -v
1.8.0

Edit: The commit where the change from package to install script was made is https://github.com/docksal/service-cli/commit/82a82581ddc2c667a45f2a76b1fe130e2636de56

2.3 and 2.4 cli images were introduced in the default stacks in Docksal 1.10.0). They require fin v1.67.2+ to work properly.
Once you update Docksal, this should work as expected.

For anyone finding this issue because yarn can't be found when you're using the cli container image without using fin (for example, in a Bitbucket pipeline), you just need to add it to your PATH:
export PATH=$PATH:/home/docker/.yarn/bin

@mikecrittenden if you are using docksal/cli standalone:

include -v /home/docker - speeds the container start substantially
invoke commands with bash -lc '' - this initializes the docker user environment, so tools installed at the user level (node stack, ruby stack, php cli tools, etc.) can be used

$ docker run --rm -it -v /home/docker docksal/cli:2.5-php7.1 bash -ilc 'yarn --version'
1.8.0

@lmakarov wow, great tips - is that documented anywhere?

@mikecrittenden Nope. I did not know anyone was using docksal/cli standalone.  I'm using docksal/ci-agent:php in CI. It's very lightweight, but it only comes in the base (minimal) and php flavors.
I'll update the README in the docksal/service-cli repo with this info.

I'm trying to use the docksal/cli via docker-composer on a CI server.  I have this:
version: '2.1'

services:
  base:
    image: docksal/cli:2.4-php7.1
    volumes:
      - ..:/var/www

and I have the same problem with yarn or npx not being found.  Can you explain what I might add to this docker-compose.yml file to make this work?

I'm sure this isn't the correct solution, but just for the record, this is how I've been doing it up until now:
# Set up NVM
source /home/docker/.nvm/nvm.sh
nvm use 8

# Set up Yarn
export PATH=$PATH:/home/docker/.yarn/bin

Actually looks like just doing source /home/docker/.profile within the container will set up everything too.

If you look above, in Leonid's reply it says
... bash -ilc '...'

-l option forces login shell, login shell autoloads /home/docker/.profile

Yep, I saw that, which is what led me to just put source /home/docker/.profile in my script.  In my case I cannot just add bash -ilc because this is using GitLab CI which just points to a docker-compose file to run specified scripts directly; it's not using docker run... directly.  So perhaps there is something I can add to the docker-compose.yml file shown above but it was just easier for me to modify my specific script.


Using the right way to parse args.

Changing the test cases as well.
JIRA: PDC-1564

Coverage decreased (-8.4%) to 80.307% when pulling 775e35bb46b27aa5222b1763b17b65ee77a2c5bc on PDC-1564_using_right_way_to_parse_args into e2d182cfb4fcc9501beee0380dbc870f7905be8a on master.

:+1:

looks good for me


MAAS-35 | Shapes

Added Shape model and shapes API endpoint, and implemented importing of GTFS shapes.txt into the model. The API returns the shapes' geometries as GeoJSON LineString objects.
Also added the shapes to the demo frontend. Beautiful.

Codecov Report

Merging #31 (e5d2daf) into main (c3d6554) will increase coverage by 0.74%.
The diff coverage is 94.66%.

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   87.94%   88.69%   +0.74%
==========================================
  Files          39       41       +2
  Lines        1062     1132      +70
  Branches       75       82       +7
==========================================
+ Hits          934     1004      +70
- Misses        101      102       +1
+ Partials       27       26       -1

Impacted Files
Coverage Δ

gtfs/importers/gtfs_feed_importer.py
85.54% <86.95%> (+1.03%)
:arrow_up:

gtfs/models/shape.py
94.44% <94.44%> (ø)

gtfs/admin.py
75.55% <100.00%> (+2.38%)
:arrow_up:

gtfs/api/shapes.py
100.00% <100.00%> (ø)

gtfs/models/__init__.py
100.00% <100.00%> (ø)

gtfs/models/trip.py
96.87% <100.00%> (+0.20%)
:arrow_up:

maritime_maas/urls.py
95.65% <100.00%> (+0.41%)
:arrow_up:

gtfs/models/base.py
100.00% <0.00%> (+6.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3d6554...e5d2daf. Read the comment docs.


Gosec

Start fixing some gosec reports

more restrictive file permission for ~/.ollama files
add --request-header-timeout param to server to prevent slowloris DDos
annotate false positive in llm/payload_common.go and DRY

Please note that there are still open issues that need to be addressed or annotated with more context:

cmd/cmd.go:761:12: G204: Subprocess launched with a potential tainted input or cmd arguments (gosec)
server/upload.go:5:2: G501: Blocklisted import crypto/md5: weak cryptographic primitive (gosec)

It would be good to add gosec to the .golangci.yaml linter config and CI when all issues are addressed

Hi @alpe thanks for the PR. I'm so sorry for taking so long to review this. Would it be possible to recreate this PR with the gosec changes off of main? RE the timeout functionality, it may be best to use a reverse proxy such as nginx to do this.


Update eDiscovery-investigation.md

Add note for teamchannel#1 template
the script that uses teamchannel#0 template won't work

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.


NullPointerException at BasicTrustRootIndex when caCert.getSubjectX500Principal() is null

We are seeing NullPointerException crashes, mainly from Samsung devices running 4.1.2 and 4.2.2. We have custom TrustManager, but it delegates to platform default getAcceptedIssuers() method. Version 3.8.1. Stack:
Fatal Exception: java.lang.NullPointerException        at org.apache.harmony.security.provider.cert.X509CertImpl.getEncoded(X509CertImpl.java:346)        at java.security.cert.Certificate.hashCode(Certificate.java:102)        at java.util.HashMap.put(HashMap.java:390)        at java.util.HashSet.add(HashSet.java:95)        at okhttp3.internal.tls.TrustRootIndex$BasicTrustRootIndex.(SourceFile)        at okhttp3.internal.tls.TrustRootIndex.get(SourceFile:48)        at okhttp3.internal.tls.TrustRootIndex.get(SourceFile:43)        at okhttp3.internal.platform.Platform.buildCertificateChainCleaner(SourceFile:167)        at okhttp3.internal.platform.AndroidPlatform.buildCertificateChainCleaner(SourceFile:173)        at okhttp3.internal.tls.CertificateChainCleaner.get(SourceFile:41)        at okhttp3.OkHttpClient$Builder.sslSocketFactory(SourceFile:696)
Could caCert.getSubjectX500Principal() even return null for a CA cert? Is this maybe a sign of misconfigured system CAs on those devices?

Yes, it looks like a bug in an old manufacturer version of Android.  Without a reproduction it will be tough to confirm.

There isn't much for us to do here since it's failing inside another codebase


Optimize if statement

Motivation
Some  if statement need optimize, reduce code.
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (yes / no) no
The public API: (yes / no) no
The schema: (yes / no / don't know) no
The default values of configurations: (yes / no) no
The wire protocol: (yes / no) no
The rest endpoints: (yes / no) no
The admin cli options: (yes / no) no
Anything that affects deployment: (yes / no / don't know) no

Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?

[ ] doc-required
(If you need help on updating docs, create a doc issue)

[x] no-need-doc

no new features.

[ ] doc
(If this PR contains doc changes)

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

@merlimat  pTAL again.


SQMAGOPC-230 Version check fixes

@Seppo-Konttinen-Solteq
Strings to translate:

Newer version (v1.2.3) available. More details
Latest version
Can't check for updates now
OP Checkout extension version v1.2.3 available!
A new Op Checkout extension version is now available: v1.2.3! You are running the v1.2.1 version. We advise to update your extension.


Create integrators

Acceptance criteria

[ ] Create verlet integration scheme

[ ] Must work for a simple harmonic oscillator (periodic motion)


Does PowerPaint support SDXL? Or will it?

Hi, thank you for make these wonderful nodes. But I found if I choose SDXL model then PowerPaint shows error. I have not found any related information on the net so I come here to ask. Hope you can share some tips. Thank you for your time, really appreciate.

Thank you for kind words. Unfortunately PowerPaint is only compatible with SD 1.5 and I didn't hear the authors are going to train it with SDXL.

Not problem. With your nodes and these models, SD 1.5 works just fine. The best inpaint in ComfyUI I have ever used. Thank you!


Explicitly tell the readers not to use | in extra_models/tutorial003_py310.py

extra_models/tutorial003_py310.py was exactly the same as extra_models/tutorial003.py
This may confuse first-time readers
https://github.com/tiangolo/fastapi/blob/0976185af96ab2ee39c949c0456be616b01f8669/docs_src/extra_models/tutorial003.py#L33
https://github.com/tiangolo/fastapi/blob/0976185af96ab2ee39c949c0456be616b01f8669/docs_src/extra_models/tutorial003_py310.py#L33

📝 Docs preview for commit d5f23097dc6159f40e325ae877b0baebbdd847b4 at: https://fb0867bb.fastapitiangolo.pages.dev

📝 Docs preview for commit 85f5d8489deee2c1789c28f1884aba9285eb1fc9 at: https://d2e43bf2.fastapitiangolo.pages.dev

Thanks for the interest @wxh06. :nerd_face:
Yep, as @svlandeg says, this would be explained in the text there. So I'll pass on this one, but thanks for the effort! :coffee:


Feature Suggestion - Use Accent Color in meta Info

Would be awesome to add already established "Accent Color" to these new tags:
<meta name="theme-color" content="#xxxxxx">
<meta name="msapplication-TileColor" content="#xxxxxx">

xxxxxx = accent color

Done, published on https://palmtree.npub.pro/, will propagate to others later on. Please check, thanks!


[Feature] Distance transform sampler

A sampler that accepts an Image (implemented by #385) and returns the distance to the closest 'on' pixel derived from thresholding the provided image. This is commonly reffered to as a distance transformation.
The primary usecase I can think of this is allowing users to draw land mass shapes very simply, while also reaping the benefits of gradient noise (such as how Overworld 2.0 utilises continent noise for shaping terrain).
See examples below:

The result could be utilised as a noise sampler as a drop in replacement for other noise  algorithms, allowing users to draw their noise.
A distance array can be precomputed at load time, meaning performance of this should not be a concern (but faster algs may improve pack load time, especially with larger source images).
This could act similarly to the cellular noise sampler, with multiple return types and distance calculation methods.

Implemented in #385


Use PascalCase for CLU samples

Relates to #35041, follow-up to PR #37122

API change check
API changes are not detected in this pull request.

Adding @KrzysztofCwalina as FYI, and in case he has any comments on alignment with the protocol method usage vision.


Unsupported image type when rendering radial-gradient

Please follow the general troubleshooting steps first:

[x] You are using the latest version
[x] You are testing using the non-minified version of html2canvas and checked any potential issues reported in the console

Bug reports:
Whenever I add the following css to my element, html2canvas throws the Unsupported image type error. Debugging shows me that the error is thrown when it tries to parse a token which type is IDENT_TOKEN (20) :
background: radial-gradient(75% 208.07% at 17.92% 27.22%, var(--theme-color) 0%, rgba(26, 26, 26, 0) 100%), #1A1A1A;

Tracetack :
Error: Unsupported image type
    at parse (html2canvas.js:2858)
    at Array.map (<anonymous>)
    at Object.parse (html2canvas.js:2891)
    at parse (html2canvas.js:4155)
    at new CSSParsedDeclaration (html2canvas.js:4039)
    at new ElementContainer (html2canvas.js:4179)
    at createContainer (html2canvas.js:4526)
    at parseTree (html2canvas.js:4529)
    at html2canvas.js:7039
    at step (html2canvas.js:83)

Specifications:

html2canvas version tested with: 1.0.0-rc.7
Browser & version: Firefox 81 & Chromium 83
Operating system: Win10 & Ubuntu-based distro

JSFiddle : https://jsfiddle.net/27dpgms3/

Found a solution : split background to background-color and background-image.
JSFiddle: https://jsfiddle.net/neuqjty7/


Error logs in agent: Unable to cancel request for *exec.roundTripper

Describe the bug
antrea-agent on windows (only observed in windows, but it should be platform independent) shows a lot of error logs saying Unable to cancel request for *exec.roundTripper. It's pretty annoying, though the functionality seems not impacted. The DEBUG logs are like the following.
I0318 22:25:03.370898    9568 config.go:168] Calling handler.OnEndpointsUpdate
I0318 22:25:03.370898    9568 config.go:168] Calling handler.OnEndpointsUpdate
W0318 22:25:03.884876    9568 transport.go:260] Unable to cancel request for *exec.roundTripper
I0318 22:25:03.884876    9568 streamwatcher.go:114] Unable to decode an event from the watch stream: net/http: request canceled (Client.Timeout or context cancellation while reading body)
I0318 22:25:03.884876    9568 reflector.go:530] pkg/mod/k8s.io/client-go@v0.21.0/tools/cache/reflector.go:167: Watch close - *v1.ConfigMap total 0 items received
W0318 22:25:04.581472    9568 transport.go:260] Unable to cancel request for *exec.roundTripper
I0318 22:25:04.581472    9568 streamwatcher.go:114] Unable to decode an event from the watch stream: net/http: request canceled (Client.Timeout or context cancellation while reading body)
I0318 22:25:04.581472    9568 reflector.go:530] pkg/mod/k8s.io/client-go@v0.21.0/tools/cache/reflector.go:167: Watch close - *v1.ConfigMap total 0 items received
I0318 22:25:04.608774    9568 net_windows.go:332] IP configuration for interface antrea-gw0 does not need to change
I0318 22:25:05.377107    9568 config.go:168] Calling handler.OnEndpointsUpdate
I0318 22:25:05.377107    9568 config.go:168] Calling handler.OnEndpointsUpdate

To Reproduce
Run the agent and check the log.
Expected
No error logs
Actual behavior
There are error logs.
Versions:
Please provide the following information:

Antrea version (Docker image tag). v1.2.0
Kubernetes version (use kubectl version). If your Kubernetes components have different versions, please provide the version for all of them. v1.22.4
Container runtime: which runtime are you using (e.g. containerd, cri-o, docker) and which version are you using? containerd and docker
Linux kernel version on the Kubernetes Nodes (uname -r). n/a
If you chose to compile the Open vSwitch kernel module manually instead of using the kernel module built into the Linux kernel, which version of the OVS kernel module are you using? Include the output of modinfo openvswitch for the Kubernetes Nodes. n/a

cc @shettyg

I did some research into this.
This is specific to users of client-go credential plugins, and in this case the exec auth plugin. @anfernee I assume that you are indeed using this plugin for client-go authentication and that you configured this plugin in the kubeconfig used by the antrea-agent?
This issue doesn't impact functionality and it was fixed in K8s v1.23: https://github.com/kubernetes/kubernetes/pull/106014. The fix wasn't backported to earlier versions, so this issue will be resolved when we upgrade the client-go dependency in Antrea to v0.23 (we currently use v0.21.2).
Given that there is an open feature request (https://github.com/antrea-io/antrea/issues/3540) which requires us to update to client-go v0.24, and given that updating the client-go version can be a bit of a pain, I suggest that we tackle both of these at the same time, when K8s v1.24 is GA at the end of the month.

Thanks @antoninbas for the updates. Yes, you are right. We do use exec auth plugin for both kubelet and antrea-agent in GKE, so very likely to be the issue you described.


changing color on the underline on menu item when hover

[x] This is a question about using the theme.
[ ] This is a feature request.
[x] I have updated all gems with bundle update.
[x] I have tested locally with bundle exec jekyll build.
[ ] I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.

Environment informations

Minimal Mistakes version: 4.4.1
github-pages or jekyll gem version: gem version
Operating system: Windows 10

Expected behavior

On the menu item, when you hover them, I would like to change the color of the underlying line that appears.
Steps to reproduce the behavior

Hover one menu item, then a underline will appear. I would like to change the default color.

You'll need to modify/override the theme's CSS to do this. The CSS you'll need to change is in _sass/minimal-mistakes/_navigations.scss
Since you're working with the theme gem version you'll need to follow the relevant instructions on this page in the docs.
Essentially...

Copy the contents of /assets/css/main.scss from the theme gem to <your_project>.
Add your CSS overrides to <your_project>/assets/css/main.scss.

The CSS will end up being something like this, where you change the background-color to whatever color you want the underline.
.greedy-nav a:before {
  background: mix(#fff, $primary-color, 50%);
}

Hi thanks for your answer,
I tried this in the <your_project>/assets/css/main.scss:
$red: rgb(233,87,110);
.greedy-nav a:before {
background: mix(#fff, $red, 50%);
background-color: $red;
}
It's bit more than what you suggest but I wanted to try more according too
but it's not changing anything on the color of the under line.
if i try  with :
.greedy-nav a:hover:before {
background: mix(#fff, $red, 50%);
background-color: $red;
}
It's' working but I still have the grey color a split second when the mouse leave the menu item and just at the beginning. I guess there is still something else that I missed, if you have any idea?

Try this:
.greedy-nav .visible-links a:before {
  background-color: red;
}

If you use your browser's web developer inspector tool you can right click any element and it'll give you a hint as to what you need to override.

Also you don't need both background and background-color. Just use background-color since it's more specific. background is a shorthand for a bunch of other properties that might override things you don't want.
Closing as this is CSS related and better suited for a forum like Stackoverflow.


Feature/#55 depth order

Remove wrong implementation to issue #50
Update doc
Remove faucet and add tab-spec #62

can you update .travis.yml, removing 0.12 and adding 8? As we are bumping the major, we can well do that.

Done

@mcollina could you merge and release it? thanks.


What are the verdictdbblock used?

Is it possible to know what are the verdictdbblock that VerdictDB uses to execute a query?

Sure.  The value of verdictdbblock is used to process only a subset of a scramble (say, 1% of it).  The subset itself amounts to a random sample of the original table, so we can compute unbiased estimators using it.
As VerdictDB processes more subsets (associated with different verdictdbblock values), the accuracy of unbiased estimators increases in expectation.

Thanks. And is it possible to know, which verdictdbblock are used while executing a query?

Yes, both inside VerdictDB modules and by observing the queries issued to an underlying DB.
In general, they are sequential, i.e., the first query is associated with verdictdbblock=0, the second query with verdictdbblock=0, and so on.  These queries may be issued in parallel to reduce the processing time (e.g., for Presto).

Do all blocks run until a convergence is reached?

No. At most 10 blocks at a time. As soon as one is processed, the next one runs until convergence. Of course, all blocks may run if your query selects only a few tuples (thus, convergence is slow).

If that is your sole purpose, I would simply turn on the DEBUG option and see what queries are being issued.
For Java: https://docs.verdictdb.org/reference/properties/
For pyverdict: use verdict.set_loglevel('debug'). https://github.com/mozafari/verdictdb/blob/master/pyverdict/pyverdict/verdictcontext.py#L222

Another question, my idea was to copy the blocks used to another database and then calculate the results. What happens is that for example in the query select sum(l_extendedprice) from lineitem blocks 0,1 and 2 are used and the result through verdictDB is 2.294500756989E11.
But if I do this query: select sum (l_extendedprice) from lineitem_scramble where verdictdbblock = 0 or verdictdbblock = 1 or verdictdbblock = 2; the result with MySQL (for example) is **<PHONE_NUMBER>6.67**.
How can I get the 2.294500756989E11 value through the value<PHONE_NUMBER>6.67 ?

Is it possible to do this through cumulative distributions?

Let me answer this in 10 mins...

So, scaling factors are obtained from the cumul distribution stored in the metadata table.
Ex. cumul = [0.2, 0.5, 1.0] means 20% of data is in block0, 30% of data is in block1, and 50% of data is in block2.
In this case, scaling is performed as follows.

"sum(col) from block0" is scaled by (1/0.2) to produce an unbiased estimator
"sum(col) from block0 and block1" is scaled by (1/0.5) to produce an unbiased estimator
"sum(col) from block0 and block1 and block2" is scaled by (1/1) to produce an unbiased estimator

I believe the actual logic is slightly more sophisticated, but the basics are still the same.

So if I divide the query result into the block by the scale factor, should I get a value close to the real one?
For example, for the lineitem table I have "cumulativeDistributions" = [ 0,142857, 0,285,714, 0,428571, 0.571429, 0,714,286, 0,857143, 1].
If I run this in VerdictDB select sum (l_extendedprice) from tpch.lineitem_scramble; I have this result:  2,2966378476811E11, where blocks 0, 1 and 2 are used.
If I do this query in MySQL select sum (l_extendedprice) from lineitem_scramble where verdictdbblock = 0; I have this result:<PHONE_NUMBER>2,00/0,142857= 2,294312329252330E11.
2,294312329252330E+11

Yes to the first question.
For joins,

We first compute the prob dist for each joined blocks, e.g., (block0 from left, block0 from right), (block0 from left, block1 from right), and so on. The prob dist for each joined block is then computed by multiplying two individual prob dist.
Then, scale factor = 1 / (cumul prob dist), which is the same as single table cases.

Thank you. And another question, how does verdictdb know which blocks to use?

VerdictDB uses block0, block1, block2, and so on.
As it combines the results from different blocks, VerdictDB performs error estimation, and if the error is small enough (or the entire data has been processed), VerdictDB returns a result.

How is this error estimation calculated?

I found this in your code "the values of the result should be within [(1-valueError)*prevValue, (1+valueError)*prevValue]", but if I do these calculations I can not get the blocks to use.
For example, for this query (blocks 0, 1 and 2 are used): select sum(l_extendedprice) from lineitem_scramble;, if I do these calculations:

select sum(l_extendedprice) from lineitem_scramble where verdictdbblock=0; Result:<PHONE_NUMBER>5.53 [(1-0,02)*0, (1+0,02)*0]=[0,0].

select sum(l_extendedprice) from lineitem_scramble where verdictdbblock=1; [(1-0,02)*<PHONE_NUMBER>5,53 , (1+0,02)*<PHONE_NUMBER>5,53

For example, for a query with group by how do I get the value close to the real? If I multiply by the individual probabilities I do not have that value.

For error estimation, VerdictDB checks if processing new blocks of data change our estimates much. If the difference is small, VerdictDB considers that the estimates are accurate.
For scaling the aggregate values for group-by queries, there is no difference.  If you can provide an example, we can have a more concrete discussion.

For example, in this more "complex" query:
SELECT     l_orderkey,     sum(l_extendedprice * (1 - l_discount)) as revenue,     o_orderdate,     o_shippriority FROM     customer,     orders,     lineitem WHERE     c_mktsegment = 'BUILDING'     AND c_custkey = o_custkey     AND l_orderkey = o_orderkey     AND o_orderdate < date '1995-03-15'     AND l_shipdate > date '1995-03-15' GROUP BY     l_orderkey,     o_orderdate,     o_shippriority ORDER BY     revenue desc,     o_orderdate LIMIT 20;
How are calculations done to get a value close to the real?

Let's think about how to scale the revenue value for l_orderkey = 1 and l_orderdate = '1998-01-01' and o_shippriority = HIGH.
Suppose:

we have processed 40% of the original data (e.g., sampling ratio is 100%, verdictdbblock ranges from 0 and 99, and we have processed verdictdbblock between 0 and 39).
sum(l_extendedprice * (1 - l_discount)) is $3000 (for the group) after processing the 40% of data

Then, an unbiased estimator for the total sum (for the group) is $3000 / 0.4 = $7500, according to the Horvitz-Thompson Estimator.

This is not working for the blocks I have, for example, for the lineitem_scramble table "storedProbDist" = [0.14285714285714285, 0.2857142857142857, 0.42857142857142855, 0.5714285714285714, 0.7142857142857143, 0.8571428571428571, 1.0]

This is an expected result. Since there are only a few tuples that include the same l_orderkey, the aggregates based on a small sample (say 1%) cannot produce accurate-enough results (as you have observed). In this situation, VerdictDB chooses to process almost all data to guarantee high accuracy.


Purl-based URIs lead to 404 error on Github

For instance: http://purl.org/pliniancore/terms/Metadata is redirected to https://github.com/PlinianCore/Documentation/wiki/PlinianCore_Terms#Metadata which returns a 404 error.
This is the case at least for all the URIs I've tried.

Ok thx @GMartSag for the information.


apiPackage required even when skipApigeneration defined

When <skipApigeneration>true</skipApigeneration> is set, the <apiPackage> value is still required. When omitted, a NullPointerException is thrown. Ideally <apiPackage> should be optional when skipping API generation. Using version 0.4.30.

Thanks for reporting, will look into this.

@kkrauth
Could you please verify that 0.4.31 works for you as expected?
Regards
Jörg

Yep, that fixed it. Thanks! 👍


Generate line number information in class files

To achieve https://github.com/typelead/eta/issues/189
It seems to work with an output similar to javac, with the actual example emitting line info:
classFile = mkClassFile java7 [Public, Super] mainClass Nothing [] []
  [
    mkMethodDef mainClass [Public, Static] "main" [jarray jstring] void $
        startLabel loop
     <> markStackMap
     <> emitLineNumber (ln 5)
     <> iconst jint 1
     <> iconst jint 1
     <> iadd
     <> ifeq (goto loop) mempty
     <> vreturn
  ]
  where loop = mkLabel 1
        ln = mkLineNumber

The javap -v outputs:
D:\ws\eta\codec-jvm\example>javap -v Test
Classfile /D:/ws/eta/codec-jvm/example/Test.class
  Last modified 22-ago-2017; size 216 bytes
  MD5 checksum 13c31bfdcfe899fbe89f1a5bcab69892
public class Test
  minor version: 0
  major version: 51
  flags: ACC_PUBLIC, ACC_SUPER
Constant pool:
   #1 = Class              #2             //  Test
   #2 = Utf8               Test
   #3 = Class              #4             //  java/lang/Object
   #4 = Utf8               java/lang/Object
   #5 = Utf8               main
   #6 = Utf8               ([Ljava/lang/String;)V
   #7 = Class              #8             //  "[Ljava/lang/String;"
   #8 = Utf8               [Ljava/lang/String;
   #9 = Utf8               Code
  #10 = Utf8               StackMapTable
  #11 = Utf8               LineNumberTable
{
  public static void main(java.lang.String[]);
    flags: ACC_PUBLIC, ACC_STATIC
    Code:
      stack=2, locals=1, args_size=1
         0: iconst_1
         1: iconst_1
         2: iadd
         3: ifeq          9
         6: goto          12
         9: goto          0
        12: return
      StackMapTable: number_of_entries = 3
           frame_type = 0 /* same */
           frame_type = 8 /* same */
           frame_type = 2 /* same */

      LineNumberTable:
        line 5: 0
}

and the class file is executable, of course.
But i am afraid that opening the class with the popular java decompiler jd-gui it doesnt show the line number in de code decompiled. It shows them for this class compiled with javac -g:lines MyTest.java:
Classfile /D:/Trabajo/NO-SALVAR/jneira/ws/eta/codec-jvm/example/MyTest.class
  Last modified 22-ago-2017; size 389 bytes
  MD5 checksum 3e4a12641dd9e6104c8b5bafc1358576
public class MyTest
  minor version: 0
  major version: 51
  flags: ACC_PUBLIC, ACC_SUPER
Constant pool:
   #1 = Methodref          #6.#14         //  java/lang/Object."<init>":()V
   #2 = Fieldref           #15.#16        //  java/lang/System.out:Ljava/io/Prin
tStream;
   #3 = String             #17            //  MyTest
   #4 = Methodref          #18.#19        //  java/io/PrintStream.println:(Ljava
/lang/String;)V
   #5 = Class              #17            //  MyTest
   #6 = Class              #20            //  java/lang/Object
   #7 = Utf8               <init>
   #8 = Utf8               ()V
   #9 = Utf8               Code
  #10 = Utf8               LineNumberTable
  #11 = Utf8               main
  #12 = Utf8               ([Ljava/lang/String;)V
  #13 = Utf8               StackMapTable
  #14 = NameAndType        #7:#8          //  "<init>":()V
  #15 = Class              #21            //  java/lang/System
  #16 = NameAndType        #22:#23        //  out:Ljava/io/PrintStream;
  #17 = Utf8               MyTest
  #18 = Class              #24            //  java/io/PrintStream
  #19 = NameAndType        #25:#26        //  println:(Ljava/lang/String;)V
  #20 = Utf8               java/lang/Object
  #21 = Utf8               java/lang/System
  #22 = Utf8               out
  #23 = Utf8               Ljava/io/PrintStream;
  #24 = Utf8               java/io/PrintStream
  #25 = Utf8               println
  #26 = Utf8               (Ljava/lang/String;)V
{
  public MyTest();
    flags: ACC_PUBLIC
    Code:
      stack=1, locals=1, args_size=1
         0: aload_0
         1: invokespecial #1                  // Method java/lang/Object."<init>
":()V
         4: return
      LineNumberTable:
        line 1: 0

  public static void main(java.lang.String[]);
    flags: ACC_PUBLIC, ACC_STATIC
    Code:
      stack=2, locals=1, args_size=1
         0: getstatic     #2                  // Field java/lang/System.out:Ljav
a/io/PrintStream;
         3: ldc           #3                  // String MyTest
         5: invokevirtual #4                  // Method java/io/PrintStream.prin
tln:(Ljava/lang/String;)V
         8: return
      LineNumberTable:
        line 5: 0
      StackMapTable: number_of_entries = 1
           frame_type = 0 /* same */

}

The only significative diff is with javac the LineNumberTable is generated for the class definition too. I suppose the order in the attr generation doesnt matter.
However, i still have not tested if the stacktraces and debuggers can use the actual LineNumberTable generated

The Eclipse Class Decompiler shows the line number:
/*** Eclipse Class Decompiler plugin, copyright (c) 2016 Chen Chao<EMAIL_ADDRESS>***/
/*   */ public class Test
/*   */ {
	/*   */ public static void main(String[] paramArrayOfString)
	/*   */ {
		/* 5 */ while (1 + 1 == 0)
			;
		/*   */ }
	/*   */ }

Looks good. We'll probably figure out as we go what the reasons for not showing up in jd-gui are. Will merge for now.


Improved view for mobile screen

Currently the UI is made with desktop viewports in focus, tweak the designs so that screens look good in mobile view too

Closed as part of #25


Export to Lat-Long feature

As requested by @taavimetso9178 in this comment. The Maths is already implemented in the latlong_conversion branch, just gotta port it over.

Finished the export feature. Implemented as both a Equirectangular / lat-long and normal screenshot in any resolution that the user desires. (With the graphics card's texture resolution being the limit).

What's really fun is playing around with world rotation, whilst viewing the Equirectangular projection. Maybe I should unlock this feature to the user as well. 🤔
https://github.com/FrostKiwi/Mirrorball/assets/60887273/8f267346-aff6-4fc8-b7d7-43eda7d93739


Possible issue in upcoming Angular V6

Just been having a play with angular v6 and get a lot of errors relating to ng2-rx-componentdestroyed
If it's just used on it's own it's fine i.e
.pipe(untilComponentDestroyed(this))

but when used with another operator I get errors i.e
    this.route.params
      .pipe(
        untilComponentDestroyed(this),
        switchMap((params: any) => {
          return this.service.findOne(params['id']);
        })
      )
      .subscribe();

which gives an error of
Argument of type '(source: Observable<Params>) => Observable<Params>' is not assignable to parameter of type 'OperatorFunction<Params, {}>'

@dottodot How does the import for switchMap look like?

import { switchMap } from 'rxjs/operators';

@dottodot I added a test to simulate your bug:
https://github.com/w11k/ng2-rx-componentdestroyed/blob/f169eb8a122215be9d81054d396cba554a9f7dd1/src/test.ts#L63
However, I was unable to reproduce it.

In which line does the error occur?
How does the import-code looks in the this.service file? I wonder if it is a import {Observable} from "rxjs" vs import {Observable} from "rxjs/Observable" issue.
Is your switchMap code working without untilComponentDestroyed?

The error occurs during the build, and in vscode highlight the issue. If I remove untilComponentDestroyed there are no error at least in vscode. I have it in a lot of places so not to keen on trying to remove it for now.
I don't have any import {Observable} from "rxjs"  anywhere just notice all these error I have and well, so wondering if it's more an issue with rxjs
node_modules/rxjs-compat/add/operator/catch.d.ts(1,10): error TS2305: Module '"/node_modules/rxjs/internal-compatibility/index"' has no exported member '_catch'.
node_modules/rxjs-compat/add/operator/filter.d.ts(1,10): error TS2305: Module '"/node_modules/rxjs/internal-compatibility/index"' has no exported member 'filter'.
node_modules/rxjs-compat/add/operator/finally.d.ts(1,10): error TS2305: Module '"/node_modules/rxjs/internal-compatibility/index"' has no exported member '_finally'.
node_modules/rxjs-compat/add/operator/map.d.ts(1,10): error TS2305: Module '"/node_modules/rxjs/internal-compatibility/index"' has no exported member 'map'.
node_modules/rxjs-compat/add/operator/mergeMap.d.ts(1,10): error TS2305: Module '"/node_modules/rxjs/internal-compatibility/index"' has no exported member 'mergeMap'.
node_modules/rxjs-compat/add/operator/share.d.ts(1,10): error TS2305: Module '"/node_modules/rxjs/internal-compatibility/index"' has no exported member 'share'.
node_modules/rxjs-compat/add/operator/switchMap.d.ts(1,10): error TS2305: Module '"/node_modules/rxjs/internal-compatibility/index"' has no exported member 'switchMap'.
node_modules/rxjs-compat/add/operator/takeUntil.d.ts(1,10): error TS2305: Module '"/node_modules/rxjs/internal-compatibility/index"' has no exported member 'takeUntil'.

Although just updated to
    "rxjs": "^6.0.0-rc.0",
    "rxjs-compat": "^6.0.0-rc.0",

and those errors have gone but the one relating to untilComponentDestroyed haven't
By the way I don't have any such issues using Angular 5.2.9

huge fan of this operator
Error:(36, 13) TS2345: Argument of type '(source: Observable<{}>) => Observable<{}>' is not assignable to parameter of type 'OperatorFunction<{}, {}>'.
  Types of parameters 'source' and 'source' are incompatible.
    Type 'Observable<{}>' is not assignable to type 'Observable<{}>'. Two different types with this name exist, but they are unrelated.
      Types of property 'source' are incompatible.
        Type 'Observable<any>' is not assignable to type 'Observable<any>'. Two different types with this name exist, but they are unrelated.
          Types of property 'source' are incompatible.
            Type 'Observable<any>' is not assignable to type 'Observable<any>'. Two different types with this name exist, but they are unrelated.
``` in Angular 6

@CD-UNCC I just copied the contents of index.ts into a file and imported that instead and don't get the errors. Not sure why that would be but at least it works.

@dottodot changing the import statement in index.d.ts to import {Observable} from 'rxjs/internal/Observable'; seems to resolve the compile error.

@dottodot @CD-UNCC I am pretty sure that the error relates to RxJS 5 vs 6. As @dottodot wrote, the error does not occur in Angular 5.2.9 (which uses RxJS 6).
I will release a new version for Angular6/RxJS6 very soon.

@dottodot @CD-UNCC I released the version 3.0.0. It should work now with Angular6/RxJS6


weighted average function

I'm trying to write a weighted average function that ignores the NA. As Spark SQL already has some basic aggregation function, I'm wondering whether there is a good way to invoke those functions and pack them into other R equivalent functions such as weighted.mean.

spark_version <- "2.1.0"
sc <- spark_connect(master = "local", version = spark_version)
df <- data.frame(A = as.numeric(c(1, 0, NA, 2)),
                 B = as.numeric(c(0, NA, 1, 3)),
                 w = as.numeric(c(1, 1, 1, 1))
                 )
tbl <- copy_to(sc, df)
tbl %>% summarise(
  A_avg = sum(A * w, na.rm = T)/sum(w * as.numeric(!is.na(A)), na.rm = T),
  B_avg = sum(B * w, na.rm = T)/sum(w * as.numeric(!is.na(B)), na.rm = T))
)

It would be nice to have:
weighted_avg <- function(A, w){
  sum(A * w, na.rm = T)/sum(w * as.numeric(!is.na(A)), na.rm = T)
}

tbl %>% summarise(
  A_avg = weighted_avg(A, w),
  B_avg = weighted_avg(B, w)
  )

Thanks!

To ignore NA, you could coalesce the value with 0. For the denominator, you need to only include the weight when the numerator is non-NA, however.


Shovel's powershell command for changing update source

https://github.com/Ash258/Scoop-Core/blob/52fe1646d87ead40b642f112c3105c5aa54da3a5/CHANGELOG.md?plain=1#L274
In Shovel changelog it say they changed the filename from install.json to scoop-install.json so the powershell command in your README only works for Scoop but not Shovel. While the fix is simple (just replace install.json with scoop-install.json) it can cause a lot of confusion to many Shovel users wondering why it won't works.

I am not familiar with this fork. Why using shovel when you can use the original? What are the benefits?

I am not familiar with this fork. Why using shovel when you can use the original? What are the benefits?
I moved to his fork because of the lack of contribution to the original scoop repo back then (you can find some issues on the repo asking if the project is being abandoned or "looking for maintainer"). He also implemented some requested feature in his fork.

What are the exact additions?
What I can see is the opposite. Shovel has been abandoned without any change in 2 years, while Scoop is being constantly maintained. So compatibility with a dead project is not an issue here.


website looks bad on mobile

If anyone has the ability to improve how our site looks on mobile / small screens, I'd appreciate some iterative PRs to improve the site! 🙇♀
cc @flynnduism

Fixed in #327


Task - 649: RACE

One more task from the RACE dataset. (As suggested in PR #176)
task649_race_blank_question_generation -> Generate a fill-in-the-blank question based on the given article and an answer.
Please review.

This task looks good to me. One question: If you have multiple question corresponding to an input, make sure to add them as a list in instance output.
Also, there are 3 old files which you are pushing here. Those files are already part of our tasks. This is intentional? If not, can you remove those files here?

This task looks good to me. One question: If you have multiple question corresponding to an input, make sure to add them as a list in instance output.
Also, there are 3 old files which you are pushing here. Those files are already part of our tasks. This is intentional? If not, can you remove those files here?

There is only one question per input because there exist 1 question for the given answer and article.
And thank you for pointing out extra files, I removed those files.