Fix the heapOverflow in logs.

Multi-stream feature has passed the test.

Codecov Report
Patch coverage has no change and project coverage change: +0.20 :tada:

Comparison is base (e6f5a44) 54.46% compared to head (83ea892) 54.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   54.46%   54.66%   +0.20%
==========================================
  Files          95       95
  Lines       25333    25333
==========================================
+ Hits        13797    13848      +51
+ Misses      11536    11485      -51

Impacted Files
Coverage Δ

src/mqtt/protocol/mqtt/mqtt_quic.c
0.00% <0.00%> (ø)

... and 13 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

actually we should remove all logging from SDK

You are right. But maybe after syncing all the codes from nanonng.


Label size in mobile view are rendered correctly.

It fixes the label size in different views.

#76


Drag too slow(lags) on VictoryVoronoiContainer with big dataset

I was trying to implement a chart  and I wanted to activate the current active point by show showing a marker and a crosshair by using label component. Something like
i was able to achieve this using following code:-
import {VictoryLine,VictoryVoronoiContainer,VictoryGroup,Point} from "victory-native";
import React from "react";
import {G,Line} from "react-native-svg";
import {View,Text} from "react-native";

class ChartPoint extends React.Component {
  state = {

  };

  render () {
    const {
      x,
      y,
      datum,
      activeX
    } = this.props;
    let size = 0;
    let lineContent = null;
    if (datum.x === activeX) {
      size = 10;
      lineContent = (
        <Line
          stroke="grey"
          strokeWidth="1"
          x1={x}
          x2={x}
          y1={y-200}
          y2={y+200}
        />
      );
    }
    return (
      <G>
        {lineContent}
        <Point
          datum={datum}
          size={size}
          symbol={"circle"}
          x={x}
          y={y}
        />
      </G>
    );
  }
}

export default class CustomDataComponent extends React.Component {
  state = {
    "x": 1
  };

  setActiveIndex = (points)  => {
    this.setState({"x": points[1].x});
  }

  render () {
    return (
      <View style={{"flex":1}}>
        <View style={{"marginVertical":20,"alignItems": "center","flex":0.2}}>
          <Text style={{"fontSize": 14}}>Date</Text>
          <Text style={{"fontSize": 16}}>{this.state.x}</Text>
        </View>
        <View style={{"flex":1}}>
          <VictoryGroup
            containerComponent={<VictoryVoronoiContainer
             labels={(d) => (d.y)}
             labelComponent={<ChartPoint />}
            />}
            data={[
              {"x": 1, "y": 2},
              {"x": 2, "y": 3},
              {"x": 3, "y": 5},
              {"x": 4, "y": 4},
              {"x": 5, "y": 7},
              {"x": 6, "y": 8}
            ]}
          >
            <VictoryLine
              style={{
                "data": {"stroke": "#c43a31"},
                "parent": {"border": "1px solid #ccc"}
              }}
            />
          </VictoryGroup>
        </View>
      </View>

    );
  }
}

ChartPoint.propTypes = {
  "activeX": React.PropTypes.number.isRequired,
  "datum": React.PropTypes.object.isRequired,
  "x": React.PropTypes.number.isRequired,
  "y": React.PropTypes.number.isRequired
};

Now this works fine if number of points are less. But if number of points increase say > 200 the mouseTouch event really lags. It takes lot of time to scroll to current point. Attaching a sample video

Can someone please help me on this?

@jinxac It looks like you're using VictoryVoronoiContainer as expected. The only thing I can think of would be moving your labels to VictoryLine rather than VictoryVoronoiContainer, as some extra positioning calculations are carried out for the container. You might also add dimension="x" to VictoryVoronoiContainer to prevent extra work.
if you drop the marker and just use the cursor, you may get better performance with VictoryCursorContainer.

@boygirl really thanks for responding... it works fine with <VictoryCursorContainer />. I somehow had missed this but this fits exactly my use case. with defaultCursorValue  I can even show the current position.

@jinxac thanks for the kind words! and I'm so glad the new VictoryCursorContainer worked well :D

@chrisbolin is there any way i can i put marker(point on active index) using CursorContainer

Hey @jinxac you might be looking for the VictoryVoronoiContainer instead of VictoryCursorContainer. from the VCC docs:

Note that the cursor allows you to inspect the entire domain, not just the data points. If you would like to instead highlight only the data points, consider using VictoryVoronoiContainer.

to expound on that: if you want to inspect the data closes to the mouse, not just where the mouse happens to be, the VoronoiContainer is for you. if you want to have a vertical line on the closest data point, you could use a different labelComponent with VoronoiContainer.

I tried that, but it becomes VoronoiContainer becomes very slow with huge
data set. Can u please check the gif attached for this bug?
On Fri, 14 Jul 2017 at 7:34 PM, Chris Bolin<EMAIL_ADDRESS>wrote:

to expound on that: if you want to inspect the data closes to the mouse,
not just where the mouse happens to be, the VoronoiContainer is for you. if
you want to have a vertical line on the closest data point, you could use a
different labelComponent
https://formidable.com/open-source/victory/docs/victory-voronoi-container/#labelcomponent
with VoronoiContainer.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/FormidableLabs/victory-native/issues/120#issuecomment-315367514,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOXrwHq57ddDB0W3fsaDhxQ4zrFTmWYcks5sN3U1gaJpZM4OWue9
.

@chrisbolin can u please share your comments on this? I think I would need VoronoiContainer because i need to get the active points to show in the different view. Will it be possible to get current active point in CursorContainer?

@jinxac sorry for the confusion!
Here's how I would summarize:
If you're interested in highlighting the position of the mouse, use Cursor.
If you're interested in highlighting the data point closest to the mouse, use Voronoi.

@chrisbolin thanks for the reply
I got this
If you're interested in highlighting the position of the mouse, use Cursor.
If you're interested in highlighting the data point closest to the mouse, use Voronoi.

But Voronoi works really slow when number of data points increase. Can you please tell how should i handle this?

@jinxac sorry for the delay - hit me on weekend :P
We use d3 for the Voronoi logic, so I don't know if we'll be able to eke out too much more performance there. Of course, if you have suggestions on the improving the implementation I am definitely open to it!
I know it can feel like an ugly solution, but decreasing the number of data points - in a smart way, of course - could be your best approach. We have an new guide on this topic here. (It hasn't even been published yet).

a few more things...

i'm assuming that this is slow without the custom labelComponent={<ChartPoint />}. Is that correct?
in your example code VictoryGroup isn't necessary; VictoryLine can take a containerComponent prop directly. But I don't think that should improve perf much.

@chrisbolin
I went through this documentation but in our case user can interact with chart anywhere and we need to get the active points. If i filter data and use wont be able to interact with all the points. Please correct me if I am wrong.
And:-

i'm assuming that this is slow without the custom labelComponent={}. Is that correct?

-Yes

in your example code VictoryGroup isn't necessary; VictoryLine can take a containerComponent prop directly. But I don't think that should improve perf much.

I tried that already but still the lag.

@jinxac i bet we can make this work!
is your data always ordered by x? (it looked like it might be, as your mockup said "Date") If it is always ordered, then we could probably use VictoryCursorContainer's onChange callback to find the closest data point very efficiently using a binary search - kinda like lodash.sortedIndexBy, or an even closer example in python.

the reason i'm suggesting not using Voronoi is that from your GIF I am deducing that the closest point search is just taking too long.

I tried using onChange on CursorContainer. From what i understood it gives
me current cursor position. So i if drag on y axis my y value keeps on
changing. If i slide exactly on line it gives me correct value.
On Tue, 18 Jul 2017 at 7:04 PM, Chris Bolin<EMAIL_ADDRESS>wrote:

the reason i'm suggesting not using Voronoi is that from your GIF I am
deducing that the closest point search is just taking too long.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/FormidableLabs/victory-native/issues/120#issuecomment-316065178,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOXrwDrF1jMrH-akUf9Pm7H5rNsvPTs8ks5sPLRfgaJpZM4OWue9
.

for sure, you are absolutely right. I was talking about putting some logic on top of that. Let me whip up a demo. But is it safe to say that your data is sorted? Or you could make it sorted relatively efficiently?

Yes data is in increasing order of dates. We show data from past 5 years.
On Tue, 18 Jul 2017 at 7:36 PM, Chris Bolin<EMAIL_ADDRESS>wrote:

for sure, you are absolutely right. I was talking about putting some logic
on top of that. Let me whip up a demo. But is it safe to say that your data
is sorted? Or you could make it sorted relatively efficiently?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/FormidableLabs/victory-native/issues/120#issuecomment-316074022,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOXrwL3RnOgTPCtl1PNGa1ZZk2l5PIkoks5sPLuDgaJpZM4OWue9
.

perfect - and what is the rough size of the data set? 100 points, 1000 points?

Yes max to max 3000
On Tue, 18 Jul 2017 at 7:44 PM, Chris Bolin<EMAIL_ADDRESS>wrote:

perfect - and what is the rough size of the data set? 100 points, 1000
points?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/FormidableLabs/victory-native/issues/120#issuecomment-316076903,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOXrwGvOxLcaSmXnunk7gLIEVlUkYWpzks5sPL2wgaJpZM4OWue9
.

alright, sorry for the delay. check out https://jsfiddle.net/chrisbolin/rz0rwdh2/

The demo relies on a simple function for efficiently finding the closest data point to the cursor (note the comment on assumptions)...
const findClosestPointSorted = (data, value) => {
	// assumes 3 things:
  // 1. data is sorted by x
  // 2. data points are equally spaced
  // 3. the search is 1-dimentional (x, not x and y)
  if (value === null) return null;
	const start = first(data).x;
	const range = (last(data).x - start);
  const index = Math.round((value - start)/range * (data.length - 1));
  return data[index];
};

Also, a few notes on data size:

I think there is a limitation in Victory that slows all events (Cursor, Voronoi, etc) when data size gets in the thousands. I'll file a bug on this and link it to this issue
From a practical point of view, there is almost no use to data sizes over ~400; if the device only has an effective pixel width of ~375 pixels, you can't hope to have the cursor interact with more than ~375.

to summarize, i think that above example is an efficient way of answering your question from 4 days ago:

is there any way i can i put marker(point on active index) using CursorContainer ?

First of all thanks for creating a demo and sharing it :) . This example works fine with less points but as you said with large number of points it becomes slow.

From a practical point of view, there is almost no use to data sizes over ~400; if the device only has an effective pixel width of ~375 pixels, you can't hope to have the cursor interact with more than ~375.

We have in a use case in which were working on charts for stocks for we need to show data for past 10 years(data of each data comprising one point) . So it would come close to 365 *10 points.

To sum it up we have 5 different variations of charts which would range from 1Month(30 points) to 10 years(3650 points).

Oh, i totally understand why your underlying dataset would be in the thousands. But many of those individual points will get lost. Here's what I mean by data reduction: http://jsfiddle.net/chrisbolin/ufn9xtub/

This might be related https://github.com/facebook/react-native/issues/7221

Is VictoryCursorContainer supposed to have some kind of PanResponder API? Docs don't mention anything about it, but I can't get a vertical line to show up when swiping on a VictoryScatter.

I'm experiencing the same lag (especially Android, but also iOS) when not working with large datasets (8 datapoints per dataset, but when I put several (12) datasets in VictoryLine components in a VictoryGroup parent, like below:
render() {
    const { datasets, onCursorChange } = this.props

    return (
      <VictoryChart
        width={360}
        height={400}
        containerComponent={
          <VictoryCursorContainer
            cursorDimension="x"
            onCursorChange={onCursorChange}
            cursorComponent={<Line style={{ stroke: 'red', strokeWidth: 2 }} />}
          />
                }
      >
        <VictoryGroup>
          {datasets.map(dataset => (
            <VictoryLine
              key={dataset.label}
              data={dataset.data}
              alignment="middle"
              style={{
                        data: {
                          stroke: dataset.color,
                          strokeWidth: 2
                        }
                      }}
              interpolation="natural"
            />
                  ))}
        </VictoryGroup>
      </VictoryChart>
    )
  }

With only one dataset, performance is very good!
I there a way to do this performantly for multiple VictoryLine or VictoryScatter components in a VictoryGroup component?
One dataset looks like:
const dataset = {
  label: 'Serie1',
  color: '#a83a62',
  data: [
    {
      x: 1,
      y: 28.52
    },
    {
      x: 2,
      y: 25.37
    },
    {
      x: 3,
      y: 25.6
    },
    {
      x: 4,
      y: 25.16
    },
    {
      x: 5,
      y: 27.78
    },
    {
      x: 6,
      y: 24.39
    },
    {
      x: 7,
      y: 25.84
    },
    {
      x: 8,
      y: 27.27
    }
  ]
}

The datasets prop would be an array of 12 of these datasets.

@karaoak that is unexpectedly slow for such a small number of datasets. Based on your code above, I don't think you need the VictoryGroup wrapper around your 12 lines. You might get better performance if you remove it.

@boygirl Thank you for your quick answer and suggestion. I just tested. Unfortunately removing the VictoryGroup does not result in a better performance 😥
With less Line components, performance is very good.
I think of investigating to only onTouchMove add an eventHandler and draw the vertical cursor line outside of my VictoryChart component.
Would that be a good direction to investigate upon?

I was following this issue, because initially I had the problem as described in issue #244
Because of issue #28 the alternative solution as I saw is unfortunately not possible.
Because of these issues that result in not being able to set up performant chart interactions on device, we are moving to implement: https://github.com/wuxudong/react-native-charts-wrapper
This wrapper and these native iOS + Android libraries facilitate in our chart interaction needs.

@chrisbolin I need help here,
VictoryCursorContainer cursorLabel x-Axis data doesn't control it and cursorComponent Line color doesn't change.
https://drive.google.com/a/ewallsolutions.com/file/d/10oqP8EN3PIiu1KCxFzcLHPYFKmBJQ3nR/view?usp=drivesdk
when i give cursorComponent Line color
https://drive.google.com/a/ewallsolutions.com/file/d/14uw1Q8CA6b3lKEaSN9n1Z5IZHmow209_/view?usp=drivesdk

@yogeshR5 your question is unrelated to this issue. I have answered your question here: https://github.com/FormidableLabs/victory/issues/1044 and in gitter.

Performance related issues are all now being tracked here: https://github.com/FormidableLabs/victory-native/issues/369

@chrisbolin how did you get to this way of finding how to reduce the amount of points? Not totally sure I understand the mathematical basis for this.
Thanks so much for the help. This was a life-saver.
https://jsfiddle.net/ufn9xtub/23/
      const k = Math.pow(2, Math.ceil(Math.log2(filtered.length / maxPoints)));
      let optimizedPoints = filtered.filter(
      	(d, i) => (((i + startIndex) % k) === 0)
      );

via https://github.com/FormidableLabs/victory-native/issues/120#issuecomment-316154918

gotcha yep, thanks this is definitely helpful. I'm wondering what the benefit of const k = Math.pow(2, Math.ceil(Math.log2(filtered.length / maxPoints))); is over const k = Math.ceil(filtered.length / maxPoints)));?
As a whole, this is a super useful suggestion that's saved my team tons of time. The mathematical basis for the Math.pow(2, Math.log2(x / y)) was what I was trying to get at.

@JackHowa sorry I wasn't clear. const k = Math.pow(2, Math.ceil(Math.log2(filtered.length / maxPoints))); makes is so that the k values is always a power of two. The k value is used to pick points (i + startIndex) % k) === 0, so if it is always a power of two, you can ensure that the same points are chosen even as the number of points you're selecting from changes (especially noticeable when zooming out).

Oh, I see. So the same values are picked -- not just same amount. That's really brilliant. Nice work. Since I didn't understand its importance, I did Math.log2(filtered.length / maxPoints). Thanks for explaining. VictoryNative has been a life-saver


Correctly handle swagger 1.2 basePath

fixes issue #21

Hi !
Thanks for contributing !
I can't accept your fix as it uses jQuery ... Could you try doing the same using AngularJS only ?
Regards

Angular implemented jQuery as documented in FAQ so I don't see this to be a problem.
My PR also added support for proxy to take care cases such as https hosted angular-swagger-ui failed to explore http hosted API because of https forbidding http ajax request.

If you don't load jQuery function '$' is not available.
As described in angular documentation: If jQuery is available, angular.element is an alias for the jQuery function'. If jQuery is not available, angular.element delegates to Angular's built-in subset of jQuery, called "jQuery lite" or "jqLite."
Therefore angular.element should be used instead of $


Update version to 1.0.81-8 on staging

Update version to 1.0.81-8

🚀 Deployed to staging         in version: 1.0.81-8🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production         in version: 1.0.82-7🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


kill backup page

https://github.com/concrete5/concrete5/issues/4043

I just open a pull request over this pull request: https://github.com/MrKarlDilkington/concrete5/pull/2

Thanks!


Change User-agent to look for in robots.txt records

http://www.robotstxt.org/norobots-rfc.txt 3.2.1 says robots identify themselves as simple product token.
For gocrawl, the token for default user-agent would be 'gocrawl'.
Site owners may not like using "Googlebot (gocrawl vM.m)" as they should include every version number if they want to control robot's behavior.

See #51 and #41 . Basically - this is just a default, it can and should (as mentioned in the readme) be set to something else by the user of the package. I'll make this more obvious in the doc.

Updated the docs and example to make that stand out.


label_class not working for text_area

When using:
f.text_area :description, rows: 5, label_class: 'my-class'

it expands to:

  Description

    <textarea rows="2" label_class="my-class" class="form-control" name="item[description]" id="item_description">Sample description</textarea>

Instead of 'my-class' being added to the  class property as I expected, a new property called 'label_class' is added to the <textarea>.
After a quick scan through the code, I suspect the private label_class is causing some conflict with the :label_class optional parameter.
Any help is much appreciated.

UPDATE: Please disregard my original post.  The problem was fixed with a reinstall of the gem and reboot of the rails server.  Thanks for a very useful gem!


Allowed_types None

Fix the Setting allowed_types None to not cast the type but to just place None.

Fixed in commit 942a082d95d56fc74fde7f4e6db1f4ad347074b2


proxy_protocol listener filter: Allow configuration for specific proxy protocol version

Title: proxy_protocol listener filter: Allow configuration for specific proxy protocol version
Description:
Currently the type.googleapis.com/envoy.extensions.filters.listener.proxy_protocol.v3.ProxyProtocol will try to match incoming connections against both proxy protocol v1 and v2 signatures. While this is convenient, it:

Increases the attack surface of the filter.
(when allow_requests_without_proxy_protocol is enabled) Increases the chance of signature conflicts between proxy protocol v1 requests and non-proxy protocol requests.

It would be nice to configure the filter to only match v1 or v2, especially when we know all connections will have a specific version.
I am happy to take this task on, please assign to me 😄
[optional Relevant Links:]

Proxy protocol config: https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/listener/proxy_protocol/v3/proxy_protocol.proto#envoy-v3-api-msg-extensions-filters-listener-proxy-protocol-v3-proxyprotocol

https://github.com/envoyproxy/envoy/pull/32861 in progress


docs(semantic): improve documentation

#4850  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on  Graphite

Sorry I didn't review as requested. Have been tied up. But just to say thanks @DonIsaac for you continued efforts on improving documentation.


chore: Release v0.4.0

Ready to merge after PR #1894 got merged and Issue #1895 solved

Ready to merge.

Not ready to merge. The app is freezing in API 28. Testing.

Ready to merge after PR #1922 and #1924 IMO.
@anhanh11001 Please test if you find any major bug?

@liveHarshit for now, not really major bugs that I could find


Migrate 'SettingsProfile' page to TypeScript

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/25221
$
Tests

[X] Verify that no errors appear in the JS console

Open App
Go to settings -> profile
Test the Display Name, Contact Method, Status, Pronouns, and timezone pages and ensure that their functionality is not affected by this migration

Offline tests

Open App
Go to settings -> profile
Test the Display Name, Contact Method, Status, Pronouns, and timezone pages and ensure that their functionality is not affected by this migration

QA Steps

[x] Verify that no errors appear in the JS console

Open App
Go to settings -> profile
Test the Display Name, Contact Method, Status, Pronouns, and timezone pages and ensure that their functionality is not affected by this migration

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes

[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)

[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/59809993/6f1d79a1-a129-445c-8688-5e66ab453473

Android: mWeb Chrome
https://github.com/Expensify/App/assets/59809993/1b58bb9d-d324-48d8-b2ad-b35afd45407f

iOS: Native
https://github.com/Expensify/App/assets/59809993/6f1d79a1-a129-445c-8688-5e66ab453473

iOS: mWeb Safari
https://github.com/Expensify/App/assets/59809993/1b58bb9d-d324-48d8-b2ad-b35afd45407f

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/59809993/d809a9d9-69e2-4fa1-b1ee-cc4150d03ba2

MacOS: Desktop

@abzokhattab LEt's merge the newest main please

Typecheck is failing now @abzokhattab

kindly reminder

Sorry, can you please fix the conflict? Then I will do a final review and merge

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/tgolen in version: 1.4.52-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.52-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Update to snapshots 1.0/gradle plugin 3.0 (release candidates)

#46  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rbro112 and the rest of your teammates on  Graphite


Print the command executed in the rustic-compilation buffer

Now now when we do rustic build etc, we get a new rustic-compilation buffer which looks like this:
   Compiling my-package v0.9.0
...
...

Instead having something like this would be better IMO:
  cargo build my-super-package --some-option

   Compiling my-package v0.9.0
...
...

I can volunteer to implement this if others think that this isn't a bad idea. :-)

Sure, makes sense :+1:
And thanks for volunteering ;)


Upgrade to jersey 2.25.1

Coverage remained the same at 84.664% when pulling 16c51d0756ab52043d1740baf891a3446faa5223 on tjcutajar:upgrade-to-jersey-2.25.1 into 8586ca2db36ef79ad6d82d8861a8c269919280fd on dropwizard:master.

We should probably update this in release/1.1.x too

Cherry-picked into release/1.1.x in https://github.com/dropwizard/dropwizard/commit/9ed3f7105a8be23932b2ed28cfaa26e19b17068f


[WIP] GEOMESA-960 Refactored temporal density iterator to range histogram i…

…terator

Comments only PR for now

Signed-off-by: Alex Tatusko<EMAIL_ADDRESS>

it would be nice if we didn't lose the ability to do date buckets - and ints, doubles, etc would be nice too. (that said, I don't think anyone uses the time density so maybe it's ok to lose it - is there a project use case that uses this Long iterator?)

#739 incorporates and expands upon this.


Letter case problem with virtual table names in R package

The duckdb package seems to be throwing an error sometimes, based on the letter case of the virtual dataframe registered.
The following works:
library("DBI")
library("duckdb")

con = dbConnect(duckdb::duckdb(), dbdir=":memory:", read_only=FALSE)

duckdb::duckdb_register(con, "mtcars", mtcars)

DBI::dbGetQuery(con, "SELECT mpg, cyl FROM mtcars WHERE disp >= 200")

The following, with the duckdb virtual table name changed, does not work:
library("DBI")
library("duckdb")

con = dbConnect(duckdb::duckdb(), dbdir=":memory:", read_only=FALSE)

duckdb::duckdb_register(con, "mtcars", MT_cars)

DBI::dbGetQuery(con, "SELECT mpg, cyl FROM MT_cars WHERE disp >= 200")

The following error is thrown:
Error in .local(conn, statement, ...) :
  duckdb_prepare_R: Failed to prepare query SELECT mpg, cyl FROM MT_cars WHERE disp >= 200
Error: Catalog Error: Table with name mt_cars does not exist!
LINE 1: SELECT mpg, cyl FROM MT_cars WHERE disp >= 200

I came across this error when building out the duckdf functionality, where the dataframe name is dynamically passed to duckdb to create the virtual table. Obviously, I have no control over how the end user names their dataframes! Logic to make everything lowercase is possible, but then the user's resulting SQL query also then needs to match the virtual table name and things get complex.....
Session Info:
r$> sessionInfo()
R version 4.0.3 (2020-10-10)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Debian GNU/Linux 10 (buster)

Matrix products: default
BLAS:   /usr/lib/x86_64-linux-gnu/openblas/libblas.so.3
LAPACK: /usr/lib/x86_64-linux-gnu/libopenblasp-r0.3.5.so

locale:
 [1] LC_CTYPE=en_GB.UTF-8       LC_NUMERIC=C               LC_TIME=en_GB.UTF-8        LC_COLLATE=en_GB.UTF-8     LC_MONETARY=en_GB.UTF-8    LC_MESSAGES=en_GB.UTF-8    LC_PAPER=en_GB.UTF-8
 [8] LC_NAME=C                  LC_ADDRESS=C               LC_TELEPHONE=C             LC_MEASUREMENT=en_GB.UTF-8 LC_IDENTIFICATION=C

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] duckdb_0.2.4 DBI_1.1.1

loaded via a namespace (and not attached):
[1] compiler_4.0.3

I believe this is expected behaviour. If you create a table with an uppercase name you will have to quote them in queries like so: DBI::dbGetQuery(con, "SELECT mpg, cyl FROM \"MT_cars\" WHERE disp >= 200")

See #1410 and #1411

This should be fixed in master. Please reopen if problem persists.


Migrate fresh

Noticed this option to migrate fresh wasn't an option, is that intended? php artisan pscale:migrate:fresh Very much needed when developing fresh applications.

+1

That's a very destructive thing to do to a production database, I'm not sure why you'd want to do that, but in that case you can just delete the current branch and start over with a new one.


Purge check and change newmemstore/newtableshard to use options

Items included in this pr:

AcquireToken from bootstrapserver when do data purge
use options to replace multiple arguments in NewTableShard/NewMemStore
add back token checking during start boorstrap session to avoid purge job running during session start

Codecov Report

Merging #203 into master will increase coverage by 0.01%.
The diff coverage is 79.66%.

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
+ Coverage   74.35%   74.37%   +0.01%
==========================================
  Files         148      149       +1
  Lines       19876    19911      +35
==========================================
+ Hits        14779    14809      +30
- Misses       3979     3984       +5
  Partials     1118     1118

Impacted Files
Coverage Δ

datanode/bootstrap/bootstrap_server.go
79.67% <100%> (+0.7%)
:arrow_up:

memstore/memstore.go
83.15% <100%> (ø)
:arrow_up:

memstore/options.go
100% <100%> (ø)

memstore/table_shard.go
90.32% <100%> (ø)
:arrow_up:

memstore/live_store.go
80.28% <100%> (ø)
:arrow_up:

memstore/test_factory.go
68.55% <100%> (+0.41%)
:arrow_up:

memstore/recovery.go
72.63% <37.5%> (+0.19%)
:arrow_up:

memstore/ingestion.go
81.15% <50%> (ø)
:arrow_up:

memstore/purge.go
87.5% <50%> (-2.21%)
:arrow_down:

memstore/backfill.go
74.5% <66.66%> (+0.21%)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af66ad7...7401e0e. Read the comment docs.


The problem seems to be that lib/representable/pipeline.rb does not define the constant Pipeline::Debug referenced in lib/representable/hash_methods.rb:7.

I checked and lib/representable/debug.rb defines that constant, but it is not required automatically by the gem.

Oh thanks, that shouldn't be referenced at all!


Update nf-core-tools.mdx

Put a little more meat on the bones.. 😁

Image looking a bit rough after being hacked through various screenshots and resizing, but still more colourful than before.. I'll try to remember to generate a nicer image another day (or can ditch it in favour of the current image if you prefer).

Thanks


Upped CloudAux to 1.1.3 to address #574 🛢

New CloudAux address #574.
A follow up PR will add an ephemeral section as discussed in https://github.com/Netflix-Skunkworks/cloudaux/issues/21.

Coverage remained the same at 54.411% when pulling 877620eda2935be2fd4b127505558b424daf7631 on mikegrima:cloudaux113 into dcb557d7cf37dc4adb3592d127e80cc9751cad20 on Netflix:develop.


Readurl is not working in VS

I was trying to execute readurl function in the extension with and without classpath but somehow both are not working...
While reading using readurl ( classpath :// )
I kept file inside resources folder and without classpath I tried keeping file in my c directory.
Could you please try and confirm this is working for you .
In both cases I get file not found
I am checking on windows.

Hi @dkdarshu45 can you please attach an example app that reproduces the issue?

try adding src/main/resources as a resource in your pom.xml (till this is a fixed in a new release)
        <resources>
            <resource>
                <directory>src/main/dw</directory>
            </resource>
            <resource>
                <directory>src/main/resources</directory>
            </resource>
        </resources>

If you run a test that should run maven for you, if you want to run a preview you'll have to run maven from the terminal before that
mvn process-resources

Thanks @svacas . It's working fine with the workaround you mentioned. Only thing is we run mvn clean  then we again need to run mvn process-resources for the preview feature to work as expected

right, that's how maven works, you can run both together to get a clean classpath generated
mvn clean process-resources

To add to that if I want to change content of the file read on classpath preview feature is not updated each time we need to run mvn clean as you said. if I update the file contents directly inside target folder preview feature works fine.
I wanted to use this plugin similar to playgrou

This is a bug and it should work as you said it should not be required to do mvn clean  for this to be reflected in the preview. Thanks we will try to address this on next release


bug: flash.treesitter preselects "a" label even if the user has defined custom labels

Did you check docs and existing issues?

[X] I have read all the flash.nvim docs
[X] I have searched the existing issues of flash.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
NVIM v0.10.0-dev-541+g96b94f8d7
Operating system/version
Pop!_OS 22.04 LTS
Describe the bug
This line basically assumes that a is the first label:
https://github.com/folke/flash.nvim/blob/455ba61cd0e48b9e3a28e9e1fa1a3364d57e7538/lua/flash/plugins/treesitter.lua#LL66C30-L66C31
Steps To Reproduce

config.modes.treesitter.labels = "fdsajkl"
vS and see the labels and selection

Expected Behavior
The inner most treesitter node should be preselected (now labelled by f). Instead the node labelled a is selected.
Repro
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
	vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
	vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
	"folke/tokyonight.nvim",
	{
		"folke/flash.nvim",
		opts = {
			modes = {
				treesitter = { labels = "zayx" },
			},
		},
		keys = {
			{
				"S",
				mode = { "o", "x" },
				function()
					require("flash").treesitter()
				end,
			},
		},
	},
	-- add any other plugins here
}
require("lazy").setup(plugins, {
	root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

Good catch!


Resolution for ARRAffinity not desribed

[Enter feedback here]
Hi,
The documentation is talking about two scenarios but only the first one is described.
How to resolve the issue with ARRAffinity cookies? Solution applies to both? Thought the rewrite is limited for set-cookie.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aacd2683-3d38-ac23-22bb-fadd39d16dcc
Version Independent ID: 0eef0b80-ee12-958f-cbf3-e35ab8e7e535
Content: Troubleshoot redirection to App Service URL - Azure Application Gateway
Content Source: articles/application-gateway/troubleshoot-app-service-redirection-app-service-url.md
Service: application-gateway
GitHub Login: @abshamsft
Microsoft Alias: absha

@cstainie Thanks for the feedback! We are currently investigating and will update you shortly.

@cstainie The 2 scenarios are dependent upon which version of the Application Gateway you are using. Using a custom domain name resolves both issues.


Ember UI - Load balancing page is stuck in loading

On rancher master-head cfbd0d3

From any cluster local or downstream clusters --> go to local/default project --> load balancing
Create an ingress with default options
Load balancer is stuck in initializing
If refresh the page, the following errors are seen in the console and the page is stuck in loading

route-recognizer.js:697 Uncaught (in promise) Error: There is no route named  ingress
 at A.handlersFor (route-recognizer.js:697)
    at j.applyToState (router_js.js:1135)
    at s.applyIntent (router_js.js:2148)
    at k (router.js:1353)
    at e._prepareQueryParams (router.js:833)
    at s.normalizeQueryParams (routing.js:53)
    at s._generateURL (routing.js:61)
    at s.generateURL (routing.js:71)
    at t (href-to.js:11)
    at n.compute (href-to.js:56)

Blocked on https://github.com/rancher/rancher/issues/33775

It's failing during initializing in a different way now, closing..


Consider deprecating in favour of redux-immutable

Original thread: https://github.com/gajus/redux-immutable/issues/12#issuecomment-176189454

@gaearon now that this update is out, can I ask you to replace redux-immutablejs with redux-immutable in http://redux.js.org/docs/introduction/Ecosystem.html#utilities?
The current implementation of redux-immutable is less opinionated (ironically, given the 1.0.0 version) and 2x faster (as asserted using [this primitive benchmark](https://github.com/gajus/redux-immutable/blob/5a5af3155073a4883f8cfc39a284e7f38d355dc8/benchmarks/> index.js)) than redux-immutablejs:
starting redux-immutablejs rootReducer iteration
target rootReducer iteration x 338,215 ops/sec ±1.68% (84 runs sampled)

starting redux-immutable rootReducer iteration
target rootReducer iteration x 721,491 ops/sec ±1.21% (89 runs sampled)

I will drop a message to @indexiatech suggesting:

to deprecate redux-immutablejs in favour of redux-immutable
suggest to release createReducer as a separate utility (which is the same route I am taking the Canonical Composition Pattern implementation)

Context:
I have recently released redux-immutable@2 that does no more and no less than allow state and initialState to be an instance of Immutable.Iterable.
I am moving all the Canonical Composition Pattern implementation under a different name that in turn will rely on redux-immutable. @asaf I'd like to suggest to do the same for createReducer.
I am happy to listen to your feedback should you have suggestions for redux-immutable improvement prior to deprecating redux-immutablejs.

Please PR changes to Ecosystem.md?

@gaearon please review this issue, if this makes sense technically to you then I'll put the deprecation message.
Thanks!

Since projects aren't completely equivalent I don't think deprecating it really makes sense unless you decide to split createReducer(). Even if you do, whether to deprecate it is completely up to you.
I have no qualms about there being two competing solutions at all. Competition is great! We will recommend the more performant one officially because people using Immutable usually do so for perf. Ideally I'd love to see collaboration between projects, further improvements to performance and bundle size, etc, so it would be nice if you folks could figure this out between yourselves.
I'm sorry if me merging a PR replacing your library with another came across as sneaky or passive aggressive!

@gaearon ack,
And sure!, not a problem, at the end, we all do the best for the community, aren't we? :-)
Closing,
Asaf.


UTF-8 characters not shown even with correctly selected encoding

It's showing just dots instead of the correct characters.

Can you provide a sample file or a screenshot?

In fact it won't display any accent. Just create a new file and type some accented letters like á, é... they will be replaced by unaccented versions: a, e...

@nobodo See #6.
@RamiroOliva please open a separate issue.


Create common interface for private link

CLI and powershell has examples of how they did this

Set of operations that should be attached to resources that work with private link
set of operations to query private links given resource is attached to
Models around private link (similar to what we have for managed identity)
autorest needs to be updated to generate the new operations

After a quick glimpse of existing definitions regarding private link, I'm wondering whether we can extract common types for it.
So far, there are two problems:
Inconsistent Definition
For example, the PrivateLinkResource has different properties under different RPs:

In appconfiguration, the PrivateLinkResource has requiredZoneNames property.
In automation, the PrivateLinkResource doesn't have that property.

Different Instances Between RPs
Even we can extract common types, the instances are not transferrable between different RPs.
For example, the typical user scenario of PrivateServiceConnection is as follows:

In Network, create a private endpoint in Network.
In Network, create a private service connection between the private endpoint and the target service.
In the target service, approve the private service connection (let's assume is manual approval required).

The problem is that the private service connection you created in Network is actually different from the one you get under the target service. Their Id and Name properties are different. If you have an instance of the connection from Network, you cannot operate the one under the target service RP, and vice versa.
So the common way to process the private service connection under target service is to list all connections, and then operate the one you want to change. See the test case of private service connection under cosmos-db for details.

When NRP team started private link initiative, our team got involved a little late on the technical side. So some of the RP already diverged. But discussing with Arthur Ning, ARM, and NRP 10 mos ago, it was still desired to have a standard for new RP to adopt. Hence the privatelink models have been added to the rest API common types. It is the hope that thru swagger review particularly for new onboard services, we steer them to the common type.  Having said that, I do not know how rigorously it is been enforced to date. Arthur can shed some light on this.
If we all agree that the desire and enforcement are still being pursued, then track 2 should have a standard implementation for those chosen the common definition. Whether is before GA or add after GA would be up to how many RPs adopt this.
If not, we decide to leave this out, we should consider some kind of prefix to disambiguate them. I suspect the developers won't appreciate looking at a list of same-named classes from different RP in the IntelliSense dropdown.

When NRP team started private link initiative, our team got involved a little late on the technical side. So some of the RP already diverged. But discussing with Arthur Ning, ARM, and NRP 10 mos ago, it was still desired to have a standard for new RP to adopt. Hence the privatelink models have been added to the rest API common types. It is the hope that thru swagger review particularly for new onboard services, we steer them to the common type.  Having said that, I do not know how rigorously it is been enforced to date. Arthur can shed some light on this.
If we all agree that the desire and enforcement are still being pursued, then track 2 should have a standard implementation for those chosen the common definition. Whether is before GA or add after GA would be up to how many RPs adopt this.
If not, we decide to leave this out, we should consider some kind of prefix to disambiguate them. Developers probably prefer not to look at a list of same named classes from different RP in the IntelliSense dropdown.

Thanks @allenjzhang !
I confirmed with Arthur Ning's team. They have already applied a few rules to enforce consistent private link definitions across RPs.

R4035 PrivateEndpointResourceSchemaValidation
R4036 ImplementPrivateEndpointAPIs

Also, I check with Java SDK team. They have common interfaces for PrivateLinkResource and PrivateLinkConnection in core package. The difference is that part of Java SDK is manually written, so they can write some codes to fix the inconsistence between the standard definitions and each RP's own definitions.
I think for .net SDK, we can follow the our convention: let autorest.csharp extract common types for private links as much as possible. If an RP has very different definition, we won't cover the gap. Later on, if the RP fixes the inconsistency, that is a breaking change in REST API, and thus it won't be a problem to have the corresponding breaking change in SDK. Considering the private link resource instances are not transferrable between RPs (see above), we should not worry too much about interface changes.

By the way, the Network uses different Resource definitions (e.g. Id, Name are writable), so that it will still have its own private link definitions. I think this is a known issue not restricted to private link resources. Also the private link connection created by Network cannot be re-used in other RPs. So, I think this should be acceptable.

Have some trial and it was not successful. The problem is found: our current type replacement logic will work for the following two scenario:

Type Foo is used as a property type
Type Foo is used as a base class

Private link resources do not belong to the above cases. They are used standalone. So they won't be replaced. We need to modify the logic to replace the MgmtObjectType if it fits certain comment type.
Java SDK doesn't have this problem, because private link resource classes are written by hand.

Per discussion, it's not worth the efforts to replace PrivateEndpointConnection or PrivateLinkResource, because:

Class type replacement is fragile, a little difference in swagger definition can fail it. See the statistics table below. For 5 RPs (with 3 classes of types to replace) we've tried, there are only 2 thorough replacement and 2 partial replacement, out of 15 cases. All the others fail due to various reasons.

RP Name
PrivateEndpointConnection/PrivateEndpointConnectionListResult
PrivateLinkResource/PrivateLinkResourceListResult
CheckNamAvailability

Cosmos
Excessive   "groupId" property, see   https://github.com/archerzz/azure-rest-api-specs/blob/f780b571abddf2fc99233212a00510d3bef6878d/specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2021-06-15/privateEndpointConnection.json#L257
Y
Not a standard API,   see:   https://github.com/archerzz/azure-rest-api-specs/blob/f780b571abddf2fc99233212a00510d3bef6878d/specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2021-06-15/cosmos-db.json#L570

Network
"id" of   "Resource" is writable (known issue of network)
N/A
N/A

Compute
Only "PrivateEndpointConnection", because   "PrivateEdnpointConnectionListResult" has "nextLink"
Y
N/A

Storage
"PrivateEndpointConnection.PrivateEndpoint"   is subresource (inlined definition, see:   https://github.com/Azure/azure-rest-api-specs/blob/719b74f77b92eb1ec3814be6c4488bcf6b651733/specification/storage/resource-manager/Microsoft.Storage/stable/2021-04-01/privatelinks.json#L11)
"RequiredZoneNames"   is IList (investigating…)
Not a standard API,   see:   https://github.com/Azure/azure-rest-api-specs/blob/603a4b41fe1100e273b79ef2de752710af724648/specification/storage/resource-manager/Microsoft.Storage/stable/2021-04-01/storage.json#L82

DeviceUpdate
Failed,   because in v3 types, "Resource" has a "systemData"   property
same
Only CheckNameAvailabilityResponse   can be replaced.     Cannot replace CheckNameAvailablityRequest, because "type"   property is of    "ResourceType" type instead of "string" in   original definition

The purpose of type replacement is for polymorphism, consistent interface, and probably other benefits. Just sharing some data structure is not sufficient. Considering private resource operations still belong to each RP, the bottom line is that we should be able to replace major class types. We don't want the scenario below that only some secondary types are replaced.

Based on the business cases of private endpoint, the corresponding object instances are not transferrable between RPs. They are restricted in each RP domain. (See the discussion above in this thread) So if we could not replace them, it's actually not that important since you won't use the type from one RP to another RP.

However, the type replacement logic is still useful. We should keep it.

This is also related to #1579


Install dependencies quietly

tox-poetry removes a lot of boilerplate from my tox configuration. The one thing that I miss about invoking Poetry in each environment, however, is the ability to use --quiet when running poetry install. The output from this command can be rather verbose, making it really cumbersome to find test errors from any environment other than the last one run.
I'm happy to submit a PR to change
cmd.append("install")

to
cmd.extend(["--quiet", "install"])  # or using += if that's the preferred style of the project

I realize, though, that some folks may want to see this output and so perhaps this behavior should be configurable. I've never worked on a tox plugin before so I'm not sure of the best way to go about doing that, but I can look into it if that's the approach you'd prefer.

tox has -v option:
  -v, --verbose                    increase verbosity of reporting output.-vv mode turns off output redirection for package installation, above level two verbosity flags are passed through
                                   to pip (with two less level) (default: 0)

Maybe we should remove --quiet option if tox started with 2 or more verbose level?

I didn't know about the -vv behavior with pip. Seems like a good idea to mimic that with Poetry. I'll take a look at that later today.

I looked more closely on the output of tox and saw that poetry output is not shown.
If you are referring to the line starting with py39 installed: ..., then the reason of so verbose output is the fact that poetry does not install packages by their names, but chooses the right distribution and installs a specific "file" directly (platform wheel for example). tox shows all installed packages with full path to installed files in this case. Plugin can't control this behavior.

Oh you're right. I thought the difference was the --quiet flag. The difference is actually that I'm using the global Poetry which installs everything outside of the tox environment, thus resulting in nothing to show as installed. That's a shame but it's good to better understand what's going on. Thanks.


Error when trying to open a new window on Spyder

Error when opening a new window

After I updated Spyder to the newest version, I get an error everytime I try to open my code in a new window.
Moreover, some icons in the tool bar looks strange. For example, when you open a pulldown of 'Run', you can see 'Run' in the first row, and there is a triangular icon next to the text 'Run'. In my case, however, the icon and the text 'Run' is overlapping. I have the same issues for all the menus in the pulldowns.
Could you tell me how to fix this problem?

Here is a screenshot of

the UI error I mentioned above.

Hey @dkobayas-cyber, thanks for reporting. This error is already fixed in our latest version (5.0.3).
Since it's still not available in Anaconda, you have two options:

Use our Windows installer, which you can find here.

Create a new environment with conda-forge packages. For that, please close Spyder, open the Anaconda Prompt and run the following commands there:
 conda create -n spyder-cf -c conda-forge spyder
 conda activate spyder-cf
 spyder


Template small fix

also fix {{raw}} bug in {{project-name}}.yml here: https://github.com/blockscout/blockscout-rs/blob/main/service-template/.github/workflows/{{project-name}}.yml#L131

Closed in favor of #820 for better branch naming + description


Integration of Botmill with Spring-boot

Is it possible to integrate botmill with spring-boot

Yes it is.
BotMill framework is just a java library. You can call the built in class load functions we have to load the bots on your Spring-Boot start up context.
//    load the botmill.properties config.
 ConfigurationUtils.loadConfigurationFile();

//    set the tokens
FbBotMillContext.getInstance().setup( ConfigurationUtils.getConfiguration().getProperty(FB_BOTMILL_PAGE_TOKEN),ConfigurationUtils.getConfiguration().getProperty(FB_BOTMILL_VALIDATION_TOKEN));

//    load the bots (@Bot)
ConfigurationUtils.loadBotDefinitions();

Hi,I used the above configuration, but I am getting the following error from heroku
at=info method=POST path="/webhook" host=chat-boot.herokuapp.com request_id=bf841d7b-7f4e-4eac-af0b-6f4cc7c77359 fwd="<IP_ADDRESS>" dyno=web.1 connect=1ms service=11ms status=403 bytes=655 protocol=https
Also added the servlet to the context by adding
   @Bean
    public ServletRegistrationBean dispatchServletRegistration() {
        ServletRegistrationBean registration = new ServletRegistrationBean(new FbBotMillServlet(), "/webhook");
        registration
           .setName(DispatcherServletAutoConfiguration.DEFAULT_DISPATCHER_SERVLET_REGISTRATION_BEAN_NAME);
        return registration;
    }

Do I need to add any other configuration to fix the above error.

Hi,
I got everything setup and seems everything is working fine. I can see the request in the log also. But the Bot doesn't reply to any messages. Is there any other configuration that we need to do.
12:02:38.784 DEBUG [main][FbBotMillNetworkController] Confirmation from Facebook. Recipient ID: [null], Message ID: [null], Result Message: [success]
12:02:59.911 DEBUG [http-nio-8080-exec-1][FbBot] AbstractFbot - Start Initialize
12:02:59.911 DEBUG [http-nio-8080-exec-1][FbBot] AbstractFbot - End Initialize
12:02:59.911 INFO  [http-nio-8080-exec-1][BotMillServlet] BotMill servlet started.
12:02:59.927 DEBUG [http-nio-8080-exec-1][FbBotMillServlet] JSON input: {"object":"page","entry":[{"id":"1723442377696212","time":1499162574914,"messaging":[{"sender":{"id":"1328610440586613"},"recipient":{"id":"1723442377696212"},"timestamp":1499162574757,"message":{"mid":"mid.$cAAZFhUaSwZZjPlLHpVdDQ7ZYAO6p","seq":35602,"text":"hi"}}]}]}
12:03:24.559 DEBUG [http-nio-8080-exec-2][FbBotMillServlet] JSON input: {"object":"page","entry":[{"id":"1723442377696212","time":1499162604131,"messaging":[{"sender":{"id":"1375110925911070"},"recipient":{"id":"1723442377696212"},"timestamp":1499162603940,"message":{"mid":"mid.$cAAZFgVAy_e5jPlM5pFdDQ3wpZo1b","seq":226,"text":"Hi"}}]}]}

Hi, This got resolved when I updated the version to RC-03-snapshot. Thanks

Can you paste your method here? Did you pass the message envelope object?
On Tue, Jul 4, 2017 at 6:44 AM Manojjanaka<EMAIL_ADDRESS>wrote:

Hi,
I got everything setup and seems everything is working fine. I can see the
request in the log also. But the Bot doesn't reply to any messages. Is
there any other configuration that we need to do.
12:02:38.784 DEBUG [main][FbBotMillNetworkController] Confirmation from Facebook. Recipient ID: [null], Message ID: [null], Result Message: [success]
12:02:59.911 DEBUG [http-nio-8080-exec-1][FbBot] AbstractFbot - Start Initialize
12:02:59.911 DEBUG [http-nio-8080-exec-1][FbBot] AbstractFbot - End Initialize
12:02:59.911 INFO  [http-nio-8080-exec-1][BotMillServlet] BotMill servlet started.
12:02:59.927 DEBUG [http-nio-8080-exec-1][FbBotMillServlet] JSON input: {"object":"page","entry":[{"id":"1723442377696212","time":1499162574914,"messaging":[{"sender":{"id":"1328610440586613"},"recipient":{"id":"1723442377696212"},"timestamp":1499162574757,"message":{"mid":"mid.$cAAZFhUaSwZZjPlLHpVdDQ7ZYAO6p","seq":35602,"text":"hi"}}]}]}
12:03:24.559 DEBUG [http-nio-8080-exec-2][FbBotMillServlet] JSON input: {"object":"page","entry":[{"id":"1723442377696212","time":1499162604131,"messaging":[{"sender":{"id":"1375110925911070"},"recipient":{"id":"1723442377696212"},"timestamp":1499162603940,"message":{"mid":"mid.$cAAZFgVAy_e5jPlM5pFdDQ3wpZo1b","seq":226,"text":"Hi"}}]}]}
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/BotMill/fb-botmill/issues/127#issuecomment-312846657,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AERYw48ObUlEqZvhw3NmueYs303mNU5Sks5sKheFgaJpZM4OKZ67
.

Actually what I did was, I added the FbBotMillServlet to the spring boot context by
 @Bean
    public ServletRegistrationBean dispatchServletRegistration() {

        ServletRegistrationBean registration = new ServletRegistrationBean(new FbBotMillServlet(), "/webhook");
        registration.setName(DispatcherServletAutoConfiguration.DEFAULT_DISPATCHER_SERVLET_REGISTRATION_BEAN_NAME);
        return registration;

    }

And then I created the FbBot as follows
@Bot
public class MyBotClass extends FbBot {

    @FbBotMillController(eventType = FbBotMillEventType.MESSAGE_PATTERN, pattern = "(?i:hi)|(?i:hello)|(?i:hey)|(?i:good day)|(?i:home)")
    public void replyWithQuickReply(MessageEnvelope envelope) {
        reply(new AutoReply() {
            @Override
            public FbBotMillResponse createResponse(MessageEnvelope envelope) {
                return ReplyFactory.addTextMessageOnly("Text message with quick replies")
                        .addQuickReply("Quick reply 1", "Payload for quick reply 1").build(envelope);
            }
        });
    }
}

and used the 2.0.0-RC3-SNAPSHOT as the dependency.
You can find the sample project here


Swiping one item at a time (question)

Hey, is there a way to enforce that the carousel only moves one item at a time, no matter how strong/fast the swipe is, without using a method/callback property? It already works relatively well (using the code of example 1, even better when activating momentum it seems), but it's also not too hard to swipe multiple items at a time.

Hi @codejet,
If you didn't read it already, you might find this useful.
I suggest you play with the prop scrollEndDragDebounceValueand set it to smaller values or even 0 (note that this prop only works when momentum is disabled). I also recommend that you take a look at ScrollView's decelerationRate (iOS only). Unfortunately, ScrollView on Android doesn't provide much fine-tuning :-(
Hope this helps anyway.

@codejet I am also looking for this feature. How you have supported this?

sorry @sridhard, i don't have access to the code anymore and after one year also don't remember the details/solution

adding  decelerationRate={0} works for me though the scroll is a little slow

@codejet how to solve this in 2020 because in V3.2.0 property scrollEndDragDebounceValue is removed

Also wondering this, upgraded to 4.0.0-beta and its now possible to swipe through all items with a hard enough swipe.

Any update on this?

Any update on this?

This repo is no longer maintained.


Repo sync for protected CLA branch

The pull request is created from main637812387706844367 to main to fix git push error for protected CLA branch

@opbld17 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"


Hack fcb

Hacke fcb acaunt

Anjing

Ada apa broo?
Pada tanggal Jum, 7 Jan 2022 14:51, achsan22 @.***>
menulis:

Anjing
—
Reply to this email directly, view it on GitHub
https://github.com/blackcodercrush/hack-facebook-teman/issues/17#issuecomment-1007206513,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVDM33RYFNECK733AKV5QVDUU2LOLANCNFSM4V7YTOKA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


llvmOPT=1_ASTCacheFix

hmm, not sure if this makes the cache less useful, the same ASTs were needing different cfuncs, not sure if the error lies within the AST generation instead, but this gets things working. . . albeit slower than OPT=2

Huh, there should be a deeper fix than this. I suspect it's constant folding, add the constant to the str rep of the buffer like in the GPU.

right, right, I was wondering why the same key (AST) was sometimes needing an extra buf or more.. definitely screams something was left our or folded.
thanks for the pointer I'll check it out

yo I need to spend a little more time on this . . it doesn't seem like theres backing for the LLVM buffers, and thats where the GPU buffers are pulling the constants from no? A small explanation would go along way too i'm on the newer end of this stuff

@geohot I added a test and some notes in most recent push. . . added the constant stuff in the string but i think its a bigger issue :/ hopefully not

A lot of lines for this debugging, and I don't really understand what it is. Is there a short fix for this issue?

This is still a work in prog, and theres notes I added in 'external_test_llvm.py' in a new test... X.add(Y).add(Z) is okay, but X.add(X).add(X) computes wrong when MERGE_ELEMENTWISE_OPS is off in lazy.py. When reusing the same buffer the AST string in the cache gets confuzed.. I'm still looking for the fix, this last push was just a debugging session for me.

Marked PR as draft, lmk when ready to merge

adding constants wasn't the issue, but added it anyway, got messed up when RESHAPE ops were introduced so needed to track num bufs in cache key, added a test too


Upper ont

integrated an upper ontology, cleaned up some IRI stuff, renamed the ontology

It should allow you to automatically import the right ontology.

On 25. Jun 2018, at 12:27, Martin Glauer<EMAIL_ADDRESS>wrote:
@MGlauer commented on this pull request.
In catalog-v001.xml https://github.com/OpenEnergyPlatform/ontology/pull/3#discussion_r197749048:

@@ -0,0 +1,5 @@
+
+

+
This seems to be an auto-generated protégé-file. Is it necessary?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/OpenEnergyPlatform/ontology/pull/3#pullrequestreview-131549987, or mute the thread https://github.com/notifications/unsubscribe-auth/ACxNW6IwryEcde7LGFU4nVQbOxFeIn2iks5uALscgaJpZM4U10cy.


refact: improve error handling on requests

This reviews all components and makes sure in case of request error:

Adds a try/catch block to ensure any error is caught
Logs the error on the console
Clears the loading state after success or fail

Links

Developer considerations

[ ] Increment the version number for relevant packages

[ ] This is a new MAJOR version (incompatible API changes were made)
[ ] This is a new MINOR version (functionality was added in a backwards compatible manner)
[x] This is a new PATCH version (backwards compatible bug fixes)

[x] Update the CHANGELOG.md with a summary of the changes

If this is a MAJOR version, what are the breaking API changes? Was anything added to the API?
If this is a MINOR version, what feature was added? Why would consumers want this new version?
If this is a PATCH version, what was fixed?

[ ] Update the appropriate documentation. Keep in mind that this mono repository has README files at the repository, project, and component levels. We want developers to be able to find what they need from the main README, so make sure to add links to component documentation if adding something new.

Steps for Testing/QA

Thanks for considering that feedback! Good work @TiagoFuelber ✅


Implement CI/CD for each PR

What: Implement CI/CD for the IEF project
Why: So we can automate checks and improve our quality
SoW:

[ ] Run typescript linters on the TS code on any PR
[ ] Run any unit or integration tests on any PR

NOTE: dev is our main development branch.

5c4cb1d


patching "about: Update to include router information"

Original PR was here: https://github.com/openshift/online/pull/1465
Trello card for extension property updates: https://trello.com/c/j3CgOkPk/1016-2-add-extension-properties-to-master-config-defaultroutesuffix-customroutesenabled
trying to patch and preserve code owners

cc @abhgupta still need to test this locally to make sure it looks good for 3.9

Tested locally and everything works as it should

added updated screenshots


GLTF - multiple textures share one image load duplicates

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

done


validation_epoch_end needs to return CUDA tensors

🐛 Bug

I'm not sure if this is expected behaviour or not, but upgrading to the latest version (from 0.8.1) caused my validation_epoch_end to break. It appears that a CUDA tensor is expected for the metric where before the tensor was device agnostic.
This was using sklearn's roc_auc_score. I haven't yet got around to testing PL's new metrics.
Feel free to close if this is expected behaviour.
To Reproduce
This is my validation_epoch_end. Uncommenting .to(avg_loss.device) allows this to run with the dev version of PL.
This was run with ddp, precision=16 using Apex AMP.
def validation_epoch_end(self, outputs):
        avg_loss = torch.stack([x["val_loss"] for x in outputs]).mean()
        y_pred = torch.cat([x["y_pred"].squeeze() for x in outputs]).cpu().numpy()
        y_true = torch.cat([x["y_true"].squeeze() for x in outputs]).cpu().numpy()

        metric = torch.tensor(roc_auc_score(y_true, y_pred))  # .to(avg_loss.device)

        tensorboard_logs = {
            "loss/validation": avg_loss,
            "auc": metric,
        }
        return {"val_loss": avg_loss, "log": tensorboard_logs, "auc": metric}

The error message can be seen here: https://github.com/PyTorchLightning/pytorch-lightning/issues/2411#issuecomment-652171874
Code sample

Expected behavior

Environment
Please copy and paste the output from our
environment collection script
(or fill out the checklist below manually).
You can get the script and run it with:
wget https://raw.githubusercontent.com/PyTorchLightning/pytorch-lightning/master/tests/collect_env_details.py
# For security purposes, please check the contents of collect_env_details.py before running it.
python collect_env_details.py

PyTorch Version (e.g., 1.0): 1.5
OS (e.g., Linux): Ubuntu 20.04
How you installed PyTorch (conda, pip, source):
Build command you used (if compiling from source):
Python version: 3.8.2
CUDA/cuDNN version: 10.2
GPU models and configuration: Dual GPU (ddp)
Any other relevant information: Apex AMP

Additional context

I also have a sklearn generated metric that is only logged, with no business being on gpu. Hopefully not intended behavior?

@justusschock @SkafteNicki mind have look? :rabbit:

@Anjum48 this is probably caused by https://github.com/PyTorchLightning/pytorch-lightning/pull/2434 in combination with your dip backend (from here: https://pytorch.org/docs/stable/distributed.html#backends) which does not support CPU tensors (are you using NCCL backend?)
@s-rog can you elaborate on your problem? Maybe in a separate issue since I'm not sure, if this is the same problem here.
cc @williamFalcon ^^

Hi @justusschock, I'm using the default PyTorch install from conda, so I believe NCCL is being used (both GPUs are in the same machine). The weird thing is that this only started happening when I upgraded from 0.8.1 to 0.8.4 so I guess something has changed in ddp?

This is not on ddp itself, but we added a often requested feature and synced the outputs across ddp nodes. And since you probably used nccl backend (which only supports gpu), this probably causes the drawback. Can you try to switch the backend of DDP? Maybe to Gloo or MPI?

I added torch.distributed.Backend('gloo') to the top of my training script and am seeing the same error

@justusschock I have the same issue as OP where my validation_epoch_end returns a cpu tensor like:
return {'log':{'some_sklearn_metric':a_cpu_tensor}}

Hi @justusschock, I'm using the default PyTorch install from conda, so I believe NCCL is being used (both GPUs are in the same machine). The weird thing is that this only started happening when I upgraded from 0.8.1 to 0.8.4 so I guess something has changed in ddp?

FYI, We are testing also against Conda PyTorch distributions

does this mean that the previous implementation was only returning/logging the rank 0 output?

I was also wondering this. I noticed my validation loss double after upgrading to 0.8.4

It is synced/reduced back to process 0 and only logged there :) DO you think it would be better to log from each process with the respective rank as a prefix?

@Anjum48 regarding your persisting error:
adding it at the top of your script doesn't help, since lightning trainer overwrites this. You have to set it in the trainer: https://github.com/PyTorchLightning/pytorch-lightning/blob/master/pytorch_lightning/trainer/trainer.py#L166

Ok I tried it in trainer, and got this error (after disabling AMP):
Loaded pretrained weights for efficientnet-b0
train.py:141: DtypeWarning: Columns (5) have mixed types.Specify dtype option on import or set low_memory=False.
  train_single_fold(args)
GPU available: True, used: False
TPU available: False, using: 0 TPU cores

  | Name      | Type             | Params
-----------------------------------------------
0 | critereon | CrossEntropyLoss | 0
1 | metric    | AUROC            | 0
2 | net       | EfficientNet     | 4 M
Traceback (most recent call last):
  File "train.py", line 141, in <module>
    train_single_fold(args)
  File "train.py", line 65, in train_single_fold
    trainer.fit(model)
  File "/home/anjum/anaconda3/envs/kaggle/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1020, in fit
    self.run_pretrain_routine(model)
  File "/home/anjum/anaconda3/envs/kaggle/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1128, in run_pretrain_routine
    self.reset_val_dataloader(ref_model)
  File "/home/anjum/anaconda3/envs/kaggle/lib/python3.8/site-packages/pytorch_lightning/trainer/data_loading.py", line 342, in reset_val_dataloader
    self._reset_eval_dataloader(model, 'val')
  File "/home/anjum/anaconda3/envs/kaggle/lib/python3.8/site-packages/pytorch_lightning/trainer/data_loading.py", line 268, in _reset_eval_dataloader
    dataloaders = self.request_dataloader(getattr(model, f'{mode}_dataloader'))
  File "/home/anjum/anaconda3/envs/kaggle/lib/python3.8/site-packages/pytorch_lightning/trainer/data_loading.py", line 363, in request_dataloader
    dataloader = dataloader_fx()
  File "/home/anjum/PycharmProjects/kaggle/siim_isic_melanoma_classification/engine.py", line 194, in val_dataloader
    sampler = DistributedSampler(dataset)
  File "/home/anjum/anaconda3/envs/kaggle/lib/python3.8/site-packages/torch/utils/data/distributed.py", line 43, in __init__
    num_replicas = dist.get_world_size()
  File "/home/anjum/anaconda3/envs/kaggle/lib/python3.8/site-packages/torch/distributed/distributed_c10d.py", line 582, in get_world_size
    return _get_group_size(group)
  File "/home/anjum/anaconda3/envs/kaggle/lib/python3.8/site-packages/torch/distributed/distributed_c10d.py", line 196, in _get_group_size
    _check_default_pg()
  File "/home/anjum/anaconda3/envs/kaggle/lib/python3.8/site-packages/torch/distributed/distributed_c10d.py", line 186, in _check_default_pg
    assert _default_pg is not None, \
AssertionError: Default process group is not initialized

I'm not familiar with gloo so I don't know what I'm looking at here. Isn't gloo for CPU only training?

fixed on master for now. all reduce for val will return in a few PRs

It is synced/reduced back to process 0 and only logged there :)

Yes, currently only rank 0 is used for val calculation.

@justusschock @williamFalcon ming clarifying? these two statements seem to be contradicting, unless I'm misunderstanding something...

Originally we didn't reduce on val - it was on our todo. Then we added it, but it had weird issues such as this one. So we removed it and will test it more before adding back in.

I suppose the metric package fixes/bypasses this issue?
I just converted my vanilla sk metrics to the pl sk interface, will test soon.

are you on master?
We won't include a cuda conversion here (we already have a push to self.device), since this also depends on your distributed backend (and you don't have access tp/want the computation to run on a gpu all the times.

@justusschock I just updated and tried again with the same error

do you have any CPU tensors there?

nope both inputs to the lightning sklearn metric are cuda tensors

I think I know the issue. Currently there is a problem with device propagation in utilities.device_dtype_mixin which causes the device property to be set only for the most outer instance. E.g. when you assign the metric to your LightningModule, the device of your metric isn't updated. So far I don't know why though.

not sure at this moment, will check it...

Should this be a separate issue? as it's an issue with metrics and not validation_epoch_end specifically

The bug is that in the device mixin, we have this line:
if device is not None:
            self._device = device

that prevents setting the device.

Just some findings tho
Currently, classification metrics return cpu tensor while regression metrics return cuda tensor, haven't tested with sk-metrics.
COLAB EXAMPLE

@justusschock The problem is simply that when you call .to on the nn.Module, it is not calling .to on the submodules. What the pytorch nn module does instead is only move the tensors (buffers, parameters) of these submodules, since pytorch has no such thing as a device property, the device is simply defined by the device the tensors are on.
We can come up with a creative solution that involves going over all submodules and checking if they are instance of dtypedevicemixin and calling .to on these
But this is not a real solution because if you nest multiple levels of dtype-mixin-subclass and nn.Module in a particular way, it can still lead to the same bug

@Anjum48 the bug should be fixed now, although I was not able to check your use case with precision=16. Let me know if it works or not.

@awaelchli pulled from master and still experiencing the same issue with FP16

Yes, but this is probably something different. If you're using AMP, they don't convert inputs and outputs once, but they monkey patch every function to convert it's inputs and convert it's outputs back...
Are you on slack? Maybe it's best to write me a message there, so that we can easily discuss your issue without spamming all the others :)


Wabi on Slackware 3.1

Ah, Wabi, properly cursed Windows compatibility. I love it. Merged, thank you for your contribution.


4.3.x

Merging 4.3.20200629

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 3

Complexity increasing per file
==============================
- src/main/java/com/shaft/tools/io/PropertiesFileManager.java  1
- src/main/java/com/shaft/cucumber/AssertionSteps.java  2

See the complete overview on Codacy

Merging 4.3.20200629


Autocorrect/autocomplete email addresses aren't recognized in login screen (OTP)

bug reported in discord

symptom: autocorrect/autocomplete email addresses aren't recognized in login screen
freq: always (3 attempts)
OS: android with google keyboard
repro steps:

go to login and partially enter email
select email from suggested text
login

expected: getting login link in email inbox
actual: email is never received (checked spam et al)

Could reproduce the error with suggested text, but the error occurs typing the text too. Needs further investigation on the causes.


Add support for read only HTTP backend

I'm working on this now. I think this feature is very cool!

Implemented in https://github.com/datafuselabs/opendal/pull/368


Revert "Revert "Use raw::c_void for GLvoid.""

Reverts bjz/gl-rs#373
Close #375
After checking, GLvoid is never used alone in the OpenGL specs, so I guess it's ok.

Next up: Revert "Revert "Revert "Use raw::c_void for GLvoid."""


ci: latest pip resolver giving installation errors

Collecting iniconfig
  Downloading iniconfig-1.1.0.tar.gz (8.1 kB)
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'done'
    Preparing wheel metadata: started
    Preparing wheel metadata: finished with status 'done'
ERROR: Requested iniconfig from https://files.pythonhosted.org/packages/44/39/e96292c7f7068e58877f476908c5974dc76c37c623f1fa332fe4ed6dfbec/iniconfig-1.1.0.tar.gz#sha256=150a59361017218f4621a68ea9984772675a7f6e074ff7d02e115152f1804dc6 (from pytest<7,>=6->pytest-invenio==1.4.0->-r .min-3.6-requirements.txt (line 4)) has different version in metadata: '0.0.0'

SImilar issue here -> https://github.com/inveniosoftware/invenio-app/issues/76

A similar issue was solved by pinning iniconfig
Check other repos: https://github.com/search?q=org%3Ainveniosoftware+iniconfig&type=code


Http Local Rate Limit throttled the traffic without exceeding the expected qps

Description:
I am using http local rate limit in a single pod in aws-us-west-2. Below is my settings at the listener:
{
              "name": "envoy.filters.http.local_ratelimit",
              "typed_config": {
               "@type": "type.googleapis.com/envoy.extensions.filters.http.local_ratelimit.v3.LocalRateLimit",
               "stat_prefix": "http_local_ratelimit",
               "token_bucket": {
                "max_tokens": 15000,
                "tokens_per_fill": 15000,
                "fill_interval": "1s"
               },
               "filter_enabled": {
                "default_value": {
                 "numerator": 100
                },
                "runtime_key": "http_local_ratelimit.filter_enabled.default_value.numerator"
               },
               "filter_enforced": {
                "default_value": {
                 "numerator": 100
                },
                "runtime_key": "http_local_ratelimit.filter_enforced.default_value.numerator"
               }
              }
             }

I expect that the http local rate limit wouldn't be triggered before reaching 15000 qps. However, the requests started to be throttled when the qps reached 3000.
I am using Envoy 1.25.9
Did I have any misconfigurations?

cc @wbpcode

I think because the implementation of this filter, it's possible to encounter inaccurate limiting. But 3000 is too low to encounter that.


[Bug]: "Unknown error occurred" after Olarm Upgrade from 2G to 4G

Contact Details
<EMAIL_ADDRESS>What happened?
I upgraded my Olarm Pro 2G device with a Olarm Pro 4G device. I created a new olarm profile for the 4G device. I tried simply changing the api with the newly generated one, but that did not work, I got the error ""Unknown error occurred". I uninstalled the Olarm Sensors Integration to see if that will solve the issue, it did not, I got the same error. I have deleted and Generated the api several times, but that did not work. I also removed the device from my olarm profile and added it again, that also did not work. I am on HA 2024.7.3.
Version
2.0.1
Relevant log output form Home Assistant
This error originated from a custom integration.

Logger: olarm_api_rainepretorius
Source: custom_components/olarm_sensors/config_flow.py:71
integration: Olarm Sensors (documentation, issues)
First occurred: 11:16:48 AM (6 occurrences)
Last logged: 12:12:13 PM

Could not get JSON data due to incorrect API key. Please update the api key
Your api key has been temporarily blocked due to too many request. Increase your scan interval

Downloaded integration debug logs.
This error originated from a custom integration.

Logger: olarm_api_rainepretorius
Source: custom_components/olarm_sensors/config_flow.py:71
integration: Olarm Sensors (documentation, issues)
First occurred: 11:16:48 AM (6 occurrences)
Last logged: 12:12:13 PM

Could not get JSON data due to incorrect API key. Please update the api key
Your api key has been temporarily blocked due to too many request. Increase your scan interval

I solved my problem. I deleted the whole olarm_sensors folder underneath the custom_components folder. I then downloaded a fresh copy of the olarm_sensors from the github page, and uploaded that to the custom_components folder. I generated a new api key on the olarm api page, did a HA server restart and added the Olarm sensors integration again from the devices and services menu. The olarm sensors integration is not available on HACS as the documentation states. You must do a manual install/reinstall.


Crash on startup

Describe the bug
Carpet-Fixes 1.7.7 in Minecraft 1.18.2 in Java 18.0.1 with Fabric 0.14.5 on PolyMC 1.2.2 crashes during startup
To Reproduce
Steps to reproduce the behavior:

Install Java 18.0.1
Download PolyMC
Download Minecraft with Fabric
Install Carpet and Carpet-fixes
Launch

Expected behavior
Not crash
Screenshots
If applicable, add screenshots to help explain your problem.
Minecraft Version:

1.18.2
Carpet-Fixes Version:
v1.7.7
Carpet Version:
v1.4.69

Additional context
log

Fixed in these releases:

22w14a
1.18.x


Added min and max tag ID to getTagMedia()

This enables pagination queries on the getTagMedia API.

Duplicate of #118. Though, this is another approach. I think its better we let the the developer decide what to send to the $params array instead of using default values since its currently not working.

Oops, sorry didn't bother looking into the issues and pull requests section before doing this.
This will be closed. But please merge the others already :)
Thanks for the work on this btw.

We'll fix this issue asap.


[explorer] Deploy next version of website

There is currently a gap between the code on main and the website deployed at https://explorer-demo.sui.io.
The website will need to be redeployed to resolve the following bugs:

Dog disappears when Owner is clicked: https://explorer-demo.sui.io/objects/363124FB1BE19377C39C4356865A8C8430C6AE85
Image stuck on 'Please Wait': https://explorer-demo.sui.io/objects/A033A5126D3EC043A5CF259075B9F7A4F4E789EB

The next version of the website has now been deployed and the above two bugs have been resolved.


Add key information to Request Path to call out limitations of the condition

The "Request Path" match condition should include a notice that it does not include the initial /, similar to the note on the "Request URL":

Key information

When you use this rule condition, note that the match starts after the first / of the path. For example: https://www.<yourdomain>.com/folder/page would start matching on folder/page.

This is slightly annoying as it means you cannot easily match only the root of the site with multiple front ends assigned.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 60119f51-51f3-223f-58d0-38578fbbcc6d
Version Independent ID: 0e633d67-bf20-036f-a59d-10fc538b751b
Content: Azure Front Door Rules Engines match conditions
Content Source: articles/frontdoor/front-door-rules-engine-match-conditions.md
Service: frontdoor
GitHub Login: @duongau
Microsoft Alias: duau

Thanks for the feedback! We are currently investigating and will update you shortly.

@Zhaph Thank you for your suggestion. I have incorporated what you've written into the doc. It will take some time to reflect. PG is aware of this issue and have addressed the request path matching not including the initial / in the new Front Door Standard/Premium SKU Rule Set feature.

#please-close


"Active catalog/Schema" not taken into account in 4.1.1 when using PostgreSQL generic driver

"Active catalog/Schema" not taken into account in 4.1.1 when using PostgreSQL generic driver.
As a result, one should either execute 'set search_path to XXXX' once on connect, or use schema prefixes when referring DB relations.

Can't reproduce.
Pleae open Query Manager view, enable all query types (in "Filters..." dialog) and check what DBeaver does when you change active schema.
It should execute some like
SET search_path = schema-name

Also you can check error log view. Thanks

I think schema name should be surrounded by double quotes (in my case it's in uppercase), otherwise the command just sets the search_path to a non-existing one, which doesn't raise an exception.

Yep, seems to be a bug in DBeaver, thanks for report.


[Feature Request] Translations

Is your feature request related to a problem? Please describe.
The whole system is only in English right now
Describe the solution you'd like
As the project is youg, it would be a good time to implement support for translations for the admin portal but also the status pages and notifications. Admins could select one or more language to display their status pages. In the case of multi-language selection, one text box for each lang will be displayed and translations will be possible from there (or translation API ?).
The language a status page is displayed for a subscriber would also be matched in notifications on registration.

@simlarsen I can look into this later this week, what do you think of react-i18next

@kashalls sure thing! please let me know if you need help.

Is there anything new on this topic?

@choolaboo low priority for us atm, but please feel free to contribute it and integrate i18n.


Product images not loading

I am not sure if I need to tweak a particular setting or what I should do to get this to work.  I can see the images showing up in the local AppData grocy directory, and filetype/size/resolution doesn't seem to matter.

Thanks, I could reproduce this - a PHP extension was missing / not enabled - will be fixed in a new release which will be ready in the next hour...


Unable to change columns size its either 250px or 520px and use resizeHandler

I am unable to change the size of the columns doesn't matter the settings I add. I am currently adding dynamic components, so the module is imported to my main module, then on my components I just import the NgGridItemConfig and NgGridConfig. I can use the grid and some of the functions. but not completely and can't adjust the size of the column.
Also, I am unable to use the resizeHandler, but the moveHandler works like a charm. Any thoughts?
Here's my gridConfig and gridItemconfig:
grid:
private gridConfig: NgGridConfig =  {
margins: [5],
draggable: true,
resizable: true,
max_cols: 0,
max_rows: 0,
visible_cols: 0,
visible_rows: 0,
min_cols: 0,
min_rows: 0,
col_width: 300,
row_height: 300,
cascade: 'up',
min_width: 100,
min_height: 100,
fix_to_grid: false,
auto_style: false,
auto_resize: false,
maintain_ratio: false,
prefer_new: false,
limit_to_screen: true,
zoom_on_drag: true,
};
gridItem:
private widgetConfig: NgGridItemConfig =  {
minWidth: 270,
minHeight: 270,
resizeHandle: '.resizeHandler',
dragHandle: '.dragHandler',
fixed: false,
};

Hmmm, interesting problem. Can you create a plunker to reproduce this at all?

I think you can close this.  I think the col_width was affecting my configuration. Changed it to 50 and set the griditemconfig as sizex and sizey. Now its working. Thank you!


Subscriber widget argument should be builder not child

Subscriber widgets take a Widget child(value) argument. In the Flutter API, all such arguments are called builder, so calling it builder would make things easier to understand (child arguments are actual Widget objects, not functions). Also, it should pass the BuildContext as a context argument: Widget builder(context, value).

Thanks for the feedback. 👍

Think I'll add this to 2023.2.1.beta

Change added to klutter_ui 1.0.0.
Will bump klutter_ui version in klutter dart/gradle libs.


DATETIME incorrectly deserialized as DATE

DATETIME projection is deserialized as datetime.date instead of datetime.datetime:
>>> DB.query("SELECT DATE('2015-01-02 03:04:05') FROM V")[0].oRecordData
{'date': datetime.date(2015, 1, 2)}

I am still seeing this issue: SELECT DATE('2015-01-02 03:04:05') FROM V returns {'DATE': datetime.datetime(2015, 1, 1, 22, 4, 5)}

@jetheurer: this seems to rather be an issue with incorrect timezone settings. Seems like either your OrientDB/JVM instance is parsing the DateTime as GMT+5, while in python you're getting a UTC representation.


Linter not working?

Hi,
I have been following your demo source code for the linter to get it working myself in React but I have been getting no luck. I feel like I copied everything that was needed but the gutter icons still are not showing up. Does something look weird here?
import React, { Component } from 'react';
import './mdn-like.css';
import './TextEditor.css';

const CodeMirror = require('codemirror/lib/codemirror');
require('codemirror/addon/edit/matchbrackets');
require('codemirror/addon/edit/closebrackets');
require('codemirror/addon/lint/lint');
require('codemirror/addon/lint/javascript-lint');
require('codemirror/mode/javascript/javascript');

require('codemirror/lib/codemirror.css');
require('codemirror/addon/lint/lint.css');

export default class TextEditor extends Component {

  componentDidMount() {
    this.editor = CodeMirror.fromTextArea(this.textarea, {
      /* Configuration */
      mode: 'javascript',
      /* theme: 'mdn-like', */
      smartIndent: true,  // javascript mode does bad things with jsx indents
      tabSize: 2,
      lineWrapping: true,
      lineNumbers: true,
      readOnly: false,

      /* Addons */
      matchBrackets: true,
      autoCloseBrackets: true,
      gutters: ['CodeMirror-lint-markers'],
      lint: true,
    });
  }

  render() {
    const editor = <textarea ref={(c) => { this.textarea = c; }} defaultValue="" />;

    return (

          Pretty / Compact / Validate / Copy / Etc

        {editor}

    );
  }
}

Please ignore the mismatch of imports and requires, I was fiddling around to see what works and what doesn't, but my linter nor console is complaining right now.
Any thoughts what could be missing?
Thanks in advance,
Anthony

The bug tracker isn't the right place for this, since the linter is working.