data does not contain any valid RSA or ECDSA certificates

Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug
What happened:
Fresh install of kubevirt on a coreos k8s cluster. Version 13 and 14.
What you expected to happen:
virt-api pods are ready
How to reproduce it (as minimally and precisely as possible):
I don't know if this is related to coreos, seems like...
Anything else we need to know?:
Environment:

KubeVirt version (use virtctl version):
tested it with 14 and 13
Kubernetes version (use kubectl version):

Server Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.2", GitCommit:"cff46ab41ff0bb44d8584413b598ad8360ec1def", GitTreeState:"clean", BuildDate:"2019-01-10T23:28:14Z", GoVersion:"go1.11.4", Compiler:"gc", Platform:"linux/amd64"}

VM or VMI specifications:
coreos nodes running on hardware and vmware combined
OS (e.g. from /etc/os-release):

NAME="Container Linux by CoreOS"
ID=coreos
VERSION=1967.4.0
VERSION_ID=1967.4.0
BUILD_ID=2019-01-28-0558
PRETTY_NAME="Container Linux by CoreOS 1967.4.0 (Rhyolite)"
ANSI_COLOR="38;5;75"
HOME_URL="https://coreos.com/"
BUG_REPORT_URL="https://issues.coreos.com"
COREOS_BOARD="amd64-usr"

Kernel (e.g. uname -a):
Linux k8s-worker-24.lxdev.domain.com 4.14.96-coreos #1 SMP Mon Jan 28 05:16:10 -00 2019 x86_64 Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz GenuineIntel GNU/Linux
Openssl version
OpenSSL 1.0.2p  14 Aug 2018

I spinned up the pod with another entrypoint... The ssl certificate virt-api complains is broken:
[virt-api@virt-api-854bd67fd5-s9h5w ~]$ /usr/bin/virt-api
{"component":"virt-api","level":"warning","msg":"Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.","pos":"client_config.go:548","timestamp":"2019-02-21T12:59:33.788776Z"}
{"component":"virt-api","level":"info","msg":"kubevirt-config ConfigMap does not exist. Using defaults.","pos":"config-map.go:75","timestamp":"2019-02-21T12:59:33.810683Z"}
{"component":"virt-api","level":"warning","msg":"Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.","pos":"client_config.go:548","timestamp":"2019-02-21T12:59:33.810780Z"}
{"component":"virt-api","level":"warning","msg":"Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.","pos":"client_config.go:548","timestamp":"2019-02-21T12:59:33.811464Z"}
panic: error reading /tmp/certsdir847514059/clientCA.crt: data does not contain any valid RSA or ECDSA certificates

goroutine 1 [running]:
kubevirt.io/kubevirt/pkg/virt-api.(*virtAPIApp).Run(0xc000118000)
	/root/go/src/kubevirt.io/kubevirt/pkg/virt-api/api.go:1031 +0x31a
kubevirt.io/kubevirt/pkg/virt-api.(*virtAPIApp).Execute(0xc000118000)
	/root/go/src/kubevirt.io/kubevirt/pkg/virt-api/api.go:170 +0x1c3
main.main()
	/root/go/src/kubevirt.io/kubevirt/cmd/virt-api/virt-api.go:36 +0xc8

[virt-api@virt-api-854bd67fd5-s9h5w ~]$ openssl x509 -in /tmp/certsdir847514059/clientCA.crt -text -noout
unable to load certificate
140510704424768:error:0906D066:PEM routines:PEM_read_bio:bad end line:crypto/pem/pem_lib.c:794:

[virt-api@virt-api-854bd67fd5-s9h5w ~]$ cat /tmp/certsdir847514059/clientCA.crt
-----BEGIN CERTIFICATE-----
MIIDdjCCAl6gAwIBAgIUFmcsO4kU1gOuC5HiW0SP7y6w3dUwDQYJKoZIhvcNAQEL
...
rhNDY6GLdsONY1rck/hn6etVlGbRFobGz8Q=
-----END CERTIFICATE----------BEGIN CERTIFICATE-----
MIIDdjCCAl6gAwIBAgIUFmcsO4kU1gOuC5HiW0SP7y6w3dUwDQYJKoZIhvcNAQEL
...
rhNDY6GLdsONY1rck/hn6etVlGbRFobGz8Q=
-----END CERTIFICATE-----```

It's the same cert twice.

@mmack could you run kubectl delete secrets kubevirt-virt-api-certs and delete all virt-api pods? They should re-create it and start again. It looks like a broken certificate landed in that secret. I wonder how.

I'm getting the same error. I deleted the secret and deleted/recreated the pods but the error persists. Using openshift-intaller+libvirt

@davidvossel do you have any insights?

whoa, this is strange. There's nothing about cert generation that should be related to the kubernetes version. This is all self contained within KubeVirt's virt-api component. I wouldn't expect it to be possible to get all the way to starting the TLS server if the certs weren't generated correctly. looking at the code this seems impossible unless the k8s secret was mutated somehow.
assuming this is a dev cluster that you aren't worried about credentials for, I'd be curious to see the kubectl get secrets -n kubevirt kubevirt-virt-api-certs -o yaml output that is generated.

@mmack @dcritch  so far we never managed to reproduce this. Is this still an issue?

@rmohr I have not seen it reoccur myself. To me, I'd say its no longer an issue

This looks to have been fixed in 0.17.0. In 0.16.0 the client-ca-file datum of the "extension-apiserver-authentication" ConfigMap was prepended with the requestheader-client-ca-file datum.
Except there was no newline between the two certificates. This is shown in the example above:
-----END CERTIFICATE----------BEGIN CERTIFICATE-----

You can see this behavior in [this repl].(https://repl.it/@TerinStock/ThinEarlyMicrostation)
AFAICT, this has nothing to do with the self-signed certificates virt-api created for webhooks and apiservices.

@terinjokes thanks.
/close


AAPT bug: enum/flag attr in a secondary framework

Information

Apktool Version: 2.3.4, 2.4.0-SNAPSHOT
Operating System: Linux, Windows
APK From: Wrote the bug sample myself

Stacktrace/Logcat
$ java -jar apktool.jar b -f framework2 -o framework2.apk
I: Using Apktool 2.4.0-896569-SNAPSHOT
W: Could not find sources
I: Building resources...
I: Building apk file...
I: Built apk...

$ java -jar apktool.jar if framework2.apk -p framework
I: Framework installed to: framework/2.apk

$ java -jar apktool.jar b -f -p framework app -o app.apk
I: Using Apktool 2.4.0-896569-SNAPSHOT
W: Could not find sources
I: Building resources...
W: W/ResourceType(18083): DynamicRefTable(0x02): No mapping for build-time package ID 0x02.
W: W/ResourceType(18083): e[0x01] -> 0x01
W: W/ResourceType(18083): e[0x7f] -> 0x7f
W: E/ResourceType(18083): Failed resolving ResTable_map name at 116 with ident 0x02030000
W: warning: Package not found for resource #02010000
W: W/ResourceType(18083): No known package when getting value for resource number 0x01010000
W: W/ResourceType(18083): Invalid package identifier when getting bag for resource number 0x01010000
I: Building apk file...
I: Built apk...

Steps to Reproduce
This can only be reproduced by using an attr of "enum" or "flag" format that's defined in a secondary framework (forcedPackageId > 0x01) inside an app and then trying to recompile the app against the secondary framework.

The error seems to disappear when forcedPackageId is set to '1' for the secondary framework.
The error seems to disappear when the enum/flag valid value list is empty.
This doesn't happen with any other format of attr (reference, string, integer, boolean, color, float, dimension, fraction).

Sample
This tiny zip is a super-minimalist way to reproduce the issue:
https://www.mediafire.com/file/zri2n3nm30sqhq8/AaptAttrBug.zip/file

Thanks for your time mate, if you need any help, I'm around, although I'm more adept with Java than C++.


inline chat HC themes input contrast is very low

doesn't reproduce in the panel chat

This isn't nice but there's actually no other way to override the foreground color of an editor- because typically you have syntax highlighting. We do this for all the other "input box"-style editors. I think I opened a feature request when I did this. We should align this rule with your rule for coloring the decoration so that it can override it properly.

labeling bug so it gets verified

Thanks @roblourens

@roblourens in the latest insider's, still seeing this

There is two separate issues with different steps. There is difference between rendering of slash command and normal prompt text. @meganrogge the only useful/visible information in the original issue description is slash commands (please use words and not images to describe issues!). For verification you have not used slash commands but normal prompt text which is a different case. Please file a separate issue, use words/steps and don't rely on screen captures with just white and white text

Steps to reproduce/verify

use HC light and dark theme
open inline chat and type a slash command, e.d /doc
make sure the command is readable when selecting its text


Change master to main branch

https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-branches-in-your-repository/changing-the-default-branch#changing-the-default-branch

Renamed. done


Show "end_time" on screen, if populated

If "end_time" is provided by the API endpoint for a meeting, included it on the meeting detail screen.

Fixed here: https://github.com/code4recovery/react/pull/50

Fix is merged, ty


Emphasize score milestones

Figure something to REALLY reward for every 5, 10, etc.

Glow it?
Only put a big space at a milestone so you can revel in it?
Play a sound!


Adds ids to progress cards and labels for automation purposes

fixes #415

cc @Yadnyawalkya
card ids follow the pattern migrationName-progress-card and the progress labels are as requested, size-migrated and vms-migrated

Per https://github.com/ManageIQ/manageiq-v2v/issues/415#issuecomment-419390513, we need this for 5.9 hence marking it g/yes


Make session upvoting more pervasive throughout UI

Make an ajaxy clickable star or something next to sessions anywhere they're shown in a list.
That includes the schedule!
Any other UI changes we can make to encourage upvoting?

I heard feedback from someone that they didn't know which sessions they'd voted for. This is already indicated on the page, but maybe it's too subtle.

It's not indicated in the schedule, and clearly should be.

On Apr 14, 2015, at 12:25 AM, Luke Francl<EMAIL_ADDRESS>wrote:
I heard feedback from someone that they didn't know which sessions they'd voted for. This is already indicated on the page, but maybe it's too subtle.
—
Reply to this email directly or view it on GitHub.


[1.12] Wither builder spawn glitch

Industrial Foregoing Version: 1.12.2 - 1.12.8-232
TeslaCoreLib Version: 1.12.2 - 1.0.15
**Crashlog If Applicable (Upload to pastebin/gist): **
Hi, I'm not sure if anyone here posted this, but I today found a bug (glitch) on stream accidentaly.
If you use wither builder in a claimed chunk and you don't allow to build fake players blocks and you build the wither for yourself except ONE wither head, I think that the wither builder tries to build the head, but it gets cancelled, however, it will still spawn the wither, so..
I had like 100 withers suddenly flying around by accident.
If it's already reported or fixed, then sorry.

:wave: Sorry but Industrial Foregoing has ended support for version 1.12. I'm closing this issue as it will no longer be updated for that version. Thanks for playing with the mod.


TS error on Nuxt

Hi! I'm having an issue with using the plugin with Nuxt, it seems to work on the front-end (and is fantastic ❤), but it's throwing Typescript errors in my VS Code console, so I can't build. I didn't know if this might be an issue with my setup, or something in the package?
ERROR in plugins/vue-frag.ts:6:29
TS2769: No overload matches this call.
  The last overload gave the following error.
    Argument of type 'FragmentComponent' is not assignable to parameter of type 'ComponentOptions<Vue, DefaultData<Vue>, DefaultMethods<Vue>, DefaultComputed, PropsDefinition<DefaultProps>, DefaultProps>'.
      Types of property 'beforeRouteEnter' are incompatible.
        Type 'NavigationGuard<never> | undefined' is not assignable to type 'NavigationGuard<Vue> | undefined'.
          Type 'NavigationGuard<never>' is not assignable to type 'NavigationGuard<Vue>'.
            Type 'Vue' is not assignable to type 'never'.
    4 |
    5 | const myPlugin: Plugin = () => {
  > 6 |   Vue.component('Fragment', Fragment)
      |                             ^^^^^^^^
    7 | }
    8 |
    9 | export default myPlugin

Setup
nuxt.config.js
plugins: [
    '~/plugins/vue-frag',
],

vue-frag.ts
import Vue from 'vue'
import { Fragment } from 'vue-frag'
import { Plugin } from '@nuxt/types'

const myPlugin: Plugin = () => {
  Vue.component('Fragment', Fragment)
}

export default myPlugin

Thanks for the report.
Feel free to open a PR correcting the types.


Traefik v2 Kubernetes Ingress Controller doesn't update Ingress resource status

Do you want to request a feature or report a bug?

Bug

What did you do?

Using Kubernetes 1.17 and traefik:2.1.4, I started a basic ingress controller. Then I create a deployment/service/ingress for a simple image errm/cheese:cheddar with this ingress resource:
apiVersion: networking.k8s.io/v1beta1
kind: Ingress
metadata:
  name: cheddar
spec:
  rules:
  - host: cheddar.<IP_ADDRESS>.nip.io
    http:
      paths:
      - path: /
        backend:
          serviceName: cheddar
          servicePort: 80

Everything works in terms of traffic and connects through the ingress to the cheddar service, but the Address: field of kubectl get ingress is empty.  Doing a kubectl get ingress/cheddar -o yaml shows an empty status.loadBalancer key.
What did you expect to see?
ingress.status.loadBalancer filled with the service IP of the traefik proxy, similar to how NGINX ingress controller would update ingress.status.loadBalancer
What did you see instead?
An empty ingress.status.loadBalancer
If I leave all cheddar resources, remove the traefik controller, replace with the nginx controller, it'll auto update the ingress.status.loadBalancer and log doing so. Then if I swap back by deleting nginx and applying traefik ingress controller resources, traefik will leave the old IP in the cheddar ingress resource and it'll be incorrect, with the wrong IP of the previous nginx ingress controller service.
status:
  loadBalancer:
    ingress:
    - ip: <IP_ADDRESS>

Output of traefik version: (What version of Traefik are you using?)

traefik:2.1.4

What is your environment & configuration (arguments, toml, provider, platform, ...)?
args
- --providers.kubernetesingress=true
- --log=true
- --log.level=DEBUG
- --accesslog=true

If applicable, please paste the log output in DEBUG level (--log.level=DEBUG switch)
none

It seems like this PR was fixing what I would expect to happen here, so maybe a v2 regression? https://github.com/containous/traefik/pull/4603

This PR adds the update of the ingress resource status but you need to configure https://docs.traefik.io/providers/kubernetes-ingress/#ingressendpoint

Thanks, I added --providers.kubernetesingress.ingressendpoint.ip=<IP_ADDRESS> and it worked.


RHOARDOC-1667: ensure stand-alone is hyphenated in docs

[ ] Have you followed the guidelines in our Contributing document?
[ ] Have you created a JIRA and used it in the commit message?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same issue?
[ ] Have you built the project locally prior to submission with mvn clean install?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

this is the community counterpart to PR #199 on thorntail-prod.

ok to test


Day48: Longest Subarray of 1's After Deleting One Element - SlidingWindow

Longest Subarray of 1's After Deleting One Element
https://leetcode.com/problems/longest-subarray-of-1s-after-deleting-one-element/
Given a binary array nums, you should delete one element from it.
Return the size of the longest non-empty subarray containing only 1's in the resulting array. Return 0 if there is no such subarray.

Example 1:
Input: nums = [1,1,0,1]
Output: 3
Explanation: After deleting the number in position 2, [1,1,1] contains 3 numbers with value of 1's.
Example 2:
Input: nums = [0,1,1,1,0,1,1,0,1]
Output: 5
Explanation: After deleting the number in position 4, [0,1,1,1,1,1,0,1] longest subarray with value of 1's is [1,1,1,1,1].
Example 3:
Input: nums = [1,1,1]
Output: 2
Explanation: You must delete one element.


Scam Thread Submission

Duplicate Submissions

[X] Yes, I checked that the name is not currently in the list
[X] I read the wiki explaining each different categories and examples before submitting

(Required) Spam Comment Direct Link
https://www.youtube.com/watch?v=CUFxSZ56dYE&lc=UgxmIRixGD4BmOEipE94AaABAg
(Optional) Screenshot of comments referencing the scammer names

(Required) List of the scammer names
تيم دريبر

Thank you for including that name, I would have no idea how to type those characters, I know 0 Arabic.
If this breaks anything with it being a Right-to-Left language I may have to revert it but for now I'll add it in.

I have also added in the English name as I can quite easily see this just being a google translate of their script.

Thank you for including that name, I would have no idea how to type those characters, I know 0 Arabic. If this breaks anything with it being a Right-to-Left language I may have to revert it but for now I'll add it in.

You can just copy it from the issue List of the scammer names section. Nevermind, you have already done it 😄
I have intentionally made the screenshot and annotated the places where it appears so you can confirm (at least, visually) that it exists in the scam thread.
About the RTL, don't worry, even YouTube itself doesn't support RTL (as you can see from the screenshot, texts are aligned to the left) but we are still using it.

I have also added in the English name as I can quite easily see this just being a google translate of their script.

Good idea. I didn't mention that these Arabic comments are clearly translated automatically and not written by Arabic speakers because any native speaker reading these comments will find them very awkward.
Anyway, thanks for your work.


Optimization fails when webpacks cache options is false

I use an emitted ng-cli config and tried to adapt it to use the build-optimizer.
While testing the build always failed until I found out that the build-optimizer only works when webpacks caching is enabled.
In build-optimizer/src/purify/webpack-plugin.js there's the following lines:
compilation.assets[fileName]._cachedSource = purifiedSource;
compilation.assets[fileName]._source.source = () => purifiedSource;

This code requires "cache: true" to be set in the webpack config as otherwise the assets are ConcatSource objects that don't have "_cachedSource" and "_source" properties resulting in the second line causing an error as "._source" is undefined.
For a fix see PR #135, it's a really simple change with which both caching and non-caching webpack configs are supported.

Heya, thanks for the reporting this bug. Yeah we shouldn't be using those private fields to set the new source.
Your PR is failing tests though. A better approach would be to not rely at all on private fields... something like https://github.com/angular/angular-cli/blob/4cd714dbcc8ffcd9d0b4a9282d69da5a692d32b7/packages/%40angular/cli/plugins/glob-copy-webpack-plugin.ts#L35-L39.
Can you try that instead?

I updated the files, instead of using private fields it's now instantiating a new CachedSource() with a new RawSource(purified) as param, hope that's correct so far, I've not dug too deep into the code of the devkit so far.

I couldn't see how your PR failed the CI, but I added a PR to fix this: https://github.com/angular/devkit/pull/137

I used the classes from webpack-sources, the last remaining error was one complaining about webpack-sources being implicitly declared as any.
Your fix seems to be much simpler and cleaner.
You may want to check if webpack really is OK with the plain object or it requires a class instance from webpack-sources, at least the assets pushed into the purifier are ConcatSources objects.

I actually thought that a using an object was the recommended webpack API (it seems to be for general assets like images) but as far as I can tell, for JS source it really is a ConcatSource like you say.
Can you reopen your PR and also add @types/webpack-sources to the dependencies? That should clear your error.

I created a new, clean PR: #138


Update Composer dependencies (2022-10-06-00-07)

Visual regression test passed!
View the visual regression test report


realsense2_camera: 2.2.22-1 in 'melodic/distribution.yaml' [bloom]

Increasing version of package(s) in repository realsense2_camera to 2.2.22-1:

upstream repository: https://github.com/IntelRealSense/realsense-ros.git
release repository: https://github.com/IntelRealSense/realsense-ros-release.git
distro file: melodic/distribution.yaml
bloom version: 0.10.1
previous version for package: 2.2.21-1

realsense2_camera
* Add reset service.
* fix timestamp domain issues
  - Add offset to ros_time only if device uses hardware-clock. Otherwise use device time - either system_time or global_time.
  - Warn of a hardware timestamp possible loop.
* Choose the default profile in case of an invalid request.
* Avoid aligning confidence image.
* Add an option for an Ordered PointCloud.
* Contributors: Isaac I.Y. Saito, Itamar Eliakim, Marc Alban, doronhi

realsense2_description
* Fix mass of d415
* Consistent add_plug in xacros and launch files
* Contributors: Manuel Stahl, Tim Übelhör, doronhi

Depends on #28342


First draft of container support.

Schema (validator),  Schema(datomic), and input code needed to add container support to cook.
Still has spurious pprints in, these need to be removed prior to commit.
Clojure style and idiom comments more than welcome.

I could have cleaned up the destructuring using a table driven approach
{ old-kw ( new-kw function-to-call-on-value )}
but I felt like this would get opaque as well in the same fashion as my original function.

I bumped into clojure.walk/{prewalk,walk,postwalk} as well and was surprised that none actually really did exactly what I thought they would.

We try to explicitly write the code to do the format conversion. Explicitly pulling all the fields out of one entity and then populating specific fields in the new map has repeatedly helped us to avoid classes of bugs that automatic conversion admits.

So are you happy with the newer version?  I'll remove the older commented one then.

I think that the newer version could be clarified by refactoring it into several functions, rather than one really big function.

I ended up doing the table driven version, but I think its pretty clear whats going on.
I also broke it out.
This version is not segfaulting in mesos now. So give it a good look and please merge.

Degler, I'm closing this PR in favor of #135 which was based off of this code. If you get a chance, please review and comment on the new pull request.


Update release README.md

What this PR does / why we need it:
The release README.md is out of date and this updates it.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1850
Special notes for your reviewer:
Feel free to suggest change, clarification, or addition.
Release note:
NONE

/cc @chxchx

Do we still want to support 0.2 patching, we get some resources(clusters, tools, docs) supporting that. If we decided not to, that we can remove them all :)

I don't suppose we want to patch 0.2 anymore. Even so, the previous release step did not work AFAICT.
I intend to replace that with general information about release for now, and add more information when the process is ready for others outside of the group to run.

I am a bit concerned by the information disappearing and not being replaced?

@ldemailly The old scripts do not work anymore after repo merge and some of them had been deleted. There is no point to keep them around.
As mentioned in the doc, the group is solely responsible for release until the process/UI are ready for broader use (next quarter). At that time we will add more information back here.

I thought there was something on the github or istio.io websites that linked to the page (so it had a potential to be useful for someone who was tasked to do a release 0.2 patch but didn't think to look on the release-0.2 branch for the relevant version of the doc), but I didn't find it this afternoon.  If 0.2 is dead then it's a moot point.
I can see @ldemailly 's concern about removing old content but not adding in new content.  I suppose there will be content to add once the process/UI is ready for others to use. I'm not clear on whether we will also eventually add content that explains how to manually kick things off (in case of bug or service outage, or for outside contributors to dev test).  We lack turnkey information on how outside contributors can build Istio (e.g., for their own dev testing), though the old content wasn't really usable by these people either so it's not a new concern.
In summary I don't have anything new to suggest for this PR.  Afaik the system thinks I'm a nobody when it comes to approvals so there's no point in me using any keywords.

@mattdelco
Don't be sad. You are in the istio org. So you should be able to say "/lgtm" :)

@mattdelco Hiding those scripts behind the release process (i.e. airflow or later the release UI) is the way to go and I don't think we want others to really mess with release scripts manually. AFAICT, nobody other than us did the past releases anyway. For anyone else who really wants to create a release themselves, they can contact us for guidance. I suppose it is very rare.
As I said earlier, when airflow or release UI is ready for wider use, we will add more information here.
Also, I think you should add yourself to the OWNERS file since you are now the release king. =)

/lgtm


"File to import not found or unreadable: neat-helpers."

Getting this error on upgrade to 2.0.0 in a Rails app from an auto-generated line in _grid-settings.scss:
 @import "neat-helpers"; // or "../neat/neat-helpers" when not in Rails
Is this no longer necessary?

Neat 2.0 no longer contains "neat-helpers"
all you need is @import "neat";

Thanks!

It'd be nice if Bourbon's _grid-settings.scss knew about this.

@sixtyfive I think you mean Bitters’ old _grid-settings partial, but that was removed in Bitters 1.3.


add support for nozomi.la

Is your feature request related to a problem? Please describe
no
Describe the solution you'd like
I would like for nozomi.la, to be added to Supported sites.

You already asked this in march 2020 : #1912 plz don't make duplicate, Bionus may be already working on it, plus, there is alternative fort thoses websites like hdoujindownloader that does the job.

You already asked this in march 2020 : #1912 plz don't make duplicate, Bionus may be already working on it, plus, there is alternative fort thoses websites like hdoujindownloader that does the job.


Use rich diagnostic formatting for early build failures

Summary
This addresses cases like URL distributions, which are built before we get to the resolver.

I'm going to DRY this up in a future commit.


"Unable to receive ZMQ rawtx " errors after upgrade

Background
Getting a lot of "Unable to receive ZMQ rawtx " errors after upgrade
Your environment

vlnd version 0.5.1-beta commit=v0.5.1-beta-rc2
debian
bitcoind v<IP_ADDRESS>-134b42a40

Bitcoind logs
2018-11-16T15:45:42Z UpdateTip: new best=00000000000000be77f35efee69ec2fc48a3e96955151b7f57e05ed154dce052
height=1443720 version=0x20000000 log2_work=71.718189 tx=48050572
date='2018-11-16T15:42:42Z'
progress=0.999998 cache=0.2MiB(909txo)
warning='26 of last 100 blocks have unexpected version'

Actual behaviour
2018-11-16 15:39:43.079 [ERR] LNWL: Unable to receive ZMQ rawtx message: frame too large
2018-11-16 15:39:43.080 [ERR] LNWL: Unable to receive ZMQ rawtx message: invalid flag                                                                                2018-11-16 15:39:43.081 [ERR] LNWL: Unable to receive ZMQ rawtx message: invalid flag
2018-11-16 15:39:43.084 [ERR] LNWL: Unable to receive ZMQ rawtx message: invalid flag                                                                                2018-11-16 15:39:43.085 [ERR] LNWL: Unable to receive ZMQ rawtx message: invalid flag
2018-11-16 15:39:43.086 [ERR] LNWL: Unable to receive ZMQ rawtx message: invalid flag
2018-11-16 15:39:43.087 [ERR] LNWL: Unable to receive ZMQ rawtx message: invalid flag
2018-11-16 15:39:43.088 [ERR] LNWL: Unable to receive ZMQ rawtx message: invalid flag                                                                                2018-11-16 15:39:43.089 [ERR] LNWL: Unable to receive ZMQ rawtx message: frame too large

Great info. I'm 100% more interested in stable performance then up-to-date unconfirmed balance.
So, to set that, is it a matter of the 4 arguments?
"-zmqpubhashblockhwm=
-zmqpubhashtxhwm=
-zmqpubrawblockhwm=
-zmqpubrawtxhwm=
what's a reasonable value for n?

See https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes-14060.md.


Error: Module "crypto" has been externalized for bro

Describe the bug
The third-party dependency referenced by the project uses crypto reports an error
"browser-external:crypto:9 Uncaught (in promise) Error: Module "crypto" has been externalized for browser compatibility. Cannot access "crypto.randomFillSync" in client code."
Reproduction
none
System Info
3.0.0

Used Package Manager
yarn
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Duplicate of #9942


No include insertion for symbols from the main-file of the dynamic index

edit foo.h:#ifndef FOO_H
#define FOO_H
int foo();
#endif

code-complete in foo.c:int x = fo^

--> we see foo() completed with no include insertion
Expect to see foo() completed, and inserts #include "foo.h"
This appears to be bad header-guard detection when the guard is partly in the preamble. We're calling HeaderSearch::isFileMultipleIncludeGuarded() for the main-file, and it's returning false.
Same behavior with foo.h:
#pragma once
int foo();

however this does work (guard not in preamble):
int foo();
#pragma once

so i did some digging, and this is happening because we override main file contents to only consists of preamble section while generating the PCH in https://github.com/llvm/llvm-project/blob/master/clang/lib/Frontend/PrecompiledPreamble.cpp#L332.
When serializing a PCH FileInfos in HeaderSearch is put into an OnDiskHashtable, keyed with filename + file_size + modtime. And unfortunately file size gets a different value when building a preamble from what it really is. Later on when building the AST, we load the preamble and try to look up the fileinfo for "foo.h" but lookup fails and we get a "default fileinfo struct", which doesn't know about #pragma once.
The dirty hack of padding the preamble section with whitespaces instead of just slicing seems to make it work. I suppose a proper fix would be to handle this in lexer similar to  code completion, i.e replacing token after preamble with EOF.

Ah, thanks! That makes sense, and yeah either replacing with spaces (and a hilarious comment) or cutting off parsing seems reasonable.
I was thinking about whether #ifdef header guards were going to be hit by a second effect: the question about include-guards isn't actually well-defined for a preamble:
#ifndef X
#define X
int z; // preamble ends here - do we have an include guard?
#endif // we do

<reuse preamble>
int z;
#endif // uh oh, this isn't a well-formed include guard
int y; // but the HFI from the preamble named a controlling macro...

I'll investigate. I guess ideally we want to treat this as a header guard because it almost always is, but that seems a little unsatisfying and also maybe hard to implement.

And of course the question of "why do we have no test coverage" has an easy answer: some of our tests don't use preamble, and the ones that do use TestTU, which happens to use trailing-#pragma-once for header guards - the one configuration that works. Sigh, I was wondering when that was going to bite us...

Yeah, as I feared, zeroing out the rest of the preamble file instead of truncating fixes #pragma once but leaves #ifdef broken.
EmitData in ASTWriter sees ControllingMacro=0 ControllingMacroID=0 when writing the preamble.

So this "fixes" ifdef guards (makes them considered controlling if unclosed at end of preamble):
   if (PP->isRecordingPreamble() && PP->isInPrimaryFile()) {
     PP->setRecordedPreambleConditionalStack(ConditionalStack);
+    if (!ConditionalStack.empty())
+     MIOpt.ExitTopLevelConditional();
     ConditionalStack.clear();
   }

It's correct enough for tools, though is obviously a false positive if there's stuff in the header after the include guard. For this to cause problems you'd have to be building a PCH file from a header, which has header guards, and then including that header multiple times and relying on multiple side-effects.
Which I guess isn't totally implausible:
#ifndef FOO_HEADERS_LOADED
#define FOO_HEADERS_LOADED
#include <x>
#include <y>
#endif
// tablegen-style macro calls
FOO("x", x::blah())
FOO("y", y::blah())

The only totally-correct thing to do I think is to record the candidate controlling macro and then promote it when we use the preamble. That seems like a lot of work :-(

Which I guess isn't totally implausible

Actually I think it's fine.
PCH files are only used for -include on the command-line, and the -cc1 -include-pch replaces the -include if the PCH is found, so content outside the preamble region is ignored. Actual #includes still use textual inclusion. The first one will rely on the actual #ifdef semantics rather than hitting the multi-header-guard code, and subsequent ones
Probably the easiest way to summarize the correctness of this (and justify it in the code) is that the candidate header guard is valid for the preamble content itself.

Haha, of course replacing the preamble buffer with nulls/zeros doesn't work - the idea is to match the size of the buffer we're using the preamble with, but of course that can change over time. I need to look again into the reasons for including size/mtime in the hashtable key, but I suspect zeroing them out for the main-file is the right fix.

OK, I have a fairly ugly fix for this: for the mainfile we store the HeaderFileInfo twice, once with a size of zero. When loading a HeaderFileInfo, if a) we're loading a preamble and b) the basename of the fileentry matches the original filename stored in the preamble and c) primary lookup fails, then we retry with size 0.
But to write the testcase for this, I had to make a change that I thought was unrelated: we currently only calculate the include header for code-completion-eligible symbols, and main-file symbols aren't indexed for code completion[1]. So we also have the option of just declaring this WAI...
[1] Actually macros are, this inconsistency is a bug.

Patch in https://reviews.llvm.org/D78038, not sure whether we should try to land it.

But to write the testcase for this, I had to make a change that I thought was unrelated: we currently only calculate the include header for code-completion-eligible symbols, and main-file symbols aren't indexed for code completion[1]. So we also have the option of just declaring this WAI...

this shouldn't have been happening, since we mark headers as not-mainfile-only. I believe this has happened because you changed TU.HeaderFileName rather than TU.FileName
bool IsMainFileOnly =
  bool IsMainFileOnly =
      SM.isWrittenInMainFile(SM.getExpansionLoc(ND->getBeginLoc())) &&
      !isHeaderFile(SM.getFileEntryForID(SM.getMainFileID())->getName(),

will take a look at the patch.

Hi there,
I'm experiencing a similar bug with the following file structure:
foo.h
#pragma once

template <typename T>
struct Point {
    T x;
    T y;
};

template<typename T>
T norm(Point<T> p);

#include <foo.impl.h>

foo.impl.h
#pragma once

#include <foo.h>

template<typename T>
T norm(Point<T> p) {
    return p.x * p.x + p.y * p.y;
}

Specifically clangd is complaining when I'm in the header file foo.h (trying to include it twice). I tried the patch proposed above on a local build of clang on macOS and it seems to solve the issue. Is there any ETA on when it can be merged?

@sam-mccall @kadircet any ETA on the patch submitted above?

+1, I have a similar situation as jdumas@ above, though a more complex case (involving generated code for a Rust/C++ FFI using https://github.com/dtolnay/cxx)

Hello. It would be nice to have this issue fixed. Qt Creator 8.0 entirely relies on clangd and (with background indexing enabled by default) the issue (same as in https://github.com/clangd/clangd/issues/333#issuecomment-630264167) is constantly popping up.

I can only support that it would be really nice if this got fixed - it's quite irritating to have clangd reporting errors such as this when in fact everything compiles just fine (and is also correctly written - so we're not relying on one specific compile order or something like that).
@sam-mccall it seems that an answer of yours is awaited for in https://reviews.llvm.org/D78038 deciding whether or not your patch is to be merged.

What is the status of patch /D78038 above? Has it been moved to a GitHub PR on the LLVM project?


NT-1819:Android CodeCov Integration

📲 What
Adds code coverage reports to our PRs
🤔 Why
to keep track of test coverage.
🛠 How
1- integrata jacoco plugin
2-Add ./gradlew jacocoInternalRelease to circle.ci flow
👀 See

Story 📖
https://kickstarter.atlassian.net/browse/NT-1819

OMG! LOVE IT! : 😍


Fix adjustsFontSizeToFit for strings with a single character

Summary:
Fixes https://github.com/facebook/react-native/issues/47045
On Android adjustsFontSizeToFit relies on two metrics:

Text with line breaks results in more lines than maximumNumberOfLines
The overall height of the text is larger than the available height

None of these two was fulfilled when a single-character string had a higher width than the available one (a single character will not be broken into multiple lines). This PR adds exactly that as a third option to trigger the scaling algorithm - a single-character string that has a higher width than the available one.
On iOS adjustsFontSizeToFit relies on truncatedGlyphRangeInLineFragmentForGlyphAtIndex which seems to be returning NSNotFound when a single-character sting gets truncated. Similarly to Android, this PR adds an additional check to make sure that single-character strings actually fit inside the container.
Changelog:
[GENERAL] [FIXED] - Fixed adjustsFontSizeToFit not working for text with a single character
Test Plan:
Tested on the code from the issue:

Android (old arch)
Android (new arch)
iOS (old arch)
iOS (new arch)

Let's make sure the CI is green before we import this 👍

Fixes the bug

(Apologise for the late review @j-piasecki)


[Backport release-24.11] ghostty: init at 1.0.0

Manual backport of #368404 and #368726

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg eval

Also consider the changes from #369282 as the runtime dependencies on the sources was reintroduced.

This shouldn't be merged until 1.0.1 due to a currently unpatched CVE

https://ghostty.org/docs/install/release-notes/1-0-1

https://ghostty.org/docs/install/release-notes/1-0-1

https://github.com/NixOS/nixpkgs/pull/369782


Remove base_url and dex_config from values.yaml? Since, it can now be configured from UI.

Also to be covered in documentation.


Create metapackage for robocorp libraries

Adds a plain robocorp PyPI package that has the core framework features: tasks, logging, and control room libraries.
Has to include some content, so adds a private module robocorp._meta with just version information. Could technically include other information that our tooling would read.
Updating of deps is currently inv update-deps that makes it match other pyproject.tomls, but this can be further automated if we want.

We should probably have a test which fails when we bump up a version from a dep and don't bump this one.

I think maybe a separate workflow that checks this project against versions in PyPI. There might be times we want to have upgrading this as a manual decision.

As a note, managing this with poetry is kind of annoying (because one needs to publish the dep i.e.: robocorp-log, wait for it to be live in pypi and then go back to this one update the version and run a poetry lock to then release it -- maybe we can try to automate that somehow or consider some other tool since there's no real code here).

That's true. Could be a traditional setup.py that is generated. I'll fix that later when I get annoyed by this 😅


ModuleNotFoundError: No module named 'castle'

https://github.com/microsoft/causica/blob/a3cfb90aa2bd61b1807dcfbf4f44b756ad7b31bd/causica/baselines/pc.py#L2
Kindly, suggest me right package to install.
i tried pip install castle.but it took like it is not right package as per causica.

used this git+https://github.com/tomsons22/trustworthyAI.git@c2e3535eba28cabf8e1309f55bffc3e4d4d78c00#subdirectory=gcastle


Aircon mode id between Homebridge and Tuya

Hi, for Heater Cooler between Tuya and Homebridge, mode id mapping is as follow:

Mode
Tuya
Homebridge

Cool
0
2

Heat
1
1

Auto
2
0

I have fixed it in my fork here.
Cheers..

It's the same mapping
let command = 2;
if (val == this.platform.Characteristic.TargetHeaterCoolerState.COOL) command = 0;
if (val == this.platform.Characteristic.TargetHeaterCoolerState.HEAT) command = 1;

How is it different?

Yup, that part is ok. It's not about the Set, it's about the initial Get

Got it. Will fix this. Thanks for spotting.

Fixed in v1.0.6. Please check and let me know.

Yes, just checked, I think that should do it. ^^


CHORE: Use single branch and PR for types generation

This prevents polluting the PRs on GitHub with a new PR with every type generation action.
This was done for CAS3 in https://github.com/ministryofjustice/hmpps-temporary-accommodation-ui/pull/951

this is great!


Got error message while installing the package with npm.

%npm i xlsx
npm ERR! Unexpected end of JSON input while parsing near '...},"devDependencies":{'

I fixed this problem after removing all cache of npm.


[Event Request] codeunit 6620 "Copy Document Mgt." purchaselines set filters

We want to filter the from records when copying documents in codeunit 6620 "Copy Document Mgt.".
In BC15 we only had the events for the sales documents.
For purchase, this was added in BC16.
However, these purchase events are way less intuitive compared to those of the sales side.
I had to actively search in the purchase copy document code for the needed event, and what's it name and parameters are.
Wouldn't it be nicer to also have those same events on the purchase side as in the sales side?
as requested by me in #4664 ?
    local procedure CopySalesDocSalesLine(FromSalesHeader: Record "Sales Header"; var ToSalesHeader: Record "Sales Header"; var LinesNotCopied: Integer; NextLineNo: Integer)
    var
        ToSalesLine: Record "Sales Line";
        FromSalesLine: Record "Sales Line";
        ItemChargeAssgntNextLineNo: Integer;
    begin
        ItemChargeAssgntNextLineNo := 0;

        with ToSalesHeader do begin
            FromSalesLine.Reset();
            FromSalesLine.SetRange("Document Type", FromSalesHeader."Document Type");
            FromSalesLine.SetRange("Document No.", FromSalesHeader."No.");
            if MoveNegLines then
                FromSalesLine.SetFilter(Quantity, '<=0');
            OnCopySalesDocSalesLineOnAfterSetFilters(FromSalesHeader, FromSalesLine, ToSalesHeader); //<<<<
            if FromSalesLine.Find('-') then
...

local procedure CopyPurchDocInvLine(FromPurchInvHeader: Record "Purch. Inv. Header"; ToPurchHeader: Record "Purchase Header"; var LinesNotCopied: Integer; var MissingExCostRevLink: Boolean)
var
    FromPurchInvLine: Record "Purch. Inv. Line";
begin
    with ToPurchHeader do begin
        FromPurchInvLine.Reset();
        FromPurchInvLine.SetRange("Document No.", FromPurchInvHeader."No.");
        if MoveNegLines then
            FromPurchInvLine.SetFilter(Quantity, '<=0');

///////>>>>OnCopyPurchInvLinesToDocOnAfterSetFilters(ToPurchHeader, FromPurchInvLine, LinesNotCopied, MissingExCostRevLink);
CopyPurchInvLinesToDoc(ToPurchHeader, FromPurchInvLine, LinesNotCopied, MissingExCostRevLink);
end;
end;
procedure CopyPurchInvLinesToDoc(ToPurchHeader: Record "Purchase Header"; var FromPurchInvLine: Record "Purch. Inv. Line"; var LinesNotCopied: Integer; var MissingExCostRevLink: Boolean)

...
OnBeforeCopyPurchInvLines(TempDocPurchaseLine, ToPurchHeader, FromPurchInvLine);
    // Fill purchase line buffer
    with FromPurchInvLine do
        if FindSet then

...
Now I have to subscribe to OnBeforeCopyPurchInvLines and put my filter there.
Yes it's the same result, except the subscribers look a complete mess code-wise.
(/rant)
Could these purchase filter events to all document source types be added please (cfr sales)?
code of BC16.3

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Image fields parse some definitions incorrectly

Having a definition named xlarge=60 and using it to define size of an image field causes the script to incorrectly try to split the definition on 'x'.
For example, {{ my_image.png:xlarge }} would be processed as {{ my_image.png:large }} because it is hardcoded to use the 'x' character as delimiter between width and height specifications.
Solution is probably to implement an additional check as the first thing, to see if the right side specification is just a definition.

Actually, the proposed solution is already in effect; the real issue is the split on the 'x' character. It would not matter where the 'x' appears- it would fail no matter what.


Debugging in VS Code

Hi!
I run the download command, for example, and try to debug in VS Code to see outbound request data. I cannot seem to get my VS Code configured to get breakpoints hit. Any help would be appreciated.
Kind regards,
Stipe

Hi @stipemodric. Excited you're using the project! Can you tell me a little more about why you need debug breakpoints or what you're hoping to do with the project? Is there some behavior that seems wrong?

This guide may help https://code.visualstudio.com/docs/nodejs/nodejs-debugging

Hi!
Sorry for the late reply, this went to spam for some reason.
I had a task at work to devise a solution to create a marketplace using a
custom api. I wanted to track request data created by the seeding tool. In
the end I tracked my own browser request data and did the work, but I still
didn't manage to configure the debugger for the seeding tool. This remains
a puzzle for me.
Kind regards,
Stipe Modric
On Thu, 29 Sept 2022, 17:22 Oliver Heywood, @.***>
wrote:

This guide may help
https://code.visualstudio.com/docs/nodejs/nodejs-debugging
—
Reply to this email directly, view it on GitHub
https://github.com/ordercloud-api/ordercloud-seed/issues/19#issuecomment-1262436934,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKDKYFLCD2SKQWNDEQF76HTWAWXZ3ANCNFSM6AAAAAAQV4P5S4
.
You are receiving this because you were mentioned.Message ID:
@.***>


Links to namespaced classes are broken

If I am not mistaken, then [api:SilverStripe\Framework\Injector\Factory] in https://github.com/silverstripe/silverstripe-framework/blob/3.1/docs/en/reference/injector.md will be turned into a link to the API docs.
the link should be:
http://api.silverstripe.org/3.1/class-SilverStripe.Framework.Injector.Factory.html

however, currently the generated link is:
http://api.silverstripe.org/3.1/class-SilverStripeFrameworkInjectorFactory.html

which is 404

We've fixed this at the SilverStripe API site end with https://github.com/silverstripe/api.silverstripe.org/issues/33 https://github.com/silverstripe/silverstripe-framework/pull/6895 https://github.com/silverstripe/api.silverstripe.org/pull/37 https://github.com/silverstripe/api.silverstripe.org/pull/38


Custom hostnames - addHostname does not work

When I try to execute the following:
new CustomHostnames($this->adapter)->addHostname(
            "zone_id",
            "mydomain.com",
        );

I get the error message: Unable to decode the JSON request body. Please check your input and try again..
I tried to modify the addHostname-function and remove the ssl-array, and by doing that, I could successfully create a custom hostname.
I am using a free-plan account on cloudflare.

Same for me, removing
//            'ssl' => [
//                'method' => $sslMethod,
//                'type' => $sslType,
//                'settings' => $sslSettings,
//                'wildcard' => $wildcard,
//            ],

fix the issue on free plan

If anyone want my fix
update your composer.json
require
"cloudflare/sdk": "dev-patch-addHostname"
and add
    "repositories": {
        "repo-name": {
            "type": "vcs",
            "url": "https://github.com/arommelaere/cloudflare-php"
        }
    }


Failing Windows CI tests on main branch

We have two consistently failing tests in Windows CI on the main branch:
Example: https://build.osrfoundation.org/job/ign_fuel-tools-pr-win/112/
FuelClientTest.CachedModel
LocalCacheTest.AllModels

FuelClientTest.CachedModel
https://github.com/ignitionrobotics/ign-fuel-tools/blob/c47d85f00419d4a684f1955e56fb4404a060f77d/src/FuelClient_TEST.cc#L617-L625
[ RUN      ] FuelClientTest.CachedModel
5: [Dbg] [C:\Jenkins\workspace\ign_fuel-tools-pr-win\ws\ign-fuel-tools\src\FuelClient_TEST.cc:48] Creating local model in [C:\Jenkins\workspace\ign_fuel-tools-pr-win\ws\build\ignition-fuel_tools8]
5: [Wrn] [C:\Jenkins\workspace\ign_fuel-tools-pr-win\ws\ign-fuel-tools\src\LocalCache.cc:105] Server directory does not exist [C:\Jenkins\workspace\ign_fuel-tools-pr-win\ws\build\ignition-fuel_tools8\test_cache\fuel.ignitionrobotics.org]
5: C:\Jenkins\workspace\ign_fuel-tools-pr-win\ws\ign-fuel-tools\src\FuelClient_TEST.cc(621): error: Value of: result
5:   Actual: false
5: Expected: true
5: C:\Jenkins\workspace\ign_fuel-tools-pr-win\ws\ign-fuel-tools\src\FuelClient_TEST.cc(622): error: Expected equality of these values:
5:   ResultType::FETCH_ALREADY_EXISTS
5:     Which is: 4-byte object <05-00 00-00>
5:   result.Type()
5:     Which is: 4-byte object <07-00 00-00>
5: C:\Jenkins\workspace\ign_fuel-tools-pr-win\ws\ign-fuel-tools\src\FuelClient_TEST.cc(624): error: Expected equality of these values:
5:   common::joinPaths(common::cwd(), "test_cache", "localhost:8007", "alice", "models", "My Model", "3")
5:     Which is: "C:\\Jenkins\\workspace\\ign_fuel-tools-pr-win\\ws\\build\\ignition-fuel_tools8\\test_cache\\localhost8007\\alice\\models\\My Model\\3"
5:   path
5:     Which is: ""

LocalCacheTest.AllModels
https://github.com/ignitionrobotics/ign-fuel-tools/blob/c47d85f00419d4a684f1955e56fb4404a060f77d/src/LocalCache_TEST.cc#L248-L258
15: [Dbg] [C:\Jenkins\workspace\ign_fuel-tools-pr-win\ws\ign-fuel-tools\src\LocalCache_TEST.cc:47] Creating 6 local models in [C:\Jenkins\workspace\ign_fuel-tools-pr-win\ws\build\ignition-fuel_tools8]
15: [Dbg] [C:\Jenkins\workspace\ign_fuel-tools-pr-win\ws\ign-fuel-tools\src\LocalCache_TEST.cc:99] Creating 3 local models in [C:\Jenkins\workspace\ign_fuel-tools-pr-win\ws\build\ignition-fuel_tools8]
15: [Wrn] [C:\Jenkins\workspace\ign_fuel-tools-pr-win\ws\ign-fuel-tools\src\LocalCache.cc:105] Server directory does not exist [C:\Jenkins\workspace\ign_fuel-tools-pr-win\ws\build\ignition-fuel_tools8\test_cache\fuel.ignitionrobotics.org]
15: C:\Jenkins\workspace\ign_fuel-tools-pr-win\ws\ign-fuel-tools\src\LocalCache_TEST.cc(258): error: Expected: (uniqueNames.end()) != (uniqueNames.find( "http://localhost:8001/alice/models/am1")), actual: 8-byte object <50-F6 94-ED 10-02 00-00> vs 8-byte object <50-F6 94-ED 10-02 00-00>
15: [  FAILED  ] LocalCacheTest.AllModels (45 ms)```

Closed by #376


Aftter truffle init, tests don't work

We created a brand new project via truffle init. Then, after starting a private testnet, unlocking the primary address, starting the miner and running the tests, I get the following error.
Contract: MetaCoin
    ✓ should put 10000 MetaCoin in the first account
    1) should call a function that depends on a linked library
    > No events were emitted
    2) should send coin correctly
    > No events were emitted

1) Contract: MetaCoin should call a function that depends on a linked library  :
     AssertionError: Library function returned unexpeced function, linkage may be broken: expected 0 to equal 20000

2) Contract: MetaCoin should send coin correctly:
     BigNumber Error: new BigNumber() not a number: [object Object]

We didn't get to looking at the second error, but for the first one, we got the following info:
outCoinBalance: { [String: '10000'] s: 1, e: 4, c: [ 10000 ] }
outCoinBalance.toNumber(): 10000
outCoinBalanceEth: { [String: '0'] s: 1, e: 0, c: [ 0 ] }
metaCoinEthBalance: 0
2 * metaCoinBalance: 20000

It looks like meta.getBalanceInEth.call(accounts[0]), which is setting outCoinBalanceEth is not returning the correct value.

This doesn't seem to be the case anymore with Truffle 2.0.4. I'm trying to do some issues cleanup, so I'm going to close this since I can't reproduce. If this is still an issue for you please reopen and comment. Thanks!

I'm experiencing the same problem with Truffle 2.0.8 using geth --dev & miner.start(1).
However tests are passing with testrpc.

Same issue happens for me with private miner with geth or ethereumJ node.

Same thing still with Truffle 2.1.1. This issue should really be reopened.

The same problem with Truffle 2.1.1 and geth 1.5.4-stable.

Same with Truffle 3.1.9 and geth-1.5.9-stable. Running against TestRPC is working fine. Should be reopened.

I am having the same issue truffle v3.1.2. When i deploy using testrpc the library linkage works without any issues. When i deploy using a pvt geth network it doesnt work even though the deployment works without any issues.

For those of you that uses a private net geth for development, configure your genesis block as follows:
{
    "config": {
            "homesteadBlock": 10
    },
    "nonce": "0",
    "difficulty": "0x20000",
    "mixhash": "0x00000000000000000000000000000000000000647572616c65787365646c6578",
    "coinbase": "0x0000000000000000000000000000000000000000",
    "timestamp": "0x00",
    "parentHash": "0x0000000000000000000000000000000000000000000000000000000000000000",
    "extraData": "0x",
    "gasLimit": "0x2FEFD8",
    "alloc": {}
}

The key point here is the homesteadBlock, which enables certain features including DELEGATECALL, which is what libraries are dependent on.
Source: https://blog.ethereum.org/2016/02/29/homestead-release/


Enable a function to be used for objective weights in MCTS bot

Objectives that can return their weight based on the game state are much more useful than those with fixed weights (a simple example is an objective for maximising the player's score in games that have a score)
Example usage:
const objectives = () => ({
    'score': {
        checker: () => true,
        weight: (G, ctx) => (G.scores[parseInt(ctx.currentPlayer)])
    }
});

Checklist

[X] Use a separate branch in your local repo (not master).
[X] Test coverage is 100% (or you have a story for why it's ok).

@danmkent Closing this since there hasn't been activity for a while.  Feel free to re-open if you do get back to working on this!


A Single Appliance (Thermador Oven) Reaches Blocked Status

Describe the bug
I have two appliances, Thermador oven and dishwasher.  I was frequently rate-limited.  Following instructions, I separated these two devices with distinct credentials.  The dishwasher is now never rate-limited, but cooking will lead to BLOCKED for the oven.  If the oven is not turned on, no block arises.  So far this has always taken 24 hours to resolve on its own.  I created a third set of credentials and can change the oven to them if I need the oven reporting.
When its working, the temperature does seem to update frequently, e.g. every sixty seconds or even more often, but that should still take over 10 hours to hit 1000 API calls.  I'd be happy to update less frequently but do not see a setting that lets me do so.
Specific questions:  Do the number of entities matter or are API calls at the appliance level? is there a way to limit API calls per appliance to, say, every five minutes?
Version of the custom_component
1.1.12
Configuration
I have two always-on tablets that among other things show the oven temperature.  Moreover these reload their dashboards every 15 minutes (otherwise the time on the dashboard stops updating).   If that update creates an API call, it could cause the overage, because 100 times per day X 28 entities could result in 2800 API calls if each entity is called separately.  I tried disabling most of the entities -- I only use current program and cavity temperature -- without effect.  Dashboard reloads should not be the cause because rate limiting only happens when cooking, not when the oven is off, and the dashboard reloads happen either way.
Debug log
I'm attaching two logs, one recorded during the block period (earlier) and one recorded after I changed credentials so that the oven was unblocked, in case they might be helpful.
home-assistant_home_connect_alt_2024-12-22T17-12-32.040Z.log
home-assistant_home_connect_alt_2024-12-22T18-32-54.373Z.log

All of you calculations are wrong because none of those things would trigger a API call. Calls are triggered only when you change some settings, like starting, stopping or selecting a different program, just reading values doesn't trigger a call.
Neither of the two attached logs indicates a API rate limit, what makes you think that you are getting blocked?
Also, it seems that you have two accounts connected with the same appliances so you are getting non-unique IDs. You shouldn't do that and if you only have one appliance you should probably stick to a single account.

I'm sorry I was unclear.
I have two appliances - dishwasher and oven -- and started using separate dev accounts so that when the oven was blocked, the dishwasher continued to work.  I thought I was hitting the API rate limit because I saw the word BLOCKED in the device settings.  I created a third set of credentials so that when the oven integration stopped working (e.g. sensor.thermador_prg486wdh_68a40e2c6663_340_bsh_common_status_operationstate became unavailable) I could switch to the other integration and make it work.  This is what I did to create the second log.
I do see in the logs that the oven cavity temperature was available even when the operationstate was not.  So I will trigger the BLOCKED state again so that I can send a screenshot of what I am seeing as well as the log.  And if I can't trigger, I will report that too.

ok, before getting the log file please also press the "Home Connect Debug Info" button for every config entry you have (there should be one for every account you added).
As for using two entries for the same device, that is creating duplicate IDs and shouldn't be done. An appliance can only be active under a single config entry (== a single Client ID)

I ran the oven for six hours and did not trigger the BLOCKED state.  I will write again if I reproduce the problem, with Home Connect Debug Info pressed.  You can close this and happy holidays.
I am seeing things that look like API calls, but only to the oven, none to the dishwasher.  240 entries that look like:
2024-12-22 10:32:28.130 DEBUG (MainThread) [home_connect_async.api]  HTTP GET /api/homeappliances/THERMADOR-PRG486WDH-68A40E2C6663-340/commands (try=1 count=14)
I attach the last half of the log file.  I pressed the Home Connect Debug Info buttons several times.  I have three accounts total but with two appliances, when one goes down I remove its account and add the other, so there are only two accounts at any given time, and I use code like
thermador_dwhd650wfp_68a40e0b2c4c:   disabled: true
to ensure that each account only handles one appliance.  I know this code works because when the oven is BLOCKED, I still see the status of the dishwasher.
home-assistant_home_connect_alt_2024-12-23T20-14-58.352Z.log

It happened again.  I am attaching three documents: two screenshots showing BLOCKED

and the log file for the past 36 hours, which has this in it:
2024-12-28 12:13:45.784 DEBUG (MainThread) [home_connect_async.api] HTTP GET /api/homeappliances (try=1 count=4) [429]
2024-12-28 12:13:45.784 DEBUG (MainThread) [home_connect_async.api] HTTP Error 429 - Too Many Requests. Sleeping for 76803 seconds and will retry
2024-12-28 12:13:45.871 DEBUG (MainThread) [home_connect_async.api] HTTP GET /api/homeappliances/THERMADOR-DWHD650WFP-68A40E0B2C4C/commands (try=1 count=34) [200]

home-assistant_home_connect_alt_2024-12-28T20-14-04.365Z.log
but I don't know if that excerpt is evidence about the problem.  Reminder: I have two thermador appliances, a dishwasher (thermador_dwhd650wfp_68a40e0b2c4c) and an oven (thermador_prg486wdh_68a40e2c6663_340).  I use two Home Connect Alt credentials, one for the dishwasher with code:
thermador_prg486wdh_68a40e2c6663_340:
  disabled: true

Let me know if there is more information I can provide and thanks in advance.
and the other for the oven with code:
thermador_dwhd650wfp_68a40e0b2c4c:
  disabled: true

Right at this moment I am receiving data from the dishwasher but not the oven.

The HTTP 429 status is indeed an indication that the client was rate limited, however, I need the entire log file, and possibly the previous one as well, to see how it got to that state. I see that this is relatively a new log, in the sense that it is shortly after restarting HA and the calls are already blocked, so it must have gotten to that state earlier, probably before the restart. Bottom line is that from this part of the log I can't tell which excessive calls caused your account to get blocked. Next time this happens please attach the full log with at least a full day of history.

Okay, I truncated the log because it would not fit in the space.  I thought I got the relevant time.  However it was probably not recording at the time the problem happened.  The available full log is here.  But I don't expect that to help.
Home_Connect_Alt has recovered, so I am restarting HA and then I will trigger logging and leave it logging.  Once the problem recurs, I will post the full log, and if it is too large, I will use the above method of posting a link in my tmp folder.  Please let me know if something else would be more useful.
I appreciate your contribution -- I like having the oven temperature on my dashboard so that I know when the oven is left on, and a defect in the thermador dishwasher is that it is almost impossible to tell from the appliance itself if you have set it for delay or not, but easy from my dashboard -- and I especially appreciate your patience in sorting out what I'm doing wrong, given my inexperience with HA and the underlying tech.

The link doesn't work. In general it is very unusual for a single appliance to trigger a rate limit, in fact I don't think I've ever seen it happening before. To understand what is causing it I need a log with enough history before getting blocked that would show the excessive calls that triggered it, assuming there really were such calls. The call counter should show the progress from a low number to a much higher one (the limit is 1000 calls a day) in the 24h window.

Trying again.  Sorry about that.  I lost the TLD when I pasted.  I also edited the comment.  This is what I have back to Dec 22 until I noticed but I didn't have logging enabled the whole time.  I have logging on now and will leave it on until the problem recurs.  It typically requires a significant use of the oven to trigger the rate limit, so it may be some time.  I only see ~60 API calls in the logs, so am  unclear why I am triggering the rate limit.

It might be related to this, but I'm having a similar problem, i get BLOCKED after a few hours. Looking at the debug logs, it seems that it's doing a lot of requests:
https://www.swisstransfer.com/d/899dbb10-7a8b-42ca-8c96-93fc1cfe9142


Add Fetcher and FileLoader classes

These will be used in the next few incoming PRs. Submitting separately to make them easier to review.
TODO:
~- [ ] Add some very rudimentary tests; figure out how to mock the HTTP request / file access and just check that they return the right thing with one or two inputs.~
Later edit: Testing FileLoader doesn't really make sense as it doesn't do much of anything, and I got stuck trying to mock the InputStream passed to new InputStreamReader() in Fetcher, so I stopped short of testing it for now.

@johnollier I've updated it! Much cleaner, thanks.


:zap: opt unuse label

What is the purpose of the change
remove unuse label : host、ip、gitcommitid
we can get it（host)  when discover host such as prometheus use $instance
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #13034 (de4deac) into 3.2 (8a509e9) will decrease coverage by 0.23%.
The diff coverage is n/a.

:exclamation: Current head de4deac differs from pull request most recent head 91fa256. Consider uploading reports for the commit 91fa256 to get more accurate results

@@             Coverage Diff              @@
##                3.2   #13034      +/-   ##
============================================
- Coverage     69.70%   69.48%   -0.23%
+ Complexity      316        2     -314
============================================
  Files          3525     1649    -1876
  Lines        167899    68549   -99350
  Branches      28038     9997   -18041
============================================
- Hits         117032    47629   -69403
+ Misses        40716    16319   -24397
+ Partials      10151     4601    -5550

see 1904 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add blog post for release 1.3.1

Signed-off-by: Phillip Ritter<EMAIL_ADDRESS>Blog post for minor release 1.3.1

PR submitted prematurely.  Further comments to release notes pending.  Will resubmit when clarified.

Updated blog post.  Ready for review.

Also note, you will probably need to do an upstream fetch to get the latest changes from https://github.com/magma/magma-website/pull/34 that fix the other dependency failure.

Corrected the timestamp and fixed the timestamp.  Should be ready now.


feat(restclient): add explicit content negotiation

Current dependencies on/for this PR:

main

PR #36

PR #37   👈

This comment was auto-generated by Graphite.

Graphite Merge Job
Current status: ⏳ Queued to merge
This pull request is currently queued to be merged as part of a stack.
This comment was auto-generated by Graphite.

Job Reference: m70Y70s4R49EIQIAok4y


fix: return valid schema in create schema method

Add seqNo to returned schema after creating. This makes it usable out of the box, without making another ledger request. Taken from ACA-Py impl
getPublicDid() -> publicDid (as a getter method)
createCredentialSchema -> createSchema (more consistent with rest of codebase)
support_revocation -> supportRevocation

Fixes #146

Codecov Report

Merging #193 (5295041) into main (7b62574) will increase coverage by 0.10%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
+ Coverage   89.35%   89.46%   +0.10%
==========================================
  Files         153      153
  Lines        3213     3208       -5
  Branches      375      371       -4
==========================================
- Hits         2871     2870       -1
+ Misses        339      335       -4
  Partials        3        3

Impacted Files
Coverage Δ

src/lib/modules/ledger/LedgerModule.ts
83.33% <75.00%> (-3.63%)
:arrow_down:

src/lib/modules/ledger/LedgerService.ts
92.39% <87.50%> (+4.63%)
:arrow_up:

src/lib/agent/Agent.ts
100.00% <100.00%> (ø)

src/lib/wallet/IndyWallet.ts
87.37% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b62574...5295041. Read the comment docs.


Implement INI ConfigFormatter

installed ini package from npm
used #253 as reference

Closes #452

Thanks for your contribution!
LGTM.
@michaldziuba03 is it a draft or ready to use?
can you add a test?

@davidmeirlevy I marked PR to be ready to review.


AssertionError: Invalid libraryOrderEntry, library: Library: name:Bundled Protobuf Distribution; roots:[VFPContai...

https://sentry.io/ks-projects/protobuf-support/issues/723042495/
AssertionError: Invalid libraryOrderEntry, library: Library: name:Bundled Protobuf Distribution; roots:[VFPContainer: [], VFPContainer: [], VFPContainer: [], VFPContainer: [], VFPContainer: []] of type class com.intellij.openapi.roots.impl.libraries.LibraryImpl, disposed: true, kind: null
    at com.intellij.openapi.roots.impl.RootModelImpl.addLibraryEntry(RootModelImpl.java:268)
    at io.protostuff.jetbrains.plugin.ProtostuffPluginController.lambda$addLibrary$1(ProtostuffPluginController.java:130)
    at com.intellij.openapi.application.impl.ApplicationImpl.runWriteAction(ApplicationImpl.java:1038)
    at io.protostuff.jetbrains.plugin.ProtostuffPluginController.addLibrary(ProtostuffPluginController.java:129)
    at io.protostuff.jetbrains.plugin.ProtostuffPluginController$1.fileOpenedSync(ProtostuffPluginController.java:107)
...
(84 additional frame(s) were not displayed)

This issue is closed as plugin is not supported anymore.
Please switch to https://github.com/jvolkman/intellij-protobuf-editor.


Generate from latest spec

Changes
Generate from latest spec
Tests

[X] make test passing
[X] make fmt applied
[ ] relevant integration tests applied

Codecov Report
Attention: Patch coverage is 0.66100% with 1052 lines in your changes missing coverage. Please review.

Project coverage is 7.03%. Comparing base (094bca8) to head (99d635b).

Files
Patch %
Lines

...ocks/service/dashboards/mock_lakeview_interface.go
0.00%
580 Missing :warning:

.../mocks/service/catalog/mock_endpoints_interface.go
2.57%
189 Missing :warning:

service/dashboards/api.go
0.00%
85 Missing :warning:

service/dashboards/impl.go
0.00%
66 Missing :warning:

service/dashboards/model.go
0.00%
51 Missing :warning:

service/catalog/api.go
0.00%
24 Missing :warning:

service/catalog/impl.go
0.00%
22 Missing :warning:

service/catalog/model.go
0.00%
19 Missing :warning:

service/jobs/model.go
0.00%
11 Missing :warning:

experimental/mocks/mock_workspace_client.go
16.66%
5 Missing :warning:

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #944      +/-   ##
========================================
- Coverage   7.13%   7.03%   -0.10%
========================================
  Files        281     282       +1
  Lines      64633   65589     +956
========================================
+ Hits        4609    4616       +7
- Misses     59715   60664     +949
  Partials     309     309

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


cob_environments: 0.6.5-0 in 'kinetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository cob_environments to 0.6.5-0:

upstream repository: https://github.com/ipa320/cob_environments.git
release repository: https://github.com/ipa320/cob_environments-release.git
distro file: kinetic/distribution.yaml
bloom version: 0.5.26
previous version for package: null

cob_default_env_config
* refactor config structure
* update apartment map
* export envlist
* manually fix changelog
* Contributors: ipa-fmw, ipa-fxm

cob_environments
* manually fix changelog
* Contributors: ipa-fxm

@ipa-flg-pb This branch has conflicts that must be resolved.

Merge conflict has been resolved

With the other cob PRs merged this needs to be resolved again.

Merge conflict resolved

Sorry I messed up at first; the merge conflict is now resolved


Can't install

You can't have both openjdk-17 and openjdk-8, you must remove openjdk-17:
apt autoremove openjdk-17

This should be marked as closed/resolved!


Update sbt-spiewak-sonatype to 0.18.3

Permits re-enabling cats-effect-2 in the Dotty community build.
See https://github.com/lampepfl/dotty/issues/10478

Superseded by https://github.com/lampepfl/dotty/pull/10587


Port genicons.py to Python3 from Python2

Fixes #9
Description

PyGTK has been deprecated in favor of PyGI+GTK. So python3gi has been imported to work with pangocairo.
cairo_font_map_get_default()''' as '''font_map_get_default()''' to get the default font map to use with Cairo. https://lazka.github.io/pgi-docs/PangoCairo-1.0/classes/FontMap.html#PangoCairo.FontMap
New syntax of print statement and '''items()''' instead of '''iteritems''' (the python2 stuff!)

Other information
CairoContext attribute is not present in gi.repository.PangoCairo, hence the line was commented and the script appears to work. I would to like to know more about this.
Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the master branch of the repository.
[x] My commit messages follow best practices.
[ ] I added tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sp35 would you be able to add a test to make sure that the script functions? I'll create a separate issue for setting up CI to run the test on every push.

@kgodey I would love to try! What all should I keep in mind?

The dependencies on Ubuntu(debian-based) were:
python3-cairo and python3-gi
gir1.2-pango-1.0 can be used by other packages using the GIRepository format to generate dynamic bindings.
So for Debian:
sudo apt-get install python3 python3-gi-cairo


Which one is the real Docker Image?

On docker hub there are two HTSeqQC images found: slr71/htseqqc and reetututeja/htseqqc. Then which one is real?

You can use reetututeja/htseqqc


Hide the embedded url

Hello, this is beautiful plugin. I have one question. How can I hide the url of embedded video or picture?
Now I do it with class 'hidden' (display:none). I put every media link inside hidden paragraph and then it works as I want. I am just wondering if there is some build in option for that

set {inlineText: false} in options.

thanks.

I tried it and have 2 problems.

If I embed 2 different videos for some reason it  embeds first video twice
if I click on video it opens video in the new tab and at the same time plays video on my page as it should

Can you create a codepen demo by forking http://codepen.io/ritz078/pen/QjZded ? It will be helpful.

http://codepen.io/Matoo125/pen/rWRZZx
Here it is

This is definitely a bug. Thanks for reporting.

good job.
I downloaded version from npm, but i cannot see it embedding visual part, just text and description
https://s30.postimg.org/eibb4nd4h/Capture.png

check with v4.1.12 and doc example seems to be working fine.

https://s28.postimg.org/wvk7f6nlp/Screenshot_from_2017_01_25_20_24_37.png
same in chrome / opera / firefox .. also opengraph and markdown looks the same.
downloaded again with npm and now it's working. Thank you, will make use of it :1st_place_medal:


Invalid TS config for<EMAIL_ADDRESS>

What happened?
Importing @markdoc/markdoc in a fresh TypeScript projects shows multiple errors:
node_modules/@markdoc/markdoc/dist/index.d.ts:15:24 - error TS2307: Cannot find module 'markdown-it/lib/token' or its corresponding type declarations.

15 import type Token from 'markdown-it/lib/token';
                          ~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@markdoc/markdoc/dist/index.d.ts:98:35 - error TS2552: Cannot find name 'Generator'. Did you mean 'Enumerator'?

98         getAstValues(value: any): Generator<import("./src/types").AstType, void, unknown>;
                                     ~~~~~~~~~

  node_modules/typescript/lib/lib.scripthost.d.ts:271:13
    271 declare var Enumerator: EnumeratorConstructor;
                    ~~~~~~~~~~
    'Enumerator' is declared here.

node_modules/@markdoc/markdoc/dist/src/ast/index.d.ts:11:31 - error TS2552: Cannot find name 'Generator'. Did you mean 'Enumerator'?

11     getAstValues(value: any): Generator<AstType, void, unknown>;
                                 ~~~~~~~~~

  node_modules/typescript/lib/lib.scripthost.d.ts:271:13
    271 declare var Enumerator: EnumeratorConstructor;
                    ~~~~~~~~~~
    'Enumerator' is declared here.

node_modules/@markdoc/markdoc/dist/src/ast/node.d.ts:14:13 - error TS2552: Cannot find name 'Generator'. Did you mean 'Enumerator'?

14     walk(): Generator<Node, void, unknown>;
               ~~~~~~~~~

  node_modules/typescript/lib/lib.scripthost.d.ts:271:13
    271 declare var Enumerator: EnumeratorConstructor;
                    ~~~~~~~~~~
    'Enumerator' is declared here.

node_modules/@markdoc/markdoc/dist/src/renderers/react/react.d.ts:1:57 - error TS2307: Cannot find module 'react' or its corresponding type declarations.

1 import type { createElement, Fragment, ReactNode } from 'react';
                                                          ~~~~~~~

node_modules/@markdoc/markdoc/dist/src/tokenizer/index.d.ts:1:24 - error TS2307: Cannot find module 'markdown-it/lib' or its corresponding type declarations.

1 import MarkdownIt from 'markdown-it/lib';
                         ~~~~~~~~~~~~~~~~~

node_modules/@markdoc/markdoc/dist/src/tokenizer/index.d.ts:2:24 - error TS2307: Cannot find module 'markdown-it/lib/token' or its corresponding type declarations.

2 import type Token from 'markdown-it/lib/token';
                         ~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@markdoc/markdoc/dist/src/utils.d.ts:1:24 - error TS2307: Cannot find module 'markdown-it/lib/token' or its corresponding type declarations.

1 import type Token from 'markdown-it/lib/token';
                         ~~~~~~~~~~~~~~~~~~~~~~~

Some of these errors are due to missing dependencies @types/react and @types/markdown-it
To reproduce

Download or clone https://gist.github.com/alunny-stripe/ed7e03f7a6fd712a8ea93eee36af8dbb
Run npm install
Run npm run types

Version
0.1.7
Additional context
I ran into slightly different errors on my project, which is using TypeScript 4.5.4 and pnpm. Here are the<EMAIL_ADDRESS>errors:
node_modules/@markdoc/markdoc/dist/index.d.ts:15:24 - error TS2307: Cannot find module 'markdown-it/lib/token' or its corresponding type declarations.

15 import type Token from 'markdown-it/lib/token';
                          ~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@markdoc/markdoc/dist/index.d.ts:98:35 - error TS2552: Cannot find name 'Generator'. Did you mean 'Enumerator'?

98         getAstValues(value: any): Generator<import("./src/types").AstType, void, unknown>;
                                     ~~~~~~~~~

  node_modules/typescript/lib/lib.scripthost.d.ts:271:13
    271 declare var Enumerator: EnumeratorConstructor;
                    ~~~~~~~~~~
    'Enumerator' is declared here.

node_modules/@markdoc/markdoc/dist/index.d.ts:111:48 - error TS2694: Namespace '"/Users/alunny/dev/markdoc-ts/node_modules/@markdoc/markdoc/dist/src/types"' has no exported member 'Variable'.

111         Variable: typeof import("./src/types").Variable;
                                                   ~~~~~~~~

node_modules/@markdoc/markdoc/dist/src/ast/index.d.ts:11:31 - error TS2552: Cannot find name 'Generator'. Did you mean 'Enumerator'?

11     getAstValues(value: any): Generator<AstType, void, unknown>;
                                 ~~~~~~~~~

  node_modules/typescript/lib/lib.scripthost.d.ts:271:13
    271 declare var Enumerator: EnumeratorConstructor;
                    ~~~~~~~~~~
    'Enumerator' is declared here.

node_modules/@markdoc/markdoc/dist/src/ast/node.d.ts:14:13 - error TS2552: Cannot find name 'Generator'. Did you mean 'Enumerator'?

14     walk(): Generator<Node, void, unknown>;
               ~~~~~~~~~

  node_modules/typescript/lib/lib.scripthost.d.ts:271:13
    271 declare var Enumerator: EnumeratorConstructor;
                    ~~~~~~~~~~
    'Enumerator' is declared here.

node_modules/@markdoc/markdoc/dist/src/renderers/react/react.d.ts:1:57 - error TS2307: Cannot find module 'react' or its corresponding type declarations.

1 import type { createElement, Fragment, ReactNode } from 'react';
                                                          ~~~~~~~

node_modules/@markdoc/markdoc/dist/src/tokenizer/index.d.ts:1:24 - error TS2307: Cannot find module 'markdown-it/lib' or its corresponding type declarations.

1 import MarkdownIt from 'markdown-it/lib';
                         ~~~~~~~~~~~~~~~~~

node_modules/@markdoc/markdoc/dist/src/tokenizer/index.d.ts:2:24 - error TS2307: Cannot find module 'markdown-it/lib/token' or its corresponding type declarations.

2 import type Token from 'markdown-it/lib/token';
                         ~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@markdoc/markdoc/dist/src/utils.d.ts:1:24 - error TS2307: Cannot find module 'markdown-it/lib/token' or its corresponding type declarations.

1 import type Token from 'markdown-it/lib/token';

PTAL @matv-stripe @rpaul-stripe

Any updates? I've run into similar issue with latest angular project.

Would be awesome if you could take a quick peak at this @benbayard-stripe

Thanks @mfix-stripe! With the changes in #197, this is the minimal tsconfig.json I need to get things passing in TS 4.8.3:
{
  "compilerOptions": {
    "esModuleInterop": true,
    "moduleResolution": "node",
    "target": "esnext"
  }
}

As Ben says, it would be great to add that to the README 😅
On TS 4.5 (which we use internally) and up to 4.7, I still get the following error:
node_modules/@markdoc/markdoc/dist/index.d.ts:111:48 - error TS2694: Namespace '"/Users/alunny/dev/markdoc-ts/node_modules/@markdoc/markdoc/dist/src/types"' has no exported member 'Variable'.

111         Variable: typeof import("./src/types").Variable;                                              ~~~~~~~~

I wonder if there was a change in how esModuleInterop in TS 4.8 🤷

@mfix-stripe is it possible to push out a bug fix release now #197 is merged? Even if it means just cherry-picking those specific commits into a release

Sorry to pile on a closed issue, but I am also seeing a similar issue to what @alunny-stripe raised in that when I use a TypeScript version lower than 4.8 It will throw Variable: typeof import("./src/types").Variable;.
TS 4.8 doesn't seem to do this for me, but TS 4.8 is only a month old and I can't upgrade my project to that version yet.


Problems scanning items classified as Volumes in Comicvine

I have stuff like Escape from New York - Volume 1 and 2.
While other comics have their id in comicvine url starting with 4000-comicid, these Escape from New York volumes have urls like 4050-comicid.
Now if I tell Tenma that Escape from New York - Escape From Florida - Volume 1 has an id of 86530 and hit reprocess it will get the info of a Dick Tracy comic which has an id of 4000-86530 (and my intended comic had id of 4050-86530).

4050 is actually a "Volume" ID. It's where collected "Issues" are found. For instance, on the page you're mentioning, if you click on the that issue, you'll get your 4000 "Issue" ID.
This is a poor descriptor on Comic Vine's part. Issues and Collected Volumes are both considered "Issues" in Comic Vine, but they are also organized separately into different "Volumes". For example, the Escape From New York tradebacks are collected on this page, but the first collected volume is collected on this page.
Sorry for the confusion! I'm hoping to better the matching over time so that this kind of confusion can be avoided.


NetCDF save with dask support

This PR is not quite ready to merge as there are a couple of areas that still need to be addressed with respect to fill_value, dtype and cubes with masked data - I just need to go around the loop to see if further work is needed, and if so, will most likely be resolved in follow-up PRs.
I wanted other devs to see the pattern for streamed saving, which also ensures that nan data is appropriately dealt with in an efficient way, hence the use of da.map_blocks.
There are still a couple of skip_biggus tests that require to be unpinned, and I should add additional testing to ensure that the streaming is doing what we hope for with different permutations of payload ... but that's to follow.

@pp-mo I assume that I now just re-target this PR against dask branch?

I think there are three useful usecases

if any missing points then return a masked array (optional : can we set a fill_value ?, do I care ?)
fill any missing points with a given fill_value
raise error if there are any missing points

(+ in future we might consider a "don't even check for NaNs" option for performance-only-reasons)

Current + possible future call signatures for the above usecases
If array_nans_to_masked() = a-n-t-m() ...

"mask-nans" = "if any missing points then return a masked array
"fill-nans" = "fill any missing points with a given fill_value"
"no-nans" = "raise error if there are any missing points"

current calls

mask-nans : a-n-t-m() [, fill_value=fv]
fill-nans : a-n-t-m(filled=True, fill_value=fv)
no-nans : a-n-t-m(filled=True [, fill_value=None]

future ideas ?
How about a-n-t-m(nans='mask', fill_value=None)

mask-nans : a-n-t-m()  [, nans='mask']
fill-nans : `a-n-t-m(nans='fill', fill_value=fv)'
no-nans : a-n-t-m(nans=None)

That allows you to still specify the fill_value of a masked array.
If that isn't needed then a single key can do it all.
How about...
a-n-t-m(nans=None)

no-nans : a-n-t-m()
mask-nans : a-n-t-m(nans=np.ma.masked)
fill-nans : a-n-t-m(nans=fill_value)

@pp-mo

if any missing points then return a masked array (optional : can we set a fill_value ?, do I care ?)

Agreed use case, interesting part is whether we care to set the fill_value or just opt to use the default fill_value of the dtype as decreed by numpy. We still need the cube.fill_value as that tells the savers what to do, specific to their fileformat - and anyways the user can change that if they care.
If a user plucks a concrete masked data payload from the cube, for whatever reason, then they can set the fill_value to be what they care about, or to the cube.fill_value if that matters to them.
I guess I'm quickly coming to the conclusion that I can't see a use case for why we would want to set the fill_value on the masked data of a cube .... and I missing something obvious here?

fill any missing points with a given fill_value

Yup ... and fill them with the fill_value that is specified ... and this can only be non-None

raise error if there are any missing points

@pp-mo I'm struggling to see when this might be required ... are you thinking of points and bounds of coordinates here? Can you elaborate?

(+ in future we might consider a "don't even check for NaNs" option for performance-only-reasons)

Yup, but not now, right? That's an optimisation that I'd love for us to be in that "happy place" to make, but now just right now.

raise error if there are any missing points

@pp-mo I'm struggling to see when this might be required ... are you thinking of points and bounds of coordinates here? Can you elaborate?

Yes, that's exactly what I'm thinking of.

Ping @pp-mo @lbdreyer @dkillick :smile:

Travis is really having problems ... not helpful!

@pp-mo @lbdreyer @dkillick someone should own this PR and drive the review forward ... tick, tock goes the clock.

Downloads to travis seem to be getting throttled at the moment ... which is painful.

someone should own this PR and drive the review forward

I'm looking at it now, but I don't claim to be in charge.
I've only got 15 mins now, then busy 1300-1400.

Re:

I don't think nans is descriptive of the purpose of this keyword argument

I'm think I'm happy with the routine function, but I will support better naming of arguments !

@pp-mo @lbdreyer @dkillick Okay guys are there any further objections to this PR?
I've address all of @lbdreyer comments ...

closes #2347

All comments have now been addressed so I'm gonna merge this in

@lbdreyer Awesome, thanks!


Install page has slightly different syntax highlight style than Sphinx sites

Ideally, they would style code exactly the same. Let's see if we can smooth this out.
/install

https://jupyterlab.readthedocs.io/en/stable/getting_started/installation.html

Hi @palewire . Would like to work on this issue, Can you guide me ?

You'll want to look at install.md, the _sass/_syntax.scss file and what's happening on the Sphinx site to identify the differences. Then start reconciling the code here to match what we see from Sphinx.

A very basic question, What is Sphinx site ? Also from the screenshot I understood they belong to these links : https://jupyterlab.readthedocs.io/en/stable/getting_started/installation.html and https://jupyter.org/install .
I only see the difference of fonts colors , type of font  and styling. Do we need to change them as the https://jupyterlab.readthedocs.io website. Also how do you want to style it, I can fetch values for some parameters.

I think one difference is that the install instructions here use a shell language:
```shell
mamba install -c conda-forge jupyterlab
```

whereas the ones in jupyterlab use bash:
.. code:: bash

    mamba install -c conda-forge jupyterlab

So if we switch the ones here to bash that would probably make them the same


webapp:Adding tests for hybrid connection and vnet integration methods.

Is your feature request related to a problem? Please describe.
In the future, I want to add more tests for the hybrid connection and vnet-integration commands, as I have had a lot issues with how difficult the required relay libraries can be to work with. This will require a lot more research, and potentially reaching out to the relay team

closing this since we already finished this.


Add additional length check when checksum offloading is used

Add additional length check when checksum offloading is used
Description
The FreeRTOS+TCP stack already has a compile time constant named ipconfigDRIVER_INCLUDED_RX_IP_CHECKSUM.  When that constant is set to 0 the TCP/IP stack validates IP packet checksum and length fields in software.  When that constant is set to 1 those checks are offloaded to the networking hardware.  This update changes that behaviour so the length fields are checked in software even when ipconfigDRIVER_INCLUDED_RX_IP_CHECKSUM is set to 1.
Checklist:

[x] I have tested my changes. No regression in existing tests.
[x] My code is Linted.


[Docs Rewrite] Remove "Using Immutable.js" page

Name: :book: New/Updated Documentation Content
About: Adding a new docs page, or updating content in an existing docs page
PR Type
Does this PR add a new page, or update an existing page?
Checklist

[x] Is there an existing issue for this PR?

https://github.com/reduxjs/redux/issues/4052

[x] Have the files been linted and formatted?

What docs page is being added or updated?

Deleted: docs/recipes/UsingImmutableJS.md
Updated: docs/FAQ.md
Updated: docs/api/createStore.md
Updated: docs/faq/ImmutableData.md
Updated: docs/faq/ReactRedux.md
Updated: docs/introduction/Ecosystem.md
Updated: docs/recipes/README.md
Updated: docs/recipes/Troubleshooting.md
Updated: docs/recipes/structuring-reducers/BeyondCombineReducers.md
Updated: docs/recipes/structuring-reducers/StructuringReducers.md
Updated: docs/understanding/history-and-design/PriorArt.md
Updated: website/_redirects
Updated: website/sidebars.js

For Updating Existing Content
Do these updates change any of the assumptions or target audience? If so, how do they change?
Updated the recommendation of Immutable.js to be Immer, I have assumed these libraries are hot-swappable and replacements for each other. It is critical to confirm this as otherwise, wording may need to be changed.

Please see below key comments on changes I have made that should be questioned.
docs/FAQ.md -
Deleted references to using Immutable.JS with Redux.
Changed "Do I have to use Immutable.JS" to "Do I have to use Immer" - Is this correct still?
docs/faq/ImmutableData.md -

JavaScript Immutability presentation PDF - Does mention Immutable.js, however,
it also provides solid understandings of immutability so I think it is worth keeping it?

Under "What approaches are there for handling data immutability? Do I have to use Immer?",
I have kept the original Immutable.JS description, are these libraries swappable and the description is still correct?

docs/recipes/structuring-reducers/BeyondCombineReducers.md -

Here, I have removed a direct reference to Immutable.JS but kept the "combineReducers" description about immutable maps in general.
I swapped the description of using Slice reducers to recommend RTK that uses a createReducer utility, is this acceptable?

website/_redirects -

I have added redirects as I have seen fit, however, I couldn't seem to test them locally? (Tested in Netlify deploy preview and seems to work).
I have separated them out from other redirects for now as they are very specific, please advise on their location.

Thanks for filing this!
First observation: no, Immer and Immutable.js are not swappable for each other directly. They both operate in the same space (providing ways to immutably update values, and preventing accidental mutations), but they take very different approaches:

Immutable.js is a collection of data types like Map and List, implemented using a specialized internal data structure. Operations like Map.set() return new instances immutably, instead of mutating the existing instance.  These data types are not compatible with plain JS data directly. Instead, you have to convert to/from plain JS data.
Immer is a single produce function that uses Proxies to wrap your original state in a "draft" value. You can "mutate" that draft, and Immer tracks all the attempted changes. It then replays those mutations immutably to return the desired result, same as if you'd done a bunch of nested object spreads and array slices by hand.  Immer works specifically with plain JS data.

So, same problem space, very different approaches. If you're using Immutable.js already, it takes a bunch of work to migrate over to using Immer instead.

Thanks for the explanation!
I have made all the changes requested except this comment here: https://github.com/reduxjs/redux/pull/4053#discussion_r605795450
I closed the comments as "resolved" but then realised that might be something you need to do? Hopefully, all is okay!

Y'know, let's just delete everything under the "Immutable Data" header in the "Ecosystem" page except for Immer. None of those other libs are relevant any more now that Immer exists.
(and yeah, marking comments as "resolved" is fine if you've made the relevant changes)

Heh, I love pasting in old URLs into previews and watching the redirects kick in :)
Awright, this is probably good enough for now. Thanks, really appreciate you doing this!


Wrong resistance shown?

Build: https://pastebin.com/T2NVCG9d
Character: https://www.pathofexile.com/account/view-profile/GreenEyes1993/characters - GreenEyes_S
Ingame it shows clearly 75%+ Cold Resistance
https://puu.sh/AMbsK.png
In Path of Building only 61%

Do you have the bandit option set? It cannot be imported, unlike the rest of your character's data. Selecting Alira gives the correct resistances, so I suspect that's what you have.

Ah right, that's it.
Thanks!