chore: v2.15.7

Codecov Report

Merging #626 (7aa39e6) into main (183284a) will increase coverage by 0.04%.
The diff coverage is 68.96%.

:exclamation: Current head 7aa39e6 differs from pull request most recent head 0f6daa8. Consider uploading reports for the commit 0f6daa8 to get more accurate results

@@            Coverage Diff             @@
##             main     #626      +/-   ##
==========================================
+ Coverage   58.98%   59.02%   +0.04%
==========================================
  Files        1208     1203       -5
  Lines       74636    73940     -696
  Branches    15463    15302     -161
==========================================
- Hits        44021    43643     -378
+ Misses      27911    27615     -296
+ Partials     2704     2682      -22

Impacted Files
Coverage Δ

...es/core-browser/src/services/status-bar-service.ts
100.00% <ø> (ø)

packages/editor/src/common/editor.ts
100.00% <ø> (ø)

...on/src/browser/vscode/api/main.thread.statusbar.ts
80.64% <ø> (ø)

packages/extension/src/common/vscode/model.api.ts
84.05% <ø> (ø)

...extension/src/common/vscode/models/html-content.ts
16.66% <ø> (ø)

...es/file-tree-next/src/browser/file-tree.service.ts
61.90% <ø> (+0.45%)
:arrow_up:

...es/extension/src/browser/extension-node.service.ts
22.68% <12.50%> (-1.24%)
:arrow_down:

packages/extension/src/common/vscode/converter.ts
38.26% <50.00%> (+0.37%)
:arrow_up:

packages/core-browser/src/index.ts
100.00% <100.00%> (ø)

packages/core-common/src/types/index.ts
100.00% <100.00%> (ø)

... and 763 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fa6efd...0f6daa8. Read the comment docs.

@hacke2 还是有问题，手动本地合并吧


/bin/bash: bad interpreter: No such file or directory

How to reproduce, git clone https://github.com/haskell/haskell-ide-engine and run stack2nix . > default.nix:
[neo@nixos:~/Sources/haskell-ide-engine]$ stack2nix . > default.nix
Ensuring cabal2nix version is >= 2.2.1 ...
Ensuring git version is >= 2 ...
Ensuring cabal version is >= 1 ...
Running /tmp/s2n/programs/x86_64-linux/ghc-8.0.2.temp/ghc-8.0.2/configure --prefix=/tmp/s2n/programs/x86_64-linux/ghc-8.0.2/ in directory /tmp/s2n/programs/x86_64-linux/ghc-8.0.2.temp/ghc-8.0.2/ exited with ExitFailure 1

checking for path to top of build tree...
/tmp/s2n/programs/x86_64-linux/ghc-8.0.2.temp/ghc-8.0.2/configure: utils/ghc-pwd/dist-install/build/tmp/ghc-pwd-bindist: /bin/bash: bad interpreter: No such file or directory
configure: error: cannot determine current directory

Error: Error encountered while configuring GHC with
         /tmp/s2n/programs/x86_64-linux/ghc-8.0.2.temp/ghc-8.0.2/configure --prefix=/tmp/s2n/programs/x86_64-linux/ghc-8.0.2/
         run in /tmp/s2n/programs/x86_64-linux/ghc-8.0.2.temp/ghc-8.0.2/

The following directories may now contain files, but won't be used by stack:
  - /tmp/s2n/programs/x86_64-linux/ghc-8.0.2.temp/
  - /tmp/s2n/programs/x86_64-linux/ghc-8.0.2/

This means that it's not using --nix when calling stack.

cc @jmitchell

Ref: https://github.com/commercialhaskell/stack/issues/2634

Had the same issue, that was fixed by running stack2nix in a nix-shell where ghc802 was available:
nix-shell -p haskell.compiler.ghc802

but of course you should have a nix: block in your stack.yaml.

@MartinPotier @razvan-panda what git commit of stack2nix were you using?

https://github.com/input-output-hk/stack2nix/commit/fe3af222ae28a595aa943cd780470d09f5551e62 (used it on a private project, following haskell lts-8.5)

I can finally reproduce this using isolated environment and a bunch of hacks using haskell-ide-engine:
$ nix-shell --pure -p glibcLocales nix git cabal-install cabal2nix --run "LANG=en_US.utf8 NIX_REMOTE=daemon NIX_PATH=nixpkgs=/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs:nixos-config=/etc/nixos/configuration.nix:/nix/var/nix/profiles/per-user/root/channels stack2nix . > pkgs.nix"

Looking into what's going on.


What is the "group" column for and how can I write to it?

So I see after install there is a "group" column in the tags table.
CREATE TABLE tags (
    id SERIAL PRIMARY KEY,
    name character varying,
    taggings_count integer DEFAULT 0,
    group character varying -- <~~~This guy right here
);

I have been searching around in GH and haven't seen anything explicitly pointing this column out, but I'd like to use it as a way, to well, "group" my tags.
As a secondary issue, I have a model that is the basis of my tags where this "grouping" already exists and I was hoping to use AATO to achieve using this model as the "source" of tags for a different model.
i.e.
I have an Athletes model (has acts_as_taggable_on :positions)
I have a Positions model (nothing special here at the moment...)
I have a User model (has acts_as_tagger)
I want to be able to "tag" an Athlete with a position with a User being the owner of that tag
RB = Running Back
WR = Wide Receiver
A1 tagged with "RB" owned by U1
A1 tagged with "WR" owned by U2
So you can see that U1 is "tracking" A1 for RB, and U2 is "tracking" A1 for WR...
I then want to use the "group" column on the tag to represent "Offense", "Defense", or "Special", so I could query all athletes being tracked for "Offense"

Well, I'm an idiot, apparently, the "group" column was added in a migration that I added, so there's that...
But I suppose the latter part of my question still stands...


bug(Chips): Selecting value from autocomplete by keyboard navigation causes both the search string and the selected option to be added

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
Reproducible on this example.
Reproduction
StackBlitz link: https://stackblitz.com/edit/rd9usi?file=package.json
Steps to reproduce:

Type any input that is a substring of any item in the suggestion list
Navigate to a suggestion with keyboard
Press Enter
Both the search string and the selected are added

Expected Behavior
Only the selected suggestion is added
Actual Behavior
Both the selected and the suggested values are added
Environment

Angular: 16.2.6
CDK/Material: 16.2.8
Browser(s): Google Chrome
Operating System (e.g. Windows, macOS, Ubuntu): darwin arm64

It's very basic scenario which I also hit right after I started exploring mat-chips.
@angular-team When is it planned to incorporate the fix?
With such a bug it's practically unusable.

Same here.
any ideas on how to fix? maybe some workaround?


[sdk/dotnet] Input<T> eagerly converts values to Output<T> leading to undesirable preview diffs

In the .NET SDK, Input<T> (and InputList<T>, InputMap<V>, InputUnion<T0, T1>, and InputJson) eagerly stores the value of T as an Output<T>, which leads to undesirable preview diffs.
https://github.com/pulumi/pulumi/blob/0a38bc295cfc5ae3c325dcece169da5a5e80fffc/sdk/dotnet/Pulumi/Core/Input.cs#L22-L31
For example, consider this program:
using Pulumi;
using Pulumi.Random;
using Pulumi.Aws.S3;

class MyStack : Stack
{
    public MyStack()
    {
        var randString = new RandomString("str", new RandomStringArgs { Length = 10 });
        var bucket = new Bucket("bucket", new BucketArgs {
            Tags = {
                { "hello", "world" },
                { "hi", "there" },
                { "foo", randString.Id },
            }
        });
    }
}

Expected preview diff:
        tags        : {
            hello     : "world"
            hi        : "there"
            foo       : output<string>
        }

Actual:
        tags        : output<string>

This also means that we have the same issue with programs that create multi-lang components, even with output values added in pulumi/pulumi#8316.
To address this, we need to fix Input<T> et. al. to not eagerly convert values to Output<T>. Instead, internally, it can keep a discriminated union of the plain T and Output<T> and only convert to Output<T> when needed.

Hitting this issue while developing Pulumi Service Provider - really confusing behavior, forced to rewrite a map into an array of custom objects. Would be great to fix and avoid this.


simplify loops with foreach

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[x] Each commit in the pull request should have a meaningful subject line and body.
[ ] Format the pull request title like [JAV-XXX] Fixes bug in ApproximateQuantiles, where you replace JAV-XXX with the appropriate JIRA issue.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

fix #378

Changes Unknown when pulling 3766f2da7bfdd8c9192299ec9b1459cd02c76629 on spinecho20:xin into ** on ServiceComb:master**.


Autosave form using JS creates new record on each POST request

I got auto-save working on a form using the following code:
<script>

$(document).on('turbolinks:load', function() {

  var $form = $('form.autosave');

  function autoSaveForm(actionPath) {
    var data = $form.serialize();
    console.log("POST: " + actionPath);
    var request = new XMLHttpRequest();
    request.open('POST', actionPath, true);
    request.setRequestHeader('Content-Type', 'application/x-www-form-urlencoded; charset=UTF-8');
    request.send(data);
  }

  $form.on('blur', 'input', function() {
    var actionPath = $form.attr('action');
    autoSaveForm(actionPath);
  });

});

</script>

However it doesn't work when I add another child record. It saves a new record  in the DB each time I move to another field. The view stays the same, but in the DB I see new records being saved  like this:
record1
field1: data1
(POST request on blur)
record1
field1: data1
record2
field1: data1
field2: data2
(POST request on blur)
record1
field1: data1
record2
field1: data1
field2: data2
record3
field1: data1
field2: data2
field3: data3
ETC....
Any ideas what is causing this? Is my controller ignoring the ID of the child-record? I've permitted it in the params, I'm sure of that. Here is my controller:
class ProfilesController < ApplicationController
  before_action :authenticate_user!
  before_action :set_profile, only: [:show, :edit, :update, :edit, :destroy]

  # GET /profiles
  # GET /profiles.json
  def index
    @profiles = Profile.all
  end

  # GET /profiles/1
  # GET /profiles/1.json
  def show
    @positions = @profile.positions
  end

  # GET /profiles/1.json
  def display
    user = User.find_by_rid(params[:rid])
    @positions = []
    if user == current_user
      if user.profile
        @profile = user.profile
      else
        new_profile = user.build_profile({})
        new_profile.save
        @profile = new_profile
      end
      @positions = @profile.positions if @profile.positions
    end
  end

  # GET /profiles/new
  def new
    @profile = Profile.new
    @profile.positions.build
  end

  # GET /profiles/1/edit
  def edit
<EMAIL_ADDRESS>  end

  # POST /profiles
  # POST /profiles.json
  def create
    @profile = Profile.new(profile_params)

    respond_to do |format|
      if @profile.save
        format.html { redirect_to @profile, notice: 'Profile was successfully created.' }
        format.json { render :show, status: :created, location: @profile }
      else
        format.html { render :new }
        format.json { render json: @profile.errors, status: :unprocessable_entity }
      end
    end
  end

  # PATCH/PUT /user/profile/1
  # PATCH/PUT /user/profile/1.json
  def update
    respond_to do |format|
      if @profile.update(profile_params)
        format.html { redirect_to display_my_profile_path(current_user.rid), notice: 'Profile was successfully updated.' }
        format.json { render :show, status: :ok, location: @profile }
      else
        format.html { render :edit }
        format.json { render json: @profile.errors, status: :unprocessable_entity }
      end
    end
  end

  # DELETE /user/profile/1
  # DELETE /user/profile/1.json
  def destroy
    @profile.destroy
    respond_to do |format|
      format.html { redirect_to profiles_url, notice: 'Profile was successfully destroyed.' }
      format.json { head :no_content }
    end
  end

  private
    # Use callbacks to share common setup or constraints between actions.
    def set_profile
      if current_user
        @profile = Profile.find_by user_id: current_user.id
        if @profile.nil?
          @profile = current_user.build_profile({})
          @profile.save
          @profile = Profile.find_by user_id: current_user.id
        end
      else
        @profile = {}
      end
    end

    # Never trust parameters from the scary internet, only allow the white list through.
    def profile_params
      params.require(:profile).permit(:first_name, :last_name, :phone, :industry, :summary, :location, :completion, positions_attributes: [:id, :title, :industry, :company_name, :country_code, :location, :start_month, :end_month, :start_year, :end_year, :profile_id, :_destroy])
    end
end

Thanks for your time!

It turns out the issue with my JS, I improved things a bit but I still would love to know how best to implement auto-save so I'm going to open a new ticket.


Backup/Restore Utility

Papermerge 2.1 does not have backup/restore utility.
Well, actually there is code for backing up and restoring files, but the utility was written for 2.0 and basically as of today it is not usable for 2.1.
This ticket is about updating, cleaning up and making code for backup/restore work for 2.1.
This ticket is something between bug and "new feature request" as the code per se was there but the utility failed to backup/restore.

Restore/Backup utility is available since version 2.1.5


Cursor Pagination without relay

Hello and merry xmas.
I just finished an implementation of cursor pagination for a non-relay context and I encountered a couple of issues I would like to ask about and perhaps get a few pointers on a better implementation. Pagination was implemented using a modified version of django-cursor-pagination , sub-classing StrawberryDjangoField , implementing a generic type for the pagination result and a custom field function to return and pass options to  the instance of the sub classed  StrawberryDjangoField
Field Implementation:
@strawberry.type
class PageInfo:
    has_next_page: bool
    has_previous_page: bool
    start_cursor: Optional[str]
    end_cursor: Optional[str]

E = TypeVar("E")
@strawberry.type
class CursorPaginatedList(Generic[E]):
    page_info: PageInfo
    items: List[E]

@strawberry.input
class CursorPaginationInput:
    first: Optional[int] = None
    last: Optional[int] = None
    before: Optional[str] = None
    after: Optional[str] = None

class CursoredGenericDjangoField(
    _StrawberryDjangoField
):
    def __init__(self, cursor_ordering=UNSET,  **kwargs):
        self.cursor_pagination = kwargs.pop('cursor_pagination',False)
        #remove other pagination and order if defined
        if self.cursor_pagination:
            kwargs.pop('order')
            kwargs.pop('pagination')
        super().__init__(**kwargs)

    @property
    def arguments(self) -> List[StrawberryArgument]:
        arguments = []
        if self.cursor_pagination:
            arguments.append(argument("cursor_pagination",CursorPaginationInput))
            arguments.append(argument("cursor_ordering",Optional[str]))
        return super().arguments + arguments

    @property
    def is_list(self):
        if self.cursor_pagination is UNSET or not self.cursor_pagination:
            return super().is_list
        return True

    @property
    def type(self) -> Union[StrawberryType, type]:
        return super().type

    @type.setter
    def type(self, type_: Any) -> None:
        super(CursoredGenericDjangoField, self.__class__).type.fset(self, type_)
        #store type and inner type to use in return of result and get_queryset to grab
        #any get_queryset overload that exists on inner type definition
        if type_ is not None and self.cursor_pagination:
            self.paginated_type = type_
            self.inner_type = typing.get_args(type_)[0]

    #resolvers.resolve_result returns a coroutine which needs to be awaited so we can get a list and slice it
    #so this needs to be async. Could not figure out a better way to do this.
    async def rewrap_result(self,result,**kwargs):
        qls = list(await result)
        cp = kwargs.get('cursor_pagination',None)
        if cp and len(qls):
            page = self.paginator.page_from_list(qls,first=cp.first , last=cp.last , after=cp.after, before=cp.before)
            pi = PageInfo(
                has_next_page= page.has_next,
                has_previous_page= page.has_previous,
                start_cursor=page.paginator.cursor(page.items[0]),
                end_cursor=page.paginator.cursor(page.items[-1]),
            )
            res =  self.paginated_type(
                page_info=pi,
                items=page.items,
            )
        else:
            pi = PageInfo(
                has_next_page= False,
                has_previous_page= False,
                start_cursor=None,
                end_cursor=None,
            )
            res =  self.paginated_type(
                page_info=pi,
                items=qls,
            )
        return res

    def get_result(
        self,
        source: Optional[models.Model],
        info: Info,
        args: List[Any],
        kwargs: Dict[str, Any],
    ) -> Union[Awaitable[Any], Any]:
        if self.cursor_pagination:
            return self.rewrap_result(super().get_result(source , info , args , kwargs), **kwargs)
        return super().get_result(source , info , args , kwargs)

    def paginate(self , qs , **kwargs):
        cp = kwargs.get('cursor_pagination')
        order = kwargs.get('cursor_ordering','id')
        self.paginator = CursorPaginator(qs, ordering=(order,'-id'))
        #Had to modify the paginator to split it's original page method into
        #two separate methods one adding filters to the queryset and another to slice the result
        #because resolvers.resolve_result returns a coroutine and not a queryset
        page = self.paginator.page_queryset(first=cp.first, after=cp.after , last=cp.last , before=cp.before)
        return page

    def get_queryset(self, queryset, info, order=UNSET, **kwargs):
        if self.cursor_pagination:
            inner_get_queryset = getattr(self.inner_type,"get_queryset",None)
            #Apply inner get queryset defined on the paginated type
            if inner_get_queryset:
                queryset = inner_get_queryset(queryset, info, **kwargs)
            #Get the queryset from super now so we get filtering on it
            queryset =  super().get_queryset(queryset, info, order=order, **kwargs)
            #Apply pagination and ordering or just ordering based on one
            #unique field as required for cursor pagination
            if kwargs.get('cursor_pagination',None):
                queryset = self.paginate(queryset,**kwargs)
            else:
                ob = kwargs.get('cursor_ordering',None)
                if ob:
                    queryset = queryset.order_by(ob)
            return queryset
        return super().get_queryset(queryset, info, order=order, **kwargs)

#re-defining the field function would not be necessary if:
#  1) Any number of extra params would be passed to the constructor of the field class
#  2) a field_cls parameter would allow for selection of which class would be returned like with type
def field(
    resolver=None,
    *,
    name: Optional[str] = None,
    field_name: Optional[str] = None,
    is_subscription: bool = False,
    description: Optional[str] = None,
    permission_classes: Optional[List[Type[BasePermission]]] = None,
    deprecation_reason: Optional[str] = None,
    default: Any = dataclasses.MISSING,
    default_factory: Union[Callable[..., object], object] = dataclasses.MISSING,
    metadata: Optional[Mapping[Any, Any]] = None,
    directives: Optional[Sequence[object]] = (),
    pagination: Optional[bool] = UNSET,
    filters: Optional[type] = UNSET,
    order: Optional[type] = UNSET,
    only: Optional[TypeOrSequence[str]] = None,
    select_related: Optional[TypeOrSequence[str]] = None,
    prefetch_related: Optional[TypeOrSequence[PrefetchType]] = None,
    disable_optimization: bool = False,
    init: Literal[True, False, None] = None,
    #This was added to allow cursor_pagination=True to be passed to the instance
    #or any other parameter that we may require in other subclasses of StrawberryDjangoField
    **kwargs
) -> Any:

    f = CursoredGenericDjangoField(
       python_name=None,
       django_name=field_name,
       graphql_name=name,
       type_annotation=None,
       description=description,
       is_subscription=is_subscription,
       permission_classes=permission_classes or [],
       deprecation_reason=deprecation_reason,
       default=default,
       default_factory=default_factory,
       metadata=metadata,
       directives=directives,
       filters=filters,
       pagination=pagination,
       order=order,
       only=only,
       select_related=select_related,
       prefetch_related=prefetch_related,
       disable_optimization=disable_optimization,
       **kwargs
    )
    if resolver:
        f = f(resolver)
    return f

Usage:
@strawberry.type
class Query:
    paginated_list:  module.CursorPaginatedList[SomeType] = module.field(cursor_pagination=True , filters=SomeFilter)

Or CursorPaginatedList could be sub classed to add more fields to it.
Issues:

Is there any way to make the field function in this package more "generic" so it can instantiate any subclass of StrawberryDjangoField passing to it any number of extra arguments and leave it to the user to pop them so they don't get passed down the inheritance chain ?
resolvers.resolve_result returns a coroutine which forced me to use the workarounds outlined in the comments and to modify the paginators functionality splitting the filtering on the queryset from the slicing of the result. Can you suggest any workaround on this?
My initial instinct was to detect whether the type is a subclass of CursorPaginatedList and not have to pass a cursor_pagination=True to the constructor but I could not find a way to detect the type within the init to disable default order and pagination. Also couldn't find a reliable way to detect  whether a type is a subclass for that matter. Any suggestions ?

Enhancements:

While reading through the code to get hints for my implementation I noticed that it's very tightly coupled with the relay implementation which made it kind of hard to figure out which part needed to be re-implemented. Perhaps the relay implementation should be completely separate ?
StrawberryDjangoField is a subclass of strawberry_django.field.StrawberryDjangoField which has multiple inheritance on the pagination , filter and ordering classes. It would be nice if a bare minimally working version of StrawberryDjangoField was provided so a user can do his own composition on the field choosing to use , not use or maybe replace  some of these classes.

Thanks in advance for any comments or suggestions you may have on this.

Hey @m4riok ,
First of all, for curiosity, why are you implementing your own "no relay" cursor pagination while it looks a lot like the relay one?

Is there any way to make the field function in this package more "generic" so it can instantiate any subclass of StrawberryDjangoField passing to it any number of extra arguments and leave it to the user to pop them so they don't get passed down the inheritance chain ?

We could probably receive an optional field_type keyword, which defaults to StrawberryDjangoField if not provided, and use it to instantiate the field. What do you think?

resolvers.resolve_result returns a coroutine which forced me to use the workarounds outlined in the comments and to modify the paginators functionality splitting the filtering on the queryset from the slicing of the result. Can you suggest any workaround on this?

That method is there specifically to handle cases where non async resolvers are called inside a running asyncio loop, which django says should be wrapped with sync_to_async. Check the async_safe implementation for more details.
If you want so support both sync and async with your code, you will have to write some spaghetti code there, unfortunately T_T. I have some utils in this lib that helps with that like the aio.resolve and aio.resolver functions. They will wrap that coroutine and return a coroutine themselves which will get cascading resolved by strawberry itself at the end. You can check some of their usage across this repo

My initial instinct was to detect whether the type is a subclass of CursorPaginatedList and not have to pass a cursor_pagination=True to the constructor but I could not find a way to detect the type within the init to disable default order and pagination. Also couldn't find a reliable way to detect whether a type is a subclass for that matter. Any suggestions ?

The issue here is that the field gets created before the type annotation is assigned to it, which happens when creating the type itself.
There are some ways around it, like, for example, overriding the arguments property and poping those from it, like what I do in StrawberryDjangoConnectionField

While reading through the code to get hints for my implementation I noticed that it's very tightly coupled with the relay implementation which made it kind of hard to figure out which part needed to be re-implemented. Perhaps the relay implementation should be completely separate ?

It actually is. The https://github.com/blb-ventures/strawberry-django-plus/blob/main/strawberry_django_plus/relay.py is a generic relay implementation in which you can also override some of its methods to do a different kind of pagination (e.g. implement a real cursor based instead of the basic offset pagination it uses).
The django type creation checks if it is a subclass of Node, and if it is, it will override those methods with some that provides better integration with querysets.

StrawberryDjangoField is a subclass of strawberry_django.field.StrawberryDjangoField which has multiple inheritance on the pagination , filter and ordering classes. It would be nice if a bare minimally working version of StrawberryDjangoField was provided so a user can do his own composition on the field choosing to use , not use or maybe replace some of these classes.

Yeah, I agree. This repo is actually going to be merged to strawberry_django in the future, and when that happens, I plan on refactoring some code to solve some of those legacy issues.


quote jq path in prow metallb setup

fixes a small issue on zsh install_metallb:9: no matches found: .[0].IPAM.Config[0].Subnet when trying to
source prow/lib.sh
install_metallb $KUBECONFIG

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
1cf24ee6bd2771471309b2846d22a5f797c69c69
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio


Fix X11 runtime with vc4graphics, disable kernel console along when ENABLE_UART is unset

These are misc changes needed for vc4graphics to work.

I rebased it on top if latest master, no code changes, please merge

Thanks @kraj


Budget app

In this pull request

[x] Splash screen
[x] Sign up and login pages
[x] Home page (categories page)
[x] Transactions page
[x] Added a new transaction" page
[x] Create unit and integration tests for all the essential components of the RoR application.

Hey @frnega
If you need any help regarding my review then you can reach out to me on slack and i can help you fix this problem in one call :blush:


New Tips: Build tooling (Gulp, Yeoman)

:+1:

:+1:

:+1:

:+1:

:thumbsup:

:+1:

:+1:

:+1:

+1

:+1:

+1

:+1:

:+1:

:+1:

:+1:

:+1:

:+1:

:thumbsup:

:+1:

:+1:


fix fix forget to abort txn when insert checkStrictMode failed

Proposed changes
Issue Number: close #xxx

we need to abort the transaction  when checkStrictMode failed.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


[dy] Restrict file creation through the API

Description

Resolves file/folder create issue through the file explorer. This should not allow users to create files or folders outside of the project repo.
How Has This Been Tested?

[x] Tested locally

Checklist

[x] The PR is tagged with proper labels (bug, enhancement, feature, documentation)
[x] I have performed a self-review of my own code
[x] I have added unit tests that prove my fix is effective or that my feature works
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation

cc:

oh wait this doesn't work with python 3.7


Cleanup: convert uses of import numpy as onp in library code

We started on this a while ago, but have not yet finished the process.
We still have lots of onp/np/jnp switches to make in tests & docs.

Internal tests pass.


This project is dead ?

The last commit dates from 26 Jul 2016.

I think it would be the responsible thing to do to archive this project, there are a lot of unaddressed bugs that actually make it unusable and it would be nice to have a warning about that.


Simplify production deployments to be a single command

This PR adds a make target to redeploy a production deployment.

It builds the containers required, before stopping the currently running instance, to reduce the down-time of the service.

It adds a commit to use omigrate to run the migrations instead of manually running the migrations on the Postgres DB.  The production DB may need to be updated to mark the existing migrations as already run. I'm not sure why we used the manual approach so far, and this seems better, unless I'm missing something. I don't have access to the production servers, right now, to check what needs to be done there to make this PR usable.

@punchagan I think perhaps we can have two targets, one redeploy with migration and one without, we don't need to the run the migrations every time :)

@gs0510 The omigrate tool would take care of whether migrations need to run or not, running only new migrations that need to be run. Leaving this to manual discretion seems error prone to me.

awesome, then this looks good :) You can try it on the prod machine IST morning, shouldn't affect anyone :))

I've fixed the schema_migrations table in the production DB to allow us to run omigrate up in future.
docker exec -it current-bench_pipeline_1 omigrate up --verbose --source=/app/db/migrations --database=postgresql://docker:docker@db:5432/docker
omigrate: [INFO] Version<PHONE_NUMBER>0054 has already been applied
omigrate: [INFO] Version<PHONE_NUMBER>3805 has already been applied
omigrate: [INFO] Version<PHONE_NUMBER>5643 has already been applied
omigrate: [INFO] Version<PHONE_NUMBER>5089 has already been applied
omigrate: [INFO] Version<PHONE_NUMBER>1834 has already been applied

This PR is now ready to be merged and deployed.

Awesome, thanks a ton @punchagan!


Consider muP suggestions made in Appendix D of Tensor Programs V

Appendix D of the Tensor Programs V paper contains a number of practical suggestions for using muP which we would do well to consider, such as:

fixing the dimension of each attention head as the model is scaled (D.4)
using normal/Gaussian initialisation instead of uniform initialisation (D.5)
use zeros to initialise attention query layers and "output" layers (those that map from scaled to non-scaled dimension) (D.2)
tuning "input, output, and attention multipliers" (need to check exactly what this means) (D.7)

No further improvements of mup are on the table


mWeb/Android - Split/Send/Request money - The transition is not smooth when requesting/split amount

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to URL https://staging.new.expensify.com/
Login with any chat
Go to any group conversation or chat
Click the + icon
Select Split Bill/Send Money/Request Money
Enter an amount and select the Next confirmation button

Expected Result:
The transition should be smooth
Actual Result:
The transition is not smooth
Workaround:
Unknown
Platform:

Where is this issue occurring?

Mobile Web

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): any
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/186993264-fe99cc5a-a028-4efb-b377-dc396ee07a00.mp4
https://user-images.githubusercontent.com/93399543/186993270-b1a8f8fe-0c72-44ab-b040-ed4893921e21.mp4
https://user-images.githubusercontent.com/93399543/186993276-0ed0a687-636c-46b2-95ec-087be0986437.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

I'm not sure I see the issue here w/ "The transition is not smooth". Do you have the original Slack discussion or a more detailed description for additional context?

@robertjchen hello! The transitions between modals is included in our scope when testing the regression. In the video it can be seen that the loading of the Big Number Pad page is glitchy (it's kinda hard to put it into words haha).
If these types of bugs related to transitions are not in scope please let us know and we'll inform the team.

Ahh, I think I see it now! These issues are definitely in scope as we want to make the app as well-polished as possible 😉 Let me open this up to our contributors to see if there's a proposal to make it better 🙏

job: https://www.upwork.com/jobs/~0165f8b1c2bb3e578e

increased to $500

Seems smooth to me
https://user-images.githubusercontent.com/11542415/190520174-033e3416-ce95-46f2-b244-77b4966723cd.mov

Seems smooth to me
Screen.Recording.2022-09-16.at.3.21.04.AM.mov

In the second 0:05 the modal blinks for a fraction of a second, I think that is what @isagoico was referring to [here] (https://github.com/Expensify/App/issues/10610#issuecomment-1234564719).

@marcochavezf thoughts on doubling?

@marcochavezf thoughts on doubling?

Yeah I think makes sense to double the price, the glitch is also happening on Android (native):
https://user-images.githubusercontent.com/6829422/191376612-9a82d822-485b-4bbb-98fe-bf1b20338abf.mp4
Seems we're displacing the pad number (for a fraction of a second) in order to display the phone keyboard, but the position of the pad number should be static.
@JmillsExpensify I think this issue can be considered also part of the WA quality project, thoughts?

Paused the video when this happens and the pad number shouldn't be in that position:

⚠ Looks like this issue was linked to a possible regression on PRODUCTION here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

In this case there's no linked PR, but the linked issue seems to be related

Related to this ^ I think the linked issue is a different problem and seems it's no longer happening.

According to this post, I'm going to put this issue on hold until we have a solution for the keyboard initiative because seems to be related. Also, I'm going to remove the label Help Wanted. @dylanexpensify could you remove the job from Upwork?

Yes! Shall we close then @marcochavezf ?

@dylanexpensify Ah I think only the Upwork job, because the problem exists, and we'd want to re-evaluate the issue after the Keyboard initiative is implemented.

Snagging this from you @dylanexpensify since I'm on the tracking issue.

Now that the keyboard initiative is kicked off, I'm removing the hold.

@tgolen Shall you take this one from @marcochavezf as well, since you're leading the tracking issue?

Whatever the case, the old Upwork job expired so I have created a new one and also raised the price to $1000 given that this is a mainline initiative for WAQ. https://www.upwork.com/jobs/~0123070f67b356c4b3

One final note. @applausebot can you help me re-test this as well, as I don't have an Android device I'm able to test with.

Sure, I'll take this over.

You know what, I think we are done here. I just tested this and the bouncing caused by the keyboard no longer exists. I'm attaching a video of my test just now.
https://user-images.githubusercontent.com/1127863/200194345-15bd2a69-e636-4aa8-adbc-5351ccdc7e01.MP4

Given that I'm unable to reproduce I'm closing this issue. Another keyboard issue bites the dust!


Use QCommandLineParser

What kind of change does this pull request introduce? (check at least one)

[ ] Bugfix
[ ] Feature
[ ] Code style update
[x] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Describe your Pull Request:
This fixes #8

LGTM :+1:


Support use of slice for Program code

Now Program::code is ArrayVec type, which contains its own data.
I think almost all of use cases are to program "static" one, and it is not necessary to allocate memory every time.
So I suggest to add slice support.
Furthermore, I want pio_proc assembler macros to support slice as well.
The macros returns ProgramWithDefines<> type, which has dynamic type parameter, so it is not possible to use it as static variable.
I am able to work with this change, but I am not sure if it is good idea or not.
Thank you!

sorry, this issue is for pio-rs.closing


Fix jobs not being cleaned in redis backing store

Fixes a bug where redis keys with "oncue:jobs:<job_id>" never got removed from redis. This is the job of the clean up method in AbstractScheduler. This resulted in expired completed/failed jobs slowly built up in redis.

Great, thanks @mfoo


exit at startup if motion_dir is missing

otherwise will crash later when tries to inspect the directory.

Closes #1


cask: add #csv to version DSL

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

csv will replace before_colon and after_colon (https://github.com/Homebrew/homebrew-cask/issues/95207)

Example:

version
version.csv[0]
version.csv[1]
version.csv[2]

123,456,789
123
456
789

: is a special character, and (unless I’m misremembering) it has given us trouble in the past. It’s used in highly specific cases, and those can be handled by multiple ,.

Nice work @FnControlOption, really like this implementation.

Thanks again @FnControlOption!

Just a reminder: we need this in a brew release tag before using this in casks.


polish: tweak api error messages

This is what an api error currently looks like

We should use the text as the title of the error, and include the url which generated the error. Maybe the stack isn't necessary either.

This is a lot better now, thanks @petebacondarwin. closing.


Consider add container option, that solves some bootstrap issues

Hello,
The container option was introduced to solve some issues of tootip and popover (like style break in btn-group, popover hidden on modal, etc). So,  IMO, it also could be implemented here.
Reference:
https://github.com/twitter/bootstrap/pull/5768
I would be happy in submit a PR if you agree.
Thanks!

Has this feature been implemented yet?

@BrianRT see: http://angular-ui.github.io/bootstrap/#/tooltip - you can configure the $tooltipProvider to append to the body globally.

Use it like this
$uibTooltipProvider.options({ appendToBody: true });


New rolling window batch operation for tf.data.Dataset #15044

This is a new feature
For help pre-processing datasets, creates a transformation function that can be applied to a tf.data.Dataset Object to create a new Dataset by rolling a window across the initial Dataset to create the batches for the new Dataset.
*Fails if Dataset is too large to fit in memory (possible future work?)

Can one of the admins verify this patch?

pylint issues. will fix then re-submit

Thanks for your contribution and sorry for letting this PR stall. In the meantime, #16123 has been merged, which provides the same functionality with a more efficient implementation, so I'm going to close this one.


Bug in admin access in settings of services application

The services application has an option of admin access in settings. After entering the password and getting admin access to settings , if the Android device is rotated
It gets back to normal settings mode.
Steps to reproduce:
1 ) Enable rotation in your Android device .
2 ) open the services application .
3 ) click on the settings option from the menu in top right.
4 ) Click on "admin access to settings" option .
5 ) Enter the password
6 ) You would now see the additional settings which are available only to the admin. Rotate your device and you will loose the admin access .
Screen recording of the bug :
https://user-images.githubusercontent.com/45128519/111951698-06814100-8b0a-11eb-8dfd-1b346f25c306.mp4

@Shubhamr837 you are correct. This is a bug. Did you want to work on this or are you simply reporting it?

@wbrunette Thanks for the reply .
I would like to work on this issue.

@Shubhamr837 I have assigned the issue to you.


Support equality operators with lists

Currently the code [1,2] == [1,2] returns false. I can't find anything in the documentation as to why this would be. Equality on lists should really be supported.

Because as this, it does object instance comparison. Code is missing for the support.

I'll add that the culprit is wrenValuesEqual in wren_value.c:
https://github.com/munificent/wren/blob/master/src/vm/wren_value.c#L1275-L1313

I suppose it depends on the intended semantics, but the current behaviour doesn't bother me. Each list is a different object in the heap so I wouldn't consider them to be the same object, even if their contents is "equal".
I would expect the following to print true though.
var a = [1 ,2]
System.print(a == a)

To do as this issue suggests, equality operations would have to do deep inspection of the whole list contents (adding to the operational complexity). Would the same semantics extend to maps? What about deeply-nested lists?

I'm also not a fan of deep/expensive operations on syntax level.
As mentioned above, you also have to account for recursion, you can make a cycle trivially with lists and now == has undefined behaviour, or behaviour that is difficult to define with reasonable expectations.
There are functions though! We don't need to overload syntax for operations on values when functions are a unit of work.
List (or maybe even Sequence) can offer a function like equivalent or equals that does this, and allows more nuance and error handling. i.e list.equals(other).

Isn't == an overloadable operator? The equality of two lists could be added as a method to the List class.

All methods can be overloaded, even the critical ones (if there is any).
There is no real check in the compiler for that.

Currently the code [1,2] == [1,2] returns false. I can't find anything in the documentation as to why this would be. Equality on lists should really be supported.

Are there any other scripting languages where a simple equality test of lists does a deep comparison? I think it's really uncommon at best, due to problems mentioned by @underscorediscovery.
Of course we know it from C++, but values are not pointers there unless written so explicitly, so it's clear when you do a pointer comparison or a deep comparison.

I think most language does collection equality using the real equality
operator. The nuance is that here == is the real equality, while
same(_) is the simple test.

Quick aside: It looks like the terms for what we are discussing are "physical" and "structural" equality. Wren's current == operator checks physical equality, as does the Object.same(_,_) static method.
An operator for testing structural equality might be useful, but it shouldn't replace the existing semantics of ==.

I disagree with that, for me as == is a structural equality, it is
expected to be expensive and slow, and defaults to physical equality
which is dumb simple and fast.

I think most language does collection equality using the real equality operator.

It doesn't do this in Java, C#, Lua and JavaScript. Neither does it work like that in C++ or C if you're dealing with pointers (which is essentially what Wren object handles are).
I just found Python and Ruby do a deep comparison, but Python provides "is" for identify comparison and Ruby provides "equal?" for that. I think especially Ruby is pretty confusing here with their naming.
In any case I think it's not easy to say what "most languages" do, and by extension it's not easy to say what == is expected to do, since this would mostly depend on what the coder is familiar with.

It all depends on what you consider to be the source of equality. For me in java, .equals() seems to be for me a better source of equality than == since it can be overloaded.
If all is a question of having a physical and structural equality, for me === and == are the ideal candidates it is only a question to have them as operators. This relate to the fact that I'm a big fan of the <=> operator. That would make 3 operators of 3 symbols (===, !==, <=>).

I feel like there is already is operator for reference equality.


Unable to change weapon firing mode

When I start a new game and start the first mission my Pistol is stuck on Pistol Whip mode and will not change to normal fire no matter what I do.

Unable to reproduce here. Are you using a controller?

Hello, I was using Keyboard and Mouse with no controllers connected.


Sidebar fails to load on Safari

Added event.js to track tasks and microtasks fired by andrewmcwatters/route.js and andrewmcwatters/include.js.
Expected processing:
routechange
mutation
viewcontentloaded
includecontentrequested
includecontentloaded

In a turn of events, this is a bug with Safari.


Copyright of logo

The logo seems to be by a graffiti writer named ESTE from Los Angeles. If no grant given from him/her, I think basically it's not fair to use his piece as another one's logo.
http://smogcityla.com/home/este-interview

Wow. Correct. Thank you for a notion. I will remove it.


make demo video

probably the easiest way to show it for the hackathon
do we wanna do a discord or zoom screenshare and record a meetup with three of us introducing it??

related #40


Is it possible to use the request body within CELs?

Describe what are you trying to do:
We are looking for a way to conditionally trigger backend requests depending on the values of fields in the request body.

Is it possible to use the request body within CELs? Like so:
"extra_config": {
    "validation/cel": [
        {
            "check_expr": "req_body.Foo.Bar == 'baz'"
        }
    ]
}

Unfortunately we didn't find anything like req_body in the documentation.

Thanks for the reply, @alombarte
Schema validation will be useful in some of our use-cases, although it must be at the endpoint object; and may not be specified at the backend object.
It seems to us, in the end, that the routing logic that needs to peek at the body will have to live outside krakend.


tests refactor: move default parameter settings into concrete classes

The framework has been refactored as descriged below.
Now, all there is to do is to move the defaults from the tests/_config file into the individual estimator's get_testing_params.
PRs are appreciated - if you work on this, please post below which estimators you are helping with refactoring to avoid duplication.

We should refactor the default settings in _config.
Currently, _config has two things related to default settings:

default "inhabitants" of key scitypes, within and outside sktime
default parameter settings for each individual concrete estimator

I would go and locate these within the boundaries of their "natural concern":

default parameter settings as an inspectable attribute of the class it is a default for. This should support a single setting, or multiple settings. I would make a method get_testing_param_defaults or similar. Imports of components etc should happen inside this method, to avoid strong coupling of modules and circular imports.
default inhabitants of scitypes should move to the registry. I would suggest a method get_example(scitype : str), which implements an extensible dispatch mechanusm similar to #1097.

I think this would declutter the logic a lot, and make extending sktime much easier - since it reduces the "points of extension" by one. Defaeult parameters would no longer have to be entered in _config, but become part of the list of things to implement, in the extension template.

@fkiraly I want to work on this issue. From what I understood, instead of setting the parameters every time inside _config, one could use a function like get_testing_param_defaults to set the default parameters. Could you please guide me as to how I should approach this task as I am new to sktime?

Yes, very much agreed! You can have the issue, no one is working on this.
I'll try post some more details as a STEP today evening.

@fkiraly Thanks a lot! I have also sent you a dm in discord.

I created a STEP here, have a look:
https://github.com/sktime/enhancement-proposals/pull/14

closing this in favour of #1678 which has a list of estimators


Human rig configuration and Blend shape

It is difficult to use this as an agent character because avatars do not have a blend shape for blink.
In addition, this rig configuration does not match the humanoid rig.  Then, I cannot apply humanoid animations to avatars

hey, mixamo animations atleast for me work fine on the avatars. You can just change the animation type in the fbx window from generic to humanoid and it will initialize the avatar again to match the humanoid rig.

Hi, the avatar rigging fails for me :

Hi, the avatar rigging fails for me :

I faced the same issue! I'm planning to use the full catalog as possible self-avatars for an upcoming study. On import (and after setting useMixamoAnimations to false) though, the humanoid avatar ended up looking like this:

It took a while of messing around and my solution isn't super elegant, but you can find it here. You'll just need to grab the altered "FixRocketboxMaxImport" script, and the "boneUtilities" script, then remove the bits of the import script that aren't relevant to you, such as the FinalIK imports and:
if (assetPath.ToLower().Contains("rocketbox")) {
            if(g.GetComponent(typeof(AutoRigAvatar)) == null & usingAutoRig)
            {
                var ik = g.AddComponent<AutoRigAvatar>();
                if(usingFinalIK)
                {
                    ik.IKSetupChooser(AutoRigAvatar.ikSolver.FinalIK, g);
                } else {
                    ik.IKSetupChooser(AutoRigAvatar.ikSolver.UnityXR, g);
                }
            }

            if(g.GetComponent(typeof(AvatarManusHandSetup)) == null & usingManusGloves){
                g.AddComponent<AvatarManusHandSetup>();
            }
        }

At some point I will clean the script up and submit an official pull request.


Cleanup bug in createVolumeFromSnapshot() and CreateSnapshot()

Describe the bug

In createVolumeFromSnapshot(), if the unsetAllMetadata or copyEncryptionConfig or expand fails we need to remove the clone.
Same in CreateSnapshot() too

See:
https://github.com/ceph/ceph-csi/pull/3005#discussion_r867690813
https://github.com/ceph/ceph-csi/pull/3005#discussion_r867691871

@yati1998 PTAL

Closing this issue since the fix is merged.


[BUG]  bullseye lite : libcamera-vid : ERROR V4L2 : Unable to set controls:Remote I/O error

Hello,
I can't acquire video with 2 new cameras v3 on 2 different raspberry Pis but it works for camera v2 and raspivid (with associated legacy settings in raspi-config.). V4L2 i2c controls seems to be the culprit. Could you help me?
Here is my process.
After flashing, updating, upgrading bullseye 32 bits lite on 2 sd cards for:

1 Pi 4 B with v3 camera
Pi zero v2 with another pi v3 camera,

I detect cameras with libcamera-vid --list-cameras
Available cameras
0 : imx708_wide_noir [4608x2592] (/base/soc/i2c0mux/i2c@1/imx708@1a)
Modes: 'SRGGB10_CSI2P' : 1536x864 [120.13 fps - (768, 432)/3072x1728 crop]
2304x1296 [56.03 fps - (0, 0)/4608x2592 crop]
4608x2592 [14.35 fps - (0, 0)/4608x2592 crop]
But I cant acquire any video with libcamera-vid -o test.h264 -t 500 -n
Bug report
pi@dev0:~ $ libcamera-vid -o test.h264 -t 500 -n
[0:32:46.873435656] [6460]  INFO Camera camera_manager.cpp:297 libcamera v0.0.5+83-bde9b04f
[0:32:46.991776953] [6461]  INFO RPI vc4.cpp:437 Registered camera /base/soc/i2c0mux/i2c@1/imx708@1a to Unicam device /dev/media4 and ISP device /dev/media1
[0:32:46.991903711] [6461]  INFO RPI pipeline_base.cpp:1101 Using configuration file '/usr/share/libcamera/pipeline/rpi/vc4/rpi_apps.yaml'
[0:32:46.992950090] [6460]  INFO Camera camera.cpp:1033 configuring streams: (0) 640x480-YUV420
[0:32:46.993485899] [6461]  INFO RPI vc4.cpp:565 Sensor: /base/soc/i2c0mux/i2c@1/imx708@1a - Selected sensor format: 1536x864-SBGGR10_1X10 - Selected unicam format: 1536x864-pBAA
[0:32:46.994860182] [6461] ERROR V4L2 v4l2_device.cpp:353 'dw9807 10-000c': Unable to set controls: Remote I/O error
[0:32:47.155226516] [6461] ERROR V4L2 v4l2_device.cpp:353 'dw9807 10-000c': Unable to set controls: Remote I/O error
....
[0:32:47.654925441] [6461] ERROR V4L2 v4l2_device.cpp:353 'dw9807 10-000c': Unable to set controls: Remote I/O error
Halting: reached timeout of 500 milliseconds.

Hello,
after few analysis, in spite of long list of error messages, video is produced but it seems that autofocus control is disabled. Can it be linked to this remote I/O error?
Thanks for your support

This looks to be an issue with communicating with the module actuator over I2C.  I would normally say that the cable may need re-seating, but I2C for the sensor access seems to be working fine.  Is this a problem that has recently started occurring with the camera board?

Hello,
I would say that this problem appeared 2 to 3 weeks ago. Meanwhile, I add the same behavior with a new couple pi zéro v2 / camera module v3. I double Checked wiring. Can I collect some logs to go further into investigation ?
Many thanks for support.
Michael

So you are getting this error with multiple Camera v3 boards?  I would suggest starting from scratch again with a fresh Raspberry Pi OS sd card image to see if you still get the error.

If there are no further updates, I'll close this one down for now.

Closing now, please do reopen if you continue having issues with a fresh Raspberry Pi OS image.

Hello ,
sorry for dealy, i'm just back from holiday. A fresh bullseye installation on a Pi 4b followed by
sudo apt update
sudo apt full-upgrade

leads to the same issue. Videofile is recorded but always these v4l2 error messages
pi@sierra:~ $ libcamera-vid -o test.h264 -n
[0:21:44.909356211] [1292]  INFO Camera camera_manager.cpp:297 libcamera v0.0.5+83-bde9b04f
[0:21:45.049081044] [1293]  INFO RPI vc4.cpp:437 Registered camera /base/soc/i2c0mux/i2c@1/imx708@1a to Unicam device /dev/media4 and ISP device /dev/media0
[0:21:45.049163414] [1293]  INFO RPI pipeline_base.cpp:1101 Using configuration file '/usr/share/libcamera/pipeline/rpi/vc4/rpi_apps.yaml'
[0:21:45.050133794] [1292]  INFO Camera camera.cpp:1033 configuring streams: (0) 640x480-YUV420
[0:21:45.050779547] [1293]  INFO RPI vc4.cpp:565 Sensor: /base/soc/i2c0mux/i2c@1/imx708@1a - Selected sensor format: 1536x864-SBGGR10_1X10 - Selected unicam format: 1536x864-pBAA
[0:21:45.052291034] [1293] ERROR V4L2 v4l2_device.cpp:353 'dw9807 10-000c': Unable to set controls: Remote I/O error
[0:21:45.212678739] [1293] ERROR V4L2 v4l2_device.cpp:353 'dw9807 10-000c': Unable to set controls: Remote I/O error
[0:21:45.245857870] [1293] ERROR V4L2 v4l2_device.cpp:353 'dw9807 10-000c': Unable to set controls: Remote I/O error
[0:21:45.279398147] [1293] ERROR V4L2 v4l2_device.cpp:353 'dw9807 10-000c': Unable to set controls: Remote I/O error
[0:21:45.312571704] [1293] ERROR V4L2 v4l2_device.cpp:353 'dw9807 10-000c': Unable to set controls: Remote I/O error
[0:21:45.345834945] [1293] ERROR V4L2 v4l2_device.cpp:353 'dw9807 10-000c': Unable to set controls: Remote I/O error
......

@UmonDaisuke thanks for the update.  Can I ask when and where did you purchase this module from?  I presume it was working fine at some point in time?

@naushir  I bought original camera modules V3 at Digikey. Yes It has worked for a while. I unplugged and replugged the sensor (like I did for years with v2) for adding and extension ribbon and it was still working. Please notice that with or without this ribbon v4l2 messages are the sames for my 3 cameras v3 (classical, noir, wide noir).   This is realy annoying as autofocus is disabled and I can't set it manually.

@naushir , topics closed. wrong connection. sorry for time spent on this false issue.
Knd regards


Add documentation for Alluxio

Add new connector documentation for Alluxio Data Orchestrator.

We added this into the Starburst Presto documentation. Would like to put int the PrestoSQL documentation.

updated PR.

@mattsfuller not sure if the check failure is related to this Pull request. Any admins to help check?

Any admin to comment? thanks

Let’s merge #1594 first, then we don’t need the instructions about coping the JAR.

@mattsfuller Could you remove the section of copying JAR? Related PR was merged.

Updates to remove that section.

Alluxio isn’t a separate connector. We should instead add an Alluxio section to the Hive connector documentation. I can try reworking this in a new PR, unless @apc999 wants to try?

@electrum I created a separate PR #1928 to add Alluxio to the Hive connector doc. Feel free to work with me on the other PR

Replaced by https://github.com/prestosql/presto/pull/1928


Implement LinkedEditingRangeEndpoint for TagHelper opt-out

Summary of the changes

Adds a LinkedEditingRangeEndpoint to implement proper TagHelper opt-out behavior. Deletes the existing LinkedEditingRangeHandler since we can now implement all tag logic without calling into HTML.
The LSP side of this PR was merged earlier this week: https://devdiv.visualstudio.com/DevDiv/_git/VSLanguageServerClient/pullrequest/344266 However, for some reason upgrading the latest LSP package version (not included in this PR) doesn't seem to contain the changes, even though I verified the changes locally when implementing the PR. If anyone has any ideas on why this may be please let me know!

Fixes:
https://github.com/dotnet/aspnetcore/issues/33126 (Once both this PR & the LSP PR have been merged and adopted)

@NTaylorMullen once your O# PR goes in, I'll update this PR to remove the added classes.


Proportional scale?

Godot version: 3.0
Any chance we can get proportional lock for scaling? Meaning if you edit one dimension of the scale field, the other dimension updates to match it.

Closing in favor of https://github.com/godotengine/godot-proposals/issues/144, as feature proposals are now tracked in the Godot proposals repository.


FAILURE: Running flutter app fails with  Execution failed for task ':app:compileFlutterBuildDebug'.

Hi guys I am getting the following error when trying run my flutter application
Target debug_android_application failed: FileSystemException: Directory listing failed, path =
'D:\Github\Flutter_lib\pay_api_settings\example\windows\flutter\ephemeral\.plugin_symlinks\pos_link_api\example\windows\flutter\ephemeral\.plugin_symlinks\asmart_api\example\build\app\intermediates\compressed_assets\debug\out\assets
\flutter_assets\packages\getwidget\*' (OS Error: The system cannot find the path specified.
[   +3 ms]            , errno = 3)

I am not sure what is wrong, I have done a flutter upgrade, flutter clean pretty much everything I could possibly think of but still the issue persists. Running flutter run --verbose gives the following output
verbose_logs.txt
Any help would be appreciated

Hi @Leylan24
Please provide a completed and minimal reproducible code sample so that we may verify this. Also, please provide the output of flutter doctor -v as well.
Thank you!

flutter doctor -v returns
 flutter doctor -v
[√] Flutter (Channel stable, 3.0.5, on Microsoft Windows [Version 10.0.19044.1889], locale en-ZA)
    • Flutter version 3.0.5 at D:\Scotch\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f1875d570e (5 weeks ago), 2022-07-13 11:24:16 -0700
    • Engine revision e85ea0e79c
    • Dart version 2.17.6
    • DevTools version 2.12.2

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\Leylan\AppData\Local\Android\sdk
    • Platform android-31, build-tools 30.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Build Tools 2019 16.11.9)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools
    • Visual Studio Build Tools 2019 version 16.11.32106.194
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 2021.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)

[√] VS Code (version 1.67.2)
    • VS Code at C:\Users\Leylan\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.40.0

    • NEW9220 (mobile)  •<PHONE_NUMBER>ABCDEF • android-arm    • Android 5.1.1 (API 22)
    • Windows (desktop) • windows          • windows-x64    • Microsoft Windows [Version 10.0.19044.1889]
    • Chrome (web)      • chrome           • web-javascript • Google Chrome 104.0.5112.81
    • Edge (web)        • edge             • web-javascript • Microsoft Edge 102.0.1245.33

[!] HTTP Host Availability
    X HTTP host "https://cocoapods.org/" is not reachable. Reason: An error occurred while checking the HTTP host: Failed host lookup: 'cocoapods.org'
    X HTTP host "https://maven.google.com/" is not reachable. Reason: An error occurred while checking the HTTP host: Failed host lookup: 'maven.google.com'
    X HTTP host "https://pub.dev/" is not reachable. Reason: An error occurred while checking the HTTP host: Failed host lookup: 'pub.dev'
    X HTTP host "https://cloud.google.com/" is not reachable. Reason: An error occurred while checking the HTTP host: Failed host lookup: 'cloud.google.com'

! Doctor found issues in 1 category.
PS D:\Github\Flutter_lib\pay_api_settings\example> flutter doctor -v
[√] Flutter (Channel stable, 3.0.5, on Microsoft Windows [Version 10.0.19044.1889], locale en-ZA)
    • Flutter version 3.0.5 at D:\Scotch\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f1875d570e (5 weeks ago), 2022-07-13 11:24:16 -0700
    • Engine revision e85ea0e79c
    • Dart version 2.17.6
    • DevTools version 2.12.2

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\Leylan\AppData\Local\Android\sdk
    • Platform android-31, build-tools 30.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Build Tools 2019 16.11.9)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools
    • Visual Studio Build Tools 2019 version 16.11.32106.194
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 2021.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)

[√] VS Code (version 1.67.2)
    • VS Code at C:\Users\Leylan\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.40.0

[√] Connected device (4 available)
    • NEW9220 (mobile)  •<PHONE_NUMBER>ABCDEF • android-arm    • Android 5.1.1 (API 22)
    • Windows (desktop) • windows          • windows-x64    • Microsoft Windows [Version 10.0.19044.1889]
    • Chrome (web)      • chrome           • web-javascript • Google Chrome 104.0.5112.81
    • Edge (web)        • edge             • web-javascript • Microsoft Edge 102.0.1245.33

[√] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Hello @Leylan24. I do not see a minimal, reproducible example attached. Also, you logs are failing on getwidget. Could you produce a sample without any 3rd party libraries?


fby4: wf: Support to read ADC sensor

Description:
- Add ADC PDR table (numeric sensor table and aux name table).
- Set MCTP message type. BMC can read ADC sensors from BIC.

Motivation:
Support BIC monitors parts of ADC sensors.

Test plan:
1. Check sensors' cache which return to BMC are correct: Pass
2. BMC read ADC sensor: Pass

Test log:
1. Check sensors' cache which return to BMC are correct:
	[00:00:27.054,000] <dbg> pldm_sensor.pldm_polling_sensor_reading: sensor0x15, value0x11e0003, status 0x0
	[00:00:27.054,000] <dbg> pldm_sensor.pldm_polling_sensor_reading: sensor0x16, value0x11e0003, status 0x0
	[00:00:27.054,000] <dbg> pldm_sensor.pldm_polling_sensor_reading: sensor0x17, value0xd20001, status 0x0
	[00:00:27.054,000] <dbg> pldm_sensor.pldm_polling_sensor_reading: sensor0x18, value0xd20001, status 0x0
	[00:00:27.054,000] <dbg> pldm_sensor.pldm_polling_sensor_reading: sensor0x19, value0x32d0001, status 0x0
	[00:00:27.054,000] <dbg> pldm_sensor.pldm_polling_sensor_reading: sensor0x1a, value0x2ef0000, status 0x0
	[00:00:27.054,000] <dbg> pldm_sensor.pldm_polling_sensor_reading: sensor0x1b, value0x2240002, status 0x0
	[00:00:27.054,000] <dbg> pldm_sensor.pldm_polling_sensor_reading: sensor0x1c, value0x2160002, status 0x0
	[00:00:27.054,000] <dbg> pldm_sensor.pldm_polling_sensor_reading: sensor0x1d, value0x25b0000, status 0x0
	[00:00:27.055,000] <dbg> pldm_sensor.pldm_polling_sensor_reading: sensor0x1e, value0x2560000, status 0x0
2. BMC read ADC sensor
	2-1. ADC sensor name
		root@bmc:~# busctl tree xyz.openbmc_project.PLDM
		`- /xyz
		  `- /xyz/openbmc_project
			|- /xyz/openbmc_project/inventory
			| `- /xyz/openbmc_project/inventory/Item
			|   `- /xyz/openbmc_project/inventory/Item/Board
			|     |- /xyz/openbmc_project/inventory/Item/Board/PLDM_Device_1
			|     `- /xyz/openbmc_project/inventory/Item/Board/PLDM_Device_2
			|- /xyz/openbmc_project/pldm
			`- /xyz/openbmc_project/sensors
			  `- /xyz/openbmc_project/sensors/voltage
				|- /xyz/openbmc_project/sensors/voltage/WF_ADC_P0V75_ASIC1_VOLT_V_26_2
				|- /xyz/openbmc_project/sensors/voltage/WF_ADC_P1V2_ASIC1_VOLT_V_24_2
				|- /xyz/openbmc_project/sensors/voltage/WF_ADC_P1V2_STBY_VOLT_V_23_2
				|- /xyz/openbmc_project/sensors/voltage/WF_ADC_P1V8_ASIC1_VOLT_V_25_2
				|- /xyz/openbmc_project/sensors/voltage/WF_ADC_P3V3_E1S_0_VOLT_V_22_2
				|- /xyz/openbmc_project/sensors/voltage/WF_ADC_P3V3_STBY_VOLT_V_21_2
				|- /xyz/openbmc_project/sensors/voltage/WF_ADC_PVPP_AB_ASIC1_VOLT_V_27_2
				|- /xyz/openbmc_project/sensors/voltage/WF_ADC_PVPP_CD_ASIC1_VOLT_V_28_2
				|- /xyz/openbmc_project/sensors/voltage/WF_ADC_PVTT_AB_ASIC1_VOLT_V_29_2
				`- /xyz/openbmc_project/sensors/voltage/WF_ADC_PVTT_CD_ASIC1_VOLT_V_30_2
	2-2.   Can you resolve?
Also, if you give us (Meta BMC team) write permissions to Wiwynn/OpenBIC we can likely use the Github tools to fix some of these trivial merge conflicts on our own.  That's what I often do with the BMC merge conflicts.

Force update to rebase main and fix the conflicts.


test-unit: fix TESTFLAGS doc

Using -run produce the following error:
+ go test -run ^TestImageGetCached -test.timeout=30m github.com/docker/docker/api
flag provided but not defined: -run
Usage of /go/src/github.com/docker/docker/bundles/1.5.0-dev/test-unit/precompiled/./api.test:
...
  -test.run="": regular expression to select tests and examples to run

LGTM :heart: :heart:

LGTM


boards: arm: nucleo_wb55rg: fails to build basic samples

Describe the bug
Building a basic sample, such as samples/basic/blinky or samples/hello_world, for the nucleo_wb55rg board fails
To Reproduce
Steps to reproduce the behavior:

west build -b nucleo_wb55rg samples/basic/blinky
See error

Expected behavior
Successful build
Impact
I expect no zephyr builds will succeed targeting nucleo_wb55rg
Logs and console output
$ west build -b nucleo_wb55rg samples/basic/blinky
-- west build: making build dir /Users/erik/zephyrproject/zephyr/build pristine
-- west build: generating a build system
Including boilerplate (Zephyr base): /Users/erik/zephyrproject/zephyr/cmake/app/boilerplate.cmake
-- Application: /Users/erik/zephyrproject/zephyr/samples/basic/blinky
-- Zephyr version: 2.4.99 (/Users/erik/zephyrproject/zephyr)
-- Found Python3: /usr/local/opt/python/libexec/bin/python (found suitable exact version "3.8.5") found components: Interpreter
-- Found west (found suitable version "0.7.3", minimum required is "0.7.1")
-- Board: nucleo_wb55rg
-- Cache files will be written to: /Users/erik/Library/Caches/zephyr
-- Found dtc: /usr/local/bin/dtc (found suitable version "1.6.0", minimum required is "1.4.6")
-- Found toolchain: gnuarmemb (/usr/local/gcc-arm-none-eabi-9-2019-q4-major)
-- Found BOARD.dts: /Users/erik/zephyrproject/zephyr/boards/arm/nucleo_wb55rg/nucleo_wb55rg.dts
nucleo_wb55rg.dts.pre.tmp:219.8-225.6: ERROR (phandle_references): /soc/timers@40000000/pwm: Reference to non-existent node or label "tim2_ch1_pa0"

  also defined at nucleo_wb55rg.dts.pre.tmp:849.12-852.4
ERROR: Input tree has errors, aborting (use -f to force output)
CMake Error at /Users/erik/zephyrproject/zephyr/cmake/dts.cmake:206 (message):
  command failed with return code: 2
Call Stack (most recent call first):
  /Users/erik/zephyrproject/zephyr/cmake/app/boilerplate.cmake:589 (include)
  /Users/erik/zephyrproject/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:24 (include)
  /Users/erik/zephyrproject/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:35 (include_boilerplate)
  CMakeLists.txt:4 (find_package)

-- Configuring incomplete, errors occurred!
FATAL ERROR: command exited with status 1: /usr/local/bin/cmake<EMAIL_ADDRESS>-B/Users/erik/zephyrproject/zephyr/build -S/Users/erik/zephyrproject/zephyr/samples/basic/blinky -GNinja -DBOARD=nucleo_wb55rg

Environment (please complete the following information):

OS: MacOS Catalina 10.15.7
Toolchain: gnuarmemb (gcc-arm-none-eabi-9-2019-q4-major)
Zephyr version: 2.4.99, commit 2ce570b03f97d5947e42fff77fe9437979c01c23

Additional context
The failure points to an undefined pin for the Timer2 PWM function. There is a #include <st/wb/stm32wb55rgvx-pinctrl.dtsi> statement in nucleo_wb55rg.dts, but that file is not in the zephyr tree as best I can tell. I would expect the required pin definition is in that file, or at least should be.

Needed a west update


Very first example in the docs is not working DSSL2

The very first DSSL2 code example in the docs (root insertion in a BST) refers to a number of undefined functions (e.g., empty?, new_node, fix_size).
So it's not actually a working example that someone could just copy and run.
That's not great for the first example someone sees...
Especially confusing is the use of empty?, which looks like a function that could plausibly be provided by the language. I just had a student assume (possibly based on that example) that DSSL2 provided an empty? function, which it does not.

Resolved by 6fa4a5590fdf80806943d2034f4655e3b363d43a.


✨ Navigator Toolbar Bottom Style Optimization

Description
The NavigatorToolBarBottom view can be clearer.
Alternatives Considered
No response
Additional Context
No response
Screenshots
No response

Closed with #1471.


Adding Uniprot, X-linking to reaction DBs for enzymes

I would be nice to add UniProt as a source, especially the following items:

protein sequence

potentially isoforms/isoform annotations

function
activity regulation
catalytic activity (for enzymes).

For enzymes, it would be very useful to have the catalytic activity expressed formally in addition (SMIRKS) to link the bio-moleuclar knowledge description to formal language. A source for this could be the Rhea DB (already referenced by UniProt for reactions), whose data is available for download and easily parseable.
I'm drafting a proof of concept that will be posted here (or as a PR if people find it useful) soon.

Update: hacked together a script to cross-check data from Rhea downloadable files which covers around 90% of the chemical compounds. The ones not covered then to be fragments of peptides or monomers (of polymers), etc. See: https://gist.github.com/hypnopump/bef3a2e34e810a529f159de015074926

Update:
hacked together a scrapper with urllib and bs4 which seems to cover the remaining points. at this point i think it might be worth it to do everything with the scrapper for consistency...
dont want to have 3 different branches in the parsing workflow as whether the ids are there or not in the downloadable master files.... Example: (1->3)-alpha-D-glucosyl-[(1->6)-alpha-D-glucosyl](n) from https://www.rhea-db.org/rhea/57036 does not have a matching chebi ID in the RDF file here but it has a ChEBI ID in the webpage.
Will update the gist with a better version relying on web parsing soon

Managed to create the script and parse the whole DB:
parsed_rhea.json.zip
chemnlp_rhea_x_uniprot_parsing_share_ipynb.txt


New ACP hashes are not reflected in constants.

I'm submitting a ...
[x] bug report
[ ] feature request
[ ] question about the decisions made in the repository
[ ] question about how to use this project
Summary
There was an update to ACP and it was redeployed. The new hashes are not reflected in the PW-Core constants.
The new constants can be found here.
The blog post about the release can be found here.

Fixed.


create_tflm_tree fails

Hello.
I am trying to make a project using TFLM, using the tensorflow/lite/micro/tools/project_generation/create_tflm_tree.py script, but I can't get it to work. I am new to TFLM, so it might be just that I am not reading the correct documentation. Please stop reading at the first error I make :)
What I tried was to follow the instructions in tensorflow/lite/micro/docs/new_platform_support.md to create the sources for libtflm.a
I took a clean clone of TFLM, and then run the script as instructed in the documentation:
$ git clone https://github.com/tensorflow/tflite-micro.git
$ cd tflite-micro
$ git submodule update --init --recursive
$ mkdir ../tflm_project
$ python3 tensorflow/lite/micro/tools/project_generation/create_tflm_tree.py -e hello_world ../tflm_project/

This fails with
[...]
FileNotFoundError: [Errno 2] No such file or directory: 'tensorflow/lite/micro/tools/make/downloads/flatbuffers/include/flatbuffers/code_generator.h'

There does exist a code_generators.h in that directory though (difference is the trailing 's' in the filename).
Reading other documentation, I tried to build TFLM (in source tree) - maybe that is a pre-requisit since it nudges me a bit forward?:
$ make -f tensorflow/lite/micro/tools/make/Makefile
tensorflow/lite/micro/tools/make/downloads/flatbuffers already exists, skipping the download.
[...]
./tensorflow/lite/schema/schema_generated.h:12:46: error: static assertion failed: Non-compatible flatbuffers version included
   12 |               FLATBUFFERS_VERSION_MINOR == 5 &&

Seems like the build expects Flatbuffers 2.5, but what was downloaded looks like 2.0.6.
Am I doing something completely wrong, or would it make sense to try to debug my steps further. I'm happy to try to fix this, but I would like to know I am on the right track at least.
thank you in advance,
kalle

$ git submodule update --init --recursive
FYI, TFLM does not use submodules, so this is not needed.

Seems like the build expects Flatbuffers 2.5, but what was downloaded looks like 2.0.6.

We actually expect v23.5.26, which is the version we download as part of the make build (which will be invoked during create_tflm_tree.py):
https://github.com/tensorflow/tflite-micro/blob/main/tensorflow/lite/micro/tools/make/flatbuffers_download.sh#L57
I think you're generally on the right track, and I'm not sure how you're winding up with a different flatbuffers version. The create_tflm_tree.py is tested as part of this script. You might want to take a look and see if there's something you're doing differently.


Clarify tooltip examples

Remove examples of using tooltip on buttons (as its against guidelines 🙈)
Also add delay on open, to fix feature request #1154

Why are we even allowing tooltips on disabled buttons when guidelines clearly say to not use tooltips on buttons with text 😆  Is it only for ghost icon buttons?


Doesn't work properly with Don't Keep Activities mode

Steps to reproduce

Set Don't keep activities flag
Open app -> You will see email dialog
Fold the app
Unfold
Tap on the dialog with any email

Result
In the form you will see(label with email field), that you are still signOut.
Expected result
You will be signedIn(correct email is shown).
Addition
If after this steps you will fold/unfold application one more time you will be signedIn.
As expected.
I investigated a little bit, and looks like we are not receiving onActivityResult after first fold/unfold, but receive after second, which is super strange.

I am closing this issue/PR, as it has been migrated to the new repo linked above in the comments. Thank you!


Add BasePath Support for #81

https://github.com/maxdome/swagger-combine/issues/81

@fabsrc May want to look into?

Thanks for your PR @dawinter
The functionality makes sense, however this seems like a breaking change to me, because it changes the default logic which might break existing services that are using this module.
Could you maybe add an option to activate this functionality (similar to existing options like includeParameters)?
Also tests would be great.

Thanks for the first review. First I thought it must be a bug. But you are right the testcase shows that the error behavoir was expected. I added a parameter and a test case.
Please review again. Feel free to change the parameter name or the level of the parameter.

Looks good to me. 🙂
Could you please also add some documentation for this feature?

documentation added ad base path option moved to the paths section to respect the structure of options.


OS#17676093: (ARM) ensure indir hoisting legalization is postRegAlloc aware

using InsertAdd in the lowerer calls Legalize with the default value postRegAlloc (false). For HoistIndirOffsetAsAdd and HoistIndirIndexOpndAsAdd, this was causing newly inserted LDIMMs to not be legalized when inserted after regAlloc.

@dotnet-bot test all


Send Message without Event

Hi mullwar
Many thanks for your awesome API!
I'm trying to use your API to send simple notifications without an event and I'm using following code:
bot.sendMessage(<user-id>, "message");
But I get following error:
(node:5735) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): [object Object]
I've created the bot object as following:
const TeleBot = require('telebot'); const bot = new TeleBot({     token: '<token>, // Required. Telegram Bot API token.     webhook: { // Optional. Use webhook instead of polling.         key: './cert/key.pem', // Optional. Private key for server.         cert: './cert/cert.pem', // Optional. Public key.         url: 'https://<IP_ADDRESS>', // HTTPS url to send updates to.         host: '<IP_ADDRESS>', // Webhook server host.         port: 88 // Server port.     } });
I'm listening via an express server.
Could you help me out?
Thank you very much!!

Hi,
Hm, this should work fine. Try this code:
const TeleBot = require('telebot');

const TOKEN = 'TELEGRAM_BOT_TOKEN';
const USER = 000000;

const bot = new TeleBot(TOKEN);

bot.sendMessage(USER, "Hello!");

To get idea whats going on, let's print server response to console log:
bot.sendMessage(USER, "Testing!").then((response) => {
    console.log('Ok:', resp);
}).catch((error) => {
    console.log('Error:', error);
});

Hi mullwar
Thanks for your fast response, I actually got it working with your code when the full error showed up!
Fix: I had to first start the bot in Telegram itself...
Thank you!

Nice! If you have any questions, don't hesitate to ask. Also, you can join to our Telegram community group: https://goo.gl/gXvm12

Hi,
Hm, this should work fine. Try this code:
const TeleBot = require('telebot');

const TOKEN = 'TELEGRAM_BOT_TOKEN';
const USER = 000000;

const bot = new TeleBot(TOKEN);

bot.sendMessage(USER, "Hello!");

To get idea whats going on, let's print server response to console log:
bot.sendMessage(USER, "Testing!").then((response) => {
    console.log('Ok:', response);
}).catch((error) => {
    console.log('Error:', error);
});

it worked for me. thank you


Doesn't render my page

Hello,
I try to integrate rendertron into our environment. But it returns only a blank page:
https://render-tron.appspot.com/render/https://trusted.de/?wc-inject-shadydom=true
Is the services maybe timing out?
Best Paul!

Tested it on my own instance of rendertron. Got a blank page as well.
It doesn't seem like a timeout.
I got the rendering result in less than 10 seconds. No cache was involved.

I have a similar issue in an Angular project.
Only content on the index.html file is being rendered.

Any updates here? I'm also experiencing the exact same thing.
When I try to use Facebook's Scrapper and check what their scrapper sees and it's blank. :/

Rendertron, as of today, is using Chromium 71. Support for Custom Elements v1 and Shadow DOM v1 first shipped in Chromium 76.
I'll take this issue as an opportunity to update the puppeteer version and thus the Chromium version.

Okay, red herring. As Shadow DOM content is basically inaccessible to Rendertron, it needs to force a "Shady DOM" which isn't helping if there are no polyfills being loaded.
Unfortunately we don't have a better answer to this than: "Load the polyfill for shadow DOM" :/


Semester dropdown in review dialog should be sorted from newest to oldest

Just a small UI tweak: most people writing reviews will be reviewing a class that they are either taking now or took last term, so it would make sense to show the most recent terms at the top in the 'semester' select dropdown (they are currently sorted from oldest to newest).

Sort order is most recent to least now.


IntelliSense randomly stops working in Python notebooks with Keras

Type: Bug
import tensorflow as tf
keras = tf.keras

Use e.g. keras.Sequential. Intellisense works fine.
After a few minutes, random code in the same cell as Keras code gets highlighted as "not defined".
Autocomplete suggestions in the entire notebook are stuck with "Loading".
Restarting VS Code fixes the issue only for a few minutes again.

VS Code version: Code 1.81.0 (6445d93c81ebe42c4cbd7a60712e0b17d9463e97, 2023-08-02T12:37:13.485Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Extensions (17)

Extension
Author (truncated)
Version

vscode-typora
cwe
3.1.6

gitlens
eam
14.2.0

code-runner
for
0.12.0

gc-excelviewer
Gra
4.2.57

python
ms-
2023.14.0

vscode-pylance
ms-
2023.8.10

jupyter
ms-
2023.7.1002162226

jupyter-keymap
ms-
1.1.2

jupyter-renderers
ms-
1.0.17

vscode-jupyter-cell-tags
ms-
0.1.8

vscode-jupyter-slideshow
ms-
0.1.5

cmake-tools
ms-
1.14.34

cpptools
ms-
1.16.3

cpptools-extension-pack
ms-
1.3.0

pdf
tom
1.2.2

cmake
twx
0.0.17

open-in-external-app
YuT
0.9.12

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
vstes263:30335439
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
pythonvs932:30410667
vsclangdc:30486549
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
vscccc:30803845
3biah626:30602489
f6dab269:30613381
2i9eh265:30646982
showlangstatbar:30737416
vsctsb:30748421
a2ce3375:30757347
pythonfmttext:30731395
pythoncmv:30756943
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
gsofa:30804715
pythonnosmt12:30797651
pythonidxptcf:30805731
pythonnoceb:30805159
e537b577:30795824
dsvsc013:30795093
dsvsc014:30804076

This could be due to various factors, such as a conflict with extensions, memory usage, or a bug in the IDE. Here are some steps you can try to resolve or troubleshoot the problem:
Make sure you're using the latest version of Visual Studio Code and that your extensions are up to date. Sometimes, issues like this can be resolved by simply updating the software. Disable other extensions one by one and see if the issue persists. It's possible that another extension might be conflicting with IntelliSense in your Python notebooks.
In some cases, memory limitations can cause IntelliSense to stop working correctly. You can try increasing the memory limits for Jupyter notebooks in your VS Code settings. Add the following lines to your settings.json file:
"notebook.jupyter.options": {
"notebook_memory_limit": 4096
}
You can adjust the value (in megabytes) according to your system's available memory.
Restart the Jupyter Kernel

I've tried to disable all extensions, except Jupyter, problem persists. Latest version is installed.
Not sure where to add the "notebook.jupyter.options". VSCode grays it out in user/workspace settings.json.
Where are these settings documented in the first place?

It's possible that this behavior was caused by #4733 which is fixed in our latest prerelease build, 2023.8.41
Could you please all to 2023.8.41 and see if your issues are resolved?

@simnba, when you see this issue, if you add/delete/reorder a cell, do you see Pylance crash with an error similar to this?
2023-08-26 09:07:01.700 [info] Error: Debug Failure. False expression: Chained file path undefined doesn't match cellFilePaths c:\temp\temp\4685repro_3\test.ipynb:pylance-notebook-cell:W3sZmlsZQ==.py
    at _0x35bbe7 (c:\Users\erikd\.vscode-insiders\extensions\ms-python.vscode-pylance-2023.8.41\dist\server.bundle.js:1:1025282)
    at c:\Users\erikd\.vscode-insiders\extensions\ms-python.vscode-pylance-2023.8.41\dist\server.bundle.js:1:1032550
    at _0x114e49.<computed> (c:\Users\erikd\.vscode-insiders\extensions\ms-python.vscode-pylance-2023.8.41\dist\server.bundle.js:1:1032582)
    at _0x4600bc._onDidChangeNotebookDocumentAsync (c:\Users\erikd\.vscode-insiders\extensions\ms-python.vscode-pylance-2023.8.41\dist\server.bundle.js:1:1010710)

If you are seeing the error that I mentioned above, please install our latest prerelease build (2023.8.51) and see if your problem is fixed there.

@debonte I can confirm that a similar issue (#4800) is fixed for me with the pre-release version v2023.8.51.


plugin.google.maps.event.MAP_CLOSE does not fire

Also tried with closeDialog(); The callback does not fire on iOS (did not test Android)

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/10075649-plugin-google-maps-event-map_close-does-not-fire?utm_campaign=plugin&utm_content=tracker%2F637500&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F637500&utm_medium=issues&utm_source=github).

Have you check the native code?

No, just tried in JS and never received my test "alert"

This issue has been fixed in the test branch. Check it out.

:+1:


unable to download the images.tar.gz of Vision-Action Tuning Dataset

Thank you very much for your work, and your open source! I tried to download the Vision-Action Tuning Dataset, but it seems that images.tar.gz can't be downloaded, the google drive shows the file is in your recycle bin, really hope to get your help, thanks!

Have fixed it!


fix: asymmetric padding for sections and zones

Description
Added asymmetric paddings for sections and zones.
https://github.com/appsmithorg/appsmith/assets/11555074/1959c6f2-5e26-4fdd-98e3-ea1bb5e09dae
Fixes #32209
Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!TIP]
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8987291148
Commit: 97b587289d45f9a1b50193e04121333a621a69fa
Cypress dashboard url: Click here!

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[x] No

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true

@KelvinOm everything lgtm
one feedback:
section background on, zone background off causes a slight shift to the bottom
https://www.loom.com/share/24f684dacd624d8faee909b005fea02f

@KelvinOm everything lgtm
one feedback: section background on, zone background off causes a slight shift to the bottom https://www.loom.com/share/24f684dacd624d8faee909b005fea02f

This should already be fixed. Check the latest DP please.

@KelvinOm trying it out on the fresh DP, the shift is less chunky but still noticeable

/build-deploy-preview skip-tests=true

@KelvinOm trying it out on the fresh DP, the shift is less chunky but still noticeable

Should be fixed.


Terminal does not load when working directory contains CJK characters

I'm on Windows 10 x64.
When a new terminal is created in the file's directory and the file's full path includes some CJK characters, the terminal won't load. winpty-agent shows up in task manager, but all I get is a blank blinking cursor in the terminal pane, no prompt.
This issue seems to come up regardless if I'm using CMD or PS. I've also tried legacy terminal in windows.
Right now my workaround is to set the starting wd to Home (C:/Users/username) which is all Latin, and then manually navigate to my project folder. As long as I get the terminal to load, it has no problem displaying CJK characters and I can navigate to folders containing them as well (using the insert characters function).
I should point out I can't rename my folders because one of them is my "Documents" folder which was named by Windows... and renaming that breaks pretty much every other program's config I have.

@yluyao I definitely do not expect you to rename your directories to use Terminal-Plus. I will have to look into this and perform some tests. Please keep in mind that this might take a while considering I have to do the following:

Test and see why winpty does not work with CJK characters.
Inform the winpty developer to implement a fix.
Update my repositories.


fwts: 20.11.00 -> 21.07.00

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/fwts/versions.
meta.description for fwts is: "Firmware Test Suite"
meta.homepage for fwts is: "https://wiki.ubuntu.com/FirmwareTestSuite"
meta.changelog for fwts is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/a63vbzixjsj07y40f0v7z9dywimhhyb1-fwts-21.07.00/bin/fwts passed the binary check.

/nix/store/a63vbzixjsj07y40f0v7z9dywimhhyb1-fwts-21.07.00/bin/kernelscan passed the binary check.

2 of 2 passed binary check by having a zero exit code.

2 of 2 passed binary check by having the new version present in output.

found 21.07.00 with grep in /nix/store/a63vbzixjsj07y40f0v7z9dywimhhyb1-fwts-21.07.00

found 21.07.00 in filename of file in /nix/store/a63vbzixjsj07y40f0v7z9dywimhhyb1-fwts-21.07.00

directory tree listing: https://gist.github.com/3162738fc5728ce56dd4b082b2db350a

du listing: https://gist.github.com/4d40244db5c4695b614ffed52c9b0afe

Rebuild report (if merged into master) (click to expand)

63 total rebuild path(s)

21 package rebuild(s)

21 x86_64-linux rebuild(s)
21 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
21 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
fwts
linuxPackages-libre.fwts-efi-runtime
linuxPackages.fwts-efi-runtime
linuxPackages_4_14.fwts-efi-runtime
linuxPackages_4_19.fwts-efi-runtime
linuxPackages_4_4.fwts-efi-runtime
linuxPackages_4_9.fwts-efi-runtime
linuxPackages_5_10.fwts-efi-runtime
linuxPackages_5_12.fwts-efi-runtime
linuxPackages_5_13.fwts-efi-runtime
linuxPackages_5_4.fwts-efi-runtime
linuxPackages_hardened.fwts-efi-runtime
linuxPackages_hardkernel_4_14.fwts-efi-runtime
linuxPackages_hardkernel_latest.fwts-efi-runtime
linuxPackages_latest-libre.fwts-efi-runtime
linuxPackages_latest.fwts-efi-runtime
linuxPackages_latest_hardened.fwts-efi-runtime
linuxPackages_lqx.fwts-efi-runtime
linuxPackages_testing_bcachefs.fwts-efi-runtime
linuxPackages_xanmod.fwts-efi-runtime
linuxPackages_zen.fwts-efi-runtime

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/a63vbzixjsj07y40f0v7z9dywimhhyb1-fwts-21.07.00 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A fwts https://github.com/r-ryantm/nixpkgs/archive/edb14bad6a6fb0c6457226d246a0c42a1ed2e9a7.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/a63vbzixjsj07y40f0v7z9dywimhhyb1-fwts-21.07.00
ls -la /nix/store/a63vbzixjsj07y40f0v7z9dywimhhyb1-fwts-21.07.00/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages marked as broken and skipped:

linuxPackages-libre.fwts-efi-runtime
linuxPackages_latest-libre.fwts-efi-runtime

15 packages built:

fwts
linuxPackages.fwts-efi-runtime
linuxPackages_4_14.fwts-efi-runtime
linuxPackages_4_19.fwts-efi-runtime
linuxPackages_4_4.fwts-efi-runtime
linuxPackages_4_9.fwts-efi-runtime
linuxPackages_5_12.fwts-efi-runtime
linuxPackages_5_13.fwts-efi-runtime
linuxPackages_5_4.fwts-efi-runtime
linuxPackages_hardened.fwts-efi-runtime
linuxPackages_latest_hardened.fwts-efi-runtime
linuxPackages_lqx.fwts-efi-runtime
linuxPackages_testing_bcachefs.fwts-efi-runtime
linuxPackages_xanmod.fwts-efi-runtime
linuxPackages_zen.fwts-efi-runtime

Maintainer pings
cc @tadfisher for testing.

Result of nixpkgs-review pr 133321 run on x86_64-linux 1

4 packages marked as broken and skipped:

linuxPackages-libre.fwts-efi-runtime
linuxPackages_hardkernel_4_14.fwts-efi-runtime
linuxPackages_hardkernel_latest.fwts-efi-runtime
linuxPackages_latest-libre.fwts-efi-runtime

15 packages built:

fwts
linuxPackages.fwts-efi-runtime (linuxPackages_5_10.fwts-efi-runtime)
linuxPackages_4_14.fwts-efi-runtime
linuxPackages_4_19.fwts-efi-runtime
linuxPackages_4_4.fwts-efi-runtime
linuxPackages_4_9.fwts-efi-runtime
linuxPackages_5_12.fwts-efi-runtime
linuxPackages_5_13.fwts-efi-runtime (linuxPackages_latest.fwts-efi-runtime)
linuxPackages_5_4.fwts-efi-runtime
linuxPackages_hardened.fwts-efi-runtime
linuxPackages_latest_hardened.fwts-efi-runtime
linuxPackages_lqx.fwts-efi-runtime
linuxPackages_testing_bcachefs.fwts-efi-runtime
linuxPackages_xanmod.fwts-efi-runtime
linuxPackages_zen.fwts-efi-runtime


Depend on local copy of la-arena instead of crates.io’s

This addresses this comment. #7275 and #7276 should start compiling if this is merged.

bors r+

bors r+


Add two payments package for django-oscar

Isn't easy maintain this packages without community help.
In some countries isn't easy use paypal for payment, instead, is easy pay in moment, i mean, cash on delivery. And, for example in my country, PayU offers multiply payment methods: user credit card, debit card, cash on delivery, etc.
I think that many people find useful use this packages, and i'll like the Oscar's Official Team help us with this packages.

Current coverage is 83.31% (diff: 100%)

Merging #2097 into master will not change coverage

@@             master      #2097   diff @@
==========================================
  Files           302        302
  Lines         15046      15046
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits          12536      12536
  Misses         2510       2510
  Partials          0          0

Powered by Codecov. Last update 62014cf...3f156a0

hi @SalahAdDin, sorry for not merging earlier. Are you able to fix the merging conflicts?

PR needs to be rebased against upstream master due to the conflicts.

Ok, i will do it this night.

PR still has conflicts. Feel free to rebase and submit new PR. Thanks.

@saha0 Which conflicts?

An update to cash on delivery is much appreciated @SalahAdDin

An update to cash on delivery is much appreciated @SalahAdDin

Sorry, I don't work with  Django since 2018.