Update README.md

urn:btih:d2474e86c95b19b8bcfdb92bc12c9d44667cfa36 as infoHash will reduce magnet:?xt=urn:btih:urn:btih:d2474e86c95b19b8bcfdb92bc12c9d44667cfa36

good catch, thanks!


License?

Same question here... What would the license?

MIT License, enjoy!

@anknown Thanks for the quick reply!


auc or roc curve?

Sorry to bother you again? How is the ROC curve drawn? Is the credibility of the vCDR value?

@ I know it...


Azure storage doesn't work in Ubuntu 14.04.2

I was able to make backups to S3, but not to Azure, got an error:

DETAIL: The subcommand is "backup-push".
STRUCTURED: time=2015-09-21T20:44:52.163131-00 pid=50907
wal_e.main   CRITICAL MSG: An unprocessed exception has avoided all error handling
DETAIL: Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/wal_e/cmd.py", line 534, in main
backup_cxt = configure_backup_cxt(args)
File "/usr/local/lib/python2.7/dist-packages/wal_e/cmd.py", line 466, in configure_backup_cxt
from wal_e.blobstore import wabs
File "/usr/local/lib/python2.7/dist-packages/wal_e/blobstore/wabs/__ init __.py", line 2, in
from wal_e.blobstore.wabs.wabs_util import do_lzop_get
File "/usr/local/lib/python2.7/dist-packages/wal_e/blobstore/wabs/wabs_util.py", line 10, in
from azure import WindowsAzureMissingResourceError
ImportError: cannot import name WindowsAzureMissingResourceError

It looks like tho code written isn't compatible with modern Azure SDK.
Fix which helped:
replaced
from azure import WindowsAzureMissingResourceError
from azure.storage import BlobService

to
from azure.storage.blob import BlobService
in lines 10-11 of /usr/local/lib/python2.7/dist-packages/wal_e/blobstore/wabs/wabs_util.py
and the first line in /usr/local/lib/python2.7/dist-packages/wal_e/blobstore/wabs/calling_format.py:
From
from azure.storage.blobservice import BlobService
to
from azure.storage.blob import BlobService - this fixed another error ("ImportError: No module amed blobservice").
pip freeze:
Babel==2.0
Landscape-Client==14.12
PAM==0.4.2
Twisted-Core==13.2.0
apt-xapian-index==0.45
argparse==1.2.1
azure==1.0.1
azure-common==1.0.0
azure-mgmt==0.20.0
azure-mgmt-common==0.20.0
azure-mgmt-compute==0.20.0
azure-mgmt-network==0.20.0
azure-mgmt-nspkg==1.0.0
azure-mgmt-resource==0.20.0
azure-mgmt-storage==0.20.0
azure-nspkg==1.0.0
azure-servicebus==0.20.1
azure-servicemanagement-legacy==0.20.1
azure-storage==0.20.1
boto==2.38.0
chardet==2.0.1
colorama==0.2.5
configobj==4.7.2
debtcollector==0.8.0
futures==3.0.3
gevent==1.0.2
greenlet==0.4.9
html5lib==0.999
iso8601==0.1.10
monotonic==0.3
msgpack-python==0.4.6
netaddr==0.7.18
netifaces==0.10.4
oslo.config==2.4.0
oslo.i18n==2.6.0
oslo.serialization==1.9.0
oslo.utils==2.5.0
pbr==1.8.0
prettytable==0.7.2
pyOpenSSL==0.13
pyserial==2.6
python-apt==<IP_ADDRESS>ubuntu1
python-dateutil==2.4.2
python-debian==0.1.21-nmu2ubuntu2
python-keystoneclient==1.7.1
python-swiftclient==2.6.0
pytz==2015.6
requests==2.7.0
six==1.9.0
ssh-import-id==3.21
stevedore==1.8.0
urllib3==1.7.1
wal-e==0.8.1
wheel==0.24.0
wrapt==1.10.5
wsgiref==0.1.2
zope.interface==4.0.5

I actually have a patch for this but have been holding off on deploying it because of testing. Can I give you a patch and you would be so kind as to make sure it doesn't bust everything up?

Yes, it would be great. Actually I mentioned all needed changes in issue, but it will be interesting to compare it with your patch.

Try this out: https://github.com/wal-e/wal-e/tree/v0.9
I'm going to bulk-process a lot of the WAL-E backlog, so I decided to start v0.9 devel just now...but this should be stable, because it's v0.8 + just Azure fix right now.

could you port this fix to 0.8 tree and release since it doesnt look like 0.9 will be out anytime soon

Yeah, let me have a look at that. Either that, or just release v0.9. I'll have a look...

I opted to release v0.9 instead.


[Question]: Access to whisper-large-v3 from groq and question about personalized components on the agent flow.

Describe your problem
Im looking for some initial guidance on the process of adding custom components to the Agents flow editor, as this would open up many possibilities for personalizing the interactions on it. It would be great if the flow could integrate access to Python scripts.
Additionally, I'd like to know if it's possible to update the models that can be used from Groq, especially Whisper-large-v3
Thank you for your work on this project.

All the components are in agent/component/.  Specify paramter and function _run in component.


A typo in colgen.py

Hi, there is a typo. It should be "column_update_num" as shown in the red rectangle. Thank you.

They have been fixed in commit 9c4e1b6. Thank you for pointing them out!


⚠ Secret Website 3 has degraded performance

In 8873fe4, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 9227 ms

Resolved: Secret Website 3 performance has improved in e8b7fb4.


SimpleAnimation on UI elements doesn't work

Hello,
I've got a problem setting SimpleAnimation on UI elements.
I have a panel that I want to animate in the view when I press a key, but the animation doesn't seem to start even tho I use the Play() method.
I tested on another gameObject (only a sprite this time) and it worked.
Can you help me to find out why it's not working for UI elements ?

Hey, can you file a Unity bug with an example of what you are doing (using the bug reporter)?
If you paste the bug number here after, I'll be able to open that project in a safe and confidential manner, and it'll be a lot easier to diagnose.

I was setting up a project with just my bug, but I think I managed to find the solution. The SimpleAnimation culling mode on the UI element was set to "Based on Renderers". I set it to always animate, and it now animate when I call the method Play().
I still have a problem tho, because Rewind seem to don't work on the UI and therefore I can't replay the animation.
Here is the bug report number : 1137042
Thank you for your time.

The support answered me regarding my Rewind problem. Looks like I made a typo in the KeyCode calling the rewind method... Silly me !
Anyway, everything works fine now.
Just for reminder in case of someone encounters the same problem : set the culling mode to Always animate for the UI elements.
Again, thanks for you time. :)


Update DB for file support

This PR was already approved previously, but the PR had to be reverted because a bug that is now fixed.
Here's what has changed:
https://github.com/Nike-Inc/cerberus-management-service/compare/feature/file_support?expand=1#diff-b61c060e505d4453becf0e125c93ceabR78
https://github.com/Nike-Inc/cerberus-management-service/compare/feature/file_support?expand=1#diff-b61c060e505d4453becf0e125c93ceabR149

Coverage increased (+0.08%) to 54.217% when pulling 93f66b1754aecc8e03eaf067f41e6bec25ec3ad0 on feature/file_support into 4116e6d35f532e431737f64895420917d2c52764 on master.


Additional documentation useful for set up

Noting here additional items that would be useful to document / add. (I will create a PR when I've documented a few of these)

[ ] In the generation notebook: the fact that the code is making API calls to the Ollama server. On a Mac M1, I had to download ollama as an application. This has to be running in order for the langchain commands to work
[ ] Save output from generation notebook for use in extraction model
[ ] Provide link to guidance on how to quantise a model (recognising this will be specific to user's environment)

Currently working on documentation for the website to provide better setup instructions! In addition to your suggestions above, this will include:

Synthea International with OpenJDK for generation of structured synthetic data
CorrectMatch with Julia for risk scoring


Suggest books

Is your feature request related to a problem? Please describe.
Some of the books of the Bible are hard to spell.
Describe the solution you'd like
It would be nice if while typing the name of the book if the verse selector that shows the whole verse would pop up with just the name of the book.

Tipping Matt would show Matthew, and tapping it would then insert the whole word. Typing King would show 1 Kings and 2 Kings; typing Cor would show 1 Corinthians and 2 Corinthians.

would love to see this also. will be good if there is book suggestion while we are typing.

would love to see this also. will be good if there is book suggestion while we are typing.

This will be a big change, it will change the behavior of the app, need to think about it thoroughly.

Would love to see this, Support to implement this as book suggestion would improve the speed of the user to quote the correct book and bible verse faster


BIGTOP-2180: Add smoke-test scripts using gradle for Apache Tajo. (This commit depends on BIGTOP-2179)

Looks like this has come along nicely.  I can't review it myself because I don't have the time, but I think it's close to being mergeable now. Puppet recipes are optional I guess although we prefer to have submitted with the packaging a lot of the time.  Thanks a lot for doing this :).!

Thanks for your mention. Please let me know if there are any other problems at this commits.
The deployment using the puppet also was included in my plan so, it would be to see next time.

Thanks again.

i think this looks good for a first pass provided its tested.
@c0s or @oflebbe or anyone else want to review ? To be honest, id be +1 to merging it if others are ok.
I dont actively work on bigtop right now so Im hesitant to give it a +1 with no other review.

Oops... I left minor comments on PR/66.

Thanks guys. I have pushed two fixed.


In client hooks context from RequestPrepared is not received in ResponseReceived

As callClientRequestPrepared is called within doProtobufRequest and that function does not return the context the context provided to ResponseReceived "only" has the values from the generated RPC client call and everything prior to that but nothing from inside doProtobufRequest.

Hey @mspindelhirn, I'm having trouble understanding this issue. From this generated example code, it looks like the request context is properly passed to the RequestPrepared hook, and then the result from the hook is returned from here. Can you provide additional detail?

@mspindelhirn I've confirmed with some folks that this is definitely a bug. Are you interested in submitting a fix for this? If not, I'm happy to take care of it.

Thanks for the follow up.
I can definitly have a go at this and try to provide a fix sometimes this week.


NixOS: Cannot "source .zshrc" (autoload: command not found)

Hey folks,
On a pristine NixOS installation, when I try to source my .zshrc I get this:
[alfredo@unluckystar:~]$ source .zshrc
autoload: command not found
-bash: /home/alfredo/.oh-my-zsh/oh-my-zsh.sh: line 31: syntax error near unexpected token `('
-bash: /home/alfredo/.oh-my-zsh/oh-my-zsh.sh: line 31: `for config_file ($ZSH/lib/*.zsh); do'

The culprit is indeed the fact my NixOS installation does not seem to have the autoload command. Googling around doesn't seem to yield anything meaningful.
EDIT: I'm just being stupid, as autoload seems to be provided by zsh and not from the OS.
I did install zsh following the guide here:
https://nixos.org/wiki/Using_the_ZSH_SHELL
Perhaps my installation is screwed?
Do you guys have any clue on how to workaround this? I'm a relatively new NixOS user.
Thanks a ton!
A.

 Apparently zsh was not being loaded by NixOS as my default shell. Duh.

Same error on osx

@ale-batt check that you have zsh as the default shell. echo $SHELL will do that.
If zsh is not your default shell, a chsh -s $(which zsh) will do it. Then, log out of your user session and log back in to apply the setting.

Forget to wrote, i solve it :) 👍 (just change to a backup from my zshrc)

i fixed, i just uninstall npm and reinstalled again, if you have yarn installed uninstall yarn first and then npm:
brew uninstall yarn
brew uninstall npm
brew install npm

then close your term and open it again


Added KillSignal to gracefully halt agent

In order to use, in systemd service, kill procedure configuration KillMode=process (default signal sent is SIGTERM https://www.freedesktop.org/software/systemd/man/systemd.kill.html# ) and be able to stop consul agent gracefully. We would have to use configuration option KillSignal sent SIGINIT (https://www.consul.io/docs/agent/basics.html)

Hmm, I'm not 100% sure this is desired behavior. Check out #146 and #87.
The general consensus was that it was dangerous for non-agents to leave a cluster gracefully.
Can you (is it possible in systemd) make this PR match the other init script behavior? (only gracefully leave cluster if agent)

I have added conditional in the template to ensure that stop consul agent gracefully only apply for consul agent client and no consul agent server.
However Consul Agent Basics ( https://www.consul.io/docs/agent/basics.html ) said:

It is especially important that a server node be allowed to leave gracefully so that there will be a minimal impact on availability as the server leaves the consensus quorum.

For client agents, the difference between a node failing and a node leaving may not be important for your use case. For example, for a web server and load balancer setup, both result in the same outcome: the web node is removed from the load balancer pool.

Hmm. These lint failures in travis are not from this PR, I don't know what is up with that. Don't worry about them.
Also, per the docs, are we "doing it wrong"? (wrt agent versus server leaving gracefully)

Also please merge/rebase on master to fix the tests.

From my point of view when you stop the service (in this case with systemd) the expected behaviour would be the node ( agent with server role or client role) leave the cluster (as doc said with a signal SIGINT).
Docs emphasizes in that is especially important that a server node be allowed to leave gracefully So I think that always we use SIGINT to stop consul agent (server or not). Other signals in some cases could produces false failing states. For me it is important that I can control the state of services, and I need to deregistrate services when I stop consul agent.

When a node leaves, it specifies its intent to do so, and the cluster marks that node as having left. Unlike the failed case, all of the services provided by a node are immediately deregistered. If the agent was a server, replication to it will stop.

Through the proper config you can rejoin consul agent (server o client) to cluster when the service starts again the service.

Just want to let you know I haven't forgotten about this PR.

This behavior has changed since the opening of this PR. The default now is to not leave the cluster regardless of server or client.


test: Isolate veth peer into Separate net namespace

Put the veth peer into separate net namespace, to
NetworkManager will not impact test results by trying to managing
the veth peer.

This PR is required by #1220


Icon submission: Forum Italia

[x] I have read and followed CONTRIBUTING document.
URL of the site or app (required, unless it's generic icon): https://forum.italia.it/
Where did you took the BG color(s) (required, unless it's generic icon): https://github.com/italia/developers.italia.it/blob/master/assets/icons/logo-it-blue.svg
Icon source: https://github.com/italia/developers.italia.it/blob/master/assets/icons/logo-it.svg

Uploaded files: Forum Italia.zip

Added to the repo.


Add support for pyhdk v0.6.1 flags

In pyhdk v0.6.1 we are introducing two new features:

Ability to place logs in a specific directory (e.g. the temp directory, if log files are not required). This was a request from one of our benchmarking teams.
Ability to lazily materialize dictionary encoded string columns. This feature speeds up the import process, particularly if only a few text columns are processed later in a query. However, it makes benchmarking more difficult, and can slow down workflows with large numbers of queries on text columns, so we're making it configurable.

We have also introduced a version API in HDK v0.5 which we will use to remove these flags from the command string for HDK versions older than 0.6.1.
I plan to submit a PR with these new config variables + version processing shortly.

Let's also substitute 0.6.1 to 0.7 everywhere


implement ability to sort images (pumped, unpumped)

implemented as even/odd frame index. in the future should be better designed, maybe with a inline python function in tango property with enums as output with this interface
def divider(frame_index):
# 5 frames per trigger
# pumped, unpumped, ped, ped, ped
x = frame_index % 5
if x == 0:
    return FrameType.PUMPED
elif x == 1:
    return FrameType.UNPUMPED
elif x >= 2:
    return FrameType.PEDESTAL


[feature request] Popular links

Since forever I have https://pinboard.in/popular/ page on my bookmarks. It's a great page for looking at popular links saved by users at Pinboard.
I truly love linkding, and I would love it more if this feature –meaning, a page for popular links, probably with opt-in, etc, etc- is implemented.

pinboard.in is a central instance with thousands of users, while linkding is a self-hosted app that doesn't know anything about the data in the instances that other people host. On pinboard that feature is useful because hundreds of people could have bookmarked the same link, making it popular. In linkding, at best you could show links that multiple users on the same instance have bookmarked, which doesn't seem very useful / meaningful since there's probably going to be very little overlap due to the much lower number of users. The next best thing in linkding is sharing bookmarks, so if you have other users on your instance (family, friends, colleagues) and they share stuff, you could take a look at what they have shared from time to time.


Allow JSON objects in telegram.*.communicate.response

This change makes it possible to send markup / HTML encoded
messages e.g. from node-red by storing a JSON structure
into the telegram.*.communicate.response.
Example:
msg.payload = {
    text: 'This is a *bold* text',
    parse_mode: 'Markdown'
}

Thank you!
It would be helpful if the readme will be updated too.


Improved dataloading with multiple sources without resampling.

This PR improves the deterministic dataloading when multiple data sources are included. The current implementation works by using a manifest for each data source, and then for each epoch using that manifest to pick shards to train for this particular epoch, according to the ratio defined by the source weights.
This PR is currently a WIP, with the following tasks remaining:

[x] Include automated tests.
[x] Ensure deterministic training.
[x] Compare with training with resampling.
[x] Update README.

Including a file for comparison between the sampling with and without replacement.

Following discussion with @gabrielilharco, splitting of the shards is no longer done strictly across epochs, but rather across chunks. Each chunk has roughly the number of samples required for the epoch, so if the number of tokens is large enough then there will be no difference.
This change was done in order to fix the issue of having only a few shards (less than the number of workers) within an epoch. This alleviates this issue by assigning more shards to an epoch, if needed.

In the above implementation, there is a corner case where if the final group of shards does not have enough samples to cover a single epoch, it is discarded. This will matter if we exhaust the dataset, so I believe it should be handled as well.

Approving because I think we've tested and iterated on this a bit, but left a few comments that would be nice-to-haves in this PR or next. I believe @Vaishaal is also planning to take a look, though, and we can wait for that before merge.


Remove line break HTML element from tooltipText

Why are we adding the line break element to meta for tooltipText?
if (hasMeta) {
  tooltipText += meta + '
';
}

I am currently implementing meta as HTML, so I simply format and style the tooltip contents with HTML and CSS. The extra line from the
 is unnecessary. Is the line break necessary in other implementations?
if (hasMeta) {
  tooltipText += meta;
}

https://github.com/Globegitter/chartist-plugin-tooltip/blob/master/src/scripts/chartist-plugin-tooltip.js#L87

@tedbreen This repository is only in maintenance mode (i.e. accepting sensible PRs), so can not say for sure what the intentions of @hansmaad where. But if this is stopping you from achieving something you want I'd be happy to accept a PR.

@Globegitter I didn't add the
. It was part of the very first commit of this repository! https://github.com/Globegitter/chartist-plugin-tooltip/blob/766e9268e787fde388f2a881864d3479b7e8cd80/dist/chartist-plugin-tooltip.js#L56

Apologies then @hansmaad, just had a cursory glance over that commit.

I suppose it depends on how much flexibility a user wants. For example, I only want to show my custom meta component in the tooltip and hide the value. The value is added by default though, which explains the line break:
if (value) {
  if (options.currency) {
    value = options.currency + value.replace(/(\d)(?=(\d{3})+(?:\.\d+)?$)/g, '$1,');
  }
  value = '' + value + '';
  tooltipText += value;
}

For now, I've just edited the source file by removing the line break and creating an option for displaying the value:
if (value) {
  if (options.currency) {
    value = options.currency + value.replace(/(\d)(?=(\d{3})+(?:\.\d+)?$)/g, '$1,');
  }
  value = '' + value + '';
  if (!options.doNotShowValue) tooltipText += value;
}

Result:

@tedbreen We would to like to implement tooltips with custom style like yours but options seem limited with default parameters. May I ask what kind of an approach you followed in your case?

Having trouble implementing meta as HTML - only seems to output as a string of html; it never renders the html. Any help would be much appreciated.

@kubilaykarpat I generate a DOM object with JavaScript so I can get an HTML string. For example:
var container = document.createElement('div')
var title = document.createElement('h1')
var sentence = document.createElement('p')

title.textContent = 'October'
sentence.textContent = '7,250 kWh'

container.appendChild(title)
container.appendChild(sentence)

container.outerHTML
// =>

October

7,250 kWh

You could just type the HTML manually, but using JavaScript will allow for more reusable functionality.

@robjac Are you using the correct options with this plugin?
Chartist.plugins.tooltip({
  metaIsHTML: true
})

Also, you have to make sure you push objects into the chart's series array that include the meta key. For example:
new Chartist.Line('.ct-chart', {
  labels: ['Monday', 'Tuesday', 'Wednesday'],
  series: [
    [
      {value: 12, meta: '

Monday

12 somethings

'},
      {value: 9, meta: '

Tuesday

9 somethings

'},
      {value: 7, meta: '

Wednesday

7 somethings

'}]
  ]
}, {
  fullWidth: true,
  chartPadding: {
    right: 40
  }
})

@tedbreen The issue is if you pass in HTML as meta, all the special characters get escaped. the metaIsHTML option wasn't detailed anywhere, but I had seen it mentioned before. We just tried it with this option and it still spits out HTML as a string; even with hardcoded html, and with building DOM objects in vanilla JS (or jQuery). Our data inputs are fed in the same way in the meta key.
Using Chartist v 0.10.0 and Chartist-Tooltip-Plugin v0.0.12.
Our workaround was to remove/comment out the Chartist.escapingMap config and everything works. Any reason why this would be disastrous?
Thanks so much for the swift reply, appreciate the discussion.

@robjac Wow, that's odd. I have never encountered that problem. I am still on Chartist v 0.9.8. I'll keep an eye out for this when I get around to upgrading.


Updated to version 1.9.1 and i can no longer set breakpoints by clicking on the leftsidebar of the code

i use vscode for python dev, in earlier versions i was able to set breakpoints by clicking on the left editor bar , but in this version i dont see the bar at all to set the break point.
please suggest how can i set breakpoints now.

Thank you @roblourens  , it was set to false , dont know how that happened, setting it to true worked


Tonel loading installs a bad debugger class

To restore back the good debugger you have to evaluate: EsImageStartUp debuggerClass: StsDebugger.
I don't know why the debugger class is changed when loading Tonel....

The reason was that one of the application depends on EtTools, which in turn depends on EtBaseTools, which has a loaded method, that sets DbgDebugger as the default debugger.


Media queries don't (always) work in a style module

Please take a look at
http://plnkr.co/edit/ig2qpsguLzpBgwRx0RjE?p=preview
ZZZ supposed to be green when less than 30em and red otherwise
When opened in chrome dev tools emulating mobile device, the color doesn't change on resize if loading from here
http://run.plnkr.co/plunks/ig2qpsguLzpBgwRx0RjE/
but it works when loading from within pluk:
http://embed.plnkr.co/ig2qpsguLzpBgwRx0RjE/preview

http://run.plnkr.co/plunks/ig2qpsguLzpBgwRx0RjE/ changes from red -> green when I resize both Chrome and FF. What are the exact repo steps?

The seps are just open the dev tools and resize. The video: https://www.dropbox.com/s/zdrqeq0od7r70nf/out.mkv?dl=0
And it works in FF for me too. The Chrome version is 46.0.2490.86 (64-bit).

and it also doesn't  work from real mobile dev (lenovo A316, chrome  46.0.2490.76). At least when I scale the screen so that zzz occupy all width it's still red.

Looking at the video, I see a difference on the right part of the screen.
In the working example, there is a small margin between the red background and the right border of the screen.
However, in the broken example, this margin does not exist.
I have tried to replicate this specific issue, but was unsuccessful. Could you maybe (in the broken example) inspect the width of the element? It might be overflowing or something similar.

You're testing in device mode emulation, perhaps its a bug in that tool? When I tested, I just resized the browser window.

Perhaps, but both are made by google:) And it didn't work in Lenovo too. I'll try to find more devices to test in.

there were no  ... so the plnkr is just broken. Sorry for taking your time.
Although the real app I have problem in still doesn't work with very same symptoms as plnkr and it has meta. So there maybe something else.


Ui improvements

Please make sure you've read the pull request section of our code contribution guidelines.
When filling in a section please remove the help text and the above text.
Summary
PLT-7711 - Fixing spacing in manage roles screen
PLT-7760 - Enabling send button for tablets
PLT-7779 - Fixing posts containing less characters
Ticket Link
https://mattermost.atlassian.net/browse/PLT-7711
https://mattermost.atlassian.net/browse/PLT-7760
https://mattermost.atlassian.net/browse/PLT-7779
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] Added or updated unit tests (required for all new features)
[ ] Has server changes (please link)
[ ] Has redux changes (please link)
[x] Has UI changes
[ ] Includes text changes and localization file (.../i18n/en.json and .../webapp/i18n/en.json) updates
[ ] Touches critical sections of the codebase (auth, posting, etc.)

@hmhealey @saturninoabril Fixed that.


No error logged when broker becomes unresponsive due to Netty transport issue

On a five server cluster with one controller & one broker, running Pinot 0.6.0, the following query caused the cluster to no longer process queries: select distinctcount(column) from table, where the column in question had very high cardinality (> 1B unique values out of 5B total records).
There were no errors logged for the controller, broker, or 5 server processes. Once the cluster became unresponsive, a new request (e.g. select * from table limit 20) would be logged by the broker and the servers, but the broker logging indicated it did not think it received a response:
2021/02/19 22:21:53.860 INFO [BaseBrokerRequestHandler] [jersey-server-managed-async-executor-59] requestId=41163,table=crawldata_OFFLINE,timeMs=10000,docs=0/0,entries=0/0,segments(queried/processed/matched/consuming/unavailable):0/0/0/0/0,consumingFreshnessTimeMs=0,servers=0/5,groupLimitReached=false,brokerReduceTimeMs=0,exceptions=0,serverStats=(Server=SubmitDelayMs,ResponseDelayMs,ResponseSize,DeserializationTimeMs);<IP_ADDRESS>_O=0,-1,0,0;<IP_ADDRESS>_O=0,-1,0,0;<IP_ADDRESS>_O=1,-1,0,0;<IP_ADDRESS>_O=1,-1,0,0;<IP_ADDRESS>_O=1,-1,0,0,query=select * from crawldata limit 20

@Jackie-Jiang indicated he thought that the very large response from servers (on the order of 200M unique strings, each 64 characters long, per server) caused an issue with the transport layer, but Netty didn't log any error:

Based on the log you posted, server side processed the second query without any issue, but broker didn't receive the response, and that's why I suspect something is broken in the transport layer

We rely on netty to transport data, maybe we hit some limitation in netty, but netty didn’t trigger the exception callback

I restarted the broker process, and the cluster once again was working, which indicates that the issue was indeed due to some invalid state for the broker.

I will pick it


why don't you normalize the images?

Thanks for your work. I found that you don't normalize the images before training. Is transformer better in this way? I look forward to your reply！

Thanks. Normalization was not part of the CLOVA AI training/eval protocol that we used. So, we did not try normalization. We just reproduced their results and followed the same protocol on our ViRSTR for fair comparison.

thanks for your reply.  Is your model able to recognize the long text? I have trained on my datasets with size of image is (32,448), however, after 300k iterations, the  model accuracy is quite low.

You might want to train fr scratch (instead of a pre-trained ViT) if you have access to a big train dataset. In such cases, you can train without resizing the input image to unconventional size of 224x224 as done in ViTSTR. The closer the target test dataset image sizes to the train dataset image sizes, the better.


Option to install gems for only target ecosystem in dev shell

This speeds up build time of the dev shell if you only need to work with a particular ecosystem. Installing gems for all ecosystems takes a long time so this flag allows you to only install them for a particular ecosystem. You'll be able to dry-run/test the target ecosystem but you'll need to rebuild or manually install gems to work with others.
TARGET_ECOSYSTEM=go_modules ./bin/docker-dev-shell --rebuild

My bash skills are a bit rusty so open to any tips on improving this as well!

This is what I was thinking: https://github.com/dependabot/dependabot-core/pull/5528. Not sure if it works but makes sense to me in principle?

Maybe a silly question, but I see that all these Gemfiles only install the dependencies in common/. Would it be a bad idea to share this gem location accross ecosystems? Just saying because that would make this fast by default.

Oh interesting, I didn't realize the gems aren't customized for any of the ecosystems! I think sharing them would make more sense although it would make it harder to add a gem to a single ecosystem in the future. That may not be a problem given it hasn't happened yet.

Yeah!
It that happened, I think it might still work, just the other environments would have one unused gem available. But we could split out that single bundle anyways (partially rolling this back indeed, so with some extra work).
Anyways, I think we can give #5528 a try and see if it has any unexpected side effects!

FYI: there are some places where we do install dependencies outside of the common gemspec, not sure if that matters in this context https://github.com/dependabot/dependabot-core/blob/10d3ba4b4cddbea14173275a07707eceb6bbd85f/git_submodules/dependabot-git_submodules.gemspec#L26

FYI: there are some places where we do install dependencies outside of the common gemspec, not sure if that matters in this context

Aha, nice find! I think that means the submodule updater would be missing that gem with https://github.com/dependabot/dependabot-core/pull/5528? If that's the only case I wouldn't be opposed to moving it to common as that makes the dev containers faster to build/easier to use for everyone.
Does it make sense to install the gems for the omnibus first since that should include dependencies from all the sub-projects? ex: https://github.com/dependabot/dependabot-core/pull/5529

I verified that with #5528 the submodule updater is indeed missing the parseconfig gem, nice catch @jurre! So I'm going to close this in favor of #5529!

I actually meant to close my own PR, not this one, sorry 😳.
But I guess #5529 looks promising enough to close this one too. We can reopen if we end up not merging #5529, sounds good?


Suggestion about my animelist part of extension

[ ] Bug
[ ] Question
[x] Suggestion
[ ] Other (please describe):

Describe your issue:
I see that when you start an anime well add it to your list using the app on 9anime it adds a start date is it possible to when you reac the end of the anime to be able to have it add to then add it at the end of the show when you click the last time to add it to 12-12 and it adds the date to myanimelist so you dont have to go and add it yourself or work out when you finished watching it?

Sure thing :) its actually a planned feature and a bit similar to #68

Yes i see it is witch is awesome with what they have said that would be useful with not having to go back and forth between sites, back to the question above i asked well suggestion more or less will this do it automaticlly to all anime when its added the end time even if you had already added it to your watching list or planned to watch list so you could be going threw and go oh thats cool and add it on my anime and it would then still add the start and end date? so from the first time you hit the button it marks the start date for 1+ and when you get to the end it would put the end date at 13+ or how ever long the show run is


DataAvailable

Is there a way to tell if there is data available on a socket stream?  I am looking for something like DataAvailable on a NetworkStream.
Thanks

Hi there. Take a look at #24 - unfortunately we can't use DataAvailable because there doesn't seem to be any equivalent in WinRT.
However, you could possibly use this BetterTcpSocket I once put together (see #9 for discussion/context - it was designed to proactively read from the socket and buffer data in order to immediately detect disconnection), and add an additional property that checks whether the BlockingMemoryStream has any data in the buffer. In that case, the socket would still be being read immediately in the background, but you would be able to check whether data was available before your made a call to Read in your own code. It might be what you're looking for?

Thank you for your response.  Great approach you you have with BetterTcpSocket.   Another question unrelated since you are up to speed on this socket stuff.  Are you familiar with any DNS solutions that are PCL?   I need the ability to resolve a host name and do a service record (SRV) look up.   THanks!

Also, it seems that is only a partial class (BetterTCPSocket).  Missing the using statements and some other issues.  Do you have a full example?

Hey again,
I'm not really familiar with anything DNS that is also PCL compatible. If you only need to do DNS lookup, you might try implementing it yourself using sockets-for-pcl (I think it's just the one request/response), or adapt an existing C# DNS library to use sockets-for-pcl instead (that is, switching out the socket used by the library with a tcp or udp socket from sockets-for-pcl).
As for BetterTcpSocketClient, I copied it into a new PCL with sockets-for-pcl installed and Resharper offered to add the following usings:
using System;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
using Sockets.Plugin;
using Sockets.Plugin.Abstractions;

With those you should be good to go!


Can't nest components inside ng-sidebar

Is it possible to put components inside ng-sidebar-content?
I've been trying without success...
ng-sidebar seems to seems to always push content of app-content.
Below my code.
<ng-sidebar #sidebar >
    <div ng-sidebar-content>
       <app-content></app-content>
    </div>
</ng-sidebar-container>

Are you sure your code is right? It seems to be missing the opening tag for the container and the closing tag for the sidebar.

Sorry, my code is a bit messy. Below it more readable:
<app-navbar></app-navbar>
<ng-sidebar-container style="height: 100vh; display: inline;">

    <ng-sidebar #sidebar
    [opened]="sidebarOpened"
    [dock]="true"
    [dockedSize]="'40px'"
    [mode]="'push'"
    [position]="'left'"
    [closeOnClickOutside]="false">
    <!-- Sidebar content  -->
   </ng-sidebar>

   <div ng-sidebar-content>
      <app-content></app-content>
    </div>

</ng-sidebar-container>

It's hard to tell without actually being to see the site. Your best bet would be poking around in dev tools to see why it's pushing things.

Thanks. I'll try to debug it, it's probably not a problem with the module


VS Code keeps crashing within 1sec of starting up

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.90.0
OS Version: Ubuntu 22.04

Steps to Reproduce:

code --disable-gpu --disable-extensions --verbose

I've tried:

Reinstalling VSCode (using snap)
Run code
Run code --disable-gpu --disable-extensions
Run code --disable-gpu --disable-software-rasterizer
Reinstalling Nvidia drivers

Adding the verbose output
[0606/164932.193632:ERROR:directory_reader_posix.cc(43)] opendir /home/parth/.config/Code/Crashpad/attachments/6388c80a-e3dc-419c-8c84-75d2bda686a8: No such file or directory (2)
[95858:0606/164932.293515:WARNING:bluez_dbus_manager.cc(248)] Floss manager not present, cannot set Floss enable/disable.
[95887:0606/164932.424709:WARNING:vaapi_wrapper.cc(1497)] Skipping nVidia device named: nvidia-drm
[main 2024-06-06T11:19:32.432Z] [File Watcher (node.js)] Request to start watching: /home/parth/.config/Code/User (excludes: <none>, includes: <all>, filter: <none>, correlationId: <none>),/home/parth/.config/Code/User/settings.json (excludes: <none>, includes: <all>, filter: <none>, correlationId: <none>)
[main 2024-06-06T11:19:32.453Z] Starting VS Code
[main 2024-06-06T11:19:32.453Z] from: /snap/code/160/usr/share/code/resources/app
[main 2024-06-06T11:19:32.453Z] args: {
  _: [],
  diff: false,
  merge: false,
  add: false,
  goto: false,
  'new-window': false,
  'reuse-window': false,
  wait: false,
  help: false,
  'list-extensions': false,
  'show-versions': false,
  'pre-release': false,
  'update-extensions': false,
  version: false,
  verbose: true,
  status: false,
  'prof-startup': false,
  'no-cached-data': false,
  'prof-v8-extensions': false,
  'disable-extensions': true,
  'disable-lcd-text': false,
  'disable-gpu': true,
  'disable-chromium-sandbox': false,
  sandbox: false,
  telemetry: false,
  debugRenderer: false,
  'enable-smoke-test-driver': false,
  logExtensionHostCommunication: false,
  'skip-release-notes': false,
  'skip-welcome': false,
  'disable-telemetry': false,
  'disable-updates': false,
  'use-inmemory-secretstorage': false,
  'disable-workspace-trust': false,
  'disable-crash-reporter': false,
  'crash-reporter-id': '752e7a7e-0c8b-4c3e-a32c-3d3dc02e1f9c',
  'skip-add-to-recently-opened': false,
  'open-url': false,
  'file-write': false,
  'file-chmod': false,
  force: false,
  'do-not-sync': false,
  trace: false,
  'preserve-env': false,
  'force-user-env': false,
  'force-disable-user-env': false,
  'open-devtools': false,
  'disable-gpu-sandbox': false,
  '__enable-file-policy': false,
  'enable-coi': false,
  'no-proxy-server': false,
  'no-sandbox': false,
  nolazy: false,
  'force-renderer-accessibility': false,
  'ignore-certificate-errors': false,
  'allow-insecure-localhost': false,
  'disable-dev-shm-usage': false,
  'profile-temp': false,
  logsPath: '/home/parth/.config/Code/logs/20240606T164932'
}
[main 2024-06-06T11:19:32.455Z] Resolving machine identifier...
[main 2024-06-06T11:19:32.455Z] Resolved machine identifier: 2cf85072c4bd13876d483f3ef88829cff176b041f0fef2ba320103764737430e
[main 2024-06-06T11:19:32.455Z] Main->SharedProcess#connect
[main 2024-06-06T11:19:32.459Z] [File Watcher (node.js)] Started watching: '/home/parth/.config/Code/User'
[main 2024-06-06T11:19:32.460Z] StorageMainService: creating application storage
MESA-LOADER: failed to open radeonsi: /usr/lib/dri/radeonsi_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/x86_64-linux-gnu/dri:\$${ORIGIN}/dri:/usr/lib/dri, suffix _dri)
failed to load driver: radeonsi
[main 2024-06-06T11:19:32.463Z] update#setState idle
MESA-LOADER: failed to open kms_swrast: /usr/lib/dri/kms_swrast_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/x86_64-linux-gnu/dri:\$${ORIGIN}/dri:/usr/lib/dri, suffix _dri)
failed to load driver: kms_swrast
MESA-LOADER: failed to open swrast: /usr/lib/dri/swrast_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/x86_64-linux-gnu/dri:\$${ORIGIN}/dri:/usr/lib/dri, suffix _dri)
failed to load swrast driver
[main 2024-06-06T11:19:32.465Z] ElectronURLListener: waiting for window to be ready to handle URLs...
[main 2024-06-06T11:19:32.465Z] lifecycle (main): phase changed (value: 2)
[95887:0606/164932.465935:WARNING:sandbox_linux.cc(418)] InitializeSandbox() called with multiple threads in process gpu-process.
[main 2024-06-06T11:19:32.466Z] windowsManager#open
[main 2024-06-06T11:19:32.466Z] windowsManager#open pathsToOpen [
  {
    backupPath: '/home/parth/.config/Code/Backups/1717643223523',
    remoteAuthority: undefined
  }
]
[main 2024-06-06T11:19:32.467Z] windowsManager#doOpenEmpty {
  restore: true,
  remoteAuthority: undefined,
  filesToOpen: undefined,
  forceNewWindow: true
}
[main 2024-06-06T11:19:32.468Z] IPC Object URL: Registered new channel vscode:e407999f-78ef-4deb-9683-91a8ea3708ce.
[main 2024-06-06T11:19:32.469Z] window#validateWindowState: validating window state on 1 display(s) { mode: 1, x: 285, y: 95, width: 1028, height: 772 }
[main 2024-06-06T11:19:32.469Z] window#validateWindowState: single monitor working area { x: 0, y: 27, width: 1596, height: 871 }
[main 2024-06-06T11:19:32.469Z] window#ctor: using window state { mode: 1, x: 285, y: 95, width: 1028, height: 772 }
[main 2024-06-06T11:19:32.535Z] window#load: attempt to load window (id: 1)
[main 2024-06-06T11:19:32.542Z] windowsManager#open used window count 1 (workspacesToOpen: 0, foldersToOpen: 0, emptyToRestore: 1, emptyToOpen: 0)
[main 2024-06-06T11:19:32.542Z] lifecycle (main): phase changed (value: 3)
[main 2024-06-06T11:19:32.542Z] resolveShellEnv(): skipped (VSCODE_CLI is set)
[main 2024-06-06T11:19:32.568Z] [File Watcher (node.js)] ignoring a path for watching who's stat info failed to resolve: /home/parth/.config/Code/User/settings.json (error: Error: ENOENT: no such file or directory, stat '/home/parth/.config/Code/User/settings.json')
[main 2024-06-06T11:19:32.596Z] resolveShellEnv(): skipped (VSCODE_CLI is set)
[0606/164932.596393:ERROR:process_memory_range.cc(75)] read out of range
[0606/164932.596420:ERROR:process_memory_range.cc(75)] read out of range
[0606/164932.596428:ERROR:process_memory_range.cc(75)] read out of range
[0606/164932.596444:ERROR:process_memory_range.cc(75)] read out of range
[0606/164932.596452:ERROR:process_memory_range.cc(75)] read out of range
...
...
...
...

I have the same problem

Had the same problem, on Ubuntu 22.04. The problem seems to come from the snap version.
You can try removing currently installed version with
sudo snap remove code
Then download the version from VSCode official site (current version is 1.90.0), and install it with
sudo apt install ./code_1.90.0-1717531825_amd64.deb
The editor launched just fine. Hope this helps.

Same thing happened to me, removing Snap version and installing Deb version worked. https://code.visualstudio.com/docs/setup/linux

Thanks for the help @davsahakyan @faabiopontes
This really worked.

Having the same issue right after updating


Configuration-filename missing

https://github.com/timoschwarzer/gitlab-monitor/blob/master/CONFIGURATION.md says "Your configuration overrides the default configuration, which can be found src/config.default.json", but is missing the filename of my configuration file.

This file definitely exists: https://github.com/timoschwarzer/gitlab-monitor/blob/master/src/config.default.json
I don't understand the problem.

Now I understand. With "Your configuration" you mean the configuration within the browser, I thought I can save my configuration to a file like config.json which did not work.
Maybe you can change this to: "Your configuration in the browser overrides the default configuration, which can be found here".


Add boolean or expressions to Krikri::Parser::Value subclasses

Add the ability to interpret boolean "or" expressions in the names passed to Krikri::XmlParser#get_child_nodes and Krikri::JsonParser#get_child_nodes, by way of Krikri::Parser::ValueArray#field and #fields.
This is necessary so that we can do the following sort of thing in our mappings:
    providedLabel record.field('description', 'item|itemAv|fileUnit',
                               'physicalOccurrenceArray',
                               'itemPhysicalOccurrence|' \
                                 'itemAvPhysicalOccurrence|' \
                                 'fileUnitPhysicalOccurrence',
                               'referenceUnitArray', 'referenceUnit',
                               'name')

Both XmlParser and JsonParser have been modified so that usage is consistent between the two.

@no-reply and @anarchivist:
There has been some discussion outside of here about the | token.   I'd be happy to rename it to "or" to avoid confusion with XPATH, because it's not documented as producing unions.  The need eventually for unions is acknowledged, but something to handle with another operator; out of scope for the time being, since we're biting off a smaller piece now, just trying to get NARA mapped.
It's documented as being a boolean "or", and I intended the operator to work like "or" in Perl or Python( 0 or 'a' resulting in 'a' in either, [] or ['a'] resulting in ['a'] in Python).
It is also supposed to be bound more loosely than anything else, and the functionality could be expanded with other operators later.
Regarding an issue raised about the order of the elements in the provider's document being potentially different, and the way I'm grabbing the first defined element in the document:  I think both fields existing at the same time would constitute ambiguity in the metadata that would be best worked out with the provider.  I think that we might not want to make any promises about which field gets taken first.  Supposing it was something we wanted to accept, it's not easy to work with given way we're currently using XPATH in #get_child_nodes.  Since we don't want to pass through XPATH expressions from the DSL to the XML parser, why use XPATH at all in #get_child_nodes?  Why not use some easier way that lets us refer to the document as a hash?
I'm writing this quickly and have to resume this train of thought later today ...

Just another thought while I have a second:
If we have a provider with multiple elements defined for the same thing, why not use a union operator to get them both and then evaluate them in the enrichment phase?  It seems that we shouldn't care which one is preferred in the "or" because that should be reserved only for cases like NARA where we know it's really supposed to be one or the other.
We want to make sure we don't make enrichment decisions in the mapping phase or introduce too much code to the parser classes.  We just want to grab one or the other element, or grab a union of elements and sort it out in enrichment.

Thanks @mb.
I'm in favor of taking on DSL extension with the limited scope needed to accomplish the NARA mapping, as you suggest.
My main stumbling block the use of the terminology "boolean or" for a short-circuited, sequence point/control flow or.  I think I'm okay with "or"... I find it somewhat counter-intuitive

I think both fields existing at the same time would constitute ambiguity in the metadata that would be best worked out with the provider.

I agree that this is the case for the NARA mapping, but I'm not sure it holds for other uses of a sequence point selector.  It seems reasonable to use such an operator to do something like record.field('dc:title|rdf:label') expecting to use label as a fall-back when title is present. I don't think we need to resolve this now, necessarily, but I'm leary of specifying the operator with this ambiguity built in.
On a related note, I'm unsure that a sequence point operator correctly specifies that mapping for NARA. My understanding is that we want to map description.itemAV if record_type matches some value, right?  Could/should we just implement that conditional?

Since we don't want to pass through XPATH expressions from the DSL to the XML parser, why use XPATH at all in #get_child_nodes? Why not use some easier way that lets us refer to the document as a hash?

Agreed. I don't see us as pinned to XPATH at all, here. The various parsers can use whatever tools are at their disposal to implement the parser-layer.
We should probably just schedule a quick meeting to talk this out. I don't want to fuss too much about getting this perfect; I'll be happy if we can just get on the same page. :)

@markbreedlove said, across two comments (emphasis added)...

Regarding an issue raised about the order of the elements in the provider's document being potentially different, and the way I'm grabbing the first defined element in the document: I think both fields existing at the same time would constitute ambiguity in the metadata that would be best worked out with the provider.

...and...

It seems that we shouldn't care which one is preferred in the "or" because that should be reserved only for cases like NARA where we know it's really supposed to be one or the other.

I think this gets at the crux of this issue, at least for the issue what the key within the top-level description object in the NARA data is, and the subsequent issues. In my understanding there shouldn't be that ambiguity. Hence, this is why my inclination was something like "wildcard" operator would be useful here - because we don't care which element - we just care that something matches.
@no-reply wrote:

On a related note, I'm unsure that a sequence point operator correctly specifies that mapping for NARA. My understanding is that we want to map description.itemAV if record_type matches some value, right? Could/should we just implement that conditional?

I'm not sure I follow. What is record_type? My understanding is that we're not too choosy about the type we receive, but that sounds like a mapping question. The major issue is that the key/element under description determines elements further down the chain. We see that with other parts of the crosswalk too, e.g. the structures for creator and contributor.

@anarchivist the "record type" thing was related to me here:  https://dpla.slack.com/archives/tech/p1432310383000203
I'm not sure what value record_type would be in NARA's metadata, but my understanding is that it would be an error to collect description.item for items of a certain types, even if it were present. (I understand that NARA's API isn't supposed to give  us a description.item in those cases).

Hence, this is why my inclination was something like "wildcard" operator would be useful here - because we don't care which element - we just care that something matches.

It's not clear to me whether your "wildcard" operator works like @markbreedlove's sequence point operator, or like union, or neither.  If I do record.field('description', wild, wild,  'referenceUnitArray', ...) am I selecting all nodes underneath 'description', just something that matches, or something else I'm overlooking?

I'm realizing that the main disconnect here is that we dealing with two different models, and seeing each this operator working in different contexts. I'm reading record.field('title') as an element selector; record.field('title|label'), for me, operates on that level, and | is an operator that works over the sets selected by 'title' and 'label'. This leads me to read "boolean or" as union.
The other model at play is control flow--"what do I do if the first field returns empty"?  The implementation @mb is arguing for is a parallel control flow or; i.e. "evaluate these expressions; give me one that selects non-empty set, I don't care which." Another approach would be a sequenced control flow or; "evaluate these expressions in order; give me the first that selects a non-empty set."
As I puzzle this out, all of these options are growing on me... Whatever we end up doing, I think we should avoid calling it "boolean or". :)
Talking this out with a language design chat yielded a couple of suggestions:

"you might also consider + for union, | for sequencing"
" in my work language i called that "rescue" bc missing values propagate like exceptions. any function of a "missing" expr is also "missing" and the | syntax "rescues" it"
""defaults" might be a better word in that case too; default as in removing the fault of missing data"

The "or" I mean is disjunctive, in that it expresses a choice between two exclusive possibilities; you get one or the other, but not both.
I haven't heard of a "sequence point selector" before, and it's not a common term, but I am familiar with the notion of a short-circuit evaluation: http://en.wikipedia.org/wiki/Short-circuit_evaluation.  I am pretty confident in my usage of "boolean or" to mean a "boolean operator" or "logical operator"; the one for "or" -- which is "||" in many languages, or "or" (where the difference is often just precedence).
I chose "|" because it's more compact, and is used in Perl-compatible regular expressions (where the conditions under which you get a union from using it have to do with it being employed with a character class ("[]") or a regex modifier like "g".
I wasn't thinking of this originally, but it turns out that the operator in the regex stops the evaluation with the first thing it encounters in the string that matches one of the conditions: try "abc".match /(c|b|a)/ in Ruby, or the equivalent in any language that uses libpcre and you'll get "a", not a union of "c", "b", and "a".  Not that this has to operate exactly like a regex, but nobody should be looking at it, thinking, "I'm going to get a union from this."
I originally intended the operator to have short-circuited evaluation like "or" or "||", where it's evaluated from left to right, but then ended up with an XPATH issue where I couldn't pull that off conveniently.  All the same, it believe that its behavior will not surprise anyone, especially if it's documented, which it will be.

My understanding is that we want to map description.itemAV if record_type matches some value, right? Could/should we just implement that conditional?

I'm trying to alleviate extra typing and extra lines of code in the mappings, and trying to make things easy for the authors of the mappings, surprising them as little as possible.  Using "|" the way it works now (or "or" if that's better) is going to be easier for a non-programmer to learn and type than using extra "if" statements.  I don't think that most of the mapping authors are going to be surprised by the way it works currently.

The other model at play is control flow--"what do I do if the first field returns empty"? The implementation @markbreedlove is arguing for is a parallel control flow or; i.e. "evaluate these expressions; give me one that selects non-empty set, I don't care which."

That's not what it's doing; it's explicitly documented as having a particular order; it happens to be what appears first in the document.  It doesn't have to be exactly like regular expressions or XPATH or anything else; it has to be well-documented and convenient for the problem it's there to solve.
I agree with putting in a "+" or "*" operator at some future date to get unions.

Okay, I'm going to step aside on this one. :)
I think the syntax and behavior here are okay and I don't want to hold this up with circular discussions.  Sorry this was a derail.

I think this generally looks OK, but as noted above, I want to verify we're not introducing a breaking change for elements in the default namespace (i.e. xmlns:).

https://github.com/dpla/KriKri/commit/2d14c17194f3d3fa2fa1645d12bfb50af0667b2e changes the | handling again to do what @no-reply suggested with moving the | up to Krikri::Parser::Value#[].   This avoids redundancy between the JSON and XML parsers and changes the order of operation back to the way it was originally intended.

:rocket: this looks good to me.
I had a quick question about an implementation detail on JsonParser, but it's very minor and I'm probably just not following the program's logic properly.
I'm :+1: to merge; doubly so if my confusion can be cleared up. :)

:100:
@anarchivist Are you :+1: to :squash:

:ok_hand:

Squashed, and CI is running ...

Thanks @markbreedlove!

Sure thing, thanks for your help!


ERROR：rosrun kinect2_viewer kinect2_viewer

$ rosrun kinect2_viewer kinect2_viewer
munmap_chunk(): invalid pointer
Aborted (core dumped)
Before, I run  roslaunch kinect2_bridge kinect2_bridge.launch successfully , But this last step I fail, why?

I have the same problem as you, but the error is not the same，mine is
[rospack] Error: package 'kinect2_viewer' not found


Available PHP Versions are EOL

PHP 7.3 is the latest supported version on App Engine, and this version of PHP was EOL January 2021. Google has offered an out-dated version of PHP, this needs to change. PHP 7.4 and PHP 8 are the actively supported versions by PHP and Google should be offering at least these versions.
What is the ETA for supported PHP versions to be used on Google App Engine?

News???

@donmccasland Removed PHP 7.4 and 8.0 in this commit:
https://github.com/GoogleCloudPlatform/php-docker/commit/a2fe0f22949a3df0c280b77fac6aa0c83a6ff5da
I'm curious, where is the right location for this issue? It appears to be outside of this project.

@Stoyvo,
I trying to build a custom image with 7.4 and 8.0.
I can not understand why they don't support 7.4 or 8.0 versions

@Stoyvo, @donmccasland
Do you know how can I create my own php7.4/8 image using this code?
I tried to build using an alpine image, but it's not working.
https://hub.docker.com/r/digitalmanagerguru/appengine-php-webserver
You can see the docker settings here:
https://bitbucket.org/digitalmanagerguru/appengine-webserver/src/dev/
This image is MUCH smaller than google's one. :P

@andreladocruz I created a custom image, tried flexible environment, moved to Standard afterwards. I believe this gets most of the way.
https://gist.github.com/Stoyvo/e81ba08103fecee7d7711b4239245cef

@Stoyvo ,
thanks for your help! =)
I made an image too and now it's running on our staging environment.
Looking into your files, I saw we got almost the same approach, using alpine. =)
The final image is 80% smaller and deploys 50% quicker than google's one.
I will move it into production soon. =)

@Stoyvo ,
my base Dockerfile
`
FROM alpine:3.15.0
LABEL Maintainer="Dev Team<EMAIL_ADDRESS>Description="Base image for appengine php webserver"
RUN echo "http://dl-cdn.alpinelinux.org/alpine/edge/community" >> /etc/apk/repositories
RUN echo "http://dl-cdn.alpinelinux.org/alpine/edge/testing" >> /etc/apk/repositories
RUN apk update
Install Base Packages
RUN apk --no-cache add
bash
curl
nginx
procps
supervisor
Install PHP Packages and Extensions
RUN apk --no-cache add
php7
php7-bcmath
php7-ctype
php7-curl
php7-dev
php7-dom
php7-fileinfo
php7-fpm
php7-gd
php7-gmp
php7-intl
php7-json
php7-mbstring
php7-mysqli
php7-opcache
php7-openssl
php7-pcntl
php7-pdo
php7-pdo_mysql
php7-phar
php7-pear
php7-pecl-grpc
php7-pecl-protobuf
php7-pecl-redis
php7-posix
php7-simplexml
php7-soap
php7-tokenizer
php7-xml
php7-xmlwriter
php7-zip
Create symlink so programs depending on php still function
RUN rm -f /usr/bin/php
RUN ln -s /usr/bin/php7 /usr/bin/php
Install Composer
RUN curl -sS https://getcomposer.org/installer -o composer-setup.php
RUN php composer-setup.php --install-dir=/usr/local/bin --filename=composer
RUN rm -rf composer-setup.php
Configure nginx
COPY config/nginx.conf /etc/nginx/nginx.conf
Configure PHP-FPM
COPY config/fpm-pool.conf /etc/php7/php-fpm.d/www.conf
COPY config/php.ini /etc/php7/conf.d/custom.ini
Configure supervisord
COPY config/supervisord.conf /etc/supervisor/conf.d/supervisord.conf
Setup document root
RUN mkdir -p /var/www/html
Make sure files/folders needed by the processes are accessable when they run under the nobody user
RUN chown -R nobody.nobody /var/www/html &&
chown -R nobody.nobody /run &&
chown -R nobody.nobody /var/lib/nginx &&
chown -R nobody.nobody /var/log/nginx
Switch to use a non-root user from here on
USER nobody
Add application
WORKDIR /var/www/html
COPY --chown=nobody src/ /var/www/html/
Expose the port nginx is reachable on
EXPOSE 8080
Let supervisord start nginx & php-fpm
CMD ["/usr/bin/supervisord", "-c", "/etc/supervisor/conf.d/supervisord.conf"]
Configure a healthcheck to validate that everything is up&running
HEALTHCHECK --timeout=10s CMD curl --silent --fail http://<IP_ADDRESS>:8080/fpm-ping
`

@Stoyvo .. be my guest and do it with the data above.
I have no interest in this kind of bureaucracy or responsibility


[Python] ERROR: Failed building wheel for pyarrow

$ pip install pyarrow
Collecting pyarrow
  Downloading pyarrow-11.0.0.tar.gz (1.0 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.0/1.0 MB 273.8 kB/s eta 0:00:00
  Installing build dependencies ... |

done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Collecting numpy>=1.16.6
  Downloading numpy-1.24.2.tar.gz (10.9 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 10.9/10.9 MB 607.5 kB/s eta 0:00:00
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: pyarrow, numpy
  Building wheel for pyarrow (pyproject.toml) ... error
  error: subprocess-exited-with-error

  × Building wheel for pyarrow (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [292 lines of output]
      running bdist_wheel
      running build
      running build_py
      creating build
      creating build/lib.linux-x86_64-cpython-310
      creating build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/filesystem.py -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/serialization.py -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/flight.py -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/benchmark.py -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/plasma.py -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/substrait.py -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/jvm.py -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/pandas_compat.py -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/orc.py -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/fs.py -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/csv.py -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/cuda.py -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/cffi.py -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/conftest.py -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_generated_version.py -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/json.py -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_compute_docstrings.py -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/util.py -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/types.py -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/dataset.py -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/compute.py -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/feather.py -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/hdfs.py -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/__init__.py -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/ipc.py -> build/lib.linux-x86_64-cpython-310/pyarrow
      creating build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_dataset.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_types.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_filesystem.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_cuda.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_orc.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/deserialize_buffer.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_pandas.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_gandiva.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_serialization.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_feather.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_plasma.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_cuda_numba_interop.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_cython.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_hdfs.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_array.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_io.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_scalars.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_extension_type.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_memory.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_deprecations.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_plasma_tf_op.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_compute.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_cpp_internals.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_strategies.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_jvm.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_sparse_tensor.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/conftest.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_schema.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_convert_builtin.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_gdb.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_serialization_deprecated.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_ipc.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_fs.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/pandas_examples.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/util.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_csv.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/strategies.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/read_record_batch.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_udf.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_misc.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_exec_plan.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_table.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_substrait.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_cffi.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_adhoc_memory_leak.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/pandas_threaded_import.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_json.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/__init__.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_util.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/arrow_7980.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_builder.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_flight.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/arrow_16597.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/test_tensor.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      creating build/lib.linux-x86_64-cpython-310/pyarrow/vendored
      copying pyarrow/vendored/docscrape.py -> build/lib.linux-x86_64-cpython-310/pyarrow/vendored
      copying pyarrow/vendored/version.py -> build/lib.linux-x86_64-cpython-310/pyarrow/vendored
      copying pyarrow/vendored/__init__.py -> build/lib.linux-x86_64-cpython-310/pyarrow/vendored
      creating build/lib.linux-x86_64-cpython-310/pyarrow/interchange
      copying pyarrow/interchange/buffer.py -> build/lib.linux-x86_64-cpython-310/pyarrow/interchange
      copying pyarrow/interchange/column.py -> build/lib.linux-x86_64-cpython-310/pyarrow/interchange
      copying pyarrow/interchange/from_dataframe.py -> build/lib.linux-x86_64-cpython-310/pyarrow/interchange
      copying pyarrow/interchange/__init__.py -> build/lib.linux-x86_64-cpython-310/pyarrow/interchange
      copying pyarrow/interchange/dataframe.py -> build/lib.linux-x86_64-cpython-310/pyarrow/interchange
      creating build/lib.linux-x86_64-cpython-310/pyarrow/parquet
      copying pyarrow/parquet/core.py -> build/lib.linux-x86_64-cpython-310/pyarrow/parquet
      copying pyarrow/parquet/encryption.py -> build/lib.linux-x86_64-cpython-310/pyarrow/parquet
      copying pyarrow/parquet/__init__.py -> build/lib.linux-x86_64-cpython-310/pyarrow/parquet
      creating build/lib.linux-x86_64-cpython-310/pyarrow/tests/interchange
      copying pyarrow/tests/interchange/test_conversion.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/interchange
      copying pyarrow/tests/interchange/test_interchange_spec.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/interchange
      copying pyarrow/tests/interchange/__init__.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/interchange
      creating build/lib.linux-x86_64-cpython-310/pyarrow/tests/parquet
      copying pyarrow/tests/parquet/test_dataset.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/parquet
      copying pyarrow/tests/parquet/test_metadata.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/parquet
      copying pyarrow/tests/parquet/test_pandas.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/parquet
      copying pyarrow/tests/parquet/test_data_types.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/parquet
      copying pyarrow/tests/parquet/test_compliant_nested_type.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/parquet
      copying pyarrow/tests/parquet/common.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/parquet
      copying pyarrow/tests/parquet/conftest.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/parquet
      copying pyarrow/tests/parquet/test_encryption.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/parquet
      copying pyarrow/tests/parquet/test_basic.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/parquet
      copying pyarrow/tests/parquet/encryption.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/parquet
      copying pyarrow/tests/parquet/test_parquet_file.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/parquet
      copying pyarrow/tests/parquet/test_datetime.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/parquet
      copying pyarrow/tests/parquet/__init__.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/parquet
      copying pyarrow/tests/parquet/test_parquet_writer.py -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/parquet
      running egg_info
      writing pyarrow.egg-info/PKG-INFO
      writing dependency_links to pyarrow.egg-info/dependency_links.txt
      writing entry points to pyarrow.egg-info/entry_points.txt
      writing requirements to pyarrow.egg-info/requires.txt
      writing top-level names to pyarrow.egg-info/top_level.txt
      listing git files failed - pretending there aren't any
      reading manifest file 'pyarrow.egg-info/SOURCES.txt'
      reading manifest template 'MANIFEST.in'
      warning: no files found matching '../LICENSE.txt'
      warning: no files found matching '../NOTICE.txt'
      warning: no previously-included files matching '*.so' found anywhere in distribution
      warning: no previously-included files matching '*.pyc' found anywhere in distribution
      warning: no previously-included files matching '*~' found anywhere in distribution
      warning: no previously-included files matching '#*' found anywhere in distribution
      warning: no previously-included files matching '.git*' found anywhere in distribution
      warning: no previously-included files matching '.DS_Store' found anywhere in distribution
      no previously-included directories found matching '.asv'
      writing manifest file 'pyarrow.egg-info/SOURCES.txt'
      copying pyarrow/__init__.pxd -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_compute.pxd -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_compute.pyx -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_csv.pxd -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_csv.pyx -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_cuda.pxd -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_cuda.pyx -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_dataset.pxd -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_dataset.pyx -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_dataset_orc.pyx -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_dataset_parquet.pyx -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_exec_plan.pyx -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_feather.pyx -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_flight.pyx -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_fs.pxd -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_fs.pyx -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_gcsfs.pyx -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_hdfs.pyx -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_hdfsio.pyx -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_json.pyx -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_orc.pxd -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_orc.pyx -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_parquet.pxd -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_parquet.pyx -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_parquet_encryption.pxd -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_parquet_encryption.pyx -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_plasma.pyx -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_pyarrow_cpp_tests.pxd -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_pyarrow_cpp_tests.pyx -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_s3fs.pyx -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/_substrait.pyx -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/array.pxi -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/benchmark.pxi -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/builder.pxi -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/compat.pxi -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/config.pxi -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/error.pxi -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/gandiva.pyx -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/io.pxi -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/ipc.pxi -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/lib.pxd -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/lib.pyx -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/memory.pxi -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/pandas-shim.pxi -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/public-api.pxi -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/scalar.pxi -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/serialization.pxi -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/table.pxi -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/tensor.pxi -> build/lib.linux-x86_64-cpython-310/pyarrow
      copying pyarrow/types.pxi -> build/lib.linux-x86_64-cpython-310/pyarrow
      creating build/lib.linux-x86_64-cpython-310/pyarrow/includes
      copying pyarrow/includes/__init__.pxd -> build/lib.linux-x86_64-cpython-310/pyarrow/includes
      copying pyarrow/includes/libarrow_dataset.pxd -> build/lib.linux-x86_64-cpython-310/pyarrow/includes
      copying pyarrow/includes/libarrow.pxd -> build/lib.linux-x86_64-cpython-310/pyarrow/includes
      copying pyarrow/includes/libarrow_cuda.pxd -> build/lib.linux-x86_64-cpython-310/pyarrow/includes
      copying pyarrow/includes/libarrow_fs.pxd -> build/lib.linux-x86_64-cpython-310/pyarrow/includes
      copying pyarrow/includes/libarrow_substrait.pxd -> build/lib.linux-x86_64-cpython-310/pyarrow/includes
      copying pyarrow/includes/common.pxd -> build/lib.linux-x86_64-cpython-310/pyarrow/includes
      copying pyarrow/includes/libgandiva.pxd -> build/lib.linux-x86_64-cpython-310/pyarrow/includes
      copying pyarrow/includes/libplasma.pxd -> build/lib.linux-x86_64-cpython-310/pyarrow/includes
      copying pyarrow/includes/libarrow_dataset_parquet.pxd -> build/lib.linux-x86_64-cpython-310/pyarrow/includes
      copying pyarrow/includes/libarrow_python.pxd -> build/lib.linux-x86_64-cpython-310/pyarrow/includes
      copying pyarrow/includes/libarrow_feather.pxd -> build/lib.linux-x86_64-cpython-310/pyarrow/includes
      copying pyarrow/includes/libarrow_flight.pxd -> build/lib.linux-x86_64-cpython-310/pyarrow/includes
      creating build/lib.linux-x86_64-cpython-310/pyarrow/tensorflow
      copying pyarrow/tensorflow/plasma_op.cc -> build/lib.linux-x86_64-cpython-310/pyarrow/tensorflow
      copying pyarrow/tests/bound_function_visit_strings.pyx -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      copying pyarrow/tests/pyarrow_cython_example.pyx -> build/lib.linux-x86_64-cpython-310/pyarrow/tests
      creating build/lib.linux-x86_64-cpython-310/pyarrow/src
      creating build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow
      creating build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/CMakeLists.txt -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/api.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/arrow_to_pandas.cc -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/arrow_to_pandas.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/arrow_to_python_internal.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/benchmark.cc -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/benchmark.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/common.cc -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/common.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/csv.cc -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/csv.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/datetime.cc -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/datetime.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/decimal.cc -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/decimal.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/deserialize.cc -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/deserialize.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/extension_type.cc -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/extension_type.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/filesystem.cc -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/filesystem.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/flight.cc -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/flight.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/gdb.cc -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/gdb.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/helpers.cc -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/helpers.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/inference.cc -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/inference.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/init.cc -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/init.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/io.cc -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/io.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/ipc.cc -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/ipc.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/iterators.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/numpy_convert.cc -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/numpy_convert.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/numpy_internal.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/numpy_interop.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/numpy_to_arrow.cc -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/numpy_to_arrow.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/parquet_encryption.cc -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/parquet_encryption.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/pch.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/platform.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/pyarrow.cc -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/pyarrow.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/pyarrow_api.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/pyarrow_lib.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/python_test.cc -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/python_test.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/python_to_arrow.cc -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/python_to_arrow.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/serialize.cc -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/serialize.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/type_traits.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/udf.cc -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/udf.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      copying pyarrow/src/arrow/python/visibility.h -> build/lib.linux-x86_64-cpython-310/pyarrow/src/arrow/python
      creating build/lib.linux-x86_64-cpython-310/pyarrow/tests/data
      creating build/lib.linux-x86_64-cpython-310/pyarrow/tests/data/feather
      copying pyarrow/tests/data/feather/v0.17.0.version.2-compression.lz4.feather -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/data/feather
      creating build/lib.linux-x86_64-cpython-310/pyarrow/tests/data/orc
      copying pyarrow/tests/data/orc/README.md -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/data/orc
      copying pyarrow/tests/data/orc/TestOrcFile.emptyFile.jsn.gz -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/data/orc
      copying pyarrow/tests/data/orc/TestOrcFile.emptyFile.orc -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/data/orc
      copying pyarrow/tests/data/orc/TestOrcFile.test1.jsn.gz -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/data/orc
      copying pyarrow/tests/data/orc/TestOrcFile.test1.orc -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/data/orc
      copying pyarrow/tests/data/orc/TestOrcFile.testDate1900.jsn.gz -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/data/orc
      copying pyarrow/tests/data/orc/TestOrcFile.testDate1900.orc -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/data/orc
      copying pyarrow/tests/data/orc/decimal.jsn.gz -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/data/orc
      copying pyarrow/tests/data/orc/decimal.orc -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/data/orc
      creating build/lib.linux-x86_64-cpython-310/pyarrow/tests/data/parquet
      copying pyarrow/tests/data/parquet/v0.7.1.all-named-index.parquet -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/data/parquet
      copying pyarrow/tests/data/parquet/v0.7.1.column-metadata-handling.parquet -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/data/parquet
      copying pyarrow/tests/data/parquet/v0.7.1.parquet -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/data/parquet
      copying pyarrow/tests/data/parquet/v0.7.1.some-named-index.parquet -> build/lib.linux-x86_64-cpython-310/pyarrow/tests/data/parquet
      running build_ext
      creating /tmp/pip-install-xlefv161/pyarrow_f5b34280db0b4761a9c4fc405a0c2ded/build/temp.linux-x86_64-cpython-310
      -- Running cmake for PyArrow
      cmake -DCMAKE_INSTALL_PREFIX=/tmp/pip-install-xlefv161/pyarrow_f5b34280db0b4761a9c4fc405a0c2ded/build/lib.linux-x86_64-cpython-310/pyarrow -DPYTHON_EXECUTABLE=/usr/local/bin/python -DPython3_EXECUTABLE=/usr/local/bin/python -DPYARROW_CXXFLAGS= -DPYARROW_BUILD_CUDA=off -DPYARROW_BUILD_SUBSTRAIT=off -DPYARROW_BUILD_FLIGHT=off -DPYARROW_BUILD_GANDIVA=off -DPYARROW_BUILD_DATASET=off -DPYARROW_BUILD_ORC=off -DPYARROW_BUILD_PARQUET=off -DPYARROW_BUILD_PARQUET_ENCRYPTION=off -DPYARROW_BUILD_PLASMA=off -DPYARROW_BUILD_GCS=off -DPYARROW_BUILD_S3=off -DPYARROW_BUILD_HDFS=off -DPYARROW_USE_TENSORFLOW=off -DPYARROW_BUNDLE_ARROW_CPP=off -DPYARROW_BUNDLE_BOOST=off -DPYARROW_BUNDLE_CYTHON_CPP=off -DPYARROW_BUNDLE_PLASMA_EXECUTABLE=on -DPYARROW_GENERATE_COVERAGE=off -DPYARROW_BOOST_USE_SHARED=on -DPYARROW_PARQUET_USE_SHARED=on -DCMAKE_BUILD_TYPE=release /tmp/pip-install-xlefv161/pyarrow_f5b34280db0b4761a9c4fc405a0c2ded
      error: command 'cmake' failed: No such file or directory
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for pyarrow

pip version pip 23.0.1
poetry --version poetry 1.4.0
python --version Python 3.10.2

Could you install CMake and try again?

      error: command 'cmake' failed: No such file or directory

Just installing cmake will typically not be enough, you will also need to have Arrow C++ installed.

@kou I've installed pip install cmake but still not able to install pyarrow.

@jorisvandenbossche thanks for immediate response
I'm trying to create poetry.lock file from above the toml file; when I attempted to install poetry, pyarrow was not successful. I personally installed cmake after noticing that it was unable to locate it.

What OS are you using? If you are just trying to install a released version of pyarrow, ideally you get a binary wheel, but it seems it is installing from a source sdist (and that requires a whole of set of additional non-python dependencies, so that is not expected to work out of the box). But normally it should download a wheel, and will only fallback to a source archive if there is no wheel available compatible with your platform.

I'm using below mentioned image into the docker container.
Image Name - python-build-3.10.2-alpine3.15:3.0.7
Docker Desktop 4.17.1 (101757)

having this issue all of a sudden...there a solution, workaround?

You might be using Python 3.12? In that case, there are no wheels yet for pyarrow for Python 3.12, the solution is to wait a month with using Python 3.12.

You might be using Python 3.12? In that case, there are no wheels yet for pyarrow for Python 3.12, the solution is to wait a month with using Python 3.12.

yes that's correct. confirmed by rolling back to python 3.11

https://stackoverflow.com/questions/77318492/building-wheel-for-pyarrow-pyproject-toml-did-not-run-successfully

There's a similar problem now with Python 3.13. In my opinion building from the sdist should be an option even if the new Python is not officially supported.

Going to close this issue, as it was worked around by waiting on the wheel (building fro source requires more manual steps).

There's a similar problem now with Python 3.13

I opened an issue to start tracking providing wheels for Python 3.13
(ideally we would indeed improve the building from source/sdist, but that's a more general issue)


[Site] Footer - misaligned

Description

Environment:

Browser: Safari

Contributor Resources

See the Contributing to getnighthawk.dev Website
See the Project Site section of GetNighthawk project doc

Couldn't reproduce this error on Safari. What's the screen-size shown in the screenshot?

This issue has been fixed by this Pull Request - https://github.com/layer5io/getnighthawk/pull/85


Ability to show an additional background permanently in the editor

For the Additional Backgrounds feature, could we have it so that clicking an additional background keeps it on-screen until you either click it again (to undo) or click another additional background? (in other words, not have PartyPlanner go back immediately to the main background when you release the mouse click)
ty c:

There is now an "eye" button for each additional background (similar to the photoshop layer visibility icon). Clicking this button toggles the visibility of the button, so it is no longer based on mouse press.
Fixed in 1ac64460792fa6e451829d77f8cd0bd329f91796.

There is now an "eye" button for each additional background (similar to the photoshop layer visibility icon). Clicking this button toggles the visibility of the button, so it is no longer based on mouse press.
Fixed in 1ac64460792fa6e451829d77f8cd0bd329f91796.


Naming of JavaScript method in generated code

The current method name is ContractName_ClauseName but this is unnecessary inside a class and could be replaced by ClauseName.

Closed by 7c67ba5.


COUNTER LOSING TICKS

Not sure what happened. And multiple people are reporting the issue. But using most weapons (bowfa and trident). It will go 4 then 3 then glitch out and go back to 4... have no idea why and haven't found any solutions. It was working fine a week ago

@ngraves95  Are you still actively working on this plugin?

I haven't been able to repro with whip and toxic trident, for example.

Is this still an issue?
If so, can you include a gif of this happening?

I haven't been able to repro with whip and toxic trident, for example.
1. Is this still an issue?

2. If so, can you include a gif of this happening?

The plugin just started working again about a month ago.  Not having any issues atm besides the new blowpipe ornament kit not working.

Ok - sounds like there might have been a bug and fix in one of this plugins dependencies (like ItemManager, etc). I will close this until it becomes an issue again.


Missing latest version on App Store

There is 1.0.3 version on App Store, but here is 1.0.4.
Could you update App Store version?
Thank you

As the release notes state, 1.0.4 is a non-shipping release. It's functionally identical to 1.0.3. Versions will sync in the next release.


[DEV-36914] Handle objects pickled in Python 2 with datetimes

After this change is merged I'll open a PR to update the web requirements file.

@Jaidan I think it will be safe since this doesn't ever actually happen (we would see Sentry errors) except in Python 3.


Issue with callback manager for verbose output

Privileged issue

[X] I am a LangChain maintainer, or was asked directly by a LangChain maintainer to create an issue here.

Issue Content
Following this tutorial: https://python.langchain.com/v0.1/docs/modules/agents/quick_start/#create-the-agent

@eyurtsev I can take this.

identical to: https://github.com/langchain-ai/langchain/issues/26773


Initial commit of N number of objects functionality

Adds fields, new classes, and changes to existing BDI Processing that will allow users to define N number of Additional objects to be created in JSON format (defined by BDI_DynamicSourceGroup).  These dynamic sources will have their processing results stored back into the text field in JSON format rather than being placed in its own field on the DataImport record.  Note that the objects created via this method must children or parents of an existing object mapping and can't currently be child/parents of other dynamically sourced additional objects.
Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata

@melissabarber The needed review from you is on the new Additional_Object_JSON__c field on the DataImport__c object

**lurch: attach W-036291

Tracking W-036291


chore(main): release 0.0.2

:robot: I have created a release beep boop
0.0.2 (2024-08-17)
Bug Fixes

add robots.txt (05930f0)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.0.2
:sunflower:


Doc: Update documentation to build cleanly in Sphinx 3.

This also requires Sphinx 3 or better to build the documentation.
There are a number of new C and C++ domain directives in Sphinx 3, which makes the docs more expressive. Sphinx 3 also does noticeably more syntax checking, which broke many bits of the existing documentation.

[approve ci docs]

[approve ci docs]

The doc/Pipfile specifies Sphinx 3.x and the CI systems are now running Sphinx 3.x (thanks @zwoop ). This change should be good to go.


Submariner IPAM controller

This change is

scripts/release, line 14 at r3 (raw file):

docker tag ${REPO}/submariner-route-agent:dev ${REPO}/submariner-route-agent:${DOCKER_TAG#"v"}
docker tag ${REPO}/submariner-route-agent:dev ${REPO}/submariner-route-agent:"${TRAVIS_COMMIT:0:7}"
docker tag ${REPO}/submariner-route-agent:dev ${REPO}/submariner-globalnet:${DOCKER_TAG#"v"}

^ typo issue: you're tagging the route-agent as globalnet

Sorry for the yellow dot from reviewable, I have disabled that behavior... I hope it will stop doing it

I re-enabled the reviewable CI part, even if it will remain yellow, otherwise it turns red. I will finally disable it when this patch is done.

I see all comments handled or negotiated for follow ups, so merging. Awesome work!