Create Version 1.1 Release

Describe the Task
This task provides final checklist of tasks for finalizing the release of Version 1.1 (see milestone for details).
Initiate release:

[x] Define scope for pre-release testing and document below
[x] Draft Release Page
[x] Clean up AWS account, feature branches, etc.
[x] Update UG release page with notes

RC1 Pre-release Testing:

[x] Create release branch: release_v1.1
[x] “pip freeze” on release branch and main branch to freeze versions of dependencies.
[x] Create release candidate tag: v1.1.0_rc1
[x] Reinstall system
[x] Several variants of UI Forecasts (TBD)

RCx Pre-release Testing: (if needed)

[ ] Create tag: v1.X.0_rcx

Finalize release:

[ ] Review public website content, update as necessary (check disclaimer links)
[x] Edit versions in appropriate places (Line 5 of setup.py -- now edit VERSION and RELEASE_DATE in python/src/wrfcloud)
[ ] Merge release branch to develop - Need to do an additional PR/commit to develop change frozen versions
[x] Merge release branch to main
[x] Create final official release tag from main branch: v1.1.0
[x] Check RTD documentation: release version (from release tag) and stable (from main branch) labels)
[x] Update & Publish Release Page

Time Estimate
1 week
Sub-Issues
Consider breaking the task down into sub-issues.

[ ] Add a checkbox for each sub-issue here.

Relevant Deadlines
July 14, 2023
Define the Metadata
Assignee

[ ] Select engineer(s) or no engineer required
[ ] Select scientist(s) or no scientist required

Labels

[ ] Select component(s)
[ ] Select priority

Projects and Milestone

[ ] Select Project
[ ] Select Milestone as the next official version or Backlog of Development Ideas

Task Checklist

[ ] Complete the issue definition above, including the Time Estimate.
[ ] Fork this repository or create a branch of develop.
Branch name: feature_<Issue Number>/<Description>
[ ] Complete the development and test your changes.
[ ] Add/update log messages for easier debugging.
[ ] Add/update tests.
[ ] Add/update documentation.
[ ] Push local changes to GitHub.
[ ] Submit a pull request to merge into develop.
Pull request: feature <Issue Number> <Description>
[ ] Define the pull request metadata, as permissions allow.
Select: Reviewer(s), Project, and Development issue
Select: Milestone as the next official version
[ ] Iterate until the reviewer(s) accept and merge your changes.
[ ] Delete your fork or branch.
[ ] Close this issue.

@hahnd - The release has been published and v1.1.0 tagged. Please proceed with the reinstall and testing for the release. Thanks!

The system was re-installed and I completed a successful model run:
https://app.wrfcloud.com/view/W8E1721A1F6

@hahnd - Great thanks!


adds support for authenticated crawling

closes #209

To setup new project
$ ./katana -np dvwa

To use created project for crawling
$ ./katana -cp dvwa ... // and other args


Add 2024 embedded-wg micro survey

As discussed here: https://github.com/rust-embedded/wg/pull/787
We'd like to request that this survey runs until Thursday September 19th, to give us a little more than 4 full calendar weeks.
CC @Kobzol

Thank you! I already saw this survey on the Embedded WG repo, so looks good from my side. @apiraino Could you please take a quick look and let me know if you have any concerns? If not, I'll start filling the survey questions in SurveyHero.

looks cool!
I'm also curious about the results :slightly_smiling_face: !

Thank you! I filled out the survey in SurveyHero.


New settings:  Linking to a setting no longer turns that setting yellow.

20:25 <agentlame> Linking to a setting no longer turns that setting yellow. :(   https://www.reddit.com#?tbsettings=rreasons&setting=alwaysshow
20:25 <dakta> I don’t know how help links are supposed to work, but I’ll see if I can fix it. I’ve still got some other cleanup to do, but there are a few things that I don’t want to do like import/export.
20:27 <creesch> dakta: afaik the help thing was really simple, just triggered the popup. Probably an easy fix.
20:27 <agentlame> dakta: https://github.com/creesch/reddit-moderator-toolbox/blob/master/modules/modbar.js#L716

@Dakta

What did this used to look like?  Something like:

Yup pretty much

Could it be because reddit strips the hashtag query off?  Check the url after the page loads: https://www.reddit.com#?tbsettings=rreasons&setting=alwaysshow
I'm going to bed but here's a solution I just sorta tested and it good:
Append the id of the element in question to the url hash (i.e. https://www.reddit.com#element_id) and you can select it with the css pseudo selector ':target' for styling.

Nah it is because of dakta refactoring settings and missing this :p

Could it be because reddit strips the hashtag query off? Check the url after the page loads: https://www.reddit.com#?tbsettings=rreasons&setting=alwaysshow

We do that, brah.  After we're sure it's a TB query.

It should be noted that @Dakta isn't to blame here (I think) but a committed change around the same time.


SIGSEGV from cuckatoo_mean_cpu plugin; compat. plugin runs fine

Date: 19. Oct. 2018
Immediately after cuckatoo_mean_cpu plug-in starts mining, a segmentation fault occurs. At the same configuration cuckatoo_mean_compat_cpu works without problems. Tested Tromp's standalone solver mean29x8 without any issues.
Reproducibility: every time
System: VirtualBox VM with Debian 9.5, GCC 6.3.0, 8 GB RAM, i7-4790k CPU, 4 virtual cores
Config:
[[mining.miner_plugin_config]]
edge_bits = 29
type_filter = "cuckatoo_mean_cpu"
[mining.miner_plugin_config.device_parameters.0]
NUM_THREADS = 4
Backtrace from GDB:
Thread 14 "mining_controll" received signal SIGSEGV, Segmentation fault.(LWP 19471)

(gdb) info threads
  Id   Target Id         Frame
  1    Thread 0x7ffff7fe70c0 (LWP 19452) "grin-miner" 0x00007ffff73667dd in nanosleep () at ../sysdeps/unix/syscall-template.S:84
  3    Thread 0x7ffff63fe700 (LWP 19457) "grin-miner" pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
  5    Thread 0x7ffff5bff700 (LWP 19459) "grin-miner" pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
  6    Thread 0x7ffff65ff700 (LWP 19460) "ui" 0x00007ffff6e7f67d in poll () at ../sysdeps/unix/syscall-template.S:84
  7    Thread 0x7ffff55ff700 (LWP 19461) "mining_controll" 0x00007ffff73667dd in nanosleep () at ../sysdeps/unix/syscall-template.S:84
  8    Thread 0x7ffff53fe700 (LWP 19462) "client_controll" 0x00007ffff73667dd in nanosleep () at ../sysdeps/unix/syscall-template.S:84
  11   Thread 0x7ffff49ff700 (LWP 19471) "mining_controll" 0x00007ffff73667dd in nanosleep () at ../sysdeps/unix/syscall-template.S:84
  12   Thread 0x7ffff3dff700 (LWP 19472) "mining_controll" 0x00007ffff6e5828d in nanosleep () at ../sysdeps/unix/syscall-template.S:84
  13   Thread 0x7ffff31ff700 (LWP 19473) "mining_controll" clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:80
* 14   Thread 0x7fff0c5ff700 (LWP 19474) "mining_controll" edgetrimmer::genUnodes (this=this@entry=0x7ffff31fd970, id=id@entry=0, uorv=uorv@entry=0)
    at /home/sa/.cargo/git/checkouts/cuckoo-miner-4752934f0f1f2bfe/7862dfe/src/cuckoo_sys/plugins/cuckoo/src/cuckatoo/mean.hpp:347
  15   Thread 0x7fff0bdfe700 (LWP 19475) "mining_controll" _mm256_load_si256(long long __vector(4) const*) (__P=<optimized out>) at /usr/lib/gcc/x86_64-linux-gnu/6/include/avxintrin.h:884
  16   Thread 0x7fff0b5fd700 (LWP 19476) "mining_controll" clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:80
(gdb) bt
#0  edgetrimmer::genUnodes (this=this@entry=0x7ffff31fd970, id=id@entry=0, uorv=uorv@entry=0)
    at /home/sa/.cargo/git/checkouts/cuckoo-miner-4752934f0f1f2bfe/7862dfe/src/cuckoo_sys/plugins/cuckoo/src/cuckatoo/mean.hpp:347
#1  0x00007ffff4035942 in edgetrimmer::trimmer (id=0, this=0x7ffff31fd970) at /home/sa/.cargo/git/checkouts/cuckoo-miner-4752934f0f1f2bfe/7862dfe/src/cuckoo_sys/plugins/cuckoo/src/cuckatoo/mean.hpp:1010
#2  etworker (vp=<optimized out>) at /home/sa/.cargo/git/checkouts/cuckoo-miner-4752934f0f1f2bfe/7862dfe/src/cuckoo_sys/plugins/cuckoo/src/cuckatoo/mean.hpp:1049
#3  0x00007ffff735d494 in start_thread (arg=0x7fff0c5ff700) at pthread_create.c:333
#4  0x00007ffff6e88acf in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97

I'm closing the issue since it no longer appears in the latest version (as of 26. Oct.).


build.xml: introduce property verbose

Before this commit the generation of schemata and compiled ODDs gave very verbose feedback. This resulted in a very long and hardly graspable output on the commandline. Especially in the GitHub Action context this made the build process hard to debug and required a lot of scrolling. This commit introduces the following changes:

The property verbose will analyze whether Ant was called with the -verbose or -v option and store this as boolean; defaults to false.
The verbose property will be propagated to the  tei:anttasks to make the verbosity of the schema and compiled-odd generation controllable.

Good thing, thanks.
Can we use this for the loadresource stuff too which adds quite some extra output? There is a quiet option for loadresource that could consume the value of verbose property?

We could also use a looger to write all the output to a file instead of the console? Cf. https://stackoverflow.com/a/20643091

We could also use a looger to write all the output to a file instead of the console? Cf. https://stackoverflow.com/a/20643091

Yes, but probably overkill for now. Maybe open an issue for a solid logging design.

Good thing, thanks.
Can we use this for the loadresource stuff too which adds quite some extra output? There is a quiet option for loadresource that could consume the value of verbose property?

The -quiet option can also be submitted on the ant call but that would override -verbose. So if you call it with quite level="verbose"will not be printed only warnings and errors. The logging level can be set on all echo task and some other.

Good thing, thanks.
Can we use this for the loadresource stuff too which adds quite some extra output? There is a quiet option for loadresource that could consume the value of verbose property?

Just read the documentation of the loadresource/@quiet will add it to this PR.

quite a typo in commit message ;)

sorry for the hassle

@ahankinson May I ask you to have a quick look at this PR, too?


wifi: airoc: remove dependency on CYHAL

Removing dependency on cyhal in airoc wifi driver.
It need to build airoc wifi driver with different than PSoC 6 Soc like STM32

hi @jukkar , can we merge this?


Deprecate the fact that shorted functors extend widened ones.

So deprecate the fact that, for example, ByteConsumer extends java.util.function.IntConsumer.
This fact has lead to some need some unfortunate extra overloads to avoid ambiguity.
These overloads were already marked deprecated, so when we remove the widened
superinterface we should also remove these methods.
Example of a deprecated method that should be co-removed is
ByteIterable.forEach(java.util.function.IntConsumer).

I'm confused. Why deprecate? This stuff has never been distributed AFAIK.

For Predicate, you are right. We could just make the change.
But the Consumers were introduced in 8.0.0 it seems.

Ok. At the same time, as I was discussing in #197 ,  predicates and consumers are exactly the case in which implementing the JDK interface,  even if the type does not match, makes perfect sense. Say you have a LongConsumer computing statistics on a stream: it is natural to use it on a CharStream. There is no unsafe type conversion. The situation is very different with operators.


API scan local image failed

curl -k -H "Content-Type: application/json" -H "X-Auth-Token: $TOKEN" -d '{"request": {"tag": "vtest.11", "repository": "docker.hanweb.com/project/jss/jszwfw/wuwei-test", "scan_layers": true}}' "https://$controllerIP:10443/v1/scan/repository"
When calling API interface for local image scanning, the following error is returned:
{"code":26,"error":"Fail to scan repository","message":"container API call error"}20220818_150021 [ooo] able to scan ubuntu:16.04 image: pass-0
Can the API interface scan the local server？

To scan the local image, docker socket should be mounted to the scanner, and the scanner has to be running on the same host of the image.


Use helm instead of anything

Its is useable on Helm as is, save for the lack of shortcuts on the actions (Open Browser/Insert Subtree.)

@zakame how are you using this with helm? There's no helm in the codebase as far as I can see.

https://github.com/gongo/org-redmine/pull/23#issuecomment-180163505

Thanks @gongo ! :+1:
@kostajh I just installed it back then, but didn't notice until now that it pulled in Anything.el :D


Improve README

There's some good documentation on the doc's site, but the README is kinda lacking. It'd be nice to better highlight the feature it supports as well as a quick way for people to try it out.
Right now, I feel like folks read the README and are asking themselves: "Now what?"
I'm opened to ideas on how to make the README better!

I agree, I've seen a few projects recently with some really slick readme files
I might take this one on and see if we can make it a bit more friendly/snazzy and such,
I'm thinking perhaps some more on a quick start, maybe a star graph etc,
On a similar vein I'm wondering if we should do some issue templates for things like new provider requests, what do you think?


[Settings] Minor UI fixes

Summary of the Pull Request
This PR solves a couple of minor Settings UX issues:
#17943 - WordWrapping is now on for the Header text
#16884 - The TextBox in the Expander will now be disabled
#17110 - Fixed margins
Quality Checklist

[x] Linked issue: #17943, #16884, #17110
[ ] Communication: I've discussed this with core contributors in the issue.
[ ] Tests: Added/updated and all pass
[ ] Installer: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Docs: Added/ updated
[ ] Binaries: Any new files are added to WXS / YML

[ ] No new binaries
[ ] YML for signing for new binaries
[ ] WXS for installer for new binaries

Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.

I don't think there's an issue for it (yet) but do you know why these presets have a bit of a different color when disabled?

Text color for this Numberbox is always the same color gray

Suggestion for General page (with the risk of going off-topic?)

@Jay-o-Way ListViews seem to be using different brushes for the disabled states.. but we do not customize those so it's a WinUI related thing. Not taking this along in this PR.


'import cvxpy': AttributeError: 'module' object has no attribute 'utilities'

I see this same error in current builds at: https://readthedocs.org/builds/cvxpy/1471353/
I've downloaded the latest master from github but still have this error.
It appears to be related to circular imports.

import cvxpy
Traceback (most recent call last):
File "", line 1, in
File "U:\python\lib\python\cvxpy-0.2.1-py2.7.egg\cvxpy_init_.py", line 20, in
from atoms import *
File "U:\python\lib\python\cvxpy-0.2.1-py2.7.egg\cvxpy\atoms_init_.py", line 20, in
from geo_mean import geo_mean
File "U:\python\lib\python\cvxpy-0.2.1-py2.7.egg\cvxpy\atoms\geo_mean.py", line 20, in
import cvxpy.utilities as u
AttributeError: 'module' object has no attribute 'utilities'

Hello steve 3141 !
I am facing with the same problem currently but it has not gone away like you. Did you have a solution ? Because even if you explained why is there a problem, i don't know what i must do to fix it.
Thank you for your help.

Same Problem:
File "/usr/lib/python3.5/site-packages/cvxpy/constraints/bool_constr.py", line 23, in
import cvxpy.utilities.performance_utils as pu
AttributeError: module 'cvxpy.utilities' has no attribute 'performance_utils'


Validate title and show/select author.

Validates there's a title present, an article without a title can't be selected from the listing therefore it is hard to edit.
Also allows you to pick an author for an article (useful when migrating from another wiki). Defaults the author to the currently logged in user.

@brupm Nice PR, thanks.


Can't run python kadenze-dl.py

Sorry, I can't get through this error, I tried installing all de WHL files in the requirements.txt separately but I can't figure out what to do. I'm a basic user tried to figure things out. Thanks
I get this in the Windows PowerShell;
Traceback (most recent call last):
  File "kadenze-dl.py", line 10, in <module>
    main()
  File "kadenze-dl.py", line 5, in main
    client = KadenzeClient()
  File "C:\Users\Eze\Downloads\kadenze-dl-master\kadenze-dl\kadenzeclient.py", line 10, in __init__
    self.conf = Settings()
  File "C:\Users\Eze\Downloads\kadenze-dl-master\kadenze-dl\settings.py", line 7, in __init__
    self.config = yaml.load(configfile)
  File "C:\Python38\lib\site-packages\yaml\__init__.py", line 72, in load
    return loader.get_single_data()
  File "C:\Python38\lib\site-packages\yaml\constructor.py", line 35, in get_single_data
    node = self.get_single_node()
  File "C:\Python38\lib\site-packages\yaml\composer.py", line 36, in get_single_node
    document = self.compose_document()
  File "C:\Python38\lib\site-packages\yaml\composer.py", line 55, in compose_document
    node = self.compose_node(None, None)
  File "C:\Python38\lib\site-packages\yaml\composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "C:\Python38\lib\site-packages\yaml\composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "C:\Python38\lib\site-packages\yaml\composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "C:\Python38\lib\site-packages\yaml\composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "C:\Python38\lib\site-packages\yaml\composer.py", line 64, in compose_node
    if self.check_event(AliasEvent):
  File "C:\Python38\lib\site-packages\yaml\parser.py", line 98, in check_event
    self.current_event = self.state()
  File "C:\Python38\lib\site-packages\yaml\parser.py", line 449, in parse_block_mapping_value
    if not self.check_token(KeyToken, ValueToken, BlockEndToken):
  File "C:\Python38\lib\site-packages\yaml\scanner.py", line 116, in check_token
    self.fetch_more_tokens()
  File "C:\Python38\lib\site-packages\yaml\scanner.py", line 248, in fetch_more_tokens
    return self.fetch_double()
  File "C:\Python38\lib\site-packages\yaml\scanner.py", line 652, in fetch_double
    self.fetch_flow_scalar(style='"')
  File "C:\Python38\lib\site-packages\yaml\scanner.py", line 663, in fetch_flow_scalar
    self.tokens.append(self.scan_flow_scalar(style))
  File "C:\Python38\lib\site-packages\yaml\scanner.py", line 1146, in scan_flow_scalar
    chunks.extend(self.scan_flow_scalar_non_spaces(double, start_mark))
  File "C:\Python38\lib\site-packages\yaml\scanner.py", line 1219, in scan_flow_scalar_non_spaces
    raise ScannerError("while scanning a double-quoted scalar", start_mark,
yaml.scanner.ScannerError: while scanning a double-quoted scalar
  in "configuration.yml", line 6, column 11
found unknown escape character '#'
  in "configuration.yml", line 6, column 15

Config file was written bad, sorry


gitup no longer able to synchronize src on 13-STABLE

I believe that this is following this commit: https://cgit.freebsd.org/src/commit/?id=04c4bd7f7b525b1627304894e3413693e945bc0d
gitup started erroring out when trying to synchronize the repo.  I tried to delete /var/db/gitup/src and with an empty /usr/src directory but the same thing happens.
$ gitup src
# Scanning local repository...
# Host: git.freebsd.org
# Port: 443
# Repository Path: /src.git
# Target Directory: /usr/src
# Want: cb96c6ba30cb917bc1223247caa93d135818199a
# Branch: stable/13
# Action: clone
gitup: load_object: local file for object 3331601f6dc50ef2c9779c1656218701b48b276c -- /usr/src/sys/contrib/openzfs/scripts/zfs-images not found: No such file or directory

That's with gitup 0.94 and this config file:
# $FreeBSD$
#
# Default configuration options for gitup.conf.
{
	"defaults" : {
		"host"           : "git.freebsd.org",
		"port"           : 443,
		"verbosity"      : 1,
		"work_directory" : "/var/db/gitup",
	},

	"ports" : {
		"repository" : "/ports.git",
		"branch"     : "quarterly",
		"target"     : "/usr/ports",
		"ignores"    : [
			"distfiles",
			"packages",
			"INDEX-13",
		]
	},

	"src" : {
		"repository" : "/src.git",
		"branch"     : "stable/13",
		"target"     : "/usr/src",
	},

}

Same here, trying to fetch fresh 13-STABLE and it fails. Trace attached
gdb.txt

Same here, also fails for current. Looks like the last openzfs import did something that getup doesn't like.

Specifically, it looks like the problem is a remote repository module:
diff --git a/sys/contrib/openzfs/.gitmodules b/sys/contrib/openzfs/.gitmodules
index d400f10a7e63..9eaa2b0495dc 100644
--- a/sys/contrib/openzfs/.gitmodules
+++ b/sys/contrib/openzfs/.gitmodules
@@ -1,3 +1,3 @@
 [submodule "scripts/zfs-images"]
 	path = scripts/zfs-images
-	url = https://github.com/zfsonlinux/zfs-images
+	url = https://github.com/openzfs/zfs-images

The stack trace shows the file type (0160000) as "whiteout" (S_IFWHT)? Never heard of that before now.
"git" with "--depth 1" just shows it as an empty directory. Seems like the proper thing to do would be the same.

Some more info: https://lists.freebsd.org/archives/freebsd-git/2021-June/000015.html
We are probably going to just delete sys/contrib/openzfs/scripts/zfs-images in the FreeBSD tree

Specifically, it looks like the problem is a remote repository module:
diff --git a/sys/contrib/openzfs/.gitmodules b/sys/contrib/openzfs/.gitmodules
index d400f10a7e63..9eaa2b0495dc 100644
--- a/sys/contrib/openzfs/.gitmodules
+++ b/sys/contrib/openzfs/.gitmodules
@@ -1,3 +1,3 @@
 [submodule "scripts/zfs-images"]
 	path = scripts/zfs-images
-	url = https://github.com/zfsonlinux/zfs-images
+	url = https://github.com/openzfs/zfs-images

The stack trace shows the file type (0160000) as "whiteout" (S_IFWHT)? Never heard of that before now.
"git" with "--depth 1" just shows it as an empty directory. Seems like the proper thing to do would be the same.

Interesting.
$ git ls-tree 584b4410bb044e4d67454b8daaefa9321f5d88ae
100644 blob 5621a6e147a0e3d934f1f35cd6ae71f0a65dbd4b	.gitignore
100644 blob f59826fe6bc87241063e25e8f53873f308bead01	Makefile.am
100755 blob 71cf521666a69ed4300e4b0e3542ae472c6e32c5	commitcheck.sh
100644 blob 8268315b336187326d712c787e8f3dd4118c31b8	common.sh.in
100755 blob d19718ecf443a1591fb414c4db79f46f5dea4cca	cstyle.pl
100755 blob 8649b93183a2bc81b0e8cdecd1e85ff198f22af1	dkms.mkconf
100755 blob 81de475877dddd3ff1e5db48886168af0b8761f4	dkms.postbuild
100755 blob 5112cc807f678055135bb046a3f67a474ce94c2e	enum-extract.pl
100755 blob 240cde3106a787ea1f0a861ad860daf077a6c718	kmodtool
100755 blob f5c743b137991ff269435c611c1db786e3cbc25a	make_gitrev.sh
100755 blob 186d94639a5651d2ff2c26365ae936b79731b655	man-dates.sh
100755 blob 87e817500b1b2e55205eae8e6014fd29e5b76d08	paxcheck.sh
100755 blob 02b4922006f270933e4771867db3aa2f080caa8a	zfs-helpers.sh
160000 commit 3331601f6dc50ef2c9779c1656218701b48b276c	zfs-images
100755 blob 45e08473d35cf5340664f0d906b22444c32446e8	zfs-tests.sh
100755 blob 2f5f3f8fdb54d452693cd1c8e0ff7dc342b1b838	zfs.sh
100755 blob 99824d6dd4afbb2c44e57e43d1aaecc8f2efcbce	zfs2zol-patch.sed
100755 blob 56dfbadae47b7a4207864c58018b4a728ed5f853	zimport.sh
100755 blob bbe326aa07e08347870adb8dd7041819191503ce	zloop.sh
100755 blob bb6d9faac450e88319106e093af33c2b135f2601	zol2zfs-patch.sed

The tree object directly points to a commit! I didn't know git could do that. I thought only commits would point to commits (and trees) and trees would point to trees and blobs.
That's a so-called "gitlink" apparently.  I think that this is how git remembers which specific revision of a submodule was checked out.  And git encodes it with a file mode that matches our S_IFWHT "whiteouts".
/*
 * A "directory link" is a link to another git directory.
 *
 * The value 0160000 is not normally a valid mode, and
 * also just happens to be S_IFDIR + S_IFLNK
 */
#define S_IFGITLINK     0160000
#define S_ISGITLINK(m)  (((m) & S_IFMT) == S_IFGITLINK)

And yeah I think that unless you specifically ask to checkout submodules (which gitup doesn't do and probably doesn't need to do), you can just ignore this tree entry.

git encodes it with a file mode that matches our S_IFWHT

Well, that is curious. Presumably git itself always interprets that as a special case and will never pass such a mode to system calls, so it's only 3rd party implementations (or git bugs) that might encounter this issue.

checkout submodules (which gitup doesn't do and probably doesn't need to do)

FreeBSD's current stance is we won't use submodules in the upstream tree. It's unlikely, but possible, that this will change at some point in the future.

Well, that is curious. Presumably git itself always interprets that as a special case and will never pass such a mode to system calls, so it's only 3rd party implementations (or git bugs) that might encounter this issue.

Yeah it's special-cased all over the git source and comments say it was chosen because it's an unused value on Linux. And it is sometimes just treated as if it were a directory.

I just committed a partial fix to get past the current breakage (but it's not a complete fix for supporting submodules -- still working on that).

I just committed a partial fix to get past the current breakage (but it's not a complete fix for supporting submodules -- still working on that).

This seems to work perfectly now. Thanks!
BTW, while testing I noticed some line ending differences in the files checked out by gitup and those in a git working directory for the same branch. They're the files listed in contrib/bc/.gitattributes. The .gitattributes got added fairly recently with a bc update. But it's not causing any problems.

I'm also seeing discrepancies with
contrib/bc/bc.vcxproj
contrib/bc/bc.vcxproj.filters
contrib/bc/bcl.vcxproj
contrib/bc/bcl.vcxproj.filters
in the packfiles I'm testing with so there's something awry.  Investigating...

I'm also seeing discrepancies with
contrib/bc/bc.vcxproj
contrib/bc/bc.vcxproj.filters
contrib/bc/bcl.vcxproj
contrib/bc/bcl.vcxproj.filters
in the packfiles I'm testing with so there's something awry. Investigating...

IIUC it's just newline normalization.  The .gitattribute file tells git to switch the CRLFs into LFs before checking in and turn them back into CRLFs when checking out.

https://github.com/johnmehr/gitup/issues/69#issuecomment-869225041

… partial fix to get past the current breakage …

Thanks, can it make it way to the ports collection?
I get gitup: load_object: local file for object 3331601f6dc50ef2c9779c1656218701b48b276c -- /usr/src/sys/contrib/openzfs/scripts/zfs-images not found: No such file or directory on FreeBSD 14.0-CURRENT.

Sorry for the delay. I just pushed out 0.95 -- how does it look?

Note that the zfs-images submodule has since been removed: https://github.com/freebsd/freebsd-src/commit/79e6eb5c018d44ee59c5b9b10755d116c860c366

Sorry for the delay. I just pushed out 0.95 -- how does it look?

Works great!!! Thank you very much! Regards..


Selecting multiple files one of which is a shortcut

Issue Type: Bug

Create a shortcut to Desktop (Context menu => Send to => Desktop (create shortcut))
Create ordinary file on Desktop New Text Document.txt
Select both files
Open with Code (From Context menu)

First try it tries to open the .lnk file:
The file is not displayed in the editor because it is either binary or uses an unsupported text encoding. Do you want to open it anyway?
After the first try, all the next attempts it opens only 1 file (the shortcut).

Sublime Text handles it nicely.
Atom - has the same bug.

VS Code version: Code 1.29.1 (bc24f98b5f70467bc689abf41cc5550ca637088e, 2018-11-15T19:13:36.375Z)
OS version: Windows_NT x64 10.0.17134

Duplicate of https://github.com/Microsoft/vscode/issues/35085#issuecomment-332452409


API: Change default name of user_readback.

Reasons:

Backward compatibility with routines developed when motors only returned one value
The vast majority of the time, people want the user_readback, and if they need to check the user_setpoint of course they can still access it.

We talked about doing this in #170 but it seemed like a small detail at the time. Don't worry: this is is not the first wave in a deluge of naming-related PRs into ophyd Device attribute names. EpicsMotor is the only place where I would advocate for overriding the verbose (if nicely explicit) default. Just as users like the special position and value attributes, they want their eta data to show up as "eta," not "eta_user_readback." We might as well make this a facility-wide standard; we are already writing this into most of the beamline configs by hand

I'm fine with this change.

Merging as tests are passing now.


API: Fix add_reaction method to pass reaction_data.

Context: I'm in the process of migrating ZT to use 'full' API calls, rather than do_api_query or call_endpoint, which were necessary to call endpoints directly when the python API didn't have the functionality.
I wondered why the add_reaction method wasn't working; apparently the method doesn't pass the actual data to call_endpoint, so it's not really so surprising!
I also corrected the example usage text, which had an extra emoji in the method name.

@eeshangarg should this have been caught by our API tests?

@timabbott: Yes, it should have been! But as it turns out, we don't have tests on the server side for this function in zerver/lib/api_test_helpers.py. I'm on it, will get this done asap and make a release tonight! :) Thanks for letting me know!

Thanks for the merge; I look forward to the release to finish my ZT migration :+1:
It's good to know about the test helpers; I've not dug super-deep into them, but some of it feels a little like  using pytest! I was surprised this had slipped through too - should the doc difference have been caught too?


native: separate branch.io test/prod apps based on preview/production targets

Updates the Branch.io config so that our test app corresponds to the preview target and the live app corresponds to the production target (i.e., join.tlon.io links will launch the main app and sa96e.test-app.link links will launch the preview app)
Tested by installing the preview app alongside the main app and tapping on a link like https://sa96e.test-app.link/dm-sapdex-diflyx to launch it. Note that deep linking is not currently set up and will need to be revisited when the home tab stack is more complete
I've had trouble running the preview Android app locally since the introduction of expo-dev-client, so I tested that out by firing off an Expo build and installing the generated APK

Nice! Looks good to me.


Entities that are not in wikipedia

Hello,
Thanks for this great repo.
Perhaps this is indicative of some fundamental misunderstanding on my part, but I was wondering if you could give me an idea of what LUKE would do if it came across a mention of an entity that does not exist in Wikipedia. Will it always try to match this to the closest entity or is there some way of saying there are no close entities?
Many thanks

Hi,
Thanks for your interest! Let me answer your questions.
LUKE can only handle entities that are in the LUKE's entity vocabulary.
For example, the luke-base model has the top 500K entities from the English Wikipedia in its entity vocabulary, so it cannot handle other entities that are not in the vocabulary.

what LUKE would do if it came across a mention of an entity that does not exist in Wikipedia. Will it always try to match this to the closest entity or is there some way of saying there are no close entities?

You need to detect entities in the input text in preprocessing before feeding the input to LUKE.
So LUKE would not do entity linking or matching for you.
It is our job to do that and deal with out-of-vocabulary entities.

would it try to do so and come up with an incorrect prediction, or would it just ignore them
It is totally up to the preprocessing step.
The model just makes predictions for whatever is given as input.

So, if you decide not to include OOV tokens in the input, the LUKE model will just ignore them.
Or you can convert those OOV entities to [UNK] or [MASK] tokens. In this case, the model will try to make predictions with them.
FYI, luke-base and luke-large are trained with [UNK] entity tokens, so they are kind of able to handle OOV entities to some extent.

Thanks, that's super helpful to know.
I guess it is unclear to me how you could ever know that an entity was OOV prior to disambiguation (in an inference set). Surely if you had some way to know whether it was in the vocabulary or not, the work of entity disambiguation is already 90% done? Maybe this is just an open question!

I guess it is unclear to me how you could ever know that an entity was OOV prior to disambiguation (in an inference set).

Actually, the LUKE model assumes that all the entities in the input are all correctly disambiguated or just converted into [UNK] or [MASK] tokens. For example, in pretraining, we use Wikipedia articles and the sentences contain hyperlinks, which can be regarded as entity annotation without ambiguity. In relation classification, we just convert the head and tail entities into [MASK] tokens to make predictions.
To apply LUKE in other contexts, we expect that LUKE is used with some entity linking or disambiguation systems such as this.

Hi @emilysilcock, Thanks for you interest in our entity disambiguation work!
Unfortunately, our current entity disambiguation model does not handle OOV entities. The publicized model is trained only with the candidate entities appearing in the datasets. However, as suggested by @Ryou0634, it may be possible to detect NIL entities by training the model with [UNK] entity, and detecting the OOV entities using the token.

Thanks, that's helpful to know!


Automatically confirm overwriting staging with production

There's no need to confirm when we're overwriting the staging database
with production; we want staging to be as similar as possible
to production.  This commit automatically confirms the overwrite.
Signed-off-by: David A. Wheeler<EMAIL_ADDRESS>

Please merge once tests pass.


Honeypot contracts: can APR repair them?

APR for vulnerable smart contracts aims to fix the contract to mitigate its vulnerability.
It is implicitly assumed that the contract is the victim and an attacker can exploit it.
Thus, automatically repairing the victim contract benefits the contract and not the attacker.
Enter honeypot contracts. A honeypot contract is a malicious contract that entices participants with the prospect of substantial rewards.
Usually, this contract's source code is public but it contains some misleading logic that tricks the participant into thinking that calling this contract is an easy grab of ether.
In reality, there's always a catch and the participants lose their ether instead of gaining more.
Thus, in this context, the contract itself is the attacker, and the participants are the victims.
The techniques used in honeypot contracts are similar to other frequent vulnerabilities present in vulnerable contracts.
E.g. uninitialized storage, reentrancy, etc.
Popular smart contract vulnerability benchmarks like smartbugs-curated consider honeypot contracts "vulnerable", they are included in their dataset.
The question is: by applying APR to honeypot contracts are we no longer benefiting contracts but rather its callers?
In practice, the attacker would not repair its honeypot contract. So should we even have these contracts in datasets?

8/10 papers on the first results page are honeypot detection tools.
Scam contract detection seems to share similar heuristics with Vulnerable contract detection.

For RepairComp we will not consider honeypot contracts as vulnerable.


silx.gui.plot.ImageView: Fixed issue with profile window size

This PR fixes an issue with ImageView profile window display.
To reproduce the issue: python bootstrap.py examples/imageview.py
Draw a horizontal line profile on the image and then draw a free line profile.
related to  #3454

DO you want to restart the failing test? I dont know how to do it?


Dev test: Desktop app 1.0.1

The PhET Desktop App is available for testing. It is available here:

MacOS
Windows

The desktop app requires a Java JDK to be installed (found here). From this page install, the latest version (Java SE Development Kit 15.0.1) of the Java JDK for your tested platform as described below:

Windows: Windows x64 Installer
MacOS: macOS Installer

General
QA, please do a dev-test of the app. Please complete a general test to make sure that all sims are launching, resources are in the correct locale, and that all other functions of the app are working properly (menu items, shortcuts, filters, launching the app, installation, etc). Issues can be created in the Weddell repo.
Locale Specific
This version of the app has been built for multiple locales. These locales can be changed via the drop-down menus near the toolbar at the top of the app's window. The expected behavior for selecting locales is as follows:

Click a locale from the drop-down menu
App should refresh and the homepage should be translated.
Sims should open in the specified locale

Additionally, the app should open in the locale chosen before it was closed. For example, select "Spanish" then close the app. The next time the app is opened, it should be in "Spanish". Other functionality should remain the same.
Assigning to @kathy-phet and @KatieWoe for prioritization.

[ ] Mac (Time = )
[ ] Windows (Time = )

@kathy-phet and I decided to end QA on this for now until the Mac version can be tested as well.

Sounds good.  I'll get the Mac version working and we'll give this another shot.  Closing.

Okay, I did some investigation, and I think the original build was actually good, but something went wrong with getting the file transferred to the phet-dev server.  I have re-transferred the DMG file, and fixed some permissions issues, and just downloaded it onto a Mac that I have access to, and it seems to have worked fine.  I'm going to re-open this issue, and testing can continue.
@KatieWoe - Note that this is not a new build, so any testing that was done on the Windows version is still applicable.

QA is done


Cross vault links show as "(Private)"

I guess this is the same issue I reported on dendron-docs.
Example
This is the markdown:
Check out an end-to-end workstyle, managing 20k notes, using schemas and daily journals from [[A Day in Dendron|dendron://dendron.dendron-site/community.greenhouse.2021-07-23-using-dendron-with-20k-notes]]

This is what gets rendered:

Check out an end-to-end workstyle, managing 20k notes, using schemas and daily journals from A Day in Dendron (Private)

Ah, thanks for the catch! In this case, this is because the link on dendron-site was broken. Fix will be included in docs public update on Friday (2022-02-18).
This is different from the dendron-docs issue, which I will respond to in that repo.
Commit: https://github.com/dendronhq/dendron-site/commit/850fe88e42cf775a31d19ce5b7865090e93e0f1a


Combine duplicated query-specific helper functions

Combine the many duplicated query-specific helper functions (e.g. tuple unpackers) into a single helper module.

Completed by a600bbfa2058ed395e629329f56a99fc0ca200bf


Bugix : Elements.IndexOf(element) value should be checked to avoid crashes

When removing elements and adding new one then removing, it can crash
in SVG.razor.cs
        protected override void OnInitialized()
        {

            ElementSubject
                .Buffer(TimeSpan.FromMilliseconds(33))
                .Where(updates => updates.Count > 0)
                .Subscribe(updates =>
                {
                    updates
                        .Distinct()
                        .ToList()
                        .ForEach(element =>
                        {
                            ElementsAsHtml[Elements.IndexOf(element)] = element.ToHtml();
                        });
                    UpdateInput();
                });
        }

Don't you think Elements.IndexOf(element) value should be checked to secure the code and avoid crashes ?

I think the solution to this problem is to make Elements private and add accessors that ensure ElementsAsHtml is updated accordingly when Elements is changed.
I will look into this.

I have separated the responsibility of the generated Html to each ISVGElement so that SVG doesn't have to handle that. So some nice Separation of Concerns.


listener_security_protocol_map not taken into account

Hello,
While trying to test kafka-monitor with one of our clusters, I encountered the following error:
[2017-07-31 13:54:23,834] ERROR single-cluster-monitor/MultiClusterTopicManagementService will stop due to error. (com.linkedin.kmf.services.MultiClusterTopicManagementService)
kafka.common.KafkaException: Failed to parse the broker info from zookeeper: {"listener_security_protocol_map":{"INT_PLAINTEXT":"PLAINTEXT","EXT_PLAINTEXT":"PLAINTEXT"},"endpoints":["INT_PLAINTEXT://<IP_ADDRESS>:9092","EXT_PLAINTEXT://<IP_ADDRESS>:9093"],"j
mx_port":9990,"host":"<IP_ADDRESS>","timestamp":"1501251189444","port":9092,"version":4}

[...]

Caused by: java.lang.IllegalArgumentException: No enum constant org.apache.kafka.common.protocol.SecurityProtocol.INT_PLAINTEXT

[...]

Testing was done with the current head at the time of writing (312abe0).

@ct16k It seems your broker has registered an unknown protocol in the zookeeper. Thus it may not be a problem due to kafka-monitor.
Can you try to produce and consume from your Kafka cluster using the producer/consumer tool in the Apache Kafka repository and see if it works? If it does work, can you provide the commands and properties file you used to start kafka-monitor?

Hello,
Producing and consuming from kafka seems to work without issues so far. We're using filebeat to send data to the cluster and the rdkafka PHP extension to read from it. The bundled scripts also work fine:
# bin/kafka-verifiable-producer.sh --broker-list <IP_ADDRESS>:9092,<IP_ADDRESS>:9092,<IP_ADDRESS>:9092 --topic test_topic --max-messages 10
{"name":"startup_complete"}
{"partition":0,"offset":10,"time_ms":1502120096241,"name":"producer_send_success","topic":"test_topic","value":"0","key":null}
{"partition":0,"offset":11,"time_ms":1502120096256,"name":"producer_send_success","topic":"test_topic","value":"1","key":null}
{"partition":0,"offset":12,"time_ms":1502120096258,"name":"producer_send_success","topic":"test_topic","value":"2","key":null}
{"partition":0,"offset":13,"time_ms":1502120096263,"name":"producer_send_success","topic":"test_topic","value":"3","key":null}
{"partition":0,"offset":14,"time_ms":1502120096265,"name":"producer_send_success","topic":"test_topic","value":"4","key":null}
{"partition":0,"offset":15,"time_ms":1502120096267,"name":"producer_send_success","topic":"test_topic","value":"5","key":null}
{"partition":0,"offset":16,"time_ms":1502120096269,"name":"producer_send_success","topic":"test_topic","value":"6","key":null}
{"partition":0,"offset":17,"time_ms":1502120096270,"name":"producer_send_success","topic":"test_topic","value":"7","key":null}
{"partition":0,"offset":18,"time_ms":1502120096271,"name":"producer_send_success","topic":"test_topic","value":"8","key":null}
{"partition":0,"offset":19,"time_ms":1502120096272,"name":"producer_send_success","topic":"test_topic","value":"9","key":null}
{"name":"shutdown_complete"}
{"avg_throughput":30.120481927710845,"target_throughput":-1,"name":"tool_data","sent":10,"acked":10}

# bin/kafka-verifiable-consumer.sh --broker-list <IP_ADDRESS>:9092,<IP_ADDRESS>:9092,<IP_ADDRESS>:9092 --topic test_topic --group-id 0 --verbose
{"timestamp":1502120085561,"name":"startup_complete"}
{"timestamp":1502120085688,"partitions":[],"name":"partitions_revoked"}
{"timestamp":1502120088717,"partitions":[{"topic":"test_topic","partition":0}],"name":"partitions_assigned"}
{"timestamp":1502120096251,"partition":0,"topic":"test_topic","name":"record_data","value":"0","offset":10,"key":null}
{"timestamp":1502120096253,"partition":0,"topic":"test_topic","name":"record_data","value":"1","offset":11,"key":null}
{"timestamp":1502120096253,"partition":0,"topic":"test_topic","name":"record_data","value":"2","offset":12,"key":null}
{"timestamp":1502120096253,"partition":0,"topic":"test_topic","name":"record_data","value":"3","offset":13,"key":null}
{"timestamp":1502120096253,"partition":0,"topic":"test_topic","name":"record_data","value":"4","offset":14,"key":null}
{"timestamp":1502120096253,"partition":0,"topic":"test_topic","name":"record_data","value":"5","offset":15,"key":null}
{"timestamp":1502120096253,"partition":0,"topic":"test_topic","name":"record_data","value":"6","offset":16,"key":null}
{"timestamp":1502120096253,"partition":0,"topic":"test_topic","name":"record_data","value":"7","offset":17,"key":null}
{"timestamp":1502120096253,"partition":0,"topic":"test_topic","name":"record_data","value":"8","offset":18,"key":null}
{"timestamp":1502120096253,"partition":0,"topic":"test_topic","name":"record_data","value":"9","offset":19,"key":null}
{"timestamp":1502120096254,"count":10,"partitions":[{"topic":"test_topic","partition":0,"count":10,"minOffset":10,"maxOffset":19}],"name":"records_consumed"}
{"timestamp":1502120096275,"offsets":[{"topic":"test_topic","partition":0,"offset":20}],"success":true,"name":"offsets_committed"}
^C{"timestamp":1502120380633,"name":"shutdown_complete"}

kafka-monitor was started with the sample properties file, modified to connect the proper hosts:
# cat config/kafka-monitor.properties
{
  "single-cluster-monitor": {
    "class.name": "com.linkedin.kmf.apps.SingleClusterMonitor",
    "topic": "kafka-monitor-topic",
    "zookeeper.connect": "<IP_ADDRESS>:2181,<IP_ADDRESS>:2181,<IP_ADDRESS>:2181",
    "bootstrap.servers": "<IP_ADDRESS>:9092,<IP_ADDRESS>:9092,<IP_ADDRESS>:9092",
    "produce.record.delay.ms": 100,
    "topic-management.topicCreationEnabled": true,
    "topic-management.replicationFactor" : 3,
    "topic-management.partitionsToBrokersRatio" : 2.0,
    "topic-management.rebalance.interval.ms" : 600000,
    "topic-management.topicFactory.props": {
    },
    "topic-management.topic.props": {
    },
    "produce.producer.props": {
      "client.id": "kmf-client-id"
    },
    "consume.latency.sla.ms": "20000",
    "consume.consumer.props": {
    }
  },
  "reporter-service": {
    "class.name": "com.linkedin.kmf.services.DefaultMetricsReporterService",
    "report.interval.sec": 1,
    "report.metrics.list": [
      "kmf:type=kafka-monitor:offline-runnable-count",
      "kmf.services:type=produce-service,name=*:produce-availability-avg",
      "kmf.services:type=consume-service,name=*:consume-availability-avg",
      "kmf.services:type=produce-service,name=*:records-produced-total",
      "kmf.services:type=consume-service,name=*:records-consumed-total",
      "kmf.services:type=consume-service,name=*:records-lost-total",
      "kmf.services:type=consume-service,name=*:records-duplicated-total",
      "kmf.services:type=consume-service,name=*:records-delay-ms-avg",
      "kmf.services:type=produce-service,name=*:records-produced-rate",
      "kmf.services:type=produce-service,name=*:produce-error-rate",
      "kmf.services:type=consume-service,name=*:consume-error-rate"
    ]
  },
  "jetty-service": {
    "class.name": "com.linkedin.kmf.services.JettyService",
    "jetty.port": 8000
  },
  "jolokia-service": {
    "class.name": "com.linkedin.kmf.services.JolokiaService"
  }
}

Complete output of a failed start:
# bin/kafka-monitor-start.sh config/kafka-monitor.properties
[2017-08-07 18:44:37,816] INFO MultiClusterTopicManagementServiceConfig values:
        topic = kafka-monitor-topic
        topic-management.rebalance.interval.ms = 600000
 (com.linkedin.kmf.services.configs.MultiClusterTopicManagementServiceConfig)
[2017-08-07 18:44:37,850] INFO TopicManagementServiceConfig values:
        topic = kafka-monitor-topic
        topic-management.minPartitionNum = 1
        topic-management.partitionsToBrokersRatio = 2.0
        topic-management.replicationFactor = 3
        topic-management.topicCreationEnabled = true
        topic-management.topicFactory.class.name = com.linkedin.kmf.topicfactory.DefaultTopicFactory
        zookeeper.connect = <IP_ADDRESS>:2181,<IP_ADDRESS>:2181,<IP_ADDRESS>:2181
 (com.linkedin.kmf.services.configs.TopicManagementServiceConfig)
[2017-08-07 18:44:37,858] INFO ProduceServiceConfig values:
        bootstrap.servers = <IP_ADDRESS>:9092,<IP_ADDRESS>:9092,<IP_ADDRESS>:9092
        produce.partitioner.class = class com.linkedin.kmf.partitioner.NewKMPartitioner
        produce.producer.class = com.linkedin.kmf.producer.NewProducer
        produce.producer.id = kmf-producer
        produce.record.delay.ms = 100
        produce.record.size.byte = 100
        produce.sync = true
        produce.thread.num = 5
        topic = kafka-monitor-topic
        zookeeper.connect = <IP_ADDRESS>:2181,<IP_ADDRESS>:2181,<IP_ADDRESS>:2181
 (com.linkedin.kmf.services.configs.ProduceServiceConfig)
[2017-08-07 18:44:37,927] INFO Starting ZkClient event thread. (org.I0Itec.zkclient.ZkEventThread)
[2017-08-07 18:44:37,942] INFO Client environment:zookeeper.version=3.4.8--1, built on 02/06/2016 03:18 GMT (org.apache.zookeeper.ZooKeeper)
[2017-08-07 18:44:37,942] INFO Client environment:host.name=eos-kmg1-all-prod (org.apache.zookeeper.ZooKeeper)
[2017-08-07 18:44:37,942] INFO Client environment:java.version=1.8.0_141 (org.apache.zookeeper.ZooKeeper)
[2017-08-07 18:44:37,942] INFO Client environment:java.vendor=Oracle Corporation (org.apache.zookeeper.ZooKeeper)
[2017-08-07 18:44:37,942] INFO Client environment:java.home=/usr/lib/jvm/java-1.8.0-openjdk-<IP_ADDRESS>-1.b16.el7_3.x86_64/jre (org.apache.zookeeper.ZooKeeper)
[2017-08-07 18:44:37,943] INFO Client environment:java.class.path=:/opt/kafka-monitor/bin/../build/libs/kafka-monitor-1.0.0.jar:/opt/kafka-monitor/bin/../build/dependant-libs/ant-1.7.1.jar:/opt/kafka-monitor/bin/../build/dependant-libs/ant-launcher-1.7.1.jar:/opt/kafka-$
onitor/bin/../build/dependant-libs/argparse4j-0.5.0.jar:/opt/kafka-monitor/bin/../build/dependant-libs/asm-3.2.jar:/opt/kafka-monitor/bin/../build/dependant-libs/avro-1.4.0.jar:/opt/kafka-monitor/bin/../build/dependant-libs/bsh-2.0b4.jar:/opt/kafka-monitor/bin/../build/$
ependant-libs/commons-collections-3.2.1.jar:/opt/kafka-monitor/bin/../build/dependant-libs/commons-lang-2.5.jar:/opt/kafka-monitor/bin/../build/dependant-libs/graphite-client-1.1.0-RELEASE.jar:/opt/kafka-monitor/bin/../build/dependant-libs/jackson-annotations-2.7.0.jar:$
opt/kafka-monitor/bin/../build/dependant-libs/jackson-core-2.7.1.jar:/opt/kafka-monitor/bin/../build/dependant-libs/jackson-core-asl-1.4.2.jar:/opt/kafka-monitor/bin/../build/dependant-libs/jackson-databind-2.7.1.jar:/opt/kafka-monitor/bin/../build/dependant-libs/jackso$
-mapper-asl-1.4.2.jar:/opt/kafka-monitor/bin/../build/dependant-libs/java-statsd-client-3.0.1.jar:/opt/kafka-monitor/bin/../build/dependant-libs/javax.servlet-3.0.0.v201112011016.jar:/opt/kafka-monitor/bin/../build/dependant-libs/jcommander-1.27.jar:/opt/kafka-monitor/b$
n/../build/dependant-libs/jetty-6.1.22.jar:/opt/kafka-monitor/bin/../build/dependant-libs/jetty-continuation-8.1.19.v20160209.jar:/opt/kafka-monitor/bin/../build/dependant-libs/jetty-http-8.1.19.v20160209.jar:/opt/kafka-monitor/bin/../build/dependant-libs/jetty-io-8.1.1$
.v20160209.jar:/opt/kafka-monitor/bin/../build/dependant-libs/jetty-server-8.1.19.v20160209.jar:/opt/kafka-monitor/bin/../build/dependant-libs/jetty-util-6.1.22.jar:/opt/kafka-monitor/bin/../build/dependant-libs/jetty-util-8.1.19.v20160209.jar:/opt/kafka-monitor/bin/../$
uild/dependant-libs/jline-0.9.94.jar:/opt/kafka-monitor/bin/../build/dependant-libs/jolokia-core-1.3.3.jar:/opt/kafka-monitor/bin/../build/dependant-libs/jolokia-jvm-1.3.3.jar:/opt/kafka-monitor/bin/../build/dependant-libs/jopt-simple-4.9.jar:/opt/kafka-monitor/bin/../b$
ild/dependant-libs/json-20140107.jar:/opt/kafka-monitor/bin/../build/dependant-libs/json-simple-1.1.1.jar:/opt/kafka-monitor/bin/../build/dependant-libs/kafka_2.11-<IP_ADDRESS>.jar:/opt/kafka-monitor/bin/../build/dependant-libs/kafka-clients-<IP_ADDRESS>.jar:/opt/kafka-monitor/$
in/../build/dependant-libs/log4j-1.2.17.jar:/opt/kafka-monitor/bin/../build/dependant-libs/lz4-1.3.0.jar:/opt/kafka-monitor/bin/../build/dependant-libs/metrics-core-2.2.0.jar:/opt/kafka-monitor/bin/../build/dependant-libs/netty-3.2.1.Final.jar:/opt/kafka-monitor/bin/../$
uild/dependant-libs/netty-3.7.0.Final.jar:/opt/kafka-monitor/bin/../build/dependant-libs/oro-2.0.8.jar:/opt/kafka-monitor/bin/../build/dependant-libs/paranamer-2.2.jar:/opt/kafka-monitor/bin/../build/dependant-libs/paranamer-ant-2.2.jar:/opt/kafka-monitor/bin/../build/d$
pendant-libs/paranamer-generator-2.2.jar:/opt/kafka-monitor/bin/../build/dependant-libs/qdox-1.10.1.jar:/opt/kafka-monitor/bin/../build/dependant-libs/scala-library-2.11.8.jar:/opt/kafka-monitor/bin/../build/dependant-libs/scala-parser-combinators_2.11-1.0.4.jar:/opt/ka$
ka-monitor/bin/../build/dependant-libs/servlet-api-2.5-20081211.jar:/opt/kafka-monitor/bin/../build/dependant-libs/slf4j-api-1.7.21.jar:/opt/kafka-monitor/bin/../build/dependant-libs/slf4j-log4j12-1.7.21.jar:/opt/kafka-monitor/bin/../build/dependant-libs/snappy-java-1.1$
2.6.jar:/opt/kafka-monitor/bin/../build/dependant-libs/testng-6.8.8.jar:/opt/kafka-monitor/bin/../build/dependant-libs/velocity-1.6.4.jar:/opt/kafka-monitor/bin/../build/dependant-libs/zkclient-0.9.jar:/opt/kafka-monitor/bin/../build/dependant-libs/zookeeper-3.4.8.jar ($
rg.apache.zookeeper.ZooKeeper)
[2017-08-07 18:44:37,943] INFO Client environment:java.library.path=/usr/java/packages/lib/amd64:/usr/lib64:/lib64:/lib:/usr/lib (org.apache.zookeeper.ZooKeeper)
[2017-08-07 18:44:37,943] INFO Client environment:java.io.tmpdir=/tmp (org.apache.zookeeper.ZooKeeper)
[2017-08-07 18:44:37,943] INFO Client environment:java.compiler=<NA> (org.apache.zookeeper.ZooKeeper)
[2017-08-07 18:44:37,943] INFO Client environment:os.name=Linux (org.apache.zookeeper.ZooKeeper)
[2017-08-07 18:44:37,943] INFO Client environment:os.arch=amd64 (org.apache.zookeeper.ZooKeeper)
[2017-08-07 18:44:37,944] INFO Client environment:os.version=3.10.0-514.26.2.el7.x86_64 (org.apache.zookeeper.ZooKeeper)
[2017-08-07 18:44:37,944] INFO Client environment:user.name=root (org.apache.zookeeper.ZooKeeper)
[2017-08-07 18:44:37,944] INFO Client environment:user.home=/root (org.apache.zookeeper.ZooKeeper)
[2017-08-07 18:44:37,944] INFO Client environment:user.dir=/opt/kafka-monitor (org.apache.zookeeper.ZooKeeper)
[2017-08-07 18:44:37,945] INFO Initiating client connection, connectString=<IP_ADDRESS>:2181,<IP_ADDRESS>:2181,<IP_ADDRESS>:2181 sessionTimeout=30000 watcher=org.I0Itec.zkclient.ZkClient@32464a14 (org.apache.zookeeper.ZooKeeper)
[2017-08-07 18:44:37,987] INFO Opening socket connection to server <IP_ADDRESS>/<IP_ADDRESS>:2181. Will not attempt to authenticate using SASL (unknown error) (org.apache.zookeeper.ClientCnxn)
[2017-08-07 18:44:37,996] INFO Waiting for keeper state SyncConnected (org.I0Itec.zkclient.ZkClient)
[2017-08-07 18:44:38,002] INFO Socket connection established to <IP_ADDRESS>/<IP_ADDRESS>:2181, initiating session (org.apache.zookeeper.ClientCnxn)
[2017-08-07 18:44:38,018] INFO Session establishment complete on server <IP_ADDRESS>/<IP_ADDRESS>:2181, sessionid = 0x15d73ebaef00124, negotiated timeout = 30000 (org.apache.zookeeper.ClientCnxn)
[2017-08-07 18:44:38,022] INFO zookeeper state changed (SyncConnected) (org.I0Itec.zkclient.ZkClient)
[2017-08-07 18:44:38,431] INFO Terminate ZkClient event thread. (org.I0Itec.zkclient.ZkEventThread)
[2017-08-07 18:44:38,437] INFO Session: 0x15d73ebaef00124 closed (org.apache.zookeeper.ZooKeeper)
[2017-08-07 18:44:38,441] INFO EventThread shut down for session: 0x15d73ebaef00124 (org.apache.zookeeper.ClientCnxn)
[2017-08-07 18:44:38,548] INFO single-cluster-monitor/ProduceService is initialized. (com.linkedin.kmf.services.ProduceService)
[2017-08-07 18:44:38,557] INFO ConsumeServiceConfig values:
        bootstrap.servers = <IP_ADDRESS>:9092,<IP_ADDRESS>:9092,<IP_ADDRESS>:9092
        consume.consumer.class = com.linkedin.kmf.consumer.NewConsumer
        consume.latency.percentile.granularity.ms = 1
        consume.latency.percentile.max.ms = 5000
        consume.latency.sla.ms = 20000
        topic = kafka-monitor-topic
        zookeeper.connect = <IP_ADDRESS>:2181,<IP_ADDRESS>:2181,<IP_ADDRESS>:2181
 (com.linkedin.kmf.services.configs.ConsumeServiceConfig)
[2017-08-07 18:44:38,668] INFO DefaultMetricsReporterServiceConfig values:
        report.interval.sec = 1
        report.metrics.list = [kmf:type=kafka-monitor:offline-runnable-count, kmf.services:type=produce-service,name=*:produce-availability-avg, kmf.services:type=consume-service,name=*:consume-availability-avg, kmf.services:type=produce-service,name=*:records-produced-t
otal, kmf.services:type=consume-service,name=*:records-consumed-total, kmf.services:type=consume-service,name=*:records-lost-total, kmf.services:type=consume-service,name=*:records-duplicated-total, kmf.services:type=consume-service,name=*:records-delay-ms-avg, kmf.servi
ces:type=produce-service,name=*:records-produced-rate, kmf.services:type=produce-service,name=*:produce-error-rate, kmf.services:type=consume-service,name=*:consume-error-rate]
 (com.linkedin.kmf.services.configs.DefaultMetricsReporterServiceConfig)
[2017-08-07 18:44:38,674] INFO JettyServiceConfig values:
        jetty.port = 8000
 (com.linkedin.kmf.services.configs.JettyServiceConfig)
[2017-08-07 18:44:38,948] INFO single-cluster-monitor/MultiClusterTopicManagementService started. (com.linkedin.kmf.services.MultiClusterTopicManagementService)
[2017-08-07 18:44:38,949] INFO Initiating client connection, connectString=<IP_ADDRESS>:2181,<IP_ADDRESS>:2181,<IP_ADDRESS>:2181 sessionTimeout=30000 watcher=org.I0Itec.zkclient.ZkClient@3b9f4f9e (org.apache.zookeeper.ZooKeeper)
[2017-08-07 18:44:38,950] INFO single-cluster-monitor/ProduceService started (com.linkedin.kmf.services.ProduceService)
[2017-08-07 18:44:38,951] INFO single-cluster-monitor/ConsumeService started (com.linkedin.kmf.services.ConsumeService)
[2017-08-07 18:44:38,951] INFO single-cluster-monitor/SingleClusterMonitor started (com.linkedin.kmf.apps.SingleClusterMonitor)
[2017-08-07 18:44:38,952] INFO Starting ZkClient event thread. (org.I0Itec.zkclient.ZkEventThread)
[2017-08-07 18:44:38,953] INFO Opening socket connection to server <IP_ADDRESS>/<IP_ADDRESS>:2181. Will not attempt to authenticate using SASL (unknown error) (org.apache.zookeeper.ClientCnxn)
[2017-08-07 18:44:38,953] INFO Waiting for keeper state SyncConnected (org.I0Itec.zkclient.ZkClient)
[2017-08-07 18:44:38,955] INFO Socket connection established to <IP_ADDRESS>/<IP_ADDRESS>:2181, initiating session (org.apache.zookeeper.ClientCnxn)
[2017-08-07 18:44:38,956] INFO jetty-8.1.19.v20160209 (org.eclipse.jetty.server.Server)
[2017-08-07 18:44:38,960] INFO Session establishment complete on server <IP_ADDRESS>/<IP_ADDRESS>:2181, sessionid = 0x35d73eb7ef6010b, negotiated timeout = 30000 (org.apache.zookeeper.ClientCnxn)
[2017-08-07 18:44:38,961] INFO zookeeper state changed (SyncConnected) (org.I0Itec.zkclient.ZkClient)
[2017-08-07 18:44:39,030] INFO Started SelectChannelConnector@<IP_ADDRESS>:8000 (org.eclipse.jetty.server.AbstractConnector)
[2017-08-07 18:44:39,030] INFO jetty-service/JettyService started at port 8000 (com.linkedin.kmf.services.JettyService)
I> No access restrictor found, access to any MBean is allowed
[2017-08-07 18:44:39,428] INFO jolokia-service/JolokiaService started at port 8778 (com.linkedin.kmf.services.JettyService)
[2017-08-07 18:44:39,430] INFO reporter-service/DefaultMetricsReporterService started (com.linkedin.kmf.services.DefaultMetricsReporterService)
[2017-08-07 18:44:39,431] INFO KafkaMonitor started (com.linkedin.kmf.KafkaMonitor)
[2017-08-07 18:44:39,575] INFO Terminate ZkClient event thread. (org.I0Itec.zkclient.ZkEventThread)
[2017-08-07 18:44:39,579] INFO Session: 0x35d73eb7ef6010b closed (org.apache.zookeeper.ZooKeeper)
[2017-08-07 18:44:39,580] ERROR single-cluster-monitor/MultiClusterTopicManagementService will stop due to error. (com.linkedin.kmf.services.MultiClusterTopicManagementService)
kafka.common.KafkaException: Failed to parse the broker info from zookeeper: {"listener_security_protocol_map":{"INT_PLAINTEXT":"PLAINTEXT","EXT_PLAINTEXT":"PLAINTEXT"},"endpoints":["INT_PLAINTEXT://<IP_ADDRESS>:9092","EXT_PLAINTEXT://<IP_ADDRESS>:9093"],"j
mx_port":9990,"host":"<IP_ADDRESS>","timestamp":"1502111018241","port":9092,"version":4}
        at kafka.cluster.Broker$.createBroker(Broker.scala:98)
        at kafka.utils.ZkUtils.getBrokerInfo(ZkUtils.scala:814)
        at kafka.utils.ZkUtils$$anonfun$getAllBrokersInCluster$2.apply(ZkUtils.scala:250)
        at kafka.utils.ZkUtils$$anonfun$getAllBrokersInCluster$2.apply(ZkUtils.scala:250)
        at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:234)
        at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:234)
        at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59)
        at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:48)
        at scala.collection.TraversableLike$class.map(TraversableLike.scala:234)
        at scala.collection.AbstractTraversable.map(Traversable.scala:104)
        at kafka.utils.ZkUtils.getAllBrokersInCluster(ZkUtils.scala:250)
        at com.linkedin.kmf.common.Utils.createMonitoringTopicIfNotExists(Utils.java:92)
        at com.linkedin.kmf.topicfactory.DefaultTopicFactory.createTopicIfNotExist(DefaultTopicFactory.java:26)
        at com.linkedin.kmf.services.MultiClusterTopicManagementService$TopicManagementHelper.maybeCreateTopic(MultiClusterTopicManagementService.java:211)
        at com.linkedin.kmf.services.MultiClusterTopicManagementService$TopicManagementRunnable.run(MultiClusterTopicManagementService.java:143)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.IllegalArgumentException: No enum constant org.apache.kafka.common.protocol.SecurityProtocol.INT_PLAINTEXT
        at java.lang.Enum.valueOf(Enum.java:238)
        at org.apache.kafka.common.protocol.SecurityProtocol.valueOf(SecurityProtocol.java:28)
        at org.apache.kafka.common.protocol.SecurityProtocol.forName(SecurityProtocol.java:89)
        at kafka.cluster.EndPoint$.createEndPoint(EndPoint.scala:49)
        at kafka.cluster.Broker$$anonfun$1.apply(Broker.scala:87)
        at kafka.cluster.Broker$$anonfun$1.apply(Broker.scala:86)
        at scala.collection.immutable.List.map(List.scala:273)
        at kafka.cluster.Broker$.createBroker(Broker.scala:86)
        ... 21 more
[2017-08-07 18:44:39,584] INFO single-cluster-monitor/MultiClusterTopicManagementService stopped. (com.linkedin.kmf.services.MultiClusterTopicManagementService)
[2017-08-07 18:44:39,585] INFO single-cluster-monitor/MultiClusterTopicManagementService shutdown completed (com.linkedin.kmf.services.MultiClusterTopicManagementService)
[2017-08-07 18:44:39,581] INFO EventThread shut down for session: 0x35d73eb7ef6010b (org.apache.zookeeper.ClientCnxn)

@ct16k I see. Thanks for providing the detailed information. It looks like your broker is running Kafka <IP_ADDRESS> or higher which supports a newer version of broker Info format in zookeeper. Kafka Monitor was not working correctly because it was compiled with Kafka <IP_ADDRESS>, which doesn't recognize that format.
I have bumped up the dependency of kafka from <IP_ADDRESS> to <IP_ADDRESS> in the master branch of Kafka Monitor. Can you try the latest version and see if the problem is addressed?

We're testing with a <IP_ADDRESS> cluster, I forgot to mention. Updating the dependency to 0.10.2 indeed fixed this.
Thank you and keep up the great work!


fix: select all log source namespaces

https://github.com/kube-logging/telemetry-controller/pull/92 mistakenly removed the ability to select all namespaces, this PR adds that back.
To use this, specify the logSourceNamespaceSelectors field with an empty slice.
apiVersion: telemetry.kube-logging.dev/v1alpha1
kind: Tenant
metadata:
  labels:
    collector: cluster
  name: tenant
spec:
  logSourceNamespaceSelectors: []

as discussed: please add doc comments and make sure the behaviour is consistent with how subscriptionNamespaceSelectors behaves


User Flow - First time logged in User

Overview

First time logged in users should be redirected to banner page( telling them to wait for the admin to get back)
Admin Users will get notified of the new login attempt over an email
Admin should be able to reject the user request to get access to the system using the current Admin menu

Some patches required

It might be required to check the current user management screen with respect to the latest group/role structure in the keycloak

@ethanjorgensen we need to move this to confluence for EPIC.auth


chore: fix r test flakiness

/azp run

Codecov Report

Merging #1314 (be254f2) into master (b268271) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1314      +/-   ##
==========================================
+ Coverage   84.67%   84.70%   +0.02%
==========================================
  Files         280      280
  Lines       13641    13641
  Branches      693      693
==========================================
+ Hits        11551    11554       +3
+ Misses       2090     2087       -3

Impacted Files
Coverage Δ

...re/synapse/ml/lightgbm/params/LightGBMParams.scala
84.09% <0.00%> (-0.38%)
:arrow_down:

...crosoft/azure/synapse/ml/lightgbm/TrainUtils.scala
85.98% <0.00%> (+2.54%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b268271...be254f2. Read the comment docs.

/azp run


Release 0.7.3-dev

Release 0.7.3-dev

Version 0.7.3-dev (08.07.2020)

[chore:ios] file name "appbeep.wav" rename to "alert.wav"
[feature:ios] add new method priceAlertPlayAudio
[bugfix:ios] AudioPlayer must be play if enabled in background mode


ci: use internal update-semver action

Use internal addonfactory-update-semver action
JIRA: https://splunk.atlassian.net/browse/ADDON-68596

:tada: This PR is included in version 5.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Dying with negative levels doesn't (always) kill you

Here's another problem I discovered on the path to making Enervation work.
 The easiest way to see what's going on seem to be to give party members negative levels with, e.g.:
game.party[0].condition_add_with_args('Temp Negative Level', 1, 1, 1)

If you give enough negative levels, and the character has more than 5HP per level, they will eventually 'die.' Then all the negative levels will disappear and they'll be reset to an HP of 5*NL-10, where  NL is the number of negative levels they had when they died. This may mean they're actually alive again, or just dying at -5 in the case of a single negative level (still not strictly dead; they may stabilize).
However, from that point on, no amount of negative levels will kill them unless it gets their HP to negatives. You can set the character's HP to 150, and it will take 31 negative levels for them to be dying again. I'm not really sure why this is; they must be in some weird state from getting killed the first time.
I did a fair amount of testing, and your previous negative level fix seems to be unrelated to this behavior. I can reproduce it in 1.0.84. The fix with monster hit dice just means it also happens on e.g. the giant and bear.
Oh, I think this also happens with 'Perm Negative Level', since those act pretty similar to temp levels in ToEE. I didn't test those as extensively, though.

 So the easiest solution is to disable that. This begs the question: does resurrection clear negative levels?

The books don't really spell out what happens, either, and I can't find a definitive ruling.
Raise dead/resurrection is actually supposed to lower your level. And restoration is unable to fix that, but I'm not sure ToEE has any way to implement this.
It's also a little unclear just what each different concept is supposed to be. Enervation/energy drain give negative levels (which are "temporary"), but after one day you're supposed to save, and you either heal or actually lose a level. Enervation actually can't do that, because the negative levels should disappear after at most 15 hours, so they never induce the save-or-lose-level condition.
However, I think ToEE's temp negative levels just have you save every day until they disappear. I guess that could be fixed similarly to the other fix, but I don't know if there's a way to remove a level of a character. I think maybe a 'permanent' negative level in ToEE is supposed to be like losing a level? (P&P) Restoration gets rid of all (temporary) negative levels, and gives you experience to gain back one lost level per casting (except if it was lost from raise dead/resurrection), so that would explain why it can get rid of 'permanent' negative levels (except I'm not sure how you get those, since temp negative levels never become perm ones).
I think most of these subtleties aren't that important for ToEE, and mostly the short-term consequences matter. Energy drained people just getting back up in a fight is a lot more of a problem than all the long term restoration rules.
In that sense, I think resurrection/raise dead clearing temp negative levels is probably fine. If your character got weakened and killed, the resurrection is probably enough of a cost. Maybe it shouldn't clear permanent negative levels, depending on how you get those.

Incidentally ToEE almost matches the Pathfinder rules for negative levels. It has temporary and permanent negative levels, temporary negative levels let you save once a day to remove them (although lots of stuff overrides this), and restoration can remove the permanent ones.
Pathfinder also says that to raise someone killed by permanent negative levels, you must cast restoration on them right away afterwards. However, it says nothing about raising someone killed by temporary negative levels. Since they're easier to get rid of, perhaps they're intended to just go away in that scenario.

FYI, the meaning of the args in Temp Negative Level:
game.party[0].condition_add_with_args('Temp Negative Level', arg0, arg1, arg2)
  arg0 - which class is affected (this is automatically set to highest class level by the engine)
  arg1 - DC for permanent negative level saving throw
  arg2 - inventory slot for the item which causes the effect (relevant only for the Holy/Unholy etc weapons )

I'm going to go ahead and cancel the removal on death. Otherwise it could get too complicated I think.

Apologies for adding another comment to a closed issue, but I've fiddled around more, and wanted to correct inaccuracies in my description above in case someone happens across it.

I was remembering the behavior of temp negative levels backwards in ToEE. They actually never go away until you fail the saving throw and they become permanent. I thought maybe this could be related to your arg2 description above, since it seems like a temp negative level from an opposite aligned item shouldn't go away until you remove it. But I no arg2 I've tried allows the level to be cleared on a successful save (0,1,2,-1,3000,100,...).
ToEE treats a permanent negative level like a temp negative level with respect to penalties (i.e. it doesn't try to roll back your actual levels, which is probably wise). However, it does deduct experience each time you get a perm negative level. Then restoration gives you back experience when removing a perm negative level presumably. However, you can also get rid of perm negative levels just by gaining the experience (at least, the levelup cheat clears perm negative levels in that way).


Fix the problem of deleting blank items appear at the end#4654

What's the purpose of this PR
Fix the problem of deleting blank items appear at the end.
Which issue(s) this PR fixes:
Fixes #4654
Brief changelog
1.delete blank item then it'll appear at the end

XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Read the Contributing Guide before making this pull request.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit tests to verify the code.
[ ] Run mvn clean test to make sure this pull request doesn't break anything.
[ ] Update the CHANGES log.

I have read the CLA Document and I hereby sign the CLA

@nobodyiam I recommit the change, please help me review the code again.

@lepdou thanks

The code change looks good to me. Would you please help to update the CHANGES.md?

The code change looks good to me. Would you please help to update the CHANGES.md?

create request to update  CHANGES.md？


Demo with kartograf 0.2.3:<PHONE_NUMBER>

The data here is using RPKI and Routeviews to produce a demo asmap file for the purpose of testing reproducibility across systems and time.
Please get the latest version of kartograf (at least 0.2.3) and run:
./run map -r /path/to/this/repo/1699394720 -t<PHONE_NUMBER>

This should result in a final result file with the hash 4cba5e3a865d7bcca903c40880420027fb7d55651a18e43f19fad848a6b33406.
Be aware that the process takes ~6h on a 2020 Macbook Pro.

On Ubuntu 23.04 I installed fjahr/kartograph master@3014b82a2d0d83312a3b9309256ffa1c065ff4c4 (not to be confused with OpenFreeEnergy/kartograf
Now running the above command...

Well that ended quickly:
$ ./run map -r ../asmap-data/1699394720 -t<PHONE_NUMBER>

--- Start Kartograf ---

The epoch for this run is:<PHONE_NUMBER> (2023-11-07 22:05:20 UTC, local: 2023-11-07 23:05:20 CET
This is a reproduction run based on the data in ../asmap-data/1699394720/

--- Validating RPKI ---

Validating RPKI ROAs
98289 raw RKPI DB entries downloaded and saved to /home/sjors/dev/kartograf/out/r1699394720/rpki/rpki_raw.json
...finished in 0:02:40.375330

--- Parsing RPKI ---

Parsing 0 ROAs
Output: 0
Duplicates: 0
Invalids: 0
Incompletes: 0
...finished in 0:00:00.000145

--- Parsing Routeviews pfx2as ---

Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/23
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/22
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/23
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: <IP_ADDRESS>/24
Bogon filtered: 2001::/32
Bogon filtered: 2001:4:112::/48
Bogon filtered: 2002::/16
Bogon filtered: 2620:4f:8000::/48
...finished in 0:02:18.439555

--- Merging Routeviews and base data ---

Parse base file to numpy arrays
Parse extra file to Pandas DataFrame
Filtering extra prefixes that were already included in the base file
  0%|                                                                                | 1/1183115 [00:00<2:27:33, 133.63it/s]
Traceback (most recent call last):
  File "/home/sjors/dev/kartograf/./run", line 86, in <module>
    Kartograf.map(args)
  File "/home/sjors/dev/kartograf/kartograf/kartograf.py", line 69, in map
    merge_pfx2as(context)
  File "/home/sjors/dev/kartograf/kartograf/timed.py", line 10, in wrapper
    result = func(*args, **kwargs)
  File "/home/sjors/dev/kartograf/kartograf/merge.py", line 35, in merge_pfx2as
    general_merge(base_file, rv_file, rv_filtered_file, out_file)
  File "/home/sjors/dev/kartograf/kartograf/merge.py", line 85, in general_merge
    df_extra['INCLUDED'] = df_extra.INETS.progress_apply(check_inclusion)
  File "/home/sjors/.pyenv/versions/3.10.10/lib/python3.10/site-packages/tqdm/std.py", line 814, in inner
    return getattr(df, df_function)(wrapper, **kwargs)
  File "/home/sjors/.pyenv/versions/3.10.10/lib/python3.10/site-packages/pandas/core/series.py", line 4771, in apply
    return SeriesApply(self, func, convert_dtype, args, kwargs).apply()
  File "/home/sjors/.pyenv/versions/3.10.10/lib/python3.10/site-packages/pandas/core/apply.py", line 1123, in apply
    return self.apply_standard()
  File "/home/sjors/.pyenv/versions/3.10.10/lib/python3.10/site-packages/pandas/core/apply.py", line 1174, in apply_standard
    mapped = lib.map_infer(
  File "pandas/_libs/lib.pyx", line 2924, in pandas._libs.lib.map_infer
  File "/home/sjors/.pyenv/versions/3.10.10/lib/python3.10/site-packages/tqdm/std.py", line 809, in wrapper
    return func(*args, **kwargs)
  File "/home/sjors/dev/kartograf/kartograf/merge.py", line 76, in check_inclusion
    inclusion_list = int(extra_net) & net_masks == network_addresses
TypeError: ufunc 'bitwise_and' not supported for the input types, and the inputs could not be safely coerced to any supported types according to the casting rule ''safe''

Some extra info: rpki-client-portable 8.2
I ran an earlier version of this script on the same machine in September. I did run a git clean -dfx on this repo before trying this PR, but didn't clean any other caches.

Updated Ubuntu and Kartograf to 8.5. Running again...

Took about 4.5 hours. Different hash though…
--- Validating RPKI ---

Validating RPKI ROAs
c98289 raw RKPI DB entries downloaded and saved to /home/sjors/dev/kartograf/out/r1699394720/rpki/rpki_raw.json
...finished in 1:01:49.240574

--- Parsing RPKI ---

Parsing 98289 ROAs
Output: 352920
Duplicates: 33828
Invalids: 3579
Incompletes: 0
...finished in 0:00:42.274760

--- Parsing Routeviews pfx2as ---

Bogon filtered: <IP_ADDRESS>/24
...
Bogon filtered: 2620:4f:8000::/48
...finished in 0:02:21.241519

--- Merging Routeviews and base data ---

Parse base file to numpy arrays
Parse extra file to Pandas DataFrame
Filtering extra prefixes that were already included in the base file
100%|██████████████████████████████████████████████████████████████████████████████████████| 1183115/1183115 [3:09:39<00:00, 103.97it/s]
Finished filtering! Originally 1183115 entries filtered down to 711395
Merging base file with filtered extra file
...finished in 3:09:46.119446

--- Sorting results ---

...finished in 0:00:06.132383

--- Finishing Kartograf ---

The SHA-256 hash of the result file is: b05544ac1247108e9e3dde0e9dae0bfb3e4052743bb7fc02bf3dfbfe0b8a8118
Total runtime: 4:14:45.025770

@Sjors Hm, the logs look good. I used rpki-client 8.6 with this run, I will run with 8.5 to see if that changes the hash for me as well.

@Sjors nope, that wasn't it, I still get the same hash as before with rpki-client 8.5 on my system. I guess we should just nixify everything, but I would really like to find out where the issue lies first. I will check which version I get on an Ubuntu box. Would you mind sharing your python version as well?

Python 3.10.10

@Sjors Ok, I think we got it now 😅 If you could test one more time with the latest Kartograf (0.2.3) that would be great! The new result hash is 4cba5e3a865d7bcca903c40880420027fb7d55651a18e43f19fad848a6b33406. Tested on Ubuntu and Python 3.10, among others.
What happened is, that the file ordering coming from pathlib was different in Ubuntu and that led to different content in some cases because there can be multiple rpki roas for a single prefix and I chose to keep the first seen as a final tiebreaker which means file order could influence the result. Now we take the entry with the lower ASN as the final tiebreaker if validity etc are all equal.

@fjahr you may want to tag the releases, but I'll try with the latest master f549ba1cb78525661354cd54aa08936e4ded84d4

I like the progress indicator…
And I get the same hash! 🎉

@Sjors Thanks a lot for sticking with me for this :)
I am working on some performance upgrades now and will motivate more people to test the process.

I am closing this now in favor of the new demo using coordinated launch: https://github.com/fjahr/asmap-data/issues/4
@Sjors  it would awesome to see you join that demo! Instructions are in the issue.


promise is not working in  actions on google v2 - firebase function - dialogflow v2

I wanted to get some data from mongodb (using mongoose framework) but unable to get the data,
previously i was using callback method as described here to getting data which was working well for me in "action on google v1" but not working in v2,
then i read here that we must need to use promise in order to make async call in "action on google v2", then i refactored my code according to the instruction of Mr. @prisoner in the question above
you can see my code here:
import * as functions from 'firebase-functions';

import {
    dialogflow,
    SimpleResponse,
    Suggestions,
    DialogflowConversation,
    DialogflowApp
} from 'actions-on-google'

import { Model } from './db'

const app = dialogflow({ debug: false })

app.middleware((conv) => {
    conv["hasScreen"] =
        conv.surface.capabilities.has('actions.capability.SCREEN_OUTPUT');
    conv["hasAudioPlayback"] =
        conv.surface.capabilities.has('actions.capability.AUDIO_OUTPUT');
});

app.intent('Get Some Data', (conv) => {

        console.log("Get Some Data Intent triggered")

        return new Promise(function (resolve, reject) {

            Model.find({}, (err, result: any) => {
                if (!err) {

                    if (!result.length) {

                        console.log("no data found")
                        conv.ask(new SimpleResponse({
                            speech: "no data found"
                        }))
                        resolve();

                    } else {

                        console.log("lots of data found")
                        conv.ask(new SimpleResponse({
                            speech: "lots of data found"
                        }));
                        resolve();

                    }
                } else {
                    console.log("Error in getting data: ", err);
                    conv.ask(new SimpleResponse({
                        speech: "Error in getting data"
                    }))
                    resolve();
                }
            })
        })
});

exports.webhook = functions.https.onRequest(app);

it is still not working for me, and function is ending with timeout
Actually i have my app up and running properly in v1, and now I'm trying to migrate from v1 to v2 since i need to use some latest features which are not available in v1 like voice authentication and other new features.
any help will be warmly welcomed
also asked on stackoverflow https://stackoverflow.com/questions/9022099/how-to-use-mongoose-promise-mongo

+1

What logs are printed out?

Since you are using TypeScript, you can use async await to simplify the code, just make sure the target is es6.
Via the stackoverflow post you linked, mongoose already has promise support built in using .exec().
So the code can be simplified to:
app.intent('Get Some Data', async (conv) => {
  console.log('Get Some Data Intent triggered')
  const query = {} // your query for model here
  try {
    const result = await Model.find(query).exec()
    if (!result.length) {
      console.log('no data found')
      conv.ask(new SimpleResponse({
        speech: 'no data found',
      }))
    } else {
      console.log('lots of data found')
      conv.ask(new SimpleResponse({
        speech: 'lots of data found',
      }))
    }
  } catch (e) {
    console.log('Error in getting data: ', e)
    conv.ask(new SimpleResponse({
      speech: 'Error in getting data',
    }))
  }
})

@canain your solution sounds like a plan, thanks i will try it out today

@Canain @malikasinger1 Any update on this issue?

Closing this since there hasn't been more comments.


Non-Conforming default values with decimal/currency

I am attempting to format currency input elements that have a non-conforming default value identifying the type of amount to be entered. I am not using labels as the default value of the input is used as a tag in a find/replace script to update a textarea element. What I found is this works for the first element, but all remaining elements do not receive the formatting mask. Once the initial value is removed the formatting works as expected. Are non-conforming default values allowed, and if not, is it possible to ignore the formatting mask on the initialization of the element?
I am using jquery.inputmask bundle version 3.3.1
$('.amount').inputmask('decimal', {
radixPoint: '.',
placeholder: '0',
groupSeparator: ',',
digits: 2,
digitsOptional: !1,
autoGroup: true,
prefix: '$',
clearIncomplete: false
});

@CarsonStiles ,
Non-conforming default values are allowed, saying the inputmask tries to apply the mask on it.
Can you give some examples of the default values used.

Below are the input statements I am using for testing. I have tried initializing by both the class and the id with the same results. I don't believe the inputmask attempts to apply the mask on the default value, but something is preventing the mask from being applied to the second element with the cause being related to the default value.
input type="text" class="amount" id="Amount1" name="AmountTest1" value="<>"
input type="text" class="amount" id="Amount2" name="AmountTest2" value="<>"


redacting the nutanix user and password from log stmts

Issue #, if available:
Description of changes:
Now it will show following instead of actual data

NUTANIX_USER=***** -e NUTANIX_PASSWORD=*****

Testing (if applicable):
ran create cluster and observed above
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/assign @abhinavmpandey08

/ok-to-test


Templates in HTML comments are escaped if front-matter is present

I'm refactoring my project's site, and I'm trying to write markdown such that the README.md of the project can also work as the front page of the website. However, some of the contents of the README.md need to be hidden when rendered on the actual website -- so I wanted to use something like the following:

Content I want to hide from the Hugo-generated site.

This works (as documented), however if you create a markdown file that has front-matter like this:

Content I want to hide from the Hugo-generated site.

Then you get the following HTML output:

Content I want to hide from the Hugo-generated site.

All of the above was done with markup.goldmark.renderer.unsafe = true in my config.toml.
What version of Hugo are you using (hugo version)?

$ hugo version
Hugo Static Site Generator v0.72.0 linux/amd64 BuildDate: unknown

Does this issue reproduce with the latest release?
Yes.

This seems like it might be related somewhat to #7092.

And it looks like adding a block HTML comment immediately after the one containing the {{ if false }} results in both comments being stripped from the output. So with a file like:

Content I want to hide from the Hugo-generated site.

You get (note the missing comments):

Content I want to hide from the Hugo-generated site.

And it seems that this is actually caused by the front-matter parsing because if you try to use the following comment it complains that it's invalid YAML:

Content I want to hide from the Hugo-generated site.

The error output being:
Built in 14 ms
Error: Error building site: "/home/cyphar/src/github.com/openSUSE/umoci/README.md:3:1": invalid YAML delimiter


Discard release by platform creates and discards actual release

to be consistent with commit ipmlementation

Looks great.   Plus it is great you "record" the right user in the discarded release.


Adding a profile card

Description
Adding a profile card in the card component of the website ,just like a instagram or twitter profile card
Screenshots

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a GSSOC'24 contributor.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

Go ahead @Vaishnavi1047

https://github.com/Rakesh9100/Beautiify/pull/803/commits
pls look at these commits
On Thu, May 30, 2024 at 11:21 PM Rakesh Roshan @.***>
wrote:

Assigned #835 https://github.com/Rakesh9100/Beautiify/issues/835 to
@Vaishnavi1047 https://github.com/Vaishnavi1047.
—
Reply to this email directly, view it on GitHub
https://github.com/Rakesh9100/Beautiify/issues/835#event-12989810644,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDXTLGBXS6TWJ5B23ZPYJUTZE5RKLAVCNFSM6AAAAABIRLLKMSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSHE4DSOBRGA3DINA
.
You are receiving this because you were assigned.Message ID:
@.***>

Please assign this issue


Using Windows auth as the only IdentityProvider results in infinite loop

Hi,
I've been learning for quite some time how to use IdSrv4 and I managed to build a small webapp acceptiong both local and windows authentication.
Lately I wanted to only offer windows as an IdentityProvider and I've been following the (excellent) quickstart code. Problem is, my requests keep looping during login and by comparing the various requests it looks like I get to the authorize endpoint without the  .AspNetCore.Antiforgery cookie embedded into the request. That's the only difference I could find between using windows auth as a secondary idp or using it as the only one.
This is what I see when I track the various requests:

supposedly the call to the 'authorize' callback should send me to the signin-oidc endpoint..
I'm not sure what else would be useful in solving this but in the meantime I'd like to know if I'm skipping some important parts

I think your ExternalLoginCallback is not properly setting the cookie at IdenittyServer. Compare our samples to what you're doing?

My ExternalLoginCallback is basically the same as the commented code in your samples (aside from the check on the user).
Like I said, I allow windows authentication as an additional button on my main login window and I'm trying to skip the login view.
I've checked every single request made in both these scenarios and the only sensible difference is in the login method:

The working scenario - return View(wm) -  returns the login view along with a AspNetCore.Antiforgery cookie. The other one calls the externalLogin procedure, I just don't understand how obtain the antiforgery cookie since it's not referred anywhere in both the code behind or the views

I've managed to include an AntiForgeryToken in my final request to the Authorize endpoint but it would still reject it and send me back to the Login action in my controller. The only way for me to go through with this scenario is customize the returnUrl and avoid using idp as an acr_value. I'm probably misusing this property but I can't figure out why. Is there any sampling showing how to skip UI login?

if you set the idp on the incoming request - we make sure that the value of idp claim going back matches that.
Setting the idp on acr_values if for scenarios where the client wants to tell the STS to use a specific external provider.

I'm not sure I understood correctly, do you mean I have to set a custom claim on my response matching the idp value on my login request?

First of all - why are you using the acr_values at all?

Because I'd like to bypass the login screen if my application has been set to use an external identity provider as a default and, if I interpreted the documentation correctly, I'm supposed to use that particular field.

OK - so you have two types of logins? username/password and Windows.
In this case the acr_values is a way to achieve bypassing the login screen - the idp claim must then match the acr_values idp name.

I wasn't even aware I had a idp claim on my responses. Anyway I checked and turns out the value on the claim was 'Windows' while the value on my acr_values field was 'windows'. Works flawlessly now. Thank you both so much!


Enable SingleQE join with SegmentGeneralWorkers

For a parallel join, we may benefit if gather SegmentGeneralWorkers to SingleQE.
Gather(SegmentGeneralWorkers) join SingleQE, return join locus: SingleQE. We may win if we are a parallel-aware join, SingleQE is on the inner side that means there is a chance to generate a parallel join under SingleQE. In this case, we have both side parallel and may benefit. See ex 5_P_2_2 in cbdb_parallel.sql
If not parallel-aware, we are not sure for the benefit and a simgle test shows lower performance, ex: parallel scan on replicated table and join with SingleQE which is a non-parallel plan.
SingleQE join Gather(SegmentGeneralWorkers), return join locus: SingleQE. We may win if gather to SingleQE no matter what parallel-aware is. SingleQE is outer side, there could be a parallel plan under it. So we may benefit even without a shared hash table. Let the planner decide.
See ex 2_P_5_2 in cbdb_parallel.sql
The final locus may be elided to Entry if possible.
Authored-by: Zhang Mingli<EMAIL_ADDRESS>

fix #ISSUE_Number

Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:

[ ] Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
[ ] Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
[ ] Learn the coding contribution guide, including our code conventions, workflow and more.
[ ] List your communication in the GitHub Issues or Discussions (if has or needed).
[ ] Document changes.
[ ] Add tests for the change
[ ] Pass make installcheck
[ ] Pass make -C src/test installcheck-cbdb-parallel
[ ] Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

+1

Thanks for review!

Pushed, thanks.


Consider a new middleware for the simple security headers.

Inspired by https://github.com/aspnet/templating/issues/497

X-Content-Type
X-Frame-Options
X-XSS-Protection

But not Content-Security-Policy because that's very app dependent to be on by default, and never ever public-key-pins because that's going away because it sucked.

If it's a middlware then it's not a docs issue @mkArtakMSFT. This is a decision for the MVC team to make on how they want to approach it.


Doesn't shutdown properly when closing a xtdb node.

I didn't do any deeper digging, but it seems like using xtdb-inspector makes the whole problem being unable to close properly, probably because of lingering thread pools or similar.
I spotted the following in the codebase: https://github.com/tatut/xtdb-inspector/blob/8a8ffd7fe6fef5dde6182ed71e7687d70bed74ef/src/xtdb_inspector/metrics.clj#L15
I didn't see any places where you're closing down the thread pool, so my hunch would be that it's the cause of being unable to exit the program normally after closing a xtdb database using xtdb-inspector.

Thanks for the report, indeed it wasn't shutdown anywhere.


Security WDS update

Change Type

[ ] Feature
[x] Chore
[ ] Bug Fix

Change Level

[ ] major
[ ] minor
[x] patch

Further Information (screenshots, etc)
Relevant Links (bug reports, etc)
Checklist

[ ] Added tests / did not decrease code coverage
[ ] Tested across browsers

Coverage remained the same at 91.509% when pulling d527e155a7124945505a3d70bbe8a3038ce8bbed on chore/updates into dd6491911eb19c9dc9b1cadd15601b2d6cf4eae2 on master.


is this library not longer maintained?

Even though this library is still working quite fine, It generates more and more warnings in every release of iOS and Xcode.
All of those warnings, and some other fixes for found issues, have opened pull requests which are not reviewed or merged. I see the last commit on this repo was on 19 June 2015.
Is this library not longer maintained? Is there any active fork we should consider to use?

I think this library is no longer maintained.
You can have a look here:  #763
Or here: https://github.com/iDevelopper/PBRevealViewController (very similar library with some mores features)


Add 'unmet dependency' warnings

npm has these:
npm WARN unmet dependency /home/travis/build/rstacruz/pnpm/node_modules/nixt/node_modules/changelog requires<EMAIL_ADDRESS>but will load
npm WARN unmet dependency /home/travis/build/rstacruz/pnpm/node_modules/chalk,
npm WARN unmet dependency which is version 1.1.1
npm WARN unmet dependency /home/travis/build/rstacruz/pnpm/node_modules/nixt/node_modules/changelog requires<EMAIL_ADDRESS>but will load
npm WARN unmet dependency /home/travis/build/rstacruz/pnpm/node_modules/semver,
npm WARN unmet dependency which is version 5.1.0

pnpm's model isn't immune to this (in fact is more prone to it), so it might be prudent to have it implemented as well.

This was covered by #433


welder stuff

About the PR

being lit consumes 2 fuel/s
added vv rw to most server weldercomponent fields
no fuel used after welding something, cost is based solely off time required

Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
:cl:

tweak: Welders have been reworked.

100% can get behind this, always thought it was dumb that the welder consumed fuel per weld instead of it being a time thing.