Update help text on tools/modules/update.sh to be runnable from commandline. [phab:D1778]

Created by danielmoy-google at 2017-07-17 23:14:14:
This time without all of the random java refactoring rolled into the same arc land.

schroederc accepted this revision at 2017-07-17 23:15:07

danielmoy-google closed via commit 4afa1b684423c72f90a3da1c5a64fa7c8731f78c at 2017-07-17 23:15:39


uart: native_posix: Fix out of bounds access

Fix an out of bound access in the native_posix uart driver,
when generating the string to autoattach a terminal to the UART.
(The space for the null termination was missing)
Fixes: #14401
Coverity issue CID: 195855
Signed-off-by: Alberto Escolar Piedras<EMAIL_ADDRESS>

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@c8dfdb6). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #14472   +/-   ##
=========================================
  Coverage          ?      52%
=========================================
  Files             ?      308
  Lines             ?    45554
  Branches          ?    10545
=========================================
  Hits              ?    23691
  Misses            ?    17063
  Partials          ?     4800

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8dfdb6...c1e059a. Read the comment docs.


use gps to make a path

I have gps plugin on the ar drone i wont to make "go to" function
who i can to recive the gps data and who to use the data to make the path
have two problem

i dont see the gps data in the  navdata function

how i can isolate one data from hit and how to use it

@ambtid I would like to work on the issue...is there any software where I can execute your scenario


Ability to Promote values from Unreal Crash Reporter to Sentry Tags

What problem could Sentry solve that it doesn't?
We would like to use values such as Unreal.engine_mode and unreal.build_configuration as a tag
Can we have a method to promote these values?

@Edstub207 can you please elaborate a bit more on how you'd think the corresponding API should look? It's already possible to add new tags with the USentrySubsystem::SetTag method and the values mentioned above can be obtained using FGenericPlatformMisc::GetEngineMode() and FApp::GetBuildConfiguration respectively.

@tustanivsky It would be nice to not have it duplicated, so the ability to promote values I guess within the settings would be cool. Although, just adding via the SetTag method is possible


This tutorial says you need to install the ".NET Core cross-platform development" workload but the installer UI does not have any such workload

https://learn.microsoft.com/en-us/microsoftteams/platform/sbs-gs-csharp?tutorial-step=1
This page says to choose the ".NET Core cross-platform development" workload but the Visual Studio installer does not have any such workload listed that I can see.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 868d10d0-97f7-0be0-3cf5-8a26ad6db573
Version Independent ID: 868d10d0-97f7-0be0-3cf5-8a26ad6db573
Content: Hello World with C# - Teams
Content Source: msteams-platform/sbs-gs-csharp.yml
Service: msteams
GitHub Login: @surbhigupta
Microsoft Alias: lajanuar

Thanks @AE-MS for raising this issue. We also noticed that .NET Core cross-platform development workload is no where listed in Visual Studio.
@surbhigupta12 - Requesting your help to remove the mentions of .NET Core cross-platform development workload from all the instances from the documentations.
Few other places where we have seen this being mentioned:
Create Teams conversation bot - Teams | Microsoft Learn
Prerequisites - Teams | Microsoft Learn


read csv file by character range

Hello, I wanted to know if it was possible to read this type of file but by character that is to say that if character 0 to 10 is the data of a column and so on
3152450707<PHONE_NUMBER>0000413213200003201810090158925201810091514512018101200000001
3505387060<PHONE_NUMBER>0000114314300004201908050107436201908051602462019081500000001
3226561807<PHONE_NUMBER>0000314312100004202009240104300202009241435572020100700000001
3163139394<PHONE_NUMBER>0000413213200003201107290100010201107291334002011080500000001

Hi,
The CSV format expects some kind of separator between the fields, so no, ExcelDataReader probably can't read your files.
But there are other libraries out there that can read files with fixed length fields. I worked on a project using the "FileHelpers" library to parse structured, fixed-length data out of OCR scans, and it worked: https://www.nuget.org/packages/FileHelpers/


Issue #367: Git Private Repository Authentication

Respect siteUsername: and sitePassword when downloading Zips.
OT: Fix "Metacello-Platform" package pharo30 branch, which had incorrect meta-data incorrectly specifying the package name including the branch i.e. "Metacello-Platform.pharo30"

What needs to be done here?

Given that there were a large number of test failures one step is to rerun the tests, but at the moment I am struggling with getting Squeak4.6 and Squeak5.0 added so I've prioritized doing that inform of this one ....
I haven't looked at all of the failing tests, so I don't know if there are additional issues or not ... the load failures are due to network failures and rerunning should show whether or there are actual code-based problems ...

@seandenigris, when you get a chance can you make a minor change to a file (like add a line to the README.md)? I'm getting massive failures for tests and I'm not sure whether travis is just confused or something else is going on ... "pinging travis" will at least eliminate travis is confused ...

I guess this should be closed

Closing this PR - storing username/passwords in the image is not a good idea. the discussion in Issue #475 addresses the larger issue of enabling "first class access" to private repositories that require usernames and passwords ...


MINOR: Fix kafkatest advertised listeners

Followup for https://github.com/apache/kafka/pull/17146
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

I encountered the following error locally with this patch. @ahuang98 Could you please take a look?
rror("'KafkaService' object has no attribute 'dynamicRaftQuorum'")
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/dist-packages/ducktape/tests/runner_client.py", line 186, in _do_run
    data = self.run_test()
  File "/usr/local/lib/python3.9/dist-packages/ducktape/tests/runner_client.py", line 246, in run_test
    return self.test_context.function(self.test)
  File "/usr/local/lib/python3.9/dist-packages/ducktape/mark/_mark.py", line 433, in wrapper
    return functools.partial(f, *args, **kwargs)(*w_args, **w_kwargs)
  File "/opt/kafka-dev/tests/kafkatest/tests/client/message_format_change_test.py", line 88, in test_compatibility
    self.kafka.start()
  File "/opt/kafka-dev/tests/kafkatest/services/kafka/kafka.py", line 674, in start
    Service.start(self, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/ducktape/services/service.py", line 265, in start
    self.start_node(node, **kwargs)
  File "/opt/kafka-dev/tests/kafkatest/services/kafka/kafka.py", line 892, in start_node
    prop_file = self.prop_file(node)
  File "/opt/kafka-dev/tests/kafkatest/services/kafka/kafka.py", line 772, in prop_file
    self.set_protocol_and_port(node)
  File "/opt/kafka-dev/tests/kafkatest/services/kafka/kafka.py", line 755, in set_protocol_and_port
    if (self.dynamicRaftQuorum and quorum.NodeQuorumInfo(self.quorum_info, node).has_controller_role) or \
AttributeError: 'KafkaService' object has no attribute 'dynamicRaftQuorum'

@chia7712 thanks for bringing that up, non-kraft mode tests would likely fail since dynamicRaftQuorum wasn't initialized in that case

having issues with the branch builder :( it worked for me yesterday but not today
paramiko.ssh_exception.SSHException: encountered RSA key, expected OPENSSH key

https://semaphore.ci.confluent.io/jobs/104b6698-910a-4958-9247-a759cb786c0d

@bbejeck what are the tests you are trying to run/does this change resolve your test failures?

@chia7712 tried running message_format_change_test.py locally and it is passing with this change

@ahuang98 the tests under tests/kafkatest/tests/streams I'll update trunk and re-run and let you know.

@ahuang98 I still get the following error
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/dist-packages/ducktape/tests/runner_client.py", line 186, in _do_run
    data = self.run_test()
  File "/usr/local/lib/python3.9/dist-packages/ducktape/tests/runner_client.py", line 246, in run_test
    return self.test_context.function(self.test)
  File "/usr/local/lib/python3.9/dist-packages/ducktape/mark/_mark.py", line 433, in wrapper
    return functools.partial(f, *args, **kwargs)(*w_args, **w_kwargs)
  File "/opt/kafka-dev/tests/kafkatest/tests/streams/streams_optimized_test.py", line 61, in test_upgrade_optimized_topology
    self.kafka.start()
  File "/opt/kafka-dev/tests/kafkatest/services/kafka/kafka.py", line 675, in start
    Service.start(self, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/ducktape/services/service.py", line 265, in start
    self.start_node(node, **kwargs)
  File "/opt/kafka-dev/tests/kafkatest/services/kafka/kafka.py", line 909, in start_node
    node.account.ssh(cmd)
  File "/usr/local/lib/python3.9/dist-packages/ducktape/cluster/remoteaccount.py", line 35, in wrapper
    return method(self, *args, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/ducktape/cluster/remoteaccount.py", line 310, in ssh
    raise RemoteCommandError(self, cmd, exit_status, stderr.read())
ducktape.cluster.remoteaccount.RemoteCommandError: ducker@ducker03: Command '/opt/kafka-dev/bin/kafka-storage.sh format --ignore-formatted --config /mnt/kafka/kafka.properties --cluster-id I2eXt9rvSnyhct8BYmW6-w' returned non-zero exit status 1. Remote error message: b'Exception in thread "main" java.lang.IllegalArgumentException: requirement failed: If process.roles contains just the \'broker\' role, the node id 2 must not be included in the set of voters controller.quorum.voters=Set(2)\n\tat scala.Predef$.require(Predef.scala:337)\n\tat kafka.server.KafkaConfig.validateValues(KafkaConfig.scala:921)\n\tat kafka.server.KafkaConfig.<init>(KafkaConfig.scala:830)\n\tat kafka.server.KafkaConfig.<init>(KafkaConfig.scala:185)\n\tat kafka.tools.StorageTool$.$anonfun$execute$1(StorageTool.scala:80)\n\tat scala.Option.flatMap(Option.scala:283)\n\tat kafka.tools.StorageTool$.execute(StorageTool.scala:80)\n\tat kafka.tools.StorageTool$.main(StorageTool.scala:47)\n\tat kafka.tools.StorageTool.main(StorageTool.scala)\n'

@bbejeck thanks a bunch, taking a look!

@bbejeck I'm not seeing that error locally, I get the following with no obvious errors in the logs
    TimeoutError("Kafka server didn't finish startup in 60 seconds")
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/dist-packages/ducktape/tests/runner_client.py", line 186, in _do_run
    data = self.run_test()
  File "/usr/local/lib/python3.9/dist-packages/ducktape/tests/runner_client.py", line 246, in run_test
    return self.test_context.function(self.test)
  File "/usr/local/lib/python3.9/dist-packages/ducktape/mark/_mark.py", line 433, in wrapper
    return functools.partial(f, *args, **kwargs)(*w_args, **w_kwargs)
  File "/opt/kafka-dev/tests/kafkatest/tests/streams/streams_optimized_test.py", line 69, in test_upgrade_optimized_topology
    self.kafka.start()
  File "/opt/kafka-dev/tests/kafkatest/services/kafka/kafka.py", line 682, in start
    self.wait_for_start(node, monitor, timeout_sec)
  File "/opt/kafka-dev/tests/kafkatest/services/kafka/kafka.py", line 925, in wait_for_start
    monitor.wait_until("Kafka\s*Server.*started", timeout_sec=timeout_sec, backoff_sec=.25,
  File "/usr/local/lib/python3.9/dist-packages/ducktape/cluster/remoteaccount.py", line 753, in wait_until
    return wait_until(lambda: self.acct.ssh("tail -c +%d %s | grep '%s'" % (self.offset + 1, self.log, pattern),
  File "/usr/local/lib/python3.9/dist-packages/ducktape/utils/util.py", line 58, in wait_until
    raise TimeoutError(err_msg() if callable(err_msg) else err_msg) from last_exception
ducktape.errors.TimeoutError: Kafka server didn't finish startup in 60 seconds

just confirming - do you see that error when checking out just this PR branch?

@ahuang98
For this KafkaService config
self.kafka = KafkaService(self.test_context, num_nodes=3, controller_num_nodes_override=1,
                                  zk=None, topics=self.topics, dynamicRaftQuorum=False)

I get the error I've posted before
File "/usr/local/lib/python3.9/dist-packages/ducktape/cluster/remoteaccount.py", line 310, in ssh
    raise RemoteCommandError(self, cmd, exit_status, stderr.read())
ducktape.cluster.remoteaccount.RemoteCommandError:
ducker@ducker03: Command '/opt/kafka-dev/bin/kafka-storage.sh format --ignore-formatted --config /mnt/kafka/kafka.properties --cluster-id I2eXt9rvSnyhct8BYmW6-w' returned non-zero exit status 1. Remote error message: b'Exception in thread "main" java.lang.IllegalArgumentException: requirement failed:
If process.roles contains just the 'broker' role, the node id 2 must not be included in the set of voters controller.quorum.voters=Set(2)\n\tat

If I update it to have a combined controller+broker per node
self.kafka = KafkaService(self.test_context, num_nodes=3,
                                  zk=None, topics=self.topics, dynamicRaftQuorum=False)

I get this
ducktape.cluster.remoteaccount.RemoteCommandError: ducker@ducker02: Command '/opt/kafka-dev/bin/kafka-topics.sh --bootstrap-server ducker02:9092,ducker03:9092,ducker04:9092 --create --topic inputTopic  --partitions 6 --replication-factor 1' returned non-zero exit status 1.
 Remote error message: b'[2024-09-27 21:05:38,441]
ERROR org.apache.kafka.common.errors.TimeoutException:
Timed out waiting for a node assignment. Call: createTopics\n (org.apache.kafka.tools.TopicCommand)\n'

I also tried using the isolated_kafka mode and when I did that I received the Kafka server didn't finish startup in 60 second error
HTH

figured out the issue, another error in the new list comprehension 😅 in favor of code clarity, I'm going to opt for some code duplication

@ahuang98 - that did it! Thanks for your efforts to get this fixed, this test was failing previously without this fix
[INFO:2024-09-28 08:46:22,475]: RunnerClient: Loading test {'directory': '/opt/kafka-dev/tests/kafkatest/tests/streams', 'file_name': 'streams_optimized_test.py', 'cls_name': 'StreamsOptimizedTest', 'method_name': 'test_upgrade_optimized_topology', 'injected_args': {'metadata_quorum': 'COMBINED_KRAFT'}}
[INFO:2024-09-28 08:46:22,478]: RunnerClient: kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=COMBINED_KRAFT: on run 1/1
[INFO:2024-09-28 08:46:22,480]: RunnerClient: kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=COMBINED_KRAFT: Setting up...
[INFO:2024-09-28 08:46:22,480]: RunnerClient: kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=COMBINED_KRAFT: Running...
[INFO:2024-09-28 08:47:07,619]: RunnerClient: kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=COMBINED_KRAFT: Tearing down...
[INFO:2024-09-28 08:47:36,272]: RunnerClient: kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=COMBINED_KRAFT: PASS
[WARNING - 2024-09-28 08:47:36,273 - runner_client - log - lineno:294]: RunnerClient: kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=COMBINED_KRAFT: Test requested 9 nodes, used only 8
[WARNING:2024-09-28 08:47:36,273]: RunnerClient: kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=COMBINED_KRAFT: Test requested 9 nodes, used only 8
[INFO:2024-09-28 08:47:36,275]: RunnerClient: kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=COMBINED_KRAFT: Data: None
================================================================================
SESSION REPORT (ALL TESTS)
ducktape version: 0.11.4
session_id:       2024-09-28--001
run time:         1 minute 13.818 seconds
tests run:        1
passed:           1
flaky:            0
failed:           0
ignored:          0
================================================================================
test_id:    kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=COMBINED_KRAFT
status:     PASS
run time:   1 minute 13.795 seconds
--------------------------------------------------------------------------------

Kicked off system test build - will post the results here later

Getting this error running system tests on branch builder
paramiko.ssh_exception.SSHException: encountered RSA key, expected OPENSSH key27:12
make: *** [Makefile:172: branch-builder-run-system-tests] Error 1

Getting this error running system tests on branch builder

same :(

My local env wasn't up for running the full suite of tests, but here are the results of one test run
[INFO:2024-09-29 08:09:04,805]: starting test run with session id 2024-09-29--001...
[INFO:2024-09-29 08:09:04,805]: running 1 tests...
[INFO:2024-09-29 08:09:04,806]: Triggering test 1 of 1...
[INFO:2024-09-29 08:09:04,816]: RunnerClient: Loading test {'directory': '/opt/kafka-dev/tests/kafkatest/tests/streams', 'file_name': 'streams_optimized_test.py', 'cls_name': 'StreamsOptimizedTest', 'method_name': 'test_upgrade_optimized_topology', 'injected_args': {'metadata_quorum': 'COMBINED_KRAFT'}}
[INFO:2024-09-29 08:09:04,818]: RunnerClient: kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=COMBINED_KRAFT: on run 1/1
[INFO:2024-09-29 08:09:04,820]: RunnerClient: kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=COMBINED_KRAFT: Setting up...
[INFO:2024-09-29 08:09:04,820]: RunnerClient: kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=COMBINED_KRAFT: Running...
[INFO:2024-09-29 08:09:48,114]: RunnerClient: kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=COMBINED_KRAFT: Tearing down...
[INFO:2024-09-29 08:10:13,728]: RunnerClient: kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=COMBINED_KRAFT: PASS
[WARNING - 2024-09-29 08:10:13,728 - runner_client - log - lineno:294]: RunnerClient: kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=COMBINED_KRAFT: Test requested 9 nodes, used only 8
[WARNING:2024-09-29 08:10:13,729]: RunnerClient: kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=COMBINED_KRAFT: Test requested 9 nodes, used only 8
[INFO:2024-09-29 08:10:13,730]: RunnerClient: kafkatest.tests.streams.streams_optimized_test.StreamsOptimizedTest.test_upgrade_optimized_topology.metadata_quorum=COMBINED_KRAFT: Data: None
================================================================================
SESSION REPORT (ALL TESTS)
ducktape version: 0.11.4
session_id:       2024-09-29--001
run time:         1 minute 8.942 seconds

this PR unblocks running system tests without needing to set dyanmicRaftQuorum=true so I'm going to merge it.

Thanks @ahuang98 for the fix!

Merged #17294 into trunk


Changes to OpenApiInfo via DocumentFilter persist between Swagger generations

I'm trying to use a DocumentFilter's OpenApiDocument object to conditionally apply changes based on extensions. For example, a spec meant for internal use would have an extension. Then DocumentFilters would conditionally apply, depending on that internal extension. Afterwards, this extension would be removed from the generated spec.
c.SwaggerDoc("v1.0", new OpenApiInfo
{
   ...
   Extensions = new Dictionary<string, IOpenApiExtension>
   {
      // Used internally to determine swagger spec generation. Afterwards, the extension is removed via filter
      { "generationType", new OpenApiString("internal") }
   }
});

The issue is that after the initial removal, generationType does not exist on the next generation.
My use case needs specifically Extensions, but I've found that the same issue applies to Title (and potentially other OpenApiInfo properties). For example, consider:
...
c.SwaggerDoc("v1", new OpenApiInfo { Title = "Test API", Version = "1" });
...
c.DocumentFilter<TitleChange>();
...

public class TitleChange: IDocumentFilter
{
    public void Apply(OpenApiDocument swaggerDoc, DocumentFilterContext context)
    {
        if (swaggerDoc.Info.Title == "Test API")
        {
            // First execution generates spec with title "Hello"
            swaggerDoc.Info.Title = "Hello";
        }
        // This is expected to never be hit
        else if (swaggerDoc.Info.Title == "Hello")
        {
            // Second execution generates spec with title "World"
            swaggerDoc.Info.Title = "World";
        }
    }
}

If this is intended behavior, I'd really appreciate an idea on how to approach conditional filtering on a per-SwaggerDoc basis.

Workaround 1, clone the Info (PROS: one-liner, CONS: slower and may break if OpenApiInfo stops being serializable):
void IDocumentFilter.Apply(OpenApiDocument swaggerDoc, DocumentFilterContext context)
{
    // Clone the Info
    swaggerDoc.Info = System.Text.Json.JsonSerializer.Deserialize<OpenApiInfo>(System.Text.Json.JsonSerializer.Serialize(swaggerDoc.Info));

    swaggerDoc.Info.Description += $"\n\nModified!";
}

Workaround 2, remember which Info has been modified:
private static readonly Dictionary<string, OpenApiInfo> _modifiedInfos = new Dictionary<string, OpenApiInfo>();

void IDocumentFilter.Apply(OpenApiDocument swaggerDoc, DocumentFilterContext context)
{
    // Modify the Info only once
    if (_modifiedInfos.ContainsValue(swaggerDoc.Info)) return;
    _modifiedInfos[context.DocumentName] = swaggerDoc.Info;

    swaggerDoc.Info.Description += $"\n\nModified!";
}

I have opted for Workaround 2, I hope it won't break when this issue is fixed.

Related to #1923


Fix obs workflow so that the submit job runs correctly on releases

...also renames few things here and there. 😬

LGTM.


fix: Remove unneeded check of list nullness from extractResources method

Fixes: #752

Closing - As discussed, I will make this change once I've run it past all stakeholders.


SharePoint Framework interactivity with SharePoint multilingual pages

What type of issue is this?
other
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Target SharePoint environment
SharePoint Online
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[ ] 💥 Microsoft Edge
[ ] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[X] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details

SPFx version: 1.13

Issue description
Currently when you build a multilingual page in SharePoint and create translations all first party web parts honor the language of the page and override the user's current language preference. The SharePoint Framework for 3rd party developers has no straightforward way to accomplish this same thing.
Ideally the context would include an additional property that would surface some of the hidden page properties for multilingual pages like _SPTranslationLanguage so that localization of the web part could work off that value in the cases where an SPFx web part is put on a multilingual page. For instance, if there was an additional property here something like pageLanguage. If in addition if there is a page language it could also affect localization like the currentUICultureName does, that would be even better. The long and the short of it is that it's very confusing to users, and nearly impossible to explain to them why 3rd party web parts on multilingual pages do not honor the translation language. There is obviously api calls we could make to get the data and then build a separate implementation of the localization to honor it but that's undesirable.

Thank you for opening this issue. Closing since this is not an issue directly with SPFx, but we have opened a bug for the product team.


Fix/brand url generation

closes #860

hey @alecritson i didn't notice you already merged in the fix. should i close this or merge and keep the other changes?

@alecritson done :)


Refactor Values to Artifact Protocol

Resolves #156.
This PR refactors the MLTE Value system to the artifact protocol. Specifically, it makes the following changes:

Refactors MLTE value types to be compatible with the artifact protocol
Refactors the artifact protocol itself slightly to utilize discriminated unions; this was not an issue in the original PR because there was only a single artifact type
Refactors the implementation of EvidenceMetadata to be serializable, like a MLTE artifact

Remaining items:

Refactor the EvidenceMetadata and Identifier classes to exist in the same module
Implement support for extending Values with the mlte.value.base implementation

Remaining items:

Refactor the EvidenceMetadata and Identifier classes to exist in the same module
Add "update test/fixture/artifact.py to TODO list for artifact protocol ports
Update the ConfusionMatrix type in demo


Add The Free Chess Club app

Add The Free Chess Club app.

This looks like a nice app. Can you add those screenshots to the metadata too?
screenshots:
  -
    imageUrl: 'https://mysite.com/awesome1.png'
    caption: 'Awesome screenshot 1'
    imageLink: 'https://mysite.com/awesome.html'
  -
    imageUrl: 'https://mysite.com/awesome2.png'
    caption: 'Awesome screenshot 2'
    imageLink: 'https://mysite.com/awesome.html'

Screenshots are not currently displayed on the site, but they will be soon.

Added screenshots to metadata - thanks.

👑


Fetch only when payload-token is set

This is not really an issue but a proposal for a performance improvement. The component is initially fetching "me" to detect if a user is logged in. For regular visitors this increases the initial load even though they are not editors. In my own project I used a wrapper for the AdminBar to check if the payload-token HttpOnly Cookies is set. If so I render the admin bar which fetches "me". I could open a PR with this approach applied if someone else finds this useful.
const hasHttpOnlyCookie = (key: string) => {
    document.cookie = key + "=anything;path=/;";
    return document.cookie.indexOf(key + "=") == -1;
  }

  useEffect(() => {
    const tokenExists = hasHttpOnlyCookie("payload-token");
    if (tokenExists) setShowAdminBar(true);
  }, []);

Code snippet for Next.js SSR:
import { cookies } from 'next/headers';

...

function MyComponent() {
    const cookieStore = cookies();

    if (!cookieStore.has('payload-token')) {
        return null:
    }

    ...
}

This completely removes the admin bar for non-Payload users.

import { cookies } from 'next/headers';

Thanks for this @cbratschi Does this mean that you load the AdminBar in a server component? So without using 'use client'?

@cbratschi That's what I've been working on yesterday as well, using a combo of server and client
export const AdminBar: React.FC<AdminBarProps> = async (props) => {
  const payload = await getPayload({config})
  const headers = await getHeaders()
  const {user} = await payload.auth({headers})

  if (!user) {
    return
  }

  return (
    <div>
      <AdminBarView {...props} />
    </div>
  )
}

@notflip thanks for mentioning this. We also render the admin bar in previews. We use a separate route for the previews and pass a preview property to the rendering component. Put it on our to do list 👍


added my profile

@sparkey667  thnx for contributing, try this year, and make sure you follow me and star this repo for updates about special swags I will be giving.
Contribute in October for Hacktoberfest 2020


[Event Request] Codeunit Available to Promise, Function CalcAllItemFields

Hi,
to manage calculation of additional (own, new) FlowFields (Item table) in this procedure it would be very helpful if you could insert the following event:

Please define Item as var

Thanks!

You help us implementing the requests faster when your request contains AL code copied from VSCode instead of screenshots.

Thanks for the suggestion, I will do that

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


[BUG] Sorry, we might be overloaded, try again later.

Hello,
I don't know where I'm making a mistake, but once I launch the front end after following the documentation for the backend I hosted on your platform, I get this message after asking a question:
Sorry, we might be overloaded, try again later.
Can anyone help me? Thank you

It might be temporary - if you retry at another time, does things work? Also, kindly make sure you have done lep login.

I came across the same situation

I haven't resolved this issue either. I noticed the following error displayed in the developer console

We had an issue yesterday re supabase (supabase updated the service url and triggered some errors). It should be back now. For the error 403 forbidden - is that due to missing credentials? Make sure you do lep login to log in to your workspace.


Add extension to swagger to capture EligibleDeploymentScopes

Right now we don't have a high-confidence way of determining which resource types are valid at which deployment scopes. We should add an extension to swagger for RP teams to capture this detail in their API definitions.

For schema generation, we maintain a list of ambiguously-scoped resources here, which we should be able to leverage to get started, once the spec for a swagger extension has been approved:
https://github.com/Azure/azure-resource-manager-schemas/blob/master/generator/autogenlist.ts

For schema generation, we maintain a list of ambiguously-scoped resources here, which we should be able to leverage to get started, once the spec for a swagger extension has been approved:
https://github.com/Azure/azure-resource-manager-schemas/blob/master/generator/autogenlist.ts


net: TestInterfaceAddrsWithNetsh fail on Windows 7

Go1.6rc1 on Windows 7, CGO_ENABLE=0:
--- FAIL: TestInterfaceAddrsWithNetsh (36.29s)
        net_windows_test.go:446: VMware Network Adapter VMnet8: unexpected addresses list ["<IP_ADDRESS>/24" "fe80::1587:c020:5827:b719"], want []
FAIL
FAIL    net     120.223s

The underlying cause is that netsh doesn't print anything when queried for this interface:
> netsh interface ipv4 show address name="VMware Network Adapter VMnet8"
[Nothing, just two blank lines]

But all information is output if not asked for this specific interface:
> netsh interface ipv4 show address
[...snip...]
Configuration for interface "VMware Network Adapter VMnet8"
    DHCP enabled:                         No
    IP Address:                           <IP_ADDRESS>
    Subnet Prefix:                        <IP_ADDRESS>/24 (mask <IP_ADDRESS>)
    InterfaceMetric:                      20
[...snip...]

If the adapter is disabled this tests passes but then TestInterfaceHardwareAddrWithGetmac fails:
net_windows_test.go:528: getmac lists "VMware Network Adapter VMnet8", but it could not be found among Go interfaces
There might be some problem with this interface on Windows side.

CC @alexbrainman @mikioh

@vdobler can you, please, run TestInterfaceHardwareAddrWithGetmac alone and show its error message in full. I think your error message above is missing its end. Thank you.
Alex

@alexbrainman Now it is Blootooth... :
$ go test -v -run TestInterfaceHardwareAddrWithGetmac net
=== RUN   TestInterfaceHardwareAddrWithGetmac
--- FAIL: TestInterfaceHardwareAddrWithGetmac (3.14s)
net_windows_test.go:515: getmac lists "Bluetooth Network Connection", but it could not be found among Go interfaces map[isatap.{4A074996-3924-459F-BFCD-5970475AE151}:00:00:00:00:00:00:00:e0 VirtualBox Host-Only Network #2:08:00:27:00:60:5e Local Area Connection:ec:f4:bb:35:28:68 VirtualBox Host-Only Network #5:08:00:27:00:30:d5 VMware Network Adapter VMnet8:00:50:56:c0:00:08 isatap.{4A17C321-4472-4A7C-A305-82158B608E7F}:00:00:00:00:00:00:00:e0 isatap.{7F1E7FEE-3396-49AD-B22F-9B6A81EB3729}:00:00:00:00:00:00:00:e0 Reusable ISATAP Interface {D4CB953B-8F67-4964-B997-0A546C44D51F}:00:00:00:00:00:00:00:e0 isatap.{718ADE47-5B44-4AE4-A10E-849CDE26215D}:00:00:00:00:00:00:00:e0 Wireless Network Connection:80:86:f2:8e:55:a8 isatap.{A7C3755F-5CE1-4695-A67D-67C085D99088}:00:00:00:00:00:00:00:e0 Teredo Tunneling Pseudo-Interface:00:00:00:00:00:00:00:e0 isatap.{3160AADB-41E4-4A1A-B73F-D3FDBF455AE2}:00:00:00:00:00:00:00:e0 isatap.{FB7C9315-676D-4EAE-B550-CB8F59586F86}:00:00:00:00:00:00:00:e0 VirtualBox Host-Only Network #6:08:00:27:00:54:f8 isatap.{6E13A897-4E51-4F7A-8809-1D5B29E0CDF6}:00:00:00:00:00:00:00:e0 isatap.{E4154231-E9E3-45E0-8275-1AF043445EC0}:00:00:00:00:00:00:00:e0 Wireless Network Connection 2:82:86:f2:8e:55:a8 isatap.{954555DC-152A-4369-8EA8-6CE0F48ACBE3}:00:00:00:00:00:00:00:e0 isatap.{DD0440CD-133C-46D3-92ED-F6CE20D50AD4}:00:00:00:00:00:00:00:e0 Mobile Broadband Connection:00:a0:c6:00:00:12 VirtualBox Host-Only Network #4:08:00:27:00:8c:64 VMware Network Adapter VMnet1:00:50:56:c0:00:01 isatap.{9C819DC3-C04B-4D4C-904E-081E478C9765}:00:00:00:00:00:00:00:e0 VirtualBox Host-Only Network #3:08:00:27:00:fc:ba VirtualBox Host-Only Network:08:00:27:00:10:b7 isatap.{4BAD2286-A5D2-4D48-9C4D-4BCC6BFBA72A}:00:00:00:00:00:00:00:e0 Local Area Connection 2:00:ad:e1:ac:1c:1a]
FAIL
exit status 1
FAIL    net     3.257s

@vdobler I am confused now. Your last error messages says: net_windows_test.go:515: getmac lists ..., but current net_windows_test.go:515 line cannot output this error. You must have changed the net_windows_test.go file. Your original error also says: net_windows_test.go:528: getmac lists ..., which seems correct to me - just another indication that you have changed the code.
But regardless of you changed the code. I don't see how TestInterfaceHardwareAddrWithGetmac is at fault here. The test has found "Bluetooth Network Connection" in the output of getmac /fo list /v command. Please check manually that "Bluetooth Network Connection" is listed in the output of getmac /fo list /v command. If "Bluetooth Network Connection" is listed by getmac command, it surely has to be returned by net.Interfaces function (see net_windows_test.go:459), and, it seems like, it is not. The only possible glitch in TestInterfaceHardwareAddrWithGetmac is that it ignores interfaces with net.FlagLoopback not set. But "Bluetooth Network Connection" should not be one of those. Can you, please, remove thse lines:
diff --git a/src/net/net_windows_test.go b/src/net/net_windows_test.go
index 095a339..e54199b 100644
--- a/src/net/net_windows_test.go
+++ b/src/net/net_windows_test.go
@@ -462,10 +462,6 @@ func TestInterfaceHardwareAddrWithGetmac(t *testing.T) {
 	}
 	have := make(map[string]string)
 	for _, ifi := range ift {
-		if ifi.Flags&FlagLoopback != 0 {
-			// no MAC address for loopback interfaces
-			continue
-		}
 		have[ifi.Name] = ifi.HardwareAddr.String()
 	}

to see if it makes TestInterfaceHardwareAddrWithGetmac PASS? If TestInterfaceHardwareAddrWithGetmac is still broken, show us output of getmac /fo list /v command. Does "Bluetooth Network Connection" have non-blank MAC address there. If it does, surely net package should return the MAC too.
Thank you.
Alex

@alexbrainman Thanks for the feedback. And please excuse the confusion I produced, I'll try to be more systematic.
I think the Go code itself is okay and worksproperly**.
But the test code executes netstat and getmac commands and parses their output and I believe this to be not robust enough. Actually these are two different non-robust tests; sorry for mixing these up in one issue.
I verified the following on go1.6rc1 and go1.6rc2 with a clean Go source tree and a (halfway freshly booted Windows 7 Enterprise Service Pack 1 with VMware Player 7.1.2 build-2780323 installed).
TestInterfaceAddrsWithNetsh
--- FAIL: TestInterfaceAddrsWithNetsh (13.02s)
    net_windows_test.go:446: VMware Network Adapter VMnet8: unexpected addresses list ["<IP_ADDRESS>/24" "fe80::1587:c020:5827:b719"], want []

but the problem is not the Go code as "<IP_ADDRESS>/24" is fine as it is the proper address as can be seen by running:
$ netsh interface ipv4 show address | grep -A 4 "VMware Network Adapter VMnet8"
Configuration for interface "VMware Network Adapter VMnet8"
    DHCP enabled:                         No
    IP Address:                           <IP_ADDRESS>
    Subnet Prefix:                        <IP_ADDRESS>/24 (mask <IP_ADDRESS>)
    InterfaceMetric:                      20

Unfortunately the test code tries to get the address by executing
$ netsh interface ipv4 show address name="VMware Network Adapter VMnet8"

which returns 0 but prints just one blank line:
$ netsh interface ipv4 show address name="VMware Network Adapter VMnet8" | od -ta
0000000  cr  nl
0000002

This is strange and clearly a Windows-only, maybe even a "my-computer-only" problem.
The test code relies on the fact that netsh name="_the-name_" really returns sensible data which is not the case for my VMware Network Adapter VMnet8
Maybe parsing the whole output of netsh interface ipv4 show address could make the test more robust.
TestInterfaceHardwareAddrWithGetmac
If I disable (through Control Panel\Network and Internet\Network Connections) "VMware Network Adapter VMnet8" and have the wireless network turned off via the hardware switch then:
--- FAIL: TestInterfaceHardwareAddrWithGetmac (3.17s)
    net_windows_test.go:515: getmac lists "Bluetooth Network Connection", but it could not be found among Go interfaces map[VirtualBox Host-Only Network #2:08:00:27:00:60:5e VirtualBox Host-Only Network #5:08:00:27:00:30:d5 VirtualBox Host-Only Network #6:08:00:27:00:54:f8 Teredo Tunneling Pseudo-Interface:00:00:00:00:00:00:00:e0 isatap.{7F1E7FEE-3396-49AD-B22F-9B6A81EB3729}:00:00:00:00:00:00:00:e0 Wireless Network Connection 2:82:86:f2:8e:55:a8 Local Area Connection 2:00:ad:e1:ac:1c:1a Local Area Connection:ec:f4:bb:35:28:68 isatap.{E4154231-E9E3-45E0-8275-1AF043445EC0}:00:00:00:00:00:00:00:e0 isatap.{A7C3755F-5CE1-4695-A67D-67C085D99088}:00:00:00:00:00:00:00:e0 isatap.{DD0440CD-133C-46D3-92ED-F6CE20D50AD4}:00:00:00:00:00:00:00:e0 VirtualBox Host-Only Network:08:00:27:00:10:b7 VMware Network Adapter VMnet1:00:50:56:c0:00:01 isatap.{FB7C9315-676D-4EAE-B550-CB8F59586F86}:00:00:00:00:00:00:00:e0 isatap.{9C819DC3-C04B-4D4C-904E-081E478C9765}:00:00:00:00:00:00:00:e0 isatap.{954555DC-152A-4369-8EA8-6CE0F48ACBE3}:00:00:00:00:00:00:00:e0 isatap.{6E13A897-4E51-4F7A-8809-1D5B29E0CDF6}:00:00:00:00:00:00:00:e0 isatap.{4A074996-3924-459F-BFCD-5970475AE151}:00:00:00:00:00:00:00:e0 Mobile Broadband Connection:00:a0:c6:00:00:12 VirtualBox Host-Only Network #3:08:00:27:00:fc:ba isatap.corp.unic.com:00:00:00:00:00:00:00:e0 isatap.{3160AADB-41E4-4A1A-B73F-D3FDBF455AE2}:00:00:00:00:00:00:00:e0 Wireless Network Connection:80:86:f2:8e:55:a8 VirtualBox Host-Only Network #4:08:00:27:00:8c:64 isatap.{4A17C321-4472-4A7C-A305-82158B608E7F}:00:00:00:00:00:00:00:e0]
    net_windows_test.go:515: getmac lists "VMware Network Adapter VMnet8", but it could not be found among Go interfaces map[Mobile Broadband Connection:00:a0:c6:00:00:12 VirtualBox Host-Only Network #3:08:00:27:00:fc:ba isatap.corp.unic.com:00:00:00:00:00:00:00:e0 isatap.{9C819DC3-C04B-4D4C-904E-081E478C9765}:00:00:00:00:00:00:00:e0 isatap.{954555DC-152A-4369-8EA8-6CE0F48ACBE3}:00:00:00:00:00:00:00:e0 isatap.{6E13A897-4E51-4F7A-8809-1D5B29E0CDF6}:00:00:00:00:00:00:00:e0 isatap.{4A074996-3924-459F-BFCD-5970475AE151}:00:00:00:00:00:00:00:e0 Wireless Network Connection:80:86:f2:8e:55:a8 VirtualBox Host-Only Network #4:08:00:27:00:8c:64 isatap.{4A17C321-4472-4A7C-A305-82158B608E7F}:00:00:00:00:00:00:00:e0 isatap.{3160AADB-41E4-4A1A-B73F-D3FDBF455AE2}:00:00:00:00:00:00:00:e0 isatap.{7F1E7FEE-3396-49AD-B22F-9B6A81EB3729}:00:00:00:00:00:00:00:e0 Wireless Network Connection 2:82:86:f2:8e:55:a8 Local Area Connection 2:00:ad:e1:ac:1c:1a Local Area Connection:ec:f4:bb:35:28:68 VirtualBox Host-Only Network #2:08:00:27:00:60:5e VirtualBox Host-Only Network #5:08:00:27:00:30:d5 VirtualBox Host-Only Network #6:08:00:27:00:54:f8 Teredo Tunneling Pseudo-Interface:00:00:00:00:00:00:00:e0 VirtualBox Host-Only Network:08:00:27:00:10:b7 VMware Network Adapter VMnet1:00:50:56:c0:00:01 isatap.{FB7C9315-676D-4EAE-B550-CB8F59586F86}:00:00:00:00:00:00:00:e0 isatap.{E4154231-E9E3-45E0-8275-1AF043445EC0}:00:00:00:00:00:00:00:e0 isatap.{A7C3755F-5CE1-4695-A67D-67C085D99088}:00:00:00:00:00:00:00:e0 isatap.{DD0440CD-133C-46D3-92ED-F6CE20D50AD4}:00:00:00:00:00:00:00:e0]
FAIL

Running getmac:
$ getmac /fo list /v | grep -A 3 -E "VMnet8|Blue"
Connection Name:  Bluetooth Network Connection
Network Adapter:  Bluetooth Device (Personal Area Network)
Physical Address: N/A
Transport Name:   Hardware not present

--
Connection Name:  VMware Network Adapter VMnet8
Network Adapter:  VMware Virtual Ethernet Adapter for VMnet8
Physical Address: Disabled
Transport Name:   Disconnected

If I peek at  TestInterfaceHardwareAddrWithGetmac around line 507 there is no code to test for the string "Disabled" or "N/A" as a value for "Physical Address" which explains the failed test.
A simple fix would be (I could prepare a complete CL):
diff --git a/src/net/net_windows_test.go b/src/net/net_windows_test.go
index 095a339..b9f116c 100644
--- a/src/net/net_windows_test.go
+++ b/src/net/net_windows_test.go
@@ -516,6 +516,9 @@ func TestInterfaceHardwareAddrWithGetmac(t *testing.T) {
                        if addr == "" {
                                t.Fatal("empty address on \"Physical Address\" line: %q", line)
                        }
+                       if addr == "disabled" || addr == "n/a" {
+                               continue
+                       }
                        addr = strings.Replace(addr, "-", ":", -1)
                        want[name] = addr
                        name = ""

@vdobler thank you for investigation. I agree we have to adjust these tests.

Maybe parsing the whole output of netsh interface ipv4 show address could make the test more robust.

I will try that.
netsh interface ipv4 show address

for ipv4, and
netsh interface ipv6 show address level=verbose

for ipv6.

A simple fix would be (I could prepare a complete CL):

Your proposed change looks good to me.
I will write a CL when I have some time. If you want to do it yourself (or even half of it), feel free to do it.
Thanks again.
Alex

@vdobler please check if https://go-review.googlesource.com/#/c/19441/ fixes problem on your computer. Thank you.
Alex


Feature Request:  Launch Client Side ❤ Launch Server Side

Expected Behaviour
Create a "link" between Launch client side & server side that will pass the rule id with the XDM object so that rules within Launch server side can use the rule id / name as the condition for a server side rule.

Actual Behaviour
Reproduce Scenario (including but not limited to)
Steps to Reproduce
Platform and Version
Sample Code that illustrates the problem
Logs taken while reproducing problem

@RudiShumpert Here are the JIRA tickets that are tracking this effort:
https://jira.corp.adobe.com/browse/CORE-54152
https://jira.corp.adobe.com/browse/CORE-54153
https://jira.corp.adobe.com/browse/CORE-54154


Fix the login widget layout (linux)

📒 Description
Basically all spacing policies are removed, vertical spacers have been reorganized, two horizontal spacers were added for the checkbox and gaps are now handled using stylesheets instead of spacers (that created weird overlaps).
🕶 Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

🤯 List of changes

Login widget is laid out in a bit more deterministic way

👫 Relationships
Closes #2657
🔎 Review hints
Design review necessary, the layout is not 1:1 to how it was before.

Before

After

I'm setting the Linux workspace. Will review this ticket in next hours 👍

I think we shouldn't change the height of the buttons and fields. They were bigger before the changes and should remain the same. The issue was that the margins between them were too small with small width of the window.

I didn't notice the height change at all, sorry about that.
Keeping the login widgets widths is a tad more involved though, because some of them (email, for instance) are used in both views.

Jumping has been fixed now.


Neotest diagnostics

resolves #22

Note that I use LazyVim that by default replaces newlines and tabs with spaces to make diagnostic messages from neotest more compact: https://github.com/LazyVim/LazyVim/blob/main/lua/lazyvim/plugins/extras/test/core.lua#L43

I could imagine that we may want to handle specialised cases for common assert failed messages, like for example: assert_eq could become a compact diagnostic message in vim: left: 2, right: 3, but we could add that in another PR (if wanted), thoughts?

I think handling specialized cases would be very welcome!
By the way, would you mind giving me some pointers for implementing this for other adapters? From looking at the code, the main thing seems to be indeed the parse_errors function and the adjustments in adapter.results. Am I missing something?

I could imagine that we may want to handle specialised cases for common assert failed messages, like for example: assert_eq could become a compact diagnostic message in vim: left: 2, right: 3, but we could add that in another PR (if wanted), thoughts?

I think handling specialized cases would be very welcome!
By the way, would you mind giving me some pointers for implementing this for other adapters? From looking at the code, the main thing seems to be indeed the parse_errors function and the adjustments in adapter.results. Am I missing something?

you can set the errors property of a result, how you do that is entirely up to you. For example, in neotest-python (at first glance) looks to call pytest as a library, where they have the ability to access representation of the exception directly:
https://github.com/nvim-neotest/neotest-python/blob/master/neotest_python/pytest.py#L116
In this library I created a module errors.lua that contains the required logic to parse panics from rustc output. parse_errors is not part of the interface that neotest will call into or anything like that.

This is kinda broken to me in the latest version. Is this working for any of you?

@igorlfs it looks like the output format has changed. can you open a new issue to track this? it should be a simple fix to https://github.com/rouge8/neotest-rust/blob/main/lua/neotest-rust/errors.lua and https://github.com/rouge8/neotest-rust/blob/main/tests/errors_spec.lua#L12 . I'm not writing much Rust these days so I probably won't get to it anytime soon, but PRs are welcome!

Hey @rouge8!
I opened a PR! It might need some adjustments, though


Custom elements as table rows break layout when importing resources as first business

I'm submitting a bug report

Library Version:
1.10.1 and later (have not tested before)

Please tell us about your environment:

Operating System:
Windows 10

JSPM OR Webpack AND Version
webpack-cli 3.1.2

Browser:
Tested in Chrome

Language:
all

Current behavior:
When using
 inside a table, where the custom element starts by requiring other resources, the actual rendering is broken.
Given
...app.html
<template>

</template>

...custom-row.html
<template>
  <require from="./custom-element.html></require>
  1
</template>

Gets rendered as:

1

Note how the td element is missing. When I remove the  from custom-row.html- or when I place the  inside the td element, things work as expected.
See: https://gist.run/?id=a5c449b7a1900f729cc36a97003c70bd
Expected/desired behavior:
In above example, I would have expected

1

@koenbeuk thanks for filing this issue. And sorry that somehow I missed it until now. The issue you encountered is because how Aurelia turns a template (or a html file content) into a view factory: it is first passed through native HTML5 parser via simple innerHTML. This means invalid HTML5 structure (like  as a direct child of template, but not the only child type) will be processed differently. In this case, it just gets dropped.
What can be done to avoid this is to make sure only TDs are children of <template/>:
<template>

    <require from="..."></require>

</template>

Can you try the aboe?

Here is an example of it working: https://gist.run/?id=45a7d62b74673e35ed667412085baa7d

@bigopon Thanks for the example, I already got it working that way :)

@koenbeuk nice. I guess we can close this issue?

It's not blocking me anymore, feel free to close if you deem best

It seems we could really use some doc describing this scenario to help future folks. Would be great if you could help with this @koenbeuk ❤


This is a mess - unable to uninstall AzureRM

PS C:\Users\John Blur> Uninstall-AzureRm
WARNING: Both Az and AzureRM modules were detected on this machine. Az and AzureRM modules cannot be imported in the same session or used in the same script or runbook. If you are running Pow
erShell in an environment you control you can use the 'Uninstall-AzureRm' cmdlet to remove all AzureRm modules from your machine. If you are running in Azure Automation, take care that none o
f your runbooks import both Az and AzureRM modules. More information can be found here: https://aka.ms/azps-migration-guide
WARNING: AzureRM.Profile already loaded. Az and AzureRM modules cannot be imported in the same session or used in the same script or runbook. If you are running PowerShell in an environment y
ou control you can use the 'Uninstall-AzureRm' cmdlet to remove all AzureRm modules from your machine. If you are running in Azure Automation, take care that none of your runbooks import both
Az and AzureRM modules. More information can be found here: https://aka.ms/azps-migration-guide.
WARNING: AzureRM.Profile already loaded. Az and AzureRM modules cannot be imported in the same session or used in the same script or runbook. If you are running PowerShell in an environment y
ou control you can use the 'Uninstall-AzureRm' cmdlet to remove all AzureRm modules from your machine. If you are running in Azure Automation, take care that none of your runbooks import both
Az and AzureRM modules. More information can be found here: https://aka.ms/azps-migration-guide.
Uninstall-AzureRm : The 'Uninstall-AzureRm' command was found in the module 'Az.Accounts', but the module could not be loaded. For more information, run 'Import-Module Az.Accounts'.
At line:1 char:1

Uninstall-AzureRm

  + CategoryInfo          : ObjectNotFound: (Uninstall-AzureRm:String) [], CommandNotFoundException
  + FullyQualifiedErrorId : CouldNotAutoloadMatchingModule

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c7f3dff7-65ab-09f2-713e-4e7f11544c9a
Version Independent ID: 524598ca-76aa-c8f5-cde1-d6bd626b757b
Content: Introducing the Azure PowerShell Az module
Content Source: docs-conceptual/azps-2.8.0/new-azureps-module-az.md
GitHub Login: @sptramer
Microsoft Alias: sttramer

@John-Blair Thank you for your feedback, we will look into this and get back to you at the earliest.

@John-Blair Apologies for delayed response on this, can you please help confirm if you are not able to consume Unistall-AzureRm command , however navigate through the next steps listed in the doc to unistall the AzureRM modules.
If you can't successfully run the Uninstall-AzureRM command, use the Uninstall-AllModules script provided in this article with the following invocation:
$versions = (Get-InstalledModule AzureRM -AllVersions | Select-Object Version) $versions | foreach { Uninstall-AllModules -TargetModule AzureRM -Version ($_.Version) -Force }
Please revert back if you have any further queries. Thanks

@John-Blair Thanks again for reaching out to us. Hope the above information on this thread helps you to uninstall AzureRM. We will go ahead and close this issue for now, however if you have any further queries please feel free to tag us in your reply and will be happy to continue the conversation forward.  Thank you.

I was only able to Uninstall AzureRM by using what i found here here
specifically, I ran this:
workflow Uninstall-AzureModules {     $Modules = (Get-Module -ListAvailable AzureR*).Name |Get-Unique     Foreach -parallel ($Module in $Modules)     {          Write-Output ("Uninstalling: $Module")         Uninstall-Module $Module -Force     } } Uninstall-AzureModules Uninstall-AzureModules   #second invocation to truly remove everything
There was no other way I could find to do this.
Uninstall-AzureRm just didn't work at all even after installing a newer version of AzureRM

@Mexicoder You're a gift sent from heaven with this bit of info


embark won't connect to simulator in another process

Bug Report
Summary

Starting embark simulator, then starting embark console will attempt to start geth as it doesn't recognize that a blockchain is already running.
If I do embark blockchain, then embark console, everything works as expected.
Expected behavior

I would expect to be able to connect to the simulator.
If you encounter an error, please create a logfile using the following command and post the output here
$ embark run --nodashboard --logfile log.txt --loglevel trace

Please provide additional information about your system
OS:
Embark Version: commit e5549f3
Node Version:
NPM Version:
Sometimes issues are related to Embark's installation. Can you provide information on how Embark was installed?

@emizzle can you link the commit/pr that fixes this issue and close this one? Can't seem to find a commit that does it.

I got this below config...
{
  "contracts": ["contracts/**"],
  "app": {
    "css/app.css": ["app/css/**"],
    "js/app.js": ["app/js/index.js"],
    "images/": ["app/images/**"],
    "index.html": "app/index.html"
  },
  "buildDir": "dist/",
  "config": {
    "contracts": "config/contracts.js",
    "blockchain": "config/blockchain.js",
    "storage": false,
    "communication": false,
    "webserver": false
  },
  "versions": {
    "web3": "1.0.0-beta",
    "solc": "0.5.0",
    "ipfs-api": "17.2.4"
  },
  "plugins": {
    "embarkjs-connector-web3": {}
  },
  "options": {
    "solc": {
      "optimize": true,
      "optimize-runs": 200
    }
  },
  "generationDir": "embarkArtifacts"
}

Running embark run dev, I found that embark cannot start the blockchain. It just hang in there waiting for the Avengers to come and rescue.

@vutran1710 Do you have an environment in your blockchain config called dev?
The default name created by Embark is called development so the issue is probably that it's trying to start an environment that doesn't exist, hence missing some configs.
Also, FYI, just doing embark run or embark blockchain defaults to development.
Here is our guide on environments if it's still unclear: https://embark.status.im/docs/environments.html


[Inject] methods called after Awake() for dynamically created MonoBehaviours

I found that [Inject] methods are called after Awake() for dynamically created objects (Case 1), whereas [Inject] occurs before Awake() for the ones that are defined in the scene hierarchy before the game starts (Case 2). In case 2, it is a simple scene with a GameObject to which NewBehaviourScript is attached.
Case 1: Execution Order of Dynamic MonoBehaviours created by MonoInstaller attached to SceneContext (Runtime) & DiContainer (in ZenjectUnitTestFixture):
InstallBindings() - Awake() - OnEnable() - [Inject] Construct() - Start()
public override void InstallBindings()
{
    Debug.Log("Install");
    Container.Bind<NewBehaviourScript>().FromNewComponentOnNewGameObject().AsSingle().NonLazy();
}

In this scene, there is a SceneContext and the above MonoInstaller. NewBehaviourScript is then instantiated during runtime via InstallBindings().
Case 2: Execution Order of predefined MonoBehaviours:
InstallBindings() - [Inject] Construct() - Awake() - OnEnable() - Start()
In this scene, there is a SceneContext, an empty MonoInstaller, and a GameObject to which NewBehaviourScript. Everything is defined before game starts and nothing is instantiated runtime.
The Case 1 appears contrary to the documentation written on Facotry.md

Also note that you for dynamically instantiated MonoBehaviours (for example when using FromComponentInNewPrefab with BindFactory) injection should always occur before Awake and Start, so you can use Awake and Start for initialization logic and use the inject method strictly for saving dependencies (ie. similar to constructors for non-monobehaviours)

Why issue?
FIrstly it seems to me that this behaviour is contrary to the documentation linked above.
Also the inconsistancy could cause a problem. For my case, I was writing Unit Tests where I intantiated MonoBehaviour that needed a Signal instance. It failed in my Test because the Signal was not yet resolved in Awake(), but it worked in a scene where it was instantiated prior to the start of the game.
Code
Simply logged in each step.
public class NewBehaviourScript : MonoBehaviour
{
	[Inject] void Construct() { Debug.Log("Construct"); }
	void Awake() { Debug.Log("Awake"); }
	void OnEnable() { Debug.Log("OnEnable"); }
	void Start () { Debug.Log("Start"); }
}

I used [Inject] method over [Inject] fields / properties, because (from README.md/Injection)

Using [Inject] methods to inject dependencies is the recommended approach for MonoBehaviours, since MonoBehaviours cannot have constructors.

Script Execution Order
From General Guidelines / Recommendations / Gotchas / Tips and Tricks

The order that things occur in is wrong, like injection is occurring too late, or Initialize() event is not called at the right time, etc.

It may be because the 'script execution order' of the Zenject classes 'ProjectContext' or 'SceneContext' is incorrect. These classes should always have the earliest or near earliest execution order. This should already be set by default (since this setting is included in the cs.meta files for these classes). However if you are compiling Zenject yourself or have a unique configuration, you may want to make sure, which you can do by going to "Edit -> Project Settings -> Script Execution Order" and confirming that these classes are at the top, before the default time.

This was the script execution order defined in my project (I did not change any).

Possible Refs

https://github.com/modesttree/Zenject#zenject-order-of-operations
https://github.com/modesttree/Zenject#dicontainerinject

Am I missing something here? Or is this inconsistant order of executions (as in Case 1 vs Case 2) expected?

Thanks for the detailed bug report.  You are not missing anything - it should work exactly like the documentation says.
I was able to reproduce the issue and am looking into it.  It looks like there is a bug with FromNewComponentOnNewGameObject.   FromComponentInNewPrefab does not have this problem, and neither does the initial monobehaviours in the scene, like you say.

Should be fixed now, if not let me know

Going to assume this is fixed since it seems fixed to me in my tests


Map editor · Beta

[x] Metadata, permissions and other ops. (Layout, Geocode, Duplicate, delete...).

[x] License
[x] Source (@piensaenpixel will send designs)

[x] CartoCSS editor.
[x] Data panel.

[x] SQL editor.
[x] How to view data below widget (scrolled version)
[x] Filters interaction.
[x] New submenu design for SQL / Filters
[x] Feedback messages
[ ] Design for different filters

[x] Infowindows panel.

[x] New infowindow templates.
[x] Make it dragable.

[x] Legends panel.
[x] Share modal.

[x] Basemap selector.
[x] Map options.
[x] Configure canvas (mobile, desktop or custom resolution)
[x] Confirm map deletion modal.
[x] Drag & drop indicator in layers and interaction.
[x] Use actual privacy modal (dashboard)
[x] Add feature (polygon, point, line).
[x] Color picker or select image new design (color also for svg images)

[x] Unify map options and metadata under the cog icon.
[x] Change margins between basemap options.
[x] Revisit style of the switcher menus
[x] Submenu colors
[x] Configure canvas, set resolution inside desktop and mobile
[x] Input to the left side on the legend editor.
[x] Indicate that a layer has a query applied on the layers list.
[x] Indicate that a layer has an error on the applied query.
[x] Change buttons for adding rows and columns to the blue area on the data view.
[x] Reorder colorpicker elements to allow numeric input on opacity.
[x] Loading indicator to the layer itself.
[x] 2nd level menu for infowindow on hover / click.
[x] Try share as a modal.

[ ] Odyssey.
[x] Add overlay.

Thanks for the feedback @saleiva. Take a look to the changes you propose. Makes sense to me:

Import your data -> Connect your datasets
Since there are thousands of posibilities for the background color when doing a map, what about doing the odyssey bar bkg dark?
"I’d not add the small spike to the overlays icons since they don't have it in reality. Ok " :trollface: ??

Import your data -> Connect your datasets
done

Since there are thousands of posibilities for the background color when doing a map, what about doing the odyssey bar bkg dark?
let’s try
“I’d not add the small spike to the overlays icons since they don't have it in reality. Ok "  ??
Ups, fixed

Cool! Close and spread! :)

:+1:


Any schedule adapt okhttp for flutter

Any schedule adapt okhttp for flutter
Thanks.

No plans. It's a separate project for someone else to start.


Perf: remove some clones

Description
Two clones were removed in favor of std::mem::take on the reconstruction of the clusters in the hierarchical pass.
Changes
No performance change (in CPU nor time) but better memory profile. The reconstruction of clusters is by no means a bottleneck (for now) but it may be problematic with very big files in terms of memory.

Codecov Report

Merging #2 (7f880b2) into trunk (f1a8309) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##            trunk       #2   +/-   ##
=======================================
  Coverage   95.23%   95.23%
=======================================
  Files           3        3
  Lines          84       84
=======================================
  Hits           80       80
  Misses          4        4

Impacted Files
Coverage Δ

src/hierarchical.rs
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1a8309...7f880b2. Read the comment docs.


BIKE support for aarch64 platforms

Issue # (if available):
https://github.com/awslabs/s2n/issues/1073
Description of changes:

BIKE support for aarch64 platforms
Updating to the latest BIKE's code

This change was tested on an EC2 a1.medium instance.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

:exclamation: No coverage uploaded for pull request head (bike_aarch64@06eec19). Click here to learn what that means.
The diff coverage is n/a.


Content - Income declaration tax year dynamic year numbers

Display dynamic year numbers for the application for income years.
Acceptance Criteria
Student portal / Application
Financial section

[ ] Replace the tax year 2020 for all program year options. Change it to dynamic value. Shown value = first year of the program year - 1 (example 2024-2025 program year would be  2023 (2024-1 = 2023) (see 4 spots where the updates are needed for this question shown in context image 1))

[ ] Resolve Bug in current state that does not show the expected value. Attempted dynamic value has the wrong year but is also showing incorrect value. If the bug still exists.

Student Portal
Family section :
Dependants with disability question

[ ] Replace 20XX Tax Year with new dynamic value for all program years.  Shown value = first year of the program year - 1 (example 2024-2025 program year would be  2023 (2024-1 = 2023) (see 2nd image content image for locations in question)
[ ] Complete the same change for the change request version of this questions document uploader using the same details as the change to the application. (Change request is under the Add/Remove dependant change request)

Student declares Partner income

[ ] Update the content for the authorization line of supplying partner income in the application and the Partner information and income change request to the following:

I have been authorized by my spouse/common-law partner to submit their financial information, including their total reported income from their insert year tax return.

[ ] Update the content above partner income self declare field (see image below location bullet #1) question to show the following for both the application question and Partner information and income change request

Enter your partners reported total income from line 15000 of their "insert year" income tax return. If they did not file a "insert year" income tax return, enter their total income from all sources both inside and outside of Canada.

[ ]  Replace "insert year" (3 numbered locations in image below) in the content with dynamic year information for all program years. Shown value = first year of the program year - 1 (example 2024-2025 program year would be  2023 (2024-1 = 2023)
[ ]  Complete this dynamic update for the change request as well. Change request is the Partner information and income change request

Additional Context
Currently the application says 2020 tax year for all applications

Please note. Had to update ticket to include updates to the change request version as well. I was under the impression that this was being handled in separate tickets that were already moving forward and ahead of this one but i was incorrect. The needed changes mirror the application changes and have added additional AC's to reflect this.


Extra ' breaks formatting

see: https://www.npmjs.com/package/event-loop-lag where the text at the bottom is code formatted

Coverage remained the same at 100.0% when pulling 80a9071e69b214f9e0c7d389eeb94d7d4dc91639 on kennethlimcp:patch-1 into c596e36268c8edcbbd1d8ca3bb1efbe543c84783 on pebble:master.

Thank you!


Uncaught Exception: Attempting to call a function in a renderer window that has been closed or released. Function provid

An uncaught exception was reported.
Info:
OS: win32
Arch: ia32
GPMDP Version: 3.2.4
Time: Sun Jun 05 2016 23:33:10 GMT 0100 (GMT Daylight Time)
Error:
Attempting to call a function in a renderer window that has been closed or released. Function provid
Error: Attempting to call a function in a renderer window that has been closed or released. Function provided here: Object.<anonymous> (C:\Users\paul\AppData\Local\GPMDP_3\app-3.2.4\resources\app\build\inject\GPMWebView\interface\customNavigation\mouseButtonNavigation.js:27:9.
    at BrowserWindow.callIntoRenderer (C:\Users\paul\AppData\Local\GPMDP_3\app-3.2.4\resources\electron.asar\browser\rpc-server.js:193:19)
    at emitTwo (events.js:105:20)
    at BrowserWindow.emit (events.js:185:7)

This issue was created automatically inside the uncaughtException handler

Closing this automatically reported issue as a duplicate of #1045


fix eslint errors

noticed the build was failing - this seems to sort it, though I can't say I'm certain it is to my taste.

Linked to https://github.com/yannickcr/eslint-plugin-react/releases/tag/v3.3.2

I would rather keep {true} with the always option

I feel we should just drop the specification of this rule from the .eslintrc file.

Hey guys - I'm with @shaurya947 . I think we should just drop this rule because
<input type="text" disabled /> is valid HTML5 syntax.

So let's just set 0 here https://github.com/callemall/material-ui/blob/master/.eslintrc#L33

fine by me :)


analogWrite(1, 0.5) is not work on Pin 1. (Pin1 only and other PWM pins works properly)

analowWrite(1, 0.5)

490khz 50% duty

Signal with latest code.


Add a linux arm64 build

I'm targeting an embedded Linux installation on an ARM device

PR?

I did take a brief look before filing the issue to see if I could, but the intricacies of the bespoke python, cmake, and of skia itself are beyond my capabilities. After all, it's why I need the wrapper in the first place!

I will try to complete it in the next few months - but I can't guarantee it.

One good news: It's easy to make it work. You just need to compile Skia and Skija yourself.

But there are still some things stopping us.
First of all, some examples will cause crashes, and the reasons need to be investigated. I have no experience in debugging JNI, so it is difficult for me to find the real reason.
Secondly, there is a more important problem, that is GitHub Action does not currently provide CI servers on Linux ARM64 platform (https://github.com/actions/runner-images/issues/5631).
Maybe we can wait for GitHub to provide it, but it will take us several months or even years.
Another solution is cross-compilation, but it takes me more time to solve various problems, and it is more difficult. I will try to do it, but I can't provide any guarantee.

This is the platform jar and jmod file I built: https://drive.google.com/drive/folders/1YCNYIokoQx3W3b_Gk4hDs-lcAm9pIG7T?usp=sharing

@JakeWharton
I have completed cross-compilation adaptation. I think you can get Linux ARM64 build in the next version.
But there are still some bugs that need to be solved. I don't necessarily have time to do it. Maybe it needs the help of others.


VSTS REST API List Iterations does not accept 'past' or 'current' values for $timeframe

Using the VSTS REST api version 4.1 AND 5.0 preview 1, making a GET request to list iterations using the $timeframe query parameter works when supplying 'current' as a timeframe value, but does not work when using 'past' or 'future' as per the documentation.
To Reproduce
Make a get request using the following URL (fill in appropriate values):
https://{CompanyName}.visualstudio.com/{ProjectName}/_apis/work/teamsettings/iterations?$timeframe=past&api-version=4.1
This returns:
{
    "$id": "1",
    "innerException": null,
    "message": "Specified argument was out of the range of valid values.\r\nParameter name: timeframe",
    "typeName": "System.ArgumentOutOfRangeException, mscorlib",
    "typeKey": "ArgumentOutOfRangeException",
    "errorCode": 0,
    "eventId": 0
}

Using either $timeframe=past or $timeframe=future reproduces the fault.
Using $timeframe=current works fine.
Expected behaviour
Using 'past' and 'future' as defined in the documentation here https://docs.microsoft.com/en-us/rest/api/vsts/work/iterations/list?view=vsts-rest-4.1 and https://docs.microsoft.com/en-us/rest/api/vsts/work/iterations/list?view=vsts-rest-5.0 should return a list of past and future iterations.
Desktop (please complete the following information):
n/a.
Smartphone (please complete the following information):
n/a
Additional context
Reproduced in Postman and C#, .Net framework 4.7.2 console application using NuGet package RestSharp v106.2.2.

@tedchamb could you please help to take a look?

Transfer to an issue of https://github.com/MicrosoftDocs/vsts-rest-api-specs/issues/52, so that @wnjenkin can triage.

@hellosnow Is MicrosoftDocs/vsts-rest-api-specs public? So user can be informed when the issue is resolved? If not, I prefer @wnjenkin assign the issue here.

@Powerhelmsman yes it is public

@stuntbeaver Your issue is transferred to MicrosoftDocs/vsts-rest-api-specs#52. @wnjenkin will help you there. I will close this issue in this repo now. Let me know if have other question so we can reopen it and continue the discussion.

@stuntbeaver refer to https://github.com/MicrosoftDocs/vsts-rest-api-specs/issues/52, this issue has been resolved. The descriptions has been updated to show only current is supported. Hope it works for you.


Low resolution texture background

I'm loading an image for a pano background with this code:
Texture
                    .builderWithImage(bitMap)
                    .stereoMode(Texture.StereoMode.TOP_BOTTOM)
                    .sRGB(true)
                    .storageFormat(Texture.Format.RGBA8)
                    .build();

(Link to image)

The pano shows ok but in a mucho lower resolution than any other image viewer I tested the image on
When  I enable mipmapping the entire thing becomes pixelated and aliased everywhere, more visible in the poles
It doesn't seem to be the texture memory, RAM , or device screen resolution since the very same file looks completely fine in other viewers

Device: Samsung Galaxy S7 Edge (1440p screen, net.arcons.onboarding.vr I/Viro: GPU vendor [Qualcomm], renderer [Adreno (TM) 530] )

Thanks @SebaSOFT, could you share the other image viewers you've used to perform the resolution comparison on your end, so that we can also use it on our end to test and identify the bug?

Samsung VR
SKYBOX

Note: May also be related: https://github.com/viromedia/virocore/issues/95

I can capture some video, where is a lot more evident
looks like its the environment resolution, or the texture resolution/filtering of the cubemap, the difference is quite noticeable

Any news on this?

Hi @SebaSOFT, I haven't reproduced this yet, but will try it again tomorrow. Out of curiosity, I know we had an issue with the Texture builder earlier, did you try constructing the Texture without the builders?

I will try and let ou know
El jue., 17 de may. de 2018 a la(s) 22:46, Raj Advani (
<EMAIL_ADDRESS>escribió:

Hi @SebaSOFT https://github.com/SebaSOFT, I haven't reproduced this
yet, but will try it again tomorrow. Out of curiosity, I know we had an
issue with the Texture builder earlier, did you try constructing the
Texture without the builders?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/viromedia/virocore/issues/111#issuecomment-390069285,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACa49Le4-z2SO-ZE80kTL-yDD-ds6kmjks5tzifkgaJpZM4T0RS4
.

--
[image: --]
Sebastián Diéguez
[image: http://]about.me/sebasoft

Builders dont have an influence, in this particular case...

Hi @SebaSOFT, still looking into this. I believe I've reproduced it but haven't root-caused the resolution drop as of yet.

One quick question: were you using the ViroViewScene or ViroViewOVR?

ViroViewOVR, looks like the resolution of panos and text surfaces are low compared with Oculus Home (for example) this is clearly artificial, as the device is already capable of handling much bigger textures. Aliasing artifacts and low resolution are my biggest concerns as it doesn't look professional.

Tested on ViroCore 1.7.1 and it's the same (or a litle worst) no antialias at all, the pano resolution is not power of two, but is square and pretty big to fit in a 2048x2048 and with a little upscaling to a 4096x4096 texture map

Hi @SebaSOFT, we've made some improvements to text rendering for our next release, making better use of trilinear filtering of fonts. And for the background image you provided, we've made some improvements to anti-aliasing as well that should mitigate the problem. However, it's not yet at the same fidelity as the image you posted above (in your second post on this thread). What application did you use to generate that image? SamsungVR? Do they have an app where you can load an arbitrary skybox that you used for comparison?

YES I used SamsungVR to take the picture, but in any case, this is a PNG 3840x3840 equirectangular stereo top-bottom pano. Please try it yourself, this is the link...
https://we.tl/b54KlAxg4E
The difference is quite noticeable. I've tried to reduce it to 2048x2048 to avoid the "power of two" problem, still the same results.

I have the picture, and have replicated your results, but was wondering if you tried this pano on other Android software and gotten different/better results?
This just helps me in root-causing the problem. Interestingly, the same pano does look significantly better on Viro on iOS, so it has to do less with the Viro renderer and more to do with the Android integration, or something specific related to the Adreno GPU.

Closing this issue due to inactivity. If you are still having issues, please re-open with the additional info requested. Thanks


Hotfix/add disposition params for s3 presign url api

Fix:

add content_disposition param in the libumccr.aws.libs3.presign_s3_file function.
Set default value inline will not change the default behaviour as before.

Refer: about ResponseContentDisposition Params in the boto3 s3 client, https://github.com/boto/boto3/issues/356#issuecomment-155919331
https://github.com/boto/boto3/issues/610#issuecomment-443878760
Link:
apis of PR, https://github.com/umccr/data-portal-apis/pull/705
ui issues, https://github.com/umccr/data-portal-client/issues/342

Reviewing...

Merge when you ready, Ray.

merged, think of publishing.....

I will publish it to PyPI.

I will update the portal-apis PR deps when it is ready

0.4.0rc4 is in:
https://pypi.org/project/libumccr/0.4.0rc4/


ci: publish npm workflow

A workflow to publish IDL files on npm. Published when a GitHub release is made.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 9.17%. Comparing base (3bc8dad) to head (1b6d1f3).

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #21   +/-   ##
=====================================
  Coverage   9.17%   9.17%
=====================================
  Files          1       1
  Lines        218     218
=====================================
  Hits          20      20
  Misses       198     198

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@zeta-chain/devops can someone, please, create a new npm package:
https://www.npmjs.com/package/@zetachain/protocol-contracts-solana
And add an npm token to this repo. Thanks!

Whats the versioning of the published package?

Whats the versioning of the published package?

To publish an npm package we'll be creating a GH release. Version specified in the release will be set as the version of the npm package.


Clock question

Is there a way to set the clock on here? When I tried, it set it about 12 hours off

Well that fixed it, thanks!


ARXIVNG-1127 ARXIVNG-1101 Alerting

ARXIVNG-1101 Renames arxiv.base.messages to arxiv.base.alerts
ARXIVNG-1127 Introduces arxiv.base.alerts.flash_hidden, which can be used to send small amounts of structured data across requests (e.g. on redirect).

Whoops, nope, missed a spot. Try again?


Unable to connect to an Azure Synapse Instance from Azure Data Studio

Open Azure Data Studio, enter the connection string, provide the connection type (MFA 2FA). When clicking on Connect, it simply rotates forever and never connects.
This issue is applicable only when I try to connect from a specific machine. Please help resolve the same.

@aaomidi any thoughts on how to troubleshoot this one?

We definitely need more logs on this. @basilcherian can you click Help -> About on the machine you're having issues from and send us the information? Also, the same process on the machines you're not having a problem on.
Would be good to see what the differences between these two machines are.


Add Ed25519 Support

Changes

Added FFI bindings to libsodium's Ed25519 functions (ed25519-ffi.ss)
Created high-level Ed25519 interface with type safety (ed25519.ss)
Added comprehensive test suite with RFC 8032 test vectors (t/ed25519-test.ss)
Updated build configuration to include libsodium dependency

Key Features

Secure key generation and management
Message signing and signature verification
Key conversion between Ed25519 and Curve25519 formats
Type-safe interfaces with proper error handling
Comprehensive test coverage using standard test vectors

Excellent work, merging with a minor cleanup.


Problem working with gulp-less

I am getting an error out of gulp-less, but as you can see I am not receiving any details from it, making it difficult for me to pinpoint what the issue is..
When I remove sourcemaps from the equation the error goes away. I am not certain if it is being generated by gulp-less or gulp-sourcemaps, but something in the interaction of the two is causing an odd error. I will cross post this on gulp-sourcemaps as well.
[11:57:04] Starting 'styles'...
[11:57:06] Plumber found unhandled error:
 Error in plugin 'gulp-less'
Message:
    First argument needs to be a number, array or string. in file undefined line no. undefined
Details:
    lineNumber: undefined
    fileName: undefined
[11:57:07] Finished 'styles' after 3.02 s
[11:57:07] Starting 'watch'...
[11:57:07] Finished 'watch' after 155 ms
[11:57:07] Starting 'clientBuild'...
[11:57:07] Finished 'clientBuild' after 5.1 μs

Here is the styles task that runs gul less, it is coffeescript, but should be legible.
gulp = require 'gulp'
{less, sourcemaps, plumber} = require('gulp-load-plugins')()

gulp.task 'styles', ->
	gulp.src(['./public/include/less/**/*.less', '!./**/_*.less'])
	.pipe plumber()
	.pipe sourcemaps.init()
	.pipe less({verbose: true})
	.pipe sourcemaps.write()
	.pipe gulp.dest('./public/include/css')

reference plus3network/gulp-less#121

@mudetroit Can you confirm this works & close the issue?

@mudetroit Can I close this?

I was able to get it to work... I was never able to get the error to output properly. I had to slowly include files to track it down


Fix rates for Octopus integration v8.0.0

With the release of v8.0.0 of the Octopus integration a breaking change was made to the rates. We now need to read the all_rates attribute, use the valid_from attribute on each rate instead of from, and the value_inc_vat attribute instead of rate.

oh wow - thanks for grabbing this, I hadn't even seen there was an update let alone install it.
Annoying because we now have to hope people will update both halves at the same time or it will break.

Yeah, I was wondering if I should try and handle both, but it's slightly tricky. If you like I can give that a go. It might just be a case of checking for both top-level keys and storing that as a comparison later.
I'm sort of assuming if people are updating things via HACS they're doing everything, but I don't know how true that is.

Yeah it's fine, we'll just roll forward. Thanks again

Thanks for all your work. A very quick fix.


[WIP] Add extra propagation steps and other changes to boost move acceptance

In this PR, I'll be incorporating some changes that appear to boost move acceptance.
Particularly:

Adding extra propagation steps between lambda 0.2 -> 0.8
Zeroing particle masses outside 5.0A

@nathanmlim - outside 5 angstroms?

Outside 5 angstroms of what? (Did you check that this is relative to the outer extent of the specified object, or the center of mass?)
Can it be outside N angstroms, where N is user specified?

@davidlmobley Right now, I'm just putting up all my changes, so that when @sgill2 gets back we can talk about what options we want to properly expose to the end user but also leave options for debugging. For now, I'll leave the new options set to what's been working in my tests.

This is ready for review.

Will have to get back to finishing cleaning up this PR after miniCUP.

Ready for review again.

By moving the nprop loop out of simulateNCMC() and into the custom integrator from @sgill2 changes, I did see a 2x speed up with a slight decrease (~3%) in acceptance, down from ~10%.
Overall, features in this PR like freezing atoms and adding extra propagation steps brings the overall acceptance up from 1% to 7%-10% for my test cases with sEH. Perhaps, it's worth revisiting with additional trials but the speed enhancement is rather dramatic, that I think this should get merged immediately.


Remove beta phase banner from service manual

Remove it from:

NHS service standard - this has now been well tested
skin symptoms guidance - once we've iterated it (see UR findings)

Do this as part of work to iterate skin symptoms guidance: https://github.com/nhsuk/nhsuk-service-manual/issues/673

Done. Close.


issues while running the tabular data section

I got some issues while opening the tabular data section. Everything else is working fine. I was running the app.py file locally.

Thanks @Flugbanane97! I redeployed it. Let me know if there are more issues.

There was an issue in the package dependencies with streamlit cloud, fixed it by adding a line in requirements for protobuf
https://discuss.streamlit.io/t/typeerror-descriptors-cannot-not-be-created-directly/25639/5


NamedIdea of' pluralizes second term, no alternative of available

of' pluralizes second term:
Purpose of Document -> Purpose of Documents
this does not match the stable example.
of_ does not use Nounphrase does not match type signature of of'.
when changed will affect:
orgOfDoc
prpsOfDoc
in Documentation.hs

Should be fixed as of b4ea5efae0a5e7791e11deefce36ad4f37ff2680


Health not good

... and it hasn't been updated in a while.

We are n a progress to have a digital solution for tracking of such features.

I think tracking is less of a problem than event generation.


WIP CMD for SG 2.0 + routes + fixes

Created CMD for supergiant 2.0.
Added API router.
Added missing API register funcs
Added missing constructor funcs for handlers and services
Small Fixes

Coverage decreased (-0.9%) to 41.832% when pulling c1d6fd446bb867a63dc5c36e8d2964fb35ae996d on egopher:master into faea3678d049585197ec4e0e95d2012d96630fc3 on supergiant:master.


build: speedup debug build

When setting codegen-units, rustc will split the crate into several module and passing it to llvm in parallel. Debug build time is decreased about 15% on my machine, 18% on travis ci.
@siddontang @disksing @iamxy PTAL

Cool, LGTM

LGTM


[json rpc] spec: update currency reference

@bors-libra: r=thefallentree

:pushpin: Commit 4ac9846 has been approved by thefallentree

:hourglass: Testing commit 4ac9846907f6fadb344026708ea02000f64d22a6 with merge 4ab13d44f35b51060b0dc01993bff3658e5be167...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: thefallentree
Pushing 4ab13d44f35b51060b0dc01993bff3658e5be167 to master...


Add Nest 10 and Pact 11 support

Add Nest 10 and Pact 11 support
Description
As there is no impacting changes with the Nest 10 and Pact 11 releases for this package change the peerDependencies, to allow nest 10 to be used as a peer dependancy.
Also changed the fixed v10 pact version to any v10 and v11 (ok for v11 as I said before)
Motivation and Context
Make the package work for NestJS recent release 10 on npm install without error Conflicting peer dependency.
How Has This Been Tested?
In my fork branch of the nestjs-pact project:
npm run build
npm pack --pack-destination ~

Then in the "final project" I try npm install after replacing in the package.json:
"nestjs-pact": "^2.3.0",

With
"nestjs-pact": "file:~/nestjs-pact-2.3.1.tgz",

Check if installation pass, looks good, good to go.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Thanks for the PR, it is very odd that it triggered the workflows automatically however, as our settings as meant to prevent that

Oh I can see Matt triggered it :) Will take a look at the errors today

Hey, if you could update the commit messages, to follow the commit convention as suggested by the latest error message. we will get a green build 👍🏾
fix: add peer dep pact-js v11 and nest-js v10

I'll leave this with you so you can get attribution rather than merging the draft PR I created for testing. Cheers buddy

I changed but only for the latest message show i change for all the messages ?


Add JPQD examples of audio classification and image classification

This PR adds examples of OpenVINO OVTrainer:
(1) QAT and JPQD examples in audio-classification.
(2) JPQD example in image-classification.
(3) renames "teacher_model_or_path" to "teacher_model_name_or_path" in the example scripts. Should be more appropriate

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@AlexKoff88  Hi Alexander, this PR about overflow fix on no-vnni-support machines, is ready for review. @vuiseng9

@helena-intel Hi, Helena, this is the PR of another two examples for JPQD. Could you help to have a look at it?

@helena-intel Hi, Helena, this is the PR of another two examples for JPQD. Could you help to have a look at it?

Thank you! I will try the examples today.

My answer is yes. AutoModelForAudioClassification API is from transformers repo, and always yields a normal PyTorch model. When it is fed into OVTrainer, it will be wrapped by NNCF to do quantization and finetuning. We follow the statement from existing openvino examples, e.g., in text-classification.

That's awesome. The configs we provide are wav2vec2 specific though. Do you know if it would be easy to make them more generic, or to provide configs for other audio classification models?

That's awesome. The configs we provide are wav2vec2 specific though. Do you know if it would be easy to make them more generic, or to provide configs for other audio classification models?

@helena-intel, the current design requires strategy registration in NNCF. Are there any other transformer architecture for audio? could you pls point us? we are in the midst of adding more architecture to NNCF. Thanks!

@helena-intel, the current design requires strategy registration in NNCF. Are there any other transformer architecture for audio? could you pls point us? we are in the midst of adding more architecture to NNCF. Thanks!

For example AST (https://huggingface.co/MIT/ast-finetuned-audioset-10-10-0.4593) and HuBERT (https://huggingface.co/superb/hubert-base-superb-ks).

@vuiseng9 @yujiepan-work I got a dynamic shapes error when loading the JPQD swin model with the OpenVINO 2023.0 prerelease. It would be good to mention in the README that this model requires static shapes, and give an example of how to load the model (and then might as well add inference too):
from transformers import pipeline, AutoFeatureExtractor
from optimum.intel.openvino import OVModelForImageClassification

feature_extractor = AutoFeatureExtractor.from_pretrained(save_dir)

ov_model = OVModelForImageClassification.from_pretrained(save_dir, compile=False)
ov_model.reshape(1,3,224,224)
ov_model.compile()

ov_pipe = pipeline("image-classification", model=ov_model, feature_extractor=feature_extractor)

outputs = ov_pipe("https://datasets-server.huggingface.co/assets/food101/--/default/validation/98/image/image.jpg")
print(outputs)

@vuiseng9 @yujiepan-work I got a dynamic shapes error when loading the JPQD swin model with the OpenVINO 2023.0 prerelease. It would be good to mention in the README that this model requires static shapes, and give an example of how to load the model (and then might as well add inference too):

Thanks very much for pointing out this error! We are trying to find out the reason and will share more information with you later

@helena-intel, thanks for reporting the issue. I think we have two issues right now.

The Swin IR is not pruned. can you check if your openvino_model.bin is about 300mb? if yes, we are seeing the same.
dynamic shaped IR cannot be compiled.
We suspect that Swin Pytorch definition has hardcoded dimension and caused this issue. We're troubleshooting now,

The Swin IR is not pruned. can you check if your openvino_model.bin is about 300mb? if yes, we are seeing the same.

Yes, my model is 352 MB.

We suspect that Swin Pytorch definition has hardcoded dimension and caused this issue. We're troubleshooting now,

That seems likely. IMO for this kind of model, it's not a critical issue if it doesn't work with dynamic shapes. If you do inference with pipeline the images are resized to a specific shape too, so then you might as well reshape your model to that static shape to not have dynamic shapes overhead.
@echarlaix if these models have hardcoded dimensions in PyTorch, would it be possible to make OVModelForImageClassification so that on loading the model, we reshape it to the size defined in the feature extractor? It could be an option, defaulting to True.

Also the doc build was fixed in https://github.com/huggingface/optimum-intel/pull/228 !

@echarlaix, @helena-intel, what are the substantial comments, in your opinion, that prevent us from merging this?

Shall we merge? 🎉

Just waiting for @helena-intel's approval


voxblox_rrt_planner

Thank u for the wonderful repo, I tried out the package and got stuck in this part
Errors     << voxblox_rrt_planner:make /home/naveen/ethz_ws/logs/voxblox_rrt_planner/build.make.001.log
/home/naveen/ethz_ws/devel/.private/voxblox_rrt_planner/lib/libvoxblox_rrt_planner.so: undefined reference to `ompl::geometric::BITstar::BITstar(std::shared_ptr<ompl::base::SpaceInformation> const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
/home/naveen/ethz_ws/devel/.private/voxblox_rrt_planner/lib/libvoxblox_rrt_planner.so: undefined reference to `ompl::geometric::RRTConnect::RRTConnect(std::shared_ptr<ompl::base::SpaceInformation> const&)'
/home/naveen/ethz_ws/devel/.private/voxblox_rrt_planner/lib/libvoxblox_rrt_planner.so: undefined reference to `ompl::geometric::InformedRRTstar::InformedRRTstar(std::shared_ptr<ompl::base::SpaceInformation> const&)'
/home/naveen/ethz_ws/devel/.private/voxblox_rrt_planner/lib/libvoxblox_rrt_planner.so: undefined reference to `ompl::base::PlannerData::PlannerData(std::shared_ptr<ompl::base::SpaceInformation> const&)'
/home/naveen/ethz_ws/devel/.private/voxblox_rrt_planner/lib/libvoxblox_rrt_planner.so: undefined reference to `ompl::geometric::SimpleSetup::SimpleSetup(std::shared_ptr<ompl::base::StateSpace> const&)'
/home/naveen/ethz_ws/devel/.private/voxblox_rrt_planner/lib/libvoxblox_rrt_planner.so: undefined reference to `ompl::geometric::PRM::PRM(std::shared_ptr<ompl::base::SpaceInformation> const&, bool)'
/home/naveen/ethz_ws/devel/.private/voxblox_rrt_planner/lib/libvoxblox_rrt_planner.so: undefined reference to `ompl::geometric::RRTstar::RRTstar(std::shared_ptr<ompl::base::SpaceInformation> const&)'
/home/naveen/ethz_ws/devel/.private/voxblox_rrt_planner/lib/libvoxblox_rrt_planner.so: undefined reference to `ompl::base::Planner::setProblemDefinition(std::shared_ptr<ompl::base::ProblemDefinition> const&)'
/home/naveen/ethz_ws/devel/.private/voxblox_rrt_planner/lib/libvoxblox_rrt_planner.so: undefined reference to `ompl::base::PathLengthOptimizationObjective::PathLengthOptimizationObjective(std::shared_ptr<ompl::base::SpaceInformation> const&)'
collect2: error: ld returned 1 exit status
make[2]: *** [/home/naveen/ethz_ws/devel/.private/voxblox_rrt_planner/lib/voxblox_rrt_planner/voxblox_rrt_planner_node] Error 1
make[1]: *** [CMakeFiles/voxblox_rrt_planner_node.dir/all] Error 2
make: *** [all] Error 2

I have installed ompl library
other planner like voxblox_skeleton_planner are working fine in the system except this

Hello, try this:
sudo apt-get install libompl-dev
Installing the library in this way worked for me.

@AVR-TEC 's suggestion worked for me as well on Melodic.
To add to it, I also had to remove ros-melodic-ompl

@naveenbiitk  were you able to resolve this . I'm getting this error despite following what @AVR-TEC  and @saihv suggested.

@SaiHaneeshAllu
Hello, Could you try this?
cd mav_voxblox_planning && git checkout devel/melodic_ompl sudo apt install libompl-dev catkin build

@Tatsuya-2  that worked. Thanks!

@SaiHaneeshAllu
Hello, Could you try this? I can build this repo.
cd mav_voxblox_planning && git checkout devel/melodic_ompl && sudo apt install libompl-dev && catkin build

这个靠谱！


selected exemplars were similar for different questions.

Hello, I've discovered that RL chose similar exemplars even when the query questions are different based on what I've learned from both the training logs and the resulting json files. Put otherwise, a certain number of exemplars were chosen at high frequencies.

See shot_pids in json, where "9254" and "36539" were frequently selected while "4995" was never used.
See cids for sample[-1] in batch in log, where [13  1] and [1 13] were dominant.

Does this suggest that those exemplars are in any way representative of the task or dataset?

Hi, Thank you for sharing your observations. The frequent selection of certain exemplars could indicate that these exemplars are highly representative of the dataset or task, suggesting their high utility in maximizing prediction rewards. However, it may raise concerns about potential overfitting or a lack of diversity in the selection process.
To address this, it's worth investigating the characteristics of these frequently selected exemplars and considering strategies to encourage a more diverse selection, such as implementing diversity-promoting mechanisms in the policy gradient strategy. This could help in understanding whether the current selection pattern is indeed optimal or if there's room for improvement to enhance generalization.