IFramed Redirect Fails in Firefox

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.14.2
Wrapper Library
MSAL Angular (@azure/msal-angular)
Wrapper Library Version
2.0.0
Description
We have a legacy VB.NET Webforms application that is authenticated against Azure B2C. As we are trying to replace certain pages/functionality we are trying to host a sub-domain in an IFrame within the Webform application. When the IFramed Angular 12 application is loaded it uses MSAL to do a LoginRedirect in order to acquire the token that the host Webform application already has. This works fine for Chrome and Edge. However, in Firefox we get the following error below.
At this point I am unsure if this is a B2C issue (due to the X-Frame-Options header) or if this has to do with MSAL.JS as it is working fine in Chrome and Edge. As the tenant does support some implicit flow redirects still, that setting is checked but the redirect uris for this application are setup under the SPA section in the B2C configuration.
Error Message
Firefox Console Error:
The loading of “https:///oauth2/v2.0/authorize?client_id=&scope=openid%20profile%20offline_access&redirect_uri=https%3A%2F%2Flocalhost%3A44328%2Fauth-callback&client-request-id=83c30574-4605-40b1-afe8-853b258e9cbf&response_mode=fragment&response_type=code&x-client-SKU=msal.js.browser&x-client-VER=2.14.2&x-client-OS=&x-client-CPU=&client_info=1&code_challenge=PKfTplwY4Qh9qE3LljDuD3P0sMeHBl2_a84her9t4uA&code_challenge_method=S256&nonce=057ca95f-e9a8-4a3f-ae9c-10ac2dedac3d&state=eyJpZCI6IjYwOTU0OGNjLTk4MDItNGE3OS04ZGY2LWZkY2RhMDA0MWM1ZCIsIm1ldGEiOnsiaW50ZXJhY3Rpb25UeXBlIjoicmVkaXJlY3QifX0%3D%7Cpush-log” in a frame is denied by “X-Frame-Options“ directive set to “DENY“.

Msal Logs
No response
MSAL Configuration
this._msalConfiguration = {
  auth: {
    clientId: authentication.clientId,
    authority: authentication.identityServiceUri,
    knownAuthorities: [authentication.identityServiceUri],
    redirectUri: '/',
    postLogoutRedirectUri: '/'
  },
  cache: {
    cacheLocation: BrowserCacheLocation.LocalStorage,
    storeAuthStateInCookie: this._isIE
  },
  system: {
    loggerOptions: {
      loggerCallback: this.authenticationLogger,
      logLevel: environment.production ? LogLevel.Info : LogLevel.Trace,
      piiLoggingEnabled: !environment.production
    },
    allowRedirectInIframe: true
  }
};

Relevant Code Snippets
return this.authService.loginRedirect({
  scopes: ['openid'],
  state: params.page,
  redirectUri: `${location.protocol}//${location.host}/auth-callback`,
  redirectStartPage: `${location.protocol}//${location.host}/auth-callback`
});

Reproduction Steps
Webform application on XXX.domain.com that includes a page with an iframe pointing to YYY.domain.com which loads an Angular application. Both use the same B2C workflow and identity for authentication.
Expected Behavior
The browser should properly handle the redirect and render the page without issue.
Identity Provider
Azure B2C Custom Policy
Browsers Affected (Select all that apply)
Firefox
Regression
No response
Source
External (Customer)

It turns out my issue was that Firefox, even in non-private browser was by default set to Strict mode for the 3rd party cookies and this was causing the blockage.


export is undefined

When using the retina.js file without any other dependency than jQuery, the "export" line in the end of the file is "undefined" .
Maybe it should be checked before being accessed for undefined?

The same thing. In minified version i have not this error, but still script isnt working, but working on other pages.

Same error here :(

Same here. Is there already a solution?

rjs attribute is needed to img tag
And this is fixed js file, that work in our project
retina.js.tar.gz

Same issue here, but the fixed JS provided by @maliyshock works for me! Thank you


Add the ROCKFB Collection

Please add the Collection., sorry for all the trouble I've caused.
https://x.com/RockFractalBitc

Please let your dev check the inscriptions.json file. There's something wrong.
![image](https://github.com/user-attachments/assets/948ae839-ab21-4946-8c2c-6deda2256f04

Hi, iyour inscriptions.json file doesn't comply with the json format, you need correct it, then upload meta.json and inscriptions.json file here for review. @FractalStone


chore: replace deno.land/x with jsr in examples and badges

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


How do you set environment variables?

There is a page listing out all the environment variables but no reference in the docs about cog.yaml about where and how these should be included.
I've tried to figure it out from old PRs but couldn't find anything conclusive.

Thanks for reporting. Cog's support for env/secrets at build time and run time is not yet well documented.
Can you share a bit more detail about what you're trying to accomplish?
If you want to set environment variables when running a model (not building), you can pass the -e flag to cog predict or cog run. See https://github.com/replicate/cog/pull/1253
If you want to inject secrets into your built image, see https://github.com/replicate/cog/blob/main/docs/private-package-registry.md

Thanks. I am trying to trying to set the WEBHOOK_AUTH_TOKEN as documented here.

I see. Are you running Cog on your own infrastructure and wanting to be able to send webhooks?

Yes I am. The webhooks are all working fine. I just would like to be able to set this WEBHOOK_AUTH_TOKEN for extra security at my webhook endpoint.

How can i set up environment variables to a prediction model if the model needs to communicate with external services (API endpoints, etc)?


Update Backend Service to EDC 0.7.0

Previously "initiate transfer" was using receiverHttpEndpoint to send EDR to backend service. This is now deprecated.

Add "callbackAddresses" in "initiate transfer" request.
Update backend service to process TransferProcessStarted event triggered after "initiate transfer" request.

Addressed in this PR: https://github.com/eclipse-tractusx/tutorial-resources/pull/417


demo/06-Contacts.elm does not compile

Detected errors in 1 module.

-- TOO FEW ARGUMENTS -------------------------------------- demo/06-Contacts.elm

Type Router.History has too few arguments.

59|     { history : History Route
                    ^^^^^^^
Expecting 2, but got 1.

It has been fixed in the last release. Thanks. :)


Validating an array input

Good day, this isn't really an issue, am migrating a certain project to Vue and using veevalidate form my forms. Most of input field are array field, e.g order[firstname], order[lastname]
Am unable to validate those field.

Found my way


notify-send: set app-name and urgency

Can you please include a screenshot of what this looks like? Thank you

I use dunst, so my setup is custom, but here you go:

And what does it look like without app name?

It's a 2 line patch. Do whatever you want
On Dec 3, 2017 1:15 PM, "Francisco Lourenço"<EMAIL_ADDRESS>wrote:

@aristidesfl commented on this pull request.
In conf.d/done.fish
https://github.com/fisherman/done/pull/25#discussion_r154536889:

@@ -69,7 +69,11 @@ and test -n __done_get_window_id  # is able to get window id
osascript -e "display notification "$message" with title "$title""

  	else if type -q notify-send # Linux notify-send

		notify-send --icon=terminal "$title" "$message"

		set -l crit

		if test $exit_status -ne 0

			set crit "--urgency=critical"

$urgency would be easier to read
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fisherman/done/pull/25#pullrequestreview-80713601,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIg5L-SKQJSpym5TE0tE5J9xPrQI-kPks5s8w9rgaJpZM4QzEz7
.


Updates to use Python2 and Python3 at same time

NOTE: Requires ESMA_cmake v3.4.0 to fully work (see https://github.com/GEOS-ESM/ESMA_cmake/pull/159)

Okay. I'll remove the blocking tag.
@mmanyin Eventually we'll need a release of this to "re-enable" the F2PY in Chem. I've also updated #122 to use the new style f2py in cmake as well in the MAM optics code.


P0 | Ability for DOM removal of selected facet

As a customer, I want the ability to completely remove facets from the DOM, as that might affect certain CSS properties I have on my UI.

After further investigation, came to the realization that this feature won't be useful. Currently, the mutation-observer script hides facets through the display: none style. This is equivalent to removing the element from the DOM.
Completely removing the element from the DOM would be difficult impossible since keeping track of the deleted/non-deleted elements would be very cumbersome and practically unfeasible.
Closing this issue as this is not something we will be supporting.
@facets-io/facet-all

After further investigation, came to the realization that this feature won't be useful. Currently, the mutation-observer script hides facets through the display: none style. This is equivalent to removing the element from the DOM.
Completely removing the element from the DOM would be difficult impossible since keeping track of the deleted/non-deleted elements would be very cumbersome and practically unfeasible.
Closing this issue as this is not something we will be supporting.
@facets-io/facet-all


It's possible for a release to fail, not show up in "helm ls", and block subsequent deployments

Hey folks!
I've noticed an interesting bug(?), when I encounter a failed release.. Here's an example:
root@cn1:~# helm ls -n dev
NAME            NAMESPACE       REVISION        UPDATED                                 STATUS          CHART                   APP VERSION
database        dev             1               2020-05-08 21:45:31.50934768 +0000 UTC  deployed        database-0.0.0-dev.100
ffl             dev             1               2020-05-08 22:17:43.699929593 +0000 UTC deployed        ffl-0.0.0-dev.10
minio           dev             1               2020-05-08 21:55:58.990715308 +0000 UTC deployed        minio-0.0.0-dev.26
tenantfe        dev             1               2020-05-08 22:17:09.700877147 +0000 UTC deployed        tenantfe-0.0.0-dev.128
root@cn1:~# helm delete -n dev fission
release "fission" uninstalled
root@cn1:~#

Note in the above, fission wasn't listed as a result of helm ls.
I did this because the failed release was preventing a new release:

history.go:52: [debug] getting history for release fission
12:07:12
upgrade.go:120: [debug] preparing upgrade for fission
12:07:12
Error: UPGRADE FAILED: "fission" has no deployed releases
12:07:12
helm.go:84: [debug] "fission" has no deployed releases
12:07:12
helm.sh/helm/v3/pkg/storage.(*Storage).DeployedAll
12:07:12
	/home/circleci/helm.sh/helm/pkg/storage/storage.go:143
12:07:12
helm.sh/helm/v3/pkg/storage.(*Storage).Deployed
12:07:12
	/home/circleci/helm.sh/helm/pkg/storage/storage.go:113
12:07:12
helm.sh/helm/v3/pkg/action.(*Upgrade).prepareUpgrade
12:07:12
	/home/circleci/helm.sh/helm/pkg/action/upgrade.go:163
12:07:12
helm.sh/helm/v3/pkg/action.(*Upgrade).Run
12:07:12
	/home/circleci/helm.sh/helm/pkg/action/upgrade.go:121
12:07:12
main.newUpgradeCmd.func1
12:07:12
	/home/circleci/helm.sh/helm/cmd/helm/upgrade.go:144
12:07:12
github.com/spf13/cobra.(*Command).execute
12:07:12
	/go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:842
12:07:12
github.com/spf13/cobra.(*Command).ExecuteC
12:07:12
	/go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:950
12:07:12
github.com/spf13/cobra.(*Command).Execute
12:07:12
	/go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:887
12:07:12
main.main
12:07:12
	/home/circleci/helm.sh/helm/cmd/helm/helm.go:83

Output of helm version: 3.2.0
Output of kubectl version: 1.16.4
Cloud Provider/Platform (AKS, GKE, Minikube etc.): Bare-metal kubeadm build

This has been fixed in #7653, you can try version 3.2.1 that includes this fix.

Understood, thank you :)

@liuming-dev Thank you so much!


[redacted]

[redacted]

@luphoria still being a good boi behind the scenes :)

@Bloxxel64

thanks man!

no problem ha. honestly was mostly doing it because my inbox was getting flooded. i want this project to succeed and be taken seriously, i just would rather not be involved anymore is all
not sure what all the cryptic posts from Agent-11 are referencing, but I think it's pretty safe to assume he doesn't like me much lmao. still never got a straight answer there :stuck_out_tongue_winking_eye:

@Bloxxel64

thanks man!

no problem ha. honestly was mostly doing it because my inbox was getting flooded. i want this project to succeed and be taken seriously, i just would rather not be involved anymore is all
not sure what all the cryptic posts from Agent-11 are referencing, but I think it's pretty safe to assume he doesn't like me much lmao. still never got a straight answer there 😜

Understandable lol. As for agent x. Yeah I don't get it either. I can understand not wanting to get involved on the project, of course, if the reason is what I think it is.  I got struck on the server because I didn't know what the R slur was. But whatever. Anyways how are you doing? I haven't talked to you too much since I became moderator of the subreddit.

not sure what all the cryptic posts from Agent-11 are referencing

yeah you do, pretty sure even 0x2480 dmed you about what you said

Is this about the whole Matrix thing?

Is this about the whole Matrix thing?

no

not sure what all the cryptic posts from Agent-11 are referencing

yeah you do, pretty sure even 0x2480 dmed you about what you said

i know im really late and you literally arent involved in sm64js at all anymore, tho im just wondering what did he say??


Unable to associate multiple vault credentials to a job_template

Tower CLI 3.3.0
API v2
AWX <IP_ADDRESS>
Ansible <IP_ADDRESS>
How can a associate multiple valt credentials (with different vault identifiers) to the same job template?
When I made:
tower-cli job_template modify --name JobTemplateName --vault-credential valut1 --vault-credential valut2
only vault2 has been taken into consideration

Addressing in https://github.com/ansible/tower-cli/issues/525
I don't know if we can remove this function of --vault-credential, because of backward-compatibility concerns with older Tower versions. A warning would be workable.


feat: create-onchain

What changed? Why?

add create-onchain CLI package

Notes to reviewers
How has it been tested?

Could you add a PR description and possibly include images or videos to help with reviewing this change? 🙏


Multiple tags support for sulu_admin.content_navigation service

Multiple tags are not working for content navigation.
Current workaround is to declare a second service with a different id for the same ContentNavigation class.

Just to be clear: we are talking about the sulu_admin.content_navigation-tag

The ContentNavigation service is gone, so this issue is obsolete.


update stageWidth and stageHeight on resize event.

It allows to update internal flash size that is not in fullscreen size on player container resizing.

Thanks for this, it was also fixed in https://github.com/johndyer/mediaelement/pull/1575 so I'll closed this one.


Fixing warning from node-validator

If you try to check an undefined field (the goal of the library in a nutshell), you get this warning from the node-validator library :

validator deprecated you tried to validate a undefined but this library (validator.js) validates strings only. Please update your code as this will be an error soon. node_modules/express-validator/lib/express_validator.js:338:41

Code sample :
req.assert('firstName', "missing_firstName").notEmpty(); // The error comes from here if this param is undefined
req.assert('lastName', "missing_lastName").notEmpty();
req.assert('username', "missing_username").notEmpty();
req.assert('password', "missing_password").notEmpty();

req.assert('username', "invalid_username").isEmail();
req.assert('password', "password_too_short").len(6);

This commit should fix the problem.

This is close. However, if you check one of the builds (https://travis-ci.org/ctavan/express-validator/jobs/121801347), you see we still have warnings regarding numbers:
validator deprecated you tried to validate a number but this library (validator.js) validates strings only. Please update your code as this will be an error soon. lib/express_validator.js:382:40

Since the main issue is that validator.js doesn't automatically convert to strings anymore in v5 (see https://github.com/chriso/validator.js/pull/496), we need to find a good place in the code to convert the params to strings, so that validator won't shout at us. However, when doing this we need to make sure that optional() still works as intended. Once we fix this, we can also upgrade validator to v5.x.

As was mentioned above, the problem is that validator.js is now designed to work only with strings. However, express-validator happily passes along non-string data to the validators, which is why we see that warning.
In the case of undefined values, the first thing to note is that despite seeing that warning, the validators are still being run. The undefined value is being coerced to an empty string, and the validators are running with that empty string as their input. This may or may not be what one expects or wants.
Second, what your code is doing is labeling all falsy values as errors. So I expect that if you test your code with "", null, 0, or any other falsy value, it will produce an error even when it is not appropriate. Consider the input 0; this should actually be treated as the string "0" and be validated accordingly.
Finally, I agree the way undefined values are currently handled is problematic. My concerns and solution are explained in #227.

Any update here?
Also what is the expected validation error if you pass in a undefined object?

+1
I'm looking forward to disappear this annoying warning message.
@rustybailey Could you tell me when fix this?

Sorry, I've been super busy and haven't had time for code outside of work. I'll try to look at this tonight.

+1 Still getting warnings. In my case, the input is coming from JSON. I can't control if the JSON request has numbers or nulls in it.

The warnings have been fixed in 2.20.4.


Create 200-Number-Of-Islands.cs

File(s) Modified: 200-Number-Of-Islands.cs
Language(s) Used: c#
Submission URL: _https://leetcode.com/submissions/detail/804194400/_

Thanks, @notauserx!


Add sign in with id token method

What kind of change does this PR introduce?
Close #43
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.

I maybe missing something - but it's not clear that this correctly sets the access token for rls for supabase client - any help here (extra steps needed) would be useful to people starting new projects.


test 2

Description
test 2
Issue Type
No response
Operating System
No response
Coral Device
No response
Other Devices
No response
Programming Language
No response
Relevant Log Output
No response

CSAT


Heater tiles appear on when they are off

Describe The Bug:
Home tile for heater appears white, which is how items appear when ON (vs gray when off), and tile text reads "Heating to 88" even though heat is off. Upon clicking on tile and turning heater on, the only change is that the temperature is now orange instead of white. This is very confusing compared to behavior of all other features which are clearly off or on.
To Reproduce:

Expected behavior:

Logs:
Show the Homebridge logs here, remove any sensitive information.

Plugin Config:
Show your Homebridge config.json here, remove any sensitive information.

Screenshots:

Environment:

Plugin Version: v2.1.1
Homebridge Version: v1.6.0
Node.js Version: v18.16.0
NPM Version:
Operating System: macOS

I have the same issue.  Has there been a solution to this?


Use a map for routes instead of iterating

In the original implementation, routes were iterated through one-by-one at runtime. This could cause a performance slowdown as new routes are added.
This PR generates a Map of all possible routes at startup, and then references that map when routing.

Hi Bryce,
thanks for the PR, I like the idea of caching routes, but I see two problems:

In development mode new routes are not picked up automagically, so the server instance has to be restarted on each addition of a new route handler (and therefore for any change in serverside code). This might be very anoying if you use caches, sessions, database pools etc.pp. which might take some time to get filled and you don't want to constantly loosing them.

As Jeasx supports serverless hosting (e.g. Vercel) and server-based hosting (e.g. classical Node hosting), a problem arises with serverless hosting: the initial serverless function needs more time to get started because all routes are calculated before anything is served.

Idea could be to use the existing implementation and build up a route cache at runtime (only for production). This would help the serverless scenario not much (only if your function is reused several times before it gets killed), but this wouldn't make the startup not slower. And for server-based hosting this would improve performance as your implementation.
Important question after all: Usually the route checks at runtime are very fast for me (about a millisecond for my projects). Maybe you can elaborate the scenario where this might take too much time? Just to prevent some kind of premature optimization, which is the root of all evil...;-)
Cheers, Maik

Hi Bryce,
I've implemented the "runtime cache" in my sandbox project:
https://github.com/jablonski/jeasx-sandbox/blob/main/serverless.ts
The results are good. For a single request it comes down to 1-2 milliseconds (hard to measure), but running huge loads of requests via a benchmark tool results in a performance improvement by factor 2.
Maybe you can have a look before I merge this into the main project?

I've integrated the runtime cache in Jeasx core, so I'm closing the PR.
https://github.com/jeasx/jeasx/blob/main/serverless.ts

Changes are released today with Jeasx 1.2.0. Thanks for bringing this topic onto the radar!

Glad to be of service!


Add aiomysql instrumentation

Related issues
closes #754

:grey_exclamation: Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #1107 opened

Reason: The PR is not allowed to run in the CI yet

Start Time: 2021-04-21T08:40:16.457+0000

Duration: 3 min 1 sec

Commit: db9de5ea7d93ae5efa7af4f8b9fb985d4ed2b2c6

Trends :test_tube:

Steps errors
Expand to view the steps failures

Load a resource file from a shared library

Took 0 min 0 sec . View more details on here
Description: approval-list/elastic/apm-agent-python.yml

Error signal

Took 0 min 0 sec . View more details on here
Description: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)

Log output
Expand to view the last 100 lines of log output

[2021-04-21T08:42:47.783Z]  > git checkout -f db9de5ea7d93ae5efa7af4f8b9fb985d4ed2b2c6 # timeout=15
[2021-04-21T08:42:51.450Z] Commit message: "Add aiomysql instrumentation"
[2021-04-21T08:42:51.450Z] First time build. Skipping changelog.
[2021-04-21T08:42:51.450Z] Cleaning workspace
[2021-04-21T08:42:51.539Z]  > git --version # timeout=10
[2021-04-21T08:42:51.551Z]  > git --version # 'git version 2.17.1'
[2021-04-21T08:42:51.565Z] fatal: bad object 164198de35fb31a0fead9e8a4d426de6c61f8948
[2021-04-21T08:42:51.452Z]  > git rev-parse --verify HEAD # timeout=10
[2021-04-21T08:42:51.461Z] Resetting working tree
[2021-04-21T08:42:51.461Z]  > git reset --hard # timeout=10
[2021-04-21T08:42:51.497Z]  > git clean -fdx # timeout=10
[2021-04-21T08:42:52.502Z] Masking supported pattern matches of $JOB_GCS_BUCKET or $NOTIFY_TO
[2021-04-21T08:42:52.595Z] The timestamps step is unnecessary when timestamps are enabled for all Pipeline builds.
[2021-04-21T08:42:52.743Z] Timeout set to expire in 1 hr 0 min
[2021-04-21T08:42:53.018Z] [INFO] Number of builds to be searched 10
[2021-04-21T08:42:53.216Z] [INFO] 'shallow' is forced to be disabled when running on PullRequests
[2021-04-21T08:42:53.249Z] Running in /var/lib/jenkins/workspace/hon_apm-agent-python-mbp_PR-1107/src/github.com/elastic/apm-agent-python
[2021-04-21T08:42:53.298Z] [INFO] gitCheckout: Checkout SCM PR-1107 with default customisation from the Item.
[2021-04-21T08:42:53.343Z] [INFO] Override default checkout
[2021-04-21T08:42:53.425Z] Sleeping for 10 sec
[2021-04-21T08:43:03.462Z] The recommended git tool is: git
[2021-04-21T08:43:03.582Z] using credential f6c7695a-671e-4f4f-a331-acdce44ff9ba
[2021-04-21T08:43:03.602Z] Wiping out workspace first.
[2021-04-21T08:43:03.612Z] Cloning the remote Git repository
[2021-04-21T08:43:03.612Z] Using shallow clone with depth 3
[2021-04-21T08:43:03.612Z] Avoid fetching tags
[2021-04-21T08:43:03.627Z] Cloning repository git@github.com:elastic/apm-agent-python.git
[2021-04-21T08:43:03.657Z]  > git init /var/lib/jenkins/workspace/hon_apm-agent-python-mbp_PR-1107/src/github.com/elastic/apm-agent-python # timeout=10
[2021-04-21T08:43:03.668Z] Fetching upstream changes from git@github.com:elastic/apm-agent-python.git
[2021-04-21T08:43:03.668Z]  > git --version # timeout=10
[2021-04-21T08:43:03.680Z]  > git --version # 'git version 2.17.1'
[2021-04-21T08:43:03.680Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-04-21T08:43:03.687Z]  > git fetch --no-tags --progress -- git@github.com:elastic/apm-agent-python.git +refs/heads/*:refs/remotes/origin/* # timeout=15
[2021-04-21T08:43:05.517Z] Cleaning workspace
[2021-04-21T08:43:05.501Z]  > git config remote.origin.url git@github.com:elastic/apm-agent-python.git # timeout=10
[2021-04-21T08:43:05.505Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
[2021-04-21T08:43:05.512Z]  > git config remote.origin.url git@github.com:elastic/apm-agent-python.git # timeout=10
[2021-04-21T08:43:05.531Z] Using shallow fetch with depth 3
[2021-04-21T08:43:05.531Z] Pruning obsolete local branches
[2021-04-21T08:43:06.199Z] Merging remotes/origin/master commit e70f1d9decf1da12c2dcf8e04dccfaa129b27bba into PR head commit db9de5ea7d93ae5efa7af4f8b9fb985d4ed2b2c6
[2021-04-21T08:43:06.293Z] Merge succeeded, producing db9de5ea7d93ae5efa7af4f8b9fb985d4ed2b2c6
[2021-04-21T08:43:06.294Z] Checking out Revision db9de5ea7d93ae5efa7af4f8b9fb985d4ed2b2c6 (PR-1107)
[2021-04-21T08:43:06.344Z] Commit message: "Add aiomysql instrumentation"
[2021-04-21T08:43:06.344Z] Cleaning workspace
[2021-04-21T08:43:06.412Z]  > git --version # timeout=10
[2021-04-21T08:43:06.414Z]  > git --version # 'git version 2.17.1'
[2021-04-21T08:43:06.421Z] fatal: bad object 164198de35fb31a0fead9e8a4d426de6c61f8948
[2021-04-21T08:43:05.518Z]  > git rev-parse --verify HEAD # timeout=10
[2021-04-21T08:43:05.523Z] No valid HEAD. Skipping the resetting
[2021-04-21T08:43:05.523Z]  > git clean -fdx # timeout=10
[2021-04-21T08:43:05.532Z] Fetching upstream changes from git@github.com:elastic/apm-agent-python.git
[2021-04-21T08:43:05.533Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-04-21T08:43:05.536Z]  > git fetch --no-tags --progress --prune -- git@github.com:elastic/apm-agent-python.git +refs/pull/1107/head:refs/remotes/origin/PR-1107 +refs/heads/master:refs/remotes/origin/master # timeout=15
[2021-04-21T08:43:06.201Z]  > git config core.sparsecheckout # timeout=10
[2021-04-21T08:43:06.204Z]  > git checkout -f db9de5ea7d93ae5efa7af4f8b9fb985d4ed2b2c6 # timeout=15
[2021-04-21T08:43:06.253Z]  > git remote # timeout=10
[2021-04-21T08:43:06.259Z]  > git config --get remote.origin.url # timeout=10
[2021-04-21T08:43:06.272Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-04-21T08:43:06.277Z]  > git merge e70f1d9decf1da12c2dcf8e04dccfaa129b27bba # timeout=10
[2021-04-21T08:43:06.285Z]  > git rev-parse HEAD^{commit} # timeout=10
[2021-04-21T08:43:06.296Z]  > git config core.sparsecheckout # timeout=10
[2021-04-21T08:43:06.300Z]  > git checkout -f db9de5ea7d93ae5efa7af4f8b9fb985d4ed2b2c6 # timeout=15
[2021-04-21T08:43:06.345Z]  > git rev-parse --verify HEAD # timeout=10
[2021-04-21T08:43:06.352Z] Resetting working tree
[2021-04-21T08:43:06.352Z]  > git reset --hard # timeout=10
[2021-04-21T08:43:06.383Z]  > git clean -fdx # timeout=10
[2021-04-21T08:43:07.391Z] Masking supported pattern matches of $GIT_USERNAME or $GIT_PASSWORD
[2021-04-21T08:43:08.083Z] + git fetch<EMAIL_ADDRESS>+refs/pull/*/head:refs/remotes/origin/pr/*
[2021-04-21T08:43:09.568Z] Running in /var/lib/jenkins/workspace/hon_apm-agent-python-mbp_PR-1107/src/github.com/elastic/apm-agent-python/.git
[2021-04-21T08:43:09.709Z] Archiving artifacts
[2021-04-21T08:43:10.454Z] + git rev-parse HEAD
[2021-04-21T08:43:10.846Z] + git rev-parse HEAD
[2021-04-21T08:43:11.191Z] + git rev-parse origin/pr/1107
[2021-04-21T08:43:11.261Z] [INFO] githubEnv: Found Git Build Cause: pr
[2021-04-21T08:43:11.614Z] Masking supported pattern matches of $GITHUB_TOKEN
[2021-04-21T08:43:12.609Z] [WARN] githubApiCall: The REST API call https://api.github.com/repos/elastic/apm-agent-python/pulls/1107/reviews return 0 elements
[2021-04-21T08:43:12.693Z] [INFO] githubPrCheckApproved: Title: Add aiomysql instrumentation - User: Sparkycz - Author Association: CONTRIBUTOR
[2021-04-21T08:43:13.087Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet
[2021-04-21T08:43:13.087Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)
[2021-04-21T08:43:13.194Z] [INFO] Let's stop build #1. The PR is not allowed to run in the CI yet
[2021-04-21T08:43:13.233Z] Sleeping for 5 sec
[2021-04-21T08:43:14.611Z] Stage "Sanity checks" skipped due to earlier failure(s)
[2021-04-21T08:43:14.732Z] Stage "Test" skipped due to earlier failure(s)
[2021-04-21T08:43:14.850Z] Stage "Building packages" skipped due to earlier failure(s)
[2021-04-21T08:43:14.965Z] Stage "Integration Tests" skipped due to earlier failure(s)
[2021-04-21T08:43:15.090Z] Stage "Benchmarks" skipped due to earlier failure(s)
[2021-04-21T08:43:15.352Z] Stage "Prepare Release" skipped due to earlier failure(s)
[2021-04-21T08:43:15.411Z] Stage "Prepare Release" skipped due to earlier failure(s)
[2021-04-21T08:43:15.539Z] Stage "Prepare Release" skipped due to earlier failure(s)
[2021-04-21T08:43:15.659Z] Stage "Prepare Release" skipped due to earlier failure(s)
[2021-04-21T08:43:16.212Z] Running on Jenkins in /var/lib/jenkins/workspace/hon_apm-agent-python-mbp_PR-1107
[2021-04-21T08:43:16.387Z] [INFO] getVaultSecret: Getting secrets
[2021-04-21T08:43:16.700Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-04-21T08:43:17.893Z] + chmod 755 generate-build-data.sh
[2021-04-21T08:43:17.894Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-python/apm-agent-python-mbp/PR-1107/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-python/apm-agent-python-mbp/PR-1107/runs/1 ABORTED 181158
[2021-04-21T08:43:18.144Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-python/apm-agent-python-mbp/PR-1107/runs/1/steps/?limit=10000 -o steps-info.json
[2021-04-21T08:43:18.695Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-python/apm-agent-python-mbp/PR-1107/runs/1/tests/?status=FAILED -o tests-errors.json
[2021-04-21T08:43:18.695Z] Retry 1/3 exited 22, retrying in 1 seconds...
[2021-04-21T08:43:20.039Z] Retry 2/3 exited 22, retrying in 2 seconds...
[2021-04-21T08:43:21.901Z] Retry 3/3 exited 22, no more retries left.

I rebased the branch by the current master due to fix conflicts in register.py etc.


Dynamically Provide Parameters for Workflows from UI

The Problem
Virtool Workflows may require arguments to be provided through the web UI. The specific arguments required vary greatly between different workflows. Thus, there is no one-size-fits-all solution to what arguments should be collected in the UI.
Thus, we require a robust way to define what information must be collected from the user in order for a workflow to be executed as a job.  Since the arguments required by a workflow are determined by the workflow developer, they should be explicitly declared by the workflow developer. The front-end UI must then adapt to the requirements that the workflow declares.
Proposed Solution
In order for the UI to adapt to the workflow's requirements, a data structure must be provided to the front-end application describing which data to collect and it's type(s). This structure can be provided through the front-end's HTTP API, or by generating the definitions as part of the deployment pipeline.
This structure would look something like this:
{
  "workflow": "name_of_workflow",
  "arguments": {
    "argument_1": {
      "type": "string",
      "help": "an example string argument for a virtool workflow"
    },
    "argument_2": {
      "type": "file",
      "help": "an example file argument for a virtool workflow"
    },
    "optional_argument": {
      "type": "integer",
      "help": "an example optional argument for a virtool workflow",
      "optional": true
    }
  }
}

Since we are already using workflow fixtures heavily, it makes sense to provide access to these arguments as fixtures.
Based on the structure above, argument_1, argument_2, and optional_argument would be made available within the
workflow code as fixtures.
I suggest implementing an API as part of virtool_workflow which will;

Implicitly produce a JSON object describing which arguments to collect and their types.
Handle retrieving arguments from the database and making them available as fixtures.

Possible API
Here is an example of what the API could look like for the workflow developer.
from virtool_workflow import Workflow
from virtool_workflow.user_arguments import user_argument
from typing import IO, Optional

argument_1 = user_argument("argument_1", type=str, help="an example string argument for a virtool workflow")
argument_2 = user_argument("argument_2", type=IO, help="an example file argument for a virtool workflow")

optional_argument = user_argument("optional_argument", type=int, optional=True,
    help="an example optional argument for a virtool workflow")

wf = Workflow()

@wf.step
def use_user_arguments(argument_1: str, argument_2: IO, optional_argument: Optional[int]):
    ...

Under the hood, the JSON structure for the front-end would be produced.
The workflow developer could then run an "install" step via the workflow command line utility.
workflow install -f my_workflow.py

Which would make sure that the front-end has access to the JSON structure and make the workflow
available in the UI to be run as a job.
Another Option: Use a Configuration File
We could also define the argument and type information apart from the code in a configuration file. This could be
a JSON file containing the exact structure used by the front-end, or something a bit nicer to deal with like YAML.
workflow: name
arguments:
    argument_1:
      type: str
      help: an example string argument
    argument_2:
      type: file
      help: an example file argument
    optional_argument:
      type: int
      help: an example optional argument

Fixtures could then be generated from the
YAML file.
from virtool_workflow.user_arguments import load_user_arguments
from pathlib import Path

fixtures = load_user_arguments(Path("my_config.yaml"))

wf = Workflow()

@wf.step
def use_user_arguments(argument_1: str, argument_2: IO, optional_argument: Optional[int]):
    ...

This idea is not yet fully developed. Any suggestions/criticisms are welcomed.

Thanks for thinking about this. I'd like to revisit it when we start adapting the COVID workflows to Virtool. For now, I am labelling Low Priority.

Closing until we want to revisit.


Hot reloading of CSS modules

Description
Hot reloading of CSS modules does not appear to work properly in Vike using React. When CSS modules are changed, the entire page reloads rather than applying the new styles. This is not consistent with behavior for Javascript/Typescript modules (which do properly reload) or handing of CSS modules in Vite without ssr.
How to replicate:

Scaffold a testing app with yarn @batijs/cli --react or similar
Add a file pages/index/main.module.css with the following contents:

.test {
    color: red;
    margin: 3em;
}

Alter pages/index/+Page.tsx to add the stylesheet:

import React from "react";
import { Counter } from "./Counter.js";
import styles from "./main.module.css";

export default function Page() {
  return (
    <>

My Vike app

      This page is:

Rendered to HTML.

          Interactive. <Counter />

    </>
  );
}

Change the style somehow. It should report hmr update /pages/index/+Page.tsx
Key step: restart the Vike server.
Change the style again. It now reports page reload pages/index/main.module.css and the page fully reloads

In Vike, changing a CSS style results in

In Vite without SSR (yarn dlx create-vite and similar updates to above), style updates result in:

Weirdly, HMR works properly when the CSS module has just been added in the same session.

See https://github.com/vikejs/vike/issues/1127.


Fix a failure of packman for --build_common_protos flag.

The grpc plugin command-line is omitted when this flag is specified,
thus --grpc_out should also be omitted.

[Current coverage][cc-pull] is 88.44%

Merging [#51][cc-pull] into [master][cc-base-branch] will increase coverage by 0.03%

@@             master        #51   diff @@
==========================================
  Files             3          3
  Lines           656        658     +2
  Methods         132        132
  Messages          0          0
  Branches        102        103     +1
==========================================
+ Hits            580        582     +2
  Misses           76         76
  Partials          0          0

Powered by Codecov. Last updated by [cbec2ad...6ca34b4][cc-compare]
[cc-base-branch]: https://codecov.io/gh/googleapis/packman/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/googleapis/packman/compare/cbec2ad61a69ddb2c4aaa7e14df053c1780fbac2...6ca34b42fbe6c9903a2c8981728f8c8c0f2ad740
[cc-pull]: https://codecov.io/gh/googleapis/packman/pull/51?src=pr

LGTM


Character System & Bullet System

https://github.com/Guuzzeji/plu-game-jam/assets/46883697/6a8b0909-5723-482e-8f95-7648b6f29e6c
List of Changes and Improvements

Created system for controlling bullet information like damage and name,
Fix bullet collision issue (bullets were hitting player character, which would cause it to count as a hit),
Added bullet life span system (self delete bullet after a couple of seconds)
Added Mana system, so now each bullet has a cost to use (similar to ammo in games)
Added Bullet collect system, now players can pick up different bullets
Add placeholder animation system, so game doesn't look static
Creating tooling for bullets and ammo pickups, don't have to write that much code now to create a bullet for the player, can probably reuse same code for enemies as well.
Creating a way for player to switch between bullets while in game (Need to make UI for this system still)
Other stuff

Added in game textures to test level for better look when testing
Other edits to the test level for testing bullets and pickups

Side note:

@levienk - you don't have to review this pull request, I just have to add someone as a reviewer in order to make the pull request go through.
If anyone has any suggestions, please add them as comments in the pull request, so I can see them and make a to-do list of what needs to be worked on.

Note to self: New commits fix some stuff I didn't like, like the loading resources code and other stuff. Now everything is good to push to main.

Note to self: Write next pull about fixing player animation to not suck as much, should use tween nodes for better animation, also work on how sound effects should work.
Good resource for understanding tween:

https://www.youtube.com/watch?v=04TB9gxz-uM
https://docs.godotengine.org/en/stable/classes/class_tween.html


chore(1.111.0-sp): release 1.111.0-sp.1

:robot: I have created a release *beep* *boop*
1.111.0-sp.1 (2021-05-12)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/googleapis/java-pubsub/releases/tag/v1.111.0-sp.1 :sunflower:


Inconsistent weight variable for some years

Some years (listed below) do not have a consistently-constructed weight variable across all rounds. What this means is that, when appended, some rounds' observations are disproportionately scaled. There also doesn't seem to be an obvious way to scale or manipulate the weight variable such that it can be harmonized: since some rounds do have multiple versions of the weight variable, we can test to see if a new scaled_weight_var is equal to an existing, "correct" final_weight_var
gen scaled_weight_var = wrongly_scaled_weight_var*10000
assert scaled_weight_var == final_weight_var

However, the assertion is wrong on ~30,000 observations, and a visual check shows that the translation between different weight variables is clearly not simply linear.
This issue applies to years: 2005, 2007
Furthermore, for 2008, there's only 1 internal weight variable in each round -- so no opportunity to compare -- but the January weight variable has a mean scaled much higher. Should I just scaled January down to the other rounds in this case without any way to confirm?
Furthermore, for 2009-2011, the problem is similar to 2008, except the only consistent weight variable is just called weight. There is indeed a fwgt or "Final weight" variable which is inconsistently coded across years, but the documentation is clear that this is the variable to use -- it says to use the variable indicated as "final weight". However, in 2012-13, the only weight variable available is not fwgt but weight, which leads me to believe that the latter may actually be the final weight variable even thought weight is not actually labeled as "final weight". Further complicating matters is that in 2014 onward, the variable labelled "Final weight' is in fact the correct, lower scaled, harmonized, weight variable. I think in summary, everything is inconsistent.
So if all the rounds do not have the compatible weight variables, what should I do?

In general, my advise is to compare with the published records of the PSA, as they have percentage but also absolute numbers. I have checked 2007 and can emulate the numbers with fwgt always. In the case of 2005 I don't get to any of the numbers. We are fairly close but I cannot comprehend why not.
In preparation for tomorrow I would recommend comparing to the published PSA data with the different weights to understand what the potential issues can be.

resolved in #67 : concluded that the data in the weight variables provided are good and the correct variables are used for each round. This is confirmed through checking the Labor Force Participation figures against those of the PSA and confirming that they are correct. For now, documenting the discrepancies in expanded population.


AttributeError: 'NoneType' object has no attribute 'get' on scorbbling

I have been able to log in to connect to both the last.fm and YoutubeMusic APIs. I edited the YouTube music API and getHistory seems to work, but it can't add to the database.
Getting history...
NEW: Scrobble for Please Come to Boston by Dave Loggins.
Traceback (most recent call last):
  File "/root/youtube-music-scrobbler/start.py", line 204, in <module>
    Process().execute()
  File "/root/youtube-music-scrobbler/start.py", line 190, in execute
    accepted = scrobbles.get('accepted')
AttributeError: 'NoneType' object has no attribute 'get'

Thank you so much for your work, this is a great project. I tried to manually update the code to reflect the fix you made and it got me past the initial getHistory error and got me to this error. I'll try to reinstall everything once the dependency gets updated.

I made a commit to replace the version with the dev version of the library, try running pip install to see if it works

@luisignaciocc I installed the fixed ytmusicapi version and I'm still getting the same error.

Oh. Which python version are you using?

I'm using 3.9.20

I'm on Python 3.9.18 using miniconda. This is my first time using it so it is possible I'm just making a mistake somehwere.

That might be it, how do you i find it? I'm on linux.

here https://github.com/luisignaciocc/youtube-music-scrobbler/blob/master/start.py#L181
try putting a print(xml_response), or to save the response to a file and let me know what you see

perfect!

maybe just remove the lastfm tokens and authenticate again

Figured out the API. Thank you for your patience and help!

@luisignaciocc I'm sorry, I have one last question. Does the program run automatically or will i have to set that up?

You need to set it up. You can just have the script on a small server and set up a cron job. Google cloud has a free tier of a micro server free forever, it should be enough.

@luisignaciocc Just wanted to let you know that I've got the app running on my server and it's been working perfectly. Thank you again! This is a great project.


Update node-gyp to 6.x

I didn't find anyone talking about this in the issues, so maybe this PR will spark some conversation.
I didn't personally run into issues while doing this in my project:
cd node_modules/prebuild && npm i node-gyp@5

Breaking changes in 5.x: https://github.com/nodejs/node-gyp/blob/master/CHANGELOG.md#v500-2019-06-13
Breaking changes in 4.x: https://github.com/nodejs/node-gyp/blob/master/CHANGELOG.md#v400-2019-04-24

Any chance the version of node-gyp could be configurable?

Any chance the version of node-gyp could be configurable?

That's dangerous because we use the programmatic API of node-gyp. You can however pass a custom instance: https://github.com/prebuild/prebuild#javascript-api

If we're going for a semver major increment, should we bump node-gyp all the way to the latest v6.x to include improvements for handling multiple Python versions?

I didn't realize 5x wasn't the latest! Yes, let's update to 6x.

10.0.0


Correct DB path for push to use local export path

Hi,
i found a little bug in the sync-lib.
When running a push and the DB-names of local and remote are different it uses the wrong path.
The local export is named after the local DB, so it needs to be the local name.
For pull it's the other way around - and was correct already.
Cheers,
Benjamin

Awesome! Thanks for pointing it out and for the pull request. Merged.


VirtualScroll in 2.3.0: "Uncaught TypeErrors" when scrolling

Ionic version:  (check one with "x")
[ ] 1.x
[x] 2.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
When I beginn to scroll in my Virtual Scroll , I immediately get the following "Uncaught Type Error(s)" error(s) in chrome:
virtual-scroll.js:538 Uncaught TypeError: Cannot set property 'scrollTop' of null
    at VirtualScroll.scrollUpdate (virtual-scroll.js:538)
    at SafeSubscriber.schedulerFn [as _next] (async.js:105)
    at SafeSubscriber.__tryOrUnsub (Subscriber.js:223)
    at SafeSubscriber.next (Subscriber.js:172)
    at Subscriber._next (Subscriber.js:125)
    at Subscriber.next (Subscriber.js:89)
    at EventEmitter.Subject.next (Subject.js:55)
    at EventEmitter.emit (async.js:79)
    at ScrollView.scroll.onScroll (content.js:328)
    at HTMLDivElement.scrollCallback (scroll-view.js:161)
VirtualScroll.scrollUpdate @ virtual-scroll.js:538
schedulerFn @ async.js:105
SafeSubscriber.__tryOrUnsub @ Subscriber.js:223
SafeSubscriber.next @ Subscriber.js:172
Subscriber._next @ Subscriber.js:125
Subscriber.next @ Subscriber.js:89
Subject.next @ Subject.js:55
EventEmitter.emit @ async.js:79
scroll.onScroll @ content.js:328
scrollCallback @ scroll-view.js:161
virtual-util.js:257 Uncaught TypeError: Cannot read property 'length' of null
    at updateDimensions (virtual-util.js:257)
    at VirtualScroll.scrollEnd (virtual-scroll.js:602)
    at SafeSubscriber.schedulerFn [as _next] (async.js:105)
    at SafeSubscriber.__tryOrUnsub (Subscriber.js:223)
    at SafeSubscriber.next (Subscriber.js:172)
    at Subscriber._next (Subscriber.js:125)
    at Subscriber.next (Subscriber.js:89)
    at EventEmitter.Subject.next (Subject.js:55)
    at EventEmitter.emit (async.js:79)
    at ScrollView.scroll.onScrollEnd (content.js:333)
    at scrollEnd (scroll-view.js:157)
    at dispatch (dom-controller.js:195)
    at DomController._flush (dom-controller.js:146)
    at rafCallback (dom-controller.js:135)
updateDimensions @ virtual-util.js:257
VirtualScroll.scrollEnd @ virtual-scroll.js:602
schedulerFn @ async.js:105
SafeSubscriber.__tryOrUnsub @ Subscriber.js:223
SafeSubscriber.next @ Subscriber.js:172
Subscriber._next @ Subscriber.js:125
Subscriber.next @ Subscriber.js:89
Subject.next @ Subject.js:55
EventEmitter.emit @ async.js:79
scroll.onScrollEnd @ content.js:333
scrollEnd @ scroll-view.js:157
dispatch @ dom-controller.js:195
DomController._flush @ dom-controller.js:146
rafCallback @ dom-controller.js:135

This error shows up since my updating to Ionic 2.3.0.
Expected behavior:
Scrolling in VirutalScroll list without exceptions.
Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
 ordova CLI: 6.5.0
Ionic Framework Version: 2.3.0
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.1.4
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Windows 10
Node Version: v6.9.5
Xcode version: Not installed

Hello, unfortunately i cannot reproduce this issue, would you mind sharing a repo we could reproduce this with? Thanks!

I managed to trace this issue down to my fault:
in my template I have two subsequent virtual scoll lists, which are triggered by an *ngIf clause:
<ion-list *ngIf="first" [virtualScroll]="items">
...
<ion-list>
<ion-list *ngIf="!first" [virtualScroll]="items">
...
<ion-list>

but my switch "first" was initialized in ionViewDidLoad() - obviously too late for a proper initialization of the template. After moving the initialization of "first" to the constructor, the runtime errors have gone.
With Ionic 2.2.0 I didn't run into this issue.
Since this issue obviously wasn't due to the upgrade to Ionic 2.3.0, I close this issue and thank you for looking into it!

Hi guys, ( @szerner @jgw96 )
I'm running into the same error but still can't figure out why.
I've posted my issue in ionic forum
https://forum.ionicframework.com/t/virtualscroll-scrollto-generates-typeerror-cannot-read-property-scrolltop-of-null/123148/2
I see your issue seemed related to concurrent scrollTo calls, and I think that is also what is happening to me, but not sure if it is the case and how to solve it.
I have a liveSample where it can be reproduced at will.
Just bring down the alpha-index-slider fast and you will get the error.
https://ionic-list100k-segment-index.stackblitz.io/
Thanks for any input.
Martin


⚠ API - Lens has degraded performance

In 3bd6343, API - Lens ($LENS_API_URL) experienced degraded performance:

HTTP code: 503
Response time: 641 ms

Resolved: API - Lens performance has improved in 1cc574c after 6 minutes.


Grab detailed movie data to hydrate missing runtime

There's a bunch of cinemas which aren't providing the runtime. This means they're being defaulted to 90 minutes. It would be great to figure out a more accurate number.
Hydration gets the movie DB id -- and the detailed movie data has a runtime. We'lre also going to need this data anyway for https://github.com/alistairjcbrown/hackney-cinema-calendar/issues/5 -- so let's grab it when generating the calendars.
It's probably not worth using the hydrated data in the calendar output -- it's nice to keep this as close to the cinema source as possible in case of mismatches. But we're just guessing the runtime at the moment, so even the risk of a mismatch doesn't really matter.
So for https://github.com/alistairjcbrown/hackney-cinema-calendar/issues/5 -- just rely on the caching mechanism so that future requests when generating the static site will get a cache hit instead of hitting the movie DB API again

Added in 28f7eecf0bb31afd17d8c99788973d0b097c35b6


Set-up Dependabot and maven workflow

Sorry, I'm traveling and didn't get a chance to take a look yet. Why did you change your mind?

Spring cleaning ! I don't like to keep things open too long.


Allow empty or missing description column

This tripped me up initially :)

Sure, done!

Thanks, @dbrgn !


[Managed Client]changes to packages files for after package rename

Updating the packages files with the new client package names. Did not update the WinJS universal quickstart.

Hi @gb92, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (gaben). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


Need to form proper RIFF header and capture WAV files, not raw

Today we dump the audio data directly on disk, resulting in .raw files with audio straight from ADC.
However this has been causing problems in that the information of the actual format is not present. Therefore during the flac encoding of the audio after downloading data onto a computer from whale tag, the only way to know the format is to go get the version of the embedded software on the tag and check for the encoding of the files.
To fix this I think we should actually use proper WAV files that do encode this information. As such, we'd need to form a proper RIFF header for capturing the audio data, not just dump the raw samples.

This also allows for more flexible use of the data acquisition system.  Currently the tags are only used at 96 kSPS, 16-bits, 3 channels - it is hardcoded.  Attaching the RIFF will allow future expert users to have flexibility with these settings without needing to otherwise informing the consumer of the files.
Also, as part of this, I suggest creating some new configuration variables that the program can reference:  BIT_DEPTH, SMPL_RATE, NUM_CHAN.  These could go in /opt/config/ceti-config.txt

The audio data comes out from FPGA in big endian format. RIFF does not support that unfortunately.
So instead, lets implement FLAC compression for the systems that are based on raspberry pi zero 2, which has enough CPU capacity.

Flac compression is in place for v2_2 that targets raspberry pi zero 2. Since it is the only platform that has enough compute to run compressor realtime. The old versions of the tags will still save raw audio data which will be encoded during offload. For data offload there's now a convenience script that can do offloading and encoding automatically, if needed, or just offload flac directly (https://github.com/Project-CETI/data-ingest/blob/main/scripts/tag.sh)


[lsan] Split the preset for lsan into stdlib -O and -Onone presets.

The current lsan preset used by the bot assumes -O. This is incorrect since:

It is a currently known problem that the -O build of swift leaks in the
optimizer on linux.

The point of the bot is to ensure that when compiling the stdlib at -Onone,
we are leaks clean.

For more information about the bot see below. Once this lands, I will update the
bot to use the new split preset.
rdar://32876901

For those who are unaware, I spent some time investigating and resolving the
leaks at -Onone b/c SourceKit for diagnostic purposes compiles sources at
-Onone, so the leaks could have hit SourceKit. Since SourceKit is a long running
process this could add up over time/etc.

@swift-ci smoke test and merge

... who broke source kit...

@swift-ci smoke test linux platform


complete server / client crash when pasting schematicannons with schematicannons

Describe the Bug
trying to paste a blueprint containing a schematicannon with a schematicannon will crash the game, sometimes so far that it also corrupts the world as teh schematicannon keeps trying to place the block on game load
Reproduction Steps

make a new schematic containing a schematicannon
put a schematic of that into an existing schematicannon
start the schematicannon
...
profit?

Expected Result
the schematicannon should place the schematicannon without issue, or at bleast skip iti f this action is illegal
Screenshots and Videos
No response
Crash Report or Log
https://pastebin.com/C7cjtqJ2
Operating System
Windows
Mod Version
0.5.0i
Minecraft Version
1.18.2
Other Mods
hermit builders create on modrinth
Additional Context
No response

on our own private server, this bug managed to corrupt the save so hard that the server now instantly crashes on startup, meaning we currently can't really play anymore

maybe you could try to delete the chunck file or smt?

maybe you could try to delete the chunck file or smt?

we ended up loading a backup. i'm more worried about other people encountering this bug and accidentally deleting the world.
also the shcematicannon was in a different chunk than the schematic, so you might have to delete multiple chunks, which sucks if you already got some heavy infrastructure built there

yea, i think there are ways to just delete blocks.

This should be fixed in 0.5.1


USHIFT-1031: fix golangci-lint reported issues

Which issue(s) this PR addresses:

USHIFT-1031
This PR applies fixes to errors caught by golangci-lint, or applies ignore directives when applicable.

/cherry-pick release-4.13

Most of these changes look like things we want.
I don't see a change to enable the linter in the Makefile, and I think we'll want that as part of this PR so we don't end up regressing.

Thanks, that's a good point. Will add.

Since the PR touches so many files, I'm hoping we can land the configuration refactoring in #1442 before this. Or at least not change the config package in this PR so I don't have to rebase again.

I'm fine keeping this one on hold until then.
/hold

/retest

/retest

Failure is due to the golangci-lint trying and failing to create a .cache dir in the user's home dir, which doesn't exist.  I'm working on a fix in CI to override the default cache location.

/retest

/test verify

/retest

@copejon , looks like the Verify test requires some fixes in the code
path_prefixer: 2/2, cgo: 57/57, uniq_by_line: 2/2, source_code: 2/2, severity-rules: 2/2, path_prettifier: 57/57, skip_dirs: 57/57, autogenerated_exclude: 56/57, nolint: 2/4, path_shortener: 2/2, fixer: 2/2, sort_results: 2/2, identifier_marker: 56/56, exclude: 56/56, max_per_file_from_linter: 2/2"
level=info msg="[runner] processing took 7.378718ms with stages: nolint: 3.187383ms, autogenerated_exclude: 1.096068ms, identifier_marker: 1.044983ms, path_prettifier: 934.479µs, exclude-rules: 711.378µs, skip_dirs: 161.01µs, source_code: 91.681µs, cgo: 76.37µs, filename_unadjuster: 41.556µs, max_from_linter: 12.311µs, uniq_by_line: 9.266µs, max_same_issues: 5.412µs, path_shortener: 1.979µs, skip_files: 1.176µs, max_per_file_from_linter: 831ns, exclude: 692ns, diff: 569ns, fixer: 488ns, sort_results: 442ns, severity-rules: 427ns, path_prefixer: 217ns"
level=info msg="[runner] linters took 2m19.546670502s with stages: goanalysis_metalinter: 2m19.539099305s"
pkg/cmd/init_test.go:147:11: Error return value of `os.Mkdir` is not checked (errcheck)
		os.Mkdir(filepath.Join(rootDir, dir), 0600)
		        ^
pkg/cmd/init_test.go:154:25: Error return value is not checked (errcheck)
	cleanupStaleKubeconfigs(cfg, rootDir)
	                       ^

/retest

/test verify

The linter is satisfied, however the vulnerability check found 4 items and is failing the verify test.

This looks good. I set the merge method to squash, but you can remove that if you want. Remove the hold when you're ready.
/lgtm

/unhold


Unit Tests?

Hi all, I know some people were complaining in the ngrx hitter chatroom about the lack of tests here. I just finished adding some unit tests to my own ngrx project so I'm willing to help out here and write some for this project. :)
Let me know what I should use though- Jasmine vs mocha, what version, etc.
thanks! :)

Jasmine has better support for Angular 2, and I would think the latest version?  I too would love to see unit tests here.

@JimTheMan, Jasmine is already included in the project. Feel free to submit a PR with more unit tests!  Duplicate of #45


exec_js return type unmatched when using dialyzer

Dialyzer show warning when run over this code
case exec_js(socket, "confirm('Are you sure?')") do
    {:ok, true} -> true
    _ -> false
end

Looking over documetation (https://hexdocs.pm/drab/Drab.Core.html#t:return/0), it seems that return type is missing bool()

Also, for this code, return type also missing atom()
{:ok, ksuid} = peek(socket, :ksuid)
if ksuid == nil do
    []
else

Indeed!  exec_js was missing the boolean as a possible browser return type!  Fixed.  ^.^
And as for peek, hmm, it can return whatever the assign is, which can be literally anything.  It looks like the typespec of peek is wrong in general as it only returns {:ok, any()} or it raises.  Fixed it too.  :-)
I ran dialyzer on the project again just now but it didn't pick up anything new, but it's not very comprehensive.  ^.^;
New release coming out shortly as 0.10.3, corresponding to this issue being auto-closed by github.  :shipit:
If there is any other typespec issues, please report them!  Getting them correct now will be significantly useful for a later gradualizer run over the code when it's complete.  :-)


Resolves issue #19

As title. It's related to issue #19.

Thanks
I‘m still thinking about changes for 4.0
As soon as it is stable I will merge this :)


Seemless transfers of funds between Kraken and the Wallet - custodial

I will give an example for Bitcoin, however this is applicable for everything.
If I have 1 Bitcoin on Kraken and I am in the wallet I should have a button for "transfer funds".
Doing so custodian doesn't change - it's Kraken.
No blockchain transaction happens.
However my Kraken account now goes down to, let's say 0.9 Bitcoin, while my wallet debits me 0.1.
Ofcourse this has to be approved with the standart Kraken security checks - 2FA for withdrawal, Email, etc etc.
Once the transfer happens though then the security checks for my Bitcoin transferred to the wallet are subject to my settings of the wallet, not Kraken's main platform's.
(reminder, this is custodial part)
I can make a blockchain transaction - the send funds will be done by Kraken and signed by them - as again we didn't change custodial.
I can still use my blockchain addresses generated by the private key to deposit. Just "depositing", which is more like debiting, from Kraken to the Kraken wallet takes no Blockchain transaction.
It acts like a sub-account on Kraken platform.
The links can be done by public-key-to-account.
So if I delete the wallet when I reinstall it and put the same private key I automatically get access back to the Kraken sub-account.
I am not sure on legal side how does this work as I might give the key to someone else, who is not a customer of the company.
Maybe in the ToC I mentioned earlier it might be like that if I use this feature I am legally liable that I will not transfer the ownership to someone else by giving him the private key.

I will give an example for Bitcoin, however this is applicable for everything.
If I have 1 Bitcoin on Kraken and I am in the wallet I should have a button for "transfer funds". Doing so custodian doesn't change - it's Kraken. No blockchain transaction happens.
However my Kraken account now goes down to, let's say 0.9 Bitcoin, while my wallet debits me 0.1.
Ofcourse this has to be approved with the standart Kraken security checks - 2FA for withdrawal, Email, etc etc.
Once the transfer happens though then the security checks for my Bitcoin transferred to the wallet are subject to my settings of the wallet, not Kraken's main platform's.
(reminder, this is custodial part)
I can make a blockchain transaction - the send funds will be done by Kraken and signed by them - as again we didn't change custodial. I can still use my blockchain addresses generated by the private key to deposit. Just "depositing", which is more like debiting, from Kraken to the Kraken wallet takes no Blockchain transaction. It acts like a sub-account on Kraken platform.
The links can be done by public-key-to-account. So if I delete the wallet when I reinstall it and put the same private key I automatically get access back to the Kraken sub-account.
I am not sure on legal side how does this work as I might give the key to someone else, who is not a customer of the company. Maybe in the ToC I mentioned earlier it might be like that if I use this feature I am legally liable that I will not transfer the ownership to someone else by giving him the private key.

Hi there @RGPankO!
When transferring funds within Kraken, no blockchain transaction occurs; your balances are updated internally, and future blockchain transactions will be handled by Kraken, with security and custodianship remaining under your control via your private key. If the issue persists, I recommend contacting the support team for further assistance.
I've already submitted a support ticket for you with ID PPC7638. Please reference this when reaching out: Kraken Fx Wallet Dapps Support Ticket Requests.
You’ll find a live chat bubble in the bottom right corner of the page. Click it to start a conversation with a support agent who can help resolve the issue quickly.
For urgent help, live chat is the fastest option.
Thank you for your patience, and I hope this is resolved soon!


Obtaining the signature of a Def

It is very useful to obtain the signature of a Def inside a macro, for example to print it:
macro not_implemented!
  ::raise(::NotImplementedError.new(\{{ "#{<EMAIL_ADDRESS>}}))
end

or to recreate a Def:
class Foo
  macro method_added(a_def)
    def {{ a_def.name }}({{ a_def.args.splat }})
      previous_def + 1
    end
  end
end

A robust implementation would have to cover a lot of edge cases for these macros to cover all possible Defs. It would be nice if an AST node method provides this functionality:
class Crystal::Macros::Def
  # If *owner* is truthy and this def has an owner, includes that owner
  # instead of the def's receiver, and uses `#` for instance methods
  # if *params* is truthy, includes the parameter list and free variables
  # if *return_type* is truthy, includes the return type
  def signature(*, owner = false, params = false, return_type = false) : MacroId
  end
end

Some examples:
class Foo::Bar
  def foo(x : T) : Int32 forall T
    {{ @def.signature }}                    # => foo
    {{ @def.signature(owner: true) }}       # => Foo::Bar#foo
    {{ @def.signature(params: true) }}      # => foo(x : T) forall T
    {{ @def.signature(return_type: true) }} # => foo : Int32
  end

  def self.foo
    {{ @def.signature(owner: true) }} # => Foo::Bar.foo
  end
end

Then signature(owner: true) matches the usage in #13078, signature(owner: true, params: true) matches the display in "no overload matches" errors, and def {{ @def.signature(params: true, return_type: true) }}; {{ @def.body }}; end can be used to recreate a Def node. The other argument combinations are probably less useful.

While being very similar, there's a significant distinction between these use cases. A method signature that can be used after def produces Crystal syntax. The reference form on the other hand does not. I think that deserves some separation.
Both variants can be useful, but they probably shouldn't be merged into a single method.
A good evidence is that MacroId should ever only contain valid syntax. Formats such as Foo::Bar#foo wouldn't fit that. It should be returned as StringLiteral.

Then what about:
class Crystal::Macros::Def
  # as though *owner* is truthy
  def description(*, params = false, return_type = false) : StringLiteral
  end

  # as though *owner* is falsey
  def signature(*, params = false, return_type = false) : MacroId
  end
end

I am not sure if "reference" is a right and unambiguous name for the first use case.

I don't think the presence of owner is actually the distinctive aspect. The description variant is commonly used without an owner as well: #foo.

I am not sure if "reference" is a right and unambiguous name for the first use case.

Probably not. I was using it just for lack of a better term.


enhancement(api-v2): Optimise checking isDeleted (DSP-848)

This PR adds an optimisation to improve the filtering of resources and values marked as deleted in Jena.

[x] With Jena, use FILTER NOT EXISTS to check knora-base:isDeleted in queries that could return many results.
[x] Improve the optimisation from #1717 by not moving statements whose predicate is rdf:subject or rdf:object (meaning that the subject is a LinkValue which should be referred to first).
[x] Add test.

Resolves DSP-848.

@SepidehAlassi Loïc says this change improves performance a lot: https://dasch.myjetbrains.com/youtrack/issue/DSP-848#focus=Comments-4-1575.0-0

Thanks for the review!


Mention in README that this is not working in Safari

Hi, the solution does not work in Safari :-(. The extraction works great, linking to sprite.svg#fragment from background-image CSS attribute is good with Chrome, but in Safari you have no luck.
Mentioning this in README would save me few hours implementing the package into our dev stack. We cannot afford having no icons in Safari.
Would it be a problem to mention this right away? Thank you.

Hi! Could you please make a PR?

@vchrm ping

Yes, but not this week (too much work). Moreover I am still investigating the issue (trying to find some working polyfill or something).

Check this one https://github.com/Keyamoon/svgxuse

I have the same issue. Unfortunately svgxuse is not working for this purpose. Any other solution? Maybe this has something to do with the way svg-sprite-loader is creating fragments id's in external file (exposed by use element referenced internally to symbol).

@vchrm currently it's a planned feature for 4.x (see kisenka/svg-baker#4), but as usual I have no time to implement it :) BTW the only working approach among all browsers is to create classic sprite and move it's background-position. I'll try to find time on next week.

Do we agree that this is what Safari is missing? https://caniuse.com/#feat=svg-fragment

@vchrm yes, both, desktop and mobile.

The simplest solution is to use object instead of img. Not sure if this has some disadvantages.

Looking forward to hearing from this 👍


Persisting data during the OAuth flow in Java app

Description
We want to map the slack team id with our user id once the slack installation is done.  Currently, we are using AmazonS3InstallationService as a post-installation hook.   We get installation information in saveInstallerAndBot however we don't know how to map slack team id with our user id. To achieve that we want to pass our user context when the user is clicking on our slack install  URL i.e https://xxxxx/messaging/slack/install.  Found this document how to do it on nodejs however I am not getting how to achieve the same in it in java. Currently, we are using the below SDK version.
<dependency>
    <groupId>com.slack.api</groupId>
    <artifactId>bolt</artifactId>
    <version>1.8.1</version>
</dependency>

Hi @rishisaraf11, thanks for asking the question! With this Java SDK, you can customize the following callbacks and service layer for the purpose:

The most relevant part only: App#oauthPersistenceCallback(OAuthV2SuccessPersistenceCallback persistenceCallback)
A bit broader part to override: App#oauthCallback(OAuthV2SuccessHandler handler)

Also, the internal code that handles the OAuth flow callback is here.
I hope this was helpful to you.

@seratch  thanks reply. Can you let me know how I pass the context of my user(like userId our of our application) when navigating user to install page. Once installation is done we need this userId so that we can map our userId with slack teamId

@rishisaraf11

Can you let me know how I pass the context of my user(like the userId of our application) when navigating the user to the install page?

This is not feasible in a simple way. The only approach that I can suggest is:

Ask your user to go through Sign in with Slack first
Save the user ID in browser cookie as a kind of state
Ask your user to go through the main OAuth flow to install your app

I know that this may be suitable for your use case but without "signing in with Slack" first, your /slack/install endpoint is unable to know who the visitor is.

@seratch I found one hack. Let me know if it looks ok to you.
Set cookie value on install handler.  our install app will orgId as query param which then can be access in doGet
@WebServlet("/slack/install")
public class SlackOAuthInstallController extends SlackOAuthAppServlet {
    public SlackOAuthInstallController(App app) {
        super(app);
    }

    @Override
    protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws IOException {
        Map<String, String[]> parameterMap = req.getParameterMap();
        if (parameterMap.get("orgId") != null) {
            Cookie cookie = new Cookie("orgId", parameterMap.get("orgId")[0]);
            resp.addCookie(cookie);
        }
        super.doGet(req, resp);
    }
}

Now retrieve the cookie value on oauthPersistenceCallback
app.oauthPersistenceCallback(new OAuthV2SuccessPersistenceCallback() {
            @Override
            public void handle(Arguments args) {
                String cookiesHeader = args.getRequest().getHeaders().getFirstValue("cookie");
                List<HttpCookie> cookies = HttpCookie.parse(cookiesHeader);
                Optional<HttpCookie> httpCookie = cookies.stream().filter(cookie -> cookie.getName().equalsIgnoreCase("orgId")).findAny();
                if (httpCookie.isPresent()) {
                    logger.info("Got orgId from cookie" + httpCookie.get().getValue());
                }

            }
        });

@rishisaraf11 I don't think that it's secure enough to blindly trust the query string value. That being said, as long as the approach works for your specific use case plus you're okay with the security risk, it would be fine. Thanks for sharing this! Would you mind closing this issue now?


Relax indexmap PartialEq bounds so value doesn't need to be Eq

The old bounds were unnecessarily strict. This PR relaxes the V: Eq bound to V: PartialEq.

Can you add a test for something that didn't work before?


Accuracy on RAVEN-FAIR dataset is higher(98%) than that in the paper(88%)

I downloaded the pre training model you provided on Google disk and generated raven-fair dataset according to the project on GitHub

The accuracy of the first epoch trained from the breakpoint has been significantly improved

The accuracy of the follow-up results is much higher than that in the paper.

The performence of training from scratch on RAVEN-FAIR is similar.
The results of the original Raven dataset training from scratch are consistent with the paper, but raven-fair is directly generated by GitHub, and there should be no problem, so I can't judge where there is a problem.
Therefore, I would like to consult you. Thank you

I seem to have found the problem: the npz file of the original RAVEN dataset is much bigger raven-fair

But I don't know why and how to solve this problem.
This is my environment for RAVEN_ FAIR-master.

This is the command I used to generate the raven-fair dataset.
python main.py --fair 1 --save-dir ../../dataset/

Hi
Let me look at it and get back to you
בתאריך יום ו׳, 31 בדצמ׳ 2021 ב-6:18 מאת WuGuommming <
@.***>:

I seem to have found the problem: the npz file of the original RAVEN
dataset is much bigger raven-fair
[image: d60ba927ca5d63f34a6fb70d948ab65]
https://user-images.githubusercontent.com/35882620/147802823-e0896150-3618-46af-91ca-0530e33ee371.png
[image: 74e34194669fa1dbbf69ea2ee08813b]
https://user-images.githubusercontent.com/35882620/147802826-1034facb-daaf-4cca-a383-60ae1eaa1e0f.png
But I don't know why and how to solve this problem.
This is my environment for RAVEN_ FAIR-master.
[image: image]
https://user-images.githubusercontent.com/35882620/147802978-b9b4515c-3871-4b12-941b-41358b29eb5f.png
This is the command I used to generate the raven-fair dataset.
python main.py --fair 1 --save-dir ../../dataset/
—
Reply to this email directly, view it on GitHub
https://github.com/yanivbenny/MRNet/issues/1#issuecomment-1003263245,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIKOOJW7EH77BGHT2UUFF5LUTUVK3ANCNFSM5K7IDA5Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Sorry for this very late response.
There was a bug that resulted in all raven splits to take all train+val+test samples.
This resulted in higher accuracy since it was computed on the train samples as well.
This issue has been resolved.


Optional enum crashes the app

Rendering the following schema will crash the app, due to options being undefined in the displayed component.
const schema = z.object({
  fruits: z.enum(['apple', 'orange'] as const).optional()
})

Not an issue anymore


Allow prison pearled players to pickup and move pearls in inv

Note this change allows prison pearled players to pick up their own pearl and free themselves


Add Vc::pow and Vc::cbrt functions

Some math functions like logarithm and trigonometric ones already exist for float_v and double_v. Would be a good idea to add a portable Vc::pow function as well. Is there any plan on this front?

Hi, thank you for your interest.
Yes, I would very much like to have the complete set of math functions in Vc (i.e. all of <cmath>. My problem is time/manpower. But I'd be very happy to integrate a patch. My preferred way forward would be integration with vdt, i.e. extend vdt to execute math functions with Vc types.

Thanks for the heads up on vdt. I just started playing with it. However, it seems to me that the functionality of vdt is already available in Vc, unless I am missing something or unless vdt offers superior performance.
Turns out adding a pow function would be straightforward using log and exp functions already available in Vc. Here is my rudimentary implementation
// exponentiate vector with scalar
template<typename T, typename M=int>
Vc_ALWAYS_INLINE Vc::Vector<T> pow(const Vc::Vector<T> &x, M y) {
    return Vc::exp(static_cast<T>(y)*Vc::log(x));
}

// exponentiate vector with vector
template<typename T>
Vc_ALWAYS_INLINE Vc::Vector<T> pow(const Vc::Vector<T> &x, Vc::Vector<T> y) {
    return Vc::exp(y*Vc::log(x));
}

On a simple benchmark on my Ivy-Bridge machine, this performs almost 10x faster than the standard libm implementation when iterating over an array of 1024 elements, for single precision.

vdt offers a complete implementation of the math functions. Vc uses the same algorithms, but has less functions implemented.
Your exp(log) solution looks like a simple intermediate solution. I'd be happy to merge such a pull request if you can generate the necessary test data and write a unit test for it. The first concern is accuracy. The second concern is that it must be faster than scalar...


continuing/dropping dotnet 2 support?

SharpFont ( https://github.com/HinTak/SharpFont ) v4.0.0 started depending on net 3.5+ Linq . IronPython did the same with 2.7 . Mono 4.4 also starts to drop support below dotnet 4.5 .
I have stayed with mono 4.2 for building FontVal 2.0 for that reason.
My current master at mine has a patched SharpFont 3.x ,  and my hybrid+empy.2016-05-06 has IronPython 2.6, to stay dotnet 2.x compatible.
Currently the incentive to break dotnet 2.x support is not strong - you'll still need to patch SharpFont v4.0 to use it with FontVal anyway, so it is just from patching version x to patching version y. It would be more persuasive if all 3 of the issues form my 4 SharrpFont patches are incorporated upstream:
https://github.com/Robmaister/SharpFont/issues/82
https://github.com/Robmaister/SharpFont/issues/87
https://github.com/Robmaister/SharpFont/issues/88

I kept dotnet 2 support mostly because dotnet2 runs under wine and the older FontVal 1.0's rasterization test requires genuine dotnet2 (i.e. not wine-mono). It is easier for comparison if both 1.0 and 2.0 run under the same-ish environment.

One action I contemplate, is to rename the current embedded-python branch as master and master as dotnet2 (this would upset most people who has a clone, on renaming branches). Or fork master into dotnet2 then merge embedded-python branch to master.
I like the former as it is neater, but it is rather upsetting to anybody who has already got a clone.

Upstream changed their mind a little after v4.0, so the FontVal v2.1 will be based on SharpFont v4.0+backports. See
https://github.com/Robmaister/SharpFont/issues/95


staccato: init at 0.1.6

Add the package staccato, "a command line program that lets you
compute statistics from values from a file or standard input".
I have tested this change per nixpkgs manual section 13.1 ("Making
patches").

Thanks!

Thanks for merging!


Does My iOS KMM Library Need to Be Static For dSYM to Work Properly?

Description
A point I've found endlessly confusing and not well explained on the Kotlin docs... do I need my iOS shared library to be static? If so why? and if not why do I not seem to be getting line numbers from my dynamic lib crash reports? Are there any additional Gradle configs I might be missing?
Here's what my Gradle cocoapods config looks like:
    cocoapods {
        // Configure fields required by CocoaPods.
        summary = "some description"
        homepage = "myurl.com"
        pod("Sentry", "~> 8.4.0")
        ios.deploymentTarget = "14"
        framework {

            // You can change the name of the produced framework.
            // By default, it is the name of the Gradle project.
            baseName = "shared"

            // this needs to be false in order to view SwiftUI previews, but needs to be true
            // to get symbolical builds. :/
            isStatic = false

            export("co.touchlab:kermit:$kermit_version")
        }
    }

Hi, if you use cocoapods you shouldn't need isStatic to symbolicate your stacktraces, if you're unsure about the setup you could take a look at the samples. The only time isStatic is necessary would be if you're using SPM to include the Sentry dependency (at least for now).
Maybe you did already but did you go through the uploading debug symbols steps?

@buenaflor That's great to know. Thank you so much. I have uploaded my debug symbols, but with no success all I see are the standard stack frames with no mapping unless I change my library to static then I weirdly do see the mapping. I'm kinda thinking it's either a gradle issue on my end or maybe I'm not uploading the correct dSYM file when generating the dynamic framework. I'll take a look at the sample and see if something becomes obvious that i missed.
Thanks so much for your response.

Hm, that's odd. Is that reproducible on your https://github.com/alexwhb/Sentry-KMM-Bug repo as well?

@buenaflor Good question. I'll give that a test today and let you know. 👍

@buenaflor I figured it out! I was missing --include-sources flag in my sentry-cli debug-files upload. Now it's working for my dynamic library too. :) Thanks for your help. So happy to have this system working well at last. :D

@alexwhb I see - good to know! Feel free to write any further feedback, we really appreciate it!

Closing as resolved - you're still welcome to leave more feedback or insights :)


Introduce Pepr Istio to Cyber Engineers

As a Cyber developer
I need to be kept in the loop on the latest Pepr things
So that Cyber can benefit from the best out of Product

in progress working with @bburky


Unable to include the math package headers even after building to system(program files) and adding cmake prefix for WideDecimalConfig.cmake

Hi @numdouglas thanks for raising this issue.
Are you mentioning this in relation to the Cmake build? That is a new feature that has not (yet) been extensively used.
Since the wide-decimal library is intended to be header only, we can see if that works initially, then in a second step figure out what's going on with the CMake build in this particular case on your workstation.
When you simply get or clone the repository and place the headers in a known location, can you use them via standard #include with command-line -I syntax?

Yes sir I am using a CMake build file. I have managed to create a new project and import the exposed math package from building INSTALL.vcxproj in the cmake buildfile. It seems the issue was that I had already made multiple build dirs from the cloned  wide-decimal folder and intellisense was having some trouble getting the exact reference(was providing three header options per header file), so when I started a fresh project with no existing wide-decimal (build) folder, the problem was gone. Here is the simple cmake file.
`cmake_minimum_required (VERSION 3.8)
add_executable(mainApp dec_make.cpp)
find_package(Catch2 REQUIRED)
find_package(WideDecimal REQUIRED)
find_package(fmt)
target_link_libraries(mainApp Catch2::Catch2 WideDecimal::WideDecimal fmt::fmt)`

otherwise it went fine

Cool.
Thanks for getting back on this @numdouglas
I'll re-copy the cmake file here for future reference.
cmake_minimum_required (VERSION 3.8)

add_executable (some_test "some_test.cpp" "some_test.h")

find_package(Catch2)

set(WideDecimal_DIR "/Program Files (x86)/wide-decimal/lib/cmake/wide-decimal")
find_package(WideDecimal)

target_link_libraries(some_test Catch2::Catch2 WideDecimal::WideDecimal)

I still have a lot to learn about CMake.

Thank you. Me too.


Ability to create Local Secondary Index for AppSync Model table

Environment information
NA

Describe the feature
Currently we can only crease GSI for the data models in Amplify.

ChartOfAccount: a
    .model({
      orgId: a.id().required(),
      accountName: a.string().required(),
      accountDescription: a.string(),
      categoryName: a.string().required(),
      categoryType: a.string().required(),}) //ex: "INCOME", "EXPENSE", "ASSET",
    .identifier(["orgId", "accountName"])
    .secondaryIndexes((index) => [index("orgId").sortKeys(["categoryName"])])
    .authorization((allow) => [allow.owner()]),
});

There is no option to create Local Secondary Index for the model. Unable to update/add using the backend.ts as the table would be already created by then and the LSI should be created with the table.
Use case
To create and use Local Secondary Index for the data models in amplify.

Any update on this?


Preserve API compat with original bash script

Will probably require custom CLI framework

Implemented hacky CLI parsing for now.


vimPlugins.nvim-bufferline-lua: init at 2021-03-22

Motivation for this change
nvim-bufferline.lua is a snazzy bufferline for Neovim
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 117414 at 1e2bd7cd run on aarch64-linux 1

2 packages built successfully:

spacevim
vimPlugins.YouCompleteMe


Update authors.

Thanks to @iconara @lukedeo @danhermann @kimschmidtsbrain @lynnlangit @artemnikitin @thibaultcha for recent additions and help!

Thank you everyone!


crash with neoforge 1.21.1

https://mclo.gs/Pqjyi5O

This is EMI crashing after the rest of your game crashed, you'll have to look deeper at the log.

ur right, u found out the reason, the crash was caused by "FancyChicken" mob from earth2java mod, i disabled the spawn for it in the config and removed the mod then joined the world, then readded, now works fine.


Azure Function Deployment - Does not get reflected on the Portal

I was working with the Azure Function APP, I have deployed the code few times earlier, but when I try to deploy it after the code change done by myself, I got the deployment successful message in the vs code, but turns out in the console it does not get reflected.

After that, when I saw it in the console - Azure Portal

I could there see the function app name and trigger does not get reflected.
Details regarding the Function APP:
Trigger : Queue Trigger
Runtime : Python 3.11
Machine: linux

Hi @Mohanraj27v
Could you share more of your logs from the deployment? It may not be zipping up the directory with your project correctly.  If your project nested in another folder of your workspace?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


The application sometimes quits unexpectedly

The application sometimes quits unexpectedly without messages when scanning multiple EAN8 codes, if barcodes are scanned at an angle or are partially obscured by thin objects such as wires.
Last messages from output:
[me.scanmauitest] Explicit concurrent mark compact GC freed 23594(1205KB) AllocSpace objects, 0(0B) LOS objects, 49% free, 6627KB/12MB, paused 124us,1.180ms total 21.234ms
[OplusStatistics--] IllegalArgumentException:java.lang.IllegalArgumentException: Unknown URL content://com.oplus.statistics.provider/track_event
[native] F0000 00:00:1711725226.632530   28971 oned_decoder_client.cc:630] Check failed: recognition_options.HasBarcodeFormat(CODE_39)
[native] terminating.
[native] F0000 00:00:1711725226.632530   28971 oned_decoder_client.cc:630] Check failed: recognition_options.HasBarcodeFormat(CODE_39)
[native] terminating.
[libc] Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 28971 (pool-4-thread-3), pid 20585 (me.scanmauitest)
My device:
Realme GT Neo 5 RMX3709
Android 14
        <scanner:CameraView
                            OnDetectionFinished="CameraView_OnDetectionFinished"
                            CaptureQuality="High"
                            ForceInverted="False"
                            TapToFocusEnabled="True"
                            AimMode="False"
                            ViewfinderMode="True"
                            BarcodeSymbologies="Ean8"
                            x:Name="Barcode" />

Hello.
Can you provide some images of barcodes that produce a crash?

Can you provide some images of barcodes that produce a crash?

Sorry I couldn't replicate your problem, at least not on my device (Oneplus 7 Pro).
I've observed that in your scenario a lot of System.ObjectDisposedException exceptions is thrown, but it got caught every time and got resolved by camera restarting.

This seems to be an issue with device + MLKit combination, so the only option is to file a bug report here. Have you maybe tried enabling CODE 39 just to see if the crash continues? And does ti happen also if you only scan one code?
I'll double check if barcode type flags get propagated through the code properly.

I try run it on another mobile phone Xiaomi Redmi Note 10 Pro, MIUI 14.0.9, Android 13, result is same. I scan from screen picture on this webpage.
[me.scanmauitest] Explicit concurrent copying GC freed 43778(1757KB) AllocSpace objects, 0(0B) LOS objects, 49% free, 7411KB/14MB, paused 51us,29us total 25.098ms
[native] F0000 00:00:1713630347.962242   21040 oned_decoder_client.cc:630] Check failed: recognition_options.HasBarcodeFormat(CODE_39)
[native] terminating.
[native] F0000 00:00:1713630347.962242   21040 oned_decoder_client.cc:630] Check failed: recognition_options.HasBarcodeFormat(CODE_39)
[native] terminating.
[libc] Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 21040 (pool-5-thread-1), pid 13023 (me.scanmauitest)
[SmartPower.com.companyname.scanmauitest] 1988): visible->died(231653ms) R(process died ) adj=0.

We have the same issue when scanning QR-Codes on iOS. We only want to scan a single QR-code, so we navigate away from the page directly after we receive the first code.
The workaround from @johannes-steurer worked for us.

The workaround from @johannes-steurer worked for me. Thank you.
cameraView.CameraEnabled = false;
await System.Threading.Tasks.Task.Delay(100);
await navigation.PopModalAsync();


Feature Request: add pLDDT/PAE

From embed.predictprotein.org created by mheinzinger: sacdallago/embed.predictprotein.org#26
It would be super useful if users could get a lane in the feature-viewer that shows the pLDDT.
This way it gets immediately obvious which regions of the 3D structure to trust.
Optimally, we also offer coloring according to pLDDT.
In a second step (slightly less important but def. a cool feature to have): visualization of the PAE. This gives additional information on domain packing.

Yup, pLDDT should be absolutely already in the PDB file (in the B-factor column).
So if easy to add: absolutely great feature to have.
PAE can be added later;

Interestingly the pLDDT info should already be encoded in the PDB file if I remember correctly, and the viewer should display pLDDT by default if in the PDB file... somehow: it doesn't. Not sure I'll be able to debug this by week end


Move 'add' command to separate executable

Resolves #66

@ivan-podorozhnyi done

@extsoft thank you

@rultor please merge.

@rultor please merge.

@extsoft OK, I'll try to merge now. You can check the progress of the merge here

@rultor please merge.

@extsoft Done! FYI, the full log is here (took me 2min)


Separate some Kowalski queries from main feature generation script

For fields/ccd/quads near the galactic plane with many sources, the drop_close_bright_stars portion of our feature generation script (querying Gaia EDR3 for sources within 300 arcsec of each ZTF source) can take several hours. This is a significant amount of time where GPUs are not needed, but are currently being used anyway. If we ran this part of feature generation separately on CPUs and saved the results, we could reduce compute cost and dedicate more of the 48-hour maximum GPU walltime to period finding.

@bfhealy This cross-match is also done in Kowalski? What is slow exactly?

@mcoughlin The below cone search query (run for 10,000 sources at a time by default) is what's holding up that part of the code. The cone radius is 300 arcsec, and in dense regions of the sky the query returns a lot of EDR3 sources brighter than 13th G magnitude. Earlier in the script, it may help to filter ZTF sources using e.g. nobs > 20 to avoid running the Gaia query for sources without the requisite number of photometry points.
# Get Gaia EDR3 ID, G mag, BP-RP, and coordinates
        query = {
            "query_type": "cone_search",
            "query": {
                "object_coordinates": {
                    "radec": dict(zip(id_slice, radec_geojson.transpose().tolist())),
                    "cone_search_radius": query_radius_arcsec,
                    "cone_search_unit": 'arcsec',
                },
                "catalogs": {
                    catalog: {
                        # Select sources brighter than G magnitude 13:
                        # -Conversion to Tycho mags only good for G < 13
                        # -Need for exclusion radius only for stars with B <~ 13
                        # -For most stars, if G > 13, B > 13
                        "filter": {"phot_g_mean_mag": {"$lt": 13.0}},
                        "projection": {
                            "phot_g_mean_mag": 1,
                            "bp_rp": 1,
                            "coordinates.radec_geojson.coordinates": 1,
                        },
                    }
                },
                "filter": {},
            },
        }

Hi @bfhealy . Why not specify thag min number of detections in the query itself, maybe it might help constrain it a bit? I believe you can do: "candidate.ndethist": {"$gte": 2} to filter based on that?

Unless that is not available in Gaia, but if my understanding is correct its a variation of Kowalski so it might have that field as well.

Thanks @Theodlz, if that doesn't work I can modify a previous query to the ZTF_sources catalog and filter by the number of detections there. I'll give this a try and see how it speeds things up.

I agree that filtering upstream is best. Also, you can consider running the queries in parallel to divide the runtime by how many cores you have available. There is the code for that in penquins.

Thanks, I hadn't looked into the parallel query code yet but it seems to be helping.


License

Thanks for releasing the official implementation! I am working on integrating Reverse Distillation model into Anomalib. Can you provide a license for your code?

Hello, I have created a license.

Thanks!