Preservation of metadata

Thanks again for the TIFF image fix. I ran through the pipeline and I noticed that the resultant TIFF image I made from the resample command contains no metadata. After investigating, this appears to be the case in the example spleen .nrrd image as well. I attached an image of the metadata of this example from ImageJ, where the original is on the left, the resampled right. The resampled lacks the imaris_channels_information. This kind of information is important for our usecase as we want want to be able to visualize other channels besides the one used for registration. Is this possible with your software?

Hello @eturkes,
The focus of the sitk-ibex repository was on the algorithmic side, so details such as copying over the image meta-data after resampling are outside the scope.
Having said this, we have developed software that builds on the sitk-ibex package and supports an interface that is more in line with microscopy workflows, GUI and the output combines all resampled images into one and copies over channel information. Specifically, see the imaris extensions repository, XTRegisterSameChannel application. The only requirement there is that the files are in the ims format (I believe Fiji can export to ims). While originally designed to work as plugins for the Imaris program, these applications can also be run in standalone mode, so you do not need the Imaris software itself to take advantage of the extensions.

Dear @zivy
Thank you very much for the informative reply. I will certainly explore your suggestion and see if we can get our data into a suitable format. Really hoping so, your extensions repo looks quite developed!


 However, for certificates it should go further. There are two options:

Load blocks for last MAX_TTL epochs (see CSL-116).
Store snapshot of SSC global state on disk.

@georgeee
Features needed for non-genesis addresses support

@gromak
Currently I think we should choose the second option. It may be useful for other reasons as well.

@georgeee

is now easier to perform, so let's do it as for 1.


Add react/stream 0.7 to dependency list

Seems to cause no issues.
Signed-off-by: Yoshi2889<EMAIL_ADDRESS>

Well, guess I was wrong. Oops. Feel free to discard this PR if you want :)

Thanks for your PR!
Closed via #12


Add Posts Examples from RTK Query docs

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[x ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior
Need more examples
Expected behavior
Add Posts Examples from RTK Query docs

:tada: This issue has been resolved in version 1.4.0-next.1 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 1.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Mutually exclusive filters

The real benefit of this web map is to enable a user to stack the different filters. An example use case would be someone who is interested in accidents that have involved a pedestrian, and where someone was drunk, and where someone was severely injured or killed. At present, we can show any of these things in isolation, but cannot answer the combined question.
Food for thought: http://ipasic.com/article/query-and-filter-leaflet-map-layers/
This is probably a major change requiring entirely different tools (that example needs Django and PostGIS)... but the result is damn useful.

Solved #42, thanks Andrew!


Voice Mail support

One note: I had to use sleep() on say greeting and start recording of voice message because noone events are raised (except hangup) for transfered call (event it is in timeout state). As result some greeting part can be recorded with voice mail message (it depends on greeting's length)

Let's review how we put this together. Ideally this will be a jumping off point for our customers, so we should probably try to keep hackyness down to a minimum.
I'm not a huge fan of the mixed BXML and REST commands as it's very confusing. I think we maybe hold off on voicemail until we get our fix rolled in.
I'll take a look at this and see if there is a way to keep the caller ID and get timeouts.


Feat/upgrade winbox to ver 4 0 beta

Description of changes

the main changelog

dark mode
new UI
it is native app now, no more wine.

there are windows, macos, linux flavor

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

My 'pkgs/tools/admin/winbox/default.nixshould be well-formated, I runnix-shell -p nixfmt --command 'nixfmt pkgs/tools/admin/winbox/default.nix'` but nothing changed. Could you help me to address this issue?

My 'pkgs/tools/admin/winbox/default.nix' should be well-formated, I run nix-shell -p nixfmt --command 'nixfmt pkgs/tools/admin/winbox/default.nix' but nothing changed. Could you help me to address this issue?

nix-shell -p nixfmt-rfc-style or don't pass -p when run in the root of your nixpkgs git directory.

@qubitnano  thanks for your advise, format seems great now :pray:

found duplicate MR, just close this one.


[Message] Border should show up on zoom

Steps
Using Firefox Developer Edition 64.0b2 (64 bit) or Firefox 62.0.3 (64 bit)

    Some additional text

Zoom Firefox Developers Edition window out to 90%.
Border disappears and all that remains is the text.
Expected Result
Message box with recolored text, as well as a border.
Actual Result
Message box with recolored text, but no border.
Version
2.4.1
Testcase
https://jsfiddle.net/tu7v0nLm/

https://github.com/tombigel/detect-zoom


Add proper copyright attribution.

I think we need a way of properly assigning copyright, similar to how other open source projects handle this.
I would suggest either an AUTHORS file or IMO even better: listing contributors at the bottom of the LICENSE file.
The copyright in the LICENSE file has already been changed to Copyright (c) 2022 libui-ng authors.
How about adding a list of authors at the bottom of said file?
Copyright (c) 2022 libui-ng authors
....

Authors
=======

First Last

Somebody would have to go through the git log and add the names.
New contributors would add their name themselves (remark in CONTRIBUTING.md needed).

Somebody would have to go through the git log and add the names. New contributors would add their name themselves (remark in CONTRIBUTING.md needed).

I've opened a PR with an AUTHORS.md file here, automatically generated from the git history and sorted by number of contributions. Please everyone review and confirm that your entry in the file is correct before I merge.

While I am not against the suggestion, there are some people who don't care - see projects such as the "unlicence" or whatever the name was. I also just use a nick to provide feedback (which, hopefully, is SOMETIMES useful). All my contributions in general are always "no need to give me credit" and I literally mean that too. (This may be a bit different with a few of my own personal projects I maintain on my own, but when I contribute anything to other projects I literally don't care about getting any credit for it. So my comment here is mostly to also account for people who really don't even need or want to be listed in authors. For those who do, that's ok of course.)
I think "libui-ng authors" is a good summary, and people who want to be listed in AUTHORS.md can say so. IMO I think to many people it is much more important that the spirit of libui is kept alive than bother with "due credit". :D

I fully agree that some authors do not care. That sadly does not mean the law does not!
You even listed "unlicense" as an example. Why does it exist in the first place? Because there are countries where you can not sign things into the public domain. Germany is one such example.

IMO I think to many people it is much more important that the spirit of libui is kept alive than bother with "due credit". :D
I truly hope so. I do hope this is true for all contributors as well. But who knows?

I am especially concerned with people using the software in commercial, closed source projects. Having a proper way of assigning copyright and attribution will give such projects peace of mind. There have been countless cases of people suing for all sorts of supposed license infringement.

I fully agree that some authors do not care. That sadly does not mean the law does not!

Exactly. We have to care. 💯
Users must be free to use libui-ng in both free and proprietary software without legal concerns!
This project isn't very relevant or useful if it is legally encumbered..

The copyright in the LICENSE file has already been changed to Copyright (c) 2022 libui-ng authors.
How about adding a list of authors at the bottom of said file?

I intentionally did not do this, because it is much riskier to have frequent edits to the license file versus an authors file. This is why many projects use Copyright The Project Authors in their licenses like I've done here. This has become even more important in recent years, as automated tools now scan the license files for compliance. Notice how GitHub knows that libui-ng is MIT licensed, and shows that information clearly.. but doesn't recognize the same license for original libui, because the license file had minor edits.

Thinking more long term.. at some point, if this project gets large enough, we'll probably want to adopt a DCO policy. No CLAs ever, of any kind.

The copyright in the LICENSE file has already been changed to Copyright (c) 2022 libui-ng authors.
How about adding a list of authors at the bottom of said file?

I intentionally did not do this, because it is much riskier to have frequent edits to the license file versus an authors file. This is why many projects use Copyright The Project Authors in their licenses like I've done here. This has become even more important in recent years, as automated tools now scan the license files for compliance. Notice how GitHub knows that libui-ng is MIT licensed, and shows that information clearly.. but doesn't recognize the same license for original libui, because the license file had minor edits.

Oh wow. Good to know. I had no idea. I guess there is a reason why projects to place authors in a separate file. I was more thinking of package maintainers, where having everything in one file makes things marginally easier.

Exactly. We have to care. 💯 Users must be free to use libui-ng in both free and proprietary software without legal concerns! This project isn't very relevant or useful if it is legally encumbered..

This is exactly the reason I opened this ticket. Thanks for communicating this more clearly.


Fix delegate and datasource strong refer

Hi! Thanks for releasing v8.0🎉
I probably found the cause of memory leak.
JTACMonthView.calendarDelegate and .calendarDataSource have strong reference.
JTACYearView has weak reference.
weak open var calendarDelegate: JTACYearViewDelegate?
weak open var calendarDataSource: JTACYearViewDataSource? {
    didSet { setupYearViewCalendar() }
}

So, I fixed JTACMonthView to have weak reference.

Thanks.
I missed that


show_bounded_ip

Hey,
just pushed changes to show bounded ip, when --bind-address is set.
This was not so easy as I initially assumed :)
Please review & merge.

lgtm after merge conflict fix, thanks!


Mistake in readme

The lazy installation uses use.
(which is packer but also uses dependendencies?)

Oh thanks for brining this up


CSV download page HTML & CSS

This PR does ...
Changes

Adds /assets dir to /prime-router
Contains HTML & CSS (+USWDS) for the CSV download page

Checklist

[x] Tested locally?
[x] Added new dependencies? SORT OF ... added USWDS SCSS
[x] Updated the docs?
[x] Added a test? N/A
[x] Did you check for sensitive data, and remove any?
[x] Are additional approvals needed for this change?
[x] Are there potential vulnerabilities or licensing issues with any new dependencies introduced?

Fixes

Partially fixes #91

To Be Done

Finish rest of checklists in #91

Ah sorry didn't see this feedback earlier @RickHawesUSDS. This PR includes all of USWDS, which we need to build our final output files. I was thinking @mry-usds would only be using the final files (the index.html, the compressed css, select fonts/images/icons), but we'd still need the whole USWDS package here for future work/collaboration. Following up on this in Slack.

I think many of these files are actually build artifacts or dependencies that shouldn't be committed. Any .css files created from the .scss off USWDS for example should not be in the repo. The developer instructions aren't super clear on this, or at least they weren't clear to me and further complicated because I was using React and Webpack. However, if this is a static page you should just be able to use the built CSS file and assets (fonts, icons, etc). Let me know if you want to pair on this and we can stumble through it together.


Add breadcrumbs to generic model views

This adds breadcrumbs to the generic models index, create, and edit views by extracting them from the snippets views.
I made it so that the last item in the breadcrumbs is a normal text instead of a link, per Ben's (our designer) suggestion and @lb-'s suggestion in https://github.com/wagtail/wagtail/pull/10865#pullrequestreview-1618351538.
I reverted 9ed5b8f07090b1bc50e80c3668e6a06aab105c22 (which I added in #10865, as I thought it'd be more consistent). Ben and I discussed it this morning, and his opinion is that such views are more like a confirmation page that "would ideally be in a dialog instead of a full view", so for now we shouldn't add the breadcrumbs.
I also made it so that with the generic views, the first item in the breadcrumbs is always the admin homepage (dashboard). This was suggested in the Notes section of #8767, and Thibaud suggested this as well. I discussed this with Ben and we decided not to do this for the page breadcrumbs for now, because it may be confusing (one might assume "Home" refers to a Page instance titled "Home").
To test this, you can check out this bakerydemo branch that registers the Country with a ModelViewSet instead of SnippetViewSet: https://github.com/laymonage/bakerydemo/tree/country-modelviewset
Access the "Countries Of Origin" menu, and observe that the index, create, and edit views for this model have breadcrumbs. Also check that for a snippet, the breadcrumbs are still shown on the index, create, edit, history, and usage views.
You'll also see that the views for the following models also have breadcrumbs:

Sites
Locales
Collections (missing in the create view)
Groups (only in the index view)

The missing ones are because the templates have been overridden and haven't been refactored to take the breadcrumbs into account. This will be addressed in #10884.
Please check the following:

[x] Do the tests still pass?[^1]
[x] Does the code comply with the style guide?

[x] Run make lint from the Wagtail root.

[x] For Python changes: Have you added tests to cover the new/fixed behaviour?

[^1]: Development Testing
[^2]: Browser and device support
[^3]: Accessibility Target

Thanks @lb-!

One request (if not already on your radar) can be on the next round of changes - Inspect Snippet view does not seem to contain the last 'title' breadcrumb item for the title of the current page.

I was planning to add InspectView to the ModelViewSet and add the breadcrumbs as part of that. Made some progress on it and I realised we don't yet have a mechanism to show listing buttons on the generic IndexView so there would be no way to access the inspect view yet. I've cherry-picked the commit to this branch, hope that's OK.


BUG - [Expression to the left of comparison must be parenthesized at]

Are you a current Fivetran customer?

Ihor Yedynak, Data Architect, Collegis Education
Describe the bug

I am getting the message below after setup and running model
{{ salesforce_formula_utils.sfdc_formula_view('enrollmentrx_rx_enrollment_opportunity_c') }}
Server error: Database Error in rpc request (from remote system)
Syntax error: Expression to the left of comparison must be parenthesized at [539:42]
Steps to reproduce
Add info to packages.yml file

package: fivetran/salesforce_formula_utils
version: [">=0.4.0", "<0.5.0"]
<see https://github.com/fivetran/dbt_salesforce_formula_utils/releases> for the latest versions

Execute dbt deps
Configure source.yml file
Execute dbt run --models myModel

Watch it fail 👀 haha
Expected behavior

Project variables configuration

copy dbt_project.yml here

Package Version

packages:
  - package: dbt-labs/dbt_utils
    version: 0.7.3

  - package: calogica/dbt_expectations
    version: 0.4.2
    # <see https://github.com/calogica/dbt-expectations/releases/latest> for the latest version tag

  - package: fivetran/salesforce_formula_utils
    version: [">=0.4.0", "<0.5.0"]
    # <see https://github.com/fivetran/dbt_salesforce_formula_utils/releases> for the latest versions

Warehouse

[X] BigQuery
[ ] Redshift
[ ] Snowflake
[ ] Postgres
[ ] Databricks
[ ] Other (provide details below)

Additional context

Screenshots

Please indicate the level of urgency

Are you interested in contributing to this package?

[ ] Yes, I can do this and open a PR for your review.
[ ] Possibly, but I'm not quite sure how to do this. I'd be happy to do a live coding session with someone to get this fixed.
[ ] No, I'd prefer if someone else fixed this.  I don't have the time and/or don't know what the root cause of the problem is.

@yedynaki I believe this issue has been resolved in the latest release of the dbt package. I will close this issue, but please feel free to open the issue again if you see the error persit.


Establish actual passwords for users

Currently the password field is ignored. Actually implement users having passwords to control their accounts. Need password reset feature, which means we need to be able to send emails?
Why? Much of the value of this system (imo) derives from being logged into the system. Here's a view of "all users": http://<IP_ADDRESS>:8080/users Once you're logged into the system you can click the (W)atch / (Y)es / (N)o / (U)nwatch links. Doing so gives users a view of the bills they've clicked that they have interest in, so those bills go to the top of the list of ~1700 bills and they can, at a glance, see the updates / status of the bills they care about. Users can also see the list of bills other users care about. So if I, as a voter, care about the bills the League of Women Voters care about (for example), and their stance on those bills, I can see those bills at a glance. Above the list of all 1700 bills.

Yes, we will want to get user functionality working. Legiscan offers some, but we can augment with more. We might even want to consider "groups" and "group membership"... at some point.
I think for now, we should get the public information further along, then we can follow-up with logins.

@barobba suggested yesterday that we could use something like auth0
https://auth0.com/pricing

Get Auth0 for free with up to 7,000 active users and unlimited logins. No credit card required.

https://auth0.com/docs/quickstart/webapp/golang/01-login


Update README.md

Hi Celab, Mr sigma

Calebbbbbbbbb!!!!!!!!!!!!!

Ski********

I know you that you like Taco Bell

max pls stop

okay


Deap varying with constraints

Currently in gp.base , the _var_and function varys the offsprings using toolbox.mate and toolbox.mutate, which checks for constraint violation through staticLimit.
It seems that the varying is done in a brute force way, i.e. to generate the offsprings first, then check for validity, if invalid use the parents. This makes it possible to have multiple generations of invalid offsprings, depending on the constraints, and render the gp not useful, since it just re evaluates the parent.
Just wondering any thoughts on improving the varying function to be "smarter" and ensure the gp is always productive?
Thanks.

You are correct about that, and this subtlety of our method is noted in our papers. It’s one reason that pure GP does not do well when you stack lots of constraints on top of each other (though DSO’s in situ priors will work just fine).
This is more of a DEAP issue than anything which is why I have not pursued it. A simple solution that could probably be done on the DSO side would be to try multiple attempts at variation before falling back to the parent. Seems like this would be a nice feature.

Is your suggestion for the below
 def _var_and(self, population):

        offspring = [self.toolbox.clone(ind) for ind in population]

        # Apply crossover on the offspring
        for i in range(1, len(offspring), 2):
            if random.random() < self.cxpb:
                offspring[i - 1], offspring[i] = self.toolbox.mate(offspring[i - 1], offspring[i])

                del offspring[i - 1].fitness.values, offspring[i].fitness.values

        # Apply mutation on the offspring
        for i in range(len(offspring)):
            offspring[i], = self.toolbox.mutate(offspring[i])
            del offspring[i].fitness.values

        return offspring

to save the prev_offspring and try the following line N times as long as offspring == prev_offspring?
offspring[i - 1], offspring[i] = self.toolbox.mate(offspring[i - 1], offspring[i])

Also, on the topic of GP generations, so far no convergence "early stop" has been implemented. Is it a good idea to implement an early stop if X% of the offsprings converge to just one individual?
I find that after certain number of rounds, the offspring consist of identical individuals, or with largely the same subtree.
Thanks!

Sorry I missed these replies.
Yes, I think the snippet above could be looped to have some number of trials before giving up. Current behavior would be restored by setting that number of trials to 1. I think you'd need some trial limit though, as in certain cases the likelihood of violating a constraint could be very close to 1.
You could do it with mutations just the same, not just crossover.
Regarding early stopping, this is also something we have not looked into. My educated guess is that, based on the way DSO uses GP, early stopping would not be helpful. DSO runs many short-generation rounds of evolution. Basically, each DSO iteration runs a mini-GP algorithm with a small number (default=20) of generations. (In each one, the starting generation, sampled from the DSO policy, will differ.) Over time, these 20-generation algorithms might start to look similar, but within a 20-something generation algorithm, I would not expect convergence. (If offspring population looks very similar to parents, it could be due to the constraint violation topic which we are also discussing.)


Integration with GoogleChrome's Puppeteer

Hello there, Thanks for making this awesome CodeceptJS project!
I recently noticed that the ChromeDev Team released their own version of automation driver called Puppeteer: https://github.com/GoogleChrome/puppeteer/blob/master/docs/api.md#puppeteer
Is there any way this can be integrated into CodeceptJS as a Helper?

@mrvicadai Yes, it can be integrated to CodeceptJS. But it will take some time. I can't give you any estimates, but I can propose you to add it by yourself and contribute it to framework! If you will start a work for this and you will have any questions, we will be glad to help you!

Hey!
I'm using codecept more and more in production finally at work and would love to see this implemented. I can try to work on this over September, but would need some guidance how to start.
@DavertMik @APshenkin could you point me how to start with this best way? I suppose I would highly inspire myself with Nightmare integration and then fit it to puppeteer? Not promising anything yet, but looks like a lot of fun task to do, would love to pick it :)

@APshenkin Thanks! I'll most likely start working on a POC of this according to your suggestion.

Thanks @mrvicadai and @jploskonka
I think we can start the branch so you could work on this integration. Yeah, Puppeteer looks so nice and so powerful. However, it's not built around webdriver protocol so I suspect it will require lots of durty hooks to make it fit our current API. For instance, its API doesn't locate elements by XPath which we highly use.
However, there is no problem to it. Look into Nightmare helper and lib/clientscripts/nightmare.js. I think you can try to reuse those to locate elements.
So you can start a plain new Helper, use Puppetteer API, and implement _locate method which can take CSS, XPath, or strict locators. Once you know how to locate elements, everything else should be pretty simple!

Hey,
@mrvicadai have you started anything yet? I will have some free time next week and would like to start on that, let me please know if do something so we don't do the same things twice :)

Just create branch https://github.com/Codeception/CodeceptJS/tree/puppeteer
Send pull requests into it

@jploskonka ah not yet; was focusing on using puppeteer directly these days, and familiarizing myself with the internals of CodeceptJS. thanks for the branch @DavertMik !

@mrvicadai any updates? :) Puppeteer is still the thing, you know :)

I started doing something with it, so far I was able to implement amOnPage method and open page :D I'm not too familiar with codecept internals yet so it's taking a lot of time, but hopefully I should be able to post some PR next week.

I started it too :) LOL


how to derefece the proprty of a field

swwe_ref->swwe = we->reset;
sewer_ref field swwe property depends on the we field reset property. I am getting this on print in Python
swwe  ==  <PropRef_reset sw_access.swwe.we->reset at 0x102322060>
Can you please help me to dereference this and extract the name of the reference field and its property name too in python

If a property is a reference to another property, it is represented using the PropertyReference object.
See the documentation: https://systemrdl-compiler.readthedocs.io/en/stable/api/types.html#systemrdl.rdltypes.references.PropertyReference
From there, the name and node members of that class should help get you what you want.

Thanks for sharing PropertyReference
can you please help the property with the custom condition like
swwe_ref->swwe = we->reset == 0;
compiler through an error on that.

Please provide details including code samples and errors. Difficult to help without proper context

This is not supported. The SystemRDL language spec from Accellera does not describe the semantics for how property references are supposed to work in this situation.


Android + iOS: Bump version

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#431  👈 (View in Graphite)
#430
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


delete --host command and message

close https://github.com/rust-lang/cargo/issues/10121
The warning for this command has been around for a long time, and it seems safe to delete it now.
According to Alex's words in the issue, I think he supports deletion. I'm sorry if I misunderstood it and feel free to close it.

r? @Eh2406
(rust-highfive has picked a reviewer for you, use r? to override)

@alexcrichton do you think the warning message we had was good enough given that it had the wrong recommended syntax for certain subcommands?
If so lets merge. If not lets fix the message to be more clear.

@bors: r+
Ok we can do that

:pushpin: Commit cf621fdc94bb40893149ee9e77bdb01b4ae5b092 has been approved by alexcrichton

:hourglass: Testing commit cf621fdc94bb40893149ee9e77bdb01b4ae5b092 with merge c87b986a5cdeae4d1d0e24f05c016ea049945259...

:sunny: Test successful - checks-actions
Approved by: alexcrichton
Pushing c87b986a5cdeae4d1d0e24f05c016ea049945259 to master...

I'm a bit confused here, this only seemed to remove the --host option from the login command.  The host option is still there for publish and search.  Shouldn't that also be removed?


Prevents an error when deleting an overlay

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

@xavijam: can you have a look, please?

Preventing guy! :es:


Do not limit FIDO/U2F usage based on user agent string

Gitea version (or commit ref): 1.7.2
Git version: 2.17.1
Operating system: Linux / Ubuntu 18.04
Database (use [x]):

[x] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Description
After enabling FIDO / U2F for an account on my Gitea server, I am not able to use U2F on Safari, even with the Safari FIDO U2F extension installed and enabled.
If I change my user agent in the developer settings to include Chrome, it works as expected

If the extension is installed/enabled, it uses U2F
If the extension is not installed / disabled, it asks for TOTP

Gitea should not rely on user agent string at all to determine if U2F is available. Checking that window.u2f is non-null should be enough. (for example, it works fine with Github)

What? Don't close.

Unfortunately the U2F support check is part of the vendored library, and looking at the latest version of that library, it still explicitly locks out Safari.
I see two ways this could be made to happen:

Scrap the legacy non-standardized U2F implementations entirely and go straight to standard WebAuthn+CTAP1. The consequences of this are that we end up dropping support for Firefox 47-59, Chrome 41-66, and Opera 42-53 (per caniuse.com). I don't think this will be a huge impact since Firefox 60 ESR has this and the Chromium browsers don't have extended support releases. Chrome<67 accounts for 2.18% of total global browser usage per caniuse.com. This is the forward looking approach, and would be a first step in adopting #6892.

Add a short-circuiting check for the window.u2f API before the call to u2fApi.ensureSupport(). This runs the risk of potentially causing issues because window.u2f is not standard. In fact, we cannot fully replace the vendored library call because Chrome itself doesn't provide window.u2f immediately. There is a U2F API library that can be retrieved from Google that implements window.u2f and could potentially replace the existing vendored library, but imho this is wasted effort given the deprecated status of unstandardized (from a web perspective) U2F implementations in favor of WebAuthn.

I'd be willing to take a stab at this if there is some agreement around one or the other option.

Modify or replace the vendored

As Safari 13.0 on macOS now has build in support for U2F and iOS 13.3 betas also including support, it would be great to make this work.

My work on the WebAuthn conversion PR can be tracked here: #9451

I am 💯 in favor of the migration to WebAuthn. I will close this and track that issue.


Never use deprecated tags
Tags like  are already deprecated and being removed in HTML5. In markdown with align: true, you can use:
::: center

contents

:::

to achieve this.
Attrs and image size support
with attrs: true and imgSize: true,  can be wriiten as:
![微信群](/personal/wechat.png =150x) {style=zoom:70%}

Use relative links in markdown or absolute links when img is in public
You should never use relative path to reference public images as contents in that folder will be copied to dest folder. By doing this, two copies of the same image will be in the final production.
To make better writting, place markdown images next to markdown (e.g.: in a fodler named assets). then use ./assets/image-name.png to reference it.
Do not enable markdown enhance features you do not use
Enabling all features will slow down render speed, increase build memory usage and largen output size.
Do not place raw text in tex equations
In tex when you want to render a text XXX, you should use \text{XXX}

Thans for your sugguestions!

Never use deprecated tags
Tags like  are already deprecated and being removed in HTML5. In markdown with align: true, you can use:
::: center

contents

:::

to achieve this.
Attrs and image size support
with attrs: true and imgSize: true,  can be wriiten as:
![微信群](/personal/wechat.png =150x) {style=zoom:70%}

Use relative links in markdown or absolute links when img is in public
You should never use relative path to reference public images as contents in that folder will be copied to dest folder. By doing this, two copies of the same image will be in the final production.
To make better writting, place markdown images next to markdown (e.g.: in a fodler named assets). then use ./assets/image-name.png to reference it.
Do not enable markdown enhance features you do not use
Enabling all features will slow down render speed, increase build memory usage and largen output size.
Do not place raw text in tex equations
In tex when you want to render a text XXX, you should use \text{XXX}

Thans for your sugguestions!

Also, it's not recommended to install a large site as PWA, as the update time can take longer then expected.

Also, it's not recommended to install a large site as PWA, as the update time can take longer then expected.

👌


Add new error message to console

This PR will help root cause #10207

Coverage decreased (-0.009%) to 33.418% when pulling 8f71a68eeea45cd102be6a7c403d8e2707f174b6 on amir/azureAuth/moreErrors into 57d2ceec9d91d5832278a6f7a7402c49d0e78e9e on master.


⚠ GitLab Server has degraded performance

In 5785c6a, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 11378 ms

Resolved: GitLab Server performance has improved in 297e9ab.


[as2_behaviors_motion] Use goal frame id in motion references

Feature Description
Currently, in both the Go To and Follow Path behaviors, the goal is converted to the "earth" frame before being sent to the controller.
It would be better to send the goal to the controller in the frame of the goal itself to allow for dynamic conversion. However, when evaluating the termination condition, both the state and the goal should be used in the "earth" frame.
Implementation Considerations
Lines where the conversion is done:
https://github.com/aerostack2/aerostack2/blob/eab31b2b24ce08c5c1dca5612fd32b267da0bce5/as2_behaviors/as2_behaviors_motion/go_to_behavior/include/go_to_behavior/go_to_behavior.hpp#L153
https://github.com/aerostack2/aerostack2/blob/eab31b2b24ce08c5c1dca5612fd32b267da0bce5/as2_behaviors/as2_behaviors_motion/follow_path_behavior/include/follow_path_behavior/follow_path_behavior.hpp#L160

The problem is when the frame id is base_link, the behavior will never ends because the reference is unreachable.
I think Aerostack2 should support behaviors in a inertial frame different from base_link.
Some solutions:

Call follow reference behavior and use its feedback for cancel the behavior.
Call behavior modify for update the goal and get the new conversion.
Behavior do the transform continuously if the frame is different from  base_link (not recommended)

For the first two solutions, maybe python interface should help, so the user just configure the call of the behavior and python interface manage it.

Done in action msgs


[CSL 414] Add browse facets and tests

@crgee1 another ping that I changed the method name to getBrowseFacets. Great work on this PR!


[pcre] fix space issue and add mirror (fix #2751)

Escape the include file and I am able to build the package successfully.
In addition, I added the official source as a download mirror.

Thanks! Looks good.


Fix integration

This PR fixes some linting issues and improves the kpt role supporting different working directories and --for-deployment experimental flag. It moves the docker setup permissions into the gce_install_sandbox.sh script

/retest

This adds support for --for-deployment and for a dir name but doesn't yet make use of those, as I read it. Is that correct? But with this change we should be able to get rid if the bash-based kpt calls?

This adds support for --for-deployment and for a dir name but doesn't yet make use of those, as I read it. Is that correct? But with this change we should be able to get rid if the bash-based kpt calls?

That's correct, I was planning to move some instructions from gce_install_sandbox.sh into playbooks/cluster.yml but I need to do more testing, because somehow the repos didn't appear in gitea.

/approve


SocketTimeoutException on websocket

version 2.3.1 and 2.3.2-SNAPSHOT
11:28:12,450 DEBUG NanoWSD$WebSocket:23 - opened
11:28:13,655 DEBUG NanoWSD$WebSocket:59 - Received Frame WS[Text, fin, masked, [2b] bb]
11:28:13,663 DEBUG NanoWSD$WebSocket:66 - Sent Frame WS[Text, fin, unmasked, [2b] bb]
11:28:13,811 DEBUG NanoWSD$WebSocket:59 - Received Frame WS[Text, fin, masked, [2b] bb]
11:28:13,812 DEBUG NanoWSD$WebSocket:66 - Sent Frame WS[Text, fin, unmasked, [2b] bb]
11:28:13,962 DEBUG NanoWSD$WebSocket:59 - Received Frame WS[Text, fin, masked, [2b] bb]
11:28:13,962 DEBUG NanoWSD$WebSocket:66 - Sent Frame WS[Text, fin, unmasked, [2b] bb]
11:28:14,107 DEBUG NanoWSD$WebSocket:59 - Received Frame WS[Text, fin, masked, [2b] bb]
11:28:14,107 DEBUG NanoWSD$WebSocket:66 - Sent Frame WS[Text, fin, unmasked, [2b] bb]
11:28:19,116 DEBUG NanoWSD$WebSocket:53 - exception occured
java.net.SocketTimeoutException: Read timed out
at java.net.SocketInputStream.socketRead0(Native Method)
at java.net.SocketInputStream.socketRead(SocketInputStream.java:116)
at java.net.SocketInputStream.read(SocketInputStream.java:170)
at java.net.SocketInputStream.read(SocketInputStream.java:141)
at java.io.BufferedInputStream.fill(BufferedInputStream.java:246)
at java.io.BufferedInputStream.read(BufferedInputStream.java:265)
at fi.iki.elonen.NanoWSD$WebSocketFrame.read(NanoWSD.java:435)
at fi.iki.elonen.NanoWSD$WebSocket.readWebsocket(NanoWSD.java:248)
at fi.iki.elonen.NanoWSD$WebSocket.access$200(NanoWSD.java:65)
at fi.iki.elonen.NanoWSD$WebSocket$1.send(NanoWSD.java:88)
at fi.iki.elonen.NanoHTTPD$HTTPSession.execute(NanoHTTPD.java:957)
at fi.iki.elonen.NanoHTTPD$ClientHandler.run(NanoHTTPD.java:192)
at java.lang.Thread.run(Thread.java:745)
11:28:19,125 DEBUG NanoWSD$WebSocket:29 - Closed [Self] InternalServerError: Handler terminated without closing the connection.

observing a bit code i thing there is a error in websocket management
when i send a message then it call receive in a loop. It sounds a error. If i send 2 consecutive messages?
i think it might be handled in a separated thread.

public class WebSocketWorker extends Thread {
	private BlockingQueue<WebSocketImpl> iqueue;

	public WebSocketWorker() {
		iqueue = new LinkedBlockingQueue<WebSocketImpl>();
		setName( "WebSocketWorker-" + getId() );
		setUncaughtExceptionHandler( new UncaughtExceptionHandler() {
			@Override
			public void uncaughtException( Thread t, Throwable e ) {
				getDefaultUncaughtExceptionHandler().uncaughtException( t, e );
			}
		} );
	}

	public void put( WebSocketImpl ws ) throws InterruptedException {
		iqueue.put( ws );
	}

	@Override
	public void run() {
		WebSocketImpl ws = null;
		try {
			while ( true ) {
				ByteBuffer buf = null;
				ws = iqueue.take();
				buf = ws.inQueue.poll();
				assert ( buf != null );
				try {
					ws.decode( buf );
				} catch(Exception e){
					System.err.println("Error while reading from remote connection: " + e);
				}

				finally {
					pushBuffer( buf );
				}
			}
		} catch ( InterruptedException e ) {
		} catch ( RuntimeException e ) {
			handleFatal( ws, e );
		}
	}
}

error seams be here
@Override
public void send(OutputStream out) {
WebSocket.this.out = out;
WebSocket.this.state = State.CONNECTING;
super.send(out);
WebSocket.this.state = State.OPEN;
WebSocket.this.onOpen();
readWebsocket();
}

There's only one loop there and it spends most of its time locked by a blocking input method.
That loop is necessary, it's what makes it possible to read more than one packet on each tcp socket.
Your websocket is timing out because you're not pinging the socket, thus whenever you spend more than 10 seconds (default socket timeout) without sending packets to the server, the server socket blocking read method unblocks and times out.

it may be pinging behind your back.
As for closed connections, if you don't use the proper closing mechanisms it's only natural that the other side of the socket throws an hissy fit.

I fixed bug with onClose event.
The lifecicle is correct now but timeout error is present also using javascript.
i tried also in javascript
var i=0;
var echo_service = new WebSocket('ws://localhost:90/aa');
echo_service.onmessage = function(event){
console.log("ricevuto :"+event.data) ;

}
var sender=function(){
  i++;
  if (i<10) {
  echo_service.send('test '+i);
  setTimeout(sender,1000);
  }

  };
echo_service.onopen = function(){
  console.log("connessione effettuata") ;
  sender();
}
echo_service.onclose = function(){
  console.log("connessione chiusa");
}
echo_service.onerror = function(){
  console.log("errore nella connessione");
}

in tomcat i found
"When using the WebSocket client to connect to server endpoints, the timeout for IO operations while establishing the connection is controlled by the userProperties of the provided javax.websocket.ClientEndpointConfig. The property is org.apache.tomcat.websocket.IO_TIMEOUT_MS and is the timeout as a String in milliseconds. The default is 5000 (5 seconds)."
This timeout is just in handshake phase. Then timeout=0.

i m thinking to modify serve function in
serve(Socket socket, IHTTPSession session)
so NanoWSD can reset socket timeout when handshake phase is completed

If you're using tomcat's websockets, then that's not a NanoWSD issue.
But it seems to me like you're simply getting into stuff that are way over your head, so I'm going to mark this as a question until we got you headed in a good direction or figure there's an actual issue with our code...

No i used nanowsd. I read tomcat specification for understanding better the websocket behaviour.

 At least in our implementation, I'm not sure if we can turn off that timeout, but if we do it's probably a bad idea anyways.
The correct way to handle that is to ping. When a side stops receiving pings or pongs, it should assume the other side of the socket died and terminate.

no browsers can ping. Who can use your implementation?  Anyway i already
changed a lot of thing, fixed these problems and others. You can continue
to leave so. Thanks anyway
2016-10-02 4:27 GMT+02:00 LordFokas<EMAIL_ADDRESS>
You still have to ping sockets, or they die. At least in our
implementation, I'm not sure if we can turn off that timeout, but if we do
it's probably a bad idea anyways.
The correct way to handle that is to ping. When a side stops receiving
pings or pongs, it should assume the other side of the socket died and
terminate.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NanoHttpd/nanohttpd/issues/386#issuecomment-250949730,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACZspNkBYAArOO-YmCyx_xaYEK7eAnJ7ks5qvxaTgaJpZM4KLtpo
.

You can ping from browsers, but it's easier to ping from the server and have the browser automatically pong.

Same thing here.. Simple FIX.
If you follow the class trail you end up at Line 165 of NanoHTTPD..
public static final int SOCKET_READ_TIMEOUT = 5000;
..Just change that.
OR.. better.. If you dig a little deeper you'll notice
public void start(final int timeout) throws IOException {
start(timeout, true);
}
And just the plain start() is called in the echosocket.. just switch it for the one where you specify a timeout.
It works.
Big Up LordFokas for sharing this great little project with all of us.. :)


Animation and AnimationComponent must ensure stepTime is informed

Is the a value for stepTime ins't informed, a NullPointerException can happen, we must add a @required to ensure that it is informed upon creation.

Since required is removed on compilation, an assert would coimplete it with a more explicit error in debug runtime.

In this case, I vote for both!
It is very user friendly to receive an handled error in compilation time instead of runtime.

Yep, me too. Thats why I wrote complete it.

Fair enough!

I'm ok with both, sincerely I think we don't necessarily need to add asserts to all our @required, if we had the annotation the user will know already before even running the code. But I'm ok with it. We should def. add required were needed

Fixed on v1


feat: snaps modal

Description

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #5166

PR #5167

PR #5169   👈

This comment was auto-generated by Graphite.

Back to draft as this https://github.com/shapeshift/web/pull/5169/files#diff-642b012440aeafd61512683e8b249ef64289ae5a0e38ff6a5c0143c4c3b23484 looks like it breaks things in swapper, including with the flag off


can't reproduce results with the model you provide

Hi,
I run the model you provide in folder DTN_SEED#5 and get accuracy only around 71%. Ps, I run 1*600 tasks when testing. But it should around 77% according your report.

Can you provide your log?

Can you provide your log?

load train dataset
48000
load test dataset
12000
==> Resuming from generator checkpoint..
test: 100 loss: 0.7847099539637565 acc: 71.54666851043702
test: 200 loss: 0.780451248139143 acc: 71.58000152587891
test: 300 loss: 0.7874181261658668 acc: 70.90666829427083
test: 400 loss: 0.7915166358649731 acc: 70.55000170707703
test: 500 loss: 0.7918601664304733 acc: 70.49600180053712
test: 600 loss: 0.7952163175741831 acc: 70.41777956644694
0 0.7952163175741831 70.41777956644694 0.6697213299215876

Can you provide your log?

load train dataset
48000
load test dataset
12000
==> Resuming from generator checkpoint..
test: 100 loss: 0.7847099539637565 acc: 71.54666851043702
test: 200 loss: 0.780451248139143 acc: 71.58000152587891
test: 300 loss: 0.7874181261658668 acc: 70.90666829427083
test: 400 loss: 0.7915166358649731 acc: 70.55000170707703
test: 500 loss: 0.7918601664304733 acc: 70.49600180053712
test: 600 loss: 0.7952163175741831 acc: 70.41777956644694
0 0.7952163175741831 70.41777956644694 0.6697213299215876

I run on my machine, it seems normal.

Please check your code & dataset. @ZRJMoon


FilePicker v8 with Sharepoint accounts

Hello,
I created an app that uses JS FilePicker v8. With personal accounts everything works as expected. But when I try to sign in to my work account (@.onmicrosoft.com), I get message "That Microsoft account doesn't exist. Enter a different account or [get a new one]".
If I replace the authority URL https://login.microsoftonline.com/consumers with https://login.microsoftonline.com/common, I can sign in both to my personal and work accounts.
But when I try to open a picker window with my personal account, I get error "AADSTS70011: The provided value for the input parameter 'scope' is not valid. The scope 'onedrive.readwrite openid profile' is not configured for this tenant.".
How to make one JS FilePicker for all users both with personal or corporate accounts?
Thanks.

You can't target personal and business accounts within the same picker instance, meaning you can't browse files across two accounts at the same time.
When loading in business the base URLs need to reference the ODB/SharePoint paths, and for consumer they should point to the consumer paths. As well you'd need to request the right scopes OneDrive.ReadWrite doesn't exist for business drives, you can use Files.ReadWrite for both I believe.

You can't target personal and business accounts within the same picker instance, meaning you can't browse files across two accounts at the same time.
When loading in business the base URLs need to reference the ODB/SharePoint paths, and for consumer they should point to the consumer paths. As well you'd need to request the right scopes OneDrive.ReadWrite doesn't exist for business drives, you can use Files.ReadWrite for both I believe.

Hello Patrick,
Thank you for answering. But your answer is not relevant. I do not want to browse files across multiple accounts. I just test different types of accounts in different browsers.
Here is a text from https://devblogs.microsoft.com/microsoft365dev/onedrive-file-picker-v8-now-generally-available/
"The OneDrive File Picker lets you connect your custom web apps to content stored in OneDrive (both the commercial and business versions) and SharePoint."
I have a web app. It has many visitors. They store their files in cloud storages (Dropbox, Google Drive, OneDrive). And want to choose and share these files. This is why I use Picker.
Now, lets ignore Dropbox and Google user, and consider Microsoft users only. Some of them have personal accounts and others have SharePoint accounts. How should I configure OneDrive Picker so that both categories (with OneDrive accounts and SharePoint account) could use Picker for choosing files?
Thanks.

Hey @AlexMyU can you elaborate on what you mean by "SharePoint Accounts" and "OneDrive Accounts"? OneDrive and SharePoint use the same Microsoft authentication.
Patrick was not referring to multiple accounts for the same user, he was referencing different login flows depending on if the user has a Microsoft account through their organization or has a personal Microsoft account.

Hey @JCrew0 ,
Can you please check my initial post? It describes what I want to achieve and what problems I faced.
I meant the following:

SharePoint Accounts - account that I got from my company (@.onmicrosoft.com)
OneDrive Accounts - my personal account (***@hotmail.com).

The goal is to have one Picker on a website and allow many different visitors to use it to select files from their accounts, regardless of account type.

Hey @AlexMyU, I think Patrick's response should still stand. When you use the personal account, you should load the instance of the picker with consumer urls, whereas when you use the business account, you should load the instance of the ODB/SharePoint urls.
Essentially, you'll have to add logic to recognize which account-type is being used and load the picker accordingly.
While we used to have a JavaScript wrapper that would do that logic for you in v7.2, it's no longer possible in v8 given some new security protocols.
Hopefully that helps explain and let me know if you have any other questions!


Differential pricing for user/group

Hi Serge
Awesome project! Has differential pricing possible where groups of user may pay different price/cost on same charging station?
Thanks!!!

Let me answer;
There is no such feature in the project.
You can make general pricing, pricing by site, pricing by charging station.
You can also set restrictions such as days and hours in price lists.


Add Support for Atari Jaguar

@sselph  I would like to add support for the Atari Jaguar. This system is currently supported by RetroPie.
The file extension is .j64

Added what I could match

Perfect 100% Match for No-Intro!  Thank you @sselph you're the best!


API review feedback fixes for RuleManager Client

Description
Addressing comments from the API review.

Removed constructor overload for CreateRule(RuleName, RuleFilter) - to be consistent with admin client and CreateRuleOptions has the necessary setter method anyways
Renamed getRules() method to listRules()  in both sync and async client
Added missing annotation on builder for the sync client

All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

Can we update the changelog since it is a breaking change for API?

This isn't a breaking change because we never released this feature,  so we should be good here.


B-21458 int2

B-21458
Summary
Agility: B-21458
When the orders type is retirement OR separation, the email should state the destination address of their first shipment instead of Duty Station.
For PPMs, we need to use the Address linked to the PPM.
Previous Int PR: #14099
Update: Other emails needed updating for PPM addresses. I also moved the formatting into Address.go to keep it consistent.
Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

[ ] Has the branch been pulled in and checked out?
[ ] Have the BL acceptance criteria been met for this change?
[ ] Was the CircleCI build successful?
[ ] Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test
NOTE: I haven't been able to test the emails locally, but I've tested the previous PRs changes for the "Complete your PPM" email in integrationTesting
Given I am a customer
When I create a PPM for a retirement or separation with an expected departure date at least 14 days in the past
Then I will receive a "Thank you for submitting your move details" email showing the actual destination address (instead of HOS/ HOR/PLEAD)
Given the above
When a TOO approves the PPM
Then I will receive a "Your counselor has approved your move details" email showing the actual destination address (instead of HOS/ HOR/PLEAD)
And the next morning I will receive a "Complete your Personally Procured Move (PPM)" email showing the actual destination address (instead of HOS/ HOR/PLEAD)
Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
[ ] This change meets the standards for Section 508 compliance.

Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys.
[ ] Have been communicated to #g-database.
[ ] Secure migrations have been tested following the instructions in our docs.

Screenshots

Emails do not seem to have the destination street address for PPM, only the city, state zip

Also, to run locally, run this:
EMAIL_BACKEND=ses aws-vault exec transcom-gov-dev -- make server_run

Warnings

:warning:

New files have been created under one of the legacy directories
(src/shared or src/scenes). Please relocate them according to the file structure described here.
View the frontend file org ADR for more information

:warning:

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?
View the frontend file org ADR for more information

  Generated by :no_entry_sign: dangerJS against b23bd2294970ecbff3365efd35301c43831c0118

Test coverage on server failed.
Last run: Wed 04 Dec 2024 08:56:49 PM UTC
Refer to this report to see coverage details for the server app.
Documentation for test coverage can be found at this link.

Emails updated, ready for review.

Changes look good, but am having issues testing locally. I've been able to create PPMs in the past, but am having a DTOD error today, so I will take your word for it.
We are unable to calculate your distance. It may be that you have entered an invalid ZIP Code. Please check your ZIP Code to ensure it was entered correctly and is not a PO Box.

Also just a heads up but the AC in this PR is NOT the AC in the BL provided. Might want to add what you've put in here to Agility.

Also just a heads up but the AC in this PR is NOT the AC in the BL provided. Might want to add what you've put in here to Agility.

Yes, thanks. I've added the AC now.

Test coverage on server failed.
Last run: Wed 11 Dec 2024 08:27:30 PM UTC
Refer to this report to see coverage details for the server app.
Documentation for test coverage can be found at this link.

I don't think the test coverage decrease is my doing. I see that it's happened to the integrationTesting branch itself: https://app.circleci.com/pipelines/github/transcom/mymove/82168/workflows/e50ceb95-c8c4-4e91-a1d8-8dac0c3aa666/jobs/1462567

Test coverage on server failed.
Last run: Fri 13 Dec 2024 12:03:22 AM UTC
Refer to this report to see coverage details for the server app.
Documentation for test coverage can be found at this link.


add missing stuff to changelog

adds everything not added to the changelog since march of 2018

This is a fairly uncontroversial PR, just adding things to the changelog that weren't added. If no objections by tomorrow afternoon, I'll just merge this.

Actually, I'm going to do a release of streaming, so I need to merge this now.


Fix typo in ListenerInterface.rst

typo fix

Admin, can CI be enabled?

Sorry robotci I speek only to humans.

Thanks, good catch! Think it should read "as a list", though.

Fixed this in 5597602 with as a list.


[Feature request] Play attach mp3/audio files

Hi,
Many language learning sites provide RSS with link to mp3/audio. It would be wonderful that Vienna support this.
PS: Also, I am new to Xcode but willing to help. Please tell me some starting points to do it
edit: play mp3 inside vienna

Vienna is able to read enclosures in RSS 2 and in Atom feeds.
I'll have to check if mod_enclosure for RSS 1.0 is also supported.
From my point of view, the real problem is that too many sites tend to hide their RSS feeds. But they do provide them to Apple Podcasts, Spotify and so on !

@barijaona thanks, i just update my description to make clear. I mean that vienna is able to play mp3 inside itself. No need to download and play later.
Bests


Support for empty blocks

Please ensure your pull request adheres to the following guidelines:

[x] make sure to link the related issues in this description
[x] when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues
Fixes #366
Thanks for contributing!

@mhaack - will you please have a look at this pr ?

:tada: This PR is included in version 2.5.0 :tada:
The release is available on:

v2.5.0
v2.5.0
GitHub release

Your semantic-release bot :package::rocket:


🐛 [Bug]: tiny-grid中右键菜单点击事件无效

Environment
chrome
Version
latest
Version
latest
Link to minimal reproduction
as title
Step to reproduce

右键菜单点击事件无效， 附件为 tinygrid的配置及测试页面的schema
schema.json
TinyGrid.json
What is expected
No response
What is actually happening
No response
What is your project name
TinyEngine
Any additional comments (optional)
No response

事件会触发，但会多弹出一个空白页。


[BUG] - Transaction failed verification on ArIO and ANT write interaction APIs

Describe the bug
Write interactions (e.g.transfer) are failing verification from arweave nodes.
To Reproduce
const nodeSigner = new ArweaveSigner(wallet);

// read and write client that has access to all APIs
const ario = ArIO.init({
  signer: nodeSigner,
  contractTxId: testnetContractTxId,
});

const transfer = await ario.transfer({
  target: arweaveWallet,
  qty: 1000, // 1000 IO tokens
});

Error message from warp:
2024-04-25T18:40:41.856Z ERROR [HandlerBasedContract] Error while posting transaction [
  {
    status: 400,
    statusText: 'Transaction verification failed.',
    data: { error: 'Transaction verification failed.' }
  }
]

Expected behavior
All interactions that submit interactions work as expected.
Environment (please complete the following information):

Environment: node
SDK Version - v1.0.1
Node Version - v18.17.1

fixed in v1.0.3


openjdk-jdk mirror is out of date

I find this mirror of http://hg.openjdk.java.net/jdk/jdk very useful for searching and linking to JDK code. However, it seems like the mirror was last updated Sept 3rd. Is that just some issue in the mirroring process?

Yes, it's a git-hg bug for sure

this is resolved, last update in the repo was 12 hours ago https://github.com/adoptopenjdk/openjdk-jdk


Pin library versions in requirements.txt

Hi @OrkoHunter I think it's necessary to do because some day app can not run as expected in case of some backwards incompatibles

This seems easy enough, submit a PR.


Invalid mute status

There's an invalid hex status code for the unavailable option in the MUTE class. Nice and easy fix.
samsung_mdc/commands.py
Current:
NONE = 0x255  # Unavailable
Correct:
NONE = 0xFF  # Unavailable
This will prevent the following exception when querying devices that have no audio, e.g.: SBB-CX4BPES
raise ve_exc
ValueError: 255 is not a valid MUTE.MUTE_STATE

Thanks, fixed and released in new version!

Thank you!


improve document page meta section

hide create project issue URL
adjust the spacing of page-meta and page-TOC

by the way. it's a safe change that comment github_project_repo in config.toml
https://github.com/open-telemetry/opentelemetry.io/pull/354/files#diff-28043ff911f28a5cb5742f7638363546311225a63eabc365af5356c70d4deb77R87

before the change, click Create project issue  on document page will go to https://github.com/open-telemetry/issues/new, always 404
k8s website did not open this feature

by the way. it's a safe change that comment github_project_repo in config.toml
https://github.com/open-telemetry/opentelemetry.io/pull/354/files#diff-28043ff911f28a5cb5742f7638363546311225a63eabc365af5356c70d4deb77R87

before the change, click Create project issue  on document page will go to https://github.com/open-telemetry/issues/new, always 404
k8s website did not open this feature


Bug

Hello,
Not sure if this is due to chatGPT or something on your end, but I see this message no matter what now (uninstalled plugin, uninstalled flow, downloaded flow again, downloaded plugin again, rebooted)

Also I have grabbed new API keys daily to see if that might have been the issue, still didnt work.

Hi @almacd3571, looking at the error, it looks like something is off with your provided payment options. Could you go here to see if you can resolve the issue?

I have the same issue with my free trial account, does it require upgrading to a paid plan ?

@MichielvanBeers I think its a bug within openAI as I have the free account, AND they wont allow me to upgrade (I guess they have closed the upgrades for now) I was wondering if anyone else was seeing this error. I wonder if @AnaelBonnafous  is correct and we need paid accounts?

I have purchased the paid version of CHATgpt, now unable to use either 3.5 or gpt4 (even though I have access on the site itself)

@almacd3571, ChatGPT unfortunately doesn't give you access to the gpt-4 API. You can join the waitlist for access to the API here

Marking this issue as stale as there hasn't been any activity on this in a while. Please reopen if you need additional help. Thanks for your contribution!


not able to setup project getting some error

Unpacking xauth (1:1.0.9-1ubuntu2) ...
Selecting previously unselected package curl.
Preparing to unpack .../curl_7.47.0-1ubuntu2.13_amd64.deb ...
Unpacking curl (7.47.0-1ubuntu2.13) ...
Selecting previously unselected package liberror-perl.
Preparing to unpack .../liberror-perl_0.17-1.2_all.deb ...
Unpacking liberror-perl (0.17-1.2) ...
Selecting previously unselected package git-man.
Preparing to unpack .../git-man_1%3a2.7.4-0ubuntu1.6_all.deb ...
Unpacking git-man (1:2.7.4-0ubuntu1.6) ...
Selecting previously unselected package git.
Preparing to unpack .../git_1%3a2.7.4-0ubuntu1.6_amd64.deb ...
Unpacking git (1:2.7.4-0ubuntu1.6) ...
Selecting previously unselected package ncurses-term.
Preparing to unpack .../ncurses-term_6.0+20160213-1ubuntu1_all.deb ...
Unpacking ncurses-term (6.0+20160213-1ubuntu1) ...
Selecting previously unselected package python3-chardet.
Preparing to unpack .../python3-chardet_2.3.0-2_all.deb ...
Unpacking python3-chardet (2.3.0-2) ...
Selecting previously unselected package python3-six.
Preparing to unpack .../python3-six_1.10.0-3_all.deb ...
Unpacking python3-six (1.10.0-3) ...
Selecting previously unselected package python3-urllib3.
Preparing to unpack .../python3-urllib3_1.13.1-2ubuntu<IP_ADDRESS>_all.deb ...
Unpacking python3-urllib3 (1.13.1-2ubuntu<IP_ADDRESS>) ...
Selecting previously unselected package python3-requests.
Preparing to unpack .../python3-requests_2.9.1-3ubuntu0.1_all.deb ...
Unpacking python3-requests (2.9.1-3ubuntu0.1) ...
Selecting previously unselected package zip.
Preparing to unpack .../archives/zip_3.0-11_amd64.deb ...
Unpacking zip (3.0-11) ...
Selecting previously unselected package ssh-import-id.
Preparing to unpack .../ssh-import-id_5.5-0ubuntu1_all.deb ...
Unpacking ssh-import-id (5.5-0ubuntu1) ...
Processing triggers for man-db (2.7.5-1) ...
Processing triggers for systemd (229-4ubuntu21.21) ...
Processing triggers for mime-support (3.59ubuntu1) ...
Processing triggers for libc-bin (2.23-0ubuntu11) ...
Setting up libpopt0:amd64 (1.16-10) ...
Setting up openssh-client (1:7.2p2-4ubuntu2.8) ...
Setting up openssh-sftp-server (1:7.2p2-4ubuntu2.8) ...
Setting up openssh-server (1:7.2p2-4ubuntu2.8) ...
debconf: unable to initialize frontend: Dialog
debconf: (No usable dialog-like program is installed, so the dialog based frontend cannot be used. at /usr/share/perl5/Debconf/FrontEnd/Dialog.pm line 76.)
debconf: falling back to frontend: Readline
Creating SSH2 RSA key; this may take some time ...
2048 SHA256:jNYqx53U/VPYf29JqHw3LdyE8TxxEhshMiTS0OejUGU root@310d84542b8e (RSA)
Creating SSH2 DSA key; this may take some time ...
1024 SHA256:/zJHWbxZKB94j2MQtPj6hFLLTBw8b4CqLhUQ0lvOAW0 root@310d84542b8e (DSA)
Creating SSH2 ECDSA key; this may take some time ...
256 SHA256:84fZ9g3/fAfDS5YNEaySZ4Hh9wHuft9ZDAjP4x4/kJ4 root@310d84542b8e (ECDSA)
Creating SSH2 ED25519 key; this may take some time ...
256 SHA256:BFGo38QV1aTOZ7FF/l9UVZBAqvfayCRGaj7u9KFi190 root@310d84542b8e (ED25519)
invoke-rc.d: could not determine current runlevel
invoke-rc.d: policy-rc.d denied execution of start.
Setting up ssh (1:7.2p2-4ubuntu2.8) ...
Setting up less (481-2.1ubuntu0.2) ...
debconf: unable to initialize frontend: Dialog
debconf: (No usable dialog-like program is installed, so the dialog based frontend cannot be used. at /usr/share/perl5/Debconf/FrontEnd/Dialog.pm line 76.)
debconf: falling back to frontend: Readline
Setting up netcat-openbsd (1.105-7ubuntu1) ...
update-alternatives: using /bin/nc.openbsd to provide /bin/nc (nc) in auto mode
Setting up libxmuu1:amd64 (2:1.1.2-2) ...
Setting up rsync (3.1.1-3ubuntu1.2) ...
invoke-rc.d: could not determine current runlevel
invoke-rc.d: policy-rc.d denied execution of restart.
Setting up xauth (1:1.0.9-1ubuntu2) ...
Setting up curl (7.47.0-1ubuntu2.13) ...
Setting up liberror-perl (0.17-1.2) ...
Setting up git-man (1:2.7.4-0ubuntu1.6) ...
Setting up git (1:2.7.4-0ubuntu1.6) ...
Setting up ncurses-term (6.0+20160213-1ubuntu1) ...
Setting up python3-chardet (2.3.0-2) ...
Setting up python3-six (1.10.0-3) ...
Setting up python3-urllib3 (1.13.1-2ubuntu<IP_ADDRESS>) ...
Setting up python3-requests (2.9.1-3ubuntu0.1) ...
Setting up zip (3.0-11) ...
Setting up ssh-import-id (5.5-0ubuntu1) ...
Processing triggers for libc-bin (2.23-0ubuntu11) ...
Processing triggers for systemd (229-4ubuntu21.21) ...
Detected operating system as Ubuntu/xenial.
Checking for curl...
Detected curl...
Checking for gpg...
Detected gpg...
Running apt-get update... done.
Installing apt-transport-https... done.
Installing /etc/apt/sources.list.d/github_git-lfs.list...done.
Importing packagecloud gpg key... done.
Running apt-get update... done.
The repository is setup! You can now install packages.
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package git-lfs
ERROR: Service 'cvat' failed to build: The command '/bin/sh -c apt-get update &&     apt-get install -y ssh netcat-openbsd git curl zip  &&     wget -qO /dev/stdout https://packagecloud.io/install/repositories/github/git-lfs/script.deb.sh | bash &&     apt-get install -y git-lfs &&     git lfs install &&     rm -rf /var/lib/apt/lists/ &&     if [ -z ${socks_proxy} ]; then         echo export "GIT_SSH_COMMAND="ssh -o StrictHostKeyChecking=no -o ConnectTimeout=30"" >> ${HOME}/.bashrc;     else         echo export "GIT_SSH_COMMAND="ssh -o StrictHostKeyChecking=no -o ConnectTimeout=30 -o ProxyCommand='nc -X 5 -x ${socks_proxy} %h %p'"" >> ${HOME}/.bashrc;     fi' returned a non-zero code: 100*

starting i faced proxy i come over it by setting proxy,,,,,,.docker----config.json file

@RajasekharKadasani , you need to ask the question on our gitter channel. It was answered many times. I will close the issue. I don't think that it is a bug in CVAT. Probably it is a gab in documentation but I don't feel that I can cover the topic completely. Internally we run CVAT behind a proxy without any issues. Of course you need to provide -build-arg http_proxy=... for your docker-compose command.


Sc-7511 : disable reset button for default value

Scope of changes
Sc-7511 : disable reset button for default value
Type of change

[ ] bug fix
[ ] new feature
[ ] documentation
[x] other (refact)

Acceptance criteria

Author checklist

[ ] I have manually tested the change and/or added automation in the form of unit tests or integration tests
[ ]  I have updated the dependencies list
[ ]  I have recompiled and included new protocol buffers to reflect changes I made
[ ]  I have added new test fixtures as needed to support added tests
[x]   Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
[x]  I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

[ ] Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

Codecov Report

Merging #683 (dbf699b) into main (dcdc91a) will decrease coverage by 7.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
- Coverage   45.40%   38.08%   -7.32%
==========================================
  Files         575      155     -420
  Lines       17090     2434   -14656
  Branches     1245      618     -627
==========================================
- Hits         7759      927    -6832
+ Misses       8151     1330    -6821
+ Partials     1180      177    -1003

Impacted Files
Coverage Δ

web/gds-user-ui/src/application/routes/routes.ts

web/gds-user-ui/src/application/store/index.ts

...user-ui/src/application/store/selectors/stepper.ts

...gds-user-ui/src/application/store/stepper.slice.ts

...b/gds-user-ui/src/components/AddressForm/index.tsx

.../gds-user-ui/src/components/ReviewSubmit/index.tsx

...b/gds-user-ui/src/components/Sidebar/MobileNav.tsx

web/gds-user-ui/src/hooks/useCertificateStepper.ts

...b/gds-user-ui/src/modules/auth/login/user.slice.ts

web/gds-user-ui/src/modules/auth/logout/index.tsx

... and 410 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcdc91a...dbf699b. Read the comment docs.


Add option to suppress reload if tab is going inactive

Issue: We want to display a stream on client/player side. While everything works fine while the tab is in the foreground, there is reload triggered on the page if I put the tab into the background. Therefore, the stream is aborted and could not be continued.
The behavior was different in soundworks v2 and I wonder if there is an option to suppress the "reload on inactive tab" action. I guess this is part of the feature how the currently active clients are handled and therefore intended.

Hi, yep there is an option, just replace the following in the index.js of the concerned client
// initQoS(client);
initQoS(client, { visibilityChange: false });

Just tested it - works like charm, thanks :)


Hermes infinite retry clear packet

Summary of Bug
https://github.com/informalsystems/ibc-rs/blob/master/relayer/src/worker/packet.rs#L120
 spawn_background_task(span, Some(Duration::from_millis(200)), move || {
        if let Ok(cmd) = cmd_rx.try_recv() {
            // infinity retry
            retry_with_index(retry_strategy::worker_stubborn_strategy(), |index| {
                handle_packet_cmd(
                    &mut is_first_run,
                    &link.lock().unwrap(),
                    clear_on_start,
                    clear_interval,
                    &path,
                    cmd.clone(),
                    index,
                )
            })
            .map_err(|e| TaskError::Fatal(RunError::retry(e)))?;
        }

        Ok(Next::Continue)
    })

Hermes will always clear the packet at a fixed height. When Hermes cannot build the packet proof at this height (the chain has been prune), Hermes will fall into an endless loop

Version
hermes 0.14.0

Steps to Reproduce

Acceptance Criteria

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate milestone (priority) applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

How does this problem manifest more precisely? It is it the case that Hermes stops operating on "live" packets and is stubbornly retrying "old" packets? Or can you explain the issue in more detail?
Note: The infinite retry approach was added as a requested feature from some operators (https://github.com/informalsystems/ibc-rs/issues/1290). I can see how this can be problematic when the chain data was pruned, so thank you for bringing this up!

when Hermes executes clear packet, it will take too long in the following cases:

If there is no packet to relay on the long-term chain, it will take a long time to build the update client next time(verify light client to target height)
an error was encountered during the clear packet process
rpc delay

when clear-height + pruning-keep-recent > latest height, the packet of this height will never be cleared. He cannot build the packet proof because the state  has been prune
conclusion：
when hermes cannot build proof, hermes should stop retrying, because retrying at this height will never succeed.

I think Hermes should improve the performance of clear packet instead of relying on "real-time relay". You can check my suggestions under this issue

conclusion：
when hermes cannot build proof, hermes should stop retrying, because retrying at this height will never succeed.

This is a very interesting scenario I'd like to reproduce and understand. Is there a way to reproduce it?

I think Hermes should improve the performance of clean packet instead of relying on "real-time relay". You can check my suggestions under this https://github.com/informalsystems/ibc-rs/issues/2087

Yes, we got the same feedback from other operators, and will proceed this way. The next release will include a fix for 2087, including your suggestions.

结论：
当hermes无法建立证明时，hermes应该停止重试，因为在这个高度重试永远不会成功。

这是一个非常有趣的场景，我想重现和理解。有没有办法重现它？

我认为 Hermes 应该提高 clean packet 的性能，而不是依赖“实时中继”。您可以在#2087下查看我的建议

是的，我们从其他运营商那里得到了相同的反馈，并将继续这样做。下一个版本将包括对 2087 的修复，包括您的建议。

Thank you for your reply！
Next, I will use the simplest way to reproduce this scene！

In order to reproduce this scenario (clean height + pruning keep recent > latest height), we first adjust the startup parameters of GAIA.
https://github.com/informalsystems/ibc-rs/blob/master/scripts/one-chain#L149

# before
$BINARY --home $CHAIN_DIR/$CHAIN_ID start --pruning=nothing --grpc.address="<IP_ADDRESS>:$GRPC_PORT" --log_level error > $CHAIN_DIR/$CHAIN_ID.log 2>&1 &

# after
$BINARY --home $CHAIN_DIR/$CHAIN_ID start --pruning=everything --grpc.address="<IP_ADDRESS>:$GRPC_PORT" --log_level error > $CHAIN_DIR/$CHAIN_ID.log 2>&1 &

setup two chains

./scripts/dev-env ~/.hermes/config.toml ibc-0 ibc-1

create channel

# note: this command may not work because the version I am using is not the latest version. The command has been changed in the latest version
hermes create channel --port-a transfer --port-b transfer ibc-0 --chain-b ibc-1 --new-client-connection

start two process to send ibc transfer tx

watch -n 1 hermes tx raw ft-transfer ibc-1 ibc-0 transfer channel-0 1 --key user2 --receiver cosmos1dgy29chm8nmt4aplxuwfl9dvzen8aunn4nq7z9 -n 200 -t 10000

watch -n 1 hermes tx raw ft-transfer ibc-0 ibc-1 transfer channel-0 1 --key user2 --receiver cosmos1dgy29chm8nmt4aplxuwfl9dvzen8aunn4nq7z9 -n 200 -t 10000

start Hermes and wait for the error to occur

hermes start

You will see an error message like this
2022-04-29T10:44:59.255498Z ERROR ThreadId(74) packet_cmd{src_chain=ibc-0 src_port=transfer src_channel=channel-0 dst_chain=ibc-1}: will retry: handling command encountered error: failed to construct packet proofs for chain ibc-0: ABCI query returned an error: AbciQuery { code: Err(18), log: Log("proof is unexpectedly empty; ensure height has not been pruned: invalid request"), info: "", index: 0, key: [], value: [], proof: None, height: block::Height(417), codespace: "sdk" } path=packet::channel-0/transfer:ibc-0->ibc-1 retry_index=286
2022-04-29T10:45:02.569352Z ERROR ThreadId(77) packet_cmd{src_chain=ibc-1 src_port=transfer src_channel=channel-0 dst_chain=ibc-0}: will retry: handling command encountered error: failed to construct packet proofs for chain ibc-1: ABCI query returned an error: AbciQuery { code: Err(18), log: Log("proof is unexpectedly empty; ensure height has not been pruned: invalid request"), info: "", index: 0, key: [], value: [], proof: None, height: block::Height(405), codespace: "sdk" } path=packet::channel-0/transfer:ibc-1->ibc-0 retry_index=286
2022-04-29T10:45:03.107963Z ERROR ThreadId(74) packet_cmd{src_chain=ibc-0 src_port=transfer src_channel=channel-0 dst_chain=ibc-1}: will retry: handling command encountered error: failed to construct packet proofs for chain ibc-0: ABCI query returned an error: AbciQuery { code: Err(18), log: Log("proof is unexpectedly empty; ensure height has not been pruned: invalid request"), info: "", index: 0, key: [], value: [], proof: None, height: block::Height(417), codespace: "sdk" } path=packet::channel-0/transfer:ibc-0->ibc-1 retry_index=287
2022-04-29T10:45:06.422157Z ERROR ThreadId(77) packet_cmd{src_chain=ibc-1 src_port=transfer src_channel=channel-0 dst_chain=ibc-0}: will retry: handling command encountered error: failed to construct packet proofs for chain ibc-1: ABCI query returned an error: AbciQuery { code: Err(18), log: Log("proof is unexpectedly empty; ensure height has not been pruned: invalid request"), info: "", index: 0, key: [], value: [], proof: None, height: block::Height(405), codespace: "sdk" } path=packet::channel-0/transfer:ibc-1->ibc-0 retry_index=287
2022-04-29T10:45:06.970827Z ERROR ThreadId(74) packet_cmd{src_chain=ibc-0 src_port=transfer src_channel=channel-0 dst_chain=ibc-1}: will retry: handling command encountered error: failed to construct packet proofs for chain ibc-0: ABCI query returned an error: AbciQuery { code: Err(18), log: Log("proof is unexpectedly empty; ensure height has not been pruned: invalid request"), info: "", index: 0, key: [], value: [], proof: None, height: block::Height(417), codespace: "sdk" } path=packet::channel-0/transfer:ibc-0->ibc-1 retry_index=288

at present, Cosmos pruning-keep-recent is set to 100height by default, which means that we only have 100height-times to generate when we are in clear packet_opdata_from_events, if timeout occurs, the whole batch will fail.
When the build packet proof fails, I think we can catch this exception and ignore the subsequent events, because the subsequent events will fail (the state has been trimmed)

I managed to reproduce the error, thanks for the detailed instructions @lyqingye !
I am trying to estimate a solution and we'll try to address this in the next (June) release.


Cmdline popup is off by two characters (prompt?)

Describe the bug
The Cmdline and cmdline-popups seem to be off by two characters as shown in the image:

Which version of Neovim are you using?
Nightly
To Reproduce
          views = {
            cmdline_popup = {
              -- https://github.com/MunifTanjim/nui.nvim/tree/main/lua/nui/popup
              position = {
                row = 15,
                col = "50%",
              },
              size = {
                width = 150,
                height = "auto",
              },
            },
            popupmenu = {
              relative = "editor",
              position = {
                row = 18,
                col = "50%",
              },
              size = {
                width = 150,
                height = 10,
              },
              border = {
                style = "rounded",
                padding = { 0, 1 },
              },
              win_options = {
                winhighlight = { Normal = "Normal", FloatBorder = "DiagnosticInfo" },
              },
            },
          }

Expected Behavior
Both windows are aligned

Even if I set the width of the cmdline to 148 chars, the two windows are shifted:

Also, is there anyway to trigger autocompletion as you write?
Thanks!

I know what's causing this. Something on my end, and also something at Nui https://github.com/MunifTanjim/nui.nvim/pull/204

Fixed, but you also need to update Nui

Thanks!


Wait for containerd installation in GCE scripts [1.4 backport]

This cherrypicks https://github.com/containerd/containerd/pull/6544 to release-1.4 branch. This will only affect k/k CI and e2e tests.
Prior to running the kube-node-installation.service, the containerd
installation should be complete as the k8s installation may have
dependencies on containerd and related binaries (e.g ctr). Add
wants/after systemd directives to ensure
kube-node-installation.service will only start after containerd
installation completes.
Signed-off-by: David Porter<EMAIL_ADDRESS>

/cc @SergeyKanzhelev

could you re-based on the latest HEAD of this release/1.4 branch? Just merged a fix for CI getting the wrong ginkgo version which blocks all PRs on 1.4 from getting through CI.

could you re-based on the latest HEAD of this release/1.4 branch? Just merged a fix for CI getting the wrong ginkgo version which blocks all PRs on 1.4 from getting through CI.

Thanks for taking a look, rebased!

/ok-to-test


HTTP stream to upload large file causes frequent connection failed, sock < 0 (IDFGH-11540)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
I am using HTTP stream described in the website to upload large file (1 MB file).
I have noticed that when I open connection with esp_http_client_open(), I am not able to established TCP connection.

However, when not using HTTP stream and instead using esp_http_client_perform(), I instantly get TCP connection.
This is the code I am using for HTTP stream:
configuring http in main:
esp_http_client_config_t config_post = {
    .url = "http://<IP_ADDRESS>/uploads/upload_file.php",
    .method = HTTP_METHOD_POST,
    .cert_pem = NULL,
    .keep_alive_enable = 1,
    .timeout_ms = 600 * 1000};

client = esp_http_client_init(&config_post);

esp_http_client_set_header(client, "Content-Type", "application/octet-stream");

Reading from a usb and using http post:

static esp_err_t post_rest_function(void) {
  static char *post_data = buffer;
  ESP_ERROR_CHECK(esp_http_client_set_post_field(client, post_data, 8192));
  // esp_err_t err = esp_http_client_perform(client);
  esp_err_t err = esp_http_client_write(client, buffer, 8192);

  return err;
}

static void file_operations(void) {
  int64_t start_time, end_time, mid_time;

  static FILE *file;
  static esp_err_t err;
  static size_t read_bytes;
  static size_t last_sent_bytes;
  static const char *directory = "/usb/esp";
  static const char *file_path = "/usb/esp/book.txt";

  struct stat s = {0};
  bool directory_exists = stat(directory, &s) == 0;

  if (!directory_exists) {
    ESP_LOGE(TAGUSB, "No directory found errno: %s", strerror(errno));
  }
  ESP_LOGI(TAGUSB, "Reading file");
  file = fopen(file_path, "rb");
  if (file == NULL) {
    ESP_LOGE(TAGUSB, "Failed to open file for reading");
    return;
  }

  int i, j;

  start_time = esp_timer_get_time();
  esp_http_client_open(client, 10000);
  while (1) {
    memset(buffer, 0, sizeof(buffer));
    read_bytes = fread(buffer, 1, sizeof(buffer) - 2, file);
    buffer[8191] = '\0';

    if (read_bytes <= 0) {
      break;  // End of file reached
    } else {
      err = post_rest_function();
    }
  }
  end_time = esp_timer_get_time();
  fclose(file);
  esp_http_client_close(client);
  esp_http_client_cleanup(client);
  printf("time taken is %lld sec for 1MB\n", (end_time - start_time) / 1000000);
  printf("Transfer speed in MiB/s %f\n",
         (1 * 1000000) / (float)(end_time - start_time));
}

I want to use HTTP stream to increase my upload speed, but it doesn't seem to be working. I would appreciate any help.

any update on this?

Hello @suryasid09
Can you provide with a minimal application which can be used to reproduce this? Please also share the sdkconfig file with which you are facing this issue.
Thanks!

Hello @hmalpani
Thank you for your reply.
some development since my last post -> I did some further experiment. When 1st time I am trying to upload 1 MB data using HTTP stream, Esp32 gets IP assigned immediately, but, often when I ping the IP address of esp32 (through windows command line interface), there is no response. Then, I preform the reset by pressing the button on esp32 dev board  the 2nd time to check again uploading of 1 MB file, it always fail to open new http connection and gives the above error. I need to wait for around 5 mins or so then it starts it work again. On the server side, I am using XAMPP for testing.
Additionally, I have also tried connecting to different router thinking it is router issue but it doesn't solve the issue.
Please find the cleaned code:
#include <stdio.h>
#include <string.h>
#include "freertos/FreeRTOS.h"
#include "freertos/task.h"
#include "freertos/timers.h"
#include "freertos/event_groups.h"
#include "esp_wifi.h"
#include "esp_log.h"
#include "nvs_flash.h"
#include "esp_netif.h"
#include "esp_http_client.h"
#include "esp_timer.h"

char buffer[4096];

static void wifi_event_handler(void *event_handler_arg, esp_event_base_t event_base, int32_t event_id, void *event_data)
{
    switch (event_id)
    {
    case WIFI_EVENT_STA_START:
        printf("WiFi connecting ... \n");
        break;
    case WIFI_EVENT_STA_CONNECTED:
        printf("WiFi connected ... \n");
        break;
    case WIFI_EVENT_STA_DISCONNECTED:
        printf("WiFi lost connection ... \n");
        break;
    case IP_EVENT_STA_GOT_IP:
        printf("WiFi got IP ... \n\n");
        break;
    default:
        break;
    }
}

void wifi_connection()
{

    esp_netif_init();
    esp_event_loop_create_default();
    esp_netif_create_default_wifi_sta();
    wifi_init_config_t wifi_initiation = WIFI_INIT_CONFIG_DEFAULT();
    esp_wifi_init(&wifi_initiation);
    esp_event_handler_register(WIFI_EVENT, ESP_EVENT_ANY_ID, wifi_event_handler, NULL);
    esp_event_handler_register(IP_EVENT, IP_EVENT_STA_GOT_IP, wifi_event_handler, NULL);
    wifi_config_t wifi_configuration = {
        .sta = {
            .ssid = "your_ssid",
            .password = "your_password"}};
    esp_wifi_set_config(ESP_IF_WIFI_STA, &wifi_configuration);

    esp_wifi_start();
    esp_wifi_connect();

}

esp_err_t client_event_post_handler(esp_http_client_event_handle_t evt)
{
    switch (evt->event_id)
    {
    case HTTP_EVENT_ON_DATA:
        printf("HTTP_EVENT_ON_DATA: %.*s\n", evt->data_len, (char *)evt->data);
        break;

    default:
        break;
    }
    return ESP_OK;
}

void http_task()
{

	    esp_http_client_config_t config_post = {
	        .url = "http://<IP_ADDRESS>/uploads/upload_file.php",
	        .method = HTTP_METHOD_POST,
	        .cert_pem = NULL,
	        .event_handler = client_event_post_handler};

	    esp_http_client_handle_t client = esp_http_client_init(&config_post);

		if ((err = esp_http_client_open(client, 9998336)) != ESP_OK)								//open to transfer 10MB file
		{
		    ESP_LOGE("HTTP_custom_msg", "Failed to open HTTP connection: %s", esp_err_to_name(err));
		}

		for(i = 0; i< 2441 ; i++)
		{
			for (j =0; j<4096; j++)
			{
				buffer[j] = (char)(1+j%255);														//putting random characters
			}
			buffer[j] = '\0';
			esp_http_client_write(client,buffer,sizeof(buffer));

		}

	    esp_http_client_close(client);
	    esp_http_client_cleanup(client);

}

void app_main(void)
{
    nvs_flash_init();
    wifi_connection();
    vTaskDelay(5*1000 / portTICK_PERIOD_MS);
    printf("WIFI was initiated ...........\n\n");
    http_task();

}

and the sdkconfig file:
sdkconfig.txt

Hello @suryasid09
I tested your code. I am able to upload whole 10M data to server without any error. I started a python http server. You can see the server setup in the code below:
import argparse
from http.server import HTTPServer, BaseHTTPRequestHandler

class S(BaseHTTPRequestHandler):
    def do_POST(self):
        content_length = int(self.headers['Content-Length']) # <--- Gets the size of data
        post_data = self.rfile.read(content_length) # <--- Gets the data itself        # Doesn't do anything with posted data
        # self._set_headers()
        # self.wfile.write(self._html("POST!"))

def run(server_class=HTTPServer, handler_class=S, addr="localhost", port=8000):
    server_address = (addr, port)
    httpd = server_class(server_address, handler_class)

    print(f"Starting httpd server on {addr}:{port}")
    httpd.serve_forever()

if __name__ == "__main__":

    parser = argparse.ArgumentParser(description="Run a simple HTTP server")
    parser.add_argument(
        "-l",
        "--listen",
        default="<IP_ADDRESS>",
        help="Specify the IP address on which the server listens",
    )
    parser.add_argument(
        "-p",
        "--port",
        type=int,
        default=8000,
        help="Specify the port on which the server listens",
    )
    args = parser.parse_args()
    run(addr=args.listen, port=args.port)

@hmalpani thanks for looking into it.
with the python server, it is working as intended, it seems my XAMP server was creating issue. I haven't done the thorough testing yet with data upload from usb or sd card. But, I will close the issue for now.


removed console log

I have removed console.log from index.tsx

thank you so much.

thank you so much.

my pleasure


Eq 847 remove jquery

What is the context of this PR?
Removed jQuery because it is only used for one pattern so have replaced this with javascript and used polyfills.js to add support to older browsers.
How to review
Check focus on radio and checkbox inputs.
Also check browsers that don't support the following methods:

https://developer.mozilla.org/en-US/docs/Web/API/Element/closest
https://developer.mozilla.org/en/docs/Web/API/Element/classList

Still need to add linting rule to discourage use of var.


Symbol.iterator is not defined

Issue Summary
i'm using fetchapi in js to load the math elements and display it in my page,
on clicking next and prev buttons, the question and answer changes and adds different math elements accordingly,
so the first time, when window is loaded, it works fine, all math elements are rendered using MathJax,
but
when i click on next or prev question, it gives me Symbol.iterator is not defined,
i tried with MathJax.typeset() after everywhere it changes text (didnt work)
after that i found out, that i only have to call typesetting once
then i move the MathJax.typeset() at the end of my fetch()  call, (again it works when page is reloaded/refresehed, but not when changing it dynamically)
Basically, i'm just changing the contents of the page asynchronously using fetchapi(), nothing fancy, but when i change on button click, new math is not able to load due to this error
i tried with MathJax.typesetPromise(), same thing is occurding, giving me "Symbol.iterator is not defined"
have added polyfill with mathjax@3  as mentioned on https://www.mathjax.org/#gettingstarted
this is my fetch call, inside that i'm updating the content, after my content is added and fetch call completes
i'm calling this,

which gives me this,

i tried to find similar issue if people have faced, but couldn't find any
Please help

https://github.com/mathjax/MathJax/assets/38568811/41172a7e-66bf-4144-84c8-0a55a53f7826
Technical details:
OS: Win11
browser: Chrome Version 120.0.6099.130 (Official Build) (64-bit)
I am using the following MathJax configuration:
no configurations, i'm using it directly with defaults
and loading MathJax via
<script src="https://polyfill.io/v3/polyfill.min.js?features=es6"></script>
<script id="MathJax-script" async<EMAIL_ADDRESS>

Found a solution to this:
found here in google groups: https://groups.google.com/g/mathjax-users/c/YvYtQLxYKBk
i was using mathjax@3
i updated to Mathjax@4
<script src="https://polyfill.io/v3/polyfill.min.js?features=es6"></script>     <script id="MathJax-script" async<EMAIL_ADDRESS>


Undo close tab

This plugin seems to handle only windows. Would be great to have all-in-one solution for undo close with undo close tab as well.
Currently when I close tab with multiple windows I cannot restore them. That's why I have to use different script https://www.reddit.com/r/vim/comments/3ke941/undo_close_tab/cuxwxy1/

The way the plugin is implemented, it listens to an autocommand to determine when a window was closed, and stores it in history for later. Unfortunately, :tabclose doesn't trigger this autocommand, or any different one that I can monitor (as far as I could tell).
The only way to fix it is with some custom mapping/command to close the tab and somehow store it in history -- that's what the script you linked to does, but it uses its own history.
I see two possible ideas. One is, instead of using that script, you use something that closes a tab by closing its windows one by one. I even have one in my own vimfiles (originally for a different reason), which is why this has never been a problem for me :) https://github.com/AndrewRadev/Vimfiles/blob/c92287283f82db9221e148bca114d81be311295e/startup/mappings.vim#L139-L149
I could even provide this sort of mapping from the plugin, as an optional "map this to something and use it if you'd like tabs to be closed and their windows to be restorable" (Note that if you just :quit windows one by one, they get restored just fine, even if they were in a different tab). This would restore windows one by one, though, instead of just restoring the whole tab, which might be inconvenient.
The second option I see is to create some kind of interface to allow custom "store" and "restore" functionality with a custom mapping.  Would you rather the plugin provided a "close tab, while storing window states" mapping that lets you restore windows one by one? Or a custom callback setup that's more complicated, but theoretically might give you more options? Or some third option I might be missing?

I've just installed your plugin along with the mentioned script and I'm quite happy with both solutions working for tabs and windows. Thank you for the seamless experience.
Reopening windows one by one from different tabs is good and useful.
Having a shortcut to reopen tabs is even better, as it is seamless and faster (especially in the case when "closing all other tabs except current". And if I close tab by ":tabclose" having no option to restore windows is sad, that's why I immediately installed that script to have complete solution.
My suggestion was just to add that script to the plugin (probably eliminating a need to have 'godlygeek/windowlayout' installed, if you know how, as I personally have no clue in vimscript) and provide a plugin with complete feature set for undo close functionality.
To summarise: user will be required to set two mappings: 1) undo close window 2) undo close tab
And probably override existing mappings for closing tab, as required by that script.

Sorry for taking a while to get around to this. While I could see the logic in what you were describing, it took some thinking and inspiration to come up with some way of implementing it.
I've pushed an :UndoableTabclose that could be used as a :tabclose replacement, and a <c-w>U mapping that should be able to restore all the windows of a full tab. Could you go over the updated documentation and try it out?

I'll go ahead and close this issue, since I think the command and mapping are the best I can do for this scenario.