PyKwiki 2 doesn't seem to be compatible with existing PyKwiki 1 content

Having upgraded to PyKwiki 2 I ran "pykwiki cache -f" over my existing blog and the resulting traceback message was as follows:
Could not load /home/rdickens/personal/pywkwiki_OLD_blog/config.yaml, using default settings
========================================
Caching source posts
Traceback (most recent call last):
  File "/usr/bin/pykwiki", line 357, in <module>
    command_cache(args)
  File "/usr/bin/pykwiki", line 206, in command_cache
    num_cached = ctrl.cache_posts(plist, force=force)
  File "/usr/lib/python2.7/site-packages/pykwiki/core.py", line 300, in cache_posts
    pg = Post(pf)
  File "/usr/lib/python2.7/site-packages/pykwiki/core.py", line 769, in __init__
    conf.check()
  File "/usr/lib/python2.7/site-packages/pykwiki/core.py", line 172, in check
    raise Exception('conf.version does not exist')
Exception: conf.version does not exist

Hey Phayz,
I'm still working on the documentation and have another update to PyKwiki2 coming this week.
However, pykwiki should support the upgrade command.
In the project directory, try:
pykwiki upgrade

Thanks for the quick reply.
pykwiki upgrade in the project dierctory worked.  \O/

Awesome. I'll make this clear when I finish the Pykwiki2 documentation -- which is probably about a month out.

I'm a professional technical writer, so if you need help with PyKwiki2's documentation please ask.

I'd love the help, but most of the important knowledge surrounding Pykwiki 2 exists only in my head. If you see anything missing or lacking once I get more content, I'd be very grateful for any commits you make to the repository (docs/ is a mirror of the documentation). Whatever you do, please continue to provide feedback when you find something broken -- it truly helps improve Pykwiki and motivates me to spend more time on it. Thanks again.

Understood. I can only document PykWiki and since all that information is in your head, I'd only be slowing you down.
I'm certainly willing to review the documentation and help where I can do so.

Hi,
Please read this info, it means so much to me, here is the link http://lafrophophu.sylviawoodsharpcentre.com/lnpmmqf
See you around<EMAIL_ADDRESS>


feat(ssl): redesign SSL usage

Server::https was changed to allow any implementation of Ssl.
Server in general was also changed. This was to help the design of Ssl, and will also allow a future Pull Request to allow the Server to support an Iterator design, and accepting single requests; generally just not requiring that a Handler (and its task pool) be used.
HttpConnector no longer uses SSL; use HttpsConnector instead. NOTE: Servo
Client will use DefaultConnector, which will be HttpsConnector by default. If the openssl feature is disabled, it will be HttpConnector. Those using Client::new() should be unaffected.

cc #573 #131 #541 #575 @reem @retep998 @Manishearth

Nice catches, fixed.

I like the new Server API, seems more easily extensible.

@seanmonstar give me a heads up before publishing a new version including these changes please.

Sure. I'll bump the version to 0.6 as well, since it has breaking changes.
On Sat, Jun 20, 2015, 7:02 PM Jonathan Reem<EMAIL_ADDRESS>wrote:

@seanmonstar https://github.com/seanmonstar give me a heads up before
publishing a new version including these changes please.
—
Reply to this email directly or view it on GitHub
https://github.com/hyperium/hyper/pull/577#issuecomment-113851507.

I'm trying to update a project to the latest versions of its dependencies including hyper but am running into an issue that I think was a breaking change in this pull. There used to exist a client.set_ssl_verifier which I used here. This method seems to have went away, but I can't find the current alternative. Does one exists in the latest release?

I think I figured out out
let client = Client::with_connector(
  HttpsConnector::new(
    Openssl {
      context: Arc::new(
        ssl_ctx // <- I create this now
       )
    }
  )
)

this factory method want's quiet what I needed but enough to steer me in the right direction.
Great work on pushing this library forward.


Add Extension capability for handling custom data types

Hello,
I made a small modification so I an extend your class and pass any data I want to the renderer. I must handle document objects, and implement ArrayAccess is not enough to have correct data :

class DocumentTable extends CliTable {

  protected function getValue($doc, string $key)
  {
    return $doc->getMetadata($key, null);
  }

}

So maybe you want to merge it :)
I also fixed a bug when displaying data with UTF-8 characters, but maybe that would require to add symfony's mbstring polyfill as a dependency.

So, sorry for the long time, new job here.
I checked the code and I installed another library for my CLI display. So maybe close this or do what you want but as far as I am concerned I will not put more time in this ; I'm sorry.


[Masthead] L0 Functional Specs

User Story

As a [user role below]:
IBM.com Library developer

I need to:
be able to reference masthead l0 behavior

so that I can:
confidently execute on my stories, and support in the future

Additional information

Masthead navigation design folder

Acceptance criteria

[ ] functional specs created and shared
[ ]  web simplification team approval
[ ]  design and development agreement
[ ]  stories (if necessary) to iterate and create

Here are two issues that didn't get broken out originally.
Profile menu functional specs
https://github.com/carbon-design-system/ibm-dotcom-library/issues/1967

@ljcarot @wonilsuhibm @jeffchew @larahanlon2 @kennylam @mbarry325 @kathysaraf @RobertaJHahn
Here are the functional specs for the L0 for you to review. If there is time in the footer review meeting I'll try to also go over this today too and what's outstanding.
https://ibm.box.com/s/j4ii2xib4f6enp1hobc55u3k535cs1vd


[Backport v2.7] [BUG] Unnecessary node restart during vSphere provisioning on RHEL 8.8

Backport https://github.com/rancher/rancher/issues/43119
Please check the original issue for details.

The fix can be validated in the latest Rancher v2.7-head.
For more information about validating the fix, please check this comment

Ticket #43778 - Test Results - ✅ Pass

Scenario
Test Case
Result

1.
Validate node doesn't reboot
PASS

2.
Scale Node driver cluster
PASS

Validated with Docker on Rancher v2.7-head:
Scenario 1: Validate node doesn't reboot

Create an Rhel 8.8 image with NM disabled and network service enabled
Create a downstream rancher cluster using the image in step 1
Validate that no reboot occurs during provisioning.

Results:
No reboot occurred on the downstream nodes and the cluster came up successfully.
Scenario 2: Scale Node driver cluster

Create an Rhel 8.8 image with NM disabled and network service enabled
Create a downstream rancher cluster using the image in step 1
Scale the cluster up.
Validate that no reboots are observed and the cluster remains in a stable state.

Results:
No reboot occurred on the downstream nodes and the cluster scaled successfully.


Ordering of Featured Resources doesn't work

related to closed #64 , a feature that was added but is not currently working.
The ability to sort a resource so it shows up in a precise order is not functioning.
On the Coordination & Planning Toolkit page, we want to highlight the 2017 Staffing Survey as the top featured resource.
However, updating the Order on the Admin page does not change the order. I even tried deleting the existing rows and adding new ones in the order that we wanted, and they still reordered on the live site.

Fixed locally. Will go out in next deploy.

Deployed to production, closing.


can this run on a Rapsberry Pi  Zero ?

Sorry not an issue but I would like to have a Raspberry Pi  Zero speak German without the need for an Internet connection
(Amazon Polly and IBM Watson have great German voices but are paid service quite complex to install - not to mention the need for a connect and its delays)
I just subscribed to your course (I understand only a bit of German) ;-)
Maybe some of the heavy work can be done on a fast computer but I need the text to speech to be done on the Raspberry Pi ?

Hi, how about just trying it out? :) I did not test it on a RPi but I currently don't see an issue except the device's performance.

Ok I will run it on my Mac to understand the process ...


feat(cli): show repo and current tag name in "cog log"

I've made changes to cog log so that it uses "repo_name:latest_tag" instead of the string "cog log" as the file name to pager.
Open Questions:

Should we include the current branch name as well. If yes, how should the text be formatted?
If there is no tag in the repo, then we only display the repo name. This behavior should be alright, right?
I've added code to use the string "cog log" just in case something goes wrong. Should I get rid of it or could you please suggest a better approach to handle this.

Closes #47

Hello @renaultfernandes thank you for taking this one !
You could add your git signature/github username to cog.toml (in this PR).

1. Should we include the current branch name as well. If yes, how should the text be formatted?

That would be great ! Something like {repo_name} on {branch} {tag} would do I guess.

2. If there is no tag in the repo, then we only display the repo name. This behavior should be alright, right?

Yep.

3. I've added code to use the string "cog log" just in case something goes wrong. Should I get rid of it or could you please suggest a better approach to handle this.

Seems good to me.
I will merge when you complete those little changes.

Thanks for reviewing my PR. I've made the suggested changes.
Cheers !!!

Congrats @renaultfernandes, nice one !


ERROR in node_modules/ngx-currency-input/lib/ngx-currency-input.directive.d.ts(25,74): error TS2304: Cannot find name 'InputEvent'.

ERROR in node_modules/ngx-currency-input/lib/ngx-currency-input.directive.d.ts(25,74): error TS2304: Cannot find name 'InputEvent'.

Hi @eldhose-cavli,
thanks for you comment. Could you provide more context to the issue you experience?
i.e:

Typescript version,
Angular version,
and how you're trying to use the library?

Hi @eldhose-cavli,
thanks for you comment. Could you provide more context to the issue you experience? i.e:

Typescript version,
Angular version,
and how you're trying to use the library?

In my case is as follows:

Now I have installed https://www.npmjs.com/package/ngx-currency instead, and it has the same effect, and is working ok tho.


clip rectangle not correct when slots out of parent window.

ad8f10b4a513bb9b6888cbb27931292c75a7f380 removed the PushClipRect line that was modified for this PR, but the issue still occurs.
The method behind this PR still seems right: Passing true for intersect_with_current_clip_rect in PushClipRect correctly hides the sequencer when scrolled out of view on 664cf2d (v1.83).
diff --git a/ImSequencer.cpp b/ImSequencer.cpp
index 6eea18a..5e2c45a 100644
--- a/ImSequencer.cpp
+++ b/ImSequencer.cpp
@@ -273,7 +274,7 @@ namespace ImSequencer
                   */
                   // clip content

-         draw_list->PushClipRect(childFramePos, childFramePos + childFrameSize);
+         draw_list->PushClipRect(childFramePos, childFramePos + childFrameSize, true);

          // draw item names in the legend rect on the left
          size_t customHeight = 0;
@@ -297,9 +298,6 @@ namespace ImSequencer
             customHeight += sequence->GetCustomHeight(i);
          }

-         // clipping rect so items bars are not visible in the legend on the left when scrolled
-         //
-
          // slots background
          customHeight = 0;
          for (int i = 0; i < sequenceCount; i++)
@@ -318,7 +316,7 @@ namespace ImSequencer
             customHeight += localCustomHeight;
          }

-         draw_list->PushClipRect(childFramePos + ImVec2(float(legendWidth), 0.f), childFramePos + childFrameSize);
+         draw_list->PushClipRect(childFramePos + ImVec2(float(legendWidth), 0.f), childFramePos + childFrameSize, true);

          // vertical frame lines in content area
          for (int i = sequence->GetFrameMin(); i <= sequence->GetFrameMax(); i += frameStep)

My above comment is wrong: this issue is fixed in 1.83.

However, it seems to be fixed by making the sequencer fill available space which hides widgets below it.  #195 computes the space needed instead and uses the change described above to ensure the window clips correctly.
I think this issue can be closed.

This change was merged with #271.


Importing libraries from urls should be more secure adding mandatory https and hash key

This issue was originally filed by @Emasoft

PROBLEM: A great feature of Dart is the possibility to import external Dart libraries from URLS. This is useful both for Dart server side scripts and for client side web apps with lots of libraries to cache via CDNs.
But this feature open a serious security breach in Dart, and can be exploited in many dangerous ways.
SOLUTION: The solution is composed by 3 parts:
1 - Force the import from secure (https) connections only. No http connections should be allowed. Only https servers would be able to serve Dart libraries. This way a MITM attack would be much more difficult.
2 - File names are not enough. A simple file rename could cause a lot of troubles and security issues. The name of the library should be add as a mandatory parameter:
import 'libraryname' , "https://something.com/script.dart";
If the library inside the dart file has a different name, it should not be loaded.
3 - Add the option to specify the hash key of the file, like a signature, for increased security against MITM attacks and server side hacks. If the hash key is specified, when the DartVM loads the library from the url it must check for its hash:
import 'libraryname' , "https://something.com/script.dart", "0x6b4e03423667dbb73b6e15454f0eb1abd4597f9a1b078e3f5b5a6bc7";
The hashing function should be SHA-3 (because of its unlimited message size), with any of the following bits formats supported:
SHA3-224
SHA3-256
SHA3-384
SHA3-512
SHAKE128
SHAKE256

I'm sympathetic to this request, and I thank you for the suggestion and feedback, but it's not on our radar.
FWIW, new web APIs like Service Worker mandate SSL (unless you are using localhost), so an SSL requirement might become common.
Regardless, as @gbracha this is an embedder specific concern. The stand-alone VM, or Dartium, or Sky, etc can make their own rules here.
The Stand-Alone VM doesn't plan to do this, so I'll close this issue.


Move Zoom Slice from Redux Store to React Context

Should be a simple experiment where we can try to migrate across to the context API and see what it can do for us.

Resolved in build 140


[Docs]:  ExpirationPluginOptions docs/functionality inconsistencies

Provide environment information
@serwist/next v9.0.2
Describe the problem
After working with the expiration plugin, I think I've found some inconsistencies between the docs and functionality, or at least things that caused confusion for me.
In my case I'm using:
new ExpirationPlugin({
	maxEntries: [some integer],
	maxAgeSeconds: undefined
});

From the docs (and comments):

maxEntries — The maximum number of entries to cache. Entries used least recently will be removed as the maximum is reached.

However this only appears to apply if maxAgeFrom is set to last-used, but the default is last-fetched. Furthermore, maxAgeFrom isn't present in the docs and the comment in the code indicates it only applies to maxAgeSeconds:
// ExpirationPlugin.ts
/**
   * Determines whether `maxAgeSeconds` should be calculated from when an
   * entry was last fetched or when it was last used.
   *
   * @default "last-fetched"
   */
  maxAgeFrom?: "last-fetched" | "last-used";

Expected behavior
I'm happy with how it works when I set maxAgeFrom: 'last-used', but I'm not sure whether the functionality or documentation is correct. If someone can clarify I could take a look at making a PR
Screenshots (if relevant)
No response
Additional information (if relevant)
No response

Ah yes, that was me forgetting to update its documentation!
Thank you for noticing! This will be fixed in 9.0.3.


Make tinymce-placeholder compliant to webpack/browserify with npm

Hi there!
small pr because we use your nice plugin, but we compile our assets with webpack, so we need to add them with npm.
npm init (add package.json), add index.js and .gitignore

This pull request is not working well. I close it and come back with a better one :)


Next.js 13 no SSR

Please describe which feature you have a question about?
I am pretty excited about the Amplify support of Next@latest , unfortunately the "hello world" app I am trying to deploy acts like create-react-app without the useful prerendered content
Provide additional details
https://main.d1top4agb5zal9.amplifyapp.com/ (if you view the source there is no HTML)
same repo/codebase/version deployed to Vercel:
https://next13-mu.vercel.app/
What AWS Services are you utilizing?
Amplify Hosting
Provide additional details e.g. code snippets

from AWS console logs

I am also getting no messaging about running in the build step.
We're having a lot of issues (right now getting a 502 error on a brand new deployment) and wonder if this might have something to do with it

@DanProudfoot can you share your AppID( found in app settings >General)? We could hop on a call to see what's going on.

does this has some preferences for region ? , I am deploying from eu-west-1 ... and since the post I didn't make new updates, now the app displays 500 error

Are you seeing this behaviour with a "Hello word" page like the below?
// pages/ssr.js
export default function SSR({ formattedDate }) {
  return (
    <>

Server-side rendered page

        This page is server-side rendered. It was rendered on {formattedDate}.

        View a static page.

    </>
  );
}

export async function getServerSideProps() {
  const renderDate = Date.now();
  const formattedDate = new Intl.DateTimeFormat("en-US", {
    dateStyle: "long",
    timeStyle: "long",
  }).format(renderDate);
  console.log(
    `SSR ran on ${formattedDate}. This will be logged in CloudWatch.`
  );
  return { props: { formattedDate } };
}

@DanProudfoot can you share your AppID( found in app settings >General)? We could hop on a call to see what's going on.

@swaminator Our AppId is d35zta8s7v7rta. Happy to jump on a call during UK working hours ( 9 - 5:30 GMT).
@arpecop We're also deploying to eu-west-1...maybe that's the problem?

Hey @arpecop for the avoidance of doubt, are you using SSR or streaming SSR?
Amplify Hosting doesn't yet support streaming SSR, which you might see if you use the (beta) /app directory feature. That said, it should fall back to client side rendering: for example https://main.d123h98fg6yy59.amplifyapp.com/ is created from https://github.com/vercel/next.js/tree/canary/examples/with-turbopack

@michrome I would be happy to use the old way (using src/pages/) but before trying to migrate I have question regarding the support lambda@edge , and edge geolocations ?

@arpecop if in doubt, I recommend creating a new app to test it out.
After migrating, apps have a fully-managed CloudFront distribution that will not be visible in your AWS account, so Lamba@Edge will not be available to you. No geographic restrictions are set so the distribution is serving gloablly.

Closing this issue due to age.


Add setting to choose if the results are errors or warnings

Problem matchers can set a default severity level. A new setting should be added that injects a user selectable value in to this.
The allowed values are error and warning, and it defaults to error.

This might not be needed for v5.1.225507 and on since the report output seems to include a violation level now. Still worth investigating though.


Generate HTTPS URIs for github-targetted gems

The bundler-audit gem rightly raises an error when a Gemfile uses a git:// or http:// source, these being insecure protocols.
This patch sets an https:// URI in the lockfile when you do something like
gem 'environmentor', github: 'madebymany/environmentor'

Duplicate of #4109.

@indirect ah sorry. I thought I searched well enough; clearly not.


Add shared-npm packages + ci

Description: Migrate shared packages from azure-pipelines-tasks-common to this repo and add ci
Documentation changes required: N
Added unit tests: N
Attached related issue: N

@damccorm @stephenmichaelf this seems like goodness all around. Do we have a plan for how to inform other task authors of the changes, and let them know what to do going forward? (Probably doesn't belong IN this PR, but I didn't want to forget to ask.)

this seems like goodness all around. Do we have a plan for how to inform other task authors of the changes, and let them know what to do going forward? (Probably doesn't belong IN this PR, but I didn't want to forget to ask.)

We haven't discussed one yet. Maybe we can add a readme in the Common folder saying a bunch of stuff has moved. I'm no longer sure what the best way to communicate to all the tasks teams is. The common folder doesn't get a ton of action to begin with, so the readme might actually just be enough

@damccorm I think popping a note into a few Slack channels that says "heads up, Common is gone, you consume common functionality via real npm packages now, remember to bump your versions and rebuild" is probably enough. I can help you figure out the set of channels (likely just the Pipelines teams, the Artifacts team, and a few groups from RM).


Stop all sounds ?

Hello,
First, thanks for ion.sound, it's great !
However, is it possible to stop all sounds ?
I tried ion.sound.stop(); but i don't know if it's still working, because i have this error :
TypeError: undefined is not an object (evaluating 'this.streams[0].stop')
Any help ?

Hello, maybe a bug. Try a demo page, also to double check.

Fixed in 3.0.1


refactor(callback): specify the name of the keyword argument

Need to maintain existing code for future implementation of service-related callback classes


close #2320

This simple_format function should probably be called on some other strings as well. The problem was that when we have <%=...%> in a div, the new lines in the string just cause new lines in the generated html, which doesn't do anything. simple_format causes those new lines to turn into p tags.

Thanks, @wkwan!


Midpoint test fails

Running from the current master (80ce30b), on Windows, with dart version:
Dart SDK version: 2.10.0-7.3.beta (beta) (Wed Aug 26 09:46:50 2020 +0200) on "windows_x64"
Does this test pass for you folks? Perhaps on Linux or on another dart version?
Log output:
PS C:\git\turf_dart> dart test
Precompiling executable...
Precompiled test:test.
00:05 +1: test\components\midpoint_test.dart: midpoint
29.704243058393104
251.6519826898071
289.2560026566121,<PHONE_NUMBER>185807, 0
00:06 +9 -1: test\components\midpoint_test.dart: midpoint [E]
  Expected: <true>
    Actual: <false>

  package:test_api                         expect
  test\components\midpoint_test.dart 24:5  main.<fn>

00:06 +17 -1: Some tests failed.

Thanks!
I'll keep looking at it to see if I can find a bug in the implementation, or in the test.

midpoint tests work now, because I added the normalization of latitudes (antimeridian, meridian boundaries [180;-180])
see
Position.toSigned()


docs: Add incremental replication example

adds a new docs page with an example of incremental replication based on a time field; closes #1372

:books: Documentation preview :books:: https://meltano-sdk--1390.org.readthedocs.build/en/1390/

Thank you @flexponsive for this PR, I was the original poster on Slack for this documentation and you beat me to it :)
I left two comments with suggestion that could add a bit more depth to the docs, feel free to take them into account or not.

@aaronsteers @edgarrmondragon can you give this a review when you're able to?
Thanks @flexponsive for the PR!

Thank you for the feedback and improvements!


Fix Stable Diffusion weights loading

in master fails with
TypeError: Dummy() takes no arguments

and after adding __init__
UnpicklingError: state is not a dictionary

I can't repro. I think you have different weights.

hmm, something in my python env triggers it 🤔 . Seems to be working in a clean env

seems like if you have pytorch-lightning installed, while unpickling weights, it gets imported and it breaks something
pytorch_lightning.callbacks.model_checkpoint ModelCheckpoint
https://github.com/geohot/tinygrad/blob/58d3824cbe93fb50ca350f6f40fcd2646a487c59/extra/utils.py#L60-L62

cool, merged


fix: don't unbind app on modify

:tada: This PR is included in version 2.18.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


In big sur top corners not rounded

Describe the bug
After updating mac to big sur the app has some weird gray corners on the top left / right.
To Reproduce
Steps to reproduce the behavior:
Just launch the app and look at the top left and top right.

Duplicate of #2835


MODFISTO-269. Allow user to base encumbrance on "Initial encumbrance" during rollover

Purpose
https://issues.folio.org/browse/MODFISTO-269

Approach
Updated function calculate_planned_encumbrance_amount(_transaction jsonb, _rollover_record jsonb, _rounding boolean) to be able to base encumbrance on "Initial encumbrance" during rollover

TODOS and Open Questions

Learning

Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.

Does this PR meet or exceed the expected quality standards?

[x] Code coverage on new code is 80% or greater
[x] Duplications on new code is 3% or less
[x] There are no major code smells or security issues

Does this introduce breaking changes?

[ ] Were any API paths or methods changed, added or removed?
[ ] Were there any schema changes?
[ ] Did any of the interface versions change?
[ ] Were permissions changed, added, or removed?
[ ] Are there new interface dependencies?
[x] There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

What other modules will these changes impact?
Do JIRAs exist to update the impacted modules?

[ ] If not, please create them
[ ] Do they contain the appropriate level of detail?  Which endpoints/schemas changed, etc.
[ ] Do they have all they appropriate links to blocked/related issues?

Are the JIRAs under active development?

[ ] If not, contact the project's PO and make sure they're aware of the urgency.

Do PRs exist for these changes?

[ ] If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment.  Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.


Crash fix for equal to MAX_BUF_SIZE case

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   58.82%   58.82%
=======================================
  Files           1        1
  Lines          17       17
  Branches        3        3
=======================================
  Hits           10       10
  Misses          5        5
  Partials        2        2

Impacted Files
Coverage Δ

src/cimplog-rdk-logger.c
58.82% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b62f0c...8996c67. Read the comment docs.


[Request] Update weapon and wearable modules to include new IDs

hi, the game recently updated and they added a couple armors (steel, gold, diamond etc) and 7 new weapons, can you update the modules to account for the additions?

Can you still use the cheats in that update? (Supposedly they would implement a better anti-cheat system)

Can you still use the cheats in that update? (Supposedly they would implement a better anti-cheat system)

that's a good question and it doesn't say there's a new anti cheat or show one in game yet

new ids will not be added but prs are welcome


Fill match arms assist ignores existing variants prefixed with Self::

Right now if you have an enum that has some match arms and a match like this:
match x {
    Self::V1 => todo!(),
    Self::V2 => todo!(),
}

and you add a new variant and then run the fill match arms assist it will insert additional copies of V1 and V2 in the match arms that are prefixed with the types own name rather than Self.

Will check to fix it :)

This is a special case of the fill match arms assist not understanding use and type aliases. For example, given the following enum and various matches on its variants...
pub(crate) enum Foo {A, B, C, D, E, F}
type Bar = Foo;
mod Mod {
    pub(crate) use super::Foo as ModFoo;
}

impl Foo {
    fn match_assist(self) {
        use Foo::*;

        match self {
            Foo::A => {},
            Self::B => {},
            Bar::C => {},
            Mod::ModFoo::D => {}
            E => {},
        }
    }
}

...Rust Analyzer detects that the match is non-exhaustive and suggests to fill in the missing match arms. When using it, it changes the example to...
pub(crate) enum Foo {A, B, C, D, E, F}
type Bar = Foo;
mod Mod {
    pub(crate) use super::Foo as ModFoo;
}

impl Foo {
    fn match_assist(self) {
        use Foo::*;

        match self {
            Foo::A => {},
            Self::B => {},
            Bar::C => {},
            Mod::ModFoo::D => {}
            E => {},
            Foo::B => {}
            Foo::C => {}
            Foo::D => {}
            Foo::E => {}
            Foo::F => {}
        }
    }
}

...add arms for B through F. It should only add an arm for F, as that's the only one missing.
This behavior remains the same in a fn outside of an impl (ignoring the Self case that obviously doesn't compile).

It duplicates E because of #1165 for sure.


Check that each block has no more than one coinbase transaction

I think this will just be a part of validation. There is no way to do the check inside coinbase tx code, becouse it doesn't have access to other transactions, just to the trees. We can force coinbase_tx easly to appear only as the first transaction in the block in block validation code. (#17)
(Unimportant note: Analysis made, because I was considering if I can maybe solve this issue now)


Use standard and unified CommonJS/esm distribution

Already done on my fork, (see changes).
Still need to update the docs.
Happy to submit a PR.
Breaking changes.

Is your feature request related to a problem? Please describe.

Currently this package is distributed using a client and server distributions.
This was identified as the cause for issues like #163 (Fast Refresh not working).
The distributions are webpack bundles, despite the fact that this package is certain to be consumed by NextJS which uses webpack. Webpack would do a much better job handling this package and its export if these are not bundled, but rather exported in CommonJS or esm format. This will allow Tree-shaking and build time saving. In other work, this package is bundled to be distributed and then bundled again (by NextJS/Webpack).
The way this package is distributed is hardly conventional.

Describe the solution you'd like and how you'd implement it

Package should be exported using standard common JS or esm.
No split between client/server distributions.

Is this a breaking change?
Yes.
In order for client NextJS build not complaining about node constructs (os, path, crypto... I stopped counting at the 13th one), any server function will have to be imported from a sub folder, like so:
import { useAuthUser, withAuthUser } from 'next-firebase-auth'
import { withAuthUserTokenSSR } from 'next-firebase-auth/server'

NextJS removes any pure server imports from client code, so this:
import { useAuthUser, withAuthUser, withAuthUserTokenSSR } from 'next-firebase-auth'

will become this for the client code:
import { useAuthUser, withAuthUser } from 'next-firebase-auth'

But 'next-firebase-auth' is not tree-shaken in development builds, and as it is importing server-related modules it will still break the client build (see comment, and confirmed in local try out).
Describe alternatives you've considered
None

Thanks for taking the time to investigate this issue.
Regarding:

The way this package is distributed is hardly conventional

Do you have any resources/examples you can share about distributing isomorphic Node packages? Before we make this change (especially because it's breaking), I'd like to get a better idea of best practices.

Do you have any resources/examples you can share about distributing isomorphic Node packages?

This is going to be a tough one in the context of this library...
Splitting into browser and main/module is absolutely fine in many scenarios, for instance, that's what puhser does. This is one approach to "distributing isomorphic Node packages"
Then there are libraries that have different logic between the server and the client - firebase-admin and firebase/app respectively.
But none is exporting React Components. A React component should have no discrepancy between Server/Client - it's a view construct and should render the same on both (or your React app will not hydrate properly).
When there are differences between Client/Server behaviour you may see two different components, like with React Router. But do note that these components do not manipulate the (to be hydrated) view.
In the way it is distributed now, this packages makes a loose separation between the React components (including HOCs) and the auth logic.
There are multitude of ways to solve this, in the solution on my branch I simply put server stuff in the /server folder and enabled importing form that /server folder. This may not be the best strategy, but it was the low-hanging-fruit.
Seeing as this is breaking change (a major version bump), we may just as well wish to think this through, but it will mean larger-scale changes.
If you wish, and I find the time, I'm happy to write an RFC on possible improvements for the next version.

@Izhaki Thanks for the info and code diff. I agree that breaking out the server code into next-firebase-auth/server looks like the right decision.
Looking at your diff, couldn't we achieve this by keeping Webpack?

Modify index.js and server/index.js like you did
Remove the "browser" property from package.json

The benefits of this approach: maintain JS compatibility, allow us to use Webpack ecosystem tools, and reduce the build scripting required.
Thoughts?

I'm also curious if this fixes #236. If you have a chance to try it on your fork, please let me know.

Looking at your diff, couldn't we achieve this by keeping Webpack?

I guess we could. I think if anything Webpack is not going to be the issue here, but rather the fact that we are going to end up with two bundles and we still have an issue with Fast Refresh. So I guess the answer is - we wouldn't know until we try.
But then there's an argument why not to use Webpack and it goes like this:
Some Context and Terminology
Two types of artefacts (with relation to React and React apps):

Apps - something that you deploy.
Packages - something you publish (say to npm) and then get bundled into an app. Sometimes the name library is used, although nitpickers will distinguish between a framework (calls your code, like React) and a library (your code calls it, like lodash).

Also, I've never seen any official figures, but I bet my car that more than 95% of React apps are bundled using WebPack.
Against Webpack
Webpack is a bundler. It works a treat with apps, gives us HMR and Fast Refresh and incremental builds and whatnot.
It is used far less commonly to publish packages. This is a problem because how other packages go about transpiling the dist folder is priceless (and normally your starting point).
I guess the main reason is that packages, specifically React related packages, do not need to be distributed as bundles, on the contrary - they are better shipped as individual files.
Bundling will include some bundler-specific code (webpack runtime/manifast). Not a problem for apps.
But a React package will be bundled again into an app, so better let the app bundler do the bundling, rather than let the bundler bundle a bundle (there are some exceptions to this, but not relevant to this package).
Now consider the following distribution you may want to support:

CommonJS - (main) this is the common denominator that is universally supported (node or webpack, but not directly in the browser). Having said that, it is only a must because some people still use CommonJS code in naive SSR code. In nearly all other cases the next option will be preferred.
Legacy ESM - (module).
Modern ESM - (exports). This is the future and is already the first choice in node 12 and Webpack 5.
umd - for CDNS.

Of all these the only one that truly need to be a bundle is the umd one. For a React library why would you bundle any other type?
(see https://github.com/developit/microbundle for more)
Who Knows?
Now you could get away with just a bundled (using Webpack) CommonJS distribution.
I have spent a lot of time with Webpack, but never to publish a library. I have no idea what quirks are ahead (and there usually are), and I'm suspect guides/examples are scarce.
It's your call really.

PS
If already introducing breaking changes. I have an idea for a few more of them. So let me know if you wish me to spell these in an v1 RFC.

We should stick with Webpack until we identify any specific problems of doing so. It's definitely used for libraries (Webpack docs) and React components (e.g., blog post).
As of now, this issue serves only to solve #163. If we identify another way to fix HMR and no other reasons for a next-firebase-auth/server refactor, we can close this.
@Izhaki Yes, feel free to open any other issues. I'll plan to put together a v1 roadmap issue.

Closing this, given that #163 is resolved.


Add sorting to organisation summary table

Make table header cells clickable and use them to sort the table by those columns
Default to last 7 days sorting
Add spec for browsing by organisation

Part of https://tree.taiga.io/project/core-improvement-theme/us/12?kanban-status=211675
cc @boffbowsh @benilovj

Couple of tiny points, otherwise :+1: from me

@boffbowsh Rebased and addressed first comment. Second one (test refactor) caused tests to fail so I have held off on that one.

Bon. Merge at will :rocket:


static get properties() vs @property(): How to get properties when @property() is used.

When
  static get properties() {
    return {
      greeting: {type: String},
      data: {attribute: false},
      items: {type: Array},
    };

is used, then
<div>${Object.getOwnPropertyNames(this.constructor.properties).toString()}</div>

does work.
But when
  @property()
  greeting;

  @property({attribute: false})
  data;

  @property({type: Array})
  items;

is used, then TypeError: can't convert undefined to object. I suspect it refers to properties.
So, how can I get the names when @property() is used?

See this example in the other issue you posted: https://github.com/Polymer/lit-element/issues/1102#issuecomment-738289694
Going to close this as we've added this capability to the next major version, and we're not going to address the issue in the current version given that you can work around the problem as shown above.

Hi @sorvell -- this issue is still the top search engine result for iterating properties on a lit-element, and I'm on v3 now, but cannot find out how to list the properties if decorators are used.  Can you point to how to do it on new lit versions? Thanks!

I've got a class that extends LitElement from Lit 3.1.3, and elementProperties does not exist on the instance.

You can access static properties from the constructor:
this.constructor.elementProperties;


Possible to update textlayers?

Hi,
Im trying to update the text in a textlayer after I have created the element with bodymovin.loadAnimation. If I try to simply update the animationData-object on the animation, it wont update. I can see that the object in developertools is updated, but this will not cause a rerender of the text onscreen. I have also tried to destroy the animation and recreate the object, but this wont work ether. So this will not work to update text, only to set it initially before calling loadAnimation:
anim.animationData.layers[0].t.d.k[0].s.t = 'RandomText';
I can see that you are doing something similar in this example on Codepen, and I can recreate your example locally. But I still cant update the text of my composition. Is there anything special about text? The text is exported from AE as text and not shapes.
I can give more complex code examples if needed.

So I am a little bit closer. After reading different cases here on GitHub, I understand that you have to have keyframes on values that should change. So now I have put keyframes on both position and Source Text. I can now update the position, but not the Source Text. Is it possible to update the Source Text?

Since Text keyframes are Hold keyframes, they are not interpolated, so until it reaches that keyframe, the text won't be updated.
You can modify the keyframe starting value together with the text in order for it to work.
Let me know if it helps.

Sorry, but I can still not get this to work.
This is my code:
let anim;

function UpdateGraphics() {
  anim.animationData.layers[0].t.d.k[0].s.t = 'Text2';
  anim.animationData.layers[0].t.d.k[1].s.t = 'Text2';
}

function CreateGraphics() {
  $.getJSON('bodymovin/test2.json', (animationData) => {

    animationData.layers[0].t.d.k[0].s.t = 'RandomText';
    animationData.layers[0].t.d.k[1].s.t = 'RandomText';

    const elem = document.getElementById('supring');
    const animData = {
      container: elem,
      renderer: 'svg',
      loop: true,
      autoplay: true,
      rendererSettings: {
        progressiveLoad: false
      },
      animationData,
    };

    anim = bodymovin.loadAnimation(animData);
  });

}

So the CreateGraphics works as expected. But I cant get UpdateGraphics to work. Is there anything other than updating the keyframes textvalue I need to do?
.json attached
test2.json.zip

closing issue. Reopen if needed.

@christianeide were you able to get it to work? I'm working on something similar, so was curious.

@ssanthos No, never managed to make it work, so I gave up bodymovin for now.

@ssanthos @christianeide I've added a method "updateDocumentData" that allows updating text during animation.
More here
https://github.com/bodymovin/bodymovin/wiki/TextLayer.updateDocumentData

Superb! Also, great to know that support to update more properties are coming in the future.

Thanks a lot @bodymovin! Will be trying this out soon!

Just a little more info on this for people still struggling (like I was)
updateDocumentData() works, but needs to be called on an TextElement, so instead of
animData.layers[n].layers[m].t.d.k[0].s.t
Instead, look at the renderer's elements arrays
e.g.
anim.renderer.elements[0].elements[4].updateDocumentData({t:"BOB"})
It helps to use the console and dig through anim.renderer.elements[n] to make sure you're calling it on a TextElement (in my case SVGTextElement because I'm using the SVG renderer.
NOTE: You won't see the effect until you next render a frame (which is automatic if your anim is playing), if not you can call anim.renderer.renderFrame(frameNumber) to force it, however, it still won't update if you're already on that frame, so choose a different one.


Constrain single Dimensions

#72 implemented one type of Constraint—the CubeRegion—through __contains__ methods on MemberSelection and CubeRegion:
https://github.com/dr-leo/pandaSDMX/blob/a670198f45f90777d26b5b83c8d9e171b266ff6b/pandasdmx/model.py#L618-L637
This allows the evaluation of k in cr, when k is an instance of Key, and cr is an instance of CubeRegion.
A related, but distinct, task is to get all possible valid KeyValues for only one of the Dimensions of the CubeRegion. In pandaSDMX 0.9 this was used for validating queries; in 1.x, it is not used for this purpose, but the feature would still be useful.

Is the above comment still current, i.e. are keys for data requests validated against the unconstrained codelists?

While I consider this feature as a must-have, I am fine with the 1.1 Milestone.

Obsolete.


Spotify: changing source only forces "play" if the current state is "playing"

Description:
With the previous implementation, changing the spotify "source" (which changes the device which is playing music) would make the music start even if it was paused. This PR prevents the music from starting if it is not playing.
This allows more control, for example:

set the device volume before starting playing music (great at night)
change to another device without starting music (when going to work, set the work computer as source, without playing).

If the code does not interact with devices:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass

Looks good!


Rename backplane files to avoid wildcard characters

Unix shells typically treat square brackets as wildcards, so the current naming convention, where the specifics of the backplane are enclosed in square brackets at the end of the filename, clashes with some software.  In particular, IDL is not happy with it so it makes it more difficult to use OMINAS for diagnosing backplane issues.  I propose to instead append the specific data to the rest of the filename using '--' instead of enclosing it in square brackets.

This is no longer relevant, as we're going to dwtich over to the gold-master tests, which meet this convention.


Address all warnings in the code

Mostly deprecated tags

[x] clear()
[ ] generateCode()

To be done as part of #28 #33


Refactor assistant determine tool role method

@qarol I attempted to cherry-pick the commit from your PR to give you credit but due to merge conflicts I think your name was dropped from the commit.

@qarol I attempted to cherry-pick the commit from your PR to give you credit but due to merge conflicts I think your name was dropped from the commit.

No problem ;)


Add global kernel cache and HCF infrastructure

Add common global kernel cache infrastructure
Add unified HCF file format for kernels, tools, and documentation
Reimplement explicit multipass for CUDA and SPIR-V to use new infrastructure
Reimplement syclcc explicit multipass drivers to utilize unified HCF generation and integration header generation

TODO: Programs don't yet terminate cleanly on Level Zero due to a lifetime issue of the Level Zero backend shutting down before the cached SPIR-V kernels are unloaded.
SYCL-Bench task throughput benchmarks indicate that CUDA explicit multipass with the new kernel cache infrastructure outperforms integrated multipass by 30-40%.

It seems there is no easy fix for the Level Zero issue. This relates to the fundamental issue that we need to transition to a runtime that has its lifetime dependent on the existence of SYCL objects. This is a larger change, and should not block this PR.

In it goes.


required configuration in sample cf manifest

I don't think there's an error. At the end it says "No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.".

I do not understand the failing error. Suggestions?

* What went wrong:
Execution failed for task ':cloudfoundry-identity-server:test'.
> There were failing tests. See the report at: file:///root/uaa/server/build/reports/tests/test/index.html
* Try:
Run with --info or --debug option to get more log output. Run with --scan to get full insights.
* Exception is:
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':cloudfoundry-identity-server:test'.
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:100)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:70)
	at org.gradle.api.i

Closing due to inactivity.


Question about the FullySupervised experiment

Thanks for your work on collecting those SSL classification methods. I'm a little bit confused about the FullySupervised experiment, which seems to be trained only on a small fraction of labeled samples in configs. While the FullySupervised results remain almost the same in the README, please help clarify the meaning of FullySupervised here.

Sorry for the inconvenience.
As you can see in (https://github.com/TorchSSL/TorchSSL/blob/main/datasets/ssl_dataset.py#L297),
we load all data to labeled dataset when it comes to fully supervised training.

Thanks for the clarification.


Alternative approach using installimage

We noticed there's an easier way to install Hetzner dedicated servers with encrypted HDDs/SSDs, using Hetzner's own installimage system. Basically it is described in https://community.hetzner.com/tutorials/install-ubuntu-2004-with-full-disk-encryption with Ubuntu instead of Debian :)
These instructions use only a single disk, if your server has multiple ones, you can use something like
DRIVE1 /dev/sda
DRIVE2 /dev/sdb
SWRAID 1
SWRAIDLEVEL 1

in /tmp/setup.conf.
The image for debian is
IMAGE /root/images/Debian-1101-bullseye-amd64-base.tar.gz

(also change that in /tmp/setup.conf).
The /tmp/post-install.sh script shown in that blog post works fine for Debian as well.
The only caveat is that the SSH keys you put into /tmp/authorized_keys will afterwards be both used for unlocking and for regular login on the server. I put the unlocking SSH key in there and used it to first login into the real system, and then changed the SSH key for that one to another.

Thats a good one, thanks for the heads up in the right direction.

This is a pretty nice no-brainer and works with bullseye 11.01 as expected.
This is a little help if you want to use LVM:
PART /boot ext3 512M
PART lvm   vg0   all crypt

LV vg0 root /    ext4  20G
LV vg0 swap swap swap   4G


Prepare product labels as batches to be processed by Nucleus

Initially it was decided to present PDS product-by-product to Nucleus to be processed. However, when processing larger data sets with hundreds or thousands of PDS product labels, this can lead to launch a large number of ECS tasks and docker containers, which is both time consuming and resource consuming.
It is required to implement a way to create batches of PDS product labels and present those batches as manifest files to Nucleus to be processed.

@ramesh-maddegoda works now with batches of 10 products which works for validate and harvest for messenger data.
@ramesh-maddegoda will use the manifest supported by both validate and harvest for a list of products.

Done but PR is not ready yet.

The pull request is available at https://github.com/NASA-PDS/nucleus/pull/78


Handle _fetchId correctly in the ProjectSet operator

In a query like select unnest(arr), x the Collect operator is allowed
to re-write x to _fetchId. The ProjectSet operator didn't handle
that case correctly.

[x] User relevant changes are recorded in CHANGES.txt
[x] Touched code is covered by tests
[x] Documentation has been updated if necessary
[x] CLA is signed

lgtm but there seems to be a configuration issue with the Azure pipeline, have a look.

It's because https://github.com/crate/crate/pull/7721 isn't merged yet


Install phase picks up integration test binary

Describe the bug
With doCheck = true (the default), crane runs cargo test. When a binary crate has integration tests, this also builds the crate's binary under the same location as cargo build does, but with potentially different dependencies. For example, when a crate has dev-dependencies with different features, these are considered in cargo test, but not in cargo build (at least with resolver version 2). As the install phase runs after the check phase, it then picks up the binary built for the integration tests and copies it into the output.
nixpkgs's buildRustPackage copies the binary after the build phase to a temporary directory (see commit that introduced the copy).
Reproduction
See https://github.com/yaxitech/crane-test-binary-reproducer/

Hi @Trundle thanks for the report and the reproduction! It's really unfortunate cargo will clobber artifacts like this so I suppose a two step installation is the best we can do... Should be fixed with https://github.com/ipetkov/crane/pull/771


[$500] Compose-Copy link option is not displayed in context menu in gmail accounts.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.14
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
Action Performed:

Go to https://staging.new.expensify.com/
Login with gmail account
Tap on a chat
Long press any sent message and note context menu options

Expected Result:
Copy link option must be displayed in context menu in gmail accounts.
Actual Result:
Copy link option is not displayed in context menu in gmail accounts.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/95a179fb-ef1d-4bc2-8f4d-0aa25aa6c973

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01639bed3a0bc7f5b9
Upwork Job ID:<PHONE_NUMBER>942121984
Last Price Increase: 2023-12-19

Proposal
Please re-state the problem that we are trying to solve in this issue.
Compose-Copy link option is not displayed in context menu in gmail accounts.
What is the root cause of that problem?
We don't have permission for copy link
What changes do you think we should make in order to solve the problem?
We need to update backend api for beta.
What alternative solutions did you explore? (Optional)

Agreed, this isn't a bug for now. it's behind a beta


The link on the main page to the latest HAXM goes to CheckTool instead

Describe the Bug
The link presented under Downloads for the latest version of HAXM actually goes to CheckTool instead: https://github.com/intel/haxm/releases/tag/checktool-v1.0.0

Summary:
The link to get the latest HAXM on the main project page is wrong.
Host Environment
N.A.
To Reproduce
Browse to https://github.com/intel/haxm
Click on "here" in the Downloads section.
Expected Behavior
Expectation:
A page offering the latest version of HAXM, as described.
Reproducibility
Always
Diagnostic Information
N.A.
Additional context

None

Thanks for your report. You may download the latest release here. We will update the web page later.

Thanks for your report. You may download the latest release here. We will update the web page later.

@Stokestack Nice issue you raised, thanks a lot.
@wcwang ,maybe we could change hyperlink  to here ( 'https://github.com/intel/haxm/releases')

@Stokestack Nice issue you raised, thanks a lot.
@wcwang ,maybe we could change hyperlink  to here ( 'https://github.com/intel/haxm/releases')

Wow intel

Wow intel

This issue has been fixed by PR #348. Thanks again.

This issue has been fixed by PR #348. Thanks again.

 Thanks for fixing it.

 Thanks for fixing it.


Move command tests into separate files

Moving the tests specific to commands to separate files to make working on individual commands easier
Fix the requires and test helper so that they can be easily run independently or with rake

Does anyone think this is a useful change? If so I can update it for all the recent code changes that conflict with it. If not I can close this.


README.md example does not work.

I did exactly as the example shows, and here are the results I got.
Machine Specs: Ubuntu 14.04.1, Python 2.7.6
[18:06] --> dmtucker<EMAIL_ADDRESS>has joined this channel.
[18:06] --> HiBot<EMAIL_ADDRESS>has joined this channel.
[18:06]  HiBot, sayhi
[18:06] <-- HiBot<EMAIL_ADDRESS>has left this server (Remote host closed the connection).
$ python test.py
...
Traceback (most recent call last):
File "test.py", line 27, in
bot.connect()
File "/usr/local/lib/python2.7/dist-packages/pyrc/bots.py", line 44, in connect
self.listen()
File "/usr/local/lib/python2.7/dist-packages/pyrc/bots.py", line 68, in listen
self.parseline(line)
File "/usr/local/lib/python2.7/dist-packages/pyrc/bots.py", line 79, in parseline
self.receivemessage(channel, nick, message)
File "/usr/local/lib/python2.7/dist-packages/pyrc/bots.py", line 109, in receivemessage
self.parsecommand(channel, message)
File "/usr/local/lib/python2.7/dist-packages/pyrc/bots.py", line 131, in parsecommand
command_func(self, channel, _match.groups(), *_match.groupdict())
File "/usr/local/lib/python2.7/dist-packages/pyrc/utils/hooks.py", line 19, in wrapped_command
return func(_args, *_kwargs)
TypeError: sayhi() takes exactly 3 arguments (2 given)

WFM with Python 2


feat: handle errors in snackbar

closes #82
add error key to SnackbarMessage type
add errorWhiteBg icon
pass error value to current snackbar store commits
conditionally render snackbar based on !!error

Great, thank you very much. LGTM.


Not more then 2 environments possible in one Azure Subscription?

We are evaluating the use of Azure Container Apps. During creating our development, test and integration environment we got the following error when deploying multiple container environments to the same Azure Subscription:

The subscription '***' cannot have more than 2 environments.

Is this something which will change once it will go GA? Or is there a specific reason for this?

This is definitely a preview limitation. If I remember correctly (don't judge me if not), @jeffhollan mentioned in the early days of the preview that this limit will also be increased during the preview

This is a limitation of the preview. We are working on increasing the quotas for GA.

@torosent do you know the planned date for GA?
I apologize for asking this question here, but couldn't find the info elsewhere

With GA we have increased the number of environments per subscription to 10

These new limits seem fairly limited for organizations that have more than 1 application in a region;
https://docs.microsoft.com/en-us/azure/container-apps/quotas

Say your organization has two applications (completely separate), and each application has a QA an a production, that's 4 app environments in potentially 1 environment right here, next application you build has to go into a different region?
Also 20 containers apps per environment per subscription? what does that mean? You can make 20 container apps in a subscription or 20 container apps in an environment?


Better bubbling-up of errors

When moving master.tus.io to kubernetes we failed to implement a number of things on the serverside:

insufficient permission on the volume
Tus-Resumable was not allowed by Access-Control-Allow-Headers
allow PATCH and friends

So all in all, it was a bit of a sloppy job for which I blame myself. That being said, the errors that that we bubbled up where quite cryptic, and I wonder if we could improve on that, so that other people trying to set up tusd servers have a smoother onboarding experience as their debugging trails are more limited.

Closing this issue due to inactivity. Feel free to leave a comment if you want to continue the discussion :)


Add GET & DELETE /transactions

Thanks George, I think I already added the GET here but it's not merged yet https://github.com/RelationalAI/rai-sdk-python/pull/56 I was waiting on Brad's approval

We can completely disregard mine and consider yours, I just added it for tracking the tickets, I can go ahead and close that one without merging

Ah sorry Sameera, totally missed #56. This one adds also the delete, exports the names & adds the permissions.

Perfect, thanks. I'll close mine. I just want to point out that it might be better for the reviewers to break down changes in separate PRs instead of having a big one. I would - as a reviewer - prefer to have separate PRs for 1. get 2. delete 3. exporting names 4. adding permissions. It's also better in my opinion to do incremental merges so we can rollback changes that break stuff (if any). But that is just my opinion :)

Perfect, thanks. I'll close mine. I just want to point out that it might be better for the reviewers to break down changes in separate PRs instead of having a big one. I would - as a reviewer - prefer to have separate PRs for 1. get 2. delete 3. exporting names 4. adding permissions. It's also better in my opinion to do incremental merges so we can rollback changes that break stuff (if any). But that is just my opinion :)

I agree on separate PRs when they make sense. Here the changes are pretty small & trivial, so I thought it's fine. Regarding breaking them, exporting & permissions are tightly coupled to the provided functionality so I'd include them with the actual get or delete functions.


Creating build to generate templates for portal and visual studio

I don't know if anyone would be able to look at a PR with 416 files changed :)

Unfortunately this was the only way i could send the PR, because of lot of back and forth the intermediary commits would have confused everyone more. Huge part of the change are file location changes. I am going to add a commit summary and highlight the files that actually changed/added.

yeah, I was just saying I think you're probably okay just merging it as I doubt anyone would really give you any meaningful review considering the size of the PR.


Path with double context in windows for --add option

I think I found a bug.
When I launch :
npx vue-i18n-extract report -v "./src/**/*.?(vue)" -l "./src/locales/**/*.json" -a

I got this result :
ectory, open 'C:\repoC:\repo\src\locales\en.json'
    at Object.openSync (fs.js:462:3)
    at Object.writeFileSync (fs.js:1384:35)
    at C:\laragon\www\oklinda\node_modules\vue-i18n-extract\dist\vue-i18n-extrac
t.umd.js:189:12

Here is the fix I did :
In vue-i18n-extract.umd.js line 185
function writeMissingToLanguage(resolvedLanguageFiles, missingKeys) {
    const languageFiles = readLangFiles(resolvedLanguageFiles);
   [...]
      const fileExtension = languageFile.fileName.substring(languageFile.fileName.lastIndexOf('.') + 1);
      const filePath = path.resolve(process.cwd() + languageFile.fileName);
      const stringifiedContent = JSON.stringify(languageFileContent, null, 2);

     [...}
    });
  }

Remove the process.cwd() as the path are already in the context.
function writeMissingToLanguage(resolvedLanguageFiles, missingKeys) {
    const languageFiles = readLangFiles(resolvedLanguageFiles);
   [...]
      const fileExtension = languageFile.fileName.substring(languageFile.fileName.lastIndexOf('.') + 1);
      const filePath = path.resolve(languageFile.fileName);
      const stringifiedContent = JSON.stringify(languageFileContent, null, 2);

     [...}
    });
  }

Now it works for me.

I had the same problem, I did what you said in your comment and it worked perfectly.
@o-Chamie-o thanks!

I had the same problem, I did what you said in your comment and it worked perfectly.
@o-Chamie-o thanks!

The problem only appears if you run it on Windows, it works perfectly on Linux.

The problem only appears if you run it on Windows, it works perfectly on Linux.

The problem only appears if you run it on Windows, it works perfectly on Linux.

Hum interesting, clearly the process.cwd() don't have the same behavior in Windows and in Linux then.
Can you try my fix in linux too, just to see if it broke it or not?
Thanks for the update. :)

If I try to do it in linux I find the following error:

The problem only appears if you run it on Windows, it works perfectly on Linux.

Hum interesting, clearly the process.cwd() don't have the same behavior in Windows and in Linux then.
Can you try my fix in linux too, just to see if it broke it or not?
Thanks for the update. :)

If I try to do it in linux I find the following error:

So maybe this is more a windows bug then. :thinking:

So maybe this is more a windows bug then. :thinking:

It's a typo; you must use , with path.resolve not +...
It has been solved in #94, update to version 1.1.11.

It's a typo; you must use , with path.resolve not +...
It has been solved in #94, update to version 1.1.11.

It's a typo; you must use , with path.resolve not +...
It has been solved in #94, update to version 1.1.11.

Oh how come I didn't see it. :o
Yeah it's a typo, just try you fix.
Thanks a bunch for the update @gilles-crealp. :)

It's a typo; you must use , with path.resolve not +...
It has been solved in #94, update to version 1.1.11.

Oh how come I didn't see it. :o
Yeah it's a typo, just try you fix.
Thanks a bunch for the update @gilles-crealp. :)


new version of vm-import-controller chart and images

Problem:

PR introduces new version of vm-import-controller chart and images to address existing CVEs
Solution:

Related Issue:
Test plan:

@mergifyio backport v1.1


navbar and scrolling fix

Issue https://github.com/Tech-N-Science/FunwithScience/issues/358
Fixes: #[issue number that will be closed through this PR]
It fixes issue https://github.com/Tech-N-Science/FunwithScience/issues/358
Describe the changes you've made
There was bug in home page which caused it to scroll up automatically after certain seconds.It was basically due to
=> Onclick function being sent directly instead of sending it as a event.
=> Another important reason was useeffect hook in navbar page which scrolled the page during render and navbar itself was rendered only after 4 seconds delay caused by settimeout in homepage's useeffect.Both together made the page go up after 4 seconds
Basically issue was not from calculator button / go top button.After solving the above causes , the problem was fixed.
To fix the navbar permanently even after scrolling , styles changes were made and most importantly position of navbar was changed to "sticky".
Checklist:

[x ] My code follows the style guidelines of this project.
[x ] I have performed a self-review of my own code.
[ x] I have commented my code, particularly in hard-to-understand areas.
[x ] I have made corresponding changes to the documentation.
[ x] My changes generate no new warnings.

@SabariGanesh-K if u did for physics then u could also have done for maths

Math I checked, it was not problematic... I opened the last section.. It was alright only..


Forcing REQUESTS_CA_BUNDLE env var

As per suggestion from @smunilla
Copied from https://github.com/openshift/elliott/blob/master/elliott#L1048

/lgtm


fixes for building on ubuntu 18 and pynq sdist packaging

Hi @powderluv, I am taking the liberty to merge this PR as in this way we'll be finally able to get this merged into PYNQ. I hope you don't mind, it's just to speed things up. You can at this point remove my write access to your fork.

Sounds great. Thx for getting it in


Jugemu adding bgm

An object with the AudioPlayer component and and AudioSource component will play its selected music. Music is selected by setting the value of the ShouldBePlaying enum variable, which can be done in inspector or by another script at runtime.
Additional music can be added by adding a music file to the BGM_Tracks array in the inspector, as well as adding the filename as a value in the enum. Of note, the order of the audio files in the aforementioned array and the order of filenames in the enumerator must be in the same order for this to work.
Sound effects can be played by calling the PlayClip() method with the desired sound as the input.

You are lucky this time @Ethan-P-Sewall .
We have a code standard located in our CodeStandard.md at the root of the repo.
But were in a rush and I will let this harisey go undocumented. lol JK I will make a short card for you to come back and fix it.

Tested and it's working.


Added s3 mirroring support

what

Upstream ECS task definition mirroring to S3 bucket

Close the PR as it is not actual anymore.
We have s3 mirroring merged in #810


Adding Data Atmosphere from S2S to mainline gcm

The purpose of this PR is add add a new question to gcm_setup for data atmosphere when running coupled. This originates from GEOS-S2S-3(https://github.com/GEOS-ESM/GEOS-S2S-3/pull/15), and as per request of @mfmehari it is being added to the main gcm.

ETA by @mathomp4: I've put a blocking label on this due to the issue with ExtData mentioned below.

Did anyone run a test?
fyi I've added readme Bin gave me to dataatm path.
/discover/nobackup/projects/gmao/bcs_shared/make_bcs_inputs/ocean/dataatm

Did anyone run a test? fyi I've added readme Bin gave me to dataatm path. /discover/nobackup/projects/gmao/bcs_shared/make_bcs_inputs/ocean/dataatm

@biljanaorescanin in the processes of testing it.

Note: The CI failures are because of the new question. Once @mfmehari says it works, then I can try figuring out how to get my scripts to work.

Did anyone run a test? fyi I've added readme Bin gave me to dataatm path. /discover/nobackup/projects/gmao/bcs_shared/make_bcs_inputs/ocean/dataatm

@biljanaorescanin in the processes of testing it.

@biljanaorescanin the new location/directory path for JRA55-DO works.


Downloading video as a single file rather than multiple files

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2016.08.07. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2016.08.07

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[x] Feature request (request for a new functionality)
[ ] Question
[ ] Other

Found out that youtube-dl downloads the video as multiple files instead of one file, which is much slower on my machine, used to be able to download videos several megabytes a second, now only downloads at a few hundred kilobytes per second. I would like an option to download the videos the old way.

-f best.


[BEAM-9240]: Check for Nullability in typesEqual() method of FieldTyp…

Added logic in typesEqual() method of FieldType class to return "false" if the FieldTypes differ in Nullability. Also added a Unit Test to validate the logic.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Also, the typesEqual() method of FieldType class is redundant as the behaviour is a subset of equals() method.
Instead of doing this:
    public boolean typesEqual(Field other) {
      return getType().typesEqual(other.getType());
    }

we can test typesEquality by doing:
    public boolean typesEqual(Field other) {
      return getType().equals(other.getType());
    }

and we can remove tyesEqual() method in FieldType class.

Can you explain how this would work? equals() checks field names and
typesEqual does not.
On Fri, Jan 31, 2020 at 11:48 PM Rahul Patwari<EMAIL_ADDRESS>wrote:

Also, the typesEqual() method of FieldType class is redundant as the
behaviour is a subset of equals() method.
Instead of doing this:
public boolean typesEqual(Field other) {
  return getType().typesEqual(other.getType());
}

we can test typesEquality by doing:
public boolean typesEqual(Field other) {
  return getType().equals(other.getType());
}

and we can remove tyesEqual() method in FieldType class.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/10744?email_source=notifications&email_token=AFAYJVPSBQEAL3QFY5OAYYDRAUSK7A5CNFSM4KORR6UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKQW6VQ#issuecomment-581005142,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAYJVK5RVUPMIYZVSKMEZDRAUSK7ANCNFSM4KORR6UA
.

Can you explain how this would work? equals() checks field names and typesEqual does not.
…
On Fri, Jan 31, 2020 at 11:48 PM Rahul Patwari @.***> wrote: Also, the typesEqual() method of FieldType class is redundant as the behaviour is a subset of equals() method. Instead of doing this: public boolean typesEqual(Field other) { return getType().typesEqual(other.getType()); } we can test typesEquality by doing: public boolean typesEqual(Field other) { return getType().equals(other.getType()); } and we can remove tyesEqual() method in FieldType class. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#10744?email_source=notifications&email_token=AFAYJVPSBQEAL3QFY5OAYYDRAUSK7A5CNFSM4KORR6UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKQW6VQ#issuecomment-581005142>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFAYJVK5RVUPMIYZVSKMEZDRAUSK7ANCNFSM4KORR6UA .

Oh! equals() won't work if the Schema has nested Schema. Sorry! didn't think of that.

Run Java PreCommit

retest this please

R: @amaliujia

LGTM to treat nullability as a factor of equivalence of fields.

Run Java PreCommit

retest this please

retest this please

retest this please

retest this please

can't seem to trigger tests.

is there anything that I can do to run the tests?

retest this please

Run SQL PostCommit

Run SQL PostCommit

If there are no comments, can this package be merged?

I will merge this PR seems it's been a while.
@reuvenlax feel free to comment anything in the future.


MI QA fixes

Description
Fixes for things that came up in the QA party on Friday https://docs.google.com/document/d/1jbSV3q1yEnDnrXJd5wKbdIRJk2yaGlBcjSkhBPW4aZQ/edit
The biggest change is that I noticed the expired incentives are still showing up - since the front end logic isn't there to exclude them yet, I marked all the expired incentives (there are a lot in MI 😢 ) as omit from API. These expired incentives were replaced with the new 2024 ones
Open question
~@hblumberg flagged that we don't want to use mathematical symbols in descriptions as per the program description guidelines. I agree with this for the most part but for this example (MI-71) the symbol is greater than or equal to which is kind of cumbersome to write out... do we think leaving in the symbol is ok in this case? (description: "Up to $600 rebate per heater for ENERGY STAR® heat pump water heaters. $600 for UEF ≥ 3.5, $475 for UEF ≥ 3.0.")~

Yeah there are a few ways to word it:

UEF of 3.5 or more
UEF of at least 3.5

Generally:

UEF > y -> "UEF over y"
UEF < y -> "UEF under y"
UEF >= y -> "UEF of y or more"
UEF <= y -> "UEF up to y"


Out of memory in case of very frequent hooked function

When the hooked function is called, let's say, 1 million times per second, the Orbit app consumes almost 5 Gb of RAM after approximately 10 seconds. If the frequency is lower (100.000 times per second), then the time extends proportionally.  I suspect that it might happen because of the data collected for a histogram, but I'm not sure yet.
I'm wondering if it's an expected behavior or a bug?

Not sure if I would call it a bug, but it also doesn't surprise me. AFAIK we never optimized for such a high load of calls.
With "Orbit app" I guess you mean the client, right? So far the limiting factor has always been the rendering.
We calculate some histograms but I don't know from the top of my head when this happens. I know some parts are done  in the postprocessing step, but probably not all of it.
Maybe @florian-kuebler knows more.
There are 2 ways to find out more details:

Orbit has introspection which can be enabled when Orbit is started with the --devmode option. (There is a button above the capture window.). This allows you to see how long certain manually instrumented function in the Orbit Client take to execute. So far mostly the rendering code is instrumented.
You can use Orbit to profile Orbit. Therefore you have to start both OrbitService and Orbit a second time. I assume you're running everything on the same machine. To make the two OrbitService not clash you have to give it a different port number. Hence start the second OrbitService with the options --grpc_port=1025 --producer_side_server=false and the client with the option --grpc_port=1025. Then you can choose the first OrbitService as the target process in the second instance of the client. (I hope that's not too confusing). (Note that you can't use user space instrumentation and/or manual instrumentation in the second Service/Client/instance-pair.

I hope that helps. :grimacing:

Thank you for these hints! I'm not sure if it helps with memory profiling, but I'll give it a try in any case.
Yes, by "Orbit app" I meant the client.

Sorry for being late to this. So I am not surprised if we do waste (or even leak) memory at some places. We unfortunately did not had time to look into memory. Also I agree that profiling Orbit with Orbit (or using introspection), will work, but also that Orbit is not particularly good in memory profiling (it has some memory tracking though).
What I know for sure is, that we keep every record of a function call (what we call a timer) in memory. That would  1.000.000* 10sec * ~4x8 Bytes (uint64) is around 0.3 Gb. That does not explain that completely. But we do have some of these places. So I would not be surprised if this is already the reason.
Unfortunately, I won't have any time soon to look into this more closely....


Add third new runner prototype

[x] #353
[x] #354

Pretty much complete, except for texture/materials

Stale


TestRail failed test run result comment includes ANSI chars

Hello,
I've noticed that in case of a failed test run result upload on testRail, it contains ANSI chars that makes reading of the outcome very difficult.
Did you face the same issue?
Is there any way to overcome this?
Example of a failed test run result uploaded as comment on testRaill:
Test Status is failed {"message":"Error: status should be 201!\n\n\u001b[2mexpect(\u001b[22m\u001b[31mreceived\u001b[39m\u001b[2m).\u001b[22mtoBe\u001b[2m(\u001b[22m\u001b[32mexpected\u001b[39m\u001b[2m) // Object.is equality\u001b[22m\n\nExpected: \u001b[32m201\u001b[39m\nReceived: \u001b[31m200\u001b....
Actual test run result as displayed under playwright html report:
Error: status should be 201!
expect(received).toBe(expected) // Object.is equality
Expected: 201
Received: 200
...

@tsakrikas how did you solve issue with
[playwright-testrail-reporter] No Existing 'TESTRAIL_RUN_ID' provided by user...
[playwright-testrail-reporter] Automatically creating a run...
[playwright-testrail-reporter] Failed to create new TestRail run: TypeError: Only absolute URLs are supported


feat: improve Nx setup, split up database repo to more modular components

Summary

types are now its own package. Import them from @modtree/types
same for entities with @modtree/entities

Testing

core: yarn test on root
e2e: yarn dev on root and make sure that localhost:3000 search works

overridden by #158


Workflow improvements

Description
The integration & delivery workflow should have the following steps:

integrate that should run all tests
deliver that should publish all publications to OSSRH.

The deployment workflow should have the following steps:

deploy that should publish all publications to GitHub Packages
deploy-docs that should publish the documentation to GitHub Pages.

Every task should be based on the host OS and should run on the following platforms:

Linux machines should target the jvm, js and linuxX64 platforms
macOS machines should target the macOSX64 platform
Windows machines should target the mingwX64 platform.

We could split jobs by platform target for convenience.

Checklist

[x] Update the integration & delivery workflow.
[x] Update the deployment workflow.
[x] Remove unused tasks in Gradle's build script.

Done.


Add set_quick_repair()

Here's the PR for #878!
This adds a new durability level above Paranoid that doesn't require repair.  For now, it's just called "ParanoidPlus" -- not the most descriptive name, but it at least makes it very clear where it falls on the scale of commit speed vs. recoverability.  If you have a better name, let me know 😄
To avoid repair, Durability::ParanoidPlus commits need to save the allocator state somewhere.  We can't use the region headers, because we'd be overwriting them in place; we might crash partway through the overwrite, and then we'd need repair.  So we instead save the allocator state to a new table in the system tree.  Writing to the table is slightly tricky, because it needs to be done without allocating (see below), but other than that it's a perfectly ordinary transactional write with all the usual guarantees.
The other requirement to avoid repair is knowing whether the last transaction used 2-phase commit.  For this, we add a new two_phase_commit bit to the god byte, which is always updated atomically along with swapping the primary bit.  Old redb versions will ignore the new flag when reading and clear it when writing, which is exactly what we want.
This turns out to also fix a longstanding bug where Durability::Paranoid hasn't been providing any security benefit at all.  The checksum forgery attack described in the Durability::Immediate documentation actually works equally well against Durability::Paranoid!  The problem is that even though 2-phase commit guarantees the primary is valid, redb ignores the primary flag when repairing.  It always picks whichever commit slot is newer, as long as the checksum is valid.  So if you crash partway through a commit, it'll try to recover using the partially-written secondary rather than the fully-written primary, regardless of the durability mode.
The fix for this is exactly the two_phase_commit bit described above.  After a crash, we check whether the last transaction used 2-phase commit; if so, we only look at the primary (which is guaranteed to be valid) and ignore the secondary.  Durability::ParanoidPlus needs this check anyway for safety, so we get the Durability::Paranoid bug fix for free.
To write to the allocator state table without allocating, I've introduced a new insert_inplace() function.  It's similar to insert_reserve(), but more general and maybe simpler.  To use it, you have to first do an ordinary insert() with your desired key and a value of the appropriate length; then later in the same transaction you can call insert_inplace() to replace the value with a new one.  Unlike insert_reserve(), this works with values that don't implement MutInPlaceValue, and it lets you hold multiple reservations simultaneously.
insert_inplace() could be safely exposed to users, but I don't think there's any reason to.  Since it doesn't give you a mutable reference, there's no benefit over insert() unless you're storing data that cares about its own position in the database.  So for now it's private, and I haven't bothered making a new error type for it; it just panics if you don't satisfy the preconditions.
The fuzzer is perfect for testing Durability::ParanoidPlus, because it can simulate a crash, reopen the database (skipping repair if possible), and then verify that the resulting allocator state exactly matches what would happen if it ran a full repair.  I've updated the fuzzer to generate Durability::ParanoidPlus commits along with the existing Durability::None and Durability::Immediate.

Oh wow, this ended up being a lot more work than I'd initially thought.
Thanks for the PR! I had been thinking it could work by setting the
recovery bit to false, but this is much better.
I'm traveling without my computer for the next few days, so it'll be a bit
before I can review this in detail.
Sent from my phone
On Sat, Nov 9, 2024, 10:57 PM Adam Reichold @.***>
wrote:

@.**** commented on this pull request.
In src/transactions.rs
https://github.com/cberner/redb/pull/893#discussion_r1835605075:

 /// Security considerations: Many hard disk drives and SSDs do not actually guarantee that data

 /// has been persisted to disk after calling `fsync`. Even with this commit level, an attacker
 /// with a high degree of control over the database's workload, including the ability to cause
 /// the database process to crash, can cause the database to crash with the god byte primary bit
 /// pointing to an invalid commit slot, leaving the database in an invalid, potentially attacker-controlled state.
 Paranoid,

/// Like [Durability::Paranoid], but also saves the allocator state as part of each commit.
/// This means repair is no longer required when opening the database after a crash.
ParanoidPlus,

I would suggest Enclosed here to convey that this writes more data inline
to make the resulting persistent structure self-contained.
—
Reply to this email directly, view it on GitHub
https://github.com/cberner/redb/pull/893#pullrequestreview-2425663411,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGNXQDPRVRTNRZAUU2CCMLZ737UXAVCNFSM6AAAAABRPVKIBSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMRVGY3DGNBRGE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Sounds good!  There's no hurry; enjoy your trip!

Ok, read through most of it now. One question. Do you think this quick repair approach can be used for 1-phase commit transactions too?
My thinking is that you need to save the allocator state and use 2-phase commit to get really fast repairs, because you need 2PC to avoid validating all the checksums. However, if you have the allocator state it seems like we can still accelerate a repair under 1-phase commit. It would still validate all the checksums, but then if it found the allocator state it could skip rebuilding the allocator state which requires a second scan of the file.
Does that seem like it works to you?
If so, then I think we should add a new method like WriteTransaction::set_quick_repair(bool) instead of adding this new Durability level, and it would work with both Immediate and Paranoid. That solves the naming issue too :)

Yeah, I like the idea of having this be a setting separate from the durability level.
I'm not sure we want to support using it with 1-phase commit, though.  It seems like a footgun -- if you call set_quick_repair(true) but forget to also do set_durability(Durability::Paranoid), your code will look like it's working, but when you actually try to recover from a crash, it'll be slow.
If we want to speed up repair with 1-phase commit, I feel like the better solution would be to verify the checksums and reconstruct the allocator state in a single pass.  That would give the same speed benefit -- and it would work for all 1-phase commit users, without requiring them to opt into a new mode or pay the cost of writing out the allocator state with each commit.

If we want to speed up repair with 1-phase commit, I feel like the better solution would be to verify the checksums and reconstruct the allocator state in a single pass. That would give the same speed benefit -- and it would work for all 1-phase commit users, without requiring them to opt into a new mode or pay the cost of writing out the allocator state with each commit.

Ah yes, good point, let's not support it for 1-phase commits.
Ok, so the naming options that seem appealing to me are:

Durability::ParanoidPlus
Durability::ParanoidWithQuickRepair or something like that
set_quick_repair(bool) where passing true also sets the durability level to Paranoid, and false leaves the durability level alone but disables quick repair.

(2) or (3) seem more descriptive than (1) to me. What do you think is most clear?

I think my preference at the moment is (3), but (2) also sounds fine!
If we go with (3), do you think it might be worth splitting 2-phase commit out into its own flag too?  This would let people use Durability::Eventual with 2-phase commit and with quick-repair, both of which seem like reasonable combinations.  We'd still support Durability::Paranoid for compatibility, but it would become an alias for Durability::Immediate with set_two_phase_commit(true).  I think this makes the durability levels a bit more intuitive -- we'd be left with just None, Eventual, and Immediate, which are all very clear names that describe their semantics well (whereas the semantics of Paranoid have never really been clear from the name).

That sounds good to me!

Okay, I've updated the code to use set_two_phase_commit() and set_quick_repair().  The old Durability::Paranoid is now deprecated in favor of the former, but still supported for compatibility.  Let me know if this looks like what you had in mind!

Merged. Thanks! This is awesome

Yay, thanks for taking the time to review all of this!
There's no hurry, but if you decide you're interested in doing the transition we were talking about in #894 to eventually get rid of the old allocator state, let me know.  I've got code to do the extra quick-repair commit on shutdown, which I can submit as another PR if you want it.

Oh ya, it'd be great to get rid of that old code path. Yes, please send that PR


[Feature Request] Add constants as type

I would like to be able to specify exactly what types of strings to output.
For example: "status: string" could be anything, but "status: 'loading' | 'ready'" could only be those two.

Nevermind. Enum can be used. status?(enum, approval status): [PENDING, APPROVED]

.


feat: support deserialization from a certain base of the response

Closes SAP/cloud-sdk-backlog#73.

I didn't notice that the newly created branch is based on other pr. So I close this one and recreate another one with a clean base.


[Question]: "Microsoft.Playwright assembly was found, but is missing required assets." - showing while trying to download browser binaries.

Your question
Trying to download browser binaries using playwright.ps1 install , but it shows Microsoft.Playwright assembly was found, but is missing required assets. Please ensure to build your project before running Playwright tool. Even after building my dotnet project the result is same as this.
Any kind of help will be apricated, thanks.

According to the documentation use pwsh bin/Debug/netX/playwright.ps1 install instead.
See https://playwright.dev/dotnet/docs/intro

According to the documentation use pwsh bin/Debug/netX/playwright.ps1 install instead. See https://playwright.dev/dotnet/docs/intro

Doesn't seem to work exactly.

try to delete C:\Users\{username}\AppData\Local\ms-playwright folder and install again

What's your .NET version? Did you follow the intro or can you share a repro repository? What does pwsh --version yield to (shows the PowerShell version)? Did you build it before with dotnet build?

@evilprince2009 Seem like you are running on MacOS. Not sure if this helps

Go to bin/debug/.playwright/node folder. Note that .playwright is hidden folder.
Make sure that under node, you will see folder called: "mac". Not "win32_x64" or "linux-x64".

If the folder is NOT mac, then try to delete your folder and run this command
dotnet publish --configuration Release -r osx-x64 --output temp-release-folder cd temp-release-folder .\playwright.ps1 install
Hope it helps. Cheers

Closing as per above since we were not able to reproduce it.

If it can help, I had the same problem because the PlaywrightPlatform in the csproj was wrong. Fixed it by setting it to all

As @gaelj mentioned, adding this to the .csproj file that references playwright will do the trick:
<PropertyGroup>
  <PlaywrightPlatform>all</PlaywrightPlatform>
</PropertyGroup>

I was building on Windows, copying files in a docker build and attempting to run pwsh playwright.ps1 install chromium on Linux and getting the error reported by the OP.
Adding <PlaywrightPlatform>all</PlaywrightPlatform> solved it.

@paulsuart but it doesn't work for me... struggling with this issue for 3 days and still having this issue with the following configuration

also have seen that browsers should be automatically downloaded, but while running tests they say to run this command to download them, which doesn't work for me. Do you have any other ways to fix it?
as a workarounds for me were:

download browsers with "npx playwright install"
download browsers in code with the "Microsoft.Playwright.Program.Main(new[] { "install" });"

But i really hope to make it work without workarounds

@igor-svirid we run the following two commands prior to running the tests (we only test with Chrome):
playwright.ps1 install chromium
playwright.ps1 install-deps chromium

Hope this helps.

@paulsuart, unfortunately no, but i've played with the PlaywrightNUnit versions and noticed that this command allows me to download all browsers till the version 1.25.0(here), but once i'm installing nuget PlaywrightNUnit with version 1.26.0 and above - i'm getting this error

As @gaelj mentioned, adding this to the .csproj file that references playwright will do the trick:
<PropertyGroup>
  <PlaywrightPlatform>all</PlaywrightPlatform>
</PropertyGroup>

I was building on Windows, copying files in a docker build and attempting to run pwsh playwright.ps1 install chromium on Linux and getting the error reported by the OP.
Adding <PlaywrightPlatform>all</PlaywrightPlatform> solved it.

This helped me. Thank you! I lost 6 hours searching for this solution.

As @gaelj mentioned, adding this to the .csproj file that references playwright will do the trick:
<PropertyGroup>
  <PlaywrightPlatform>all</PlaywrightPlatform>
</PropertyGroup>

I was building on Windows, copying files in a docker build and attempting to run pwsh playwright.ps1 install chromium on Linux and getting the error reported by the OP.
Adding <PlaywrightPlatform>all</PlaywrightPlatform> solved it.

This helped me. Thank you! I lost 6 hours searching for this solution.

This has also solved the problem for me - it appears to have been introduced in 1.33.0, 1.32 and below were all fine without this entry.

Added this line resolved my issue: Program.Main(new[] { "install" });
Example: for NUnit
[SetUp]
    public Task SetUp()
    {
        int exitCode = Program.Main(new[] { "install" });
        if (exitCode != 0)
        {
            throw new InvalidOperationException($"Playwright exited with code {exitCode}");
        }

        return Task.CompletedTask;
    }

Unfortunately I'm not able to solve this issue on a Mac (Ventura 13.0) using .NET 7.0. Modifying the .csproj file did not do it for me.

Did anyone resolve this? I'm on Mac 12.6 using .NET 7.0 and I amended the .csproj

Removed local repo, did clean clone and rebuild solution and didn't help.
Update of Playwright nugets didn't help.
Removal and new installation of Microsoft.Playwright and Microsoft.Playwright.NUnit nuget packages solved the issue.

all

did the trick for me, thanks


Can't use initializer for Context because of internal protection level

We are in the process of converting to Swift 3 (then later Swift 4) syntax and we upgraded Stencil from 0.5.x to 0.8.0.
After upgrading, I'm receiving an error when trying to initialize an instance of Context, stating we can't use the initializer because of internal protection level.

@ahoang That is correct, please see the release notes / changelog for 0.8 https://github.com/kylef/Stencil/releases/tag/0.8.0

Breaking

It is no longer possible to create Context objects. Instead, you can pass a
dictionary directly to a Templates render method.

- try template.render(Context(dictionary: ["name": "Kyle"]))
+ try template.render(["name": "Kyle"])