Introduces teuthology.packaging.GitbuilderProject

teuthology.suite, teuthology.task.install and teuthology.task.internal.check_packages all use different methods to check for packages in gitbuilder.  This provides a standard interface that all places in teuthology should be able to use to interact with packages on gitbuilder.
I'm looking for feedback on the class and the approach.  I've implemented it's usage in teuthology.task.internal.check_packages and that tests out with manual teuthology runs.  I've scheduled a suite, but it hasn't completed yet.
I'm hoping we can agree on  the approach and usage in check_packages in this PR and then submit others to use this in suite and install.
I've also done a bit of refactoring and testing to install here as well.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1690/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1691/
Test FAILed.

The commits are a bit of a mess, lots of refactoring happened during the course of this ticket.  I'll clean those up, of course.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1692/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1693/
Test PASSed.

I like this approach - it's actually really similar to something I've sort-of daydreamed about but never got around to. I can't help but think it would be worth splitting the generic parts out into a parent class, though, in case we want to create e.g. a PuddleProject using the same interface. Thoughts?

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1694/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1695/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1696/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1701/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1702/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1703/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1705/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1710/
Test FAILed.

Yay to the overall idea here - thanks for implementing this

I do still really think that this should have its interface abstracted before merging, rather than refactoring this refactor later... unless we know we'll never need to do it. Maybe we won't?

@zmc I disagree. I don't think we should abstract an interface without having an already existing use case for it. It just seems like a premature optimization at this point and what if we "imagine" the wrong interface.  You have more context than me here though. What do you see this interface looking like?

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1721/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1724/
Test PASSed.

@andrewschoen I care less now, after thinking more realistically about the likelihood that we'd want to reuse this code for something like Puddle. We can cross that bridge when we reach it.

@zmc yeah, we can always rework later if necessary.  Let me get those docs added and I'd like to try removing the need for ctx as well.  I think that either passing a list of roles or ctx.cluster there would be sufficient.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1726/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1727/
Test PASSed.

@idryomov revived #500 recently, and pointed out that we're missing the fact that the kernel task talks to gitbuilders as well.
Looks like we have a bit more to do here after all...
https://github.com/ceph/teuthology/blob/master/teuthology/misc.py#L197

@zmc yeah, the install task isn't included in this patch either.
I was hoping to only change internal.check_packages with this PR and follow
up with the others.  Do you think this PR should find all the places we
talk to gitbuilder and replace it with this?
On Fri, Jul 31, 2015 at 2:30 PM, Zack Cerza<EMAIL_ADDRESS>wrote:

@idryomov https://github.com/idryomov revived #500
https://github.com/ceph/teuthology/pull/500 recently, and pointed out
that we're missing the fact that the kernel task talks to gitbuilders as
well.
Looks like we have a bit more to do here after all...
https://github.com/ceph/teuthology/blob/master/teuthology/misc.py#L197
—
Reply to this email directly or view it on GitHub
https://github.com/ceph/teuthology/pull/580#issuecomment-126791075.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1733/
Test PASSed.

So good. I just noticed one tiny docs issue but I think we're good after that.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1735/
Test PASSed.


adding two lemmas about division

These are very minor lemmas, and I don't know how they should be named, but I think they should be in.
These came up when I was trying to record a video demonstrating proving the infinitude of primes in Lean. (Essentially following the mathlib proof.)
It comes to the step where you know p | fact N and p | fact N + 1, and you're trying to deduce p | 1. Without magically knowing that the relevant lemma is nat.dvd_add_iff_right in core, I challenge you to explain to somehow to find that lemma!
If we add these two lemmas, at least one can do the obvious thing:
#find _ ∣ _ → _ ∣ _ →  _ ∣ _

The idea is that this is a simplification of the second hypothesis. In fact you could make it a biconditional with the other hypothesis instead, resulting in the slightly peculiar d | m + n -> (d | m <-> d | n), but I like to think of dvd_add_iff_left as an inversion of dvd_add with one of its hypotheses. (As a general rule, if it can be biconditional it will be, in mathlib.)

I'm fine with adding a biconditional in the opposite direction.

Which do you mean? I think that it is better for d | m + n to be the LHS of a biconditional, because it is the more complex side so it is in line with our general principles for simp-like lemmas. For the backward biconditional I quoted I guess it could be either way, although it makes sense to keep m on the left since it was on the left to start with.

I mean nat.dvd_add_iff_left and nat.dvd_add_iff_left. These are their current forms:
theorem dvd_add_iff_left {a b c : α} (h : a ∣ c) : a ∣ b ↔ a ∣ b + c
theorem dvd_add_iff_right {a b c : α} (h : a ∣ b) : a ∣ c ↔ a ∣ b + c

And I also think the + should be on the LHS instead of the RHS.

Oh yes, I agree with you there.

Okay, I think this is saying we want lemmas
theorem XXX {a b c : α} (h : a ∣ c) : a ∣ b +c ↔ a ∣ b
theorem YYY {a b c : α} (h : a ∣ b) : a ∣ b + c ↔ a ∣ c

Unfortunately I don't understand the naming scheme well enough to name these.

They should be dvd_add_iff_left/right just as in Johannes's comment.

But -- that's what they are already called in core. I thought we would need new names?!

I don't think the core theorems require modification, the remark above is about the nat versions, which are in mathlib, I think

No, nothing is in mathlib. We have
protected theorem dvd_add_iff_right {k m n : ℕ} (h : k ∣ m) : k ∣ n ↔ k ∣ m + n := ...
protected theorem dvd_add_iff_left {k m n : ℕ} (h : k ∣ n) : k ∣ m ↔ k ∣ m + n := ...

in library/init/data/nat/lemmas.lean, and
  theorem dvd_add_iff_left {a b c : α} (h : a ∣ c) : a ∣ b ↔ a ∣ b + c := ...
  theorem dvd_add_iff_right {a b c : α} (h : a ∣ b) : a ∣ c ↔ a ∣ b + c := ...

in library/init/algebra/ring.lean.
This leaves me pretty confused about what you and Johannes are suggesting! I guess my best guess is we should have
  theorem dvd_iff_add_right {a b c : α} (h : a ∣ c) : a ∣ b + c ↔ a ∣ b := ...
  theorem dvd_iff_add_left {a b c : α} (h : a ∣ b) : a ∣ b + c ↔ a ∣ c := ...

for both [ring α] and for nat.
I'm not particularly confident I have my left and right correct here, nor that we really ought to change anything...


Add calculator component

In this milestone I did the following;

Designed the UI for a calculator component
Added a react component (calculator component)

Remove boilerplate that was created by the CRA (texts, images, and styles)
Adjust the design to match the provided wireframe


[production] APA Citations

Steps

Go to project: https://osf.io/r9pqe/?view_only=8be7e07f6c4a4b0aa21ba44c97a4608a
Go to Mendeley Add-on, choose format "American Psychological Association 6th Edition"
Copy citation for the last entry, "De Jong, K.P.,...."
Go to Son of Citation Machine with same information (http://old.citationmachine.net/index2.php) and generate APA 6th edition citation
Go to Mendeley Desktop and generate same citation

Expected
All citations would have the same format.
Actual
Citations generated by Mendeley desktop and Son of Citation Machine are the same:
De Jong, K. P., & Geus, J. W. (2000). Carbon Nanofibers: Catalytic Synthesis and Applications. Catalysis Reviews, 42(4), 481–510. http://doi.org/10.1081/CR-100101954
but citation generated by Mendeley Add-on on the OSF is different:
De Jong, K. P., & Geus, J. W. (2000). Carbon Nanofibers: Catalytic Synthesis and Applications. doi:10.1081/CR-100101954

Interesting. @lyndsysimon, when you get a moment. Thanks.

I'm fairly sure the issue here is that we're missing some attributes in the conversion between what Mendeley's API returns and the CSL-Data format.
This can be fixed by setting the appropriate keys in website.addons.mendeley.model#Mendeley._citation_for_mendeley_document.
It looks like the missing keys are: source, pages, issue, and volume.
Here is the API result for that object, when accessed from Mendeley's Research Catalog via their public API explorer:
{
  "title": "Carbon Nanofibers: Catalytic Synthesis and Applications",
  "type": "journal",
  "authors": [
    {
      "first_name": "KRIJN P.",
      "last_name": "DE JONG"
    },
    {
      "first_name": "JOHN W.",
      "last_name": "GEUS"
    }
  ],
  "year": 2000,
  "source": "Catalysis Reviews",
  "identifiers": {
    "isbn": "0161-4940",
    "issn": "0161-4940",
    "doi": "10.1081/CR-100101954"
  },
  "keywords": [
    "Carbon",
    "Carbon filaments",
    "Carbon nanofibers",
    "Carbon nanotubes",
    "Catalyst support",
    "Catalytic synthesis",
    "Filamentous carbon",
    "Gas storage",
    "Graphite"
  ],
  "pages": "481-510",
  "volume": "42",
  "issue": "4",
  "websites": [
    "http://www.tandfonline.com/doi/abs/10.1081/CR-100101954"
  ],
  "month": 11,
  "day": 30,
  "id": "d47b0015-2fec-3c6b-b091-1b2120defcec",
  "accessed": [
    2012,
    10,
    4
  ],
  "file_attached": false,
  "link": "http://www.mendeley.com/research/carbon-nanofibers-catalytic-synthesis-applications-3",
  "reader_count": 52,
  "reader_count_by_academic_status": {
    "Professor": 2,
    "Post Doc": 4,
    "Ph.D. Student": 9,
    "Researcher (at an Academic Institution)": 2,
    "Researcher (at a non-Academic Institution)": 1,
    "Student (Postgraduate)": 1,
    "Student (Master)": 5,
    "Student (Bachelor)": 2,
    "Doctoral Student": 2
  },
  "reader_count_by_subdiscipline": {
    "Engineering": {
      "Miscellaneous": 6,
      "Nanotechnology": 1
    },
    "Earth Sciences": {
      "Miscellaneous": 1
    },
    "Chemistry": {
      "Miscellaneous": 9,
      "Petroleum": 2,
      "Applied Chemistry": 1
    },
    "Materials Science": {
      "Miscellaneous": 4,
      "Plastics": 2
    },
    "Physics": {
      "Miscellaneous": 2
    }
  },
  "reader_count_by_country": {
    "United States": 2,
    "Ukraine": 1,
    "Netherlands": 1,
    "United Kingdom": 1
  },
  "group_count": 1,
  "abstract": "<snipped for brevity>"
}

You want to make it happen @lyndsysimon ? -- or you think good for an intern project?

Sorry - yes, it's a suitable intern task. It touches on a lot of things (OSF, addons, external APIs, citations, the CSL-JSON data format), but the change is a small one and there should be enough information above to keep the problem space small enough to be manageable.
@ticklemepierce reached out to me over chat, and I let him know that I'm happy to help with this if there are any major roadblocks.

:+1:


Update package.json with latest node-sass with windows fix

Using alpha instead of pre version of node-sass to have this plugin work on windows.  #54 is predated compared to this one.

Ah, I already just merged #54. It's released in 0.6.1. Does this solve your problem?

@joliss I was about to update the version again since the latest version has a fix we're interested in. Since its alpha release would you be ok with releasing a newer patch release?

alpha.1 has been tagged but not pushed to npm - see https://github.com/sass/node-sass/commit/a85b266e75faf15c138b9b56baa230a3a230ad84. If Adeel does decide to push it we can update broccoli-sass again.

(Closing for now; feel free to ping when you want me to push a new update.)

Sure thanks.


add interface xcvr info

model
serial number
dom

I am closing this task. We will discuss how to do that later on.


the p and g of "Mappings" is truncated in mapping table view

what do you mean?

the bottom of the letters are truncated:


react-native run-android crash

:react-native-billing:compileReleaseJava
/node_modules/react-native-billing/android/src/main/java/com/idehub/Billing/InAppBillingBridge.java:9: error: cannot find symbol
import com.anjlab.android.iab.v3.PurchaseInfo.ResponseData;
                                             ^
  symbol:   class ResponseData
  location: class PurchaseInfo
/node_modules/react-native-billing/android/src/main/java/com/idehub/Billing/InAppBillingBridge.java:344: error: cannot find symbol
        ResponseData responseData = details.purchaseInfo.parseResponseData();
        ^
  symbol:   class ResponseData
  location: class InAppBillingBridge
/node_modules/react-native-billing/android/src/main/java/com/idehub/Billing/InAppBillingBridge.java:344: error: parseResponseData() has private access in PurchaseInfo
        ResponseData responseData = details.purchaseInfo.parseResponseData();
                                                        ^
Note: /Users/serzn1/Desktop/Proj/smartbics-calc/node_modules/react-native-billing/android/src/main/java/com/idehub/Billing/InAppBillingBridge.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
3 errors

What can it be? It doesn't work on clear Awesome Project.
"react-native": "^0.36.0",

Same issue.

Same issue:
react-native 0.36.1
react-native-billing 2.1.0
~/rn_app/node_modules/react-native-billing/android/src/main/java/com/idehub/Billing/InAppBillingBridge.java:9: error: cannot find symbol
import com.anjlab.android.iab.v3.PurchaseInfo.ResponseData;
                                             ^
  symbol:   class ResponseData
  location: class PurchaseInfo
~/rn_app/node_modules/react-native-billing/android/src/main/java/com/idehub/Billing/InAppBillingBridge.java:344: error: cannot find symbol
        ResponseData responseData = details.purchaseInfo.parseResponseData();
        ^
  symbol:   class ResponseData
  location: class InAppBillingBridge
~/rn_app/node_modules/react-native-billing/android/src/main/java/com/idehub/Billing/InAppBillingBridge.java:344: error: parseResponseData() has private access in PurchaseInfo
        ResponseData responseData = details.purchaseInfo.parseResponseData();
                                                        ^
Note: ~/rn_app/node_modules/react-native-billing/android/src/main/java/com/idehub/Billing/InAppBillingBridge.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
3 errors
:react-native-billing:compileReleaseJavaWithJavac FAILED

FAILURE: Build failed with an exception.

The issue is caused by the update of android-inapp-billing-v3 library (https://github.com/anjlab/android-inapp-billing-v3) to version 1.0.34
Edit node_modules/react-native-billing/android/build.gradle and change
dependencies {
    compile 'com.facebook.react:react-native:+'
    compile 'com.anjlab.android.iab.v3:library:1.0.+'
}

to
dependencies {
    compile 'com.facebook.react:react-native:+'
    compile 'com.anjlab.android.iab.v3:library:1.0.33'
}

and it works again.

Argh, the wonders of not following semantic versioning. I'll review the PR asap.

Update to 2.1.1, and hopefully this will be fixed. Thanks to @cmiotto for his PR.


Support go language?

There is a project written in rust. It uses this package to store the .redb database. Is there any way I can read this file in go language? Or can I use the go language to call the redb package of rust?

Nope. Or at least I have not built anything to do that. You would need to build some FFI bindings in Go

Thank you for your reply, do you have any plans for this? I am a rust novice, and I can't spend a lot of energy learning it.

No, I don't. I may add Python support one day but do not plan to add any other languages

C bindings for redb would be a useful foundation for access from many other languages. Might be much easier to just ask the maintainers of the downstream tool to support exporting to JSON or similar, though.


Test Authentication is broken

TCTAuthTests >> #testAuthStateReady and TCTLoggedInTests >> #testMessageSending fail locally and on CI. The authState is authorizationStateWaitPassword after sending the auth code. The question is where we can get this password from ...

Here is some background information: https://core.telegram.org/api/auth#test-phone-numbers


Chat text with URL's?

I am looking to utilize something very much like this project, for retail virtual sales. The goal would be for a salesperson and a customer to be on a video chat where the salesperson would display items the customer is interested in. Then if the customer wishes to purchase an item, the salesperson would push them a purchase URL through the Snackbar chat.
Is there an existing function in the Snackbar library that automatically formats URL's so they are messaged as hyperlinks? I realize with the minimalist angle that Snackbar is created for this might be contrary to the intent...

Would something like this added in work? https://github.com/gregjacobs/Autolinker.js/

So I am now able to display the URL's locally for the DataTrack sender. I placed this in the ChatInput.tsx file.
// Render the message locally so the local participant can see that their message was sent.         enqueueSnackbar({message});
But when I am trying to push the message out to the remote users I cannot get this to appear correctly on their end. Since the localDataTrackPublication.track.send(message) call in the ChatInput.tsx file is enforcing the message to always be a string.
Here is what I see in the DataTrack.tsx file.
`import { useEffect } from 'react';
import { DataTrack as IDataTrack } from 'twilio-video';
import { useSnackbar } from 'notistack';
export default function DataTrack({ track }: { track: IDataTrack }) {
const { enqueueSnackbar } = useSnackbar();
useEffect(() => {
const handleMessage = (message: string) => enqueueSnackbar(message);
track.on('message', handleMessage);
return () => {
track.off('message', handleMessage);
};
}, [track, enqueueSnackbar]);
return null; // This component does not return any HTML, so we will return 'null' instead.
}
`
I am assuming this is where the enqueueSnackBar is being triggered when there are DataTrack elements to display for the remote users. Any suggestions as to how I can present this message as a clickable URL?

Hey @gregarican - Thanks for the question!
I think that the text that is sent over a DataTrack can be left as is. I don't think that it needs to be modified.
When the text is received, we can look for any URLs inside them, and then convert those URLs into  components. It's a little tricky to do, but I found a library that does all this for us. It's called react-linkify.
I was able to get this feature working with that library. First I installed it with npm i -S react-linkify @types/react-linkify. Then, I changed my DataTrack.ts file to the following (note: I had to also change the filename to DataTrack.tsx):
import React from 'react';
import { useEffect } from 'react';
import { DataTrack as IDataTrack } from 'twilio-video';
import { useSnackbar } from 'notistack';

import Linkify from 'react-linkify';

export default function DataTrack({ track }: { track: IDataTrack }) {
  const { enqueueSnackbar } = useSnackbar();
  useEffect(() => {
    const handleMessage = (message: string) =>
      enqueueSnackbar(
        <Linkify
          componentDecorator={(decoratedHref, decoratedText, key) => (

              {decoratedText}

          )}
        >
          {message}
        </Linkify>
      );
    track.on('message', handleMessage);
    return () => {
      track.off('message', handleMessage);
    };
  }, [track, enqueueSnackbar]);

  return null; // This component does not return any HTML, so we will return 'null' instead.
}

Thats it! The componentDecorator stuff that you see in there is needed to add the target="_blank" rel="noopener" attributes to the anchor element, which allows links to be opened in a new window (opening them in the same window would end the call).
Let me know how this works out for you! I'll close this issue for now, but please do let me know if you have any other questions!
Note: one downside of this approach is that the react-linkify repository looks like it may be abandoned. It hasn't been updated in a while, and it looks like there be some outstanding bugs. I didn't encounter any bugs myself, but it's something to keep in mind.

Thank you SO much for this! Works like a champ. I appreciate you taking the time to look at this.

Happy to help!

Please how can implement this. The chat feature. Will appreciate sharing the steps.

This project itself contains all of the particulars. You can review the source code to see how the Twilio API's DataTrack (remote and local) is implemented using Snackbar. It works quite well and has helped me get my head around how React works.


Adding a querystring example for List

I want to be able to have example of  List<string>  for FromQuery string.
I tried to use Swashbuckle.AspNetCore.Filters and created an issue there
@mattfrear has added the functionality Add examples to XML params that I would like to extend as soon as possible with a PR.
I was thinking something in the line of the following could work.
/// <summary>
/// GetByIds
/// </summary>
// <param name="Ids" example="[one,two,three]"></param>
public void GetByIds([FromQuery] List<string> ids)
{}

Would this work?

I like your idea to do a list [] rather than a delimiter |, I was thinking the same thing.
It would be worth looking through the XML spec to find out how to do multiple values for an XML attribute (if that is valid).
You will also need to get familiar with the OpenApi 3.0 spec and how multiple request querystring examples are specified (if that is possible). Try and get it working in https://editor.swagger.io/ before you start writing any code.

Ok cool thanks. I got little lost in specs and documentation 🤦♂
I'm not 100% I understand your question but in the specification for adding examples they say

"Note that arrays and array items support single example but not multiple examples."

So if I got that right I think there is only room for one XML example node like I have made working here

Other interesting doc is query paramters styles
Is this enough information to implement <param name="Ids" example="[one,two,three]"></param>  or is there something else I'm missing (I just use Swagger so what do I know 😆)?

Hi @mattfrear I prepared some code and unit tests for it (just to be able to discuss further) and tried to push to a new branch but I get 403. Do I need permission or am I doing something wrong?

Looks like you're making pretty good progress.
I'd suggest that for

Array of string
<param name="ByString" example="['one','two','three']"></param>

should be OK. Unless you wanted to escape the double quotes with " but that's not as readable.
It's up to @domaindrivendev to agree with what you're doing though, not me, as he is the owner of this repository.

any feedback on this @domaindrivendev?

Any update on this?  I'm very much looking forward to including this, but specifically for long[].
Also, could/would this support <returns example="['admin','user']">A string array of roles.</returns> ?

I'm also interested in using this, but for List<Guid>. Personally I don't have a strong preference between ' and ", I think the former looks better in the docstring whereas the latter looks better in the swagger GUI.

any feedback on this @domaindrivendev?

If someone puts together a reasonable PR for this and it doesn't add too much complexity to the code base, I'd be happy to merge it in

@domaindrivendev could you then comment on questions/design here above and in the PR draft. I can finish this soon if I know that I'm headed in the right direction...

In latest master, this is now possible with the following syntax for top-level parameters:
 /// <param name="tags" example='["foo", "bar"]'></param>
 [HttpGet]
 public IActionResult Get([FromQuery]List<string> tags)

Or the following for property-based parameters:
public class QueryParams
{
    /// <example>["foo", "bar", "blah"]</example>
    public List<string> Tags { get; set; }
}

Will be officially available in the upcoming 6.0.0 release, but in the meantime you can try it out by pulling down the lastest preview build from myget.org.

In latest master, this is now possible with the following syntax for top-level parameters:
 /// <param name="tags" example='["foo", "bar"]'></param>
 [HttpGet]
 public IActionResult Get([FromQuery]List<string> tags)

Or the following for property-based parameters:
public class QueryParams
{
    /// <example>["foo", "bar", "blah"]</example>
    public List<string> Tags { get; set; }
}

Will be officially available in the upcoming 6.0.0 release, but in the meantime you can try it out by pulling down the lastest preview build from myget.org.

In latest master, this is now possible with the following syntax for top-level parameters:
 /// <param name="tags" example='["foo", "bar"]'></param>
 [HttpGet]
 public IActionResult Get([FromQuery]List<string> tags)

Or the following for property-based parameters:
public class QueryParams
{
    /// <example>["foo", "bar", "blah"]</example>
    public List<string> Tags { get; set; }
}

Will be officially available in the upcoming 6.0.0 release, but in the meantime you can try it out by pulling down the lastest preview build from myget.org.

In latest master, this is now possible with the following syntax for top-level parameters:
 /// <param name="tags" example='["foo", "bar"]'></param>
 [HttpGet]
 public IActionResult Get([FromQuery]List<string> tags)

Or the following for property-based parameters:
public class QueryParams
{
    /// <example>["foo", "bar", "blah"]</example>
    public List<string> Tags { get; set; }
}

Will be officially available in the upcoming 6.0.0 release, but in the meantime you can try it out by pulling down the lastest preview build from myget.org.

Is there something that I'm missing here... I have xml comments included (as described here).
However, with a setup similar to the following:
/// <param name="ids" example='[]'>blah</param>
[HttpPost]
public IActionResult Post(List<int> ids)

The resulting example & default value within the swagger page is:
[
  0
]

The generated xml looks normal:
<member name="M:HedgeFox.Api.Controllers.ParsersController.PostInvestorFunds(System.Collections.Generic.List{System.Int32})">
 <summary> ... </summary>
  <param name="ids" example="[]">blah.</param>
</member>


chore: Added README.md

To quickly configure and use linter in VS Code Editor.

Oh, one thing I forgot -- I'm not sure if it needs to be in this document, but might be good to mention that Vale is also usable as a CLI tool, in case anyone doesn't use VSCode.

@spark-c / @sharat87 - Could you do a final review? I guess it's good to go.


CARGUS - The locations displayed as results on the search engine do not match the locations from scraper-UI and from the company's website

ENVIRONMENT:
url: https://peviitor.ro/
browser: Chrome
device: laptop
OS: Windows
Version: 10
STEPS TO REPRODUCE:
Open url in browser.
Type "cargus" in the serach bar.
Analyze the jobs' locations.
EXPECTED RESULTS:
The jobs' locations match the locations from scrapers-UI  and from the company's website.
ACTUAL RESULTS:
The Telesales executive job appears to be in Magurele, Bistrita-Nasaud, instead of in Magurele, Ilfov.
Attachments:

Fixed can you retest?

Retested ✅


fix(38312): Update dependencies as indicated by Snyk

Details

The original PR (created by Snyk automatically) had conflicts. As such, raising a new PR with those changes.
Fixed Issues

$ https://github.com/Expensify/App/pull/38311
$ https://github.com/Expensify/Expensify/issues/366633
$ https://github.com/Expensify/Expensify/issues/366623
PROPOSAL: N/A
Tests

Run npm install
Then run npm run storybook
Verify that the storybook opens and run fine.

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

Go to https://staging.new.expensify.com/docs/index.html and make sure it loads

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Ready now @yuwenmemon

Given the changes, I think it would be helpful for a C+ to help with the testing. The changes are mostly related to types.

@allroundexperts Friendly bump. And there're conflicts need to be resolved.

@allroundexperts Another friendly bump here!

Why does it have no QA steps or tests? We need to make sure storybook still works, right? For tests you can say you ran npm run storybook and for QA to go to the storybook and browse to a couple of components to make sure it does not throw and loads properly

Why does it have no QA steps or tests? We need to make sure storybook still works, right? For tests you can say you ran npm run storybook and for QA to go to the storybook and browse to a couple of components to make sure it does not throw and loads properly

Added.

@pecanoro This same error exists on main as well. I don't think this has to do with the version update. We can fix it in a follow up PR if you'd like.

@allroundexperts There're conflicts need to be resolved.

Ugh damn, I was waiting for the tests to finish running and I didn't merge, now we have conflicts, I am sorry!

No worries. Resolved the conflicts!

All tests passing. @pecanoro Good to merge!

Tested again and it seems to be working! Merging since @yuwenmemon is OOO for the whole week and we don't want more conflicts! Thank you everyone!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.4.62-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.4.62-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.4.62-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

I'm not sure if this is related or not, but the test steps failed when QA can't access https://staging.new.expensify.com/docs/index.html
@eh2077 @allroundexperts @pecanoro please could you take a look and see if you think of a fix

Checking this now @Julesssss

@Julesssss Is the deploy blocker link you shared is correct?

This is the error I get in console. It looks like the issue is with how we're deploying this. It's building fine locally. Do you know how we are deploying this currently?

@Julesssss Did you check if it was related to the deploy process? Since it's working locally, maybe it's related to that as @allroundexperts suggested

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.62-17 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Class implementation: DocumentFragment.

[ ] children
[ ] firstElementChild
[ ] lastElementChild
[ ] childElementCount
[ ] querySelector
[ ] querySelectorAll
[ ] getElementById

See tests in branch fragment

Looks like querySelector(All) methods should actually be part of the ParentNode trait.
https://developer.mozilla.org/en-US/docs/Web/API/ParentNode

Have added some additional tests to my fork of that branch, to make sure the scope of queries to the fragment is limited to the fragment itself and not the document it's appended-to.


Semantic coloring is sometimes corrupted

microsoft/vscode#96332

:tada: This issue has been resolved in version 2.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Auto-completion for import from '..' file address

It would be nice if editor provided auto completion for import from file names

This is on the plan for TS. see https://github.com/Microsoft/TypeScript/pull/9353


refactor(LinearAlgebra,RingTheory): Replace Fintype.card with Nat.card

This PR replaces a few occurrences of Fintype.card with Nat.card in the LinearAlgebra and RingTheory folders.

bors merge

bors r-

bors merge


Add custom LogMessageWaitStrategy startup timeout

For some long starting services like kafka+zookeper it could take more than 60 sec to start and configure. As currently there is no possibility to set it to some custom timeout I propose this change.

There exists a public withStartupTimeout in AbstractWaitStrategy. So I don't think there is a need for this ?

Yes, my bad. I missed that one, closing PR.


EPIC - Issues found during Apache KIE 10.0.0 release candidates verification

Many community members helped with verifying the artifacts for 10.0.0 release candidates [1]. Than you ALL for your involvement and dedication! As much as no hard blockers have been found at the moment, many small issues could be addressed to smooth things out a little bit. Here's a compilation of problems I found during my verification, together with issues that other people found during theirs.

drools-docs failed on a first run when trying to install Node.js 16 (EOL). We should not only upgrade Node.js to 20 (LTS) but also try and understand what is causing it to fail for the first time.
Extra argument -Dquarkus.native.additional-build-args=-H:-CheckToolchain needed when building kogito-apps on Arm-based MacBook Pro, with graalvm-jdk-17.0.12+8.1.
kie-tools build got stuck on a prompt from Angular about collecting analytics. We need to have this disabled by default.
kogito-images copying the entire local Maven repository (~/.m2/repository) inside Container images during build, causing build to fail for people with a large local Maven repository.
999-SNAPSHOT references found on disabled modules on<EMAIL_ADDRESS>(dead code)
Create and commit a per-repo list of files to be ignored by Apache RAT.
helm-docs is not listed as a requirement before building 10.0.0 from source.
Lots of [WARNING] Could not validate integrity of download from http://<IP_ADDRESS>/ when using maven-m2-repo-via-http during kie-tools build.
Make "Build instructions" and "How to verify" sections tied to a release. Those instructions will likely change from one release to the other.
✅ FIXED: ~Had to install 'requests<2.32.0' with python -m pip install 'requests<2.32.0' before building kogito-images, otherwise it didn't work.~ (Fixed for 10.1+ since kogito-images has been permanently moved to kie-tools).
✅ FIXED: ~999-SNAPSHOT references found on<EMAIL_ADDRESS>(Fixed for 10.1+ since kogito-images has been permanently moved to kie-tools)

[1] https://kie.apache.org/docs/community/verify/

For reference, here are the voting threads:
rc1: https://lists.apache.org/thread/x1q6yz6ybmb4ym6p16bjgcdksfn900sf
rc2: https://lists.apache.org/thread/t72b95d3q1qvcyd7lbqkrt8cdx2cgsp2

@tkobayas Can you help me understand this quote from https://lists.apache.org/thread/l7gx1wc1lfhkoxg1kwy2pzyp0nv9l2fl?
[x] No compiled archives bundled in source archive. <- it includes some
What are the "compiled archives" you found on our sources? Thanks!

@tiagobento
Under incubator-kie-10.0.0-rc2-sources directory,
$ find . -name "*.jar" -exec sh -c 'unzip -l "{}" | grep -q "\.class" && echo {}' \;
./incubator-kie-drools/drools-verifier/drools-verifier-drl/src/test/resources/org/drools/verifier/model.jar
./incubator-kie-drools/drools-compiler/src/test/resources/KAModelTest.jar
./incubator-kie-drools/drools-compiler/src/test/resources/primespoc.jar
./incubator-kie-drools/drools-compiler/src/test/resources/eventing-example.jar
./incubator-kie-drools/drools-compiler/src/test/resources/JarWithSourceFiles.jar
./incubator-kie-drools/drools-test-coverage/test-compiler-integration/src/test/resources/billasurf.jar
./incubator-kie-drools/drools-test-coverage/test-compiler-integration/src/test/resources/only-jar-pojo-not-kjar-no-kmodule-1.0.0.jar
./incubator-kie-drools/drools-test-coverage/test-compiler-integration/src/test/resources/testEnum.jar
./incubator-kie-drools/drools-legacy-test-util/src/test/resources/billasurf.jar
./incubator-kie-kogito-apps/.mvn/wrapper/maven-wrapper.jar
./incubator-kie-kogito-runtimes/.mvn/wrapper/maven-wrapper.jar
./incubator-kie-kogito-runtimes/quarkus/integration-tests/integration-tests-quarkus-gradle/integration-tests-quarkus-gradle-project/gradle/wrapper/gradle-wrapper.jar

These files contain .class files.
I thought that test resources are acceptable. Should they be changed? (e.g. generate the jars during maven build)

@tkobayas Hi! Just reminding you of the existence of this EPIC. I'm trying to keep it up-to-date, but if you find something that is not here, please feel free to edit it's description directly! Thank you! 😊


Now selectively loads planners and does not fail when it can't find one.

Ok, this looks good. Adding.


SyntaxError: invalid regexp group

I'm trying to ship the standalone editor and it is not coming up in FF or Edge due to the following regular expressions:
https://github.com/Microsoft/vscode/blob/52306b406d9231a0667c758e536bd177e5570180/src/vs/base/browser/ui/menu/menu.ts#L23-L24
I will push a workaround to the standalone/0.16.x branch, but can you please tweak your regular expression such that it works also on Edge and FF? Thanks!

Marking as web as this is something we should revisit eventually when supporting other browsers.
cc @sbatten

@bpasero Why did the importance level drop? This blocks the release of the editor...

@alexandrudima my understanding is that you pushed a workaround for this issue (try-catch) that unblocks the release of the editor. For example, I can see releases that date to after this issue was created:

I think we should use important labels for stuff like data loss etc. but not if a workaround is installed. Nevertheless I agree we should fix this asap.

I didn't do 0.17.0

Yeah you are right, sorry for that :heart:


Provide different pretrained backbones in DetectoRS

hi everyone,
Currently, I only see DetectoRS with ResNet-50 in this repo. Can you provide us the model and config files for ResNet-101, ResNeXt-101 like in the related paper?
Because the code of joe-siyuan-qiao Github is different from this repo with regards to DetectoRS.
Thank you.

Hi, we are providing pretrained r101 and x101 checkpoints in process.

Hi, we are providing pretrained r101 and x101 checkpoints in process.

I hope to see that. Thank you and your team.

I hope to see that. Thank you and your team.

Hi, we are providing pretrained r101 and x101 checkpoints in process.

Hi,
Is there an estimated release date? I will be doing some research on industrial automation soon, so it would be great to know when ResNeXt 101 64x4d backbone will be ready, since it is the one that performed best.
Thanks for your effort!


Fix nil pointer error in seed-lifecycle controller

How to categorize this PR?

/area control-plane
/kind bug
What this PR does / why we need it:
A nil pointer Panic can occur in seed-lifecycle  controller in case GardenletReady condition is not set on seed.
This PR fixes nil pointer issues in the seed-lifecycle controller.
Which issue(s) this PR fixes:
Fixes #7235
Special notes for your reviewer:
Release note:

An issue causing a nil pointer error in the `seed-lifecycle` controller is fixed.

/cherry-pick release-v1.63

/cherry-pick release-v1.64


Update configuring-sdn-interface.md

Docs Build status updates of commit 08c25eb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/SDN/articles/configuring-sdn-interface.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


reorder of modules

I get the same error running the script after reordering the modules as instructed. Thanks.

I don't understand what this issue is referring to. Make sure to re-open it with more information if you're still struggling with this!


postfix changes the domain to the primary one and thus the cert failed

postfix changes the domain to the primary one and thus the cert failed
Context

When I run  posttls-finger example2.com i can see that
posttls-finger: < 220 2.0.0 Ready to start TLS posttls-finger: mail.example2.com[<IP_ADDRESS>]:25: subjectAltName: mail.example1.com posttls-finger: mail.example2.com[<IP_ADDRESS>]:25 CommonName mail.example1.com
So it looks like incoming connects with example2.com will be redirected to mail.example1.com  by the function subjectAltName.  And thus the sender cert example2.com ist tls-handshaked against example1.com which failed.
I've setup 2 domains example1.com example2.com, having same ip, but different MX-Records. Certs create with certbot. Certification for exampl1.com - the primary is working properly. Mailboxes from example2.com are responding and working fine - but only if accepting the security-exception.
`
dig -t MX exampel1.com
example1.com.	86400	IN	MX	100 mail.example1.com.
dig -t MX example2.com
example2.com.	5365	IN	MX	100 mail.example2.com
server:/etc/postfix# grep virtual_mailbox_domains main.cf
virtual_mailbox_domains = /etc/postfix/vhost
server:/etc/postfix# cat /etc/postfix/vhost
example2.com
example1.com
Expected Behavior

Accepted certs from various letsencrypt domains.
Actual Behavior

Possible Fix

Steps to Reproduce

Your Environment

Amount of RAM available:
Mailserver version used:
Docker version used:
Environment settings relevant to the config:
Any relevant stack traces ("Full trace" preferred):

There can be only 1 certificate. If you want to use multiple host names  then the certificate should contain multiple hostnames in the certificate.

Okay - I've learned the keyword is SAN = Subject Alternate Name = one single cert for multiple domains.


Add property for when item was added to database

1 - Launch
2 - CoO
2.1 - Dawning
3 - Warmind
4 - Forsaken
4.1 - Festival of the Lost
This should be in it's own separate season.json

https://github.com/delphiactual/d2-seasons


Fixed cmd/task/list panic; cmd/dashboard server env var; more validation

closes #363
closes #361

latest commit make view ignore case


Cannot find the boost library

Dear all:
I currently trying to use ck-caffe to download caffe on my mali-GPU. After downloading the necessary components, I use the command
ck install package:lib-caffe-bvlc-opencl-clblast-universal --env.DISABLE_DEVICE_HOST_UNIFIED_MEMORY=ON --env.CK_HOST_CPU_NUMBER_OF_PROCESSORS=2    to download Caffe.
But it seems that ck-caffe is trying to find Boost Library in a wrong directory:
I have download Boost in my own preferred location:

However, whenever I run the above mentioned command, ck tries to find the boost in the location
/usr/lib and gives me following error message:

I have tried to change the environment variable with
 export BOOST_INCLUDEDIR=$HOME/Documents/SummerResearch/boost_installation/include/
 export BOOST_ROOT=$HOME/Documents/SummerResearch/boost_installation

However, ck is still trying to find boost using the directory  /usr/lib
so I tried to get around the problem through soft-link by setting
sudo ln -sf /home/odroid/Documents/SummerResearch/boost_installation/include/boost/ /usr/lib/boost

so now, ck install could find the boost, but it cannot find certain boost_library, giving me the error message:

and I am sure that I have the required library in the directory
/home/odroid/Documents/SummerResearch/boost_installation/lib

Could you please give me some help? Thanks!

@XiaoMaol , Hello, It's nice to know that you are using ck-caffe with mali GPU because I'm doing so :D
I faced your problem some days ago, and I worked around to overcome with this problem as follow:

sudo apt-get install build-essential g++ python-dev autotools-dev libicu-dev libbz2-dev libboost-all-dev
Go to boost homepage and download the lastest boost library (v1.64 as I remember).
./boostrap.sh --prefix=/usr/local
Build it with command: ./b2
Final install it: sudo ./b2 install

And when you install ck-caffe, the program will realize that you have 2 boost libraries on your system, so let's choose manually built version (v1.64 in this case) and bingo :) Hope this help
I have installed ck-caffe on Odroid Xu4 which running ubuntu 16.04. I wonder how to install optimized blast version for mali GPU because when I chose  blast for mali GPU and built caffe but failed. @psyhtest , Would you help me with this case? And I also have one more question that how can I use ck-caffe with float16, will it improve inference time? I'm intent on running YOLO  for real time object detection using mali GPU and ck-caffe :)

First of all, @XiaoMaol @dohai90, it's nice of you both to use CK-Caffe. Thanks for your interest! :)
@XiaoMaol It's a bit weird that CK didn't offer to install Boost when it failed to find it in the system path (/use/lib) but perhaps it was a partial installation. As @dohai90 noted, it is not sufficient to just download Boost - you need to build it. Unfortunately, it's a bit of a pain to do so. Fortunately, CK automates this as well!
Please try the following sequence of steps:
$ ck pull repo:ck-math
$ ck rm env --tags=lib,boost
$ ck install package:lib-boost-1.64.0
$ ck install package:lib-caffe-bvlc-opencl-clblast-universal \
  --env.DISABLE_DEVICE_HOST_UNIFIED_MEMORY=ON \
  --env.CK_HOST_CPU_NUMBER_OF_PROCESSORS=2

Does this resolve your issue?

@dohai90, please try building Caffe w/ CLBlast with the above flags. I suspect your failure relates to this workaround not being enabled. If this doesn't help, please open a separate issue and provide more information.
We don't yet support building Caffe with FP16, although the OpenCL branch already supports it. I'll open an enhancement request.
It's cool you want to run YOLO! Have you already converted it to Caffe? Have you considered YOLO v2 as well? Really curios to hear about your results!

Dear @psyhtest and @dohai90,
Thank you so much for the help, I can currently find the boost Library now!
I have successfully build caffe, and now I can move to the stage to configure caffe and python. Currently, I have some issues in configuring, but I will try to fix it myself first before making another post asking for help. So do not close this thread yet. Thanks! :)

Hey @dohai90, thank you so much for giving me advice! and I am so glad to hear that you are doing real time object detection using Mali.
Hey @psyhtest, thank you so much for your help as well. Currently, I finally have successfully download Caffe! :)
Here is the picture:

@XiaoMaol Great to hear this worked for you!
P.S. Wow! Your Odroid (XU4?) board has the OpenCL driver of revision 14.0, whereas the latest one can download from the ARM Mali drivers' page is 12.0...

By the way, in the cases, when "correct" version of dependency such as Boost is installed in an unusual path, it is possible to detect it first (before installing Caffe via CK) while giving CK extra paths to search libraries like this:
$ ck detect soft:lib.boost --search_dirs={ROOT dir of correct boost}
and then continue installing Caffe via CK
Another note - rather than calling ./caffe device_query, you can also use CK front-end for Caffe (we are trying to unify AI API):
$ ck run program:caffe --cmd_key=query_gpu_opencl
Hope it's of any help and thanks again for your interest!

And just one more thing. Another alternative is to install Boost using CK package:
$ ck list package:boost
$ ck install package:lib-boost-1.64.0
and then install Caffe ...

I get similar error of finding boost library when I use the command
$ ck install package:lib-caffe-bvlc-opencl-libdnn-clblast-universal \
  --target_os=android24-arm-v7a \
  --env.DISABLE_DEVICE_HOST_UNIFIED_MEMORY=ON  \
  --env.CK_HOST_CPU_NUMBER_OF_PROCESSORS=2

the error message is
CMake Error at /usr/share/cmake-3.2/Modules/FindBoost.cmake:1201 (message):
  Unable to find the requested Boost libraries.

  Boost version: 1.64.0

  Boost include path:
  /home/*****/CK-TOOLS/lib-boost-acl-1.64.0-llvm-android-ndk-5.0.300080-android24-arm-v7a-32/install/include

  Could not find the following static Boost libraries:

          boost_thread
          boost_filesystem

  Some (but not all) of the required Boost libraries were found.  You may
  need to install these additional Boost libraries.  Alternatively, set
  BOOST_LIBRARYDIR to the directory containing Boost libraries or BOOST_ROOT
  to the location of Boost.

the boost include path in error message is CK-TOOLS subdirectory. I check this directory and I find only 7 files in folder install/lib as follows
libboost_chrono.a
libboost_prg_exec_monitor.a
libboost_program_options.a
libboost_system.a
libboost_test_exec_monitor.a
libboost_timer.a
libboost_unit_test_framework.a

so I use the command
ck install package:lib-boost-1.64.0-acl --target_os=android24-arm-v7a
to rebuild this boost but not more file.
is there anything wrong?

@Lmy0217 You are using a wrong package package:lib-boost-1.64.0-acl. It's a special version I prepared to use with the ARM Compute Library. Please try:
$ ck rm env --tags=lib,boost,android24-arm-v7a
$ ck install package:lib-boost-1.64.0  --target_os=android24-arm-v7a
$ ck install package:lib-caffe-bvlc-opencl-clblast-universal  --target_os=android24-arm-v7a \
  --env.DISABLE_DEVICE_HOST_UNIFIED_MEMORY=ON \
  --env.CK_HOST_CPU_NUMBER_OF_PROCESSORS=2

it's successfully installed, thanks. @psyhtest


Remove infinispan-jboss-marshalling from server

https://issues.jboss.org/browse/ISPN-10591
Creating this is as a separate PR from https://github.com/infinispan/infinispan/pull/7388 to isolate any failures

@gustavonalle https://github.com/infinispan/infinispan/pull/7391/commits/2184bff02703bb8775bf490816bb4ead4c6c99e9 Unifies the three protostream transcoders and makes it more like the JBossMarshallingTranscoder.
Protostream text/object transcoders are now needed in core so that a server without remote-query can still transcode stored protostream entries based upon the SerializationContext initialized from the embedded configuration.
The reason for unifying the three classes, was to allow simple overriding of the SerializationContext in the remote-query ModuleLifecycle.

@gustavonalle 2184bff Unifies the three protostream transcoders and makes it more like the JBossMarshallingTranscoder.

Don't see any issues with this

@ryanemerson There are bunch of failures in org.infinispan.client.hotrod.HotRodClientNearCacheJmxTest.ThreadLeakChecker is this related?

@ryanemerson There are bunch of failures in org.infinispan.client.hotrod.HotRodClientNearCacheJmxTest.ThreadLeakChecker is this related?

They're on master as well:
https://ci.infinispan.org/job/Infinispan/job/master/1468/#showFailuresLink
I think https://github.com/infinispan/infinispan/commit/22950ba2026914b4ed6e98b93edd73ad680d6334 introduced them

@ryanemerson Looks good to me!
One question though: which module in the source tree will be testing the server components with JBM in the classpath?

One question though: which module in the source tree will be testing the server components with JBM in the classpath?

My intention is to add a integrationtests/jboss-marshalling module, which will test the server and client with jboss-marshalling. I was going to add this in a follow up PR with the changes required to remove jbmar from the client.

Integrated into master, thanks @ryanemerson !


test voting

What happened?
see title
How to reproduce
see title
Relevant log output
No response
Which version are you running?
beta
Diagnostics file

[X] I have attached a diagnostics file

Additional information
No response

/vote

/vote

/vote

/check-vote

/vote


test: new test case for renaming JS Object

Description

[!TIP]
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!IMPORTANT]
🟣 🟣 🟣 Your tests are running.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12491383429
Commit: 28a1a5a891667edc7367c655b3c9e8a429514857
Workflow: PR Automation test suite
Tags: @tag.JS
Spec: ``
Wed, 25 Dec 2024 08:50:11 UTC

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[x] No

Summary by CodeRabbit

New Features

Introduced a new test suite to validate renaming behavior of JavaScript objects, ensuring focus remains on the current tab.
Added a new method to rename JavaScript objects via the context menu in the JavaScript Editor.
Added a new property to reference the list of JavaScript objects in the JavaScript Editor.

Bug Fixes

Addressed an issue where focus shifted to another tab during the renaming of a JavaScript object.

/ci-test-limit-count run_count=20 update_snapshot=true specs_to_run=cypress/e2e/Regression/ClientSide/JSObject/renameJSObjectIssue38207.ts

/ci-test-limit-count run_count=20 update_snapshot=true specs_to_run=cypress/e2e/Regression/ClientSide/JSObject/RenameJSObjectIssue38207.ts

/ci-test-limit-count run_count=20 update_snapshot=true specs_to_run=cypress/e2e/Regression/ClientSide/JSObject/RenameJSObjectBug38207_spec.ts runId=12491412689


Serial port setup: baud_rate/8/N/1 doesn't work when uploading examples to Arduino Uno rev2

I'm getting gibberish on serial port.
I've uploaded examples to my Arduino Uno rev2 board via cargo +nightly run --example uno-serial and cargo +nightly run --example uno-adc. I've played with several baud_rates (switched uno-serial.rs example from 57600 to 9600). I cannot get the correct setup to retrieve the data. The upload process is correct and other examples (uno-blink.rs) are working correctly.
Also, code from Arduino IDE behaves correctly in terms of Serial port communication.

I don't have any immediate idea what might be wrong ... Here's a few questions, maybe we can narrow it down a bit?

Do the TX and RX leds show any activity?  Especially, does TX indicate that the program is sending data as it should?
What program are you using to connect to the serial console on your host?
Modify the serial example to continously send some data, then cycle through baudrates on your host.  Do you, at any point, see either the output or some gibberish?

I'm getting gibberish on serial port.

Ugh, reading is hard; just noticed this ... In that case, this is most likely a baudrate mismatch of some sort.  What program are you using on the host to read from the serial console?

Thanks! You are right, there were baud rate mismatch. I was able to RX/TX correctly at 19200, despite setting baud rate in code to 9600. With the rate in the code 57600, I was able to connect at 115200. So basically it was always doubled rate. When I've submitted the issue, I've tried only lower baud rates, so wasn't able to find correct one.
I believe there is some issue causing this. I'm happy to help fix it, but need some pointers where to look at.

Hm, I think I found something:  Please flash a test program, power off the arduino entirely, turn it back on and try again.  Will this lead to using the correct baudrate?
Could you also try adding the following patch?

diff --git a/avr-hal-generic/src/serial.rs b/avr-hal-generic/src/serial.rs
index 280f92da1cf1..677ba3841d91 100644
--- a/avr-hal-generic/src/serial.rs
+++ b/avr-hal-generic/src/serial.rs
@@ -57,6 +57,8 @@ macro_rules! impl_usart {
                 let brr = CLOCK::FREQ / (16 * baud) - 1;
                 self.p.[<ubrr $n>].write(|w| unsafe { w.bits(brr as u16) });

+                self.p.[<ucsr $n a>].reset();
+
                 // Enable receiver and transmitter but leave interrupts disabled.
                 self.p.[<ucsr $n b>].write(|w| w
                     .[<txen $n>]().set_bit()

If any of the above helps, here's what I suspect:  Arduino firmware sets the U2Xn bit in its serial driver which doubles the configured baudrate.  This bit isn't currently cleared in avr-hal because it should be disabled by default.  But maybe in some weird circumstances it might have stayed enabled (or was set by the bootloader?) so you got the behavior you observed.  The above patch would fix this by properly disabling the bit every time.

Reading into this a bit more, it seems we might want to enable U2Xn as well:

You should be aware that the Arduino software sets the U2X bit, so the correct UBRR value is 16.  This results in a "closer" 115200bps bit rate (2.1% off), which is why it was done.  If you use 8 without UX2 set, you'll get 3.7% error IN THE OTHER DIRECTION.  The combined error is more than the ~5% that Async can easily tolerate.

(Arduino Forum)

Additionally, the above post links to this workaround in Arduino Core:
  // hardcoded exception for 57600 for compatibility with the bootloader
  // shipped with the Duemilanove and previous boards and the firmware
  // on the 8U2 on the Uno and Mega 2560. Also, The baud_setting cannot
  // be > 4095, so switch back to non-u2x mode if the baud rate is too
  // low.
  if (((F_CPU == 16000000UL) && (baud == 57600)) || (baud_setting >4095))
  {
    *_ucsra = 0;
    baud_setting = (F_CPU / 8 / baud - 1) / 2;
  }

Not sure if we should add that ... It is specific to arduino boards and might be entirely wrong for non-arduino usecases.  OTOH without it, we might see more baudrate mismatch problems.

Please flash a test program, power off the arduino entirely, turn it back on and try again. Will this lead to using the correct baudrate?

I've trurned it off, wait 10+ seconds, and plugged it back. It didn't help.

If any of the above helps, here's what I suspect: Arduino firmware sets the U2Xn bit in its serial driver which doubles the configured baudrate.

Looks like this is the case. I've applied the path you provided and it works as expected.

Additionally, the above post links to this workaround in Arduino Core
This workaround is exactly for 8U2 serial chip which I have on Arduino Uno rev2. Nowadays, most common is rev3, which have different chip.

Looks like this is the case. I've applied the path you provided and it works as expected.

Great to hear, I'll apply this patch properly this evening (hopefully)!

This workaround is exactly for 8U2 serial chip which I have on Arduino Uno rev2. Nowadays, most common is rev3, which have different chip.

Okay, maybe you can do some tests to see how unstable our current settings are?  E.g. if you try using 115200 baud, does it work reliably?

115200 with patch applied is totally unreliable, I receive broken data.
115200 without patch (57600 set in the code, 2*57600 = 115200 in terminal) is reliable, I can send and read received data.

Ok, at least that's in line with what I'd expect after reading about the Arduino implementation ...

I've pushed commit 7caed3a995e2 ("generic: serial: Fix U2Xn not being reset") to fix your original problem.  I'd keep this issue open, though, for discussing the other baudrate mismatch topics ...

Let's close this issue here and continue the baudrate topic in #80 where I've started to outline possible solutions.


Add device plugin for host devices

Add device plugin for host devices under /dev.

document please.


Add load balancer access logs for security

Merged to template infra. Discussed with @lorenyu and task is considered complete. May cause temporary error in deployment pipelines due to name changes. terraform move module.service.aws_s3_bucket_policy.bucket_pol module.service.aws_s3_bucket_policy.access_logs fixes terraform state.


long-llm run for more than 1 epoch

If we following the script setting of long-llm, the parameter num_train_epoch is set to 1, it will give out really significant improvment over the original model. However, if we change the paramter to larger than 1 ( i've tried 2, 3). The resulting model is total garbage. The first picture shows the prediction of some prompt using the model being trained for only 1 epoch. The second picture shows the same prompt's prediction using the model with 3 epochs. Something is not right here, as i don't believe more epochs will lead to dramatically worse result.

In addition, i've tried the following:

train the lora adapter based on the original model for 1 epoch
merge the adapter back to the original model, call it model 1
train another lora adapter based on model 1 for 1 epoch also
merge back the adapter to model 1, call it model 2
evaluate both model 1 and model 2, model 1 shows really good result compare to original base model, whereas model 2 is also a garbage, spitting out nonsense, repetitive results ( put the picture down below)
Does anyone know why this happens? All other parameters remain the same for all the experiments. Seems like this long-llm script is only working on ONLY 1 epoch setting, weird.

Really appreciate if someone could provide some insight on this, thanks in advance.

This is a weird issue. I'll try it myself very soon. Could you please share your training log? Is the loss for more than 1 epoch normal?

This is a weird issue. I'll try it myself very soon. Could you please share your training log? Is the loss for more than 1 epoch normal?

Hi i overwrote the log with that 1-epoch model's training log, but if you try the following setup, i believe you could reproduce the error:

export PYTORCH_CUDA_ALLOC_CONF=expandable_segments:True
export CUDA_VISIBLE_DEVICES=0,1,2,3,4,5,6,7
export NCCL_BLOCKING_WAIT=0
export NCCL_DEBUG=INFO
export OMP_NUM_THREADS=1
output_name=qlora-llama3_chat-gpt_longalpaca_redpajama5000-unsloth
output_name=l3_8b_1epoch_8gpu_t1
unsloth/bin/torchrun
--master_addr localhost
--master_port 6667
--nnodes 1
--node_rank 0
--nproc_per_node 8
train.py
--data_root data/long-llm
--output_dir model/$output_name
--model_name_or_path /mnt/cpfs-data/mashiyao/MODEL/LLaMa3-Instruct
--train_data "long-llm:gpt/one_detail_book.train.64K.json long-llm:gpt/one_detail_paper.train.64K.json long-llm:gpt/multi_detail_book.train.json long-llm:gpt/multi_detail_paper_short.train.json long-llm:gpt/multi_detail_paper_long.train.json long-llm:gpt/bio_book.train.json long-llm:longalpaca/train.json long-llm:redpajama/train.json[5000]"
--max_length 81920
--group_by_length
--rope_theta 200e6
--attn_impl flash_attention_2
--gradient_checkpointing
--use_reentrant True
--learning_rate 5e-5
--num_train_epochs 2
--save_only_model
--save_strategy epoch
--logging_steps 5
--bf16
--lora_tune
--lora_extra_params embed_tokens
--load_in_4_bit
--chat_template llama-3

Also, i wanna ask if this training method is able to scale to 70b llama3 instruct model using the same hyper-parameter setting?

I think it would work. Please report your result here if you would like to have a try :)

This is a weird issue. I'll try it myself very soon. Could you please share your training log? Is the loss for more than 1 epoch normal?

@namespace-Pt Hi, have you tried finetuning in this way and encounter the same issue?


AES-256-GCM not available

Since the new update, I can not run the loki storage server due to the failure in crypto_aead_aes256gcm_is_available() function. Maybe it is due to the incompatible CPU (which worked fine till now). I suggest you revert this commit to sustain the backward compatibility or find a solution.
Describe the bug
loki-storage wont start since the new update: "AES-256-GCM is not available on this CPU"
To Reproduce
run loki-launcher or loki-storage-server
Desktop (please complete the following information):

Device: VPS
OS + Version: Debian 10
Release Version or Github commit hash: https://github.com/loki-project/loki-storage-server/commit/330581b0d455581528169dc3413b8756fd40185e

Can you copy a cat /proc/cpuinfo here?  Not supporting AES suggests it is a very old model, but it could also be something in the VPS layer not properly passing through instructions.

Based on cpuinfo, your CPU is advertising its supported instructions of 14 year old, late generation Pentium 4 (family 15, model 6 = Pentium 4 Cedar Mill).  It's not actually such a CPU because the CPU clockspeed (2.4GHz), cache (16MB), and number of cores don't match.
This looks like an ISP issue: they are providing a virtual environment that says the CPU only supports instructions that were supported on a 14-year old CPU.  This is a terrible KVM configuration, and terrible for performance (aside from the compatibility issue here): the CPU most likely supports various modern instructions but the KVM environment is preventing them from being used by telling the OS that the CPU is 14 years old.

Hmmm... Is there a possible solution for this? Or must I Change my VPS provider?

In theory it might be possible to rebuild libsodium with the feature support hard-coded to enabled.  I don't know if it will work, but it might.
A better solution is to ask your ISP to improve their KVM configuration; what they are offering here seems pretty crappy.

They are cheap 🙈
Will ask their support. Thanks for now.

It was problem with virtualization. Everything works fine now.

Thought this was an interesting project and attempted to start a service node, but I am also having this issue, though my VPS processor flags do support AES.
Describe the bug
oxen-storage server won't start, giving error [error] [main] AES-256-GCM is not available on this CPU
To Reproduce
run ./oxen-storage <IP_ADDRESS> 22021 --lmq-port 22020 --log-level error --oxend-rpc-ip <IP_ADDRESS> --oxend-rpc-port 22023
or
systemctl restart oxen-storage-server
Server Specs (please complete the following information):
Device: VPS
OS + Version: Ubuntu 18.04 Bionic
Release Version or Github commit hash: Storage Server 2.0.8
cat /proc/cpuinfo Output designated below:
processor	: 0
vendor_id	: GenuineIntel
cpu family	: 6
model		: 44
model name	: Westmere E56xx/L56xx/X56xx (Nehalem-C)
stepping	: 1
microcode	: 0x1
cpu MHz		: 2400.084
cache size	: 4096 KB
physical id	: 0
siblings	: 1
core id		: 0
cpu cores	: 1
apicid		: 0
initial apicid	: 0
fpu		: yes
fpu_exception	: yes
cpuid level	: 11
wp		: yes
flags		: fpu de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 syscall nx lm constant_tsc nopl cpuid tsc_known_freq pni ssse3 cx16 sse4_1 sse4_2 x2apic popcnt aes hypervisor lahf_lm pti
bugs		: cpu_meltdown spectre_v1 spectre_v2 spec_store_bypass l1tf mds swapgs itlb_multihit
bogomips	: 4800.16
clflush size	: 64
cache_alignment	: 64
address sizes	: 40 bits physical, 48 bits virtual
power management:

Any idea what I could ask the VPS provider to focus on, or a way to resolve this problem?

@jagerman Any ideas on what could be causing the test/detection of AES to fail here?
@MartinJakomin Maybe you can show me your new cat /proc/cpuinfo?

Any ideas on what could be causing the test/detection of AES to fail here?

That's a bit odd: the CPU being advertised there (Nehalem-C) should support the needed AES instructions, but it isn't being advertised in the CPU flags.  Possibly a VPS setting controlling what gets passed through?


xemm - incomplete history output

Describe the bug

Upon checking filled trade event and doing history --verbose command bot unable to show the complete output expected.

Steps To Reproduce

create strategy using cross_exchange_market_making
a. select your maker_market (my case binance)
b. select your taker_market (my case ascendex)
select your maker and taker trading pair (my case avax-usdt)
finish up the prompts then start strategy
watch-out for filled trades and do history --verbose command

Screenshots

history command fails to show both filled trades

both trades captured (trades csv, logs and sqlite)

Release version

dev-1.0.0

                "branch": "development",
                "commit": "2e61c1721daf65a48044050b26bad2e372ebb329",
                "date": "2021-12-15T13:16:04Z",

Attachments

config, logs, sqlite and csv

xemm.zip

Is the expected output that it should show a higher number of trades?

@sisco0 I think the screenshot already shows the history --verbose but its missing the ascendex side, clearly the user use another command ctrl + s after that to show that the output stops there and the history is incomplete (without ascendex).

If I understand correctly the number of buy orders is shown as zero and it should be one. Is that the issue that we are facing?

https://user-images.githubusercontent.com/54516858/146846013-b48102d9-d3b7-4088-9a00-a1061a0f3496.mov

here is an example of both exchanges showing when using history --verbose
also note that history command doesn't need more than 1 day to get them both showed on output, if both exchanges has fill orders then it must have both exchanges on the history output.

I understand now, the history is not showing the full list of exchanges when using history command (without the --verbose).


Chai and specs

This contains the conversion of should to Chai, cleanup of some typeof specs, and additional specs to increase code coverage. Two bugs I came across and fixed are as follows:

When following a link specified in knownOptions, but the link definition wasn't actually returned as part of the initial OPTIONS call would attempt to make a request with no href or method (It would use an empty object as the definition {})
The defaultAdapter method didn't work since the value of _defaultAdapter was being attached to the defaults hash outside the halonFactory

Finally, before npm test or npm run coverage are executed, a quick build of halon is run to make sure you never run into a situation where src has changed, but lib has not.

Closing because these are merged as part of #25


Why does @model build a declaration instead of a value?

Hello Turing,
I'm curious about the design decision to make @model return a declaration instead of a value. For example, turing.ml has this example:
@model gdemo(x, y) = begin
  # Assumptions
  σ ~ InverseGamma(2,3)
  μ ~ Normal(0,sqrt(σ))
  # Observations
  x ~ Normal(μ, sqrt(σ))
  y ~ Normal(μ, sqrt(σ))
end

In Soss.jl I would write this as
gdemo = @model (x, y) begin
  # Assumptions
  σ ~ InverseGamma(2,3)
  μ ~ Normal(0,sqrt(σ))
  # Observations
  x ~ Normal(μ, sqrt(σ))
  y ~ Normal(μ, sqrt(σ))
end

We can think of Soss's @model as being "anonymous", similar to an anonymous function. I see a few advantages to the latter approach:

It's easy to add a name with myModel = @model...
Models can be inlined. For example, in the Soss counterpart to sample(gdemo(1.5, 2), SMC(1000)), gdemo could be replaced with @model... code
It's very natural in a context where models are "first class". One of the goals of Soss is to allow swapping out, @model... in place of (for example) Normal()

This makes me wonder, was having @model be a declaration a conscious design choice, or was the alternative not discussed? What benefits do you see from this approach? Is there any possibility of this changing at some point, or has it become too strong a dependency?

I will close this issue for now. As for using models as drop-in for distributions, I think a separate API can be used to create a distribution from the model generator. I will think more about this after I move the Turing compiler to DynamicPPL and try to make Turing and Soss interoperable.


🔒 Patch the Flask-CORS vulnerability (CVE-2024-6221)

User Need
As a Operations Engineer team member
I want to patch the Flask-CORS vulnerability (CVE-2024-6221) in all our affected repositories
so that we can prevent potential security breaches and unauthorised access to our private network resources
Functional Requirements (What):

[x] Identify all repositories using Flask-CORS version 4.0.1 or earlier
[ ] Update Flask-CORS to version 5.0.0 in all affected repositories
[ ] Test the updated repositories to ensure functionality is maintained

Non-Functional Requirements (How):

[ ] Ensure the patching process doesn't cause extended downtime
[ ] Verify that the Access-Control-Allow-Private-Network CORS header is not set to true by default after the update
[ ] Conduct security scans post-update to confirm the vulnerability has been addressed

Acceptance Criteria:

[ ] All identified repositories are updated to Flask-CORS version 5.0.0
[ ] No instances of the vulnerability are detected in security scans
[ ] All systems maintain their intended functionality after the update

Notes:
Vulnerability details:
CVE-2024-6221 | Severity: HIGH | Package: Flask-Cors | Fixed Version: 5.0.0
Link to release: Flask-CORS 5.0.0
The vulnerability in corydolphin/flask-cors version 4.0.1 allows the Access-Control-Allow-Private-Network CORS header to be set to true by default, without any configuration option. This behaviour can expose private network resources to unauthorized external access, leading to significant security risks such as data breaches, unauthorized access to sensitive information, and potential network intrusions.
Multiple repositories within our organization may be affected. A thorough audit and patching process is required to mitigate this security risk across all our projects.

You can watch the currently impacted sites using this search
https://github.com/orgs/ministryofjustice/security/alerts/dependabot?q=is%3Aopen+flask-CORS


Refactor torque units

After the addition of the ACIM, it is not so clear cut that q axis current = torque. So we should abstract it so that controller can work with just torques.
Proposal:

controller works in torque units (you can put kT=1.0 Nm/A if you don't care about correct units)
motor provides a effective_torque_limits() function, so that controller can antiwindup correctly.
motor is responsible to convert the torque setpoint from controller into currents. This will depend on motor type (PMSM, ACIM, Gimbal, etc), and also subject to inverter limits (modulation limit, power limits)

Resolved with PR #426 - Change motor control input from A to Nm.


[Table] Non scrollable overflow content

Description
after fix all-time horizontal scroll in table, the issue https://github.com/vexip-ui/vexip-ui/issues/273 is actual now
Validations

[X] Ensure this issue neither a bug report nor a feature proposal.
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that descript the same thing to avoid creating a duplicate.

Please view this sfc.


Tidy up dir names

rename kg_emerging_viruses -> kg_covid_19
changed zhou_host_proteins -> pmid32194980_zhou_host_proteins per @callahantiff's  convention

Did you also want to change the projectKey in the sonar-project.properties file to match? if so, I'm not 100% certain, but I think changes will also need to be made in the sonar web app. We can consult Luca on that last point if you end up making that change.

@LucaCappelletti94, any advice here? Feel free to push changes to this PR

@justaddcoffee I'm on it!

I think that renaming the repository made Travis-CI lose the connection with it, and sonar went down as well since it does not receive reports from Travis. We could have a short call on Zoom or Hangout for patching it up, I'm available for a bit here on hangout.

I think that renaming the repository made Travis-CI lose the connection with it, and sonar went down as well since it does not receive reports from Travis. We could have a short call on Zoom or Hangout for patching it up, I'm available for a bit here on hangout.

@justaddcoffee - if you are busy I am happy to hop on.

@callahantiff I think we will need someone with admin access on the repository, I don't know who has them.

@callahantiff I think we will need someone with admin access on the repository, I don't know who has them.

Justin gave me that permission last week 😄

Perfect! I'm waiting for you on Hangouts then!

Perfect! I'm waiting for you on Hangouts then!

I'm on, but I don't see you. Maybe I have the wrong link? Would you chat to me on Gitter please?

Hi @justaddcoffee! We are currently stuck for the repository permissions. Do you have time tomorrow? Now here is getting pretty late and I'll head to bed.
Happy quarantine everyone!

@LucaCappelletti94 no problem - I dropped into the hangout, but can't talk or hear you guys. Anyway, we can pick it up tomorrow. I gave @callahantiff some permissions she requested, but let me know if you need more/others

@LucaCappelletti94 no problem - I dropped into the hangout, but can't talk or hear you guys. Anyway, we can pick it up tomorrow. I gave @callahantiff some permissions she requested, but let me know if you need more/others

Thanks @justaddcoffee! Maybe we can both drop in tomorrow, I'm enjoying learning more about Travis and @LucaCappelletti94 pypy package.

Hi! Do you have time for a hangout call to patch up Travis and Sonar?

Yes, name a time
On Tue, Mar 24, 2020 at 8:49 AM Luca Cappelletti<EMAIL_ADDRESS>wrote:

Hi! Do you have time for a hangout call to patch up Travis and Sonar
https://hangouts.google.com/call/K-4vQrWwc4D3RU24pCC-AEEI?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Knowledge-Graph-Hub/kg-covid-19/pull/29#issuecomment-603320966,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABEWJ5MFNTLTLG4KOZU3K3RJDJALANCNFSM4LSEAXFQ
.

--
Justin Reese, Ph.D.
Berkeley Bioinformatics Open-source Projects
Lawrence Berkeley National Laboratory
phone<PHONE_NUMBER> |<PHONE_NUMBER>

I am already available if you are!

great, bit.ly/justaddcoffee then
On Tue, Mar 24, 2020 at 8:51 AM Luca Cappelletti<EMAIL_ADDRESS>wrote:

I am already available if you are!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Knowledge-Graph-Hub/kg-covid-19/pull/29#issuecomment-603322408,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABEWJ5SWKUX2ER4JNPI7ALRJDJILANCNFSM4LSEAXFQ
.

--
Justin Reese, Ph.D.
Berkeley Bioinformatics Open-source Projects
Lawrence Berkeley National Laboratory
phone<PHONE_NUMBER> |<PHONE_NUMBER>

I can't make it, meeting at 10am. Do you mind telling me later what the issue was?

Several different problems were preventing CI from running - in case you're curious:

pip couldn't install bmt>0.1.0 (a dependency for KGX) for some reason - seems to be a pip bug? We ended up having to fork KGX and change requirements.txt there. (@deepakunni3 have you seen this issue before?)
unit tests were running all downloads and all transforms, which now takes a long while
a few mypy failures

All checks are running and passing now in master

I can't make it, meeting at 10am. Do you mind telling me later what the issue was?

Several different problems were preventing CI from running - in case you're curious:

pip couldn't install bmt>0.1.0 (a dependency for KGX) for some reason - seems to be a pip bug? We ended up having to fork KGX and change requirements.txt there. (@deepakunni3 have you seen this issue before?)
unit tests were running all downloads and all transforms, which now takes a long while
a few mypy failures

All checks are running and passing now in master

@justaddcoffee  - thank you so much for the update and information! I'm glad to hear that the build is passing now.

@justaddcoffee - thank you so much for the update and information! I'm glad to hear that the build is passing now.

I spoke too soon
Working on this

Closing this PR - we can rename this later


The scraper does not show that the Senior Project Management Specialist job was posted twice

ENVIRONMENT:
https://admin.peviitor.ro/
Browser: Chrome
Device: Laptop
OS: Windows 10
STEPS TO REPRODUCE:
Enter url in browser
In go to "https://admin.peviitor.ro/" and click to jobs for "Goodyear"
Click on Senior Project Management Specialist" job tab on "Catre Job "option
EXPECTED RESULTS:
The page shows the full description of the job
ACTUAL RESULTS:
The page shows the same full description of the previous job announcement
See below the screenshots
Attachment:
Page from Validator for Goodyear

Daca intri pe siteul lor de cariere o sa le gasesti pe ambele.

Daca te uiti pe fiecare job o sa vezi ca au doua id-uri complet diferite

Nu sunt duplicate


IGAPP-1139: Change footer seperation line color to #B1B1B1

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword IGAPP.

@randowha on a minor note: We try to prefix all our commits with the issue number, in your case this would be for example:
IGAPP-1139: Change footer seperation line color to #B1B1B1

would

Looks like your merge somehow failed :/ Also, Why did you revert the usage of our textColor constant back to a magic value?

There is no color #b1b1b1 yet. Would you like me to use the already existing textDecorationColor (#c7c7c7) or to create a new color constant?

Looks like your merge somehow failed :/ Also, Why did you revert the usage of our textColor constant back to a magic value?

There is no color #b1b1b1 yet. Would you like me to use the already existing textDecorationColor (#c7c7c7) or to create a new color constant?

Hmmm, good question, we are now using that color in two places. My usual rule of thumb is to make it a constant after three repeats but we can also make one here already?

Sorry for all these commits, but because of merging main into my branch in the middle of the feature, I find myself unable to squash them together. If sb is able to resolve that, feel free


Issue with Unicode literals

https://github.com/sanskrit-coders/jyotisha/blob/d7a6643c314c520c0662f2be4dd3f56c98c70761/jyotisha_tests/spatio_temporal/data/Chennai-1981-12-23.json#L316
Not sure what introduced this.

Adding canonical interval names in sanskrit introduced it. Should go away if that file is regenerated.

Got it - I think your computer has an older version of sanskrit_data package. Please update. Your json updates are introducing such escaped characters.

ok thought so, some version issue. Have updated to sanskrit-data-0.7.8 now. Fixed


Follow up on removing the option to select a population in the bbr_plot_lambda_distributions() function

Since the previous functions that feed into this function only allow a single population, this one shouldn't have an option to select the population. Users can filter down if they need before passing it to the function. Confirm with @joethorley before preceding with this change.

Yes please proceed


REQUEST: New membership for KunWuLuan

GitHub Username
@KunWuLuan
Requirements

[X] I have reviewed the community membership guidelines
[X] I have enabled 2FA on my GitHub account
[X] I am actively contributing to 1 or more Koordinator subprojects
[X] I have two sponsors that meet the sponsor requirements listed in the community membership guidelines
[X] I have spoken to my sponsors ahead of this application, and they have agreed to sponsor my application
[X] I have verified that my sponsors are a reviewer or an approver in at least one OWNERS file within one of the Koordinator GitHub organizations (excluding the contributor-playground)
[ ] OPTIONAL: I have taken the Inclusive Open Source Community Orientation course

Sponsor 1
@eahydra
Sponsor 2
@zwzhang0107
List of contributions to the Koordinator project
pull requests:

https://github.com/koordinator-sh/koordinator/pull/969
https://github.com/koordinator-sh/koordinator/pull/920
https://github.com/koordinator-sh/koordinator/pull/918
https://github.com/koordinator-sh/koordinator/pull/916
https://github.com/koordinator-sh/koordinator/pull/908
https://github.com/koordinator-sh/koordinator/pull/906
https://github.com/koordinator-sh/koordinator/pull/873
https://github.com/koordinator-sh/koordinator/pull/775

/lgtm
Welcome!

/lgtm
Welcome!
@hormes @FillZpp

Invitation sent, please check your email. Welcome to the community!

Thanks, it's been great working with you!


modify_signature fails if activeParameter is nil

The modify_signature which is used in the mappings for sig_next, sig_prev, param_next, and param_prev fails if neither of SignatureHelp or SignatureInformation has an activeParameter field.
This happens because modify_signature will always call Signature:modify_active_param which attempts to performs arithmetic operations on either self.activeParameter or self.signatures[current_sig_index].activeParameter.

Fixed by PR