fix: clickhouse https url

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
#12040
exactly the same issue as https://github.com/loyd/clickhouse.rs/issues/58
Need to test it with Clickhouse Cloud

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

martin@Lius-MacBook-Pro ~ % ./clickhouse client --host mpbg0njbua.us-west-2.aws.clickhouse.cloud --secure --password 'XXXXXXXXXXXXX'
ClickHouse client version <IP_ADDRESS> (official build).
Connecting to mpbg0njbua.us-west-2.aws.clickhouse.cloud:9440 as user default.
Connected to ClickHouse server version 23.8.1 revision 54465.

ClickHouse server version is older than ClickHouse client. It may indicate that the server is out of date and can be upgraded.

clickhouse-cloud :) CREATE table demo_test(
    user_id Int32,
    target_id String,
    event_timestamp DateTime64,
)ENGINE = ReplacingMergeTree
PRIMARY KEY (user_id);

CREATE TABLE demo_test
(
    `user_id` Int32,
    `target_id` String,
    `event_timestamp` DateTime64
)
ENGINE = ReplacingMergeTree
PRIMARY KEY user_id

Query id: 22153db8-99b2-4316-97c1-0f6ee61c99b1

Ok.

0 rows in set. Elapsed: 0.204 sec.

clickhouse-cloud :) select user_id, count(*) from default.demo_test group by user_id limit 10

SELECT
    user_id,
    count(*)
FROM default.demo_test
GROUP BY user_id
LIMIT 10

Query id: 1c1c5acd-b057-4eb1-9d88-79d4327968ce

┌─user_id─┬─count()─┐
│      66 │       1 │
│      94 │       1 │
│      69 │       1 │
│      89 │       1 │
│      41 │       1 │
│      53 │       1 │
│      46 │       1 │
│      50 │       1 │
│       4 │       1 │
│      24 │       1 │
└─────────┴─────────┘

10 rows in set. Elapsed: 0.005 sec.

clickhouse-cloud :)

martin@Lius - MacBook - Pro risingwave % psql - h localhost - p 4566 - d dev - U root psql (15.3, server 9.5.0) SSL connection (
  protocol : TLSv1.3, cipher : TLS_AES_256_GCM_SHA384,
  compression : off
) Type "help" for help.dev => CREATE TABLE user_behaviors (
  user_id INT,
  target_id VARCHAR,
  target_type VARCHAR,
  event_timestamp TIMESTAMP,
  behavior_type VARCHAR,
  parent_target_type VARCHAR,
  parent_target_id VARCHAR,
  PRIMARY KEY(user_id)
) WITH (
  connector = 'datagen', fields.user_id.kind = 'sequence',
  fields.user_id.start = '1', fields.user_id.end = '100',
  fields.user_name.kind = 'random',
  fields.user_name.length = '10', datagen.rows.per.second = '50'
) FORMAT PLAIN ENCODE JSON;
CREATE_TABLE

dev => CREATE MATERIALIZED VIEW bhv_mv AS
SELECT
  user_id,
  target_id,
  event_timestamp
FROM
  user_behaviors;
CREATE_MATERIALIZED_VIEW

dev => CREATE SINK bhv_clickhouse_sink
FROM
  bhv_mv WITH (
    connector = 'clickhouse', type = 'append-only',
    force_append_only = 'true', clickhouse.url = 'https://mpbg0njbua.us-west-2.aws.clickhouse.cloud:8443',
    clickhouse.user = 'default', clickhouse.password = 'XXXXXXXXXXXXX',
    clickhouse.database = 'default',
    clickhouse.table = 'demo_test',
  );
CREATE_SINK
dev =>

It worked with Clickchouse Cloud


Add .vscode/launch.json file?

Adding a .vscode/launch.json file to all of the projects might make it easier to run the files. Currently you can run files by pressing the Run button above the main method, but for single file projects it doesn't work to press F2.
We would need to see if there is an option for the mini-example.dart and challenge.dart since they are both in the same folder. Maybe putting them in different folders.
What should the launch.json config file contain? Here is a sample from the Null Safety examples. We wouldn't use the experimental flag, though.

Also, should we add directions to Chapter 1 for adding a launch.json file in your projects.

Chapter 1 now has instructions for adding launch.json.


Scrobble eMusic cloud

Would great if you could support eMusic's cloud streaming service
http://www.emusic.com/music-cloud/

Behind a paywall :( @mrbootle do you have any JS experience? We have documentation on our wiki.

Just saw this… sorry :-) No JS experience sadly. I'll ask them directly

You can open player by clicking track number


Could not read script '...\node_modules\react-native-turbo\android\turbo-android-dependencies.gradle' as it does not exist.

Description
Hello,
I'm on Windows 11 with this Android Studio version :
Android Studio Jellyfish | 2023.3.1
Build #AI-233.14808.21.2331.11709847, built on April 12, 2024
Runtime version: 17.0.10+0--11572160 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Windows 11.0
GC: G1 Young Generation, G1 Old Generation
I have this error  when I use the command "yarn dev:android" :
Could not read script '...\node_modules\react-native-turbo\android\turbo-android-dependencies.gradle' as it does not exist.
I have also this warning :
Warning: SDK processing. This version only understands SDK XML versions up to 3 but an SDK XML file of version 4 was encountered. This can happen if you use versions of Android Studio and the command-line tools that were released at different times.
Steps to reproduce

Git clone
yarn install
yarn dev:android

Snack or a link to a repository
https://github.com/software-mansion-labs/react-native-turbo-demo/
React Native Turbo version
1.0.0
React Native version
0.73.6
Platforms
Android
JavaScript runtime
None
Workflow
None
Architecture
None
Build type
None
Device
None
Device model
No response

Works on ubuntu

I'm also facing similar issue on windows, does this mean it doesn't work on Windows?


Upgrade AppwriteSDK and support for 0.12

Fixed via https://github.com/appwrite/demo-todo-with-svelte/pull/37


MudButton OnClick/Href not triggered when MudSelect is open

Bug type
Component
Component name
MudSelect, MudButton
What happened?
With MudSelect open, OnClick and Href will not work unless MudButton is clicked twice!
The first click is the action to close MudSelect, in which case the ripple effect should not work.
Href does not work either, but MudNavLink Href works in the same state, so the behavior does not seem to be unified.
Expected behavior

MudButton OnClick should work even when MudSelect is open.
MudButton Href behavior should also be consistent with MudNavLink behavior.
Even if the behavior of the MudButton when MudSelect is open is in spec, the ripple effect should not work.
If MultiSelection="False", MudSelect is closed when an item is selected, which is acceptable, but if MultiSelection="True", it remains open, which requires two button clicks, an inconvenient behavior.

Reproduction link
https://try.mudblazor.com/snippet/GOmwuZbnHvywtNdr
Reproduction steps

Click MudSelect to open the item.
If MudButton is clicked while MudSelect is open, MudSelect is closed and the ripple effect of the MudButton is displayed, but OnClick is not triggered.
Href instead of OnClick does not work while  MudSelect is open.

== Comments ==

MudButton Href does not work, but MudNavLink Href does work while  MudSelect is open.

Relevant log output
No response
Version (bug)
6.0.13
Version (working)
No response
What browsers are you seeing the problem on?
Chrome, Microsoft Edge
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

The first click is to close the menu, because when would you know the user is done selecting?
In your use case the user would have to re-open the menu every time they want select multiple values (which is more clicks).
However, if you want to close the menu after the user selected a value.
Just close it like this?
<MudText>@currentCount</MudText>

<MudButton Color="Color.Primary" Variant="Variant.Filled" OnClick="IncrementCount">Click me</MudButton>

<MudSelect T="string" Label="Select" >
    <MudSelectItem T="string" Value="@("1")">aaa</MudSelectItem>
    <MudSelectItem T="string" Value="@("2")">bbb</MudSelectItem>
    <MudSelectItem T="string" Value="@("3")">ccc</MudSelectItem>
</MudSelect>

<MudSelect @ref="multiMudSelect" SelectedValuesChanged="MultiMudSelect_ValuesChanged" T="string" Label="Select" MultiSelection="true">
    <MudSelectItem T="string" Value="@("1")">aaa</MudSelectItem>
    <MudSelectItem T="string" Value="@("2")">bbb</MudSelectItem>
    <MudSelectItem T="string" Value="@("3")">ccc</MudSelectItem>
</MudSelect>

@code {
    private MudSelect<string> multiMudSelect;
    private IEnumerable<string> options;

    private int currentCount;

    private void IncrementCount()
    {
        currentCount++;
    }

    void MultiMudSelect_ValuesChanged(IEnumerable<string> selectedValues)
    {
        options = selectedValues;
        multiMudSelect.CloseMenu(false);
    }
}

What I want is a little different.
I don't want the menu to close on first click, I want the button event to fire even when the menu is open.

Have you tried increasing the z-index of the button to something big like : 999 ?
<MudButton style="z-index: 999;" Color="Color.Primary" Variant="Variant.Filled" OnClick="IncrementCount">Click me</MudButton>

I set "z-index: 6;" and now I can click on the button.
I am wondering if this mechanic will cause other problems.
For example, the behavior of the dialog does not seem to be affected.

I don't expect any issues as long as you don't exceed MudBlazor's default z-indexes:
https://mudblazor.com/customization/default-theme#mudtheme-zindex
And even if you did, you could always change the default values in the theme if I'm not mistaken.

Its by design. The same behavior with autocomplete, menu etc. Select has an overlay when you open it so on your first click it hits the overlay and close select.

And it some kind of duplicate #4774.

I understand that it is by design.
I would consider accepting this behavior.
This issue may be closed.

should be closed


fix(template/typescript-webpack): import/resolver

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] The changes are appropriately documented (if applicable).
[x] The changes have sufficient test coverage (if applicable).
[x] The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
Fixes (reverts?) PR https://github.com/electron-userland/electron-forge/pull/2139.
The solution is to include "plugin:import/typescript" which includes these rules and some more:
/**
 * Adds `.jsx`, `.ts` and `.tsx` as an extension, and enables JSX/TSX parsing.
 */

const allExtensions = ['.ts', '.tsx', '.d.ts', '.js', '.jsx'];

module.exports = {

  settings: {
    'import/extensions': allExtensions,
    'import/external-module-folders': ['node_modules', 'node_modules/@types'],
    'import/parsers': {
      '@typescript-eslint/parser': ['.ts', '.tsx', '.d.ts'],
    },
    'import/resolver': {
      'node': {
        'extensions': allExtensions,
      },
    },
  },

  rules: {
    // analysis/correctness

    // TypeScript compilation already ensures that named imports exist in the referenced module
    'import/named': 'off',
  },
};

The PR submitter didn't have it enabled in their config so they added it manually.
This was already merged in https://github.com/electron-userland/electron-forge/pull/2048 and the import/resolver section does nothing.

CI failed


File delete doesn't work

I can't delete uploaded files. I have uploaded file:
 (doesn't work pdf preview but that's another topic)
When click trash icon, file disappears (looks correct), then save form and see message (updated succesfully). But when back to form editing - everything is back in place.
Doesn't work neither multipleFile nor one file form type.
"encore/laravel-admin": "1.4.x-dev"

look here #666

It works! Thanks!


Pass MF2 WG syntax tests

Handle unknown-function error.
Format zeros correctly.

Zeros formatting in another issue.


Enso Interop could support pattern matching Java Enums

Currently, if I try to pattern match a Java enum:
package foo;

import org.graalvm.polyglot.Value;

public enum Foo {
    A, B, C;

    public static Foo generate(int i) {
        if (i == 0) return A;
        return B;
    }
}

from Standard.Base import all

polyglot java import foo.Foo

convert enum_value =
    case enum_value of
        Foo.A -> "aaa"
        Foo.B -> "bbb"
        Foo.C -> "ccc"

main =
    IO.println (convert Foo.C)
    IO.println (convert (Foo.generate 0))
    IO.println (convert (Foo.generate 1))

I get
C:\NBO\repr\PolyProject\src\Main.enso: error: The name `Foo.A` could not be found.
Aborting due to 1 errors and 0 warnings.
Execution finished with an error: Compilation aborted due to errors.

I can convert the Enso code to:
from Standard.Base import all
import Standard.Base.Errors.Common.No_Such_Method

polyglot java import foo.Foo

convert enum_value =
    if enum_value == Foo.A then "aaa" else
        if enum_value == Foo.B then "bbb" else
            if enum_value == Foo.C then "ccc" else
                Nothing

main =
    IO.println (convert Foo.C)
    IO.println (convert (Foo.generate 0))
    IO.println (convert (Foo.generate 1))

and then it works:
ccc
aaa
bbb

Nonetheless, it would be nice if the Java enums were also supported in regular pattern matching. It may be a bit surprising to users that if works but case does not.
Of course this is lower priority, because most of our users won't be using Java polyglot as much and even less will care about enums. But it may be worth to improve this at some point.

Another small issue related to this:
As you can see the error message C:\NBO\repr\PolyProject\src\Main.enso: error: The name Foo.A could not be found. - it does not have any indication of the position of the error in the file. In my small example it is easy to find it, but in a big library file it may be problematic when it is unclear where the error is located.


Ability to open folders

Describe Your Suggestion
Hiya, I'd like to be able to open a folder in VPK edit like a vpk file. I really don't want to pack a folder as a VPK then open it just to use the viewer tools.

This is mostly a duplicate of #72 but I'm going to leave it open since it's a bit different

This is pretty cool, took like a half hour to implement lol
I'm not doing anything fancy like watching the folder for changes or letting users modify the contents yet, but its a start


L10s Ultra Gen 2 not showing in HA - Multiple Devices

Describe the bug
I have a regular L10s Ultra and I see a device entry for that one. I recently bought a Gen 2 and updated the plugin to v2v.b16 which should support the Gen 2 but it is not appearing as a device.
To Reproduce
Have a L10s Ultra already in the account, then add an L10s Ultra Gen2
Expected behavior
A device entry for the Gen 2 should be there
Additional Information (please complete the following information)

L10s Ultra Gen2
v 4.3.9_1037
2024.10.2
Map support
No logs specific to this

Are multiple robots supported at this point? I can't see any documentation about it.

Looks like I manually had to add the device going through the wizard, wasn't sure if I had to do that or not and also wasn't sure if I did it the whole thing would break. Can be closed :)


cargo.sh: make rustfmt and clippy available

These are used by run_tests.sh.  It doesn't work in nix-shell without
these available.

Thank you. I apparently did not notice that I used my generally installed versions.

Unfortunately, ./run_tests.sh fails for me locally with this applied.
+ ./cargo.sh clippy
   Compiling proc-macro2 v1.0.7
   Compiling unicode-xid v0.2.0
   Compiling syn v1.0.13
   Compiling libc v0.2.66
    Checking cfg-if v0.1.10
   Compiling memchr v2.3.0
   Compiling serde v1.0.104
    Checking lazy_static v1.4.0
error[E0463]: can't find crate for `std`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0463`.
error: could not compile `proc-macro2`.
warning: build failed, waiting for other jobs to finish...
error[E0463]: can't find crate for `core`

error[E0463]: can't find crate for `core`

error: aborting due to previous error

error: aborting due to previous error

For more information about this error, try `rustc --explain E0463`.
For more information about this error, try `rustc --explain E0463`.
error[E0463]: can't find crate for `std`

error: aborting due to previous error

error: could not compile `cfg-if`.
warning: build failed, waiting for other jobs to finish...
error: could not compile `lazy_static`.
warning: build failed, waiting for other jobs to finish...
For more information about this error, try `rustc --explain E0463`.
error: could not compile `libc`.
warning: build failed, waiting for other jobs to finish...
error[E0463]: can't find crate for `core`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0463`.
error: could not compile `unicode-xid`.
warning: build failed, waiting for other jobs to finish...
error[E0463]: can't find crate for `std`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0463`.
error: could not compile `serde`.
warning: build failed, waiting for other jobs to finish...
error[E0463]: can't find crate for `std`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0463`.
error: could not compile `memchr`.
warning: build failed, waiting for other jobs to finish...
error[E0463]: can't find crate for `std`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0463`.
error: could not compile `syn`.

To learn more, run the command again with --verbose.

Any idea why and how to make it find the std library?
I am reverting the clippy part for now. @alyssais

I fixed it now by adding logic to enter a pure nix-shell.
I hope it works for you, @alyssais !


How to handle older versions of packages?

This is not really an issue with biocrnpyler but rather a question about how we would want to manage versioning.
Since the last pull request, we decided to start updating biocrnpyler versions (updated from 0.2 -> 0.2.1). With every new pull request (depending on the size of changes), we should ideally be updating versions.
The problem is that jupyter notebook continues to use the older version (because the older installed version still exists in site-packages). Possible solutions:

Forcefully delete all older versions when installing newer version - We would need to write setup.py in a way that does this.?

Overwrite the current version with the later version?

Use a package versioning manager : For example: https://pypi.org/project/pbr/

Some related discussion : https://www.python.org/dev/peps/pep-0440/
I am not sure what is the best solution here...
@murrayrm @zoltuz any comments?

Something like this could solve the problem:
new workflow

A feature/bugfix starts on a separate branch in your repo, where you test it
When you are ready you open a PR onto the development branch (doesn't exist yet)
After review, it gets merged into  development

new deployment

When a handful of changes accumulated on development we merge them to master
merge commit on master triggers a script, which tags the commit version number (adjust setup.py as well), and uploads the new code to the pip database
with pip install the user upgrades the code

user interface
The user can pip install from the pip repo
pip install biocrnplyer

or directly from GitHub
pip install git+git://github.com/BuildACell/BioCRNPyler.git

I did this on goggle colab:

As you can see you can select branches. (I think you can even select single commits or PRs)

I do think this would solve the problem, and I've been wanted to switch having a master branch and development branch separately.

What does pip install do that is different than setup.py install in terms of versioning? How is it ensured that the latest version will be used - because on the user's site-packages there will be two different egg files with the two versions?

Probably nothing, but pip uninstall does purge the package, while there's no setup.py uninstall (unless we write one). source
About the versioning: our workflow and the code itself are still changing a lot until we figure them out, I don't think we will have a reliable versioning schema.
Probably the best workflow for the users right now:
first time
mkdir biocrnplyer
git clone https://github.com/BuildACell/BioCRNPyler.git biocrnplyer
cd biocrnplyer
pip install --user .

getting an update
pip uninstall biocrnpyler
git pull upstream/master
pip install --user .

Got it! pip uninstall does the trick then :)


Missing highlights for clojure keywords

Description
Clojure keywords (eg :keyword) seem to be missing color. This does not seem to be the case with a raw symbol like 'my-symbol.
Behavior
Expected behavior
Keywords have some color. Treesitter sees them as @symbol
Screenshots

Configuration
I am using AstroNvim, although I have observed this issue without it.
-- in user/init.lua
config = {
  -- ...
  colorscheme = "nightfox",
  plugins = {
    init = {
        ["EdenEast/nightfox.nvim"] = {}
    },
  },
}

Nightfox only defines the colors for highlight groups. Treesitter is the one that does the syntax highlighting. Your issue is with the treesitter parser for clojure.
I am also unable to reproduce your issue. @symbol is defined as preproc. By default that is defined as pink.

Do you have a reproducible example?

I tried a completely bare neovim config and it seems to work. Looks like the problem is with Astro somehow, so I'll close this and tinker some more.


Add CodeLingo Tenets

It looks like this is a Go project. This pull request will add a codelingo.yaml file with some common Go Tenets that CodeLingo will use to review Pull Requests to this repository.

Apologies! Looks like we have a bug....

@Daanikus It bothered me. Make some offline tests before running the program, and do it carefully.


added my name to guestbook.md

Hello Sean,
I've added my name to guestbook.md
Have a nice day!
Marco

Thank you so much!


Parent event listeners before clients (formerly Async Events)

Currently, events are dispatched synchronously.  This could cause problems by allowing the user to see intermediate states (e.g. in the middle of a bulk operation) or by doing unfriendly things in an event handler (spending a lot of time, sending new operations).  We should dispatch them async by default, like normal DOM events.
However, when CRDTs internally listen for each other's events, they should usually listen synchronously, so that they can finish what they are doing before users have a chance to inspect the state.

The easy solution to this, which I believe all of our current code follows, is that child events are not exposed to outsiders except by the parent.  So the parent can easily ensure that it updates its own state before emitting its own version of the event.
Also, weird intermediate states can be avoided by only emitting events when you are not in such a state.  The new Change events respect this (they are emitted only when some other event is emitted, not on every message).


fixes 400 bad request

Recently we were getting 400 from coveralls when sending our reports.
Turns out the implementation that writes the request’s body content manually does not work anymore.
We switched it for a way simpler implementation that works again.

I guess the solution is even easier: just check #177
(sorry read this a bit too late...)


Jesse: Watch seoexpertrakib.com

Jesse requests the watch of the watch_keyword seoexpertrakib\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

seoexpertrakib\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Approved by cocomac in Charcoal HQ


Add XWiki to "Who is using Testcontainers"

@vmassol merged, thank you!
Happy to have XWiki as a user, you provide a very valuable feedback! 💯

@vmassol merged, thank you!

And thank you for your great support and fantastic tool :)


Suggestion for composeRefs

I use the following in my own code. Do you have any objections?
It looks a bit simpler than your own method, but that does obviously not mean it is better. I just haven't experienced any problems with it, yet.
Problems would indeed appear if the amount of filteredRefs would change during the component lifecycle, e.g. if a passed ref is defined just after the first render. I can't see why that would be useful, though. You either want to use a ref during a lifecycle, or you don't ... right?
(sorry for the humongous tab size, hope you can read it anyway)
/** Merges any number of `LegacyRef`:s into a single ref callback.
 * If no defined refs are passed, `undefined` will be returned. */
export function useMergeRefs<T>(...refs: LegacyRef<T>[]) {
	if (!refs.length) {
		return;
	}

	const filteredRefs = refs.filter((ref) => !is.falsey(ref));

	if (!filteredRefs.length) {
		return;
	}

	if (filteredRefs.length === 1) {
		return filteredRefs[0];
	}

	return useMemo(
		() =>
			function merged(instance: T) {
				for (const ref of filteredRefs) {
					if (is.function(ref)) {
						ref(instance);
					} else if (is.object(ref)) {
						(ref as any).current = ref;
					}
				}
			},
		filteredRefs,
	);
}

@ludvigalden  Hello and sorry for taking so long to reply, I forgot to enable notifications for this project when I created it.
If the code above satisfies your use case and you are happy with it, there is no reason why you should not use it :).
However, if you would be interested in my feedback:

usage if is.falsey is kind-of pointless IMHO, refs.filter((ref) => ref) will yield the same result and be more performant
your code relies on react hooks, and therefore cannot be used in class components
you allow legacy (string) refs in your arguments, however, do not support them nor emit any warning/error if one is used, your code just ignores them. Empty string refs will even be omitted from filteredRefs. I suggest changing the arguments to ...refs: Ref<T>[]

The only issue with changing the filteredRefs would be changing the resulting ref passed to react, which will be transparent to object refs, and should not be too much of an issue for correctly implemented callback refs (performance impact is likely though, depending on the code in the callback).

Closing this due to inactivity.


Update Forward webhooks prompting UX

When the user opens up the forward webhooks dialogue, we prompt the user to enter in two addresses, the 2nd for connect. The message varies only slightly so it's easy for users to think their input got eaten.
We need to update the UX to at least clarify this.

@gracegoo-stripe If we can't figure out something intuitive on our own, we can always ask @karolis-stripe for help

What do you think @jbyrum-stripe we can differentiate by using brackets like this? Given we want it to be upfront.
I've updated the text to better match the dashboard text:

Ah this is a limit of vscode. We don't have a way to label the input box as far as I know. We can only provide a description. For what it's worth this is how all interactions work with input boxes in VSCode.

We can add a description like this it looks like. And put those titles in there.

Potential option is to move to a "QuickPick" dialog. If the user hasn't put a URL before it'll show this this. If they have it will be pre-filled with what they had previously. We can then offer our suggested URL like before. Ptal? @jbyrum-stripe

@ctrudeau-stripe Does the QuickPick allow arbitrary input? I'm not sure if it does.

Ah yes. You are right that it doesn't accept arbitrary input. Looks like the only option is to not pre-fill with something recommended if the text below won't work.

https://github.com/stripe/vscode-stripe/issues/248#issuecomment-857239528
@jbyrum-stripe will this solution suffice given it's our only option with the VSCode APIs without going completely custom?


Is it possible to add sound?

I have tried the usual methods of adding sound to html and javascript neither of them have worked. Do you know a way of doing it when the website loads or as you get close to an art piece?

Please don't ask questions unrelated to this project. Just google it or ask on stackoverflow.


Teams with same display name

2 teams have the same display name i.e. Infra

@parthp2107, I think two teams can have the same displayName but not the same name.
cc: @sureshms @harshach


DNS Record state discrepancy

Describe what happened
Yesterday cloudflare had an outage that caused an error when creating a DNS record.
Upon retry Pulumi seems to not be aware that this record was actually created and tries to add it again, which causes the update to fail.
Refresh did not help.
Sample program
new Pulumi.Cloudflare.Record(name, new RecordArgs
            {
                ZoneId = zoneId,
                Name = name,
                Content = domainVerificationId,
                Type = "TXT",
                Ttl = 1,
                Proxied = false,
            }

Log output
original error:

cloudflare:index:Record asuid.app-ingestion.eastus2.pr1242 creating (1s) error: error reading from server: EOF
cloudflare:index:Record asuid.app-ingestion.eastus2.pr1242 creating failed error: error reading from server: EOF

some other records we tried toc reate gave slightly different error:

cloudflare:index:Record asuid.app-ingestion.pr1242 creating (1s) error: connection error: desc = "transport: Error while dialing: dial tcp <IP_ADDRESS>:39483: connect: connection refused"
cloudflare:index:Record asuid.app-ingestion.pr1242 creating failed error: connection error: desc = "transport: Error while dialing: dial tcp <IP_ADDRESS>:39483: connect: connection refused"

now, every time we retry update (before and after refresh):

cloudflare:index:Record (asuid.app-ingestion.eastus2.pr1242):
error:   sdk-v2/provider2.go:385: sdk.helper_schema: expected DNS record to not already be present but already exists<EMAIL_ADDRESS>error: 1 error occurred:
* expected DNS record to not already be present but already exists

Affected Resource(s)
cloudflare:index:Record
Output of pulumi about
we use https://github.com/pulumi/actions so it's irrelevant
Additional context
This bug might be not reproducible in an easy way, without mocking CF responses, but it shows a bigger underlying issue that we have discussed with pulumi numerous times. It seems that when pulumi fails to get a successful response from a provider it assumes the resource was simply not created, while often it was or will be soon after. Instead of verifying this the next time around (or doing refresh) pulumi then tries to create that resource again, which either fails or causes a duplicate. We were assured that this scenario has been taken into account but we still see cases like this one were clearly it's a problem.
Unfortunately in such situation there is really little we can do, as the resource is created, deployment won't work, and pulumi also won't clean it as it's not aware of its existence (not that we can destroy the stack in many cases). We're aware that we could import resource, etc etc but those deployments are all part of an automated solution that deploy simtimes hundreds of times per day and we use pulumi to exactly avoid having to manage all such cases.
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Hi @mikocot. I'm sorry your hitting this error. Unfortunately, this is almost definitely a bug in the upstream provider: cloudflare/terraform-provider-cloudflare.
A pulumi level fix would be very similar to the resolution of https://github.com/pulumi/pulumi/issues/3388.

Also, looking from a customer perspective, think that if we did not use pulumi, such incident with a provider like CloudFlar or Azure, would be a no event, we'd just retry a creation. If this happens with Pulumi, we're actually stuck. There isn't any good way to deal with such state discrepancies, we had to do it before, and it's a super error prone and tricky operation making the whole deployment fragile.
Therefore Pulumi should do anything possible to avoid such state discrepancies, and it does not seem to. The fact that such issues are not fixed with a 'refresh' are even more worrying. And they are not becaue Pulumi doesn't seem to have any record of trying to create such resource first of all.

I totally agree; when providers are not resilient to create failures and the resource was actually created in the cloud, the declarative model breaks down a bit. To be fair, if you we're not using pulumi, you would still get an error when you retry and have to decide how to handle it. (but maybe the tools to resolve it would be more familiar?)
The problem is fundamentally tricky to solve at the Pulumi layer for a few reasons:

The (upstream, terraform) provider doesn't hand Pulumi any id/handle for the thing it was trying to create when it fails. This is why refresh can't work; we don't have enough information to try to read the state in the cloud.
When you run pulumi up a second time, the service returns a hard error, but not enough information for the provider to determine that its state matches the resource you're trying to create.

The best solution would be for the upstream provider to fix 1, so that the subsequent refresh would just work. (This is not always possible for all resources depending on the way the service API works, but based on the create error message it seems likely to me that it would be for this resource.)
At the Pulumi level, I think @iwahbe is right that https://github.com/pulumi/pulumi/issues/3388 is the best solution we've come up with. That option would let you instruct the provider to try to check to see if the resource already exists before attempting a create. (We're also very open to your ideas for what would be an intuitive way to address these sorts of errors!)
I hope that is helpful. We can also try to help with urging maintainers of https://github.com/cloudflare/terraform-provider-cloudflare see if they can fix the return on error for this resource as well, but your concern sounds like it may be more about create errors in the declarative IaC model generally rather than the behavior of this specific resource.

Sorry, didn't notice your response.

To be fair, if you we're not using pulumi, you would still get an error when you retry and have to decide how to handle it. (but maybe the tools to resolve it would be more familiar?)
yup, but you can handle it, with Pulumi we just get broken state and it becomes both difficult and risky to move on.

The (upstream, terraform) provider doesn't hand Pulumi any id/handle for the thing it was trying to create when it fails. This is why refresh can't work; we don't have enough information to try to read the state in the cloud.
But the same happens e.g. with azure-native provided that does not use TF and I guess pulumi generate the ids by itself there. also AFAIR in this case the name is not randomized so one could look it up by 'name' I believe.

The best solution would be for the upstream provider to fix 1, so that the subsequent refresh would just work. (This is not always possible for all resources depending on the way the service API works, but based on the create error message it seems likely to me that it would be for this resource.)
But would that really work? Does Pulumi have logic to note down resources it tried to create but failed so it can verified

Here I'm talking about a system that should work on every resource, basically:
1. Generate resource ID (if not set by user), add to state in 'draft' status

2. Try to create resource

3. a) if success, add to state
   b) if failed beyond doubt (e.g. 400 bad request), fail deployment, set status as failed / remove from state
   c) if failed, but the result is inconclusive (e.g. timeout, server error, network errror), fail deployment, set status as 'inconclusive'
   d) pulumi process killed, action timeout out or cancelled, hardware issue, whatever -> do nothing

Then the next time Pulumi tries to create a resource and sees a resource in the state with status draft or 'inconclusive it first queries provider to see if resource exists and matches what was requested. If yes, the status is updated to created and pulumi moves on to the next. If not, it retries creating it. @mjeffryes, or does Pulumi follow a similar workflow already?

This is unfortunately quite difficult to do generically. The problem is that it's not universally possible to generate an id in step 1, that can be used to read the resource after an inconclusive create. The id required for a read is often only returned on a successful create and can't be predicted for many resource types.
Now in specific cases like this DNS Record resource, it's likely that the provider could predict the id before the call to create. We currently have 3 options for addressing this situation in the provider:

Attempt the create, detect that the error means the resource already exists and try to read state.

Attempt to read before creating; skipping the create if the read succeeds

Both options can cause problems if the resource was actually created by a different stack. You end up with two stacks thinking they own this resource.
I think you are right that the core engine could be updated to give the provider a third option:

Before attempting the create, the provider returns the id it expects to use. The engine then stores this in state as you suggested and if the create fails in an ambiguous way; the engine would attempt a read before create when the update is retried.

It's worth noting that this is not a perfect fix though:

individual resources create behavior would have to be updated and this would only be possible if the id can be predicted ahead of time
It would still be possible to read a resource that you didn't actually create and get two stacks trying to manage the same resource (though with this third option that should be very rare)

FWIW, we are exploring how to support communicating these expected id to the engine. It's relevant to problems like Resource Create methods may be idempotent· pulumi/9925 and Structural resources· pulumi/918 as well. I just don't want to over promise what we can do here.

true, the issue of the resource possibly being created by another stack could be a problem, although as you have said, in many cases this is acceptable, so it could be configurable.
as for the ids not being deterministic, that's more of a problem, with the solution you've mentioned being a potential fix. On the other hand I believe that with many providers, like azure, you already know what the id is going to be, and azure is going to respect it


MGMT-16696: ResourceSync Models and API

This PR adds:

Created ResourceSync (and list) model spec.
Created APIs:

create
list
update
delete
get

Added needed commands to flightctl cmd
Added example resourcesync.yaml

Please also add to the end of .github/workflows/pr-smoke-testing.yaml


In plate list interfaces, should also expose date stamp

It appears to me that the change that was made in the linked PR adds the plate creation date to the plate list page--but that is not where the users actually pick plates for use in any stage of the LabControl processes.  The actual selection of plates to use for gdna extraction, library prep, pooling, etc, happens in javascript. And that javascript is duplicated in seven different locations (see all the places that say <!-- Modal to add a plate -->).
So .. unfortunately now it is time to pay the piper.  It turns out that https://github.com/jdereus/labman/issues/351 "Centralize addPlate functionality in front-end html/javascript" is NOT a nice-to-have but a must-have to provide users with the info they need to pick between plates.  We need to centralize this functionality into one place and then add date into the columns in this plate addition modal.


Latest update Version 1.15.3 creates incorrect namespace

Hi,
My VS Code install just updated the extension to version 1.15.3. When i create a class now it generate a messy namespace.  Refer to the code generated below:
<?php

declare(strict_types=1);

namespace c:\xampp\htdocs\MyCoursesLG\php\mvcframewks\garyclarke\frmwkpro\framework\src\Controller;

class Test
{

}

@lexman1958 I just published an update with a fix (1.15.4). It seems that the problem was in the backslash that Windows uses at path separator.

@jaguadoromero
Hi, It works now. Thank you so much.


lxc image copy documentation

I've tried hard to find a documentation regarding the command :
lxc image copy...
I'd like to copy an image which is identified by its fingerprint. The documentation talks about the ability to specify a 'version', but... it may represent 30 different images... and don't need all of them.
Where are the real 'manuals' of all the lxc commands ? The current method of 'lxc ... --help' is way not sufficient.

"lxc image copy --help" shows:
lxc image copy [<remote>:]<image> <remote>: [--alias=ALIAS...] [--copy-aliases] [--public] [--auto-update]
    Copy an image from one LXD daemon to another over the network.

    The auto-update flag instructs the server to keep this image up to
    date. It requires the source to be an alias and for it to be public.

At the top of the same help message, you have:
The image unique identifier is the hash (sha-256) of its representation
as a compressed tarball (or for split images, the concatenation of the
metadata and rootfs tarballs).

So this means that you can do:
lxc image copy HASH remote:

So do "lxc image list", get the fingerprint of the image and then pass that to "lxc image copy".


!pb Barb Assault

This is currently a draft. I'd just like a few more eyes on it to make it easier to merge in its final form.
Currently adds:
Saving of current best time into an overall pb and a role-specific pb into the config file at the end of w10
new config setting in Barbarian assault to check if they'd like to save into a role-specific pb (default false)
Fixed display of timer from changing to hh:mm when a run lasted more than 1hr instead staying as mm:ss
and the usage of these commands.
!pb barb assault (with a few more cases in chat commands plugin)
!pb ba healer
!pb ba collector
!pb ba defender
Currently, they all save correctly and logic is being double-checked to make sure there isn't some hidden little bug.
Feel free to build yourself and play around with it.
Gonna mark it as a draft, for now, maybe get some new eyes on it and some review of code then when finalized I'll squash commits and do a final pr

Reasons for adding is for the general person playing Barbarian assault they get a torso and leave and get lvl5 all for diaries and leave and therefore would never need/want to use the current !gc command for gamble count. These new commands would allow them to be able to show others how well(or poorly) they performed in any role as well as an overall personal best.
Then for the people who do leeches/ba community in general the !gc command is nice to show how much time you've put into the minigame, but at a certain point, you can't really determine the skill level of those players just from the !gc command. An example being someone showing that they have 700gc from just playing in 306 vs someone who does leeches and is at 300gc this would be a better way of showcasing the skill level of other players especially if they only have 700gc from a single role.
Everyone asked from the ba community has been quite receptive and would like this change, and for the average player it gives them some functionality as well
I do know there might be hesitation on saving a personal best from something that can not be verified as it is not tracked serverside by Jagex and however is totally client-side, but my views on this are the people who know how to change them can change how they show up anyways.  And tbh you can also mess with how other people's !pb commands show up regardless with no editing of their config file. And for records in BA, there are already strict guidelines set with video evidence and timing so this would not affect that in any way.

Looks like this was added in https://github.com/runelite/plugin-hub/pull/1562, so I'm closing this PR.


Find the definitive name for this project

Here are the suggestion as discuss by the team:
Contenders
1⃣ vallet
a mix from vega and wallet
2⃣ vegawallet
self explanatory
3⃣ wallet-cli
might conflict with other wallet software, though
5⃣ attaché
The French should like this
6⃣  財布 / saifu
Japanese for wallet, also sounds like "safe"
Rejected
4⃣ balrog
Japanese name of Vega.
As mentionned with @barnabee:

Not Balrog because of potential confusion with the company some of us work for.

vegawallet seems good to me! I think the desktop app has come up before in this question but I don't think that's a big issue, right? Certainly not internally and once it's an app, I don't think the repo name is a big deal for users.


Bug: Renaming a note doesn't change PDF attachment links

Renaming a note successfully changes the images internal links and also the attachment folder name.
But PDF attachments doesn't automatically change it's internal links.
So the PDFs are still linked to the old ${notename} attachment folder.

Fixed in v0.7.8, please upgrade to.

Perfect! Thanks 👍


The Format document command does not work in multi root workspaces

Issue Type: Bug
The command Format Document does not work in every project folder when there is multi-root workspace.
Extension version: 1.15.2
VS Code version: Code 1.26.1 (493869ee8e8a846b0855873886fc79d480d342de, 2018-08-16T18:38:57.434Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4790S CPU @ 3.20GHz (8 x 3193)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
15.94GB (12.57GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe

Screen Reader
no

VM
0%

Hi @Martin00001, you right that this does not work today. https://github.com/OmniSharp/omnisharp-vscode/issues/1889 will need to be fully implemented before that can happen.

Closing as issue can be tracked by #1889


[WIP] Fixing MemorySwappiness docker compose failures on master

Signed-off-by: Nishant Totla<EMAIL_ADDRESS>

Root cause found: https://github.com/moby/moby/pull/33898


Fix error_types and sends_stopped for the transfer family of algos

The schedule_from algo has its own completion signals computation that
joins the error_types and sends_stopped from the input scheduler and
the sender created by the given scheduler.
This fixes also the bad behavior of transfer and transfer_just, and
helps on fixing some tests based on these.
Adding more tests for completion signatures and __transform in the
process of chasing a hard-to-find bug that manifested on downstream
senders (using the Variant template parameter multiple times in the
error_types definition; depending on the transformation passed to
error_types, that leads to strange errors).

Thanks for this. I'm going to hold off on merging this since I have already fixed this problem and many more like it in #410, and this PR will add massive merge conflicts. I'd prefer to wait until I get direction from LEWG on the receiver concept design changes, and have merged #410.

Needs a rebase on main now that I have merged the receiver changes.


Fix code scanning alert - Failure to use secure cookies

Tracking issue for:

[ ] https://github.com/qld-gov-au/documentproduction/security/code-scanning/13

Covered in https://github.com/qld-gov-au/documentproduction/pull/187


isso 0.11 default install exposes admin interface with a default password: "please_choose_a_strong_password"

This seems like a security problem, anyone upgrading from 0.10 will be surprised I'm sure. I only figured out the existence of this admin interface by poking around pull requests.
This seems like something that should be disabled by default. If not, atleast documented in the public docs at Documentation. One of the things that drew me to isso was the fantastic documentation and very good defaults that prevent shooting in the foot type scenarios.

Thanks to this issue I just discovered the service I was hosting was vulnerable. Fortunately no damage was done. Thanks.


Add test info mod rs

Rebased PR #822
Didn't realize that would close the other PR, sorry.

Trying a new approach in 3e2757d
Test will creates repo and expected result using shell script via git-testttools
Test will read expected result from file created by shell script
Test will perform action
Test will compare actual to expected

These assertion diffs are pretty hard to read :laughing:
I've used pretty_assertions before to get better diffs.

Thank you @spenserblack , here is a pretty assertion:

@spenserblack  and @o2sh
Really like the output of pretty_assert that is very easy to see the issues.
What are thoughts on using regular expressions in the expected output?
I have the wrong regex for REGEX_ANYTHING, ".*" is only good for end of lines.
Wanted a quick review and collect ideas before putting too much effort into this.
Would this be better if a phrases were used: MATCH_UNTIL_END_OF_LINE or MATCH_WORD ?

Here I was about to make a snapshot testing library, and in my research found that one exists :laughing:
https://crates.io/crates/insta
It might be worth using this library for the JSON output test.

Hav a look at  6486d50
uses insta snapshots for the JSON
Neato.

Change 69c6229 caused a snapshot change, testing gitignore change ;-)
Also, gave another chance to use cargo insta review that is so cool how it "fixes" up the snapshot file for the test.

that is so cool how it "fixes" up the snapshot file for the test.

Yeah, snapshot testing is pretty interesting. It leans a bit towards "acceptance". That is, instead of a human writing a test for the machine to run and the code to pass, a human reviews the output and tells the machine if they like it.


ts fails

Issue Type: Bug
not sure, I get an error from vscode that typescript failed more than 5 times
VS Code version: Code 1.47.3 (91899dcef7b8110878ea59626991a18c8a6a1b3e, 2020-07-23T13:12:49.994Z)
OS version: Windows_NT x64 10.0.19041
Remote OS version: Linux x64 4.19.104-microsoft-standard

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz (8 x 1498)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.59GB (18.18GB free)

Process Argv

Screen Reader
no

VM
0%

Item
Value

Remote
WSL: Ubuntu-20.04

OS
Linux x64 4.19.104-microsoft-standard

CPUs
Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz (8 x 1497)

Memory (System)
24.74GB (21.05GB free)

VM
0%

Extensions (9)

Extension
Author (truncated)
Version

remote-wsl
ms-
0.44.4

code-settings-sync
Sha
3.4.3

vscode-eslint
dba
2.1.8

gitlens
eam
10.2.2

prettier-vscode
esb
5.1.3

go
gol
0.15.2

vscode-docker
ms-
1.4.1

code-spell-checker
str
1.9.0

vscode-status-bar-format-toggle
tom
2.0.0

When this happens, click on the report issue link in the error notification. It will pre-populate the issue with the relevant error stack
/needsMoreInfo

actually that's what I did, this is all the info that is produced
On Fri, 31 Jul 2020 at 06:40, VS Code Issue Triage Bot <
<EMAIL_ADDRESS>wrote:

Thanks for creating this issue! We figured it's missing some basic
information or in some other way doesn't follow our issue reporting
https://aka.ms/vscodeissuereporting guidelines. Please take the time to
review these and update the issue.
Happy Coding!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/103626#issuecomment-666896668,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKRKF4AXCVT2GTKIYXIUFLR6I4JTANCNFSM4PNUBMLQ
.

Does this reproduce in the latest VS Code insiders build with all extensions disabled?


[PPP] Fix style in PPP (shermannws)

Codecov Report

Merging #590 (bb5399e) into master (a7e7ad2) will increase coverage by 0.44%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #590      +/-   ##
============================================
+ Coverage     61.27%   61.72%   +0.44%
- Complexity      628      630       +2
============================================
  Files           104      104
  Lines          2252     2252
  Branches        261      261
============================================
+ Hits           1380     1390      +10
+ Misses          756      744      -12
- Partials        116      118       +2

Impacted Files
Coverage Δ

...java/seedu/programmer/logic/parser/ParserUtil.java
71.69% <0.00%> (+5.66%)
:arrow_up:

...edu/programmer/logic/parser/EditCommandParser.java
80.55% <0.00%> (+19.44%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7e7ad2...bb5399e. Read the comment docs.


Add workspace test, clear ws db between tests

Coverage remained the same at 97.879% when pulling 248a7a97564af62480257ab5c8cefd27265cd85f on MrCreosote:master into 2f8ac41a71f0e8b34714e5e62904837e1190556e on kbaseIncubator:master.


Explorer link in Settings is the 941

Needs to be updated to 951 http://explorer-951.symboldev.network/

@jabo38 which release of the wallet are you using? The latest release i.e. 0.10.0 is showing 951 as per the explorerUrl setting in network.conf.json

@jabo38 which release of the wallet are you using? The latest release i.e. 0.10.0 is showing 951 as per the explorerUrl setting in network.conf.json

He probably meant that the "Details about a transaction" window transaction hash link is pointed to 941 network instead of 951.

Needs to be updated to 951 http://explorer-951.symboldev.network/

Go to "Settings" --> "General Settings" --> Change the "Explorer URL" to the latest explorer link.
This will solve the problem.

@jabo38 Actually this setting was missed in the wallet client database migration from 941 to 951. I'm working on the fix. Thanks for the feedback.


When does the cleanup occur?

Would it be possible to also document when the cleanup based on these retention rules occurs? Or maybe how to access the logs of what happened when running the task?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8aa2c495-4dd0-1040-cb44-2d569514de2f
Version Independent ID: 7adea665-ebd8-8e85-7c7d-6fd070378073
Content: Policy to retain untagged manifests in Azure Container Registry
Content Source: articles/container-registry/container-registry-retention-policy.md
Service: container-registry
GitHub Login: @dlepow
Microsoft Alias: danlep

Thanks for the feedback! We are currently investigating and will update you shortly.

@mkstephenson not sure I fully understand. Once the retention period is up, the images and artifacts are automatically removed. So not sure what exactly you are looking to have documented here.
As per the logs, you are looking for a summary of the images that were removed correct? I am not sure if that functionality is possible at this time. Possibly in the activity logs... @dlepow would you know?

We're checking if this is logged to the pending Audit Logs capability. It should, if it's not.
For the occurrence of purging, it works under a queue based system.
ACR does ref counting for manifests. When a manifest no longer has a tag, it checks the purge policy. If purge policy is enabled, a manifest delete is queued, with a specific date.
There's a separate queue management job that's constantly processing messaging, scaling as needed. Lets say you untagged two manifests, 1 hour apart, which had a retention policy of 30 days. Two queued messages would be made. 30 days later, approximately, 1 hour apart, the messages would be popped and processed.
@dlepow : can we add that later part to our documentation? While more detailed, It may be interesting to know how we built ACR, following cloud scale principals.

@MicahMcKittrick-MSFT @SteveLasker thanks for the info! That's really interesting to hear how this is handled internally and I'm certain I'm not the only one who would find that later part interesting in the docs. I initially thought that since it was being developed at the same time as the auto-purge tasks that it used a similar mechanism but the queue based system makes a lot more sense.
I wonder, how does the registry handle existing untagged manifests when the user enables the retention policy feature? Does it do a scan of the existing manifests and queue the untagged ones (which should be deleted) for deletion in the same way that it queues the manifest delete requests?

I'm just wondering since we enabled the feature a couple of days ago and so far no cleanup has happened of the existing repositories so I was wondering how the cleanup task worked, if there was a way of seeing if it was having an effect or not.

@mkstephenson It only applies to any untagging after the policy was enabled. Manifests that got untagged in the past won't get purged automatically.
In future iteration, we will mostly come up with an intuitive way for users to review and purge the existing untagged manifests while enabling retention policy.
@dlepow Can we please cover this fact in the docs too?

@mkstephenson Manifests untagged after you enable retention policy (with n days)  will get purged n days after the untagging.
Quickest way to validate:

Enable retention policy with 0 days (purge immediately, no wait).
Push a hello-world image with tag latest (default).
Untag latest leaving the manifest corresponding to hello-world image untagged.
The manifest should get automatically deleted too within next few seconds (~immediately). You can check the manifest count in repository attributes or list all manifests for the repository.

We still need to account for the untagged manifests that were in the registry prior to enabling the policy.
Users can use: https://docs.microsoft.com/en-us/azure/container-registry/container-registry-delete#delete-untagged-images
However, we will incorporate deleting previously untagged manifests in the policy as well.
@dlepow, can you add a x-reference to the delete-untagged-images doc as well?

@mkstephenson and ACR team - Thanks for helpful feedback. I'll update the article and we can sort out the fine points during the review cycle.

#in-progress

Updated article has been published. @mkstephenson, thanks again.
#please-close

Perfect thanks!


request Indo Global Mandiri University

@gustiawanadi First stage of verification passed, official domain is uigm.ac.id as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@gustiawanadi I have to close this request without merging, because you requested to add a non-existent domain to this repository: ;; connection timed out; no servers could be reached Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


Add contact form for email

I removed the email button from the site entirely for now; it's just causing too many issues with spam and spoof attempts

Moved to v3.1

Instead of a form, it could just be a mailto: behind a captcha

Instead of a form, it could just be a mailto: behind a captcha

I've been exploring the captcha. It's turning out to be a lot of work. For now, I'm just removing references to email.


Add env_logger to tests.

The log crate needs to be initialized with a backend or it won't report any messages.
This adds env_log hooks to the tests so that RUST_LOG=coio=trace cargo test generates lots of output instead of none.

Yes, but .. is it necessary to commit this to the repo? Because these is used for debugging, not testing.

I think it's alright actually… But if possible I'd move the env_logger to src/lib.rs, like this:
#[cfg(test)]
extern crate env_logger;

@glasswings One of us was strongly against this PR (due to the added code) and one was somewhat for it. So... I'll close this PR for now. Still thanks! :blush:

Ah before I forget it: You can now use ::env_logger::init().unwrap(); in any test on origin/master and it will work.


chore: Upgrade Packages

Closes #188

📦 Published PR as canary version: 0.12.1--canary.190.e644e06.0

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>

Looks like chromatic pipeline is sat at Node 16, Upgrading to Node 20 will probably fix the chromatic issue at least


Node Stream support for react v18?

With the upcoming React v18 i was wondering if much thought has been given about how to implement Node streams. As some of the new features for v18 React.Lazy and React.Suspense will be leveraging a new nodestream https://github.com/reactwg/react-18/discussions/22
i dont have much experence on the node side of this. im not sure where to start with a basic implementation using renderToNodeStream any guidance would be appreciated.
I though about trying to do something with Web sockets and tie into the JS Engines that way but not sure that would work.

Yeah I’m not sure the embedded v8 engine would support this at all with the
current architecture. Might need to revisit some
kind of real Node interop later, I believe there was a PR from a while ago
that explored making that work.
For now only string based rendering is supported, at least until we sort
that path out.
On Thu, Sep 2, 2021 at 16:58, Loren Dorez @.***> wrote:

With the upcoming React v18 i was wondering if much thought has been given
about how to implement Node streams. As some of the new features for v18
React.Lazy and React.Suspense will be leveraging a new nodestream
reactwg/react-18#22 https://github.com/reactwg/react-18/discussions/22
i dont have much experence on the node side of this. im not sure where to
start with a basic implementation using renderToNodeStream any guidance
would be appreciated.
I though about trying to do something with Web sockets and tie into the JS
Engines that way but not sure that would work.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/reactjs/React.NET/issues/1265, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHGCFVHDQPOH3TZQSNHO4DT77QPLANCNFSM5DJ6FDBQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Well I see JES has a node engine that could be used but again not sure how you would be able to wireup the cross talk between JSE <> .Net <> Client. I was thinking you could use websockets or signalR to help with the .Net <> Client but not sure the JSE can handle the constant connection between it and .Net


License server request body

Shaka player <IP_ADDRESS>
I'm implementing license server, and trying to make license request from shaka player to the license server following the tutorial on https://shaka-player-demo.appspot.com/docs/api/tutorial-drm-config.html
from the documentation I understood the request should be JSON with key id parameter,
but the shaka player body of the request (payload) contains the following data that I don't know how to parse:
ð
³ChromeCDM-Windows-x86Þ¬"0
¡§d²7úÝ³ÛD¼§Â òú3GõÄËÔËÃT¨yÊÔ×Ð©Ú¯åÞ¯E-Á<|A
]ãµä,Ðù÷#ÆÈxá=-¥5WL^Üí
î©ùh¦öd÷1Ç|<]JÑÊÃ$û:uË£
GØ
ê·Lf·¶èZ©d[ÃvÙ³¡.ám\Ì0ñ¹LÂ|4^¨îÇÍÚ²Ìu¾Uò9S f¤~éÆF	I
[¸B+]¼ÏÍJµàR<;56RÙà	vz3NÓIYl${y¬¬@Ú8¡ÇCÚÕ_úÊkK³ÿ	(þ!8Ò¦àÿ°î"»H Wlrê¦ü^ÇÃQËÖ÷JÙø¼â ¾Ù'¯IÙ[UÐÁç£fØþÎÄäg!Ríx|t@}É[ªþ6XCðÀ:åh6¹bØ¢ \Ùª6BYw£ày/¿9w-ýhÙ ¶7|Ñ\ûÎ¨¶ñ{¶ø´ÚJFýt»JÈßiG_4ÿ¦µÔsés£tåS¹s°I§RqqND¾º+¶}aø6àíN7;FxhdMÊ^4r(Ë3o4iìä¦ä7fåÒÑ
ÖwtÖ¨g<»óÆll*íp´
®ÖÒïäáX=EûË.®¥"0
ëÙ-ä
v;©N+O
]{h£<ý±Ø4Øáèí®¼Sa<?QUáiØàq·iÞùÄsÏjïÜM&ÆiiÜ÷çÑÝ4úðÁ½ãXGKÉå©
á »óÙÂ+Å^$»Óâ{äÎtsïºæi¥G¶5Æp¹ÊÅî³Ø§ä.¯n(³4¸ÚE
>^X¨ pnºkÑ¼ºÍg±ì¥>ü+ýÀ`/-õ2÷ÞÁäé,·~%~ä¸[_>¼"(÷óV<;P{f¨x¥½èNâFiËyf)4Êç(þ!² o¢÷§³ª¡î¾µ{ï®øÏW3Æönßh¢Fò`/A|-ü¸ÍÇà¡Ô«sBlN¸¢RfúâµÈ¼ÎÔÿ¿î¸«Sßùt¨ùb	yzâÛd6îÙWÂûo8«$À	SÄ£^ñãæh1ý¼CÊW#Í¯_xv¡k¡¡>IÀ
%¬<ëG2o@k/F¶ÙN¾h)B±R³k¯ÙRgX1É[ªÌ¯ü
½²·íRÖE-j\+èDÆÖ|øJ ùGö½)ué9àBÕ©mÑÁ¤Wû(½
=x>OdUjL²ò¶?ÈaV×<ìý¤¢Kxª÷Tâ×«p
¤]üüeå¾T¹"cn©R]÷ê¨¸âÌ}·O®ËÐÌ~(wò,âØKqZo¼@ãte°§òèÎÔ¬Uº"×áº6þ¬`%
3ë#4:#1&+ý*|Î
architecture_namex86-32
company_nameGoogle

model_name	ChromeCDM

platform_nameWindows!
widevine_cdm_version	<IP_ADDRESS>32 k
i
Sh¬ÌÖ¬SXl1à¿9>ÔazPj"nrÇõÉ·D-`Ò]î¥Ç>ñÃ
widevine_test"ÎÅ¿õÜ@ÝÉ2ÍÈÀ¦k\{eè´
;Ä çÒÀ0l±ÌtËæØ\%§vtÞ%Âÿ;)öË4èµ	Q'%Ô&õLæúóJüän¯ÃF¯^::ÍªÜ
NÈJÍLdü&òÎ`ü®§ºÌÀH+à7ÏÇíýnqþ%¹®§
_ë`h
híö`ÿ#´QÍ²+ zéãýXMí!åo¨r¹$ Òzl8ôB.é¨¾Ä¤×RúòfÛÓAf©s@ïw't±5óC©OSÑHb½LRóhÍÉ]º#+`÷-òà«(AYçÉ©¥ô0êÄ/ë|ÜLê?µ¸

is this the payload I need to pass to widevine?
Thanks in advance
Alex

Hi Alex,
A Widevine license request is not in JSON format.  I apologize if the docs gave you the wrong impression.  If you can point out what part of the docs made you think that, we will be happy to correct them.
Shaka Player will not, by default, make any changes to the format of the license request or response.  The request from the CDM is sent directly to the configured license server, and the response from that license server is given directly back to the CDM.  Both request and response are in a non-readable binary format.
Does that answer your question?

Hi Joey,
Thanks for the fast response
i have misread the documentation in "DRM Configuration" section, it has "license request format" link, its for clear key license only now i understand.
guess the request shaka player is sending to the license server is the "payload" the license server needs to pass to widevine,
and if i want to pass additional parameters i would need to use "License Wrapping" and add any additional parameters like "content id" for example
is that correct?

The raw request coming from the CDM should be sent to the Widevine backend in whatever format the backend requires from the proxy.  I can't comment on what additional parameters you might need, but anything you want to add to the request on the client side will require license wrapping.

Got it.
Thank you!


Inputtoolbar disappears if I dismiss the view and than present it again

Hi, I am writing a small chat app, where I use the JSQMessageViewController for the main component of the chat view controller. Beyond that, I have another view, which contains a table showing the list of current chats, where I should open the chat by clicking the cells of the table.
The problem is that, opening the chat by clicking the cells of the table is fine at the first time; but after I dismiss that chat by clicking left top button of the navigation bar and try to reopen the chat by clicking the  cell again, the problem happens, where the inputtoolbar doesn't show anymore.
Any idea on it?

are you using swift or Objective c for your project?

@jayisidoro I am using objective c. Thanks!

Same issue and I am using Swift

For me is fixed when change the modalTransitionStyle from default value .coverVertical to any other style e.g. .flipHorizontal

Hello everyone!
I'm sorry to inform the community that I'm officially deprecating this project. 😢 Please read my blog post for details:
http://www.jessesquires.com/blog/officially-deprecating-jsqmessagesviewcontroller/
Thus, I'm closing all issues and pull requests and making the necessary updates to formally deprecate the library. I'm sorry if this is unexpected or disappointing. Please know that this was an extremely difficult decision to make. I'd like to thank everyone here for contributing and making this project so great. It was a fun 4 years. 😊
Thanks for understanding,
— jsq


Heroku deployment issue

Trying to deploy a freshly forked project on heroku using the heroku branch nets the following error during the build phase.
https://pastebin.com/KF5096Vy
No additional ENV settings have been set in heroku

You need to follow this guide: https://github.com/bertho-zero/react-redux-universal-hot-example#deployment-on-heroku

This is due to the missing env variable NODE_PATH.

Ah, you'd figure 3 developers looking at it could figure that out... 😄
Might i suggest adding a little index at the top of the readme to improve readability?

Yes, a PR is welcome.


Deselect Table Row on Click Outside

Update exemple to remove button since it's not usefull anymore
Add unit tests
Potential Breaking Changes
Behaviour is different, code isn't
Acceptance Criteria

[x] The proposed changes are covered by unit tests
[x] The potential breaking changes are clearly identified
[x] README.md is adjusted to reflect the proposed changes (if relevant)

Codecov Report

Merging #1360 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1360      +/-   ##
==========================================
+ Coverage   99.33%   99.33%   +<.01%
==========================================
  Files         374      374
  Lines        9261     9280      +19
  Branches     2236     2239       +3
==========================================
+ Hits         9199     9218      +19
  Misses         62       62

Impacted Files
Coverage Δ

...t-vapor/src/components/table-hoc/TableSelectors.ts
100% <100%> (ø)
:arrow_up:

...apor/src/components/table-hoc/TableWithActions.tsx
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4df211d...51ff8f5. Read the comment docs.

Works well and code is clean :+1:


Document conditional expandable rows (wiki or Website)

Select one ... (check one with "x")
[ ] bug
[x] feature request
[x] enhancement

Expected behavior

I would like to request supporting conditionally disable for extendable datagrid row.
The content in row detail might be invalid for some cases.
It's better to hide the arrow and row detail for those rows.
For Example:
The arrow and row detail is hidden for the 3rd row.

Actual behavior

It's not supported. An empty detail row appent.

Reproduction of behavior

Include a link to the reproduction scenario you created by forking one of the Clarity Plunker Templates:

clarity-v11-datagrid-issue
Environment details

Angular version: 4.x.x

Clarity version: 0.10.15

OS and version:

Browser: all

@youdz Thanks 👍

Closed via #2507


Download to output stream memory optimizations.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-core


LOD distance is set correctly for scaled meshes

WIP fix for LOD distance being set incorrectly for scaled meshes.
https://user-images.githubusercontent.com/18116695/158236346-9a90fd6b-02f6-45e9-bcbb-36f9cfbc376c.mp4
https://user-images.githubusercontent.com/18116695/158236363-01b4f9d3-08f4-46dd-819a-675c0173d999.mp4
Bugsquad edit: This closes https://github.com/godotengine/godot/issues/57895.

@JFonS Please take a look. I’ll check later today.

I think the problem must be somewhere else, it is intended that the mesh scale when imported is not taken into consideration, as the LODs should change depending on the scale in real-time, not when imported.

I think this bug is caused by the mesh's aabb being too small.

This is what it looks like when the scaling is fixed in the glTF file.

Even the official Khronos glTF 2.0 Sample Viewer has trouble with this mesh, so it's probably not a Godot specific issue.


Home directory is polluted with .beamup directory

I think it would be best to have this be within an appropriate directory such as ~/.local, ~/Library, etc, similar to how the data and configuration directories work

Are you on macos? On Linux it shouldn't be ~/.beamup for sure. What I did was utilize the results of https://docs.rs/dirs/5.0.1/dirs/ and in the cases of None I based it on what I believe to be common practice on macos/windows from similar tools.
I don't like it, and don't have macos to verify against. Even on Linux tools like rustup/cargo/npm use ~/.*. Can beamup do better? Yes, I considered it playing it cautious to do this in the case executable_dir is None.

This was on Fedora Linux.

Weird... I'm on Fedora.

I just tested on fedora, alpine, and debian and this didn't happen! I must have make a mistake. Sorry about that


Creation of valid migrations with "table" in the name (eg vegetable) causes unexpected behaviour

Package version
4.1.0
Node.js and npm version
11.12.0 & 6.7.0
Sample Code (to reproduce the issue)
Running
adonis make:migration vegetable
leads to the creation of a migration as follows:
Migration name:<PHONE_NUMBER>425_vege_schema.js
'use strict'

/** @type {import('@adonisjs/lucid/src/Schema')} */
const Schema = use('Schema')

class VegeSchema extends Schema {
  up () {
    this.create('veges', (table) => {
      table.increments()
      table.timestamps()
    })
  }

  down () {
    this.drop('veges')
  }
}

module.exports = VegeSchema

As a continuation to this, if I create a model called Vegetable, the spelling is kept intact. This causes issues while performing DB operations. For instance, on inserting an entry, the framework throws the error that the table vegetable could not be found.
I'm guessing this table keyword replacement in migrations is some magic the framework performs. But it can lead to unexpected bugs.
P.S: Thanks for your work on this framework, Virk!

Yup, needs to be fixed.


marathon bump to 1.6.352

High-level description
What features does this change enable? What bugs does this change fix?
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

MARATHON-8088 Implement gpu_scheduling_behavior parameter and basic functionality.
MARATHON-8089 Application specific override for GPU scheduling behavior
MARATHON-8112 Open the persistence store before taking a backup using CLI

Checklist for all PRs

[x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[x] Change log from the last version integrated (this should be a link to commits for easy verification and review):  changelog
[x] Test Results: CI Build
[ ] Code Coverage (if available): [link to code coverage report]

@mesosphere-mergebot bump-ee

@mesosphere-mergebot label ready for review


Multi-Level Grouping show 'undefind' values

Multi-levl grouping shown undefined when the group key is not aviable in row.
.

use a valueGetter and handle this in your client code. if it was left blank, you could have three blank groups (null, undefined, empty string) with no way of knowing why the duplicate, so solving this problem in the grid just creates another one!


Terminal integration tests failing on Browser

Here's the failing build https://dev.azure.com/monacotools/Monaco/_build/results?buildId=69339&view=logs&j=935a53e5-ce00-51d1-185d-b2f737723cea&t=78251e6f-ceae-58b8-b69e-6d3a7d24b6bc
Window namespace tests Terminal sendText immediately after createTerminal should not throw:

/duplicate https://github.com/microsoft/vscode/issues/92826


Automated Package Upgrade

:tada: This PR is included in version 25.6.70 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update wasmi used in differential fuzzing

Closes #4818
Closes #5102

We have not yet integrated full fuzz testing for the newest wasmi engine (just very basic fuzzing so far) so I am a bit worried that it might be a big noisy at start. If that's the case we will definitely fix found wasmi bugs asap.
Concerning cargo-vet the following crates must be registered to your database:

wasmi: Well, this is a tough one tbh. I am the author of it but it contains plenty of unsafe code for optimization purposes. We (Parity) are going to use it in production very soon(TM).
wasmi_core: This is just a small utility crate and should be pretty boring. Also it has no unsafe code.
wasmi_arena: Similar to wasmi_core. Just defines some arena data structures for use in wasmi.
memory-units: Can be safely ignored since wasmi already removed it.
indexmap-nostd: This again is interesting. It is a reimlpementation of the API of the well-known indexmap crate. It uses no unsafe Rust code and is implemented as simple as it gets. We use it in the wasmparser-nostd fork of wasmparser and it passes all wasm-tools tests as well as all of wasmi tests but has no tests on its own.
wasmparser-nostd: More or less trivial fork of wasmparser. The most interesting difference is the use of the aforementioned indexmap-nostd.

I've added cargo vet entries for all new dependencies added here, except for the wasmi crate itself. I've updated the exemption from 0.11.0 to 0.19.0 so we're not necessarily in much worse of a position, but othewise I'm not in a position to provide a "vet" of that crate in the official sense but I believe it's safe to run for fuzzing for us.
Otherwise thanks for the info @Robbepop, I've run the fuzzer for a number of hours locally and nothing has shown up, so if something pops up on oss-fuzz I'll forward along the issue.

Otherwise thanks for the info @Robbepop, I've run the fuzzer for a number of hours locally and nothing has shown up, so if something pops up on oss-fuzz I'll forward along the issue.

Oh wow, that's incredible news. Also looking forward to any forwarded bugs. :)


Recover flow using pin & passphrase

if the user does not have their QR code, they can recover their backed up keys.

User enters in their recovery pin code (6 digits)
The app users the hashed email & pin code to fetch the encrypted keys from TIKI
User enters in their passphrase to decrypt the keys
User enters in new pin code and passphrase
App replaces the old backup with a new one
The user is logged in and their account restored

done in https://github.com/tiki/login/


RCSBuildAid 0.7.1

new version, review everything is alright since I updated the file to spec v1.4

You need to add commas at the end of lines 7, 8 and 9. I think that's everything but the bot will tell us for sure once that's fixed :)


prepDE.py pulls around 50% MSTRG as gene_id from Stringtie_merge RNA-Seq

Dear community,
I am running an analysis of unpaired RNA-sequencing reads (derived from mice) as my first ever bioinformatics project, and am stuck at one point. Although a few people reported similar problems regarding MSTRGs as the output of their raw gene counts tables, I couldn't solve the problem with the answers given there.
The workflow I used was STAR for the alignment. The raw fastq.gz files, which were obtained using an Illumina sequencing machine, were checked using FastQC. The resulting STAR output .bam file was used as input for stringtie, using the following commands in a linux shell (essentially following the protocol of the Nature Protocols paper from Pertea et al. published in 2016):
maindir=pwd; for i in $( ls -d Mouse ); do cd $i; echo $i; label=$i; output=$i."gtf"; stringtie -p 8 -G /RAID5/indices/STAR_mouse/Mus_musculus.GRCm38.91.gtf -e -o $output -l $label Aligned.sortedByCoord.out.bam; cd $maindir; done;
stringtie --merge -p 8 -G /RAID5/indices/STAR_mouse/Mus_musculus.GRCm38.91.gtf -e -o stringtie_merged.gtf  mergelist.txt
maindir=pwd; for i in $( ls -d Mouse );  do echo $i; cd $i; stringtie -e -B -p 8 -G $maindir/merged.annotated.gtf -o Deseq2/$i.gtf Aligned.sortedByCoord.out.bam; cd $maindir; done
The resulting .gtf-files were fed into the prep.DE.py, in order to use the resulting output raw gene counts table for further downstream analysis with DESeq2.
python ./prepDE.py -i python_guide.txt
Here, around 50% of the genes are labled as MSTRGs in the output file although in the Stringtie-merge file there is an ENSMUSG ID in every row. Interestingly, sometimes as gene_id and sometimes as ref_gene_id. I have attached a few lines of the stringtie_merged file as a manually shortened .txt file (I just copied the first and last ~500 lines since the original file is far too large to be attached to this post). Those should illustrate my problem. Intrestingly, the Input-.gtf files for stringtie differ, with some having no MSTRG-genes, and some having a lot more (Input python example 1 and 2).
My question is: Is there any way how I can change the stringtie file, so that the python script only gives me the ENSMUSG IDs (or the gene names) as an output in the raw gene counts table? Or how should I deal with those MSTRG-labeled genes in general?
In case you need more information to help me, please let me know.
Thank you for your help,
Thaddaeus
stringtie_merge_example.txt
Input_python_example1.txt
Input_python_example2.txt

I know this issue frustrates many users and I am looking into practical ways to alleviate it.. As you probably figured it out, there is a simple technical reason why those MSTRG gene_ids are assigned there in StringTie output instead of the original gene_ids:  an unique gene_id was needed (internally) to identify a locus in StringTie, i.e. a contiguous region on the genome where transcripts overlap (their exons, more specifically), that is, a cluster of transcripts defined by the transitive overlap property (transitive closure). prepDE only uses the gene_id attribute to determine the gene ID (duh) so whatever identifier you want to see for the gene in the expression table, should be in that attribute.
We simply could not rely on the uniquenes/correctness of the reference gene_id.. Also, many times a StringTie locus is very different from the reference loci, as it comes from a mix between novel transcripts and overlapping reference transcripts, and sometimes even multiple reference genes (loci) can be merged into a larger StringTie locus due to extended overlaps between the member transcripts. The unique MSTRG solves all these ambiguities.
To clarify one of your observations: the ENSMUSG.. gene_id entries you see in StringTie's output (at the end of the file) are only for the reference transcripts which had absolutely no overlap with any of the StringTie-assembled transcripts, so they are not "merged" and even considered for merging, they are just copied over from the reference annotation file, pretty much, keeping their original gene_id (because StringTie did not need to handle them internally for the merging procedure).
A user-side solution at this point would be the post-processing of the stringtie --merge GTF output, before running StringTie to estimate that GTF for each sample, as to adjust the gene_id in order to include somehow any other information about the genes that the user might want (using the ref_gene_id and/or gene_name of the transcripts with the same MSTRG gene_id).
For example, if the original gene_id for a bunch of transcripts was MSTRG.4 then that could be modified to collect all the ref_gene_id for those transcripts and replace the gene_id with a composite string like this: MSTRG.4|ENSMUSG00000025903|ENSMUSG00000104217|ENSMUSG00000033813
(this actually reflects the data from the first example file you attached above)
I wrote a quick perl script doing just that, as an example:
https://gist.github.com/gpertea/b83f1b32435e166afa92a2d388527f4b

I realized I am unclear about the source/origin of those Input_python_example*.txt files, how they differ from the stringtie_merge_example.txt .. The script I posted above might not work for those as they do not seem to have ref_gene_id in place, but only ref_gene_name sometimes..

Thank you very much for your quick and in-depth response. It really helped me to understand the reasoning behind the MSTRG-tags better. I will try to modifiy the stringtie_merge.gtf file as you suggested.
The input_python files are the output of running stringtie with the output of stringtie_merge as the reference, meaning the output of the following line of code:
maindir=pwd; for i in $( ls -d Mouse ); do echo $i; cd $i; stringtie -e -B -p 8 -G $maindir/merged.annotated.gtf -o Deseq2/$i.gtf Aligned.sortedByCoord.out.bam; cd $maindir; done
But since it is far more practical to follow your advice to change the stringtie_merge.gtf before re-running stringtie with the merge.gtf as the reference file (because I then only have to edit one file and not one file per sample) it is not a problem that the pearl script might not work with the attached input_python_example files.

Thank you very much for your help!
The perl script you provided worked just fine on the merge.gtf file. I inspected the file manually afterwards, and it seems only a relatively small number of ENSMUSG "report" to different MSTRG-identifiers, while most of the MSTRGs and ENSMUSG are 1:1 pairs, but there are many MSTRGs, that represent Transcripts from multiple ENSMUSG-loci (see sample.txt). The attempt to run stringtie with the perl-script manipulated merged.gtf was successful, meaning that I have input files for the python script in order to obtain raw gene counts for further analysis in Deseq2.
My follow up question is: How should I best process those MSTRGs after obtaining the raw gene count table (when I am not interested in novel transcripts)? My first impulse is to simply add the gene counts for identical ENSMUSGs up, discarding the MSTRG tags, before feeding the raw gene counts as input to Deseq2, So that I would have stable gene IDs for downstream analysis. Would that procedure be mathematically sound?
sample.txt

Oh, actually if you are "not interested in novel transcripts", which are indeed complicating things (yet are the whole reason for the "full" protocol with stringtie --merge) then perhaps you would be better off running the "alternate", faster protocol, as mentioned in issue #170 and in StringTie's manual web page?
That way you could directly get expression estimates (read counts) for all those ENSMUSG genes separately, for each sample -- by simply using the reference annotation file instead of the merged GTF produced by stringtie --merge. I somehow assumed you knew that was an option..

Thank you very much for your help! I will try the shortened protocol. My apologies that I somehow must have overlooked that solution.

Hello everyone,
After running that script I still can't associate the gene_id to the transcripts.
Do you have any advice to see what am I doing wrong?
thank you


'No test found in suite' failure with passWithNoTests enabled

Describe the bug

I have a test suite with no tests, similar to

describe('My feature', () => {
  describe('my test suite', () => {
    // no tests here
  });
});

I am testing with passWithNoTests enabled (full command is vitest run --passWithNoTests --logHeapUsage)

My test suite fails:

 FAIL  tests/suite.test.ts > My feature > my test suite
Error: No test found in suite my test suite

I expected the test suite to pass.

I might be able to open a PR if you agree this should be changed.
Reproduction
https://stackblitz.com/edit/vitest-dev-vitest-dubrh2?file=test%2Fsuite.test.ts
System Info
System:
    OS: Linux 5.15 Ubuntu 20.04.6 LTS (Focal Fossa)
    CPU: (12) x64 12th Gen Intel(R) Core(TM) i5-1235U
    Memory: 2.16 GB / 7.62 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 18.16.0 - ~/.nvm/versions/node/v18.16.0/bin/node
    npm: 9.5.1 - ~/.nvm/versions/node/v18.16.0/bin/npm
  npmPackages:
    @vitest/coverage-v8: ^0.33.0 => 0.33.0
    vitest: ^0.33.0 => 0.33.0

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

This is intended behavior. All test files should contain at least one test.
This option just makes it so your tests don't fails if there are no test files matching filters.


angular http response.text() now returns [object Object]. Previously [{"Id":1,"Name":"BUC ...

It's not a big issue, and a little awkward to ask now :) ... as I get my array of objects from .json() in my last issue.
I pretty much cleared my logging after that so I've only just noticed. Feel free to keep things the way they are as its just a nice to know.
let text = response.text();
console.log(text);

results in:
JS: =Debug===============
JS: [object Object],[object Object],[object Object]

It is a string (I checked)... just a very insignificant string.
The '.text()' version should be the result body (i imagine its due to the content type header, which was fixed in core to automatically serialize) when the command should result in the content body in text format.
Previous text:
JS: [{"Id":1,"Name":"BUCS","Logo":"content/logos/bucs-logo.jpg","CompetitionCount":4},{"Id":2,"Name":"SUTL","Logo":"content/logos/sutl.jpg","CompetitionCount":8},{"Id":1008,"Name":"South East Region","Logo":null,"CompetitionCount":4}]

The later is quite useful for debugging, but I don't really have a use case beyond that.
I have a workaround for the moment:
var subscription = requestObservable.subscribe(response => {
	let text = response.text();
	let json = response.json();

	this.Notify(text);
	let jsonAsText = JSON.stringify(json)
	this.Notify(jsonAsText);
});

Results in:
JS: =Debug===============
JS: 2016-02-25T23:27:46.876Z: [object Object],[object Object],[object Object]
JS: ======================
JS: =Debug===============
JS: 2016-02-25T23:27:46.878Z: [{"Id":1,"Name":"BUCS","Logo":"content/logos/bucs-logo.jpg","CompetitionCount":4},{"Id":2,"Name":"SUTL","Logo":"content/logos/sutl.jpg","CompetitionCount":8},{"Id":1008,"Name":"South East Region","Logo":null,"CompetitionCount":4}]

@matt4446 Indeed. When the response-type of the XHR request is json it is automatically parsed and returned as an object. The text() method of the response object will only call .toString() of the xhr.response object - so you will get the [object Object],[object Object],[object Object] string.
Note, that if the response type is not json you will get the actual string of the response.
Does this makes sense?

I only use the .json() and .text() in combination for debugging really. It saves on loading up fiddler. So as I pointed out it isn't a big problem, however, I'll point out one scenario where it might be trouble in the last paragraph.
@vakrilov Yes. I understand the implementation, but...
The docs state text(): Returns the body as a string, presuming toString() can be called on the response body. and json() : Attempts to return body as parsed JSON object, or raises an exception.. It doesn't mention response types.
I would go with technically you may be playing by the rules, but the browsers are being less ambiguous and display any request's body as text (it had for my JSON results at least). Its been a few months since I've checked but text() on the web would always present the body in text and the 'json()' would always present it as an object, providing it could serialize it. [object Object] etc is unfortunate as it does not represent the body of the request.
I'll also add that not all APIs respond the way they should. SendGrid's V2 API was bad like that returning JSON but as a text response type, which leads to: json(), blob() and text() ... should they cause serialization of the request body / reserialize / continue with the automated serialization... I'll leave it to your implementation and judgment. There is just the potential that it could limit calling some APIs without knowing some additional hacks.


[dependencies] Update cryptography to 3.1.1

Update the cryptography library to allow the latest version, ensure tests pass and the main features work correctly.

Hi!
Is anyone working on this? it's seems a easy picking!

@DaffyTheDuck you can work on it 😄


issue #57 - fix for disappearing generator list

fixed tasks.json and launch.json to address some updates
introduced new options for showQuickPick call

Signed-off-by: Brian Fitzpatrick<EMAIL_ADDRESS>

Closing as this has been around for over a year and never fixed. We fixed it in our fork and re-distributed.


feature: 提供验证访问模块可达的接口 (closed #441)

Codecov Report

Merging #447 (00f7d98) into V2.2.0-rc (2dec855) will increase coverage by 0.02%.
The diff coverage is 85.71%.

@@              Coverage Diff              @@
##           V2.2.0-rc     #447      +/-   ##
=============================================
+ Coverage      70.32%   70.35%   +0.02%
=============================================
  Files            269      269
  Lines          19675    19688      +13
=============================================
+ Hits           13837    13851      +14
+ Misses          5838     5837       -1

Impacted Files
Coverage Δ

apps/node_man/urls.py
100.00% <ø> (ø)

apps/node_man/views/__init__.py
76.92% <85.71%> (+7.69%)
:arrow_up:

apps/node_man/handlers/job.py
86.14% <0.00%> (-0.26%)
:arrow_down:

apps/utils/unittest/base.py
83.82% <0.00%> (+5.88%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dec855...00f7d98. Read the comment docs.


Adding Tags To Emails

Description
Is there a way to add tags to outbound emails?
Additional info

Craft version: 3.7.44
PHP version: 7.4.3
Database driver & version: MySQL 8.029
Plugins & versions: 2.1.0

Is there any news on this? This would be a great feature

I would also really appreciate this feature so that I can tag transactional emails on a per-site basis.


failed to renew lease kafka/controller-leader-election-helper: timed out

Describe the bug
Kafka Operator restarts every 5 minutes with this error
E0318 15:30:52.925394       1 leaderelection.go:320] error retrieving resource lock kafka/controller-leader-election-helper: Get "https://<IP_ADDRESS>:443/api/v1/namespaces/kafka/configmaps/controller-leader-election-helper": context deadline exceeded
I0318 15:30:54.821644       1 leaderelection.go:277] failed to renew lease kafka/controller-leader-election-helper: timed out waiting for the condition

Steps to reproduce the issue:
run the operator
Expected behavior
don't crash every 5 minutes
Additional context
Using chart version '0.4.6'. This didn't always happen it started sometime in the last couple months.

Hi @pmatheson-greenphire sorry for the delayed response. Can you please share more information about your setup? What is the kubernetes version you are using? Are you updated the k8s version as well when upgrading the operator?

k8s version: v1.17.12-eks-7684af

I think my cluster just got in a wonky state after I create and deleted several hundred topics a few times with low resources allocated to the controller. I recreated everything an bumped the controller resources. Seems to be working without any errors now. Thank you for responding.

Hi,
I am facing same issue with operator where Kafka Operator keeps restarting after running couple of minutes. I have allocated enough resources on Kafka Operator.
E0202 12:05:55.694251       1 leaderelection.go:367] Failed to update lock: resource name may not be empty
I0202 12:05:55.694312       1 leaderelection.go:283] failed to renew lease kb/controller-leader-election-helper: timed out waiting for the condition
{"level":"error","ts":"2023-02-02T12:05:55.694Z","logger":"setup","msg":"problem running manager","error":"leader election lost","stacktrace":"main.main\n\t/workspace/main.go:207\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:255"}
Attached operator values.yaml for more information.
I am using Kubernetes version 1.24.6.
Thanks,
Laukik
values.yaml.zip

@laukik85 Thanks for the update on this, reopening this and will look into it soon


OAS-7199 | Add MLServicesSize UsageItem

@Robert-Stam Yes, correct. Just wanted to tackle the API services first