changes made in edit.html form

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #37
Type of change

Added bootstrap4 CDN
New responsive form is added.

Please delete options that are not relevant.

[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Adding screenshots of the form
-Desktop view

-Tablet view

-Mobile view

Change base branch to develop as its already mentioned in readme
content and changes looks fine but I would advice you to double check for minor errors if any.

Conflicting files
edit.html

resolve these

Please resolve the conflicts asap!

Please do this asap.

Please do this asap.


Migrate types from DefinitelyTyped

I imported the entire history of @types/rdf-js by cloning the original repo and running git filter-branch --subdirectory-filter types/rdf-js -- --all.
Please rebase-merge

[x] reworded the DT commit messages so that PR/issue numbers correctly link to the original repository
[x] split the declarations in three parts and re-exported from index.d.ts so that it's easier to find the types by spec
[x] add test script to compile the types
[ ] add linting
[ ] Continuous integration

fixes #1

For linting I propose  the recommended eslint setup from @typescript-eslint/eslint-plugin
For CI I would add a GitHub Actions workflow

Very nice. Made my round of comments on the reviews and will give some time for others.
I would propose we merge this as soon as we can resolve the standing comments and once the last two steps are completed. That way we'll at least have a master branch we can reference for issues and PRs.

Any idea why the GitHub Action did not kick in?


removed moment as a dependency

Title
Description of what's changing
Removed moment as a dependency to cut down package size
What else might be impacted?
...
Checklist
[ ] Tests are written and maintain or improve code coverage
[ ] I've tested this in my application using yarn link (if applicable)
[ ] You consent to and are confident this change can be released with no regression

@skodamarthi this is ready for review now

Moment is gone completely now. And I rebased since we have had a decent number of contributions since I branched. I also found a slightly cleaner way to pick out the bits of the formatted string we want... and added a comment besides to make it clearer when we look back in a years time. Ready for review and merge when you have some time @skodamarthi


%(a&b|c)s : are field names disallowed in b and c ?

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[X] I've verified that I'm running yt-dlp version 2023.03.04 (update instructions) or later (specify commit)
[X] I've searched known issues and the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Please make sure the question is worded well enough to be understood

@pukkandan commented:
%(a&b|c)s is kinda like if a, "b" else "c".

I can't get this to work. In my tests the field names are printed instead of the field values:
yt-dlp ZYlALC1Pmv4 --ignore-config --print "filesize_approx"
468853974 # ok this works

yt-dlp ZYlALC1Pmv4 --ignore-config --print "%(filesize_approx&id)s"
id

yt-dlp ZYlALC1Pmv4 --ignore-config --print "%(filesize_approx&url)s"
url

yt-dlp ZYlALC1Pmv4 --ignore-config --print "%(filesize_approx&filesize_approx)s"
filesize_approx

yt-dlp ZYlALC1Pmv4 --ignore-config --print "%(filesize_approx&filesize_approx|filesize_approx)s"
filesize_approx

Does that mean in the syntax above, a is a field name whereas b and c are only strings in which field names are not recognized ?
So is there no possibility to say:
If field a exists, output field b, else field c ?
I am trying to learn the syntax rules, but the link in README

The special sequences may be formatted according to Python string formatting operations

didn't mention the replacement rules. I have tried to search on the net, but I don't even know the search term I would have to use. I tried "printf style string formatting" and "special sequences in Python" and "Python string formatting operations" but I didn't come anywhere close to the syntax that is in use here apparently. So despite my best efforts, I am sorry to have to ask. Any advice where I could study the correct syntax would be most welcome.
Provide verbose output that clearly demonstrates the problem

[ ] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
No response

Does that mean in the syntax above, a is a field name whereas b and c are only strings in which field names are not recognized ?

Yes, as denoted by "" in my explanation

I am trying to learn the syntax rules, but the link in README
didn't mention the replacement rules.

This is not using Python syntax, but our customized mini-language. See "Default" and "Replacement" in https://github.com/yt-dlp/yt-dlp#output-template

So is there no possibility to say: If field a exists, output field b, else field c ?

Not exactly, but you can say 'if a, a, else c' using %(a,c)s - see "Alternate" in output template doc for details.
Technically, what you want can be achieved by some smart use of --parse-metadata, but I would need to see exact use-case and example to help.

Could I have known that from README or isn't it mentioned there yet ?

this

See "Default" and "Replacement" in yt-dlp/yt-dlp#output-template

so I have to use something bulky like --print "%(filesize_approx&~)s%(filesize_approx|)s%(filesize_approx& bytes)s".

Yes

what you want can be achieved by some smart use of --parse-metadata

Thank you. I'll see first if I can work it out with what's available to me. But could you give me a hint what idea you had in mind regarding --parse-metadata because that parameter doesn't allow if/then/else/and/or/not/etc. either, no ?

Similar to bashonly's suggestion in #6848

No, similar to -f's mini-language, it's a language we built for this specific use-case. Full documentation is in readme. It is extended from printf-style formatting, hence why we reference its docs for relevant parts.

That is not an intended use and just happens to work due to a quirk of >. Don't blame me if it breaks in future.

Pukkandan commented: We'd have to look into adding a new operator if this is needed.

... because as you can see from the above, this has obvious advantages.

That comment is not related to this issue 😕. I am not going to add a new operator for this since it can already be achieved, even though in a bit lengthier form.

Is there really no easy way of saying "just take everything from the field as string" (like: %(filesize_approx>~%S bytes)s ) ?

Would be possible, but probably confusing since > is specifically intended for date time formatting. And if we are doing it, I'd want %d, %f etc to also work, which would conflict with some of the existing operators. Maybe we could instead implement %(filesize&%s bytes|)s? That would be much less ambiguous.

Date/time Formatting: Date/time fields can be formatted according to strftime formatting by specifying it separated from the field name using a >. E.g. %(duration>%H-%M-%S)s, %(upload_date>%Y-%m-%d)s, %(epoch-3600>%H-%M-%S)s

>%s means epoch of the datetime.

ok thanks. Why isn't it menioned here ?

I am not sure. Maybe because it's support is OS dependent? (We do some extra magic to support it on all OSes)

--print "%(epoch>%Y is a good year)s"
2023 is a good year

... I thought it would be much easier to slightly enhance this than the "full rewrite" with the "tokenizer/parser" thing you talked about above. Or would it be needed either way?

No, this should be easier. What we cannot implement without rewrite is nesting brackets - like %(a& %(b)s)s because python regex has no way to keep proper track of bracket counts.

I decided to use the str.format syntax instead of %s as it provides more flexibility. So now you can do %(filesize_approx>~{} bytes|)s

Was a typo. Updated https://github.com/yt-dlp/yt-dlp/issues/6843#issuecomment-1520143696


"Ghost" feedback messages

Might be related to #7, but: since the release of 1.5.0 (I think) I have unclearable unread notifications:

At the same time, the badge shows 25
Doesn't look like I'm having this "beta" new Notification center, at least I don't see it on the site and the extension does not detect it.
Trying to reset unreads or mark all as read doesn't clear this state.

I'm extremely busy until the weekend, for now you can try to uninstall and reinstall the extension, but if that doesn't fix it, this might take me a few days to get sorted.

No problem, it's not urgent! Just wanted to make you aware of it.
Reinstall didn't help. I'm attaching a dump of the storage before reinstall.
localStorage_storage_Deviant-Notify.json.txt
sync_storage_Deviant-Notify.json.txt

v1.5.1 has just been pushed to the extension sites which should resolve this issue, if it does not work for you please reopen the issue.

It works fine, thanks!


Regenerated jazzy docs for SwiftCurrent

Linked Issue:

Checklist:

[ ] Is the linter reporting 0 errors?
[ ] Did you comply with our styleguide?
[ ] Is there adequate test coverage for your new code?
[ ] Does the CI pipeline pass?
[ ] Did you update the documentation?
[ ] Did you update the sample app?
[ ] Do we need to increment the minor/major version?
[ ] Did you change the public API?
[ ] Have you done everything you can to make sure that errors that can occur are compile-time errors, and if they have to be runtime do you have adequate tests and documentation around those runtime errors? For more details.

If Applicable:

[ ] Did you test when the first item is skipped?
[ ] Did you test when the last item is skipped?
[ ] Did you test when middle items are skipped?
[ ] Did you test when incorrect data is passed forward?
[ ] Did you test proceeding backwards?

If Public API Has Changed:

[ ] Did you deprecate (rather than remove) any old methods/variables/etc? Our philosophy for deprecation.
[ ] Have you done the best that you can to make sure that the compiler guides people to changing to the new API? (Example: the renamed attribute)
[ ] If necessary, have you tested the upgrade path for at least N-1 versions? For example, if data persists between v1 and v2 then that upgrade should be tested and as easy as we can make it.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@72c375b). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage        ?   97.25%
=======================================
  Files           ?       35
  Lines           ?      985
  Branches        ?        0
=======================================
  Hits            ?      958
  Misses          ?       27
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72c375b...a275199. Read the comment docs.


feat(action): prepare for release of Krystal fork

Change relevant bits to be able to release and tag a Krystal owned fork of the upstream jimeh/release-please-manifest-action action.

😐 this PR was supposed to be against the https://github.com/krystal/release-please-manifest-action repo.


Fixed Testcase failure issue

fixed Sum(dimension column) was failing for other data type then double

LGTM


Replace Buffer constructor

new Buffer(...) is deprecated and unsafe. Could it be replaced with Buffer.from(...) in these places?

Any feedback from upstream ?
If it helps I am considering to pick this change in forked project:
https://github.com/abandonware/bleno/


ci: Test on Safari 16 and 15

Since Safari 16 became the default on macos-11 images in GitHub, we are updating our homedir installation of Safari 14 to Safari 15 instead.  This also renames that entry in the matrix from Safari-14 to Safari-old, in recognition of the fact that we will probably have to continue updating this.

Confirmed that Safari 15 is working in place of 14.


Borwein quintic Pi calculation method hangs near last steps

When computing a million digits, the last step hangs up and does not proceed. Is the iteration stuck in n'th root finding?

Somehow the program reaches a point where the argument to a call to the square root function is negative, resulting in NaN. The program hangs in the square root function (erroneously) forever.
Even if you break this error and pass zero instead of negative at this last iterative step, the result of pi is not correct to within 1 million digits.

OK, let's Put this side-by-side with exactly the same calculation as done in wide-decimal and see the exact operation at which the results differ.
This one can be done on a rainy day in the future...

Recent investigation shows that (at the moment) unknown result of add/sub/mul or div seems to underflow/overflow a tiny amount when the exponent is around $10^{-500,000}$. This causes a very small, negative number to be passed to square root. But it is not square root that is the problem, rather this aforementioned overflow/underflow that occurs previously.


Base Feature: Make table-sort-js do a stable-sort by default.

Make table-sort-js do stable sorting so the user does not experience inconsistent sorting when sorting with columns that have duplicated values in their <td>.
https://streamable.com/dz2q12#

You can make non-stable sorts stable relatively easily. Instead of returning 0 from the comparison function, compare the indexes.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#sort_stability
Since version 10 (or EcmaScript 2019), the specification dictates that Array.prototype.sort is stable.


feat: add CREATEUSER and NOCREATEUSER option for user create/alter

NOCREATEUSER should be default option when not specified.
And when create/alter user, the options should be subset of current user.

Cc @CharlieSYH

Maybe a dumb question, but I cannot find NOCREATEUSER option in PostgreSQL doc.

Maybe a dumb question, but I cannot find NOCREATEUSER option in PostgreSQL doc.

PG uses CREATEROLE/NOCREATEROLE:
https://www.postgresql.org/docs/current/sql-createrole.html
But we don't have "roles" in RIsingWave. I guess that's why we use CREATEUSER/NOCREATEUSER instead, right? @yezizp2012

Maybe a dumb question, but I cannot find NOCREATEUSER option in PostgreSQL doc.

In PostgreSQL, it's NOCREATEROLE. Since we don't have role concept yet, just use use instead for now.


lxd/db/networks: Fix NULL description

Closes #8051
Signed-off-by: Stéphane Graber<EMAIL_ADDRESS>

@tomponline @brauner good to go. We'll want that in before we release 4.7 to stable.

Testsuite passed

@stgraber thanks for this. Is there a particular reason that the description field isn't marked NOT NULL like the other fields in that table? New networks are created with an empty string for network (which is why the patch didn't trigger that issue in our tests). Could we make description NOT NULL like the other columns to avoid this class of error in the future?
CREATE TABLE "networks" (
    id INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL,
    project_id INTEGER NOT NULL,
    name TEXT NOT NULL,
    description TEXT,
    state INTEGER NOT NULL DEFAULT 0,
    type INTEGER NOT NULL DEFAULT 0,
    UNIQUE (project_id, name)
);

The reason is that it's a field we've added after the fact I believe. So we didn't set not null to deal with the initial schema update without having to potentially copy the entire table due to sqlite limitations.
Looks like the generated database code handles such cases properly but the hand written one didn't.

@stgraber I can put a patch in that will re-create the table with NOT NULL if it cannot be altered, have done something similar when adding project ID column for networks.


Pretty print assembly code using rich syntax highlighting

This PR closes issue #97 and adds syntax highlighting to pyjion.dis.dis_native().
It also adds an extra modifier to the package like pyjion[dis] that optionally requires rich and `distorm.
Here is an example output:

Should i add an extra modifier to the package like pyjion[dis] that optionally requires rich and distorm ?

Yes please @C4ptainCrunch

Should i add an extra modifier to the package like pyjion[dis] that optionally requires rich and distorm ?

Yes please @C4ptainCrunch

Awesome!! thanks @C4ptainCrunch

Awesome!! thanks @C4ptainCrunch


Update HSC chain rpc link

RPC link from official docs: https://docs.hoosmartchain.com/#/mainnet

Is this an archive node @kizenY ?

Hi, do you know if this is an archive node @kizenY ?

Yes, it is.I have tried to get data of first 2k blocks and succeed.

The archive node ( https://http-mainnet2.hoosmartchain.com) has resumed synchronizing. Node "https://http-mainnet.hoosmartchain.com is full node.


Fix tests failures

:tophat: What is the goal?
The goal fo this PR is fixing some issues introduced in previous PRs.

We fixed the bug related with the uninstall in mac and centos os system that the env variable doesn't exist as sudo user.
We stopped the processes related with CLAI when user uninstall the system.
We modified the docker image for the integration tests.

:memo: How is it being implemented?

modified the python uninstall script to check the directory or the env variable.
We stop the process when uninstall as sudo. a A argument has missed.
we modify the docker to install new mandatory dependencies for system works perfectly.

:boom: How can it be tested?
Some integration tests continue falling. Please @TathagataChakraborti or @MayankAgarwal check those skills that are throwing errors because are falling out of the integration tests too.

Thanks! @flipper83 🤗
@kpfadnis is looking at the howdoi situation, @MayankAgarwal please take a look at the other error from man page explorer.


Lotus integration - signature does not match

When using the wasm library to derive an address and private key and sign a message, the lotus jsonrpc sends back a "signature does not match" error.
We ran into this same issue with the Ledger once, here's the relevant conversation/fix:
usually people normally deal with compressed public keys (33 bytes)
[7:45 AM]
the are completely equivalent... any secp256k1 library will take one or the other without problem, etc. etc..
[7:45 AM]
the thing is.. addresses hash the pubkey... so then.. it is not the same if you use one or the other
[7:45 AM]
and for the same pubkey/privkey pairs, there were 2 addresses
[7:46 AM]
depending on which format is used (compressed/uncompressed)
[7:46 AM]
this can actually be a serious issue
[7:47 AM]
we have to use uncompressed everywhere or things will fail

This issue will be covered as part of this existing task https://github.com/Zondax/filecoin-rs/issues/33


Add Semantic Versioning link

Journey tests a failing because the Federal Senate's website is down. I'm merging this inspire of that.


feat(template): add notios instead of npm-run-all

v0.1.0と書いているのでまだ動きません。
0.0.9 で試すとこのようになります。

Types of changes

[ ] Bug fixes

resolves #

[ ] Features

resolves #

[ ] Maintenance
[ ] Documentation

Changes

...

Additional context
Community note

Please upvote with reacting as :+1: to express your agreement.

選択肢にする予定


Cannot make offline calls to FB using Laravel Queue API

Trying to fetch user's photos using Laravel Queue API
But even simple call like this throws SammyK\FacebookQueryBuilder\FacebookQueryBuilderException
Facebook::setAccessToken($user->access_token['access_token']);
$user = Facebook::object('me')->fields('id', 'name')->get();

I'm using long lived access token here.
What am I doing wrong?
Thanks for help.

What's the error message you're getting?
try {
    $user = Facebook::object('me')->fields('id', 'name')->get();
} catch (SammyK\FacebookQueryBuilder\FacebookQueryBuilderException $e) {
    dd($e->getMessage());
}

it says "Graph returned an error response."

What if you did:
dd($e->getPrevious()->getMessage());

Now I got "Invalid OAuth access token."

Yeah so the access token you're using is not valid for that endpoint. Either because it's the wrong type of token or it has expired. You can debug it and find out what's wrong with it.

"Invalid appsecret_proof provided in the API argument"
Sorry for last post. This is the exception I got.

Anyways thanks for the help.
I can debug it now.  :) Make sure your app secret is correct. It's used to generate the app secret proof. Good luck!


Second y plotted series lines seems have an offset

Hi,
I'm plotting two series using the following plot command in DFN Pro 1.10.3:
display.plot(t, { }, { x: "date", y: "new_confirmed", y2: "avg_new_confirmed_7days" });
The avg_new_confirmed_7days lines has an offset as you can see on joined screen capture.
On December 12 data point, the avg value is :  1508.71... but shows in the 2500-3000 range on the plot.

Is this a problem or did I just forgot to pass some parameters?
A second question, is it possible to mix a line and a bar chart. I went to C3 they have this kind of graph, did try to do the same in DFN. It doesn't seems to work.
Here is my plot command : display.plot(t, { type: 'bar', types: { avg_new_confirmed_7days: 'line'} }, { x: "date", y: "new_confirmed", y2: "avg_new_confirmed_7days" });
Thank you,
Stéphane

Hi @konato, can you please submit an example notebook that shows the problem?
It can't do mixed charts yet. But I'll look into that soon.

You can synchronize the y axis' by setting min/max values for each, like this:

I'm working on mixed charts. But it will be a couple of weeks before I do a new build.

It does work fine.
It will be great to have mixed charts in the future.
Thank you very much for your help.

I've implemented mixed charts (published yesterday) in the Plot library (https://www.npmjs.com/package/plot).
This will be included in the next release of DFN (v1.10.4) which I'll aim to publish in the next couple of weeks.
By the way, I'm also working to improve the documentation for the Plot function, you can check it out here:
https://data-forge-notebook.github.io/plot/
Let me know if you have any feedback about the docs!

@konato just letting you know that I've implemented the mixed charts in DFN.
Version 1.10.4 will be release in the next couple of weeks.
When you get it make sure you look at the charts example notebook to see how it works.


NRE in HullIntegrity patches

Reported in ticket-3435 on RT discord:
2020-04-08T16:46:26 FYLS [ERROR] CRITICAL ERROR, PLEASE REPORT:
Delegate OnAttackSequenceEnd - Standard for message type OnAttackSequenceEnd failed with exception
Object reference not set to an instance of an object
  at CBTBehaviorsEnhanced.HullIntegrity.AttackDirector_OnAttackSequenceEnd+<>c.<ResolveTurretHullBreaches>b__3_0 (BattleTech.MechComponent mc) [0x00006] in <d5abd8016f094a7ab65c144b8f36957c>:0
  at System.Linq.Enumerable+WhereListIterator`1[TSource].ToList () [0x00017] in <1b13ba6391c74847bbc3eddc86df7eee>:0
  at System.Linq.Enumerable.ToList[TSource] (System.Collections.Generic.IEnumerable`1[T] source) [0x0001f] in <1b13ba6391c74847bbc3eddc86df7eee>:0
  at CBTBehaviorsEnhanced.HullIntegrity.AttackDirector_OnAttackSequenceEnd.ResolveTurretHullBreaches (BattleTech.Turret targetTurret) [0x0002d] in <d5abd8016f094a7ab65c144b8f36957c>:0

Also
2020-04-24T01:38:01 FYLS [ERROR] CRITICAL ERROR, PLEASE REPORT:
Delegate OnAttackSequenceEnd - Standard for message type OnAttackSequenceEnd failed with exception
Object reference not set to an instance of an object
  at CBTBehaviorsEnhanced.HullIntegrity.AttackDirector_OnAttackSequenceEnd+<>c__DisplayClass4_0.<ResolveVehicleHullBreaches>b__0 (BattleTech.MechComponent mc) [0x00006] in <d5abd8016f094a7ab65c144b8f36957c>:0
  at System.Linq.Enumerable+WhereListIterator`1[TSource].ToList () [0x00017] in <1b13ba6391c74847bbc3eddc86df7eee>:0
  at System.Linq.Enumerable.ToList[TSource] (System.Collections.Generic.IEnumerable`1[T] source) [0x0001f] in <1b13ba6391c74847bbc3eddc86df7eee>:0
  at CBTBehaviorsEnhanced.HullIntegrity.AttackDirector_OnAttackSequenceEnd.ResolveVehicleHullBreaches (BattleTech.Vehicle targetVehicle) [0x00044] in

Implemented various nullity guards and pre-processing to try to avoid these errors. Likely fixed in 0.5.0


Forward Events to Elasticsearch

Currently it is not possible to forward Kubernetes Events to Elasticsearch.
It would be good to see a new forwarding "channel" to Elasticsearch.
Features for Elasticsearch integration:

[ ] All Events into one indice.
[ ] Per namespace Elasticsearch indice for Events.
[ ] Elasticsearch with and without authentication.

I'll probably take a stab at this for at least the general functionality.

We have removed the event forwarder in https://github.com/appscode/kubed/releases/tag/v0.12.0-rc.0. Closing.


No module named Armchair

After following the installation steps exactly, I still cannot import Armchair, and Xcode is giving an error - No such module 'Armchair'
I'm not really sure where to go from here. I'm using the latest Xcode and latest OSX.

I am having the same problem with XCode 7.0 and 7.1. Any idea how to solve it? All dependencies are met.

I finally added cocoapods support so this issue can now be closed.


General Issue: Find Solution for Links in Documentation

Background Information
There are several issues regarding links in the admiral documentation:

Links to vignettes in function documentation do not work when viewed in RStudio help tab consider for example the links in the details section of ?derive_vars_query
We can not link to new vignettes on the NEWS page (using absolute links to the not yet release documentation) because our link check and the CRAN link check will fail.
When the documentation is build locally, e.g., for review, some links point to the release documentation and not the local one.
pkgdown::build_site() does not build the README correctly because README.md has to be created from README.Rmd first.

Definition of Done
Requirements

All links in the documentation should work in the HTML output as well as in the RStudio help tab. They should work in a local build and in a published build. They should work for multi versions docs.

The syntax for linking to vignettes within the package and to vignettes of other admiral packages should be the same.

Links to vignettes of other packages should link to the devel version for local builds and devel builds, they should link to the main version for main, pre-release, and patch build.

[ ] Create a proposal fulfilling the requirements

[ ] Get agreement from admiral team

[ ] Implement proposal

Links to vignettes in function documentation do not work when viewed in RStudio help tab consider for example the links in the details section of ?derive_vars_query

I see two options:

Using \code{vignette("queries_dataset", package = "admiral")} as it working with pkdown. For roxygen links it's possible to add the link e.g. [\code{vignette("queries_dataset", package = "admiral")}](../doc/queries_dataset.html)
This solution create 2 links on pkgdown website. Roxygen link can be removed by tweak_link proposed in pharmaverse/admiralci#13.

We can create roxygen links and and tweak them during pkgdown build. pharmaverse/admiralci#13

We can not link to new vignettes on the NEWS page (using absolute links to the not yet release documentation) because our link check and the CRAN link check will fail.

For links in NEWS it's working in similar way as above.
- Add [`vignette("queries_dataset", package = "admiral")`](./doc/queries_dataset.html) links

When the documentation is build locally, e.g., for review, some links point to the release documentation and not the local one.

We should not use the absolute links and put prioritize roxygen compatibility.

pkgdown::build_site() does not build the README correctly because README.md has to be created from README.Rmd first.

In my opinion in that the issue should be tweak during pkgdown build.
Definition of Done

All links in the documentation should work in the HTML output as well as in the RStudio help tab. They should work in a local build and in a published build.

The roxygen and local compatibility should be prioritized and tweak in pkgdown build when needed.

They should work for multi versions docs.

The different versions only exists in pkgdown site. For proper build the links between versions it's important to set the URL param in DESCRIPTION file. e.g. https://pharmaverse.github.io/admiraldev/main/

The syntax for linking to vignettes within the package and to vignettes of other admiral packages should be the same.

For vignettes link to other packages I recommended to use only code section \code{vignette("queries_dataset", package = "admiral")} but it's still possible to create links similar to above example. The pkgdown website lining will be cover with URL param from target package DESCRIPTION file.

Links to vignettes of other packages should link to the devel version for local builds and devel builds, they should link to the main version for main, pre-release, and patch build.

In local environment the links can only redirect to the package that is installed or build in your library. For pkgdown website the links will be base on URL param of build environment. In any case of extra needs it can be covered by tweak_page.
Note: Currently the pkdown allow to tweak links only by modify the pkgdown namespace. I hope having the hooks in pkgdown allow for simply solution. pharmaverse/admiralci#13
I'm happy to discuss the solution so let me know what you think.

@galachad , Tweaking the links make sense to me.
What should we do if your PR at pkgdown is not accepted?
Could we also tweak the link text? I would rather prefer "See the Queries Dataset Documentation vignette." than "See the vignette("queries_dataset", package = "admiral").".

See #1444 for additional past discussion

Hey all - this impacts all admiral packages.  Could CI team look more in to this issue?


fix gpg API panic when no verification

fix #1383 @sapk please help to confirm.

Not tested but LGTM

Thx for the quick fix of my mistake.

LGTM

Trusted LGTM


Commodity Influence

Add analysis of commodity prices on dependent asset (ie How does oil price affect the price of BP)

Don't plan to add this.


fix(Makefile): Restore local build/install capability

I am a big fan of #340 (because I am a fan in general of containerizing our builds), but it had the unfortunate side-effect of removing any possibility of building the client from source on a Mac and then using that client on a Mac-- this is something I do frequently and I suspect I'm not the only one.
This PR restores that possibility through:
$ make binary-build install

@krancour LGTM, sorry about the breakage

LGTM3


@@servername and SERVERPROPERTY('ServerName') are the same, only case is different

Description of the issue
Backup scripts don't start as described on your site :
"Added a check in DatabaseBackup that @@SERVERNAME is the same as SERVERPROPERTY('ServerName'). The check is only performed if Always On is enabled.
The background for this is that sys.fn_hadr_backup_is_preferred_replica is not working correctly if @@SERVERNAME is not correct.
"
Because of the case sensitivety of the sql server instance @@servername and SERVERPROPERTY('ServerName') are different in case and stop starting the backup jobs.
/********* VALUES *******/
select
@@servername as [@@servername], --Returns the name of the local server that is running SQL Server.
SERVERPROPERTY('ServerName') as [ServerProperty_ServerName], --Both the Windows server and instance information associated with a specified instance of SQL Server.
SERVERPROPERTY('MachineName') as  [ServerProperty_MachineName], -- Windows computer name on which the server instance is running. For a clustered instance, an instance of SQL Server running on a virtual server on Microsoft Cluster Service, it returns the name of the virtual server.
SERVERPROPERTY('ComputerNamePhysicalNetBIOS') as [ServerProperty_ComputerNamePhysicalNetBIOS], -- NetBIOS name of the local computer on which the instance of SQL Server is currently running.
@@SERVICENAME as  [@@SERVICENAME],
name as [sysservers_name],
data_source as [sysservers_data_source]
from sys.servers
/******** Results *******/
@@servername = SERVER06\INST01
ServerProperty_ServerName = server06\INST01
ServerProperty_MachineName =	server06
ServerProperty_ComputerNamePhysicalNetBIOS	= SERVER06
@@SERVICENAME	=  INST01
sysservers_name = 	SERVER06\INST01
sysservers_data_source = SERVER06\INST01
Is this "work as designed" with a special reason or is this a little bug ?
SQL Server version and edition
Microsoft SQL Server 2019 (RTM-CU15) (KB5008996) - 15.0.4198.2 (X64)   Jan 12 2022 22:30:08   Copyright (C) 2019 Microsoft Corporation  Enterprise Edition: Core-based Licensing (64-bit) on Windows Server 2019 Datacenter 10.0  (Build 17763: ) (Hypervisor)
Version of the script
Version: 2020-12-31 18:58:56
What command are you executing?
FULL, DIFF and LOG backups; One example :
EXECUTE dbo.DatabaseBackup
@Databases = 'SYSTEM_DATABASES',
@Directory = N'\xxxxxxxxx.local\Share\Backups\xxxxxxxx\SQL Backups',
@BackupType = 'FULL',
@Verify = 'Y',
@Compress = 'Y',
@CheckSum = 'Y',
@CleanupTime = 360,
@MaxFileSize=10240,
@LogToTable = 'Y'
What output are you getting?
[SQLSTATE 01000] (Message 50000)  The @@SERVERNAME does not match SERVERPROPERTY('ServerName'). See https://docs.microsoft.com/en-us/sql/database-engine/install-windows/rename-a-computer-that-hosts-a-stand-alone-instance-of-sql-server.

I resolved the problem in the availability group by renaming the servernames with the correct CASE :
sp_dropserver <'old_name\instancename'>
GO
sp_addserver <'new_name\instancename'>, local
GO
The job runs without error BUT.... no transactionlog backups are made...
If I run the command manually I get no errors but I dont see any backups starting:
EXECUTE dbo.DatabaseBackup
@Databases = 'USER_DATABASES',
@Directory = N'\xxx.local\Share\Backups',
@BackupType = 'LOG',
@ChangeBackupType = 'Y',
@Compress = 'Y',
@CheckSum = 'Y',
@CleanupTime = 72,
@LogToTable = 'Y'
Output looks normal but no transacyionlog backups or cleans or done (see output below). Any suggestions ?
**Date and time: 2022-07-22 09:11:54
Server: xxx\INST01
Version: 15.0.4236.7
Edition: Enterprise Edition: Core-based Licensing (64-bit)
Platform: Windows
Procedure: [master].[dbo].[DatabaseBackup]
Parameters: @Databases = 'USER_DATABASES', @Directory = '\xxx.local\Share\Backups', @BackupType = 'LOG', @Verify = 'N', @CleanupTime = 72, @CleanupMode = 'AFTER_BACKUP', @Compress = 'Y', @CopyOnly = 'N', @ChangeBackupType = 'Y', @BackupSoftware = NULL, @CheckSum = 'Y', @BlockSize = NULL, @BufferCount = NULL, @MaxTransferSize = NULL, @NumberOfFiles = NULL, @MinBackupSizeForMultipleFiles = NULL, @MaxFileSize = NULL, @CompressionLevel = NULL, @Description = NULL, @Threads = NULL, @Throttle = NULL, @Encrypt = 'N', @EncryptionAlgorithm = NULL, @ServerCertificate = NULL, @ServerAsymmetricKey = NULL, @EncryptionKey = NULL, @ReadWriteFileGroups = 'N', @OverrideBackupPreference = 'N', @NoRecovery = 'N', @URL = NULL, @Credential = NULL, @MirrorDirectory = NULL, @MirrorCleanupTime = NULL, @MirrorCleanupMode = 'AFTER_BACKUP', @MirrorURL = NULL, @AvailabilityGroups = NULL, @Updateability = 'ALL', @AdaptiveCompression = NULL, @ModificationLevel = NULL, @LogSizeSinceLastLogBackup = NULL, @TimeSinceLastLogBackup = NULL, @DataDomainBoostHost = NULL, @DataDomainBoostUser = NULL, @DataDomainBoostDevicePath = NULL, @DataDomainBoostLockboxPath = NULL, @DirectoryStructure = '{ServerName}${InstanceName}{DirectorySeparator}{DatabaseName}{DirectorySeparator}{BackupType}{Partial}{CopyOnly}', @AvailabilityGroupDirectoryStructure = '{ClusterName}${AvailabilityGroupName}{DirectorySeparator}{DatabaseName}{DirectorySeparator}{BackupType}{Partial}{CopyOnly}', @FileName = '{ServerName}${InstanceName}{DatabaseName}{BackupType}{Partial}{CopyOnly}{Year}{Month}{Day}{Hour}{Minute}{Second}{FileNumber}.{FileExtension}', @AvailabilityGroupFileName = '{ClusterName}${AvailabilityGroupName}{DatabaseName}{BackupType}{Partial}{CopyOnly}{Year}{Month}{Day}{Hour}{Minute}{Second}{FileNumber}.{FileExtension}', @FileExtensionFull = NULL, @FileExtensionDiff = NULL, @FileExtensionLog = NULL, @Init = 'N', @Format = 'N', @ObjectLevelRecoveryMap = 'N', @ExcludeLogShippedFromLogBackup = 'Y', @StringDelimiter = ',', @DatabaseOrde...
Version: 2020-12-31 18:58:56
Source: https://ola.hallengren.com
Date and time: 2022-07-22 09:11:54
Database: [schedbe]
State: ONLINE
Standby: No
Updateability: READ_WRITE
User access: MULTI_USER
Recovery model: FULL
Encrypted: No
Is accessible: Yes
Availability group: xxxag1
Availability group role: PRIMARY
Availability group backup preference: NONE
Is preferred backup replica: No
Differential base LSN:<PHONE_NUMBER>685600235
Last log backup LSN:<PHONE_NUMBER>956000001
Last log backup: 2022-07-19 15:07:14
Log size since last log backup (MB): 623.051
Date and time: 2022-07-22 09:11:54
Database: [test]
State: ONLINE
Standby: No
Updateability: READ_WRITE
User access: MULTI_USER
Recovery model: FULL
Encrypted: No
Is accessible: Yes
Availability group: xxxag1
Availability group role: PRIMARY
Availability group backup preference: NONE
Is preferred backup replica: No
Differential base LSN:<PHONE_NUMBER>2400001
Last log backup LSN:<PHONE_NUMBER>2400001
Last log backup: 2022-05-06 11:00:03
Log size since last log backup (MB): 4.30078
Date and time: 2022-07-22 09:11:54
Completion time: 2022-07-22T09:11:54.8002394+02:00_**

the log backups you see in the output above are done manually...

I found a workaround. I put an extra parameter @OverrideBackupPreference='Y' and then it worked. Even when all my Always On nodes are in "Any replica" Backup preference... So I think there will be a little bug in the Backuppreference check (in combination with the Latin1_General_BIN collation), which is overrided by this parameter...

I hit the same problem when I move the new server.
Servername named in camelcase standart. e.g MpsServerSql1  Server collation TURKISH_CS_AI
also server joined an AlwaysON.
Cae senstivity is the main prıblem I guess.
select @@SERVERNAME
MpsServerSql1
select  SERVERPROPERTY('ServerName') r
MPSSERVERSQL1
up-to-date your scripts.
SQL Server Version:
Microsoft SQL Server 2019 (RTM-CU29) (KB5046365) - 15.0.4405.4 (X64)   Oct 23 2024 08:45:19   Copyright (C) 2019 Microsoft Corporation  Developer Edition (64-bit) on Windows Server 2019 Standard 10.0  (Build 17763: ) (Hypervisor)
I can handle easily dropserver and addserver. Maybe case sensitive could be forgotten.

I always create a database management database with case insensitive collation, problem solved. Master and msdb should be left as is. But there could be a convert to upper or lower case...but SQL variant...

I always create a database management database with case insensitive collation, problem solved. Master and msdb should be left as is. But there could be a convert to upper or lower case...but SQL variant...

I thought may be case insensitivy was overlooked. I made my comment thinking that. Otherwise I am totally agree with you.

I have experienced that users have been running into issues with backups not being performed, because sys.fn_hadr_backup_is_preferred_replica was returning 0 on all replicas.
I found out that sys.fn_hadr_backup_is_preferred_replica was not working correctly if @@SERVERNAME was not returning the same value as SERVERPROPERTY('ServerName'). This could happen if the server has been renamed. It could be that it can happen in other scenarios as well.
Therefore I added this check:
  IF @@SERVERNAME <> CAST(SERVERPROPERTY('ServerName') AS nvarchar(max)) AND SERVERPROPERTY('IsHadrEnabled') = 1
  BEGIN
    INSERT INTO @Errors ([Message], Severity, [State])
    SELECT 'The @@SERVERNAME does not match SERVERPROPERTY(''ServerName''). See ' + CASE WHEN SERVERPROPERTY('IsClustered') = 0 THEN 'https://docs.microsoft.com/en-us/sql/database-engine/install-windows/rename-a-computer-that-hosts-a-stand-alone-instance-of-sql-server' WHEN SERVERPROPERTY('IsClustered') = 1 THEN 'https://docs.microsoft.com/en-us/sql/sql-server/failover-clusters/install/rename-a-sql-server-failover-cluster-instance' END + '.', 16, 1
  END

My reasoning so far has been that it is better to have this check, than having users run into issues with backups not being performed.

There is another similar issue, https://github.com/olahallengren/sql-server-maintenance-solution/issues/692

This will perhaps fix it?
IF UPPER(@@SERVERNAME) <> UPPER(CAST(SERVERPROPERTY('ServerName') AS nvarchar(max)))
AND SERVERPROPERTY('IsHadrEnabled') = 1

The question is how sys.fn_hadr_backup_is_preferred_replica behaves, when there are differences in the casing.
I was searching for it and I found some people reporting issues.
I will review the code in sys.fn_hadr_backup_is_preferred_replica.

I was checking the code of sys.fn_hadr_backup_is_preferred_replica on SQL Server 2022 CU15.
It has this comment:
    -- Hotfix for IcM356152806
    -- Under case sensitive collation, replica_server_name and @@servername
    -- is not considered the same if the letter case is different

I also see UPPER in several places.
I will implement the change in DatabaseBackup that @Stiffboard suggests.


Transform file:// URIs to remote URI inside comments and hover result markdown in remote mode

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.69.2
OS Version: macOS 12.0.1

Steps to Reproduce:

connect to a remote host and open a ts file with following content (file path and remote authority may differ)

/**
 * remote uri in rendered jsdoc markdown: ok
 * [link](vscode-remote://ssh-remote+host/home/semesse/test/test.ts)
 *
 * file uri in rendered jsdoc markdown: not ok
 * file uri in comment: not ok
 * [link](file:///home/semesse/test/test.ts)
 *
 * link in rendered jsdoc markdown (resolved to file://): not ok
 * {@link a}
 */
const a = 1

only the link with vscode-remote:// will navigate to the correct file path and line, others will throw a File not found error

Those URIs are intended for local machine, but for remote ssh they must be transformed before accessing from UI. Maybe we should transform file:// URIs to remote ones in hovers and comments?
I'd be happy to work on fixing this issue 🥰

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.70.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!


Derpibooru characters

First. Thank you for this awesome project.
Second. It seems rating and characters doesn't work on derpibooru. Only artist tag. Will it be included in the future?
What steps will reproduce the problem?
Try to use %character% or just click on picture. Only artist tag is different color.
What is the expected behavior? What do you get instead?
Character name and rating download correctly after using %character% and %rating%. I get whatever I put in "Options>Save" in my case - unknown.
How often does this problem occur? On which sources?
all the time. on derpibooru and trixiebooru.
What version of the program are you using? On what operating system?
5.5.0
Please provide any additional information below
This program is awesome.

Indeed, I can reproduce.
It actually seems to have been reported months ago without me taking action on it (oops) in issue #699.
I'll take a look and update the tag parser to take those into account.

This program is awesome.

Thanks! :smile:

Thank you.


Fix headers white blurring style bug in mobile (light mode)

Issue:

Header css in the mobile view is unable to detect and change the background color based on the light or black mode in mobile view.

TO-DOs

[ ] Fix the background style so that background response and change dynamically based on the light or dark mode (mobile view)

Thank you !
Code  commit reference: ef8a0f2

I can take this. Thank you:)


St fix to support ruby19

Fix to support ruby 1.9

- replace colon with arrows as colon with String Object as hash keys
not supported in 1.9
Update initialize block

virtual attributes are not initialized properly
#reset method has necessary code to initialize the virtual attributes.
just update initialize block by calling #reset

@sthirugnanasambandam How come you're using ruby 1.9? I see that support for ruby 1.9.3 has already ended.
I'm not sure I'd want to support ruby versions that even the official ruby lang won't be supporting. Though I'm not using too many 2.0+ features right now, I feel that I should at least keep it at least in rubies that are being supported.
So that's why I'm curious why you're still using 1.9.x?

@iamwilhelm We are in process of moving to ruby 2.x. Ours is a mammoth project. So we will be migrating very soon. Having said that the ruby 1.9.3 support has just ended couple of months back and  I am pretty sure there are tons of teams out there still using 1.9.3 or in process of migrating to 2.x.


Records disappearing after reconciliation

 On some occasions during the user testing sessions in June (see https://github.com/OpenRefine/CommonsExtension/issues/28), when users reconciled files against Wikimedia Commons, the records would all disappear from the main screen area, and users would have to delete several of the facets generated during the reconciliation process in order to bring back the row view of records.
To Reproduce
Steps to reproduce the behavior:

First, open a project which contains file names to be reconciled with Wikimedia Commons.
Then, reconcile the files names column.
Finally, check if any unexpected behaviours - especially around faceting reconciliation judgements occur.

Current Results
 This doesn't seem to happen consistently, so hard to reproduce, but sometimes all the rows disappear unexpectedly.
Expected Behavior
Rows should remain in view and reconciliation judgements should be shown to users.
Screenshots
 [See video snippet](https://drive.google.com/file/d/1aNFKJ_5B5YDK32h63PLwmIEmASnQ_QKe/view?usp=sharing)
Versions

Operating System: This has happened both in Windows 10 and on Mac (OS Monterey).
Browser Version: latest Chrome and Firefox browsers.
JRE or JDK Version: latest version avilable.
OpenRefine: 3.7 snapshot releases from June.

Datasets
 N/A
Additional context
 N/A

@lozanaross The rows are filtered from view because there seems to be a final "no matching rows" condition that results finally?
It seems it's from the culmination of:

the initial 4 Facets (which seem initially duplicated as well ?!?) - Title_DE judgment (2 each), Title_DE best candidates score (2 each)
and then 4 more Facets applied after the quick reconciling against Type=Null (notice the quick yellow recon banner).

I would try to reproduce by expanding all the Facets fully and double-checking their selections.


Disable code formatting

Issue
In my environment:

Windows, WSL2, terminal inside VSCode

When I am getting responses back from the model with code changes, my laptop seems to grind to a halt when it is displaying the code. My guess is that this is due to code formatting for the terminal, since it seems very fast to display all the text outside of the code. I would like to simply disable the code formatting/highlighting that is going on.
Note that this gets progressively slower the longer the code block is to the point where I am getting one line every few seconds.
Version and model info
Aider 0.60.0
Model: Sonnet

This looks like a duplicate of #930. Please see the comments there for more information, and feel free to continue the discussion within that issue.
I'm going to close this issue for now. But please let me know if you think this is actually a distinct issue and I will reopen this issue.


[FP]: CVE-2015-3208 on activemq-broker-5.16.5.jar

Package URl
<EMAIL_ADDRESS>CPE
cpe:2.3:a:org.apache.activemq:activemq-broker:5.16.5:*:*:*:*:*:*:*
CVE
CVE-2015-3208
ODC Integration
{"label"=>"Maven Plugin"}
ODC Version
7.1.1
Description
CVE-2015-3208 affects Artemis ActiveMQ (cpe:2.3:a:apache:activemq_artemis:-:*:*:*:*:*:*:*)
but activemq-broker-5.16.5.jar (cpe:2.3:a:org.apache.activemq:activemq-broker:5.16.5:*:*:*:*:*:*:*) is from ActiveMQ "classic" which is not affected by this CVE.

This is a finding originating from OSSINDEX, which has recently exposed more of its vulnerability research.
Experience from earlier FP reports suggests that the finding is likely to be correct. If you believe it to be a real false positive it would be best to open a ticket with them for re-evaluation of their vulnerability analysis.

It seems as someone else already did it. See https://github.com/OSSIndex/vulns/issues/307

OSSINDEX does not respond to that ticket anymore, even though the project has good reasons this is not an issue (wrong project and code never shipped): https://issues.apache.org/jira/browse/AMQ-8984
Is there a way to get this out of dependency-check? I suppressed it now, but this is a good example of a bad CVE wasting peoples time


Add history tracking for various activities

Summary
This PR adds history tracking for the following activities:

Creating a node (for non-source nodes)
Updating a node
Posting availability state
Creating namespace
Setting column attribute on a node
Deleting a node
Restoring a node
Adding/updating a materialization
Creating a dimension link
Creating a tag
Updating a tag
Tagging a node

It also adds a node field to History, which will help us track and return activity at the node level, rather than just at an individual entity level.

Test Plan
Added tests for all of the above. Planning on recreating dj.demo.db with the above history tracking in place.

[X] PR has an associated issue: #624
[X] make check passes
[X] make test shows 100% unit test coverage

Deployment Plan

@samredai and @agorajek I've updated this so that EntityType maps onto what we actually store (so LINK, ATTRIBUTE, MATERIALIZATION etc), with ActivityType being straighforward actions like CREATE, UPDATE,
and DELETE. I also went through the checklist in https://github.com/DataJunction/dj/issues/624 and added a bunch of them

@shangyian I am reading through your PR and I feel like the context keyword is really not needed anywhere in this new code. Am I missing something or have you arrived at a conclusion that history by node context means much more than history (or activity) by node ?

@agorajek That's a good point -- I renamed it to node 😄


Connection to ***.ssh.wpengine.net closed by remote host.

Hello
The GitHub action suddenly failing on the following error:
debug1: client_input_channel_req: channel 2 rtype exit-status reply 0
debug1: channel 2: free: client-session, nchannels 3
debug1: channel 1: free: mux-control, nchannels 2
OpenSSH_8.4p1, OpenSSL 1.1.1k  25 Mar 2021
debug1: Reading configuration data /etc/ssh/ssh_config
debug1: Authenticator provider $SSH_SK_PROVIDER did not resolve; disabling
sent 15,208 bytes  received 41,025 bytes  5,919.26 bytes/sec
debug1: multiplexing control connection
debug1: channel 1: new [mux-control]
debug1: channel 2: new [client-session]
total size is 4,244,568  speedup is 75.48
debug1: Sending command: cd sites/***  && wp page-cache flush
debug1: mux_client_request_session: master session id: 2
debug1: channel 0: free: /github/home/.ssh/ctl/7260324bf49f620e4d53622ca448e04791d88411, nchannels 3
debug1: channel 1: free: mux-control, nchannels 2
debug1: channel 2: free: client-session, nchannels 1
debug1: fd 2 clearing O_NONBLOCK
Connection to ***.ssh.wpengine.net closed by remote host.
Transferred: sent 18904, received 43660 bytes, in 609.8 seconds
Bytes per second: sent 31.0, received 71.6

Can you please advise?

Hey there @vitaly-dt !
Given the issue you're describing, could you create a ticket with support and reference this issue here? That will give us some more context to help troubleshoot the issue.
If possible, provide support with the entire run logs as well as the action workflow configuration yml you're using.
Thank you,
The WP Engine engineering team

Closing
Was resolved by support - the issue was with the server itself
Thanks for the quick response!


Need a douc

I can not find the function to get the token with timestamp info etc. Some doucs are needed.

https://github.com/DoggyWalkie/eth-contract/blob/0757bb050262ff40bcc6fc6ecba439f4700bce49/build/contracts/Dogi.json#L213-L226
These parameters don't work.
  doginstance.mintWithTokenURI(web3.eth.accounts[0], 0, app.data);

Error: Invalid number of arguments to Solidity function


Add LTS and Commercial Support information to README.md

Add badges and information for LTS policy and commercial support.

@seabaylea - http://github.com/CloudNativeJS/ModuleLT seems to be an empty repo at the moment, I assume that's going to have content added soon?
Tests seem to have failed because default Node on Travis has moved up from 8.x to 10.x, which we don't yet support.  I will create a separate PR to change the Travis build to just build on 6 and 8, although I guess we should also start supporting Node 10 fairly soon.

Yes, that's expected - the repo will be populated in the next couple of days.

Ok, thanks. I've fixed the tests on master, no point rebasing as this PR only changes the README.


load language from server then re-render?

I have 4 language store in local, en, tw, jp, zh.

now I need support Russian
I am loading Russian language by http request, and then
I18n.translations["ru-BY"] = output;

and clearly it need re-render to make it work.
I know this is not exactly react-native-i18n issue,
I need looking for a way to re-render the app.
I just thought maybe ask here and somebody know the answer
:smile:
I have tried

react-native-restart not working, it's restart, not re-render, it just restart.
forceUpdate() not working
https://blog.callstack.io/react-native-handling-language-changes-on-android-the-right-way-c883056a8f5c  this one work, but only work change language setting in Android, and when switching to the app, app would reload and now language is right. but not what I need.

Anyone know how to re-render the app once it done loading language from remote server?
Thanks!

I am using React Native 0.52 and develop for Android

my react-native info (if you want know more about my env)

because I am using React Navigation, I thought about reset route to make it reload. and it kinda work.
https://github.com/react-navigation/react-navigation/issues/1990#issuecomment-332782092
https://reactnavigation.org/docs/navigation-actions.html#reset
I am still trying this, but so far it seem work.
would come back and update once I got some progress

If you use https://github.com/react-community/react-native-languages and i18next + react-i18next, it is easy to rerender your app :)

@zoontek Would try, Thank you!

I would close this issue in 1-3 day, after my problem solved,
and maybe put some note or useful code sample here too.
:smile:

I wrote a little demo App, https://github.com/1c7/react-native-langauge-hot-reload-example

@1c7 Awesome work, thanks you!

:D

it turns out that demo app I wrote is not working for loading language from the remote server.
(the UI wouldn't refresh, even the addResourceBundle success, and I successfully add the Russian language)
it works for change language in the Android Setting. and switch back to App, it would work.
anyway, eventually I use following code sample to make it work
export default translate('translation')(HomeScreen);
export default translate('translation')(LogsScreen);
export default translate('translation')(ProfileScreen);

@ic7 hey, I want to make the same thing - download new languages from server and make the app to use them - but I dont get your last message here. Where did you use that code? And dont you need to re-render whole app when you download new language that was not there before and user have the currant locale the same as the one right downloaded?

@davidbilik
Hi I use "translate" from i18next
import { translate } from 'react-i18next';

and then,
export default translate('translation')(More)

use the translate to wrap my component, exactly like your code there.
I think the problem is language code,
in my case, Russian is RU-BY, not just ru
you should try console.log(i18n) after the language is loaded.
and also print out current language code, see if they match.
hope it help.

@1c7 my server response looks like
{
   "en" : { ... },
   "fr" : { ... }
}

but the language from the system (android) is fr-FR. You mean that the response from the server should have the fr-FR key? I have the project at home and I cant try it now :( Also, do you use that i18nextProvideror do you set the i18n instance to translate method yourself as I do above?

@davidbilik

you don't need to change the 'fr' key from the server, just use fr-FR when using addResourceBundle
maybe using an if statement like

if(key == 'fr'){
   addResourceBundle( blah blah blah )
}

I use both I18nextProvider  and translate to make it work
The code example below is from my real project (Bitbucket private repo):

in root folder App.js, MainScreen is first one in StackNavigator

and in MainScreen I use react-native-tab-view to make the bottom tab
so code look like this:

inside HomeScreen

hope it help

if there are more question, feel free to ask, I would help as much as I can

In the app I have a list of languages when I select 1 in which whether the application changes the language in real time
@zoontek  @1c7  @davidbilik

@helloo0-0oword I tried change language in real time.
no success. now I am not developing React Native anymore.
working on web app at the moment (Vue.js)
can't help. sorry.
good luck

@helloo0-0oword I have migrated to i18next after the read of this issue https://github.com/AlexanderZaytsev/react-native-i18n/issues/68


Add an organized folder for C++ code as well.

A lot of programmers prefer to code interview questions in C++. Please add a C++ folder so that we can contribute.

I think so.

While I agree with your sentiment, I don't think I would be able to maintain it and I cannot rely on others to maintain it.


Drop support for rails 4.0 and 4.1

EoL for both was 2016-06-30
http://weblog.rubyonrails.org/2016/6/30/Rails-5-0-final/
PT continued to support them for 15 months after EoL.

Will this result in a 8.0.0 release of paper_trail?

Will this result in a 8.0.0 release of paper_trail?

Yes, the release that includes this change will be a major version bump. There are three breaking changes lined up for 8.0.0 (see changelog under "Unreleased"). If you have other suggestions for breaking changes, now's the time :)

Is there something that Ruby 2.1 breaks, just out of curiosity?

Is there something that Ruby 2.1 breaks, just out of curiosity?

Hi Ben, Good question, and I'm glad you're asking it :) I'll answer over at https://github.com/airblade/paper_trail/pull/994 as this PR is for dropping rails 4.0 and 4.1 support.


Add note about git tags for versioning

I'll go ahead and add this requirement to the pull request checklist as well.


⚠ API has degraded performance

In 0765533, API ($ZESTY_API) experienced degraded performance:

HTTP code: 403
Response time: 1236 ms

Resolved: API performance has improved in 075310f.


Update mockito-scala to 1.16.1

Updates org.mockito:mockito-scala from 1.16.0 to 1.16.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.mockito", artifactId = "mockito-scala" } ]

labels: test-library-update, semver-patch

Superseded by #117.


Update draft order for a given league

Acceptance Criteria

Provide the new draft order in the body with the user ids and the updated pick order
There can not be a gap between pick orders

e.g. pick 1, pick 2 and pick 4

The largest pick position can not exceed the players in the league

Blocked on #224


[Bug] OAP keeps restarting using h2 and helm

Search before asking

[?] I had searched in the issues and found no similar issues.
(similar but fixed issues linked at the end)

Apache SkyWalking Component
OAP server (apache/skywalking)
What happened
I tried to setup minimal Skywalking via helm for the first time however I cannot reach UI which which seems to be caused by OAP not starting.
k8s tells me: Readiness probe failed: dial tcp <IP_ADDRESS>:12800: connect: connection refused
2023-05-13 12:15:52,783 com.zaxxer.hikari.HikariDataSource 82 [main] INFO  [] - HikariPool-1 - Start completed.
2023-05-13 12:15:52,786 org.apache.skywalking.oap.server.core.storage.model.ModelInstaller 43 [main] INFO  [] - table: alarm_record does not exist. OAP is running in 'no-init' mode, waiting... retry 3s later.
2023-05-13 12:15:55,787 org.apache.skywalking.oap.server.core.storage.model.ModelInstaller 43 [main] INFO  [] - table: alarm_record does not exist. OAP is running in 'no-init' mode, waiting... retry 3s later.
2023-05-13 12:15:58,788 org.apache.skywalking.oap.server.core.storage.model.ModelInstaller 43 [main] INFO  [] - table: alarm_record does not exist. OAP is running in 'no-init' mode, waiting... retry 3s later.

however init job seem to be run fine
2023-05-13 12:15:15,402 org.apache.skywalking.oap.server.library.server.grpc.GRPCServer 131 [main] INFO  [] - Bind handler MetricServiceGRPCHandlerV3 into gRPC server <IP_ADDRESS>:11800
2023-05-13 12:15:15,404 org.apache.skywalking.oap.server.library.server.grpc.GRPCServer 131 [main] INFO  [] - Bind handler AccessLogServiceGRPCHandler into gRPC server <IP_ADDRESS>:11800
2023-05-13 12:15:15,409 org.apache.skywalking.oap.server.library.server.grpc.GRPCServer 131 [main] INFO  [] - Bind handler AccessLogServiceGRPCHandlerV3 into gRPC server <IP_ADDRESS>:11800
2023-05-13 12:15:15,410 org.apache.skywalking.oap.server.library.server.grpc.GRPCServer 131 [main] INFO  [] - Bind handler SatelliteAccessLogServiceGRPCHandlerV3 into gRPC server <IP_ADDRESS>:11800
2023-05-13 12:15:15,506 com.linecorp.armeria.common.util.SystemInfo 237 [main] INFO  [] - hostname: skywalking-oap-init-ghwpw (from /proc/sys/kernel/hostname)
2023-05-13 12:15:16,216 com.linecorp.armeria.server.Server 807 [armeria-boss-http-*:12800] INFO  [] - Serving HTTP at /<IP_ADDRESS>:12800 - http://<IP_ADDRESS>:12800/
2023-05-13 12:15:16,218 org.apache.skywalking.oap.server.core.storage.PersistenceTimer 58 [main] INFO  [] - persistence timer start
2023-05-13 12:15:16,221 org.apache.skywalking.oap.server.core.cache.CacheUpdateTimer 46 [main] INFO  [] - Cache updateServiceInventory timer start
2023-05-13 12:15:16,659 org.apache.skywalking.oap.server.starter.OAPServerBootstrap 53 [main] INFO  [] - Version of OAP: 9.2.0-cb8845a
2023-05-13 12:15:16,660 org.apache.skywalking.oap.server.starter.OAPServerBootstrap 56 [main] INFO  [] - OAP starts up in init mode successfully, exit now...

What you expected to happen
OAP to just start up without manual intervention on first install
How to reproduce
Just run the following command against a 1 node k8s minikube cluster
helm upgrade --install "skywalking" oci://registry-1.docker.io/apache/skywalking-helm  \
      --set oap.image.tag=9.2.0 \
      --set oap.storageType=h2 \
      --set oap.replicas=1 \
      --set ui.image.tag=9.2.0 \
      --set ui.replicas=1 \
      --set elasticsearch.enabled=false

Anything else
I found the same error in issues, however it seemed to be fixed in 9.1.0 and also was related to elastic not h2
likely related:
https://github.com/apache/skywalking/discussions/8701
https://github.com/apache/skywalking/pull/8958
https://github.com/apache/skywalking/issues/9486
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Don't use H2 for helm deployment. SkyWalking helm is only designed for product use, but the default H2 setup is only in-memory, which is conflicting.


permissioned  denied when start repository watcher

When no storage provided to core operator(no volume mount), the core operator needs to create  /opt/helm itself. But we do not permit core service to do mkdir

Fixed by this PR. The root cause is that the controller do not have that permission to do mkdir at path /opt/helm(helm path changed to /opt/helm with environment variables )


After removing background image with a "delete" button, I can't get a new image to load

I found this post: https://github.com/scottcheng/cropit/issues/146 and followed it and got it working to where I can load an image into the cropit area and then click my "cancel" button to remove the image. The problem then becomes that when I click on the browse button again and click on an image, it does not load it into the cropit image area until I first refresh the page. Can anyone point me in the right direction as to how I can reinitialize the upload feature once my "cancel" button is clicked? Here's my code:

Select new image

	Cancel

Your image will appear here where it can be moved accross to suit where you want to crop it.

	<input type="file" class="cropit-image-input" />

join the club #26

Your code worked pretty well for me.
Here is how I used it:
HTML

	Upload a Photo

		<input type="range" class="cropit-image-zoom-input" />

			Remove Photo

	<input type="file" class="cropit-image-input" name="photo" id="photo" capture="camera" />
	<input type="hidden" name="photo_url" id="photo_url" value="" />
	<?php /** / ?>export<?php /**/ ?>

JS
/**
 * Adding crop support
 */
function patch_activateCrop()
{
	var $imageCropper          = jQuery('#image-cropper'),
		$imageEditContainer    = $imageCropper.find('#image-cropper-edit'),
		$imagePreviewContainer = $imageCropper.find('.cropit-image-preview-container'),
		$imagePreview          = $imageCropper.find('.cropit-image-preview'),
		$imageZoomRange        = $imageCropper.find('input.cropit-image-zoom-input'),
		$imageRemove           = $imageCropper.find('.cmb2-remove-wrapper');

	$imageCropper.cropit({
		onImageLoading: function() {
			$imagePreviewContainer.hide();
			$imageZoomRange.hide();
			$imageRemove.hide();
		},
		onImageLoaded: function() {
			$imagePreviewContainer.show();
			$imageZoomRange.show();
			$imageRemove.show();
		},
	});

	$imageRemove.on('click', function(e) {
		e.preventDefault();
		if ( $imagePreview.hasClass('cropit-image-loaded') )
		{
			$imagePreview
				.css('background-image', '') //remove preview-images
				.removeClass('cropit-image-loaded');
			$imagePreviewContainer.hide();
			$imageZoomRange.hide();
			$imageRemove.hide();
		}
	});

	// When user clicks select image button, open select file dialog programmatically
	jQuery('.select-image-btn').on('click', function(e) {
		e.preventDefault();
		jQuery('.cropit-image-input').trigger('click');
	});
}

@jupitercow I still have no idea how my code is working for you? I can load an image but if I cancel and then try to load another, nothing ever loads in the cropit window.
That said, I tried your javascript with my HTML and it seems to work fine. So I'll need to go through your JS to pinpoint exactly what you're doing differently from me.
On another topic, do you know how I'd take the cropped image and send it server-side? The other cropping functionality I was using was jCrop and it would actually give some coordinates that I could save into some hidden text inputs and pass that server side in order to crop everything. I guess I haven't really made the connection with cropit on how to get the cropped image server side so I can process it, save it, etc.

I am just using this:
var imageData = jQuery('#image-cropper').cropit('export');
if ( imageData ) {
	imageData.replace(/^data:image\/(png|jpg);base64,/, "");
	jQuery('input#photo').val(imageData);
}

It saves the cropit data url for the image into an input before the form gets submitted.
Then you have to look at how to handle on the server side for your language. I am using PHP, and you can save to a file. On the most recent project, I am using WordPress, and the wp_upload_bits() function is key.

Oh, that's right. I remember that now from when I first started looking at this way back when. It gives you the base64 data of that image, doesn't it? I'm using Python on the backend with the Django framework and if I remember I was struggling to process a base64 data. I'll have to revisit it.

Hi guys ,
I  am also facing this. I have an image gallery and file upload function. Whenever user pick any pics from library then it is not  work properly. May it's help full to you guys.below Mention code is  work  fine  with  me  :
**Step  1 Html Setup & CSS **

              <input type="file"  name="browseFile" id="browseFile" class="cropit-image-input">

Resize image

              <input type="range" name="range" class="cropit-image-zoom-input">
              <input type="hidden" name="image-data" class="hidden-image-data" />

              Browse Image

It must be an image file.
.png, .jpg, .jpeg, .gif, .bmp

CSS
`

`
Step 2 Cropit Initialization
//Sdet Image  Cropping Tool
$('.image-editor').cropit(
{
"smallImage":"reject",
"onImageErrorfunction": function (fileObj){
custom_message(fileObjError.message);
},
"onImageError":function(fileObjError) {
custom_message(fileObjError.message);
},
"onImageLoadedfunction":function(fileObject){
  console.log(fileObject);

},
"onOffsetChange":function(fileOffsetObj){
  console.log("offset Change "+fileOffsetObj);
  var imageUrl = $('.image-editor').cropit('export');
  $('.campFile1,#campFile').attr('src',imageUrl);

}

});
Step 3 : Clean uo  Image  Editor
$('input.cropit-image-input').val('');
$('.cropit-preview').removeClass('cropit-image-loaded');
$('.cropit-preview-image').removeAttr('style');
$('.cropit-preview-image').attr('src','');

Worked for me when i set the value of the file input to empty.
$('input[type="file"]).val('');

@breoesculta Thanks. I'll give that a try when I jump back into this project. I've had to put it on the back burner a bit.

@deronsizemore You´re welcome ;)


[DO NOT MERGE] Auto PR to update dependencies of istio

This PR will be merged automatically once checks are successful.
none

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
2a063bc85745f434e802c2dcbc1891ae1a9c7944
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm


In tag.yml, fix permissions, make a GH release, and dynamically infer version yaml path

Quick fixes + enchangement to tag.yml

incomplete ci is not testing changes in this PR, so not going to wait for merge


Add 04-21-2023 proposal.

IPFS Preview: https://app.aave.com/governance/ipfs-preview/?ipfsHash=0x8e036cb7b5c10028564ba8d16c19e1b8bda48fa41edb904caec571908a76b1d3
In accordance with https://governance.aave.com/t/gauntlet-recommendations-for-eurs-on-v3-polygon/12798

Propose transaction simulation: https://dashboard.tenderly.co/public/safe/safe-apps/simulator/c16b4f61-8aac-462f-bcb0-bb4114398eea


types: changing UnwrapRef to a simpler implementation

This is a type I was really careful not to break anything, I hope I haven't missed anything.
Overall this shouldn't affect much, but it improves when using Ref on a generic function.
I'm porting my vue composables library to use the new reactivity and because of the nature of the library, my functions are quite generic, and ran into some issues with the typescript type checking.
It works using @vue/vue-composition, but when I use @vue/reactivity it has some errors, and not really readable errors since the typescript type is quite weird to because of the recursive implementation.
Full method working with plugin
Reproduction code
const f = <T extends Promise<any>, TArgs extends Array<any>>(
  fn: (...args: TArgs) => T
) => {
  const t: Ref<T> = {} as any
  const a: TArgs = {} as any
  t.value = fn(...a) // doesn't work, because return value is not Ref<T>
  t.value = fn(...a) as UnwrapRef<T> // doesn't work with prev UnwrapRef but works with this PR
}

I don't believe with a recursive approach we will be able to fix this without a cast, because I've raised https://github.com/microsoft/TypeScript/issues/33942 some time ago,  but seems to be a design limitation so I don't expect it to change any time soon.
EDIT: Having issues with Portal and inferring the children on h
EDIT2: Still having issues with the portal seems to not be inferred, the issue being with ref<VNodeChildren<TestNode, TestElement>> be able to be converted to RawChildren  therefor not be able to match with the overload
Argument of type 'UnwrappedArray<string | number | boolean | void | VNodeChildren<TestNode, TestElement> | VNode<TestNode, TestElement> | null>' is not assignable to parameter of type 'RawChildren'.
  Type 'UnwrappedArray<string | number | boolean | void | VNodeChildren<TestNode, TestElement> | VNode<TestNode, TestElement> | null>' is not assignable to type 'VNodeChildren<any, any>'.
    The types returned by 'pop()' are incompatible between these types.
      Type 'string | number | boolean | void | UnwrappedArray<string | number | boolean | void | VNodeChildren<TestNode, TestElement> | VNode<TestNode, TestElement> | null> | UnwrappedObject<...> | null | undefined' is not assignable to type 'string | number | boolean | void | VNodeChildren<any, any> | VNode<any, any> | null | undefined'.
        Type 'UnwrappedArray<string | number | boolean | void | VNodeChildren<TestNode, TestElement> | VNode<TestNode, TestElement> | null>' is not assignable to type 'string | number | boolean | void | VNodeChildren<any, any> | VNode<any, any> | null | undefined'.
          Type 'UnwrappedArray<string | number | boolean | void | VNodeChildren<TestNode, TestElement> | VNode<TestNode, TestElement> | null>' is not assignable to type 'VNodeChildren<any, any>'.
            The types returned by 'pop()' are incompatible between these types.
              Type 'string | number | boolean | void | UnwrappedArray<string | number | boolean | void | VNodeChildren<TestNode, TestElement> | VNode<TestNode, TestElement> | null> | UnwrappedObject<...> | null | undefined' is not assignable to type 'string | number | boolean | void | VNodeChildren<any, any> | VNode<any, any> | null | undefined'.
                Type 'UnwrappedArray<string | number | boolean | void | VNodeChildren<TestNode, TestElement> | VNode<TestNode, TestElement> | null>' is not assignable to type 'string | number | boolean | void | VNodeChildren<any, any> | VNode<any, any> | null | undefined'.

EDIT3: It can be fixed by casting to the correct type:
h(Portal, { target }, children.value as VNodeChildren<TestNode, TestElement>)

EDIT4: merged with master and made a few changes to be able to pass the testing.
Has been some time since I opened this PR, but my problem was getting error:
t.value = fn(...a) // it works in the PR and master!? 😕
t.value = fn(...a) as UnwrapRef<T> // doesn't work PR and master 😕

The value of this PR is the error messages, instead of having the unreadable message from recursion, you have a message like:
Type 'UnwrapRef<T>' is not assignable to type 'T'.
  Type 'unknown' is not assignable to type 'T'.
    Type 'UnwrappedObject<Promise<any>>' is not assignable to type 'T'.ts(2322)

Probably in the next few days I will do a bit more testing

@yyx990803 is this useful or just close it?

Can you remove the formatting changes from this PR?

Oops, looks like I hit the button at the wrong time

Sorry for the accidental merge, can you open a follow up PR for the type test fix please?

Sorry about that, should have run the testing before pushing


Look up lowercased URLs in lowercased items dict

Task/Issue URL: https://app.asana.com/0/1201037661562251/1208943052282180/f
Description:
This change fixes looking up bookmarks in the lowercased items dictionary by also lowercasing
the URL in question.
Steps to test this PR:

Verify that UI tests pass.

You can test manually by opening a mixed case URL such as https://pl.wikipedia.org/w/index.php?title=The_Mandalorian_(sezon_1)&oldid=75295490&veaction=edit and trying to bookmark it via context menu -> Bookmark Page. The bookmark icon in the address bar should be filled, indicating that the URL is now bookmarked.

Definition of Done:

[ ] Does this PR satisfy our Definition of Done?

Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@jotaemepereira let me work on unit tests separately and let's have this merged first to unblock UI tests. Thanks for the review!


Remove unused DateValidator

This hasn't been used since the big commit where the bulk of the specialist publisher code was removed.
Note that this was not obvious, because the validation was being triggered by the date option in lines like this:
    validates :tribunal_decision_decision_date, presence: true, date: true

There are no such lines left in the code now.

@chrislo: Thanks for reviewing.
Rebasing against master and force-pushing in preparation for merging.


Mz config

closes #6

I see it got merged already...I was too slow ;(

Hi, sorry for merging too soon. I've got a review internally by someone else. I'll go through your suggestions and merge fixes.

See changes here https://github.com/signageos/vscode-sops/pull/9


feat(batch): add async_batch_processor for concurrent processing

Issue number: #1708
Summary
Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist
If your change doesn't seem to apply, please leave them unchecked.

[ ] Meet tenets criteria
[ ] I have performed a self-review of this change
[ ] Changes have been tested
[ ] Changes are documented
[ ] PR title follows conventional commit semantics

Is this a breaking change?
RFC issue number:
Checklist:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@heitorlessa the code still is untested

Codecov Report
Base: 99.27% // Head: 99.24% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (4d6c0f3) compared to base (f9752df).
Patch coverage: 92.85% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1724      +/-   ##
===========================================
- Coverage    99.27%   99.24%   -0.03%
===========================================
  Files          129      131       +2
  Lines         6059     6091      +32
  Branches       403      405       +2
===========================================
+ Hits          6015     6045      +30
- Misses          20       21       +1
- Partials        24       25       +1

Impacted Files
Coverage Δ

aws_lambda_powertools/utilities/batch/__init__.py
100.00% <ø> (ø)

aws_lambda_powertools/utilities/batch/base.py
96.87% <91.17%> (-0.92%)
:arrow_down:

aws_lambda_powertools/asynchrony/__init__.py
100.00% <100.00%> (ø)

aws_lambda_powertools/asynchrony/base.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Thank you once again for the heavy lifting - I like the overall direction! It even brought up that we should (separate PR) have a way to use a ThreadPoolExecutor as an opt-in feature like concurrent=True for the synchronous processor.
Major comments summarized:
* **Breaking change**. Removing `process()` from `BasePartialProcessor` breaks [custom processors](https://awslabs.github.io/aws-lambda-powertools-python/2.3.1/utilities/batch/#create-your-own-partial-processor). Turns out (TIL) we don't have a test for it hence why it wasn't caught up earlier.

* **Let's keep Lambda handler synchronous**. We can prevent a call stack slowdown, make `async_lambda_handler` redundant, and prevent a class of unforeseen issues for customers stacking decorators of different colours (sync/async) since ordering matters.

* **Single inheritance only**. As I mentioned earlier, we can't use multiple inheritance as that will impact our ability to use Mypyc later.

Hey!

Make the simple inheritance code forces to do things not so beautiful, such as loading the methods _async_process_record and async_process to the class BasePartialProcessor.
So, I changed the asyncio.run() in async_batch_processor, I had BIG problems with that in another project.
About the concurrent=True, following the best practices, it is best to have "atomic responsibilities" for methods/classes. It would be better to get a new class called ThreadBatchProcessor class with its corresponding thread_batch_processor, keeping this explicit, also solve the tend to confuse asynchrony with the concurrence

I'm glad you called it out - thank you for keeping us honest ;)
Answering them

Make the simple inheritance code forces to do things not so beautiful

I couldn't agree more. Because we optimize to run in a constrained environment (almost like embedded), we have to make these decisions which would be sub-optimal in different contexts. We're trading a more beautiful implementation with future speed gains that could save $ for customers.

So, I changed the asyncio.run() in async_batch_processor, I had BIG problems with that in another project.

Mind sharing what the big problems were so we can learn from it? I'm new to asyncio in Python from a library authorship point of view - if there's a balance we can strike to avoid decorator stacking confusion and increased call stack while avoiding these scars you've earned, it'd be lovely!

About the concurrent=True, following the best practices, it is best to have "atomic responsibilities" for methods/classes.

I worded that poorly. What I meant for concurrent=True was an UX thinking, I didn't put any thought on the underlying implementation at the time of writing. You're absolutely right on ThreadBatchProcessor - way to go, as threading can get complex pretty quickly.
Since batch_processor decorator would simply call ThreadBatchProcessor.process() where the threading logic is, and it's also sync, I find thread_batch_processor mostly cognitive load when balancing semantics, intent and non-developers using it -- am I missing something here?

Mind sharing what the big problems were so we can learn from it? I'm new to asyncio in Python from a library authorship point of view - if there's a balance we can strike to avoid decorator stacking confusion and increased call stack while avoiding these scars you've earned, it'd be lovely!

It is something that I still can't explain well, I have worked for a good time with this function in docker environments without memory or disk limitations and always following the documentation: It should be used as a main entry point for asyncio programs, and should ideally only be called once.
However, in the AWS Lambda environment, even with high limits, it simply fails when for some reason an unexpected error occurs(prematurely closing the main loop without allowing the error to spread up).
Imagine an error 423 in an API or an error 400 in the boto3 behind an asynchronous wrapper with a thread underneath. In non-Lambda environments, the error is simply propagated up, and then the loop closes without complaints.
However, python's recommendation is to use asyncio.run instead of deep functions to create the main loop.

Since batch_processor decorator would simply call ThreadBatchProcessor.process() where the threading logic is, and it's also sync, I find thread_batch_processor mostly cognitive load when balancing semantics, intent and non-developers using it -- am I missing something here?

Exactly, it is a matter of being explicit and not giving rise to confusion, it is also due to maintenance of the code, imagine in the future for some reason processing messages using the class ThreadBatchProcessor, it is not simply calling to ThreadBatchProcessor.process().
The batch_processor would have to be modified in consequence to have synchronous logic and a multithread logic, this could be confusing to maintain, especially not intuitive.
I'm sorry for not having a more technical detail about asyncio, I wait for your thoughts :)

Aaah, that's highly likely due to the nature of container/process freezing in Lambda. There are similar side effects in NodeJS too.
Agreed on the unforeseeable nature of thread_batch_processor needing custom logic in the future. Let's go ahead with these.
I'm going to re:Invent today and will be mostly away for a week, feel free to reach out to @rubenfonseca for anything.
We can help write the docs, do a thorough review, and contribute any possible gaps to make this quicker.
Thank you so much again for helping out with this (Gracias!!)

Back from holidays and our team offsite ends this week. I'll resume this PR next week so we can get it merged for our next release ;-)
Hope you had a great end of the year, and look forward to getting this to the finish line!
Thank you for the prolonged patience

Pushed some changes to improve maintenance. Next: I'll create a summary of the changes in the PR before refactoring the doc examples, and create docs for this. If nothing else drags me over meetings and such, this should be in the next release 2.8.0 ;)

Pull request description changed to reflect all changes, and to make it easier for maintainers to reason what, why, and the effect of these changes.
Added two mermaid diagrams to more easily grasp it as a summary

Before
classDiagram
    class BasePartialProcessor {
        <<interface>>
        +success_handler(record, result) SuccessResponse
        +failure_handler(record, exception) FailureResponse
        +process()
        +_prepare()
        +_clean()
        +_process_record_(record)
        +_async_process() List~Tuple~
        +__enter__()
        +__exit__()
        +__call__(records, handler, lambda_context)
    }

    class BatchProcessor {
        +Dict batch_response
        +response() Dict
        +_process_record()
        +_prepare()
        +_clean()
    }

    BasePartialProcessor <|-- BatchProcessor : implement
    note for BatchProcessor "implements entire interface and logic for batch processing"

New
classDiagram
    class BasePartialProcessor {
        <<interface>>
        +success_handler(record, result) SuccessResponse
        +failure_handler(record, exception) FailureResponse
        +process()
        +_prepare()
        +_clean()
        +_process_record_(record)
        +_async_process_record_(record)
        +_async_process() List~Tuple~
        +__enter__()
        +__exit__()
        +__call__(records, handler, lambda_context)
    }

    class BasePartialBatchProcessor {
        +Dict batch_response
        +response() Dict
        +_prepare()
        +_clean()
    }

    class BatchProcessor {
        +_process_record()
        +_async_process_record() NotImplementedError
    }

    class AsyncBatchProcessor {
        +_process_record() NotImplementedError
        +_async_process_record()
    }

    BasePartialProcessor <|-- BasePartialBatchProcessor : implement
    BasePartialBatchProcessor <|-- BatchProcessor : inherit
    BasePartialBatchProcessor <|-- AsyncBatchProcessor : inherit

    note for BasePartialBatchProcessor "implements shared logic for batch processing used for sync and async processing"
    note for BatchProcessor "only implements logic to call customers' record handler synchronously"
    note for AsyncBatchProcessor "only implements logic to call customers' record handler asynchronously"

ALL DONE 🎉 🚀 @BakasuraRCE -- I'll wait until Thursday for any last comments before we merge and push a new release ;)
I wanted to thank you one more time for this big effort. Since you last touched, I've made the following changes:

[x] Documented API changes (new/refactoring) in the PR description
[x] Removed the sync code snippet, and refactored the async code snippet to better show case this change
[x] Created a new section in the docs, along with warnings when used with Tracer, and guidance for those new to AsyncIO
[x] Fixed docstrings in classes (BatchProcessor and AsyncBatchProcessor) to ensure VSCode/PyCharm play nice when auto-completing docs

@BakasuraRCE Hey, I'm looking into writing a load test for this today/tomorrow to check perf :)


Add Forked RadioLib to Submodules

@amirna2 build this new code for the CDP and we found a small compatibility issue with the SX127x Lora Module. Project OWL forked RadioLib and @amirna2 made a small patch to fix the compatibility issues. We will use the forked Library as the new Submodule for the CDP until the patch is fixed in the RadioLib upstream.

This looks good to me. Does OWL RadioLib fork have the patch?

Yes https://github.com/Project-Owl/RadioLib/commit/52abdeb615549afd7127ecd83d1d8c17c749947a


On restart resume mailbox after starting

Currently if an exception is thrown while processing the Started message, other user messages will be delivered before a successful start. This pull request delays resuming the mailbox until after Started is sent to the actor, changing this behaviour. Other user messages are only delivered once the actor has completed processing the Started message.
See issue #31

@james-cobb it looks great, is there a way we avoid the sleep inside the test?
@rogeralsing can you have a look and merge?

Replaced Thread sleeps with countdown latches


Can't edit custom links in OLD ui on 6.7

Describe the bug
If you create a custom link and then go back to edit it, the title and url are reset to their defaults.
To Reproduce
Steps to reproduce the behavior:

Go to Settings / General / Custom links in OLD UI
Add new link
Enter some values for the title and URL and Save
Edit your new link
Values are reset back to blank and "http://"

Confirmed working in 6.7


LENGTH ERROR when creating project on Linux

When using ]Cider.CreateProject
LENGTH ERROR: Boolean singleton value required
CreateProject_[35] :If ¯1=P.ProjectConfig filename
                         ∧

A file cider.config is created and I am able to open the project with ]Cider.OpenProject afterwards.
Cider version
      ]cider.version
0.42.4+671

Linux and RIDE
IDE:
  Version: 4.5.4097
  Electron: 26.6.9
  Chrome: 116.0.5845.228
  Node: 18.16.1
  Platform: Linux x86_64
  Date: 2024-02-23 15:24:25 +0100
  Git commit: 9fb313638328832b51012bd75b2523a8d97f4509
  Preferences:{
    "autoStart":"1",
    "defaultConfig":"v19.0",
    "kbdLocale":"en_GB",
    "keys":"{\"FX\":[\"Ctrl+S\"]}",
    "presetsCreated":"[\"/opt/mdyalog/19.0/64/unicode/mapl\",\"/opt/mdyalog/18.2/64/unicode/mapl\",\"/opt/mdyalog/20.0/64/unicode/mapl\"]",
    "zoom":"1"
  }

Interpreter:
  Version: 19.0.50099
  Platform: Linux-64
  Edition: Unicode/64
  Date: Sep 11 2024 at 00:47:48

Can't reproduce. Please send the project config file cider.config.
I would also appreciate if you could save the workspace with -andse and send it over to me.


#1923 Allow to create images with creation date in past (for testing purposes)

This PR is to address issue reported in #1923.
Reason: In order to test some clean up scripts I need to be able to create in test fixture some AMIs (properly named, tagged, etc.) but with creation date in the past.
The test script checks the datetime of AMI as a criteria what to keep and what to delete.

Coverage remained the same at 92.496% when pulling 6e83590e27a820639d7172c6e304f6bbc6be3f02 on Constantin07:master into 90a62b56400251620684a094d85e458bc3abb17e on spulec:master.

It isn't clear to me what this changes. Won't it still set the current time as the creation date in the AMI instantiation?

the idea was to be able to pass creation_date value in the past instead of using default (current time).

Maybe I'm missing it, but it seems like this change still won't allow you to pass a creation_date. Where would you be passing it?

Some example code of how you are planning on using this would be very helpful.

I don't think this PR is necessary. the Ami class in ect/models.py already sets creation_date to the current time. For testing, you could import freeze_time from freezegun and create images at any point in time. This will only work when not in server_mode.

I tend to agree with @queue-tip . I'm going to close this out, but let me know if I am missing something.


Problem with CORS

All the api GET request stating me and error about Cross orgin resource sharing
Please fix this

Hi,
In order to resolve any possible issues, we need more information

Which URL are you trying to retrieve?
What are you aiming to do (so we may assist you in case there are better endpoints available)

A GET from https://data.irail.be/NMBS/Stations
And thr liveboard

You are not supposed to retrieve information from data.irail.be (it's an old system for one specific partner for legacy reasons).
Please use api.irail.be. Documentation can be found at docs.irail.be. The correct github repository for this is https://github.com/iRail/iRail

https://api.irail.be/stations/ works fine here - please pay attention to the documentation

i just use these code and it gives ma an empty 200 error this is client based i know , my postman does work in angular it won't do you know a solution

As described in the documentation, available at https://docs.irail.be , you can use the format parameter: https://api.irail.be/stations/?format=json


[WIP] fix for issue related to service principal

…hing that caused cluster create api spin for 10-15mins before erroring out. Also adding a --purge-sp-cache which would allow users to force creation of service principal and refresh cache

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[ ] I adhere to the Command Guidelines.

No action for months. Feel free to reopen when this is ready.


Generalize variable domains

Purpose
Allow standalone models to define variables on subdomains (e.g. just on the surface, or throughout the domain).
Required for 2d aux variables of the soil model (for example).
Removes requirement for bucket model to have its own methods for initialize
Simplifies our domains by removing the LSM domains
Down the road will reduce allocations as we can now pre-allocate surface fields for e.g. the soil model for storing the boundary fluxes
To-do
Review
Propagate to docs and experiments once approach is settled.
Content

Remove LSM domains (LSMSingleColumnDomain, LSMMultiColumnDomain, LSMSphericalShellDomain)
Changes the space stored in the domains to have the spaces of the surface (for 0D-2D domains) or of the subsurface+surface(for 1D/3D domains). This is more general in case we ever need to store additional spaces (e.g. the face space, which we do use in some places). They are stored as a NamedTuple.
Calling coordinates(domain) now also returns a NamedTuple with the coordinates for each space associated with that domain.
add prognostic_domain_names and auxiliary_domain_names which now must be defined for all variables of all models (e.g. :surface, :subsurface)
updates methods appropriately for initialize to include the domain types. When initializing a variable, we use the coordinates of the domain, along with the "state" =  getproperty(coords, var_domain_name).
Removes unnecessary Bucket initialize methods and updates LSM methods for the new functionality.
removes domain_name(model) function as this is superceded by variable domain names.

Review checklist
I have:

followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/
followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/
followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy
checked that this PR does not duplicate an open PR.

In the Content, I have included

relevant unit tests, and integration tests,
appropriate docstrings on all functions, structs, and modules, and included relevant documentation.

[ ] I have read and checked the items on the review checklist.

bors r+


Set highlight's parent before setting transf

I don't know if there was a specific reason it was being done in the other order, but I just ran into this one - it loses the local scale of the model because Unity will re-calculate scales when you set the parent. So you need to set the parent first.
Case where it was uses: Gameobject with scale of 0.015 holding mesh of scale 1 which was the interactable. When touching it, spawned highlighted mesh was at scale 66x because it would recalculate its scale to match the previous scale of 1x the root, rather than 1x the new mesh.

There were the following issues with your Pull Request

Commit: 253976b55a2853cc389a0dba851215f60f1f08a3
Your commit message body contains a line that is longer than 72 characters
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/thestonefox/SteamVR_Unity_Toolkit

This message was auto-generated by https://gitcop.com

SourceTree managed to foobar my last attempt to amend the commit, so going to try again.
That'll teach me not go use the command line.