"undefined session received in acceptDebugSessionStarted" introduced in VS Code 1.32

When starting a Dart debugging session in Insiders, I see this error in the console. I'm not sure what's causing it, though I'm seeing another issue (some commands not working) and unsure if it's related.

@weinand this issue has made it to stable and appears to have stopped acceptDebugSessionStarted from firing (which has broken many features in the Dart plugin). Do you know whether it's likely something wrong in what I'm doing, or a bug here? (it definitely all worked fine before yesterdays update, I've had a lot of comments at https://github.com/Dart-Code/Dart-Code/issues/1518 since).

Here's what I'm returning from my resolveDebugConfiguration method:
{
        "name": "Flutter",
        "request": "launch",
        "type": "dart",
        "program": "/Users/dantup/Dev/Google/flutter/examples/flutter_gallery/lib/main.dart",
        "cwd": "/Users/dantup/Dev/Google/flutter/examples/flutter_gallery",
        "args": [],
        "vmAdditionalArgs": [],
        "dartPath": "/Users/dantup/Dev/Google/flutter/bin/cache/dart-sdk/bin/dart",
        "observatoryLogFile": "/Users/dantup/Dev/Dart-Code-Logs/observatory.txt",
        "maxLogLineLength": 99999999,
        "pubPath": "/Users/dantup/Dev/Google/flutter/bin/cache/dart-sdk/bin/pub",
        "pubSnapshotPath": "/Users/dantup/Dev/Google/flutter/bin/cache/dart-sdk/bin/snapshots/pub.dart.snapshot",
        "pubTestLogFile": "/Users/dantup/Dev/Dart-Code-Logs/pub_test.txt",
        "debugSdkLibraries": false,
        "debugExternalLibraries": true,
        "flutterDebuggerRestartBehaviour": "hotRestart",
        "evaluateGettersInDebugViews": true,
        "forceFlutterVerboseMode": false,
        "flutterTrackWidgetCreation": true,
        "flutterMode": "debug",
        "flutterPath": "/Users/dantup/Dev/Google/flutter/bin/flutter",
        "flutterRunLogFile": "/Users/dantup/Dev/Dart-Code-Logs/flutter_run.txt",
        "flutterTestLogFile": "/Users/dantup/Dev/Dart-Code-Logs/flutter_test.txt",
        "deviceId": "1DD6786B-37D4-4355-AA15-B818A87A18B4",
        "deviceName": "iPhone XS Max (ios)",
        "showMemoryUsage": false,
        "debugServer": 51218
    }

And I've started a server on that port. It all works fine in my tests, though they use the DebugClient class and don't rely on onDidStartDebugSession firing.

@DanTup the error message on the console just says that a null DebugSession would be passed to "vscode.debug.onDidStartDebugSession" (which is against the spec). Previously we were just passing the null and fire "onDidStartDebugSession" anyway.
@isidorn Since I was sporadicly seeing "null" session objects passed to the debug extension API "vscode.debug.onDidStartDebugSession" I've added a safe guard and console message in https://github.com/Microsoft/vscode/blob/fa93b07de3fc7b670211ef521a1fab500f59f85f/src/vs/workbench/api/electron-browser/mainThreadDebugService.ts#L39.
Could you please investigate why an undefined session is passed to "debugService.onDidNewSession".

The strange thing is, in VS Code 1.31 the Dart debugger works fine, yet it's code is reading properties of the session so I don't believe they could be null:
https://github.com/Dart-Code/Dart-Code/blob/e3ab4bf00f07a7b2df8e26da9d85be478685be17/src/commands/debug.ts#L123
But in 1.32 we see this error, and the event doesn't fire. Is there anything else that changed in this area that might have affected this?

@weinand looking at the code I can not figure out how could you possible get null.
Though I rembember I was seeing this error as well, however I can no longer reproduce. Are there some easy repro steps?
Do you get null or undefined?

I just loaded my extension in 1.31 and added this logging:

The output looks like this:

Yet in 1.32 the event never fires and I see the error above. The session is definitely not null in 1.31, so I'm not sure why this is triggering :-(

FWIW, the error I'm seeing doesn't isn't the same as the one in the code that @weinand linked to:
console.error('undefined session received in onDidNewSession');
vs
undefined session received in acceptDebugSessionStarted
It's the bottom one I'm seeing, not the top.

Note: this has broken significant debugging functionality for Dart/Flutter and I'm having to tell people downgrade to v1.31. If it turns out to be something in VS Code, it would be great if this could be considered for a recovery release.

If you don't have a good repro for this and want to repro with Dart, you can do this:

Grab a Dart SDK ZIP from https://www.dartlang.org/tools/sdk/archive
Extract the zip (can be anywhere)
Install the Dart extension
Create a folder and add a file to bin/main.dart with the contents main() {}
Open the folder (parent of bin) and when the extension says it can't find a Dart SDK, click Locate and navigate to the SDK folder you extracted
Press F5 to run

If you check in the dev tools, you'll see that warning. If you repeat the same thing in 1.31 you won't see a warning (and the session that was received in onDidStartDebugSession is not null).
If you want to run the extension from source, you can just clone https://github.com/Dart-Code/Dart-Code and it works with just F5 as you'd expect.
As a slight aside, it'd be really nice if we could write debugger tests that went through VS Code's launch process. I have good test coverage here, but because using DebugClient doesn't go through this code, it was not detected. I know how to spawn a debug session using the VS Code command, but then I'm not able to interact with it like I can with DebugClient to set breakpoints etc..

I can repro the issue.

I can repro this too :(

@weinand are you reproing using Dan's steps or are you reproing using node? If using node can you please provide steps?

I mean: I can repro this in the debugger and found out what the problem is.
Some API to find the WorkspaceFolder for a URI (workspaceService.resolveWorkspaceFolder()) has become asynchronous and that has changed the timing behavior. As a consequence the debug session has not yet arrived in the EH host but we are already trying to look it up by UUID. This fails which results in the console error message.

@weinand I'm reproing this with a simple hello world program. Debugging works fine. It is just that "vscode.debug.onDidStartDebugSession" is not called...

BTW, #69128 was the issue that made me add the code to protect calls to "vscode.debug.onDidStartDebugSession" with an undefined session...

Ok thanks for the details. I will first convert all debug to null checks. This will be a good test if the null checks catch this.

And here is the PR that probably introduced the issue: https://github.com/Microsoft/vscode/pull/67216

@weinand Thanks for tracking this down! For some reason I can't get VS Code to build on my PC anymore (gives a weird error about being out of disk space of failing to seek to a position on a file..) but I'll can test it with Dart & Flutter once it's in an insiders build.

I've released a fix for Insiders and create a PR as a candidate for the February recovery release.

@DanTup yes, it would be great if you could verify the fix in the next Insiders. Thanks a lot.
(BTW, make sure to use node.js 10.15.x when building VS Code. Earlier versions of node.js had the issue to ignore some "heap_size" command line argument.)

Will do - I'm not sure if the timing of insiders - is there another build before Monday?
And thanks for the tip - I'll check my node version later. I had built it previously, but it was a while ago, so who knows what's changed.

make sure to use node.js 10.15.x

I was on an older version, but I upgraded to v10.15.3 and still see the error below when running yarn. Let me know if I should open an issue here about it (it's not clear if it's Code-specific). I'm certainly not short on disk space, and re-cloning and clearing noed_modules doesn't seem to make any difference.
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
  is-elevated.cc
  win_delay_load_hook.cc
C:\Users\danny\.node-gyp\iojs-3.1.3\x64\iojs.lib : fatal error LNK1106: invalid file or disk full: cannot seek to 0x2B4286 [M:\Coding\Applications\vscode\node_modules\native-is-elevated\build\is-elevated.vcxproj]
gyp ERR! build error
gyp ERR! stack Error: `C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin\MSBuild.exe` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:189:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:248:12)
gyp ERR! System Windows_NT 10.0.17134
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
gyp ERR! cwd M:\Coding\Applications\vscode\node_modules\native-is-elevated

Checkdisk reported nothing, so I cleaned all my temp folders (they were getting big) and uninstalled a bunch of stuff, then reboot. Now strangely the error has gone away. Makes no sense - unless it was disk space - but I had about 30GB free! Now I have 45GB free!
Anyway, I will do some testing and see if I can verify the fix on master...

Ok, running from source I can repro the issue without ac46ca2 and cannot repro with it. As far as I can see, the fix is good! 👍
Thanks again for the speedy fix! I'm happy to re-verify in insiders and/or a stable release if you ping me when they're available.

Downgrading to 1.31 is a temporary fix until this https://github.com/Microsoft/vscode/commit/ac46ca2a5e5aaab3f01cffec46d3e2ac96519f1f patch released with insiders or stable

Tested on the Insiders build that just went out, and it's also working as expected there 👍

@DanTup thanks a lot! Can you also check out the other Dart hot reload issues. They should be fixed with latest insiders, right?
https://github.com/Microsoft/vscode/issues/70057
https://github.com/Microsoft/vscode/issues/70105

@isidorn Yep, those issues both appear to be the same as this. We use the session start event to track all sessions so that we can send editor-side events (like hot reload) to them all.

Given this is a regression, will the fix for this land in a 1.32.2?

@tdyas-stripe this issue is in the recovery build 2 milestone, so I think that's the plan (though I'm not on the Code team!).

@tdyas-stripe yes, the fix will appear in the recovery release (as already announced 4 days ago: https://github.com/Microsoft/vscode/issues/69534#issuecomment-470982409)

Verifiers:
You can verify this by running the cluster sample:
const cluster = require('cluster');
const http = require('http');
const numCPUs = require('os').cpus().length / 2;
const Net = require('net');

if (cluster.isMaster) {
	console.log(`Master ${process.pid} is running`);

	console.log(`Forking ${numCPUs} workers.`);
	// Fork workers.
	for (let i = 0; i < numCPUs; i++) {
		cluster.fork();
	}

	cluster.on('exit', (worker, code, signal) => {
		console.log(`worker ${worker.process.pid} died`);
	});

	// start listening on a random port
	//const server = Net.createServer(socket => {
	//}).listen(0);

	//console.log("listening on port: " + server.address().port);

} else {
	// Workers can share any TCP connection
	// In this case it is an HTTP server
	http.createServer((req, res) => {
		res.writeHead(200);
		res.end('hello world\n');
	}).listen(8000);

	console.log(`Worker ${process.pid} started`);
}

with this launch config:
{
			"type": "node",
			"request": "launch",
			"name": "Cluster",
			"program": "${workspaceFolder}/test.js",
			"autoAttachChildProcesses": true
},

Works great. Both regular node debugging and cluster debugging.
No undefined session error in debug console.
Adding verified label

@isidorn thanks!

@weinand thanks!


ERROR - Failed to Query Poloniex for Balance Data, Restarting Loop

may i know what the problem?

Sorry for not getting back earlier,
Did you enter your api keys&secret into the arbbot.conf file before running? Because if you didn't, you will get this message. Also you may want to recreate your api key, as with poloniex there are occasionally problems with api keys that have been created a while back.


Stronghold backup date is not recognized correctly

Issue description
Today is March 24th and this will appear on my wallet. The last backup was yesterday.
Perhaps the calculation is not based on the date, but on the basis of 24 hours. However, this would then have to be represented differently.
Wallet version
0.3.1
-- MacOS 11.2.3

The calculation is actually checked to see if your backup is older than one month. And from what I can see and test the calculations are correct. So you should not actually get that window until a month has passed from the original backup. Something must have gone wrong somewhere else.

Now the display is correct again. So it's up to the 24 hours.

This should be fixed in the next release, please re-open if it persists.


Add Parser Stats

Parsers should log their stats, such as logs read per sec, etc, on a regular basis.
That 'regular basis' should be settable via cfg file.

The plan is to add stats with sleep output.
Current code - Anatomize.py::Anatomize::startAnatomizer() - line 186:
self.lgr.debug('sleeping for [ ' + self.cfg['parsing']['sleepTime'] + ' ] seconds...')
sleep(int(self.cfg['parsing']['sleepTime']))

Change to:
self.lgr.debug('sleeping for [ ' + self.cfg['parsing']['sleepTime'] + ' ] seconds :: ' + self.parserStore[parserId].generateStats())
sleep(int(self.cfg['parsing']['sleepTime']))

    def printStats(self, raw=False):
        """
        Generate stats in string or raw form

        :return: str or dict
        """

        # check if raw data should be returned
        if raw:
            return self.stats

        # return stats as string
        return '[ |-- STATS --| :: TOTAL LOGS READ: { } :: (( AVG LOGS READ / SEC: { } :: AVG LOG LENGTH: { } :: AVG LOG SIZE: { } ))]'

Completed w/ commit
https://github.com/magneticstain/Inquisition/commit/53db6afa912823456a0f5221b16b14012784ad28


Integration

Great effort,
Ping me when it's ready. I'll make an adapter for it.
Feel free to make breaking changes on the API. It doesn't have to be just a port. If you see opportunities for improvements.
There is also a lot of things we do not use, you don't have to re implement the whole feature set.
Best

This is the interface that your implementation's feature set should enable me to implement.
For reference, this is the implementation for the Java API
Good luck!


Upgrade to Microsoft Graph PowerShell v2

Microsoft now has different commands for beta and
1.0 rather than using Select-MgProfile

Thanks for pushing the initial support for Graph PowerShell.  Very helpful for my Azure Function.

https://github.com/AusXTech/IntuneBackupAndRestore-MGGraph and https://github.com/cloudwise-wesley/IntuneBackupAndRestore are more complete than my changes.


Make extensible enums actually extensible

Right now, using x-extensible-enum to declare an enum instead of the enum keyword does not actually generate "extensible enums", as the name suggests. Instead, it's just an alias for "enum". For example, this enum model here:
enum class ExtensibleEnumObject(
    @JsonValue
    val value: String
) {
    ACTIVE("active"),

    INACTIVE("inactive");

    companion object {
        private val mapping: Map<String, ExtensibleEnumObject> =
            values().associateBy(ExtensibleEnumObject::value)

        fun fromValue(value: String): ExtensibleEnumObject? = mapping[value]
    }
}

should actually look more like this when marked as "extensible": (untested code)
enum class ExtensibleEnumObject(
    @JsonValue
    val value: String
) {
    ACTIVE("active"),

    INACTIVE("inactive"),

    UNKNOWN("");

    companion object {
        private val mapping: Map<String, ExtensibleEnumObject> =
            values().filter { it != UNKNOWN }.associateBy(ExtensibleEnumObject::value)

        @JsonCreator
        fun fromValue(value: String): ExtensibleEnumObject = mapping[value] ?: UNKNOWN
    }
}

Interesting idea. The way we use this feature is we opt-in to the alias when generating the server-side but leave it disabled for client side. That way we get the strict typing server side, and our clients don't break when we extend with new values.
Your proposal might be a nice improvement though.
Side note, I've a relatively clear calendar tomorrow and will try and catch up fabrik issues and PRs

Interesting idea. The way we use this feature is we opt-in to the alias when generating the server-side but leave it disabled for client side. That way we get the strict typing server side, and our clients don't break when we extend with new values.

So you're mainly using it for extensibility in responses (i.e. the client might have to deal with unknown values) and my proposed change would offer extensibility in requests (i.e. the server might have to deal with unknown values). Correct?

Side note, I've a relatively clear calendar tomorrow and will try and catch up fabrikt issues and PRs

Nice, thank you :)

Yes, at Zalando x-extensible-enum is used to communicate to clients that: these are the current options, but new options may be added in the future
To my knowledge, it is never used to allow clients to make requests using undefined enum values, only to prepare clients to gracefully handle responses with unexpected new enum values as the API evolves over time.


Tests are failing on Windows

Is your enhancement related to a problem? Please describe
When running test:backend tests seems ok but vitest report a timeout error
Describe the solution you'd like
Check the timeout
Describe alternatives you've considered
No response
Additional context
No response

Closing as it maybe related to my settings


Add note that ALP currently works with k8s <= 1.15

Description

Related issues/PRs

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

None required

Deploy preview for calico ready!
Built with commit 99609f5057d2eab1e316aadbdeb7f4b2cfc6634f
https://deploy-preview-2942--calico.netlify.com


Show deprecation text in the error message

When we deprecate a function or method, we also document the replacement to use. For example,
/**
 * @deprecated Use bar instead
 */
function foo() {}

Currently when foo is used in the code, this rule only says foo is deprecated.
Call to deprecated function foo()

It would be very useful if it shows the deprecation text Use bar instead in the message as well.
Call to deprecated function foo(). Use bar instead.

I took a look at the code. It seems we need to change PHPStan\PhpDoc\PhpDocNodeResolver to let it store the deprecation text.

Hi, this isn’t part of any standard, I don’t think the text has to be
included in the error message.
On Thu, 15 Nov 2018 at 05:49, Wenzheng Jiang<EMAIL_ADDRESS>wrote:

I took a look at the code. It seems we need to change
PHPStan\PhpDoc\PhpDocNodeResolver
https://github.com/phpstan/phpstan/blob/master/src/PhpDoc/ResolvedPhpDocBlock.php
to let it store the deprecation text.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/phpstan/phpstan-deprecation-rules/issues/2#issuecomment-438916596,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGZuN5voZ2bUMg2nty2r2trKyeDXV4_ks5uvPJwgaJpZM4YfE-F
.

--
Ondřej Mirtes

+1, this would be very useful. It is documented as part of the FIG standards (https://github.com/php-fig/fig-standards/blob/master/proposed/phpdoc-tags.md#55-deprecated)

+1 for display deprecation info.
It's a widly used practise to also write some notes about the deprecation itself.
Thanks @joshuaspence for pointing to PHPFIG.
According to them it's recommended to use @see in combination with @deprecated.
At least this should be added to the error message.

We're using this for the Drupal 9 clean up of deprecated code. Having the deprecation message available would be great. Often times the message says when a method will be removed. So you could ignore certain deprecations (ie not Symfony 4.4 but anything else)

The error message says what’s deprecated so you can put it to ignoreErrors,
right?
On Thu, 7 Mar 2019 at 02:22, Matt Glaman<EMAIL_ADDRESS>wrote:

We're using this for the Drupal 9 clean up of deprecated code. Having the
deprecation message available would be great. Often times the message says
when a method will be removed. So you could ignore certain deprecations (ie
not Symfony 4.4 but anything else)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/phpstan/phpstan-deprecation-rules/issues/2#issuecomment-470344468,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGZuNY_Zq7maOCFLLnGDHMjnz7_JFXeks5vUGnHgaJpZM4YfE-F
.

--
Ondřej Mirtes

Filtering out Drupal 10 versus a bunch of specific error messages would be much easier. It'd also be better DX to explain why it is deprecated and how to fix it. It also makes reporting easier.
Here's what I have setup to help triage deprecations for Drupal core using my phpstan-junit formatter.
Example report: https://deprecationbot.glamanate.com/job/core_aggregator/lastBuild/testReport/
It would be nice to include the deprecation message which includes how to fix the problem. This is really helpful at a code sprint.
PHPStan error:

Call to deprecated method url() of class Drupal. on line 36
--

Message:
   * @deprecated as of Drupal 8.0.x, will be removed before Drupal 9.0.0.
   *   Instead create a \Drupal\Core\Url object directly, for example using
   *   Url::fromRoute().

@ondrejmirtes for what it is worth, I am totally willing to own and contribute this. I just want to have your 👍 before venturing down the road.

@mglaman Of course :) I need to give you a little bit of guidance on how to do it.
Check out PhpDocNodeResolver:.resolveIsDeprecated in phpstan/phpstan. It currently returns only boolean for whether the tag exists, but you should be able to inspect what $deprecatedTags actually contains. If it has description, you just need to rewrite the method similarly to resolveReturnTag or resolveThrowsTags. It it doesn't have description, we will have to modify phpstan/phpdoc-parser (but I won't go into that now).
You have to create DeprecatedTag class similar to ReturnTag or ThrowsTag.
ResolvedPhpDocBlock needs to be updated to contain not just boolean for isDeprecated, but the DeprecatedTag with the description. (isDeprecated needs to stay for backwards compatibility but you can add getDeprecatedTag).
DeprecatableReflection interface needs to have getDescription(): ?string added. Once you add it, you have to implement the method in all the interface implementations - usually by adding ?string $deprecatedDescription to the constructor.
Send a PR with this change to phpstan/phpstan. Once accepted, you can modify all the rules here in phpstan-deprecation-rules to output the description where available.
Let me know if you have any questions.

@ondrejmirtes thank you for the instructions! I will give this some time over the next week.

This is now getting closer to being ready :)

The parent PR has merged :) Now this can be worked

Already doing that :)

😮 beating me to the punch 😄

Implemented in https://github.com/phpstan/phpstan-deprecation-rules/commit/5685fe48873efc5af1f2cc95d9c1b8ae82c728fe, release as 0.11.2.


Feature/tracking

Documentation: http://vortex.a2hosted.com/index.php/CV_target_tracking

Looking very nice 😄 Quick Q: what's the buoy-detection code doing here?
Also: We finally have the repository vortex-sensor-fusion, and this is perfect to start the tracking/ folder there.................... I know theres a lot of moving code around so maybe leave that to whenever the great cv-repo cleanup comes?


.Dharvey ignite 2.5

I pushed some MBeans extensions earlier, but this is a material change to normal code paths, so deserves a real review.

Go ahead


[Feature request] Supporting substitutions in string parameters

Hi @rocher,
Very interesting project.
After a quick look, I think the library doesn't support substituting inside a passed string. I have a project idea in which the program will programmatically determine the values to make the substitution in a template. The template could be passed to the program by the user, but I'd like also to have a default template valid for most use cases. If the default template could be stored in memory as a string, there wouldn't be any need to add it to the program as a resource (either external or embedded with some library). The program determines the values, it calls mold_lib to do the substitutions passing the default in memory template, and the resulting string is dumped to the final file by the program.

Hi @mgrojo,
Thanks for the suggestion!!  As you can see, mold_lib has only one single call that operates on external files (input template, input variables -toml file- and output directory). This is, in my opinion, the most common use case for these kind of tools. Right now the input template can be a single file or a directory, and of course there is no problem having it in memory.
The use use case you propose is easy to implement, even with some variants. For example, instead of an external file of variable definitions, you could directly provide a map from unbounded string to unbounded string to provide the required variable -->  value mapping. If you want to work only in memory, wouldn't that be more appropriate? Also, what about using environment variables?
The same with the output: the function could return an unbounded_string or dump the result to a file. And regarding the output file, it could be possible to provide just a string filename or, if an already opened text stream is passed, append the result string in that text stream.
Let me think how can I slightly refactor the implementation to support these uses cases ... no much effort is required, so stay tuned!

I'm realizing that I could in fact use your library without any change, because I could always print the default template and request the library to do the substitutions

If the final result must be a file, then this is the best way: just print your template to your-file.txt.mold and apply the variable substitution with mold. Adjust the settings to remove the source file and the result will be in your-file.txt.

the proposal still makes sense for having a more generalized API

Yes, and I realized that is quite immediate to implement it reusing the current design. There will be some missing features when working in memory:

variable substitution won't be applied to variable values (e.g. A="Hello", B="World" and C="{{A}}, {{B}}!", therefore C="Hello, World!"), to avoid modifying the variables mapping parameter.
template inclusion will be ignored: that would require reading a file in memory, appended to the original template string, and this is a mixed used case not considered for now (see below).

This is the function signature I have in mind:
   function Apply (
      Template  : String;
      Variables : not null Variables_Access;  --  Access to a Variables_Map object (hashed map)
      Settings  : Settings_Access := null;
      Filters   : Filters_Access  := null;
      Results   : Results_Access  := null;
      Log_Level : Log.Levels      := Log.Info
   ) return String;

I'm not considering mixed used cases in which, for example, you provide a template file and a hashed map with variables definitions; or vice-versa, you provide a template String and a toml file with variables definitions. For now, either you provide files or objects in memory.
BTW, do you have a link to your project?  With more context, I might help you more or provide additional insights.

Your proposal makes sense to me, and seems to fit my need perfectly.

BTW, do you have a link to your project? With more context, I might help you more or provide additional insights.

For the moment, it's only an idea. You can understand it with this issue I opened in Alire and some internal notes I have (below). So basically I want to generate a crate.desktop taking information from an alire.toml and some predefined data. I'd also like to let the user provide their own template for the desktop file, by modifying the default template (meaning that I should print it and keep it, after all...).
It's probably going to take a long time, because I have some obligations filling my free time, but from time to time, I cannot resist procrastinating the obligations and thinking on the design of the idea.
alr-appimage
alr-appimage is a tool to automatically create an AppImage executable from an Alire crate.
How to use the tool
There are two prerequisites for your project to work with this tool:

It has to be an Alire crate.
It must be installable using gprinstall.

alr-appimage will use the following command for installing it:
alr exec -P -- gprinstall --prefix=$(DESTDIR) --create-missing-dirs --mode=usage -f
Note: no longer needed if using Alire 2.0: alr install
If you simply run the tool inside an Alire crate, it will read the
metadata from your alire.toml file and create a default AppImage
from it.
The following metadata will be read from your alire.toml for the generation, and will be matched to the equivalent field of the your_crate.desktop file needed by the AppImage:

Alire
Desktop
Comment

name
Name

description
Comment

tags
Keywords
Additionally, any of the tags matching (case-insensitively) one of the main categories in the freedesktop.org menu specification will be used as Categories.

executables
Exec

Terminal
This field of the desktop entry will be set to true

Type
This field of the desktop entry will be set to Application

If these defaults are not good for your project, you can also define a template for your desktop file, and only the fields that you want will be included from the alire.toml or initialized by this utility.

seems to fit my need perfectly

Yes, in this case working with files is the best alternative, I think.
alr-appimage is great idea, very interesting project!!
BTW, could alire itself be packaged as an AppImage with predefined toolchains (Linux, Windows, Apple)?  Makes sense?
Best regards,
-- Francesc


30s down-moratorium before allowing suspension

If all services of a node are down, we used allow suspension.  If those services are monitored with /state/v1/health, we have the timestamp the service became unhealthy - the "since" timestamp.  Now we will require the services to have been down for at least 30s before allowing suspension based on unhealthiness.
Also, for config servers only, we will log all healthiness transitions to track down some orchestrator issues.

I'm unable to reproduce the Travis failure (ControllerTest, testDevDeployment), and I no longer have the ability to trigger another run on Travis.  I'll merge and make a revert just in case.


Migrate actors to use grpc

Signed-off-by: addjuarez<EMAIL_ADDRESS>Description
Migrate .net actor implementation to use grpc by default.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #486
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

How hard would it be to replicate any tests that the DaprHttpInteractor has for the DaprGrpcInteractor? It would also be good to make a base e2e test for the actors to ensure this works correctly.

I can make e2e tests for the grpcInteractor but the unit tests for grpc are a bit more complex.


Api

Our checklist before requesting a review
Added a new folder for the api controllers.
Added methods to show, create and the index.
Added routes to all the new URLs.
http://<IP_ADDRESS>:3000/api/v1/users/

http://<IP_ADDRESS>:3000/api/v1/users/7/posts/

http://<IP_ADDRESS>:3000/api/v1/users/7/posts/33/

http://<IP_ADDRESS>:3000/api/v1/users/2/posts/27/comments

@Felix45 Thank you for review

Hi @Haywayaheadshot that's great, please fix the linter error and send it for another review, I wish you all the best :pray:

Hi @Haywayaheadshot please check your slack


Resubmitting a form after it came back w/ submitErrors

I have a redux-form that I submit through redux-saga. If the request to the backend returns an error, I populate submitErrors by calling stopSubmit('loginForm', errors) from within the worker saga.
The form piece of application state then looks like so:

I consume the submitErrors by connecting my  component to the redux store using connect and the getFormSubmitErrors redux-form selector. (so far so good)

Next, I want to fix the issues and allow the user to re-submit the form. I understand that these are errors to be handled by client-side validation. Just assume that we are dealing w/ meaningful server side validation errors. I return from the server two type of errors:

errors that pertain directly to individual fields
errors that pertain to the form as a whole.

Example:
submitErrors: {
    email: "Email is already in use",
    username: "Username is taken"
}

submitErrors: {
    form: "Email and password are required"
}

PROBLEM:
I wonder how I can re-submit the form when the submitErrors object is populated. First I realized that it is impossible to re-submit the form as long as submitErrors exist. The only way I found to clear submitErrors is to call stopSubmit('loginForm') w/o a second parameter. I would then be able to re-submit the form.
However, when is the best time to clear existing submitErrors using the stopSubmit action creator? From where shall I call the action creator? onChange, onBlur?
Also, is there a better way to achieve what I am trying to do?

Excellent reporting!
But I'm not really understanding the problem. In the Submit Validation Example, you can click submit even if there are already submit errors, and it is clearly calling the submit function because the submit button is disabled for a second. Also, the field-specific submit errors are already removed by default (there's a config parameter to change this behavior) on CHANGE.

Because this issue saw almost no activity for almost a year, I'm closing it.


Add Italian translation to SaintHelenaCountryTranslation

Which translation is affected?
SaintHelenaCountryTranslation.
Description
Add IT translation for this Country. It is missing in file SaintHelenaCountryTranslation.cs
File: https://github.com/nager/Nager.Country/blob/master/src/Nager.Country.Translation/CountryTranslations/SaintHelenaCountryTranslation.cs

And what is the correct translation?


After reading "readme.md for qwen2"

Hello guys.
First of all, I want to thank you guys for great works on TinyLLaVA Factory.
As you guys mentioned in "readme.md for qwen2"
I'm trying to make model with Qwen2-7B-Instruct and it seems there are error
such as below when running the training script
Caught signal 11 (Segmentation fault: address not mapped to object at address (nil))
==== backtrace (tid: 8601) ====
0 0x0000000000042520 __sigaction() ???:0
======================

It would be greatful if you guys share the knowledge how to train other qwen2 model

Never mind. It turns out that the problem was the GPU server's low linux kernel version.
After I upgrade the GPU server, it works fine.

This issue seems not specific to the Qwen2 model. But if you want to train Qwen2 -7B by TinyLLaVA factory please feel to contact us.


Missing error code AADSTS500208:

I was trying to look up information on the following error "AADSTS500208: The domain is not a valid login domain for the account type" but this code is not in this list. Not sure whether I am looking at the wrong list or whether the list needs updating.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a826ee6f-f457-7109-9f77-67c57977d4e7
Version Independent ID: 11766f27-492e-a579-dced-8a42528cbb47
Content: Azure AD authentication & authorization error codes - Microsoft Entra
Content Source: articles/active-directory/develop/reference-error-codes.md
Service: active-directory
Sub-service: develop
GitHub Login: @rwike77
Microsoft Alias: ryanwi

@wpo365
Thanks for your feedback! We will investigate and update as appropriate.

@wpo365
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


SPAdes_Failure that points to empty single reads file in v2.0.2

PHoeNIx version: v2.0.2
Nextflow: 23.04.4
HPC: HiPerGator
PHoeNIx failed 4 isolates due to Auto_QC_Failure_Reason: SPAdes_Failure from each *_summaryline_failure.tsv. Impact of this SPAdes Failure is that most results in the summary files are "Unknown". SPAdes failed due to an empty single reads file "{sample}.singles.fastq.gz" which was supposed to be produced by FastP trimming.
From the nextflow log there is a line for each sample:
"error [nextflow.exception.ProcessFailedException]: Process PHOENIX:PHOENIX_EXTERNAL:SPADES_WF:SPADES ({sample}) terminated with an error exit status (255)"
From the spades_wf work directory, each {sample}.synopsis file shows: "ASSEMBLY: FAILED: {sample}.scaffolds.fa.gz not found"
The .command.log files show: "== Error ==  file is empty: path/{sample}.singles.fastq.gz (single reads, library number: 1, library type: paired-end)"
From the documentation, ".singles.fastq.gz" files are output from fastp_trimd, so I checked that step next in the .nextflow.log (attached below). The TaskProcessor from DEBUG lines all show "Skipping output binding because one or more optional files are missing: fileoutparam<6:1>"
I am trying to find out what went wrong in the FASTP_TRIMD step. From that step, the .command.out is empty and .command.err doesn't say much, so  attached is the .command.sh from one isolate out of four.
Attached logs:
nextflow.log
fastp_trimd-command.sh.txt

Hi @TK-DPH can you check that this is still an issue with the newest v2.1.0 version? If so we will continue with troubleshooting.

What is the sample name and the full file name? I think this is related to #142 we are working on a patch

File names look like "2021LY00045_1.fastq.gz" and "2021LY00045_2.fastq.gz" for example, and sample name "2021LY00045" . If I go into the phx_output directory for that one in "phx_output/2021LY00045/file_integrity/2021LY00045_summary.txt" it only states the following: PASSED: File 2021LY00045_ is not corrupt.
PASSED: File 2021LY00045_ is not corrupt.

@TK-DPH, I also see there is a comment "None of paired reads aligned properly" in the spades.log, which is probably why its not making scaffolds. Again it would be good to confirm that your local copy isn't different from NCBI.  Let me know so we can move forward with a patch release and close this issue.


Coinbase

Started adding some Coinbase API support using the https://github.com/coinbase/coinbase-exchange-node library

Seems there was an issue with an npm dependancy which was causing travis build to fail.
Just squashed the commits to get travis to run again.
All checks are passing now.

Great, thanks


Not all IP blocks are listed in the documentation

The IP listed in the documentation is missing blocks (like the power management). Can all of the HW blocks be added to the documentation?

yep, working on it, thanks @alistair23

all the IPs should be there now.
Yes sorry I'm closing this more than 2 years later.


[Windows] Removing WS_CAPTION (titleBarStyle = 'hidden') Disables Animation

No animation during maximize, minimize, close, etc.
Need to find a workaround or another method to remove title bar while still enabling border and resize and retaining animation (like chromium, electron, etc)

Any clues? I haven't been able to find another way.

Finally found this a few minutes ago.
I've confirmed that it works on my machine (windows 10 using vs 2022). I don't know how to implement it here though.
Hope this helps a little.

I know this too, I tried to integrate it, but it didn't work.

I've succeeded enabling animation in titleBarStyle 'hidden'.
The code needs some tweaking so that isMinimizable and isClosable would work probably.
I'll share the code tomorrow since I'm tired right now and need to go to sleep.

Oh yea I didn't mention that the top resize border won't work anymore.

There's also this
https://github.com/rossy/borderless-window

Fixed, will be released in next version


[graphiql] Auto Build Query from Selecting Schema Item

I've just recently started delving into graphiql, and while the auto text completion when writing the query is great, it would also be nice to have a way to click on a schema item and have it auto fill into the query pane. This would also allow newer users to be able to "build" the query easier, while gaining familiarity with the schema.

I will be introducing some hooks that allow you to intercept this event and add custom logic for this via plugins!

@famous1337 use following plugin https://github.com/graphql/graphiql/tree/main/packages/graphiql-plugin-explorer


Run only one alertmanager pod

Upto now we were using 3 replicas for alertmanager
Due to wrong usage of labels all of these replicas are ending up on only single node and it doesn't serve redundancy, moreover eating away extra resources
There'll not be much repercussions due to alertmanager being StatefulSet as it guarantees new pod is Ready before killing old pod (Evict API friendly)

Signed-off-by: Leela Venkaiah G<EMAIL_ADDRESS>

rebased


Implement #163 - Shape length verification

PR in progress
Summary:
This PR provides support to execute cross verification of fields stop_times.shape_dist_traveled, trips.shape_id and shapes.shape_id.
Expected behavior:

[ ] For all records from stop_times.txt that have a non-null value for field shape_dist_traveled, shape_dist_traveled should be smaller or equal to the total shape length it is related to. See https://github.com/MobilityData/gtfs-validator/issues/163

[ ] write unit tests
[ ] add javadoc

Please make sure these boxes are checked before submitting your pull request - thanks!

[ ] Run the unit tests with gradle test to make sure you didn't break anything
[x] Format the title like "Fix #<issue_number> - " (for example - "Fix #1111 - Check for null value before using field")
[x] Linked all relevant issues
~[ ] Include screenshot(s) showing how this pull request works and fixes the issue(s)~

Iceboxed


Delete compiler directive from functional tests YAML build

Delete no-longer-used compiler directive from the functional tests YAML build. Specifically, delete msbuild argument  -p:DefineConstants="FUNCTIONALTESTS"
This is build cleanup from PR #3124.

Pull Request Test Coverage Report for Build 95474

0 of 0   changed or added relevant lines in 0 files are covered.
23 unchanged lines in 18 files lost coverage.
Overall coverage decreased (-0.2%) to 78.531%

Files with Coverage Reduction
New Missed Lines
%

/libraries/Microsoft.Bot.Builder/Adapters/TestFlow.cs
1
77.17%

/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/EmitEvent.cs
1
65.22%

/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/IfCondition.cs
1
88.89%

/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/SwitchCondition.cs
1
91.49%

/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/DialogManager.cs
1
80.77%

/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Generators/ActivityChecker.cs
1
86.76%

/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Testing/TestActions/AssertReplyActivity.cs
1
80.77%

/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/OAuthPrompt.cs
1
56.4%

/libraries/Microsoft.Bot.Builder/Inspection/InspectionMiddleware.cs
1
78.89%

/libraries/Microsoft.Bot.Builder.LanguageGeneration/Expander.cs
1
81.43%

Totals

Change from base Build 95461:
-0.2%

Covered Lines:
13154

Relevant Lines:
16750

💛  - Coveralls

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3


Support flatcar in aws

What this PR does / why we need it:
Adding support for flatcar os for aws cloud provider.
Which issue(s) this PR fixes
Fixes kubermatic/machine-controller#716
None

/retest


ARM gives too many initial potato bugs

ARM makes you start with not 2, not 3, but 4 potato bugs on game start.
Quick, someone get a deep fryer!

fixed by https://github.com/sirgwain/craig-stars/commit/8abb5244ebdfff2d3bfd74a0ef7749086d4d8560


Link EF Core metrics documentation

After https://github.com/dotnet/EntityFramework.Docs/pull/4743 is merged, this can be merged.

Internal previews

📄 File
🔗 Preview link

docs/core/diagnostics/built-in-metrics.md
Built-in metrics in .NET

@dotnet-policy-service rerun

Unsure why the build still says the page link is missing. I verified that it is published.


[perf] cache nix.searchSystem

Summary
From observing times for adding and removing packages, I notice that a lot of time is spent in syncPackagesToProfile and most of that is from nix.Search, which is a fairly slow operation. However, from observing the results, it seems that these should be constant.
For example, here are the search results that get saved in a local file while running this PR's code:
https://gist.github.com/savil/584c4d9bd6c468aaa8c289265287a23a
Correct me if wrong: all these seem to be constants that won't change, because the queries we run have the nixpkgs-commit-hash in them.
The general nix search command seems to be slower since the query it accepts is an installable regex, which can match a large number of concrete queries. Furthermore, it needs to accept queries likenixpkgs#vim and figure out which nixpkgs commit hash this would resolve to. In our case, our queries are much more specific.
How was it tested?
This effect is more pronounced for packages that are not using store-paths. This will affect all users who are still on nix < 2.17, which is a fairly large percentage for now.
I have a devbox global of about 43 packages. For the times below, I ran devbox global add vim (where vim is already in my /nix/store), and did export DEVBOX_FEATURE_REMOVE_NIXPKGS=0
BEFORE:
syncPackagesToProfile takes about 1 min 30+ seconds
AFTER:
syncPackagesToProfile takes 500ms

Current dependencies on/for this PR:

main

PR #1546   👈

This comment was auto-generated by Graphite.

@savil I just realized the reason this is super slow for you it's because it's downloading nixpkgs. We are searching for the "resolved" packages. Previously nixpkgs always existed because you could not install the package otherwise. But now that we allow installing packages without nixpkgs, this function will needlessly download nixpkgs.
I still think caching is a good idea, but now I think how we do profile comparisons for packages with store path is broken. We should not be running search on a reference that includes nixpkgs if we don't intend on installing the package using nixpkgs
Just to give you an example, if our lockfile includes store paths, then simply comparing the store path on the nix profile and the store path in the lockfile is sufficient.
@gcurtis, for more context:
we use search to find a normalized way to compare packages in devbox.json with packages in the nix profile.
Nix has a set of rules of how it determines the default output. To avoid re-implementing those rules we rely on search. If two flake references with outputs are searched we can compare the results and that way we know we are using same rules as nix.
For example:
github:F1bonacc1/process-compose#process-compose
github:F1bonacc1/process-compose
Are both the same.
Similarly, nixpkgs can be referred to using github, nixpkgs or as a devbox package. This function allows us to compare all of these correctly.
Using eval could work, but in practice can be slower (~600ms) than search. I think the solution is:

We need to ensure we never download nixpkgs for a package that was installed via store path
Add caching to avoid slowish calls to nix search

@savil I just realized the reason this is super slow for you it's because it's downloading nixpkgs. We are searching for the "resolved" packages. Previously nixpkgs always existed because you could not install the package otherwise. But now that we allow installing packages without nixpkgs, this function will needlessly download nixpkgs.

I still think caching is a good idea, but now I think how we do profile comparisons for packages with store path is broken. We should not be running search on a reference that includes nixpkgs if we don't intend on installing the package using nixpkgs

Just to give you an example, if our lockfile includes store paths, then simply comparing the store path on the nix profile and the store path in the lockfile is sufficient.

Ah, no, this is not accurate. In my testing, I had disabled remove-nixpkgs, removed .devbox, and installed all packages in the devbox.json. All timings are after doing that setup and then doing devbox add.
For remove-nixpkgs, @ipince and I added various higher-level functions (like NixProfileItem.Matches) so packages with store-paths don't call this function. Otherwise, you'd be witnessing "Downloading nixpkgs" a lot more!

Directly-installed packages slowing things down makes sense. Even if it's not downloading a new nixpkgs commit, just evaluating the package for the first time can take a while.
Taking a step back, why are we comparing packages in the profile to the ones in devbox.json? I'm a little unsure about adding caching, because that's what Nix is supposed to do. We should just have the devbox-generated flake refer to the packages and save them to a file.
Here's a small example of a flake that could be generated to track Devbox dependencies:
{
  description = "A Devbox environment";

  outputs = { self, nixpkgs }: {
    packages.aarch64-darwin.default = derivation {
      name = "devbox-env";
      system = "aarch64-darwin";
      builder = "/bin/bash";
      args = let
        script = builtins.toFile "builder.sh" ''
          echo "$hello
          $go" > $out
        '';
        in [ "${script}" ];

      # Note the packages don't need to be nixpkgs attributes. They could also
      # be direct store paths or `fetchClosure` calls.
      hello = nixpkgs.legacyPackages.aarch64-darwin.hello;
      go = nixpkgs.legacyPackages.aarch64-darwin.go;
    };
  };
}

If you run nix path-info it spits out all the references:
// $ nix path-info --json | jq
[
  {
    "deriver": "/nix/store/kpl2nb2b3xwkyw0ma4d4qnxvsz3zllgh-devbox-env.drv",
    "narHash": "sha256-KzYFyXkgG8kWpdHNABX/zu6qchMP7TWylosl8/zirOk=",
    "narSize": 224,
    "path": "/nix/store/c9046f6p7dg0v248cvrfhlqbj5bsy544-devbox-env",
    "references": [
      "/nix/store/c4n3i1nfhvcim30s4ij502cw84yl4vdn-hello-2.12.1",
      "/nix/store/dpnvxm37r1z9vk77mdc3h68b95kxvsji-go-1.20.8"
    ],
    "registrationTime":<PHONE_NUMBER>,
    "ultimate": true,
    "valid": true
  }
]

ping


Insert with metadata

Is it possible to insert an index with metadata for each entry?
Thanks.

Right now the metadata is supposed to be an external index. E.g. a dictionary with the lookup by the label that might be stored in hnswlib


Add Trinity and py-solc-x in setup.py

It's inconvenient to have them as build tools in every repo where we use hmt-escrow, so let's add them in setup.py as soon as the last commit from August is released on PyPi for each of them.

@uivlis Did we finish this?

No, there is still no trinity PyPi release with the modifications present in the git version we use.


Zero Currents Addition & Minor CLI Bug

PolarRoute Pull Request Template
Description of change
Making changes to include a zero_currents flag that works from the config_route input. In addition fixing CLI bug with Dijkstra path definition
Testing
To ensure that the functionality of the PolarRoute codebase remains consistent throughout the development cycle a testing strategy has been developed, which can be viewed in the document test/testing_strategy.md.
This includes a collection of test files which should be run according to which part of the codebase has been altered in a pull request. Please consult the testing strategy to determine which tests need to be run.

[x] My changes have not altered any of the files listed in the testing strategy

[ ] My changes result in all required regression tests passing without the need to update test files.

list which files have been altered and include a pytest.txt file for each of
the tests required to be run
The files which have been changed during this PR can be listed using the command

git diff --name-only 0.3.x

[ ] My changes require one or more test files to be updated for all regression tests to pass.

include pytest.txt file showing which tests fail.
include reasoning as to why your changes cause these tests to fail.
Should these changes be valid, relevant test files should be updated.
include pytest.txt file of test passing after test files have been updated.

Checklist

[ ] My code follows pep8 style guidelines.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have updated the documentation of the codebase where required.
[x] My changes generate no new warnings.
[ ] My PR has been made to the 0.3.x branch (DO NOT SUBMIT A PR TO MAIN)

Please find attached the logs for the two requested tests, completed after final commit above.
dijkstra_test.log
smoothed_test.log


Update README CI links

Update the links CI badges. This fixes the error on the README.

@abkfenris this should be ready for review - pretty small change, but it'll fix the status badge 😄

Thanks Max! Looks good to me, but it appears repo permissions got reset after the move, so I can't land it right now.


Error checking self.bases, should be self.aux

I'm not sure this is right. We definitely want to check bases.

I found that bases were checked twice but aux was not checked. Did I understand it wrong?

You're right, good catch!


Extending SincNet convolutional layers

Thanks for this piece of code !
I've recently extended the SincNet filterbank to be a complex analytic filterbank which has been shown to perform much better for source separation applications. See the paper here.
Their implementation is open-sourced here.
If you'd like, I could make a PR to also add this extension is your repo.
Let me know !

Hey, sorry it took me a while to see this post! If you could submit a PR with the complex filter-bank I would be happy to review and integrate!


no res.redirect?

Not yet! On the agenda for 1.0 – see #5 🙌

Think I figured it out
`
import * as encodeUrl from 'encodeurl';
...
res.writeHead(301, { Location: encodeUrl(myurl) });
res.end();
`
Thanks for the help, think I would have never find it out alone

TIL. Thanks man.
On Wed, Dec 19, 2018, 1:59 PM Olivier Refalo<EMAIL_ADDRESS>wrote:

Think I figured it out
`
import * as encodeUrl from 'encodeurl';
...
res.writeHead(301, { Location: encodeUrl(myurl) });
res.end();
`
Thanks for the help, think I would have never find it out alone
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lukeed/polka/issues/78#issuecomment-448479146, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AKHcj-dZqYqeqK2G2h3tSWU557eKgDRwks5u6dW7gaJpZM4ZY_6A
.

Oh, sorry guys. Didn't know there was a question for how to do a redirect. Thought this was just a tracker for res.redirect to exist.
let url = 'https://.../foo/bar';
let str = `Redirecting to ${url}`;

res.writeHead(302, {
	Location: url,
	'Content-Type': 'text/plain',
	'Content-Length': str.length
});

res.end(str);

This is pulled from one of my projects. It displays text in the browser for a moment – which isn't necessary but I chose to have it here.

for compatibility with with other express middlewares like passport, a res.redirect function might also be a good idea

should anyone stumble upon this, I solved my issue by added the method to the res object in a middleware like this:
polka()     .use(function(req, res, next) {         res.redirect = location => {             let str = Redirecting to ${location};             res.writeHead(302, {                 Location: location,                 'Content-Type': 'text/plain',                 'Content-Length': str.length,             });             res.end(str);         };         next();     })


Scrap yard

probably needs some polish 👾

probably needs some polish

Indeed it does. Are you comfortable working the validation errors?
https://github.com/KSP-CKAN/NetKAN/pull/8779/checks

Error: 1418 [1] FATAL CKAN.NetKAN.Program (null) - License Expat-MIT should match spec
that is the official license - not MIT because it isn't MIT - what is collegially referred to as MIT is actually Expat-MIT.

Pushed a commit to fix the remaining issues to get this moving again. Looks good to me, is there anything else to address?


Make picking work correctly within XEO.Viewports

Need picking methods on viewport state chunk

Fixed in https://github.com/xeolabs/xeoengine/commit/b112b9a7e5027b069217dea9d0b1bd94e15b527d


Installation Fails on python 3.12 windows 11 - [App]:

Current Behavior
I have tried to install the package via pip, as written in the site I wrote in the CLI:
 pip install wandb
everything almost goes through, but then crashes with error listed below:
Lib\site-packages\setuptools\build_meta.py", line 341, in run_setup
          exec(code, locals())
        File "<string>", line 25, in <module>
      ModuleNotFoundError: No module named 'imp'

Expected Behavior
I wished it could finish the installation.
Steps To Reproduce
No response
Screenshots
No response
Environment
OS: Windows 11
Browsers:
Version: python 3.12
Additional Context
No response

I'm getting same problem installing through pip in a conda python 3.12 env
Collecting pathtools (from wandb->tradezero==0.0.0)
  Downloading pathtools-0.1.2.tar.gz (11 kB)
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [6 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/tmp/pip-install-51q41hfg/pathtools_9b14847a61414bd0b9f1110c948cb89f/setup.py", line 25, in <module>
          import imp
      ModuleNotFoundError: No module named 'imp'
      [end of output]

might just be that wandb supports only up to python 3.11, it looks like everything is going to have to migrate away from imp for 3.12+

WandB Internal User commented:
evanatyourservice commented:
might just be that wandb supports only up to python 3.11, it looks like everything is going to have to migrate away from imp for 3.12+

hey @JJKK1313 - we just released a new version of our sdk which adds support for 3.12. could you try upgrading your wandb   sdk to 0.16.0 and let me know if you're reaching the same error?

Hi @JJKK1313, since we have not heard back from you we are going to close this request. If you would like to re-open the conversation, please let us know!

hey @JJKK1313 - we just released a new version of our sdk which adds support for 3.12. could you try upgrading your wandb sdk to 0.16.0 and let me know if you're reaching the same error?
Note: this version drops support for python 3.6

Yes, the update probably fixed the issue, I managed to install it now easily. Thanks!


add release.yml and create-tag.yml

@pminz Can you squash the commits and rebase on the latest main please.

Thanks @pminz


Prepare 1.1.5 release notes

Feel free to comment if the anything is missing or there is any mistake.
Signed-off-by: Lantao Liu<EMAIL_ADDRESS>

Codecov Report

Merging #2787 into release/1.1 will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release/1.1    #2787   +/-   ##
============================================
  Coverage        48.99%   48.99%
============================================
  Files               85       85
  Lines             7603     7603
============================================
  Hits              3725     3725
  Misses            3203     3203
  Partials           675      675

Flag
Coverage Δ

#linux
48.99% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cc1302...4b9cc35. Read the comment docs.

LGTM

heads up; I opened https://github.com/containerd/containerd/pull/2802, which should probably be added if that gets merged before 1.1.5 is released

heads up; I opened #2802, which should probably be added if that gets merged before 1.1.5 is released

ACK. I'll update the release note correspondingly.

Merged one more fix in, update and do the release today?

SG, I'll send the cherrypick, and we can let the test run for 2~3 hours, and then cut the release?

Here is the cherrypick https://github.com/containerd/containerd/pull/2818

Updated the release note with "Update runc".

LGTM


[SMALLFIX] Replace anonymous type with lambda

replace anonymous type with lambda in alluxio/core/common/src/main/java/alluxio/util/network/HttpUtils.java

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/2803/
Test PASSed.

alluxio-bot, merge this please


promtool test rules fails to run from prometheus:latest image

What did you do?
Tried to run promtool from the prometheus docker and it fails while it works for the same files
$ promtool test rules tests/unit/promtool/test_unit_available.yaml                                                                                Unit Testing:  tests/unit/promtool/test_unit_available.yaml
  SUCCESS

$ docker run -v $PWD:/tmp --entrypoint "/bin/promtool" prom/prometheus:latest  test rules /tmp/tests/unit/promtool/test_unit_available.yaml
Unit Testing:  /tmp/tests/unit/promtool/test_unit_available.yaml
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x19f3f48]

goroutine 1 [running]:
github.com/prometheus/prometheus/promql.(*LazyLoader).Errorf(0xc00067a000?, {0x34cdded?, 0xc000111c20?}, {0xc0006d7e10?, 0x2fcd000?, 0x56bb9a0?})
	<autogenerated>:1 +0x28
github.com/stretchr/testify/assert.Fail({0x7fcef76a0ba0, 0xc000111c20}, {0xc0000544b0, 0x4f}, {0xc000a40060, 0x1, 0x1})
	/go/pkg/mod/github.com/stretchr/testify@v1.8.4/assert/assertions.go:333 +0x350
github.com/stretchr/testify/assert.NoError({0x7fcef76a0ba0, 0xc000111c20}, {0x3bb7500, 0xc0007d1830}, {0xc000a40060, 0x1, 0x1})
	/go/pkg/mod/github.com/stretchr/testify@v1.8.4/assert/assertions.go:1495 +0xfc
github.com/stretchr/testify/require.NoError({0x7fcef76a0b58, 0xc000111c20}, {0x3bb7500, 0xc0007d1830}, {0xc000a40060, 0x1, 0x1})
	/go/pkg/mod/github.com/stretchr/testify@v1.8.4/require/require.go:1357 +0x8f
github.com/prometheus/prometheus/util/teststorage.New({0x3bc6af8?, 0xc000111c20})
	/app/util/teststorage/storage.go:34 +0xc5
github.com/prometheus/prometheus/promql.(*LazyLoader).clear(0xc000111c20)
	/app/promql/test.go:772 +0xd6
github.com/prometheus/prometheus/promql.NewLazyLoader({0x0?, 0x0}, {0xc000492070, 0x68}, {0x60?, 0xac?})
	/app/promql/test.go:736 +0xa9
main.(*testGroup).test(0xc000a40fa0, 0xdf8475800, 0xc0005930e0?, {0xe0?, 0x8d?}, 0x0, {0xc0006d7d10, 0x1, 0x1})
	/app/cmd/promtool/unittest.go:180 +0xa5
main.ruleUnitTest({0x7ffd516b4f55, 0x31}, {0xa?, 0x0?}, 0xc000a41188?, 0x4c?)
	/app/cmd/promtool/unittest.go:114 +0x58c
main.RulesUnitTest({0x0?, 0x0?}, {0x0?, 0x3ba9140?, 0x1?}, 0x0?, {0xc0006d76e0?, 0x1, 0x0?})
	/app/cmd/promtool/unittest.go:54 +0x131
main.main()
	/app/cmd/promtool/main.go:373 +0xb278

What did you expect to see?
Same output as when I download promtool binary e.g.
Unit Testing:  tests/unit/promtool/test_unit_available.yaml
  SUCCESS

What did you see instead? Under which circumstances?
Unit Testing:  /tmp/tests/unit/promtool/test_unit_available.yaml
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x19f3f48]

goroutine 1 [running]:
github.com/prometheus/prometheus/promql.(*LazyLoader).Errorf(0xc00067a000?, {0x34cdded?, 0xc000111c20?}, {0xc0006d7e10?, 0x2fcd000?, 0x56bb9a0?})
	<autogenerated>:1 +0x28
github.com/stretchr/testify/assert.Fail({0x7fcef76a0ba0, 0xc000111c20}, {0xc0000544b0, 0x4f}, {0xc000a40060, 0x1, 0x1})
	/go/pkg/mod/github.com/stretchr/testify@v1.8.4/assert/assertions.go:333 +0x350
github.com/stretchr/testify/assert.NoError({0x7fcef76a0ba0, 0xc000111c20}, {0x3bb7500, 0xc0007d1830}, {0xc000a40060, 0x1, 0x1})
	/go/pkg/mod/github.com/stretchr/testify@v1.8.4/assert/assertions.go:1495 +0xfc
github.com/stretchr/testify/require.NoError({0x7fcef76a0b58, 0xc000111c20}, {0x3bb7500, 0xc0007d1830}, {0xc000a40060, 0x1, 0x1})
	/go/pkg/mod/github.com/stretchr/testify@v1.8.4/require/require.go:1357 +0x8f
github.com/prometheus/prometheus/util/teststorage.New({0x3bc6af8?, 0xc000111c20})
	/app/util/teststorage/storage.go:34 +0xc5
github.com/prometheus/prometheus/promql.(*LazyLoader).clear(0xc000111c20)
	/app/promql/test.go:772 +0xd6
github.com/prometheus/prometheus/promql.NewLazyLoader({0x0?, 0x0}, {0xc000492070, 0x68}, {0x60?, 0xac?})
	/app/promql/test.go:736 +0xa9
main.(*testGroup).test(0xc000a40fa0, 0xdf8475800, 0xc0005930e0?, {0xe0?, 0x8d?}, 0x0, {0xc0006d7d10, 0x1, 0x1})
	/app/cmd/promtool/unittest.go:180 +0xa5
main.ruleUnitTest({0x7ffd516b4f55, 0x31}, {0xa?, 0x0?}, 0xc000a41188?, 0x4c?)
	/app/cmd/promtool/unittest.go:114 +0x58c
main.RulesUnitTest({0x0?, 0x0?}, {0x0?, 0x3ba9140?, 0x1?}, 0x0?, {0xc0006d76e0?, 0x1, 0x0?})
	/app/cmd/promtool/unittest.go:54 +0x131
main.main()
	/app/cmd/promtool/main.go:373 +0xb278

Other environment information:
$ docker version
Client:
 Version:           24.0.5
 API version:       1.43
 Go version:        go1.20.8
 Git commit:        ced0996
 Built:             Sat Oct  7 00:14:00 2023
 OS/Arch:           linux/amd64
 Context:           default

Server:
 Engine:
  Version:          24.0.5
  API version:      1.43 (minimum version 1.12)
  Go version:       go1.20.8
  Git commit:       a61e2b4
  Built:            Sat Oct  7 00:14:30 2023
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          v1.6.21
  GitCommit:        3dce8eb055cbb6872793272b4f20ed16117344f8
 runc:
  Version:          1.1.7
  GitCommit:
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

System information
Linux 6.5.0-21-generic x86_64
Prometheus version
2.50.0 but this happens with 2.20.0 image,2.30.0, 2.40.0

Prometheus configuration file
No response
Alertmanager version
No response
Alertmanager configuration file
No response
Logs
No response

Weird. @dgl any idea why this is apparently only happening with promtool from the docker image?

Fun bug... the problem is docker run with -v $PWD:/tmp -- this is making /tmp be mounted as whatever the working directory is, which likely isn't set up to be world writable like /tmp is expected to be. This means os.MkdirTemp fails (as the Docker image runs as nobody). I clearly need to fix the error reporting though, it shouldn't be using testify on this code path.
tl;dr: Rather than using /tmp, use something without a special meaning like /data.

Good catch actually, it never occured to me that mounting tmp could create an issue. I 'll make sure to avoid this practice in the future.
Thanks for the workaround. I 'll leave this open since it's something you need to fix.


Exception when using strip:1

decompress-zip:0.0.6: Extracting a simple zip file with one level of empty directory at the root will throw an TypeError on path.join decompress-zip.js:259 if strip:1 is set
DecompressZip.prototype.extractFile = function (file, options) {
var destination = path.join(options.path, file.path);

The issue is in decompress-zip.js:109..120, which, instead of adding .path to the file entry, is returning the path directly in files.map().
files = files.map(function (file) {
                if (file.type !== 'Directory') {
...
                    return file.path //<-- this is replacing file with file.path in the map.
                    // should be:
                    //   file.path = path.join(dir.join(path.sep), filename);
                    //   return file

                }

Note: The current tests do not detect the issue as they do not validate the feature at all - they just test strip to see if an exception is thrown for the 'stripping too deep' case. Ideally, the stripping too deep test case should validate the exact exception expected and a new test case with strip:1 should be added.

https://github.com/bower/decompress-zip/pull/31


On Gamestart we just have a blackscreen with a hand that says grab

We figured out your mod is causing this problem sadly. It started happening today not yesterday night so I have no clue what happened. We use the "XspacerX" Modpack and your mod is one of them sadly not working since today :d

me too,yesterday is all good

solved


fix: manage migration of OrganizationUsers duplicates

fixes AM-942
Description
Manage Organization duplicate during execution of migration script.
This update only manage cockpit users and organization users created with the default gravitee ognization user idp

Integ test not executed as the changes are only targeting a mongo script


Devise Docs Alignment Strategy for OSE

Phase 2 of this project is about evolving tbd.developer.website's clarity:

Why Web5/tbDEX/Decentralization/Self-Soverign Identity is important
What Web5 is
How to quickly Get Started building Web5 applications.

The "Getting Started" piece in particular is an interface point between Programs, DevRel, and Open Source Engineering.
@kirahsapong has volunteered as this project's Ambassador to the Open Source Engineering group. This ticket is an umbrella for the tasks she may create in service of making sure that the documentation types and the site infrastructure are well-fit for the sample applications, playgrounds/sandboxes/, tutorials, and any other documentation types to be submitted and surfaced on developer.tbd.website. This may include strategies for:

Where the sample/example/playground code lives
What the maintenance lifecycle for code-based docs looks like.
Is there CI/CD?
Tests?
How do we ensure everything works as new releases are made? How do we ensure the written docs are kept up-to-date with new versions of code?

Up to the DRI of this task to outline the concerns which should be addressed, create issues for them, and work throughout the teams to drive them to completion.

Next step: @kirahsapong sets time w/ ALR to decompose this and Kirah walks through your thinking

Inventory of considerations to make issues for:

New Sections:

"Concepts" section - A place that defines common paradigms, terms, approaches. Example: "Self-Sovereign Identity",
"Glossary" Section - A place that defines common terms, may link off to specs. Example: "Verifiable Credential". For instance: https://developer.mozilla.org/en-US/docs/Glossary/Search_engine
"Reference" Section - A place that outlines data types. Example: the structure of a DID Document. For instance: https://developer.mozilla.org/en-US/docs/Web/HTML/Element

Note on above: @kirahsapong wonders if "Glossary" and "Concepts" are the same?
ALR Note on above: Probably good to link w/ @bobbilee19 and @angiejones about where the above sections live. In the docs section? Under the "Learn" section of the Developer Site?
Define DRIship of Getting Started Application - and think about who should be responsible for which pieces of this longer-running effort that likely should be released in phases. For this Phase 2 of the Developer Site, no delivery needed here, but clarity on when and who is making Getting Started applications would be great.
Align w/ Bobbilee on "Documentation Content Types", for example "Tutorials", "Playgrounds/Sandbox", "Sample/Example Applications" - and ensure that of the content types OSE would like to surface is accounted for. Also: is there a template for these types that we can use to make creating new ones easier, and drive uniformity so each content type follows a similar form.
DRIship for issues proposed in the issue description

Added issues in the Project Board for OSE reps to DRI project docs of each project.

Bumping from Phase 2 to at least 3 per @kirahsapong


[release-1.6] fix hpa scaleTargetRef

This is an automated cherry-pick of #24887

@istio-testing: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.6
43f401d7f01c7c3f2583e36600f71237566130e5
link
/test gencheck_istio_release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.6
43f401d7f01c7c3f2583e36600f71237566130e5
link
/test gencheck_istio_release-1.6

unit-tests_istio_release-1.6
43f401d7f01c7c3f2583e36600f71237566130e5
link
/test unit-tests_istio_release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

cc @richardwxn can you look into this issue?

/retest

@istio-testing: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.6
43f401d7f01c7c3f2583e36600f71237566130e5
link
/test unit-tests_istio_release-1.6

gencheck_istio_release-1.6
43f401d7f01c7c3f2583e36600f71237566130e5
link
/test gencheck_istio_release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.6
43f401d7f01c7c3f2583e36600f71237566130e5
link
/test gencheck_istio_release-1.6

unit-tests_istio_release-1.6
43f401d7f01c7c3f2583e36600f71237566130e5
link
/test unit-tests_istio_release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.6
a94e3d504a88091ccab79be2326a99c014f2d358
link
/test unit-tests_istio_release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio_release-1.6


cleanup unused scripts and Makefile

Signed-off-by: yeya24<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
Clean up the unused scripts and Makefile.

make check is not used and we already have golangci-lint check
vendor is not used as well

Ⅱ. Does this pull request fix one issue?

NONE
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

@yeya24  Does golangci-lint also checks the boilerplate?

Does golangci-lint also checks the boilerplate?

I do not think so. @Starnop

Oh, I agree with you. @yeya24

LGTM


Improved table encoding code to handle sparse arrays.

By going through the table before to get the maximum index we can handle sparse arrays. Also tostring seems to work better by maintaining float and integer number conversion.

Hello! This would be nice change, but table.pack() creates an array with property n. Would it be possible to add check to line 71, that if k == "n" and type(v) == "number" then length = v else treat as object?
Lua documentation: https://www.lua.org/manual/5.2/manual.html#pdf-table.pack
Current behaviour:
> json.encode({1, nil, 3})
"[1,null,3]"
> json.encode(table.pack(1, nil, 3))
"{1:1,3:3,\"n\":3}"

Why is this beneficial?
If lua array ends with nil(s), they are trimmed. If we however use table.pack, the original count of objects is stored in property n allowing the array to end with nil/null.

Fixed that. Now arrays can be specified through table.pack.

@appgurueu
Is there a reason for your abrupt and occasionally hostile behavior?
You're coming off as unnecessarily rude.

@appgurueu Is there a reason for your abrupt and occasionally hostile behavior?
You're coming off as unnecessarily rude.

I'm not sure what you consider to be rude about my review. I made three comments:

Pointing out a possible worst-case scenario.
Labeling a clear code smell (outcommented code) as "dirty". If it isn't dirty, is it clean? I believe(d) this to be self-evident; it does not need elaboration. Maybe I should have phrased this differently, as "oops, looks like you forgot some outcommented code here"?
Pointing out that using tostring on numbers is unreliable (if a certain format is expected). I should have elaborated on this; I didn't because it is something I am used to.

This was intended just as very "direct" feedback from a quick look.
In hindsight, some of it would have needed some elaboration.
If I came off as rude to @aryajur, that was not my intention, and I apologize for that.

@appgurueu Is there a reason for your abrupt and occasionally hostile behavior?
You're coming off as unnecessarily rude.

I'm not sure what you consider to be rude about my review. I made three comments:

Pointing out a possible worst-case scenario.
Commenting on the bad formatting.
Labeling a clear code smell (outcommented code) as "dirty". If it isn't dirty, is it clean? I believe(d) this to be self-evident; it does not need elaboration. Maybe I should have phrased this differently, as "oops, looks like you forgot some outcommented code here"?
Pointing out that using tostring on numbers is unreliable (if a certain format is expected). I should have elaborated on this; I didn't because it is something I am used to.

This was intended just as very "direct" feedback from a quick look. In hindsight, some of it would have needed some elaboration.
If I came off as rude to @aryajur, that was not my intention, and I apologize for that.

I appreciate your feedback. Would always want to improve my work.


Code cleanup for Api::extractMetaDataFromTreeInfo()

Fixes #8.

Current coverage is 92.75%

Merging #11 into develop will decrease coverage by -0.10% as of 0291a6f

@@            develop     #11   diff @@
=======================================
  Files             3       3
  Stmts           210     207     -3
  Branches          0       0
  Methods          48      48
=======================================
- Hit             195     192     -3
  Partial           0       0
  Missed           15      15

Review entire Coverage Diff as of 0291a6f

Powered by Codecov. Updated on successful CI builds.


Datasets from Raphenya et al

ESKAPE pathogens found in https://www.nature.com/articles/s41597-022-01463-7
Datasets for benchmarking antimicrobial resistance genes in bacterial metagenomic and whole genome sequencing
https://doi.org/10.1038/s41597-022-01463-7

Data are found in https://zenodo.org/record/6543963


Process errors and call callbacks properly

when triggering builds on CI systems. No more fire-and-forget logic.
Fixes #194

Coverage decreased (-0.3%) to 54.71% when pulling e3028e7f1a43ba1e168d4298831335e2f2573bd6 on rhyolight:fix-194 into b0e7da186b88d4359dce3ed983bd29daf2865a8c on numenta:master.


Add lang/jobtype column to racetrack-client list command

It would be nice if racetrack-client's list command could return a column with the jobs' langs
Currently, this is not an option with racetrack-client v. 2.10.1

Good idea. It will be easy to do right after merging https://github.com/TheRacetrack/racetrack/pull/205

Good idea Dr. ZCG Number 909.
by the way, if you pipe the output into another command it drops the fancy formatting, right?

by the way, if you pipe the output into another command it drops the fancy formatting, right?

Nope, just checked that racetrack list | cat gives the same output, including ANSI color chars.


possible fix for 82 Response filter is not valid error

I did some research into this issue and it looks the same as this reported in this blog post. It seems there is a bug in ASP.NET 3.5 where you must read the response filter before you set it.
I create a pull request with this fix however I was unable to repro the error so I cannot verify the fix definitely works.

Thanks Matt! I saw that yesterday and was gonna try the same thing. Thanks for adding this. @rdorris: before we actually release this, could you pull this down from here either by forking or just downloading the source here: https://github.com/mwrock/RequestReduce/zipball/master. From a power shell command line in the path of the solution root, enter ./build build-output and then copy the RequestReduce/Nuget/Lib/net20/RequestReduce.dll to your project and let us know if this fixes your issue?  Thanks and let me know if you have any issues building the binary.


Release Google.Cloud.CertificateManager.V1 version 2.7.0

Changes in this release:
New features

Add IServiceCollection extension methods for client registration where an IServiceProvider is required. (commit 022fab2)

Created release for Google.Cloud.CertificateManager.V1-2.7.0


Can't run in client mode: tcp.go:67: failed to get target address: SOCKS error: 8

Describe the bug
Doesn't work in client mode.
To Reproduce

open console 1 and run in server mode: c:\app\shadowsocks2-win64.exe -s ss://AEAD_CHACHA20_POLY1305:pass@:465 -udp
open console 2 and run in client mode: c:\app\shadowsocks2-win64.exe -c ss://AEAD_CHACHA20_POLY1305:pass@<IP_ADDRESS>:465 -socks :10802 -verbose -u
set proxy to socks5 port 10802 and try to navigate to google.com
see tcp.go:67: failed to get target address: SOCKS error: 8 in console 2
browser can't navigate
other ss-clients works fine with server running as on 1st step

Expected behavior
must work
Desktop (please complete the following information):

OS: Windos 7 64bit

这是来自QQ邮箱的假期自动回复邮件。

您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。

这是来自QQ邮箱的假期自动回复邮件。

您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。


Editor content in view mode issue

@amaldinesh7 _a https://youtu.be/gFIk6Cv2aVE

@rishavkr08 _a Please check the Output section in the documentation - https://neeto-editor.netlify.app/.

@amaldinesh7 I already checked the editor, in the console it prints correctly. But in the application, the view is different.

Works fine with EditorContent component of neeto-editor.


add runtime display support

[root@centos7 _output]# ctr c ls
CONTAINER                                                           IMAGE                               RUNTIME
d3fca4e7912c7006ec248a822b4c0b88eb2dea90c4cfc085bc67879d87c3f7c6    docker.io/library/busybox:latest    io.containerd.runc.v2
nerdctl should support  it

I move platform  and runtime to --fortmat wide,bracause  platform's value often null


ImportError while importing test module

I just encountered this error when ever i get to the end of any test.
It was working fine before i updated my branch. (i was running 4 commits behind)

Rebuild your container or run script/setup. That should fix it, but reopen the issue if that's not the case.


DOC: some general doc/sphinx fixes

lgtm

@jreback there were some lint issues introduced in https://github.com/pydata/pandas/pull/13710 (so travis for master will start to fail when it reaches that PR). But fixed them here


Questions about st link

[ ] Programmer/board type: Stlink/v2-onboard
[ ] Programmer firmware version: lost
[ ] Operating system: Windows 10
[ ] Stlink tools version and/or git commit hash:
[ ] Stlink commandline tool name:
[ ] Target chip (and optional board): STM32F401RE

Hi.
I lost st-link firmware of NUCLEO-F401RE.
I can not download the target device(STM32F401) firmware.
I need st-link firmware version V2.Jxx.Mxx..
Can I obtain a st link V2-1 hex file?

I must say this is not related to our project. You should use the original firmware upgrade tool from STlink itself or else you can move your programmer to the trashcan. Firmware on the program "doesn't get lost"  by itself (normally). If you can connect to the programmer with the STLink firmware upgrade tool or STUtility from ST itself then you are out of luck.

Sorry yiraseo questions unrelated to the current project.
After various attempts, and currently it operates V2.Jxx.Sxx version.
Should it not possible to change it back to V2.Jxx.Mxx version?
Sorry again yiraseo questions not related to the project .. T.T

I don't understand what you say. Why should you change back the firmware? I have never heard of Mxx version, as only Sxx (SWIM interface) is available.

Nucleo have Mxx version.
Disco and ST-LINK/V2 have Sxx version.
I have an Sxx version hex file downloaded from Google.
but I really need Mxx version hex file..

I think you are at the wrong place for this question, I would like to help but I have no idea how you broke it.

@gandol2 I have found an article about firmware corruption:
http://www.carminenoviello.com/2016/02/26/restore-st-link-interface-bad-update-2-26-15-firmware/


Replace instances of v1beta1 with v1beta3

Per issue 7502, replaced all instances of “v1beta1/proxy” with
“v1beta3/proxy/namespaces/default” and “v1beta1/redirect” with
“v1beta3/redirect/namespaces/default”. Also removed all trailing ‘/‘
forward slashes.

Can you delete the section which contains:
$ cat ~/.kube/kubernetes-satnam2_kubernetes/kubernetes_auth
{
  "User": "admin",
  "Password": "4mty0Vl9nNFfwLJz",
  "CAFile": "/Users/satnam/.kube/kubernetes-satnam2_kubernetes/kubernetes.ca.crt",
  "CertFile": "/Users/satnam/.kube/kubernetes-satnam2_kubernetes/kubecfg.crt",
  "KeyFile": "/Users/satnam/.kube/kubernetes-satnam2_kubernetes/kubecfg.key"
}

and replace it with the use of kubectl config view for obtaining the basic authentication username and password? Thansk. @roberthbailey

The section you refer to above that you want replaced with `kubectl config view' was done with pull request 7956. Should i instead combine all changes into one branch/one PR?

If you write a # symbol in front of the number 7956 it forms a link #7956

OK, let's wait for the other PR to merge, and then you can rebase this one -- otherwise it is too hard for me to understand what is going on!
Any idea why your CLA is not approved yet?

ICLA signed (requirement for contractors)

Can you re-base your other merged PR? Something like this I think:
$ fetch upstream
$ rebase upstream/master
$ push -f origin 7094-v1beta1_to_v1beta3

I did author these commits.

Note that you have other people's commits in here. Please can you:
$ git rebase -i HEAD^10

and delete the other commits? Thanks.

I propose that you change:
To access a service endpoint /alpha/beta/gamma/ via the proxy service for your service myservice you need to specify an HTTPS address for the Kubernetes master followed by /api/v1beta3/proxy/namespaces/default/services/myservice/alpha/beta/gamma.

to:
To access a cluster service endpoint via the proxy you should prefix the name of the service with /api/v1beta3/proxy/namespaces/default/services e.g. /api/v1beta3/proxy/namespaces/default/services/elasticsearch and /api/v1beta3/proxy/namespaces/default/services/elasticsearch/_search?q=user:kimchy


⚠ ClamAV has degraded performance

In 630011c, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 56 ms

Resolved: ClamAV performance has improved in b67bf8a after 5 minutes.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/109214

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/109649

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/110892

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/110923

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/113296


Sarosij's app submission

Hey @ChandanP007,
Here is my submission of the flutter forward event.
A simple UI of a to-do list app. Please check my submission
and merge it.
Here is a screenshot :

Looks good to me 👍


Fix bad data in example deviation file

The inclination value provided (424) is outside of the normal
inclination domain range which we expect to be 0 <= inc < 180.
The neighbouring values of 4.87 and 4.42 suggest that the
value of 424 should actually be 4.24
The corresponding test output value (987.03517) was also updated
to 998.45378 to reflect the corrected inclination.

Seems like there should be a test containing some bad data? Maybe add a new file with one or more perturbations that we can then catch / warn about.

Yes I agree I've added issue #157 so we can do that later.


Create TF Module that implements public/private subnet strategy in existing VPC

What

Create TF Module that implements a public & privatesubnet strategy using existing VPC

Why

Encapsulate business logic of VPCs and Subnets in a module

@s2504s looks great! Just add README.md

There was an issue if we try to use existing AWS Internet Gateway and Default Route Table.
Even if we use code like this it doesn't work.
resource "aws_route_table_association" "public" {
  count = "${length(var.availability_zones)}"
  subnet_id      = "${element(aws_subnet.public.*.id, count.index)}"
  route_table_id = "${signum(length(var.vpc_default_route_table)) == 1 ? var.vpc_default_route_table : aws_route_table.public.id }"
}

Because if we do not create aws_route_table.public (when we use existing route table), Terraform is unable to resolve aws_route_table.public.id and we got an error.
Error running plan: 1 error(s) occurred:

* module.tf_subnets.aws_route_table_association.public: 2 error(s) occurred:

* module.tf_subnets.aws_route_table_association.public[0]: Resource 'aws_route_table.public' not found for variable 'aws_route_table.public.id'
* module.tf_subnets.aws_route_table_association.public[1]: Resource 'aws_route_table.public' not found for variable 'aws_route_table.public.id'

I've pinned igw_id as required value and added resources for two cases: use existing aws_route_table and create new aws_route_table.
resource "aws_route_table_association" "public_new" {
  count = "${signum(length(var.vpc_default_route_table)) == 1 ? 0 : length(var.availability_zones)}"
  subnet_id      = "${element(aws_subnet.public.*.id, count.index)}"
  route_table_id = "${aws_route_table.public.id}"
}

resource "aws_route_table_association" "public_exists" {
  count = "${signum(length(var.vpc_default_route_table)) == 1 ? length(var.availability_zones) : 0}"
  subnet_id      = "${element(aws_subnet.public.*.id, count.index)}"
  route_table_id = "${var.vpc_default_route_table}"
}

I've tested terraform plan with two cases:
module "tf_subnets" {
  source = "git::https://github.com/cloudposse/tf_subnets.git?ref=init"

  availability_zones      = ["us-east-1a", "us-east-1b"]
  namespace               = "test"
  name                    = "test"
  stage                   = "test"
  region                  = "us-east-1"
  vpc_id                  = "vpc-aceb27ca"
  igw_id                  = "igw-9c26adfb"
  vpc_default_route_table = "rtb-f4f0ce92"
}

module "tf_subnets" {
  source = "git::https://github.com/cloudposse/tf_subnets.git?ref=init"

  availability_zones      = ["us-east-1a", "us-east-1b"]
  namespace               = "test"
  name                    = "test"
  stage                   = "test"
  region                  = "us-east-1"
  vpc_id                  = "vpc-aceb27ca"
  igw_id                  = "igw-9c26adfb"
}

Both are ok.

@osterman please review

Added required fixes.
@osterman please approve.


ChestCommands (Chest GUI) just make it crash with JSON error...

The title say it all, sorry
Thank for your awesome work
Ah, another thing: when i use 1.9 it lag (chat is retarded)

Use version 0.3.4

WoW that's awesome XD Really thanks, a lot


TC Overrides QSS3BucketName parameter in parameter file

Description:
I am trying to run a stack using resources from a different S3 Bucket.
To Reproduce
This is an example of the parameter being passed.

This is the output from TC when preparing to launch the stack

Are you testing a QuickStart or Custom template? QuickStart
Attach or link a copy of the template if possible (remove any sensitive info)
Provide the parameters that you passed. (remove any sensitive info) See Image Above
How did you install taskcat? (docker or pip3) pip3
Are you using a profile, an instance role or  access keys to run taskcat? profile
Is your AWS environment configured via aws configure? Yes

Expected behavior
The input parameter should not be ovewitten
Screenshots
If applicable, add screenshots to help explain your problem.
**Version (Please make sure you are running the latest version of taskcat)

Taskcat Version (ex: [2018.817.210357]) 0.8.35

Note: Python Version (python3 required) python3
To find versions:
Via taskcat: taskcat -V
Via pip3: pip3 show taskcat
Note: both version should match
To update taskcat run:
for docker : docker pull taskcat/taskcat
for pip3: pip3 install --upgrade taskcat
Additional context
Add any other context about the problem here.

Hey Tony add the s3bucket key (in the global section) to your taskcat.yml
Then set value to the bucket you want to use.