@material-ui/pickers is not optional

Hello. I don't use @material-ui/pickers and any pickers but cannot use your lib without this extra dependency
Failed to compile.

./node_modules/material-ui-formik-components/DatePicker/DatePicker.js
Module not found: Can't resolve '@material-ui/pickers' in 'D:\JS\poemarket\frontend\node_modules\material-ui-formik-components\DatePicker'

same for the material-ui-chip-input

Hello @CyanoFresh.
Make your imports this way:
import { TextField } from 'material-ui-formik-components/TextField'
import { Select } from 'material-ui-formik-components/Select'

instead of
import { TextField, Select } from 'material-ui-formik-components'

Sorry, I've been importing the first way but now it works by itself


Support for Windows Alt codes for extended ASCII input

When trying to insert a character with an alt code in Godot, in any text field, it will not be picked up.
For this purpose, I tried to enter the curly apostrophe: ’ (Alt + 0146)
Example 1:

Open a new scene
Add a Label node
When writing text in the text field, enter Alt + 0146

Example 2:

Open a new scene
Add a TextEdit field
Save scene
Play scene
In the text field, try to enter Alt + 0146

Neither of these approaches will work.

At first I thought this was related to Unicode, but it does not work even with standard ASCII characters (like Alt+65 for "A").

this is very windows specific.. i have no idea how to fix it.. godot just gets unicode characters, so maybe this is a behavior of Window's line edit control, which godot does not use?

Retagging as a feature proposal, as it's not a bug per se, it's just a feature of Windows input controls that we don't have in Godot's cross-platform controls.
I've had a quick look for examples of how this could be implemented, but couldn't find anything relevant (the name of the "feature" doesn't help search engines though).
If someone wants to look into, it might be worth checking how cross-platform toolkits like Qt or GTK+ handle it. If it's possible to implement it at all, then it might be interesting to also look into supporting Ctrl+Shift+U + hex which is used (at least by GTK+ apps) to input any Unicode character.

I have the same problem, my keyboard doesn't have keys for angle brackets < >.
I usually get them with Alt+60 and Alt+62 (using numeric keyboard) but that doesn't work in godot, so I'm copypasting them from another application. The right bracket is specially useful to statically type the function return values (func xxx() -> int:).
I imagine two possible solutions:

add a specific command for inserting a > so we can bind a shortcut to it
change the autocompleter so when a hyphen is added after a funcion signature it autocompletes with the bracket, maybe the semicolon, and the cursor gets in the place of the type

Before autocompletion:
func get_some_integer() -
After autocompletion:
func get_some_integer() -> :

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!

Implemented by #55441.


Dialog layering issues

Comment history sometimes spawns behind CustomProfileLayer
When you click on my levels from a CustomProfileLayer spawned by a comment and go back input focus goes to the InfoLayer behind it, even though CustomProfileLayer still appears on top

This is temporarily worked around in v2.0.1 by closing CustomProfileLayer but I don't consider that a proper fix

dont care anymore


Pyperclip no longer working with WSL2 version of Ubuntu

I've just upgraded to the May 2020 release of Windows 10, and in the process have enabled WSL v2 (using the Ubuntu distro).  Sadly, the upgrade has broken Pyperclip which now returns the "Pyperclip could not find a copy/paste mechanism for your system".
I noticed a previous commit to add support for WSL, so wonder whether this needs a tweak for WSL2?

Same here. I tried downloading the recommended packages for Linux on the Pyperclip page. No luck. Some of the packages didn't intall. Others just didn't do anything at all.

same on my  distro
Linux kali 5.7.0-kali1-amd64 #1 SMP Debian 5.7.6-1kali2 (2020-07-01) x86_64 GNU/Linux

same here on Debian unstable. Investigating…

This is probably related to !168

D'oh - failed to spot #168 when I raised this one!


Hero UI Responsivenenss

I worked on the Hero responsiveness.
#315
See Screenshots

Thank you.
Well done.


Issue with Certificate Expiry Overview page and deprecated JWT

Expected Behaviour
On the Service Account (JWT)
DEPRECATED](https://developer.adobe.com/developer-console/docs/guides/email-alerts/cert-expiry/) page, on Step 2, task 2, it states to "Go to the Service Account (JWT) tab"
Actual Behaviour
When I go to that task, it is now replaced with "Service Account (JWT) DEPRECATED."  Drilling down further, it speaks to how JWT is being deprecated and being replaced by OAuth.  It's not clear how to refresh an expiring certificate under that circumstance.
Reproduce Scenario (including but not limited to)
Steps to Reproduce

Go to https://developer.adobe.com/developer-console/docs/guides/email-alerts/cert-expiry/
Notice that it now says Service Account (JWT)
DEPRECATED
Choose that and see completely different instructions than what the documentation indicates.

Platform and Version
Sample Code that illustrates the problem
Logs taken while reproducing problem

I hope you solved it, but on the same page you must scroll to the bottom of the page to refresh certificates.


Ruby 2.4 error: Warning is not a class (TypeError)

Ruby 2.4 now has it's own Warning class which causes the error:
Warning is not a class (TypeError)
~/.gem/ruby/2.4.0/gems/structured_warnings-0.2.0/lib/structured_warnings/warning.rb:11:in '<top (required)>'
~/.gem/ruby/2.4.0/gems/structured_warnings-0.2.0/lib/structured_warnings.rb:4:in '<top (required)>'
~/.gem/ruby/2.4.0/gems/attempt-0.2.1/lib/attempt.rb:2:in '<top (required)>'

This error is due to the dependency on structured_warnings (0.2.0) which could be fixed with something like structured_warnings#7

structured_warnings just released version 0.3.0 which is now compatible with Ruby 2.4.x
See the compatibility note for how to upgrade

I pushed out 0.3.0 which updates the constant and dependency.


[WIP] Adding system Lisp implementation support for CI

This allows to run CI with CLISP, CMUCL, ABCL, ECL and Allegro CL.
If $LISP is one of below, the installer script installs corresponding implementation:

clisp
cmucl
cmu (Same as cmucl)
abcl
ecl
allegro
alisp (Same as allegro)

ex) https://github.com/fukamachi/quri/blob/3f9bb50836cec41bfd45c2fe78327df2536538cf/.travis.yml
This requires 'sudo' if $LISP is clisp or abcl because they needs 'clisp' and 'default-jre' to be installed via APT.
If those packages are installed beforehand (ex 'addons' directive in .travis.yml), it doesn't require 'sudo'.
As ECL doesn't provide a binary package, it takes much time to CI for it.
The installs implementations under ~/.roswell/impls/system (not /usr/local like cl-travis does) because this makes it easy to cache on CI services.

+1

I'm just amazed with the quick implementation.Thank you very much :+1:

This doesn't support Multiple OS container of Travis CI, btw.
http://docs.travis-ci.com/user/multi-os/


CI: Wait on create/delete in helpers.SampleContainersAction

We use this utility function in a number of test suites, cleaning up
when they end. We don't wait for the deletes (or creates) to complete
and this may cause a race with later tests. We now enforce a wait when
creating or deleting endpoints.

This change is

test-me-please

test-me-please

test-me-please

test-nightly

Main CI passed. Failure in nightly CI is unrelated.


Dex certificate/key should be mandatory only when dex is turned on

Running kube-aws validate on a cluster without Dex turned on but also without credentials/dex.pem causes this:
Error: Failed to initialize cluster driver: failed to read/create TLS assets: open credentials/dex.pem: no such file or directory

Same with kube-aws update. Perhaps the cert+key for Dex should only be validated as present when that feature is turned on? Otherwise this forces a user to run render credentials which in turn causes update to fail, see https://github.com/kubernetes-incubator/kube-aws/issues/600.

@c-knowles Missed this part on tests. Yes, we should remove validation for dex certificates, if dex is turned off. I'll take a look to see if we can fix this quickly.

any update?

@c-knowles @VinceMD Completely removed the certificates generation in #820. Closing.


TreeItem EraseButton does not work reliably

Godot version
v4.0.beta9.mono.official [e780dc332]
System information
Linux Mint 20.3 Cinnamon, NVIDIA Corporation TU106 [GeForce RTX 2070]
Issue description
When calling EraseButton on a TreeItem with exactly one button, the following error occurs:
ERROR: Index p_idx = 2 is out of bounds (cells[p_column].buttons.size() = 1).
After investigating the cause is clear, the Erase function is taking the button id and passing it to the button array as an index. So if the first button you add has the id 0, and the second 1, and so on, the function actually works fine. Conversely if I set the button id to 99 the error says .
ERROR: Index p_idx = 99 is out of bounds (cells[p_column].buttons.size() = 1).
I have to assume that expecting the user to track the order that the buttons are stored in the internal array is not intentional.
Steps to reproduce
Just create a Tree with a TreeItem and then add a button to it with an id that is != 0
Then try to remove that button.
Minimal reproduction project
c# (sorry I don't really do GDScript)
var Tree = new Tree();
var root = Tree.CreateItem();
var item = Tree.CreateItem(root);
item.AddButton(0, someRandomTexture2D, 99);
item.EraseButton(0, 99);

For anyone experiencing this the workaround is to make sure your button id is always the same as the order it was added to the TreeItem, starting with 0. For more complex setups this could be difficult.

check the last line..
basically you're adding a child with an index of say 10, the child is added to the tree at position 10 but the problem is that the tree doesn't have 10 or more children so it puts the child at the next highest index, and since the tree has no children that highest index is 0, this is why trying to erase higher than 0 returns an error.
it is honestly your fault for not reading the docs, (or not understanding) but I think that Tree.CreateItem should return the new index where the item was inserted so we can avoid these issues

That is the wrong section of the docs. The function in question is TreeItem.AddButton:

void add_button ( int column, Texture2D button, int id=-1, bool disabled=false, String tooltip_text="" )
Adds a button with Texture2D button at column column. The id is used to identify the button. If not specified, the next available index is used, which may be retrieved by calling get_button_count immediately before this method. Optionally, the button can be disabled and have a tooltip_text.

It is honestly your fault for not reading the bug report, (or not understanding).
Note that to avoid this problem in the future, there is no reason to assign blame in a bug report. If I write a mistaken report (which happens often enough) I will be embarrassed enough without such comments.
On another note, the AddButton tooltip_text doesn't work. This probably requires another report though.

If you know, that id != index, as a workaround you could use TreeItem.get_button_by_id:
https://docs.godotengine.org/en/latest/classes/class_treeitem.html#class-treeitem-method-get-button-by-id

@Dunkhan apologies if I come off as rude, it wasn't my intention I'm just trying to lend a hand here. besides I don't see why one should be embarrassed for making such mistakes it happens all the time.
so I've done some digging in the source code of Godot and this is the problematic part:

as you can see in the second line it checks if the index is valid by checking if it's smaller than 0 (ok makes sense) and bigger than the buttons size (what the??), so the same things I talked about with Tree.create_item() above is happening here, which shouldn't be the case according to the docs.
so we should either document this, just like it's documented in Tree.create_item() or change its behavior so that it loops all buttons in that column and finds the one with the erase id, as for the tooltip I think you should open a second issue for that.

@DissonantVoid You are right it is the same thing, and to be fair, if I had read the entire documentation page for both Tree and TreeItem I would most likely have realised what was happening. I find it a little strange that an internal implementation detail like what order the buttons are stored in an internal array is the main way for users of the class to reference the buttons. Having said that this appears to be the standard way to do things across the entire UI library. Coming from other UI frameworks it can be especially problematic. Although it can be confusing and occasionally cause difficulties, to change that system in one place and not everywhere else would cause confusion for all the people that are used to the Godot way of doing things. Therefore I think the solution suggested by Sauermann is probably the best we can do.


sTeX folding mode

CodeMirror's fold mode is awesome!  There are built-in folding modules for code, braces, Markdown, XML/HTML, but not for sTeX.  (For comparison, Ace supports all of these.)  This PR fills this hole by providing folding support in sTeX/LaTeX.
Conveniently, @williamstein already wrote this code; I'm just putting this together into a PR (and converting from CoffeeScript to JavaScript).  See https://github.com/sagemathinc/smc/issues/1509 which requests that I do this.
I'm new to the CodeMirror source so let me know if I missed anything.  In addition to the new fold module, I added to the obvious demo.

Hi. Thanks for the PR. But to keep the main distribution maintainable by a small team, we're tightening the criteria for what goes into the main distribution, and are encouraging people to maintain code like this in separate NPM modules. (We will, eventually, also split the current main package into smaller modules.) So it'd be great if you could put this into a separate repository and publish it to NPM. It's not in scope for the main distribution.

OK.  Do you have a suggested naming for the NPM package, e.g. codemirror-stex-folding?  Or would you prefer a more "contributed" namespace?

I'd go with codemirror-fold-stex, so that other folding modules can share the codemirror-fold- prefix.

Ah yes, that is better.  FWIW, markdown-it could be a good model here, which has several self-owned plug-ins and several contributed plug-ins, including links to the latter.  In any case, I'll keep you posted about an NPM module in case you want to assemble a list of links somewhere.

We already have a list which definitely could be improved.

Cool, thanks!  I'll just add to that Wiki once I get around to packaging (maybe making a section for fold-related plugins).


Maybe a issues?

The datapack file show to wave8, but there's no wave8 in the codes, it only show to wave7, which suggests that in-game, raids wave8's illagers don't wear armor, at least in my game, maybe I'm just unlucky?

Nice spot, will put a hotfix out :+1:

Actually, an 8th wave is possible, i'll have to put it into the armorChances switch (the extra wave on hard difficulty counts as wave 8)

Closed in 3.0.1

Actually, an 8th wave is possible, i'll have to put it into the armorChances switch (the extra wave on hard difficulty counts as wave 8)

Let me ask, the illusioner can wear armor? because it can't spawn natural , and MrSterner's grandvillagers fabric mod  dont have illusioner spawn natural option.


feat(ROIThresholdsTools): Made the Rectangle and Circle ROIStartEndThresholds works on other planes

Context
Updated version of the Rectangle/Circle ROIStartEndThreshold tools so they can work on other then acquisition plane.

Changes & Results

Update calculateCachedStats for other plane

Testing
yarn run example RectangleROIStartEndThreshold or on CircleROIStartEndThreshold

Checklist
PR

[] My Pull Request title is descriptive, accurate and follows the
semantic-release format and guidelines.

Code

[] My code has been well-documented (function documentation, inline comments,
etc.)

[] I have run the yarn build:update-api to update the API documentation, and have
committed the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)

Public Documentation Updates

[] The documentation page has been updated as necessary for any public API
additions or removals.

Tested Environment

[] "OS:
[] "Node version:
[] "Browser:

@sedghi  We've made some changes to the way we were doing the 3D ROI. Now there is no more sliceIndex but we are using instead the world coordinates of where the annotation is drawn and we compare it to the focalpoint of the camera.
Also we added the calculation of the basic stats with all the points contained in the 3D roi and the posibility to show the textbost like we have the for the other tools.

@sedghi I think you might have tested an older version.
Here is what I have : https://streamable.com/yx1qd4

Hi @sedghi, is there a chance you could review this PR ? We enhanced it, i think it is ready for review

Yes, we released version 3.8.1, so I will review this issue. Apologies for the delay.

@sedghi thank you ! Next week we will make you a PR to update the command that set the start / stop slice in ohif as now the z limits are set by position and not to the viewport slice index

(PR in ohif not cornerstone)


[DNM] kvrpc: add batch rollback, update commit

After https://github.com/pingcap/kvproto/pull/57
@ngaut @morefreeze

Please add BatchRollback tests.

PTAL @morefreeze @ngaut

LGTM

LGTM


COMMS-613 Dropdown Improvements

Included in this change is:

adding spacing between dropdown menu and the trigger
fix issue where triggers via renderTrigger were not being informed on hover events

Pull Request Test Coverage Report for Build 3123

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.611%

Totals

Change from base Build 3122:
0.0%

Covered Lines:
166

Relevant Lines:
166

💛  - Coveralls

great addition! I wonder if we should add the same spacing to AutoDropdown and ComboBox (SearchableDropdown in v3) ?

@plbabin I just checked each and they both inherited the spacing change in the core Dropdown component. So we're good to go.


[BUG] Support topology aware scheduling of guest cluster workloads

Describe the bug
We would like to be able to configure advanced scheduling of pods in guest clusters, based on the topology and physical architecture of the Harvester cluster.
This would allow - among others - to make use of:

Automatic spreading of pods across failure domains such as regions, zones, racks and servers.
Scheduling of pods to specific physical nodes based on labels

Implementation Details
Kubernetes nodes in the guest clusters would inherit the standard as well user-defined labels assigned to the physical Harvester servers on which they are running on. Such labels may include labels such as performance, instance-type, zone, rack and well-known labels such as topology.kubernetes.io/zone.
These labels would be continuously synced by the Harvester cloud controller.

https://github.com/harvester/harvester/issues/1418


Add option for custom panic handler

This PR adds an option to provide a custom error handler for panics.
By giving more control over the panic error creation, it's possible for the consumer of this library to capture the panics and format the message, add extenstions and send to 3rd party error reporting services.
I opted for keeping existing log.LogPanic functionality to not make breaking changes. But you can write your own panic handler that implements both interfaces. Here's an example of how I'm using a custom panic handler.
// main.go
...
panicHandler := &myerrorlib.PanicHandler{}
rootSchema := graphql.MustParseSchema(
	schema.GetRootSchema(),
	resolvers.NewRootResolver(),
	graphql.Logger(panicHandler),
	graphql.PanicHandler(panicHandler),
)
...

and then in my case I'll provide a custom PanicHandler like so:
package myerrorlib

import (
	"context"
	"github.com/graph-gophers/graphql-go/errors"
)

type PanicHandler struct{}

// LogPanic is a no-op to silence the default panic logging.
// Implements the Logger interface from `graph-gophers/graphql-go/log`
func (p *PanicHandler) LogPanic(ctx context.Context, value interface{}) {
	return
}

// MakePanicError logs and reports the error using the common error library.
// Implements the PanicHandler interface from `graph-gophers/graphql-go/errors`
func (p *PanicHandler) MakePanicError(
	ctx context.Context,
	value interface{},
) *errors.QueryError {
	// create and report custom error for 3rd party logging
	err := createAndReportErrorf(ctx, "panic: %s", value)
	return &errors.QueryError{
		Message:    err.Error(),
		// Decorate error with status code, trace id etc...
		Extensions: err.Extensions(),
	}
}

Please, add unit tests.

@hampusohlsson are you still interested in this change? The code seems to have conflicts. I'm closing this PR. Please, feel free to reopen it later.


[Feature Request] add fs.writeFile(path, File) support

current fs.writeFile support String only
PR https://github.com/StarLederer/vite-plugin-fs/pull/20

I agree with the cause and will take a look at the PR. Thank you very much for your interest!

#20 merged. Thank you once again for your help!


Remove site extension workarounds

https://github.com/aspnet/AspNetCore/blob/master/src/SiteExtensions/build.cmd#L13

Also consider removing this build from PR checks if it takes too long and only run it in the official build.

@JunTaoLuo does any work remain here now that #13044 is in?


Weird particle Bug

Issue Description:
There is a bug with particle rendering related to mekanism.
Nearly everytime a player re-enter a chunk by porting in (it seems, that it doesn't matter what kind of port is used; I tested it with Mekanism Portable Teleporter, RFTools Dimensional Porting System and Journey maps waypoint teleport) all particle effects like for example Botanias Natura Pylon, Mana spreader, Mekanisms Fusion Laser, Endermans teleporting Particles, mining particles, etc are disabled.
This is a multiplayer and SP bug, I could reproduce it in creative SP.
The only fix for this at the moment is to restart the whole client, only reconnecting to the server doesn't help.
But it doesn't seem to be the port itself. The problem doesn't appear, when I am porting into the chunk I am already in. Neither when I am porting into an (clientsided) unloaded area for the first time. And re-enter the chunk by flight causes no problems too.
It seems to be the second port in an area with a mekanism Multiblock like Brine Tower, industrial Turbine, fusion reactor, etc; after that, all particles are gone.
For now, only the induction matrix seems not to be the problem. At least the issue doesn't appear when it's the only multiblock in range - for now.
I confirmed the issue with a minimal setup:
ChickenChunks-1.10.2-<IP_ADDRESS>-universal (to chunkload the teleporter)
CodeChickenCore-1.10.2-<IP_ADDRESS>-universal
CodeChickenLib-1.10.2-<IP_ADDRESS>-universal
Mekanism-1.10.2-<IP_ADDRESS>1
MekanismGenerators-1.10.2-<IP_ADDRESS>1
MekanismTools-1.10.2-<IP_ADDRESS>1
MCMultiPart-1.4.0-universal
Affected Versions:
Minecraft 1.10.2
Forge <IP_ADDRESS>4/2281
Java 8 Update 131
Mekanism : 1.10.2-<IP_ADDRESS>1
Mekanism Generators: 1.10.2-<IP_ADDRESS>1
MekanismTool: 1.10.2-<IP_ADDRESS>1
Dedicated Server for a few friends
215 mods (private modpack)

I wouldn't call this a Mekanism bug, rather an issue with the Minecraft particle renderer. I'm not doing anything that would cause this.

To Clarify:
This issue report should be no offense against mekanism; I like your mod, it has a cool design and nice playstyle.
It's something I've been noticed and which seems relative important so I reported it. ;)
I investigate a little bit deeper and tested following setups so far:
ChickenChunks-1.10.2-<IP_ADDRESS>-universal (to chunkload the teleporter)
CodeChickenCore-1.10.2-<IP_ADDRESS>-universal
CodeChickenLib-1.10.2-<IP_ADDRESS>-universal
Mekanism-1.10.2-<IP_ADDRESS>1
MekanismGenerators-1.10.2-<IP_ADDRESS>1
MekanismTools-1.10.2-<IP_ADDRESS>1
MCMultiPart-1.4.0-universal
(I tested different multiblocks like Fusion Reactor / Industrial Turbine / Brine Tower / Induction Matrix; all on their own, means I broke one block of the multiblock and  tested the next candidate)

Issue encountered by Brine Tower / Fusion Reactor / I-Turbine / Induction Matrix

ChickenChunks-1.10.2-<IP_ADDRESS>-universal (to chunkload the teleporter)
CodeChickenCore-1.10.2-<IP_ADDRESS>-universal
CodeChickenLib-1.10.2-<IP_ADDRESS>-universal
Mekanism-1.10.2-<IP_ADDRESS>1
MekanismGenerators-1.10.2-<IP_ADDRESS>1
MekanismTools-1.10.2-<IP_ADDRESS>1
MCMultiPart-1.4.0-universal
Botania r1.9-341
Baubles 1.102-1.3.10
Botania for his great amount of particle effects and Mekanism only for the teleporter, no other machine

no issue

Botania r1.9-341
Baubles 1.102-1.3.10
ChickenChunks-1.10.2-<IP_ADDRESS>-universal (to chunkload the area, if this cause the issue)
CodeChickenCore-1.10.2-<IP_ADDRESS>-universal
CodeChickenLib-1.10.2-<IP_ADDRESS>-universal
teleport command

no issue

Botania r1.9-341
Baubles 1.102-1.3.10
teleport command

no issue

ChickenChunks-1.10.2-<IP_ADDRESS>-universal (to chunkload the teleporter)
CodeChickenCore-1.10.2-<IP_ADDRESS>-universal
CodeChickenLib-1.10.2-<IP_ADDRESS>-universal
Mekanism 1.10.2-<IP_ADDRESS>2
Mekanism Generators 1.10.2-<IP_ADDRESS>2
Mekanism Tools 1.10.2-<IP_ADDRESS>2
MCMultiPart-1.4.0-universal
teleport command

Issue encountered by Brine Tower / Fusion Reactor / Induction Matrix / I-Turbine

I build the Multiblock and port, the issue appears. I restart the client (only relog doesn't work) and break one block of the multiblock and port, no issue appears. I repair the block and port... issue appears. (Sometimes it happened, when I finished the multiblock and the red sparkles appeared, no need for port)
I tested in my mainworld multiblocks of other mods too, but nothing happened (like Immersive Engineering, EnderIO Capacitorbanks). It seems to be something about the forming of the multi, directly after the red sparkles appears, but this is a shot in the dark.
Maybe the particle renderer of Minecraft is responsible for the issue, but Mekanism's multiblocks are definitely related to it. I'm surprised, nobody else noticed it yet.
You can do with this report what you want now, your the author - ignore it or look a little bit closer to what the relationship between the particle rendering and the multiblocks is.
I won't do anything further.


narrow by instanceof: infer type parameters from original type

class Parent<T> {
  item: T;
}

class Child<R> extends Parent<R> {
  other: R;
}

function narrow(p: Parent<number>) {
  if (p instanceof Child) {
    // what should p's type be?
    p;
    // before this change: Child<any>
    // after this change:  Child<number>
  }
}

This change fixes #28560 by inferring (where possible) the generic type parameters for a class when it's narrowed to by the instanceof operator.
The general process is to infer the parameters as though performing an assignability check of new Child(...) to the super type. This means that it handles e.g.
class Parent<A, B> { a: A; b: B }
class Child<B, A> extends Parent<A, B> { }

and anything else you might try to throw at it.
This is a breaking change. However, nothing in the test suite broke (the only changes would be in the newly-added test case that covers this behavior).
It therefore might be a good idea to put it behind a new strict flag, e.g. --stricterInstanceofNarrowing. However, depending on whether anyone out in the world breaks, that might not be needed.
Not all cases are fully covered (i.e. they still infer any for some/all type parameters), or otherwise behave in a (potentially) unexpected (albeit correct) manner:
class Parent<A, B> {
  a: A;
  b: C;
}

class Child<C> extends Parent<C, C> {
  c: C;
}

function example(p: Parent<string, number>) {
  if (p instanceof Child) {
    p; // Parent<string, number> & Child<string | number>
  }
}

the resulting type is the most-specific sound(ish) type. It's unlikely anyone deliberately will encounter this case (it should be the case that the Child type is uninhabited in that case).

Just as a heads up, your commits don't seem to be associated with your GitHub account. While this isn't technically a problem, you might care if you want more appropriate attribution. You can either make sure your GitHub account is associated with the email address you're using for your commits, or rebase and amend your commits to fix the author name and email.

@typescript-bot test this

@typescript-bot test this new one

The bot lies; RWC is clean.
@typescript-bot perf test this

@ahejlsberg take a look? Interesting change

@ahejlsberg take a look? Interesting change

Will this also fix this case:
class Query<T> {}
function f<T>(q: T[] | Query<T>) {
    if (Array.isArray(q)) {
        q;  // T[], so far so good
    } else if (q instanceof Query) {
        q;  // Query<any>, wtpf
    }
}

In my case there's no inheritance.  I'm literally only checking if it's one of the types already named in the union and it goes and widens it from T to any. 🙁  I can work around it by moving the Query<T> case into an else { } but that's not ideal.

@fatcerberus I think that it should handle that case, but I'm not sure whether the custom type guard in isArray causes problems. I can add that to the test suite to find out.

The isArray check actually doesn’t have anything to do with it - the issue is specifically when there’s an instanceof C check after the type has already been narrowed down to C<T>.  Then the instanceof widens it to C<any>.

This does fix the unnecessary widening issue.

I'm going to update the test to better organize the various facets of this feature that are being tested. Here are a few samples (commented annotations are taken mechanically from the generated .types file):
function dontWidenPointlessly() {
  class Query<T> {
    uses: T;
  }
  function f<T>(p: T[] | Query<T>) {
    if (Array.isArray(p)) {
      p; // p: T[]
    } else if (q instanceof Query) {
      p; // p: Query<T>
    }
  }
}

I've identified some bugs/limitations that need to be corrected before moving forward:
function union() {
  class Parent<A> {
    a: A;
  }
  class Child<B> extends Parent<B> {
    b: B;
  }
  function multipleParents(
    p: Parent<number> | Parent<string> | Parent<boolean> // p: Parent<number> | Parent<string> | Parent<boolean>
  ) {
    if (p instanceof Child) {
      p; // p: Child<number> | Child<string> | Child<boolean>
    } else {
      p; // p: Parent<number> | Parent<string> | Parent<boolean>
    }
  }
  function mixedChildren(p: Parent<number> | Child<string>) {
    if (p instanceof Child) {
      p; // p: Child<string>
    } else {
      p; // p: Parent<number>
    }
  }
  function imcompatibleOptions(
    p: Parent<number> | Parent<string> | { foo: boolean } // p: Parent<number> | Parent<string> | { foo: boolean; }
  ) {
    if (p instanceof Child) {
      p; // p: Child<any>
    } else {
      p; // p: Parent<number> | Parent<string> | { foo: boolean; }
    }
  }
}

There are several problems visible here:

in mixedChildren, Child<string> is preserved but Parent<number> was thrown out entirely! We should expect to see Child<number> | Child<string> in the then-case
in incompatibleOptions the presence of the {foo: boolean} object causes the current heuristic check to fail, and therefore the prior fallback behavior of using Child<any> occurs

It occurs to me that the theory behind the current implementation is not terribly sound. At the same time, it's not entirely obvious to me how this can be corrected.
When we have
let x: T;
if (x instanceof K) {
   ...
}

and K is some generic type e.g. K<T1 extends C1, T2 extends C2> then what we "really" know inside the if is that
x: T & (exists<t1 extends C1, t2 extends C2> in K<t1, t2>)

That is, we know that it's still a T and we also know that there are some parameters that make it into a K<t1, t2> (because otherwise, it's not a "real" K). The exists<T> in S syntax is a strawman for hypothetical existential types in TypeScript.
The trick is that in many (but not obviously all) cases we can simplify this to remove the existential, producing a type that can be expressed in TS today, and is functionally the same.
For example, exists<S extends number> S is functionally identical to number, since any value that could be read from it is a number, and any value that's already a number also satisfies that type trivially.
On the other hand, exists<S extends number> {num: S} is not the same as {num: number}, although it's close, and TS today currently blurs this concept. This is because TS usually types object assignability as though fields were readonly even when they're not. The following is legal today in TS, even though it's not sound:
const a: {f:1|2} = {f: 1};
const b: {f:number} = a;
b.f = 3;

The way this could be done soundly is by annotating every field with a read bound and a write bound; {f: T} can be treated as shorthand for {readonly f: T} & {writeonly f: T}. Then in the above we'd have:
const a: {readonly f : 1 | 2} & {writeonly f: 1 | 2} = {f: 1};
const b: {readonly f : number} & {writeonly f : 1 | 2} = a;
b.f = 3; // error, f is only writeonly with 1 | 2

writeonly fields are contravariant, so attempting to specify b as merely {writeonly f: number} would fail, since number is not a subtype of 1 | 2.
Moving back to the original problem, we would like to say that exists<S extends number> {num: S} is the same thing as {num: number}. This is true in the same sense that {num: 1 | 2} is a subtype of {num: number}; it is, provided that we neglect writable values imposing contravariance constraints.
What this suggests as an alternative, sound(ish) procedure is to therefore consider the type T & exists<S> K<S>, and repeatedly simplify it until it can be expressed entirely in TypeScript without any exists operator (alternatively, add an exists type operator to TypeScript, and just perform simplification while doing the above).
This partly simplifies the view of what must be done- many easy cases fall out immediately. The main problem are object and intersection types (since they have fields, and those fields must be compared against the existential) whereas all other instances are either never or the most general value possible (i.e. what you get when you plug in unknown or the generic constraints for the type, assuming it's covariant, or never if it's contravariant).

const a: {f:1|2} = {f: 1};
const b: {f:number} = a;
b.f = 3;

This kind of blew my mind.  Thinking about it, I guess enforcing the contravariance here might be too restrictive in practice; it would effectively make all objects invariant unless they consisted of nothing but readonly or writeonly properties—the latter of which doesn’t even exist in TS.
Still thought-provoking, though.

Unfortunately, we never finished reviewing this PR. It is pretty old now, so I'm going to close it to reduce the number of open PRs.


Docs: Fix Cache Docs Typo

What is the purpose of this change?
Fixes a typo in the cache docs page that causes Hugo not to find the title and description.

Was the change discussed in an issue or in the forum before?
No

Checklist

[x] I have read the contribution guidelines.
[ ] I have added tests for all changes in this PR if appropriate.
[x] I have added documentation for the changes if appropriate.

[x] I'm done, this Pull Request is ready for review :-)

Thanks for that


docker-py  doesn't seem to be installed error.

Hello, I'm new to ovn-scale-test.
I followed the tutorial but got stuck with the bellow error when I run
ansible-playbook  -i ansible/inventory/ovn-hosts ansible/site.yml -e action=deploy
failed: [<IP_ADDRESS>-> <IP_ADDRESS>] (item=[0, '<IP_ADDRESS>']) => {"failed": true, "item": [0, "<IP_ADDRESS>"], "msg": "docker-py  doesn't seem to be installed, but is required for the Ansible Docker module."}
I did install docker-py by running:
pip install -U docker-py
These are my system specifications:
Ubuntu 4.4.0-34-generic
Docker version 1.11.2, build b9f10c9
Python 2.7.12
Please advice,
Thanks

If you login as a root, please download the ovn-scale-test repo in /root/ovn-scale-test

Thank you! That solved the problem.


Wait for the renderer socket to drain before exiting the extension host process when running tests

This PR fixes #102062

Nice! This should also fix https://github.com/microsoft/vscode/issues/97132


Updates to .NET Core deployment topics for 2.0

We have the following LiveFyre comments for the topic https://docs.microsoft.com/en-us/dotnet/core/deploying/deploy-with-cli:

Process is slightly different for core 2.0. Is there a separate series of docs for core 2.0?
Do you know how it is different? My self-contained app is having issues running, after publish, after upgrading to 2.0. Problems loading 'System.Net.Http.Native' or one of its dependencies. Probably one of its deps because it is in output directory.

@livarcocc @nguerrera what are the changes we need to consider when talking about deployment for 2.0?
/cc @rpetrusha

The topic has been revised for 2.0 and 2.0 by #7468. Closing this issue.


Top search bar is activated even without present in the script

🧐 Have you read the FAQ and viewed similar issues?

[X] I have read the FAQ
[X] I have checked older issues, open and closed
[X] I did a clean install of SpotX as described in the FAQ

Сountry of your account
India
What is your Spotify Plan?
Free
Do you have Spicetify installed?
No
ℹ Computer information
- Spotify: <IP_ADDRESS>2.gf57913e0
- Windows: Win 11 22H2 22631
- PowerShell: 7.4.5

📝 Description
Even without -topsearchbar in install script it is present in the spotify. I have even did a fresh install but still it is present

📸 Screenshots
No response

the new search bar is now impossible to disable starting with version 1.2.46, the -topsearchbar parameter will not work accordingly, you can downgrade your spotify version to 1.2.45 and below
iex "& { $(iwr -useb 'https://raw.githubusercontent.com/SpotX-Official/spotx-official.github.io/main/run.ps1') } -v <IP_ADDRESS>4.gc16ec9f6-118 -confirm_spoti_recomended_over -block_update_on -new_theme"


Pluggable Language Helper Support

The Problem
Currently LanguageHelpers are part of the CLI source code. This means that support for a given language must be hardcoded in, forcing users to re-download the CLI every time a new language is added, and also not allowing people to provide support for their own language of choice.
Proposed solution
Implement the language helpers as a docker image-based plugin, downloaded/run upon calling fn init or fn build. This has a number of benefits:

New languages can be added without updates to the CLI source.
Users can provide support for their own languages.
Language support can be written in any language (no need for contributors to learn Go!)
Users can add support for a language for personal use without needing the blessing of the Fn team.
Slightly simplifies the CLI codebase (both init.go and common.go will become slightly less complex, and the langs directory is entirely removed.

Details
Currently the plan is as follows:

Each LangHelper now takes the form of a docker image.
When fn init or fn build is called, the CLI will run the container from that image, and retrieve the information required as a JSON encoded struct.
The container will also produce any side effects produced as necessary (boilerplate generation, and prebuild stages
The CLI will ascertain which docker image is required in one of two ways. Either, the --runtime flag (or the runtime field in the func.yaml will directly refer to a docker image, in which case that image will be pulled from Dockerhub - this is what allows users to use non-official images for their projects.
If the --runtime flag does not refer to a docker image (i.e. it does not contain a /), then the image name required is decided dynamically using a naming convention that is yet to be completely decided, but something akin to fnproject/fn-langhelper-$RUNTIME:latest.

Progress
I have begun work on this already, and am approaching a presentable proof of concept in the form of a docker plugin for the java LangHelper; discussion and feedback is greatly welcomed.
tl;dr
To provide an easy, flexible, and pluggable way for developers and users to add support for a given language, without updating the CLI source code.

related to https://github.com/fnproject/fn/issues/135

👊 Bump

@hibooboo2  This work/branch is currently on hold - what are you proposing exactly? Not exactly clear how the serverless integration dictates things here?

Was hoping to separate language helpers from the cli so that they could be used by serverless. After our convo, seems better to leave as is and just dup for now. So will go that route.


Create scrollable playlist (->queue 2 etc.)

This is just a suggestion, it's not really needed but it's useful in finding where the song you want is ;3

Well, it's deffinetly not impossible, we'll look into it.

i web ui would make this easier

@BrennanFlory It depends because even if Web UI would allow non-ranked users to utilize the service, it doesn't mean they will go and look at it.

Web UI is temporarily discontinued, and it shouldn't be hard to make the pagination, I'll try to do it for next build 👍


recent_view: Show checkbox icon for unread filter.

discussion: https://chat.zulip.org/#narrow/stream/9-issues/topic/Recent.20conversations.20unread.20filter
I accidentally removed the filter_unread parameter passed to the template.

Merged, thanks @amanagr!


ChangeNotifier should get method removeListeners()

Use case
The ChangeNotifier allows for removing listeners by providing exactly the reference to the added listeners.
This makes it a little complicated, if one would simply remove all listeners, for instance within dispose() when leaving a view.
I had to write this much code to add and remove listeners to/from the view when entering/leaving the view:
  //current up- and downloads
  List<Transfer> _transfers;

  //map of added listeners
  //objects of type Transfer have a field 'info' that is a ValueNotifier (extends ChangeNotifier)
  Map<Transfer, Function> listeners = {};

  @override
  void initState() {
    super.initState();
    _transfers = transferService.getCurrentTransfers();
    _transfers.forEach((t) {
      _registerListener(t);
    });
  }

  @override
  void dispose() {
    listeners.entries.forEach((element) {
      element.key.info.removeListener(element.value);
    });
    super.dispose();
  }

  void _registerListener(Transfer t) {
    Function f = () => () {
      //code that runs when ChangeNotifier fires
    };
    listeners.addEntries([MapEntry(t,f)]);
    t.info.addListener(f);
  }

Proposal
If ChangeNotifier had a removeListeners() function, that simply removes all previously added listeners, people would not need to keep track of the added listeners to be able to remove them all.
Unfortunately it's not an option to extend ValueNotifier or ChangeNotifier since the _listeners field is private there.

You can just call dispose on a ValueListener or ChangeNotifier. That removes all its listeners and disposes the object.
Adding a method that just removes all listeners unquestioned seems dangerous if you don't own the object. Somebody else may have added a listener and doesn't expect it to get removed.
I don't think we should do this. The code you have to write to enable this isn't that complicated and you could easily encapsulate it in a separate class.

You can just call dispose on a ValueListener or ChangeNotifier. That removes all its listeners and disposes the object.
No, @goderbauer  unfortunately that's not the possible. I tried it. When calling dispose() on a ValueNotifier before leaving the view the following exception occurs:

Exception has occurred. DioError (DioError [DioErrorType.DEFAULT]: A ValueNotifier<TransferInfo> was used after being disposed. Once you have called dispose() on a ValueNotifier<TransferInfo>, it can no longer be used. #0      ChangeNotifier._debugAssertNotDisposed.<anonymous closure> (package:flutter/src/foundation/change_notifier.dart:106:9) #1      ChangeNotifier._debugAssertNotDisposed (package:flutter/src/foundation/change_notifier.dart:112:6) #2      ChangeNotifier.notifyListeners (package:flutter/src/foundation/change_notifier.dart:201:12) #3      ValueNotifier.value= (package:flutter/src/foundation/change_notifier.dart:274:5)
This is probably due to the fact, that dispose() on the ChangeNotifier just nulls the list of _listeners:
 /// Discards any resources used by the object. After this is called, the
  /// object is not in a usable state and should be discarded (calls to
  /// [addListener] and [removeListener] will throw after the object is
  /// disposed).
  ///
  /// This method should only be called by the object's owner.
  @mustCallSuper
  void dispose() {
    assert(_debugAssertNotDisposed());
    _listeners = null;
  }

By the way, this method's description tells me, that I cannot use it, if there is still a ValueNotifier in the wild..
So, would it be an option to change ChangeNotifier's dispose() method like as follows?
  @mustCallSuper
  void dispose() {
    assert(_debugAssertNotDisposed());
    _listeners.forEach((element) {
      _listeners.remove(element)
    })
  }

Since I put some work into reporting this issue and offering a solution, could you please at least comment @goderbauer?

I don't think dispose needs to be changed. The whole point of dispose is to disable the object so it can no longer be used. The thing that registers a listener is responsible for removing it. I don't see what's wrong with writing the code to just remove all listeners.


Button: the disabled attribute doesn't apply to the button element

Steps
Create a Button component with disabled set to true.
Expected Result
The button should be disabled.
Actual Result
The button only has styles to make it appear disabled, but it still functions if you tab to it due to a missing disabled attribute on the button element.
Version
0.68.3
Testcase
https://codepen.io/anon/pen/OgbeXr

As I see, disabled button doesn't receive focus due negative tabIndex, however HTML's button tag can have a disabled attr. I think, that we need to pass disabled prop if an element is button:
<Button disabled />
<Button as='div' disabled />

<button class="ui disabled button" disabled></button>

Yes exactly, however the tab index isn't applied when you use it inside a FormButton. Maybe that is a separate issue, but in this case it means that inside a form it allows submission when the button is disabled by tabbing.

A further issue is that the disabled prop is stripped from the props as it is a handled prop of Button. How do you handle these cases when there is a prop that is both handled, but should also be passed through?

I think we can do there something like this:
const disabledButton = disabled && ElementType === 'button'

<ElementType {...rest} className={classes} disabled={disabledButton} onClick={this.handleClick} ref={this.handleRef} tabIndex={tabIndex}>
// ...
</ElementType>

However, it's quite ugly solution because Button's render has already too many conditions. Open for better ideas.

It seems quite bad to treat the button different to other semantic components. Elsewhere this is handled by splitting the props to get the unhandled props and then spreading them onto the child component. I think the solution should take that into account.

Thanks a lot for fixing, much appreciated


Request for DistributedDataParallel

To allow for the training of larger models split across GPUS using the DefaultTrainer class, implement model parallel capabilities using the torch.DistributedDataParallel functionality.

Thanks for opening this @sladenheim. We are currently focusing on a new release of micro_sam, but will then look into this.

We support distributed training now via https://github.com/constantinpape/torch-em/blob/376247b8745768de205cd2bc9f681fa1b22ad28f/torch_em/multi_gpu_training.py .
We should document this, I will open up a follow up issue.


Scroll to issue

Hello, first of all thanks for such great tool. I faced with issue when scroll to id feature won't work.
Here is example of the header.
## Not working scroll to / example

Fixed via 9b4e6669dbf454ea17ee42331487825475130d40


Add OGN buyback contract

Deploys a simple buyback contract that swaps OUSD for OGN via Uniswap. The buyback contract replaces the trustee and the swap function is called as part of allocate. Some design decisions I made:

Non upgradeable, has a hardcoded Uniswap path and hardcoded threshold for swap amounts
Only swap if buyback has > 1000 OUSD

Contract change checklist:

[ ] Code reviewed by 2 reviewers. See template and example.
[x] Unit tests pass
[x] Slither tests pass with no warning
[ ] Echidna tests pass if PR includes changes to OUSD contract (not automated, run manually on local)

FYI - I'm starting to gather the list of contracts to include when we do our next mainnet deploy so that I can iron out all the deploy scripts involved. Trying to target end of this week.

Ah also, there is a test failure which seems related to this PR. Let's fix it before merging.

I fixed the slither error. Not sure about that timeout, but seems to be unrelated to this. I'll keep pressing retry till it goes green!


fix: get commands options and description from new package

Summary
Fixes https://github.com/callstack/repack/issues/473. With React Native 0.73, we've migrated start and bundle command to Core. So right now when resolving path to CLI and trying to require these commands from CLI, script will fail. In this PR I changed the require.resolve to look into new package, where these commands are living right now.
Test plan

Create new React Native app with npx react-native@latest init app
Init Re.Pack with npx @callstack/reapck-init
Apply changes from this PR
npx react-native config should be executed correctly.

@szymonrybczak is this still compatible with previous versions? We need to ensure compatibility with at least last 3 versions of RN (0.71, 0.72, 0.73)

With the backwards compatibility it looks great, thanks!

I tested this change by react-native@73, but there is a problem when I build android, main js doesn't compile with repack,
webpack.config.js never run

Suggestsions applied, should be good now! 🙌


Split view - many results

When there are many results, split view takes a lot of time to load.
Web should change the control to have paging.

Pagination added to table control #106


Use a deterministic parameter instead of a random value for debug urls.

jawr.debug.use.random.parameter adds a random value to urls, using a value computed from the hash of the content or the last modified time would help in development to preserve breakpoints while still keeping content up to date.

Hi
We could use the last modified time but I'm not sure that this attribute is properly kept during war deployment, and for the use of both (last modified date + the hash of the content), this could slow down the generation of the URL a little bit.
When developing, I generally set this parameter to false and disable cache in my browser.
Would this workaround fix your issue?
Cheers,

Either method would definitely slow down generation of the URL and there are certainly workarounds. This is definitely a feature request and if I really want it I should probably take a hack at it myself :)
The source of my irritation comes from the way the grails plugin and tag lib for <jawr:script /> default to useRandomParam whenever debug mode is on, you must explicitly turn it off at the script level (it never actually looks at this property: jawr.debug.use.random.parameter)
See: https://github.com/ic3fox/jawr-main-repo/blob/fbc3157cdb3de990d7e7ae0b42d88953065577e1/jawr-grails/jawr-grails-plugin/grails-app/taglib/JawrTagLib.groovy

Hi
The fact that the property jawr.debug.use.random.parameter is not properly handled in the jawrTagLib is an issue.
The JIRA JAWR-338! has been created to fix this issue.
Cheers

Thank you!

Hi,
This issue has been fixed in the master branch.
This fix will be part of the next release.
Cheers,

That's some seriously fast turn around, thank you!


Delay in managedCluster status update

I have a managed cluster configured with a heartbeat of 60 seconds:
% oc get -o yaml managedcluster cluster1 | grep lease
  leaseDurationSeconds: 60

However, when I scale down the klusterlet-registration-agent in the managed cluster it takes almost 5 minutes for the cluster to be reported with Unknown availability:
% k scale deployment.apps/klusterlet-registration-agent --replicas 0
deployment.apps/klusterlet-registration-agent scaled
% time cat
cat  0.00s user 0.00s system 0% cpu 4:42.50 total

On the opposite, only 5/6 seconds for the cluster to be reported as Available when scaling up the agent:
% k scale deployment.apps/klusterlet-registration-agent --replicas 1
deployment.apps/klusterlet-registration-agent scaled
% time cat
cat  0.00s user 0.00s system 0% cpu 6.344 total

I would have expected a smaller time since the heartbeat is configured to 60 seconds.
Notes:

Both environments are kind clusters configured as per the Quick Start guide
Setting leaseDurationSeconds to a lower value (i.e.: 1 or 5 seconds) does not change the outcome

Logs from the hub cluster-manager-registration-controller:
I1204 12:27:21.129691       1 event.go:285] Event(v1.ObjectReference{Kind:"Namespace", Namespace:"open-cluster-management-hub", Name:"open-cluster-management-hub", UID:"", APIVersion:"v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'ManagedClusterAvailableConditionUpdated' update managed cluster "cluster1" available condition to unknown, due to its lease is not updated constantly
I1204 12:27:21.185928       1 event.go:285] Event(v1.ObjectReference{Kind:"Namespace", Namespace:"open-cluster-management-hub", Name:"open-cluster-management-hub", UID:"", APIVersion:"v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'ManagedClusterConditionAvailableUpdated' Update the original taints to the [{Key:cluster.open-cluster-management.io/unreachable Value: Effect:NoSelect TimeAdded:0001-01-01 00:00:00 +0000 UTC}]
I1204 12:30:29.673784       1 event.go:285] Event(v1.ObjectReference{Kind:"Namespace", Namespace:"open-cluster-management-hub", Name:"open-cluster-management-hub", UID:"", APIVersion:"v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'ManagedClusterConditionAvailableUpdated' Update the original taints to the []

I am guessing the lease is being refreshed every 60 seconds but the hub that checks the lease is still on a 5 mins interval.
CC @qiujian16 @deads2k

/assign @skeeey

@josecastillolema
A managed cluster has a grace period for its unknown status, the grace period is leaseDurationSeconds x 5,  so when the managed cluster stop to update its lease, by default, the cluster will become unknown after 5mins (the default leaseDurationSeconds is 60s), the grace period will help to tolerate some unexpected situations, e.g. the network latency, and once the managed cluster recover to update its lease, we expect the managed cluster become available immediately
And we support to reduce the leaseDurationSeconds to reduce the grace period (like you did), but unfortunately, there is a bug in current implement, I will fix it
thanks

Thanks for the quick response!


Fix use merging not using the first path segment

Finally figured out why nested imports don't properly merge in some cases

bors r+


Could not load file or assembly 'System.IdentityModel Version=<IP_ADDRESS>

I'm trying to connect to Office365 environment through Powershell Core but seems to missing some Assembly libraries
I've installed Powershell core through Microsoft's Linux repository:
https://packages.microsoft.com/config/rhel/7/prod.repo

Steps to reproduce
$username = 'foobar@domain'
$password = ConvertTo-SecureString -String 'XXXXXX' -AsPlainText -Force
Import-Module MSOnline
$credential = New-Object System.Management.Automation.PSCredential $username, $password
$session = New-PSSession -ConfigurationName Microsoft.Exchange -ConnectionUri https://outlook.office365.com/powershell-liveid -Credential $credential -Authentication Basic -AllowRedirection
Import-PSSession $session
Connect-MsolService -Credential $credential
Get-MsolUser -UserPrincipalName USRLOGIN@domain | Format-List UserPrincipalName

Expected behavior
This connection and Get-MsolUser must to happen

Actual behavior
Connect-MsolService -Credential $credential command results:
Connect-MsolService : Could not load file or assembly 'System.IdentityModel, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089'. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
At line:1 char:1
+ Connect-MsolService -Credential $credential
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : NotSpecified: (Microsoft.Online.Ad\u2026.ConnectMsolService:ConnectMsolService) [Connect-MsolService], FileLoadException
+ FullyQualifiedErrorId : System.IO.FileLoadException: Could not load file or assembly 'System.IdentityModel, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089'. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
File name: 'System.IdentityModel, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089' ---> System.IO.FileLoadException: The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
   at Microsoft.Online.Administration.Automation.ConnectMsolService.MsolCmdletProcessRecord()
   at Microsoft.Online.Administration.Automation.MsolCmdlet.ProcessRecord()
,Microsoft.Online.Administration.Automation.ConnectMsolService

Connect-MsolService : Could not load file or assembly 'System.IdentityModel, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089'. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
At line:1 char:1
+ Connect-MsolService -Credential $credential
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : NotSpecified: (:) [Connect-MsolService], FileLoadException
+ FullyQualifiedErrorId : System.IO.FileLoadException,Microsoft.Online.Administration.Automation.ConnectMsolService

Environment data
PowerShell 6.2.3

Linux CentOs 7 - 3.10.0-957.27.2.el7.x86_64

System.IdentityModel is not part of CoreFx so it can't be used with PSCore.  https://github.com/dotnet/corefx/issues/12623


Update syntax

all of these example got syntax error . How can I run on new version of Proverif Online ?

Did you get any code for the new version?


use pretrained weights from Swin transformer

Hi, did you used pretrained weights from Swin transformer?
Could you please share your training files that we understand about this?
Which type of Swin transformer (large, small,...) did you use for training?
@JingyunLiang

No, the model is trained from scratch. See https://github.com/cszn/KAIR/blob/master/docs/README_SwinIR.md for training codes.

No, the model is trained from scratch. See https://github.com/cszn/KAIR/blob/master/docs/README_SwinIR.md for training codes.

It is possible to use pretrained weights?
Why you didn't share train.py file?

The architecture is different. Besides, there is no much meaning to use weights pretrained on classfication.
The train.py is provided. Please refer to the Readme.


thellier_gui.py doesn't save MagIC tables as expected

What command was run:
thellier_gui.py
What happened:
I ran the auto-interpreter with a specified criteria.txt file and saved the MagIC tables.  They were not the same as the tables in the thellier-interpreter, which are correct.
What I expected to happen:
I expected the two to be the same
archaeomag_test_file.zip
Data file(s):
Screenshot(s):
PmagPy version:

my bad.  this is working


GetEnterpriseRunner method appears to be missing

The docs describe the following api https://docs.github.com/en/enterprise-server@3.10/rest/actions/self-hosted-runners?apiVersion=2022-11-28#get-a-self-hosted-runner-for-an-enterprise
however the EnterpriseService does not appear to have a corresponding method https://github.com/google/go-github/blob/master/github/enterprise_actions_runners.go
Happy to raise a PR to add this capability

Thank you, @matt-simons!


Some doc fixes

While reading the docs I stumbled upon some missing words or "broken" sentences (maybe refactoring artifacts) so I fixed some things.
Unfortunately I wasn't able to generate the documentation and see if things work as expected since doc/settings.el is missing.
(btw: there are some documents -- e.g. design.org -- which aren't in use. Is that intentional?)

Excellent!  Thanks for catching and enhancing these!
The design.org is more of an internal document that is not published.
The doc/settings.el is generated by my local environment setup and is designed to allow additional load-paths to be specified if needed.  It should be fine if it's missing: thanks for pointing this out and I'll make some updates to allow for this case.

Excellent!  Thanks for catching and enhancing these!
The design.org is more of an internal document that is not published.
The doc/settings.el is generated by my local environment setup and is designed to allow additional load-paths to be specified if needed.  It should be fine if it's missing: thanks for pointing this out and I'll make some updates to allow for this case.


Format: remove help text

Remove the phrase "Dublin Core format value"
Some formats will not appear on this list. Can this be adjusted to allow values outside of the list?

Remove dropdown, replace with select2 maybe?


Allow testutil.GetFakeClient to take build options

In the current implementation, when used externally, the fake client cannot be futher configured with extra objects, or options, like setting WithStatusSubresource when patching objects with a status subresource.

/assign @pwittrock @ehashman


Review Mockito for Unit Testing

Increase the project testability

https://site.mockito.org/
https://github.com/marcingrzejszczak/mockito-cookbook
https://www.baeldung.com/mockito-annotations

https://www.baeldung.com/mockito-annotations

Using current implementation with TestContainers, everything goes fine.


Feature Request: show latency per I/O in verbose mode

It would be nice to have verbose mode also list the latency for an I/O.

-L produces the latency distribution. What are you looking for?
If you want per-IO tracing, taking a wpr trace of the run would provide that.

Right, a WPR trace would provide that info, but only after the run. I just would find it handy to have IO stats listed while running. It’s not a big issue, just a nice to have.
From: Dan Lovinger<EMAIL_ADDRESS>Reply-To: microsoft/diskspd<EMAIL_ADDRESS>Date: Thursday, 16 May 2019 at 20:29
To: microsoft/diskspd<EMAIL_ADDRESS>Cc: Rob Scheepens<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [microsoft/diskspd] Feature Request: show latency per I/O in verbose mode (#98)
-L produces the latency distribution. What are you looking for?
If you want per-IO tracing, taking a wpr trace of the run would provide that.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub [github.com]https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_microsoft_diskspd_issues_98-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DADZMNMD6DYOIF4K42FMJFWDPVWRYRA5CNFSM4HLZGXC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVSVT6I-23issuecomment-2D493181433&d=DwMCaQ&c=s883GpUCOChKOHiocYtGcg&r=OMged-t_5I_fmfpUaT3vaA06lgLL_alYnDQJxHmXz64&m=czqWzeNmr8iMGIeO45FPmabIppfz6sASDW_IgNYgFA4&s=qATHDtzPzmORl2rrNQpedIyfqfNmno6dfgVwf8k-n64&e=, or mute the thread [github.com]https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ADZMNMBT3WS2UFOX64TZVB3PVWRYRANCNFSM4HLZGXCQ&d=DwMCaQ&c=s883GpUCOChKOHiocYtGcg&r=OMged-t_5I_fmfpUaT3vaA06lgLL_alYnDQJxHmXz64&m=czqWzeNmr8iMGIeO45FPmabIppfz6sASDW_IgNYgFA4&s=oroYp36LfACaqjKsTt6Y4l9H88XFm8QxgbL0HIoUnJE&e=.

I can't think of many situations where actual per-IO stats on stdout wouldn't be overwhelming.
Running per-second/interval aggregates like interval IOPS, average latency, etc. would have some utility and been considered before. There's nothing in the way of that except someone able to contribute, with sufficient time.


Fixes for Sigma RPC functions

Fixes issues with RPC tests failing for certain Sigma RPC functions
Fixes the following error msg showing in debug.log:

ERROR: CheckZerocoinTransaction :  invalid denomination value, unable to convert to integer

Fixes GUI out-of-sync issues with mints.

This pull request introduces 1 alert and fixes 1 when merging 14a68c3ec3164a91fa2862f823e400ea830e795b into db3756cb08832f45032fec6c42b3700e1fa7ed6f - view on LGTM.com
new alerts:

1 for 'import *' may pollute namespace

fixed alerts:

1 for Syntax error

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

Does this also fix the intermittent lag issues?

This pull request introduces 1 alert and fixes 1 when merging b494a55bba540a0be1ec41a31251011cd313144c into 7b0f6a7f47e2f84cd6ba0b9761946374d63b635f - view on LGTM.com
new alerts:

1 for 'import *' may pollute namespace

fixed alerts:

1 for Syntax error

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

This pull request introduces 1 alert and fixes 1 when merging 624858bdd893a8d089ce294afa902ec43d1c3bdb into 7b0f6a7f47e2f84cd6ba0b9761946374d63b635f - view on LGTM.com
new alerts:

1 for 'import *' may pollute namespace

fixed alerts:

1 for Syntax error

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

This pull request introduces 1 alert and fixes 1 when merging 97b755a1f92ae6f59793281a2e46c55f80db61de into 7b0f6a7f47e2f84cd6ba0b9761946374d63b635f - view on LGTM.com
new alerts:

1 for 'import *' may pollute namespace

fixed alerts:

1 for Syntax error

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com


Tiff rendition to use same compression as source image, if any

Description
By default, imagemagick generates lossless tiff files. Unfortunately those files are hug. This PR introduces the use of (lossless) compression for tiff files.
Fixes a bug discovered during another review.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Failing IT tests is another occurrence of NUI-878.

@alexkli
Actually it wasn't a mistake. I generated those JPEGs from the PNG example, in order to control the quality levels (this influences compression). But I can update the tests and use the file in the root. I will check the changes regarding the usefulness of the tests beforehand, though. I might even use totally different files so we actually (at least) see a notable size difference if compression is not working as expected.

So, I changed tests to do a png -> tiff conversion.
PNG is compressed using zlib, and with the current code, the tiff rendition is requested to use the same compression. With the change, the tif rendition has a small size (<200KB), but if ran without the change to request compression, it explodes to >3MB of size.

note 2: Why is this not a breaking change?
Previously, some setting ensured tiff files were compressed using a lossless algorithm. That setting was lost[1] with the update to use a custom imagemagick build. This code change is to restore the behavior[2], moving it to a visible setting in the code.
[1] The imagemagick config files before/after using the custom build are the same. Note that tests using perceptual comparison to validate the rendition will not detect size changes.
[2] Besides the exception of one worker, other workers capable of generating tiff files as renditions are not impacted by the change, as they continue to use their own code instead of imagemagick.

@alexkli I'll wait for your greenlight to merge.

To be merged after https://github.com/adobe/asset-compute-sdk/pull/66.


SAK-30031: Send bug reports email in server language rather than affected user's language

+1 Seems smart to me


CGP-40: Make python installation directory during build

Following on form Ulrik's review on https://github.com/dls-controls/dls_ade/pull/55, this adds the Python install directory so that module mainters don't have to add it to there builds on RHEL7.

Coverage remained the same at 88.107% when pulling e9c61903b8fd1febdbed8d16848a7c58d1f3f0e4 on CGP-40 into d244815c540703162f7ae3750f25d5cf2fa775c5 on master.


Classify func unused

Hi,
Thanks for making this SOM implementation. Just wondering why you never used the classify function to do the Euclidean distance? Or have I missed something.
I am fairly new to Scala so have not noticed whether you actually used it.

Hi @codeninja55,
I'm glad that you're interested in using the SOM. Seems that I missed to write a test for that so that people can actually see how to use it. I just wrote a short hint on the README. Sorry for that.
However, classify is a method a user might call on a fitted SOM instance to identify a best matching unit (BMU) to an unseen data point. There is no point (at least I could think of) in using this method within the library itself.
Hope that helps.
Just let me know if you have any further questions. Please note that it could take a couple of days for you to get an answer.


Upgrade System.Metadata.Reflection and System.Collections.Immutable to latest versions

cc @hoyMS

@dotnet-bot test this please

@dotnet-bot test this please

@dotnet-bot test this please

@jkotas This is breaking the desktop project (System.Collections.Immutable NuGet versioning). Do you mind if I roll this back?

Sorry about that. Yes, roll it back please.


gitlab-runner: 16.2.1 -> 16.3.0

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Requesting in advance that this is backported to nixos-23.05 once merged and cleared on master.

Result of nixpkgs-review pr 250521 run on x86_64-linux 1

1 package built:

gitlab-runner


Prevent project shutdown on watch mode

Hi, I've just discovered this package and I was surprised on how fast it was 🚀
Unfortunately I tried using it on watch mode, but the program kept ending on any file change (apparently someone else has already noticed the same issue #45 )
So... this is my shot into fixing it 🐞
Issue
In order to react to changes in our files, the watcher triggers a change event, that in turn triggers a project reload.
This project reload forces a supervisor restart, that in the code is implemented by killing the current process and creating a new one.
https://github.com/gadget-inc/wds/blob/f89b208082eefb9b0977b6a32abdd65f9ee266fc/src/Supervisor.ts#L32-L46
This process exit is caught in the supervisor exit event, but it's only prevented for the supervise mode  case.
https://github.com/gadget-inc/wds/blob/f89b208082eefb9b0977b6a32abdd65f9ee266fc/src/index.ts#L172-L177
Possible solution
My proposed solution is to add the missing reload on changes mode case, preventing to kill our 'project' on any file change.
Images
Running original file (watch mode is enabled by default)

Modifying and saving changes to file

Previously the program would just end, like in the logs of #45

Ah, thanks for the PR! I think I've always just run with wds --watch --supervise to turn on both bits of behaviour! I agree though that it isn't very useful to turn on --watch without also turning on the supervise behaviour -- you told wds you wanted it to watch and that you're gonna make changes, seems silly it would just quit! What do you think about making the --watch flag imply the --supervise flag, documenting it like that and fixing the issue at a higher level when doing argparsing? Also curious what @gmalette thinks

I've so far considered --watch to be fs-related, and --supervise to be essentially keep-alive, but that's perhaps the wrong way to think about it.
Given the role of wds, I can't think of a reason you'd want --supervise without --watch. Why keep the process alive, but not reload it with the changed code, except if it exited by itself and/or crashed?
I have used --watch without supervise to let the process die, when booting the process caused a significant amount of logs, making it hard to find the breakage.
Unless there's compelling arguments to keep --supervise, I think I'd be in favour of:

Getting rid of --supervise
--watch by default also keeps the project alive if the child process exits
Add a flag to --watch that allows the process to die

Given that my usage of --watch without --supervise may be a special case, I'd also be open to deferring (3).

Okay, I've removed supervise mode

Add a flag to --watch that allows the process to die

I think--no-watch already does this, is that what you meant?

@airhorns can you publish a new version pls?

There's a subtle difference for long-running processes that don't automatically end. With only --watch changing its files will cause it to be reloaded. However, if it crashes (or exits normally for that matter), previously to this PR it would not have been restarted.

Got it. I also noticed the tests keep running infinitely, it's probably because, as you say, now the process doesn't end
https://github.com/gadget-inc/wds/runs/7234432137


[Snyk] Upgrade @stytch/stytch-js from 0.2.0 to 0.2.1

Snyk has created this PR to upgrade @stytch/stytch-js from 0.2.0 to 0.2.1.

:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 21 days ago, on 2021-02-02.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

stytch already upgraded


(URGENT) BIPM outcomes still rendered in short format

How do we use the long format?

But the French outcomes are correct. Only the English ones are wrong.

This is looking like a real bug with the English/French citation style discrepancy.

Wait... only collection_en.pdf shows the English Short citation format. Let me verify. This is strange.

Actually I updated metanorma-bipm to the latest Git version, and this issue is gone. Thank you!


Rune count in string

Codecov Report

Merging #64 into master will increase coverage by 0.5%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master      #64     +/-   ##
=========================================
+ Coverage   91.06%   91.56%   +0.5%
=========================================
  Files          36       35      -1
  Lines        4264     4256      -8
=========================================
+ Hits         3883     3897     +14
+ Misses        259      237     -22
  Partials      122      122

Thanks!


Username must be small case

Description
As we know that fetching data from firebase is case sensitive so having username in capital letter could lead to problem further if we add username fetching also in the search bar. So, I think we should not let the user to use capital letter in their username.
I want to alter this on edit profile and also on the signup page.
Steps to reproduce
Try to edit your profile
You will see the you can also add uppercase letters in username.
Screenshots
No response
Desktop (please complete the following information)
No response
Smartphone (please complete the following information)
No response
Additional information
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I have checked the existing issues
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

Hi @Palakkgoyal let's add all the validations as required in any username we pick anywhere, like consisting of only small letter,maybe hyphen/underscore,number and no special character. What do you think? you may chose any of those options to improve the username validation :)

The username can only consist of alphabets, number and underscore. Is there anything else you would like to add?

The username can only consist of alphabets, number and underscore. Is there anything else you would like to add?

nah, that's fine and let them be a maximum length of perhaps 20?

Yes, that would be ok. And also can I change the minimum length of displayName as it is 6 and its long for my name and might be for other that. Due to this I have to write my Palakg or Palak goyal XD

Yes, that would be ok. And also can I change the minimum length of displayName as it is 6 and its long for my name and might be for other as well. Due to this I have to write my Palakg or Palak goyal XD

ohho correct! UX must be taken care of!


Energy Distribution Options

New to Home Assistant and hoping there is something I have missed in the install/config. The energy distribution isn't displaying correctly (when compared to the native app iSolarCloud). As far as I can see I am missing an option for Grid Consumption in the Energy Configuration Section.
I have a SG8K but am using the SG5K as suggested here.

What I was comparing to at the time (iSolarCloud)

See a resolution in another issue


DEBUG    Starting container with command: docker exec -i
         test-container-this-is-a-random-string /bin/bash -l
INFO     🌱 Environment Initialized
DEBUG    Environment initialization took 1.43 seconds
INFO     Installing __tmp__pytest-of-runner__pytest-0__swe-agent-test-repo at
         base commit...
ERROR    Install command failed to execute successfully: error: No Python
         interpreters found in virtual environments
INFO     Beginning environment shutdown...
INFO     Agent container paused
INFO     Beginning environment shutdown...
WARNING  Failed to pause container.
         Traceback (most recent call last):
           File "/home/runner/work/SWE-agent/SWE-agent/tests/test_env.py", line
         48, in swe_env_context
             yield env
           File "/home/runner/work/SWE-agent/SWE-agent/tests/test_env.py", line
         140, in test_execute_environment_clone_python_uv
             env.reset()
           File
         "/home/runner/work/SWE-agent/SWE-agent/sweagent/environment/swe_env.py"
         , line 371, in reset
             self.install_env()
           File
         "/home/runner/work/SWE-agent/SWE-agent/sweagent/environment/swe_env.py"
         , line 979, in install_env
             self.communicate_with_handling(
           File
         "/home/runner/work/SWE-agent/SWE-agent/sweagent/environment/swe_env.py"
         , line 739, in communicate_with_handling
             raise RuntimeError(msg)
         RuntimeError: Install command failed to execute successfully: error: No
         Python interpreters found in virtual environments

         During handling of the above exception, another exception occurred:

         Traceback (most recent call last):
           File
         "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/doc
         ker/api/client.py", line 275, in _raise_for_status
             response.raise_for_status()
           File
         "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/req
         uests/models.py", line 1024, in raise_for_status
             raise HTTPError(http_error_msg, response=self)
         requests.exceptions.HTTPError: 409 Client Error: Conflict for url:
         http+docker://localhost/v1.43/containers/14f3254c509a38706f263bf5e713ff
         87dbf22805fe8466159b7626241781e21d/pause

         The above exception was the direct cause of the following exception:

         Traceback (most recent call last):
           File
         "/home/runner/work/SWE-agent/SWE-agent/sweagent/environment/swe_env.py"
         , line 506, in close
             self.container_obj.pause()
           File
         "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/doc
         ker/models/containers.py", line 332, in pause
             return self.client.api.pause(self.id)
           File
         "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/doc
         ker/utils/decorators.py", line 19, in wrapped
             return f(self, resource_id, *args, **kwargs)
           File
         "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/doc
         ker/api/container.py", line 917, in pause
             self._raise_for_status(res)
           File
         "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/doc
         ker/api/client.py", line 277, in _raise_for_status
             raise create_api_error_from_http_exception(e) from e
           File
         "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/doc
         ker/errors.py", line 39, in create_api_error_from_http_exception
             raise cls(e, response=response, explanation=explanation) from e
         docker.errors.APIError: 409 Client Error for
         http+docker://localhost/v1.43/containers/14f3254c509a38706f263bf5e713ff
         87dbf22805fe8466159b7626241781e21d/pause: Conflict ("Container
         14f3254c509a38706f263bf5e713ff87dbf22805fe8466159b7626241781e21d is
         already paused")

The reason that
if self.container_obj.status not in {"paused", "exited"}:

doesn't work is that self.container_obj.status apparently doesn't get updated after the initialization:
x = _get_persistent_container("coa1", "sweagent/swe-agent:latest")
client = docker.from_env()
co = client.containers.get("coa1")
co.status
# running
co.pause()
# let's wait a bit
co.status
# still running


Does this project format doctests?

I have a number of doctests embedded in normal docstrings (i.e. these aren't formatted in a special way, like with Markdown)--I'm wondering if this project is intended to format these tests? In brief testing, it doesn't seem like blacken-docs picks up the doctests.

it does not yet, see #8


Make dune build -p not require ppx_expect

$ dune build -p ocluster
File "test/dune", line 22, characters 19-29:
22 |   (preprocess (pps ppx_expect))
                        ^^^^^^^^^^
Error: Library "ppx_expect" not found.

though it should be a just test dependency

well the issue currently is that it is not a test dependency:
$ dune build @install
File "test/dune", line 22, characters 19-29:
22 |   (preprocess (pps ppx_expect))
                        ^^^^^^^^^^
Error: Library "ppx_expect" not found.
Hint: try:
  dune external-lib-deps --missing @install

Removing this makes the API depend on the tests, which is not good.

Are you sure? dune build -p ocluster-api works fine with this PR and without ppx_expect.

It's not just me. With your change, the CI is failing with:
current_ocluster.opam: changes needed:
  "capnp-rpc-lwt" {with-test & >= "1.2"}   [from scheduler]
  "capnp-rpc-net" {with-test & >= "1.2"}   [from scheduler]
  "lwt-dllist" {with-test & >= "1.0.1"}    [from scheduler]
  "ppx_expect" {with-test & >= "v0.14.1"}  [from test]
  "prometheus-app" {with-test & >= "1.1"}  [from test]
  "psq" {with-test & >= "0.2.0"}           [from scheduler]
  "sqlite3" {with-test & >= "5.0.3"}       [from db]
ocluster-api.opam: changes needed:
  "capnp-rpc-net" {with-test & >= "1.2"}   [from scheduler]
  "fmt" {with-test}                        [from db, test] (missing {with-test} annotation)
  "logs" {with-test & >= "0.7.0"}          [from scheduler, test]
  "lwt" {with-test}                        [from scheduler, test] (missing {with-test} annotation)
  "lwt-dllist" {with-test & >= "1.0.1"}    [from scheduler]
  "ppx_expect" {with-test & >= "v0.14.1"}  [from test]
  "prometheus" {with-test & >= "1.1"}      [from scheduler]
  "prometheus-app" {with-test & >= "1.1"}  [from test]
  "psq" {with-test & >= "0.2.0"}           [from scheduler]
  "sqlite3" {with-test & >= "5.0.3"}       [from db]
ocluster.opam: changes needed:
  "ppx_expect" {with-test}                 [from test] (missing {with-test} annotation)

This is because your change makes everything depend on the tests, which is not good.
But I don't understand how you don't have ppx_expect, when it's listed as a dependency in ocluster.opam.

ok then, closing. Hopefully dune can fix that at some point in the future.


Idiom for capturing the body of a failed client response

We added expect as a way to decode successful responses to expected types.  This captures the status code in an exception, but does not capture the response for troubleshooting.  We can't naively return Task.fail(response), because we need to release the HTTP connection from which the body would be read.
I've seen two idioms for this at work.  There may be more in the community.  Is there a sensible API we're missing to help people avoid reinventing this, or does one size not fit all?

Made this easier with #1668.


Remove trailing whitespace

Some editors are set to highlight trailing whitespace as an error.

Superseded by #11.


feat: Onboard the COVID-19 Google Mobility (EU) dataset

Onboard pipelines:

datasets/covid19_google_mobility_eu/mobility_report

Based on #
Note: It's recommended to open an issue first for context and discussion.
Checklist
Note: Delete items below that aren't applicable to your pull request.

[x] Please merge this PR for me once it is approved.
[x] If this PR adds or edits a dataset or pipeline, it was reviewed and approved by the Google Cloud Public Datasets team beforehand.
[x] If this PR adds or edits a dataset or pipeline, I put all my code inside  datasets/covid19_google_mobility_eu and nothing outside of that directory.
[x] This PR is appropriately labeled.

Closing due to the dataset having ended support.


Using go:embed

What this PR does / why we need it:
This PR is to propose using embed to move files from strings to actual files. The contents are loaded at compile time, so we shouldn't have lower performance. It actually can improve performance in some places that we load the files are runtime, like in capabilities_test.go.
So, I'm starting the proposal with some changes in virtwrap by using testdata directory so we always have go:embed testdata/path-to-file.
NONE

/retest-required

/cc

I only have a concern that ideally it would be nice to have a consistency in the project. E.g. now we already use the approach with testdata in some other places to store xmls or other stuff for the tests:

100% agree with consistency. I did not know we had already a directory like that. Let's use it! So, I'll change it to testdata

/retest-required

/retest-required
Thanks Vasiliy, for the reviews!

/test pull-kubevirt-unit-test-arm64

/test pull-kubevirt-unit-test-arm64


Build errors

root@AndrijNotebook:/home/andrijzyn/Desktop/cpp-netlib# ./build.sh
CMake Deprecation Warning at CMakeLists.txt:7 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

CMake Warning (dev) at CMakeLists.txt:8 (project):
  Policy CMP0048 is not set: project() command manages VERSION variables.
  Run "cmake --help-policy CMP0048" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  The following variable(s) would be set to empty:

    CMAKE_PROJECT_VERSION
    CMAKE_PROJECT_VERSION_MAJOR
    CMAKE_PROJECT_VERSION_MINOR
    CMAKE_PROJECT_VERSION_PATCH
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Deprecation Warning at deps/uri/CMakeLists.txt:7 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

CMake Warning (dev) at deps/uri/CMakeLists.txt:10 (option):
  Policy CMP0077 is not set: option() honors normal variables.  Run "cmake
  --help-policy CMP0077" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.

  For compatibility with older versions of CMake, option is clearing the
  normal variable 'Uri_BUILD_TESTS'.
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at deps/uri/CMakeLists.txt:11 (option):
  Policy CMP0077 is not set: option() honors normal variables.  Run "cmake
  --help-policy CMP0077" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.

  For compatibility with older versions of CMake, option is clearing the
  normal variable 'Uri_BUILD_DOCS'.
This warning is for project developers.  Use -Wno-dev to suppress it.

C++ Flags: -std=c++11 -Wall -std=c++11 -std=c++11 -Wall -Werror link flags:
CMake Deprecation Warning at deps/googletest/CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

CMake Deprecation Warning at deps/googletest/googlemock/CMakeLists.txt:42 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

CMake Deprecation Warning at deps/googletest/googletest/CMakeLists.txt:49 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

-- Configuring done
-- Generating done
-- Build files have been written to: /home/andrijzyn/Desktop/cpp-netlib/build
/usr/bin/cmake -S/home/andrijzyn/Desktop/cpp-netlib -B/home/andrijzyn/Desktop/cpp-netlib/build --check-build-system CMakeFiles/Makefile.cmake 0
/usr/bin/cmake -E cmake_progress_start /home/andrijzyn/Desktop/cpp-netlib/build/CMakeFiles /home/andrijzyn/Desktop/cpp-netlib/build//CMakeFiles/progress.marks
make  -f CMakeFiles/Makefile2 all
make[1]: Entering directory '/home/andrijzyn/Desktop/cpp-netlib/build'
make  -f deps/uri/src/CMakeFiles/network-uri.dir/build.make deps/uri/src/CMakeFiles/network-uri.dir/depend
make[2]: Entering directory '/home/andrijzyn/Desktop/cpp-netlib/build'
cd /home/andrijzyn/Desktop/cpp-netlib/build && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/andrijzyn/Desktop/cpp-netlib /home/andrijzyn/Desktop/cpp-netlib/deps/uri/src /home/andrijzyn/Desktop/cpp-netlib/build /home/andrijzyn/Desktop/cpp-netlib/build/deps/uri/src /home/andrijzyn/Desktop/cpp-netlib/build/deps/uri/src/CMakeFiles/network-uri.dir/DependInfo.cmake --color=
make[2]: Leaving directory '/home/andrijzyn/Desktop/cpp-netlib/build'
make  -f deps/uri/src/CMakeFiles/network-uri.dir/build.make deps/uri/src/CMakeFiles/network-uri.dir/build
make[2]: Entering directory '/home/andrijzyn/Desktop/cpp-netlib/build'
[  1%] Building CXX object deps/uri/src/CMakeFiles/network-uri.dir/detail/uri_normalize.cpp.o
cd /home/andrijzyn/Desktop/cpp-netlib/build/deps/uri/src && /usr/bin/c++ -DBOOST_TEST_DYN_LINK -I/home/andrijzyn/Desktop/cpp-netlib/deps/uri/src -I/home/andrijzyn/Desktop/cpp-netlib/deps/uri/include -std=c++11 -Wall -std=c++11 -std=c++11 -Wall -Werror -MD -MT deps/uri/src/CMakeFiles/network-uri.dir/detail/uri_normalize.cpp.o -MF CMakeFiles/network-uri.dir/detail/uri_normalize.cpp.o.d -o CMakeFiles/network-uri.dir/detail/uri_normalize.cpp.o -c /home/andrijzyn/Desktop/cpp-netlib/deps/uri/src/detail/uri_normalize.cpp
In file included from /home/andrijzyn/Desktop/cpp-netlib/deps/uri/src/boost/mpl/aux_/na_assert.hpp:23,
                 from /home/andrijzyn/Desktop/cpp-netlib/deps/uri/src/boost/mpl/arg.hpp:25,
                 from /home/andrijzyn/Desktop/cpp-netlib/deps/uri/src/boost/mpl/placeholders.hpp:24,
                 from /home/andrijzyn/Desktop/cpp-netlib/deps/uri/src/boost/iterator/iterator_categories.hpp:17,
                 from /home/andrijzyn/Desktop/cpp-netlib/deps/uri/src/boost/iterator/iterator_adaptor.hpp:14,
                 from /home/andrijzyn/Desktop/cpp-netlib/deps/uri/src/boost/iterator/transform_iterator.hpp:12,
                 from /home/andrijzyn/Desktop/cpp-netlib/deps/uri/src/boost/algorithm/string/iter_find.hpp:17,
                 from /home/andrijzyn/Desktop/cpp-netlib/deps/uri/src/detail/../boost/algorithm/string/split.hpp:16,
                 from /home/andrijzyn/Desktop/cpp-netlib/deps/uri/src/detail/uri_normalize.cpp:15:

the error is floating, sometimes “Building CXX object” goes up to 9%.

System details:


unexpected behavior with "default" script invocation and fuzzy name matching

nps version: 5.0.3
node version: 4.3.2
npm version: 2.14.12

Here's a trivial package-scripts.js reproducing the issue:
exports.scripts = {
  foo: {
    'bar-baz': 'echo "foo.bar-baz"',
    bar: {
      default: 'nps foo.bar.baz',
      baz: 'echo "foo.bar.baz"'
    }
  }
};

The command executed:
$ nps foo.bar

The output:
nps executing: echo "foo.bar-baz"
foo.bar-baz

Problem description:
It appears the fuzzy script name matching is overeager when "default" scripts are invoked.
Suggested solution:
The script name matching should attempt literal keypath access before fuzzy matching if a "default" script is invoked.

fwiw:
$ nps foo.bar.baz

results in:
nps executing: echo "foo.bar.baz"
foo.bar.baz

Yeah, this seems to be related to #24 which we kinda gave up because it's rare to happen. But, I would definitely like to see things improved!


Add AAR library support

Right now this is not a high priority in my opinion. Any PR's regarding this are more than welcome though.