Collect test coverage for cc-cli

Description of proposed changes

Practical tips for PR review & merge:

[ ] All GitHub Actions report PASS
[ ] Newly added code/functions have unit tests

[ ] Coverage tools report all newly added lines as covered
[ ] The positive scenario is exercised
[ ] Negative scenarios are exercised, e.g. assert on all possible errors
[ ] Assert on events triggered if applicable
[ ] Assert on changes made to storage if applicable

[ ] Modified behavior/functions - try to make sure above test items are covered
[ ] Integration tests are added if applicable/needed

Codecov Report

Merging #1191 (6a26af0) into dev (d399389) will decrease coverage by 67.56%.
The diff coverage is 37.22%.

@@            Coverage Diff             @@
##              dev   #1191       +/-   ##
==========================================
- Coverage   74.62%   7.06%   -67.56%
==========================================
  Files          74      25       -49
  Lines       10686     722     -9964
  Branches        0      83       +83
==========================================
- Hits         7974      51     -7923
+ Misses       2712     671     -2041

Impacted Files
Coverage Δ

scripts/cc-cli/src/commands/balance.ts
0.00% <0.00%> (ø)

scripts/cc-cli/src/commands/bond.ts
0.00% <0.00%> (ø)

scripts/cc-cli/src/commands/distributeRewards.ts
0.00% <0.00%> (ø)

scripts/cc-cli/src/commands/newSeed.ts
0.00% <0.00%> (ø)

scripts/cc-cli/src/commands/send.ts
0.00% <0.00%> (ø)

scripts/cc-cli/src/commands/setKeys.ts
0.00% <0.00%> (ø)

scripts/cc-cli/src/commands/status.ts
0.00% <0.00%> (ø)

scripts/cc-cli/src/commands/unbond.ts
0.00% <0.00%> (ø)

scripts/cc-cli/src/commands/validate.ts
0.00% <0.00%> (ø)

scripts/cc-cli/src/commands/wizard.ts
0.00% <0.00%> (ø)

... and 3 more

... and 86 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


KAFKA-6487: ChangeLoggingKeyValueBytesStore does not propagate delete

The ChangeLoggingKeyValueBytesStore used to write null to its underlying store instead of propagating the delete, which has two drawbacks:

an iterator will see null values
unbounded memory growth of the underlying in-memory keyvalue store

The fix will just propagate the delete instead of performing put(key, null).
The changes to the tests:

extra test whether the key is really gone after delete by calling the approximateEntries on the underlying store. This number is exact because we know the underlying store in the test is of type InMemoryKeyValueStore
extra test to check a delete is logged as <key, null>  (the existing test would also succeed if the key is just absent)

While also updating the corresponding tests of the ChangeLoggingKeyValueStore I noticed the class is nowhere used anymore so I removed it from the source code for clarity.

So my question is what the strategy is towards these deprecated StateStoreSupplier's in the unittests? Create two versions of each, using the old and new strategy to keep coverage for both types?

Currently the community is still working on a strict maintenance strategy towards deprecated APIs, and for this deprecated API that is introduced in 1.0.0 we are likely going to remove it in 2.0.0 release.
As for the test coverage, I'd suggest just updating InMemoryKeyValueLoggedStoreTest to use the new API and not cover the old API anyways.

@bbejeck @guozhangwang a test for the .all() iterator was added as discussed in the AbstractKeyValueStoreTest:testPutGetRange with an update on InMemoryKeyValueLoggedStoreTest to make sure a ChangeLoggingKeyValueBytesStore is instantiated in that test.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-test-coverage/238/

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-test-coverage/242/

@bartdevylder thanks for adding the test.
Just a couple of minor nits, otherwise LGTM

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-test-coverage/246/

@bbejeck @guozhangwang thanks for the quick review, I updated the code as suggested

Cherry-picked to 1.1 as well

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-test-coverage/262/


Current testing branch seems to be unable to get any system-level settings from the database

I couldn't really find the cause for it, but it seems that the way mysqli statements are prepared, they don't handle project_id = null correctly. The resulting query should be something like ISNULL(project_id) instead of project_id in ("NULL").
This affects getSetting() in a system context (where project_id is null).
This change must have occured fairly recently.

The latest commit should resolve this.  While trying to refactoring out the "NULL" string logic I and accidentally committed a broken partial set of changes.  I just reverted it and will make sure the changes is working before I try again.  Please forgive the inconvenience!


Name is not copied to replacement input

I'm using jquery-validation along side my html5 forms.
It requires all inputs to be validated to have a name property.
When the shadow input is added it doesn't have a name so it's not validated.
The original field is hidden, so it also is not validated.
Is there a way to control the attributes that are copied to the shadow elements?
Or some extension point to modify the replacement elements?

We can not copy the name attribute, because this would give wrong values to the backend, not validating invisible elements is not standard compliant.
webshim is coming with a standard compliant validation engine: http://afarkas.github.io/webshim/demos/demos/forms.html#UI-ival
Consider to use this instead of jquery-validation.

Understand.

How do you check a form is valid in JS?
I'll definitely look at swapping to it.

There are multiple possibilities:
//The checkValidiy method return true/false, but also triggers invalid events on all invalid input, which means the validation UI is also invoked
$('form').checkValidity();

// check whether form has valid elements:
$('form :invalid').length

//get validity info about a specific element:
console.log($(':invalid').prop('validity'));

//while this is already implemented as a polyfill / it is currently not enforced (chrome doesn't support this yet)
$('form').is(':invalid');

Also note: In case you want to do some AJAX things. You don't have to do anything. Just bind to the submit event. As long as a form is invalid the submit event is never fired.

In case you want to get the $('form').is(':invalid') feature into all browsers you can do this:
//has to be run before calling webshim.polyfill
try {
webshim,bugs.bustedValidity = !$('<fieldset />').is(':valid');
} catch(e){}

webshim.polyfill('forms forms-ext');

Note: I will add this feature detect as soon as Chrome has this in its stable version (i.e: 41 supports this).


"Current" property renamed to "Instance"

I was following the ReactJS.NET Getting Started for ASP.NET 4.x and found that the "Current" property of JsEngineSwitcher has been replaced by "Instance" as seen here:
https://github.com/Taritsyn/JavaScriptEngineSwitcher/wiki/How-to-upgrade-applications-to-version-2.X

Hello, Halmon!
You are not right. Better read the “How to upgrade applications to version 3.X” section of documentation.

Hi Taritsyn,
Thank you for informing me about the newer version. Worked as the instructions said.


[Feature request]: Generalized submodule accessor

This framework is extremely promising, and I'm keen to see it develop! As you work toward v1.0, I'd like to suggest some kind of functionality that enables users to access submodule components without hard-coding. It seems to me that flexible, scaled model comparisons will require some standardized mode of access that generalizes beyond attribute accessors (I recognize this is partly a limitation of PyTorch).
For example, instead of:
from nnsight import LanguageModel
model = LanguageModel('gpt2', device_map='cuda:0')

with model.trace("Some sequence of text"):
    output = model.transformer.h[5].mlp.output.save()

Using something like stringified submodule accessors:
with model.trace("Some sequence of text"):
    output = model.get("transformer.h.5.mlp.output").save()

...would mean a particular Python script could work for multiple different models and layer types using external configuration in, say, a TOML file or the like. Unless I'm missing something, as things currently stand I have to rely on an external function to achieve this (which is fine but perhaps not ideal):
def get_submodule(
    model: LanguageModel, submodule_name: str, sep: str = "."
) -> Envoy:
    """Get a submodule from the LanguageModel.

    Submodule names are in the format <module><sep><module>...

    Parameters
    ----------
    model : LanguageModel
        The model
    submodule_name : str
        Stringified name of the submodule
    sep : str
        Separator character for submodule components

    Returns
    -------
    Envoy
        The submodule

    Raises
    ------
    AttributeError
        If the model does not have a requested submodule component
    """
    modules = submodule_name.split(sep)
    submodule = model
    while len(modules) > 0:
        module, *_ = modules
        if not hasattr(submodule, module):
            raise AttributeError(
                f"Couldn't access module '{module}' for {submodule_name}"
            )

        submodule = getattr(submodule, module)
        modules.pop(0)

    return submodule

@t-shoemaker  Good idea! Done https://github.com/ndif-team/nnsight/pull/305

Great, thanks!


chore(tests): replace jest with vitest

:tickets: TICKET-000

Upstream PRs

Downstream PRs

Changes

Notes for Reviewers

Recordings/Screenshots

coverage: 100.0%. remained the same
when pulling 87a6f225a34870eaf03c5a5c67d96ad88a8663a5 on vitest
into fda67d1e6be8f74be863b07c25ff82c82c0c6e5c on main.


WSO2 Api Manager 3.0  Data Mapper does not work

I have installed wso2 Api Manager 3.0 on my windows by downloading the binaries.
I wonder if the datamapper does work in the v3.0 of the Api Manager.
it does not work in my case.
I am using OOTB sequences,  but unfortunately unable to actually save it:
The logs are saying that the XML sequence are not found for the datamapper, regarding the apache-synapse configuration.
Steps to reproduce the issue:
1.)Downlaod AM3.0 Binaries and install in windows machine
2.)Open publisher and create a dummy api and in request mediator select the json_to_xml or any ootb sequences. and click on save button.
SAME FLOW WORK PERFECTLY FINE IN 2.6
Please find the errror log file attached.
erroe.txt

Hi guys,
Is it a bug (or) am I doing something wrong ??

Yes, it seems to be a bug. It would be the same issue, https://github.com/wso2/product-apim/issues/6754.
This is fixed in latest master branch with https://github.com/wso2/carbon-apimgt/pull/7835

@dushaniw Thanks for the response.
Can you please guide me on how to get the latest binaries of this fix.?

Hi @ssshaik
Sorry for the late reply. Yes this will be fixed in 3.1.0 :)


Typescript compile error

The current aurelia-breeze.d.ts file has this as the first line:
import breeze from 'breeze-client';
This gives me the error:

ERROR in C:\my\path\my-project\node_modules\aurelia-breeze\dist\aurelia-breeze.d.ts
(1,8): error TS1192: Module '"C:/my/path/my-project/node_modules/breeze-client/index"' has no default export.

If I change the first line to this:
import * as breeze from 'breeze-client';
Then it works fine.
Please consider changing this in the source.

Is this project abandoned?

@Vaccano  you may have to email @jdanyow  personally but which version of TS are you using and what's does tsconfig look like


Mirego-base-setup 9 of X: App Center

📖 Description
Add base setup for appcenter
🦀 Dispatch

#dispatch/kmp

🦀 Requesting reviewers for this pull request:

@marcantoinefortier (contributor with 4 commits in the last 90 days and 29 commits overall)
@EtienneStPierre (reviewer for the kmp stack)

🦀 Mentionning users for this pull request:

@flambert (learner for the kmp stack)
@jgarcia-mirego (learner for the kmp stack)

Wrong base branch


v1.10.2

[ ] #4470
[ ] #4471

Anything more?

https://github.com/pydantic/pydantic/issues/1477

Could you please take a look at https://github.com/pydantic/pydantic/issues/3300#issuecomment-1236129855?

done.


Feat/card

:tada: This PR is included in version 0.8.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add CPOOL: Clearpool

[x] I understand that token listing is not required to use the Polygon Wallet with a token.

Please provide the following information for your token.
Token Name: Clearpool
Token Symbol: CPOOL
Decimals: 18
Polygon Address: 0xb08b3603C5F2629eF83510E6049eDEeFdc3A2D91
Ethereum Address: 0x66761fa41377003622aee3c7675fc7b5c1c2fac5
Logo URI (svg): https://drive.google.com/file/d/10YrrZoKpnqjNnFaMRG5VNLw9zgcDBd96/view?usp=sharing
Project Name: Clearpool
Project Summary:
Clearpool is a Decentralized Capital Markets Ecosystem, where institutional borrowers can access unsecured loans directly from the DeFi ecosystem. Clearpool introduces a dynamic interest model driven by market supply and demand forces.

Liquidity providers on Clearpool can earn attractive yields, with pool interest rates enhanced by additional LP rewards paid in CPOOL - Clearpool's utility and governance token.

Clearpool LP tokens, called cpTokens, are the building blocks for a system of tokenized credit that will provide Clearpool LPs with risk management and hedging capabilities.

As more institutions begin to realize the benefits that decentralized finance can bring to their organizations, Clearpool will provide the new architecture to facilitate flows between the $120 trillion traditional capital markets, and the burgeoning DeFi ecosystem.

The CPOOL Token - CPOOL is the utility and governance token for the Clearpool protocol. - CPOOL holders will vote on the whitelisting of new borrowers, a process that will qualify participants to earn additional CPOOL through an incentive reward scheme. - CPOOL staking will be a required action for borrowers, who must stake an amount of CPOOL to access the area of the protocol where they can make a proposal to be whitelisted. Liquidity providers earn additional CPOOL rewards, enhancing pool interest rates to attractive levels. - Clearpool will announce a buyback program, where a share of protocol revenue will be used to buy CPOOL in the open market, to perpetually sustain reward pools.

Project Contact: https://t.me/zolotokrylin
Project Website: https://clearpool.finance/
Mainnet/Testnet: https://app.clearpool.finance/lend?market=polygon

Internal PR: https://github.com/clearpool-finance/smart-contracts/issues/96#issuecomment-1206046829

@zolotokrylin Can you please confirm the Polygon address. We see that 0x66761fa41377003622aee3c7675fc7b5c1c2fac5 on Ethereum is mapped to 0x5dCc7FEEEfeF110419549A4417313876D33D354con Polygon

I confirm, that this is the correct address: Polygon Address: 0xb08b3603C5F2629eF83510E6049eDEeFdc3A2D91 @appumenon

@appumenon do you mind me asking about the ETA? thanks in advance

Hey @zolotokrylin
We are sorry bit we cannot support a natively deployed token if there is an already bridged token. As per the mapping initaited, it is a mapping from 0x66761fa41377003622aee3c7675fc7b5c1c2fac5 on Ethereum to 0x5dCc7FEEEfeF110419549A4417313876D33D354c on Polygon

@appumenon do you mean there is nothing you guys can do to map the correct  correct token logo?


Addresses Issue #219: Alphabetize Active Campaigns list

What this PR does
Alphabetizes the Active Campaigns list in CampaignListFragment.kt to make it easier to read.
Screenshots
Before:
< add a screenshot of the UI before your change >
(page 1 of 8)

After:
< add a screenshot of the UI after your change >
(page 1 of 8)

I guess there is some reason we are showing that sorting order. @ragesoss can you tell in which sorting order the campaign list is coming?

@ujjwalagrawal17 which campaigns list?
The list of current campaigns on the /explore page is ordered by number of courses.
The campaigns index page at /campaigns shows all campaigns, ordered by ID.
I think alphabetical makes sense for the app.

To clarify, I was referring the the Active Campaigns list on the Explore page.  If you want to make this change, I could do the same for the Active Courses list on the Explore page, too.

I think the current ordering, by number of programs, is what we want to keep for the Explore page.

Ok, thanks for the response, Sage.  As someone new to looking at the Explore page in the app, I'd suggest it might be helpful to let the app user know how the "Active Campaigns" and "Active Courses" lists are sorted if they're left as-is.  A user who is looking for a specific campaign or course title may have to look through the whole list to find it, and a user who's browsing the lists may find it useful to know how the lists are ordered.

@melissasny I think if we can add more details in the course card item they will be able to find it useful.

I guess we don't want to change the sorting order so closing this PR. Thanks for your effort. Let's continue the discussion on #219 for this.


Define global action.yaml

🚀 Feature
Motivation
Seems that particular actions/workflows are not recognized by dependabot and so several of our repo/projects are still using the old version... On the other hand, pin main may have some overhead as we could introduce breaking changes and so broke the particular CI until it is aligned.
So the one global action would aggregate the suggested group of workflows: https://github.com/Lightning-AI/utilities/blob/main/.github/workflows/ci-use-checks.yaml
Also, we can consider based on input/parameter to tun some workflows off :chipmunk:
Pitch
allow dependabot to pick up whenever we make a new release
Alternatives
switch to use main by default
Additional context
see: https://docs.github.com/en/actions/creating-actions

Seem GH updated this case, and recently, new CICD versions were pocked by dependable...

@Borda I thought you somehow managed to make dependabot recognise our releases :) We can close this issue then?

@Borda I thought you somehow managed to make dependabot recognise our releases :) We can close this issue then?

it was not me, so yeah, let's close it for now :)

on the other hand, having global we can have it on GH marketplace :)


Minor fix to Tw2FloatParameter

Fixed updating of the constant buffer in the SetValue prototype
Removed the TODOs for the unused size parameter used by some functions

Not sure why I closed this, this fix is valid.


stop_workers() not working with SLURMCluster

stop workers is not working for me on a SLURM cluster. Looking at the SLURM status I can still see the jobs running, and they are still available in the scheduler after running stop_workers, even after a few minutes.
In [1]: from dask_jobqueue import SLURMCluster

In [2]: cluster = SLURMCluster(processes=1, threads=1, memory='7GB', walltime='00:20:00')

In [3]: from dask.distributed import Client

In [4]: client  = Client(cluster)

In [5]: workers = cluster.start_workers(2)

In [6]:

In [6]: cluster.stop_workers(workers)

In [7]: client.scheduler_info()['workers']
Out[7]:
{'tcp://<IP_ADDRESS>:34830': {'name': 'dask-worker-3',
  'memory_limit':<PHONE_NUMBER>,
  'host': '<IP_ADDRESS>',
  'resources': {},
  'ncores': 1,
  'services': {'nanny': 45411, 'bokeh': 8789},
  'local_directory': '/home/shawntaylor/projects/dask-jobqueue/dask-worker-space/worker-fcck4f5r',
  'pid': 31568,
  'cpu': 2.0,
  'memory': 67280896,
  'time':<PHONE_NUMBER>.0637333,
  'read_bytes': 2777.9680047420147,
  'write_bytes': 2062.4913531609777,
  'num_fds': 22,
  'executing': 0,
  'in_memory': 0,
  'ready': 0,
  'in_flight': 0},
 'tcp://<IP_ADDRESS>:41714': {'name': 'dask-worker-2',
  'memory_limit':<PHONE_NUMBER>,
  'host': '<IP_ADDRESS>',
  'resources': {},
  'ncores': 1,
  'services': {'nanny': 43241, 'bokeh': 42670},
  'local_directory': '/home/shawntaylor/projects/dask-jobqueue/dask-worker-space/worker-857lfd0u',
  'pid': 31570,
  'cpu': 0.0,
  'memory': 67092480,
  'time':<PHONE_NUMBER>.739144,
  'read_bytes': 2542.885851061595,
  'write_bytes': 2066.345038028005,
  'num_fds': 22,
  'executing': 0,
  'in_memory': 0,
  'ready': 0,
  'in_flight': 0}}

In [8]:

I'm pretty sure it's because stop_workers is calling self.cancel_command (set to scancel for SLURM) and expecting to use the slurm job id, which is saved here:
In [30]: cluster.jobs
Out[30]: {4: 'Submitted batch job 19566158', 5: 'Submitted batch job 19566159'}

and using the entire string with scancel instead of just the job id. This gets set here https://github.com/dask/dask-jobqueue/blob/74b3f45a7272e938c7b075f08c7de96fe6369caa/dask_jobqueue/core.py#L164
That's probably made for another schedulers job submission output format? I can fix this for SLURM but I don't know how I would generalize that to fit in the package. If someone can point me in the right direction I can give it a try though and submit a PR.

Thanks for the report. We probably need a method on each cluster that handles decoding the job id from the submit call.

Yes we're not really generic here, it seems very PBS oriented :slightly_smiling_face: ...
Looking at the code, I think we could probably also improve error handling.
In the case of SLURM output, maybe we could use the following option with the sbatch command (see https://slurm.schedmd.com/sbatch.html):
--parsable
    Outputs only the job id number and the cluster name if present. The values are separated by a semicolon. Errors will still be displayed.

Using sbatch --parsable as a submit_command might be enough if it works as expected. But it will probably also be cleaner to have some kind of method to implement in every JobQueueCluster child object as @jhamman mentioned.
It would be great if you could work on a PR @sdtaylor!


change k8scmd node to use k8sassist - [closed]

In GitLab by @luotian-github on May 23, 2018, 07:27
Merges updatek8s18 -> updatek8s18
change k8scmd node to use k8sassist

In GitLab by @wknet123 on Nov 13, 2019, 11:00
closed


Support configurable shared span context

Describe the feature request
The configuration shared_span_context allows us to determine whether client and server spans will shared the same span id. And this value seems to be set to false by Istio.
Maybe we should consider to make this field configurable in the API since some customers really want this to be true.
Describe alternatives you've considered
Expect Istio to support new API or enhance current tracing API to support envoy shared_span_context configuration.

cc @douglas-reid @objectiser
shared_span_context false by default is making zipkin generating wrong span hierarchy, I think we should definitely make this value adjustable, or at least give it reasonable default value based on data model expected by the tracing system.

@bianpengyuan Do you have an example illustrating how the wrong span hierarchy is generated?

@objectiser  See this: https://github.com/istio/istio/issues/13391#issuecomment-484986113

@bianpengyuan Are you referring to the shared_span_context config here? If so, then this governs how span data is generated from the envoy proxy, which is not relevant when generating span data from the adapter.

Sorry maybe I was not very clear in the linked comment. The graph attached in that comment was from envoy reporting span directly to zipkin. I found it was wrong when I try to debug the linked issue.

@objectiser I checked my test cluster again and seems like zipkin could render separated server/client span correctly this time:

Let me dig more and I will share my finding here.

/cc @linsun

We have such a situation：
Two systems in kubernetes. System A is in istio, and the spans were generated by envoy. System B is not in istio, and the spans were generated by other distributed tracing  system, such as libraries which been supported by the OpenZipkin. The service of system A access The service of system B. Then the spans  of system A and system B were send to the same zipkin-collector. If we want to see the correct span context in zipkin-ui, it is necessary to set the shared_span_context true.

@zhu0516123  How does shared_span_context help in this case? shared_span_context controls envoy whether to generate new span for ingress request or not. If system B is not even using envoy, how would shared_span_context affect span generation in systemB? Instead, the tracing library used by systemB should properly handle tracing context from request headers so that spans from two systems could correlate.

@bianpengyuan It seems that if the shared_span_context is true, the spans in two systems will be  normaller in zipkin-ui.
shared_span_context=true:

shared_span_context=false:

@zhu0516123  Thanks for the detailed explanation! I see, it is to make istio tracing behavior consistent with non-istio environment. That makes sense to me. I've created the api change: https://github.com/istio/api/pull/907. Once that is in, I will update the code in main repo.

@bianpengyuan Thanks!

@morvencao @zhu0516123 for now, there are two ways to override the shared_span_context value:

define a custom-bootstrap.yaml and apply it, then add the annotation to the deployment, refer to https://github.com/istio/istio/tree/master/samples/custom-bootstrap

kind: ConfigMap
metadata:
  name: istio-custom-bootstrap-config
  namespace: default
data:
  custom_bootstrap.json: |
    {
      "tracing": {
        "http": {
          "name": "envoy.zipkin",
          "config": {
            "collector_cluster": "zipkin",
            "collector_endpoint": "/api/v1/spans",
            "trace_id_128bit": "true",
            "shared_span_context": "true"
          }
        }
      }
    }

template:
    metadata:
      annotations:
        sidecar.istio.io/bootstrapOverride: "istio-custom-bootstrap-config"

mount a configmap to the path /var/lib/istio/envoy/envoy_bootstrap_tmpl.json at istio-proxy container to override the envoy_bootstrap_tmpl.json, when the proxy start, it will generate the bootstrap config file from that template file.

@foshantiger we'd better have Istio API support configurable shared span context.

@zhu0516123 Thanks for the detailed explanation! I see, it is to make istio tracing behavior consistent with non-istio environment. That makes sense to me. I've created the api change: istio/api#907. Once that is in, I will update the code in main repo.

@bianpengyuan  Is the api change in ?

@silencehe09 No I think the api change won't make it, because it conflicts with the plans for operator and tracing api support in Sidecar API. For now I think we are in favor of customized bootstrap template and annotation. I will keep this issue open until to track this FR until we have a better way to provide configurability on this.

@zhu0516123 Thanks for the detailed explanation! I see, it is to make istio tracing behavior consistent with non-istio environment.
@bianpengyuan  I had met a problem when trying to make istio tracing behavior consistent with non-istio environment if istio ingress gateway is used.  Can you give some suggestions?

Consider this situation (whether share_span_context is set to  true or not; the following share_span_context is set to false):

Because the istio ingress gateway is running in "route" mode, it seems that it only reports one span(outbound span) and ignores the inbound span , but the tracing headers is modified inbound.
As a result, one span is missing for this trace.  I had tried out some experiments and analyzed the span data in json format , just found only one span reported by istio ingress gateway for per trace.
Is there any method to solve this problem?  To make tracing  disabled in istio ingress gateway or make tracing headers pass through?

@zhu0516123 Thanks for the detailed explanation! I see, it is to make istio tracing behavior consistent with non-istio environment. That makes sense to me. I've created the api change: istio/api#907. Once that is in, I will update the code in main repo.

@bianpengyuan  I had met a problem when trying to make istio tracing behavior consistent with non-istio environment if istio ingress gateway is used. Can you give some suggestions?
Consider this situation (whether share_span_context is set to true or not; the following share_span_context is set to false):

Because the istio ingress gateway is running in "route" mode, it seems that it only reports one span(outbound span) and ignores the inbound span , but the tracing headers are modified inbound.
As a result, one span is missing for this trace. I had tried out some experiments and analyzed the span data in json format , just found only one span reported by istio ingress gateway for per trace.
Is there any method to solve this problem? To make tracing disabled in istio ingress gateway or make tracing headers pass through?

@silencehe09 Are you seeing trace generated by istio cannot connect to the ones generated outside of istio? If that is the case, I think maybe it is because ingressgateway is not aware of the trace initiated by the external client. Could you please try to set x-client-trace-id headers? https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/tracing#how-to-initiate-a-trace

@bianpengyuan Thanks. It seems to be right when I initialte the span of external client.

@bianpengyuan  By the way, can we only disable the tracing of istio ingress gateway?

No, I don't think we could control tracing at per workload granularity. @douglas-reid has a wip proposal  about better tracing control via API: https://tinyurl.com/y3lnlf7n

@silencehe09 is your desire to not have a span for the ingress gateway, but have spans for the rest of the services involved?  we don't have a way to do that yet.  as @bianpengyuan relates, we are working towards a proposal that may allow us to do that.


POEditor

POEditor is a localization management platform that allows for collaborative translation of web sites, apps and more.
A SVG-version of their logo is available from http://linode.hvassing.com/poeditor.svg although this is not an official version and should only be used as a way of getting started

Added in 84fc2abe2b9d0b5b39ceac4af32c6e7eccecd657


Add timeline graph

For screenshot and description see issue #1425

Would be useful to have the appropriate API (and if needed documentation) in place, so that I know how the data is formatted. (@tanel)

On hold for the time being.


Format markdown in description

Fix: format markdown in description
Fix: infinite scroll too early

result on my local machine

Thanks, I updated


Revert "singularity-tools: don't preserve store content ownership"

Use cp -ar instead of cp -r to preserve symbolic links and other attributes whenever possible.
This reverts the commit c2eb0aa56e90cffbdcb82a54f3a9b1419e19c88b from #333843.
I mistakenly thought that cp -ar would fail when copying from the root-owned /nix/store without the root privilege. Thanks @SomeoneSerge for pointing it out in the discussion https://github.com/NixOS/nixpkgs/pull/333843#discussion_r1718757987.
Dropping the -a (--archive) flags also causes symbolic links to be dereferenced, which is wrong for store path copying.
As the mistake has got into Nixpkgs 24.11, we may need to backport this PR.
Cc: @jbedo @SomeoneSerge @posch

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[X] Tested, as applicable: (``)

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 358817

x86_64-linux

@ofborg build apptainer.tests
@ofborg build singularity.tests


[Event Hubs] Non-TLS Fix

Summary
The focus of these changes is to ensure that the transport used by the AMQP connection respects the scheme specified and does not enable TLS when it has been explicitly disabled.

/azp run net - eventhub - tests

API change check
API changes are not detected in this pull request.


docs(translation): add French translation

PR Checklist
Please check if your PR fulfills the following requirements:

Put "x" to check

[x] The commit message follows our Contributing Guidelines
[ ] Tests for the changes have been added (optional, for bug fixes or features)
[x] Docs have been added / updated (optional, for bug fixes or features)

PR Type
What kind of change does this PR introduce?

Please check any kind of changes that applies to this PR using "x"

[ ] Bug fix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] ..... (describe the other type)

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.

 (#95 )
What is the new behavior?
..... (Added French translation)
Other information
..... (None)

@Shashankpantiitbhilai Please update this PR or I will close it as an invalid PR.

wait i will fix it


Add systemResourceInfo to getInstance API

Description
This PR adds systemResourceInfo to getInstance API.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

[ ] Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

[ ] Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

New configuration options
Deprecation of configurations
Signature changes to public methods/interfaces
New plugins added or old plugins removed

[ ] Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

Could you add more details on how this will be used?

Generally I am fine this change. Just thinking if it could be an issue if we have multiple api's returning similar information. But that might require a bigger cleanup I guess.

Codecov Report

Merging #7160 (518f0eb) into master (de2f0e0) will decrease coverage by 31.56%.
The diff coverage is 0.00%.

:exclamation: Current head 518f0eb differs from pull request most recent head 9b8be51. Consider uploading reports for the commit 9b8be51 to get more accurate results

@@              Coverage Diff              @@
##             master    #7160       +/-   ##
=============================================
- Coverage     73.49%   41.93%   -31.57%
+ Complexity       92        7       -85
=============================================
  Files          1500     1500
  Lines         73756    73758        +2
  Branches      10637    10637
=============================================
- Hits          54207    30928    -23279
- Misses        16012    40214    +24202
+ Partials       3537     2616      -921

Flag
Coverage Δ

integration
41.93% <0.00%> (+0.02%)
:arrow_up:

unittests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...er/api/resources/PinotInstanceRestletResource.java
17.28% <0.00%> (-46.01%)
:arrow_down:

.../pinot/server/starter/helix/BaseServerStarter.java
54.76% <ø> (ø)

...c/main/java/org/apache/pinot/common/tier/Tier.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ava/org/apache/pinot/spi/data/MetricFieldSpec.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...va/org/apache/pinot/spi/utils/BigDecimalUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...java/org/apache/pinot/common/tier/TierFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...a/org/apache/pinot/spi/config/table/TableType.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...a/org/apache/pinot/spi/data/DateTimeFieldSpec.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../org/apache/pinot/spi/data/DimensionFieldSpec.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../org/apache/pinot/spi/data/readers/FileFormat.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 941 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de2f0e0...9b8be51. Read the comment docs.


added the api endpoints in controllers folder

PR #52
@Niharika0104
I have made the changes as requested and refactored the user endpoint to use the MVC architecture. Please review the updated implementation. I have also added a video demonstrating the implemented functionality.
https://github.com/Niharika0104/TrendTrove/assets/127289297/832f28b2-9722-4b71-8067-ecbb4682c725

Cool!But there are merge conflicts,please resolve them so that I can merge the code.

Yeah I have resolved that

..

@Niharika0104


Unexpected toolbar behavior when browser loses focus

The toolbar is hidden whenever it loses focus, but is only deactivated when the roosterjs editor becomes an inactive element.  If these events don't happen at the same time (such as if you move focus outside of the browser by using/opening another window), then you'll be able to activate a toolbar button by "clicking" on its location, even though the button isn't visible.
This is more of an edge case issue, but it can lead to some confusing behavior (i.e. accidentally indenting your text when you're trying to click back into the editor).

This repo is archived now. For react wrapper of roosterjs, please refer to roosterjs-react package in roosterjs repo. Thanks.


Priority to Youtube music videos

What is the purpose of your issue?

[ ] Bug
[x ] Feature Request
[ ] Question
[ ] Other

Description
I would love a feature that gives priority to youtube music videos!
I thought about getting the video with the "Official Artist Channel" mark, but I'm not sure how to edit the code myself, so I'm submitting here the request.
Just to add context, I do know I can edit the search query into the config.yml file, but I tried different ones and I'm still receiving wrong tracks sometimes...
Search queries I tried:
{artist} - {track-name} official music video
{artist} - {track-name} youtube music
{artist} - {track-name} provided to youtube by

The feature for searching music.youtube.com is yet to be implemented but yes, would be nice to have this as an option.

add ( "topic" ) on the search format and then find any video that matches up with the music you wanted to download
If you find nothing then try to use the manual download

Implanted in v3


[Hermes] [iOS] codepush release-react fails to create Hermes bytecode for iOS

Description
With the advent of Hermes on iOS, it would make sense to distribute Hermes bundles via CodePush. Right now CodePush creates and distributes non-bytecode (plain source) update bundles on iOS. Thus, theoretically, app performance upon installing such an update can degrade.
Browsing the current code for the command, I can see that hermesc can only be invoked for Android projects.
Repro Steps
Please list the steps used to reproduce your issue.
0. Have a Hermes-enabled iOS app (React Native 0.64+)

Run appcenter release-react command for an iOS target. Wait until the bundle is created and uploaded.
Access the Appcenter portal and navigate to the newly updated Code Push distribution's page.
Click "Download bundle". Unzip the file.
main.jsbundle contains minified JS source and not bytecode.

Expected behavior
If Hermes is enabled, the resulting update bundle is Hermes bytecode.
Details

Is there a particular beacon/command that you are having trouble with?

codepush release-react

Which version of the App Center CLI are you using?

latest

Which OS version did you experience the issue on?

macOS BigSur 11.1

What command line/shell are you using?

Shell 5.8 /bin/zsh

What version of Node.js and NPM/Yarn are you using?

node v15

Additionally, you can provide verbose logs of a CLI command by using DEBUG="appcenter-cli:*" before the command, for example, DEBUG="appcenter-cli:*" appcenter apps list. Include the logs here, don't forget to omit any personal/sensitive data.

Good catch! Can't believe I didn't notice this before in my bundles.
I believe the best way to determine if Hermes is being used is by scanning the Podfile.lock for the string "hermes-engine", then just use hermesc as normal.
Even if the main focus should be iOS now (as a lot of people already switched to Hermes on iOS), this will also affect Windows and MacOS, as Hermes runs on those platforms too.
cc @eggli @azundo @andreidubov

Hey all,
Yes, we have it in the roadmap, but so far we can not give any ETA.

I'm thinking... Is it possible to at least highlight the fact that the aforementioned command will not build Hermes bytecode bundles? Users will then know that they have to manually build and upload the Hermes bundle.
I stumbled upon this behavior accidentally, and I guess not many people will find it on their own without a caveat.
It seems that with 0.65 even more people will be migrating to Hermes, especially with that sweet new GC implementation.

Hi there, can anyone confirm if hermes is supported on both iOS and Android now, given that https://github.com/microsoft/appcenter-cli/pull/1461 has been merged and released?

Hi @se1exin , yes hermes is supported on iOS and Android now.
Closing the issue.


29.11 Update to the game has been relased and the hack stops working

The hack stops working, , the auto aim is off, auto loot and evertyhing else  as weell. But on my PC i see game tih like x15 zoom all the time

Yup, same here. Console as follows:
start.js:18 [Deprecation] Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.
loadFile @ start.js:18
userscript.html?id=a1dd658e-3488-4a63-8aaa-7f344af46e9c:20 firststage
manifest.eadb9fdd.js:1 Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
vendor.c9de893b.js:1 Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
app.4899fb15.js:1 Failed to load resource: net::ERR_BLOCKED_BY_CLIENT pretty sure this stuff is from my adblock extension hehe
tag.min.js:18
tag.min.js 1.2s ✰ SRV ✰      ads by http://www.adinplay.com/
VM75:1 The Web Audio autoplay policy will be re-enabled in Chrome 71 (December 2018). Please check that your website is compatible with it. https://goo.gl/7K7WLu
e @ VM75:1
userscript.html?id=a1dd658e-3488-4a63-8aaa-7f344af46e9c:131 loaded
userscript.html?id=a1dd658e-3488-4a63-8aaa-7f344af46e9c:140 modifyStyleRule
userscript.html?id=a1dd658e-3488-4a63-8aaa-7f344af46e9c:160 DOMException: Failed to read the 'cssRules' property from 'CSSStyleSheet': Cannot access rules
at modifyStyleRule (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?id=a1dd658e-3488-4a63-8aaa-7f344af46e9c:146:31)
at eval (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?id=a1dd658e-3488-4a63-8aaa-7f344af46e9c:217:9)
userscript.html?id=a1dd658e-3488-4a63-8aaa-7f344af46e9c:181 DOMException: Failed to read the 'rules' property from 'CSSStyleSheet': Cannot access rules
at modifyStyleRule (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?id=a1dd658e-3488-4a63-8aaa-7f344af46e9c:164:31)
at eval (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?id=a1dd658e-3488-4a63-8aaa-7f344af46e9c:217:9)
userscript.html?id=a1dd658e-3488-4a63-8aaa-7f344af46e9c:191 removeRule success
userscript.html?id=a1dd658e-3488-4a63-8aaa-7f344af46e9c:207 addRule success
userscript.html?id=a1dd658e-3488-4a63-8aaa-7f344af46e9c:191 removeRule success
userscript.html?id=a1dd658e-3488-4a63-8aaa-7f344af46e9c:207 addRule success
userscript.html?id=a1dd658e-3488-4a63-8aaa-7f344af46e9c:191 removeRule success
userscript.html?id=a1dd658e-3488-4a63-8aaa-7f344af46e9c:207 addRule success
userscript.html?id=a1dd658e-3488-4a63-8aaa-7f344af46e9c:191 removeRule success
userscript.html?id=a1dd658e-3488-4a63-8aaa-7f344af46e9c:207 addRule success
userscript.html?id=a1dd658e-3488-4a63-8aaa-7f344af46e9c:191 removeRule success
userscript.html?id=a1dd658e-3488-4a63-8aaa-7f344af46e9c:207 addRule success
userscript.html?id=a1dd658e-3488-4a63-8aaa-7f344af46e9c:191 removeRule success
userscript.html?id=a1dd658e-3488-4a63-8aaa-7f344af46e9c:207 addRule success
webpack_override.js:174 Uncaught TypeError: Cannot read property 'prototype' of undefined
at Object.webpack_inject (webpack_override.js:174)
at n (:1:101)
at window.webpackJsonp (:1:418)
at webpack_inject (webpack_override.js:111)
at webpack_override.js:188

Looks like they tailored the fixes specifically to your program, no feature works except zoom (client-side so it should work).  If possible, you may want to duplicate this repo and make a new account (one that they aren't watching) or make this private.  If you do, please add me! :)))

add me please as well, i see someone also put it on googlechrome (old version from 18.11) , maybe thast thay are more aware about it,

Wait, the hack will be updated soon...

this is a final patch #163

Thanks, i just used your  updated webpack_override.js to bild  extension.  Everything looks fine for me)

Gimme about 30 min, I'm using another computer atm
If someone wants to open pull request with the new variables that's cool too
On Thu, Nov 29, 2018, 12:59 PM Yaroslav Koval<EMAIL_ADDRESS>wrote:

this is a final patch #163
https://github.com/Kalaborative/survivio-plus/pull/163
Thanks, i just used your updated webpack_override.js to bild extension.
Everything looks fine for me)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Kalaborative/survivio-plus/issues/161#issuecomment-442952270,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ASVRhs1zCYRnGMV5DoLIOQHe1alogHjsks5u0C6BgaJpZM4Y5Am4
.


TODOs for integration with docker-galaxy-stable compose containers

These are the main actionables I need to go through to have a first container based on galaxy-stable compose containers working with the helm deployment, as discussed in #2 . More to come here, as I go through them and find dependent tasks.

[x] Fix pykube version on ansible-galaxy-extras to 0.15.0
[ ] Create proposal(1) on docker-galaxy-stable for intermediate image between galaxy-base and galaxy-web, from where galaxy-k8s could stem from.
[x] Create base galaxy-k8s image (2) based on proposal (1).
[ ] Make ansible/run_galaxy_config.sh work on /galaxy-central/ on image (2). Alternatively, replace its functionality.

[ ] Inject workflows given.
[x] Setup database.
[ ] Setup admin user.

[ ] Handle galaxy.ini.injected from user on image (2)
[x] Add missing k8s_* vars on job_conf jinja template on ansible-galaxy-central.
[ ] Write down what seem to be our minimal dependencies (or link to such revision).
[x] Try using GALAXY_RELEASE related vars as in https://github.com/bgruening/docker-galaxy-stable/blob/master/galaxy/Dockerfile#L14 to set repo and branch to use for build.
[ ] Evaluate whether this strategy serves the purpose of sharing tools with jobs pods: https://github.com/bgruening/docker-galaxy-stable#integrating-non-tool-shed-tools-into-the-container--toc
[ ] Use this approach for the image (2) personalization: https://github.com/bgruening/docker-galaxy-stable#personalize-your-galaxy--toc
[x] Handle missing datatypes.
[x] Helm needs to use both a galaxy-init and a galaxy-web derived images for a minimal working example.

Regarding missing datatypes - do you have a list? We should get them into Galaxy 18.01 directly.

Datatypes are mostly from W4M XCMS:
# Missing XCMS datatypes for w4m
COPY external-datatypes/rdata_xcms_datatype.py /galaxy/lib/galaxy/datatypes/
COPY external-datatypes/rdata_camera_datatype.py /galaxy/lib/galaxy/datatypes/
COPY external-datatypes/no_unzip_datatypes.py /galaxy/lib/galaxy/datatypes/
COPY external-datatypes/nmrml_datatype.py /galaxy/lib/galaxy/datatypes/
COPY config/datatypes_conf.xml config/datatypes_conf.xml

from this revision: https://github.com/phnmnl/container-galaxy-k8s-runtime/tree/c6b4bea41481894eeac0e54f786b4f9b839c16e5/external-datatypes

Will close this as it is mostly addressed by work on the branch feature/sync_with_galaxy_stable, which is functional albeit lacking a bit of documentation. PhenoMeNal public instances have been running on the compose setup for some months now.


chore: switch tokens

Coverage remained the same at 100.0% when pulling 21e7ada73478951ea15a8627973fae179bbe501d on switch-token into a4b4c83c0363b97ed4c55701d34484601d175732 on main.

:tada: This PR is included in version 1.3.2 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Section Component

A generic Section that has a title prop and a scrollKey. The scroll key should be used to create a child component used by the NavBar to scroll.

We are using the react-scroll package package. The Section component should create a div with an id equal to the scrollKey prop.


Update spec and add tests for xy, geo shape, and geo bounding box query

Closes #516
This PR includes the following changes:

Change shape query to xy_shape query and add specs for xy_point and xy_shape
Update spec for geo_shape query
Update spec for geo_bounding_box query
Add tests for the 3 query types mentioned above

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Nice work @kolchfa-aws, looking forward to a passing CI. Btw, you can auto-lint-fix with npm run lint--fix.

@dblock @nhtruong Could I get some help with this PR? The tests run locally but are breaking here. Also, I understand that the spec test linter requires me extract object definitions into separate objects and refer to them using ref but when I try to do it, I get an error. Trying to extract the following objects:
GeoShape:
    type: object
    properties:
      type:
        type: string
      coordinates:
        type: array
  GeoShapeField:
    type: object
    properties:
      shape:
        $ref: '_common.yaml#/components/schemas/GeoShape'
      relation:
        $ref: '_common.yaml#/components/schemas/GeoShapeRelation'
    required:
      - shape
GeoShapeQuery:
      allOf:
        - $ref: '#/components/schemas/QueryBase'
        - type: object
          properties:
            field:
              $ref: '#/components/schemas/GeoShapeField'
            ignore_unmapped:
              $ref: '#/components/schemas/IgnoreUnmapped'
          required:
            - field

The error is Error: strict mode: required property "shape" is not defined at "#/components/schemas/_common.query_dsl:GeoShapeField#" (strictRequired).


Debug view colors not visible in light mode

Light theme (Default light +) debug mode colors are garbled -- when the swank debugger opens up.
Need theme based variables for colors defined in debug.css.

Oh, yeah, that needs fixed. I kept meaning to check the different themes but forgot about it. Hopefully I'll have an update for this in a couple of days. I have some other changes I want to put into the next release as well.

This should be fixed


CSS suggestion

In my site (which I didn't write) the global css file has the following
.wt-global {
    overflow-y: scroll;
    overflow-x: hidden;
}

which is applied to the body, this over-rides spotlight's class hide-scrollbars css. Can I suggest you add !important to the overflow: hidden line. After all very little (none?) of the theme css is applicable when spotlight is active.

This is now included on the latest version. Thanks a lot for the report.


Hello，i have some question about beam search

when i set beam_width =2,and in moder.py i change
 if beam_width > 0:    logits = outputs.beam_search_decder_output    sample_id = outputs.predicted_id
this but i get the logits shape is [3,53,10,2] when i decoder 10 sentence
i dont know why the first dim is 3 not vocabulary_size.
when i set beam_width=0
the logit shape is [50,10,17191] is can easy understand
hope can reply!

outputs.beam_search_decoder_output is a tuple of three things namely
( scores , predicted_ids , parent_ids )
53 must be time_axis of decoder
10 is the number of sentence
2 is the beam_width
change :
logits = outputs.beam_search_decoder_output.scores

@piyank22 thank you very much!

@piyank22  Thanks for you explanation!
I just have a follow up question, is there a way that we can find out best prediction amount all results?
in the repo, it seem set beam_id to be 0 as default. I can't find explanation anywhere in the documentation.

beam_id : 0 , implies that no beam search is being used , greedy inference helper is being used.


feat: i add animation to show the modal with transition and fix the icon of close in modal component

Hi, development Team.
i upload change about modal component, i add efect animation to modal with transition, besides also ajustment height and width of button icon close in modal.
By Gabojcb.

I reviewed and tested the commit


crun: 0.16 -> 0.17

https://github.com/containers/crun/releases/tag/0.17

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 110397 run on x86_64-linux 1

4 packages built:

buildah
cri-o
crun
podman

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 110397 run on x86_64-linux 1

4 packages built:

buildah
cri-o
crun
podman


[BACKEND][BUG] Geeting Error while tryign to use django-admin dumpdata  in cti-website-backend_web_1 container

Error Message
# django-admin dumpdata faqs
Traceback (most recent call last):
  File "/usr/local/bin/django-admin", line 8, in <module>
    sys.exit(execute_from_command_line())
  File "/usr/local/lib/python3.8/site-packages/django/core/management/__init__.py", line 401, in execute_from_command_line
    utility.execute()
  File "/usr/local/lib/python3.8/site-packages/django/core/management/__init__.py", line 395, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/usr/local/lib/python3.8/site-packages/django/core/management/base.py", line 330, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/usr/local/lib/python3.8/site-packages/django/core/management/base.py", line 368, in execute
    self.check()
  File "/usr/local/lib/python3.8/site-packages/django/core/management/base.py", line 392, in check
    all_issues = checks.run_checks(
  File "/usr/local/lib/python3.8/site-packages/django/core/checks/registry.py", line 70, in run_checks
    new_errors = check(app_configs=app_configs, databases=databases)
  File "/usr/local/lib/python3.8/site-packages/django/core/checks/security/base.py", line 236, in check_default_hashing_algorithm
    if settings.DEFAULT_HASHING_ALGORITHM not in {'sha1', 'sha256'}:
  File "/usr/local/lib/python3.8/site-packages/django/conf/__init__.py", line 82, in __getattr__
    self._setup(name)
  File "/usr/local/lib/python3.8/site-packages/django/conf/__init__.py", line 63, in _setup
    raise ImproperlyConfigured(
django.core.exceptions.ImproperlyConfigured: Requested setting DEFAULT_HASHING_ALGORITHM, but settings are not configured. You must either define the environment variable DJANGO_SETTINGS_MODULE or call settings.configure() before accessing settings.
#

Fix:
Export environment variable pointing to settings file. It seems that for cti-website-backend_web container configuration is located in /CTI-website-backend/config/settings.py file
Ref: https://stackoverflow.com/questions/47700347/django-core-exceptions-improperlyconfigured-requested-setting-use-i18n-but-set#47700674

@emecas Please use the manage command to dump data. It explicitly references the settings.
python manage.py dumpdata --indent 4 data.faq


Open 0.3.1 pre

@honzasp sorry about the noise with this PR, but i had to test and the py37 support is cumbersome, most of the packages already deprecated it...
Anyways, this PR adds some QA: linter, code formatting and so on. The fixes were mostly automated, except the last one (there is no "flake8 autofix" by default, like with eslint/js).
Please install pre-commit in your machine, then pre-commit install in the repo so it add the git hooks to check stuff before you commit.

I thought it was some cloud env that required it. It's okay so far, let's try to keep it... but in the future we may bump to 3.8 or even 3.9 as they bring lots of stuff for more modern stuff (asyncio, typing...)


Control hjkl keys are bound to arrow keys

[x] I am on the latest Hyper.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate
OS version and name: <OS X El Capatin 10.11.5 >
Hyper.app version: <1.0.0>
The issue is reproducible in vanilla Hyper.app: Yes

Issue
Control hjkl keys are bound to arrow keys.
They are mapped to ^[[D^[[B^[[A^[[C when typed after cat command.
Also these are not the case in other terminal emulators.

Sorry it was to do with my tiling manager not Hyper

@rmurai0610, just curious, what tiling window manager are you using on OS X? 😱 I didn't know that existed!

@albinekb I think it's called KWM. https://github.com/koekeishiya/kwm

@tbodt @albinekb
Yes I use kwm as tiling manager


Add REJECTED status in JobExecutionRequestStatus

When a job execution request is not correct (malformed json), it still in the 'PENDING' status and the job server will continuously try to parse it and submit it. This has a useless overhead in execution, may pollute the logs with repetitive information and may mislead the user.
A new status REJECTED is needed to prevent this overhead.

fixed in d18572bc8f9c62add9d8c80dc62a5735f4897ca1 and e96da8c127c174af48dc3f622b98b2896136fae0


fix: Remove unused using directive in Stride.Audio

PR Details
Fix for #2547 PR
Types of changes

[ ] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] I have built and run the editor to try this change out.

Thanks !


Microsoft Teams loading issue

Describe the bug
I can't open Microsoft Teams anymore. I always get the error "We're sorry - we've run into an issue" after a long loading time. When I delete and readd the service, it works for 2-4 hours again. Then it runs into an issue, force me to reload and runs into this issue again.
Edit: To readd the service, doesn't help anymore.
To Reproduce
1.) Login into MS Teams.
2.) Wait some time.
3.) When MS Teams forces you to reload, click on the button and it fail to load in my case.
Screenshots

Desktop (please complete the following information):

Device: Macbook Pro
OS: macOS Mojave (v10.14.2)

As it's also happen in my normal webbrowser now (before I opened this issue it worked) I'll close this issue. I think it's something on my or microsoft site.


  Platform engineer can either use this as is or use it as a sample to provide a starting point for their own GPT.
What problem does this solve?
As a Developer
I want a guided UI to create GH repo for a Go application, which will be managed by Argo using Tekton
So that I can get started quickly with a Go application
Scenario:
Given: A Developer and an existing Backstage application
When: The developer wants to add a new component to the application
Then: A Go GPT is available to select
Given: A Developer and an existing Backstage application
When The developer adds a new Go component to the application
Then: A starting point application is committed to a source repository

/assign

completed by https://github.com/janus-idp/software-templates/pull/65


adds support for browserify

adds support for browserify, the final javascript file can be generated using make target:
make dist/carto.uncompressed.js

It exposes the global variable "carto" so can be used in the browser like:
carto.Parser().parse('#test { marker-fill: #F00; }')

One of the problems is mapnik reference, the module is not read to work with browserify since it loads modules dynamically. It does not make sense to make it compatible since mapnik-reference is not going to be used so people must to set the reference needed before parse/render:
carto.tree.Reference.setData(reference)
this PR also changes some code to make compatible with the browser.

Yep, the thing here is carto should not depend on mapnik-reference

Just to be clear: I agree, and it's totally possible to disentangle the two.


Python: Fix - Action Planner breaking when parameters are not explicitly given in the ask

Solution to the issue: Python: Action Planner breaking when parameters are not explicitly given in the ask
https://github.com/microsoft/semantic-kernel/issues/5583
Motivation and Context

What problem does it solve?
A. The action planner breaks when the user does not provide specific parameters in the ask/goal
What scenario does it contribute to?
A. In cases when user may not explicitly mention any parameters in the ask/goal
If it fixes an open issue, please link to the issue here.
A. It fixes the issue https://github.com/microsoft/semantic-kernel/issues/5583

Description
Just adding an IF condition before iterating through the generated_plan variable to check if parameters are present or not does the job

@microsoft-github-policy-service agree

Hi @ArfiArfath21, thank you for your contribution. We're actually retiring the action planner in the following PR that is open. https://github.com/microsoft/semantic-kernel/pull/5586 FYI.

Hi @moonbox3, I get that the legacy Stepwise planner is being retired because of a newer version. Why is the action planner being retired though? It actually is an useful feature to have right?

Hi @ArfiArfath21, could you please explain your use-case for the action planner and why you chose is versus something like the function calling stepwise planner? Using OpenAI function calling is more accurate, uses less tokens, and is faster.

Hi @ArfiArfath21, could you please explain your use-case for the action planner and why you chose is versus something like the function calling stepwise planner? Using OpenAI function calling is more accurate, uses less tokens, and is faster.

I have a chatbot application which basically offers multiple different services in it. Depending on the user query/message it has to identify one best course of action (which can be done with action planner) and take the subsequent steps as necessary. Sort of like a classification problem.

@ArfiArfath21 thanks for your response. Have you tried the new function calling stepwise planner? It's performing the same operations as the action planner, but wrapping the plan create as part of the invoke. It uses the available plugins/functions in the kernel and will choose the best one depending upon the user query/question.


Update the "Base quality" project board to a point in which the content can be public

The Base quality project is somehow clean so it may be ready to be made public.


Support metrics in the integrated dashboard

We integrate the upstream dashboard. In order for metrics to show up on the dashboard, the dedicated kubernetesui/metrics-scraper sidecar needs to be integrated as well. This issue is to track the necessary work.

@timoreimann Looks like you only use the repo for public issue tracking, is there anywhere else where we can check for progress, or do you handle that internally only? In other words, is anyone looking into it yet?

@TonyBogdanov we do maintain another, internal ticket. Work for the task at hand is planned, but we cannot commit to a specific timeline as of now.
The place to look for updates publicly is this issue. I'll make sure to post relevant updates here.

@TonyBogdanov Awesome! Have a great day (or night) ;)

Would really like this to work!

Any news on this?

@nickmelis no and there probably won't be. Figure out something else :)

@nickmelis no and there probably won't be. Figure out something else :)

Is this based on any information?

@ties-s No, only experience and the fact that there have been 2 major, stable versions of Kubernetes released on DO since the reporting of this issue and no work has been done on it as far as I know.

Any progress here? Thanks.

Any progress here? Thanks.

Nope, just forget about it and figure out something else. I already said that 1 year ago.

Is any work done on this? It doesn't make sense to use embedded dashboard if there's no way about getting pods metrics

Shame

Any progress?

Any progress?

Any updates after 3 years?


Update packaging and add tox

Update packaging to comply with PEP 517

Implement tox for testing

Closes #326

This is too old, I will start a new one from scratch


Release v0.5

One last time. 💥

Coverage increased (+1.3%) to 88.801% when pulling 5c4557602e35c8dd7711afa8069754d301b6c3d8 on development into 61c23a26b6abc0b2099bfb9c4b6c560f70d611a5 on master.

🎆


Rename config options

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
✔

@arogachev fixed.


Unable to start v0.10.0 on k8s v1.21.4

Version

Karpenter: v0.10.0

Kubernetes: v1.21.4
Expected Behavior

Karpenter pod should start fine
Actual Behavior

Karpenter pod failed as soon as it started, somehow it is complaining about ports 8443 and 8008 in use
In the exact same cluster, v0.9.1 works absolutely fine.
Steps to Reproduce the Problem

Resource Specs and Logs

➜  ~ kl karpenter-56f9c8cfb9-66466 webhook
2022/05/23 07:38:36 Registering 2 clients
2022/05/23 07:38:36 Registering 2 informer factories
2022/05/23 07:38:36 Registering 3 informers
2022/05/23 07:38:36 Registering 4 controllers
2022-05-23T07:38:36.149Z        INFO    Successfully created the logger.
2022-05-23T07:38:36.149Z        INFO    Logging level set to: debug
2022-05-23T07:38:36.150Z        INFO    webhook Profiling enabled: false        {"commit": "00661aa"}
2022-05-23T07:38:36.154Z        INFO    webhook Running with Standard leader election   {"commit": "00661aa"}
2022-05-23T07:38:36.161Z        INFO    webhook Starting configuration manager...       {"commit": "00661aa"}
{"level":"info","ts":1653291516.2617507,"logger":"fallback","caller":"injection/injection.go:61","msg":"Starting informers..."}
2022-05-23T07:38:36.261Z        ERROR   webhook ListenAndServeTLS for admission webhook returned error  {"commit": "00661aa", "error": "listen tcp :8443: bind: address already in use"}
2022-05-23T07:38:36.267Z        DEBUG   webhook.DefaultingWebhook       Adding to queue defaulting.webhook.provisioners.karpenter.sh (depth: 1) {"commit": "00661aa", "knative.dev/key": "/defaulting.webhook.provisioners.karpenter.sh"}
2022-05-23T07:38:36.267Z        DEBUG   webhook.ValidationWebhook       Adding to queue validation.webhook.provisioners.karpenter.sh (depth: 1) {"commit": "00661aa", "knative.dev/key": "/validation.webhook.provisioners.karpenter.sh"}
2022-05-23T07:38:36.267Z        DEBUG   webhook.ConfigMapWebhook        Adding to queue validation.webhook.config.karpenter.sh (depth: 1)       {"commit": "00661aa", "knative.dev/key": "/validation.webhook.config.karpenter.sh"}
2022-05-23T07:38:36.267Z        DEBUG   webhook.ValidationWebhook       Adding to queue platform/karpenter-cert (depth: 2)      {"commit": "00661aa", "knative.dev/key": "platform/karpenter-cert"}
2022-05-23T07:38:36.267Z        DEBUG   webhook.ConfigMapWebhook        Adding to queue platform/karpenter-cert (depth: 2)      {"commit": "00661aa", "knative.dev/key": "platform/karpenter-cert"}
2022-05-23T07:38:36.267Z        DEBUG   webhook.WebhookCertificates     Adding to queue platform/karpenter-cert (depth: 1)      {"commit": "00661aa", "knative.dev/key": "platform/karpenter-cert"}
2022-05-23T07:38:36.267Z        DEBUG   webhook.DefaultingWebhook       Adding to queue platform/karpenter-cert (depth: 2)      {"commit": "00661aa", "knative.dev/key": "platform/karpenter-cert"}
2022-05-23T07:38:36.362Z        INFO    webhook Informers have been synced, unblocking admission webhooks.      {"commit": "00661aa"}
2022-05-23T07:38:36.362Z        INFO    webhook Starting controllers... {"commit": "00661aa"}
2022-05-23T07:38:36.362Z        ERROR   webhook Error while running server      {"commit": "00661aa", "error": "listen tcp :8008: bind: address already in use"}

Do you have multiple Karpenter installations in your cluster? Sounds like you've already got a webhook running on the worker node that this webhook tried to start up on

Do you have multiple Karpenter installations in your cluster? Sounds like you've already got a webhook running on the worker node that this webhook tried to start up on

I too thought the same when I was troubleshooting the same, but I had made sure nothing related to Karpenter was running in the cluster.

Hello @vikas027 ,
Are you deploying Karpenter through the Karpenter Helm chart?  Or through some other mechanism?

I had used helm template to create a manifest and applied it on the cluster.

Can you share the output of k get pod karpenter-56f9c8cfb9-66466 -n karpenter -o yaml?

Sure, will share the output tomorrow morning.

This is quite odd.  I wasn't able to reproduce the problem using the values file (with my cluster details) and helm template.
The only way I can imagine a port conflict such as this is if two containers within the same pod are listening on the same port, or if you are somehow using hostNetwork: true and another pod is already using the ports.
For clarification, are you able to deploy v0.9.1 back to this very same cluster and it works as expected?

For clarification, are you able to deploy v0.9.1 back to this very same cluster and it works as expected?

Yes, it works absolutely fine v0.9.1 on the very same cluster and commands.

Hey @vikas027 my apologies for the delay.  I think we will need to logon to the node directly to understand what else is listening on ports 8443 and 8008.  Assuming you have access to the node via SSH or SSM, you can try a couple things:
Check to see if any process is listening on the referenced ports on the host
sudo netstat -anp | grep -e 8443 -e 8008

Check that just a single webhook container is running on the host
sudo docker ps -a | grep webhook

Check the pods namespace to see what processes are listening on the webhook ports:

Get the PID of the Karpenter Webhook container

sudo ps -aux | grep webhook

Use nsenter to check what is listening on the ports in the network namespace:

sudo nsenter -t <pid> -n netstat -anp | grep -e 8443 -e 8008

Hello @vikas027 ,
Have you had a chance to dig deeper into this issue?  Anything to report?


Add initial skeleton

@hamza3202 Image is available for testing. docker pull stakater/whitelister:PR-1-1

@hamza3202 Image is available for testing. docker pull stakater/whitelister:PR-1-2

@hamza3202 Yikes!  Build 3 has Failed!

@hamza3202 Yikes!  Build 4 has Failed!

@hamza3202 Image is available for testing. docker pull stakater/whitelister:PR-1-6

@hamza3202 Yikes!  Build 7 has Failed!

@hamza3202 Yikes!  Build 8 has Failed!

@hamza3202 Yikes!  Build 9 has Failed!

@hamza3202 Image is available for testing. docker pull stakater/whitelister:PR-1-10

@hamza3202 Image is available for testing. docker pull stakater/whitelister:PR-1-11

@hamza3202 Image is available for testing. docker pull stakater/whitelister:PR-1-12

@hamza3202 Image is available for testing. docker pull stakater/whitelister:PR-1-13

@hamza3202 Image is available for testing. docker pull stakater/whitelister:PR-1-14

@hamza3202 Image is available for testing. docker pull stakater/whitelister:PR-1-15


fix onConfigure access-modifier

Change OnConfigure access modifier to match the overridden method.
In this PR https://github.com/ChilliCream/graphql-platform/pull/5750, you changed OnConfigure from public to protected and forgot to update it in the docs.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Swinging needle meter

You folk might be interested in this if only because imitation is the sincerest form of flattery. It represents two things:

I think it's a genuinely useful component in itself, and
It demonstrates generating dynamic SVG from re-com.

Let me know if you'd like me to work it up into an actual pull request.

Apologies for the very, very, very late response.  Thank you for the offer, but we'll be sticking with fairly stock standard UI widgets and leaving dashboard kinda stuff to other libraries.


fix: update build status badge

JIRA link (if applicable)
Change description
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

Merging as build passed


"In App" Notification

Describe the bug
Consider the scenario where the OS notifications aren't working (like in my case, despite them being enabled hehe). If the app opens up and a new notification has come in, it WILL appear if I check "notifications" but what would be groovy is if the app popped up on things like invites. The way it stands, if notifications aren't working (or I ignore them), it's up to me to go find those invites...too many clicks to get to it.

okay, took the first step toward a solution. agreed that things like invites could be surfaced even better, but now at least there is a notification indicator to let you know if you have anything in your inbox. release is out for that


Add option to embedd Wasm module

At the moment, the Wasm module for lua vm needs to be fetched from the internet. This works nicely in the browser (just another package to fetch), but for server side it would be beneficial if the library was self-contained.
as far as I understand, the best way to do that would be to embedd a base64 encoded module as a sting in source file. That’s, for example, how deno implements deno-dom:
https://github.com/b-fuze/deno-dom/blob/e18ab07fd6e23f1e32ffd77fb4c0f92fadb81b87/build/deno-wasm/deno-wasm.js#L175

It doesn't fetch from the internet on server side, the wasm module is exported as a separated file inside the package


[Bug] [Module Name]dashboard_action web data did not display

Search before asking

[X] I had searched in the issues and found no similar issues.

Operating system information
Linux
Python version information

=3.11

DB-GPT version
main
Related scenes

[ ] Chat Data
[ ] Chat Excel
[ ] Chat DB
[ ] Chat Knowledge
[ ] Model Management
[X] Dashboard
[ ] Plugins

Installation Information

[X] Installation From Source

[ ] Docker Installation

[ ] Docker Compose Installation

[ ] Cluster Installation

[ ] AutoDL Image

[ ] Other

Device information

Models information

What happened

终端有数据为什么前端不显示？vis-dashboard只能展示图吗，表不作为报告的一部分？
What you expected to happen

How to reproduce

Additional context
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

我也是这样的


Try Subsquid for on-chain indexing

Describe the feature you'd like to request
https://docs.subsquid.io/migrate/subsquid-vs-thegraph/
Looks very similar to the Graph, but potentially faster for Optimism, and allows us to use Typescript and our existing ORM
Describe the solution you'd like
https://docs.subsquid.io/quickstart/quickstart-ethereum/
Describe alternatives you've considered

The Graph

Closing this for now as we're moving towards using other resources


[alerta] TLS Support

Currently Kapacitor is sending the Alerta api token as a url param which is unencrypted even when ssl is used. Alerta supports tokens being provided via headers and I am working to make this change. In addition I am adding an option to skip TLS verification for convenience purposes.

@allen13 Thanks!


Update intro-clean-code.md grammar

Another pass at editing after @ucodery's awesome PR.

And thank you for the approval, @ucodery !!


Remove the internal external radio buttons

What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/4101
Description (What does it do?)
It removes the Item type radio button in Menu Item Form.

How can this be tested?

Login to cow-studio

Add a new site course or use and existing one

In the course setting, visit page for Menu

Add a new menu item or open an existing one

The item form should not have radio button as shown in the above picture in description

@ibrahimjaved12 Could you review this?

The changes are working as expected. And I see that you also updated tests, and removed a lot outdated code.
However, I think we may be able to use some more cleanup.
When I search external within the codebase, there are some places where external links is still mentioned (I don't mean within context of external resources).
We should use this opportunity to update it also. Also it appears a few management commands are currently also using external URL.
For example, these are a few files: ocw-studio/websites/management/commands/markdown_cleaning/rules/validate_urls.py  ocw-studio/websites/management/commands/markdown_cleaning/rules/broken_link_fix.py ocw-studio/websites/constants.py - EXTERNAL_IDENTIFIER_PREFIX = "external-" - is this used anywhere?
Also there is isExternalLinkId which seems to be used a lot in the codebase.
We should remove external link related stuff wherever possible, make sure it does not break the management commands. And update internal link related variables' names for their better clarity now.
Just search through external and internal in the codebase for cleanup. More thorough cleanup would depend on priority, but we should do at least what we can here.

@ibrahimjaved12 I have checked through a lot of code. external mostly shows up in management commands like nav_item_to_external_resource which is used to convert an obsolete type of external link to new type of external resource. This should be kept as we might need it in case some external links needs to be converted in production
There shouldn't be any breaking change as far as I can see. However, removing the suggested commands or constants will take a lot of effort alone with updating/removing the relevant tests. I shall track this in a separate issue and prioritize if need be.

@pdpinch what's your take on this?

@pdpinch what's your take on this? ⬆

Sorry I haven't had a chance to comment until now. I appreciate @ibrahimjaved12's zeal for removing code, but I also don't want to hold up this change too long. We should remove the UI as soon as reasonably possible in order to avoid course authors being tempted to use it and creating more data we need to migrate.


Cargo audit informs a possibility of a vulnerability

From cargo audit checking:
Fetching advisory database from `https://github.com/RustSec/advisory-db.git`
      Loaded [39](https://gitlab.com/my_project/-/jobs/2118924918#L39)8 security advisories (from my_project/.cargo/advisory-db)
    Updating crates.io index
    Updating crates.io index
    Scanning Cargo.lock for vulnerabilities (260 crate dependencies)
Crate:         chrono
Version:       0.4.19
Title:         Potential segfault in `localtime_r` invocations
Date:          2020-11-10
ID:            RUSTSEC-2020-0159
URL:           https://rustsec.org/advisories/RUSTSEC-2020-0159
Solution:      No safe upgrade is available!
Dependency tree:
chrono 0.4.19
└── shadow-rs 0.8.1

simplelog replaced their implementation with time-rs

see:

https://github.com/baoyachi/shadow-rs/issues/89
https://github.com/baoyachi/shadow-rs/issues/72

Now, fix with https://github.com/baoyachi/shadow-rs/pull/99.
Upgarde shadow-rs version
...
[dependencies]
shadow-rs = "0.13.0"
...

Close now, and reopen it if there is a problem.


locale-ready fired multiple times

Changing the locale makes the event be fired more than once

locale attribute was removed, so this issue does not happen anymore


"Dataset Name" and "Search Datasets" seem misplaced

Are you okay with this change in wording, @elevnli?


Test commit for triggering update reference images

Signed-off-by: Arkadiusz Spiewak<EMAIL_ADDRESS>Thank you for contributing to harp.gl!
Before requesting a pull request, please remember to check the following documents:

contribution guidelines
coding style

If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.
CI Check
Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!
And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use git commit -s or append --signoff when you are committing to the repo.
Happy contributing!

@heremaps-bot retest this please

@heremaps-bot retest this please

@heremaps-bot ok to test

@heremaps-bot retest this please

@heremaps-bot retest this please


Multiple souls

I added this feature because it was one that I needed so that I could do autocomplete on a unique set of data for each of my users.  I understand completely if you want to keep soulmate as lean and small as possible, but if it's something you think might be useful, you might give it a look.  The gist of this feature is it will let you set a different namespace for your data.  I'm calling that namespace a soul.  The use of the feature is optional, so if you don't specify a soul when you load the data, and when you query the data, it will work the exact same way it works right now.
There's some basic documentation of the feature in the README.md, and I added one new test to suite.
Let me know what you think.

I can definitely see how this feature is useful, though I'd like to try to figure out something a bit cleaner and maybe more powerful.
This implementation is mostly equivalent to having a different "type" for each user's data set, in other words soulmate load venue -s 1 is basically like saying soulmate load venue:1. Ideally you wouldn't want to have to run a separate load command for each user.
A second issue (though probably not a problem in your case) is that your forced to query by a specific user. Certainly there are datasets when you'd only want to limit your query to a specific user sometimes, and other times you want to query the whole set.
I think it'd be nice to be able to filter by any attribute in the data object, where in your case you could store user_id. The simplest implementation would just pull every record matching the autocomplete term and then just filter them down in ruby. That might be problematic if you've got millions of users, but for smaller datasets it shouldn't be too bad.
What do you think?

By the way, thanks for the contribution!

You are right, it's the equivalent of setting a different type for each user.  But, correct me if I'm wrong, but wouldn't it be possible to query all of the venue datasets by asking redis for all the keys that match venues:* then making a union set between all of them?  I do like the idea of just having the user_id in the data object, but I wish there was a better way to filter than just with ruby.  I'll think on it, and see if there isn't some faster way.

If you made the json object have a souls field that could have an array of souls, be it user ids or something else, you could have the loader add it to each needed soul.  So if you had an object like
{
  "id":1,
  "term":"Dodger Stadium",
  "score":84,
  "data":{"url":"\/dodger-stadium-tickets\/","subtitle":"Los Angeles, CA"},
  "aliases":["Chavez Ravine"],
  "souls":[8,12,42,321]
}

The loader would add all the keys like
item["souls"].each do |soul|
  Soulmate.redis.sadd("#{base}:#{soul}", p) # remember this prefix in a master set
  Soulmate.redis.zadd("#{base}:#{soul}:#{p}", item["score"], item["id"]) # store the id of this term in the index
end

And there would have to be some kind of a check to see if the souls attribute is empty, and if so then to do it like it is currently being done.
This makes the redis database size larger if you have a bunch of items that are shared across a lot of souls, but redis's performance shouldn't be hurt noticeably.  In reading stuff put out by antirez about redis and how to tackle certain problems with it, I've noticed he does not seem to take too much care in keeping things as small as possible.  He prefers to take up more space in redis, than have very few keys and doing the heavy lifting with ruby or another language.  I realize that you might be paying a literal price if you're using a service like redis to go, but let me know what you think about this.

I definitely agree on the point of using more space in redis where it avoids heavy lifting in ruby.
One question is, do you think it makes more sense to have a single indexed field that can take multiple values (as in your examples), or the ability to index on multiple fields, each of which can take multiple values? An example of the latter would be:
{
  "id":1,
  "term":"Dodger Stadium",
  "score":84,
  "data":{"url":"\/dodger-stadium-tickets\/","subtitle":"Los Angeles, CA","user_id":"8","city_id":"12"},
  "aliases":["Chavez Ravine"],
  "index":["user_id","city_id"]
}

which I think I prefer.
Another thing is that I think we should limit querying to a single secondary index (at least for now for simplicity), in other words you shouldn't be able to specify a user_id and a city_id.

(made a small edit to the last comment, in case you're reading via email)

Ooh yeah I like that a lot better.  And that shouldn't be too difficult to do either.  Adding filtering by multiple indices shouldn't be too hard to do either with an interstore.  As long as we can keep redis doing all the heavy lifting it should be plenty fast.


Support metadata for exceptions

Describe the solution you'd like
Currently App Center treats unhandled exceptions as errors and there is no way to attach metadata (.jpeg, .txt) or any other relevant information to these.
In our project we consider unhandled exceptions as crashes (where we make Unity trigger a real crash through the Fast but no Exceptions option in ther Player settings). This does not play well with App Center as all these crashes gets lumped together into a single SIGABRT with no meaningful call stack or info.
What we'd like is the possibility to consider unhandled exceptions as crashes with relevant call stacks and be able to attach metadata to these, alternatively treat crashes, exceptions and errors differently.
Describe alternatives you've considered
Some sort of hack to first catch the unhandled exception in ShouldProcessErrorReport and then override the unmeaningful crash data with the callstack/id of the exception together with metadata in GetErrorAttachments - when Unity triggers the crash.
Additional context
To clarify, what we'd like to see in the dashboard:
Crashes -> Here goes pure native crashes and crashes triggered by Unity with relevant info/callstack/metadata.
Errors -> Log errors, exceptions.
Or something like:
Crashes -> Pure native crashes, possible to add metadata
Exceptions -> All exceptions, possible to add metadata
Errors -> Errors with no metadata.
Further note: In HockeyApp we could actually attach a metadata blob to unhandled exceptions which does not seem possible in App Center.

@novalain can you elaborate on how App Center treats your unhandled exceptions as errors? App Center distinguishes handled vs. unhandled exceptions as errors vs. crashes for Xamarin and Unity apps and they should visually be different. Are you seeing your crashes listed as errors?
You can attach a binary or text attachment to your crash reports or customize properties for your handled errors.

Hi @winnieli1208, thanks for your response. If what you say is correct then that is exactly the behaviour we want. I've attached a screenshot showing three errors (two log errors and one exception) and a crash generated by Crashes.GenerateTestCrash()

Here you can see that the unhandled exception is shown as en error and not a crash.
Further, your documentation says:

By default, the App Center SDK doesn't report unhandled exceptions thrown in your app that don't cause a fatal crash. To enable this functionality, call the following method: Crashes.ReportUnhandledExceptions(true);

This only seems to send the unity logs to AppCenter as errors, nothing else. This is very confusing - how can I get my unhandled exceptions to be sent to AppCenter as crashes?

@novalain thanks for the additional details. As you mentioned in your note, Unity puts a catch-all around unhandled exceptions. So even though these might be considered "crashes", the application never actually exits so our SDK treats these exceptions as handled (or errors). I understand this might not be an ideal experience and unfortunately this is a unique limitation for Unity apps. I'll update our docs to make this more clear.
As for your feature request on handled errors attachments - this is definitely on our radar but not on our immediate roadmap. I'll monitor this thread for community support and post here with any updates.
Thanks and let me know if you have any other questions!

Hey @winnieli1208 thanks for explaining this. Unfortunately the limitation of 20 properties per error and 125 characters per key/value is way to low for us. In HockeyApp we could attach a big chunk of JSON to these, which is a requirement from our side in order to be able to do the migration. If support for this is not on your immediate road map we'd have to consider alternative solutions.

@novalain we are discussing this internally and will get back to you with updates. We understand this is a major limitation for Unity developers and we will explore what we can do to improve this experience. Thanks for your patience!


Fix source download location.

This fixes a mystery crash in Conan 1.18 where it gives an error of
NoneType not having an attribute 'token'. Really, it failed to download
the sources.

Reviewed & approved - but can't merge.

Thanks, @datalogics-robb. I keep forgetting to add teams to projects I fork into the organization. You should be able to merge now.


removal of out_fct_wrap_type

This wrapper exists, as a means of passing a function pointer and a null pointer, from the interface function all the way down to the character output function, which itself is a function pointer based on the output mode. This is needed to provide fctprintf().
A better approach, is to instantiate a variable set (struct) particular to the output mode in the interface function. Then pass this by reference through to the character output function.
This makes the character output function the same format (void (out)(char, void))  as that used by fctprintf().
This removes the need for a double function pointer de-reference per character which is a performance boost.
It also removes the need to pass the 'maxlen' parameter to most of the functions, where for most output modes it is unused.

I don't exactly follow what you're suggesting:

out_fct_wrap_type is not exposed in the library interface.
As for the double-dereferencing - we do currently have it, but I don't see how your suggestion would remove it: You seem to be suggesting we pass the function pointer through a pointer to a struct containing it.

Please clarify...

Not the function pointer. Only variables specific to the mode of output. It's difficult for me to explain, but I've already done this on an open PR, you can see the changes there.

Oh, now I see your PR.
But - it's a 44-commit PR; that doesn't make sense. I can't use it without spending hours, or days, on merging. To submit a PR, you start from the branch you're PR'ing against, and only apply one or a few changesets to get the effect you wanted.
Anyway, I don't mind using the struct you suggested, which basically a kind of a richer iterator than a raw pointer. I'll try to manually merge that change soon.

Hmm. This is interesting. This actually gives me the idea of doing something a little differentr:

Do wrap output functions.
Use the wrapper for regular buffer output as well
Have the wrapper take care of counting the number of characters printed
Don't pass maxlen around at all... perhaps we can even avoid passing idx around entirely.
Don't pass idx and maxlen to the output function - because they're supposed to have it.

Well, I was going to work on this, but then other issues came up. Now that there are no open bugs, I believe it might be a good idea to pause, make a release (v5.0 I suppose), then get back to this. What do you think, @mickjc750 ?

I agree, I have some other issues myself at the moment. It's working well enough for now.

@mickjc750 : So, this is happening... expect a PR soon. It will do away with 4 parameters + the return value in lots of functions :-)


make demand plot lines, change filter_curtailment to not alter results

@claytonpbarrows this is just failing because PowerGraphics is using a more up to date version of PowerSystems & Infrastructure Systems than PowerSimulations, so when dev0-6 gets merged it should stop failing


Filter parameters in Mailer logging?

I'm working with attr_encrypted to encrypt my User.email, and have successfully moved my Devise authentication_key to another attribute. However, I'm still seeing legible email addresses in the Mailer logs. Is there any way to get them out of there?
I'm filtering my logs like so in the standard Rails filtered_parameter_logging.rb initializer --
# Configure sensitive parameters which will be filtered from the log file.
Rails.application.config.filter_parameters += [:email, :password, :admin_secret, :access_token]

My logs are being successfully filtered otherwise.
Any ideas?

@irstacks sadly that's more of a Rails issue than Devise's - the whole logging infrastructure is from Rails and as far as I remember the filter_parameters config is only applied to HTTP requests and not to the ActionMailer/ActiveJob logging - maybe the patch from #4140 could help but I haven't tested that.
I'm closing this as it isn't something we can fix on Devise sides.


Perform JSON content type validation in BindJSON()

It might be convenient if BindJSON() could implicitly perform the Content-Type: application/json header validation instead of having to manually call GetContentType() == "application/json" before, WDYT?

Indeed, it could simplify the type validation 👍

Implemented in de74c01c76082fa3c24ba6b59972d9f760fab71d.


DDD for HTTP resources

#145

In trying to follow the same structure as we have for SQLAlchemyTableRepository, which contains a manager SQLAlchemyTableManager which is the one managing the execution of queries with the _connection object, we have created:

HTTPResourceManager
HTTPResourceRepository which derives from HTTPRepository and has a _resource_manager = HTTPResourceManager(self._resource, client).

However, following this pattern I find that the methods of HTTPResourceRepository are just wrappers of single-line methods of HTTPResourceManager. Does this mean we might not need HTTPResourceManager? Or, contrarily, does this mean the methods fo HTTPResourceManager need to do something else rather than jusr returning the response of the client?

In trying to follow the same structure as we have for SQLAlchemyTableRepository, which contains a manager SQLAlchemyTableManager which is the one managing the execution of queries with the _connection object, we have created:

HTTPResourceManager
HTTPResourceRepository which derives from HTTPRepository and has a _resource_manager = HTTPResourceManager(self._resource, client).

However, following this pattern I find that the methods of HTTPResourceRepository are just wrappers of single-line methods of HTTPResourceManager. Does this mean we might not need HTTPResourceManager? Or, contrarily, does this mean the methods fo HTTPResourceManager need to do something else rather than jusr returning the response of the client?

Sorted out, the HTTPResourceManager will return the data itself, i.e. will wait for the response and run checks of the  status_code. If the status_code satisfies the standard REST response codes, then it will parse the data (if available). Otherwise, it will raise an appropriate exception.


priority not working

I have a queue with 100 promises with priority 5 and when schedule a new promise with priority 1 it waiting all the other 100 call

What options are you using? You might need to set a maxConcurrent value for priorities to work with your options.

Priorities essentially allow some jobs to skip ahead of other jobs in the queue. Without a maxConcurrent value (and/or a reservoir), jobs only stay in the queue for a very brief instant before being scheduled for execution at a later time.