allow tzdata 1.0 dependency

tzdata 1.0 has just been released. This version is very similar to 0.5.x so it should just work with  timex. I suggest allowing tzdata ~> 1.0 in mix.exs in addition to the version already allowed.

Done


Longitudinal preprocessor multithreading

Multithreading for Longitudinal Features Lagger

Should probably have a test of some sort to validate they output the same things


DriverFramework: fix lsm9dsl1 mag orientation

This is needed for #5882.

@bkueng please review :).

Applied


Security: Implement Two Factor Authentication

What options exist for two factor authentication? As systems get hacked increasingly we also need to implement ways to keep open event secure.
Therefore please propose and implement two factor authentication. Research solutions and implement the best suited option according to feedback.
I found this Open Source system https://www.privacyidea.org that also provides SMS through Sipgate, but maybe we simply start by using Email as a 2FA authentication method first?

@mariobehling  Can I work on this issue?


wasm: functions in FunctionIndexSpace include wrong contents

Build a hello-world wasm:

package main

func main() {
        println("Hello, World!")
}

GOOS=js GOARCH=wasm go build -o test.wasm helloworld.go

Run the below code:

package main

import (
        "fmt"
        "os"

        "github.com/go-interpreter/wagon/wasm"
)

func main() {
        f, err := os.Open("test.wasm")
        if err != nil {
                panic(err)
        }
        defer f.Close()

        mod, err := wasm.ReadModule(f, nil)
        if err != nil {
                panic(err)
        }

        fn := mod.FunctionIndexSpace[0]
        fmt.Printf("name: %q\n", fn.Name) // This is empty. That's fine since this is an imported function 'debug'.
        fmt.Printf("len(code): %d\n", len(fn.Body.Code)) // This is not empty. That's unexpected. This content is for the first function as 'go.buildid'.
}

It looks like the function's index and its instructions don't match. Some of the first functions should be imported functions, but include instructions for other functions. I think the function bodies are shifted.

https://github.com/go-interpreter/wagon/blob/cbbdf0893ce4f79668a13c0879a7f143bdd0f472/wasm/index.go#L76-L80
The names are shifted with numImports, which is correct, while Sig and Body are not shifted.

Hello, I read in detail, found that the problem comes with numImports, when you don't provide a imported module but the wasm file need it, the numImports is not equal to len(FunctionIndexSpace).
https://github.com/go-interpreter/wagon/blob/dc6758ca7262efb2ef987e32e09f648300b4d007/wasm/index.go#L84-L85
So I had a pr #193
I am not sure if we can do it in this way.
Thanks.


Fix infinite loop in the port mapping code

There's an infinite loop if the offer provides a single port mapping, where the begin = 31000 and the end = 31000. The inner while loop will never execute causing an infinite loop which effectively blocks JenkinsScheduler and causes a lock up in Jenkins

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@stephenliang Thanks for the PR. Awesome job with the unit test!


About the evaluation program

Hello, Pang.
Thanks for your sharing.
Congratulations on your contributions to robustness research.
I tried to run you empirical engineering trick progrm in default setting and run the evalution program from you AT_With_He paper.
https://github.com/AnonymousForDoubleBlind/AT_with_HE/blob/master/CIFAR-10/pgd_attack_cifar10.py
However, it is very wierd that the PGD err is 0.85 while natural err is 0.81.
If I wnt to use the pgd_attack_cifar10.py, what other step should I do to fix the bug so that correct results can be demonstrated.
Thank & Regards!
Momo

Hi Momo, thank you for your appreciation.
We just add a new script eval_cifar.py, which includes evaluation under PGD attacks (CE loss or CW loss) and AutoAttack. You can set the attacking parameters (e.g., attack_iters, restarts) as you need.

Hi Momo, thank you for your appreciation.
We just add a new script eval_cifar.py, which includes evaluation under PGD attacks (CE loss or CW loss) and AutoAttack. You can set the attacking parameters (e.g., attack_iters, restarts) as you need.


Stellar core config history domain missing {0}

The "Stellar Core Config" displayed in stellarbeats.io missing {0}. For example SDF 1, click on "Stellar Core Config", shows HISTORY = "curl -sf http://history.stellar.org/prd/core-live/core_live_001/ -o {1}". ({0} missing at the end of "core_live_001/")
Presumably this line  needs to change.

Fixed, thanks!


facilitate building commandlines in CommandLineProgramTest

currently subclasses of CommandLineProgramTest build commandlines themselves. this could be lifted up and reused.

not something we'll actively work on


Eks-core-services module failing | Pinging tiller!

Output of helm version:
helm version --debug --tiller-connection-timeout 4
Client: &version.Version{SemVer:"v2.14.0", GitCommit:"05811b84a3f93603dd6c2fcfe57944dfa7ab7fd0", GitTreeState:"clean"}
[debug] SERVER: "<IP_ADDRESS>:44134"
Kubernetes: &version.Info{Major:"1", Minor:"13+", GitVersion:"v1.13.12-eks-eb1860", GitCommit:"eb1860579253bb5bf83a5a03eb0330307ae26d18", GitTreeState:"clean", BuildDate:"2019-12-23T08:58:45Z", GoVersion:"go1.11.13", Compiler:"gc", Platform:"linux/amd64"}
[debug] context deadline exceeded
Error: cannot connect to Tiller
Output of kubectl version:
kubectl version
Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.3", GitCommit:"06ad960bfd03b39c8310aaf92d1e7c12ce618213", GitTreeState:"clean", BuildDate:"2020-02-11T18:14:22Z", GoVersion:"go1.13.6", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"13+", GitVersion:"v1.13.12-eks-eb1860", GitCommit:"eb1860579253bb5bf83a5a03eb0330307ae26d18", GitTreeState:"clean", BuildDate:"2019-12-23T08:58:45Z", GoVersion:"go1.11.13", Compiler:"gc", Platform:"linux/amd64"}
Cloud Provider/Platform (AKS, GKE, Minikube etc.): EKS
Hello,
I am in the process of bringing up my EKS cluster using Gruntwork code.
I am able to create cluster successfully and when I run eks-core-services module is failing at a stage where "helm is trying to ping tiller". I am trying to setup helm in my local VM and tiller is deployed in EKS.
time="2020-03-06T13:35:15+05:30" level=info msg="Verified helm home directory /tmp/657119618/.helm and all its subdirectories exist" name=kubergrunt
time="2020-03-06T13:35:15+05:30" level=info msg="Initializing repository file" name=kubergrunt
time="2020-03-06T13:35:15+05:30" level=info msg="Creating helm repository file /tmp/657119618/.helm/repository/repositories.yaml" name=kubergrunt
time="2020-03-06T13:35:15+05:30" level=info msg="Initializing repository file /tmp/657119618/.helm/repository/repositories.yaml with stable repo" name=kubergrunt
time="2020-03-06T13:35:15+05:30" level=info msg="Adding stable repo with URL: https://kubernetes-charts.storage.googleapis.com" name=kubergrunt
time="2020-03-06T13:35:23+05:30" level=info msg="Verifying repository file format" name=kubergrunt
time="2020-03-06T13:35:23+05:30" level=info msg="Verifed repository file format is up to date" name=kubergrunt
time="2020-03-06T13:35:23+05:30" level=info msg="Successfully initializing repository file" name=kubergrunt
time="2020-03-06T13:35:23+05:30" level=info msg="Successfully initialized helm home directory /tmp/657119618/.helm" name=kubergrunt
time="2020-03-06T13:35:23+05:30" level=info msg="Done initializing helm home" name=kubergrunt
time="2020-03-06T13:35:23+05:30" level=info msg="Downloading TLS certificates to access specified Tiller server." name=kubergrunt
time="2020-03-06T13:35:23+05:30" level=info msg="Successfully downloaded TLS certificates." name=kubergrunt
time="2020-03-06T13:35:23+05:30" level=info msg="Generating environment file to setup helm client." name=kubergrunt
time="2020-03-06T13:35:23+05:30" level=info msg="Successfully generated environment file." name=kubergrunt
time="2020-03-06T13:35:23+05:30" level=info msg="Verifying client setup" name=kubergrunt
time="2020-03-06T13:35:23+05:30" level=info msg="Loading Kubernetes Client" name=kubergrunt
time="2020-03-06T13:35:23+05:30" level=info msg="Using direct auth methods to setup client." name=kubergrunt
time="2020-03-06T13:35:23+05:30" level=info msg="Setting up connection to Tiller Pod in Namespace kube-system" name=kubergrunt
time="2020-03-06T13:35:23+05:30" level=info msg="Using direct auth methods to setup client." name=kubergrunt
time="2020-03-06T13:35:30+05:30" level=info msg="Successfully opened tunnel to Tiller Pod in Namespace kube-system: <IP_ADDRESS>:33609" name=kubergrunt
time="2020-03-06T13:35:30+05:30" level=info msg="Setting up new helm client with home /tmp/657119618/.helm and pinging Tiller" name=kubergrunt

  on main.tf line 56, in data "external" "configured_helm_home":
  56: data "external" "configured_helm_home" {

I see that helm is opened tunnel to local host, is that what causing the problem? Do I need to configure this as EKS endpoint in someway?
I am able to get all EKS cluster information from my local VM. Also since I have a openvpn connection established from my local VM to AWS account, I can access the EKS worker nodes from my local VM.
kubectl get namespace
NAME          STATUS   AGE
default       Active   3d19h
kube-public   Active   3d19h
kube-system   Active   3d19h

kubectl get nodes -o wide
NAME                            STATUS   ROLES    AGE     VERSION               INTERNAL-IP     EXTERNAL-IP   OS-IMAGE         KERNEL-VERSION                  CONTAINER-RUNTIME
ip-172-21-103-4.ec2.internal    Ready    <none>   3d19h   v1.13.12-eks-c500e1   <IP_ADDRESS>    <none>        Amazon Linux 2   4.14.165-131.185.amzn2.x86_64   docker://18.9.9
ip-172-21-80-42.ec2.internal    Ready    <none>   3d19h   v1.13.12-eks-c500e1   <IP_ADDRESS>    <none>        Amazon Linux 2   4.14.165-131.185.amzn2.x86_64   docker://18.9.9
ip-172-21-89-120.ec2.internal   Ready    <none>   3d19h   v1.13.12-eks-c500e1   <IP_ADDRESS>   <none>        Amazon Linux 2   4.14.165-131.185.amzn2.x86_64   docker://18.9.9

kubectl get pods --namespace=kube-system -o wide
NAME                             READY   STATUS    RESTARTS   AGE     IP              NODE                            NOMINATED NODE   READINESS GATES
aws-node-2kb88                   1/1     Running   0          3d19h   <IP_ADDRESS>   ip-172-21-89-120.ec2.internal   <none>           <none>
aws-node-st75j                   1/1     Running   0          3d19h   <IP_ADDRESS>    ip-172-21-80-42.ec2.internal    <none>           <none>
aws-node-t65zb                   1/1     Running   0          3d19h   <IP_ADDRESS>    ip-172-21-103-4.ec2.internal    <none>           <none>
coredns-69bc49bfdd-2q2v2         1/1     Running   0          3d19h   <IP_ADDRESS>    ip-172-21-103-4.ec2.internal    <none>           <none>
coredns-69bc49bfdd-wjcw7         1/1     Running   0          3d19h   <IP_ADDRESS>   ip-172-21-103-4.ec2.internal    <none>           <none>
kube-proxy-bt98t                 1/1     Running   0          3d19h   <IP_ADDRESS>    ip-172-21-103-4.ec2.internal    <none>           <none>
kube-proxy-cvxrc                 1/1     Running   0          3d19h   <IP_ADDRESS>    ip-172-21-80-42.ec2.internal    <none>           <none>
kube-proxy-sxwtd                 1/1     Running   0          3d19h   <IP_ADDRESS>   ip-172-21-89-120.ec2.internal   <none>           <none>
tiller-deploy-797864d97c-pppp7   1/1     Running   0          19h     <IP_ADDRESS>   ip-172-21-89-120.ec2.internal   <none>           <none>

I have even tried configuring helm using kubergrunt command. That is also getting timedout at pinging tiller.
kubergrunt helm configure --tiller-namespace kube-system --resource-namespace kube-system --rbac-user sr_full_admin_access

INFO[2020-03-06T13:44:41+05:30] Setting up connection to Tiller Pod in Namespace kube-system  name=kubergrunt
INFO[2020-03-06T13:44:41+05:30] No direct auth methods provided. Using config on disk and context.  name=kubergrunt
INFO[2020-03-06T13:44:43+05:30] Successfully opened tunnel to Tiller Pod in Namespace kube-system: <IP_ADDRESS>:33161  name=kubergrunt
INFO[2020-03-06T13:44:43+05:30] Setting up new helm client with home /home/sanoop/.helm and pinging Tiller  name=kubergrunt

I have following files in my helm home directory.
total 32
drwxr-xr-x 2 sanoop sanoop 4096 Mar  6 13:20 starters
drwxr-xr-x 2 sanoop sanoop 4096 Mar  6 13:20 plugins
drwxr-xr-x 3 sanoop sanoop 4096 Mar  6 13:20 cache
drwxr-xr-x 4 sanoop sanoop 4096 Mar  6 13:20 repository
-rw-r--r-- 1 sanoop sanoop  227 Mar  6 13:44 key.pem
-rwx------ 1 sanoop sanoop  129 Mar  6 13:44 env
-rw-r--r-- 1 sanoop sanoop  729 Mar  6 13:44 cert.pem
-rw-r--r-- 1 sanoop sanoop  814 Mar  6 13:44 ca.pem

And my helm env file is having following contents.
export HELM_HOME=/home/sanoop/.helm
export TILLER_NAMESPACE=kube-system
export HELM_TLS_VERIFY=true
export HELM_TLS_ENABLE=true

I have also set the HELM_HOST environment variable, still it is not connecting to tiller.
export HELM_HOST=<IP_ADDRESS>:44134

helm version --debug --tiller-connection-timeout 4

Client: &version.Version{SemVer:"v2.16.2", GitCommit:"bbdfe5e7803a12bbdf97e94cd847859890cf4050", GitTreeState:"clean"}
[debug] SERVER: "<IP_ADDRESS>:44134"

Kubernetes: &version.Info{Major:"1", Minor:"13+", GitVersion:"v1.13.12-eks-eb1860", GitCommit:"eb1860579253bb5bf83a5a03eb0330307ae26d18", GitTreeState:"clean", BuildDate:"2019-12-23T08:58:45Z", GoVersion:"go1.11.13", Compiler:"gc", Platform:"linux/amd64"}
[debug] context deadline exceeded
Error: cannot connect to Tiller

Have you reached out to kubergrunt and see if they were able to resolve this? Given it's a third-party project, there may be something in their setup that may be causing this. I'd follow up there first.

I am closing this, as it does not appear to be a Helm-specific question, but an EKS/kubegrunt question. Feel free to re-open if you find a Helm-specific issue.


broken author XML for RFC 8288

Describe the issue
See https://bib.ietf.org/public/rfc/bibxml/reference.RFC.8288.xml:
<reference anchor="RFC8288" target="https://www.rfc-editor.org/info/rfc8288">
  <front>
    <title>Web Linking</title>
    <author fullname="M. Nottingham" initials="M." surname="Nottingham"/>
    <author>
      <organization>RFC Publisher</organization>
    </author>
    <date month="October" year="2017"/>
    <abstract>
      <t>This specification defines a model for the relationships between resources on the Web ("links") and the type of those relationships ("link relation types").</t>
      <t>It also defines the serialisation of such links in HTTP headers with the Link header field.</t>
    </abstract>
  </front>
  <seriesInfo name="RFC" value="8288"/>
  <seriesInfo name="DOI" value="10.17487/RFC8288"/>
  <format target="https://www.rfc-editor.org/info/rfc8288" type="TXT"/>
</reference>

Note the entry for "RFC Editor".
Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

Thank you @reschke , this is a bug on our side as a regression of #321 . I will open a separate issue to track this.

(moving this comment here from #321)
(just to note another example)
It looks like this issue has reappeared. While trying to publish last week, I noticed that "RFC Publisher" is now listed as an author for RFCs. For example, see
https://www.rfc-editor.org/v3test/rfc9333.html#section-12.1
https://www.rfc-editor.org/v3test/rfc9333.xml
It seems that the http://bib.ietf.org/ files contain the "RFC Publisher" data. Examples:
https://bib.ietf.org/public/rfc/bibxml/reference.RFC.2119.xml
https://bib.ietf.org/public/rfc/bibxml/reference.RFC.5234.xml
https://bib.ietf.org/public/rfc/bibxml/reference.RFC.9020.xml

@ronaldtse This issue has delayed the publication of RFCs and needs to be treated as urgent.

@ronaldtse - where are we with versioning? I'm surprised that such a regression affected what the bibxml service renders? What needs to happen to keep such perturbations from propagating before they are accepted?


Add a default value for w.size in getWPixelSize

getWPixelSize throws the error "Uncaught (in promise) TypeError: e.size is undefined" upon Webamp initialization if the config option 'windowLayout' is used but doesn't specify all windows, or lacks a 'size' property on some windows.
So for example, either of these windowLayout values will trigger the issue:
// equalizer not specified
windowLayout: {
	main: { position: { left: 0, top: 0 } },
	playlist: {
	  position: { left: 0, top: 232 },
	  size: { extraHeight: 4, extraWidth: 0 },
	}
}

// playlist lacks 'size'
windowLayout: {
	main: { position: { left: 0, top: 0 } },
	equalizer: { position: { left: 0, top: 116 } },
	playlist: {
	  position: { left: 0, top: 232 }
	}
}

My solution was to default 'size' to [0,0] if not present, which seems to work fine (error is resolved and windows render as expected), but not sure if this would be your preferred fix.  The problem windows are designated 'open: false' so that might be checked somewhere, alternatively.

Instead of setting the default in the getter, can you apply the default to the passed in config? I think the types in the rest of Webamp assume the size property is set.
Maybe also update the config types and docs to indicate that size is now optional?

Alternatively, I tried short circuiting the getter if window isn't open:
function getWPixelSize(w: WebampWindow, doubled: boolean) {
	if (!w.open) {
		return {height: 0, width: 0}
	}
	...

Doing that seems fine with omitting the size property; I think my previous testing was - in both cases - throwing the error only because of unspecified (thus, not open) windows (the second example leaves out the milkdrop window).

I really don't like applying the default here. The types say this value will always have a size property. I believe everywhere within Webamp the types are checked and therefore safe. The only place we can end up with a missing size is if the user passes us a window with a missing size. I think it's fine to support that, but we should do so at the boundary where the user provides the incomplete window object.
Alternatively we can validate that input object better and throw if the size is missing.

I'd say this PR can be closed, but wanting to clarify that my original description of the issue is wrong.  User passing a window with missing size is working fine; it's already applying default values in that case.
The issue may be specifically related to the milkdrop window, as this for example throws the error:
windowLayout: {
	main: { position: { left: 0, top: 0 } },
	equalizer: { position: { left: 0, top: 116 } },
	playlist: { position: { left: 0, top: 232 } }
}

Checking the window objects going through getWPixelSize() shows main, eq and playlist as expected, followed by a fourth window object that has only a single property, open, which is false.  Error is then thrown as the size property is undefined.
If milkdrop is in there, or if another window is omitted, no error is thrown.


incorrect rendering of latex pdf

pdf is generated from the following latex code:
simplemath.tex.txt
with pdflatex command, from texlive 2023 with default settings
pdf is the following:
simplemath.pdf
expected behavior:
pdfjs should use font from the pdf
actual behavior:
pdfjs uses system font, which is not needed in this case. as a result, math content displayed incorrectly on some platforms.
configuration:
windows 10 1809, firefox 116, pdfjs shipped with firefox
question:
how to force pdfjs to use embedded font whenever possible, even if it thinks that something is wrong with it?

WFM, with the caveat that I don't speak Russian, using PDF.js 3.10.80 [690b87389] in Firefox Nightly 118.0a1 on Windows 11.

pdfjs should use font from the pdf

The embedded fonts are used in my testing, and there's also no error/warning messages printed in the console.

how to force pdfjs to use embedded font whenever possible, even if it thinks that something is wrong with it?

If a font is rejected by OTS (i.e. the OpenType Sanitizer) for some reason, which doesn't actually seem to happen here, it's simply impossible to force the browser to use said font.

It's not really clear what the "brokenness" looks like in your case, since you didn't include any screen-shots!
(This is something that the ISSUE_TEMPLATE specifically asks for, and please remember to fill out the ISSUE_TEMPLATE as it's presented to you rather than deleting it.)

screenshot:

that's how it looks in my Windows.
there is simple quadratic equation in this document.
the Equals sign looks like minus sign, which is incorrect, but copies as a equal sign.
in linux with firefox 116, all works perfectly.
therefore, this looks like as a problem with my windows system font.
logs:
jslog.txt

screenshot from the fresh latest nightly:

screenshot from the clear fresh profile of ff 116:

Given that this appears to work with a fresh profile, based on https://github.com/mozilla/pdf.js/issues/16836#issuecomment-1679180582, that unfortunately suggests that you've changed some setting(s) in your regular profile which break font handling in the browser.

Closing given the above; I don't see anything actionable for us here at the moment.


Add support for the Partitioned attribute in cookies

Motivation:
Netty currently does not support the Partitioned attribute for response cookies.
https://developers.google.com/privacy-sandbox/3pcd/chips
Modifications:
Since adding new methods to the Cookie interface is backwards-incompatible, the attribute has been solely added to the DefaultCookie class. Moreover, the Partitioned attribute is not included in the current RFC6265. ServerCookieEncoder and ClientCookieDecoder have been updated accordingly to process this value.
Result:
Response cookies with the Partitioned attribute set can be read or written by Netty.
Fixes #13740

@slandelle PTAL

@bryce-anderson can you have a look ?

@simonatan thanks a lot! Can you also do a PR against main ?

@normanmaurer Okay, I'm on it!

Hi,
I see the code changes are available in netty:4.1.107.Final, could you please specify when this will be released to general use?
Thanks,
Arpitha

@aramired 2-3 weeks

Hi,
We are waiting for netty:4.1.107.Final release to utilize it in our release planned in this month. Please do needful.
Thanks in Advance,
Arpitha

@normanmaurer we want to check the SNAPSHOT fix from our local environment. Can you share the repository url we should be pointing to. We tried with below url's with no luck (along with entry)
ext['netty.version'] = '4.1.107.SNAPSHOT'
maven { url "https://oss.sonatype.org/content/repositories/snapshots" }
maven { url "https://oss.sonatype.org/service/local/repositories/snapshots" }

@svankamamidi The version should be 4.1.107.Final-SNAPSHOT, can you try it?

Hi,
We were able to use the  4.1.107.Final-SNAPSHOT in local. As the changes in DefaultCookie we cannot set partitioned parameter directly while adding cookie using ResponseCookie
Below is the context customizer for Tomcat to set partitioned parameter for all cookies globally
@Bean
public TomcatContextCustomizer tomcatContextCustomizer() {
Rfc6265CookieProcessor cookieProcessor = new Rfc6265CookieProcessor();
cookieProcessor.setPartitioned(true);
return context -> {
    context.setUsePartitioned(true);
    context.setCookieProcessor(cookieProcessor);
};

}
Looking for the same in Netty, but didn't find relevant solution. Could you please help out here?
Thanks,
Arpitha

@violetagg thank you so much.
I too have same problem as reported by @aramired


Resolve /v1/bequeath-your-data-and-die is not sending a notification to /v1/update-ltp for tcp-client Updation

Fixes #419

Reviewer is @PrathibaJee


MM-44498: Fix typing UX on channel name input

Summary

Stabilizes updatePlaybook identity
Adds useProxyState hook to debounce side effects or upstream state-setting
Debounces channel name input with useProxyState

Ticket Link

https://mattermost.atlassian.net/browse/MM-44498

Checklist

Item
Y / N / NA [^1]

Telemetry updated?

Gated by experimental feature flag?

Unit/E2E tests updated?

[^1]: Yes / No / Not Applicable.

This is super complicated. I am not sure if I totally understand it. But I also understand why we need it. Hopefully we can remove this with some of the GraphQL performance work we might be doing soon.

This is super complicated. I am not sure if I totally understand it. But I also understand why we need it. Hopefully we can remove this with some of the GraphQL performance work we might be doing soon.

Very much agreed that this should be temporary—it'd be better to fix the root of the problem in the GraphQL layer, that solution would also scale better to fix other things not behind an edit+save gate like drag&drop, toggles, etc.

This is super complicated. I am not sure if I totally understand it. But I also understand why we need it. Hopefully we can remove this with some of the GraphQL performance work we might be doing soon.

This is super complicated. I am not sure if I totally understand it. But I also understand why we need it. Hopefully we can remove this with some of the GraphQL performance work we might be doing soon.

Very much agreed that this should be temporary—it'd be better to fix the root of the problem in the GraphQL layer, that solution would also scale better to fix other things not behind an edit+save gate like drag&drop, toggles, etc.


MoViNet-A0 block 2 should have 40 out channels

Nit: per the paper, there should be 40 output channels in block 2 for MoViNet-A0, while this implementation currently has 24.
https://github.com/Atze00/MoViNet-pytorch/blob/2ad697facd370d01b0f3a6093d38211166e594de/movinets/config.py#L62
https://arxiv.org/pdf/2103.11511.pdf

There are some modification with respect to the original paper. These modifications are made by the authors in their own official implementation, probably the paper is not updated to the latest results.
Have a look here:
https://github.com/tensorflow/models/blob/master/official/vision/beta/projects/movinet/modeling/movinet.py

Thanks @Atze00 for the info. Closing this issue.


Added samples for Partial Document Update (aka Patch)

resolves #28

Looks good to me 👍

are we planning to also add samples for async apis?

yes I will do that later once we finalise the sync example


correct bookmark advance method, especially for situations where the …

…read did not start on the first file in the set of buffer files on disk
as mentioned in https://github.com/serilog/serilog-sinks-loggly/issues/25 (reopened for this reason)

I performed a few tests using the sample app with the set of log files that reproduces the problem (from a production app) and changes a few params in the sample (removed files or moved the bookmark forward) and also tested with the retainedFileLimit param defined, and the erro behaviour seems to be gone.

Hi Miguel! Unfortunately I'm struggling to find time to offer a proper review right now, but in any case, if this fixes known issues it seems like merging through to dev and getting some wider use would be worthwhile 👍 ... Cheers!

Thanks Nick, no problem. I'm going to get a couple of tests run with the prerelease package to be sure and I'll move it into dev. Initial tests seem ok.


Inspect is not a function, Inspect.default is

Describe the bug
The README says that
import Inspect from 'vite-plugin-inspect'

export default {
  plugins: [
    Inspect()
  ],
}

should work.  When I do that, I get:
TypeError: (0 , import_vite_plugin_inspect.default) is not a function

The following works but doesn't match the README:
import Inspect from 'vite-plugin-inspect'

export default {
  plugins: [
    Inspect.default()
  ],
}

Reproduction
See the description
System Info
Node 18
Vite 5.0.4
Vite Plugin Inspect 0.8.0
Bun 1.0.14

Used Package Manager
bun
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

Maybe caused by #99, /cc @userquin

I'll check it

vite + vanilla-ts in SB:

ok, problems with CJS, we should patch cjs/d.cts: https://stackblitz.com/edit/vitejs-vite-9ncgh5?file=main.js

fixed: SB repo using vite-plugin-inspect v0.8.1 https://stackblitz.com/edit/vitejs-vite-xmxn4k

I somehow am getting the same error in a Storybook 8 vite project. I have<EMAIL_ADDRESS>installed, as well as<EMAIL_ADDRESS>info => Starting manager..
info => Starting preview..
=> Failed to build the preview
TypeError: (0 , import_vite_plugin_inspect.default) is not a function
    at Object.viteFinal (./.storybook/main.mjs:172:28)
    at ./node_modules/@storybook/core-common/dist/index.js:12:1162
    at async createViteServer (./node_modules/@storybook/builder-vite/dist/index.js:55:11517)
    at async Module.start (./node_modules/@storybook/builder-vite/dist/index.js:58:1102)
    at async storybookDevServer (./node_modules/@storybook/core-server/dist/index.js:28:7699)
    at async buildOrThrow (./node_modules/@storybook/core-server/dist/index.js:24:7665)
    at async buildDevStandalone (./node_modules/@storybook/core-server/dist/index.js:66:1322)
    at async withTelemetry (./node_modules/@storybook/core-server/dist/index.js:28:3579)
    at async dev (./node_modules/@storybook/cli/dist/generate.js:663:563)
    at async Command.<anonymous> (./node_modules/@storybook/cli/dist/generate.js:665:250)

WARN Broken build, fix the error above.
WARN You may need to refresh the browser.

I added the plugin like so:
import Inspect from 'vite-plugin-inspect';

const config = {
  // ...
  viteFinal(config) {
    config.plugins.unshift(Inspect());

    return config;
  },
};

As you can see from the stacktrace, the file already is named main.mjs - and yes, i already tried Inspect.default() as well.
I just tried to delete the build cache and rebuild the whole thing again, and the .default() fix seems to work with that now? weird.
Interestingly enough, it runs on the storybook port (and not the one declared in the README of this package).

I just tried to delete the build cache and rebuild the whole thing again, and the .default() fix seems to work with that now? weird.

We've moved the package to ESM first, since the package is using default export for the plugin, CJS and ESM don't play well together, we need to update the readme file to include the .default suffix when using this plugin in CJS.

Interestingly enough, it runs on the storybook port (and not the one declared in the README of this package).

This plugin doesn't start a dev server, it just add a middleware to it (sirv iirc) to serve the client ui under <base>__inspect: https://github.com/antfu/vite-plugin-inspect/blob/67e702f998da6aed6474a0b29cd4b784b3ccf1ae/src/node/index.ts#L120-L123


Disable shaky scrollbar

Custom CSS to add to the app:
html {
  scrollbar-gutter: stable;
}

Originally posted by @Tagaishi in https://github.com/ajnart/homarr/issues/1368#issuecomment-1794114450

Original linked issue https://github.com/ajnart/homarr/issues/1513

Closes #1513


Pinterest doesn't work

I love your plugin! Just integrated instagram, facebook and twitter - now i need pinterest:
  pinterest:{
    accounts: ['@romanmelchner'],
    limit: 10,
    access_token: 'xxxxxxxxxx|xxxxxxxxxxxxxx'
  },

could you provide working code - or update your demo?
Cheers,
Roman

HI,
Pinterest was working fine few days ago, but it's now stopped working giving me consol error
Uncaught TypeError: Cannot read property 'forEach' of null
    at Object.getPosts [as success] (jquery.socialfeed.js?ver=4.9.5:691)
    at i (jquery.js?ver=1.12.4:2)
    at Object.fireWith [as resolveWith] (jquery.js?ver=1.12.4:2)
    at y (jquery.js?ver=1.12.4:4)
    at HTMLScriptElement.b.onload.b.onreadystatechange (jquery.js?ver=1.12.4:4)


[feature-request] Add offset to current episode number

I am watching aot and wanted to keep track of episodes I have watched and where to continue. I realise that some anime like aot episode numbering doesn't reset after next season.
for example if season 1 ends on 12th episode and season 2 will starts with 13th episode.
but in MAL episode number will always start at 1 so sometimes its not instantaneous to know which episode I left off, I have to do calculate by adding total number of episode in the last season to the current number.
so it will be a cool feature to also show current episode number by an offset value.

Hey, I'm not quite sure what you are asking for.
After completing 25 episodes of AoT S1, do you want the second season to start from the 26th episode in the app, so it's 25-38 instead of 0-12?
If so, I would say there is no easy way to implement something like this, the MAL API doesn't indicate in any shape or form that a title's sequel has some weird numbering and we should start counting from the prequel's last episode and not 0.

yes MAL api doesn't provide that info and the episode numbering is random in nature some anime do some doesn't, its also depends on the community whether to reset the episode numbering each season or not.
so I would suggest to have an option to give episode offset value. and it will show it like this
ex: if offset value is 25, so for that season it should display like this 0(25)/12, 1(26)/12.
you can give an option to whether use offset feature or not in settings under advance section.
and after long pressing the anime tile in home screen it will show a context menu with options like set offset, remove offset
once set offset is clicked text box will appear with number only input, after entering the offset number. the anime tile should show the episode numbering like this 5(30)/12.
and when remove offset is clicked it will show thr episode number same as before, like this 5/12.
you can also place the offset episode number somewhere else where it would look pretty in the ui.

I don't think it's something I'm gonna ever implement. It's too much work for a questionable output. I don't mind adding some obscure features that are available if a user wants to opt-in from the settings, but your request doesn't seem to be worth the work and complicating the codebase.
I used to watch a ton of anime and never had a need for something like this.

no problem, I just thought I would be a cool feature.

closing the issue, sorry for the trouble.


Add overlay for mesh config to helm

A similar API exists in the operator. This does this in native Helm,
allowing it to be used directly with Helm and to avoid re-implementing
the functionality in operator.
There are two motivations for this change:

Users only need to learn one API, which has been around forever and is
revewed in istio/api: MeshConfig. They have direct access to modify
this, rather than an indirection, where we add confusion and less
flexibility. With this change, users can modify any setting they desire.
Zero maintainance. We don't need to add new values for every field, as
users can touch all of them. We can also remove all the values here (in
the future), as they are redundant now - this cleans up ~60 values.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
3f033dee69bedbda84e096bda16eaa45d71fe6f4
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I have a more complete version of this in https://github.com/istio/istio/pull/22593, but its broken for some reason - not sure what.


Added js to json funciton to JsonUtils.  Also added single unit test for new method.

This will be used to help address issue #622

I'm going to have to re-do this PR...  I accidentally commit from a box that didn't have git fully configured so the name is wrong on the commit record.

@tst-rwildes: You should be able to just rebase, instead of creating a new pull request.


Fix a test that was assuming to be run on UTC clock.

Fix #604

@felixonmars, can you take a look please?

@pcorpet Thanks! I confirm that it fixes the error on my UTC+8 machine.


Update to 1.7.5 causes hydration to break

Hello!
I have a project built with ElderJS and Svelte. While running the yarn audit I saw that ElderJS uses a vulnerable version of Svelte (details).
I tried to update to ElderJS to 1.7.5 and Svelte to 3.49.0, but the hydration stopped working for some reason.
Is this behaviour expected?
Thanks in advance.

Could you be more specific?
I use 1.7.5 and hydration is NOT broken for me, thought there are certain issues.
If you use hydrate-options then you have to use 'json' style for its options:
hydrate-options={{ "loading": "eager", "preload": true }}

Yes, of course.
I did try to provide hydrate-options with hydrate-client, but I get the same behaviour.
So, I have a carousel component where slides are being passed by using hydrate-client.
Inside the component, I have the following logic:
<script>
import { onMount } from 'svelte';

let hydrated;

function prev() {
  console.log('PREV clicked')
}

function next() {
  console.log('NEXT clicked')
}

onMount(() => hydrated = true);
</script>

// IN THE HTML
  <nav>
    {#if hydrated}
      <svg viewBox="0 0 64 64" on:click={prev}>...</svg>
      <svg viewBox="0 0 64 64" on:click={next}>...</svg>
    {/if}
  </nav>

My issue is that hydrated  variable never gets set to true, assuming onMount is not working as expected.
As an idea, I tried to remove the #if hydrated condition, but when clicking, the function would not be executed and I would not see the console.log.
Thank you in advance!

any updates on this?


Quiz exercises: Disable navigation to quiz exercise detail page when the quiz is active

Checklist
General

[ ] I tested all changes and their related features with all corresponding user types on a test server.
[ ] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Client

[x] I followed the coding and design guidelines.
[x] I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

Users should not be able to open the details page after the quiz has started. Instructors should be able to navigate to Re-evaluate page after the quiz ends. Closes #5022.
Description

There are already server-side checks disallowing quiz editing requests after the quiz has started. Also, the Edit button at the Course Management > Exercises page and the one at the Instructor actions bar at the Exercise details behaves correctly and get disabled when the quiz is active. Only the link on the id of the quiz exercise (see screenshot below) seems to be misbehaving so it is fixed in this PR to behave like other navigation buttons.
Steps for Testing

Prerequisites:

1 Instructor
1 Active Quiz
1 Visible Quiz
1 Closed Quiz
1 Open for Practice Quiz
1 Hidden Quiz

Log in to Artemis
Navigate to Course Administration
Go to Exercises page
Check for quizzes in each status:

Hidden, Visible: Editing link/buttons should be enabled.
Closed, Open for Practice: Re-evaluate link/buttons should be enabled.
Active: Editing and Re-evaluate link/buttons should be disabled.

Ensure there are no other buttons or links in the application (apart from typing the url directly) should navigate the user to the re-evaluate and edit pages of Quiz Exercises which does not obey the status rules above.

Review Progress

Code Review

[ ] Review 1
[ ] Review 2

Manual Tests

[x] Test 1
[ ] Test 2

Screenshots

The Visible quiz's id has the navigation link to the edit page while the Active quiz's id does not have it.

As far as I know, the only way to change the quiz from ‘Released for Practice’ to ‘Closed’ is on the quiz edit page (or it should at least be possible from there, #5003). This is now no longer reachable by clicking on the quiz exercise ID in the exercise list.
How can I close a quiz now? The quiz lifecycle table column has no button to go to the next state like it did for the other steps before.

Closing a quiz was never a use case for us, we always kept them open for practice.
We can add a button to the quiz lifecycle column, or we can make it part of the re-evaluation screen which might not be very obvious to users though. It would make sense to rename "Re-evaluate" to "Edit" in the future, but still opening the "re-evaluate" page. Here, we could allow to change the status of the quiz then

Tested on ts2, works as expected. One comment though: When I want to change the status, when editing the quiz, the dropdown status-menu on the bottom left does not work. This is probably intended?

Thank you for your review. Yes , the condition of the drop-down menu is intended and it will even be removed in a follow-up PR since it is not needed anymore.


Add CancellationToken parameters

I added a CancellationToken paramter to InvokeApi functions.
This modification was requested here: https://github.com/Azure/azure-mobile-services/issues/524

Hi @Reminouche, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@Reminouche, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, AZPRBOT;

We'd like to see this change go in, but unfortunately this pull request adds duplicate implementations of RequestAsync, SendRequestAsync and InvokeApiAsync. Any chance you can refactor the existing method implementations to avoid the copy/paste?

Thank for you review @paulbatum
I tried to refacto MobileServiceClient functions to avoid duplication. I hope it will be correct.
Best regards,

What about all of the other Async methods in the Azure Mobile Client, like ToListAsync(), etc.?  Those need cancellation tokens too.


WIP: Update Modularscale to 3

Tried to resolve #44. Unfortunately, my knowledge stops on how exactly typi calls ms. Tests are not passing. I hope someone could help resolve it.
Bower is really outdated and should be removed. This also removes bower dependencies.

@kbariotis: Awesome, thanks for your work! I am really looking forward to using latest modularscale
(which also got some pow/libsass issues fixed).

I won't be able to look at this for a while No bandwidth to do so at the moment. I'll get back to this as soon as I can (I don't know when it'll be though, but please rest assured I'll come back to this; I use Typi in my work regularly, and I'd like to keep it updated).


Sdk Api doesn't fallback to other endpoints

We supply multiple endpoint options to the sdk on our production environment. It's expected that if a connection fails on the first endpoint a connection should be attempted with the next one. This doesn't appear to be happening, could be a bug in polkadot js api

We should try removing this code from the sdk, it might be overriding the default behaviour from polkadot js.
const provider = await polly()
  .logger(_ => {
    debug(`rpc connection failed, retrying..`, config, 'warn')
  })
  .waitAndRetry(config.connectionRetries ?? 8)
  .executeForPromise<WsProvider>(
    () =>
      new Promise((resolve, reject) => {
        const provider = new WsProvider(config.provider)
        provider.on('error', error => {
          reject(error)
        })
        provider.on('connected', () => {
          resolve(provider)
        })
      }),
  )


CentOS 9 grub cannot find kernel

Hi,
If I enable --bootloader grub-bios this happens:

It's looking in a non-existent path. Any ideas where I could look?
Thanks.

Also if I run without --bootloader grub-bios and boot the VM then install grub manually and reboot I get exactly the same issue. So it seems there is something dragged into the VM from the docker environment? It's very strange.

here it source:

Hello @lttlrck  !
I cannot reproduce using the main branch.
Can you share the Dockerfile please ?

I cannot share my dockerfile but it is:
FROM quay.io/centos/centos:stream9-minimal

# lots of regular dnf install, nothing that touches /boot/ or grub. no kernel installs.

I should try an empty dockerfile
I worked around the issue by adding this to the centos template, which is horrible and fragile:
{{- if .GrubBIOS }}
RUN sed -i 's#/root/var/lib/docker/btrfs/subvolumes/[0-9a-f]*##' /boot/loader/entries/*
{{- end }}

Is it possible that one of the dnf contains a vmlinuz which would then be discovered by grub ?

I don't think so.

As it is my hosts docker volume path leaking in, maybe this is an environment issue. Something strange with my dev environment/docker install.

Can you run find / -name 'vmlinuz*' inside the vm please ?

nothing.

I did some grepping and there is no trace of this path either:

this doesn't make any sense and I fear I am wasting your time because of a strange artifact in my environment.


Fix to not expect Outdoor Temperature to exist

Fix to not expect 'outdoor_temperature' to exist when updating since not all units return this information.

@scottyphillips Tested and working (and I think a bug from me originally!)


[YUNIKORN-1492] Add gang scheduling test suites

What is this PR for?
Add gang scheduling test methods to cover all the flows. Added/Modified helper methods as needed.
What type of PR is it?

[ ] - Improvement

Todos

[ ] - Task

What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1492
How should this be tested?
Screenshots (if appropriate)
Questions:

[ ] - The licenses files need update.
[ ] - There is breaking changes for older versions.
[ ] - It needs documentation.

I understand that this is still a draft but these comments should be solved before moving out of draft stage:

license headers for all files
no filenames with capitals (Wrappers.go)
sort imports in 3 groups based on origin: golang system, others packages and yunikorn package imports
Remove any company specific info or messages

Can you check the call you do in the before suite? looks like the REAT call is failing in all setups.


support connection urls

If you merge this pull request, will you be able to create a new release? Thank you.

Sure thing, will do tomorrow!
On Sat, Jan 24, 2015 at 18:44 Simon Bolduc<EMAIL_ADDRESS>wrote:

If you merge this pull request, will you be able to create a new release?
Thank you.
—
Reply to this email directly or view it on GitHub
https://github.com/BlueHotDog/sails-migrations/pull/51#issuecomment-71326252
.


I guess this is no longer needed

Since we have dataAPI and monthly build available, I guess we do not need all of these data
DataAPI : https://data.gov.au/data/dataset/cricos

@vaibhavwtg yes and no
The DataAPI at the current stage is lacking information (for example contact details). I hope the government will enhance the DataAPI with more features and information.
For the time-being, I highly recommend users to take advantage of both sources. The scraped info can be used to query extra information whilst the DataAPI can be used to develop a full list of courses and institutions.


[Inference] Add the num_votes parameter to the CLI so as to control the inference duration (testing purpose)

Alternative to a raw CLI parameter: a configuration file (kind of overkill, at this stage, in my opinion).

Proposed through #50. I will close it once the PR is merged.


Handle missing values

take a look if they are already handled properly

test if the tool works properly with missing values
how are they currently handled?


Green led on dark image

Bug report, debug log and your config file (FULL LOGS ARE MANDATORY)

I am using HyperSerialEsp8266 (@1Mbps) <IP_ADDRESS> with neutral white SK6812 and the recommended RULLZ grabber (coffee, blue). Proper LUT is in config folder.
Steps to reproduce
Display dark color in non hdr.
What is expected?
Led should be darker or off.
What is actually happening?
Led are green
System

HyperHDR Server:

Build:           (HEAD detached at dec81c0) (Awawa-2a2ed8d/dec81c0-1631541363)
Build time:      Sep 15 2021 15:59:42
Git Remote:      https://github.com/awawa-dev/HyperHDR
Version:         <IP_ADDRESS>
UI Lang:         auto (BrowserLang: de-DE)
UI Access:       default
Avail Capt:      macOS (AVF)
Database:        read/write

HyperHDR Server OS:

Distribution:   macOS 12.3
Architecture:   x86_64
Kernel:         darwin (21.4.0 (WS: 64))
Qt Version:     5.15.2
Browser:        Mozilla/5.0 (iPad; CPU OS 15_4_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.4 Mobile/15E148 Safari/604.1

no logs, please stop spamming across multiple repos


[PE-D][Tester A] Define TA in glossary

To ensure that all stakeholders including those that may not be familiar with abbreviations used in NUS have a common understanding

Labels: type.DocumentationBug severity.Medium
original: Justincjr/ped#10

Preliminary Comments:

Not a medium bug.
Considering that the target audience is purely meant for users within NUS, it is unlikely they don't know what TA means. However, might still be good to define.

Recommended Fix:

Define TA in glossary.


Is there a way to save/serialize a document and load/deserialize?

I'm aware that pdfkit is not intended to open and edit existing pdf files. However, I have a use case where I'd like to:

Create a new document
Do a bunch of long-running operations (mainly drawing a few complex svg's using svg-to-pdfkit)
Save the in-progress document to a file somehow
Later (in another instance of the application), I would load the file, do a few minor edits, and produce a pdf file.

Basically, I would do the last step multiple times (in separate processes) so I'd like to perform the long-running operation only once and save it. Is this possible?

In my current project I am using svg-to-pdfkit to do single page pdfs, then using HummusJS to append them together. HummusJS has full parsing/modification/merging capabilties.

We had a similar use case (we needed to serialize and deserialize jobs, but also we needed to use the same set of instructions to draw to HTML canvas) and wrote a very thin wrapper around pdfkit that only implemented the functions we were using, drawing text, placing svg and other images etc - a simple skeleton for implementing such a thing would be something like:
const jsonApi = instructions => {
  const text = ( text, x, y ) => {
    instructions.push( { text, x, y } )
  }

  //... other wrapper fns go here

  const api = { text, /* other wrapper fns */ }

  return api
}

const canvasApi = context => {
  const text = ( text, x, y ) => {
    /*
      the canvas api uses the baseline instead of the ascender for y, do some
      math here using the font metrics (see fontkit) to alter y accordingly
    */

    context.fillText( text, x, y )
  }

  //... other wrapper fns go here

  const api = { text, /* other wrapper fns */ }

  return api
}

const pdfApi = doc => {
  const text = doc.text

  //... other wrapper fns go here

  const api = { text, /* other wrapper fns */ }

  return api
}

const generateDocument = api => {
  api.text( 'Hello, World!', 50, 50 )

  // other instructions to generate the document go here
}

const generatePdf = () => {
  const doc = new PDFDocument()
  const api = pdfApi( doc )

  generateDocument( api )

  // write pdf etc
}

const generateJson = () => {
  const instructions = []
  const api = jsonApi( instructions )

  generateDocument( api )

  // save json or whatever
}

const generateCanvas = () => {
  const canvas = document.createElement( 'canvas' )
  const context = canvas.getContext( '2d' )
  const api = canvasApi( context )

  generateDocument( api )

  // etc
}

// now add some code that can play back the json to a different api

@nrkn Nice example of Strategy and Delegator there!


fixes to get istiod working with constrained permissions

Signed-off-by: rcernich<EMAIL_ADDRESS>Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

I called out one of the Node informers after the rebase. More info on that in MAISTRA-1622. I think that change is partly to support exposing gateways via NodePort. Maybe we don't support that, but we should probably document that.

Yeah, I'm not sure why it's adding the node IPs for the gateways into the service registry.  Maybe this is for multicluster?  If so, maybe we should be watching routes instead?  (Although, that probably won't work, as you can't access the service using an IP, without specifying SNI host too, and that means we need to get the host IP for the router anyway.)


404 does not get returned if logged in

If you are logged in and go to some route, which does not exists it looks like this:

I looked into app/Exceptions/Handler.php but this seems fine. I also did an dd('test') in 404.blade.php and it gets displayed.
Anyone an idea why it is not showing up the error site?

@Naoray Yeah I've seen this before, so it's a known issue that I've never addressed.
Not exactly sure why it's doing this. If you want to dig into it, I'd be really curious to know. But now that you brought it up, I'll try and give it a look in the next couple days as well.


MULTIPLE UPS on ONE OPNsense box

I have TWO UPS's THAT ARE NOT CONNECTED TO COMPUTERS that I would like controlled by one instance of OPNsense via the USB ports.   If there is a way to do that, I've not found it. :-(

Is this with the plain NUT tools possible?

Any news @waydavis ?

none.

Do you want to investigate some time or close for now?

You're asking ME because?  I asked the original question.  I'm a end-user.  If I knew what, where, or how, I would have posted a solution instead of the question.

You could Plug in both cables and Post the last 50 lines of system.log. When both are the same driver we perhaps can configure  both ports. Cant reproduce since I dont have 2 UPS

Close? I don't have 2 UPS and won't have 2 in future. Not able to test ...

Hello, can this be reopened ?

If you can implement this via cli and conf I can try to add it to gui

I won't be able to work on that this month but I can give it a try in July.
I've never worked on opnsense plugins before and my PHP skills are close to nonexistent but why not.
As for the issue, via shell I used nut-scanner -U and piped it to the ups.conf file, I also added one MONITOR line for each UPS and restarted nut using the rc.d file.
Doing so made the UPS metrics for both UPS via upsc nutdevX@opnsense-ip:3493 (X -> device number).

Also it would be great to be able to specify the behavior and thresholds when the UPS battery goes down


Update based on voxpupuli/modulesync_config

Please merge. I disabled the check variable_contains_upcase until we fixed this and have a better code coverage.

Do we have reason to believe that puppet 4's resource types behave that differently?

Same problem as with the module confluence.


CSS file contains global styles

Steps to Reproduce

Go to example page https://lifescience.opensource.epam.com/KetcherDemoSA/index.html
Open browser console and find main style file
In style file find "checkbox":

OR:

Open https://www.npmjs.com/package/ketcher-react?activeTab=explore
Open index.css file
Find "checkbox":

Actual behavior
Global styles exported from npm build
Expected behavior
Compiled styles should not contain global styles. I tried to compile Ketcher locally and styles looks fine:

Ketcher version [e.g. v2.4.2].
2.6.4

Hello @Nitvex , I am experiencing an issue where I am unable to use ketcher-react in a Next JS project. Is there any plan to fix this issue?

Hi @Jackson-Hill, please checkout this comment https://github.com/epam/ketcher/issues/2197#issuecomment-1619776556

Thanks for your contribution @4-life
This issue has been fixed by https://github.com/epam/ketcher/pull/1767


added Testimonial section

Thank you for your contribution to Dust-Road-Co 🤩🤩

Please mention the following in order to get PR merged  🙌🏻🙌🏻

Kind of change this PR introduce: Added testimonial section for reviews
Issue it resolves: #41
GitHub Page Link: https://sanjana317.github.io/Dust-Road-Co/

ohh okay thank you

@2024-SANDHYA I have made changes. Please take a look.

@2024-SANDHYA Yes, I made changes now. Please review it.

@2024-SANDHYA I have made changes but there seems to be a problem in the banner section which is why there's white space between the banner and the testimonial section. Please review it.

even after adding the padding, the white space is still there @2024-SANDHYA

even after adding the padding, the white space is still there @2024-SANDHYA

I know about that, I am not concerned about the white space. @sanjana317

@2024-SANDHYA oh okay I have added the padding and pushed the changes

oh sorry, I've changed it now @2024-SANDHYA

yes I have changed it @2024-SANDHYA


[UI] add mapper to podname and version

Signed-off-by: Bariq<EMAIL_ADDRESS>Description
This PR fixes #3955
Notes for Reviewers
Making a function where all the heavy work and bad codes resides.
Signed commits

[x] Yes, I signed my commits.

Codecov Report

Merging #3956 (9255e4e) into master (87f51e6) will decrease coverage by 7.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3956      +/-   ##
==========================================
- Coverage   26.22%   18.93%   -7.29%
==========================================
  Files          64       64
  Lines        4995     4995
==========================================
- Hits         1310      946     -364
- Misses       3281     3760     +479
+ Partials      404      289     -115

Flag
Coverage Δ

gointegrationtests
?

unittests
18.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mesheryctl/internal/cli/root/system/status.go
0.00% <0.00%> (-62.83%)
:arrow_down:

mesheryctl/internal/cli/root/system/start.go
1.08% <0.00%> (-52.90%)
:arrow_down:

mesheryctl/internal/cli/root/system/stop.go
0.90% <0.00%> (-39.10%)
:arrow_down:

mesheryctl/internal/cli/root/system/restart.go
1.78% <0.00%> (-32.15%)
:arrow_down:

mesheryctl/internal/cli/root/system/update.go
1.17% <0.00%> (-29.42%)
:arrow_down:

mesheryctl/internal/cli/root/system/check.go
1.39% <0.00%> (-22.38%)
:arrow_down:

mesheryctl/internal/cli/root/system/logs.go
0.00% <0.00%> (-21.60%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87f51e6...9255e4e. Read the comment docs.

Uh-oh, a merge conflict has arisen.


ISPN-1747 redundant checks in the RecoveryManagerImpl

https://issues.jboss.org/browse/ISPN-1747

merged, thanks!


The defined window global variable cannot be obtained.

Found an issue or bug with electron-vue? Tell me all about it!
Questions regarding how to use electron or vue are likely to be closed as they are not direct issues with this boilerplate. Please seek solutions from official documentation or their respective communities.
Describe the issue / bug.
in main.js defined window._et = {/****/}, and then throw error "Uncaught ReferenceError: _et is not defined"
How can I reproduce this problem?
just defined some variable in you main.js and then use it.
If visual, provide a screenshot.
main.js:
window._et = {
  config,
  utils
}

and you can in console input _et
Tell me about your development environment.

Node version:8.9.0
NPM version:5.5.1
vue-cli version: (if necessary)
Operating System: window 10

If you are looking to suggest an enhancement or feature, then feel free to remove everything above.

In electron script there is no window object. Instead there is global object available.

@mubaidr Thank you!
This really works.


What up with 'Pop Art'

Pop art in the popular categories doesn't trigger recommendation.

What is this about exactly?

Pop Art used to be in the popular categories list, and when you clicked it it would just kind of freeze. I've taken it out of the json file for now, but need to debug it properly - about to do that now.

Thanks!

Fixed! Had the wrong ID and _id in the json file (pop-and-contemporary-pop no longer exists). Now just pop-art.


not possible to craft a broken spawner villager

not possible to craft a broken spawner villager in the binder soul will I put a vial villager soul I can not meter the broken spawner is inversely
I try to change the config file user but still not possible I can make you this video you want. I esseiller to add a mob in disable it is these well disable
sorry for the quality of translation

https://github.com/SleepyTrousers/EnderIO/issues/2581

ths it works


When to release Elvish 1.0

Here are my thoughts on what Elvish 1.0 means and when to release it.
Background
Elvish has, up until then, been designed and implemented predominantly by one person, namely me. I certainly don't mean to belittle the contributions from and discussions with the community, nor do I reject a future where Elvish becomes more like a community project. Nonetheless, I am the only person who can push directly to the repo, and I have never merged any code that I don't personally like.
Having a small team of designer for a language is a better idea than it might sound (and 1 is the smallest you can get). For instance, C was designed by Dennis Ritchie; Go by Robert Griesemer, Rob Pike and Ken Thompson; Clojure by Rich Hickey. None of those languages are perfect, but they are more coherent and tend to be smaller than languages designed by committees. (Examples abound; Scheme is a notable, perhaps only, counter-example).
To conclude, before the Elvish community evolves significantly, Elvish will remain designed (and "controlled", if you will) predominantly by me. This is both a constraint of reality and a good thing. As a result, this design note and potentially many others to come, will be colored by my honest personal opinions.
With that out of the way let's get to the actual topic...
What Elvish 1.0 means
I treat the significance of 1.0 as pretty much the same way as Go treated its 1.0, namely there is a compatibility promise. What this means is the following:

There will be a more or less rigorous language specification (this is Go's);

Any code written against that language specification will continue to work in future releases of Elvish 1.x.

In other words, once a language feature is in Elvish 1.0, it will be in all of Elvish 1.x releases. One can workaround that by explicitly marking some features as unstable and not documenting them in the language specification, but I want to avoid that wherever possible.
I would also think that Elvish 1 should have a lifespan of at least 10 years from the 1.0 release. Combined with the compatibility release, this means that Elvish 1.0 language needs to get things as "right" as possible, because once it is released, I will stick to such features for 10 years (this is not a promise, but rather a goal).
Also note that the UI experience is not put under the compatibility promise. My hope is that by Elvish 1.0, the UI will have become modular enough that it can have its own versioning, and breaking changes in the UI is more acceptable than the language.
What are still not right
So the reason we haven't had an Elvish 1.0 release yet is, of course, some parts of the language are still not "right". This is a strictly subjective matter, and this is where my personal taste kicks in.
Here is a preliminary list of things I don't find "right" yet. As anyone familiar with programming languages will notice, all of those problems are already understood within the PL theory community, and many have multiple solutions. However, the real problem here is a design one: which solutions to pick and mix to make Elvish feel simple and coherent.

State sharing between concurrent threads. Shells are inherently concurrent languages due to the existence of pipelines. However, it is not clear how to share state between threads in a safe way: Elvish today is actually an concurrency-unsafe (or concurrency-dangerous if you will :) language, and you can actually crash Elvish by concurrently accessing variables from different goroutines.

Should all variables be guarded by mutexes (in other words, make all variables atoms)?

As far as I know no language does this, but Elvish can probably do it if we are willing to permanently give up performance in favor of safety and ease of use.

If we do this, it makes atomic access to single variables easier, but might end up making atomic access to multiple variables harder too.

Should concurrent access of variables simply be disallowed, and CSP-style concurrency enforced?

Should we keep the core language concurrency-dangerous, and require explicit use of concurrency primitives? Most languages actually do this, but it requires programmers to be careful.

Static type system. A language without any kind of static type system is not likely to be future-proof. I have this vague idea that Elvish should have an optional structural type system much in the style of TypeScript, but there are many details to be figured out.

Should numbers be strings? This might sound like a trivial question, but it's hard to answer.

Answer: they both are and aren't! Design is #816.

If numbers are strings (which is the current case), it means that you cannot convert JSON (or any other serialization format, really) to Elvish value and back and get the same value, because JSON numbers are converted to strings.

If numbers are not strings, should a literal like 42 be a number or a string? This is also hard to answer, because in vim 42, the 42 is definitely a filename and thus a string, but in + 42 2, the 42 is definitely a number.

Maybe we should adopt some kind of sloppiness in this subject, treating numbers like strings (and vice versa) sometimes, but not always. But sloppiness is very hard to get right.

That's it for now; the list will likely grow and shrink over time as I update this post to reflect the status.

Addendum to what's still not right:

A system for classifying errors. Perhaps not so much as a "system", but a coherent guideline. I am mainly familiar with those of Python and Go and neither is exactly satisfying:

Python provides a few "standard" exception types like ValueError and TypeError. However, they are way too vague and don't provide nearly enough signal when it comes to fine-grained error handling. Programmers can also define their own exception types, but there is not much guideline on how to use them.

In Go there are basically two ways you can do errors: 1) build adhoc errors that are basically just glorified messages, via fmt.Errorf or errors.New 2) implement a dedicated type for a class of errors. An example of this is os.PathError. Sometimes, functions are provided to distinguish certain classes of errors from others; an example of this is os.IsPermission. All of these techniques in Go seem to work fine for their specific use cases, but then there isn't much uniformity; programmers are left on their own to decide how to report and classify errors.

Another more interesting question that I haven't "got right" is the ability of defining new types from Elvish code. (There currently isn't any.)

On the one hand, Elvish has maps and lists, which can pretty much carry most shapes of data (never mind efficiency); this is indeed how data in languages like Clojure and JavaScript are typically represented. Maps and lists are easy to understand, inspect and serialize. Behaviors cannot be attached to them; instead, you can write functions that manipulate them.

On the other hand, Elvish has a few builtin custom types, like styled and styled-segment (the type of keys in binding tables are also custom types, but they are not exposed to Elvish code). Those custom types are really just Go structs that implement some methods, which makes sense as this is indeed how you define new data types in Go. They also have some custom behaviors; notably for styled, it knows how to turn itself into ANSI sequences when printed onto the terminal. This is something that maps and lists cannot do unless we introduce something along the line of metatable in Lua.

Another way to summarize this is that there are three different requirements that pull the design in different directions:

Interoperability with Go code -- including, notably, the implementation of builtin facilities. This encourages defining custom types, because Go code typically defines new shapes of data using struct, and new behaviors are implemented as methods of those structs.

Uniformity and simplicity within Elvish. This favors having as few custom types as possible -- use lists and maps for everything.

Go/Elvish code parity. Go code can define custom behavior (styled being the arch-example), Elvish code cannot. This is not a good scenario to be in, as builtin facilities (which are Go code) have access to magic that is inaccessible to Elvish code.

WRT state sharing between concurrent threads - I'd say first implement something simple (an MVP) and later maybe something more complex.
I'd first go for CSP-style channels as that should be quite easy to expose from Go. But ideally I'd probably go for something like V's shared & (r)lock blocks (they can be nested and guarantee safety!) which is presumably more time-consuming to implement.

I'm a bit skeptical about defining new types. I'd prefer the direction "Uniformity and simplicity within Elvish." out of the three choices. I'm too new to grasp everything in Elvish and all the reasons why things in Elvish are as they are but intuitively I'd say such a high-level shell doesn't need any dedicated support of "working with types" in syntax (not even lists/maps/integers/...) as it's anyway futile imagining those thousands of types utilities produce in pipes.
My idea always was to add own "method" (i.e. new functionality) to an existing shell command (thus leveraging its existing implementation details!) which would have a standardized name/API and which would ensure compatibility on demand. On of potential ways how to implement it could be as follows:

each command has to accept pipe data in the most generic format (I'm deliberately not saying what format it is, but I'm sure it has to be extensible at least in compile time as newly defined commands can require new data types which won't fit the existing set of data types the generic format will support) - imagine something like TLV or any other stream-oriented extensible (unlike msgpack/cbor/...) efficient (in terms of native binary data support unlike JSON/XML/...) format like uSX or ston

each command is in addition to (1) encouraged to accept also data in other formats - especially the one format which the command itself finds most efficient to work with (targetting zero-copy)

each command is required to produce pipe data in the most generic format (the same one as in (1) )

each command is in addition to (3) encouraged to produce also data in other formats - especially the one format which the command itself finds most efficient to work with (targetting zero-copy)

at the beginning of the pipe plumbing both producer and consumer will try to find the most efficient way to exchange data

This is to avoid any need for conversion commands in between while at the same time offer run-time detection of the most efficient way to produce & consume data.
Btw. having separate filtering commands as the primary recommended measure to filter data in pipelines might sound very tempting but it actually makes things less composable in practice considering that non-filtering commands will be extended over time which will result in new filtering needs and these will at some point be impossible to satisfy in the generic context of a "filtering command" and will be satisfiable only in the contexts of non-filtering commands.
Another reason is that filtering commands will never be able to efficiently support the special data types and thus everything would in practice just collapse to using the generic format significantly harming performance. Actually this whole idea might be implemented as an extension subcommand for "generic" filtering commands but the "main" implementation would be rooted in the non-filtering command.

which would have a standardized name/API and which would ensure compatibility on demand ... "each command has to accept pipe data in the most generic format"

I think this would be great. Although the concept of a 'pipeline' is the first one greeting us on the elvish home page, most elvish commands are not pipeline aware (why there is a rather cryptic all (one) to feed an each): all and nested each tare required to get pipelines working across commands. Being more pipeline friendly would make elvish more expressive, see for example nushell which has really expressive and semantically obvious pipelines: df | detect columns | drop column | into filesize 1K-blocks Used Available — @xiaq — you don't mention it above so it seems you prefer for the elvish design to be a pipeline-optional approach rather than a pipeline-first approach?

Python provides a few "standard" exception types like ValueError and TypeError. However, they are way too vague and don't provide nearly enough signal when it comes to fine-grained error handling.

I was surprised and disappointed when I learned that ValueError doesn't even have an attributes (passed as optional argument) for the value that caused the ValueError!


Fix typo in api versioning documentation

1. Why is this change necessary?
2. What does this change do, exactly?
Fixes a typo in the api versioning documentation.
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Checklist

[ ] I have written tests and verified that they fail without my change
[X] I have squashed any insignificant commits
[X] I have written or adjusted the documentation according to my changes
[X] This change has comments for package types, values, functions, and non-obvious lines of code
[X] I have read the contribution requirements and fulfil them.

Hi @hanneswernery

True.
I just fixed that.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-7798
Please use this issue to track the state of your pull request.

@hanneswernery Github still says "Pending — Contributor License Agreement is not signed yet."
I can not import your PRs until the CLA is accepted due to legal reasons.
Please accept it here
Sunny regards
pantrtxp

Hmm I tried again. Maybe now?

Thank you for your contribution :blue_heart:


3.0 rc.11 - Classes not being merged from parent to child component (in client-only components)

Environment
Nuxt CLI v3.0.0-rc.8
RootDir: /Users/samh/Sites/reelcrafter/v2-presentation
Nuxt project info:

Operating System: Darwin
Node Version:     v16.16.0
Nuxt Version:     3.0.0-rc.8
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      -
Runtime Modules:  -
Build Modules:    -

Reproduction
https://stackblitz.com/edit/nuxt-starter-lzssqp?file=app.vue,components%2FHowdy.client.vue,components%2FTest.vue
Describe the bug
Classes are not being merged properly into the child component's root div. This was working fine in RC8.
In the reproduction, note how the app-vue class is missing from the Howdy component root. This only seems to be an issue with .client.vue components, not components wrapped in <client-only>.
Additional context
No response
Logs
No response

Hey @danielroe it seems i still got this issue in the latest version 3.5.3 of nuxt, the example is a bit different but result is the same, it's not merged:
https://stackblitz.com/edit/nuxt-starter-mavf4s?file=components%2FTest.vue
Should i open a new issue ?

Yes, please! 🙏

Done !


An error occurred in filling in the author in the publication.

As shown in the figure below

Change detected, rebuilding site.
2020-10-12 14:47:46.912 +0800
Source changed "/Users/obsidian/资料/starter-academic/content/publication/sci_1/index.md": WRITE
ERROR 2020/10/12 14:47:46 render of "page" failed: execute of template failed: template: publication/single.html:5:5: executing "main" at <partial "page_header.html" .>: error calling partial: execute of template failed: template: partials/page_header.html:90:7: executing "partials/page_header.html" at <partial "page_metadata" (dict "page" $page "is_list" 0 "share" true)>: error calling partial: execute of template failed: template: partials/page_metadata.html:11:7: executing "partials/page_metadata.html" at <partial "page_metadata_authors" $page>: error calling partial: "/var/folders/t9/v0nvt0mn2vzgrr7jw2mx3fdm0000gn/T/hugo_cache/modules/filecache/modules/pkg/mod/github.com/wowchemy/wowchemy-hugo-modules/wowchemy@v0.0.0-20201008203720-98d093a07301/layouts/partials/page_metadata_authors.html:6:30": execute of template failed: template: partials/page_metadata_authors.html:6:30: executing "partials/page_metadata_authors.html" at <.GetTerms>: can't evaluate field GetTerms in type *hugolib.pageState
ERROR 2020/10/12 14:47:46 render of "home" failed: execute of template failed: template: index.html:21:5: executing "main" at <partial "widget_page.html" .>: error calling partial: execute of template failed: template: partials/widget_page.html:103:9: executing "partials/widget_page.html" at <partial $widget_path $widget_args>: error calling partial: execute of template failed: template: partials/widgets/featured.html:64:11: executing "partials/widgets/featured.html" at <partial "li_card" .>: error calling partial: execute of template failed: template: partials/li_card.html:40:7: executing "partials/li_card.html" at <partial "page_metadata" (dict "page" $item "is_list" 1)>: error calling partial: execute of template failed: template: partials/page_metadata.html:11:7: executing "partials/page_metadata.html" at <partial "page_metadata_authors" $page>: error calling partial: "/var/folders/t9/v0nvt0mn2vzgrr7jw2mx3fdm0000gn/T/hugo_cache/modules/filecache/modules/pkg/mod/github.com/wowchemy/wowchemy-hugo-modules/wowchemy@v0.0.0-20201008203720-98d093a07301/layouts/partials/page_metadata_authors.html:6:30": execute of template failed: template: partials/page_metadata_authors.html:6:30: executing "partials/page_metadata_authors.html" at <.GetTerms>: can't evaluate field GetTerms in type *hugolib.pageState

This is not a bug. For questions, please on the Q&A forum: https://github.com/wowchemy/wowchemy-hugo-modules/discussions
The message indicates that you may be using an incompatible version of Hugo Extended (before Hugo team released the GetTerms feature) - try updating your Hugo Extended version.


NavigationAgent2D/3D.get_nav_path() returns stale path

Godot version
3.5 beta, master
System information
NixOS
Issue description
When NavigationAgent2D.get_nav_path() (or 3D) is executed, it returns a stale path unless update_navigation() is called first, and update_navigation() isn't exposed to GDScript -- this can for example result in confusing implicit behaviour where nothing is navigating if one relies on get_nav_path() exclusively. Should one of these options be considered?

update_navigation() should be called in set_target_location()
get_nav_path() should call update_navigation()
update_navigation() should be exposed in GDScript

I'm happy to submit a PR and update docs if necessary.
Relevant files

https://github.com/godotengine/godot/blob/0f5455230c8955be0c6533574bd3d5b6f50792b6/scene/2d/navigation_agent_2d.cpp
https://github.com/godotengine/godot/blob/0f5455230c8955be0c6533574bd3d5b6f50792b6/scene/3d/navigation_agent_3d.cpp

Steps to reproduce

Call .get_nav_path() without first calling get_next_location, get_final_location, or is_navigation_finished().

Minimal reproduction project
No response

CC @godotengine/navigation @Scony

From the code it looks like it should be fairly safe to call update_navigation() in set_target_location(). @Shou can you create such a PR and annotate me?

@Scony made the PR now ^

A function to receive the full path without triggering any updates is required for many use case like debug draw or other sophisticated navigation behaviour.
Maybe this is a function naming issue but for me get_nav_path() always was supposed to serve a full "stale" path and NOT to do updates. The docs clearly state "Returns the path from start to finish in global coordinates." so please consider that is all I (and maybe others) would expect it to do without side effects.

Note that if you want to move an actor manually like in old Godot you do not need to use a NavigationAgent Node.
You can use NavigationServer2D.map_get_path(get_world_2d().get_navigation_map()) from any Node2D inheriting Node (or same with 3D) to get a fresh path array.


reloading the editor stops intercepting but that isnt obvious to the user

relading the popup closes the debugger session, but that's super not obvious
we should close the window probably

maybe reloading the editor should reload the tab inspected?

https://github.com/google/tamperchrome/commit/536dd8260966b67d3f233cfccbeb7aee969209ae


Merge fromdevelop

Note: The default GitHub diff makes this look worse than it is. Compare with &w=1 on the end of the URL to ignore whitespace and see a much saner diff.

@pharring,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


SAML configuration at org authentication

If we want support for SAML at the SaaS we need to configure it here.
Check roadmap with @xavijam and @javisantana .
See #11108.

Closing automatically because of inactivity. If anybody considers that this still important, please reopen and it'll be prioritized.


Build a packaging script

Adapt script
Make docker

A script build-prod.sh is now available

Docker is transferred as a new issue


Incomprehensible Audio generated by GL-vocoder at 169K Iterations

Hi, I have trained a model after 169K Iterations by tacotron2 with batch-size=8 on a 1080TI GPU. The training data is LJ-speech. But I get  incomprehensible Audio synthesized by GL-vocoder on this model.  The text to be synthesized is "All the wardsmen alike were more or less irresponsible."

The synthesis waveform is incomprehensible.
165k.zip

What is your training and validation loss?

@rafaelvalle , I am sorry I am a novice in pytorch. How can I get the training and validation loss from the  log file or check-point file? How to draw the training and  validation curves? Could you give me some guides? Thank you in advance!

@NewEricWang You can use tensorboard:
tensorboard --logdir=outdir/logdir

@deli666, Thank you very much!
@rafaelvalle, My training and validation loss curves are as follows:

@NewEricWang The tensorboard plot you shared goes only up to 50k iterations and did not learn attention. Synthesis should start working when the model learns attention, i.e. the alignment plot shows a diagonal line.

@rafaelvalle , Thank you very much! I get it. So I will wait until the alignment plot shows a diagonal line.


feat: support date and time

Support DataTypes of Date and Time, close issue:https://github.com/CeresDB/ceresdb/issues/194

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


init: sd at 0.5.0

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Note on the relevant documentation -
sd doesn't seem to build man pages yet

@Amar1729 your commit msg should be formatted like
sd: init at 0.5.0

https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes
(pkg-name): init at version

@GrahamcOfBorg build sd

welp that's embarrassing :/


How to handle login session correctly?

When I use ly to log in and start X for me, I can't see my session in w or who command outputs. It brings problems together with policykit where all the default rules concerning suspend or hibernate are bound to local sessions only.
I wasn't figure out whether I am able to force local login session through xsetup.sh or PAM. Can you help?

Same issue. Login with sddm and ly makes different situations.  Command w returns nothing. Due to the problem range of the other programs doesn't work correctly.

@jkrcma @evgenux I opened a PR which should fix this for you, please see whether it does - https://github.com/cylgom/ly/pull/133

Thank you a lot, @stlaz! With #133 login session starts well on my pc. Even my clipmanager, which depends somehow on it, functionate properly.

Thank you a lot, @stlaz! With #133 login session starts well on my pc. Even my clipmanager, which depends somehow on it, functionate properly.

But I noticed another related issue: when I terminate awesome wm (or qtile), a wallpaper remains and I can't get to ly again.

If it’s related only to this fix, it might be caused by https://github.com/cylgom/ly/pull/133/files#r339329964. I haven’t tested this with xserver yet, actually.

Yes, it is: I can't get back to ly only with #133. But without your patch range of programs doesn't work: for example connman rejects to work and prints Error getting services etc.

With patch #133 ecryptfs-add-passphrase doesn't work.


interactive bots: Create Alert bot.

Hi mentors !
I've been working on this bot for a while and I think it could be really useful in the future.
Bot description:
Name: Sched
Sched let's you setup a reminder for anything you need, or even trigger other bots at specific times.
It have three commands.

Schedule an alert on a cycle. Every N time units trigger a Job.
Syntax is:
@every [int] [time_unit] Your_reminder
@every [int] [weekday] at [hour] Your_reminder
This command could be used with other bots, for ex:
Have a bot greet the users everyday with a different message.

Schedule one event once.
Syntax is:
@at [weekday] [hour] Your_reminder

Cancel a cyclic event.
Every cyclic event have a tag, this commands clears all events from an specific tag.
If more than one event belongs to the same tag, all events in that category will be deleted.
Currently tasks are assigned randomly from a number 1 to 1000000, ideally we would have UUID or something similar.

Also, the hour parameter is currently not the hour that appears at the zulip chat, it is the server hour.
To get open python: import datetime datetime.datetime.now()
I would love to know how does zulip gets the hour that appears when I send a message so that I can translate timezones for the bot.
All of this are minors fixes that can be done relatively easy, but currently there is something I haven't been able to figure out by my own.
So far the bot falls into something like an infinite loop and is just able to schedule one task.
This is probably because of the way the class is initiated and this code at the end of the class might need to be somewhere else.
    while True:
        schedule.run_pending()
        time.sleep(1)

I've tried working with Queues and ended up losing myself in the code, so if you can find what happens here I would really appreciate it.

Automated message from Dropbox CLA bot
@Juanvulcano, it looks like you've already signed the Dropbox CLA. Thanks!

@Juanvulcano, you need something for persistence as well. Currently, all your reminders will be lost if your bot is stopped.

Update:
I had to came up with a somewhat original solution, to have a task being verified every X time I had to generate a new message. So I just had to tweak a little bit my initial bot and add a new schedule.run_pending() so that it is constantly up.
So we now have 2 bots.
Keepalive.py and Sched.py
Setup instructions:
To have this working first of all you will need to run the keepalive.py file as any bot, go to chat.zulip and type @every 1 minute keepalife or @every 1 hour keepalife depending on your needs.
After sending the message, you can now run the sched.py bot in another tab without closing the keepalife bot. Now this should work for every task you want to schedule.
Now the only problem is the persistence.
Every event is recorded on the events.p file, but for some strange reason unrelated to pickle decoding, when I setup again the events with the @recover command, messages are treated all as the last message of the events.p list but have their original properties.
Why this is being caused?
I think that when I run the @recover command and try to schedule a task, it is limited to one task per recover. So maybe I need to have something like @recover [int] for every alert in events.p, but I've been unable to identify the best solution. I would really appreciate if you could try to find this bug so that we are able to have a persistent scheduler 👍
:)

I worked a way around with a recursive chat function, to recover all the commands just run in the chat.
@recover 0
ALSO, you need to create an alert stream. All reminders will go to that stream.

@Juanvulcano, I think you are on the right track; I would also do this with two separate processes. I think instead of creating a new bot, you can start a new thread in sched.py. Break this problem into two parts:

Bot which creates events in a JSON file.
Extension to your bot to start sending alert messages to Zulip.

First part is easy. It is a simple bot which receives the message from Zulip and creates an alert entry in 'events.json' file. Yeah, I would recommend a JSON file over Pickle because you can read JSON and ascertain if your code is working correctly.
For second part you need to look at threading module of Python. Basically you will write a function like this:
def event_handler():
   while 1:
      # Add your scheduling code here
      time.sleep(1)  # sleep for 1 second

and start this function in a separate thread. This function will wake up every 1 second and run your scheduling code.
Some observations:

Do not change run.py.
Get rid of @recover message. Whenever you restart your bot it should recover the alerts automatically.

Hope this is helpful. This is an awesome task. Something that I'd like to do myself :).

Hi ! I was finally, able to get the multi-threading working all within the same file and changed pickle with json. However, as the bot is currently designed it is not possible to trigger the @recover command when the bot is started, as it will require a client that only gets passed down to the function once a message have been sent. The current wake-up interval is once every 5 seconds.

Doesn't the api provide any way for initialisation?
On Saturday, December 17, 2016, Juanvulcano<EMAIL_ADDRESS>wrote:

Hi ! I was finally, able to get the multi-threading working all within the
same file and changed pickle with json. However, as the bot is currently
designed it is not possible to trigger the @recover
https://github.com/recover command when the bot is started, as it will
require a client that only gets passed down to the function once a message
have been sent. The current wake-up interval is once every 5 seconds.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/zulip/zulip/pull/2680#issuecomment-267759014, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAnK47ytgH766v_wH3G17s2Ppz617PaWks5rI87GgaJpZM4LLXDc
.

--
Sent from mobile.

@umairwaheed I wouldn't be able to tell. The only solution I could think of is modify run.py so that the usage function gets a client, but that still doesn't sound good. Maybe someone with a better understanding of the api can answer that? @showell @timabbott

So bot handler is a Python class. May be you can use this fact?
On Saturday, December 17, 2016, Juanvulcano<EMAIL_ADDRESS>wrote:

@umairwaheed https://github.com/umairwaheed I wouldn't be able to tell.
The only solution I could think of is modify run.py so that the usage
function gets a client, but that still doesn't sound good. Maybe someone
with a better understanding of the api can answer that? @showell
https://github.com/showell @timabbott https://github.com/timabbott
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zulip/zulip/pull/2680#issuecomment-267759584, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAnK47J41ZtQphbsALRt6bF8FicTbCsoks5rI9JKgaJpZM4LLXDc
.

--
Sent from mobile.

Hi guys! I listened to your feedback, I was able to have the @recover command run automatically at the beginning. I also added a config file. Minimum timeout for the config is 1 second, but it's actually 5 seconds on the bot. All the other values are given in base of this timeout in order for the bot to function properly.

I created a new function on run.py. I noticed that it was not possible to have a bot send a message when it was initialized, so this function is meant to do that.

@Juanvulcano, why not use __init__ function of a Python class?

@Juanvulcano, you are almost there. Some more feedback added.

@umairwaheed One reason not to do too much in __init__ is that some people like the convention that creating an object doesn't have any major side effects like sending messages.  Also, we have a separate proposal for doing some other things at startup, such as accepting new command line options, so we need to figure this out as well.

Cool. We do need something in our API for initialisation though.
On Monday, December 19, 2016, showell<EMAIL_ADDRESS>wrote:

@umairwaheed https://github.com/umairwaheed One reason not to do too
much in init is that some people like the convention that creating an
object doesn't have any major side effects like sending messages. Also, we
have a separate proposal for doing some other things at startup, such as
accepting new command line options, so we need to figure this out as well.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zulip/zulip/pull/2680#issuecomment-267985768, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAnK42YbaoYV0Gs0e9IpvUv_czFs4cejks5rJpyzgaJpZM4LLXDc
.

--
Sent from mobile.

I think that dealing with how to initialize might be a little out of the scope of this task. I updated the changes for the loop in a different thread 👍and with the init function.
:) Thanks for guiding me ! @umairwaheed @showell
I would really like to start with more tasks asap though.

@Juanvulcano I am going to close this PR without merging it.  You can move on to another task.  We may come back to this eventually.


[RequestMock] Add a warning with a clear message when CORS validation is failed

I'm testing to mock a remote API endpoint (http://remote-api.com/api/auth?user_type=customer) that is being called with "isomorphic-fetch" when filling a form and clicking in a simple submit button. It seems that the mock is returning HTTP status 222. Does this means it can be a CORS issue? Or a bug of the RequestMock?
Tested page URL: http://localhost:3000/
Test code
const mock = RequestMock()
  .onRequestTo('http://remote-api.com/api/auth?user_type=customer')
  .respond({
    result: null,
    errors: [
      {
        message: 'Incorrect username or password.',
      },
    ],
  });

fixture('As a customer I want to be able to sign in')
  .page('http://localhost:3000/login')
  .requestHooks(mock);

test('Login with incorrect credentials', async (t) => {
  await t
    .typeText(Selector("input[name='email']"<EMAIL_ADDRESS>    .typeText(Selector("input[name='password']"), 'password')
    .click(Selector("input[type='submit']"));
  const location = await t.eval(() => window.location);
  await t.expect(location.pathname).eql('/login');
});

operating system: Mac OS X 10.13.4
testcafe version: 0.20.0
node.js version: 8.11.1

By adding nock as dependency and .reply(200, jsonMockedResponse, { 'Access-Control-Allow-Origin': '*'}); the request was correctly intercepted. But it means there must be some bug with RequestMock.

Hi @davidcunha
Yes, your are right. It's a CORS issue. You need to change your code as follows:
const mock = RequestMock()
  .onRequestTo('http://remote-api.com/api/auth?user_type=customer')
  .respond({
    result: null,
    errors: [
      {
        message: 'Incorrect username or password.',
      },
    ],
  }, 200, {'Access-Control-Allow-Origin': '*'});

From our side we will add a warning with a clear message for this case.

I am working on it


Update sbt-native-packager to 1.9.9

Updates com.github.sbt:sbt-native-packager from 1.9.6 to 1.9.9.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.github.sbt", artifactId = "sbt-native-packager" } ]

labels: sbt-plugin-update, early-semver-patch, semver-spec-patch, commit-count:1

Codecov Report

Merging #376 (d691406) into main (df19298) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #376   +/-   ##
=======================================
  Coverage   59.87%   59.87%
=======================================
  Files          30       30
  Lines         987      987
  Branches       64       64
=======================================
  Hits          591      591
  Misses        396      396

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df19298...d691406. Read the comment docs.

Superseded by #400.