(URGENT) ISO 10303-52: Figure within EXAMPLE is missing "Figure nn" caption

This is from ISO 10303-52:
[example]
====
<<fig21>> illustrates a 1-to-1 abutting interface, also referred to as matching or C0 continuous. The interface is a plane of vertices that are physically coincident (i.e., they have identical coordinate values) between the adjacent meshes; mesh-coordinate lines perpendicular to the interface are continuous from one mesh to the next. In 3-D, a 1-to-1 abutting interface is always a logically rectangular region.

[[fig21]]
.A 1-to-1 abutting interface
image::fig21.png[]
====

This is counted as "Figure 21" internally -- Figure 20 is present, and the next numbered figure is Figure 22.

However, it is not rendered as such.
This is the original:

Compare:

I have a good reason for not captioning figures embedded inside of other things—if you're referencing this from outside, you're actually referencing the example and not the figure. We did originally allow captioning of figures within tables, and it was a horror film (and did not correspond to desired markup).
I could make a rule that figures can be captioned numbered within tables and not figures, but frankly I'd rather use a %numbered vs %unnumbered option, and a rule: figures embedded within other assets are by default unnumbered, unembedded figures by default are numbered, and you override that with %unnumbered (already implemented) or numbered.
@ronaldtse?

The real problem here is logical inconsistency with the missing number of "Figure 21". This is the same issue we encountered at OGC. If the system "numbers" every figure but hides it in the caption titles, a reader has no way of referring to the Figure.
Logically, if we take the typical behavior of NOTEs in a clause, the NOTE is numbered according to the clause itself, not taking into the location hierarchy of the NOTE itself (e.g. NOTE in the clause or a NOTE within a list item in the clause).
Similarly, a Figure is numbered in an ISO document with a scope of the document itself, i.e. the location of the Figure in the content hierarchy (e.g. in a Table or in an Example) is not relevant to its title captioning.
If we wanted to hide the Figure caption, %unnumbered should then be used, but by default the Figure reference in the caption should be shown.

If we wanted to hide the Figure caption, %unnumbered should then be used, but by default the Figure reference in the caption should be shown.

I think this is going to be disastrous, but I'll be very happy to point the finger when it does. OK then, numbering embedded figures unless they are explicitly unnumbered, and including the numbering in captions.

HTML:
PDF:

The caption "Figure 21" is still missing from the figure...

Needed to remove inherited instances in metanorma-iso and metanorma-bipm

Confirm fixed. Thanks!


Training Phrases missing on getIntent

The getIntent response value and the listIntents response always reads an empty array for its trainingPhrases value.
Environment details

OS:
Node.js version: 10.15.3
npm version: 6.9.0
dialogflow version: 0.10.3

Steps to reproduce

call getIntents on an intent with training phrases listed in console

Ah did not set the IntentView. Closing.

this is still an issue, any fix for it?

in case somebody else has same issue, request should include intentView with value 1 to return trainignPhrases
        const request = {
            parent: projectAgentPath,
            intentView: 1 // INTENT_VIEW_FULL
        };


Code Quality: Update code structure

Code Quality: Update structure of the projects
Motivation & Context

Improved readability

WarningPlease do not review code lines that I did not changed. I cannot make more diff. If there're more codes that are preferred to change, I will do that and mark that PR as the final one for that stage.

PR Checklist

[x] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Related #11419
Related #4180
[x] Did you build the app and test your changes?
[ ] Did you check for accessibility? You can use Accessibility Insights for this.
[ ] Did you remove any strings from the en-us resource file?

[ ] Did you search the solution to see if the string is still being used?

[ ] Did you implement any design changes to an existing feature?

[ ] Was this change approved?

[ ] Are there any other steps that were used to validate these changes?

Screenshots

Reverted all of them that you mentioned. I will do them in project file improvement.


[Thanos Rule] Rules Files not reloading after SIGHUP signal

Thanos, Prometheus and Golang version used:
thanos, version 0.21.1 (branch: HEAD, revision: 3558f4a5adc8d4068f82528570a439d440f98b9d)
build user:       root@744cf7ef4576
build date:       20210604-12:11:58
go version:       go1.16.5
platform:         linux/amd64
What happened:
After rule files update, a SIGHUP signal is sent to Thanos in order to reload the rules in run time. The rule files update is no applied by Thanos Rule, keeping applying the same rules as when Thanos was started.
By restarting  the Thanos  process the rules are updated.
What you expected to happen:
Thanos should reload the rules at runtime after receiving SIGHUP signal, with no need to stop and start the Thanos process.
How to reproduce it (as minimally and precisely as possible):
Run Thanos Rule with minimal configuration and a basic and valid rule_test.yaml file:
thanos rule --log.level debug --log.format logfmt --http-address <IP_ADDRESS>:10902 --http-grace-period 2m --grpc-address <IP_ADDRESS>:10901 --grpc-grace-period 2m  --data-dir ./data --rule-file './*.yml'  --resend-delay 1m --eval-interval 30s --tsdb.block-duration 2h --tsdb.retention 2d  --query thanos-query.domain :20902
Access UI and check that rules defined in rule_test.yamls file are being applied.
Add a new rules file (rule__test_2.yaml) to the same folder.

Full logs to relevant components:
After sending the SIGUHP this is the log:
level=info ts=2021-07-09T15:43:27.658638469Z caller=main.go:180 msg="caught signal. Reloading." signal=hangup
level=info ts=2021-07-09T15:41:04.904147954Z caller=main.go:183 msg="reload dispatched."
level=debug ts=2021-07-09T15:43:49.605131566Z caller=promclient.go:398 component=rules msg="querying instant" url="http://<IP_ADDRESS>:30902/api/v1/query?......
Anything else we need to know:
Tested other Thanos versions, and the last version where it worked properly was  v0.19.0.
Following the same steps with v0.19.0 the rules files are reloaded. The log is different, and its reporting that  rules files are being loaded:
level=info ts=2021-07-09T15:41:04.904087152Z caller=main.go:180 msg="caught signal. Reloading." signal=hangup
level=info ts=2021-07-09T15:41:04.904147954Z caller=main.go:183 msg="reload dispatched."
level=debug ts=2021-07-09T15:41:04.904165954Z caller=rule.go:820 component=rules msg="configured rule files" files=./*.yaml
level=info ts=2021-07-09T15:41:04.904271701Z caller=rule.go:843 component=rules msg="reload rule files" numFiles=2

Possible workaround until it's fixed is triggering reload by calling http endpoint: curl localhost:10902/-/reload -X POST.

I was able to track down this pr which introduces the bug. I was also able to fix it in my branch. With this change  reloading using sighup works for me again.

Possible workaround until it's fixed is triggering reload by calling http endpoint: curl localhost:10902/-/reload -X POST.
I managed to reproduce the issue locally and the reloading trough the http endpoint still works.

Yes, the workaround works.
Thanks 👍

Fixed by https://github.com/thanos-io/thanos/pull/4442. It's now covered by tests so it's working 100% :muscle:


Prerequisites

[X] I have searched all issues/PRs to ensure it has not already been reported or fixed.

Criteria

[X] Reasonably well-known and widely used (e.g. if it's a GitHub project, it should have at least 100 stars and/or 50 forks)
[X] English interface (or at least English documentation)
[X] Latest stable version
[X] Full version (i.e. not a trial version)
[X] Fairly standard install (e.g. uses a version-specific download URL, no elaborate pre/post install scripts)

Name
Coinomi
Description
Securely store, manage and exchange Bitcoin, Ethereum, and more than 1,770 other blockchain assets.
Homepage
https://www.coinomi.com/en/
Download Link(s)
https://www.coinomi.com/en/downloads/
Some Indication of Popularity/Repute
https://www.fool.com/the-ascent/cryptocurrency/coinomi-wallet-review/

Hi,
You can install it from my bucket by running the following commands:
scoop bucket add naderi https://github.com/naderi/scoop-bucket
scoop update *
scoop install coinomi

Thank you very much, but i stll think that including that in the one of the official buckets would be awesome too :)


Changed version number from 5.6.22 to 5.6.26

Tested on clean pfSense install with no issues.

Thank you!


Increase vm alive retry count to allow longer network setup in the VM after boot

Fixes #64

duplicate with #86


POC: Zip Archive Library

I would like to start by contributing an archive library. What does everyone think of the following DSL?
Archive::Zip.open("foo.zip") do |zip|
  # Set File
  zip.write("sample.txt", "contents")

  # or maybe also ...
  zip["sample.txt"] = "contents"

  # Set File with Permissions
  zip.write("sample.txt", "contents", 0755)

  # Set File from IO
  zip.write("sample-2.txt", File.open "sample.txt")

  # Add file to zip, as is with the current name
  zip << File.open("sample-3.txt")

  # Shorthand of above
  zip << "sample-3.txt"

  # Change directory
  zip.dir "foo" do |dir|
    # Adds a file at the directory
    dir << File.open("sample-3.txt")
  end

  # Read all files from a zip
  zip.each do |file|
    puts file.name
    puts file.read
  end

  # Get filenames
  puts zip.list_files

  # Get file by name
  puts zip.read("sample.txt")

  # change directories and list files
  zip.dir "foo" do |dir|
    puts dir.list_files
  end
end

Looks good enough for a first iteration. A couple of points:

Should it take a mode flag to open for reading, writing? If yes, what should be the default mode?
Should dir be mandatory, or should / inside filenames be interpreted? How to add a file with a / in its name if the latter?
Not all archive formats support file permissions, should we raise when trying to set one in these cases?
How can we encourage File.open(..) { zip << io } and similar patterns to avoid FD leakage?
Do we want a convenience API for writing a file step by step without having to create the StringIO or IO.pipe yourself?
What backend library should we choose? libarchive?

But I'm not saying all of these need to be addressed for a first iteration ;)

 # Avoid fd leaks.
 # Add file to zip, as is with the current name
 File.open("sample-3.txt") { |file| zip << file }

Something missing is an IO compatible writer for generated content.
  zip.open("a/b/file.txt", "w") do |zfile|
    10.times { zfile.puts "hello" }
  end

With a IO compatible write object you can implement most other functionality.
  def write filename, data
    zip.open(filename, "w") { |zfile| zfile.write data }
  end

Hi!
Note that there's this: https://github.com/datanoise/zlib.cr
I'd really like to integrate that into the standard library, zlib is super standard and useful.

(though I'm not sure if a zip archive and zlib are related :blush:)

They aren't, zlib is merely compression (gzip & LZMA is supported iirc). Then you have archive formats like tar which describe how to pack a file/folder tree into a single file. Things like zip, rar, 7z and so on define both in one, an archive format and a compression algorithm.

@jhass I would say that changing directory is not required. You can specify full path of the file in a given archive. Some may just want the ability to have the dir method as a convenience.

@asterite my plan was to integrate zip first and then tackle some of the other archive formats. It would be great if they all followed the same format.

@jhass
Re: dir: I would say that changing directory is not required. You can specify full path of the file in a given archive. Some may just want the ability to have the dir method as a convenience.
Re: Permissions: ZIP does support permissions, in the case of other formats, I would say that we simply would not have the argument.
Re: File.open {}: I agree here, although this would be user choice is should be documented as the preferred way.
Re: Convenience API: Great question, I would lean toward a convenience API as long as its portable between archive formats.
Re: Library: I was looking at lib archive. But I was also debating going the pure crystal route. Golang was able to do theirs natively.

One other note:
Zips can be written to any IO. It does not have to be a file. The open command calls out to a file and opens it with the proper mode.
Archive::Zip.new(io : IO) do |file|
  # Do Something
end

I'd just like to point out that maybe ZIP, TAR, etc. archives are outside the scope of the stdlib, especially if they rely on an external C library. That being said, it would make a great library for the language!

@ysbaddaden ... why? I think it can be built natively in crystal without requiring a c library. It is in the stdlib in Go... So why can't it be in crystal? Here are some examples:
http://golang.org/pkg/archive/zip/

It's in Python's stdlib, too.

@jwaldrip The IO object would need to support seek, so not any IO can be written to.

@jwaldrip I said "maybe" :)

Re: dir +1 to support "foo/bar.txt" as a filename in a dsl.
Some of you already know, but I would vote to tackle a DSL and abstraction for FS on one side and archive/zip functionality in another.
I think there is value in an abstract FS api. It can be used later for testing with in memory or embedding fs in an app. There was an experiment of that was removed but removed meanwhile to avoid polluting the stdlib without some further discussions.

there is value in an abstract FS api

:+1:

Python stdlib isn't the best think to take examples from.

@Nakilon Why not?

I'm closing this. What can be done for now is create a separate shard. If the shard matures and has a good API and performance it can be eventually merged into the standard library.


Missing startup documentation

What?
Viewing this app for the first time and starting up in isolation (to resolve an a11y issue) it's not clear that the typical Frontend startup process outlined in the docs does not apply to this app.
In order to startup this app and to be able to move through example pages and have them render, this app has to be started using Docker and the --live flag.
$ govuk-docker up email-alert-frontend-app-live
Why?
Without starting the up via this method, the app from a Frontend POV is unusable and you run into many errors.
Eg you cannot use /.startup.sh or docker without live data.
PR conversation with @kevindew around updating the README advised that it would be more desirable to get consensus with startup documentation across many apps and is most likely a wider topic. Updating docs as suggested above would be misleading and would age badly

Thanks for turning this into an issue @chris-gds

Viewing this app for the first time and starting up in isolation (to resolve an a11y issue) it's not clear that the typical Frontend startup process outlined in the docs does not apply to this app.

By this process do you mean: https://docs.publishing.service.gov.uk/manual/local-frontend-development.html ? and if so I'm not sure why it didn't apply as I think it should?

I think the thing that is a bit fishy is that very few GOV.UK app readme's have a "Running the application" the application section, and the lack of one suggests that someone forgot to add it, rather than it purposely isn't there. Indeed, it was only recently removed as the information was out of date.
If we're able to reach a resolution on this issue, it'd be good if it was something that could apply across various GOV.UK Docker apps so we'd want something simple that could be repeated.
Personally I'd be happy with something like:
### Running the application

This application is designed to be run within the [GOV.UK Docker](https://github.com/alphagov/govuk-docker) development environment.  You can also [run this application in isolation](https://docs.publishing.service.gov.uk/manual/local-frontend-development.html#using-startup-scripts) for frontend development.

I'd want to keep anything we put brief to reduce the risks of information falling out of date.
@benthorner, as someone involved in the previous removal, what are your thoughts?

Thanks for tagging me @kevindew.
@chris-gds I'm nor sure I understand the problem. Could you help me understand what's wrong?

By this process do you mean: https://docs.publishing.service.gov.uk/manual/local-frontend-development.html?

Yes

and if so I'm not sure why it didn't apply as I think it should?

This is because the docs within this link read:

If you are making changes to a frontend app and nothing else, you can view these changes by running the application's ./startup.sh script.

This is not applicable to this application to run in isolation, even if you wish to only update the frontend you have to use Docker  --live.

Indeed, it was only recently removed as the information was out of date.

This makes sense as ./startup.sh does not apply to this app, only govuk-docker up email-alert-frontend-app-live realistically applies to work on this app

Personally I'd be happy with something like:

### Running the application

This application is designed to be run within the [GOV.UK Docker](https://github.com/alphagov/govuk-docker) development environment.  You can also [run this application in isolation](https://docs.publishing.service.gov.uk/manual/local-frontend-development.html#using-startup-scripts) for frontend development.

It's pretty close, however I wouldn't say the last sentence is accurate as it could be. By clicking this link a user could easily follow the startup.sh process as this is listed first and there is nothing to suggest this process would not apply to this app.
In order to correctly make changes to this app's Frontend I would have found something like this helpful:
### Running the application

This application is designed to be run within the [GOV.UK Docker](https://github.com/alphagov/govuk-docker) development environment using the `--live` flag.

I reference the --live as this documentation suggest several different methods
My ideal update would be something like:
### Running the application

This application is designed to be run within the [GOV.UK Docker](https://github.com/alphagov/govuk-docker) development environment.

`govuk-docker up email-alert-frontend-app-live`

## Troubleshooting

 (`startup.sh` does not apply to this app)

@benthorner
As part of this PR there was a request to update the README to ensure the guidance around starting up this app in isolation from a Frontend POV was clearer and faster.   It was discovered there are some nuances to this particular app which means that more global documentation does not apply quite the same.
It was decided this might be a larger topic and to extract out the README update into an issue to reach a consensus.

@chris-gds thanks for the handy summary! I understand the problem now. We should bear in mind that the "live" way of running apps is just a convenience. In theory, any developer can also have a local copy of data and just develop against that. So we shouldn't be too prescriptive about how to run a given app. I use a mixture of both, for example.
My preference is that we should avoid repeating the same instructions in every app, and refer to the usage guidance in GOV.UK Docker. While it's longer, it saves time versus maintaining different/redundant instructions for each app.
### Running the app

See the usage instructions in [GOV.UK Docker](https://github.com/alphagov/govuk-docker#usage).

It also sounds like we can also delete the startup.sh script for this app, since GOV.UK Docker doesn't rely on them (it's something of a smell that so many other apps still have them).
I guess there's still some ambiguity if someone is coming from the dev doc. We could fix this by adding "these instructions apply to any frontend app...with a startup.sh script".
Would that have been enough to help you at the time?

I understand the problem now. We should bear in mind that the "live" way of running apps is just a convenience.  In theory, any developer can also have a local copy of data and just develop against that.

I'm not sure a local copy of the data is always required or even desirable (eg in this context and to run in isolation)

So we shouldn't be too prescriptive about how to run a given app. I use a mixture of both, for example.

Me too, I partially agree - you should be free to choose the startup method that suits, however in this context I think the number of choices is reduced.  (Possibly to one?  Can you start up this app in isolation another way?)

My preference is that we should avoid repeating the same instructions in every app, and refer to the usage guidance in GOV.UK Docker. While it's longer, it saves time versus maintaining different/redundant instructions for each app.

Would this apply to the test snippet as well? $ bundle exec rake could this be moved to more global documentation?

It also sounds like we can also delete the startup.sh script for this app, since GOV.UK Docker doesn't rely on them (it's something of a smell that so many other apps still have them).

Potentially this could resolved the opposite way with ./startup.sh --live working as expected within this app? I think from the previous conversation and the comment, that this is classed as a smell, that this method is wished to be phrased out long-term..

I guess there's still some ambiguity if someone is coming from the dev doc. We could fix this by adding "these instructions apply to any frontend app...with a startup.sh script".

I think it's better.  I'm not sure it's ideal from a Content POV - I'm wondering how many FE apps can't be used with ./startup - is it just this one?

Would that have been enough to help you at the time?

I'm thinking about the next person that wishes to start this repo in isolation to work on the FE only.  How can the doc be updated to cater for difference Dev audiences with different goals? My UX preference would be a working snippet in the README that runs in this app in isolation much like the testing snippet.
If this isn't possible, then perhaps as a second choice - updating this doc to reference that Docker (& --live) is required and startup.sh doesn't apply to this app via the method suggested

So, as I understand it the problem is that ./startup.sh doesn't work for this app and the documentation states that the startup script works for all apps. I'd like to scope this to email-alert-frontend only.
There's a discussion about removing the documentation for the startup.sh script which is interesting.
I think that most of the problems highlighted in this issue could be solved by shifting the order of the documentation, with Docker listed before startup.sh; that way people would pick that up first.
As well, the startup script documentation should have a caveat added saying that this might not work with certain apps, including email alert frontend. As we know about more apps, we can update the documentation.
I think that this would help point developers in the correct directions without being too much work - and I'm happy to raise a pull request to do so.

So, as I understand it the problem is that ./startup.sh doesn't work for this app

Exactly, you can't move through it / render certain pages.

and the documentation states that the startup script works for all apps. I'd like to scope this to email-alert-frontend only.

Yes, the docker --live command is the default way to move through this particular app and render it's pages - this wasn't clear.  So as part of this PR there was a rejected update to the README of this app to note this startup command for ease, as this is a bit of an anomaly.
This README  update request prompted further conversation about /startup.sh and docker in general so was moved to an issue to not obstruct the PR.

👋🏼  @injms do you think this is worth updating as part of https://github.com/alphagov/govuk-ithc-documentation/issues/116 or should we close this issue?


Docs Refactor

This is a complete refactor of the documentation:

Navigation
Structure
Content

This reverted all of my edits in #14.  Am I missing something here?

@randybias hu, interesting, I thought I rebased my PR on top of this change, will have a look what happened here.


Football League Message Board

Football League message board #429

Codecov Report
Base: 81.00% // Head: 80.29% // Decreases project coverage by -0.72% :warning:

Coverage data is based on head (fb9dcb7) compared to base (d9f1ff0).
Patch coverage: 9.52% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
- Coverage   81.00%   80.29%   -0.72%
==========================================
  Files          60       60
  Lines        2080     2101      +21
==========================================
+ Hits         1685     1687       +2
- Misses        395      414      +19

Impacted Files
Coverage Δ

espn_api/requests/espn_requests.py
86.20% <8.33%> (-12.46%)
:arrow_down:

espn_api/football/league.py
94.52% <11.11%> (-3.58%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


boundary-init job hangs

I am trying the helm chart you provided in EKS and it hangs at the boundary-init job. any idea why would that would be?
job Logs:
Error creating: pods “boundary-init-” is forbidden: error looking up service account boundary/boundary: serviceaccount “boundary” not found.
EKS Version: 1.26

Hmm... let me take a look into this and see what's going on. I haven't looked at this chart in a while now, and it was before the EKS upgrade so might be something that needs to be updated.

Hi, I am having the same issue. It seems that the ServiceAccount doesn't get created. Regards

there is a fix for that. you need to add below annotations to serviceaccount.yaml in templates:
annotations:
helm.sh/hook: pre-install,pre-upgrade
helm.sh/hook-delete-policy: before-hook-creation
helm.sh/hook-weight: "-10"

Thanks @lucardcoder. The helm chart Template serviceaccount.yaml already got the annotations.
I deployed the Service Account using the following Manifest, before deploying boundary with the helm chart to get around the issue.
apiVersion: v1
kind: ServiceAccount
metadata:
  name: boundary
  namespace: boundary
  labels:
    app.kubernetes.io/managed-by: Helm
  annotations:
    meta.helm.sh/release-name: boundary
    meta.helm.sh/release-namespace: boundary
    helm.sh/hook: pre-install,pre-upgrade
    helm.sh/hook-delete-policy: before-hook-creation
    helm.sh/hook-weight: "-10"

kubectl create namespace boundary
kubectl apply -f service_account.yaml

However, I am getting the following error on the pods:
Back-off restarting failed container boundary-controller-scale-down in pod boundary-init-dr6zn_boundary(421cb507-6ec5-4351-a9bd-b1bfee9de02c)

Any ideas?

I already have the helm.sh/hook* annotations in the develop branch I just don't think it's been released in a version yet as the main branch still doesn't have it.  As the init process is attempting to scale-down and scale-up the controller while it runs without the SA in place that will not have the proper RBAC access and I can see that causing errors.

The Back-off issue comes from the initContainers' in the https://github.com/ugns/boundary-chart/blob/v0.1.0/templates/database-init-job.yaml#L48, because the scale-downcontainer is specified there instead of theinitcontainer as you have in  thedevelop` branch https://github.com/ugns/boundary-chart/blob/develop/templates/database-init-job.yaml#L49. Another issue I ran into is that there is no postgresql defined in the chart, so you need to deploy it before it seems. I haven't fully tested it yet, but it would be a great addition to the helm chart, if the postgresql is added there as an optional argument.


Demo videos

@CooperStansbury @KendraMBach @y2kfan12321 @nolan12gage
Uploaded Demo Videos for Personas 1-3.  God I hope I don't sound like that in real life.
Also, uploaded the videos to Youtube, added links in the video readme file

done


Deadlock sometimes caused on LimitSizeTo and ExpireAfter operator on SourceList

This can happens when these operators are applied  and the user also has the ability to remove data.

Experiment on a local branch  with reducing the locking and allowing the consumer to take charge of locking the removes


Challenger Coin - Find a way to remove it from the potion spawn pile, because of Alchemize.

Essentially, Silent's Alchemize creates a potion, and all base game potions the Silent has access are useful in battle.
Challenger Coin is NOT, and that's what I have to fix here. Just don't know if in a specific case or just limiting the potion to be very rare at combat and shops... well, let's find out.

Ok, need to do some patching.

For now, the only potion affected will be the ChallengerCoin. In the future, I may extend that to all OutOfCombatPotions.

The way thing sare, or I do an rloc change to add a line of code with a comparison, or I find out how to change a != using an ExprEditor.

Discord's Quincunx (Arbiter)#3304 showed the light: my code was working, the problem was JD-Gui which wasn't showing the changes.


MSC1731: Mechanism for redirecting to an alternative server during SSO login

Rendered
Full disclosure for this MSC: the reason for me proposing it is that I have a project which requires users to log in via SAML to a portal server; based on the results of the SAML authentication, the user should automatically be logged into one of several homeservers.

The generality of MSC1730 is a lot more appealing to me. It gives servers a way to redirect clients to other servers without complicating the login flow for the user (as SSO is some amount more complex for the user than logging in via other methods). Not to mention MSC1730 is a lot easier to implement for clients than supporting SSO auth (assuming they didn't go the route of fallback).

(I've updated the description of this MSC to give the reasons for proposing it)

The generality of MSC1730 is a lot more appealing to me. It gives servers a way to redirect clients to other servers without complicating the login flow for the user (as SSO is some amount more complex for the user than logging in via other methods). Not to mention MSC1730 is a lot easier to implement for clients than supporting SSO auth (assuming they didn't go the route of fallback).

I am strongly inclined to agree with you. For my current project, this MSC has appeal since it is a trivial enhancement to what is there already, but in the general case of usefulness to the matrix ecosystem, MSC1730 seems more powerful, and makes this one redundant.

@mscbot fcp cancel

@mscbot fcp close

since #1730 has now completed its MSC, and nobody objected to this being closed, I'm assuming that people are happy with that.


Roll back airs-router n10n fix

Problem
Now, in current architecture
Voedger uses airs-router with n10n fix: #471

Problem (hot): SSE stopped working in Alpha for an unknown reason

Describe the solution you'd like
rollback n10n modifications in router.

rolled back: #481

rolled back: #481


URL in description and README broken

The URL in the repository description and README are pointing to githubschool's copy of the game instead of yours.
Please fix both so they point to your copy of the game at https://githubschool.github.io/github-games-joseang860724/

Both files were updated

Both files were updated


As an Attestation Issuer, I can use the DefaultPortal of Verax as my Portal

This ticket is two fold:
More details on this specification in the issue #7
Requirements
1/ Create the DefaultPortal smart contract
2/ Create the method on the PortalRegistry to deploy a clone of it
Todo - 1/ Create the DefaultPortal smart contract

[ ] Create a DefaultPortal contract in the /portal folder
[ ] Create the state bytes32 public schemaId
[ ] Create the state address[] public modules
[ ] Create the state bool public isInitialized
[ ] Create the method initialize(bytes32 schemaId, address[] modules). This method will:
- Check that isInitialized is currently false
- Check against the SchemaRegistry that the SchemaId is registered (otherwise revert with custom error)
- Check against the ModuleRegistry that each module mentioned is registered (otherwise revert with custom error)
- Set isInitialized to true
- Store schemaId
- Store modules
- Emit event initialized
Note: how to get the SchemaRegistryAddress and ModuleRegistryAddress: one can be done assuming that the PortalRegistry exposes these addresses with a public getter. As the PortalRegistry will be the msg.sender of the initialize method, this DefaultPortal SC can use the IPortalRegistry(msg.sender) to get the addresses
[ ] Create the method `attest(bytes attestationPayload, bytes verificationPayload). This method will:
- run all the modules IModuleRegistry.runModules(address[] modules, bytes attestationPayload, bytes verificationPayload). The method runModules does not exist on the ModuleRegistry and must be created in this ticket
- Emit custom event
- store the attestation on the AttestationRegistry (not to be done in this ticket. Will be done through the ticket for attestationRegistry creation #61)
[ ] Create the method `revoke(bytes32 attestationId, bytes attestationPayload, bytes verificationPayload). As a basis in this DefaultPortal, the revoke functional path will be identical to the attest. Except that verification on the existence of the attestationId for this Portal have to be coded

Todo - 2/ Create the method on the PortalRegistry to deploy a clone of it

[ ] On the PortalRegistry, create a method `deployDefaultPortal(bytes32 schemaId, address[] modules) that will deploy a new (using create2) defaultPortal SC, initialize it and finally register it

Acceptance criteria

Should include a script to deploy the DefaultPortal conjointly with the PortalRegistry
Should include 100% unit-tests (including accessing the metadata through the mapping)

Additional information

Workload estimate

TBD

Do we not need to define an AbstractPortal first, the DefaultPortal would then be the most basic implementation of this AbstractPortal

The revoke method is now out of scope and will be covered by #31.


fix: type modelName

This has some great side effects:

errors when a typo is made
avoid ts errors when using model.modelName in downstream code

here's why it's useful:
const model = new OpenAI({
	temperature: 0,
	maxTokens: -1,
	modelName: "gpt-3.5-turbo-16k",
	openAIApiKey: openAIAPIKey,
})

const modelTokenLimit = await calculateMaxTokens({
	prompt: renderedEmptyPrompt,
	modelName: model.modelName,
})

I'd love to hard-type this but unfortunately I think it's best if we don't for two reasons:

If a new model comes out, people will get type errors with older LangChain versions.
I believe this will cause type errors for the following:

const options = {
  modelName: "gpt-4"
};

new ChatOpenAI(options);

Would you still get the autocomplete benefits if you did TiktokenModel | string or does that completely wipe it?

Thanks for engaging on this!

If a new model comes out and it's not explicitly supported by langchain this could cause very hard-to-debug errors. i.e. token max not being calculated properly by calculateMaxTokens and probably other assumptions throughout the codebase I'm not aware of. IMHO it's better to hard fail to indicate to the user the library does not officially support the model they are attempting to use. If the user wants an escape hatch, then can always cast the string to the type ("gpt-4" as TiktokenModel).
Wouldn't this hold true if any of the fields object keys were typed using a langchain-defined type?

Bump on the above?

I'll try to take a look today!

Closing for now but feel free to reopen


Bump core-paging dependency version

Text Analytics now uses features part of<EMAIL_ADDRESS>so I am bumping the dependency on it to be ^1.2.0 across our packages. I will merge this PR after the release week.
Please note that<EMAIL_ADDRESS>is not released yet so please let me know if your package is planned to release oob this month and it depends on @azure/core-paging so we can make an exception.

I am closing this PR because I think we decided to prefer to not align dependencies by default across our packages.


Wrong XML format

Hi,
I'm having an issue with the utilization of the script.
When I run the script on the probe itself, the script return me something like that:
PS C:\Program Files (x86)\PRTG Network Monitor\Custom Sensors\EXEXML> .\PSx64.exe -f="PRTG-VeeamBRStats.ps1"
0:<prtg> <result>   <channel>Successful-Backups</channel>   <value>5</value>   <showChart>1</showChart>   <showTable>1</showTable> </result> .....
I don't pass any parameters because I modified the BRHost variable into my script.
But when I setup PRTG to run the script, this is what it gives me :

This is what is setup into PRTG :

Thanks for your help and Happy new year !

Hi,
this issue is typically based on special characters (like "\ > <") in your Repo names.
Might you please execute the Script in Debug Mode and share the Result?
C:\temp\PRTG-VeeamBRStats.ps1 -Debug

I'm running the command on the server with : .\PSx64.exe -f="PRTG-VeeamBRStats.ps1" -Debug and it returns me the same result.

Please run the command directly in PS without PSx64.exe

I donwloaded the latest version of the script and it worked


Python : "UseDevelopmentStorage=true does not work

I am using "AzureWebJobsStorage": "UseDevelopmentStorage=true" in my Python function.
Here is the error : ValueError("Connection string missing required connection details.")

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0bd49c9b-995f-cc7e-77d7-74f21f1249f7
Version Independent ID: 1c2ce65b-5bd3-ca40-a487-ca5059f2c887
Content: Use the Azure storage emulator for development and testing
Content Source: articles/storage/common/storage-use-emulator.md
Service: storage
Sub-service: common
GitHub Login: @mhopkins-msft
Microsoft Alias: mhopkins

@kilagg Thank you for your feedback. Do you have the storage emulator installed locally?

yes and it is running during the process

@kilagg I see, I would take a look at the environment again and make sure the virtual env and other prerequisites are installed & configured properly. Alternatively, this could be something related to the python worker so it might be better to open a separate issue on the python worker repro and engage the Functions team.

@kilagg We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


[CLEANUP] fix improper usage of m:classifier

@pentaho/x-wing

Build Skipped
:white_check_mark: There was nothing to build. The changes are probably excluded by the build rules. If this is an error, please contact your system administrator.


[$250] Map preview moves around when the distance expense is loading

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.62-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @kevinksullivan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1713222545829489
Action Performed:

Track expense
Select distance
Create a distance expense by entering start / end points
Once landing in DM, tap around on the map

Expected Result:
The map shouldn't move around in a preview
Actual Result:
The map moves around in the preview, until the expense finishes and then it doesn't anymore
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/38435837/0d7c5e4a-5015-42ee-bfa6-f9914c261c66
https://github.com/Expensify/App/assets/38435837/955cf9ce-a1dd-49a0-b59a-7b9a9d451630

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01bfeab361be7edd4a
Upwork Job ID:<PHONE_NUMBER>830057472
Last Price Increase: 2024-04-23
Automatic offers:

jjcoffee | Reviewer | 0
bernhardoj | Contributor | 0

Proposal
Please re-state the problem that we are trying to solve in this issue.
We can move around the map after creating a new track distance.
What is the root cause of that problem?
This started to happen after this PR where we add a map view component to preview the distance map while waiting for the BE to give us the map preview in image form.
https://github.com/Expensify/App/blob/21ee1a3772253538bba74b2bc655213dc7bdb68a/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx#L231-L235
Because we are using the map view component, the user can interact with the map as they do on the distance request page.
After the BE sends us the image, we render the image instead of the map view.
What changes do you think we should make in order to solve the problem?

We need to disable the map interactivity when showing it as a preview only. We can do that by:

Pass a new prop to ConfirmedRoute > DistanceMapView called interactive.
In MapView.website.tsx, set interactive props of Map to the interactive props we pass.

<Map interactive={interactive} ...

In MapView.tsx, since rnmapbox doesn't support the interactive props, we can disable it by appending the style to include pointerEvents: none to the View wrapper.
https://github.com/Expensify/App/blob/21ee1a3772253538bba74b2bc655213dc7bdb68a/src/components/MapView/MapView.tsx#L148-L149

<View style={[style, interactive ? {pointerEvents: 'none'} : {}]}>

Or we can have the same implementation for both platforms by passing a style of pointerEvents: none directly from ConfirmedRoute.

@bernhardoj's proposal LGTM!
:ribbon::eyes::ribbon: C+ reviewed

PR is ready
cc: @jjcoffee

@jjcoffee - can you add regression steps? Payment not due till the 9th.

The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/34133
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/34133/files#r1599802819
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Open an existing expense report
Create a new distance request
Drag around the money request map preview
Verify the map doesn't move
Press the preview to open the transaction thread
Drag around the map preview
Verify the map doesn't move

Do we agree 👍 or 👎

Paid, added regression test.


Spyder had encountered an internal problem

Description
What steps will reproduce the problem?

Every time I open up Spyder, I immideately  get a notice stating " Spyder has encountered a problem". I have tried reinstalling Spyder, and have even deleted Anaconda and reinstalled that as well.

This is the entire error message
File "/Users/bennicholl/anaconda3/lib/python3.6/site-packages/spyder/plugins/ipythonconsole.py", line 950, in update_working_directory
shellwidget.get_cwd()
File "/Users/bennicholl/anaconda3/lib/python3.6/site-packages/spyder/widgets/ipythonconsole/shell.py", line 128, in get_cwd
self.silent_exec_method(code)
File "/Users/bennicholl/anaconda3/lib/python3.6/site-packages/spyder/widgets/ipythonconsole/shell.py", line 340, in silent_exec_method
local_uuid = to_text_string(uuid.uuid1())
File "/Users/bennicholl/anaconda3/lib/python3.6/uuid.py", line 606, in uuid1
clock_seq_hi_variant, clock_seq_low, node), version=1)
File "/Users/bennicholl/anaconda3/lib/python3.6/uuid.py", line 168, in init
raise ValueError('field 6 out of range (need a 48-bit value)')
ValueError: field 6 out of range (need a 48-bit value)
Version and main components

Spyder Version: 3.2.6
Python Version: 3.6.3
Qt Versions: 5.6.2, PyQt5 5.6 on Darwin

Dependencies
pyflakes >=0.6.0 :  1.6.0 (OK)
pycodestyle >=2.3:  2.3.1 (OK)
pygments >=2.0   :  2.2.0 (OK)
pandas >=0.13.1  :  0.22.0 (OK)
numpy >=1.7      :  1.12.1 (OK)
sphinx >=0.6.6   :  1.6.6 (OK)
rope >=0.9.4     :  0.10.7 (OK)
jedi >=0.9.0     :  0.11.1 (OK)
psutil >=0.3     :  5.4.3 (OK)
nbconvert >=4.0  :  5.3.1 (OK)
sympy >=0.7.3    :  1.1.1 (OK)
cython >=0.21    :  0.27.3 (OK)
qtconsole >=4.2.0:  4.3.1 (OK)
IPython >=4.0    :  6.2.1 (OK)
pylint >=0.25    :  1.8.2 (OK)

This is duplicate of issue #6335. To fix it you need to open Terminal.app and run there
conda update python python.app

I got the same issue. Every time  i open spyder i get a notice "spyder has encountered an internal problem".
And the detail of the problem is:
plugin = mod.PLUGIN_CLASS(self)
AttributeError: '_ModuleMock' object has no attribute 'PLUGIN_CLASS'
WARNING:traitlets:kernel died: 18.00585126876831
What should i do to resolve it?

yeah when i did... I'm getting this error...
PackageNotInstalledError: Package is not installed in prefix.

prefix: C:\Users\Ace\Anaconda3*
package name: python.app*

On Mon, Sep 3, 2018 at 1:22 AM Ben Nicholl<EMAIL_ADDRESS>wrote:

did you try running:
conda update python python.app
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/spyder-ide/spyder/issues/7047#issuecomment-417957231,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AgtJ9CXxh_94vI16aueGngTvsb7ACVCLks5uXD38gaJpZM4TuFuS
.


Setup jvm-test-fixtures project, extract java-test-fixtures plugin class

Also clean up some other files that didn't or couldn't move to the proper sub-project without this existing, or were left behind in plugins by error.

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test and merge

I've triggered a build for you. Click here to see all failures if there's any.

Pre-tested commit build failed. Click here to see all build failures.

@bot-gradle test and merge

I've triggered a build for you. Click here to see all failures if there's any.

Pre-tested commit build failed. Click here to see all build failures.

@bot-gradle test and merge

I've triggered a build for you. Click here to see all failures if there's any.

Pre-tested commit build failed. Click here to see all build failures.

@bot-gradle test and merge

I've triggered a build for you. Click here to see all failures if there's any.


v1: simplified font-size behaviour

These changes will also reduce the bundle size even further

remove modularscale-js from being a hard dependency. Some user may not need this package's feature, so why force them to download it when it is extremely easy to setup manually. Instructions have been provided in the readme.
removed the useModularScale option based on the above decision
removed the 2nd param from ds.fontSize()
removed the ability to set a unitless type.sizes value. IMHO this was confusing and if user's need modular-scales, then they can implement that in their own way.

These changes are a breaking change so that is why the major version number has been bumped.

for anyone reviewing this PR, the main changes are in the index.js file


Tag Filter Source Nullpointer

Hi,
We recently upgraded to version 3.4.0 and then started getting a nullpointer exception on our search page. I noticed that the nullpointer was pointing to
com.adobe.aem.commons.assetshare.components.predicates.impl.PropertyPredicateImpl.getItems(PropertyPredicateImpl.java:138)

I debugged the code and saw that it was happening because the source object was null at the following line
if (source.equals("json"))

In looking at the resource object of the predicate, I noticed it was actually on Tag Filter component, not a Property Filter, which is what the PropertyPredicateImpl should be triggering from. I guess it may be happening because the Property Filter is a super resource type of the Tag Filter. The Tag Filter dialog, however, doesn't have a source field (it's actually explicitly hidden), so it will always be null if PropertyPredicateImpl is triggered.
Are we doing something wrong that it is getting invoked like that? I removed all the Tag Filter components from the page and it did start working, so it certainly seems like they are the culprit.
Thanks,
Liviu

Just noticed that there seems to be a PR in place to fix this at https://github.com/adobe/asset-share-commons/pull/1007
Any plans to make this part of a release?

Sorry -i thought this was released. Cutting 3.4.2 with this fix now

Fixed in 3.4.2 released today

Thanks David!


Implement fix for redis-oplog issue #367.

This fixes the issue mentioned here (with the fix suggested there). Without the fix, the use of _.union is a no-op and so fields that appear only under an operator like $or or $and won't be found.

Thank you @brianlukoff once the tests pass I will merge this and release a new patch version.


Task weighting in scenes

Task weighting is performed by multiplying task matrix A and task vector y  by a weight value w.
in this way, it's like stretching the space to have larger or smaller contribution with the square norm
|| w(Ax -y) ||  ->  || (wAx - wy) ||  ->  minimize  x'(wA)'(Wa)x - (wAx)'wy
In current implementation, (see velocity scene for example), y vector is not multiplied by the task weight. the resulting problem is
minimize  x'(wA)'(Wa)x - (wAx)'y
https://github.com/ARC-OPT/wbc/blob/19c562dd3699f7581161bf6958dab29655624220/src/scenes/VelocitySceneQuadraticCost.cpp#L110-L115

Should be fixed by #91


[Bug]: Navbar width is not correct

Describe the bug
The navbar width is not correct from the left side. It has some space between the navbar and sidebar that is visible on the colored background. The behavior is also not good on mobile devices.
To Reproduce
Steps to reproduce the behavior:

Go to the main page of the website
Scroll down to the blue background
See error

Expected behavior
There would be no space between the navbar and the sidebar. These both will look combined with each other. On small devices, it will expand to full width.
Screenshots

I can fix it. Can you assign me?


Compile on OpenBSD (bad)

I was playing with Godot on OpenBSD. A few small changes were neccessary to make it compile.

Hi @a12n and sorry for the delay. Could you rebase your branch on the current godotengine/master branch, so that it could be merged?

Ugh, looks like I've merged libao branch into this one. Is it acceptable to import it that way? Or should I do/redo something?

It would be better to clean it up to only have the OpenBSD related changes yes, especially as your libao branch is quite big and will likely need more thorough review. I'd advise you to create a new branch for the OpenBSD fixes and cherry-pick the relevant commits there.

OK, I've created #2849.

Thanks! :)


Some improvements in WalkUtils and use the ValueUseDefWalker in the ReleaseDevirtualizer pass

Improvements for WalkUtils and EscapeInfo:

"merge" the Path and State in WalkUtils into a single WalkingPath. This makes it simpler for clients to configure a path and additional state variables. EscapeInfo now defines EscapePath which includes the projection path and EscapeInfo's specific state variables.
Make the WalkerCache part of the WalkUtils, so that not all clients have to re-implement it.
Rename walkDownResults -> walkDownAllResults and walkUpOperands -> walkUpAllOperands and make these functions client configurable.

And: use the ValueUseDefWalker instead of the manual use-def walking implementation

@swift-ci test

@swift-ci benchmark

@swift-ci smoke test


New Ads on website are very intrusive

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
The Ads that follow the user’s scrolling across the website remind me of the illegal websites used to watch copyrighted movies and make me not want to recommend odysee anymore
Describe the solution you'd like
A clear and concise description of what you want to happen.
Make ads less intrusive and not follow you when scrolling on the page
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
I love odysee, I just don’t want to have to use an adblocker everytime I want to watch a video

Send us an email at<EMAIL_ADDRESS>with which ad you are referring to exactly.
Odysee needs to make money to operate, so ads are a must


fix: restore 'Initialized...' message in app runs

Yeah agree, I just wanted to timebox this. Added a note to come back to it.


upgrading hoek for CVE-2018-3728

Change to resolve issue #19

Coverage remained the same at 100.0% when pulling 3a7847160cfadf50cbd1b1958391d91757b2eaf5 on njlg:hoek-security-issue into e523a6950f9f7e32ed5c6cfb493dd51ea6995c96 on dialexa:master.

Coverage remained the same at 100.0% when pulling 3a7847160cfadf50cbd1b1958391d91757b2eaf5 on njlg:hoek-security-issue into e523a6950f9f7e32ed5c6cfb493dd51ea6995c96 on dialexa:master.


Is it possible to assign essential bc in different directions for each boundary?

Consider a linear elasticity problem. How do I assign a different component to each boundary?
I tried the following:
ess_bdr_west_list = [0] * (n_bdr_attr)
ess_bdr_north_list = [0] * (n_bdr_attr)
ess_bdr_bottom_list = [0] * (n_bdr_attr)
ess_bdr_west_list[nwest] = 1
ess_bdr_north_list[nnorth] = 1
ess_bdr_bottom_list[nbottom] = 1
ess_bdr_west = mfem.intArray(ess_bdr_west_list)
ess_bdr_north = mfem.intArray(ess_bdr_north_list)
ess_bdr_bottom = mfem.intArray(ess_bdr_bottom_list)
fespace.GetEssentialTrueDofs(ess_bdr_west, ess_tdof_list,0)
fespace.GetEssentialTrueDofs(ess_bdr_north, ess_tdof_list,1)
fespace.GetEssentialTrueDofs(ess_bdr_bottom, ess_tdof_list,2)
But only the last one is taken. Any suggestions.
Adolfo

Hi @adantra, so you currently would want a temporary array which you'd pass into the fespace.GetEssentialTrueDofs(...) calls. Then between each call you'd want to add the information from there to your ess_tdof_list.
I will mention that I currently have a PR open #2849  which should eventually make this process easier in future versions of MFEM.

Thanks, Robert. That's exactly what I need.


Continue the developing of the F-Droid version

There is no separate F-Droid version

I'm sorry, but I saw it on the Play Store is version 1.7.1 (20/06/2016), while on the F-Droid is stopped to version 1.7 (11/20/2015) .. I thought were 2 versions different.
Updates of the F-Droid, please.

Building and updating the app for F-Droid is up to the F-Droid guys. Apparently, the didn't build the latest version because they don't support the used build tools version: https://f-droid.org/wiki/page/de.j4velin.systemappmover


Support variable fonts (#153291)

This PR fixes #153291

@mitsukuri I've been also waiting for responses from team members.

Thank you! Is there anything I need to do?

Thanks for the PR! Please merge in main and resolve the merge conflicts (might also conflict with https://github.com/microsoft/vscode/pull/149703). Thank you!


Fixed link in import.md

[x] Have you signed the Contributor License Agreement?
[ ] Are you working against an Issue?

Microsoft Reviewers: Open in CodeFlow

https://github.com/microsoft/winget-cli/pull/1313#issuecomment-882852550


Add button and route to halt Smoothie and reset robot

Description:
add /reset route to immediately halt Smoothie and reset robot

Closing in favor of #510


xsession is in /bin folder

In readme you giving such a command:
ln -s ~/.xmonad/xsession ~/.xsession (and correspoding for .xinitrc)

but xsession is in /bin forlder so it should be
ln -s ~/.xmonad/bin/xsession ~/.xsession

no?

Hey @sandric. This was fixed in e671c81ae5e458be780e55a4c9ebbb2e8e65855c. Thanks!


let foo = null isn't an error with noImplicitAny

Maybe I'm misunderstanding something, but I was really surprised by this!
TypeScript Version:  2.4.1
Code
let foo = null;

with noImplicitAny: http://www.typescriptlang.org/play/#src=let foo = null;
Expected behavior:
foo has an implicit any type but isn't flagged with noImplicitAny:

Actual behavior:
Not an error.

The implicit any is now tracked in a more complex way that makes the error appear later, e.g.
// Error, return type of 'fn' is implicitly any
function fn() {
  let foo = null;
  return foo;
}

If you use foo in a way that exposes its anyness, you should see an error (post a repro if that happens)

Here's the broader context:
import * as React from 'react';

export class Foo extends React.Component<{}, {}> {
  render() {
    let foo = null;

    if (Math.random() > 0.5) {
      foo = <div />;
    }

    return <div>{foo}</div>;
  }
}

When I mouse over either of the first two mentions of foo, its type is any. But when I mouse over the third, it's JSX.Element | null, which is correct. So I guess this is WAI, it's just a bit surprising to see what looks like an implicit any not trigger a noImplicitAny error!


Invalid manifest error while installing using chrome extension store

Install from the chrome extension store.

What is the browser version and operating system?

Fixed in v2.12.2.


Add Document content to ollama prompt

I've found that ollama came up with nonsensical correspondent names (akin to ACME Corp, ABC Industries etc).
Upon inspection it seems like the document information is not appended to the prompt at all so in retrospective the behaviour does make sense.
Fun fact, no errors were seen in the logs when using mistral as a model. After switching to llama3.2, the LLM's reply actually mentions it's not able to build the requested output since the input is missing.

Oh wow you are absolutely right with that.
I forgot to add the content part to the print after reworking the ollamaService.
Thanks for your valuable input. I really appreciate that.


Motion detection trigger by camera, not by camera.ui

I am using camera.ui since da few days, seems to work fine. Great Plugin!
Before I used a Synology NAS with Surveillance Station. In Surveillance Station I could configure motion detection by surveillance station OR by Camera. My Cameras (LevelOne FCS-3084) habe built-in Motion detection. In Surveillance Station, the cams are conntected by ONVIF. I had nothing more to configure, it just worked. When I used "Motion detection by surveillance station", I had the CPU always up on 100% and the LAN was on heayv traffic.
How do I have to configure Motion Detection by Camera?
Greetz

🎉 A new version of camera.ui
A new version of camera.ui is currently under active development. An initial alpha/beta release and previews are coming soon. Stay tuned for exciting updates: https://github.com/seydx/camera.ui/issues/448 .
This version will no longer be developed / fixed. The new version contains many novelties and fixes (most important is for HKSV recording).


Data view doesn't update with custom geometries

Context
When adding custom geometries, data view is not updated nor provided in the case it was originally empty.
Steps to Reproduce
Please break down here below all the needed steps to reproduce the issue

Create a new map with an empty layer
Add some points via geometry edition
Switch to table view

Current Result
No data
Expected result
The resulting point table should be shown

Adding new points on a layer with previous geometries also fails in updating the table view.

This is already reported, let me find it.

@matallo, do you remember that ticket? I feel you opened it, didn't you?.

not sure it is the same, but it can be related https://github.com/CartoDB/cartodb/issues/11759

Yep @matallo, take a look @nobuti while you fix this one.


"is online" state

Hello,
with the following commit the online status should also be visible as dp in iobroker.
https://github.com/iobroker-community-adapters/ioBroker.unifi/commit/37c4c441f4be5acf82a3d86190a1da763e59cc98
Unfortunately I could not find it after updating to the latest version.

@n3roGit The latest version is v0.5.0. Every commit after this version is bleeding edge and unsupported. Nevertheless, as this is a new state you first have to enable it in the configuration.
I hope this solves your problem and I'll close this issue. If the issue persists, keep in mind that you are using bleeding edge without support.


Fix Parameter change via proposal

Scenario:
Change value for the instantiateAccess parameter from AccessTypeOnlyAddress with an address to a value without address like AccessTypeNobody.
Issue
It fails with invalid parameter value: address not allowed for this type.
Cause
The address part from the previous state was not cleared by the gov parameter change proposal handler. Probably because it is set to an empty value.
This can be replicated in a modified TestUpdateParamsProposal test.

@bragaz fyi: you may run into this with simulations

@bragaz fyi: you may run into this with simulations

During the weekend I've tried to solve this but somehow it kept returning this error so this morning I asked my @riccardom to help me debug the code.
We found out that protobuf takes care of the unmarshal while we were using json.Marshal to encode the CodeUploadAccess param inside ParamChanges.
After switching to protobuf marshaler everything worked fine.
However, the tests will fail due to a bug inside the Capability module but I don't think this is related to the params.


customize buttons

Hi, I like your plugin very much. I got one question. Is it possible to customize the buttons? To add image to prev/next?  To change position of buttons?

Already answered here https://github.com/smashingboxes/OwlCarousel2/issues/663 ?

yes, you can. see the docs to more info.


Support remote policies

The goal of this PR is to add support for organization owned policies, stored in an external repository.
Currently, any policy author can specify remote policies by providing an external public URL. But this might not be enough for private or builtin policies, that organizations don't want to expose publicly, but still want to keep in a central repository. For this purpose, we propose allowing the configuration of "Policy providers", consisting of an external service that will provide the policy material on request.
Policies will be referenced by name, optionally prepending a provider name:
apiVersion: workflowcontract.chainloop.dev/v1
kind: Policy
metadata:
  name: sarif-errors
spec:
  ref: policy-name # or chainloop://policy-name

On contract create, Chainloop would query the provider to verify that the reference is valid.
On contract describe, Chainloop will query the provider to retrieve the policy material and embed it in the resulting payload. This way, the CLI doesn't need to know anything about providers, since all the policies will be already in the contract.
The policy provider service would accept Chainloop API_TOKEN for Bearer authentication.

@jiparis we need to update the helm chart to support configuring providers correct?

correct. Let me follow up a quick PR

Please check https://github.com/chainloop-dev/chainloop/pull/1224


Feature Request: merging models respecting the identity of Archi objects

Occasionally I cut a fragment F from a model (e.g. a view) and paste it into a different model T. The current semantics of this is a "disjoint union". That is: all elements from F and T are present in the combined model. It is now possible that there are multiple elements with the same type and name sitting in the combined model.
For example: Suppose F contains an Archi object (with internal identifier 96a0c822-d611-420c-9b57-dc2f15da36f0) of type "ApplicationComponent" and name "File Upload Server". At the same time, T contains an Archi object (with internal identifier c28e684f-600b-4aeb-a247-92040e595168) of type "ApplicationComponent" and name "File Upload Server". In this case, I get two Archi objects with the same type and name in the combined model. If both Archi objects have a number of relations attached, I have to do tedious "plumbing" to turn them into one object.
The problem is that I want objects with the same type and name to be identical because there are relations attached to them that need to be combined in the new model. Doing that by hand is utterly impractical. I need the semantics of "union" rather than "disjoint union".
So, I would like to have a way of merging that respects the identity of Archi objects and merges these two objects into one. This can be done by substituting one of the internal identifiers systematically with the other internal identifier, throughout the entire combined model.
The architectural principle here is that objects with the same type and name are identical and are therefore represented in a model only once. I am asking to promote this principle to be a feature of Archi and apply it consistently throughout the software.

The Import/Merge feature works on the basis of objects' internal identifiers to determine uniqueness. This is by design and so it's not something that will change in this feature.
Of course someone could write a plug-in or a jArchi script that could import/merge objects based on other criteria.

The implementation of this feature request is slightly different with properties, because properties don't have an internal identifier in Archi. A property is basically a key/value pair. So, for example, if I have Archi object o in model F with properties "(repr, Philip)", "(repr, John)", and "(source,240)", and I have Archi object o' in model T with properties "(repr, Sarah)", "(repr, Jane)", "(repr, John)", and "(idiom,cluster)", then there should be one combined object o'' in the combined model with properties "(repr, Philip)", "(repr, John)", "(source,240)", "(repr, Sarah)", "(repr, Jane)", and "(idiom,cluster)". This too is not the disjoint union of properties, but the union (where a property is seen as a set of key/value pairs).

Do you know of any such plug-in? Is there a list of known plug-ins somewhere?

The Import/Merge feature works on the basis of objects' internal identifiers to determine uniqueness. This is by design and so it's not something that will change in this feature.
Of course someone could write a plug-in or a jArchi script that could import/merge objects based on other criteria.

Do you know of any such plug-in? Is there a list of known plug-ins somewhere?

The architectural principle here is that objects with the same type and name are identical and are therefore represented in a model only once.

In the ArchiMate standard, it is possible to have multiple objects of the same type and name. Thus I don't think it would be good to enforce this when merging two models.
It is not too complicated in jArchi to merge concepts based on whatever rule you defined (one colleague created such script), so I'll share such script in the future as soon as I'll have cleaned it a bit.

@jbsarrodie, thanks for sharing that. I will look out for it.
Just now I have made a jArchi-script called "Show duplication.ajs" to signal this situation.

The architectural principle here is that objects with the same type and name are identical and are therefore represented in a model only once.

@jbsarrodie said:
In the ArchiMate standard, it is possible to have multiple objects of the same type and name. Thus I don't think it would be good to enforce this when merging two models.

Hm, the ArchiMate standard does not define equality on elements. So it leaves it up to the tool implementor to decide whether or not it is possible to have multiple objects of the same type and name. Archi's answer is "yes", but that cannot be traced to the ArchiMate standard. (@jbsarrodie please point out where I missed the definition of equality between elements in the ArchiMate standard. I don't mind being wrong about this...)
If the ArchiMate standard leaves the equality of elements up to the tool builders, the issue boils down to whether there is a good reason from a user perspective to define that equality.
My plea in the opening comment boils down to a plea to have equality of elements based on name and type within a single model. As a modeler, I want sharing of relations across views to be predictable. Whichever instance of an element I click on, regardless of the view I'm in, I want to see the same analysis and the same list of properties. All of this will still be within the ArchiMate Standard since it does not define equality of elements.
If Archi were to adopt this equality, it would interestingly enough NOT affect the visual representation of any view. It would however ensure that an element with the same name and type is shown with the same analysis and properties throughout the model. It would have to be implemented as a system invariant.

Hm, the ArchiMate standard does not define equality on elements. So it leaves it up to the tool implementor to decide whether or not it is possible to have multiple objects of the same type and name.

That's not how it works with the standard: if it is not explicitly forbidden then it is allowed, so it is possible to have multiple concepts of the same type and name in ArchiMate (as in most modelling language and/or notation). This is reflected in the ArchiMate Model Exchange File Format which defines a separate id. The fact that some tools impose to have different names has even been an issue for interoperability testing when developing the exchange format. These tools were considered non compliant.

My plea in the opening comment boils down to a plea to have equality of elements based on name and type within a single model. As a modeler, I want sharing of relations across views to be predictable. Whichever instance of an element I click on, regardless of the view I'm in, I want to see the same analysis and the same list of properties.

I do think that most of the time we (as practitioners) should try to avoid "name duplicates" (let's call them this way). That's why it's useful to have such rule implemented in Archi's Validator. But I know lot's of cases which forces people to have "name duplicate". One of the best example is data modelling: As soon as a model encompass multiple business domains (that's my case), then it becomes impossible to avoid "name duplicates" because it is perfectly right for different business to use the same word (thus Business Object) while attaching a different meaning. The real issue behind is not the name itself but the need for a kind of namespace.

If Archi were to adopt this equality

That ship sailed long ago.
All of Archi's code is based on the equality of objects' identifiers. That's not going to change so, for me, this discussion is purely academic.

Well, let's leave the discussion to the academics then.
In the meantime, I have published a second jArchi code snippet to ensure that all elements that share type and name are one and the same element. Executing it does not affect any views and is idempotent.


Import error for _base_model

Hello,
I followed the Linux installation procedure described here: https://github.com/X-DataInitiative/tick/blob/master/INSTALL.md, on a Windows 10 WSL environement, with Python 3.7. Installation built and finished OK.
But I face an error trying to simply import a Tick module:
[GCC 8.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from tick.plot import plot_hawkes_kernels
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/dist-packages/tick/solver/build/solver.py", line 14, in swig_import_helper
    return importlib.import_module(mname)
  File "/usr/lib/python3.7/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1006, in _gcd_import
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 670, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 583, in module_from_spec
  File "<frozen importlib._bootstrap_external>", line 1043, in create_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
ImportError: _base_model.cpython-37m-x86_64-linux-gnu.so: cannot open shared object file: No such file or directory

While the file exists:
m@m:/c/Users/Me$ ll /usr/local/lib/python3.7/dist-packages/tick/base_model/build/
total 23728
drwxr-xr-x 1 root root      512 May 16 21:35 ./
drwxr-xr-x 1 root root      512 May 16 21:35 ../
-rw-rw-rw- 1 root root      258 May 16 21:16 __init__.py
drwxr-xr-x 1 root root      512 May 16 21:35 __pycache__/
-rwxrwxrwx 1 root root 24145648 May 16 21:21 _base_model.cpython-37m-x86_64-linux-gnu.so*
-rw-rw-rw- 1 root root    36597 May 16 21:21 base_model.py

Do you know if I missed someting obvious ?

Use Python 3.6 instead of 3.7, we still avec issues with 3.7. Cheers

WSL is not tested or supported

we provide a rolling wheel for windows if you'd rather use that
can be found @ appveyor https://ci.appveyor.com/api/buildjobs/6u7ng72ml9n0ccb8/artifacts/dist%2Ftick-<IP_ADDRESS>-cp36-cp36m-win_amd64.whl
I have discovered that it does actually work if you use an alternate build method
cd ~/
git clone https://github.com/Dekken/maiken --depth 10 -b master git/mkn
cd git/mkn
make nix
sudo cp mkn /usr/bin
cd ~/git
git clone https://github.com/X-DataInitiative/tick --depth 10 -b master --recursive tick
cd tick
MKN_COMPILE_THREADS=4 CXXFLAGS="-march=native" ./sh/mkn.sh
export PYTHONPATH=$PWD
python3 -c "import tick"

Hello everyone,
Thanks for your prompt and detailed answers. I tested the above build method with Windows 10 WSL, and Python 3.6 : it works!
On the contrary, the same build method, with the same environment, and Python 3.7 faces the issue I initially described.
No big deal, I will use Python 3.6 for this specific project.
Thanks again.

Just tested with Windows 10 WSL and python 3.8, it took a really long time to build the wheel but it works :-)

Just tested with fresh build of Windows 10 WSL and python 3.8 which failed but succeeded with 3.6 :-)


Does this adapter support *NIX out of the box

Subject says it all.
Does this adapter support any flavors of *NIX - out of the box?

The API Adapter is published for linux-x64 and may work on NixOS, but no testing has been done in this regard and there are no plans to specifically support NixOS.

Thanks, will check out linux-x64

From: Steve Dietz @.>
Sent: Wednesday, July 31, 2024 4:48:28 p.m.
To: Geotab/mygeotab-api-adapter @.>
Cc: Brent Kimberley @.>; Author @.>
Subject: Re: [Geotab/mygeotab-api-adapter] Does this adapter support *NIX out of the box (Issue #17)
The API Adapter is published for linux-x64 and may work on NixOS, but no testing has been done in this regard and there are no plans to specifically support NixOS.
—
Reply to this email directly, view it on GitHubhttps://github.com/Geotab/mygeotab-api-adapter/issues/17#issuecomment-2261435578, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJXZLIOLFH6C4GRDMPB5G43ZPFERVAVCNFSM6AAAAABLZF4ZWGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRRGQZTKNJXHA.
 No rights to any privilege have been waived. If you are not the intended recipient, you are hereby notified that any review, re-transmission, dissemination, distribution, copying, conversion to hard copy, taking of action in reliance on or other use of this communication is strictly prohibited. If you are not the intended recipient and have received this message in error, please notify me by return e-mail and delete or destroy all copies of this message.


Test fails when using /InIsolation parameter

Description
I have a test where the garbage collector is under heavy usage. When testing at the command line using vstest.console.exe without the /InIsolation parameter tests succeeds. Running with the /InIsolation paramter or inside Visual Studio test fails.
Steps to reproduce

Compile attached project (x86, no matter if Debug or Release)
Run test: vstest.console.exe MemPressure.dll /platform:x86  /InIsolation

Expected behavior
Test should succeed.
Actual behavior

Test fails. I think the error message is wrong. I have a similar test for our internal suite. Here the test just hangs.
Test also does not fail if number of iterations (UnitTest1.cs, line 12) is lower (for example 2500).

Environment

Win10 (10.0.15063), vstest 15.0.26228.0 (Visual Studio 2017)
MemPressure.zip

So you can reproduce this? What's happen next?
Just curios - Robert

@RobertFromBerlin, i didnt try yet. After reading the issue its seems a bug in TestPlatform. Will update you once i will strat working on it.

@RobertFromBerlin "InIsolation" switch was added in latest vstest.console.
Also I debugged your repro project in VS IDE, & if the count is set 25000, the test method is causing "Out Of Memory" exception. Since we cannot OOM Exception all the time, you are getting an invalid error message.
Can you please try and debug this in latest VS 2017.5

@RobertFromBerlin I've provided my analysis above, please go through it & see if it resolves the issue for you or not.
I'll close this thread for now, feel free to re-open if you still encounter this issue.


Updating Serverless tutorial, engineVersion needs to be string

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/lgtm


[BUG] plugins.lazygit.settings.use_custom_config_file_path does not get passed to plugin correctly

Field
Description

Plugin
lazygit

Nixpkgs
unstable

Home Manager
unstable

[x] I have read the FAQ and my bug is not listed there.

Description

When the option is set to true, lazygit.nvim does not recognize it.
NixVim says this option is a bool and passes it on as such into the generated init.lua, but lazygit.nvim checks if the option is 1 to enable the feature.
Minimal, Reproducible Example (MRE)

programs.nixvim = {
  plugins.lazygit.settings = {
    use_custom_config_file_path = true;
    config_file_path = builtins.toString (pkgs.writeText "custom-lazygit-config.yml" ''
      # any options, e.g.
      gui:
        border: single
      notARepository: quit
    '');
  };
};

Workaround
programs.nixvim = {
  plugins.lazygit.settings = {
-   use_custom_config_file_path = true;
+   use_custom_config_file_path.__raw = 1;
    config_file_path = builtins.toString (pkgs.writeText "custom-lazygit-config.yml" ''
      # any options, e.g.
      gui:
        border: single
      notARepository: quit
    '');
  };
};

As per the example, mkVimPlugin should convert bool settings options to int. https://github.com/nix-community/nixvim/blob/49452662b7b4dd2467cbac19e0f9820d570d8976/lib/vim-plugin.nix#L57-L62
The example was added by @GaetanLepage in 97fb6d6a
That said, looking at the implementation, I can't see any type conversion being done. It only seems to add the prefix to the option name: https://github.com/nix-community/nixvim/blob/49452662b7b4dd2467cbac19e0f9820d570d8976/lib/vim-plugin.nix#L107
This likely affects a ton of plugins, as many will assume the example is correct and bools are properly converted to int.

I'm dumb, of course vim options can be booleans. Therefore we can't assume nix booleans should be converted to ints.
Instead, the settings-example should be fixed and any affected options should have their type changed to enum [0 1].
IDK if there's a good way to transition affected options without immediately breaking users' configs. I guess any affected users already had (silently) broken configs anyway, so this may not be important.
One way we could do this would be to create a custom type, equivalent to enum [0 1 true false] but have its "show" text be either 0 or 1.
That way we aren't documenting boolean support, but we could still check for boolean definitions and print an appropriate warning.

Yeah for configs that are already broken I don't think it's too bad to introduce a breaking change


This provider have to use terraform-provider-sdk v2

Announcing HashiCorp Terraform 1.0 General Availability

The Terraform Plugin SDK is a framework that lets developers create and maintain Terraform providers. HashiCorp will be ending support for the version 1 release of the Plugin SDK on July 31, 2021. Users of the Terraform CLI and Terraform Cloud are not affected by this and do not need to take any action. Maintainers of Terraform providers who are impacted are encouraged to use our upgrade guide to move to version 2 of the Terraform Plugin SDK. Follow our tutorials to develop your first provider. Additional information can be found in the Terraform Provider Developer Community Discuss forum: End of Life Timeline for v1 of the Terraform Plugin SDK.

This provider doesn't use SDK v2. (https://github.com/jfrog/terraform-provider-artifactory/blob/master/go.mod#L6)

It has been labeled as a bug, but it is not a bug 🙇

OK.
I'll submit a PR.

@cappyzawa I'm fairly confident we were successful in upgrading to v2 (v2.7.0) of terraform-provider-sdk in #95
Currently awaiting review 👍


the line noise, anyone can remove it?

this problem has disturbed me long time. any people can remove it.

Try increasing sigma during inference.

@rafaelvalle I try， but it can not remove it.

I also can't find a satisfying sigma. Bigger sigma makes the periodic noise less obvious, but harms the speech quality.
@rafaelvalle , @bryancatanzaro  Do you think smaller n_group value can solve the periodic noise problem? How does the n_group size affect the speech quality in your experiments?

The periodic noise can be solved by decreasing the bias of the model, which can be achieved by sampling with higher sigma. To achieve similar speech quality with higher sigma, one needs a model that better fits the data.

@rafaelvalle I cannot understand your ans "The periodic noise can be solved by decreasing the bias of the model, which can be achieved by sampling with higher sigma", can you explain in detail? train with high sigma?

@rafaelvalle Thanks for your reply.
Do you think WaveGlow with smaller n_group value could better fits the data?
Do you experiment with different n_group values?

There's a hack here to remove the "line noise"
https://github.com/NVIDIA/tacotron2/issues/142#issuecomment-466506044

@rafaelvalle Thanks for suggesting the frequency domain line noise removal. I find another way to greatly attenuate the line noise in spectrogram on my setup for narrow band speech generation. Keep the same segment length, increase the number of group from 8 (default) to 16 or 32. I find it helped to converge to good quality speech faster as well. Though I don't have good explanation on that, any insight?

@triwoods Can you share samples with us using group size 8, 16 and 32?

@rafaelvalle I've implemented the denoiser, but the output generated is silent; is there a way of fixing this?

Just FYI. Another quick fix I used to remove these line noise was to apply a notch filter around these frequency lines with an appropriate Q value on the generated waveform.

@guanlongzhao would you mind sharing your code ?

@guanlongzhao would you mind sharing your code?

See this code snippet. For 16KHz audios, you can sequentially filter the waveform by setting w0 to [2000, 4000, 6000]. I used Q = 50 in my experiments. Although in general, I think you should stick to the official denoiser since the line noises and other background noises were caused by the nature of the method, IMHO.

@guanlongzhao thanks my friend.

The noise peaks are detected at 0th, 256th, 512th, 768th bins (i.e. quartiles given 1024 frequency bins). My question is why these particular quartile positions? My initial thought was the hop-size being ¼ of win-size, or the dilation being power of 2 in WN interacting with the bias values in an unexpected way, but these are just my baseless suspicions for now.

This is because Waveglow generates 8 samples at a time.
Assume there is time invariant mel spec. input and sigma=0.0.
In this case the model is deterministic, resulting audio is periodic, and its period is 8 samples.
To remove this effect, sigma must be sufficiently large and the model must handle cross sample correlations appropriately.
Perhaps because the model can handle long-distance crosscorrelations more easily with large n_group, as @triwoods pointed out, this periodic noise can tend to be removed more quickly, though I don't have formal proof of it.

@ishihara1989 That makes a lot of sense! Gave me an aha moment.
Thank you very much for taking your time to ponder and answer my question.

@rafaelvalle
Firstly, thanks for your gread work about waveglow project.
My questions is that: how to automatic remove the line noise in inference process？Thanks
PS: In inference stage, I use --denoiser_strength option which is aiming to removes model bias, and I start with 0.1 and adjust the value, but I found the line noise still exists.

waveglow_eval_group_32.zip
Here is my config.json and we do not hear any line noises any more. In my experiment the training lasted only 4 days on single GPU to achieve such results.

waveglow_eval_group_32.zip
Here is my config.json and we do not hear any line noises any more. In my experiment the training lasted only 4 days on single GPU to achieve such results.

Hi @jaeseongyou , why did you feel confused with my evaluation? I know the results are not good enough since it only took less than 300 epochs. Please speak out your confusion and let me know it.

 But I keep training and now it is up to 1k epochs. If there are still line noises please let me know.

Hi @begeekmyfriend.
As @MuyangDu pointed out, I thought the audio files you posted still suffer from the same noise problem. Above is the spectrogram of your 1k result, which seems to have a lot more lines than the outcome based on the original config. It might have something to do with you changing the number of group from 8 to 32.

@jaeseongyou But the final results do nothing with whether the spectrograms look good or not. In my headset I do not hear any line noises any more, right?

@jaeseongyou But the final results do nothing with whether the spectrograms look good or not. In my headset I do not hear any line noises any more, right?

Nope, I can hear strong line noise in your samples. Maybe you can try to use another device or headset to test your samples.

the line noise seems more obvious after trained more epochs. But in the sample provided by nvidia, there are very clean without this problem. Still don't know how to prevent the line noise.


Elements no longer in the DOM should be removed on refresh

While poking around with removing elements, I noticed that elements that have been removed from the DOM still have their listeners and such stored in the Context.
These elements are never truly cleaned up and remain because there's a reference to them from the waypoint object.
Can we possibly remove the waypoints on refresh if we notice that the elements are no longer in the DOM?

Here's an untested snippet: https://gist.github.com/patrick-mcdougle/0d72e18f9f52cc586a6c025f7ab6745f/revisions


Touch support

I've got mixed feelings about some of this - like that each touch enum has a position in it. I could have done it more similar to how the mouse events work.
I've tested the todo and tour examples on my iPhone 8 with iOS 13.2.2, the things that don't work are:

Text input (though, the cursor ends up in the text box) - I think we need to signal to winit to pop up the keyboard.
Touch scrolling on a scrollable widget. Given that the logic around cursor and touch movement not having the previous location, this didn't seem very easy to do. Fortunately, the side scrollbar works.

Here's what the tour example looks like (up to just before the rust image):

It looks like a lot of progress has been made since last year, how's this looking?

Now that #181 landed, I think we can get this ready for merging.
@simlay We should rebase and remove all the merge commits. Let me know if you need any help. I could also take it to the finish line from here.

@hecrj Well, I squashed the commits (it was a pretty brutal rebase) but it seems that https://github.com/servo/font-kit/issues/115 font-kit has moved to using pathfinder_geometry to draw stuff which breaks the build for aarch64-apple-ios (all modern iPhones).
Looks like there's a bunch of issues similar to:
no method named `min` found for type `pathfinder_simd::scalar::I32x2` in the current scope
I might submit a PR to the pathfinding repo if it's not too hard.
I haven't been keeping up with all the widgets this project has added since I opened the PR so I'm not sure which widgets don't have touch support.

@hecrj This good to merge?

Does that PR also add IOS support for iced ?
Might be totally unrelated, but is that project relevant for that PR ? And for IOS support in general ?
https://github.com/BrainiumLLC/cargo-mobile

I think I've brought this up to speed.
I have ended up turning the Touch struct back into an enum in 3bdf931925067acbaabf040f6c437a54640ed1a0, given that this is how we handle mouse events now.
Proper support for the latest widgets is missing, but I imagine we can add that in further PRs. For instance, #650 seems to be adding touch support to the PaneGrid and the PickList. It may be interesting to rebase that PR on top of this one, once we get this merged.
As always, let me know what you think!

Great news!


websites are not loading,  some sort of DNS resolve issue.

OS/Platform
Windows
Installed
https://ungoogled-software.github.io/ungoogled-chromium-binaries/
Version
108.0.5359.95
Have you tested that this is not an upstream issue or an issue with your configuration?

[X] I have tried reproducing this issue in Chrome and it could not be reproduced there
[ ] I have tried reproducing this issue in vanilla Chromium and it could not be reproduced there
[ ] I have tried reproducing this issue in ungoogled-chromium with a new and empty profile and it could not be reproduced there

Description
websites are not loading,  some sort of DNS resolve issue.
How to Reproduce?

search for a site I've not been to before
the page will try to load, fail, refresh once and sometimes load, sometimes wont.

Actual behaviour
the site does not load,  it auto-refreshes once that I can see, then will usually fail.  looks like a DNS issue with the browser.
Expected behaviour
the page should load,  it loads fine on chrome and firefox (latest versions) without any of this DNS problems or refreshing of a page.
Relevant log output
No response
Additional context
I'm using Win10 Enterprise LTSC 1809, this is a work systems critical computer that has to use long term branches.

It would help if you hit F12 after loading the website and telling us the errors the console is giving you in red.


Translatable class

Create Translatable (or named similar) class for passing as a param into smarty templates

Done
https://github.com/cargomedia/CM/pull/1794


Stats not available after run completion

Using jade v0.4.9, stats are not available after my run completes, e.g.:

I'm trying to run  jade stats collect, but that is taking many minutes to run and hasn't yet completed. I also felt compelled to get a debug node to run it on. What am I missing?

I would guess that you did not enable collection of resource stats. That is disabled by default. You have to append -r X (where X is the monitor interval in seconds) to jade submit-jobs.
I could detect this condition in jade stats show and provide a meaningful message instead of dumping an empty table.
The command jade stats collect is a standalone source-monitoring tool. I intended it for uses case like

You want to collect stats on your laptop while something else is running.
You are running some application in an interactive session and want to monitor the stats.

The default behavior is to monitor indefinitely, which is why it never completed. My thought was that the user would press Ctrl-c when their app is done. Checkout the help for the command and feel free to comment on whether it should be more clear.

Collecting resource stats was the default behavior in earlier versions of jade, yes? In general that would be my preference. The default collection rate could be set to be fairly slow, e.g., 60s, perhaps adjusted some based on walltime.
Alternatively, is it possible to specify this setting in the config file?
Of course I will start specifying -r X when I submit-jobs in the meantime ...

I changed the behavior in v0.2.5 because most people using Jade weren't looking at the stats and the log files were getting very large. I'm open to polling users and adjusting it again. Another thing I could do is only collect memory and CPU stats by default. Network is usually a don't-care and disk stats don't measure Lustre I/Os.
In the meantime consider using the submitter-params config file. Refer to jade config submitter-params --help.

Do you actually care about periodic stats? Another solution is to sample regularly (every second) but only record min/max/average on those samples at the end of a node allocation or on some much longer interval. This could give you the max memory usage every hour, every day, or per-node. There would be minimal storage consumption and this could be the default.

I do not care about periodic stats and definitely up-vote that idea :)

Ok, then the plan is to make this the default behavior:

Take samples every second
Track the min, max, and sum of each stat in memory.
Record the min, max, and average when the node allocation completes.
If the user provides -r X on the command line, follow the current behavior.


refactor(api): create robot-server subproject

overview
api is being split up into two projects. This creates the webservice portion of the split.
The whole api project was copied to a new monorepo sub-project called robot-server.
The server (aiohttp) and app (fastapi) packages were copied over along with the tests. Everything else was deleted.
review requests
This is a work in progress.  Notice that it's to be merged into api_splitup, a feature branch for the split up.
closes #5011

@sfoster1 The goal is to remove the aiohttp package, isn't it? Is the history so important? I can redo as a git mv. I'd really rather not keep one foot in and one foot out. (the feet are metaphors for api and robot-server... bleh).
Also, I should have mentioned this, but the build and Makefile changes will come in a separate ticket/PR. Your comments will not be ignored. Is that cool?

Abandoning this PR in favor of #5083


Use save_pretrained to make the model locally available

Background:

Currently, we use from_pretrained with the cache_dir option to load the model and upload the cache directory to the BucketFS
The current approach in general works, but seems to check each time online if the model exists, or we have access and if we have the newest version
This is not possible in some deployments
To solve this issue, we could follow the following example using save_pretrained which stores the model into a directory which we then could upload
We can then load the model with from_pretrained from a local path

Acceptance Criteria

Change download of model to save_pretrained
Upload the save model to the BucketFS
Use a local path to load the model during inference

suggested splitting of this ticket:

familiarize self with huggingface api
add new functionality

download

upload

load

add tests for new functionality

download

upload

load

change code to use new functionality ,remove check for newest version (should this be toogleable?)

download

upload

load

new tickets are

#143
#144
#145
#146
#147


Add Oracle Database Exporter

Thanks for your PR. In order to make things easy for users, we try to only list one exporter for a given thing and we already have an Oracle DB exporter listed. I'd suggest that if there's something missing from the current one, to work with the author(s) to improve it.

Thanks for the clarification and understand it. But, Oracle Database Exporter is a better option to monitor the Oracle database.


remove boost dependencies

c++11 and c++14 introduce new features that often replace the boost libraries (in many cases, incorporating the boost implementation).   Boost is a rather large set of packages, and looks not much is lost by moving away from it and making gippy more portable.

fileystem functionality isn't really used internally much at all, so can safely be removed (just use string instead).

shared_ptr: c++11 implements smart_ptr and direct replacement for boosts shared_ptr

boost logging wasn't really used (implementation was started, but never finished) so can be safely removed

boost bind for dynamic binding of functions: this is the tricky part, however c++11 lambda functions may prove to not only be a replacement, but also be a better implementation which will make it easier to implement #2

<boost/filesystem> is implemented as  in c++14.  However, c++14 isn't fully supported by gcc 4.8 which is the version on Ubuntu 14.04 LTS.   It is supported by clang (osx).   It would be useful in the future for better error checking when c++14 becomes standard.
Looks like boost bind is implemented in c++11 though, so this may end up being a direct replacement for now after all.  Lambda functions still worth looking into at future date.

std::bind was not a drop in replacement for boost::bind, trying to fix led me down the path of lambda functions which proved to be a better and simpler approach after all.