Adds unwanted borders to images when using the orientation parameter

When I use the &or=0 parameter, it adds a border.
When I do NOT use that parameter, it does NOT add a border.
It also does NOT add a border when using or=90, or=180, and or=270
(see images below)

Interesting. What version of Glide are you using?

Just updated to the 1.0 version to see if it would fix the problem...but seems to exist on both 0.3 and 1.0 versions.

Are you using GD, or Imagick?

I'm not explicitly defining the image handling library - doesn't it default to GD?

Yes, it defaults to GD. So, I'm not really sure exactly what's happening here. Version 0.3 of Glide didn't even have border support, so it's impossible that it happened because of that. It almost looks like your image may be a transparent PNG, with a 1px or 2px transparent border around the outside. Then, when the image is being created as JPEG, a black background is automatically applied, causing a border look like this. Can you confirm if that is the case?

I will check the picture and let you know on Monday, but if that was the
case, wouldn't the picture have a border when rotated 90 degrees or more?
When I use or=auto or or=90 it doesn't have a border.
Only happens with or=0
On Fri, Oct 9, 2015 at 3:14 PM Jonathan Reinink<EMAIL_ADDRESS>wrote:

Yes, it defaults to GD. So, I'm not really sure exactly what's happening
here. Version 0.3 of Glide didn't even have border support, so it's
impossible that it happened because of that. It almost looks like your
image may be a transparent PNG, with a 1px or 2px transparent border around
the outside. Then, when the image is being created as JPEG, a black
background is automatically applied, causing a border look like this. Can
you confirm if that is the case?
—
Reply to this email directly or view it on GitHub
https://github.com/thephpleague/glide/issues/103#issuecomment-146976209.

These were JPG files, so there isn't any transparent border around the outside - any other ideas what it could be?

Would you mind emailing me<EMAIL_ADDRESS>the source image so I can run some tests?

I'm going to close this, as I haven't received an test image. However, if you still need help, please feel free to email me and I'll doing some testing on my end. Thanks!

Hi @reinink, I'm observing this same issue using Spatie's 'Responsive Images' addon  for Statamic, which is using Glide under the hood.
It seems like this has been an ongoing issue for sometime, but hasn't reared it's head enough to be esacalated, Saw a few different comments/threads on Statamic's different support channels like this one: https://statamic.com/forum/5378-glide-images-black-top-border. I remember having the issue myself on a previous project, but managed to find a workaround at the time.
I have confirmed the original image file(s) don't contain any border, and there aren't any transparency issues at play as the source files are jpgs. I can also confirm there is no CSS at play creating the border — it's within the generated image output.
I'm not doing anything particularly unusual. Here's the snippet I'm using with Spaties responsive images tag:
{{ responsive:image alt="{alt}" ratio=".75" glide:width="900" }}
Strangely enough, when I remove the glide:width="900" attribute (which sets a max width of variations to be generated) the border dissapears.... when I add it back the border returns! It doesn't happen on all images, so it seems like it could be a bug/issue depending on the cropping required for that specific image, but that's just speculation on my part!
This is happening with the default GD driver, haven't tried using Imagick for this site yet, but will test this down the track possibly.
Some screenshots for reference below:

Happy to supply further info as required. Would love to assit in squashing this bug — it's the only issue I've had with Glide to date! if you think I should raise this directly with Statamic as well do let me know
With thanks,
Andrew


demo-box disapper after swtiching markdown files

https://github.com/njleonzhang/docsify-demo-box-react/blob/5ca08e323466fb7eb5f65efb1b1c0dda287cc06a/src/plugin/index.js#L15
It seem the renderer.code doesn't execute after switching files.

fixed and release 1.0.1. please have a try

It work as expected now. Thanks!

Are you using this plugin to write a doc for some library? If yes, would you mind if I show your project in my readme as a sample？

Of Course! With pleasure.
https://sodalife.github.io/soui-react/

It's cool!
更新了readme , 有时间学习下
另外通过desc可以给例子添加说明，你好像没用这个功能。不知道你是不是没注意，提醒下有这个功能。:)
https://njleonzhang.github.io/docsify-demo-box-react/#/?id=sample

Get √
确实没注意到 :+1:


Using without explicitly passing a storage engine is throwing an error

@naptiv reported this in https://github.com/feathersjs/feathers-authentication/issues/84:

Btw, I had to change .use('storage', localstorage({"storage":memory})) as I got a ReferenceError: window is not defined at new LocalStorage @feathers-localstorage/lib/index.js:32:41

@naptiv are you using webpack or babel? I'm wondering if it is a shimming issue.
Maybe we shouldn't be expecting window to just be there and instead you always get the developer to pass in their storage engine explicitly. cc/ @daffl

@ekryski webpack based on this boilerplate https://github.com/RickWong/react-isomorphic-starterkit

Ya the issue is that with webpack you need to shim the window object. So you end up with something like this in your config.
externals: [
        {
            "window": "window"
        }
    ],

Not sure how I want to proceed here. I think it actually might be more flexible and work "out of the box" better if we explicitly get people to pass in their storage engine.

We should probably also set https://github.com/feathersjs/feathers-localstorage/blob/master/src/index.js#L7 to
this._storage = options.storage || (typeof window !== 'undefined' && window.localStorage);

And then throw an error if this._storage is undefined.

Ya I think you're right @daffl


implement blog

I've only implemented the basics at this point, i.e. post overview, basic pagination and the post layout itself, as I'm not certain whether we really need stuff like categories at this point. I've also made a couple of minor changes to the overall look of the site to better accommodate generated post HTML.
Preview is available at https://toncherami.github.io/polybar.github.io
I've also added a couple of posts to the other example repo so you can judge how it actually looks - https://toncherami.github.io/polybar.preview
Some post creation guidelines (perhaps these should be put into an md file somewhere):

Posts are written using Markdown (kramdown). They are to be put into the _posts directory. Post file name has to be of the yyyy-mm-dd-post-name.md format, zero padded if necessary.

Posts can have variables defined in their front matter (which is yaml), e.g.
---
variable: true
author: John Doe
---
... Your Markdown goes here

Variables you can specify:

author - author name, also used as part of github URL unless account is specified. It has to be specified.
account - if specified, used as the account part of an author github URL, like so - https://github.com/$account. Allows your author name to be anything you'd like it to be, e.g. if author is Polybar Team and account is polybar the github link in the post header
will be Polybar Team.
title - post title, if omitted the non-date part of the post file name is used, dashes stripped and capitalized.
excerpt - post excerpt, goes below the post title in overview. It has to be specified if the very first thing in your post is an image. If omitted first paragraph of the post is used. It is a good idea to specify it if the first paragraph is not a good fit by itself, for example if it is in fact a header.

H1 is reserved for the post title, please avoid using it.

I suppose it would make sense to have posts submitted here as PRs so they can be proofread before being merged.

Categories could be useful when differentiating between official release announcements vs. less formal stuff (like code explanations, tips, etc.)
Not too fond of #f3eaee on https://toncherami.github.io/polybar.preview/blog/, could we use another color for the blog entries instead?
Also, the commit message for 2325c5b has a typo.

Yeah, I suppose so, they can be implemented at a later time though, once we have enough posts to actually make use of them.
What exactly do you not like about it? Should it be less pink, more austere or something?
Thanks, fixed.

I've pushed some changes to the preview repo, let me know what you think.
Regarding images in overview, I feel we would be better off without them; in my opinion they serve little purpose in a technical blog and if chosen poorly one image could ruin the look of the entire page, yet it would be tricky to design entries in such a way that would allow to omit them.

Now the code blocks work correctly on all my devices as well :+1:
The banners in the blog look really amazing, I'm a big fan of the new design.
Will do a more in-depth review next week hopefully.
Just one thing right now, in the blog entries page, the author should also be a link.

Marvelous, I'll try to clean things up a bit and will then do a rebase here.

Nice, looking forward to it. It should also help us discover any shortcomings the current design may have.
Certainly, is it okay to have it replace Submit an Issue? I'm not a huge fan of how the navbar looks with four items present.


click item not work

vue-autosuggest version: 1.7.1
node version: 10.3.0
npm (or yarn) version: 6.1.0

Relevant code or config

What you did:
by click one item of result lists to select one.
What happened:
click not work

Reproduction repository:

Problem description:
Suggested solution:
can select item by click item

1.7.1 was immediately deprecated because of this bug. Use 1.7.1-2 please and let me know if you have same issues

1.7.1-2 resolve my problem


Huge gap between the playlist and video being played when used with krystal plug in

This is from the demo site.

This is when i am using mediaplayer with krystal plug in

There is a huge gap between the playlist and video being played
Here is a demo wiki
Krystal + tiddlyclip + mediaplayer.zip

This is caused by the krystal plugin re-defining the tw css - you can delete the highlighted rule to remove the problem:

This is caused by the krystal plugin re-defining the tw css - you can delete the highlighted rule to remove the problem:

when i remove it, the scrollbar at the bottom is disappearing

instead you can try removing this line then reloading the tw

instead you can try removing this line then reloading the tw

That one worked. Thank you


How to not override holder kml

Is there a way to not overwrite the names of the features in a kml file, keeping the original format in geojson?

Folders.

https://pt.stackoverflow.com/questions/436514/how-to-not-override-folder-kml


docs: Fixed image links in readme

Using githubusercontent urls so that images on https://www.npmjs.com/package/hygen are not broken anymore

Thanks!!


remove KKT_temp when LDL fails.

Resolves #44
Now Valgrind is happy
-----------------------------------------------------------------
           OSQP v0.2.1  -  Operator Splitting QP Solver
              (c) Bartolomeo Stellato,  Goran Banjac
        University of Oxford  -  Stanford University 2017
-----------------------------------------------------------------
problem:  variables n = 3, constraints m = 7
          nnz(P) + nnz(A) = 20
settings: linear system solver = suitesparse ldl,
          eps_abs = 1.0e-03, eps_rel = 1.0e-03,
          eps_prim_inf = 1.0e-04, eps_dual_inf = 1.0e-04,
          rho = 1.00e-01 (adaptive)
          sigma = 1.00e-06, alpha = 1.60, max_iter = 4000
          check_termination: on (interval 25)
          scaling: on, scaled_termination: off
          warm start: on, polish: on

iter   objective    pri res    dua res    rho        time
   1   0.0000e+00   1.00e+00   1.00e+02   1.00e-01   8.16e-02s
  25   0.0000e+00   3.94e-04   1.21e-04   1.00e-01   8.90e-02s
polish in init_linsys_solver 1
polish in init_linsys_solver_suitesparse_ldl: 1

status:               solved
solution polish:      unsuccessful
number of iterations: 25
optimal objective:    0.0000
run time:             9.40e-02s
optimal rho estimate: 1.98e-03

==32542==
==32542== HEAP SUMMARY:
==32542==     in use at exit: 0 bytes in 0 blocks
==32542==   total heap usage: 136 allocs, 136 frees, 11,460 bytes allocated
==32542==
==32542== All heap blocks were freed -- no leaks are possible
==32542==
==32542== For counts of detected and suppressed errors, rerun with: -v
==32542== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)

Coverage decreased (-0.05%) to 85.144% when pulling 411b061d2f7c6eb1faaf0c2f52afa5215ade78bc on hongkai-dai:clear_KKT_temp into fe99529722f699184ec9fd1691882f9e7705b157 on oxfordcontrol:master.

Great! Thanks for this pull request.


fix(organisme): refresh ds

:tada: This PR is included in version 1.9.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


ibc-go feature: Beefy light client

Summary
Beefy light client on ibc-go needed for Substrate <> Cosmos cross-chain transaction(ICS20).
Problem Definition
The substrate-ibc project to enable Substrate <> Cosmos cross-chain transaction(ICS20) is in progress.
On the Substrate side, we use substrate-ibc pallet integrated with ibc-rs, where the Tendermint light client resides in and verifies the messages from the Cosmos side.
The Substrate uses GRANDPA for block finalization and adopts Beefy as a secondary protocol alone with GRANDPA for efficient bridging. On the Cosmos side, a corresponding light client is needed to verify messages from Substrate finalized by GRANDPA & Beefy. No such light client has been released for now, and the substrate-ibc project is blocked. Composable Finance team is developing a beefy light client on ibc-go (@seunlanlege), which is in progress and can't be used for integrated testing.
The testing issue is submitted to CF team.
Proposal
We would like to develop a light client on ibc-go with updated ICS10 spec and the code of CF's light client as references. Noted that CF team is developing a Beefy light client by Rust, which may benefit the chains embedded with Cosmwasm. Cosmos chains without Cosmwasm still need Beefy light client in Golang to enable IBC connection with Substrate chains.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

Hi @livelybug, thanks for opening the issue.
If I remember correctly the Composable Finance team hit some roadblocks on their implementation of a beefy light client for ibc-go and decided to implement it in Rust instead. Do you have a plan of how you will solve those issues that Composable Finance faced on the implementation of the Go light client? And have coordinated with Composable Finance to maybe continue the work from where they left off?

One of the issues/blockers we had was: https://github.com/ChainSafe/gossamer/issues/2329

@blasrodri Thank you for your feedback, we are communicating with @qdm12 about this issue and trying to resolve it, other than that, are there any other issues during the development of the beefy light client?

@livelybug I will close this issue for now, since there's no concrete action for us to take at the moment. If you develop a  beefy light client in Go it will be not mandatory for it to be in ibc-go in order for chains to use it. From ibc-go v7.0.0 onwards light clients will need to implement the AppModuleBasic interface, so they can be regular SDK modules living in their own repositories. See this PR for an example with 07-tendermint.
Good luck with this endeavor!


chore: format all config by soulteary/nginx-formatter

@xeioex Hello maintainer 👋
In my recent work, there are some places where Nginx needs to be used.
Referring to our open source project, I found that contains many configuration files.
These configs don't seem to be well formatted, and the crunching and string handling may be borrowed from historical configs from the 1990s to 2020.
So I spent some time, with the help of GPT, finished a small tool for formatting Nginx configuration files.
https://github.com/soulteary/nginx-formatter
I hope it will be helpful to the Nginx open source community.
When I am free next week, I will write an article to talk about how to deal with configuration files, and to further improve this tool, providing a complete command line and Web WYSIWYG interface, and so on.

Good job @soulteary.  Feel free to share a link to your article here.

Hi @soulteary,
Does it have configuration options? For example for indentation level.
Looking at changes I see that it mostly fixed indentation, right?
What else was fixed?

Hi @xeioex ,
Yes, as a formatting tool, it is primarily responsible for unifying indentation and bracket suspension.
In the next version, I will add formatting options, such as indent character type, indent character amount, and a WYSIWYG web interface.
If possible, I hope that in a later version, the implementation plan of the open source community will be completely rewritten based on token (AST) & GPT, so that Lint and configuration suggestions can be implemented.

UPDATE 1: https://github.com/soulteary/nginx-formatter v0.5.0
support use  cli  to set the indent size, indent char, src dir, output dir. @xeioex

UPDATE 2: https://github.com/soulteary/nginx-formatter/releases/tag/v1.0.0
Keeping with the planning promise above, support formatting Nginx configuration in the web interface. @xeioex


chore: release 1.0.0

:robot: I have created a release *beep* *boop*
1.0.0 (2023-02-08)
Continuous Integration

fix workflow (109bc85)

Miscellaneous Chores

release workflow setup (f6b1683)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/johnhwhite/ng-keyboard-sort/releases/tag/v1.0.0 :sunflower:


Fix spelling and change the subtitle

I suggest:
Collaboration 1st, Code 2nd

| EddieHub Community | © 2021 | MADE WITH ❤ BY US |
     WE BELIEVE OPEN SOURCE IS FOR EVERYONE !!!

What do you think?
I'll be watching this and try to help to improve this repository.

Ya For sure !!

Done, I will add my github profile tomorrow.


worked on NavBar, added transition fx to hover; added img in back- ne…

…ed to stretch and send back, need to style div container for skillsDisplay and bring to forefront, change font color to #fdf800

luis went ham on nav bar and added some pic assets


On the log-in page hitting enter doesn't always trigger the loading animation

The delayed valid check was reenabling it after submit. Fixed so it stays loading


Commit working examples

There are already 2 working examples... they just suck. I'll improve them at some point then close this.

I meant to commit the generated PDFs so people can quickly see what the
template is.
On Thu, Feb 4, 2016, 4:53 PM Erik Derohanian<EMAIL_ADDRESS>wrote:

There are already 2 working examples... they just suck. I'll improve them
at some point then close this.
—
Reply to this email directly or view it on GitHub
https://github.com/Erik-J-D/sydetex/issues/3#issuecomment-180068053.

--
Sent from my device tracking my every move,
vt


[HPC][OpenCatalyst] Missing HP rule for LR decay factor

The learning rate decay factor was mistakenly left out of the HP table for the OpenCatalyst benchmark, but is a very reasonable thing to tune and is usually allowed for other benchmarks.
I think we should allow to add a rule saying this parameter is unconstrained for HPC v2.0, despite being past the freeze deadline.

I think it makes sense to make this parameter tunable. I do not see any big issues adding this to the tunable parameters list at this point in time since we are still early in the submission.


Go modules

While I was trying to help upgrade terrafrom to v0.12.12, I have found the module dependency has been changed to use Subpackage github.com/hashicorp/hcl/v2.
Based on the Version-Selection doc, to be able to use hcl/v2, it requires to do the go modules upgrade.
Furthermore, with go v1.14, go modules would be the default toolchain, so I think it would be nice that we can upgrade the build toolchain to use go modules.
Kind of relates to https://github.com/Homebrew/homebrew-core/pull/45521

This is on our roadmap, but I'm not sure if we'll be able to get to it soon. In the meantime, a PR to switch to Go modules is very welcome!

Done in #1105


Re: voltage sensor and divide

Marco, regarding voltage sensors and voltage dividers, suggest you discuss with my friend S/V Jedi in the cruiser forum LFP section.
I am interested in this.

Done! Let's hope the intended parties chime in ;-)


wluna solana to metamask--not enough gas so I rejected.. now I can't find it..please help

Can anyone help.. I attempted to move wLuna through Wormhole to Metamask.  When the transaction prompted I didn't have enough ETH to cover the gas and so I rejected.  Now my Luna seem to be lost in space ..please help
it was transaction 24oxQKizr1xUnSJjVeELpaDdQhSp1gtusuqYL4ZcwMbcM3jy79QtGgDeqRPNcJZp1H66USJAxX4NQ7PyrDLUdouQ

The transaction was successfully processed by the Wormhole network, but the client-side transaction submission may have failed. Try clearing your cache and reloading https://v1.wormholebridge.com to see if the transaction can be completed there. Make sure both wallets are connected, and select both tokens from the picker.
If v1.wormholebridge.com doesn't work, you can manually submit the signed VAA bytes below to the submitVAA method on the Wormhole contract: https://etherscan.io/address/0xf92cd566ea4864356c5491c177a430c222d7e678#writeContract
Note that Wormhole v2 was recently launched on wormholebridge.com, which fixes the bug you encountered! You will still have to use v1 to complete your in-progress transfer.
You can also try using the third-party https://www.interstellar.tk site to retry your VAA submission.

Digest (for reference only): ebd2e1649ab4b92b29cfc7b31be69e652422a83fc6fc24b475edb71b14e57211
Signed VAA bytes to submit to the contract:

0x01000000010d00330591bec5c52ec2a5b86ae1636a9a592b1757d01807b881c79a6d3c329dce84039234c752b3282e03a2de83a0e69697117132e5da02d25d085d5d2ed707fbac00015ec0a325d4c33bd7648126201577965d183225a06aa3bb1d237e89bd5e2d02fc6950224a564d0e4f79e8b38bbca74b34e34d160cb40793cd854ce704313ef36601037448a3f56cf38840196d9abb9457406b19de3d059785780c29d2e6118f06acd0720775a1694e393cc71bcb1420a9fe98957501c7913577e4917d129efe464207010437d66152f09a331fc09869a7dd5ae227e3d7006e8ee5af21e415b83cffbdf8ed24301a790f32f148661fe3934592d43cf9090c4e9ab12f9e0ba64617d1d86400010522c8d80a9e94299f881195f397179450d18988bf83aa1a582f262602b45933cb21c29f537b0e12c6448ac8d3e848b1404eb7eea222e1dd30f655449bb07013740006ac9d1f79848e6dbb04cefad90d0356e03127eccd896700fb7b824c728e854a60117709b6b4f30770a868fea433f98d2fd01dc8b60646d0cac0e8acb74f327f3a01078cd5799c00c5e749d311b8f8162000f7911272cae01824d69a1a1f9f57b72e186c9fe8321c5cdc85d683996db2bdb81e886f53517baccb4a90b9af35d01f6ceb0009302ccbf804caa0a1914972f1a55c5f1e6dbc791e2a1f646aa65d5f98531830d953ce390a81407ea7a553e1abf9c731a84d6454984a02553aab6ae5e8ffa97cee000a33e60ff7522402f60bad7467f6490f1319957b20fff020cd68124674ae9022881f6b6a5a9ac6fe5ec515f0acc2850178e385293ab9493e792087413f3c698d25010d7b276fb201526a19897804eb64772cf0f2a2534e04215d6aafb4dd8cd83bff1679cc8853c2e8c559071164e89abdfb7fe952869156d81c03e77b208d92f2981b01105d1f1d8e432ad8e64e01f4c276d41692c47705ff0c86ae6a2e452777ea27213a438f3006d52a57e8cb3e94c24120dc4c8e11ed79729fe8338eac3239c290626d0011c5cc1aee34c8da8e9a3445a04e17bab6d6195c69ceeba75158eb93e07c83296a618ed579e6142711aafbaffa9c443ffd8c6b2e88f929fdecc08b7ef6e6daa1120112d573614b2ef48f2482b0afd9159dc40a51d4587f3475a2910fd7f90a346621dd038c501c64775e4efe7f86054952352c37d6bd8816402b5b0ee6543cd2cda077006141b949100000e0790102db237b9a8f5f47b1dcb9a85842b10ca00f194604dc1922c5b1909e378ab435f8000000000000000000000000e95d57aebf657dae7689410bd7aaadc32109534b02000000000000000000000000d2877702675e6ceb975b4a1dff9fb7baf4c91ea90900000000000000000000000000000000000000000000000000000002540be400


Remove testing logs

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 24.86%. Comparing base (a6e56ea) to head (a939f2a).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #411   +/-   ##
=========================================
  Coverage     24.85%   24.86%
  Complexity      513      513
=========================================
  Files           138      138
  Lines          5307     5305    -2
  Branches        645      645
=========================================
  Hits           1319     1319
+ Misses         3797     3795    -2
  Partials        191      191

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix for overlapping text

Fix for overlapping text visible before login. Copied from:
https://github.com/HalianElf/Deluge-Dark/issues/1

Thank you for the PR!
Please remember to add a before and after screenshot(s) on any css changes!

Thanks!


afterStep not being dispatched with custom ui

Describe the bug
Hi! here I am again 😅
the after step seems not being dispatched:
      on: {
        afterStep: function () {
          alert('testing')
        },
      },

To Reproduce
Steps to reproduce the behavior:

use the custom ui https://v-onboarding-docs.fatihsolhan.com/examples/custom-ui
create one or more steps with on.afterStep

  const steps = [
    {
      attachTo: { element: '#create_quest_button' },
      content: {
        title: trans('Create quest'),
        description: trans('If you want to create a task for others to do, click on Create quest'),
      },
      on: {
        afterStep: function () {
          alert('testing')
        },
      },
      options: {
        popper: {
          modifiers: [
            {
              name: 'offset',
              options: {
                offset: [10, 20],
              },
            },
          ],
        },
      },
    },
  ]

Desktop (please complete the following information):

OS: macOS
Browser chrome
Version 102

Hi @ibrunotome, thank you for catching this bug. I will investigate it and will get back to you with a fix asap


QtCreator plugins no loads

After upgrading from IDE to version 4.7.1-1, it does not want to load the dependencies needed to run properly.

I can’t reproduce. See that Qt5 is patched properly with qtbinpatcher

I downloaded the original qtcreator and find out that the same plugins folder in msys2 was missing dependent libs. I copied from one to the other and it worked again. So the IDE in the repository is incomplete.

What libraries missing?


Dev-UI Pages and Collections Editor (Roq Back-office)

I've been dreaming about it for a while now 💭.
Some kind of fancy backend for Roq in the dev-ui:

CRUD new posts
CRUD new pages
With markdown and asciidoc preview and all..

This would be a great feature for one or more new Roq contributors.
It covers a lot of things and should be really cool to do...

@phillip-kruger and I talked about adding a text editor component for files. maybe add the basics in core-devui and then roq could add devui tiles with preview of asciidoc/etc.

+1

I guess we could also integrate this with AI in dev-ui to help writing articles. @maxandersen wdyt?

It could automatically guess tags and suggest description and stuff like this..


envVar units

BOUNDARYLAYERHEIGHT is in cm. Should be in m
PRESS is in torr. Should be in mbar

I need to check this. It may be all right, depending on how the variable is used.


Drop unnecessary lifetime annotations

The 'static lifetime annotations on ArchiveIterator::read_from() hinder the usage on non-local variables, e.g. a given slice of bytes wrapped in std::core::Cursor.

Could you fix the code formatting issues and force push?


Support safe mode

I prefer if function returns error instead raise Lua errors.
E.g. if i get info from untrasted source I want return either info or error message.
Now I have to use pcall for such thing.
I like way how it was implemented in cjson library.
It just provide 2 module cjson and cjson.safe.

I agree. Happy to add functions that return nil, err, errno and keep old constructor for compatibility

Let me know what you think of #10. Pick me some better function names if you can :)


USER PROGRESS

Hi @devianl2
have any update to track user sco for any module uploaded and how to save this data in database if u had any information about this u can explain how to use it
thank you

If possible I'd like to see an example of user tracking works too.

@CThomas87 In order for you to track user progress from scorm, you have to implement an IFRAME with sort of javascript to read the variable from SCORM package. This package is focus on SCORM package extraction and function to store user learning progress. You may read the article below to get some ideas how to sync SCORM information from frontend to backend.
https://scorm.com/scorm-explained/technical-scorm/run-time/?utm_source=google&utm_medium=natural_search

I do not see any further reply. This post is mark as closed now. If you have any question in future, feel free to open another post. Thank you


Always constrain popper to collison boundary

Fixes
https://github.com/radix-ui/primitives/issues/393
Description
Adds size to the middleware pipeline to ensure the resulting placement doesn't overflow the collision boundary. Instead, the content will be given a max height and overflows will be handled with scrolling.
Goal / Motivation
Allow Dropdown menus that go outside the collision boundary to be scrollable instead of just going off screen where users cannot use them.
Approach / Alternatives
I'm not married to the approach I currently have in the PR. What I dislike about it is that it makes the assumption that consumers of the library will want their content to scroll when the popper goes outside the collision boundary. I do think that it's a good default however, so it's the approach I went with. One of the primary downsides is that having the scroll behavior on the content is gets coupled with other styles that get passed in for the content itself). For example, a menu with a border-radius & border will cause clipping with the scrollbar:

Alternative:

Store the availableWidth and availableHeight in the middlewareData (also passed into the apply fn used with size) and then store them on the content wrapper as CSS variables (e.g. --radix-popper-available-height & --radix-popper-available-width). This would avoid introducing new behavior, but also allow consumers to apply their own styling using the CSS vars (example below). Additionally, it would allow people to setup their own scroll behavior, which would allow them to use a parent/child div to separate the content styles from the border styles, which would allow better looking scrollbars.

<DropdownMenu.Content
  style={{
    maxHeight: 'var(--radix-popper-available-height)',
    overflowY: 'auto',
  }}
>
  {children}
</DropdownMenu.Content>

Hey @timothympace,
Interestingly I have already solved this in this PR #1853.
And rather satisfyingly I went for the approach you described in your alternative.
I will therefore close your PR as it's addressed there.


[BUG] Main Screen: On 'role info' page, clicking on "Help Others" button leads to a blank page

Describe the bug
On 'role info' page, clicking on "Help Others" button leads to a blank page
To Reproduce
Steps to reproduce the behavior

Go to https://reach4help-staging-web-client.firebaseapp.com/
Go to 'role info' page
3.'How can we assist you' page will be displayed
Click on 'Help Others' button
The blank screen is displayed

Expected behavior
On 'role info' page, click on  "Help Others" button should display the 'Find Requests page'
Screenshots

Desktop (please complete the following information):

OS: Windows 10
Browser: Chrome
Version: 81.0.4044.138 (Official Build) (64-bit)

Smartphone (please complete the following information):
N/A
Additional context
N/A

ZenHub Information
This information is updated automatically. To modify it, please use ZenHub.

I have pushed a fix for this issue

Regression testing is done! issue resolved.


Archive creation fails if directory name is shorter than 3 characters

File.createTempFile is called with the given directory's name as a prefix. If it's too short, this will fail with an IllegalArgumentException. The prefix should be padded so this doesn't happen.
File destinationFile = new File("/var/tmp/1")
File sourceFile = new File("/var/tmp/2")

Archiver arch = ArchiverFactory.createArchiver(ArchiveFormat.TAR, CompressionType.GZIP)
File archiveFile = arch.create("64cacf30-b294-49f4-b166-032a808d73cd", destinationFile, sourceFile)

See: https://stackoverflow.com/questions/48806562/java-io-file-prefix-string-too-short-but-its-not

The prefix should use the String archive instead of the File destination name. If the value is still too short, simply provide a constant value (jarch), this is a temporary file so this is not important.


Fixes bid status not updating

This is for Purchase-290 but it needs more testing before merging.
Here's the cause of the bug:

ARArtworkView fetches API results when new bids are placed.
We were relying on ARArtworkView to notify subviews when there is new bid status (from API fetch).
We expected the model in the nested ARArtworkActionsView to be updated in-place based on the fetch but they weren't.

The solution is to pass down the new sale artwork model as a parameter to the updateUI function.

Ah, this makes much more sense to me. Tested and working in the xcode simulator.

Thanks Erik! Appreciate the help testing – I've also verified that it works. Feel free to merge when ready 👍


Improved undocking

Currently, publishing to the undock topic simply switches control of the robot back to the user (after the robot has entered the docking demo). It would be nice if, on top of this, the robot also backs up slowly for a short distance. Similar to how the built-in cleaning behaviours work when starting on a docking station. Unfortunately, iRobot has not exposed this undocking behaviour, so we have to roll our own.

Could you not write a simple program which just drives backward and then turns for 180 degrees?

Could you not write a simple program which just drives backward and then turns for 180 degrees?

Yes. I was debating whether or not it should be a routine inside ca_driver, but I think it is better to only expose the underlying interface provided by the Create/Roomba platforms. Perhaps, an undocking routine could be implemented in a separate node as an optional feature in ca_tools or new package ca_behaviours.

I would go for having them separate. I think the whole Docking/Undocking process should be done via an Action Server. You could preempt your requests and also cover all the specific cases (ex: if ordered to undock while already docked/charging - backup and rotate, if ordered to undock while still searching for the charger - stop and return control to user, etc ). This of course if you don't mind the overhead and added code complexity.

@betaupsx86 Thanks for the input. I like the idea of an action server for docking. If we want to follow the OI Spec more exactly there could be an action server for each of the possible "demos" that the base provides (ie. clean, spot, max, dock). Unfortunately there does not seem to be a notion of "done" for the actions I mentioned coming from the base. It may be simpler to leave the /dock interface as is and have the Set Mode feature for regaining control of the robot. For example, changing the mode to FULL via a message (or service call) to /set_mode will naturally preempt a docking procedure. We can add complexity in a separate package with an undocking behaviour.

For docking at least we could query the charging state of the robot. If the base gets to the charger and starts charging then the action is complete.


display shortened website url

https://github.com/OpenBazaar/OpenBazaar-Client/issues/575

Thanks for the submission @reedrosenbluth

Good work Reed! 🎉

This is awesome, Reed!


Release 2.6.3

This is a draft of changelog for the 2.6.3 release.
Here you can find all related translations changes: 2.6.2...master.

⚠ Do not merge this pull request manually ⚠
You should approve this pull request instead. After approving, I will automatically update it (release date needs to be adjusted), merge, and tag a new release. You can read more about the process on forum.

Show release notes preview
2.6.3

General changes:

Updated Flarum core translations.

All changes: 2.6.2...2.6.3.

Success! Now you can announce new release on forum:
## Version [`2.6.3`](https://github.com/flarum-lang/hebrew/releases/tag/2.6.3)

**General changes**:

* Updated Flarum core translations.

All changes: [2.6.2...2.6.3](https://github.com/flarum-lang/hebrew/compare/2.6.2...2.6.3).

In order to update run these commands:

```console
composer update flarum-lang/hebrew
php flarum cache:clear
```


Mipmapping individual sprites from a spritesheet results in a blurriness

Problem summary
A sprite that was loaded from an image file containing only that sprite will mipmap correctly on its own. However, that same sprite loaded from a spritesheet will not always mipmap correctly even though both the sprite and the spritesheet have powers-of-two dimensions. I'm not actually sure if this is a problem in my code or in Pixi. 😢
Expected Behavior
I'm trying to get the sprites to render exactly the same regardless of the source. That way, I don't need to know anything about the spritesheet itself and I don't need to produce the spritesheets in a specific way.
Current Behavior
The sprite that's drawn from the spritesheet (i.e. the one on the right) is blurrier than the one drawn from the standalone image on the left. This is more apparent in the example code that I've included than it is in this image:

Possible Solution
I think this problem is due to the X and Y coordinates of the sprite when inside the spritesheet. I have some commented-out PIXI.Rectangle objects that point to the same image in different parts of the spritesheet, and some of those render just fine.
Steps to Reproduce
I uploaded a ZIP file here. If you prefer just the application code, here it is:
const resolution = window.devicePixelRatio;
const spriteName = "256x256.png";
const spritesheetName = "2048x1024.png";
var canvas = document.createElement("canvas");
document.body.appendChild(canvas);

var renderer = new PIXI.WebGLRenderer({
  width: 400,
  height: 300,
  view: canvas,
  resolution: window.devicePixelRatio || 1,
  roundPixels: true,
  autoResize: true,
  antialias: true,
  backgroundColor: 0xffbbbb
});
var stage = new PIXI.Container();

function mainLoop() {
  renderer.render(stage);
  requestAnimationFrame(mainLoop);
}

function finishedLoadingAssets() {
  const sprite = new PIXI.Sprite(PIXI.loader.resources[spriteName].texture);

  // The commented-out rectangles still point to the same general sprite but at
  // different locations in the spritesheet.
  //
  // const rect = new PIXI.Rectangle(0, 0, 256, 256);
  // const rect = new PIXI.Rectangle(512, 0, 256, 256);
  // const rect = new PIXI.Rectangle(0, 364, 256, 256);
  const rect = new PIXI.Rectangle(504, 582, 256, 256);
  const singleTexture = new PIXI.Texture(
    PIXI.loader.resources[spritesheetName].texture,
    rect,
    rect.clone()
  );

  const spriteFromSpritesheet = new PIXI.Sprite(singleTexture);

  sprite.scale.set(1 / 8);
  spriteFromSpritesheet.scale.set(1 / 8);
  spriteFromSpritesheet.position.set(sprite.width + 5, sprite.y);
  stage.addChild(sprite);
  stage.addChild(spriteFromSpritesheet);

  mainLoop(0);
}

function main() {
  PIXI.loader
    .add(spriteName)
    .add(spritesheetName)
    .load(finishedLoadingAssets);
}

main();

Environment

pixi.js version: e.g. 4.8.7
Browser & Version: e.g. Chrome 73
OS & Version: e.g. Windows 10
Running Example: https://share.bot.land/mipmap_mvce/

Hi, Adam!
Try this one before renderer is created:
PIXI.settings.PRECISION_FRAGMENT=PIXI.PRECISION.HIGH
It should work in some cases I believe

Hey, Ivan! 😄
I did some testing based on what you said, and I've included my discoveries below (mostly for the sake of people finding this through a search engine in the future):

In this particular case, PIXI.settings.PRECISION_FRAGMENT shouldn't come into play since no filters are involved, and only core/Shader.js in v4 (moved to core/src/shader/Program.js in v5) uses this value.
The special offset works. I believe that it has to be nextPow2 of the lowest scale value ever used. So, for example, if I wanted a scale of 1/12 the original size, then I need the sprite to be positioned at coordinates divisible by 16 in the spritesheet.
TexturePacker, as in CodeAndWeb's TexturePacker, does seem to support commonDivisorX and commonDivisorY options (docs here). However, that's paid software, and unfortunately, the free TexturePacker that I'm using from libgdx only has one semi-related, undocumented option called multipleOfFour, which in my case will not suffice even if it does what I think it does since my scale value is 1/8, not 1/4.

So my options are either:

Use the paid TexturePacker with the options mentioned earlier.
Generate a mipmappable texture from the spritesheet, then make a sprite from that texture, that way the coordinates that the sprite was at in the spritesheet shouldn't matter.

Either way, it doesn't sound like this is a bug in Pixi, so I'll close this. Thanks for the help!

Hey, I left a note to @badlogic for him to make this a priority if you make that PR.

Update (not that anyone probably cares 😜): I filed a feature request to libgdx, but I ended up closing it since I think I'm going to go the render-to-texture route.
I did try out the CodeAndWeb TexturePacker and it seemed to address my issue, but I think I'm just not comfortable "solving" this entirely via spritesheet generation; I'd rather have my game code handle this.


Not able to run with restify 8

I tried to use this module using given documentation. It gives below error on trying to access docs:
{     "code": "ResourceNotFound",     "message": "/docs; caused by Error: ENOENT: no such file or directory, stat 'E:\\SmartTicket WorkSpace\\restifyTypescript2\\node_modules\\swagger-ui-restify\\static\\docs'" }
My Restify app server code looks like:
`const swaggerUi = require('swagger-ui-restify');
const YAML = require('yamljs');
const swaggerDocument = YAML.load(__dirname + '/swagger.yaml');
console.log(swaggerDocument)
api.get('/docs', swaggerUi.serve, swaggerUi.setup(swaggerDocument, { baseURL: 'docs' }))`
I tried with both json and YAML options. Please let me know if I am missing anything here?

I am also facing a similar issue on unbuntu, were you able to resolve this
code :"ResourceNotFound"
message : "/api-docs; caused by Error: ENOENT: no such file or directory, stat '/home/*****/****/*****/codebase/connector/node_modules/swagger-ui-restify/static/api-docs'"

Below is the sample code
const restify = require('restify');
const swaggerUi = require('swagger-ui-restify');
const YAML = require('yamljs');
const swaggerDocument = YAML.load('./swagger.yaml');

const {config} = require('./config');

const app = restify.createServer();

app.use(restify.plugins.queryParser());
app.use(restify.plugins.bodyParser({
    requestBodyOnGet: true,
}));

app.get('/api-docs',swaggerUi.serve,swaggerUi.setup(swaggerDocument,{ baseURL: 'api-docs' }));

const PORT = process.env.PORT || 5000;

app.listen(PORT, function () {
    console.log('%s listening at %s', app.name, app.url);
});

Would appreciate any help

I'm facing the same issue. My setup is
const restify = require('restify');
const restifyApp = restify.createServer();
restifyApp.use(restify.plugins.queryParser());
restifyApp.use(restify.plugins.bodyParser({
    requestBodyOnGet: true,
}));
const swaggerUi = require('swagger-ui-restify');
const YAML = require('yamljs');
const swaggerDocument = YAML.load('./src/api-spec.yaml');
const swaggerOptions = {
    explorer: true,
    baseUrl: 'api-docs'
};
//restifyApp.use('/api-docs', swaggerUi.serve, swaggerUi.setup(swaggerDocument, swaggerOptions));
restifyApp.get('/api-docs/:whatever', swaggerUi.serveFiles(swaggerDocument));
restifyApp.get('/api-docs', swaggerUi.setup(swaggerDocument, swaggerOptions));
restifyApp.listen(3005, () => console.log('serving OpenAPI specs'));

when I open locahost:3005/api-docs:
{
"code": "ResourceNotFound",
"message": "/api-docs/; caused by Error: ENOENT: no such file or directory, stat 'C:\\Users\\dmarq\\Tanner\\status-tanner-api\\poller\\node_modules\\swagger-ui-restify\\static\\api-docs'"
}

The documentation is out-of-date. Use something like this:
app.get('/api-docs', swaggerUi.setup(swaggerSpec));
app.get('/swagger-ui-init.js', ...swaggerUi.serve);
app.get('/swagger-ui.css', ...swaggerUi.serve);
app.get('/swagger-ui-bundle.js', ...swaggerUi.serve);
app.get('/swagger-ui-standalone-preset.js', ...swaggerUi.serve);

or, if you don't mind all otherwise unmatched URLs being processed by swaggerUi.serve, you can do this:
app.get('/api-docs', swaggerUi.setup(swaggerSpec));
app.get('/*', ...swaggerUi.serve);

@chowington Thank you very much.. your comment fixed an issue that's been bugging me

Updated fix: https://github.com/bvanderlaan/swagger-ui-restify/issues/6#issuecomment-624268765


Update Workbox to 4.1.0

Currently the generated service worker workbox version is:
importScripts("https://storage.googleapis.com/workbox-cdn/releases/3.6.3/workbox-sw.js")
The latest is 4.1: see https://github.com/GoogleChrome/workbox/releases
The import can now read as:
importScripts("https://storage.googleapis.com/workbox-cdn/releases/4.1.0/workbox-sw.js")
This update improves a number of things, including adding the much needed skipWaiting() message handler:
https://github.com/GoogleChrome/workbox/pull/1929

There are a number of issues with the service worker from the older version of the plugin. I ejected create-react-app and updated the version number in the package.json to 4.1.1 (latest version of workbox-webpack-plugin).
Most of these issues have now been resolved in the new version, and nothing else is required apart from updating the version number of the npm module. This should be a relatively simple update.

@r0ughnex would you like to submit a PR?

@iansu: Sure :)

@iansu: One more thing, I was having this issue on Chrome (on Windows 10) with version 3.6.3, but updating it to 4.1.1 resolved it. I can't reference the issue. It was auto-lock closed because it went stale.

@jadbox, @iansu: PR submitted for this issue.


Envtest

It would be nice to support something like controller-runtime's envtest helper for starting a minimal cluster per test.
https://book.kubebuilder.io/cronjob-tutorial/writing-tests.html

A minimal version that creates a temporary cluster without affecting ~/.kube/config, provide configured kube::Client, and clean up when it's dropped can be done using k3d easily.
https://gist.github.com/kazk/3419b8dd0468e1640c4575c638ef590b
#[tokio::test]
async fn test_integration() {
    let test_env = TestEnv::new();
    let client = test_env.client().await;

    let pods: Api<Pod> = Api::default_namespaced(client);
    let _pod = pods.get("example").await.unwrap();
}

running 1 test
INFO[0000] Prep: Network
INFO[0000] Created network 'k3d-c308jevs3ok61t88c0dg' (832b6396535a5538cb87bf2f29a47849011dc1d80e13e567c3c06bd23ede4cdf)
INFO[0000] Created volume 'k3d-c308jevs3ok61t88c0dg-images'
INFO[0001] Creating node 'k3d-c308jevs3ok61t88c0dg-server-0'
INFO[0001] Creating LoadBalancer 'k3d-c308jevs3ok61t88c0dg-serverlb'
INFO[0001] Starting cluster 'c308jevs3ok61t88c0dg'
INFO[0001] Starting servers...
INFO[0001] Starting Node 'k3d-c308jevs3ok61t88c0dg-server-0'
INFO[0009] Starting agents...
INFO[0009] Starting helpers...
INFO[0009] Starting Node 'k3d-c308jevs3ok61t88c0dg-serverlb'
INFO[0010] Cluster 'c308jevs3ok61t88c0dg' created successfully!
INFO[0010] You can now use it like this:
export KUBECONFIG=$(k3d kubeconfig write c308jevs3ok61t88c0dg)
kubectl cluster-info

thread 'test_integration' panicked at 'called `Result::unwrap()` on an `Err` value: Api(ErrorResponse { status: "Failure", message: "pods \"example\" not found", reason: "NotFound", code: 404 })', tests/integration_test.rs:13:42

Deleting k3d cluster c308jevs3ok61t88c0dg...
INFO[0000] Deleting cluster 'c308jevs3ok61t88c0dg'
INFO[0000] Deleted k3d-c308jevs3ok61t88c0dg-serverlb
INFO[0000] Deleted k3d-c308jevs3ok61t88c0dg-server-0
INFO[0000] Deleting cluster network 'k3d-c308jevs3ok61t88c0dg'
INFO[0000] Deleting image volume 'k3d-c308jevs3ok61t88c0dg-images'
INFO[0000] Removing cluster details from default kubeconfig...
INFO[0000] Removing standalone kubeconfig file (if there is one)...
INFO[0000] Successfully deleted cluster c308jevs3ok61t88c0dg!
test test_integration ... FAILED

failures:

failures:
    test_integration

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 12.11s

I think we can extend this (make it configurable, load CRDs, assertion helpers, etc.) to get a pretty good test helper.

I think this would be a fantastic out of the box thing to have, particularly if it can be done without screwing over the kubeconfig!
One philosophical aspect about this though. Should we be optimising this to be a general integration test setup that you only need a handful of (because of the spin-up cost), or maybe something that can do tons of little verifications in dynamic namespaces?
If each #[tokio::test] performs a full cluster provisioning step, then we are implicitly encouraging enormous test fns (and the handful of tests case).
 That way, the whole namespaced class of users could have a full cluster setup done once per CI, and run tests very fast (potentially even parallelising some down the road).

 That way, the whole namespaced class of users could have a full cluster setup done once per CI, and run tests very fast (potentially even parallelising some down the road).

Maybe we should have both? Namespaces are a good ideal but it breaks down as soon as you want to test something cluster-scoped..

I tried writing an integration test for my example controller https://github.com/kazk/cnat-rs. See https://github.com/kazk/cnat-rs/tree/main/tests.
GitHub Actions:

(note that ~/.kube/config doesn't even exist because it's never touched)
Multiple tests like this can run in parallel just fine.
To create a minimal cluster:
let test_env = TestEnv::new();

Builder to enable features (not much is configurable at the moment):
let test_env = TestEnv::builder()
    .servers(1)
    .agents(3)
    .inject_host_ip()
    .build();

If these look like a good start, we can create kube-test crate having:

kube_test: general test helpers
kube_test::k3d: TestEnv with k3d

One philosophical aspect about this though. Should we be optimising this to be a general integration test setup that you only need a handful of (because of the spin-up cost), or maybe something that can do tons of little verifications in dynamic namespaces?

I can't think of a way to put each of the small tests in a separate #[tokio::test] and use the same temporary cluster that cleans itself up. It's possible to write many small tests in one #[tokio::test] sharing the cluster, but test failure outputs will be unclear.

If these look like a good start, we can create kube-test crate having:
kube_test: general test helpers
kube_test::k3d: TestEnv with k3d

I think this would be super useful. Sorry it took so long to get back on this. A kube-test crate for these things would definitely be welcome in my book at least. IMO, CI is probably one of our weaker spots so far, so a better out-of-the-box experience here would be very worth focusing on. So many people jump at these convenience stories (like kube-derive with schemas) if the interface is sleek.
Happy to review as usual, but the code inside your test repo already looks great as a first release imo.
Also, very cool repo! Did you build cnat against all the operator frameworks to compare? That's like a cool talk topic / blog post right there.

I can't think of a way to put each of the small tests in a separate #[tokio::test] and use the same temporary cluster that cleans itself up. It's possible to write many small tests in one #[tokio::test] sharing the cluster, but test failure outputs will be unclear.

Maybe that type of parallelisation is best left up to the user if the default behaviour would be confusing.

No problem, I've been busy too. I'll open a PR with mostly the same code, with more docs.

Did you build cnat against all the operator frameworks to compare?

I was going to, but only built their client-go version. If I remember correctly, I couldn't find the versions of KubeBuilder (https://github.com/programming-kubernetes/cnat/tree/master/cnat-kubebuilder) or Operator SDK (https://github.com/programming-kubernetes/cnat/tree/master/cnat-operator) they had used. I also didn't spend much time on them.

That's like a cool talk topic / blog post right there.

Yeah, it's interesting to see what's necessary to implement the same thing. I love how straightforward the kube version is. Anyone with Kubernetes and some Rust knowledge should be able to understand, and build it. I'm not into blogs/talks, so feel free to take it :)

Going to close as it's impractical to do something like this inside kube, and there are other ways to test.
Some reasons outlined in https://github.com/kube-rs/kube/pull/564#issuecomment-1455003710 but basically; k3d is not the most reliable way to test, so we should probably not encourage multiple clusters being spun up as part of tests as a main testing method (if people want to do that they should do it on CI configuration where they know what machine they are dealing with).
Easier ways to test are through mocking, or idempotent integration tests using k3d (with some care taken to work in non-isolated environments) as outlined in https://kube.rs/controllers/testing/
Something closer to the original envtest proposal in this issue could be https://github.com/kube-rs/kube/issues/1108 but not sure if that's particularly likely to happen (and if it does, it would be an orthogonal project to kube). It might be more likely that we can lean on https://github.com/kubernetes-sigs/kwok/ in the future.


Updating the member details in the Library management System

As an administrator I need to update the details of the members in the library management System.
Following tasks has to be attended to complete this user story.

[x] Design the Patch Member API https://github.com/chinthakarukshan/lbms/issues/4
[x] Implement the Patch Member API https://github.com/chinthakarukshan/lbms-admin-service/issues/3
[x] Writing Unit Tests for Patch Member API https://github.com/chinthakarukshan/lbms-admin-service/issues/5

Story completed.


irmin: introduce an abstraction for portable commits

This is needed by users of generic-keyed backends in order to compute the hash of purely in-memory commits.
I'm not so happy with the extra boilerplate that this requires of the backends. That could be avoided by providing a helper functor such as Irmin.Of_hash_keyed_backend, but I'll leave it for a different PR as this is already the case for the Node_portable module.
Extracted from https://github.com/mirage/irmin/pull/1534.

Thanks @Ngoguey42 for the review.


Is the date time in starting_position means EnqueuedUtcTime of the message?

Is the date time in starting_position means EnqueuedUtcTime of the message?
If i want to receive messages from the certain message create time, what should i do ?

文档详细信息
⚠ 请勿编辑此部分。 docs.microsoft.com ➟ GitHub 问题链接必须具有此部分。

ID: 3882d6ff-f3f3-db47-003d-872c30e4d8bf
Version Independent ID: 6f707aa5-21b5-d508-3750-a9ccde1ffb34
Content: azure.eventhub.aio.EventHubConsumerClient class
Content Source: docs-ref-autogen/azure-eventhub/azure.eventhub.aio.EventHubConsumerClient.yml
GitHub Login: @lmazuel
Microsoft Alias: lmazuel

@HuaqiongWu Thanks for your feedback, we'll investigate asap.

Hey @HuaqiongWu , starting_position is taking either of the following three forms:

event offset (str)
event sequence number (int)
enqueued time (datetime)

If you want to receive message from certain create(enqueue) time, you could pass a datetime object as the parameter of starting_position:
consumer_client.receive(..., starting_position=datetime.datetime())

please be aware that it should be a UTC time.

as per our oob discussion, filter by creation time (not enqueued time) is not supported.
EventData.properties could be utilized to store the creation time information and do custom filtering upon receiving events.
I'm closing this issue now


[Bug]: manifest.json file should be improved

Describe the bug
The manifest.json file should be improved as it tells the browser about the website on the user's mobile device or desktop. There are some errors and warnings in the website's manifest that should be fixed as it contains the website app name, the icons used by it, start_url when launched, and many other details.
To see the errors in manifest.json:

Right click on mouse in the browser tab.
Click on "Inspect"
Jump on "Application" tab.
Click Manifest option and see it displays.

To Reproduce

short_name should be given for the web application that is displayed in homescreen or in the menu.
Instead of "Create React App Sample" in place of the name, a reasonably bigger name should be given for the web application that is useful when searching in the user's phone or desktop searchbar.
Icon size and icon type should be written properly in manifest.json as there are some errors and warnings.
"lang": "en-US" should be added as it specifies the primary language of the web application.
Orientation should be set as it will set web application default orientation, when open.

Expected Behavior
No response
Screenshot/ Video

Desktop (please complete the following information)
No response
Additional context
No response

Hi @kaiwalyakoparkar and @kunal-kushwaha, Please assign it to me. I will work to fix this issue.


Add Call for Tutorials

I attach the call for papers in markdown.
Action items:

add this page (also to the menu - can we have a 'Calls' menu item?)
add the relevant dates
check if formatting is consistent with the Call for Papers page
call_tutorials.zip

Thanks!

The email-id<EMAIL_ADDRESS>in the Call for Tutorials (appears in two places in the markdown file) does not have a hyperlink. Could you please edit the markdown to do so?

It should be fixed now!


Add no-new-priviliges check

It is usually good that have this in your compose file
security_opt:
  - no-new-privileges:true

Added in v0.3.0


Improving the hover effect on the Options(Boxes) in Internship Section

The hover effect on the boxes can be very improved very much to improve the UI .

I'd love to work on this issue

Ok go ahead @UjjwalGupta1105


Add support for hours/minutes/seconds

This PR adds support for hours, minutes, and seconds when converting to NetCDF and also when describing data.
It also changes the to_netcdf CLI to accept a separate datetime-pattern parameter instead of combining the file pattern and datetime pattern.

Coverage increased (+0.1%) to 39.596% when pulling 9f1e55e8d7fa0b30f57c24eb23b99caf2eca4f50 on time-support into 63878367e14a48497c18f3d29e2a8573624aa714 on master.

Ok, feedback incorporated.


diners club card-type added

Hi, I did a small update on the repository. I want to contribute more in the project if I have a good acceptance for this request.
Thanks ;)

This looks good.
Thanks for contributing and also sorry for the acceptance delay.


Optimize ts function runtime into multi stage build.

Reduce cold start times and remove superfluous code and dependencies from final image.

Codecov Report

Merging #210 (d170756) into develop (cf635ec) will decrease coverage by 0.08%.
The diff coverage is 58.97%.

@@             Coverage Diff             @@
##           develop     #210      +/-   ##
===========================================
- Coverage    35.94%   35.85%   -0.09%
===========================================
  Files           48       48
  Lines         4215     4242      +27
===========================================
+ Hits          1515     1521       +6
- Misses        2557     2571      +14
- Partials       143      150       +7

Flag
Coverage Δ

unittests
35.85% <58.97%> (-0.09%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/runtime/typescript.go
71.55% <58.97%> (-8.23%)
:arrow_down:

pkg/ghissue/buglink.go
90.32% <0.00%> (-9.68%)
:arrow_down:

pkg/utils/paths.go
5.55% <0.00%> (-5.56%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf635ec...d170756. Read the comment docs.


Deep Insight and Neural Network Analysis (dianna)

Adding the Deep Insight and Neural Network Analysis (dianna) Python package

@jphall663 do you accept more PRs for extending the list?

Sorry - I was really busy for a few years :( But now have help from @datherton09 :)

If you have new stuff, we want to see it now!


Storyshot fail with Typescript

I am trying to use storyshot with Typescript but I get an error that I don't manage to solve:
 ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){import * as React from 'react';

    SyntaxError: Unexpected token *

I also tried to follow https://medium.com/@mtiller/storybook-react-typescript-and-jest-c9059ea06fa7 without success.
To Reproduce
yarn add --dev @storybook/addon-storyshots
yarn add --dev @types/storybook__addon-storyshots

In my source folder I add a storybook.test.ts
import initStoryshots from '@storybook/addon-storyshots';
initStoryshots();

The wepack config is
module.exports = (baseConfig, env, config) => {
    config.module.rules.push({
        test: /\.(ts|tsx)$/,
        use: [
            {
                loader: require.resolve('ts-loader'),
            },
        ],
    });
    config.resolve.extensions.push('.ts', '.tsx');

    config.module.rules.push({
        test: /\.stories\.tsx?$/,
        loaders: [
            {
                loader: require.resolve('@storybook/addon-storysource/loader'),
                options: { parser: 'typescript' },
            },
        ],
        enforce: 'pre',
    });
    return config;
};

and the jest config is
"jest": {
        "setupFiles": [
            "<rootDir>/setupTests.ts"
        ],
        "transform": {
            "\\.(ts|tsx)$": "ts-jest",
            "\\.css$": "<rootDir>/node_modules/razzle/config/jest/cssTransform.js",
            "^(?!.*\\.(js|jsx|css|json)$)": "<rootDir>/node_modules/razzle/config/jest/fileTransform.js"
        },
        "testMatch": [
            "!**/flycheck_*",
            "<rootDir>/src/**/__tests__/**/*.(ts|js)?(x)",
            "<rootDir>/src/**/?(*.)(spec|test).(ts|js)?(x)"
        ],
        "moduleFileExtensions": [
            "ts",
            "tsx",
            "js",
            "json"
        ],
        "collectCoverageFrom": [
            "src/**/*.{js,jsx,ts,tsx}"
        ]
    },

Screenshots

Bump, also hitting this.
It seems to happen when storyshots tries to load the storybook-config file, which contains code that's not just plain JS.

@apiel @DeX3 I was able to fix similar errors by renaming addons.js and config.js to addons.ts and config.ts

@dgreuel I tried out without success :-/

I am encountering a similar issue where Jest throws on my storybook config.js file:
({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){import { configure } from '@storybook/react';

    SyntaxError: Unexpected token {

Here are my files:
jest.config.js
module.exports = {
	roots: ['<rootDir>/../src'],
	transform: {
		'^.+\\.tsx?$': 'ts-jest'
	},
	testRegex: '[.]storyshot[.]tsx?$',
	moduleFileExtensions: ['ts', 'tsx', 'js', 'jsx', 'json', 'node']
};

config.storyshot.ts (the test running the storyshot)
import initStoryshots from '@storybook/addon-storyshots';

initStoryshots({
	storyNameRegex: /^((?!.*?\(No Storyshot\)).)*$/
});

config.js
import { configure } from '@storybook/react';

// Loads all files ending with ".stories.ts" or ".stories.tsx" in 'src' directory.
const req = require.context('../src', true, /[.]stories[.](ts|js)x?$/);

function loadStories() {
	req.keys().forEach(fileName => req(fileName));
}

configure(loadStories, module);

webpack.config.js
const webpackConfig = require('../webpack/webpack.config');

module.exports = async ({ config }) => ({
	...config,
	module: {
		...config.module,
		rules: webpackConfig.module.rules
	},
	resolve: {
		...config.resolve,
		extensions: webpackConfig.resolve.extensions
	}
});

tsconfig.json
{
	"compilerOptions": {
		"outDir": "./dist/",
		"sourceMap": true,
		"noImplicitAny": true,
		"module": "commonjs",
		"moduleResolution": "node",
		"target": "es6",
		"jsx": "react"
	},
	"include": ["./src/**/*"]
}

Same here. :(

same here

I had a similar error after upgrading today. This was the error message:
  ● Test suite failed to run

    /var/www/html/node_modules/@dump247/storybook-state/dist/index.js:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){import _possibleConstructorReturn from "@babel/runtime/helpers/possibleConstructorReturn";
                                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^

    SyntaxError: Unexpected identifier

And this jest configuration helped:
{
    "transformIgnorePatterns": [
      "/node_modules/(?!@dump247).+(ts|tsx|js|jsx)$"
    ],
}

Not sure whether this helps someone.

Ran into the same issue. Very sad about this :(

We'd love to get some help fixing this, is anyone here able to help us?

For reference, the error in this thread only occurs when loading stories dynamically with require.context. If one were to load stories via just require('../src/stories/Example.stories') then it works with TypeScript.

For reference, the error in this thread only occurs when loading stories dynamically with require.context. If one were to load stories via just require('../src/stories/Example.stories') then it works with TypeScript.

Any strategies on loading all the stories into using one script like that?

I successfully use Barrelsby to generate a barrel that exports all *.stories.tsx files, then just require that single file.

Still having problems
({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){import { configure } from '@storybook/react';

    SyntaxError: Unexpected token {

 SyntaxError: Unexpected token {

      at ScriptTransformer._transformAndBuildScript (../node_modules/@jest/transform/build/ScriptTransformer.js:471:17)
      at ScriptTransformer.transform (../node_modules/@jest/transform/build/ScriptTransformer.js:513:25)
      at configure (../node_modules/@storybook/addon-storyshots/dist/frameworks/configure.js:38:11)
      at Object.load (../node_modules/@storybook/addon-storyshots/dist/frameworks/react/loader.js:26:26)
      at loadFramework (../node_modules/@storybook/addon-storyshots/dist/frameworks/frameworkLoader.js:31:17)


Windows Autopilot - Self Deploying Mode

Wondering why Windows Autopilot, in particular Self Deploying Mode it is not mentioned here as an option?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2e0c4be4-5e7b-5433-e1f6-58869677e176
Version Independent ID: 2e7c086b-cb48-e086-4ac9-b43f13f09591
Content: Set up Windows devices for education
Content Source: education/windows/set-up-windows-10.md
Product: w10
GitHub Login: @CelesteDG
Microsoft Alias: celested

@officedocsbot assign @jvsam

Hi @nimojg-microsoft just to clarify, are you suggesting that we add Windows Autopilot option in the Set up Windows devices for education document? In the Table of Contents on the left, there is a link to the Deploy Windows 10 in a school guide. Windows Autopilot, including other deployment scenarios are on a separate document category, but the docs are also applicable for Windows 10 Education. Perhaps this blog article may help as well.
Of course, we want users to have the best Windows 10 experience by ensuring the contents of the Microsoft Docs are useful, hence, if there is anything that needs to be added or edited in the documentation, please let us know. Thank you.

Hi @nimojg-microsoft. We haven't received any response from you, so for now, we will close this issue. If you believe the documentation needs improvement, please re-open and provide recommendations on what needs to be changed or updated. Again, our main goal here is to ensure users have the best Windows 10 experience by providing useful, accurate and up-to-date documentation.
Thank you for your feedback and for engaging with the community!

@officedocsbot close


venv not working for custom location (after vscode restart)

Environment data

VS Code version: 1.50.1
Extension version (available under the Extensions sidebar): v2020.10.332292344
OS and version: Win7 x64
Python version (& distribution if applicable, e.g. Anaconda): 3.8
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
Relevant/affected Python packages and their versions: XXX
Relevant/affected Python-related VS Code extensions and their versions: XXX
Value of the python.languageServer setting: XXX

Expected behaviour
After pointing 'Python: Select Interpreter' to a custom location(e.g. 'C:\VENVs\venv1'), the virtual environment is used for the current workspace, which is indicated in the status bar. Closing VSCode and reopening it, should not break this behavior.
Actual behaviour
The venv in the custom location is used correctly the first time it is added to VSCode. After VSCode is closed and reopened again, the venv is non functional inside VSCode. It is correctly configured in the workspace's settings.json. The statusbar shows the correct path while hoovering over the current interpreter, but the status bar caption is missing the indicator that this is a venv.
Opening an integrated terminal shows the (venv1) prefix, but the venv is not loaded correctly(e.g. python command is missing, because path to venv executable is not loaded). Furthermore installed packages are missing, which clearly indicates that the wrong interpreter is being used.
After making an venv unusable 'buggy'(by adding it, closing and reopening VSCode) it will show this behavior even for a different workspace, where it hasn't been selected previously at all.
Update regarding behavior
At first it seemed that the configured venv is also not used at all, but I noticed that this was actually my mistake(I wasn't aware that moving a venv breaks its function in general, because absolute paths are hardcoded in its internal scripts).
Therefore the update:
The configured interpreter seems to be used correctly by VSCode, but after closing and reopening VSCode, the sufix in the status bar, e.g.: '(venv: myvenv)' is missing. This has been obeserved not only for the broken venv, but also for new created venvs.
Steps to reproduce:

create a new workspace
create and select a venv in a custom location
verify that venv is used correctly by VSCode
close and reopen VSCode
observe broken behavior of previously selected workspace

Notes
I currently don't have the ressources to analyze this in detail - what I have seen so far:
After adding the python interpreter for the first time it gets added to the SQLite database in the configuration folder User\globalStorage\state.vscdb under the key ms-python.python. I haven't tried to tinker with the entries manually, but it is probably related to the existence of this entry?

This is probably related to the issues https://github.com/microsoft/vscode-python/issues/14607 and https://github.com/microsoft/vscode-python/issues/14592

Thanks for the bug report! We investigate issues in order based on priority and severity, which includes the impact it has on your ability to use the extension to do productive work, and the number of people affected. If other users come forward and leave a comment demonstrating they are seeing/reproducing the problem then we will raise this issue's priority.
If you think your issue is more of a question or configuration problem rather than a bug, please ask on Stack Overflow with the visual-studio-code and python labels for help.
Thanks for your understanding and patience!

I responded over in https://github.com/microsoft/vscode-python/issues/14592 before seeing this issue. It makes me completely unable to work with any other environment than the one I happened to have selected when I became unable to change it. I guess one could theoretically wipe the environment clean and repopulate it every time one wants to work on some other project, but that is not really feasible. I'd say it severely hampers the capacity to use VSC productively for those affected.
Manually switching do a different environment via conda activate other-env doesn't seem to work for me, by the way. Probably because VSC calls python.exe directly. So yeah, not fun.

Hello Silun!
As I haver stated in my update - It seems that I am actually able to use the venv without problems. The only problem, which remains from this issue for me is that the status bar does not show that the interpreter is part of a venv(after restarting VSCode). This creates the impression, that you are unable to change the venv - but the integrated terminal, as well as code execution use the correct configured venv interpreter.
You description suggests that you are probably facing a problem which I had previously, which was caused by a 'damaged' venv.
Did you move your venv to a different location on your file system after creating it? Can you verify that your virtual environment is actually working by activating it in your systems terminal and confirming that it is actually used(e.g. checking the the installed packages)?

I have not moved the venv at all. I can use all my venvs just fine in windows terminal via conda activate venv-name, it shows the (venv-name) in front of the line, and conda list gives the correct packages. I can enter and leave my environments just like I should, it's only VSC that is acting up.

@Silun I think your issue is different from the one @dmi-github stated, but it's dup of the other issue I'm investigating, would greatly appreciate your help there. Can you please fill the issue template and link more details in a comment there: https://github.com/microsoft/vscode-python/issues/14645
I'm especially interested in the last edit comment your left about "double pythonpath", please elaborate and leave a comment there, thanks!

@Silun The issue you face is dup of Closed as dup of https://github.com/microsoft/vscode-python/issues/14645

The latest update should've the fix for this, if not please let me know and I'll reopen the issue.


Addign missing owner files

Same as https://github.com/openshift-knative/serverless-operator

/lgtm

Thanks!


request for preprocessed data

Hello,
Thanks for your code for "Multi-Level Memory for Task Oriented Dialogs".
I want to run the code, but I find that your data is not original data which has been preprocessed, would you mind provide the preprocessed data or basic data_loader.py for truly running?

@doublejingz Thank you for your interest! I will provide them in a day or two.

Thanks a lot and I am looking forward to it.

Thanks a lot and I am looking forward to it.

@doublejingz: The PR from @revanth1996 contains the data requested.
I am closing this issue.


takeWhile Operator - not supporting inclusive inconsole at rxjs site

Describe the bug

Got to https://rxjs.dev/ site.
Open console
type following:

rxjs.of(1,2,3,4).pipe(
rxjs.operators.takeWhile(val => val !== 3, true)
).subscribe(x => console.log(x))
Using in internal apps work as expeceted.
This logs:
Should log:
1,2
Expected behavior
Should log:
1,2,3
Reproduction code
No response
Reproduction URL
No response
Version
V6 and V7.1.0
Environment
No response
Additional context
No response

Looks like rxjs.dev site is using RxJS 6.3.3:

The optional inclusive option was added in RxJS 6.4.0 according to the changelog.

Yeah, we actually want to remove this feature entirely anyhow. It's fairly unnecessary. People should just use stackblitz.com/fork/rxjs

Looks like this was changed here: https://github.com/ReactiveX/rxjs/commit/e7f59fd0599b13de16f17a63b98a865fdee67806#diff-44ce9f855a5470017be4dae2d43113eaad1451772c6295f9246e969a100c160d if I am reading this correctly.


Introduce type reference type

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes #26284
Fixes #32848
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Need to add the annotation info as well to the BTypeDefinitionSymbol. See BInvokableSymbol for example.

Need to add the annotation info as well to the BTypeDefinitionSymbol. See BInvokableSymbol for example.

Added support and enabled test for #32662


Set local/global setting from llvmenv

llvmenv global system

or
llvmenv local system

has not been implemented yet (´・ω・｀)

Resolved in 48589f14c581fa586fa173bfbcd2a917b2d0c251


feature: v2

Description
I was about to start work on the Modal component for the component library and noticed that this could use some love so one thing led to another and I ended up rewriting it and modernizing the setup as well.
If this works well, our other libraries can follow suit and start shipping types and CSS modules.
V2
Changes
The old design of the modal was honestly great but it had an achilles heel, it used an internal context to handle the transition and syncing that with state which caused:

Actions to be tied to a context, adding custom components to close the modal for example was a bit annoying
Animation and state were too tightly coupled and not exposed for further customization

To solve these I decoupled things and inverted the control from the component to the hook

Now the modal component only cares about rendering
The hook takes care of the logic and expose the variables in the shape that the modal expects so the developer don't have to worry
It opened the door to use custom component for things like closing the modal and backdrop, so much so that we don't need to ship a close button anymore and we could honestly get away with shipping a backdrop component, it's just a positioned absolute div with a background color, too but decided to keep for convenience as that is something very common that almost never changes
It's much easier to reason about animation now as the duration is directly exposed
No need for context anymore, the hook takes care of it
The logic for dealing with slugs is simpler, it's automatic, you don't need to set it

This change also makes issue #2 irrelevant. Customizing the component is just a matter os styling with css and the only trick is the transitionDuration which is I explained in the README updates.
New things
Modernized the library with:

CSS modules
Typescript

Screenshots
https://github.com/wethegit/react-modal/assets/1956448/d56a884d-f157-494f-b35e-0bad1a045acd
Usage
Simple
No custom transition, no focus management
function MyModal() {
  const { isOpen, state, toggle } = useModal()

  return (
    <>
      <button onClick={toggle}>
        Open modal
      </button>

      {isOpen && (
        <Modal state={state}>
          <ModalBackdrop onClick={toggle} />
          <ModalContent>
            <button onClick={toggle}>
              Close
            </button>

Voluptate Lorem ut minim excepteur sit fugiat anim magna aliquip.

          </ModalContent>
        </Modal>
      )}
    </>
  )
}

Complete
With custom transition, focus management and hash trigger
function MyModal() {
  const TRANSITION = 800
  const triggerButton = useRef(null)
  const { isOpen, state, toggle } = useModal({
    triggerRef: triggerButton,
    transitionDuration: TRANSITION,
    // modal will automatically open close when hash changes
    slug: "modal-with-slug",
  })

  // Custom transition must be set on the <Modal> component, how you do it, inline styles or as a className, is up to you
  const stylesVars = {
    "--transition-duration": `${TRANSITION}ms`,
  }

  return (
    <>
      {/* `triggerRef` allows the focus to shift to whatever triggered the modal, on close. */}
      <button ref={triggerButton} onClick={toggle}>
        Open the modal window!
      </button>

      {isOpen && (
        <Modal state={state} style={stylesVars}>
          <ModalBackdrop onClick={toggle} />
          <ModalContent
            className={classnames([
              // up to you how you want to handle the animation
              // you can also add separate classes for each state to customize the animation even further
              // you can also simply customize the parent <Modal> component
              // etc...
              'my-modal',
              (state === ModalStates.OPENING || state === ModalStates.OPEN) && 'my-modal-open',
            ])}
          >
            <button onClick={toggle}>
              Close
            </button>

Voluptate Lorem ut minim excepteur sit fugiat anim magna aliquip.

          </ModalContent>
        </Modal>
      )}
    </>
  )
}

I am thinking of changing slug to hash.

All done now @andrewrubin

Converting it to a Draft while we wait for hooks v2


wip: add-tests

Great, we would also probably need CI with that @jakubczarnowski

We are moving those tests to #60, thanks for your contribution!


chore: lint vue-app templates

Types of changes

[ ] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Maybe we should start looking for a more constructive way of composing the templates. Especially now with the feature flags the amount of configurable code paths is becoming almost unmaintainable and makes the templates quite unreadable. Eg I'm quite sure that certain methods from utils.js could actually still be removed for certain feature flag combinations.
Not sure how we could solve that except maybe by splitting the template compilation in to two steps, first generate templates based on the enabled features then compile with the configured options.
This pr also upgrades eslint-multiplexer to v2.0.0 which makes #6291 obsolete. Creating a new pr is easier then trying to fix this within the renovate pr.
Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly. (PR: #)
[ ] I have added tests to cover my changes (if not applicable, please state why)
[ ] All new and existing tests are passing.

Codecov Report

Merging #6390 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #6390   +/-   ##
=======================================
  Coverage   95.61%   95.61%
=======================================
  Files          79       79
  Lines        2689     2689
  Branches      694      694
=======================================
  Hits         2571     2571
  Misses        101      101
  Partials       17       17

Flag
Coverage Δ

#e2e
100% <ø> (ø)
:arrow_up:

#fixtures
50.79% <ø> (ø)
:arrow_up:

#unit
92.26% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ccca22...a6366e9. Read the comment docs.

You rock @pimlie ❤