TGI 2.0.3 fails to serve CodeLlama models that 2.0.1 supports

System Info
Running a TGI 2.0.3 docker on a 8 NVIDIA_L4 VM.

Information

[X] Docker
[ ] The CLI directly

Tasks

[X] An officially supported command
[ ] My own modifications

Reproduction

Run the provided command.
meta-llama/Meta-Llama-3-70B also failed with similar error. Not sure about other models.

Get the following error:

torch.distributed.DistBackendError: NCCL error in: /opt/conda/conda-bld/pytorch_1712608935911/work/torch/csrc/distributed/c10d/ProcessGroupNCCL.cpp:2395, unhandled cuda error (run with NCCL_DEBUG=INFO for details), NCCL version 2.20.5\nncclUnhandledCudaError: Call to CUDA function failed.\nLast error:\nFailed to CUDA malloc 512 bytes

Is this a CUDA OOM error?
Expected behavior
The model is loaded successfully on 8 L4s with the same command and a TGI 2.0.1 container. Are there any changes to default settings that might have caused increased GPU RAM usage?

Can you try with the latest available public container ghcr.io/huggingface/text-generation-inference:latest? And let us know if it is still exist?

Can you try with the latest available public container ghcr.io/huggingface/text-generation-inference:latest? And let us know if it is still exist?

I still get a CUDA error with ghcr.io/huggingface/text-generation-inference:latest:

RuntimeError: CUDA error: out of memory

Just on a hunch, but I've had some stability issues that I believe (I haven't had time to dig into it enough to rule out something on our end or consistently reproduce it) have to do with inter-GPU communication in these newest versions. The issues went away completely when I disabled cuda-graphs (--cuda-graphs 0), so maybe that's worth a try? It's really just a shot in the dark though at this point.

Hi @stefanobranco , thanks for the suggestion. The model can be loaded with -e CUDA_GRAPHS=0 on the latest TGI docker. But I do see cuda graphs are enabled in 2.0.1 and the model can still be served correctly. I'm wondering if this is a temporary mitigation or is there expected to be a fix to reduce GPU memory usage?

Hi @KCFindstr, I’ve just tried to reproduce the issue on a device with 8 NVIDIA A10G GPUs, which have the same VRAM (8x24.1GB = 192.8GB). I can confirm that the OOM is caused by CUDA_GRAPHS attempting to allocate more space than TGI did prior to version 2.0.0. Is it possible that the version you’re using is older than 2.0.0 or that CUDA_GRAPHS is disabled?
I tested the codellama/CodeLlama-70b-Python-hf with the following versions: 1.4.5, 2.0.0, 2.0.1 and 2.0.4 (command used below). In all versions >=2.0.0 the container will OOM if the default CUDA_GRAPHS (1, 2, 4, 8, 16, 32) are used with that combination of model and hardware.
CUDA_GRAPHS became default in version 2.0.0 and attempts to allocate additional space in the initial warmup step. As noted above, by decreasing the number of graphs the container will load as expected.
In version 1.4.5 CUDA_GRAPHS were experimental, and can be enabled by setting ENABLE_CUDA_GRAPHS=true. It is possible to reproduce the OOM by enabling CUDA_GRAPHS in version 1.4.5 which suggest that the issue is related to the amount of space that CUDA_GRAPHS is attempting to load after loading in the model.
I don't think this is a regression but is a limitation to the hardware + model + configuration (using cuda graphs). However I think we need better messaging/smart defaults to avoid this case. Regarding reducing GPU usage; we're always trying to get the most out of the limited GPU space and am going to look more into ways that we can reduce overhead in general to allow for more optimizations
command used
MODEL=codellama/CodeLlama-70b-Python-hf
IMAGE=ghcr.io/huggingface/text-generation-inference:2.0.0

docker run \
  -m 320G \
  --shm-size=40G \
  -v /nvme0n1/Models/:/data \
  -e HUGGINGFACE_HUB_CACHE=/data \
  -e NVIDIA_VISIBLE_DEVICES=all \
  -e MODEL_ID=$MODEL \
  -e NUM_SHARD=8 \
  -e MAX_INPUT_TOKENS=1024 \
  -e MAX_TOTAL_TOKENS=2048 \
  -e MAX_BATCH_PREFILL_TOKENS=2048 \
  -e TRUST_REMOTE_CODE=true \
  -e JSON_OUTPUT=true \
  -e
  -e PORT=8080 \
  -p 7080:8080 \
  --runtime=nvidia \
  $IMAGE

@drbh Thanks for the investigation! However, I retried with TGI 2.0.1 and the model can still be loaded successfully, which is different from your observation.

{"timestamp":"2024-06-12T23:25:59.509912Z","level":"INFO","fields":{"message":"Args { model_id: "codellama/CodeLlama-70b-Python-hf", revision: None, validation_workers: 2, sharded: None, num_shard: Some(8), quantize: None, speculate: None, dtype: None, trust_remote_code: true, max_concurrent_requests: 128, max_best_of: 2, max_stop_sequences: 4, max_top_n_tokens: 5, max_input_tokens: Some(1024), max_input_length: None, max_total_tokens: Some(2048), waiting_served_ratio: 1.2, max_batch_prefill_tokens: Some(2048), max_batch_total_tokens: None, max_waiting_tokens: 20, max_batch_size: None, cuda_graphs: None, hostname: "ecdb3588f8ab", port: 8080, shard_uds_path: "/tmp/text-generation-server", master_addr: "localhost", master_port: 29500, huggingface_hub_cache: Some("/data"), weights_cache_override: None, disable_custom_kernels: false, cuda_memory_fraction: 1.0, rope_scaling: None, rope_factor: None, json_output: true, otlp_endpoint: None, cors_allow_origin: [], watermark_gamma: None, watermark_delta: None, ngrok: false, ngrok_authtoken: None, ngrok_edge: None, tokenizer_config_path: None, disable_grammar_support: false, env: false, max_client_batch_size: 4 }"},"target":"text_generation_launcher"}
{"timestamp":"2024-06-12T23:25:59.513288Z","level":"INFO","fields":{"message":"Token file not found "/root/.cache/huggingface/token"","log.target":"hf_hub","log.module_path":"hf_hub","log.file":"/usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/hf-hub-0.3.2/src/lib.rs","log.line":55},"target":"hf_hub"}
{"timestamp":"2024-06-12T23:25:59.990069Z","level":"INFO","fields":{"message":"Using default cuda graphs [1, 2, 4, 8, 16, 32]"},"target":"text_generation_launcher"}
{"timestamp":"2024-06-12T23:25:59.990095Z","level":"WARN","fields":{"message":"trust_remote_code is set. Trusting that model codellama/CodeLlama-70b-Python-hf do not contain malicious code."},"target":"text_generation_launcher"}
{"timestamp":"2024-06-12T23:25:59.990101Z","level":"INFO","fields":{"message":"Sharding model on 8 processes"},"target":"text_generation_launcher"}

From the logs, it looks like CUDA graph is enabled. (Using default cuda graphs [1, 2, 4, 8, 16, 32])
This is the VRAM usage when the model is loaded and being served:
Wed Jun 12 23:28:55 2024
+-----------------------------------------------------------------------------------------+
| NVIDIA-SMI 550.54.15              Driver Version: 550.54.15      CUDA Version: 12.4     |
|-----------------------------------------+------------------------+----------------------+
| GPU  Name                 Persistence-M | Bus-Id          Disp.A | Volatile Uncorr. ECC |
| Fan  Temp   Perf          Pwr:Usage/Cap |           Memory-Usage | GPU-Util  Compute M. |
|                                         |                        |               MIG M. |
|=========================================+========================+======================|
|   0  NVIDIA L4                      Off |   00000000:00:03.0 Off |                    0 |
| N/A   76C    P0             36W /   72W |   21948MiB /  23034MiB |      0%      Default |
|                                         |                        |                  N/A |
+-----------------------------------------+------------------------+----------------------+
|   1  NVIDIA L4                      Off |   00000000:00:04.0 Off |                    0 |
| N/A   77C    P0             37W /   72W |   21948MiB /  23034MiB |      0%      Default |
|                                         |                        |                  N/A |
+-----------------------------------------+------------------------+----------------------+
|   2  NVIDIA L4                      Off |   00000000:00:05.0 Off |                    0 |
| N/A   73C    P0             34W /   72W |   21948MiB /  23034MiB |      0%      Default |
|                                         |                        |                  N/A |
+-----------------------------------------+------------------------+----------------------+
|   3  NVIDIA L4                      Off |   00000000:00:06.0 Off |                    0 |
| N/A   77C    P0             35W /   72W |   21948MiB /  23034MiB |      0%      Default |
|                                         |                        |                  N/A |
+-----------------------------------------+------------------------+----------------------+
|   4  NVIDIA L4                      Off |   00000000:80:00.0 Off |                    0 |
| N/A   66C    P0             31W /   72W |   21948MiB /  23034MiB |      0%      Default |
|                                         |                        |                  N/A |
+-----------------------------------------+------------------------+----------------------+
|   5  NVIDIA L4                      Off |   00000000:80:01.0 Off |                    0 |
| N/A   76C    P0             37W /   72W |   21948MiB /  23034MiB |      0%      Default |
|                                         |                        |                  N/A |
+-----------------------------------------+------------------------+----------------------+
|   6  NVIDIA L4                      Off |   00000000:80:02.0 Off |                    0 |
| N/A   72C    P0             32W /   72W |   21948MiB /  23034MiB |      0%      Default |
|                                         |                        |                  N/A |
+-----------------------------------------+------------------------+----------------------+
|   7  NVIDIA L4                      Off |   00000000:80:03.0 Off |                    0 |
| N/A   76C    P0             36W /   72W |   21948MiB /  23034MiB |      0%      Default |
|                                         |                        |                  N/A |
+-----------------------------------------+------------------------+----------------------+

This is the TGI 2.0.1 image I used:
us-docker.pkg.dev/deeplearning-platform-release/gcr.io/huggingface-text-generation-inference-cu121.2-0.ubuntu2204.py310:m121

Do you know if there are any other changes from 2.0.1 -> 2.0.3 that might lead to VRAM usage increase?

@KCFindstr thats very interesting! would you be able to share the all of the logs until the server is ready to receive requests? Also does the model run on 2.0.2?
I'm not aware of anything major at the moment but will take another look soon for anything that would impact the VRAM

@drbh I tested the containers hosted on ghcr.io:

ghcr.io/huggingface/text-generation-inference:2.0.1: Succeeded
ghcr.io/huggingface/text-generation-inference:2.0.2: CUDA OOM

The logs from us-docker.pkg.dev/deeplearning-platform-release/gcr.io/huggingface-text-generation-inference-cu121.2-0.ubuntu2204.py310:m121 are attached here:
tgi_2_0_1.log

Thank you for sharing, I've started to look through the changes between the two versions and the issue is possibly related to a change in how we are masking the frequency penalty. However I cannot confirm this yet and am going to investigate further tomorrow. Will post an update soon.

Hi @KCFindstr, I've continued to debug the issue and cannot find a specific change within TGI that would use more memory in 2.0.2, although I have some findings/recommendations/ideas below.
Where the OOM happens and how to avoid it:
During warmup we attempt to allocate as many blocks of kv_cache memory. This step checks the available memory and estimates a number of blocks. The percent of the total hardware memory can be configured with --cuda-memory-fraction and by default is 1.0. It should be possible to load the model by decreasing this value to ~.9 (depending on your system)
Continuing the warmup process, after the blocks are allocated, cuda graphs are initialized, at this point if there is not enough memory for the graphs (because of the block allocation) TGI will OOM.
Depending on the model, the cuda graphs step will allocate more memory when initializing. In the case of codellama/CodeLlama-70b-Python-hf the amount of memory needed is greater than the leftover space after allocating the blocks.
The solution is to either decrease the optimistic kv_cache allocation with --cuda-memory-fraction or decrease the number of --cuda-graphs.
Personally, I'd recommend decreasing the --cuda-memory-fraction by small amounts until your GPU's are fully saturated and the model loads. On 8 A10G's I can run the following command and get ~99% (23.9GB) utilization of each GPU. This uses the default settings max_input_tokens=4095, max_total_tokens=4096, max_batch_prefill_tokens=4145 and cuda_graphs=[1, 2, 4, 8, 16, 32].
text-generation-launcher \
--model-id codellama/CodeLlama-70b-Python-hf \
--num-shard 8 \
--cuda-memory-fraction .93

In terms of the origin of the change, in 2.0.2, torch  was updated from 2.1.1 to 2.3.0 in TGI, which includes many upstream changes that likely changed how and how much memory is allocated.
Would you kindly try reducing the memory fraction to fit the model on your hardware with cuda graphs?
Im going continue to explore the memory allocation and follow up with better error messages however I believe reducing this value should resolve this loading issue

Thanks @drbh ! Setting --cuda-memory-fraction to 0.93 works. However IIUC this value should depend on the model length and total GPU memory available, so ideally shouldn't be a fixed value for every model and machine configuration?

It may also be worth mentioning that torch 2.3.1 contains a few fixes for various memory leaks, e.g. https://github.com/pytorch/pytorch/pull/124238. From my understanding this mainly affects torch.compile, so it might not be relevant, but I'm also not knowledged enough to really estimate the impact of these fixes. Might be worth checking out if it has any impact though?


Add arm64 support

Why you need it?
I was trying to add arm64 jobs in Travis-ci and found that com.google.protobuf:protoc:3.3.0:exe is not available for arm64 and after upgrading the version of the exe there were some conflicts. So I have updated etcd-client-v3.version accordingly and also did some changes in discovery/seata-discovery-etcd3/src/test/java/io/seata/discovery/registry/etcd/EtcdRegistryServiceImplTest.java file. Currently, the jobs for arm64 are failing giving the following error -
[ERROR]   GlobalLockTemplateTest.setUp:41 initial global lock config should be null ==> expected: <null> but was: <io.seata.core.model.GlobalLockConfig@707aa922>
[ERROR]   GlobalLockTemplateTest.setUp:41 initial global lock config should be null ==> expected: <null> but was: <io.seata.core.model.GlobalLockConfig@707aa922>
[ERROR]   StatementProxyTest.testBatch:229 Unexpected exception thrown: java.lang.UnsupportedOperationException: ONLY SUPPORT SAME TYPE (UPDATE OR DELETE) MULTI SQL -select * from table_statment_proxy; update t set x = 'x' where id = 1
[ERROR]   SelectForUpdateExecutorTest.testDoExecute:94 Expected java.lang.RuntimeException to be thrown, but nothing was thrown.
[ERROR]   MySQLUndoLogManagerTest.testBatchDeleteUndoLog:111 Unexpected exception thrown: java.sql.SQLException: io.seata.common.loader.EnhancedServiceNotFoundException: not found service provider for : io.seata.sqlparser.druid.SQLOperateRecognizerHolder
[ERROR]   MySQLUndoLogManagerTest.testDeleteUndoLog:104 Unexpected exception thrown: java.sql.SQLException: io.seata.common.loader.EnhancedServiceNotFoundException: not found service provider for : io.seata.sqlparser.druid.SQLOperateRecognizerHolder
[ERROR]   MySQLUndoLogManagerTest.testDeleteUndoLogByLogCreated:78 Unexpected exception thrown: java.sql.SQLException: com.alibaba.druid.sql.parser.ParserException: syntax error, error in :'<= ? LIMIT ?', expect LIMIT, actual LIMIT pos 49, line 1, column 44, token LIMIT
[ERROR]   MySQLUndoLogManagerTest.testInsertUndoLog:88 Unexpected exception thrown: java.sql.SQLException: com.alibaba.druid.sql.parser.ParserException: syntax error, error in :'<= ? LIMIT ?', expect LIMIT, actual LIMIT pos 49, line 1, column 44, token LIMIT

Commit Link - https://github.com/odidev/seata/commit/a7b0ef0c4ee3803a18b82cf42f83a6a95e8a6ca7
Travis Link - https://travis-ci.com/github/odidev/seata/builds/191375746
How it could be?
If you are interested in adding arm64 support in Seata, I am happy to help with adding this and raise PR.
To start with adding support, Can I get suggestions on the above issue?

@odidev glad to you to solve this problem.

Can I get suggestions on the above issue?


The "Asset Location" field is missing while creating a Purchase Receipt for the auto-creation of an asset.

Information about bug

Module
assets
Version
Assets: v0.0.1 (pre-prod)
CRM: v0.0.1 (master)
ERPNext: v15.36.2 (pre-prod)
Frappe Framework: v15.41.0 (pre-prod)
Payments: v0.0.1 (version-15)
Projects: v0.0.1 (master)
sales_commission: v0.0.1 (master)
Installation method
None
Relevant log output / Stack trace / Full Error Message.
No response

Manufacture tab break in item child table has Asset Location field


Esya custom attributes

Rebased version of #946 from @Esya
Fixes #754.

Looks good to me! :white_check_mark:

:heavy_check_mark:


Python textMate grammar: 'in' in the control flow 'for ... in ...' syntax is sometimes recognized as a logical operator

VSCode Version: 1.40.1 and 1.41.0-insider
OS Version: Win 10 64bit

Steps to Reproduce:
Type in this python code and use Developer: Inspect TM Scopes to look at the in keyword in each line.
x = [y + 3 for y in range(3)]  # 'in' is recognized as logical operator, but is part of the control flow
z = any(y == 3 for y in range(7))  # 'in' is rightfully recognized as control flow operator

for a in x:  # 'in' is recognized as logical operator, but is part of the control flow
    if a in x:  # 'in' is rightfully recognized as logical operator
        pass

Does this issue occur when all extensions are disabled?: Yes

Moved to the repo that owns the python grammar: https://github.com/MagicStack/MagicPython/issues/193


remove hardcoded floor URDF

The floor URDF can be passed as an additional path after #81

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 89.466%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
1758

Relevant Lines:
1965

💛  - Coveralls

LGTM, let's merge it with a release note once https://github.com/upkie/upkie/pull/197 is merged.


feat: detect start block changes

Depends on: https://github.com/checkpoint-labs/checkpoint/pull/221
This PR adds verification that start block in config did not change.
Test plan

Start the server normally so start block gets persisted.
Change start in your config to different network (if editing events it has to be the lowest block number from there).
Start the server. You get error message.
Set resetOnConfigChange to true in options, start server again, it continues.
Remove this option, start server again, it works.

@bonustrack reset only resets entities tables, you need to reset both (reset() and resetMetadata() - it is mentioned in error message). We have two separate methods, because resetMetadata was added later.


removed unneccessary code-line

We agreed that we wanted to keep the unneccessary code line for the sake of clarity :)


SSL_CERT_FILE only works for Linux, not for OSX

export SSL_CERT_FILE=/path/to/cert
cf login -a https://api.mything.com

This works on linux, but on osx it doesn't seem to know about SSLCERT_FILE and I get:
Invalid SSL Cert for api.18-220-97-61.sslip.io
TIP: Use 'cf login --skip-ssl-validation' to continue with an insecure API endpoint

That's as documented.
We rely on Golang for this functionality, and unfortunately they only support it on Linux.


Internal server error with pending transactions[BUG]

Describe the bug
Random 500 ISE related to checking for pending txs occurs causing fatd to panic and crash
Describe the environment (please complete the following)
OS: Ubuntu 18.01
Factom Network: testnet
fatd State: synced
fatd Version: v0.6.0.r84.g90575c4
fat-cli Version: v0.6.0.r84.g90575c4
To Reproduce

./fatd -ecadr EC1tE4afVGPrBUStDhZPx1aHf4yHqsJuaDpM7WDbXCcYxruUxj2D -debug -networkid=test -dbpath /home/devon/git-projects/fatd/fat.db -whitelist 0cccd100a1801c0cf4aa2104b15dec94fe6f45d0f3347b016ed20d81059494df,962a18328c83f370113ff212bae21aaf34e5252bc33d59c9db3df2a6bfda966f
Wait for sync ...
Wait for indeterminate panic

Expected behavior
Normal behavior
Output
https://gist.github.com/drkatz/b279c4d855300feb1d0af131ee368bf2
Additional context
Seems to happen randomly?

The EOF was an error from factomd. the non-clean shutdown was due to the bug fixed in the latest commit.


Fix Windows Packaging on Develop

We do not distribute the CPP version of the ROS controller on Windows anymore.

:+1:


macOS permission denied, mkdir /var/lib/homebridge

@seydx
On the macOS we get Error: EACCES: permission denied, mkdir “/var/lib/homebridge” and the bridge crashes because /var is a private directory on macOS and can’t be used to store any data, can you change this to /Users/USER_NAME/camera.ui?

same

I am getting the same issue on synology


use WSTRINGSTREAM when encoding the public key token

use WSTRINGSTREAM when encoding the public key token into hex for the log file

I don't understand what was wrong with the original version.

This fixed the issue on Windows but broke the CircleCI tests. 👎


3.2.0 Release

I am ready to push 3.2.0 - Tyler - it would be great if you could try 3.2.0rc4 in your application to make sure nothing obvious broke.
I'd like to push this in the next few days....
Thanks!

Will do.  I think I have some time tomorrow and Wednesday.  I've tested a little and seems to be functioning, but I will test more in depth tomorrow.

From my personal testing, I would say that this is good to release.  I haven't had any issues with the package in a flask app that I have.

@jwag956 -- I'm switching over to your fork so I can take advantage of the authentication tokens (I'm using a SPA after all).
I did a standard install, and can confirm I have what pip thinks is version 3.2.0, but I don't think I have the right version. At a minimum, I see the 'cache.py' file is missing (and my auth tokens are still slow!). Maybe I did something wrong?
pip uninstall flask-security
pip install flask-security-too
pip freeze | grep Flask-Security
Flask-Security-Too==3.2.0
cd .direnv/python-3.7.3/lib/python3.7/site-packages/flask_security Tue Jul 09]
69$ ls
babel.py        core.py        __init__.py      registerable.py  translations
changeable.py   datastore.py   passwordless.py  script.py        utils.py
cli.py          decorators.py  __pycache__      signals.py       views.py
confirmable.py  forms.py       recoverable.py   templates

Certainly I can just pull from git but I thought I'd bring this up in case there's something else that's misconfigured upstream. I also note that pip thinks there should be a site-packages/Flask_Security_Too-3.2.0.dist-info folder, but that doesn't exist (but site-packages/flask_security does).

Something is definitely odd - I just did an uninstall/reinstall and worked fine and I have a site-packages/Flask_Security_too-3.2.0.dist-info
any chance you forgot to activate your venv? :-D

yeah, it's definitely weird. I cannot get this to install and a fresh environment either. I can clone just fine, but the installed package itself seems stale.
Maybe you are right. Could it be that pip somehow caches the previously installed flask_security?

you could try pip --no-cache-dir to see if that helps. Very odd since the version numbers are different in any case. If you have a chance - could you zip up the contents of our site-packages/flask_security and send it to me? I will see what version it is...

Weird. It works now. I can't explain it. I installed the original flask-security, then removed it, then installed flask-security-too, and now everything looks ok. I didn't even have to use --no-cache-dir


fix(sessions): enable sessions in OP_MSG

Sessions information is not presently applied to OP_MSG messages
because of a patch that was left out of the OP_MSG PR. The real
fix for this is to merge all of the sessions-related code in
our pool into the command wire protocol method, but that work
shouldn't hold up sessions support today.

@daprahamian I'd say its mostly on Travis config + evergreen config, but no worries this was never released


Update elderjs.md to include proper link

Link to Elder.js official documentation instead of the GitHub repo.

🥳


Adds implementation to enable conversion of AvroSchema to Descriptor Proto.

Also adds tests to validate the implementation.

.getAvroSchema() method is used to convert a TableSchema to AvroSchema.

This function utilises the preexisting implementation of SchemaTransform.toGenericAvroSchema() to obtain Generic Avro Schema from TableSchema.

The current PR enables implementation of conversion of various Avro - Schema field types to descriptor proto.  RECORD, PRIMITIVE TYPE, LOGICAL TYPES as well as UNION type are implemented.

A UNION field is converted to an OPTIONAL bigquery field, with an exception to UNION of MAPs and UNION of ARRAYs which will be handled in future PRs.
For PRIMITIVE types, the mapping is as follows:

AVRO SCHEMA TYPE
Field Descriptor TYPE

INT
TYPE_INT64

FIXED
TYPE_BYTES

LONG
TYPE_INT64

FLOAT
TYPE_FLOAT

DOUBLE
TYPE_DOUBLE

STRING
TYPE_STRING

BOOLEAN
TYPE_BOOL

ENUM
TYPE_STRING

BYTES
TYPE_BYTES

For LOGICAL types:

AVRO SCHEMA TYPE
Field Descriptor TYPE

DATE
TYPE_INT32

DECIMAL
TYPE_BYTES

TIMESTAMP-MICROS
TYPE_INT64

TIMESTAMP-MILLIS
TYPE_INT64

UUID
TYPE_STRING

TIME-MICROS
TYPE_STRING

TIME-MILLIS
TYPE_STRING

LOCAL-TIMESTAMP-MICROS
TYPE_STRING

LOCAL-TIMESTAMP-MILLIS
TYPE_STRING

GEOGRAPHY
TYPE_STRING

JSON
TYPE_STRING

A RECORD type is considered as a RECORD bigquery field, its inner fields are handled by recursively.

/gcbrun

/gcbrun

/gcbrun


What are we doing here?

So it went this way:
i've been running a custom model, and i can ask/receive a decent answer in about 30 seconds.
Going through OpenDevin, each step takes about 5-10 minutes. i see the cpu spiking, so there's something going on, but no idea what, because it's surely not the answer, because it keeps going on about making plans and agendas and what not, so clearly there's some other wrappers there.
i see the Docker sandbox running a tail to keep it alive,  but otherwise it's empty. Devin's not doing anything there either.
Then i went to the LLM parameters, and now i had to learn what all those mean, and i tuned the parameters to what i thought it makes sense in terms of precision and accuracy as per the documentation available:
PARAMETER temperature 0.8
PARAMETER num_ctx 16384
PARAMETER num_thread 12
PARAMETER seed 42
PARAMETER top_k 40
PARAMETER top_p 0.9
PARAMETER tfs_z 0.92
PARAMETER mirostat 2
PARAMETER mirostat_eta 0.05
PARAMETER mirostat_tau 3.0
PARAMETER repeat_penalty 0
PARAMETER repeat_last_n -1

Gave a nice system prompt, and off to the races we went. But all that comes out is nonsense.
So.
The only way to go back to getting any sort of "meaningful" output, i'd have to tweak the parameters to introduce more "diversity" and "probability" and "creativity", which if i'm interested in precision and accuracy, that's not what i need.
Again, there's the possibility of me being stupid at this point, but i do have to ask. What is this and what are we doing here? To me it looks like a way to introduce delays.

i have a few alternatives, options, ideas, theories, whatever you may wanna call it, and since you like probability so much, feel free to choose whatever suits you:
- i made a mistake in reading the docs, and i've selected some wrong parameters due to me not knowing this subject well enough.
- you're all on an inside joke but me.
Because coders, are smart people right? they write code, they are good with numbers, algorithms, math, they are by all definitions knowledgeable. They work based on logic and precision and they work with computers which are - just that - precise. They are made of switches, upon which we have abstracted meaning, in the form of instruction sets (i'm not gonna call them programming languages, because we all know - or at least i thought everybody knew - that "language" is a term used when you communicate with someone. And with a computer, you don't communicate, you give it instructions on where to move bits of data. So why use the term "language" anyway, in an environment where it's all about precision?)
- you're all idiots.
Because i can't understand how so many people which by all standards are smart, are going about and giving their effort to something that is not what it is.
- you've all been duped. Into going on an AI bandwagon, searching for something, all world's brightest minds, going on loops, and inaccurate data, and they themselves creating more inaccurate data in the process, muddying the waters in order to make them seem deep.
- ill intent. you all know what you're doing, but somehow you decided that it's fun and maybe that's the definition of chaos and you feel giddy about it. However, it's a mediocre implementation of chaos.
- you're all just playing along, fully aware of what you're doing, but going along to see where this leads, if anywhere, just to see what this is all about. No harm done, it's time spent by enthusiasts, doing something exciting and new.
However, here, we come back to the idea that programmers, are smart people, so it couldn't have taken anyone focused nearly anywhere as it took me to think about this.

So, what are we doing? Because at this point i'd rather just compute primes than doing this. At least that's doing something.

I just stumbled upon this repository, then saw this issue, and while I'm surely not knowledgeable enough to answer your questions i wanted to give my 2 cents anyway. I'm sure someone will come along and give a proper answer to your issue.
As for why we (or anyone) is doing this:
Innovation can be driven by a lot of things: curiosity, money, even national security or safety concerns. Things like Ollama and Opendevin seem like a try to stand up to a rising AI oligarchy, giving people back power over computing, which is a good thing to me. If it succeeds, good. If this and the current wave of AI hype is nothing but that, then we'll see what will stick around. At least some people have to have learned something along the way.
For Opendevin specifically:
These kind of tools are in a very early stage, who knows what will come. If everything will go according to plan, this could be a great opportunity to teach about programming or let people quickly spin up prototypes. On the flip side, it could remove a big part of programming that i really liked. But no one can and should stop innovation.
Anyways, will try this thing out tomorrow. Maybe I'll even like it, maybe wait for another year or 10 until its ready for prime time. Maybe this will never happen and it's all just a fever dream coming to an end soon lol.

I just stumbled upon this repository, then saw this issue, and while I'm surely not knowledgeable enough to answer your questions i wanted to give my 2 cents anyway. I'm sure someone will come along and give a proper answer to your issue.
As for why we (or anyone) is doing this: Innovation can be driven by a lot of things: curiosity, money, even national security or safety concerns. Things like Ollama and Opendevin seem like a try to stand up to a rising AI oligarchy, giving people back power over computing, which is a good thing to me. If it succeeds, good. If this and the current wave of AI hype is nothing but that, then we'll see what will stick around. At least some people have to have learned something along the way.
For Opendevin specifically: These kind of tools are in a very early stage, who knows what will come. If everything will go according to plan, this could be a great opportunity to teach about programming or let people quickly spin up prototypes. On the flip side, it could remove a big part of programming that i really liked. But no one can and should stop innovation.
Anyways, will try this thing out tomorrow. Maybe I'll even like it, maybe wait for another year or 10 until its ready for prime time. Maybe this will never happen and it's all just a fever dream coming to an end soon lol.

i mean none of that stand up to a rising AI oligarchy and giving people power over computing is true, so the idea of it being a good thing is sort of questionable.
However, they do lead to better understanding of what the current AI is about, and that is a good thing.
As far as trying things out goes, it comes with it's caveats and debbie downers due to lag, delays and response times not being on point. Waiting is often pointless when you know. It usually leads of frustration and going about learning other cool things like playing an instrument and what not, which is not necessarily a bad thing, but it's usually more fun if things are in motion. Then, we can play.

Bro, relax.
These guys are trying to replicate a $2 billion company without any paycheck, and it's only been around 2 months since the project started.
It's only been a year since AI agent frameworks got introduced, so there's still a lot to be understood in order to get production level outputs.
I lost interest halfway through reading your post as you're clearly acting like a Karen. If u have any solution to offer, then please do so. Orelse, keep your childish tantrum out of the issues.

Appreciate the feedback y'all. It's definitely still early days, but we're close to having a SWE-Agent implementation, which will be a huge boost in quality. And I'd definitely recommend using it with SOTA LLMs, rather than a smaller local model (which often produces nonsense, as you point out).
Let's move this discussion to Discord or Slack--we're trying to keep GitHub issues for bugs and features.


Sniff for correct usage of add_action vs add_filter

Today we discovered that some code under development was breaking functionality related to the attachment_fields_to_save  hook.
It turns out the bug was caused by a callback being incorrectly registered as an action (with add_action()) instead of a filter (with add_filter()). This meant that all filters after this particular callback were receiving a null value instead of the WP_Post object.
It's a bit of a long shot, but it would be great if WPCS could be aware of which hooks in WordPress are actions, and which are filters, and raise an error if add_action() is used instead of add_filter().

I think the sniff could be relatively simple if we have list of WordPress filters and actions. It would need to be decided what happens if the hook is not part of the list as it is not part of WordPress core.

Just checking - was the actual issue caused by the use of add_action() or was it caused by the hooked in function not returning the expected value ... ?

Just checking - was the actual issue caused by the use of add_action() or was it caused by the hooked in function not returning the expected value ... ?

Yeah, I've been bitten by that before. But that would really be beyond WPCS's ability to detect in some cases.

Yes the actual bug was caused because the action callback was not returning a value. The same problem would occur if a filter callback didn't return a value, but it would be more likely to be picked up during code review in that case, I think.
A sniff which could detect when a filter callback doesn't contain a return statement on the final line would be great, but that's probably a bit too much to ask of a static analyser.

Gonna close this off as something that realistically isn't practical to implement.

I'm going to re-open this as the original issue can be quite difficult for a developer to spot. I don't think WPCS should go so far as detecting return values, but detecting incorrect usage of add_action() versus add_filter() for core hooks ought to be doable.
I recently created a library that lists core's actions and filters that could be used by WPCS: https://github.com/johnbillion/wp-hooks

That would be awesome! I've run into this problem yesterday, where I ended up one hour debugging the issue where I typed add_action( 'wp_handle_upload', ... instead of add_filter( 'wp_handle_upload', ..., and my image uploads were failing and I had no idea why.
:+1: from me 🙂

Loosely related to #1803.
Any sniff for this would need a list of hooks and that list could be generated via running PHPCS over Core.
A sister-sniff checking for use of deprecated hooks would also be good.

Any sniff for this would need a list of hooks and that list could be generated by running PHPCS over Core.

This is what the wp-hooks library provides.

A sister-sniff checking for use of deprecated hooks would also be good.

Yep, agreed. Let's keep this focused for now though.

Just saw a comment somewhere in a Slack about someone having to fix some bugs related to exactly this. Good reminder that a sniff which checks that the correct hook-in function is used would be a good addition, if for no other reason than to remind the developer that actions !== filters.

If someone wants to pick this up, my wp-hooks library is actively maintained and would be a good source for the list of core actions and filters.
Aside: I'm considering how best to provide common aliases for hooks that include dynamic portions in their names, eg. {$old_status}_to_{$new_status}.


LifecyclePolicyPolicyDetailsScheduleCreateRule.times accepts str not list

There is an inconsistency between the doc (including the doc in the doc) and the code itself in LifecyclePolicyPolicyDetailsScheduleCreateRule.
The example should be updated to:
times=["23:45"] should be  times="23:45" in LifecyclePolicyPolicyDetailsScheduleCreateRuleArgs
File: themes/default/content/registry/packages/aws/api-docs/dlm/lifecyclepolicy/_index.md

The issue moved to pulumi-aws: https://github.com/pulumi/pulumi-aws/issues/1704


Add settings.gradle file

Similarly to what is in prometheus-exporter repo: https://github.com/vvanholl/elasticsearch-prometheus-exporter/blob/master/settings.gradle
It should read:
rootProject.name = "openshift-ingest-plugin"

Note to myself: once resolved we need to remove this file from branch in downstream clone we use for buiild.


Update 144-black-hole-visualization.md with Contribution

Running Version: https://editor.p5js.org/Eddershaw/full/dPJZX05Yq
Or GIF preview:

Much Appreciated,
Louis Eddershaw

Another great idea ❤ Thanks!
Here's the fix.
  - title: "Light Trajectories Around a Black Hole"
    author:
      name: "Louis Eddershaw"
      url: "https://github.com/Eddershaw"
    url: "https://editor.p5js.org/Eddershaw/full/dPJZX05Yq"
    source: "https://editor.p5js.org/Eddershaw/sketches/dPJZX05Yq"


RFM - Natron

Current Maintainer

[ ] I am the maintainer of the package and wish to pass it to someone else;

I DON'T Want To Become The Maintainer

[X] ~I have~ User reporting this has followed the Package Triage Process and ~I~ they do NOT want to become maintainer of the package;
[X] There is no existing open maintainer request for this package;

Checklist

[X] Issue title starts with 'RFM - '

Existing Package Details
Package URL: https://chocolatey.org/packages/Natron
Package source URL: https://github.com/Summerspecial/ChocoCont

https://natron.fr unavailable today (connection timeout). To check later if it is temporary or not.

Seems to be the new URL: https://natrongithub.github.io

Status: Review

https://chocolatey.org/packages/natron
https://chocolatey.org/packages/natron.install
https://chocolatey.org/packages/natron.portable

Status: Published

https://chocolatey.org/packages/natron
https://chocolatey.org/packages/natron.install
https://chocolatey.org/packages/natron.portable

Can be closed.


Always supply a user.ip_address value

When applicable, we should try and pass along the X-Forwarded-For
value from the client as REMOTE_ADDR. There is no security implications
here and only yields more accurate data in Sentry itself. It's not as
common for a user to mutate their own REMOTE_ADDR, so we should try to
do the right thing and fetch XFF when present instead.
It's an explicitly decision to mutate REMOTE_ADDR inside of the env
rather than the user interface because right now, the Sentry server is
taking the liberty of filling in the user.ip_address from the
env.REMOTE_ADDR already when it exists, so it only makes sense to just
pass along the more expected behavior.
This has come up a number of times in support and from users.

@nateberkopec do you remember what we did in raven-ruby for this?

Also if we do this we should update client-dev docs to suggest this

thanks @mattrobenolt!
this will make our error data much more useful - it'll align our frontend (raven.js) user IPs with our API (raven-python) user IPs even though we're behind both CloudFront and Heroku

@mattrobenolt @dcramer any updates on this? it's a very important feature for us

@dcramer here you go: https://github.com/getsentry/raven-ruby/blob/master/lib/raven/utils/real_ip.rb

HI, @mattrobenolt @dcramer I'd like to ask if you are planning to merge this PR soon?

@ashwoods we should merge this after fixing the tests.


:robot: use KVM on self-hosted workers

          KVM is not used when using earthly. This needs some more work to run tests without earthly.

Originally posted by @jimmykarily in https://github.com/kairos-io/kairos/issues/929#issuecomment-1438673628

We are already using KVM in our self hosted runners. E.g. https://github.com/kairos-io/kairos/blob/b0e7800347f9d5643a331f836d08fa52f018682b/.github/workflows/reusable-install-test.yaml#L54-L68


Help with finding Bundler Resolving Method/Logic

Hey guys,
following this issue https://github.com/webpack/enhanced-resolve/issues/382 (enhance-resolved issue)
i need to find the method/logic which webpack uses to resolve packages entrypoints.
meaning, given target = 'webworker' && packageJsonPath == 'somepath' i want to get the package worker entrypoint.
so lets say i have this Package.json in packageJsonPath == 'somepath' i want it to return "./dist/index-worker.js"
      {
        name: "sampleModuleWithMultipleEntries",
        version: "0.0.1",
        main: "./dist/index.js",
        browser: "./dist/index-browser.js",
        exports: {
          ".": {
            module: {
              node: "./dist/index-node.js",
              worker: "./dist/index-worker.js",
              browser: "./dist/index-browser.js",
              default: "./dist/index-node.js",
            },
            default: "./dist/index-node.js",
          },
          "./package.json": "./package.json",
        },

can anyone help me find where this logic is implemented in webpack?

Close in favor https://github.com/webpack/enhanced-resolve/issues/382, please don't duplicate issues


How does it work?

Sorry, but I did not see any information about how does it get the latest version number?
Lately I want to add the Update function in my app, so a more specific document will be appreciated.

Basically it compares your app version with the latest version available in the .setUpdateFrom(UpdateFrom) that you have provided in the builder. A string with the version can be found in the page source, so the library retrieves this version (the latest one published) and checks if it's the installed one.
Hope it helps you.

Hi javiersantos, I've following code kotlin project:
val appUpdater = AppUpdater(this)                 .setUpdateFrom(UpdateFrom.JSON)                 .setUpdateJSON(currentSystem.appUpdaterFullURI)                 .setButtonDoNotShowAgain("")    //Hide the 'Do not show again' button                 .showEvery(3)       // show every 3 times this code run         appUpdater.start()
And json object:
$data = [                 'latestVersion' => '1.0.1',                 "url" => "http://<IP_ADDRESS>:81/downloads/isms_nct_latest.apk",     			"releaseNotes" => [     			    "- First evolution",     			    "- Second evolution",     			    "- Bug fixes"       			]             ];
The problem is... After we click to download and install the latest software, after 3 times restart the app, it pops up again to ask if want to update the app.
The questions rise in... If appUpdater were to used, where and how shall we record the info 'oh hey, this device has already installed 1.0.1', if same json data receive again, don't pop up the dialog box.


refactor: delegates additional handling

Summary
https://app.clickup.com/t/8678ur3qk
@ItsANameToo added some handling for when there are missed blocks for delegates that don't exist (e.g. when we run tests locally and it starts throwing an error). It effectively just hyphen's the data in the table. Sorting doesn't break under these circumstances either. If you'd prefer not to have this as it's only caused by local issues I can revert it

Checklist

[ ] I checked my UI changes against the design and there are no notable differences
[ ] I checked my UI changes for any responsiveness issues
[ ] I checked my UI changes in light AND dark mode
[ ] I checked my (code) changes for obvious issues, debug statements and commented code
[ ] I opened a corresponding card on Clickup for any remaining TODOs in my code
[ ] I added a short description on how to test this PR (if necessary)
[ ] Documentation (if necessary)
[ ] Tests (if necessary)
[ ] Ready to be merged

is fine with me @alexbarnsley


Update upsell/setup page

looks weird on PC. hide the sidebar and center?
looks small on PC and mobile
update to comma three
less ambiguous pair text

maybe we should detect a mobile resolution and remove the text which says 'with your phone' since they're already using their phone?


impl Intochrono::Duration for model::Interval

This fixes two naming errors in the model::Interval enum:
Interval::FiftyMinutes -> Interval::FifteenMinutes
Interval::ThreeDay -> Interval::ThreeDays
And this enables:
model::Interval::FourHours.to_duration().num_milliseconds()

Hey @steffenix thanks for marking this as a sized issue :) This means I can claim a NEX reward, right? How does that work?

Yes you can, please contact Fabio on the openlimits slack


game not launching

Describe the bug game not running when launching
To Reproduce idk
Expected behavior game not running
Screenshots
OS windows

Please make sure the path to your FA installation (steam) is correct in the settings
Please provide downlords-faf-client.log from C:\ProgramData\FAForever\logs
Can you go to C:\ProgramData\FAForever\bin\ and check if you are able to run ForgedAlliance.exe?

Also please provide logs, u can find them by clicking "show log" in the top right of the client

Not sufficent information


Add note about when ground truth labels are required

To reduce some confusion, add a note mentioning that ground truth labels are only required for context_recall, since the tool can generate other metrics in a "ground truth" free manner.

Thank you so much @tleyden for taking the time to help with the docs. Much appreciated 🙂


Allow access to Dask-Gateway from clients outside of QHub

As per the user-request (described at #174), we want to allow QHub to connect to Dask clusters outside of Kubernetes.
To do so, we will need to:

Explore options on how to securely expose the cluster;
Createguidelines docs on teaching users how to create their own credentials for JupyterHub authentication.

This is an epic ticket, feel free to add all issues that are part of this user-story.

Closed due to becoming a milestone.

Closed due to becoming a milestone.


LSPS0 more notes for implementation

There is an LDK sub-project to build LSPS0 support.  Dig up the link and put it in LSPS0 "Notes for implementation" section.  Please assign to me.

https://github.com/lightningdevkit/ldk-lsp-client <- the LDK sub-project


[PER-01M] Potentially Incompatible Code

PER-01M: Potentially Incompatible Code

Type
Severity
Location

Language Specific

ProtectedERC20.sol:L12-L13

Description:
The ProtectedERC20 token wrapper will attempt to use the IERC20Metadata::name and IERC20Metadata::symbol functions of the underlying token even though it may not support them.
Example:
constructor(address underlying, string memory underlyingName, string memory underlyingSymbol)
ERC20(
    string(abi.encodePacked("Kinza Protected ", IERC20Metadata(underlying).name())),
    string(abi.encodePacked("p", IERC20Metadata(underlying).symbol()))
    )
ERC20Wrapper(IERC20(underlying)) {
}

Recommendation:
Given that the metadata EIP-20 standard is optional, the code should be compatible with tokens that do not comply with it by f.e. using the token's address.

we would like to respect the name & symbol of the underlying token; if name/symbol is unavailable or does not conform with metadata from EIP-20 we would need to make code change anyway so the current behavior is acceptable; address is already included as "underlying".


[Feature Request] Added a new component ChatMessage

Existing Component
No
Component Name
ChatMessage
Description

I have created a ChatMessage component. The contributing page says that a merge requires two maintainers. What next steps do I need to take?
Demo: https://element.dev54.ru/#/en-US/component/chat-message
Commit: https://github.com/mes01/element/commit/f4f0712ae332ff0865968ccb49c80e443528b327

Is there anyone can follow up on this request?


Proliferate TAOS-CI to help developers that suffer from incorrect PRs

Now, it is an appropriate time to advertise TAOS-CI to help project leaders that suffer from incorrect PRs.

https://github.com/joho/awesome-code-review/pull/11

:octocat: cibot: Thank you for posting issue #254. The person in charge will reply soon.


Weekly PR

Feature #67 Game Center login for Profile

@borisspektor @refaelos, it's ready for merge.


Add doctor check for Python 'six' module

Required as part of Xcode lldb module. In all likelihood, if we
encounter this situation, the developer is using a custom Python install
(e.g., via MacPorts or Homebrew).

Fixes a potential gotcha encountered in #7767.


Fix failures while executing make test-e2e

Observed that the make test-e2e command fails due to unavailability of the cert-manager-webhook service with the following error log snippet.
[FAILED] Unexpected error:
      <*errors.errorString | 0xc00012c550>:
      make deploy IMG=quay.io/amalvank/instaslicev2-controller:latest failed with error: (exit status 2) make[1]: Entering directory '/home/svanka/go/src/instaslice-operator'
      test -s /home/svanka/go/src/instaslice-operator/bin/controller-gen && /home/svanka/go/src/instaslice-operator/bin/controller-gen --version | grep -q v0.14.0 || \
      GOBIN=/home/svanka/go/src/instaslice-operator/bin go install<EMAIL_ADDRESS>      /home/svanka/go/src/instaslice-operator/bin/controller-gen rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
      cd config/manager && /home/svanka/go/src/instaslice-operator/bin/kustomize edit set image controller=quay.io/amalvank/instaslicev2-controller:latest daemonset=quay.io/amalvank/instaslicev2-daemonset:latest
      /home/svanka/go/src/instaslice-operator/bin/kustomize build config/default | kubectl apply -f -
      Warning: resource namespaces/instaslice-operator-system is missing the kubectl.kubernetes.io/last-applied-configuration annotation which is required by kubectl apply. kubectl apply should only be used on resources created declaratively by either kubectl create --save-config or kubectl apply. The missing annotation will be patched automatically.
      namespace/instaslice-operator-system configured
      customresourcedefinition.apiextensions.k8s.io/instaslices.inference.codeflare.dev configured
      serviceaccount/instaslice-operator-controller-manager created
      role.rbac.authorization.k8s.io/instaslice-operator-leader-election-role created
      clusterrole.rbac.authorization.k8s.io/instaslice-operator-manager-role created
      clusterrole.rbac.authorization.k8s.io/instaslice-operator-metrics-reader created
      clusterrole.rbac.authorization.k8s.io/instaslice-operator-proxy-role created
      rolebinding.rbac.authorization.k8s.io/instaslice-operator-leader-election-rolebinding created
      clusterrolebinding.rbac.authorization.k8s.io/instaslice-operator-manager-rolebinding created
      clusterrolebinding.rbac.authorization.k8s.io/instaslice-operator-proxy-rolebinding created
      service/instaslice-operator-controller-manager-metrics-service created
      service/instaslice-operator-webhook-service created
      deployment.apps/instaslice-operator-controller-manager created
      daemonset.apps/instaslice-operator-controller-daemonset created
      mutatingwebhookconfiguration.admissionregistration.k8s.io/instaslice-operator-mutating-webhook-configuration created
      Error from server (InternalError): error when creating "STDIN": Internal error occurred: failed calling webhook "webhook.cert-manager.io": failed to call webhook: Post "https://cert-manager-webhook.cert-manager.svc:443/validate?timeout=30s": dial tcp <IP_ADDRESS>:443: connect: connection refused
      Error from server (InternalError): error when creating "STDIN": Internal error occurred: failed calling webhook "webhook.cert-manager.io": failed to call webhook: Post "https://cert-manager-webhook.cert-manager.svc:443/validate?timeout=30s": dial tcp <IP_ADDRESS>:443: connect: connection refused
      make[1]: *** [Makefile:230: deploy] Error 1
      make[1]: Leaving directory '/home/svanka/go/src/instaslice-operator'

This change waits until the cert-manager-webhook pod is in Running state before performing the e2e test.
/cc @harche @asm582 @mamy-CS

/lgtm


@vercel/blob - Support for Thumbnail in Vidoe Uploads

Summary
I am working on a project where I have to display all the videos that are uploaded in blob. But I have to manually take out the a thumbnail image and uploading it there. For streaming purposes, it is important to have a thumbnail to show.
I propose an addition in response API of upon uploading and listing videos.
{
  pathname: 'profilesv1/user-12345.txt',
  contentType: 'text/plain',
  contentDisposition: 'attachment; filename="user-12345.txt"',
  url: 'https://ce0rcu23vrrdzqap.public.blob.vercel-storage.com/profilesv1/user-12345-NoOVGDVcqSPc7VYCUAGnTzLTG2qEM2.mp4'
  downloadUrl: 'https://ce0rcu23vrrdzqap.public.blob.vercel-storage.com/profilesv1/user-12345-NoOVGDVcqSPc7VYCUAGnTzLTG2qEM2.mp4?download=1',
  thumbnail: 'https://ce0rcu23vrrdzqap.public.blob.vercel-storage.com/.thumbnail/user-12345-NoOVGDVcqSPc7VYCUAGnTzLTG2qEM2.png'
}

Here, .thumbnail folder can be made which is used to store metadata like thumbnail. I would like to discuss its complexity & contribute if it is approved by maintainers of this repo.

Hey @bhupesh98 are you suggesting that Vercel Blob could create a thumbnail from your videos automatically? Thanks!

Hey @bhupesh98 are you suggesting that Vercel Blob could create a thumbnail from your videos automatically? Thanks!

Yes, while uploading videos, it should randomly take out a frame and save it in .thumbnail folder under same pathname. Also, for videos, a config object can be sent to customize which timestamp of video frame to take as a thumbnail.

+1 for thumbnail generation


TypeError: ResourceDto.init() got an unexpected keyword argument 'createdDate'

Hello,
Seems like the API got updated and there's a missing field. Should be a real easy fix, and will be forking the repo to get it done.
I. I am running the API, attempting to query resources with the following line:
resources_response = client.resource.query_resources(None, None, None, None, None)
I expect it to return an AstroResult list of resources.
II. Unfortunately, I get the following error
TypeError: ResourceDto.init() got an unexpected keyword argument 'createdDate'
A search of the source code reveals that the ResourceDto class does not have this attribute
https://github.com/projectmgr/projectmanager-sdk-python/blob/4a060919f2b4a4a234cbf557a7ef5747e8aa502f/src/ProjectManagerSdk/models/resourcedto.py
III. Steps to reproduce
import ProjectManagerSdk
client = ProjectManagerSdk.projectmanagerclient.ProjectManagerClient('production','KCMDATAMESH')
client.with_api_key(apiKey)
resources_response = client.resource.query_resources(None, None, None, None, None)

Adding these attributes to the resourceDto class fixes the error
createdDate: str | None = None
createdBy: str | None = None
modifiedDate: str | None = None
modifiedBy: str | None = None

Thanks for catching this.  The Python SDK should not be throwing errors for new fields like this; we are shipping a R114 patch today that adds these fields.  The goal for the SDK should be - if a new release of the API starts sending a new field, and you're using an older version of the SDK, you shouldn't get an error for that.
We'll run some more tests to make sure this is being properly caught.  Thanks for the report!

It's no problem. It was benign in nature since it was pretty clear what the error was in terms of how API integration can go.
Otherwise, the API has been straightforward to work with and this SDK is helpful.

I found that although I had updated parts of the code to use dacite, not every part did.  I updated the generator to replace ** with dacite, and it now handles regular addition of new fields correctly.


installed irmin-unix using opam but it says command not found

I have installed irmin but it says command not found .
sahana@sahana-HP-ProBook-440-G4:~/work/irmin_ocaml$ irmin
irmin: command not found

sahana@sahana-HP-ProBook-440-G4:~/work/irmin_ocaml$ opam install irmin-unix
The following actions will be performed:
  - install irmin      0.12.0                           [required by irmin-unix]
  - install irmin-unix 0.12.0
===== 2 to install =====
Do you want to continue ? [Y/n] y

=-=- Gathering sources =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
[irmin] Archive in cache

=-=- Processing actions -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
-> installed irmin.0.12.0
-> installed irmin-unix.0.12.0
Done.

sahana@sahana-HP-ProBook-440-G4:~/work/irmin_ocaml$ irmin-unix help
irmin-unix: command not found

sahana@sahana-HP-ProBook-440-G4:~/work/irmin_ocaml$ which irmin

sahana@sahana-HP-ProBook-440-G4:~/work/irmin_ocaml$ irmin help
irmin: command not found

Are you sure that Opam-installed binaries are in your PATH? (with eval $(opam env))
What is the result of opam exec irmin help?

-> installed irmin.0.12.0
-> installed irmin-unix.0.12.0

You opam installed a very old version of irmin.
Can you try opam update then opam install irmin-unix.2.1.0, to install the latest version?

Good spot. You may also be using an Opam 1.x version, in which case you probably want to upgrade to Opam 2.x to access Irmin 2.0+.

yes the opam version is 1.2.2 .  I tried "opam update" but the version is still 1.2.2

For the "opam exec irmin help" and "opam env" it says exec and env command not found.

yes the opam version is 1.2.2 . I tried "opam update" but the version is still 1.2.2

opam update updates the repository metadata, not opam itself. For that, you'll need to follow https://opam.ocaml.org/doc/Install.html#Upgrading-from-a-previous-version.

For the "opam exec irmin help" and "opam env" it says exec and env command not found.

Yes, this will be because your Irmin version is from before the CLI was introduced. Try opam upgrade irmin (ideally after installing Opam 2.0, to get the latest Irmin version).

I have updated the opam version. But Now I am not able to update irmin.
sahana@sahana-HP-ProBook-440-G4:~$ opam --version
2.0.6

sahana@sahana-HP-ProBook-440-G4:~$ opam install irmin-unix
[ERROR] irmin-unix unmet availability conditions, e.g. ocaml-version >=
        "4.01.0"

sahana@sahana-HP-ProBook-440-G4:~$ ocaml -version
The OCaml toplevel, version 4.02.3

sahana@sahana-HP-ProBook-440-G4:~$ opam upgrade irmin
[ERROR] irmin unmet availability conditions, e.g. ocaml-version >= "4.03.0"

sahana@sahana-HP-ProBook-440-G4:~$ opam install irmin-unix.2.1.0
[ERROR] Package irmin-unix has no version 2.1.0.

sahana@sahana-HP-ProBook-440-G4:~$ opam install irmin-unix
[ERROR] irmin-unix unmet availability conditions, e.g. ocaml-version >=
        "4.01.0"

Apparently you also have a very old OCaml version, so that won't be compatible with irmin.
You can upgrade your OCaml version with opam upgrade --unlock-base ocaml-base-compiler.4.09.1, then you should be able to install it correctly.

Thanks @pascutto and @CraigFe


Align int types in ShapeAttr with actual metal implementation

In several places in code, we are using different int types (uint32_t, int32_t, int64_t) to represent shape values. They should be aligned so that they match everywhere (IR, flatbuffers, ...). Source of truth is TTNN lib. In flatbuffers, we read shape of output tensor in many places instead of directly reading the shape operand.

ttnn/cpp/ttnn/tensor/types.hpp - uint32_t is the one we should aim for.


Stream existing electron apps

From Ben's Medium writeup:

It’s important to note that in our solution, an app is simply any online resource that can be accessed and rendered in a browser by a configurable unique URL.

I'd like to use browserd for streaming existing electron apps, for example postman and dot. These apps would run in a container on a server and be streamed to a browserd/stream-consumer. This goal appears to be fundamentally different to the intention of the project which is for streaming a URL accessible web app, not an existing electron app.
From your experience on this project, do you know if it's possible to achieve my goal? Essentially SERVICE_URL would point to an electron app, however an electron app is not addressable by a URL.

Short answer is yes this is possible, but requires some changes (not sure the size of em just yet, either).
The changes
https://github.com/bengreenier/browserd/blob/74110ed3c02a8fc04ee103398814fdfcbc4ce27c/components/stream-provider/src/node/application.ts#L95 would have to go, as we won't create a browser window ourselves to host the experience. then the captureWindowTitle would need to be passed, and match the window name of the process you want to capture.
https://github.com/bengreenier/browserd/blob/74110ed3c02a8fc04ee103398814fdfcbc4ce27c/components/stream-provider/src/node/application.ts#L116
which eventually chains to the actual window enumeration and filtering logic:
https://github.com/bengreenier/browserd/blob/74110ed3c02a8fc04ee103398814fdfcbc4ce27c/components/stream-provider/src/browser/application.ts#L85
At that point, you should be able to grab the window frames. The last tricky bit is mapping input, and i'm not sure our current approach allows doing this across different input windows...you'd have to see if this code
https://github.com/bengreenier/browserd/blob/74110ed3c02a8fc04ee103398814fdfcbc4ce27c/components/stream-provider/src/browser/input.ts#L24
that uses the sendInputEvent call works on processes that aren't owned by our application handle. If it does work, great input is easy - our code may even just work. However, if it doesn't...
Well, if our existing input approach doesn't work you've probably got to look at shelling out to some OS helper that can simulate input on an OS scale. I played with xdotool a bit - it might be capable of doing such a thing.
I'd be happy to field questions for this type of work (probably via this issue thread) if you (or anyone else, for that matter) wants to give this a go.


Difference between person_center and ann_center?

Hi,
I have a short question regarding the bounding boxes. In measurement 3 (M3) you use bounding boxes from gender and from anns. However, I don't quite understand the difference between those.
In my understanding, gender is passed the person bounding box. But which bounding box is passed to anns?
Thank you very much in advance.
All the best,
Nastassia

Hi Nastassia, the bounding boxes in anns correspond to objects, whereas the bounding boxes passed through gender corresponds to the person. If there are no objects in your dataset, anns can be left as an empty list. Hope that helps!

Hi Nastassia, the bounding boxes in anns correspond to objects, whereas the bounding boxes passed through gender corresponds to the person. If there are no objects in your dataset, anns can be left as an empty list. Hope that helps!


remove gitignore

there was a gitignore in the husky folder by default, which is why it was only running for me 🤦♂. Removed
this .sh file is the default one given when you install husky

@CassioMG ok I figured it out. The husky hook needs to be added to each person's local machine, and is added when husky install is ran.
can you run yarn prepare when you get the chance, and add another test commit to check it's working?

@CassioMG ok I figured it out. The husky hook needs to be added to each person's local machine, and is added when husky install is ran.
can you run yarn prepare when you get the chance, and add another test commit to check it's working?

@acharb ok looks like it worked now :)
I pushed a completely messed up commit and it only left 2 blank lines

@acharb just FYI, on Vibrant we use the below packages which help us keeping a very consistent codebase in regards to code formatting, typing, syntax and also detecting unused code (like unused imports which I see happens quite often in our typescript-wallet-sdk repo, also works for unused functions):
"@stellar/eslint-config": "^2.1.2", ===> we already use this on the TS repo
"@stellar/prettier-config": "^1.0.1", ===> we already use this on the TS repo
"@stellar/tsconfig": "^1.0.2", ===> we already use this on the TS repo
"prettier": "^2.6.0", ===> we already use this on the TS repo (but on version 2.0.5)
"@typescript-eslint/eslint-plugin": "^5.15.0",  ===> new to TS repo
"@typescript-eslint/parser": "^5.15.0", ===> new to TS repo
"@fnando/eslint-plugin-consistent-import": "*", ===> new to TS repo
"babel-eslint": "^10.0.3", ===> new to TS repo
"eslint-config-prettier": "^8.6.0", ===> new to TS repo
"eslint-plugin-prettier": "^4.0.0", ===> new to TS repo
"ts-prune": "^0.10.3", ===> new to TS repo
we also use some scripts in addition to those imports, so maybe some of them wouldn't work out of the box but thought about sharing it in case you'd like to take a look :)

awesome I'll look through these. I was hesitant to add linting at the start but there's a ticket to add it now that it's public. I'll add this to the ticket thanks!


numatop: init at 2.1

Motivation for this change
Useful utility.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

The tool requires root access. Is this intended?

I think so? :).

The platform should be restricted to x86_64-linux. Since the tool is provided by intel it may not be intended to work on ARM.


Project Console - remove duplicate "View Companies" button.

Summary
The "View Companies" option is duplicated in the project console. Please remove the button from the UI.

Observe a "View Companies" button and a "View Companies" link that do the exact same thing.

Screenshots
If applicable, add screenshots to help explain your problem.

confirmed the button is gone in dev.

Verified that the issue is fixed


Comment button is shown despite WAGTAILADMIN_COMMENTS_ENABLED = False

Issue Summary
The comment button is shown even if WAGTAILADMIN_COMMENTS_ENABLED = False is set in settings. It is however not possible to add a comment since it is not initialized.
I would suggest that the FieldPanel.comments_enabled property should take into account WAGTAILADMIN_COMMENTS_ENABLED's value. This setting is an interesting feature when comments are not wanted in a project - which is by the way easier and faster than definning disable_comments=True to each panel.
Technical details

Python version: 3.11.2
Django version: 4.2.1
Wagtail version: 5.0

Confirmed on a fresh Wagtail instance running from main. Thanks for the report @jeromelebleu!

Thanks for the report @jeromelebleu. I thought I had covered this but it looks like I then refactored the CSS in a way that breaks this scenario. The current implementation is unfortunately very inelegant, with the setting only toggling a CSS class that shows/hides the buttons.

Related: #9670


Restore default Ivy completion style

https://github.com/purcell/emacs.d/blob/86adc49d280633d2e83e52e1e9c302ecbeac3666/lisp/init-ivy.el#L25
Hi, I'm trying to restore default Ivy completion style
(setq ivy-re-builders-alist       '((t . ivy--regex-plus)))
Or disable sanityinc/enable-ivy-flx-matching
How can I do?
Thanks

I didn't really build that to be a toggle, so your options are:

Don't call sanityinc/enable-ivy-flx-matching
Restart Emacs. :-)
Use (setq-default ivy-re-builders-alist '((t . ivy--regex-plus))) <- note the setq-default


Security Issue!

Hey,
I found a security issue how I can report it?
Regards,
@alpernae

any update?


stage1: Add logic to insert environment from manifest

update logic to insert environment from manifest on stage1_fly/run/main.go

closed because weird merge raised.


It goes slow...

The Teletype's installation goes SUPER slow!
Ty guys! you rock anyway!

Thanks for the feedback and the kind words!
Not sure what kind of install time you're seeing, is it minutes or tens of minutes?  Filling out the issue template is super helpful for us so please keep that in mind for future issues.
I think the install time could vary based on things like your location, what kind of computer you have, how you connect to the internet, etc.  But I'd also guess that you probably see similar install times for other packages as well so this isn't specific to Teletype?  In any case, it sounds like besides the wait, you have Teletype installed and running so we'll go ahead and close this out and share your feedback with the other maintainers.
Thanks again :bow:


Uninstall gobrew

I think the steps on how to uninstall gobrew from your system is missing in the README.

Thanks, done!


[Bug] Timer fails in the transition between classes

When the timer reaches 0 and should start counting down for the next class, it instead freezes at 0 and displays "Summer | Free"
Clearly something is wrong, but when forcing the Calendar object to be a few seconds before the transition and adding 1000ms to it each second, this bug is NOT replicated.
It only appears during real-time transitions.

This issue has been fixed as described in commit afd7473


iCloud: Messages are marked as unread regardless of setting

I found #118, but it seems in 13.0.0 the issue still (or again) exists. Interestingly there is a difference in behaviour that I observed:

A completely new e-mail never previously read will be marked as read once imap-backup runs
A previously read e-mail manually marked as unread will not be marked as read once imap-back runs

The behaviour is the same, regardless of the fix changes to unread flags during download setting

Hi @glocknerc
Thanks for opening the issue. I've found the cause and will be releasing a fix soon!

I've release version 13.1.0 with a fix.


No way to add customHttp.yml to AWS::Amplify::App CloudFormation

** Please describe which feature you have a question about? **
I've been using CloudFormation to automate the creation of Amplify Apps and with the recent change of shifting Custom headers out of the amplify.yml file and into customHttp.yml I wanted to find out how this can be done through CloudFormation now?
** Provide additional details**
There is a BuildSpec param currently documented here - https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-amplify-app.html
There does not appear to be an equivalent CustomHttp param (or similar)
Apologies with this should be in another repository, I wasn't sure where the related CloudFormation repository lives.

Hi @Alk3m1st we'll be rolling out CloudFormation support for the new customHeaders field on the App resource in the next week, and the docs will be updated to reflect the new property.

Thanks @kahdojay looking forward to it.

@Alk3m1st https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-amplify-app.html

Just to add to finally, it would be useful to have an example in the CloudFormation documentation. It took some time and failed attempts to figure out that I needed to keep customHeaders: in the CustomHeaders: CFN property. I initially assumed it could be just the - pattern: if that makes sense.


Not able to install this software properly in ARC/HTC cluster

Hi,
Following all the instructions (using git clone route) I tried to install this package in HTC cluster. However although it did not throw any error during installation, but  in the BioAutoMATED folder  there is no code/modules when  I launched the same using Jupyter notebook. Using docker Icould successfully install in Win 11, however the tool could not process sequences with length > 300 in the same machine (intel i5, NVIDIA-GeForce GTX-1650 Ti)  so Itried to install it in ARC cluster which has more memory capability , in order to process these sequences.
Can you please advice on this. Thanks!

Hi Shruti, thanks for reaching out and I am sorry that you are having issues. First, I am happy to hear that you can successfully install BioAutoMATED in Windows 11 via Docker. You should also be able to install the code on a cluster as well. After installing via Docker, the localhost:8888 port should look something like this: . The code can be found under BioAutoMATED/main_classes/.
After installing via git clone, the BioAutoMATED folder should have many similar elements, including the main_classes/ folder where the main python scripts can be found. The folder should look like this: . Can you provide more details about what the installed BioAutoMATED folder contains via the git clone route on the ARC cluster? It might be that the download was incomplete and perhaps you can try to clone the folder again and verify if this solves the issue.
I will also add a quick note that a known limitation of BioAutoMATED is longer range sequences; we only tested sequences up to several hundred base pairs. The computational complexity of datasets with longer sequences is high and the model architectures we chose to explore with BioAutoMATED are not necessarily suited for longer sequences. Your experiment should still work, but please keep these limitations in mind.

Hello,
Thank you very much for getting back to me and I apologize for late response. I could successfully install this software in Cluster. This is a very good package overall. Thanks for your contribution.

Wonderful news! Let me know if any other questions or issues pop up and thanks for using BioAutoMATED!


2016-10-27-release-0.13.1.md

2016-10-27-release-0.13.1.md translation in simplified mandarin

ping @jl2012

I merged the contributions from @jl2012


Seed is different from what webpage says.

Im running seed<PHONE_NUMBER>, in the website it says itll have a snow flask and first shift is lava to pea soup, after testing ingame i start with slime flask and first shift is worm blood to normal blood. Noita is April Build 23 2021

The highest allowed seed is<PHONE_NUMBER>. I made a commit that should cap the seed at that number.
Update: It seems that noita allows you to set this seed, but with some errors:

The issue seems to be in the random algorithm wasm module - i will try to replace my implementation with the one from https://github.com/kaliuresis/noa

I replaced the wasm module with kaliuresis' version, it seems to be working.


transitionsProvider onEnter not firing everytime for '*'

Hi,
I was trying to save the previous state for auth success redirection.
Isn't this code supposed to fire every transition?
    $transitionsProvider.onStart({to:'*'}, ($transition$) => {
       // save previous state info
    })

but this fires every time.
    $transitionsProvider.onEnter(
      {to: () => { return true; }},
      $transition$ => {
       // save previous state info
      }
    )

Am I missing something?
I was trying it with the alpha.3 version.

Isn't this code supposed to fire every transition?

The '*' glob matches only top-level states, as opposed to the '**' glob which matches any top level or child state.
$transitionsProvider.onStart({to:'**'}, cb) should invoke the callback for every transition.

    $transitionsProvider.onEnter(
      {to: () => { return true; }},
      $transition$ => {
       // save previous state info
      }
    )

This code will fire for each state being entered (not just for each transition)
 $transitionsProvider.onEnter({ to: 'login' }, getFromStateFunction) will fire when the login state is entered.

Take a look at the sample app's login state: https://github.com/ui-router/sample-app/blob/master/app/login.state.js
It defines a resolve returnTo which injects the current Transition, then figures out where the user should be sent back to after a successful login.
The sample app accounts for two cases:

a redirected request

unauthenticated user is on e.g. 'welcome'
user attempts to access protected resource e.g. 'contacts', so the transition is redirected to 'login'
after user logins in, they should return to 'contacts' (the redirected transition's to state) because that's where they wanted to go

user clicks login

unauthenticated user is on e.g. 'welcome'
user clicks 'login' link
after user logs in, they should return to the 'welcome' page because that's where they came from

@zirho does that answer your issue?

closing because I don't think there's a bug here

@christopherthielen @eddiemonge
Yes it resolves my issue.
Thank you so much for the support.
I really appreciated.


peer review of CHAOS-5172

Implement peer review on CHAOS-5172

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6621f3d7f926957b6021d13d--harness-developer.netlify.app


Bookmarks

Allow:

select row in main output and mark row as bookmarked

Result:

bookmarked row should be always visible in a search result output

Also:

bookmarked rows should have a different style to easily recognize in stream

done


rename lcs to bcs

Rename LCS to BCS.
I'm unsure if this rename will be a breaking change wrt to the changes in Move

This PR may have modified JSON-RPC server code.
Breaking changes policy:

Chaning JSON-RPC method signatures or removing/modifying fields
in the response in /V1 will not be accepted.
Adding fields is ok.
Adding a new JSON-RPC method is ok.

Please ensure you have also done the following to update the docs:

Update json-rpc/API-CHANGELOG.md.
Add/update type/method documentation under json-rpc/docs.

LEC dependency change summary:
target packages:
  A bcs 0.1.1 (direct third-party, crates.io)
    * features: [none]
  R libra-canonical-serialization 0.1.0 (direct third-party, crates.io)
    * (old features: [none])

LSR dependency change summary:
target packages:
  A bcs 0.1.1 (direct third-party, crates.io)
    * features: [none]
  R libra-canonical-serialization 0.1.0 (direct third-party, crates.io)
    * (old features: [none])

release binaries dependency change summary:
target packages:
  A bcs 0.1.1 (direct third-party, crates.io)
    * features: [none]
  M libra-canonical-serialization 0.1.0 (transitive third-party, crates.io)
    * status changed from direct third-party
    * (unchanged features: [none])

/canary

LSR dependency change summary:
target packages:
  A bcs 0.1.1 (direct third-party, crates.io)
    * features: [none]
  R libra-canonical-serialization 0.1.0 (direct third-party, crates.io)
    * (old features: [none])

LEC dependency change summary:
target packages:
  A bcs 0.1.1 (direct third-party, crates.io)
    * features: [none]
  R libra-canonical-serialization 0.1.0 (direct third-party, crates.io)
    * (old features: [none])

release binaries dependency change summary:
target packages:
  A bcs 0.1.1 (direct third-party, crates.io)
    * features: [none]
  M libra-canonical-serialization 0.1.0 (transitive third-party, crates.io)
    * status changed from direct third-party
    * (unchanged features: [none])

LEC dependency change summary:
target packages:
  A bcs 0.1.1 (direct third-party, crates.io)
    * features: [none]
  R libra-canonical-serialization 0.1.0 (direct third-party, crates.io)
    * (old features: [none])

LSR dependency change summary:
target packages:
  A bcs 0.1.1 (direct third-party, crates.io)
    * features: [none]
  R libra-canonical-serialization 0.1.0 (direct third-party, crates.io)
    * (old features: [none])

release binaries dependency change summary:
target packages:
  A bcs 0.1.1 (direct third-party, crates.io)
    * features: [none]
  M libra-canonical-serialization 0.1.0 (transitive third-party, crates.io)
    * status changed from direct third-party
    * (unchanged features: [none])

LSR dependency change summary:
target packages:
  A bcs 0.1.1 (direct third-party, crates.io)
    * features: [none]
  R libra-canonical-serialization 0.1.0 (direct third-party, crates.io)
    * (old features: [none])

LEC dependency change summary:
target packages:
  A bcs 0.1.1 (direct third-party, crates.io)
    * features: [none]
  R libra-canonical-serialization 0.1.0 (direct third-party, crates.io)
    * (old features: [none])

release binaries dependency change summary:
target packages:
  A bcs 0.1.1 (direct third-party, crates.io)
    * features: [none]
  M libra-canonical-serialization 0.1.0 (transitive third-party, crates.io)
    * status changed from direct third-party
    * (unchanged features: [none])

@bob-wilson Thanks for the review. I'll make sure those changes are made

/canary

release binaries dependency change summary:
target packages:
  A bcs 0.1.1 (direct third-party, crates.io)
    * features: [none]
  M serde-generate 0.17.0 (direct third-party, crates.io)
    * version upgraded from 0.16.1
    * (unchanged features: [none])
  R libra-canonical-serialization 0.1.0 (direct third-party, crates.io)
    * (old features: [none])

LEC dependency change summary:
target packages:
  A bcs 0.1.1 (direct third-party, crates.io)
    * features: [none]
  R libra-canonical-serialization 0.1.0 (direct third-party, crates.io)
    * (old features: [none])

LSR dependency change summary:
target packages:
  A bcs 0.1.1 (direct third-party, crates.io)
    * features: [none]
  R libra-canonical-serialization 0.1.0 (direct third-party, crates.io)
    * (old features: [none])

/cancel

/canary

LSR dependency change summary:
target packages:
  A bcs 0.1.1 (direct third-party, crates.io)
    * features: [none]
  R libra-canonical-serialization 0.1.0 (direct third-party, crates.io)
    * (old features: [none])

LEC dependency change summary:
target packages:
  A bcs 0.1.1 (direct third-party, crates.io)
    * features: [none]
  R libra-canonical-serialization 0.1.0 (direct third-party, crates.io)
    * (old features: [none])

release binaries dependency change summary:
target packages:
  A bcs 0.1.1 (direct third-party, crates.io)
    * features: [none]
  M serde-generate 0.17.0 (direct third-party, crates.io)
    * version upgraded from 0.16.1
    * (unchanged features: [none])
  R libra-canonical-serialization 0.1.0 (direct third-party, crates.io)
    * (old features: [none])

LEC dependency change summary:
target packages:
  A bcs 0.1.1 (direct third-party, crates.io)
    * features: [none]
  R libra-canonical-serialization 0.1.0 (direct third-party, crates.io)
    * (old features: [none])

LSR dependency change summary:
target packages:
  A bcs 0.1.1 (direct third-party, crates.io)
    * features: [none]
  R libra-canonical-serialization 0.1.0 (direct third-party, crates.io)
    * (old features: [none])

release binaries dependency change summary:
target packages:
  A bcs 0.1.1 (direct third-party, crates.io)
    * features: [none]
  M serde-generate 0.17.0 (direct third-party, crates.io)
    * version upgraded from 0.16.1
    * (unchanged features: [none])
  R libra-canonical-serialization 0.1.0 (direct third-party, crates.io)
    * (old features: [none])

LSR dependency change summary:
target packages:
  A bcs 0.1.1 (direct third-party, crates.io)
    * features: [none]
  R libra-canonical-serialization 0.1.0 (direct third-party, crates.io)
    * (old features: [none])

LEC dependency change summary:
target packages:
  A bcs 0.1.1 (direct third-party, crates.io)
    * features: [none]
  R libra-canonical-serialization 0.1.0 (direct third-party, crates.io)
    * (old features: [none])

release binaries dependency change summary:
target packages:
  A bcs 0.1.1 (direct third-party, crates.io)
    * features: [none]
  M serde-generate 0.17.0 (direct third-party, crates.io)
    * version upgraded from 0.16.1
    * (unchanged features: [none])
  R libra-canonical-serialization 0.1.0 (direct third-party, crates.io)
    * (old features: [none])

release binaries dependency change summary:
target packages:
  A bcs 0.1.1 (direct third-party, crates.io)
    * features: [none]
  M serde-generate 0.17.0 (direct third-party, crates.io)
    * version upgraded from 0.16.1
    * (unchanged features: [none])
  R libra-canonical-serialization 0.1.0 (direct third-party, crates.io)
    * (old features: [none])

LEC dependency change summary:
target packages:
  A bcs 0.1.1 (direct third-party, crates.io)
    * features: [none]
  R libra-canonical-serialization 0.1.0 (direct third-party, crates.io)
    * (old features: [none])

LSR dependency change summary:
target packages:
  A bcs 0.1.1 (direct third-party, crates.io)
    * features: [none]
  R libra-canonical-serialization 0.1.0 (direct third-party, crates.io)
    * (old features: [none])

/canary

:sunny: Canary successful

/land


Cannot read property 'match' of undefined

When running react-native link react-native-fast-image, I get the error
Cannot read property 'match' of undefined
Stack trace is below:
rnpm-install ERR! Something went wrong while linking. Error: Cannot read property 'match' of undefined
Please file an issue here: https://github.com/facebook/react-native/issues

Cannot read property 'match' of undefined

TypeError: Cannot read property 'match' of undefined
    at findLineToAddPod (....react-native/local-cli/link/pods/findLineToAddPod.js:22:13)
    at getLinesToAddEntry (....node_modules/react-native/local-cli/link/pods/registerNativeModule.js:36:8)
    at registerNativeModulePods (....node_modules/react-native/local-cli/link/pods/registerNativeModule.js:25:21)
    at Object.registerNativeModule [as register] (....node_modules/react-native/local-cli/link/ios/common/registerNativeModule.js:13:1)
    at ....node_modules/react-native/local-cli/link/link.js:74:12
    at Array.forEach (<anonymous>)
    at linkDependency$ (....node_modules/react-native/local-cli/link/link.js:44:28)
    at tryCatch (....node_modules/@babel/runtime/node_modules/regenerator-runtime/runtime.js:62:40)
    at Generator.invoke [as _invoke] ....node_modules/@babel/runtime/node_modules/regenerator-runtime/runtime.js:288:22)
    at Generator.prototype.(anonymous function) [as next] (....node_modules/@babel/runtime/node_modules/regenerator-runtime/runtime.js:114:21)

same err


feature mark join to support subquery in disjunction

Proposed changes
-- create table
Create Table: CREATE TABLE `t1` (
  `id` int(11) NULL
) ENGINE=OLAP
DUPLICATE KEY(`id`)
COMMENT 'OLAP'
DISTRIBUTED BY HASH(`id`) BUCKETS 10
PROPERTIES (
"replication_allocation" = "tag.location.default: 1",
"in_memory" = "false",
"storage_format" = "V2",
"disable_auto_compaction" = "false"
);

-- query
select id from t1 where (id < 5 and (id > 0 or id in (select id from t1 a where t1.id = a.id))) and id in (select id from t1 a where t1.id = a.id);

Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.7 seconds
load time: 432 seconds
storage size:<PHONE_NUMBER>6 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221130144837_clickbench_pr_55652.html


Bot error on_voice_state_update

(<Member id=235088799074484224 name='Rythm' discriminator='3722' bot=True nick=None guild=>, <VoiceState self_mute=False self_deaf=False channel=>, )
{}

Reported on discordbot by discord user--------------------------------------------------------------------------------
AttributeError
Stack Trace:

  File "run.py", line 87, in <module>
    run()
  File "run.py", line 14, in run
    bot.init()
  File "/home/discord/Penny-Dreadful-Discord-Bot/discordbot/bot.py", line 194, in init
    client.init()
  File "/home/discord/Penny-Dreadful-Discord-Bot/discordbot/bot.py", line 31, in init
    self.run(configuration.get('token'))
  File "/home/discord/.local/lib/python3.6/site-packages/discord/client.py", line 564, in run
    loop.run_forever()
  File "/usr/lib64/python3.6/asyncio/base_events.py", line 422, in run_forever
    self._run_once()
  File "/usr/lib64/python3.6/asyncio/base_events.py", line 1432, in _run_once
    handle._run()
  File "/usr/lib64/python3.6/asyncio/events.py", line 145, in _run
    self._callback(*self._args)
  File "/home/discord/.local/lib/python3.6/site-packages/discord/client.py", line 220, in _run_event
    await coro(*args, **kwargs)
  File "/home/discord/Penny-Dreadful-Discord-Bot/discordbot/bot.py", line 52, in on_voice_state_update
    voice = after.channel.guild.voice_client

Another case of referring to Channel.guild in a situation where the channel has no such property. It would be way better if this returned None but we can work around it.
I assume we don't need to voice disconnect from a channel that doesn't have a guild but if that's wrong my fix will be wrong.
eaae8be1.

Testing out the commands from help! :D


Rename alljoints-inertials port to avoid using portprefix

With:

https://github.com/robotology/robots-configuration/pull/632

I added the possibility of reading the Euler angles streamed by the IMUs wrapped up in a single port. I named the port as /${portprefix}/alljoints/inertials following what I've done and tested in simulation. Unfortunately, while working on the real robot, I found that the portprefix is not always defined in the configuration files and, if defined, is not always icub or ergocub. For example, on ergoCubSN000, that port is named /ergoCubSN000/alljoints/inertials.
This PR introduces the fix to have all the port names. I also made the change for the iCubs that expose those measurements.

cc @S-Dafarra

Thanks heaps @pattacini!


Job not starting after update from 2.3.1 to 2.4.4

Hi guys. Before the update this was working OK
tower-cli job launch --job-template=55 --extra-vars="DIT=2221 BN=9881"
Error: The Tower server claims it was sent a bad request.

POST https://<HOST>/api/v1/job_templates/55/launch/
Params: None
Data: {"extra_vars": "DIT=2221 BN=9881"}

Response: {"variables_needed_to_start": ["'BN' value missing", "'DIT' value missing"]}

Am I doing something wrong here? Thanks in advance

Apparently this is the way it works now
tower-cli job launch --job-template=19 --extra-vars="{'DIT': 2221, 'BN': 9881}"

I hope this helps as a future reference. I believe documentation should be updated

I can't reproduce the behavior here from the tower-cli side. Launching a job with those extra_vars gives me a request that contains:
Data: {u'extra_vars': '{"DIT": 2221, "BN": 9881}'}

I wouldn't be surprised if you saw that behavior if you were using Tower 2.4.4 with tower-cli 2.3.0. You need tower-cli 2.3.1 to correctly use key=value syntax parsing.