rustfix doesn't fix "use of deprecated item" warnings

I have a bunch of "use of deprecated item warnings" that look like
warning: use of deprecated item 'libc::fixed_width_ints::uint32_t': Use u32 instead.
  --> util_linux/volume_id/xfs.rs:78:16
   |
78 |   pub dummy3: [uint32_t; 2],
   |                ^^^^^^^^

These would seem to be very straightforward to auto-fix since the alternative is presented in the warning itself.

Hey, thanks for the report! Sadly, this repo is just for the library that applies machine-readable suggestions. Making suggestions like this applicable is an issue for the main rust-lang/rust repo, as it is generated by the compiler. (Once it's fixed there, the rustfix tool can automatically apply it.)
I do however fear that it's not as easy as it seems: Library authors can pretty much add a random string there:
https://github.com/rust-lang/libc/blob/13d4a5da2eafd82d3ebb2acb729d8b8c9148fb1f/src/fixed_width_ints.rs#L17-L18
So there's no way for us to apply this suggestion without having a program interpret English text!
Can you maybe check if there is an issue alread on the rust-lang/rust repo for this? Otherwise you are very welcome to suggest how to extend this attribute to make it applicable!
Thanks again :)

@killercup Mm, I see. It would be great if there was more structured information in the deprecation notice. But of course that's an issue for rust-lang/rust...


Add WebTorrent VFS

Hi @rhashimoto and thanks for your awesome work,
I have implemented a WebTorrent based read only VFS. Do you want to add it to the examples?
It will probably never be really fast but being able to "serverless" host a database is very interesting. In combination with a webseed this is also very similar to sql.js-httpvfs (Thanks @phiresky by the way for introducing me into this topic).
To make sure the demo always works it also uses a webseed (the GOOG.db file). To truly test the torrenting you have to open a new tab at https://instant.io/ and add the GOOG.db, which then acts as another peer. Also the adding of the webseed url has to be removed in demo/index.js:L64. When using a magnetUri you may have to increase the torrent ready timeout option of WebTorrentVFS, because loading the meta information from peers is rather slow.

That's cool!
This seems like something that belongs in its own repo.  I'm just not prepared to support contributed code that I may not completely understand, and I haven't figured out what I want to do about CLAs.
I would definitely like to link to your VFS, though. If that's okay with you then can you give me a sentence or two of accompanying description and where you want the link to go? They can be updated later if necessary, e.g. I'd be happy to link to your fork now and a standalone repo later.

I totally understand that. It is not really desirable to add a webtorrent dependency to wa-sqlite.
I added it as PR because I don't consider myself a javascript developer and thus have no experience with publishing or maintaining a javascript package. But I guess this is a good opportunity to learn it 😄
Do you think it is possible/feasible to create a wa-sqlite-base package that basically only contains VFS.js (the abstract base vfs and consts). That way vfs implementations could easily depend on it to get a typed interface they need to implement. The full wa-sqlite is then only required for tests or the actual user of the vfs. Since the vfs api is very stable this package properly will rarely change (or require maintenance).
I will try to setup a wa-sqlite-webtorrent package in the next days or on the weekend. Or do you have a better name suggestion?
P.S. I also noticed some sqlite constants are duplicated between VFS.js and sqlite-api.js. This could also be resolved by having all consts in wa-sqlite-base.

Javascript is not my primary language either, which is why I'm not great with the tooling. 😀 The project is not on npm, so you'll need to use a git dependency. I would recommend using a "buildless" branch or tag instead of the master branch. I haven't been good about versioning and tagging; I'll try to be better going forward.
Originally VFS.js was considered example code, and it really still is just a convenience to help with implementing a VFS. There's no requirement to subclass from it; any object that has the appropriate properties will work. If you would rather bypass subclassing or copy VFS.js into your own tree, those are also options. I'm not clear on the advantages of a standalone VFS base class package - it seems to me that you would need the wrapper API at least as a devDependency for testing, and users will need the API to incorporate it.
Your repo/package name is totally up to you.
The duplication of constant definitions is indeed annoying. I'll see about changing that.

Hi @rhashimoto,
after 2 days of javascript pain I finally found a setup I kind of like 😄
I have created 3 repos:
In wa-sqlite-base is a typescript interface for the vfs api and an abstract base vfs implementation.
wa-sqlite-webtorrent contains my webtorrent vfs and only has wa-sqlite-base as dependency.
wa-sqlite-webtorrent-demo is a Svelte-Kit based demo site very similar to your demo.
I still think that wa-sqlite-base could be useful for other vfs implementations. Especially since I added an abstract name function and a close function to the SQLiteVFS interface. My intention for that was, that a name function is much more obvious than requiring that a name property exists. But for that to work properly, it would be nice if you could switch vfs.name in libvfs.js#L12 and libvfs.js#L25 to vfs.name(). Or get rid of vfs.name altogether and add the name as an argument.
The idea behind close() was that all vfs's should have a defined cleanup function which could make the usage more similar/consistent.
A bit offtopic, have you considered switching to typescript? I found it easier to write typescript and have the .d.ts files get auto generated by the compiler. No need to maintain them by hand and they always match the source code. I ask because I could not get type hints to work for wa-sqlite when using it as dependency (but maybe it's just my bad javascript skills or IntelliJ).
Regarding this PR I will close it now.
You also do not have to link to wa-sqlite-webtorrent. It first needs some documentation and wa-sqlite-webtorrent-demo some fixes, so it can be deployed as github page. Svelte-Kit is just too new & work in progress, the production build is not playing along with monaco-editor currently.

Re Typescript, I like to develop without a build step as much as I can get away with. There was a time when Typescript's advantages could overcome that, but modern Javascript and its browser support (along with Microsoft's willingness to adapt VSCode Typescript tooling to Javascript projects, like supporting JSDoc typing) have advanced to the point that I prefer working with plain Javascript.

@rhashimoto You can use Deno to develop in TypeScript and deno bundle to make a bundle for browsers.
The advantage of Deno is all batteries are included. Tests, Docs, etc. And you don't have to public to npm :-)

@steida  deno bundle is a build step 😀 . The web server I use for development serves unbundled ES6 modules (technically this does perform an on-the-fly file transformation but I think this is as lightweight as it gets until import maps arrive).
That said, I really love the ideas behind deno. I was holding off because of WebCrypto but I see it's there now so I'll have to check again whether there's any remaining reason not to migrate.


feat(docker): build Docker images too

Description
This adds-in an updated Dockerfile and enables Docker image building & push to GitHub. :sparkles:
Type of change

[x] New feature :sparkles:

How Has This Been Tested?

[x] docker build -t kubeaudit .

Checklist:

[x] I have :tophat: my changes (A 🎩 specifically includes pulling down changes, setting them up, and manually testing the changed features and potential side effects to make sure nothing is broken)
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] The test coverage did not decrease
[x] I have signed the appropriate Contributor License Agreement

Perhaps nice to keep an eye on https://github.com/goreleaser/goreleaser/issues/1783 too


update filter positions to be percentage based instead of actual pixel values to avoid the need for updating filter positions upon each resize

complete with 62c39a6


Using string or map or JSON object as a value for a key.

Dear Team,
Is it possible to assign a string / map / JSON object to a key? The documentation and examples speak of uint64.
If not, is it possible to get an index to the key that uniquely points to the key as a kind of hash / pointer one could use as a key in a map to attach some more metadata to the key that just an integer value available by default?
Thanks for any hints...

Initially we planned to build this into the library, but it turns out all of our use cases so far have been satisfied with this simpler API.

If you're going to persist the vellum to disk anyway, you can persist your other data structures first, and then when you build the vellum, the uint64 value you assign to the keys is simply the file offset of your other more complex data-structure.  This is how bleve's file format zap does things.  We first persist the roaring bitmap data-structures to disk (things we want to be the value we can lookup in vellum)  Then when we insert into vellum, we associate the file offsets of those data-structures (uint64) with the keys.  Then later when we use vellum for a lookup, we take the uint64, and use it to find the roaring bitmaps elsewhere in the file.  This is very convenient if you plan to mmap the file anyway.

If you're not persisting this to disk, and working with it purely in memory, then you could simply keep another map along side the vellum instance, and you can make the key to your map be the uint64 you associate with the vellum key.  For example:

side := make(map[uint64]YourOwnStruct)
Then, you place your data into this side structure, and then insert the data into vellum, with the value being the key into your side structure.  Later if you look up something in vellum, it returns to you the key in your side structure when you can find the rest of the data.
Hope this helps.

I guess, I will go the second route… What I wanted to is to filter the results using the iterator based on conditions applied to the bitmask in the value field.
From: Marty Schoch<EMAIL_ADDRESS>Sent: wtorek, 21 lipca 2020 19:49
To: couchbase/vellum<EMAIL_ADDRESS>Cc: Pawel Urbanski<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [couchbase/vellum] Using string or map or JSON object as a value for a key. (#31)
Initially we planned to build this into the library, but it turns out all of our use cases so far have been satisfied with this simpler API.

If you're going to persist the vellum to disk anyway, you can persist your other data structures first, and then when you build the vellum, the uint64 value you assign to the keys is simply the file offset of your other more complex data-structure. This is how bleve's file format zap does things. We first persist the roaring bitmap data-structures to disk (things we want to be the value we can lookup in vellum) Then when we insert into vellum, we associate the file offsets of those data-structures (uint64) with the keys. Then later when we use vellum for a lookup, we take the uint64, and use it to find the roaring bitmaps elsewhere in the file. This is very convenient if you plan to mmap the file anyway.
If you're not persisting this to disk, and working with it purely in memory, then you could simply keep another map along side the vellum instance, and you can make the key to your map be the uint64 you associate with the vellum key. For example:

side := make(map[uint64]YourOwnStruct)
Then, you place your data into this side structure, and then insert the data into vellum, with the value being the key into your side structure. Later if you look up something in vellum, it returns to you the key in your side structure when you can find the rest of the data.
Hope this helps.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/couchbase/vellum/issues/31#issuecomment-662011003, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAWAEQCB2QSY7CFKWMAHGKLR4XIJNANCNFSM4PD2RPKA.


indentation's not perfect yet

for eg- ObjectExpression or StructDeclaration doesn't get linted for indentation:
struct Foo ({
    hello: 'world'
});

same for ArrayExpression that span over multiple lines:
uint[] ages = [
    19,
    20
];

same for CallExpression
foo ({
    'hello': 'world'
});

something like this shouldn't bypass the wrath of solium:
foo (
    "hello", "world", "mofo"
);

1 arg per line, if you're spreading your function call over multiple line. Need to code logic for this too
if (true)
    hello();

Also read https://github.com/duaraghav8/Solium/pull/122
without block statement, indentation raises error saying no indent before "hello()" which shouldn't happen
indentation is a bitch o.O

ensure that you check indentation thingy ONLY when start line & end line for param list is not the same

Worth changing the wording here to say "4 spaces" rather than 2, as this is what it's testing for.
https://github.com/duaraghav8/Solium/blob/master/config/solium.json#L99
As a nice-to-have would be to make this configurable as we here use 2-space indentation rather than 4, forcing us to switch off this rule altogether.

Special case of the missing block statement, abstract functions also result in false positive:
    function accessPolicy()
        public
        returns (IAccessPolicy);

another example
other.call('transferFrom', myAddress, this, bond);

results in WARNING: Function "undefined": in case of more than 3 arguments, drop each into its own line.
but if I change it to
other.call(
    'transferFrom',
    myAddress,
    this,
    bond
);

I get WARNING: Incorrect Indentation...
A bit of a catch-22 here.
also while
event Rejected(Claim claim, string reason);

is fine,
event Rejected(
    Claim claim,
    string reason
);

also trips an indentation error.

@elenadimitrova configuration is now possible in v1
@Recmo @davesag please install the latest version (1.0.3) and let me know if the issues still persist for you.

@elenadimitrova configuration is now possible in v1
@Recmo @davesag Your issues have been fixed in v1.0.4 (latest). Thanks for reporting

Thanks @duaraghav8 ! Confirming this tests ok with custom 2-space rule.


antiInvite doesn't trigger unless there is at least one invite link whitelisted

Expected behavior:
When filters.antiInvite is enabled and no invite links have been added to filters.inviteWhitelist, all invite links should be deleted.
Actual behavior:
When filters.antiInvite is enabled and no invite links have been added to filters.inviteWhitelist, the monitor triggers. After adding an invite link to filters.inviteWhitelist, the monitor triggers as normal.

moved if(!msg.guild.settings.filters.inviteWhitelist.length) from the start of the run method to the nested loop of the cycleWords method.


Composite resource not properly migrated to CR 1.16

I looked at the following resource.
https://dev-hs-6.cuahsi.org/resource/ba59b91b681141259bc621493960b6d9/
This includes a geographic feature and a bunch of single files.  The single files are each represented as single file aggregations.  They should have been represented just as files.  This suggests that the migration script to change the www representation of generic logical files to plain files has not been run on dev-hs-6.
If I download the bag for this resource I do not get the aggregation metadata files for the geographic feature aggregation within this resource.  This suggests that the setting to reset bags has not been done for dev-hs-6.
I tried to make a copy of this resource to see if aggregation metadata files would be correctly created for a copy that presumably did not already have a bag.

Immediately after the copy action the resource contents display properly (albeit showing each file as a single file aggregation).
Download content as a zipped bag results in a bag zipfile being downloaded.  However after this action the resource contents does not display any files

The bag zipfile appears to be correct with *meta.xml and *resmap.xml files present for each aggregation (spot checking contents I did not see anything wrong with these).
Debug reports inconsistencies between iRODS and Django - likely same cause as #2833.
There appears to be "remembering" of bag creation/downloading that results in odd behavior.  I added 'debug' at the end of the resource URL to check the point above.  Then I clicked "back" in the browser and was again prompted to save or open the bag zipfile I had already downloaded.

Note that fix_irods_file_paths must be run before migrating the composite resources; otherwise migrations will not be done on user resources.

remove_auto_generated_generic_metadata command developed to be run at deploy to resolve this.


Edit pkg insallation procedure

Some .pkg installations have the option to edit the installation procedure ("Ad Hoc"), the user should be able to perform this edits via homebrew-cask.
Esample: osxfuse during the installation allow to enable the MacFuse compatibility layer, but homebrew-cask deny this.

Hi!
Yes, there is already an issue for this (#2751). Everye agrees this s desirable functionality, but nobody has worked on it.  I'm closing this as a duplicate, but feel free to continue the discussion on the main issue.


How to allow multiple users type simultaneously on the editor ?

I'm currently working on a project where I'm allowing multiple users to share a codemirror editor. Since, I'm using socket.io for the real time changes, there's one problem I'm facing. The issue is that there's only one cursor to the editor, so only one user can type at a time. But I want that multiple users could type at different lines at the same time with their individual cursors. What changes should I make ? Help me with this.

This is called collaborative editing, and isn't something CodeMirror 5 supports by itself, though there are external components that implement this.

Can you help with y-codemirror integration ? Because I'm facing a lot of issues in my project. My project is a MEAN application which already uses socket.io. But y-codemirror has its own socket.

Can you help me with y-codemirror integration ?

No, sorry. I'm providing this library, but no free integration support.


Client public path

Adds a CLIENT_PUBLIC_PATH env var so that the dev environment can work on a non-http://localhost:3000 url.
E.g. I have a local setup somewhat similar to Laravel Valet https://laravel.com/docs/5.6/valet. We deal with many clients, so it's nice to be able to go to http://clientA.dev and http://clientB.dev instead of remembering which localhost port each client is on, or bringing one down before switching to the next.

In case someone else finds this thread & you need this in Razzle <= 2.4.0, you can use the following in your razzle.config.js as a workaround.
module.exports = {
  modify: (config, { target, dev }, webpack) => {
    // note the use RAZZLE_ prefix
    if (dev && process.env.RAZZLE_CLIENT_PUBLIC_PATH) {
      config.output.publicPath = process.env.RAZZLE_CLIENT_PUBLIC_PATH;
    }
    return config;
  }
};

When you upgrade razzle, nothing will break, and you can migrate from RAZZLE_CLIENT_PUBLIC_PATH to CLIENT_PUBLIC_PATH at your leisure.


test(e2e,playwright): progress-bar.tsx

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Related to https://github.com/freeCodeCamp/freeCodeCamp/issues/51705

i made  a fresh  pr https://github.com/freeCodeCamp/freeCodeCamp/pull/51789 .  prev on  was giving some error in node lint . i did all the changes it requested

camperbot cant code

Can u merge this .


Frigid Highlands waypoint unable to be used/not found

When running Eldritch it thinks I am missing the Frigid Highlands waypoint, so it teleports or walks to Eldritch instead of using the waypoint. When it gets there it tries to trigger the waypoint so it definitely thinks I don't have it.
Anyone else have this issue? All other runs I've tried work fine, both with sorceress or hammerdin without teleport.
Version
I'm running the latest version [v0.3.2] and have not compiled it from source.
My best guess:
Seems odd that it's just this Waypoint, so maybe the coordinates of that first row of waypoints isn't quite right?
Looking at my logs below, the color matching operating score of 76.42276422764228 is also what shows up when leveling, i.e. time to find Baal for the first time, it doesn't have the waypoint, and returns that number.
So it seems like it is correctly matching a waypoint, but one that is blank. So it's possible matching the wrong waypoint or something?
Happy to be pointed in the right direction of the code to try and test myself.
Log Extract
From back in December but issue still exists on a newer install.
2023-12-14T22:49:02.051+1300    DEBUG   action/stash.go:28      Checking for items to stash...
2023-12-14T22:49:02.052+1300    DEBUG   action/stash.go:30      No items to stash...
2023-12-14T22:49:08.345+1300    DEBUG   ui/template_finder.go:130       Color matching operation        {"score": 73.98373983739837}
2023-12-14T22:49:08.346+1300    DEBUG   ui/template_finder.go:130       Color matching operation        {"score": 76.42276422764228}
2023-12-14T22:49:08.346+1300    INFO    action/waypoint.go:99   Traversing areas to reach destination   {"areas": [109,110,111]}

First score is 73.98 and the threshold is set at 75, it might be the reason. I need to update the WP detector to read the available WP from memory instead of using UI matching, I hope I have some time within the next weeks to do it.

@Millionaar give it a try to the latest release

Thank you all fixed. Only just had the chance to test but appreciate the quick fix!


Remove QUnit

Fixes https://github.com/cfpb/capital-framework/issues/656
Additions

Adds initial Expandables jest test spec.

Removals

Removes QUnit.
Removes unnused testID variable from Table-spec.

Testing

gulp test should pass and have >90% coverage for cf-expandables and cf-tables.

Note that the QUnit tests acted as acceptance tests (e.g. they had HTML mocks that included the CSS and therefore included the animations, which jest unit tests do not included), therefore the tests have been reduced in number. We should add acceptance tests for the CF docs to cover this gap.


xReg: How do people know what content-type the messages will be?

We have a format property that will tell people that the message is a CloudEvent, but nothing in the Endpoint metadata to indicate whether it'll be xml, json, avro, ... or what the possible formats might be so people could specify that choice on the Subscribe() operation (if it supported it).
We should consider adding something to indicate the content-type(s) of the messages.
Moved from: https://github.com/cloudevents/spec/issues/1162

Does the "contenttype" attribute convey this info?

Proposal:

add "data" prefix to:
"schemaformat": "STRING", ?
"schema": ANY, ?
"schemauri": "URI", ?
add "datacontenttype" as a sibling to those 3 - RECOMMENDED
add text to say that any "envelope" metadata that specifies the data content-type MUST be compatible this message-level content-type value (if both are present)


Study to compare t-Digest and REQ sketch

Compare the performance of t-Digest with the closest competitor in the library, REQ sketch.
REQ sketch is the closest competitor because it prioritizes high rank accuracy (HRA mode) or low rank accuracy (LRA mode), unlike other quantile sketches (KLL, classic) with the same rank error for any rank.
There are a few obvious differences:

REQ sketch can work with any data type with a comparator, t-Digest is limited to numeric data (floating-point types)
REQ sketch retains and returns values observed in the input only - no notion of distance (only less than comparison), no interpolation. t-Digest is based on computing means and does interpolation.
t-Digest prioritizes both high rank and low rank accuracy at the same time with the default scaling function. Perhaps this can be changed with different scaling functions.

Here is what I have so far. Surprisingly REQ sketch with k=10 and k=12 behaves very similarly

We compared t-digest and ReqSketch in a paper (at KDD'21) with Graham and people from Splunk. I think t-digest was not updated much since then, so I hope the points below are still true.
Here's an upshot based on the paper (see Section 6 in the paper):

We were able to construct inputs for t-digest that make its error arbitrarily bad, even though these inputs are highly unlikely to be encountered in practice (N.B. we needed to use numbers from astronomically large to infinitesimally small). On the other hand, we were able to come up with distributions such that on i.i.d. samples from these distributions, t-digest has worse error than ReqSketch while using similar space (again, these distributions may seem artificial due to requiring large scale). See plots in Section 5 in the paper. Thus, t-digest is not robust to adversarially inputs.
Of course, on more realistic distributions, t-digest works much better in terms of accuracy.
t-digest has worse update time; see Table 1. This is because sampling used by KLL and ReqSketch does not require so many expensive operations as maintaining centroids in the t-digest.

Here is what I have so far. Surprisingly REQ sketch with k=10 and k=12 behaves very similarly

I'd say that values of $k \le 12$ are somewhat small, but of course, such small values are needed to have somewhat comparable space for t-digest (at least for short streams). Actually, in the KDD paper we used k = 4 to achieve similar space for a stream of length $2^{20}$.
The choice of the uniform distribution may not be the best for a comparison. I'd suggest to also include the log uniform distribution (uniform on the log scale) that we used in the paper. Or a normal distribution.

@PavelVesely although slightly off topic, do you understand why REQ k=12 and k=10 end up retaining about the same number of items and having about the same rank error? Do you think it might be a bug in the implementation?

@PavelVesely although slightly off topic, do you understand why REQ k=12 and k=10 end up retaining about the same number of items and having about the same rank error? Do you think it might be a bug in the implementation?

My guess is that for such a small k, rounding would yield sketches of pretty much the same size. Specifically, since k is the initial section size and section size decreases by a factor of $\sqrt{2}$, the next section size (after the first doubling of the number of sections) is the same for k=10 and k=12 --- the nearest even number to $10/\sqrt{2}$ is 8, so it's the same as for $12/\sqrt{2}$
Apologies for the belated answer! (You can let me know by email if you'd like me to look at something, but I'm not watching the dev mailing list closely.)

@AlexanderSaydakov The plots are nice, albeit it's not surprising that t-digest is much better on uniform distribution. Can you try another distribution which is more skewed?

sorry for the delay. I plan to do this eventually, but was busy with more urgent tasks.

I measured rank error with input from exponential distribution (lambda=1.5). I don't see drastic difference from the uniform distribution

Thanks for the update! In the KDD paper, we tried the log-uniform distribution, that is, choosing a random $R\in (0,1)$ and outputting item $10^{R*E}$, where $E$ the maximum exponent. Generally, the larger $E$, the worse for t-digest.
(We actually tried some variations of the log-uniform distribution, like additionally choosing a random sign, or squaring $R$ in the exponent, that is, $10^{R^2*E}$, which made the error of t-digest even worse.)

@AlexanderSaydakov @leerho Btw, are there any differences between your implementation of t-digest and the "official" implementation? I mean primarily algorithmic differences that would influence the accuracy on some datasets.

We implemented merge slightly differently since the reference implementation modifies the input sketches. My testing shows that our version does a bit better in terms of accuracy after merge. Other than that I believe our implementation is equivalent to the reference implementation.


/setup/connect_wifi looks like POST, not GET as documented.

I assume it takes a POST request of an SSID to connect to, or something similar.

Closing this for now


Update PythonExecutionService to support "conda run".

This will involve the following:

change PythonExecutionService.pythonPath (a string) to PythonExecutionService.pyArgv (an array of strings)

https://github.com/microsoft/vscode-python/blob/master/src/client/common/process/pythonProcess.ts
[x] rename
[x] updatePythonExecutionService accordingly

update PythonExecutionService.create() to pass an array of strings to PythonExecutionService()

https://github.com/microsoft/vscode-python/blob/master/src/client/common/process/pythonExecutionFactory.ts
[ ] determine if conda or not (and set pyArgv accordingly)
[x] update the call sites

update PythonExecutionService.createActivatedEnvironment() to pass an array of strings to PythonExecutionService()

https://github.com/microsoft/vscode-python/blob/master/src/client/common/process/pythonExecutionFactory.ts
[ ] determine if conda or not (and set pyArgv accordingly)
[x] update the call sites

verify that the usage in the various places works properly for conda and non-conda:

[ ] formatting

src/client/formatters/baseFormatter.ts (via PythonToolExecutionService)

[ ] linting

src/client/linters/errorHandlers/notInstalled.ts
src/client/linters/baseLinter.ts (via PythonToolExecutionService)

[ ] testing

src/client/testing/common/services/discovery.ts
src/client/testing/common/runner.ts
src/client/testing/common/runner.ts (via PythonToolExecutionService)

[ ] installers

src/client/common/installer/pipInstaller.ts
src/client/common/installer/productInstaller.ts

[ ] debugger

src/client/debugger/extension/adapter/factory.ts

[ ] interpreter discovery

src/client/interpreter/locators/services/workspaceVirtualEnvWatcherService.ts
src/client/interpreter/configuration/pythonPathUpdaterService.ts
src/client/interpreter/helpers.ts
src/client/interpreter/interpreterService.ts
src/client/interpreter/locators/services/windowsStoreInterpreter.ts

[ ] import sorting

src/client/providers/importSortProvider.ts

[ ] jedi

src/client/providers/jediProxy.ts

[ ] refactoring

src/client/refactor/proxy.ts

Make sure conda run works with both named environment and non-named environment (where we have to use the path)

To validate:

workspace with a named conda environment (conda create --name yourenv or conda create -n yourenv)

[ ] extension loads
[ ] extension selects the workspace correctly
[ ] formatting should be executed using conda run
[ ] linting should be executed using conda run
[ ] run in terminal should be executed using conda run
[ ] test discovery using pytest should be executed using conda run

workspace with a prefixed conda environment (conda create --prefix path/to/env)

[ ] extension loads
[ ] extension selects the workspace correctly
[ ] formatting should be executed using conda run
[ ] linting should be executed using conda run
[ ] run in terminal should be executed using conda run
[ ] test discovery using pytest should be executed using conda run

validated

Found a unrelated issue while validating it. https://github.com/microsoft/vscode-python/issues/8783


Recognition of geodeticDatum Field by IPT

Hello, recently we have published biodiversity data in GBIF using the georeferencing process recommended by the publication (georeferencing best practices), using the georeferencing Calculator tool. In addition to the field "coordinateUncertaintyInMeters", this tool provides other data such as the datum. For our publication, we used the datum "WGS84" and it was published in our database as it is delivered by the Calculator, "(WGS84) World Geodetic System 1984". However, when analyzing our data later in GBIF under "Issues and Flags", we found that this datum is not recognized by the IPT.
While the solution is to change the datum to "WGS84" or "EPSG:4326", would it be possible to add the value "(WGS84) World Geodetic System 1984" to the allowed dictionary in IPT? The georeferencing Calculator is recognized as one of the official tools that add quality to databases related to the georeferencing process. Additionally, we believe that it would be useful to disseminate this information to the nodes, as we stumbled upon this issue while generating a quality report for our data published in GBIF.
Best regards,
Marcelo Oyaneder Labarca -<EMAIL_ADDRESS>Paulette Naulin Gysling -<EMAIL_ADDRESS>

@marcelooyaneder Thank you for contacting us
@fmendezh @muttcg It's pipelines scope I guess

parsers-0.61 now includes the required values.  I don't know if you want to update dev or master.
These two issues are also handled, and can be closed once this is deployed: https://github.com/gbif/portal-feedback/issues/4610, https://github.com/gbif/portal-feedback/issues/4388


Transaction collision caused NPE when creating service

10:05:47.530
FileObject 'html/img/osa_white_nl_250.jpg', Basepath: '/base/data/home/apps/e~rogerthat-server/21.402659118505646944/shop' (/base/data/home/apps/e~rogerthat-server/21.402659118505646944/lib/xhtml2pdf/util.py:517)

10:05:47.530
URLParts: ParseResult(scheme='', netloc='', path='/base/data/home/apps/e~rogerthat-server/21.402659118505646944/shop', params='', query='', fragment='') (/base/data/home/apps/e~rogerthat-server/21.402659118505646944/lib/xhtml2pdf/util.py:532)

10:05:50.020
Creating recommendation QR for<EMAIL_ADDRESS>(/base/data/home/apps/e~rogerthat-server/21.402659118505646944/rogerthat/bizz/service/__init__.py:611)

10:05:50.190
New avatar hash: 3C607337037C922671F00F46743FBF2F45320AE972064ECB3715FF7AE59264FF (/base/data/home/apps/e~rogerthat-server/21.402659118505646944/rogerthat/bizz/profile.py:913)

10:05:50.226
Coupling new user<EMAIL_ADDRESS>to<EMAIL_ADDRESS>(/base/data/home/apps/e~rogerthat-server/21.402659118505646944/rogerthat/bizz/service/__init__.py:2706)

10:05:50.251
New avatar hash: 3C607337037C922671F00F46743FBF2F45320AE972064ECB3715FF7AE59264FF (/base/data/home/apps/e~rogerthat-server/21.402659118505646944/rogerthat/bizz/profile.py:913)

10:05:50.282
Profile<EMAIL_ADDRESS>removed from cache. (/base/data/home/apps/e~rogerthat-server/21.402659118505646944/rogerthat/models/__init__.py:551)

10:05:50.359
Profile<EMAIL_ADDRESS>removed from cache. (/base/data/home/apps/e~rogerthat-server/21.402659118505646944/rogerthat/models/__init__.py:551)

10:05:50.361
Svc Identity<EMAIL_ADDRESS>removed from cache. (/base/data/home/apps/e~rogerthat-server/21.402659118505646944/rogerthat/models/__init__.py:1084)

10:05:50.363
Svc Identity<EMAIL_ADDRESS>removed from cache. (/base/data/home/apps/e~rogerthat-server/21.402659118505646944/rogerthat/models/__init__.py:1087)

10:05:51.102
Transaction collision. Retrying...  (/base/data/home/runtimes/python27/python27_lib/versions/1/google/appengine/api/datastore.py:2688)

10:05:51.102
Transaction collision, retrying 1 .... (/base/data/home/apps/e~rogerthat-server/21.402659118505646944/add_1_monkey_patches.py:171)

10:05:51.247
Unhandled exception: 'NoneType' object has no attribute 'modules' (/base/data/home/apps/e~rogerthat-server/21.402659118505646944/solutions/common/bizz/service.py:125)
Traceback (most recent call last):
  File "/base/data/home/apps/e~rogerthat-server/21.402659118505646944/solutions/common/bizz/service.py", line 121, in put_customer_service
    run_in_xg_transaction(trans)
  File "/base/data/home/apps/e~rogerthat-server/21.402659118505646944/rogerthat/utils/transactions.py", line 103, in run_in_xg_transaction
    return db.run_in_transaction_options(xg_on, function, *args, **kwargs)
  File "/base/data/home/apps/e~rogerthat-server/21.402659118505646944/add_1_monkey_patches.py", line 184, in wrapped
    r = run(transaction_guid)
  File "/base/data/home/apps/e~rogerthat-server/21.402659118505646944/add_1_monkey_patches.py", line 166, in run
    return _orig_run_in_transaction_options(options, *args, **kwargs)
  File "/base/data/home/runtimes/python27/python27_lib/versions/1/google/appengine/api/datastore.py", line 2647, in RunInTransactionOptions
    ok, result = _DoOneTry(function, args, kwargs)
  File "/base/data/home/runtimes/python27/python27_lib/versions/1/google/appengine/api/datastore.py", line 2667, in _DoOneTry
    result = function(*args, **kwargs)
  File "/base/data/home/apps/e~rogerthat-server/21.402659118505646944/solutions/common/bizz/service.py", line 118, in trans
    skip_email_check=skip_email_check)
  File "/base/data/home/apps/e~rogerthat-server/21.402659118505646944/mcfw/rpc.py", line 164, in typechecked_return
    result = f(*args, **kwargs)
  File "/base/data/home/apps/e~rogerthat-server/21.402659118505646944/mcfw/rpc.py", line 142, in typechecked_f
    return f(**kwargs)
  File "/base/data/home/apps/e~rogerthat-server/21.402659118505646944/shop/bizz.py", line 719, in put_service
    for m in sln_settings.modules:
AttributeError: 'NoneType' object has no attribute 'modules'

10:05:51.260
Could not save service service information (/base/data/home/apps/e~rogerthat-server/21.402659118505646944/add_1_monkey_patches.py:111)
Traceback (most recent call last):
  File "/base/data/home/apps/e~rogerthat-server/21.402659118505646944/solutions/common/restapi/services.py", line 245, in rest_put_service
    skip_email_check=True, rollback=is_new_service)
  File "/base/data/home/apps/e~rogerthat-server/21.402659118505646944/solutions/common/bizz/service.py", line 126, in put_customer_service
    raise e
AttributeError: 'NoneType' object has no attribute 'modules'

10:05:51.268
Failed to save new service service information, changes would be reverted... (/base/data/home/apps/e~rogerthat-server/21.402659118505646944/solutions/common/restapi/services.py:255)

10:05:51.269
[XX-OFFLOADv1] {"function":"/common/services/put","request_data":{"website":"www.***.be","city":"***","force":false,"name":"***","language":"nl","broadcast_types":["Evenementen","Infosessies","Kortingen","Nieuws"],"address1":"*** 23","address2":"","modules":["appointment","order","bulk_invite","static_content","ask_question","broadcast"],"telephone":"***","user_email":"info@***.be","organization_type":2,"facebook_page":"https://www.facebook.com/***/","vat":"***","zip_code":"***"},"success":true,"timestamp":1500278751,"response_data":{"errormsg":"Kon de dienst niet aanmaken. Probeer later opnieuw of contacteer onze klantendienst indien het probleem zich blijft voordoen.","warningmsg":null,"success":false},"type":"web","user":"2e257bc785b28ecdac5dc5a73d3923aa"} (/base/data/home/apps/e~rogerthat-server/21.402659118505646944/rogerthat/utils/__init__.py:396)

This error occurs when the user double clicks save...


TypeError: Cannot read property 'query' of undefined

error text
/node_www/crawler.x-sells.com/node_modules/mysql/lib/protocol/Parser.js:82
        throw err;
              ^
TypeError: Cannot read property 'query' of undefined
    at /node_www/crawler.x-sells.com/autoInit.js:53:19
    at Handshake.onConnect (/node_www/crawler.x-sells.com/node_modules/mysql/lib/Pool.js:54:9)
    at Handshake.Sequence.end (/node_www/crawler.x-sells.com/node_modules/mysql/lib/protocol/sequences/Sequence.js:96:24)
    at Handshake.ErrorPacket (/node_www/crawler.x-sells.com/node_modules/mysql/lib/protocol/sequences/Handshake.js:103:8)
    at Protocol._parsePacket (/node_www/crawler.x-sells.com/node_modules/mysql/lib/protocol/Protocol.js:271:23)
    at Parser.write (/node_www/crawler.x-sells.com/node_modules/mysql/lib/protocol/Parser.js:77:12)
    at Protocol.write (/node_www/crawler.x-sells.com/node_modules/mysql/lib/protocol/Protocol.js:39:16)
    at Socket.<anonymous> (/node_www/crawler.x-sells.com/node_modules/mysql/lib/Connection.js:82:28)
    at Socket.emit (events.js:107:17)
    at readableAddChunk (_stream_readable.js:163:16)
    at Socket.Readable.push (_stream_readable.js:126:10)
    at TCP.onread (net.js:529:20)

windows on everything works fine, but when you transfer linux appears this error
tell me how it is solved

It really depends on what your code in the /node_www/crawler.x-sells.com/autoInit.js file is.

Most likely you have code like
pool.getConnection(function (err, conn) {
  conn.query(/* ... */);
})

which is not correct, because you never checked and acted on err.

@dougwilson No, the connection I have so
mysql.createPool({
connectionLimit : $config.get('db:connectionLimit'),
host      : $config.get('db:host'),
user      : $config.get('db:user'),
database  : $config.get('db:base'),
password  : $config.get('db:password')
})
using so
db.getConnection(function (err, connection) {
connection.query(/* ... */, [], callback);
connection.release();
});
but the problem is this only in Linux, and it is not always

Thanks :) Your second code block is incorrect. It should be as follows:
db.getConnection(function (err, connection) {
      if (err) throw err; // You *MUST* handle err and not continue execution if
                          // there is an error. this is a standard part of Node.js
            connection.query(/* ... */, [], callback);
            connection.release();
        });


Verify/cleanup the monkey patch in build/1_8_7_hacks.rb

Is it still needed with ruby 2.0 and beyond?
https://github.com/ManageIQ/manageiq/blob/master/build/1_8_7_hacks.rb#L3

This was deleted in the split repo manageiq-appliance-build.


If dependent testcase is not invoked then the dependency library just shows the message but don't blocked it.

Let say we have 2 testcases
Testcase One
   [Tags]    t1    test
   Fail       this is testcase one

Testcase Two
   [Tags]    t2   test
   Depends On Test     Testcase One
   Log       this is testcase two

If i run robot -i test and test1 fails then the message is shown and test2 is skipped
If i run robot -i t2 then in this case the message is shown but the test2 continues to run.
Message shown is

[ WARN ] Dependency not met: test case 'Testcase One' not found.

Expectation is if dependent testcases are failed or not found then no testcases should run further which are dependent on it.

The behavior you want is what it used to do before v4. I guess it's time to rethink #6 and #7 and make the behavior choosable at run time somehow.
I'm not sure how soon I'll get to it - in the meantime, you can install v3.0.1 instead of latest.

I personally like this current v4 implementation. If Depends On Test Keyword would cause Fail every time with the command robot -i t2, you could not even try to run the test to see where the execution crashes, i.e. why t2 depends on t1.
If the dependency is real, when t2 is executed alone, it will fail somewhere anyway. In that example, t2 doesn't really depend on t1, so of course it goes through with that warning only.
I think the "problem" is in the robot -i t2 command, because what would be the point of running test t2 alone if it depends on test t1? It would be convenient if the execution of the t2 test could select the entire dependency chain, i.e. in this case run t1 first and then t2.
I am working on such a feature to be given as a robot --prerunmodifier option. What do you @mentalisttraceur think, would this be a good addition to this library?


Imgur direct links result in duplicates

[Jan 24 20:37:40] Saved URL https://i.imgur.com/O92BEOB.png to D:\kpics\Tunkkausta\tunkkaus\O92BEOB.png from #general/SnekCord

https://imgur.com/O92BEOB

[Jan 24 20:37:41] Saved URL https://imgur.com/download/O92BEOB to D:\kpics\Tunkkausta\tunkkaus\O92BEOB - Imgur.png from #general/SnekCord

This link gets posted to channel once (https://i.imgur.com/O92BEOB.png) and it result's in two downloads and above output in log.
If the link is gallery link (https://imgur.com/O92BEOB) no duplicate pictures are saved.

fixed in 96df9afbfbf4e0b3014c03b280e24dcb4cd9f506


New O2 infrastructure for launching Jupyter

There seems to have been an update to the wiki page for Jupyter on O2 dated Jul 20, 2020.
Based on what I remember of the old instructions, the changes include:

--tunnel flag in the srun command to complete the tunnel (for x11 forwarding, presumably)
a second terminal ssh'ing into the compute node from (1) is no longer used

Looks like a useful addition! That means one less 2FA prompt is needed if you are remote.
In testing, the old way (with a second ssh) still works, but I will add the option to use that flag and not run a second ssh, and make it the default in the config.

coolio
Thanks!

I've addressed these changes in Jupyter-O2 version 1.0.2.
The lack of a second ssh should make 2FA a bit less annoying during work from home.

great! thank you!


[GHSA-p48j-9rw2-x9q6] SQL Injection vulnerability in viaviwebtech Android EBook...

Updates

Affected products
Description
References
Source code location
Summary

Comments
Please remove this advisory because this is effected on our business.

Hey there @nkuldip 👋
This advisory is in our unreviewed set so, you'll need to reach out to the assigning CNA to get it revoked.

👋 This pull request has been marked as stale because it has been open with no activity.  If you do nothing this pull request will be closed eventually by the stale bot. Please see CONTRIBUTING.md for more policy details.


Add Company button not hidden when adding a new company

Fixed, issue was the submit bug button was named AddCompany


feat: tags for blogs

Issue fixed: #56
Features added:

tags field for Post model (multiple tags can be entered separated by comma)
tags display in Post detail.html

Screenshots:

tags field input in django-admin

tags view in detail.html

Issue fixed: #56
Features added:

tags field for Post model (multiple tags can be entered separated by comma)
tags display in Post detail.html

Screenshots:

tags field input in django-admin

tags view in detail.html

Hey @SubhradeepSS , try to make something like this.

@diyajaiswal11 is this fine?


add OSS manifest staging dir to make target

This change adds a step to the building of config sync manifests which
produces the subset of manifests for multirepo/oss from the already
generated ACM manifests.

/assign @janetkuo @mortent
/cc @nan-yu


Nuget Packages

For scaffolding the controller, we also need the Nuget package: Microsoft.EntityFrameworkCore.Design.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 583ae3e7-5915-f22b-e54c-6c100cf2a7da
Version Independent ID: 95f2549e-29f9-e31a-b4d0-432b971643ff
Content: Tutorial: Create a web API with ASP.NET Core
Content Source: aspnetcore/tutorials/first-web-api.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

What version of .NET?

5.0
From: Rick Anderson @.***
Sent: Wednesday, September 29, 2021 3:25 PM
To: dotnet/AspNetCore.Docs
Cc: xenophilios; Author
Subject: Re: [dotnet/AspNetCore.Docs] Nuget Packages (#23412)
What version of .NET?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/dotnet/AspNetCore.Docs/issues/23412#issuecomment-930516507 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AL6S5M5SSSOARCB3HM5OEDDUENYZ3ANCNFSM5FAMJYWA .
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675  or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub . Image removed by sender.

Thank you for contacting us. Due to a lack of activity on this discussion issue we're closing it in an effort to keep our backlog manageable. If you believe there is a concern which hasn't been addressed, please file a new issue.


fix ave profiles + update tests

fix subjectClassification
remove string type from objectAssay
update tests
rerun make all

@afrubin I'm unable to request your review but here are my suggested changes. Let me know if you have any questions


Claims data visit level attention

Hi,
Thank you for this implementation; learned a lot on how to apply DL to claims data!  I was curious as to how you one would aggregate claims data to the visit level. Service date? Given that some facility claims for inpatient hospital stays may span multiple days, curious if there is some processing necessary to get an identifier for visit, which there probably is.
If it's possible, it would be great if there was a sample claims demo dataset, in addition to the MIMIC-III dataset demo.

Good question @DanielYWu.  We have a way of handling this but I need to double check.  I want to say that you can use the discharge date for inpatient claims, but of course it depends on what you're trying to do.  If you would like to match codes from an inpatient claim to a date, typically the best codes to use are the discharge codes, as the clinicians have had time to properly assess the cause of the stay.  By that logic, using discharge date seems appropriate.

For now, no additional demo datasets will be added to the repo.  We are discussing doing more work with this codebase in the future and may want to revisit the idea.


Target Ruby 2.3

(I know that "unsopported" doesn't mean "don't work")
Since support for Ruby 2.1 and 2.2 were dropped and there is a 2.0 milestone, this PR contains a proposal to set the minimum required Ruby version to 2.3
I've removed the lib/extensions folder, because the minimum required version of Ruby already support the class methods defined there
I've updated RuboCop and fixed all the new issues
Ruby 2.3 added support for frozen string literals and RuboCop demands # frozen_string_literal: true on top of each ruby file, I've fixed the fakers that didn't work with frozen string literals.

Awesome, thanks!


Error in get_inception_features

Hi, I had a few issues to get it to run in my computer specially with the encode decode functions with the shape, now I am getting the following error:
Traceback (most recent call last):
File "/Users/pepe_garcia/opt/anaconda3/lib/python3.7/site-packages/imsearch/feature_extractor/extractor.py", line 93, in
main()
File "/Users/pepe_garcia/opt/anaconda3/lib/python3.7/site-packages/imsearch/feature_extractor/extractor.py", line 65, in main
all_features['secondary'] = get_inception_features(img.copy())
File "/Users/pepe_garcia/opt/anaconda3/lib/python3.7/site-packages/imsearch/feature_extractor/extractor.py", line 38, in get_inception_features
x = inception_model.predict(x)
File "/Users/pepe_garcia/opt/anaconda3/lib/python3.7/site-packages/keras/engine/training.py", line 1441, in predict
x, _, _ = self._standardize_user_data(x)
File "/Users/pepe_garcia/opt/anaconda3/lib/python3.7/site-packages/keras/engine/training.py", line 579, in _standardize_user_data
exception_prefix='input')
File "/Users/pepe_garcia/opt/anaconda3/lib/python3.7/site-packages/keras/engine/training_utils.py", line 145, in standardize_input_data
str(data_shape))
ValueError: Error when checking input: expected input_1 to have shape (None, None, 3) but got array with shape (974, 1390, 4)
What could be the issue ?

Can you give me some more details about what are you trying to do? Maybe some code snippet or other details about the system.

Hi, thanks for the reply, yes I am trying to run it locally
I get it to run but then when I add a PNG image with:
Add single image to the index
index.addImage(all_images[0])
I get an error in this function saying that it can not reshape it:
def decode_image(_q, dtype=np.uint8):
if sys.version_info.major == 3:
img = bytes(_q['image'], encoding="utf-8")
img = np.frombuffer(base64.decodestring(img), dtype=dtype)
img = img.reshape(_q['shape'])
return img

I was able to get it working by forcing the dtype to np.float32
def decode_image(_q):
if sys.version_info.major == 3:
img = bytes(_q['image'], encoding="utf-8")
img = np.frombuffer(base64.decodebytes(img), dtype=np.float32)
img = img.reshape(_q['shape'])
print('img decode', img)
return img
But then I run into the error above.
I think I might have an error while encoding and decoding the image and then reshaping it
The last error happens in this function:
def get_inception_features(x):
x = preprocess_input(x)
x = inception_model.predict(np.expand_dims(x, axis=0))
return base64.b64encode(x[0]).decode("utf-8")

I have pushed the changes that fixes this issue. Thanks for pointing this out.


backend: save images as PNG instead of JPEG

Why changing to a png?

PNG is lossless, JPEG is lossy

The jpeg artifacts are quite visible and make further processing (eg. upscaling) harder.

Thanks for opening this PR! I've added the option to specify the output image format in https://github.com/saharmor/dalle-playground/commit/cad1753193ed15c06c6dddc076d0f5d4a04653a7


Fix selection/unselection when using badges

When using badges, an extra FrameLayout is inserted as the container
for each tab. This container inherits the tag of the pre-badge tab view,
but the tag is not reset on the pre-badge tab view. This causes selection
and unselection of tabs to fail because findViewWithTag will erroneously
find the now obsolete tab views when searching for active tabs, resulting
in multiple tabs being visually selected when changing tabs.
By clearing the tag of the old (now inner) view when putting it in the new
tab container, we can ensure that findViewWithTag will only find relevant
views.
This fixes #266.

Hi,
@roughike : since the commit 6f6a8b32598707aa08c5c29d456548d569cf329b the methods no longer exists. Does it mean that the functionnality has been removed ?
Regards


fix(v2): allow negative sidebar positions

Motivation
In some cases, negative sidebar positions can be useful for reversing the sorting order with minimal maintenance overhead. For example, a docs folder with changelogs for historical versions should be sorted in reverse chronological order. This is easy to do for semantic version numbers by converting them into a negative numerical representation, e.g. 11.5.1 -> -110501.
The alternative is to make the first version start with a large position number (e.g. 9999) and decrement it for each version. However, this requires referring to older versions to get the current sequence number, thus increasing maintenance overhead. It also makes the number less intuitive and more prone to error.
Negative sidebar positions work great for this purpose, so make the front matter validator allow them again as #4796 broke this use case.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Negative sidebar positions worked on 2.0.0-beta.0, so I simply reverted #4796 by removing .min(0). I also added tests that follow the existing format in order to prevent regressions.

Makes sense thanks
Thought about it and wasn't sure people would use this 😅
Also note we don't currently have support for extracting negative and float position from the filename (ie docs-1.5-Guide.md), not sure it's worth adding that until someone come with a need


[Breaking] Modify return type of created_at/finished_at to datetime

Metaflow Client currently returns a string for created_at and finished_at properties. This PR changes the response type to a more appropriate Datetime object.

I will merge this PR right when we are merging #580


DiscordPermissionHelper does not follow permission hierarchy correctly

It's close, but not quite ;).
See https://discordapp.com/developers/docs/topics/permissions#permission-hierarchy.

Turns out it wasn't really broken at all. Regardless, commit d09638754e409251ea9b8c645338e4e419b921fc changes the existing logic to match the official documentation much closer to ensure there's no edge cases left out.


Change the URL to get the playlist tracks from a user

The URI used in getUserPlaylistTracks is no more available. Now we don't need to give the user id, it is remplaced by "spotify".

Error, in fact the case i tested is with user_id = spotify, it was a particular case. So we have to give the user_id which is the owner of the playlist.


145816283 application interface

What does this PR do?
Completes task for building user interface
Description of Task to be completed?

Build interface for login/registration/logout
User been able to add documents
Application dashboard for managing documents
User page

How should this be manually tested?
N/A
Any background context you want to provide?
This task was completed using React, Material UI, and SASS.
What are the relevant pivotal tracker stories?
Build user interface (#145816283)
Screenshots (if appropriate)
Homepage

Dashboard

Registration page

User profile page

User update screen

View/search users screen

Sidemenu / drawer Homepage

Questions:
N/A

Coverage increased (+0.007%) to 90.809% when pulling 2103f54b2f066facb24fc61ce29aced4754302e2 on feature/145816283/application-interface into 269e29fb9b2c0f42815a91dcbeeae8a61228269f on develop.

Coverage increased (+0.007%) to 90.809% when pulling 3d0346a93fd8e90fb5bb623b8f5ba39c294dd8c6 on feature/145816283/application-interface into 269e29fb9b2c0f42815a91dcbeeae8a61228269f on develop.

Well done Joshua. It is obvious the amount of work you put in in such a short time. He is a summary of the review I made.

Use stateless components when there is not need for state or life-cycle methods
You may extract your styles into external files. Looks like you have that consistently in almost every component
You can decongest most of your render methods. One way is to use renderFunctions that return the expected jsx
Handle your errors or remove the catch blocks in your actions
Fix your hound-ci errors
Try to implement the suggestions all across the code since almost the same things were repeated. Enjoy!

Coverage decreased (-0.07%) to 90.73% when pulling 1ca9070eb29a3906ab0bf9cd12cd212c2249ab3e on feature/145816283/application-interface into 269e29fb9b2c0f42815a91dcbeeae8a61228269f on develop.

Coverage decreased (-0.07%) to 90.73% when pulling 86305d523613364412cbd0f8134656cbc4faae59 on feature/145816283/application-interface into 269e29fb9b2c0f42815a91dcbeeae8a61228269f on develop.

Coverage decreased (-0.07%) to 90.73% when pulling 3a11b6a10f85d76b64deacd9f3c999db9dc2d132 on feature/145816283/application-interface into 269e29fb9b2c0f42815a91dcbeeae8a61228269f on develop.

Coverage decreased (-0.08%) to 90.723% when pulling 77d5a2a73bdea9a975c53415a5c0ab3b50cca4cd on feature/145816283/application-interface into 269e29fb9b2c0f42815a91dcbeeae8a61228269f on develop.

Coverage decreased (-0.08%) to 90.723% when pulling 4b1a256becb0440c1fa32c457e49900db4fd4542 on feature/145816283/application-interface into 269e29fb9b2c0f42815a91dcbeeae8a61228269f on develop.

Coverage increased (+0.001%) to 90.803% when pulling d64e5d00da233fe0e1bdf0d920487ba9267b1d7f on feature/145816283/application-interface into 269e29fb9b2c0f42815a91dcbeeae8a61228269f on develop.

Coverage increased (+0.001%) to 90.803% when pulling d22ccd2b7454ad4dce8e57075d75483011e12d57 on feature/145816283/application-interface into 269e29fb9b2c0f42815a91dcbeeae8a61228269f on develop.


Look to re-design the header and nav

Might be better to start from scratch than try to recreate what was on the current site.

After POC


Use internal gain node in envelope

Use an internal gain node for enveloping stuff vs. connecting directly to parameter nodes.

having issues to connect the gain node to the envelope module. Set it aside to work on a different task.

seems like audio has to be run thru the gain node for modulation purposes.
gain = Headroom
audiothru = actual modulation performed.
Lfo used to prove this method. but still working on a final design/concept


Support CDATA text

Support CDATA text according to issue #12

Thanks for the pr! Merged as 9879a93.


GraphQL support

When I try accessing the Views Work field through GraphQL in the following way:
query feed {
  entry {
    ... on feed_articles_Entry {
      id
      views
    }
  }
}

I get the following message:
{
  "errors": [
    {
      "message": "String cannot represent value: instance of twentyfourhoursmedia\\viewswork\\models\\ViewRecording",
      "extensions": {
        "category": "graphql"
      }
    }
  ],
  "data": {
    "entry": {
      "id": "174",
      "views": null
    }
  }
}

Is Views Work not supporting GraphQL or am I missing something?
If not: is this added any time soon? Or tips on how to implement it ourselves?
Same for the 'orderByPopular',... twig helpers in the GraphQL query.

@ThinkGraphical I have not tested with GraphQL.
But the problem seems that 'views' is a model (object), not a number.
I think you should query something like views.today, views.total, views.thisMonth, views.thisWeek (but don't know the exact graphql syntax to get properties from objects)


avx512f: test cases for mm512_set4_{epi32,epi64,ps,pd}

I already fixed it, but test_simde_mm512_set4_epi{32,64} were missing the UINT32_C/UINT64_C macros on the inputs.


Doesn't work anymore

I have tried running it but the their are no results. Can you please check it once?

@amanmamta Sure! man give me some time!

Can we talk. I would like to hire you for a small work.

It's based on link resolver itself. Just let me know how can I contact you. Please consider this as this an urgent request.

You can contact me through telegram @Anubis9494

I have mssged you. please check it and reply

@amanmamta Got it!


Detection of SCTE 18 Messages

Hi, Is it possible to add detection of SCTE 18 messages?
SCTE18 carries emergency alert signaling within atsc streams.
https://www.scte.org/documents/pdf/Standards/ANSI_SCTE 18 2007 J-STD-042A 2007.pdf
I can currently detect the presence of SCTE18 PID's in the stream with tsp -P filter -p 8188 -p 8187
The pids are always either 0x1ffb or 0x1ffc.
I would like to add the ability to also read/interpret the SCTE18 table, Where can we add the EAS table ID 0xD8 and table format?

In windows the scte18 packet is received and processed:

Debug[2]: ip: received UDP packet, source: <IP_ADDRESS>:33174, destination: <IP_ADDRESS>:5050
Debug: ip: initial buffer load: 1 packets, 188 bytes
ip: unknown initial input bitrate
Debug: ip: input thread started
Debug: tables: packet processing thread started

However in ubuntu the tsduck doesn't seem to receive the packet. I can see it with tcpdump:
15:01:57.300767 IP <IP_ADDRESS>.33174 > <IP_ADDRESS>.mmcc: UDP, length 188
15:01:57.312763 IP <IP_ADDRESS>.33174 > <IP_ADDRESS>.mmcc: UDP, length 188
15:01:57.322798 IP <IP_ADDRESS>.44674 > <IP_ADDRESS>.mmcc: UDP, length 188
15:01:57.334608 IP <IP_ADDRESS>.44674 > <IP_ADDRESS>.mmcc: UDP, length 188
15:01:59.091921 IP <IP_ADDRESS>.50376 > <IP_ADDRESS>.mmcc: UDP, length 188
15:01:59.101914 IP <IP_ADDRESS>.58375 > <IP_ADDRESS>.mmcc: UDP, length 188

Support for SCTE 18 EAS messages has been added.
It is very strange that you have a different behaviour on Windows and Linux. It is possible to imagine different multicast reception behaviours, due to system configurations. But I would be extremely surprised that the processing of the same stream of received packets would be different. This is pure application code which is identical on all platforms.
Could you first capture a stream on both systems:
tsp -I ip ... -P until .... -O file out.ts

Please do that on both systems at the same time. There may be some initial and final desynchronizations but the rest of the file should be identical.
Then, try the command tstables (same as tsp -I file ... -P tables ... -O drop) on both systems. For a given file, the result shall be exactly identical on Windows and Linux.

@lelegard Thanks!
I found my issue, I assumed that tsp with ip input runs in promiscuous mode. Once i fixed my network subnets to match. tsp worked as expected.
Is there a way to run tsp in  promiscuous mode?

Also a small correction is need it the locations, the county codes are wrong. in the raw packets we have 02 2a 0c 5b 2a 0c 65, where 02 is locations count and 2a 0c 5b as first location, and 2a 0c 65 as second.
TSP output is:
State code: 42, county: 3072, subdivision: All or unspecified (0x0)
State code: 42, county: 3072, subdivision: All or unspecified (0x0)
the county codes should be 91 and 101.
2a is a state code. The next 16 bits are for:

subdivisions code (4 bytes)
reserved "11" (2bytes)
county code (10bytes)

Is there a way to run tsp in promiscuous mode?

No. TSDuck is a true UDP client, it works as any regular client. Promiscuous mode is merely designed to steal traffic from other clients, e.g. for probe tools such as WireShark.

the county codes are wrong

Sorry, should be fixed now.


First test to read characteristic.

This is a simple test to read a known BLE characteristic value and
display it on the page.

This can be viewed and run at https://cmumford.github.io/manual-tests/

All requested changes should now be addressed. PTAL.

Reilly. How does it look now?


rar: 6.11 -> 6.12

Description of changes

RAR/Unix 6.12 release
CVE-2022-30333 security vulnerability is fixed in Unix RAR versions.

See https://nvd.nist.gov/vuln/detail/CVE-2022-30333
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 188317 run on x86_64-linux 1

1 package built:

rar


Trigger initialization

Hello,
I would like to use the gradients in multiple "tiles". It works so far, I can initialize them individually (eg. onClick change state).
But most of the tiles are not visible at the beginning (display: none), so when I initialize them, the scripts says they're 0 height an width. Only if I resize the window it recreates them and the gradient is visible.
Is it possible to trigger it?
Thank you!

Can you please reproduce this bug on codepen or jsfiddle? It will be easier to debug.

So here is the pen:
https://codepen.io/SebaGnich/pen/BwMZar
When you toggle, you see it has no gradient. To show that it works, you need to remove the display: none;.

The script needs to set the width and height attributes on the <canvas> by getting this info from the DOM. In this case, because the canvas element is not displayed these values are 0.
A simple solution would be to create the Granim instance when the element is supposed to be displayed, I created a pen that shows how:
https://codepen.io/sarcadass/pen/BwbxRE


Dart 2 SDK Tests vs flutter test --preview-dart-2

I've been running into a funny issue updating the Redux library for Dart 2. Since Redux does not depend on Flutter, I generally run tests in a pure dart environment. When I run tests using the Dart 2 SDKs, all tests pass. When I run tests in a Flutter environment, I run into errors.
I'm not sure if these are accurate type errors that are no longer supported by Dart 2, or if there's some bug in Flutter, but it's a bit confusing since the tests pass using the Dart 2 SDK by itself.
Steps to Reproduce

Clone the Flutter Architecture Samples repo (https://github.com/brianegan/flutter_architecture_samples/tree/redux-flutter-test/example/redux)
Checkout the redux-flutter-test branch
Navigate to the example/redux folder
Run combine_test using the Dart SDK provided by flutter, everything works
Run the tests using flutter test --preview-dart-2 and I get type errors

Logs
example/redux ‹redux-flutter-test*› » ~/lab/flutter/bin/cache/dart-sdk/bin/dart --version
Dart VM version: 2.0.0-dev.28.0.flutter-0b4f01f759 (Tue Feb 20 17:53:06 2018 +0000) on "macos_x64"

example/redux ‹redux-flutter-test*› »  ~/lab/flutter/bin/cache/dart-sdk/bin/dart test/combine_test.dart
00:00 +0: Combining Reducers Type Safe Combinations are invoked when they match the Type of the dispatched action
00:00 +1: Combining Reducers Type Safe Combinations are not invoked if they do not handle the action type
00:00 +2: Combining Reducers Dynamic Combinations when two reducers are combined, each reducer is invoked.
00:00 +3: Typed Middleware are invoked based on the type of action they accept
00:00 +4: Typed Middleware are not invoked if they do not handle the Action and call the next piece of middleware in the chain
00:00 +5: All tests passed!

example/redux ‹redux-flutter-test*› » flutter test --preview-dart-2 test/combine_test.dart
00:01 +0 -1: Combining Reducers Type Safe Combinations are invoked when they match the Type of the dispatched action [E]
  type '(String, TestAction1) => String' is not a subtype of type '(String, dynamic) => String'
  package:redux/src/utils.dart         combineTypedReducers.<fn>.<fn>
  dart:collection                      _Object&ListMixin^^#T0.fold
  package:redux/src/utils.dart 113:21  combineTypedReducers.<fn>
  package:redux/src/store.dart 218:21  Store._createReduceAndNotify.<fn>
  package:redux/src/store.dart 250:20  Store.dispatch
  test/combine_test.dart 24:15         main.<fn>.<fn>.<fn>

00:01 +2 -2: Typed Middleware are invoked based on the type of action they accept [E]
  type '(Store<String>, TestAction1, (dynamic) => void) => void' is not a subtype of type '(Store<String>, dynamic, (dynamic) => void) => void'
  package:redux/src/utils.dart         combineTypedMiddleware.<fn>.<fn>
  package:redux/src/store.dart 238:43  Store._createDispatchers.<fn>
  package:redux/src/store.dart 250:20  Store.dispatch
  test/combine_test.dart 94:13         main.<fn>.<fn>

00:01 +3 -2: Some tests failed.

Run flutter analyze and attach any output of that command also.
Analyzing /Users/phillywiggins/lab/flutter_architecture_samples/example/redux...
No issues found!
Ran in 6.6s

Flutter Doctor
[✓] Flutter (Channel beta, v0.1.5, on Mac OS X 10.13.3 17D102, locale en-US)
    • Flutter version 0.1.5 at /Users/phillywiggins/lab/flutter
    • Framework revision 3ea4d06340 (4 weeks ago), 2018-02-22 11:12:39 -0800
    • Engine revision ead227f118
    • Dart version 2.0.0-dev.28.0.flutter-0b4f01f759

[✓] Android toolchain - develop for Android devices (Android SDK 27.0.2)
    • Android SDK at /Users/phillywiggins/Library/Android/sdk
    • Android NDK at /Users/phillywiggins/Library/Android/sdk/ndk-bundle
    • Platform android-27, build-tools 27.0.2
    • ANDROID_HOME = /Users/phillywiggins/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b08)

[✓] iOS toolchain - develop for iOS devices (Xcode 9.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 9.2, Build version 9C40b
    • ios-deploy 1.9.2
    • CocoaPods version 1.3.1

[✓] Android Studio (version 3.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b08)

[✓] IntelliJ IDEA Community Edition (version 2017.3.5)
    • Flutter plugin version 22.2.2
    • Dart plugin version 173.4700

[✓] VS Code (version 1.21.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Dart Code extension version 2.8.2

[✓] Connected devices (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 8.0.0 (API 26) (emulator)

• No issues found!

I'm not sure if these are accurate type errors that are no longer supported by Dart 2, or if there's some bug in Flutter, but it's a bit confusing since the tests pass using the Dart 2 SDK by itself.

Have you tried running with --preview-dart-2 directly n the Dart VM? (~/lab/flutter/bin/cache/dart-sdk/bin/dart --preview-dart-2 test/combine_test.dart)? This might confirm whether it's just Dart 2 changes versus something in Flutter?

@DanTup Good call -- I should have included that run as well. I get the same results:
example/redux ‹redux-flutter-test› »  ~/lab/flutter/bin/cache/dart-sdk/bin/dart --preview-dart-2 test/combine_test.dart
00:00 +0: Combining Reducers Type Safe Combinations are invoked when they match the Type of the dispatched action
00:00 +1: Combining Reducers Type Safe Combinations are not invoked if they do not handle the action type
00:00 +2: Combining Reducers Dynamic Combinations when two reducers are combined, each reducer is invoked.
00:00 +3: Typed Middleware are invoked based on the type of action they accept
00:00 +4: Typed Middleware are not invoked if they do not handle the Action and call the next piece of middleware in the chain
00:00 +5: All tests passed!

Sorry to ping on this one again -- trying to get my stuff Dart 2 ready! Does anyone have any insights into this issue?

@brianegan I had a go at reproing this, but failed to restore packages:
dantup-macbookpro:redux dantup$ flutter packages get
Running "flutter packages get" in redux...
Incompatible version constraints on intl:
- flutter_architecture_samples 0.0.1 depends on version 0.15.1
- flutter_driver 0.0.0 depends on version 0.15.4
pub get failed (1)

I'm likely on a later flutter. Have you tried on either the new beta update this week, or on master to see if it might already fixed? I think there have been a lot of fixes since the first beta. (I don't think you use it, but in VS Code you can check both master and beta out and quickly switch between them from the status bar).

@DanTup I ran into this issue on master recently, but worth giving it another shot. Thanks for the help!

FWIW, I suspect the error is the correct behaviour and the Dart VM is incorrect (or outdated). If you define a function as taking dynamic but then passed it something that requires a specific type, it'd be a runtime error if you called it passing something else.

@DanTup Yep, that's definitely what I'm trying to suss out, but in this case the error is a bit strange. Why? Because I'm not returning a (String, TestAction1) => String but rather a (String, dynamic) => String.
The exact function that's throwing the error is this one:
// User defines the type of Action they want to handle
class ReducerBinding<State, Action> { /* Omitted for brevity */ }

// Function takes in a list of ReducerBindings with different types of actions handled.
// It returns a function of the correct signature.
//
// I've tried using both ReducerBinding<State, dynamic> and ReducerBinding<State, Object>
// but neither works. In either case, a function of the correct signature is returned.
Reducer<State> combineTypedReducers<State>(
    List<ReducerBinding<State, dynamic>> bindings) {
  return (State state, dynamic action) {
    return bindings.fold(state, (currentState, binder) {
      if (binder.handlesAction(action)) {
        return binder.reducer(state, action);
      } else {
        return currentState;
      }
    });
  };
}

I don't know a lot about how this works, but can you not use generic type args so the types all match up everywhere? (it if works, you'll get extra type safety you didn't have with dynamic)

In this case, that's not possible. An action needs to be of any type (dynamic or Object or some base-type). This allows both the user and 3rd party libraries to dispatch Actions.

Ok, got it working by shuffling some code around, but still curious if this might be a bug.
The problem in the end turned out to be this line:
binder.reducer(state, action). Since the action is dynamic, and the binder.reducer has a Typed param, they didn't match. What made it confusing is I had tried explicitly casting the action to the correct type, using action as Action, and it still failed for me.
However, if I pass the action into a function that accepts dynamic, and casts inside an if statement there, all works.
State reduce(State state, dynamic action) {
    if (action is Action) {
      return reducer(state, action);
    } else {
      return state;
    }
  }


Any noise will appear to contain patterns if patterns are looked for

If you listen to empty white noise long enough you might begin to hear voices or sounds in the static. Any program designed to look for repeating patterns or complexity occuring in, what should be, random noise is going to find "something" there, because noise is noise

Just because there isn't any input, you can't expect a RGN to produce stable noise at high frequency. Your "impulses" could very well be the processors of your device lagging for milliseconds at a time, desyncing your noise

And beyond that, what about a repeating pattern makes it intelligent? By that logic wouldn't any naturally occurring pattern, such as the golden ratio, be equal proof that "math is engineered"?

It's a program, its result does not depend on how you perform it - you may do the same on a paper, with a pencil. Ratio is a ratio. Information is a completely different thing.

Not that math isn't engineered, by humans in an attempt to understand and calculate the world around us. It is a haphazard numeric representation of reality and not reality itself

I'm not telling math is a reality itself.

Like looking closely at a printed photo and seeing the pixels of the camera's sensor, it's a limitation of our math, not a representation of a universe-predating being

I'm not talking about representation of God either. My conclusion is that mathematics is an art of God.

Ok, but what it sounds like you have concluded is that if a tree falls in the woods with none around to hear it, then it only existed to fall because it was being perceived by God/the human mind? Or concluding that math cannot contain set "information" or properties without there being someone to write them or perceive them?

It seems a bit of a logical leap, perhaps cognitive bias of the human mind when staring into a long empty corridor such as maths

Math is usually not thought as something "having information", it is perceived as a set of rules to manipulate information. Information is assumed to be always human-made. But my research conclusively says that math does have embedded human-understandable information.

Generally, your comments go far beyond what I've discovered and claiming. This work is not about how consciousness works, or ways to "see" something in noise. Extracting information from noise always requires some sort of a filter. Here, the function is itself a generator, but, quite unexpectedly, it does not generate noise...

Your claim assumes there is a god to begin with, making all findings thereafter biased. What you're seeing is far more likely to be fractals or simpler patterns arising from hardware or implementation limitations. Pseudo random number generators are named such because they are by definition not random and built on patterns that look "random enough" and have a useful distribution of output. Any structure found is indeed there by design, but the designer is you.

Pseudo-random generators have to pass specific statistical tests. They are pseudo-random, because they require seeding. Of course, I'm the designer of the program, but what the program produces is not defined in the program, it's embedded into math.

As for mentioning Creator, it's just a conclusion. The overall reasoning is not based on imaginary existence of God, it's the other way round - the finding requires introduction of external source of information as to not meet a dead-end.

You're just ignoring your own biases and applying conclusions from fallacy. It's like people who claim that God exists because the "chance" of the world existing is "too unlikely" without design. It's a fallacy. The chance of the world existing the way it does is 100% because it does exist. It exists by the properties of the universe because the properties of the universe are.
You claim being able to observe a pattern from pseudo, key being PSEUDO, random data is proof of a creator but it's not proof of anything; except that your brain as a human in the universe evolved within the constraints of the universe and is wired to find patterns therein, wherever it can. You wouldn't be able to recognize anything, period, if you weren't constantly subconsciously analyzing and attributing combinations of contrast as objects to be recognized.

@SampsonCrowley  Ah, whatever, you are spewing a usual "educated" word mumbo-jumbo. All I'm talking about is that math is likely engineered, with some pre-defined non-random information embedded. The keyword is "non-random", because in realm of PRNG, randomness is strictly defined via a set of state-of-the-art tests. Existence of God is then a byproduct conclusion, questionable of course, and that's why I'm using adverb "probably".

I'm actually expecting someone to describe function's behavior in other terms, of course in the realm of mathematics, maybe referring to some implicit functions. Everything else is just literacy contest.

Of course, I'm the designer of the program, but what the program produces is not defined in the program, it's embedded into math.

Creating a simple program that produces interesting patterns isn't particularly novel nor is it evidence of a higher power. The code somewhat resembling that of an actual PRNG program doesn't change anything.

@TheUnlocked You are simply not involved enough, and the issue is not about your beliefs. What the program does - exhibits complex non-linear behavior while using linear in F2 math - may change a lot of things.


Observation does not distinguish between empty cells and unobserved cells

I think it would be beneficial (at least to me) to include the option of distinguishing between a cell which is observed to be empty, and a cell which is not seen at all (e.g. behind a wall).  This is currently not the case, as both scenarios correspond to 0 values in the observation image.
I would probably try to do this in my own fork, but if there is any interest in pulling this to the main repo I would like to discuss it here because there's multiple ways to approach this:

Adding an item to the observation dictionary.
pros:  does not change observation image, i.e. less likely to break existing code.  Completely separates "what is seen" from "whether it is seen", so that the user can choose whether to use just one of both.
cons:  The original ImgObsWrapper would ignore the addition and just return the original image.

Adding a cell type value to the observation image;  perhaps this can be done by adding a new cell type altogether "Unseen" which will only be used in observation grids?
pros:  minor change to observation image, less likely to break code
cons:  Arguably awkward to add a type which is not associated with the state of the true environments and its objects.

Adding a binary channel to the observation image.
pros:  dedicated channel, "unseen" is not a physical property inherent to the environment so it makes sense to separate it from things like the actual items.
cons:  major change to observation image, more likely to break existing code.

Personally, I think option 1 would work best:  Existing code will continue working as before, and methods which want to exploit the new mask are able to do so.  New observation wrappers can be added to handle the case where the user wants just the image, or the image and the "mask".
Thoughts?

You're not the first to bring this up, which suggests it's probably a good idea to add this information to observations.
I think I might lean towards option 2. The unseen cell type could take integer value 0, and everything else would be shifted up by 1. It probably won't break code. Actually, the upside is that a neural network (or other algorithm) trained with this new observation format should be able to take advantage of the extra information without any changes to the code.

This might require a new Object to be defined;  Grid.encode() only has access to the objects in the grid (with None taking a special meaning), and not the agent itself.
The least invasive way seems to add an Unseen / Unknown cell type, but this seems backwards to me:  If anything, an Empty cell is more of an actual physical property of the grid, compared to an Unseen.  This may require more work to carefully make sure nothing breaks, but what do you think about either:

Letting None mean "not applicable" and adding a new Empty cell type;  or
Adding both an Unknown cell type and an Empty cell type;  this way the grid contents are homogeneous and always WorldObj.

I prefer number 1, but I obviously lack a lot of understanding in how this may influence and break everything else, so it's your choice.

In terms of the least code breakage, it would be best not to add new cell types.
I would encode Unseen as (0, 0, 0) on all 3 channels and increment the existing cell type integer values by 1.
For Grid.encode(), we might want to pass the visibility mask as an optional argument.

Just to be clear, you're suggesting that the encodings for the second and third channels should not change, right?  i.e. In the color channel, 0 should remain red, which at the same time means that both empty cells and unseen cells will be encoded as having the same code as red?

Yes


[doc] Add "Alternatives" for Bazel and ROS 2 workflows; mention ApexAI/rules_ros

Per internal discussion.
Filed issue for RFC and possible symmetry: https://github.com/ApexAI/rules_ros/issues/5

This change is

Here is a yet another alternative https://github.com/mvukov/rules_ros2/ ;).

And it cool if I file issue against your repo for similar? If you wanna link here, or add your own analysis, I'm good either way!

Sure, you can either open an issue or make a PR.

--> https://github.com/mvukov/rules_ros2/pull/24

@EricCousineau-TRI This looks good to me. Thanks for referencing the ApexAI/rules_ros here.

See also discussions in https://discourse.ros.org/t/adding-bazel-as-an-official-alternative-build-system-for-ros2-iron/28476

Thanks!


Puppet is abstract class, can't construct it.

The wechaty constructor needs the options containing Puppet instance, but Puppet is defined as abstract. So I can't create an instance of it and pass it to WechatyOptions.

got the same issue.

@GuoqiuZhong 目前已经出了一个基础版的dotnet-wechaty-getting-started 可以使用 https://github.com/wechaty/dotnet-wechaty-getting-started


Added basic editing and save capability. Rotate or delete pages.

Glad to be of help. I added several of the APIs that I know of for editing and saving to the NativeMethods collection and also added DeletePage and RotatePage to PdfDocument. This should be plenty to get you started, but there is a lot more that can be done of course.

I should also note that in this branch I changed the PdfFile class to always use the FPDF_LoadCustomDocument method and a generic Stream. (This also obviates any need for the derived PdfFile classes). This way you can open a PDF file with any kind of Stream (even something off a network, encrypted, whatever you like) and the delegate takes care of feeding the data to pdfium. There's some fancy COM interop going on in order to pass the Stream around so it actually gets to the delegate, but it works like a charm. I use this to read PDFs off of Azure blobs, among other things.

please merge the pull request.

Sorry for the delay. Thank you for the merge request; looks very nice. I've made a few changes:

I've cleaned up some things (removed the unused files, some small checks, some minor refactoring);
I removed the "fancy COM interop" and replaced it with a registry to create int handles for Stream's. Looks a lot simpler and doesn't interfere with the GC as much;
I've implemented rotate and delete on PdfDocument and added a few menu options in the demo application to demo these new methods.

Oh that's a much more elegant solution to passing the Stream to the native code!
Glad to be of help.
Sent from my iPhone
On Jun 17, 2016, at 12:59 AM, Pieter van Ginkel <notifications<EMAIL_ADDRESS>wrote:
Sorry for the delay. Thank you for the merge request; looks very nice. I've made a few changes:

I've cleaned up some things (removed the unused files, some small checks, some minor refactoring);
I removed the "fancy COM interop" and replaced it with a registry to create int handles for Stream's. Looks a lot simpler and doesn't interfere with the GC as much;
I've implemented rotate and delete on PdfDocument and added a few menu options in the demo application to demo these new methods.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/pvginkel/PdfiumViewer/pull/57#issuecomment-226687020, or mute the threadhttps://github.com/notifications/unsubscribe/AInpM03BE3omuZfvwhJ3jRuo_KLXBuyFks5qMjetgaJpZM4HfqiW.


HDDS-3720. Datanode configuration object has wrong values

What changes were proposed in this pull request?

@Config annotation was assigned to the wrong fields (the ones with default values) in DatanodeConfiguration - fixed.
Added check for possible coding error: @Config on final field.  This catches the above problem if the class is instantiated in tests.
Added unit test.

https://issues.apache.org/jira/browse/HDDS-3720
How was this patch tested?

Verified that default values are used (without warning) by default:

datanode_1  | ... INFO statemachine.DatanodeStateMachine: container.delete.threads: 2
datanode_1  | ... INFO statemachine.DatanodeStateMachine: replication.streams.limit: 10

Verified that valid custom values are accepted:

datanode_1  | ... INFO statemachine.DatanodeStateMachine: container.delete.threads: 123
datanode_1  | ... INFO statemachine.DatanodeStateMachine: replication.streams.limit: 42

Verified that invalid custom values produce warnings, and config is reset to default:

datanode_1  | ... WARN statemachine.DatanodeConfiguration: hdds.datanode.replication.streams.limit must be greater than zero and was set to 0. Defaulting to 10
datanode_1  | ... WARN statemachine.DatanodeConfiguration: hdds.datanode.container.delete.threads.max must be greater than zero and was set to -1. Defaulting to 2
datanode_1  | ... INFO statemachine.DatanodeStateMachine: container.delete.threads: 2
datanode_1  | ... INFO statemachine.DatanodeStateMachine: replication.streams.limit: 10

Added unit test for the same cases.
https://github.com/adoroszlai/hadoop-ozone/runs/741212448

Thanks @adoroszlai for the contribution.

Thanks @nandakumar131 for reviewing and committing it.


fix: cluster deploy compatible different os

What type of PR is this?

/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #635
Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

Codecov Report

Merging #636 (109ff91) into master (c7bf54d) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.


Separate mutex of Http2ClientSession and Http2Stream

When parent selection feature is enabled, TS starts dns reverse lookup on every transaction. With HTTP/2, HostDBProcessor::getby() is called simultaneously and lock contention starts. This serialize the transactions of HTTP/2.
https://github.com/apache/trafficserver/blob/e4aa18e3337929bb1c9dc4272f369c86a1325c61/iocore/hostdb/HostDB.cc#L652
Before

After

Also debug logs of hostdb says "getby" got immediate answer in many cases.
Before
10000 <HostDB.cc:485 (reply_to_cont)> (hostdb) hostname = localhost
7786 <HostDB.cc:664 (getby)> (hostdb) immediate answer for <IP_ADDRESS>
2214 <HostDB.cc:675 (getby)> (hostdb) delaying force 0 answer for <IP_ADDRESS>

After
10000 <HostDB.cc:485 (reply_to_cont)> (hostdb) hostname = localhost
9913 <HostDB.cc:664 (getby)> (hostdb) immediate answer for <IP_ADDRESS>
87 <HostDB.cc:675 (getby)> (hostdb) delaying force 0 answer for <IP_ADDRESS>

Fix #3100 b)
Backport 7.1.3 candidate

I haven't looked into the detail but my only concern is HPACK. We need to acquire a lock for session before accessing HPACK tables.

As for receiving frame, HPACK is covered by mutex of Http2ConnectionState.
As for sending frame, send_headers_frame() is called from Http2Stream and it looks not covered by mutex of Http2ClientSession or Http2ConnectionState. I'll take a look more.
Actually, I also worry about metrics and connection level flow control.

@zizhong Could you please take a look? We need more eye balls.

@masaori335 sure. Will do.

Overall looks good to me that all the write operations get the right locks.
Didn't check the risk of deadlock. @masaori335 do we need to worry about it?

I'm not wildly familiar with this code, but it feels like we should free this stream mutex at some point? Or is there C++ magic happening here somewhere ?

@zwoop It's refcount object, so when ProxyClientTransaction::destroy() is called, it should be freed. But I'll check again.

@zizhong Thanks. Yes, it could be. I'm checking it with TSan and it reports some potential deadlocks. I'm looking them. https://paste.apache.org/Mpln

@zwoop What I said was little bit wrong. When ProxyClientTransaction::destroy() is called from Http2Stream::destroy(), the mutex.m_ptr->m_refcount is not 0.
But when mutex.m_ptr->m_refcount is 0, it is freed finally.
https://paste.apache.org/gUij

I built master and this PR with ThreadSanitizer, and send some traffic by nghttp for regular cases and h2sepc for corner cases.
TSan reported some “lock-order-inversion (potential deadlock)” . But there’re no difference between master branch and this PR.

Sounds like we need one more issue for it. Does it survive tons of requests from h2load?

So we should always fetch the session lock then the stream lock?  Or visa versa?

[approve ci debian]

If above TSan reports are not false positive, the lock order should be consistent. Also we need to take care of the order of (Http2ConnectionState - Http2Stream) and (Http2ConnectionState - Http2ClientSession). I think the lock order should be below, because this is the order of those objects are created.

Http2ClientSession -> Http2ConnectionState -> Http2Stream

BTW, some of above TSan reports might be false positive, because some functions of Http2Stream are sending the cross-thread-event to owning thread. If all events are processed on same thread (not sure this is right thing), the lock-order-inversion doesn't trigger deadlock.

The three TSan reports for this PR looks fails positive. I think we can leave it.
a) Http2Stream vs Http2ConnectionState
WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid=1662)
#4 Http2Stream::update_read_request(long, bool, bool) /home/masaori/src/github.com/apache/trafficserver/proxy/http2/Http2Stream.cc:478 (traffic_server+0x0000006fad94)
#4 Http2Stream::update_write_request(IOBufferReader*, long, bool) /home/masaori/src/github.com/apache/trafficserver/proxy/http2/Http2Stream.cc:603 (traffic_server+0x0000006fbe08)

Full TSan Report : https://paste.apache.org/wCAQ
This looks false positive because Http2Stream::update_read_request() and Http2Stream::update_write_request() always run on same thread

b) Http2Stream vs Http2ConnectionState
WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid=20208)-
#4 Http2Stream::update_read_request(long, bool, bool) /home/masaori/src/github.com/apache/trafficserver/proxy/http2/Http2Stream.cc:478 (traffic_server+0x0000006fad94)-
#4 Http2Stream::terminate_if_possible() /home/masaori/src/github.com/apache/trafficserver/proxy/http2/Http2Stream.cc:378 (traffic_server+0x0000006f9e40)

Full TSan Report : https://paste.apache.org/Mpln
This looks false positive because Http2Stream::main_event_handler() and Http2Stream::update_read_request() always run on same thread

c) Http2ConnectionState vs Http2ClientSession
WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid=20208)-
#4 send_connection_event /home/masaori/src/github.com/apache/trafficserver/proxy/http2/Http2ClientSession.cc:57 (traffic_server+0x000000708a2d)-
#4 Http2ConnectionState::send_headers_frame(Http2Stream*) /home/masaori/src/github.com/apache/trafficserver/proxy/http2/Http2ConnectionState.cc:1453 (traffic_server+0x0000007188e0)

Full TSan Report : https://paste.apache.org/yW4X
This looks false positive because Http2Stream::update_write_request() sends cross-thread event to same thread of Http2ClientSession::start() is processed.

[approve ci debian]

Now, the issue #3100 b) doesn't looks serious in our production. So let's change the release target to 7.2.0 or 8.0.0. At least, this doesn't hold up 7.1.3 release.

This doesn't cherry-pick cleanly, it looks like a trivial change, but lets stick to the protocol and make a 7.1.x PR please.