Initial UI/UX concept

Create initial concept of UX/UI. A few considerations:

Service has potentially 3 environments:

website
browsers extension
developer module / js library / plugin

UI should account both for desktop and mobile platforms

Here’s some of the studies we’ve been working before following the initial plan for Discussify, where different platforms were taken in consideration. Please note that for now we're only focusing on the desktop version.

Web-app (w/ landing page draft)

https://drive.google.com/file/d/1_ntHspDj_hMgfpv_lC7t6_WjePNejKqZ/view

Initial Style Guide (for web-app)

https://drive.google.com/file/d/1Wg8BxkVzGBNiqW-epfik3xHas1iM-hHT/view?usp=sharing

Extension to easily discuss URIs

https://drive.google.com/file/d/1UR2LrjBrQuUj9JkcUl-He2TGvxezIhw0/view?usp=sharing

An embed so that developers can embed discussions on stuff like articles, news, etc.

https://drive.google.com/file/d/19c5_l0LcZfZ_aC6S3JSdxauQMo1-JWK4/view?usp=sharing

Current Status
The browser extension will be the path to follow since it will be required to present by the end of July with the MVP features. This week was defined that we need to use “Blockstack” for the login process.
Here’s the current proposal following those requirements:

https://drive.google.com/file/d/10ZiCztQEuTJ5EiDkYdOwJIq323vMMB1Y/view?usp=sharing

*For this concept discussions are always public and users have the ability to share discussions directly with other Blockstack IDs.

To mark this task as complete, we should put the links to the material into the README.md or DESIGN.md.
Thoughts @marcooliveira ?

Yes, I'm working on getting this information organised here on Github, it's a bit different from what we're used to. I'll organise it and let you know.

Based on the discussions today, let's organise this material under the repo. I'll be making the changes we discussed shortly.

Marking this as done, I'm organizing the repository as part of #42


Refactor Buggy code

Based on @harshavardhana PR feedback. Still compiling exact refactoring todo items.

Some amount of cleanup has already happened. Don't have cycles to fix this completely right now.


Changes related to Spark Connector upgrade to 3.4.0

Ignore the output cell diffs - all config changes are in the top few code cells.

To be merged together with the Dockerfile PR related to Spark Connector 3.4.0 upgrade. With just one merged, Spark notebooks will break.

Thanks, Arthur and Phuc.
On Fri, May 13, 2022 at 12:17 AM pvinh-spike @.***>
wrote:

Merged #47
https://github.com/aerospike-examples/interactive-notebooks/pull/47
into main.
—
Reply to this email directly, view it on GitHub
https://github.com/aerospike-examples/interactive-notebooks/pull/47#event-6603425633,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AN2IW4REUFFHO6KONUNN7ITVJX6X3ANCNFSM5VZTUXSQ
.
You are receiving this because you authored the thread.Message ID:
<aerospike-examples/interactive-notebooks/pull/47/issue_event/6603425633@
github.com>


game: init properties

This wasn't being initialized, and it would cause a soft error on login.

It was removed, since not really needed.


feat(mongo 3.6): update zsh completions for mongo 3.6

add installation method with antigen

Nice -- thanks @Ameausoone :)


Fixed apsect ratio

Fixed to use aspect_ratio auto determine rows and cols.
Added more examples to doc.

Need to fix some typos.  Please ignore this pull request


Is String Foldable?

Hello,
I was wondering why a character string is not considered as a Foldable.
AFAIU, a character string could be reduced character by character.
Can someone give me more insight on this point ?

Setting aside contradictions which arise if one treats String as shorthand for Array Char, String cannot satisfy the requirements of Foldable because we need a value of type Foldable f => f a for any type a, but the inner type is fixed (to Char).

for any type of a

Ah yes, now it makes sense.
So the easy way to treat a String as a Foldable is to convert it to Array Char which means one can use S.splitOn('') and S.joinWith('') as conversion tools.
Thanks for the quick answer :-).


Fixture templating: adds the ability to create fixtures from templates files using dynamic values

This PR adds a templating mechanism to requestmatcher. It works by replacing keys that are in the ${KEY} format by the values specified using the fluent API exposed to users of the library, like this:
server.addTemplate(404, "json_error_template.json")
                .withValueForKey("error", "Resource not found")
                .ifRequestMatches()
                //...

I believe no change is breaking! I chose to change the method name from addFixture to addTemplate in this case to make the intentions clearer. The delimiters ($,{,}) are open for discussion!

Should’ve ran the quality suite 🧐

Friendly ping


Failed to subscribe Create 3 Topics

Robot Model
Turtlebot4 Standard
ROS distro
Humble
Networking Configuration
Simple Discovery
OS
Ubuntu 22.04
Built from source or installed?
Installed
Package version
$ dpkg -l | grep turtlebot4
ii  ros-humble-turtlebot4-base                        1.0.2-1jammy.20240219.090534            arm64        Turtlebot4 Base Node
ii  ros-humble-turtlebot4-bringup                     1.0.2-1jammy.20240308.175126            arm64        Turtlebot4 Robot Bringup
ii  ros-humble-turtlebot4-description                 1.0.4-1jammy.20240220.151406            arm64        Turtlebot4 Description package
ii  ros-humble-turtlebot4-diagnostics                 1.0.2-1jammy.20240219.092405            arm64        Turtlebot4 Diagnostics
ii  ros-humble-turtlebot4-msgs                        1.0.4-1jammy.20240217.101439            arm64        Turtlebot4 Messages
ii  ros-humble-turtlebot4-navigation                  1.0.4-1jammy.20240220.175556            arm64        Turtlebot4 Navigation
ii  ros-humble-turtlebot4-node                        1.0.4-1jammy.20240219.090001            arm64        Turtlebot4 Node
ii  ros-humble-turtlebot4-robot                       1.0.2-1jammy.20240308.175711            arm64        Turtlebot4 Robot Metapackage
ii  ros-humble-turtlebot4-setup                       1.0.3-1jammy.20240217.102329            arm64        Turtlebot4 setup scripts
ii  ros-humble-turtlebot4-tests                       1.0.2-1jammy.20240217.102249            arm64        Turtlebot4 System Tests

Type of issue
Networking
Expected behaviour
RasPi4 could subscribe Create 3 Topics.
Actual behaviour
RasPi4 could NOT subscribe Create 3 Topics.
Error messages
$ ros2 topic echo /battery_state

There is no response.
$ ros2 topic echo /odom
WARNING: topic [/odom] does not appear to be published yet
Could not determine the type for the passed topic

RasPi4 could NOT subscribe Create 3 Topics.
To Reproduce

Change to Simple discovery and Cyclone DDS(RasPi4)
Change to Simple discovery and Cyclone DDS(Create 3)
Create 3 connect Wi-Fi AP via Create 3 webserver
Shutdown RasPi4 and Create 3
Power on RasPi4 and Create 3

Other notes
I checked the following environment variables.
$ echo $ROS_DOMAIN_ID
0

$ echo $CYCLONEDDS_URI
/etc/turtlebot4/cyclonedds_rpi.xml

$ echo $RMW_IMPLEMENTATION
rmw_cyclonedds_cpp

RasPi4 could subscribe RasPi4 topic.
ros2 topic echo /scan

I checked the configuration via Create 3 webserver.

I checked the connection from RasPi4 to Create 3. As a result, there is no problem.
ping <IP_ADDRESS>

Hello @atinfinity ,
Thank you for reaching out on the official Turtlebot 4 Github page. I am very sorry to hear that you are having issues with on our products. Would it be possible to provide the following:

Are you able to view the topics from the Create3 on your remote computer? What is the output of ros2 topic list on the Raspberry Pi and the remote computer?
Is the Create3 connected to a 5 GHz network? The Create3 cannot handle a 5 GHz network and must be connected to a 2.4 GHz network.
Would it be possible to share the Create3 logs: https://iroboteducation.github.io/create3_docs/webserver/logs/
Looking forward to hearing from you soon.
Best Regards,
Saif

@smatarCPR

Are you able to view the topics from the Create3 on your remote computer?

No.
I read https://turtlebot.github.io/turtlebot4-user-manual/setup/simple_discovery.html#additional-cyclonedds-configuration to set up DDS on remote computer.
wget https://raw.githubusercontent.com/turtlebot/turtlebot4_setup/galactic/conf/cyclonedds_pc.xml
sudo mv cyclonedds_pc.xml /etc/turtlebot4/
export CYCLONEDDS_URI=/etc/turtlebot4/cyclonedds_pc.xml
export RMW_IMPLEMENTATION=rmw_cyclonedds_cpp
export ROS_DOMAIN_ID=0

As a result, remote computer could not subscribe RasPi4 & Create3 topics.
$ ros2 topic list
/parameter_events
/rosout

What is the output of ros2 topic list on the Raspberry Pi and the remote computer?

https://github.com/turtlebot/turtlebot4/issues/381#issue-2191363120 is the result of RasPi4.
$ ros2 topic list
/battery_state
/cmd_vel
/color/preview/image
/diagnostics
/diagnostics_agg
/diagnostics_toplevel_state
/dock_status
/function_calls
/hazard_detection
/hmi/buttons
/hmi/display
/hmi/display/message
/hmi/led
/imu
/interface_buttons
/ip
/joint_states
/joy
/joy/set_feedback
/mouse
/parameter_events
/robot_description
/rosout
/scan
/stereo/depth
/tf
/tf_static
/wheel_status

There is battery_state topic. But RasPi4 could not subscribe this topic.
There is no odom topic.

Is the Create3 connected to a 5 GHz network? The Create3 cannot handle a 5 GHz network and must be connected to a 2.4 GHz network.

Create3 and RasPi4 connected 2.4GHz network.

Would it be possible to share the Create3 logs: https://iroboteducation.github.io/create3_docs/webserver/logs/
Looking forward to hearing from you soon.

I downloaded Create3 logs via webserver. messages.txt

tev: ddsi_udp_conn_write to udp/<IP_ADDRESS>:7400 failed with retcode -1

It seems that DDS communication failed.

And I found strange behavior.
Create 3
I set to Cyclone DDS via Create 3 webserver. And I restart Create 3.

Raspi4
I set to Fast DDS on RasPi4.
export RMW_IMPLEMENTATION=rmw_fastrtps_cpp
export ROS_DOMAIN_ID=0

In this case, RasPi4 could subscribe odom topic.
But I don't understand this behavior.

Hello @atinfinity ,
Would it be possible to try factory resetting the Create3: https://iroboteducation.github.io/create3_docs/webserver/about/#:~:text=set to USB.-,Factory Reset,-A hyperlink to
Following this flash the latest firmware, based on your initial opening, you are running ROS Humble, meaning the latest firmware for the Create3 would be H.2.6 which can be found here: https://iroboteducation.github.io/create3_docs/releases/overview/
After updating, reconfigure the Create3 and see if the issue persists. Looking forward to hearing from you soon.
Best Regards,
Saif

@smatarCPR I tried to flash H.2.6 firmware and try factory resetting.
But, this issue factory persist.

@smatarCPR I used Dual Band Wi-Fi Router(2.4GHz + 5GHz).
And, I select 2.4GHz as band in turtlebot4-setup(Wi-Fi setup)
https://turtlebot.github.io/turtlebot4-user-manual/setup/basic.html#connect-the-raspberry-pi-to-your-network
Is this a problem?

Hello @atinfinity ,
Does the dual band network have separate SSIDs for the different frequency bands or are they found on the same SSID? If so, then this is likely what is causing the issue seen. If possible separate the two frequency bands into two uniquely named networks. Connect the Raspberry Pi to the 5.0 GHz network and set the band as 5.0 GHz in the turtlebot4-setup(Wi-Fi setup). Then for the Create3, connect it to the 2.4 GHz network. The two networks should be joined in the backend allowing for communication across all devices.
Alternatively, you can switch to a discovery server setup, if the option is available to you, this will have the Create3 communicate to the Raspberry Pi using the USB-C connection, and the Pi will forward the data using the 5 GHz network. We typically see faster speeds and a more stable connection when this setup is used.
Let me know how these recommendations work for you. Looking forward to hearing from you soon.
Best Regards,
Saif

Hello @atinfinity ,
This issue is being closed due to inactivity. If you are still experiencing the issue, feel free to reopen this ticket when you are ready to continue the troubleshooting process.
Best Regards,
Saif


DOC: add an explicit statement about NR to the FAQ

sparked by the discussion starting at https://github.com/scipy/scipy/pull/5653#issuecomment-170696160
The questions about Numerical Recipes, the book appear every so often. Maybe it's worth it to formulate our position w.r.t. NR explicitly. What's written here is only me hoping to not completely butcher the wording by @matthew-brett and I'm happy to scrap it if there's a better alternative and/or a better location for it.
I'll dare pinging @rkern  for an opinion on legal matters, and also @pv @rgommers @argriffing. I imagine that merging this would require some sort of consensus among @scipy/scipy-core-team
[ci skip]

it is fine to refer to its text

That book is written in almost a literate programming style, so I'm imagining someone writing Python code while they refer to the commented lines in the text of the 'numerical recipes in fortran' book. They see this explicit statement and so they hit the 'submit PR' button because they've only referred to the book's text and they've never even looked at the source code in the CD that came with the book.

@@            master   #5716   diff @@
======================================
  Files          234     234
  Stmts        43137   43137
  Branches      8155    8155
  Methods          0       0
======================================
  Hit          33453   33453
  Partial       2604    2604
  Missed        7080    7080

Review entire Coverage Diff as of f040b51

Powered by Codecov. Updated on successful CI builds.

While you're at it, this same section has a link to https://www.scipy.org/License_Compatibility that is broken. Can't remember what text was there. Maybe just remove the link.

http://scipy.github.io/old-wiki/pages/License_Compatibility.html

@ev-br want to give this another try? The comments seem to have converged mostly.

Seems stalled and still a bit contentious, so closing to get the PR count smaller...


Composer crashes due to DDP time-out

** Environment **
GCP A100s running mosaicml/composer:all-0.2.4
I get this trace-back relatively often (third time that I've seen this, so it certainly isn't a one-off error).
Traceback (most recent call last):
  File "/workspace/src/composer/examples/run_mosaic_trainer.py", line 47, in <module>
    main()
  File "/workspace/src/composer/examples/run_mosaic_trainer.py", line 42, in main
    trainer = Trainer.create_from_hparams(hparams=hparams)
  File "/workspace/src/composer/composer/trainer/trainer.py", line 366, in create_from_hparams
    trainer = cls(
  File "/workspace/src/composer/composer/trainer/trainer.py", line 199, in __init__
    ddp.initialize_ddp(device.ddp_backend, datetime.timedelta(seconds=ddp_timeout))
  File "/workspace/src/composer/composer/utils/ddp.py", line 205, in initialize_ddp
    dist.init_process_group(backend, timeout=timeout)
  File "/usr/local/lib/python3.8/dist-packages/torch/distributed/distributed_c10d.py", line 547, in init_process_group
    _store_based_barrier(rank, store, timeout)
  File "/usr/local/lib/python3.8/dist-packages/torch/distributed/distributed_c10d.py", line 219, in _store_based_barrier
    raise RuntimeError(
RuntimeError: Timed out initializing process group in store based barrier on rank: 0, for key: store_based_barrier_key:1 (world_size=8, worker_count=7, timeout=0:00:05)

Do we need to increase the timeout for GCP, or is there something else going on?

I had this issue with DeepLabV3 since I was downloading pretrained weights during model initialization. A quick fix is to set --ddp_timeout to larger value. I'm not sure if the long-term solution is to set --ddp_timeout on a case by case basis or to make a more general change to ddp. cc: @jbloxham?

Assuming @moinnadeem's error is the same as @Landanjs's, the fix here is to initialize the distributed environment before doing any model or dataset initialization. That should be a quick fix. @Landanjs do you have a YAML I could use to replicate?

I'm currently working on my fork on branch landan/ade20k_deeplabv3, but this should hopefully be merged by the end of the week. Alternatively, I suspect setting --model.gpt2.use_pretrained true when using the GPT-2 yamls would result in the same issue.

Closing for now as the timeout may need to be adjusted on a per-experiment basis. If there is a better default timeout, please create a PR for that -- happy to adjust it so long as it's reasonable (i.e. probably on the order of minutes)?

Wait, I think we should take a look at this since we're seeing a few people run into this. I know I've launched experiments only to see them fail due to a poor time-out. @Landanjs Are you still seeing this? Maybe we could both find a good timeout for us and make that a new default?

Yeah, can do! I'm really focused on getting speedups at the moment, and then will spend time fixing a lot of the Composer bugs that I've been running into. I can take care of a lot of that stuff early February.

I can check as well when some GPUs become available

Just checking, #272 should fix this right?


Investigate and fix liveness probe in presence of a large WAL

(we observed a CrashLoopBack on k8s with a full WAL of 10GB)

Closed via #4512.


need help for a project

Good evening/morning,
I am a 4 year computer science student and have a project where I think I need to use Unicorn Engine.
My project is to emulate a single function from an executable (PE, ELF or MACH-O) for all the platforms (Windows, Linux or Mac).
I know that your project can do that but I have to write a code less bigger and by myself.
I wanted to know if you could give me any advice for it ?
In your project, I don't realy understand where are the instructions we want to emulate ?
What I understood is that you write all the instructions of the executable in the Unicorn instance and then you emulate what you want. Is that?
Thank you for your time,
Sorry for inconvenience ,
NB

Hello NB,
With Unicorn, you have to allocate memory in the emulator, write the instruction bytes to it, then emulate it. See https://github.com/unicorn-engine/unicorn/blob/master/bindings/python/sample_x86.py#L103 for an example of this. In flare-emu, it loads the executable binary in Unicorn similar to how the operating system would load it in process memory. It reads the executable's headers and maps the executable's segments to the emulator's memory. See https://github.com/mandiant/flare-emu/blob/master/flare_emu.py#L1484 for how it does this.
Good luck!

thank you very much
Just one last question if possible
Do you know how to initialize the ebp register with multiple arguments before emulation?
I don't see any example on Unicorn
Thanks

You are welcome! For your last question, that is not how the x86 architecture works. General purpose registers such as ebp can only hold a single 32-bit value.  There are a lot of free resources on the internet to help you learn it. Here is one example: https://opensecuritytraining.info/IntroX86.html


AttributeError: 'Trainer' object has no attribute 'meta_val_interval'

when i run training code：bash scripts/train/resnet18.sh，
have a problem;
ERROR - FSL training - Failed after 0:04:19!
Traceback (most recent calls WITHOUT Sacred internals):
File "/home/data/qinyanfei/code/TIM-master/src/main.py", line 118, in main
if (epoch) % trainer.meta_val_interval == 0:
AttributeError: 'Trainer' object has no attribute 'meta_val_interval'
can you answer me？

This should be fixed. Please pull again and let me know if you still face problems.
Malik


999 classes?

After running gen_urls, the clist.csv file contains class ids from 0 to 998. It seems as if there's one class that is not present in the file to round it up to 1000 classes. Is this a normal behaviour?
Thanks

Got the bug! the crane category is repeated. Apparently, there are two types of cranes (tool and animal) with different synsets, but with the same name.


Add fontColor to list of profiles pleaaaaaase!

Description of the new feature/enhancement

Proposed technical implementation details (optional)

You must be looking for foreground.


[Jetsnack] Add an example ViewModel to SnackDetail

Fixes #565
Implemented a contrived simple ViewModel for the SnackDetail screen.
It is obviously up to you if you actually want this change merged in, I just did it as part of my learning and thought it might be useful for others. I would also be happy to convert it to using LiveData or StateFlow if that would be a better example but thought I would keep it simple in the first pass.
The ViewModelFactory code was taken straight from Jetcaster in order to be consistent.

Hey Ben, thanks for your contribution. As this adds nothing new (the tricky stuff comes from Jetcaster), and the implementation of the VM is as simple as it gets, I would rather keep Jetsnack simple.
Keeping the PR open for other thoughts.


For google page i.e the url https://google.com - LetXPath fails to fetch the xpath for google searchbox or any random elements on that page

Describe the bug
https://google.com - > Unable to capture xpath for this page
To Reproduce
Steps to replicate the behavior:

Go to 'https://google.com'
Do right click on google search box and go to inspect element
LetXPath fails to fetch the xpaths.

No message is displayed. Please display the message if something went wrong or if it is inside the iframe.
Expected behavior
It should display a message if the google page or any page is inside the iframe.
For eg: This element might be inside iframe from different src.
Screenshots

Hi singhvk3004 , after installing kindly restart the browser. Navigate to google or any page and then open your devtools.
I don't think there is an issues, please refer the attachment below.
Thank you.

Hi singhvk3004 , after installing kindly restart the browser. Navigate to google or any page and then open your devtools.
I don't think there is an issues, please refer the attachment below.
Thank you.

Might be , please check once how it behave if any elements is inside the iframe tag and try to inspect the element. We might need to add message in such scenario..

Yes, elements can be found within the iframe but as of now message is not shown.
Thanks for the input, definitely I will do it ASAP.
Thanks for trying out LetXPath. Have  a great day, cheers 👍


Using ipywidgets

Is it possible to use ipywidgets inside Azure Data Studio? I was using an existing Python installation that already had widgets enabled, but when I tried running notebooks with widgets, instead of the widgets being rendered, I got output similar to this:
Text(value='foo')

This usually happens in regular Jupyter if this command has not been run
jupyter nbextension enable --py widgetsnbextension

Is this a bug or are nbextensions unsupported in Azure Data Studio?

... or am I, perhaps, missing a step in the set-up?

We're looking into adding ipywidgets support into Azure Data Studio, but don't have support as of yet unfortunately. It is on our list of experiences to support in the future.
We'd love to hear how you use ipywidgets to get an idea of how we can prioritize this work.

I frequently use notebooks for ad hoc report generation where the widgets are used to specify, say, a date range. This is also useful for exploratory data analysis.
Also, I feel Azure Data Studio could replace JupyterLab and be a more natural fit for me at work given I'm working on the Microsoft stack, and I use many other MS development tools (e.g. Visual Studio, Visual Studio Code, SQL Server Management Studio). I'm moving away from the latter now that Azure Data Studio has more functionality.
Other use cases:

Interactive charts and visualizations
Experimentation for machine learning (e.g. browsing through a data set and testing my model's predictions)
Various ad hoc tools for specific use cases (e.g. browsing through an application's communication logs, which are stored in file system files with each payload recorded as a file)

Would be very useful too for compatibility with more notebook widgets. For example, qgrid requires enabled the ipywidgets and nbextension. This widget is very useful to render DataFrames from the pandas library.

It's 2022 and this still seems to be an issue.
I'm attempting to find the right environment for a small team to collaborate on data science projects, and thought Data Studio would be a nice fit since it helps us manage the database. My use case is similar to those above -- experimentation and making interactive data visualizations.


Generic Attributes -> Generic types are not valid.

So, I was looking to find a way to better document expected responses to various messages. So, I created an attribute to document what the expected response would be for a particular message.
Source/destination types
/// <summary>
/// Defines what type of message should be expected in return.
/// </summary>
/// <typeparam name="T"></typeparam>
public class ExpectedResponseTypeAttribute<T> : Attribute
{
}

It would typically be used, like so.
[ExpectedResponse<MyResponse>]
public class MyRequest {}

public class MyResponse {}

However, it appears Newtonsoft does not appreciate this attribute, containing a generic type.
Source/destination JSON
The resulting JSON does not contain anything regarding the issue here. Attributes are not included in generated JSON at all.
Expected behavior
Expected- It just works.
Especially since the attribute itself, is not actually included in the generated json, nor would you expect it to be deserialized.
When you serialize a class, its attributes are not included in the resulting JSON, as such, I don't expect exceptions to occur when deserializing something, that includes an attribute that would not be used anyways.
This feature was introduced in c# 11
https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/proposals/csharp-11.0/generic-attributes
Actual behavior
at System.RuntimeTypeHandle.CreateCaInstance(RuntimeType type, IRuntimeMethodInfo ctor)
at System.Reflection.CustomAttribute.GetCustomAttributes(RuntimeModule decoratedModule, Int32 decoratedMetadataToken, Int32 pcaCount, RuntimeType attributeFilterType, Boolean mustBeInheritable, IList derivedAttributes, Boolean isDecoratedTargetSecurityTransparent)
at System.Reflection.CustomAttribute.GetCustomAttributes(RuntimeType type, RuntimeType caType, Boolean inherit)
at Newtonsoft.Json.Utilities.ReflectionUtils.GetAttributes(Object attributeProvider, Type attributeType, Boolean inherit)
at Newtonsoft.Json.Serialization.JsonTypeReflector.GetAssociateMetadataTypeFromAttribute(Type type)
at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
at Newtonsoft.Json.Serialization.JsonTypeReflector.GetAttribute[T](Type type)
at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
at Newtonsoft.Json.Serialization.DefaultContractResolver.CreateContract(Type objectType)
...

Steps to reproduce
  public class TestAttribute<T> : Attribute { }
  [Test<string>]
  public class TestClass{}

      static void main()
      {
          var output = Newtonsoft.Json.JsonConvert.SerializeObject(new TestClass()); <- Exception HERE.
          Console.WriteLine(output);
          JsonConvert.DeserializeObject<TestClass>(output);
      }

Resulting exception-
   at System.RuntimeTypeHandle.CreateCaInstance(RuntimeType type, IRuntimeMethodInfo ctor)
   at System.Reflection.CustomAttribute.GetCustomAttributes(RuntimeModule decoratedModule, Int32 decoratedMetadataToken, Int32 pcaCount, RuntimeType attributeFilterType, Boolean mustBeInheritable, IList derivedAttributes, Boolean isDecoratedTargetSecurityTransparent)
   at System.Reflection.CustomAttribute.GetCustomAttributes(RuntimeType type, RuntimeType caType, Boolean inherit)
   at Newtonsoft.Json.Utilities.ReflectionUtils.GetAttributes(Object attributeProvider, Type attributeType, Boolean inherit)
   at Newtonsoft.Json.Serialization.JsonTypeReflector.GetAssociateMetadataTypeFromAttribute(Type type)
   at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
   at Newtonsoft.Json.Serialization.JsonTypeReflector.GetAttribute[T](Type type)
   at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
   at Newtonsoft.Json.Serialization.DefaultContractResolver.CreateContract(Type objectType)
   at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
   at Newtonsoft.Json.Serialization.DefaultContractResolver.ResolveContract(Type type)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.Serialize(JsonWriter jsonWriter, Object value, Type objectType)
   at Newtonsoft.Json.JsonSerializer.SerializeInternal(JsonWriter jsonWriter, Object value, Type objectType)
   at Newtonsoft.Json.JsonConvert.SerializeObjectInternal(Object value, Type type, JsonSerializer jsonSerializer)
   at Newtonsoft.Json.JsonConvert.SerializeObject(Object value)

With Error Message: "Generic types are not valid."

Not reproducible using Newtonsoft.Json 13.0.3 and the sample code given in your report.
The sample code outputs the expected {} and throws no exception.
For reference, these are the project settings i used:
<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>net8.0</TargetFramework>
    <ImplicitUsings>enable</ImplicitUsings>
    <Nullable>enable</Nullable>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
  </ItemGroup>
</Project>

Not reproducible using Newtonsoft.Json 13.0.3 and the sample code given in your report. The sample code outputs the expected {} and throws no exception.
    <TargetFramework>net8.0</TargetFramework>

I wonder, if perhaps, this is something specific to older framework apps. I noticed this issue on an app running .net framework 4.8.
The message it received, was successfully serialized without issue from an app running .NET 8.
But, upon deserializing it, it failed on the framework 4.8 app... Let me test this...

Yeah, .NET Framework 4.8 is quite likely way too old. I believe (although i am not 100% certain) generic attributes require support by the runtime, particularly how attribute data is represented in the CLR.

Testing with my example code-
using ConsoleApp1;
using Newtonsoft.Json;

var output = Newtonsoft.Json.JsonConvert.SerializeObject(new TestClass());
Console.WriteLine(output);
JsonConvert.DeserializeObject<TestClass>(output);
Console.WriteLine("Worked here.");

Yields this, on .NET 8
{}
Worked here.

Making a few minor changes....
<Project Sdk="Microsoft.NET.Sdk">

	<PropertyGroup>
		<OutputType>Exe</OutputType>
		<TargetFramework>net48</TargetFramework>
		<LangVersion>preview</LangVersion>
		<ImplicitUsings>enable</ImplicitUsings>
		<Nullable>enable</Nullable>
	</PropertyGroup>

	<ItemGroup>
		<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
	</ItemGroup>

</Project>

So, confirmed, this is specific to .net framework, and does not affect newer .NET.

It's not an issue of the Newtonsoft.Json library and not something the library can resolve. Generic attribute types are basically a feature that is dependent on the runtimes of recent .NET versions and/or their respective BCL implementations.
Using <LangVersion>preview</LangVersion> only allows you to use newer language feature that do not rely on new features of the CLR or BCL. Note that <LangVersion>preview</LangVersion> enables preview features the used C# compiler supports, and that includes enabling language features the compiler supports but the targeted framework version does not support.

Issue closed.
Resolution, Update old applications, off of .net framework.


ci: Publish ebpf builder helper image

Fixes: #1420
It uses the same idea of #1472 and will only:

Build images if changes are detected
Publish images if variable PUSH_HELPERS = ENABLE_PUSH_HELPERS is defined (it helps avoid issues with external contributors PR)
Publish images for each release

Testing done

Fork: A test commit result in helper image being built and used here.
Release: A test release (v0.10.0) publish the tags here.

Todo

[ ] Claim ownership of https://github.com/orgs/inspektor-gadget/packages/container/package/ebpf-builder since it belongs to Inspektor Gadget org (or someone who created it) not repo.
[ ]  Use the published release image here. (Should we? Separate PR?)

I think we should with the following rule:
* If VERSION is a release, use that tag by default

* If not, use `latest` by default

I think it if the image is modified by a PR, then the built image for that specific PR should be used, otherwise it'll be impossible to implement PRs that modify the image and the gadgets (as https://github.com/inspektor-gadget/inspektor-gadget/pull/2107) without having a "REMOVE BEFORE MERGE" commit pointing the image to something else.

Btw, I rebased https://github.com/inspektor-gadget/inspektor-gadget/pulls on top of it so we can check with a real example if it's working fine :D

I see it failed because of missing patterns, I updated the list and now it looking better with PR on fork!

I merged this one and we can track arm64 in https://github.com/inspektor-gadget/inspektor-gadget/pull/2139


Align the token Negotiation V1 / V2 Solution Liscon

This task is to resolve a path to full migration to version 2 of the token negotiator.
Issue located whilst debugging the current solution in examples:
Token Negotiator V1 and V2 use a different communication protocol. V2 loads tokens from this event - where V1 does not emit this event - if (event.data.evt === 'setTokens') {

Closing this ticket - approach confirmed in the meeting


Add nest-asyncio to allow execution in Jupyter notebooks

https://github.com/erdewit/nest_asyncio

Should not be implemented in mure itself


Minor pecan fixes

Updates cdb
Adds a loader while the style is being applied
Fixes a bad written reject condition.

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)


Update demo site with new versions

Update demo site with new versions

Hi, the new version is fantastic, but the color of the text in the form elements is very clear and can not be read properly. Thanks

Solved also @battoualex comment. Thanks!


Bump Dependencies

I ran into an issue upgrading dependencies from dependabot, since we had a lot of upgrades that would require upgrading multiple libraries at once, even if their version specifiers don't indicate so. This was particularly true for webpack dependencies. On top of that, many things need to be bumped and rewritten in bulk, such as the react dependencies. I went through and made bumps for all those, each "group" in a commit.
Most commits have just been version changes with no code changes, but here are the ones that did change code:

618ed04d: Husky rewrote it's format... again... I just regenerated the same hook
bd47dceb: The library we use for transforming SVGs in tests hasn't had an update in half a decade, and it doesn't work with the latest version of jest. We don't actually need it though, I removed it, and added a simple transformer that achieves the same thing.
66cb2362: We now need to set the test environment to jsdom explicitly

8c286b09: jsdom-fourteen is no longer necessary, since the jsdom library published by jest has the same features, and jsdom-fourteen is archived

52e6fe41: Import has been renamed
5f4ddc8f: Bumping react to v18. This is a large breaking change, and required updating our code. It also required updating react-related libraries such as router, which required more changes. Changelogs for both are attached in the commit

Netlify is being wonderful and using node 12. I've bumped us up to 16.


Count the hit times of materialized view

Feature request
Is your feature request related to a problem? Please describe.
A base table may have many materialized view
Describe the solution you'd like
Make statistics of such views or rollups, and clean them regularly to release resources
Describe alternatives you've considered
none
Additional context
A base table may have many materialized views, but some of them have not been used for a long time, but they occupy resources. Make statistics of such views or rollups, and clean them regularly to release resources

That's a good suggestion

Hello, I would like to know how is the progress of this function? We happen to have this need too.

it'll be got scheduled this month.

Hello, I would like to know how is the progress of this function? We happen to have this need too.

may i ask, what about your requirement about this ?


Upgraded Alpine Linux version to 3.8

Upgraded Alpine Linux version to 3.8

going to upgrade to alpine:3.8 on next Java 8 release, thanks @lospejos

upgraded to 8u192b12 and alpine:3.8


Cleanup travis output

Maven warnings and redirect output

Prior https://travis-ci.org/square/okhttp/builds/342666412

n.b. Build failure happened earlier this week on master, so looks like a flaky build.
https://travis-ci.org/square/okhttp/builds/342702941


ERROR : Got a scan that has FOV 106 smaller that threshold 270

Hello ,
I have been exploring the use of this package. I am getting the following error.
ERROR extensions/localization/flatscan_localization/grid_search_localizer.cpp@306: Got a scan that has FOV 106.000000 smaller than threshold 270.000000, ignoring this scan.
My scans are clipped not to see the back of the robot , ~300 FOV. The angle ranges in the flat scan does look right from -3.0 to + 3.1.
Sandeep

It looks like the FOV is computed to be 106 from the FlatScan msg. Can you please post the FlatScan msg for this error comes up?
Note: min_scan_fov_degrees parameter here: https://github.com/NVIDIA-ISAAC-ROS/isaac_ros_map_localization#ros-parameters

Hello Ashwin,
Is there a way to capture the scan that caused the problem ? If I capture all scans it will be large.
Sandeep

If you can provide a small rosbag + map(.png+.yaml) and launch file, I can try to reproduce this on my end. Then I look into it this issue further.

sorry about the delay .I have attached a rosbag and the map. Please let me know if you anything else to reproduce.
rosbag.zip

"map.yaml"
image: upper_corridor.png
mode: trinary
resolution: 0.05
origin: [-2.94, -1.64, 0]
negate: 0
occupied_thresh: 0.65
free_thresh: 0.25


Rename core get & set functions

Rename get_skin_data and set_skin_weights to extract_skin_data and apply_skin_data.
This makes the convention consistent and removes confusion with export, save and load which can imply reading and writing to disk.

Resolved in: https://github.com/munkybutt/SkinPlusPlus/commit/0dc13207fe379dba7151d14acab59533a175f7a8


Package for Homebrew

See https://til.simonwillison.net/homebrew/packaging-python-cli-for-homebrew

I have a hunch this will be difficult, because Playwright is a bit of a weird dependency and it doesn't look like anyone else has packaged something for Homebrew that depends on it.
https://cs.github.com/?scopeName=All+repos&scope=&q=path%3AFormula%2F**+playwright showed me one repo that mentions Playwright but I don't think it uses it:
https://github.com/jphastings/homebrew-tap/blob/8819693f5f32d2df7d3366d6ea0c14b587e3402b/Formula/gsts.rb#L15

I don't think this will be possible: https://docs.brew.sh/Acceptable-Formulae#we-dont-like-binary-formulae

We don't like binary formulae
Our policy is that formulae in the core tap (homebrew/core) must be open-source with an Debian Free Software Guidelines license and either built from source or produce cross-platform binaries (e.g. Java, Mono). Binary-only formulae should go to homebrew/cask.

This is why Python dependencies are meant to be sdist and not wheels. But Playwright only provides wheels, because it bundles a binary Node.js inside itself: https://pypi.org/project/playwright/#files
My hunch is that shot-scraper isn't really compatible with the Homebrew way of doing things, sadly.


Settings  doesn't open

Latest source code, compiled ok.
System.Windows.Markup.XamlParseException: 'Provide value on 'System.Windows.Markup.StaticResourceHolder' threw an exception.'
Inner exception
Exception: Cannot find resource named 'SystemAccentColorPrimary'. Resource names are case sensitive.
System.Windows.StaticResourceExtension.ProvideValueInternal(System.IServiceProvider, bool)
System.Windows.StaticResourceExtension.ProvideValue(System.IServiceProvider)
MS.Internal.Xaml.Runtime.ClrObjectRuntime.CallProvideValue(System.Windows.Markup.MarkupExtension, System.IServiceProvider)

Exception thrown at:
// No Window Found, open a new one
T newWindow = new T();
newWindow.Show();
return newWindow;

@andersberglund what version of Visual Studio are you running? and what version of Windows are you running?

This looks like it's my bad. I copied the new source over the old and that probably clashed with something and caused the problem.
I copied the source to a new folder and it now works as supposed.
Sorry  if I gave you some unnecessary work. 🙄


Some fun side activity for the hackathon

🚧 First very hacky version 🚧
Based on https://www.nytimes.com/games/wordle/index.html and a clone implementation from https://github.com/WebDevSimplified/wordle-clone

pipeline wordle runs for all pipelines names (even >5 letters). To make it a bit easier it allows also entering shorter pipeline names, to get more hints.

started with module version

Known bug: If a letter is entered twice and one of the instances is actually on the right position, the incorrect occurrence does still flip to orange (for example when the right word is "chipseq" and I enter "cageseq" both "e"s are orange), because each letter is tested individually without knowledge about the others. I would be thankful, if somebody knows how to solve this elegantly.

I removed  the modules section and moved everything in one file.
Copies the emoji summary of the guesses at the end of the tries (=win or lose), e.g.:
nf-cordle 1
🟨🟨⬛🟨🟨⬛
🟨🟨🟨🟨⬛⬛
🟩🟩🟩🟩🟩🟩
New pipeline name available every 12 hours (3am and 15pm CET for now)
Doesn't save the state in a cookie, so you have multiple tries and no state is saved...

I guess the easiest to test it would be to deploy it on the live server, so that people from the outreach team can play with it.


Update Summary.py For Mixed Graphs

Summary.py currently utilizes networkx to summarize the outputted file paths. The issue with networkx is that its library does not handle mixed directionality. As a result, summary.run appears to be useless for the time being and has been commented out until the code is updated to operate on mixed graphs. summary.run computes degree, nx.clustering, and nx.betweenness_centrality; however, when the graph is mixed, picking either directed or undirected makes no sense. We maintained summary.summarize_networks as an undirected graph because it was initially used to derive its information. The information it returns is valuable and does not require directionality to explain the information it returns.
This will hopefully be an easy future summer project for a new incoming researcher

Implementing this would require either using a different Python graph package that supports mixed graphs or implementing the graph summary statistics from scratch using our own graph data structure that supports mixed graphs.


How does SWE-agent find the issue # or pull request # to fix the bug?

Describe the issue
I'm currently trying to prompt the agent to generate dependency graphs, and the agent is able to execute the curl command accordingly.
The command looks like this ./generate_graph.sh pytest 7490 pytest-dev and the middle number is supposed to be the PR # that is extracted from the instance id.
However, when I run the agent, it runs like this:
ACTION (primary)
generate_graph pytest placeholder pytest-dev

or mentions that a PR # was not provided.
Is there anywhere I should look to see how the agent finds the PR # or issue # to be fixed? I'm a little confused because the PR # is explicitly stated in the dataset, and I assume that dataset is fed to the agent.
Thank you!
Optional: Relevant documentation page
No response

The number in the instance ID (e.g., "django__django-16379") is the number of the PR, so you could use that. But the agent of course has all of the information from the dataset that it loads (the --data_path file which loads SWE-bench light dev-set by default).

The number in the instance ID (e.g., "django__django-16379") is the number of the PR, so you could use that. But the agent of course has all of the information from the dataset that it loads (the --data_path file which loads SWE-bench light dev-set by default).

Right, I was using that to get the PR # for my own experimentation. However, the agent seems confused and does not know where to get the PR number, is there a specific code file where it is broken down? I was just wondering how it was handled in the backend

More so asking how to prompt the agent to use that number

Currently I have
        instance_id = self.env.data[index]["instance_id"]
        # Extract and print the PR number
        pr_number = instance_id.split('-')[-1]

And
setup_args = {"issue": issue, "files": files, "test_files": test_files, "tests": tests, "pr_number": pr_number }

However the agent still seems to be confused


Design UI explaining Google OAuth screen

As a developer, I need to make sure that the user understands the Google OAuth screen to give all the permissions the app needs to function correctly.
Design a UI that explains to the user how to check the permissions in the google OAuth screen and why we use them.
Design a UI that explains to the user the account was not connected because it did not give the app all the needed permissions.
Acceptance criteria
1 - Approved design

#77 detects if the user has checked all boxes. For better UX, we don't need to explain the user before the login, we just explain if there's an error and we can't move forward without all permissions.


Web hook validation fails

It's hashing with the API key.  It needs to be using the shared secret for the web hook.  I hardcoded mine for now but I'll try to modify the configuration form and update the validation method.  Is this being actively enough maintained that I can just do a pull request when it's done?  I've never done one before but it looks straightforward.

I issued a pull requires for this let me know if this can be addressed.

Hey @breandan81, this has been fixed in the latest code. Stay tuned for the latest release.


Standardize on using created instead of timestamp

Details
Refactors App to use created instead of timestamp
cc @roryabraham
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/240878
Tests

Send a few messages to another user
Verify that the messages are grouped and appear with the correct time
Wait 5+ minutes
Send another message and verify that your avatar and name show up and the message has the correct time

Android-specific tests

Sign into the Android app
Sign into another account on web and upload a custom profile picture for that account
Background the Android app
Send a message from the account signed in on web to the account signed in on Android
Verify that a push notification appears and that the notification appears a message style notification, including the avatar image of the web user.

[x] Verify that no errors appear in the JS console

QA Steps
Same as test steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@mananjadhav this will fail right now since the date format returned by the API is invalid for the changes in this PR. We'll ping you once it's ready for you to test!

@roryabraham I'm going ooo until Nov 22, could you help push this through the finish line please?

@Julesssss this is ready for review if you just check out https://github.com/Expensify/Web-Expensify/pull/35486 first

This tested well on all platforms, but I had to log out first n a couple of devices before the chats would load, is that expected? 😕

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Android

Android mWeb

iOS

iOS mWeb

Desktop

Web

@Julesssss  @roryabraham  Can I test this? or it can only be tested locally?

@Julesssss @roryabraham Can I test this? or it can only be tested locally?

For now this is only testable with our dev environment.

I had to log out and back in again first before the chats would load, is that expected?

That is not expected. Are you sure it's related to this PR?

I'm not 100% certain that it was these changes, but it occurred on all 6 platforms. Let's ignore if it's not reproducible for others though

@Julesssss I think the skeleton UI not fading is this issue and unrelated to this PR.

@Julesssss I saw a similar error on staging:

I also saw that I was getting 404's back from the API for all my reports:

Signing out and back in fixed it. So I'm pretty certain that the error you saw was unrelated to this PR and is already out in the wild

This is off hold and ready for review/merge

This is off hold and ready for review/merge

Even for C+ review ?

Yes, the related API PR was deployed to staging

Bump for reviews plz. This PR is blocking other work

I just reviewed the code. Going through the code to see if we've missed any references and will start with the testing then.

@Julesssss @roryabraham @luacmartins I was testing this and I've got one blocker.
Unfortunately I couldn't get a physical Android device where I could received the Push Notifications for now. The chat timestamps etc, work fine but the PN avatar image I am unable to test.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] iOS / native
[ ] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Unfortunately I couldn't get a physical Android device where I could received the Push Notifications for now. The chat timestamps etc, work fine but the PN avatar image I am unable to test.

No worries, I'm certain I tested that, but I'm going to test once more quickly to confirm.

Thanks @Julesssss I've then completed the reviewer checklist.

Damn, actually I'm going to run out of time for this today.

Verify that a push notification appears and that the notification appears a message style notification, including the avatar image of the web user.

@luacmartins did you need a release build in order to test this?

Web-E was deployed to prod last night so I can now test this with a release build. We're still blocked on merging this though:

Verify that a push notification appears and that the notification appears a message style notification, including the avatar image of the web user.

This test fails btw. I'm not seeing the profile pic on either Android device -- though part of me thinks that this has been broken for a while.
@roryabraham @luacmartins please let me know if there was a better way to run the Android notification test.

This test fails btw. I'm not seeing the profile pic on either Android device -- though part of me thinks that this has been broken for a while.

I confirmed that this is currently not working on staging, so I don't think that this is something that was broken by this PR. We should make sure we create a follow-up issue to fix that.

The PR reviewer was filled out here, but the action to verify that has recently changed (along with the PR reviewer checklist itself, if I'm not mistaken).

Not an emergency, see last comment

This is Failing on main
FAIL tests/unit/DateUtilsTest.js
  ● DateUtils › should return the date in calendar time when calling datetimeToCalendarTime

    expect(received).toBe(expected) // Object.is equality

    Expected: "Nov 5 at 10:17 AM"
    Received: "Nov 5, 2022 at 10:17 AM"

      34 |
      35 |         const date = moment.utc('2022-11-05').set({hour: 10, minute: 17});
    > 36 |         expect(DateUtils.datetimeToCalendarTime(LOCALE, date)).toBe('Nov 5 at 10:17 AM');
         |                                                                ^
      37 |     });
      38 |
      39 |     it('should return the date in calendar time when calling datetimeToRelative', () => {

      at Object.<anonymous> (tests/unit/DateUtilsTest.js:36:64)

Fix here https://github.com/Expensify/App/pull/12884

🚀 Deployed to production by @luacmartins in version: 1.2.30-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@luacmartins @roryabraham This is ready for C+ review payout. Can someone please help here? The linked issue is not an App issue so can't comment there.

Handled here @mananjadhav https://github.com/Expensify/App/issues/13234


USB device not recognized, ItsyBitsy M0 Express, Windows 10

Hi,
I have two ItsyBitsy M0 Express boards.  One seems to be broken, and the other works fine.  The apparently-broken one isn't recognised by Windows 10 when connected via USB.  I've tried connecting it to two different Windows 10 computers, both behave the same.  Using the same USB cable, Windows recognises the other Itsy, and used to recognise the apparently-broken one.
I might have done something bad while developing on the broken one.  I was getting it to print debugging messages in an unrestrained loop (with no "wait" command).  At some stage I saw a "safe mode" message, but being really deep in the problem I was debugging, I didn't want to change focus, so pay much attention.  I hit the reset button, it came back up, then died again shortly after, never to return.
When I connect the broken one to my PC, a message pops up saying "USB device not recognized - The last USB device you connected to this computer malfunctioned, and Windows does not recognize it."

And in Device Manager, it says "Unknown USB Device (Device Descriptor Request Failed)"

Is there anything I can do?

@dhalbert sorry to keep bugging you - is there any further advice you can offer on this issue? (And by the way, thanks for supporting the community :)

Sorry for not replying earlier! Have you tried this on another computer? If it still doesn't work, maybe there is something wrong with the "bad" board. Could you post in the forums about this? We can see about getting you a replacement there. Post a link to the forum thread here.

Thanks Dan, I've tried the boot copy procedure on a couple of Windows 10 machines now, with the same results. Thank you for your help with this.

Adafruit support conversation: https://forums.adafruit.com/viewtopic.php?f=62&t=162018

We'll work with your on a replacement. Continuing the conversation in that thread.


Add a forc call command for calling contract methods

Currently, forc-client provides basic support for:

deploying contracts (forc deploy) and
running scripts (forc run)

However, there's no way to call a deployed contract's ABI method.
This could be useful e.g. for testing locally deployed contracts from the command line.
Rough thoughts
An invocation might look something like:
forc call --contract-abi "out/debug/my-contract-abi.json" --contract-id "..." --method-id "..." arg1 arg2 arg3

I'm not 100% sure how we determine the method ID just yet (or if that's how we want to refer to methods).
I imagine we'll need to know about the contract's ABI.
W.r.t. handling arguments, we could consider following suit with #3439.

I'm not 100% sure how we determine the method ID just yet (or if that's how we want to refer to methods).

The function selector is basically the method ID but that's not present in the JSON ABI. I suggest relying on just the name of the method given that it's in the JSON ABI and it uniquely identifies a contract method (no overloading!).


Separate out the provider of repositories (GitHub) from the building code

Should make it trivial to add more sources in the future (such as bitbucket)

We do this now!


fix: php 8.0 pdo will check the flag bit (#159)

ref: https://github.com/cectc/dbpack/issues/
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #163 (c90edee) into dev (2745593) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #163   +/-   ##
=======================================
  Coverage   42.29%   42.29%
=======================================
  Files          73       73
  Lines        8342     8342
=======================================
  Hits         3528     3528
  Misses       4483     4483
  Partials      331      331

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2745593...c90edee. Read the comment docs.


added few announcements tests

Test coverage

[x]  Compose does not show for unauthenticated users
[x]  Compose shows for admins and moderators users
[x]  Contract call is correct after commit
[x]  Comment button is visible
[x]  Like button is visible
[ ]  A post shows in feed (socialdb query)
[ ]  A comment shows on post in feed (socialdb query)
[x]  A post shows in feed (near-query-api query)
[x]  A comment shows on post in feed (near-query-api query)

@elliotBraem I m not sure how can I add separate tests for near-query-api and social-db query..?
I have added other required tests

The tests look good. We will merge the announcement PR first, and then you can test against the develop branch.


--citation yields blank output

Looks like this command does not work any more:
py scholar.py -c 1 --author "albert einstein" --phrase "quantum theory" --citation bt

I got confused with the scholar project. It must be too late, sorry for that.


Update almel19.json

some updates and tests

You have conflicts in your file, please resolve. This is usually because your fork is not up to date.
You may wish to have a look at the following Docs and video: https://linkfree.eddiehub.io/docs/how-to-guides/editing

I don't know what happened. I clicked sync fork before editing the file, passed the checks and there where no conflicts with the base branch

I will merge as there are no longer any conflicts.


Create an Account on the Gateway Demo System

Tutorial URL: https://developers.sap.com/tutorials/gateway-demo-signup.html
Please specify the step you are referring to:
How do sap employees login as we have a single sign-on in sap.com?
Thanks,
Mary Jose

You would need to go through the same flow that is described here, there is no SSO :)


Normlize command

Implementing #16

Coverage decreased (-0.3%) to 94.208% when pulling cd081945c4896f9e6676fe3e6b9d79bacea26137 on normlizeCommand into<PHONE_NUMBER>15b637c121b3a4e485465b597d2be3 on master.

Coverage increased (+0.5%) to 94.981% when pulling 2971a22f93d4d98704d877a990ea2c4a097a69c6 on normlizeCommand into<PHONE_NUMBER>15b637c121b3a4e485465b597d2be3 on master.

close #16


Update gitsign 0.3.1

Summary

Update gitsign 0.3.1 - https://github.com/sigstore/gitsign/releases/tag/v0.3.1
Release Note

Update gitsign 0.3.1 - https://github.com/sigstore/gitsign/releases/tag/v0.3.1
Documentation

Always forget to do that 🙃
Done!

checking what is going on with ci

releated to https://github.com/actions/runner-images/issues/6283
will check a workaround

this fixes: https://github.com/sigstore/homebrew-tap/pull/70


Vault commands slow when using the load balancer address.

Vault commands take some 5 - 15 seconds to process. This eventually works, but is annoying.
Any vault command results in:
uname({sysname="Linux", nodename="ip-172-16-127-35.eu-west-1.compute.internal", ...}) = 0
epoll_pwait(4, [], 128, 0, NULL, 138566752) = 0
futex(0x4000094550, FUTEX_WAKE_PRIVATE, 1) = 1

NOTE: The nodename is set to ip-172-16-127-35.eu-west-1.compute.internal. That's not correct, should be the external address. (api_address).

From now on a loop starts: (Likely causing the delay.)
--- SIGURG {si_signo=SIGURG, si_code=SI_TKILL, si_pid=1797, si_uid=0} ---
rt_sigreturn({mask=[]})                 = 1

The api_addr is set correctly in /etc/vault.d/vault.hcl:
api_addr          = "https://dev.robertdebock.nl:8200"

Maybe the node_id causes this behaviour:
storage "raft" {
  path    = "/opt/vault/data"
  node_id = "ip-172-16-127-35.eu-west-1.compute.internal"

The load balancer returns 3 IP-addresses, 2 of these do not pass TCP port 8200:
Works:
robertdb@MacBook-Pro-van-Robert terraform-aws-vault % telnet <IP_ADDRESS> 8200
Trying <IP_ADDRESS>...
Connected to ec2-34-247-75-149.eu-west-1.compute.amazonaws.com.
Escape character is '^]'.
^]
telnet> c
Connection closed.

Broken:
robertdb@MacBook-Pro-van-Robert terraform-aws-vault % telnet <IP_ADDRESS> 8200
Trying <IP_ADDRESS>...
telnet: connect to address <IP_ADDRESS>: Operation timed out
telnet: Unable to connect to remote host

Broken:
robertdb@MacBook-Pro-van-Robert terraform-aws-vault % telnet <IP_ADDRESS> 8200
Trying <IP_ADDRESS>...
telnet: connect to address <IP_ADDRESS>: Operation timed out
telnet: Unable to connect to remote host

Only one subnet has a route set to the internet gateway.

Fixed in release 3.0.1.


I spotted an issue with the "Shortcut mode"

Hello, I spotted a bug with the "Shortcut Mode (no letters no and no shift)". When I select that mode and press any keyboard letter it would show the black window that is blank and then it won't go. I have recorded a small video to show what it is. Its in AV1 so ping me if you can't play it.
https://user-images.githubusercontent.com/9980686/210401137-0e7f5676-ec2e-4e2f-8100-018d83629a1b.mp4
Another bug is that it won't disappear once triggered by the above way. It will only go away if a short cut is hit.
https://user-images.githubusercontent.com/9980686/210401405-927cd403-c59f-4b5b-a983-cf3c8abd292c.mp4
If you need my settings here they are.

If I can help in anyway let me know!

I've submitted a pull request for this.
https://github.com/Phaiax/Key-n-Stroke/pull/103


langchain: fix create failed when using AsyncOpenAI to create OpenAIAssistantRunnable

fixed https://github.com/langchain-ai/langchain/issues/20436
the OpenAIAssistantRunnable.create_assistant will create the client object as default, it's not neccessary to set default_factory to the client, because when I use async_client the client isn't neccessary

Will this break things for users relying on the default? I think that is undesirable compared to passing in an unnecessary client. Closing for now, can discuss on linked issue.


Varnish Version Updates

Currently we ship Varnish 5.2.1 in our varnish images amazeeio/varnish which is the default in alpines 3.7 repos - https://pkgs.alpinelinux.org/packages?name=varnish&branch=v3.7
~ > docker run -it amazeeio/varnish:latest varnishd -V
varnishd (varnish-5.2.1 revision 67e562482)

Currently the last releases are 6.3 and 6.4 - https://varnish-cache.org/docs/index.html
We should discuss how we move forward with newer varnish versions as the 5.2.x are marked as deprecated by Varnish.

Varnish 5 and 6 now available in lagoon-images


update search method arguments

Search class does not exist, $manager->search method updated to reflect its argument list.

Hello would you like me to close this pull request or is your intention to merge it?

Since I have not heard from you on this, I have to assume your priorities have changed.


missing curly bracket Custom Widget step 6

Under the Web App Builder Custom Widget, step 6. there is a missing ending curly bracket. I spent a long time trying to figure out why this wasn't working! thanks

Thanks for the heads-up, we'll take a look!

closed via 7f4cdc3f5d1159032a06052167a9f22cbbaec120
thanks for taking the time to report and sorry for the confusion @suname33!


install turborepo

first crack at getting turborepo set up. if i've done this correctly (big if), this will make things like docs PRs much faster to get through CI, since we can replay remote caches for unchanged packages rather than re-running the entire CI workflow every time. similarly, tweaking a changeset shouldn't cause another 10 minute wait to get a bank of green lights.
to take advantage of this, we need to do e.g. pnpm turbo run lint instead of pnpm lint. i haven't perfectly preserved all the --filter options we had in place previously, since in theory if everything is cached we can be more relaxed about that sort of thing

once this is merged, we should update the build commands on vercel (on both projects) to use pnpm turbo run build rather than pnpm build -r


Kiali requires username and password

Kiali setup now requires a username and password to work.

This works now.


Assertion information on precompute_float8_dynamic_scale_for_fsdp is misleading

https://github.com/pytorch/ao/blob/main/torchao/float8/fsdp_utils.py#L44-L48
Should it be raise NotImplementedError("Only supports dynamic scaling")?

Yeah I think you're right, wanna just make a PR to fix this?


Store keypairs as options keyed to user IDs.

A problem we've run into for WP Multisite is that there is theoretical key leakage for a given user who is a member of more than one network blog.
Imagine example.com as a WP Multisite install. Two users, foo (ID 1) and bar (ID 2), have a shared site called foobar.example.com, while foo has a solo site, foo.example.com. Since usermeta is shared across the whole network, bar could be sneaky and retrieve foo's private key from their shared site. bar could then use that private key to sign private messages on the fediverse as though it was coming from<EMAIL_ADDRESS>rather than<EMAIL_ADDRESS>or any other site on that network on which foo is a member.
What this patch does is to migrate keypair storage to be based on blog options instead, which will keep each keypair functioning only within a single blog context per user in the network. foo will have blog options of activitypub_keypair_for_1 on both sites but it will be unique to each site.
There was no reason to not just standardize on this so I've made the Blog and Application Users use this style as well for consistency. They will receive activitypub_keypair_for_0 and activitypub_keypair_for_-1, respectively.
This is a speculative PR, put up before I went to bed while the idea was still in my head. I have not tested it other than in my head, and that it doesn't throw fatals. I'm sure it needs unit tests.

@mattwiebe thanks for preparing the PR!
I thought it might be a good idea to remove all signature relevant informations/functions from the User objects (except the public-key output for the ActivityPub-Profile) to be sure that the private key will never unintentionally displayed by a to_json or to_array function.
I also added the legacy check as one option to the generate_key_pair_for method, because it is kind of a generation of the keys using the old DB persistence.
Let me know what you think.
/cc @ebinnion

Nice refactor, gonna test this out on wpcom a bit


Spam on wiki pages.

The wiki for this project has a bunch of spam pages on it. :(

Thanks, I just restricted editing and deleted the spam pages. Very disappointed that this was necessary :(


Breaking: add cron scheduling

This PR introduces a new feature to define periodic backups using cron expressions instead of an interval in seconds.
This offers more flexibility. The new option is available through the -c or --cron CLI arguments, as well as the AWSBCK_CRON environment variable.
The old -i/--interval option and AWSBCK_INTERVAL are not supported anymore.
To perform backup based on an interval, use for instance -c "@hourly", -c "@daily" or -c "0 0 */6 * * * *".

Closes https://github.com/beeb/awsbck/issues/16


Update memory offsets and fix issues with 64-bit platforms

Reading pointers as signed integers caused them to get sign extended in IntPtr constructor on 64-bit platforms, closes #3.
Also updated offsets and improved string reading, while chat log lines will probably never be shorter than 8 characters, it can be useful in future, closes #12.

Can you make a file out of that so i can just download it? for some reason it wont work when i copy past stuffs and remove stuffs D:


Refactor integration tests - extract start/stop functionality.

Coverage increased (+0.03%) to 90.891% when pulling 7231b2943193bbdf9c2223163747aceacb4b7e17 on SAP:refactor_integration_tests into 1e4582801f602866fc814481dfff976cd5f7547e on cloudfoundry-incubator:master.

Coverage increased (+0.05%) to 90.917% when pulling 0b47fd47d54091bd387366715ee73f221aca1b4e on SAP:refactor_integration_tests into 1e4582801f602866fc814481dfff976cd5f7547e on cloudfoundry-incubator:master.


Dyson node pointing the wrong way.

Found an issue with your mod, though I'm not sure how to reproduce. Basically one node of the shell is pointing away from the sun, instead of towards it. See screenshot.

thanks for reporting this! I'll check it out after the combat update.


Avoid using global_schema for roles in I/O process

Introspect roles directly without global schema.
Include roles in QueryUnit when global_schema is updated.

Ah, the roles_intro_query could also be one of the sys_queries I guess?

Ah, the roles_intro_query could also be one of the sys_queries I guess?

Yes.  In fact, we already have it there.


Implementing with Android's LayoutTransition

The implementation of the DragLinearLayout works fine until I also implement Android's LayoutTransition.
I get this error:
java.lang.IllegalStateException: The specified child already has a parent. You must call removeView() on the child's parent first.

And I get runtime errors on these two methods in the DragLinearLayout class :
1. addView(draggedItem.view, switchPosition);  //called in on drag
2. onDrag(deltaY); // called in the onTouchEvent override method.

I stopped it crashing by overriding onTouchEvent() in my implementing activity, and setting the setLayoutTransition parameter to null on the DraggerLinearLayout when the row is touched, then in the DragLinearLayout when onAnimaitonEnd is  called,  I call a method in my implementing activity and make the setLayoutTransition() parameter not null anymore.
But this causes some lag, and on the row you're dragging when you stop the drag and let it settle, it disappears for a second and then reappears.
Is there anyway to implement the LayoutTransition, or any other recommended techniques for using animations to add rows, and for animating the incrementally increasing size of the DragLinearLayout?
Thanks in advance.

Thanks for bringing to attention. I will take a look at the issue later this week.
Meanwhile:

Since merging #8, DragLinearLayout does essentially what you describe by clearing / setting the layout transition.
The notes sample animates in rows using explicit view property animation.

Thanks for the response, I look at the changed in #8, implemented them, and it worked well.
Thanks !


Add new Framework7 / Vue.js layout templates

I added them as layout-*.
Not convinced this is the best choice... looking for opinions.

Let's wait for #706 to land first before we merge this in :)

@devgeeks here are my thoughts:
layout-blank is called Single View App in Xcode and Empty Activity in Android Studio.
layout-panel is called Master Detail App in Xcode and Master Detail Activity in Android Studio.
layout-tabs is called Tabbed App in Xcode and Tabbed Activity in Android Studio.
So I think we should eschew close to those names for the templates but remembering that we may want to add React/Preact templates in the future so I'd go with something like:
blank-app-vue
master-detail-app-vue
tabbed-app-vue

In windows :
layout-blank => 'Blank' A project for a single-page app that has no predefined controls or layout. Use this template to build an app from the ground up without any starter code
layout-panel => 'Split' A project for a two-page Windows Store app or Windows Phone Store app that navigates among grouped items
layout-tabs => 'Pivot' a Windows Phone Store app that uses a Pivot control


Where() method on Collections gives inconsistent responses on Booleans

Laravel Version: 10.1.5
PHP Version: 8.1.3
Database Driver & Version: N/A - db not required

Description:
When using where() on a Collection of objects (base Collection or Eloquent Collection) that contains booleans - the response changes to either be a keyed collection or a flat collection depending on the order of the variables.  This causes problems when passed to Inertia/other front ends:
Steps To Reproduce:
In Tinker:
$test = collect([
    (object)['value'=>true],
    (object)['value'=>true],
    (object)['value'=>false]
]);

$true = $test->where('value',value: true);
$false = $test->where('value',value:false);

Results
$true
> $true = $test->where('value',value: true);
= Illuminate\Support\Collection {#5192
    all: [
      {#5193
        +"value": true,
      },
      {#5239
        +"value": true,
      },
    ],
  }

$false - note that this collection is now keyed
> $false = $test->where('value',value:false);
= Illuminate\Support\Collection {#5216
    all: [
      2 => {#5215
        +"value": false,
      },
    ],
  }

This behaviour persists when an operator is specified, and using the WhereStrict() methods also.
If you change the first object to have a value of 'false' rather than true, both collections are always keyed - try with:
$test = collect([
    (object)['value'=>false],
    (object)['value'=>true],
    (object)['value'=>false]
]);

$true = $test->where('value',value: true); // Is now keyed where was not previously
$false = $test->where('value',value:false); // Is still keyed as previously

I think that’s expected. The first example where it’s not keyed is because the result collection has all the elements in the same order before applying the where call. The other ones are keyed because the result collection has the items in diff order than the original collection.


Signing algorithm in SAML protocol configuration is not getting updated through rest api

Description:
Through the endpoint /api/server/v1/applications/{app-id}/inbound-protocols/saml it  is not possible to update the signing algorithm for response/assertion signing.

Steps to reproduce:

Send a GET request to /api/server/v1/applications/{app-id}/inbound-protocols/saml to check the current signing algorithm
Send a PUT request to /api/server/v1/applications/{app-id}/inbound-protocols/saml with different signing algorithm like http://www.w3.org/2001/04/xmldsig-more#ecdsa-sha384
Again send GET request to /api/server/v1/applications/{app-id}/inbound-protocols/saml and check whether the signing algorithm has changed

this is assigned to @AnuradhaSK


Port configuration not working

It looks like even when I configure the port as 8080, it is still starting the server on 8081:
$ npm start -- --port=8080

><EMAIL_ADDRESS>start /mnt/disk1/Workspace/restapi
> node lib/app.js "--port=8080"

Express server started at http://:::8081

This should now be fixed.

These should generally be closed by the person who discovered them, no?
On Apr 22, 2015 15:21, "Mark Scappini"<EMAIL_ADDRESS>wrote:

Closed #5 https://github.com/optbot/restapi/issues/5.
—
Reply to this email directly or view it on GitHub
https://github.com/optbot/restapi/issues/5#event-287749733.

It's been six days, plus the approach has changed entirely.

Fair point. We should make decisions on handling of these things, and maybe
meet to discuss and groom/triage at regular points?
On Apr 22, 2015 15:34, "Mark Scappini"<EMAIL_ADDRESS>wrote:

It's been six days, plus the approach has changed entirely.
—
Reply to this email directly or view it on GitHub
https://github.com/optbot/restapi/issues/5#issuecomment-95357131.


Make it python3

wxPython supports Python 3 now.
I fix the import problem in the init.py file. Indeed it is a good practice to use all to expose the main function of your package, it just needed to go one level down :).
Changed the Exception catching for python3 and replaced xrange by range.
./demo.py runs in python3 with these changes

Thanks a lot for the contribution!
Out of curiosity: Which version of wxPython are you using?

I installed it from conda-forge
wxpython 4.0.0rc1.dev3440+0f9b36e          py36_0 conda-forg


Update ToolFactory introductory module. Add new docker installation option

New installation instructions and various small clarifications,
Backend has been substantially simplified - no more Planemo - using a local test script instead. Without new deps, a tool can be built and installed within about 10-15 seconds now.
Revised the docker image so it's far simpler, for a fast but non-persistent installation compared to a normal desktop dev server.

needs fixing - header levels :(


Require an key for OpenAI only when default URL is used

Does this mean we can now remove the dummy keys from various places in tests and docs samples?

Probably just tests that use a mock. We don't override the URL in docs samples.

Actually I'll leave out fixing the tests for when I get around to https://github.com/quarkiverse/quarkus-langchain4j/issues/446

Remind me why this is needed ?
Shouldn't we just not do anything for dummy key and have users set that value explicitly ?

The point is that the OpenAI extension can be used with other model serving services besided OpenAI and these services may not require an API key


feat: auto-refresh endpoints in server mode

this allows adds a --endpoints.refresh.interval [duration] flag to the server command, so it'll reload the previously used config, as well as any seed endpoints from SRV and/or mDNS.

Hi, thanks for the heads up @caarlos0.
This auto-refresh reads the config on interval right?

This auto-refresh reads the config on interval right?

the config, and also SRV records and zeroconf services if that is set up as well

Ahh okay, I see. However I don't think I need that for wishbox. Thanks for the notice though :=)


How to call the backend api to implement rss

The project does not use Nitro Hooks, but calls the api interface of the back-end program to obtain list information. How should I use it to generate feed.xml?

Create a nitro plugin like here in the playground example. https://github.com/tresko/nuxt-module-feed/blob/main/playground/server/plugins/feed.ts. You can call the backend here.
I must take a look if we could use nitro hooks in the future.


Whitespace missing in invite developer success message difficulty/newcomer

Opened by @jayvdb

with what file is this issue related to ?

@vaibhavgarg11 adding a space between ourcommunity here https://github.com/coala/corobo/blob/master/plugins/labhub.py#L31

@vaibhavgarg11 please assign yourself before you start working on the issue. Please go through Newcomer Guide, it is really helpful and has these things already mentioned. http://coala.io/newcomer


socket hang up-ECONNRESET

I have a hapi server running using forever and on the same machine I am sending requests to that server using node script using request liberary. I am getting socket hangup ECONNRESET error pretty frequently but if I don't use forever then it is working just fine.

@manV this is likely a problem with your app and not with forever. Hard to tell without more information, so I'm going to close this now.
Feel free to post more for us to help you out on this.