openfortivpn: 1.0.1 -> 1.1.4

Motivation for this change
Update openfortivpn 1.0.1 to 1.1.4, since it has an issue on 1.0.1[https://github.com/adrienverge/openfortivpn/issues/5], and I can confirm this work with 1.1.4 on my machine.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

cc @madjar

It is strange, I cannot reproduce the travis failure locally. I'll merge this right now, and investigate this later (maybe).


Clean up circuit drawer capitalization

Summary
Details and comments
This PR fixes some inconsistent capitalization in the circuit drawers. It follows these rules,

For the text drawer, all internally-created gate names are displayed in all caps, like X, UNITARY.
For the mpl and latex drawers, all internally-created gate names are displayed with first-letter capitalization, like X, Unitary.
All user-generated names and labels are left unchanged.

The fixes for the text and mpl drawers are in this PR. The latex drawer fixes are done as part of #5855.

I'm closing this since it is superseded by #6078.


Some docs still contain "Model Server for Apache MXNet (MMS)"

Main README references MMS as "Model Server for Apache MXNet (MMS)". Some documents might still be calling MMS as "Model Server for Apache MXNet", which might need to be changed.

Well, I missed this one (along w/ others). https://github.com/awslabs/multi-model-server/pull/872

The rest of the renaming mainly involves docker containers which haven't been updated to reflect the new name. Will have a larger PR after this to rename everything once we have them.

This finishes the name change. https://github.com/awslabs/multi-model-server/pull/874


event: YouTube removes video about selling a Tesla

https://twitter.com/RebuildsRich/status/1278313482224631809
https://www.zerohedge.com/technology/youtube-removes-video-popular-ev-owner-explaining-why-he-traded-his-tesla-gas-powered

https://archive.is/PM530
Pattern?


Feature request: Set cargo --features via environment variables

Consider a Cargo.toml including
[features]
default = []
unstable = [] # Enables nightly features

Simply put, you'd now be able to enable unstable by setting CARGO_SET_FEATURE_UNSTABLE to "truthy". Alternatively, you'd be able to set  CARGO_SET_FEATURES to a comma separated string of the features you wish to enable. This of course works for any number of features by setting more env vars or adding more to the comma separated string.
Having this capability would make .travis.yml files capable of enabling features very succinctly without relying on travis-cargo or other methods. An example:
language: rust
sudo: false
dist: trusty
rust:
- 1.22.1
- stable
- beta

matrix:
  allow_failures:
    - rust: nightly
  include:
    - rust: nightly
      env: CARGO_SET_FEATURE_UNSTABLE

cache: cargo

Does this apply to dependencies or only the "top-level" crate?

Summarizing from chat on #rust-internals:
CARGO_SET_FEATURE_UNSTABLE (or if we use the other env var method) would be the same as cargo <task> --features unstable, and iirc that does not apply to dependencies directly, but the top level crate may propagate the features down if it wants to in Cargo.toml.

I vaguely support this.
It feels a little strange that it only affects the top level, since other env vars, e.g. RUSTC=./hijacked_rustc.sh cargo build would apply to everything that gets compiled.
As to the question of CARGO_SET_FEATURE_$NAME vs CARGO_SET_FEATURES=$name,..., I don't know because to me it's a question of consistency vs. specificity. Other Cargo env vars, e.g. CARGO_CFG_* and CARGO_FEATURE_* (which are passed to build script), choose the first option. But the conversion from what you wrote in Cargo.toml to the environment variable name (namely, s/-/_/ and upcase), is lossy. So it would be more correct, at the cost of inconsistency, to go with the second encoding.

I wonder: would we want to sketch this out in an RFC in order to move this idea forward?

I believe so!

@dwijnand @alexcrichton I'm a bit swamped with language design so I don't have the bandwidth to hash this out; might one of you be able to author such an RFC?

My bandwidth is stretched, so I would rather focus it on some higher impact changes.
(My goal here was just to help define the next steps, for any interested party.)

Hi I would need this feature,
My use case is - I do have a cargo feature, which change compilation process  for libavformat  - it either uses shared library available on system (default) or download appropriate version, compiles and links statically.
On my development machine I need  to use this feature always - for test, run, build  etc. and it's bit annoying to always explicitly write it to commands. If tthere would be env. variable which will contain features to always use it would be nice.
I'm not experienced in you processes,  but   if you'll provide some basic guidance I can try to put together such RFC, I guess.

Did anyone end up implementing this feature?
It would be extremely useful when compiling Rust code from language-agnostic build tools and CI servers.
For example, in a typical Python extension written in Rust, rustc/cargo is called by Maturin... which might be wrapped by the Python pip package manager... and then pip might be run by Docker, Bazel, or some other build tool.
If Cargo features can be specified via environment variables, then it would be easier to improve a Rust build without changing the API of build tools that weren't designed for Rust.

The original motivation for this was when using travis and wanting to configure the implicit runs of cargo.  That use case is dramatically reduced (haven't heard of anyone using travis lately).
However, the idea is more general than that: people wanting to control cargo through other layers, like the maturin example above.  For myself, I'd prefer to have those build systems design the interaction, rather than us providing a bypass that may not match it (e.g. the original use case would justify a --no-default-features env variable but that could cause problems for the maturin case to not be additive).
In this thread, someone else also brought up the idea of effectively allowing per-user build parameters, including features.  As this would be an environment variable, it would then apply to everything run within the context it sets, which seems like a bad take except for a gitignored .cargo/config.toml which might not be possible if the project already has one.  A feature that should be always-on or always-off depending on the environment seems like a niche case.  Contrast that with people doing this for development convenience for regularly testing a set of features but then that makes it difficult to test other combinations.
Based on that, I feel like there isn't enough value-add gained compared to some of the potential negative side effects that I'm going to propose to the cargo team that we close this.

Of course Travis isn't very relevant, but that's just one example of many. Maturin isn't the only other gig in town either, there are a plethera of build systems out there, whether project or distro oriented. ENV vars are are one of the most universal mechanism out there for passing options around between layers in almost all of them. I've recently been working on autotools based projects with some Rust component, and although I've found ways to make it work cargo deliberately not playing nicely is a constant source of frustration. The solutions are much more convoluted than they need to be if ENV vars could be used to set values like this.
An unrelated case with (I think) a similar outlook flaw is #6790. I know it adds a little complexity to Cargo, but it would make it so much easier to make it play nice with other tools, yet somehow gets put off and put off...
Please don't think that the onus should be on every other tool to come up with ways to work around Cargo's mono-culture approach.

I'm running into a case where being able to set features through environment variables would be immensely useful as well.

Same here. I'm using some meta-tool that builds several parts of a project that includes but is not limited to making cargo calls and it would be superb to have an easy way for the features defined at the top level to trickle down to all cargo calls as well as other related components that are not Rust.
Otherwise, I'll need to make all of that more generic for adding a feature unrelated to the build system, which is kind of annoying.

Please don't think that the onus should be on every other tool to come up with ways to work around Cargo's mono-culture approach.

Another one to add to the list is bacon, now the defacto successor to cargo watch. If one wants to use a future in all jobs, currently the only way to do it is to redefine the full definitions of every job in the default config and add the --feature line. If instead Cargo would just support an env var, the same thing could be accomplished with one line of config.


AssertionError when caching artifact

See original issue on GitLab
In GitLab by [Gitlab user @TheRealMichaelCatanzaro] on Apr 9, 2018, 00:24
bst 1.1.2 crashes whenever it tries to build glib-networking. Note that I have an open workspace for it:
[--:--:--][????????][build:core/glib-networking.bst      ] START   Caching Artifact
[00:00:29][????????][build:core/glib-networking.bst      ] BUG     Build

    An unhandled exception occured:

    Traceback (most recent call last):
      File "/home/mcatanzaro/.local/lib/python3.6/site-packages/buildstream/_scheduler/job.py", line 265, in child_action
        result = self.action(element)
      File "/home/mcatanzaro/.local/lib/python3.6/site-packages/buildstream/_scheduler/buildqueue.py", line 34, in process
        element._assemble()
      File "/home/mcatanzaro/.local/lib/python3.6/site-packages/buildstream/element.py", line 1145, in _assemble
        self.__artifacts.commit(self, assembledir, self.__get_cache_keys_for_commit())
      File "/home/mcatanzaro/.local/lib/python3.6/site-packages/buildstream/_artifactcache/ostreecache.py", line 265, in commit
        refs = [buildref(element, key) for key in keys]
      File "/home/mcatanzaro/.local/lib/python3.6/site-packages/buildstream/_artifactcache/ostreecache.py", line 265, in <listcomp>
        refs = [buildref(element, key) for key in keys]
      File "/home/mcatanzaro/.local/lib/python3.6/site-packages/buildstream/_artifactcache/ostreecache.py", line 47, in buildref
        assert key is not None
    AssertionError

In GitLab by [Gitlab user @TheRealMichaelCatanzaro] on Apr 9, 2018, 00:46
Errr, looks like it's now happening for WebKit.bst as well. :(

In GitLab by [Gitlab user @tristanvb] on Apr 9, 2018, 05:46
This is another report of #316
Are you sure you have updated BuildStream to master and have https://gitlab.com/BuildStream/buildstream/commit/9012a5ed2f94704a99b3a2ac8f673160fca86668 from late last week ?
I'll try to see if I can reproduce in the meantime, if this is indeed not fixed; it would be nice if you could provide some additional information; the full build log as an attachment would be nice, along with the command you used to invoke BuildStream.

I guess this is non-strict mode ?
I guess that your open workspaces include glib-networking and WebKit ?
Does this happen with --track-all ? Or is it reproducible with bst build core-deps/WebKit.bst ?

In GitLab by [Gitlab user @tristanvb] on Apr 9, 2018, 09:26
I didnt notice that you mentioned 1.1.2 in the report, closing this as it's fixed since then.

In GitLab by [Gitlab user @tristanvb] on Apr 9, 2018, 09:26
closed

In GitLab by [Gitlab user @TheRealMichaelCatanzaro] on Apr 9, 2018, 19:43
Yes, I was using exactly version 1.1.2. I'd better try updating then, thanks!


Refactoring authorityselect to rely on data attributes in markup

This refactors authority select so that it uses data attributes in markup instead of requiring you
to initialize the class with selectors.
@projecthydra-labs/hyrax-code-reviewers

@jcoyne Is this alright now?

Still the indentation at this line: https://github.com/projecthydra-labs/hyrax/pull/771#discussion-diff-111156385R11

I think all the indentation is clean now?

@projecthydra-labs/hyrax-code-reviewers Can someone take another look at this?

@little9 can you update the commit message so it doesn't say "formatting changes" three times?

@jcoyne I removed the extraneous commit messages


Code review from Robin Wilson

As requested by @IanMayo, here is an initial code review of the code in parser/. I've included a lot of references to specific lines in specific files - hopefully Github will make them into nice links, but if not then it should be relatively easy to find them using VS Code (Ctrl-G triggers the Go To Line functionality).
Please feel free to ask for any clarification on any of these, or express disagreement (a lot of these are open to interpretation and I am quite happy to discuss them).
General notes

Overall assessment: In general, the code is well-organised and well structured. Functions are often quite long, but make sense as a conceptual unit so I don't think they should be split. There are some issues with repeated code and use of Python-specific features as detailed below, and path manipulation is a particular concern. Some comments don't match the code (or vice versa!). The htmlToDITA function is particularly well structured and documented - some would say it should be replaced with a series of functions to do each transformation, which are called in turn on the soup, but I don't think that would actually make it any clearer or easier to maintain.
In general, proper path joining functions should be used to join paths, rather than f-strings or other manual string manipulation. Examples include parser/parser.py:23, parser/parser.py:29 and many more. You might want to investigate PathLib which lets you do nice things like base_path / dir1 / dir2 and it will do the path joining for you. I think that could significantly clean up various parts of the codebase. It can also replace various calls like os.path.dirname etc.
Docstrings for most functions would be useful
There are various calls to the replace_characters function to get rid of %20 (eg. parser/class_files.py:114). I assume you're doing this to remove URL-encoded spaces from the filenames. That makes sense, but might there be other characters that are URL encoded that need updating? You could use a function like urllib.parse.unquote to remove all of them and then just remove the spaces? Might be more robust - but not essential. Need input from original author
A useful new function could be something like write_prettified_xml which takes a dita_soup variable and does parser/reference_files.py:76 to parser/reference_files.py:79 returning the filename - this could be used in various places and would reduce a bit of duplication.
parser/parser_utils.py:83: Not sure why you've got a definition for __all__ here or in various other utility files - that's normally just in an __init__.py, and importing should work automatically without __all__ in a normal Python file.

Specific notes

lxml needs to be added to requirements.txt
In general, don't commit the .vscode directory - it took over my editor settings when I opened it up, specifically by making the entire editor orange, which made me jump a bit! This directory is usually for user-specific custom editor settings, which don't need to be shared
parser/parser.py:112: What is ns in the name of this function? Being in the name of the function makes me think it is important, but scares me that I can't work out what it is.
parser/parser.py:388: We should check the output of subprocess.run here, as we currently don't know if it has succeeded or not - and then in the next few lines we say that the processing is complete, even though if the subprocess.run line has failed then it won't actually have completed. We can probably just check the return code of the process, but might need to check the actual output.
parser/parser.py:376: This seems to be a misleading name and comment - as far as I can tell, this is the entry to parsing the whole set of documents, not just the region map
parser/parser.py:34: This dita_soup variable is created here, used briefly to create an image tag, and then assigned to again at parser/parser.py:50 - and first assignment uses lxml-xml and the second just xml. I suspect the second definition can be moved up to replace the first one, but I'm not sure
parser/parser_utils.py:77: This actually removes multiple leading slashes
parser/parser.py:117: Comment outdated, this just sets up the HTML parsing
parser/parser.py:126: This exception isn't being caught anywhere - is this deliberate to crash the processing if it is raised? If not, it'll need to be caught at a higher level Need input from original author Comment included
parser/parser_utils.py:18: This function can be replaced with os.makedirs with the argument exist_ok=True
parser/parser.py:187: This is a bit unpleasant - I think it could be simplified with proper use of os.path.join etc, or (ideally) pathlib. The same applies for the various bits of path manipulation code in the following lines.
parser/parser_utils.py:36: This could be simplified by replacing the first if with if not filenames: filenames = os.listdir(source_dir) and then just having one lot of copying commands (reduces code duplication)
parser/parser_utils.py:73: This function probably isn't needed, I don't think it is any simpler than the standard python version of s.replace('x', 'y')
parser/parser.py:221: The first argument to this function is unused - should it be used? Need input from original author Fixed
parser/parser.py:270: tr_count in this for loop is unused - if you're not using it then you can remove the enumerate call. Same applies a couple of lines later.
parser/parser.py:343: It looks like this call to get_files_in_path can be removed and you can just pass an empty list of files to copy_files, and then it'll copy all the files in the source folder. The same applies at parser/parser.py:210. That seems to be the only two places that get_files_in_path is used, so it can probably be removed after that.
parser/parser_utils.py:26: It's probably not worth having a function defined that just calls another function with the same arguments Agreed
parser/class_files.py:81: The file_name argument is unused - should it be used? Need input from original author
parser/class_files.py:100: Why would entries in the children attribute of a tag not be BS4 tags? I can totally accept that they might not be (might they be raw text?), but it'd be good to have a comment here explaining what you're filtering out and why Need input from original author
parser/class_files.py:120: It looks like this TODO might have been done already? Need input from original author
parser/class_files.py:48: This error is being reported by a print statement, whereas various others have been reported by raising exceptions. Is there a reason for this difference?
parser/reference_files.py:9: This function needs a clearer docstring - it says it just converts a HTML file to DITA, but that's a description of the whole project - and more specifically of the htmlToDITA function. The docstring should explain what a non-class file is, and how it parses it.
parser/class_files.py:286: The code here and at parser/class_files.py:353 is very similar - can it be refactored in to one function, that takes an argument of what sort of tag to find (remarks or propulsion) and an argument of what function to call to process the relevant type of page - actually, they might even be the same function to be called just with different arguments - Leaving for now, as we're not using class_files.py at the moment
parser/html_to_dita.py:7: What is the purpose of this function? Is it just for development testing? It looks like it should be a unit test (and would probably be found automatically by the pytest runner), but doesn't have any asserts or similar in it. Need input from original author Done
parser/html_to_dita.py:35: This is a fairly complex function, so the docstring should reflect that. It would be useful to know why div's have to be replaced sometimes and not other times, and also useful to know the type of the return (it looks like it is a soup object and not a string of XML as is implied by the docstring) Need input from original author - I don't know why div's have to be replaced sometimes and not other times Have tried to extend DocString to explain the div strategy.
parser/html_to_dita.py:46: It looks like the TODO has been done. It would be useful to replace this comment with a comment explaining why a copy needs to be taken Need input from original author - I don't know why the copy needs to be taken Have tried to explain in relevant TODO
parser/html_to_dita.py:51: This if statement seems unnecessary - you can just do the assignment and if the value is the same as what it's being replaced with then it'll stay the same. The only reason not to do this is if there is a performance impact, which I don't think there would be here.
parser/html_to_dita.py:49: This actually replaces it with whatever is in div_replacement, so the comment is misleading
parser/html_to_dita.py:58: This could do with a numbered header as it seems to be a different transformation, and not part of number 1
parser/html_to_dita.py:78: This comment doesn't seem to match the code below it Done
parser/html_to_dita.py:87: What is A9 in this context? Need input from original author I have a lookup document of target files, indexed using this code. It is useful so I know which target document I found the pattern in
parser/html_to_dita.py:105: Does this need better urlencoding handling (see general notes) or are we sure we'll only find spaces and not any other invalid HTML characters? using a off-the-shelf URL tidier would be fine
parser/html_to_dita.py:121: This comment and the one below it are out of step with the code - they should be h2 and h3 respectively. In fact, this code could be replaced with another loop that loops over "h1", "h2" and "h3".
parser/html_to_dita.py:144: The repeated code here could be put in a for loop too
parser/html_to_dita.py:162: Please use os.path.join here (or pathlib) rather than just the string join function
parser/html_to_dita.py:183: Is this meant to be a function call to the clear() function? Need input from original author Yes, it looks like a bug
parser/html_to_dita.py:262: This is just checking whether it is one character long, rather than checking if it's actually just a newline. I doubt there are many single character bits of text, but it is probably worth checking for \n here instead/as well.

All items either resolved or overtaken-by-events (agreed in Slack)


Lidar ASO tutorial contents

All material for the ASO portion of the lidar tutorial

Closing in favor of a new PR with a fresh fork from the website


Do utility methods belong in another repo?

Should isValid, debounce, etc. live elsewhere?
I am torn because, on one hand, they can be really convenient
On the other hand, I feel like they are stand-alone utility functions and I like it when libraries are focused on one thing (for example, in Angular it came with $http service and if you wanted to use something custom, it always felt redundant)
Just writing this issue quickly whilst it's on my mind so I haven't checked, but could debounce be replaced with debounce or lodash.debounce?

These same utility functions will probably work for the Inferno version, etc. too so it makes sense to abstract them?

It would be actually perfect if debounce would not be part of the library and one could an existing utility library. The problem right now, is that debounce internally has some logic, to decouple sync from async actions. So it does actually more than just delay the update.


PortMidi: `Bad pointer' error when closing port with pygame backend on Windows

I'm using mido with the pygame backend on Windows 7 and Python 2.7.
When running this:
import mido
import time

mido.set_backend('mido.backends.pygame')

output = mido.open_output()
output.send(mido.Message('note_on', note=64, velocity=60))
time.sleep(3)
output.close()

The following error is printed to stderr in the last line:
Exception Exception: "PortMidi: `Bad pointer'" in <pypm.Output object at 0x025FF0B0> ignored

This error is mentioned as a known bug, but only under Ubuntu. This happens to me on Windows.
Apart from this everything seems to work, but I'm developing a console app so this is problematic. Is there a way for me to fix this? Or should I just use RtMidi as the backend instead?
Thank you

I would recommend RtMidi. PortMidi has a few of these problems that can
only be fixed by recompiling it.

Indeed I've switched to RtMidi and so far it works flawlessly. Thanks :)

Happy to hear that. :) Closing the issue then.


fix: Drop support for Ansible 2.11

2.11 does not work with the current Galaxy API.

Ping @gardar, all PRs are failing due to Galaxy API changes.

fixed #241


Create apache config example file - Solve issue #258

include an apache.conf.template inside config path, with instructions
about how to use it.

In my opinion this is out of Picos scope, it's not our job to explain how a webserver is configured. Any other opinions about that? @theshka

While I do agree it is out of Pico's scope @PhrozenByte, the Wiki does offer instructions for NGIX, and others. Perhaps we can include this in the wiki, or just remove them all and have examples for none?

I think our configuration suggestions would be (per-definition...) wrong, there are too many platforms with different configuration strategies out there. For example, I'm using Debian, using the suggested template will definitely break Debians default configuration. It's even hard to link to a website that explains the webserver configuration, I don't know any website that even covers the major platforms, far less any platform. My personal opinion is, that someone, who isn't able to google for the right solution for his platform, shouldn't have a root server, he should stay with managed webspace. So, I think it's best to remove all configuration examples, except for Pico-specific things like URL Rewriting.

Perfect, then lets move to clean up the examples, and going forward reiterate that web server configuration is not within the scope of this project. :+1:


helm charts

Deploy skywalking to kubernetes using helm charts.

Hi , About toYaml, If I use the toYaml method, I need to define multiple keys in the values.yaml file, because the deployment and the required keys in the service are different, which causes me to define different keys, but their values are the same, and will cause ui to get the port of oap complicated.
What should I do ? Tell me ,Thanks.

the deployment and the required keys in the service are different,

My suggestion is "toYaml" resource(cpu, memory) configuration instead of all of the yamls.

Except for namespace, other Changes requested have been modified.
About namespace ,I have two ways.

now charts
add the namespace configuration to each file and maintain this configuration with values.yaml
helm install skywalking --set=""
I recommend using the first method, I refer to helm/charts repo.

Help review again , thanks


Cannot import name 'Dispatch' from 'win32com.client' and missing attribute 'Dispatch'

Problem Description
When compiling a Python application using Nuitka with certain win32com.client imports, the resulting executable fails to locate the Dispatch method or the gencache functionality from the win32com.client module. This problem persists despite the code functioning correctly in the Python interpreter.
Environment Details

Nuitka version, full Python version, flavor, OS, etc.

  2.5.4
Commercial: None
Python: 3.11.10 | packaged by Anaconda, Inc. | (main, Oct  3 2024, 07:22:26) [MSC v.1929 64 bit (AMD64)]
Flavor: Anaconda Python
Executable: D:\miniconda3\envs\...\python.exe
OS: Windows
Arch: x86_64
WindowsRelease: 11
Version C compiler: C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.34.31933\bin\Hostx64\x64\cl.exe (cl 14.3).

The specific PyPI names and versions

pywin32                   308         D:\miniconda3\envs\...\Lib\site-packages pip
pywin32-ctypes            0.2.3       D:\miniconda3\envs\...\Lib\site-packages pip
pywinauto                 0.6.8       D:\miniconda3\envs\...\Lib\site-packages pip

Code to Reproduce the Issue
The problem is reproducible with the following code:

def dispatch(app_name: str):
    try:
        from win32com.client import Dispatch
        from win32com.client.gencache import EnsureDispatch, GetGeneratePath
        app = EnsureDispatch(app_name)
    except AttributeError:
        # Corner case dependencies.
        import os
        import re
        import sys
        import shutil
        # Remove cache and try again.
        MODULE_LIST = [m.__name__ for m in sys.modules.values()]
        for module in MODULE_LIST:
            if re.match(r'win32com\.gen_py\..+', module):
                del sys.modules[module]
        from win32com.client import Dispatch
        from win32com.client.gencache import EnsureDispatch, GetGeneratePath
        shutil.rmtree(GetGeneratePath())
        app = EnsureDispatch(app_name)
    return app

Compilation command
nuitka --windows-icon-from-ico=logo/logo.ico --windows-uac-admin --output-dir=dist --standalone start.py
Upon running the compiled .exe file, the following error occurs:
Traceback (most recent call last):
  File "D:\...\dist\start.dist\utils\Win32Utils.py", line 4, in dispatch
ImportError: cannot import name 'Dispatch' from 'win32com.client' (D:\...\dist\start.dist\EXE_FILE\client\__init__.py)

Note: EXE_FILE is just a replacement of the real name
Whenever some part of the code try to access the Dispatch method of win32com.client it ends up in not finding it.
Same problem can be seen by just importing:
from win32com.client.gencache

with the call:
gencache.EnsureDispatch(...)

and compiling with:
nuitka --windows-icon-from-ico=logo/logo.ico --output-dir=dist --standalone --debug --run start.py
Traceback (most recent call last):
  File "D:\...\dist\start.dist\utils\Win32Utils.py", line 5, in dispatch
  File "D:\...\dist\start.dist\win32com\client\gencache.py", line 628, in EnsureDispatch
AttributeError: module 'win32com.client' has no attribute 'Dispatch'

Traceback (most recent call last):
  File "D:\...\dist\start.dist\utils\Win32Utils.py", line 19, in dispatch
  File "D:\...\dist\start.dist\win32com\client\gencache.py", line 628, in EnsureDispatch
AttributeError: module 'win32com.client' has no attribute 'Dispatch'

I'm providing the nuitka build output:
Nuitka-Options: Used command line options: --follow-imports --windows-icon-from-ico=logo/logo.ico --output-dir=dist --standalone start.py
Nuitka-Options: Following all imports is the default for standalone mode and need not be specified.
Nuitka: Starting Python compilation with Nuitka '2.5.4' on Python '3.11' commercial grade 'not installed'.
Nuitka-Inclusion: Should decide '--prefer-source-code' vs. '--no-prefer-source-code', using existing 'zeroconf._services' extension module by default. Candidates were:
Nuitka-Inclusion: ImportScanFinding(found_in='D:\\miniconda3\\envs\\...\\Lib\\site-packages\\zeroconf', module_type='C_EXTENSION', priority=1,
Nuitka-Inclusion: full_path='D:\\miniconda3\\envs\\...\\Lib\\site-packages\\zeroconf\\_services', search_order=0) <->
Nuitka-Inclusion: ImportScanFinding(found_in='D:\\miniconda3\\envs\\...\\Lib\\site-packages\\zeroconf', module_type='PY_SOURCE', priority=2,
Nuitka-Inclusion: full_path='D:\\miniconda3\\envs\\...\\Lib\\site-packages\\zeroconf\\_services', search_order=0).
Nuitka-Plugins:anti-bloat: Not including 'PIL.ImageQt' automatically in order to avoid bloat, but this may cause: PIL will not be able to create Qt image objects.
Nuitka: Completed Python level compilation and optimization.
Nuitka: Generating source code for C backend compiler.
Nuitka: Running data composer tool for optimal constant value handling.
Nuitka: Running C compilation via Scons.
Nuitka-Scons: Backend C compiler: cl (cl 14.3).
Nuitka-Scons: Backend linking program with 249 files (no progress information available for this stage).
Nuitka-Scons: Compiled 249 C files using clcache with 0 cache hits and 249 cache misses.
Nuitka-Postprocessing: Adding 1 icon(s) from icon file 'logo/logo.ico'.
Nuitka: Keeping build directory 'dist\start.build'.
Nuitka: Successfully created 'dist\start.dist\EXE_FILE.exe'.

Note: References to other packages are releated to other portion of codes that i'm not including in this issue beacause not releated.

Seems like a missing implicit dependency to add here.

Unfortunately your reproducer is incomplete. The other ones gives me AttributeError: module 'comtypes' has no attribute 'client'. Did you mean: 'c_int'? probably just a wrong import. Please provide a minimal program that works with Python and not with Nuitka as a reproducer.

Sorry for the missing information.
Anyway i think I found the problem. I have a package named "client" in my project, and when trying to import win32com.client for unknown reasons the built .exe try to search for it in my client package and not in the right one.
I tried to compile just a single file:
def dispatch(app_name: str):
    try:
        from win32com.client import Dispatch
        from win32com.client.gencache import EnsureDispatch, GetGeneratePath
        app = EnsureDispatch(app_name)
    except AttributeError:
        # Corner case dependencies.
        import os
        import re
        import sys
        import shutil
        # Remove cache and try again.
        MODULE_LIST = [m.__name__ for m in sys.modules.values()]
        for module in MODULE_LIST:
            if re.match(r'win32com\.gen_py\..+', module):
                del sys.modules[module]
        from win32com.client import Dispatch
        from win32com.client.gencache import EnsureDispatch, GetGeneratePath
        shutil.rmtree(GetGeneratePath())
        app = EnsureDispatch(app_name)
    return app

shell = dispatch("Shell.Application")
windows = shell.Windows()

print(windows)

and by executing the build with nuitka --output-dir=dist_TODEL --mode=standalone githubdiscussion.py i get:
Traceback (most recent call last):
  File "D:\PROJECT\dist_TODEL\githubdiscussion.dist\githubdiscussion.py", line 25, in <module>
  File "D:\PROJECT\dist_TODEL\githubdiscussion.dist\githubdiscussion.py", line 4, in dispatch
ImportError: cannot import name 'Dispatch' from 'win32com.client' (D:\PROJECT\dist_TODEL\githubdiscussion.dist\PROJECT\client\__init__.py)

This is my project structure:
PROJECT
|
| client
| | __init__.py
| | Client.py
| | ClientState.py
| | Command.py
| start.py
| githubdiscussion.py

The client.__init__.py is:
from .Client import Client
from .ClientState import ClientState

The funny thing is that the script causing this error is completely separate from the client package.
I tested the built githubdiscussion.py script outside my project environment, and it works perfectly.
P.S.: Renaming the client package resolves the issue.

I managed to replicate this issue by creating a project environment with this structure:
TEST
|
| client
| | __init__.py
| githubdiscussion.py

With empty __init__.py.
And I get the following error:
Traceback (most recent call last):
  File "D:\TEST\githubdiscussion.dist\githubdiscussion.py", line 24, in <module>
  File "D:\TEST\githubdiscussion.dist\githubdiscussion.py", line 3, in dispatch
ImportError: cannot import name 'Dispatch' from 'win32com.client' (D:\TEST\githubdiscussion.dist\TEST\client\__init__.py)

I have to confirm that I actually reproduce this, amazing, and Python doesn't have it, so this would have to be a several bug I guess.

Thanks for your report. This is fixed on the factory branch, which is a development version that is under rapid development. You can try it out by going here: https://nuitka.net/doc/factory.html
Feedback on whether this is working is very welcome. Please do not share plans to do it; only confirm or deny that it is working.

The feature in the yaml configuration used, was implemented such that not only was win32comext added, but also each folder examined, which involves the main program directory as well, and others, leading to this happening.

It works perfectly! Thank you.

Part of the 2.5.6 hotfix I just made.


Fix redirects to room versions

Where are they now so we can look them up in the meantime? :D

@heylix on the new spec website https://spec.matrix.org/unstable/rooms/

Yes, it was mentioned yesterday but I haven't gotten to it yet.

Redirect is pending ops approval/deployment


Refactor: Make GenerateKey more robust

The GenerateKey function has been refactored to improve its robustness and efficiency. The function now only accepts a slice of strings as input, preventing non-string values from being passed. The strings.Builder type is used for more efficient string concatenation. The function also handles potential errors that may occur during the string concatenation process.
Fixes https://github.com/rollkit/rollkit/issues/1492

[ ] New and updated code has appropriate documentation
[ ] New and updated code has new and/or updated testing
[ ] Required CI checks are passing
[ ] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

Summary by CodeRabbit

Refactor

Improved the GenerateKey function for better performance and error handling.

@AbhinavMir are you still interesting in finalizing this PR?

closing in favor of #1580 due to inactivity.


feat(icon): add null as a valid animation

Please read and mark the following check list before creating a pull request:

[x] I read and followed the CONTRIBUTING.md guide.
[x] I read and followed the New Feature Checklist guide.

Short description of what this resolves:
In our app we render a lot lists with hundreds or thousands of items. Each list item has an icon, but list rendering is slowed down by the icons animating. We don't care much for the animation and would like an easy way to disable the animation.

@Photonios  Thanks for taking care about this!

Thanks for the quick review @artyorsh! I addressed the other comments by amending the commit.


Allow for a new db-sync node to sync with a pre-existing database

External
Existing Database Connections
Summary
Hopefully this hasn't already been hashed, I tried to do some searching but haven't found much. I've deployed db-sync several times now and have noticed that I do not seem to have a way to re-use an existing sync'ed database. Would love to be able to clone a database and have a newly installed/configured db-sync connect to it and verify.
For deployments and issues that may crop up with servers, requiring a total re-load / re-sync is extremely time-consuming. This will become a major issue in the future when the blockchain is getting even larger I can only assume.
Steps to reproduce
Steps to reproduce the behavior:

Install a db sync node
Fully sync a database
Clone the database
Install another db sync node and attempt to sync

Expected behavior
The node should ideally be able to quickly perform checks to verify the database is valid instead giving insertion errors or attempting to rollback the entire database.
System info:

OS: Debian Buster
DB Sync Version 9.0
Node version 1.26.1

Additional context
Finally amazing job and if there's something I can do to help, just let me know. As the size of the services grow having "modular" capabilities like this to improve deployments and separate the db-sync process from the node and from the database could be advantageous.

There are two bits of persistent state; the Postgres database and the ledger state directory (as specified by the --state-dir directory. As long as you clone both bits of state from one machine to another, and they are running the same version of software, this should work now.

Ahhh, ok that helps; I'm assuming if that state directory doesn't match perfectly with the database, the whole thing will get rolled back? For example if I have a database that is one day old, but a ledger state that is one week old; it won't just roll back to the ledger state, but the entire db?

As long as the database is not behind the ledger state directory, it will only roll back to the latest point specified by the ledger state.
In the example you give, it will roll back a week, not the whole db.

Sweeet, thanks!


How can I use monaco in my electron app?

How can I use monaco in my electron app?
I mean the code sample from https://github.com/TypeFox/monaco-languageclient/tree/master/example
What's the proper way to do that?  i'm open to new suggestions. I throughout into building a micro frontends but it's not that nice in react/electron and in the end i would have to include the final index output file using iframe. I wish I could use something we do with dlls in desktop application. note: i'm new to react and electron, perdon mystakes that seems so simple.
Well, I tried to "merge" as needed both webpack configs. Is this the way to go? so far i couldn't make it. I added:
  resolve: {
    alias: {
      'vscode': require.resolve('@codingame/monaco-languageclient/lib/vscode-compatibility')
    }

but it cannot find the vscode module, i'm getting the error:
Module not found: Can't resolve 'vscode' in 'C:\Users\jjj\Desktop\merge\Newton\node_modules\vscode-languageclient\lib\common' even tho the package is installed.
I also tried to add "editor.worker": 'monaco-editor/esm/vs/editor/editor.worker.js'  in the entry section but I got the error:

An unhandled error has occurred inside Forge:
Conflict: Multiple chunks emit assets to the same filename index.js (chunks 179 and 915)
Error: Conflict: Multiple chunks emit assets to the same filename index.js (chunks 179 and 915)

I did plan to -- assuming it's the proper way to go ---, once managed to fix this webpackes merge, I'd include the main file with the contents:
    require('monaco-editor');
    (self as any).MonacoEnvironment = {
        getWorkerUrl: () => './editor.worker.bundle.js'
    }
    require('./client');

then have

somewhere to show the editor and the  wouldn't be needed due to the fact it would be included in the webscript's output javascript bundle file, used elsewhere by the entire application.

I'm not used to electron, sorry

Multiple chunks emit assets to the same filename

It happens if you make the webpack config output 2 different bundles as the same file, it's probably related to the output.filename/output.chunkFilename configurations.

I'm not used to electron, sorry

Multiple chunks emit assets to the same filename

It happens if you make the webpack config output 2 different bundles as the same file, it's probably related to the output.filename/output.chunkFilename configurations.

I've fixed that but still get the vscode not found error

@MassMessage does this problem still persist with newer versions of monaco-languageclient?

@MassMessage thanks for the update. I will close this now. If you run into new problems, please open a new issue.


Ensure insert projections are of correct type

Which issue does this PR close?
Works-around #5046.
Rationale for this change
Described in issue
What changes are included in this PR?
Casts from values clause types to insert table types.
Are these changes tested?
Yes, with an integration test.
Are there any user-facing changes?
No - I don't think anyone is using the insert/update/delete plans yet, and if they are this is probably an improvement.

FYI any "no space left on device" CI errors should be fixed by merging up from master to get https://github.com/apache/arrow-datafusion/pull/5047

It's approved, tests pass, and it's not a big breaking thing, so I'll just go ahead and merge it.


Air Quality Observed: measurand attribute is not documented

in the readme example there this attribute:
"measurand":
[
"SO2,4.0,GQ,Sulfur Dioxide",
"CO,0.3,GP,Carbon Monoxide",
"NO,18.0,GQ,Nitrogen Monoxide",
"NO2,46.0,GQ,Nitrogen Dioxide",
"NOx,73.0,GQ,Nitrogen oxides"
],
which is not then used in the spec neither in the .json files. I suppose it should be removed, given that contains duplicated information. But it a guess.

yes, this attribute is deprecated, and should be removed

I made a PR #198. I wonder if we shouldn't review the model, there are few things that are not in aligned with the last practises. For example, values of gases are not defined. I am also not sure it is a good idea to allow to reference directly attributes from the WeatherObserved data model. The default modality should always be the reference to the entity.

values of gases, yes they are defined, but not individually, but in general. please check.
wrt WeatherObserved, yes you might be right. a pull request could be welcome. although you might need to modify many different things, such as readme, harvest python scripts, etc. etc. it can be quite a few work ...

i wondered if for completeness it wouldn't be better to list the actual values of gases as by the normative reference you link (and consequently update them in the schema).
as regards WeatherObserved, let's open it as an issue, if no one else come first, i will work on the pr when I find a slot.

you can use the GSMA IoT Big Data  Harmonised Datamodel document as reference, it is mentioned the WHO recommended parameters. You can list some of the pollutants but I would leave it open to new pollutants as per the current specification

closing as this is fixed


Decreased the size of the outerring so that the handle is within gesture zone

when trying to drag the handle,  the gesture detective was not picking up when the handle was around the fifteen minutes mark  and you click to the right of the center of circle.
this because the circle is being painted outside of the painter area,  which is the widget that is getting the  gestures and therefore they are lost when it is outside of it.  there maybe some other approaches to deal with this,  was unable to solve it by having the gesture detector  having padding before the  custom paint.
the side effect from making the  circle smaller the font sizes  were no longer appropriate,  however these scale funny anyway so think some work is needed here.
Resized the font to suit the slightly smaller display
Resized landscape height as was too small
Possibly font sizes should  have been retained and the widget sizes  and boundaries increased, But I think the font sizing needs work in general  so I'm contributing this as is.

before and after

with fonts fixes


ideas for sealed trait

Pull Request Test Coverage Report for Build 3790
Details

0 of 0   changed or added relevant lines in 0 files are covered.
11 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 83.556%

Files with Coverage Reduction
New Missed Lines
%

hashset/hashset.mbt
11
80.9%

Totals

Change from base Build 3783:
-0.2%

Covered Lines:
4309

Relevant Lines:
5157

💛  - Coveralls


[move modules] Merge ValidatorConfig and FullNodeDiscoveryConfig

Motivation
This change merges FullNode config and ValidatorConfig in move modules: LibraSystem and ValidatorConfig. ValidatorSet contains consensus public keys and networking information for validators and validators' full nodes.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
cargo xtest

@bors-libra r=$davidiw

:pushpin: Commit ccf70d9 has been approved by $davidiw

:hourglass: Testing commit ccf70d9605a07434ec1d480a95eda2d462126d6a with merge d934bba5447e0dbd1658e9f15ad30e261f7a1d19...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: $davidiw
Pushing d934bba5447e0dbd1658e9f15ad30e261f7a1d19 to master...


Swift 4

Do you have any plans to release in swift 4?
Also are there any resources on implanting groups in swift?
Thanks for your work here

Good point. I will push a new version now.


Support CAA Records

We're probably going to have to PR to miekg, but this would be very useful to have.

This was implemented by #64.


Feedback on Milestone #2

Good work team! You've done a great job organizing and building your repo. A few comments:

Nice work using branches and issues with your workflow
All tests path except for one passed. The test that failed (test_input located in test_histogram.py) spat out this error when I used pytest: "fixture 'y' not found". Did you also receive this error? It may have been due to how my personal python environment is set up.
Related to this issue, we are asking that for future versions of your functions you attach, in a new folder, a screenshot of your pytest output.
Good job with your documentation and commenting your functions. Your README is easily navigated and the examples of outputted graphs are helpful.
Is there a reason you put all of your functions in the same python script? As opposed to different scripts? I suppose it doesn't matter but it might make your package a little more readable to split it up.

Thanks for the good work!

Hi @rainerlempert ,
As we have responded you in person last Tuesday, I think we can close this issue now.
Thank you for your feedback!
@sabrinatkk  @ian-flores @hfboyce


Assignment

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding code to complete the assignment. I made multiple directories, moved files, removed files with IP addresses and created a file that contains the contents of the directories.
What did you learn from the changes you have made?
That I'm learning how to actually do this!
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
No, I followed the course slides.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Yes - didn't realize I had to make the ./data/processed directory. I had to test it out as I was going along to make sure I was including steps not explicitly mentioned in the question.
How were these changes tested?
I tested them out on my terminal and visually seeing it in windows explorer as I was inputting code into Visual Studio.
A reference to a related issue in your repository (if applicable)
N/A
Checklist

[x] I can confirm that my changes are working as intended

You did a great job here!
Just keep in mind that the pull request should be open during the marking process, after the assignment gets marked you can close or merge the request.
Please work on part two of the assignment which is about resolving the conflicts and then let me know. Thanks!

Thank you for your comments! I've created another pull request (and left it open) with part 2 of the assignment done!


[admin] (Links) Fixing bookmarks in auto-gen tables

The What's New tool has an issue with anonymous structs as parameters, so I fixed the output related to that (Word search options and Excel Settable*Properties). I also changed the tool to change _s in parameter names to - when generating links, which matches OPS behavior.
Also, there were a couple instances of an old moniker view parameter in URLs that have been addressed.

Docs Build status updates of commit 3b7d9a4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/custom-functions-authentication.md
:white_check_mark:Succeeded

docs/excel/custom-functions-dialog.md
:white_check_mark:Succeeded

docs/reference/requirement-sets/excel-api-1-2-requirement-set.md
:white_check_mark:Succeeded

docs/reference/requirement-sets/excel-api-1-9-requirement-set.md
:white_check_mark:Succeeded

docs/reference/requirement-sets/word-api-1-1-requirement-set.md
:white_check_mark:Succeeded

docs/reference/requirement-sets/word-api-1-3-requirement-set.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


tabindex="0" gets only added in readonly mode. When keyboard tabbing,…

tabindex="0" gets only added in readonly mode. When keyboard tabbing, no focus is needed in readonly mode.
Fixes issue #22:
https://github.com/gjunge/rateit.js/issues/22
I (We) decided to not just leave the value for tabindex empty, because looking at the documentation it looked like a value of "0" is the default. It is safer to just not add the attribute alltogether in readonly mode.
For some reason both my editors added a newline at the end of the file. I hope that is not a problem.

Thanks for the PR, looks great.
I'll merge it now, and tomorrow publish to NPM & NuGet

Thank you :)
Hartstikke bedankt as well


The Ima extension does not have ImaAdsLoader

Seems the binding does not have necessary classes. ImaAdsMediaSource constructor parameters showing JniRef whereas it should be ImaAdsLoader which is not present.

Fixed in <IP_ADDRESS>


Brew install problem

When entering
brew install https://raw.githubusercontent.com/scrapinghub/crawlera-headless-proxy/master/crawlera-headless-proxy.rb
I receive below error
'brew extract or brew create and brew tap-new to create a formula file in a tap on GitHub instead.: Invalid usage: Non-checksummed download of crawlera-headless-proxy formula file from an arbitrary URL is unsupported!'

Same here ! @123fischer have you figured this out?

Homebrew now requires Github repositories containing recipes to follow a specific naming convention homebrew-* and hence the install command breaks. While that is figured out, try using docker image instead for the mac.

Try this one:
curl -L https://raw.githubusercontent.com/scrapinghub/crawlera-headless-proxy/master/crawlera-headless-proxy.rb > crawlera-headless-proxy.rb && brew install --HEAD crawlera-headless-proxy.rb


Update to Spring Security 3.2.6.RELEASE

Update to Spring Security 3.2.6.RELEASE. My IDE reformatted some whitespaces, you can ignore them using the w=1 parameter: https://github.com/grails-plugins/grails-spring-security-acl/pull/14/files?w=1

ping @burtbeckwith :)

+1 @burtbeckwith please merge this.

Closing since I've updated to 3.2.9


Feat/stabilize divisions

Closes #9
Addresses #27

Work done

[x] Hex::length and Hex::ulength rework to reduce overflowing cases (#27)
[ ] Reworked Div impls for Hex to respect expected length expectations (#9)

[x] Div<f32>
[x] Div<i32>
[ ] Div<Self>

[x] Adapted Rem impls to match the new division
[x] Added Hex::abs method
[x] Updated example to showcase the division and rotations

Actually, I think @nuggetInc was correct in the original issue. We should just remove Hex's division by self.

I think having division makes sens as we have multiplication. In the current state
let a = Hex::new(13, 42);
let b = Hex::new(21, 45);
let product = a * b;
assert_eq!(product / a, b);
assert_eq!(product / b, a);

Therefore I think the current Div<Self> impl makes sense


Update registry for 1.1.0

Creates a new registry subfolder for 1.1.0 values to maintain registry compatibility with previous engine versions.

tested and everything worked on my end.


useing OAuthPrompt but teams are not responding

problem description:
after starting,enter any text,I think the expected effect should be like this

microsoft teams will pop up a continue button to allow us to authoize,but now teams is not responding

We tried many time but still it`s like this，can you please help me solve it? thanks
ps：web chat can log in normally

Examples of use：https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/bot-teams-authentication/nodejs

@MDZZ3 - Thanks for reporting your issue. We will check this and update you soon.

@Nivedipa-MSFT  ok，  thanks

@MDZZ3 - We are able to repro your issue. We have informed sample team to investigate further. We will let you know once we get any updates from them.

@Nivedipa-MSFT  thanks，hope the reason can be found out soon，because our teams bot fails to allow users to log in successfully due to this problem

@Nivedipa-MSFT  ok

Same issue with the .net core samples. Is the issue located on samples that are outdated or is it a bug somewhere inside the bot framework ?
If it's an issue with the samples, would be awesome if someone can show me an actual working example. Thanks in advance.

@MDZZ3, @AndroMsd - The sample team is working on the bot-teams-authentication sample to fix the issue. Meanwhile, could you please try this similar sample?
Microsoft-Teams-Samples/samples/bot-conversation-sso-quickstart/js at main · OfficeDev/Microsoft-Teams-Samples

+1 on the sample not working. Commenting to get updates when they are posted

@Nivedipa-MSFT  Now that I run this js sample(https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/bot-conversation-sso-quickstart/js) and our program has returned to normal, has anything been updated? thanks

@MDZZ3 - No, there is no update in this sample. It is functioning as it did previously.


Different result for external-memory version

Hi!
I encountered with incorrect working of external-memory version.
This is output from standart version of xgboost (in-memory). It works correct.
[0]	test-logloss:0.478994	test-auc:0.515605
[1]	test-logloss:0.348310	test-auc:0.514015
[2]	test-logloss:0.261227	test-auc:0.514495
[3]	test-logloss:0.200327	test-auc:0.514573
[4]	test-logloss:0.156165	test-auc:0.514474
[5]	test-logloss:0.124013	test-auc:0.515259
[6]	test-logloss:0.100075	test-auc:0.515203
[7]	test-logloss:0.082257	test-auc:0.514975
[8]	test-logloss:0.068881	test-auc:0.515249
[9]	test-logloss:0.058907	test-auc:0.523425
[10]	test-logloss:0.051434	test-auc:0.527481
[11]	test-logloss:0.045821	test-auc:0.526359
[12]	test-logloss:0.041727	test-auc:0.525705
[13]	test-logloss:0.038686	test-auc:0.528643
[14]	test-logloss:0.036467	test-auc:0.533795
[15]	test-logloss:0.034843	test-auc:0.537545
....
 The external memory and in-memory algorithm are different so  the difference in trace was not surprising.
The non-converging behavior is likely have something to do with the skewness of the data.  Are you working on very unbalanced dataset? The max_delta_step  mentioned here https://github.com/dmlc/xgboost/blob/master/doc/param_tuning.md may help solve the problem.
It would be great if you can share your setting and data that reproduce the error, so we can take a closer look at the problem.

Thanks for quick answer! Yes, I have unbalanced dataset - it's clickthrough log indeed :)
But when I use in-memory algorithm I don't ecnounter with this issue.
I'll try to set parameter max_delta_step and will comment out the results.
Thanks

@ivihrov  any updates on this?

Hi!
Setting max_delta_step to finite number helps for small dataset, but when I try to train model on big dataset (>100Gb), I  get this error.

hi @ivihrov  can you send the printed log to me (can be by email) I will take  a closer look on this.
This could still due to the problem of skew-ness in data.
Another thing that might help simply try to limit the minimum of hess produced by the objective function. So it returns max(p(1-p), v) where v is a small number say 0.001

closing for now due to inactive state, you can try https://github.com/dmlc/xgboost/tree/brick which is the most recent version that comes with several fix of distributed version that can also affect external memory version.
It now runs billion scales on distributed setting without any problem


Add an explanation before asking for permissions.

-Add an explanation before asking for permissions - contacts, camera, etc
-Why do we need access to your address book?
If you want to associate an address book contact with your Friends & Family in Hexa, you will need to give access to your address book. It is a good way to remember who the contacts are with their name and image

Don’t worry these details don’t leave your phone and are for your eyes :eyes: only

Updated description: Address book details like name and image are used for you to better recognize your Hexa F&F contacts. Don’t worry, they don’t get stored anywhere else and are for your eyes only.
Tested on iOS (wasn't able to figure out for Android).

-Android permissions are missing.

Wasn't able to figure out where the permission string for Android is located. @abdulmuneer22 Can you look into the android part of this? Thx.

For this implementation has to be changed anyways wrt react-native upgrade, at the moment we are using expo-permissions and the same will not be used anymore.
@antuz123  , please move it to 1.1.3

@Parsh - please add the required text for now if we can’t move it to the later part of the process.

Updated description: Address book details like name and image are used for you to better recognize your Hexa F&F contacts. Don’t worry, they don’t get stored anywhere else and are for your eyes only.
Tested on iOS (wasn't able to figure out for Android).

@antuz123 I've changed it for iOS, can't figure out for Android(as I've mentioned earlier).

Current Status:
After the latest set of changes Android permissions are requested when they are needed and not at startup.
IOS Permissions are requested when they are needed and are accompanied by a reason why they are needed.
What is missing:
Android permissions dont have a reason when permissions are asked.
What needs to be done:
Before asking for permissions a new screen needs to be added to show what permissions are being requested and why. After this the permission should be requested.
This should be for:

Contacts/Address book
Camera

This is the information screen that should be shown before requesting any permission:
https://xd.adobe.com/view/00485057-d5b7-4b2b-641b-20216b3a38d5-7679/screen/d16432e9-fb2f-457c-98ae-0e9d95fe7db2/

-Verified this issue on dev app version 1.3.2(170) on android and ios device.


SAMZA-2591: API updates for TaskStorageBackupManager

Changes: Updated TaskStorageBackupManager API in order to accommodate async commit to remote stores. Full design document at SAMZA-2591
Excerpt for this PR: We will be replacing the TaskStorageManager class and abstracting the common operations that the store backups need to call into a separate class called “TaskStorageBackupManager ”. This class will handle backup of the local state storage into the remote state, depending on the specific upload implementation for the remote storage.
API Changes: Internal TaskStorageManager changes
Tests: Tested with existing unit tests
Upgrade Instructions: None
Usage Instructions: None

Can you attach the design document to the ticket (parent or the child one) to give more context on this change? Maybe add an excerpt to this PR description too.

@mynameborat Thanks for the reminderl Added the main design doc to SAMZA-2591
as well as an excerpt pertaining to this initial PR.

@dxichen Let's close this PR.

Merged to feature branch state-backend-async-commit in #1489 #1490 #1491


[Diamond Wolf] Teleport tertiary item

Diamond Wolf: Some kind of powerup/tertiary for teleporting to it's location (destroyed on teleport, i.e. one-time usage?)

Dove-tail idea off of that, something like Ultima Underwold's silver seed/tree re-spawning for single player death?


Typescript   commonjs   import (lazy route) does not work

Version
3.0.3
Steps to reproduce
Create a Vuejs   Typescript project.
Set the module property in tsconfig as "commonjs".
Setup a lazy-route
What is expected?
I would expect the route to be lazy loaded
What is actually happening?
The route is not lazy-loaded. Route is included in the bundle

I've made a big research in internet - some people recommend using "esnext" as the module in tsconfig but that does not work for me. I have to use commonjs.

Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the forum, the Discord server or StackOverflow. This is related to Typescript, dynamic imports, and webpack or any bundler you are using


test: assert that client join degraded federations promptly

This test currently fails because joining the federation takes ~60 seconds if 1/4 guardians is offline:
Error: client join took too long: 60.644507708s

Do I assume correctly that joining a federation involves downloading the client config? If so consider to test removing the timeout in line 559 of fedimint-core/src/api.rs; its the only place where we use a turnout like this in a query strategy - I took it over from the previous implementation when I rewrote the download, do not really now why its there..? To me it Dows not make sense to timeout here.

Ahh, @joschisan thanks for the clue. I think the culprit is discovering the api version set, which uses a query strategy of AllOrDeadline, where we give a 60 second timeout.
https://github.com/fedimint/fedimint/blob/09fe6aa/fedimint-core/src/api.rs#L699
Raises the question of how do we want to handle discovering the api version set with a degraded number of guardians?

I think we could just make the timeout shorter here. We do ideally want to get API versions for all guardians since if we only have the version of e.g. 3/4 as other strategies would give us even though all are online then if one actually went offline we might be down to 2/4 guardians.
If we set the timeout to e.g. 5s the worst case when joining is waiting 5s too long. Ever consecutive startup of the client should be fast (TODO: test) as the versions are updated asynchronously in the background (we can generally assume that old API versions stay around for long enough to not require an immediate switch).

@justinmoon Thanks for flagging the issue in the PR. We can close since we're handling here: https://github.com/fedimint/fedimint/pull/4247#discussion_r1495638960


Set automationaccount context

it would be great to have the ability to "connect" to a given automation account so that subsequent commands related to that account could be typed without specifying the automation account. Could be as easy as saving the automation accont in a $script: variable, and just look at that if the automationaccount parameter isn't specified (and then failing if none of them have a value).
function name could be "Connect-ArmAutomationAccount" or "Set-ArmAutomationAccountContext" or similar.

ping @bgelens

resolved via https://github.com/PSBlue/Blue/pull/31


Add Google analytics tracking to blog

Like the title suggests, this PR is to add google analytics tracking to the blog.
This is the same GA tracking id used for the underdog.io and blog.underdog.io (at the request of josh).
/cc @twolfson

I should also mention that the current underdog.io and blog.underdog.io only record on a per-path basis, not a full URL so we have some conflation of data. This will be one more point of conflation =/

Yeah :/
I asked Josh about that earlier, he doesn't seem to be too concerned with it.

The gist of it looks good. Have you verified that the npm run build HTML files have the GA script whereas development ones don't?

Well, now with the change, it is npm run build has the production GA id and anything else uses the development GA id.

Ah, right. That was what I meant. And that's good to head =)

Ok, I think I like this much more. Hope you agree :)

:+1: :100:

But please fix the ^ to a ~ before landing