Chain loaders?

Something that I haven't understood yet from this plugin is, how I could use multiple loaders. I.e.:
    loaders: [
      {
        test: /\.css$/,
        loader: ExtractTextPlugin.extract('style', 'css')
      }
    ]

Logically, this will run CSS files through the css-loader and then through the style-loader and capturing its output (i guess?). But how do I apply multiple of these? Say I want to use some less files also but put their output into the bundled CSS as well. How do I do this?

I think you might be able to get away with
loader: ExtractTextPlugin.extract('style', 'css', 'less)

Remember to have less-loader installed.
I haven't tried this so no guarantee it will works. Worth a go, though.

loader: ExtractTextPlugin.extract('style', 'css!less')

@sokra but that will execute the loaders once per each css file. What about the case when someone wants to execute a loader at the whole result of ExtractTextPlugin ? A.k.a. apply a loader to the merged file?
Like running postcss' cssnano?

That's not supported. But you can write a webpack plugin that does that.

I though something like this. Thank you, @sokra . It's still beyond me to write a plugin but may be I'll be able to at some point.
And thank you for developing webpack ecosystem. A frontend revolutionary piece of software.

@antitoxic close this then?

@necolas My question is answered. If everyone else is happy close it  with no worries.

For some weird reason it works for me:
{test: /\.(less(\?.*)?)$/, loader: ExtractTextPlugin.extract("css!less")}

while it doesn't
{test: /\.(less(\?.*)?)$/, loader: ExtractTextPlugin.extract("css", "less")}

It fails to parse LESS syntax.
Shouldn't be the same thing?!
I prefer to use native datastructures over DSL so I used this
{test: /\.(less(\?.*)?)$/, loaders: ["style", "css", "less"]},

before ExtractTextPlugin and everything were fine.
Also I don't understand whether style loader is required with ExtractTextPlugin or not.
Some examples show it with style included and some without.

@ivan-kleshnin try loader: ExtractTextPlugin.extract('style', 'css!less') as @sokra mentioned above.  I'm not sure why exactly the plugin method signature for extract is writen like that, but I agree that its a bit confusing and it took me reading the source code for the plugin and finding this issue before I got it.

This works for me ExtractTextPlugin.extract('css-loader!stylus-loader').


Create method to change position

I recently needed an implementation to change the position of the iframe, there I created an auxiliary method for this.

Coverage decreased (-0.8%) to 92.676% when pulling d31ccea5c3b51af03bb84247d4abe98cb52d1414 on omarkdev:dev into bd8e617713bda53ac0e9541296c597f18171d92d on davidjbradshaw:dev.


Missing Images

The Azure DevOps images referenced in this article are not included in the repository. So, none of the images are rendering as excepted.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 11f43544-e181-b021-b362-dd7c5c631d7c
Version Independent ID: 01897be8-0c56-1e83-0e1e-8dea747911ec
Content: Configure package management for Maven with Azure DevOps Services
Content Source: docs/java/labs/mavenpmvsts/index.md
Product: devops
GitHub Login: @erickson-doug
Microsoft Alias: douge

@isaiahwilliams Thanks for letting us know, I'll take a look and see if I can find and restore those images.

On repro it appears this issue was addressed. Most likely thanks to this feedback- thank you.


Update sl_SI translation

Hello, this patch updates sl_SI translation according to the English origin.
Thank you for considering merging it in the repository.

Bumping in hope of getting any kind of response here. Is this repository active? Maybe something needs to be fixed in the PR? Thank you so much for your response and possible merge.

I'm guessing this is not much of a relevance. Closing...

@petk this is relevant, but we can't merge it without somebody versed in the language reviewing it

@petk @Ocramius Apart from that comment I left, LGTM.

@petk could you reopen? @archSeer thanks for the review!

@Ocramius done and reopened. I thought this repository is not active anymore. Well great then...
@archSeer fixed. Thanks for helping out.
Thanks for considering merging it and have a nice day.

@petk merged, thanks!


Binding a particular IP

It would be great to be able to bound a particular IP as the source address (for hosts with multiple IP addresses).

Interesting. How do you invision the usage?

related: https://github.com/shazow/urllib3/issues/9

^ shazow/urllib3#9

The goal is to write a crawler using an IP associated with a particular country. But I don't know how it would be used on a API level.

Couldn't you just send a request to an IP with a particular Host header?

No, because it's to have the specific IP in the web server log (to be reversed to a particular country using tools like GeoIP).

I don't follow.
>>> requests.get('http://<IP_ADDRESS>', headers={'host': 'ci.kennethreitz.com'})
<Response [200]>

import socket
import urllib2
true_socket = socket.socket

def make_bound_socket(source_ip):
	def bound_socket(*a, **k):
		sock = true_socket(*a, **k)
		sock.bind((source_ip, 0))
		return sock
	return bound_socket

socket.socket = make_bound_socket('<some source ip>')
print urllib2.urlopen('http://httpbin.org/ip').read()

socket.socket = make_bound_socket('<some other source ip>')
print urllib2.urlopen('http://httpbin.org/ip').read()

If traffic going out from the two source ip numbers goes out through two different public ip numbers one should see these different public numbers in the origin field of the response.

I think this is out of scope.

Specify host header does not work in SSL with SNI:
>>> requests.get('https://<IP_ADDRESS>/', headers={'host': 'www.zenlayer.com'})
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Library/Python/2.7/site-packages/requests/api.py", line 69, in get
    return request('get', url, params=params, **kwargs)
  File "/Library/Python/2.7/site-packages/requests/api.py", line 50, in request
    response = session.request(method=method, url=url, **kwargs)
  File "/Library/Python/2.7/site-packages/requests/sessions.py", line 465, in request
    resp = self.send(prep, **send_kwargs)
  File "/Library/Python/2.7/site-packages/requests/sessions.py", line 573, in send
    r = adapter.send(request, **kwargs)
  File "/Library/Python/2.7/site-packages/requests/adapters.py", line 431, in send
    raise SSLError(e, request=request)
requests.exceptions.SSLError: hostname '<IP_ADDRESS>' doesn't match 'manage.c3edge.com'

So it would be useful if:

Possible to bind IP
Or, possible to specify SNI hostname

@kennethreitz If I put following bind in /etc/hosts:
<IP_ADDRESS> www.zenlayer.com

Then it would work:
>>> requests.get('https://www.zenlayer.com/', verify=True)
<Response [200]>

But it does not work if:
>>> requests.get('https://<IP_ADDRESS>/', headers={'host': 'www.zenlayer.com'})
Traceback (most recent call last):
...

@kennethreitz Sorry, I found this page through a Google search, but after rescan the whole discussion I realized that the issue I'm having was not related to this one. I'll try to remove my unrelated replies now. Sorry!

import socket
import urllib2
true_socket = socket.socket

def make_bound_socket(source_ip):
    def bound_socket(*a, **k):
        sock = true_socket(*a, **k)
        sock.bind((source_ip, 0))
        return sock
    return bound_socket

socket.socket = make_bound_socket('<some source ip>')
print urllib2.urlopen('http://httpbin.org/ip').read()

socket.socket = make_bound_socket('<some other source ip>')
print urllib2.urlopen('http://httpbin.org/ip').read()

If traffic going out from the two source ip numbers goes out through two different public ip numbers one should see these different public numbers in the origin field of the response.

Just wanted you to know I've been scouring the internet for forever and this was the only solution that worked for me.


match-highlighter.js: add an option to skip single-match case

Currently, at CodeMirror 5.24, the match-highlighter.js addon unconditionally highlights a single match occurrence which is IMHO very misleading and confusing.
It'd be nice if there was an option to avoid highlighting when only one match is found.

Overlays should not have side effects, so you can't use them to do what you're trying to do here. I'm okay with the current behavior, so if you want something else, you'll have to create your own fork of the addon.

The "side effect" refers only to my hacky implementation which has nothing to do with the feature if I understand your objection correctly. You can simply disregard that code and what it implies.
The idea per se may be implemented properly if you can extend CodeMirror's overlay API so that when token() is invoked from highlightWorker's doc.iter it receives an additional parameter to indicate start/stop of the iteration in this run of highlightWorker and a parameter to indicate the overall completion.

No, that's fundamentally not how overlays work. They take text input and output styling without knowing about anything else. That's how they can be cheap and efficient, and it's not changing.

Not knowing the stage of processing is not what makes overlays fast, obviously, and I don't know why you appear to think there's a direct connection.
On the other hand, knowing the processing state would open more possibilities at an effectively zero cost of comparing a boolean parameter or a line index number. For example, with the latter it would be possible to alter overlay behavior based on proximity to the active line. And that's just one example off the top of my head.

Not knowing the stage of processing is not what makes overlays fast, obviously, and I don't know why you appear to think there's a direct connection.

Because I designed and wrote this code. But thanks for explaining it to me.

That ironic retort sounds like you didn't read the second paragraph. Welp, I guess I'm not good at selling ideas so I see no point of pursuing this further.


module 'eulerian_magnification' has no attribute 'load_video_float'

Hello,
When using the module downloaded from pip, I get this error when trying out the sample code from the readme.
My video is an .mp4 file taken from the paper.

I don't think this library is currently in a functional state.

Also I think you forgot to include the error.

Oh its in the title :smile: whoops.

the pip version is old. Just copy github version to python packages and then you should have that function. But when I run em.eulerian_magnification(vid, fps, freq_min=50.0 / 60.0, freq_max=10.0, amplification=20, pyramid_levels=3) I get MemoryError:
     42                 vid_pyramid.append(
     43                     numpy.zeros((video.shape[0], pyramid_sub_frame.shape[0], pyramid_sub_frame.shape[1], 3),
---> 44                                 dtype="float"))
     45
     46             vid_pyramid[pyramid_level][frame_number] = pyramid_sub_frame

you can use like this
import eulerian_magnification as em
from eulerian_magnification.io import load_video_float
vid, fps = load_video_float('data/Normal/Normal1.mp4')


Create Fibonacci Series

C program to display fibonaaci series

It is a c program to display the fibonacci series of n terms where n is entered by the user


Code structure and parsing  of 'entity to value' and 'entity -> relationship -> entity'

Shifting all discussions related to this topic here, as it spans across multiple pull requests.
Earlier discussion with Jakub https://github.com/buildingSMART/ifc-gherkin-rules/pull/62
In response to Stefan's comment https://github.com/buildingSMART/ifc-gherkin-rules/pull/80#discussion_r1334667879, it might be beneficial to consider reorganizing the structure. Broadly speaking, when parsing Gherkin statements related to values and attributes, it seems we encounter two distinct scenarios:
Direct value-to-attribute linkage, as observed here, such as "The type of the attribute 'Items' must be IfcCurveSegment."
Through relationships: mapping from one entity to another, like "An IfcAlignmentSegment nests an IfcAlignmentHorizontalSegment". This can further have a conditional statement: "value -> relationship -> entity -> condition".

Intuitively, I think this approach would simplify the process by parsing the information into more manageable chunks, leading to more consistent and replicable code. This would consolidate relationship terms (like nesting, containing, associating) into one location alongside the entities (e.g., IfcRelAssigns, IfcRelAssociates, etc.). The conditions can be categorized separately, encompassing clauses like "if X is present", "a list of only", or "num instances of".
Regarding the condition to a 'given' statement. Currently it's kind of mixed, perhaps adding to the horror and inconsistency. For instance
  Given A file with Model View Definition "CoordinationView"
    And A file with Schema Identifier "IFC2X3"

   Then There must be at least 1 instance(s) of IfcBuilding
    And The IfcBuilding must be assigned to the IfcSite if IfcSite is present
    And The IfcBuilding must be assigned to the IfcProject if IfcSite is not present

Change to
 Background:
  Given A file with Model View Definition "CoordinationView"
    And A file with Schema Identifier "IFC2X3"

  Scenario 1 : The IfcBuilding must be assigned to the IfcSite if IfcSite is present
   Given IfcSite is present # condition
   Then A relationship from IfcBuilding to IfcSite  # entity -> rel -> entity
   And The relationship is must be 'assigned'

   Scenario 2: # The IfcBuilding must be assigned to the IfcProject if IfcSite is not present
  Given IfcSite is not present
  Then  A relationship from IfcBuilding to IfcSite # or to/from, as @aothms implemented before
   And The relationship is must be 'assigned' # entity -> rel -> entity

  Scenario 3:
   Then There must be a least 1 instance(s) of IfcBuilding

Or
  And An IfcAlignment
  Then Each IfcAlignment must be directly contained in IfcSite

To
Given An IfcAlignment
And A relationship from IfcAlignment to IfcSite
Then The relationship is 'directly contained'

A potential addition could involve adding an extra table to the database that stores previously identified relationships between two entities. This could optimize the search process; if we already know that the relationship between IfcEntity1 and IfcEntity2 is defined as ["X"], the system can begin its search based on this established connection.

@aothms @Ghesselink is this still valid or obsolete?


HAWKULAR-1208 Replace Server-Added Event Notification

add new /notification endpoint for rest-based notifications

Migrate PingHandler -> ApiHandler for all /api services

add a few ResponseUtil utils for easy message-based responses
remove inventory event handler for add/remove server events
ListenerUtils: add ability to generate event only if it doesn't exist
comment out unused hystrix filters and dependencies
replace wordnik.swagger deps with io.swagger deps

@jmazzitelli @pilhuhn So this PR is a POC for server-side support of the "Server Added" event feature.   It's basically a simple service at the services [glue] level that can take a notification (type and property map) and do what we want with it.  For a RESOURCE_ADDED notification it would generate an event for MIQ consumption, if necessary.  If the event [id] already exists it won't create another one.
I think by locating the logic in the glue code and just letting the agent generate notifications based on some new resource-type config meta-data (see dev list discussion), we may be in decent shape.  The agent doesn't have to be smart or change anything based on a change to MIQ integration or whatever. We eliminate the inventory hooks and don't rely on metrics.  The glue code just interacts with the events api offered by alerting.
If this looks promising we could look at adding the agent support.

retest this please

@jmazzitelli @jotak @pilhuhn  I think this can be merged.  The agent side PR is being generated but will be marked DoNoMerge as is currently depends on a SNAPSHOT version of the server (and also needs some test).  Step 1 is to merge this PR, I think, assuming no objections.

Setting back to DNM after a chat with @jmazzitelli.  Will move new client jar module to commons to avoid a circular dep issue with the agent...

Updated to use new common hawkular-client-api.jar to get rid of circular dep issues with the agent.  Still set to DNM because of snapshot deps on commons and the agent.

Running all of this results in the following for me:
14:55:59,806 WARN  [org.hawkular.rest] (default task-19) RestEasy exception, : javax.ws.rs.NotFoundException: RESTEASY003210: Could not find resource for full path: http://localhost.localdomain:8080/hawkular/api/notification
...
14:55:59,812 ERROR [org.hawkular.agent.monitor.storage.HawkularStorageAdapter] (OkHttp http://localhost.localdomain:8080/...) HAWKMONITOR010083: Failed to store notification: {"type":"RESOURCE_ADDED","properties":{"resourcePath":"/t;hawkular/f;d9cd8940-60e4-4944-b0dd-3342a1a7d6d2/r;Local~~","resourceType":"WildFly Server"}}: java.io.IOException: status-code=[500], reason=[Internal Server Error], url=[http://localhost.localdomain:8080/hawkular/api/notification]
	at org.hawkular.agent.monitor.storage.HawkularStorageAdapter$4.onResponse(HawkularStorageAdapter.java:513)

retest this please

retest this please

retest this please


agate: 3.2.3 -> 3.2.4

Description of changes

Bump agate to 3.2.4
Note: I've not ran the VM test yet since it was building loads of stuff
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[X] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 173494 run on x86_64-linux 1

1 package built:

agate


merge from template-sync/template-coveralls

package.json

chore(deps): add ^5.6.2 remove ^5.5.4 (devDependencies.typescript)

:tada: This PR is included in version 6.11.30 :tada:
The release is available on:

npm package (@latest dist-tag)
v6.11.30
GitHub release

Your semantic-release bot :package::rocket:


scx: 1.0.3. -> 1.0.4

:fish: What?
Updates hash and rev for scx.
:fishing_pole_and_fish: Why?
Was outdated.
:fish_cake: Pending

[ ] Complain with linter;
[ ] Remove some temporary fix;
[ ] Publishing to news' channel.

:whale: Extras

i REALLY love banana pie XD

Won't work, needs a full rewrite to fully use their Cargo.lock now


3.0 Changed AsNoTracking identity resolution

According to the Breaking Change Doc
the following is no longer true

No tracking queries still perform identity resolution within the executing query. If the result set contains the same entity multiple times, the same instance of the entity class will be returned for each occurrence in the result set.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f3ffc114-df51-0be7-8972-6fcead14e011
Version Independent ID: 94c34571-7314-aab1-7898-93ac6d0f3430
Content: Tracking vs. No-Tracking Queries - EF Core
Content Source: entity-framework/core/querying/tracking.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @rowanmiller
Microsoft Alias: divega

Duplicate of #1412
On my radar to update soon.

@smitpatel #1412 seems like it is about a change in the tracking of Query types.

@joelweiss - It is about all related changes around tracking in 3.0. Like tracking when doing client eval etc. I will update it all.


On Search button, there is history visible of the searched data

Describe the bug
On the search button, one can see the search history when clicked on the button. It should be off to have privacy for the site users.
To Reproduce
Steps to reproduce the behavior:

Go to 'Home page -> Projects -> Search Projects'
Click on 'Enter Projects to search '
See error

Expected behavior
Disabling search history
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Raised a PR: #1578 for addressing the issue

plz assign this issue to me under ssoc this is my first contribution I m begineer


ReWrite: .permissionsFor(member) doesn't account for channel permission overwrites.

^

Can you elaborate? Works fine for me.

Fixed in b18aaa8711fa7e800a84612d058fb67814665c47, it broke when switching from arrays to collections ;)


Make undo remember cursor position and selection

This is a problem xi-editor had too (https://github.com/xi-editor/xi-editor/issues/458): Undo is done as part of the CRDT engine, which does not know about cursors.
I see two viable implementation strategies:

wrap around the CRDT undo API and memorize cursor positions outside (this may need to interact with more of the CRDT for cursor offsets, idk)
Fork xi-rope
Don't do this (deliberately not counted towards the viable implementation strategies, as this would be garbage UX)

Additionally, any other marks also need to be aware of undo: Some, if not most, should just be recomputed (i.e. marks for inlay hints, or whatever we may use them for). Others (i.e. the carets of users other than the one that just did the undo) should apply a coordinate transform.

From discord:

so every mark has a u32 offset, a kind, an affinity, and maybe a user id (worst-case scenario). that makes it about 12 byte.
let's say we have a pessimistic number of about 100 marks, that makes it 1.2kb
let's now say we just naively store all marks for each history revision, at about 2000 undo history steps
that makes for a worst-case size of 2.4mb just to store caret history
let's, more realistically, assume we just recompute most marks anyways, so we just care about the ~1-5 user carets for the revision history
that would mean 120kb for caret history
I don't think that's an issue, is it?


[WIP] Added support for BERT.

This PR adds support for BERT. It is not ready to merge yet.
I believe that the following features should be moved to swift-apis if people agree:

A new Embedding that ought to support using matrix multiplications instead of gather ops for faster execution on TPUs (this is currently commented out due an AutoDiff bug). This can replace the existing layer in swift-apis and should be backwards compatible.
A MultiHeadAttention layer that can be used for other models too (other than BERT or Transformers).
A Regularizable protocol that I don't really like, but it's a temporary solution for supporting weight decay in BERT. We probably shouldn't move this to swift-apis until we have thought out a nicer solution.
A new Optimizer protocol that supports learning rate schedules and a  WeightDecayedAdam implementation.
ScheduledParameter corresponds to tensorflow/swift-apis#431.

The following features are also added:

Multiple text tokenization approaches, including a byte-pair encoding (BPE) tokenizer as well as a WordPiece tokenizer.
A Transformer implementation.
A BERT implementation that supports multiple variants (i.e., BERT, RoBERTa, and ALBERT).
Support for automatically downloading and loading pre-trained models for all these variants.

Note that for RoBERTa I had to convert the published PyTorch checkpoints to TF checkpoints compatible with this model. I have uploaded these to my Dropbox account, but they take too much space, so I would really appreciate it if we could move them to Google Cloud Storage.
This is not ready to merge yet, but is rather aimed at getting feedback to improve the API and also making sure that the code style is compatible with this repository. A big open question is, how do we want to test this? I know it's working fine as I'm using it for my own research projects, but I don't know what kind of tests would be appropriate.
Sorry if I missed something in this list of changes. I'll keep updating it as we refine the PR.
NOTE: The new layers are not generic over the Scalar type due to a compiler bug (TF-427).
NOTE: Compilation is currently failing because the synthesized TangentVector initializers are internal and I cannot declare conformances to Regularizable without using those initializers.
cc @saeta @dan-zheng @BradLarson

This is absolutely huge @eaplatanios. I've been working on BERT for the past few months and can't wait to check this code out :).

@eaplatanios What do you think about restructuring the encoding techniques under a preproccessing directory either in this repo or the swift-apis repo, These techniques are used everywhere.
I'm also suggesting for a preprocessing directory, because down the line if we image preprocessing techniques including augmentatation, this structure would benefit that as well.
cc: @BradLarson @saeta

I think we could take some inspiration on how to test these models from how these are done in pytorch-transformers, as @saeta mentioned in the design meeting, they do just check loading the model and check if the tensor shapes are right. You can take a look at these tests here.

I'd like to see what can be done to help drive this to completion. I forget where we left things after the community meeting, but is the biggest blocker right now the compilation errors around TangentVector and the activation functions in Attention.swift?
If there are areas you'd like me to look into, I'd be glad to do so.

Thanks @BradLarson ! The only blocker is the TangentVector initializer. The issues related to attention have to do with supporting generic BERT layers (currently they're just Float-valued).

Please also let me know what you guys think should be pushed to swift-apis and what kind of restructuring and testing would be useful. :)

Now that the TangentVector visibility issues have been resolved, is there anything else blocking the core model? If so, I'd love to see what we could do to resolve that.
Beyond the core model, do you have an example of BERT in action or a unit test of it that we can use to verify correct operation? If those are too tied up in any internal infrastructure you have, we could potentially pull this in and I could add a demo and / or tests as a follow-on, but if you have simple demo code for this that would really ease the process of pulling this in.
We can merge together the existing Transformer demo and the new Transformer model and utility functions you have here to migrate our text generation demo over to this new structure, but didn't know if there was a similar demo you had available for BERT.

I merged the tensorflow:bert-wip branch into eaplatanios:bert. This includes the following changes:

Some merge conflicts were fixed.
Some differentiation-related compilation errors were fixed.
A training loop for BERT was added in Models/Text/main.swift.

A BERT.PreTrainedModel.bertBase pretrained model is loaded and trains on the CoLA task. You can run it via swift run TextModels.

Consider generalizing DatasetUtilities.downloadResource to support URLs that don't end in the zipped file name. The CoLA dataset URL is one such example. Alternatively, we could host the dataset elsewhere.

Improve code organization.

Currently, most BERT code lives at the top-level in Models/Text. Models/Text could be better organized, like Models/ImageClassification.

Verify that BERT training converges, and that results match a reference implementation.
Verify that other BERT variants work.

BERT variants like roberta and albert were added in this PR but are untested.

swift run TextModels works with latest Swift for TensorFlow toolchains:
$ swift run TextModels
...
[Step: 41]	Loss: 0.3939771
[Step: 42]	Loss: 0.7205323
[Step: 43]	Loss: 0.4848549
[Step: 44]	Loss: 0.2727359
[Step: 45]	Loss: 0.3460037
[Step: 46]	Loss: 0.9574833
[Step: 47]	Loss: 0.7397041
[Step: 48]	Loss: 0.35861257
[Step: 49]	Loss: 0.4990799
[Step: 50]	Loss: 0.92075384
Evaluate BERT for the CoLA task:
Total predictions: 1043
True positives: 719
True negatives: 34
False positives: 288
False negatives: 34
["matthewsCorrelationCoefficient": 0.26019016]

If there are no objections, now seems like a good point to merge this PR and continue incremental improvements. Thanks @eaplatanios for driving this work!

Thanks @dan-zheng and @BradLarson for getting this in! I'm sorry I haven't had too much time lately to address some of the mentioned todos.


Fix #2575

Add an event.stopPropagation to changeSlide handler to prevent click events to propagate to parent container.

Excellent fix. Looks like some changes were made to .gitignore and ISSUE_TEMPLATE.md
I think the change to .gitignore makes sense, but should be in a separate commit, and I think the ISSUE_TEMPLATE.md changes might be by mistake?
Once that get's cleaned up I think we can get this merged.
Thanks @natete

Perfect, why isnt this already merged ?

Guys, please merge this, it is very useful fix

I removed the files I committed by mistake, I think you can proceed now with the merge.


Unable to use React class for custom header / cell renderer

Describe the bug
I am trying to use a custom header and cell.  These cells use a ref, and as such cannot be a stateless functional component.  According to the documentation:

Renderers
React Table supports very flexible renderers for just about everything:
Cell - Renders a standard cell
Header - Renders a column header or column group header
Footer - Renders a column footer
Filter - Renders a column's filter UI
Aggregated - Renders an aggregated cell
Pivot - Renders a pivoted cell (by default, will utilize Expander and PivotValue renderers)
PivotValue - Renders the value inside a Pivot renderer
Expander - Renders the Expander used in both the default Pivot renderer and any expander-designated column
Any of these renderers can be one of the following:
A React Class
JSX or any rendered react component
Stateless functional component
Function that returns any primitive

However, when I use a react class, I get the following error:

main.js:116313 Uncaught TypeError: Cannot call a class as a function
at _classCallCheck (main.js:116313)
at DeleteIcon (DeleteIcon.jsx:7)
at Object.normalizeComponent (utils.js:224)
at makeHeader (index.js:336)
at Array.map ()
at makeHeaders (index.js:362)
at makeTable (index.js:758)
at ReactTable.render (index.js:790)
at finishClassComponent (react-dom.development.js:13727)
at updateClassComponent (react-dom.development.js:13690)

To Reproduce
I am trying to use a React class to accomplish this. For example:
import React from 'react';

export class DeleteIcon extends React.Component {

  render() {
    return (
foo
);
  }

}

In my class using ReactTable:
        <ReactTable
          className="-striped -highlight"
          defaultSorted={[{ id: 'id', desc: false }]}
          loading={!fetched}
          columns={[
            {
              Header: DeleteIcon,
              id: 'delete',
              accessor: 'id',
              className: 'text-center',
              minWidth: 35,
              resizable: false,
              filterable: false,
              sortable: false,
              Cell: DeleteIcon,
            },
          ]}
          data={data}
        />

If I try to wrap my real implementation of DeleteIcon (with ref) in a functional component, I get the following warning, which results in a error in the component:

Warning: Function components cannot be given refs. Attempts to access this ref will fail.

Expected behavior
I should be able to use a React class for a custom header / cell without wrapping in a functional component.

This is also an issue on our system. Cell actually works just fine with this:
columns={[
{
Header: DeleteIcon,
id: 'delete',
accessor: 'id',
className: 'text-center',
minWidth: 35,
resizable: false,
filterable: false,
sortable: false,
Cell: (row) => {
return <SomeReactComponent {...row} />
},
},
]}


plaintext_request fails

plaintext_request calls make_request with is_json=False, which then runs the data through urlencode_utf8 to get a urlencoded string.  The data param of requests.post requires a dictionary (this is a difference from urllib2), so the regid and other parameters are not passed to GCM, which then errors out.

Agree -
I had to comment out these 2 lines to get it to work:
if not is_json:
data = urlencode_utf8(data)
I do not know the issue behind... maybe different version of the url lib...

This problem occurs due to double percent encoding. The requests library already encodes the values passed in the data parameter of the post method.
This issue will be fixed by #77 soon


Fix isort v5

Codecov Report

Merging #130 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
- Coverage   92.55%   92.54%   -0.02%
==========================================
  Files          21       21
  Lines        2189     2186       -3
==========================================
- Hits         2026     2023       -3
  Misses        163      163

Impacted Files
Coverage Δ

medallion/__init__.py
80.45% <100.00%> (-0.66%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25666e8...eb7e178. Read the comment docs.


Update assistants-reference-messages.md

Fixed typo & added formatting

@mrbullwinkle
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Add examples/ to CI UT/IT ignore

Skip Java UTs and ITs when there are changes to examples folder which contain the quickstart tutorials. Also, sort the  ignored paths.
This PR has:

[x] been self-reviewed.

I think GHA is running all the CI checks because of the change to workflow file. I can't think of a way to test this change besides verifying it later in a follow on test PR once this PR is merged to master. The test commit has now been reverted

This shouldn’t have been merged. ITs use files in examples directory which
is why we don’t skip ITs when there are changes in examples folder.
On Thu, 18 May 2023 at 6:16 AM, Clint Wylie @.***>
wrote:

Merged #14306 https://github.com/apache/druid/pull/14306 into master.
—
Reply to this email directly, view it on GitHub
https://github.com/apache/druid/pull/14306#event-9274705172, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AALIWUIQPGAKXNLGAJYO4EDXGVWPHANCNFSM6AAAAAAYFTSL6Q
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

This shouldn’t have been merged. ITs use files in examples directory which is why we don’t skip ITs when there are changes in examples folder.

I guess I assumed that any changes there with test implications would also have changes to java files, though if that's not true we can revert this

@abhishekagarwal87 what part of the Java UTs and ITs rely on the example QuickStart stuff? Do we need some restructuring?

@abhishekrb19 - you will find various examples if you search for examples in the integration-test module. The examples are not changed frequently so it's just best to not skip them altogether. can you revert this change?


Wallet Service + SignalR improvements - Core pre-requisites

This PR includes the following changes

Remove logic from WalletController and Create Wallet Service to allow for re-use and consistency between different Transports (Currently RestApi and SignalR - "RPC requires more investigation")

ServerSide Paging for history, future versions of Core to use infinite scroll

Full Async support on Wallet Controller, with cancellation tokens

SignalR GetMessages  now Async with linked CancellationToken, restricted to 10 seconds execution time

Add Ability to send SignalR Messages, currently implemented  to configure SignalR Broadcasters from the client

Improved Test composition by using AutoMock.

Created BoilerPlate code for Controllers to force consistency of validation and error handling for RestApi's

@ArcSin2000X I have tested this extensively on the test tool and all seems well 👍


Bookmark option

Is your feature request related to a problem? Please describe.
There should be a bookmark option in a blog. If a user bookmarks any blog It should add to his bookmark list.

I would like to work on this issue...

Go ahead @ManishShah120 :+1:


[1.3] Scheduled-job approval/dry-run REST API doesn't enforce object-based permissions yet

Environment

Python version:
Nautobot version: next after #1457

Expected Behavior
REST API for scheduled job approval/dry-run/deny needs to enforce the same set of action and object-based permissions as the UI views do. Tests need to be added to verify these permissions, similar to what was added in https://github.com/nautobot/nautobot/pull/1457/commits/7c4e47442972b5d45c45a8a299df7b71c6899796 for the UI views.

Observed Behavior
These REST API endpoints require extras.run_job permission for all three actions, do not require extras.approve_job permission, and do not enforce object-based permissions on extras.run_job.

Implemented in #1490.


GPG key for Debian repository(PPA) should be served over HTTPS

As of a couple days ago, I've taken notice to the fact that the GPG key used to sign the Debian repository is served over HTTP.
Background
GPG is like HTTPS for a Debian repo - it's what validates that the content received from a server is actually from the server.
If the GPG key itself is modified during download(which is made possible due to the lack of HTTPS), this would allow an attacker to modify other contents in a repo such as the Release file, Packages file, and all debs, and APT on the client wouldn't complain, and would just go about installing the package.
In the current state that things are usually done, a GPG key also gives that same level of privilege to all other repositories on a system served over HTTP. This could have implications outside the DogeHouse repository, as a modified GPG key will allow an attacker to modify packages on other repositories served over HTTP while being delivered to the client, such as the Ubuntu and Debian repositories.
Fix
My proposal is to simply serve the repository, or the GPG key at minimum, over HTTPS. It takes a matter of seconds to set up with Let's Encrypt, and there aren't many other reasons not to.
A lot of big-name players in the server space also serve the contents for their Debian repositories over HTTPS, including:
Docker: https://docs.docker.com/engine/install/ubuntu/#install-using-the-repository
Atom Text Editor: https://flight-manual.atom.io/getting-started/sections/installing-atom/
Jenkins CI: https://pkg.jenkins.io/debian-stable/

If I remember correctly, there is a Cloudflare setting where Cloudflare will be responsible for providing SSL to the client (while still working with HTTP servers).

@drvladb That would work, except that the connection between Cloudflare and the server would still be over HTTP, allowing the connection to still be modified(between Cloudflare and the server). You can find some info on it here and here.
I'm not against it or anything(actually for it), but it doesn't look like the repo is using a Cloudflare proxy right now anyway(which is needed to utilize the flexible ssl option as per the links above)

@benawad Would you or anyone else have any updates on this?


All goma tasks switch to local fallback.

As of this morning, all goma jobs are falling back to local execution. This significantly slows down local development. Goma has been updated and restarted with no lingering processes. The engine is at TOT. Some information about the local environment:
GOMA Version: e78b10f2654ab6e8805ea60892e384c0e5f04522@1656292154
GOMA Flags:
GOMA_BURST_MAX_SUBPROCS=72 (auto configured)
GOMA_BURST_MAX_SUBPROCS_HEAVY=18 (auto configured)
GOMA_BURST_MAX_SUBPROCS_LOW=72 (auto configured)
GOMA_COMPILER_INFO_POOL=8 (auto configured)
GOMA_COMPILER_PROXY_DAEMON_MODE=true
GOMA_COMPILER_PROXY_ENABLE_CRASH_DUMP=true
GOMA_COMPILER_PROXY_HTTP_THREADS=9 (auto configured)
GOMA_COMPILER_PROXY_LOCK_FILENAME=goma_compiler_proxy.lock
GOMA_COMPILER_PROXY_PORT=8088
GOMA_COMPILER_PROXY_SOCKET_NAME=goma.ipc
GOMA_COMPILER_PROXY_THREADS=36 (auto configured)
GOMA_DIR=/Users/chinmaygarde/VersionControlled/depot_tools/.cipd_bin
GOMA_INCLUDE_PROCESSOR_THREADS=36 (auto configured)
GOMA_LOG_CLEAN_INTERVAL=86400
GOMA_MAX_SUBPROCS=8 (auto configured)
GOMA_MAX_SUBPROCS_LOW=7 (auto configured)
GOMA_PING_TIMEOUT_SEC=60
GOMA_PROVIDE_INFO=true
GOMA_SEND_USER_INFO=true
GOMA_SERVER_HOST=<IP_ADDRESS>
GOMA_SERVER_PORT=19080
GOMA_TMP_DIR=/var/folders/36/jgm8vhqx1z33f0d67pppnxpc009h5t/T/goma_chinmaygarde
GOMA_USE_SSL=false

Local Compilers:
clang++ ../../buildtools/mac-x64/clang/bin/clang++  15.0.0[Fuchsia clang version 15.0.0 (https://llvm.googlesource.com/a/llvm-project aaaf8e4c409f080f35ea227b20dc6ac8a45c2fa4)]  1d2afcccea7be7d097f852f246abd9fa075a408d47a7910c30f8bb34e90565c1
clang ../../buildtools/mac-x64/clang/bin/clang  15.0.0[Fuchsia clang version 15.0.0 (https://llvm.googlesource.com/a/llvm-project aaaf8e4c409f080f35ea227b20dc6ac8a45c2fa4)]  1d2afcccea7be7d097f852f246abd9fa075a408d47a7910c30f8bb34e90565c1

Flutter Engine Revision: 3868f93222a1e283746ee952bae1c02389ea347b

Looking into this.

I attached the compiler hashes to the issue so we could check if GOMA is aware of the compiler version. I don't know how to do this myself unfortunately. I will look at the last toolchain revision and revert that to see if builds are any faster. Momentido.

@chinmaygarde Thanks, I've also reached out to goma ops to see if theres some even on their end that might be contributing to this.

That did not do it. The last Clang roll was more than a couple of weeks ago.

@chinmaygarde it looks like the fleet is now recovered. Can you please confirm things are working on your side now?

This appears to be resolved.


incompatible for go module

it is a nice  package !  it would  be  better if  it is available as go module。
why not  add a go.mod  under  its root directory.

@tylitianrui This should be fixed in https://github.com/judwhite/go-svc/releases/tag/v2.0.0


(maint) Mergeup 5.2.x to 6.0.x

Keeps Docker assets intact that were deleted from the prior 5.x series
branches.

CLA signed by all contributors.

Test PASSed

This PR should have also carried forward changes from https://github.com/puppetlabs/puppetdb/pull/2818/commits/b639fb6c95f95533620bd60355c250517d569a5b to the 6.0.x branch instead of removing them - a separate PR will carry those forward.

#2820 fixes the omission


Add platform setting for queue_monitor_length_notify_support

Change Summary

Add platform setting for queue_monitor_length_notify_support
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes)
[ ] Documentation content changes
[ ] Other (please describe):

Related Issue(s)
Fixes #1005
Component(s) name
arista.avd.eos_designs
Proposed changes

Introduce a new knob under platform_settings to specify if the CLI queue-monitor length notify is supported.
This is needed since EOS from 4.25.x rejects this command on unsupported platforms.
platform_settings:
  - platforms: [ < Arista Platform Family >, < Arista Platform Family > ]
    queue_monitor_length_notify_support: < true | false | default -> true >

Also updating the default platform_settings to leverage this knob:
platform_settings:
  - platforms: [ default ]
    reload_delay:
      mlag: 300
      non_mlag: 330
    queue_monitor_length_notify_support: false
  - platforms: [ 7800R3, 7500R3, 7500R, 7280R3, 7280R2, 7280R ]
    tcam_profile: vxlan-routing
    lag_hardware_only: true
    reload_delay:
      mlag: 780
      non_mlag: 1020

The impact for running networks should be none, since the command would be ignored on non-R-series platforms anyway, but since this will change the defaults, we will merge this in for next major release (3.0.0)
How to test

We did not have molecule testing of queue_monitor_length so added that on scenario where we have different platforms.
Checklist:

[x] My code has been rebased from devel before I start
[x] I have read the CONTRIBUTING document.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have updated molecule CI testing accordingly
[x] All new and existing tests passed (pre-commit, make linting and make sanity-lint).

@kmueller68 please review this one as a fix for your issue #1005

@ClausHolbechArista Thank you very much for implementing this so fast. I will try to test this in our environment as soon as possible.

@ClausHolbechArista Thank you very much for implementing this so fast. I will try to test this in our environment as soon as possible.

@kmueller68 Note that we have changed the data model a bit, to make it easy to add new similar feature knobs in the future.


Inference and subcategories

I’ve been encountering inference difficulties when using Categories.Category.SubCategory. Below is a simplified example:
open import Level
open import Algebra.Bundles

open import Categories.Category.Core using (Category)
open import Categories.Category.Instance.Setoids using (Setoids)
open import Categories.Category.SubCategory (Setoids 0ℓ 0ℓ)

open Category (FullSubCategory Magma.setoid)

_ : ∀ {A} → A ⇒ A
_ = id

The error message (referring to the use of id in the last line):
__∙__16 : Algebra.Core.Op₂ (Magma.Carrier A)  [ at /Users/conal/Agda/cat-linear/src/T7.agda:11,5-7 ]
_∙-cong_19
  : Algebra.Definitions.Congruent₂ (λ z z₁ → (A Magma.≈ z) z₁)
    __∙__16  [ at /Users/conal/Agda/cat-linear/src/T7.agda:11,5-7 ]

If I replace Magma by a structure with more operations, such as Ring, I see more such errors, failing to infer each operation and associated property.
I’d appreciate any insights about causes and cures for this error.

And it was answered on the mailing list. For those who stumble upon this later: the implicits really can't be inferred here, so need to be given explicitly.


How to get article publication date?

If I have a pmid, how do I get the publication date of the article?
Also, what are the other properties of PubMedArticle.   I see that there are: title, authors, mesh, abstract, etc.   Is there a full list somewhere?
Thanks!

Hi @richardehughes ,
The PubMedArticle python object reflects the Eutils PubMedArticle XML object.
Specific information about date structure can be found here.
Unfortunately, implementation of publication date is under-featured metapub because generally speaking, the year is the only consistent piece of data you can get from the database.  Most articles have only a year and then are referenced by their volume and issue numbers relative to the journal they're in.
However, I think it would be reasonable to add a regularized "pubdate" special attribute to the PubMedArticle object.  It would take a bit of information gathering to ensure all the different XML formats are represented and supported.
This is the reason why I've never implemented a normalized pubdate before -- just look at the nonsense Entrez wants us to contend with.
So the answer is: for now, you just have to use PubMedArticle.year.
If you need the specific date right away, the PubMedArticle object provides access to the original data blob sent by Eutils on the .content attribute (a dict created directly from the XML).  So you'd drill into that and look for the date characteristics.
If you're ok waiting a week or two, I'll probably implement .pubdate as a normalized attribute across all of these different article types despite this being super annoying 😄  for one of the next minor versions.
Also: My apologies that it's still taking me a few days to look at new messages as I am actively improving metapub as well as a few other open source projects under my wing!    Thanks for your patience.

yeah, we need this feature~

Hi, any updates on this? This would be super helpful!

Hi there -- this definitely ended up being a relatively non-straightforward thing to make happen, as I expected.   Thanks for the patience.
Something that would help me do this faster is posting PMIDs here in this issue that are representative of the different formats that a PubMedArticle may contain.
This is just sort of a painstaking / tedious thing to do so I've been working on other things...


Whats about ver.2 Audio switcher?

We are waiting 3 years

Yes whats happening with development of v2


fix storage read and write

/tip small

Ah okay, of course the tip bot isn't set up for this repo

Very nice catch, thanks!
So this PR fixes two problems: The storage pointer values should not be truncated to the register size so that arbitrary storage keys work, not just ones that fall below our register size. And failed storage value reads now guarantee to return the zero value on error. Could you please add that to the description?

yes sure, I was waiting for you review first :)


Fix text alignment issues with upgrade cards + html2canvas

Fixed in https://github.com/retinue-app/react-swl/commit/d84040fa2ee7a97dae113644f174233306ebbf38.


Allow user to upload datapackages when not using SSL

This PR seeks to fix #92 where users cannot upload datapackages when the server is configured to use the TCP streaming protocol.
Confirmed working while running taky_deps on the command line and when installed as a systemctl service. I have not tested it with SSL on, as generating SSL certs are broken on Ubuntu >22.04.
Thank you @tkuester.

Hey @lucasburlingham ! Thanks for the pull request!
I had a small pedantic change, I ended up using Flask's app.config to check instead of passing around the app_config object. That's a rather ugly part of the code I plan to get rid of later. While I didn't pull your commit in directly, I'll make sure to credit you in the changelog!


This PR shouldn't break the tests

@Swizec please ignore this PR, it was used for demoing purposes.


Automated Package Upgrade

:tada: This PR is included in version 2.2.354 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


⚠ Spryr has degraded performance

In 3e1fd26, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 4227 ms

Resolved: Spryr performance has improved in 43ecfcc after 13 minutes.


Support sympy.physics.mechanics.dynamicsymbols as well as sympy.Symbol in SymPy backend

The SymPy backend should natively support sympy.physics.mechanics.dynamicsymbols as well as sympy.Symbol objects (as was the case prior to https://github.com/brocksam/pycollo/commit/24eb461975834279ecad098a58b9cb71b4a314a3). It is common for users to use sympy.physics.mechanics to derive equations of motion (EoMs) that are then used to construct their optimal control problem. These EoMs will be built from both sympy.physics.mechanics.dynamicsymbols and sympy.Symbol objects. It should be possible to directly set sympy.physics.mechanics.dynamicsymbols as state and control variables in the OCP definition when the SymPy backend is being used to save users doing a replacement to sympy.Symbol objects, which can be costly for large and complex models.
Note: the workaround until this issue is resolved is for users to manually substitute sympy.Symbol objects in place of sympy.physics.mechanics.dynamicsymbols before constructing their OCP via pycollo.OptimalControlProblem.

PR #67 has implemented the basics of this in a way that'll work with the CasADi backend. See the PR description for details about how it can be used. Particularly if you wish to access the state variables from Phase.state_variables as attributes using the symbol's name, the (t) of the me.dynamicsymbol is trimmed off. I.e. using me.dynamicsymbols("x") with name x(t) can be accessed by phase.state_variables.x.

Currently it's not possible to use Derivative(x(t), t) as state or control variables without error.


Update install.sh

Take user consent in one line.
Check root permission
remove use of sudo

Great @Athuli7, thank you!


⚠ BeyondHD has degraded performance

In 11c3ec0, BeyondHD ($BHD) experienced degraded performance:

HTTP code: 200
Response time: 7209 ms

Resolved: BeyondHD performance has improved in a1be205.


on mobile, swiping is very buggy

Open the demo page on mobile, swipe up many times fast. Somehow it scrolls to the second item, however we swipe opposite direction.
This is causing issues when I swipe down fast. It kinda loses control.

Maybe you need some debouncing/throttling for the event.


Clearing collection data from other subscriptions

Hi @ShivamArora
How can I reset / clear a client side collection which was populated from a subscription.
I have multiple subscription returning data from same collection but of different context / user. so I want that previously collected data in collection should not be there.
Thanks

I see unsubscribe does that.

Great to see you found a solution on your own. @davinderkumar


Set macosx_version to the full macOS version (e.g. 10.15.5)

Previously macosx_version was set to the major version (e.g. 10.5). A
new variable macosx_major_version is added to avoid numerious splits
and joins.
Any checks using vercmp will still work.
Closes: https://trac.macports.org/ticket/56252

Putting this up for comments on if this is the way to proceed.  There are a number of tests that set macosx_version that will need to be investigated.

Adding a new variable is fine, but changing the semantics of an existing one is an API break and should be avoided if at all possible. I don't think there's a compelling reason to break API here.

So you'd rather have macosx_version stay the same and add a new variable macosx_full_version?

I also prefer the other one

What's the compelling reason for not fixing how the existing variable works? Why perpetuate the mistake of having a variable called macosx_version that does not contain the macOS version but only a part of it? What use case are you envisioning where changing macosx_version to the full version would break something? I already went through the ports tree years ago to fix ports so that they would use macosx_version in a way that would work if it were the full version. Looks like this PR has gone through base to do the same there, or rather introduces a new macosx_major_version variable and uses that instead, which at least makes sense and names the variables in a way that clearly conveys what they contain.
We have previously made breaking changes without apparently caring about API stability. For example, platform blocks were changed so that they executed immediately (like an if statement) rather than deferred (like a variant) which broke several ports. We removed the cd command, requiring ports to adapt to that. We've renamed variables (livecheck.type used to be called livecheck.check). And quoting of env variables was changed, requiring some compatibility code to be added to portfiles for a time but that worked out fine.


Added more cypress testing cases

Screenshots:
https://user-images.githubusercontent.com/95460021/224496226-b8327a05-80f7-4c98-bce3-df9d2987e883.mp4
resolves issue #82

good work


Feature Form Controls Part 2

Proposed Changes
Implement missing form controls with Next.js
Potential Breaking Changes
I removed some components that are deprecated (chosen, dropdown search, ...)
Acceptance Criteria

[ ] The proposed changes are covered by unit tests
[ ] The potential breaking changes are clearly identified
[ ] README.md is adjusted to reflect the proposed changes (if relevant)

Codecov Report

Merging #1163 into feature-replace-jeyll-with-nextjs will increase coverage by 0.01%.
The diff coverage is n/a.

@@                          Coverage Diff                          @@
##           feature-replace-jeyll-with-nextjs    #1163      +/-   ##
=====================================================================
+ Coverage                              99.73%   99.74%   +0.01%
=====================================================================
  Files                                    350      350
  Lines                                   8546     8525      -21
  Branches                                2030     2024       -6
=====================================================================
- Hits                                    8523     8503      -20
+ Misses                                    23       22       -1

Impacted Files
Coverage Δ

...ges/react-vapor/src/components/chart/BarSeries.tsx
100% <0%> (ø)
:arrow_up:

...rc/components/table-hoc/actions/TableRowActions.ts
100% <0%> (ø)
:arrow_up:

.../components/table-hoc/reducers/TableRowReducers.ts
100% <0%> (ø)
:arrow_up:

.../react-vapor/src/components/chart/ChartTooltip.tsx
96.15% <0%> (+2.21%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d43cda...db68418. Read the comment docs.


If apihost already is fully qualified with a protocol, use it

I'm making a change on the openwhisk side so that the api host always contains the protocol. This make the inference here unnecessary (and will cause some breakage).

Thanks for updating this, I'll merge it and fix the tests later today.


feat(barcode-scanning): support all barcode types

Plugin(s)

[X] Barcode Scanning
[ ] Face Detection
[ ] Face Mesh Detection
[ ] Selfie Segmentation
[ ] Translation

Current problem
Currently, only the displayValue/rawValue of a barcode is returned.
However, the ML Kit Barcode Scanning SDK also offers the option of returning parsed data such as calendar event details or email details.
Preferred solution
Extend the barcode interface with the following properties:

CalendarEvent
ContactInfo
DriverLicense
Email
GeoPoint
Phone
Sms
UrlBookmark
WiFi

Example:
export interface Barcode {
  ...
  wifi?: BarcodeWifi;
}

export interface BarcodeWifi {
  encryptionType: BarcodeWifiEncryptionType;
  password: string;
  ssid: string;
}

export enum BarcodeWifiEncryptionType {
  OPEN = 1,
  WPA = 2,
  WEP = 3
}

Alternative options
No response
Additional context
No response
Before submitting

[X] I have read and followed the feature request guidelines.
[X] I have attached links to possibly related issues and discussions.

@robingenz 👋  could you pls assign this issue to me?

Closed by #206


"devcontainer features publish" fails to log in with Artifactory

We're using Artifactory as container registry and I'm trying to use it to store a Dev Container Feature. Unfortunately, the login fails.
I have setup a Docker credential helper to return the username and token, but we're not even getting there:
$ devcontainer features publish --registry docker-eu.artifactory.example.com -n my-repo/my-project devcontainer-features/src/git-absorb --log-level=trace
[3 ms] @devcontainers/cli 0.54.0. Node.js v20.9.0. linux 4.18.0-477.27.1.el8_8.x86_64 x64.
[3 ms] Packaging single feature...
[27 ms] Packaged feature 'git-absorb'
[34 ms] Processing feature: git-absorb...
[34 ms] > input: docker-eu.artifactory.example.com/my-repo/my-project/git-absorb
[34 ms] >
[34 ms] > resource: docker-eu.artifactory.example.com/my-repo/my-project/git-absorb
[34 ms] > id: git-absorb
[34 ms] > owner: my-repo
[34 ms] > namespace: my-repo/my-project
[34 ms] > registry: docker-eu.artifactory.example.com
[34 ms] > path: my-repo/my-project/git-absorb
[34 ms] >
[34 ms] > version: latest
[34 ms] > tag?: latest
[34 ms] > digest?: undefined
[35 ms] Feature Annotations: {"dev.containers.metadata":"{\"id\":\"git-absorb\",\"name\":\"Install git-absorb\",\"version\":\"1.0.0\",\"description\":\"Install git absorb (https://github.com/tummychow/git-absorb)\",\"installsAfter\":[\"ghcr.io/devcontainers/features/common-utils\"]}"}
[35 ms] Fetching published versions...
[251 ms] [httpOci] Attempting to authenticate via 'Bearer' auth.
[252 ms] [httpOci] WWW-Authenticate header is not in expected format. Got:  Bearer realm="https://docker-eu.artifactory.example.com/artifactory/api/docker/null/v2/token",service="docker-eu.artifactory.example.com"
[252 ms] Request failed
[252 ms] (!) ERR: Failed to publish 'docker-eu.artifactory.example.com/my-repo/my-project/git-absorb'

The scope key is not part of the response, which seems to be allowed according to https://datatracker.ietf.org/doc/html/rfc6750#section-3 (as referenced in https://distribution.github.io/distribution/spec/auth/token/).
I'm not even close to understanding how the auth flow works, so I'd appreciate further input on that.
Container Registry: Artifactory Enterprise Plus 7.55.8 rev 75508900

With https://github.com/devcontainers/cli/pull/692 I'm able to successfully push a feature to Artifactory.

Thank you for reporting the issue and the quick fix, left a review comment.


redirect based on log level

I would like error messages to appear on console as well as a log file.
i would like info messages to appear only in the log file.
how can i have both?

You would configure your root logger to log at the error level to console and configure a second info logger that uses a separate appender which logs to a log file.

how can i have multiple loggers for the same crate?
Let's say i have the crate foo_bar, how can I define multiple loggers for it?

Closing due to inactivity.


Enhancement: Add the possibility to require npm packages in transformers

It seems that it is currently not possible to use require("...") in transformers (transporter does not send any document when require is being used). NPM packages would add a lot of possibilities in the transform step when it comes to parsing and rewriting fields.

Ok, I checked the code and discovered that transporter uses the Otto javascript VM (I was assuming that it uses node) - It won't work then I guess :)

I think we could probably build some functionality that loads scripts into the vm.
You're right though, this is js, not node, so there aren't things like file / network access, so I imagine that some modules / parts of modules might not work.  are there specific modules that you'd like to see here?

This would be pretty nice! You talk about on the blog that underscore is automatically available in the transformers but that doesn't appear to be the case (at least in v0.0.3)

closing this out as mentioned in previous comments this is a JS VM and npm modules are not something we can do.


win: replace uv_file API

On Windows, a file descriptor is emulated in user-space as a wrapper around the real Win32 API. Indeed, the first operation libuv almost always must do is to throw away the wrapper (by calling uv__get_osfhandle). However, since the wrapper is implemented in user-space, this adds unnecessary overhead, makes the API less flexible, and is potentially error-prone (it assumes that the caller and libuv are linking against the same copy of msvcrt). A couple of functions already accept a uv_os_sock_t, essentially just to work around these limitations. While libuv could continuing adding dual APIs for everything (e.g. see uv_poll_init vs. uv_poll_init_socket), this doesn't seem particularly ideal to me.
What I would like to propose is to consistently remove this extra indirection from all APIs in libuv, and replace all usages of uv_os_sock_t with uv_file, while redefining uv_file on Windows to be a HANDLE.
It this is acceptable, I will start work on a PR.
Existing clients can initially transition to the new API by adding the following helper function code snippet:
HANDLE os_handle = _get_osfhandle(fd), handle;
if (!DuplicateHandle(GetCurrentProcess(),
                     os_handle,
                     GetCurrentProcess(),
                     &handle,
                     0,
                     TRUE,
                     DUPLICATE_SAME_ACCESS)) {
  return INVALID_HANDLE_VALUE;
}
_close(fd);
return handle;

Longer term, those clients would now be able to transition to using the Win32 API directly instead of requiring indirection through the MSVCRT API.

This would definitely be something for 2.0. While your reasoning sounds ok to me, I don't have enough Windows specific knowledge to make a good judgement call here, so I'll defer to our Windows overlords @piscisaureus and @orangemocha.

Bump. Please let me know whether you would merge this.

This is a fairly crucial issue for being able to deal with files on Windows. Can someone please reply to this?

I'll look at this more in deep by next week, sorry folks.

Sorry for the delay. I had a look at this and have some questions:

However, since the wrapper is implemented in user-space, this adds unnecessary overhead, makes the API less flexible, and is potentially error-prone (it assumes that the caller and libuv are linking against the same copy of msvcrt).

I understand the multiple CRT problem, but what is the flexibility we are lacking here? Is that overhead measurable?

What I would like to propose is to consistently remove this extra indirection from all APIs in libuv, and replace all usages of uv_os_sock_t with uv_file, while redefining uv_file on Windows to be a HANDLE.

IMHO uv_file is kinda a Unix-ism, since "everything is a file", I'd go for uv_os_fd_t or something similar. On Unix it would be an int and on Windows it would be a HANDLE. IIRC SOCKET can be cast to HANDLE, so we'd be covered for the uv_*_open APIs.

Existing clients can initially transition to the new API by adding the following helper function code snippet:

I think that helper function would need to be included in libuv.
Now, how would uv_tty_init work? It currently gets a fd in uv_file form, and everyone is used to passing 0, 1, 2, standard C stdio fds. Extending this, since all fs functions would now return a HANDLE on Windows, how would Node translate that into an object?
Another one: when using uv_spawn and passing the stdio container, the fd of the passed handles corresponds with the index, how do we do that now? Environment variables could be used, but we are back to the previous question: how do we 'serialize' a HANDLE?
One possible solution is to rely on the fact that even on 64 bit systems a HANDLE is actually a 32 bit integer (also see this) but I wouldn't want to base a design in some assumption that might not be future-proof.
From where I stand right now, this change would introduce tons of breakage for a not clear benefit. Can you please elaborate on the upsides of this change? Please don't take this as a discouraging note, my 'job' as a maintainer is to find all possible problems in advance, so I'd like to have a clearer picture before anyone gets to coding.
PS: If we move forward with this I'll request that you write a LEP with a detailed plan and reasoning, so doing that as a response to this note could be a good thing.

I understand the multiple CRT problem, but what is the flexibility we are lacking here? Is that overhead measurable?

For example, reference discussion at https://github.com/libuv/leps/pull/2#discussion_r21122363. In general, there are Windows API's that aren't available through the CRT. This results in the need for extra effort to, for example, write a simple implementation of pipe: https://github.com/libuv/libuv/blob/b12624c13693c4d29ca84b3556eadc9e9c0936a4/test/test-spawn.c#L1568

IIRC SOCKET can be cast to HANDLE

Yes, they're the same size. (although the WSA API is completely independent, so they mostly aren't interchangeable)

Now, how would uv_tty_init work? It currently gets a fd in uv_file form, and everyone is used to passing 0, 1, 2, standard C stdio fds. Extending this, since all fs functions would now return a HANDLE on Windows, how would Node translate that into an object?

The STDIO handles on windows are -10, -11, and -12. Unlike the standard CRT handles (0,1,2), it is not undefined behavior to access these from a graphical program (https://support.microsoft.com/en-us/kb/105305). The application can also use GetStdHandle https://msdn.microsoft.com/en-us/library/windows/desktop/ms683231(v=vs.85).aspx to retrieve the real handle instead of the pseudo handle if it wants a stable / non-redirectable handle.

Another one: when using uv_spawn and passing the stdio container, the fd of the passed handles corresponds with the index, how do we do that now? Environment variables could be used, but we are back to the previous question: how do we 'serialize' a HANDLE?

We do that now by extracting the HANDLE from the fd and passing the first 3 as the StdInput, StdOutput, and StdError Handles, respectively. (The Win32 API only supports passing 3 HANDLEs, and they are named, not indexed).

PS: If we move forward with this I'll request that you write a LEP with a detailed plan and reasoning, so doing that as a response to this note could be a good thing.

Sounds good. I'll start working on that too. I don't mind discussion, it's silence that's annoying.

The STDIO handles on windows are -10, -11, and -12. Unlike the standard CRT handles (0,1,2), it is not undefined behavior to access these from a graphical program (https://support.microsoft.com/en-us/kb/105305). The application can also use GetStdHandle https://msdn.microsoft.com/en-us/library/windows/desktop/ms683231(v=vs.85).aspx to retrieve the real handle instead of the pseudo handle if it wants a stable / non-redirectable handle.

That's good. We could have some defines a la UV_STDIN_FD et al, which map to STDIN_FILENO on unix and those you mentioned on Windows.

We do that now by extracting the HANDLE from the fd and passing the first 3 as the StdInput, StdOutput, and StdError Handles, respectively. (The Win32 API only supports passing 3 HANDLEs, and they are named, not indexed).

I meant in the child. Or maybe I'm confused and it's a Unix thing? AFAIS Node use NODE_CHANNEL_FD environment variable for the children get the fd and can communicate with the parent: https://github.com/nodejs/node/blob/master/lib/internal/child_process.js#L269-L273 the fd number seems to match the index in the stdio array.

Sounds good. I'll start working on that too. I don't mind discussion, it's silence that's annoying.

👍

I meant in the child. Or maybe I'm confused and it's a Unix thing? AFAIS Node use NODE_CHANNEL_FD environment variable for the children get the fd and can communicate with the parent: https://github.com/nodejs/node/blob/master/lib/internal/child_process.js#L269-L273 the fd number seems to match the index in the stdio array.

This is modeled after the Unix thing. It's possible to pass more than 3 handles to a child via a call to DuplicateHandle (https://msdn.microsoft.com/en-us/library/windows/desktop/ms724251(v=vs.85).aspx) after the child has started, but any fd number would be assigned by the mscvrt library in the child only if you called _open_osfhandle on the handle. There's no way to map a fd across to an arbitrary number. However, the fds 0, 1, and 2 are special, since they are automatically mapped to the pseudo-handles -10, -11, and -12 during crt initialization. Therefore, at launch, these are roughly interchangeable ids.

This is modeled after the Unix thing. It's possible to pass more than 3 handles to a child via a call to DuplicateHandle (https://msdn.microsoft.com/en-us/library/windows/desktop/ms724251(v=vs.85).aspx) after the child has started, but any fd number would be assigned by the mscvrt library in the child only if you called _open_osfhandle on the handle. There's no way to map a fd across to an arbitrary number. However, the fds 0, 1, and 2 are special, since they are automatically mapped to the pseudo-handles -10, -11, and -12 during crt initialization. Therefore, at launch, these are roughly interchangeable ids.

I see. My question is about how we would do it after the change. Now, AFAIS, because we use CRT fds they are allocated in order, and we know the 4th entry in the stdio array will have fd 3, so one can export a variable indicating this fact, but if we switch to using HANDLE, this won't be predictable, and it's not yet clear to me how we would signal the child that there is an IPC channel setup.

I discovered I misspoke: there is no *documented* way to pass a fd to the child, so I didn't realize libuv is using a little trick. For a child program compiled against the Microsoft C runtime, there's a magic buffer (Reserved2) which can be set to contain a list of the HANDLEs. These HANDLEs will be reopened as file descriptors by the child CRT in the order they are given in the list.

I have a different reason to want it to use more of a bare windows API instead of temporary storage in C runtime.  Node is linked with a static runtime, so no mixed runtime DLL issues; but that means that the call that is   _open_osfhandle just makes a windows HANDLE into an int for internal tracking and then handle = uv__get_osfhandle(fd); is done in most places to get back to the HANDLE.  This ends up doing a validation in the first place (open_osfhandle) becomes static code that REQUIRES the HANDLE be a real HANDLE instead of just trusting that it is.  So right now, for me, even Open File is crashing; because
there seems to not really be a C API use of the fd, except to get the handle back out of it.
And the above DuplicateHandle would be redundant.  It's not the handle duplication that's required... it's just converting from HANDLE to 'int' which might be smaller, and fits more with the posix way of things; but this tracking and assignment of integer to handle COULD be a  libUV lookup instead.  Then at least if I give back a handle from CreateFileW that is X it might not try to assume it's really really REALLY a HANDLE.

Implemented in #1166.


Custom Scenario not working and Actor not spawning in desired place

Hello all,
I have tried running all the scenarios in the example folder and have successfully done it.
However, when I try to create a custom scenario with a different name similar name to FollowLeadingVehiclewithObstacle which has a custom initialization(no other actor in XML file) it throws an error saying other actors are empty in the Actortransformsetter function.
Also when I include the other actor in the XML file and try to change its position with the ActorTransformSetter in the Python code, the actor spawns at the same location as in the XML file.
On observing closely I came to the conclusion that the def_ initialize_actors(self) is not being called.
@fabianoboril  Please advise.
Desktop (please complete the following information):

OS: [e.g. Windows 11]
CARLA Version [ CARLA 0.9.13]
Python version [e.g. 3.8.8]

@Kraftivoll  Did you find a solution regarding the spawning of the actor?


qt: Fix font size and scaling issues

This PR should fix all remaining places where the font scale wasn't applied yet (besides the splashscreen which probably also should follow anytime later). It also in general improves the font-scaling process and from now on it only updates fonts where really required. See commit messages.
@thephez This should fix all the issues you pointed out in slack
@PastaPastaPasta 64ce1b5 might fix the one you sent me. At least it makes it better here on mac where i had it similar like you with a low font scale though.
@strophy 82c1612 could be a fix for your "I can't get the same menu size like in other applications" thing

Stuff still getting cropped in Network traffic for me

@PastaPastaPasta Please look at the network traffic stats again with 3c52ea3
@PastaPastaPasta @UdjinM6 I rebased this PR now on #3717 to include 0156d4d in here as it seems to make more sense in here. Should fix the min width issue. Thoughts?

Okaay one more.. see the last three commits i changed it to resize depending on the font size. Now if any of the appearance attributes gets changed or if the PS UI gets shown/hidden the OptionsDialog gets resized to the required size.

Seems to be working as expected for me (could use QTimer::singleShot(0, this, SLOT(updateWidth())); instead of calling it directly in ctor to fix issues with buttons visibility not being available at that point but 3170db0 is fine too :) )

Seems to be working as expected for me (could use QTimer::singleShot(0, this, SLOT(updateWidth())); instead of calling it directly in ctor to fix issues with buttons visibility not being available at that point but 3170db0 is ~fine~ ok-ish too :) ).

Does the single shot timer 100% guaranteed only fire after the widgets visibility state flipped? I have no idea just curious.

EDIT: Technically speaking though, you could one day want a visible but disabled tab there and 3170db0 won't work.

Dropped 3170db0c67247d29f6ba6f9be1d560dfe1f49596 and added fe3ae7e that should do it better

Working as expected for me now (but I had no issues with Network traffic before, so can't say if it was also improved or not).

Working as expected for me now (but I had no issues with Network traffic before, so can't say if it was also improved or not).

Yeah i also had no issues with it since it was not looking bad on macOS but now it should just scale as expected based on the really required size not on the "on macOS required" size :D
Added three more commits:
d94655e + 62a6cbc To give the main window the same resizing behaviour depending on the enabled tabs like in the options window. For me on my system the 980 min width is reasonable but not sure if other systems require more there? @PastaPastaPasta how is min size looking there if PS + Masternode are hidden?
35dc39b To allow manual resizing after the window has been resized dynamically after restart/reopen or appearance adjustments.

Below are the only few remaining problems I could find on really edge case font settings. Don't think it's critical to get these fixed

###########################################

###########################################

###########################################

Two more fixes:
c5390d5ea910b61eb5190f55f900a5b59152e454 To make sure all widgets receive the font weight updates if "font-weight-normal" gets updated.
95a169842b4e91a8704e8946c6e43de84a14e47c To make sure a widget which for example had a bold font initially gets updated to normal font if requested. Like all tab-like buttons we have, the currently clicked one is bold, the others normal. Without this commit they don't update properly if the font-weight gets adjusted in appearance tab.
Those behaviours were broken by the changes of this PR, e.g. 2bfe078b2ff303486ebc47f412ad802243415f94 and 41524ea52e154667ed34364860868702e218d226

Needs rebase

Needs rebase

Done

See below + (maybe) d734bf1 + found 2 issues:

In general im with you, having a smaller min size is preferable but i would rather revisit this sometimes later i tested it a bit and it breaks things with other font sizes and seems to mess a bit with traditional too.
The other commits i just added should fix the remaining scaling issues + they remove (as discussed in slack) the fixed pitch font. About the scaling: The previous default font implementation was not optimal because widgets without a object name set received an empty key from getKey(). The initial idea there was to only add the default font size for an instance of a class /UI element only once not for each instance. Now with d82c5d7 they are stored for the actual instance and removed again if the instance is not longer available in the UI.

Nah, I think https://github.com/dashpay/dash/commit/cb23aae4204705f44fbe26ee983e0bb688f75303 is related enough. It's fine

No, the problem with different size font in the menu and title bar remains. It is impossible to get them to match, and I think the reason is they are using different layout engines. The kerning looks really bad, letters have too much or not enough spacing on each side, icons in the menu are missing padding and it generally just doesn't feel "native" for Windows. I can count 6 different font sizes and weights in this screenshot alone, not counting the Dash logo...

Also having some scaling issues on ubuntu with a 1920x1080 display
Zooming in until my toolbar matches yours will give you a good approximation of what it looks like on my display
Cheers


Add the is_uma flag to payments.

Current dependencies on/for this PR:

main

PR #22   👈

This stack of pull requests is managed by Graphite.

Merge activity

Jan 11, 12:18 PM: @jklein24 merged this pull request with Graphite.


Updated for 7.1

Updated DalamudPackager package reference to 11.0.0.
Updated packages.lock.json to reflect the new DalamudPackager version.
(Sorry, my VS is bugged and I couldn't undo the autoformatting!!)

Hey, thanks for the PR.
Can you try again to fix the autoformatting?
Did you check if everything still works as expected with the new Client Structs?
Do you know when the old packager will be deprecated?

Plugin appears to be functioning correctly without further changes needed

Thank you @ChrisMellor for the changes and @Limiana for confirming this is enough to make it work.
I'll build/release as soon as I can


Target jvm 1.8

What was the motivation for targeting 1.8? I can't target 1.8 yet because AGP 3.4.0 can't desugar everything in the bytecode created by Kotlin. Now I'm getting this error

the kotlin intellij plugin which we depend on uses 1.8 bytecode in 1.3.30, so we were having the same error in our project

i think we could only declare 1.8 for the intellij plugin and that might work

Should I open an issue to track this?

yes please - thanks


Incompatible with React Native 0.71

First of all I would like to thank you guys for creating this library - it's highlighted so many accessibility issues in our apps!
I'm in the process of updating to React Native 0.71.2 and the build fails with the following:
FAILURE: Build failed with an exception.

* What went wrong:
The Android Gradle plugin supports only kotlin-android-extensions Gradle plugin version 1.6.20 and higher.
The following dependencies do not satisfy the required version:
project ':react-native-ama' -> org.jetbrains.kotlin:kotlin-gradle-plugin:1.5.20

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 12s

Ahhh, bumping my kotlin version inside android/build.gradle to 1.6.20 fixed the issue.


Feature/form field tooltips

Description
A new feature to add description of fields to show as tooltips. Implemented by transferring the description of the field to the icon title tooltip by the field. This is done by following the existing parsing of the forms fields from ENA schema.
Related issues
Fixes #172
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update (this needs a follow up PR)

Changes Made
Added Material UI tooltip and Material-UI help icon at /WizardJSONSchemaParser .
Added check for tootipWizardFillObjectDetailsForm.test.js
Testing

[x] Unit Tests
[ ] Integration Tests
[ ] Tests do not apply
[ ] Needs testing (start an issue or do a follow up PR about it)

Mentions

some cypress e2e tests would be nice, not required but nice.

* i have low luminosity on my screen and the grey of the question mark is very faded, maybe we can give it a darker grey e.g. `rgba(0, 0, 0, 0.40)` or something similar

I wanted the question mark be less disturbing, when a user knows what to do, by choosing the same colour than in the framing of the fields, it depends what is wanted?

I wanted the question mark be less disturbing, when a user knows what to do, by choosing the same colour than in the framing of the fields, it depends what is wanted?

i think we need to guide here by the accessibility principles  https://webaim.org/articles/contrast/  i see it recommends: Gray (#767676) on white
we can use: https://wave.webaim.org/extension/ to test this and get suggestions - which apparently only notices that we have that hidden

oh ... we need to use a different tool: https://webaim.org/resources/contrastchecker/

is it possible to align vertically the question mark with the form field so that they look on the same line ? right now they look a bit out of place at least in my version of firefox
Easy one done in latest commit replace help icon inline with textfield . More difficult are the ones inside some box, did not found those nor the solution yet.

is it possible to align vertically the question mark with the form field so that they look on the same line ? right now they look a bit out of place at least in my version of firefox

Easy one done in latest commit replace help icon inline with textfield . More difficult are the ones inside some box, did not found those nor the solution yet.

In helpIconStyle > divBaseline, I think we can leave out flexWrap: wrap so the ones inside the box can be on the same line.

Thanks, @hannyle , leaving out flexWrap: wrap made them inline inside box :) . Rest of styling can be fixed later when adding  CSC style, #363 .


chore: og:image

og:image is url, not path.
https://ogp.me/

Thanks!

Its live, although i dont see it on the card preview

I can not see logo at Twitter card.
SVG may not be  supported at Twitter card.
https://cards-dev.twitter.com/validator

@EugeneHlushko
I sent pull request which uses png file.
#3560


Make leaderboard mobile compatible

For example, Gets cutoff on the side

I actually think alot of mobile issues can be solved with #305 . For example, instead of displaying the full paths on mobile, we can add a tooltip icon for each run. Any additional info related to the run would be displayed there instead


Update connected console information on disconnect of any sort

When you stop the engine, the connected console name stays and it can kind of confuse what's actually happening
This would make getting back up and running quicker
i think it would wrap up the experience a bit more

Are you talking about the connected to dialog in the top right corner? Or are you talking about the Connected Consoles window within XLink Kai?
If you are talking about the one that shows in XLink Kai, that should actually stop showing your PSP/Vita if it was not detected before xlinkhandheldassistant was started.
Could you elaborate on the issue a bit more? Then i can check where it should be fixed.

Oh, sorry. In the top right corner of the xlha window!
simply stop the engine and the Connected to: information doesn't refresh

Aha yes, technically it's still connected when that happens, but I do think it's easier for people if it disappears, I'll work on that

I see! well good to know. This tool is fascinating


Namespace aggregation

rollup prometheus config fixes for various bugs related to namespace relabeling
fixes lightbend/es-backend#268
fixes lightbend/es-backend#267
fixes lightbend/es-backend#253

I'm curious why we have all of the various SD configs for services/endpoints/etc. When, as far as I know, we don't test, document, or support that config. Doesn't it make sense to delete everything but pod discovery until we plan to support the other configs?

Few more questions. The only change I'd like to see is making the kube-state-metrics relabeling more explicit, so it's obvious its for kube-state-metrics pods only rather than any generic service. We could merge it as-is and do that separately though.