Remove unused parameter [phab:D1766]

Created by schroederc at 2017-07-07 19:24:54:

shahms accepted this revision at 2017-07-07 19:34:58

schroederc closed via commit 702ac63444fdbac13b08dba2bfe3670cef2a86bd at 2017-07-07 19:54:59


FS: Move command doesn't work

https://forums.ghielectronics.com/t/directory-move-sourcedirectory-destinationdirectory/21840/3

Works fine, users have to point out new destination folder, same behavior on window OS.


can i fetch data of particular rowKey from hbase

@weiqingy
can i fetch data of particular rowKey from hbase using SHC without fetching all data of hbase
we can also able to add min and max timestamp but didn't find anything for rowkey.
here some code

SparkConf sparkConf = new SparkConf();
sparkConf.setAppName("local");
sparkConf.setMaster("local");
SparkSession sparkSession = new SparkSession(new SparkContext(sparkConf));
SQLContext sqlcontxt = new SQLContext(sparkSession);
String query = "select * from NVReport";
Map<String, String> colMap = new HashMap<String, String>();
String cat = ConfigUtil.getConfigurationValue("emp2");
colMap.put(HBaseTableCatalog.tableCatalog(), cat);
Dataset dataset = sqlcontxt.read().options(colMap).format("org.apache.spark.sql.execution.datasources.hbase").load();

i also find something like HBaseTableCatalog.rowKey() but its not working
colMap.put(HBaseTableCatalog.rowKey(), "key");

Hi @AtulKumVerma,
Yes, you can not make colMap.put(HBaseTableCatalog.rowKey(), "key"). However, as SHC pushes filters down into Hbase, you may want to do select on your dataframe to tell Hbase only return rowKey back to Spark.
val df = dataframe.select("col00") // assume "col00" is mapping to rowKey in your catalog
df.show() // you will see Hbase only return row key

Appreciate with this but i have another issue.
see lets i have some data in hbase like
| rowKey | col1 | col2 |
|   19      |  x     | A      |
|   23      |  y     | B      |
|   25      |  z     | C      |
so i want to get that data whose rowkey is 23.
| rowKey | col1 | col2 |
|   23      |  y     | B      |
Actually i dont know its internall architecture how dataframe actually works if i use like .
val df = select(col("rowkey")).filter(col("rowkey")).equals("23");
so this will fetch all rowkey i.e. 19,23,25 from hbase and than apply filter on rowkey column to find whose value is 23.
OR
this will fetch that rowkey from hbase whose value is 23.
Thanks in advance.

@AtulKumVerma  The later one - "fetch that rowkey only from hbase whose value is 23". (of course, you may want to invoke some Spark action operations like show(), count(), etc)

Thanks @weiqingy .


Add Poetry

Instead of using pip, poetry would be a better choice for dependency handling for complex projects.

Closed #7


Getting an error when running validator - can't download schema

---- proj: Error downloading https://schemas.stacspec.org/v1.0.0-beta.2/extensions/proj/json-schema/schema.json
HTTP ERROR 404

Thanks for reporting. The correct link is https://schemas.stacspec.org/v1.0.0-beta.2/extensions/projection/json-schema/schema.json and it's likely that your STAC Item is not correct and contains proj in stac_extensions instead of projection. I can certainly provide a better error message in the validator, but the actual issue is likely in the STAC Item itself.

Alright, thanks for the explanation! @m-mohr

Fixed in v0.4.3.


Appstudio update mvp-test-component

Pipelines as Code configuration proposal

Pipelines as Code CI/mvp-test-component-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
15 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
9 seconds
sanity-inspect-image

✅ Succeeded
9 seconds
deprecated-base-image-check

✅ Succeeded
17 seconds
clair-scan

✅ Succeeded
53 seconds
clamav-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
8 seconds
sanity-label-check

✅ Succeeded
8 seconds
sanity-optional-label-check

✅ Succeeded
6 seconds
show-summary


[Core] Add trait static property accessors/mutators

What
Add static variants of trait property accessors and mutators, e.g. getMyPropertyFrom(traitsData) / setMyPropertyTo(traitsData)
Why
Currently trait view classes require construction around a TraitsDataPtr before property accessors/mutators can be used.  This involves a copy-construction of the TraitsDataPtr.  If the user only cares to query a particular property, then that copy-construction is a waste of resources.
Note that we already have static variants of imbue/isImbued, i.e. imbueTo/isImbuedTo, so doing similar for properties adds some functional parity.

Dupe of https://github.com/OpenAssetIO/OpenAssetIO-TraitGen/issues/35


[faucet] Remove waitForIndexer for faucet fundAccount

Description
Unneeded waitForIndexer call for faucet.
Test Plan
pnpm lint && pnpm unit-test
Got the same number of errors locally (before and after any changes) running pnpm api-test 🤷

pnpm test includes both pnpm unit-test and pnpm api-test, tho for this change pnpm api-test is enough as this piece of code is only tested in api-tests.
Local tests should not fail locally. If it does it might be because localnet (probably a indexer processor) breaks and need to restart it.
I am not fully convinced waitForIndexer is not needed. If indexer doesnt catch up it might be something wrong with indexer. Also, you should be able to disable this default behavior with  options: { waitForIndexer: false }

Ok fair. ill close


Replaced field "categories" with "category" when querying a single category by slug

Queries QUERY_CATEGORY_BY_SLUG and QUERY_CATEGORY_SEO_BY_SLUG are querying a list of categories, and then picking the first item.
But WPGraphQL can already query a single category by its slug: { category(id: $slug, idType: SLUG) { id } }
So this PR replaces it

ah great catch, thank you!
@all-contributors please add @leoloso for code


react-flow cannot be installed in a fresh create-react-app app

Describe the Bug
npm install react-flow-renderer --save
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/react
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"16 || 17" from<EMAIL_ADDRESS>npm ERR! node_modules/react-flow-renderer
npm ERR!   react-flow-renderer@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
npx create-react-app my-app
npm install react-flow-renderer
Expected behavior
I expect react-flow to be installable
Screenshots or Videos
No response
Platform

OS: Windows

Additional context
No response

We have not yet updated to React v18. Until we do, you would need to install React Flow with --legacy-peer-deps.

@chrtze When is it expected to be happening? Popular boilerplates are defaulting to react 18 version, nextjs 12 even demand it with dependency range.

@FateRiddle please see #2067

The linked MR has been merged just a few hours ago

Fixed with v10.2.0


No issue - Kudos

So I've been using this for about a month now.  After a few very minor complaints on my part, @erikrichardlarson you knocked it out of the park with this.  No where else has anyone been able to get track ID from rekordbox.  It is working great.  Many DJ's are asking me how I did it and I just send them here.  Thank you so much.

Great to hear! Thank you, really appreciate the support!
If you're on Windows 64 you can expect an update soon that gives you updates in real-time that follow rekordbox's master deck.


Give your feedback on Browserpass v3

Browserpass v3 was written from scratch, and is quite different than the current version. Please give it a try, and let me know your thoughts!
The release date is set for Saturday, April 13
Post feedback directly in this thread, I will triage and create follow-up issues when necessary.
It is not backwards compatible, so you'd have to install a new version of the host app as well.
Native app: How to install
Browser extension: How to install (install manually, don't use policies-* make targets as v3 is not in Webstore yet!)
I recommend you reading the entire README of the browserpass-extension project, it contains description of some new behavioral changes.
If you really hate the new Browserpass, don't worry, the current version will not be removed from the Github, so you will always be able to keep using it.

If you use Arch Linux, to get Browserpass v3 you can add my repo or just fetch the compiled package from here.

Great news, thanks!  Looking forward to giving it a try.

Huge fan. Do you have a write-up of the changes yet?

I think the best documentation I have is both README files in browserpass-native and browserpass-extension repos, it doesn't list changes per-se, but it explains everything that's now possible. My favorite change is of course how popup looks and behaves now, much fewer keystrokes needed for daily operation. In addition, a lot has changed internally in the communication protocol between extension and the host app, it's richer and more extensible (if you want to dig into it, see PROTOCOL.md).

@maximbaz Thank you very much for your hard work. Some initial feedback after reading the documentation and before installation.
I really like the anti-phishing protection. It seems to be really well designed, both its UI and UX. Good job.
I've been waiting for v3 for quite some time now as I thought it would help me with all these multi-steps authentications forms (e.g., with otp, or with username in a form and password in another). I'm sad that it seems v3 won't help after all (at least for otp). It's perfectly fine not to implement a feature if you don't want to but I'm not sure about the reason you give. If it's only for security reasons, then I think you should let the user decide what is best for them (it can be through an option protected by a big red warning text). Because I'm more frightened to stay connected on websites and to leave cookies around, I clear cookies as soon as I close a browser tab: using my phone for OTP would be too cumbersome.
I'm very surprised that installing the native application requires sudo (at least that's what the README says). I would prefer to install locally under my own user. I already give browserpass access to all my passwords, I don't want to give it access to all my system :-).

Hi, my install of brave (on funtoo) does not react to the host being installed with hosts-brave and policies-brave. It does, however, work with host-chromium and policies-chromium.
I like the new UI. However, did you remove support for OTP? Because I could not figure out how to generate tokens, which worked in the 2.x release.

Thanks for the feedback!

I've been waiting for v3 for quite some time now as I thought it would help me with all these multi-steps authentications forms (e.g., with otp, or with username in a form and password in another). I'm sad that it seems v3 won't help after all (at least for otp). It's perfectly fine not to implement a feature if you don't want to but I'm not sure about the reason you give. If it's only for security reasons, then I think you should let the user decide what is best for them (it can be through an option protected by a big red warning text).

Multi-step authentication is still planned #286 (up until now I was trying to at least reach feature parity with v2, so that I can finally focus solely on v3), but yes OTP was intentionally not re-implemented in v3. I simply don't want to have a feature that I don't want people to use, spending time implementing something and then covering it up under settings with big red warnings is a waste of energy. In v2 I was both unhappy with having the feature in the first place, and the way it was implemented (e.g. static digits that were not updating). The reason I put in README is attempting to explain why I won't accept a PR; I think Browserpass should not promote pass-otp.

I'm very surprised that installing the native application requires sudo (at least that's what the README says). I would prefer to install locally under my own user. I already give browserpass access to all my passwords, I don't want to give it access to all my system :-).

You need sudo because the default location is set to /usr/bin and /usr/lib, which can only be written by root. Thanks to open source, you can see exactly which commands will be executed on sudo make install 😉 But it's also possible to install Browserpass in a custom location, I haven't thoroughly tested that, but something like this should work: make DESTDIR=$HOME/bin install, it won't require sudo and it will install Browserpass binary in $HOME/bin/usr/bin/browserpass. I believe by running sudo make install you are not giving Browserpass access to your entire system, only the commands listed in the install goal will be executed as root, nothing else 🙂

My install of brave (on funtoo) does not react to the host being installed with hosts-brave and policies-brave. It does, however, work with host-chromium and policies-chromium.

That's quite weird, could you please investigate some more? I took the target paths from your PR https://github.com/browserpass/browserpass/pull/295, but maybe the paths for Brave browser are not correct? Could you please remove the symlinks created by hosts-* commands that you executed and try to prove again which paths does Brave browser actually support? For example, if you executed hosts-chromium target, remove the symlink /etc/chromium/native-messaging-hosts/com.github.browserpass.native.json.

Oh, just realized I didn't write it anywhere, don't use policies-* targets yet, because I haven't pushed v3 to Webstore yet! Follow the "manual installation" for browser extension.

but yes OTP was intentionally not re-implemented in v3.

In that case, I'm probably going to stick to v2. I understand where you're coming from with the reason to not include it, but I'm not trying to protect myself from someone getting into my passwordstore. I'm trying to protect myself against someone who pwned some service's password database, and in that case, it doesn't really matter where my OTP is coming from. If I'm at the point where someone has gained control over my computer to the point where they can access pass, I'm fucked either way.

I understand your point too 👍
There's also an option to implemented a dedicated pass-otp browser extension, if someone feels passionate about it 😉

Maxim Baz<EMAIL_ADDRESS>writes:

There's also an option to implemented a dedicated pass-otp browser
extension, if someone feels passionate about it 😉

in this case, would you accept a PR adding OTP support to your native
application? This would be less work for the volunteer who would only
have to maintain a browser extension and the end users.
--
Damien Cassou
http://damiencassou.seasidehosting.st
"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

It worked before, but I now get "Error: Attempt to postMessage on disconnected port" in the popup.

in this case, would you accept a PR adding OTP support to your native application? This would be less work for the volunteer who would only have to maintain a browser extension and the end users.

Native application will require no changes, it is intentionally implemented in such a way that it contains almost no logic, everything is done on javascript side. I will gladly assist the volunteer on how to integrate the existing native app with their extension 👍
In particular, there is a fetch request that will return the entire contents of the password entry. Then on the javascript side you would need to find the line that starts with "otp", extract the otp URL, and use some js library to generate actual codes (first Google result for me was this library: https://github.com/jiangts/JS-OTP).
If someone starts the work and has questions, please create a new Github issue for focused discussion.

It worked before, but I now get "Error: Attempt to postMessage on disconnected port" in the popup.

Sounds like the host json file is either misconfigured or contains incorrect path to the binary, how did you install it and what changed since it worked?

Sounds like the host json file is either misconfigured or contains incorrect path to the binary, how did you install it and what changed since it worked?

I found the reason. Because browserpass v3 is not on AMO yet, I installed it as a temporary add-on. This got reverted to v2 when I restarted the browser. I fixed that by re-installing (now 3.0.1). But this is soon getting to be annoying because I regularly restart Firefox. Do you know when AMO will get the new version?

I'll release as soon as I get at least few people to try and confirm in this thread that everything works. Also hoping I get all OS package maintainers to respond in https://github.com/browserpass/browserpass-native/issues/31.
Since this is a big breaking release, I want to build at least some amount of confidence that users will be able to upgrade seamlessly, especially because as soon as I publish extension on webstores, users will receive auto-update and will need to go and install new native host right away. So ideally I would synchronize the update with OS package maintainers, and do it on Thursday or Friday, so folks have weekends to sort this out and I'm around to help debugging urgent issues.

The release date is set for Saturday, April 13

Hey guys, please see a follow-up to the discussion about OTP in a new thread: Support OTP in Browserpass v3 (#333)

Update: the latest RC are browserpass-extension v3.0.3 and browserpass-native v3.0.2.

I am very grateful for your hard work, and use browserpass daily. It is a real security solution for me. Thanks a LOT.

I normally use firefox. I just opened chromium and received a notification about this update. It's not good I did not get this notification on firefox. I must have missed something. But this is very important as I use browserpass daily and it's a shame I only know about this update because of some small notification. Can this news be made more visible, for example by updating the current browserpass extension?

The update procedure is not nice. I have to sit down on a specific date, Saturday 14th, a day that I'm travelling, and wait for the browser extension to update, then update the native application, and hope that I manage to do that, which is not guaranteed. "Yes but you can do something in the developer options" is not a solution for the vast majority of users, and I'm not sure it actually solves the problem, because you still need to do something very specific on a specific date. This update needs to be opt-in for now.

After having problems with version mismatches, I finally managed to get browserpass working on my partner's Ubuntu machine. The problems stemmed from the fact that browserpass was installed manually a long time ago, and the extension got updated, but the native host did not (of course), as the package manager did not see any package to update. Now, barely a week later, it looks like I'm back to square 1. This time it's worse because there is no package to install on Ubuntu. For me, this feels like a downgrade rather than an upgrade: I'll be forced to install the native application manually, which will guarantee that I'll have version mismatch problems somewhere down the line. I'd love to stop the upgrade until there is an Ubuntu package, but I'm not sure the proposed workaround of "temporarily" installing an extension is a solution. Going into developer options every time you start a browser should not be a requirement.

Please don't let the above three points take anything away from point 0, namely that this is a fantastic piece of work that solves real-life problems, for which me and undoubtedly many other people are very grateful.

Thanks for the kind words @abooij!
It's sad that Firefox didn't show you a notification, it definitely should have. I think it's a bit too late to implement some persistent update message for the old extension, but definitely something we must consider for the future.
Believe me, I am well aware of the ugly upgrade procedure 😞 Backwards compatibility was considered, but I gave up on this given the amount of available time to implement and especially test all possible combinations. With the upgrade notification I was hoping to just let people know that yes, an ugly breaking update is coming, don't be scared about the Saturday release, if you know you won't be able to update, download the unpacked extension, try out now to load it via developer tools, at least you will have a working extension until you find time to update. It's totally possible to have both old and new native hosts installed side by side, if that's what you want to do. I know it's not perfect, but I hope it's temporary (not more than a few days) and to be honest it's the best I could offer to finally get v3 out of the door 🙂
Luckily it's going to get better starting from v3, I have found ways for users to freeze the versions. For Chromium, I'm now offering extensions with two different IDs, browserpass-webstore.crx (same ID as on Webstore, will auto-update) and browserpass-github.crx (never auto-updates, users must watch Github release notifications), so in the future I will be able to say "if you can't upgrade, for now switch to browserpass-github.crx". Sadly I can't do it for v2, as this requires updating native host app. For Firefox it's even simpler, you can unpack the contents of firefox.zip in<EMAIL_ADDRESS>folder, and Firefox will use this extension regardless of what's currently on Webstore (actually, let me document this in the top of README in this repo).
What I described above is also packaging-friendly, for example on Arch Linux I'm packaging browserpass (native host app), browserpass-chromium (which installs browserpass-github.crx) and browserpass-firefox (which installs unpacked Firefox extension in /usr/share/mozilla). This way, starting from v3 I as a package maintainer am finally able to control when exactly users receive updates for native host app and browser extensions, I am finally able to release them together.
I do hope other distros pick up the same pattern, but it isn't the case yet. I was able to reach Browserpass package maintainer on NixOS and they prepared a v3 release for native host app (not browser extensions though), maintainer on Debian responded in a thread but haven't prepared any package updates yet (to my knowledge), and I was not able to reach Ubuntu or macOS package maintainers.

For me, this feels like a downgrade rather than an upgrade: I'll be forced to install the native application manually, which will guarantee that I'll have version mismatch problems somewhere down the line

I'm planning to have very few updates for v3 native host app after the Saturday release, it was a pain forcing people to often update it, so one of the big v3 design goals was to shift as much functionality as possible to the browser extension side, which is easier to update.
But in case there is a new version of a native host app, Browserpass v3 will notify you:

So, as much as I would love Ubuntu folks to update browserpass package, it's okay if you install it manually.

Thanks for your extensive reply, @maximbaz. It is clear that you have exhaustively searched for solutions!

@maximbaz, Will the new extension detect when an old native host is installed, and give (a link to) appropriate update instructions? (As opposed to the old "Error: Native host has exited".)

not really, partially because it's a completely different native host, with different ID, the new extension doesn't know anything about the old native host because it must be configured with new json files; but also because theoretically v2 and v3 can run side by side so it doesn't make sense if v3 starts to complain about the presence of v2 app.
What will happen though is once browser extension gets installed or upgraded to v3, it will show notification with a link to Github with instructions on how to configure the new host app.

Hi @maximbaz
The installation process on Mac seems quite a bit more burdensome in v.3 with additional packages having to be installed etc. After running into issues I tried https://github.com/gopasspw/gopassbridge (which also supports OTP) and the installation process is much smoother.
My main point though, now that the backend has been separated from the browser plug-in, wouldn't it make sense to just adapt it to gopass with its json api and native messaging? This would make the installation process easier across all platforms and allow more development effort for improving the browser plug-in as well as potential for synergies with gopass bridge. I have no issues with running both pass and gopass on my system.

Thanks for the feedback 🙂 If by "additional packages" you refer to the fact that you had to install browser extension manually - this is because we are in pre-release mode, but starting from tomorrow the new extensions will hit Web Stores 🎉 But if you refer to the "native host app", just like in v2 we have to have this extra app in order to give browser extension access to files on your local system - however both v2 and v3 have a user-contributed homebrew tap for Browserpass for macOS, so installation should hopefully be smooth.
I had similar idea about gopass json api, in fact I did propose at some point to align with gopass api, but this idea didn't get any interest. However, remember that we also want Browserpass to work for people who only use pass, not gopass - in fact, right now Browserpass does not depend on either of them, it only requires gpg installed. And finally I need to be able to have some decision-making/control powers over the way native app is implemented, that's definitely simpler when having our own native host app. In fact, even if gopass folks suddenly became interested in aligning our APIs, I'd probably choose to stay with our own app - besides the benefits explained above, I have some features implemented which are not present in gopass api, and one other very nice benefit is that our app is very small (because it's doing only one job), and less code means less bugs, less often releases and easier to audit.
The switch from v2 to v3 is painful, but we learned a lot and I do believe future updates will be much smoother.

@maximbaz, The extension just got updated for me. It gives an error message: "Error: Error: Attempt to postMessage on disconnected port". No update instructions.

Was there no update notification? 😞
Please follow the instructions in this repo, you need to install and configure a new native host app: https://github.com/browserpass/browserpass-native

@maximbaz There was a notification that the extension got updated, but this disappeared after a few seconds and could easily be missed. It would be better if the extension gives a useful error message :)

I'm pushing it right now 😉 If you are on Arch, I would highly recommend you uninstall extension from Web Store, and instead install browserpass-chromium or browserpass-firefox from [community] (am preparing these packages now as well), this will make sure that you will never experience breaking releases anymore, as browser extension and native host will update at the same time.

The packages you pushed seem to work, thanks!

Package updated to broken state without warning.
New package has completely removed OTP functionality.
No simple manner to revert to the functioning OTP-aware version of package.

Make sure to read FAQ for what happened to OTP and how to revert to a legacy version.

Make sure to read FAQ for what happened to OTP and how to revert to a legacy version.

Doesn't work on MacOS.  You have deliberately broken the extension which was installed in good faith. A breaking change like this should not have been forced on people, rather a new extension should have been made available and a 'nag-screen' added to the existing functional extension.
Your FAQ on OTP is, frankly, insulting. otp-pass exists for good reason, bringing otp functionality inside the gpg-encrypted password store.
Your extension, amazingly, doesn't even rely on passwordstore any more.

@dg01d

The old extension has been displaying a warning popup on startup for the last week, explaining that this upgrade was coming.
You don't need to add it as a temporary extension every time you start your browser. If you wish to continue using v2, it can be installed permanently, once. This is explained in Q3 in the FAQ.
There will be a separate OTP plugin for v3. We agreed that this was an acceptable compromise; it mitigates the problems inherent with continuing to support OTP within the main extension, while still providing full support and integration with the fill workflow. If you would like to contribute to this effort, your input would be welcome - the issue currently tracking the OTP stuff is here.
The v2 plugin doesn't rely on pass / passwordstore either. It has a native host component which calls gpg directly, just as v3 also directly uses gpg.
Yes, v3 is a breaking change. There have been breaking changes in the past too. A breaking change is not a reason to roll an entirely new extension ID in the webstore every time it occurs - it would result in an awful lot of clutter, lose user settings (because they'd be stored under the old extension), and also break auto-update of the extension, which the vast majority of browser users expect to happen without requiring them to go to the webstore and install a completely different extension.

You have deliberately broken the extension which was installed in good faith.

We have deliberately provided a significant upgrade in good faith. If you don't like it, you are welcome to continue using the legacy version - nobody is stopping you, and we have even provided documentation explaining how to do so.
If you have additional constructive questions, please feel free to post them here, and we will address them. This is not a forum for general ranting and ad-hominem however.

@dg01d

Doesn't work on MacOS.

If this isn't working for you on OSX, could you please open a new issue on this repo explaining the problem, and we'll look into it. Permanent install on OSX should definitely be possible.

1. The old extension has been displaying a warning popup on startup for the last week, explaining that this upgrade was coming.

Yes, a popup occurred. On macs, the popup stated that v3 was a major upgrade, and provided a non-clickable link to github. It did not specify that this was a breaking change.
The first I knew that a new additional program element was being introduced was this mornings "New major update is out", which appeared after the extension had updated. The first time I was informed that OTP functionality had been removed was when I came to github to find out how to make the extension functional.

3. There will be a separate OTP plugin for v3. We agreed that this was an acceptable compromise; it mitigates the problems inherent with continuing to support OTP within the main extension, while still providing full support and integration with the fill workflow. If you would like to contribute to this effort, your input would be welcome - the issue currently tracking the OTP stuff is [here](https://github.com/browserpass/browserpass-extension/issues/76).

If this is the case, why is this not specified in the release notes for this release? Instead there's a lot of, frankly, hectoring notes regarding why using OTP is bad and noone should do it. There's no indication, at all, that OTP support is something which is actively being pursued, just very insulting language about why it isn't.

5. Yes, v3 is a breaking change. There have been breaking changes in the past too. A breaking change is _not_ a reason to roll an entirely new extension ID in the webstore every time it occurs - it would result in an awful lot of clutter, lose user settings (because they'd be stored under the old extension), and also break auto-update of the extension, which the vast majority of browser users expect to happen without requiring them to go to the webstore and install a completely different extension.

The popup should have specified, in the lede that autoupdating should be disabled until the user had the opportunity to evaluate the new, and non-functional, extension. Not everyone has the time or the headspace to follow the development cycle of every app, extension and program which they are using. Presuming that people do is not a good look.
Moreover, the extension updated itself to a broken state. You can say that you had a popup, but that popup was not informative, and did not provide (at least on macs) anyway of following, or even seeing the full content of, the link. I've attached screenie of the popup for information.
The only information I had was the error message Error: Error. Attempt to postMessage on disconnected port. That was it. Nothing else.

We have deliberately provided a significant upgrade in good faith. If you don't like it, you are welcome to continue using the legacy version - nobody is stopping you, and we have even provided documentation explaining how to do so.

Having had this discussion, and having had things outlined in such a frank and engaged manner, I am perfectly happy to try the new extension.  This whole thing should have been handled in this manner from the off.

If you have additional constructive questions, please feel free to post them here, and we will address them. This is not a forum for general ranting and ad-hominem however.

Yes, a popup occurred. On macs, the popup stated that v3 was a major upgrade, and provided a non-clickable link to github. It did not specify that this was a breaking change.

Normally major version numbers are only changed on a breaking release. That's the whole point of semantic versioning. However, I freely admit that we're seeing that from a development perspective, and perhaps that wasn't sufficiently obvious to everyone else. Feedback taken on board - we'll try to be clearer about that next time.

Why is this not specified in the release notes for this release?

It's not in the release notes anywhere because v3 never did anything with OTP in the first place - there was no release of v3 in which OTP changed, it was absent the whole time. Our release notes generally list PRs that have been merged since the previous release. The lack of OTP in v3, and the reasons why, are detailed in the FAQ.

There's no indication... that OTP support is something which is actively being pursued.

Good point - we overlooked that, so thanks for pointing it out. This information has now been added to the README.

That popup... did not provide (at least on macs) anyway of following, or even seeing the full content of, the link.

That's really good to know. Our testing did show the whole message, but it looks like something may be a bit different on the Mac side, even though the browser is the same. That the link was truncated on your system is troubling (thanks for the screenshot), and something we need to address.

I am perfectly happy to try the new extension.

Sounds good. Let us know if you encounter any issues with it - we've ensured we have round-the-clock eyes on the project during the release (hooray timezones), so if you find anything major, we should be able to address it reasonably quickly.

Error: Error: {"status":"error","code":14,"version":3000006,"params":{"action":"configure","error":"lstat /home/matt/.password-store: no such file or directory","message":"The default password store is not accessible","storePath":"/home/matt/.password-store"}}
And i cannot find where to change the password store location any more

In extension options, click on "Add store", fill it in and hit "Save":

@symonds The store location can be configured in the extension options. These are accessible via the right-click menu:

Thats not possible as the error blocks that window from opening, instead you just get the error pasted above.
I mkdir /home/matt/.password-store, at which point the error disappeared and I could change add the store location and remove the old directory.
Should be fixed so that if the directory doesn't exist you can still set those options.

Nice finding @symonds, will fix 👍

@symonds Fixed in browserpass/browserpass-extension#94.

Hi, my install of brave (on funtoo) does not react to the host being installed with hosts-brave and policies-brave. It does, however, work with host-chromium and policies-chromium.

The problem seems to be fixed now.

Launched Firefox.
 Have I been hacked?
Oh, it’s a new icon for browserpass. Ok.
Press
Error!
🤔
spend the next fifteen minutes figuring out why the extension broke and how to install the new native binary

I feel the transition could have been handled far more eloquently.

Without breaking all existing installs by default (but prompting them to install the new, non-backwards compatible extension as an option)

By providing a far more streamlined migration process (especially for the native binary).

Thank you very much for Browserpass, it is absolutely awesome. And I hope the above feedback helps make it even better.

@aral Thanks for your feedback - I feel your pain, it's frustrating! We did try to warn people - we've been displaying a popup about this for the last week - but there are aspects of the transition that we could improve on for next time something like this comes up.

Without breaking all existing installs by default (but prompting them to install the new, non-backwards compatible extension as an option).

Releasing an entirely new extension under a different ID every time a breaking change occurs is simply not practical. Ideally, we'd have it check the native app version and delay the upgrade until the native app is upgraded, but sadly the various webstores don't provide us any mechanism for implementing this.
If you have a suggestion for how this could practically be achieved, without cluttering up the webstore with multiple extensions, we'd love to hear your ideas.

By providing a far more streamlined migration process (especially for the native binary).

Normally this will be the case. We couldn't do it in any practical manner for the upgrade from v2 to v3, because the entire protocol for communication with the native app has fundamentally changed. However, we designed the v3 protocol specifically with this issue in mind, because breaking changes are frustrating for everybody involved.
Going forward, it should be possible to update the browser extension, and have it continue to function correctly with an older native app. There might be the occasional new feature which doesn't work until the native app is updated (although most new features will not require an update at all), but none of the existing functionality should break.

Why is this not specified in the release notes for this release?

It's not in the release notes anywhere because v3 never did anything with OTP in the first place - there was no release of v3 in which OTP changed, it was absent the whole time. Our release notes generally list PRs that have been merged since the previous release. The lack of OTP in v3, and the reasons why, are detailed in the FAQ.

Look - I can understand the semantic explanation here. What you're saying is the same as Dennis Hopper on the set of Apocalypse Now arguing that he hasn't forgotten his lines because he never learned them. However:-

v2 of browserpass handled OTP.
v3 of browserpass does not handle OTP.

That should be in the release notes. It is a major change to the program. It is the removal of essential functionality for many people.
Like others, I am tremendously thankful for all that the team has done with browserpass. I don't understand why you've chosen to be this actively hostile to users, and so defensive when users react to being treated like this.

I don't understand why you've chosen to be this actively hostile to users
Your FAQ on OTP is, frankly, insulting

even though I regret the support for OTP, I don't see any hostility or insult in the maintainers' writings. In my opinion, the maintainers have done quite a good job at explaining their reasoning and at taking into account every feedback they got.

@dg01d OTP functionality now exists.


Fix calendar spec

@andrew — why did the test start breaking?

@nodunayo because the first day of the month changed between 2018 and 2019 and the test assumed 2018, simply updated it for 2019 as a quick fix


refactor: clean up for GlobalContext rename

What does this PR try to resolve?
Cleanup after https://github.com/rust-lang/cargo/pull/13409
How should we test and review this PR?
CI passes and we're ready to go.
Additional information

A couple more items.  Can be in this PR or one of us can do it in another

Rename src/cargo/utils/config to context
Rename config_configure to configure_gctx

A couple more items. Can be in this PR or one of us can do it in another
* Rename `src/cargo/utils/config` to `context`

* Rename` config_configure` to `configure_gctx`

Let's do it in another, as public item renames would be involved?

@bors r+

:pushpin: Commit 75dbb865917af9fc5fa5b985d8f9585aa16aa3d4 has been approved by epage
It is now in the queue for this repository.

:hourglass: Testing commit 75dbb865917af9fc5fa5b985d8f9585aa16aa3d4 with merge e975158c1b542aa3833fd8584746538c17a6ae55...

:sunny: Test successful - checks-actions
Approved by: epage
Pushing e975158c1b542aa3833fd8584746538c17a6ae55 to master...


Add orgnaization resource

I created a resource for managing snyk organizations. The version choice for the api is probably wrong, and the structure could be optimized, but it adds what is needed for creating and deleting organizations in a group.

Something happened with files reoopening a different one


start method returned from watch is undefined

https://github.com/TRON-US/tronweb/blob/b0a694d4dbcd708a528e32839d8d0e50b8187fe5/src/lib/contract/method.js#L359
Shouldn't this line just be start: bindListener, so you can call it later?

We'll fix this in the next version.

fixed in version v2.10.2


Remove file in filepond client-side without triggering revert function

Hi, first of all, thanks for this wonderful tool for file upload.
I've just noticed that there was an update on the latest version 4.13.6 related to revert function. I used to have 4.13.4 installed in my apps but when I ran npm install yesterday, filepond's removeFile function now triggers revert function which basically triggers file removal in the server. My system requirement prior this update was to remove a file from filepond area in 5 second count to clear the filepond area and give space for new uploads, and not to totally revert the file upload. Are there any workaround for this in the current update or some other way to remove the uploaded file in filepond area without triggering revert function?
Thanks in advance! Any suggestions or help will be greatly appreciated.

I'm not sure I understand the use case, but if the files should not be removed, maybe add mock files?

I'm not sure if adding a mock file will work as an alternative, but here's my code for you to clearly visualize what I want to achieve.
In 'pondOptions' I have this defined
revert: (objectParam, load, error) => {           var params = JSON.parse(objectParam);           // Func to delete the file from the server }
then I also have this function to perform some logic once file is successfully uploaded. After 5 seconds, we should be able to remove the file in filepond area and add the uploaded files in a list view. Within the 5 second mark, we allow reverting of file upload transaction, otherwise the file will be transferred from filepond area to the list view.
onprocessfile(event: any) {     setTimeout(() => {       event.pond.removeFile();     }, 5000); }
This feature works nicely prior the updates from 4.13.4 but not in the latest release. I was thinking if there are other things I can do to remove a file from filepond area once successfully uploaded without deleting it from the server.

Okay, now I understand, hmm might be better to revert the change and add a parameter to the API method. I’m going to give it some though.

Published 4.13.7 should restore functionality to normal.
To trigger revert you can now pass { revert: true } to the removeFile method.

Thanks @rikschennink. I really appreciate your help. :) Very nice work.


Allows user to provide filepath to BigQuery credentials when connecting via SDK

Describe your changes and why you are making these changes
Previously we only allowed users to connect to BigQuery from the SDK if they provided a string of the svc account credentials. This is not user-friendly so we should allow them the option of specifying a file, since typically these credentials are downloaded in a JSON file.
This was also a pre-req for our integration tests, since it is easier to specify a credentials file instead of copying a long JSON string in the test-credentials file.
Related issue number (if any)
ENG 2386
Test
See the following notebook commands:

Loom demo (if any)
Checklist before requesting a review

[ ] I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
[ ] I have performed a self-review of my code.
[ ] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
[ ] If this is a new feature, I have added unit tests and integration tests.
[ ] I have run the integration tests locally and they are passing.
[ ] I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
[ ] All features on the UI continue to work correctly.
[ ] Added one of the following CI labels:

run_integration_test: Runs integration tests
skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

cc @vsreekanti since there are some SDK changes involved in terms of how a user can connect to big query from the SDK

The API looks fine. Do we require an absolute path, or is a relative path okay?

@vsreekanti Relative is fine

@likawind This is only meant to be local relative to the SDK. We are not storing this filepath in the backend, so this filepath should be a local filepath. It probably is unnecessary to support S3 paths for this feature.


new: add support to tags variable

Is there any other change needed to merge this PR?

Merged. New release is - https://github.com/terraform-community-modules/tf_aws_private_subnet_nat_gateway/releases/tag/v1.0.1
Previous code is tagged as https://github.com/terraform-community-modules/tf_aws_private_subnet_nat_gateway/releases/tag/v1.0.0


SIP creates non-signed file when agent timeout

User tried to run
mirrord exec -f .. -- ./script.sh
then got agent timeout, next execution everything failed because it used the patched sh binary that for some reason wasn't signed.
Two possible solutions (maybe should do both):

when reusing "file cache" - check file is also signed before reusing it
find how execution failure can lead to signing not happening?

seems that deleting the file doesn't help, but manually codesign'ing again does help. very weird.
user has some AV that blocks running unsigned code

I'm trying to reproduce this issue with no luck.
I can cause an agent timeout by running
MIRRORD_AGENT_TEST_ERROR=true mirrord-dev exec -t deployment/py-serv-deployment -- sh
! Warning: field AgentConfig.test_error is marked as unstable. Please note API may change
When targeting multi-pod deployments, mirrord impersonates the first pod in the deployment.
Support for multi-pod impersonation requires the mirrord operator, which is part of mirrord for Teams.
You can get started with mirrord for Teams at this link: https://mirrord.dev/docs/overview/teams/?utm_source=multipodwarn&utm_medium=cli
  x ! Warning: field AgentConfig.test_error is marked as unstable. Please note API may change
    ✓ running on latest (3.125.0)!
    x preparing to launch process
      ✓ layer extracted
      ✓ operator not found
      ✓ agent pod created
      ✓ pod is ready                                                                                Error:   × Failed to communicate with the agent: timeout
  help: Please check agent status and logs.

        - If you're still stuck:

        >> Please open a new bug report at https://github.com/metalbear-co/mirrord/issues/new/choose

        >> Or join our Discord https://discord.gg/metalbear and request help in #mirrord-help

        >> Or email us at<EMAIL_ADDRESS>
On a cluster without an operator (did the user have an operator installed?).
But no patched sh is created (find $TMPDIR -iwholename "**/bin/sh" 2>/dev/null does not return results).
Any more information for reproduction, @aviramha?
How should I proceed? Should I continue trying to reproduce? Should I add a signature check for executing already patched binaries and sign them before running if they're not signed?

The user had an operator.
Not sure if we can reproduce it as they had some custom AV..
I think maybe the more complete solution would be to create the patched file in temp file, codesign it then mv it to the "cache". Wdyt?

I think maybe the more complete solution would be to create the patched file in temp file, codesign it then mv it to the "cache". Wdyt?

Sounds good. Not sure if that's exactly what you meant, but when patching a file we can write the binary to a file with a random path, sign it there, and only move it to the destination once we're done. That way there is no need for extra checks on running an existing patched file, because if it's there it means it's signed (except for files created by older mirrord versions, but they will be deleted on a restart).

That's what I meant 🙂

So apparently we already do that @aviramha
https://github.com/metalbear-co/mirrord/blob/705998e979b188977673de429d163ead28c9c7c9/mirrord/sip/src/lib.rs#L277-L279
https://github.com/metalbear-co/mirrord/blob/705998e979b188977673de429d163ead28c9c7c9/mirrord/sip/src/lib.rs#L312-L317

Ok let's close this 😢


better conform with python3 style

see e.g. http://portingguide.readthedocs.io/en/latest/classes.html
also some minor questions/suggestions
does this pass pylint?

@yunfangjuan I saw some typos in check_s3_pres(e)nce_for_file_list and s3_downlo(a)dable


drivers: adc: permit use of vref_mv, even if reference == ADC_REF_INTERNAL

It is useful to be able to provide a zephyr,vref-mv property that takes a potential divider into consideration, allowing direct measurement of a voltage higher than the part's maximum, with no further conversion steps.
For example, a potential divider with a 10kOhm resistor between the signal and the ADC input, and a 1kOhm resistor between the ADC input and ground can permit measuring a voltage up to 11x higher. In this case, a zephyr,vref-mv value of Vref * 11 can be given. When a call is made to adc_raw_to_millivolts_dt(), the "real" voltage is returned immediately.
This PR is in response to further reflection on #67634

the actual voltage the ADC measures is still not incorrect.... it is measuring the output of a voltage divider circuit, not the input. The internal reference it is using does not change.

Agreed, the actual voltage at the input to the ADC is read correctly... but in the example design, that ADC input voltage is fairly meaningless, we're really interested in the input to the divider - the device tree feels like the right place to describe this sort of detail. Alternatively, the value would need to be scaled a second time after the reading, which presents a level of disconnect from the hardware.
This is a per-channel node, so we're not unduly affecting everything that uses this ADC / reference.

the actual voltage the ADC measures is still not incorrect.... it is measuring the output of a voltage divider circuit, not the input. The internal reference it is using does not change.

Agreed, the actual voltage at the input to the ADC is read correctly... but in the example design, that ADC input voltage is fairly meaningless, we're really interested in the input to the divider - the device tree feels like the right place to describe this sort of hardware implementation detail. Alternatively, the value would need to be scaled a second time after the reading, which presents a level of disconnect from the hardware.
This is a per-channel node, so we're not unduly affecting everything that uses this ADC / reference.

Mt feeling is that just like any other interpretation of the meaning of an ADC measurement, this belongs in application software.

this belongs in application software

Understood, thanks - is this a blocking / no-merge decision, or are you looking for other opinions?

To follow up, this is actually not so hard to do in the application code, it's possible to just force using vref_mv from the device tree:
-       ret = adc_raw_to_millivolts_dt(&adc_vin, &tmp_mv);
+       ret = adc_raw_to_millivolts(adc_vin.vref_mv, adc_vin.channel_cfg.gain, adc_vin.resolution, &tmp_mv);

I am not sure if I am understanding your goal. If you are measuring from the adc a signal that is 11x another signal, as an example, and you need in software the value of the other signal, which you know is 1/11 of the measurement, can't you just divide the result of the adc measurement in software by 11?

Also, look into the voltage divider header
https://github.com/zephyrproject-rtos/zephyr/blob/main/include%2Fzephyr%2Fdrivers%2Fadc%2Fvoltage_divider.h

can't you just divide the result of the adc measurement in software by 11?

It's the other way around... e.g: read 1.8v (or the raw equivalent), and produce 19.8v / 19,800mV as the output value.
It's a trivial problem for sure, but as above, I'd like to describe this hardware detail in the device tree - maintaining a single function that may have multiple analog inputs, each with a different radio on the potential divider.
e.g: this project has a 3S LiPo and a 5v super capacitor, each divider needs to be enabled, given time to settle, read, and then disabled. Scaling them both by a common value isn't ideal (you loose resolution on the supercap), and handling these scale values in the application side is not ideal either.

The 12.6v nominal battery is divided down to ~1.145v, but needs to be presented to the application as 12.6v (x11).
The 4.5v nominal supercap is divided down to ~1.596v, but needs to be presented to the application as 4.5v (x2.82).

My current approach (with this patch) is to declare the zephyr,vref-mv in the device tree for each ADC channel, which works well:
    adc_vin: channel@1 {
        reg = <1>;
        zephyr,gain = "ADC_GAIN_1";
        zephyr,reference = "ADC_REF_INTERNAL";
        zephyr,acquisition-time = <ADC_ACQ_TIME_DEFAULT>;
        zephyr,resolution = <12>;
        zephyr,vref-mv = <19800>;
    };

    adc_supercap: channel@2 {
        reg = <2>;
        zephyr,gain = "ADC_GAIN_1";
        zephyr,reference = "ADC_REF_INTERNAL";
        zephyr,acquisition-time = <ADC_ACQ_TIME_DEFAULT>;
        zephyr,resolution = <12>;
        zephyr,vref-mv = <5074>;
    };

Also, look into the voltage divider header

I didn't know about this - looks ideal! ... I'll check this out properly, and may come back to close this PR, thanks.

@attie-argentum what is the verdict? should we close the PR?

Thanks / sorry @decsny - I missed your message... I've not had a chance to actually do this yet, but I expect it will be fine.

Thanks / sorry @decsny - I missed your message... I've not had a chance to actually do this yet, but I expect it will be fine.


undefined variable fixed

build was broken. Now it works

sorry about that, @jamiehannaford got it first though :smile: #11


This brings the style on this repo inline with others

This is a simple change to the style

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


sap.m.Switch unnecessarily HUGE in sap.m.Table

The code:
<Switch type="AcceptReject" state="true"></Switch>

Why does it do this? How do I make it stop? :)
If there isn't a way to easily fix this, this is an #issue

Hi @RaisingAgent,
do you have a sample for this issue?
It would be very helpful for our control developers if you could build a a small plnkr sample:
http://plnkr.co/edit/YUMEqD2Z0earCmA4I2nA?p=info
Thanks,
Thodd

Try adding sapUiSizeCompact, sapUiSizeCozy https://jsbin.com/nixahusuto/edit?html,output
For more details https://openui5.hana.ondemand.com/#/topic/13e6f3bfc54c4bd7952403e20ff447e7


ScenarioList.from_dict()

d = [{'period: 'morning'}, {'period: 'evening'}]
sl = ScenarioList([Scenario(e) for e in d])

Yeah let's just leave as standard loop for now. Closing this.


Externals external

Leaflet and lodash were included in the dist/vue2-leaflet.js files. I have removed them using https://www.npmjs.com/package/webpack-node-externals.

Sounds good to me

I've just publish an updated version (0.0.27) to npm

Great thx!


refactor: handle undefined on setAttributes params

in deriv-app we have to setAttributes several times, in this case we have to handle all undefined's properties
here is example with quick tests how it works

@NikitK-deriv can you update the version in package.json ?


feat: Add Azure and Oracle Fabric Cloud Router connections

Adds the below Fabric cloud router(FCR) connections types and related tests and examples

FCR to Azure cloud
FCR to Oracle cloud

Codecov Report
Patch coverage: 20.00% and project coverage change: +45.68% :tada:

Comparison is base (973fdaa) 13.73% compared to head (66de217) 59.41%.
Report is 2 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #382       +/-   ##
===========================================
+ Coverage   13.73%   59.41%   +45.68%
===========================================
  Files           8       98       +90
  Lines         910    19750    +18840
===========================================
+ Hits          125    11735    +11610
- Misses        770     7720     +6950
- Partials       15      295      +280

Files Changed
Coverage Δ

equinix/fabric_mapping_helper.go
0.80% <0.00%> (ø)

equinix/fabric_connection_schema.go
100.00% <100.00%> (ø)

... and 88 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Run profiler for all models

Is it possible to just include the profiler to all models and keep the output in another table with the results to have historical data?

Hi @moseleyi ! Currently, there's no way to profile all models in a single macro execution. However, you can write a custom script that loops all the models and profiles them individually. Would this be sufficient for your needs? :)

I think so. Thanks for clarification @stumelius


Edit README

Codecov Report

Merging #28 (57bed7e) into master (d4a03c7) will not change coverage.
 Consider uploading reports for the commit 5943186 to get more accurate results

@@            Coverage Diff            @@
##             master      #28   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Cannot find tag PackIconMaterialDesign line 47 of StaffDetailsView.xaml

I brought your package down thru VisualStudio 2019 and it installed fine. When I compiled it had the above error. i checked References of StaffStuff.WPF and the MahApps.Metro.IconPacks.MaterialDesign is present. The xmlns:mdi= line is at the top of the xaml. I don't how to fix. Would appreciate help. Your article is very interesting and i wanted to run the example.
Thank you.
Bruce

I note it is complaining that I am using .Netframework 4.6.1 instead of 4.7 I will see if I can upgrade


Core test not working in sbt.

Core test is broken in sbt. The tests won't compile, but they are working fine in Mill. I've delayed bumping the uTest version.

Fixed.


Unable to create Firestore client when user is authorized

I cannot create a client for firebase when using an authorized HTTP client. The problem does not occur when I am anonymous.
Environment details

OS: Mac OS
Python version: Python 3.6.8 (v3.6.8:3c6b436a57, Dec 24 2018, 02:04:31) [GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.57)] on darwin
pip version: pip 19.0.3
google-api-python-client version: google-api-python-client==1.7.10

Steps to reproduce
When I ran following code
import google_auth_httplib2

from googleapiclient import discovery
import httplib2

import google.oauth2.service_account

key_path='files/gcp/keys/sa.json'

credentials = google.oauth2.service_account.Credentials.from_service_account_file(key_path, scopes=[
    "https://www.googleapis.com/auth/cloud-platform",
])

http = httplib2.Http()
authed_http = google_auth_httplib2.AuthorizedHttp(credentials, http=http)

print("Non authorized client: ")
try:
    print(discovery.build("firestore", "v1"))
except:
    print("Unable to create client")

print("Authorized client: ")
try:
    print(discovery.build("firestore", "v1", http=authed_http))
except Exception as e:

    print("Unable to create client")

I got folllowing message;
Non authorized client:
<googleapiclient.discovery.Resource object at 0x10c8dc390>
Authorized client:
Unable to create client
<HttpError 400 when requesting https://www.googleapis.com/discovery/v1/apis/firestore/v1/rest returned "Request contains an invalid argument.">

I am currently using the following hack, which allows me to build a client that works properly and uses authorization.
print("Hack:")
try:
    non_authorized_conn = discovery.build("firestore", "v1", cache_discovery=False)
    client = discovery.build_from_document(
        non_authorized_conn._rootDesc,  # pylint: disable=protected-access
        http=authed_http
    )
    print(client)
except Exception as e:
    print("Unable to create client")

Hi mik :)
Had this issue as well. I think this module doesn't build the credentials the way google-api-python-client requesting it.
Try the following:
# Import discovery from 'google-api-client'
from googleapiclient import discovery
# Import GoogleCredentials Class oath2client.client
from oauth2client.client import GoogleCredentials
# Path to JSON File
jsonPath = "jsonCredentialsFile.json"
# Building credentials from stream
credentials = GoogleCredentials.from_stream(jsonPath)
# Define the service
try:
    service = discovery.build('firestore', 'v1', credentials=credentials)
    print(service)
# Throw exception if authentication failed
except Exception as err:
    raise Exception("Could not authenticate. See details: {}".format(err))

But why do all other services work properly?

The oath2client package is deprecated.  I can't use it in my project.

Hi @mik-laj,
I was able to reproduce the error, but I'll have to do some more investigation on why it is happening.
If possible, please use the modern firestore client google-cloud-firestore (https://github.com/googleapis/python-firestore).
You can pass the google-auth credentials directly to discovery.build. Could you try this?
credentials = google.oauth2.service_account.Credentials.from_service_account_file(key_path, scopes=[
    "https://www.googleapis.com/auth/compute",
])

print(discovery.build("firestore", "v1", credentials=credentials))

On an unrelated note you will probably want to adjust the scopes. Requests to the FIrestore REST API need the https://www.googleapis.com/auth/datastore scope. documentation

@busunkim96 I cannot pass credentials directly to the library because I want to set up a user agent.
I know there is another library for Firebase. Here is my PR. which adds this information to README.md.
https://github.com/googleapis/google-api-python-client/pull/833
According to this documentation, I use the correct scope.

Authorization Scopes
Requires one of the following OAuth scopes:
https://www.googleapis.com/auth/datastore
https://www.googleapis.com/auth/cloud-platform

https://firebase.google.com/docs/firestore/reference/rest/v1beta1/projects.databases/exportDocuments
I discovered this error while working on the integration of Airflow and Firestore.
My PR: https://github.com/apache/airflow/pull/7725
Code responsible for creating the API client:
https://github.com/apache/airflow/blob/63a3102/airflow/providers/google/firebase/hooks/firestore.py#L68-L79
Code responsible for creating the HTTP client:
https://github.com/apache/airflow/blob/63a3102ede8fb8f764d251b20cad5ee5bef84f50/airflow/providers/google/cloud/hooks/base.py#L218-L227
Code responsible for creating credentials;
https://github.com/apache/airflow/blob/63a3102ede8fb8f764d251b20cad5ee5bef84f50/airflow/providers/google/cloud/hooks/base.py#L145-L203

I saw that you had the compute scope in your original post and didn't correct it when I replied. Apologies if that caused confusion. 😄
Are you trying to use Firebase or Firestore? There is a firestore specific library: https://github.com/googleapis/python-firestore. The one you linked in the pull request is https://github.com/firebase/firebase-admin-python.
If user-agent is the only blocker you can pass that via client_info in the modern clients. See
https://googleapis.dev/python/firestore/latest/client.html
I'll go do some more investigation on AuthorizedHttp.

I want to use Firestore, more precisely, I need the export_documents method. This method is not available in the google-cloud library according to documentation
but I looked at the source code and found that this method is available.
https://github.com/googleapis/python-firestore/blob/master/google/cloud/firestore_admin_v1/gapic/firestore_admin_client.py#L648-L656
This will probably solve my problem completely, but now we have another problem - holes in documentation.

Here is ticket about lack of documentation for FirebaseAdminClient; https://github.com/googleapis/python-firestore/issues/30

I think this is a discovery bug. Googlers, see internal issue 170905603.
Summary:
The firestore discovery docs cannot be retrieved when there the GET request has extra headers. This occurs for all the versions of firestore (v1, v1beta1, v1beta2) using both the v1 and v2 style discovery URIs.
$ curl -H "authorization: Bearer foo"  https://firestore.googleapis.com/\$discovery/rest?version=v1
{
  "error": {
    "code": 400,
    "message": "Request contains an invalid argument.",
    "status": "INVALID_ARGUMENT"
  }
}
$ curl -H "authorization: Bearer foo"  https://www.googleapis.com/discovery/v1/apis/firestore/v1/rest
{
  "error": {
    "code": 400,
    "message": "Request contains an invalid argument.",
    "status": "INVALID_ARGUMENT"
  }
}

This does not seem to cause an issue for other APIs.
$ curl -H "authorization: Bearer foo"  https://datastore.googleapis.com/\$discovery/rest?version=v1
...
$ curl -H "authorization: Bearer foo"  https://www.googleapis.com/discovery/v1/apis/datastore/v1/rest
...

Hi @mik-laj ,
We've just released version 2.0 of google-api-python-client. One of the key features is that discovery.build() will retrieve discovery documents from the client library itself rather than fetching them over the internet. Please try version 2.0 and let us know if you're still experiencing an issue. I'm going to close off this issue due to inactivity. If you're still having trouble, please re-open it with more information.


Fragile E2E test: 24-event.createOrder.test.js

Sample runs:

https://circleci.com/gh/opencollective/opencollective-frontend/60987
https://circleci.com/gh/opencollective/opencollective-frontend/61688
https://circleci.com/gh/opencollective/opencollective-frontend/61873
https://circleci.com/gh/opencollective/opencollective-frontend/62208

There is a first error message that is non breaking. It should be fixed.
error: Error while generating the ics file for event id 10893 (*********************/31c67739-888/events/test-event-with-vat-2997cc7f)child "start" fails because ["start" at position 0 fails because ["0" must be a number]]

The breaking error that is making the test fragile is the following.
1) event.createOrder page makes an order for a free ticket as an existing user:
     Uncaught Error: Cannot clear timer: timer created with requestAnimationFrame() but cleared with clearTimeout()

I'm reopening to focus on the first warning.


Update CRI tests to build and push to gcs

This enables to the CRI e2e tests to use the build from a PR
WIP: for testing

/test pull-containerd-build

/test pull-containerd-build

/test pull-containerd-build

/test pull-containerd-build

/test pull-containerd-build

/test pull-containerd-build

/test pull-containerd-build

/retest

/test pull-containerd-build

/test pull-containerd-node-e2e

LGTM @dmcgowan

Merging, the e2e tests aren't expected to pass yet


Denizen not compatible spigot 1.8.3

git-Spigot-beb883d-234e607 (MC: 1.8.3)
[07:56:55 INFO]: [Denizen] Enabling Denizen v0.9.6-SNAPSHOT (build 1568)
[07:56:55 WARN]: [Denizen] -------------------------------------
[07:56:55 WARN]: [Denizen] This Denizen version is not compatible with this CraftBukkit version! Deactivating Denizen!
[07:56:55 WARN]: [Denizen] -------------------------------------
[07:56:55 INFO]: [Denizen] Disabling Denizen v0.9.6-SNAPSHOT (build 1568)

Grab the latest developmental builds for 1.8.3 from here
http://ci.mineconomy.org/job/Denizen_Developmental/lastSuccessfulBuild/

Success, Thank you !! i expected http://ci.citizensnpcs.co/job/Denizen/ to be the latest. i will bookmark that link.

We haven't documented it much, but http://ci.citizensnpcs.co/job/Denizen/ is now for release builds, while the new link is for the latest developmental builds


keepDfcSecurityAssignments not working as expected

policy-plan.json
global-settings copy.jsonc
Based on the "global-settings" file attached running a "build-deploymentPlans" gives the output (attached plan) in which it is stated that all ASC assignments will be removed.
Based on this docs it shouldn't happen.
Our code is fully synced with with this repo origin.

The image shows just an example of roles that are to be removed too, and are used by ASC.

Hi @techlake . In the first message I have attached policy-plan file that shows that assignments will be removed. Role part is just addition to that.

Update from my side.
The behavior is not the same when I locally run "build-deploymentPlans" and when it is triggered within the pipeline (from starter set).
Problem described above is local behavior and within the pipeline it skips ACS assignments as expected.


Squad info

Hi,
is there an option to see in which squad a sentinel is. /sentinel info doesn´t show the squad...
Greetings

Added to info command in build 108.

Works great. Thanks :)


Login page/customer form edits

I kinda did a lot here.
I reworked the login page and customer form to match styling. But the functionality is still not there.
I should have made a new branch for this second part, but did it without realizing.
I made the User Management section where you can search by email for customers and bring up their info.  You can then edit and resubmit their info.  That whole page works just fine.

great job

Thanks guy!


Pass over DataFixers

This PR maps a bunch of things in net/minecraft/datafixers/fixers, mostly focusing on missing parameter names and method names. Hopefully clearer names in this area help people understand DataFixer better.
Some highlights:

Constructor parameters changed to outputSchema and changesType.

Obvious change since this is what DataFixerUpper calls them. There's just lots of these parameters.

EntityPaintingFix -> HangingEntityFix

It applies to paintings and item frames, not just paintings.

ItemOminousBannerRenameFix -> OminousBannerItemRenameFix

Suffixy.
Matched the other one.

OminousBannerBlockEntityRenameFix#convertOutdatedTranslationKey -> fixBannerName

Felt wordy? Idk.
It's a fixer, so of course it's converting something outdated.
(see also OminousBannerItemRenameFix's method that I named myself to the same thing.)

Parameters:

Dynamic<?> -> tag in most cases

Realistically we are talking about nbt tags in 90% of cases where a dynamic appears.

DynamicOps<?> -> ops

What DataFixerUpper calls them.

Some questions:

Parameters: What to call "Typed"s? I can't find any Typed names in DataFixerUpper.
LeavesFix, SwimStatsRenameFix, VillagerXpRebuildFix

These don't wanna decompile for me!

SavedDataVillageCropFix#a, b

Maybe I've been staring at Yarn too long but I can't figure these ones out.
Seem to be "plumbing" functions.

The questions can be left for another PR.

The package is still riddled with prefixing so the two class renames have actually made the inconsistency worse

VBO in OptionsForceVBOFix should be Vbo

I think it's worth noting that a lot of the names are just lifted from the data fixer names within the file. For instance, the VBO fix contains OptionsForceVBOFix in the name, and so the class is most likely named that. Likewise OminousBannerItemRenameFix is (probably) just called OminousBannerRenameFix. A lot of the the prefixed names (say, BlockEntityJukeboxFix) are only because that's what name is used within the class.
Of course, that doesn't mean we have to go with (assumed) Mojang names here, it was just the decision I made when originally mapping some of these classes out :).

these prefix names are straight from mojang names, so things don't need change

Hmm, I think even if you want to stick to the internal string names, there's definitely a lot of cases where it's appropriate to slightly change the spelling or casing of data fixer classes, since not all fixer names have a string that works as a class name anyways (like Map id fix)
I like OminousBannerItemRenameFix: the mojang string is just OminousBannerRenameFix and idk, part of me likes the Item clarifying that it's not the OminousBannerBlockEntityRenameFix? Agree with the VBO -> Vbo tho

If you change ItemOminousBannerRenameFix, you'd need to change all other class names that are prefixed like that, too though, for consistency.


Convector not working - add new device

Hi!
I have a convector/heater from a local brand, betterlife, this is the device
https://www.betterlife.cl/product/estufa-electrica-infrarroja-con-wi-fi-bl2000w/
I managed to get the ID and Key with Charles and now have the config set on my config panel:
{
"platform": "TuyaLan",
"devices": [
{
"name": "Estufa",
"type": "Convector",
"manufacturer": "Betterlife",
"model": "BL2000W",
"id": "XXXXXXXXXXX",
"key": "YYYYYYYYYYY",
"cmdLow": "Low",
"cmdHigh": "High",
"minTemperature": 20,
"maxTemperature": 30,
"noChildLock": false
}
]
},
Problem is that when appears in home app it keeps in updating or can't connect, from terminal  I can see this:
[6/19/2019, 2:06:08 PM] [TuyaLan] Ready to handle Estufa with signature {"1":false,"2":28,"4":"1","6":false,"11":0,"101":0}
Any ideas of what can be? Thanks!

Can you post some more of the log, maybe grep by Tuya to see all the logs from this plugin.

this is the new signature that I get:
[9/6/2019, 4:27:45 AM] [TuyaLan] Ready to handle Estufa with signature {"1":false,"2":30,"4":"1","6":false,"11":0,"101":0}
HAP Warning: Characteristic 00000012-0000-1000-8000-0026BB765291 not in required or optional characteristics for service 000000BC-0000-1000-8000-0026BB765291. Adding anyway.
HAP Warning: Characteristic 00000036-0000-1000-8000-0026BB765291 not in required or optional characteristics for service 000000BC-0000-1000-8000-0026BB765291. Adding anyway.
HAP Warning: Characteristic 000000A7-0000-1000-8000-0026BB765291 not in required or optional characteristics for service 000000BC-0000-1000-8000-0026BB765291. Adding anyway.
HAP Warning: Characteristic 00000029-0000-1000-8000-0026BB765291 not in required or optional characteristics for service 000000BC-0000-1000-8000-0026BB765291. Adding anyway.
also I got the:
[TuyaAccessory] Odd message from Estufa with command 8: { cmd: 8,
data:
'J~æ¾Zø\u0006ah§¸þ\u001bo\u001aeV+»®:ÀÊYôÎùµb7¶Î=×j~\u0012¦\u0005\u0002w1\u001c;Í\u0010´)ÆßO\#¼í+0®éG¯ð:\u001c' }

There are two problems that I see:

The HAP complaints indicate an outdated HAP which could be an indicator of an outdated Homebridge. Do you know what version of Homebridge you are running?
The "Odd message" is the main problem preventing you from using your device. In non-3.3 devices, this indicates a wrong key. Follow the new Setup Instructions to get the key again. I have heard comments about some devices changing keys when they are reset, sent bad data, or change WiFi.

Either way, please update to the latest rc release to benefit from better log messages which will help us figure out what the root cause might be. Get it using npm i -g homebridge-tuya-lan@rc.

For the point 1 I have I think the latest homebridge version 0.4.50, regarding point 2 this is the log:
[9/7/2019, 10:16:24 PM] [TuyaLan] Discovered Estufa (XXXX)
[TuyaAccessory] Discovery ended.
[9/7/2019, 10:16:24 PM] [TuyaLan] Connected to Estufa
[9/7/2019, 10:16:24 PM] [TuyaLan] Ready to handle Estufa with signature {"1":false,"2":30,"4":"1","6":false,"11":0,"101":0}
HAP Warning: Characteristic 00000012-0000-1000-8000-0026BB765291 not in required or optional characteristics for service 000000BC-0000-1000-8000-0026BB765291. Adding anyway.
HAP Warning: Characteristic 00000036-0000-1000-8000-0026BB765291 not in required or optional characteristics for service 000000BC-0000-1000-8000-0026BB765291. Adding anyway.
HAP Warning: Characteristic 000000A7-0000-1000-8000-0026BB765291 not in required or optional characteristics for service 000000BC-0000-1000-8000-0026BB765291. Adding anyway.
HAP Warning: Characteristic 00000029-0000-1000-8000-0026BB765291 not in required or optional characteristics for service 000000BC-0000-1000-8000-0026BB765291. Adding anyway.
When I do any action (press power on, set temperature in24, then 30, then turn off) in the home app this is why I get:
[TuyaAccessory] Sending Estufa {"7":true}
[TuyaAccessory] Sending Estufa {"7":true}
[TuyaAccessory] Sending Estufa {"2":24}
[TuyaAccessory] Sending Estufa {"2":30}
[TuyaAccessory] Sending Estufa {"7":false}
none of the actions were performed, Ill check later tonight the key capture again and check back

so update: it effectively changed the key, so looked again and now works, it didn't power on but after add "dpActive": 1, it works, the only thing that is not working is changing the mode between low, high and a eco mode that has.
Also have to think any alternative to merge with a thermometer to get the temperature of the device and not showed as 0,0 in home app, beside that two things works flawlessly.
thanks!

First of all, I want to apologize; I confused you for someone else and didn't pay attention to a few details that you had already provided.
Your signature indicates that:

1 which I believe is power
2 the desired temperature
The device doesn't report the current temperature
I am not sure what 4, 6, 11, or 101 are.

Convector is a much more complex device. Yours would be great with SimpleHeater. Please use this configuration, substituting in your id and key.
{
    "name": "Estufa",
    "type": "SimpleHeater",
    "manufacturer": "Betterlife",
    "model": "BL2000W",
    "id": "*************",
    "key": "***********",
    "dpCurrentTemperature": 2,
    "minTemperature": 20,
    "maxTemperature": 30
}

Let me know how it goes.

Works perfect!  post you the new log:
9/8/2019, 1:16:21 AM] [TuyaLan] Connected to Estufa
[9/8/2019, 1:16:21 AM] [TuyaLan] Ready to handle Estufa with signature {"1":false,"2":26,"4":"1","6":false,"11":0,"101":0}
HAP Warning: Characteristic 00000012-0000-1000-8000-0026BB765291 not in required or optional characteristics for service 000000BC-0000-1000-8000-0026BB765291. Adding anyway.
then at turn on and change temperature:
[TuyaAccessory] Sending Estufa {"1":true}
[TuyaAccessory] Sending Estufa {"1":true}
[TuyaAccessory] SimpleHeater changed: {"1":true,"2":26,"4":"1","6":false,"11":0,"101":0}
[TuyaAccessory] Sending Estufa {"2":29}
[TuyaAccessory] SimpleHeater changed: {"1":true,"2":29,"4":"1","6":false,"11":0,"101":0}
[TuyaAccessory] Sending Estufa {"2":23}
[TuyaAccessory] SimpleHeater changed: {"1":true,"2":23,"4":"1","6":false,"11":0,"101":0}
[TuyaAccessory] Sending Estufa {"2":30}
[TuyaAccessory] SimpleHeater changed: {"1":true,"2":30,"4":"1","6":false,"11":0,"101":0}
[TuyaAccessory] Sending Estufa {"2":25}
[TuyaAccessory] SimpleHeater changed: {"1":true,"2":25,"4":"1","6":false,"11":0,"101":0}

Wow. great. Sorry that it took me so long to realize I had you mixed up.
I have not been able to get the Tuya app to talk to the Merkury camera locally. If I can carve some time, I will try and play with it again. I saw something a few days ago which might lead to something.


Updated README by fixing small typo in code block

The example code showing how to create a JWT use a payload containing a uid property. Reuse this payload property in the code example that verify the JWT (instead of id).

thanks man! :)


Add a page for inject failure demo

What type of PR is this?

/kind documentation
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Add shortcode code-sample
Add a page for inject failure demo

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

/cc @yuanchen8911
/cc @network-charles

/hold


regression around Inconsistent implicit qualifiers (did not expect argument aquals)

Hi,
our CI just broke  on unchanged code:
/home/runner/.nix-profile/bin/fstar.exe
fstar.exe --cmi --warn_error -331-321-274 --cache_checked_modules --cache_dir .cache --already_cached "+Prims+FStar+LowStar+C+Spec.Loops+TestLib" --include "/nix/store/18l7w674px4kwazy5ip88yxqskwlcwxc-source"/lib --include "/nix/store/1hnjzj74rsk1g80pkq3jhvs7qg6mkfy2-fstar"/rust_primitives --include "/nix/store/1hnjzj74rsk1g80pkq3jhvs7qg6mkfy2-fstar"/core --include "/nix/store/vss9b7rkwgv7wxk4xxzh3q481iq5vimf-hax-lib"/proofs/fstar/extraction --admit_smt_queries true Riot_rs_runqueue.Runqueue.fst  --hint_file .hints/Riot_rs_runqueue.Runqueue.fst.hints
* Error 92 at Riot_rs_runqueue.Runqueue.fst(17,33-17,38):
  - Inconsistent implicit qualifiers (did not expect argument aquals)

We're using the hax action from "master", so I'm assuming some of the just merged changes here are the cause.
Let me know if I can provide more info!

I can confirm that pinning hax_reference to d10f891a19f96bcafa9e31b1d78763e4f3cf30b4 makes our CI work again, we'll be temporary doing that.

Hi, thanks for the report!
I will try to look at before the end of the day, I suspect that it is something easy to fix. We changed a convention and our F* core library may be not entirely updated yet, hence the problem you have here.

This issue is related to https://github.com/hacspec/hax/issues/719.
One patch we merged for solving #719 yielded this issue, but was not fixing entirely #719.
Thus, fixing this issue now would just make it re-appear differently when #719 is fixed. I'm thus waiting for #719 to be fixed before fixing this one.

Hi @kaspar030, sorry for the delay.
I just checked, and I believe this regression is fixed in latest hax, can you confirm it is fixed on your end?

@kaspar030 @elenaf9 is this still an issue?


Features support that can be added.

Discussed in https://github.com/Gautam-Arora24/resize-observer-hook/discussions/17

Originally posted by Gautam-Arora24 September 25, 2021
I just wanna know from the community members that what new features can be added to the library's scope?

I don't know if this features can be added in this same repo, but let me share the ideas:

Get background color on a click
Get text size, color, tag (like h3, h1 etc)

Kindly refer discussions.


Updating Travis-CI testing

Creating this so you can see my progress so far. Still need to replace save_model() with dump_model() and load_model() with get_dump().

Codecov Report

Merging #70 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
  Coverage   37.07%   37.07%
=======================================
  Files          16       16
  Lines        2004     2004
=======================================
  Hits          743      743
  Misses       1261     1261


Updated faq.css

resolves #705
Description
Improved the css of dropdown arrow in the FAQ section
Type of PR

[ ] Bug fix
[x ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist:

[ x] I have performed a self-review of my code
[ x] I have read and followed the Contribution Guidelines.
[ x] I have tested the changes thoroughly before submitting this pull request.
[ x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[ x] I have commented my code, particularly in hard-to-understand areas.

Additional context:
[Include any additional information or context that might be helpful for reviewers.]

In your PR, There have some issue check it once .

@arghadipmanna101 The issue is resolved. Pls add relevant gssoc labels and merge this PR. Thank you.

Issue 👍


[Advice] Development workflow with keycloak-config-cli

Hi,
I'm new to keycloak and keycloak-config-cli and I'm trying to understand how to use this cli in my development cycle.
Taking moped.json as example, how this file was could be generated?
The moped realm was exported manually from keycloak through "Partial Export" feature on keycloak admin console / kc.sh export using command line?
Considering docs on README,

The config files are based on the keycloak export files. You can use them to re-import your settings. But keep your files as small as possible. Remove all UUIDs and all stuff which is default set by keycloak.

After manual realm export, should I manually sanitize exported json removing all uuuid fields and all other general/default configs that I don't want to be part of import process?
Thanks in advance

Hi @ederparaiso ,
basically you can start with the provided example if you have a green field approach.
If you already have bootstrapped keycloak instances just start with them and export the needed data.
You can also have a look on the generate-export-realm.sh in contrib/scripts folder of this git repo.
Unfortunately we have no tool that automates the sanitization.
Best regards

Thanks for your attention @st3v0rr ! I'll check this script and define the best approach to my needs.

Where can we find documentation about the "all stuff" in Remove all UUIDs and all stuff which is default set by keycloak.


the fixture repository directory is not create when using fixture new

The fixtup new command fails when the fixture repository does not exist. I encountered the problem when I copied the fixtup.yml file from another project.
When reading the settings from python manifest, if the directory for fixture repostiory is missing, we will create it.

fix in https://github.com/FabienArcellier/fixtup/commit/f3b070c2c333e5ef2866eced7c4798046fa026f3


Add receive/transmit hooks

Problem
To allow the extension of the Sync module with e.g., Reliable messaging, there need to be defined hooks/callbacks. We can use them to transform behavior (e.g., store sent messages in buffer, move client tracker, send acknowledge messages to client, etc.).
Implementation

[x] Add ActionCable like callbacks to Sync (like subscribed, unsubscribed).
[x] Add a chain of responsibility implementation for extensions (e.g., Reliable for Sync)

Taken care of in #17

Taken care of in #17


Replaced rust-crypto and rustc-serialize dependencies

rust-crypto seems to be abandoned and crates from RustCrypto offer a smaller footprint, plus they are written in completely pure Rust.
rustc-serialize deprecated and can be easily replaced by rustc-hex crate. (or by hex, but it will require more changes)
BTW is there a particular reason for creating a separate crate and not sending a PR to the @avacariu's repository?
UPD: Ah, I found an answer to my question. Maybe he could grant you an access to the oath crate or even transfer the repository?

Hi, @newpavlov !
Thanks for contributing. So, step by step.
Positive changes:

Deprecated dependency is replaced by a fresh one - rustc-hex. As for me, both "hex" and "rustc-hex" are OK, their code is almost identical.
Removed time crate. That is a great idea, I didn't know that it is possible to use time from std.
Make totp* functions generic. It looks fine.
Negative:
Instead of 1 crypto library you require 4 different crates. It is inconsistent, as for me. I know, that current one is rather abandoned, but it is consistent and works.
Documentation is not updated. You've changed API, so keep function description up to date :)

So, I will merge this change, if you:

Update docs
Revert crypto crate back to "rust-crypto" or use another fresh and alive single crypto crate(ring?)

P.S. Yes, I also don't like the decision to fork. Unfortunately, crates.io will keep oath2 crate forever. Publishing there is a one way road.

Instead of 1 crypto library you require 4 different crates. It is inconsistent, as for me. I know, that current one is rather abandoned, but it is consistent and works.

All those crates are part of the same project. The only difference between separate crates approach and one library one is that it does not require to pull whole crypto blob for just three HMACs. It has a positive impact on the compilation times and on resulting binary size (quite small, but still), as you pay only for that you use. And thanks to cargo this approach is quite practical. So honestly I don't understand of what kind of "inconsistency" are you talking about. If you still want "one crate", then I could change dependency to crypto-hashes meta-crate, which re-exports those crates and several others, not used by your crate, so it will save several lines in the Cargo.toml, but at the cost of the wasted bandwidth and compilation time.
I am ready to update docs, but not to revert back to to rust-crypto or rewrite it using other library.
As for fork, if you get oath ownership you can simply yank all published versions and add to description something like "use oath crate instead", this way you will be able to clearly indicate to users what they should not look deeper into oath2, thus saving time for them.

OK, you are right. Let it be RustCrypto.
Update, please, docs and readme.

Nice!
I've updated docs (it was only one public function though and from_hex() corrections) and bumped minor version in the Cargo.toml.

@crypto-universe if you open a new PR, and @newpavlov thinks it looks OK, I'll merge it and publish it to crates.io.

@avacariu that would be great. I can abandon this crate and put a reference to your, if you keep it up to date. There is one thing - you'll need to change all links in readme and Cargo.toml, because there are references to my travis, docs.rs and so on.

Merged. Thanks everyone for contribution!


Shuttle Cam

Have cameras recording the shuttle to allow for easy remote operation. This is part of larger camera service but this epic focus on the need for the shuttle demo.

Have one or more cameras connected their own compute and be able to stream data to the cloud/backed.
Multiple browser should be able to see the streams at the same time. There may be multiple steams shown at the same time.

Design Tasks

[x] Complete experiments. #29
[x] Draw and design Shuttle Cam. #41

Development Tasks

[ ] Authentication and Authorization #15

More tasks will come as design gets completed.

Did almost work.

No longer relevant.


Enable 'fail-build' for check-libraries action

Problem
We are shaning shared libraries without proper LIBPATCH bumping.
As a result changes are not published to charmhub.io store and not shared properly, it affects further libs update issues:
Exampl:

Library charms.mongodb.v0.helpers has local changes, cannot be updated.
Library charms.mongodb.v0.mongodb_backups has local changes, cannot be updated.
Library charms.mongodb.v0.mongodb_vm_legacy_provider has local changes, cannot be updated.

Solution
The GitHub action check-libraries should notice such cases are report Author about forgotten LIBPATCH bump.
Testing
Testing here in this PR. It should fail until this PR comment is addressed merged.
Release Notes
Not necessary.

Unfortunately, the option fail-build is not working as we want. Requested improvement for the action.


Identity columns

This PR documents new support for PostgreSQL-like identity columns. The PR also moves the "Column qualification" section from the ADD COLUMN page to the CREATE TABLE page, as more column qualifications are fully-supported in CREATE TABLE statements than in ADD COLUMN statements (e.g., Identity columns).
Fixes https://github.com/cockroachdb/docs/issues/11417.
Fixes https://github.com/cockroachdb/docs/issues/11451.

This change is

Should this feature be added to https://www.cockroachlabs.com/docs/v21.2/sql-feature-support.html#miscellaneous?

Should this feature be added to https://www.cockroachlabs.com/docs/v21.2/sql-feature-support.html#miscellaneous?

Probably. Good point. I think I'm going to open a separate PR for all of the feature support additions though, since there will be more on my end than just this one.


Inconsistent behavior when undoing animation bezier movements upon selection of different animations

Tested versions

Reproducible in 4.2.1 and master (9425535)

System information
Windows 10
Issue description
When manipulating bezier keys and then selecting a different Animation, or a different AnimationPlayer, bad things are bound to happen on undo and redo, due to the animation_bezier_editor referencing the currently selected animation in the undo methods.
Steps to reproduce

Select AnimationPlayer, go into bezier view and move a key
Select a different AnimationPlayer
Undo (observe an index out of bounds error in the output)
Redo (observe that the key is now transferred to the currently selected animation)

Minimal reproduction project (MRP)
AnimationTestProject2.zip

damn, that was fast :D
I am working on a fix for this.


Don't rearrange self connections in GraphEdit

Fixes #63501
While iterating through all nodes to get the to rearrange nodes before actually rearranging, ignore the connections where the to and from StringNames are the same (=self connections). Other rearranging still works the same after.

Actual problem was cycles in the graph not self connections so closing for now


Add Vault signers: UI chnage.

Found this process confusing. There is no indication that I can choose from existing signer or add an entirely new one. We need to have a distinction. Choose or add new.

https://xd.adobe.com/view/f1543c84-c25a-4ad6-81ca-1e0c540e956e-a407/screen/71a0cb48-a6b5-42fa-8f89-d23e5e1b38c3/
distinction exists in the current design, follow the design provided.

Verified this issue on keeper app v 1.1.12(303)


write ogg file with opus chunks

Hi!
I have stream of opus chunks.
I know that is 1 channel 24000 sample rate.
How to write file with node-ogg?

Don't suppose you ever figured this out?
Going through the same issue
https://github.com/discordjs/opus/issues/40


Update to MkDocs 1.04 and enable Google Analytics.

Need to update the documentation to MkDocs 1.04 similar to other CDSS documentation, and enable Google Analytics so that documentation use can be tracked.

I updated the documentation to use MkDocs 1.0.4 and added Google Analytics to the configuration file.  Close the issue.


[Bugfix] Scene Dataset Attributes Managers access enforcement

Motivation and Context
This PR makes all scene dataset attributes managers accessed by const refs.  This required a slight change to how the current active dataset is queried - now there will never be an occasion for a null ptr return for any of the managers - if somehow a non-existent dataset has become active (which is not currently possible) then the default dataset will be called upon to provide the managers.
The scene dataset attributes also has been changed so that its destructor will kill its various managers.  This is so that any persistent external references to the managers will give an error, and not leak, if the dataset they reference has been removed, addressing an extant possible bug in the scene dataset removal process.
Ideally these managers would be accessed by weak pointers, which would address this issue more politely, but such support would necessitate a substantial refactor of how the managers work; this can be addressed at a later date.

How Has This Been Tested
C++ and python tests pass

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have completed my CLA (see CONTRIBUTING)
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

override strictly implies virtual.
On Wed, May 26, 2021 at 3:11 PM John Turner @.***>
wrote:

@.**** commented on this pull request.
In src/esp/metadata/attributes/AttributesBase.h
https://github.com/facebookresearch/habitat-sim/pull/1272#discussion_r640050518
:

@@ -28,7 +28,7 @@ class AbstractAttributes : public esp::core::AbstractFileBasedManagedObject,
AbstractAttributes::setHandle(handle);
}

~AbstractAttributes() override = default;

virtual ~AbstractAttributes() override = default;

Is it? will inheriting destructors treat it as virtual? I was unclear.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/facebookresearch/habitat-sim/pull/1272#discussion_r640050518,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAPVMX7YU56CGSDRY7AP2WTTPVBWDANCNFSM45SUUNGQ
.


refactor: remove react-router-dom to next

Change all the react-router-dom to use next

@heronlancellot can I work on this one?

hey @diegosano  ! assigned to you

Closed by #168