Bad GUESS

This pickle file contains a dataframe with a column of numerical data, run_time, which is ignored.
In [19]: from bdbcontrib import Population
from cPickle import load
df = load(open('/tmp/bad-guess.txt'))
p = Population(name='bad_guess', df=df, session_capture_name=False)
v = p.quick_describe_variables()
print 'run_time variable type:', v.stattype[v.name == 'run_time'].values
print
print v

In [24]: run_time variable type: ['ignored']

In [26]:            name   stattype unique   top  freq     mean      std      min  \
0    start_time  numerical   None  None  None   51.246  28.7207        1
1  per_sim_time  numerical   None  None  None   51.956   28.178        1
2      run_time    ignored   None  None  None  18231.5  32962.8  44.2664
3         dummy  numerical   None  None  None    499.5  288.819        0

       25%      50%      75%     max count  hist
0       26     52.5       76     100  1000  None
1    28.75       52       77     100  1000  None
2  3776.48  8708.79  20834.6  535208  1000  None
3   249.75    499.5   749.25     999  1000  None

In [27]: set(df.run_time.map(type))
Out[27]: {numpy.float64}

In [28]: df.run_time.isnull().any()
Out[28]: False

In [29]: [m(df.run_time.values) for m in [min, max]]
Out[29]: [44.266372827937154,<PHONE_NUMBER>9714804]

I think it would be valuable for Population.init to give a way to specify the column types.

I forgot to mention, when this data is dumped to a csv file using numpy.savetxt, GUESS gets the column type right.
Unfortunately, I was doing this in a python notebook, so I don't have a record of the specific commands I used for that.

Rather than specifying column stattypes, I think population.init should be able take a metamodel initializer generally, to override the crosscat default. Haven't had time to look into the above yet.

It would also be good to have ways to specify the metamodel, and an easy way to turn off the wizard-mode failure.
Frorm some code I wrote recently:
from bdbcontrib import Population
from pandas import DataFrame

# Take a 1,000 row subsample
rng = RandomState(0)
choices = rng.choice(np.arange(0, len(simulations)),
                     size=1000, replace=False)
subsample = simulations.ix[choices]

p = Population('runtime_simulations', df=subsample, session_capture_name=False);

# Sadly, GUESS gets the column type of run_time wrong for some reason.
# So we have to create the generator manually to specify the type.
p.q('DROP GENERATOR "runtime_simulations_cc"')
p.q('CREATE GENERATOR "runtime_simulations_cc" '
    'FOR "runtime_simulations" '
    'USING crosscat( GUESS(*), run_time NUMERICAL)')
p.quick_describe_variables()['name stattype'.split()]

# Also, good to get this working with multiprocessing
from crosscat.MultiprocessingEngine import MultiprocessingEngine as MPE
from bayeslite.metamodels.crosscat import CrosscatMetamodel
crosscat = CrosscatMetamodel(MPE())
# Since bdb is already registered, do the registration manually
# From bayeslite.metamodel.bayesdb_register_metamodel
from bayeslite.metamodel import builtin_metamodels, builtin_metamodel_names
# Don't know whether it's necessary to change the builtin_metamodel* data.
# Don't know what it's for.
assert len(builtin_metamodels) == len(builtin_metamodel_names) == 1
builtin_metamodels[:] = [crosscat]
assert builtin_metamodel_names == {crosscat.name()}
crosscat.register(p.bdb)
p.bdb.metamodels[crosscat.name()] = crosscat

# Unfortunately, we still have to shut up bayesdb about wizard mode, even using population
import os
os.environ['BAYESDB_DISABLE_VERSION_CHECK'] = 'True'
os.environ['BAYESDB_WIZARD_MODE'] = 'True'

Wizard mode is very much intentional. Please see examples/Index.ipynb for an explanation.
The way you have seems pretty easy.

That said, thanks for the init file you're using! That does help me see what would be nice to make easy here. But that does also seem like a separate issue from whatever is wrong with GUESS. Scheduling both...

No problem.  Glad it's helpful.

Population.init is no longer in use (per deprecation of bdbcontrib).


Configs about VehicheID dataset

Hi, Thanks for your nice work.
Can you provide the configs of the vehiche reid datasets.

We will upload vehicle reid training config next week.

@CHENGY12 Hi, we have added config file, please check the model zoo.

Thank you very much for your rapid reply. It is very helpful for our works.


Flowkey Links no longer available

Hey,
I have been a casual user of your flowkey downloader - quite a nice idea and very useful as after the initial few rounds of practicing a new song with the video I find it quite annoying to have the screen moving around all the time. All I want is the static notes then... which your program helped solve :)
Only that flowkey seems to have changed the url / way the notes are shown...
Is there a new way you can make your tool work?
Christian

Brilliant - worked like a charm and I learned something on top. Your tool is great, a real help! Thanks!
Von meinem iPad gesendet

Am 13.12.2022 um 10:54 schrieb Matthias Lienhard @.***>:

Yes, flowkey made it harder to get the url of the underlying images, simply right click does not work anymore. It should still work when looking in the browsers cache. With google-chrome browser, you find it by clicking on the three dots in the top right -> more tools -> developer tools, then on the "sources" tab. Here you should find flowkeycdn.com with a folder /sheets, with all the songs from the last session. Click right on the first image (0.png) and then 'copy link location'.
There is probably similar ways in other browsers.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.

Added this to the readme.


Updating changelog entry for Stream enhancement properties

Updates the Stream changelog to log the new player enhancements feature.

@dcpena Would you mind taking a look 🙏


tests: Expand PSO abbreviation for readability

Continuation of commit d793351
Expand abbreviations to improve readability:
PSO -> pipeline state object
w/o -> without
Change-Id: Ia0281b4d2dc00541a70bc48710daa0ffd89d9117

Looks good on our end - thanks Mike.

Looks good to me too


[BUG]: Many controls lack screen reader labels

Pull Request Type

[x] ✨ feat
[x] 🐛 fix
[ ] ♻ refactor
[ ] 💄 style
[ ] 🔨 chore
[ ] 📝 docs

Relevant Issues
resolves #1022
What is in this change?
Invisible changes to the UI that offer considerable improvements to the accessibility of the application for screen reader users. Most of the buttons are now spoken properly, and related controls have been grouped to make it possible to quickly reach the workspace and threads lists.
Additional Information
Full list of changes:

Label the back button on the onboarding screen
Label the continue button on the onboarding screen
Label the social links, which are currently only represented by images
Label some of the navigation items (general appearance, settings button)
Indicate the currently selected workspace to screen readers, and indicate the relationship as a list container
Indicate the currently selected thread to screen readers, and indicate the relationship as a list container
Label copy and thumb up/down buttons in a chat
Label stop generating button

Developer Validations

[x] I ran yarn lint from the root of the repo & committed changes
[x] Relevant documentation has been updated
[x] I have tested my code functionality
[x] Docker build succeeds locally

A great start to aria labeling, will def need to do more of this across the app.


Implement MFA authentication APIs

🔧 Changes
Adds support for the Challenge and various Verify* APIs supported by the authentication API.
This does not add support for using the Authentication APIs as it was determined that the existing support on the management client is sufficient.
📚 References

Close #316
🔬 Testing

📝 Checklist

[x] All new/changed/fixed functionality is covered by tests (or N/A)
[x] I have added documentation for all new/changed functionality (or N/A)

Codecov Report
Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (1f73dd6) 95.09% compared to head (b5c2f29) 94.96%.

Files
Patch %
Lines

authentication/mfa.go
80.43%
12 Missing and 6 partials :warning:

authentication/authentication.go
87.50%
8 Missing and 4 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
- Coverage   95.09%   94.96%   -0.13%
==========================================
  Files          46       47       +1
  Lines        8984     9078      +94
==========================================
+ Hits         8543     8621      +78
- Misses        336      346      +10
- Partials      105      111       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Asian Option

Hi team,
Is there any plan for the implementation of asian option computation? I would like to contribute if there is anything related in you plan.
I can also contribute to other issues if you have one.
Xiaozhi

Hi Xiaozhi, I don't think anyone is working on that atm but it would be cool to have a pricing formula for Asian options at least for the Black-Scholes case.
There are more potential projects available :-)

Hi Xiaozhi,
Are you working on this one? If so, could you please clarify what you are implementing.
Thanks,
Cyril


[chart/redis-ha][BUG] Separate redis installs highjack each other

Describe the bug
I've hit this several times, and I'm not quite sure if it's a network issue, or something in code. I have many redis-ha installs in my k8s cluster (50+) and on the odd occasion, one of the redis-sentinels from a separate cluster takes 'ownership' of one of the slaves in the other cluster, causing both sentinels to fight between them.
Cluster 1 (whose slave is fighting)
redis1-redis                            ClusterIP   None             <none>        6379/TCP,26379/TCP,9121/TCP   4d22h
redis1-redis-announce-0                 ClusterIP   <IP_ADDRESS>   <none>        6379/TCP,26379/TCP,9121/TCP   4d22h
redis1-redis-announce-1                 ClusterIP   <IP_ADDRESS>   <none>        6379/TCP,26379/TCP,9121/TCP   4d22h
redis1-redis-announce-2                 ClusterIP   <IP_ADDRESS>     <none>        6379/TCP,26379/TCP,9121/TCP   4d22h

redis2-redis                             ClusterIP   None             <none>        6379/TCP,26379/TCP,9121/TCP   4d22h
redis2-redis-announce-0                  ClusterIP   <IP_ADDRESS>   <none>        6379/TCP,26379/TCP,9121/TCP   4d22h
redis2-redis-announce-1                  ClusterIP   <IP_ADDRESS>    <none>        6379/TCP,26379/TCP,9121/TCP   4d22h
redis2-redis-announce-2                  ClusterIP   <IP_ADDRESS>   <none>        6379/TCP,26379/TCP,9121/TCP   4d22h

Cluster 2 Sentinel Config
sentinel known-replica redis2 <IP_ADDRESS> 6379
sentinel current-epoch 12
sentinel known-sentinel redis2 <IP_ADDRESS> 26379 00e29ddeaf2c2acc165fd1e2ea0e1699b798cc7f
sentinel known-sentinel redis2 <IP_ADDRESS> 26379 4fd0e78c284fced4951c66ec6eb3b4fec19a9712
sentinel known-replica redis2 <IP_ADDRESS> 6379
sentinel known-replica redis2 <IP_ADDRESS> 6379
sentinel known-replica redis2 <IP_ADDRESS> 6379```

Note the <IP_ADDRESS> IP (from Cluster 1) in the known replicas.
Then in the logs of redis1 that is trying to re-start/sync
1:S 17 Nov 2021 16:47:56.868 * REPLICAOF <IP_ADDRESS>:6379 enabled (user request from 'id=75 addr=<IP_ADDRESS>:39708 laddr=<IP_ADDRESS>:6379 fd=18 name=sentinel-4fd0e78c-cmd age=17 idle=0 flags=x db=0 sub=0 psub=0 multi=4 qbuf=201 qbuf-free=40753 argv-mem=4 obl=45 oll=0 omem=0 tot-mem=61468 events=r cmd=exec user=default redir=-1')
1:S 17 Nov 2021 16:47:56.870 # CONFIG REWRITE executed with success.
1:S 17 Nov 2021 16:47:56.870 * Non blocking connect for SYNC fired the event.
1:S 17 Nov 2021 16:47:56.871 * Master replied to PING, replication can continue...
1:S 17 Nov 2021 16:47:56.873 * Trying a partial resynchronization (request 79a75e7d43ed1715b06b30bd44bdb1d993d82802:4566852076).
1:S 17 Nov 2021 16:48:01.870 * Full resync from master: 9d88731c84104089ae32ab8609fbc7dce05881c7:2760659548
1:S 17 Nov 2021 16:48:01.870 * Discarding previously cached master state.
1:S 17 Nov 2021 16:48:01.875 * MASTER <-> REPLICA sync: receiving streamed RDB from master with EOF to disk
1:S 17 Nov 2021 16:48:02.533 * MASTER <-> REPLICA sync: Flushing old data
1:S 17 Nov 2021 16:48:02.656 * MASTER <-> REPLICA sync: Loading DB in memory
1:S 17 Nov 2021 16:48:02.666 * Loading RDB produced by version 6.2.5
1:S 17 Nov 2021 16:48:02.666 * RDB age 1 seconds
1:S 17 Nov 2021 16:48:02.666 * RDB memory usage when created 72.48 Mb
1:S 17 Nov 2021 16:48:02.899 * MASTER <-> REPLICA sync: Finished with success
1:M 17 Nov 2021 16:48:13.876 # Connection with master lost.
1:M 17 Nov 2021 16:48:13.876 * Caching the disconnected master state.
1:S 17 Nov 2021 16:48:13.876 * Connecting to MASTER <IP_ADDRESS>:6379
1:S 17 Nov 2021 16:48:13.876 * MASTER <-> REPLICA sync started
1:S 17 Nov 2021 16:48:13.876 * REPLICAOF <IP_ADDRESS>:6379 enabled (user request from 'id=92 addr=<IP_ADDRESS>:57612 laddr=<IP_ADDRESS>:6379 fd=16 name=sentinel-1ac17110-cmd age=17 idle=0 flags=x db=0 sub=0 psub=0 multi=4 qbuf=200 qbuf-free=40754 argv-mem=4 obl=45 oll=0 omem=0 tot-mem=61468 events=r cmd=exec user=default redir=-1')
1:S 17 Nov 2021 16:48:13.878 # CONFIG REWRITE executed with success.
1:S 17 Nov 2021 16:48:13.878 * Non blocking connect for SYNC fired the event.
1:S 17 Nov 2021 16:48:13.879 * Master replied to PING, replication can continue...
1:S 17 Nov 2021 16:48:13.879 * Trying a partial resynchronization (request 9d88731c84104089ae32ab8609fbc7dce05881c7:2760662980).
1:S 17 Nov 2021 16:48:18.961 * Full resync from master: 79a75e7d43ed1715b06b30bd44bdb1d993d82802:4566858988
1:S 17 Nov 2021 16:48:18.961 * Discarding previously cached master state.
1:S 17 Nov 2021 16:48:18.968 * MASTER <-> REPLICA sync: receiving streamed RDB from master with EOF to disk
1:S 17 Nov 2021 16:48:20.262 * MASTER <-> REPLICA sync: Flushing old data
1:S 17 Nov 2021 16:48:20.320 * MASTER <-> REPLICA sync: Loading DB in memory
1:S 17 Nov 2021 16:48:20.325 * Loading RDB produced by version 6.2.5
1:S 17 Nov 2021 16:48:20.325 * RDB age 2 seconds
1:S 17 Nov 2021 16:48:20.325 * RDB memory usage when created 132.51 Mb
1:S 17 Nov 2021 16:48:20.791 * MASTER <-> REPLICA sync: Finished with success
1:M 17 Nov 2021 16:48:23.979 # Connection with master lost.
1:M 17 Nov 2021 16:48:23.979 * Caching the disconnected master state.
1:S 17 Nov 2021 16:48:23.979 * Connecting to MASTER <IP_ADDRESS>:6379
1:S 17 Nov 2021 16:48:23.979 * MASTER <-> REPLICA sync started
1:S 17 Nov 2021 16:48:23.979 * REPLICAOF <IP_ADDRESS>:6379 enabled (user request from 'id=102 addr=<IP_ADDRESS>:46660 laddr=<IP_ADDRESS>:6379 fd=9 name=sentinel-00e29dde-cmd age=10 idle=0 flags=x db=0 sub=0 psub=0 multi=4 qbuf=201 qbuf-free=40753 argv-mem=4 obl=45 oll=0 omem=0 tot-mem=61468 events=r cmd=exec user=default redir=-1')
1:S 17 Nov 2021 16:48:23.982 # CONFIG REWRITE executed with success.
1:S 17 Nov 2021 16:48:23.982 * Non blocking connect for SYNC fired the event.
1:S 17 Nov 2021 16:48:23.983 * Master replied to PING, replication can continue...
1:S 17 Nov 2021 16:48:23.985 * Trying a partial resynchronization (request 79a75e7d43ed1715b06b30bd44bdb1d993d82802:4566860568).

1:S 17 Nov 2021 16:48:13.876 * REPLICAOF <IP_ADDRESS>:6379 enabled (user request from 'id=92 addr=<IP_ADDRESS>:57612 laddr=<IP_ADDRESS>:6379 fd=16 name=sentinel-1ac17110-cmd age=17 idle=0 flags=x db=0 sub=0 psub=0 multi=4 qbuf=200 qbuf-free=40754 argv-mem=4 obl=45 oll=0 omem=0 tot-mem=61468 events=r cmd=exec user=default redir=-1')

1:S 17 Nov 2021 16:48:23.979 * REPLICAOF <IP_ADDRESS>:6379 enabled (user request from 'id=102 addr=<IP_ADDRESS>:46660 laddr=<IP_ADDRESS>:6379 fd=9 name=sentinel-00e29dde-cmd age=10 idle=0 flags=x db=0 sub=0 psub=0 multi=4 qbuf=201 qbuf-free=40753 argv-mem=4 obl=45 oll=0 omem=0 tot-mem=61468 events=r cmd=exec user=default redir=-1')

These two line in particular are the sentinels fighting between the redis pods.

@aleclerc-sonrai Do you have your separated values you can provide?
This looks to me like the cluster names are the same in your values, and as a result the Redis side is actually finding them.
Can you also do a kubectl get endpoints and check if all the pods are being picked up by the redisX-redis services?

I'm having this same problem.

This looks to me like the cluster names are the same in your values

By "cluster name" do you mean master set? Yes, both redis installations use the default master set "mymaster". But why should that matter? The IPs would be different for each installation, so how are they finding each other?

kubectl get endpoints and check if all the pods are being picked up

Yes, it looks like somehow pods from both installations are being added to both endpoints.

Aha, I see, it's because the selector for the main services (or more specifically, the "app" label) isn't reacting to fullnameOverride, which is the value I changed to differ the installations. 🤔

@DandyDeveloper thoughts on my PR?

@jimethn Correct. It's because of the selector & headless service. I'll review your PR in a bit.

Fixed in #197


S3 compatible blob storage configuration

Description
When trying the self-hosted deployment of foxgrove based on the documentation provided, the S3 compatible storage solution for inbox-listener and stream-service does not work

Version: CHART primary-site-0.0.52; APP VERSION: 79aed2aaac91cb942467185b7c1f74454cb0fefe
Platform: kubernetes v1.27

Steps To Reproduce
As in the documentation, using the following as values.yaml
globals:
  lake:
    storageProvider: s3_compatible
    bucketName: foxglove-lake
  inbox:
    storageProvider: s3_compatible
    bucketName: foxglove-inbox

Then installing with
helm repo add foxglove https://helm-charts.foxglove.dev
helm repo update
helm upgrade --install foxglove-primary-site foxglove/primary-site \
    --values ./values.yaml  \
    --namespace foxglove \
    --create-namespace

The PODs are failing with:

{"message":"Failed to initialize inbox store: S3CompatibleServiceURL must be configured","severity":"FATAL","timestamp":""}

Expected Behavior
A working system with self-storage in own cluster.

The following gaps in documentation:

How to provide serviceUrl or S3CompatibleServiceURL for s3_compatible?
How to provide the secrets for the s3_compatible

Thanks for the pointer. I guess I got confused on the references to "cloud-credentials".  It works now, with another issues

{"message":"Failed to detect org: forbidden","severity":"FATAL", ...}

I close the issue, but if you have any pointer. Let me know


May you add an Block excluding feature for layers?

So basically that should just give the opportunity to remove a certain block from the rendering.
Such as water.

Add "minecraft:water" and "minecraft:flowing_water" to the "Extra Air Blocks" option under "General" in the config.  Then relog if you're on a server. (You might have to on singleplayer too, I haven't tried)  Schematics will then show properly underwater.


feat!: don't expose OpenSsl ffi class

This PR reduces the API surface of the library by reverting the exposure of the OpenSsl class (which has become obsolete due to #24).

Codecov Report
Base: 23.56% // Head: 23.56% // No change to project coverage :thumbsup:

Coverage data is based on head (8a81fe4) compared to base (f1e82b0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   23.56%   23.56%
=======================================
  Files           7        7
  Lines         297      297
=======================================
  Hits           70       70
  Misses        227      227

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Regression after fixing #3

After adding multiwindow support in c56dfc241f6cb9f09b5344d25a1b86c9832cd5c7 pressing tab has undesired secondary effects.
In integrated editor mode, it will tab out of the script editor entirely.
In windowed editor mode, it will insert a tab character.

Closing as solved


Add bleeding, cursed, silenced, surprised, and transformed to conditions

We already have diseased as a condition even though it technically isn't one so that it shows up nicely under Condition Immunities for paladins and monks. So we might as well add some of the other non-RAW conditions, I think. Probably controversial.

Bleeding: Perhaps useful considering there's blood magic that is only able to target creatures with blood.
Cursed: I couldn't find a creature that is immune against curses, but it might be possible, not sure.
Silenced: If you can be immune against blinded and deafened, I imagine you could possibly be immune against being silenced.
Surprised: Some creatures are immune to being surprised unless incapacitated (e.g. Canoloth). There's also the Helm of Awareness (Artificer Infusion).
Transformed: Some creatures are immune to any spell or effect that would alter its form (e.g. Clay Golem).

I think we actually want to remove diseased from conditions, rather than go the other way. It's got a special-case exception to omit it from the character sheet, for example.

I think removing Diseased would be even more controversial.
We could introduce system.traits.ailments or some such, if a split is really needed.

If it's the simplest way to implement some of these features like Immutable Form, then that's fine. I can see we have a raw flag in this PR which would probably have been my only real concern.

Might be a bit nicer to invert raw, add special or something that is only for conditions that are not official conditions rather than tagging every official condition. Also not sure how clear raw is without the JSDocs, given it isn't clear it is an acronym.

Yeah, I think I agree that marking the non-official ones is preferable. Maybe we can flag them as pseudo: true? It's reasonably terse and things like 'surprised' are sometimes referred to as 'pseudo conditions' because they behave similarly without actually being in the conditions appendix.


Add support for S3 SSE using own KMS key

Brief description of the changes
Huge thanks for the brilliant library! 💯
I found that Fine Uploader supports uploading to S3 with SSE. That's great! But it lacks some not so popular feature -  encryption with custom KMS Keys  which I need.
Fortunately, it was pretty straightforward to patch the lib for my needs.
But this is not a proper long-term solution. So that's why I propose this PR to raise a discussion about adding this feature to Fine Uploader. Treat this PR as Proof of Concept as it was done in "Search & Replace" mode and doesn't pretend to be merged.
What browsers and operating systems have you tested these changes on?
Chrome 57.0.2987.110 (64-bit)
Have you written unit tests? If not, explain why.
I'm not sure you'll even decide to include this feature into Fine Uploader
But I added some unit tests (which fail for some reason)
Results
So I did a simple test with small (10KB) and big (53MB) file. And looks like it was encrypted properly:

What do you think @rnicholus  ?

Thank you for your work on this, and for bringing this to my attention. I find that I learn more about S3 through user-contributed issues and PRs in this project than anywhere else. This is interesting, and appears to be a low-risk addition, so I don't see an immediate reason to reject this outright. As you said, the tests are failing though. One other note, SSE w/ KMS is only supported when using v4 signatures, so that would require some changes to your PR I believe.
Currently, my priority is to release Fine Uploader 5.14.2 once #1802 is solved, which is needed to push out the first stable release of React Fine Uploader. I'm also about to start a new job, and I'm the only consistent maintainer of this large suite of projects. So, it may be a while before I can take some time to code review and offer assistance here. But here's what I think is needed to push this forward:

Updates to reflect that this feature is only supported w/ v4 signatures.
Passing tests.
Updates to the documentation (in this case, the S3 feature page + options).
A full code review by me, which may result in more requested changes.

Whoa!
Cool solution @nadeesha!


How can i get international phone number?

I am about this future:
getNumber
Get the current number in the given format (defaults to E.164 standard). The different formats are available in the enum intlTelInputUtils.numberFormat - taken from here. Requires the utilsScript option. Note that even if nationalMode is enabled, this can still return a full international number.
https://github.com/Bluefieldscom/intl-tel-input#public-methods

I made Pull request #14
Can you merge it?

Merged. Thank you for your contribution! :+1:


Add centos support for minikube install

Currently, centos is not supported in minikube install scripts. This PR completes the missing part.
Fixes: #8239

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: kimikowang
If they are not already assigned, you can assign the PR to them by writing /assign @kimikowang in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/e2e/local/minikube/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @m1093782566. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/assign @hklai @costinm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/e2e/local/minikube/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@m1093782566: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fa928de7ca14e22b1f19ac0bec53b2b8064fdf55
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@m1093782566: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fa928de7ca14e22b1f19ac0bec53b2b8064fdf55
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
fa928de7ca14e22b1f19ac0bec53b2b8064fdf55
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@m1093782566: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
fa928de7ca14e22b1f19ac0bec53b2b8064fdf55
link
/test e2e-mixer-no_auth

prow/istio-unit-tests.sh
fa928de7ca14e22b1f19ac0bec53b2b8064fdf55
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hklai
Could you help review this PR if you have chance?

@m1093782566: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
c2606d9e7941e4d23573ac2fe52ff72475879ede
link
/test istio-unit-tests

prow/istio-presubmit.sh
9681cf86fb43411e2890eb9cdaf6cd93030894c2
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hklai
I just pushed an update since #8521 went in :)

@m1093782566: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
e2bc672d15096a111f502a478a5966da3c7f8d88
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@m1093782566: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
e2bc672d15096a111f502a478a5966da3c7f8d88
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
e2bc672d15096a111f502a478a5966da3c7f8d88
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@m1093782566: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
e2bc672d15096a111f502a478a5966da3c7f8d88
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
e2bc672d15096a111f502a478a5966da3c7f8d88
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
e2bc672d15096a111f502a478a5966da3c7f8d88
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@m1093782566: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
e2bc672d15096a111f502a478a5966da3c7f8d88
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
e2bc672d15096a111f502a478a5966da3c7f8d88
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
e2bc672d15096a111f502a478a5966da3c7f8d88
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
e2bc672d15096a111f502a478a5966da3c7f8d88
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@m1093782566: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
e2bc672d15096a111f502a478a5966da3c7f8d88
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
e2bc672d15096a111f502a478a5966da3c7f8d88
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
e2bc672d15096a111f502a478a5966da3c7f8d88
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
e2bc672d15096a111f502a478a5966da3c7f8d88
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
e2bc672d15096a111f502a478a5966da3c7f8d88
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@m1093782566: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
e2bc672d15096a111f502a478a5966da3c7f8d88
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
e2bc672d15096a111f502a478a5966da3c7f8d88
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
e2bc672d15096a111f502a478a5966da3c7f8d88
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
e2bc672d15096a111f502a478a5966da3c7f8d88
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
e2bc672d15096a111f502a478a5966da3c7f8d88
link
/test e2e-simple

prow/istio-pilot-multicluster-e2e.sh
e2bc672d15096a111f502a478a5966da3c7f8d88
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@m1093782566: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
e2bc672d15096a111f502a478a5966da3c7f8d88
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
e2bc672d15096a111f502a478a5966da3c7f8d88
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
e2bc672d15096a111f502a478a5966da3c7f8d88
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
e2bc672d15096a111f502a478a5966da3c7f8d88
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
e2bc672d15096a111f502a478a5966da3c7f8d88
link
/test e2e-simple

prow/istio-pilot-multicluster-e2e.sh
e2bc672d15096a111f502a478a5966da3c7f8d88
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
cd0dc7ff719e4a152ef05b04714dd305a750fefd
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm
@sdake your recommendation (i.e. adding opt-in check) is being done in a follow up PR. https://github.com/istio/istio/pull/8551. So I am going to approve this. Please let me know if you have any objection or concern.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hklai
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/e2e/local/OWNERS [hklai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@m1093782566: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
cd0dc7ff719e4a152ef05b04714dd305a750fefd
link
/test istio-unit-tests

prow/istio-pilot-multicluster-e2e.sh
cd0dc7ff719e4a152ef05b04714dd305a750fefd
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Fix migrated column on rule evaluations

After testing in staging, I found that the migration to set the migrated column did not work as expected. The intention was that any rows in rule_evaluations which have the same combination of rule instance ids and entity ids should be marked as migrated, as they refer to the same evaluations. This migration addresses this problem.
Tested against staging (with a rollback)
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:

[x] Bug fix (resolves an issue without affecting existing features)
[ ] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[x] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

coverage: 54.402%. remained the same
when pulling ca3c24a21933022977c08e5fa3c18bace0a53ed6 on fix-migrated-flag
into ff0f01bf5fda0c049cc67340dcb445da6db45bdc on main.


Build spring-boot-project thin jar?

Does the liberty maven plugin automatically produce a thin jar file when building a spring boot application and the pom.xml is configured with:
<installAppPackages>spring-boot-project</installAppPackages>
The built application is named:
thin-SpringBootTestApp.jar
Does this mean that SpringBootUtility is being called?
Running in debug mode certainly suggests it:

[INFO] (org.codehaus.mojo.pluginsupport.ant.AntHelper) CWWKM2001I: Invoke command is [/home/user/git/springboottest/springboot/SpringBootTestApp/target/liberty/wlp/bin/springBootUtility, thin, --sourceAppPath ...

could this then be used to create a multi layer docker image?

@mjwhale Yes, you are correct.

Closing since this was a question and not an issue.


Feature/new/halin restart button, back button, connect new API in result pages

restart button, back button, connect new API in result pages

정말 수고하셨습니다!


ROCm Support for Radeon Pro 5600M

I check the document and repo of ROCm (http://repo.radeon.com/rocm/apt/3.5/pool/main/m/)
It seems only support architecture gfx900 and gfx906 at this moment.
I check the hardware spec. and LLVM doc on https://llvm.org/docs/AMDGPUUsage.html, it shows
the new Radeon Pro 5600M's architecture should be gfx1011 with 40 CU.
May I know when will ROCm officially support new Radeon Pro 5600M?
Thanks and best regards,

Hi @strategist922
Thanks for reaching out.
Currently we are not supporting Radeon 5000 series with ROCm.
We have plans to support Radeon 6000 series with ROCm in near future.
Thank you.

@ROCmSupport wait, there are no plans for Radeon 5000 series, just 6000?

Hi @aliPMPAINT
Am not commenting about Radeon 5000 future plans because I do not have handy information.
We will definitely share the information in future if any.

Hey @ROCmSupport do we have that functionality now, cause I've got a Radeon RX5600M GPU and was wondering if I can use ROCM on that..??


provides information of type inferation

Clear and concise description of the problem
The current function provides only a type that is determined on running.
Information of type inferation might also be wanted by users.
Additional context
N/A

see: https://github.com/task4233/dl/pull/16#issuecomment-1079622785


Add unit tests

I took a brief look on the current code-base, and noticed that there're no unit tests!
Adding ones would help us better maintain this project in longer term.
Also, I'm happy to contribute here.
Please let me know if there's specific type/func to which you'd like to add tests.

I think starting at the build flow level is a good one by adding unit tests around a single step when artifacts are pulled out as well as tests around secret providers.


mcuboot: Booting an image flashed on top of a Hawkbit updated ones results in hard fault

Describe the bug
After hawkbit downloaded an image and performed a test update, if the device is reset after booted up that test update, for some reason MCUboot doesn't perform swap even though it should, as the image isn't confirmed.
Then if an image is flashed to the image-0 partition using a hw debugger (Jlink), the MCUboot would think that it needs to boot_complete_partial_swap. However, in boot_swap_image, the swap_size (copy_size) from boot_read_image_size is likely corrupted?

And caused it to hard fault while it finds the last sector in the primary slot that needs swapping in swap_run

I'm not sure if this is an expected behavior. To be able to boot an image again, full chip erase is required.

My board

STM32G0B1RE custom board

mcuboot - 64 kiB
image-0 - 416 kiB
Remaining 32 kiB - left blank

1 MiB external spi-nor flash

image-1 - 416 kiB
scratch - 140 kiB
Other partitions like storage, etc

gsm_ppp LTE modem

To Reproduce

Flash hawkbit sample and OTA upgrade to an image
After the OTA upgraded image is booted, flash an image on top using hardware flasher
Reset to boot the flashed image
See hard fault error

Expected behavior
I expect the bootloader to boot the flashed image.
Impact
Extra steps required to flash the device using a hardware flasher.
Environment (please complete the following information):

OS: Windows 10
Toolchain: GNUARMEMB
v2.6.0-1638-g0296d12675fd

@d3zd3z After few days of testing I've edited the title and narrowed the scope of the problem in the description

I'm not exactly sure I'd call it expected behavior, but it is unsurprising. The easiest fix is going to be either 1. erase the entire partition for the primary image slot before flashing the image with the hw tools, or 2. Pass --pad to imgtool.py (as well as --slot-size), which will fill out the entire image, overwriting whatever state is present.
This could indeed be improved, but it is hard to as there is no correlation between the image in the trailer and a given image itself. If a hw tool replaces the image, but not the trailer, it will still behave. Regardless. Fixing this would be an issue on https://github.com/mcu-tools/mcuboot and not really against Zephyr. Feel free to create an issue there if you'd like.

I've gone ahead and created #mcu-tools/mcuboot#1116 to track any work on a fix, and I will go ahead and close the issue here on Zephyr.


Using ActiveHash::Associations and JSONAPISerializer at the same time will result NoMethodError.

Controller

Model

Seriralizer

How to fix
Pattern 1

Pattern 2

think this is fixed.
Let me know if there is still an issue here.


Various peer dependency issues

Hi, I'm trying to use both of your packages (1.0.0-alpha.2) on strapi 4.0.4, but I'm getting various peer dependency conflicts upon npm install. It seems that @mattie-bundle/strapi-provider-search-algolia depends on version 1.0.0-alpha.0 of @mattie-bundle/strapi-plugin-search, which in turn depends on "@strapi/strapi": "4.0.0-beta.0".
The relevant parts of my package.json currently looks like this
    "@mattie-bundle/strapi-plugin-search": "^1.0.0-alpha.2",
    "@mattie-bundle/strapi-provider-search-algolia": "^1.0.0-alpha.2",
    "@strapi/design-system": "^0.0.1-alpha.71",
    "@strapi/plugin-i18n": "4.0.4",
    "@strapi/plugin-users-permissions": "4.0.4",
    "@strapi/strapi": "4.0.4",

@Adarah
I have the same problem. The quick solution is to use yarn

Hey @Adarah, thanks for reporting this issue. As @3webbg yarn indeed doesn't conflict about these differences. I will update the peerDependencies in the next patch.


Coordinate getHashCode() incorrect

This issue was imported from CodePlex
MilanBoers wrote 2015-05-27 at 12:09
The Equals() method of the DotSpatial.Topology.Coordinate class was overridden, but the getHashCode() function was not. Therefore, it is possible for equal coordinates to have different hashcodes, which leads to unexpected behavior when storing coordinates
in for example, HashSets.
How to reproduce:

Make Coordinate object and add to a HashSet Make another Coordinate object with the same coordinates, and also add to the same HashSet
Now the HashSet contains 2 Coordinate objects, while it should contain only one.

this should be automatically closed after merging nts-integration

This works in 2.0.
Tested this with the following code:
        Coordinate c1 = new Coordinate(-90.697857, 41.658643, 5, 12);
        Coordinate c2 = new Coordinate(-90.697857, 41.658643, 5, 12);
        HashSet<Coordinate> has = new HashSet<Coordinate>();
        has.Add(c1);
        has.Add(c2);
        Assert.AreEqual(has.Count, 1);

Also tested this for Coordinates with values
Coordinate c1/c2 = new Coordinate(-90.697857, 41.658643, 5);
and
Coordinate c1/c2 = new Coordinate(-90.697857, 41.658643);


Unable to complete Closures exercise

My code is:
function foo(){
var  bar;
function zip() {
bar = true;
}
return zip;
}
It fails with:
operator: equal
expected:
  '(global)\n\tfoo()\n\t- var bar\n\t- quux = ?\n\treturn zip\n\t\tzip()\n\t\t- var quux\n\t\t- bar = ?'
actual:
  '(global)\n\tfoo()\n\t- bar = ?\n\treturn zip\n\t\tzip()\n\t\t- bar = ?'

Hey @ryoboua , I assume this is for exercise 4?
I believe you need to carry over the quux variables from the previous exercise
function foo() {
	var bar;
	quux = true;

	function zip() {
		bar = true;
		var quux = false;
	}
	return zip;
}

It's always failed for me.
function foo() {
  var bar;
  quux = "quux";

  function zip () {
    var quux = "quux-zip";
    bar = true;
  }

  return zip;
}

you need to keep the var bar ,
so that give
function foo() {
        var bar
        function zip() {
                var quux = 0
        }
}

note that this weird thing also work lol
function foo() {
        var bar = function zip() {
                var quux = 0
        }
}


Promise.allSettled type problem

This code gives me some null errors even though i filtered the array. Type 'HistoryItem | null' is not assignable to type 'HistoryItem'.
txDatas.map(txData => txData.status === 'fulfilled' ? txData.value : null).filter(Boolean)

And also below code gives me Property 'value' does not exist on type 'PromiseRejectedResult'. even though i filtered for fulfilled promise results.
txDatas.filter(txData => txData.status === 'fulfilled').map(txData => txData.value)

See also #16655 for .filter(Boolean).

I already have some workaround for those, but i am still not convinced that this is not an issue (especially for filter if not for Promise Result types)? Shouldn't Typescript compiler already infers the types for filtering with var !== null.
Some of those workarounds for filter are below code and i can make it work also with as PromiseFulfilledResult for Promise thing.
const numbers = [1, 2, 3, 4, null];
numbers.filter((num): num is number => num !== null);

Shouldn't Typescript compiler already infers the types for filtering with var !== null.

See #38390.


False positive: Included header stdafx.h is not used directly (fix available)

When using precompiled headers, clangd gives false positive about not using the header. This issue was not present on clangd-14.
stdafx.h:
#ifndef STDAFX_H_
#define STDAFX_H_

#include <raygui.h>
#include <raylib.h>
#include <raymath.h>

#endif

main.c:
#include "stdafx.h"
// ^ Here

void setup(void) {
  InitWindow(1280, 720, "HW01");
  MaximizeWindow();
  SetTargetFPS(60);
}

void teardown(void) { CloseWindow(); }

int main(int argc, char **argv) {
  (void)argc;
  (void)argv;
  setup();
  teardown();
  return 0;
}

Logs
clangd.log
System information
Output of clangd --version:
Ubuntu clangd version 17.0.6 (++20231209124227+6009708b4367-1~exp1~20231209124336.77)
Features: linux+grpc
Platform: x86_64-pc-linux-gnu

Editor/LSP plugin: VSCode + clangd
Operating system: Ubuntu 22.04

This happens not just with stdafx.h, but any headers that is intended to be a "common header" that includes a bunch of other header files.

The warning is produced by a new feature in clangd 17 called include cleaner.
The issue you describe sounds like the first scenario discussed in this section section, you can see some of the possible solutions there.
Alternatively, the "unused header" diagnostic can be disabled as discussed in this section.

I don't know what to think about having to annotate everything, but for now I will do it.
Is there a way to keep "unused header" behavior, but allow indirect use as well? Or will that not work for C?

Is there a way to keep "unused header" behavior, but allow indirect use as well?

I think such an option is possible to implement, but isn't currently implemented.
We have #70 open for what is basically the equivalent request for the "header insertion" feature associated with code completion. If implemented, I imagine the "unused header" diagnostic could share the same infrastructure to support a similar option.

Header insertion is also a problem, because it sometimes breaks things when a certain include order is required.
Take volk as an example. This header is supposed to replace the usage of vulkan.h, as it redefines a lot of symbols, etc. And this must come before anything that uses Vulkan, and should the original header be included for whatever reason, they must come before volk.h.
However, every time clangd autocompletes (without disabling auto insert), it inserts headers like vulkan_core.h, and in the wrong place, causing all sort of compile error.
Even just considering stdlib.h. If I have auto-insert on, every time I type NULL, clangd would include some weird low-level platform header which I definitely don't want in my sources.

Even just considering stdlib.h. If I have auto-insert on, every time I type NULL, clangd would include some weird low-level platform header which I definitely don't want in my sources.

That sounds like a bug, would you mind filing that separately with a log?

A quick minimal example doesn't reproduce. I'll give it a try later

The warning is produced by a new feature in clangd 17 called include cleaner.

I am new to using clangd, but is there a way that it could more gently suggest "hey, consider this optimization" rather than labelling it as a warning? It's something that's certainly nice to know, but I'd really prefer warnings to be reserved for "potentially dangerous" elements rather than opinionated/optimized/stylized ones.
For context, I am using clangd in VSCode and the presence of the warning ends up colouring the file name yellow. Sometimes for simplicity I prefer a wider #include, and it would be nice to not be warned about a valid choice (but still be passively informed that there is a more optimal alternative). I seem to recall seeing either blue underlines or "suggestion" lightbulbs in VSCode for other languages in past projects. Assuming these non-warning suggestions are a part of the language server and not the editor, perhaps there's a way clangd could communicate more "informational" suggestions that aren't considered warnings, but still inform the user?

The LSP does offer a lower diagnostic severity than a warning, DiagnosticSeverity.Information (and interestingly, it looks like the "missing include" diagnostic uses this lower severity, while the "unused include" diagnostic does not). You're welcome to file an issue suggesting a change to the severity or a way to configure it.

Thank you @HighCommander4 - I just updated my .clangd to feature:
Diagnostics:
  MissingIncludes: Strict
  UnusedIncludes: None

I now see the informational suggestions, and they do not increase my warning count.  I will gladly open an issue about making this informational severity the default behaviour for UnusedIncludes.
(Side-note: I had to restart VSCode for the changes to .clangd to take effect.)
In the meantime, are there any ways we can change severities in our config files or through command-line options?  If not, perhaps I see another feature request in my future 🙂

In the meantime, are there any ways we can change severities in our config files or through command-line options?

Not that I know of.


Godot Not Response Error (Wait for Windows dwm)

Tested versions

Reproducible in: v4.3.rc1.mono.official [e343dbbcc]

System information
Godot v4.3.rc1.mono - Windows 10.0.19045 - Vulkan (Mobile) - dedicated Intel(R) Iris(R) Xe Graphics (Intel Corporation; <IP_ADDRESS>92)
Issue description

Here are two screenshots when the editor is not responding. I noticed that godot is waiting for dwm.exe to respond. This may be windows related. And sometimes it's endlessly unresponsive, other times it'll fix itself in 10 seconds or so. I think it's a bug because all the other programs running at the same time as it work fine. And it's also not an important bug to fix, since restarting the editor is sufficient. But it's an annoying bug.
My English is not very good, so sometimes I use translation tools. Please let me know if I've said something wrong, or if I've expressed myself unclearly.
Steps to reproduce
It is known that this error is not caused by every dwm trigger. But this is the only known way to cause it. And I've found that updating the graphics driver causes the program to wait for dwm which in turn leads to unresponsiveness.
Minimal reproduction project (MRP)
N/A

Sorry, dwm wasn't the main cause because when I started photoshop, it broke again. At that time I realized that dwm was not causing the error 🤔.


Automatically Select Newly Uploaded Image In Media Library

Is your feature request related to a problem? Please describe.
Currently when a new file is uploaded it is not selected.
Describe the solution you'd like
On most occasions, the newly uploaded file will be the one being added, so it should be selected automatically. Even if it isn't being added, selecting it will do no harm.
Describe alternatives you've considered
The only alternative is to find and select the newly uploaded file.

@erquhart should this issue be closed? It looks fix for this was merged on Aug 20 :)

Good catch
Sent with GitHawk

@erquat figured this was another way to contribute to Hacktoberfest! Was looking for an issue to help out with after I found out about this project at the JamStack conf last week. Great talk by the way! :)

Thank you! Completely failed to label issues for hacktoberfest 🤦♂
Sent with GitHawk


Cannot make release PR

I'm getting an error trying to make a new release PR:
release-please release-pr --repo-url=google/slo-generator --token=<MY_TOKEN> --package-name=slo-generator
✖ pull #21 2790f8765db7e628f7eeea1e8016971b05b13225 has not yet been released

Pull request in question is here and has been merged to master.
Could you please help ?

Seems like the release PR was not correctly tagged autorelease: tagged, so had to do it manually.
I'm now getting:
release-please release-pr --repo-url=google/slo-generator --token=<MY_TOKEN> --package-name=slo-generator
✔ found 6 commits since 2790f8765db7e628f7eeea1e8016971b05b13225
✔ release as minor: There are 0 BREAKING CHANGES and 1 features
command release-pr failed with status 404

@ocervell my hunch is that this is potentially permission related, it might be easiest for us to dig into this together.

I see your issue based on that error message, I think it's using the default release type node, but the type should be python. I'm looking at your upstream repository, and it looks like python is configured, so wondering if perhaps you worked through this?


Add latest kerio-control-vpn-client.

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

[x] Named the cask according to the [token reference].
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.
[x] Checked there are no [open pull requests] for the same cask.
[x] Checked that the cask was not already refused in [closed issues].

When you download the dmg there are two files, Kerio Control VPN Client Installer.pkg and Kerio Control VPN Client Uninstaller.app. The uninstall app contains an uninstall script at Kerio Control VPN Client Uninstaller.app/Contents/Resources/uninstall which seems to do a more thorough job of uninstalling this.
It might be better to add an uninstall script: to this Cask. See an example here.

I went down that way at first. But it seems that the script only works through the UI.
When you run that uninstall script, it halts with a non-zero exit status (without any output). I even tried to simulate the work of the uninstall script and execute those action scripts (residing in action/) separately which failed as well.
So I took the uninstall script and simulated all its jobs using cask's uninstall stanza. The only thing that differs is that the uninstall script closes the System Preferences app. I didn't know how to do that in using uninstall stanza.
What do you think?

No problem if you had already tried and it calls a UI then no problem. The only thing I can see that the uninstall script does "extra" is removing the following files:
rm -rf /usr/local/kerio/vpnclient/!(dbSSL|config|logs)
rm -rf /Library/PreferencePanes/KVpnClient.prefPane
rm -rf /Library/LaunchDaemons/com.kerio.kvpncsvc.plist
rm -rf /Library/Extensions/kvnet.kext

Yes, you are right and I saw those lines as well. But I though that's covered by pkgutil:   'com.kerio.control.kvpnclient.pkg'. Isn't that?

Ah yes, I believe you are correct.


[b/337839365] Implement StatsTaskListGenerator, add an example

b/337839365
Provide a single example of the new connector being used with a statspack DMA SQL

I think it's good to comment separately on the SQL file added by this PR.
It integrates some of the DB dumping mechanism created by fellow Googlers in GCP DB Assessment
The original script can be found here.


Update pro_scraping.md

Added two missing userData

those are not missing, Request.label is a shortcut


Pluralsight -HTTP Error 403

"C:/Users/msabeq/Videos/Pluralsight/%(playlist)s/%(chapter_number)02d - %(chapter)s/%(playlist_index)02d - %(title)s.%(ext)s"  --sleep-interval 35 --max-sleep-interval 120 --sub-lang en --sub-format srt --write-sub )
[pluralsight:course] microsoft-azure-cloud-concepts: Downloading JSON metadata
[download] Downloading playlist: Microsoft Azure Cloud Concepts
[pluralsight:course] playlist Microsoft Azure Cloud Concepts: Collected 12 video ids (downloading 12 of them)
[download] Downloading video 1 of 12
[pluralsight] Downloading login page
ERROR: Unable to download webpage: HTTP Error 403: Forbidden (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
PLZ help me with is error

PLZ follow the template.

@msabeq I was in the same boat. I used --cookies option instead of --username and --password successfully. Used "Get cookies.txt" extension to get the cookies to a text file. Ref: https://github.com/ytdl-org/youtube-dl/issues/28762

Duplicate of #29776.


Questions: How to provide serializer to the WrappedWindowStore

Description
When creating tumbling windows the result object's SerDes is not passed to the inner window store.
How to reproduce
Having the following stream:
StreamBuilder builder = new StreamBuilder();

builder.Stream<string, ObjectA, StringSerDes, SchemaAvroSerDes<ObjectA>>(_config.InputTopicName)
    .Map((key, value) => new KeyValuePair<string, ObjectA>(value.symbol, value))
    .GroupByKey()
    .WindowedBy(TumblingWindowOptions.Of(TimeSpan.FromMinutes(5)))
    .Aggregate<ObjectB, SchemaAvroSerDes<ObjectB>>(
        () => new ObjectB(),
        (key, ObjectA, ObjectB) => _ObjectBHelper.CreateObjectB(key, ObjectA, ObjectB))
    .ToStream()
    .Map((key, ObjectB) => new KeyValuePair<string, ObjectB>(key.Key, ObjectB))
    .To<StringSerDes, SchemaAvroSerDes<ObjectB>>(_config.OutputTopicName);

Will throw the following exception:
Streamiz.Kafka.Net.Errors.StreamsException: SchemaSerDes<ObjectB> is not initialized !
   at Streamiz.Kafka.Net.SchemaRegistry.SerDes.SchemaSerDes`1.Serialize(T data, SerializationContext context) in /Users/oxid/code/kafka-streams-dotnet/serdes/Streamiz.Kafka.Net.SchemaRegistry.SerDes/SchemaSerDes.cs:line 68
   at Streamiz.Kafka.Net.SerDes.ValueAndTimestampSerDes`1.Serialize(ValueAndTimestamp`1 data, SerializationContext context) in /Users/oxid/code/kafka-streams-dotnet/core/SerDes/ValueAndTimestampSerDes.cs:line 56
   at Streamiz.Kafka.Net.State.Internal.WrappedWindowStore`2.GetValueBytes(V value) in /Users/oxid/code/kafka-streams-dotnet/core/State/Internal/WrappedWindowStore.cs:line 48
   at Streamiz.Kafka.Net.State.Internal.WrappedWindowStore`2.Put(K key, V value, Int64 windowStartTimestamp) in /Users/oxid/code/kafka-streams-dotnet/core/State/Internal/WrappedWindowStore.cs:line 77
   at Streamiz.Kafka.Net.Processors.KStreamWindowAggregateProcessor`4.Process(K key, V value) in /Users/oxid/code/kafka-streams-dotnet/core/Processors/KStreamWindowAggregateProcessor.cs:line 74
   at Streamiz.Kafka.Net.Processors.AbstractProcessor`2.Forward[K1,V1](K1 key, V1 value) in /Users/oxid/code/kafka-streams-dotnet/core/Processors/AbstractProcessor.cs:line 83
   at Streamiz.Kafka.Net.Processors.KStreamMapProcessor`4.Process(K key, V value) in /Users/oxid/code/kafka-streams-dotnet/core/Processors/KStreamMapProcessor.cs:line 20
   at Streamiz.Kafka.Net.Processors.SourceProcessor`2.Process(K key, V value) in /Users/oxid/code/kafka-streams-dotnet/core/Processors/SourceProcessor.cs:line 57
   at Streamiz.Kafka.Net.Processors.AbstractProcessor`2.Process(Object key, Object value) in /Users/oxid/code/kafka-streams-dotnet/core/Processors/AbstractProcessor.cs:line 200
   at Streamiz.Kafka.Net.Processors.AbstractProcessor`2.Process(ConsumeResult`2 record) in /Users/oxid/code/kafka-streams-dotnet/core/Processors/AbstractProcessor.cs:line 194
   at Streamiz.Kafka.Net.Processors.StreamTask.Process() in /Users/oxid/code/kafka-streams-dotnet/core/Processors/StreamTask.cs:line 311
   at Streamiz.Kafka.Net.Processors.Internal.TaskManager.Process(Int64 now) in /Users/oxid/code/kafka-streams-dotnet/core/Processors/Internal/TaskManager.cs:line 217

If I remove the windowing tasks and just leave an input/output Map steps, ObjectBs are properly written in the output topic, so the SerDes alone is working fine. But when the Windowing aggregator step is added the SerDes gets lost for the output object.
Modifying the ValueAndTimestampSerDes class to initialize the inner serdes causes seems to be working but it's not quite 100%, the output topic SerializationContext is still of the input and not the output.
InnerSerdes.Initialize(serDesContext);
How can I properly feed in the output schema SerDes and topic name to the below method:
public override byte[] Serialize(ValueAndTimestamp<V> data, SerializationContext context)
Checklist
"Streamiz.Kafka.Net" Version="1.1.5"
"Streamiz.Kafka.Net.SchemaRegistry.SerDes.Avro" Version="1.1.5"
Kafka docker image: confluentinc/cp-kafka:5.3.0
Schema registry: confluentinc/cp-schema-registry:6.0.0
.net 5.0 on MacOS

Hi @0x1D-1983,
You are right ! Serdes is not initialized from Schema registry and if you modify ValueAndTimestampSerDes ( initialize the inner serdes), maybe it's cool but can't work any time at 100%.
Why ?
At time I haven't changelog topic, so when schema registry client need a schema (option1 : check local cache and that's works ! option2: No present in cache, and need to contact schema registry with a subject (default: topicName-key or topicName-value), but I haven't changelog topic at time (present normally in next release 1.2.0 soon I hope)./
SO that's why and you have just source and sink data with SchemaAvroSerdes, it's works because I can set a topic name.
A good workaround is to use JSON Formatter (without registry) for intermediate statefull processor waiting 1.2.0 release.
If you have any other question, do not hesitate.

Thank you for the answer. I will try Option1 (local cache) and if it doesn't work I will check the JSON formatter workaround. Cheers!


MAID-3246: use safe crypto

Replace rust_sodium with safe_crypto.

We proabably don't need everything in this PR anymore. Socket-collections can now be configured to encrypt/decrypt all wire data so we should be good if users of that crate (like this one) can simply configure it that way.

I was planning to build socket-collection with encryption integration into p2p based on this PR. Otherwise I will have to redo quite a few changes: e.g. replace rust_dosium with safe_crypto types in code/examples/tests...

I would highly advise to review and merge this PR.

It replaces rust_sodium with safe_crypto which will have to be done in the near future anyway.
These are safe mechanical changes with a low chance of breaking anything.
These changes touch most parts of the code base. That means if anything changes in p2p I have to rebase this PR and that is a lot of work again. Also, consider point 1 in this case.


Homebridge can connect and display AC parameter but can't change any set setpoint

Homebridge can connect and display AC parameter but can't change any set setpoint

Model : RAC_056905_WW

Please reopen this issue after attaching any relevant logs to assist with debugging. It'd be best to turn on debug mode for Homebridge and send along anything that sticks out. Thank you!


update stage_type if it is DEFAULT and delivery_type is different with it

We will keep one source of truth for stage_type on Teletraan side.
When the delivery_type is different with stage_type and stage_type is not DEFAULT, we reject the deployment API call;
When the delivery_type is different with stage_type and stage_type is DEFAULT, we update the stage_type;

Feel free to test here:


Question: PDTextField value with line break "\n"

Hi, I've been generating PDFs using user input and some of the text input allows for line breaks that span multiple lines. I set these strings using PDTextField.setValue() and a typical multiline string would look like this:
"This is a test string\nThis is a new line\nAnd another"
Problem is, after setting a string with line breaks and generating the PDF, this causes the lines to combine and overlap one another rather than separating to a separate line below (see pic). Does anyone know of a way to set strings with line breaks and have them reflect in a PDF text field?

(The entire "Notes" box is a text field and its multiline has been set to true)
Here the full code of how I set the value:
PDField treeNode;
try {
      treeNode = acroForm.getField(textFieldName);
      if (treeNode instanceof PDTextField) {
          PDTextField textField = ((PDTextField) treeNode)
          textField.setMultiline(true);
          textField.setValue(text);
      } else {
          throw new IOException();
      }
} catch (IOException ignored) {
}

hi guys, any news about that one?
we have the same issue here and tried a few workarounds with no luck.
regards from sunny Vienna -Eduard


Stats view improvement

[x] Add gists with code related to each statistic
[x] Find a different way to display the stats

Expansion panel component was used


v1 PR with comment change, shows CI failing for v1 branch

v1 PR with comment change, shows CI failing for v1 branch

Tests were fixed by mocking out the calls to get the petstore spec from http://petstore.swagger.io/v2/swagger.json
Closing this PR because the commit that fixes those tests has been pulled into https://github.com/swagger-api/swagger-parser/pull/1414


Service Request by David Lounsbury - LIST OPTIONS

[ ] Qualtrics Service Request Form was received from User
[ ] e-mail acknowledging that User's Qualtrics Service Request Form was sent
[ ] Problem NOT RESOLVED
[ ] Problem PARTIALLY RESOLVED
[ ] Problem FULLY RESOLVED and Issue is Closed
[ ] Qualtrics Post-Service Request Survey was sent to User

Use comments feature (below) to document:

A clear and concise description of the solution.

A clear and concise description of any alternative solutions or features you've considered.

Any additional context, such as screenshots about the problem.

Jeff saw the problem and fixed it right away.


Can't access .ExternalURL on Slack actions gotpl templates

What did you do?
Create a custom template for Slack button for silences
What did you expect to see?
A button to create silences
What did you see instead? Under which circumstances?
Nothing on Slack. Error on Alertmanager logs
Environment

System information:

EKS 1.16 with AWS eks AMIs
Linux 4.14.186-146.268.amzn2.x86_64 x86_64

Alertmanager version:

alertmanager, version 0.21.0 (branch: HEAD, revision: 4c6c03ebfe21009c546e4d1e9b92c371d67c021d)
  build user:       root@dee35927357f
  build date:       20200617-08:54:02
  go version:       go1.14.4

Prometheus version:

prometheus, version 2.20.1 (branch: HEAD, revision: 983ebb4a513302315a8117932ab832815f85e3d2)
  build user:       root@7cbd4d1c15e0
  build date:       20200805-17:26:58
  go version:       go1.14.6

Alertmanager configuration file:

My silence link gotpl function... expecting having access to the full context (Data on the Alertmanger page https://prometheus.io/docs/alerting/latest/notifications/)
            {{ define "util.generate.silence.link" }}
                {{ .ExternalURL }}/#/silences/new?filter=%7B
                {{- range .CommonLabels.SortedPairs -}}
                    {{- if ne .Name "alertname" -}}
                        {{- .Name }}%3D"{{- .Value | urlquery -}}"%2C%20
                    {{- end -}}
                {{- end -}}
                alertname%3D"{{ .CommonLabels.alertname }}"%7D
            {{ end }}

receiver
            receivers:
              - name: infrastructure-alert
                slack_configs:
                - channel: '#infrastructure-alerts'
                  send_resolved: true
                  icon_emoji: '{{ template "slack.webhook.icon_emoji" . }}'
                  color: '{{ template "slack.resolve.color" . }}'
                  text: '{{ template "slack.generic.text" . }}'
                  title: '{{ template "slack.generic.title" . }}'
                  username: prometheus-monitor
                  actions:
                  - type: button
                    text: 'Run book :hammer_and_spanner:'
                    url: '{{ template "util.generate.runbook.url" (index .Alerts 0) }}'
                  - type: button
                    text: 'Logs :book:'
                    url: '{{ template "util.generate.logs.url" (index .Alerts 0) }}'
                  - type: button
                    text: 'Dashboard :bar_chart:'
                    url: '{{ template "util.generate.dashboard.url" (index .Alerts 0) }}'
                  - type: button
                    text: 'Silence :no_bell:'
                    url: '{{ template "util.generate.silence.link" . }}'
                  - type: button
                    text: 'Code :github:'
                    url: '{{ template "util.generate.github.repo.url" (index .Alerts 0) }}'

Prometheus configuration file:

insert configuration here (if relevant to the issue)

Logs:

level=error ts=2020-08-21T15:35:51.150Z caller=dispatch.go:309 component=dispatcher msg="Notify for alerts failed" num_alerts=8 err="infrastructure-alert/slack[0]: notify retry canceled due to unrecoverable error after 1 attempts: template: utils.tmpl:64:9: executing \"util.generate.silence.link\" at <.ExternalURL>: can't evaluate field ExternalURL in type template.Alert"

Slack URL templated here
https://github.com/prometheus/alertmanager/blob/master/notify/slack/slack.go#L141
using this function
https://github.com/prometheus/alertmanager/blob/master/notify/util.go#L83
which uses the context extracted from this function
https://github.com/prometheus/alertmanager/blob/master/notify/util.go#L132
==>
https://github.com/prometheus/alertmanager/blob/master/template/template.go#L280:20

Alertmanager is correct in saying that it can't evaluate the ExternalURL field because it's part of the Data structure and not Alert.

Somehow the configuration you've shared doesn't match with what Alertmanager is running...

@carlosjgp you can try something like this:
          {{ define "slack.my.text" }}
          {{- $root := . -}}
          {{ range .Alerts }}
            *Alert:* {{ .Annotations.summary }} {{ .Annotations.message }}
            *Description:* {{ .Annotations.description }}
            *Silence this alert:* <{{ template "util.generate.silence.link" $root }}|:no_bell:>

...

Sadly I'm not using Alertmanager anymore so I can't test this
Thanks for your response. Will close this now


Update datasite-tutorial.md

changed the email address for support to<EMAIL_ADDRESS>

Looks good, @jeevansd @arajpathak7 Could anyone of you please sign-off

#sign-off

@gregvossen : Thanks for your contribution! The author(s) have been notified to review your proposed change.


First runnable version

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@7a29df0). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage        ?   69.23%
=======================================
  Files           ?        3
  Lines           ?       13
  Branches        ?        0
=======================================
  Hits            ?        9
  Misses          ?        4
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a29df0...e921d4d. Read the comment docs.

We should add the .pylintrc which we missed in #4


fix(@schematics/angular): remove compileComponents from component test schematic

Note: This is an updated version of #18316 after discussing with @atscott who thought we are now in a place where it could land
compileComponents is not necessary when using the CLI (as the templates are inlined) and just adds boilerplate code. So we can remove it from the test schematic and make it independent from async/await (only place we would have it in the CLI generated code, and in most Angular apps).
PR Checklist
Please check to confirm your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
Tests are generating with compileComponent calls that aren't needed with the CLI
What is the new behavior?
The boilerplate is reduced to only keep what is really necessary
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Apologies for blocking this PR the first time, I'm on board with the change now at least. :sweat_smile:
Just to note somewhere for future reference, removing .compileComponents() does make the generated schematic slightly less portable since it won't fetch templateUrl and styleUrl resources during testing. That's fine for CLI tests and jest-preset-angular (AFAICT) because they include transforms in the build process to inline such resources at build time (the compiler rewrites templateUrl: './template.ng.html' to template: '<div>...</div>'), so they don't need to be loaded at runtime in the test environment.
Aside from being an optimization, I think it's actually required regardless of .compileComponents(). templateUrl and styleUrls are both file-relative, but at runtime which file is requesting a given resource is lost. So there's no way to know what directory a reference to ./template.ng.html actually wants. If we had design this to look like:
@Component({
  templateUrl: new URL('./template.ng.html', import.meta.url),
  // ...
})
class MyComponent {}

Then this information would be kept at runtime and we could resolve resources correctly. Without it, I think there's enough ambiguity here to say that Angular just doesn't work without the inline resources transform. Since compileComponents() is only needed in situations where users don't have the inline resources transform and that use case is basically impossible anyways, then there's not much value in generating .compileComponents().

@dgp1130 No hard feelings 😉. Thank you for considering it this time, and for the detailed explanation!


Error in Typescript build

Any idea to resolve this

I will recommend you not to use the Typescript version...because I am gonna change many of the settings there especially vuex -> pinia and also some other typing-related issues. But if you want to try (vite + vue 3 + typescript) in your project.
I will highly recommend you to use vitesse or if you want a forked version of this with a clean and modular architecture pattern, then go for one of my repo here vitesse-stackter-clean-architect

Thank you for prompt response. will give it a try.


[Transforms] Import external helpers module

This change adds support for referencing emit helpers from an external module.
Compiler Options

--importHelpers - Import emit helpers from "tslib".

Emit
When importHelpers is specified, a synthetic ImportDeclaration is added to the top of each external module that needs an emit helper, such as __extends. As a result, no emit helpers will be added to these files during emit. In addition, any place where the emit helper would be referenced, it would instead reference a member of the imported module.
For example:
// @module: commonjs
// @importHelpers: true
export class A { }
export class B extends A { }

Outputs:
var tslib_1 = require("tslib");
var A = (function () {
  function A() {
  }
  return A;
})();
exports.A = A;
var B = (function (_super) {
  tslib_1.__extends(B, _super);
  function B() {
  }
  return B;
})(A);
exports.B = B;

Script files
If a file is detected as a non-external-module (e.g. script file), the existing behavior for emit helpers is used. As long as the --noEmitHelpers option is not set, emit helpers will be added to the top of the file as usual.

CC: @mhegazy, @vladima

__asing seems to be emitted still.
other than that, can you add a test for something that explicitly includes an import to tslib.

We previously talked about adding a check in the program creating to make sure that tslib can be resolved as a module. and possibly, that it does have an exported function __extends, etc..

Baselines need to be updated for error spans i would expect.

👍

Will be useful to allow specify own module name. In my project https://github.com/electron-userland/electron-builder/blob/master/src/codeSign.ts I need only awaiter and since bluebird is forbidden, I disable emit helpers and add custom awaiter impl to each file. And new option is not solution because I cannot specify helper module name.

Will the new --importHelpers flag also apply to the __export helper? Currently, the --noEmitHelpers controls all the other helpers (e.g., __extends, __decorate, etc.), except for __export. See issue #10905.

@gilboa23, no it doesn't yet apply to __export as that helper is currently a closure over the local exports symbol defined in the module body. We are considering a change to make this possible, but it would be a breaking change for anyone using --noEmitHelpers.

Yes, but I was not referring to the existing --noEmitHelpers flag. What I meant was to apply this change just over the new --importHelpers flag by passing the local exports symbol in the invocations of the imported tslib.__export() function. This should not be a breaking change since this is a new flag that no one is using yet. Something like:
// @module: amd
// @importHelpers: true
export * from "A";
export * from "B";

Output:
define(["require", "exports", "A", "B"], function (require, exports, A_1, B_1) {
    "use strict";
   var tslib_1 = require("tslib");
    tslib_1.__export(A_1, exports);
    tslib_1.__export(B_1, exports);
});

@gilboa23 if issue https://github.com/Microsoft/TypeScript/issues/10905 is fixed, it will work for both.

<EMAIL_ADDRESS>is missing __generator function. But the source code has.
should tslib on npm be updated and release a new version?

So, if I would like to use --importHelpers with tslib and replace only a specific helper (say, __awaiter) with my own implementation, how would I go about that?

So, if I would like to use --importHelpers with tslib and replace only a specific helper (say, __awaiter) with my own implementation, how would I go about that?

Use<EMAIL_ADDRESS>or later
Install tslib
Set --importHelpers on the command line or in your tsconfig.json


Msbuild issue in 6.1.0 preview.2

Describe the bug
When running build using visual studio it causes error
Error	MSB4018	The "ZeroQLBuildTask" task failed unexpectedly.
System.IO.FileNotFoundException: Could not load file or assembly 'Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed' or one of its dependencies. The system cannot find the file specified.
File name: 'Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed'
   at ZeroQL.Core.Config.ZeroQLSchema.GetJsonSchema()
   at ZeroQL.Core.Config.ZeroQLConfigReader.ReadConfig(String configFile)
   at ZeroQL.Tasks.ZeroQLBuildTask.Execute()
   at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
   at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext()

How to Reproduce
Build project that uses package with visual studio
Expected behavior
Build should complete without error
Environment (please complete the following information):

Nuget package version [6.1.0-preview.2]
IDE: [VS]
.Net Version [6.0.400]

Additional context
dotnet build works but build using visual studio not.
It seems that issue is in .nuget\packages\zeroql\6.1.0-preview.2\build\net6.0\ZeroQL.props file when replaced with .nuget\packages\zeroql\6.0.0\build\net6.0\ZeroQL.props - build works.

I managed to reproduce in Visual Studio. However, it works fine in Rider and via CLI. Will have a look at it.

Checkout v6.1.0-preview.4. The issue with msbuild in VS should be fixed.


[dv/common] update intr_state CSR exclusions

This PR updates the exclusions added to all intr_state CSRs to disable
most checks on it.
This addresses #6888.
Signed-off-by: Udi Jonnalagadda<EMAIL_ADDRESS>

should we revert the update at #6890? since we don't check intr_state, we may not need to avoid writing that CSR. Otherwise, LGTM

@weicaiyang good question - #6890 fixes a separate set of issues in csr_hw_reset, namely some assertion errors that popped up due to unexpected entropy FSM operation, so this PR is still necessary for the IP level csr tests.

should we revert the update at #6890? since we don't check intr_state, we may not need to avoid writing that CSR. Otherwise, LGTM

@weicaiyang good question - #6890 fixes a separate set of issues in csr_hw_reset, namely some assertion errors that popped up due to unexpected entropy FSM operation, so this PR is still necessary for the IP level csr tests.

I see. Thanks for the explanation.


Add wrapper to Nix package to find LLVM backend

Needed for #1733.

Looks fine to me but I'd like someone else to take a look since I don't know nix that well. Doesn't have to be a nix expert, I just want more eyes on this so people can start to build knowledge.

Looks fine to me but I'd like someone else to take a look since I don't know nix that well. Doesn't have to be a nix expert, I just want more eyes on this so people can start to build knowledge.

@andreiburdusa Please take a look at this.

@andreiburdusa Please take a look at this.

Is this wrapper used to find LLVM backend like wrappers for gcc and ld are used here to find libgd?

Is this wrapper used to find LLVM backend like wrappers for gcc and ld are used here to find libgd?

Is this wrapper used to find LLVM backend like wrappers for gcc and ld are used here to find libgd?

Yes, that's right.

Is this wrapper used to find LLVM backend like wrappers for gcc and ld are used here to find libgd?

Yes, that's right.

What's going on with this one? Everett wanted it merged prior to my krun/kx PR, so I would like to see progress. Does @andreiburdusa still need to review? Should I just approve and merge? What's the next step and who needs to take it?

What's going on with this one? Everett wanted it merged prior to my krun/kx PR, so I would like to see progress. Does @andreiburdusa still need to review? Should I just approve and merge? What's the next step and who needs to take it?

What's going on with this one? Everett wanted it merged prior to my krun/kx PR, so I would like to see progress. Does @andreiburdusa still need to review? Should I just approve and merge? What's the next step and who needs to take it?

I already took a look here. I think it can be merged if @ttuegel agrees.

What's going on with this one? Everett wanted it merged prior to my krun/kx PR, so I would like to see progress. Does @andreiburdusa still need to review? Should I just approve and merge? What's the next step and who needs to take it?

I already took a look here. I think it can be merged if @ttuegel agrees.


Renewable lilypads

Renewable lily pads is a broken feature because FC removed the placement of lily pads as it could be used as an exploit to avoid squids. I need to decide if its a feature worth keeping, or if I should undo the change.

Dawn has stated that she will port placement over to CE, which means that I just need to confirm that the feature is working.


Support for Terraform 0.13

what
Adds Terraform 0.13 support.
why
Testing and preparing for Terraform 0.13 support.
references
Resolves #48

Testing in progress, as consumed by this PR: https://github.com/slalom-ggp/dataops-infra/pull/120

I think this was resolved in #46 #47
Please re-open otherwise.
Thanks for the contribution.

Awesome - thanks, @osterman! 👍


Update u256.rs

return the value from macro

Thanks for PR!

Please, use https://www.conventionalcommits.org/en/v1.0.0/ for commit messages
Rebase onto the actual master. It seems you use the old version.
It's an error, but how have you met it? Is it a prerequisite for U512 support?

Sorry for not responding. I see it is not relevant, close PR.


Copyright years based on git history

We have recently introduced a custom PropertiesProvider in our project  that adds two new properties:

license.copyrightLastYear - the year of the last change of the present file as seen in git history
license.copyrightYears - the combination of project.inceptionYear and license.copyrightLastYear delimited by a dash, or just project.inceptionYear if project.inceptionYear is eqal to license.copyrightLastYear

In this way we are able to comply with the requirement of our legal department to update the copyright range anytime the given file is changed without too much manual work. Because this kind of requirement is certainly quite common, we are looking for a way to share our code.
To contribute our code to license plugin seems to be the first natural choice. However our code depends on jGit and you probabaly will not be wanting to introduce the jGit dependency to license plugin itself.
Maybe a submodule of license plugin would be better? That submodule would build to a jar that could optionally be used by license plugin at runtime. WDYT?

Understood!
I think of 2 ways implementing this in MLP:
In exemple in MLP configuration you can currently set properties like this:

Mycila
<EMAIL_ADDRESS>
an idea would be to introduce a propertiesProvider setting:

org.hawkular.build.license.CopyrightRangeProvider

So we could have such behavior:

MLP laods proeprties like it it currently done (which handle the properties section)
Then find if a propertiesProviderClass class is available, and if yes, instantiate it and gets the properties (which overrides existing ones)

Another solution would be to use the JDK ServiceLoader system to load all implementations of an interface from the classpath. This way, several implementations could provided their own properties (and could be several properties provider).
This way the properties provider could just be an interface:
public interface PropertiesProvider {
Map<String, String> getAdditionalProperties(AbstractLicenseMojo mojo, Properties properties,
Document document) {
}
in the MLP project.
Then in your project you just implement it and provide either a configuration, or a META-INF/services/com.mycila...PropertiesProvider file referring to all your PropertiesProvider implementations.
ServiceLoader pros:

it enables several providers through plugins, projects, etc.. to be discovered automatically. Thus, it could avoid any configuration complexity. You could put the GIT class in a simple JAR and add this jar as a dependency of MLP plugin and the property provider will be automatically discovered

ServiceLoader cons:

unwanted properties could come from plugins or unwanted jars in project having such META-INF/services file
no guaranteed order of providers (=> no override order)

 pros:

better control over properties from a project / module and can also specify several providers, in order

 cons:

harder to use plugins architecture  (i.e. having a plugin jar set to MLP to automatically loads properties from git) since you have to declare your provider in the config

Let me know what you think of!
This way you could easily provider a little modification in your fork and send a pull request I think.
Thanks :+1:
Mat'

I do not know if I stated explicitly enough that we already have an implementation of com.mycila.maven.plugin.license.PropertiesProvider here: https://github.com/hawkular/hawkular-build-tools/blob/master/src/main/java/org/hawkular/build/license/CopyrightRangeProvider.java#L70
It works quite well with the ServiceLoader framework and I am OK to leave it like that.
As you seem to imply that this functionality is welcome I am going to prepare a PR with how I'd introduce it to your source tree.

Thanks :-)

Merged #56


Duplicated newlines after processing

Prass, as the title says, exports duplicated newlines in the resulted script. For example, this:
[Script Info]
ScriptType: v4.00+
WrapStyle: 0
PlayResX: 848
PlayResY: 480
ScaledBorderAndShadow: yes

[V4+ Styles]
Format: Name, Fontname, Fontsize, PrimaryColour, SecondaryColour, OutlineColour, BackColour, Bold, Italic, Underline, StrikeOut, ScaleX, ScaleY, Spacing, Angle, BorderStyle, Outline, Shadow, Alignment, MarginL, MarginR, MarginV, Encoding
Style: Main,Open Sans Semibold,36,&H00FFFFFF,&H000000FF,&H00020713,&H00000000,-1,0,0,0,100,100,0,0,1,1.7,0,2,0,0,28,0

[Events]
Format: Layer, Start, End, Style, Name, MarginL, MarginR, MarginV, Effect, Text
Dialogue: 0,0:00:00.91,0:00:03.44,Main,,0,0,0,,Sorry for making you come along, Shin-chan.
Dialogue: 0,0:00:03.44,0:00:04.46,Main,,0,0,0,,Don't be.
Dialogue: 0,0:00:04.46,0:00:07.27,Main,,0,0,0,,But are you sure you should've bought so much?
Dialogue: 0,0:00:07.60,0:00:09.61,Main,,0,0,0,,They're all clothes to wear at the club,
Dialogue: 0,0:00:09.61,0:00:11.40,Main,,0,0,0,,so they'll be expensed.

Dialogue: 0,0:00:04.46,0:00:07.27,Main,,0,0,0,,But are you sure you should've bought so much?

Dialogue: 0,0:00:07.60,0:00:09.61,Main,,0,0,0,,They're all clothes to wear at the club,

Dialogue: 0,0:00:09.61,0:00:11.40,Main,,0,0,0,,so they'll be expensed.

This is not an actual issue for Aegisub to parse. But, for the sake of automated processes, launching Aegisub again to clean those newlines after running Prass would kill the point of using Prass at all.
Maybe worth noting that running 'run-tests.py' on my end throws two failures because of this. More specifically on test_cleanup and test_noop.
Hope that helps and thanks in advance.

That was fast, thanks a lot.


Feature/hres mobile

@d4weed I'll wait until tomorrow to merge this into develop so we can modify whatever we might need before, but I think it's pretty nice right now:

Once the PR is merged, I'll assign it to @aagm so she can test it.
Cheers!

Tested by @aagm


Rework Settings gui (SOFIE-2300)

Work in progress
This PR aims at change how the settings pages are made, in order to provide several quality-of-life issues, such as:

A unified “filterable” settings tree component that we could reuse.
Use VS Code Settings page as a reference
Have the settings be divided into nested sections.
Lists should be sortable
Have an auto-focused “Search settings” text box

Codecov Report
Patch coverage: 11.11% and project coverage change: -0.03 :warning:

Comparison is base (ba813b1) 58.95% compared to head (33fc04a) 58.93%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@              Coverage Diff              @@
##           release50     #922      +/-   ##
=============================================
- Coverage      58.95%   58.93%   -0.03%
=============================================
  Files            464      466       +2
  Lines          70969    71014      +45
  Branches        3672     3674       +2
=============================================
+ Hits           41838    41849      +11
- Misses         29081    29115      +34
  Partials          50       50

Impacted Files
Coverage Δ

meteor/client/lib/guiSettings/guiSettings.ts
0.00% <0.00%> (ø)

meteor/client/lib/guiSettings/studioSettings.ts
0.00% <0.00%> (ø)

meteor/server/collections/collection.ts
66.02% <26.31%> (-1.70%)
:arrow_down:

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Prevent svelte repl from being overwritten

One of my projects was totally ruined because someone edited it after I sent them a link without me realizing that other people can just edit your repls. Here is my proposed solution:

User makes a repl and saves it
User sends/shares the link
User B makes changes to the repl
a. These changes are reflected locally but not saved to the original repl.
b. There is a prompt after a few minutes of editing to fork and save
Done, happy users

without me realizing that other people can just edit your repls

I don't think they can, that would be horrible.
https://github.com/sveltejs/sites/blob/70a2f338b5f49af4acf130a3127dda826175772b/sites/svelte.dev/src/routes/(authed)/repl/[id]/AppControls.svelte#L29
https://github.com/sveltejs/sites/blob/70a2f338b5f49af4acf130a3127dda826175772b/sites/svelte.dev/src/routes/(authed)/repl/[id]/AppControls.svelte#L97-L100

Out of curiosity I dug a little deeper and it seems even down to the db level this should not be possible, the gist needs to belong to the current user https://github.com/sveltejs/sites/blob/06f0de39ac789617dcfa9b3f45261aafc507ff64/db/setup.sql#L143

Yeah, sorry for not closing this earlier, this doesn't actually happen (anymore?) I saw a post on Reddit about it (can't find it anymore), and tested it. That repl seemed to save edits by anyone.


Consume STDERR from ripgrep to allow indexing process to complete

Description of the Change
When indexing a project with a lot of broken symbolic links, the indexing process never completes. This is because the ripgrep process has written more data to its error output (STDERR) than the calling process has buffer to receive; until this buffer is cleared, the process will not terminate. The solution to this is to process the data on the receiving side.
This pull request adds a simple no-op handler for anything sent back on STDERR from ripgrep.
Alternate Designs
I considered logging the error output from ripgrep. This produced a lot of noise when running the test-suite and is unlikely to be of use for anyone in the real world. Logging the error messages returned from ripgrep is a trivial change.
Benefits
Indexing process always completes.
Possible Drawbacks
Diagnosing some issues may be difficult due to the lack of logging, however before this change any messages sent to STDERR were already being lost.
Applicable Issues
No obviously related open issues in this repository at time of opening this pull request. Lots of seemly-related external results when searching for this problem on the web.

Thanks for the contribution!  CI failure looks unrelated so we'll ask the other maintainers to take a look.

Thanks for the contributions 🙇  @fredden

Small note: if you are dropping stderr anyway, then you can use --no-messages (and possibly --no-ignore-messages) to tell ripgrep to be more quiet about file system related errors (and errors from parsing gitignore files).


Error while running example

Hi,
I tried running this:  cirro launch pbmc3k.h5ad --markers markers.json using the example data.
Got this error:
/home/parashar/miniconda3/lib/python3.7/site-packages/anndata/_core/anndata.py:21: FutureWarning: pandas.core.index is deprecated and will be removed in a future version.  The public classes are available in the top-level namespace.
  from pandas.core.index import RangeIndex
Traceback (most recent call last):
  File "/home/parashar/miniconda3/bin/cirro", line 10, in <module>
    sys.exit(main())
  File "/home/parashar/miniconda3/lib/python3.7/site-packages/cirrocumulus/__main__.py", line 20, in main
    cmd.main(command_args)
  File "/home/parashar/miniconda3/lib/python3.7/site-packages/cirrocumulus/launch.py", line 143, in main
    configure(args.dataset, args.spatial, args.backed, args.markers)
  File "/home/parashar/miniconda3/lib/python3.7/site-packages/cirrocumulus/launch.py", line 102, in configure
    key = os.path.splitext(os.path.basename(marker_json))[0]
  File "/home/parashar/miniconda3/lib/python3.7/posixpath.py", line 146, in basename
    p = os.fspath(p)
TypeError: expected str, bytes or os.PathLike object, not dict

cirrocumulus version: 1.1.7
Parashar

Thanks for reporting. This is fixed in 1.1.7.post1.