Update Documentation

Little change to make to smart-contracts more clear

Having these comments by itself to structure the code is not helpful I believe. Just a matter of time someone adds a modifier between the public functions or makes one of the public functions private.
If our goal is to make it super easy for a datascientist to grasp what the code does we should probably elaborate what a modifier or a public function is supposed to be.

I'm a big supporter of more comments / descriptions in this repo... @jeamick perhaps you'd be willing to elaborate in a bit more detail in your commenting?

sorry, @axelhodler  I wanted to make more changes in order to update the documentation of the functions just to be more clear about the code.

sorry @jeamick for the late answer. Feel free to improve any docs around here. The conflicts should be resolved though.
Aside from the above, can you think of a good way we could enforce the truth of the comments? Such as that no one would add non-modifiers under the /** Modifiers */ comment?

huh ? I didn't get really well what you were saying ...


dependencies: bump invenio-rdm-records to 0.15.0

This adds the version of invenio-rdm-records that has the bibliographic records Resource. It is now up to invenio-app-rdm to register it on the application.
From here on, @zzacharo is on it from what I understood. You can continue on this branch if you want, I won't touch it anymore.

@fenekku thanks a lot for all the pre work! :)

I think I will merge this and start from a fresh one just for convenience :)


haproxy fails to forward to virt-api in some cases

There are currently two scenarios where haproxy stops forwarding to virt-api:

virt-api pod not yet up (and service not ready) and you want to access it
kubernetes dns server is not reachable when we first try to access virt-api

If one of these situations happens you will get a "503" from haproxy and it will not retry.
We should probably take this to the haproxy mailing list too. I would expect haproxy to retry later on instead of stopping to work forever.

/cc @fabiand @stu-gott @admiyo

Could we add a little wrapper which retries our important urls - and if it fails, then the container fails, then kubelet will restart it.
Thoughts?

http://discourse.haproxy.org/t/resolvers-inside-kubernetes/916

@fabiand we can also do something like this: https://github.com/kubernetes/contrib/blob/master/ingress/controllers/README.md
with our haproxy. Basically when virt-api-server gets redeployed we restart haproxy ....

It does not seem to happen anymore. Closing it.


Initializer with showProgressGuide boolean does not work

I had to set the showProgressGuide after initialization for it to work, even when I set this value to true in the parameters for the initializer.

Hi, @Ahaubster.
I fixed this issue in https://github.com/kentya6/KYCircularProgress/commit/be2dab67748b6ec5a0bc5f8d716a1d5fc6bf3bc2.
Thanks. :+1:

Thanks! It works nicely.


fix(tutorials): use gdown to download files from Google Drive

Description
While trying examples in docker containers, it's inconvenience to download files directly from Google Drive. Besides, there is no Downloads folder in docker container, so users should modify the path by themselves. Suggest to use wget instead.
Refer to here for how to download files from Google Drive with wget.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.

[x] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[x] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kenji-miyake I've already tested the modification on the tutorial by my side. Would you please help me check whether there is anything I missed?

@evshary Ah, we should have updated the title. I applied minor fixes. Can I merge this?

@evshary Ah, we should have updated the title. I applied minor fixes. Can I merge this?

Sure, I forgot we don't use wget anymore 🤣


Few improvements

Add parsing to the editor’s preview (filter:parse.raw)

Add ability to set a title for the spoiler with >! (Title) Spoiler
Hidden:

Shown:

(The old behaviour still works if you don't include the title between the parenthesis)

Add 0.5s of delay before showing the spoiler to avoid viewing it by
accident

@psychobunny Check out the PRs for nodebb-plugin-spoilers

haha wow,
better late than never huh? thanks guys


Consider DateTimeHelper to be public as well as its UtcNowFunc

We are using IdentityServer in a time synchronized environment with a single IClock interface.
We would like to replace IdentityServer's clock source with ours, but DateTimeHelper.UtcNowFunc is not visible from our code (maybe a reflection hack woud do it, but that is not nice).

maybe we can get this in for rtm

Also, I believe having available the DateTimeHelper in the user code is beneficial, because the user extensions would use the same time source as the core implementation. Not to mention testing ...
Anyway, I'd be satisfied with just turning the keywords from internal to public. No need for a service oriented or DI way of doing that, which could pretty complicate the refactor of all the time using code ...
IMHO, the singleton solution is the way to go here, maybe with some rename only, st. like IdentityServerDateTime.UtcNow and .SetUtcNowFunc() or similar to suite your taste.
Thank you for your development and evolution!
I am learning from reading your code a lot.

I made them public.

Thank you!
Congrats to the fresh OIDC Certification! 🥇
Crossing fingers for the RTM on Friday
and Best Wishes for the New Year :)


Make ToC and RHS responsive panes hideable/adjustable as to not waste space in portrait mode [whole site]

The ToC pane on the left takes up too much room when viewed on a portrait mode monitor -- which otherwise is an excellent way to read documentation.
It would be great if one could (a) un-pin the ToC so that it collapses, (b) make the divider movable, or at least (c) shrink-to-fit so that there isn't any extra trailing whitespace preserved.
If I reduce the font size to try and add more main content, then I get a responsive right-hand column added with "Is this helpful?" and "in this article..." which is also not collapsible.
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f94a6e7d-3cb5-790c-2b8b-c09abd1de3f6
Version Independent ID: a0d381e1-07ad-9191-4697-6faf600a7bd8
Content: Use Azure Pipelines - Azure Pipelines
Content Source: docs/pipelines/get-started/pipelines-get-started.md
Product: devops
Technology: devops-cicd-get-started
GitHub Login: @steved0x
Microsoft Alias: sdanie

@thelazydogsback Thank you for the feedback.
It looks like you've encountered an issue with the product itself, rather than an issue with the documentation.
To solicit feedback from the product team, please use Report a problem or Suggest a feature in the Azure DevOps community and provide a link back to this issue.
For additional support options, please see Azure DevOps support.

@thelazydogsback Thank you for the feedback.
It looks like you've encountered an issue with the product itself, rather than an issue with the documentation.
To solicit feedback from the product team, please use Report a problem or Suggest a feature in the Azure DevOps community and provide a link back to this issue.
For additional support options, please see Azure DevOps support.

@thelazydogsback Thanks for your feedback; we appreciate it. You can submit issues related to overall site experience, or suggestions for improved site functionality or design, at https://aka.ms/sitefeedback/.


unexpected behaviour: gulp watch and gulp build at the same time

Sometimes when running gulp watch and gulp build at the same time the app/main/constants/config-const.js is emptied.

Ahhh is that why?! I was wondering why my const file was empty when I was running gulp build!

yeah, thats why. Unfortunately we cannot reproduce this issue continuously. Can you? Thanks for your help!

today I encountered this error as well while running both of the tasks at the same time.
[18:13:05] 'clean' errored after 1.76 s
[18:13:05] Error: ENOTEMPTY: directory not empty, rmdir '/Users/jonathan/Projects/m-way/qr-code-test/.tmp/main/styles'
    at Error (native)

+1 having this issue from time to time.

I have this problem too with the following versions
bash-3.2$ node -v
v4.2.1
bash-3.2$ npm -v
3.3.12

+1
Is there a way to "refill" the file?
Now I'm getting angular.js:68 Uncaught Error: [$injector:unpr] Unknown provider: ConfigProvider <- Config ...

We usually just use git and simply checkout the file.
 git checkout app/main/constants/config-const.js
you can generate a new file with the sub-generator:
yo m-ionic:constant config --template=config

Closing this one. Discussion moved the new collective ticket: https://github.com/mwaylabs/generator-m-ionic/issues/453


[VL] VeloxMemoryPool error

23/07/29 11:57:55 ERROR CoarseGrainedExecutorBackend: RECEIVED SIGNAL TERM
23/07/29 11:57:55 INFO YarnCoarseGrainedExecutorBackend: Got assigned task 4520
23/07/29 11:57:55 ERROR Inbox: Ignoring error
java.util.concurrent.RejectedExecutionException: Task org.apache.spark.executor.Executor$TaskRunner@6fe7e275 rejected from java.util.concurrent.ThreadPoolExecutor@4d543878[Shutting down, pool size = 1, active threads = 1, queued tasks = 0, completed tasks = 754]
	at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2047)
	at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:823)
	at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1369)
	at org.apache.spark.executor.Executor.launchTask(Executor.scala:270)
	at org.apache.spark.executor.CoarseGrainedExecutorBackend$$anonfun$receive$1.applyOrElse(CoarseGrainedExecutorBackend.scala:183)
	at org.apache.spark.rpc.netty.Inbox.$anonfun$process$1(Inbox.scala:115)
	at org.apache.spark.rpc.netty.Inbox.safelyCall(Inbox.scala:213)
	at org.apache.spark.rpc.netty.Inbox.process(Inbox.scala:100)
	at org.apache.spark.rpc.netty.MessageLoop.org$apache$spark$rpc$netty$MessageLoop$$receiveLoop(MessageLoop.scala:75)
	at org.apache.spark.rpc.netty.MessageLoop$$anon$1.run(MessageLoop.scala:41)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
23/07/29 11:57:55 INFO MemoryStore: MemoryStore cleared
23/07/29 11:57:55 INFO BlockManager: BlockManager stopped
WARNING: Logging before InitGoogleLogging() is written to STDERR
E20230729 11:57:55.618413 481318 Exceptions.h:68] Line: /opt/gluten/cpp/velox/memory/VeloxMemoryPool.cc:88, Function:~VeloxMemoryPool, Expression: 0 == remainingBytes (0 vs. 1589248) Memory pool op.1.0.0.FilterProject should be destroyed only after all allocated memory has been freed. Remaining bytes allocated: 1589248, cumulative bytes allocated: 31457280, number of allocations: 882, Source: RUNTIME, ErrorCode: INVALID_STATE
terminate called after throwing an instance of 'facebook::velox::VeloxRuntimeError'
  what():  Exception: VeloxRuntimeError
Error Source: RUNTIME
Error Code: INVALID_STATE
Reason: (0 vs. 1589248) Memory pool op.1.0.0.FilterProject should be destroyed only after all allocated memory has been freed. Remaining bytes allocated: 1589248, cumulative bytes allocated: 31457280, number of allocations: 882
Retriable: False
Expression: 0 == remainingBytes
Function: ~VeloxMemoryPool
File: /opt/gluten/cpp/velox/memory/VeloxMemoryPool.cc
Line: 88
Stack trace:
# 0  _ZN8facebook5velox7process10StackTraceC1Ei
# 1  _ZN8facebook5velox14VeloxExceptionC1EPKcmS3_St17basic_string_viewIcSt11char_traitsIcEES7_S7_S7_bNS1_4TypeES7_
# 2  _ZN8facebook5velox6detail14veloxCheckFailINS0_17VeloxRuntimeErrorERKSsEEvRKNS1_18VeloxCheckFailArgsET0_
# 3  _ZN6gluten15VeloxMemoryPoolD1Ev
# 4  _ZN8facebook5velox4exec4TaskD2Ev
# 5  _ZNSt16_Sp_counted_baseILN9__gnu_cxx12_Lock_policyE2EE10_M_releaseEv
# 6  _ZN6gluten24WholeStageResultIteratorD1Ev
# 7  _ZN6gluten35WholeStageResultIteratorMiddleStageD0Ev
# 8  _ZNSt8__detail16_Hashtable_allocISaINS_10_Hash_nodeISt4pairIKlSt10shared_ptrIN6gluten14ResultIteratorEEELb0EEEEE18_M_deallocate_nodeEPS9_.isra.0
# 9  _ZNSt10_HashtableIlSt4pairIKlSt10shared_ptrIN6gluten14ResultIteratorEEESaIS6_ENSt8__detail10_Select1stESt8equal_toIlESt4hashIlENS8_18_Mod_range_hashingENS8_20_Default_ranged_hashENS8_20_Prime_rehash_policyENS8_17_Hashtable_traitsILb0ELb0ELb1EEEE5clearEv
# 10 JNI_OnUnload
# 11 Java_java_lang_ClassLoader_00024NativeLibrary_unload
# 12 0x00007fa08d017a14

23/07/29 11:57:55 ERROR CoarseGrainedExecutorBackend: RECEIVED SIGNAL TERM

Was the executor process being manually killed?

There is no manual abort. Looking at the exception log of the stage failed container also found this @zhztheplayer
terminate called after throwing an instance of 'facebook::velox::VeloxRuntimeError'```

I got the same error.

https://github.com/oap-project/gluten/pull/2156/files

I got the same error.

Which version of Gluten are you using?

I got the same error.

Which version of Gluten are you using?

gluten 1.0.0.

I got the same error.

Which version of Gluten are you using?

It's strange, I'm normal on another machine. What environment do I need to configure before using Gluten? Such as GCC, arrow, etc....thanks

1.0.0 was known as having limited ability to avoid memory issues. Have you tried using current main branch? I assume issues like this one was expected to be solved already.


Refactor isDuplicated type

Hey, nice project!
I open this pull request to refactor isDuplicated  type, as I noticed that it is in fact used within HasDuplicatedNames to check for the presence of a Name in Names.
Hope I did not misunderstand its usage and that I am not breaking any additional functionality, but please let me know if any additional changes are required.

Committed a fix for the eslint error.

Hi, thanks for trying it out. I added some more tests.

Thank you, I will take another look within the week, otherwise I will close the pull request.

Gave it another try, just noticed another similar PR open that seems simpler :) Please feel free to close this one.

Yeah, thanks for trying anyway!


BUG: Fixed maximum update rate computation in ctkVTKAbstractView

Render window's DesiredUpdateRate property was used to determine maximum update rate of ctkVTKAbstractView. This had two issues:

VTK often significantly overestimates rendering time and so DesiredUpdateRate have to be set to quite low value (few fps) to get acceptable quality rendering. However, if ctkVTKAbstractView uses this value as maximum update rate, it would severely limit the achievable actual refresh rate. Separating the two values allow controlling quality settings and event compression separately.

When DesiredUpdateRate was set to "still update rate" (0.0001 fps; this is the default value) then rendering was never enforced. This caused indefinitely delayed rendering updates on MacOSX, when events were continuously generated on the GUI (e.g., by moving image slice selector slider continuously, see https://issues.slicer.org/view.php?id=4496). DesiredUpdateRate is set to 60.0 by default now, which results in smooth updates, while still effectively suppressing rendering request submitted in quick succession.

:+1:
Would also be great to fix the typo and squash with this commit

I won't have a chance to build and test until next week sometime, but this sounds great - I would vote for integrating this and testing it out in the nightlies.

Thanks @lassoan  :+1:
And thanks @sankhesh  for the comments.

However, GPU volume renderer provides very low quality rendering when desired frame rate is set to 30, while it can actually render in very high quality at 30fps (we just need to set desired frame rate to 1 FPS to get that).

That seems like an issue in the volume mapper logic. I remember that the mapper uses the
vtkRenderWindow's desired update rate along with the last frame render time to come up with the downsampling ratio. I think the issue might be with the first frame.

Should we create an issue in VTK tracker ?

Should we create an issue in VTK tracker ?

https://gitlab.kitware.com/vtk/vtk/issues/17324

We faced the same issue (GPU rendering not following the wanted FPS) and ended up patching the logic in
vtkOpenGLGPUVolumeRayCastMapper::ComputeReductionFactor(double allocatedTime)
Here is the method we used
void vtkOpenGLGPUVolumeRayCastMapper::ComputeReductionFactor(
  double allocatedTime)
{
  if (!this->AutoAdjustSampleDistances)
  {
    this->ReductionFactor = 1.0 / this->ImageSampleDistance;
    return;
  }

  if (this->TimeToDraw)
  {
    double oldFactor = this->ReductionFactor;
    double timeToDraw;
    if (allocatedTime < 1.0)
    {
      if( this->TimeToDraw == this->BigTimeToDraw )
        {
        timeToDraw = this->TimeToDraw;
        }
      else
        {
        timeToDraw = this->SmallTimeToDraw;
        }
      if (timeToDraw == 0.0)
      {
        timeToDraw = this->BigTimeToDraw / 3.0;
      }
    }
    else
    {
      timeToDraw = this->BigTimeToDraw;
    }

    // This should be the case when rendering the volume very first time
    // 10.0 is an arbitrary value chosen which happen to a large number
    // in this context
    if (timeToDraw == 0.0)
    {
      timeToDraw = 10.0;
    }

    double fullTime = timeToDraw / this->ReductionFactor;
    if (timeToDraw == BigTimeToDraw && allocatedTime > 1.0)
    {
      this->ReductionFactor = 1;
    }
    else
    {
      double l_wanted_fps = 1. / ( allocatedTime * 3. );
      double l_current_fps = 1. / timeToDraw;
      this->ReductionFactor *= l_current_fps / l_wanted_fps;
      this->ReductionFactor = vtkMath::Round( this->ReductionFactor * 50. ) / 50.;
    }
    // Clamp it
    if (1.0 / this->ReductionFactor > this->MaximumImageSampleDistance)
    {
      this->ReductionFactor = 1.0 / this->MaximumImageSampleDistance;
    }
    if (1.0 / this->ReductionFactor < this->MinimumImageSampleDistance)
    {
      this->ReductionFactor = 1.0 / this->MinimumImageSampleDistance;
    }
  }
}

To be compared with :
void vtkOpenGLGPUVolumeRayCastMapper::ComputeReductionFactor(
  double allocatedTime)
{
  if (!this->AutoAdjustSampleDistances)
  {
    this->ReductionFactor = 1.0 / this->ImageSampleDistance;
    return;
  }

  if (this->TimeToDraw)
  {
    double oldFactor = this->ReductionFactor;

    double timeToDraw;
    if (allocatedTime < 1.0)
    {
      timeToDraw = this->SmallTimeToDraw;
      if (timeToDraw == 0.0)
      {
        timeToDraw = this->BigTimeToDraw / 3.0;
      }
    }
    else
    {
      timeToDraw = this->BigTimeToDraw;
    }

    // This should be the case when rendering the volume very first time
    // 10.0 is an arbitrary value chosen which happen to a large number
    // in this context
    if (timeToDraw == 0.0)
    {
      timeToDraw = 10.0;
    }

    double fullTime = timeToDraw / this->ReductionFactor;
    double newFactor = allocatedTime / fullTime;

    // Compute average factor
    this->ReductionFactor = (newFactor + oldFactor) / 2.0;

    // Discretize reduction factor so that it doesn't cause
    // visual artifacts when used to reduce the sample distance
    this->ReductionFactor =
      (this->ReductionFactor > 1.0) ? 1.0 : (this->ReductionFactor);

    if (this->ReductionFactor < 0.20)
    {
      this->ReductionFactor = 0.10;
    }
    else if (this->ReductionFactor < 0.50)
    {
      this->ReductionFactor = 0.20;
    }
    else if (this->ReductionFactor < 1.0)
    {
      this->ReductionFactor = 0.50;
    }

    // Clamp it
    if (1.0 / this->ReductionFactor > this->MaximumImageSampleDistance)
    {
      this->ReductionFactor = 1.0 / this->MaximumImageSampleDistance;
    }
    if (1.0 / this->ReductionFactor < this->MinimumImageSampleDistance)
    {
      this->ReductionFactor = 1.0 / this->MinimumImageSampleDistance;
    }
  }
}

as it was back in VTK 8.1.1

Done


How to use SkypeCallMsg?

I want to track the moment of an outgoing call (when im press call) using SkypeCallMsg, but I can't, I'm following the documentation: https://skpy.t.allofti.me/_modules/skpy/msg.html#SkypeCallMsg
Please help.
P.S: Sorry if this question does not belong to this section

Please re-read the contributing guide and fill in the issue template as requested, as the only thing I've got to go on so far is:

I can't

To track any call, use the onEvent method. Check if the event is an instance of a SkypeCallEvent:
E.g
`import skpy
class SkypeCallHandler(skpy.SkypeEventLoop):
def __init__(self, username, password) -> None:
    super(SkypeCallHandler, self).__init__(username, password)

def onEvent(self, event):

    if isinstance(event, skpy.SkypeCallEvent):
        # your code
        pass

if name=="main":
username = "your_username"
password = "your_password"
main = SkypeCallHandler(username, password)
main.loop()`

From a quick test, it looks like Skype doesn't actually send a message event for initiating calls any more, only afterwards with a summary (what shows as the call duration or "Missed call"), so SkPy won't be able to tell when a call starts.

To check when a call starts, you need to check the state of the event.
  ```

.......
if event.msg.State.Started:
# do something
pass
elif event.msg.State.Missed:
#: do something
pass
elif event.msg.State.Ended:
#: do something
pass


MNK List

Is it possible to provide an MNK list (containing all MxMs) to make?

I think you are asking for Issue #42 (perhaps the title of the issue is somewhat generic). Although rather trivial to support, the importance of the issue has de-emphasized with JIT code generation becoming the default, and hence the issue is still not implemented (but nicely aged).
Let's clarify: are you asking for some simple file format to be supplied (to make) in order to specify kernels, which are then generated statically (at build-time of the library)?

Yes, that's what I am looking for.

just out of curiosity: why is the JIT compilation of the kernels not working/the best solution for you?
Thanks!

Side-note: v1.5.1 is around the corner. It will fix an issue with the Fortran interface in v1.5 (SMM functionality), where requesting a JIT kernel never returned a suitable PROCEDURE POINTER (always NULL).

I don't like to sit in the queue on a big supercomputer to find out that something went wrong generating the kernels on the fly. Also, do you support KNC/KNL (including coprocessor configurations) with JIT?

We do support JIT code generation for KNL, and this just carries forward to KNL cards as well. However, we have not played with KNL cards so far. Generating JIT code for and on KNL is in production e.g., with CP2K.
We do not support JIT code generation for KNC (neither native/self-hosted nor via offload); this is documented in our reference documentation.

Regarding "I don't like to sit in the queue on a big supercomputer to find out that something went wrong generating the kernels on the fly." - Do you have anything that does not work for you, or is there anything we can do to improve something?


⚠ Bofrost.lu has degraded performance

In bfdd0b9, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2801 ms

Resolved: Bofrost.lu performance has improved in 9cd8129 after 39 minutes.


Problem when testing trained agent

I am trying to learn imitation learning for robots, and I have tried to train an agent using diffusion_policy which was able to achieve a success rate of up to 0.96 when Rollout on the NutAssemblySquare task. I'm considering whether the agent has the ability to insert the nut into a target peg whose position has been changed, such as when I try to modify the coordinates of the peg in the pegs_arena.xml file.
In my practice, I move all the pegs to the left by some distance, however, from the trajectory during rollout, it seems that the robot still puts the nut into the original peg position without adapting to the change in the environment, which is supposed to be inconsistent with the effect of imitation learning.
I would like to know if it is reasonable for me to adjust the test environment in this way, is it the case that such a modification does not change the Obs? If there is a correct way, please guide me, thanks!

This is likely because (1) the agent never saw any variation in peg location in the training data and (2) the peg location is not given to the agent as an observation. This is likely a better question for the robosuite issues page, but I would start by modifying the environment to include peg information as an observation - you can see an example here.


feat(examples): add OpenShift examples and readme

Signed-off-by: Rick Rackow<EMAIL_ADDRESS>Since OpenShift has some different behavior especially around connecting to built-in services, it makes sense to have a separate Readme for it with examples adjusted to work on OpenShift. This PR adds exactly that: A readme and all files to deploy a running Pyrra on Openshift
cc @vrutkovs

The push error in the workflow isn't related to my change @metalmatze, but probably needs a bit of extra attention

Bummer. I thought I fixed that issue. We can safely ignore it.

The rest should be good, maybe @vrutkovs or @nautilux could run through the Readme on a cluster-bot cluster and see if it's working

We've successfully deployed this to our OpenShift cluster, but I can't confirm if the prometheus-operator logic works (the part where rules should be automatically picked up py prometheus-operator). We use standalone instances outside of the cluster looking in. We did however get the SLO definition deployed to Pyrra and using this https://github.com/pyrra-dev/pyrra/issues/314 we managed to generate the alert/recording rules outside of the cluster and then deploy them to the server with Ansible.


[SPARK-9397] DataFrame should provide an API to find source data files if applicable

Certain applications would benefit from being able to inspect DataFrames that are straightforwardly produced by data sources that stem from files, and find out their source data. For example, one might want to display to a user the size of the data underlying a table, or to copy or mutate it.
This PR exposes a sourcePaths method on DataFrame which attempts to discover the source data in a best-effort manner, by inspecting HadoopFsRelations and JSONRelations.

cc @marmbrus @rxin about exposing a new DataFrame API.

Merged build triggered.

Merged build started.

Test build #38665 has started for   PR 7717 at commit 0acd3ad.

Test build #38665 has finished for   PR 7717 at commit 0acd3ad.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Renamed to inputFiles and updated description.

Merged build triggered.

Merged build started.

Test build #38705 has started for   PR 7717 at commit ff67430.

Test build #38705 has finished for   PR 7717 at commit ff67430.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

The API change LGTM.


Are we able to get alerts?

Is there a way for this app to send push notifications of alerts?

Duplicate #14


REST API select * from table

I'm looking for a REST API call to retrieve rows from a table where I do not know the value of the primary keys.
In cqlsh, I can do the following:

SELECT * FROM users_keyspace.users ;

Is there a way to do something similar through the REST API?

Yes. In v1 you can leave off the primary key entirely and use /v1/keyspaces/{keyspaceName}/tables/{tableName}/rows.

Thanks @dougwettlaufer !
That worked exceptionally well. And I see &pageSize=20 will give me the first 20 rows.
Is there a way to get the last 20 rows from the table?

Is there a way to get the last 20 rows from the table?

No, sorry. If this is a frequent query pattern I believe creating your table with a descending clustering order should do the trick.

That can work. Thanks!


Apply GIGS tests

Execute the Geospatial Integrity of Geoscience Software tests. This require completion of task #10, in order to use the tests defined in GeoAPI 3.1/4.0.

The tests are not complete, but geoapi-4.0 branch can now execute the tests that we have.

GIGS tests have been removed from GeoAPI and will need to be removed from PROJ-JNI geoapi-4.0 branch. Those tests moved in a new project hosted by IOGP, the organization that created the GIGS tests in the first place:
https://github.com/IOGP-GIGS/GIGSGeoAPI


Field for local identifier

There should a field in the csv schema to store the local identifier code for a public body, if available. This would make it possible to later create a global identifier (as per #41) and also to keep track of bodies that change names.

Including a local identifier used by governments would also make it easier to cross this dataset with other official datasets that make references to them.

Sounds very wise. There's a column for local identifier ID in the ones I'm uploading for Sweden soon.

@augusto-herrmann +1 - can you do a PR for any changes you want here.
Also @augusto-herrmann would you interested in becoming the "maintainer"  for Public Bodies project? http://okfnlabs.org/projects/publicbodies/

Thanks. For the past couple of years, I have been able to give attention to this project only once every few months. If it's ok not having to be more regular, I'd be fine to becoming a "maintainer". In any case it would be good to have more than one maintainer in the project in order to respond to issues and PRs more quickly than I'm able to.

@augusto-herrmann Excellent, @augusto-herrmann.  Whatever time you can spare is much appreciated :).
To make it official, can you add yourself to the okfnlabs site?  http://okfnlabs.org/members/signup/

Sorry for the delay, but now it's done. Next I'll do a PR of the actual issue being discussed here. @rgrp , you can assign this issue to me as per your suggestion.


Fix Webflux plugin throw ClassCastException when defining a filter

Please answer these questions before submitting pull request

Why submit this pull request?

[x] Bug fix

[ ] New feature provided

[ ] Improve performance

Related issues
https://github.com/apache/skywalking/issues/3392

Bug fix

Bug description.

How to fix?
Enhance classes that cannot be cast

Resolves #3392

/run ci

All fail somehow :)


Testcafe stops working after redirect

Are you requesting a feature or reporting a bug?
Bug
What is the current behavior?
Testcafe stop working after redirect happens.
What is the expected behavior?
Testcafe should be able to continue testing after the redirect
How would you reproduce the current behavior (if this is a bug)?
The problem seems to be related to a redirect code. If I set the fixture page like the example below:
fixture(`Bank`)
    .page("http://localhost:8080/#/bank")

My frontend application will see the user is not authenticated and will redirect to "http://localhost:8080/#/login". See the code below:
location.href = "/#/login";

Before each test, I have a helper function that checks if the user is in the login page, and if it is, perform the authentication and finally redirects the user to the original page. And here is where the problem happens. After the redirect to the login page, the testcafe actions simply stop working. If I change the fixture page to start at the login page, instead of trying to access to target page and execute the exact same code, everything works fine.
Important: Maybe the problem happens because I am using hashcode URLs
Provide the test code and the tested page URL (if applicable)
Tested page URL:
Test code
const login = async (t) => {
    const getLocation = ClientFunction(() => document.location.href.toString());

    await t.wait(5000)
        .typeText(Selector('#email'<EMAIL_ADDRESS>        .typeText(Selector('#password'), "1")
        .click(Selector('#login_btn'))
        .expect(getLocation()).contains("/dashboard");
}

const loginAndNavigate = async (t, url) => {
    await login(t);
    await t.navigateTo(url);
}

const loginAndNavigateIfNeeded = async (t, url) => {
    const isLoginPage = await Selector(".login-form").exists;

    if (isLoginPage) await loginAndNavigate(t, url)
   else await t.navigateTo(url)
}

const baseUrl = "http://localhost:8080"
const targetUrl = `${baseUrl}/#/bank`

fixture(`Bank`)
    .page(targetUrl)
    .beforeEach(async t => await loginAndNavigateIfNeeded(t, targetUrl))

test("Bank test", async t  => {
    console.log("test failed before getting here...");
})

Specify your

operating system: linux mint 18
testcafe version: 0.18.2
node.js version: 7.9.0

Hi @leonardocaldas,
Does your app have a public url? If yes we can check the issue on our side.

the testcafe actions simply stop working

Could you please clarify what happens there? Does the test execution just hang or it fails with some error?
What the stack do you use in the app (some frameworks like Angular or any other)?

Additionally please run your test with opened browser developer tools and take a look are there any js-errors there?

Hi Alexander,
Even I am facing this issue.
I have a private URL(Corporate URL) which redirects you automatically to the authentication page when I try to access it through my Test Cafe script.On providing the credentials and clicking the submit button it again tries to redirect to the private URL which I was trying to access initially but it is unable to load the target URL page and keeps on loading the page forever.
This is a showstopper as it does let you access the URL page which is supposed to be tested.
The target URL which I am accessing is an Angular UI.
Please look into this issue at the earliest.
Thanks & Regards,
Vikram Aditya

I am also seeing an error, after I let the test click the login button and the redirect happens.
The following error message is printed within the browser window as well as the testcafe CLI:

Hi @thomasbrueggemann,
I've prepared a build with a possible fix for your problem. Could you please check it?

Download an archive packed by npm from dropbox;
Install it on your machine:
npm install testcafe-0.18.5-custom20171120.tgz -g for global installation or
npm install testcafe-0.18.5-custom20171120.tgz for local.

Please let me know whether it work properly now on your side. If yes we'll add this fix to the sources.

Thanks for the effort, @AlexanderMoskovkin .
I used the custom build you provided and it resolved the above mentioned error regarding "testCafeCore" but it prompts me another error now:
Uncaught TypeError: t is not a function
For a testcase such as:
test("Open showMap.aspx", async t => {
	await t
		.typeText($("#txtUsername-inputEl"), "****")
		.typeText($("#txtPassword-inputEl"), "****")
		.click($("#btnLogin"))
		.expect($("#Header2").exists)
		.ok();
});

as soon as the page redirects after it clicking on the #btnLogin. So up until then, the t is valid. Do you have an idea?

Hi @AlekseyMartynov!
Right now I'm using Vue.js. I'll test again with your custom build and get back to you.
Thanks.

Uncaught TypeError: t is not a function

@thomasbrueggemann Could you please provide the full error message with callstack? You can just take a screenshot of the console

I'll test again with your custom build and get back to you.

@leonardocaldas I'm not sure that this custom build will help for your case because it's created based on  the error in the browser provided by @thomasbrueggemann.
To try to find the cause of the issue on your site could you please answer the questions:

the testcafe actions simply stop working

Could you please clarify what happens there? Does the test execution just hang or it fails with some error?
Additionally please run your test with opened browser developer tools and take a look are there any js-errors there?

@AlexanderMoskovkin We could also switch to a seperate issue, just thought it might be related to the title here.

The error appears in the second that TestCafe clicks on the login button and disappears in a blink of an eye when the reload to the logged-in-page happens. But nevertheless shows the test as failed in the terminal-console.

@thomasbrueggemann, Yes, please create a separate issue with this screenshot. It seems we've reproduced this js-error appearing and will investigate it soon

I'm closing this since there were no activity about an initial issue here for a long time. Feel free to reopen the issue if it's still needed.
Also, you can try to run your tests on the latest TestCafe version.


Block inheritance

Hi.
What this article doesn't clarify is whether setting "Block inheritance" on a OU will then block any other GPOs outside that OU, for example, a user logon script GPO applied to a user in a completely different parent OU that logs into a machine located in an OU that has block inheritance turned on. I would think that every other GPO would be blocked from that OU going up, and even any other GPOs from any other OUs that are at the same level as the parent OU of the sub-OU that has blocked inheritance turned on.
Is that correct?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9530a35b-23e4-fcc9-bb1f-b4954bb597d0
Version Independent ID: e4e678b7-3d27-8cd2-a3a7-0c14056e8f79
Content: Security policy settings (Windows 10)
Content Source: windows/security/threat-protection/security-policy-settings/security-policy-settings.md
Product: w10
Technology: windows
GitHub Login: @Justinha
Microsoft Alias: justinha

@officedocsbot assign @e0i

@Justinha Would you be able to provide directions in clarifying this questions if the time permits? Thank you.

@SirJewDanielBerg Thanks for the feedback and sorry for delay. Yes, you are right. If you want to submit a pull request for this, we can review and merge. To my mind, the point you are raising is more relevant to a topic about how GP works rather than any specific Security Option policy. Maybe add a link to https://blogs.technet.microsoft.com/musings_of_a_technical_tam/2012/02/15/group-policy-basics-part-2-understanding-which-gpos-to-apply/ for example?

@SirJewDanielBerg Thank you for reaching out to help improve MS Docs.  Please let me know if the link from @Justinha helps answer your questions, and I will have the link added to the article.

@SirJewDanielBerg
Upon your feedback, We have updated the content with relevant changes accordingly. Thanks.

@officedocsbot close


Fixed bug with incorrect Router Id 62.

This PR fixes issue #597.

Current coverage is 65.09% (diff: 82.43%)

Merging #625 into master will decrease coverage by 0.02%

@@             master       #625   diff @@
==========================================
  Files            98         99     +1
  Lines         14379      14382     +3
  Methods        1971       1972     +1
  Messages          0          0
  Branches       1683       1683
==========================================
- Hits           9364       9362     -2
- Misses         4480       4483     +3
- Partials        535        537     +2

Powered by Codecov. Last update e74bee4...bcfeb6d


Failed unit test shows no information about the cause

This issue was originally filed by @zoechi

What steps will reproduce the problem?
1.
I have unit test that I run with Dartium.
When a test fails because of an exception or for example
expect(false, isTrue)
Dartium shows
FAIL
Total 1 passed, 1 failed, 0 errors
but no further indication about what went wrong.
2.
3.
What is the expected output? What do you see instead?
Stack trace
or a message 'expected true but was false' or similar
What version of the product are you using? On what operating system?
Dart VM version: 1.4.0-dev.2.2 (Tue Apr 15 11:17:30 2014) on "linux_x64"
Please provide any additional information below.

This issue has been moved to dart-lang/test#249.


x/tools/gopls: initial support for pull-based diagnostics available in LSP 3.17

LSP 3.17 adds support for Pull Diagnostics
The spec includes Document Diagnostics, Workspace Diagnostics.
I think this allows us to address some long-standing issues like

https://github.com/golang/vscode-go/issues/50 Support a setting to control the frequency of diagnostics
(some users want to see diagnostics only when they save a file, not as they type
https://github.com/golang/vscode-go/issues/1275 Option to run diagnostics only on current package

Partly

https://github.com/golang/go/issues/42527 Support diagnostics for files inside vendor directories
https://github.com/golang/go/issues/45607#issuecomment-823694873 Fine-grained control on diagnostics

For now, I'm going to restrict this to "initial support", because while there is more to do, we have enough to get started integrating with internal systems that need pull diagnostic support. I'll open up a follow-up issue for more TODO items.
Therefore, this is done.


Test for esoteric double parse accuracy

This looks like it is failing on Azure?

Yep this is the issue I mentioned on slack. Vs2017 produces a different result to all other compilers by 2ulp for that case.
Not sure where we go from here.

Can we increase the tolerance just for VS2017 and earlier?


Mapping UI Usability Issues: Predicates

From @siuc-nate
Clicking on a drop-down list causes the list of options (which has a much narrower width) to appear above the box and animate downwards. I assume the intended animation here was to have it show up behind (and be cropped by) the box?

I think this is personal preference not a bug, I like how it is. Anyway, it'll likely change when other features come in around alignment. Making priority 3.

UI has changed since this was raised


Add meta option to group input variables

Implemented "-meta" option used inside of libFM to group input variables.
Meta argument accepts numpy array or python list.

Sorry for the delay, I was on vacation.
Thank you for the contribution!

Sorry to go back to this PR @hasoya but could you:

Update the README (Usage and Future Work section) and;
Provide an example/instruction on how to use the meta flag?

Thank you!


Unable to authenticate login to rancher UI when multiple browser Windows are opened

What kind of request is this (question/bug/enhancement/feature request):
BUG
Steps to reproduce (least amount of steps as possible):

Setup Rancher 1.6.24 with local auth
Open two or more browser Windows and go to Rancher login page
Click Login

Result:
Can not login to Rancher.
Environment information

Rancher version :
rancher/server:v1.6.22 to v1.6.24
Installation option (single install/HA):
HA

@loganhz

This is the same as https://github.com/rancher/rancher/issues/15869


Handle email already registered error better instead of throwing an error

This has been reported a handful of times by Sentry: https://sentry.io/organizations/member-matters/issues/1783504244/

Done


grouping requests by resource name (first path segment)

for example, these requests are now grouped in group '/user'

/user/login
/user/logout
/user/{id}/posts

@nosyjoe We are currently working on API to let importers expose UI options to the user before they import. Is it ok if we wait on this pull request until 2.3.3 then we can have this as an option for users to configure?

@hishnash oh nice, options, I like that! sure, let's wait for 2.3.3 for this.

fixed in v2.2.0


Follow up on IR and using a tool like Webflow

https://webflow.com/ is a great tool that I often hear people using to make simple marketing sites like essential.cu.edu but not have to worry about the dev side of things.
The biggest pain point in recent years has been the "design to dev" process, especially when the changes are one CSS property, and there are many issues where only one might be suggested.
While it might seem like it is quicker for a developer to handle the task, when you account for review time, pushing updates, design review, etc, the process is not quick at all.
Contrast that with a tool like Webflow where the content creator and designer can work within the tool that actually deploys the code right off the bat.
As a developer, I can help with training on parts of a tool, but the UI is very similar to a design tool like Sketch or Photoshop, and you can click to edit items so people don't have to figure out where bits of data come from.
I estimate IR21 cost would cost well over $100K if paying the market rate to a vendor whereas using something like Webflow will end up costing a fraction and free up CU employees to do other tasks.
Acceptance Criteria:

[ ] Try out Webflow via the tutorial
[ ] Potentially list other tools
[ ] Think about the need to write code at all. Is this way of working really needed to produce a good Impact Report?

@ktheiler @tskillern @duquennoisa @Feissit  I'd like to get your thoughts on what I wrote above. I know there is talk of "sunsetting Essential CU", potentially expanding Odder use, and that you are all busy, but for the past two years, the IR has snuck up on me at least and ended up in a situation with the tech stack that was not ideal but had to be used to finish the project.
I truly think a simple tool like Webflow is a great fit for projects like the Impact Report and the past two years have been way overkill on the tech end at the same time as limiting design and content. There are plenty of other tools to look at, but Webflow is my top recommendation.
Anyhoo, I had this note sitting around so I made it into an issue, and now I have creating this issue off of my todo list. I would have added Sue but she just started and I'm not sure if working with Donor Comms on GitHub will continue, especially if no code is involved in the future.

Hi @tskillern @duquennoisa @Feissit (and we'll need to get Sue on this thread), @alexfinnarn and I are going to set up time in late April or early May to review the CMS tool(s) for consideration (ie Webflow and possibly Odder - at least want to talk about Odder and it's functionality) so that we can figure out that aspect of the IR project well in advance of starting the nuts and bolts of design and content.

Yes, this works for me. Just so everyone knows (I told Katie separately): There are security review and procurement steps related to something like this. Those can take a while and could affect timelines.
From: ktheiler @.>
Date: Thursday, April 7, 2022 at 12:18 PM
To: CUCentralAdvancement/essential-cu @.>
Cc: Tim Skillern @.>, Mention @.>
Subject: Re: [CUCentralAdvancement/essential-cu] Follow up on IR and using a tool like Webflow (Issue #552)
Hi @tskillernhttps://github.com/tskillern @duquennoisahttps://github.com/duquennoisa @Feissithttps://github.com/Feissit (and we'll need to get Sue on this thread), @alexfinnarnhttps://github.com/alexfinnarn and I are going to set up time in late April or early May to review the CMS tool(s) for consideration (ie Webflow and possibly Odder - at least want to talk about Odder and it's functionality) so that we can figure out that aspect of the IR project well in advance of starting the nuts and bolts of design and content.
—
Reply to this email directly, view it on GitHubhttps://github.com/CUCentralAdvancement/essential-cu/issues/552#issuecomment-1092062304, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQWLOG42NPTB2U3P74XDYB3VD4RHNANCNFSM5STO6ZNA.
You are receiving this because you were mentioned.Message ID: @.***>


Even More Arities

Description
Add sixth and seventh arity implementations.
Type of Change

[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

[x] I have read the contributing guidelines
[x] Existing issues have been referenced (where applicable)
[x] I have verified this change is not present in other open pull requests
[x] Functionality is documented
[x] All code style checks pass
[x] New code contribution is covered by automated tests
[x] All new and existing tests pass

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (41968af) 100.00% compared to head (858af91) 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##              main       #12    +/-   ##
==========================================
  Coverage   100.00%   100.00%
==========================================
  Files            2         2
  Lines          270       445   +175
  Branches        11        15     +4
==========================================
+ Hits           270       445   +175

Impacted Files
Coverage Δ

src/LazyCart/LazyCartesianProduct.cs
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


AuthorizationFailed

Repro steps:

Action: azureFunctions.deploy
Error type: AuthorizationFailed
Error Message: The client<EMAIL_ADDRESS>with object id '545105db-ac40-4672-a22a-e3c300f70c8a' does not have authorization to perform action 'Microsoft.Storage/storageAccounts/write' over scope '/subscriptions/b8f2ff04-0a81-4cf9-95ef-5828d16981d2/resourceGroups/COSMOS_RG_East_US_2_10f09450-8ea8-419e-aac5-7aef97f5db13/providers/Microsoft.Storage/storageAccounts/bassboy' or the scope is invalid. If access was recently granted, please refresh your credentials.
Version: 0.20.0
OS: win32
Product: Visual Studio Code
Product Version: 1.40.0
Language: en

Call Stack
extension.bundle.js:218:738885extension.bundle.js:218:738885
s extension.bundle.js:218:111766
s extension.bundle.js:164:25792
extension.bundle.js:164:27034extension.bundle.js:164:27034
o extension.bundle.js:164:670342
extension.bundle.js:164:24705extension.bundle.js:164:24705
$._callback extension.bundle.js:1:636382
$.t._callback.t.callback.t.callback extension.bundle.js:194:5590
$.emit events.js:200:13
$.<anonymous> extension.bundle.js:194:18450
$.emit events.js:205:15
IncomingMessage.<anonymous> extension.bundle.js:194:17282
Object.onceWrapper events.js:288:20
IncomingMessage.emit events.js:205:15
endReadableNT _stream_readable.js:1154:12

@bassyboy can you try using Advanced create? For example if your subscription doesn't have permission to create a storage account, that will let you select an existing account. We're tracking improvements to basic create here: https://github.com/microsoft/vscode-azurefunctions/issues/1583


Going back from zoom causes history loop

When going into zoom and clicking NASPÄŤ the history becomes looped due to funky Url::Previous behaviour.
Could be solved by swapping relevant line with JS history call.

thank you @bliker for reporting
fixed with 3a8f430decbd567ca07fbb4e2c567f483aef1d85
good point! ;)


lean_nat_mod returns a wrong value (proof of False)

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Checked that your issue isn't already filed.
Reduced the issue to a self-contained, reproducible test case.

Description
On a 64-bit platform, the C++ implementation of Nat.mod returns a wrong value when the dividend is big (not scalar) and the divisor is medium-sized (more than 2^32 and less than 2^64).
I think this get_unsigned_int is wrong when sizeof(size_t) > sizeof(unsigned int) and the result is truncated:
https://github.com/leanprover/lean4/blob/a62949c49b4f631624fe33315f04b738f0cce349/src/runtime/object.cpp#L1115
Steps to Reproduce
Proof of False:
def dividend := 2^65
def divisor := 2^33+1

def correctQuot := 2^32-1
def correctRem := 2^32+1
def wrongRem := 1

theorem correct₁ : dividend / divisor = correctQuot := rfl
theorem correct₂ : dividend = divisor * correctQuot + correctRem := rfl

theorem wrong : dividend % divisor = wrongRem := rfl

theorem unsound : False := by
  have : wrongRem = correctRem := by
    have h := Nat.div_add_mod dividend divisor
    rw [wrong, correct₁, correct₂] at h
    apply Nat.add_left_cancel h
  contradiction

Expected behavior: 2^65 % (2^33+1) =  2^32+1
Actual behavior: 2^65 % (2^33+1) = 1
Versions
Lean (version 4.0.0-nightly-2022-08-04, commit 9e69259f8343, Release)

Thanks for reporting this serious issue and finding where the bug is.


test: pkg/configurator IsPrivilegedInitContainer()

In pkg/configurator IsPrivilegedInitContainer() does not have good unit test coverage.
It would be great to write a small test for this function.

ref #1489


DRILL-4990:Use new HDFS API access instead of listStatus to check if …

…users have permissions to access workspace.
Manually tested the fix with impersonation enabled. All unit and regression tests pass.

I did not add new unit tests because existing tests already provide enough coverage and they run on local file system.

LGTM

This pull request was never merged because of a problem with windows test setup we have.  As a workaround, I added code to fall back to using old API if new API fails for some reason. All tests are passing fine with this change.
This is nice to include in 1.12 as it provides performance improvement for all DFS based queries especially when there are large number of files.
Can we review the new diffs please ?

@sohami Sorabh, since you reviewed the original pull request, can you please review the updated diffs ?

Based on the last in-person discussion it was decided to further look into why the test was failing on Windows platform. Is it the test environment setup issue or an actual issue w.r.t platform implementation of access method ?

You can close this PR, @ppadma .
This seems to have been resolved by @chunhui-shi 's commit (#1032) for DRILL-5089.
https://github.com/ppadma/drill/commit/18a71a38f6bd1fd33d21d1c68fc23c5901b0080a#diff-b89fd230da4ac69b7a8b6caf7677f77a

this issue is addressed through another PR #1032. closing it.


Add credentials input

At this moment the preview action supports connecting DockerHub and GHCR credentials. It must support credentials for other types of registries too (Google, Amazon, Azure, custom docker registries).

Should be tested together with https://github.com/UffizziCloud/preview-action/issues/16
See the above task for description

TESTED - OK


Error with 'drupal_deploy_updated'

Issue Type

Bug Report / Support Request

Your Environment
$ vagrant --version
Vagrant 1.9.7

$ vboxmanage --version
5.1.4r110228

$ ansible --version
ansible 2.4.0

Your OS

macOS (version)

error output
TASK [geerlingguy.drupal : Define drupal_deploy_updated] *********************** fatal: [fbm_vm]: FAILED! => {"failed": true, "msg": "the field 'args' has an invalid value, which appears to include a variable that is undefined.The error was: 'drupal_deploy_repo_updated' is undefined\n\nThe error appears to have been in '/drupal-vm/provisioning/roles/geerlingguy.drupal/tasks/main.yml': line 24, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Define drupal_deploy_updated\n  ^ here\n\nexception type: <class 'ansible.errors.AnsibleUndefinedVariable'>\nexception: 'drupal_deploy_repo_updated' is undefined"}
Summary
Fresh install, latest and greatest, I keep running into this error about 'drupal_deploy_updated'

It looks like you may be running Ansible 2.4, which is still a pre-release (alpha/beta quality), and there are definitely going to be some weird issues until it's more stable.
Can you switch to a stable version (current is 2.3.1) and see if you get the same error?
Also, probably unrelated, but it looks like you're running an old release of VirtualBox (5.1.4); the latest is 5.1.22: https://www.virtualbox.org/wiki/Downloads

I'll close this as there hasnt been any response since July.


Check dependencies

Fybrik assumes the existence of Vault and datashim for some of the modules.
Requirements and instructions for datashim deployment are not evident in the Fybrik documentation.
Fybrik doesn't check that datashim is deployed, and if storage_provisioning tries run CreateDataset eventually the application gets the following status error:
Status:
  Asset States:
    New - Data:
      Conditions:
        Status:   False
        Type:     Ready
        Status:   False
        Type:     Deny
        Message:  An error was received for asset new-data . If the error persists, please contact an operator.Error description: no matches for kind "Dataset" in version "com.ie.ibm.hpsys/v1alpha1"
        Status:   True
        Type:     Error
      Endpoint:
        Name:

The issue is related to the wider discussion about usage of datashim. But if we continue to use it, we have to update documentation and add prerequirements checks with relevant error messages. (the same for Vault)

We no longer use datashim. Is this issue still relevant?

No, it is not.


@azure/msal-react: usable or time frame for release?

Please follow the issue template below. Failure to do so will result in a delay in answering your question.
Library

[ ]<EMAIL_ADDRESS>or<EMAIL_ADDRESS>[X]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>
Description
Please provide your question here, including as much relevant details as possible.
I see a number of branches referencing @azure/msal-react. I'm mostly curious what the state of it is: is it usable or a time frame for it being released?
I ask because this tutorial doesn't seem to be up-to-date:
https://docs.microsoft.com/en-us/graph/tutorials/react
The examples in this repo primarily deal with VanillaJS.
This repo says it will be deprecated when @azure/msal-react is released so I'm reluctant to use it for that reason and given it is also based on<EMAIL_ADDRESS>https://github.com/syncweek-react-aad/react-aad#readme
At any rate, having a hard time getting this working in my CRA app with the examples provided, so thought I'd ask about the availability of it.

@cheslijones We have an updated roadmap available here. We're working to have a preview version available by November.

@jasonnutter Got it, thanks.


Increase number of max connections to 8192

How to categorize this PR?

/area networking
/kind enhancement
What this PR does / why we need it:
This PR increases the number of max connections for envoy-proxy sidecar in vpn-seed-server to 8192.
We saw on some shoot clusters that the default value of a maximum of 1024 connection was not sufficient for the envoy-proxy and led to a lot of 408 errors because the buffer of the envoy-proxy was overflowing.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

The number of max connections for envoy-proxy sidecar in vpn-seed-server is now increased to `8192`.

/milestone v1.40


[Beacon API] id_to_state_root function

We have different ways to address states:

[ ] "genesis" literal. This represents the genesis state according to the node.
[ ] "justified". This represents the last justified state according to the node.
[ ] "finalized". This represents the last finalized state according to the node.
[x] "head" string. The current head state according to the node.
[ ] by a root. The most direct addressing is the root of a state.

We can have a parser in beacon_api/utils.ex:
parse_id("genesis") -> :genesis
parse_id("justified") -> :justified
parse_id("finalized") -> :finalized
parse_id("head") -> :head
parse_id("0x" <> hex_root) -> <<root>>
parse_id(other) -> :invalid_id

We can then have a root_by_id(id) function that takes any of the previous results and returns a root that can be used to get a state using the db.
root = Utils.parse_id(id) |> ForkChoice.Utils.root_by_id()

The checkboxes in the issue mark the completion of each specific parsing and root_by_id clause. This task will be considered finished when the get_state_root endpoint of the beacon api uses this function.

there is an additional case when the binary does not start with 0x it could be the slot that has to be parsed into ~Types.slot`


Proxy service readme - autoprovisioning - unclear text

There are two statements in the proxy readme in section Automatic User and Group Provisioning that sound contradictionary and need clarification. This was found by @kobergj reading the admin docs PR.
This is a copy/paste of the finding:

you must ensure that the user's email address or username never changes.

Later you state:

If the user does already exist, the proxy will check if the user's email or displayname has changed and updates those accordingly via graph service.

So what is it now? Do I need to take care the email never changes or will it be updated automatically?
@rhafer @micbar pls help sorting this out

I made a comment here https://github.com/owncloud/docs-ocis/pull/912#discussion_r1678915286
which might help or confuse the discussion.

I made a comment here owncloud/docs-ocis#912 (comment) which might help or confuse the discussion.

Your comment is exactly right. I'll try to come of with some additional working to clarify in the README


add permissions to allow oidc

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.56%. Comparing base (232c9b1) to head (84c4402).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #705   +/-   ##
=======================================
  Coverage   83.56%   83.56%
=======================================
  Files          36       36
  Lines        1813     1813
=======================================
  Hits         1515     1515
  Misses        298      298

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Reporting rates: HIV, PMTCT, TB Trends chart (and other similar) doesn't show, while other charts show

Looks like the API is working for some URLs but not for other ones. Review if we can get it working with css+html or with png, or with api/25

Server response wrong images, I have created an issue in JIRA
https://jira.dhis2.org/browse/DHIS2-1922


page-break-inside: avoid is erratic

I have a complex html template that I am converting to a pdf. It has icons created from several absolute positioned elements. I do not want the page to break in the middle of these icons. I am using css to tag the icon container with "page-break-inside: avoid". When I print the html from the browser, the page breaks work correctly so I'm confident the css is correct. But when the pdf is rendered this css is not honored and the page breaks split the icons.

I am using the same css on another container that contains only text and the page breaks properly around it.
So my question: is there anything in node-html-pdf that would keep certain elements from honoring the css?
I have tried adjusting the page height, format, borders, css and have seen no change to the icon issue.

I'm using those css rules page-break-inside: avoid and page-break-before: always but It does not seems to work at all. I need to handle the page break mostly for big tables. Is there a solution for that ?

Also unable to get custom fonts to work. Looks like we will be switching to a different tool unless these issue can be fixed.

I ended up using wkhtmltopdf. There is an npm package which make the interface between the binary and your node module. I can use custom font, and the page breaks (in or out of table) work like a charm. I don't know about the absolute elements, but you can give it a try.

lol. I initially used this module because I wasn't able to get wkhtmltopdf to work at all.
this module should work with custom fonts though.
Regarding the page-break-inside issue, you can try to use position: relative on the parent element and on the element you have the css rule.
Apparently that worked for some people: https://github.com/ariya/phantomjs/issues/13524#issuecomment-269029693
Sorry for the issues. I can't do much to fix those. Maybe we can put together a list with all the issues, so people are aware of them when they try to use this module or another one based on phantomjs.

@marcbachmann In fact the linked module is only an interface between the binary and the node application. You have two options, install wkhtmltopdf on your environment, or define the path of the binary to use. In my case it was the second option, as I'm making a nwjs application which must embed the binary. Anyway what you are proposing could also be a great option, in my case it wasn't really what I needed.

For me, it breaks in the middle of line 14, I have no idea to prevent this although I also tried with page-break-inside or page-break-after. It's better if the line 14 will be in next page. Any idea?

It just ignores the page-break-inside property....

I have the same issue, regardless of browser used. in a webapp. Even when I say media="print" the print-window/-console does not adhere to the setting, in any browser on Windows. Very frustrating, even making all elements display:block; (which is a prerequisite). It does not matter if I try this on a Hx, p, table, tr, td or div, on all HTML-tags this CSS-setting is ignored. Anyone having this working anywhere?

Has anybody found a solution to this issue?

I solved it by adding the following css class to the element you prefer not to break (say the inner-most div you wish to keep in tact):
.no-page-break {
    position: relative;
    page-break-inside: avoid;
}

I have seen it in this StackOverflow post .
There are some drawbacks but since this is headless chrome, we are safe.
**Notice it is said that there that the parent must not have position: absolute (I haven't tried it yet).

In my case, the problem was a parent element with display: -webkit-box;. It seems page-break-inside is incompatible with a flexbox layout, and it started working as intended after I changed the parent to display: block;.

I had many tables in the page and I solved it by using
table {
page-break-inside: avoid;
display: block
}
See image below:

Has anybody found a solution to this issue?
This problem is still relevant.

Has anybodoy another working solution?

@augustosnk12 I noticed that flex-direction: column was causing me this type of problem. I removed all the flex columns and now it respects the page-break-inside: avoid;

@vasco3 Thanks for the answer but I'm not using any flexbox in my code... :'(

@augustosnk12 are you using grid?

@vasco3 I'm using tables

Avoid to use thead. It work to me while text inside thead become double at the end of page and the top of page below.

I've tested the html in chrome print preview, the css is correct but node-html-pdf seems to break it

I had height property on an ancestor of the elements I wanted to avoid page breaks on. As soon as I removed them, the elements were no longer being split accross pages. I'll see if I can come up with solid repro steps.


Updated header links

Coverage remained the same at 82.308% when pulling 980dd24efb9bcf55b0369615b5dfaa6159652ffc on update-header-links into 130bb6c0645e308894b903064174fbe940463c60 on master.

change it back!

Coverage increased (+0.05%) to 82.355% when pulling e31f507c5311011a3118f9ff15566815ebca4927 on update-header-links into 130bb6c0645e308894b903064174fbe940463c60 on master.


Git diff paths are confusing when using git difftool (but not git diff)

Issue
cd /tmp/
cargo new --bin repro
cd repro
git add .
git commit -m "First commit"
echo 'fn main() { println!("Repro for difftastic"); dbg!(42); }' > src/main.rs
git difftool --tool difftastic  # See https://difftastic.wilfred.me.uk/git.html

This shows:

Note the path: main.rs instead of src/main.rs. Using GIT_EXTERNAL_DIFF=difft git diff does not have this problem for some reason ?
Solution
I replaced the [difftool "difftastic"].cmd with echo "$LOCAL" "$REMOTE" and it shows this: /tmp/nix-shell.Pyzfqe/git-blob-OVxVxg/main.rs src/main.rs
/tmp/nix-shell.Pyzfqe is $TMPDIR for me so really git is passing LOCAL="$TMPDIR/git-blob-OVxVxg/main.rs".
So here is what I propose:

When two paths are given
And they're both files
And one of them starts with $TMPDIR and the other doesn't (when $TMPDIR is unset, /tmp/ is used)
And the directory just under said TMPDIR starts with git-blob-
Then the path used in difftastic output should be the other path

I think this will work on both Linux and macOS. I don't know how git windows works
Note: the second path given to difftool is always from the root of the repo, we could make it relative to the current dir (when possible, falling back to the original path) to make it more intuitive, like a simple git diff works)
Meta

Difftastic: 0.54.0 (built with rustc 1.75.0)
OS: macOS 14.1 (23B74)

Workaround: using cmd = difft --tab-width 4 "$BASE" "$LOCAL" "hash" "mode" "$REMOTE" "hash" "mode" works well enough, though it is an hack based on how difftastic parses args and how "git diff" passes arguments

Thanks, I agree this is worth fixing and your heuristic sounds good.


proposal: avoid github actions known as currently broken

In order to avoid confusing contributors and reviewers we should avoid enabling or keeping CI jobs that are known as broken.
The only exception to this rule should be if someone is already actively working on fixing these.
If a job is broken for more than a week or two, we should just disable the job and eventually document that use-case as unsupported, at least until we can make it green again.
Reasoning
When looking at list of open pull request, anyone should be able to see the green-checkmark for changes that passed CI. Once this happens they can review them.
If a project has known-as-broken jobs, all pull-requests will report a red-check, making much harder to identify those that are ready for review or not. If the project happens to have more than 8-10 CI jobs, it can become even harder for the reviewer to identify if a genuinely required job failed or if only the known failures caused the mark.
As seen in screenshot example below none of the pending pull-requests have a green checkmark on them because that project has CI jobs known to be broken. That is making reviewing less likely to happen and reviewer time is limited and he is not expected to investigate each exiting PR to see if it was updated and if only broken jobs are causing the red mark on it.

Other options
If we identify a way to still run broken jobs but avoid changing the final mark from green to red we should keep them. Sadly, AFAIK that is not possible with GHA at this time. Even if we skip jobs, the final mark will be red.

+1 for this proposal, I am in favour of removing GHA failing for known reason until we fix it (there can be an issue raised to track it) to avoid confusion and save PR submitters time to try to figure out why the job is failing.

+0......  If the job was once working, it should be fixed or the change that broke the job reverted.  If the job never worked, it shouldn't have been enabled.
IMO, avoiding "known-as-broken" jobs entirely might be the ultimate fix.

@cidrblock Windows building never worked as we did not had any CI jobs. It was added as an emergency/fast-tracked change https://github.com/ansible/ansible-language-server/pull/18 just before we both went on vacation, as we wanted to ensure that what comes while we were drinking margaritas was not going to give us more headaches when back.
If you read the comments on the change you will see that I was against adding it with few other remarks. Still, I did approve and merged it with @webknjaz because it was far worse to have no CI at all.
We will discuss it in our next team meeting but it would be very useful if everyone does the research regarding pros/cons before the meeting.

@ssbarnea I may have missed this was concerning a specific issue/PR and/or repo in the explanation above... My bad.

I'm "-2" on this. At least, on removing the jobs entirely. And here's why:

In order to avoid confusing contributors and reviewers we should avoid enabling or keeping CI jobs that are known as broken.

Did any contributor get confused by this? What was the case? It looks like you're suggesting a solution to a different problem or maybe you're mixing up several cases that seem related to you (see below).

If a job is broken for more than a week or two, we should just disable the job and eventually document that use-case as unsupported, at least until we can make it green again.

In the Python ecosystem, we'd use an xfail for it. I think we should emulate something similar here.

Reasoning
When looking at list of open pull request, anyone should be able to see the green-checkmark for changes that passed CI. Once this happens they can review them.
If a project has known-as-broken jobs, all pull-requests will report a red-check, making much harder to identify those that are ready for review or not. If the project happens to have more than 8-10 CI jobs, it can become even harder for the reviewer to identify if a genuinely required job failed or if only the known failures caused the mark.
As seen in screenshot example below none of the pending pull-requests have a green checkmark on them because that project has CI jobs known to be broken. That is making reviewing less likely to happen and reviewer time is limited and he is not expected to investigate each exiting PR to see if it was updated and if only broken jobs are causing the red mark on it.

This is not a realistic workflow for many, though. Most (all?) of the review tools distinguish the "ready for review" and "the CI is passing" statuses. They are different things. Many of us have seen Gerrit at least once in a lifetime: it encourages reviews of the code (and the commit message for that matter) and it shows those separately from the CI results. Some of the platforms have it as a WIP in titles.
In the case of GitHub, the flag for whether something should be reviewed or not is the Draft status that is literally controlled by a button saying Ready for review. One shouldn't rely on the CI status to start reviewing. Moreover, the CI may be broken and the contributor may need help to get it fixed — if you dismiss them, it is going to be a weird loop of not getting reviews because the CI is red and not getting the CI fixed because of no reviews and the maintainers don't even know about such a need to help someone.
Also, the CI may be temporarily broken because of minor linter issues in the PR and the author could benefit from getting asynchronous feedback while they are fixing the linting violations. Waiting/blocking on unrelated things is counterproductive. The CI checks exist for preventing broken merges, not for preventing reviews.
That said, we should encourage reviews of any PR that is not marked as a Draft. And reserve that the Draft label as a unified way of signaling "do not attempt to review this, it's not yet ready".

Other options
If we identify a way to still run broken jobs but avoid changing the final mark from green to red we should keep them. Sadly, AFAIK that is not possible with GHA at this time. Even if we skip jobs, the final mark will be red.

Skipping the jobs doesn't add a red mark AFAIK but continue-on-error does pass it through, yes. I've been meaning to experiment with the idea of making the failing jobs green if they are not required by the branch protection.
FWIW part of the tests pass in the windows tests and I don't see any reason not to run them in the CI. We should test that at least they work. It could be acceptable to somehow limit the test run to only those tests that are passing, for example.

@webknjaz First, that is not like xfail. Using xfail does not alter the outcome of pytest run. Pytest reports green at the end. If github jobs could do the same and avoid polluting the final result of the entire execution I would not have proposed that change.
The reality is that as far as we know, Windows builds never worked. We are not talking about a temporary regression, we are talking about the fact that these jobs were broken from the moment they were added.
I do not have the bandwidth to fix them myself and I did not see anyone working on that either in two weeks. I would not remove the jobs from the file but I would only comment them so we have at least two places reminding us that Windows is broken: that issue and the ci.yml file. In fact yesterday I even pinned that issue to increase its visibility.
Having permanent broken jobs does degrade my ability to review incoming patches, as I am no longer able to easily identify which incoming patches reported green. The direct result on this is less reviews.
I wonder if @tomaciazek knows how to fix the Windows failed tests.

@webknjaz First, that is not like xfail. Using xfail does not alter the outcome of pytest run. Pytest reports green at the end. If github jobs could do the same and avoid polluting the final result of the entire execution I would not have proposed that change.

I think you misunderstood the context here. What I mean is that we could add some conditional skips to the failing tests under known bad envs rather than not testing at all.

The reality is that as far as we know, Windows builds never worked. We are not talking about a temporary regression, we are talking about the fact that these jobs were broken from the moment they were added.

And several tests are green. They should remain green.

I do not have the bandwidth to fix them myself and I did not see anyone working on that either in two weeks. I would not remove the jobs from the file but I would only comment them so we have at least two places reminding us that Windows is broken: that issue and the ci.yml file. In fact yesterday I even pinned that issue to increase its visibility.

See above. We can skip the failures to avoid those red flags but:

Having permanent broken jobs does degrade my ability to review incoming patches, as I am no longer able to easily identify which incoming patches reported green. The direct result on this is less reviews.

as I've mentioned in the previous post, it's the wrong approach. The PRs that are not marked as Draft should be reviewed regardless of the CI status. It shouldn't be an excuse to skip them.

@webknjaz Add the 9 required xfail conditions and I will be the first to approve the change. I doubt that mocha would not have a similar mechanisms as pytest xfail/xskip.


tmp_overrides multiple entries format

Hello, I was wondering if the below tmp_overrides are correctly formatted if we have multiple drives that can handle more max jobs than tmp_dir_max_jobs setting:

Thank you!

That strikes me as ok, though I haven't used this feature yet.  Are you having any issues?

Those drives seem to be starting a 4th job, and my tmpdir_max_jobs is set to 3, so it looks like the override is working!
I need to change the stagger_phase settings to make them each have 6 consecutive jobs. Is there a way to change these settings on the fly or do I have to restart plotman completely?
Thanks!

Now that I think about it, it would be nice to have override option for stagger_phase settings as well. For instance my 1TB drives can use phase_limit 1, while the 2TB drives that have faster writes can use phase_limit 2

Ok I think I have a work around for what I've described above:
In case of some drives using the global max jobs 3, and some drives using override max jobs 6:
Start plotman interactive with phase_limit 2 in the config. Let it run until the global max jobs drives reach 3 instances.
Change the config to phase_limit 2. Close the plotman interactive terminal to kill the process. Run plotman interactive again. The drives with override max jobs 6 will start working on new plots and always have 2 plots in phase 1 at a time.
This achieves the goal of not having the global max jobs 3 drives having 2 jobs in phase 1 at the same time

Presumably there should be more per-tmp-drive configurability at least in the direction you provide.
Yes, restarting plotman is how you get configuration updates.  This should be fine since plotman is (fairly) stateless.  You can exit plotman by pressing q.
Yeah, you can play games like you mention with changing the config.  We can't support everything immediately, but I do consider this workaround to be exactly that, a workaround for missing features in plotman.

So when "plotman interactive" is open and running and I press Q - is it turned off? Because status is showing that processes are running. What should I do to correctly restart plotman to reload config settings?

@drygb plotman just launches chia plotting processes.  They continue when you quit plotman.  When you run plotman again it will load the present configuration file and detect the previously-started processes.

regarding the "overrides" part of the config, i am leaning towards eliminating the "global" settings and defaulting to per-dir settings.  Most people don't have a ton of directories anyway, and a lot of people seem to have heterogenous setups.  Then, if people have a lot of identical drives, they can use node references to avoid duplicating settings.  WDYT, @altendky ?

I think we're thinking pretty similarly, even down to YAML anchors...  CPU related limits would still be global, but we probably need to discuss everything a bit and make sure I'm up to speed on some details.

@drygb plotman just launches chia plotting processes. They continue when you quit plotman. When you run plotman again it will load the present configuration file and detect the previously-started processes.

@altendky Although unrelated to this issue, in particular, your statement I quoted should go in the readme. I feel like many, many issues I've seem in plotman have questions that can be answered by this statement. The readme has the following

Plotman tools are stateless. Rather than keep an internal record of what jobs have been started, Plotman relies on the process tables, open files, and logfiles of plot jobs to understand "what's going on". This means the tools can be stopped and started, even from a different login session, without loss of information.

but I think your explanation is much clearer.


Clicking outside to close the Color Picker is closing the modal

https://react-science.pages.dev/stories/?path=/story/components-color-pickers--color-picker-dropdown-story
https://github.com/zakodium-oss/react-science/assets/35760236/444a83c8-5491-4e92-8920-0c56896ffebf

After migrating to react-science version 0.33 and replacing the old Modal component with the Dialog component from Blueprint.js, the color picker is now appearing behind the Dialog

@hamed-musallam @stropitek
This happens because of react-science Portal blueprint js portal are diffrent
So we need to refactor any react-science component that uses it.

I believe the color picker should use the Portal from Blueprintjs. As I can see, we have fully replaced the Modal with Dialog.


Rewrite the packages to a more scripting method ;; WLFE-30

Also:

Use Handlebars as template engine.
Change how create-workleap and @workleap/foundry communicate with each other.
Improve documentation.
Fix typos.

Still missing support to replace patterns in multiple files, this will be implemented in this PR by a commit coming soon.

I noticed you updated the PR type to "draft". Is it ready to review? I am confused because I also received a review request :)

It's just me trying GitHub features end testing workflow 😅
It' ready to review now 👍

By convention, a package bin file should be named bin.ts not index.ts

With @alexasselin008 we gonna merge this PR. After we will review the files together and make many of the requested changes in other smaller PRs.


Support string responses

Describe the bug
EDIT: It has also become apparent when doing a GET request and returns a stringified json object on iOS it fails to parse. and instead errors, below is an example which id expect it to be able to handle.
"{\"ColumnDefinition\":{\"RecordNumber\":{\"ColumnType\":\"\",\"IsStatusField\":false,\"IsVisible\":false,\"TranslatedColumnName\":\"\"},\"ItemNumber\":{\"ColumnType\":\"text\",\"IsStatusField\":false,\"IsVisible\":true,\"TranslatedColumnName\":\"Item Number\"},\"Description\":{\"ColumnType\":\"text\",\"IsStatusField\":false,\"IsVisible\":true,\"TranslatedColumnName\":\"Description\"}},\"DataSource\":[{\"RowNumber\":\"1\",\"RecordNumber\":\"1,190\",\"ItemNumber\":\"000001\",\"Description\":\"\"}],\"RowCount\":1}"

When sending a put/post request with a content type of application/json, it terminates the app due to an unhandled exception error if the data is a non-object value eg string.
CoreFoundation __exceptionPreprocess
libobjc.A.dylib objc_exception_throw
Foundation +[NSJSONSerialization dataWithJSONObject:options:error:]
CapacitorCommunityHttp 0x0000000101468000 + 33396
CapacitorCommunityHttp 0x0000000101468000 + 42956
CapacitorCommunityHttp 0x0000000101468000 + 44788
CapacitorCommunityHttp 0x0000000101468000 + 87648
CapacitorCommunityHttp 0x0000000101468000 + 120732
CapacitorCommunityHttp 0x0000000101468000 + 122024
CapacitorCommunityHttp 0x0000000101468000 + 122088
Capacitor 0x0000000101190000 + 85168
Capacitor 0x0000000101190000 + 43204
libdispatch.dylib
_dispatch_call_block_and_release

Based on
To Reproduce
  private static async request(url: string) {
  const httpOptions: HttpOptions = {
      headers: {
        'Content-Type': 'application/json'
      },
      method: 'PUT'
      url: url
      data: "123456"
    };
    return await Http.request(httpOptions);
  }

I have tried both data: '"123456"' and data: "123456" and it is the same result, app termination.
Edit: This might be related to #172 but not sure. I have noticed if i remove the content type json for a string request, no data is sent.
Expected behavior
To be able to send a request without the app being terminated due to an unhandled exception error.
To be able to send a content type request with a non-object data value
Smartphone

Device: iPhone 11 Pro Max
OS: iOS 15.0.2

Additional context
Based on history, this was fixed in #141 and released in 1.1.0

This plugin isnt maintained and in its current state, in my opinion, isnt fit for purpose and issues arent being addressed - It doesnt handle JSON on iOS and/or Android. Appears to work fine on Web.
Ive found another bug - However, I think this might just be because it cannot handle JSON:
Setting the responseType doesnt do anything if the responce request headers content-type includes 'application/json'.
This is because it is at the top of the if statement, if you move it to be the last in the if else it'll resolve this issue, but at the same time I dont understand why it has been done this way.
Will regretabily have to go back to angular http and remove this npm package.

The plugin is indeed still maintained, I just don't have much time to work on it nowadays.
This was fixed in a recent release with #196

Misread the issue, reopening


Implement scan

Description:
kostasl@macbook:~/resin/github/resin-os/resin-device-toolbox$ ./bin/resin-device-toolbox scan -h
Usage: scan

Examples:

	$ rtb scan
	$ rtb scan --verbose

Options:

    --verbose, -v                       Display full info

Preview:
kostasl@macbook:~/resin/github/resin-os/resin-device-toolbox$ ./bin/resin-device-toolbox scan
| Scanning for local resinOS devices..
Reporting scan results
-
  host:          resinos-beta.local
  address:       <IP_ADDRESS>
  dockerInfo:
    Containers:        5
    ContainersRunning: 5
    ContainersPaused:  0
    ContainersStopped: 0
    Images:            21
    Driver:            aufs
    SystemTime:        2016-10-13T16:57:26.991495101Z
    KernelVersion:     4.1.21
    OperatingSystem:   Resin OS 2.0.0-beta.1
    Architecture:      armv7l
  dockerVersion:
    Version:    1.10.3
    ApiVersion: 1.22

Closes #13

Would this close #13 ?

@lurch yeap, updated PR description

I guess you might want to also update the PR description to use rdt rather than rtb ;-)


Getting status: 0 when I run more than 10 requests at once

I'm getting a strange issue where Typhoeus is returning empty responses with status: 0, but only when I make more than 10 requests at once.
Here's the ethon output when I run 12 requests at the same time (the 400s are ok and expected, the 0s are bad):
ETHON: started MULTI
ETHON:         performed EASY effective_url=<URL> response_code=0 return_code=recv_error total_time=0.280002
ETHON:         performed EASY effective_url=<URL> response_code=0 return_code=recv_error total_time=0.300416
ETHON:         performed EASY effective_url=<URL> response_code=400 return_code=ok total_time=0.365894
ETHON:         performed EASY effective_url=<URL> response_code=400 return_code=ok total_time=0.371102
ETHON:         performed EASY effective_url=<URL> response_code=400 return_code=ok total_time=0.372054
ETHON:         performed EASY effective_url=<URL> response_code=400 return_code=ok total_time=0.467612
ETHON:         performed EASY effective_url=<URL> response_code=400 return_code=ok total_time=0.468912
ETHON:         performed EASY effective_url=<URL> response_code=400 return_code=ok total_time=0.475045
ETHON:         performed EASY effective_url=<URL> response_code=400 return_code=ok total_time=0.484486
ETHON:         performed EASY effective_url=<URL> response_code=400 return_code=ok total_time=0.484521
ETHON:         performed EASY effective_url=<URL> response_code=400 return_code=ok total_time=0.484609
ETHON:         performed EASY effective_url=<URL> response_code=400 return_code=ok total_time=0.484651
ETHON: performed MULTI

However, if I set my max_concurrency to 10, everything works.
Any thoughts as to why this might be occurring? Is it a problem with Typhoeus or Ethon?
I tried passing higher values of max_total_connections and maxconnects when initializing the Typhoeus::Hydra but it didn't seem to help.
libcurl version:
$ curl-config --version
libcurl 7.30.0

This was using the Faraday adapter, by the way... if that's relevant.

@asross thanks for your report. Maybe your issue is resolved in the latest libcurl release. If it is not, let me know. Did you set timeouts?

I get this same error using typhoeus, I'm using heroku. libcurl version:
curl-config --version
libcurl 7.35.0

typhoeus/ethon#125 fixes the repro in #411 on MRI 2.2.1 for me. @i0rek would it be possible to create a release(s) that includes that change please?

@eltone I released ethon 0.9.1 last night.

@i0rek Great! Thanks so much.

Feel free to close this issue if you guys believe it's solved!


bug: fix test.yml

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
25 unchanged lines in 8 files lost coverage.
Overall coverage decreased (-0.02%) to 77.879%

Files with Coverage Reduction
New Missed Lines
%

storage/cluster/cluster.go
1
87.97%

raft/engine.go
2
86.38%

raft/internal/transport/transport.go
2
92.83%

raft/request.go
2
94.52%

regattaserver/encoding/zstd/grpc.go
2
94.12%

storage/engine_events.go
3
24.74%

raft/internal/tests/kvtest.go
4
47.77%

raft/internal/transport/snapshot.go
9
87.28%

Totals

Change from base Build<PHONE_NUMBER>4:
-0.02%

Covered Lines:
21448

Relevant Lines:
27540

💛  - Coveralls


Music driven lights fades out to louder noises (voices, cough, doors closing...)

I managed to get it up and running in no time! Thank you for the repo! =) I'm using it as a reactive lights for the TV and Home Theater (where I reproduce heaps of videos and music).
I'm currently using a Mini USB Microphone as the input. I'm having a problems with the background noises. i.e.: I'm reproducing a song/video on the TV and the lights work perfectly, BUT as soon as there is another sound (people talking for example) the mic isolate their voice and removes the "background noise" (the music in this scenario) and the light starts to fade out (or to bright to something other than the music). This happens as well for loud noises (or louder than the music playing such as door closing, laughs, somebody coughing). I already move the microphone right next to the sound bar / tv but the problem persists.
Please let me know if you need more details.
I would like to know if you have tried to have a Sound Sensor as the input (instead of a mic which filters out background noise). Or do you have any idea how can I solve this issue?

Sorry for the delay, I never got an email from Github about this issue.
I'm glad to hear that you have it working!
What you're experiencing is common since the mic is trying to adjust the sensitivity on the fly. The mic will adjust its sensitivity dynamically so when something loud happens, the sensitivity is turned is turned way down because it assumes everything else will be loud. Then it'll adjust back after a few seconds.
What kind of sound sensor were you thinking of using? I don't know if that will work since I'm not too sure how PyAudio (the library used to listen to the mic) will interpret it. You could give it a try. If the Pi can see it as an input device, it might work. I don't have any sound sensors to test though.
Couple of things you can try is to get a USB-AUX adapter and feed the audio into it directly:

I've had a few people tell me that this works just fine. That way there's no mic in between to pick up random noises.
Second thing is that I have a version of this project that allows you to play audio directly on the Pi without a mic: https://www.easyprogramming.net/raspberrypi/audio_reactive_holiday_leds.php
Might need some tweaking to have your TV send audio to the Pi or something but that's also another option.
Hope some of this helps. Best of luck!


some features added

Nice contribution! Thanks!

Your welcome.
Thank you too.
I think it's time for max-depth option.


Sort query param persists between switching search tabs on entity page, breaking search if not configured

Describe the bug
For an entity page with a tabbed search using two different search configuration. If you in one of the tabs select a sort order which does not exist on the config of the other tab & then switch to the other tab, this will show error there because this sort option that is still present in url and thus applied, doesn't exist for this tab's discovery config.
To Reproduce
Steps to reproduce the behavior:

Orgunit page with search for related Authors (Person) and related Search Projects: https://demo.dspace.org/entities/orgunit/04900cb5-0200-40cc-8df1-3d14a6f1b8ca
Go To Search Projects tab => Select sort on title
Switch to Authors tab => Will show error because sort on title (spc.sf=dc.title&spc.sd=ASC) doesn't exist for solr search.

Expected behavior
When switching between search tabs on entity page, the search params in url should be cleared.

Atmire would like to claim this issue.


test

Task/Issue URL: https://app.asana.com/0/1202552961248957/1202810419472767/f
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #2191   👈

This comment was auto-generated by Graphite.


AS3 Extension is not idempotent

Environment

Application Services Version: 3.13.1
BIG-IP Version: BIG-IP <IP_ADDRESS> Build 0.0.4 Point Release 4

Summary
Sending an AS3 declaration triggers a "Changes Pending" even if there's "no change".
Steps To Reproduce
Steps to reproduce the behavior:

Submit the following declaration:

{
  "class": "AS3",
  "action": "deploy",
  "persist": true,
  "declaration": {
    "class": "ADC",
    "schemaVersion": "3.0.0",
    "label": "Sample 01",
    "remark": "Simple HTTP application with round robin pool",
    "sample01": {
      "class": "Tenant",
      "defaultRouteDomain": 0,
      "Application_1": {
        "class": "Application",
        "template": "http",
        "serviceMain": {
          "class": "Service_HTTP",
          "virtualAddresses": ["<IP_ADDRESS>"],
          "pool": "web_pool"
        },
        "web_pool": {
          "class": "Pool",
          "monitors": ["http"],
          "members": [
            {
              "servicePort": 80,
              "serverAddresses": ["<IP_ADDRESS>", "<IP_ADDRESS>"]
            }
          ]
        }
      }
    }
  }
}

Sync the devices.

Re-submit the declaration.

Observe the following response:

        {
            "message": "no change",
            "host": "localhost",
            "tenant": "sample01",
            "runTime": 557,
            "code": 200
        }

Observe the sync status on the BIG-IP: Changes Pending

Expected Behavior
When there's no change, sending an AS3 declaration should not trigger a "Changes Pending".
Actual Behavior
A "Changes Pending" is triggered on the BIG-IP, even if the AS3 response message says "no change".

Thank you for creating the new issues. I am going to close this one out. If you feel there is something else that is not covered by #221 or #222, please reopen this ticket or create a new one.


Add links, for all measures, to data / code / text explaining how measure was built

We have this done for all that can be driven from analyse page; but those relying on e.g. quantity cannot be done this way. For those we could swiftly zip thru and manually make a link to the code driving the measure, not necessary for it to be perfect text, just discoverable and intelligible to an expert crowd.

@inglesp Given that we now have SOURCE_COMMIT_ID in settings and that the measure ID maps straightforwardly to a filename, I suppose we could generate a link to the measure definition on github fairly easily.

After discussion with @inglesp, we think we should have a page for each measure showing the SQL which drives it, together with some generic explanatory text (the same for all measures). This can piggy back off the work Peter's already done in getting our measures to run off the public BQ dataset. There will still be some "black box" elements (e.g. private tables which Rich manually curates) but it's a solid step in the right direction.
Tech notes:

Use the template in bq_public_tables/_measure_template.sql
Maybe inject comments into the template making it visually clear which are the key parts of the query which define the numerator and denominator
I think there are some SQL syntax highlighting libraries written in JS which we could use for added prettiness.

We could just show the SQL for the two subqueries that calculate the numerators and denominators -- that'd be significantly less overwhelming that showing the full query.