lint-staged failed due to a git error

Description
Unable to commit due to git error while nothing was done except for changing some files.

Steps to reproduce

git commit -m 'msg'
Debug Logs

[STARTED] Preparing...
lint-staged:git Backing up original state... +0ms
lint-staged:git Getting partially staged files... +0ms
lint-staged:git Running git command [ 'status', '-z' ] +89ms
lint-staged:git Found partially staged files: [] +30ms
lint-staged:git Backing up merge state... +0ms
lint-staged:file Reading file .../.git/MERGE_HEAD +0ms
lint-staged:file Reading file .../.git/MERGE_MODE +0ms
lint-staged:file Reading file .../.git/MERGE_MSG +0ms
lint-staged:file File .../.git/MERGE_HEAD doesn't exist, ignoring... +1ms
lint-staged:file File .../.git/MERGE_MODE doesn't exist, ignoring... +0ms
lint-staged:file File .../.git/MERGE_MSG doesn't exist, ignoring... +0ms
lint-staged:git Done backing up merge state! +1ms
lint-staged:git Getting deleted files... +56ms
lint-staged:git Running git command [ 'ls-files', '--deleted' ] +87ms
lint-staged:git Found deleted files: [] +13ms
lint-staged:git Running git command [ 'stash', 'create' ] +13ms
lint-staged:git Running git command [
'stash',
'store',
'--quiet',
'--message',
'lint-staged automatic backup',
''
] +19ms
[FAILED] Preparing...
[STARTED] Running tasks...
[SKIPPED] Skipped because of previous git error.
[STARTED] Applying modifications...
[SKIPPED]
[SKIPPED]   ✖ lint-staged failed due to a git error.
[STARTED] Cleaning up...
[SKIPPED]
[SKIPPED]   ✖ lint-staged failed due to a git error.
✖ lint-staged failed due to a git error.
Any lost modifications can be restored from a git stash:
> git stash list
stash@{0}: automatic lint-staged backup
> git stash apply --index stash@{0}

expand to view
COPY THE DEBUG LOGS HERE

Environment

OS: macOS Big Sur
Node.js: v12.18.2
lint-staged: 10.5.1

Merge from #945

Description

Lint-staged failed when new commits only in submodule and nothing else changed in the parent repo.
Steps to reproduce
I have a repo with one submodule. After I pushed commits to the submodule and would like to update the parent repo with no other changes directly in it, lint-staged failed.
More specifically, when you run git status before add and commit, you should get the following message from git indicating that you only have new commits in your submodule folder.
modified:   path/to/your/submodule/folder (new commits)

Debug Logs
No log available as I've used --no-verify to bypass the error and commited.
Environment

OS: macOS Big Sur
Node.js: v12.18.2
lint-staged: v10.5.3

Merge from #945

Description

Lint-staged failed when new commits only in submodule and nothing else changed in the parent repo.
Steps to reproduce
I have a repo with one submodule. After I pushed commits to the submodule and would like to update the parent repo with no other changes directly in it, lint-staged failed.
More specifically, when you run git status before add and commit, you should get the following message from git indicating that you only have new commits in your submodule folder.
modified:   path/to/your/submodule/folder (new commits)

Debug Logs
No log available as I've used --no-verify to bypass the error and commited.
Environment

OS: macOS Big Sur
Node.js: v12.18.2
lint-staged: v10.5.3

I'm experiencing the same error in monorepo using Lerna to run lint-staged in all workspaces/packages (lint:staged is just a script in package.json that runs lint-staged version 11.0.1).
lerna info Executing command in 2 packages: "yarn run lint:staged"
lerna ERR! yarn run lint:staged exited 1 in 'b2b'
lerna ERR! yarn run lint:staged stdout:
$ lint-staged
[STARTED] Preparing...
[STARTED] Running tasks...
[SKIPPED] Skipped because of previous git error.
[STARTED] Applying modifications...
[SKIPPED]
[SKIPPED]   ✖ lint-staged failed due to a git error.
[STARTED] Cleaning up...
[SKIPPED]
[SKIPPED]   ✖ lint-staged failed due to a git error.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
lerna ERR! yarn run lint:staged stderr:
⚠ Some of your tasks use `git add` command. Please remove it from the config since all modifications made by tasks will be automatically added to the git commit index.

[FAILED] Preparing...

  ✖ lint-staged failed due to a git error.
  Any lost modifications can be restored from a git stash:

    > git stash list
    stash@{0}: automatic lint-staged backup
    > git stash apply --index stash@{0}

error Command failed with exit code 1.
lerna ERR! yarn run lint:staged exited 1 in 'b2b'
lerna WARN complete Waiting for 1 child process to exit. CTRL-C to exit immediately.
husky > pre-commit hook failed (add --no-verify to bypass)

The command yarn workspace b2b lint:staged ran by itself is finished successfully.
I'm bypassing the error above by using --no-verify. However this happens only if there is a huge amount of changes to be committed. When I commit a single change the problem is not there and lint works well.

Check your .git folder. There could be a lint-staged_unstaged.patch file. Delete that and try it again. That fixed it for me.

In the case with submodule, lintstaged --no-stash solves this problem.
I would think prepare method in libs/GitWorkflow cannot handle submodule hash correctly.

Pull requests are welcome if you manage to make it work better with submodules!

We had this issue at work.
We pin-pointed the issue with our pnpm mono-repo structure. By default, it uses parallelism. However, lint-staged do some git operations which cannot be ran concurrently.
tl;dr: if you have a mono-repo, be sure that you are not running multiple times lint-staged concurrently

In my case I didn't have a lint-staged_unstaged.patch file in .git folder as @lgoodcode suggested, but instead I had an awkward  index.lock.lock file (yes, appended .lock twice). I deleted it, and everything worked fine again.

@quadristan You are right, the problem is, that pnpm -r will run in concurrency (currently 4 processes); I simply call lint-staged now with pnpm -r --workspace-concurrency=1 lint-staged and everything works like a charm!

In my case, I just deleted the stash.lock located in .git/refs/stash.lock, everything fine again, and the stashes that lint had created are still there.

In my case, opening a new terminal fixed my issue.

still no answer?

still same issue

Posting a reply like this is not helpful. Without debug logs it's not possible to tell what the issue is. This issue already has multiple reports of different issues in it.

Posting a reply like this is not helpful. Without debug logs it's not possible to tell what the issue is. This issue already has multiple reports of different issues in it.

Here debug log.
  lint-staged:bin Options parsed from command-line: {
  allowEmpty: false,
  concurrent: true,
  configPath: undefined,
  cwd: undefined,
  debug: true,
  diff: undefined,
  diffFilter: undefined,
  maxArgLength: undefined,
  quiet: false,
  relative: false,
  shell: false,
  stash: true,
  verbose: false
} +0ms
  lint-staged:validateOptions Validating options... +0ms
  lint-staged:validateOptions Validated options! +0ms
  lint-staged Unset GIT_LITERAL_PATHSPECS (was `undefined`) +0ms
  lint-staged:runAll Running all linter scripts... +0ms
  lint-staged:runAll Using working directory `D:\websites\ksvblog` +0ms
  lint-staged:resolveGitRepo Resolving git repo from `D:\websites\ksvblog` +0ms
  lint-staged:resolveGitRepo Unset GIT_DIR (was `undefined`) +0ms
  lint-staged:resolveGitRepo Unset GIT_WORK_TREE (was `undefined`) +0ms
  lint-staged:execGit Running git command [ 'rev-parse', '--show-prefix' ] +0ms
  lint-staged:resolveGitRepo Resolved git directory to be `D:/websites/ksvblog` +78ms
  lint-staged:resolveGitRepo Resolved git config directory to be `D:/websites/ksvblog/.git` +0ms
  lint-staged:execGit Running git command [ 'log', '-1' ] +78ms
  lint-staged:execGit Running git command [ 'diff', '--name-only', '-z', '--diff-filter=ACMR', '--staged' ] +76ms
  lint-staged:runAll Loaded list of staged files in git:
  lint-staged:runAll [ 'D:/websites/ksvblog/themes/ksv' ] +246ms
  lint-staged:searchConfigs Searching for configuration files... +0ms
  lint-staged:execGit Running git command [ 'ls-files', '-z', '--full-name' ] +92ms
  lint-staged:execGit Running git command [ 'ls-files', '-z', '--full-name', '--others', '--exclude-standard' ] +15ms
  lint-staged:searchConfigs Found possible config files: [ 'D:/websites/ksvblog/package.json' ] +101ms
  lint-staged:loadConfig Loading configuration from `D:/websites/ksvblog/package.json`... +0ms
  lint-staged:loadConfig Successfully loaded config from `D:\websites\ksvblog\package.json`:
  lint-staged:loadConfig { '**/*': 'prettier --write --ignore-unknown' } +2ms
  lint-staged:searchConfigs Config file "D:/websites/ksvblog/package.json" resolved to "D:\websites\ksvblog\package.json" +3ms
  lint-staged:validateConfig Validating config from `D:\websites\ksvblog\package.json`... +0ms
  lint-staged:validateConfig Validated config from `D:\websites\ksvblog\package.json`: +1ms
  lint-staged:validateConfig {
  lint-staged:validateConfig   '**/*': 'prettier --write --ignore-unknown'
  lint-staged:validateConfig } +0ms
  lint-staged:searchConfigs Found 1 config files +2ms
  lint-staged:groupFilesByConfig Grouping 1 files by 1 configurations +0ms
  lint-staged:chunkFiles Resolved an argument string length of 30 characters from 1 files +0ms
  lint-staged:chunkFiles Creating 1 chunks for maxArgLength of 4095.5 +0ms
  lint-staged:generateTasks Generating linter tasks +0ms
  lint-staged:generateTasks Generated task:
  lint-staged:generateTasks {
  lint-staged:generateTasks   pattern: '**/*',
  lint-staged:generateTasks   commands: 'prettier --write --ignore-unknown',
  lint-staged:generateTasks   fileList: [ 'D:/websites/ksvblog/themes/ksv' ]
  lint-staged:generateTasks } +2ms
  lint-staged:makeCmdTasks Creating listr tasks for commands 'prettier --write --ignore-unknown' +0ms
  lint-staged:resolveTaskFn cmd: prettier +0ms
  lint-staged:resolveTaskFn args: [ '--write', '--ignore-unknown' ] +0ms
  lint-staged:resolveTaskFn execaOptions: {
  cwd: 'D:\\websites\\ksvblog',
  preferLocal: true,
  reject: false,
  shell: false
} +0ms
  lint-staged:chunkFiles Resolved an argument string length of 30 characters from 1 files +5ms
  lint-staged:chunkFiles Creating 1 chunks for maxArgLength of 4095.5 +0ms
[STARTED] Preparing lint-staged...
  lint-staged:GitWorkflow Backing up original state... +0ms
  lint-staged:GitWorkflow Getting partially staged files... +0ms
  lint-staged:execGit Running git command [ 'status', '-z' ] +102ms
  lint-staged:GitWorkflow Found partially staged files: [] +166ms
  lint-staged:GitWorkflow Backing up merge state... +0ms
  lint-staged:file Reading file `D:\websites\ksvblog\.git\MERGE_HEAD` +0ms
  lint-staged:file Reading file `D:\websites\ksvblog\.git\MERGE_MODE` +0ms
  lint-staged:file Reading file `D:\websites\ksvblog\.git\MERGE_MSG` +0ms
  lint-staged:file File `D:\websites\ksvblog\.git\MERGE_HEAD` doesn't exist, ignoring... +1ms
  lint-staged:file File `D:\websites\ksvblog\.git\MERGE_MODE` doesn't exist, ignoring... +0ms
  lint-staged:file File `D:\websites\ksvblog\.git\MERGE_MSG` doesn't exist, ignoring... +0ms
  lint-staged:GitWorkflow Done backing up merge state! +3ms
  lint-staged:GitWorkflow Getting deleted files... +0ms
  lint-staged:execGit Running git command [ 'ls-files', '--deleted' ] +169ms
  lint-staged:GitWorkflow Found deleted files: [] +65ms
  lint-staged:execGit Running git command [ 'stash', 'create' ] +66ms
  lint-staged:execGit Running git command [
  'stash',
  'store',
  '--quiet',
  '--message',
  'lint-staged automatic backup',
  ''
] +76ms
[STARTED] Running tasks for staged files...
[SKIPPED] Running tasks for staged files...
[STARTED] Applying modifications from tasks...
[SKIPPED]
  ✖ lint-staged failed due to a git error.
[STARTED] Cleaning up temporary files...
[SKIPPED]
  ✖ lint-staged failed due to a git error.

  ✖ lint-staged failed due to a git error.
  Any lost modifications can be restored from a git stash:

    > git stash list
    stash@{0}: automatic lint-staged backup
    > git stash apply --index stash@{0}```

⟹  git commit -m "Themes: ksv Updated."
[STARTED] Preparing lint-staged...
[STARTED] Running tasks for staged files...
[SKIPPED] Running tasks for staged files...
[STARTED] Applying modifications from tasks...
[SKIPPED]
✖ lint-staged failed due to a git error.
[STARTED]
✖ lint-staged failed due to a git error.
Cleaning up temporary files...
[SKIPPED]  Any lost modifications can be restored from a git stash:
> git stash list
stash@{0}: automatic lint-staged backup
> git stash apply --index stash@{0}

✖ lint-staged failed due to a git error.
husky - pre-commit hook exited with code 1 (error)

If there is a command called npx lint-staged in the pre-commit file under the .husky directory, you will see that the error is resolved if you add the following command snippet to the end and then commit:
--no-stash
Note: If you are working on a personal project, there is no problem in committing this change you made in the pre-commit file. However, you should be careful when committing to a large-scale, multi-participant or company project. In this case, the only drawback is that it needs to be done before each commit.

If there is a command called npx lint-staged in the pre-commit file under the .husky directory, you will see that the error is resolved if you add the following command snippet to the end and then commit:
--no-stash
Note: If you are working on a personal project, there is no problem in committing this change you made in the pre-commit file. However, you should be careful when committing to a large-scale, multi-participant or company project. In this case, the only drawback is that it needs to be done before each commit.

That was exactly my case and it worked, but I didn't understand why. Can you elaborate?

@quadristan You are right, the problem is, that pnpm -r will run in concurrency (currently 4 processes); I simply call lint-staged now with pnpm -r --workspace-concurrency=1 lint-staged and everything works like a charm!

Are you running commits in multiple git submodules at the same time? Do you have a sample repo we can take a look at?

You are right, the problem is, that pnpm -r will run in concurrency (currently 4 processes); I simply call lint-staged now with pnpm -r --workspace-concurrency=1 lint-staged and everything works like a charm!

@ChristianUlbrich  Are you running commits in multiple git submodules or workspaces at the same time? Do you have a sample repo we can take a look at?

@trusktr I am allergic to submodules. Just kidding. One mono repo managed by pnpm. I think the problem is pretty obvious, but apparently not so easy to be solved - lint-staged seems to invoke certain git commands, that cannot be invoked in parallel, which is seemingly happening if you call it multiple times with different paths on the same git repo.
I cannot share the repo, that we initially had the error with, but I think this is easily reproducible. If I find some time, I might manage to have a small repo available, that is mimicking our setup.
I think this is pretty much by design for any version control system working with a flat-file-based "index", like git does.

So to me it now sounds like this issue is about running lint-staged in parallel in a monorepo. This is already mentioned in the readme: run it on the root level only once, and have multiple configs instead.
https://github.com/lint-staged/lint-staged?tab=readme-ov-file#how-to-use-lint-staged-in-a-multi-package-monorepo

Got this error on my setup with husky and next
The solutions
--no-stash - 🤷🏻 i don't understand
--concurrent false - 👍🏻 found in this repo, guess this solves the main problem - intersection of a tasks / files
Config example
.husky/pre-commit

#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

npm run pre-commit

.husky/pre-push

#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

npm run pre-push

.lintstagedrc.js
const path = require('path')

const buildEslintCommand = (filenames) =>
  `next lint --fix --file ${filenames
    .map((f) => path.relative(process.cwd(), f))
    .join(' --file ')}`

module.exports = {
  '*': `prettier --write --ignore-unknown --ignore-path ${path.relative(
    process.cwd(),
    '.prettierignore'
  )}`,
  '*.{js,jsx,ts,tsx}': [buildEslintCommand],
}

package.json
"scripts" : {
  "pre-commit": "lint-staged --concurrent false",
  "pre-push": "npm run build && npm run license",
  "lint": "next lint --fix",
  "prepare": "husky install",
  "format": "prettier --write --ignore-unknown --ignore-path .prettierignore --cache .",
}

for me it was permission issue and was fixed by: sudo chown -R $(whoami) .*


Is there a way to filter the results by description (contains certain keywords)

Wanted to ask if you can set keywords that need to be present in description to prefilter the results?

the job boards don't provide a filter for that, so I would just iterate over the jobs after and filter.


Google Nexus 7 v2

Testing the Nexus 7 2013...
Seeing some differences but I'm not sure if that's due to the Share over LAN function from Desktopserver or the preset.
The background of my local website doesn't show when I view the site on my Nexus 7 but it does show in the preset from Firefox.

Guess I'll just use live websites instead of local development sites.

 <-- desktop

Nexus 7 2013 screenshot all looking nice!

Looks good! Thanks for the test.


Pipelines don't trigger on branch create when using paths include in trigger

So we're following the monorepo approach and thus need some fine-grain pipeline triggers in our YAML files using paths includes.
For example like that:
trigger:
  batch: true
  branches:
    include:
    - main
    - refs/heads/release/demo02/v*
  paths:
    include:
    - src/Demo02

The problem is that pipelines don't trigger when you create a branch (which works with the branch includes) while you're using paths includes.
Is that a known issue and do you already have a solution for that on your roadmap?
If you only want to trigger one pipeline due to the creation of a branch then it's still okay if you need to trigger it manually. But if multiple pipelines should trigger then it gets messy if they don't trigger automatically.

I just hit this as well, but only using paths. No trigger on branch creation but triggers successfully on subsequent pushes to that branch.


test: add ncu-config tests

Fixes: https://github.com/nodejs/node-core-utils/issues/148

Hello @joyeecheung, can we merge this?

This needs a rebase. @joyeecheung could you take another look?

Does this have a path forward or can it be closed?


Find new download source for msp430

The page we got them from http://software-dl.ti.com/ seems to have died, so we need a new source for them

The links here appear to be good http://software-dl.ti.com/msp430/msp430_public_sw/mcu/msp430/MSPGCC/5_00_00_00/index_FDS.html

Specifically:
http://software-dl.ti.com/msp430/msp430_public_sw/mcu/msp430/MSPGCC/5_00_00_00/exports/msp430-gcc-support-files-1.198.zip
and
http://software-dl.ti.com/msp430/msp430_public_sw/mcu/msp430/MSPGCC/5_00_00_00/exports/msp430-gcc-<IP_ADDRESS>_linux64.tar.bz2

Thanks for the links!


Update pip package

Hi, I fixed pip package in one PR so now templates are included in installer, so I think it's a good idea release a new package.

Pip package is now updated, v 0.0.3 released: 2b37d4792f70ae610c3d42ef96fcae45703a10a8


Unable to determine Puppet version

Description of problem

What did you do?
After following the configuration instructions, and the settings[:puppetdb_ssl_client_pem] tweak in #6, I receive the error Unable to determine Puppet version
What happened?
I receive the error Unable to determine Puppet version
What did you expect to happen?
I expected octocatalog-diff to probably hang up on the bootstrap script (similar setup as described in #4)
How can someone reproduce the problem?
My setup involves a private GitHub repo and nodes on my home LAN so I am unsure how much it can be replicated by others. The layout is similar to that of https://github.com/puppetinabox/controlrepo, and these steps were followed afterward:

# add octocatalog-diff to the Gemfile
bundle install --path vendor --without system_tests
curl https://raw.githubusercontent.com/github/octocatalog-diff/master/examples/octocatalog-diff.cfg.rb .octocatalog-diff.cfg.rb
# configure, see output below
bundle exec octocatalog-diff -d -n build03.nelson.va -o /tmp/catalog.json --bootstrapped-to-dir=$PWD --catalog-only

Command used and debugging output

$ bundle exec octocatalog-diff --config-test
Looking for config in: /home/rnelson0/puppet/controlrepo/.octocatalog-diff.cfg.rb
Loading config: /home/rnelson0/puppet/controlrepo/.octocatalog-diff.cfg.rb
:hiera_yaml_file => (String) "hiera.yaml"
:hiera_path_strip => (String) "/etc/puppetlabs/code/environments/"
:puppetdb_url => (String) "https://puppet.nelson.va:8081"
:puppetdb_ssl_ca => (String) "/etc/puppetlabs/puppet/ssl/certs/ca.pem"
:puppetdb_ssl_client_pem => (String) "TWO REALLY LONG CERTIFICATE BLOCKS CONCATENATED TOGETHER"
:storeconfigs => (TrueClass) true
:puppet_binary => (String) "/opt/puppetlabs/puppet/bin/puppet"
:from_env => (String) "origin/production"
:header => (Symbol) :default
:cached_master_dir => (String) "/home/rnelson0/.octocatalog-diff-cache"
:safe_to_delete_cached_master_dir => (String) "/home/rnelson0/.octocatalog-diff-cache"
:basedir => (String) "/home/rnelson0/puppet/controlrepo"

$ bundle exec octocatalog-diff -d -n build03.nelson.va -o /tmp/catalog.json --bootstrapped-to-dir=$PWD --catalog-only
D, [2016-10-30T23:58:49.943424 #18490] DEBUG -- : Running octocatalog-diff 0.5.1 with ruby 2.0.0
D, [2016-10-30T23:58:49.943526 #18490] DEBUG -- : Command line arguments: ["-d", "-n", "build03.nelson.va", "-o", "/tmp/catalog.json", "--bootstrapped-to-dir=/home/rnelson0/puppet/controlrepo", "--catalog-only"]
D, [2016-10-30T23:58:49.943556 #18490] DEBUG -- : Running on host build03 (x86_64-linux)
D, [2016-10-30T23:58:49.943577 #18490] DEBUG -- : Compiling catalog --catalog-only for build03.nelson.va
D, [2016-10-30T23:58:49.943960 #18490] DEBUG -- : Initialized OctocatalogDiff::Catalog::Noop for from-catalog
D, [2016-10-30T23:58:49.944006 #18490] DEBUG -- : Initialized OctocatalogDiff::Catalog::Computed for to-catalog
D, [2016-10-30T23:58:49.944054 #18490] DEBUG -- : Initialized parallel task result array: size=2
D, [2016-10-30T23:58:49.946238 #18492] DEBUG -- : Begin build_catalog for origin/production
D, [2016-10-30T23:58:49.946525 #18492] DEBUG -- : Setting up Puppet catalog build for origin/production
D, [2016-10-30T23:58:49.946616 #18492] DEBUG -- : Catalog for origin/production will be built with OctocatalogDiff::Catalog::Noop
D, [2016-10-30T23:58:49.946919 #18492] DEBUG -- : Catalog for origin/production successfully built with OctocatalogDiff::Catalog::Noop in 7.57e-06 seconds
D, [2016-10-30T23:58:49.946976 #18492] DEBUG -- : Success build_catalog for origin/production
D, [2016-10-30T23:58:49.947677 #18495] DEBUG -- : Begin build_catalog for .
D, [2016-10-30T23:58:49.947938 #18495] DEBUG -- : Setting up Puppet catalog build for .
D, [2016-10-30T23:58:49.947982 #18495] DEBUG -- : Catalog for . will be built with OctocatalogDiff::Catalog::Computed
D, [2016-10-30T23:58:49.948035 #18495] DEBUG -- : Calling build for object OctocatalogDiff::Catalog::Computed
D, [2016-10-30T23:58:49.948118 #18495] DEBUG -- : Start retrieving facts for build03.nelson.va from OctocatalogDiff::Catalog::Computed
D, [2016-10-30T23:58:49.948119 #18490] DEBUG -- : Success build_catalog for origin/production
D, [2016-10-30T23:58:49.948173 #18495] DEBUG -- : Retrieving facts from PuppetDB
D, [2016-10-30T23:58:50.164067 #18495] DEBUG -- : Success retrieving facts for build03.nelson.va from OctocatalogDiff::Catalog::Computed
D, [2016-10-30T23:58:50.165255 #18495] DEBUG -- : Symlinked /tmp/d20161030-18495-t0lgqg/environments/production -> /home/rnelson0/puppet/controlrepo
D, [2016-10-30T23:58:50.165401 #18495] DEBUG -- : Installed puppetdb.conf file at /tmp/d20161030-18495-t0lgqg/puppetdb.conf
D, [2016-10-30T23:58:50.167107 #18495] DEBUG -- : Installed routes.yaml file at /tmp/d20161030-18495-t0lgqg/routes.yaml
D, [2016-10-30T23:58:50.178975 #18495] DEBUG -- : Installed fact file at /tmp/d20161030-18495-t0lgqg/var/yaml/facts/build03.nelson.va.yaml
D, [2016-10-30T23:58:50.179398 #18495] DEBUG -- : Installed CA certificate in /tmp/d20161030-18495-t0lgqg/var/ssl/certs/ca.pem
D, [2016-10-30T23:58:50.450442 #18495] DEBUG -- : Failed build_catalog for .: RuntimeError Unable to determine Puppet version: /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/spec_set.rb:95:in `block in materialize': Could not find rake-11.3.0 in any of the sources (Bundler::GemNotFound)
        from /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/spec_set.rb:88:in `map!'
        from /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/spec_set.rb:88:in `materialize'
        from /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/definition.rb:140:in `specs'
        from /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/definition.rb:185:in `specs_for'
        from /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/definition.rb:174:in `requested_specs'
        from /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/environment.rb:19:in `requested_specs'
        from /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/runtime.rb:14:in `setup'
        from /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler.rb:95:in `setup'
        from /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/setup.rb:19:in `<top (required)>'
        from /opt/puppetlabs/puppet/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require'
        from /opt/puppetlabs/puppet/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require'

bundler: failed to load command: octocatalog-diff (/home/rnelson0/puppet/controlrepo/vendor/ruby/bin/octocatalog-diff)
OctocatalogDiff::CatalogDiff::Cli::Catalogs::CatalogError: Catalog for 'to' (.) failed to compile with RuntimeError: Unable to determine Puppet version: /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/spec_set.rb:95:in `block in materialize': Could not find rake-11.3.0 in any of the sources (Bundler::GemNotFound)
        from /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/spec_set.rb:88:in `map!'
        from /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/spec_set.rb:88:in `materialize'
        from /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/definition.rb:140:in `specs'
        from /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/definition.rb:185:in `specs_for'
        from /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/definition.rb:174:in `requested_specs'
        from /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/environment.rb:19:in `requested_specs'
        from /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/runtime.rb:14:in `setup'
        from /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler.rb:95:in `setup'
        from /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/setup.rb:19:in `<top (required)>'
        from /opt/puppetlabs/puppet/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require'
        from /opt/puppetlabs/puppet/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require'

   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/octocatalog-diff-0.5.1/lib/octocatalog-diff/util/puppetversion.rb:20:in `puppet_version'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/octocatalog-diff-0.5.1/lib/octocatalog-diff/catalog/computed.rb:66:in `puppet_version'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/octocatalog-diff-0.5.1/lib/octocatalog-diff/catalog/computed.rb:181:in `block in run_puppet'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/octocatalog-diff-0.5.1/lib/octocatalog-diff/catalog/computed.rb:178:in `upto'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/octocatalog-diff-0.5.1/lib/octocatalog-diff/catalog/computed.rb:178:in `run_puppet'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/octocatalog-diff-0.5.1/lib/octocatalog-diff/catalog/computed.rb:114:in `build_catalog'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/octocatalog-diff-0.5.1/lib/octocatalog-diff/catalog/computed.rb:59:in `build'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/octocatalog-diff-0.5.1/lib/octocatalog-diff/catalog.rb:60:in `build'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/octocatalog-diff-0.5.1/lib/octocatalog-diff/catalog-diff/cli/catalogs.rb:221:in `build_catalog'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/octocatalog-diff-0.5.1/lib/octocatalog-diff/util/parallel.rb:26:in `call'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/octocatalog-diff-0.5.1/lib/octocatalog-diff/util/parallel.rb:26:in `execute'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/octocatalog-diff-0.5.1/lib/octocatalog-diff/util/parallel.rb:114:in `block in run_tasks_parallel'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/parallel-1.9.0/lib/parallel.rb:451:in `call'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/parallel-1.9.0/lib/parallel.rb:451:in `call_with_index'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/parallel-1.9.0/lib/parallel.rb:422:in `process_incoming_jobs'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/parallel-1.9.0/lib/parallel.rb:404:in `block in worker'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/parallel-1.9.0/lib/parallel.rb:395:in `fork'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/parallel-1.9.0/lib/parallel.rb:395:in `worker'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/parallel-1.9.0/lib/parallel.rb:386:in `block in create_workers'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/parallel-1.9.0/lib/parallel.rb:385:in `each'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/parallel-1.9.0/lib/parallel.rb:385:in `each_with_index'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/parallel-1.9.0/lib/parallel.rb:385:in `create_workers'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/parallel-1.9.0/lib/parallel.rb:327:in `work_in_processes'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/parallel-1.9.0/lib/parallel.rb:241:in `map'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/parallel-1.9.0/lib/parallel.rb:203:in `each'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/octocatalog-diff-0.5.1/lib/octocatalog-diff/util/parallel.rb:90:in `run_tasks_parallel'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/octocatalog-diff-0.5.1/lib/octocatalog-diff/util/parallel.rb:72:in `run_tasks'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/octocatalog-diff-0.5.1/lib/octocatalog-diff/catalog-diff/cli/catalogs.rb:98:in `build_catalog_parallelizer'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/octocatalog-diff-0.5.1/lib/octocatalog-diff/catalog-diff/cli/catalogs.rb:32:in `catalogs'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/octocatalog-diff-0.5.1/lib/octocatalog-diff/catalog-diff/cli.rb:180:in `catalog_only'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/octocatalog-diff-0.5.1/lib/octocatalog-diff/catalog-diff/cli.rb:88:in `cli'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/octocatalog-diff-0.5.1/bin/octocatalog-diff:74:in `<top (required)>'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/bin/octocatalog-diff:23:in `load'
   /home/rnelson0/puppet/controlrepo/vendor/ruby/bin/octocatalog-diff:23:in `<top (required)>'
   /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/cli/exec.rb:63:in `load'
   /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/cli/exec.rb:63:in `kernel_load'
   /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/cli/exec.rb:24:in `run'
   /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/cli.rb:304:in `exec'
   /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
   /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'
   /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/vendor/thor/lib/thor.rb:359:in `dispatch'
   /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/vendor/thor/lib/thor/base.rb:440:in `start'
   /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/cli.rb:11:in `start'
   /usr/local/share/gems/gems/bundler-1.12.5/exe/bundle:27:in `block in <top (required)>'
   /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/friendly_errors.rb:98:in `with_friendly_errors'
   /usr/local/share/gems/gems/bundler-1.12.5/exe/bundle:19:in `<top (required)>'
   /usr/local/bin/bundle:23:in `load'
   /usr/local/bin/bundle:23:in `<main>'
  /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/octocatalog-diff-0.5.1/lib/octocatalog-diff/catalog-diff/cli/catalogs.rb:209:in `add_parallel_result'
  /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/octocatalog-diff-0.5.1/lib/octocatalog-diff/catalog-diff/cli/catalogs.rb:118:in `block in build_catalog_parallelizer'
  /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/octocatalog-diff-0.5.1/lib/octocatalog-diff/catalog-diff/cli/catalogs.rb:112:in `each'
  /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/octocatalog-diff-0.5.1/lib/octocatalog-diff/catalog-diff/cli/catalogs.rb:112:in `build_catalog_parallelizer'
  /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/octocatalog-diff-0.5.1/lib/octocatalog-diff/catalog-diff/cli/catalogs.rb:32:in `catalogs'
  /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/octocatalog-diff-0.5.1/lib/octocatalog-diff/catalog-diff/cli.rb:180:in `catalog_only'
  /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/octocatalog-diff-0.5.1/lib/octocatalog-diff/catalog-diff/cli.rb:88:in `cli'
  /home/rnelson0/puppet/controlrepo/vendor/ruby/gems/octocatalog-diff-0.5.1/bin/octocatalog-diff:74:in `<top (required)>'
  /home/rnelson0/puppet/controlrepo/vendor/ruby/bin/octocatalog-diff:23:in `load'
  /home/rnelson0/puppet/controlrepo/vendor/ruby/bin/octocatalog-diff:23:in `<top (required)>'

Platform and version information

Your OS: CentOS 7
Your Ruby version: ruby 2.0.0p598 (2014-11-13) [x86_64-linux]
Your version of Puppet: system: 4.5.2; gem: 4.7.0
Your version of octocatalog-diff: 0.5.1

Do the tests pass from a clean checkout?

Negative, these are the troubleshooting steps that are failing

Anything else to add that you think will be helpful?

You can find me on the Puppet Community slack most days and I can definitely set aside a chunk of time for contiguous work on this if it would help.

The pertinent error is:
OctocatalogDiff::CatalogDiff::Cli::Catalogs::CatalogError: Catalog for 'to' (.) failed to compile with RuntimeError: Unable to determine Puppet version: /usr/local/share/gems/gems/bundler-1.12.5/lib/bundler/spec_set.rb:95:in `block in materialize': Could not find rake-11.3.0 in any of the sources (Bundler::GemNotFound)

and in particular:
Could not find rake-11.3.0 in any of the sources (Bundler::GemNotFound)

I suspect you have settings in your environment that are needed to allow Puppet to run (perhaps bundler settings or the like).
During our development we ran into a bunch of problems when a different version of Ruby was used to run octocatalog-diff than was used for Puppet, so when the Puppet binary is run, it's in a very clean environment by default. source
By default we are passing only HOME, PATH, and PWD to your Puppet binary. If you want to pass other variables from your environment, there is a command line option:
--pass-env-vars VAR1[,VAR2[,...]]          Environment variables to pass

Assuming /opt/puppetlabs/puppet/bin/puppet is the default binary that ships from Puppet, then I'd be very keen to make this work with all the default arguments. Could you confirm that's a stock Puppet install and let me know what version that comes with so I can try it out?
I'm happy to debug with you in real-time via Slack, but I wanted to identify here in public what I think the problem likely is.

The agent is puppet-agent-1.5.2-1.el7.x86_64 and reports version 4.5.2. I do receive the same error if I specifically base the binary location (bundle exec octocatalog-diff -d -n build03.nelson.va -o /tmp/catalog.json --bootstrapped-to-dir=$PWD --catalog-only --puppet-binary /opt/puppetlabs/bin/puppet). Since I'm using bundler, maybe that's the interference point? I do have the rake gem, though.
$ be gem list

*** LOCAL GEMS ***

ansi (1.5.0)
bundler (1.12.5)
colorize (0.8.1)
diff-lcs (1.2.5)
diffy (3.1.0)
docile (1.1.5)
domain_name (0.5.20161021)
facter (2.4.6)
facterdb (0.3.8)
fast_gettext (1.1.0)
generate-puppetfile (0.9.11)
gettext (3.2.2)
gettext-setup (0.7)
hashdiff (0.3.0)
hiera (1.3.4)
hirb (0.7.3)
http-cookie (1.0.3)
httparty (0.14.0)
jgrep (1.4.1)
json (1.8.3)
json_pure (2.0.2)
locale (2.1.2)
mcollective-client (2.9.0)
metaclass (0.0.4)
metadata-json-lint (0.0.19)
mime-types (2.99.3)
mocha (1.2.1)
multi_xml (0.5.5)
netrc (0.11.0)
octocatalog-diff (0.5.1)
parallel (1.9.0)
puppet (3.8.7)
puppet-blacksmith (3.4.0)
puppet-lint (2.0.2)
puppet-lint-classes_and_types_beginning_with_digits-check (0.1.2)
puppet-lint-leading_zero-check (0.1.1)
puppet-lint-trailing_comma-check (0.3.2)
puppet-lint-unquoted_string-check (0.3.0)
puppet-lint-version_comparison-check (0.2.1)
puppet-syntax (2.1.1)
puppetlabs_spec_helper (1.2.2)
rake (11.3.0)
rest-client (1.8.0)
rspec (3.5.0)
rspec-core (3.5.4)
rspec-expectations (3.5.0)
rspec-mocks (3.5.0)
rspec-puppet (2.5.0)
rspec-puppet-facts (1.7.0)
rspec-support (3.5.0)
rugged (0.25.0b10)
semantic_puppet (0.1.4)
simplecov (0.12.0)
simplecov-console (0.3.1)
simplecov-html (0.10.0)
spdx-licenses (1.1.0)
stomp (1.4.3)
systemu (2.6.5)
text (1.3.1)
unf (0.1.4)
unf_ext (<IP_ADDRESS>)

Hey @rnelson0,
I pulled a brand new clean CentOS virtualbox, installed Puppet on it, installed the base control repo on it, and ran the octocatalog-diff with what I believe is the closest to your settings. I did not experience the problem you reported and was able to generate a catalog successfully (albeit one that did absolutely nothing.) I'll arrange a screen share with you on slack to see if we can nail down the exact cause of this issue.

The root cause of this is https://github.com/github/octocatalog-diff/issues/14


[Feature Request] Please add support for render buttons in searchbar

I need a search bar with button on the right side like this:

:D

@gperdomor While this might be a "hack" you can use the Grid Component and create two columns with the search bar in one column and button in another.


ImageMagick

I noticed that ImageMagick is not installed.
Thumbnails for PDF files cannot be generated because of the dependency to ImageMagick.
Do you plan to add it?

@cmmarslender maybe put this in the new Docker image?

Latest phpfpm images now come with ImageMagick.


MQTT state not updated

I have seen this scenario:
I set a sensor as immediate, I let it open, I try to arm the alarm and it does not go to "arming". So far so good.
But what I have seen too is that the MQTT playload for the state (default alarmo/state) does not change to disarmed after that.
So, any device or app monitoring the state of the alarm does not get updated.

There will only be a message sent through the state topic if the state changes.
So, no update on the state topic after sending a command, will mean that the state remains unchanged.
Messages sent through the state topic will become retained in the next update.

Then, I will wait for the next update.
Thanks a lot for your work.

The retain function is in v1.4.0.
I hope this solves your problem.
If not, please re-open this issue.


The layout of badge component is off when the screen width increases

Description

The badges' text breaks unwantedly when the screen width increases.

https://github.com/genesis-tech-tribe/nishiki-frontend/pull/113#discussion_r1434842871

This issue was already solve here
https://github.com/genesis-tech-tribe/nishiki-frontend/pull/113#discussion_r1435476324


add some tests

it would be good to add some testing, minimal would certainly do the job
There is an example of a very fully featured set of tests run by anchore/sbom-action

this GH action utilizes external program which is already tested.

good point @jkowalleck and I will close this issue


Sherpa UI implementation

Create UI for sherpa flow according to the below Mockup:
https://xd.adobe.com/view/3c65958a-a4a3-44d6-9112-3185c3024d6f-6936/

https://xd.adobe.com/view/81d78db1-c1a6-4f7d-974f-eb56167a821d-d484/


ref(tests): randomize k8s resource names in tests

Adds a RandomName() func to e2e test framework to
more easily generate a random resource name
Modifies helper functions that create resource defs to use
random resource names if resource names are not specifically
supplied to helpers
includes some cleanup of tests although more is needed in
follow up

resolves #2953
Signed-off-by: Michelle Noorali<EMAIL_ADDRESS>
Description:

Testing done:

Affected area:

Functional Area

New Functionality
[ ]

CI System
[ ]

CLI Tool
[ ]

Certificate Management
[ ]

Control Plane
[ ]

Demo
[ ]

Documentation
[ ]

Egress
[ ]

Ingress
[ ]

Install
[ ]

Networking
[ ]

Observability
[ ]

Performance
[ ]

SMI Policy
[ ]

Security
[ ]

Sidecar Injection
[ ]

Tests
[ ]

Upgrade
[ ]

Other
[ ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project?

Did you notify the maintainers and provide attribution?

Is this a breaking change?

Codecov Report

Merging #4087 (d37f288) into main (98d8904) will decrease coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4087      +/-   ##
==========================================
- Coverage   69.03%   68.78%   -0.25%
==========================================
  Files         205      205
  Lines       11242    11242
==========================================
- Hits         7761     7733      -28
- Misses       3429     3457      +28
  Partials       52       52

Flag
Coverage Δ

unittests
68.78% <ø> (-0.25%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/crdconversion/crdconversion.go
41.30% <0.00%> (-28.27%)
:arrow_down:

pkg/k8s/announcement_handlers.go
72.97% <0.00%> (-5.41%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98d8904...d37f288. Read the comment docs.


[BEAM-3713] Moving integration tests from nose to pytest

Move integration tests from nose to pytest on the following jobs:

job_PostCommit_Python
job_PostCommit_Python_ValidatesContainer_Dataflow
job_PostCommit_Python_ValidatesRunner_Dataflow
job_PostCommit_Python_ValidatesRunner_Flink

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Python Dataflow ValidatesContainer

Run Python Dataflow ValidatesRunner

Run Python Dataflow ValidatesContainer

run seed job

Run Python Dataflow ValidatesContainer

Run Seed Job

R: @udim, could you take a look at this? Thanks in advance!

Run Python 3.7 PostCommit

Run PythonDocs PreCommit

In https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont_PR/176/console I see this:
18:15:51 ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?

I see that you updated the archiveJunit paths, so it's probably because the Jenkins job config is not updated (needs a "run seed job").

rnu seed job

run seed job

In https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont_PR/176/console I see this:
18:15:51 ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?

I see that you updated the archiveJunit paths, so it's probably because the Jenkins job config is not updated (needs a "run seed job").

Thanks Udi, I think the "Seed Job" is not triggering on the comment (https://ci-beam.apache.org/job/beam_SeedJob/), I was thinking maybe because I'm not a committer and that job probably only runs on committer's PRs.

In ci-beam.apache.org/job/beam_PostCommit_Py_ValCont_PR/176/console I see this:
18:15:51 ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?

I see that you updated the archiveJunit paths, so it's probably because the Jenkins job config is not updated (needs a "run seed job").

Thanks Udi, I think the "Seed Job" is not triggering on the comment (ci-beam.apache.org/job/beam_SeedJob), I was thinking maybe because I'm not a committer and that job probably only runs on committer's PRs.

I believe this is true. And @tvalentyn had a work around for this. Maybe he could share, @udim could help with running tests.

Running a seed job from a copy of this PR: https://ci-beam.apache.org/job/beam_SeedJob/7972/ (#14629)

Run Python 3.7 PostCommit

Run Python Dataflow ValidatesContainer

https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont_PR/182/ passed and has test results correctly reported. Overall an improvement since it now has stderr/out captured.
https://ci-beam.apache.org/job/beam_PostCommit_Python37_PR/257/ timed out after 1h40m. I think the above result is enough to verify the .groovy changes.

Lint failure:
09:32:57 apache_beam/testing/test_pipeline.py:149:0: C0301: Line too long (100/80) (line-too-long)

You can run lint checks locally as well using ./gradlew lint: https://cwiki.apache.org/confluence/display/BEAM/Python+Tips#PythonTips-LintandFormattingChecks

Thanks!

Thanks to you

Is it possible this broke Python PostCommits? They've been failing since this went in: https://ci-beam.apache.org/job/beam_PostCommit_Python38/1146/


Encodes special characters in query params with percent encoding.

The '+' in our api request needs to be encoded percent encoded.
Special casing the '+' per https://github.com/daltoniam/SwiftHTTP/issues/178 since '+' is a valid character in URLQueryAllowedCharacterSet.

this seems like a good candidate for a test


Removed 3 field in Product.yaml v1.17

Pre-submission checklist:
Please check each of these after submitting your pull request:

[ ] If this is a new entry, have you submitted a signed participation form?
[ ] Did you include the product/project logo in SVG, EPS or AI format?
[ ] Does your logo clearly state the name of the product/project and follow the other logo guidelines?
[ ] If your product/project is open source, did you include the repo_url?
[ ] Did you copy and paste the installation and configuration instructions into the README.md file in addition to linking to them?

This request is not yet verifiable, please confirm that your product file ( PRODUCT.yaml ) is named correctly and have all the fields listed in  How to submit conformance results . Please make sure you included the following fields:&{map[description:{} product_logo_url:{} website_url:{}]}

/meow

/woof

This request is not yet verifiable, please confirm that your product file ( PRODUCT.yaml ) is named correctly and have all the fields listed in  How to submit conformance results . Please make sure you included the following fields:&{map[description:{} product_logo_url:{} website_url:{}]}[1]

This request is not yet verifiable, please confirm that your product file ( PRODUCT.yaml ) is named correctly and have all the fields listed in  How to submit conformance results . Please make sure you included the following fields:[One sentence description of your offering Name of the legal entity that is certifying. This entity must have a signed participation form on file with the CNCF Name of the product being certified. The version of the product being certified (not the version of Kubernetes it runs). URL to the product information website URL to the product documentation URL to the product's logo, (must be in SVG, AI or EPS format -- not a PNG -- and include the product name). OPTIONAL. If not supplied, we'll use your company logo. Please see logo guidelines Is your product a distribution, hosted platform, or installer (see definitions)]

This request is not yet verifiable, please confirm that your product file ( PRODUCT.yaml ) is named correctly and have all the fields listed in  How to submit conformance results . Please make sure you included the following fields:&{map[description:{} product_logo_url:{} website_url:{}]}[1]

This request is not yet verifiable, please confirm that your product file ( PRODUCT.yaml ) is named correctly and have all the fields listed in  How to submit conformance results . Please make sure you included the following fields:&{map[description:{} product_logo_url:{} website_url:{}]}

This request is not yet verifiable, please confirm that your product file ( PRODUCT.yaml ) is named correctly and have all the fields listed in  How to submit conformance results . Please make sure you included the following fields:

vendor
name
version
website_url
documentation_url
product_logo_url
description

This request is not yet verifiable, please confirm that your product file ( PRODUCT.yaml ) is named correctly and have all the fields listed in  How to submit conformance results . Please make sure you included the following fields:

website_url
product_logo_url
description

This request is not yet verifiable, please confirm that your product file ( PRODUCT.yaml ) is named correctly and have all the fields listed in  How to submit conformance results . Please make sure you included the following fields:&{map[description:{} product_logo_url:{} website_url:{}]}[1]

This request is not yet verifiable, please confirm that your product file ( PRODUCT.yaml ) is named correctly and have all the fields listed in  How to submit conformance results .

This request is not yet verifiable, please confirm that your product file ( PRODUCT.yaml ) is named correctly and have all the fields listed in  How to submit conformance results . Please make sure you included the following fields:&{map[description:{} product_logo_url:{} website_url:{}]}[1]

This request is not yet verifiable, please confirm that your product file ( PRODUCT.yaml ) is named correctly and have all the fields listed in  How to submit conformance results . Please make sure you included the following fields:&{map[description:{} product_logo_url:{} website_url:{}]}[1]

This request is not yet verifiable, please confirm that your product file ( PRODUCT.yaml ) is named correctly and have all the fields listed in  How to submit conformance results . Please make sure you included the following fields:

website_url
product_logo_url
description

This request is not yet verifiable, please confirm that your product file ( PRODUCT.yaml ) is named correctly and have all the fields listed in  How to submit conformance results . Please make sure you included the following fields:

website_url
description

This request is not yet verifiable, please confirm that your product file ( PRODUCT.yaml ) is named correctly and have all the fields listed in  How to submit conformance results . Please make sure you included the following fields:

website_url
description

This request is not yet verifiable, please confirm that your product file ( PRODUCT.yaml ) is named correctly and have all the fields listed in  How to submit conformance results . Please make sure you included the following fields:

website_url
description

/pony

/woof

/meow

This request is not yet verifiable, please confirm that your product file ( PRODUCT.yaml ) is named correctly and have all the fields listed in  How to submit conformance results . Please make sure you included the following fields:

website_url
description

/woof

This request is not yet verifiable, please confirm that your product file ( PRODUCT.yaml ) is named correctly and have all the fields listed in  How to submit conformance results . Please make sure you included the following fields:

website_url
description

/woof

Testing completed


Debug: trigger Read the Docs Addons event to test/debug locally

Use a mocked JSON to trigger the event that Read the Docs Addons triggers when serving docs on production.
You can build the docs via:
sphinx-autobuild -E docs docs/_build/html

and then open http://<IP_ADDRESS>:8000 locally to see it in action.
Closes #1605

Are you not using npm run dev? There shouldn't be any manual commands necessary for development like that. The changes here look like they'll be usable either way, npm run dev doesn't do anything special during the Sphinx build.

Are you not using npm run dev?

Interesting. I was not using this. I just tested it and it works great 💯


Qty Aggregated as attribute for parent product sensor

Hi again,
Thanks for product sensor attributes, but I have some enhancement.
In Grocy, app adds all the child product quantity inside to show as quantity in summary. '∑' represents it's sum.
However, for parent product sensors produced by Shopping list with Grocy, it only show attribute.qty_in_stock as '0', which is useless since attribute.no_own_stock = 1 already shows it has now own stock.
And it is cumbersome to add calculation in Lovelace. I wish if integration supports this.
So in product sensor for parent product, I think it should show value of sum. Like Grocy app, adding ’∑‘ can represent it's sum of child product's quantity.
And I wish I can get some attributes in boolean, int or float, not string.

Hello @saya6k !
I pushed a version 0.12.x where you'll be able to find both aggregated_stock and parent_product_id new attributes for each of your products
I hope it will answer your needs.
Thanks!


When enabling ssh, a restart is required. The enable-ssh command should give a hint

Command
cf enable-ssh myapp
What occurred
$ cf enable-ssh myapp
Enabling ssh support for 'myapp'...

OK
$ cf ssh 'myapp'
FAILED
Error opening SSH connection: ssh: handshake failed: ssh: unable to authenticate, attempted methods [none password], no supported methods remain

What you expected to occur
$ cf enable-ssh myapp
Enabling ssh support for 'myapp'...

OK
TIP: Use 'cf restart myapp' to ensure your changes take effect

CLI Version
cf version 6.32.0+0191c33d9.2017-09-26
CC API Endpoint Version
api version:    2.98.0

Thanks for the report!
We'll look at adding a tip for enable-ssh to restart the app to ensure the change takes affect, and also for disable-ssh to restart the app to ensure currently open SSH sessions are terminated.

@jsievers thanks for creating this issue. This issue's been documented and we are closing this due to inactivity. The v3 version of this command will work without a restart, so when we release support for v3 commands, this issue (if you are using the latest version of the CF API) should be resolved. Let us know if you have any feedback/comments by either reopening this issue or creating a new one.

Hi sorry to reopen this topic after such a long time.
Was this issue really fixed in v3?
Tried it with cf version 7.2.0+be4a5ce2b.2020-12-10 and still need to restart the app.
@XenoPhex

Hi sorry to reopen this topic after such a long time.
Was this issue really fixed in v3?
Tried it with cf version 7.2.0+be4a5ce2b.2020-12-10 and still need to restart the app.
@XenoPhex


Plugins

Issue type
[ X] Feature request
[ ] Bug report
[ ] Documentation

Environment

Python version:
Peering Manager version:

Description
Add a plugin location, where we can integrate plugins that are not part of the core system. Currently I have to plugins I want to develop but I don't think they are part of the core:

Collect flow information from flow collector API to get how match traffic do the network has we a specific peer.
External web site that can be exposed to public users allowing them to setup peering with the router automatically (example company X would like to peer with my company, they fill their information, peering-manager generates config and push to the router)

I guess this feature is actually two.
The first one is about allowing the collection of data from other tools. I doubt it could be simple to implement because it depends on what kind of tools and mostly on how to integrate these tools in the UI. So I guess it is a bit out of the scope of this project.
The second one is directly linked with issue #41. It would allow an external website to make API calls on Peering Manager so it can handle the peering setup part automatically.


[pylint] Api checker

Api version linter rule, to be merged after checkers

Did we have many libraries that had this error?


gradle, buildTools and appcompat-v7 updated to latest versions

It seems changes in the travis file needed


Corrected some grammar in Norwegian translation

The sentences were, in my opinion, a too direct translation from English. This caused a few of the sentences to sound a bit odd.

THanks


After I delete/disable a catalog, a get is called and fails with 500 error

Rancher versions: 2.0 master 12/12
Steps to Reproduce:

Add a catalog
Open dev tools
Delete the catalog

Results:  Catalog is deleted then a Get is called which ends up throwing a 500 (internal Server error) in the dev tools

similar problem  the wrong record in cattle.catalog was not removed

Version - 2.0 master 2/23
Verified fixed


rails 4 deep_clone different in development/staging and production

Dear Moiristo,
Here is my stack overflow post which describes the problem in detail. I hope you can help me here:
https://stackoverflow.com/questions/62576235/rails-4-deep-clone-different-in-development-staging-and-production
PS: I today updated to v3 of the gem. No changes.
Thanks and best regards,
Stephan

Hello,
I don't think this is related to the gem actually. Looking at your logs, my hunch is that you are rendering something on the redirect page that calls GET interactions#duplicate with the old ID again. I've seen stuff like this happen in the past caused an img attribute with the URL as its src :) To verify that something like this is happening, I'd suggest you don't perform mutations in GET requests. Always use POST instead. Then, check your browser console to see what is being sent to the server.
Hope this helps..

Hi Moiristo,
thanks a lot! It worked out for me. I rewrote the action to be POST not GET and so now only on copy is generated!
This issue can be closed!
Thanks a lot!
Cheers,
Stephan


1xA100 80GB inference in INT4?

Thanks for making such a powerful model widely available! Very impressive work to get it to run on a single node using all open source methods.
I took it for a spin on an 8x A100 40GB machine and got some nice results.
Have you tried running the model on a single A100 80GB or an H100? Can it run without off-loading the weights to CPU?
I looked at the low resource info and did some simple calculations and it looks like

The FP16 model has 260GB of weights and runs smoothly on 320GB of VRAM (eg an 8x A100 40GB or 4x A100 80GB).
The INT4 model has 65GB of weights, so it should run smoothly on 65 * 320/260 = 80 GB VRAM.

If that's the case, it'd be great to know because single-card setups are even easier to work with than single-node, and the H100s are coming soon.

Hello @charlesfrye, the actual VRAM usage for INT4 inference is around ~88G due to runtime memory consumption. Unfortunately, it's impossible to run INT4 model in a single 80G card for now. However, more advanced quantization techniques such as GPT-Q allows INT3 quantization, which can further reduce memory usage. We've got some preliminary results for this, but we haven't gotten around to putting together a release yet.

Ah bummer! Thanks for the quick reply, and thanks again for making this model!


Sun is behind the clock

Before, the sun obscured the clock in smaller resolutions (eg iPhone 5s)

Thanks, quite busy but happy with your change and will merge shortly.

Ok :)
On 8 May 2016 at 11:43, Oliver Dunk<EMAIL_ADDRESS>wrote:

Thanks, quite busy but happy with your change and will merge shortly.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/oliverdunk/LiveCode/pull/1#issuecomment-217708692

--
http://jab-jab.co.uk
Joseph Bywater / A Student
<EMAIL_ADDRESS>http://jab-jab.co.uk
[image: Twitter] https://twitter.com/thejj100100 [image: Youtube]
https://www.youtube.com/user/TheJJ100100 [image: Instagram]
http://www.instagram.com/kiwifruitapple/ [image: flickr]
https://www.flickr.com/photos/129058144@N06/


Roadmap

Hi,
Rather than having an issues with the project, I have a question.
What is the roadmap of the project ? Will or is it actively developed ? as in new features?
Cheers,

Hi,
Yes, just made a release last week to be able to paginate. For now, the client seems to fully exploit the available tasklist APIs but don't hesitate to raise an issue if you find a missing piece.
Regards!

Thanks for the info, super cool !


Look into SWC skeleton format for fibers

@willgray we'll figure this out + make a parser/converter if it looks suitable?

update: greg to make a parser


ossl_property_list_to_string() could be improved

Currently the ossl_property_list_to_string() internal function has a few nasties.  Refer to this discussion.  It boils down to:

not dealing with buffer overflows in a nice manner
not using WPACKET, instead having yet another chunk of length checking code
requires a two phase determine length then allocate & fill.  This makes using it more cumbersome

Ideally, I think this should just be called and it returns a malloced buffer where everything just fits.  This is how it is currently called everywhere.

Given that #22182 is merged, it seems like this can be closed


Style the title

Hi,
Great plugin. The only thing that I cant get to match my app's theme is the toolbar title. Is there a way to style the text for the 'staticText' property of the 'title' option? I.e. text-size, font-weight:bold, font-family etc.
Alternatively a feature to allow us to specify a centralised image on the tool-bar that could contain the text.

+1

+1

+1


Version Conflict of Kotlin

Can we add the required versions of gradle/kotlin and android plugins in the readme.

What do you mean?

What do you mean?


Performance degradation

So if I have a long running process I end up with what I would consider serious performance degradation. The following code when the process originally starts takes ms however as the process goes on the takes longer and longer no matter the size of the repository. I've seen it literally taking 10s of minutes on really small git repositories.
func (gc *GitRepository) FetchFiles() (*FileList, error) {

	if len(gc.files) > 0 {
		return &FileList{gc.files}, nil
	}

	log.Infof("Fetching files for %s", gc.name)
	ref, err := gc.repository.Head()
	if err != nil {
		return nil, err
	}

	// ... retrieving the commit object
	commit, err := gc.repository.Commit(ref.Hash())

	if err != nil {
		return nil, err
	}
	tree, err := commit.Tree()

	if err != nil {
		return nil, err
	}
	fileIt := tree.Files()

	defer fileIt.Close()
	repoFiles := map[string]File{}
	for {
		fo, err := fileIt.Next()

		if err != nil {
			break
		}
		repoFile := GitFile{
			fo:  fo,
		}
		repoFiles[fo.Name] = repoFile
	}
	gc.files = repoFiles
	log.Infof("Finished fetching files for %s", gc.name)
	return &FileList{repoFiles}, nil
}

Also may as well use this issue for the memory performance issues with this library and commits as can be seen on https://github.com/icambridge/go-git-example with symfony/symfony taking up a GB of RAM just to get the commits.
Overall I have a 8 core 16GB server processing 140 repositories an hour running out of memory.

@icambridge Thank you for the report!

Which version of go-git are you using?
How are you instantiating repositories? (NewMemoryRepository or NewFilesystemRepository)
Are you cleaning up references to repositories after you process them?

@smola

I am (or was before the last merge) using the latest master.
For the memory usage of 1GB in https://github.com/icambridge/go-git-example I am using NewMemoryRepository. In my actual app I'm using NewFilesystemRepository.
I think so yes. My memory usage goes up and down instead of constantly climbing. So I assume no memory leak. However there doesn't seem to be a close method so I'm just relying on garbage collection.

I've finally got round to adding profiling to the process. These were taken while i had 15 goroutines all taking a while in the fetch files method.
CPU snapshot

Memory snapshot

@icambridge We recently merged https://github.com/src-d/go-git/pull/218 which makes full packfile decoding (e.g. clones) both faster and with less allocations. We're planning further improvements on this front for other use cases.

Thanks, I was going to mention I've built the with latest master and performance difference is 100% improvement.

Ok. I'm closing this as fixed.
@icambridge Feel free to reopen if the problem persists.

@smola There still appears to be degrading performance, as in it slows down over time. I'm solving this myself by constantly restarting the process every 30 minutes.


Added Huffman Compressor Project

🛠 Issue (#983 )

Closes #983
Description
Added the corresponding files of the project
Type of change

[ x] Addition of new project

Checklist:

[ x] I have made this from my own
[ x] I have taken help from some online resourses
[ x] My code follows the style guidelines of this project
[ x] I have performed a self-review of my own code
[ x] I have commented my code, particularly in hard-to-understand areas
[ x] I have made corresponding changes to the documentation
[ x] My changes generate no new warnings
[ x

] The title of my pull request is a short description of the requested changes.

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

@TusharKesarwani  @zugzwang03  Please review it .
deployment link : https://deploy-preview-1348--frontendprojects.netlify.app/projects/huffmancompressor/


TRPresentTransitionMethod is not recognized as a type

Just followed you basic readme file with the example and could not recognize TRPresentTransitionMethod
So I created it myself but anyway couldn't get to work.
Also your demo project just don't go straight to the point, its very confusing...
tr_presentViewController(vc, method: TRPresentTransitionMethod.Fade, completion: {
            print("Present finished.")
        })

Maybe you need perform
$ pod install

It has been done.
Problem was after that.

I have the same issue too. Any solutions? I also did pod install

@thongtran715 I ended up creating my own transition. Better than using a pod anyway... :P

Same issue here.
Use of unresolved identifier 'TRPresentTransitionMethod'

Problem solved by adding TransitionAnimation
pod 'TransitionAnimation'
and import TransitionAnimation before using TRPresentTransitionMethod
import TransitionAnimation

@DianQK please add TransitionAnimation on the podspec

Hi~  @lfarah  I have add TransitionAnimation .
https://github.com/DianQK/TransitionTreasury/blob/master/TransitionAnimation.podspec
https://cocoapods.org/?q=TransitionAnimation

As you can see HERE, you can add a dependency on your podcast so people don't have to install 2 libraries:
s.dependency '1PasswordExtension', '1.8.2'

@lfarah  I think we often just need TransitionTreasury which help us manage custom transition animation easy. TransitionAnimation is not a common animation, when we build a app, we often have own animation. So I separated TransitionAnimation.


2087 netcdf validation

This is for release 1.11. Ready for code review.

@pkdash I modified the code based on the code review. Ready for second round of review. Thanks

@gantian127 +1. Merge after Jenkins checks are successful.


Toolgun assembles ship with weird collisions?

Describe the bug
I assembled my ship and it seems like it assembled it weirdly. It looks like a physics hitbox is surrounding the ship and it's solid and one block shorter than the ship. This makes it float off the ground by one block.
To Reproduce
Steps to reproduce the behavior:

Build a large ship (I need to do more testing)
Select the area with a tool gun
Build it
Watch the weirdness unfold

Expected behavior
My ship's hitbox should include the actual blocks on the ship and it should not float a block off the ground.
Screenshots/videos

Logs
The game logs (latest.log, debug.log).
Versions

VS2 version: 1.20.1-forge-2.3.0-beta.5
Mekanism version: <IP_ADDRESS>

This has nothing to do with kontraption. Increase LOD detail in vs_core config to make hitbox more accurate


Improve the way we handle the Form and FormInputs

Explication
Exists some problems with the actual way to handle Form, one of the problems is with ts-check. The idea is to solve this problems with this new solution.
This issue is to discuss about the new way to handle form. Next I will add a new issue to implement the decision
Checklist

[ ] We have decided how to handle the form at the issues comments
[ ] The new solution avoid ts-check errors
[ ] The new issue is opened

References
https://github.com/Azordev/dasher-user/pull/154#discussion_r751255517

check that your tasks have the corresponding labels

I think that this form handling is not correct, but to solve it can be a lot of effort


Move tests that run test kube to integration

The purpose of this is to speed up our unit tests, and eventually run the tests that depend on the test kube process as a separate integration test.

/test e2e

/lgtm


Dots on the schema names are being replaces by _

Dots on the schema names are being replaces by _. I'm using client generator with NSwag, and this approach is giving me errors .

changed the schema naming behavior in v3.2.0-beta5. so you don't need a custom schema name generator anymore.


Add missing required deps and reconcile conflicting versions

(with what's defined in dd-agent requirements files and omnibus-software)
Detected by dd-agent-testing

CI passes, merging


menc: add wait_secure flag

this patch adds a flag bool wait_secure to the mediaenc struct
the purpose is to control when the media-stream should start.
if the flag is false, the media stream will start when the SIP session
is established. if the flag is true, the media stream will start when
the menc is secure.
for example DTLS-SRTP has an async handshake after the SIP session
is established, so the flag should be set to true here.
here is a list of Mediaenc modules and the suggested flag value:

Module
wait_secure

srtp
no

zrtp
no

dtls_srtp
yes

Alfred E. Heggestad writes:

here is a list of Mediaenc modules and the suggested flag value:

Module
wait_secure

srtp
no

zrtp
no

dtls_srtp
yes

They look good to me.


Execution Context

The  runtime will use a context object to pass data to and from the Python function. This is primarily used to reference metadata and  information related to a specific execution of the function. For example -
# main.py
def main(context):
	return context.invocation_id

Similarly, the following attributes can be accessed using context:

Attribute
Description

invocation_id
Unique identifier of the function execution.

function_name
Name of your function.

function_directory
Directory path to where your script is located.

Context is accessible in two ways:

Via the reserved keyword - 'context'

# main.py
def main(context):
	return context.function_name

By declaring 'Context' type for a method argument

# main.py
def main(foo: Context):
	return foo.function_directory

This has been implemented in full and committed to the dev branch. Closing this issue, please open a new one if we need to add new methods/properties to the Context object.


I didn't find any where in the readme about sorting & filter feature ?

Hi @Lodin ,
I am working on the project. So the problem here are -

Rendering of giant data of nodes in tree (approx. 2k-3k)
Have filter & sorting feature
Performance issue of page due to such huge size of data

However, in the doc, I didn't find anywhere how to tackle with sorting & filtering feature. It would be really great, if you can direct me to the doc where these things are mentioned ?

Could you link an example where you've seen sorting of a tree structure?
For filtering I think you're "gonna have a bad time" if you're trying to show/hide nodes that match certain filters. You could however use the recomputeTree function on the tree ref to expand all nodes matching a specific filter using the subtreeCallback function. If, however, youre experiencing performance issues I would suggest not manipulating the tree all at once with a relatively complicated filter. In this case where performance is an issue I would recommend maintaining an index of the current node matching a filter and providing a button that will scroll the user to the next node matching that filter.
If you're experiencing performance issues due to tree size you will want to consider asynchronously building the tree.
demo: https://lodin.github.io/react-vtree/?path=/story/tree--async-data-with-placeholder
code: https://github.com/Lodin/react-vtree/blob/master/stories/AsyncData.story.tsx
note in the tree walker generator function the if condition that checks if the parent's data was downloaded:
if (parentMeta.data.downloaded) {


Date validation error messages suggests using an incorrect date format

Describe the bug
After entering an invalid date and clicking next, the error message that pops up suggests using "YYYY/MM/DD", but the input field expects mm/dd/yyyy.
A few nuances to consider when solving this bug:

I believe the placeholder text in <input type="date"> is dependent on the language the user sets their browser to. (Based on this stackoverflow and linked docs). So this is not always going to be mm/dd/yyyy as shown in my screenshot.
We can set the lang attribute for the input tag to force a certain language (e.g. the one selected by the user within CiviForm).

My proposed solution (open to alternatives):

Set lang="en" to ensure the format displayed to the user is always mm/dd/yyyy.
Update all message translations to use "MM/DD/YYYY".

I feel like this is the easiest solution to ensure the error message matches the input field format.
Alternatively, we could try to fully localize by setting lang to the CiviForm selected language, but this introduces room for bugs where the translation we have may not match the input date format. Also, I think applicants are used to and expect the mm/dd/yyyy format, since they are US based.
To Reproduce
Steps to reproduce the behavior:

Answer a date question with invalid date 05/05/999999
Click "Save and Next"
Look at the error text!

Screenshots

Actually based on some quick manual testing, I'm not sure if setting lang changes the date formatting. It may only be based on the user's browser's locale. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/date#value

I'm going to assume it's probably fine to leave the placeholder text for this kind of field (relating to https://github.com/civiform/civiform/pull/4099) since it actually helps the user input the value, unlike other placeholder text we had.

It seems that even changing the browser's locale still makes the input format MM/DD/YYYY, so I think we should just update all the messages.

Rather than trying to wrestle with this (because it all gets converted to a common format in the backend, this is all just UI differences), we could just say "Please enter a date in the correct format" instead?

Agree let's update the help text date format to: MM/DD/YYYY in the meantime and then update to: "Please enter a date in the correct format."

We (Arkansas) noticed this problem with date validation and the red text date format not being correct today. We'd sure like to bump this one up on the priority list since it's been hanging around for a while now.


Fix multi login with offline accounts

This code does not take into account the possibility to change the username in AsyncPreLoginEvent. For example, we ignore usernames from packages, and use our own system of usernames, in this case, if there is a player with the nickname A on the server, another player whose nickname A in the launcher will not be able to log on to the server, although he would have been assigned nickname B using a custom nickname system

This code does not take into account the possibility to change the username in AsyncPreLoginEvent. For example, we ignore usernames from packages, and use our own system of usernames, in this case, if there is a player with the nickname A on the server, another player whose nickname A in the launcher will not be able to log on to the server, although he would have been assigned nickname B using a custom nickname system
I think if you do this, then after the event. But I believe that this code should not be part of Minestom, but should be part of your server software implementation, or at least be an optional part of Minestom


feat: commands can be defined globally. fixes #707

Added global commands feature. A user can specify a table with functions that will automatically be added to all sources.
The table is config.commands and it's content is added to config[source_name].commands with vim.tbl_extend, and the "keep" option, to allow overriding the global implementation with a custom one in any source.
   require("neo-tree").setup({
     commands = {
       hello = function()            -- define a global "hello world" function
         print("Hello world")
       end
     },

     window = {
       mappings = {
         ["<C-c>"] = "hello"
                    -- define a global mapping to call 'hello' in every source
       }
     },

     filesystem = {
       commands = {
         -- override implementation of the 'hello' action in filesystem source
         hello = function()
           print("Hello inside filesystem")
         end
       }
     }
   })

This means that pressing CTRL-c in the filesystem source will result in a different effect than in other sources.
hello is therefore a global command, but in filesystem it is overwritten.

I tried to make a test for the feature, but on my setup Plenary didn't work and the test mechanism seemed rather complex.

As a quick drive by comment, you can run the tests by running
make test

in the root of the project.
There is also a dockerized version, although I haven't used it in a while:
make test-docker

@lnc3l0t the scripts/test.sh file has the code for setting up the environment. Basically cloning the plugins to the necessary location.
Are tests necessary here? I looked and there currently aren't testing for custom defined commands for each source as it currently exists either.

Are tests necessary here? I looked and there currently aren't testing for custom defined commands for each source as it currently exists either.

I'm not a stickler for tests because I don't have the time so I assume most other contributors also don't, but as a general rule I think we need way more tests than we have so don't use what tests already exists as a good benchmark for what is appropriate.

Oops, this should have been targeting main instead of the release branch. I missed that one and merged it to 2.x accidentally, I'll try to move it to main now...


Testnet v3.3: Unhandled top-level exception: $exn / Unconsumed item in cache: $cache

Summary

started coda daemon via coda daemon -peer $SEED1
set staking: coda client set-staking -public-key $CODA_PUBLIC_KEY
SEED1 and CODA_PUBLIC_KEY are set.

Error
2020-09-19 15:33:43 UTC [Info] validating a new pubsub message ...
2020-09-19 15:33:43 UTC [Info] validating a new pubsub message ...
2020-09-19 15:33:43 UTC [Info] validating a new pubsub message ...
2020-09-19 15:33:43 UTC [Info] validating a new pubsub message ...
2020-09-19 15:33:43 UTC [Info] validating a new pubsub message ...
2020-09-19 15:33:46 UTC [Info] why u fail to validate :(
2020-09-19 15:33:49 UTC [Warn] writing to closed pipe "(\"valid transitions\")"
2020-09-19 15:33:49 UTC [Fatal] Unhandled top-level exception: $exn
Generating crash report
        exn: "(monitor.ml.Error\n  (\"write to closed pipe\"\n    (pipe\n      ((id 98) (buffer ()) (size_budget 0) (pushback (Full ()))\n        (num_values_read 0) (blocked_flush
es ()) (blocked_reads ())\n        (closed (Full ())) (read_closed Empty) (consumers ())\n        (upstream_flusheds ()))))\n  (\"Raised at file \\\"src/error.ml\\\" (inlined), lin
e 9, characters 14-30\"\n    \"Called from file \\\"src/error.ml\\\", line 11, characters 19-40\"\n    \"Called from file \\\"src/pipe.ml\\\", line 510, characters 2-15\"\n    \"Ca
lled from file \\\"src/deferred1.ml\\\", line 17, characters 40-45\"\n    \"Called from file \\\"src/job_queue.ml\\\" (inlined), line 131, characters 2-5\"\n    \"Called from file
\\\"src/job_queue.ml\\\", line 171, characters 6-47\"\n    \"Caught by monitor coda\"))"
2020-09-19 15:33:49 UTC [Info] Starting Bootstrap Controller phase
2020-09-19 15:33:49 UTC [Error] Unconsumed item in cache: $cache
        cache: "cached item was not consumed (cache name = \"Transition_handler__Unprocessed_transition_cache\")"
  ☠  Coda Daemon crashed.
   The Coda Protocol developers would like to know why!
    Please:
      Open an issue:
        <https://github.com/CodaProtocol/coda/issues/new>
      Briefly describe what you were doing and attach the crash report /home/bakebrain/.coda-config/coda_crash_report_2020-09-19_15-33-49.843948.tar.gz

version
bakebrain@coda-daemon-1:/usr/local$ coda -version
Commit 4395e91 on branch master

status just before crash
Global number of accounts:       1017
Block height:                    1
Max observed block length:       1
Local uptime:                    5m58s
Ledger Merkle root:              jxH4Qmdt5jFUoVupEihNvVBpSh2oiN4cSjDqgpS7oq9Bsdat4U2
Protocol state hash:             3NLwBcsoZBdUGtndj14Cts5SRDwx3xvk4jEYAqBNRJ87BVzKuesM
Chain id:                        b90b8b744074d8cc9d864925b58d1f882b1c2e89a46245be3e0a969d39de43a0
Git SHA-1:                       4395e9162b55323e76141c174ed585a0bf8cce81
Configuration directory:         /home/bakebrain/.coda-config
Peers:                           5 (<IP_ADDRESS>:10008 <IP_ADDRESS>:10007 <IP_ADDRESS>:10001 <IP_ADDRESS>:10009 <IP_ADDRESS>:10005)
User_commands sent:              0
SNARK worker:                    None
SNARK work fee:                  25000000
Sync status:                     Synced
Block producers running:         1 (B62qjx6vxaWNfn75FB295M6K56brKA6eq3cHHibd8EJz5Wkcw2PWxrG)
Best tip consensus time:         epoch=0, slot=0
Next block will be produced in:  None this epoch… checking at in 4.452h
Consensus time now:              epoch=0, slot=390
Consensus mechanism:             proof_of_stake
Consensus configuration:
        Delta:                     3
        k:                         20
        c:                         8
        c * k:                     160
        Slots per epoch:           480
        Slot duration:             3m
        Epoch duration:            1d
        Genesis state timestamp:   2020-09-18 20:00:20.000000Z
        Acceptable network delay:  9m
Addresses and ports:
        External IP:    <IP_ADDRESS>
        Bind IP:        <IP_ADDRESS>
        Libp2p PeerID:  12D3KooWQKhxjckkDVBBrF5ncHTTkz56UBxQpfhL4XrUt91CMZHk
        Libp2p port:    8302
        Client port:    8301

log
coda_crash_report_2020-09-19_15-33-49.843948.tar.gz
discord
powersource#7803

Also experiencing this and is also mentioned in this issue as #4 https://github.com/CodaProtocol/coda/issues/4480

Closing, this was fixed in #6357.


Adding specific Int64 type support

On 32-bit platforms (namely iPhone 4S, iPhone 5 for iOS8+) the Swift Int type only goes up to 2^31.  Even though there is technically no limits placed upon JSON numeric values, they are often designed around JavaScript clients which have a maximum integer value of 2^53.  I've added explicit support for the Int64 type to support this limit.
In order to get around Xcode 6.3/Swift 1.2 (see #106) limitations, I split out the numeric tests into a sub-model.  Using the solution presented in #5 didn't seem to work.

Probably important to mention that if a numeric value of greater than 2^31 is present in the data and you are on a 32-bit device using a plain Int type, you get a silent overflow on decoding.

Killer. I'm going to reword your commit message to include some of the info you've provided here and then merge it in.

Done in ddee5da

Awesome, thanks!


Dagger 2 support

The differences between Dagger 1 and 2 are not trivial, so would be nice if this sample used Dagger 2 instead of Dagger 1.

Right now we're using Dagger 1 internally and probably not upgrading any time soon so I'd prefer to keep this app matching. This will make it easier to include more of our internal structure here in the future. That's not to say we won't upgrade, it's just not a high priority right now.

@AlexBravo I've forked the project and added Dagger 2 support here https://github.com/prolificinteractive/u2020 everything else remains the same other than that.

It would be nice indeed to see u2020 migrated to Dagger2.  Is there a reason you are still using Dagger1 internally?

It serves our use case much better than Dagger 2. We leverage granular overrides in the runtime and its flexibility for testing that cannot be achieved in v2 without far too much ceremony.

I see.  I am wondering why they had to go invent Dagger2 when Dagger1
worked perfectly fine?  I mean it's such a headache for other developers to
make this switch....
On Oct 22, 2015 1:16 PM, "Jake Wharton"<EMAIL_ADDRESS>wrote:

It serves our use case much better than Dagger 2. We leverage granular
overrides in the runtime and its flexibility for testing that cannot be
achieved in v2 without far too much ceremony.
—
Reply to this email directly or view it on GitHub
https://github.com/JakeWharton/u2020/issues/158#issuecomment-150294762.

No one is forcing you to switch. It was created with very specific use cases in mind which were unsolved by Dagger 1. It shouldn't have been called Dagger 2 but something else.

Nobody is forcing me to do anything, I know.  But the general sentiment is
that if something is called "Something2", then it must be better than
"Something1".  And most developers (naive like myself) will feel the urge
to update to "Something2".  You are right, they shouldn't have called it
Dagger2 if it is so drastically different and hard to migrate from Dagger1.
Thanks,
Igor
On Thu, Oct 22, 2015 at 1:18 PM, Jake Wharton<EMAIL_ADDRESS>wrote:

No one is forcing you to switch. It was created with very specific use
cases in mind which were unsolved by Dagger 1. It shouldn't have been
called Dagger 2 but something else.
—
Reply to this email directly or view it on GitHub
https://github.com/JakeWharton/u2020/issues/158#issuecomment-150295313.

Never mind people who upgrade.
What about the new people who are about to use Dagger for the first time?
Would they use Dagger or Dagger 2?
This needs to be resolved somehow...
Any chances that Dagger 3 will unify the use cases of both Dagger 1 and 2?

That's a great question.  I myself was in that boat a few months back.  I
was led to believe that Dagger1 is deficient.  So I spent time learning
Dagger2.  But now I don't know why.
On Oct 22, 2015 8:05 PM, "Alex Bravo"<EMAIL_ADDRESS>wrote:

Never mind people who upgrade.
What about the new people who are about to use Dagger for the first time?
Would they use Dagger or Dagger 2?
This needs to be resolved somehow...
Any chances that Dagger 3 will unify the use cases of both Dagger 1 and 2?
—
Reply to this email directly or view it on GitHub
https://github.com/JakeWharton/u2020/issues/158#issuecomment-150391660.

The big thing that Dagger 2 has that Dagger 1 does not (unless you are on a very early build of Dagger 1) is the ability to support Proguard obfuscation.
The big problem with Dagger 2 is that it requires compile-time static linking to an injection method on the component which unfortunately has lead many people down very bad paths where people are actually using a dependency injection framework in a manner that is doing service lookup instead of dependency injection. If you see things like components being instantiated within the actual object being injected (or even just slightly hidden behind another method but still bound at compile time) then run away, this is not dependency injection. By the way, most of the Dagger 2 examples do this.
There are some libraries that try to aleviate this see Bullet (https://github.com/tbroyer/bullet) or my preliminary rewrite of Bullet (https://gitlab.com/NobleworksSoftware/NobleInjection/tree/master). These libraries try to add the ability to have a generic injection method on the component (e.g. inject(T t)).

@dalewking I don't understand.  It sounds like you're saying Dagger2 is a mistake for most developers to try and use.

What I am saying is that it is hard to use Dagger 2 correctly and the way it is designed sort of encourages people to use it incorrectly. It requires extra care and even extra libraries to use it in a good way. This is one of the few articles that I have seen actually discuss the issue: https://blog.gouline.net/2015/05/04/dagger-2-even-sharper-less-square/, see Annoyances section, but the issues is bigger than that and I do not like the runtime reflection solution.
There are two issues, how do you determine the correct component to do the injection and given the correct component how do you call the injection method. What most people end up doing is binding at compile time what component is used and calling the method. Either they actually instantiate the component inside the object being injected or perhaps hide it in a base class. But then substituting what gets injected for unit testing e.g. becomes a near impossibility, thus you are not doing dependency injection.
What I did in my library is two-fold. I provide an injection service singleton (see https://gitlab.com/NobleworksSoftware/NobleInjection/blob/master/android-injection-service/src/main/java/com/nobleworks_software/injection/android/InjectionService.java) that you set up in initialization. Things like an Activity just need to call InjectionService.inject(this); to be injected which is pretty much the best we can get. The activity itself then has no knowledge of what component is used as is should be.
The second part is tackling calling the correct injection method based on an arbitrary class since Java does not do double dispatch. One way is using reflection as explained in that article, my solution is a rewrite of the Bullet library which uses annotation processing to generate a generic wrapper around the Dagger 2 component to give you a generic method to call for injection Bullet had the right idea, but a horrible implementation (but there is a PR based on my work to fix that). This annotation processing could be done much easier and more efficiently inside of Dagger 2.
For some other discussions I have been involved with on the subject see:
https://github.com/google/dagger/issues/213
https://github.com/tbroyer/bullet/issues/2
https://github.com/google/dagger/issues/110
I took an existing Dagger example and rewrote it to use my library. I didn't use u2020, because u2020 didn't really use subcomponents which I wanted to demonstrate. See:
https://gitlab.com/NobleworksSoftware/NobleInjection/tree/master/githubclient-example/src/main

No plans for this.


Slightly inefficient ElasticSearch Aggregation Query

Describe the bug
The query that populates the sidebar is setting the size to a non-zero value, resulting in a slightly inefficient query.
To Reproduce
Steps to reproduce the behavior:

Open developer tools in your browser
Go to search page
Clear network requests (makes it easier to find the one we're looking for)
Click on the WDL facet
Click on the first API request, then the response tab
See the hits.hits field is populated with a bunch of hits, and the took field is some value. Not too large, currently 79 for me on prod, but larger on qa, 147, where we're experimenting with a smaller ES configuration.

Expected behavior
The hits.hits in the response should be an empty array. The took time should be smaller, ideally a single digit.
Screenshots

Additional context
The fix won't have as dramatic an effect as the fix for #5220, but it will help a little.
[Domain] - https://qa.dockstore.org
Webservice - 61861c1
UI - 2.10.1-24-g4be31c82
Compose Setup - 0ddff40
Deploy - 1.13.2-14-gf9d7293
cwlParsingLambdaVersion: n/a
wdlParsingLambdaVersion: n/a
nextflowParsingLambdaVersion: n/a
galaxyParsingLambdaVersion: 0.0.6
checkUrlLambdaVersion: n/a
┆Issue is synchronized with this Jira Story
┆Fix Versions: Dockstore 1.14
┆Issue Number: DOCK-2287
┆Sprint: 101 - Cheeks, Sandy
┆Issue Type: Story

Notes for the reviewer: I took at look at QA myself because I was curious, and:

The performance difference is subtle and and usually only kicks in the second time you query on a facet, e.g., toggle WDL facet on/off/on/off, and the took field in the response is in the single digits for the second on/off.
Main thing to verify would be to ensure that facets are working as expected.


ROX-12848: Set Postgres flag to permanently enabled

Description
Sets the Postgres flag to always be the default value of the setting
Tests that need to be ported:

Central/deployment/index/search_comparison_test.go
Central/splunk/violations_test
TestImageLoader - graphql/resolvers/loaders/images_test.go
TestImageIntegrationDataStore - central/imageintegration/datastore/datastore_impl.go
TestProcessBaselineService - central/processbaseline/service/service_impl_test.go
Role/datastore/datastore_test.go

Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
CI

/test openshift-newest-qa-e2e-tests openshift-penultimate-qa-e2e-tests openshift-oldest-qa-e2e-tests

/test openshift-newest-qa-e2e-tests openshift-penultimate-qa-e2e-tests openshift-oldest-qa-e2e-tests

The fact that all openshift-*qa-e2e-tests failed worries me. For example:
Requesting stop of task ':testBAT' as it has exceeded its configured timeout of 3h.

Are we sure these failures are not related to this change @connorgorman ?


Check fail on several tokens

The test fail (return HP - transfer failed) on several tokens, where on others check site they are correctly reported with the right taxes.
Example: bsc 0x3f203c1403ce39d4d42c4667287a7fb2b1db1066

The test fail (return HP - transfer failed) on several tokens, where on others check site they are correctly reported with the right taxes.
Example: bsc 0x3f203c1403ce39d4d42c4667287a7fb2b1db1066

Binance Chain is not supported by this repo, for Binance there are better alternatives.

The test fail (return HP - transfer failed) on several tokens, where on others check site they are correctly reported with the right taxes.
Example: bsc 0x3f203c1403ce39d4d42c4667287a7fb2b1db1066

Binance Chain is not supported by this repo, for Binance there are better alternatives.

Why it should not be supported? is there any tech difference from other chains?
The same tested contract i posted above deployed on a supported chain will still fail.

Because there is community accepted Tax/Honeypot checker for BSC network which is the https://honeypot.is .
This repo is made to make an universal contract for chains where is no other alternative. Feel free to deploy to BSC.

Because there is community accepted Tax/Honeypot checker for BSC network which is the https://honeypot.is .
This repo is made to make an universal contract for chains where is no other alternative. Feel free to deploy to BSC.

I did deploy on BSC to test the success rate of the tester vs other popular tester, as the one you pointed out, and that's how i realized that the current version show several tokens as Honeypot when they are not, and that is what i was reporting .
The same token contract if forked on a chain you directly support will still fail the check, no matter what the chain it is deployed on.

The same token contract if forked on a chain you directly support will still fail the check, no matter what the chain it is deployed on.

Please give some example, we are using this contract and not experienced false report unless the contract / LP has some issue.

The contract i posted on the first post, the check for that CA succeed on ishoneypot but fail with the contract from this repo
0x3f203c1403ce39d4d42c4667287a7fb2b1db1066

The contract i posted on the first post, the check for that CA succeed on ishoneypot but fail with the contract from this repo
0x3f203c1403ce39d4d42c4667287a7fb2b1db1066

There is no BSC support in this repo, so it is expected that it will fail.

The contract i posted on the first post, the check for that CA succeed on ishoneypot but fail with the contract from this repo
0x3f203c1403ce39d4d42c4667287a7fb2b1db1066

There is no BSC support in this repo, so it is expected that it will fail.

I deployed your contract checker on BSC and it fail with it.
You can fork 0x3f203c1403ce39d4d42c4667287a7fb2b1db1066 on your favorite chain or testnet and check on that if you prefer, i don't see why the results should be any different

Okay, I deployed the contract for you:
0x3f203c1403ce39d4d42c4667287a7fb2b1db1066
BSC MainNet {   buyTax: 14.999999788758412,   sellTax: 13.279372300708047,   buyGasCost: '153334',   sellGasCost: '296250',   isHoneypot: 0 }

It's working fine you are right, i realized that i was testing with a 2 BNB buy which was too much for that token, that was the only reason why it was returning
buyTax: -1, sellTax: -1, isHoneypot: 1, error: Error: Returned error: execution reverted: Pancake: TRANSFER_FAIL
great and gj!