file input inside vex.open()

I'm trying to implement a file upload functionality with vex.
This is my code (taken from the documentation):
vex.dialog.open({   message: 'Select your document',   input: [     '
',     'Document',     '
',     '<input name="ed_doc" id="ed_doc" type="file" />',     '
',     '
Accepted file formats: .docx, .doc and .otf
',     '
'   ].join(''),   callback: function(data) {     if (!data) {       return console.log('Cancelled')     }     console.log('File', data.ed_doc)     console.log(data);   } });
However this always returns "undefined" in the callback function.
Are file inputs something that can be done with Vex?

I am also having this issue and am interested in whether it is possible.


Introduce Dockerfile for ndnd binary

The .sample should be kept in the filenames.
These sample files are not meant to run directly, but needs to be customized.by the operator.
They are included in the container so that the operator can find them easily, which can be extracted with docker cp command.
In contrast, if the operator must download the sample config from git repository, they would have to track down the proper git repository and commit hash.


Use consistent syntax when referencing variables in scripts

At the beginning of this article it says that in scripts (which includes inline script blocks a la script: ...) you have to use normal environment variable syntax of the respective shell. Some of the following examples follow this, but then for some reason the Counters example and some of the following ones use the $(..) syntax, which is confusing.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dd7e0bd3-1f7d-d7b6-cc72-5ef63c31b46a
Version Independent ID: dae87abd-b73d-9120-bcdb-6097d4b40f2a
Content: Pipeline variables - Azure Pipelines
Content Source: docs/pipelines/process/variables.md
Product: devops
GitHub Login: @andyjlewis
Microsoft Alias: alewis

Updated the doc with more examples to clarify this.

Please reference the commit/PR so that I can have a look.


⛓ Don't break the chain: Propagate caught exceptions

When investigating for https://github.com/andregasser/bigbone/issues/280#issuecomment-1761414760 I noticed that we throw a BigBoneRequestException but completely remove any knowledge about prior exceptions that led to this issue.
Proposal: We should try to propagate exceptions by always calling the constructor(message: String, e: Exception) constructor that allows a root cause to be passed so that the stacktrace contains all necessary information and doesn’t just start with where we threw an exception.
Sometimes, we return null in some catch statements. Not sure where to start there. I think it could make sense to return non-nullable types instead and throw the exception unless it’s an expected exception (date formatting/parsing or similar for example where it’s okay and almost expected that things can go wrong).
(ℹ If proposal is accepted, I’d like to implement this, so feel free to assign me. @andregasser)

@bocops @andregasser Do you have an opinion about nullability VS throwing exceptions as described in my third paragraph?


Add neutral color variants

Hi, this PR adds neutral variants just like base.
So base has base-100, base-200 and base-300 but I felt that having neutral variants would benefit DaisyUI a lot since I couldn't find a better way for text coloring.
So, this is a PR that introduces that feature with:
neutral
neutral-200
neutral-300

This won't break anything as neutral is treated as neutral-100. I'm sorry for creating a PR directly without creating an issue but I thought it'd be better this way. Please let me know if there's anything wrong in my PR and if the idea of adding neutral variants is not a good one. I wouldn't mind any of your decisions, thank you.

Can you please save your file without formatting?
Because this PR is really really hard to review when your editor changed formatting on all the lines where there's no edit (adding ;s, indentations, etc.)
Only the lines with actual changes should be committed.


Properly Handle Lifecycle Events to Prevent Video Playback in Background

Description:
When the app is paused, video playback continues in the background, leading to unintended behavior. This issue affects the app’s performance and user experience, as videos should be paused when the app is not active.
Steps to Reproduce:
Launch the app.
Start playing a video.
Minimize or close the app without stopping the video.
Observe that the video continues to play in the background.
Expected Behavior:
When the app is minimized or terminated, video playback should pause to prevent background activity.
Actual Behavior:
The video continues to play in the background even after the app is minimised.

Hi @sudheer11002 , thank you for raising this issue.
Are you using setAllowBackgroundPlayback() method on the player?
Example: https://github.com/THEOplayer/flutter-theoplayer-sdk/blob/develop/flutter_theoplayer_sdk/example/lib/main.dart#L60
If that's true, the player will keep playing in the background. (opening up the possibility to connect it to e.g. notification center or mediasession on the app-level)
Try to set It to false, then the player should behave as you expect.
Does this help?

Closing the issue as it seems a configuration problem.
If you can still reproduce the issue with allowBackgroundPlayback=false, feel free to re-open the ticket.
Thank you,
Daniel


express-checkout.e2e-spec.ts failing

**after merging the new features to develop on sept19 (release 1.2.x) , the following tests have been failing and need to be fixed:
regression/express-checkout.e2e-spec.ts
it's expecting the cart to have 1 product, but the cart is empty, so it fails.

Fails because of this issue: https://github.com/SAP/cloud-commerce-spartacus-storefront/issues/4155#issuecomment-534010526
On hold

It's fixed now. Test is passing in the nightly builds, and also when I run it locally against dev17.


mitmproxy display "\t" as "?"

Steps to reproduce the problem:

My request's ua has "\t" and mitmproxy display it as "?".

What is the expected behavior?
Normally "\t" display as blank, like fiddler and charles.
What went wrong?
Any other comments?

Mitmproxy Version:0.17.1
Operating System:OS X 10.11.4

Where do you see this? Could you post a screenshot please?


[Feature] Manually add columns in tables

Is your feature request related to a problem? Please describe.
I am using wandb for kaggle trainings now but the problem is that I am not able to update test set score for a particular model in tables tab.
Describe the solution you'd like
Give add, delete, edit, update option in columns of tables
Describe alternatives you've considered
Writing in reports but can't compare in the tables column.

Hi @harveenchadha can you please post a screenshot of the table you're trying to update? It seems like this could be better achieved by joining two tables but I'd like to understand your use case more.

For example if I want to add a new column here in which I can save the test set results. There is no way to do it and hence I cannot track parameters outside of my model training.

So if you logged something during the run or even added something to the run summary post run using the API, then you should be able to visualize that value as a column in your runs table. My two suggestions would be to 1). update the run summary using the API to include the test set results or 2). create new runs with job_type="testing" that take in the model artifacts and testing set as inputs. You could then visualize the results of just the testing jobs through a simple filter and be able to see which run produced the model that achieved that test score.

This issue has gone stale and we are now closing it. Please comment to reopen.

I also need that feature. Sometimes, we can come up with new metrics or new information that comes from old columns. Therefore, it is better to allow quick manual creation instead of rerunning.

+1

I need to use spreadsheets to track additional info, and this feature would be very valuable


MiqProductFeature - fewer queries to load cache

We load (and cache) product feature identifiers on the first request. This only ever happens once in production mode. This happens often in development mode.
Since this query takes up a page in the logs, it makes collection of metrics difficult.
While this does improve production performance, most of the gains will be seen in development mode.
Summary

ms
bytes
objects
queries
query (ms)
rows
log lines
comments

608.6
56,575,039*
712,271
3
54.1
2,622
45
master

85.5
5,099,101*
54,285
1
19.6
1,129
4
PR

86%
91%
92%
67%
64%
57%
91%
diff

* Memory usage does not reflect 143 freed objects. (in both cases)
before

ms
bytes
objects
queries
query (ms)
rows
comments

608.6
56,575,039*
712,271
3
54.1
2,622
master

24.1

1
2.6
1,129
SELECT "miq_product_features"  -- [59]

6.2

1
2.6
365
SELECT "miq_product_features"  -- [1908]

23.8

1
10.7
1,128
SELECT "miq_product_features"  -- [5771]

* Memory usage does not reflect 143 freed objects.
If you note, the queries are 7,738 characters (~1 page)
after

ms
bytes
objects
queries
query (ms)
rows
comments

85.5
5,099,101*
54,285
1
19.6
1,129
feature_load_query

19.6

1
2.9
1,129
SELECT "miq_product_features" -- [474]

* Memory usage does not reflect 143 freed objects.
If you note, the query takes 474 characters (4 lines)
/cc @chrisarcand thanks for help

@gtanzillo added tests for the method changed

@kbrock Will get to this soon.


Debugger doesn't pause at breakpoints

I'm having an issue was hoping I could get some help with configuring Atom and Xdebug. I can set breakpoints and they show up in the breakpoint panel, but the process never pauses. Oddly, the process does pause on a exception warning, so I know it's connecting somewhat, but just not pausing at breakpoints.
My php.ini is as described in the readme:
    xdebug.remote_enable=1
    xdebug.remote_host=<IP_ADDRESS>
    xdebug.remote_connect_back=1    # Not safe for production servers
    xdebug.remote_port=9000
    xdebug.remote_handler=dbgp
    xdebug.remote_mode=req
    xdebug.remote_autostart=true

Here's my settings:
    "php-debug":
        PhpException:
          Warning: false
        PathMapping: [
          {
            local: "C:\\wamp\\www\\sgn\\com-forums\\www\\index.php"
            remote: "localhost/sgn/com-forums/www/index.php"
          }
        ]

I'm developing locally using WAMP, xdebug 2.3.5, Atom 1.2.3, & php-debug 0.1.4. As well, I'm using Chrome with Xdebug helper. What should the idekey be? Any ideas why it isn't working?

This has been adjusted with the latest release. The new format is "remotepath;localpath".
Your Example would be
PathMaps: [
  "localhost/sgn/com-forums/www/index.php;C:\\wamp\\www\\sgn\\com-forums\\www\\index.php"
]


Need a 'graceful landing' if someone goes to a screen they don't have access to while logged in.

Summary
If someone goes to a screen they don't have access to while logged in (usually through a link they have saved), take them to their own dashboard screen, with an error message.
Why
There are several people who have multiple roles.  We're frequently seeing cases in bugsnag where people are trying to go to a screen they can't access in their current role.  We'd like this to be gentler than a 500 error.
Details
If someone is logged in, but attempting to access a screen they can't,  redirect them to the dashboard for their current role and show an error "That screen is not available.  Please switch to the correct role and try again."
Recreation
Create a new user that  is both a org admin and a partner.
Log in as that user
As the org admin,  go to a report, and grab the link for that.
Switch to the partner role
Go to that link
Current:  you get a 500 error
Desired:  redirect to the partner dashboard with the above message.
(Similarly for the opposite case where you are going to a partner page from the org admin)
Criteria for completion

[ ] above behaviour across all screens
[ ] automated tests to demonstrate the behaviour

@cielf to clarify you mean something like:
I log in a partner and go to http://localhost:3000/reports/annual_reports/2023 and get hit with

?

The particular error that's coming up in that case is because they don't have a 'current organization" because they are signed in as a partner.    I think that's going to be the kind of thing that currently happens on most of the relevant cases, but/and they shouldn't be able to access any of the views that require org_user or org_admin status when logged in as a partner.       Does that help?

Hey all,
With apologies for forging rashly ahead (I took a look at this to see if I could figure it out, and by the time I figured out I could, well, it was mostly done) I'm working on a draft for this one: https://github.com/rubyforgood/human-essentials/pull/4650
I still have some tests to write, and per the reqs need to bubble up a slightly more helpful message than Access Denied, but put up a draft bc I find it it helpful to see in diff view (and so folks can chime in if I've totally misunderstood something here!)

It might be a day or two before anyone has a chance to take a look at what you've done,  but I've assigned it to you.

thanks @cielf! I'll try to get the rest of my ducks in a row here meanwhile :)

@therufs not sure I understand what's changed in that PR. As far as I can tell you renamed a method, but I don't really see how that fixes this problem?

Hey @dorner -- sorry I missed this when it was fresher! The renamed method is now being called as a before_action in the annual_reports_controller and reports_controller (which other reports inherit from). As in the screenshot elasticspoon and cielf were discussing above, the 500 error we're currently seeing is due to those reports trying to look things up on nil orgs, so the before methods should ascertain that the user persona who's trying to access the report has the necessary information to successfully find an org.

I'm still a bit confused.
ApplicationController has this as a filter:
  def authorize_user
    return unless params[:controller] # part of omniauth controller flow
    verboten! unless params[:controller].include?("devise") ||
      current_user.has_role?(Role::SUPER_ADMIN) ||
      current_user.has_role?(Role::ORG_USER, current_organization) ||
      current_user.has_role?(Role::ORG_ADMIN, current_organization) ||
      current_user.has_role?(Role::PARTNER, current_partner)
  end

Are you saying that in the case of the 500 error, some of the other checks are stopping this from doing verboten!? If so, which? I can't see the logic that this would help with.

tl;dr: No, I think verboten! still runs, but since the conditionals we're checking before we run it still permit users who currently have the PARTNER role, and users who currently have the PARTNER role have a current_organization of nil, we still end up having problems. Or, put another way, the "user" that's being authorized in this authorize_user is too broad a net for these specific cases, so we need to check specifically that the user is an ORG_USER or admin.
Deeper exploration, following through the stack trace above from the bottom:

The user is in the PARTNER role, so the current_organization helper doesn't find anything (and does not raise an error).
the annual_reports_controller asks Reports to retrieve_report, passing organization: current_organization (nil).
AnnualReport.find_or_create_by is called with report_attributes that include the nil organization. (On the topic of not raising errors, AnnualReport does not seem to immediately care that its organization is nil, which I would have guessed belongs_to would validate -- possibly the error ends up getting bubbled up before the validation occurs?)
Reports#all_reports generates an array of new different types of Report, with organization: organization (nil)
the new report in question finally tries to ask something of the nil organization, specifically in the example for the total_disposable_diapers_distributed in the time specified
Nil cannot respond to the inquiry, NoMethodErrors (500s to prod users) ensue

As a meta observation, while this issue is specifically about reports, the same error is generated when a partner visits any page that is only accessible to org users (e.g. /purchases). This problem doesn't go the other way, because the BaseController that partner-related controllers inherit from already handles a redirect for users without appropriate credentials. If we wanted to commit to the bit, we could refactor the controllers that handle org actions to inherit from a similar specialized class that could implement and call a require_org?

Yep, that's what I think we need to do. Now I get why this is happening, but your current fix doesn't go far enough. Your suggestion is what I would go with. Rather than inheriting, maybe we could create a module that all the org controllers include (because otherwise I think we'd have to mess with all the routes to make it make sense).

🤦🏻  amazing job me, I picked the obvious test case and then in the interim forgot there were other cases. I will keep working on it!


Exclude CMakeLists.txt from package targets.

This PR silences some warnings from SwiftPM now that we have CMake support since SwiftPM doesn't recognize the CMakeLists.txt files used by CMake.
Checklist:

[x] Code and documentation should follow the style of the Style Guide.
[x] If public symbols are renamed or modified, DocC references should be updated.

@swift-ci please test

Windows failure is a known compiler issue.


make collapsedText theme-able

Issue
Fixes #172881
Changes
Change the default color of collapsedText (the "..." at the end of a folded line) from a fixed color in folding.css to be a registered color under  editor.collapsedText. #808080 is grey.

hey @aeschli @Tyriar, noticed that this got approved. Do I need to do anything from my end to let it merge?


How to reduce the TimeElapsed interval?

Hello!
I would like to display a progress bar under a video using your component.
I can use the TimeElapsed event handler, but the TimeElaspedInterval is an integer, so the minimum interval that I can set is 1 second, and I would like it to be more frequently called (each 0.1 second for instance).
I wanted to check if a native property could help, in the renderers. For Android, the Control has indeed a TimeElapsedInterval property which is a double, so I can set it at 0.1 second. However for iOS I can't find such a property.
Is there any way ?
Also, I noticed that on a Android 6.0 device, the TimeElapsed event handler isn't called anymore when the video restarts (with Repeat="True").
Thanks!
Emmanuel
PS: I'm using the trial version.

Unfortunately Android didn't have a time elapsed interval event by default and I had to build it custom for that platform to match the others. I ended up using a timer object to keep track of when to fire the event and had to extend both my VideoPlayerRenderer and also Android's MediaPlayer to support what I needed to accomplish this. You could extend VideoPlayerRenderer and add a timer that supports fractional seconds but an easier approach to try first might be to just stay in the cross-platform project, add a timer there and set it to start and stop when the Playing/Paused/Completed events occur.


Centralize jest + babel config at repo root

This is a WIP

Closes #6921
Summary
This is a first rough cut to show the general idea. There are a few ways you could achieve this with the Babel setup + Lerna commands.
Here, we're opting for a single babel.config.js file at the repo root, as suggested in the Babel Docs. The one caveat to this is that the React Native sub-package has it's own setup , and so it uses the babelrcRoots config with its own .babelrc.js config.
To run the tests, simply run at the repo root:
yarn test

To run the full test suite, or
yarn test react-router-config

to run a limited set of tests.
What's included

Lifts the Babel config to the monorepo root
Lifts the Jest config to the monorepo root

Notes

All tests pass, with the exception of (some of) the React Native tests. I'm not familiar enough with RN setups to easily figure this out. Will have another stab at it, but any thoughts/hints would be helpful.

Thank you for taking a stab at this, @tgallacher! I really appreciate it. react-router-native is going to be the tricky part.

Got a bit side-tracked by delayed work stuff. I'll continue digging into fitting the RN setup into the repo. Found Jest "projects" (not pushed yet) which seems to provide different error, which may be more encouraging 🤷♂

ok. I've tried A LOT of permutations of the config (jest, babel) with varying results, as there is so many ways you can slice this with the different options between Jest and Babel..
The general problem is with Babel 7's default file config merging behaviour, which leads to a slightly overly complicated project-wide config. So, i've put the Babel config for RN package inline to the Jest config -- although I still believe this might be merged with the root babel.config.js file, even though the inline config is set to not look for it.. Still thinking on this.
Nevertheless, this is where I'm at:

I don't really have the RN background to understand the typical setup, so anyone that might have seen this before; pointers welcome!

@tgallacher I'd look into the current setup here over the weekend, need to first digest it (and the requirements) to come up with the appropriate solution. Gonna report back if I fail to figure this out or gonna prepare a PR to your fork with a fix.

Thank you both 🙏

Ok - so I'm pretty close to being done with this. I'm not 100% sure if this is yours "holy grail" of that setup - so let me go through a few things.
RN included here makes this somewhat harder to unify. RN comes with a custom jest preset, babel preset and it also forces you to run babel over react-native package. I don't personally think that this means that maybe RN should be moved out of here - IMHO it just means that for a monorepo like this a project-wide config doesn't necessarily work out. This is IMHO the case mainly because with project-wide config you kinda want to have a single config for everything but at the same time you want to opt-out of it for a particular single package - and this can quickly become a fight not worth fighting it.
This doesn't mean that you shouldn't try to centralize your configuration, you don't have to do it with a traditional config file though. My personal recommendation would be to create dev-only packages (managed by lerna) which would act as for example a babel preset. That way you can easily add options to it, or you can create 2 such presets to pick up whichever you want. Such a solution seems for me to have better composability.
Let's summarize what things/options I've used to achieve the goal here:

jest projects - jest can run multiple project (each with its own config) within a single run. Great fit for a monorepo + each config can focus on its own subpackage, so there is less "dance" with escaping the subpackage in config (no explicit relative paths going outside of a subpackage's root). Also by having it like it it's easier to just run jest both in a subpackage and in the monorepo root.
jest preset - I've created a single jest preset in the monorepo root which is just required in each subpackage (except the RN one)
babel.config.js - by using rootMode: 'upward' somewhat everywhere we can force babel to find that babel.config.js in the root. It has to use a single override rule to cover RN subpackage.

I've wanted to get rid also babelrc file inside a website directory, but not sure if that's the intention (or rather if it should be done in this PR) - because that website directory is still using Babel 6 and has its own yarn.lock (it's not managed by yarn workspaces).
WIP commit can be seen here - https://github.com/Andarist/react-router/commit/e42b75c378b4466b5e4e38aace229bc8b60abdc7

@mjackson friendly 🏓 any thoughts regarding this?

Thanks, @Andarist, sorry I missed your earlier message. I left a few notes on the commit.
I think the overrides piece was the part that I couldn't get working properly. Can you run all the tests successfully using that config?
Don't worry about the website directory for now. We don't test, build, or release it with any of the other stuff. It's totally separate.

Can you run all the tests successfully using that config?

Yes 😃 Created a PR - https://github.com/ReactTraining/react-router/pull/6967


fix: handling of params.mongoose in transaction

extend params.mongoose with session instead of replacing it
Summary
Currently beginTransaction overrides the params.mongoose object:
context.params.mongoose = { session };
This causes issues if an operations depends on mongoose/mongodb params, for example when using arrayFilters or upsert (https://docs.mongodb.com/master/reference/method/db.collection.findAndModify/#findandmodify-arrayfilters)
Not sure if there was an intentional design decision behind overwriting it. If so, some sort of whitelisting for options should be included in my opinion.

[x] Tell us about the problem your pull request is solving.
See desc
[x] Are there any open issues that are related to this?
No, I just fixed it instead of opening one
[x] Is this PR dependent on PRs in other repos?
No

Published as v8.1.1, thank you!


purge-cluster: check if rbdmap exists

When running infrastructure-playbooks/purge-cluster.yml twice, it fails the
second time on the ensure rbd devices are unmapped task, because rbdmap
isn't installed anymore at that point.
This commit adds a check that ensures rbdmap is available, and skips the
ensure rbd devices are unmapped task if it isn't.
Signed-off-by: Benoît Knecht<EMAIL_ADDRESS>

jenkins test centos-non_container-purge

jenkins test centos-non_container-purge


Add initial User administration with account suspension

This PR addresses Issue #86
This is an initial attempt at adding a user administration section to the forum. It is intentionally limited to the following:
Administration Section

Scaffolding for the User admin section
A list of current users (no sorting or pagination)
The ability to suspend a user.
Highlights administrators within the list of users.
Links out to the list of users threads.

Forum Section

Suspended users are prevented from creating new threads.
Suspended users are prevented from replying.

There is a lot of scope for more features (for example,  optionally preventing suspended users from deleting their replies or fully removing users) but due to the already large number of changes, I decided it was better to make a PR with a smaller feature set.
Notes/Issues

I am not totally happy with how the suspension middleware and authorization gates interact.
I think there are opportunities to introduce more Vue components for a better user experience.
I would much prefer a simple list of users with a modal popup that contains the admin functions but I felt this would make the PR even bigger—an enhancement maybe.

All in all this PR might not be ready for merging even though the features it introduces are complete and tested. It may require tweaks and changes to make it better.
I'm open to suggestions!

Closing for now…
I may resubmit this PR once the design branch has been merged into master and I have made all appropriate changes.


Podman bug

Changes introduced with this PR
Fix container name generation by composing a random number generator with the factory, and generating the random name in the connector's Deploy().

By contributing to this repository, I agree to the contribution guidelines.

A subsequent run had a failure, followed by it passing again.
Do you have any idea if this was caused by the Podman deployer?
Workflow output attached.
failure.txt


Add RemoveFinalReset pass

Summary
This adds a RemoveFinalReset pass, which removes a Reset instruction if it comes at the end of a qubit wire.  It also enables this pass at optimization level 1 and higher.
Details and comments
The new wire cutting code in the Circuit Knitting Toolbox results in circuits where there are Resets in the circuit.  In the special case that no qubits are re-used later in the circuit, then all of these Resets are either at the beginning of the circuit or the end of the circuit.  There is an existing pass, RemoveResetInZeroState, that removes resets at the beginning of the circuit.  This pass is disabled by default in the pass managers (see https://github.com/Qiskit/qiskit/pull/10591), as it places assumptions on the state at the beginning of the circuit.  This PR creates the other transpiler pass that we need, namely one that removes resets at the end of the circuit.  If nothing happens to a qubit wire after, then this removal should have no effect on the circuit.  Of course, this does change the result if you then concatenate it with another circuit; I'm assuming this assumption is okay, but if not, it should be removed from the default passes. EDIT: I have removed this from the default passes in 4adc04889f76239e475a2ddd33929fb0d4cf267a.
Related CKT issue: https://github.com/Qiskit-Extensions/circuit-knitting-toolbox/issues/452

@mtreinish: I fixed a few things; this is ready to merge now.


Support VGA timing and support for faster SPI1 bus

Defaults are unchanged - 15kHZ timing, spi2, dispctl_tristate
Support VGA timing and support for faster SPI1 bus

config menu for spi bus and pixel clock

Amiga keys

WASD to move up/down/left/right OSD offsets
keypad ( ) for VGA/15kHz timing
keypad + - for sync polarity

Added SAVE+RESET to config menu

default to this if SPI has changed

Factory default now does a reset

Cheers I should have time to review this next week as I've just got the next rev of Greaseweazle complete and boards at the pcb house 😊

Sweet
I chose not to squash the SWD and mapr change so they’re super obvious to you
Next on my list

dispctl config changes - I burnt an hour in final testing cos it’s sort but not quite hard coded

double line output option. For those who want to use vga/18MHz pixels on SPI2

Thoughts ?

Is the comment in disabling SW JTAG now correct? Looks like you disable full JTAG but keep SWD active?

What do you mean by "dispctl config changes"?

If SWD is a subset of JTAG your are correct - I enabled SWD.
I want to expose
#define DISPCTL_tristate    0 /* PB15 is tristate outside OSD; PA15 unused /
#define DISPCTL_enable_high 1 / PA15 is Display Enable: Active HIGH /
#define DISPCTL_enable_low  2 / PA15 is Display Enable: Active LOW */
uint16_t dispctl_mode;
As config options in the menus

OK I can fix the comment when I merge.
Re dispctl config and double lines: go for it if you have the time.


Fix Highlighted Section Issue

Fixes in part https://github.com/Azure/azure-sdk/issues/4188
Make selected section highlighted.

@chidozieononiwu after testing I think the highlighting works now but the sidebar still collapses. As a repro just expand the 2022 Releases and click one of the months. You will see that the sidebar closes and nothing is highlighted on it.


How to support ma1co?

How can we support you? How can we get the file with all 15.000 entrys to find the options for you? Is it necessary? I like the results: 30 Min, No NTSC Message. Its a big help for enhance the user expirience.

1

+1

+1

+1

+1
Very interested to help as well

Well, we'd really need some reverse engineers. Get IDA and start digging through the firmware! The settings file is useless on its own since you don't know what each setting changes. So, learn some assembly language!
If you're a Java / Android developer, build a nice timelapse app / similar.
Report any bugs that you may encounter, it's really important to know what works and what doesn't.
It would be cool if someone could test this on a camcorder, since these run android, too.
If you have a camera with firmware 1.00 (no updates installed), i would appreciate if you could dump and share the firmware (some basic linux console experience required, but I'm glad to help).
Other than that, tutorials are always useful to people having trouble installing the app.

@ma1co I have a RX1RII with version 1.00 of its firmware. Will that be of any help, or are you looking for some of the older models?

@henrikhj First, can you confirm issue #59? Second, it would be awesome if you could dump the firmware. The procedure is described here. Let me know if you need any help.

Well, we'd really need some reverse engineers. Get IDA and start digging through the firmware! The settings file is useless on its own since you don't know what each setting changes. So, learn some assembly language!
If you're a Java / Android developer, build a nice timelapse app / similar.
Report any bugs that you may encounter, it's really important to know what works and what doesn't.
It would be cool if someone could test this on a camcorder, since these run android, too.
If you have a camera with firmware 1.00 (no updates installed), i would appreciate if you could dump and share the firmware (some basic linux console experience required, but I'm glad to help).
Other than that, tutorials are always useful to people having trouble installing the app.

Hi, i have a cx405 version 1.00 software
https://ibb.co/72YyBng


Use of vhostuser plugin

A bit unclear from the README what the end result is for the host/container. Few questions:

Is the project for creating OVS-DPDK/VPP containers themselves, or interfacing containers with a OVS-DPDK/VPP instance that is installed on the bare-metal?

Does the vhostuser port appear as a standard interface (net0, eth0, etc) within the container?

Are DPDK applications (e.g. testpmd) required to utilize the port within the container?

Thanks, and looking forward to testing it out!

Hi. I have another question, just want to make sure does the IPAM only works for VPP, not OVS/DPDK?

@edsealing @hwchiu: I think @kangasta has updated the README,md file on this.
#testing-the-plugin-with-dpdk-testpmd-application


how to download the dataset？

We have not made the dataset publicly available, as it contains images from the internet that we don't necessarily have permissions to redistribute.


Update Harshitha_HW5-Team-12 Eval.md

Signed-off-by: Harshitha.Paruchuri<EMAIL_ADDRESS>

Codecov Report
Base: 74.53% // Head: 74.53% // No change to project coverage :thumbsup:

Coverage data is based on head (f30f870) compared to base (b43febc).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   74.53%   74.53%
=======================================
  Files          15       15
  Lines         326      326
=======================================
  Hits          243      243
  Misses         83       83

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Update KlipperPreprocessor.py

Change in the layer and total layer count logic.
Now removes the ;LAYER: and ;TOTAL LAYER: and replaces with correct print stat options as per klipper documentation

Hi @dwhitnall, thank you for submitting this Pull Request.
The existing implementation tries to only add what it needs without changing the existing gcode (comments or otherwise), so I see no need to remove the LAYER: or ;TOTAL LAYER: comments added by Cura.
Furthermore, other tools can actually use these comments (the cancelation preprocessor is a good example of this), so removing them is unwise!


opencv not found

I am attempting to install on a cluster running Red Hat Enterprise Linux 6. I have loaded opencv 3.0.0, and have a link to all the .so files. However, make all will still fail, saying I need to find opencv.pc. I cannot find that in my opencv installation, can you point me in the right direction?
See error message below:
[jmschr@n025 mxnet]$ make all
g++ -std=c++0x -DMSHADOW_FORCE_STREAM -Wall -O3 -I./mshadow/ -I./dmlc-core/include -fPIC -Iinclude -msse3 -funroll-loops -Wno-unused-parameter -Wno-unknown-pragmas -DMSHADOW_USE_CUDA=0 -DMSHADOW_USE_CBLAS=1 -DMSHADOW_USE_MKL=0 -DMSHADOW_RABIT_PS=0 -DMSHADOW_DIST_PS=0 -DMXNET_USE_OPENCV=1 `pkg-config --cflags opencv` -fopenmp  -MM -MT build/c_api.o src/c_api.cc >build/c_api.d
Package opencv was not found in the pkg-config search path.
Perhaps you should add the directory containing `opencv.pc'
to the PKG_CONFIG_PATH environment variable
No package 'opencv' found
g++ -std=c++0x -c -DMSHADOW_FORCE_STREAM -Wall -O3 -I./mshadow/ -I./dmlc-core/include -fPIC -Iinclude -msse3 -funroll-loops -Wno-unused-parameter -Wno-unknown-pragmas -DMSHADOW_USE_CUDA=0 -DMSHADOW_USE_CBLAS=1 -DMSHADOW_USE_MKL=0 -DMSHADOW_RABIT_PS=0 -DMSHADOW_DIST_PS=0 -DMXNET_USE_OPENCV=1 `pkg-config --cflags opencv` -fopenmp  -c src/c_api.cc -o build/c_api.o
Package opencv was not found in the pkg-config search path.
Perhaps you should add the directory containing `opencv.pc'
to the PKG_CONFIG_PATH environment variable
No package 'opencv' found
g++ -std=c++0x -DMSHADOW_FORCE_STREAM -Wall -O3 -I./mshadow/ -I./dmlc-core/include -fPIC -Iinclude -msse3 -funroll-loops -Wno-unused-parameter -Wno-unknown-pragmas -DMSHADOW_USE_CUDA=0 -DMSHADOW_USE_CBLAS=1 -DMSHADOW_USE_MKL=0 -DMSHADOW_RABIT_PS=0 -DMSHADOW_DIST_PS=0 -DMXNET_USE_OPENCV=1 `pkg-config --cflags opencv` -fopenmp  -MM -MT build/resource.o src/resource.cc >build/resource.d
Package opencv was not found in the pkg-config search path.
Perhaps you should add the directory containing `opencv.pc'
to the PKG_CONFIG_PATH environment variable
No package 'opencv' found
g++ -std=c++0x -c -DMSHADOW_FORCE_STREAM -Wall -O3 -I./mshadow/ -I./dmlc-core/include -fPIC -Iinclude -msse3 -funroll-loops -Wno-unused-parameter -Wno-unknown-pragmas -DMSHADOW_USE_CUDA=0 -DMSHADOW_USE_CBLAS=1 -DMSHADOW_USE_MKL=0 -DMSHADOW_RABIT_PS=0 -DMSHADOW_DIST_PS=0 -DMXNET_USE_OPENCV=1 `pkg-config --cflags opencv` -fopenmp  -c src/resource.cc -o build/resource.o
Package opencv was not found in the pkg-config search path.
Perhaps you should add the directory containing `opencv.pc'
to the PKG_CONFIG_PATH environment variable
No package 'opencv' found
g++ -std=c++0x -DMSHADOW_FORCE_STREAM -Wall -O3 -I./mshadow/ -I./dmlc-core/include -fPIC -Iinclude -msse3 -funroll-loops -Wno-unused-parameter -Wno-unknown-pragmas -DMSHADOW_USE_CUDA=0 -DMSHADOW_USE_CBLAS=1 -DMSHADOW_USE_MKL=0 -DMSHADOW_RABIT_PS=0 -DMSHADOW_DIST_PS=0 -DMXNET_USE_OPENCV=1 `pkg-config --cflags opencv` -fopenmp  -MM -MT build/engine/engine.o src/engine/engine.cc >build/engine/engine.d
Package opencv was not found in the pkg-config search path.
Perhaps you should add the directory containing `opencv.pc'
to the PKG_CONFIG_PATH environment variable
No package 'opencv' found
g++ -std=c++0x -c -DMSHADOW_FORCE_STREAM -Wall -O3 -I./mshadow/ -I./dmlc-core/include -fPIC -Iinclude -msse3 -funroll-loops -Wno-unused-parameter -Wno-unknown-pragmas -DMSHADOW_USE_CUDA=0 -DMSHADOW_USE_CBLAS=1 -DMSHADOW_USE_MKL=0 -DMSHADOW_RABIT_PS=0 -DMSHADOW_DIST_PS=0 -DMXNET_USE_OPENCV=1 `pkg-config --cflags opencv` -fopenmp  -c src/engine/engine.cc -o build/engine/engine.o
Package opencv was not found in the pkg-config search path.
Perhaps you should add the directory containing `opencv.pc'
to the PKG_CONFIG_PATH environment variable
No package 'opencv' found
g++ -std=c++0x -DMSHADOW_FORCE_STREAM -Wall -O3 -I./mshadow/ -I./dmlc-core/include -fPIC -Iinclude -msse3 -funroll-loops -Wno-unused-parameter -Wno-unknown-pragmas -DMSHADOW_USE_CUDA=0 -DMSHADOW_USE_CBLAS=1 -DMSHADOW_USE_MKL=0 -DMSHADOW_RABIT_PS=0 -DMSHADOW_DIST_PS=0 -DMXNET_USE_OPENCV=1 `pkg-config --cflags opencv` -fopenmp  -MM -MT build/engine/naive_engine.o src/engine/naive_engine.cc >build/engine/naive_engine.d
Package opencv was not found in the pkg-config search path.
Perhaps you should add the directory containing `opencv.pc'
to the PKG_CONFIG_PATH environment variable
No package 'opencv' found
g++ -std=c++0x -c -DMSHADOW_FORCE_STREAM -Wall -O3 -I./mshadow/ -I./dmlc-core/include -fPIC -Iinclude -msse3 -funroll-loops -Wno-unused-parameter -Wno-unknown-pragmas -DMSHADOW_USE_CUDA=0 -DMSHADOW_USE_CBLAS=1 -DMSHADOW_USE_MKL=0 -DMSHADOW_RABIT_PS=0 -DMSHADOW_DIST_PS=0 -DMXNET_USE_OPENCV=1 `pkg-config --cflags opencv` -fopenmp  -c src/engine/naive_engine.cc -o build/engine/naive_engine.o
Package opencv was not found in the pkg-config search path.
Perhaps you should add the directory containing `opencv.pc'
to the PKG_CONFIG_PATH environment variable
No package 'opencv' found
g++ -std=c++0x -DMSHADOW_FORCE_STREAM -Wall -O3 -I./mshadow/ -I./dmlc-core/include -fPIC -Iinclude -msse3 -funroll-loops -Wno-unused-parameter -Wno-unknown-pragmas -DMSHADOW_USE_CUDA=0 -DMSHADOW_USE_CBLAS=1 -DMSHADOW_USE_MKL=0 -DMSHADOW_RABIT_PS=0 -DMSHADOW_DIST_PS=0 -DMXNET_USE_OPENCV=1 `pkg-config --cflags opencv` -fopenmp  -MM -MT build/engine/threaded_engine.o src/engine/threaded_engine.cc >build/engine/threaded_engine.d
Package opencv was not found in the pkg-config search path.
Perhaps you should add the directory containing `opencv.pc'
to the PKG_CONFIG_PATH environment variable
No package 'opencv' found
g++ -std=c++0x -c -DMSHADOW_FORCE_STREAM -Wall -O3 -I./mshadow/ -I./dmlc-core/include -fPIC -Iinclude -msse3 -funroll-loops -Wno-unused-parameter -Wno-unknown-pragmas -DMSHADOW_USE_CUDA=0 -DMSHADOW_USE_CBLAS=1 -DMSHADOW_USE_MKL=0 -DMSHADOW_RABIT_PS=0 -DMSHADOW_DIST_PS=0 -DMXNET_USE_OPENCV=1 `pkg-config --cflags opencv` -fopenmp  -c src/engine/threaded_engine.cc -o build/engine/threaded_engine.o
Package opencv was not found in the pkg-config search path.
Perhaps you should add the directory containing `opencv.pc'
to the PKG_CONFIG_PATH environment variable
No package 'opencv' found
g++ -std=c++0x -DMSHADOW_FORCE_STREAM -Wall -O3 -I./mshadow/ -I./dmlc-core/include -fPIC -Iinclude -msse3 -funroll-loops -Wno-unused-parameter -Wno-unknown-pragmas -DMSHADOW_USE_CUDA=0 -DMSHADOW_USE_CBLAS=1 -DMSHADOW_USE_MKL=0 -DMSHADOW_RABIT_PS=0 -DMSHADOW_DIST_PS=0 -DMXNET_USE_OPENCV=1 `pkg-config --cflags opencv` -fopenmp  -MM -MT build/engine/threaded_engine_perdevice.o src/engine/threaded_engine_perdevice.cc >build/engine/threaded_engine_perdevice.d
Package opencv was not found in the pkg-config search path.
Perhaps you should add the directory containing `opencv.pc'
to the PKG_CONFIG_PATH environment variable
No package 'opencv' found
g++ -std=c++0x -c -DMSHADOW_FORCE_STREAM -Wall -O3 -I./mshadow/ -I./dmlc-core/include -fPIC -Iinclude -msse3 -funroll-loops -Wno-unused-parameter -Wno-unknown-pragmas -DMSHADOW_USE_CUDA=0 -DMSHADOW_USE_CBLAS=1 -DMSHADOW_USE_MKL=0 -DMSHADOW_RABIT_PS=0 -DMSHADOW_DIST_PS=0 -DMXNET_USE_OPENCV=1 `pkg-config --cflags opencv` -fopenmp  -c src/engine/threaded_engine_perdevice.cc -o build/engine/threaded_engine_perdevice.o
Package opencv was not found in the pkg-config search path.
Perhaps you should add the directory containing `opencv.pc'
to the PKG_CONFIG_PATH environment variable
No package 'opencv' found
g++ -std=c++0x -DMSHADOW_FORCE_STREAM -Wall -O3 -I./mshadow/ -I./dmlc-core/include -fPIC -Iinclude -msse3 -funroll-loops -Wno-unused-parameter -Wno-unknown-pragmas -DMSHADOW_USE_CUDA=0 -DMSHADOW_USE_CBLAS=1 -DMSHADOW_USE_MKL=0 -DMSHADOW_RABIT_PS=0 -DMSHADOW_DIST_PS=0 -DMXNET_USE_OPENCV=1 `pkg-config --cflags opencv` -fopenmp  -MM -MT build/engine/threaded_engine_pooled.o src/engine/threaded_engine_pooled.cc >build/engine/threaded_engine_pooled.d
Package opencv was not found in the pkg-config search path.
Perhaps you should add the directory containing `opencv.pc'
to the PKG_CONFIG_PATH environment variable
No package 'opencv' found
g++ -std=c++0x -c -DMSHADOW_FORCE_STREAM -Wall -O3 -I./mshadow/ -I./dmlc-core/include -fPIC -Iinclude -msse3 -funroll-loops -Wno-unused-parameter -Wno-unknown-pragmas -DMSHADOW_USE_CUDA=0 -DMSHADOW_USE_CBLAS=1 -DMSHADOW_USE_MKL=0 -DMSHADOW_RABIT_PS=0 -DMSHADOW_DIST_PS=0 -DMXNET_USE_OPENCV=1 `pkg-config --cflags opencv` -fopenmp  -c src/engine/threaded_engine_pooled.cc -o build/engine/threaded_engine_pooled.o
Package opencv was not found in the pkg-config search path.
Perhaps you should add the directory containing `opencv.pc'
to the PKG_CONFIG_PATH environment variable
No package 'opencv' found
g++ -std=c++0x -DMSHADOW_FORCE_STREAM -Wall -O3 -I./mshadow/ -I./dmlc-core/include -fPIC -Iinclude -msse3 -funroll-loops -Wno-unused-parameter -Wno-unknown-pragmas -DMSHADOW_USE_CUDA=0 -DMSHADOW_USE_CBLAS=1 -DMSHADOW_USE_MKL=0 -DMSHADOW_RABIT_PS=0 -DMSHADOW_DIST_PS=0 -DMXNET_USE_OPENCV=1 `pkg-config --cflags opencv` -fopenmp  -MM -MT build/io/io.o src/io/io.cc >build/io/io.d
Package opencv was not found in the pkg-config search path.
Perhaps you should add the directory containing `opencv.pc'
to the PKG_CONFIG_PATH environment variable
No package 'opencv' found
g++ -std=c++0x -c -DMSHADOW_FORCE_STREAM -Wall -O3 -I./mshadow/ -I./dmlc-core/include -fPIC -Iinclude -msse3 -funroll-loops -Wno-unused-parameter -Wno-unknown-pragmas -DMSHADOW_USE_CUDA=0 -DMSHADOW_USE_CBLAS=1 -DMSHADOW_USE_MKL=0 -DMSHADOW_RABIT_PS=0 -DMSHADOW_DIST_PS=0 -DMXNET_USE_OPENCV=1 `pkg-config --cflags opencv` -fopenmp  -c src/io/io.cc -o build/io/io.o
Package opencv was not found in the pkg-config search path.
Perhaps you should add the directory containing `opencv.pc'
to the PKG_CONFIG_PATH environment variable
No package 'opencv' found
In file included from src/io/io.cc:5:0:
src/io/./image_augmenter.h:10:30: fatal error: opencv2/opencv.hpp: No such file or directory
 #include <opencv2/opencv.hpp>
                              ^
compilation terminated.
make: *** [build/io/io.o] Error 1

opencv.pc is usually installed to $PREFIX/lib/pkgconfig. For example, it might be /usr/lib/pkgconfig, /usr/local/lib/pkgconfig. Or if you compile openCV and install it locally at any prefix you specified, you might find it at prefix/lib/pkgconfig.

If there is no opencv.pc You can also do it by changing https://github.com/dmlc/mxnet/blob/master/Makefile#L46
`pkg-config --cflags opencv`  to -I/path/to/opencv/include
`pkg-config --libs opencv`  to -L/path/to/opencv/libs

@tqchen, your workaround is incomplete becuase -L/path/to/opencv/libs only specifies the library path, but dose NOT tell the linker which libs to use. The linker still complains about objext missing in this case.
My workaround is to specify all OpenCV libraries manually, along with the lib path at the beginning. It makes the Makefile looks like:
# setup opencv
ifeq ($(USE_OPENCV), 1)
        CFLAGS += -DMXNET_USE_OPENCV=1 -I/path/to/opencv/include
        LDFLAGS += -L/path/to/opencv/lib -lopencv_calib3d -lopencv_contrib -lopencv_core -lopencv_features2d -lopencv_flann -lopencv_gpu -lopencv_highgui -lopencv_imgproc -lopencv_legacy -lopencv_ml -lopencv_nonfree -lopencv_objdetect -lopencv_ocl -lopencv_photo -lopencv_stitching -lopencv_superres -lopencv_ts -lopencv_video -lopencv_videostab
        BIN += bin/im2rec
else
        CFLAGS+= -DMXNET_USE_OPENCV=0
endif

$niranjan@niranjan-VirtualBox:~/mxnet$ make
g++ -std=c++0x -c -DMSHADOW_FORCE_STREAM -Wall -O3 -I./mshadow/ -I./dmlc-core/include -fPIC -Iinclude -msse3 -funroll-loops -Wno-unused-parameter -Wno-unknown-pragmas -DMSHADOW_USE_CUDA=0 -DMSHADOW_USE_CBLAS=1 -DMSHADOW_USE_MKL=0 -DMSHADOW_RABIT_PS=0 -DMSHADOW_DIST_PS=0 -DMXNET_USE_OPENCV=1 -I/path/to/opencv/include -fopenmp  -DMXNET_USE_NVRTC=0 -c src/engine/threaded_engine_pooled.cc -o build/src/engine/threaded_engine_pooled.o
g++ -std=c++0x -DMSHADOW_FORCE_STREAM -Wall -O3 -I./mshadow/ -I./dmlc-core/include -fPIC -Iinclude -msse3 -funroll-loops -Wno-unused-parameter -Wno-unknown-pragmas -DMSHADOW_USE_CUDA=0 -DMSHADOW_USE_CBLAS=1 -DMSHADOW_USE_MKL=0 -DMSHADOW_RABIT_PS=0 -DMSHADOW_DIST_PS=0 -DMXNET_USE_OPENCV=1 -I/path/to/opencv/include -fopenmp  -DMXNET_USE_NVRTC=0 -MM -MT build/src/io/io.o src/io/io.cc >build/src/io/io.d
g++ -std=c++0x -c -DMSHADOW_FORCE_STREAM -Wall -O3 -I./mshadow/ -I./dmlc-core/include -fPIC -Iinclude -msse3 -funroll-loops -Wno-unused-parameter -Wno-unknown-pragmas -DMSHADOW_USE_CUDA=0 -DMSHADOW_USE_CBLAS=1 -DMSHADOW_USE_MKL=0 -DMSHADOW_RABIT_PS=0 -DMSHADOW_DIST_PS=0 -DMXNET_USE_OPENCV=1 -I/path/to/opencv/include -fopenmp  -DMXNET_USE_NVRTC=0 -c src/io/io.cc -o build/src/io/io.o
In file included from src/io/io.cc:5:0:
src/io/./image_augmenter.h: In member function ‘virtual cv::Mat mxnet::io::ImageAugmenter::Process(const cv::Mat&, mxnet::common::RANDOM_ENGINE*)’:
src/io/./image_augmenter.h:262:26: error: ‘CV_BGR2HLS’ was not declared in this scope
       cvtColor(res, res, CV_BGR2HLS);
                          ^
src/io/./image_augmenter.h:278:26: error: ‘CV_HLS2BGR’ was not declared in this scope
       cvtColor(res, res, CV_HLS2BGR);
                          ^
In file included from ./dmlc-core/include/dmlc/./registry.h:14:0,
                 from ./dmlc-core/include/dmlc/data.h:14,
                 from include/mxnet/io.h:9,
                 from src/io/io.cc:3:
src/io/io.cc: At global scope:
./dmlc-core/include/dmlc/././parameter.h:254:43: warning: ‘mxnet::io::__make__BatchParamParamManager__’ defined but not used [-Wunused-variable]
   static ::dmlc::parameter::ParamManager &__make__ ## PType ## ParamManager__ = \
                                           ^
src/io/io.cc:18:1: note: in expansion of macro ‘DMLC_REGISTER_PARAMETER’
 DMLC_REGISTER_PARAMETER(BatchParam);
 ^
./dmlc-core/include/dmlc/././parameter.h:254:43: warning: ‘mxnet::io::__make__PrefetcherParamParamManager__’ defined but not used [-Wunused-variable]
   static ::dmlc::parameter::ParamManager &__make__ ## PType ## ParamManager__ = \
                                           ^
src/io/io.cc:19:1: note: in expansion of macro ‘DMLC_REGISTER_PARAMETER’
 DMLC_REGISTER_PARAMETER(PrefetcherParam);
 ^
./dmlc-core/include/dmlc/././parameter.h:254:43: warning: ‘mxnet::io::__make__ImageAugmentParamParamManager__’ defined but not used [-Wunused-variable]
   static ::dmlc::parameter::ParamManager &__make__ ## PType ## ParamManager__ = \
                                           ^
src/io/io.cc:20:1: note: in expansion of macro ‘DMLC_REGISTER_PARAMETER’
 DMLC_REGISTER_PARAMETER(ImageAugmentParam);
 ^
./dmlc-core/include/dmlc/././parameter.h:254:43: warning: ‘mxnet::io::__make__ImageNormalizeParamParamManager__’ defined but not used [-Wunused-variable]
   static ::dmlc::parameter::ParamManager &__make__ ## PType ## ParamManager__ = \
                                           ^
src/io/io.cc:21:1: note: in expansion of macro ‘DMLC_REGISTER_PARAMETER’
 DMLC_REGISTER_PARAMETER(ImageNormalizeParam);
 ^
make: *** [build/src/io/io.o] Error 1

can you tell me how to fix this error.


Add automated tests

Opened a PR so that the CI pipeline is run (as set up in Azure DevOps)

I will merge branches manually, not using this PR


Labels in a pod are nested under "image" why?

Coming from kubernetes, having labels in the "image" block is weird.   I would expect them at the top scope.   Maybe I just don't get what you mean by labels yet.

Because they are labels to perform dependency matching for the dependent images. I don't think the usage is particularly different to k8s. Essentially the "dependency matching" is like a label selector for dependent images. The objects to which the labels are attached is the actual images, i.e. top level of ImageManifest. Does that make sense?

Hmm, maybe I misunderstand.
When you apply labels to an image manifest you say "I declare this image to have these labels".
When you apply them to a PodManifest.apps[].image are you declaring that this pod-app has labels or demanding that the image for that pod-app must match those labels?  We differentiate in kubernetes between labels (declare) and selectors (demand).  But note that our selectors are evolving into a richer query language than just "==".
The examples show both an ID and labels, which seems pointless to me - if the id matches, are labels even considered?

If the dependency specification has an image ID, it will be compared against the hash of image returned, and must match.
Otherwise, the labels in the dependency specification are compared against the labels in the retrieved ACI

When you apply labels to an image manifest you say "I declare this image to have these labels".

Correct

When you apply them to a PodManifest.apps[].image are you declaring that this pod-app has labels or demanding that the image for that pod-app must match those labels

The latter. Maybe we should rename them to selectors. Although I don't think we would expect them to evolve to be more complex.

if the id matches, are labels even considered?

They are not considered for the dependency matching per se; but they still might be utilised for discovery. Consider the scenario where ID is specified - I'd expect a runtime to do the following:

first try to retrieve that image deterministically by ID (e.g. from local cache or some other CAS known by executor)
otherwise, if there are labels, use them to try discover the image (either locally, or following app container image discovery)
if an image is discovered via labels, and an id is specified, check that the id matches. if it does, great, if not, the dependency resolution failed.


Update opengraph.html

Add a 'description' field to avoid "Document does not have a meta description" warning in pagespeed insights and web.dev, especially for themes using the internal template.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Subtitles broken after unlinking

I'm trying to unlink THORA's Spice and Wolf season 1 as well as Coalgirl's version. I keep hitting this issue: http://pastebin.com/g2d2ZSGk
The subtitles show up, but after the OP, all the styles are messed up. The OP styles are fine. Perhaps this happens because the OP is the first file played?

I've tried, with the exact same libraries, dependencies, mkvmerge version, etc, on WhyNot's Steins;Gate BD rips. In this, the ordered chapter OP/EDs are "inserted" into the series rather than starting from the beginning or right at the end. The subtitles are styled properly.
Perhaps this is a bug that happens only if the OP is the first file played, before the main file?

Thank you for your report. I will try it out.
Have you tried other releases? Do they work?
On Aug 28, 2015 2:32 AM, "Jay"<EMAIL_ADDRESS>wrote:

I've tried, with the exact same libraries, dependencies, mkvmerge version,
etc, on WhyNot's Steins;Gate BD rips. In this, the ordered chapter OP/EDs
are "inserted" into the series rather than starting from the beginning or
right at the end. The subtitles are styled properly.
Perhaps this is a bug that happens only if the OP is the first file
played, before the main file?
—
Reply to this email directly or view it on GitHub
https://github.com/hilts-vaughan/UnlinkMKV-GUI/issues/11#issuecomment-135648295
.

I've tried 3 releases. Both Thora's and Coalgirl's releases of Spice and Wolf (s1) don't work. They both use ordered chapters and the OP comes right before the show. There's no show then OP then show.
I've tried WhyNot's Steins;Gate. This is more of a traditional ordered chapter thing. There's some show lead in, then an OP, then back to the show. This works. I used the same mkvmerge version and UnlinkMKV-GUI. The only thing that's different in my test are the shows.
I don't think it's a font issue because the subs shows as if there's no styling associated with them. I think the styles are not being copied properly in the edge case... could you confirm?

Hi, I ran into this problem with some of my releases and found some blog post explaining why it's happening and how to fix it,
http://thisdoesnotcompute.org/2013/01/14/undoing-ordered-chapters-part-2-fixing-broken-subtitles/
Basically unlinkmkv only uses styling from OP subtitles and sometimes that doesn't contain styling for actual episode and that causes the problem. Adding missing styles from episodes subtitle style sheet to OPs subtitle style sheet fixes the problem.

Cool -- thanks! I'll see if I can include this automatically.
On Fri, Aug 28, 2015 at 4:13 PM, sherlockeb<EMAIL_ADDRESS>wrote:

Hi, I ran into this problem with some of my releases and found some blog
post explaining why it's happening and how to fix it,
http://thisdoesnotcompute.org/2013/01/14/undoing-ordered-chapters-part-2-fixing-broken-subtitles/
Basically unlinkmkv only uses styling from OP subtitles and sometimes that
doesn't contain styling for actual episode and that causes the problem.
Adding missing styles from episodes subtitle style sheet to OPs subtitle
style sheet fixes the problem.
—
Reply to this email directly or view it on GitHub
https://github.com/hilts-vaughan/UnlinkMKV-GUI/issues/11#issuecomment-135877397
.

Perhaps a safer solution would be to merge all the styles from all linked files (OP, actual episode, AND ED) and remove any duplicates. In Thora's Spice and Wolf, the ED's messed up too.

Great idea. I'll see about including them all. That should fix this
On Aug 28, 2015 5:35 PM, "Jay"<EMAIL_ADDRESS>wrote:

Perhaps a safer solution would be to merge all the styles from all linked
files (OP, actual episode, AND ED) and remove any duplicates. In Thora's
Spice and Wolf, the ED's messed up too.
—
Reply to this email directly or view it on GitHub
https://github.com/hilts-vaughan/UnlinkMKV-GUI/issues/11#issuecomment-135894050
.

Thanks for the quick response, but I'm reading the documentation for the original unlinkMKV script:
   --fix-subtitles        Defaults to on. Sometimes groups don't use uniform subtitle styles and fonts in all segments, it's a good idea to leave this enabled.
I can't read perl, but it seems like the author of unlinkMKV has accounted for this issue... perhaps there's a bug in the current script?

There should be an option in the UI to enable it. Can you try it with that
option?
On Aug 28, 2015 5:39 PM, "Jay"<EMAIL_ADDRESS>wrote:

Thanks for the quick response, but I'm reading the documentation for the
original unlinkMKV script:
--fix-subtitles Defaults to on. Sometimes groups don't use uniform
subtitle styles and fonts in all segments, it's a good idea to leave this
enabled.
I can't read perl, but it seems like the author of unlinkMKV has accounted
for this issue... perhaps there's a bug in the current script?
—
Reply to this email directly or view it on GitHub
https://github.com/hilts-vaughan/UnlinkMKV-GUI/issues/11#issuecomment-135894664
.

Yeah, I tried it in the original bug submission. It didn't help (plus, it seems like it default are on).

Sorry to bother again -- any luck? Let me know if there's anything I can help.

I was just about to report this issue myself. I noticed that you mentioned ChapterUnorderer was inaccurate but it is working in this case. I personally completed a Windows port of this project a few months before you started but I found Perl to be way too frustrating on Windows and pitched it after I noticed these issues.
That could be due to my lack of knowledge with Perl though.

Fixed in the original UnlinkMKV repo. The original author has done a winport as well.


Question about one signal configuration

Hello and very nice work with the adapter guys!
I have one question, if i put the adapter at my parse-server app, can i send push notifications from the onesignal.com dashboard? Or only from cloud code?
Thanks!

Yes and no.
OneSignal will not be aware of which devices are subscribed to notifications until you send at least one notification to the device via Cloud Code. Once OneSignal is aware of the device then you can send notifications to it and your other subscribed devices through the OneSignal dashboard.
In general the dashboard will work better for you if you include the OneSignal SDK in your app. This will remove the above requirement, and you will still be able to send notifications through the OneSignal Parse Server adapter too

How about sending from the parse-dashboard?
I tried it, sometimes it works, sometimes it doesn't. I have no idea what the problem might be.


fixes for multi access mode attachment condition

What type of PR is this?

/kind design

What this PR does / why we need it:
VA need to save extra info(VolumeCapability) for passing in to nodestagevolume and tell if the attach is appropriate in certain clash conditions and automatically fixes the clash which preventing the clash.
Does this PR introduce a user-facing change?:

@houz42


Move CPUID functions into driver

CPUID brand string bug is back, still investigating.

Delayed PR due to regression in brand string printing; will merge when fixed. You can keep committing to the branch, no need to redo the PR.


12/18/2023 version bump to publish

12/18/2023 version bump to publish

Version bumps

PyPi

1.1.7

NPM

1.1.1

Stack created with Sapling. Best reviewed with ReviewStack.

-> #520
#524

going to wait for #524 gets merged before merging this


Support for adaptive Multibitrate rtmp (smil generation)

As titled.

Please file issue at https://github.com/simple-rtmp-server/srs/issues


Protect #pragma comment(lib, "foo") with _WIN32 checks

lld on Linux can now process #pragma comment(lib, "foo") macros which
results in build failures on Linux when lld is used. Fix this by
protecting these macros with _WIN32 checks.

FWIW vcpkg-osx-PR fail is unrelated.

/azp run

LGTM, thanks for the PR!


[ODS-4217] Remove Grand Bend Extension

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add support for insecure https connections

Closes #55
Since handling different ssl keystores with java is quite heavy burden for cli tool users and we don't handle customer critical traffic, this PR configure http client of CLI with disabled ssl check.
You can verify this locally by using https://zally.architecture.zalan.do

Thanks for fixing!

👍


Something doesn't work

Describe the bug
A clear and concise description of the bug.
Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Unexpected behavior

Expected behavior
A clear and concise description of what you expected to happen.
Additional context
Add any other context about the problem here.


Make RetDec compilable via MSYS2 on Windows

I made some changes to the cmake files that allow smooth compilation on msys2. This fixes the issue mentioned in issue 558 and another one with linking libdwarf further down the compile.

I'm very new to this, what is the next step to get this merged?

Hi. Thank you for the contribution. I will review the changes and will let you know.

Thank you for reviewing it,
I can, by the way, reproduce the test failure on Ubuntu 18 with the regular main branch. Will look into it separately. That test failure is caused by missing linker files to pthread and dl.

That pthread failure on Linux is already fixed in master, so no need looking into it. If you want, you can rebase your branch based on the current master to get all the builds to suceed.

@twitzelbos Can you please check the commits on your branch? GitHub shows 28 commits, where your commits are there twice, and there are also commits from other people. Could you please fix your issue558 branch by taking just the most recent version of your commits and applying them to the current master?

Sorry, this must be due to by git ineptness. I have reverted one of my 4 commits and replaced with a new commit. The other 20ish commits I guess are due to the rebase with the upstream master? Is there a clean way to fix this? The diff to the upstream master should just be my patch.
Thanks, Thomas

There are multiple ways of fixing this. One of them is as follows:
# 1. Ensure that you are in the root of the retdec repository:
cd retdec

# 2.  Generate a patch with your changes (the diff between your branch and master):
git diff master..issue558 > patch.txt

# 4. Delete the original local branch.
git branch -d issue558

# 5. Create a new branch off the current master and switch to it.
git checkout -b issue558

# 6. Apply changes from the saved patch:
git apply patch.txt

# 7. Stage the changed files:
git add deps/libdwarf/CMakeLists.txt deps/llvm/CMakeLists.txt deps/yaracpp/CMakeLists.txt src/utils/CMakeLists.txt

# 8.  Remove the no-longer-needed patch:
rm patch.txt

# 10. Push the changes to the original branch on GitHub (--force is required as we are overwriting history):
git push --force origin issue558

After this, there should be only a single commit in this PR.

I can do this, but if I may use some more of your time, I like to learn why this has to be done. My branch, as it is right now, has this diff:
`git diff upstream/master..issue558
diff --git a/deps/libdwarf/CMakeLists.txt b/deps/libdwarf/CMakeLists.txt
index 3839a4fe..a3a7b068 100644
--- a/deps/libdwarf/CMakeLists.txt
+++ b/deps/libdwarf/CMakeLists.txt
@@ -71,6 +71,9 @@ target_include_directories(libdwarf SYSTEM INTERFACE ${source_dir}/libdwarf)
if(MSVC)
target_link_libraries(libdwarf INTERFACE ${binary_dir}/libdwarf/libdwarf/$/${CMAKE_STATIC_LIBRARY_PREFIX}retdec-libdwarf.lib)
target_link_libraries(libdwarf INTERFACE ${binary_dir}/libelf/lib/$/${CMAKE_STATIC_LIBRARY_PREFIX}retdec-libelf.lib)
+elseif(MSYS)

  target_link_libraries(libdwarf INTERFACE ${LIBDWARF_INSTALL_DIR}/bin/${CMAKE_STATIC_LIBRARY_PREFIX}retdec-libdwarf${CMAKE_SHARED_LIBRARY_SUFFIX})

  target_link_libraries(libdwarf INTERFACE ${LIBDWARF_INSTALL_DIR}/bin/${CMAKE_STATIC_LIBRARY_PREFIX}retdec-libelf${CMAKE_SHARED_LIBRARY_SUFFIX})

else() # Linux
target_link_libraries(libdwarf INTERFACE ${LIBDWARF_INSTALL_DIR}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}retdec-libdwarf${CMAKE_SHARED_LIBRARY_SUFFIX})
target_link_libraries(libdwarf INTERFACE ${LIBDWARF_INSTALL_DIR}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}retdec-libelf${CMAKE_SHARED_LIBRARY_SUFFIX})
@@ -78,6 +81,8 @@ endif()
if(MSVC)
install(DIRECTORY "${LIBDWARF_INSTALL_DIR}/bin" DESTINATION "${CMAKE_INSTALL_PREFIX}")
+elseif(MSYS)

  install(DIRECTORY "${LIBDWARF_INSTALL_DIR}/bin" DESTINATION "${CMAKE_INSTALL_PREFIX}")

else() # Linux
install(DIRECTORY "${LIBDWARF_INSTALL_DIR}/lib" DESTINATION "${CMAKE_INSTALL_PREFIX}")
endif()
diff --git a/deps/llvm/CMakeLists.txt b/deps/llvm/CMakeLists.txt
index 2794fed6..9869cd8d 100644
--- a/deps/llvm/CMakeLists.txt
+++ b/deps/llvm/CMakeLists.txt
@@ -1,5 +1,5 @@
find_package(Threads REQUIRED)
-if(UNIX)
+if(UNIX OR MINGW)
find_package(ZLIB REQUIRED)
endif()
@@ -223,6 +223,9 @@ if(UNIX)
endif()
target_link_libraries(llvm INTERFACE debug     ${ZLIB_LIBRARIES} ${CMAKE_DL_LIBS} ${EXECINFO})
target_link_libraries(llvm INTERFACE optimized ${ZLIB_LIBRARIES} ${CMAKE_DL_LIBS} ${EXECINFO})
+elseif(MINGW)

  target_link_libraries(llvm INTERFACE debug     ${ZLIB_LIBRARIES})

  target_link_libraries(llvm INTERFACE optimized ${ZLIB_LIBRARIES})

endif()
Set include directories.
diff --git a/deps/yaracpp/CMakeLists.txt b/deps/yaracpp/CMakeLists.txt
index e086b20a..4486088b 100644
--- a/deps/yaracpp/CMakeLists.txt
+++ b/deps/yaracpp/CMakeLists.txt
@@ -78,6 +78,9 @@ if(MSVC)
set(YARA_WIN_DIR       ${YARA_DIR}/windows/vs2015)
set(YARA_LIBRARY_DIR   ${YARA_WIN_DIR}/libyara/$)
set(YARAC_PATH         ${YARA_WIN_DIR}/${CMAKE_INSTALL_CONFIG_NAME}/${YARAC_NAME})
+elseif(MSYS)

  set(YARA_LIBRARY_DIR   ${YARA_DIR}/libyara/.libs)

  set(YARAC_PATH         ${YARA_DIR}/yarac.exe)

else()
set(YARA_LIBRARY_DIR   ${YARA_DIR}/libyara/.libs)
set(YARAC_PATH         ${YARA_DIR}/yarac)
diff --git a/src/utils/CMakeLists.txt b/src/utils/CMakeLists.txt
index 642c9187..d879f306 100644
--- a/src/utils/CMakeLists.txt
+++ b/src/utils/CMakeLists.txt
@@ -16,7 +16,7 @@ set(RETDEC_UTILS_SOURCES
add_library(retdec-utils STATIC ${RETDEC_UTILS_SOURCES})
target_link_libraries(retdec-utils whereami)
-if(MSVC)
+if(WIN32)
target_link_libraries(retdec-utils shlwapi) # shlwapi.dll for PathRemoveFileSpec()
endif()
target_link_libraries(retdec-utils mpark_variant)`
Are you worried about the clutter in the history?

I can do this, but if I may use some more of your time, I like to learn why this has to be done.

Sure. When you click on Files changed, there are changes in 15 files, and most of them are not related to the present PR in any way. This causes unnecessary difficulties to both me (as a reviewer) and future readers of the PR. The reason is that GitHub shows the changes of all new commits in the branch rather than changes when compared to master.

Are you worried about the clutter in the history?

No. I would squash all the commits from the branch into a single one when merging anyway, so there won't be any clutter.

Okay, will do as you suggested. It just doesn't seem like that's the intended way with git.

Thank you, the changes are now shown correctly :+1: I will review the code, and if everything works as expected, I will merge the PR.


Studios not correct aligned when they enter a third line

As seen in the screenshot the alignment breaks when entering the third line. This would probably also be the case for genres but I have found no anime where this is the case.

One way to fix it is to add padding to the .inline-list class in each respective list (genres, studios).  I tried padding-left: 58px; and everything seemed to line up.

@astraldragon do you plan on submitting a PR for that? Otherwise I'll do it.

Just found an example where this also happens on genres

It's also fixed with the fix suggested by @astraldragon

I can submit a PR for it later today

Ok thanks

@astraldragon  I tried padding-left: 58px; and everything seemed to line up.

If you're going to do that use padding-left: 54px; so it doesn't change the spacing.
Using this method also breaks the layout on smaller window sizes as the Genre & Studios become their own lines - so you'll need to wrap this in a @media query so lower widths remain unchanged.

Genres: With padding-left 54px (or 58px)
Studios: Original intended layout

@wopian Would you rather have both lists start on the new line on all screen sizes?  Or do you like the padding applied only on the normal layout?

Padding applied to normal layout only - to conform with the current design.


Fixed start/stop issues

This fixes the issue seen in many daemons such as https://github.com/kitematic/kitematic/issues/746 - By default the docker CLI uses a timeout of 10s before killing the process, Kitematic did not, which caused issues when a container had a cleanup method on shutdown.
This patch adds the same 10seconds wait time before killing the container.
Signed-off-by: FrenchBen <me(at)frenchben.com>

Woo! Issue #1000
Looking

Tested this out locally, works great! Thanks Ben!

Sweet!


[WIP] Add emmc support

Adds the support needed for us-east-detiber

Still working on testing this build

Still working on testing this build

Adds the support needed for us-east-detiber

Arguably the most import region! Thanks for the pr (once tested)

Adds the support needed for us-east-detiber

Arguably the most import region! Thanks for the pr (once tested)

Looks like it is still missing something, will do some more digging...

Ok, updated and tested and successfully ran a workflow with these kernel changes.
It wasn't clear to me how the kernel is picked up through the build pipeline, though.

Great! Yeah it is not clear because I do it manually right now. We didn't build a good story yet @thebsdbox


use rustls

this makes aur-rpc use rustls instead of relying on openssl

I changed it so that aur-rpc has a rustls-tls feature too and can be used similar to reqwest by toggling the default features off and opting into rustls-tls.


Property order

Problem
Can you output properties in a different order? Alphabetical is like the least useful order to read properties as a consumer--even if it's a consistent system to order things.
Requested enhancement
Something along the lines of https://github.com/constverum/stylelint-config-rational-order
References
n/a
Anything else?
nope

For what it's worth, I think I've found a solution to the declaration ordering issue (i.e. declarations potentially not rendered in input order). Depending on the results of my testing/benchmarking, I may publish an update soon.
Unfortunately, as I'm sure you've already realized, that doesn't eliminate the need for a tool like CSScomb if you actually do want the output to be reordered.


Are scipy.sparse matrices supposed to be sequences?

I wanted to assign a scipy.sparse matrix (any storage type) to a NumPy array slice, but this didn't work because PySequence_Check() didn't recognize the sparse matrix as a sequence.
Is this intentional?
IMO sparse matrices are sequences and they can easily be used as such by means of __getitem__() and __len__().
See also my related question on stackoverflow: http://stackoverflow.com/q/26934349/500098.
I know that using sparse matrices as sequences might be slow in some cases, but it would allow writing more generic code.
It would especially allow numpy.array(s) and numpy.asarray(s) with s being a sparse matrix.

Just for reference: An issue that suggests adding an __array__() method was recently created: #4239.
There is also a quite old (and closed) issue that mentions it briefly: #1569.

I think that disagrees with the Python mantra "we're all consenting adult here".

Consenting adults is about being able to access private members and method. This is a case of "explicit is better than implicit" (and "sparse is better than dense", in a bit of eisegesis ;). In my problems, matrices tend to grow have size (n,O(√n)) with O(n) non-zeros, so an implicit conversion would cause a superlinear memory blowup. I find that unacceptable.


Hermit updates

This PR does three things related to the Hermit target:

Close https://github.com/rust-lang/libc/issues/3318.
Non-unix Hermit has been supported since https://github.com/rust-lang/libc/pull/1292 and unix Hermit does not exist anymore.

Update Hermit docs.
HermitCore/RustyHermit has been renamed to just Hermit.
I took the chance to simplify the Hermit module's docs.

Add the riscv64gc-unknown-hermit target to docs and CI (https://github.com/rust-lang/rust/pull/114004).

CC: @stlankes

@bors r+

:pushpin: Commit 54f63b79654c41c6084ca9891f19b5144e16a29c has been approved by JohnTitor
It is now in the queue for this repository.

:hourglass: Testing commit 54f63b79654c41c6084ca9891f19b5144e16a29c with merge 6f31de33032bf37b5735357320feedb84bb44478...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 6f31de33032bf37b5735357320feedb84bb44478 to main...


Let RectTileLayer extend PIXI.DisplayObject

There is no any Container feature in RectTileLayer

I'm wrnong. ZLayer needs


Add ttl_options setting

Adds a new setting to define the options in the TTL dropdown when
editing a record. The setting is a comma separated string with the
valid options.
Fixes #362

Thanks @rkerr for the contribution.  Your changes look good to me. However, it should be applied to domain template also.
There will be also a small issue if we remove the TTL setting that already applied to an existing record. User will see the blank field when editing it. But i think we can ignore it for now.

Yes, your solution looks good to me. Merging the PR. Thanks for your contribution!


uploading contents of buffer on every keystroke

On every keystroke, Russia uploads the contents of the buffer to their servers (pastes included). I would suggest they wait a bit before doing so.
I pasted some secrets into the buffer the other night and had eight hitmen trying to kill me in Saratoga Springs, NY. Just something to point out.

Thank you for reaching out!
Because this doesn't reproduce in Safe Mode, it would seem that what you're reporting isn't being caused by Atom itself but by a community package you have installed. It may be that there is still a bug in Atom. If so, we'll need the maintainer of the package that is causing the problem to help track that down.
What we need you to do is to figure out what community package is causing the problem. Some people have reported that using the package-cop package has been helpful, you may want to try it. Once you've determined what package is causing the problem, The Atom FAQ has information on how to contact the maintainers of any Atom community package or theme so you can file this issue there.


Add Linux ARM build for M1 devices

Hello from Asahi Linux! Could you add aarch64-linux for m1 linux please?
I'm hoping this can be as simple as it was for #22 ?
Thank you so much! :smiley:

My details:
$ name -a
Linux oatman-m1 6.1.0-asahi-2-2-edge-ARCH #2 SMP PREEMPT_DYNAMIC Fri, 16 Dec 2022 05:04:23 +0000 aarch64 GNU/Linux

Added #92 which with some noodling by someone clever could work!

@0atman how do you even manage to run neovim on ARM? neovim doesn't provide ARM binaries.

solved


Mocked version of ExecuteWorkflow doesn't accept a custom Context

Is your feature request related to a problem? Please describe.
In our tests, we need to jump through hoops and provide a custom Context Propagator, because the mock version
of ExecuteWorkflow doesn't take in a context.Context param.
The regular (production) version of ExecuteWorkflow DOES accept such a parameter.
Describe the solution you'd like
Add a ctx param to the mock variant of ExecuteWorkflow and propagate it.

@dorsec - I am assuming you're talking about testsuite.TestWorkflowEnvironment.ExecuteWorkflow and not mocks.Client.ExecuteWorkflow, correct?
Can you provide more information on how you are using the context to Client.ExecuteWorkflow? The context is for client calls only (and there is no client for the testsuite) and doesn't really affect the running of the workflow.
Also, in the master branch and soon to be released, if it helps you, there are now Interceptors on the worker options which support intercepting both outbound (i.e. client call) and inbound (i.e. workflow invocation request) ExecuteWorkflow calls. They can perform similar functions to context propagators though, so likely unrelated to the root of this problem.

The code in my workflows/activities may on context information (e.g. user ID).
So, in tests, it needs to be passed from somewhere - and testsuite.TestWorkflowEnvironment.ExecuteWorkflow doesn't allow for it :)

The code in my workflows/activities may rely on context information (e.g. user ID).

But you can't inject user values into the context that is given to your workflow (unless you're using interceptors or context propagators). The internal system creates the workflow.Context. Same for activities and context.Context. If you have multiple workers, sometimes the workers/activities run on completely different machines than where they were executed.
Can you give me an example of what you're doing without the test environment and maybe I can show how you can do it with the test environment?


tsproxy performance can drop significantly after a period of time (intermittent)

When using tsproxy for repeated browsertime page loads we intermittently see a huge drop off in performance after a few minutes.
We are using browsertime to drive Chrome for Android, with tsproxy as the network throttler. Generally WebPageReplay is used as the http archive.
Once the performance has dropped, it will persist in that state until the tsproxy process is restarted.
I believe the problem is coming from tsproxy because when I remove WebPageReplay from the equation we can still reproduce the issue (i.e. when using tsproxy to throttle access to lives sites we still see the problem).
Similarly, we've not seen this issue when using browsertime and Chrome directly against live sites.
I'm seeing this behaviour on MacOS (High Sierra) and my colleague is seeing it on Ubuntu linux.
I've attached both the tsproxy logs (verbose) as well as browsertime's.
In this case it the problem surfaced in slightly under 5 minutes at around 10:57:52 in the logs.
You can see the browsertime backendTime metric jump from ~2100ms to ~18000ms on iteration 4 onwards.
I noticed that from tsproxy's logs there  are no more long tick times (e.g. 1 second), and you can see a continuous spew of 0.001 Tick Time's:
10:57:51.450 - Tick Time: 1.000
...
10:57:52.688 - Tick Time: 0.001
10:57:52.689 - Tick Time: 0.001
10:57:52.691 - Tick Time: 0.001
10:57:52.693 - Tick Time: 0.001
...

tsproxy is started as follows (verbose logging added here), in this case bound and directed to the host machine's local ip where WebPageReplay is running:
python tsproxy.py -b <IP_ADDRESS> -d <IP_ADDRESS> -m '80:8080,443:8081' --rtt=200 -vvvvv
For reasons unknown, we see this problem more frequently with the following urls,
https://booking.com
http://www.espn.com/nba/story/_/page/allstarweekend25788027/the-comparison-lebron-james-michael-jordan-their-own-words
https://www.bbc.com/news/business-47245877

We're on the latest commit of tsproxy:
6ccc0eb5a8d308608d155545d265bd425765d724
Let me know if there is additional information I can provide.
tsproxy_logs.txt
webpagereplay logs.txt

Here are browsertime logs for a session in which it looks like tsproxy got into a bad state (it was logging Tick Time: 0.001 continuously, but I restarted tsproxy after iteration 5 and you can see the performance metrics return to normal.
browsertime_logs_restart_tsproxy_after_iteration_5.txt

I've found a simpler method to reproduce this issue (the method doesn't require Browsertime).

Start tsproxy on your host machine, e.g. python tsproxy.py -b {host_ip} --rtt=200 -vvvv

Configure Chrome for android to point to tsproxy on your host machine, e.g.  --proxy-server=socks://{host_ip}:1080

Run the following bash script to repeatedly clear and launch Chrome, loading the provided website

i=0

while [ $i -le 40 ]
do
  adb shell am force-stop com.android.chrome
  adb shell pm clear com.android.chrome

  adb shell am start -n com.android.chrome/com.google.android.apps.chrome.Main -a android.intent.action.VIEW -d "https://www.bbc.com/news/business-47245877"

  echo Number: $i
  ((i++))
  sleep 10s
done

Notice that initially the page will have time to load.
After a number of iterations, tsproxy will be begin to output something like:

11:51:06.587 - Tick Time: 0.001
11:51:06.589 - Tick Time: 0.001
11:51:06.590 - Tick Time: 0.001

and at this point Chrome will no longer load the page within the 10 seconds given.
If the bash script is cancelled at the point, Chrome will generally hang mid load.

No promises on a fix but I'm looking at it now.  Managed to reproduce it with a simple puppeteer script:
const puppeteer = require('puppeteer');

(async () => {
  while (true) {
    const browser = await puppeteer.launch({
        headless: false,
        args: ['--proxy-server=socks://<IP_ADDRESS>:1080'],
        timeout: 10000
        });
    const page = await browser.newPage();
    await page.goto('https://www.bbc.com/news/business-47245877');
    await browser.close();
  }
})();

I'm hoping it's a clock problem with a packet getting stuck in one of the queues with an invalid time and maybe it will be a simple check to detect when that happens.

Fix is inbound (just letting it test for a while to make sure it is stable first).  Looks like the task_done in the queue was somehow getting called more often than there were queue items and it would start throwing an exception.  I don't see how that's possible since it's paired 1:1 with pulling items from the queue but since we don't join() the packet queue we don't actually need to know the task status so I just removed it.
So far it has been running for ~30 minutes with a test every 10 seconds with now issues.

Thank you @pmeenan
With the latest commit tsproxy is passing both my shell script test as well as long-running browsertime runs.
Nicely done!


[FEATURE]: EPSS Score on Vulnerability model

Describe the feature
Vulnerabilities can have an EPSS score attached to them. This describes the probability of a vulnerability being exploited. As of spec version 1.6, there is no clear way to attach this to a CycloneDX Vulnerability.
A vulnerability does have a slot for ratings, but it is not clear whether it can be used to include the EPSS, which consists of two values (the probability score itself, a percentile). It might be worth introducing a new slot for this vulnerability attribute.
Possible solutions
Shooting from the hip.
type Vulnerability {
  bom-ref string
  // ...
  epss    epssScore
}

type EpssScore {
  probability float
  percentile  float
}

Alternatives
Getting it into the ratings, but it does not really fit the "severity" category that ratings was intended for.
Additional context
Support for EPSS was added to SPDX 3.0: https://spdx.github.io/spdx-spec/v3.0/model/Security/Classes/EpssVulnAssessmentRelationship/

Thanks for the insightful response, @stevespringett. I've asked about KEV in the Slack thread, but I figured I should do it here since it's more discoverable by others.
Have you got any thoughts on supporting KEV in CDX?

@thiago-gitlab,
KEV defines the following properties:

property
description

cveID
The CVE ID of the vulnerability in the format CVE-YYYY-NNNN, note that the number portion can have more than 4 digits

vendorProject
The vendor or project name for the vulnerability

product
The vulnerability product

vulnerabilityName
The name of the vulnerability

dateAdded
The date the vulnerability was added to the catalog in the format YYYY-MM-DD

shortDescription
A short description of the vulnerability

requiredAction
The required action to address the vulnerability

dueDate
The date the required action is due in the format YYYY-MM-DD

knownRansomwareCampaignUse
'Known' if this vulnerability is known to have been leveraged as part of a ransomware campaign; 'Unknown' if CISA lacks confirmation that the vulnerability has been utilized for ransomware

notes
Any additional notes about the vulnerability

knownRansomwareCampaignUse is interesting but limited to only ransomware, which is unfortunate. The requiredAction and dueDate are U.S. Government specific. In fact, KEV itself is U.S. specific. If CycloneDX supported a catalogue of known exploitable vulnerabilities, it would need to do so in a more inclusive way. If you're interested in that, please create a new ticket and we can discuss there.


Automatic cast breaks playground

After #6074 merged, the following works.
x : Int8

x = 1

pp x

However it fails in playground with the following error
ERROR -- : Instrumention bug found (session=1, tag=1).

Yeah, that won't work. I think that gets re-written to:
x : Int8

x = instrument { 1 }

and of course that won't compile.
My suggestion: move the playground outside of the compiler, as a separate project. It will free us from having to track and fix these bugs here.
I really like the playground, but because of how it's currently implemented there's no way it can be exactly the Crystal language. There are many easy ways to break it by now.

Having the playground in the compiler directory looks a bit weird.
Creating https://github.com/crystal-lang/playground would be good.

+1 for moving it to crystal-lang/playground

I don't see much benefit of splitting it out. It's not crystal but it's hardly icr-levels of hacks and works as a good first approximation. Removing it is just detrimental to newcomers for purism's sake.

Who from the core team uses the playground? Or someone here that uses the playground daily?

@asterite I do, also @artlinkov its great for prototype and testing new ideas and types

In my opinion, a "standard playground" has little sense, it's a separate project of the Crystal compiler. It has its own HTML views, has its JS libraries in public with also CSS. And perhaps in the future it will use some npm packages with a package.json, JS linters/tests frameworks...
Tere are so many awesome tools like ameba that will fit better in the compiler tools, but they aren't integrated and it is fine.

Not to mention that the compiler depends on HTTP::Server for this whole purpose, and it's why we have all that without_openssl mess, because we can't compile the compiler and easily statically/dynamically link openssl. It would simplify things so much.

IMO we should ship playground with releases, but not necessarily have it part of the compiler itself. Similar to how shards is built and bundled with a new release, the same should be for playground.
My 2 cents.
Cheers.

If we ship it with the release that would mean we still need to have -Dwithout_openssl.
I strongly vote keep it.

Let's do a poll for the future of playground:
:+1: Move it out to https://github.com/crystal-lang/playground
:-1: Keep it in the compiler as is - don't change anything
:confused: Something between the two last propositions (e.g. moving in its repository but integrate it to the compiler somehow)

If we ship it with the release that would mean we still need to have -Dwithout_openssl

Yes, but just for crystal-playground binary, as crystal itself will no longer require SSL to work.
While Crystal still don't have a IPC or plugin mechanism, nothing stop us from having a shim command that invokes the playground binary (ala git with libexec's git-something binaries)
The compiler source code is always available to any project, so playground can be split from the codebase, maintained and build independently.
If the concerns are around the time will take to build playground and compiler in release mode, then we can benchmark the efficiency of the bc+obj cache of the two different projects accessing the same classes.
Cheers.

@RX14 , @bcardiff or @asterite, could you move out the playground to https://github.com/crystal-lang/playground – most of the community agree on this.
Then we could eventually open an issue on the new repo for if we want to integrate it, and how, to the Crystal compiler release.

I would like to see this done only and as long as the compiler is extended to let the program be instrumented in a better way as it is today. Otherwise changes to the language or the the ToSVisitor are too sensible to break the playground.
As pointed out, taking out the playground will result in bigger binary to distribute and specially some more distribution tasks that should be deferred since there was already a lot of work in distribution/infrastructure tasks.

Exactly, just because the "community agrees" on something doesn't mean it's actually a good idea.

seems a good rule, yet multi assignments wont work with that rule. but we can define different rules for multi-assign (there are already some custom rules for puts and print)
The instrumentation until now avoided adding new variables.

seems a good rule, yet multi assignments wont work with that rule. but we can define different rules for multi-assign (there are already some custom rules for puts and print)

sounds good

The instrumentation until now avoided adding new variables.

We add new variables with unguessable names all over desugaring and in macros, so this is acceptable.

One to throw my opinion about spliting the Playground. The other day I want to take that playground for something else(basically an devops tool to write runbook for oncall and execute from playground) then I realize it depends on the compiler repo somehow and cannot easy to split it out to compile and run on its own :(.

@v9n it'll always depend on the compiler whether or not its in a seperate repo. The crystal compiler is part of the stdlib however, so you should be able to require parts of the playground from any crystal program right now with no dependencies

@v9n you can build the playground (or the compiler) and tweak things. But maybe you can use the playground workbooks for your needs. There in a link in the navbar explaining a bit of them.
In a folder were you will start the $ crystal play you can create a playground subfolder and drop there .cr .md .html files that will render nicely. Each code section in .md with "```playground" or <pre class="playground"> in .html files will render the interactive playground. You can have multiple per files.

@RX14  @bcardiff That's awesome.

The error shown in playground is different now
error in line 2
Error: type must be Int8, not Int32

Crystal 0.31.1 on MacOS
$ crystal --version
Crystal 0.31.1 (2019-10-02)

LLVM: 8.0.1
Default target: x86_64-apple-macosx

If I change the code to this (added _i8)
x : Int8

x = 1_i8

pp x

The output in playground is
1 : Int8
1 : Int8


added the implicit type declarator using var

Had to define the arguments variable

@RickAndMSFT @Rick-Anderson


how can I import WSDL with xsd imports?

Hi,
Thank you for such a great tool. I'm just facing an issue related to a special WSDL with xsd:import and xsd:include that aren't imported and the mocks servers don't work.
Is there a way to import the imports and includes somehow?
Thanks,

HI @diegocastillomck.
Thank you very much for the kind words and for using Castle Mock!
Castle Mock ignores imports and includes since they are often quite problematic to deal with (Relative paths, problems with accessibility and so on). Nevertheless, I would very much like to investigate this particular problem. Would it be possible for you to provide an example WSDL on how your setup looks like?
Best regards,
Karl Dahlgren

@diegocastillomck I've worked with some WSDLs that have the same issue, but they provided a single wsdl as well, this is what I mean: https://stackoverflow.com/questions/25277536/what-is-the-difference-between-wsdl-and-singlewsdl-parameters

Hi @diegocastillomck.
Did you manage to resolve your issue? Can I close this?
Thank you.
Best regards,
Karl Dahlgren

Closing this issue. Please feel free to contact me again if you need help in the future.


use resolve/alias to resolve stylus import paths

Feature request
I'd like to be able to use the resolve/alias extension of webpack for stylus as well.
For example their is the relevant part of the webpack config
///...,
resolve: {
  extensions: ['.js', '.vue', '.json'],
  alias: {
    'vue$': 'vue/dist/vue.common.js',
    'assets': path.resolve(__dirname, './src/assets'),
    'components': path.resolve(__dirname, './src/components')
  }
},
// ....

let say I have a generic purpuse stylus file in src/assets/funcs.styl containing the following
add(a)
  a + a

and a component that is located in src/components/a/very/long/path/MyComponent.vue containing:
<template>

{{ msg }}

  </div
</template>

To reference my component where ever i am in the application, thanks to the webpackresolve/alias combo i can do import 'components/a/very/long/path/MyComponent'.
What i'll like to achieve is to replace in the vue file this line
@import "../../../../../../assets/funcs.styl"

With this
@import "assets/funcs"

by using the same mechanism used for the js file.
I beleive this feature would remove a lot of hard to find bug and would be a nice addition.
I first intended to post the Feature request in vue-style-loader, but couldn't. Hopefully I am in the right place for the job and don't hesitate to tell me if i need to move my questions.
Cheers and thanks for that plugin i love
Seb

I managed to get this to work by changing all my paths from path.join to path.resolve, apparently the alias' need to be absolute.
This is the snippet from my config...
const appPath = path.resolve(__dirname, 'app');
...
resolve: {
    extensions: ['', '.styl', '.jpg', '.png'],
    root: appPath,
    alias: {
        img: path.resolve(appPath, 'assets', 'img')
    }
},
module: {
    loaders: [
        { test: /\.styl$/, loader: ExtractTextPlugin.extract('style', 'css!postcss!stylus-relative-loader?resolve url')  }
     ]
},
stylus: {
    use: [],
    preferPathResolver: 'webpack'
}

and then in my stylus CSS I was able to use
background-image url('~img/risks.jpg')

This must be a common issue. Maybe it should be added to the readme?

I couldn’t get it to work with stylus imports in Vue 2.3.3, but I solved ot by writing this:
@import<EMAIL_ADDRESS>
This will import src/global.styl. I haven’t tried with url() but I guess it’s the same.
I’m leaving this here if someone else end up here looking for a solution for Stylus (because I did)… Hope that’s alright :)

I've just hit this myself actually, so thanks :)

you can solve this problem with that
config
alias: {
    'vue$': 'vue/dist/vue.common.js',
    'assets': path.resolve(__dirname, './src/assets'),
    'components': path.resolve(__dirname, './src/components')
  }

import
@import '~assets/func.styl'
I’ve tried it can work !
the key is that you need add the "~" in front of your alias

Unfortunately it still doesn't work for me, I'll create a demo project and see if I can reproduce it.

the path.resolve works for me

Where did this "extra ~ to use aliases" notation come from? Where can I find it in documentation? Is it webpack? Is it stylus? Is it vue-loader? (gasp) o.O

@qm3ster it is the stylus-loader. It is explained in the readme under usage

See my solution in: https://github.com/vuejs/component-compiler-utils/issues/49

Webpack aliases work in the master. If the problem persists, please reopen this issue with a minimally reproducible repo


Request: Plot peaklists

Peaklists have enough information for some simple plots (intensity, RT, m/z), in the absence of .raw data.

MZmine 2 has some plots like this:

scatter plot
logratio plot
CV plot
We are thinking to implement something like a XCMS's cloud plot in MZmine 3. If you have any suggestion for a useful plot, feel free to provide the details.

Hi, what I meant was a peaklist standalone plot.  e.g. a x-y scatter plot where each point is a single feature (x axis being RT, y axis being m/z).  It could be possible to color each point to indicate intensity, or log-ratio changes between samples.  Maybe the cloud plot is similar?

What you described is basically the existing logratio plot (found in Peak list methods / Data analysis in MZmine 2):

Although, I totally agree this plot is very basic and needs some improvements.

Thanks : ) I suppose what I thought was missing is mostly just plotting in the context of a single peaklist.  It seems all the existing peaklist visualizations in MZmine2 don't accept <2 peaklists, but yes the logratio plot style is what I meant.


Implemented GetActionsForFunctionDefinition #127

Signed-off-by: manick02<EMAIL_ADDRESS>Many thanks for submitting your Pull Request :heart:!
What this PR does / why we need it:
Implemented GetActionForFunctionDefinition utility Method
Special notes for reviewers:
Additional information (if needed):

@manick02 very nice! thank you again. Just left a small comment .


Stop pattern matching from unfolding the types unnecessarily.

The example is let {a,b} = c where c is in a record type with component types written in some custom operators. It seems those custom operators will be unfolded after the deconstruction of c. I wonder why? I thought the pattern matching would leave the component types alone. @jonsterling

Never mind. RedPRL is correct.


Crate yanked?

What happened to it?

Hi! A couple of years ago, the overly generic crate ncollide has been replaced by two distinct crates: ncollide2d and ncollide3d which are dedicated to 2D and 3D respectively.

Thanks. Maybe this could be advertised in the README? (With two different badges?) anyway, good to know.