Proxy not reusing sessions for first batch of recover requests

Hello!
We deployed an instance of pushpin on our kubernetes cluster with hint and poll for pushing data down SSE streams. We observed that, after a hint, it's going to send a recover request for each client connected. We know that pushpin aggregates/reuse requests on proxy level using sharing-key. However, it's only happening in kubernetes deployment, not with local docker container. It could also happen on local with docker's kubernetes enabled (not 100% sure about this).
After digging deeper, we see that the difference is in inspect not available log from proxy. We also see the ordering of logs is different. The proxy determines inspect not available before a zrpc sends and receives sharing-key.
The first "batch" of proxy request is going to have inspect not available for each request after a hint. Subsequent "batches" reuses proxy sessions as expected.
This happens on 1.38.0. We reverted to use 1.34.0 (that has zurl) and no longer sees this behavior (didn't test out 1.35.0, 1.36.0, or 1.37.0).
The log below has 4 clients connected to pushpin with param max_open_sessions=2. It is showing the first "batch" of recovery requests for 2 clients.
We see the proxy determines inspect not available and creating proxysession before it receives sharing-key from zrpc server, which seems to be the wrong order.
        [DEBUG] 2024-03-08 19:10:23.175 [proxy] zhttp/zws server: IN { "passthrough": { "trusted": true, "prefer-internal": true, "auto-share": true, "route": "*,*,*,*" }, "seq": 0, "id": "7d76447b-9e0c-4a29-a387-ac00ebcda1ab", "credits": 200000, "method": "GET", "uri": "http://localhost:7999/recover/1_289220_996_", "headers": [ [ "Grip-Last", "1_289220_996_; last-id=1_289220_996_" ] ], "ext": { "multi": true }, "from": "pushpin-handler_10", "stream": true }
        [DEBUG] 2024-03-08 19:10:23.175 [proxy] IN id=7d76447b-9e0c-4a29-a387-ac00ebcda1ab, GET http://localhost:7999/recover/1_289220_996_
        [DEBUG] 2024-03-08 19:10:23.175 [proxy] requestsession: 0xaaab066e51c0 localhost has 1 routes

        [DEBUG] 2024-03-08 19:10:23.176 [proxy] zhttp/zws server: IN { "passthrough": { "trusted": true, "prefer-internal": true, "auto-share": true, "route": "*,*,*,*" }, "seq": 0, "id": "2b8ef8e7-5526-42c1-b8a5-afffec407262", "credits": 200000, "method": "GET", "uri": "http://localhost:7999/recover/1_289220_996_", "headers": [ [ "Grip-Last", "1_289220_996_; last-id=1_289220_996_" ] ], "ext": { "multi": true }, "from": "pushpin-handler_10", "stream": true }
        [DEBUG] 2024-03-08 19:10:23.176 [proxy] IN id=2b8ef8e7-5526-42c1-b8a5-afffec407262, GET http://localhost:7999/recover/1_289220_996_
        [DEBUG] 2024-03-08 19:10:23.179 [proxy] requestsession: 0xaaab066db8a0 localhost has 1 routes

        [DEBUG] 2024-03-08 19:10:23.180 [proxy] zhttp/zws server: IN { "passthrough": { "trusted": true, "prefer-internal": true, "auto-share": true, "route": "*,*,*,*" }, "seq": 0, "id": "e7ab7436-c2a9-4425-8d38-ad3205f1a0e5", "credits": 200000, "method": "GET", "uri": "http://localhost:7999/recover/1_289220_996_", "headers": [ [ "Grip-Last", "1_289220_996_; last-id=1_289220_996_" ] ], "ext": { "multi": true }, "from": "pushpin-handler_10", "stream": true }
        [DEBUG] 2024-03-08 19:10:23.180 [proxy] zhttp/zws server: IN { "passthrough": { "trusted": true, "prefer-internal": true, "auto-share": true, "route": "*,*,*,*" }, "seq": 0, "id": "6463261a-d8dc-47f2-9dd7-3b8d7df49314", "credits": 200000, "method": "GET", "uri": "http://localhost:7999/recover/1_289220_996_", "headers": [ [ "Grip-Last", "1_289220_996_; last-id=1_289220_996_" ] ], "ext": { "multi": true }, "from": "pushpin-handler_10", "stream": true }

        [DEBUG] 2024-03-08 19:10:23.180 [proxy] zhttp server: OUT pushpin-handler_10 { "id": "7d76447b-9e0c-4a29-a387-ac00ebcda1ab", "seq": 0, "type": "keep-alive", "ext": { "multi": true }, "from": "pushpin-proxy_9" }
->        [DEBUG] 2024-03-08 19:10:23.180 [proxy] inspect not available

        [DEBUG] 2024-03-08 19:10:23.180 [proxy] zhttp server: OUT pushpin-handler_10 { "id": "2b8ef8e7-5526-42c1-b8a5-afffec407262", "seq": 0, "type": "keep-alive", "ext": { "multi": true }, "from": "pushpin-proxy_9" }
        [DEBUG] 2024-03-08 19:10:23.180 [proxy] inspect not available

->        [DEBUG] 2024-03-08 19:10:23.181 [proxy] zrpc client: OUT { "id": "d88406b1-7c74-44f5-9945-a7b8dc03a0af", "args": { "body": "", "auto-share": true, "method": "GET", "uri": "http://localhost:7999/recover/1_289220_996_", "headers": [ [ "Grip-Last", "1_289220_996_; last-id=1_289220_996_" ] ] }, "method": "inspect" }
->        [DEBUG] 2024-03-08 19:10:23.181 [proxy] creating proxysession for id=7d76447b-9e0c-4a29-a387-ac00ebcda1ab
        [DEBUG] 2024-03-08 19:10:23.181 [proxy] proxysession: 0xaaab066e1b40 forwarding to <IP_ADDRESS>:8080

        [DEBUG] 2024-03-08 19:10:23.181 [proxy] zrpc client: OUT { "id": "243bf7bc-97f0-47e7-8f50-5b71cc3da587", "args": { "body": "", "auto-share": true, "method": "GET", "uri": "http://localhost:7999/recover/1_289220_996_", "headers": [ [ "Grip-Last", "1_289220_996_; last-id=1_289220_996_" ] ] }, "method": "inspect" }
        [DEBUG] 2024-03-08 19:10:23.181 [proxy] creating proxysession for id=2b8ef8e7-5526-42c1-b8a5-afffec407262
        [DEBUG] 2024-03-08 19:10:23.181 [proxy] proxysession: 0xaaab066fce90 forwarding to <IP_ADDRESS>:8080

        [DEBUG] 2024-03-08 19:10:23.182 [proxy] zhttp client: OUT { "id": "c405cd07-12b6-4bc8-b77b-f5e3b3af8c4a", "seq": 0, "credits": 200000, "connect-port": 8080, "method": "GET", "uri": "http://localhost:7999/recover/1_289220_996_", "headers": [ [ "Grip-Last", "1_289220_996_; last-id=1_289220_996_" ], [ "Grip-Sig", "eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJleHAiOjE3MDk5Mjg2MjMsImlzcyI6InB1c2hwaW4ifQ.Ir7O5wfWuTWC4dl7_clnfqkyEnlns1gN1bkeRkjpK0k" ], [ "Grip-Feature", "status, session, link:next, filter:skip-self, filter:skip-users, filter:require-sub, filter:build-id, filter:var-subst" ], [ "Host", "localhost:7999" ] ], "ignore-policies": true, "ext": { "multi": true }, "from": "pushpin-proxy_9", "stream": true, "connect-host": "<IP_ADDRESS>" }
        [DEBUG] 2024-03-08 19:10:23.182 [proxy] zhttp client: OUT { "id": "30250e68-167d-4d1f-814d-2d22011b6e75", "seq": 0, "credits": 200000, "connect-port": 8080, "method": "GET", "uri": "http://localhost:7999/recover/1_289220_996_", "headers": [ [ "Grip-Last", "1_289220_996_; last-id=1_289220_996_" ], [ "Grip-Sig", "eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJleHAiOjE3MDk5Mjg2MjMsImlzcyI6InB1c2hwaW4ifQ.Ir7O5wfWuTWC4dl7_clnfqkyEnlns1gN1bkeRkjpK0k" ], [ "Grip-Feature", "status, session, link:next, filter:skip-self, filter:skip-users, filter:require-sub, filter:build-id, filter:var-subst" ], [ "Host", "localhost:7999" ] ], "ignore-policies": true, "ext": { "multi": true }, "from": "pushpin-proxy_9", "stream": true, "connect-host": "<IP_ADDRESS>" }

        [DEBUG] 2024-03-08 19:10:23.187 [handler] zhttp/zws client: IN pushpin-handler_10 { "type": "keep-alive", "seq": 0, "from": "pushpin-proxy_9", "id": "7d76447b-9e0c-4a29-a387-ac00ebcda1ab", "ext": { "multi": true } }

        [DEBUG] 2024-03-08 19:10:23.187 [condure] [pushpin::client] client-worker 1: stream conn starting 0 1/25000
        [DEBUG] 2024-03-08 19:10:23.187 [condure] [pushpin::executor] spawning future with size 12720
        [DEBUG] 2024-03-08 19:10:23.187 [condure] [pushpin::client] client-worker 1: task started: connection-0

        [DEBUG] 2024-03-08 19:10:23.187 [condure] [pushpin::connection] client-conn 1-0-30250e68-167d-4d1f-814d-2d22011b6e75: request: GET http://localhost:7999/recover/1_289220_996_
        [DEBUG] 2024-03-08 19:10:23.187 [condure] [pushpin::connection] client-conn 1-0-30250e68-167d-4d1f-814d-2d22011b6e75: resolving: [<IP_ADDRESS>]
        [DEBUG] 2024-03-08 19:10:23.187 [condure] [pushpin::connection] client-conn 1-0-30250e68-167d-4d1f-814d-2d22011b6e75: connecting to one of [<IP_ADDRESS>:8080]

        [DEBUG] 2024-03-08 19:10:23.187 [condure] [pushpin::client] client-worker 0: stream conn starting 0 1/25000
        [DEBUG] 2024-03-08 19:10:23.187 [condure] [pushpin::executor] spawning future with size 12720
        [DEBUG] 2024-03-08 19:10:23.187 [condure] [pushpin::client] client-worker 0: task started: connection-0

        [DEBUG] 2024-03-08 19:10:23.187 [condure] [pushpin::connection] client-conn 0-0-c405cd07-12b6-4bc8-b77b-f5e3b3af8c4a: request: GET http://localhost:7999/recover/1_289220_996_
        [DEBUG] 2024-03-08 19:10:23.187 [condure] [pushpin::connection] client-conn 0-0-c405cd07-12b6-4bc8-b77b-f5e3b3af8c4a: resolving: [<IP_ADDRESS>]

       [DEBUG] 2024-03-08 19:10:23.187 [handler] zhttp client: OUT pushpin-proxy_9 { "type": "keep-alive", "seq": 1, "from": "pushpin-handler_10", "id": "7d76447b-9e0c-4a29-a387-ac00ebcda1ab" }

        [DEBUG] 2024-03-08 19:10:23.187 [condure] [pushpin::connection] client-conn 0-0-c405cd07-12b6-4bc8-b77b-f5e3b3af8c4a: connecting to one of [<IP_ADDRESS>:8080]
        [DEBUG] 2024-03-08 19:10:23.187 [handler] zhttp/zws client: IN pushpin-handler_10 { "type": "keep-alive", "seq": 0, "from": "pushpin-proxy_9", "id": "2b8ef8e7-5526-42c1-b8a5-afffec407262", "ext": { "multi": true } }

        [DEBUG] 2024-03-08 19:10:23.187 [handler] zhttp client: OUT pushpin-proxy_9 { "type": "keep-alive", "seq": 1, "from": "pushpin-handler_10", "id": "2b8ef8e7-5526-42c1-b8a5-afffec407262" }

->        [DEBUG] 2024-03-08 19:10:23.188 [handler] zrpc server: IN { "args": { "headers": [ [ "Grip-Last", "1_289220_996_; last-id=1_289220_996_" ] ], "method": "GET", "uri": "http://localhost:7999/recover/1_289220_996_", "body": "", "auto-share": true }, "id": "d88406b1-7c74-44f5-9945-a7b8dc03a0af", "method": "inspect" }
->        [DEBUG] 2024-03-08 19:10:23.188 [handler] zrpc server: OUT { "success": true, "id": "d88406b1-7c74-44f5-9945-a7b8dc03a0af", "value": { "no-proxy": false, "sharing-key": "auto|http://localhost:7999/recover/1_289220_996_|1_289220_996_; last-id=1_289220_996_" } }
        [DEBUG] 2024-03-08 19:10:23.188 [handler] zrpc server: IN { "args": { "headers": [ [ "Grip-Last", "1_289220_996_; last-id=1_289220_996_" ] ], "method": "GET", "uri": "http://localhost:7999/recover/1_289220_996_", "body": "", "auto-share": true }, "id": "243bf7bc-97f0-47e7-8f50-5b71cc3da587", "method": "inspect" }
        [DEBUG] 2024-03-08 19:10:23.188 [handler] zrpc server: OUT { "success": true, "id": "243bf7bc-97f0-47e7-8f50-5b71cc3da587", "value": { "no-proxy": false, "sharing-key": "auto|http://localhost:7999/recover/1_289220_996_|1_289220_996_; last-id=1_289220_996_" } }
        [DEBUG] 2024-03-08 19:10:23.188 [proxy] zhttp/zws server: IN stream { "seq": 1, "id": "7d76447b-9e0c-4a29-a387-ac00ebcda1ab", "type": "keep-alive", "from": "pushpin-handler_10" }
        [DEBUG] 2024-03-08 19:10:23.188 [proxy] zhttp/zws server: IN stream { "seq": 1, "id": "2b8ef8e7-5526-42c1-b8a5-afffec407262", "type": "keep-alive", "from": "pushpin-handler_10" }
        [DEBUG] 2024-03-08 19:10:23.188 [proxy] zhttp/zws client: IN pushpin-proxy_9 { "id": "30250e68-167d-4d1f-814d-2d22011b6e75", "seq": 0, "type": "keep-alive", "ext": { "multi": true }, "from": "condure" }
        [DEBUG] 2024-03-08 19:10:23.188 [proxy] zhttp client: OUT condure { "id": "30250e68-167d-4d1f-814d-2d22011b6e75", "seq": 1, "type": "keep-alive", "from": "pushpin-proxy_9" }
        [DEBUG] 2024-03-08 19:10:23.188 [proxy] zhttp/zws client: IN pushpin-proxy_9 { "id": "c405cd07-12b6-4bc8-b77b-f5e3b3af8c4a", "seq": 0, "type": "keep-alive", "ext": { "multi": true }, "from": "condure" }
        [DEBUG] 2024-03-08 19:10:23.188 [proxy] zhttp client: OUT condure { "id": "c405cd07-12b6-4bc8-b77b-f5e3b3af8c4a", "seq": 1, "type": "keep-alive", "from": "pushpin-proxy_9" }
        [DEBUG] 2024-03-08 19:10:23.188 [condure] [pushpin::client] client-worker 1: queued zmq message for 1 conns
        [DEBUG] 2024-03-08 19:10:23.188 [condure] [pushpin::connection] client-conn 1-0-30250e68-167d-4d1f-814d-2d22011b6e75: handle packet: keep-alive
        [DEBUG] 2024-03-08 19:10:23.188 [condure] [pushpin::client] client-worker 0: queued zmq message for 1 conns
        [DEBUG] 2024-03-08 19:10:23.188 [condure] [pushpin::connection] client-conn 0-0-c405cd07-12b6-4bc8-b77b-f5e3b3af8c4a: handle packet: keep-alive

->        [DEBUG] 2024-03-08 19:10:23.188 [proxy] zrpc client: IN { "id": "d88406b1-7c74-44f5-9945-a7b8dc03a0af", "value": { "no-proxy": false, "sharing-key": "auto|http://localhost:7999/recover/1_289220_996_|1_289220_996_; last-id=1_289220_996_" }, "success": true }
        [DEBUG] 2024-03-08 19:10:23.188 [proxy] zrpc client: IN { "id": "243bf7bc-97f0-47e7-8f50-5b71cc3da587", "value": { "no-proxy": false, "sharing-key": "auto|http://localhost:7999/recover/1_289220_996_|1_289220_996_; last-id=1_289220_996_" }, "success": true }

        [DEBUG] 2024-03-08 19:10:23.222 [condure] [pushpin::connection] client-conn 0-0-c405cd07-12b6-4bc8-b77b-f5e3b3af8c4a: connected to <IP_ADDRESS>:8080
        [DEBUG] 2024-03-08 19:10:23.228 [condure] [pushpin::connection] client-conn 1-0-30250e68-167d-4d1f-814d-2d22011b6e75: connected to <IP_ADDRESS>:8080
        [DEBUG] 2024-03-08 19:10:23.288 [condure] [pushpin::connection] client-conn 1-0-30250e68-167d-4d1f-814d-2d22011b6e75: response: 200 OK
        [DEBUG] 2024-03-08 19:10:23.288 [condure] [pushpin::connection] client-conn 1-0-30250e68-167d-4d1f-814d-2d22011b6e75: finished

The log below shows the right ordering. First fetch inspect data, then do proxy with the sharing-key available.
->        [DEBUG] 2024-03-08 19:10:23.289 [proxy] zrpc client: OUT { "id": "b23402dc-e957-4a10-8079-e5e11f3473e2", "args": { "body": "", "auto-share": true, "method": "GET", "uri": "http://localhost:7999/recover/1_289220_996_", "headers": [ [ "Grip-Last", "1_289220_996_; last-id=1_289220_996_" ] ] }, "method": "inspect" }
        [DEBUG] 2024-03-08 19:10:23.290 [proxy] zhttp/zws server: IN stream { "seq": 1, "id": "e7ab7436-c2a9-4425-8d38-ad3205f1a0e5", "type": "keep-alive", "from": "pushpin-handler_10" }
        [DEBUG] 2024-03-08 19:10:23.289 [handler] zhttp/zws client: IN pushpin-handler_10 { "code": 200, "seq": 1, "from": "pushpin-proxy_9", "id": "2b8ef8e7-5526-42c1-b8a5-afffec407262", "headers": [ [ "Date", "Fri, 08 Mar 2024 19:10:23 GMT" ], [ "Content-Length", "1044" ], [ "Grip-Hold", "stream" ], [ "Grip-Channel", "1_289220_996_; prev-id=1_289220_996_" ], [ "Grip-Keep-Alive", "data:  \\n\\n; format=cstring; timeout=15" ], [ "Grip-Link", "</recover/1_289220_996_>; rel=next; timeout=2147483" ], [ "Vary", "Origin" ], [ "X-Content-Type-Options", "nosniff" ] ], "reason": "OK" } 1044 "data: [{\"key\":\"peter-test-5\",\"metadata\":{\"deployed\":true,\"evaluationMode\":\"remote\",\"flagType\":\"release\",\"flagVersion\":37},\"segments\":[{\"metadata\":{\"segmentName\":\"default\"},\"variant\":\"off\"}],\"variants\":{\"off\":{\"key\":\"off\",\"metadata\":{\"default\":true}},\"on\":{\"key\":\"on\",\"payload\":{\"haha\":\"aa\"},\"value\":\"on\"}}},{\"key\":\"peter-test-local-1\",\"metadata\":{\"deployed\":true,\"evaluationMode\":\"local\",\"flagType\":\"release\",\"flagVersion\":150},\"segments\":[{\"conditions\":[[{\"op\":\"is\",\"selector\":[\"context\",\"user\",\"use...r\":[\"context\",\"user\",\"device_id\"],\"values\":[\"asdf\"]}]],\"metadata\":{\"segmentName\":\"individual-inclusions\"},\"variant\":\"on\"},{\"bucket\":{\"allocations\":[{\"distributions\":[{\"range\":[0,42949673],\"variant\":\"on\"}],\"range\":[0,92]}],\"salt\":\"iQ7VVBCW\",\"selector\":[\"context\",\"user\",\"device_id\"]},\"metadata\":{\"segmentName\":\"All Other Users\"},\"variant\":\"off\"}],\"variants\":{\"off\":{\"key\":\"off\",\"metadata\":{\"default\":true}},\"on\":{\"key\":\"on\",\"payload\":{\"a\":\"ffeffefffeeaaeeeff0cc0ee0ee111ee1ff10\"},\"value\":\"on\"}}}]\n\n"
        [INFO] 2024-03-08 19:10:23.289 [handler] GET http://localhost:7999/recover/1_289220_996_ route=*,*,*,* code=200 1044 #1_289220_996_=1_289220_996_
        [DEBUG] 2024-03-08 19:10:23.289 [handler] zhttp/zws client: IN pushpin-handler_10 { "type": "keep-alive", "seq": 0, "from": "pushpin-proxy_9", "id": "e7ab7436-c2a9-4425-8d38-ad3205f1a0e5", "ext": { "multi": true } }
        [DEBUG] 2024-03-08 19:10:23.289 [handler] zhttp client: OUT pushpin-proxy_9 { "type": "keep-alive", "seq": 1, "from": "pushpin-handler_10", "id": "e7ab7436-c2a9-4425-8d38-ad3205f1a0e5" }
->        [DEBUG] 2024-03-08 19:10:23.290 [handler] zrpc server: IN { "args": { "headers": [ [ "Grip-Last", "1_289220_996_; last-id=1_289220_996_" ] ], "method": "GET", "uri": "http://localhost:7999/recover/1_289220_996_", "body": "", "auto-share": true }, "id": "b23402dc-e957-4a10-8079-e5e11f3473e2", "method": "inspect" }
->        [DEBUG] 2024-03-08 19:10:23.290 [handler] zrpc server: OUT { "success": true, "id": "b23402dc-e957-4a10-8079-e5e11f3473e2", "value": { "no-proxy": false, "sharing-key": "auto|http://localhost:7999/recover/1_289220_996_|1_289220_996_; last-id=1_289220_996_" } }

->        [DEBUG] 2024-03-08 19:10:23.290 [proxy] zrpc client: IN { "id": "b23402dc-e957-4a10-8079-e5e11f3473e2", "value": { "no-proxy": false, "sharing-key": "auto|http://localhost:7999/recover/1_289220_996_|1_289220_996_; last-id=1_289220_996_" }, "success": true }
->        [DEBUG] 2024-03-08 19:10:23.290 [proxy] need to proxy with sharing key: auto|http://localhost:7999/recover/1_289220_996_|1_289220_996_; last-id=1_289220_996_
        [DEBUG] 2024-03-08 19:10:23.290 [proxy] creating proxysession for id=e7ab7436-c2a9-4425-8d38-ad3205f1a0e5
        [DEBUG] 2024-03-08 19:10:23.290 [proxy] proxysession: 0xaaab066daad0 forwarding to <IP_ADDRESS>:8080

Thanks!

Hi Peter,
Are you seeing the "inspect not available" message for incoming client requests too, or only for next link fetches?

Hi Justin,
Yes, only for next link fetches. And only after hint. The initial large response on new connections with Grip-Link works fine and reuses proxy sessions as well.
Also just tested with 1.37.0 and that seems to work as well.

I was able to reproduce this. It seems the issue has to do with external routing (when the scheme/domain of the next link is different than that of the original request), although it is possible older versions may have slightly different behavior. Maybe the links differ in your environments.
In any case, this does look like a bug, and will be fixed in the next version very soon.


Exception problems

@anuraj, I am using ASP.NET Core (.NET Core 2.0 Preview 2)
This great middleware won't work with app.UseExceptionHandler("/error"); app.UseStatusCodePages();
app.UseHTMLMinification("(w*)page*");

Strangely enough, it works when I call this middleware before app.UseStatusCodePages().
Below order works:
app.UseExceptionHandler("/error");
app.UseHTMLMinification("(w*)page*");
app.UseStatusCodePages();

Sorry for the late response. Since StatusCodePagesMiddleware handles the status codes, may be the minification middleware unable to get the status code. And stops working.
As it is working by moving before StatusCodePagesMiddleware, I am closing this issue.

Fair enough.


Todo lists for extension implementations

I have a habit of adding a todo list into javadoc or kotlindoc when I start implementing an extension, so that I can keep track of the activities I still have to do. It is something like:
For inspections:
 * TODO: javadoc
 * TODO: test
 * TODO: readme
 * TODO: html description
 * TODO: quick fix - optional
 * TODO: messages into bundle
 * TODO: settings panel - optional

For Intention actions:
 * TODO: javadoc
 * TODO: test
 * TODO: readme
 * TODO: html description
 * TODO: messages into bundle
 * TODO: before/after templates

Live templates might be a good candidate to create such todo lists, that are also customizable, so that they can easily be added to documentation comments.

Completed.


Create PeakGroup and Measurement objects

Create ObservedCompound and Measurement objects
Measurement object will need functions to lookup/compute values including:

serum_infusate_abundance - the 'normalized_abundance' for the infusate compound (tracer) in the serum sample from this mouse. If 13C-lactate was infused this is the value for 'normalized_abundance' of serum lactate.
normalized_fraction - normalized_abundance / serum_infusate_abundance, the lab usually calls this 'normalized labeling'

PeakGroup
-
id PK int
label string                       # Compound or isomer group name
formula string INDEX               # Molecular formula
ms_run_id int FK >- MSRun.id
compound_id int FK >-< Compound.id # Many-to-many

Measurement
-
id PK int
peak_group_id int FK >- PeakGroup.id
labeled_element string
labeled_count int
# Composite Key -> observed_compound_id, labeled_atom, and labeled_count
raw_abundance float
corrected_abundance float  # also called total_ion_count
normalized_abundance float # also called "fraction"
med_mz float
med_rt float
# Additional computed values
# serum_infusate_abundance

Didn't Michael say some analog of presumed compound would be more accurate?  The observation is not really of the compound.

@lparsons I see that labeled_element and labeled_count are very similar to animal.tracer_labeled_atom and animal.tracer_labeled_count .  Should I make an abstract base class for "TracerLabeledThings" for for shared thing like MAX_LABELED_COUNT or TRACER_LABELED_ELEMENT_CHOICES?  Just wondering...

@lparsons I see that measurement.labeled_element and measurement.labeled_count are very similar to animal.tracer_labeled_atom and animal.tracer_labeled_count . Should I make an abstract base class for "TracerLabeledThings" for for shared data like MAX_LABELED_COUNT or TRACER_LABELED_ELEMENT_CHOICES? Just wondering...

It makes sense to avoid duplication for sure. I'm not certain of the best way to do that off the top of my head, but you're welcome to take a stab at it if you like. I'm also happy leaving this as a future enhancement. A couple of thoughts:

The elements that would be labeled (i.e. TRACER_LABELED_ELEMENT_CHOICES) would certainly come from the same list, it might be good to create a class for that.
The MAX_LABELED_COUNT, however, should be dynamically controlled for each compound, and be the number of those elements present in the formula. That should probably be a method in the Compound class.

will change peakgroup.label to peakgroup.name


Add Contributing.md file as well as update the readme file

Hii @swapnilsparsh,
I would like to work on contributing.md as well as updating the present readme file by adding some cool elements which look amazing or gives a  cool/nice look.
Hope you like it!
Thankyou in advance

That's great
You can work on this.

Thankyou @swapnilsparsh!
Is there any time period for submitting the PR?

Thankyou @swapnilsparsh!
Is there any time period for submitting the PR?

No time period.
PR will be merged on first come first serve basis.
So anyone can work on this issue but first you have to tell that you are interested in the issue so that I can assign it to you.

Ok great!
Yeah, I would love to contribute to this issue.

Ok great!
Yeah, I would love to contribute to this issue.

That's great.

Hello, i would be glad if you assign this to me. I am eager to help in such a good project.

Hi!
I would love to work on a project like this. Very keen on working for Women Security with you. Thank you :)

Hello sir !
I also would like to work on this issue

Hello, i would be glad if you assign this to me. I am eager to help in such a good project.

@smriti1313  You can start your work.

@IshetaBansal and @Himanshi2016 you have to wait for 3-5 days as 2 people are already assigned on this issue.
Kindly give some time to the assignees to resolve the issue then you can work on this issue till then look after some other issues.

Hello
I would love to work on this issue.

Hello
I would love to work on this issue.

Thank you for showing you interest in the project.
@kanishkaa24  you have to wait for 3-5 days as 2 people are already assigned on this issue.
Kindly give some time to the assignees to resolve the issue then you can work on this issue till then look after some other issues.
We appreciate your patience.

Can you tell me in detail about contributing.md? What shall be included in it? Also I have done readme part. So can i pull request of that part?

Can you tell me in detail about contributing.md? What shall be included in it? Also I have done readme part. So can i pull request of that part?

Keep all the necessary things that are there in contributing.md file and that's great that you have finished the Readme part.
But this issue is for both contributing.md file and Readme file, so when you are done with both the issues resolved then request a PR.

Can you tell me in detail about contributing.md? What shall be included in it? Also I have done readme part. So can i pull request of that part?

Keep all the necessary things that are there in contributing.md file and that's great that you have finished the Readme part.
But this issue is for both contributing.md file and Readme file, so when you are done with both the issues resolved then request a PR.

@swapnilsparsh What sort of necessary things? It would be great if you could give an example or two. Thank you

Can you tell me in detail about contributing.md? What shall be included in it? Also I have done readme part. So can i pull request of that part?

Keep all the necessary things that are there in contributing.md file and that's great that you have finished the Readme part.
But this issue is for both contributing.md file and Readme file, so when you are done with both the issues resolved then request a PR.

@swapnilsparsh What sort of necessary things? It would be great if you could give an example or two. Thank you

Contribution (heading and some general info)
Pull Request Process
Code of Conduct
and etc.

Looks interesting I can work on this issue assign me @swapnilsparsh

Looks interesting I can work on this issue assign me @swapnilsparsh

It's already assigned to you.

Looks interesting I can work on this issue assign me @swapnilsparsh

Thank you for showing you interest in the project.
@pankaj892  you have to wait for 3-5 days as 2 people are already assigned on this issue.
Kindly give some time to the assignees to resolve the issue then you can work on this issue till then look after some other issues.
We appreciate your patience.

This is how now Readme.md file looks:

This is how now Conributing.md file looks:

@bhavesh1129
Both the files are looking awesome.
Send a PR so I can merge it.

Issue has been resolved by @smriti1313


lexgen 20241030

@brianolson: there was a lexgen issue in here that I manually worked around. we have a new lexicon which uses a ref directly for the API endpoint "input" schema, which maybe hasn't be exercised before.

Is there a way to fix this so that the next person to run make lexgen doesn't undo that patch? e.g. I check this out and run make lexgen and ...
-func SetUpsertSet(ctx context.Context, c *xrpc.Client, input *SetDefs_Set) (*SetDefs_SetView, error) {
+func SetUpsertSet(ctx context.Context, c *xrpc.Client, input *SetUpsertSet_Input) (*SetDefs_SetView, error) {

@brianolson I have a PR trying to fix lexgen for this here: https://github.com/bluesky-social/indigo/pull/788


[UI] Interface elements are displayed and clickable when clicking on the burger menu button in the user's personal account if the user has the 750 screen extension installed.

Environment: Windows 10, 64-bit, Google Chrome 117.0.5938.92,
Windows 10, 64-bit, Microsoft Edge 114.0.1823.67.
Reproducible: always.
Preconditions

Go to (https://oos.dmytrominochkin.cloud/)
The user is authorized as a parent.
750 screen extension installed.

Steps to reproduce

Go to the "Personal information" tab.
Click on the "Burger menu" button.

Actual result
A burger menu opens, interface elements shine through the interface, and are also clickable.

Expected result
The burger menu opens. All interface elements are aligned, written without errors, colors are reproduced according to the mockup.
Labels to be added
"Bug", Priority ("pri: Low"), Severity ("severity: Low"), Type ("UI").

Fixed in #2263


GEM_HOME and GEM_PATH not set by Rubyinstaller, is this default behavior?

Hi, on Windows 7 64bit I am observing that after installing Ruby 2.3.0 64bit, using latest RubyInstaller, GEM_PATH and GEM_HOME env. variables are not set and this is giving me some problems with SSL root certificate file and other minor issues. Now, I know that I can easily set those vars manually, but what I am trying to understand here is if there is some kind of bug in RubyInstaller which prevents it to set them, in case this is the default expected behavior.
So, is RubyInstaller setting those environment variables (and possibly others) by default?
Based on this answer I will have to diagnose other kinds of problems with my system (where I also have installed JRuby <IP_ADDRESS>. which is also in path...).
Thanks.

No, GEM_HOME and GEM_PATH are managed by Ruby itself unless explicitly asked to do so otherwise.
We considered at one point using GEM_HOME and GEM_PATH to install gems npm style in a different directory, but since binary gems are super common and have breaking changes in every minor release we decided against it.


Progress is inaccurate (overestimating time taken) when reusing checkpoint

Repro steps:

Import some large database, long enough for the progress log to appear
Ctrl+C before all tables are written
Resume from checkpoint
Note that the remaining time is very long, as it includes those files already processed.

I think there are two different problems that affect the accuracy:

we resume from checkpoint we don't consider chunks already finished restore.

this can be easily fixed by adjust the estimate logic

how to estimate the extra time needed for import data with local/importer backend

not sure if there is easy way


Error Messages for Action with RunPageLink

I get three error messages if try to create an Action on Page Chart of Accounts:

Reference to object Change Log Entries is ambiguous. Make sure you are not referencing packages containing objects with the same names.

The property value '"Table No."=CONST(15), "Primary Key Field 1 Value"=FIELD("No.")' on property 'RunPageLink' is not valid.

Field type Text is not convertible to field type Code.

pageextension 70000002 pageextension70000002 extends "Chart of Accounts"
{
  layout
  {
  }
  actions
  {
    addafter("G/L Register")
    {
      action("Change Log Entries")
      {
        CaptionML=DEU='Änderungsprotokoll',
                  ENU='Change Log Entries';
        Image=ChangeLog;
        RunObject=Page "Change Log Entries";
        RunPageLink="Table No."=CONST(15), "Primary Key Field 1 Value"=FIELD("No.");
        RunPageView=SORTING("Table No.","Primary Key Field 1 Value") ORDER(Descending);
      }
    }
  }
}

I cannot reproduce it either. It looks like this one is also caused by ambiguous references.
Do you have any extension dependencies in app.json? Can you make sure that you have up to date symbol files (.app) by deleting them from the cache and redownloading from the server?

There are no dependencies in app.json. I deleted the symbol files. Problem still exists.
I attached a sample project with the .al-File in the screenshot, which generates the second and third error message in the September Update Azure VM. I try to reproduce the first error message for the case #745.
Microsoft (R) AL Compiler version 0.9.12794
Copyright (C) Microsoft Corporation. All rights reserved

c:\Users\vmadmin\Simple Project\Modification  - Chart of Accounts(Page 16).al(13,44): error AL0204: Field type Text is not convertible to field type Code.
c:\Users\vmadmin\Simple Project\Modification  - Chart of Accounts(Page 16).al(13,21): error AL0171: The property value '"Table No."=CONST(15), "Primary Key Field 1 Value"=FIELD("No.")' on property 'RunPageLink' is not valid.
Error: The package could not be created.

Simple Project.zip


Home hub /setup/scan_results returns 403

Running: curl -vvv -H "Content-Type: application/json" http://192.168.xx.xx:8008/setup/scan_results responds in a 403, not sure if I'm missing something here?
*   Trying 192.168.xx.xx...
* TCP_NODELAY set
* Connected to home.hub (192.168.xx.xx) port 8008 (#0)
> GET /setup/scan_results HTTP/1.1
> Host: home.hub:8008
> User-Agent: curl/7.54.0
> Accept: */*
> Content-Type: application/json
>
< HTTP/1.1 403 Forbidden
< Content-Length:0
<
* Connection #0 to host 192.168.xx.xx left intact

Ah sorry for the noise, just seen your other open github issue #39  and https://gist.github.com/rithvikvibhu/1a0f4937af957ef6a78453e3be482c1f

That reminds me to add a link in the readme.


Feat:Enabled PWA for the site

Related Issue
Feat:Enable PWA for the site
Fixes:  #1556
Description
I have made the site PWA or Progressive Web Application enabled, so the users can install it locally into their system as a desktop or android application. It also provides offline access by pre-download assets such as files or images.
Additional Context
I have modified index.html file with an inline comment to link manifest.json. I have also added two other files named manifest.json and service-worker.js for enabling PWA. I have also added a service worker script in script.js at the bottom with an inline comment to detect service-worker.js file in the root of the folder. I have also added logo2.png to 192x192 and 512x512 format for app icon in different screen sizes.
Type of PR

[ ] Bug fix
[X] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
Since PWA only works for HTTPS sites and not in local server, I am attaching my previous work as a GSSoC Ext Contributor;
https://www.loom.com/share/635a2d108ff7426a9fb0eb06a61371cc?sid=369d79af-ec92-47ff-82b2-bf95fd163aed
Checklist:

[X] I have made this change from my own.
[X] I have taken help from some online resources.
[X] My code follows the style guidelines of this project.
[X] I have performed a self-review of my own code.
[X] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[X] My changes generate no new warnings.
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers and screenshots after making the changes.

@PriyaGhosal I have opened a PR for #1556 and it has no conflicts with the main branch

@mohammedanaf  Your pull request has been successfully merged! Don't stop here—continue contributing by addressing more issues and aiming to become a top contributor. Exclusive swag awaits for those who go the extra mile! Also Take a moment to ⭐ Star the repository if you haven't already.
Great contribution ! 🎉


Adapt the event message regex in the OOM tracker (release-1.16)

Get rid of Kill process <PID> (<PROCESS_NAME>) score 0 or sacrifice child\n part of the OOM event message regex as it's no longer printed out in the kernel logs.
Backports #1579.
/sig scalability
/assign @jkaniuk

/lgtm
/approve


Custom Regex Path Matching for Processes

These changes allow you to map a slider to all processes that exist under one or more specific directory paths. These directory paths can be defined using regex, and any processes that have paths which match the given regex can be assigned to the custom slider mapping deej.custom_match.

Hey there @jackphilippi, thank you for your interest in contributing to deej.
As per the project's contribution guidelines, I'm currently not accepting PR submissions for deej's main fork. That being said, I encourage you to continue working on these changes to your heart's content in your own fork of the project.


Add Storage and Model Components of VacantRoomFinder Feature

Add Storage component to read and process information from venueinformation.json file.
Add Building, Room, Week, WeekDay classes.
WIP: read and process venueinformation when the MainApp runs
#76

Pull Request Test Coverage Report for Build 193

0 of 106 (0.0%) changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-3.4%) to 76.522%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/logic/parser/VacantCommandParser.java
0
1
0.0%

src/main/java/seedu/address/storage/ReadOnlyJsonVenueInformation.java
0
9
0.0%

src/main/java/seedu/address/model/building/Room.java
0
16
0.0%

src/main/java/seedu/address/model/building/Building.java
0
23
0.0%

src/main/java/seedu/address/model/building/Week.java
0
26
0.0%

src/main/java/seedu/address/model/building/WeekDay.java
0
31
0.0%

Totals

Change from base Build 185:
-3.4%

Covered Lines:
1822

Relevant Lines:
2381

💛  - Coveralls


Update bats-core to official release once it is available

See #1559 for reference.

Bats-core 1.2.0 was released yesterday: https://github.com/bats-core/bats-core/releases/tag/v1.2.0

It's time to close this issue then?

Indeed - thanks for the reminder!


(PUP-7221) Type schedule should accept integers for weekdays

All rspec tests passed when I ran them on Puppet 5.3.3.

CLA signed by all contributors.

In the error string for your test, you want to replace %{value} with what you expect it to actually be in the error (in this case 7), and get rid of the format hash. You're asserting exactly what the error should be, once that variable has been filled in in the code.


DBZ-404 Postgres container is detected as started after initialization

https://issues.jboss.org/browse/DBZ-404

Ah, very nice you fixed that, @jpechane. It was bugging me, but still below "taking action" threshold ;)


Update REARDME.md to include Traffic Influnce

Included the Traffic Influence feature in the Edge Cloud API Family description

@Kevsy I have fixed the Typo


doc: add richardlau to maintainers

Thank you for inviting me to join.

Welcome Richard!

Landed in https://github.com/libuv/libuv/commit/c6331a42ce50341461668cde55e87667629a6090.


feat: Add Inspector EntityDropdown Field

This PR adds a util EntityDropdown field to show entities based on components.

Closes https://github.com/decentraland/sdk/issues/978

I noticed that the padding between the fields is gone in this PR, I don't know if it's coming from the changes in this branch, but I don't see it like that on other PRs

I noticed that the padding between the fields is gone in this PR, I don't know if it's coming from the changes in this branch, but I don't see it like that on other PRs

You're right, I removed the TextboxField margin in this PR: https://github.com/decentraland/js-sdk-toolchain/pull/806/files#diff-c8c97e2ba0e6703f0fc5316c5927e8c163ca9db1f3f394cf43a53656d387fc32L7
Fixing it

there's another issue i noticed with the dropdowns:
https://github.com/decentraland/js-sdk-toolchain/assets/2781777/a938b714-9322-4bad-955a-290d6cecb811


feat: read mailbox every 15 minutes

Resolves  #22
In addition, @sansan88 you should take care of  the following as displayed in the documentation

Important: Cloud Scheduler requires that your project have a Google App Engine (GAE) app; during its setup you're prompted to select your project's default Google Cloud Platform (GCP) resource location. This location will be used for GCP services in your project that require a location setting, specifically, your default Cloud Storage bucket and your Cloud Firestore database.
When setting your project's default GCP resource location, primarily consider where you want to store your data and files and, secondly, where you want to run any triggered functions for Cloud Firestore and Cloud Storage. After you set your project's default GCP resource location, you cannot change it.

thank you david! yes I know this from the documentation. but good to have it documented here!

added europe-west6


Added hints, leaderboard, adjusted scores for hints, json q's data package

I added the following functionality.

Hints (borrowed heavily from another pull request)
Score adjusted for hints
JSON Data file within package (it's just easier to have everything in one repo)
Leaderboard (top or bottom)
Entities decoder for "&" string values

Feel free to totally dismiss my request or raise concerns or fixes to merge this. If you decide to totally abandon my request, I might just maintain the fork as an alternative.

I do like some of the ideas, like scoring adjusted for hints. I might make that an option in the future. I'm not going to add the question set, for various reasons. Feel free to maintain a fork though! If I add some of your code, there will of course be attribution in the code.


CRA - DOM has unwanted iframe which blocks to choose the element from developer tool

Didn't work the below steps. Still there is an iframe inside the dom.
I recently had this issue aswell.
I did couple of things to make it work. You can try these aswell.

Change the react-script version to 4.0.3 inside package.json.
Add this to package.json below the dependencies
"resolutions": { "react-error-overlay": "6.0.9" },
Install react-error-overlay v6.0.9 inside your devDependencies.
Remove your node_modules and package-lock.json.
Do npm install and check that works.
Note: After doing the above steps i had to run npm install<EMAIL_ADDRESS>again to fix this issue.

Hope this helps!!

This is happening with us too. It's blocking the entire app content. It's happening for only localhost AFAIK. It's happening on Chrome and Firefox browsers too.
Please check the screenshot below for more details:

Same case for me.
I solved using this issue https://github.com/facebook/create-react-app/issues/11880


rule update: fix macro reference

Signed-off-by: kaizhe<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:
Fix a macro reference
Which issue(s) this PR fixes:
Macro remote_file_copy_procs reference to macro remote_file_copy_procs with typo.

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Fix macro `remote_file_copy_procs`

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign kaizhe
You can assign the PR to them by writing /assign @kaizhe in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

rules/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 516cb704094edcc62394a9a332b77066f07401da

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mstemm
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

rules/OWNERS [mstemm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leodido, mstemm
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

rules/OWNERS [leodido,mstemm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


refactor(e2e): only start servers when needed

Note that this change is also a workaround for:
https://github.com/microsoft/playwright/issues/18209

@quentinderoubaix Thank you for your review!


How can I enable MMBarricade for AFHTTPSessionManager in AFNetworking ?

AFHTTPSessionManager is a subclass of AFURLSessionManager with convenience methods for making HTTP requests.

It seems we can't get NSURLSessionConfiguration before creating the session.

Try something like this:
NSURLSessionConfiguration *config = [NSURLSessionConfiguration defaultSessionConfiguration];
		[MMBarricade enableForSessionConfiguration:config];
AFHTTPSessionManager *manager = [[AFHTTPSessionManager alloc] initWithBaseURL:[NSURL URLWithString:@"http://www.baseurl.com"]
																 sessionConfiguration:config];

What @jcgsxr describes should be right on. @zhugexiaobo feel free to let me know if you're still having trouble, but I think that should get you in the right direction.

Yes, it works. Thanks for both of you. I forgot to close this issue.


Use resource instead of time for numba

As suggested in PR #8 , use resource to time numba for the best comparison with pyccel/pythran

@aholmes After this PR and PR #8 I have updated the figures in the article. Do you know if I need to ask the editorial bot to regenerate the pdf on https://github.com/openjournals/joss-reviews/issues/4991 ?

@aholmes After this PR and PR #8 I have updated the figures in the article. Do you know if I need to ask the editorial bot to regenerate the pdf on openjournals/joss-reviews#4991 ?

I'm not certain, but I went ahead and left a comment for it to do so. Can't hurt!


Use Sets in sum-of-multiples?

I just had this little discussion.
@enricospataro may have a point here?! Shall we change the test suite?

Hmmm, he has a point. The readme states: "Write a program that can find the sum of the multiples of a given set of numbers." Perhaps this might be a good exercise to get users to practice with sets? We could then add a hints file to help ease them into using sets.

I had a quick look, in the Haskell track they also use lists. So this might be something bigger.
@ErikSchierboom But yes, we could change our test suite and add the hints.

Well, the Haskell track uses lists for almost everything :)

@ErikSchierboom True, and that may be because only lists are directly supported in Prelude. :)

It also doesn't make sense to find multiples of duplicate numbers, so I think that Set is the right choice

I think we should change the test suite to use a Set.. It is right there in
the Readme - "Write a program that can find the sum of the multiples of a
given set of numbers."
On Wed, Dec 7, 2016 at 4:51 AM enricospataro<EMAIL_ADDRESS>wrote:

It also doesn't make sense to find multiples of duplicate numbers, so I
think that Set is the right choice
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/exercism/xscala/issues/230#issuecomment-265428223,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABeHG92l_JAgH_e8rYFl2gLzncXHlvNWks5rFp3FgaJpZM4LGO5C
.


Archive unused OCP overview pages

Archive unused OpenShift overview pages for infrastructure, supplementary, and usage.
https://issues.redhat.com/browse/COST-1838

Codecov Report

Merging #2210 (a8956f4) into master (f22e676) will increase coverage by 0.42%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2210      +/-   ##
==========================================
+ Coverage   71.04%   71.47%   +0.42%
==========================================
  Files         405      387      -18
  Lines        7453     7169     -284
  Branches     1615     1572      -43
==========================================
- Hits         5295     5124     -171
+ Misses       2123     2013     -110
+ Partials       35       32       -3

Impacted Files
Coverage Δ

src/store/rootReducer.ts
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f22e676...a8956f4. Read the comment docs.


Prototype Inviting other user

This PR aims to add inviting other users support for koji apps.

related commits:
https://github.com/lolimay/Button-War-rocketchat-demo/commit/5d173f1fe9422ba8827536808ccf0c090852171c
https://github.com/lolimay/Button-War-rocketchat-demo/commit/b12b7a4c974df6f9e42cc415ccf50222f34f22be
https://github.com/lolimay/Button-War-rocketchat-demo/commit/e661a14f2d2d9b422892028c221ae3d04a3d9e52
https://github.com/lolimay/Button-War-rocketchat-demo/commit/a54f58c0064e8dab17da533bf299040cb9c2dd5f
https://github.com/lolimay/Button-War-rocketchat-demo/commit/a6bd9fbc737f77b981435371d4653d48ae803995
https://github.com/lolimay/Button-War-rocketchat-demo/commit/8ee898188264bad05c2cc3b2a083bfacd04afc48


About the solder bridge SB10.

A disclaimer on 06-hello-world says that "you'll have to solder the solder bridge SB10" to get to print anything with the printing macro for the itmdump.
It needs to be noted in the disclaimer that you don't have to solder anything at all. That you can just literally plug the last pin of the SWD (CN3? idk..) into PB3 with some extra wires.
The solder bridge SB10 is just a more permanent option, it's not "required".

Thanks for the heads up. I have added an alternative to that section.


Document the output format

Probably be worthwhile to include an example of the yaml output in the index.md and README.md

Yes that format is correct... http://pyyaml.org/wiki/PyYAMLDocumentation#Dictionarieswithoutnestedcollectionsarenotdumpedcorrectly
Although it's likely that default_flow_style=False would be a nicer default. (Tho if that change does get made then let's make sure to highlight it as a difference when we release 3.1, and ensure it's easy enough to change by subclassing YAMLRenderer)

@tomchristie yeah I'm setting default_flow_style=False to be the default behavior for the renderer.

@tomchristie how about adding default_flow_style as a property on YAMLRenderer so if someone wanted the old behavior they'd just do:
class UglyYAMLRenderer(YAMLRenderer):
    default_flow_style = True

Yup that'd be fine. We can then document that in the 'use django-rest-framework-yaml now section of the 3.1 release notes.

Great! Although note the build failures due to the style change.

@tomchristie already took care of those, updated docs, and release v1.0.2

Rockin'


Update improve-existing-docs.yaml

Why:
Closes: #30408

What's being changed (if available, include any code snippets, screenshots, or gifs):
Fixed broken "Code of Conduct" link on line 21 of ISSUE_TEMPLATE/improve-existing-docs.yaml

Check off the following:

[X] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

[X] For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[X] For content changes, I have completed the self-review checklist.

Ah ok. Thanks Melanie! 🙏
FWIW the updated issue template link works 🎉


✨ Implement error-rate-based circuit breaker

Hyx is providing a circuit breaker based on the consecutive error number right now.
We need to expand that and provide a circuit breaker based on rolling window stats (e.g. percentage of failed requests).
Let's think about providing the rolling window stats as a separate low-level component, so other project could use it to implement very custom rate limiters or similar things.
References:

https://github.com/App-vNext/Polly/wiki/Advanced-Circuit-Breaker

@roma-glushko do you know when you plan to add this feature? We are currently evaluating which resilience framework to use for python and I came across hyx. I wanted to check with you if there is any approximate ETA on this or if the repo is actively maintained?

Hey @pratik3558 👋 This project is not abandon but it do have little time right now to keep it rolling.
Other than that, Hyx supports consecutive breakers right now.
How do you plan to use the error-rate based breakers? Curious what your use case 👀


SendMail through AAD App with Client Secret

Describe the bug
I want to send an email via graph api through Azure Active Directory App authorization. The app in aad does have all the necessary api permissions which would be needed for that request. I create an bearer token through postman which is used for authorization to send the mail. The Token is generated through https://login.microsoftonline.com//oauth2/v2.0/token and does include all api permissions. With this I want to access the Graph API https://graph.microsoft.com/v1.0/users//sendMail. However, when calling the API I get the following error: The property 'subject' does not exist on type 'Microsoft.OutlookServices.Message'. Make sure to only use property names that are defined by the type or mark the type as open type. REST APIs for this mailbox are currently in preview. You can find more information about the preview REST APIs at https://dev.outlook.com/."
If I use the token which is generated in graph explorer in my postman request it works just fine. The authorization is done through a client secret in postman.
To Reproduce
Steps to reproduce the behavior:

Open Postman
Create Environment with Client Secret to AAD
Create Bearer Token
Create GET Request to SendMail
Send Request

Expected behavior
{
"error": {
"code": "RequestBodyRead",
"message": "The property 'subject' does not exist on type 'Microsoft.OutlookServices.Message'. Make sure to only use property names that are defined by the type or mark the type as open type. REST APIs for this mailbox are currently in preview. You can find more information about the preview REST APIs at https://dev.outlook.com/.",
"innerError": {
"date": "2022-01-11T14:42:45",
"request-id": "5aa0b96c-6537-420b-94df-50ef811f90a0",
"client-request-id": "5aa0b96c-6537-420b-94df-50ef811f90a0"
}
}
}
Desktop (please complete the following information):

OS: Windows 10 Enterprise
Browser MS Edge
Version 97.0.1072.55

Hi @wd21sos ,
This is an API issue not a Graph Explorer one. I'm pinging the relevant team internally, in the meanwhile I recommend you post the question on Microsoft Q&A


Code features not used

I am not sure if we use the features S4R and S4R0
Should we remove them?
@SophieHYe  WDYT?

Hi Matias,
I would prefer to remove the features of S4R0 for a more clear structure of coming code features.

S4R0 removed in #257


Sanitize arguments

Stop passing around dictionaries of potentially hidden options to our important classes. There aren't that many options to make this necessary and it just obscures things. If many options are required add a frozen dataclass for description purposes.

#213 and #215 addressed these for some core components (walkers, propagator)
#201 addressed this for trial.


ELEMENT: Accordion using Bootstrap

Create a react component for Accordion using Bootstrap.
Note: Commit only single file as per structure mentioned in readme
Information

Element Type: Accordion using Bootstrap
Framework:

[x] Bootstrap
[ ] Tailwind
[ ] None
[ ] Other (Specify)

Hey @iam-abbas please assign this to me

@PranavTrip assigned!

@PranavTrip assigned!

I just need to create an Accordion Component using React and Bootstrap. Right?

@PranavTrip assigned!

I just need to create an Accordion Component using React and Bootstrap. Right?

Yes! and commit single js file (of accordion) to Accordion/Bootstrap/<Custom Name>.js. An example for  is "SimpleAccordion.js"


Processonelog corrected

Catch up with recent cleanups and additions to processonelog.sh.

I will keep guessing what the UI wants.


Update the man page

It seems that the man page is missing some info.
It would also be the best place for infos like thoses asked in #180

It seems that the man page is missing some info.

Yes, it's often out of sync as we forget to update it.

It would also be the best place for infos like thoses asked in #180

Agreed.

I am working on it.


Sound does not play in background on iOS 11

expected: with Required background modes set to
App plays audio or streams audio/video using AirPlay
App downloads content from the network
and the following in the code:
Sound.setActive(true)
Sound.enableInSilenceMode(true)
Sound.setCategory('Playback', true)

const sound = new Sound('https://s3.amazonaws.com/data.monstercat.com/blobs/21e6e0336ac16963b063b0ccba5797e1a44fcdf4', undefined, error => {
  if (error) {
    console.log('error loading sound', error)
    return
  }
  sound.play(() => { })
})

When playing sound, and sending the app to the background, the audio should still play.
I've created a minimal setup which reproduces the issue:
https://github.com/joshbalfour/rn-sound-issue

Hi, I have same issue. Did someone found a solution ?

Dealing with the same thing here.

I haven't found anything that works, so I unfortunately had to roll my own. This does background music playing and the lock screen controls but only works on iOS:
https://gist.github.com/joshbalfour/35afac16027c8745f7e6e71fabcc4226
If this gets enough attention I'll put it properly on github and npm.

Thank you for this @joshbalfour ; it still doesn't work in my simulator.
I'd read somewhere yesterday that this is probably because of some bug in simulator for iOS 11.

It's just a simulator issue, it works if you run your application on your phone.

I found a solution. The docs seem to be incomplete. You have to add the following to ios/Info.plist (just before the closing </dict>):
<key>UIBackgroundModes</key>
<array>
    <string>audio</string>
</array>

Also don't forget Sound.setCategory('Playback'). Thats enough to get it working.
After rebuilding/restarting the simulator it works fine for me.

@lgraubner Sound.setCategory('Playback', doh! Works like a charm now. Yes, that can be overlooked easily.

@lgraubner it worked like a charm.

If anyone is still seeing this issue, one reason is because iOS11 requires background audio permissions to be enabled.
@lgraubner proposed one fix for this, another way is to select your project in Xcode, enter Capabilities tab, and set background modes 'on', then toggle Audio, AirPlay and Picture in Picture.

After rebuilding the audio should work in the background.

Hey,
I was having the same issue, and I resolved it by adding the correct configuration to my Info.plist file.
However, it's now working on the simulator but not on a real device.
Has anyone encounter such a case?
Thanks in advance!

Same issue, it's now working on the simulator but not on a real device

Same issue, can’t play in silence mode and background

if it still doesn't work then try adding these lines.
UIBackgroundModes

audio
fetch
processing

in your plist file. It worked for me. Or you can check mark those in xcode background modes as well.

if it still doesn't work then try adding these lines.
audio
fetch
processing
error - Terminated due to signal 9
song stop after 30 second

still not working, do we need to add any native code in react-native project too ???


Collapsible doesn't show contained table view form on first load (need refresh)

On first load it doesn't show the form.  We need to refresh manually using browser for it to appear.
Tested on Servoy Version 8.2.3
Attached a sample solution
collapseTest.zip

Fixed, see https://support.servoy.com/browse/SVY-12303


Does this plugin support Team Google Drives?

I am trying to integrate a team google drive instead of the default user google drive and it's not reading the files for the team drive.

I don't know how it works but maybe you can change the default scope:
scope: [
    "https://www.googleapis.com/auth/documents.readonly",
    "https://www.googleapis.com/auth/drive.metadata.readonly",
  ],

@xuopled,
I just enabled team drives by editing your repo by adding these two lines in bold to drive.files.list call.
drive.files.list({         **includeTeamDriveItems: true,         supportsAllDrives: true,**         q: '${folderId}' in parents and (mimeType='${MIME_TYPE_FOLDER}' or mimeType='${MIME_TYPE_DOCUMENT}') and trashed = false,         fields: files(id, mimeType, name, description${fields ? , ${fields.join(", ")} : ""})       }
Do you think that is something you can add to this or should I just fork your repo?

Thank you for your PR. I just merged it and published v1.8.0


Amplify Deployment Failing

Describe the bug
Amplify failing to build master (frontend).
The logs on the frontend build step appear to be as expected (nothing unusual). It just stops at some point often after "Compiled with warnings" or slightly after that, at which point building the react app is effectively completed.
To Reproduce
Trigger a deploy of master (either via merge code, or webhook, both are failing).
Expected behavior
App should continue deployment process as expected.
Additional context
d3sfwvga9bf72i (failing similarly for our other apps as well)
us-east-1
Something odd is the pr preview branches seem to build fine, then once merged, they fail.

After a few hours of failed builds, I've had one go through successfully on an adjacent app. Attempting another rebuild here in case there was some strange intermittent issue.

We are running into the same issue. We have 2 CI builds - one FE only and one FE and BE. The FE only succeeds while the FE and BE build fails while building the FE. Makes no sense since the FE build is identical for both.

@blairtaylor You could try removing the cache section from the frontend app's config where it is failing. It seemed to unblock us, at least to get deployed yesterday.

@benmkramer Commenting the cache section does seem to work. Since the change our CI builds have been worked.
Just FYI:

this was on a dev branch not a master branch
after the CI build failed, I was able to trigger a build through the Amplify console which was successful even with the cache section enabled

I can say that I had this same issue. Builds for me were failing after about 7.5 minutes, I'd have to redeploy about 5 times to get it to go through successfully after building for 15 minutes. I removed the cache and I now get successes after 7 minutes.

We have deployed some changes to how we do caching:

We limit the folder depth of the cache in case you accidentally have recursive symlinks leading to OOM errors during caching
We automatically omit node_modules/.cache to prevent intermediate files from bloating your cache size
We don't download old cache artifacts if you previously had a cache section in your buildspec but removed it

If I had to guess, your issue may have been related to fix 1.  Without app ids, I can't confirm.  Please reopen with app ids if you are still seeing this behavior.


Trait owner.target-annotations is not propagated to K8S Services

When using the Owner Trait to propagate annotations to the owned resources, such annotations are not propagated to the Kubernetes Services.
# camel-k: language=yaml
# camel-k: trait=owner.enabled=true
# camel-k: trait=owner.target-annotations=[example]

The deployment shows the annotation but the service doesn't.
Is this the expected behaviour?

fyi @squakez

It seems the Service is annotated correctly. I've just tested with an example as:
import org.apache.camel.builder.RouteBuilder;

public class PlatformHttpServer extends RouteBuilder {
  @Override
  public void configure() throws Exception {
    from("platform-http:/hello?httpMethodRestrict=GET").setBody(simple("Hello ${header.name}"));
  }
}
...
$ kamel run PlatformHttpServer.java --annotation test=my-test -t owner.target-annotations=test --dev
...
$ k get svc platform-http-server -o yaml
apiVersion: v1
kind: Service
metadata:
  annotations:
    test: my-test
  creationTimestamp: "2022-07-27T13:28:29Z"
  labels:
    camel.apache.org/generation: "1"
    camel.apache.org/integration: platform-http-server
    camel.apache.org/service.type: user
...

@squakez it seems I didn't define the integration resource properly. Yes it is working, sorry for the false alarm :sweat_smile:

Here is an example of the CRD definition, for reference
apiVersion: camel.apache.org/v1
kind: Integration
metadata:
  name: auth-hello-world
  annotations:
    test: my-test
    other: other-test
spec:
...
  traits:
    owner:
      configuration:
        enabled: true
        targetAnnotations:
        - test
        - other


Possible to make generated Java code package-private?

Hi,
I might be doing this wrong, but I'm writing an Android library which uses djinni and I'd like to keep the generated code out of my library's public API. As far as I can tell, the only way to do this would be to have the djinni --java-package be the same package as my library and then remove the public access modifier from the djinni generated sources. There doesn't seem to be a way yet to do this automatically.
I have a feeling I'm approaching this the wrong way. Is there a better way to achieve this?

There's no existing feature for this.  The approach you suggest would work, and it wouldn't be too difficult to add a Djinni command-line argument to specify the visibility of generated Java classes (but it would take changes to the Djinni implementation, obviously).
Another approach I've taken to similar problems in the past (in pre-Djinni days) was to use class-file modifier to change visibility as a post-build step.


Migrate from CircleCI

We plan to move off the CircleCI system.
We can use GitHub actions for a lot of things.
If we need more than that, we can move onto the Apache Software Foundation's Jenkins instance. Our rationale for using that is that a couple of the current maintainers (@Poundex and @jonnybot0) have some background with Jenkins, which also has a nice Groovy DSL for jobs.
The Apache Guide on Jenkins says we'll need access from the PMC. It looks like I can currently login to Jenkins and even create objects in the Groovy section.
Will look at replicating many of the build steps in Circle CI to GitHub actions first, as that's the least friction

Did a basic PoC git GitHub actions to run the check job, which seemed to work okay. https://github.com/apache/groovy-geb/actions/runs/12188231782
I had a go at using Reusable actions for much of the rest, but I don't think I've quite got it right. See:

Failed run: https://github.com/apache/groovy-geb/actions/runs/12188668188
Source: https://github.com/apache/groovy-geb/tree/refs/heads/task/213-github-actions-for-ci
Docs: https://docs.github.com/en/actions/sharing-automations/avoiding-duplication

I'll need to dig into things a bit more later. Leaving this note here for future me to pick up where I left off.

The publishing of snapshots is now handled by this Jenkins build (may require asf login):
https://ci-builds.apache.org/job/Groovy/job/Geb%20snapshot%20build/

Snapshot artifacts are published here:
https://repository.apache.org/content/repositories/snapshots/org/apache/groovy/geb/

Note: I moved a couple of PRs fairly quickly, so some of this may change once the dust settles and folks have a chance to review.

Hey, Paul. I actually appreciate you moving some of this quickly. Wrapping up for the end of year left me with relatively little time for review, but I'm going to be doing some catch-up today. If there's any feedback that I can quickly action, I'll probably just raise a PR. If it needs more discussion, I may raise a post or comment here as appropriate.

So, running check pretty well covers everything that was in the manual and check steps. That step is definitely taking a lot longer, so it may be needful to break it up into distinct steps as it was in CircleCI... gonna need to do a little more analysis before I shoot from the hip next time. :/


create custom skins for client

please create the script of custom skins for the cigar's client

I'm keeping it only for the vanilla client, not for others.

Why would you need that, you can edit the code inside the main_out.js to change the skins folder..


⚠ ComboForum has degraded performance

In 6dd1876, ComboForum (https://comboforum.com) experienced degraded performance:

HTTP code: 200
Response time: 4457 ms

Resolved: ComboForum performance has improved in ec7cdc9.


feat: Saving Runtime CR to Persistent Volume

Description
To have a comparison app which will compare the Provisioner and KIM provisioning input request we need to store RuntimeCR in PersistentVolume.
Changes proposed in this pull request:

logic which saves the KIM Runtime CR object to mounted Volume

Related issue(s)
#185

@mvshao If you could please move the shoot/runtime persistence logic to this place https://github.com/kyma-project/infrastructure-manager/blob/main/internal/controller/runtime/fsm/runtime_fsm_persist_shoot.go#L40 and let @m00g3n know so he can also adapt his PR to this change.


chore: use Dependabot to update GitHub Actions deps

Set to monthly to reduce noise.

this change could cause us to miss a high-priority dependency vulnerability for a month

AFAIK, security-related pull requests from Dependabot will happen regardless of this change, as that's an org-level security setting. It's just there's very few GitHub Actions security advisories so we haven't seen one yet.
This change will just be for non-security updates, so I think monthly is fine for those. I'm rolling these out to repos to help handle updating deps to clear Node16 deprecation warnings - also has the added benefit that I can approve and merge the Dependabot PRs while if I make the changes myself they'll be blocked waiting for a review.


Number of passage max in the follow path task

Short Description:
The bot can now stop after a given number of laps in the FollowPath task. Once stopped, the bot will start again (login back) after a given timer.
This usage is optional.
Fixes/Resolves/Closes (please use correct syntax):

Closes #4072

If someone can explain on slack how to get rid the commits which have already been merged so they are not displayed here... (the  de09ba6 is not relevant here).

+1 for updating docs :)

Looks good to merge :)


Make "connect" button blue and change the copy a bit

closes #389
There's 1 case when we have 2 buttons primary on a page, but it's doing the same thing, so I guess it's ok.

Connect and Connect wallet buttons are now blue
Change the copy "Watch One" -> "Wach address" since the "one" we're referring to makes no sense, one what, wallet?
"Connect extension" to "Connect wallet" to be future proof if we want to use WalletConnect or anything else

I used this opportunity to refactor the Home that was having a lot of duplicate code. This means please check that the correct messages  are displayed when they should (BTW let's make a test for this, edit: https://github.com/ChainSafe/Multix/issues/412)

Multix welcome message when brand new landing
No account found when clicking on connect without an extension
No multisig found when an account is shared in the extension but there's no msig and watched address is empty

Submission checklist:
Layout

[x] Change inspected in the desktop web ui
[x] Change inspected in the mobile web ui

Compatibility

[x] Functionality of change validated with a connected account with multisig
[x] Applicable elements hidden / disabled for watched multisigs / pure

Left one little suggestion for consistency but other than that looks great.
The appropriate message is displayed for all of the scenarios listed.


Pipeline never completes, timeout doesn't kick

Component
server
Describe the bug
We have jobs that have been running for over 16h and are still considered in progress, like this:
https://woodie.osgeo.org/repos/30/pipeline/777
The timeout is set to 180 minutes (3 hours)
System Info
source	"https://github.com/woodpecker-ci/woodpecker"
version	"1.0.1"

Additional context
No response
Validations

[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
[X] Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.

We found that the problem was a non-silent infinite loop. Is the woodpecker timeout only effective during silent periods ?
https://trac.osgeo.org/postgis/ticket/5473


Eliminate unreachable code server/client-side

I wish that code that is only meant to be executed on the server will not be shipped out to the client and vice versa. I have this function that will be executed both on the server and client and I need to check if it's executed on the client because of preloaded redux state.
function makeStore() {
	const storeOptions = { reducer: rootReducer };

	if (typeof window !== "undefined") {
		const preloadedState = window.__PRELOADED_STATE__;
		delete window.__PRELOADED_STATE__;
		storeOptions.preloadedState = preloadedState;
	}

	const store = configureStore(storeOptions);
	return store;
}

As of Razzle 3.1.6 the if statement block is bundled in the server bundle despite it won't be executed. The same goes for when the condition looks like this: typeof window !== "undefined" - it's bundled in the client as well.
This is can be achieved with https://www.npmjs.com/package/babel-plugin-transform-define
Next.js implemented it like this: https://github.com/vercel/next.js/pull/8355 and tests: https://github.com/vercel/next.js/pull/8361
It can be put in the docs for explanation.

This will be fixed with the new babel configuration in razzle 4.0

fixed in dev

That's awesome. Hoping to see it in the documentation.
I checked the https://github.com/jaredpalmer/razzle/blob/next/packages/babel-preset-razzle/razzle-four-preset.js but I couldn't find anything about the subject. Am I looking in the wrong place?

https://github.com/jaredpalmer/razzle/blob/next/packages/razzle/config/babel/razzle-babel-loader.js#L194


⚠ Bofrost.at has degraded performance

In 07289e6, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2353 ms

Resolved: Bofrost.at performance has improved in 4caccb1 after 13 minutes.


Appstudio update test-component-pac-ecck

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-ecck-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
12 seconds
clone-repository

✅ Succeeded
20 seconds
build-container

✅ Succeeded
7 seconds
deprecated-base-image-check

✅ Succeeded
7 seconds
sanity-inspect-image

✅ Succeeded
32 seconds
clamav-scan

✅ Succeeded
9 seconds
clair-scan

✅ Succeeded
19 seconds
sbom-json-check

✅ Succeeded
7 seconds
sanity-optional-label-check

✅ Succeeded
7 seconds
sanity-label-check

✅ Succeeded
7 seconds
show-summary

Pipelines as Code CI/test-component-pac-ecck-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
12 seconds
clone-repository

✅ Succeeded
20 seconds
build-container

✅ Succeeded
7 seconds
sanity-inspect-image

✅ Succeeded
7 seconds
deprecated-base-image-check

✅ Succeeded
9 seconds
clair-scan

✅ Succeeded
32 seconds
clamav-scan

✅ Succeeded
19 seconds
sbom-json-check

✅ Succeeded
7 seconds
sanity-label-check

✅ Succeeded
7 seconds
sanity-optional-label-check

✅ Succeeded
7 seconds
show-summary


globus_auth only recognizes groups associated with the user's primary identity

@hongsudt this is something we want reviewed ASAP so I'll set it to current milestone...

All the groups associated with all my identities are now displayed in the attributes list!


README

#README
##User Story
As a boot camp student,
I want the prework notes to be structured on a webpage,
So that I can easily find and read the information.
##Acceptance Criteria
GIVEN the prework project repository,
WHEN I view the README for the repository,
THEN I can see a professional README that provides information on the project and how to use it

I have completed all acceptance criteria for the prework README


FXGLDialog in FS mode causes FS to toggle for a few frames

This may or may not be a JavaFX bug, needs some investigation

since 0.2.1 we are using MDI windows for dialogs which do not cause this behavior as they are not native windows


Add Codecov Integration and Configuration

This PR introduces Codecov integration to our CI/CD pipeline, enhancing our ability to track and visualize code coverage across the project. It also adds a custom Codecov configuration to tailor the tool's behavior to our project's needs.

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


using a fine-tuned model for prediction on unlabeled data

Hi,
Thanks for creating these helpers and finetuning tutorials. I've found this repo to be very helpful and appreciate all the work you've put into it :).
One question I have is in regards to the following validation function from your gpt2-finetune-classification notebook. Here is the code snippet:
    # speeding up validation
    with torch.no_grad():
        # Forward pass, calculate logit predictions.
        # This will return the logits rather than the loss because we have
        # not provided labels.
        # token_type_ids is the same as the "segment ids", which
        # differentiates sentence 1 and 2 in 2-sentence tasks.
        # The documentation for this `model` function is here:
        # https://huggingface.co/transformers/v2.2.0/model_doc/bert.html#transformers.BertForSequenceClassification
        outputs = model(**batch)

        # The call to `model` always returns a tuple, so we need to pull the
        # loss value out of the tuple along with the logits. We will use logits
        # later to to calculate training accuracy.
        loss, logits = outputs[:2]

        # Move logits and labels to CPU
        logits = logits.detach().cpu().numpy()

        # Accumulate the training loss over all of the batches so that we can
        # calculate the average loss at the end. `loss` is a Tensor containing a
        # single value; the `.item()` function just returns the Python value
        # from the tensor.
        total_loss += loss.item()

        # get predicitons to list
        predict_content = logits.argmax(axis=-1).flatten().tolist()

        # update list
        predictions_labels += predict_content

I'm trying to repurpose this to predict on unlabeled data. Although the comments in the code suggest that we have not provided the labels, I am getting errors when feeding in a dictionary with one extra other category (indicating that no class has been assigned):
-> 2264         ret = torch._C._nn.nll_loss(input, target, weight, _Reduction.get_enum(reduction), ignore_index)
   2265     elif dim == 4:
   2266         ret = torch._C._nn.nll_loss2d(input, target, weight, _Reduction.get_enum(reduction), ignore_index)
IndexError: Target 13 is out of bounds.

Is there a good way to change this to exclude the labels and label dictionary from being fed into the model, and also to exclude the loss from being calculated? Sorry if there is an obvious solution, it seems to be evading me right now.
Thank you for the help!

Yes this helps a lot! Thank you for the detailed answer!


Can't Get This to Build

I downloaded VS2015 and finally got ffmpeg built, but I can't get ffmpeginterop to build in vs2015 or vs2017.

1>------ Build started: Project: FFmpegInterop, Configuration: Debug x64 ------
1>pch.cpp
1>FFmpegInteropLogging.cpp
1>FFmpegInteropMSS.cpp
1>FFmpegReader.cpp
1>H264AVCSampleProvider.cpp
1>H264SampleProvider.cpp
1>MediaSampleProvider.cpp
1>c:\users\seano\desktop\ffmpeginterop-lukasf-alpha-support\ffmpeginterop\source\ffmpeginteropmss.cpp(68): error C4996: 'av_lockmgr_register': was declared deprecated
1>c:\users\seano\desktop\ffmpeginterop-lukasf-alpha-support\ffmpeg\build\windows10\x64\include\libavcodec\avcodec.h(5973): note: see declaration of 'av_lockmgr_register'
1>UncompressedAudioSampleProvider.cpp
1>UncompressedSampleProvider.cpp
1>UncompressedVideoSampleProvider.cpp
1>c:\users\seano\desktop\ffmpeginterop-lukasf-alpha-support\ffmpeginterop\source\uncompressedvideosampleprovider.cpp(112): error C4996: 'av_frame_get_best_effort_timestamp': was declared deprecated
1>c:\users\seano\desktop\ffmpeginterop-lukasf-alpha-support\ffmpeg\build\windows10\x64\include\libavutil\frame.h(587): note: see declaration of 'av_frame_get_best_effort_timestamp'
1>Done building project "FFmpegInterop.vcxproj" -- FAILED.
2>------ Build started: Project: MediaPlayerCPP, Configuration: Debug x64 ------
3>------ Build started: Project: MediaPlayerCS, Configuration: Debug x64 ------
4>------ Build started: Project: MediaPlayerJS, Configuration: Debug x64 ------
5>------ Build started: Project: UnitTest, Configuration: Debug x64 ------
5>CSC : error CS0006: Metadata file 'C:\Users\seano\Desktop\FFmpegInterop-lukasf-alpha-support\x64\Debug\FFmpegInterop\FFmpegInterop.winmd' could not be found
4>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin\Microsoft.Common.CurrentVersion.targets(4277,5): error MSB3030: Could not copy the file "C:\Users\seano\Desktop\FFmpegInterop-lukasf-alpha-support\x64\Debug\FFmpegInterop\FFmpegInterop.winmd" because it was not found.
4>Done building project "MediaPlayerJS.jsproj" -- FAILED.
3>CSC : error CS0006: Metadata file 'C:\Users\seano\Desktop\FFmpegInterop-lukasf-alpha-support\x64\Debug\FFmpegInterop\FFmpegInterop.winmd' could not be found
2>pch.cpp
2>c:\users\seano\desktop\ffmpeginterop-lukasf-alpha-support\samples\sampleswin10\mediaplayercpp\pch.cpp : fatal error C1192: #using failed on 'C:\Users\seano\Desktop\FFmpegInterop-lukasf-alpha-support\x64\Debug\FFmpegInterop\FFmpegInterop.winmd'
2>        'The system cannot find the file specified.'
2>Done building project "MediaPlayerCPP.vcxproj" -- FAILED.
========== Build: 0 succeeded, 5 failed, 0 up-to-date, 0 skipped ==========

I'm trying to build lukasf's alpha channel branch but I had the same errors when I tried the master branch. Prior to this I was just using the Nuget package.

It looks like you are using a different ffmpeg version than the one that comes with FFmpegInterop. Did you update ffmpeg or use a build from a different branch? The ffmpeg version we currently use does not have a deprecation on av_lockmgr_register.

If you want to use your custom ffmpeg build, you can add "4996" to the disabled warnings in the project's C++ compiler settings.

I just used the latest FFmpeg master branch, the instructions on the FFmpeg Interop readme.md says to download the source from the FFmpeg repository.  I didn’t realize FFmpeg Interop came with its own specific FFmpeg source as I was just following those instructions.  Thanks.

That fixed it, thanks again.

We do not use the latest sources because these may have bugs. We usually bump up the version every 6 months or so.


Initial return ipam custom lookups

Fixes:  #982 partial #130
Looking to provide custom lookups again for VarbinaryField. Before I went too far, I thought I would see if this would be an acceptable solution. This only includes a postgres version currently, it should be somewhat trivial to add to MySQL as well.
Demonstrating this in action
>>> Prefix.objects.filter(network__net_contains='<IP_ADDRESS>/24')
<PrefixQuerySet [<Prefix: <IP_ADDRESS>/24>]>
>>> Prefix.objects.filter(network__net_contains='<IP_ADDRESS>/16')
<PrefixQuerySet [<Prefix: <IP_ADDRESS>/24>]>
>>> Prefix.objects.filter(network__net_contains='<IP_ADDRESS>/17')
<PrefixQuerySet []>

Looking at the NetBox which seems to take patterns from https://github.com/jimfunk/django-postgresql-netfields, I think I can reproduce most of the functionality
'net_contains_or_equals'   | Good
'net_contains'             | Good
'net_contained'            | Good
'net_contained_or_equal'   | Good
'net_host'                 | Unclear?
'net_in'                   | Good
'net_host_contained'       | Good
'net_mask_length'          | Good
'host'                     | Not sure what it does?
'inet'                     | Not sure what it does?

This should be ready for review, will update docs as well, only places I see is:

nautobot/docs/rest-api/filtering.md
nautobot/docs/installation/migrating-from-netbox.md

Any other places I should consider updating docs?

Documentation provided, should be good to go.

tests are good, black is not, pending core update to black before updates work

This came up with an additional project in the last 24 hours.

We'll revisit this after 1.2.0b1 is released.

Everything should be good to go now.

Everything should be good to go now.

Accidentally merged into next; double-committed into develop as dd08dee5dfb56af899e23923f40f8d2953fc8ffe


Git ads

          1 Error

:no_entry_sign:
Please provide a summary in the Pull Request description

          2 Warnings

:warning:
Please rebase to get rid of the merge commits in this Pull Request

:warning:
Found 1 link issue, a project collaborator will take care of these, thanks :)

Link issue by awesome_bot

Line
Status
Link

4201
503
https://www.qownnotes.org/

  Generated by :no_entry_sign: Danger


Ghidraton not displayed in window tab

I installed Ghidraton and all the dependencies.
I followed the instalation guidelines.
Ghidraton is in the extension folder of Ghidra but Ghidraton is not displayed in thw window tab.
There is no error in the log file but no information on Ghidraton either.
Any advice on how I can fix this ?
System information:
OS: Arch Linux x86_64
Kernel version: 6.7.3-arch-1
Jep version: 4.2.0
Java: java-17-openjdk, version 17.0.10
Ghidraton: 4.0.0
Python: 3.11.6
Ghidra: 11.0.1

Hi @Voxanimus thank you for reaching out! Ghidra should prompt you to configure the extension but sometimes it does not. You can manually configure the Ghidrathon extension from Ghidra's CodeBrowser window by navigating to File > Configure, selecting Configure under Ghidra Core, and selecting the checkbox next to GhidrathonPlugin (you can use the Filter box to search for GhidrathonPlugin). Ghidrathon will be listed under the CodeBrowser's Window tab after selecting Ok.
If you don't find GhidrathonPlugin listed under Ghidra Core then double-check that you have unzipped the Ghidrathon extension (.zip) to the directory <absolute_path_to_ghidra_install_dir>\Ghidra\Extensions. The Ghidrathon extension is the .zip included in the release .zip.

Hi @Voxanimus - were my suggestions able to solve this issue for you?

No problem, thank you for responding. I'll close this for now - please reopen if have a change to try and continue to experience problems.

I also had this problem, but didn't find any reference to what was going on. I found people describing error messages, but I wasn't sure where I should find them. Since I had none, I wasn't seeing anything.
I only found this issue accidentally by searching for what the installation path should be. Therefore, I suggest someone to add this to the README. For me, it seems to have worked.


misc: refactored named types of withCallState

This is a suggestion for an easier mapping of the state and signal types to the named (collection) types.
If you're ok with this I can take a look at the other mappings.
I've also reordered them so that the dependent type comes first.

Hi Lars, thanks for the PR. We are more than just OK, if you find look for improvements.

Thanks Lars!


Readme update

This install: pip install -U --extra-index-url https://pypi.ngc.nvidia.com triton-model-navigator[<extras,>]
breaks pips parser.
This works instead:
pip install -U --extra-index-url https://pypi.ngc.nvidia.com triton-model-navigator[extras]

Hi @esnvidia!
The command you are mentioning is just an example how to use extras during pip installation.
We may need to enhance the instruction to be more clear. To give an example the following installation commands could be used based on model framework:

PyTorch

pip install -U --extra-index-url https://pypi.ngc.nvidia.com triton-model-navigator

TensorFlow

pip install -U --extra-index-url https://pypi.ngc.nvidia.com triton-model-navigator[tensorflow]

JAX

pip install -U --extra-index-url https://pypi.ngc.nvidia.com triton-model-navigator[jax]

Let us know if this explain reported problem. Thanks!

This is great feedback! Thanks for pointing that @esnvidia.

The docs have been improved. Now the installation is described as mentioned above in the issue.


ETL-35 Create a default IAM role applicable to any user

I am sorry guys, this PR is a WIP and I didn't want to post it here. I was trying to publish it at my fork.


[FIX] The get started page doesn't show all the options properly

The get started page is not showing all the options on the screen

The Advance Modules should be shown properly inside the screen

Hey @dakshsinghrathore can you assign me this issue under SWOC'2024

Hey @dakshsinghrathore can you review my PR and Merge it

Hey @dakshsinghrathore  did you close this? Was it correct? Will you merge it?


Android unit tests

My first attempt on getting the unit tests was far too complex.
With this PR I take a much simpler route: running the unit tests on the command-line. I have bumped the required version of CMake (2.6.3 is required by the Android toolchain). Moreover, I have added PEGTL_PLATFORM as a shortcut of setting everything but it is possible to override settings on the command-line. The default settings assume that you are using an x86 based Android device (aka emulator - commonly used by Android developers).
Building and running unit tests for an Android can be done by:
cmake -DANDROID_NDK=/path/to/android-ndk -DPEGTL_PLATFORM=Android
make
make test

(if you have an Android device, adding -DANDROID_ABI=armeabi-v7a is useful)
During testing it is required that the device is connected (an emulator is always connected). The script run-on-android.sh assumes that only one device is connected.
I have tested it on an Android device (OnePlus One) and emulator using Android NDK r10e and r13b.
Unfortunately, Travis CI doesn't support Android NDK (https://github.com/travis-ci/travis-ci/issues/5395) so we might find another way to run the tests in an automated way.

I like this direction, even though requiring CMake 3.6.0 as a minimum does exclude quite a few systems. But we are using it more for testing purposes than as a recommended build/installation system towards the user, so it's not a problem. Currently, we use CMake on AppVeyor and on the Fedora 24 builds in Doozer.io. The AppVeyor environment has CMake 3.7.x at the moment, so this, too, is no problem. I'm not sure about Doozer.io, but that should not hold us back, in case of doubt I'd sacrifice those builds.
Now for the real issue: Automated builds for Android. If I read the travis-ci issue you linked correctly, it seems that the Android NDK is not installed by default, but you can do it manually. In https://github.com/travis-ci/travis-ci/issues/5395, the reporter links a working (manual) build and shows the "old" and his envisioned "new" way. And ultimately, the idea seems to be to speed up the build process which I don't care too much about. If it takes 2 minutes longer, so be it 😃. Could you try to replicate the manual way of installing the NDK and running the PEGTL tests with it?

@d-frey Sorry for not coming back sooner. I have not experience with Travis, and in the last week I have been busy. But I will give the manual method a shot.

Thanks Kenneth.
If you are working on your branch, feel free to nuke all other builds in the .travis.yml and just focus on the Android build. This should help you to speed things up considerably, as usually the MacOS build take quite some time before the Travis infrastructure has a free slot for them. I am positive that I'll be able to merge whatever you end up with in your .travis.yml with the existing builds.

@d-frey It tooks a few attempts.

@kneth Thanks for keeping at it!

Thanks Kenneth. I accepted the merge request and I'll now try to reunite it with the "old" .travis.yml.

Everything looks good so far, the new, combined .travis.yml is working as expected and I committed some cleanups. Quick question for our main README.md: It currently says "Android" in the bullet list in the Status section. I'd like to add some version number, but I have no clue about Android version numbers and what people usually use the refer to a version. I've seen 22 as well as r10e. What would, in your opinion, a better entry look like? "Android, Version 22"? "Android, NDK 22"?

API 22 is Android 5.1 (Lollipop), while r10e is NDK release 10e. They are not directly related. So the line might be "Android 5.1 (API 22) using NDK r10e".

I've updated the README, which leaves the question: Which is the minimal version required for the PEGTL to work? Is it possible and reasonable to find that out? Should we add multiple versions of Android and/or the NDK? If you have any insight/advice, please share it with us :)

I have built against API 9 (Android 2.3) using NDK r10e and executed tests on a HTC Desire S (Android 2.3.5) with success.

OK, thanks. I think this means that the API version is not really important for the PEGTL as we are not using much from the system, we only need good-enought C++11 support and that depends on the NDK? Any idea if earlier NDKs work or if they are still relevant?

As I recall, gcc 4.9 has been part of NDK through the r10 series so it is probably safe to say NDK r10 or later.

I will leave the entry as is then. Thanks again for all your work on PEGTL+Android! 👍


Orthanc should wait for series to complete before serving.

During the C-MOVE or C-STORE event, the image objects may come in one slice at a time, and if a workstation queries for that series while it is uploading, currently the workstation is able to see it and retrieve it. The retrieval itself will not fail, but the workstation will be missing slices and might show errors, or display things incorrectly.
It would therefore be necessary for orthanc not to show the series as part of a query until it has been completely uploaded and is ready.

According to chat-gpt this is not possible. I have not found information on how to do this yet.


Datapack does not work when dying in another dimension on Minecraft server

I run a paper server which I added the datapack to and it works amazing in the overworld but in the nether it doesn’t save your items and your items fly everywhere

Yea, this is known and a problem with paper. See #13
You may be able to fix it by running gamerule keepInventory true in both the end and the nether (and all other dimensions)

Wait but wouldn’t running keep inventory just make the datapack obsolete

No, the data pack uses "keepInventory" on by default and does the "losing items and xp" itself, it's the only good way to achieve this using a data pack

Ok, thanks but I think I’m just going to switch servers from paper to fabric so that it works and I can run some performance enhancing mods on it too


Speed up releae

This is going to take a few iterations, Github needs the worklows in master before I can iterate on them in a branch. So, here we go.


added polygonAmoy to sourcify and etherscan plugin

this allows for using polygon amoy with the cli using either etherscan or sourcify as a plugin

Wasn't able to push. Closing in favor of https://github.com/wevm/wagmi/pull/4399


Mixing back slashes with forward slashes, in the same path.

Sometimes, you're mixing back and foward slahes in the same path.
  File "./platform/windows\detect.py", line 109: (See in context below.)
To reproduce : The error was caused because I didn't issue the command after first calling vcvarsall.bat.
Microsoft Windows [Version 6.3.9600]
(c) 2013 Microsoft Corporation. All rights reserved.

C:\Users\Robert>cd C:\home\robert\game-engines\godot

C:\home\robert\game-engines\godot>C:\Python27\Scripts\scons platform=windows
scons: Reading SConscript files ...
TypeError: cannot concatenate 'str' and 'NoneType' objects:
  File "C:\home\robert\game-engines\godot\SConstruct", line 190:
    detect.configure(env)
  File "./platform/windows\detect.py", line 109:
    env.Append(CCFLAGS=['/I'+os.getenv("WindowsSdkDir")+"/Include"])

C:\home\robert\game-engines\godot>

6.3.9600 commandline terminal accepts mixed / with \ into path.
So, what is the problem ?

also, how does it come that you call :
C:\Python27\Scripts\scons p=windows

instead of just :
scons p=windows

???
isn't there a pythons path into the system env path if you type this below ?
echo %PATH%

no, scons is inside scripts and that inst in the path, I usually just copy
the .bat to c:\python27
On Fri, Jan 9, 2015 at 10:16 AM, UsernameIsAReservedWord <
<EMAIL_ADDRESS>wrote:

also, how does it come that you call :
C:\Python27\Scripts\scons p=windows
instead of just :
scons p=windows
???
isn't there a pythons path into the system env path if you type this below
?
echo %PATH%
—
Reply to this email directly or view it on GitHub
https://github.com/okamstudio/godot/issues/1158#issuecomment-69332621.

( strange ... I have C:\Python27\Scripts into my PATH .... maybe I added it manually and forgot about it ... Oh, anyway, as long as it works ... )

@UsernameIsAReservedWord

6.3.9600 commandline terminal accepts mixed / with \ into path.
So, what is the problem ?

That's a public secret.
Even in the DOS days a forward slash as path separator was allowed, in scripts only.
On the command line it was initially not allowed because a forward slash was used as switch/argument delimiter.
But there was a SWITCHAR option in config.sys to allow forward slashes (mainly for network paths) on the command line. But that turned into a big fail (or whatever) and MS removed the forward slash restriction from the command line, and replaced it with code to accept forward slashes on the command line. I believe since XP.
Anyway, the issue is in the script. Not the on command line.
Each platform has a detect.py script. So the issue is not limited to the Windows platform.
Apparently the path to the script detect.py was fed with mixed slashes.
There could be issues where the script script.py could not be found on the file system.
The back slash on Linux, etc will be treated as an Escape character.
Try "./platform/x11\detect.py" on Linux. (\d)
Also if the path is in an unquoted variable and contains one or more spaces in the file name, the forward slashes will be treated as switch/argument delimiters (Windows only issue).
@reduz Has already responded to your other question.

@RobertinoValue : oh thanks for these complementary info ! very enlighting. now I understand your point.

The initial issue description is concise and didn't need further clarification.
But under certain circumstances that's not possible.

I know github issues are not a knwoledege database, but the link you removed from your previous post was very informative too. You could have left it just in case someone else would have been interested ...

The above mentioned issue is at line 109 of platform/windows/detect.py, so there doesn't seem to be an issue reading the file, I'd assume the path is fine.


Create UI scaffolding for dogfood wallet

TODO:  criteria
TODO:  epic

Completed as part of other work.