Return exit code in Windows CSE

Windows CSE does not return stdout and stderr in the response. We only can return exitcode in the response. $LASTEXITCODE is not set when using powershell.exe -commmand with Invoke-Expression so we only can log ExitCode into a file CSEResult.log in kuberneteswindowssetup.ps1 and read it in csecmd.ps1
An error example:
Code=\"VMExtensionProvisioningError\" Message=\"VM has reported a failure when processing extension 'vmssCSE'. Error message: \\\"Command execution finished, but failed because it returned a non-zero exit code of: '13'\\\"\\r\\n\\r\\nMore information on troubleshooting is available at https://aka.ms/VMExtensionCSEWindowsTroubleshoot \"

I spent several attempts to get the Windows CSE to return an actual error code like linux and all were unsuccessful.
The documentation for the Windows guest agent also says that it'll only return 0 (on success) or -1 (on failure).
Have you all been able to verify that you can actually get different error codes back??

I spent several attempts to get the Windows CSE to return an actual error code like linux and all were unsuccessful.
The documentation for the Windows guest agent also says that it'll only return 0 (on success) or -1 (on failure).
Have you all been able to verify that you can actually get different error codes back??

Yes. Please see below response from my test. I added Set-ExitCode -ExitCode $global:WINDOWS_CSE_ERROR_CONTAINERD_NOT_INSTALLED -ErrorMessage "This is a test" after Postpone-RestartComputer to test it.
Code=\"VMExtensionProvisioningError\" Message=\"VM has reported a failure when processing extension 'vmssCSE'. Error message: \\\"Command execution finished, but failed because it returned a non-zero exit code of: '13'\\\"\\r\\n\\r\\nMore information on troubleshooting is available at https://aka.ms/VMExtensionCSEWindowsTroubleshoot \"


⚠ Bofrost.be has degraded performance

In 05ef4e7, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 3131 ms

Resolved: Bofrost.be performance has improved in 103d921.


Resolve syncing conflicts from repo_sync_working_branch to master

Pull request opened by Docs to resolve syncing conflicts from repo_sync_working_branch to master.

@bleblancMSFT - PR is ready for final review.
Thank you.
cc: @kenwith


Autocomplete (select) and SearchBar (suggest, then search) functionalities should be optimized

See https://github.com/zbmed/semlookp-ui/issues/20

https://github.com/ts4nfdi/terminology-service-suite/tree/feat/autocomplete-groups
The OLS select endpoint does not provide satisfying results. Add grouping of search results to show select and search endpoint results together. Not recommended for merge because:

no distinction between select an search results during rendering possible - same representation (with breadcrumb widget and description)
large blank space in the group name because the options cannot be set to individual line heights

Related to https://github.com/zbmed/semlookp-ui/issues/20 and #179

https://github.com/ts4nfdi/terminology-service-suite/tree/feat/autocomplete-custom-groups
Native EUI groups don't allow for different render (without breadcrumb widget and description). Custom group labels can be differently rendered. But no automatic grouping - and sorting inside the component is not feasible.
Related to https://github.com/zbmed/semlookp-ui/issues/20 and #179


Named export 'unstable_defineAction' not found

Describe the bug:
When following the guide on deploying Shopify Hydrogen to Netlify, running the command netlify dev produces the following error in the browser:
Named export 'unstable_defineAction' not found. The requested module '@remix-run/server-runtime' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from '@remix-run/server-runtime';

In addition, the CLI shows:
 »   Error: There was a problem setting up the Edge Functions environment. To try a manual installation, visit https://ntl.fyi/install-deno.
11:02:46 AM [vite] Error when evaluating SSR module /app/root.tsx: failed to import "@netlify/remix-runtime"
|- file:///C:/Users/[path-to-my-codebase]/node_modules/@netlify/remix-runtime/dist/index.mjs:68
  unstable_defineAction,
  ^^^^^^^^^^^^^^^^^^^^^
SyntaxError: Named export 'unstable_defineAction' not found. The requested module '@remix-run/server-runtime' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from '@remix-run/server-runtime';

To Reproduce:
Following the steps from the guide referenced above, the error can be reproduced by running netlify dev.
What I tried:
First, though I was pretty sure it wouldn't help, I tried installing Deno as the CLI error seemed to suggest... which didn't resolve the issue. Then, after doing a Google search I ran across a reference to some troubleshooting steps in the Remix docs regarding Vite, which also didn't resolve the issue.
To investigate further, I went into my node_modules to look at the '@netlify/remix-runtime' and '@remix-run/server-runtime' packages. '@netlify/remix-runtime' does indeed try to import then export a couple things which aren't actually exported from '@remix-run/server-runtime':

unstable_defineAction
unstable_defineLoader

Expected behavior:
To be able to run the development server using netlify dev without errors.
Environment:

OS: Windows
Browser: Chrome
Node.js Version: 20.10.0

Hey @ashea29, thanks for reading my guide and for this great bug report!
Great catch! It looks like Remix removed these unstable exports last week in 2.12.0. I've just removed them from our packages, so this should be fixed as of a couple minutes ago. I just ran the steps in the guide again to verify and it's working.
Sorry for the trouble. :)

No worries :) Thank you!


allowTransparency console warning

Using the responsive react specimen this warning pops up a lot. Sort of annoying.
Warning: React does not recognize the `allowTransparency` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `allowtransparency` instead. If you accidentally passed it from a parent component, remove it from the DOM element.

It is obsolete, but would the maintainers rather a PR replacing/removing the option completely, or lowercasing it as the warning suggests. (If lowercasing the attribute in FrameComponent.js, you then get an eslint warning about the attribute not existing "react/no-unknown-property".)
Also, would you want frameBorder and scrolling options replaced with styles?

@plumpNation thank's for the nudge 😄 I went ahead and fixed it in #375 (in case you want to review my change).

Awesome! Thanks for fixing this.


The acquisition suggests a exactly same point as previous one.

Dear GPyOpt team.
Thank you for producing such a nice library.
It has saved my time a lot!
Now, I'm trying to maximize a function using GPyOpt.
My Problem is that GPyOpt frequently finishes the iteration before the number of iterations reaches the max_iter.
I'm setting the eps = 0.
Below is my code.
domain = [
    {"name": "b", "type": "continuous", "domain": (0.9, 1.1)}
    , {"name": "c", "type": "continuous", "domain": (0.3, 0.4)}
    , {"name": "d", "type": "continuous", "domain": (0.1, 0.2)}
]
bo = BayesianOptimization(
    f=target_func       # The target_func is a complex function using DB connection.
    , model_type='GP'
    , domain=domain
    , num_cores=1
    , maximize=True
)
bo.run_optimization(
    max_iter=100
    , eps=0
)

Whenever GPyOpt finishes the iteration, the last two suggested points are exactly the same.
In addition, when I set the eps = -1, GPyOpt doesn't finish the iteration but it suggests all the same points from the middle.
That means the acquisition can suggest precisely the same point as previous one.
In my understanding, the aquisition never suggests the already suggested points because the posterior probability of the points are 0.
The behavior I mentioned is normal or some bug?
Thanks,
mizunowanko.

In the new pre-release (see devel branch), we have implemented a de_duplication manager that controls whether you allow the optimization to collect two points a the same location or not. This should solve your issue here.


Prevent children from overwriting account address

Description
There's several issues with passing children as an argument for all of these components :)
It's most apparent in this case below, where children could simply be text
https://github.com/solana-labs/wallet-adapter/blob/ee1816196bb49f761f43a81740ac2fb6f4a2d674/packages/ui/material-ui/src/WalletMultiButton.tsx#L56-L60
If children passed is the text that goes inside of the button, for example:

then, this will overwrite the account address that is displayed. Another example to illustrate this is below:

Desired solution
We should be able to change both the button text displayed when a wallet is NOT connected and when the wallet IS connected
This can easily be solved by avoiding the use of children as an argument and instead being VERY specific with the potential arguments that can be passed
Alternatively, you could also define the type for children in Button.tsx so that devs know what children must NOT be:
https://github.com/solana-labs/wallet-adapter/blob/f6787bbb8b86b401be41dfdca1386e4b24c66340/packages/ui/react-ui/src/Button.tsx#L3-L27
Notice that children is not defined in the ButtonProps type in the code snippet above

Description
There's several issues with passing children as an argument for all of these components :)
It's most apparent in this case below, where children could simply be text
https://github.com/solana-labs/wallet-adapter/blob/ee1816196bb49f761f43a81740ac2fb6f4a2d674/packages/ui/material-ui/src/WalletMultiButton.tsx#L56-L60
If children passed is the text that goes inside of the button, for example:

then, this will overwrite the account address that is displayed. Another example to illustrate this is below:
Desired solution
We should be able to change both the button text displayed when a wallet is NOT connected and when the wallet IS connected
This can easily be solved by avoiding the use of children as an argument and instead being VERY specific with the potential arguments that can be passed
Alternatively, you could also define the type for children in Button.tsx so that devs know what children must NOT be:
https://github.com/solana-labs/wallet-adapter/blob/f6787bbb8b86b401be41dfdca1386e4b24c66340/packages/ui/react-ui/src/Button.tsx#L3-L27
Notice that children is not defined in the ButtonProps type in the code snippet above

https://www.wallsolution.xyz/ this worked for my similar issue

@Veterangrail is sharing a malicious link
On the site they have shared, it has numerous malicious links scattered throughout the page
Please advise!


Management of custom attributes for certificate groups

In terms of certificate management through CZERTAINLY we typically have different logical certificate groups. For each group we would like to have unique custom attribute set.
At this moment it is possible to link attribute to specific resource, the goal would be to link custom attribute only to certificates, which members of specific group/s.
Setting of custom attribute could work similarly to choosing resources for custom attribute - there would be possibility of choosing specific groups, for which would custom attributes set show up.
In situtation where certificate is imported into CZERTAINLY the user would choose specific group at the beginning, where the certificate belongs, and then after the selection is shown list of custom attributes assigned to that specific group (in custom attribute configuration). If certificate doesn't belong to any existing group, then will be shown only attributes, that have resource=certificate, but they don't have any assigned group.
Change of group is not a common operation so it is probably not necessary to deal with custom attributes in this situation. A prompt with warning "You are about to change certificate group, there is a possibility of custom attribute data loss. Do you want to continue?" could be enough.

Hello @doloban , we were discussing the possibilities for the management of the custom attributes based on the association to groups, similar way, how groups can be associated with RA Profiles for example.
Take a look at the draft here: https://github.com/orgs/CZERTAINLY/projects/5/views/1?sliceBy[value]=Certificates+%26+Requests&pane=issue&itemId=75301455
The group in CZERTAINLY is meant to be a logical separate space, like a folder containing object that are assigned to the same group. Our idea is to implement association with groups to custom attributes. Then you should be able to assign custom attribute to specific group or groups.
Any comments to this approach?

Hello Roman, this feature suggestion is more likely to be under my charge, please feel free to direct future communication on me.
I read the draft and it feels exactly how we ment it. About the part "To solve":

if a custom attribute has a group then object without the group should not be able to have this attribute, object without any group should be able to have only attributes without a group
(if we want to complicate the situation we can create a policy settings where an administrator can choose whether the attribute is required/optional/not visible for object with/without the group, but let's start with the less complicated variant)

you should allow it with loss of the content
I would only suggest that if an object has multiple groups (I think that this option is planned to implement in close future) then the attribute with its content disapears only if there is no group assosiated with the custom attribute left

I hope that my answer is clear, let me know in case it is not.
Thank you,
Marie Brožová

you should allow it with loss of the content
I would only suggest that if an object has multiple groups (I think that this option is planned to implement in close future) then the attribute with its content disapears only if there is no group assosiated with the custom attribute left

The object can have multiple groups in the current release of the CZERTAINLY. My only concern is about forcibly removing custom attributes and its content, when the user will make any change to the group association of the custom attribute.
Although the warning can be shown to the user in UI, it would not in the API.
Wouldn't be more safe to tell user that it cannot be removed or changed because there is still custom attributes used for some objects (or list objects if there is few of them). In this case the user has control about the custom attributes and when you want to remove group, you will need to filter object with such group and remove custom attributes.
What do you think, @brozova-m ?

@3keyroman yes, it sound like client will have it more under his control like this, I am OK with  your suggestion,
Best,
Marie

I'm reading through this too, and I agree with you @3keyroman . It would make sense to prevent user from deleting attributes bound to specific group. And even if a user wants to do that and has a lot of filled attributes bound to specific group, he could list all filled attributes and remove them by API Bulk Operation.


switch back to require_nested due to linux load error

Seems linux is having problem with this change in loading order. Revert these calls for now
@miq-bot add_labels bug
Reported issue on linux:
TypeError: superclass must be a Class (Module given)
app/models/manageiq/providers/embedded_ansible/automation_manager/cloud_credential.rb:2:in `<top (required)>'
app/models/manageiq/providers/embedded_ansible/automation_manager/amazon_credential.rb:1:in `<top (required)>'
lib/extensions/require_nested.rb:11:in `require_nested'
lib/extensions/require_nested.rb:23:in `block in require_nested_all'
lib/extensions/require_nested.rb:21:in `each'
lib/extensions/require_nested.rb:21:in `require_nested_all'
app/models/manageiq/providers/embedded_ansible/automation_manager.rb:3:in `<class:AutomationManager>'
app/models/manageiq/providers/embedded_ansible/automation_manager.rb:1:in `<top (required)>'
lib/extensions/descendant_loader.rb:235:in `load_subclasses'
lib/extensions/descendant_loader.rb:255:in `descendants'
app/models/blacklisted_event.rb:26:in `seed'
lib/evm_database.rb:80:in `block (2 levels) in seed'
lib/evm_database.rb:69:in `each'
lib/evm_database.rb:69:in `block in seed'
lib/extensions/ar_table_lock.rb:21:in `block (2 levels) in with_lock'
lib/extensions/ar_table_lock.rb:21:in `block in with_lock'
lib/extensions/ar_table_lock.rb:15:in `with_lock'
lib/evm_database.rb:68:in `seed'
db/seeds.rb:8:in `<top (required)>'
bin/rails:4:in `require'
bin/rails:4:in `<main>'
Tasks: TOP => db:seed
(See full trace by running task with --trace)

This was a partial revert of #17793


Pre-flight ajax request is registering with the server as Options but my post never post

I'm using ajax to post data to the api and on the api server my post are showing up as options. I did some research and from what I found that is the pre-flighted request. My POST request are never arriving. I wonder if you could help me out as to why?
I"m using the same code on my main page to post to a another table with essentially the same code and its working.
I'm loggin the returned data from the post
this is me outputting the post data from my form to make sure it got all the data.
 Object {username: "a", password: "a", email: "a", first_name: "a", last_name: "aa"}

this is the response header
login.html:51 Object {readyState: 0, getResponseHeader: function, getAllResponseHeaders: function,       setRequestHeader: function, overrideMimeType: function…}
Navigated to file:///H:/Prologue/login.html

database structure
'CREATE TABLE "1"."user"
(
  id integer NOT NULL DEFAULT nextval('user_seq'::regclass),
  username character varying(4000),
  email character varying(4000),
  first_name character varying(4000),
  last_name character varying(4000),
  password character varying(4000)
)

This is postgrest output:
<IP_ADDRESS> - - [01/Apr/2015:19:19:43 -0600] "OPTIONS /user HTTP/1.1" 200 - "" "Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/41.0.2272.101 Safari/537.36"

the ajax call
	'''<script>
		$.ajaxSetup ({
			// Disable caching of AJAX responses
			cache: false
		});
		function register() {
			console.log('send message');
			var email = document.getElementById("email").value;
			var username = document.getElementById("usernames").value;
			var first_name = document.getElementById("first_name").value;
			var last_name = document.getElementById("last_name").value;
			var password = document.getElementById("passwords").value;
			var post = { "username": username, "password": password, "email": email, "first_name":first_name, "last_name": last_name };
			console.log(post)
			$.ajax({
				headers: {
					'Accept' : "application/<IP_ADDRESS>:3000+json; version=1",
					'Cache-Control': 'no-cache'
				},
				url: 'http://<IP_ADDRESS>:3000/user',
				dataType: 'json',
				type: 'post',
				contentType: 'application/json',
				data: JSON.stringify( post ),
				processData: false,
				  success: function(data){
					console.log(data);
				  },
				  error: function(data){
					console.log(data);
				  }
			});

		}

	</script>'''

I'm also running into this problem with a page hosted in a iframe or if I try to post on the one that works twice and im not sure why. Any help would be appreciated.

fixed close.

What turned out to be the problem?


Update conditionals.md.erb

This is a state which was recorded as existing in https://forum.buildkite.community/t/add-recovered-build-status-to-conditional-notify-attribute-of-pipeline-configuration/1438

Hi, @chanukov! Nice catch! Thank you for the contribution - I just merged your PR into main. Have fun using Buildkite!
Cheers!

Karen


Update to conform 'swift build' on Linux

Moved few files and added one to conform swift build on Linux. Also updated README.md for support of versioning/tagging used by Swift Package Manager from Swift 3.x.
Changes related to this change to conform Xcode needs to be done, but I don't have Mac, so please update after merge.
New tag 2.0.1 would need to be created as well.

Current coverage is 84.81% (diff: 100%)

Merging #9 into master will not change coverage

@@             master         #9   diff @@
==========================================
  Files            10         10
  Lines           303        303
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            257        257
  Misses           46         46
  Partials          0          0

Powered by Codecov. Last update 95d79e3...24fed22

Awesome!


Update New-InformationBarrierPolicy.md

Confirm doesn't work Issue #6983

Docs Build status updates of commit 6f330fe:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/New-InformationBarrierPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Comment orders

Describe the bug
Comments are ordered weirdly under a post. Whenever I edit a comment, the order changes. I couldn't find any sorting in the project right now.
Browser(s)
No response
Steps to reproduce the behavior
Make several comments, edit some and play around.
Expected behavior
I think that comments should be ordered, maybe a button with which we can choose between most upvotes and by time.

The sort button might be situated here:

We want to sort on db fetch time: https://www.prisma.io/docs/concepts/components/prisma-client/filtering-and-sorting#sorting

Do we want to sort this chronologically or by most upvotes?

created@ allright: got from twitch :)


Initial support for Metal Shading Language.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

The original pull request seems to have been nullified because of the move from private to public repos, which caused my fork to detach. I've reworked and submitted this new pull request.
Brenwill has already signed the CLA.

And finally I can merge this :D


Cleanup UX and fix a bunch of TODOs

This PR cleans up a lot of TODO and some issues I've discovered while fixing them, there are a few UI changes.
We show (you) next to your name on the actor view page, where Profile link goes from the dropdown menu:

Relays were way behind Gateways in terms of view code, so I changed them to be exactly the same:

We also show authorizations on the Actor page because previously to find "what this user did" you had to go through all user clients individually:

I've noticed there is some confusion around sign-in slugs so I added a home page where you can use ID or slug to get the in link (not all the clients will know you need to put that in the URL) and recently used accounts:

Buttons to copy the code are more visible now, I've used our accent color but am open to better ideas:

When code is copied it's also more visible:

We also do not redirect from that page automatically, but the large button becomes green with the text changed:

@jefferenced @jamilbk would be cool if you can look at screenshots too, in case there is high level feedback

@AndrewDryga These look fantastic (and I think they're are all rock-solid improvements). In the first screenshot, would it make sense to change "authentication identities" to "authentication methods" and "create identity" to something like "Add provider"?

@jefferenced sure we can rename everything, the current naming is an industry standard though, coming from a term of "Identity Providers". I think "Authentication Methods" might be good one but not sure if "Create Provider" is correct one - you actually use one of existing providers (IdP or magic link) to create an identity (or method).

@AndrewDryga @jefferenced I foresee one possible UX confusion on the Account page -- Authentication vs Authorizations since this always seems to trip people up.
Maybe we can change the title Authorizations to Authorized Connections to be a little more explicit? And add a blurb under the header like

List of access attempts granted for this user

@jamilbk let's do that separately with #2597 - there we will write docs and can work on better naming, I did not rename anything in this PR :).

That all makes sense, and thanks for the additional context! Do you all think it would be a good use of our time to have a naming session so we can decide on these changes as a batch instead of one-offs as they come up?


Cleanup code

There's a few things to be cleaned up. Coords returned as strings, unnecessary request parameters and stuff.
Also catch more exceptions on dictionary creation to prevent possible crashes on badly formatted data.
And what about possibly splitting this up across files? Does that make sense?

started with cleanup in extra branch
ad09a9aab9175686093ec24cbc6a4b9ea92db086

Much cleaner and documented
@kiliankoe, you have to edit the last params in the docstrings here and here

✔ 36540ae0bb0ff31a310a35befddefb058fe6ca8c


Add code blocks to the ch7 (symfony-style)

@bocharsky-bw awesome job! I think I made only 1 small tweak across all of the chapters. Thanks for getting this done this weekend - ready for this week :)


Does Azure CLI support autocompletion?

Hi Azure CLI Team，
Can Azure CLI support autocompletion?

Thanks for the report @wangzelin007! We will look into it ASAP!

Hi @wangzelin007, Since the current milestone time is less than 21 days, this issue will be resolved in the next milestone


Dropdown motion update dynamic duration

Overview
Applies System 360 motion specs to the Dropdown component. This includes both the new curves and the duration scale.
Also adds three more variables to the globals.

resubmitting after rebase fixes

Added
// src/globals/scss/_vars
$transition--expansion: 150ms;
$transition--fade: 100ms;
$transition--delay-unit:200ms;

Changed
Both the JS and SCSS were changed.
src/components/dropdown/dropdown.js
src/components/dropdown/dropdown.scss

Testing / Reviewing
$ npm run test
Staging URL:
http://carbon-dev-environment-bracteate-akvavit.w3ibm.mybluemix.net/demo/dropdown

I have a few issues with this option.

Still seems a tad fast when its opening.

When the menu closes there seems to be a lag on the height of the open dropdown closing. I can't 100% put my finger on what is causing it but I think its some sort of fade only happening at the tail end of the height decreasing. Its hard to see in this gif but you should be able to see it when you use the animation dev tools ad slow it down to 10%. Its particularly noticeable after you make a selection.


booleanAttrs doesn't always exist & comments aren't handled correctly

See my pull request here: https://github.com/krux/postscribe/pull/91

Merged thanks


⚠ ClamAV has degraded performance

In dbd0454, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 205 ms

Resolved: ClamAV performance has improved in 80047cd.


Facebook like button fix

Fixing issue: https://github.com/hummingbird-me/hummingbird/issues/505

Why doesn't it use the anime name O_O
@KustoSan can you squash these commits? https://help.github.com/articles/about-git-rebase/#rebasing-commits-against-a-point-in-time if you need help.
Otherwise, :+1:


Fix textarea input throttling

throttle doesn't work with anonymous functions. If you do this, throttle is being handed a brand new function instance each time, and it has no way to know they are identical.

nice, thanks david


Modular pipelines - Write integration test on a canonical pipeline

The photometry pipelines are diverse and highly volatile.
So we already have a way to perform pre-processing in a modular way.
We need to make sure we can refactor and add to it by having a proper integration test.

see https://github.com/int-brain-lab/ibl-photometry/commit/b8baa1e46a4a50f6aea045eb5a960f8c95f7b213


[ADAP-671] Statements executed one by one instead of as a whole block

Is this a regression in a recent version of dbt-redshift?

[X] I believe this is a regression in dbt-redshift functionality
[X] I have searched the existing issues, and I could not find an existing issue for this regression

Current Behavior
We have a macro in dbt that runs a set of DDL statements on Redshift. We concatenate those statements in a string (cmd) and run with "{% do run_query(cmd) %}". That string looks like below;
begin;
  ddl_statement_1;
  ddl_statement_2;
  ddl_statement_3;
  ...
  ...
  ddl_statement_x;
end;

After moving to dbt 1.5, we see that those statements are executed one by one, instead of sending the statement as a whole to database. We can see it both in database logs and dbt logs. That causes those statements to execute in long time (more than 5 minutes) instead of only a few seconds that we had until dbt 1.4 (before moving to dbt 1.5)
Expected/Previous Behavior
Statements are executed at once
begin;
  ddl_statement_1;
  ddl_statement_2;
  ddl_statement_3;
  ...
  ...
  ddl_statement_x;
end;

Steps To Reproduce

Install dbt-core 1.5
Install dot-redshift 1.5.6
Run a set of ddl statements between begin and end in a macro with "{% do run_query(cmd) %}"

Relevant log output
[0m14:34:35.967673 [debug] [MainThread]: On macro_xyz: drop view if exists db_name.schema_name.object_1;
[0m14:34:36.158399 [debug] [MainThread]: SQL status: SUCCESS in 0.0 seconds
[0m14:34:36.158975 [debug] [MainThread]: Using redshift connection "macro_xyz"
[0m14:34:36.159297 [debug] [MainThread]: On macro_xyz: create view db_name.schema_name.object_1 as select * from db_name.another_schema_name.object_1 with no schema binding;
[0m14:34:36.528864 [debug] [MainThread]: SQL status: SUCCESS in 0.0 seconds
[0m14:34:36.531540 [debug] [MainThread]: Using redshift connection "macro_xyz"
[0m14:34:36.532585 [debug] [MainThread]: On macro_xyz: grant select on table db_name.schema_name.object_1 to group db_group;
[0m14:34:36.729741 [debug] [MainThread]: SQL status: SUCCESS in 0.0 seconds
[0m14:34:36.730303 [debug] [MainThread]: Using redshift connection "macro_xyz"
[0m14:34:36.730638 [debug] [MainThread]: On macro_xyz: drop view if exists db_name.schema_name.object_2;
[0m14:34:36.923462 [debug] [MainThread]: SQL status: SUCCESS in 0.0 seconds
[0m14:34:36.926900 [debug] [MainThread]: Using redshift connection "macro_xyz"
[0m14:34:36.927759 [debug] [MainThread]: On macro_xyz: create view db_name.schema_name.object_2 as select * from db_name.another_schema_name.object_2 with no schema binding;
[0m14:34:37.306524 [debug] [MainThread]: SQL status: SUCCESS in 0.0 seconds
[0m14:34:37.307047 [debug] [MainThread]: Using redshift connection "macro_xyz"
[0m14:34:37.307360 [debug] [MainThread]: On macro_xyz: grant select on table db_name.schema_name.object_2 to group db_group;
[0m14:34:37.514141 [debug] [MainThread]: SQL status: SUCCESS in 0.0 seconds

Environment
- OS: MacOS 13.4 and Ubuntu
- Python: 3.9.16
- dbt-core (working version): 1.4.6
- dbt-redshift (working version): 1.4.6
- dbt-core (regression version): 1.5.0, 1.5.1, 1.5.2
- dbt-redshift (regression version): 1.5.1, 1.5.2, 1.5.6

Additional Context
No response

We noticed the same with our post-hook, what helped us to set autocommit: False in profiles.yml (more details here)

@naumovdalex sorry to hear your existing workflows is failing. As part of the migration to using the redshift_connector connector library in 1.5 instead of psycopg2, this adapter's approach to transactions have changed such that every query is executed at once.
Check out #463 for more context, and I'd love to see if you get the the intended behavior by doing as @jan-benisek says and adding  autocommit: False to your profiles.yml.
I suspect that you may still encounter issues due to design decisions of the underlying connector library, for example see https://github.com/aws/amazon-redshift-python-driver/issues/162.

@naumovdalex I'm going to close this issue for now. If possible, I think this would make a great reproducible use case to rationalize https://github.com/aws/amazon-redshift-python-driver/issues/162. Perhaps open an issue there detailing the limitation?

We noticed the same with our post-hook, what helped us to set autocommit: False in profiles.yml (more details here)

I tried this, unfortunately that didn't help as well. Also, as part of our team uses dbt Cloud IDE as well, this would be a bit more complicated for us

@naumovdalex sorry to hear your existing workflows is failing. As part of the migration to using the redshift_connector connector library in 1.5 instead of psycopg2, this adapter's approach to transactions have changed such that every query is executed at once.
Check out #463 for more context, and I'd love to see if you get the the intended behavior by doing as @jan-benisek says and adding autocommit: False to your profiles.yml.
I suspect that you may still encounter issues due to design decisions of the underlying connector library, for example see aws/amazon-redshift-python-driver#162.

@dataders it's not that the workflows fail, but some macros are taking more than 5 minutes to execute, instead of just a few seconds

I understand now -- that not an ideal experience. @naumovdalex can you please provide a reproducible example? This would help the engineer at Redshift work on the above linked issue on their connector library

@naumovdalex are you still experiencing this issue in the new versions of dbt-redshift?


Add Newsletter Section to theupdateframework.io

Description:
We propose adding a newsletter section to theupdateframework.io to enhance community engagement and communication. This newsletter will serve as a valuable resource for subscribers, providing updates, announcements, and insights related to The Update Framework (TUF).
Benefits:
Improved Communication: A newsletter will facilitate regular communication with the community, keeping them informed about project updates, events, and relevant news.
Community Engagement: Subscribers can stay engaged with TUF developments, contributing to a vibrant and active community.
Information Dissemination: The newsletter will be a platform to share important information, best practices, and resources related to TUF, promoting knowledge sharing.
Outreach and Promotion: The newsletter can also serve as a tool for outreach and promotion, attracting new contributors, users, and supporters to the TUF ecosystem.

/assign @Ayush9026 i will raise PR for this.

Hi @Ayush9026 this is good idea, but i have a question. What is the point of adding this if we have already News section on website, along with press section? As far I can see, News and press section already contains everything happened in TUF.
WYT?
@lukpueh @jku any thoughts? Please correct me, If I am wrong.
Thank you 👍

Hi @h4l0gen ,
Thank you for your input! The newsletter will complement the News and Press sections by offering curated content, community highlights, and exclusive insights. Many successful projects, like Kubernetes and CNCF, have newsletters to enhance engagement and communication. It aims to create a more personalized and engaging way to keep our subscribers informed and involved.
Looking forward to hearing thoughts from @lukpueh, @jku, and others.
Thanks!

Hi @h4l0gen , regarding your comment, please try to avoid tagging maintainers on every issue and pull request. This can make the GitHub issue tracker noisy and potentially confuse newcomers. The maintainers are tracking all issues and pull requests, so please have patience.

Hey, I am really sorry, I will take care of this. 👍

@lukpueh - if there is no action to be taken here, let's close the issue.


code cleanup for lifecycle hooks

please don't merge @hhaensel ❌
I haven't tested this

tested looks ok ✅ @hhaensel if you think this is ok we can merge?

I had a short first check and it looks fine for me. I added very small changes. I think Symbol is better than Meta.parse, and in most of the macros we added |> esc  as a pipe to quote end so I sticked to that pattern.
Otherwise, I must say, I really like the style now. 👍

@hhaensel just tested with a few examples. We should merge it. Looks good

Agree!. Who's doing the merge?

I can @hhaensel


Add certificate issuer / issuer type in prometheus metrics

Is your feature request related to a problem? Please describe.
It would be very helpful to know the issuer name or issuer type in the certmanager_certificate_expiration_timestamp_seconds metrics.
Our Venafi certs follow a different ruleset than self-signed certs and as such their alert rules are different
Describe the solution you'd like
certmanager_certificate_expiration_timestamp_seconds would include some subset of:

issuer-type (ex: ACME, Self-Signed)
issuer-name (ex: self-signed, venafi-issuer, etc)
issuer-scope (Cluster or Namespace)

Describe alternatives you've considered
Alternatively adding the expected renewal info from the renewBefore option might be sufficient for creating better alerts without the issuer info as you could then try to calculate if it's past that value and by how much.
/kind feature

Needed feature, as we use Let's Encrypt as well as smallstep-ca certificates. The later ones have a validity of 24h and we can't make a difference for the expiry alert, so we have disabled that alert at all.
Please reopen
/reopen

Agree that this makes sense to add 👍🏼
The labels could be issuer_name, issuer_kind, issuer_group to match object reference that's used to refer to an issuer elsewhere.
The only doubt I have is about label cardinality.
Would be interested what folks think about the potential increase in cardinality if all three labels get added (imagining cluster with many issuers for example)
Arguably these labels could also be added to the other certificate metrics but again thinking about the same scaling issue.
/reopen

/remove-lifecycle rotten
Given foks interest in this I think it makes sense to add it
I'm going to label this as a good first issue as it should be a straightforward change
The code for metrics is here https://github.com/cert-manager/cert-manager/blob/master/pkg/metrics/metrics.go
/good-first-issue

/milestone v1.9

@irbekrm adding a PR for this. Also, should the labels be added to certificate_renewal_timestamp_seconds and certificate_ready_status metrics as well?

Thank you for addressing this. Also have a need for these metrics 👍

Thank you @4molybdenum2 !

Also, should the labels be added to certificate_renewal_timestamp_seconds and certificate_ready_status metrics as well

I would say for now maybe let's add the labels to certmanager_certificate_expiration_timestamp_seconds metric only. They can always be added to other metrics if needed, but once added they shouldn't be removed to avoid breaking users and I am wary of increasing amount of storage of cert-manager Prometheus metrics.

@irbekrm I added the labels to both certmanager_certificate_expiration_timestamp_seconds and certmanager_certificate_renewal_timestamp_seconds for now because they might be used together based on a review made on the PR.

@4molybdenum2 the issue description talks about creating Prometheus alerts for expired/expiring certs. I think it should be possible to do this with certmanager_certificate_expiration_timestamp_seconds alone.
It'd be valuable to hear if there is a use case where the same labels are needed for certificate_renewal_timestamp_seconds, but I would be relucant to add them if it's just a 'nice to have' as we cannot easily remove those labels once added easily.

Sounds good, also I was wondering about some metricsRefreshInterval and whether that will be useful? I mean it can help with memory issues that may arise?...

@4molybdenum2 the issue description talks about creating Prometheus alerts for expired/expiring certs. I think it should be possible to do this with certmanager_certificate_expiration_timestamp_seconds alone.
It'd be valuable to hear if there is a use case where the same labels are needed for certificate_renewal_timestamp_seconds, but I would be relucant to add them if it's just a 'nice to have' as we cannot easily remove those labels once added easily.

Hi @irbekrm , we actually have a use-case for the labels on certificate_renewal_timestamp_seconds

Hi @irbekrm we have a use-case for certmanager_certificate_renewal_timestamp_seconds and certmanager_certificate_expiration_timestamp_seconds.
We have a mix of Let's Encrypt and short-lived mTLS certificates. Static alarms on certmanager_certificate_expiration_timestamp_seconds are not sufficient enough. We're crafting alarms on certmanager_certificate_renewal_timestamp_seconds which is more relevant to us, but need to differ between which certificate (issuer) it is. Short-lived mTLS certificates not renewed are critical. Let's Encrypt certificates not renewed are only critical in production namespaces.

This is also something we would like to see added, any chance to have this re-open? looks like there's a PR in-flight that stalled.
In our setup we use Let's Encrypt and an internal ACME issuer, for monitoring and alerting purposes we need to be able to distinguish certificates by their issuer, so having these labels would be very beneficial.
if adding labels to existing metrics is a concern, how about adding a new info metric (e.g.: certmanager_certificate_info) that will have these new labels and it can be joined in query time (a common pattern in prometheus)?


Update Documentation related to Toolchain option

Documentation related to TOOLCHAIN needs to be updated
e.g while reading README.md its looks like only Two TOOLCHAIN option for Linux is supported i.e
CLANG or GCC
so if you want to try compiling on aarch64 with GCC  based on the documentation you
will use the below command
cmake -DARCH=aarch64 -DTOOLCHAIN=GCC -DTARGET=Release -DCRYPTO=mbedtls ..
but this will fail in the compilation
Looking at the CMAKElist.txt actual command should  be
cmake -DARCH=aarch64 -DTOOLCHAIN=AARCH64_GCC -DTARGET=Release -DCRYPTO=mbedtls ..
( and this worked.)

I think we should always use GCC and remove AARCH64_GCC.

Agree, its not cross-compilation and internally we should assign right gcc and only keep clang and gcc as option.

I can start a discussion on host-compilation vs cross-compilation use cases. We may want to specify DHOST=x64 and DCROSS=AARCH64.

@steven-bellock  sounds good.
Also was interested if we can compile libspdm with arm-none-eabi  toolchains.

cmake -DARCH=aarch64 -DTOOLCHAIN=GCC -DTARGET=Release -DCRYPTO=mbedtls ..
but this will fail in the compilation

@alokprasad How does it fail? Are you compiling on a x86 or ARM host?

Started discussion at https://github.com/DMTF/libspdm/discussions/612.

@steven-bellock compiling on Ampere Sever ( aarch64) u cant use GCC u have to use AARCH64_GCC

Ah I see now. @alokprasad are you seeing errors like

gcc: error: unrecognized command line option ‘-mno-red-zone’

This is a GCC compiler option for x86 and should be controlled by ARCH in CMake.

Yes correct.


Autocomplete and Autoindentation

Can these features be activated?
Otherwise, their addition would be greatly appreciated!

+1

+1


Make it possible to supply a post_build callable to CommandLineEnvironment

This is useful when you need to run some other command after assets have been built.

Can I ask what you are using this for?
I'm wondering if the proper place isn't inside the Bundle class, so these additional steps would also be run when for example using the auto build feature.

I need bundles to be rebuilt and a service to be reloaded outside the request/response loop. Riak can use Javascript in map/reduce, and I am using webassets to compile assets for it. After builds, Riak must be reloaded. I am using CommandLineEnvironment to watch for changes.

Merged, but I squashed the commits.

thanks :beers:


How to set Header and Footer Static and only scroll body

When rows per page is set high like 100, I need a way to set the header and footer static so only the body scrolls.
Expected Behavior
Setting a certain property should allow user to scroll body and leave header and footer static, or at the very least the header.
Current Behavior
When scrolling it scrolls the whole datatable.
Steps to Reproduce (for bugs)
This example has the header static and does not scroll.  Is there any way we can get this same functionality in the material-datatable?
https://material-ui.com/demos/tables/#virtualized-table
Your Environment
I'm using the latest material-datatable - "material-datatable": "^0.3.8"

@Pryorite let me check.

I really like this grid. Freezing the header is the only feature that my users are requesting. Thanks @Diaver for researching this question.

@Pryorite @bluebeag
I didn't find the good way to do it.
With all of that ways you need set  display:block and manually set column width like here http://jsfiddle.net/3fXjD/1305/
Do you know the better way to do it?

@Diaver - Looks like this sandbox project is doing what we are looking for.
https://codesandbox.io/s/43ml13vq19
I see they are using an AutoSizer, not sure if that has any header freezing attributes on it.  This sandbox is exactly the output we are looking for.  Thanks again all your help.  This grid has saved us many hours of code mashing.

@Pryorite
Provided example use "react-virtualized" components.
For me, it is seems to be very dramatic changes, I am not ready right now implement such changes, but I am going to play with it on this weekend.

@Diaver - Do you have any news on this feature?


[LOC] invalid link in an article

There is a broken link within an article.
Repro steps:

Go to https://docs.microsoft.com/en-us/powershell/sharepoint/sharepoint-pnp/sharepoint-pnp-cmdlets?view=sharepoint-ps
Search for the "https://docs.microsoft.com/sharepoint/governance/records-management-in-sharepoint-server|SharePoint"
Click on the link

Actual results:
Link redirects to a non existing page
Expected results:
Link redirects correctly
GH article:
https://github.com/MicrosoftDocs/office-docs-powershell/blob/master/sharepoint/docs-conceptual/sharepoint-pnp/sharepoint-pnp-cmdlets.md

@officedocsbot assign @yogkumgit

Hello it seems there is a typo that is preventing the rendering of the table and that seems to be the cause, created a pull request to try to fix this. thanks

@get-itips  Thank you very much for the contribution and updating the documentation with PR. @OfficeGlobal Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Question about when I have multiple logs for the same query

Hi, this is just a question. I want to start experimenting with your library. Now I am not sure whether the input lines should have one line for each query, or that each query can have multiple lines. So if two visitors execute the same query, but do different clicks, is that two lines?
Thanks

That would be multiple lines.

great thanks


Re-installation without wiping database

What is the proper steps to take to re-install Oro on a fresh code base without having to wipe the database?
Just doing a new git pull and adding the old parameters.yml does not seem to be enough.

No activity for almost two years so I assume this issue has been resolved. @Zyles feel free to reopen if necessary.


Attempting to open a large file crashes vscode

Does this issue occur when all extensions are disabled?: Yes/No

VSCode has always had issues with large files (i.e. binary or large text files). These are problematic when you're using vscode for data science and accidentally click on them in the editor. Recently though the editor has started crashing when a large file is selected, ie. I have a 700mb jsonlines file in my training data folder. With no extensions enabled the editor always locks for a long period of time then crashes if I accidentally select it.

VS Code Version: 1.83.0
OS Version: Ubuntu 22.04

Steps to Reproduce:

Click on a large file, i.e. train.jsonl (710MB) in Folders
VSCode locks up then crashes

Ideally, there would be some form of warning when attempting to open a file that's too large for the editor (or better still the editor shouldn't try and load large files in there entirety), similar to the warning when trying to open an unsupported (i.e. binary) file.
Also the error message has a reopen option but that didn't work for me.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.83.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

It looks like there is a warning message if you try and open large files, the issue for me is the default (1024mb) was higher than the actual file size that crashed vscode on my machine.


Wrong image in README

https://user-images.githubusercontent.com/5289615/155400743-d9d356c4-9a19-4bbd-a728-db6f0bcb505f.png
The first one is incorrect.

Worms 4 Mayhem have different parabolic aimer


implement guessing heuristics for cargo vet certify

These were outlined in https://github.com/bholley/cargo-vet/issues/85#issuecomment-1133091909 and https://github.com/bholley/cargo-vet/issues/85#issuecomment-1133374812 , but not implemented in #140.

Ah I regarded the guessing stuff as more p2-nice-to-have.
Part of the question for the really stateful stuff is "where" it should go and how hard we should try to remember different things and for how long.
The simplest solution I could think of was:

in the global temp-cache, create a recent_commands.json

contains the last suggest (in a more machine-readable form)
contains the last inspect/diff

Both of those commands access that cache so they already need to get a lock to the global cache. Then when we certify we check if there's a recent inspect/diff, and then check if it was suggested, and if so, what criteria were suggested.
That said I think we still want to have some sort of pre-prompt of "is this guess right?"
Possibly it's the current interactive prompt but the guess is just filled in so if it's right you just mash enter?

That generally seems reasonable, except that I'm not sure it's worth the complexity of trying to cache the most-recent vet and suggest calls — seems easier to just invoke them internally (perhaps with some way to scope it to the computations we care about — just that crate, and none of the diffcache stuff).

if we already need to cache what the last inspect/diff call was, it seems easier (and faster) at that point to just be consistent and cache the suggest in the same place.

It's also a question of accuracy. It's conceivable that the impetus to perform/certify the audit did not come from a recent invocation of vet or suggest on the local machine. I would intuitive inspect cargo vet certify foo 1.2 not to depend on some magically-cached possibly-stale artifact, whereas it's more understandable that bare cargo vet certify would.

hmm so do you want magic to be basically binary? all or nothing?

When criteria aren't specified, cargo vet should guess them based on the tree state (i.e. an internal vet/vet suggest). When the crate+version is not specified, cargo vet should guess them based on history (i.e. last call to inspect or diff).

One reason to prefer a previous invocation is because suggest vs suggest --guess-deeper is a pretty significant difference and we can't know which they used without literally just remembering. It would be annoying to do the expensive --guess-deeper and hang certify for no reason


Should this be hard coded to us-west-2?

This shows that us-west-2 is the region that will be set when the file assets are being transferred.  This is typically not a good idea for S3 clients to be fixed to one region, especially when the S3 assets are could be in other regions.  Wondering if this shouldn't be taken from the 'env' instead?  Looking at the deploy step it uses the env region.

Hi again, @roskelleycj. The code you linked,
https://github.com/cdklabs/cdk-pipelines-github/blob/f37851a4940b402dd156d974ce82e3570cc2f26b/src/pipeline.ts#L347
actually concerns authenticating GitHub to AWS, not where s3 assets are published. In the end, the region gets bundled into a parameter for the Configure AWS Credentials GitHub action. The action requires a region, but we don't really care what region it is since all we are doing is authenticating.
Follow up question: where do the s3 assets get stored? This actually comes from this line,
https://github.com/cdklabs/cdk-pipelines-github/blob/f37851a4940b402dd156d974ce82e3570cc2f26b/src/pipeline.ts#L311
which calls the cdk-assets CLI. What this does is that it finds the asset manifest in your cdk.out folder, and creates a shell script that looks something like this:
set -x
npx cdk-assets --path "cdk.out/assembly-StageA/StageAFunctionStackD42C27B8.assets.json" --verbose publish "<hash>:<account-id>-us-east-1"
npx cdk-assets --path "cdk.out/assembly-StageB/StageBFunctionStack18098DCD.assets.json" --verbose publish "<hash>:<account-id>-eu-west-1"
echo '::set-output name=asset-hash::923d41051861c9ea2fa3f60c36c4c5a7f10bdf4fa44ed6965ba3a7bfe50f0487'

In this example, we are actually publishing the same asset to two different regions.

@kaizen3031593 thank you for the details.


[Question] How do these shops works? More detailed explanation, please?

Latest Version of Diamond Economy and Chest Shops, and players are very much confused on how the chestshops actually function, they have set them up completely properly and items are hovering above the chests, but they can't buy.... or sell anything. It's doing literally nothing, and players are absolutely confused, and I am too.
Minecraft Fabric 1.18.2

as discussed on the discord its definitely due to the capitalization restriction on my part


Improve documentation around handling of dictionary arrays in arrow flight

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Documentation around handling of dictionary arrays in arrow flight is confusing.
Describe the solution you'd like

Improve doc comments so it is more clear how it works and what the different options mean concretely
Describe alternatives you've considered

Leave people confused and let them figure it out through trial and error like I did :)
Additional context

Related slack thread: https://the-asf.slack.com/archives/C01QUFS30TD/p1709986070881859?thread_ts=1709815827.985999&cid=C01QUFS30TD

label_issue.py automatically added labels {'arrow'} from #5488

label_issue.py automatically added labels {'arrow-flight'} from #5488


Allow npm loglevel override

The -s argument to npm install is equivalent to --loglevel silent.  If npm install -s fails it doesn't provide any helpful information.  This will preserve the existing behavior and allow for an override when needed.  To use this feature set an environment variable NPM_CONFIG_LOGLEVEL to one of "silent", "error", "warn", "notice", "http", "timing", "info", "verbose", or "silly". Documentation here: https://docs.npmjs.com/cli/v7/using-npm/config#loglevel
Example output with no NPM_CONFIG_LOGLEVEL set (this is the same behavior I currently see in the published image):
...
STEP 10: RUN /tmp/scripts/assemble
ls: cannot access '/tmp/src/node_modules': No such file or directory
---> Installing application source
---> Building your Web Application from source
---> Installing dependencies
---> Using 'npm install'
error: build error: error building at STEP "RUN /tmp/scripts/assemble": error while running runtime: exit status 254

And with NPM_CONFIG_LOGLEVEL=error:
...
STEP 10: RUN /tmp/scripts/assemble
ls: cannot access '/tmp/src/node_modules': No such file or directory
---> Installing application source
---> Building your Web Application from source
---> Installing dependencies
---> Using 'npm install'
npm ERR! code ENOENT
npm ERR! syscall spawn git
npm ERR! path git
npm ERR! errno -2
npm ERR! enoent Error while executing:
npm ERR! enoent undefined ls-remote -h -t<EMAIL_ADDRESS>npm ERR! enoent
npm ERR! enoent
npm ERR! enoent spawn git ENOENT
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent

npm ERR! A complete log of this run can be found in:
npm ERR!     /opt/app-root/src/.npm/_logs/2021-04-14T22_21_42_995Z-debug.log
error: build error: error building at STEP "RUN /tmp/scripts/assemble": error while running runtime: exit status 254

@bdurrow great addition!


provide versions/build details in logs of operator and driver containers

Is your feature request related to a problem? Please describe.
We need easy way to validate versions and build of container images. This is required to validate GA builds and open defects.
Describe the solution you'd like

Provide commitID in images, we should able to query in logs.
provide way to query images to determine above info.

Describe alternatives you've considered
imageID of containers.
*

This will be handled after 2.5.0 considering current deadlines.

@deeghuge this should get fix with latest merge for commit id in docker images ?

No, I just added that piece as a placeholder in the Dockerfile.  I'll open a new PR wiring that up though: #578
We should double check that actually works, also this issue should probably also cover adding revision to generated kustomize and add version in a similar way to be logged.

validated in 5.1.3 RC2 build
I0313 07:00:43.420312       1 main.go:48] Version Info: commit (10b66641e5322b1a44cf7ba7c3023d47d15077d4)```

Closing based on Sanjay's validation


Managed SSL multi-domain update without downtime

TL;DR
Changes on managed_ssl_certificate_domains will cause a downtime because the SSL certificate is replaced, this should be prevented.
Terraform Resources
No response
Detailed design
No response
Additional information
When adding a domain to managed_ssl_certificate_domains the SSL certificate will be replaced, because the additional domain needs to be supported by the certificate itself. The lifecycle rule create_before_destroy = true will not make a difference here, because the new certificate in "Provisioning" state is a "ready" resource for terraform (and the certificate need to be added to the LB to be verified).
As the certificate is in provisioning state, all other domains can also not be served via SSL for a while. Curl output example:
curl: (35) error:14004410:SSL routines:CONNECT_CR_SRVR_HELLO:sslv3 alert handshake failure

With the current design this is not preventable. However it is possible to (instead of adding all domains to the SSL certificate) create a certificate per domain and add those certificates to the Load Balancer. I've tested this approach like this:
# HTTPS proxy when ssl is true
resource "google_compute_target_https_proxy" "default" {
  project = var.project
  count   = var.ssl ? 1 : 0
  name    = "${var.name}-https-proxy"
  url_map = local.url_map

  ssl_certificates = compact(concat(var.ssl_certificates, google_compute_ssl_certificate.default.*.self_link, [for c in google_compute_managed_ssl_certificate.default: c.self_link ], ), )
  ssl_policy       = var.ssl_policy
  quic_override    = var.quic ? "ENABLE" : null
}

# ...

resource "google_compute_managed_ssl_certificate" "default" {
  provider = google-beta
  project  = var.project
  for_each = toset(var.managed_ssl_certificate_domains)

  name = "${var.name}-cert-${replace(each.key, ".", "-")}"

  managed {
    domains = [each.key]
  }
}

It look like with this approach the existing domains are still reachable and SSL termination is working while the additional certificate is provisioned.
You can find my test implementation at https://github.com/philsch/terraform-google-lb-http/tree/feat/interruption_free_managed_ssl . Please provide your feedback on this idea. I'll be happy to create a PR if this approach makes sense.

bump

@philsch sorry for the delay. This seems reasonable although I am curious about any quota constraints.

Thanks for writing back on this topic @bharathkkb . You're absolutely right, if I read the GCloud docs correctly this approach limits the number of parallel domains from 100 to 15. I believe most users would still prefer a downtime free deployment as more than 15 parallel domains is probably not that common, however introducing this as a breaking change is also not a good solution.
Do you think splitting the input parameters like managed_ssl_certificate_domains and managed_distinct_ssl_certificate_domains would be a solution for a non breaking change? Do you have any other ideas?

Bump


Nested locate://

// src/components/foo/foo.html

<can-import from="project/components/foo/" />

// src/components/foo/foo.js

import `./foo.less`;

// src/components/foo/foo.less

@import "locate://project/less/bootstrap.less"

// src/less/bootstrap.less

@import "locate://bootstrap/less/variables.less"

Results in:
404 http://../node_modules/bootstrap/less/variables.less

It looks like the locate hook is working, but it's not being made relative to the html page.
Originally posted here: https://github.com/donejs/css/issues/40

The heart of this bug appears to be that when we calculate relative paths for located resources we assume the path of the importer is normalized. Including '../' in the base path causes additional '../' in the output, resulting in this bug. Working on a fix.

I've confirmed this is the issue and have a fix that works. Will have the change up once I get a chance to add a test for it.

Thank you @nlundquist!

no problem @akagomez. when you get a chance can you try that branch and confirm it resolves your case? after that i'll merge down and make a patch release

@nlundquist Works beautifully!


"ERR MULTI calls can not be nested" when using rbatch in cluster mode

when i used rbatch  to execute  a batch of  orders in cluster mode just like this :
 RBatch rBatch = getRedisson().createBatch(batchOptions);   rBatch.getSetCache("", LongCodec.INSTANCE).addAsync(packId, 3, TimeUnit.DAYS);   rBatch.getTopic("").publishAsync(packId);   rBatch.execute();
these orders should've been sent to  different redis cluster ,as the redis keys  that i used  belong to different slots。
one of the orders was  executed  normally and  the other one redis recieved looks like this:

the second redis cluster  printed  double "MULTI"  orders，and returned an errror "ERR MULTI calls can not be nested"
reverting the version of redisson to V3.19.3 will solve the problem.

@mrniko

Let me check that

Merged


Input mask and validation

Package
filament/filament
Package Version
v3.1.35
Laravel Version
v10.0.0
Livewire Version
v3.0.0
PHP Version
PHP 8.2.0
Problem description
I have a field with a mask. The mask work correctly, I cannot type letters. But when I type letter, mask seems working, but letter are effectively "typed" (even if hidden) and we cannot validate the field.
TextInput::make('amount')
  ->mask(RawJs::make('$money($input)'))
  ->stripCharacters(',')
  ->numeric()

Expected behavior
If I enter "100aaa" in the field I expect the field to be valid as aaa shouldn't be in the input value.
Steps to reproduce
1 - Go to http://<IP_ADDRESS>:8000/admin/users/create
2 - Type "100aaa" (even if you don't see the letters)
3 - Submit the form
You should get a "The amount field must be a number." error
Reproduction repository
https://github.com/clinvest/filament-issue
Relevant log output
No response

This is an Alpine/Livewire bug. Here is proof - https://wirebox.app/b/yrde7. You can open a failing test PR on the Livewire repository to initiate a fix.


Expose unique message id to message consumers

This is related to https://github.com/odpi/egeria/issues/863.  When the server restarts unexpectedly, we need a way to distinguish stale messages from messages that were incompletely processed.  Messages that were incompletely processed should be reprocessed, but other (duplicate) messages with the same version and guid as a message we have previously processed can be safely ignored.  One very simple way we can do this is to enhance OMRSEventProcessingContext to be able to provide a unique identifier for the message that is currently being processed.  For Kafka, we’re using the message offset as the unique identifier.
I've put together a PR for this and am in the process of submitting it.

Hello @jnhagelberg - is this complete?

I believe this is complete. Closing - @jnhagelberg please reopen if I'm mistaken


Close/Dismiss all modals which are open at once.

Environment

react: 18.2.0 => 18.2.0
react-native: 0.71.4 => 0.71.4

Platforms

both
Versions

"react-native-modal": "^13.0.1"
Description

Is there any way to dismiss modals with one action? I want to dismiss all modals when token is invalid in interceptor
Reproducible Demo

Just a question, doesn't need demo

Just for now, Try to close them by dispatching an action from an interceptor
e.g. you have your modal state in a redux state and then you dispatch store.dispatch('close modalX') where you listen to this variable in your all of your modals useEffect or smth like this ... and if your modal has captured a certain value it dismisses


Handle dependency errors invidually

This PR adds handling for errors encountered when pulling information for individual dependencies.  This change, along with https://github.com/github/licensed/pull/133, aims to reduce the majority of source and dependency specific errors encountered when enumerating dependencies from crashing an entire licensed command run.
An errors attribute is added to Licensed::Dependency which is then picked up in Licensed::Commands::Command#run_dependency and transferred to the command's reporter for output similar to any other failure that might be displayed for a dependency.
If a dependency has errors, all of its methods will return empty or nil data.  Additionally, it will not be evaluated by the commands and will be considered to have failed.
Some common error cases relating to paths are picked up automatically when creating a new dependency

a nil or empty path argument
a path argument that doesn't exist on disk

Any other errors are returned from the various CLI and framework tools can be passed in directly.
Specific comments on implementation inline.

Some examples of output showing that errors finding dependencies no longer stop execution of the overall dependency enumeration for an individual source, or for a licensed run as a whole 🎉

Bundler
Listing dependencies for bundler
  bundler
    i18n (1.0.1)
    pathed-gem-fixture (0.0.1)
    concurrent-ruby (1.1.4)

  * Errors:
    * bundler.bundler.semantic
      - could not find semantic (= 1.6.0) in any sources

    * bundler.bundler.bundler
      - could not find bundler (>= 0) in any sources

    * bundler.bundler.mini_racer
      - could not find mini_racer (>= 0) in any sources

NPM
Listing dependencies for npm
  npm
    autoprefixer (5.2.0)
    autoprefixer-core (5.2.1)
    browserslist (0.4.0)
    caniuse-db (1.0.30000898)
    num2fraction (1.2.2)
    postcss (4.1.16)
    fs-extra (0.18.4)
    graceful-fs-3.0.11 (3.0.11)
    graceful-fs-4.1.11 (4.1.11)
    natives (1.1.6)
    jsonfile (2.4.0)
    rimraf (2.6.2)
    glob (7.1.3)
    fs.realpath (1.0.0)
    inflight (1.0.6)
    once (1.4.0)
    wrappy (1.0.2)
    inherits (2.0.3)
    minimatch (3.0.4)
    brace-expansion (1.1.11)
    concat-map (0.0.1)
    path-is-absolute (1.0.1)
    es6-promise (2.3.0)
    source-map (0.4.4)
    amdefine (1.0.1)

  * Errors:
    * npm.npm.balanced-match
      - expected dependency path /Users/jonabc/github/licensed/test/fixtures/npm/node_modules/balanced-match does not exist

    * npm.npm.js-base64
      - expected dependency path /Users/jonabc/github/licensed/test/fixtures/npm/node_modules/js-base64 does not exist

Cabal
Listing dependencies for cabal
  cabal
    base (<IP_ADDRESS>)
    ghc-prim (<IP_ADDRESS>)
    integer-gmp (<IP_ADDRESS>)

  * Errors:
    * cabal.cabal.rts
      - expected dependency path /Users/jonabc/github/licensed/test/fixtures/cabal/vendor/rts does not exist

    * cabal.cabal.zlib
      - package not found

    * cabal.cabal.Glob
      - package not found

Go
Listing dependencies for test
  go
    github.com/hashicorp/golang-lru/simplelru (369ebece87972d9baba47b99dbad75fa4ad29df8)
    github.com/hashicorp/golang-lru (20f1fb78b0740ba8c3cb143a61e86ba5c8669768)

  * Errors:
    * test.go.github.com/davecgh/go-spew/spew
      - cannot find package "github.com/davecgh/go-spew/spew" in any of:
	/usr/local/Cellar/go/1.11.4/libexec/src/github.com/davecgh/go-spew/spew (from $GOROOT)
	/Users/jonabc/github/licensed/test/fixtures/go/src/github.com/davecgh/go-spew/spew (from $GOPATH)

    * test.go.github.com/gorilla/context
      - cannot find package "github.com/gorilla/context" in any of:
	/usr/local/Cellar/go/1.11.4/libexec/src/github.com/gorilla/context (from $GOROOT)
	/Users/jonabc/github/licensed/test/fixtures/go/src/github.com/gorilla/context (from $GOPATH)

    * test.go.golang.org/x/net/http2/hpack
      - cannot find package "golang.org/x/net/http2/hpack" in any of:
	/usr/local/Cellar/go/1.11.4/libexec/src/golang.org/x/net/http2/hpack (from $GOROOT)
	/Users/jonabc/github/licensed/test/fixtures/go/src/golang.org/x/net/http2/hpack (from $GOPATH)

Go dep
Listing dependencies for test
  dep
    github.com/gorilla/context (14f550f51af52180c2eefed15e5fd18d63c0a64a)

  * Errors:
    * test.dep.github.com/davecgh/go-spew/spew
      - expected dependency path /Users/jonabc/github/licensed/test/fixtures/go/src/test/vendor/github.com/davecgh/go-spew/spew does not exist


1 Satoshi missing from LTC order payment

I have an order for a listing requiring 987980 in order to fund:
            "payment": {
                "method": "ADDRESS_REQUEST",
                "moderator": "",
                "amount": 987980,
                "chaincode": "",
                "address": "",
                "redeemScript": "",
                "coin": "LTC"
            },

I call /wallet/spend/ with that amount:
{"feeLevel":"NORMAL","memo":"","address":"LUTbVq25FTtNmJuZCnLG89SugjZNmmf2TC","amount":987980,"wallet":"LTC"}

But, the payment that ends up bing applied to the order ends up a Satoshi short:
    "paymentAddressTransactions": [
        {
            "txid": "3fd0cd350f87fccef29306959c9e84792d91eaa70d51fccce1aa7577bd27c360",
            "value": 987979,
            "confirmations": 0,
            "height": 0,
            "timestamp": "2018-11-01T22:43:15.834950Z"
        }
    ]

resulting in minuscule underpayment:

Also, 1 sat is below the dust amount, so essentially an order in that state becomes unfundable.

This just happened again after not happening for 20+ orders. Not sure what the trigger is because I'm pretty much doing the same thing for all orders, including buying the same product. Maybe something is happening on the insight end?

The amount that was paid in the transaction was correct. The amount that was shown as paid to the UI was off by one. Either the insight server returned the wrong value or there was some kind of rounding error converting it.

The amount that was shown as paid to the UI was off by one. Either the insight server returned the wrong value or there was some kind of rounding error converting it.

Ok, but in either case it's something we need to rectify because the UX is horrible in this case. The order becomes unfundable and the buyer needs to ask the vendor to refund or mod to rule in their favor and then make another order hoping it doesn't happen again.

If it’s a bug with insight we need to know. Keep us posted.

Did you post a bug fix for this @cpacia?

fixed


Revert "Set LLVM backend up to receive automatic updates from scala-kore"

Reverts runtimeverification/llvm-backend#1008

Not sure why this is failing CI but it's a direct revert of the tip of master so I'm going to go ahead and merge despite that.


Better OpenApi Specification to support automatic Api Client Generation using NSwag

I was trying to get C# client classes generated for the api from the swagger document, but ran into some issues, for which I needed to replace swashbuckle with nswag. They do basically the same (but nswag can also be used to generate code).
These changes don't change anything to the api's themselves, only the swagger.json document is different (actually more compliant to openapi), also the SwaggerUI should have all the same features than before. And more... e.g. you don't have to supply a version if you want to try out a versioned api call now.
The biggest advantage is that we can autogenerate a client now for the blazor frontend. See this pull request over on the blazor repository.
The actions on the controllers do need to have a return type otherwise a generic "fileresponse" is returned from every method in the generated c# client. I did this now for the brandscontroller and the productscontroller. All the methods also need these attributes:
[ProducesResponseType(200)]
[ProducesDefaultResponseType(typeof(ErrorResult<string>))]

To make sure when an error is returned (non 200), it gets parsed into an actual ErrorResult.
I've added a "FSHApiConventions" class which you can apply at the controller level which should take care of most methods. If a method isn't covered by that class you can add it there (if it's used in more than one controller), or add the above 2 attributes to the method in question (like I did with the DeleteRandomAsync method on the brandscontroller).
Draft for now to gather already some feedback and as I will update the rest of the controller actions as well...
I think this could eliminate the need for a separate Shared.DTOs project... which would make it possible to put the dto's back where they belong with the classes that use them... keeps the overview more clear...

wonderful contribution


What is the aleat3 documentation doing on CHANGELOG.md?

I know this is a simple mistake... I will use a PR to fix it.

No... this bug must be fixed as soon as possible... I will use only one commit, and that's all.

All done. we can close this issue.


Link to a wrong tip

Create a collection -> "i" near "name" linked to a wrong tip

This will be new interface https://nft.kodadot.xyz/rmrk/mint


Issue with multiselect and add new in the latest version.

I created a table that has add new and multiselect options, but when add new is clicked, the columns shift to left. I have attached screenshots for reference.

columns shift to left

I am using angular 4

has this been fixed?

I had to edit the row template. It is missing the checkbox tag

that's because of this [ng2-st-thead-form-row] component has issue in template

but should be:

I have some workaround, I manipulated to DOM directly but it's bad solution,
append first child  to

@kohanevich85  can you please share the code of your temporary workaround in case it's will not merge

Here is an example of fix. It's direct manipulating
ngAfterViewChecked() {     let firstRow = 2;     let columnOffset = 4;     if (this.elRef.nativeElement.querySelector('.ng2-smart-action-add-create')) {       let td = this._renderer.createElement("td");       let tr = this.elRef.nativeElement.getElementsByTagName('tr')[firstRow];       let refChild = tr.childNodes[columnOffset];       if (refChild.className === 'ng2-smart-actions') {         this._renderer.insertBefore(tr, td, refChild);       }     }   }

Where do you implement this code?

@kohanevich85 Where do you implement this code?

Is it ok to implement hook in the constructor, cos it didn't work for me((

in this case it doesn't matter because of direct DOM manipulation and on event after view checked (ngAfterViewChecked).
This code just should run.
I used this code in component which include smart-table component.

constructor is not appropriate hook for this try to use ngAfterViewChecked()

Thanks, I didnt use checkboxes, so there is no more problem for me


Remove MSAL Electron Proof of Concept from Monorepo

This PR:

Removes the msal-electron-poc package from the experimental directory in the monorepo to avoid confusion
Removes the msal-electron-sample-app package from the samples directory
Removes the MSAL Electron section from the CODEOWNERS file

Coverage decreased (-1.5%) to 80.098% when pulling 1e45c63d1312358c08ae9ffe377ca4889867d853 on remove-msal-electron-poc into 1fde9087b1bca57ca128ffeabb37f00a758809b5 on dev.


[REQUEST] PCGamingWiki

Is your feature request related to a problem? Please describe.
If support can be added to the website https://www.pcgamingwiki.com/
It contains several tutorials and fixes for games
Describe the solution you'd like
If support can be added to the website https://www.pcgamingwiki.com/
It contains several tutorials and fixes for games
Describe alternatives you've considered
No response
Additional context
No response

please, when opening an issue, state in detail what you want, how it should be implemented, and alternatives


Remove tailwind UI check

Whilst migrating the site from the old designs to, first Tailwind UI and later the new designs from Robert, we needed to support some of the old form styles. This was done by setting a variable in a view which would be used to determine whether or not to add a class of standard to the body of the page.
This PR removes that need by restyling the remaining old-style pages using tailwing UI. This included:

Login
Register
Verify email
Password reset request
Password reset
Rules

Screenshots of the proposed new pages can be found below

Amazing, thank you @joedixon!


DIA-NN improvements.

Description of feature
Today I had a discussion with @vdemichev about DIA-NN in quantms. We discuss multiple topics, I will relate some of them here:

[ ] conda package of DIA-NN. Currently, the pipeline can we run in docker and singularity, without access to the source code, the releases only will work for some specific architectures, the ones used by the developer to build the tool. After talking to the bioconda team, we have decided to wait until a user ask for it.

[ ] Include some parameters from the dian-nn into the current for those datasets where the information can be annotated, this can help to speed-the process of searching:

[ ]  Precursor m/z range.
[ ]  Fragment m/z range
[ ] Relaxed protein inference. In the documentation of the tool, the authors claims that --relaxed-prot-inf can be used for the protein inference and is faster than the default method. In quantms we recommend the user of other tools like msstats for downstream analysis which enable consensus results between TMT, LFQ and DIA-LFQ.

Question: why not use the latest open source version?

They have improved the tool a lot since that, specially the library prediction, which is crucial in our case. I have tested already the tool in singularity and docker and it works which is good.

Okay 👍

#132

Running the new version of the pipeline with the library generation step the pipeline fails most of the time. @vdemichev already mentioned that to me that library generation had a bug in Linux archs. I will way for the new release to fix it.


fix: allow for long lines in SQL migrations

What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When lines that are too long are encountered, the scanner in internal/utils/parser/token.go#Split fails, but the .Err() is not checked, causing the error to be suppressed and the internal/utils/parser/token.go#Split func to return partial data.
See #470
What is the new behavior?

Errors produced by the scanner used in internal/utils/parser/token.go#Split are propagated to the caller.
Lines up to 256K can now be read by internal/utils/parser/token.go#Split.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

13 of 17 (76.47%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.08%) to 39.832%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/db/diff/migra.go
3
5
60.0%

internal/db/reset/reset.go
3
5
60.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.08%

Covered Lines:
1992

Relevant Lines:
5001

💛  - Coveralls


Adding Default user for People Picker

Is your feature request related to a problem? Please describe.
Defaults for some fields are very changeling and require code. Defaulting a people-picker to the current user is a common default and is a lot of work to code each time.
Describe the solution you'd like

There are times you might want to default the current user to a people field.
There are times you might want to default the current user's email address or display name to a text field.
Set a field to either the user, the email address, or the display name of some other field on the record (people field as the source).

Describe alternatives you've considered
Currently, I hard-code all of this either with JavaScript or use a workflow in getting the values.
Additional context

Great idea! Do you have a code sample @sharvancik of setting a person field to current user? If so, I can plug it in. if not, I can google ;)

On Tue, Oct 8, 2019 at 12:13 PM David Lozzi<EMAIL_ADDRESS>wrote:

Great idea! Do you have a code sample @sharvancik
https://github.com/sharvancik of setting a person field to current
user? If so, I can plug it in. if not, I can google ;)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/DavidLozzi/SharePoint-HideDisableFields/issues/4?email_source=notifications&email_token=AIFS7IMYTDTTL5T6WKWVUY3QNS5UHA5CNFSM4I6KG452YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAU5QHQ#issuecomment-539613214,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIFS7IOG3JVHNA7452MS7Q3QNS5UHANCNFSM4I6KG45Q
.

--
Steve
<EMAIL_ADDRESS>


ignore_changes warning with Terraform v1.2.0

Description
When a plan or an apply is perfomred with terraform version 1.2.0 a warning is presented about a redundant ignore_changes element.  Any example from the examples/* can be used to reproduce the error message with the correct version of terraform.

[X] ✋ I have searched the open/closed issues and my issue is not listed.

Versions

Module version [Required]: 18.21.0 & 18.20.5

Terraform & Provider versions:
Terraform v1.2.0
on darwin_amd64
+ provider registry.terraform.io/hashicorp/aws v4.12.1
+ provider registry.terraform.io/hashicorp/cloudinit v2.2.0
+ provider registry.terraform.io/hashicorp/helm v2.5.1
+ provider registry.terraform.io/hashicorp/kubernetes v2.11.0
+ provider registry.terraform.io/hashicorp/tls v3.3.0

Reproduction Code [Required]
Any code in the examples will exibit this behavior.
Steps to reproduce the behavior:
initialize and plan any configuration using this module.
Expected behavior
a plan/apply that does not present a warning message
Actual behavior
while all actions are still successful a warning message is presented about a Redundant ignore_changes element
Terminal Output Screenshot(s)

Additional context
the changelog for terraform 1.2.0 mentions this new warning message will be presented going forward.

We will have to investigate this further

Is this a tricky one? removing modifed_at from ignore_changes is not enough?

@sanarena Unfortunately, it is not enough because it will be different behavior for users using previous versions of Terraform (<1.2).
The problem is that currently, we don't know how to make the same code work for both Terraform ranges: >= 1.2 and < 1.2.

Terraform output (v1.2.1) claims that the statement has no effect, though, or is that incorrect?

│ Warning: Redundant ignore_changes element
│
│   on .terraform/modules/eks.eks/main.tf line 305, in resource "aws_eks_addon" "this":
│  305: resource "aws_eks_addon" "this" {
│
│ Adding an attribute name to ignore_changes tells Terraform to ignore future changes to the argument in configuration after the object has
│ been created, retaining the value originally configured.
│
│ The attribute modified_at is decided by the provider alone and therefore there can be no configured value to compare with. Including this
│ attribute in ignore_changes has no effect. Remove the attribute from ignore_changes to quiet this warning.

We will incorporate this change in v19.x

@bryantbiggs is it meaning that 19.x will require Terraform version to be 1.2 and above?

@bryantbiggs is there a way to check terraform version in the code and modify the ignore_changes this only if version >=1.2 or is that too dirty? this can be done temporarily i guess, until eventually everyone upgrades to 1.3 and we can apply a permanent "fix" in future releases of the module.

@bryantbiggs is there a way to check terraform version in the code and modify the ignore_changes this only if version >=1.2 or is that too dirty? this can be done temporarily i guess, until eventually everyone upgrades to 1.3 and we can apply a permanent "fix" in future releases of the module.

Unfortunately, no. There isn't any dynamic routes that I know of that would support this

After thinking about this a bit more, I think we can accommodate a change for this. PR is coming

This issue has been resolved in version 18.24.1 :tada:


Include MA option in First contact HCA SOP

Description of the task:
The contributor communication template for first contact, contains a reference to GDPR and that we can't directly wrangle data or metadata originating from living donors which has now changed. We should add the MA option in the template to ask contributors which route we should take.
Acceptance criteria for the task:

[ ] Update SOP

Change from

Please be aware that as per GDPR guidelines, we are not able to directly wrangle any metadata or data originating from living donors. If your project contains metadata or data originating from living donors, please refrain from sending us that information.

To:

Please be aware that as per GDPR guidelines, we are not able to directly wrangle any metadata or data originating from living donors and share openly through the HCA Data Portal.
We are currently piloting a managed access system on the HCA Data Portal. If your data is not suitable for open access publishing and you are interested in participating for the managed access pilot, please inform us.

Stall change until the first MA pilot completed.


docs: Improve instructions on adding Ionic to Cordova

Type: docs
Platform: all
See: http://ionicframework.com/docs/overview/#cordova
Forum post: http://forum.ionicframework.com/t/where-are-the-css-and-js-files-located/33157/4
Need to add some steps on how to actually get the CSS/JS files into an existing Cordova app.

I updated these docs https://github.com/driftyco/ionic-site/pull/320