[Fix] fix a bug that may cause compilation failure of dynamic voxelization when using GPUs with compute capability lower than 6.x

fix a bug that may cause compilation failure of dynamic voxelization when using GPUs with compute capability lower than 6.x
fix imperfection kernel code that may unintentionally discard valid points when input points count is larger than 50000 * 512 (nearly impossible though).

We just found that the CUDA kernel cannot successfully be compiled with CUDA 9.0. Does this PR fix this issue?

Hi, @ZwwWayne
Sorry I did not test the code on CUDA 9.0. I only tested it on 10.2 and 11.0 with no error.
Could you please share with me the specific compiler error? I will have a look into that and it won't take long.

Hi, @ZwwWayne
Sorry I did not test the code on CUDA 9.0. I only tested it on 10.2 and 11.0 with no error.
Could you please share with me the specific compiler error? I will have a look into that and it won't take long.

We also test the code on CUDA 10.1 environments and it seems to be OK. However, MMDetection3d still needs compatibility with CUDA 9.0 due to some reasons. So it would be nice if you could help and also fix that issue in this PR.
The screenshots of the error is listed below, @Tai-Wang may provide a more detailed log if necessary.

Thanks in advance.

Hi, @ZwwWayne
Sorry I did not test the code on CUDA 9.0. I only tested it on 10.2 and 11.0 with no error.
Could you please share with me the specific compiler error? I will have a look into that and it won't take long.

We also test the code on CUDA 10.1 environments and it seems to be OK. However, MMDetection3d still needs compatibility with CUDA 9.0 due to some reasons. So it would be nice if you could help and also fix that issue in this PR.
The screenshots of the error is listed below, @Tai-Wang may provide a more detailed log if necessary.
Thanks in advance.

It is really weird that from the log it seems all the errors occured when instantiating templates in PyTorch headers.
This PR will not fix this issue because this PR mainly deals with potential compiling errors on cuda arch<6.0, while you were using 6.1.
I don't have enough clue now and I am gonna test it with CUDA 9.0 on docker. It might take a couple of hours. Sorry for the delay.

Hi, @Tai-Wang
Which version of PyTorch did you use with CUDA 9.0? Looks like only versions no higher than 1.1 are compatible with CUDA 9.0. Did you build PyTorch from source?

@zhanggefan Yes, exactly. We use the pytorch 1.5 built from source. The compilation error does not exist in the previous released version and it seems to point to the "scatter" cuda file related to your PR.

Hi, @ZwwWayne
Sorry I did not test the code on CUDA 9.0. I only tested it on 10.2 and 11.0 with no error.
Could you please share with me the specific compiler error? I will have a look into that and it won't take long.

We also test the code on CUDA 10.1 environments and it seems to be OK. However, MMDetection3d still needs compatibility with CUDA 9.0 due to some reasons. So it would be nice if you could help and also fix that issue in this PR.
The screenshots of the error is listed below, @Tai-Wang may provide a more detailed log if necessary.
Thanks in advance.

It is really weird that from the log it seems all the errors occured when instantiating templates in PyTorch headers.
This PR will not fix this issue because this PR mainly deals with potential compiling errors on cuda arch<6.0, while you were using 6.1.
I don't have enough clue now and I am gonna test it with CUDA 9.0 on docker. It might take a couple of hours. Sorry for the delay.

LGTM. The failure might need further exploration.

@Tai-Wang It is really interesting that when compiling with pytorch1.5 and cuda9.0, NVCC cannot compile any code successfully if it includes "torch/extension.h". I am still trying to find out the root cause. But the workaround code will be ready soon.

@Tai-Wang It is really interesting that when compiling with pytorch1.5 and cuda9.0, NVCC cannot compile any code successfully if it includes "torch/extension.h". I am still trying to find out the root cause. But the workaround code will be ready soon.

OK. When your workaround is ready, I can help check it together.

This version can be compiled successfully with PyTorch1.5 on CUDA9.0, and pass the unit test on CUDA10.2. But I have not been able to test its functionality with CUDA9.0. Installing all the dependencies is a nightmare for me...

This version can be compiled successfully with PyTorch1.5 on CUDA9.0, and pass the unit test on CUDA10.2. But I have not been able to test its functionality with CUDA9.0. Installing all the dependencies is a nightmare for me...

How do you test the functionality with CUDA10? Just run some experiments using dynamic scatter? Could you please show an example or give me a standard benchmark, or could you please add some simple tests to validate it on CUDA9 devices?

This version can be compiled successfully with PyTorch1.5 on CUDA9.0, and pass the unit test on CUDA10.2. But I have not been able to test its functionality with CUDA9.0. Installing all the dependencies is a nightmare for me...

How do you test the functionality with CUDA10? Just run some experiments using dynamic scatter? Could you please show an example or give me a standard benchmark, or could you please add some simple tests to validate it on CUDA9 devices?

The pytest script is here:
https://github.com/open-mmlab/mmdetection3d/blob/ccd3047a1d62048cc5707e60181b2ab586b8e479/tests/test_models/test_voxel_encoder/test_dynamic_scatter.py

Please let me know if the test fails. I am not experienced with the torch extensions before CUDA 10 so I could not guarantee that code works as expected. For CUDA versions>=10 the torch/extension.h is the all-in-one header. But for CUDA9 I have to turn to those backend aten headers that I am not familiar with.

Please let me know if the test fails. I am not experienced with the torch extensions before CUDA 10 so I could not guarantee that code works as expected. For CUDA versions>=10 the torch/extension.h is the all-in-one header. But for CUDA9 I have to turn to those backend aten headers that I am not familiar with.

The compilation and installation is fine, but there is a RuntimeError for the gradcheck in the unit test. Here is the error message for your reference:
  File "tests/test_models/test_voxel_encoder/test_dynamic_scatter.py", line 59, in test_dynamic_scatter
    gradcheck(dsmean, (feats, coors), eps=1e-2, atol=1e-2, rtol=1e-5)
  File "/home/wangtai/anaconda3/envs/open-mmlab/lib/python3.8/site-packages/torch/autograd/gradcheck.py", line 281, in gradcheck
    analytical, reentrant, correct_grad_sizes = get_analytical_jacobian(tupled_inputs, o, nondet_tol=nondet_tol)
  File "/home/wangtai/anaconda3/envs/open-mmlab/lib/python3.8/site-packages/torch/autograd/gradcheck.py", line 156, in get_analytical_jacobian
    grads_input = torch.autograd.grad(output, diff_input_list, grad_output,
  File "/home/wangtai/anaconda3/envs/open-mmlab/lib/python3.8/site-packages/torch/autograd/__init__.py", line 156, in grad
    return Variable._execution_engine.run_backward(
RuntimeError: Expected isFloatingType(grads[i].scalar_type()) to be true, but got false.  (Could this error message be improved?  If so, please report an enhancement request to PyTorch.)

Please let me know if the test fails. I am not experienced with the torch extensions before CUDA 10 so I could not guarantee that code works as expected. For CUDA versions>=10 the torch/extension.h is the all-in-one header. But for CUDA9 I have to turn to those backend aten headers that I am not familiar with.

The compilation and installation is fine, but there is a RuntimeError for the gradcheck in the unit test. Here is the error message for your reference:
  File "tests/test_models/test_voxel_encoder/test_dynamic_scatter.py", line 59, in test_dynamic_scatter
    gradcheck(dsmean, (feats, coors), eps=1e-2, atol=1e-2, rtol=1e-5)
  File "/home/wangtai/anaconda3/envs/open-mmlab/lib/python3.8/site-packages/torch/autograd/gradcheck.py", line 281, in gradcheck
    analytical, reentrant, correct_grad_sizes = get_analytical_jacobian(tupled_inputs, o, nondet_tol=nondet_tol)
  File "/home/wangtai/anaconda3/envs/open-mmlab/lib/python3.8/site-packages/torch/autograd/gradcheck.py", line 156, in get_analytical_jacobian
    grads_input = torch.autograd.grad(output, diff_input_list, grad_output,
  File "/home/wangtai/anaconda3/envs/open-mmlab/lib/python3.8/site-packages/torch/autograd/__init__.py", line 156, in grad
    return Variable._execution_engine.run_backward(
RuntimeError: Expected isFloatingType(grads[i].scalar_type()) to be true, but got false.  (Could this error message be improved?  If so, please report an enhancement request to PyTorch.)

Looks like you switched to python 3.8 this time. What is the PyTorch and CUDA version this time?

I think it should be able to be compatible both with python 3.7 and 3.8, which is not a strong constraint for environment. Apart from python version, we use the same version of CUDA and pytorch built from source.

Just validate it with python 3.7 and get the same error message.

Just validate it with python 3.7 and get the same error message.

Error reproduced. The issue closely relates to the following discussion as well as an issue and a PR to PyTorch:
https://discuss.pytorch.org/t/custom-autograd-function-with-int-tensor-input/65907
https://github.com/pytorch/pytorch/issues/37680
https://github.com/pytorch/pytorch/pull/38326
Before this PR the Pytorch's auto-grad engine marks integer output as requires grad by default (for example marking indices tensors as require grad and for most cases, this does not make sense). This PR deals with it and has been merge into the master branch before Pytorch 1.6, so this issue cannot be reproduced with versions later than 1.6. Explicitly marking voxel_coors as non-differentiable could solve this issue.

@Tai-Wang
I managed to build up a very similar environment as yours (really lots of labor bro... and I'm really curious about the reason behind your environmental requirements of such a strange combination... hahaha):

1080Ti==sm6.1
cuda==9.0
nvdriver==450.80.02
pytorch==1.5 built from source
torchvision==0.6 built from source
mmcv-full==1.2.5

The last commit passed the gradcheck without error.

@zhanggefan Haha it is just due to many GPUs available for us are 1080Ti, so we are only able to use CUDA9 and pytorch built from source. Thanks for your contribution. It also works on my side and looks good to me.


rapids_cmake_install_lib_dir now aware of GNUInstallDirs improvements in CMake 3.22

Starting with 3.22, CMake is fully aware of the conda 'lib' requirements so we don't need todo all the conda checks ourselves.

rerun tests

rerun tests

@gpucibot merge


Come up with a Solution for Syncing Eventing CR Stream Replicas with NATS CR Replicas

Description
We should come up to solution whether we need to have eventing CR stream replicas and NATS CR replicas the same value.
We need to find out where one NATS node can have multiple stream replicas. If it cannot have we just have the same values for stream and NATS replicas.
Reasons
Currently, if NATS CR has one replica and eventing CR is created with 3 stream replicas, an error occurs.

If single node set stream replicas to 1 automatically, otherwise to 3, which means a user will not set this.


docs: fix typos in interop docs

What ❔
Typos in function name and comments are corrected.
Why ❔
Improve quality of documentation
Checklist

[ ] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[ ] Tests for the changes have been added / updated.
[x] Documentation comments have been added / updated.
[ ] Code has been formatted via zkstack dev fmt and zkstack dev lint.

Hi @kelemeno, I fixed some typo in the interop docs, could you please review it? thanks!


My script is always being called when the song starts, but this is not what I want.

Describe your problem here.
I want my lua event script to call whenever it is triggered in the chart editor, but it keeps triggering at the start of the song.
My script:
function onCreate()
	makeAnimatedLuaSprite('GATES', 'gate', -3000, -3500);
	addAnimationByPrefix('GATES', 'flow', 'gate', 24, true);
	objectPlayAnimation('GATES', 'flow');
	setProperty('GATES.scale.x', getProperty('GATES.scale.x') + 10);
	setProperty('GATES.scale.y', getProperty('GATES.scale.y') + 10);
end

function onEvent() -- this is what i want to start where i placed it to appear in the chart editor, but it is triggered when the song starts after the countdown
	addLuaSprite('GATES', true);
end

Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
Yes, but there are too many changes I made to summarize them.

Have you tried just having it create the sprites on the event, instead of at the beginning of the song?

thats what im asking, how do you do that?

You should just be able to copy the code from below the onSongStart function, and put it below the onEvent function but above the line that make the sprites.

onEvent is called for all events, if you don't check the event name it'll be called every time
This is why you use function onEvent(name, value1, value2 and if name == 'event name' then

Oh right, thank you for correcting me.

i realized i was missing an "=", but now its not doing anything.

Are you putting the name of your custom event?

Yes, the name is correct

Let me see the code. I'll see if I ca n do anything.

-- Lua stuff
function onCreate()
	makeAnimatedLuaSprite('GATES', 'gate', 0, 0);
	addAnimationByPrefix('GATES', 'flow', 'gate', 24, true);
	objectPlayAnimation('GATES', 'flow');
	setProperty('GATES.scale.x', getProperty('GATES.scale.x') + 10);
	setProperty('GATES.scale.y', getProperty('GATES.scale.y') + 10);
end

function onEvent(name, value1, value2)
	if name == 'GateFlow' then
		if value1 == 1 then
			addLuaSprite('GATES', true);
		elseif value1 == 0 then
			removeLuaSprite('GATES', true);
		end
	end
end

**the name of this event is "GateFlow"

Shouldn't it be, "addAnimatedLuaSprite"? Since you've made the rest of the sprite animated on the SongStart function.

makeAnimatedLuaSprite has always worked for me

Im just saying, you're making it make a normal lua sprite when the event is called, but since youre trying to make it animated, shouldn't it be called as an animated lua sprite?

doing either or hasnt change anything

Just so I'm clear, the two zeros in the first line of code are the coordinates, correct?

yeah, but they're "-3000, -3500" now, still not appearing

Try 990, 540. I got these from an event I use that makes an image flash on the screen.

that worked?????? i guess

Yeah. If the coords are in the thousands, they go off screen. And at 0, 0, I guess theyre also offscreen. Glad I could help some. Have fun with your mod.

value1 and value2 always return strings, you're comparing a string to an int so it will never be true
Use if value 1 == '1' then or if tonumber(value1) == 1 then


Typescript migration

Hi @stephomi
First of all I'm really impressed that you have made a sculpting program on pure JS which runs on every device smoothly
I've seen that you used a mix of es5 and es6. I already started a PR with upgraded webpack v4 and eslint + prettier and suddenly found your tweet that it has perf issues with using const and let.
I can say that i didn't noticed a really big issues (win10 chrome 72.0.3626.119) with let and const, but there was a little regression, like 5-10%.
However it's also possible to process all code through babel and get var.
Also I found some possible issues here
https://github.com/stephomi/sculptgl/blob/master/src/Scene.js#L628-L639
What mesh it returns? The last one from loop? Or somewhere from the upper scope?
And this one is interesting. Not sure that it was done on purpose
https://github.com/stephomi/sculptgl/blob/master/src/misc/getOptionsURL.js#L84
if (->tInt === tInt<- && tInt >= 10) key = tInt;

If you are interested in this, I could make a PR.
Also, it would be worth to make some tests, both unit and perf.
Perf tests could be done with puppetter but only chrome based. I think they might be useful.
Regarding the subject. There is a gazillion lines of code which is hard to understand at first glance and it's really easy to get lost which function or type is returning increasing chances to get cannot get property fu of undefined error.
Also, I have seen the C++ comparison. Maybe it's worth to implement the heaviest in terms of processing things using Assembly script?
It's almost same as typescript, it can reuse some bits of browser code (like constants) and it doesn't have any glue code. Some info here and here. I'm not an expert, but it seems to be a good choice using it along with typescript in project.
What do you think? I'm happy to help with all this, except linear algebra stuff 😅 but i'm keen to learn.
P.S. I have seen an issue somewhere here, that it would be awesome to have a native app for iOS using all variety of gestures it gives. I assume that it's possible to make it using React Native. All JS/Wasm logic could be reused across desktop, browser and mobile. When on mobile with RN it's possible to make bridges/bindings for native stuff like gestures.

maybe tInt === tInt is NaN checking

Hey, thanks for your interest!
Unfortunately, I'm not really active on sculptgl, except for a few quick experiments here and there.
The C++ version is closed source and will probably stay that way.

Also I found some possible issues here
https://github.com/stephomi/sculptgl/blob/master/src/Scene.js#L628-L639
What mesh it returns? The last one from loop? Or somewhere from the upper scope?

The last one from the loop, but the variable should indeed be declared outside the loop though (prettier should detect those normally).

And this one is interesting. Not sure that it was done on purpose
https://github.com/stephomi/sculptgl/blob/master/src/misc/getOptionsURL.js#L84

Cf @disjukr answer.

and suddenly found your tweet that it has perf issues with using const and let

Yep my tweet dates from 2016 and the issue doesn't exist anymore.
I still have my test pages, and the performance is the same:
https://stephaneginier.com/archive/testperf/indexLet.html
https://stephaneginier.com/archive/testperf/indexVar.html

I already started a PR with upgraded webpack v4 and eslint + prettier
If you are interested in this, I could make a PR.

As I said previously, I'm not active anymore on sculptgl so I would be wary PRs with lot of changes.
But if it's just a webpack+es6+eslint+prettier, I could definitely merge it (const/let is fine as well).
Ideally, I'd also like to remove electron from the package.json, I think it makes the initial checkout too big.
And there's also this part (https://github.com/stephomi/sculptgl/blob/master/package.json#L24-L27) which is probably not great because of paths (issues slash/antislash)

Also, it would be worth to make some tests, both unit and perf.

Agreed, but considering I don't plan on adding new features it would probably be overkill.

There is a gazillion lines of code which is hard to understand at first glance and it's really easy to get lost which function or type is returning increasing chances to get cannot get property fu of undefined error.

Yep it certainly misses documentation.
There're also parts of the code that are terrible from a usability pov (shader management).

Also, I have seen the C++ comparison. Maybe it's worth to implement the heaviest in terms of processing things using Assembly script?

Probably too big of a change for me!


Parse old, but valid syntax? E.g.: echo -a $dir='select dir' c:\

Talking about $dir and $hfile:
https://en.wikichip.org/wiki/mirc/identifiers/$dir
https://en.wikichip.org/wiki/mirc/identifiers/$hfile
Note: I havent included them for the moment...

This goes back to, whether or not to add deprecated identifiers/commands. I do think giving support to old scripts is a good thing. So we should add those, but they should have a lower priority.

Both of these have been added


Auto start not working,of you use Add Amnezia side-by-side with WireGuard

Describe the bug
A clear and concise description of what the bug is.
Smartphone (please complete the following information):

Device: nvidia shild pro 64 bit
Android Version: [droid 14/
App Version [e.g. prei release today

To Reproduce
Steps to reproduce the behavior:

Go to Add Amnezia side-by-side with WireGuard
Click on '....'
Scroll down to auto starten'
Reboot and is not common on

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots (Only if necessary)
Additional context
Add any other context about the problem here.

Hello! Can you describe more what is happening? There are some comments from other users in #149 about some values that may need to be switched around.

Okay, I'm going to adjust some parameters and see what happens

It Works on mobile, not on nvidia shield, I'll test it thoroughly, don't worry

There is a bug in the wg tunnel amnezia config.
I tested it only with my standard wg server and changed server config.
This is my amnezia config:
Jc = 100
Jmin = 10
Jmax = 1000
S1 = 0
S2 = 0
H1 = 1
H2 = 2
H3 = 3
H4 = 4
And this is what it looks like in wg tunnel:
Jc = 100
Jmin = 10
Jmax = 1000
H1 = 1
H2 = 2
H3 = 3
H4 = 4
I guess it doesn't like 0 as input, but without there can't be a connection.

Thanks for reporting this. I'll look into it!

This is confusing. zthe problem lies in Amnezia's lib where they are setting the value to empty if it is equal to zero.
public Builder setInitPacketJunkSize(final int initPacketJunkSize) throws BadConfigException {
            if (initPacketJunkSize < 0)
                throw new BadConfigException(Section.INTERFACE, Location.INIT_PACKET_JUNK_SIZE,
                        Reason.INVALID_VALUE, String.valueOf(initPacketJunkSize));
            this.initPacketJunkSize = initPacketJunkSize == 0 ? Optional.empty() : Optional.of(initPacketJunkSize);
            return this;
        }

        public Builder setResponsePacketJunkSize(final int responsePacketJunkSize) throws BadConfigException {
            if (responsePacketJunkSize < 0)
                throw new BadConfigException(Section.INTERFACE, Location.RESPONSE_PACKET_JUNK_SIZE,
                        Reason.INVALID_VALUE, String.valueOf(responsePacketJunkSize));
            this.responsePacketJunkSize = responsePacketJunkSize == 0 ? Optional.empty() : Optional.of(responsePacketJunkSize);
            return this;
        }

I can easily change this in my fork, but I'm wondering if this is a bug or is the desired behavior by Amnezia.

If you look at their post here: https://www.reddit.com/r/AmneziaVPN/comments/1c1gsvz/amneziawg_app_for_ios_and_android/ They say: 'Any change of S and H parameters to different from what we have written will not allow you to correctly use "obfuscation".' If I get this right, S = 0 is necessary. The only thing I also did was adding these values to my server. That was probably the reason that the entire connection could not be established.
I don't think this is a bug. I used your amnezia config mode with amnezia backend, but this solution should also work with the official wg app. So in theory if I use wg tunnel without anything amnezia related and just add the values to the config it should work. But I am not sure if wg tunnel really use these amnezia values then. (does it?) My thought is, if I also add these values to the server they are necessary so I get a sign if the clients config is wrong. But I am also not sure about this.
So in conclusion the best solution would be to just add an option to add the values to the regular wg config.

I will have to change Amnezia's code to allow for the value zero. This must be a bug in their code.


googler: 3.6 -> 3.7

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/googler/versions.
meta.description for googler is: '"Google Search, Google Site Search, Google News from the terminal"'.
Release on GitHub
Compare changes on GitHub

Checks done (click to expand)

built on NixOS
/nix/store/m4jcymfas16dyjl105gyy7ydfii7q7d8-googler-3.7/bin/googler passed the binary check.
1 of 1 passed binary check by having a zero exit code.
1 of 1 passed binary check by having the new version present in output.
found 3.7 with grep in /nix/store/m4jcymfas16dyjl105gyy7ydfii7q7d8-googler-3.7
directory tree listing: https://gist.github.com/2955278ba9e019e1530370c330e8825d
du listing: https://gist.github.com/97f331c3c2f15b4afb2b0cb7f7a19cab

Instructions to test this update (click to expand)

One-time optional setup to skip building using Cachix:

Install cachix from https://cachix.org/
Use r-ryantm's cache:cachix use r-ryantm

Test this update by entering a nix shell, seeing what is inside the
result, and if applicable, running some binaries:
nix-shell --pure -I nixpkgs=https://github.com/r-ryantm/nixpkgs/archive/3e5adb42f93c4e7d13f054bd986775bd8aac9ac8.tar.gz -p googler
ls -la /nix/store/m4jcymfas16dyjl105gyy7ydfii7q7d8-googler-3.7

cc @k0ral for testing.

Success on x86_64-darwin (full log)
Attempted: googler
Partial log (click to expand)
install -m644 googler.1.gz /nix/store/2famy0wwmnpcar45m4qw6isinifca87p-googler-3.7/share/man/man1
install -m644 README.md /nix/store/2famy0wwmnpcar45m4qw6isinifca87p-googler-3.7/share/doc/googler
rm -f googler.1.gz
post-installation fixup
gzipping man pages under /nix/store/2famy0wwmnpcar45m4qw6isinifca87p-googler-3.7/share/man/
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/2famy0wwmnpcar45m4qw6isinifca87p-googler-3.7/bin
patching script interpreter paths in /nix/store/2famy0wwmnpcar45m4qw6isinifca87p-googler-3.7
/nix/store/2famy0wwmnpcar45m4qw6isinifca87p-googler-3.7/bin/googler: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/dlswl7xjvh3bsfydygqzi2n0f82p5d9p-python3-3.6.6/bin/python3"
/nix/store/2famy0wwmnpcar45m4qw6isinifca87p-googler-3.7

Success on x86_64-linux (full log)
Attempted: googler
Partial log (click to expand)
rm -f googler.1.gz
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/m4jcymfas16dyjl105gyy7ydfii7q7d8-googler-3.7
gzipping man pages under /nix/store/m4jcymfas16dyjl105gyy7ydfii7q7d8-googler-3.7/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/m4jcymfas16dyjl105gyy7ydfii7q7d8-googler-3.7/bin
patching script interpreter paths in /nix/store/m4jcymfas16dyjl105gyy7ydfii7q7d8-googler-3.7
/nix/store/m4jcymfas16dyjl105gyy7ydfii7q7d8-googler-3.7/bin/googler: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/hy65mn4wjswqih75gfr6g4q3xgqdm325-python3-3.6.6/bin/python3"
checking for references to /build in /nix/store/m4jcymfas16dyjl105gyy7ydfii7q7d8-googler-3.7...
/nix/store/m4jcymfas16dyjl105gyy7ydfii7q7d8-googler-3.7

Success on aarch64-linux (full log)
Attempted: googler
Partial log (click to expand)
rm -f googler.1.gz
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1l0pxxw69cmd7jdqhjqhikmw0mvi85ka-googler-3.7
gzipping man pages under /nix/store/1l0pxxw69cmd7jdqhjqhikmw0mvi85ka-googler-3.7/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1l0pxxw69cmd7jdqhjqhikmw0mvi85ka-googler-3.7/bin
patching script interpreter paths in /nix/store/1l0pxxw69cmd7jdqhjqhikmw0mvi85ka-googler-3.7
/nix/store/1l0pxxw69cmd7jdqhjqhikmw0mvi85ka-googler-3.7/bin/googler: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/sb88r9crdhinhkm6vpxwzf5zmij86p8v-python3-3.6.6/bin/python3"
checking for references to /build in /nix/store/1l0pxxw69cmd7jdqhjqhikmw0mvi85ka-googler-3.7...
/nix/store/1l0pxxw69cmd7jdqhjqhikmw0mvi85ka-googler-3.7


Update cardDetails.json

why i can finish this pull request

Hi @Clau050994
Thanks for contributing! But you PR have some issues we'll have to fix before your PR is merged.
You edited the card details template which you're not supposed to edit. Kindly follow the instructions and add your details just as seen in the carddetails.json file. Thanks!


Add section for for how to run Varnish

Add docs for running Varnish with CIAB.
Closes: #7724

Which Traffic Control components are affected by this PR?

Documentation

What is the best way to verify this PR?

This is documentation.
PR submission checklist

[ ] This PR has tests
[x] This PR has documentation
[ ] This PR has a CHANGELOG.md entry
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

after #7746


[Bug]: Receive "Unexpected Application Error!" on localhost:3000

Is there an existing issue for the same bug?

[X] I have checked the troubleshooting document at https://opendevin.github.io/OpenDevin/modules/usage/troubleshooting
[X] I have checked the existing issues.

Describe the bug
When running docker using:
ghcr.io/opendevin/opendevin:main
around 2 days it stops working and when I enter localhost:3000 I'm getting the following

Here's devtools:

and terminal logs:

I'm using MacOs with M1
Current OpenDevin version
main on commit 9434bcce4880dda390209633dc5cb307c2b499d8

Installation and Configuration
export WORKSPACE_BASE=$(pwd)
export LLM_API_KEY="OPEN_AI_API_KEY"

docker run \
        -it \
        --pull=always \
        -e LLM_API_KEY \
        -e SANDBOX_TYPE=exec \
        -e SANDBOX_USER_ID=$(id -u) \
        -e WORKSPACE_MOUNT_PATH=$WORKSPACE_BASE \
        -e HF_HOME=~/code/self/.cache \
        -v $WORKSPACE_BASE:/opt/workspace_base \
        -v /var/run/docker.sock:/var/run/docker.sock \
        -p 3000:3000 \
        --add-host host.docker.internal:host-gateway \
        ghcr.io/opendevin/opendevin:main

When I'm switching to 0.5 it works fine.

Model and Agent
default
Operating System
Macos
Reproduction Steps
Just run it on the commit I specified.
Logs, Errors, Screenshots, and Additional Context
around 2 days it stops working and when I enter localhost:3000 I'm getting the following

Here's devtools:

and terminal logs:

Duplicate of #2087

It works; it's probably some browser's cache issue.


Enhancement proposal: no date in file?

Hi,
i have a proposal, where i also want to create a pull request later. if the results file is generated, a date is also generated. this does not help if i commit my results file to the git, but nothing changes. this also is problematic in a pipeline way, because i always have to filter the date.
i want to propose a flag, which on use does not generate a date in scan or audit. :) i will create a pull request of the weekend.

i am currently reading your source code and instead of adding a commandline parameter i am beginning to think it makes more sense to add a date plugin. because:

from using i know that rescanning the git repository changes the date

when you want to merge your old baseline and your new baseline and at one point no date was generated, that can make merging difficult

if you make a plugin in from it you could account for scan and audit and new findings/removals if you want and if the plugin/the architecture supports it

Anyway before that, i would rather argue that you should remove your generated_at attribute. This will be already documented when you add the baseline file to the git repository, so in that regard it is redundant.
and if you always rescan your repository for whatever reason and do not generate a permanent baseline which you audit on(though that could be an antipattern which should be documented to be avoided), the attribute will hinder the diff between the new and old scan.

This is somewhat of a duplicate issue of https://github.com/Yelp/detect-secrets/issues/92
I'm okay with getting rid of it, but a --no-generated-at flag also seems less contentious given the stale discussion in that issue. So your PR idea for the flag seems great.
See also https://github.com/Yelp/detect-secrets/pull/295, as it is somewhat related to your comments. A date plugin doesn't make much sense to me, plugins are used for detecting certain types of secrets, and that's all they should be used for IMO.

hm, then what would one do with the merge process when the no-generated-at is used earlier or later in the scan process? or do we just add an alternative attribute like  no-date-here, when the first baselinefile is created, so that later no date is added? i will have to look at the merging code.

My thinking of how it would work is: Whenever the tool is called with that flag, no generated_at field would be present. So in the merging code we could check if the flag was present, and then not output it.

Can we add this feature please?


Implement JSON string escape in pure-awk (several orders of magnitude faster)

I've got a very pathological branch of a certain repository where this makes a parallelized (four concurrent invocations) generation change from ~3 minutes down to ~13 seconds.
I did not implement \b or \f because I don't think the chances of them occurring naturally in a text document (especially a Dockerfile) in 2022+ are very high. :sweat_smile:
(Also, this isn't required to be pure JSON, but rather "jq compatible" as it's used as jq syntax so we have a little bit more wiggle room as jq is more forgiving than a pure strict parser)

Codecov Report

Merging #48 (9f6a357) into master (92ab34b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   76.83%   76.83%
=======================================
  Files           5        5
  Lines         587      587
=======================================
  Hits          451      451
  Misses        104      104
  Partials       32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92ab34b...9f6a357. Read the comment docs.

Just running ./apply-templates.sh on PHP takes ~2 minutes currently and ~6 seconds with this change.


Question: How does one reference Windows SDK APIs?

Perhaps this is more a documentation issue than anything.
In .NET Core 3.1, I could use Windows SDK APIs simply by including a PackageReference to Microsoft.Windows.SDK.Contracts and running dotnet build.
Now with .NET 5, I'm trying to do the same using CsWinRT, but am seeing a viral expansion of requirements in the CsWinRTIncludes tag of my csproj file.
Minimal repro: https://github.com/stevedesmond-ca/CsWinRT-repro -- I would expect this to compile on dotnet build, as it does in 3.1 (adding <OutputType>Exe</OutputType> and removing the CsWinRT reference).
The only class actually used is Windows.Devices.WiFi.WiFiAdapter, but trying to build the code as-is then requires me to add everything that WiFiAdapter references. Doing that then requires I add everything that each of those classes reference.
The same is true if I use namespaces instead of classes in CsWinRTIncludes: I basically end up requiring the entire Windows SDK surface.
What am I missing (either technically in the csproj or theoretically in my understanding)?

@stevedesmond-ca With .NET 5, we build the Windows SDK projection generated using CsWinRT and distribute it as a package which the .NET SDK has a reference to.  If you were to use the .NET 5 Windows SDK specific TFMs like net5.0-windows10.0.19041.0, you would get an implicit reference to that projection package and be able to use the Windows SDK APIs like WifiAdapter.  You don't actually need to reference the Microsoft.Windows.CsWinRT package or the Microsoft.Windows.SDK.Contracts package unless you are looking to build your own CsWinRT projection for your own component.

So for Windows SDKs, the big change for .NET 5 is that they only work with the Windows TFM? Which means I would now need different projects for Windows vs Linux, where I could previously just switch on the platform ID within the same project?

@stevedesmond-ca yes with .NET 5, you now access Windows APIs using the TFM instead of needing a package reference. These docs have more information on .NET 5 + OS-specific TFMS: https://docs.microsoft.com/en-us/dotnet/standard/frameworks#net-5-os-specific-tfms
Specifically,

To make your app portable across different platforms but still have access to OS-specific APIs, you can target multiple OS-specific TFMs and add platform guards around OS-specific API calls using #if preprocessor directives.

Thanks for the info!


Fixes #586 : Remove content of AccountsActivity.AccountViewPagerAdapt…

The problem appeared when switching to Recent or Favorites Account Tab and then opening another Book.
The problem did not appear when switching to "All" tab, then opening another book, even having open Recent or Favorites tab before "All" tab.
The Exception was thrown in DatabaseAdapter.getID() by the line :
throw new IllegalArgumentException(mTableName + " with GUID " + uid + " does not exist in the db");
because the uid has been built from cursor given in AccountRecyclerAdapter.AccountsListFragment.onBindViewHolderCursor(AccountViewHolder, Cursor), which is a cursor on the previous Book and this uid does not exists in the newly opened Book.
I fixed the issue in (7b6ebb398c89459ffe479d519ee5a69db2449ae9) by removing the content of AccountsActivity.AccountViewPagerAdapter.destroyItem().
I don't know why this fixed the problem, but I found it by discovering that destroyItem() was not called when switching to "All" Tab, but was when switching to Recent or Favorites Tab.

@JeanGarf Can you make a build with your improvements? This project looks dead.

After having done #876, I restore state as before #586 (in 1e2d83acbd8eb0c9b96d6b1e49dd326ee0a7befc) and it seems to be OK.
So I remove this pull request.

@JeanGarf Can you make a build with your improvements? This project looks dead.

Yes I can.
Where can I do that ?

You know what, I'll set up an f-droid repo for your version using github actions. I need a couple of other forked apps built anyway which nobody is managing automated builds for.

I've set up a repo here (https://madushan1000.github.io/fdroid-repo/repo/), I can configure it to do automated builds for each commit to your repo if you can configure a webhook.

Hi madushan1000,
Sorry, I didn't saw your post and therefore, I added a page on my web site to allow downloading of the apk with all my contributions (my 10 Pull Requests. See #841)
http://thierryw777.free.fr/index.php/bureautique/comptabilite/gnucash-android/
If you're interested to test or use it, tell me if it works fine.
See you


Bluetooth hub disconnects during firmware flash on MacOS

The error is observed on the following setup:
OS: Apple M1 Pro, 14.4.1 (23E224)
Python: 3.10.4
Firmware: https://nightly.link/pybricks/pybricks-micropython/workflows/build/master/technichub-firmware-build-3343-git46f29c09.zip
pybricksdev: v1.0.0a46
Running: pybricksdev flash with the given firmware causes the error:
Creating firmware...
Searching for TECHNIC hub...
Found: DF4BFD20-FC05-F0E9-3AFD-8A9E3DAF5A90: LEGO Bootloader
Connecting to DF4BFD20-FC05-F0E9-3AFD-8A9E3DAF5A90: LEGO Bootloader
Connected successfully!
Erasing flash and starting update
  1%|█▏                                                                                | 2.21k/200k [00:30<45:56, 71.9B/s]
Traceback (most recent call last):
  File "/Users/ld/.pyenv/versions/3.10.4/bin/pybricksdev", line 8, in <module>
    sys.exit(main())
  File "/Users/ld/.pyenv/versions/3.10.4/lib/python3.10/site-packages/pybricksdev/cli/__init__.py", line 383, in main
    asyncio.run(subparsers.choices[args.tool].tool.run(args))
  File "/Users/ld/.pyenv/versions/3.10.4/lib/python3.10/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/Users/ld/.pyenv/versions/3.10.4/lib/python3.10/asyncio/base_events.py", line 646, in run_until_complete
    return future.result()
  File "/Users/ld/.pyenv/versions/3.10.4/lib/python3.10/site-packages/pybricksdev/cli/flash.py", line 472, in flash_firmware
    await flash_ble(hub_kind, firmware, metadata)
  File "/Users/ld/.pyenv/versions/3.10.4/lib/python3.10/site-packages/pybricksdev/cli/flash.py", line 327, in flash_ble
    await updater.flash(firmware, metadata)
  File "/Users/ld/.pyenv/versions/3.10.4/lib/python3.10/site-packages/pybricksdev/flash.py", line 241, in flash
    result = await self.bootloader_request(
  File "/Users/ld/.pyenv/versions/3.10.4/lib/python3.10/site-packages/pybricksdev/flash.py", line 160, in bootloader_request
    await self.write(data, request.write_with_response)
  File "/Users/ld/.pyenv/versions/3.10.4/lib/python3.10/site-packages/pybricksdev/ble/__init__.py", line 149, in write
    await self.client.write_gatt_char(
  File "/Users/ld/.pyenv/versions/3.10.4/lib/python3.10/site-packages/bleak/__init__.py", line 659, in write_gatt_char
    await self._backend.write_gatt_char(char_specifier, data, response)
  File "/Users/ld/.pyenv/versions/3.10.4/lib/python3.10/site-packages/bleak/backends/corebluetooth/client.py", line 332, in write_gatt_char
    await self._delegate.write_characteristic(
  File "/Users/ld/.pyenv/versions/3.10.4/lib/python3.10/site-packages/bleak/backends/corebluetooth/PeripheralDelegate.py", line 192, in write_characteristic
    await future
bleak.exc.BleakError: disconnected

This issue currently makes PyBricks unavailable for the given OS/chip combo due to neither Chromium nor pybricksdev working.

If you have any other Bluetooth devices connected to your Mac, I would turn them all off and try again.
If that doesn't fix it, we would need Bluetooth packet logs to help troubleshoot. (see https://bleak.readthedocs.io/en/latest/troubleshooting.html#macos)


Update predefined cluster roles to consider all important CAPI CRs

rbac-operator creates a number of "predefined" cluster roles when it first runs on a cluster (those in defaultnamespace controller). These cluster roles give access to specific groups of resources, e.g. write-nodepools should give access to machinepools and everything related.
Some of these cluster roles are quite outdated and do not give access to all related CRs defined in CAPI clusters.
We have to check which CRs are currently not covered and update the existing cluste roles accordingly.

I have created a list of all CRs in the cluster.x-k8s.io group, that are on at least one of our CAPA MCs.

crd
clusterrole

awsclustercontrolleridentities

awsclusterroleidentities

awsclusters
write-clusters

awsclusterstaticidentities

awsclustertemplates

awsfargateprofiles

awsmachinepools

awsmachines

awsmachinetemplates

awsmanagedclusters

awsmanagedcontrolplanes

awsmanagedmachinepools

azureclusteridentities

azureclusters
write-clusters

azureclustertemplates

azuremachinepoolmachines

azuremachinepools
write-nodepools

azuremachines
write-clusters

azuremachinetemplates

azuremanagedclusters

azuremanagedcontrolplanes

azuremanagedmachinepools

clusterclasses

clusterresourcesetbindings

clusterresourcesets

clusters
write-clusters

eksconfigs

eksconfigtemplates

extensionconfigs

ipaddressclaims

ipaddresses

kubeadmconfigs

kubeadmconfigtemplates

kubeadmcontrolplanes

kubeadmcontrolplanetemplates

machinedeployments
write-nodepools

machinehealthchecks

machinepools
machinepools

machines

machinesets

providers

vsphereclusteridentities

vsphereclusters

vsphereclustertemplates

vspheredeploymentzones

vspherefailuredomains

vspheremachines

vspheremachinetemplates

vspherevms

Next, I will investigate the CRs that are not yet covered by any cluster role.

I talked to @anvddriesch and we came to the following conclusion:
The cluster roles that manage access to CAPI-related resources are write-nodepools and write-clusters.
In vintage those managed access to cluster or nodepool-related resources like cluster, machinedeployment, etc...
However, in CAPI, all those resources are managed through the cluster-apps (e.g., cluster-aws). For example, to create a new nodepool, you would not create a new resource but edit the values of the cluster app.
Therefore, the only access necessary would be to create/delete cluster-apps and modify their config values.
However, one might also want to view the resources created by the cluster-apps which would require read access to those.
As this is closely related to UX, I would like to bring this to SIG-UX for discussion on how the UX vision is in general for creating/modifying CAPI clusters.

We talked about this in Sig UX sync and came to the following conclusion:

I will investigate how many customers use write-nodepools and write-clusters separately
The underlying problem is about how we manage fine-grained control over cluster and cluster-related components in CAPI. We think that discussing this is important as we don't want to remove useful features going from vintage to CAPI.
I will bring this to Sig Product sync.

I've checked the following installations:

akita
alpaca
anaconda
anchovy
anteater
antelope
anzu
argali
bandicoot
buffalo
cuckoo
eagle
flamingo
fox
gaggle
gaia
gauss
giraffe
glippy
goku
golem
goku
golem
gollum
gopher
gorilla
gremlin
grizzly
kudu
leopard
potato
snail
valkyrie
viking
visitor

For each of those the only reference of write-nodepool and write-clusters was a cluster role binding for the automation service account in the default namespace.
Therefore, there is no evidence of anyone using write-nodepools and write-clusters separately.

@gawertm I just realized that for the next two weeks, I cannot make it to Sig product sync. Is this something you could bring there?
Summary of what I want to talk about:
In vintage we two cluster roles write-nodepools and write-clusters. These give access to cluster and nodepool related resources respectively. With these roles you can therefore create clusters and nodepools. Because the two roles are separate, it was possible to let someone only create nodepools, but not clusters.
In CAPI this will be more difficult, because you create clusters and nodepools only through the cluster-app and its configmap.
The question is whether we still want to keep providing these separate cluster roles. They were meant to be used by customers.
As stated in the above comment, in all installations that I checked write-nodepool and write-clusters were always used together. Furthermore, those roles were only bound to the automation ServiceAccount in the default namespace, which I think is also created by rbac-operator. Therefore, no one uses them manually.

sure, lets discuss (maybe in refinement tomorrow). maybe we can decide as bigmac, otherwise I'll bring it to sig product

outcome of refinement:
we want to check if we can remove the two roles and maybe include the permissions in another role that is bound to the Automation SA, if not already existing. this will be for vintage,
for CAPI this is different anyways and we wont need the two roles anymore as they are not used in any case

The cluster roles write-clusters and write-nodepools are removed from rbac-operator.
In addition, I did a clean-up, because removing them from rbac-operator won't remove them from the MCs.
All installation expect

guppy
icecream
are cleaned.

I couldn't log in to these two.


fix: update sha for building images

in cargo-package.nix

Erroneous sha introduced by #959.

bors merge


Vouchers - Download links not working

Cannot download csv/pdf of voucher batches
<Error>
NoSuchKey
<Message>The specified key does not exist.</Message>
<Key>cCBWcNEtTjUP-FLhPDh6cQ.pdf</Key>
<RequestId>84878A7748389025</RequestId>
<HostId>
xCLasNxc1ADLPQO8eauVBo8MVqxnK41Q98Q1BBvUKnE3CEg735UO9cGGUox9IO+hmeIiBxbFnxo=
</HostId>
</Error>

Should be fixed in forthcoming build @ZakMooney.

works locally, not on production though...

Build now deployed, links created however the password seems to be missing.

@ZakMooney Think you might want to tell the customer who raised this that it's resolved.


Autofocus search input

Added one line to application.js to autofocus filtering input so user can start typing instantly.

Travis build failes on Ruby 1.8.7 because CI server tries to use new version of rake which supports only Ruby 1.9.3 and higher. Should I set proper version of rake in Gemfile?

@hedgesky I’ve fixed this is master. Can you please rebase and force push your branch?

Done.

Hello!
Are there any things to do before merging this to master?

Hi!
Let me remind you about this PR once again 🙂

:wave:
Thanks for the ping, seens semi taking over some maintenance duties I ahven't really gotten to the formatter yet. Appologies and merge :)


Pandigital prime

Solve Problem 41: Pandigital prime on Project Euler
Make a directory whose name is your Github username. Move your solution to that folder. Also a screenshot of your submission.
Move that directory to Problem41 directory in the ProjectEuler directory.
For eg. location of my solution would be /ProjectEuler/Problem41/MJ10/

Look up the CONTRIBUTING.md Document to see how to push your code to GitHub.

Issue closed, end of Hacktoberfest!


Update README.md

fixed doc link ( http -> https ) .

Coverage remained the same at 95.052% when pulling 1c32b5616d41f05dadddd4ab8bd0092f53dbc827 on lanqy:master into 1d8bf81dc6e35581a6626edce891b23811dbfc7e on Vincit:master.

Coverage remained the same at 95.052% when pulling 1c32b5616d41f05dadddd4ab8bd0092f53dbc827 on lanqy:master into 1d8bf81dc6e35581a6626edce891b23811dbfc7e on Vincit:master.

Coverage remained the same at 95.052% when pulling 1c32b5616d41f05dadddd4ab8bd0092f53dbc827 on lanqy:master into 1d8bf81dc6e35581a6626edce891b23811dbfc7e on Vincit:master.

Coverage remained the same at 95.052% when pulling 1c32b5616d41f05dadddd4ab8bd0092f53dbc827 on lanqy:master into 1d8bf81dc6e35581a6626edce891b23811dbfc7e on Vincit:master.

Thanks!


Deep links do not open [android] [dapp browser]

Describe the bug
I'm trying to open something like “https://t.me/joinchat/F_BETUjG0Crb2s6mFx1LWA” from a page inside the dapp browser, but instead of launching the telegram app, the browser stalls for over 30sec and eventually opens a Google search query of an invite link (not even the original link) as- "tg:join?invite=F_BETUjG0Crb2s6mFx1LWA".
To Reproduce
Go to any page with a telegram link and try to open it from the dapp browser. For instance, https://opengsn.org/
Expected behavior
A page should pop up saying "Open in telegram". The user should be able to click the link and the telegram app should open.
Additional context
The "Open in Telegram" page shows for a brief moment right before the dapp browser hijacks it and displays the google search query.

@vikmeup
Maxim has commented  that this feature was disabled by security reasons.
https://github.com/trustwallet/android/issues/3875#issuecomment-765362830
Also I checked iOS. Telegram deep link handling is disabled in dApp browser.

@vikmeup
Maxim has commented  that this feature was disabled by security reasons.
https://github.com/trustwallet/android/issues/3875#issuecomment-765362830
Also I checked iOS. Telegram deep link handling is disabled in dApp browser.


cw/geo errors

geo: Unpacks internal errors using the IsFastlyError helper.

go.mod: use go 1.20 for comparable constraint
geo: use IsFastlyError helper to improve error messages

@joeshaw PTAL, I think I've addressed the feedback.


Replace nedb with mongo

Adds MongoDB driver instead of NeDB.
Still has NeDB as a dependency in order to perform a one time migration of the contents of the database from the storage file to Mongo.

The tests are currently blocked on https://github.com/nodkz/mongodb-memory-server/issues/289 so they've been removed from CI for now, with local testing being carried out by me.


not receiving notification of data messages on cellular data network, background.

Hi
I have start with messaging example
It works good when mobile connected via WiFi
But after I switch to Mobile (Cellular) data internet, close app, close mobile and the FCM stop to work,
since other similar Apps ( facebook messanger, etc. ) continue to receiving data
What happens ? what should I do ?

@armennazaretyan this is not enough information to help you debug.  FCM works fine on both cellular or WiFi networks.  I'd suggest looking at #4 or #89 and seeing if there's anything there to help you.


Peng/230 unit tests for common

Created unit tests for common components from NiDataLoading.vue to NiHardwareState.vue. I learned a lot about Jest and vue-test-utils APIs through this. I created some of the first slot tests for Vue components with slots. Closes #230
Heads up - I updated vue-test-utils from 1.0.0-beta.6 -> 1.0.0-beta.8 because it supports classes(). It also deprecates hasClass. I've made the following change to the relevant tests:
// old
    expect(wrapper.find('.ni-li-tx').hasClass('ni-li-tx-received')).toBe(true)
// new
    expect(wrapper.find('.ni-li-tx').classes()).toContain('ni-li-tx-sent')

@jolesbi I've also started converting some of the component CSS to BEM, as that naming scheme provides more clarity than what we've been using.

One note: the tests snapshot are not readable.
Finding: expect(wrapper.vm.$el).toMatchSnapshot() also produces good output.


dwmblocks has 2 volume % indicator

would love to remove this but ive installed the dwm from aur
fresh from larbs install...
would love if you could patch this up and push to aur...

solution
I think the one without off is the correct one, as alsa doesn't have a off status, when its muted its set to 0 ... :) but not quite sure :) either way both work


feat(client): Create helper functions for challenge tests available across curriculum challenges

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

This PR attempts to create a set of utility functions that can be used across all curriculum tests.
Goals Achieved:

Able to get rid of all of the Before / After Test sections that only existed for the sole purpose of using in a curriculum file's tests.
Create tested functions that test writer's can trust will work when ever used.
Clean up existing textStrings in tests by not having to define the functions within the textStrings

To Do Before Merging:

Conclude if where I currently stored these helper functions (client/src/utils) is the best place for them.
Need to figure out how to use @babel/standalone instead of @babel/parse and @babel/generate.  (@ojeytonwilliams to help here)
Figure out if this needs to be lazy-loaded (@ojeytonwilliams to help here)
Update the existing documentation to include a reference to trying to use the helper functions whenever possible.

Dynamically importing Babel is causing problems.  Not sure why, but doing that means I have to target webworkers for the test evaluator and web for the framer-runner.  When importing statically that was not necessary.
However, since it only gets imported in the challenges, I think a static import is fine.  To avoid duplicate downloads, I'll see if I can get Gatsby and the runner/worker to use the same bundle.


Feature Request: set amount of buffering

Hi there,
I'm implementing mediaelement.js in a known closed Wi-Fi offline environment. Therefore for some network control it would be great to have more buffering options. Like being able to set a max-buffer at start, or having acess to network bandwith and setting the buffer dynamically.
Thank you,
Christian

@chriho Closing old issues. If you'd like to reopen this, let us know. Thanks!


Plugins developer guide2

@MoFoGo I know we use Netlify, so I assume we have the option to view this branch on the docs like it is already in production. Do you know how we can view it? Maybe all checks should pass to see the link?


Add quotes around search query

This PR adds quotes around a search query, to make it easier to grep on strings that contain spaces.

The lack of quotes is intentional to allow options to be specified on the command line (-i for example).
In fact, this PR does not pass the CI tests.


ChatSample no worky

The sample is not really functional right now, it runs but things like registering a user doesn't work.
If fixing everything is too much work, maybe we should just replace it with a simple Chat Hub like the one described here:  https://blogs.msdn.microsoft.com/webdev/2018/02/27/asp-net-core-2-1-0-preview1-getting-started-with-signalr/
I can submit a PR slimming it down to simple chat app like that if we want, since I just followed that walkthrough

Hrm, I was able to register and login just fine. The JavaScript code is a bit out of date, but I'm fixing that in #2050 . Can you clarify what errors you were seeing?

Hrm, so when I tried, I was able to register, but login didn't work, it would just redirect back to the login page, and it would display all of the cookies under the external login page.  I can try again tomorrow to see if its still doing what I was seeing

I could have been doing the flow wrong, I didn't actually try just directly going to the chat url after registering

It's possible that there is an issue with logging in. All I did was register and then was immediately logged in.


safe math

All the ones in the audit are done and some extras due to the new dev
also optimised using fold as its a little quicker i think.

failures are due to benchmarks


Anything else I need to know?

Seems go was also a prerequisite, and not just git, docker and chrome. After figuring that out, trying to instal sail using your docs, I get:
can't load package: package go.coder.com/sail: cannot find package "go.coder.com/sail" in any of:
	/usr/local/go/src/go.coder.com/sail (from $GOROOT)
	/Users/frdo/go/src/go.coder.com/sail (from $GOPATH)

Hey @Magistern, thanks for trying out Sail and sorry about the missing docs on the installation process.
I'll open a PR to update the docs with more details about installing with go.
In the meantime, you should be able to install the sail binary through our releases page.
So that I can better understand the issue you're facing with the go installation, could you respond with the output of go env?

No the original poster, but I have the same issue as @Magistern and my go env shows:
 go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/stratos/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/mnt/data/projects/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/lib/go"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build906226595=/tmp/go-build -gno-record-gcc-switches"

Thanks for sending that over, can you try go get -u go.coder.com/sail to see if that fixes it? I think the docs are incorrect on the installation. Let me know if that fixes the issue and I'll update the docs accordingly.
  That failed!  Then I tried under /mnt/data/projects/go/src/github.com/cdr/ and that failed too.
I was getting:
➜ go install
repo.go:10:2: cannot find package "github.com/google/go-github/v24/github" in any of:
        /usr/lib/go/src/github.com/google/go-github/v24/github (from $GOROOT)
        /mnt/data/projects/go/src/github.com/google/go-github/v24/github (from $GOPATH)
project.go:13:2: use of internal package go.coder.com/sail/internal/browserapp not allowed
codeserver.go:18:2: use of internal package go.coder.com/sail/internal/codeserver not allowed
editcmd.go:15:2: use of internal package go.coder.com/sail/internal/dockutil not allowed
editcmd.go:16:2: use of internal package go.coder.com/sail/internal/editor not allowed
hat_builder.go:14:2: use of internal package go.coder.com/sail/internal/hat not allowed
editcmd.go:17:2: use of internal package go.coder.com/sail/internal/randstr not allowed
editcmd.go:18:2: use of internal package go.coder.com/sail/internal/xexec not allowed

I never understood how go is doing it's package management, so I stopped trying to be smart about it and tried $HOME/src, which DID work, after downloading a ton of dependencies I have NO idea where they went.
I now have a sail under my /mnt/data/projects/go/bin/, and sail --help properly displays the command line params.
No time to properly test-drive this now, but after a rough installation process I should be able to start doing so now.  Phew....

how do you get sail to be a recognized command in Terminal? There's no info on that.
I can find sail in my ~/go/bin/ folder and run it using ./sail but that doesn't help the Chrome browser plugin.

I see you're on macos and I'm in linux, but I bet your ~/go/bin is not in your PATH. Maybe that would help with the chrome extension too (I have not tried it yet)

Probably, then perhaps that should go in the installation instructions as well...
How do I do it?

Well, that is part of the installation instructions when you install go.  Once again, not sure about macos but you should edit some .bashrc file? on your home directory and append the ~/go/bin to an export PATH=/some/path;/another/path definition?
Which brings us back to your original issue, that go is a prerequisite for this tool.

Hey @Magistern, you need to have $GOPATH/bin added to your $PATH as stratosgear mentioned.
Also, go isn't a dependency to sail, only if you want to install it from source and mess with the source code. I'll update the docs again to specify installing that way isn't recommended unless you're actually changing the source.
It's recommended that you install it from the releases page if you just want to use the tool.

https://superuser.com/questions/284342/what-are-path-and-other-environment-variables-and-how-can-i-set-or-use-them

Thanks. I guess Sail is for super users :D

Lol, sorry for the painful setup experience you had. We've taken a lot of measures in the past day to ensure a more user friendly setup experience. Thanks for submitting the issues and helping us determine where our docs and process were lacking. I hope things are smoother for you now with the more recent updates.

Excellent work on that part. Sail is installed and I can view the manual sail --help
All that remains now is to be able to use it as well.
trying sail run cdr/code-server ends with
Status: Downloaded newer image for codercom/ubuntu-dev-node12:latest
2019-05-22 23:16:42 INFO	writing sail proxy logs to /var/folders/1s/w4r5xtt95nl3q50r1j4l7pn00000gp/T/sailproxy_cdr_code-server865899265
2019-05-22 23:16:53 ERROR	failed to wait for project to be online: context deadline exceeded
+ cd /home/user/code-server
+ sudo chown -R user:user /home/user/.vscode
2019-05-22 23:16:53 ERROR	build run failed: context deadline exceeded

and the log file above says:
2019-05-22 23:16:42 INFO	listening on http://<IP_ADDRESS>:54583
2019-05-22 23:16:53 FATAL	failed to refresh code-server port: failed while trying to find code-server port: Get http://localhost:32773: EOF

But perhaps I should put that in a new issue?

@nhooyr seems like this might be an issue with the reverse proxy

Not an issue with the reverse proxy. The container failed to start. If you do a docker ps -all then take the id of the container and plop it into docker logs <id>, it should show you why.

How large is your ~/.vscode/ directory? I wonder if the chown -R user:user /home/user/.vscode is taking longer than the 10 second timeout

We should print out the docker log when it fails to start anyway.

How large is your ~/.vscode/ directory? I wonder if the chown -R user:user /home/user/.vscode is taking longer than the 10 second timeout

630M

uninstalled a bunch of extensions now and got a new error:
128M/Users/frdo/.vscode/
128M	total
macfrdo: extensions frdo$ sail run cdr/code-server
2019-05-23 08: 31: 28 INFO	using default image codercom/ubuntu-dev-node12: latest
2019-05-23 08: 31: 28 INFO	ensuring image codercom/ubuntu-dev-node12: latest exists
latest: Pulling from codercom/ubuntu-dev-node12
Digest: sha256: 587ef9bdcb39f9edec99034726cd379683646de7f089896257dee97c4f0a0894
Status: Image is up to date for codercom/ubuntu-dev-node12: latest
2019-05-23 08: 31: 30 INFO	writing sail proxy logs to/var/folders/1s/w4r5xtt95nl3q50r1j4l7pn00000gp/T/sailproxy_cdr_code-server320250593
2019-05-23 08: 31: 41 ERROR	failed to wait for project to be online: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
+ cd/home/user/code-server
    +sudo chown-R user: user/home/user/.vscode
2019-05-23 08: 31: 41 ERROR	build run failed: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

It appears that your docker daemon isn't running. Can you validate by trying to run docker run hello-world? See docker for mac

It says:
Hello from Docker!
This message shows that your installation appears to be working correctly.

Can we repoen this issue as it does not seem to be solved?

Also, @Magistern can you try to run sail now? Sometimes, there is a permission problem with the docker daemon upon initial installation. If you have logged out, and back in, the problem could potentially be fixed.

I'll restart the computer and try again then. See you soon.

nah, still the same error:
2019-05-23 22:21:13 INFO	using default image codercom/ubuntu-dev-node12:latest
2019-05-23 22:21:13 INFO	ensuring image codercom/ubuntu-dev-node12:latest exists
latest: Pulling from codercom/ubuntu-dev-node12
Digest: sha256:587ef9bdcb39f9edec99034726cd379683646de7f089896257dee97c4f0a0894
Status: Image is up to date for codercom/ubuntu-dev-node12:latest
2019-05-23 22:21:15 INFO	writing sail proxy logs to /var/folders/1s/w4r5xtt95nl3q50r1j4l7pn00000gp/T/sailproxy_cdr_code-server909453300
2019-05-23 22:21:18 INFO	loaded code-server in 3.471843835s
2019-05-23 22:21:29 ERROR	failed to wait for project to be online: context deadline exceeded
+ cd /home/user/code-server
+ sudo chown -R user:user /home/user/.vscode
2019-05-23 22:21:29 ERROR	build run failed: context deadline exceeded

This is different than the second error that you provided, but the same as the first. Let's see what we can do here...
Do you have the latest version of sail? If so, can you provide me with sail version?

$ sail version
Usage: sail [GLOBAL FLAGS] COMMAND [COMMAND FLAGS] [ARGS....]

A utility for managing Docker-based code-server environments.
More info: https://github.com/cdr/sail

[project] can be of form <org>/<repo> for GitHub repos, or the full git clone address.

sail flags:
	--config	Path to config.	(/Users/kojo/.config/sail/sail.toml)
	--install-autocomplete	Install autocomplete	(false)
	--uninstall-autocomplete	Uninstall autocomplete	(false)
	-v	Enable debug logging.	(false)

Commands:
	run	Runs a project container.
	shell	shell drops you into the default shell of a repo container.
	edit	This command allows you to edit your project's environment while it's running.
	ls	Lists all containers with the com.coder.sail label.
	rm	Remove a sail container from the system.
	install-for-chrome-ext	Installs the chrome native message host manifest.

is there another way of figuring out?

That just means that you are not on the latest version (which provides more detailed error messages).
Can you run this for me:
curl sail.dev/install.sh | bash

Then I get this:
$ curl sail.dev/install.sh | bash
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

it didn't update right?

I did this curl https://sail.dev/install.sh | bash instead and now...
IT WORKS! Heureka 😄

@Magistern Glad you worked it out. The reason the first command didn't work is because sail.dev tried to redirect you to https. You should never curl a non HTTPS url and pipe it into bash, always use https otherwise you're opening yourself up to a MITM attack.

😳 Oh, thanks for the advice

ah, that's true. My bad.

Thank you all for bearing with me. Btw, how do you stop it?

Stop the sail instance?


Investigate TN contraction precompilation latency

Some users have notified that the first contraction of a TensorNetwork takes a huge amount of time due to compilation.

The source of compilation time seems to come from 2 sources:

OMEinsum uses dynamic dispatch with runtime-generated Val values, that's why first contraction always takes so much time
do blocks and closures need always to be runtime compiled due to its dynamic scope


WebTauUiFeaturesTest failures

I'm getting the following failure:
[ERROR] Failures:
[ERROR]   WebTauUiFeaturesTest.forms:162->runCli:256 matches:

testDetails.exitCode:   actual: 1 <java.lang.Integer>
                      expected: 0 <java.lang.Integer>
testDetails.scenarioDetails[4].stepsSummary.numberOfSuccessful:   actual: 2 <java.lang.Integer>
                                                                expected: 3 <java.lang.Integer>

extra values:

testDetails.scenarioDetails[4].stepsSummary.numberOfFailed: 1
[INFO]
[ERROR] Tests run: 40, Failures: 1, Errors: 0, Skipped: 0

Running the forms test locally, I see this in the report:
java.lang.AssertionError:
mismatches:

value:   actual: "12016-02-06" <java.lang.String>
       expected: "2016-06-21" <java.lang.String>

The assertion that produces this is:
scenario('values validation') {
    form.name.should == 'Full Automation'
    form.rank.should == 'B'
    form.startDate.should == '2016-06-21'
}

Could this be a locale issue?  The start date is set as follows:
form.startDate.setValue('06/21/2016')

On a London laptop that probably results in it setting it to the 21st month...

should be closed by #321. Please give it a go.

It is, thanks!


Adding working changes for CSCC API integration

This is a PR for direct integration between Forseti and Cloud Security Command Center (CSCC). The violations from Scanner can now be written directly into CSCC via its REST API.
@blueandgold I made some small tweaks to the format of the finding, in "_transform_findings_for_cscc()", and tested to ensure this works. I did not add unit tests yet, based on our discussion.

I signed it!

LGTM, thank you for doing this!  This will be super useful for integration with CSCC.  I will tweak it with some clean-ups and add unit tests.

Adding cla: yes label, as the PR author has ack'd signing the CLA.


Evaluation Exception: Index was outside the bounds of the array.

Hello, I am using your repo and my custom setting. I got 0.34LB for SGD. I changed to Adam and encoded submission again. However, when I submit to the system, I got the error:

Evaluation Exception: Index was outside the bounds of the array.

I think your code has some bug in somewhere in the inference that output size does not match with original size or other reasons.
This is my submission file
submission.csv.zip

@John1231983 I've spotted this one for myself too.
Let's check: you've achieved 0.34LB using this repo and it worked properly?

Sorry. I have check again. It above 0.32 after 50 epcho. I think it may be better if I run more but your code is too slow due to you turn off the multiple processing flag

I think I know the issue. It may be you did not take argmax of a pixel if they maintain two predictions. It is known as remove mask function in the original mask rcnn implementation.
You can refer the code function numpy2encoding_no_overlap2 in the https://github.com/YanWang2014/Mask_RCNN/blob/master/Spot-Nuclei2/val_test2.py

@John1231983 it should be something else, because I handle that case here https://github.com/killthekitten/kaggle-ds-bowl-2018-baseline/blob/master/inference.py#L49.
Could you change the code to @YanWang2014's and check in your local setup? Appreciate it.

Hi. I have change it and it worked. So, I guess that your problem from the above reason

@John1231983 Could you share the fix in a separate PR? Thanks!

Sure. I will update it

Sorry. I don't know why I cannot make the separate PR. Could you check the diff in this one and modify your code https://github.com/John1231983/kaggle-ds-bowl-2018-baseline

@John1231983 thanks, I'll handle it from here :+1:


fix: param bug in test_binary_ops_aten

Description
Fixed a param bug in test_binary_ops_aten. The param is required to be a tuple instead of a single value.
Fixes # (issue)
Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the style guidelines of this project (You can use the linters)
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas and hacks
[ ] I have made corresponding changes to the documentation
[ ] I have added tests to verify my fix or my feature
[x] New and existing unit tests pass locally with my changes
[x] I have added the relevant labels to my PR in so that relevant reviewers are notified

Looks good to me! Were these tests getting skipped before?

I think so. Not sure why they were skipped in CI


Download Azubu.tv and "event not found"

root@install:~# sudo youtube-dl -F http://www.azubu.tv/Faker#!/play/25892/skt-faker-march-25th-2015
-bash: !/play/25892/skt-faker-march-25th-2015: event not found

It's the newest version
root@install:~# youtube-dl --version
2015.03.28

The exclamation mark in the URL is being interpreted by bash. Enclose the URL in single quotes, to avoid bash interpreting it:
youtube-dl 'http://www.azubu.tv/Faker#!/play/25892/skt-faker-march-25th-2015'

Also, youtube-dl doesn't require root privileges, so please avoid running youtube-dl as root, unless when updating.


Update README.md

Update quaireaux naming to alexandria

@Pet3ris
Didn't even see as it was automatically redirecting to the new link, good catch!
Should be good to go, now


Transcode failure on iOS 17

I am raising this for visibility and in hopes others have found a solution.
Our users are reporting random failures of basis transcode on iOS 17.0.
It looks likely a regression in safari, I have reported the issue here:
https://bugs.webkit.org/show_bug.cgi?id=260252
Since iOS 17 is now released we may be forced to find a workaround.

Having test a little more, it's the call to file.transcodeImage on the final/smallest mipmap level which fails:

only in basis format (ktx2 seems fine)
compressed with ETC
with no alpha channel
larger images seem to fail more often (128x128 don't fail, 256x256 fail 1 in 10, 512x512 1 in 2, etc)

To reiterate, these failures are likely to be an issue with Safari 17 WASM engine, but we are trying to find a possible mitigation from our end.

Seem like you have found workaround for this problem: https://forum.playcanvas.com/t/important-basis-on-safari-17-0/33145
We found that recompiling the basis module with the latest emscripten toolchain seems to mitigate the issue

@richgel999 Can you update a version compiled with latest emscripten toolchain?

@richgel999 Can you update a version compiled with latest emscripten toolchain?

Yes - no problem.


[Minor] Update Readme

This PR will fix the bad link in the current README (due to the renaming of lmquant -> deepcompressor).
We will direct users to the v0.0.0 version (which is the fixed branch for the original lmquant) so there should be no change in the QServe codebase.


FW actuator_controls_2 parachute interferes with gimbal (vmount)

When trying to use a gimbal (vmount) on FW or VTOL there are multiple actuator_controls_2 publishers.

https://github.com/PX4/Firmware/blob/8b3716c0df292ddda71a6114d55ad9df2e7ff37d/src/modules/fw_att_control/FixedwingAttitudeControl.cpp#L854

At a minimum the parachute needs to be moved to not interfere with the gimbal.

Is anyone actually using parachute on control group 2?

Right now I think nobody is really using it.

https://github.com/PX4/Firmware/pull/8907

Hey, this issue has been closed because the label more_info_needed is set and there were no updates for 30 days. Feel free to reopen this issue if you deem it appropriate.
(This is an automated comment from GitMate.io.)

DO_SET_SERVO is publishing on this too:
https://github.com/PX4/Firmware/blob/8a8cc3b52b45c12078c7c655c3b29c6f5511b7f6/src/modules/navigator/mission_block.h#L138
https://github.com/PX4/Firmware/blob/8a8cc3b52b45c12078c7c655c3b29c6f5511b7f6/src/modules/navigator/mission_block.cpp#L449

FYI @bresch

Having the same problem now too. Controlling gimbal with AUX channels does not work for fixed wing/VTOL. How expensive would it be to create non-interfering control groups? Like one for only gimbal. One for external servos. And control group 6 for parachute. This would give a lot of freedom if you only have to create custom mixer files.
This could be also used to cleanup a few parameters. For example "TRIG_PINS" could be handled by a camera control group. RC_MAP_AUX# could be handled by a RC passthrough control group.

Having the same issue as well.


NoClassDefFoundError

I try to implement this library to my project, i've followed all the step but when I run my project get me a NoClassDefFoundError
12-01 09:05:53.760 E/AndroidRuntime(25347): java.lang.NoClassDefFoundError: com.danielstone.materialaboutlibrary.adapters.MaterialAboutListAdapter$1
12-01 09:05:53.760 E/AndroidRuntime(25347): 	at com.danielstone.materialaboutlibrary.adapters.MaterialAboutListAdapter.(MaterialAboutListAdapter.java:141)
12-01 09:05:53.760 E/AndroidRuntime(25347): 	at com.danielstone.materialaboutlibrary.MaterialAboutActivity.initViews(MaterialAboutActivity.java:88)
12-01 09:05:53.760 E/AndroidRuntime(25347): 	at com.danielstone.materialaboutlibrary.MaterialAboutActivity.onCreate(MaterialAboutActivity.java:55)
I hope someine can help me

More information please!

I've update the comment

Thanks. Could you leave a copy of your build.gradle here as well so that we can check if there are any issues with setup.

Here is it
build.txt

A few things:

Why is your compileSdkVersion 21?
Have you tried updating to AndroidX and using the latest release of the library?

I'm using AIDE for compile my projects
Yes, but when i use the latest version I have problems with AndroidX libraries

Can I use version 2.2.5 with new layout design ?

Nope, but it looks very similar.
Can you confirm that it doesn't work when you change all the v25 support libraries to 28.0.0 https://developer.android.com/topic/libraries/support-library/revisions

Yep, it does not work

I try to use 2.4.0support library version but I get error that can not found dependency

Closing due to inactivity


3.1rc (js) regression: writing to property of a global variable redefines entire variable type

TypeScript Versions:  3.1.0-rc.20180911, 3.1.0-dev.20180914
Not an issue in 3.1.0-dev.20180831 (bisected to #26908)
Search Terms:
does not exist global write module
Code
// test.js
const INPUT = process.argv;
process.env.ENV_VAR = 'val';

module.exports = INPUT;

Run tsc --noEmit --allowJs --checkJs with @types/node available (see below for a non-node example).
Expected behavior:
No error.
Actual behavior:
error TS2339: Property 'argv' does not exist on type 'typeof process'.
Not a problem in typescript code. When all the example lines are present, the definition and type definition of process now point to the process.env.ENV_VAR line instead of to @types/node.
To get the bug, either module.exports needs to be set or a file needs to be required or imported, so I assume it being a module is important. Writing to anything on process seems to trigger it, not just a sub-property (so e.g. process.env = {ENV_VAR: 'val'}; would also trigger the bug, though probably not a good idea in real code :).

bisecting leads to #26908.
It seems to occur for any globals, e.g.
window.name = '55';
window.console.log(5); // error TS2339: Property 'console' does not exist on type 'typeof window'.

module.exports = 'anything';

It looks like issue #27057 may be the same issue, but it's difficult to tell from the description there (I haven't cloned and run the project given in the example).

Notably, doesn't happen in Typescript.

Repros on 3.0 with an expando initializer, like window.name = {}. The bug is more visible now that initializers aren't required to be more visible. The core of the problem is in iniitalizeTypeChecker:
if (!isExternalOrCommonJsModule(file)) {
  mergeSymbolTable(globals, file.locals!);
}

CommonJS modules should still merge with globals, because, in JS, the compiler allows undeclared identifiers to act as namespaces in exactly the way assignment to window works.


Document CSS Inline Formatting Context

Request type

[ ] Please close this issue, I accidentally submitted it without adding any details
[x] New documentation
[ ] Correction or update

Details
Submitted over on Bugzilla https://bugzilla.mozilla.org/show_bug.cgi?id=904680

From here: https://developer.mozilla.org/en-US/docs/Web/CSS/Visual_formatting_model

Follow the 'inline formatting context' link to https://developer.mozilla.org/en-US/docs/CSS/Inline_formatting_context 404s.

So, I think this is a bigger job as that page on the Visual Formatting Model really needs rewriting.
This page is describing the model defined in CSS2. Level 3 specs do still refer to this definition, for example if we look for the definition of the inline formatting context in Display Level 3 we read,

"Block and inline formatting contexts are defined in CSS 2.1 Section 9.4."

I'm going to finish up writing about the inline formatting context as it is useful to have, but I'll add another ticket regarding reworking the visual rendering page.

First draft here https://developer.mozilla.org/en-US/docs/Web/CSS/Inline_formatting_context

Hi Rachel!
This is mostly looking really good. I gave it a light copy edit, and added some headings to give the article a bit more structure. I just had one comment:

"If there is a float within the same block formatting context however, the float will cause the line boxes that wrap the float to become shorter."

In this example below this line, wouldn't it be a good idea to not set a width on the floated box, so that it doesn't look like it is just the width causing the line boxes to become shorter?

In this example below this line, wouldn't it be a good idea to not set a width on the floated box, so that it doesn't look like it is just the width causing the line boxes to become shorter?

maybe, but typically floated things have widths, I don't see why the width is an issue as it's not on the containing block.

Also, having the width, with this being a live example, allows them to change the width on the float and see the change to the line boxes. Which seems useful.

OK, good points. In that case I'm happy to change this to done.


Blank screen upon launching program

OS:
Windows 10 Anniversary
Issue Descriptions:
3.6.0 blank screen upon launching program
Steps to Reproduce:
Open program.
I saw other threads regarding this dating back to May but didn't see any resolution from the dev. I want to use your program but cannot. Also, 3.5.0 keeps auto-updating which is a hassle.

but didn't see any resolution from the dev

The only way an issue gets closed is if I (the dev as you put it) close them.  All those issues have resolutions, whether it be update your drivers.  Lack of information from the reporter or a resolution was found through a Chromium update.
I would suggest attempting all of the above and trying the latest betas from the CI machines.
https://ci.appveyor.com/project/MarshallOfSound/google-play-music-desktop-player-unofficial/branch/master

Dev wasn't an insult! I'm sort of new to this github thing so I don't understand that big page of code. the only chromium i'm familiar with is the browser. i updated that and the load screen on GPM Desktop won't get past the 1/4 mark.

Latest AppVeyor build still exhibits crash behavior for me.

Latest AppVeyor build still exhibits crash behavior for me.

Same here

Also, 3.5.0 keeps auto-updating which is a hassle.

You can delete the update.exe. The program will stop trying to update itself. That's what I did and now I can use the 3.5.0 without any problems.

But you really should manual Update then because if google decides to
Change something on the UI of GPM that breaks 3.5.0 you wont receive auto
updates then.
itroy187<EMAIL_ADDRESS>schrieb am Di., 11. Okt. 2016, 10:43:

Also, 3.5.0 keeps auto-updating which is a hassle.
You can delete the update.exe. The program will stop trying to update
itself. That's what I did and now I can use the 3.5.0 without any problems.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/issues/1734#issuecomment-252849263,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMCBvP3rmmxxhvYnPwlrMxVDdJHZXVh3ks5qy0w8gaJpZM4KQU7s
.

--
Matjas

But you really should manual Update then because if google decides to Change something on the UI of GPM that breaks 3.5.0 you wont receive auto updates then.

True. This should just be temporary solution until the bug is fixed.


[Improvement]Add Unit Test for CloudController (#13695)

[Improvement]Add Unit Test for CloudController (close #13695)

@caishunfeng Hello, I want to ask for help on merge. I want to add a UT, but an error is reported, saying that the label is fail. What is the reason?

Hi, @beatCao You can ignore the Mergeable label check, which requires a committer to add for this PR.

Contributor

Thank you very much, because the progress of the PR is stagnant, I just need to wait for a commit to add, right?

Hi, @beatCao DS uses spotless to fix the code style, could you please run ./mvnw spotless apply before committing the code.
FYI: https://dolphinscheduler.apache.org/zh-cn/docs/3.1.3/contribute/development-environment-setup

Hi, @beatCao DS uses spotless to fix the code style, could you please run ./mvnw spotless apply before committing the code.
FYI: https://dolphinscheduler.apache.org/zh-cn/docs/3.1.3/contribute/development-environment-setup

Can we run spotless apply in our ci and fix the code style issue by bot instead of by hand, for our contributors? @rickchengx @EricGao888

Hi, @beatCao DS uses spotless to fix the code style, could you please run ./mvnw spotless apply before committing the code.
FYI: https://dolphinscheduler.apache.org/zh-cn/docs/3.1.3/contribute/development-environment-setup

Can we run spotless apply in our ci and fix the code style issue by bot instead of by hand, for our contributors? @rickchengx @EricGao888

@zhongjiajie No. Spotless cannot convert wildcard imports import * into specific imports automatically at this moment. Also, we have rules to ban powermock, junit4 with Spotless. If the CI automatically runs apply , it will remove those stuff and cause compilation failure.

@EricGao888 please check again，Thank you


"RNMonthPicker" was not found in the UIManager using Expo

Hey,
First of all thanks for creating this datepicker.
I am using the following packages:
Expo: "expo": "^39.0.3"
"react-native": "^0.63.2"
I have installed the package using:
npm install react-native-month-year-picker --save
As per my knowledge there is no linking/autolinking in a managed expo project so the quesiton is how can i make it work?
When i tap on the button to show the datepicker i get the following error:
"RNMonthPicker" was not found in the UIManager
Many thanks,
Trix

Hey @lvegh! Thank you for using the library. Unfortunately, Expo does not support libraries with nagive code. With Expo, you write just JavaScript and a set of native APIs that the Expo team maintains and upgrades. I leave you here a link to Expo documentation on third-party libraries for future reference: https://docs.expo.io/workflow/using-libraries/#determining-third-party-library-compatibility


test: fix wording for isDai tests

Description of the Changes
Fixes wording for tests of the isDai function. The test titles should mention dai as opposed to eth.
Checklist

[ ] Changes have been done against dev branch, and PR does not conflict.
[ ] Manually tests of the main Application flows are done and passed.
[ ] New unit / functional tests have been added (whenever applicable).
[ ] Automation tests are passing in local environment.
[ ] Docs have been updated (whenever relevant).
[x] PR title is follow the Conventional Commits convention: <type>[optional scope]: <description>, e.g: fix: prevent racing of requests

This change is

:tada: This PR is included in version 1.9.0-dev.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.9.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


loggerd: new class FFmpegEncoder

do ffmpeg encoding and remuxing in class FFmpegEncoder

Is there any immediate benefit to this?  In addition to that, we need as much comma three data as we can get, so we can't ship a subtly broken logger for a release.
Currently, we have offline checks that run on incoming data to track logger quality, but those metrics lag the actual changes we make since so few people run master and many don't run the latest commits. We may be able to start considering stuff like this once all those checks are also run in openpilot CI. We'd merge PRs that only add tests (#22095) and possibly minor refactors to support those tests.

The main purpose of this pr is  to write test cases for ffmpeg encoding and remuxing. I have found several problems through this refactor. I will submit the fix separately.


Separate searchTx and searchTxById in launchpad and stargate

Right now we include a "search by ID" query as one of the query types in the searchTx method of both the launchpad and stargate clients. But searching by ID is different to other kinds of searches because it should never return more than one transaction and search filters don't really make sense. We should separate this functionality out into a separate method in both packages.

Makes sense to handle this cases separately