Fix area around bottom tab avatar isn't clickable

Details

The are around the bottom tab avatar isn't clickable.
Fixed Issues

$ https://github.com/Expensify/App/issues/38369
PROPOSAL: https://github.com/Expensify/App/issues/38369#issuecomment-1998877292
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

A.

Click/press around the area of the bottom tab avatar
Verify that it opens the settings page

B.

Click/press around the area of the bottom tab FAB
Verify the FAB menu is visible
Click/press again around the area of the bottom tab FAB
Verify the FAB menu closes
Hover over the area of all the 3 bottom tab menus (Chats, FAB, and Profile)
Verify the tooltip shows

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/50919443/cb2b9528-8e3f-466e-8bfc-ce1a6bc8d09a

Android: mWeb Chrome

https://github.com/Expensify/App/assets/50919443/756ec51a-c97c-4409-b3b4-77180be3c692

iOS: Native

https://github.com/Expensify/App/assets/50919443/20e6ca72-d489-466c-bf76-3c5744e340da

iOS: mWeb Safari

https://github.com/Expensify/App/assets/50919443/6680ce8c-e92e-4cc2-9035-157baf8fddb1

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/50919443/efb51d73-0961-428e-8ae9-5c9dff925cbc
https://github.com/Expensify/App/assets/50919443/ef89caad-dff0-4dd9-abee-acc83cb14836

MacOS: Desktop

https://github.com/Expensify/App/assets/50919443/4b2f189f-510d-4344-a1cb-5e53e799ca36
https://github.com/Expensify/App/assets/50919443/33899e3a-58ff-44b4-b13a-38e6180135fe

@bernhardoj yep if you can fix that here too happy with $500

Found the issue. When we press the area around FAB, isCreateMenuActive value is false.
https://github.com/Expensify/App/blob/e9c112a2b89217401dfef3e248fa8e93d4c4e418/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js#L142-L147
That is because, in PopoverProvider, we have a click listener that will close a popover, except if the popover anchorRef is the same as the element that we click.
https://github.com/Expensify/App/blob/e9c112a2b89217401dfef3e248fa8e93d4c4e418/src/components/PopoverProvider/index.tsx#L37-L44
FAB currently has 2 pressable and the anchorRef is set to the inner pressable.
https://github.com/Expensify/App/blob/e9c112a2b89217401dfef3e248fa8e93d4c4e418/src/components/FloatingActionButton.tsx#L106-L120
So, if we press the outer pressable, the PopoverProvider will close the FAB menu then the FAB click (toggleCreateMenu) will be executed which will show the popover again.
We can fix it by only having the outer pressable and replacing the inner one with an animated view, but the problem that comes after that is the tooltip won't hide when the popover is visible.
https://github.com/Expensify/App/assets/50919443/a3e4b58a-4feb-4d16-9a8c-3b7b62ce5c7f
That's because PopoverAnchorTooltip will only hide the tooltip if the children of the tooltip are the popover anchor ref element, which in our case is not because we wrap the tooltip to the inner animated view.
https://github.com/Expensify/App/blob/e9c112a2b89217401dfef3e248fa8e93d4c4e418/src/components/Tooltip/PopoverAnchorTooltip.tsx#L11-L16
What if we move the tooltip to the outer pressable, it will look like this:
https://github.com/Expensify/App/assets/50919443/0da9bd94-134b-4d7f-9b46-8fd794a2f1ba
@paultsimura @mountiny

What if we move the tooltip to the outer pressable, it will look like this:

Personally I would be okay with that, I think it's fine. Curious if @Expensify/design agrees!

Yeah, I'm okay with that as well 👍

@paultsimura Great. Updated the code and test.

Oh, we got a TS error because of renaming the PressableAvatarWithIndicator to ProfileAvatarWithIndicator

What should we do here?

no problem, continue with the review

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

The JS file was renamed

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.54-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.54-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Using laravel octane cannot use custom domain name

What happened?
I tried to follow this https://laravel.com/docs/11.x/octane#frankenphp-via-docker, but it did not work when I access the site, https://api.myapp.local, Unable to connect.
I am using docker windows
FROM dunglas/frankenphp:latest

#https://github.com/exaco/laravel-octane-dockerfile/blob/main/FrankenPHP.Dockerfile reference ni

RUN apt-get update && apt-get install -y \
    curl \
    supervisor \
    && apt-get clean \
    && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*

#ENV NVM_DIR /home/${GetMyUsername}/.nvm
# Add additional PHP extensions here:
RUN install-php-extensions \
    pdo_mysql \
    gd \
    intl \
    zip \
    opcache\
    pcntl

# Install Composer
RUN curl -sS https://getcomposer.org/installer | php -- --install-dir=/usr/local/bin --filename=composer

COPY . /app

ENTRYPOINT ["php", "artisan", "octane:frankenphp"]

services:
      php:
        container_name: frankencontainer
        build:
            context: .
            dockerfile: ./docker/web.dockerfile
        image: frankenimage

        ports:
            - "80:80" # HTTP
            - "443:443" # HTTPS
            - "443:443/udp" # HTTP/3

        volumes:
            - caddy_data:/data
            - caddy_config:/config
            - ./:/app
        entrypoint: php artisan octane:frankenphp --max-requests=1 --host=api.myapp.local --port=80   --admin-port=2019 --https
        environment:
            - SERVER_NAME=api.myapp.local

            ```

### Build Type

Docker (Debian Bookworm)

### Worker Mode

Yes

### Operating System

Other (tell us more in the description)

### CPU Architecture

x86_64

### PHP configuration

```shell
none

Relevant log output
Unable to connect

You need to specify the domain name in the options: php artisan octane:frankenphp --host=my-domain-name --port=80 (add --https and change the port to 443 to enable HTTPS).

@dunglas
Thanks, my container is spinning up, but I have problem when I check that octane is working by checking

am I missing something?
I also added to the .env
OCTANE_SERVER=frankenphp
OCTANE_HTTPS=true

Thank you in advance


Allow cross architecture docker builds with docker buildx

Is your feature request related to a problem? Please describe
I want to be able to build docker images with leeway that can target ARM64 cpus, without needing to switch to an ARM machine in development
Describe the behaviour you'd like
An option to specify target architecture for docker which can make use of the docker buildx extension. Leeway already allows specifying GOARCH to compile go binaries for ARM64 targets, a similar feature for docker builds would also be extremely helpful
Describe alternatives you've considered
Running the entire build on an ARM machine. I would assume that this would lead to the build automatically being created for an ARM target
However, this would require both devs and CI pipelines to switch/add a new machine to their workflows to build for ARM

Hi @kushal-ti, is this related with Gitpod self-hosted?

Yes, it is

This is not doable right now.


fix use-after-free for HTTP 100 Continue case

Scope & Purpose
Fix use-after-free error and wrong behavior for HTTP 100 Continue case.

[x] Bug-Fix for devel-branch (i.e. no need for backports?)
[x] Strictly new functionality (i.e. a new feature / new option, no need for porting)
[x] The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)

Testing & Verification
This change is a trivial rework / code cleanup without any test coverage.
https://<IP_ADDRESS>/view/PR/job/arangodb-matrix-pr/7112/

https://<IP_ADDRESS>/view/PR/job/arangodb-matrix-pr/7113/


Fix offloading saved tensor interaction with checkpointing

Context
What is the purpose of this PR? Is it to

[ ] add a new feature
[x] fix a bug
[ ] update tests and/or documentation
[ ] other (please add here)

Please link to any issues this PR addresses.
Hopefully fixes #1867 once and for all
Needs https://github.com/pytorch/pytorch/pull/139109 to land!
Changelog
What are the changes made in this PR?

Fixes checkpoint interaction with offloading. Prior, if an unpacked tensor is cached by activations checkpointing as a saved variable, it may be freed too early. This PR uses hooks (not currently in core yet, so we'll have to wait for that) to be able to coordinate this save properly.
I should also add a test case, but that'll take me a while to contrive lol.

Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.

[x] run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
[ ] add unit tests for any new functionality
[ ] update docstrings for any new or updated methods or classes
[ ] run unit tests via pytest tests
[ ] run recipe tests via pytest tests -m integration_test
[ ] manually run any new or modified recipes with sufficient proof of correctness
[ ] include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example

[ ] I did not change any public API
[ ] I have added an example to docs or docstrings

Closing in favor of #1936


Use 1ES pools in all pipelines

Also set vmImage where missing

@allenjzhang IIRC, you did this before and reverted some of them but I do not recall the reason for the revert. Is that right? Do you remember why we reverted if so?

I think there was some issue with the wrong version of visual studio available preventing the packaging of of hte visual studio extension(or something like that)
But guessing that if hte PR ci is passing now this has been resolved. We should just watch that the main branch CI doesn't fail after merging.

@mikeharder no the fact that the PR is passing I think is a good enough sign to me that it was resolved.


Shoppe (Rails) App: "uninitialized constant Shoppe"

Hi, pretty new to rails and starting my first Shoppe App. I've followed the steps on their get started page (http://tryshoppe.com/docs/tutorials/setting-up), and after running the server, it's giving me an "uninitialized constant Shoppe" error with the line "  mount Shoppe::Engine => "/shoppe" " in routes.rb. Anyone know how to fix that and why that would happen? Thanks!

It doesn't sound like you have the Shoppe gem in your Gemfile and ran bundle install


Auth with Login Facebook is outdated

I run your your authentication example with facebook login. In your example it works well. However, create a new one and test. Many functions are deprecated.  I code with Swift 3, Xcode 8.

Thanks for the heads up!

Sample is updated to swift 3.


Features/style updates

@pedroseromenho tell me when you’re done here when you want me to put it in production

You can go for production ! :)

Done!


Done with - #4754

Done with - #4754

@rahulshukla-webkul

Image height and width should be fixed, currently the image size is too bigger

There should be a option to add multiple product image

@rahulshukla-webkul
alignment issue on all review page if their are some review exist with image or without images
https://prnt.sc/1177pb1


Fix bug with highlighting text & drag region on macOS

@RocketChat/core

Closes #410

Fixes bug with selecting text by changing drag region show in images below.
Green means it is draggable (meaning you can't highlight text). If you remove the server list it just gets rid of that drag region, and the rest stays the same.

Another part of this issue is that if you have a scroll bar due to many channels/DMs/Etc. the scroll bar is not clickable as a scroll bar. This means you can't scroll if you have a standard 2-button mouse without scroll-wheel/scroll-touch funtionality.
See screen:
I have a grey scroll bar on the left. If I click and try to scroll it just drags the Rocket.Chat.Electron window around.

Using Rocket.Chat.Electron: 2.6.1
Server: 0.54.2 [running onto Ubuntu 16.04 LTS]
My Client Machine: OSX 10.9.5

What about use just the top area to drag?

@rodrigok I'm happy to change it to just the top bar. Hopefully it should be obvious enough for most people.


Added diffs for Web

Added to the HTML file:

diff=html
diff=php
diff=python
diff=ruby

@Richienb
Thanks for the series of PRs and sorry for the delay!
I was not aware that git could specify patterns like that (apparently for many versions now!).


Update?

Hi, does this wrapper is still maintained? Looks really neat and simple.

Hey @ponasromas, yes, I would be more than happy to maintain this if there's interest. I really should make this wrapper more TypeScript-friendly as well.


Use a TestRule to check for connection leaks

This implements the suggestion in https://github.com/square/okhttp/pull/4677.
I'm not very happy with the result and I personally prefer it not to be merged, at least not as-is: The problem is that many tests use this pattern to overwrite the client field:
client = client.newBuilder()
      ...
      .build();

Since updating OkHttpClientTestingRule.client after every instance of this would be tedious, OkHttpClientTestingRule will apply its checks to the original OkHttpClient. This is usually OK since the original and new OkHttpClient instances share most of the fields, but since some fields do differ, the result is inconsistent.

I think it's a net improvement, we can add functionality to the Rule, but happy to wait for other feedback.

I think it's a net improvement

@yschimke, not necessarily. For example, consider this test:
https://github.com/square/okhttp/blob/d261896d03c3afc9a39e64cf0a7f31fb8d971d0d/okhttp-tests/src/test/java/okhttp3/ConnectionReuseTest.java#L114-L117
The existing code will detect a connection leak in this test because it looks at the new client instance and new ConnectionPool. The new code will not detect a leak because it looks at the overwritten client and its ConnectionPool.

@amirlivneh maybe this should be part of the functionality of the rule, e.g. registering the client with the TestRule for cleanup?

I considered it but was concerned about the boilerplate it would add to tests and the fact that it's easy to forget to register the client. This would make it inferior to the tearDown() solution, where these issues don't exist.

I like it. I don’t think it’s harder to remember a rule than to remember a tearDown() method.
We could get rid of TestUtil.defaultClient() so the only way to get an OkHttpClient for a new test is to either instantiate one directly or to use this rule? Most tests that I write copy-paste an existing one for setup so as long as we start consistent it’s easy to stay consistent.

@swankjesse, my concern is not about forgetting to add a rule per file - that’s easy. It’s about the added boilerplate and the chance of forgetting to reassign the new client instance to the rule in each test method that uses this pattern:
https://github.com/square/okhttp/blob/d261896d03c3afc9a39e64cf0a7f31fb8d971d0d/okhttp-tests/src/test/java/okhttp3/ConnectionReuseTest.java#L114-L117

How about the rule becomes the factory:
OkHttpClient client = rule.defaultClient();

OkHttpClient client = rule.build(builder -> {
  builder.connectionPool(...)
});

Yes, that should work.

I tried the approach suggested by @JakeWharton, and it works. I personally still prefer the tearDown() solution because it requires adding only one call site per test class, leaving test methods unconcerned with the whole thing, but it looks like I'm in minority here :)
If we move forward with the TestRule solution, I recommend merging this PR as-is and sending another PR that only applies the pattern suggested by Jake. I expect the change to be in dozens of call sites and will be easier to review if it consists only of that single mechanical change.

How about the rule becomes the factory:
OkHttpClient client = rule.defaultClient();

OkHttpClient client = rule.build(builder -> {
  builder.connectionPool(...)
});

How about making OkHtttpClientTestRule.client.newBuilder() return a class derived from OkHttpClient.Builder() whose build() method updates its enclosing TestRule with the built OkHttpClient instance? This will be transparent to call sites, but will require making OkHttpClient.Builder non-final.

I'm a bit wary of changing public API to accommodate tests. Especially
since I'm a 'final' warrior.
On Thu, Mar 7, 2019 at 10:40 AM Amir Livneh<EMAIL_ADDRESS>wrote:

How about the rule becomes the factory:
OkHttpClient client = rule.defaultClient();
OkHttpClient client = rule.build(builder -> {
builder.connectionPool(...)
});
How about making OkHtttpClientTestRule.client.newBuilder() return a class
derived from OkHttpClient.Builder() whose build() method updates its
enclosing TestRule with the built OkHttpClient instance? This will be
transparent to call sites, but will require making OkHttpClient.Builder
non-final.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/square/okhttp/pull/4680#issuecomment-470575491, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAEEEVZavDC3GRstBRw4fUz8RTCLMJbPks5vUTLXgaJpZM4bbUMp
.


console.log messages are too noisey

Prerequisites

[x] Are you running the latest version?
[x] Are you reporting to the correct repository?
[x] Did you perform a cursory search?

Description
There are many places in the codebase which are calling console.log for example on mouse interaction or on state change of a tool. This makes the console very noisy and hard to use as a tool when developing on-top of cornerstoneTools.
The following is a pretty common sight in my console.

Suggestion
One solution to this would be to add a tool like debug
(no affiliation) for logging.
Debug is really useful for library makers to keep useful logging around to aid in debugging issues while having it disabled by default.
It also lets you "scope" logs so they can be filtered in/out and be identified by color.
Debug is enabled/disabled using a field in localStorage so the setting will persist through a refresh.
// Show all debug logs - note this may include other libraries which also use debug
localStorage.setItem('debug', '*');

// Filter by scope
// - all cornerstoneTools logs
localStorage.setItem('debug', 'cornerstoneTools:*');

// - just the cornerstoneTools:annotation scope
localStorage.setItem('debug', 'cornerstoneTools:annotation');

Example output in a chrome console:

I'd be happy to make a PR to get this started.

Ah! @JamesAPetts and I were just discussing better logging practices. The current state of things is a bit embarrassing. Please feel free to continue down this path ^_^

I approve of any work in this direction. The current console logs are relics from the rapid development of 3.0 haha. It'd be nice to turn it off entirely for production use.

:tada: This issue has been resolved in version 3.7.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Deprecation of Community Plugin

The Datadog team has released an official version of their SDK. Since they are a team and very close to the APIs and features of the iOS and Android SDKs, it is with a heavy and joyful heart that version 2 of datadog_flutter will be the final release of this community package.
The migration is not exactly one to one. This follow is an impartial migration guide, as the new SDK has just reached beta. Add more in the comments and I'll edit this list as we discover disparity. If you have questions about the new SDK or APIs, please open issues on the new repo. Good luck @fuzzybinary @xgouchet and thanks for your work in releasing this new SDK.
Thank you to everyone for your support and contributions to this plugin, especially @btrautmann @charafau @QuirijnGB.
Migration Guide (WIP)

Rename datadog_flutter to datadog_flutter_plugin. The Datadog team has decided to not use the datadog_flutter package name.
The initialization API is extremely similar, however, you cannot pass keys for different platforms. Instead, consider applicationId: Platform.isAndroid ? androidKey : iosKey. For apps that use web/linux/mac/windows too, you'll have to be more creative with your solution.
Use the global logger in DatadogSdk.instance.logs. While you can still use the individual logger architecture, the class isn't publicly exposed (DataDog/dd-sdk-flutter#121) as of writing.
Web is not supported by the new SDK yet. Do not migrate if you use Flutter web.
HTTP tracing has been mostly completely rewritten (cc #104). Please review the new datadog_trackiing_http_client package to integrate with your app. Don't forget to enable automatic capture.
DatadogObserver is now DatadogNavigationObserver

Thank you for all the time and effort!

Thanks a lot @tshedor for making and maintaining this plugin!

Thank you!!

Thanks so much for all your contribution!


Element ref in onValue function

Is there a better way to get element ref inside onValue() of any property or stream.
someSteam/property.onValue(function(value){
$(event.srcElement) // other than this
})

Well, that's about it. If the element is what you care about, you might do
var elementStream = stream.map(function(event) { return $(event.srcElement) })

And then place your subscribers on top of that.

Slightly related question: Is there a better way to do something like this? I'm not sure if this is as concise/functional as it could be, or if I'm still thinking in an imperative way about the problem.
var elementStream = stream.map(function(event) { return $(event.srcElement) });
var elementHeight = elementStream.map('.height').map(function(val) { return val + 10 });

elementStream.zip(elementHeight).onValue(function(data) {
  var [element, height] = data;
  element.css({height: height});
}

There are a couple of places in my current codebase that I want to compute a value and then use that value to assign something back to the original event target. Is there a way to do this without zip? I particularly don't like having to clump the data together into a temporary array just to get both values… any advice?

You can use zip of course, but If you don't really need elementHeight as an eventstream, you might just
var elementStream = stream.map(function(event) { return $(event.srcElement) });
function elementHeight(el) { return el.height + 10 }

elementStream.onValue(function(el) {
  element.css({height: elementHeight(element)});
}

So in this particular case it doesn't really make sense to represent elementHeight as a stream.
Keep it simple :)


Bug template

Adds information about targeting the correct branch when submitting pull requests

I guess the only problem with specifying the version numbers is you'll have to update these after every point release. Is that actually a problem, or would something like [ ] 9.4.x nightly build be better?

@OllyHodgson it was already that way, I think there is a release checklist item to update the issue templates after each release.


ORDO: Text definitions sometimes truncated

From @cmungall on October 21, 2017 18:12
E.g. https://www.ebi.ac.uk/ols/ontologies/ordo/terms?iri=http%3A%2F%2Fwww.orpha.net%2FORDO%2FOrphanet_199 has a text definition ).

The def on the orpha site is fine:
http://www.orpha.net/consor/cgi-bin/OC_Exp.php?Expert=199
so looks like introduced when going from xml2owl?
Copied from original issue: monarch-initiative/monarch-disease-ontology-RETIRED#412

@nicolevasilevsky
The definition of Orphanet:199 ‘Cornelia de Lange syndrome’ looks good in the latest OLS update (09 May 2018), so looks like the changes have propagated there. I haven’t checked bioportal. I will unassign myself from this ticket now. Should there be any future issue related to OLS, please create a ticket here: https://github.com/EBISPOT/OLS/issues
Thanks! :-)

Sounds good, closing


How to change the code if I use CUDA 10？

2020-12-29 10:10:44.476602: E tensorflow/stream_executor/cuda/cuda_driver.cc:318] failed call to cuInit: CUDA_ERROR_NO_DEVICE: no CUDA-capable device is detected

I solved the problem by changing os.environ['CUDA_VISIBLE_DEVICES'] = "0"


refactor(meta): some refactor on source/stream manager and fix recovery clean

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
In this PR:

add some cleaning for compaction group register and source manager, and pause source manager at the beginning of recovery.
removed background streaming job deleter, it's not necessary since we have already support batch drop streaming jobs, we can handle drop of streaming job right inside stream manager, ignore the failure and let recovery to take over the data cleaning.
some refactor in stream/source manager, including some rename, ie: rename materialized view with streaming job, because the stream and barrier manager will manage not only materialized views, but also sinks.
some refactor and fix on catalog manager, mainly about drop_database.

Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)

Will review it later. ❤

Will review it later. ❤

Just take your time, it's acceptable to review it next week. 😊

This PR speeds up the e2e a lot on the CI. Interesting. 🤔 cc @xxhZs


Running make

Running make results in lots of warnings and about five errors

Ok. Don't care about the warnings ... All the warnings are enabled in the compilation ... this is a part of the debug process.

We need the check this multiple definitions of 'heapCount' in stdlib.o. This file is found in the rtl/ library in desktop/ folder.

Hi Fred Nora, this issue has been resolved. Thanks


Added adadomain integration

Added support for adadomains to work in the same way $handles are
dealt with.
The UI has been modified to state that addrresses, $handles,
adadomains or Milkomedia can be used.
Summary of changes:
src/config/config.js
exporting ADA_DOMAIN with the policy ID from adadomain
proof of policy ID: https://presale.adadomains.io/
src/api/extension/index.js
    imported ADA_DOMAIN from config.js
    added "getAdaDomain" function using the $handle code but referencing ADA_DOMAIN and different variable names to distinguish it from the $handle code

src/ui/app/pages/send.jsx
    Adjusted the placeholder to include adadomains
    Added variable "isDomain" to store if the entered text is an adadomain
    Checks if the text ends with ".ada" and assumes that the entered text is an adadomain
    If it is an adadomain it uses the same code as it uses for $handle except for:
        variable names reflecting the fact that this code is about adadomains
        using getAdaDomain instead of getAdaHandle to find the address
        using the text up to the last occurence of a dot instead of everything except for the "$"

addr1vxu8w9m847nmcxu6ehylf5fgzwnae2ff7mvf8vus426j3tgqgfuhh

While we would certainly be happy with this integration. This is not a proper way to integrate us.
We will publish docs and correct policy to integrate us once we have a full solution ready(Q3). Read the latest blog for more info.


relax progressive checks for categorical dtypes

You've got a lot of tests failing because the stored "progressive" check results don't have categorical datatypes encoded in them, but the revised code does.  We can patch this for now by just checking that the values match and not the datatype in the output.  Then we can in the near future regenerate the reference data pipelines and simultaneously turn the strict_categorical setting on.

@i-am-sijia this PR now fixes all relevant outstanding tests in your PR.  If all seems legit to you please merge this into your branch.  The last failing test is addressed in the develop branch, which I will merge into your PR shortly via another PR here, but that one will be messy so I want to keep it separate so you can see what I did here more easily.


allow Tupleable instances to include default relvar name

Currently, the Tupleable interface does not include any specific binding to any relvar. @3noch suggested that the Tupleable typeclass could carry a default relvar name likely for use in define/assign/insert/update/delete operations. Tupleable values would still be able to be extracted from arbitrary queries.

You could encode this as a separate type class.

I guess the following would work nicely
class HasRelVarName a where
  relVarName :: RelVarName

and then we could add a default that names it using Generics?

This is exactly what I had in mind (and implemented in one of my projects). It works great.

Awesome ;) did you implement a default for it?

No I didn't get that far. But I'm on the fence about it anyway. I like things like that to be explicit, but certainly for toy projects it's nicer.

I guess it would still be reasonably explicit because you would have to write
instance HasRelVarName a where

anyway. But I guess you're right that you might as well add the string anyway at that point. Although as mentioned in the Beam tutorial, in GHC 8.2 that can be changed to a deriving (HasRelVarName) on the type which would be nice.

@3noch In your definition of the class do you get an ambiguous type error? I get one on relVarName because it ignores the a.

I am thinking tentatively that there should be indeed two classes: Tupleable and something else for the relvar name. The reason is that, if Tupleable has a single hard-coded relvar name, then one would need a second Tupleable instance to marshal the Haskell values to/form a different relvar. That seems rather limiting, especially considering that Tupleable instances don't need to use all the attributes of the target relation.
Alternatively, we could stick the relvar name into the Tupleable instance while making two expression-generating APIs, one using the instance's relvar name and one using any name (like we have now). That sounds like it could clutter what should be an easy-to-use API, though.
What do you think?


How Can I Run Dockerfile-dev for development

Topic
Documentation
Ask away!
Thank  you for your development,
I want to run file Dockerfile-dev

But have error, I guess i miss file enviroment for dev.
I want to run test

But i don't know, how it will work

Hi, @Hi1805. Please follow the instructions in our QuickStart guide.

Hi @rafaspadilha , Thank you for reply.
When i try setup setup_python_develop_env.sh
I have problem

I think it is conflicting version python :((.
I try run file vibe_dev/testing/op_tester.py.
I will be failed, because miss package

Could you please help, how i can run test op or workflow :(( ?
Many thanks

@rafaspadilha  Many thanks,
I change version python 3.8.
It's work fine

Hi sir @rafaspadilha,
I Run Pip check, i see conflict version package when i run bash setup_python_develop_env.sh

Python: 3.8
Please help me check it :( ?
Many thanks


Feature: User can create a dependency graph of components

Lets say I have a setup of video search application
I could define my model as
video downloader and frame extractor - Model1
Embedding model - Model2
Other model - Model3
VectorIndex - VI
Now,
if we create a graph it might look like
            Data
                |
           Model1
         |               |
  Model2         Model3
         |
        VI

Now if user wants to create a setup like above he would explicitly define select parameter in Listener with model1, model2 outputs collection.
What if we provide a elegant solution by letting user define a graph
graph = ComponentGraph()

graph.add(Collection1()) # Acts as input node
graph.add(Model1)
graph.add(Model2)

graph.connect(Collection1, Model1) # means inject collection1 as input to Model1
graph.connect(Model1, Model2) # means Model2 works on outputs from Model1

graph.add(Model3)

graph.connect(Model2, Model3)

Visualize
graph.show()

# we can add the graph to db and this creates the complete setup
db.add(graph)

I think we should put this on hold until after the launch.


svelte 5 support

The Svelte version of Golte seems to be 4.2.19. However, Svelte 5 provides more powerful features and improvements, such as TypeScript support, that I would like to take advantage of. Could you provide guidance on how to properly set up and integrate Golte with Svelte 5? Or, would Golte be updated in the near future to fully support Svelte 5 and its TypeScript capabilities?
Any tips or documentation on potential workarounds or compatibility configurations would also be appreciated.
Thank you for your assistance!

Sorry for the late response. I haven't had time to work on this project recently as I've been pretty busy. However, I will try to upgrade Golte to Svelte 5 as soon as I can.

No worries at all! I completely understand how busy things can get. Take your time, and I’m looking forward to seeing the Svelte 5 upgrade whenever you get the chance to work on it. Thanks for letting us know!


Enable Usage of JemAllocator

Fixes the issue highlighted in https://github.com/casey/ord/issues/1894, however likely needs to be adjusted to support multiple operating systems as at present it will only support linux + mac osx

Nice! Could be awesome with some benchmark data to show the improved performance

Nice! Could be awesome with some benchmark data to show the improved performance

Benchmark already provided https://github.com/casey/ord/issues/1893

Optimization PRs require a benchmark before they can be reviewed.


Option to prune stale SLXs on upload to the platform

Specify the --prune-stale-slsx flag when executing the workspace builder to enable this upload mode. If enabled, then any SLXs in the existing repo that were originally generated by the workspace builder but are not present in the new upload data are pruned from the repo. SLXs that were manually created/configured by the user are never pruned.

Very cool, I'll test this out shortly. Thanks @vaterlaus !

@vaterlaus when I performed a discovery with 2 namespaces, and then removed one, it looks like it tried to remove the slx content but then re-added it.
In this test, the initial upload was like this:
cloudConfig:
  kubernetes:
    kubeconfigFile: /shared/kubeconfig
    namespaceLODs:
      kube-system: none
      kube-public: none
      kube-node-lease: none
      online-boutique: detailed
      runwhen-local: detailed
```

And then set runwhen-local to `none` and uploaded again with the prune slx option set
```
cloudConfig:
  kubernetes:
    kubeconfigFile: /shared/kubeconfig
    namespaceLODs:
      kube-system: none
      kube-public: none
      kube-node-lease: none
      online-boutique: detailed
      runwhen-local: none
```

Check out this commit
![image](https://github.com/runwhen-contrib/runwhen-local/assets/18314168/a6c48dc5-017a-4a0e-9f81-e037f7aeb048)

![image](https://github.com/runwhen-contrib/runwhen-local/assets/18314168/7db80156-cf70-4a6c-82f1-f14b86c86cde)

I can confirm that the `runwhen-local` resources don't exist in the output from workspace builder
```
$ ls shared/output/workspaces/t-shea-crc/slxs/
ads-ob-grnsucsc1c-depl-health/   grnsucsc1c-clstr-rsrc/           on-bt-grnsucsc1c-cert-health/    rcm-ob-grnsucsc1c-depl-health/
chc-ob-grnsucsc1c-depl-health/   ldg-ob-grnsucsc1c-depl-health/   on-bt-grnsucsc1c-flux-kstmz/     rc-ob-grnsucsc1c-depl-health/
crr-ob-grnsucsc1c-depl-health/   ob-grnsucsc1c-ingress-health/    on-bt-grnsucsc1c-ns-health/      rc-ob-grnsucsc1c-redis-health/
crt-ob-grnsucsc1c-depl-health/   ob-grnsucsc1c-pod-resources/     on-bt-grnsucsc1c-sa-check/       shp-ob-grnsucsc1c-depl-health/
eml-ob-grnsucsc1c-depl-health/   ob-ob-grnsucsc1c-htt-ok-tls-tst/ prd-ob-grnsucsc1c-depl-health/
frn-ob-grnsucsc1c-depl-health/   ob-ob-grnsucsc1c-image-check/    pym-ob-grnsucsc1c-depl-health/

```

I mistakenly merged my previous commits into this branch instead of main. I'm going to merge this in, but will reach out to @vaterlaus to open a new PR to address the reconcile issues.


secretbox-decoding

Hi. I might be faar out sailing here but had to ask. So I use rclone to mount some 10Gb google drives that I got access to with my g-mails locally. Like on my laptop and phone and so on. On them mounts I also mount  encryption layers (crypt) so google cant snoop or scan my files. I'm a bit political and not the generally trusting type. I just like to keep mine to me. It just feel fine.
Rclone encrypt this layer with secretbox. Now I use this free phpbb forum that has no real space or shell coming with it. Of course I have some big sound files I would like to publish on my forum, speeches. They are all together some Gb's worth. So it makes sense to use cloudflare to cache them for me to avoid google having to share to much. And also then I would prefer to not store my sound files unencrypted in their cache..  So it made sense to me to look for a script that would receive the files at the end user and decrypt them after the TLS decryption, before they are passed off to the browser and storage.
Your script here is the closest thing I found. I'm not a programmer but an old toothless punk that lives on an old ship https://imgur.com/a/xuReX4u  so My hope is that you, that seem to do a fair bit of opensource coding, might find it in your heart to either point me to such a script or cobble together something useful (and explain how to set it to catch the streams of some links).
The crypt drive mount has a password in the rclone config ( it is for a sub folder to the plain mount) and it is not very important that this password is secret as the files anyway are gonna be openly accessible. It is good thou that the key is begotten first at the site. It may be put hard coded in to the script or maybe it could be loaded in a plain text  from some other domain(not cached at CF) or even reside in the sites html or something like that. The files are not meant to be secret per see but just not automatically audio to text transcribed and then scanned automatically either at google or cloudflare. Well I get that I'm a bit paranoid, but things are moving about a bit strangely nowadays in my mind and eyes.
so drive+Xsalsa20>TLS>-->cloudflare>noTLS>ev cloudflare encryption-decryption>TLS>-->client>noTLS>Xsalsa20DecryptionScript>plain file>browser>drive or stream.
There is some options with rclone to encrypt file names as well as content.
My guess is that with this solution the g-drive - hotlink thing could become more attractive as a "poor man's" option as it at least stop automatic scanning.
Well, All this with a stubborn hope. Ivano-jirido

Hi @Jirido 👋🏼
It sounds like you are caught between the devil and the deep blue sea with privacy/anonymity.  Let me get back to you after digesting this!

Nice.. You seem like a sharp dude, For me it often is blurry around how, in the scheme of all things moving about, to catch things that a function gonna work with and then how to pass it on to where it was going. Even if often know what I want to get done ; ) I begun to think that maybe if i gave the links a class somehow or if the links should call the script with an argument of the actual link or.. well But I guess you will know.
If you look for some broader application to this secretbox-encoding and (maybe decoding) this one guy has this cool "org-web" org-file editor that works with different of this free or non free storage's.
He thought it could be a good thing for his foss app but that it was out of the scope of his ability.   So I thought of your thing here when I woke up this morning and saw that he had answered..  For me here in the Scandinavia helvete(swedish) - helviti(finnish) -> "Hel viet"  would be "whole-we or "the we of whole"  as "hel" is old old, even pre sweedish word for whole, and "vi" is the word we.
 The inner light that, yes is both death and life. Or to say the truth, there is only life. So no bad intention meant from me when I express myself from my culture and see you as a potential holy fit from hell.
One can't miss an opportunity to stifle the, with the "norm culture" very resonant spread of Asa respect now when they start to sell them selfs even as the opposition to them selfs under their main cloak of god and goth, good and goat. Typical normal black magic of fake conflicts and double bookings to exclude.
I hope I did not disrespect 100 of your toes by ranting against the spawns of self ointing valhall wanabe goates and limp d**ks..  Damned I can hardly stop.  It is one of this mornings I guess..
Anyway here is a link to web-org if you feel inspired at some moment https://github.com/DanielDe/org-web/issues/132.   Thanks for cooking with your brain on this problem.


[C_CPP]:Dijkstra's Algorithm

Description
This documentation will explain the dijksta's algorithm for graphs
Domain
C/CPP
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign


Crafting With Containers UI missing total resources

In 1.0.10 the UI does not show the total amount of resources anymore. Worked in 1.0.9.
List of mods used:

Woops! Missed to return a boolean! Hotfixing :)

Didn't mean to close the ticket so fast. Version 1.0.11 coming right now


Generator should include .cache to gitignore

Reported in Plone Conf 2022 Plone Installer training

It's cache without a period at the beginning


[Bordle] Word vaiidity check fails in certain cases

Affected hardware version
Bangle 2
Your firmware version
2v12
The bug
The clever check for whether a word exists (i.e., its index occurs on a mod 5==0 boundary in the word list) fails when a valid word happens to straddle two other words. Such is the case for the word 'taste' that unfortunately occurs in the concatenation of "asset" and "aster".
Thanks again for creating the Bordle app!

Maybe fixed with  #1795


MAHOUT-1795: Build math & spark bindings under scala 2.11

The shell isn't building, so only enable it for 2.10.
Unfortunately this means that there's a 2x2 build matrix with hadoop/scala versions. The only way to resolve this
was to switch to activating profiles through properties, so if you were previously using -Phadoop1, you'll want
to use -Dhadoop1. The default config without any options is effectively -Phadoop2,scala-2.10.

Ok.... what's not-so-terrible hack? where do we go from here?

Sorry, I was asked to open a pull request in the ticket. Given this, would there be interest in having a dual 2.10/2.11 build that excluded mahout-shell for 2.11?

Updated to not be a terrible hack, but formalizes excluding spark-shell from the 2.11 build. (If you look at the way spark itself tackles the 2.10/2.11 split - shell will need completely different code for 2.11.)
If this does get accepted, it would be nice to also set up CI for scala 2.11 (mvn -Dscala-2.11 ...) :)

Can somebody else to look this over -- we may want to include this if it truly enables 2.11 build

+1, preliminarily. still don't understand why this seems to exclude spark-shell from the build.

@mikekap can you explain why converting spark-shell for the 2.11 build is non-trivial, maybe give some more context?

I haven't looked too far in depth, but as I mentioned above, spark itself has completely separate (probably not API-compatible) source trees for spark 2.11 and 2.10. The code doesn't seem even remotely similar to me, and I likely don't have the expertise to convert that mahout shell code to work with 2.11.
Let me know if you'd like be to rebase this.

Hey Mike-
Sorry to let this thread go dead- can you rebase this?  Working on Spark 2.x and this becomes much more relevant. Also re: shell- I'm proposing dropping in favor of this approach.
https://github.com/apache/mahout/pull/271
Thanks for your contribution!

I'm happy to rebase this, but if you don't mind I'll wait until #271 is merged. It would be trivial to enable scala 2.11 if the shell is gone :)

@mikekap #271 is merged.  Please re-base.
Would love to get this in for 0.13.0 if possible.
Thank you again for the contribution!

Bump- @mikekap can we get a rebase. Would like to merge this as soon as code-freeze for 0.13.0 is done.

Now that 0.13.0 is out, is this still something we'd want to put in 0.13.1?

hey @mikekap sorry I missed this- we changed the travis yml.  Can you rebase off of that.  This is failing on the viennaCL stuff, this is a known problem (scala 2.11 not working with viennaCL bindings).  The new travis.yml tests for spark 1.6/scala 2.10, spark 2.0/scala 2.11, spark 2.1/scala 2.11.
But the scala 2.11's aren't tested with viennaCL. (only scala 2.10)
this should fix your build issue, and if you woundn't mind update the travis yml to utilize your profiles.

bump

going to merge this and fix outstanding issues with other PRs.

@mikekap thanks for the contrib.  I went ahead an merged, and fixed up the rest.


Exam mode: Artemis may leak programming exercise titles to students

Describe the bug
When changing an exercise description, students get notifications about the title of the exercise (not exercise group). This should not happen before an exam has started!
To Reproduce

create student exams
We suspect that this happens when the exam is already visible to students, but has not started yet.
Change the exercise description
Observe notifications as a student registered for the exam by navigating to the main exam in the exam tab and waiting a few seconds.

Expected behavior
Exercise names should never be leaked to students before the exam started.
Screenshots

Which version of Artemis are you seeing the problem on?
7.4.4
What browsers are you seeing the problem on?
Other (specify in "Additional context")
Additional context
Briefly discussed with @az108
Relevant log output
No response

A point to be added:
This only happens if the exams for students are already generated.

PR #9102 fixes this issue, notifications like this will only be shown after starting the exam.

I think #9102 is only a partial fix that fixes the observable issue. The information leak still happens when looking at the network tab in the browser devtools. Ideally, the server would not send the information at all.

Or does the live event button handle the requests internally and the request is not made in the first place if the component is no longer there?

I would assume so, but I have to double check. Good point, thank you!

I still see the information in network tab even if the component is not present in the welcome page of the exam.

I think it is quite important because the network tab also shows the problem statement itself even if the exam is not started and the instructor made some changes in problem statement. It would be nice to handle it on server side like not sending the response at all if the exam is not started.

I discussed this quickly internally today and assumed this information is passed to you @edkaya
Here is my viewpoint:

Exams are not supposed to be visible multiple days before. Typically, they are visible a few hours before the exam starts when all information is correct. We should display a warning when instructors set the visible date too early. Let's say when there is more than 4h difference.

Students can click on start 5 min before the actual exam start, but the exam content is only shown to them when the actual exam starts.

Before this moment, there is no need to create exam live events for exercise updates at all!!! The server should simply do "nothing" here in terms of live events

In the short time window 5min before the exam (quite unlikely that the instructor changes something, but we should still cover it) until the exam officially starts, the update should be sent via websocket to the client and update the hidden information in the client, but should not be shown to the student, because he/she never looked at the problem statement, so there is no need to display something (which is annoying if it is not needed)

only after the exam started, the server should produce the actual exam live event and display it all students who are affected

@edkaya please implement it like that, potentially split into multiple PRs
The 5min time window extra handling would be low priority because it's very unlikely.

Sure, I will have a look 👍


HTML homepage should be readjusted for when user has signed in. (User should not have to see the Login and Signup signs after getting logged in)

Wrote an authentication condition to determine what was displayed before and after login. This fixed the issue


author formatting is not correct.

Description
can author formatting issues in the html view be corrected ?
(Optional:) Please add any files, screenshots, or other information here.
No response
(Required) What is this issue most closely related to? Select one.
Choose One
Internal issue ID
72cbb760-9027-4677-b23b-e57ebed71dc8
Paper URL
https://arxiv.org/html/2401.03955v3
Browser
Chrome/<IP_ADDRESS>
Device Type
Desktop

Looks like, google scholar is using the html format to index my article and for some reason, the google scholar index is not getting updated. Wondering, if it is due to the html page issues ?


apparmor-enforcer: skip non-regular profiles

SUSE creates few symbolic links (cache, cache.d in the /etc/apparmor.d/ folder.
Kubearmor gives out error since the current check if based on IsDir()
and the sym links are not covered in that check. Now we are checking if
the file is a regular file and only use it in that case.
Signed-off-by: Rahul Jadhav<EMAIL_ADDRESS>

Codecov Report

Merging #665 (1a852ef) into main (5d47974) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
+ Coverage   44.12%   44.16%   +0.04%
==========================================
  Files          23       23
  Lines        8730     8731       +1
==========================================
+ Hits         3852     3856       +4
+ Misses       4412     4410       -2
+ Partials      466      465       -1

Impacted Files
Coverage Δ

KubeArmor/enforcer/appArmorEnforcer.go
49.00% <100.00%> (+0.12%)
:arrow_up:

KubeArmor/monitor/systemMonitor.go
49.08% <0.00%> (+0.55%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f22bc07...1a852ef. Read the comment docs.


Switch to new cluster and build credentials

@samhh @elcuervo can we go ahead and merge this? I kicked off a deployment today (to test out auto rotated access keys) and the build failed because the AWS_SECRET_ACCESS_KEY_PUSHER key doesn't seem to exist any more.
Looking at the mercury terraform - a seemingly valid build role  is managed there but no IAM users. So, I think the best path forward is to just merge this PR.


Webp images dont work on iOS11

Description
Webp images dont work on iOS11 in different devices (iPhone 5s, iPhone SE, iPad Mini 2)
Works as expected in iPhone 5s with iOS10
Steps to Reproduce
Try to display an uri or file imagesource with a webp image.
CachedImageRenderer.Init(); is present on FinishedLaunching.
Expected Behavior
Image loaded
Actual Behavior
The image is shown empty; it gives followin error:
An error occured while retrieving image.
System.Exception: Could not create an native instance of the type 'WebP.Touch.WebPDecoder': the native class hasn't been loaded.
It is possible to ignore this condition by setting ObjCRuntime.Class.ThrowOnInitFailure to false.
at Foundation.NSObject.InitializeObject (System.Boolean alloced) [0x000af] in /Users/builder/data/lanes/5024/152b654a/source/xamarin-macios/src/Foundation/NSObject2.cs:198
at Foundation.NSObject..ctor (Foundation.NSObjectFlag x) [0x0000d] in /Users/builder/data/lanes/5024/152b654a/source/xamarin-macios/src/Foundation/NSObject2.cs:117
at WebP.Touch.WebPDecoder..ctor () [0x00000] in <0b9e96b17a814cc7973c5662835f5cc0>:0
at WebP.Touch.WebPCodec..ctor () [0x00006] in <0b9e96b17a814cc7973c5662835f5cc0>:0
at FFImageLoading.Work.ImageLoaderTask+d__13.MoveNext () [0x004a3] in <42a5f678b05a4043b21d2f40835869e4>:0
--- End of stack trace from previous location where excepti
on was thrown ---
Basic Information

Version with issue: Tested with multiple versions, including the latest. FFImageLoading 2.3.2, WebpTouch 1.0.7
Platform: iOS 11

Did you clean bin/obj folders and caches properly? WebP 1.0.7 works just fine on iOS 11.2

i've done 4 times the following steps:

deleted bin/obj folders
deleted ffimageloading and webp in components folder
deleted ffimageloading and webp components folder in Mac (Library....)

Am i missing something?
Could be related to Xamarin version? I'm using Xamarin 15.3 with XCode 9.0 support.
Thank you very much indeed
Jose Antonio

Run our sample Xamarin.Forms sample, it works fine. I'll need a repo to help you. I remember someone had similar problems here, and it worked fine with a different device, so it looks like old app files could interfere with it too, or maybe linking issue?

Hi,
I just ran the WebP Demo on a real device and I am getting the error:
Wrapper type 'WebP.Touch.WebPDecoder' is missing its native ObjectiveC class ‘WebPDecoder
When setting the SmartLink = false in libWebPWrapper.linkwith.cs it runs fine on a real device with iOS 11.2.5.
This bug is more related to the WebP.Touch repository than on FFImageLoading.

On 4 Feb 2018, at 16:47, Jose7777<EMAIL_ADDRESS>wrote:
I've found the solution playing with WebP.Touch project and the included demo.
If i remove SmartLink = true in libWebPWrapper.linkwith.cs , the error is gone, and images loads perfectly. Tested with 3 different devices, one of them in previous iOS version.
Do you want me to make a PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/luberda-molinet/FFImageLoading/issues/874#issuecomment-362916760, or mute the thread https://github.com/notifications/unsubscribe-auth/AGOcLZQKJsE1YFn0DOj7hqtjQUGWZhKdks5tRdEigaJpZM4RNOuE.

Furthermore, setting SmartLink = true will ignore ForceLoad property.
https://developer.xamarin.com/api/type/MonoTouch.ObjCRuntime.LinkWithAttribute/ https://developer.xamarin.com/api/type/MonoTouch.ObjCRuntime.LinkWithAttribute/
From my understanding it is safe to remove or set SmartLink to false.

On 5 Feb 2018, at 09:43, Benjamin Jose<EMAIL_ADDRESS>wrote:
Hi,
I just ran the WebP Demo on a real device and I am getting the error:
Wrapper type 'WebP.Touch.WebPDecoder' is missing its native ObjectiveC class ‘WebPDecoder
When setting the SmartLink = false in libWebPWrapper.linkwith.cs it runs fine on a real device with iOS 11.2.5.
This bug is more related to the WebP.Touch repository than on FFImageLoading.

On 4 Feb 2018, at 16:47, Jose7777<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
I've found the solution playing with WebP.Touch project and the included demo.
If i remove SmartLink = true in libWebPWrapper.linkwith.cs , the error is gone, and images loads perfectly. Tested with 3 different devices, one of them in previous iOS version.
Do you want me to make a PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/luberda-molinet/FFImageLoading/issues/874#issuecomment-362916760, or mute the thread https://github.com/notifications/unsubscribe-auth/AGOcLZQKJsE1YFn0DOj7hqtjQUGWZhKdks5tRdEigaJpZM4RNOuE.

I have created a PR for this.
https://github.com/luberda-molinet/WebP.Touch/pull/10
Could you please release a nuget with this fix?
Thank you very much

Fixed. New stable soon. Thanks :)


is there a function that provides the pose of the marker?

Hi,
in this project, there is no dedicated function for pose estimation, as this is typically accomplished using the cv::solvePnP() function of OpenCV. Please have a look at this Tutorial for an example. The corresponding Python functions are documented in the OpenCV documentation.
The STag library is designed to serve as a drop-in replacement for the ArUco library, so you can easily replace it with this library in your projects.
Best regards


Obscure Storage Account Secrets in UX

Is your feature request related to a problem? Please describe.
The Azure Storage Explorer UX exposes account keys, SAS, etc.. in the lower left corner of the screen. During screen sharing sessions, it is possible for secrets to be exposed. A user could simply expand or widen the left nav.
Describe the solution you'd like
Add an option to obscure the secret values (e.g., secure string, ****, etc..)
Describe alternatives you've considered
Tried collapsing the properties section in the lower left of the UX, but there is still risk the section could accidently be expanded and the secret exposed.

Use 1.16 to investigate this issue.

The following feature areas had secrets obscured:

subscription storage accounts
attached storage accounts
attached containers
cosmos db accounts


feature request - add option for database gui

The whole install is painless for the inexperienced user on Windows, so thanks for that. The only glitches were that the Quick Start Guide does not mention the need to edit the values of sh.path and sh.args in the Vagrant file; and that vagrant-hostsupdater does not work for me on Windows 7.
Getting phpmyadmin working from within the VM using https://github.com/geerlingguy/ansible-role-phpmyadmin on Windows is not so simple for someone new to Ansible, and I gave up and installed it manually. Including optional setup of phpmyadmin or some similar db visualisation tool in the main playbook may help new users.

Why not just use something like HeidiSQL client?

@John-B @kevinquillen - I tossed out phpMyAdmin in favor of Adminer, a much nicer/simpler/easier to use MySQL GUI.
Just make sure adminer is in the list of installed_extras, and you can access it at http://drupalvm.dev/adminer (assuming you have default URL configured—otherwise replace drupalvm.dev with the URL for your VM instance.

Thanks.


Portugues brasileiro

Sorry if i did anything wrong, it's my first time contributing and i don't have much experience with git and github. I tried to follow the tutorial for contributing and i hope i did good.


Set PGDATA for Kube deployment

The postgres container would fail trying to chmod the data directory,
which was the same as the volumemount. Set PGDATA to a data
subdirectory to fix this.

The fail looked like
$ oc project compserv
Now using project "compserv" on server "https://api.mcrr-171-1.devcluster.openshift.com:6443".
13:56:19 mrogers@fedora:[compserv:main]:
$ oga                                                                                NAME                            READY   STATUS             RESTARTS      AGE                                                                                pod/postgres-676bd447c4-4psww   0/1     CrashLoopBackOff   1 (10s ago)   16s

NAME               TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)    AGE
service/postgres   ClusterIP   <IP_ADDRESS>   <none>        5432/TCP   16s

NAME                       READY   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/postgres   0/1     1            0           16s

NAME                                  DESIRED   CURRENT   READY   AGE
replicaset.apps/postgres-676bd447c4   1         1         0       16s
13:56:23 mrogers@fedora:[compserv:main]:
$ oc logs pod/postgres-676bd447c4-4psww
chmod: /var/lib/postgresql/data: Operation not permitted
chmod: /var/run/postgresql: Operation not permitted
The files belonging to this database system will be owned by user "1000670000".
This user must also own the server process.

The database cluster will be initialized with locale "en_US.utf8".
The default database encoding has accordingly been set to "UTF8".
The default text search configuration will be set to "english".

Data page checksums are disabled.

fixing permissions on existing directory /var/lib/postgresql/data ... initdb: error: could not change permissions of directory "/var/lib/postgresql/data": Operation not permitted

Actually, this fixes it by setting the PGDATA to the precise volume mount (it was set to /var/lib/postgres not /var/lib/postgresql)

Nice find! I opened an issue for it and I was able to reproduce the problem.
https://github.com/rhmdnd/compserv/issues/115


crawl-archives ignored in DevSkimRuleProcessor

Describe the bug
The devskim analyze command allows to specify the   -c, --crawl-archives          Analyze files contained inside of archives flag.
The flag is ignored by the DevSkimRuleProcessor and all the archives are scanned independently from the flag

Thanks for the report. This appears to be an oversight in the refactor. Should be a simple fix I can get to later today.

Should be fixed on main now with the next build coming shortly. Thanks for the report.


Add RMessage

A crisp in-app notification/message banner built in ObjC.
Project URL
https://github.com/donileo/RMessage
Category
UI/Alert & Action Sheet
Description
A crisp in-app notification/message banner built in ObjC.
Why it should be included to awesome-ios (optional)
Checklist

[x] Only one project/change is in this pull request
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 / tvOS 10 or later
[ ] Supports Swift 4 or later
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          1 Warning

:warning:
Found 1 link issue, a project collaborator will take care of these, thanks :)

Link issue by awesome_bot

Line
Status
Link

1355
Error
https://packetzoom.com  Connection timed out - connect(2) for "packetzoom.com" port 443

  Generated by :no_entry_sign: Danger


[BEAM-3301] Adding restriction trackers and validation.

Adding RTrackers as an interface, and adding them to the SDF validation.
I think this is the last real code involved in SDF validation, assuming I'm not forgetting anything. I might do a second pass on the error messages because they seem inconsistent with the old error messages, but the next major task is going to be working on the SDF exec code and doing some testing with the Flink runner.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Run Go PostCommit

Whoops, forgot reviewers.
R: @lostluck

LGTM

Squashed fixup commits


Remove explicit lifetime marker from RegexTestCase

The explicit lifetime marker inside RegexTestCase is not really necessary and hence we can remove it and after that considerably simplify the implementation of Steps by removing a lot of explicit lifetime specifications.

Please rebase. :smile:

Please rebase.

Done.


Settings dropdown with report abuse option

Going to have to do a merge dance with the telemetry PR but I'll cross that bridge when I get to it.
Adds a settings gearwheel which has a dropdown with one option:

Which pops up the report abuse modal:

Which sends a POST request to /api/[URI encoded pageSourceURL/abusereports with { text: [user description] } in the body. The localhost request looks correctly formatted to me, but I'm not quite sure how to test that it's being received on the other end. (I also haven't sent any real abuse reports because I didn't want to trigger a false Avert warning?)

Can we reuse the existing dialog for consistency?

@abchatra that dialog is pretty tied into the pxt codebase (the skill map doesn't have access to the modal component or the pxt cloud util functions right now). i could use something like the share page report abuse:

but either case would require changes to the modal, since it expects to be reporting a shared project id and the skills map would be reporting the markdown url

@shakao sounds good. Nit pick: May be move "Cancel" to "x" at the top?


add command: amp stack redeploy

Implement the amp command: amp stack redeploy [stack yaml file]
it could work like that:

compare the stack started services with new ones (in the stack yaml file)
for each service:
if no change, then nothing is done
if change appear, then update it using docker service update swarm api
if a service is not in the stack yaml file, then stop it
and update ETCD data accordingly.

so on service side, we have to implement 'service update'
and on stack side, to implement 'stack redeploy'
What do you think?

:+1:


Enhance table component with richer full text search capabilities

Potentially implement using lunr

Done in dev-simulators-2 branch branch. Supports searching over specific fields. Will add tooltip which explains this.

Done. Added tooltip in branch.


Is this still being maintained?

Hi there,
fist off, thank your for all the work you have put into this project so far.
Are you still maintaining this?
I got the current code to run, but I can not wrap my head around the generator function to get the individual samples from the telemetry feed. Can you explain to me, how to iterate through the samples?
Best regards,
Niklas

Hi @niklasden.
I started rewriting this to use TypeScript without the async generator. It is in a working state, but there is likely going to be changes to it before I officially release it. I tend to work on this on occasion.
If you take a look at this issue: https://github.com/SkippyZA/ibt-telemetry/issues/4 I discuss how to use the to-typescript branch which does not require the transpilation with babel to make use of the async generators.
There is also this comment https://github.com/SkippyZA/ibt-telemetry/issues/1#issuecomment-568279412, which mentions how to include the polyfill to make the existing version work.


uwsgi: Ensure that the master process cannot load the application.

The rolling restart configuration of uwsgi attempted to re-chdir the CWD to the new /home/zulip/deployments/current before lazy-apps loaded the application in the forked child.  It successfully did so -- however, the "main" process was still running in the original /home/zulip/deployments/current, which somehow (?) tainted the search path of the children processes.
Set the parent uwsgi process to start in /, so that the old deploy directory cannot taint the load order of later children processes.  We also shift all deployments to be lazy-apps, as this does not appear to alter the memory footprint in any way.

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

OK, merged, thanks @alexmv!


how to start?

Everything seems to be there, but does not want to start

Do you have java 17 or above installed?

yes installed. 17 18 and 20 java


GeoTIFFImage.getTileOrStrip Fail when rendering large multiband tiff file

When rendering 5 band 3.9 Gb .tiff file in multi mode the error described below often occurs. Looks like it does not lead to anything bad, but I decided to report it for further investigation if required.
index.js:2292 AggregateError: Request failed
    at BlockedSource.fetch (blockedsource.js:160:13)
    at async GeoTIFFImage.getTileOrStrip (geotiffimage.js:396:20)
    at async Promise.all (:8081/index 0)
    at async GeoTIFFImage._readRaster (geotiffimage.js:528:5)
    at async GeoTIFFImage.readRasters (geotiffimage.js:622:20)

Data to reproduce the issue on Google Drive.

This seems to be caused by a 304 cache error when fetching the data with a fetch request. The geotiff will spontaneously execute the request again, so it has no impact on the rendering.


⚠ ClamAV has degraded performance

In 11f2749, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 192 ms

Resolved: ClamAV performance has improved in e295b3f.


Moonwell Moonbeam: Indexing Errors

https://okgraph.xyz/?q=messari/moonwell-moonbeam
A determinstic fatal error occured at block 3060190: Failed to call 'asc_type_id' with 'ArrayBuffer' wasm backtrace: 0: 0x309a -<EMAIL_ADDRESS>1: 0xd47a - <unknown>!generated/templates/CToken/SolarBeamLPToken/SolarBeamLPToken#try_getReserves 2: 0xd830 - <unknown>!protocols/moonwell/src/mapping/setMarketRewards 3: 0xe204 - <unknown>!protocols/moonwell/src/mapping/handleAccrueInterest : wasm trap: interrupt wasm backtrace: 0: 0xffffffff - <unknown>!node_modules/@graphprotocol/graph-ts/global/global/id_of_type 1: 0x309a -<EMAIL_ADDRESS>2: 0xd47a - <unknown>!generated/templates/CToken/SolarBeamLPToken/SolarBeamLPToken#try_getReserves 3: 0xd830 - <unknown>!protocols/moonwell/src/mapping/setMarketRewards 4: 0xe204 - <unknown>!protocols/moonwell/src/mapping/handleAccrueInterest in handler `handleAccrueInterest` at block #3060190 (19651dc82a366431b72acec4bc4cac761718af070864e943f2998977a55b2fb4)

@dhruv-chauhan Could you take a look at this when you get the chance? Thanks!

The code looks good to me, test deployment has successfully synched ahead.
I reckon it's a timeout, wrongly reported as a deterministic error and redeploying the graft (PR: #1822) should fix it.
@bye43 @dmelotik


feat(streaming): enable lookup to scan from arrange keyspace

Signed-off-by: Alex Chi<EMAIL_ADDRESS>What's changed and what's your intention?
Refactor meta to allow lookup executor to scan from arrangements. We store a fragment_id in lookup stream node.
Checklist

[x] I have written necessary docs and comments
[x] I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)
close https://github.com/singularity-data/risingwave/issues/719

Also create delta-join mv is extremely slow (5 secs), not sure what's happening... I'll look into this later.

LGTM!


Onnxruntime v1.8.1 with GPU/CUDA 11 support

Merging two branches together to enables CUDA 11 Support on ONNX 1.7
The first one is: https://github.com/nbigaouette/onnxruntime-rs/pull/78
The second one is: https://github.com/radu-matei/onnxruntime-rs/tree/cuda
The solution is only for Linux for the moment as I don't have a windows machine to test it on.
This solution may not be perfect but wanted to share it with others. I am available to add or maintain this branch if you have any recommendations to make it better :)
Thanks for the work of @radu-matei, @dkim, @dllu, which is the base for this PR :1st_place_medal:

Thanks for the contribution!
Sorry for my late replay, I don't have much time to put on that project...
I updated the bindings yesterday to 1.8.1. Would you mind pushing commits just for the CUDA stuff? Or I can cherry-pick the two if you prefer.

All set!
I have rebase from master !
I did not push the bindings for Windows as I have no machine to test it on.
Feel free to leave comment on necessary modification :)

Codecov Report

Merging #87 (7578dc0) into master (312952b) will decrease coverage by 1.70%.
The diff coverage is 9.09%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88c6bab...7578dc0. Read the comment docs.

This branch should pass test now :)


[#noissue] Add grpc config

Codecov Report

Merging #6073 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6073      +/-   ##
==========================================
- Coverage   40.76%   40.76%   -0.01%
==========================================
  Files        3020     3020
  Lines       90572    90572
  Branches    11819    11819
==========================================
- Hits        36926    36920       -6
- Misses      50484    50489       +5
- Partials     3162     3163       +1

Impacted Files
Coverage Δ

...p/pinpoint/rpc/client/WriteFailFutureListener.java
56.25% <0%> (-18.75%)
:arrow_down:

...cluster/zookeeper/ZookeeperClusterDataManager.java
52.9% <0%> (-1.94%)
:arrow_down:

...pinpoint/profiler/monitor/DeadlockMonitorTask.java
18.6% <0%> (-1.17%)
:arrow_down:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
80.28% <0%> (-0.71%)
:arrow_down:

...rc/main/java/com/navercorp/pinpoint/test/Item.java
70% <0%> (ø)
:arrow_up:

.../pinpoint/rpc/client/PinpointClientHandshaker.java
66.42% <0%> (+1.42%)
:arrow_up:

...tor/metric/datasource/DefaultDataSourceMetric.java
78.12% <0%> (+3.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a4a66f...6eceff0. Read the comment docs.


doc: reconnect minlinked links as possible as many

Please describe the changes this PR makes and why it should be merged:
some hyperlinks are broken in CONTRIBUTING.md.

if those syntaxes should work, they should have their own link URL like CODE_OF_CONDUCT.md
so I added URLs as possible as many, but not all of them because I could not find them.

[coc]: seems like just #coc heading link.
[github]: our [GitHub Repository] means this repository.
[js-style-guide]: couldn't find it in this repository, so I searched and got jsguide.html
[commit-message-format]: seems similar to COMMIT_CONVENTION.md
[dev-doc], [individual-cla], [corporate-cla]: I cannot find a suitable URL, so linked their own heading temporary.

[dev-doc]: #submit-pr
[individual-cla]: #cla
[corporate-cla]: #cla

I don't know what to do about them.
Package

discordx

Additional Context
I'm new at contributing to the open-source GitHub repository.
if there is something that I missed, please notice me.
thanks.


Zip exporting isn't working for reimport the project

Godot version
3.4.1
System information
Window 10, GlES3
Issue description
I was trying to export my project as a zip and reimport in godot to make some changes. But when ever i tried to import the zip godot don't allow me to import the zip and says no project.godot file is found.
Fix this problem. This problem is very much irritating. I  spent 2 days by trying various way but i failed.
Steps to reproduce
Include the project.godot file while making the zip
Minimal reproduction project
No response

Exporting the project is for distribution in a form which is optimized for playing, not for editing. The vast majority of users don't want players to have full access to their source code. If you want to copy your project source, you can simply zip the project folder.


Any version > 6.2.2 ; "There were 2 problems processing this event"

Platform:

[ x]  Dart
[x ]  Flutter Android or iOS
[ ]  Flutter Web

IDE:

[x ]  VSCode
[x ]  IntelliJ/AS
[ x]  XCode
[ ]  Other, which one?

split-debug-info and obfuscate (Flutter Android or iOS) or CanvasKit (Flutter Web):

[ ]  Enabled
[ x]  Disabled

Platform installed with:

[x ] pub.dev
[ ] GitHub

Output of the command flutter doctor -v below:
[✓] Flutter (Channel stable, 2.8.1, on macOS 12.3.1 21E258 darwin-arm, locale en-AU)
• Flutter version 2.8.1 at /Users/angusjohnston/fvm/versions/2.8.1
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 77d935af4d (4 months ago), 2021-12-16 08:37:33 -0800
• Engine revision 890a5fca2e
• Dart version 2.15.1
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
• Android SDK at /Users/angusjohnston/Library/Android/sdk
• Platform android-31, build-tools 31.0.0
• Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 13.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• CocoaPods version 1.11.2
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2020.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
[✓] VS Code (version 1.66.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.38.1
[✓] Connected device (4 available)
• Pixel 3 XL (mobile) • 8AWY0RX94                 • android-arm64  • Android 12 (API 31)
• SM G900I (mobile)   • f6569c0e                  • android-arm    • Android 6.0.1 (API 23)
• iPhone (mobile)     • 00008030-001C710111D8802E • ios            • iOS 15.2.1 19C63
• Chrome (web)        • chrome                    • web-javascript • Google Chrome 100.0.4896.75
• No issues found!
The version of the SDK (See pubspec.lock):
6.3.0

I have the following issue:
Ever since we updated to any version > 6.2.2 we receive the following errors in the Sentry admin panel. We have made no changes at all to the code that logs to Sentry which has been in place for a long time now. Why are we seeing this?

@ajonno are you using sentry.io or self-hosted, if self-hosted, which version?
Are you enabling the performance feature?

hi @marandaneto,
we are using sentry.io.
We are not using the Performance feature (nb: there is no data in that view in the web portal).

@ajonno can you share with us your SDK init (code snippet) and a link to sentry.io where you get this error?

thanks @ajonno we'll investigate it, the property that causes it is:
{
  "trace": {
    "trace_id": null,
    "span_id": null,
    "op": "noop",
    "status": "unknown",
    "type": "trace"
  }
}

The trace metadata should never be attached to the event since performance is not enabled, also the trace is not valid anyway.

Ok great thanks for quick turnaround much appreciated. Can you please update this ticket once  the bug fix has been made available?

Oh yes, you can disable the auto transaction if you are not using it, https://docs.sentry.io/platforms/flutter/performance/instrumentation/automatic-instrumentation/#routing-instumentation
The SDK should not add the trace context if it's a noop anyway, so I'll keep the bug open.


Default logger is broken in 0.5.3

Describe the bug
Not defining a custom Logger makes it use the PrettyPrinter of the logger package instead MyLogPrinter provided by this package. Also loggingLevel has no effect because of this.
To Reproduce
Do anything that causes a log. Do not use a custom logger. Also notice that changing loggingLevel doesn't do anything
Expected behavior
I expect it to work like in 0.5.2 or before. Now, it's not using the provided methods of the Log class anymore, (like debug, warn etc.) therefore bypassing the autoInit and the factories.
System Infomation()
Flutter SDK Version: Flutter (Channel stable, 3.3.8)
Target OS and Version: (flutter web) Chrome Version 107.0.5304.107 (Official Build) (64-bit)
Host OS and Version:  Microsoft Windows [Version 10.0.19044.2251]

The current code of the Log class seems also very strange to me and overly complicated. I refactored it myself locally to this to solve this bug and also making the class much simpler:
Logger logger = Log();
class Log extends Logger {
  Log(): super(printer: MyLogPrinter('.')) {
    StackTraceNJ frames = StackTraceNJ();

    if (frames.frames != null) {
      for (Stackframe frame in frames.frames!) {
        _localPath = frame.sourceFile.path
            .substring(frame.sourceFile.path.lastIndexOf('/'));
        break;
      }
    }
  }

  static late String _localPath;
  static Level _loggingLevel = Level.debug;
  static set loggingLevel(Level loggingLevel) => _loggingLevel = loggingLevel;
}

I think this will result with identical behavior as before without all unnecessary factories and other overcomplications

Fancy a pull request?


refactor: Use bollard client for Image builds

Resolves: #129
Work Done

Use bollard API instead of unix cmds

Tests & not worth it - need to compress the whole folder using tar so Bollard can use the context & perfs are not so much better.


Channel should not send old data from local storage

May be we want to send a single trace instead of the whole batch so customer can investigate the missing data issue.

We are updating channel in the scope of this: https://github.com/Microsoft/ApplicationInsights-dotnet/issues/318
This enchantments may be obsolete.

It is implemented.
See this
// The injestion service rejects anything older than 2 days.
if (file.DateCreated > DateTimeOffset.Now.AddDays(-2))

PR: https://github.com/Microsoft/ApplicationInsights-dotnet/pull/326/


Bin and apertures check

Upon reading the aperture, bins, and kinematics files, DYNAMITE now checks for

consistent number of velocity (kinematics) bins between the kinematics and bins input files
consistent number of spatial bins between the aperture and bins input files

Tested with test_nnls.py (with provoking errors in all three input files) and "all passed" with test_notebooks.sh.
@sthater: perhaps you and/or Julia can test this with your erroneous data and verify that you get meaningful error messages.
Closes #370.

Tested with a bin.dat that was created with a bintable written in IDL, which starts at 1 instead of 0. Therefore no consistent number of velocity (kinematics) bins between the kinematics and bins input files.
Old error, that only occured at the end of a model during plotting:
ValueError: All (kin)chi2 values are nan.

Now, It successfully raised the following error:
ValueError: Numbers of kinematic bins do not match: 149 (length of gauss_hermite_kins_nifs_gh12.ecsv), 149 (last id in gauss_hermite_kins_nifs_gh12.ecsv), max number 150 in bins_nifs_idl.dat.

Hello @juliala2504,
many thanks for testing (and sorry for my late reply)! I again successfully ran test_notebooks.sh with both Python 3.12 and 3.10 and will merge into master and delete this branch...
Cheers,
Thomas


Added support for APCu Cache driver

With PHP 7.0 (and availability to use OPcache), APC is no longer the only opcode cache extension. APCu as been made available to replace the key/value component of APC.
APCu is officially supported in Doctrine\Cache since v. 1.6
I did not include any new tests since there was none to test other services, but I can, if they are required

@jfdion, would be cool, if you add the new cache Driver to the readme

@simensen looks good to me, what do you think?


Add log partitioning function

It would be nice to have some sort of function + utilities to separate the logs into semantically meaningful chunks. Motivation: as a simulation progresses, things can get increasingly unstable. We can diff CSTGs between groups of iterations to watch the instability progress.
Consider adding a function like partition_log("label_name ← (idk if we want any parameters in this function—think about it)"), and maybe some utilities to separate, analyze, and diff the logs/CSTGs.

@ashton314  try a quick version later this month --- for the JuliaCon talk. Partition in the main loop of shallow waters, or something similar.
Don't make a public interface for it yet. First let's see if the idea works at all. (I think it will, but hey this is research.)


Update serverless.yml

What did you implement:
Updated the node version since nodejs8.10 is no longer supported for creating or updating AWS Lambda functions.

How did you implement it:
Updated the serverless.yml

How can we verify it:
Deploy the example.

Todos:

[ ] Write tests
[ ] Write documentation
[ ] Fix linting errors
[ ] Make sure code coverage hasn't dropped
[ ] Provide verification config / projects / resources
[x] Enable "Allow edits from maintainers" for this PR
[x] Update the messages below

Is this ready for review?: YES
Is it a breaking change?:  I think this one should be docs

@theburningmonk
Ah, sorry! The commit lint was avoided since I fixed it directly on browser
Will create another PR for fixing the message.


Introduce annotation utils class which caches annotation to class and…

… method for increased through-put as reflection is slow.

Fork: 1 of 1
Warmup: 10 iterations, 1 s each
Measurement: 10 iterations, 1 s each
Threads: 1 thread, will synchronize iterations
Benchmark mode: Throughput, ops/time
Running: com.ea.orbit.util.test.AnnotationUtilsTest.validateAnnotationCache
Warmup Iteration   1: 4554.609 ops/ms
Warmup Iteration   2: 5841.132 ops/ms
Warmup Iteration   3: 6435.203 ops/ms
Warmup Iteration   4: 6344.103 ops/ms
Warmup Iteration   5: 6399.238 ops/ms
Warmup Iteration   6: 6420.515 ops/ms
Warmup Iteration   7: 6398.806 ops/ms
Warmup Iteration   8: 6238.948 ops/ms
Warmup Iteration   9: 6259.711 ops/ms
Warmup Iteration  10: 6432.795 ops/ms
Iteration   1: 6439.464 ops/ms
Iteration   2: 6385.065 ops/ms
Iteration   3: 6354.809 ops/ms
Iteration   4: 6304.851 ops/ms
Iteration   5: 6378.160 ops/ms
Iteration   6: 6365.325 ops/ms
Iteration   7: 6450.577 ops/ms
Iteration   8: 6292.706 ops/ms
Iteration   9: 6352.279 ops/ms
Iteration  10: 6469.955 ops/ms
Result : 6379.319 ±(95%) 42.331 ±(99%) 60.821 ops/ms
Statistics: (min, avg, max) = (6292.706, 6379.319, 6469.955), stdev = 59.179
Confidence intervals: 95% [6336.988, 6421.650], 99% [6318.498, 6440.140]
Fork: 1 of 1
Warmup: 10 iterations, 1 s each
Measurement: 10 iterations, 1 s each
Threads: 1 thread, will synchronize iterations
Benchmark mode: Throughput, ops/time
Running: com.ea.orbit.util.test.AnnotationUtilsTest.validateReflection
Warmup Iteration   1: 2446.657 ops/ms
Warmup Iteration   2: 2707.269 ops/ms
Warmup Iteration   3: 2711.998 ops/ms
Warmup Iteration   4: 2672.706 ops/ms
Warmup Iteration   5: 2712.464 ops/ms
Warmup Iteration   6: 2715.316 ops/ms
Warmup Iteration   7: 2619.297 ops/ms
Warmup Iteration   8: 2644.168 ops/ms
Warmup Iteration   9: 2677.530 ops/ms
Warmup Iteration  10: 2705.124 ops/ms
Iteration   1: 2714.140 ops/ms
Iteration   2: 2687.473 ops/ms
Iteration   3: 2715.665 ops/ms
Iteration   4: 2676.113 ops/ms
Iteration   5: 2704.872 ops/ms
Iteration   6: 2715.823 ops/ms
Iteration   7: 2705.450 ops/ms
Iteration   8: 2720.823 ops/ms
Iteration   9: 2687.831 ops/ms
Iteration  10: 2694.165 ops/ms
Result : 2702.235 ±(95%) 10.776 ±(99%) 15.482 ops/ms
Statistics: (min, avg, max) = (2676.113, 2702.235, 2720.823), stdev = 15.064
Confidence intervals: 95% [2691.460, 2713.011], 99% [2686.753, 2717.717]
Benchmark                                                 Mode Thr     Count  Sec         Mean   Mean error    Units
c.e.o.u.t.AnnotationUtilsTest.validateAnnotationCache    thrpt   1        10    1     6379.319       60.821   ops/ms
c.e.o.u.t.AnnotationUtilsTest.validateReflection         thrpt   1        10    1     2702.235       15.482   ops/ms
API replied benchmark score: 6379.319033333333 ops/ms over 10 iterations
API replied benchmark score: 2702.2352333333333 ops/ms over 10 iterations

@johnou Could you show the test source for these benchmarks?
Because we cache the java.lang.reflect.Method used in Execution.invoke so the annotations are also cached when you get to verifyActivated
(check ActorFactoryGenerator.makeReferenceClass, you'll see the method being cached in a static field)


Fix build error for the rstudio image

The RStudio image does not have access to the devtools package to install containerit from Github. Fixed this to install and use remotes instead

can you please rebase master?

also, you can avoid having to reconcile changes on the upstream's master branch with your fork's branch (which usually differ significantly due to squashed commits) by working on feature branches and open PRs from there. So you can first pull upstream changes to your local repo, then create a branch locally, and then push that branch to github and open a PR from there.

can you please rebase master?
This did not have any effect on my side. Am I missing something?

This did not have any effect on my side. Am I missing something?

sorry, I think I got confused. I thought there was a merge conflict with master but there isn't one