qLoRA notebook for LongT5

I am trying to get a longT5 version of qLORA to run.

TypeError: zeros_like requires ndarray or scalar arguments, got <class 'generator'> at position 0.

I have an error in the notebook, could you help to check ?
The error traces back to the line of code : optimizer_state = optimizer.init(params)

(QLoRA uses a data free quantization method. This is using GPT-Q)
params = model.parameters()  # Returns an iterable over the parameters

I'm guessing the issue is that params is a generator. It looks like the issue is not related to this repo.

@buttercutter Yeah that's just an example for showing the API, I have an example of how to apply it to a pretrained HuggingFace model here. There's nothing really HuggingFace specific in there though.

I tried to change your example to use LongT5 instead.
However, I got into the following runtime error:
Cell In[20], line 46, in main()
     39 lora_spec = simple_spec(params, decision_fn=decision_fn, tune_vectors=True)
     41 # Cast input parameters to np.float32
     42 #params = lax.convert_element_type(params, np.float32, params.dtype)
     43
     44 # Split the parameters up into tunable and frozen ones, and initialize a pair of LoRA matrices for each parameter
     45 # which had a spec value other than LORA_FULL or LORA_FREEZE
---> 46 freeze_params, tune_params = init_lora(params, lora_spec, jax.random.PRNGKey(0))
     48 optimizer = optax.adamw(learning_rate=1e-4, weight_decay=1e-4)
     50 # Make sure to only pass the tunable parameters to the optimizer

File ~/anaconda3/envs/arc/lib/python3.11/site-packages/lorax/helpers.py:42, in init_lora(param_tree, spec, rng, stddev, dtype, alpha, is_leaf)
     37     b = jax.random.normal(rng, (*window_shape, in_channels, spec_val), dtype=param.dtype) * stddev
     38     return LoraNode(a, b, alpha=alpha)
     40 return (
     41     jax.tree_map(freeze_getter, param_tree, spec, is_leaf=is_leaf),
---> 42     jax.tree_util.tree_map_with_path(tune_getter, param_tree, spec, is_leaf=is_leaf)
     43 )

File ~/anaconda3/envs/arc/lib/python3.11/site-packages/jax/_src/tree_util.py:788, in tree_map_with_path(f, tree, is_leaf, *rest)
    786 keypath_leaves = list(zip(*keypath_leaves))
    787 all_keypath_leaves = keypath_leaves + [treedef.flatten_up_to(r) for r in rest]
--> 788 return treedef.unflatten(f(*xs) for xs in zip(*all_keypath_leaves))

File ~/anaconda3/envs/arc/lib/python3.11/site-packages/jax/_src/tree_util.py:788, in <genexpr>(.0)
    786 keypath_leaves = list(zip(*keypath_leaves))
    787 all_keypath_leaves = keypath_leaves + [treedef.flatten_up_to(r) for r in rest]
--> 788 return treedef.unflatten(f(*xs) for xs in zip(*all_keypath_leaves))

File ~/anaconda3/envs/arc/lib/python3.11/site-packages/lorax/helpers.py:25, in init_lora.<locals>.tune_getter(path, param, spec_val)
     22 if len(param.shape) == 2:
     23     b_dim, a_dim = param.shape
---> 25     b = jnp.zeros((b_dim, spec_val), dtype=param.dtype)
     26     a = jax.random.normal(rng, (spec_val, a_dim), dtype=param.dtype) * stddev
     27     return LoraNode(a, b, alpha=alpha)

File ~/anaconda3/envs/arc/lib/python3.11/site-packages/jax/_src/numpy/lax_numpy.py:2151, in zeros(shape, dtype)
   2149 if isinstance(shape, types.GeneratorType):
   2150   raise TypeError("expected sequence object with len >= 0 or a single integer")
-> 2151 dtypes.check_user_dtype_supported(dtype, "zeros")
   2152 shape = canonicalize_shape(shape)
   2153 return lax.full(shape, 0, _jnp_dtype(dtype))

File ~/anaconda3/envs/arc/lib/python3.11/site-packages/jax/_src/dtypes.py:596, in check_user_dtype_supported(dtype, fun_name)
    594 if isinstance(dtype, type) and dtype in {bool, int, float, builtins.complex}:
    595   return
--> 596 np_dtype = np.dtype(dtype)
    597 if int4 is not None:
    598   is_custom_dtype = np_dtype.type in [*_custom_float_scalar_types, int4, uint4]

TypeError: Cannot interpret 'torch.float32' as a data type

For longT5 model, I am not really sure how to make use of (frozen_params, tunable_params) tuple and input_ids without any runtime errors.
Cell In[8], line 21, in main.<locals>.lora_forward(params, input_ids)
     19 @lora
     20 def lora_forward(params, input_ids):
---> 21     return model(input_ids)

File ~/anaconda3/envs/arc/lib/python3.11/site-packages/torch/nn/modules/module.py:1501, in Module._call_impl(self, *args, **kwargs)
   1496 # If we don't have any hooks, we want to skip the rest of the logic in
   1497 # this function, and just call forward.
   1498 if not (self._backward_hooks or self._backward_pre_hooks or self._forward_hooks or self._forward_pre_hooks
   1499         or _global_backward_pre_hooks or _global_backward_hooks
   1500         or _global_forward_hooks or _global_forward_pre_hooks):
-> 1501     return forward_call(*args, **kwargs)
   1502 # Do not call functions when jit is used
   1503 full_backward_hooks, non_full_backward_hooks = [], []

File ~/anaconda3/envs/arc/lib/python3.11/site-packages/transformers/models/longt5/modeling_longt5.py:2030, in LongT5ForConditionalGeneration.forward(self, input_ids, attention_mask, decoder_input_ids, decoder_attention_mask, head_mask, decoder_head_mask, cross_attn_head_mask, encoder_outputs, past_key_values, inputs_embeds, decoder_inputs_embeds, labels, use_cache, output_attentions, output_hidden_states, return_dict)
   2027 # Encode if needed (training, first prediction pass)
   2028 if encoder_outputs is None:
   2029     # Convert encoder inputs in embeddings if needed
-> 2030     encoder_outputs = self.encoder(
   2031         input_ids=input_ids,
   2032         attention_mask=attention_mask,
   2033         inputs_embeds=inputs_embeds,
   2034         head_mask=head_mask,
   2035         output_attentions=output_attentions,
   2036         output_hidden_states=output_hidden_states,
   2037         return_dict=return_dict,
   2038     )
   2039 elif return_dict and not isinstance(encoder_outputs, BaseModelOutput):
   2040     encoder_outputs = BaseModelOutput(
   2041         last_hidden_state=encoder_outputs[0],
   2042         hidden_states=encoder_outputs[1] if len(encoder_outputs) > 1 else None,
   2043         attentions=encoder_outputs[2] if len(encoder_outputs) > 2 else None,
   2044     )

File ~/anaconda3/envs/arc/lib/python3.11/site-packages/torch/nn/modules/module.py:1501, in Module._call_impl(self, *args, **kwargs)
   1496 # If we don't have any hooks, we want to skip the rest of the logic in
   1497 # this function, and just call forward.
   1498 if not (self._backward_hooks or self._backward_pre_hooks or self._forward_hooks or self._forward_pre_hooks
   1499         or _global_backward_pre_hooks or _global_backward_hooks
   1500         or _global_forward_hooks or _global_forward_pre_hooks):
-> 1501     return forward_call(*args, **kwargs)
   1502 # Do not call functions when jit is used
   1503 full_backward_hooks, non_full_backward_hooks = [], []

File ~/anaconda3/envs/arc/lib/python3.11/site-packages/transformers/models/longt5/modeling_longt5.py:1436, in LongT5Stack.forward(self, input_ids, attention_mask, encoder_hidden_states, encoder_attention_mask, inputs_embeds, head_mask, cross_attn_head_mask, past_key_values, use_cache, output_attentions, output_hidden_states, return_dict)
   1432     raise ValueError(
   1433         f"You cannot specify both {err_msg_prefix}input_ids and {err_msg_prefix}inputs_embeds at the same time"
   1434     )
   1435 elif input_ids is not None:
-> 1436     input_shape = input_ids.size()
   1437     input_ids = input_ids.view(-1, input_shape[-1])
   1438 elif inputs_embeds is not None:

TypeError: 'int' object is not callable

I am not particularly interested in reading stack traces for you, sorry.

oh wait, I am not posting this for help with traceback.
For https://chat.openai.com/share/2d026c56-7b00-490e-b7fd-62a76c7e49c2 and https://github.com/davisyoshida/lorax/blob/13034a29d0354d69da87ed26b7adf0627548c930/lorax/helpers.py#L8 , is there a way to adapt init_lora() coding properly for models such as longT5 which does not require both frozen_param and tuneable_param ?
Note: https://github.com/microsoft/LoRA/blob/a0d5efec36d74b5dce257492cc6943402573c4f3/loralib/layers.py#L48-L49 still splits into two separate params

The point of the lorax transform is to convert a function of the form f(params, x) into a function of the form f(arg_tuple, x) where arg_tuple = (frozen_params, tunable_params). So the point is you start with a model which doesn't expect the parameter tuple, and it gets transformed into one which does.


[DPP] [Release 24.08] E2E Integration Test passed

Description
The End-to-end tests of the DPP application needs to be passed to qualify the release requirements for the release 24.08.
Release version: v4.0.1
Acceptance Criteria

[X] EDC v0.7.3
[X] App working on INT environment
[X]  Test Case updated
[X]  Test Execution Done

We are waiting for the release v4.0.1 to be done, and then we can update the test case in the JIRA

We have now a release version published https://github.com/eclipse-tractusx/digital-product-pass/releases/tag/v4.0.1
The E2E Tests are executed

Approved by @ds-meberle


added video player examples. put example tab into separate layout file

Thanks @shirleylberry, really appreciate it!


Troposphere + recovery stack variant

Any changes you want to see for the docs? (Like maybe changing the icon I'm using for the chapter in the index...)

I tweaked a few things and squashed up everything on a new branch over here: https://github.com/GoTeamEpsilon/OpenEMR-Cloud/pull/65


Replace player ID by auto incremented int

The goal of this PR is to make the player table compatible with another tool.

The problem with this is that if another tool is holding this data, and sending raws to golbat the ids will not be aligned - since it is an auto-increment field

The problem with this is that if another tool is holding this data, and sending raws to golbat the ids will not be aligned - since it is an auto-increment field

Golbat is using the username to find and update player data. So how is it an issue?

Is this confirmed as the way you want to go? Or holding out for recent raid changes?

No it's not, hence why I made the PR a draft. In the end, I will go this way:
https://discord.com/channels/973641026117972038/1023686446671999046/1065895293939372104
But for that, I need to be able to parse the request


Issue with changing commit dates on GitHub

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
I've encountered an issue with the functionality of changing commit dates and times on GitHub. When a user changes the date and time on their computer and makes a commit, these changes are accepted without any errors, even if they are dated in the past. As a result, the user's profile displays incorrect information about the dates and times of their commits, which can lead to misunderstandings regarding the user's activity.
You can check a years of activity in my account: https://github.com/Mirzoev-Parviz
What changes are you suggesting?
Steps to reproduce:

Set an incorrect date and time on the computer.
Make a commit in a repository on GitHub.

Expected behavior:

The system should check the dates and times of commits and reject commits that are dated in the past.

Actual behavior:

Commits dated in the past are accepted without any warnings or errors.

Additional information
No response

Code of Conduct

[x]  I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
I've encountered an issue with the functionality of changing commit dates and times on GitHub. When a user changes the date and time on their computer and makes a commit, these changes are accepted without any errors, even if they are dated in the past. As a result, the user's profile displays incorrect information about the dates and times of their commits, which can lead to misunderstandings regarding the user's activity.
You can check a years of activity in my account: https://github.com/Mirzoev-Parviz
What changes are you suggesting?
Steps to reproduce:

Set an incorrect date and time on the computer.
Make a commit in a repository on GitHub.

Expected behavior:

The system should check the dates and times of commits and reject commits that are dated in the past.

Actual behavior:

Commits dated in the past are accepted without any warnings or errors.

Additional information
No response

Thanks for your cooperation

Hi @Mirzoev-Parviz 👋 ! Thank you for reaching out to GitHub Docs!
Your question would best be handled by our wonderful support team. Please reach out to them for assistance ✨
If there's anything in the documents that you have suggestions for updating, please feel free to open an issue 💛


New Instagram logo

Instagram launched a new logo - https://www.instagram-brand.com
Can you update the font to include this?
Thanks

You should contact font authors of import that icon as custom one.


Glances sensors

Home Assistant release with the issue:
0.77.3
Last working Home Assistant release (if known):
0.76.2
Operating environment (Hass.io/Docker/Windows/etc.):
Docker CE, Ubuntu 18.04, Glances 3.0
Component/platform:
Glances
https://www.home-assistant.io/components/sensor.glances/
Description of problem:
Sensor from Glances platform periodically became unavailable. Log flooded with following errors:
2018-09-04 14:46:09 ERROR (MainThread) [glances_api] Can not load data from Glances API
2018-09-04 14:46:09 ERROR (MainThread) [homeassistant.components.sensor.glances] Unable to fetch data from Glances
2018-09-04 14:51:18 ERROR (MainThread) [glances_api] Can not load data from Glances API
2018-09-04 14:51:18 ERROR (MainThread) [homeassistant.components.sensor.glances] Unable to fetch data from Glances
2018-09-04 14:56:28 ERROR (MainThread) [glances_api] Can not load data from Glances API
2018-09-04 14:56:28 ERROR (MainThread) [homeassistant.components.sensor.glances] Unable to fetch data from Glances
2018-09-04 15:01:38 ERROR (MainThread) [glances_api] Can not load data from Glances API
2018-09-04 15:01:38 ERROR (MainThread) [homeassistant.components.sensor.glances] Unable to fetch data from Glances

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
sensor:
  - platform: glances
    host: localhost
    version: 3
    resources:
      - 'processor_load'
      - 'process_thread'
      - 'memory_use'
      - 'memory_free'
      - 'disk_use_percent'
      - 'disk_free'
      - 'docker_active'
      - 'docker_cpu_use'
      - 'docker_memory_use'

Traceback (if applicable):
2018-09-04 14:46:09 ERROR (MainThread) [glances_api] Can not load data from Glances API
2018-09-04 14:46:09 ERROR (MainThread) [homeassistant.components.sensor.glances] Unable to fetch data from Glances
2018-09-04 14:51:18 ERROR (MainThread) [glances_api] Can not load data from Glances API
2018-09-04 14:51:18 ERROR (MainThread) [homeassistant.components.sensor.glances] Unable to fetch data from Glances
2018-09-04 14:56:28 ERROR (MainThread) [glances_api] Can not load data from Glances API
2018-09-04 14:56:28 ERROR (MainThread) [homeassistant.components.sensor.glances] Unable to fetch data from Glances
2018-09-04 15:01:38 ERROR (MainThread) [glances_api] Can not load data from Glances API
2018-09-04 15:01:38 ERROR (MainThread) [homeassistant.components.sensor.glances] Unable to fetch data from Glances

Additional information:

On dev it seems to work fine for me at least for the last 30 min with your configuration.
I rewrote the underlying module awhile ago for Glances 3.0 support aka support for the APIv3. Back then I didn't do a lot of testing because Glances 3.0 was not released.

There are breaking changes with the release of Glances 3.0.
https://github.com/nicolargo/glances/wiki/Glances-3.0-Release-Note

XML/RPC API have changed between Glances 2 and Glances 3. It is not possible to use a Glances 2.x client with a Glances 3.x server and conversely
Restful API upgraded to version 3 (default entry point: http://localhost:61208/api/3)

How did you install glances? Using pip or pip3?

Just reinstalled Glances using python3. Now component works without issues. It's looks like some compatability issues with glances for python2.

I did pip3 install glances as most distributions haven't updated the glances packages yet.

I will Going to close this issue. Please re-open it if you find bugs. Thanks.

I also got this error when updating my glances docker container to the latest version 3.0.  In order to get it working again I had to downgrade it to the stable version 2.11.  I even tried using version: 3 in the HA sensor configs with the latest glances image but it didn't like it.

@fabaff I am also seeing these errors even after manually installing glances. The sensors work, but there are those errors in the logs. Here's my config:
  - platform: glances
    host: <IP_ADDRESS>
    resources:
      - 'disk_use_percent'
      - 'memory_use_percent'
      - 'processor_load'

seeing the same error..

- platform: glances
  host: !secret glances_ip
  port: !secret glances_port
  resources:
    - 'disk_use_percent'
    - 'disk_use'
    - 'disk_free'
    - 'memory_use_percent'
    - 'memory_use'
    - 'memory_free'
    - 'swap_use_percent'
    - 'swap_use'
    - 'swap_free'
    - 'processor_load'
    - 'process_running'
    - 'process_total'
    - 'process_thread'
    - 'process_sleeping'
    - 'cpu_temp'
    - 'docker_active'
    - 'docker_cpu_use'
    - 'docker_memory_use'
  entity_id: sensor.time

Same issue, using latest glances docker image, config set to use v3 api
The sensors are reporting back fine, just have the following in the log
2018-09-29 07:07:17 ERROR (MainThread) [glances_api] Can not load data from Glances API
2018-09-29 07:07:17 ERROR (MainThread) [homeassistant.components.sensor.glances] Unable to fetch data from Glances
Config
- platform: glances   host: <IP_ADDRESS>   name: docker_host   version: 3   post: 61208   resources:       - 'disk_use_percent'       - 'memory_use_percent'       - 'processor_load'       - 'cpu_temp'       - 'docker_active'

I am have the same issue...

I just tried these sensors on Hassio 0.84.6:
- platform: glances
  host: <IP_ADDRESS>
  name: MQTT Slave
  resources:
    - 'processor_load'
    - 'memory_use_percent'
    - 'swap_use_percent'
    - 'disk_use_percent'
    - 'cpu_temp'

I installed glances using pip and pip3. I can see glances for this remote machine using a web browser or terminal but HA keeps logging that the glances platform is not ready, retrying in xx seconds (where xx keeps increasing by 30 seconds).

Any Progress on this? well i too have this issue:
2019-04-17 08:25:08 ERROR (MainThread) [glances_api] Can not load data from Glances API 2019-04-17 08:25:08 ERROR (MainThread) [homeassistant.components.glances.sensor] Unable to fetch data from Glances
And sensor data is still pulled no problem.
Here is my configuration:
  - platform: glances     name: docker     host: <IP_ADDRESS>     port: 61208     username: !secret glances_user     password: !secret glances_password     version: 3     resources:       - 'processor_load'       - 'memory_use_percent'       - 'disk_use_percent'

I have the same problem. installed glances addon into hassio v0.93.1.
addon config
{   "log_level": "trace",   "process_info": true,   "refresh_time": 10,   "ssl": true,   "certfile": "fullchain.pem",   "keyfile": "privkey.pem",   "influxdb": {     "enabled": true,     "host": "a0d7b954-influxdb",     "port": 8086,     "username": "umerglances",     "password": "Truelies_1981",     "database": "glances",     "prefix": "localhost",     "interval": 60   } }
i have also set the network of addon to map 61208 to 80 of container.
the sensor config is as follows, though i have seen people using user name and password but wasnt sure if what i should use. the Hassio access credentials?
  - platform: glances     name: i5glances     version: 3     resources:       - 'disk_use_percent'

Got it working somehow, i think i disabled ssl_verify and enabled ssl. also provided the login credentials for HASSIO instance in the sensor config

@bastshoes
I'm having the same problem but I can't find where to change the timeout value. Can you tell me where? Thnx

I'm also using the Hass.IO plugin and all is working fine, I did notice I needed to change the port to 61209
  - platform: glances
    host: <IP_ADDRESS>
    port: 61209
    name: Athena
    version: 3
    resources:
      - disk_use_percent
      - disk_use
      - disk_free
      - memory_use_percent
      - memory_use
      - memory_free
      - swap_use_percent
      - swap_use
      - swap_free
      - processor_load
      - process_running
      - process_total
      - process_thread
      - process_sleeping
      - cpu_use_percent
      - cpu_temp
      - docker_active
      - docker_cpu_use
      - docker_memory_use

{   "log_level": "info",   "process_info": true,   "refresh_time": 10,   "ssl": false }


enh(gdrive incremental sync): cancel running activity on timeout

Description
The problem
Today, when a workflow is terminated/cancelled or when an activity runs longer than its startToCloseTimeout, the activity is considered failed/cancelled on temporal's side, but the actual process continues to run on the worker. This is because our activities currently only communicate with the temporal server when they begin and when they end, so temporal cannot communicate them when they need to stop their work.
This is an issue:

long activities that timeout might run for a veeeeeery long time on the worker, consuming resources, doing API calls, and squatting a worker slot (while temporal is already retrying them)
activites with a short timeout, when they timeout, can be running multiple times concurrently because they are being retried immediately after timing out (but original execution i s still actually running on the worker). These take worker slots as well.

the solution
Temporal has something that is called a heartbeat. This is used for 2 reasons:

let temporal know that the activity is still running
let the activity know if it got "cancelled" (timed out or parent workflow cancelled / terminated)

When we import activities in the workflow, we can set a heartbeatTimeout: if the activity doesn't send any heartbeat for longer than this duration, the activity will be considered as failed by temporal.
in practice, to send a heartbeat, an activity must call Context.current().heartbeat(). But this function doesn't directly send a heartbeat: instead, it queues a heartbeat. Indeed, heartbeats in temporal are throttled using heartbeatTimeout. If heartbeatTimeout is 100ms, then the activity will send at most one heartbeat every 100ms, even if Context.current().heartbeat() was called many times during the period. It's also important to not that even if the activity is cancelled, calling Context.current().heartbeat() will not throw any exception. When the heartbeat actually happens (which happens when the "heartbeat queue" next execution takes place, not upon calling Context.current().heartbeat()), the information that the activity is cancelled will start being available in the activity's context.
This information is accessible is two ways:

Context.current().cancelled -> this promise never resolves, but rejects if the activity is marked as cancelled. it's not super practical to use, because awaiting it is blocking.
Context.current().sleep() will reject

For this reason, I am introducing this helper:
// This function allows to heartbeat back to the temporal workflow, but also
// awaits a temporal sleep(0), which allows to throw an exception if the activity should be cancelled.
export async function heartbeat() {
  Context.current().heartbeat();
  await Context.current().sleep(0);
}

This can be awaited instead of Context.current().heartbeat() in order to heartbeat but also get an exception if the activity is timed-out.
I have no idea why temporal doesn't provide something like this out of the box.
It's important to note that activity cancellation will be effective on the call to heartbeat that immediately follows the first temporal heartbeat (remember, this is throttled by heartbeatTimeout) after the activity was cancelled.
So picking a short heartbeatTimeout is important, if the heartbeatTimeout is 30 minutes, the activity might spin in the void for more than 30 minutes before stopping.
Risk
Unless API calls to Gdrive take more than 5 minutes we should be fine.
Deploy Plan

Yes definitely 👍


chore(deps): upgrade configuration

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-configuration-k8s-29-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4914

Questions ?
Please refer to the Backport tool documentation


[feature] Option for automatic renaming

Describe your idea
While working on some Android application, I noticed that sometimes classes have useful information in toString() or log methods. e.g.
public String toString() {
        String str = this.a;
        String str2 = this.b;
        TokenProvider tokenProvider = this.c;
        return "PlatformServiceConfig(apiUrl=" + str + ", apiKey=" + str2 + ", tokenProvider=" + tokenProvider + ")";
 }

It would be nice to automate these class/attributes rename

Next Jadx version will have scripting support so you can write your own deobfuscation code.
You can test this version by downloading the latest unstable version. See also the existing sample scripts https://github.com/skylot/jadx/tree/master/jadx-plugins/jadx-script/examples/scripts

@MarcoBalossini unfortunately toString patterns can be very different, so it is hard to implement a common solution. Scripts is the only way. I commit simple implementation for your case, check deobf_from_tostring example. Hope it will work for your apk :slightly_smiling_face:

@skylot thanks a lot for the script

Hi @skylot , thanks for your help!
I have an APK with a lot of "toString" functions but the arguments and objects names remained the same (a,b,c). is this should work only for kotlin? if so, how can I change it to java too?
Thank you!!!


Use 4 byte error selectors

Modify constants for error encoding to use left-padded uints so they are compiled to push4. Reduces contract size by ~0.5kb

Codecov Report
Base: 100.00% // Head: 99.74% // Decreases project coverage by -0.25% :warning:

Coverage data is based on head (2416bf3) compared to base (59f00d7).
Patch coverage: 93.50% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##               1.2     #663      +/-   ##
===========================================
- Coverage   100.00%   99.74%   -0.26%
===========================================
  Files           45       46       +1
  Lines         1918     1953      +35
  Branches       322      321       -1
===========================================
+ Hits          1918     1948      +30
- Misses           0        5       +5

Flag
Coverage Δ

production
99.48% <93.50%> (-0.52%)
:arrow_down:

reference
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

contracts/lib/AmountDeriver.sol
100.00% <ø> (ø)

contracts/lib/SignatureVerification.sol
100.00% <ø> (ø)

contracts/lib/TokenTransferrer.sol
100.00% <ø> (ø)

contracts/lib/ConsiderationErrors.sol
86.11% <86.11%> (ø)

contracts/lib/Assertions.sol
100.00% <100.00%> (ø)

contracts/lib/BasicOrderFulfiller.sol
100.00% <100.00%> (ø)

contracts/lib/CriteriaResolution.sol
100.00% <100.00%> (ø)

contracts/lib/Executor.sol
100.00% <100.00%> (ø)

contracts/lib/FulfillmentApplier.sol
100.00% <100.00%> (ø)

contracts/lib/OrderCombiner.sol
100.00% <100.00%> (ø)

... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


New table: actortype_taxonomies

simple many-to-many "join" table linking actortypes with taxonomies
determines which taxonomy categories may be applied to an actor by type
corresponds to existing table "framework_taxonomies"
configuration table

Permissions by role

public: none
registered, no role: none
analyst: R
manager: R
admin: R

@parndt if easy to change please change name from actor_type_taxonomies to actortype_taxonomies as per specification

see #57

Fixed by #61

rename table to actortype_taxonomies as specified and consistent with previous join tables


Multiline commit message are incorrectly marked as too long

When a commit message is longer than 80 characters, it displays as red, even when the 80 characters are split up over multiple lines. I will have a look at fixing it.

The colored characters have been introduced in #65 and currently simply counts the characters of the commit message.

That's what I figured. I will work on it. shouldn't take too long.

ah great, just stumbled upon this and now i see it’s already fixed on master :smile:


Fix #29

#29
PR Type

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Others. (Please describe)

PR Info.
Changes

CreateAssignmentApiSerializer's tag field now inherit from CreateTagApiSerializer

Fixes

Calling the GET All API returning the 500 telling that CustomUser is not JSON serializable. #29

🔧🔧🔧

Codecov Report

Merging #30 (ddaef92) into master (d10d38d) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   92.93%   92.70%   -0.24%
==========================================
  Files          46       46
  Lines         708      699       -9
  Branches       18       18
==========================================
- Hits          658      648      -10
- Misses         44       45       +1
  Partials        6        6

Impacted Files
Coverage Δ

garnbarn_api/serializer.py
83.14% <100.00%> (-2.57%)
:arrow_down:

garnbarn_api/tests/test_view.py
100.00% <100.00%> (ø)

garnbarn_api/views.py
90.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d10d38d...ddaef92. Read the comment docs.


KAFKA-2389: remove commit type from new consumer.

A shot to remove commit type from new consumer. The coordinator constructor takes a default offset commit callback mainly for testing purpose.

LGTM. I thought it was a little weird before to have a callback in the synchronous case. I've also considered making the behavior explicit by naming the methods "commitSync" and "commitAsync," but I don't think it's necessary.

Left some comments on things you might want to tweak, but otherwise LGTM.

@becketqin Did the commit history get screwed up somehow? This seems to be including a bunch of unrelated stuff.

@becketqin could you rebase on trunk? There are too many unrelated diff files which makes it very hard to review.

@guozhangwang @hachikuji Yes.... I must have done something wrong.... I don't know how to fix it. Do you mind if close this PR and open another one?

@becketqin Looks like you may have merged instead of rebasing (there's still the initial commit at the front of the history). You might have to rewind to the initial commit and try the rebase again (maybe someone else knows a better way?). Anyway, if you fix the problem in your local branch, you should be able to do a 'push -f' to update this PR.

@hachikuji Awesome, you are right, what I need is a push -f. Thanks for help.

@becketqin Minor thing, but I think there might be an example in the class-level javadoc for KafkaConsumer that needs updating.

@hachikuji Good catch. I missed that one.

LGTM

Thanks @becketqin @hachikuji , I left some comments on the ticket regarding the names. Other than that the implementation LGTM.

@guozhangwang Ping for review. I just rebased on trunk. I want to wait for this to be checked in before adding new consumer to mirror maker. Thanks!

@guozhangwang ping.

Hey @becketqin, sorry for being late.. will try to take a look again today.

LGTM.


Collides with SimpleSchema/Collection2

Hey,
after adding the package, I get the following error if I try to add a document in one of my collections:
SimpleSchema.clean: filtered out value that would have affected key "last_message", which is not  allowed by the schema
[..same message for other fields..]

The affected collection doesn't have a Schema - also I didn't set {tx:true} or started a transaction at the beginning.
Before that insert, I do a insert into another collection, which has a Schema. This insert works without problems.

https://github.com/JackAdams/meteor-transactions/blob/master/lib/transactions-common.js#L1471 is the offending line of code.  It's supposed to prevent schema from being automatically added to collections with no schema attached, but it's obviously not doing that.  Should be an easy fix.

Okay, just released a new version that will, I hope, fix this.  If it's not fixed, and you've got time, I'd really appreciate a simple repro so I can sort it out properly.


Migrate to Meteor 1.0.4

Meteor just released 1.0.4, see [1]
Would be great, if the universal fork follows
Many thanks in advance!
;-)
[1] https://www.meteor.com/blog/2015/03/17/meteor-104-mongo-cordova-template-subscriptions

Hi Wolfram ( @derwok )
I will automatically update the meteor universal to latest stable branches.
Normally MDG will send out some updates to meteor few days after next stable release.
So I wait some days until the meteor release is defined as stable. Same for this release, its now <IP_ADDRESS>.
Meteor universal is now updated to <IP_ADDRESS>

Its now already 1.0.5 :-)


Update tone integration docs - 3

Updating instances of EI, WSO2 EI, and Enterprise Integrator.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[hotfix] Fix database initialize late in standalone.

Purpose of the pull request
When I start StandaloneServer, find the master will throw exception:
[ERROR] 2022-05-30 18:37:34.967 +0800 org.apache.dolphinscheduler.server.master.registry.ServerNodeManager:[221] - WorkerNodeInfoAndGroupDbSyncTask error:
org.springframework.jdbc.BadSqlGrammarException:
### Error querying database.  Cause: org.h2.jdbc.JdbcSQLSyntaxErrorException: Table "t_ds_worker_group" not found; SQL statement:
select *
        from t_ds_worker_group
        order by update_time desc [42102-200]
### The error may exist in file [/Users/ruanwenjun/Project/Github/dolphinscheduler/dolphinscheduler-dao/target/classes/org/apache/dolphinscheduler/dao/mapper/WorkerGroupMapper.xml]
### The error may involve org.apache.dolphinscheduler.dao.mapper.WorkerGroupMapper.queryAllWorkerGroup
### The error occurred while executing a query
### SQL: select *         from t_ds_worker_group         order by update_time desc
### Cause: org.h2.jdbc.JdbcSQLSyntaxErrorException: Table "t_ds_worker_group" not found; SQL statement:
select *
        from t_ds_worker_group
        order by update_time desc [42102-200]
; bad SQL grammar []; nested exception is org.h2.jdbc.JdbcSQLSyntaxErrorException: Table "t_ds_worker_group" not found; SQL statement:
select *
        from t_ds_worker_group
        order by update_time desc [42102-200]

This is caused by the h2 database is not initialized when we query the work group.
Brief change log
Inject the DataSourceScriptDatabaseInitializer to make sure the database is initialized after we can get connector.
Verify this pull request
Start StandaloneServer, find there is no exception.

I saw this bug in 2.0.6 version. The same error message.

Fix database initialize late in standalone. (

You can follow this PR #10296.

Thanks, it works for me.


Starter documentation?

Hey, I'm looking to improve our overall coherence in projects and our back-end team is thinking of using archunit, as such I found your project.
It seems like a great tool! I just have one problem, I have no experience with your tool and next to no experience with jest. What do I have to do to get started?
The documentation doesn't really cover getting started afaics.
Your docs here state npm install --save-dev tsarch. Cool straightforward enough.
Then under it, it gives an example of a spec file. Ok, cool, so I copy this as an experiment and create arch.spec.js.
Play around a bit to create arch.spec.js;
import "tsarch/dist/jest.js"; // << appended '.js' here as node was complaining about it.
import { filesOfProject } from "tsarch";

describe("Architecture tests", () => {
  it("N00b's first dummy test", async () => {
    const rule = filesOfProject()
      .inFolder("some folder")
      .shouldNot()
      .dependOnFiles()
      .inFolder("someotherfolder");

    const violations = await rule.check;
    expect(violations).toEqual([]);
  });
});

But what do I do from here? Do I install jest and create an npm run jest script? In that case if complains about a malformed spec file. Or do I run something like node arch.spec.js? If I do that, it throws errors such as

Is there anywhere where this is documented? I couldn't find anything on so, google, or youtube either. If this isn't documented anywhere, I can open a PR with our own internal documentation backported once I've written it to help out.

Ah, I think I might have figured it out. Found a older project here which showed me what I was doing wrong.
Will work it out further next week and might write a getting started document.


treat user input as text, not HTML

Sorry for the delay on merging this, I didn't know it was there.


Secret scrub OTEL logs

Currently we use the secret scrubber just for the results of withExec - this is neccessary so we don't end up accidentally caching secrets in the output.
However, this isn't entirely sufficient - secrets can still appear in the logs, for example by calling dagger call get-secret plaintext (where get-secret is a field that returns a Secret). Since these logs are uploaded to dagger cloud, we should censor all the logs.
This will additionally have the effect of scrubbing the cli output, which is probably desirable?
Related:

https://github.com/dagger/dagger/issues/8464

100% agree with scrubbing this from the OTEL logs and agree with scrubbing it from CLI output other than the one case where a user explicitly asks for the CLI to output the plaintext secret (e.g. dagger call get-secret plaintext).

I think we should have an exception for that case since it seems like a valid use case for dagger to support telling users the values of secrets created by modules. E.g. a module that generates certs for you would likely model private keys as Secrets, but it also makes sense to print those out if the user explicitly does dagger call cert-gen private-key plaintext

Hypothetical implementation notes:

The client-side doesn't know the values of all secrets created in the session. It could know the ones it explicitly created via SetSecret, but Secrets can also be created by module function calls, in which case the value is set server-side
The current best idea I can think of is to create a session attachable that tells the client every secret that gets created in the session. We'd just call this attachable every time a secret is created and the client would store the key/values in an in-memory map.
Then the client should be able to do scrubbing of any secrets on its side then too (OTEL, terminal output other than the case mentioned above where plaintext is explicitly called, etc.)

Yeah, I agree we should let the user get the plaintext if explicitly requested in the CLI output, just scrubbed from OTEL. For example you could use a dagger module to get a secret like you can with the op CLI.


merge layer documentation and architecture

I built a project using (Merge, merge) layer once, and use share layer in another. The problem I can't find any documentation that explains how merge or share layer works like convolution or max-pooling layers.
I will be grateful if anyone can direct me or suggest some paper to me that helps me to understand how these layers work ???

From the existing documentation and by reading the source code: Merge will take two input tensor and will combine them according to the defined operation, the operation may be of a mathematical nature such as addition, subtraction, getting the maximum or minimum value or can simply concatenate the data by agglomerating the two input tensor in a single one i.e.:  two array of dimensions [2,2] will become [4,2] or [2,4] depending on the axis of concatenation.
Also note that every mathematical operation is performed element-wise.


Prevent Original Agario Script?

How would i completely remove the original Agario Client code before ANY of it executes and run my own code instead?

See http://tampermonkey.net/documentation.php#_run_at


Test coverage wrong when importing large library

Type: Bug

Create a simple project that imports MONAI with a test
Open the Testing tab and run tests with coverage
Module-level lines (e.g. imports, class definitions, and function definitions) will show as missed in the coverage report

Extension version: 2024.16.0
VS Code version: Code 1.94.0 (d78a74bcdfad14d5d3b1b782f87255d802b57511, 2024-10-02T13:08:12.626Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Remote OS version: Linux x64 4.18.0-348.23.1.el8_5.x86_64
Remote OS version: Linux x64 4.18.0-348.23.1.el8_5.x86_64
Remote OS version: Linux x64 4.18.0-348.23.1.el8_5.x86_64
Remote OS version: Linux x64 4.18.0-348.23.1.el8_5.x86_64

System Info

Item
Value

CPUs
AMD Ryzen 7 5825U with Radeon Graphics          (16 x 1996)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabledwebnn: disabled_off

Load (avg)
undefined

Memory (System)
38.83GB (21.36GB free)

Process Argv
--file-uri file:///c%3A/Users/mvine/Documents/Programming/goliath-fragct.code-workspace

Screen Reader
no

VM
0%

Item
Value

Remote
SSH: <IP_ADDRESS>

OS
Linux x64 4.18.0-348.23.1.el8_5.x86_64

CPUs
AMD Ryzen 9 5950X 16-Core Processor (32 x 3650)

Memory (System)
125.82GB (89.95GB free)

VM
0%

Item
Value

Remote
SSH: <IP_ADDRESS>

OS
Linux x64 4.18.0-348.23.1.el8_5.x86_64

CPUs
AMD Ryzen 9 5950X 16-Core Processor (32 x 3650)

Memory (System)
125.82GB (89.95GB free)

VM
0%

Item
Value

Remote
SSH: <IP_ADDRESS>

OS
Linux x64 4.18.0-348.23.1.el8_5.x86_64

CPUs
AMD Ryzen 9 5950X 16-Core Processor (32 x 3650)

Memory (System)
125.82GB (89.95GB free)

VM
0%

Item
Value

Remote
SSH: <IP_ADDRESS>

OS
Linux x64 4.18.0-348.23.1.el8_5.x86_64

CPUs
AMD Ryzen 9 5950X 16-Core Processor (32 x 3589)

Memory (System)
125.82GB (89.95GB free)

VM
0%

thank you for the bug report! Could you include what is shown if you run coverage from the terminal as comparison?

thank you for the bug report! Could you include what is shown if you run coverage from the terminal as comparison?

Sure thing:
---------- coverage: platform linux, python 3.11.6-final-0 -----------
Name                     Stmts   Miss  Cover   Missing
------------------------------------------------------
app/__init__.py              0      0   100%
app/main.py                  1      0   100%
app/tests/__init__.py        0      0   100%
app/tests/test_main.py       3      0   100%
------------------------------------------------------
TOTAL                        4      0   100%

@eleanorjboyd any update on this? Anything more I can provide to help debug?

What is your root dir when you run it from the terminal? You can see what one is selected for running tests in vscode and so im trying to figure out what setting could be different between what you are putting in the terminal and the extension might be passing to run coverage in the UI.

My root directory is test_coverage.

I also ran the full command exactly as it shows in the terminal excluding the -p argument: pytest --cov=. --cov-report term-missing --rootdir=/home/mvine/Documents/test_coverage /home/mvine/Documents/test_coverage/app/tests/test_main.py::test and got the same results. My suspicions are that either the plugin is doing something or the --cov=. is not working because it's using a relative path. However, I tested running the previous command from /home/mvine/Documents/test_coverage/app/tests, /home/mvine/Documents/test_coverage/app, /home/mvine/Documents/test_coverage, and /home/mvine/Documents without replicating the problem.

I will create a new virtual environment trying to replicate VS Code's as closely as possible. But the test coverage is correct in the terminal, VS Code's is wrong. Do you know how I can get the vscode pytest plugin?
I think I can remove the term missing stuff from the command as well. That's just the command I normally run.

I created a new virtual environment, ran pip install monai pytest pytest-cov and the integrated test reported 100% coverage. I then ran pip install faker==22.2.0 pytest-timeout==2.3.1 anyio==4.4.0 pytest-cov==5.0.0 dash==2.16.1 pytest-xdist==3.5.0 pytest-drop-dup-tests==1.0.0 pytest-mock==3.14.0 typeguard==4.3.0 to install the identical plugins and it still reported 100% coverage. I am now going through every library in my massive virtual environment to find which is causing the problem 😩

It's opencv-python!

pip install opencv-python pytest pytest-cov
Have a file with the line import cv2 (change monai to cv2)
Test coverage breaks

Yeah, the warnings are fine: https://github.com/nedbat/coveragepy/issues/1653

Aha, problem solved! Adding the config file as described in this comment resolves the problem: https://github.com/nedbat/coveragepy/issues/1653#issuecomment-1653730387!
This is probably still a problem though because my terminal doesn't match the integrated test coverage.

Hi @MattTheCuber, thanks for all your investigation help! I have just put in the a fix for the NoSource issue. Are you seeing the same issues with your terminal not matching like above or does it look different now? If it looks different and you could send an updated screenshot that would be great. One note is you might see rounding discrepancies in the coverage numbers between terminal and the sidebar so just an fyi there.

Which version of the extension should I test?


move Evidence Notes text field to below Summary Text field

On Edit page.. this should support ~2 sentences of text


Keyboard shortcuts not working

Description
Keybord shortcuts not working. So I can't get the preview for .md files or the side-by-side comparison between version for other files.
Desktop

Windows 10 1903 18362.267

You are using v<IP_ADDRESS> right? DiffViewer and Markdown are first added in v<IP_ADDRESS>.

Yes I use :

Okay my bad, I just got the update actually, I see it now...
By curiosity, what tool do you use for the MD preview ?

This is the control I use to render Markdown: https://docs.microsoft.com/en-us/windows/communitytoolkit/controls/markdowntextblock


[BUG] cannot pickle 'mappingproxy' object when using TabularFeatures create_categorical

Bug description
I have a bug just creating a schema programmatically. Can you help me on this?
thx
Steps/Code to reproduce bug
import merlin_standard_lib as msl
from merlin_standard_lib import Schema
from transformers4rec.torch.features.tabular import TabularFeatures

features_schema = Schema([msl.ColumnSchema.create_categorical("language", num_items=149),]
        )
a = TabularFeatures.from_schema(
        features_schema,
    )

I have TypeError: cannot pickle 'mappingproxy' object
coming from
│ /home/mdenadai/miniconda3/envs/gnn/lib/python3.9/site-packages/transformers4rec/torch/features/t │
│ abular.py:175 in from_schema                                                                     │
│                                                                                │
│   172 │   │   │   │   │   **kwargs,                                                              │
│   173 │   │   │   │   )                                                                          │
│   174 │   │   │   else:                                                                          │
│ ❱ 175 │   │   │   │   maybe_continuous_module = cls.CONTINUOUS_MODULE_CLASS.from_schema(         │
│   176 │   │   │   │   │   schema, tags=continuous_tags, **kwargs                                 │
│   177 │   │   │   │   )                                                                          │
│   178 │   │   if categorical_tags:                                                               │
│                                                                                │
│ /home/mdenadai/miniconda3/envs/gnn/lib/python3.9/site-packages/transformers4rec/torch/tabular/ba │
│ se.py:190 in from_schema                                                                         │
│                                                                                │
│   187 │   │   -------                                                                            │
│   188 │   │   Optional[TabularModule]                                                            │
│   189 │   │   """                                                                                │
│ ❱ 190 │   │   schema_copy = deepcopy(schema)                                                     │
│   191 │   │   if tags:                                                                           │
│   192 │   │   │   schema_copy = schema_copy.select_by_tag(tags)

This happens even when I just do:
import deepcopy
import merlin_standard_lib as msl
from merlin_standard_lib import Schema
from transformers4rec.torch.features.tabular import TabularFeatures

deepcopy(Schema([msl.ColumnSchema.create_categorical("language", num_items=149),]))

Environment details

Transformers4Rec version: 23.6.0
Platform: unix
Python version: 3.9

It seems that if I removeint_domain from ColumnSchema everthing can be copied
class ColumnSchema(Feature):
    @classmethod
    def create_categorical(
        cls,
        name: str,
        num_items: int,
        shape: Optional[Union[Tuple[int, ...], List[int]]] = None,
        value_count: Optional[Union[ValueCount, ValueCountList]] = None,
        min_index: int = 0,
        tags: Optional[TagsType] = None,
        **kwargs,
    ) -> "ColumnSchema":
        _tags: List[str] = [t.value for t in TagSet(tags or [])]

        extra = _parse_shape_and_value_count(shape, value_count)
        int_domain = IntDomain(name=name, min=min_index, max=num_items, is_categorical=True)
        _tags = list(set(_tags + [Tags.CATEGORICAL.value]))
        extra["type"] = FeatureType.INT

        return cls(name=name, int_domain=int_domain, **extra, **kwargs).with_tags(_tags)

and it gets solved with betterproto 2.0, maybe because of https://github.com/danielgtaylor/python-betterproto/pull/339. However, this creates a dependency clash
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. merlin-core 23.6.0 requires betterproto<2.0.0, but you have betterproto 2.0.0b6 which is incompatible.

Thanks for the detailed bug report and the fix.
You can try updating the dependencies in requirements.txt; there's a reasonable chance that it'll work.  We're unfortunately not able to update our containers at this time but if you can test that it's working we'd love a PR with your solution.

@denadai2 Did you ever figure out a solution to this?


error parsing toml config

I just tried to run the latest version from git and my configuration fails now on: config: value mapped to "fields" is []interface {} not []string
By the looks of it the cause is #411 where fields, err := vc.StringSlice(ConfigKeyFields) was changed into fields, err := layer.StringSlice(ConfigKeyFields) with vc being a dict and layer not a dict  in provider/postgis/postgis.go: https://github.com/go-spatial/tegola/blame/638968429bec58da56f1b008ae36d70e207117aa/provider/postgis/postgis.go#L174
Should the config be changed, or is there a bug in the code?
The .config.toml used:
[webserver]
port = "<IP_ADDRESS>:9797"              # port to bind the web server to. defaults ":8080"

[cache]
type="file"
basepath="/tmp/tegola"

# register data providers
[[providers]]
name = "foo"       # provider name is referenced from map layers (required)
type = "foo"            # the type of data provider. currently only supports postgis (required)
host = "foo"         # postgis database host (required)
port = 5432                 # postgis database port (required)
database = "foo"           # postgis database name (required)
user = "foo"           # postgis database user (required)
password = "foo"               # postgis database password (required)
srid = 3857                 # The default srid for this provider. Defaults to WebMercator (3857) (optiona
max_connections = 50        # The max connections to maintain in the connection pool. Default is 100. (op

# WATER
    [[providers.layers]]
    name = "water1000"
    tablename = "top1000.waterdeel"
    geometry_fieldname = "geometrie_vlak_3857"
    id_fieldname = "ogc_fid"
    srid = 3857
    fields = [ "ogc_fid"]

@stvno  thanks for the report. We will dig into this quickly. The config parsing was overhauled in v0.7.0 and we want to get this fixed before the release. Thanks for testing this.
@ear7h can you take a look at this?

I can take care of this

just to make it clear, I've always used the 0.7.0-branch

The changes were merged into v0.7.0 recently. I just submitted a PR for this issue, fee free to pull it and test it

This is now fixed in v0.7.0


add browsers-node12.14.1-chrome85-ff81

add browsers-node12.14.1-chrome85-ff81

oh now, it failed!!!! @Bkucera

why did it fail!?

you could look at the build job output ...

thanks auto formatter..


Test with whois.ra.net

Test with server: whois.ra.net

this server will have to be tested for each query method to determine if will support it.


Documentation bug: unclear how to use pre-release versions of Rustup.

This change is something I'm super excited about, unfortunately it looks like it hasn't made it to the release version of rustup. I dug into the README.md file looking for a way to use the rustup nightly but didn't find anything.

We talked about this on IRC, right? There is no "rustup nightly". Can this be closed?


feat: Add Slack and Jira Source file uploads and 3P embedding model config example for corpus creation

Add Slack and Jira Source file uploads and 3P embedding model config example for corpus creation

If you are opening a PR for Community Notebooks under the notebooks/community folder:

[X ] This notebook has been added to the CODEOWNERS file under the Community Notebooks section, pointing to the author or the author's team.
[ X] Passes all the required formatting and linting checks. You can locally test with these instructions.

Adding @qizzzh to this pull request for review.


build problem on ubuntu -gcc 9.3

Running Environment (please complete the following information):
Ubuntu
GCC  9.3
//simplessd-fullsystem# git show -s HEAD
commit 96377cf409f1bc10d8b5678221f1aa16b1cb0d06 (HEAD -> master, tag: v2.0.10, origin/master, origin/HEAD)
Author: Donghyun Gouk<EMAIL_ADDRESS>Date:   Sat Apr 4 04:19:42 2020 +0900
//simplessd-fullsystem# cd src/dev/storage/simplessd/
//simplessd-fullsystem/src/dev/storage/simplessd# git show -s HEAD
commit 73ad8ad5220ce5ebfeb055687d0328765a046c0f (HEAD, tag: v2.0.13)
Author: Donghyun Gouk<EMAIL_ADDRESS>Date:   Sun Feb 2 02:16:25 2020 +0900
Release SimpleSSD version 2.0.13

Explain what you want to ask here:
when try to build this error is appear:
TypeError: argument should be integer or bytes-like object, not 'str':
File "///simplessd-fullsystem/SConstruct", line 357:
main['GCC'] = CXX_version and CXX_version.find('g++') >= 0
IS not support this version of GCC???

Hi,
The error message is coming from scons (python) not GCC.
Please use python version 2.7 not 3.x, because gem5 v19 does not support python 3.
(gem5 v20 supports python 3, but I did not merged them to SimpleSSD-FullSystem)
Thanks.


chore: remove commented out lines

Description

This PR removes commented out lines that are not useful anymore. I have verified with Abhinav and Hetu that these lines can be removed now.

PR fixes following issue(s)
Fixes #25780
Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Chore (housekeeping or task changes that don't impact user perception)

Testing

How Has This Been Tested?

Does not apply.

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test


fromhttpstream not saving Endpoint value

I'm adding a fromhttpstream block to the UI and enter an Endpoint value. Within a few seconds the value disappears and is not saved. It doesn't matter if I hit the Update button or close the popup options. I've tried multiple endpoint values but nothing will save which makes logging impossible.
I'm using Mac OSX Yosemite and have tried both Safari and Chrome.

Same problem. Did you find a solution ? @kylegrussell Thx.


Docs: Programmatic play/pause/seek

I'm migrating from ReactPlayer to this and am seeing a lot of missing documented features in the general repo README. I might not realize all of the following are native capabilities, but generally I imagine it would be useful to have some explainers of the following:

How to programmatically control play/pause
How to programmatically seek
Best ways to to control react state that control the player (ie. useState for handling play/pause/seekTo)
How to know when the video is ready to play (ie. isReady useState update)

Yes I also need to programmatically start the player

I'm also looking to programmatically seek (continue user from where they last left off)

+1. Is this currently possible?

Sorry for the slow reply, we worked out a process for tracking issues and this one slipped through the cracks.
Mux Player can be controlled programmatically with the same APIs as the HTML5 video element and it also fires the same events.
So you can do things like:
muxPlayer = document.querySelector('mux-player');

muxPlayer.play(); // player
muxPlayer.currentTime = 67; // set current time to 67 seconds

muxPlayer.addEventListener('timeupdate', function () {. });
muxPlayer.addEventListener('canplay', function () {. });

I think we should add some documentation on docs.mux.com about this, but the TLDR is that with Mux Player we've intentionally kept it consistent with HTML5 video.
If there are more specific questions, please ask and we're happy to help!

Thanks @dylanjha  - Just after I posted here, I found this issue, and realized I can use the video API. Appreciate this clarity though, and yes, noting in the docs will likely be helpful for future users.
Thanks again for the speedy response!


7.124.424 - Line 10811 has error='key not found in database'

Upon upgrading to v7.124.424, I'm getting the following error.
`Aug 24, 2020 at 1:27:36 PM
Enabling plugin "piBeacon 7.124.424"
Starting plugin "piBeacon 7.124.424" (pid 14794)
piBeacon                        initializing	 ...
piBeacon                        path To files:          =================
piBeacon                        indigo                  /Library/Application Support/Perceptive Automation/
piBeacon                        installFolder           /Library/Application Support/Perceptive Automation/Indigo 7.4/
piBeacon                        plugin.py               /Library/Application Support/Perceptive Automation/Indigo 7.4/Plugins/piBeacon.indigoPlugin/Contents/Server Plugin/
piBeacon                        Plugin params           /Library/Application Support/Perceptive Automation/Indigo 7.4/Preferences/Plugins/com.karlwachs.piBeacon/
piBeacon Warning                !!!!INFO ONLY!!!!  logger  enabled for   WARNING       !!!!INFO ONLY!!!!
piBeacon Error                  !!!!INFO ONLY!!!!  logger  enabled for   ERROR         !!!!INFO ONLY!!!!
piBeacon Critical Error         !!!!INFO ONLY!!!!  logger  enabled for   CRITICAL      !!!!INFO ONLY!!!!
piBeacon                        check                   /Library/Application Support/Perceptive Automation/Indigo 7.4/Logs/com.karlwachs.piBeacon/plugin.log  <<<<    for detailed logging
piBeacon                        Plugin short Name       piBeacon
piBeacon                        my PID                  14794
piBeacon                        set params for indigo V 7.4
Started plugin "piBeacon 7.124.424"
piBeacon                        myLogSet setting parameters -- logFileActive= indigo; logFile= /Library/Application Support/Perceptive Automation/Indigo 7.4/Logs/com.karlwachs.piBeacon/plugin.log;  debug plugin:[]   RPI#:-1
piBeacon                        testing if variable enableTimeTracking_piBeacon is == on/off/print-option to enable/end/print time tracking of all functions and methods (option:'',calls,cumtime,pcalls,time)
piBeacon                         --V 7.124.424   initializing  --
piBeacon                         ..  initialized
Aug 24, 2020 at 1:28:16 PM
piBeacon Error                  Line 10811 has error='key not found in database'
piBeacon Error                  Line 10811 has error='key not found in database'
piBeacon Error                  Line 10811 has error='key not found in database'
piBeacon Error                  Line 10811 has error='key not found in database'
piBeacon Error                  Line 10811 has error='key not found in database'
piBeacon Error                  Line 10811 has error='key not found in database'
piBeacon Error                  Line 10811 has error='key not found in database'
piBeacon Error                  Line 10811 has error='key not found in database'
piBeacon Error                  Line 10811 has error='key not found in database'
piBeacon Error                  Line 10811 has error='key not found in database'
piBeacon Error                  Line 10811 has error='key not found in database'
piBeacon Error                  Line 10811 has error='key not found in database'
`

will fix today ..
Karl

On Aug 24, 2020, at 13:31, smeee-again<EMAIL_ADDRESS>wrote:
10811

try this one:
https://github.com/kw123/pibeacon/releases/tag/v7.124.428

On Aug 24, 2020, at 13:31, smeee-again<EMAIL_ADDRESS>wrote:
Upon upgrading to v7.124.424, I'm getting the following error.
`Aug 24, 2020 at 1:27:36 PM
Enabling plugin "piBeacon 7.124.424"
Starting plugin "piBeacon 7.124.424" (pid 14794)
piBeacon initializing ...
piBeacon path To files: =================
piBeacon indigo /Library/Application Support/Perceptive Automation/
piBeacon installFolder /Library/Application Support/Perceptive Automation/Indigo 7.4/
piBeacon plugin.py /Library/Application Support/Perceptive Automation/Indigo 7.4/Plugins/piBeacon.indigoPlugin/Contents/Server Plugin/
piBeacon Plugin params /Library/Application Support/Perceptive Automation/Indigo 7.4/Preferences/Plugins/com.karlwachs.piBeacon/
piBeacon Warning !!!!INFO ONLY!!!! logger enabled for WARNING !!!!INFO ONLY!!!!
piBeacon Error !!!!INFO ONLY!!!! logger enabled for ERROR !!!!INFO ONLY!!!!
piBeacon Critical Error !!!!INFO ONLY!!!! logger enabled for CRITICAL !!!!INFO ONLY!!!!
piBeacon check /Library/Application Support/Perceptive Automation/Indigo 7.4/Logs/com.karlwachs.piBeacon/plugin.log <<<< for detailed logging
piBeacon Plugin short Name piBeacon
piBeacon my PID 14794
piBeacon set params for indigo V 7.4
Started plugin "piBeacon 7.124.424"
piBeacon myLogSet setting parameters -- logFileActive= indigo; logFile= /Library/Application Support/Perceptive Automation/Indigo 7.4/Logs/com.karlwachs.piBeacon/plugin.log; debug plugin:[] RPI#:-1
piBeacon testing if variable enableTimeTracking_piBeacon is == on/off/print-option to enable/end/print time tracking of all functions and methods (option:'',calls,cumtime,pcalls,time)
piBeacon --V 7.124.424 initializing --
piBeacon .. initialized
Aug 24, 2020 at 1:28:16 PM
piBeacon Error Line 10811 has error='key not found in database'
piBeacon Error Line 10811 has error='key not found in database'
piBeacon Error Line 10811 has error='key not found in database'
piBeacon Error Line 10811 has error='key not found in database'
piBeacon Error Line 10811 has error='key not found in database'
piBeacon Error Line 10811 has error='key not found in database'
piBeacon Error Line 10811 has error='key not found in database'
piBeacon Error Line 10811 has error='key not found in database'
piBeacon Error Line 10811 has error='key not found in database'
piBeacon Error Line 10811 has error='key not found in database'
piBeacon Error Line 10811 has error='key not found in database'
piBeacon Error Line 10811 has error='key not found in database'
`
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/kw123/pibeacon/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEH2SNHYT66PK6BAN2N5XNTSCKWYVANCNFSM4QJZIITA.

New error:
`Aug 24, 2020 at 2:08:50 PM
Indigo Cocoa client connected
Upgrading plugin piBeacon to newer version 7.124.428 (previous version moved to trash)
Loading plugin "piBeacon 7.124.428"
Starting plugin "piBeacon 7.124.428" (pid 15719)
piBeacon                        initializing	 ...
piBeacon                        path To files:          =================
piBeacon                        indigo                  /Library/Application Support/Perceptive Automation/
piBeacon                        installFolder           /Library/Application Support/Perceptive Automation/Indigo 7.4/
piBeacon                        plugin.py               /Library/Application Support/Perceptive Automation/Indigo 7.4/Plugins/piBeacon.indigoPlugin/Contents/Server Plugin/
piBeacon                        Plugin params           /Library/Application Support/Perceptive Automation/Indigo 7.4/Preferences/Plugins/com.karlwachs.piBeacon/
piBeacon Warning                !!!!INFO ONLY!!!!  logger  enabled for   WARNING       !!!!INFO ONLY!!!!
piBeacon Error                  !!!!INFO ONLY!!!!  logger  enabled for   ERROR         !!!!INFO ONLY!!!!
piBeacon Critical Error         !!!!INFO ONLY!!!!  logger  enabled for   CRITICAL      !!!!INFO ONLY!!!!
piBeacon                        check                   /Library/Application Support/Perceptive Automation/Indigo 7.4/Logs/com.karlwachs.piBeacon/plugin.log  <<<<    for detailed logging
piBeacon                        Plugin short Name       piBeacon
piBeacon                        my PID                  15719
piBeacon                        set params for indigo V 7.4
Started plugin "piBeacon 7.124.428"
piBeacon                        myLogSet setting parameters -- logFileActive= indigo; logFile= /Library/Application Support/Perceptive Automation/Indigo 7.4/Logs/com.karlwachs.piBeacon/plugin.log;  debug plugin:[]   RPI#:-1
piBeacon                        testing if variable enableTimeTracking_piBeacon is == on/off/print-option to enable/end/print time tracking of all functions and methods (option:'',calls,cumtime,pcalls,time)
piBeacon                         --V 7.124.428   initializing  --
piBeacon                         ..  initialized
Aug 24, 2020 at 2:09:21 PM
piBeacon Error                  Line 10827 has error='key not found in database'
piBeacon Error                  Line 10827 has error='key not found in database'
piBeacon Error                  Line 10827 has error='key not found in database'
piBeacon Error                  Line 10827 has error='key not found in database'
piBeacon Error                  Line 10827 has error='key not found in database'
piBeacon Error                  Line 10827 has error='key not found in database'
piBeacon Error                  Line 10827 has error='key not found in database'
piBeacon Error                  Line 10827 has error='key not found in database'
piBeacon Error                  Line 10827 has error='key not found in database'
piBeacon Error                  Line 10827 has error='key not found in database'
piBeacon Error                  Line 10827 has error='key not found in database'
piBeacon Error                  Line 10827 has error='key not found in database'
piBeacon Error                  Line 10827 has error='key not found in database'
piBeacon Error                  Line 10827 has error='key not found in database'
`

I edited the wrong plugin file… will correct

On Aug 24, 2020, at 14:13, smeee-again<EMAIL_ADDRESS>wrote:
10827

published formal release on indigo store (and GitHub) if you like to down load.

On Aug 24, 2020, at 14:13, smeee-again<EMAIL_ADDRESS>wrote:
New error:
`Aug 24, 2020 at 2:08:50 PM
Indigo Cocoa client connected
Upgrading plugin piBeacon to newer version 7.124.428 (previous version moved to trash)
Loading plugin "piBeacon 7.124.428"
Starting plugin "piBeacon 7.124.428" (pid 15719)
piBeacon initializing ...
piBeacon path To files: =================
piBeacon indigo /Library/Application Support/Perceptive Automation/
piBeacon installFolder /Library/Application Support/Perceptive Automation/Indigo 7.4/
piBeacon plugin.py /Library/Application Support/Perceptive Automation/Indigo 7.4/Plugins/piBeacon.indigoPlugin/Contents/Server Plugin/
piBeacon Plugin params /Library/Application Support/Perceptive Automation/Indigo 7.4/Preferences/Plugins/com.karlwachs.piBeacon/
piBeacon Warning !!!!INFO ONLY!!!! logger enabled for WARNING !!!!INFO ONLY!!!!
piBeacon Error !!!!INFO ONLY!!!! logger enabled for ERROR !!!!INFO ONLY!!!!
piBeacon Critical Error !!!!INFO ONLY!!!! logger enabled for CRITICAL !!!!INFO ONLY!!!!
piBeacon check /Library/Application Support/Perceptive Automation/Indigo 7.4/Logs/com.karlwachs.piBeacon/plugin.log <<<< for detailed logging
piBeacon Plugin short Name piBeacon
piBeacon my PID 15719
piBeacon set params for indigo V 7.4
Started plugin "piBeacon 7.124.428"
piBeacon myLogSet setting parameters -- logFileActive= indigo; logFile= /Library/Application Support/Perceptive Automation/Indigo 7.4/Logs/com.karlwachs.piBeacon/plugin.log; debug plugin:[] RPI#:-1
piBeacon testing if variable enableTimeTracking_piBeacon is == on/off/print-option to enable/end/print time tracking of all functions and methods (option:'',calls,cumtime,pcalls,time)
piBeacon --V 7.124.428 initializing --
piBeacon .. initialized
Aug 24, 2020 at 2:09:21 PM
piBeacon Error Line 10827 has error='key not found in database'
piBeacon Error Line 10827 has error='key not found in database'
piBeacon Error Line 10827 has error='key not found in database'
piBeacon Error Line 10827 has error='key not found in database'
piBeacon Error Line 10827 has error='key not found in database'
piBeacon Error Line 10827 has error='key not found in database'
piBeacon Error Line 10827 has error='key not found in database'
piBeacon Error Line 10827 has error='key not found in database'
piBeacon Error Line 10827 has error='key not found in database'
piBeacon Error Line 10827 has error='key not found in database'
piBeacon Error Line 10827 has error='key not found in database'
piBeacon Error Line 10827 has error='key not found in database'
piBeacon Error Line 10827 has error='key not found in database'
piBeacon Error Line 10827 has error='key not found in database'
`
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/kw123/pibeacon/issues/2#issuecomment-679313341, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEH2SNCZOGBTGYZYHXKJ543SCK3T3ANCNFSM4QJZIITA.

This issue appears to be resolved.  I installed the updated plugin and no errors for about 50 minutes; normally after a few minutes the errors would start.
Aug 24, 2020 at 8:01:56 PM    piBeacon Error                  Line 10827 has error='key not found in database'    piBeacon Error                  Line 10827 has error='key not found in database'    Stopping plugin piBeacon (pid 19664)    piBeacon                        stop requested from indigo     piBeacon                         .. quitNow:  empty    Stopped plugin piBeacon    Upgrading plugin piBeacon to newer version 7.124.430 (previous version moved to trash)    Loading plugin "piBeacon 7.124.430"    Starting plugin "piBeacon 7.124.430" (pid 19800)    piBeacon                        initializing	 ...     piBeacon                        path To files:          =================    piBeacon                        indigo                  /Library/Application Support/Perceptive Automation/    piBeacon                        installFolder           /Library/Application Support/Perceptive Automation/Indigo 7.4/    piBeacon                        plugin.py               /Library/Application Support/Perceptive Automation/Indigo 7.4/Plugins/piBeacon.indigoPlugin/Contents/Server Plugin/    piBeacon                        Plugin params           /Library/Application Support/Perceptive Automation/Indigo 7.4/Preferences/Plugins/com.karlwachs.piBeacon/    piBeacon Warning                !!!!INFO ONLY!!!!  logger  enabled for   WARNING       !!!!INFO ONLY!!!!    piBeacon Error                  !!!!INFO ONLY!!!!  logger  enabled for   ERROR         !!!!INFO ONLY!!!!    piBeacon Critical Error         !!!!INFO ONLY!!!!  logger  enabled for   CRITICAL      !!!!INFO ONLY!!!!    piBeacon                        check                   /Library/Application Support/Perceptive Automation/Indigo 7.4/Logs/com.karlwachs.piBeacon/plugin.log  <<<<    for detailed logging    piBeacon                        Plugin short Name       piBeacon    piBeacon                        my PID                  19800    piBeacon                        set params for indigo V 7.4    Started plugin "piBeacon 7.124.430"    piBeacon                        myLogSet setting parameters -- logFileActive= indigo; logFile= /Library/Application Support/Perceptive Automation/Indigo 7.4/Logs/com.karlwachs.piBeacon/plugin.log;  debug plugin:[]   RPI#:-1    piBeacon                        testing if variable enableTimeTracking_piBeacon is == on/off/print-option to enable/end/print time tracking of all functions and methods (option:'',calls,cumtime,pcalls,time)    piBeacon                         --V 7.124.430   initializing  --     piBeacon                         ..  initialized Aug 24, 2020 at 8:48:51 PM

Did you use the latest v also published on the Indigo store?
Karl

On Aug 24, 2020, at 20:52, smeee-again<EMAIL_ADDRESS>wrote:

Closed #2.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

I used the latest in the Indigo Domo plugin store; v7.124.430.


Can I build Macvim with RVM Ruby instead of System Ruby?

Here comes with my system versions:
My system is  MacOS 10.14.1
Homebrew version is 1.8.2-96-g4021aa8
RVM version is 1.29.4
RVM ruby is 2.5.3
System Ruby is 2.3.7
I use the formula here https://github.com/macvim-dev/homebrew-macvim to build Macvim.
I want to build macvim with my RVM ruby, but always get system ruby installed.
:ruby print RUBY_VERSION
I always get 2.3.7.
Does there any way can let me build macvim with RVM ruby? Thanks!

Macvim from GitHub is compiled with +ruby/dyn configure option, thus you can set rubydll=... to use Ruby version you need.

I saw vim patch 8.0.0163 http://download.openpkg.org/components/cache/vim/8.0.0163 fix it, but it's in compile time, not in runtime. So I still need a way to build macvim against with my RVM ruby.

Patch 8.0.0163 is already in MacVim. It seems, you need to open an issue with ViM itself as it looks like it needs to be fixed there.

I think the problem is Macvim's build formula, maybe need  a way to specify the ruby version.

Does it well vim (not MacVim) from homebrew to blame MacVim?

I did not blame MacVim, I did say Macvim's build formula, maybe need a way to specify the ruby version.
I try to add the following code to the brew formula, it can compiled against with rvm ruby. Currently, there is no way to get the rvm ruby version information from environment. It is brew formula's restrictions.
    ENV.append 'vi_cv_path_ruby', "/Users/mark/.rvm/rubies/ruby-2.5.3/bin/ruby"

But, with wrong dll path.
:set rubydll, it shows rubydll=libruby.2.5.dylib
After set the dll path again,
set rubydll=/Users/mark/.rvm/rubies/ruby-2.5.3/lib/libruby.2.5.dylib
The command :ruby print RUBY_VERSION works, it shows 2.5.3.

I compare formula from macvim-dev/macvim-homebrew and this one and see that the first is quite outdated. Could you try formula from the homebrew-core repo?

No luck, the homebrew-core one still compiled against with system ruby 2.3.7, instead of rvm ruby 2.5.3.

Okay. I just come out my personal formula for this purpose.
https://github.com/markwu/homebrew-personal/blob/master/Formula/macvim.rb
You can use the following command to install RVM version.
brew tap markwu/personal
brew install --HEAD --with-rvm-ruby=$MY_RUBY_HOME markwu/personal/macvim

It will add rubydll to default vimrc to make rvm ruby works.
The drawback of this method is no way to reinstall macvim, you have to brew uninstall/brew install again.

You may want to file an issue with homebrew/homebrew-core to see if they could add this. Your argument doesn't have to be --with-rvm-ruby though right? It could just be any Ruby binaries, not necessarily from RVM.

It is for RVM only, because I can guess ruby dll's location from ruby command.
My formula fork from https://github.com/macvim-dev/homebrew-macvim made by macvim-dev team, I suppose this formula is more accurate than homebrew one.

I suppose most people will install MacVim with formula from homebrew core, rather than from macvim-dev.

I do think most people use the Homebrew-core one which is quite actively maintained by the Homebrew team but it leaves a very good question why we maintain a mostly inactive MacVim Homebrew Tap.
The custom Homebrew Tap was before my time. Wonder if @splhack has input to why we added that in addition to the Homebrew Core formula?

Ok, I think I found the problem, homebrew use the superenv environment to compile all Formulas, it cause homebrew lose all environment  information include your custom ruby path and a lot of stuffs ... :(
The only way to add it back is to pass these information as option arguments, or put them in your system environment with HOMEBREW_* prefix, or get them from pkg-config if exists. they will keep inside  building process.
So, I come out a new --with-custom-ruby for this purpose, it combine homebrew-core/macvim and also fix a homebrew python3 dynamic dll link problem come with MacVim default vimrc.
https://github.com/markwu/homebrew-personal/blob/master/Formula/macvim.rb

does modification of /etc/paths helps you? This file doesn't accept any environment variables during path building, but it's quite helpful for me.

@eirnym Thanks, I never know this. I'll try it.

@markwu Does suggested solutions works for you?
You have been suggested to set:

correct paths
setting parameters within configure script
setting rubydll in your vimrc

All these options are not MacVim-specific and can be done with the original version of vim.

None of them working for me, I have to pass the correct RVM ruby path through HOMEBREW_* system variables.

Did it solve your issue?

Homebrew has it's own MacVim formula anyway and MacVim authors have no ability to fix it. If you blame the formula itself, you should write a ticket there.

OMG, again? I did not blame anything, I just ask how to resolve the issue. Anyway, I resolve by my personal formula.

I am happy with my modified formula. The issue solved.

Glad to see it resolved for you @markwu. There were a lot of back-and-forth here, so I just want to make sure I understand: You forked from https://github.com/macvim-dev/homebrew-macvim and did the modifications? Have you tried the latest official homebrew-core formula?
If homebrew-core's version is not working due to its usage of superenv and whatnot, have you filed an issue with them? If there are other users like you it may be a good idea to see if there's a common way to fix it for everyone.
The Macvim's own homebrew formula is quite outdated and since homebrew-core maintains an official MacVim formula I am not too inclined in keeping it up to date (more options to get MacVim = more complexities and more chances of things not working). I'll leave a note on the README there to make it clear it's no longer actively maintained.


Test failure in MySQL 5.7

I'm getting the following error with MySQL 5.7.11 on my local build. It doesn't happen in Travis.
My assumption is that there is a config setting that makes MySQL a bit more strict (only_full_group_by) that is on by default from MySQL 5.7.5 onwards. We probably want to address this. I can't imagine it's too much of an issue, as PostgreSQL has had this kind of strictness for a long time.
1) SQLSelectTest::testCount
SilverStripe\Model\Connect\DatabaseException: Couldn't run query:

SELECT DISTINCT "SQLSelectTest_DO"."ClassName", "SQLSelectTest_DO"."LastEdited", "SQLSelectTest_DO"."Created", "SQLSelectTest_DO"."Name", "SQLSelectTest_DO"."Meta", "SQLSelectTest_DO"."Common", "SQLSelectTest_DO"."Date", "SQLSelectTest_DO"."ID",
            CASE WHEN "SQLSelectTest_DO"."ClassName" IS NOT NULL THEN "SQLSelectTest_DO"."ClassName"
            ELSE 'SQLSelectTest_DO' END AS "RecordClassName"

FROM "SQLSelectTest_DO"

GROUP BY Common
 HAVING ("Date" > 2012-02-01)

Expression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'ss_tmpdb5709632.SQLSelectTest_DO.ClassName' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by

/Users/sminnee/Sites/ss4/framework/model/connect/DBConnector.php:63
/Users/sminnee/Sites/ss4/framework/model/connect/MySQLiConnector.php:141
/Users/sminnee/Sites/ss4/framework/model/connect/MySQLiConnector.php:229
/Users/sminnee/Sites/ss4/framework/model/connect/Database.php:150
/Users/sminnee/Sites/ss4/framework/model/connect/Database.php:201
/Users/sminnee/Sites/ss4/framework/model/connect/Database.php:153
/Users/sminnee/Sites/ss4/framework/model/DB.php:329
/Users/sminnee/Sites/ss4/framework/model/queries/SQLExpression.php:123
/Users/sminnee/Sites/ss4/framework/model/queries/SQLSelect.php:581
/Users/sminnee/Sites/ss4/framework/tests/model/SQLSelectTest.php:44
/Users/sminnee/Sites/ss4/vendor/phpunit/phpunit/phpunit:47

+1 this is a bug; We should not be generating invalid SQL, even if prior mysql versions were forgiving of such syntax.
The code that converts grouping queries -> counts could be quite a challenge. Could we accept a less performant (but more robust) solution for certain queries that can't be automatically converted, such as querying the full result, but then discarding after counting rows?

It looks as though this is what is already being attempted; (3.x head)
// we can't clear the select if we're relying on its output by a HAVING clause
if(!empty($this->having)) {
	$records = $this->execute();
	return $records->numRecords();
}
// Choose a default column
elseif($column == null) {
	if($this->groupby) {
		$column = 'DISTINCT ' . implode(", ", $this->groupby);
	} else {
		$column = '*';
	}
}

Hm, I take that back... the problem seems to be with the initial query constructions.
$qry = SQLQueryTest_DO::get()->dataQuery()->getFinalisedQuery();
$qry->setGroupBy('"Common"');

This seems like a mis-use, to simply apply a grouping to a dataquery, without specifying the aggregation method? The problem is nothing to do with the count at all, as the $qry object is set to an inconsistent state as soon as the above lines are invoked.
We could do one of;

Update the test to set the SELECT component at the same time as the GROUP BY to aggregate columns. We can document this behaviour as a necessary part of constructing SQL queries for execution (onus is on developer not the framework).
Provide some kind of default aggregate to apply to columns when running ->groupBy (or some other manipulation of SELECT fragment). Default aggregation could be applied just before query, or as soon as ->setGroupBy() is called.
Alternatively, instead of aggregating automatically, throw an error where aggregration would be necessary (but isn't done). Essentially causing a different error at the same time, but with more specific information (.e.g. you grouped by column X but didn't aggregate columns Y and Z).

From what I can see, setGroupBy() isn't used by the core ORM, so this is only for custom query creation.
Perhaps go with the 3rd case, but throw a warning? Since it works on some version of MySQL, that'll tell people that their code is dumb without breaking things that currently work?

I've fixed the poor sql usage at https://github.com/silverstripe/silverstripe-framework/pull/6608. Not sure how to best manage future warnings, yet.

Future warnings?

Warnings in case of improper usage. In this case, we just avoid improper usage, but we aren't protecting other users against it.

This is really down to MySQL changing the meaning of sql_mode ANSI in version 5.7.5. A possible fix that will protect users and modules from creating queries that run under 5.6 but crash under 5.7 would be for frame work to explicitly set modes  REAL_AS_FLOAT, PIPES_AS_CONCAT, ANSI_QUOTES, & IGNORE_SPACE (the previous definition of "ANSI"), rather than use the ANSI alias, which is not stable.

Related:#6632


RadixTree - Concurrency Is Broken

The most recent performance changes to the RadixTree no longer exhibit safety for multi-reader, single writer concurrency. I have been investigating the issue, and I believe concurrency support may have always been broken and hidden by the usage patterns and timing characteristics of the unit tests in question.

This has been fixed. It was out of sync parent and 'IndexInParent' references without cloning all nodes involved that was causing an issue. I switched back to using a pooled stack instead of relying on navigation references and it solved the issue.


Add Time Is Money™

Is it OK to suggest my own project? Time Is Money™ is a game I made with @michalbe for a game jam. It's an incremental game about the passage of time. The art and the UI are inspired by Windows 95 and the early 3D games like Hover!. Please merge only if you like it! :)

Hi stasm, this game is very neat and addicting 😁 I actually played it when I came across a couple of months ago on itch!
Although I think it belongs to a different list.
Please keep up the good work pal and good luck with the development!

That's fair, thanks for playing and for making the list! All the best!


ENH: override isf for Burr distribution

Reference issue

Towards: gh-17832
What does this implement/fix?

Overrides and adds the inverse survival function of the Burr distribution in order to improve its precision
Adds some tests.

Additional information

I still have to add the reference distribution if required.
CC: @mdhaber

from scipy.stats import burr
from scipy.special import expm1, xlog1py
import numpy as np
import matplotlib.pyplot as plt
from mpmath import mp
mp.dps = 200

def mpmath_isf(q, c, d):
    q = mp.mpf(q)
    c = mp.mpf(c)
    d = mp.mpf(d)

    q = mp.one - q
    value = (q**(-mp.one/d) - 1)**(-mp.one/c)
    return float(value)

def _isf(q, c, d):
    _p = xlog1py(-1.0/d, -q)
    return expm1(_p)**(-1.0/c)

def plot_isf():
    c, d = 5.0, 3.0
    q = np.logspace(-40, -1, 200)
    mp_values = np.array([mpmath_isf(_q, c, d) for _q in q], np.float64)
    plt.semilogx(q, burr.isf(q, c, d), label="main", ls="dashed")
    plt.semilogx(q, _isf(q, c, d), label="pr", ls="dashdot")
    plt.semilogx(q, mp_values, label="mpmath", ls="dotted")
    plt.legend()
    plt.title("Burr inverse survival function")
    plt.show()

All three lines on the plot appear to overlap perfectly. Can you adjust the plot to show the improvement? For instance:

you can use the y axis to plot the relative error rather than the value of the result
you can use log scale on the y axis to highlight the magnitude of the error

All three lines on the plot appear to overlap perfectly. Can you adjust the plot to show the improvement? For instance:

you can use the y axis to plot the relative error rather than the value of the result
you can use log scale on the y axis to highlight the magnitude of the error

Actually the one for main stops way before. The color for main is just not clear.

I see. Makes sense.


erlangR23: 23.1 -> 23.1.1

Motivation for this change
Upstream release: https://github.com/erlang/otp/releases/tag/OTP-23.1.1
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 102135 1

1 package built:

erlangR23

Closure size difference:
/nix/store/60cl373d5d5f741cvs7m2akj5hv1sdmq-erlang-23.1           616544448 # before
/nix/store/x2nhr912cn7rih1hav9dl260hdgqv190-erlang-23.1.1         616579872 # after

Result of nixpkgs-review pr 102127 run on x86_64-darwin 1

1 package failed to build:

plover.dev

Running configuration tests...
Checking for valid makespec...
+ cd /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/config.tests/verifyspec && /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/bin/qmake "CONFIG -= qt debug_and_release app_bundle lib_bundle" "CONFIG += shared warn_off console single_arch" 'QMAKE_LIBDIR += /nix/store/x2r6z8m6h8aaq4g0sgkw8amfscdk1f6q-icu4c-67.1/lib /nix/store/bkbw8vp4g3fnkcsrw9ayfazk096rjd7n-zlib-1.2.11/lib /nix/store/4lcgzmjmipg8s4cg5qflhs5afnsaah19-libjpeg-turbo-2.0.5/lib /nix/store/xm0jvjxb2ga3vd5icpz0ldx57pjpzinp-harfbuzz-2.7.1/lib /nix/store/4115fabrf3hcccwa760057pqxvssmh13-openssl-1.1.1g/lib' 'INCLUDEPATH += /nix/store/dmy9q4cm6c9nzdar7nqgn06gvkgxsid1-icu4c-67.1-dev/include /nix/store/7dw65jc4r4vkaqizzcx1njyryi8vw7vm-zlib-1.2.11-dev/include /nix/store/fhmc6vlgh1vcjilhs4z5fjlfr6qbbqmq-libjpeg-turbo-2.0.5-dev/include /nix/store/yr68z4q8i7bzk6z93q58vvzqwyvyy33i-harfbuzz-2.7.1-dev/include /nix/store/bid8wmf6fb5kg702ywnl7zjzh5158dnr-openssl-1.1.1g-dev/include' /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/config.tests/verifyspec
> /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/mkspecs/features/mac/toolchain.prf:3: Cannot find feature sdk
> Info: creating stash file /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/config.tests/.qmake.stash
> /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/mkspecs/features/mac/default_post.prf:5: 'xcodeSDKInfo' is not a recognized replace function.
> Project WARNING: Qt requires at least version 10.14 of the platform SDK, you're building against version . Please upgrade.
+ cd /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/config.tests/verifyspec && MAKEFLAGS= /nix/store/c3v8mz19las3k4afgqfjj9h054yv9sbz-gnumake-4.3/bin/make
> Makefile:69: /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/mkspecs/features/mac/sdk.mk: No such file or directory
> make: *** No rule to make target '/private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/mkspecs/features/mac/sdk.mk'.  Stop.
Note: Option 'verbose' with value 'true' was specified twice

Note: -docdir is not a subdirectory of -prefix.
Note: -plugindir is not a subdirectory of -prefix.
Note: -qmldir is not a subdirectory of -prefix.

ERROR: Cannot compile a minimal program. The toolchain or QMakeSpec is broken.
builder for '/nix/store/4v66czqj5sv19i335rpnykkj96ww3zwa-qtbase-5.14.2.drv' failed with exit code 3
cannot build derivation '/nix/store/w7apblbplwv1qf393q9ahljv9l3wy01h-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/v2a97qadijl3qlqb4rkg2m8y0vljr6m3-python3.6-plover-4.0.0.dev8.drv': 1 dependencies couldn't be built
error: build of '/nix/store/v2a97qadijl3qlqb4rkg2m8y0vljr6m3-python3.6-plover-4.0.0.dev8.drv' failed

Result of nixpkgs-review pr 102127 run on x86_64-darwin 1

Should this comment be in another PR? This is not #102127.

Result of nixpkgs-review pr 102127 run on x86_64-darwin 1

Should this comment be in another PR? This is not #102127.

You are totally right. Sorry about that. I deleted the comment and will rerun nixpkgs-review.

Result of nixpkgs-review pr 102135 run on x86_64-darwin 1

1 package built:

erlangR23

/marvin opt-in
/status needs_reviewer

Obsolete, OTP 23.1.2 was released: #103111


Add non-zero exit for NoResults #19

This helps to facilitate piping commands together, or otherwise using this tool in combinations with others simply.

Thanks. Closing #19.


Deal with missing folders and pre-existing files better

Please:  Create a folder if the folder doesn't exist.  Particularly useful for creating files names with folder paths included e.g. myFolder/MyFileNote

LIkewise, if a file already exists, could there be an option to append instead of create. This would be really useful for me.
Likewise, it would be nice if there were an option for the template-output that would be the current folder. This way the file could be placed in the same folder as the call...CurrentPath includes the filename, which leads to problems.


Question on EIP-2981

First of all thanks for your efforts on the Mimetic Metadata - just read the articles and even though I still have to dig through the repo to see how it works out I was wondering how in this approach EIP-2981 (Onchain Royalty) would be implemented.
If we are building an evolutive Art piece for example and want to be able to sell the "Childs" independently I'll not clear if / how EIP-2981 could be implemented using Mimetic Metadata at the same time. Maybe I'm missing something...

You could for sure maintain the use of 2981 -- It would be collection wide though. if you want multiple 'collection' operations inside the same contract for minimal usage I would recommend the use of a Minimal Proxy factory.
I do believe there's a way to do token royalties (someone has done it in the past I think?) but I can't recall of the top of my head.