Formular not working in Fieldcatalog

Hello,
i have the same problem like in Issue 723. I have Office 365 and the formular don´t work.
I always get the error, when opening Excel.

I also tried this: SAP Community but this doesn´t work either.
 LO_WORKSHEET = LO_EXCEL->GET_ACTIVE_WORKSHEET( ).
 LO_WORKSHEET->SET_TITLE( IP_TITLE = 'KUG-Planung' ).
 LO_WORKSHEET->FREEZE_PANES( IP_NUM_COLUMNS = 3 IP_NUM_ROWS = 1 ).

 LS_TABLE_SETTINGS-TABLE_STYLE       = ZCL_EXCEL_TABLE=>BUILTINSTYLE_MEDIUM2.
 LS_TABLE_SETTINGS-SHOW_ROW_STRIPES  = ABAP_TRUE.
 LS_TABLE_SETTINGS-NOFILTERS         = ABAP_TRUE.
*LS_TABLE_SETTINGS-TABLE_NAME        = 'KUG'.

  LT_FIELD_CATALOG = ZCL_EXCEL_COMMON=>GET_FIELDCATALOG( IP_TABLE = GT_KUG_30 ).
        LOOP AT LT_FIELD_CATALOG ASSIGNING FIELD-SYMBOL(<ls>).
          IF <LS>-FIELDNAME = 'KUG_DAYS'.
             <ls>-SCRTEXT_M = 'KUG'.
             <ls>-SCRTEXT_S = 'KUG'.
             <ls>-scrtext_l = 'Kurzarbeits-Tage'.
             <LS>-COLUMN_FORMULA = 'COUNTIF(P2:AS2;"K")'."'ZÄHLEWENN(P2:AS2;"K")'.
          ENDIF.
        ENDLOOP.

        LO_WORKSHEET->BIND_TABLE( IP_TABLE          = GT_KUG_30
*                                  IS_TABLE_SETTINGS = LS_TABLE_SETTINGS
                                  IT_FIELD_CATALOG  = LT_FIELD_CATALOG ).

If I put the fomurlar like normal it is working:

Formular: =ZÄHLENWENN(P2:AS2;"K")
Testreport: ZDEMO_EXCEL47 also don´t work for me.

Sorry, I thought that the hyperlinks worked and the coding...

If I put the fomurlar like normal it is working:

Formular: =ZÄHLENWENN(P2:AS2;"K")

Thank you for posting. It's not the same request as the feature request 723, in your case it's an issue, 723 was a feature request.
In your case, I think the issue is due to the use of the language-specific function names (like German ZÄHLEWENN), you should only use the language-agnostic function names (which are the same as the English names).
Either you use the Microsoft Excel functions translator (which I never tested), or you enter manually the formula ZÄHLEWENN, save and look directly into the .xlsx file (it's like a ZIP file).

Thank you for posting. It's not the same request as the feature request 723, in your case it's an issue, 723 was a feature request.
In your case, I think the issue is due to the use of the language-specific function names (like German ZÄHLEWENN), you should only use the language-agnostic function names (which are the same as the English names).
Either you use the Microsoft Excel functions translator (which I never tested), or you enter manually the formula ZÄHLEWENN, save and look directly into the .xlsx file (it's like a ZIP file).

Hey sandraros,
the Problem is that I already tried the "language-agnostic function names". It doesn´t work either. The same as the testreport "ZDEMO_EXCEL47" which doesn´t work either, like the screenshot.
I think the Problem is, that the table can´t be recognized.

And sorry the referencing Issue would be Issue 905.

The issue 905 is about the reader but your question is about creating a formula with ZÄHLEWENN. Could you fix your question and show how I can reproduce without effort please?

Alright, so I try to build an Excel-File with the formula "ZÄHLEWENN" or in English "COUNTIF", but after downloading the file it shows the errror like above.
If I start the Report "ZDEMO_EXCEL47" I got the following problem for "Direct display":

If I download the file from the Report it also gives the same error. For example the file attached.
47_ColumnFormulas.xlsx

If I understand well, your only issue is in fact #905. If you have some ABAP expertise, would you mind developing a solution and proposing a Pull Request? For now, I would propose to close this current issue as it is a duplicate of #905.

Got it concerning zdemo_excel47. It's due to the login in German. It works in English.
In column E, the formula is =[@Airfare]+100

If you connect in German, the column name is different:

I will open an issue in the demos repository.

Now, back to your original issue, I don't think you really want to use the Excel feature of Column Formulas.
Your basic question is to use the formula =COUNTIF(P2:AS2,"K"). Pay attention to the fact that the formulas are internally stored with a comma, not a semi-colon.
I tested it, it works well.

Got it concerning zdemo_excel47. It's due to the login in German. It works in English.
In column E, the formula is =[@Airfare]+100
If you connect in German, the column name is different:
I will open an issue in the demos repository.

Thank you very much.

Now, back to your original issue, I don't think you really want to use the Excel feature of Column Formulas.
Your basic question is to use the formula =COUNTIF(P2:AS2,"K"). Pay attention to the fact that the formulas are internally stored with a comma, not a semi-colon.
I tested it, it works well.

That is really the right solution. I didn´t tried it because I copied the Formular from the Excel Translator and it didn´t work.
Now it is working with the comma.
Thank you very much!


Docker healthcheck script

Hi,
I reviewed the PR quickly as requested, and for my use case (remote harvester only), it should be just fine to query the harvester process with get_plot_directories to check the process health, as moreover it's not a heavy load request, even in the case of very large farms.
And I confirm the wallet-only option is deprecated with 1.3 and the embedded light wallet. wallet just starts the light wallet and syncs it with network peers (as the beta light wallet used to).

Hi, I reviewed the PR quickly as requested, and for my use case (remote harvester only), it should be just fine to query the harvester process with get_plot_directories to check the process health, as moreover it's not a heavy load request, even in the case of very large farms. And I confirm the wallet-only option is deprecated with 1.3 and the embedded light wallet. wallet just starts the light wallet and syncs it with network peers (as the beta light wallet used to).

Awesome. We're also looking into getting a health check endpoint added to the RPCs, so the endpoints in use might be even better in the future, we just tried to pick existing endpoints that should be pretty light calls for the time being.


Add appropriate ids to sections of extension

Subject of the issue
If you see, currently we have used section tag in our extensions. However do not have any ids to differentiate them. It would be good if we can add ids to each section. For this simply add an id attribute to the section based on the header.

@developer-diganta i would like to work on this

Sure. Go ahead!


only use the internalIP to speak to kubelets

This allows the NO_PROXY setting to only list internal node CIDRs which reduces churn as nodes are added and removed.
I'm not completely sure of all the downstream impacts from this choice.

i don't see a complication as long as the kubelet serving cert is valid for that IP (e2e would have failed if it was not)

@mfojtik @sttts PTAL when you have a moment. This PR can greatly simplify how we manage no_proxy across the the supported install types.

/lgtm


Added connection in GCSBatchSink and GCSMultiFileBatchSink

PLUGIN-968

Please also make sure the changes work for preview, and actual pipeline run

These changes LGTM, we will also need to add these sinks to the connector's spec method to let UI know which plugins the spec is corresponding to, please see https://github.com/data-integrations/google-cloud/blob/develop/src/main/java/io/cdap/plugin/gcp/gcs/connector/GCSConnector.java#L158
Since the UI need some changes on getting back to studio, you can test it directly using REST endpoint: namespaces/system/apps/pipeline/services/studio/methods/v1/contexts/default/connections//specification with request body like
{
  "path": "<path-to-file>",
  "properties": {}
}

to ensure these sinks are included in the response

Done.


use-cases: revise so they're more high level "landing pages"

Use cases should have a different focus, so they are more high level and serve as landing pages – single web page that appears in response to clicking on a search engine optimized search result – leaving most details to the user guide. Some relevant quotes from https://github.com/iterative/dvc.org/pull/784#issuecomment-558403171:

This section should answer the question of an infrastructure, DevOps, MLOps folks on how DVC can help them. How can it be used, in what high level scenarios. (And it's even okay if they overlap in this case.)

To reiterate on the Use Cases vs User Guide:
Users Guide is like a car owner's manual - a lot of details, how tos, etc.
Use Cases would be like explaining how that car can be used (potentially referring a lot to the owner's manual to cover the technical details) - driving from home to work, renting, taxi, etc

Note: perhaps we could split this issue into 3. Not 4 because Data Registry is already written in this direction in #818.

Ideas:

[ ] IN PROGRESS #654 extract details from use cases and possibly other redundant docs (e.g. some tutorials) into blog posts user guide? - #2482
[x] #1722 write use cases correctly and extract how-to/tutorials into separate pages
[ ] IN PROGRESS? #862 new case: DVC in Production (probably touch MLOps topics) - #2404
[x] #857 Special content previews for SEO
[x] #986 small shared dev server case update
[ ] #194 About ML on a remote machine
[ ] #2431 About specific ways to deploy ML models
[ ] #2270 About Experiment Management
[ ] QUESTIONED #682 new case about data partitioning and compression ?Use cases should have a different focus, so they are more high level and serve as landing pages – single web page that appears in response to clicking on a search engine optimized search result – leaving most details to the user guide. Some relevant quotes from https://github.com/iterative/dvc.org/pull/784#issuecomment-558403171:

Priority @shcheklein? 🙂

I think p2 for now. Too many things in play already.

Summary on MLOps-related use case ideas:

Training on a remote machine #194 was the first idea and would narrowly focus on remote SSH executors. We can prob consider it part 3.0 experiments now, I think? (I can't find the related issue or discussion but I know there's one).
DVC in Production #862 sounds broad but it intends to define and doc best practices around "synchronizing" DVC pipelines between experimental local dev and changing prod envs (I think). Cc @dmpetrov
CI/CD for ML (PR) #2404 is a bit broad so far but in the process of being narrowed down. Not clear what it will cover exactly but it'll likely include at least continuous integration using DVC + CML mentions. Cc @casperdcl
Deploying models for real-time inference #2431 may be a bit narrow but adds interesting edge to the model deployment topic, specifically model registries and real-time data streaming. Cc @dberenbaum
Model zoo (see https://github.com/iterative/dvc/issues/2719#issuecomment-555373498) Whether using a DVC repo to centralize ML model management is fundamentally different from general data registries (possibly our most popular UC) has been a recurrent question. I think that probably yes but not sure how exactly.

Should this be a separate story ticket (new use cases vs revising existing ones)?

OK: #2490


Deep Insert Sample returns Error

After copy and pasting the sample ODATA / WEB API request for a deep insert it works fine.
When doing deep inserts on elastic tables I get the below error. I am not sure if this is an elastic table limitation or a different error,
{"error":{"code":"0x80040265","message":"Cannot create related entities. Create has to be called individually for each entity."}}

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3a78e7ae-d181-4bf5-3257-6ab4f9fecca8
Version Independent ID: dedf3b5a-6f2d-95c2-0dc8-7ccfe7ef1e3f
Content: Web API basic operations sample (Microsoft Dataverse) - Power Apps
Content Source: powerapps-docs/developer/data-platform/webapi/web-api-basic-operations-sample.md
Service: powerapps
Sub-service: dataverse-developer
GitHub Login: @divkamath
Microsoft Alias: dikamath

Thanks for your comment, @DeanD84. This issue has been assigned to the doc author for review.

@DeanD84
Thanks for your feedback.
This sample code was written to use standard tables. Elastic tables are a preview feature at the moment.
For standard tables our documentation is here; Create related table rows in one operation
Elastic tables documentation doesn't call out this limitation. Will assign this issue to Elastic tables team.

Elastic tables for developers now says:

Elastic tables don't support deep insert as standard tables do. You will get this error: Cannot create related entities. Create has to be called individually for each entity.

Web API Create related table rows in one operation now says:

With standard tables, you can create entities related to each other by defining them as navigation properties values. This pattern is known as deep insert.

 SDK Create related entities in one operation now says:

For standard tables, when you create a new table row, you can also create related rows in the same operation. This is called deep insert.


🎉 New extension: Payu

There is an option to download open API spec
https://secure.payu.ru/docs/

Closing this issue as we are focusing more on the ticketing vertical. Feel free to reopen this when we start the work again


Made ErrorKind for std::io::Error more specific

This helps with fallbacks (don't decompress, return compressed) and allows better error recovery for programs using xz2.
I'm not 100% sure if all ErrorKinds are appropriate as I have never worked with liblzma. Let me know if some changes need to be made.
I also added more descriptive error display strings so that crashes give more insight into why they happened.

Right, LMK which error gets thrown when output buffer is too small (or whether that happens at all), that one needs to change to ErrorKind::WriteZero

Seems reasonable to me, thanks! I think this needs rustfmt from CI but otherwise seems good to go.

Thanks!


Do We Support PHP 5.6.4?

The readme would suggest otherwise. Also, I think we should only support that version, and drop everything else.

Well the buildpack uses CHH/php-build which does say it supports 5.6.4 - I'll try make it the default.

I think we're currently using PHP 5.6.2

Yeh, I know. What happens if we just change that number in the file?

Doesn't work, I had to revert the change.

The original Scalingo buildpack is going to be updated to 5.6.4 today anyway, so I'll see how it's done for next time.

Cool. :)

Using 5.6.4.


Milestone 5: Fetching data

In this milestone, I achieved the following...

I used axios with createAsyncThunk for making API calls.
I  fetched the book list from Bookstore API on the Books page load.
I refactored add book and remove book features to persist your changes in the server.
I made changes by using API.

Thanks for reviewing and approving my project, I appreciate it.


[AutoRelease] t2-mysqlflexibleservers-2024-11-05-41323(can only be merged by SDK owner)

https://github.com/Azure/sdk-release-request/issues/5675
Recording test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=7156

issue link:https://github.com/Azure/sdk-release-request/issues/5675


Fix image versions in database and other good practices

Hi,
I've made some changes to fix the problem executing all the app with new versions of postgres. Additionally, I have made some changes recommended by hadolint in the dockerfiles.

Hey, sorry, we're archiving this old sample.


#slice should implicitly permit

When I call params.slice(:one_param, :two_param), it seems to me like that it should return a permitted hash instead of it still being marked dirty.

Hi @mockdeep. This is a compatibility gem for Rails versions prior to 4. You'd probably be best submitting a PR against rails/rails with an implimentation, or suggesting it as an issue against the same.

This can be closed @fxn.


Update countrySelect.js

Fix #7
@mrmarkfrench Please help me update min.js file

The minified file is now updated to include this change.

Tks you for fast and furious :D


update from upstream?

hello
just wanted to confirm this repo is regularly updated from upstream to keep it compatible with openlens releases (see https://github.com/lensapp/lens/issues/6823)
thank you

To my knowledge, the last released version 0.1.0 is still compatible with current OpenLens releases (I still use 0.1.0 of this extension every day at work with OpenLens 6.5.2-366). As noted in https://github.com/lensapp/lens/issues/6823#issuecomment-1614687710, additional steps may be needed after installation.
From what I can tell, the issues that people are running into are caused by how OpenLens installs/loads extensions (e.g. it installs the extension into the wrong folder, etc.). I have tried updating the @k8slens/extensions dependency but it does not seem to have much impact on the resulting extension.
In any case, I can cut a new release of this extension, but I'm not sure it will actually fix any of the issues that people are running into.

I'm experiencing this problem also. I just cannot install the extension in the last version of Open Lens (I was using de Lens with Free subscription until they destroy the plan). I try to install the extension and the install never ends.


different behavior between Terraform V11 and V12 on this module

Hi,
I'm using this module for a pro mission, originally they use terraform V11 to provision resources with this module : 1 master and a read replica with another provider alias.
With Terraform v11, no errors are showing.
But when a do the same with Terraform V12, the following error occurs :
Error: Unsupported block type

  on rds.tf line 123, in module "rds_master_replica":
 123:   providers {

Blocks of type "providers" are not expected here.

To be more precise, in the vars.tf, the map values doesn't activate the rds_master_replica resource...this is why I do not understand why the error above occurs.
I thought it could the version of terraform (like similar issues), but it's terraform v0.12.20.
Thanks for any help :)

You should update your rds.tf and write providers = { in Terraform 0.12.
This problem is not related to the module, see this section in Terraform 0.12 Upgrade Guide.


pybind11: 2.2.2 -> 2.2.4

Motivation for this change
Update pybind11 to latest release.
Also enable the included test suite again, apart from mock install based test_cmake_build test, which always fails.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@yuriaisaka Any interested in taking a look at this?

@dotlambda Now that you had some exposure to pybind11, would you mind reviewing this one as well?

@FlorianFranzen Thanks a lot for enabling the tests!

@dotlambda: No problem. Thank you for the feedback. I just updated the expression with your proposed correction.
Furthermore the test failure we are currently seeing in now also documented in detail in the linked upstream issue.

@GrahamcOfBorg build pybind11


Fixed the types in  PodUpgrade struct

@BUGFIX Fixed the types in PodUpgrade struct, types changed from int to float64 since it should be a number between 0 and 1.
Bug report:
failed to get list of pods from marathon: failed to unmarshal response from Marathon: malformed pod definition json: cannot unmarshal number 0.5 into Go struct field PodUpgrade.minimumHealthCapacity of type int

much appreciated @riot-mraviv


Can't mock library

Describe your environment

React-Native version: 0.57.5
OS version: Mac OS 10.13.6 (17G65)
react-native-languages version: 3.0.1

How to repeat issue and example
After mocking
jest.mock('react-native-languages', () => ({
  RNLanguages: {
    language: 'en',
    languages: ['en'],
  },
}))

I had this error:
TypeError: Cannot set property 'locale' of undefined

      5 | I18n.locale = language

#I18n.ts
import { language } from 'react-native-languages'
import I18n from 'i18n-js'
import {ru, pl, uk, en} from './locales'

I18n.locale = language
....
export default I18n

The issue does not seems linked to react-native-language but to the i18n-jspackage.
Which version of it have you installed ? Also, do you enable the Jest automock feature ?

@zoontek
i18n-js: 3.1.0
no automock

@stereodenis Could you provides an exemple repo with a minimalist exemple?

@stereodenis please tell me how to mock this library.
In my jest setup file, i am having
jest.mock('react-native-languages', () => ({
    RNLanguages: {
      language: 'en',
      languages: ['en'],
    },
  }));

Still it throws, TypeError: _reactNativeLanguages.default.addEventListener is not a function.

No solution from above works for me, so I just used the following to bypass it like the following:
jest.mock('react-native-localize', {})

You can mock it like this:
jest.mock('react-native-localize', () => ({
  getLocales: () => [
    { countryCode: "GB", languageTag: "en-GB", languageCode: "en", isRTL: false },
    { countryCode: "US", languageTag: "en-US", languageCode: "en", isRTL: false },
    { countryCode: "FR", languageTag: "fr-FR", languageCode: "fr", isRTL: false },
  ],

  getNumberFormatSettings: () => ({
    decimalSeparator: ".",
    groupingSeparator: ",",
  }),

  getCalendar: () => "gregorian", // or "japanese", "buddhist"
  getCountry: () => "US", // the country code you want
  getCurrencies: () => ["USD", "EUR"], // can be empty array
  getTemperatureUnit: () => "celsius", // or "fahrenheit"
  getTimeZone: () => "Europe/Paris", // the timezone you want
  uses24HourClock: () => true,
  usesMetricSystem: () => true,

  addEventListener: jest.fn(),
  removeEventListener: jest.fn(),
}));

@zoontek's solution works for me. Alternatively you could place a similar mock in the mocks folder which is the setup that we use in our project. Usually you would export default the module but since this package uses an unusual module style you have to export the module without the default keyword.
	const getLocales = () => [
	  { countryCode: "NL", languageTag: "nl-NL", languageCode: "nl", isRTL: false },
	  { countryCode: "FR", languageTag: "fr-FR", languageCode: "fr", isRTL: false },
	]

	const getNumberFormatSettings = () => ({
	  decimalSeparator: ".",
	  groupingSeparator: ",",
	})

	const getCalendar = () => "gregorian" // or "japanese", "buddhist"
	const getCountry = () => "NL" // the country code you want
	const getCurrencies = () => ["EUR"] // can be empty array
	const getTemperatureUnit = () => "celsius" // or "fahrenheit"
	const getTimeZone = () => "Europe/Amsterdam" // the timezone you want
	const uses24HourClock = () => true
	const usesMetricSystem = () => true

	const addEventListener = jest.fn()
	const removeEventListener = jest.fn()

    export {getLocales, getNumberFormatSettings, getCalendar, getCountry, getCurrencies, getTemperatureUnit, getTimeZone, uses24HourClock, usesMetricSystem, addEventListener, removeEventListener}

I successfully mocked the project and have working tests using the file from the comment above (thank you @tijs !)  - Every version I am using is current as of today (RN 0.59.3, latest release of localize etc etc.)
So this can probably be closed unless a documentation update is desired, or the project wants to provide a current/valid mock and make keeping it up to date a requirement for PRs...

This is what I'm using in mocks/react-native-localize.ts (but could probably be .js)
It is from the above but I added findBestAvailableLanguage (defaulting to Spanish because hola a todas, si?) change it for your language
I think this could probably be closed unless it should be a PR for docs
const getLocales = () => [
  { countryCode: 'US', languageTag: 'en-US', languageCode: 'en', isRTL: false },
  { countryCode: 'EC', languageTag: 'es-EC', languageCode: 'es', isRTL: false },
];

const findBestAvailableLanguage = () => ({ languageTag: 'es', isRTL: 'false' });
const getNumberFormatSettings = () => ({
  decimalSeparator: '.',
  groupingSeparator: ',',
});

const getCalendar = () => 'gregorian'; // or "japanese", "buddhist"
const getCountry = () => 'ES'; // the country code you want
const getCurrencies = () => ['USD']; // can be empty array
const getTemperatureUnit = () => 'celsius'; // or "fahrenheit"
const getTimeZone = () => 'Ecuador/Guayaquil'; // the timezone you want
const uses24HourClock = () => true;
const usesMetricSystem = () => true;

const addEventListener = jest.fn();
const removeEventListener = jest.fn();

export {
  findBestAvailableLanguage,
  getLocales,
  getNumberFormatSettings,
  getCalendar,
  getCountry,
  getCurrencies,
  getTemperatureUnit,
  getTimeZone,
  uses24HourClock,
  usesMetricSystem,
  addEventListener,
  removeEventListener,
};

@mikehardy I wrote an example in the README: https://github.com/react-native-community/react-native-localize/blob/master/README.md#how-to-test-your-code

typescript version
interface Locale {
  countryCode: string;
  languageTag: string;
  languageCode: string;
  isRTL: boolean;
}
const getLocales = (): Locale[] => [
  { countryCode: 'US', languageTag: 'en-US', languageCode: 'en', isRTL: false },
  { countryCode: 'EC', languageTag: 'es-EC', languageCode: 'es', isRTL: false },
];

const findBestAvailableLanguage = (): Partial<Locale> => ({
  languageTag: 'es',
  isRTL: false,
});

const getNumberFormatSettings = (): object => ({
  decimalSeparator: '.',
  groupingSeparator: ',',
});

const getCalendar = (): string => 'gregorian'; // or "japanese", "buddhist"
const getCountry = (): string => 'ES'; // the country code you want
const getCurrencies = (): [string] => ['USD']; // can be empty array
const getTemperatureUnit = (): string => 'celsius'; // or "fahrenheit"
const getTimeZone = (): string => 'Ecuador/Guayaquil'; // the timezone you want
const uses24HourClock = (): boolean => true;
const usesMetricSystem = (): boolean => true;

const addEventListener = jest.fn();
const removeEventListener = jest.fn();

export {
  findBestAvailableLanguage,
  getLocales,
  getNumberFormatSettings,
  getCalendar,
  getCountry,
  getCurrencies,
  getTemperatureUnit,
  getTimeZone,
  uses24HourClock,
  usesMetricSystem,
  addEventListener,
  removeEventListener,
};


Add wifimap.io as easy

Hey,
I just added a new site, wifimap.io as this was not on justdelete.me.
Written by my own experience.
Thanks for the site btw!

Thanks for your contribution!


Make mock brokers and protocol packets available for outsider

This is a very selfish PR, I am probably one of the very few people (if not the only one) who needs this, so if you think that it makes no sense for you then just close this PR immediately.
Basically I need MockBroker and Mock response types to be available outside of Sarama to reuse in our tests. I also wanted to move them to saram/mock package, but that would require making the encoder type public that would collide with the existing public Encoder type. A solution to that would be to move all request/response marshaling/unmarshaling logic to a dedicated package e.g. sarama/proto or sarama/protocol, but that seemed to be too much to ask...

Hrm, a protocol subpackage has been on our 2.0 wishlist for a while (see https://github.com/Shopify/sarama/wiki/Ideas-that-will-break-backwards-compatibility).
I'm not strictly against this PR, but I'm really more curious what case you're doing that the high-level mocks don't support? Are you actually using the low-level broker directly in your code?

Why is introducing the protocol package considering a breaking change? Yes, strictly speaking the request and response structs are public and moving them to another package breaks the interface. But they have been unusable outside of sarama because of private encode/decode methods, so nobody could use them anyway, right? I would say de facto it is a non-breaking change.
Answering you other question: we have our own implementation of consumer and offset_manager that have been living in our sarama clone. I want to stop maintaining the sarama clone and move the consumer and offset_manager implementations to where they are actually used. Just as I said. Very selfish :).

They're not unusable, they are intended to be used with the Broker object which has public methods taking each request type and returning the appropriate response type.
If the current consumer/offset-manager don't do what you need, a less selfish approach would be to contribute that functionality upstream and just start using the sarama-provided ones... in the long run this might even be more selfish since then we'd take the maintenance burden for them :)

@eapache when I was adding missing features I was stupid enough to rewrite the Consumer and OffsetManager in a slightly different way. I also slightly changed their API. Since then you fixed probably all of the issues I have had with them, but it is not easy for me to move to the original sarama Consumer and OffsetManager. As a step in this direction I wanted to move custom logic away from sarama, but for that I need to be able to test it using Sarama's mocks.

We're considering doing a breaking release, because some of the 0.9 protocol additions are not backwards compatible. As part of this we could also extract out the protocol stuff into a subpackage.

@wvanbergen do I get this right that Sarama v2 compatible with Kafka 0.9 won't be able to talk to Kafka 0.8?

It should still be able to for most/all API calls, with a potential exception of the offset manager.

Alas that would not work for us, we do use the offset manager with Kafka 0.8 so if we switch to Sarama v2 we won't be able to support both Kafka 0.8 and Kafka 0.9.

The offset manager may work as well with both versions, but we'd have to investigate some more before we can be sure. The issues: the current offset manager doesn't work with 0.9 for unknown reasons, and a bunch of error/protocol names have been changed compared to Kafka 0.8. Could be fixable.

@wvanbergen thanks for sharing, I appreciate that.

@wvanbergen check out #585. Looks like it won't be necessary to make backwards incompatible changes after all.

I'm trying to write some tests right now that need the mock broker as well.  So it isn't that selfish @horkhe
I'm trying to upgrade some code to use the latest version of sarama and part of that code uses a Client, which is an interface and can be mocked except for the fact that a few of the functions return a real *Broker.  These tests are pretty difficult to fix/upgrade without a mock broker.

Hmm, I wonder if long-term the better solution might just be to make Broker an interface rather than trying to maintain all the networking code associated with the mockbroker...

Well, people would still need to come up with some sort of mock broker implementation. And the one that comes with Sarama would satisfy many of us. So event with a Broker interface it would still make sense to make the sarama mock broker implementation public, I think.

Hey @eapache any chance of getting this to the master? If you do not think that it is worth having then let's just close this PR.

Urgh, I dislike all the types this adds to our public API, but I'm also not super-keen on doing a 2.0 just so we can package everything up properly, and I do understand the problem you're trying to solve.
I think I'm OK with this PR if the documentation for the various mock types mentions that you probably don't need them / shouldn't use them unless you're doing low-level testing? @wvanbergen do you have a strong opinion here?

@eapache thanks man! If you plan on going to GopherCon this year I will be glad to meet you guys there and treat you with some beer :)

I'll take Willem's lack of response as "no strong opinion" so: update the godoc to make it explicit these types are for low-level testing and aren't normally needed, and I'll merge this.

Sorry, I was sick the last week so I missed this.
But yeah - if this solves a problem for you I am OK with merging this.

@eapache @wvanbergen I have updated the comments.


[BUG] Clientside Crash only on Multiplayer Server when trying to launch rocket

[Please fill out the form below and delete the sections in square brackets after reading them]
Version of Advanced Rocketry

1.16.5-2.0.0-10

Have you verified this is an issue in the latest unstable build

[x] Y

Version of LibVulpes

1.16.5-1.0.2-18

Version of Minecraft

Forge 1.16.5 36.1.4

Does this occur without other mods installed

[x] Y

LibVulpes, Advanced Rocketry.

Crash report or log or visualVM (if applicable)
Crash Report
VVV
https://pastebin.com/8hytS9uG
Log
VVV
https://pastebin.com/erqHsuYm
Description of the problem

Ok so when I try to launch a rocket to a space station in singleplayer, everything works fine. When I try to do this on a server, everyone on the server gets a client side crash.
On crash it claims that there is a missing registry entry of "rocketfx". I closed the server and dug through the config. I found advancedVFX, so I turned set that to false for both client and server. When I relaunched the server I found that the rocket had launched? I managed to land on the space station and it was all there. Every other time this crash has occurred, the rocket does nothing when I relog. I am simply in my seat right where I was. I don't know what to make of that tbh, hope this helps tho.

EDIT: I tried to recreate the rocket launching after logging back in but failed. Not sure what happened the first time...

it looks like the check to see if the rocket can go to its destination doesn't work on client only.  I'll get a fix in for that.

i've fixed the issue causing the crash in the report you submitted, as for the particle thing, it's looking like somehow they're all getting unregistered on the client but only in multiplayer.  I'll follow up on that one too.


Zone id is case sensitive - Story Id: 119047255

Link: https://www.pivotaltracker.com/story/show/119047255
Labels:
Requester: Priyata Agrawal
Estimate: 0.0

Zone ids should be made case sensitive. We noticed that when we created zones with randomly generated zone ids, the zone id would get stored all lowercase. When using the X-Identity-Zone-Id header, the zone switching filter did not find the zone because of case mismatch. This should be similar to the subdomain fix which can be found here. #101469422

Link: https://www.pivotaltracker.com/n/projects/997278/stories/119047255/comments133285413
User: Priyata Agrawal

@stummidi
Comment Id: 133285413


Custom Font

Possibility to use a Custom Icon Font.

Not currently available. Not on the road map.


[MySQL] changing resource provider casing from DBForMySQL to DBforMySQL

All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] Please open PR in Draft mode if it is:

Work in progress or not intended to be merged.
Encountering multiple pipeline failures and working on fixes.

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[ ] I have read the contribution guidelines.
[ ] The pull request does not introduce breaking changes.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
[ ] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:
Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

[ ] Include updated management metadata.
[ ] Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

If the check fails at the Verify Code Generation step, please ensure:

Do not modify any code in generated folders.
Do not selectively include/remove generated files in the PR.
Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:
  `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

/azp run net - mgmt - ci

Related Swaggger PR is  https://github.com/Azure/azure-rest-api-specs/pull/15016

@m-nash Can you take time to review this?

@m-nash Can you take time to review this?

@m-nash Hello, can I get this PR reviewed? It is fairly simple PR for a typo fix

/azp run net - mgmt - ci


Korean translation and fix bugs on translation name

there is no archwaylHallway in map. it seems not your bug, it's r6's bug.

Looks good, thank you!


Fix GetCorrectCasedPath() to first check if any system file entries is returned before calling First()

PR Summary
On WSL, if you have a folder in /mnt/c/Users/steve/Blah and try: test-path /mnt/c/Users/steve/blah -pathtype container you get an error because .First() is being called on an empty string array.  Fix is to check that the returned array contains something.  Otherwise, just return the given path as some file system issue prevents correcting the casing.  This issue seems to only repro on WSL.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:

Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

I can repo on WSL1. Is the issue on WSL2?


Required Data Stream SPNs are not supported. SPNs: 12744 … Reported for CI engine.

Required Data Stream SPNs are not supported. SPNs: 12744
was observed on a CI engine. But, EVAP is SI only.
Please correct SP 12744, Evap. System Purge Pressure, to SI only.
Observed on 3.1.14.

I'm still seeing this is 3.1.19:
Required Data Stream SPNs are not supported. SPNs: 166
Required Data Stream SPNs are not supported. SPNs: 12748
Required Data Stream SPNs are not supported. SPNs: 3516, 3518, 7346
FAIL: <IP_ADDRESS>.b - N.2 One or more SPNs for data stream is not supported
Required Data Stream SPNs are not supported. SPNs: 132
Required Data Stream SPNs are not supported. SPNs: 166
Required Data Stream SPNs are not supported. SPNs: 245, 917
Required Data Stream SPNs are not supported. SPNs: 4360
Required Data Stream SPNs are not supported. SPNs: 12744
Required Data Stream SPNs are not supported. SPNs: 12750
Required Data Stream SPNs are not supported. SPNs: 12751
Required Data Stream SPNs are not supported. SPNs: 12752
Required Data Stream SPNs are not supported. SPNs: 12753
Required Data Stream SPNs are not supported. SPNs: 3516, 3518, 7346
WARN: <IP_ADDRESS>.a - SPN not supported in DM24
Required Data Stream SPNs are not supported. SPNs: 74
Required Data Stream SPNs are not supported. SPNs: 101
INFO: <IP_ADDRESS>.a - SPN not supported in DM24
More than one of the SPNs are reported as supported. SPNs: 110, 1637, 4076, 4193
INFO: <IP_ADDRESS>.b - More than 1 SPN supported

Still observed data to follow

The logic for <IP_ADDRESS>.b is separate from the rest of the A1 table.  It was broken in multiple places.


[SPARK-30339][SQL] Avoid to fail twice in function lookup

What changes were proposed in this pull request?

Currently if function lookup fails, spark will give it a second change by casting decimal type to double type. But for cases where decimal type doesn't exist, it's meaningless to lookup again and causes extra cost like unnecessary metastore access. We should throw exceptions directly in these cases.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Covered by existing tests.

Test build #115679 has started for PR 26994 at commit a471a9b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20476/
Test PASSed.

cc @dongjoon-hyun @gatorsmile

Test build #115679 has finished for PR 26994 at commit a471a9b.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115679/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20484/
Test PASSed.

Test build #115688 has started for PR 26994 at commit a471a9b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20485/
Test PASSed.

Test build #115688 has finished for PR 26994 at commit a471a9b.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115688/
Test FAILed.

retest this please

Test build #115753 has started for PR 26994 at commit a471a9b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20547/
Test PASSed.

Test build #115753 has finished for PR 26994 at commit a471a9b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115753/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20747/
Test PASSed.

Test build #115955 has started for PR 26994 at commit be6c276.

Test build #115957 has started for PR 26994 at commit 71b85e6.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20749/
Test PASSed.

Test build #115955 has finished for PR 26994 at commit be6c276.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115955/
Test PASSed.

Test build #115957 has finished for PR 26994 at commit 71b85e6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115957/
Test PASSed.

Merged to master.

Late LGTM. Thanks, @HyukjinKwon !


question about data in signer

How is data fed to the signer? This is a weird pattern.
https://github.com/decentralized-identity/did-jwt/blob/master/src/signers/ES256KSigner.ts#L31

If the data is a string, then it's converted to the byte array representation, otherwise the data is expected to be a byte array, in which case it is sent directly to the signer. The string conversion exists for convenience.
What would make it less weird? Your question is a bit vague; please help me understand.

Somehow the signer grabs the payload and puts in the variable data and returns a signature. I collected all the component code in a gist from the did-jwt library that seems to work together:
https://gist.github.com/bshambaugh/2d37d55b71910a3a4c7dfcc03e41bf33

I think I understand your confusion now.
This is a common pattern in Javascript, where a function returns another function (as opposed to returning the result of another function).
In this case, the function ES256KSigner receives a private key parameter, and returns another function that receives a data parameter and signs it using the private key.
I suppose in C this would be returning a function pointer.. My C is very rusty so don't take my word for it.
To learn more about this pattern, I guess a good starting point is to search for documentation about Javascript closures.
I'm closing this issue, since it doesn't relate strictly to this library, but to a general Javascript pattern.
Feel free to reopen if I misunderstood.

This is unrelated to this library. Apologies in advance.
rambling. ( I have been flailing about trying to think about my typescript problem and I am unsure who to ask to clear stuff up for me ....I feel that maybe I exhausted the local dev slack. ... locally I don't even think there is someone I could ask to pair-program with me at a coffee shop even for money. I've alluded to this when talking to people...and the community has known I've been working on this for months..but I haven't had much success...there is a newbie coding group I could try out tomorrow that meets every couple weeks or so..... I'll report back in a few hours....maybe I'll finally get lucky)
I put together some non-functional code
https://codesandbox.io/s/infallible-christian-y860j3?file=/index.js:387-1245
Here is the most interesting excerpt
async function getSignature(data) {  ... I suspect an async function with an eventEmitter is illegal....perhaps the same if it was replaced with a stream
   eventEmitter.emit('requestforsignature',data); // this emulates sending data over websockets to a remote device

   eventEmitter.on('requestforsignature', (chunk) => { // this emulates the remote device receiving the data and doing an operation on it
    const sig = bytesToBase64url(callToHSM(chunk));
    eventEmitter.emit('signature',sig);
   })

   eventEmitter.on('signature', (chunk) => {  // this is the response that the original sender recieves from the device...
     // console.log('signeddata:',chunk);
     return chunk; // somehow the code returns the response when it gets it   .... I suspect this line is illegal
   });

}

/// this is the functionality I need, but it is not going to work
export function P256Signer(): Signer {
    return async(data: string | Uint8Array) : Promise<string> => {
       return getSignature(data);   ... I suspect this is illegal because return chunk is illegal
    }
}

Errata. I apologize, the internet is intermittent here. If I succeed pushing these packets to the web, it should read:
 eventEmitter.once('signature', (chunk) => {  // this is the response that the original sender recieves from the device...
     // console.log('signeddata:',chunk);
     return chunk; // somehow the code returns the response when it gets it   .... I suspect this line is illegal
   });

I just found out from https://nodejs.org/api/stream.html that async/await was integrated with streams. Of course I can use once to trigger a Promise (https://www.derpturkey.com/event-emitter-to-promise/) on eventEmitter.once. I can also write stream.once on a duplex stream for incoming data.

Looking at the previous, the pseudocode I've settled on is :
async function getSignature(payload) {
      let data = '2'+'1200'+payload;
      stream.write(data);
  return new Promise((resolve,reject) => {
        stream.once('data',(resolve) => {
             return resolve;
        });
        stream.once('error',reject);
}

export function P256Signer(): Signer {    // signer like ed25519, secp256k1 signer in did-jwt
      return async(payload: string | Uint8Array): Promise<string> => {
            return await getSignature(payload);
      }
}

// so if you wanted the signature every 2 seconds....this code....but actually I want the signer to emulate this with a private key
available on the network [](https://github.com/ceramicnetwork/key-did-provider-ed25519/blob/main/src/index.ts#L46-L56)
websocketServer.on('stream',function(stream,request) {
      setInterval(function(){
          getSignature(payload); // this may not be right....
      },2000);

})

I will make a “cartoon” of animated video to illustrate the conceptualization I am trying to convey

Okay here is the cartoon.
I seem to be stuck trying to embed a websocket connection within an async function. It could be that I am almost there. I made a video:
http://www.youtube.com/watch?v=ZrS4QRsLn98&t=4m15s

fwiw, I did a weird hack as a result of making this video. It opened up my eyes so to speak. The previous video is not as relevant anymore.
https://github.com/bshambaugh/BlinkyProject/blob/remoteSigner/testJWTremoteSigner/src/P256Provider_class.ts
I'll try to find someone to pair program with on this.


Application performance

I think we have an emerging problem with application performance. For example it takes around 12 seconds on a dev machine to build the Country Projects Page (on a high-end MBP).
@kouphax @psd  I'd be interested to learn of any performance profiling tools you would use for this type of application - I don't know if the problem is the API calls, Sinatra processing of the data or in the munging of the data in the page templates, but 12s for a page isn't acceptable.

@johnadamsDFID  could you please provide a URI?

Siem, the country page I was looking at is /countries/PK/projects/. I've not got a profiling tool set up yet, but the API URL
http://dfid-oipa.zz-clients.net/api/activities?format=json&reporting_organisation=GB-1&hierarchy=1&related_activity_recipient_country=PK&fields=title,descriptions,activity_status,reporting_organisation,iati_identifier,total_child_budgets,participating_organisations,activity_dates&page_size=1000
takes about 8s in Chrome.


Events outpacing elm's handler (Losing keystrokes on input field)

Sometimes when typing too fast while some heavy background processing is going on, an input field will lose some of its keystrokes. For instance, on my machine, typing "abcd" fast in http://library.elm-lang.org/catalog/elm-lang-Elm/0.12.3/ will result in "acd" displayed in the input box.
Reference threads:

real time search swallows typed characters
Elm's input loses key strokes

Mentioning https://github.com/elm-lang/core/issues/332 so we can see all the Graphics.* issues in one place and so the compiler issues gets cleaned out and focused on compiler stuff.


Update examples of WorkBuilder that accept Types implementing JobStream trait

The example provided doesn't work with a simple string argument for WorkBuilder's new method: WorkerBuilder::new("email-worker-1") instead it works if it's WorkerBuilder::new(storage.clone()).
I feel .with_storage(storage.clone()) is defunct.
apalis version: 0.3.6

Ok closing for https://github.com/geofmureithi/apalis/tree/v0.3.6


Chromium Web Browser Support

I'm new to git/github, so hope what I'm doing is right...
This adds detection for the Chromium web browser, which only contains open-source video codecs (i.e. WebM and Theora). Unlike Chrome, it has no native support for MP4 files.
This is also related to a 3 year old (unresolved) issue, "Chrome vs Chromium video source confusion" https://github.com/johndyer/mediaelement/issues/62.
Feel free to improve the code, as I'm not much of the "programmer type".

Still not fixed in the version in latest Wordpress... any eta on when this can be removed?

I added a section to use the latest version of the plugin with Wordpress while this happens. I haven't had an answer about this issue yet


Reselect conversation when leaving a team

This prevents the currently selected team conversation from being stuck in the thread view, much in the same way that #13458 handled reselecting after a blocked conversation.
The fix is to always reselect after leaving a team, which we did not do before because the fall-through logic was not true. Instead we bailed early because the currently selected conversation (now old as the user has left the team), was valid and we skipped re-selection.

@keybase/react-hackers


Please treat tags as immutable.

It isn't the first time this has happened, and in the past it was due to CI errors. But please don't treat Git tags as transient or mutable refs. It reduces trust in the project if a version tag moves from one commit to another.

Aside: I do understand this instance was just moving one commit forward in the branch. But without manually checking the commit log it's impossible to tell this at a glance. With all this said, cutting a release that fires off a notification also wouldn't be the smartest move for a threat actor.

Yea, well, mistakes happens. And the removal of the tags instead of creating a new release usually boils down to time/cost. And I would say that this is the first time since we switched from Goreleaser (which creates and pushes the tag as the first step) to Hugoreleaser.
Also, in general, I would not trust something to be immutable when it's not. GitHub should have made tags immutable, but I guess that train has left the station.

Also, in general, I would not trust something to be immutable when it's not. GitHub should have made tags immutable

Wholeheartedly agree.

but I guess that train has left the station.

Not completely. Like most forges, there are features to enforce protection policies on a per-repository basis. For GitHub, this is the rulesets feature. I wish they were configured by default, but it is what it is.

I wish they were configured by default, but it is what it is.

Sure, but if something can be turned off it cannot be trusted in general


Feat: Revamp rma register claim

What

register claim modal
address submodal

dependent on #273 and #278

Claim reasons and return reasons are not the same:

Right now we only have these:
  const reasonOptions = [
    {
      label: "Missing Item",
      value: "missing_item",
    },
    {
      label: "Wrong Item",
      value: "wrong_item",
    },
    {
      label: "Production Failure",
      value: "production_failure",
    },
  ]

Not sure if we have a module for this but it would be really nice to have this dropdown styled as a single select - the checkbox here makes it seem like you can select multiple reasons + it stays open after you have selected a value which is a bit annoying


Issue with version strings

Currently, versions are indexed by version strings.  But each version string leads to data that itself includes a potentially different version string.  This is OK because the version string associated with each version can be see as a canonical version string (i.e., "1.0" might point to the canonical version string "1.0.0" and "1.0.0" might also point to the canonical version string "1.0.0").  This has the effect of normalizing the versions by using the embedded version string.
But, the current approach only specified major, minor and patch.  It doesn't include build or release candidate information anywhere.  So it doesn't look like there is an obvious way to handle "1.0.0-RC1" vs. "1.0.0+build58babd".

I've thought about this and here is my proposal:
Every version of every library that impact indexes will have a semantic version associated with it.  There are two problems we have to address with such an approach:

What to do when a library includes a uses annotation that isn't a semantic version (e.g., "1.0")
What to do when a repository includes a v tag that isn't a semantic version.

(note, we currently ignore the version annotation in the Modelica code and rely strictly on the tag for the version number...for better or for worse...see #7).
I propose we handle both of these cases the same way.  We normalize whatever version string they provide.  In other words, we formulate a mapping from non-semver to semver and employ it consistently.  Cases 1) and 2) above are just different sides of the same coin.  As long as the scheme is consistent, they should match up.
Previously, we would store the "string" version of the version information as well so we could match up non-standard things.  With this version, I'm proposing dropping that altogether.
The question is whether we can come up with a sufficiently smart way of mapping non-semver to semver where we don't end up with collisions or ambiguities.  So it would be good to think about, for example, how we could remap existing MSL versions into a normalized semantic version form.
Comments?

Nobody commented on this.  I'm using normalized versions now.  We'll see how that works.


Remove VARIATION SELECTOR-16 in Run arrow

Closes #4446, cc @Veetaha.

I feel there should be a space between "▶" and "Run Test", WDYT?

I like this one better... but can we use whatever vscode uses in it's debugger? Or if any of their bundled extensions uses one... we should at least be consistent.

Sure, but what has changed? I don't see any changes in the diff

@Veetaha

Bruh, text rendering is so hard...

See https://microsoft.github.io/vscode-codicons/dist/codicon.html

@Veetaha There was a (invisible) U+fe0f after the arrow, which asks for it to be rendered as an emoji. So we had U+25b6 U+fe0f U+fe0e, and the latter probably had no effect.

It does work @kjeremy

Wait... there was a PR related to this symbol and emojis and this may have been intentional. I actually thought that @Veetaha was the one who submitted it.

I had the person wrong :) #3091

@kjeremy do you mean #4446 or an older one?

Yeah, #3126 was incomplete because the emoji was already in there.

I guess we could also use "⏵ Run Test" instead of "▶ Run Test".

??

Okay, that's too thin. I think we shouldn't use the Code-specific solution.

Don't you think my PR works?

This one is better.

It looks fine also in my environment, which is gnome-terminal + neovim + coc.nvim.

(my env interpret U+25b6's width as half, but It ’s okay because they don’t overlap...)

Btw, white themed ide???

I like this one more too.
My 5 cent:
how about we use an env variable like : RA_PLAY_SYM to let user overwrite the symbol ?

An environment variable seems a little heavy handed.

I guess we can configure it from the LSP settings but something about feature creep? :-).

Yeah, I feel liks we should just have non-emoji play button. For anything more fancy I think we should just upstream context-dependent running.
bors r+


ERROR:  While executing gem ... (Gem::FilePermissionError)     You don't have write permissions for the /usr/bin directory.

Question Checklist

[ ] Updated fastlane to the latest version
[ ] I read the Contribution Guidelines
[ ] I read docs.fastlane.tools
[ ] I searched for existing GitHub issues

Question Subject

Question Description

When I Install fastlane using command 'sudo gem install fastlane -NV', It shows the following log:
ERROR:  While executing gem ... (Gem::FilePermissionError)
You don't have write permissions for the /usr/bin directory.
What should I do to continue my installation？

This is caused by using the default ruby version of the MAC OS system. We can solve the problem by installing a self-managed ruby version via 'rvm'.

I have the same problem, don't have any idea how to solve it


Simplified config

Can be merged with upcoming 6.4.1

CI will be green again as soon as the @sap/cds version allowing simplified protocols config is released


Initial refactorings

A few things in here:

Rubocop refactors.
If connection failure, returns a proper exception.

Cool!


Create google colab 'sandbox' environment for Biosimulators interaction

Addresses the following need:

A 'startup' environment that users are able share and access with a web browser that is lightweight

What does this PR do?
-Adjusts Dockerfile for wheel build dependency issue
-Adds a jupyter notebook entitled "Biosimulators_Playground" which will be formatted into a Google Colab notebook that is viewable on this repo's landing page
To Do
-Format for Google Colab
-Refactor for build error

During CI, an old version of utils is being used to build the tutorials repo and thus there is an error when importing the object CompilationException. I am going to attempt to assert higher upper bounds for the biosimulators-utils dependency requirement. After all, this is the tutorial and should have an up-to-date utils backend!

I propose a change to the readme as follows:

BioSimulators tutorials
This repository contains Jupyter notebooks with tutorials for the Python APIs for the simulation tools registered with BioSimulators and a Jupyter notebook server for running the notebooks. NEW: As an alternative to the Jupyter Notebooks and relative Jupyter Notebook server, we have added a Google Colab Notebook for users that are more comfortable with a shareable, annotatable "sandbox environment". Complete with the required dependencies, input data, and explicitly-defined methods that are essential to interacting with Biosimulators, this Google Colab notebook serves as "click and play" experience.
The tutorials are located in the tutorials subdirectory. The README in this directory summarizes the content of the tutorials.
Getting started
Running the tutorials online with Google Colab (web-based, minimal setup)
Open https://colab.research.google.com/drive/1aI7Z6ZBcQzOc9PJllW9N9oeTcFtXfhTd#offline=true&sandboxMode=true in your browser or click on the above Colab badge.
Running the tutorials online with Binder
The easiest way to run the tutorials is with Binder. Simply open https://tutorial.biosimulators.org/ in your browser.
Running the tutorials on your own machine
Run the following command to download the tutorials:
docker pull ghcr.io/biosimulators/tutorials

Run the following command to launch a Jupyter notebook server at http://localhost:8888 for the tutorials in this repository:
docker run -it --rm -p 8888:8888 ghcr.io/biosimulators/tutorials jupyter notebook --ip=<IP_ADDRESS> --port=8888

Alternatively, run the following command to launch a Jupyter lab server at http://localhost:8888 for the tutorials in this repository:
docker run -it --rm -p 8888:8888 ghcr.io/biosimulators/tutorials jupyter lab --ip=<IP_ADDRESS> --port=8888

License
This package is released under the MIT license.
Development team
This package was developed by the Karr Lab at the Icahn School of Medicine at Mount Sinai in New York as part of the Center for Reproducible Biomodeling Modeling with assistance from the contributors listed here.

Bilal Shaikh
Jonathan Karr

Funding
This package was developed with support from the National Institute for Bioimaging and Bioengineering (award P41EB023912).
Questions and comments
Please contact us at<EMAIL_ADDRESS>with any questions or comments.


NuGet Packages out-of-date

Upon opening the solution, Visual Studio displayed a dialog saying: "This solution contains packages with vulnerabilities."

Hi @johanneskopf,
This issue is now resolved, I will close it. Thank you for contributing to Clang Power Tools!
Kind regards,
Marina


Please publish for Scala 2.13.14

...which is now on Maven Central, as per https://contributors.scala-lang.org/t/scala-2-13-14-release-planning/6581/13

We'll have to update next week as everyone is out this week, but everything should work fine if user sets 2.13.14 to use.


Can no longer access keepCharPositions parameter in version 3.1.0

Hi there,
Thanks for your work on this great library!
I've been trying to set the keepCharPositions flag for the underlying text field. I followed the solution in this issues, but it doesn't seem to be working for @material-ui/pickers version 3.1.0.
For example, in the following code keepCharPositions does not take effect:
    <KeyboardDatePicker
      autoOk={true}
      variant="inline"
      label={"Test"}
      format={"dd/MM/yyyy"}
      inputValue={"12/12/1900"}
      value={null}
      InputAdornmentProps={{ position: "end" }}
      placeholder={"__/__/____"}
      onChange={(_date, value) => {
        console.log(value);
      }}
      InputProps={{
        inputProps: {
          keepCharPositions: true
        }
      }}
    />

Any ideas how to use keepCharPositions with the latest version?

Hey @TrySound do you know is it possible to make smth simmilar to keepCharPositions from react-text-mask with rifm?

We have mask flag in the new version for this. In the version you use it's replace: string => boolean.

Hmm, but can we update to the latest rifm without major release? We exposing only refuse api prop

Refuse is replaced with inverted accept. I'm not sure it is possible to convert this regexp. Upgrade will be a breaking change. You may add keepCharPositions option for now which will wrap replace and after upgrade mask.


Error in "Go to Definition" in WSL. ENOTDIR: not a directory

When a folder is opened using File > Open Folder, the "Go to Definition" works fine.
But when the same folder is opened using VS Code Remote WSL there is an error when trying to use "Go to Definition":
Unable to open 'visor.py': Unable to read file 'vscode-remote://wsl+ubuntu-18.04/home/client/visor.py/home/client/visor.py' (Unknown (FileSystemError): Error: ENOTDIR: not a directory, stat '/home/client/visor.py/home/client/visor.py').
The path seems duplicated in the error message.
Environment data

VS Code version: 1.42.1
ms-vscode-remote.remote-wsl 1.809.610
OS and version: Windows 10 version 1903
Python 3.8.0
Type of virtual environment used: venv

This looks like a dupe of #1687. Same error and doubling of paths. Likely due to the + in the URI (may need to rework escaping), but I'm unsure past that.


Which dataset needs to apply scale-shift alignment?

Thanks for your excellent work!
I have a problem that which dataset needs to apply scale-shift alignment during testing? I noticed that TABLE 1,2,3 (in Metric3D-v2 paper) are evaluated without scale-shift alignment with GT depth, while TABLE 4 is evaluated with scale-shift alignment. In my understanding, Metric3D resolves the metric depth estimation issue by contructing a canonical camera space, therefore the estimated depth needs no more scale-shift alignment across different datasets, as long as the correct focal length is given. Why do you conduct additional scale-shift alignment in the evaluation of TABLE 4?

Thanks for your excellent work! I have a problem that which dataset needs to apply scale-shift alignment during testing? I noticed that TABLE 1,2,3 (in Metric3D-v2 paper) are evaluated without scale-shift alignment with GT depth, while TABLE 4 is evaluated with scale-shift alignment. In my understanding, Metric3D resolves the metric depth estimation issue by contructing a canonical camera space, therefore the estimated depth needs no more scale-shift alignment across different datasets, as long as the correct focal length is given. Why do you conduct additional scale-shift alignment in the evaluation of TABLE 4?

We applied scale (actually no shift) alignment in Table 4, when comparing relative depth estimation with those predicting depth without metric scale (like MiDAS, marigold, and original DepthAnything). When compared with metric depth estimators like zoedepth, there is no need to apply scale alignment.

I still can't understand it. The paper claims that through canonical camera transformation, the output predicted depth (after detransformed) is expected to be particularly the metric depth. There is no need to apply scale-shift alignment, isn't it? But why do you apply additional scale-shift alignment in TABLE 4?
我的理解是Metric3D-v2对于任意数据，只要给定真实的pixel-represented focal length，就可以预测出metric depth，是这样吗？如果是的话，为什么在TABLE 4中还需要做scale-shift alignment呢？（尤其是仅在TABLE 4中出现的ScanNet数据集，我发现如果不做alignment，ScanNet预测的depth与GT偏差非常大）
我注意到TABLE 3和TABLE4中都有ETH3D的结果，而且TABLE 4的结果比TABLE 3中显著好，是否是因为对同一批测试数据，TABLE 3没做alignment，TABLE 4的结果做了alignment导致的？
以上疑惑想跟您请教，谢谢您！

I still can't understand it. The paper claims that through canonical camera transformation, the output predicted depth (after detransformed) is expected to be particularly the metric depth. There is no need to apply scale-shift alignment, isn't it? But why do you apply additional scale-shift alignment in TABLE 4?
我的理解是Metric3D-v2对于任意数据，只要给定真实的pixel-represented focal length，就可以预测出metric depth，是这样吗？如果是的话，为什么在TABLE 4的比较中，对metric3d的结果还需要做scale-shift alignment呢？（尤其是仅在TABLE 4中出现的ScanNet数据集，我发现如果不做alignment，ScanNet预测的depth与GT偏差非常大） 我注意到TABLE 3和TABLE4中都有ETH3D的结果，而且TABLE 4的结果比TABLE 3中显著好，是否是因为对同一批测试数据，TABLE 3没做alignment，TABLE 4的结果做了alignment导致的？ 以上疑惑想跟您请教，谢谢您！

Table4中做了 alignment，因为是relative depth评估；table3中是metric depth，因此没做align。
ScanNet上的问题，可能是训练时的数据处理后还有噪声引起的。
我们align的时候只做了 scale alignment而不是 scale-shift alignment

I still can't understand it. The paper claims that through canonical camera transformation, the output predicted depth (after detransformed) is expected to be particularly the metric depth. There is no need to apply scale-shift alignment, isn't it? But why do you apply additional scale-shift alignment in TABLE 4?
我的理解是Metric3D-v2对于任意数据，只要给定真实的pixel-represented focal length，就可以预测出metric depth，是这样吗？如果是的话，为什么在TABLE 4的比较中，对metric3d的结果还需要做scale-shift alignment呢？（尤其是仅在TABLE 4中出现的ScanNet数据集，我发现如果不做alignment，ScanNet预测的depth与GT偏差非常大） 我注意到TABLE 3和TABLE4中都有ETH3D的结果，而且TABLE 4的结果比TABLE 3中显著好，是否是因为对同一批测试数据，TABLE 3没做alignment，TABLE 4的结果做了alignment导致的？ 以上疑惑想跟您请教，谢谢您！

Table4中做了 alignment，因为是relative depth评估；table3中是metric depth，因此没做align。 ScanNet上的问题，可能是训练时的数据处理后还有噪声引起的。
我们align的时候只做了 scale alignment而不是 scale-shift alignment

这里噪声指的是把scannet加入训练集后，可能depth有些地方没有处理好，这个需要核实一下。在Scannet上法向还是正常的。


Minor code quality improvements

Checklist

[ x ] Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
[ x ] Make sure mvn install runs for the whole project and, if you touched any code in the respective service, submission and distribution service can be run with spring-boot:run

Description
Some minor improvements in terms of best practices and maintainability.

Thank you @BjoernKW,
I took the liberty to rebase your PR, fix the failing test and incorporate the open feedback.


Question: Run without Erlang?

Hi! Thanks for this library, I just wanted to try it because it looks amazing.
However, when starting out, I ran into a problem:
> gleam run -m lustre/dev start
  Compiling argv
error: Program not found

The program `escript` was not found. Is it installed?
Documentation for installing Erlang can be viewed here:
https://gleam.run/getting-started/installing/

This looks like Erlang is required to run the dev server. Is this assumption true? I have not installed Erlang yet, but I have installed NodeJS. Gleam seems to runs fine up to this point. I don't know if it's an official goal of Gleam, but it would be nice to not require Erlang when running on NodeJS. What do you think?
Would it be a goal of lustre to make the dev server run on pure NodeJS? Would it even be possible?

Update: I have installed Erlang, but now it fails because it seems I also need to install rebar3 just to run the dev-server.

Closed, as this is the wrong repo, sorry. Opened in the correct repo: https://github.com/lustre-labs/dev-tools/issues/35


Null pointer exception in Library tab with Information button

Description
When driver JDBC driver is deleted Information button is still enabled. Clicking on it produce Null pointer exception error.
DBeaver Version
Community Edition 22.2.4
Operating System
Windows 10
Database and driver

Database name and version: Db2 v<IP_ADDRESS>
Driver name and version: JDBC v4.31.10 and v4.32.28

Steps to reproduce

Start DBeaver and menu Database | Driver Manager.
DB2 | DB2 LUW and Edit button.
Libraries tab.
Select drivers and use Delete button to delete all of the drivers.
Now no drivers exists in window, but Information is still enabled. Clicking on Information button produces Null pointer exception error.

Because there is no driver on the list, Information button should be greyed out. Also if there are no entries in window Delete button should also be greyed out.
Additional context
No response

Ok, Thanks for the bug report


Content Security Policy support.

Hello, lovely PageSpeed folks.

We're in the process of pushing CSP 1.1[1] through to CR. I think it has a few
features which would be quite usefully injected via PageSpeed. For example,
hashes and nonces would allow script/style to be inlined for performance while
maintaining protections against XSS.

More generally, PageSpeed understands the resources on a page, and could fairly
easily construct a CSP to deliver along with the page to protect against
DOM-based XSS attacks.

I'd love to chat with you folks about these options. :)

-mike

[1]:
http://w3c.github.io/webappsec/specs/content-security-policy/csp-specification.d
ev.html

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 29 Jan 2014 at 6:43

Could we do combine_js with data urls instead of an inline script?  Still need eval though.

I don't think that should change how CSP applies. If it does, it's a bug in
CSP spec.
On Mon, Nov 30, 2015 at 9:24 AM, Jeff Kaufman<EMAIL_ADDRESS>wrote:

Could we do combine_js with data urls instead of an inline script? Still
need eval though.
—
Reply to this email directly or view it on GitHub
https://github.com/pagespeed/mod_pagespeed/issues/876#issuecomment-160643980
.

We need eval to:

run each script in the same DOM context as the original

CSP Level 2's nonce-src may be a potential middle ground, however as far as I know nonce-srcs can only be used to restrict unsafe-inline and there is no way to restrict unsafe-eval to only these blocks. Also of note, PageSpeed will also break Subresource Integrity unless it updates the corresponding hashes.

Pagespeed will also break Subresource Integrity unless it updates the corresponding hashes.

Resources with SRI should set Cache-Control: no-transform, right?  In which case PageSpeed will leave them alone.

nonce-srcs can only be used to restrict unsafe-inline and there is no way to restrict unsafe-eval to only these blocks

Is this something we should ask to be added to the spec?

Some design notes:
https://github.com/pagespeed/mod_pagespeed/wiki/Design-Doc:-Brainstorming-PageSpeed-Optimization-Products-and-Content-Security-Policy
To highlight, the worst case for us is when CSS is affected by policy in HTML--- that sort of thing is really hard for us since:

It prevents in-place rewriting of CSS --- and we may not know when looking at CSS, if the CSP info is in HTML only. That means we can't really have out-of-the-box support for both default-on IPRO and CSP w/o major architectural innovations.
For from-HTML use, we need to encode the plicy info into the .pagespeed. URL. This one isn't so bad, but we need to be careful that our approximation of the policy is conservative.

There is a bit of a pragmatic upside, too: the actual CSP use in the wild seems to be considerably less tricky than it's capable off; most policies seem to be host-level, sometimes directory level.
(Well, not so much of an upside since a lot of websites use unsafe-eval and the like).

the actual CSP use in the wild
Is that statistic for mod_pagespeed users? Because I disabled mod_pagespeed as it compromised the security of my CSP. I expect the uptake of this mod by users who want to use CSP properly, will be significantly lower.

It stands to reason that most mod_pagespeed w/CSP users will have the unsafe-eval option enabled, otherwise mod_pagespeed will break their code...

On Tue, Jan 31, 2017 at 8:22 AM, Tim Stamp<EMAIL_ADDRESS>wrote:

the actual CSP use in the wild
Is that statistic for mod_pagespeed users? Because I disabled
mod_pagespeed as it compromised the security of my CSP. I expect the uptake
of this mod by users who want to use CSP properly, will be significantly
lower.
It stands to reason that most mod_pagespeed w/CSP users will have the
unsafe-eval option enabled, otherwise mod_pagespeed will break their
code...

No, it's based on top sites in HTTP archive. It's possible that
(actual/potential) mod_pagespeed users actually have tighter policies,
though, since the big sites tend to be less agile.

Looks like there is also a 'strict-dynamic' option, which may or may not be useful as an alternative method.

Any update on this?
I have problem with lazy load option in pagespeed. It adds static js code with "onload=" which CSP does not allow, and I can not edit it because CSP adds it, so I can not add nonce or sha to it.
It would be good, if authors can add web server variables like:
webpagespeed-nonce
and
webpagespeed-sha
If both of them are empty add js code that is added now, if one of them is empty, append another that is not empty to js code and then add it to page source.

@AngelDeaD could you add a concrete example of how the module would rewrite its input to illustrate your goal?

This is line that I have problem with:

It's piece of source code of an web page.
This part of line:
data-pagespeed-url-hash="204305278" onload="pagespeed.CriticalImages.checkImageForCriticality(this);"
Is added staticly by pagespeed. (I mean there is no way to edit it or add something to it).
Regarding my suggestion:
If ( $webpagespeed-nonce != "" && $webpagespeed-sha == "" ) then

pagespeed static js code would be:
nonce="YYY" data-pagespeed-url-hash="204305278" onload="pagespeed.CriticalImages.checkImageForCriticality(this);"
Of course, if both of webpagespeed-nonce and webpagespeed-sha are empty. First static would be added (as it's right now).

Ping ?

hey @oschaaf,
i wanted to just check in on this issue really quick. we are noticing some major challenges with Pagespeed and CSP. in particular:

PS does not seem to honor nonces issued via the origin, and embedded in the page
PS does not seem to understand CSP2.0/3.0, and consequently embeds violating scripts

since PS is acting on behalf of the origin in a trusted manner, why can't it just inject nonces that match any present nonce value, for scripts it adds to the page?
in any case, this is enough of a challenge for us right now that it's pagespeed or CSP, which is a lame decision to have to make. if i can help with diagnosis or PRs at all, i would be happy to contribute.

PRs definitely welcome!

Same problem here. I can't put a nonce attribute on the PS script, so the script is blocked because it violates CSP header.

Then how do we resolve this? What's the best practice?

I've just disabled most of the filters on affected sites. Not much else we can do, until someone has a chance to implement proper support.

Did you check out https://www.modpagespeed.com/doc/configuration#honor-csp ?
On Tue, Mar 31, 2020 at 12:41 PM Sam Bull<EMAIL_ADDRESS>wrote:

I've just disabled most of the filters on affected sites. Not much else we
can do, until someone has a chance to implement proper support.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-pagespeed-mod/issues/876#issuecomment-606741367,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAO2IPNM2AXLAKWQHNGP2D3RKIMKDANCNFSM4BVN3RSQ
.

@jmarantz ModPagespeedHonorCsp on directive does not do anything.

@jmarantz As per the discussion above, it breaks the CSP when using nonces/hashes etc.

@Dreamsorcerer / @jmarantz unfortunately that kind of PR, at least from scratch without pointers, is outside the scope of my skillset. what i mean to say is, i'm happy to help test PRs or otherwise diagnose issues or provide help as much as i can to the relevant teams and contributors.

Seven years, folks. Just sayin'
We cannot use the add_instrumentation filter because of this. I think Pagespeed is amazing, and I'm really surprised that the project is short of contributors, especially for something like this.
I'd have thought that CSP would be a great opportunity for Pagespeed to show off its capabilities. It could be leading the way by allowing CSP's to be automatically inserted into content, not crippled by it!

I am applying a nonce to my inline javascript but that is being lost when PageSpeed rewrites the scripts. What not just rewrite the existing nonce just as it writes in the data-pagespeed- addtributes
I have a very simple implementation where I use nginx sub module to replace the string with the nginx request id which works as a nonce but pagespeed breaks
add_header Content-Security-Policy "default-src 'self'; style-src 'nonce-$request_id'; script-src 'nonce-$request_id'
this is available to the page as a constant CSP_NONCE and replaced using nginx sub module
sub_filter_once off;    sub_filter CSP_NONCE $request_id;
this specific CSP issue is not going away. We can not fully use Pagespeed right now due to it's lack of support for CSP and it would be easy to make possible if Pagespeed will respect and reuse the existing nonce="" attribute. How hard can this be?

There's lot of problems I discovered with pagespeed which made me pretty much abandon it entirely except for the webp conversion part and even that I am considering just doing it in the application layer directly. It seems this project was given to the Apache foundation to be its "grave".

the image resizing feature doesn't consider aspect ratio (the resize to rendered dimensions filter).
the css inlining doesn't work at all if you use any advanced css features (variables, keyframes), the css parser it outdated.
it doesn't do anything with csp except ignore some filters when you set honor csp on. it can't even read the current nonce from http header and apply it on inline scripts it writes. and to make things worse, the inline script it writes contains an ever changing embedded part (server generated nonce), so you can't even try to work around this by using unsafe-hashes and hashing the content of the inline script yourself.

About the only useful feature it has right now maybe to recompress images to be more efficient and resize images to tag specified width and length and conversion to webp. That's it in my opinion.
I tried to modify / fork it but the build system is complex, and the projects are not isolated, you are forced to compile an apache and an nginx and both modules and even chromium just to build it, and the scripts are already broken on newer distros. I gave up on trying, and just implemented some of those features in my own apps by hand.

Thank you very much for sharing these points. I am going to abandon using pagespeed module given your points are valid.
I was blindly trusting this source code
https://github.com/apache/incubator-pagespeed-ngx/archive/v<IP_ADDRESS>-RC1.zip
Given the webp support is still lacking aspect ratio, and to be honest I have had some poor quality image renders

Also we really don't need to dynamically translate files as this could be done as a scheduled job

I am curious to talk shop with you about a leading edge web application stack if you want to email me at Firegarden I will follow up.
Thank you


Ruff gives unhelpful error message for all commands when pyproject.toml is invalid

When my pyproject.toml file is invalid, every ruff command gives the same somewhat confusing error message.
$ poetry run ruff check

Invalid statement (at line 9, column 1)
$ poetry run ruff --help

Invalid statement (at line 9, column 1)
$ poetry run ruff --version

Invalid statement (at line 9, column 1)
$ poetry run ruff server --preview

Invalid statement (at line 9, column 1)

My pyproject.toml (reduced down for simplicity) looks like:
[tool.poetry]
package-mode = false

[tool.poetry.dependencies]
python = "^3.10"

[tool.poetry.group.dev.dependencies]
ruff = "^0.4.4"
<<<<<<< HEAD
hypothesis = "^6.102.4"
=======
pytest = "^8.2.1"
>>>>>>> main

[build-system]
requires = ["poetry-core"]
build-backend = "poetry.core.masonry.api"

The error message doesn't make it clear that this is caused by thepyproject.toml file. I think the message should say
Failed to parse pyproject.toml. Aborting
Invalid statement (at line 9, column 1)

or something.
Less importantly, it would be nice if some commands like --help and --version still worked even when it can't parse pyproject.toml.

In my terminal I see this:
❯ ruff check
ruff failed
  Cause: Failed to parse /Users/crmarsh/workspace/ruff/pyproject.toml
  Cause: TOML parse error at line 123, column 1
    |
123 | <<<<<<< HEAD
    | ^
invalid key

Which seems pretty good...
I think this is a Poetry error? If I run poetry run:
❯ poetry run ruff

Invalid statement (at line 123, column 1)

Ahh you're right. I think this happens for any poetry run command but not other poetry commands.
$ poetry run echo foo

Invalid statement (at line 9, column 1)

This error message should be improved in newer versions of poetry https://github.com/python-poetry/poetry-core/commit/1459c57c825cda5f9a286bffaf233b77583427b9

Thanks @mscheifer!


Allow same name for type parameter and bound

Currently, there's some inconsistency:
trait Foo {}
trait Bar<Foo: Foo> {}

does not work (because of expected trait, found type parameter 'Foo'), while
trait Foo {}

trait Bar {
    type Foo: Foo;
}

does work.

@torkleyy,
They are different because
type Foo is referred with Self::Foo this is why it is permitted.
trait Foo {}

trait Bar {
    type Foo: Foo;

    fn f(foo: &Foo) {} // Refers to the trait Foo

    fn f(foo: &Self::Foo) {} // Refers to the associated type Foo
}

@KalitaAlexey But you could still use
trait Foo {}
trait Bar<Foo: self::Foo> {}


Curious as to where stable builds are and dev builds are?

Curious as to where stable builds are and dev builds are. Are the stable builds on spigotmc or bukkitdev as I noticed that multiverse on spigot was last updated in 2016, multiverse on bukkitdev was last updated in 2017 and the multiverse in this link https://ci.onarandombox.com/job/Multiverse-Core/ was last updated in 2018

Use the latest build in jenkins.

So jenkins builds is classed as a stable build then? If not where would safer/more stable builds be dev bukkit?

A lot of plugin devs seem to be a bit iffy with the new vector system and aren't updating that's all, so I'm trying to choose which build would suit most plugins most likely a stable build

I'm not even sure what the "Vector" system is. I think we're at a very interesting point in Minecraft Plugin age. This project was started when @Rigby90 and I were in school, with gratuitous amounts of free time while not in school, that's how it was for a lot of us.
That brings the life of a lot of the "big" plugins to ~7.5 years (give or take a year or two). I know @dumptruckman  still hangs out here, I watch for emails detailing security issues or API breakage, so we're all still watching the repositories but we don't hang out in IRC every day (like I used to ha) because there are other things to learn and contemplate.

You're right, we should probably push a new build up to the upstream systems (It's just annoying that there isn't a "true" source like PyPi, PPA or NPM), but that takes us remembering. Jenkins is just so easy to push to.
What is "Vector", by the quotes and capitalization, I assume this is some new kind of API or hook? Or is it just a new deployment repository? I think it's fair to say that at this point we don't have the time to re-write Multiverse for a new API, but pushing it to a new location might be feasible.

Vector system I'm pretty sure it's just a class/class name change, not 100% sure but here's the builds for worldguard mentioning it http://builds.enginehub.org/job/worldguard/10556

So this looks like an internal API Change, and you're really just asking to update the WorldEdit API.
IIRC this (might) only be a thing for MV portals and has nothing to do with Core.
Note our dependency POMs:
Core (No WorldEdit dep)
Portals


Added possibility to add existing profile to identity.

Codecov Report
Attention: Patch coverage is 68.08511% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 22.46%. Comparing base (51e4628) to head (4b918ce).

Files
Patch %
Lines

...domain/use_cases/profile/add_profile_use_case.dart
64.28%
15 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #409      +/-   ##
===========================================
- Coverage    22.48%   22.46%   -0.02%
===========================================
  Files          315      315
  Lines         8829     8840      +11
===========================================
+ Hits          1985     1986       +1
- Misses        6844     6854      +10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Bug creating scaffolding in VS 2022

[Enter feedback here]
Whenever I try to add a scaffold to my controllers I get an error message and am unable to add the needed items
Finding the generator 'controller'...
Running the generator 'controller'...
Minimal hosting scenario!
Generating a new DbContext class 'TuitionWaiver.Data.TuitionWaiverContext'
Object reference not set to an instance of an object.
at Microsoft.VisualStudio.Web.CodeGeneration.ActionInvoker.b__6_0()
at Microsoft.Extensions.CommandLineUtils.CommandLineApplication.Execute(String[] args)
at Microsoft.VisualStudio.Web.CodeGeneration.ActionInvoker.Execute(String[] args)
at Microsoft.VisualStudio.Web.CodeGeneration.CodeGenCommand.Execute(String[] args)
I had the same issues trying to do this in the RazorPagesMovie60  tutorial.
I need this to work please
Suggestions?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1d975a83-1550-b284-d0d8-7fe2ea206ff5
Version Independent ID: 48e81b42-7c2b-afbf-71e6-d4f442a4bd1f
Content: Part 4, add a model to an ASP.NET Core MVC app
Content Source: aspnetcore/tutorials/first-mvc-app/adding-model.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@hcprobst, it sounds like either one of the packages that are required are not there, the wrong version or you might have an outdated gobal tool that you have to actually remove, before updating.
Try the following:
Verify the tool versions by running the following at the command line:
dotnet tool list -g
You should see the following result:
dotnet-aspnet-codegenerator      6.0.6        dotnet-aspnet-codegenerator
dotnet-ef                        6.0.6        dotnet-ef
Before installing the latest of the dotnet tool dotnet-ef you need ot first uninstall it:
dotnet tool uninstall dotnet-ef --global
Verify your list of installed packages and their version for your MvcMovie project, at the project directory, with the following command:
dotnet list MvcMovie.csproj package --verbosity d
It is possible you might need to start over with a new project in the tutorial since we don't know what state it is in, but try what I suggested above first.
I will close this issue.  For more troubleshooting you can try the community at stackoverflow.com.  Feel free to reopen this issue if you have more information and feel there is a change that needs to occur in the doc instead.  Thanks very much for your feedback. Always appreciated.

I updated the instruction above with version information.


Support new access modifier package swift 5.9

Modify DependencyEndpoint macro to support new access modifier package

@nhenri Thanks for the PR! Want to add another macro test to capture this change?

@stephencelis Done, my commit is amend with macro test.


[FEATURE REQUEST] Post Download Jobs / ?Move Feature?

Unless I have just missed it, and I know this really isn't in active development, but..
How about an feature that allows seedsync to run a job once complete.  Similar to how the auto-extraction works
Another feature to allow seedsync to move once completed downloading.  I've been running into an issue where Sonarr/Radarr will import before the file has actually downloaded correctly.  I don't notice until someone tries to watch, and it's garbage.  But I wonder if I have just missed the option "Rename unfinished/downloading files" which should solve the problem -- sonarr/radarr won't import a file with an extension of .lftp.

Yes, the rename option solves that problem.