Add IF NOT EXISTS option to node and edge table creation.

SQL databases provide the convenient clause IF NOT EXISTS when creating tables to avoid the user having to handle errors when a table with the same name already exists.
Creating a node table in Kùzu is a bit tedious in comparison. Currently the user has to perform custom exception handling (e.g., in Python, using if/else statements or try/except blocks to handle failure when the table already exists), which slows down experimentation and requires more boilerplate.
It would be great to have a feature that allows users to create tables using this syntax:
CREATE NODE TABLE IF NOT EXISTS
Person(
    person_id INT64,
    name STRING,
    age INT64,
    PRIMARY KEY (person_id)
);

CREATE REL TABLE IF NOT EXISTS
Follows(
    FROM Person TO Person
);

Per the discussion with Semih, this might be on hold till we have evidence that it's a useful feature.

slows down experimentation and requires more boilerplate

Indeed, I've come across Kuzu about 30 minutes ago and already stumbled upon this issue. I wanted to re-run the script that created the DB:
conn.execute(
    "CREATE NODE TABLE Person(name STRING, PRIMARY KEY(name))")
conn.execute(
    "CREATE REL TABLE Parent(FROM Person TO Person)"
)

...but it failed saying:
Traceback (most recent call last):
  File "./venv/lib/python3.12/site-packages/marimo/_runtime/cell_runner.py", line 238, in run
    return_value = execute_cell(cell, self.glbls)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "./venv/lib/python3.12/site-packages/marimo/_ast/cell.py", line 444, in execute_cell
    exec(cell.body, glbls)
  File "/var/folders/61/p7f15sln0gxd7lwbr58cy6f00000gn/T/marimo_8105/__marimo__cell_vblA_.py", line 1, in <module>
    conn.execute(
  File "./venv/lib/python3.12/site-packages/kuzu/connection.py", line 92, in execute
    _query_result = self._connection.execute(prepared_statement._prepared_statement, parameters)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: Binder exception: Person already exists in catalog.

Makes sense, but what can I do to get rid of this? Should I just catch the RuntimeError? What if it's a different kind of RuntimeError? I want exactly the one related to attempting to create a NODE TABLE that already exists.
How should I handle this?

Hi @ForceBru, welcome, and hope you enjoy using Kùzu!
There's a relatively simple way to handle this in Python that requires just a couple extra lines of code:
import kuzu
import shutil

db_path = './my_kuzu_db'
shutil.rmtree(db_path, ignore_errors=True)

You can basically overwrite the database directory by using shutil.rmtree() - that way the next time you run the script, it will recreate the node/rel tables.
Note that this isn't recommended in any pipeline that runs in production, as you may inadvertently delete data when it was not intended. This approach shown only makes sense in early stages of experimentation, and you'd ideally remove the shutil.rmtree() line when productionizing a workflow to properly catch and handle exceptions for cases where the tables already exist. Hope this helps!

To answer your other question about "different RuntimeError, we don't have a separate error type for catching existing node/rel tables that already exist. But at that stage of the pipeline, the "table already exists" error is the most likely error one might encounter, so if you come across any cases where you need more fine-grained or explicit error handling, let us know.

Okay, got it, delete directory with the DB or handle the RuntimeError.
It might also be useful (mainly for early experimentation and new user onboarding) to support in-memory databases like in sqlite, such that one could write db = kuzu.Database(":memory:") and mess with it without polluting the filesystem.

Yup, in-memory by default is one of the main areas where Kùzu is different from systems like DuckDB - see #1816 for the existing issue and discussion on this. It's on the longer term roadmap but requires a lot more changes to the core as Kùzu's query engine was built to run on on-disk storage, so requires additional effort from the system internals perspective.

I've just run into this issue, and ended up going with a rather un-pythonic "ask permission" approach:
if not conn.execute("CALL SHOW_TABLES() WHERE name = '<table-name-here>' RETURN name;").has_next():
    conn.execute("CREATE NODE TABLE <table-name-here>(<fields-go-here>)")

Yes please! I'm creating migration scripts now for longer living dbs, so it'll be extremely useful.

This feature is added in #3601 and should be available in the nightly build tmr.

Thank you 🙏
On Mon, Jun 10, 2024 at 20:45 andyfeng @.***> wrote:

This feature is added in #3601 https://github.com/kuzudb/kuzu/pull/3601
and should be available in the nightly build tmr.
—
Reply to this email directly, view it on GitHub
https://github.com/kuzudb/kuzu/issues/2878#issuecomment-2159666116, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKDS6N5M6WANTPPIGKOYKDZGZQDVAVCNFSM6AAAAABDHHAUOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJZGY3DMMJRGY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

@andyfengHKU
I just tried this:
conn.execute("CREATE NODE TABLE IF NOT EXISTS Person(name STRING, age INT64, PRIMARY KEY (name))")
Any idea why I get this error back:
ERROR - An error occurred while loading data into the database: Failed to create table in Kuzu database: Parser exception: mismatched input 'NOT' expecting '(' (line: 1, offset: 21)
"CREATE NODE TABLE IF NOT EXISTS Person(name STRING, age INT64, PRIMARY KEY (name))"

Hi @stugorf did you get this error after installing the latest nightly build? Could you confirm which dev release you're working with?

Hi Prashanth,
I have v0.4.2:latest running.
Regards,
David
On Sat, Jul 6, 2024 at 11:24 AM Prashanth Rao @.***>
wrote:

Hi @stugorf https://github.com/stugorf did you get this error after
installing the latest nightly build? Could you confirm which dev release
you're working with?

You are receiving this because you were mentioned.Message ID:
@.***>

Ah, I don't believe this is supported in 0.4.2 yet. We will be releasing 0.5.0 very soon and it will be supported there - till then could you run on the dev version and let us know if that works?

Sure! What tag should I pull?
On Sat, Jul 6, 2024 at 4:00 PM Prashanth Rao @.***>
wrote:

Ah, I don't believe this is supported in 0.4.2 yet. We will be releasing
0.5.0 very soon and it will be supported there - till then could you run on
the dev version and let us know if that works?
—
Reply to this email directly, view it on GitHub
https://github.com/kuzudb/kuzu/issues/2878#issuecomment-2212036443, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKDS6NOWYQUU7U46NKQJOTZLBZKBAVCNFSM6AAAAABDHHAUOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSGAZTMNBUGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

pip install --pre kuzu

Hi Prashanth,
I am using Poetry so poetry add kuzu --allow-prereleases worked and
installed kuzu = {version = "^0.4.3.dev47", allow-prereleases = true}. My
code now correctly executes conn.execute("CREATE NODE TABLE IF NOT EXISTS Person(name STRING, age INT64, PRIMARY KEY (name))")
On Sat, Jul 6, 2024 at 4:05 PM Prashanth Rao @.***>
wrote:

pip install --pre kuzu
—
Reply to this email directly, view it on GitHub
https://github.com/kuzudb/kuzu/issues/2878#issuecomment-2212037716, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKDS6PMX2VFGJ7I7SNHQODZLBZ3VAVCNFSM6AAAAABDHHAUOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSGAZTONZRGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thank you for the help!
On Sat, Jul 6, 2024 at 16:09 David Hughes @.***> wrote:

Hi Prashanth,
I am using Poetry so poetry add kuzu --allow-prereleases worked and
installed kuzu = {version = "^0.4.3.dev47", allow-prereleases = true}. My
code now correctly executes conn.execute("CREATE NODE TABLE IF NOT EXISTS Person(name STRING, age INT64, PRIMARY KEY (name))")
On Sat, Jul 6, 2024 at 4:05 PM Prashanth Rao @.***>
wrote:

pip install --pre kuzu
—
Reply to this email directly, view it on GitHub
https://github.com/kuzudb/kuzu/issues/2878#issuecomment-2212037716, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKDS6PMX2VFGJ7I7SNHQODZLBZ3VAVCNFSM6AAAAABDHHAUOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSGAZTONZRGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

Great, glad that worked!

Prashanth,
Will something like IF EXISTS be implemented for DROP so that we can
execute a command like DROP IF EXISTS Person
Regards,
David
On Sat, Jul 6, 2024 at 4:23 PM Prashanth Rao @.***>
wrote:

Great, glad that worked!
—
Reply to this email directly, view it on GitHub
https://github.com/kuzudb/kuzu/issues/2878#issuecomment-2212046778, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKDS6MMWXNE2YEV2B6A2DDZLB35JAVCNFSM6AAAAABDHHAUOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSGA2DMNZXHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi @stugorf, we haven't prioritized this yet as we normally wait to see if there's need from the community on specific keywords that require changes to our grammar. Though it seems like the DROP TABLE [IF EXISTS] syntax exists in Postgres SQL.
I'll create an issue for this, and someone can pick it up in due course. However, in the interim (assuming you're working in Python), you can easily work around this with just one additional line of code:
# Open kuzu connection
import kuzu

db = kuzu.Database("mydb")
conn = kuzu.Connection(db)

# Drop node table
node_table_name = "MyNodeTable"
if node_table_name in conn._get_node_table_names():
    conn.execute("DROP MyNodeTable")

# Drop rel table
rel_table_name = "MyRelTable"
if rel_table_name in conn._get_rel_table_names():
    conn.execute("DROP MyRelTable")

Not ideal, but it works well if you're using Python. You can also apply the not operator to negate the above check, and perform specific actions only if the table doesn't exist. Hope this helps!

Thank you for the workaround in the meantime. With the -dev version of kuzu
does the explorer work? I am getting this error:
[21:26:57.994] INFO (1): Access mode: READ_WRITE
[21:26:58.019] ERROR (1): Error getting version of Kùzu: Error:
std::bad_alloc
On Sun, Jul 7, 2024 at 12:27 PM Prashanth Rao @.***>
wrote:

Hi @stugorf https://github.com/stugorf, we haven't prioritized this yet
as we normally wait to see if there's need from the community on specific
keywords that require changes to our grammar. Though it seems like the DROP
TABLE [IF EXISTS] syntax exists in Postgres
https://www.postgresql.org/docs/current/sql-droptable.html SQL.
I'll create an issue for this, and someone can pick it up in due course.
However, in the interim (assuming you're working in Python), you can easily
work around this with just one additional line of code:
Open kuzu connectionimport kuzu
db = kuzu.Database("mydb")conn = kuzu.Connection(db)
Drop node tablenode_table_name = "MyNodeTable"if node_table_name in conn._get_node_table_names():
conn.execute("DROP MyNodeTable")

Drop rel tablerel_table_name = "MyRelTable"if rel_table_name in conn._get_rel_table_names():
conn.execute("DROP MyRelTable")

Not ideal, but it works well if you're using Python. You can also apply
the not operator to negate the above check, and perform specific actions
only if the table doesn't exist. Hope this helps!
—
Reply to this email directly, view it on GitHub
https://github.com/kuzudb/kuzu/issues/2878#issuecomment-2212545629, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKDS6M5ZA633XZ3W2UPSATZLGJBXAVCNFSM6AAAAABDHHAUOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSGU2DKNRSHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thank you for the workaround in the meantime. With the -dev version of kuzu does the explorer work? I am getting this error: [21:26:57.994] INFO (1): Access mode: READ_WRITE [21:26:58.019] ERROR (1): Error getting version of Kùzu: Error: std::bad_alloc
…
On Sun, Jul 7, 2024 at 12:27 PM Prashanth Rao @.> wrote: Hi @stugorf https://github.com/stugorf, we haven't prioritized this yet as we normally wait to see if there's need from the community on specific keywords that require changes to our grammar. Though it seems like the DROP TABLE [IF EXISTS] syntax exists in Postgres https://www.postgresql.org/docs/current/sql-droptable.html SQL. I'll create an issue for this, and someone can pick it up in due course. However, in the interim (assuming you're working in Python), you can easily work around this with just one additional line of code: # Open kuzu connectionimport kuzu db = kuzu.Database("mydb")conn = kuzu.Connection(db) # Drop node tablenode_table_name = "MyNodeTable"if node_table_name in conn._get_node_table_names(): conn.execute("DROP MyNodeTable") # Drop rel tablerel_table_name = "MyRelTable"if rel_table_name in conn._get_rel_table_names(): conn.execute("DROP MyRelTable") Not ideal, but it works well if you're using Python. You can also apply the not operator to negate the above check, and perform specific actions only if the table doesn't exist. Hope this helps! — Reply to this email directly, view it on GitHub <#2878 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKDS6M5ZA633XZ3W2UPSATZLGJBXAVCNFSM6AAAAABDHHAUOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSGU2DKNRSHE . You are receiving this because you were mentioned.Message ID: @.>

This happens most likely because the DB version you created is different than the DB version that's running in Kuzu Explorer. So if you created the db with a nightly build, then try launching the nightly Explorer. For example use this docker-compose.tml:
services:
  explorer:
    image: kuzudb/explorer:dev
    restart: unless-stopped
    environment:
      - MODE=READ_ONLY
    ports:
      - 8000:8000
    volumes:
      - ./ex_db_kuzu:/database

and then do:
docker compose pull
docker compose up

Perfect; I was just reading in the repo to use the 'dev' tag. Thank you.
On Sun, Jul 7, 2024 at 2:42 PM Semih Salihoglu @.***>
wrote:

Thank you for the workaround in the meantime. With the -dev version of
kuzu does the explorer work? I am getting this error: [21:26:57.994] INFO
(1): Access mode: READ_WRITE [21:26:58.019] ERROR (1): Error getting
version of Kùzu: Error: std::bad_alloc
… <#m_7732110577369242028_>
On Sun, Jul 7, 2024 at 12:27 PM Prashanth Rao @.*> wrote: Hi @stugorf
https://github.com/stugorf https://github.com/stugorf
https://github.com/stugorf, we haven't prioritized this yet as we
normally wait to see if there's need from the community on specific
keywords that require changes to our grammar. Though it seems like the DROP
TABLE [IF EXISTS] syntax exists in Postgres
https://www.postgresql.org/docs/current/sql-droptable.html
https://www.postgresql.org/docs/current/sql-droptable.html SQL. I'll
create an issue for this, and someone can pick it up in due course.
However, in the interim (assuming you're working in Python), you can easily
work around this with just one additional line of code: # Open kuzu
connectionimport kuzu db = kuzu.Database("mydb")conn = kuzu.Connection(db)
Drop node tablenode_table_name = "MyNodeTable"if node_table_name in
conn._get_node_table_names(): conn.execute("DROP MyNodeTable") # Drop rel
tablerel_table_name = "MyRelTable"if rel_table_name in
conn._get_rel_table_names(): conn.execute("DROP MyRelTable") Not ideal, but
it works well if you're using Python. You can also apply the not operator
to negate the above check, and perform specific actions only if the table
doesn't exist. Hope this helps! — Reply to this email directly, view it on
GitHub <#2878 (comment)
https://github.com/kuzudb/kuzu/issues/2878#issuecomment-2212545629>, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKDS6M5ZA633XZ3W2UPSATZLGJBXAVCNFSM6AAAAABDHHAUOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSGU2DKNRSHE
https://github.com/notifications/unsubscribe-auth/ABKDS6M5ZA633XZ3W2UPSATZLGJBXAVCNFSM6AAAAABDHHAUOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSGU2DKNRSHE
. You are receiving this because you were mentioned.Message ID: @.*>
This happens most likely because the DB version you created is different
than the DB version that's running in Kuzu Explorer. So if you created the
db with a nightly build, then try launching the nightly Explorer. For
example use this docker-compose.tml:
services:
explorer:
image: kuzudb/explorer:dev
restart: unless-stopped
environment:
- MODE=READ_ONLY
ports:
- 8000:8000
volumes:
- ./ex_db_kuzu:/database
and then do:
docker compose pull
docker compose up
—
Reply to this email directly, view it on GitHub
https://github.com/kuzudb/kuzu/issues/2878#issuecomment-2212585292, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKDS6JUOIMVOM7NT2CZPIDZLGY2ZAVCNFSM6AAAAABDHHAUOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSGU4DKMRZGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Yes, if this is indeed the case, let's open an issue to give a better error message. I'll ask @mewim to take a look.

Perfect; I was just reading in the repo to use the 'dev' tag. Thank you. On Sun, Jul 7, 2024 at 2:42 PM Semih Salihoglu @.> wrote:
…
Thank you for the workaround in the meantime. With the -dev version of kuzu does the explorer work? I am getting this error: [21:26:57.994] INFO (1): Access mode: READ_WRITE [21:26:58.019] ERROR (1): Error getting version of Kùzu: Error: std::bad_alloc … <#m_7732110577369242028_> On Sun, Jul 7, 2024 at 12:27 PM Prashanth Rao @.> wrote: Hi @stugorf https://github.com/stugorf https://github.com/stugorf https://github.com/stugorf, we haven't prioritized this yet as we normally wait to see if there's need from the community on specific keywords that require changes to our grammar. Though it seems like the DROP TABLE [IF EXISTS] syntax exists in Postgres https://www.postgresql.org/docs/current/sql-droptable.html https://www.postgresql.org/docs/current/sql-droptable.html SQL. I'll create an issue for this, and someone can pick it up in due course. However, in the interim (assuming you're working in Python), you can easily work around this with just one additional line of code: # Open kuzu connectionimport kuzu db = kuzu.Database("mydb")conn = kuzu.Connection(db) # Drop node tablenode_table_name = "MyNodeTable"if node_table_name in conn._get_node_table_names(): conn.execute("DROP MyNodeTable") # Drop rel tablerel_table_name = "MyRelTable"if rel_table_name in conn._get_rel_table_names(): conn.execute("DROP MyRelTable") Not ideal, but it works well if you're using Python. You can also apply the not operator to negate the above check, and perform specific actions only if the table doesn't exist. Hope this helps! — Reply to this email directly, view it on GitHub <#2878 (comment) <#2878 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKDS6M5ZA633XZ3W2UPSATZLGJBXAVCNFSM6AAAAABDHHAUOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSGU2DKNRSHE https://github.com/notifications/unsubscribe-auth/ABKDS6M5ZA633XZ3W2UPSATZLGJBXAVCNFSM6AAAAABDHHAUOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSGU2DKNRSHE . You are receiving this because you were mentioned.Message ID: @.> This happens most likely because the DB version you created is different than the DB version that's running in Kuzu Explorer. So if you created the db with a nightly build, then try launching the nightly Explorer. For example use this docker-compose.tml: services: explorer: image: kuzudb/explorer:dev restart: unless-stopped environment: - MODE=READ_ONLY ports: - 8000:8000 volumes: - ./ex_db_kuzu:/database and then do: docker compose pull docker compose up — Reply to this email directly, view it on GitHub <#2878 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKDS6JUOIMVOM7NT2CZPIDZLGY2ZAVCNFSM6AAAAABDHHAUOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSGU4DKMRZGI . You are receiving this because you were mentioned.Message ID: @.**>

Explorer itself has the correct infrastructure to handle a storage version mismatch, as shown below:

However, I think the issue was that the dev builds do not actively maintain the storage version number. The storage version number is defined at: https://github.com/kuzudb/kuzu/blob/9df0a994535829df598dbfdf135795513554850c/src/include/storage/storage_version_info.h#L15-L20
For each stable release, we manually update this dictionary to add the version number of kuzu and storage. But since each dev build is automatically built and deployed, it does not get its own storage version number. Instead, it simply assumes that it has the latest storage version number in the dictionary.


Add net getNodeAddress RPC

What this PR does / why we need it: /kind feature
Which issue(s) does this PR fixes?:  Adding getnodeaddresses
Usage: Fixes getnodeaddress @ Issue#48
Additional comments?: Testing In-progress

Also, we're using "Semantic Pull Request", you should relabel your title.


New full-stack demo

@anthonydahanne Can you have a look and make sure everything is working fine? We might really want to have fake calls to google and darksky to make it easier to use.
One thing that I don't like is that we can't pass a variable for the terracotta cluster. But I think we now have system properties replacement. So we should use this probably. Or find a more "Springy" way to configure the CacheProvider

@henri-tremblay I haven't reviewed yet but I was wondering the reason why all the commits have changed since the Innovation week ?

./mvnw clean install

eventually failed with :

Results :

Tests in error:
  ActorResourceIntTest.createActor » OutOfMemory Java heap space
  ActorResourceIntTest.deleteActor » OutOfMemory Java heap space
  ActorResourceIntTest.updateActor » OutOfMemory Java heap space

Tests should not load the actors list from the internet; a (small) list should be provided

Yes. Because we are on a new gît repo. So I had to restart from scratch
Le 25 oct. 2016 4:09 PM, "Anthony Dahanne"<EMAIL_ADDRESS>a
écrit :

@henri-tremblay https://github.com/henri-tremblay I haven't reviewed
yet but I was wondering the reason why all the commits have changed since
the Innovation week ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ehcache/ehcache3-samples/pull/6#issuecomment-256161079,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABKRM5s0EeRXETV_hXj7OrQeywLHTL_lks5q3mIQgaJpZM4KgZoE
.

please have a look at https://github.com/ehcache/ehcache3-samples/pull/7 it keeps history, remove the generated bower files and imports this current PR commits

Done by #7 instead

Bower should not be removed. The problem is that bower packages are based
on git tags. They are considered unstable. So committing them is deemed
safer.
Le 26 oct. 2016 6:55 AM, "Anthony Dahanne"<EMAIL_ADDRESS>a
écrit :

please have a look at #7
https://github.com/ehcache/ehcache3-samples/pull/7 it keeps history,
remove the generated bower files and imports this current PR commits
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ehcache/ehcache3-samples/pull/6#issuecomment-256314285,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABKRM2jPmyOr5_SteBp4dsoyIfQjIWZzks5q3zG-gaJpZM4KgZoE
.


Add web.external-url flag

Allows setting the full external URL for accessing Alertmanager, takes
precedence over web.hostname.
Fixes #95
I left the old flags there so we don't break any existing users, but they should
probably be dropped at some point.

Thanks! :+1:


Feature request: History after exit

I'd like the history to persist after exiting the shell, so if you re-enter the shell you can hit up arrow to see your previous command. Would you accept this as a PR with a toggle to turn it off? I'm thinking of using the temp dir to persist it (temporarily).

Yeah - I've wanted to do this. I'd love help on it, but want to make sure we do it totally right.
As part of this (and as a first step), I want to make a sturdy, basic API for temp files, as that subject is coming up a lot in Vorpal.
Wat implements a cross-platform temp file solution with a really small module, so perhaps we can do a similar thing and build it in.

Actually, just looked. Looks like I just use os.tmpDir(). I think the directory should be {temp}/.vorpal/hist, and then you can throw in a text file there for persistent history.

Then maybe for temp file access, we can have an API like:
vorpal.temp('hist'); // returns the directory string ./tmp/.vorpal/hist
vorpal.temp('hist').clear(); // clears out directory

Do you think maybe it makes more sense to providing more of an object-oriented API that persists itself automatically to the OS's temp dir? Here's my approach:
var history = vorpal.temp('history');
var commands = history.get('commands', []); // Second argument is default, if doesn't exist
// Last entry: commands[commands.length]
commands.push('command');
history.set('commands', commands); // Persists it
history.set('expires', Date.now() + 60000);

Something along those lines. Thoughts?

I'm totally down with that, which looks a lot like localStorage. We should just mirror the localStorage API in that case, IMO.
However, there should at least be one command that returns the location of a free-for-all localstorage directory, in case the user wants to do fs writes and reads, not just key/value assignments.

I am working on this and will submit a PR in the next week or so.

Agree with mirroring the localStorage API. That was actually what I was thinking originally, verbatim.

Nice and thanks for your help! :+1:

I think it makes more sense to implement this as an extension, so the developer will have a chance to implement the history matching algorithm he prefers, choose where and how to save history etc.
The current history implementation, in https://github.com/dthree/vorpal/blob/6381c2c87081cf4ebaa3b903cc32081614131a5f/lib/session.js, could be removed and rewritten as an extension.
I have written this super naïve history extension that saves to disk a list of newline-separated commands (accepts a filepath, defaults to $HOME/.vorpal_history): https://github.com/fiatjaf/vorpal-history/blob/master/index.js. It works before a command is actually sent, but the default history behavior breaks everything after that.
Anyway, the idea is on the first paragraph.

@fiatjaf I agree. I didn't think about it in these terms before. We should continue down this path.

Good thinking. :+1:

See #36.
Implemented in v1.5.0.


implement BitInputBase for data annotation validations (#1317)

This closes #1317

since we've decided to change some related matters to this issue, I'm going to close this PR for now.


(maint) Do not use Ruby stacktrace for "Puppet" stack

Previously, we used Kernel.eval to add additional information to the
Ruby call stack. That information would show that the call had come from
a Puppet manifest. We did this to interleave Puppet "function calls"
with Ruby function calls. Then when creating error or warning messages
we would retrieve the entire Ruby call stack and strip out everything
from the call stack save for the Puppet manifest files.
This moves us to use a threadsafe variable to store Puppet stack
information bypassing the performance issues that come from interacting
with the Ruby call stack.
Conflicts:

lib/puppet/pops/evaluator/runtime3_support.rb
lib/puppet/pops/puppet_stack.rb

cherry-pick note:
The original threadsafe class is not available in this stream. This
may be merged up to Puppet 6.5.x but not later w/o needing further
editing and/or review to ensure the threadsafety isn't compromised.

I believe this may help some issues we're seeing in a few customers' LTS installs. Preparing a patch to test that assumption.

Could you file a PUP ticket and "post-humously" update the git summary? At least that way we can document the change in the upcoming .z releases. Otherwise looks good.

Will do

CLA signed by all contributors.

friendly ping @justinstoller for PUP ticket in the git commit summary

Thanks for the reminder

jenkins please test this on redhat7-64,windows2019-64 with servertests

Is this ready to go in now?

yes


Add BitCore (BTX) support

Adding BitCore (BTX) support to the Ledger Nano S / Blue app.
Website: bitcore.cc
COIN_P2PKH_VERSION=3
see: bitcore source
COIN_P2SH_VERSION=125
see: bitcore source

Reference to Pull-request #30

https://github.com/LedgerHQ/ledger-live-common/pull/91


feat(Dialog): Migrate to Variance + ColorModes

Overview

Updates Dialog to current color mode standard and removes extra code.
Updates the documentation to reflect the differences.

PR Checklist

[ ] Related to designs:
[ ] Related to JIRA ticket: ABC-123
[ ] I have run this code to verify it works
[ ] This PR includes unit tests for the code change

📬Published Alpha Packages:@codecademy/gamut-illustrations@0.10.3-alpha.62fe34.0@codecademy/gamut-kit@0.3.39-alpha.62fe34.0@codecademy/gamut-labs@14.0.1-alpha.62fe34.0@codecademy/gamut-styles@9.5.4-alpha.62fe34.0@codecademy/gamut-tests@2.3.15-alpha.62fe34.0@codecademy/gamut@32.0.1-alpha.62fe34.0@codecademy/konamimojisplosion@0.2.15-alpha.62fe34.0@codecademy/markdown-overrides@0.5.27-alpha.62fe34.0@codecademy/styleguide@36.0.1-alpha.62fe34.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6080166baeb414fef6838325--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-illustrations@0.10.5-alpha.8a618d.0@codecademy/gamut-kit@0.3.45-alpha.8a618d.0@codecademy/gamut-labs@14.2.5-alpha.8a618d.0@codecademy/gamut-styles@9.5.6-alpha.8a618d.0@codecademy/gamut-tests@2.3.17-alpha.8a618d.0@codecademy/gamut@32.1.4-alpha.8a618d.0@codecademy/konamimojisplosion@0.2.17-alpha.8a618d.0@codecademy/markdown-overrides@0.5.29-alpha.8a618d.0@codecademy/styleguide@36.2.6-alpha.8a618d.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://608371ffcd53b334aaa40c41--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.3.49-alpha.869efc.0@codecademy/gamut-labs@14.4.1-alpha.869efc.0@codecademy/gamut@32.3.1-alpha.869efc.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6086e7ba7a03e825bbb4b08c--gamut-preview.netlify.appDeploy Logs

Codecov Report

Merging #1657 (869efc4) into main (90c0514) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

:exclamation: Current head 869efc4 differs from pull request most recent head 07974de. Consider uploading reports for the commit 07974de to get more accurate results

@@            Coverage Diff             @@
##             main    #1657      +/-   ##
==========================================
- Coverage   95.12%   95.11%   -0.02%
==========================================
  Files         268      268
  Lines        2729     2722       -7
  Branches      743      741       -2
==========================================
- Hits         2596     2589       -7
  Misses        127      127
  Partials        6        6

Impacted Files
Coverage Δ

packages/gamut/src/Dialog/index.tsx
100.00% <100.00%> (ø)

📬Published Alpha Packages:@codecademy/gamut-illustrations@0.10.7-alpha.07974d.0@codecademy/gamut-kit@0.3.51-alpha.07974d.0@codecademy/gamut-labs@14.4.3-alpha.07974d.0@codecademy/gamut-styles@9.6.1-alpha.07974d.0@codecademy/gamut-tests@2.3.19-alpha.07974d.0@codecademy/gamut@32.3.3-alpha.07974d.0@codecademy/konamimojisplosion@0.2.19-alpha.07974d.0@codecademy/markdown-overrides@0.5.31-alpha.07974d.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60874fbd8ba1342e464ee429--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.3.63-alpha.281bc1.0@codecademy/gamut-labs@15.2.3-alpha.281bc1.0@codecademy/gamut@32.6.2-alpha.281bc1.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://608b1aa58957236100e6f4e9--gamut-preview.netlify.appDeploy Logs


Wrong nesting for nested lists inside content class

Issue extracted from #129.
It seems to work fine with code snippets and flat lists, but with a nested list all 1st level elements except the first one become 2rd level element.
.foo[
 - a
 - b - I became a nested element
  - b1
  - b2
 - c
]

In HTML it looks like a 1st level li tag is not properly closed.
Reproduced problem:
http://jsfiddle.net/szpak/57uQb/2/

Is this a similar issue where a 3rd-level nested bullet is rendered as a 2nd-level bullet (b3 should be a 3rd-level list)?


Remove native outline from host

Fixes #71

This change is

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

…oh, damn – I didn’t realize it was applied to the core styles. I think this should go into the Lumo theme instead.

Should we revert?

@jouni yep, looks like we should, will do.


Emmet go to matching pair doesn't work at the very start of opening tags and very end of closing tags

VSCode Version: Code - Insiders 1.13.0-insider (c2a17a7929259d3d2643cb3f98478e994a39605b, 2017-05-30T05:12:15.312Z)
OS Version: Linux x64 4.10.0-21-generic
Extensions:

Extension
Author
Version

EditorConfig
EditorConfig
0.9.3

lorem-ipsum
Tyriar
1.0.0

sort-lines
Tyriar
1.3.0

theme-sapphire
Tyriar
0.2.1

vscode-svgviewer
cssho
1.4.1

tslint
eg2
0.15.0

git-project-manager
felipecaputo
1.3.2

md-navigate
jrieken
0.0.1

vscode-scss
mrmlnc
0.6.2

seti-icons
qinjia
0.1.3

#27316
It's strange that it works fine at the start of </foo> but not at the start of <foo>. Probably due to emmet, a better error would probably be better if so:

The same popup as go to definition would be good, I'm not sure if that's the direction we want to go for everything though? Plus it's probably not in the API yet.

Its a bug, will fix it. The command should work even when the cursor is at the start/end of the open/close tags.
That error you see shows up only on the first tag of the document, so thats a different issue. Will fix it too.

I updated to VS Code 1.17.2 and now Emmet 'Go to matching pair' command doesn't work at all (before this update it worked). Today is Oct 25 2017

@Dagge1 I see that you have logged an issue #36905 for this, lets take this up there


Sonic 2 - Freeze if pausing when finishing a level

for example, pausing here will cause the feeze.

https://youtu.be/zOnn_Fv_2-U
Maybe this is an actual bug in the game?


Support defining custom entry points

Motivation
As described in #139 although user can define custom entry_points and use them in the generated contract it is not possible to use it in generated multitests.
Solution
We could either use macro attribute pointing to the custom entry_point function or add method attribute inside of the macro.
Macro attribute approach will be more flexible for the user.
Add missing Context type
pub struct SudoCtx<'a, C: CustomQuery = Empty> {
    pub deps: DepsMut<'a, C>,
    pub env: Env,
}

Detect attribute sv::custom_entry_point on contract
This attribute should be used both by contract macro to use the custom entry point in multitest helpers and by entry_points macro so that there will be no duplication after generation.
pub mod entry_points {
    #[entry_point]
    pub fn sudo(_deps: DepsMut, _env: Env) -> ... {
    }
}

#[cfg_attr(not(feature = "library"), entry_points)]
#[contract]
#[sv::custom_entry_point(sudo=entry_points::sudo)]
impl ReceiverContract {
    pub const fn new() -> Self {
        Self {}
    }

    #[msg(instantiate)]
    pub fn instantiate(&self, _ctx: InstantiateCtx) -> StdResult<Response> {
        todo!()
    }
}

Alternative
Although support for sudo is not yet implemented we could allow defining sudo msg as it is done in case of reply. If detected sylvia will generate appropriate entry_point and implement cw_multi_test::Contract with this entry_point.

To make it complete - it should be possible to overwrite all of the entry points to possibly overwrite some sylvia behaviour in case of need (in particular: missing features).

In case of overwriting entry points other than sudo it shouldn't cause any issues.
In case of sudo we still don't generate the SudoMsg. This causes an issue with dispatch.
For cw_multitest::Contract implementation on user contract we need to define the type of the incoming message.
For f.e. query we will cast the received byte array to generated `ContractQueryMsg' type.
fn query(
    &self,
    deps: sylvia ::cw_std::Deps<sylvia ::cw_std::Empty>,
    env: sylvia ::cw_std::Env,
    msg: Vec<u8>,
) -> sylvia ::anyhow::Result<sylvia ::cw_std::Binary> {
    sylvia ::cw_std::from_slice::<ContractQueryMsg>(&msg)?
        .dispatch(self, (deps, env))
        .map_err(Into::into)
}

For sudo we don't have a message to base on so we would have to either require the user to use message with standarized name SudoMsg with dispatch method or we could generate the SudoMsg and thus provide support for multitest and entry points (please refer to the Alternative section in original description).
With all this I would suggest to first implement basic support for sudo and then on top of that introduce entry point overwriting with restriction that entry points need to use messages generated using #[msg(...)] attribute.

See your point here - you need to know the type of the message to properly parse it in particular places.
Using "standardized" name is always a wrong decision - you should have as minimal restrictions on code shape as possible. It might be reasonable default to reduce the simple case boilerplate, but there should always be a way to provide the custom typename.
What I would do here is just alter the syntax a bit, to provide space for naming the type, like:
#[cfg_attr(not(feature = "library"), entry_points)]
#[contract]
#[sv::custom_entry_point(sudo=entry_points::sudo(SudoMsg))]
impl ReceiverContract {
    pub const fn new() -> Self {
        Self {}
    }

    #[msg(instantiate)]
    pub fn instantiate(&self, _ctx: InstantiateCtx) -> StdResult<Response> {
        todo!()
    }
}

This is just an example; if you have an idea for better syntax feel free to suggest it. In this case I would not provide "default" name - the syntax is to be used rather rarely for cases where Sylvia is behind needs, So it is already "strange", and default - even if reasonable - is not super obvious. Because of that default would probably only bring confusion, and I would make providing the typename required.


Changes due to integration testing with election product

Description
Fixed issues related to integration testing with election equipment manifacturer.

Doing this actually gives a warning in VSCode.
CA1069: Enums should not have duplicate values


test(bookshelves): testing bookshelves

@AhmadT198  you can find the starter branch for bookshelves test here whenever you wanna jump on it- start the repository tests

if anyone pulls it make sure you migrate because I deleted all migrations

This issue is gonna stay open a while as we are preoccupied with more prior things before getting to it
@AhmadT198 if it so happens you ever jump on testing the respository add your branch to this issue


Use Django coverage plugin

Refactor coverage configuration

Coverage decreased (-0.2%) to 88.066% when pulling f8bef5eae13ff0d305246d4d2440992736ce410b on django-coverage-plugin into 24b9b84c2e365948e64d1810bcc100004075aaa7 on master.

Updated only changing the configuration and removing the unecessary file .coveragerc


Space between paragraphs

Hi there,
In the default configuration of the minimal theme, there is only little space between each blocks/paragraphs (there is actualy no space at all). It would be nice to be able to adjust this space through the minimal theme plugin, or if it could be bigger by default at least.
There is a space only before headings. This space should, in my opinion, also be present between paragraphs. The actual workaround is to put empty lines to delimit paragraphs.

duplicate #360 which provides a better description with screenshots


Voice / Digital settings not sticky

Only one microphone volume level is set at startup.   The the V or D value will be set at start up depending on the last setting of the V/D button.

This has been fixed


Add total supply of nft and different rarities

Hi, I updated the code to input total supply of NFT and provide different rarities
Hope it to be improve this repo for users.

hello, pls did you by chance create a tutorial on how to use it now?

can you please try to run my updates?
It will be asking all information needed.
or I can upload some tutorial video?

I tried to run it but it looked thesame thing as the original.

or is there a different way to run your update? because its not asking me for total supply.

Please check line 90 and 241 on my updates (index.js)
what's your whatsapp or telegram?
Let's have a quick call

+18152165330 - whatsapp
@devstar0718 - telegram
<EMAIL_ADDRESS>- email
this is my contact info


🔄 Synced file(s) with jhudsl/OTTR_Template

Synced local file(s) with jhudsl/OTTR_Template.

Changed files

Synced local directory .github/workflows/ with remote directory .github/workflows/Synced local  config_automation.yml with remote  config_automation.yml

This PR was created automatically by the repo-file-sync-action workflow run #10910164970

Please carefully review these changes and decide which are useful for your course.
See the release notes: https://github.com/jhudsl/OTTR_Template/releases

If you don't want the changes from a particular file, you can always revert that particular commit before merging the sync PR.
If you will not want any updates on this file in the future, you may want to remove a file from being synced in your repo by reconfiguring the sync file.

If you want only some changes, but they are not on a whole file basis, you could check out the branch and make manual edits. To checkout the branch, navigate to your own repository you should be able to run:

git checkout repo-sync/OTTR_Template/default

If you don't want any of the changes you can close the PR entirely.

You may want to unenroll your repository from the sync GitHub actions by filing a PR on OTTR_Template
to delete your repo name from this file if this will continue to be the case.

going to merge this even though there are spell checks and url checks that need attention... doing that in another PR


Add cell clustering to QC report

Is your feature request related to a problem? Please describe.
Once we start to have visualization with #121 , we will probably want to add some color to the plot, which probably means adding clustering to the visualization.
Describe the solution you'd like
Clustering should be added separately, likely as part of the core scpca-nf workflow, but the notebooks should notice if there is clustering present and use it to color the UMAP visualization.
Describe alternatives you've considered
We could do clustering internal to the notebook, but we probably don't want to.
Additional context
This was originally part of #20. I am separating it out here, since we have a separate issue for UMAP alone.

Closing this because we decided we don't want to add clustering right now.


gender inclusive language

change "her" to "them"

@emberstevens : Thanks for your contribution! The author, @jeevansd, has been notified to review your proposed change.

#sign-off

Adjusted gender-inclusive language so that the pronoun doesn't conflict with the traditionally female-gendered name "Britta."


feat(gemini) Support Safety Settings for VertexAiGeminiChatModel

Adds support for SafetySettings configuration to VertexAiGeminiChatModel and VertexAiGeminiChatOptions
See https://cloud.google.com/vertex-ai/generative-ai/docs/multimodal/configure-safety-filters for reference.
Should fix https://github.com/spring-projects/spring-ai/issues/942

@tzolov I updated the code with updates from the spring-javaformat plugin. Apologies that I didn't catch that the first time.

Great feedback. I'll take a look and get back to you.

@tzolov I think we're good to go now.
Changes since last review:

Introduce new VertexAiGeminiSafetySetting class to allow for declarative configuration. This is converted to the Vertex AI setting at request-time.
Not null assertions for safetySettings on both the Builder and the class property.
Verified that declarative configuration works
Updated docs

I made some changes to the originally suggested SafetySetting class, including renaming it and adding a Builder. I also kept the Spring-defined enums both value- and name- consistent with the Gemini enums so that there won't be accidental confusion of users.
Let me know if there is anything else.

thanks @terussell85


[stable/spark-history-server] add apiVersion

Adding the apiVersion for chart.yaml
to fix the issue: https://github.com/helm/charts/issues/13763
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] title of the PR contains starts with chart name e.g. [stable/chart]

/assign @mattfarina

/lgtm


Fix instance-type option

By default rolling-restart is not showing wich instance type will be used.
This leads to a situation when users do not know what they are execution.
This PR enforces users to specify instance type and removes incorrect
default value (that is hidden, btw)

:+1:

👍


add ml-commons plugin to 2.1 manifest

Signed-off-by: Yaliang Wu<EMAIL_ADDRESS>Description
Add ml-commons plugin to 2.1 manifest
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #2252 (d81243b) into main (6d4f71d) will increase coverage by 5.43%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #2252      +/-   ##
=============================================
+ Coverage     94.56%   100.00%   +5.43%
=============================================
  Files           205         6     -199
  Lines          4254       105    -4149
  Branches         29        19      -10
=============================================
- Hits           4023       105    -3918
+ Misses          225         0     -225
+ Partials          6         0       -6

Impacted Files
Coverage Δ

src/system/zip_file.py

..._workflow/perf_test/perf_test_runner_opensearch.py

...est_workflow/perf_test/perf_single_node_cluster.py

src/ci_workflow/ci_check_list_dist.py

...w/perf_test/perf_test_runner_opensearch_plugins.py

...PromoteArtifacts_OpenSearch_Dashboards_Jenkinsfile

tests/jenkins/jobs/DownloadFromS3_Jenkinsfile

src/ci_workflow/ci_check_npm_package_version.py

src/test_workflow/test_result/test_result.py

tests/jenkins/jobs/BuildShManifest_Jenkinsfile

... and 189 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d4f71d...d81243b. Read the comment docs.

I have no permission to merge PR. Please help review and merge.

Will do once all test cases pass. Thanks!


Commander

Commands are awesome but impose a complexity burden on users. One way to alleviate this is to have a smarter command prompt that can check syntax and perform tab completions. This PR introduces a basic commander widget, puts in place tab completions for command names only, and sets the stage for completions for choices, paths, cut specifications and so forth.


Created XhrIo object from XhrIoPool doesn't receive the headers if the XhrIoPool was instantiated with opt_minCount > 0

This issue was imported from Closure Library's previous home at http://closure-library.googlecode.com
The link to the original issue is:
https://code.google.com/p/closure-library/issues/detail?id=191

Fixed in https://github.com/google/closure-library/pull/304


Service Renaming

Hi,
Thanks for the code, this was the most well done version of this interceptor I found. Just wanted to suggest one small change: How do you feel changing authService to something more unique? It's a too generic name for a third party service and prevent's me to creating my own authService. Have you considered naming it httpAuthService or something?

:+1:

+1

+1

The problem is that it will brake all the apps using this module. I do this change, bump a major version number, but NPM or Bower will pick what's new and all the apps will crash.

@witoldsz only if people are using "" in their package.json/bower.json file. If that's the case, it's the users own fault for using "" in their .json file as you should always specify a major version using either carot or tilde http://stackoverflow.com/questions/22343224/difference-between-tilde-and-caret-in-package-json
The point of a major version change is to account for non-backwards compatible or breaking changes.

I agree @toymachiner62. I read some issues and PR and I think there is (or will be in short time) space to release new major version with breaking changes (and good documentation).
So, maybe create new branch first and plan changes :)
I think part of new version could also be some dist folder with .min.js version and grunt/gulp to create it.

I think part of new version could also be some dist folder with .min.js version and grunt/gulp to create it.

Wouldn't it be strange if the source code repository had also the dist files? Committed on each source change? What about strange merge conflicts? Doesn't seem right, does it?

Dont think so. Dist folder will be update only on new release. I see it in a lot of simple angular/JS libraries. E.g. https://github.com/eriktufvesson/ngBootbox.
However angular.js make it with separate bower repository. See https://github.com/angular/bower-angular.git
I think this is only on owner (and contributors) how to do it :) But I think minimized version could be useful.

Update on each release seems like a good compromise.

Yeah. But contributors cannot commit to dist folder in PR, dont forget build on release, change bower conf, create some minify task and so on.
I know little bit painful to reach small goal as minimized version, its your call ;)


Tabs on the product page are not reset properly

Current behavior
If the user switches to Read reviews,  then each newly viewed PDP page will display a view with reviews, instead of displaying 'Description' by default
Expected behavior
By default, first tab (Description in our case) should be opened
Steps to reproduce the issue

Go to any PDP
Switch to "Read reviews"
Change PDP

Can you handle fixing this bug by yourself?

[ ] YES
[x] NO

Environment details

Browser: All
OS: All
Code Version: All

Additional information
No additional information

@qiqqq now there is the same problem


Q/A- Using snorkel in my python script

Hi there,
Is it possible to use snorkel to label some data within my python script outside jupyter notebook?
I have tried doing that even the import statement throws error.
ModuleNotFoundError: No module named 'snorkel'

Hi,
Definitely! This is often how we use Snorkel in our lab. The issue is likely just putting Snorkel on your Python path so that import statements know where to look. Here's a tutorial I found on doing so:
http://www.bdnyc.org/2012/09/editing-pythonpath-to-import-modules/


PublisherService: Handle all type of exceptions when failing to publish

Current implementation doesn't take in to account AmazonClientExceptions, thus, will miss if there is connectivity issues to aws.
This will handle all types of unforseen exceptions, so if something exceptional happens: leave the message in the que.

ping @xiaodong-izettle

fyi: @ssprang

@MrShish, I paired programming with @nzroller for this PR: https://github.com/iZettle/sun/pull/7580.
It will solve the issue at hand. But I think this one is good anyway. :)

Nice and merging...


Update killbill-oss-parent to 0.146.35

Currently used version contains https://avd.aquasec.com/nvd/2022/cve-2022-1471/ https://avd.aquasec.com/nvd/2022/cve-2022-1471/

Thanks!


hipcc straight up broken

Describe the bug
hipcc not even shows --help
Steps To Reproduce
Steps to reproduce the behavior:

bring rocmPackages.hipcc to a shell
hipcc --help
Can't exec "/usr/local/cuda/bin/nvcc": No such file or directory at /nix/store/xs85f29kps1d5p69fhrcgl47a466zscs-hipcc-5.7.0/bin//hipcc.pl line 634. failed to execute: No such file or directory

Expected behavior
Help message
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Notify maintainers
@NixOS/rocm-maintainers

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.59, NixOS, 23.11 (Tapir), 23.11pre-git`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.15.2`
 - nixpkgs: `/nix/store/ki98w9ah1k5p62mfv5pjbb58szndc2g5-source`

Same for  rocmPackages_5.hipcc

You need to use rocmPackages_5.clr.
The hipcc package itself doesn't include the wrapper.

Maybe I should move hipcc and hip-common into clr to avoid this sort of issue in the future.

@Madouura i had a similar issue.
I wanted to test if HIP is setup correctly and found this test: https://rocm.docs.amd.com/projects/HIP/en/latest/how_to_guides/debugging.html#debugging-hip-applications
So i tried hipcc from the hipcc package. It's broken:
[davidak@gaming:~]$ nix-shell -p rocmPackages.hipcc
this path will be fetched (0.43 MiB download, 3.66 MiB unpacked):
  /nix/store/iwl6aad529v3l2m1g7w5l75dc4m0b1am-hipcc-5.7.1
copying path '/nix/store/iwl6aad529v3l2m1g7w5l75dc4m0b1am-hipcc-5.7.1' from 'https://cache.nixos.org'...

[nix-shell:~]$ hipcc app.cpp -o app
Can't exec "/opt/rocm/llvm/bin/clang": No such file or directory at /nix/store/iwl6aad529v3l2m1g7w5l75dc4m0b1am-hipcc-5.7.1/bin//hipcc.pl line 175.
Use of uninitialized value $HIP_CLANG_RT_LIB in scalar chomp at /nix/store/iwl6aad529v3l2m1g7w5l75dc4m0b1am-hipcc-5.7.1/bin//hipcc.pl line 176.
Can't exec "/opt/rocm/bin/rocm_agent_enumerator": No such file or directory at /nix/store/iwl6aad529v3l2m1g7w5l75dc4m0b1am-hipcc-5.7.1/bin//hipcc.pl line 487.
Use of uninitialized value $targetsStr in substitution (s///) at /nix/store/iwl6aad529v3l2m1g7w5l75dc4m0b1am-hipcc-5.7.1/bin//hipcc.pl line 488.
Use of uninitialized value $targetsStr in split at /nix/store/iwl6aad529v3l2m1g7w5l75dc4m0b1am-hipcc-5.7.1/bin//hipcc.pl line 494.
sh: line 1: /opt/rocm/llvm/bin/clang: No such file or directory

Using hipcc from the rocmPackages.clr package does work, but it's not obvious to the user to use that and not the hipcc package.
It would be good if the hipcc package does what a user expects. Maybe make it an alias for clr?


Update data-lake-storage-use-databricks-spark.md

Replace following section
Create a service principal. See How to: Use the portal to create an Azure AD application and service principal that can access resources.
There's a couple of specific things that you'll have to do as you perform the steps in that article.
✔ When performing the steps in the Assign the application to a role section of the article, make sure to assign the Storage Blob Data Contributor role to the service principal.
[!IMPORTANT] Make sure to assign the role in the scope of the Data Lake Storage Gen2 storage account. You can assign a role to the parent resource group or subscription, but you'll receive permissions-related errors until those role assignments propagate to the storage account.
✔ When performing the steps in the Get values for signing in section of the article, paste the tenant ID, app ID, and client secret values into a text file. You'll need those soon.
With  following

Follow Step 1 to Step 3 from  Connect to Azure Data Lake Storage Gen2 using OAuth 2.0 with an Azure service principal to connect to ADL Stroage Gen 2 using Secret directly or  Step 1  to Step 5 to connect to ADL Gen2 Storage using Keyvault back Secrets.
:heavy_check_mark: When performing the steps in the Get values for signing in section of the article, paste the tenant ID, app ID, and client secret values into a text file. You'll need those soon.

Learn Build status updates of commit 351482f:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/machine-learning/how-to-auto-train-image-models.md
:warning:Warning

Details

articles/machine-learning/how-to-manage-models.md
:warning:Warning

Details

articles/machine-learning/how-to-prepare-datasets-for-automl-images.md
:warning:Warning

Details

articles/machine-learning/tutorial-auto-train-image-models.md
:warning:Warning

Details

articles/storage/blobs/data-lake-storage-use-databricks-spark.md
:warning:Warning

Details

articles/machine-learning/how-to-auto-train-image-models.md

Line 192, Column 1: [Warning: invalid-code] The code snippet "~/azureml-examples-main/sdk/python/jobs/automl-standalone-jobs/automl-image-object-detection-task-fridge-items/data/training-mltable-folder/MLTable" could not be found.

articles/machine-learning/how-to-manage-models.md

Line 360, Column 1: [Warning: invalid-code] The code snippet "~/azureml-examples-main/CLI/assets/model/job-model-as-input.yml" could not be found.
Line 424, Column 1: [Warning: invalid-code] The code snippet "~/azureml-examples-main/CLI/assets/model/job-model-as-output.yml" could not be found.

articles/machine-learning/how-to-prepare-datasets-for-automl-images.md

Line 168, Column 1: [Warning: invalid-code] The code snippet "~/azureml-examples-main/sdk/python/jobs/automl-standalone-jobs/automl-image-object-detection-task-fridge-items/data/training-mltable-folder/MLTable" could not be found.

articles/machine-learning/tutorial-auto-train-image-models.md

Line 272, Column 1: [Warning: invalid-code] The code snippet "~/azureml-examples-main/sdk/python/jobs/automl-standalone-jobs/automl-image-object-detection-task-fridge-items/data/training-mltable-folder/MLTable" could not be found.

articles/storage/blobs/data-lake-storage-use-databricks-spark.md

Line 41, Column 55: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/databricks/getting-started/connect-to-azure-storage#--step-2-create-a-client-secret-for-your-service-principal' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 39, Column 1: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/databricks/getting-started/connect-to-azure-storage' will be broken in isolated environments. Replace with a relative link.
Line 41, Column 55: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/databricks/getting-started/connect-to-azure-storage#--step-2-create-a-client-secret-for-your-service-principal' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit d9e920e:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/machine-learning/how-to-auto-train-image-models.md
:warning:Warning

Details

articles/machine-learning/how-to-manage-models.md
:warning:Warning

Details

articles/machine-learning/how-to-prepare-datasets-for-automl-images.md
:warning:Warning

Details

articles/machine-learning/tutorial-auto-train-image-models.md
:warning:Warning

Details

articles/storage/blobs/data-lake-storage-use-databricks-spark.md
:warning:Warning

Details

articles/machine-learning/how-to-auto-train-image-models.md

Line 192, Column 1: [Warning: invalid-code] The code snippet "~/azureml-examples-main/sdk/python/jobs/automl-standalone-jobs/automl-image-object-detection-task-fridge-items/data/training-mltable-folder/MLTable" could not be found.

articles/machine-learning/how-to-manage-models.md

Line 360, Column 1: [Warning: invalid-code] The code snippet "~/azureml-examples-main/CLI/assets/model/job-model-as-input.yml" could not be found.
Line 424, Column 1: [Warning: invalid-code] The code snippet "~/azureml-examples-main/CLI/assets/model/job-model-as-output.yml" could not be found.

articles/machine-learning/how-to-prepare-datasets-for-automl-images.md

Line 168, Column 1: [Warning: invalid-code] The code snippet "~/azureml-examples-main/sdk/python/jobs/automl-standalone-jobs/automl-image-object-detection-task-fridge-items/data/training-mltable-folder/MLTable" could not be found.

articles/machine-learning/tutorial-auto-train-image-models.md

Line 272, Column 1: [Warning: invalid-code] The code snippet "~/azureml-examples-main/sdk/python/jobs/automl-standalone-jobs/automl-image-object-detection-task-fridge-items/data/training-mltable-folder/MLTable" could not be found.

articles/storage/blobs/data-lake-storage-use-databricks-spark.md

Line 39, Column 1: [Warning: file-not-found - See documentation] Invalid file link: '../../databricks/getting-started/connect-to-azure-storage'.
Line 41, Column 55: [Warning: file-not-found - See documentation] Invalid file link: '../../databricks/getting-started/connect-to-azure-storage'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

#Sign-off

Thanks for the contribution @csunilkumar . I like the suggestion to consolidate the prereqs. Can you please review/accept my PR into your contribution? - https://github.com/csunilkumar/azure-docs/pull/1. The updated text fixes a typo and a broken link but also suggest rephrasing for clarity and consistency. Thx

I updated doc in a separate PR. Closing this one as duplicate. Thanks for the suggestion!
#please-close


We need our API refactored

So one of the main goals of the project is to ultimately consume a community standard API that will work with Google!
The API is a work in progress that will live here: https://github.com/kris-nova/cluter-api
Furthermore, we need someone to audit and review this API, as it will be a good candidate for a starting point for the cluster API project.
I kind of hate the words we use now to represent things, can we please change them? I am terrible at naming things.

Fixed with #162


Use git flow workflow

https://www.atlassian.com/git/tutorials/comparing-workflows/gitflow-workflow
It's a proposal.

My immediate thought was "yeah, about time to do this". Then, I realized for a lot of new contributors, the process is:

fork
do work
submit PR

And to have to deal with syncing upstream multiple branches while working in their own repo is likely to be more painful.
That said, I expect we'll have growing number of contributors add to this repo, like yourself, for which common git flow will be useful.
If we adopt git flow for contributors with commit access to repo, could we still keep an easy workflow for new people wanting to submit patches via cloning and PRs? Also, I'd like to ensure support for people who don't even want to use (or geo-blocked from using) GitHub so they can still send patches/diffs via email.
If we continue to use just master, feature-xyz and tags, can we keep merging features into master, treating it like a common develop branch, without affecting people using the projects via Composer?
ie, unless users explicitly target master in their composer.json, can we avoid pushing them new unstable releases?

In my opinion, in this repository, only need to exists master and development branches. Features and Bug branches are reserved to forked repositories of contributors. You will have clean repositories and contributors only merge with development branch and you will accept patches via email.
We could use some sort of forking workflow with git flow

Thanks, that makes sense to me.
If you want to add instructions to the repo's readme (just regular git commands, not any extensions), under some kind of "How to contribute" section, we can mark this off and start using.

The master and development branches should be enough for the project for now. Master should be more stable and better tested, so people who are more into just using the plugin and not so much getting the bleeding edge dev version can stick to the master.
Forks and contributors can then name their branches as they see best, but then the pull requests should be merged mostly to the development-branch, and from there to master.
So yeah, basically what you guys said before. Just wanted to say as a new user/developer, that I was feeling the need for this as well. There are no official releases available, so I just cloned the repository. But it was broken even tho it was master branch, so first things I needed to do was to fix the couple of issues I was facing. This process for new users could be improved by making these changes as discussed.
Sidenote, aside from these couple of issues I was facing, the plugin seem to be working nicely now. Good job! The site is now super fast, I think a ton of sites would benefit so much from using static page generator like this.

So yeah, basically what you guys said before. Just wanted to say as a new user/developer, that I was feeling the need for this as well. There are no official releases available, so I just cloned the repository. But it was broken even tho it was master branch, so first things I needed to do was to fix the couple of issues I was facing.

I really don't see how this change will help with that at all. As it is, when I make changes it's because I just barely have time to make and test those changes (and testing often takes longer than the coding). I definitely don't have time to test the same changes twice on two different branches. For my part at least, I will just have to make changes to development without pushing any fixes to master, and master will just be an older version of development with less features and more bugs. We don't have the manpower to make things more time-consuming than they already are. Time is better spent on getting the plugin built out and out of alpha status.
Note that for major experimental changes, I'm already keeping those off the main branch and am testing those in other places like in https://github.com/WP2Static/wp2static-addon-advanced-crawling. That said, it has already come at the cost of having bug fixes in that addon which have not been applied to the core plugin due to lack of time.
On the other hand, it would be nice to have some newer official releases.

You don't have to test twice, when you feel that some version in development is in ok state and somewhat enough tested to be in master, just switch from the development branch to the master git checkout master and then merge the development to master git merge development. And that's it. Then you can go back to the development branch to continue to do stuff that has potential to break stuff.
But yeah, I know how it is. It's consuming to develop open source projects for free on your free time. It's a job with little praise and lot's of complaints. However, I don't intend to complain. Just suggesting and letting you know my point of view. Keep up the good work.

Yep, I am initial hesitant to any extra process without direct benefits, but I'm behind using development as mentioned.
It was set as the default branch a while back, which I switched back to master when I was lazy and needed to move quickly.
As @JTS-FIN mentioned, no need for extra test, we just treat develop as we have been master.
Myself or another committer can update master refs same time as tagging release versions.
The biggest benefit I see in us maintaining quick development in develop branch, is that people can then rely upon semvar in their composer files/workflows or master when they want the latest "stable" head. develop we treat as unstable.
Aside: we still don't have any releases in this repo, as I want to get back to my coding productivity, gather up all working add-ons and be in control of the first release, including docs, etc. Who knows how long until I'm of sound mind and productivity to do that, but we'll get there :)

I'll leave this open until I'm ready to do some releases and will set develop as default branch and add that wording to readme

In the meantime, send code through how you like. PRs for most, and if you have commit access to repo, as you like

updated README with some contrib notes. develop set as default branch already and workflow a bit smoother now, whilst accommodating dev and stable WP plugin versions


Where is 0.5.0.pre

I cannot find this version of the gem 0.5.0.pre in this repository. Why?

It is master

You are right. Sorry.
https://github.com/james2m/seedbank/compare/v0.4.0...master


[JOSS Review] Statement of need and the paper

Dear authors,
The paper is written well, but these issues should be addressed:

More elaboration is needed on "The updated version is better designed, more efficient, and significantly more user-friendly" and "significant enhancements over its predecessor, such as new algorithms for improved sarcomere detection and tracking, faster computation times, and a more user-friendly library design". These sentences seem to be qualitative. Can you provide more details leading to such a conclusion?
Why is the new algorithm more efficient than the previous one (Zhao et al. 2021)? A quantitative comparison is needed here. Comparing and elaborating on the differences between Fig 4 in this paper and Fig 6 of the previous publication can be helpful here.
"SarcGraph is readily customizable and adaptable by the user", how is this going to come into practice? How is this customizability foreseen considering that the software comprises only 2 big source files?
The scale bar is missing in the paper figures.
It can be nice to mention how the reader should proceed to reproduce the figures of the paper?
The JOSS guidelines require the paper to contain a section titled "statement of need", which is missing in this case. Part of the summary is already discussing it, but a separate section with more elaboration on the target group of users is desired. The software should also be compared to other available tools in this section.
I think it is beneficial if you mention the limitations of the library briefly (can be in the documentation instead).

P.S. This issue is related to https://github.com/openjournals/joss-reviews/issues/5322

We appreciate your thorough feedback on the manuscript and the opportunity to address the concerns raised. In response to your comments, we have directly implemented the following changes:

We introduced a new section in the manuscript titled “SarcGraph vs. Legacy Sarc-Graph,” which discusses the key differences and improvements between the two versions.
In the same section, we offer a quantitative comparison of the run time and sarcomere tracking performance for both versions of SarcGraph using an experimental sample video (displayed in Figure 2, left panel) and a synthetically generated sample (depicted in Figure 4).
We believe that the addition of specific guides for developer in response to Sarc-Graph/sarcgraph#2 and Sarc-Graph/sarcgraph#3 will better facilitate users interested in extending the software. By customizability, we mostly meant that our code is structured to enable the use of individual steps in isolation or to be replaced with further development. This distinction should be clearer in the revised manuscript.
We have incorporated a scale bar in Figure 2, as it was the only plot requiring one.
In the appendix, we included code snippets for reproducing the figures 2-4 and added ground truth data for the synthetic sample in Figure 4 to the repository under the ‘validation-data’ folder.
We have added a “Statement of Need” section that comprehensively addresses the challenges of the field and the target user group.
Lastly, we included a section in the manuscript titled “Current Limitations and Plans for Future Development,” which outlines the software’s limitations and potential future directions.
We hope that these revisions adequately address your concerns, and we welcome any further comments or suggestions. Again, the time taken to provide this comprehensive feedback is much appreciated.

We hope that these revisions adequately address your concerns, and we welcome any further comments or suggestions. Again, the time taken to provide this comprehensive feedback is much appreciated.


Cannot directly "Clone from GitHub"

Type: Bug
Hi!
I have never realized this before, but since some time the Git: Clone command drop-down does not show "Clone from GitHub" anymore.
It's a bit mysterious to me as to why because

disabling all extensions did not help (via code --disable-extensions),
an extension bisect did neither,
it worked though in a newly installed Insiders instance/window (so re-installing might probably help),
completely removing all user settings also did not help,
and I have this issue both on my personal and office machines (with settings sync enabled).

Steps to reproduce:

???
Execute the Git: Clone command.
Input any character(s) or full names of valid, public GitHub repos.
"Clone from GitHub does not appear".

 Is there a chance that the "GitHub" extension is disabled? Please open the "Extensions" view, search for "@builtin" and scroll down to the "GitHub" extension. Is the extension enabled? if not, can you please enable it and see if that resolves the problem? Thanks!

@lszomoru: That was exactly the issue!
I have no idea how, but the built-in GitHub extension was disabled.
In hindsight I feel stupid, thanks a lot for your help!

@ChristoWolf, no worries. I am glad that we were able to fix it.


Why remove the app from winget?

What's the Problem?
No response
Solution/Idea
Re-add this app to winget, since it is the easiest way for app distribution (mostly updating) on windows, rather than the windows store and manually updating it. If not, can you please state the reason why not?
Alternatives
The ms store is full of bloat, the manual installation requires manual updating, choco and scoop work, but winget is starting to replace them.
Priorities

Capability
Priority

This proposal will allow developers to accomplish W
Must

This proposal will allow end users to accomplish X
Should

This proposal will allow developers to accomplish Y
Could

This proposal will allow end users to accomplish Z
Won't

Files Version
No response
Windows Version
No response
Comments
No response

The app can still be installed through WinGet, alternatively you can use the sideload version of Files https:/files.community/download/stable which has auto update.

Can you please tell me, what is the ID of the winget package, since I can't find it. And also your sideload link (https://github.com/files.community/download/stable) is a broken (github 404 page)?

The WinGet package id is 9NGHP3DX8HDX.
The download link for the sideload packages is https://files.community/download/stable

I would like to ask why is the winget id just some random string and not a descriptive name?
(something like files-community.Files, like for most other apps)? And also how to find it using the winget search command? Also i can't seem to find files on something like https://winstall.app?

@CodeCubeNeo the winget id is provided by the Microsoft Store, I believe you can still search for the app name.

I tried to search for "files", " files community", "files app" (using the "winget search {search query}" command and it didnt find anything.

Ok, but what about my second comment, about getting Files its own standalone winget package (not provided with ms store, but the actual winget-pkgs)

The last time we tried, there were some issues with WinGet not installing the correct dependencies, so they stopped accepting packaged apps like Files.

Not a problem since Winget 1.6 (Sep. 21, 2023).
However there is another problem now.

Try using
https://cdn.files.community/files/stable/Files.Package.appinstaller

If that doesn't work you can try using the offline files, first is Files and seconds WinAppSDK. there will have to be updated as Files gets updates.
https://cdn.files.community/files/stable/Files.Package_<IP_ADDRESS>_Stable_Test/Files.Package_<IP_ADDRESS>_x64_arm64_Stable.msixbundle

https://cdn.files.community/files/stable/Files.Package_<IP_ADDRESS>_Stable_Test/Dependencies/x64/Microsoft.WindowsAppRuntime.1.5.msix

Try using the below, if any of them work please comment which one did.
https://cdn.files.community/files/stable/Files.Package.appinstaller

If that doesn't work you can try using the offline files, first is Files and seconds WinAppSDK. these will have to be updated as Files gets updates.
https://cdn.files.community/files/stable/Files.Package_<IP_ADDRESS>_Stable_Test/Files.Package_<IP_ADDRESS>_x64_arm64_Stable.msixbundle

https://cdn.files.community/files/stable/Files.Package_<IP_ADDRESS>_Stable_Test/Dependencies/x64/Microsoft.WindowsAppRuntime.1.5.msix

@vikingnope

@vikingnope it's a standard msixbundle so you can use any of the appxpackage commands. See our documentation for an example.

will have a look and see what I can do, thanks

Maybe this can be reopened? It would be more visible on the list. I almost filed a new issue here to add Files to Winget… 😅

Any issue with Winget would be on Microsoft's side. The links I posted above are standard app installer package which can be installed silently

There is still some issue on Winget side blocking the install without known what the issue is I can't do anything to put Files on there.


Fix some quality issues

This pull request fixes some of the issues raised by DeepSource on my fork of this repo here.
Some issues were automatically fixed by DeepSource, while I fixed some of them by hand.
This PR also contains a .deepsource.toml, in case you want to run continuous quality analysis on your repository. If you wish to do so, you can follow these steps:

Merge this PR.
Signup on DeepSource here.
Activate analysis on your repo here.

Here is a gist of the issues that I have fixed in this PR :

Replaced strings.Replace(...,-1) with strings.ReplaceAll(...)
Fix unnecessary typecasting on bytes.Buffer
Improved the check for empty string
Replace nested if block with else-if

If you don't want to use DeepSource, I can edit the PR to remove the .deepsource.toml file.
Thanks a lot for this amazing project. 🙂

Plus one on this!

Hey @mardukbp 👋 Just following up, it will be great if you can take a look once. 🙂
Thanks and a Happy New Year 🙂

Hey @mardukbp 👋 Just following up, it will be great if you can take a look once. 🙂
Thanks and a Happy New Year 🙂

Happy New Year to you too @siddhant-deepsource! I am not an admin of this repo. I am sure that code quality improvementes are welcome, but I am afraid they are not top priority. I recommend patience :) Thank you for your contributions!

Happy New Year to you too @siddhant-deepsource! I am not an admin of this repo. I am sure that code quality improvementes are welcome, but I am afraid they are not top priority. I recommend patience :) Thank you for your contributions!

Thanks @mardukbp 🙂 In that case @zyedidia can you please review this once. Thanks 🙂

Thanks @mardukbp 🙂 In that case @zyedidia can you please review this once. Thanks 🙂

Ok it looks good. It doesn't seem like the .deepsource.toml file is necessary though -- could you remove that? Thanks!

Ok it looks good. It doesn't seem like the .deepsource.toml file is necessary though -- could you remove that? Thanks!

@zyedidia Have removed .deepsource.toml file. Please take a look. Thanks.

@zyedidia Have removed .deepsource.toml file. Please take a look. Thanks.

🥳🥳🥳

🥳🥳🥳


Mixup not mixing samples?

Mixup does not seem to be mixing up the input samples to a classification, only the targets, as seen by this code, which returns the input samples with no modifications.
...
    def __call__(self, x, target):
        assert len(x) % 2 == 0, 'Batch size should be even when using this'
        if self.mode == 'elem':
            lam = self._mix_elem(x)
        elif self.mode == 'pair':
            lam = self._mix_pair(x)
        else:
            lam = self._mix_batch(x)
        target = mixup_target(target, self.num_classes, lam, self.label_smoothing, x.device)
        return x, target

Is this expected behavior? I was under the impression that the purpose of mixup is to interpolate between both samples and targets.

@bhoov 'x' is modified in place by the _mix_* functions


Time.Format() should fail when the layout string is unexpected

What version of Go are you using (go version)?

$ go version
go1.13

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOHOSTOS="linux"

What did you do?
On 2019-10-18, run time.Now().Format("2006-01-01") (instead of the correct magic string "2006-01-02")
What did you expect to see?

Go magically understands the format and returns the correct time with this format.
or
It complains the given format string is unexpected, either during compiling or at run time.

What did you see instead?
It returns a wrong time "2019-10-10".

Is not "magical".
When you write time.Now().Format("2006-01-01")  you are printing the month twice, so the format and output is correct.

Sorry, but this is working as designed & documented.
We're not going to add magic (it's not clear what magic would work), and we can't make it return an error on duplicate layout rules, as that would likely break other people's (correct, if odd) programs.
Maybe there could be a vet or lint check for bizarre and likely incorrect format strings, though.
I wouldn't be surprised if @dominikh has already written such a thing.

Actually I haven't. I would have the same issue on my end, trying to discern weird formats from incorrect formats.
Maybe one day editors will become powerful enough to show example formatted times in tooltips.

Thanks all! In the meantime, it's probably worth to explicitly warn in the doc https://golang.org/pkg/time/#Time.Format that the reference time must be "Mon Jan 2 15:04:05 -0700 MST 2006". Using a different time can lead to undefined behavior, not necessarily an error. Further explaining "01" = month, "02" = date will make things much more clear.

It already says that at the URL you just linked to.

I wish the consequence of using an arbitrary date is explicitly documented. When I read the doc, I thought using an arbitrary date will either work or give an error. So I tried and thought it worked, as there was no error. The fact that "Mon Jan 2 15:04:05 -0700 MST 2006" itself looks arbitrary and is not explained also encourages the attempt.
I'm probably biased by my experience (which is largely due to my fault), but unintentionally returning wrong timestamp can be dangerous. I wish people are warned about it even if they just skim through the doc.

Do you have a specific suggestion for how the docs should be improved?  It seems hard to fix the docs to work for people who just skim them.  Thanks.

It would be very helpful if the reference time is explained and the fact that "01" = month and "02"= date is explicitly mentioned.
People can make different guesses of the underlying mechanism by reading "Format returns a textual representation of the time value formatted according to layout, which defines the format by showing how the reference time, defined to be Mon Jan 2 15:04:05 -0700 MST 2006 would be displayed if it were the value"
A very reasonable understanding is that the time should be "Mon Jan 2 15:04:05 -0700 MST 2006", so "2006-01-02 01:04:05 AMT" when expressing in AMT. But we get "2019-10-20 10:04:05 AMT" with the following code:
t, err := time.Parse("2006-01-02 15:04:05 MST", "2019-10-20 20:04:05 AMT")
if err != nil { return err }
fmt.Printf("%s", t.Format("2006-01-02 01:04:05 AMT"))
It's obvious once we know "01" = month and "02" = date. But otherwise it's surprising. I'm still worried that I can make this mistake without being warned. But making the doc very clear can help.

@dominikh I'd think a rough heuristic for time formats to be that they shouldn't contain repeats of the same segment (01 etc). That'd be technically more lint than vet, unfortunately, because of joke code like
rebeccaBlack := time.Now().Format("It's Monday, Monday\nGotta get down on Monday")

But I really can't think of a non-joke example. Might be worth running through the corpus and just enabling it as a vet if nothing matches -- jokes can always add overrides or ignore vet results.


feat(ci): add prettier

i should use a develop branch first. prettier is already installed. for now i use it only in local but that could be great if i can use it in ci.

i don't like how prettier format few lines of code so i think i don't use it in ci but only in cli with vscode. but i prefer to use stylint with ci

ok so now i use prettier in vscode with npm, stylint too that the most convenient for me.


would you please release the version based on vc 2015?

Sorry for the delay. The latest release is build on vc2015 (v14).


Send Email when user is assigned a task

When someone is assigned to an issue we'd like an email to be sent to them to let them know.
Last I checked this was not implemented, would be good to have this setup with a corresponding unit test.

https://github.com/go-gitea/gitea/pull/8546


Typo in changelog entry for release 1.3.1

It appears there is a typo in the changelog entry for release 1.3.1:
https://github.com/LennartHennigs/SimpleFSM/blob/f06574716daf6b1fedc2d18c8fe35c7b630fd64f/CHANGELOG.md?plain=1#L9
The day of the date is wrong... but the year should also be 2024?
So this probably should be changed to:
## 1.3.1 - 2024-10-27

As that is the Blame date.

Thx for pointing it out. Changed it.


zoom-us: init at 2.0.91373.0502

Actually, reintroduce after removal (https://github.com/NixOS/nixpkgs/commit/bb99babc5a1c62edd012da5a1ad14cd3fe1abf0a)
and use bundled Qt.
Stepping up as a maintainer
Still, some bugs present (like crash when log-in using Facebook, clear ~/.zoom to recover, bug reported upstream) and I didn't test video (no cam).
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@danbst I just tried this, it's working for me.
I recommend renaming the executable to zoom-us because there already exists another package called zoom exposing an executable called zoom. Moreover, zoom-us was what the executable was called until zoom-us package was removed some weeks ago.
Also, I recommend against just copying all of the top-level contents of the zoom sources to $out/share, since there's a lot of noisy garbage there. Could you create a folder $out/share/zoom instead and put all of the files in there?

:confetti_ball:

Sign in with Google does nothing for me.
Sign in with SSO ends up with error:
Qt WebEngine resources not found at /home/levi/Qt5.6.2/5.6/gcc_64/resources. Trying parent directory...
Qt WebEngine resources not found at /home/levi/Qt5.6.2/5.6/gcc_64. Trying application directory...
[0607/214354:FATAL:udev_loader.cc(36)] Check failed: false.

@kamilchm same for me. :( Let's wait what upstream says about hardcode /home/levi/Qt5.6.2/...

👍  Thanks for this, I was 2 hours in to trying to get Zoom running in an Ubuntu VM (crying as my underpowered laptop started compiling VirtualBox in order to use the extension pack for webcam support) before I stumbled upon this, saves me a lot of trouble. nox zoom didn't show me anything, not sure why...


Broken CPE ID when supplier contains a digit

Same issue than #14, iperf3_project:iperf3 will be wrongly be translated into iperf_project:iperf3 resulting in a wrong CPE ID (and wrong purl). Code can easily be updated to add 0-9  in the regex but again it would probably be better to just remove the whole code?

Same issue with nghttp2:nghttp2 which is translated into nghttp:nghttp2


[Security] Workflow ci.yml is using vulnerable action pre-commit/action

The workflow ci.yml is referencing action pre-commit/action using references v2.0.3. However this reference is missing the commit 80db042ff08cdddbbbfb6f89c06a6bfc4dddf0b7 which may contain fix to the some vulnerability.
The vulnerability fix that is missing by actions version could be related to:
(1) CVE fix
(2) upgrade of vulnerable dependency
(3) fix to secret leak and others.
Please consider to update the reference to the action.

Fixed in #134


Password reset services

This completes the majority of the backend services for password resetting. Next, I'll have a PR including tests for these functions, and later, another PR completing the routing/frontend portion.

LGTM!

LGTM!


Update front page description

Current text:
Flux is a set of continuous and progressive delivery solutions for Kubernetes, and they are open and extensible.
The latest version of Flux brings many new features and made Flux more flexible and versatile.
Flux is a CNCF Incubating project.
Suggest changing to:
Flux is a set of continuous and progressive delivery solutions for Kubernetes, and they are open and extensible.
The latest version of Flux brings many new features and makes Flux more flexible and versatile.
Flux is a CNCF Incubating project.

https://github.com/fluxcd/website/pull/541
The line
  Flux is a set of continuous and progressive delivery solutions for Kubernetes that are open and extensible.

could be simplified down to
  Flux is a continuous and progressive delivery solution for Kubernetes that is open and extensible.

Closing this for now as merged PR


Mxnet.io doc problem

On this page, the API dropdown in headline doesn't work
http://mxnet.io/tutorials/python/mnist.html#

Unfinished content in http://mxnet.io/api/python/io.html#extension-multiple-labels-for-a-single-image

Is the (source of) doc also available on the git repo to edit? If yes, would love to get the link :D

This issue is closed due to lack of activity in the last 90 days. Feel free to reopen if this is still an active issue. Thanks!


27 develop systemverilog crc 8 decoder module

I verified that decoder module works with test bench. Result should be 0 if no errors detected. Comment out the encoder test bench to allow the simulation to run with the decoder test bench.

In this commit, I also deleted our old project and made a new one without the deprecated files. Also added some good gitignore logic to avoid committing unintended, burdensome files.


Bump version to 0.1.5

Why are these changes needed?
Bump version to 0.1.5
Related issue number

Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Codecov Report

Merging #60 (dd66325) into main (4adbffa) will decrease coverage by 0.36%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   39.08%   38.73%   -0.36%
==========================================
  Files          17       17
  Lines        1998     1998
  Branches      439      439
==========================================
- Hits          781      774       -7
- Misses       1148     1154       +6
- Partials       69       70       +1

Flag
Coverage Δ

unittests
38.73% <100.00%> (-0.26%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

autogen/version.py
100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


The TOC links dont work

Clicking on 1. Installation doesn't work because of the emoji.

Thanks for reporting this. Easy fix to get rid of the emoji

I've been discovered that any head link are working because emojis, probably some update from GitHub side made this bug. I will fix it.

Hey @weyderfs. Happy 2024. Thanks for handling the issue about the offline versions.
Thought I'd get this one off our plate if you have a moment for an easy, low risk review

Hi @iokiwi. Happy 2024 for you. I've been open this Pull Request, with necessary fixes at README.md and made some improvements at Headings.


[docs] Added branch management scheme

Introduced beta branch to track the weekly beta version release.
Also updated the branching management rules.
Next will try to automate the beta release process.

@Hanks10100 @cxfeng1 PTAL, thanks


No alias recipient with address extension possible

It is not possible to add to an alias a recipient with address extension like<EMAIL_ADDRESS>The error message says "Local recipient<EMAIL_ADDRESS>not found".

What version of Modoboa are you using ?

1.2.0

Ok, this problem has already been fixed. You can :

Use the 1.2.x branch
Upgrade to 1.3.3

The first option is quicker to setup.

Well, how could I upgrade to 1.2.x branch if I installed modoboa via pip?

I think I'll release a minor version (1.2.2), it will be easier.

:) thanks @tonioo

The release is available:
pip install modoboa==1.2.2


:api is not indexed, and should be better documented

The problem
Documentation about :api is here and there and even there.
It's not referenced in the description of the type system, for instance, despite being there alongside ver and auth
Suggestions
Give it the same standing as ver and auth, including indexing.

Closed in 4c49cea5a4fcffc94e0ab3b897ab8102490a7f0f