Extended the embedded pbix

Hi,
How do I go about downloading (and then extending) the personnel management Power BI report? I have followed the process we use in finance & operations (via the Asset Library in LCS) but cannot see any Power BI packages to download.
I know I could connect PBI desktop upto the CDS entities but as the data model and pbix already exist in the OOB workspace this seems a nonsensical approach that would mean huge a duplication of effort top replicate the standard report before beginning extension work.
Also - once extensions are made I assume i can replace the existing analytics tab within the personnel management workspace in the same way we can within F&O?
Any advice would be great
Thanks,
Dave

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 02a41087-2a11-d94a-6630-81e74a9ef256
Version Independent ID: 6b869ada-9961-870f-4703-9adcdafdaed3
Content: Reporting options - Human Resources | Dynamics 365
Content Source: articles/human-resources/hr-admin-troubleshooting-reporting.md
Service: dynamics-365-human-resources
Product: ****
Technology: ****
GitHub Login: @andreabichsel
Microsoft Alias: anbichse

@davecope1982, thanks for posting this feedback!
@andreabichsel, please review and update the content, as needed.

Bug 480527 has been logged to track this issue.

any update on this?

Per our product team, these reports are locked down in Human Resources.


What about RTL?

Version:

"react": "18.2.0"
"expo": "~51.0.21"
"react-native": "0.74.3"

Issue:
The issue is, according to some languages such as Persian, Arabic, etc., I need a RTL version of the component. For example, caret and close icons should be aligned at left and the filled text at right.
Does the component support this and I'm wrong?

the same issue with me.

I think if you just pass the textInputProps correctly it falls back to the RN TextInput behaviour which supports RTL languages.
@AliBahaari @datvu1907


How to find centroid of polygon before or during creation?

I have my own rendering function/system and special objects for rendering with Matter body and pixi Display object with all rendering propeties.
First I draw any shape and later function create matter body fromVertices and display object from the same path and this works in general but shape is moved a little relative to matter body.
Something like this (blue one is display object):

I seen that center point (orange one) is generated by Body constructor during creation but I am not able to find it after decomposition.
First I used the middle point but it was wrong, later I studied the code and found that center is found from convex hull of main body so I made convex hull and found centroid aka this:
        Matter.Vertices.clockwiseSort(vertices);
        var hull = Matter.Vertices.hull(vertices);
        return Matter.Vertices.centre(hull);

but that also failed for some reason and now i see that this point is calculated from all parts with next function and also this point is different if body is static (if mass is inifity) and if it is normal body.
I spent lot of time on this and I feel a little confused now how should I do this..
Simply speaking I finding center point of my polygon before creation (after drawing) and all vertices are this point oriented but matter finding different point (second picture) and everything is moved when rendering.

How can I know where is that point before I start whole simulation, just from vertices I have drawn?
Any help would be nice.

I am not sure is that best idea but for now I copied fromVertices function and modified it to get only parts and calculate centroid based on generated parts using code from _totalProperties function.
So this function make temporary matter body and it returns the point difference and later I can move display object.
Is there any better way for this ?


bug: Ionic 4 / React history.push() is not changing pages

Bug Report
Ionic version:
[x] 4.11.x
Current behavior:
history.push does not change pages.
I believe <IonRouterOutlet> is not working, because the kitchen sink React Ionic demo works with previous versions of Ionic, but upgrading to the latest version breaks it.
Expected behavior:
history.push changes pages.
Steps to reproduce:
Please see:
https://github.com/benallfree/ionic-react-conference-app/tree/history-push-working
https://github.com/benallfree/ionic-react-conference-app/tree/history-push-bug-broken
Related code:
`<IonButton onClick={() => history.push('/somePage')}>Go</IonButton>` does not change pages.

Other information:
Related  issues: https://github.com/ionic-team/ionic/issues/19246  and https://github.com/ionic-team/ionic/issues/18804
Ionic info:
Ionic:

   Ionic CLI       : 5.4.2 (/Users/uncovered/.nvm/versions/node/v10.15.0/lib/node_modules/ionic)
   Ionic Framework : @ionic/react 4.11.0

Cordova:

   Cordova CLI       : 9.0.0<EMAIL_ADDRESS>   Cordova Platforms : not available
   Cordova Plugins   : not available

Utility:

   cordova-res : 0.6.0 (update available: 0.8.0)
   native-run  : not installed

System:

   ios-deploy : 1.9.4
   NodeJS     : v10.15.0 (/Users/uncovered/.nvm/versions/node/v10.15.0/bin/node)
   npm        : 6.7.0
   OS         : macOS Catalina
   Xcode      : Xcode 11.1 Build version 11A1027

Hi @benallfree,
Thanks for the issue. There was a change in one of the later RCs that requires each "page" to have IonPage be the root of the component (https://github.com/ionic-team/ionic/blob/master/packages/react/CHANGELOG.md#breaking-changes-1).
So if you add IonPage to the master and detail components like so:
const Master: React.FC<RouteComponentProps> = ({ history }) => {
  return (
    <IonPage>
      <IonContent>
        <IonButton onClick={() => history.push(`/detail`)}>Detail</IonButton>
      </IonContent>
    </IonPage>
  );
};

const Detail: React.FC<RouteComponentProps> = ({ history }) => {
  return (
    <IonPage>
      <IonContent className="ion-padding">
        <IonButton onClick={() => history.goBack()}>Back to Master</IonButton>
      </IonContent>
    </IonPage>
  );
};

The conference app starter is fairly out of date and we are working on updating it now.
The transitions will begin to work. Also, fyi, there is a prop on Buttons called routerLink that you can pass the url to have it do the transitions.

Fantastic. For anyone else who comes here, this snippet works on 4.11.x:

const Master: React.FC<RouteComponentProps> = ({ history }) => {
  return (
    <IonPage>
      <IonContent>
        <IonButton routerLink="/detail">Detail</IonButton>
      </IonContent>
    </IonPage>
  );
};

const Detail: React.FC<RouteComponentProps> = ({ history }) => {
  return (
    <IonPage>
      <IonContent className="ion-padding">
        <IonButton routerLink="/">Back to Master</IonButton>
      </IonContent>
    </IonPage>
  );
};

const App = () => (
  <IonApp>
    <IonReactRouter>
      <IonRouterOutlet>
        <Route path="/" component={Master} exact />
        <Route path="/detail" component={Detail} exact />
      </IonRouterOutlet>
    </IonReactRouter>
  </IonApp>
);


Created debounce & throttle effects

I needed a debounce effect so I created one.

Thanks for the PR. Have you taken a look at my proposal #2 for throttle? It seems very similar, except that inmediate (should be immediate btw) is always true. Do you have use cases where you always want the first time an action is called to be delayed? I would prefer delay over wait if we're going with debounce, but my real preference would be more of an action rate limiter/throttle with a prop of rate.

You're welcome. I had a look at #2 after I after I created this PR. I've prepared a throttle implementation, but I've not prepared the test yet.
throttleand debounce seem very similar, but the behaviour is subtly different. I've always liked this demo to visualise the difference.
Use case: listening for typing in a search ahead box. I don't want the search to start immediately, I want to start the search when the user has finished typing.

@rmc thanks for the reference, I believe that confirms my beliefs WRT throttle vs debounce.
I hear folks mentioning the search box as a use case for debounce, but personally that user experience bugs me since you won't see the results update while you're typing. The ideal experience IMHO would be to trigger a search after each space immediately (more likely to match when you have a phrase with complete words) and throttle searches while the user is typing other characters so they don't overload your API.
Should we have both throttle and debounce effects? Or is there a way to write one effect that can do the work of both?

@okwolf I liked your suggestion for searching and was able to implement it with fxIf really easily (naive version):
    startSimpleSearch: event => fxIf([
      [/[^\s]$/.test(event.target.value), debounce(500, 'search')],  // last char is not whitespace
      [/\s$/.test(event.target.value), action('search')], // last char is whitespace
      [/^(?![\s\S])/.test(event.target.value), action('noop')] // had to add this for reasons I'll explain later
    ]

I'd go for adding both throttle and debounce. That way you could choose which you prefer according to your sensibilities/requirements. Writing one function to handle both cases would be complicated. Specifying the effect you would like to use explicitly makes more sense to me.
As for the last line in my example: I was implementing your search experience, and noticed that whenever all the conditions in fxIf evaluated to false, fxIf returns an empty array and the following error appears:

So I implemented a noop action, now whenever event.target.value is "" the error doesn't appear anymore. TBH I think I might be abusing fxIf. Am I right in thinking it always requires one condition to evaluate to true? I might be looking for and fxMaybe; execute all effects for which the condition evaluates to true? (This is a whole different issue though)

@rmc thanks for trying out my crazy harebrained scheme!
I'm OK with adding both throttle and debounce since neither should be very large functions. How attached are you to having the immediate prop on debounce are you? I would think this feature wouldn't be used most of the time, so I'm thinking we should leave it out until someone really needs it. I'm also not a big fan of boolean arguments in general, so if we do find that we need such a thing, we might want to migrate to passing objects directly for the props to make it more like named arguments, but that's a different discussion...
I believe you are using fxIf correctly, but the code for running fx has a bug where it should treat empty arrays as a no-op effect instead of trying to run them. Like you said, that should be a different PR though.

Not really attached to immediate, removing it should simplify debouncea bit.
Should I attach the throttle effect to this PR as well?
Good to know I wasn't abusing fxIf too much ;-).

@rmc Not really attached to immediate, removing it should simplify debouncea bit.

👍

@rmc Should I attach the throttle effect to this PR as well?

Your call, I'd like to get both in before making a new release either way. Also the bug fix for #28.

@rmc thanks for the simplification!
I think we just need docs and this effect will be 💯.

Docs are ready to go. Please have a look at them to make sure they're clear enough.


0 hits for tags beginning with Capital Letter

Please follow the guide below

Issues submitted without this template format will be ignored.
Please read the questions carefully and answer completely.
Do not post screenshots of error messages or code.
Put an x into all the boxes [ ] relevant to your issue (==> [x] NO spaces).
Use the Preview tab to see how your issue will actually look like.
Issues about reverse engineering is out of scope and will be closed without response.
Any mention of spam-like actions or spam-related tools/libs/etc is strictly not allowed.

Before submitting an issue, make sure you have:

[x] Updated to the lastest version v1.5.7
[x] Read the README and docs
[x] Searched the bugtracker for similar issues including closed ones
[x] Reviewed the sample code in tests and examples

Which client are you using?

[ ] app (instagram_private_api/)
[x] web (instagram_web_api/)

Describe the Bug/Error:
Please make sure the description is worded well enough to be understood with as much context and examples as possible.
Code to replicate the error must be provided below.

Paste the output of python -V here:
Code:
web_api = Client(auto_patch=True, drop_incompat_keys=False)
tag_feed_info = web_api.tag_feed(tag_name)
numberOfHits= tag_feed_info['data']['hashtag']['edge_hashtag_to_media']['count']
print(numberOfHits)
Error/Debug Log:
If tag_name begins with capital letter, the number of hits is always 0

This is Instagram's limitations. You can simply do a tag_name.lower().


box-sizing: border-box; missing from Timeline header

Hi because we no longer include
@defencedigital/css-framework which has a global style of
* {
    box-sizing: border-box;
 }

When using the DS in isolation this cause the dates to misalign.
https://codesandbox.io/s/timeline-box-sizing-demo-r86xep

This can be fixed by wrapping the root of the application with the supplied GlobalStyleProvider.
This information appears to have been omitted from the upgrade guide.
I have created a ticket to rectify this.


ExtractAssociatedIcon (Lost connection to device)

I am not quite sure how to use this function. I am trying to get the associated icon for a file on the files system. I have tried implementing the code from the tests which show that it is a function but I don't know how to actually use it to get an icon. With what I have now, the debugger quits with an error of Lost connection to device.
I'm sure that I'm making a mistake in this code but what am I doing wrong? How do I create the hInst, Pointer<Utf16> and Pointer<Uint16> objects to pass to ExtractAssociatedIcon? If you could just point me in the right direction.
  final shell32 = DynamicLibrary.open('shell32.dll');

  Pointer<Uint16> pointerUint16 = Pointer.fromAddress(0);

  ExtractAssociatedIcon(GetModuleHandle(nullptr),
      'c:\\AVScanner.ini'.toNativeUtf16(), pointerUint16);

Also, the microsoft documentation for ExtractAssociatedIconW says When it is no longer needed, the caller is responsible for freeing the icon handle returned by ExtractAssociatedIcon by calling the [DestroyIcon] function. Is that something that we would need to do somewhere so that we don't get memory leaks?

I am not quite sure how to use this function. I am trying to get the associated icon for a file on the files system. I have tried implementing the code from the tests which show that it is a function but I don't know how to actually use it to get an icon. With what I have now, the debugger quits with an error of Lost connection to device.

I can't help you with this as I don't know how to use this function.

I'm sure that I'm making a mistake in this code but what am I doing wrong? How do I create the hInst, Pointer<Utf16> and Pointer<Uint16> objects to pass to ExtractAssociatedIcon? If you could just point me in the right direction.

You are assigning nullptr to the pointerUint16 variable. In order to allocate memory, you need to use calloc from package:ffi:
import 'dart:ffi';

import 'package:ffi/ffi.dart';
import 'package:win32/win32.dart';

void main() {
  final pointerUint16 = calloc<Uint16>();
  final iconHandle = ExtractAssociatedIcon(GetModuleHandle(nullptr),
      'c:\\AVScanner.ini'.toNativeUtf16(), pointerUint16);
}

Also, the microsoft documentation for ExtractAssociatedIconW says When it is no longer needed, the caller is responsible for freeing the icon handle returned by ExtractAssociatedIcon by calling the [DestroyIcon] function. Is that something that we would need to do somewhere so that we don't get memory leaks?

Yes, you need to call DestroyIcon with the icon handle returned from the ExtractAssociatedIcon function once you are done using it.

Ah, thanks a lot. I'm in over my head with shell32 stuff. I have done this in C# many years ago but how does the icon handle translate into an image that can be displayed in flutter? Is the iconHandle an image? I get these values from the objects but I'm not sure how to create an image in flutter from these. Is that what this function does?

Ah, thanks a lot. I'm in over my head with shell32 stuff. I have done this in C# many years ago but how does the icon handle translate into an image that can be displayed in flutter? Is the iconHandle an image? I get these values from the objects but I'm not sure how to create an image in flutter from these. Is that what this function does?

You have to do a lot more to display an image in Flutter than the icon handle returned from the ExtractAssociatedIcon function.
I managed to create an example for this:
import 'dart:ffi';
import 'dart:typed_data';

import 'package:ffi/ffi.dart';
import 'package:flutter/material.dart';
import 'package:win32/win32.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: MainPage(),
    );
  }
}

class MainPage extends StatefulWidget {
  const MainPage({super.key});

  @override
  MainPageState createState() => MainPageState();
}

class MainPageState extends State<MainPage> {
  Uint8List? bytes;

  /// Extracts the icon from the given [path] and returns the bytes of the
  /// created BMP.
  ///
  /// To display the image, use the [Image.memory] widget:
  /// ```dart
  /// Image.network(getEncodedImageBytes(r'c:\windows\regedit.exe')!);
  /// ```
  Uint8List? getEncodedImageBytes(String path) {
    final hInstance = GetModuleHandle(nullptr);
    final pLocation = path.toNativeUtf16();
    final piIcon = calloc<Uint16>();
    final hIcon = ExtractAssociatedIcon(hInstance, pLocation, piIcon);
    if (hIcon == NULL) {
      print('ExtractAssociatedIcon failed.');
      return null;
    }

    final pIconInfo = calloc<ICONINFO>();
    if (GetIconInfo(hIcon, pIconInfo) == FALSE) {
      print('GetIconInfo failed.');
      return null;
    }

    final bmp = calloc<BITMAP>();
    if (GetObject(pIconInfo.ref.hbmColor, sizeOf<BITMAP>(), bmp) == NULL) {
      print('GetObject failed.');
      return null;
    }

    final bitmapFileHeader = calloc<BITMAPFILEHEADER>();
    final bitmapInfoHeader = calloc<BITMAPINFOHEADER>()
      ..ref.biSize = sizeOf<BITMAPINFOHEADER>()
      ..ref.biWidth = bmp.ref.bmWidth
      ..ref.biHeight = bmp.ref.bmHeight
      ..ref.biPlanes = 1
      ..ref.biBitCount = 32
      ..ref.biCompression = BI_RGB;

    final dwBmpSize =
        ((bmp.ref.bmWidth * bitmapInfoHeader.ref.biBitCount + 31) /
                32 *
                4 *
                bmp.ref.bmHeight)
            .toInt();

    final hdc = GetDC(NULL);
    final lpBitmap = calloc<Uint8>(dwBmpSize);
    GetDIBits(hdc, pIconInfo.ref.hbmColor, 0, bmp.ref.bmHeight, lpBitmap,
        bitmapInfoHeader.cast(), DIB_RGB_COLORS);

    final dwSizeOfDIB =
        dwBmpSize + sizeOf<BITMAPFILEHEADER>() + sizeOf<BITMAPINFOHEADER>();
    bitmapFileHeader.ref.bfOffBits =
        sizeOf<BITMAPFILEHEADER>() + sizeOf<BITMAPINFOHEADER>();

    bitmapFileHeader.ref.bfSize = dwSizeOfDIB;
    bitmapFileHeader.ref.bfType = 0x4D42; // BM

    final bytes = (BytesBuilder()
          ..add(Pointer<Uint8>.fromAddress(bitmapFileHeader.address)
              .asTypedList(sizeOf<BITMAPFILEHEADER>()))
          ..add(Pointer<Uint8>.fromAddress(bitmapInfoHeader.address)
              .asTypedList(sizeOf<BITMAPINFOHEADER>()))
          ..add(lpBitmap.asTypedList(dwBmpSize)))
        .toBytes();

    DeleteObject(pIconInfo.ref.hbmColor);
    DeleteObject(pIconInfo.ref.hbmMask);
    DestroyIcon(hIcon);
    ReleaseDC(NULL, hdc);

    free(pIconInfo);
    free(bmp);
    free(pLocation);
    free(piIcon);
    free(bitmapFileHeader);
    free(bitmapInfoHeader);
    free(lpBitmap);

    return bytes;
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: bytes == null ? const SizedBox() : Image.memory(bytes!),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: () {
          setState(() {
            bytes = getEncodedImageBytes(r'c:\windows\regedit.exe');
          });
        },
        mini: true,
        child: const Icon(Icons.add),
      ),
    );
  }
}

Preview:

It looks like you'll be able to achieve this with the WinRT APIs, but we still have some work to do before you can use these APIs.

Thanks a lot for the information. I might try the non-transparent for now as a placeholder. I'm wondering if I could just scrape a lot of icons in a language I'm familiar with and then create a repo as a half-measure in the meantime. I could probably do that faster than learning win32 c++ :)
Anyway, this was extremely helpful and thanks for your time.

hi @hootyjeremy , you can try https://github.com/Far-Se/win32audio to extract icons, it's on Extra functions at the end of the page.

I will check it out. Thanks a lot. @Far-Se


How to remove empty columns.

Hi XLSX team,
Can you guys please let me know how can I remove an empty column from excel file.
Thanks & Regards,
N.Murali Krishna.

https://github.com/SheetJS/sheetjs/issues/413#issuecomment-456979011


[Updated] Separate OMs

Called out that they should always seperate

Thanks, @ryanjjones10

@ryanjjones10 Would you like us to pull this change into the PKS v1.1 docs as well?

Yes please @bentarnoff


match page fixes

[ ] "Building map" should be capitalized
[ ] slightly smaller inflictorwithvalue
[ ] teamfights inflictorwithvalue shows index instead of number of uses

Hey! I am new to this project, but want to work on this. Is that okay?

Sure.  All of the above should be fairly simple fixes.  Join our Discord (linked on README) if you'd like some real-time support

@howardchung Okay.

teamfights inflictorwithvalue shows index instead of number of uses

fixed in https://github.com/odota/ui/pull/319/commits/251af872e8ef9d880e3aac985048c32c67bd5bc2


Version 2.0

Codecov Report

Merging #24 (bf00521) into master (341f6e5) will not change coverage.
The diff coverage is 60.00%.

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   88.96%   88.96%
=======================================
  Files           5        5
  Lines         616      616
=======================================
  Hits          548      548
  Misses         68       68

Impacted Files
Coverage Δ

src/bin/urlsup.rs
0.00% <0.00%> (ø)

src/validator.rs
99.33% <ø> (ø)

src/lib.rs
94.17% <75.00%> (ø)

tests/cli.rs
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 341f6e5...bf00521. Read the comment docs.


[Request] Use RFC 5646 for README and folders name.

I think the standardized nomenclature for languages is not accurate in the README.
The column table "ISO 639-1" is not exactly the wikipedia description of "two-letter codes"

And this section says that you intend to use RFC 5646 but is different from this list

Request: Use RFC 5646 for README and folders name.

@switchhalt
"Language code different from standardized nomenclature."

@ByMykel  Thanks for bringing this up and taking some time to think about it.

And this section says that you intend to use RFC 5646 but is different from this list

actually that section says  RFC 5646 is a super set of ISO 639‑2, and how RFC works in its letter combination.
in the document linked there you can read more about it.

Also, more importantly , around that screenshot is these two standards which is why we use those RFC standards.

We want to adhere to the Standards for Content-Language and Accept-Language going forward.

The column table "ISO 639-1" is not exactly the wikipedia description of "two-letter codes"
very correct, we should fix that :+1: thank you for pointing this out.

@BeauBouchard  :P its pretty all over the place with the contributions as we started with "2" letters and built on top of that, later adopting the standard of RFC5646; even in the screenshot of the readme tl-fil is reversed format of the filename.
the RFC5646 that is used in most communication for the content-language for eng-us for us is typically en-US like the above screenshot.
@ByMykel  Thank you for pointing this out, it allows us to openly discuss this issue, and address a solution.
we want to be backwards compatible so this change will need to accommodate the previous combinations but i agree, we should adhere to whatever the RFC5646 standard is using which also makes it easier for us all to keep from making errors.
I think we should just rename the files to use "RFC5646" from a list, and include the filenames as "RFC5646" objects in the models, should be pretty easy.


Add necessary fields for performance tuning

As a user and operator I expect that KubeVirt allows me to tune my VMs in order to meet the performance of other KVM based hypervisors.

Requirements:

[ ] Update requirements based on references below

References

https://www.ovirt.org/develop/release-management/features/virt/high-performance-vm/
https://www.ovirt.org/blog/2017/10/introducing-high-performance-vms/
https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.2/html-single/virtual_machine_management_guide/#Configuring_High_Performance_Virtual_Machines_Templates_and_Pools (paywalled)

I created the list of things that we need to enable or disable:

Enable L3 cache - what downsides this feature has, why does not enable it by default
The best performance increasement will have a VM that uses cores from the same socket
Enable Headless Mode - we need to disable graphical and video devices
Disable USB devices
Disable Smart Card device - IIRC we do not have this device so nothing need to do from our side.
Enable Virtio serial console
Enable CPU passthrough
Disable memory balloon device
Enable usage of IO threads - what downsides this feature has, why does not set it by default to 1.
CPU pinning and NUMA pinning - currently not supported by us, but I hope in the near future we will have CPU pinning
some additional work on a disk device - set cache to none, set io to threads
enable virtio-rng device - we have the separate issue for it
disable watchdog device

For the most part of things that I specified above we do not have API on the frontend side, so we can not specify it under VM preset.
@fabiand @rmohr @michalskrivanek Do we want to introduce API for each small feature or maybe do we want to introduce something similar to Ovirt VM profile to set only relevant profile and under the hood we will set all small features for the VM?

@cynepco3hahue I'm volunteering to help implementing this feature if you want

my 2c about the implementation: IMHumbleO all of the above should be hidden behind a single tunable setting (AFAIK kubevirt already has ways to do most of the relevant settings) like the ovirt vm profiles, to be later moved in the virtuned/libvirt-profiles.

Enable Headless Mode - we need to disable graphical and video devices

We can add a autoattachGraphicsDevice boolean field. Maybe starting with an annotation to gather feedback. That might be something more users care about, to save ram without going for full performance.

Disable USB devices
Disable Smart Card device - IIRC we do not have this device so nothing need to do from our side.
Enable Virtio serial console
Enable CPU passthrough
Disable memory balloon device

Do we have that by default? We don't have ballooning right now. I would make sure it is not added by default at this moment.

Enable usage of IO threads - what downsides this feature has, why does not set it by default to 1.
CPU pinning and NUMA pinning - currently not supported by us, but I hope in the near future we will have CPU pinning
some additional work on a disk device - set cache to none, set io to threads

I guess that we want to expose the cache directly? Afaik it depends on a huge amount of factors from your host if "none" is the fastest?

enable virtio-rng device - we have the separate issue for it

Yes, we can definitely do that always as far as I remember.

disable watchdog device

Not there by default, so not an issue.

Disable USB devices

We could do that right now and thinking about adding them the right way once we support attaching stuff to them.

Disable Smart Card device - IIRC we do not have this device so nothing need to do from our side.
Enable Virtio serial console

Hm, that depends on the fact if the guest supports virtio or not. Is that even important? Does having a compatible console attached slowing down the vm already?

Enable CPU passthrough

Here I still wonder if host-model makes any sense at all and if we should not just use passthrough. According to e.g. https://wiki.openstack.org/wiki/LibvirtXMLCPUModel, it does neither guarantee a sane cpu configuration, nor migratability.

@fromanirh Hi, and thanks for the proposal. IMHO I do not have much to do here, because

@stu-gott works on IO threads
@vladikr works on CPU pinning
@petrkotas works on virtio-rng

So here we just need to decide what approach we prefer, to use profiles or create separate API fields for every needed feature(it more customizable than profile). Ovirt has profiles, but still, you have the API for each separate feature(except L3 cache IIRC). Also, we need to decide if we want to enable part of the features for the regular VM's as well:

L3 cache
IO threads 1

@cynepco3hahue ack

We can add autoattachGraphicsDevice boolean field. Maybe starting with an annotation to gather feedback. That might be something more users care about, to save ram without going for full performance.

Do you mean to use annotation instead of API field?

Do we have that by default? We don't have ballooning right now. I would make sure it is not added by default at this moment.

Yes we have it by default, I think if you do not specify model to be none, libvirt set it by default to virtio
<memballoon model='virtio'>
      <alias name='balloon0'/>
      <address type='pci' domain='0x0000' bus='0x04' slot='0x00' function='0x0'/>
    </memballoon>

I guess that we want to expose the cache directly? Afaik it depends on a huge amount of factors from your host if "none" is the fastest?

I checked Ovirt disk parameters(none means that it does not caching on the host), so it possible that it does not suite good for all cases, @aglitke maybe do you know which option is best from performance perspective, will <driver name="qemu" type="raw" io="threads" cache="none"/> suite well for most cases?

Not there by default, so not an issue.

Good for us :smile:

We could do that right now and thinking about adding them the right way once we support attaching stuff to them.

Will create a PR to disable all not used devices.

Hm, that depends on the fact if the guest supports virtio or not. Is that even important? Does having a compatible console attached slowing down the vm already?

@fromanirh Maybe you can answer it, I do not sure what performance impact it will have.

Here I still wonder if host-model makes any sense at all and if we should not just use passthrough. According to e.g. https://wiki.openstack.org/wiki/LibvirtXMLCPUModel, it does neither guarantee a sane cpu configuration, nor migratability.

I think when a user does not specify host-passthrough or specific CPU model, it just means that he does not really care about CPU flags, so when libvirt will mask part of features after the migration, it also does not matter for him.
IMHO because of it host-model still the best option for the default value, from one side it provides a pretty good approximation to host CPU and from another side, it does not prevent migration.

Hm, that depends on the fact if the guest supports virtio or not. Is that even important?
Does having a compatible console attached slowing down the vm already?
@fromanirh Maybe you can answer it, I do not sure what performance impact it will have.
AFAIK the footprint in terms of CPU and memoru of a console device, either serial or virtio, is negligible, and we need it anyway to offer a mean to connect to the VM :)

for console devices, virtio is the default, but as rmohr pointed out, requires drivers from the guest. For Linux should be no issue, for windows we need it. For the maximum compatibility we should use the serial emulation.

@fromanirh Thanks for the information, will use serial emulation.

@fromanirh I see that we anyway do not use virtio console
    <serial type='unix'>
      <source mode='bind' path='/var/run/ovirt-vmconsole-console/40195fba-1894-4641-9033-3ac9b99287d2.sock'/>
      <target type='isa-serial' port='0'>
        <model name='isa-serial'/>
      </target>
      <alias name='serial0'/>
    </serial>
    <console type='unix'>
      <source mode='bind' path='/var/run/ovirt-vmconsole-console/40195fba-1894-4641-9033-3ac9b99287d2.sock'/>
      <target type='serial' port='0'/>
      <alias name='serial0'/>
    </console>

so no need to change it.
We can consider to expose two consoles one serial emulation and another one virtio serial console.

@cynepco3hahue indeed, it seems you are OK already. I think two consoles are overkill - if memory serves well we never encountered a case on which it was worth adding two, in oVirt.
IOW, I think that the "console" item is pretty much OK already, no extra work seems to be needed.

the only drawback of serial was that it's buggy:) for OSes where we have drivers(like Linux) we should go with virtio. For random stuff, BSD, Windows (if someone finds that useful at all) "serial" could be good enough
As for two consoles - I do not see a reason why to limit it to one at spec level really. It can be useful to define more, albeit rarely.

@michalskrivanek Do you have some examples of buggy behavior, because currently all our VM's uses the serial console and I did not see any problems with it.

Everything except for numa has been merged. Thus resolving this issue as DONE.
NUMA will be tracked separately.


Bug: App crashed when I tried to go-back from the trash can

Describe the bug
When I access the playlist and clicked on the Trash can, the app crashed when I tried to go back with both the app back button and the mobile back button.
To Reproduce

Launch the app
Click on Playlist
Then click on the Trash can
And click on the app or phone back button

Expected behavior
I expect to use the back button without any issue.
Screenshots
https://youtu.be/LJh3f63BRAg
**Smartphone

Device: [itel]
OS: [6.1]
Version [<IP_ADDRESS>]

Log
06-02 11:32:03.934 22980 22980 E AndroidRuntime: Process: top.geek_studio.chenlongcould.musicplayer.Common:musicService, PID: 22980
06-02 11:32:03.934 22980 22980 E AndroidRuntime: java.lang.RuntimeException: Unable to start service top.geek_studio.chenlongcould.musicplayer.MusicService@e683846 with null: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String android.content.Intent.getAction()' on a null object reference
06-02 11:32:03.934 22980 22980 E AndroidRuntime: 	at android.app.ActivityThread.handleServiceArgs(ActivityThread.java:3028)
06-02 11:32:03.934 22980 22980 E AndroidRuntime: 	at android.app.ActivityThread.-wrap17(ActivityThread.java)
06-02 11:32:03.934 22980 22980 E AndroidRuntime: 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1443)
06-02 11:32:03.934 22980 22980 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:102)
06-02 11:32:03.934 22980 22980 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:148)
06-02 11:32:03.934 22980 22980 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:5452)
06-02 11:32:03.934 22980 22980 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
06-02 11:32:03.934 22980 22980 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:781)
06-02 11:32:03.934 22980 22980 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:671)
06-02 11:32:03.934 22980 22980 E AndroidRuntime: Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String android.content.Intent.getAction()' on a null object reference
06-02 11:32:03.934 22980 22980 E AndroidRuntime: 	at top.geek_studio.chenlongcould.musicplayer.MusicService.onStartCommand(SourceFile:1)
06-02 11:32:03.934 22980 22980 E AndroidRuntime: 	at android.app.ActivityThread.handleServiceArgs(ActivityThread.java:3011)```

Emm This function is normal on my phone. If I want to locate your crash, I need a log file.
You can use adb tools to get the log for me.

Done

try new version, may fixed

It works perfectly :+1:


-- Highlight Search Text and Previous and Next

Hi,
Could you help me how I can highlight the Search text in the PDF Viewer?
I need also the Previous and next button functionality.
Thanks

I've implemented a PdfSearchManager that provides this functionality and a search dialog in the demo application. This probably implements everything you need, including highlighting. Have a look and please re-open this ticket if you're missing something.


unsafe{} when used in macros can emit "unnecessary unsafe block" warning without macro invocation location

The warning itself could be resolved by stmt_expr_attributes (once it is stable) by marking the inner unsafe{} as OK to be unneeded. (If we don't stabilize those, though, we may want to consider whether applying the unused_unsafe warning to unsafe{} generated by macros makes sense.
In any case, we should get an indication of where the macro expansion causing the error is occurring (right now only the macro location is printed, not the invocation location).
Tested with rustc 1.9.0-nightly (600dc3552 2016-04-04)
Example:

macro_rules! another_unsafe {
    ($e:expr) => ({
        unsafe { $e }
    })
}

fn main() {
    let x : usize = unsafe { another_unsafe!(std::mem::transmute(3usize)) };
    println!("{:?}", x);
}

Output:
src/main.rs:4:9: 4:22 warning: unnecessary `unsafe` block, #[warn(unused_unsafe)] on by default
src/main.rs:4         unsafe { $e }
                      ^~~~~~~~~~~~~

Whoops, wrong repo.


i need ipa,can you build it.?

thanks

Sorry, but this is not an issue related to the library and I can't help you.


[Doc] Remove dropped commands

Q
A

Type
Documentation update

Summary
Remove the documentation for odm:generate:documents and odm:generate:repositories commands which have been dropped since 2.0.

Thanks @Alsatian67!


Fix when resque failure backend is already multiple

Goal
We had an outage today after recently introducing Bugsnag into our codebase because our Resque failure backend was already Resque::Failure::Multiple, which this code looks like it handles, except for a small mistake with the operator:
Resque::Failure::Multiple < Resque::Failure::Multiple
# => false

Resque::Failure::Multiple <= Resque::Failure::Multiple
# => true

The backend is likely to be the Resque::Failure::Multiple class, not a sub-class.
This meant that when the bugsnag instrumentation code ran and we ended up with:
Resque::Failure.backend
# => Resque::Failure::Multiple
Resque::Failure::Multiple.classes
# => [Resque::Failure::Redis, Bugsnag::Resque, Resque::Failure::Multiple]

So a failure was reported to Redis, then Bugsnag, then Redis, then Bugsnag, then Redis, then Bugsnag, and so on, until we got a "stack overflow" error.
For us, we had a worker which needed cleanup during resque boot, which involves reporting a failure, so none of our resque workers would boot or process work, resulting in an outage of all background queue processing.
Testing
The tests here are pretty literal and testing the implementation more than the outcome. It might be possible to refactor them to test the Resque side of things a little more, but that's a little more than I'd like to chew off in this PR.
We are currently using BUGSNAG_DISABLE_AUTOCONFIGURE to work around, and would love to get this change merged and released quickly so we can use Bugsnag error reporting for Resque :pray:

Hi @sj26
Thank you for providing this PR. I've added this to our backlog and will review this when priorities allow.

This bit us again today.
Could you please take a look at this. It's quite a small fix, and shouldn't take much of your time.

Hi @sj26
Just a heads up that this is on our list to look at. I still can't give an ETA on when it'll be fully assessed and tested, but we'll make sure to provide any updates on this thread.
Thanks for your patience in the meantime.


vscode debug error  extensions/ms-vscode.js-debug/src/bootloader.js' not found

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:  latest
OS Version: w11

Steps to Reproduce:
40294@antlrv D:\tempFiles\WebDemos\nextjsdemos\nextjs-dashboard git:main ?21 ~21

pnpm run dev
Debugger attached.

@ dev D:\tempFiles\WebDemos\nextjsdemos\nextjs-dashboard
next dev --turbo

Debugger attached.
node:internal/modules/cjs/loader:1143
throw err;
^
Error: Cannot find module 'c:/Users/40294/AppData/Roaming/Code/User/workspaceStorage/ee96a073001a32bfd4ae5846116a79bd/ms-vscode.js-debug/bootloader.js d:/software/Microsoft VS Code/resources/app/extensions/ms-vscode.js-debug/src/bootloader.js'
Require stack:

internal/preload
at Module._resolveFilename (node:internal/modules/cjs/loader:1140:15)
at Module._load (node:internal/modules/cjs/loader:981:27)
at internalRequire (node:internal/modules/cjs/loader:174:19)
at Module._preloadModules (node:internal/modules/cjs/loader:1569:5)
at loadPreloadModules (node:internal/process/pre_execution:628:5)
at setupUserModules (node:internal/process/pre_execution:154:3)
at prepareExecution (node:internal/process/pre_execution:114:5)
at prepareMainThreadExecution (node:internal/process/pre_execution:40:10)
at node:internal/main/run_main_module:11:19 {
code: 'MODULE_NOT_FOUND',
requireStack: [ 'internal/preload' ]
}

what version of Node.js are you using?
Can you print the value of the NODE_OPTIONS environment variable in your terminal?


Added config parsing check to GaNDLF task runner

Thanks for the PR and detailing the issues, @sarthakpati. Am I understanding correctly that the change to load the default params in the PR is unpreferred? If so let's avoid that. I agree it's better to test against the latest tag and use the latest GaNDLF configuration format. To ensure OpenFL is always up to date with the latest GaNDLF format, maybe we could rely on this functionality:
fx plan initialize --gandlf_config ${PATH_TO_GANDLF_CONFIG}.yaml
To pull a GaNDLF reference configuration file from your repo that get's updated if/when there's a new tag with changes? Would it be possible to host and maintain this config file on the GaNDLF repo, or maybe there's one we can already use?

@psfoley: when I am trying to initialize the plan using the gandlf_config parameter [ref], the gandlf_config in the plan seems to be empty [ref]. Any idea what's happening?

There's a couple things going on here:

The path that you're importing the gandlf config from doesn't exist, and OpenFL is not throwing an error (I'll file a bug to add a check for this). I think if you change the command to the following the plan initialization should work correctly:

        fx plan initialize --gandlf_config ../testing/config_segmentation.yaml

You're initializing the plan, but then the final test that runs is:

python -m tests.github.test_gandlf --template gandlf_seg_test --fed_workspace aggregator --col1 one --col2 two --rounds-to-train 1

This will not use the plan you initialized with fx plan initialize ..., but the original gandlf_seg_test plan [ref] instead. It would probably be easiest to delay the plan initialization (with gandlf config) to this line [ref]


Consider using varint for all quantities in the noms format

I had originally reasoned that chunk-level compression (snappy) would do a good enough job removing zeros from quantities (e.g. chunk height, number of elements following in a sequence, etc...), that there was no point to using var int.
Yesterday, I discovered a reason. For #617, I tracked down a bug which caused me to think about the fact that mostly those quantities will be 8 byte values and will tend to be mostly zeros. When we hash over the value bytes, it means that (a) these zeros will tend to skew the target chunk size down and also reduce entropy into the rolling hash.

I think this is a natural thing for Noms V8. it's a simple change it'll result in more consistent chunk size.

I think a better way is to let the encoder use a few more number types. For example, we can use uint8 if the number is a positive int in the range [0, 255], Similarly we can use an int32 if the number is an int in that range.
This would not change that types.Number is a float64 (we want it to be an arbitrary precision number but we haven't done that yet).

I'd have to go back and look more closely, but I think we do use uint8 for the few cases that we know the value is bounded, but for most of the quantities (numLeaves, height, etc...), there isn't really a theoretical bound, so its kind of nice to encode with varint.

I was thinking we would encode as (kind, value) when we know the number can be exactly represented by the kind.

I feel pretty strongly this is the right thing to do. I review the encoding again. Currently we only ever use
uint8 (kind, bool)
uint32 (internal quantities, like number of fields in a struct or number of items in a sequence)
uint64 (external quantities, like ref height, numLeaves)
What I'm proposing is that kind & bool will remain one byte, no point in changing that. but all other quantities become uvarint
To review, varints are generally a win if you encode small quantities ALOT more than large ones. I think this applies generally to noms encoding. of the above usages, really the only that could plausibly be big is numLeaves and even then, the number of numLeaves encodings which are small will far outstrip the number of them which are large.
Take one practical example, a meta sequence requires, at minimum:
-20 byte hash
-8 byte height
-8 byte numLeaves
in order to reference a child node. practically speaking, height will never be > 2^8 and the average numLeaves in a store can't every really be larger than 2^16. This means that encoding with varint, the minimum number of bytes to store a reference goes from 36 to ~22. This would allow for ptrees up to 40% wider.
Note that even the idea compressing the bytes passed into the rolling hash will only get us half of the way there because a copy in snappy is always 3 bytes, so at least the two 8 byte values get compressed to 4 bytes each.


Add missing reducer composition example to docs

The code for the first implementation of todos as an example of reducer composition is actually the same as the previous example, causing the following paragraph ("This is called reducer composition, and it’s the fundamental pattern of building Redux apps") to make no sense.
This change adds the todos function from the following example to make this one more clear.
There are other ways the composition could be done, certainly, and I'm not sure that the one I chose is the most iconic, so feel free to suggest alternatives. :-)

You're right - thanks for the PR :grin:

Argh, my bad. I'm glad you were paying attention @sirbrillig, I'm going to double check the docs to make sure I didn't make any other silly mistakes like this.
I made a minor update, removing a semi-colon that had snuck in, to keep the example following the new Rackt lint config.

:+1: :grinning:

Ok, went through the diffs and couldn't spot any more glaring errors.


feat: split test-utils from integration-tests package

On this PR;

Split test-utils from the integration-test for post-release to npm and facilitate using the utils on other projects like the fuel-bridge for testing proposes.

Error: src/utils/logs.ts(1,28): error TS2307: Cannot find module '@fuel-bridge/portal-contracts' or its corresponding type declarations.


Maxwell filter scaling.

When I use st_only=True the scaling on mag channels seem off. Script to reproduce.
import mne
import os.path as op
from mne.datasets import testing

data_path = testing.data_path(download=False)
sss_path = op.join(data_path, 'SSS')
fine_cal_fname = op.join(sss_path, 'sss_cal_3053.dat')
ctc_fname = op.join(sss_path, 'ct_sparse.fif')
pre = op.join(sss_path, 'test_move_anon_')
raw_fname = pre + 'raw.fif'
raw = mne.io.Raw(raw_fname, allow_maxshield=True)

raw_sss = mne.preprocessing.maxwell_filter(raw, calibration=fine_cal_fname,
                                           st_duration=2, st_only=True,
                                           cross_talk=ctc_fname)
raw_sss.plot()

I also see similar looking issues with reconstructed bad grad channels on multi-subject, multi-modal human neuroimaging dataset subject 10, but I'm unable to reproduce it with the testing dataset.

Hmm... I think that within any given window, the result actually looks reasonable. And tSSS is reducing power, as expected:
import mne
import os.path as op
from mne.datasets import testing
import numpy as np
from nose.tools import assert_true

data_path = testing.data_path(download=False)
sss_path = op.join(data_path, 'SSS')
fine_cal_fname = op.join(sss_path, 'sss_cal_3053.dat')
ctc_fname = op.join(sss_path, 'ct_sparse.fif')
pre = op.join(sss_path, 'test_move_anon_')
raw_fname = pre + 'raw.fif'
raw = mne.io.Raw(raw_fname, allow_maxshield='yes', preload=True)

raw_sss = mne.preprocessing.maxwell_filter(raw, calibration=fine_cal_fname,
                                           st_duration=2, st_only=True,
                                           cross_talk=ctc_fname)
raw.pick_types(meg='mag')
raw_sss.pick_types(meg='mag')
raw_sss.plot()
assert_true((np.linalg.norm(raw_sss[:][0], axis=-1) <
             np.linalg.norm(raw[:][0], axis=-1)).all())

But window-by-window the projection changes, so you get over multiple windows an up-down sort of behavior, which I assume is what you're pointing out? This might be fixed by doing overlap-add windowing, which is something I've discussed previously with Samu. I hope to get to it soon.

Oh wait... I think there might also something odd going on due to the DC value in the signal. I'll keep digging.

BTW anyone to lazy to run code, here's an example before/after tSSS, the 2-second-ness of the data processing is visible:

The bad channel reconstruction was fixed by setting origin and destination manually, but the mag channels are still noisy with st_only=True. On multimodal dataset it's even more prominent.

Can you paste the updated command lines so I can look at the same thing
locally?

That is from the multimodal dataset sub010. So just
raw = mne.preprocessing.maxwell_filter(raw, calibration=cal,
                                                   cross_talk=ctc,
                                                   st_duration=10.,
                                                   st_only=True,
                                                   origin=(0., 0., 0.04),
                                                   destination=destination)

what is destination and which run is that?

actually I think destination shouldn't matter for this, and I guess I can check any run and they'll probably display this behavior

The original raw data with no projectors looks about the same. st_only removes projectors, so it will look different unless you disable proj.
I guess in st_only mode we don't need to remove projectors, since tSSS by itself doesn't/shouldn't change the spatial configuration of the data.


Hotfix/windows comment

Sot that users can easily provision Windows...

don't forget to bump version number in metadata and then push to supermarket after it's all merged.

I think it doesn't need release as it's just commentary.
Just leaving till next release.


Release/1.26.0

Description
Please summarise the changes.
Related issues
Please mention any github issues addressed by this PR.
Checklist

[ ] I have performed a self-review of my code.
[ ] I have commented hard-to-understand parts of my code.
[ ] I have made corresponding changes to the public API documentation.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have updated the changelog with any user-facing changes.

In particular, it'd be #82 and #83 that I'd like to have merged before releasing, along with another branch (PR not yet created) for the Jupyter notebook. I'm a bit busy atm with the submission of a paper, so if we can postpone this for a couple of weeks I'd be grateful.

I don't think there's any urgency about this release so it should be fine to wait.

@PabloAndresCQ Happy to wait, and happy to help with the review if there is something I can support you with :relaxed:


Fix/shebangs

Proposed changes
Remove unnecessary shebangs.
Fixes
n/a
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

[x] Non-breaking fix (non-breaking change which fixes an issue)
[ ] Breaking fix (breaking change which fixes an issue)
[ ] Non-breaking feature (non-breaking change which adds functionality)
[ ] Breaking feature (breaking change which adds functionality)
[ ] Refactor (non-breaking change which changes implementation)
[ ] Messy (mixture of the above - requires explanation!)

Checklist
Put an x in the boxes that apply.

[x] I have read the CONTRIBUTING doc
[x] I am making a pull request against the main branch (left side). Also you should start your branch off our main.
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have locally run services that could be impacted and they do not present failures derived from my changes

The only remaining shebangs (apart from files in scripts/ and .tox/):
upload.py
setup.py
packages/valory/connections/abci/check_dependencies.py
packages/valory/connections/abci/scripts/genproto.py
plugins/aea-test-autonomy/setup.py


OOM Killed Scanned pod job

Target namespace one of deployment scanned image pod job getting killed due to OOM resulting scan failure (succeeded state as false)
Please help how to increase the memory resources on scanned pod before the scan

Hi @hackerup, currently the only option you have to increase scanners resources will be to build your own kubei deployment.
The resource values are hard coded here for the vulnerability scanner and here for the CIS docker benchmark scanner.
We are working on a big refactoring for kubei and in that release we will make the resources configurable

@fri

Hi @hackerup, currently the only option you have to increase scanners resources will be to build your own kubei deployment.
The resource values are hard coded here for the vulnerability scanner and here for the CIS docker benchmark scanner.
We are working on a big refactoring for kubei and in that release we will make the resources configurable

Thanks for the rapid response I will try the above workaround

Worked Thankyou


Add type scale feature flag to example scss

Prompted by a report that the warning text examples on the website aren't using the new type scale despite us setting govuk-new-typography-scale to true in main.scss.
Because we use a different stylesheet for examples, the examples themselves weren't using the new type scale. This is set on example-init which is being used by the 2 example stylesheets: example and example-inverse.

@36degrees So, all examples are using either example or example-inverse which both import example-init. I'd therefore expect all examples to be impacted by this except full page examples, which just use main right now which itself has the type scale feature flag set to true. Additionally, they won't get the new type scale from the govuk-frontend import because the type scale isn't on by default yet, whilst it is on by default for the rest of the website. I think it makes sense for our website and our examples to be consistent.
I should've added more context as well that I got a DM from a user that the warning text component was dropping to 16 on mobile which isn't intentional against the new scale. From a very quick test this is true for all our examples. I'll add this to the PR desc.

Take a look at the example for warning text in this PR on a mobile viewport – it's still 16px on mobile just like the live site.
This is because the example and example-inverse stylesheets only contain the additional CSS required for the examples and not the styles that are coming from GOV.UK Frontend.
This is the entirety of example.scss:
.app-example-page__wrapper{overflow:auto;background-color:#fff}.app-example-page{padding:30px}
/*# sourceMappingURL=example-28cf8f56ce3cba62d258b5725b59ecd7.css.map */

The styles for warning text are coming from the minified CSS file straight out of the govuk-frontend package which we'll need to change to fix this.

Following a chat off github, it transpired that Ollie's right and this isn't actually working. I was on another planet 🙃
They only conceivable way we'd be able to do this, other than turning on the type scale flag by default, is to import govuk-frontend directly into example.scss, like we do with main.scss. This would partially undo some work we did to decouple the different scss spaces and could have negative consequences on caching. I'm gonna close this for now and reconvene with the other devs on a potential solution.


switched HashMap tests over to testify

Pull Request for issue
https://github.com/kasvith/kache/issues/20
Description
Testing Instructions
Additional Comments

I wonder why go get ./... fails to grab the testify

maybe you can run dep ensure to add github.com/stretchr/testify to gopkg.lock and then ci well isntall it

@BigJk can you resolve conflicts?

Ok I found the issue, testify need to be fetched as a whole. So go get ./... only works for assert package and it causes issue.
We would switch to dep to eliminate these issues

this can be closed

Closed by #50


libc: Fix IPTR for puts/fputs/scanf

since the fgets isn't decorated by IPTR
Signed-off-by: Xiang Xiao<EMAIL_ADDRESS>Change-Id: I2a83afb4d934a44ad1b56ec6dd72e654f4e112a3
Summary
Impact
Testing

This function did not need to be decorated with IPTR since it explicitly copied the bytes from ROM.  IPTR is a special storage class for Harvard architecture maches that indicates that the pointed to data resides in instruction (ROM) space.  In this case, it would instead explicitly copy from instruction space.
This function is older than IPTR.  If you are going to remove this function, then could you please add IPTR to the string pointer argument?

Does anyone can help review this change?


chore: Bump deps 2021.03.09

What does this change?
Bumps dependencies, key highlights are:

Upgrade to Husky 5, which uses files in .husky for its hooks and is much smaller.
Upgrade to action-semantic-pull-request v3.4.0, which allows for validateSingleCommit flag.

Why?
Keep @dependabot happy.

Should be happy now, @sndrs!


Deduplicate mock_trait Macro

Currently, the mock_trait has two duplicate definitions. One is for private mocks and the other is for public (pub) mocks.
As shown by the following Rust issue, there is currently no way to define a single macro that has an optional (i.e. 0-or-1) token to be included:
https://github.com/rust-lang/rust/issues/18317
This issue is here so we don't forget to deduplicate this macro when the relevant changes have been made to Rust to allow optional tokens.
Originated from PR: https://github.com/DonaldWhyte/double/pull/6/

I'm closing this issue. https://github.com/DonaldWhyte/double/pull/10 has just landed, which mostly removes most of the duplicated code in mock_trait! caused by the pub/non-pub versions.
I don't think there's a reason to wait for issue https://github.com/rust-lang/rust/issues/18317 to be resolved for this, since most of the duplicated has been removed now.


Added tilt button

Hey @Spyware007 I have added the tilt button to your website. Please review my pr and merge it. Thank you!

Hi, there seems to be a merge conflict, please resolve it

Hello @sumitkr2000 it because of you are adding unwanted files like package-lock.json
Remove the file from this PR.

@Spyware007 Now please check. I am now tired of resolving merge conflicts. 😪


Request edit access to Yocto Project

Hi, Would it be possible to gain edit access for the Yocto Project's entry? The original author hasn't updated things in over a year. Thanks, Richard (Yocto Project Architect)

It is certainly possible. The easy way is if the original owner agrees to it directly... once we confirm that, then the transfer is easy. Is that likely?

Just to confirm, Richard is Mr. Yocto, so we might want to make an
exception here: https://en.wikipedia.org/wiki/Yocto_Project
Dan Kohn<EMAIL_ADDRESS>Executive Director, Cloud Native Computing Foundation https://www.cncf.io
+1-415-233-1000 https://www.dankohn.com
On Tue, Dec 11, 2018 at 6:30 PM David A. Wheeler<EMAIL_ADDRESS>wrote:

It is certainly possible. The easy way is if the original owner agrees to
it directly... once we confirm that, then the transfer is easy. Is that
likely?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/coreinfrastructure/best-practices-badge/issues/1252#issuecomment-446402931,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC8MBtQDt3MpL7chTTNmbz-7p2ScKZpwks5u4EAmgaJpZM4ZOVYh
.

If the badge entry refers to a GitHub site, then you can already edit it if you are allowed to edit the repo itself. Also, the current owner can add you as someone who is allowed to edit.

I have contacted Sona (the person originally working on this) to ask her position on this. As Dan mentioned, I'm a fellow at the LF using my LF email address and lead the project so I'm hopefully in good standing! The project is not a github based one, it has its own site/infrastructure predating github and is an LF project.

@rpurdie : Oh, you're definitely in good standing! :-).  But transferring badge entry ownership is a big deal, so we have a special process/ceremony that we use to prevent misuse and reduce that risk that someone can use a subverted account to make the request.  I've started that process now.  Thanks for contacting us.

Just to be clear: I expect this transfer to be quick and easy.  I've not used Yocto, but I've read lots of good about it over the years, so it's an honor to chat!  That said, we have to double-check things to protect everyone, it shouldn't take long and doing same the process for everyone makes it harder on the bad guys.

Hi guys, sorry that I haven't been active with this project due to several reason :( David: Please give access/ownership to Richard. I will help him as much as I can.

All done!
@rpurdie - you now own the badge entry.   As the entry owner, you can allow others to edit it as well; once the others have an account, you can edit "What other users have additional rights to edit this badge entry?" and add their user ids.
Officially Yocto only shows 64% in progress.  I suspect that Yocto is much further along than that.  When you view the badge entry, there are buttons at the top - you can click "expand panels" and "Hide Met & N/A" to show what's missing.
I'm closing this issue, since it's complete.
If you have further questions, please let me know!!  We definitely want to help.

Thanks David and Sona.
We should be able to do much better than 64% and that is one of the reasons I wanted to move this forward which I think we can now do. There are some others I'll involve and see if we can't improve that number :)


Error launching nav2 with FastDDS

Robot Model
Turtlebot4 Standard
ROS distro
Humble
Networking Configuration
Discovery Server
OS
Ubuntu 22.04
Built from source or installed?
Built from Source
Package version
turtlebot4_navigation                  nav2.launch.py
Type of issue
Navigation (SLAM, Nav2 etc.)
Expected behaviour
Nav2 starts and should wait for a position to navigate.
Actual behaviour
Nav2 does not starts correctly when using discovery server, stays waiting for service controller_server/get_state indefinitely.
Error messages
Waiting for service controller_server/get_state...

To Reproduce
Launch the localization node
ros2 launch turtlebot4_navigation localization.launch.py map:=office.yaml
Launch the nav2 node
ros2 launch turtlebot4_navigation nav2.launch.py
Other notes
Before changing the networking to discovery server I had other problems such as that the base kept disconnecting very easy from the network, that is why I changed to discovery server. Now, I do not have problems like not getting the topics from the base, but I have these problems now, maybe it is a problem that I caused when I did the change to discovery server, but from my understanding, if that was the case I wouldn't be able to read the topics from the base.
Another interesting thing is that I am running it from my computer which has ROS2 Humble, and the turtlebot4 is using ROS2 Galactic. Again, I have been working with the robot like this I did not have problems, so I do not see why the problems would start now, unless you say otherwise @hilary-luo ... What do you think?
Thanks for the help!

i have the same problem, but both my PC and Turtlebot are already in humble version.


Overlapped speech performance

Hi,
I did check this with a video  where 2 speakers speaking at the same time. It can detect only one speech at a time.

The performance of TalkNet may decease for the overlapped speech. 'Can detect only one speech' is not true since the detection for two speakers are INDEPENDENT. In another word, it is possible that there are >=2 green boxes on the screen. While the performance may not robust for that difficult condition.

Understood. Perhaps, adding some speaker information in the embedding may help.
( Another point : when I remove the average smoothing, I could see some improvement. Is this verified  on your side? )

I notice the results are similar in my experiments? Yes they are similar I also find.


feat : port Algebra.Module.Equiv

Could you please run scripts/fix-comments.py on this?

Also note there's still norm_cast attributes that I couldn't carry over. Do we still need them?


Only green screen

Hi, when I install everything like in the instruction I have only green screen on http://localhost:31982/hud

Will close this one for now, feel free to reopen with the data from above if you're still having trouble.

Now is working! Thx <33
Btw it is save to play cs2 normal with this csf in game?

yes, it's safe


Signal PDU

Would like to have possible radio coms sent over dis.

Signal PDUs have been added in. They should be able to be both received and sent.


Map suddenly completely reveals, all dug out spaces filled back to their original blocks

Describe the bug
The map fully revealed and all dug out spaces reverted to their original blocks.
What happened
The map fully revealed on two occasions on the same save, second time after quiting without saving. Then dwarves couldn't do anything anymore, cause most were stuck inside stone.
Expected behavior
Not suddenly doing this
ai version:
Dwarf Fortress 0.47.05
Windows 64-bit
df-ai 0.47.05-r1-0-gd7302b4a
code d7302b4a8ca9417b9d47337cf2009c0940c8f6e3
DFHack 0.47.05-r1-0-g032cd64c
library 032cd64c10bf38fcb9d955c75a8ade4e857cc579
structures 11c379ffd31255f2a1415d98106114a46245e1c3
df-ai-debug.log
Additional context
I can provide a world download if you'd like me to, just tell me what scope of folders you'd like. I'll keep the world safe for now.

Happened on a personal playthrough too. Pretty sure this is a dfhack/df core issue

Are you using open-legends?


Export JDL export unwanted values (and create invalid JDL)

Overview of the issue

When exporting a JHipster application with the jdl exporter, the jdl seems incorrect as there are some unrecognized values (e.g. packageFolder, promptValues, jhipsterVersion, jwtSecretKey,     otherModules and blueprints)
Motivation for or Use Case

Reproduce the error

Create a default jhipster application and try to export it with jhipster export-jdl
Related issues
#264 and jhipster/generator-jhipster#8391
#344 for the blueprints option

Suggest a Fix
Maybe just ignore the unwanted values ?

JHipster Version(s)
6.2.0 (master) and jhipster-core on master too

JHipster configuration

Entity configuration(s) entityName.json files generated in the .jhipster directory

Browsers and Operating System

[x] Checking this box is mandatory (this is just to show you read everything)

Hi, what are the unwanted values and why? They aren't in a .yo-rc anymore?

packageFolder, promptValues, jhipsterVersion, jwtSecretKey, otherModules and blueprints are exported, but not recognized when importing a JDL. These values are stored in the yo-rc file. I am not sure if it is useful to export all of them in the jdl.
Concerning blueprints, it should be handled by #344.
Moreover, promptValues and otherModules are not correctly exported (in the exported jdl, they are printed as [Object])

Is promptValues needed?

I don't think so. I am not sure that the jwtSecretKey is useful too. Concerning the jhipsterVersion, and the packageFolder, I don't know.

From what I've been able to deduce, promptValues can be omitted.
About the secret key, I'm not sure. If the JDL export has to perform a perfect export of the app, wouldn't it be needed too?
The JHipster version may be useless (unless I'm missing a use case), the packageFolder maybe not: it is asked during the generation.
Thanks for the clarification :)

Btw, I can try to make a PR to fix this, if you tell me which fields you want to keep and which ones to drop

The JHipster version may be useless (unless I'm missing a use case),

It's used a least by the upgrade feature.

@clement26695 I'll do it but thanks! Just having this issue is a big step forward.

Only the otherModules key is bothering me... I've dealt with the other (except the package folder, which I'd rather generate from the package name option). This is a tricky one as it contains a name and a version


Why so many !important css declarations?

I need to set some of the basic colors of items to our corporate design system colors.
In 3.x this was not an issue, set up our custom _variables.scss and remap the colors.
But I keep running into roadblocks with classes like .bg-primary or .text-info to name two:  these are set in the Bootstrap scss with !important declarations forcing me to redefine the style and also add !important.
Why all the !importantss?

You can still do the same as in v3 and use a _custom.scss to define your custom colors.
The !important shouldn't matter if you use _custom.scss

CSS should not need !important
We compile a file called design_system.css which is distributed to our various dev teams via Bower and NPM.
They load a vanilla Bootstrap install via Bower, NPM,  or Bootstrap CDN -- they don't use the sass version -- and link to that in their index.html, followed by the above-mentioned design_system.css, which has overrides and additional code for our company's apps.
Having to rely on a _custom.scss file and compiling Bootstrap sass files is not part of their workflow.
Again, I don't expect Bootstrap to use !important, especially in cases like I mentioned.  It's an amateur technique.

They're there to ensure you can apply those styles as utilities no matter what. It's a necessary evil that's only present for utility classes, and nothing else.
You don't have to rely on the included custom Sass file (I think I'm going to nuke that damn thing at this point, it's way too confusing).

@mdo Here's a case in point:  Using progress bars.  Both Bootstrap 4's and ng-bootstrap's.
Their colors are set with things like bg-info.  This uses the default BS4 "info" color of cyan.  In my app, I have set this to be blue.  Now all my progress bars are wrong.
As I said above, I cannot have our dev teams use the scss version of Boostrap.  So now I need to re-define all the helper classes in MY css, also with !important.  It's nuts.

Sorry, @smlombardi, but this was the direction we decided to take years ago. We're kinda locked into it now. Plus, most folks asked us for !important on these utilities.

The !important shouldn't matter if you use _custom.scss

Of course it doesn not; indeed, it is the only sensible way to go with Bootstrap4.
But you might have a hard time explaining stakeholders (and in less lucky areas, where e.g. using Angular or embedding non-escaped HTML inside scripts is considered "intuitive", even colleagues) why to spend time on "creating something that is already there".

@mdo can you point to the requests on github? I find that EXTREMELY hard to believe.

How can we remove !important from all the bootstrap class ?

In v5, simply set $enable-important-utilities to false.

@mdo where are these github request? Below is reason why you shouldn't use important in your css.
The use of !important is considered an anti-pattern and bad practice. !important overrides all other declarations and makes the CSS code more difficult to maintain and debug. The only thing that can override an !important is another !important, and once you go down that road, it never stops.
From a Web Accessibility perspective, the use of !important is negative because it would override the end-user defined styling. And there are multiple cases in which users –and especially users with disabilities– may want to override some of the CSS properties (e.g. to enlarge the font size, or change the font-family, or even change the distribution and position of elements in a page.)


Driver repeat installation issue

There should a mechanism to stop the installation of already installed driver or app again. Currently, from UI there is no way to get back (or stop) once install button is clicked. In background an error is thrown, but I think there should be some way of graceful error-handling mechanism for this issue.

Agreed.
I think @ktg is picking this up in #11

fixed in https://github.com/me-box/core-container-manager/commit/7af22eb7954cc63795b7525783160c3f85ad8b61 by @ktg


Update UML diagrams

Update UML diagrams to indicate that the Person class includes NOK and Description.
Related to issue #48

LGTM


Add assembly definition to make import via git URL possibe

Hi, adding the package via git URL does not work because your repository does not have an assembly definition.
I cannot create Sprite Animation assets nor add any related components to GameObjects when importing this way.
Warnings:

Please add an assembly definition file to this reposiory. This is a common practice used in similar packages.
Example:

Hi, sorry for the delay, it used to have an assembly definition, i removed it because importing it this way makes it impossible to make changes to the package.
I will be adding it back soon


Add a way to look up the library object for an instance in DDC apps

We currently have the getType(instance) utility which gives the class for an instance, but we don't have a way (that I can find) to get back at the library for that instance.
For the vm service protocol we need to provide a ClassRef for each InstanceRef, which requires an id and a name. The name we can get, but we don't have a way of constructing a unique id today if we can't get back to the library.
It is probably worth chatting in person before doing anything here, there are some other ways we could potentially solve it as well (add a unique ID for each class etc).

Are the requirements that id is globally unique per type? Is it a String?

The ids do need to be globally unique, and are just simple Strings. We do already get ids from chrome though which we might be able to use.

I believe kernel provides something like this (thing URIs) - we just don't save it in DDC. I haven't checked if they are consistent with Analyzer though.

@natebosch - do you have an update on this one?

No updates yet - will take a look today.

If we add the extra metadata to track this internally it's about a 2% size penalty within the SDK.

That's not bad.  Add under --emit-metadata?

Nate - did you decide if we want anything in D24 for this?

~1.2% impact on flutter web gallery. I think we should move forward with the change and release in D24.
I think we should keep this on by default instead of behind --emit-metadata for now. It's not clear that all the other stuff that comes along with emit-metadata is going to be as useful as this...

sgtm


Add workaround for CERTIFICATE_VERIFY_FAILED error

:+1:
Would it be worth mentioning that other than for the purposes of training, this is not something you should ever do on a real system?

Would it be worth mentioning that other than for the purposes of training, this is not something you should ever do on a real system?

@natefoo It does say "if your Galaxy uses a self-signed SSL certificate...", but feel free to amend as you see fit!

True - so it should already be fairly obvious. Although in the case of training, they're not self-signed, they're just signed by an untrusted (and untrustworthy) CA.

Yeah, thought about that same distinction (self vs untrusted) and decided majority won't be bothered and merged as-it-was.


Fix CAlphabet::Clone + unit test

Seems like CAlphabet couldn't be cloned properly. Another bug that surfaced with the all the cloning happening now with parallel xval, for me in the case of CCommWordStringKernel.
There are some remarks about this in the serialization section here.
Please check.

@vigsterkr feel free to merge

boooyaaaa

Feel free to change the license to BSD and fix the code style issues. Now that this was merged I guess it's easier if you commit directly.


How to dynamically build list of keys to use in a select query in .select(keys)?

Not sure where to post this, I tried discord but it seems dead, and I was the first person to tag kysely on stackoverflow, so not sure I will get any bites there. Any help would be appreciated (and note on where I should ask future questions, I have a few for kysely).
https://stackoverflow.com/questions/76277708/how-to-properly-build-an-array-of-keys-which-match-a-types-keys-in-typescript
Thanks!

If the discord seems dead you were in the wrong discord.

Here's one option https://kyse.link/?p=s&i=ye5MaLka2OLLWmIBVnSC

You were actaully answered 11 minutes after your question. Jesus christ 😄 That's enough for you to consider it dead?????


07 Registers / Bad Address: Function "UserHardFault" not defined

Hi,
thanks for the awesome work.
I found a minor bug in section 07 Registers / Bad Address
When running the example with the following openocd.gdb config:
target remote :3333
set print asm-demangle on
set print pretty on
monitor tpiu config internal itm.txt uart off 8000000
monitor itm port 0 on
load
break DefaultHandler
break UserHardFault
break main
continue

gdb complains about not finding the UserHardFault function:
...
Function "UserHardFault" not defined.
...

When running continue, the program does not halt as expected in the hard fault handler, but hangs in a loop.
I looked into the cortex_m_rt crate which, does not expose the expected UserHardFault function, however it exposes HardFault.
Changing the openocd.gdb config to:
...
break HardFault
...

solved the problem and the program holds as expected on the breakpoint.
I hope you can improve this section.
Keep up the great work!
Relevant versions:
discovery book: bbd3f0
cortex-m-rt: 0.6.7

thnxxx for the suggestion


strange behavior in the RX buffer

when reading the buffer RX ( sx126x_read_buffer ) , if I read as many bytes as the sx126x_get_rx_buffer_status function says, there is random data. In order to retrieve my frame is to read 255 B and my received frame is there, with 4 bytes offset. If I read a different amount of bytes from the RX buffer, I get random data.

Hi,
In https://github.com/Lora-net/SWSD003/blob/master/sx126x/common/apps_common.c (starting from line 478), you can find an example of reading received payload.
Many thanks,
Best regards,


issue on getAccountDetails and getPayments.

Hey,
When I try to get account details and payments it is giving this error.
"The operation couldn’t be completed. (stellarsdk.HorizonRequestError error 4.)
error!"
version: "1.6.0"

Hey @wixvii - can you provide the code you're using (along with the account ID you're requesting), or a sample code snippet that generates the same failure?

here is my code:
        sdk.accounts.getAccountDetails(accountId: accountId) { (accountResponse) -> (Void) in             switch accountResponse             {             case .success(let account):                 print(account)             case .failure(let error):                 print(error.localizedDescription)             }         }
and sample account is yours account for donate :)
"GANSYJ64BTHYFM6BAJEWXYLVSZVSHYZFPW4DIQDWJL5BOT6O6GUE7JM5"

Which URL did you configure the SDK object with? The follow snippet (which is close to yours) yields the correct response...
let sdk = StellarSDK.init(withHorizonUrl: "https://horizon.stellar.org")
let account = "GANSYJ64BTHYFM6BAJEWXYLVSZVSHYZFPW4DIQDWJL5BOT6O6GUE7JM5"

sdk.accounts.getAccountDetails(accountId: account) { response -> Void in
    switch response {
    case .success(let details):
        print(details.balances)
        print(details.accountId)
    case .failure(let error):
        print(error)
    }
}

Can you also provide the output of the following command: cat Podfile.lock | grep stellar?

yeah its work!
Sorry its my fault, I did not think about test-live horizon sdk :(
but maybe you can add it to readME file. default sdk is test you can add it to readME. Maybe someone like me can miss it. Thank you.

No problem - happy it's solved!

Hi, Nick, I need Your help !
I'm created account in test net and checking it - he exists.
When I using getAccountDetails with "https://horizon-testnet.stellar.org" - I have error  "The data couldn’t be read because it is missing."
When "https://horizon.stellar.org" as in the example above -
notFound(message: "{\n  "type": "https://stellar.org/horizon-errors/not_found\",\n  "title": "Resource Missing",\n  "status": 404,\n  "detail": "The resource at the url requested was not found.  This is usually occurs for one of two reasons:  The url requested is not valid, or no data in our database could be found with the parameters provided."\n}", horizonErrorResponse: Optional(<stellarsdk.NotFoundErrorResponse: 0x281e3fe30>))
my account "GB33EPYLVRLD6GTCRLSBCXET35TZKJJCQDRQZHLR5UNNNWWTHMD4IL4B".
And I using
let sdk = StellarSDK.init(withHorizonUrl: "https://horizon.stellar.org")
let account = "GB33EPYLVRLD6GTCRLSBCXET35TZKJJCQDRQZHLR5UNNNWWTHMD4IL4B"
sdk.accounts.getAccountDetails(accountId: account) { response -> Void in
switch response {
case .success(let details):
print(details.balances)
print(details.accountId)
case .failure(let error):
print(error)
}
}
But it's not works for me.
Thank You !

@PavelSakhanko - your issue is that GB33EPYLVRLD6GTCRLSBCXET35TZKJJCQDRQZHLR5UNNNWWTHMD4IL4B exists on Testnet but not on production. Your SDK initialization seems to be configured for production based on the debug output you've provided.
Change "https://horizon.stellar.org" to "https://horizon-testnet.stellar.org" in your SDK initialization and you'll be all set.
Testnet is a completely different Stellar environment and will not have the same accounts, ledgers, and transactions as production.


Upgrade to Django 4.2 LTS

Update psycopg to 3 as it’s not supported by Django 4.2
Replaced “BaseUserManager().make_random_password”, as it’s deprecated
Update github action and breakup different checks, making them easier to debug
Updated the makemigrations checks to display the missing migration and then fail
Upgrade django-hijack to 3.4.2
Update gunicorn to 21.2.0
Upgrade django slack to 5.19.0
Upgrade mistune to 3.0.2 (Bug fix release)
Upgrade whitenoise to 6.6.0
Update dev dependencies - black, ruff, pre-commit, pytest-django

Closes https://github.com/HyphaApp/hypha/issues/3362

This should be good to put on test now.

Did a rebase. This seems to work well!


unused column

What about unused column?
For example there are 5 columns in "Character" sheet.
"name", "_desc", "ap", "dp", "maxhp"
But I do not want to import "_desc" column into scriptableobject.

Though Unity-QuickSheet does not support that feature, Unity-QuickSheetPro has that feature.
See the following image:

You can freely remove a selected column. And the removed column is not imported.
Unfortunately, Unity-QuickSheetPro is not released yet but hopefully, it will be soon.
By the way, it will be a charged one.
Cheers,

Bought from AssetStore? I've never sold it on AssetStore.  What did you buy on AssetStore?

I'm sorry!! I mixed Unity-QuickSheet with another plugin I just bought from Unity Asset Store! That plugin also releases its source in git. I was just so busy and my brain became a mess. Sorry again!

No worries. And thanks for your interesting.


[SPARK-15271] [MESOS] Allow force pulling executor docker images

What changes were proposed in this pull request?
Mesos agents by default will not pull docker images which are cached
locally already. In order to run Spark executors from mutable tags like
:latest this commit introduces a Spark setting
spark.mesos.executor.docker.forcePullImage. Setting this flag to
true will tell the Mesos agent to force pull the docker image (default is false which is consistent with the previous
implementation and Mesos' default
behaviour).
How was this patch tested?
I ran a sample application including this change on a Mesos cluster and verified the correct behaviour for both, with and without, force pulling the executor image. As expected the image is being force pulled if the flag is set.

Please note that I had to upgrade the Mesos library version to implement this feature! Unfortunately its only available in Mesos 0.22 and above.

Can one of the admins verify this patch?

I rebased again, against master. Anything else I can do here to get this merged?

Other than the style nit, I think it LGTM. Once you fixed it we need to ask a Spark committer to review it.

ok to test

Test build #59858 has started for PR 13051 at commit 1b295e8.

Test build #59858 has finished for PR 13051 at commit 1b295e8.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59858/
Test FAILed.

@tnachen I addressed your comment and also fixed the scala style error from the build.

Test build #59864 has started for PR 13051 at commit 80d1e3e.

Test build #59864 has finished for PR 13051 at commit 80d1e3e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59864/
Test PASSed.

@andrewor14 PTAL, this PR LGTM

rebase to master

Test build #61719 has started for PR 13051 at commit 7768589.

Test build #61719 has finished for PR 13051 at commit 7768589.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61719/
Test PASSed.

Can you add this to the CoarseMesosSchedulerBackend as well?  This solution adds the force pull feature to drivers, but not executors for spark jobs.

Test build #62317 has started for PR 13051 at commit c2d4b7f.

Test build #62317 has finished for PR 13051 at commit c2d4b7f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62317/
Test PASSed.

Merged build finished. Test PASSed.

Test build #62465 has started for PR 13051 at commit 36b3258.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62465/
Test PASSed.

@andrewor14 This LGTM.  Can you take a look and merge?

@srowen Or if you could help :)

Merged to master

This patch just broke the build:
[error] /home/jenkins/workspace/spark-master-compile-maven-hadoop-2.2/core/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala:268: not enough arguments for method verifyTaskLaunched: (driver: org.apache.mesos.SchedulerDriver, offerId: String)List[org.apache.mesos.Protos.TaskInfo].
[error] Unspecified value parameter offerId.
[error]     val launchedTasks = verifyTaskLaunched("o1").asScala
[error]                                           ^
[error] /home/jenkins/workspace/spark-master-compile-maven-hadoop-2.2/core/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala:306: not enough arguments for method verifyTaskLaunched: (driver: org.apache.mesos.SchedulerDriver, offerId: String)List[org.apache.mesos.Protos.TaskInfo].
[error] Unspecified value parameter offerId.
[error]     val launchedTasks = verifyTaskLaunched("o1").asScala
[error]                                           ^
[warn] one warning found
[error] two errors found
[error] Compile failed at Jul 25, 2016 12:34:51 PM [37.534s]

Going to revert now.

Shoot, yeah PR builder tests passed, but that was 7 days ago. Sorry @philipphoffmann can you try this one again after figuring out whatever caused this?

fixed the above issue and sent another request here: #14348


BAU Add expired and not yet valid certs for stub country

Does this require a manual version bump in any way? If so, how does one do that?
These certs are being added to make it easier to test a change to the
MSA that ensures that it starts even if a cert contained in the trust
anchor is expired.
The new and changed profiles in the config have expiry set as it
appears to be required, despite explicitly setting not_before and
not_after.

This looks good. I don't think we need any version bump, the local stuff should use the updated repo after merging


Your Apple ID account is attached to other iTunes providers. You will need to specify which provider you intend to submit content to by using the -itc_provider command

Did anyone incur into the following error?
Package Summary:

1 package(s) were not uploaded because they had problems:
	/var/folders/dw/bb3vx0757nzckp2t81shwk6h0000gn/T/F1F8613D-3584-487D-BF3D-A8CB736639CF/net.company-name.tav.itmsp - Error Messages:
		Your Apple ID account is attached to other iTunes providers. You will need to specify which provider you intend to submit content to by using the -itc_provider command. Please contact us if you have questions or need help. (1627)
2019-11-13 16:26:01.610 altool[27318:239676] *** Error: Your Apple ID account is attached to other iTunes providers. You will need to specify which provider you intend to submit content to by using the -itc_provider command. Please contact us if you have questions or need help. (1627)

    at /Users/damians/Desktop/tav-client/node_modules/electron-notarize/src/index.ts:83:13
    at Generator.next (<anonymous>)
    at fulfilled (/Users/damians/Desktop/tav-client/node_modules/electron-notarize/lib/index.js:4:58)
    at processTicksAndRejections (internal/process/task_queues.js:93:5

I'm using the following script:
const fs = require('fs');
const path = require('path');
const electron_notarize = require('electron-notarize');
const { build: { appId } } = require('./package.json');

module.exports = async function (params) {
    // Only notarize the app on Mac OS only.
    if (process.platform !== 'darwin') {
        return;
    }
    console.log('afterSign hook triggered', params);

    let appPath = path.join(params.appOutDir, `${params.packager.appInfo.productFilename}.app`);
    if (!fs.existsSync(appPath)) {
        throw new Error(`Cannot find application at: ${appPath}`);
    }

    console.log(`Notarizing ${appId} found at ${appPath}`);

    try {
        await electron_notarize.notarize({
            appBundleId: appId,
            appPath: appPath,
            appleId: process.env.appleId,
            appleIdPassword: process.env.appleIdPassword,
        });
    }
    catch (error) {
        console.error(error);
    }

    console.log(`Done notarizing ${appId}`);
};

Hey guys, I solved by fighting with apple developer account / teams / passwords / licenses.
What a mess.

@damianobarbati Can you share how you fixed this?
I'm getting the same error

@mitchdennett sign into your developer account (you must be the all-mighty team agent, not team admin) and accept/confirm every pending document if any in the licenses section.
You need:

your apple developer account email
an app-specific password generated at https://appleid.apple.com/account/manage, here the guide https://support.apple.com/en-us/HT204397
the ProviderShortname  found with xcrun altool --list-providers -u <email> -p <password> with the aformentioned credentials

Then use the following ./afterSign.js:
const fs = require('fs');
const path = require('path');
const electron_notarize = require('electron-notarize');
const { build: { appId } } = require('./package.json');

module.exports = async params => {
    if (process.platform !== 'darwin')
        throw new Error('You can build MacOS .app only on MacOS.');

    const appPath = path.join(params.appOutDir, `${params.packager.appInfo.productFilename}.app`);
    if (appPath.includes('/dist/win')) {
        console.log(`skipping notarization for ${appPath}`);
        return;
    }

    if (!fs.existsSync(appPath))
        throw new Error(`Cannot find application at: ${appPath}`);

    console.log(`Notarizing ${appId} found at ${appPath}`);

    try {
        await electron_notarize.notarize({
            appBundleId: appId,
            appPath: appPath,
            appleId: 'xxx', // apple developer email
            appleIdPassword: 'xxx',
            ascProvider: 'xxxx',
        });
    }
    catch (error) {
        console.error(error);
    }

    console.log(`Done notarizing ${appId}`);
};

Hope this helps.

Amazing! @damianobarbati  that worked great! I just needed to add the ascProvider: to my notarize script!

Confirm, it worked for me too. Thanks @damianobarbati .

Really nice. Helped me a lot! Thx


waitForTransactionFinalization now returns a BlockItemSummary

Purpose
See #166.
Checklist

[x] My code follows the style of this project.
[x] The code compiles without warnings.
[x] I have performed a self-review of the changes.
[x] I have documented my code, in particular the intent of the
hard-to-understand areas.
[x] (If necessary) I have updated the CHANGELOG.

Should we rename the function to wait_until_finalized to be more consistent with the RustSDK?

I don't really think we need to. @soerenbf did you agree or did you not read the comment? upside_down_face

He agreed with you, so we keep it as is