🚀 Feature: Allow to set timeout on before/after/beforeEach/afterEach in declaration

Feature Request Checklist

[X] I have read and agree to Mocha's Code of Conduct and Contributing Guidelines
[X] I have searched for related issues and issues with the faq label, but none matched my issue.
[ ] I want to provide a PR to resolve this

Overview
it returns a TestFunction that has a timeout method. This is useful for setting timeouts in slow tests, without needing to define the test code inside a function() {} block.
An analogous feature would be useful for the before/beforeEach/after/afterEach hooks. The current workaround would be:
before(function() {
  this.timeout(3000);
});

Suggested Solution
before/beforeEach/after/afterEach could return a HookFunction, analogous to TestFunction, which has a timeout method. The code above could be rewritten:
before(() => {}).timeout(3000);

Alternatives
None
Additional Info
No response

👍 Agreed, I'm surprised they didn't have this already! This took me a bit to parse through as someone who doesn't use those APIs much. Putting a summary here for clarity...
There are two ways to describe a timeout:

this.timeout(...);: allowed for hooks (before(...), etc.) as well as tests (it(...), etc.)
test.timeout(...): only allowed for tests

Assuming I'm understanding correctly, this issue is asking to allow hook.timeout(...). Doing so would mirror the test.timeout(...) already allowed.

@JoshuaKGoldberg thanks for summarizing it more clearly than the original post 🙂
ok, I just looked into the codebase, and I think this will be very simple to implement, but I am not sure about potential implications. I will send a PR shortly


Remove /security/ alias for ko translation

This will need to be cherry picked back to 1.16/1.17

@kubernetes/sig-docs-ko-owners @zacharysarah

Preview looks good.
https://deploy-preview-18132--kubernetes-io-master-staging.netlify.com/docs/reference/issues-security/security/
/lgtm
/approve

@cblecker Thanks for this fix! ✨ For the duration of the 1.17 release, PRs to master fix 1.17 content. If you open The same PR against release-1.16, I’m happy to approve it also.

@zacharysarah Done! Opened #18134


Nice library

Hi @srghma , nice library! I was looking for exactly this, and here it is. What's the condition of this library? Are you using it? Does it work? Are you going to publish to Pursuit?

hi @jamesdbrock yes, I'm using it in (future production) project https://github.com/srghma/purescript-halogen-nextjs
I am not going to publish to pursuit my libs (you can find them in https://github.com/srghma/my-purescript-package-sets) since:

publising projecess may change soo, they want to discontinue using bower
my other libs are not stable, will publish all at once

update: I have published almost all of my libs except this one
seems like core team wants to include it https://github.com/purescript-web/purescript-web-html/issues/26#issuecomment-616228777
TODO: close this issue when this happens


Wonder why you don't use component name in metric name

I wonder why you decided to report component name as a custom property, not as part of the metric name here: https://github.com/anastasiia-zolochevska/react-appinsights/blob/master/src/components/TrackedComponent.js#L31
It is not wrong, I'm just curious

First of all to be able to group by Component Name. And if I'm not mistaken AI has limitation for the  amount of custom metrics.

The same limitation applies to the cardinality of a custom property. However we are working on removing this limitation. So consider using metric name, not custom property please

Hi @SergeyKanzhelev! Any updates on this issue two years later..? Would you still stand by this recommendation?
(In the meantime I've released v2.0.0, with some maintenance changes)


Ownership change breaks interpolated fields

Version Number and Operating System(s):
Master Branch  commit 8d131e0fe9cebade291cd76dcd3f49acfd20b5fa (latest as of today)
Unity 2018.3.0f2
Windwdos 10
Expected behavior:
When ownership changes, interpolated field variables of a networkObject are identical on both the new owner and other connected clients.
Non-interpolated fields work as expected.
Actual behavior:
The variable on the non-owner client is unequal to the value on the owner. However, Interpolation.current holds the correct value from the owner.
See my post on discord (forge-bugs @ 18.01.2019 15:03) for a little more information.
Steps to reproduce:

Setup TestOwnerSwitch with the Forge Network Contract Wizard with a field rotation - Quaternion - Interpolate Checked - 0.15 and another field rotationNoInterp - Quaternion - Interpolate Unchecked
Create a script named OwnerSwitchTester.cs with the content of the attached txt file.
OwnerSwitchTester.txt
Setup a forge networked game with two clients and spawn one GameObject with the OwnerSwitchTester script attached to it on the server.
Try either case:
4.1 Press 1 on the client, then press 2 on the server.
4.2 Press 2 on the client, then press 3 on the server.
The output on the client shows a wrong value for rotation = ... on the non-owner client. The interp = and rotationNoInterp = ... values are correct.

p.s. I use Log Viewer from DREAMMAKERSGROUP from the unity asset store to show the output log of a build game.
[Optional] Discord Username:
Adrian_H

Would it be possible to proved a simple project that reproduces the issue @adrianhoppe ?

Hey,
sadly right now I am very busy with work and won't be able to provide you a minimal working project.
The project where we found the issue is way too large to strip down. However, I hope that the steps to reproduce are detailed enough to replicate the issue.
Best,
Adrian


How to use v2 with  @nomicfoundation/hardhat-toolbox ?

Hi there, I can see you upgraded ethers v5 to v6 in v2, which is highly needed for deduping package.
However, @nomicfoundation use the obselete outdated v1 version.
I have tried to force install the v2 instead of v1, but it seem incompatible.
How do you guy use hardhat-gas-reporter@2 ? Do you have any top so I can use it with the toolbar ?
Thanks
Link https://github.com/NomicFoundation/hardhat/issues/5795

@kopax Does this fix itself if you completely uninstall the gas-reporter (e.g make sure neither version is in your dependency tree) and then only install the latest?
Another approach is suggested in #229, where you can use npm's overrides, or yarn's resolutions features to specify which version to install by adding the relevant key below to your package.json:
npm
"overrides": {
    "hardhat-gas-reporter": "^2.2.1"
  }

yarn
"resolutions": {
    "hardhat-gas-reporter": "^2.2.1"
  }

Hi @cgewecke and thanks for your reply. I just pinned the hardhat-gas-reporter version to latest, and so far I do not see regression (your first suggestion). However, I am not if later i use more feature from hardhat-toolbox if it will become buggy.
Are all the interface the same ? I wish they could upgrade hardhat-toolbox with the latest version, but no one poped yet in the opened issue on their repository.

@kopax

if later i use more feature from hardhat-toolbox if it will become buggy...are all the interface the same ?

Yes, it should be ok. There were no relevant API changes in the gas reporter between v1 and v2 and the toolbox basically just imports a set of plugins - I think it's meant to make people's hardhat.config.ts look cleaner and be convenient to set up.
You might see peer dependency warnings from npm when installing since the toolbox lists v1 as a peer here, but that's all.


Error: No available model

Help me with it now what to do.
......
Thanks admin .
.......

Aichat already explains what happened; the clients field in the config.yaml is invalid.
Two Methods:

Delete config.yaml and run it again; let aichat help you create config.yaml.
Edit config.yaml manually, following https://github.com/sigoden/aichat/blob/main/config.example.yaml


In Creative Effect autoplay does not work after second slide

Check that this is really a bug

[X] I confirm

Reproduction link
https://codesandbox.io/p/live/d4f2a4c6-dc05-44ed-9f57-05d16e2d2ba3
Bug description
It appears that there is a concern with the autoplay functionality in the Swiper.js library when used with React, specifically within the context of a Creative Effect. The problem manifests itself as the autoplay feature ceasing to function properly after the transition to the second slide.
Expected Behavior
No response
Actual Behavior
No response
Swiper version
11.0.5
Platform/Target and Browser Versions
Windows
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

Can't replicate the issue, and the link you have provided leads to the "404 not found" page

Sorry @nolimits4web  , can you try this link
https://codesandbox.io/p/devbox/bold-varahamihira-hsjx8v?layout=%257B%2522sidebarPanel%2522%253A%2522EXPLORER%2522%252C%2522rootPanelGroup%2522%253A%257B%2522direction%2522%253A%2522horizontal%2522%252C%2522contentType%2522%253A%2522UNKNOWN%2522%252C%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522id%2522%253A%2522ROOT_LAYOUT%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522UNKNOWN%2522%252C%2522direction%2522%253A%2522vertical%2522%252C%2522id%2522%253A%2522clrrppqqs0007356gtd7z65lc%2522%252C%2522sizes%2522%253A%255B70%252C30%255D%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522EDITOR%2522%252C%2522direction%2522%253A%2522horizontal%2522%252C%2522id%2522%253A%2522EDITOR%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522EDITOR%2522%252C%2522id%2522%253A%2522clrrppqqs0003356g4hjfee91%2522%257D%255D%257D%252C%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522SHELLS%2522%252C%2522direction%2522%253A%2522horizontal%2522%252C%2522id%2522%253A%2522SHELLS%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522SHELLS%2522%252C%2522id%2522%253A%2522clrrppqqs0004356gd5zgzeoc%2522%257D%255D%252C%2522sizes%2522%253A%255B100%255D%257D%255D%257D%252C%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522DEVTOOLS%2522%252C%2522direction%2522%253A%2522vertical%2522%252C%2522id%2522%253A%2522DEVTOOLS%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522DEVTOOLS%2522%252C%2522id%2522%253A%2522clrrppqqs0006356gp1anhxy5%2522%257D%255D%252C%2522sizes%2522%253A%255B100%255D%257D%255D%252C%2522sizes%2522%253A%255B50%252C50%255D%257D%252C%2522tabbedPanels%2522%253A%257B%2522clrrppqqs0003356g4hjfee91%2522%253A%257B%2522tabs%2522%253A%255B%257B%2522id%2522%253A%2522clrrppqqs0002356g9p51hufb%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522FILE%2522%252C%2522filepath%2522%253A%2522%252Fsrc%252FApp.jsx%2522%252C%2522state%2522%253A%2522IDLE%2522%252C%2522initialSelections%2522%253A%255B%257B%2522startLineNumber%2522%253A21%252C%2522startColumn%2522%253A1%252C%2522endLineNumber%2522%253A21%252C%2522endColumn%2522%253A1%257D%255D%257D%252C%257B%2522id%2522%253A%2522clrrr09mn0002356fwkhnx2eu%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522FILE%2522%252C%2522initialSelections%2522%253A%255B%257B%2522startLineNumber%2522%253A5%252C%2522startColumn%2522%253A24%252C%2522endLineNumber%2522%253A5%252C%2522endColumn%2522%253A24%257D%255D%252C%2522filepath%2522%253A%2522%252Fpackage.json%2522%252C%2522state%2522%253A%2522IDLE%2522%257D%255D%252C%2522id%2522%253A%2522clrrppqqs0003356g4hjfee91%2522%252C%2522activeTabId%2522%253A%2522clrrr09mn0002356fwkhnx2eu%2522%257D%252C%2522clrrppqqs0006356gp1anhxy5%2522%253A%257B%2522id%2522%253A%2522clrrppqqs0006356gp1anhxy5%2522%252C%2522tabs%2522%253A%255B%257B%2522type%2522%253A%2522TASK_PORT%2522%252C%2522taskId%2522%253A%2522dev%2522%252C%2522port%2522%253A5173%252C%2522id%2522%253A%2522clrrpw9560051356flxv79cbv%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522path%2522%253A%2522%252F%2522%257D%255D%252C%2522activeTabId%2522%253A%2522clrrpw9560051356flxv79cbv%2522%257D%252C%2522clrrppqqs0004356gd5zgzeoc%2522%253A%257B%2522id%2522%253A%2522clrrppqqs0004356gd5zgzeoc%2522%252C%2522activeTabId%2522%253A%2522clrrpw5lc003f356fd88i2hy7%2522%252C%2522tabs%2522%253A%255B%257B%2522type%2522%253A%2522TASK_LOG%2522%252C%2522taskId%2522%253A%2522dev%2522%252C%2522id%2522%253A%2522clrrpw5lc003f356fd88i2hy7%2522%252C%2522mode%2522%253A%2522permanent%2522%257D%255D%257D%257D%252C%2522showDevtools%2522%253Atrue%252C%2522showShells%2522%253Atrue%252C%2522showSidebar%2522%253Atrue%252C%2522sidebarPanelSize%2522%253A14.947916666666671%257D

@nolimits4web  do you mean this
autoplay={{
delay: 2500,
disableOnInteraction: false,
waitForTransition: true,
}}

it needs to be false as you don't use transitions

ok @nolimits4web , it is till stuck on second slide
  grabCursor={true}
        effect={"creative"}
        loop={true}
        autoplay={{
          delay: 2500,
          disableOnInteraction: false,
          waitForTransition: false,
        }}


Ergonomics of head and request modules

Consider merging some of the functions from head.rs into request.rs to offer a more ergonomic approach to getting parameters from a request.
Should these be moved into request.rs from head.rs:

pub fn uri(&self) -> &http::Uri
pub fn path(&self) -> &str
pub fn query(&self) -> Option<&str>
pub fn method(&self) -> &http::Method

A code example would then look more like the following:
async fn get_message(
    mut db: AppData<Database>,
    id: request::Path<usize>,
) -> Result<body::Json<Message>, StatusCode> {
    if let Some(msg) = db.get(id.0) {
        Ok(body::Json(msg))
    } else {
        Err(StatusCode::NOT_FOUND)
    }
}

Instead of:
async fn get_message(
    mut db: AppData<Database>,
    id: head::Path<usize>,
) -> Result<body::Json<Message>, StatusCode> {
    if let Some(msg) = db.get(id.0) {
        Ok(body::Json(msg))
    } else {
        Err(StatusCode::NOT_FOUND)
    }
}

Sorry for the confusion.  To simplify, in most frameworks, you interact with a "request" type object to get data like path, method, query, etc.
So I am suggesting that maybe we figure out a way to make a call like:
head::Path<usize>
look like
request::Path<usize>
Maybe it is no big deal, but just considering being consistent with many other frameworks from other languages I have experienced in the past.

Got it, makes perfect sense!

this issue seems no longer relevant. The function signatures have changed but users do now interact with a Request type that is no longer tied to http. If I missed something here, I think opening a new issue that's geared to what tide is like today would be better


Using regular Google calendars

Reference #25
Using regular Google calendars in addition to resource calendars would open this application for more users. Then it wouldn't be required to have Google apps for business or Google apps for education anymore for this application to work.

Issue solved with PR #44


RN method roundToNearestPixel is not used

Hi @DaniAkash,
your solution is good, I use a very similar one for my RN projects. The difference from my solution is that I use roundToNearestPixel RN method that rounds a layout size (dp) to the nearest layout size that corresponds to an integer number of pixels. And I was about to create a npm package of my own until I saw yours.
I would be happy to provide a PR, if you are actively maintaining this package :)
Thanks

@DaniAkash any updates?
Thanks

Thanks @marudy PRs are welcome. I'll be publishing a new release soon


[Do not merge] testing 1744

Merged in https://github.com/cython/cython/commit/749d07b9c1eee8751c690967dc48bdd11c0cfc06


Contract interactions

These exercises will teach how to perform interactions with other contracts and libraries on Starknet.
They will cover

Contract Dispatcher and Library Dispatchers
call_contract syscall

@enitrat Seems like this might be included in exercise starknet5?

yes indeed

Sweet, closing this one then. Let me know if we needed something else for this too.


Docker scripts for containing OHS <IP_ADDRESS>.0 installation

Are you removing the <IP_ADDRESS> image?  Both <IP_ADDRESS> and <IP_ADDRESS> images should both be in GitHub.


Low performance for a GeoJSON with a total of 68,921 vertices

Describe the bug
When loading a GeoJSON of 7882 MultiPolygons with a total of 68,921 vertices, the OpenLayers map becomes very slow to navigate.
Considering OpenLayers can handle LineStrings with 700,000+ vertices, it seems like rendering this amount of vector data should not cause performance issues.
To Reproduce
Steps to reproduce the behavior:

Go to https://github.com/erwinkn/openlayers-vector-performance.git
Clone the repository and run npm install in the root folder
Run npm dev and navigate to http://localhost:5173/
Move around the map

Expected behavior
The map is smooth to navigate.
Note: there are quite a lot of exactly overlapping MultiPolygon in that GeoJSON, as it was naively created from a dataset that has multiple rows linked to the same area. I don't know whether this could be the source of the performance issue, but I thought I'd mention it.

LineStrings are simplified on-the-fly; points that result in less than 0.5 pixel distance are simply omitted. Although for each Polygon at least two points are drawn.
In the example you linked only one LineString exists and it can be simplified very efficiently.
In your example there are lots of low-res polygons which cannot be simplyfied much further so there is not much reduction in data. And as you noted the dupilcate polygons are also detrimental.
For increased performance you can try the new (experimental) webgl renderer for lines and polygons as in https://openlayers.org/en/latest/examples/webgl-vector-layer.html
import { Map, View } from "ol";
import TileLayer from "ol/layer/Tile";
import { OSM, Vector as VectorSource } from "ol/source";
import GeoJSON from "ol/format/GeoJSON";
import WebGLVectorLayerRenderer from "ol/renderer/webgl/VectorLayer";
import Layer from "ol/layer/Layer";
import { packColor } from "ol/renderer/webgl/shaders";
import "ol/ol.css";

class WebGLLayer extends Layer {
  createRenderer() {
    return new WebGLVectorLayerRenderer(this, {
      fill: {
        attributes: {
          color: function (feature) {
            return packColor([255, 255, 255, 0.2]);
          },
        },
      },
      stroke: {
        attributes: {
          color: function (feature) {
            return packColor([0, 0, 200, 0.8]);
          },
          width: function () {
            return 1.5;
          },
        },
      },
    });
  }
}

async function renderMap() {
  const res = await fetch("/electricity_prices.json");
  const data = await res.json();

  const view = new View({
    center: [0, 0],
    zoom: 1,
  });

  const features = new GeoJSON().readFeatures(data, {
    dataProjection: "EPSG:4326",
    featureProjection: "EPSG:3857",
  });

  const source = new VectorSource({
    features,
  });
  new Map({
    target: "map",
    layers: [
      new TileLayer({
        source: new OSM(),
      }),
      new WebGLLayer({ source }),
    ],
    view,
  });

  view.fit(source.getExtent());
}

renderMap();

Alternatively, you can use an ol/layer/VectorImage instead of an ol/layer/Vector. Or use geojson-vt, like shown in the https://openlayers.org/en/latest/examples/geojson-vt.html example.

Thanks for the suggestions! geojson-vt and the experimental WebGL renderer seem to be the best option for my use case.
I have updated my test repository to showcase a comparison between a simple vector layer, a vector tile layer with geojson-vt, a WebGL vector layer and the same dataset in MapLibre GL (which also uses WebGL).
In case anyone's interested, here's a live deployment: https://openlayers-vector-performance.vercel.app/


Convert Speaker Recognition Pre trained Pytorch Model to CoreML model to support in iOS

I am trying to convert the Speaker recognition Pytorch model(.pt) to CoreML (.mlmodel) to integrate in an iOS app.
I followed the steps mentioned in the official tutorial video:
Convert PyTorch models to Core ML : Apple Developer Tech Talk
But the scripts are getting failed with multiple reasons.
Question 1: Is it really possible to convert this model to CoreML Model?
Question 2: If so, can someone help me in converting so?

@robin1001 @cdliang11 Do you have related experiences?

Sorry, I don't have related experience.

@cdliang11
I tried using CoreML Tools, as the onnx-coreml is deprecated.
I have used export_jit.py as reference and tried both Tracing and scripting approaches using coremltools.
I am not sure how to correctly pass the input parameters for trace and convert functions.
from __future__ import print_function

import argparse
import os

import torch
import yaml
import coremltools as ct

from wespeaker.models.speaker_model import get_speaker_model
from wespeaker.utils.checkpoint import load_checkpoint

def get_args():
    parser = argparse.ArgumentParser(description='export your script model')
    parser.add_argument('--config', required=True, help='config file')
    parser.add_argument('--checkpoint', required=True, help='checkpoint model')
    parser.add_argument('--output_file', required=True, help='output file')
    parser.add_argument('--tracing', default=True, action=argparse.BooleanOptionalAction)
    args = parser.parse_args()
    return args

def main():
    args = get_args()
    # No need gpu for model export
    os.environ['CUDA_VISIBLE_DEVICES'] = '-1'

    with open(args.config, 'r') as fin:
        configs = yaml.load(fin, Loader=yaml.FullLoader)
    model = get_speaker_model(configs['model'])(**configs['model_args'])
    print("model Loaded successfully")

    load_checkpoint(model, args.checkpoint)
    model.eval()

    # Tracing approach
    if args.tracing:

        print('Using Tracing approach')

        example_input = torch.rand(1, 3, 64, 64)
        traced_model = torch.jit.trace(model, example_input)

        mlmodel = ct.convert(traced_model, inputs=[ct.TensorType(name="input", shape=example_input.shape)], minimum_deployment_target=ct.target.iOS13)
        mlmodel.save(args.output_file)

        print('Export model successfully, see {}'.format(args.output_file))

    else:
        print('Using scripting aproach')

        scripted_model = torch.jit.script(model)

        mlmodel = ct.converters.convert(scripted_model, inputs=[ct.TensorType(shape=(1, 3, 64, 64))], minimum_deployment_target=ct.target.iOS13)
        mlmodel.save(args.output_file)

        print('Export model successfully, see {}'.format(args.output_file))

if __name__ == '__main__':
    main()

Tracing approach error

Scripting approach error

The dimension of example_input is 3, egs: example_input= [1,200,80]

@akshaydevelops
Assuming you are using the resnet model and the pooling function is TSTP (pooling_func: "TSTP"). Then modify the class TSTP(nn.Module) in wespeaker/models/pooling_layers.py to the following code:
class TSTP(nn.Module):
    """
    Temporal statistics pooling, concatenate mean and std, which is used in
    x-vector
    Comment: simple concatenation can not make full use of both statistics
    """

    def __init__(self, in_dim=0, **kwargs):
        super(TSTP, self).__init__()
        self.in_dim = in_dim

    def var(self, x, dim, keepdim=False):
        input_means = torch.mean(x, dim=dim, keepdim=True)
        differences = x - input_means
        squared_deviations = torch.square(differences)
        variance = torch.mean(squared_deviations, dim=dim, keepdim=keepdim)
        return variance

    def forward(self, x):
        # The last dimension is the temporal axis
        pooling_mean = x.mean(dim=-1)
        # pooling_std = torch.sqrt(torch.var(x, dim=-1) + 1e-7)
        pooling_std = torch.sqrt(self.var(x, dim=-1) + 1e-7)

        pooling_mean = pooling_mean.flatten(start_dim=1)
        pooling_std = pooling_std.flatten(start_dim=1)
        stats = torch.cat((pooling_mean, pooling_std), 1)
        return stats

    def get_out_dim(self):
        self.out_dim = self.in_dim * 2
        return self.out_dim

Similar modifications can be made to other code that uses torch.var() or tensor.var().

@cdliang11 I'm assuming the above changes requires the model to be rebuild and train the model again.
as per https://github.com/apple/coremltools/issues/1203#issuecomment-2048023128, There's a way where we can use the custom var function during the export, using @register_torch_op() from https://apple.github.io/coremltools/docs-guides/source/composite-operators.html#using-composite-ops-with-pytorch-conversion
Can we do something like below for the var function implementation, which will not require the entire model recreation.?
@register_torch_op()
def var(context, node):
    inputs = _get_inputs(context, node, expected=4)
    x = inputs[0]
    axes = inputs[1].val

    # Ensure axes is a list of integers, e.g., [2, 3] for the last two dimensions (Change #3)
    assert isinstance(axes, list) and all(isinstance(axis, int) for axis in axes)

    # Assert we can have biased divisor (N). (Change #1)
    assert(inputs[2].val == False)

    keepdim = True  # Set keepdim to True for broadcasting (Change #2)

    x_mean = mb.reduce_mean(x=x, axes=axes, keep_dims=keepdim)
    x_sub_mean = mb.sub(x=x, y=x_mean)  # Broadcasting should work here (Change #4)
    x_sub_mean_square = mb.square(x=x_sub_mean)
    x_var = mb.reduce_mean(x=x_sub_mean_square, axes=axes, keep_dims=keepdim)

    context.add(x_var, torch_name=node.name)

Hey @cdliang11 , @wsstriving
I'm able to export the Pytorch model to CoreML Model using the below torch operation.
@register_torch_op()
def var(context, node):
    inputs = _get_inputs(context, node, expected=4)

    x = inputs[0]
    axes = inputs[1].val
    keepdim = True

    x_mean = mb.reduce_mean(x=x, axes=axes, keep_dims=keepdim)
    x_sub_mean = mb.sub(x=x, y=x_mean)
    x_sub_mean_square = mb.square(x=x_sub_mean)
    x_var = mb.reduce_mean(x=x_sub_mean_square, axes=axes, keep_dims=keepdim)

    context.add(x_var, torch_name=node.name)

Can someone help me on passing the task, audio_file & audio_file2 inputs to CoreML Model using the MultiArray(Float32 1 × 200 × 80)?

Hey @cdliang11 , @wsstriving
I'm able to export the Pytorch model to CoreML Model using the below torch operation.
@register_torch_op()
def var(context, node):
    inputs = _get_inputs(context, node, expected=4)

    x = inputs[0]
    axes = inputs[1].val
    keepdim = True

    x_mean = mb.reduce_mean(x=x, axes=axes, keep_dims=keepdim)
    x_sub_mean = mb.sub(x=x, y=x_mean)
    x_sub_mean_square = mb.square(x=x_sub_mean)
    x_var = mb.reduce_mean(x=x_sub_mean_square, axes=axes, keep_dims=keepdim)

    context.add(x_var, torch_name=node.name)

Good to know you've finally found a workaround! Currently, the ncnn branch supports the replacement of the var operation. You can take a look at it.
By the way, it would be great if you could help make a pull request for Apple platform support. Thank you very much!


Lun 264 create locking lane for unlocking exercises

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword LUN.

Please remove these line-svgs. You should create Views which are only few px wide and have a dynamic/appropriate height. E.g. like here https://www.w3schools.com/howto/howto_css_vertical_line.asp

If you need some help by explaining things like css and how to create such a progress bar or async functions just contact me via mattermost


Support SwiftLint

We'd like to automatically run SwiftLint against PRs on Travis.  Would it be possible for this to be done via Package-Builder?

This should be possible. We will look into it hopefully soon.

That's fine - thanks @rolivieri

@BDHernand Here's the link: https://github.com/realm/SwiftLint. There's already a swiftlint file in the PackageBuilder repo.

@ianpartridge We noticed there is a swiftlint file in some of the Kitura repos. I had thought the purpose of having the swiftlint file in the PackageBuilder repo was 1) to avoid having to check in a swiftlint file in every Kitura repo and 2) to ensure that the same set of rules (in the single swiftlint file) is applied to all Kitura repos. Has this changed? Are you guys planning on using a different approach?

We'd like to remove the swiftlint files from Kitura repos and use a common file in PackageBuilder.

@ianpartridge i started to enable swiftlint in package builder and have it pointed to the .swiftlint.yml file in the Package-Builder directory.  I was using my Forked version of Kitura which I had did a pull from the master branch to bring it up to date.  I got the following from swiftlint
Done linting! Found 632 violations, 12 serious in 54 files.

@ianpartridge should the .swiftlint file be changed or is it good to go?

I ran it again locally with the .swiftlint.ym file in the Kitura directory and got
Done linting! Found 2573 violations, 83 serious in 115 files.
which swiftlint file should we use?

We should use the one in Package-Builder. We still need to go through and fix the violations which couldn't be fixed by the auto-correcter.
I've deleted the one in Kitura.
Thanks!

Some of the issues we are having with swiftlint is the following:
line_length:  Some test files have JSON strings that are over a certain length producing errors being returned.  These are mainly in the test files.  Should we exclude these in the swiftlint.yml file?
cyclomatic_complexity:  Some files have a lot of case statement/if checks in the functions which are causing errors in swiftlint.  Currently if it is more than X it will error out
function_parameter_count: if it is more than 5 swiftlint errors out

some changes that are going to be added to the functionality:

Only the Sources directory will be linted.
If the root repo directory contains a .swiftlint.yml file then the package builder will use that to override the default rule file located in package builder.  This will give the repo owner the ability to disable some lint rules that they may not be able to correct without breaking people.

line_length: Yes, let's exclude these files
cyclomatic_complexity: Exclude this test?
function_parameter_count: What's the list of functions that error? We should review them.

@ianpartridge we change the package builder swift lint yml file for line length to give a warning after 250 and error out after 500 characters.  We have not disabled the cyclomatic_complexity or the function_parameter_count

@ianpartridge do you have an ETA on the Kitura repositories being ready for us to merge the swiftlint branch into master?


Fix link

Description
Fixes link to websocket example
Reference issue
Fixes #...

Pull Request Test Coverage Report for Build 2679

0 of 0   changed or added relevant lines in 0 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 79.811%

Files with Coverage Reduction
New Missed Lines
%

dtlstransport.go
4
78.57%

Totals

Change from base Build 2676:
-0.2%

Covered Lines:
3123

Relevant Lines:
3913

💛  - Coveralls

Thanks for fixing this @simonacca-fotokite
Would you mind adding yourself to the list of contributors in the README? Thank you!

Merged with 79d29886d9dd508badb0610bf687ff2f78be25bf
Thanks for contributing to Pion @simonacca-fotokite :)


[BUG] When I use the camera to take a picture, after I tap the confirm button, it asked me to authorize the photo library, it's ridiculous. I just want to use camera, no need to save it to my photo library.

Describe the bug
When I use the camera to take a picture, after I tap the confirm button, it asked me to authorize the photo library, it's ridiculous. I just want to use camera, no need to save it to my photo library.
How to reproduce
CameraPicker.pickFromCamera(
context,
pickerConfig: CameraPickerConfig()).then((value) {
print(value);
})
Steps to reproduce the behavior:

Go to 'pickFromCamera'
Click on 'take a picture'
Scroll down to 'confirm' and deny to access the photo library.
Got nothing.

Expected behavior
After I authorized the Camera,  Even though I denied the photo library, I should take the picture anyway.
Version information

Device: [iPhone X]
OS: [iOS 17.0]
Package Version: [4.0.2]
Flutter Version: [3.13.x]

iOS如果只给部分相册访问权限时，拍照或拍视频保存时会报错没有权限。

Use onEntitySaving to override the default behavior.


[YUNIKORN-3002] Update Go dependencies for CVE fixes

What is this PR for?
Update Go dependencies for CVE fixes

golang.org/x/crypto from v0.26.0 to v0.31.0
golang.org/x/net from v0.28.0 to v0.33.0

What type of PR is it?

[ ] - Bug Fix
[x] - Improvement
[ ] - Feature
[ ] - Documentation
[ ] - Hot Fix
[ ] - Refactoring

What is the Jira issue?
YUNIKORN-3002
How should this be tested?
Successfully passed the unit test locally
Screenshots (if appropriate)
Questions:

[ ] - The licenses files need update.
[ ] - There is breaking changes for older versions.
[ ] - It needs documentation.

@blueBlue0102 Could you please check the CI error. Thanks!

Should just need to run 'go mod tidy' before pushing.


Border Radius on ct-grids

Hello, awesome job on charts!
Is there any option to put border radius on .ct-grid-background?
Or maybe stroke-linejoin="round" on path.
My example: http://mlimasolucoes.com.br/etalent/chartist/ i want border radius on background

solved by:
var addedEvents = false;
normalChart.on('draw', function() {
if (!addedEvents) {
$(".ct-grid-background").attr("rx",10);
$(".ct-grid-background").attr("ry",10);
}
});

Oh, that's good to know. If you solved it and don't need further help, please close this issue.


Add code lint?

@robertrosman
I don't know how to add code lint or format to project. Like prettier.
This keeps our code style consistent and avoids conflicts caused by formatting.
Would you help me do this.

In fact, I am a back-end programmer, and I don’t know much about plug-ins like eslint.
😄

Sure I can have a look, it's usually pretty straight forward 👍

Sure I can have a look, it's usually pretty straight forward 👍

So great, I resolve some error of lint and pr.yml, it works.


SQL Dao reponse

Function SQLTools.getConnection is very long after a long time idle.
Launch App.
Do nothing 2-3 min.
Click on "Collections".

add pooling management


Enable sqlite/bundle for diesel cli

Trying to install the CLI on windows can be problematic, when creating a project you can just import the libsqlite3-sys feature but you can't do that when installing the cli tools. With this change you can install on Windows (or other platforms without an easy way of installing sqlite3).
Installation can be achieved using this: cargo install diesel_cli --no-default-features --features sqlite-bundled

Is this better? Also should I add this to the appveyor script?

Appveyor is already too slow, but I do think it's worth adding an additional matrix entry for this on Travis. I would like to hear input from @killercup and @Eijebong on that though.

What needs to get this PR over the hump and merged? 😄

This is a killer on windows.  What needs to be done?

The comments that have been left on this PR need to be addressed.

Applying the diff I posted earlier to this PR addresses the last outstanding comment (the environment var looks to be already taken care of). If desired, I can simply open a new PR with applied diff to this PR.

Feel free to open a new PR, please leave the original author's commits in
tact if you do
On Tue, May 1, 2018 at 9:36 AM Nick Babcock<EMAIL_ADDRESS>wrote:

Applying the diff
https://github.com/diesel-rs/diesel/pull/1302#issuecomment-378414844 I
posted earlier to this PR addresses the last outstanding comment (the
environment var looks to be already taken care of). If desired, I can
simply open a new PR with applied diff to this PR.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/diesel-rs/diesel/pull/1302#issuecomment-385701919,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABdWKwwMzpnyodCzYNEnQs2KqofbTKT_ks5tuIDsgaJpZM4QcWmU
.

#1672 finished this


Brought this over from the main branch.

Added a link to the wiki page on Craft setup.

Bunch of edits put into the wiki page to resolve issues mentioned #403, and plugin install/usage info from craft extra readme. Thanks to @CosminAnca for the help!


Use clang-format in CI to ensure consistent formatting across developer submissions.

To proceed on this:

Need to decide on what version of clang-format to use.  Yes, this matters (slightly) because different major versions of clang-format format differently.  macOS 10.12 seems to have version 6.0.0.  You would want to document this in a CONTRIBUTING.md.  We also would want to match the version running on the CI machine.  While it may be possible to install a specific version on the CI machine, it may be good to know what version is already there.  (I tried to submit a Travis job from my fork to query this, but Travis seems to be having trouble displaying logs at the moment.)

Need to decide on clang-format parameters and put them in a .clang-format file at the top of the repo.  This is where you get to pick a basic style (e.g., LLVM or Google) and make tweaks such as line length and tab size.  You can look at other repos for ideas and/or try to match any existing style in the code base.  Check this file into the repo.

Get the current repo formatted.  You would do this by running clang-format (using -style=file) on all the sources in the repo and commit.  It probably would have been better to do this and the preceding steps before going public, but there's little that can be done about that.  This does introduce a "format only" commit that will show up often in "git blame" type searches in the code base, but that would have to be tolerated.

Add the CI plumbing to check that incoming PRs are formatted.  (The point of this issue).  As an example, this was added with KhronosGroup/Vulkan-LoaderAndValidationLayers@b11b5297c2aecc4c2a53079918f46bca7f3a7c02.  I'd be happy to do this part of it once the able steps are done.

Travis got healthy again.   clang-format is not installed by default, but is easily installed with brew, and it is version 6.0.0.


http://localhost:4000

is it me or API doesnt work?
lynx  <IP_ADDRESS>:4000 gives 404
if i bing api to <IP_ADDRESS>:4000 it 404's
and if i proxy_pass is nginx it is also 404

use <IP_ADDRESS>:4000/api/

Take a look at the wiki page for the API.
it's <IP_ADDRESS>:4000/api/pools/...

Hello,
Thank you everyone for your input.
Because the documentation was pinting to server:4000/api I was lead to believe that /api itself would return values but instead returned a 404 and for some reason, the documented endpoint calls were returning and internal server error.
I restarted Miningcore a few times and was still encountering the same issue.
Finally I just restarted the whole server last night and like magic the issue went away and api was functioning.
I dont know what i was getting an internal server error since it was a fresh install from about two weeks ago and havent changed anything except for the pool configurations.
I believe the api didnt bind correctly because the port had been used by another resource during launch?
Anyway thanks for the help, the issue has been resolved.

It can cause an error or a 404 error if the web server is not configured as a reverse proxy to the api. The miningcore api server is only capable of http communication. If the web interface works on https, port 4000 reverse proxy in nginx configuration (/etc/nginx/sites-enabled/) is required
Example:
server {
    root /var/www/yourdomain/html;

index index.html index.htm index.nginx-debian.html;
    server_name yourdomain;

    location / {

            try_files $uri $uri/ =404;

    	}
    location /api/ {
    proxy_pass http://<IP_ADDRESS>:4000/api/;
		}

Hi,
Thanks for the info. I already have it setup and the website is running.
Thanks!


Update Bamboozled::API::Meta to match API responses from Bamboo

Fix Bamboozled::API::Meta to work with responses from Bamboo Metadata API.

[x] Update implementation
[ ] Add tests

Potentially closes https://github.com/Skookum/bamboozled/issues/36
/cc @spicycode

Coverage decreased (-1.2%) to 84.791% when pulling bf2669977046e0ff5fbbade16628bcc783f597eb on jonmagic:update-meta-api-implementation into 96b837a51cf45ec0dbc84827337d71df3acf080e on Skookum:master.


Deterministic external memory.

Replaces https://github.com/dmlc/xgboost/pull/6317 for addressing comment from @RAMitchell .
Close: #5063
Close: #6307

@RAMitchell I'm not sure if this is better than the previous approach.  In this PR, the data pool is involved even if external memory is not being used. (single batch file).


fix: stderr to support tty (colors in errors)

Problem
stderr didn't support TTY and hence didn't support colors because it was being piped to filter out warnings
closes https://github.com/esbuild-kit/tsx/issues/16
closes https://github.com/esbuild-kit/tsx/pull/20
Changes

Instead of filtering the stderr, use the --require hook to overwrite the process.emit function to filter out the warnings.
This probably has a slight performance improvement too because it's no longer piped

Other info
I would like to add a test for this, but I'm not sure if I can because the tests run tsx in a non-TTY environment.

:tada: This PR is included in version 3.4.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Adds removeAllHydrogenRGroupsAndLabels and fixes kekulization issues

fixed residual kekulization issues when R-labels are removed from aromatic atoms on the core

added removeAllHydrogenRGroupsAndLabels flag, which defaults to True. If set to False,
unused user-defined labels on the core will be retained. If also removeAllHydrogenRGroups
is set to False, all-hydrogen user-defined R-groups will be included in the output.
Under no circumstance dynamically-added R-groups (when onlyMatchAtRGroups=false)
that are all-hydrogen will be included in the output, as that's not useful (change
compared to previous behavior)

added tests for (1), (2) and for removeAllHydrogenRGroups, that had no tests so far

fixed a few documentation typos in the Python code and added some documentation
to the C++ sources

I also refactored UsedLabelMap to be a class rather then yet another obscure std::map<int, std::pair<int, int>> as I think it makes maintenance of this complex code a bit easier.

@jones-gareth : would you mind looking at this one too in order to see if you agree with the changes?

@jones-gareth : would you mind looking at this one too in order to see if you agree with the changes?

The code changes are good, I'm just uncertain about the need for an extra parameter.  Do you see a common scenario where you set removeAllHydrogenRGroups true and removeAllHydrogenRGroupsAndLabels false?  We did have a discussion about that in a previous PR - I think the conclusion was to remove unused R group labels.
There are numerous RGD parameters that result in different code paths that become hard to maintain and test.

@jones-gareth Yes, I do see a use case. As a chemist, if I supply a user-labelled core, I might find it undesirable that some labels disappear from the core that I have supplied, as I might not recognize my own scaffolds anymore. However, I may be happy not to see the H R groups in the results. Setting the additional parameter gives me the flexibility to do so. Also, this has been the RGD behavior until Release 2020.09, and it could be confusing to change it.

@jones-gareth Yes, I do see a use case. As a chemist, if I supply a user-labelled core, I might find it undesirable that some labels disappear from the core that I have supplied, as I might not recognize my own scaffolds anymore. However, I may be happy not to see the H R groups in the results. Setting the additional parameter gives me the flexibility to do so. Also, this has been the RGD behavior until Release 2020.09, and it could be confusing to change it.

OK makes sense.


Uncaught SyntaxError: TypeError

While I was de-obfuscating my code on obf-io.deobfuscate.io My javascript code wouldn't de-obfuscate. Here is the error:
Uncaught SyntaxError: Unexpected token, expected "," (1:138845) (at deobfuscator.js:1:197711)
at c (deobfuscator.js:1:197711)
at e (deobfuscator.js:1:213903)
at on.raise (deobfuscator.js:1:261330)
at on.unexpected (deobfuscator.js:1:261762)
at on.expect (deobfuscator.js:1:266297)
at on.parseExprList (deobfuscator.js:1:439156)
at on.parseArrayLike (deobfuscator.js:1:437299)
at on.parseExprAtom (deobfuscator.js:1:423372)
at on.parseExprSubscripts (deobfuscator.js:1:417892)
at on.parseUpdate (deobfuscator.js:1:417515)

Can you provide the code you were trying to deobfuscate?

Now it works. Thanks.


无法获取七牛下载地址

添加七牛下载链接获取

Coverage decreased (-0.08%) to 79.237% when pulling bf223756ea7fad67449aa3de57c32983bb296c6f on chinachuner:patch-3 into ff07696826cb75c4dd9795cf1038e3c1293014f1 on lisong:master.


ScottPlot5 NET Framework 4.6.2

I want to use ScottPlot5 for signal waveform display, but I found that it does not work under NET Framework 4.6.2; Whether I drag and drop controls or generate controls, he always reports an error. Does ScottPlot5 currently not support the NET Framework 4.6.2 environment; I work normally under NET7.0 with the same configuration; Compiled class library, check Support for NET Framework 4.6.2. What should I do? ScottPlot5 can work in the NET Framework 4.6.2 environment,

Hi @yizushijie, thanks for reporting this!
I googled for system.runtime.interopservices.comexception 0x80004005 and found some interesting pages reporting a similar error

https://github.com/MicrosoftEdge/WebView2Feedback/issues/978
https://learn.microsoft.com/en-us/answers/questions/433127/my-program-works-correctly-within-the-visual-studi
https://community.esri.com/t5/water-resources-questions/i-am-having-this-error-while-using-arch-hydro-and/td-p/672997

I think the solution may be to ensure you are using the latest version of Visual Studio! Note that Visual Studio 2023 community is free for small projects and open source developers.


1.9.4 Gui issue

Issue Description:
Note: If this bug occurs in a modpack, please report this to the modpack author. Otherwise, delete this line and add your description here. If you are using an unreleased version of Ender IO (e.g. for 1.8.9), please don't open an issue for features that have not been announced as "finished" or "working".
its the Knoxz 1.9 Testpack but it is reproducable with just enderio/ender core
What happens:
Phantom items in hotbar
What you expected to happen:
Shouldnt be hapening
https://gyazo.com/8105ab677be6b3546d0e90f732f37d2b
Steps to reproduce:

Open a slice and splice

Affected Versions (Do not use "latest"):

EnderIO: 1.9.4-<IP_ADDRESS>.40_alpha

EnderCore: <IP_ADDRESS>.4.0.24-alpha

Minecraft: 1.9.4

Forge:

Your most recent log file where the issue was present:
NA
i know 1.9.4 is unfinished but i wanted to report just in case this wasnt known

thx, fixed in next build


Feature Request : Use new Anthropic Prompt Caching feature

hi,
I received this documentation : https://docs.anthropic.com/en/docs/build-with-claude/prompt-caching
This new feature allow to cache a context so we spend less.
It requires to add a new message in system part.
what do you think ?
Thank you

Hey @numerogeek, yes it can be a good feature. Do you want to contribute?


Release 4.2.0

The pip's release is on the way. Let's release pip-tools then!
See https://github.com/pypa/pip/issues/6993

Since #911, the next releases should be done via PR (which is excellent!).
$ git push upstream master
Enumerating objects: 5, done.
Counting objects: 100% (5/5), done.
Delta compression using up to 8 threads
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 679 bytes | 679.00 KiB/s, done.
Total 3 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2), completed with 2 local objects.
remote: error: GH006: Protected branch update failed for refs/heads/master.

> remote: error: At least 1 approving review is required by reviewers with write access.

To github.com:jazzband/pip-tools.git
 ! [remote rejected] master -> master (protected branch hook declined)
error: failed to push some refs to 'git@github.com:jazzband/pip-tools.git'

TODO: update "Project Release Process" in CONTRIBUTING.md.

@davidovich thanks! I'll cancel CIs and merge this then.

🎉

I've uploaded the release on the jazzband PyPI server, waiting for approvement by @davidovich or @vphilippon.

pip-tools v4.2.0 is released! Thanks to all contributors, especially: @georgek, @jamescooke, @AndydeCleyre, and @hramezani!
Many thanks to @codingjoe and @blueyed for helping to review PRs.
Cheers 🎉


Update default settings and add new setting

Updates the following setting defaults:
--no-custom-headers is now defaulted to true, meaning all new code generation will add overloads without ResponseBase for REST APIs that have typed headers. These overloads are meant to be a performance improvement as they skip converting the HttpHeaders to the typed header object, which is commonly ignored in handwritten APIs.
--generic-response-type is now defaulted to true, meaning all new code generation will no longer generate named subtypes of ResponseBase, ex NameResponse extends ResponseBase<TypedHeaders, BodyType>. This reduces the amount of reflective access that is required by azure-core by using ResponseBase directly which azure-core can instantiate directly rather than needing to access the named subtype with reflection.
The following setting was added:
--disable-typed-headers-methods, this setting is defaulted to false. When set to true, this will skip generating any ResponseBase and named ResponseBase REST API methods in the interface client. This reduces the number of overloads that exist in the interface. Typed headers will still be generated but require being instantiated with handwritten code, making it even clearer when there will be a performance hit for using typed headers.
An additional miscellaneous change was added. Now when code generation is completing, or is halting due to an error, a shutdown call will be sent to the Eclipse Language Server if it was being used. The aim of this change is to have a more graceful shutdown process, hopefully reducing how often the Eclipse Language Server gets stuck in a permanent bad state, requiring it to be deleted and re-downloaded.

@XiaofeiCao after this PR, please check fluentgen for MGMT settinga.

@XiaofeiCao after this PR, please check fluentgen for MGMT settings.

Sure. I'm curious what the generation error is for fluent. I fixed some in https://github.com/Azure/autorest.java/pull/2541.

@XiaofeiCao after this PR, please check fluentgen for MGMT settings.

Sure. I'm curious what the generation error is for fluent. I fixed some in #2541.

I guess we would have no-custom-headers=false as we probably don't want to have ##NoCustomHeadersWithResponse APIs.
Not sure about generic-response-type. We would still need it to be false for libs that already generates the wrapper class. Not sure about new libs.

@XiaofeiCao after this PR, please check fluentgen for MGMT settings.

Sure. I'm curious what the generation error is for fluent. I fixed some in #2541.

I guess we would have no-custom-headers=false as we probably don't want to have ##NoCustomHeadersWithResponse APIs.
Not sure about generic-response-type. We would still need it to be false for libs that already generates the wrapper class. Not sure about new libs.

I left both settings in instead of making them hard coded for these reasons, making them enabled may be breaking for some generated code. In the long run for the ResponseBase scenarios, this would be recreating the previously generated class manually and just mapping ResponseBase to the subtype that was previously generated.


[Bug] Upload Files open up camera on iOS

Is there an existing issue for this?

[X] I have searched the existing issues

Have you updated FilePond and its plugins?

[X] I have updated FilePond and its plugins

Describe the bug
Whenever you click open your files on iOS devices, it opens the camera. You can't open files.
It should open to files in the iOS browser

Reproduction
Create a basic Vue3 install, add file-pond, set accepted file type to 'application/pdf,application/msword,
application/vnd.openxmlformats-officedocument.wordprocessingml.document'. It will default open a camera.
Environment
- Device: iPad, iPhone
- OS: all
- Browser: safari

This is probably basic file input behaviour, will close for now, you can try to reproduce with a normal file input and setting the accept and capture attributes.

What should they be set to?

https://stackoverflow.com/questions/21523544/html-file-input-control-with-capture-and-accept-attributes-works-wrong


Remove the statement from README that logs are not deobfuscated

What does this PR do?
We support deobfuscation for logs for a long time already, so removing false statement.
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.12%. Comparing base (fe2c9b6) to head (4c2ebbb).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #275      +/-   ##
=============================================
- Coverage      78.34%   78.12%   -0.22%
+ Complexity       254      253       -1
=============================================
  Files             31       31
  Lines            914      914
  Branches         114      114
=============================================
- Hits             716      714       -2
- Misses           147      148       +1
- Partials          51       52       +1

see 3 files with indirect coverage changes


Add support for transparent mesh material.

Fix https://github.com/rdeits/meshcat-python/issues/35
Add support for transparent material, using Three.js transparent and opacity attributes (see https://threejs.org/docs/#api/en/materials/Material.opacity).

Codecov Report

Merging #37 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   87.17%   87.21%   +0.04%
==========================================
  Files           8        8
  Lines         577      579       +2
==========================================
+ Hits          503      505       +2
  Misses         74       74

Impacted Files
Coverage Δ

src/meshcat/geometry.py
87.02% <100%> (+0.14%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4816882...c4e2e13. Read the comment docs.

Thanks! I'm going to make one change on top of your work, which is to make the transparent flag we send to three.js default to (opacity != 1). Otherwise users have to remember to set both flags to get the behavior they're likely to expect. That change will also match the behavior of https://github.com/rdeits/MeshCat.jl which already supports opacity.


server-sent-events stream not terminating

I have a server-sent-events (it returns "text/event-stream" streams) api from an asp.net 4 application - which my client can connect to using yarp - it maintains very long running (many days) connections with no issues, messages are delivered normally. However, if the client disconnects the server doesn't see the disconnection and and the stream isn't closed - it can continue to write as if the client is still there. Yarp has logged the disconnect "Request finished in X ms 200 text/event-stream", but the upstream server doesn't see the disconnect.
The full output from yarp is like this:
[20:09:45 INF] Operation ended: ReverseProxy.Proxy,<PHONE_NUMBER>ms, error: The operation was canceled.
[20:09:45 INF] Executed endpoint 'pulse'
[20:09:45 INF] HTTP GET /pulse?t=[trimmed url] responded 200 in<PHONE_NUMBER> ms
[20:09:45 INF] Request finished in<PHONE_NUMBER>ms 200 text/event-stream

If I terminate yarp, the server immediately sees the client as having gone - i.e. even though the client has long gone, the upstream server doesn't notice until I kill yarp - which is why I think yarp is holding the tcp connection open.
If I connect directly to the server without yarp, the server will see immediately when the client disconnects.
No exceptions are produced
I am developing this on Windows 10 for use on Windows Server 2016 & 2019. The upstream server is IIS, running asp.net 4, .net framework 4.8.
The reverse proxy application is a .net core 3.1 application using kestrel, running yarp preview 5. The reverse proxy application and the upstream server reside on the same box.

Hmm. Operation ended: ReverseProxy.Proxy,<PHONE_NUMBER>ms, error: The operation was canceled. means an OperationCancelledException was caught and logged here:
https://github.com/microsoft/reverse-proxy/blob/4bd161b6b357e2f146159dd8aef843b6e67fc4a7/src/ReverseProxy/Middleware/ProxyInvokerMiddleware.cs#L91-L93
Preview5 includes a bunch of new error handling in HttpProxy, an exception shouldn't have escaped. It should also have been logged like this:
https://github.com/microsoft/reverse-proxy/blob/4bd161b6b357e2f146159dd8aef843b6e67fc4a7/src/ReverseProxy/Service/Proxy/HttpProxy.cs#L788-L791
Are you sure you're not running preview4? The lack of that log and the escaping exception seem like preview4 behavior.
The request would have been in the CopyResponseBody stage here:
https://github.com/microsoft/reverse-proxy/blob/4bd161b6b357e2f146159dd8aef843b6e67fc4a7/src/ReverseProxy/Service/Proxy/HttpProxy.cs#L618-L619
Failing to disconnect with the destination implies a failure to close/reset the connection when copying the response body was cancelled. There's a using on that destinationResponseStream so it should always be closed. It's possible the SocketsHttpHandler isn't closing/resetting the connection for some reason?
Do you know if the connection to the destination is using HTTP/1.1 or HTTP/2? HTTP/2 is the default if you're using TLS/HTTPS to the destination. HTTP/1.1 would close the whole connection, where HTTP/2 would only reset the one request stream. Either should register as a disconnection on the destination though.

Thanks for your comments; and I apologize, it turns out that it was actually preview 4.
With preview5 the output is indeed different and the connection is properly closed to the upstream server.
Closing this issue. Thanks for the product too - very useful.
[14:25:11 INF] ResponseBodyCanceled: Copying the response body was canceled.
System.Threading.Tasks.TaskCanceledException: The operation was canceled.
   at System.Net.Http.CancellationHelper.ThrowOperationCanceledException(Exception innerException, CancellationToken cancellationToken)
   at System.Net.Http.CancellationHelper.ThrowIfCancellationRequested(CancellationToken cancellationToken)
   at System.Net.Http.Http2Connection.Http2Stream.GetCancelableWaiterTask(CancellationToken cancellationToken)
   at System.Net.Http.Http2Connection.Http2Stream.ReadDataAsync(Memory`1 buffer, HttpResponseMessage responseMessage, CancellationToken cancellationToken)
   at Microsoft.ReverseProxy.Service.Proxy.StreamCopier.CopyAsync(Stream input, Stream output, CancellationToken cancellation)
[14:25:11 INF] Operation ended: ReverseProxy.Proxy, 34988.409ms, success
[14:25:11 INF] Executed endpoint 'pulse'
[14:25:11 INF] HTTP GET /pulse?t=[trimmed url] responded 200 in 35359.0192 ms
[14:25:11 INF] Request finished in 35367.1177ms 200 text/event-stream


Check param string types

BUG: Change str to string_types to avoid errors
When in python2.7, and unicode_literals is imported
type check will raise error because 'type' is not str but unicode
Fixes up https://github.com/quantopian/zipline/pull/1315

Coverage remained the same at 86.608% when pulling a4e495dd248b22595f1c195931a987c77b91d7f9 on check_param-string_types into 9a301dc59bcf36161de264bb80b48d78173aa745 on master.

lgtm


fix: restore line beneath page header

Description
This adds some CSS to restore the gray border beneath the page header.
Task Item
closes #7656
Screenshots

Just being paranoid but --- the problem wasn't happening on the Configure your bot page before.
Can we make sure it is resolved in the places where it was reported missing?

The Configure your Bot page was injecting its own custom CSS for the page header, which is why the behavior was different. It should be fixed everywhere now.


dev sealv4

support for macOS
SEALv4 upgrade with BGV scheme

A few things to change before merging:

Pyfhel==3.3.0 introduced a bunch of changes that conflict with this PR, and thus they need to be resolved.
The pull request still shows thousands of lines changed due to an issue with the newline. While this can be filtered out in Github, git is not that smart by itself. Remove all these unnecessary changes and rebase the entire pull request so that only the important changes are committed.
MacOS support is based on setting global environment variables, but this can be compiler-dependent and not controlled by Python. Review the approach to add compiler and linker directives only in the pyproject.toml file and avoid using environment variables.
Update Demo_7_BGV to Demo_9_BGV.
Add coverage tests to the new pieces of code.

Any updates on this? We are trying test BGV, but have some issues with the installation (compilation errors in Pyfhel/Pyfhel.cpp when building 'Pyfhel.Pyfhel' extension) (e.g., Pyfhel/Pyfhel.cpp:26069:64: error: cannot convert ‘std::vector<long long int>’ to ‘std::vector<long int>&’ when running pip install . However, not sure what stage this pull request is at?
@devharsh @ibarrond

@davidhassel BGV is now implemented in the dev branch, building and testing correctly for Windows and Ubuntu. You can install it from there.

@devharsh To avoid the full rewrite due to the newline issue you had, I mocked your commits in the dev branch and kept updating it there. Everything related to BGV now works in Windows/Linux, and I'm stuck with the installation in MacOs (testing it automatically in a fresh MacOs environment via Github Actions). If you have the time, let's move the discussion to #131 to solve the last missing issues.
Closing this branch!

Sure, always happy to help!
Best,
Devharsh.
On Dec 2, 2022, at 3:32 PM, Alberto Ibarrondo @.***> wrote:

@devharshhttps://github.com/devharsh To avoid the full rewrite due to the newline issue you had, I mocked your commits in the dev branch and kept updating it there. Everything related to BGV now works in Windows/Linux, and I'm stuck with the installation in MacOs (testing it automatically in a fresh MacOs environment via Github Actions). If you have the time, let's move the discussion to #131https://github.com/ibarrond/Pyfhel/issues/131 to solve the last missing issues.
Closing this branch!
—
Reply to this email directly, view it on GitHubhttps://github.com/ibarrond/Pyfhel/pull/141#issuecomment-1335814457, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AATLUPTHRBSFFVS34LN7CCDWLJMFTANCNFSM56TKULGA.
You are receiving this because you were mentioned.Message ID: @.***>


move endianness management to ipa.go

Move all endianness considerations to an IPA-specific file, so that it can be fixed in the dependency.

Codecov Report

Merging #122 (6230c51) into master (d431fff) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
- Coverage   89.28%   89.22%   -0.07%
==========================================
  Files           8        8
  Lines         532      529       -3
==========================================
- Hits          475      472       -3
  Misses         42       42
  Partials       15       15

Impacted Files
Coverage Δ

ipa.go
100.00% <100.00%> (ø)

tree.go
89.06% <100.00%> (-0.21%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d431fff...6230c51. Read the comment docs.


Update Loyal Beta for P3

Also included in https://github.com/wowsims/sod/pull/452 😄

oof, only saw mental dexterity in the open PR but all good.

Sorry I had everything locally still while I was working on updating it 😅


Refactors Security section into three sections

Two different 404 checkers claim that I didn't break any links. 😄
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@elfisher @stevensideyliu @alolita @CarlMeadows for visibility. I'm just going to merge sans review.


Missing Header File - catch.hpp

Checked out code from repository. Went to compile and received numerous error messages that header file catch.hpp was missing. Eventually tracked down that problem was associated to an external project: https://github.com/catchorg/Catch2 (I think...)
Suggest change to project README for others to know they need to grab this and where exactly the header file can be placed in project to be compatible with existing CMakeLists.txt.

Hello Scott,
you are right, this one was missing. I'm sorry. It is fixed now.
Best regards
Christoph


unable do swipe to delete

Hi,
I have UITableView inside stacked view. I found out that I can't use  swipe to delete feature, because look it stop working. Every time I try to swipe, then view is bouncing ;) Is this a known issue ? if so maybe there is known solution for that.

Maybe there would be good solution to add parameter about Pan gesture. If we would allow switch to "two fingers" move for views, then swipe to delete on tables start working fine.
    [panRecognizer setMinimumNumberOfTouches:2];
    //[panRecognizer setMaximumNumberOfTouches:1];

This isn't an issue, it is just a result of the fact that you can't use the same gesture to 2 things in the same physical area of the screen. Either you want left right swipe to move the stack or you want a left right swipe to delete a cell, you can't have both.
If you want to keep using the stack controller, the solution would be to add the "edit" button to your nav bar or add a "delete"  button in your detail views.

you right about it's not issue, hoever we an easily do it as a feature. It's easy to switch between 1 finger/more fingers move window where one finger gestures from default controls work anyway. What do you think?

You could also add a condition and return no on the shouldGestureRecognizerStart when you're detecting that the finger is over a tableview cell.

@steipete I found out that you already merged my change fb0fecde3852f0bd27b1c84cd4ffdbfe7f5cc537, thx.


Arrange call lists by start time [BW-527]

Tested locally against a workflow with a couple of calls: http://localhost:3000/#workspaces/general-dev-billing-account/cjl_test_workspace/job_history/82e9c326-8fc0-4d3f-aab7-d674bcaafa9e/23f98406-5d7a-4eae-be7f-bf6f6392c4ec
The more natural order makes it easier to decipher the story of what was going on in the workflow that the previous "alphabetical" order.

It looks like the test failure is related to changes made. Holding off the review for now.

@salonishah11 thanks - I think the test failures are common and unrelated to my changes (see the many merges in https://github.com/DataBiosphere/terra-ui/pulls?q=is%3Apr+is%3Aclosed despite failures in this flaky test suite)

@cjllanwarne Ah I see. Sorry. My bad!


St Peter CHI

There are several entries in the Gazetteer for St Peter  CHI. They are duplicates of the entries for JSY and GSY.
Please move the search records for these places to the correct islands, and remove the CHI entries.
Geoff

Done


Simplify the way we store the settings in an index

The current version of Meilisearch stores each setting independently in a key/value entry in the main database, to change and access this setting we need to add no more than 3 methods in the Index struct, it is too much and must be improved.
https://github.com/meilisearch/milli/blob/9580b9de7973e5252d23a2951c3fd3f973ca9617/milli/src/index.rs#L797-L814
A good way to improve that would be to create a new, well-typed, struct that describes the settings and store it in the database by using the SerdeJson de/serializer of heed.

I just spent some time doing an initial survey of all the things that this new Settings struct should keep track of. I referenced this page but obviously there are some other things we'll need that aren't list there. Upon further examination, it seems to me that all the things listed in pub mod main_key (index.rs:30) are officially defined as "settings" and all the things that aren't in there are not. Is this a fair assessment?
Moreover, I'm trying to picture the new interface to index settings. What is the intended benefit of this change? Is it just to further separate concerns? If so, it would make sense for  Struct to just have three methods corresponding to the normal put, get, and delete operations, but I'd be interested in knowing what other goals might be achieved that might affect the design.
Finally, I noticed that the technical overview stressed that it was important for this change to be backward-compatible, but that further research was necessary. Has anything interesting been discovered?
Sorry for the wall of text. I just realized I had a lot of thoughts.

Hello @phdavis1027
Thanks for your involvement, don't worry about writing a lot; it's always interesting for us to discuss with the community! 😄
FYI, @Kerollmops is on Holiday right now, he's coming back in few weeks, so you probably get an answer when he'll come back

Gotcha, thanks for the reply! I'll put a pause on this until then, for fear of finding out any changes I make are irrelevant.

Hey @phdavis1027,
Sorry for the late answer!
I looked at the codebase and listed the keys that are real settings (at the end of my message).
What I see by using a single Settings struct that you directly store into one single entry in the main database is a simplification of the internal API and impl block of the Index struct, one single put, delete and get for the whole list of Settings.
The Settings should always be merged with the previous version of them, and therefore every single setting field must be optional (as optionally set). We could probably use the Setting struct?
In terms of backward compatibility, you can ignore that for now, we will figure that out later.
Thank you very much for the time you take on this subject as it is a quite hard problem 😃
CRITERIA_KEY
DISPLAYED_FIELDS_KEY
DISTINCT_FIELD_KEY
HIDDEN_FACETED_FIELDS_KEY
FILTERABLE_FIELDS_KEY
SORTABLE_FIELDS_KEY
GEO_FACETED_DOCUMENTS_IDS_KEY
PRIMARY_KEY_KEY
SEARCHABLE_FIELDS_KEY
USER_DEFINED_SEARCHABLE_FIELDS_KEY
STOP_WORDS_KEY
SYNONYMS_KEY
AUTHORIZE_TYPOS
ONE_TYPO_WORD_LEN
TWO_TYPOS_WORD_LEN
EXACT_WORDS
EXACT_ATTRIBUTES
MAX_VALUES_PER_FACET
PAGINATION_MAX_TOTAL_HITS

👋 hi again!
After having worked with, and directly on, milli index settings, I agree it is a bit verbose as-is. However, I foresee some issues:
1. One settings struct won't cut it.
You will need one Settings struct that simply wraps around a ton of slices (gathered from a given read transaction).
You will also need another Settings struct akin to the settings builder of today, milli::update::Settings.
I have some issues with the ergonomics of the current update::Settings builder, for the exact same reasons this issue was created. Here's a brief example of what I think it should look like in Rust pseudocode:
// in another impl index to help separate this logic:
pub fn update_settings(
    wtxn: &mut heed::RwTxn,
    indexer_config: &IndexerConfig,
    settings_updates: &SettingsUpdates,
) -> Result<()> {...}

#[derive(Default)]
struct SettingsUpdates {
    searchable_fields: Setting<Vec<String>>,
    displayed_fields: Setting<Vec<String>>,
    filterable_fields: Setting<HashSet<String>>,
    sortable_fields: Setting<HashSet<String>>,
    criteria: Setting<Vec<String>>,
    stop_words: Setting<BTreeSet<String>>,
    distinct_field: Setting<String>,
    synonyms: Setting<HashMap<String, Vec<String>>>,
    primary_key: Setting<String>,
    authorize_typos: Setting<bool>,
    min_word_len_two_typos: Setting<u8>,
    min_word_len_one_typo: Setting<u8>,
    exact_words: Setting<BTreeSet<String>>,
    exact_attributes: Setting<HashSet<String>>,
    max_values_per_facet: Setting<usize>,
    pagination_max_total_hits: Setting<usize>,
}

#[derive(Default)]
pub enum Setting<T> {
    Set(T),
    Reset,
    #[default]
    NoChange,
}

index.update_settings(wtxn, IndexerConfig::default(), SettingsUpdate {
  // settings override here that explicitly define what to do using Setting::Reset & Setting::Set(_)
  ..Default::default(),
});

I could probably throw together a PR that implements this pretty quick if you're interested.

The Settings should always be merged with the previous version of them, and therefore every single setting field must be optional (as optionally set). We could probably use the Setting struct?

You will definitely need to use the Setting struct, or a customization thereof, for every field. This is not possible with just optionals (unless you use Optional<Optional<T>>, but that really feels like an anti-pattern). Reason being: if I pass None to a field that requires an update, do I want to reset it or simply not change it? You will need to wrap each field in an enum that can handle all 3 cases.
2. Handling fields that require extra care
As an example, take searchable_fields. This is not a simple delete, put, or get operation in heed like some of the other settings. Because of how this setting, and some others, are unique in how they are handled, there is no one-size-fits-all approach where you can take a *_KEY and perform some heed operation on it. Some extra processing has to be done. With the pseudocode I gave above, this is practically given to you already for free without too much extra verbosity because it is all taken care of in one method in the index. You can simply loop through the *_KEY settings that are "easy" first and then process the more complicated fields with custom logic later.

Hey guys, sorry for falling off the face of the Earth, a lot of personal stressors this past semester. Does it meet goals to allow the impl block of Index to remain pretty bulky as long as the only public-facing methods are put, get, and set?  It seems kind of trivial to make those have the desired interface as long as you can just dispatch different cases to individual functions? @GregoryConrad is right that there are definitely edge cases but a giant match block could take care of that. For example, if pub(crate) fn put<T>(&mut self, key: &str, val: T) were a method, we could manipulate complicated settings like searchable_fields or synonyms according to, e.g.,  the put_searchable_fields method. This is uglier but achieves the goal of cleaning up the database and also means that people could call put as if it were nice and simple while maintaining extensibility.

Thank you both for your input on this issue 🌮
We just did a meeting with @dureuill and decided that we could start by implementing a small POC that would serialize the internal settings as a JSON document. It brings new potential performance issues, but we will start by doing that and see later.
We also discussed our concerns about https://github.com/meilisearch/meilisearch/issues/2570 and thought about adding a version field in the struct itself. It would be helpful for the next engine version to open and read the previous version of the settings. It can convert them from one format to the new one.
We are not discussing modifying the Settings builder struct, at least for now. We are talking about how we store the internal settings, every single put_*, delete_* and get Index methods.


Add support for coc status line

There is function in coc-nvim like nearest function which can show the nearest function relative to cursor
Please add that functionality

I just added support for this for the TreeSitter. I will also add this support for coc-nvim.

I just added support for this for the TreeSitter. I will also add this support for coc-nvim.

@rustiever  added support on https://github.com/adelarsq/neoline.vim/commit/b4ecfac8298e75f01b032bd7892959b01a39cc3e
Thanks!

@rustiever  added support on https://github.com/adelarsq/neoline.vim/commit/b4ecfac8298e75f01b032bd7892959b01a39cc3e
Thanks!


⚠ Spryr has degraded performance

In d82b0e5, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 3626 ms

Resolved: Spryr performance has improved in 36e26f4 after 25 minutes.


#260 Implement sendReaction Method

Implemented a fix to properly pass the reaction parameter.
Added support for the is_big parameter.

approved, thanks @Anze  and  @andrey-helldar  for your contribution!


Ensure e2e test hardware is powered off before tinkerbell tests

Add methods to pbnj client to power on, power off, and get machine power state.

Update e2e tests to ensure all machines used for the test run are powered off before cluster create command.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/lgtm


Build fails

Hi, awesome work! I'm trying to install minimalloc on Ubuntu 22.04.3 LTS, but I'm facing the problem described below. Looks like the external submodules used are not public.
Without the --recursive flag, build fails with minimalloc/external/googletest does not contain a CMakeLists.txt file.
With the --recursive flag, the repo cannot be cloned:
Cloning into 'minimalloc/external/googletest'...
<EMAIL_ADDRESS>Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'git@github.com:google/googletest.git' into submodule path '/home/ideapilot/cmake-3.28.2/minimalloc/external/googletest' failed
Failed to clone 'external/googletest'. Retry scheduled
Cloning into 'minimalloc/external/googletest'...
<EMAIL_ADDRESS>Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'git@github.com:google/googletest.git' into submodule path 'minimalloc/external/googletest' failed
Failed to clone 'external/googletest' a second time, aborting

Also note that external/abseil-cpp gets cloned just fine. Only googletest seems to be the problem.
Thx in advance!

Just tried; unfortunately I get the same error.

OK, I just updated our googletest submodule to use HTTPS:
 https://github.com/google/minimalloc/commit/143a2c21ec52e8e5d07f0f6f8d92a635c4c15f4f

Can you try once more from scratch, using the same command above?

Problem solved. Thanks again!


preparations for js-ipfs 0.34.0

👋 I upgraded ipfs to 0.34.0-rc.1, datastore-level to ^0.10.0, ipfs-repo to ~0.26.1 and ran the tests but there were many failures 😞.
There have been breaking changes to the Object API which I believe to be the cause of the failures. You can read the release notes here: https://github.com/ipfs/js-ipfs/issues/1721

Hey, what's the roadmap for this? 0.35 is also coming soon, already in a prerelease and both 0.34 and 0.35 have critical features. Thanks!

0.36 is supported in the stable 0.21.4 version and we're now working on supporting 0.38


Add missing 'index' attribute

Coverage increased (+0.04%) to 47.429% when pulling 1b9b5b68ea2e998b0676ff9908dfe871c94a5545 on add-missing-parametr into aa378da8dfc24df1d63adeb1755cc05ebdcf3312 on master.

Coverage increased (+0.04%) to 47.429% when pulling a7900e5dc295e0515d00f73f6364d7e54912d068 on add-missing-parametr into aa378da8dfc24df1d63adeb1755cc05ebdcf3312 on master.


Can't find framework+error about it

Information

Apktool Version (apktool -version) - latest, 2.4.1
Operating System (Mac, Linux, Windows) - Windows 10
APK From? (Playstore, ROM, Other) - Samsung GT-S6802

Stacktrace/Logcat
C:\Users\Andrey\Desktop\new\123>apktool decode -f C:\Users\Andrey\Desktop\new\123\Settings.apk
I: Using Apktool 2.4.1 on Settings.apk
I: Loading resource table...
W: Skipping "android" package group
I: Decoding AndroidManifest.xml with resources...
I: Loading resource table from file: C:\Users\Andrey\AppData\Local\apktool\framework\1.apk
I: Regular manifest package...
I: Decoding file-resources...
W: Could not decode attr value, using undecoded value instead: ns=android, name=textColor, value=0x02050000
W: Could not decode attr value, using undecoded value instead: ns=android, name=textColorHint, value=0x02050001
W: Could not decode attr value, using undecoded value instead: ns=android, name=textAppearance, value=0x0207000f
W: Could not decode attr value, using undecoded value instead: ns=android, name=textColor, value=0x0205009a
W: Could not decode attr value, using undecoded value instead: ns=android, name=textAppearance, value=0x0207000f
I: Decoding values / XMLs...
Can't find framework resources for package of id: 2. You must install proper framework files, see project website for more info.
Include stacktrace here

Steps to Reproduce

apktool

Frameworks
If this APK is from an OEM ROM (Samsung, HTC, LG). Please attach framework files
(.apks that live in /system/framework or /system/priv-app)
It was been in \system\app
APK
If this APK can be freely shared, please upload/attach a link to it.
https://fex.net/en/s/3z6yxap
Questions to ask before submission

Have you tried apktool d, apktool b without changing anything?
D: Input file (d) was not found or was not readable.
B: brut.directory.PathNotExist: apktool.yml

If you are trying to install a modified apk, did you resign it? No, but ive been gonna do it with ApkTool

Are you using the latest apktool version? Yes
*Sorry for my english, i'm not good speaking english so, sorry!

Settings.zip
There is an apk app in zip file


allow to configure more parameters, like limit

also none of configuration method have any return codes, what if I will provide zero limit?

like limit
@dzmitry-lahoda Do you mean VALUES_LIMIT?

more parameters
What else do you wish to be configurable?

return codes
I don't see a fit for return codes in the current set_* functions:

  set_expired_timeout(timeout_sec: u64)
  set_host_expired_timeout(timeout_sec: u64)
  set_stale_timeout(timeout_sec: u64)

Do you? Can you describe cases where they're needed?

what if I will provide zero limit
Well, what's wrong with that? Service's owner can do whatever she likes. If she needs to set 0 to be the limit of storable values, that there may be a valid use-case behind that. Same for timeout_sec, btw.

pub static VALUES_LIMIT: usize = 20;

other parameters seems ok - timeout are configured.
pub fn write_config(config: Config) {
    fs::write(CONFIG_FILE, toml::to_string(&config).unwrap()).unwrap();
}

pub fn load_config() -> Config {
    let file_content = fs::read_to_string(CONFIG_FILE).unwrap();
    let config: Config = toml::from_str(&file_content).unwrap();
    config
}

unwrap here at least be replaced with well written expect. of course more better, imho, consistent API with success as other method.