Indicator modal doesn't warn user about blank value in required field

The indicator modal isn't alerting the user when all required fields have not been completed.  I would expect to see a message like "Please complete the required field on the Performance tab" or somesuch.
One path to reproduce:  Go to the program program page of a program that pre-existed Satsuma and so had access to old-style levels (the QA programs are good examples because none of the old levels are set).  Click on a gear icon to update any indicator.  Change something and try to save.  It looks like nothing has happened.  If you go to the Performance tab and select an old-style level, the save button acts as expected.

@sanjuroj I was seeing these "incomplete" warnings as expected, as recently as yesterday afternoon. Are they all failing now, or only a subset, based on program settings? Do you need me to dig into this?

@jennyhavah It was a simple fix, I didn't bother to see when/how the change happened.  I can dig into it if you want but I think it's working now.

@sanjuroj Using the program https://tola-activity-qa.mercycorps.org/program/581/#/:
I am able to clear out the baseline field -- remove any value and uncheck N/A -- and it saves successfully, despite it being a required field. I can then reopen and it's empty.

That was a completely different issue which I've queued up a fix for.  There's another issue I found while testing:  If you have LOP target selected in the Indicator Modal, delete the target value, trigger the error message, enter a number and directly click the Save button, the error clears, but the form doesn't save.  You have to click the save button again to get it to save.   Fixing that now.

PASSED. When I attempt to edit a QA program that doesn't have OldLevels set, I see this:

I am also unable to save if I clear out the baseline field.


I2S_write blocks with unfilled DMA buffers (IDFGH-519)

Environment

Development Kit:  ESP32-PICO-Kit
Kit version: v4
Module or chip used:  ESP32-PICO-D4
IDF version: v3.3-dev-386-gf1b4c18c2
Build System: Make
Compiler version: crosstool-ng-1.22.0-80-g6c4433a
Operating System:  Linux
Power Supply: USB

Problem Description
i2s_write() blocks when space available in buffer. (posted on esp32 forum). Upon further testing and inspecting the i2s.c code, it seems, even if I2S is started, the i2s_write() api allows the filling of only one TX buffer at a time. After a single buffer is filled, a subsequent call will block from filling the next buffer until a i2s_reg->int_st.out_eof interrupt is received. Thus having multiple buffers is pointless.
Expected Behavior
As per ESP-IDF docs, if space is available in DMA transmit buffer, the function should return.
Actual Behavior
i2s_write() blocks when DMA buffers available.
Steps to repropduce
Run code below.
Code to reproduce this issue
#define I2S_NUM (0)
void app_main()
{
size_t bytes_written;
i2s_config_t i2s_config = {
.mode = I2S_MODE_MASTER | I2S_MODE_TX,
.sample_rate = 16000,
.bits_per_sample = 16,
.channel_format = I2S_CHANNEL_FMT_ONLY_LEFT,
.communication_format = I2S_COMM_FORMAT_I2S | I2S_COMM_FORMAT_I2S_MSB,
.dma_buf_count = 8,
.dma_buf_len = 400,
.intr_alloc_flags = ESP_INTR_FLAG_LEVEL1, // Interrupt level 1
};
i2s_pin_config_t pin_config = {
.bck_io_num = 19,
.ws_io_num = 23,
.data_out_num = 22,
.data_in_num = -1
};
i2s_driver_install(I2S_NUM, &i2s_config, 0, NULL);
i2s_set_pin(I2S_NUM, &pin_config);
i2s_stop(I2S_NUM);
ESP_LOGI(TAG, "begin write");
i2s_write(I2S_NUM, "X", 1, &bytes_written, portMAX_DELAY);
ESP_LOGI(TAG, "write complete"); /* never reaches here, even though DMA buffer is not full */
}

@iceman1194 i2s_stop before write operation will disable I2S interrupts, that will anyways block any I2S operations. Any specific reason for this, can you try removing it?

[this seems obsolete and should probably be closed?]
By inspection of the code and also experimentation, i2c_write() can definitely fill more than one DMA buffer. It does fetch each of them in turn from the queue of empty buffers, but that makes sense and is by design. In the example above, the call to i2s_stop() does seem like the problem, as @mahavirj pointed out...


feat(STONEINTG-674): update kubebuilder to v4

update kubebuilder to v4

Maintainers will complete the following section

[ ] Commit messages are descriptive enough (hints)
[ ] Code coverage from testing does not decrease and new code is covered (check the PR coverage on codecov)
[ ] Controllers diagrams are updated when PR changes controllers code  (if applicable)

/ok-to-test

@hongweiliu17 why are we moving all of the controllers within a new "internal" folder? commit message is missing the description

@hongweiliu17 why are we moving all of the controllers within a new "internal" folder? maybe add explanation to commit message

Added. Thanks.


chore(TestModels): Add constraints inside list, map and union

Issue #, if available:
Description of changes:
This PR adds constraints inside list (ListWithConstraint), map (MapWithConstraint) and union (UnionWithConstraint) in the test model.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

It would be good to also add a constraint within multiple levels of structures, to ensure that we're not only validating input structures. For example
structure GetConstraintsInput {
  ... // existing members omitted for brevity
  inner: InnerStructure,
}

structure InnerStructure {
  str: NonEmptyString,
}


ListItemAttachments use when creating a new list item

Category
[ ] Enhancement
[ ] Bug
[X ] Question
Version
Please specify what version of the library you are using: [  1.14.0       ]
Expected / Desired Behavior / Question
I am just learning the whole SPFx and am trying to enable a user to add attachments on my form which will create a new list item after they filled out the form and click the submit button.  I just added the ListItemAttachments component and it is expecting the list item ID which doesn't exist yet.  Is there any way to use this component before the list item is created and during/after creation add the attachments to the newly create list item?
Observed Behavior
I am using a state variable to save the new list item ID after creation which is 0 until the user clicks on the submit button.
When I load the webpart, I get an error "Error on load list item attachment, reason: Cannot read property 'map' of null"
Steps to Reproduce
Added below code to my tsx (listId redacted)

Hi, are there any plans to add this functionality?

Hi @chris-ci, cardinalpipkin and @evlo
Thanks for the suggestion, sounds like a great improvement.
I don't believe this is supported at the moment, but happy for someone to submit a PR with the improvements

@mgwojciech sounds like a way to get it to work, thanks for the suggestion. Would you be willing to submit a PR and also include an update to documentation? If so I will assign you to this issue so other people are aware that it's being addressed.

@joelfmrodrigues  - sure thing! I'm not sure if quality of the docs will be satisfactory but I'll do my best :)

Pushed with my other PR:
https://github.com/pnp/sp-dev-fx-controls-react/pull/906
Have a great weekend

@mgwojciech Thanks, I'm sure it will be satisfactory :) All I was referring to was to add an example for the use case above so people understand how to use it when the item is yet to be created.
I will review as soon as possible


[BUG] PEP-660 editable installs import issue based on package name and CWD

setuptools version
setuptools==65.3.0
Python version
Python 3.10 or Python 3.8
OS
Ubuntu 22.04
Additional environment information
pip==22.2.2
Description
If I install a package with a PEP 660 editable install using a pyproject.toml file and no setup.py file, and the package's parent directory has the same name as the package directory itself, Python fails to fully import the package specifically when my CWD is the grandparent of the package directory. That is, I can import the package, but I can't access its non-built-in attributes, and its __spec__ attribute includes loader=<_frozen_importlib_external._NamespaceLoader even though there are no namespace packages involved here. If my CWD is any other directory, I don't encounter this issue, and if I ensure that the package directory has a different name than its parent, I don't encounter this issue. This also isn't an issue when using setup.py instead of pyproject.toml.
Expected behavior
I expect to be able to import from an editable install with a venv activated regardless of my CWD and regardless of whether or not the package's name is the same as its parent directory.
How to Reproduce
I made a minimal reproducible example here: https://github.com/noah-weingarden/setuptools-mre
This is the directory structure:
.
├── bugexample
│   ├── bugexample
│   │   └── __init__.py
│   └── pyproject.toml
└── workingexample
    ├── pyproject.toml
    └── working
        └── __init__.py

Output
$ pwd
/home/noah/setuptools-bug-demo
$ python3 -m venv env
$ source env/bin/activate
$ pip install --upgrade pip setuptools wheel
$ pip install -e bugexample
$ pip install -e workingexample
$ python

>>> import bugexample
>>> import working
>>> bugexample.obj
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'bugexample' has no attribute 'obj'
>>> working.obj
'Yay! :D'

cd ~
python

(I think any other directory would also work.)
>>> import bugexample
>>> import working
>>> bugexample.obj
'Oh no!'
>>> working.obj
'Yay! :D'

Sorry, I think this is a duplicate of #3557.


docker-entrypoint: add workaround for Azure app service idiosyncrasy

Codecov Report

Merging #86 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   95.85%   95.85%
=======================================
  Files          85       85
  Lines        5160     5160
  Branches      186      186
=======================================
  Hits         4946     4946
  Misses        198      198
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fe14b8...99c3139. Read the comment docs.


Cosmos DB trigger cannot fire

Describe the Bug with repro steps
I added new item in cosmos db, but the flow didn't be fired. I make sure the connection, db name and container name all correct.
What type of Logic App Is this happening in?
Standard (Portal)
Are you using new designer or old designer
New Designer
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
No
Workflow JSON
{
  "definition": {
    "$schema": "https://schema.management.azure.com/providers/Microsoft.Logic/schemas/2016-06-01/workflowdefinition.json#",
    "actions": {
      "Initialize_variable": {
        "type": "InitializeVariable",
        "inputs": {
          "variables": [
            {
              "name": "content",
              "type": "object",
              "value": "@triggerBody()"
            }
          ]
        },
        "runAfter": {}
      }
    },
    "contentVersion": "<IP_ADDRESS>",
    "outputs": {},
    "triggers": {
      "When_an_item_is_created_or_modified": {
        "type": "ServiceProvider",
        "inputs": {
          "parameters": {
            "databaseName": "db",
            "collectionName": "container",
            "leaseCollectionName": "leases",
            "createLeaseCollectionIfNotExists": false,
            "leasesCollectionThroughput": 400
          },
          "serviceProviderConfiguration": {
            "connectionName": "AzureCosmosDB",
            "operationId": "whenADocumentIsCreatedOrModified",
            "serviceProviderId": "/serviceProviders/AzureCosmosDB"
          }
        },
        "splitOn": "@triggerOutputs()?['body']"
      }
    }
  },
  "connectionReferences": {
    "AzureCosmosDB": {
      "connection": {
        "id": "/serviceProviders/AzureCosmosDB/connections/AzureCosmosDB"
      },
      "connectionName": "cosmosconnection",
      "api": {
        "id": "/serviceProviders/AzureCosmosDB"
      }
    }
  },
  "parameters": {}
}

Screenshots or Videos
No response
Browser
Chrome
Additional context
No response
AB#24574814

Moving this to the backend repo for triage since this appears to be happening at runtime rather than in the UX


Filters on public plan page not working as expected

Please complete the following fields as applicable:
What version of the DMPRoadmap code are you running? (e.g. v2.2.0)
Expected behaviour:
I was expecting to be able to filter on Funder and Subject here: https://dmptool.org/public_plans?search=&sort_by=title
Actual behaviour:
Funder and Subject filters display "0" despite all 1,195 plans displayed in the panel to the right.
Steps to reproduce:

This was fixed in v5.10


RequirementMachine: Introduce 'concrete contraction' pre-processing pass before building rewrite system

See the comment at the top of ConcreteContraction.cpp for a detailed explanation.
Fixes rdar://problem/88135912.

@swift-ci Please smoke test

@swift-ci Please smoke test Linux


WorkflowUpdate and attendant types

What changed?
Adds the WorkflowService.UpdateWorkflow RPC

Why?
New feature

How did you test it?
make proto

Potential risks

[...] where are the "commands"? Are they coming later?

Yes, first drop will just be external fast-path invocations (i.e. gRPC clients, not workflow-to-workflow) so commands are not needed yet.

Yes, first drop will just be external fast-path invocations (i.e. gRPC clients, not workflow-to-workflow) so commands are not needed yet.

I would think it'd need commands no matter what. How does a worker provide a response for an update back to the server?


How to set min/max range to cancel gesture

Is there a prop to stop or cancel the gesture once it hits a minimum or maximum value?
I’m working on a Slider component and I need to stop not only the UI from moving but the value of either translationX or absoluteX. For the Animated UI I found I could set a clamped range by using interpolate, but the value would still increase or decrease once the max or min was surpassed.

Having a cancel() method would fix my problems. I'm implementing a bottom sheet with a nested ScrollView. It would be awesome to be able to have the ScrollView waitFor a PanGestureHandler that animates the sheet up to a max height. Then, as the gesture continues, it would be nice to have PanGestureHandler cancel itself and allow the ScrollView to pick up where it left off.
The end result would be one fluid gesture that animated the sheet up and then scrolls the content in the ScrollView.


[@open-wc/building-rollup] Web Workers showing in bundled index.html

hey team,
thanks for the work in these standards. i'm using web workers and bundling the workers with rollup-plugin-off-main-thread (https://github.com/surma/rollup-plugin-off-main-thread) where it searches for the regex new Worker and bundles that file, but the createDefaultConfig is also loading the script into the index.html.
main.js
import './app/app.component.js'
const apiWorker = new Worker('./workers/api.worker.js');
const appStateWorker = new Worker('./workers/app-state.worker.js');

rollup.config.js
import {createDefaultConfig} from '@open-wc/building-rollup';
import OMT from '@surma/rollup-plugin-off-main-thread';

const config = createDefaultConfig({ input: './src/index.html' });

export default {
  ...config,
  plugins: [
    ...config.plugins,
    OMT(),
  ],
};

so my dist folder has the right scripts, but the index.html contains
function t() {
    ["./main-fffd6547.js", "./api.worker-23ba6621.js", "./app-state.worker-2d8e41a7.js"].forEach((function (e) {
      window.importShim(e)
    }))
  }

but i need it to just be
function t() {
    window.importShim("./main-fffd6547.js")
  }

Looking at the output, it seems like the OMT plugin injects the worker as entrypoints to rollup which in turn causes them to be loaded in HTML because it picks up all rollup entrypoints automatically.
We have a big update of the rollup config coming up soon which will use our new HTML plugin (https://github.com/open-wc/open-wc/tree/master/packages/rollup-plugin-html). This doesn't suffer from this problem, it will only inject entrypoints that belong to that HTML file.
If you're patient you could wait a bit, or you could try out https://github.com/open-wc/building-rollup-changes where we've prepared the upcoming changes.

yeah, absolutely! i can wait and do building-rollup-changes in the meantime. thanks so much

This should work properly now with v1 of building-rollup. See https://github.com/open-wc/open-wc/blob/master/packages/building-rollup/README.md and https://github.com/open-wc/open-wc/blob/master/packages/building-rollup/MIGRATION.md. Could you try it out and let me know?

yep! that worked. thank you so much for getting this out! I really appreciate it.


Negative options

Do not generate a negative option (--no-no-foo) for already negative boolean options (--no-foo)

+1  An option's default must match its type  error in master

Coverage increased (+0.11%) to 91.91% when pulling d65fef7e6d41c4204e6a68a33e628c3e0c498397 on aderouineau:negative-bool into 0399bcfea20ee16535075baff7d4ade9274b7f32 on erikhuda:master.

Thanks!


Allow to Defer Reconcilation/Maintenance to Next Maintenance Time Window/24h

Story

As shoot cluster owner I want to defer the next reconciliation/maintenance to the next maintenance time window or by at most a day/24h, so that I can avoid planned or unplanned cluster outages.

Motivation
At present we run only zonal clusters and we know that during maintenance of either the seed or the shoot the control plane may become unavailable for a minute or so. Most use cases will cope nicely with that, but there are others that won't (e.g. FaaS or CI/CD use cases). Now imagine, that if a stakeholder runs multiple shoot clusters in HA spread across multiple seed clusters (to avoid seed cluster update issues due to missing anti-affinity) and one cluster fails (maybe because of a bug in the software running on said stakeholder cluster), then the respective stakeholder SRE/ops team would like to prevent also the other (HA) cluster from failing (then maybe because of a reconciliation/maintenance issue) and therefore defer the reconciliation/maintenance until the first/initial problem is resolved. This example also illustrates, why disjunct maintenance time windows are not helping the stakeholder: The first cluster goes down because of a problem unrelated to Gardener. So even if we would know of the logical connection between the two, we can’t really know of their actual health in regards to the software they run. We on the other hand want to know, that clusters get eventually all reconciled (forcefully without manual intervention) in a reasonable time. If that time is now 2 days instead of 1 day, I guess we could live with it (cc @rfranzke @adracus).
Acceptance Criteria

[ ] Shoot cluster maintenance can be temporarily avoided/deferred (e.g. by means of an annotation, specifying a timestamp that may not lie more than 48h after the last reconciliation)
[ ] Shoot cluster gets eventually reconciled, no matter the annotation or updates to it (within at most 48h)

Definition of Done

[ ] Knowledge is distributed: Have you spread your knowledge in pair programming/code review?
[ ] Unit tests are provided: Have you written automated unit tests?
[ ] Integration tests are provided: Have you written automated integration tests?
[ ] Minimum API exposure: If you have added/changed public API, was it really necessary/is it minimal?
[ ] Operations guide: Have you updated the operations guide about ops-relevant changes?
[ ] User documentation: Have you updated the READMEs/docs/how-tos about user-relevant changes?

Implemented, but not on a per-shoot basis, but globally in the controller-manager configuration.


Including declarations files

@rockwotj This is an alternative PR for https://github.com/firebase/bolt/pull/211
FYI @wcandillon

(also I need to figure out the internal release process for this and I'll release a new patch version here).


Focus should remain on Grid when Row Selection Mode is turned off using Grid shortcut

Summary
Fixed issue where WorklistDataGrid loses focus when Row Selection Mode is turned off from a Row Selection Cell.
Testing
This change was tested using:

[x] WDIO
[x] Jest
[ ] Visual testing (please attach a screenshot or recording)
[ ] Other (please describe below)
[ ] No tests are needed

Reviews
In addition to engineering reviews, this PR needs:

[ ] UX review
[ ] Accessibility review
[ ] Functional review

This PR resolves:
UXPLATFORM-9655

@sdadn, you added "UX Review Required" but we do not think this is needed so I am going to remove it. We did not change any of the screenshots or added any new ones. With the exception of the bug, everything should behave the same. I am adding @eawww just in case he thinks otherwise.


Fix tests for metrics

It seems to me that the unit tests for the metrics were written incorrectly. When writing grep "smth"  the utility looks for occurrences of exactly "smth", so if, for example, the metric returns 0.5, then grep "0" will consider that this is correct. This situation happened with ahf and sahf. This is not critical, it seems that all the metrics are working correctly, but it is better that the tests are correct.

@rultor merge

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 14min)


ASM

Create a runtime dummy class that implements an interface with a method 'fire(Event event, Object... objects)' that is implemented at runtime and calls the actual methods after evaluating if the event is of type X and that corresponds to method(s) Y.
The interface should only allow the compiler to compile. Might need to be an abstract class. Method can be overloaded for all possible cases.

Currently no concept for additional properties. This would either need to still be called with reflection or otherwise solved

https://chat.openai.com/share/2a8f82bb-ce20-496d-8ddc-b5df99705ff6


Square brackets in code-blocks are interpreted as CodeTour References

The following markdown for a code block

```
Array[]
```

is interpreted as a CodeTour reference and is rendered to
Array[#undefined](command:codetour.navigateToStep?undefined "Navigate to step #undefined")
Extension version 0.0..32

Ah good catch! At a minimum, we should only be looking for square brackets that aren’t directly preceded  by characters. So we should be able to unblock this specific instance for sure.


Set replica to ERR if the size is mismatched with expected size

Longhorn 3601
Signed-off-by: Derek Su<EMAIL_ADDRESS>

Will this lead to any upgrade compatibility issues?

Yes. If the volume using the old engine image is stopped and then restart, the longhorn-manager cannot start the engine process because of the incompatible arguments. Any advise for the compatibility issue?

The first commit message is not right.
Set replica to ERR if the size is mismatched with expected size instead?

Yes, typo.

A few comments about testing, and suggest having the default value for open_replica or others w/ a new size arg, so you don't need to modify the test functions. WDYT?
open_replica(rpc_client, backing_file=None, size=SIZE_STR)

Yes, good idea.

the longhorn-manager cannot start the engine process because of the incompatible arguments.

As a hack we used env vars instead of new parameters, but what we really need to do is change the engine binaries so that we can pass arbitrary parameters which are ignored instead of just terminating the process.
If we fix this first, then in >= v1.4 we can fix a bunch of the env hacks we use as well.
We can also eventually make engines <X incompatible with longhorn-manager Y cc @innobead @shuo-wu
A good candidate is to make any non proxy engine incompatible once we reach either v1.4 v1.5 that will allow us to remove a bunch of code (backwards compatibility etc for engine/instance-manager)

Will this lead to any upgrade compatibility issues?

Yes. If the volume using the old engine image is stopped and then restart, the longhorn-manager cannot start the engine process because of the incompatible arguments. Any advise for the compatibility issue?

I missed this part.
It would be better to keep backward compatible; otherwise, users need to upgrade the engine image of the volume to start the engine. This will be an interrupt behavior. (we have a similar compatible issue before about backup creation w/ a provided backup name.)
Another way is to simulate compatible interface between versions to make any new added command options as optional, so if they are not provided, it will be fall back to the current behavior. Of course, this is not good enough in my view because I like strong contract instead.

the longhorn-manager cannot start the engine process because of the incompatible arguments.

As a hack we used env vars instead of new parameters, but what we really need to do is change the engine binaries so that we can pass arbitrary parameters which are ignored instead of just terminating the process.

Agree, also if all communication can be over gRPC instead of CI, would be much naturally to do version compatibilty.
In this case, @derekbit can we make the manager backward compatible with the old engine image when creating an engine process? at least, it should know what engine image it will use for that volume.
Having backward compatibility is quite important for us if we would like to provide a non-interruptive user experience.

If we fix this first, then in >= v1.4 we can fix a bunch of the env hacks we use as well.

@joshimoo Could you elaborate what hacks we have now?

the longhorn-manager cannot start the engine process because of the incompatible arguments.

As a hack we used env vars instead of new parameters, but what we really need to do is change the engine binaries so that we can pass arbitrary parameters which are ignored instead of just terminating the process.

Agree, also if all communication can be over gRPC instead of CLI (we use to create engine and replica process), would be much naturally to do version compatibilty.
In this case, @derekbit can we make the manager backward compatible with the old engine image when creating an engine process? at least, it should know what engine image it will use for that volume. WDYT?
Having backward compatibility is quite important for us if we would like to provide a non-interruptive user experience.

If we fix this first, then in >= v1.4 we can fix a bunch of the env hacks we use as well.

@joshimoo Could you elaborate what hacks we have now?

Yes, I'm working on the compatibility issue.
I have one question. What do these mean? Especially, the xxxMinVersion.
InstanceManager.status.apiMinVersion
InstanceManager.status.apiVersion
InstanceManager.status.proxyApiMinVersion
InstanceManager.status.proxyApiVersion

cc @c3y1huang

Agree, also if all communication can be over gRPC instead of CLI (we use to create engine and replica process), would be much naturally to do version compatibility.

@innobead  Could you give some more detail about how it is much more natural to do version compatibility once all communication use gRPC?

for @PhanLe1010
Basically just use the protocol message compatibility characteristic.
"Protocol buffers provide a language-neutral, platform-neutral, extensible mechanism for serializing structured data in a forward-compatible and backward-compatible way."
ref: https://developers.google.com/protocol-buffers/docs/overview

BTW, will we have any api/cli version deprecation roadmap?

The backward compatibility issue is addressed. Please help review the PR. Thank you.

All comments are addressed. It is ready for review. Thank you.
cc @innobead


[Minor] Decoupling NameLayer permissions

I noticed that DOORS, CHESTS, BLOCKS and CROPS are Citadel specific permissions, shouldn't plugin-specific permissions be managed by their plugin, perhaps with a NameLayer permissions API, so dependent plugins like CivChat or Bastions could define their own perms without modifying NameLayer itself?

This is an excellent idea, some kind of permission registration system within NameLayer. Would have to figure out the storage/persistence of those registrations, opens up a proverbial can of worms, but it's a good idea.

Agree, great idea. I imagine factories and the future contraptions benefitting from this.

I've always wanted to do this but I've never though of a good system.  Is there some way to do it that doesn't involve using Strings?

GUIDs

Hmm. Stumping for Postgresql: http://www.postgresql.org/docs/8.3/static/datatype-uuid.html
MySQL (grumble): https://dev.mysql.com/doc/refman/5.0/en/miscellaneous-functions.html#function_uuid
E.g. in Postgresql UUID (GUID) is a top-level type with its own comparison and indexing abilities. In MySQL it's just a string. With string capabilities. Or you can do fancy work to pack it into a 16 byte number (which Postgresql gives you for free).
In general, @rourke750 these things are either magic strings or magic numbers. This isn't all bad. GUID is nice, we could provide a resource for a plugin to register its own GUID with NameLayer, give it some descriptive jazz for pretty printing, default levels-of-application, etc.

Plugins use MySql. NameLayer already lists all permissions in a single
string field. Why can't plugins register more permissions which just get
added to that string (barring the inevitable maximum length for that field
in the DB, for which a fix should be created if this is supported). Better
yet, why doesn't NameLayer farm permission management out to PEX so we
don't have to deal with it? Create an abstraction layer for permissions in
NameLayer and have a NameLayer based manager + a PEX based manager which
could be selected via config.
On Fri, Jul 24, 2015 at 11:20 AM, Daniel Boston<EMAIL_ADDRESS>wrote:

Hmm. Stumping for Postgresql:
http://www.postgresql.org/docs/8.3/static/datatype-uuid.html
MySQL (grumble):
https://dev.mysql.com/doc/refman/5.0/en/miscellaneous-functions.html#function_uuid
E.g. in Postgresql UUID (GUID) is a top-level type with its own comparison
and indexing abilities. In MySQL it's just a string. With string
capabilities. Or you can do fancy work to pack it into a 16 byte number
(which Postgresql gives you for free).
In general, @rourke750 https://github.com/rourke750 these things are
either magic strings or magic numbers. This isn't all bad. GUID is nice, we
could provide a resource for a plugin to register its own GUID with
NameLayer, give it some descriptive jazz for pretty printing, default
levels-of-application, etc.
—
Reply to this email directly or view it on GitHub
https://github.com/Civcraft/NameLayer/issues/125#issuecomment-124607980.

Plugins use MySql.

I know. I hate it. Not pulling punches here, Postgres is superior in every way.

PEX

Makes a lot of sense, would probably be a good approach.

Don't forget other people use this plugin.  By using pex as a dependency we could put other servers in a tough situation.

Thus why the permissions layer is abstracted away with a
NameLayerPermissionManager for those servers.
On Fri, Jul 24, 2015 at 1:13 PM, rourke750<EMAIL_ADDRESS>wrote:

Don't forget other people use this plugin. By using pex as a dependency we
could put other servers in a tough situation.
—
Reply to this email directly or view it on GitHub
https://github.com/Civcraft/NameLayer/issues/125#issuecomment-124704449.

Re: Dan & Postgres
Agreed, that's why the AuxBox uses Postgres. Migrating all the plugins
would be a huge pain though.
On Fri, Jul 24, 2015 at 2:06 PM, Nick<EMAIL_ADDRESS>wrote:

Thus why the permissions layer is abstracted away with a
NameLayerPermissionManager for those servers.
On Fri, Jul 24, 2015 at 1:13 PM, rourke750<EMAIL_ADDRESS>wrote:

Don't forget other people use this plugin. By using pex as a dependency
we could put other servers in a tough situation.
—
Reply to this email directly or view it on GitHub
https://github.com/Civcraft/NameLayer/issues/125#issuecomment-124704449
.

Re: Postgres
Yeah. I can't even think about it seriously until all the plugins are using a sensible DB connection pool manager, probably hosted in Civmodcore. Then we could talk about DB conversion, but it's a mess no matter how you slice.
Reg: PEX
I appreciate that other people are using the plugin and we don't want to alienate them, but significantly improving the plugin by having better permission handling, and abstraction like 'rocs is suggesting, can only make life better for everyone (probably). What kind of resistance would you expect, especially if we document the change well?

just lots of confused people, in general we just want to avoid tight coupling and dependencies where possible.

Coming back to this, going to start defining group permissions that get stored with player and then we just check the player for the permission.

https://github.com/Civcraft/NameLayer/pull/191


How do you get to the view that shows all the PRs?

In the readme it shows this starting view with all the PRs

But when I open the extension I only see one PR like this

I'm sure it must be something simple, but I'm not finding it very intuitive.

Hey @parched, if I see it correctly in your screen, your current branch has an open PR and you're currently looking at the (single) PR view

However, the view you're referring to from the first screenshot is the actual overview of the extension that has a different icon

If you click there the overview should open.
If you can't see it (in fact, it's not in your screenshot):
A) If you have many extensions (more than the available space) some will be hidden behind this icon

Click on it and look for "GitHub"
or
B) If the extension is hidden, try to right click on the PR icon and you should find "Github" unchecked. Click there and the icon will appear.

Thanks @Balastrong, yes I had it hidden for some reason.
I'll leave this open in case the maintainers want to update the readme as that only shows one icon. Also, it says

A new viewlet will appear on the activity bar which shows a list of pull requests and issues.

but there are actually 2 viewlets. I'm guessing there used to be one, but that's changed since the readme was written.

Thanks @Balastrong for responding!


Error building dependencies with yarn on Arch Linux

I just downloaded the code and tried to build the dependencies on Arch Linux with yarn. I'm not sure if I'm missing something obvious.
Here is my build output.
https://bpaste.net/show/d9de030db9ca

@dmp1ce did you / can you try running npm run install-grpc after running yarn?

@dmp1ce if you could test the above patch which updates the grpc package that would be great ;)
Updated code is in this fork/branch https://github.com/mrfelton/zap-desktop/tree/feat/update-grpc

https://bpaste.net/show/d32c16d9afc0 from the branch feat/update-grpc. I didn't try the step npm run install-grpc because I assumed the yarn command failed. Should I just continue on with running lnd and running Zap?

npm run install-grpc also had errors. https://bpaste.net/show/c2bf6b2ea5e1

@dmp1ce I've been working on updating various build dependencies for the project to resolve some build related issues that I was facing. It's possible that some of these updates could resolve your issues too.
Could you try with the code from this PR https://github.com/LN-Zap/zap-desktop/pull/426 (code is in this branch https://github.com/mrfelton/zap-desktop/tree/feat/update-tooling)

I'm not sure I'm building grpc-native-core correctly but I get these errors.
https://bpaste.net/show/659c8d50e916

@dmp1ce Can you open a support request at https://github.com/grpc/grpc/issues/new please? They should be able to help you better.

The actual problem is here:
https://github.com/LN-Zap/zap-desktop/blob/master/app/package.json#L14
Please don't do this. electron-rebuild isn't doing things correctly by skipping hooks, and will break grpc every now and then, like with this issue here. Moreover, the only advantage of using electron-rebuild is to automatically rebuild for the installed version of electron, so you don't need to specify the target, like you're doing. So effectively, you're getting into a situation where:
-) You are creating more problems than it's worth by using electron-rebuild.
-) You don't get the only advantage that using electron-rebuild is supposed to provide.
The correct method would rather be to do npm rebuild --target=1.8.4 --target-runtime=electron --dist-url=https://atom.io/download/electron, which will correctly call all of the necessary hooks so it'll try grabbing our pre-built packages instead.

Also, unless I am mistaken, you are only using the client side of grpc. Please consider using the @grpc/grpc-js package instead, which is a pure javascript client.

@nicolasnoble The line that you point to (the install-grpc script) is not actually called as part of the installation process.
When you run yarn it runs electron-builder install-app-deps which causes the postinstallstep from app/package.json to run, which runs the code:
npm rebuild --runtime=electron --target=1.8.4 --disturl=https://atom.io/download/atom-shell --build-from-source

See https://github.com/LN-Zap/zap-desktop/blob/master/app/package.json#L13
The install-grpc script which you pointed to is currently listed as an additional installation step in the advanced installation instructions (which I believe should be removed as is redundant - and problematic as you have pointed out)
See https://github.com/LN-Zap/zap-desktop/blob/master/ADVANCED.md#installing-dependencies
So unless @dmp1ce was manually running yarn install-grpc after running yarn (which I don't think he was), then I don't think this is the issue here.
@dmp1ce can you confirm which command you were running when you faced this issue please?

This is all I did originally:
git clone https://github.com/LN-Zap/zap-desktop.git
cd zap-desktop
yarn

Afterwords I tried some different branches from @mrfelton by changing the branch with git checkout and then yarn again.

Alright, I did some investigation locally, there's still something wrong somewhere, @mrfelton. You say you are invoking npm rebuild upon doing yarn, but locally, I can see the extension being built instead.
I don't know how to show it exactly with yarn to be honest, but if I try installing your app, I can see the following processes being spawned on my machine:
/usr/lib/gcc/x86_64-linux-gnu/5/cc1plus -quiet -I ../deps/grpc -I ../deps/grpc/include -I ../deps/grpc/third_party/abseil-cpp -I /home/pixel/.electron-gyp/iojs-2.0.2/include/node -I /home/pixel/.electron-gyp/iojs-2.0.2/src -I /home/pixel/.electron-gyp/iojs-2.0.2/deps/uv/include -I /home/pixel/.electron-gyp/iojs-2.0.2/deps/v8/include -I ../deps/grpc/third_party/boringssl/include -I /home/pixel/.electron-gyp/iojs-2.0.2/deps/zlib -I /home/pixel/.electron-gyp/iojs-2.0.2/deps/cares/include -imultiarch x86_64-linux-gnu -MMD Release/obj.target/grpc/deps/grpc/src/core/ext/filters/client_channel/lb_policy/round_robin/round_robin.d [...]
```

So whatever is being run during your installation process isn't working right: the grpc extension is being rebuilt from source instead of being installed from the prebuilt binaries we are shipping. Unfortunately, I don't know yarn enough to get any useful logging output, but I suspect that `electron-builder install-app-deps` does in fact try to rebuild grpc from scratch first, which makes the `postinstall` step useless.

the grpc extension is being rebuilt from source instead of being installed from the prebuilt binaries we are shipping

@nicolasnoble  my understanding is that the recommendation for including 3rd party binaries in an Electron app is to always force compile from code rather than trusting pre-built binaries.
Note that in our npm rebuild command we specifically include the --build-from-source flag.
As I understand it, the issue here is not that it is trying to rebuild the binaries from source, but rather that it is failing when trying to do so.

That recommendation is bad, really. Or at least, I can understand this stance because a lot of prebuilt packages aren't doing it right for electron, but we took a lot of care into making it right. Now, we are providing prebuilt binaries because it's excruciatingly difficult to built it, especially on platforms like Windows. I would wager that your app is fully uninstallable under Windows that is because of this. Raspberry pis is another example where the experience is painful, not because it doesn't work, but because it takes forever.
So I would highly recommend you to change this workflow for at least grpc - in case you have other native extensions in your app that is - if you want a smoother user experience.
The other bet would be to wait until Electron migrates to node's runtime 8.11.2 or above, and then you could use our pure javascript client instead.

Hey @dmp1ce - could you try with https://github.com/LN-Zap/zap-desktop/pull/445 please?
Code in https://github.com/mrfelton/zap-desktop/tree/build/use-precompiled-grpc-bindings

@dmp1ce I would suggest you remove node_modules and app/node_modules before running yarn

At least I can confirm this doesn't try to rebuild on my machine, and makes the process much faster :-)
Thanks!

@mrfelton That worked for me. Thank you!

Closing as fixed by #445


Merge codecov reports

This PR merges the codecov results from different runs caused by the Travis matrix.
See https://docs.codecov.io/docs/merging-reports

Codecov Report

Merging #519 into master will decrease coverage by 2.85%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
- Coverage   93.78%   90.92%   -2.86%
==========================================
  Files          31       31
  Lines        4198     4198
==========================================
- Hits         3937     3817     -120
- Misses        261      381     +120

Impacted Files
Coverage Δ

databricks/koalas/usage_logging/__init__.py
23.58% <0%> (-73.59%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
50% <0%> (-50%)
:arrow_down:

databricks/conftest.py
87.87% <0%> (-9.1%)
:arrow_down:

databricks/koalas/__init__.py
76.31% <0%> (-7.9%)
:arrow_down:

databricks/koalas/utils.py
97.29% <0%> (-2.71%)
:arrow_down:

databricks/koalas/frame.py
92.06% <0%> (-2.04%)
:arrow_down:

databricks/koalas/namespace.py
88.23% <0%> (-1.69%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cac41b...1a30bd5. Read the comment docs.

Let me get this in and see if it works great.


Olivia Zoe: Watch senlainc.com

Olivia Zoe requests the watch of the watch_keyword senlainc\.com. See the Metasmoke search here and the Stack Exchange search here.

senlainc\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Coverage remained the same at 65.091% when pulling 1d563b1df695133abe7f5cbb63172c856047df53 on auto-blacklist-1524229155.8804533 into 26470441e16bea9be931ada698e58599132748fa on master.

!!/approve


Navigation

Please add page navigation at the top (https://hanslick-online.github.io/hsl-app-dev/toc.html) and the bottom (https://hanslick-online.github.io/hsl-app-dev/search.html) of the table too.

Thanks for adding the page navigation in the table of contents. Please also add a page navigation at the bottom of the search results, so users don't have to scroll to the top each time when switching between pages (https://hanslick-online.github.io/hsl-app-dev/search.html).


Add svg tag icon. Resolves: #3

I read from "Font Awesome" that with the usage of such icons, it is required to provide a link to the license. I am assuming that this is being done already somewhere, as you are using these icons. Please let me know if this license should be part of the PR

Hi @primercuervo
I'd rather use a regular icon to keep the same icon style through the whole theme (https://fontawesome.com/icons/tag?style=regular)
Regarding the attribution, I actually have a Pro Licence, so no need for attribution. But you're right, it should be added in the theme if needed. It's not clear to me if the attribution is actually needed, reading at the license.

Adding the regular tag icon would work as well for me! In that case I will close the PR and wait for the Update. Thank you for doing this.
With the attribution, I have more doubts than certainties, tbh. Coming back to the case where I would like to extend the svg.html (which becomes, temporarily, purely hypothetical since I'll wait for an update from your side), then the Icons would become part of my site instead of the theme by moving the partial to my root dir, right?? Who should manage the attribution then? For starters, my content won't be publicly shared, but this is still something to consider just in case I choose to make it public, I assume. Also, the theme users might not be considering the Pro license.
In any case, It is not my intention to extend the discussion unnecessarily in that direction. It's good to know that the tag icon will come live soon :)


Minor improvements

Just clarified the README section about the dir segment and added the visual identifier concept to the icons_test segment.

Nice.


Cannot perform evaluation on trained image model using either resnet or stacked_cnn

CLI evaluation on a model trained with a resnet input feature crashes.
This works correctly on a numerical\categorical input. Only an image input feature seems to have this issue, either with resnet encoder or stacked_cnn encoder (I tried both)
Attached the sample model definition I used and the stack dump
model_definition.txt
stackdump.txt

@carlogrisetti looking into this. Can you check if predict works?

For now I can sell you that I can run inference from the APIs, so calling ludwigmodel.predict works fine in any scenario tested (both resnet and stacked_cnn)
Also the evaluation within the training cycle seems to always works fine (but since I'm having issues in converging to a solution on a project I'm working on, I'm not so sure about that... At least it's not crashing and results don't look suspicious)

Looked into it. generated a dataset, trained a model, run predict and run evaluate from cli and everything works.
I'm guessing there's something else going on, could you please create a reproducible example using synthetic data? (now there's a symthesize_dataset command).

Sure, there has to be something weird since I can't evaluate older models too, I found out. This means it's not specific to the model/ludwig version, but to my environment (I tried rolling back the code to 0.3.0-rc1 with no avail, but I didn't roll back all the other pip packages in the dependencies).
Might be something related to pip packages versions: i recently upgraded all packages with the eager parameter, forcing pip to install the most up to date package (within the requirements.txt constraints of each package, of course).
I'll try both generating the synthetic dataset to repro, and to look into packages min/max versions.

I uninstalled and reinstalled several components, even trying a support matrix between trained and evaluated versions of tensorflow... and as soon as i tried downgrading to tensorflow 2.2.0 i was able to evaluate models trained with 2.2.0. I was not able to evaluate models trained with 2.3.1 thou... After some fiddling around it all works now, but I can't repro the issue\solution steps. I have another machine that has the same issue, and I highly suspect the root cause are the tests I've done for the export_tflite PR, which I had done using tensorflow nightly... maybe something was left dirty by that package even after uninstall, and it got cleaned only with the tasks I've done today.
Will try to repro on the other machine and report back :)

On the second machine nothing I tried working... aligning versions, removing and adding packages...
I have the two machines perfectly aligned on the same pinned versions... but that did not work.
I was using a different model for testing (the real one on the production machine and a different, testing one, on the test machine), and using the same "test" model it works on both machines. I cannot port the production model to the test machine so I'm now trying to rebuild all the production non-working model from scratch (dataset et al) because I suspect there is something related to versions used when training.

I can't find out what is going wrong with that machine or how I fixed it on the other one.
I'll update if I find out how to fix that and do not resort to destroying the whole machine :)

Ok so closing for now, if you end up replicating the issue open to reopen and llok into it ;)


Restoring window (after iconification(minimization)) causes the context to not be current.

I am on windows 7 64 bit with an Intel iGPU. If I iconify (minimize) a window by clicking the "-" in the top right corner, and then un-iconify(open) the window again, the window become blank even though my main loop is still running. Note that the window doesn't become blank when I iconify it, but when I un-iconify it. Even when iconified, the window is still working correctly (I can see with the windows aero theme), however as soon as I un-iconify it, it stops working. (This doesn't happen when i simply switch to a different window and then back to my glfw window)
I can fix this by adding a window_iconify_callback, and calling "glfwMakeContextCurrent(window);" inside the callback, which i guess means that the context is dropped when the window is un-iconified.

What is the output of glfwinfo on your machine?

How do i use glfwinfo? It the i cant find the call in the API, unless maybe i have an outdated version or something.

glfwinfo is a test program, found in the tests directory. It is built along with the library when you compile GLFW from source.
If you're using a binary release, instead post the GLFW version number and the version of your GPU driver.

I am using the 3.2.1 GLFW binaries. My have the GM45 iGPU ("Mobile Intel 4 series express chipset family") in my laptop, the driver version being <IP_ADDRESS>3.
(I need to upgrade my PC V: )

I cannot reproduce this and haven't ever encountered this before. Try updating the GPU driver.

All drivers are up to date, but becouse support for that chipset was dropped a long time ago, i would not be surprised if there were still bugs like this.

Does this happen even with a very basic program, say this one?

Well, i couldn't actually test the issue with the basic program becouse it doesn't actually contain any drawing, so i added a simple fixed pipeline triangle. (https://pastebin.com/eEEAEt1m)  After doing so, i observed that this issue did not occur.
Another thing i noticed was that glfwGetWindowSize always returned 0 for both width and height when the window was iconified. (But not when simply a different window was opened instead.)
I though that perhaps having two glfw windows in two separate threads (main, plus a ImGui interface) was causing the issue, but in my main menu, (when second window isn't opened yet), this issue was still occurring.

Well, i couldn't actually test the issue with the basic program becouse it doesn't actually contain any drawing, so i added a simple fixed pipeline triangle. After doing so, i observed that this issue did NOT occur.

Are you updating the OpenGL viewport in your application when the framebuffer size changes?

Another thing i noticed was that glfwGetWindowSize always returned 0 for both width and height when the window was iconified, but returning to normal values once the window was open again.

This is normal behavior on Windows.

Yes i set glViewport() every frame.

I don't know what is causing this, then.

Well, i am having the exact same issue with SDL, so ¯\_(ツ)_/¯
(Unfortunately the fix i use with GLFW does not work with SDL though)


Add Opera 54

Recently today, I found Opera Internet Browser being upgraded to V54 so please add it. See this for more

Any updates for this?
Seems other browsers be stuck oon old versions. Opera Android must be v47 which is based on M66 of chromium.

We're having issues with users with opera v54 and 55.  They are being reported as opera 53.

Opera versions 54 & 55 have now been added.

Thank you!


Add note in dev guide about hissw

In GitLab by @wtbarnes on Oct 8, 2019, 23:54
Some of the tests that compare to IDL results use the hissw package to make calls to sswidl from Python. If the user has not configured hissw, these tests will fail. There needs to be note in the dev guide explaining this and how to configure hissw properly.
This is not a problem for normal users as hissw is not a hard dependency of the package and if it is missing, those tests will be skipped.

In GitLab by @wtbarnes on Oct 29, 2019, 15:07
mentioned in commit 59d6d707620d3ff181803f58eda26a535546a023

In GitLab by @wtbarnes on Oct 29, 2019, 15:07
closed via merge request !34


flutter doctor with java 12

There is an issue with Android sdkmanager where it does not work with Java > 8.
You can google it and find tons of issues around this with various fixes. The simplest fix is just to revert your JVM install to java 8. If you want to use Java < 11, you can apply this fix:
export JAVA_OPTS='-XX:+IgnoreUnrecognizedVMOptions --add-modules java.se.ee'
But then that does not work with Java 11 and Java 12, with a new unhelpful error.
Let's just assume I only want to have Java 12 on my machine since I like latest and greatest...
The thing that overlaps with flutter is that this breaks flutter doctor which attempts to use the sdkmanager to check the license status.
This is causes flutter doctor to error out with a totally unhelpful message:
flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, v1.8.3, on Mac OS X 10.14.6 18G95, locale en-US)
[!] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    ✗ Android license status unknown.
      Try re-installing or updating your Android SDK Manager.
      See https://developer.android.com/studio/#downloads or visit https://flutter.dev/setup/#android-setup for detailed instructions.
[✓] Xcode - develop for iOS and macOS (Xcode 10.3)
[✓] Android Studio (version 3.4)

So, one solution to this problem is to rely on the JDK installed with Android Studio:
JAVA_OPTS="" JAVA_HOME="/Applications/Android Studio.app/Contents/jre/jdk/Contents/Home" flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, v1.8.3, on Mac OS X 10.14.6 18G95, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 10.3)
[✓] Android Studio (version 3.4)
[✓] VS Code (version 1.36.1)
[!] Connected device
    ! No devices available

Given that flutter doctor already has the dependency, on Android studio, the path could be used to set JAVA_HOME before calling sdkmanager. This would hide the problem from flutter doctor.

Thanks,
JAVA_OPTS="" JAVA_HOME="/Applications/Android Studio.app/Contents/jre/jdk/Contents/Home" flutter doctor
worked for me!

If you are using a Mac it works with JDK 8:
JAVA_OPTS="" JAVA_HOME="/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home" flutter doctor

If you are using a Mac it works with JDK 8:
JAVA_OPTS="" JAVA_HOME="/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home" flutter doctor

Yea... no thanks. I want >8, which is the point of this issue.

If you are using a Mac it works with JDK 8:
JAVA_OPTS="" JAVA_HOME="/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home" flutter doctor

Yea... no thanks. I want >8, which is the point of this issue.

Yes, me too as I am using JDK12 elsewhere but to validate licences for example it works this way for now. I would be happy to have a fix too!

i have same problem with java 14

@iMAHMOD the solution given by @blacroix solves the issue of signing the Android licenses. Once you have done that, you can use JAVA 14 no problem.
Do remember to install JAVA 8 though.
NOTE: the given solution assumes you installed adoptopenjdk-8 using home brew (brew cask install adoptopenjdk-8).

@benjaminhorner The solution provided at the very top solves this issue without having to install JDK8. 🤦♂

This seems fixed.
$ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, v1.12.13+hotfix.9, on Mac OS X 10.15.4 19E266, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0-rc2)
[✓] Xcode - develop for iOS and macOS (Xcode 11.4)
[✓] Android Studio (version 3.6)
[✓] IntelliJ IDEA Ultimate Edition (version 2019.3.4)
[✓] VS Code (version 1.38.1)
[!] Connected device
    ! No devices available

! Doctor found issues in 1 category.

$ java -version
openjdk version "14" 2020-03-17
OpenJDK Runtime Environment AdoptOpenJDK (build 14+36)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 14+36, mixed mode, sharing)


added bootstrap per homework task

👷 Deploy Preview for sprightly-marshmallow-131688 processing.

Name
Link

🔨 Latest commit
62099ae7d8c1ffb6a011e857321da05e2634f5ef

🔍 Latest deploy log
https://app.netlify.com/sites/sprightly-marshmallow-131688/deploys/666026ab4fc68e000868e6aa


Search box loses focus w/ Streamlit 1.35.0

Hi, i updated Streamlit to 1.35.0 (from 1.34.0) and the search box loses focus after typing a few characters.
Note: I see a page reload happens for a split second when the focus is lost and reset
i do not get any errors and have not changed any config.
st_searchbox(
            callback_fn,
            key="my_input",
            label="",
            edit_after_submit='option',  # "disabled", "current", "option", "concat"
            placeholder="Search...",
            clear_on_submit=False,
            default='',
            rerun_on_update=True,
            style_overrides={
                "clear": {
                    "width": 20,
                    "height": 20,
                    # default: circle-filled
                    # other: cross
                    "icon": "circle-unfilled",
                    "stroke-width": 2,
                    "stroke": "red",
                },
            }
        )

Hey, thanks for the bug report. I could replicate this with streamlit versions 1.35 and 1.36 by typing (very) fast until the searchbox looses focus (looks like the iframe is reloading).
I'll create a bug report on the streamlit repostiory. The issue seems to have started with this commit https://github.com/streamlit/streamlit/commit/d302553a3724e0142b2a4420649e228a0632d36e - I don't think this is sth. that can be fixed from the component side, so we'll probably have to wait until streamlit is updated.

Problem seems to be worse with version 1.37, I've added an exception for it to the setup.py / install_requires

I've added a min_execution_time parameter to delay the next rerun and avoid the reset issues atm. This is supposed to be removed, once the original issue is resolved.


use timers to un-stall navigation after CV delete

Sometimes, after removing an entry on a <ControlledVocab> page, the
browser appears to get stuck on that page and can't navigate away.
The timer fixes this problem, though adding it makes me very very very
very very very very very very very very very very very very very very
very very very very very very very very very very very very very very
very very very very very very very very very very very very very very
very very very very very very very very very very very very very very
very very very very very very very very very very very very very very
very very very very very very very very very very very very very very
very very very very very very very very very very very very very very
very very very very very very very very very very very very very very
very very very very very very very very very very very very very very
very very very very very very very very very very very very very very
very very very very very very very very very very very very very very
very very very very very very very very very very very very very very
very very very very very very very very very very very very very very
very very very very very very very very very very very very very very
very very very very very very very very very very very very very very
very very very very very very very very very very very very very very
very very very very very very very very very very very very very very
very very very very very very very very very very very very very very
very very very very very very very very very very very very very very
very very very very very very very very very very very very very very
sad. Very sad.

yarn run v1.9.4
$ eslint .
/home/jenkins/workspace/folio-org/ui-organization/PR-165/test/ui-testing/locations.js
4:66  error  Block must not be padded by blank lines  padded-blocks
✖ 1 problem (1 error, 0 warnings)
1 error and 0 warnings potentially fixable with the --fix option.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.


Getting Errors when using Frame waitForSelector()

Puppeteer version<EMAIL_ADDRESS>Platform / OS version: 4.15.7-1-ARCH
Bitbucket Repo: https://bitbucket.org/lems111/kshowscraperserver
Node.js version: v9.5.0

What steps will reproduce the problem?

Run node server on local machine: pull source code from repo and start node app (node server.js)
Run this URL in your local to call the API:
http://localhost:3000/apis/kshow123/links?episode=http://kshow123.net/show/hyoris-bed-and-breakfast/episode-10.html&oneLink=true
You'll notice in logs that the process hangs with following error:

GetIframeData error:  Error: waiting failed: timeout 30000ms exceeded
    at Timeout.WaitTask._timeoutTimer.setTimeout (/home/lems111/Dev/kshow-scraper-server/node_modules/puppeteer/lib/FrameManager.js:789:58)
    at ontimeout (timers.js:458:11)
    at tryOnTimeout (timers.js:296:5)
    at Timer.listOnTimeout (timers.js:259:5)

This is the selector that am using when it hangs in streamer.js:
urlElement = await iframeplayerFrame.waitForSelector(
            "#olvideo_html5_api[src]"
          );

I'll be glad to provide more info to help resolve this error.

@lems111 that's a lot of code to go through; do you have a reduced test case?


Improve particle system memory management performance

From https://github.com/AnalyticalGraphicsInc/cesium/pull/5212#issuecomment-310212896

In the fireworks Sandcastle example, I would not expect this to be 10% of the profile?

and https://github.com/AnalyticalGraphicsInc/cesium/pull/5212#issuecomment-310238663

The problem is the memory management again. Sometimes more particles are created than was estimated and they get removed later. This causes the number of commands from the billboard collection to change. For every new command, it generates the OIT shader and looks it up in the cache.

The Particle System Fireworks sandcastle demo won't load in Firefox for me, it says the web page is slowing down the browser.  Is this why?

@hpinkos most likely not.  It loads OK for me on Mac Firefox 54.  Can you confirm this doesn't load for you with a clean build and clear cache in Firefox 54, check out the console, and then submit a new issue if it is a problem?

Okay, it worked after I cleared my cache


MGDOBR-647: Refactoring kustomize project

MGDOBR-647
The idea of this refactoring is the following:

We still keep a base layer, which is common for openshift and k8s
We still keep a minikube overlay that uses base
We add a base-openshift layer that contains all the configurations in common for dev and stable environments. This layer uses base
We keep the overlays dev and stable, but this time they contain only the specific configurations for the environments (for example, secrets).

The new deployment strategy is the following:

ArgoCD on dev env will watch this repository under the dev branch.
ArgoCD on stable env will watch this repository under the stable branch

When you want to deploy something to dev, just open a PR from main to dev and merge it.
When you want to deploy something to stable, just open a PR from dev to stable and merge it.
Note that this time if you are making changes to the code and an update of the kustomization files is needed, you have to do it in the PR itself for both dev and stable overlays.
Since the actual deployment of the resources is done from dev and stable branch, on main the code and the kustomize layer must be aligned.
For the time being, we still need the bot that updates the images on main when they are available.
PR owner checklist
Please make sure that your PR meets the following requirements:

[ ] Your code is properly formatted according to this configuration.
Run mvn clean verify -DskipTests so that imports are correctly set.
[ ] Your commit messages are clear and reference the JIRA issue e.g: "[MGDOBR-1] - $clear_explanation_of_what_you_did"
[ ] All new functionality is tested
[ ] Pull Request title is properly formatted: MGDOBR-XYZ Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains link to any dependent or related Pull Request
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket

PR reviewer(s) checklist

[ ] Check if code and Github action workflows have been modified and if the modification is safe
[ ] If the modification is safe, add the safe to test label

How to trigger pipelines and use the bots:

Run the end to end pipeline
Annotate the pull request with the label: safe to test. If you want to run the pipeline again, remove and add it again.

Rebase the pull request
Comment with: /rebase.

@r00ta I'm +1 on your proposed layout for the kustomize directory, but I really don't see the need for a dev and stable branch. The only reason I can see to do that would be to model environment specific configuration and that's exactly what kustomize does for us with the overlays.
As you say yourself in the PR description: environment specific configuration goes into the overlay for the environment. What else does the branch give us over that?
Part of what started this discussion was the ability to have different versions of the CRDs for the Fleet Shard operator in each environment when we make changes (as we have done in with @kostola work). Why don't we just have the CRD version that matches the operator in the overlay for the environment? So that would mean something like:

kustomize/overlays/dev/shard/resources/bridgeexecutors.com.redhat.service.bridge-v1.yml
kustomize/overlays/stable/shard/resources/bridgeexecutors.com.redhat.service.bridge-v1.yml

Where the CRD matches the version of the Operator deployed in that environment, rather than the CRD being defined in base.
cheers,
Rob

Let's consider the following scenario: we do merge some changes and a new configuration MY_CONFIG is needed for the manager.

With the current implementation we have to:

add the MY_CONFIG configuration in the dev overlay
update the images
When we are happy about the changes on dev, we have to copy/paste the new config from dev to the stable overlay together with the new images.

With the new strategy we have to:

add the MY_CONFIG configuration in the base-openshift overlay
add the new images in the base-openshift overlay
Create a PR from main to dev (it will just perform a fast-forward) -> the changes are deployed to dev
Once we are happy with the changes on dev, we open a PR from dev to stable (it will just perform a fast-forward) -> the changes are deployed to stable.

Which of the two approches do you think is more error prone?  Consider the case in which stable is behind ~10 versions respect to dev: it's really hard to remember/time consuming to remember if there are properties to be copied from dev overlay to stable.

Where the CRD matches the version of the Operator deployed in that environment, rather than the CRD being defined in base.
cheers,
Rob

Maybe there was a misunderstanding: with this PR I'm trying to improve the entire situation, not only the problem with the CRDs we talked about few days ago.

This PR is blocking basically any E2E test from PR check (due to missing CRD adjustments for Processor type). Please merge it soon.

LGTM Make sure to update the guide to promote from dev to stable and the scripts

I removed the script (cc @lucamolteni ) as we don't need anymore to copy any configuration from dev to stable


Consider exporting the full type of the RouterLink and RouterView component for TypeScript

What problem does this feature solve?
As it stands now, attempting to use RouterLink or RouterView in TSX fails with:
TS2604: JSX element type 'RouterLink' does not have any construct or call signatures.

This is because the type is erased here:
https://github.com/vuejs/vue-router-next/blob/096d86498e954345c6bd4d8e82fe54c37d3f869b/src/RouterLink.ts#L140
Is there something blocking the full type being exported?
What does the proposed API look like?
Removing the as unknown as Component.

Is there something blocking the full type being exported?

Not anymore!

@posva Do not seem to be fixed for me?
I just installed Vue 3 and am testing out type hinting with vue-tsc package, and I am now getting this error? Its a totally fresh project with Vue 3.2

@posva Do not seem to be fixed for me?
I just installed Vue 3 and am testing out type hinting with vue-tsc package, and I am now getting this error? Its a totally fresh project with Vue 3.2

Same here, did you find any solution?

@posva Do not seem to be fixed for me?
I just installed Vue 3 and am testing out type hinting with vue-tsc package, and I am now getting this error? Its a totally fresh project with Vue 3.2

Same here, did you find any solution?

You can import RouterView and RouterLink from vue-router and define them as components in your component, which will give you correct typings and resolve the errors you are getting.
//
import { RouterView, RouterLink } from 'vue-router'
//
components: {
RouterView,
RouterLink
}
Do note that this is not a permanent fix, just a workaround.

That works, i now just have an error with the whole App import in App.vue:
Module '"C:/Users/Christian/PhpstormProjects/vue-sales-running-attempt-3/src/App.vue"' has no default export.


[Courier] Shipments Dashboard / Missing h&min in "Last Modified"

Please change the label:
Schedule Pickup Date/Time -> Scheduled (ED at the end)

I am attaching the current status with the scheduled pickup date/time attribute visualization.

@arijitnv can you check why Scheduled Pickup Date/Time does not have 00:00 for time when it was not selected?


License ?

Hello, under what license is this project released under ? I would like to study it to learn from it. Thank you.

Thanks for your interest! I've added a license file for the MIT license.


Rascaline wrapper for a Clebsch–Gordan functions

As discussed in the dev-meeting:
PR #158 adds a pure Pythons implementation for constructing a Power-Spectrum for one or two Spherical Expansions. However, this is only a special case for Clebsch–Gordan function. We should try to generalize this a bit more and also focus on speed.
We had an idea for using an external library for the actual calculation and providing a wrapper for the rascaline style. @serfg could maybe share some more details here?

Closing in favor of #178 which tracks the same thing.


Wait until device is idle before running update job

If a user is actively using the device, we don't want Apps to update
apps currently in use because the OS will kill them. This problem
expands to apps outside of those in the repository because some that
depend on Play Services will barf if Play Services is killed while
they're running.
The API description for setRequiresDeviceIdle suggests the device is
considered "idle" when the user isn't actively interacting with it. If
this is the case, Apps could still update apps while the the device is
being "used" (say, a music player is running in the background), but
even so this change would reduce the frequency of apps being killed when
the user doesn't expect them to be.

I'm unsure if this makes sense since it may be too aggressive. Some use cases may rarely have the device considered idle.

Yeah I'm not exactly sure what "active use" is and it sounds like the definition could change based on the OS.

This state is a loose definition provided by the system.

If you think it's too aggressive that's cool. I figured it was worth looking into since the docs say the job constraint means "not in direct use" as opposed to "in the 'device idle' state," leading me to believe there would be ample opportunity for the job to run.

We could probably use this. I'm just not sure it makes sense alone. It would be nice if we could set an override time that still respects needing the network available...

We want something to avoid interfering with users actively using an app but this is too aggressive.


Bug: Project storybook leading to 404

Describe the bug
This URL is from the Readme which should link to the Project storybook at https://design-insights.opensauced.pizza/; The page currently is not found hence loading to a 404 error.

If there's been a change in the subdomain/domain that hosts the project, I suggest it should be updated in the ReadMe or if there hasn't been any change in the url, then this should be addressed.
Steps to reproduce

Go to https://design-insights.opensauced.pizza/

Browsers
Chrome
Additional context (Is this in dev or production?)
Production
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[ ] I agree to follow this project's Contribution Docs

Looking at the build logs, the app is being built instead of the Storybook site. I think I know what's up. We recently updated the netlify.toml as it was misconfigured, https://github.com/open-sauced/app/pull/1961.
Previously, the commands were using what was configured in the Netlify UI. Since we're not using a monorepo, the netlify.toml configuration runs the same on both the Storybook and App sites.
For now, we'll need to remove the build command from the netlify.toml.
[build.environment]
NODE_VERSION = "18"

- [build]
- command = "npm run build"
- publish = ".next"

# more config....

To validate this fixes the issue, ensure that the app and Storybook deploy previews both load their respective sites.

If you're up for it, feel free to take this one @babblebey.


Update field name normalize logic

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

👍
/approve

/changelog


remove argument from onSelect, unnecessary with getRowProps prop

:tada: This PR is included in version 1.1.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Improved storybook performance & migrate to forwardRefSimple

Just remove the old forwardRef & rename simple so we use the previous name.

Just remove the old forwardRef & rename simple so we use the previous name.


[Feature]: How to connect two Milvus clusters using ingress without using port-forward?

Is your feature request related to a problem? Please describe.
I get error while I am creating task CDC:
[2024/06/07 08:41:53.192 +00:00] [WARN] [reader/target_client.go:101] ["fail to describe collection"] [error="rpc error: code = Unimplemented desc = unexpected HTTP status code received from server: 404 (Not Found); transport: received unexpected content-type \"text/plain\""]
[2024/06/07 08:41:53.192 +00:00] [WARN] [retry/retry.go:46] ["retry func failed"] [retried=0] [error="rpc error: code = Unimplemented desc = unexpected HTTP status code received from server: 404 (Not Found); transport: received unexpected content-type \"text/plain\""]
[2024/06/07 08:41:54.217 +00:00] [WARN] [reader/target_client.go:101] ["fail to describe collection"] [error="rpc error: code = Unimplemented desc = unexpected HTTP status code received from server: 404 (Not Found); transport: received unexpected content-type \"text/plain\""]
[2024/06/07 08:41:56.242 +00:00] [WARN] [reader/target_client.go:101] ["fail to describe collection"] [error="rpc error: code = Unimplemented desc = unexpected HTTP status code received from server: 404 (Not Found); transport: received unexpected content-type \"text/plain\""]
[2024/06/07 08:42:00.267 +00:00] [WARN] [reader/target_client.go:101] ["fail to describe collection"] [error="rpc error: code = Unimplemented desc = unexpected HTTP status code received from server: 404 (Not Found); transport: received unexpected content-type \"text/plain\""]
[2024/06/07 08:42:08.291 +00:00] [WARN] [reader/target_client.go:101] ["fail to describe collection"] [error="rpc error: code = Unimplemented desc = unexpected HTTP status code received from server: 404 (Not Found); transport: received unexpected content-type \"text/plain\""]
[2024/06/07 08:42:08.291 +00:00] [WARN] [retry/retry.go:46] ["retry func failed"] [retried=4] [error="rpc error: code = Unimplemented desc = unexpected HTTP status code received from server: 404 (Not Found); transport: received unexpected content-type \"text/plain\""]

Here is config ingress milvus downstream:
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  annotations:
    nginx.ingress.kubernetes.io/backend-protocol: GRPC
    nginx.ingress.kubernetes.io/proxy-body-size: 2048m
  name: milvus-ingress
spec:
  ingressClassName: traefik
  rules:
    - host: milvus-proxy.downstream
      http:
        paths:
          - backend:
              service:
                name: milvus-milvus
                port:
                  number: 19530
            path: /
            pathType: Prefix
status:
  loadBalancer:
    ingress:
      - ip: <IP_ADDRESS>
      - ip: <IP_ADDRESS>

Here is config create task CDC:
{
    "request_type": "create",
    "request_data": {
        "milvus_connect_param": {
            "host": "milvus-proxy.downstream",
            "port": 443,
            "username": "",
            "password": "",
            "enable_tls": false,
            "connect_timeout": 10
        },
        "collection_infos": [
            {
                "name": "*"
            }
        ],
        "rpc_channel_info": {
            "name": "by-dev-replicate-msg"
        }
    }
}

Describe the solution you'd like.
No response
Describe an alternate solution.
No response
Anything else? (Additional Context)
No response

@SimFG
I connect successful with
connections.connect("default", host="milvus-proxy.downstream", port="443", secure=True, server_pem_path="milvus/cert/ca.pem")
How can I config to create CDC task?

@anhnch30820 got it, we are developing tls connection.

@SimFG I hope it will be released soon, thank you.

@SimFG I only use tls for ingress to have grpc connection and I deploy Milvus with tlsMode=0, Is this what are you developing?

@anhnch30820 this doesn't seem to connect milvus via ingress, can you connect directly via the sdk?

@SimFG I connected with SDK pymilvus succeessfully.
What I did:

generate certs via ./gen.sh with CommonName="milvus.-proxy.downstream", other params by default
kubectl create secret tls milvus-tls -n milvus --key="/home/testuser/milvus/cert/server.key" --cert="/home/testuser/milvus/cert/server.pem"
Create Ingress like here

apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: my-release-milvus
  labels:
    helm.sh/chart: milvus-4.1.17
    app.kubernetes.io/name: milvus
    app.kubernetes.io/instance: my-release
    app.kubernetes.io/version: "2.3.8"
    app.kubernetes.io/managed-by: Helm
  annotations:
    nginx.ingress.kubernetes.io/backend-protocol: GRPC
    nginx.ingress.kubernetes.io/proxy-body-size: 4m
spec:
  rules:
  - host: milvus-proxy.downstream
    http:
      paths:
        - path: /
          pathType: Prefix
          backend:
            service:
              name: milvus-proxy
              port:
                number: 19530
  tls:
  - hosts:
    - milvus-proxy.downstream
    secretName: milvus-tls

I use pymilvus version 2.4.3, connect to milvus
connections.connect("default", host="milvus-proxy.downstream", port="443", secure=True, server_pem_path="/home/testuser/milvus/cert/server.pem")

I understand that to connect to milvus via ingress is just file server.pem.

@anhnch30820 get it, it will be supported

@SimFG I want to put the pem file on the server, but I don't know where to change the code to specify the pem path because I don't know go language. Can you help me to do this?

@anhnch30820 I will develop this feature. At present, I am just telling you my implementation plan. The latest main branch next week should include this feature.

@SimFG Thank you. I am really looking forward to the next release :rocket:

@anhnch30820 i have merged the feature into the master branch, you can try it. if you have other issues, please tell me. the usage doc: https://github.com/zilliztech/milvus-cdc/blob/main/doc/cdc-usage.md#create-request-with-tls-one-way-authentication

@SimFG It does'nt work and fail with log:
[2024/06/24 03:33:37.009 +00:00] [WARN] [server/cdc_impl.go:339] ["fail to connect the milvus"] [connect_param="{\"host\":\"milvus-proxy.downstream\",\"port\":443,\"username\":\"root\",\"password\":\"Milvus\",\"enable_tls\":true,\"dial_config\":{\"server_name\":\"localhost\",\"server_pem_path\":\"/app/configs/server.pem\",\"ca_pem_path\":\"\",\"client_pem_path\":\"\",\"client_key_path\":\"\"},\"ignore_partition\":false,\"connect_timeout\":10}"] [error="rpc error: code = DeadlineExceeded desc = context deadline exceeded"]

I put file server.pem at path /app/configs/ in cdc server. Here is config create task CDC:
{
    "request_type": "create",
    "request_data": {
        "milvus_connect_param": {
            "host": "milvus-proxy.downstream",
            "port": 443,
            "username": "",
            "password": "",
            "enable_tls": true,
            "connect_timeout": 10,
            "dial_config": {
               "server_name": "milvus-proxy.downstream",
               "server_pem_path": "/app/configs/server.pem"
        },
        "collection_infos": [
            {
                "name": "*"
            }
        ],
        "rpc_channel_info": {
            "name": "by-dev-replicate-msg"
        }
    }
}

@anhnch30820 can you try to use the pymilvus to connect the milvus? Because I checked it locally and there is no problem.

@SimFG I connect successfully with pymilvus.
connections.connect("default", host="milvus-proxy.downstream", port="443", secure=True, server_pem_path="/xxx/server.pem", server_name="milvus-proxy.downstream")

I see there is a variable secure=True in connect pymilvus, is this the problem?

@anhnch30820
No, can you confirm whether the pem file is the same? According to the pymilvus code you provided, if the pem file is the same, there should be no problem.

@SimFG Could you give me the command to create file server.pem?

@anhnch30820 i use the server.key and server.pem file in the https://github.com/milvus-io/milvus/tree/master/configs/cert, and the server name is localhost. you can try to use it.

@SimFG It 's worked for me. Thank you.
The reason for the error is that I use the server.key and server.pem file generated from /gen.sh and get error failed to verify certificate: x509: certificate relies on legacy Common Name field, use SANs instead. Then I try to create the server.key and server.pem from solution on stackoverflow and it works fine too.

@anhnch30820 if you have other problem, please open a new issue and i will close this issue.


feature: apply encoding when parse feilds

Please kindly review the PR due to the multi-byte field name not getting properly parsed.

Thanks for the contribution @merik-chen! I've pushed some changes to keep all the encoding selection logic in one place and use it consistently.
Do you have a file with non-latin-1 field names that can be added to the test fixtures, so we can add a test case for this?

@yortus  Sorry for the late replies. I added a test fixture with non-Latin-1 headers.
I can pass the reading test but failed the writing one.
It seems like still related to the header encoding problem after writing data to the file. seek your help to deal with it.

Sorry for the delay @merik-chen. Thanks for adding the test file - it revealed another field name encoding bug which I've fixed. Merging now, thanks very much for your contribution!


When I finished downloading, I had some problems running the code

After I had downloaded the latest download instructions, I tried to run the first command（python -m omnigibson.examples.scenes.scene_selector ） in “explore omnigibson” and got the following errors

But eventually, I got to this interface（）

When I've made all the choices,

and then It finally closed

can anyone help？I've been troubled for a long time.

Hi,
Everything here is running as expected - those red errors are from some part of Isaac Sim we don't use, and apart from that this script executes to completion (I know nothing too interesting happens)!
If you want to drive a robot around a bit as a demo, run python -m omnigibson.examples.robots.robot_control_example
Thanks!

I see. Thank you very much for your reply！


EJS template string in Google Docs are not escaped correctly when rendering

Expected Behavior
In Google Doc:
```
<%- include('./../default/partials/pagination', { pages }) %>
```

The code snippet should render with the contents:

<%- include('./../default/partials/pagination', { pages }) %>

Actual Behavior
The code snippet is rendered empty:

Possible Solution
Is there a conflict between the EJS templating and EJS template strings?

Looks like this line is the culprit. I'm not sure if there is a reason the app removes template strings if ALLOW_INLINE_CODE is not set rather than leaving them in, but @isaacwhite would know more!

In @mtandre's case I believe ALLOW_INLINE_CODE was set, but you have a good point @afischer  that it's reasonable to return unescaped text from the match rather than an empty string when the env var is omitted.


Merge #15334, #13076, #15266, #13128

a4b92e467dd182621497deda1e80a9737629c75f Log full paths for wallets (Hennadii Stepanov)
Pull request description:
Fix #15333
debug.log with this PR:
...
2019-02-03T19:02:35Z Using wallet directory /home/hebasto/.bitcoin/testnet3/wallets
2019-02-03T19:02:35Z init message: Verifying wallet(s)...
2019-02-03T19:02:35Z Using BerkeleyDB version Berkeley DB 4.8.30: (April  9, 2010)
2019-02-03T19:02:35Z Using wallet test_alpha/wallet.dat
2019-02-03T19:02:35Z BerkeleyEnvironment::Open: LogDir=/home/hebasto/.bitcoin/testnet3/wallets/test_alpha/database ErrorFile=/home/hebasto/.bitcoin/testnet3/wallets/test_alpha/db.log
2019-02-03T19:02:35Z Using BerkeleyDB version Berkeley DB 4.8.30: (April  9, 2010)
2019-02-03T19:02:35Z Using wallet alpha_wallet/wallet.dat
2019-02-03T19:02:35Z BerkeleyEnvironment::Open: LogDir=/home/hebasto/.bitcoin/testnet3/wallets/alpha_wallet/database ErrorFile=/home/hebasto/.bitcoin/testnet3/wallets/alpha_wallet/db.log
2019-02-03T19:02:35Z Using BerkeleyDB version Berkeley DB 4.8.30: (April  9, 2010)
2019-02-03T19:02:35Z Using wallet wallet.dat
2019-02-03T19:02:35Z BerkeleyEnvironment::Open: LogDir=/home/hebasto/.bitcoin/testnet3/wallets/database ErrorFile=/home/hebasto/.bitcoin/testnet3/wallets/db.log
2019-02-03T19:02:35Z Using BerkeleyDB version Berkeley DB 4.8.30: (April  9, 2010)
2019-02-03T19:02:35Z Using wallet none/wallet.dat
2019-02-03T19:02:35Z BerkeleyEnvironment::Open: LogDir=/home/hebasto/.bitcoin/testnet3/wallets/none/database ErrorFile=/home/hebasto/.bitcoin/testnet3/wallets/none/db.log
2019-02-03T19:02:35Z init message: Loading banlist...
...

Tree-SHA512: 8dd4408d3f6b04f396dd0ae0d248fedc3a0f6d36788556ae1662443f06f2ecce1c2be9456bf8d1b3d25b29c2a0cfb03cb805bde0a40387e68988ab932e17e118

The CI is acting flaky again
I had one good run https://gitlab.com/dashpay/dash/-/pipelines/369583089,  after that, I rebased the same code changes to fixup/squash the commit into one commit and force pushed it  then with code changes observed https://gitlab.com/dashpay/dash/-/pipelines/369606293 feature_llmq_data_recovery.py test failing
After that tried to add some more changes to shake the CI then some "depend" failure starts occurring which is happening even after deleting the changes,
Does Anyone else also observe this type of behavior? @UdjinM6 @PastaPastaPasta

Gitlab itself is having issues atm https://status.gitlab.com/pages/incident/5b36dc6502d06804c08349f7/613f5ad56e8609053a627730, expect CI to fail until it's resolved

Oh I see, Thanks for updating me

Hello @UdjinM6  @PastaPastaPasta please have a look

Thanks, @UdjinM6 for comments, Implemented all review comments

@PastaPastaPasta  @UdjinM6,  Thanks for Review comments, I have Implemented them

Hello @PastaPastaPasta All review comments implemented


Update for changes in aerie#318

Tickets addressed: N/A
Review: By commit
Merge strategy: Merge (no squash)

Description
This PR updates the aerie-lander mission model for the changes in NASA-AMMOS/aerie#318. In particular, the aerie-lander.jar bundled with that PR was generated via ./gradlew assemble from this branch.
Verification
This branch builds against NASA-AMMOS/aerie#318, and tests on that PR pass.
(This branch will fail to build until it can access an aerie version with the changes in that PR, though.)

I believe the tests are failing here because our builds are pinned against the latest release of Aerie, whereas the changes this PR depends on have "only" been merged into Aerie develop.

Overtaken by #10 - in hindsight I should have used this PR as a starting point for #10. I was motivated primarily by the need to have a working Aerie lander for demonstration purposes.


Cannot find class com.microsoft.azure.keyvault.spring.AzureKeyVaultCredential

Environment

Spring boot starter:

azure-spring-boot 2.2.2

OS Type: MacOS

Java version:

1.8

Summary

When upgrading from azure-spring-boot 2.2.1 to 2.2.2, the com.microsoft.azure.keyvault.spring.AzureKeyVaultCredential class cannot be found. It has never been marked as deprecated, and we depend on this class in our code. It appears to have been deleted in this commit. Deleting this class (along with several others) is not mentioned in the release notes. I looked at other code changes in the commit, and it appears that usages of AzureKeyVaultCredential were replaced with ClientSecretCredential, but this requires the tenant ID, which we store in a key vault, which means that this is not an option for us.
Reproduce steps

Add dependency com.microsoft.azure:azure-spring-boot:2.2.1
Add import com.microsoft.azure.keyvault.spring.AzureKeyVaultCredential to a class
Upgrade azure-spring-boot to 2.2.2

Expected Results

The import of com.microsoft.azure.keyvault.spring.AzureKeyVaultCredential should still work.
Actual Results
Compiler error "Cannot resolve symbol 'AzureKeyVaultCredential'"

Hi @rossdevol, sorry for the late response because of the Chinese New Year Holiday.
Yep, there is a breaking change in version 2.2.2 because we update Keyvault SDK to             azure-security-keyvault-secrets. In this version, it use the new SDK (  azure-identity)  to do authentication. So AzureKeyVaultCredential has been deprecated. Sorry for the omit in Release Note, I will add this part into it.

Close this issue for now.


Add observers to WebXRCamera when a rotation is performed

Add observables onBeforeCameraTeleportRotation and onAfterCameraTeleportRotation to WebXRMotionControllerTeleportation.
npm run format:fix

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/14660/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14660/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14660/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14660/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14660/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14660/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14660/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14660/merge#BCU1XR#0

@RaananW Done!

Thanks! this is great. I guess we can add a proxy from the teleportation to the camera's observable and mark it deprecated on the camera. But this is a very low priority.

@RaananW that would be great. It crossed my mind to do that but I am focusing on other improvements currently, like adding a BVH file loader.


[BUG] redirect logged users when visiting "join community" pages

admins, recruiters, developers when logged in should be redirected to the developers page when they visit the /Join-Golang-Community or /Hire-From-Golang-Community pages
test locally
add redirect to handlers

/bounty $10

@dm161 I did not receive the bounty to my account yet....

check your account


update necessary

The Snakemake version in the template needs to be updated b/c of https://github.com/snakemake/snakemake/issues/1899 to at least 7.15.1. Given changelog entries for 7.16.0 and 7.18.0, updating to the latest 7.18.1 seems the most reasonable...

given more potentially relevant bug fixes, updated default env to Snakemake 7.19.1 (latest release), plus snakefmt to 0.8


[QUERY] Microsoft.Azure.Management.Subscription 1.1.0-preview version

Query/Question
I am using Microsoft.Azure.Management.Subscription 1.1.0-preview NuGet package for C# and need to know if this package is being deprecated, if so, what is the timeline and what are the breaking changes if I need to upgrade to the latest package.
Environment:

Name and version of the Library package used:   Microsoft.Azure.Management.Subscription 1.1.0-preview NuGet

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

Any inputs on this?
Madhura
From: msftbot[bot]<EMAIL_ADDRESS>Sent: Thursday, December 10, 2020 1:27 PM
To: Azure/azure-sdk-for-net<EMAIL_ADDRESS>Cc: Madhura Amlekar<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [Azure/azure-sdk-for-net] [QUERY] Microsoft.Azure.Management.Subscription 1.1.0-preview version (#17434)
Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @anuragdalmiahttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fanuragdalmia&data=04|01|madhura.amlekar%40microsoft.com|0ddfe3232ce245da37e008d89d418d05|72f988bf86f141af91ab2d7cd011db47|1|0|637432252148131833|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=GjCgRkDSV7PViPMcvb2ARNYObnTKP%2FClPvhpbno00Y4%3D&reserved=0, @ShilpiGautamhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FShilpiGautam&data=04|01|madhura.amlekar%40microsoft.com|0ddfe3232ce245da37e008d89d418d05|72f988bf86f141af91ab2d7cd011db47|1|0|637432252148141830|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=BFBp%2BmskBPD1hC0Cn59Oxu3DLAjGO3kR%2FluCQt3wF8I%3D&reserved=0, @ramaganesan-rghttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Framaganesan-rg&data=04|01|madhura.amlekar%40microsoft.com|0ddfe3232ce245da37e008d89d418d05|72f988bf86f141af91ab2d7cd011db47|1|0|637432252148141830|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=vFw0fWabWmiOQh59r1RmVcJEelslVRRJWNT8HVft1NY%3D&reserved=0.
Issue Details

Query/Question
I am using Microsoft.Azure.Management.Subscription 1.1.0-preview NuGet package for C# and need to know if this package is being deprecated, if so, what is the timeline and what are the breaking changes if I need to upgrade to the latest package.
Environment:

Name and version of the Library package used: Microsoft.Azure.Management.Subscription 1.1.0-preview NuGet
Author:
maamleka
Assignees:

Labels:
Mgmt, Service Attention, Subscription, customer-reported, needs-team-attention
Milestone:
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-net%2Fissues%2F17434%23issuecomment-742742468&data=04|01|madhura.amlekar%40microsoft.com|0ddfe3232ce245da37e008d89d418d05|72f988bf86f141af91ab2d7cd011db47|1|0|637432252148151821|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=K2j872xT%2BMawoTolwpawAOH9AuSrT1%2BJxB%2BEvNC0y70%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAL44IAWIVTIFLD54D5XEHJTSUEOH3ANCNFSM4UT47VYA&data=04|01|madhura.amlekar%40microsoft.com|0ddfe3232ce245da37e008d89d418d05|72f988bf86f141af91ab2d7cd011db47|1|0|637432252148151821|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=S%2FMBCjHE6GVE2We2S5yg6xZNC1TF2POymcPC6CAkqj8%3D&reserved=0.

Hi, the latest version is at https://www.nuget.org/packages/Microsoft.Azure.Management.Subscription/. This is actually the GA version of our APIs. Following is the breaking change release note. Note that as of now, we encourage you to adopt the GA version of the APIs vs the preview APIs, but we dont have any timeline when we will completely deprecate the preview version.
Breaking changes:
* This is the new release of Microsoft.Subscription
* SDK structure has been updated to make it more consistent and user-friendly:

Put Subscription Alias Api has been added to support subscription creation
2. Post CreateSubscription APIs have been removed as new subscription alias API provides the same functionality.