Don't prompt to save file on close when autosave: onFocusChange

Current flow when attempting to close a dirty editor when "files.autoSave": "onFocusChange":

Close editor
Dialog: "Do you want to save the changes you made to ...?"
As soon as dialog opens, focus leaves editor and it autosaves

I think we can just skip 2 all together and have it save then close on attempt to close if "files.autoSave": "onFocusChange" is enabled. Especially given the confusing UX that Don't Save wont revert the autosave it just performed.

So you're saying that you want the editor to save when the user clicks on the x?
Probably put a check here: https://github.com/microsoft/vscode/blob/6526fe0a1ade9d8f6e566811f4118191b84bf9f7/src/vs/workbench/browser/parts/editor/editorGroupView.ts#L1318
and here:
https://github.com/microsoft/vscode/blob/6526fe0a1ade9d8f6e566811f4118191b84bf9f7/src/vs/workbench/browser/parts/editor/editorActions.ts#L580
Don't know which one to add a check or maybe both? Can make a PR

Verification:

configure autoSave: onFocusChange
make a normal editor dirty and verify you are not being asked to save when either closing that editor or closing all editors (e.g. from the "Open Editors" close all action)
repeat the steps but this time have an untitled editor

closing the untitled editor should still prompt


[v1] Feature Request: A Policy's Resources input should be a dropdown

Is your feature request related to a problem?
Currently the Resources input only takes a list of strings, this should be reformatted to a dropdown which is tied to the API Group setting.
Solution you'd like
Based on the API Group selected show a list of resources that can be targeted. By default show the available resources for the core api group.

Reference 84d57d2

You can now select all available resources from a given list that is dependent on the apiGroup that is chosen for that particular rule set.


update josh instructions

This doesn't recommend the rebase yet as I am worried about what that will do to future syncs.
Cc https://github.com/rust-lang/miri/issues/2569

:umbrella: The latest upstream changes (presumably #2578) made this pull request unmergeable. Please resolve the merge conflicts.


MC Terraform Auto-Creates ECS/httpd reverse proxy and points it to the  Management ALB upon bootup

As a necessary prerequisite to getting https://github.com/unity-sds/unity-project-management/issues/71 done, we want to make sure that the ECS/httpd reverse proxy on the Unity-Sips-Test account (and any other future project deployment accounts) gets automatically created, and pointed to the Management Console ALB.  This will serve as a bootstrap for the remaining parts of the deployment process, and ensure that the Management Console is accessible network-wise.
Acceptance Criteria:

[ ] Project account API Gateway creation is already completed (https://github.com/unity-sds/unity-cs/issues/200 is implemented and working)
[ ] Project account deployment code (i.e. Terraform) contains a block that successfully adds the Management Console route

We discussed in 9/26 meeting that this creation is in the MC bootup

The MC LB URL will be populated by CloudFormation, and that value will be needed in this ticket.

MC is being provided with the LB URL per https://github.com/unity-sds/cfn-ps-jpl-unity-sds/issues/4

@frankinspace @buggtb  PLEASE NOTE THAT WE HAVE MOVED AWAY FROM APIGW in latest discussions.  We are evaluating the ECS (httpd) pointing to the ALB solution.  This linkage will still have to occur during the MC bootup actions.  I'm going to rename the title of this ticket, and update the description.

title/description updated

Thanks, I was trying to find a ticket describing the setup ECS setup and this one looked like it was the closest one

https://github.com/unity-sds/unity-proxy unity proxy repo now has the ssm params and stuff for deployment
https://github.com/unity-sds/unity-marketplace/tree/main/applications/unity-proxy/0.1 also has its entry and there is a hook in the MC to deploy it when it bootstraps


Ensure that jGit finds the .git directory

This PR should fix issue #24 in most cases by always passing the base dir of the maven project.
One area that is not covered is when using multiple worktrees, which could be considered as an edge case and an acceptable trade-off.

Hi, any news on this? Would be great if this could be merged. Till now we have to rename the extensions.xml in local development so it will only be used in our gitlab pipeline build.

Thank you for the contribution @olivier-hubaut.
Apologies for the delay in getting to this. Change looks good to me but it appears that Github Actions aren't triggered. It is supposed to ask me for approving the GH Action execution on first-time contributors but it just in the waiting mode. When @bjsee  sent his PR about regex, it worked well. LMS what is happening here. I might push an empty commit to this PR and see if that allows me to trigger it. I hope thats okay.

This is released with v0.9.1. Thank you!


"linkage() function mistakes distance matrix as observation vectors"

this is to handle issue # 2614 ( scipy#2614 )
"linkage() function mistakes distance matrix as observation vectors"
If input to linkage() is a 2-dimensional matrix, it is first checked by predicate is_valid_dm(). If it is a distance matrix, it is converted to condensed vector. Otherwise it is considered to be observation vectors and condensed distance matrix is calculated using pdist() function.

This is addressed in #6342, so I'm closing it.


Separate safe and unsafe math operations

As discussed in #993.

Mathematic and logical operations are now fully defined by default for every input. This change includes:

Numeric conversions from/to floating point saturate if the value doesn't fit in the destination type
Signed integer division returns 0 on overflow (e.g. I8(-128) / -1)
Left shift by more bits than the type width returns 0
Logical (unsigned) right shift by more bits than the type width returns 0
Arithmetic (signed) right shift by more bits than the type width extends the sign bit on the low bits
Left and right bit rotate work correctly for amounts greater than the type width
Signed rotate is removed
Shift and rotate now take an unsigned amount as argument
popcount, clz, ctz and bitwidth now always have an unsigned return type

Add unsafe operations that can have undefined results for some inputs but can be faster and allow better optimisations. Unsafe functions are suffixed with _unsafe. This change includes:

Unsafe numeric conversions. If the value doesn't fit in the destination type, the result is undefined
Unsafe addition, substraction, multiplication and negation. For integers, the result is undefined on overflow. For floating points, fast math semantics are enabled
Unsafe division and modulus. For integers, the result is undefined on division/modulus by 0. For floating points, fast math semantics are enabled
Unsafe left shift. On overflow, the result is undefined
Unsafe right shift. If non-zero bits are shifted out, the result is undefined
Unsafe floating point comparisons. Fast math semantics are enabled
Unsafe square root. If the operand is negative, the result is undefined. Fast math semantics are enabled
Unsafe clz/ctz. If the operand is 0, the result is undefined.

Fast math semantics mean that the result is undefined if the computation involves NaN and/or +/- infinity. In addition, full compliance to IEEE-754 isn't required.
For reference, the semantics of undefined results and of the associated as-if rule are defined as follows.
As-if rule
The compiler is permitted to perform any changes to the program as long as the following remains true for every behaviour in the program.

At the end of a behaviour, the associated actor is exactly in the state it would be if the program was executed as written
If an object has a finaliser, that finaliser will eventually be called exactly once
Messages are sent as if the behaviour was executed as written, in the same order and with the same contents.
FFI calls to well-defined C functions are executed as written, in the same order and with the same arguments. The runtime functions (every function prefixed with pony_) are free from this rule and from the following one.
Message sends and FFI calls are not reordered with respect to each other.
Capability security (both object capability and reference capability) is maintained.

Undefined results
If an expression with undefined results is evaluated:

Every subsequent expression depending on udefined result also has undefined results.
If the constructor of an object with a finaliser has undefined results, that finaliser isn't guaranteed to be called.
If a message send or a FFI call has undefined results, it is free from the as-if rule.
The implementation is allowed to generate platform-specific exceptions (which are not Pony exceptions).
Capability security is always maintained.

Can we take this opportunity to also add some arithmetic tests corresponding to the semantics that were ironed out?
Obviously we can't test for undefined behaviour but at least we can test key parts of the defined domain of these functions.

You're right. I'll add that.

I also forgot to update the pony.g file. I'll fix that.

The build failed with an assertion failure on OSX and I don't really see what could be wrong. Could somebody on OSX try running the compiler with the code here and see if the assertion failure occurs? If it does, a debugger call stack trace would be great to identify the problem.

@Praetonus the code that triggers the failure on OS X is:
class iso _TestNumberConversionSaturation is UnitTest
  ...
  fun float_to_ints[A: (Float & Real[A])](h: TestHelper) =>
    float_to_int[A, I8](h)
    float_to_int[A, I16](h)
    float_to_int[A, I32](h)
    float_to_int[A, I64](h)
    float_to_int[A, ILong](h)
    float_to_int[A, ISize](h)
    float_to_int[A, I128](h)

The unsigned counterparts don't cause trouble.

@malthe Thanks. I think I figured it out.

Can anyone with OSX grab this PR and run it in a debugger to get a stack trace for @Praetonus?
I might be able to do it in a couple weeks but I can't until a work project is finished.

CHANGELOG was updated for 0.9.0 release. This will need to be rebased to pick up those changes and verify the CHANGELOG entries are correctly in the "unreleased" section

CHANGELOG update for 0.10.0 release means that you will need to rebase verify the entries are correctly in the "unreleased" section.

I think I found the problem in this. I also updated the changelog entry, this should be ready for review & merge if CI passes.

Note that this change will probably have some (quite small, I think) performance impact on the standard library. I'll make a followup PR to use unsafe maths in the standard library where function contracts guarantee it won't explode, so that we can minimise that performance loss.

Rebased to catch up changes to the changelog.

Conflicts resolved.

Is this good to merge @Praetonus?

Yes, I think it is.

Conflicts resolved.


I am not able to launch in IOS , only

I am facing an issue, after adding this dependency in pubspec.yaml,
[VERBOSE-3:FlutterPlatformViews.mm(154)] Check failed: factories_.count(idString) == 0.
And app is crashed in IOS
@Team! can you please help me asap

@singhBijendraIOS Can you please include a full log.

Reopen if the issue persists.

i have same issue @singhBijendraIOS can you please share solution.


Add assert_not_regexp_match

By request from @mikewest
TODO docs, tests

LGTM % a phrasing nit. Thanks!

I am slightly against this in principle; I think there are only a small number of cases where the right thing to do is to allow almost any input to pass except as small set of inputs that fail. It's not too difficult to write this out by hand in the few cases where it's really needed.

OK, closing


feat: 3444 Add MacOS specific switch tabs keyboard shortcuts

Closes #3444
MacOS shortcuts for switching tabs next and previous is now Cmd+SHIFT+[  and Cmd+SHIFT+] respectively. Window shortcut remain Control+TAB and Control+SHIFT+TAB respectively.

Thanks @barmac !
I implemented it where @nikku had pointed out

Seems like we need MacOS specific switching here.

Please confirm that my course of action is to undo these changes in menu-builder.js and implement them in mac-menu-builder.js ?
If that is the correct, as I understand your comment:

Also, we want to keep the Ctrl+Tab / Ctrl+Shift+Tab shortcuts on MacOS too, as it's an established pattern to have dual shortcut, cf. how Google Chrome and Safari handle it. Check out https://stackoverflow.com/questions/57081237/electron-js-multiple-accelerators for a guidance how to implement it.

I should implement both sets of shortcuts in mac-menu-builder.js (?) or will the shortcuts in menu-builder.js be inherited and both sets of shortcuts will be available for use in MacOS?
Thanks!

Cody

I guess additional (visually hidden) shortcuts in mac-menu-builder would be sufficient.

I've updated the PR to have both the original shortcuts of Ctrl+Tab / Ctrl+Shift+Tab as well as including the CommandOrControl+SHIFT+] / CommandOrControl+SHIFT+[ via hidden menu items, as @nikku  had suggested.
I was having problems trying to get the mac-menu-builder.js to override the switch tab functionality in menu-builder.js hopefully this will suffice.

The mac-menu-builder works by overriding the Menu Builder methods. No magic here. Read more on inheritance at https://www.w3schools.com/js/js_class_inheritance.asp
I added the required implementation and will squash this PR after CI run.


Rename openssl_user_macros -> openssl-user-macros

I also removed the doc/build.info.in file and the ability to auto-generate the list of doc files. This is the start of a "thread" to minimize the amount of Perl needed to build QuicTLS (or at least localize it)
Checklist
Thank you for your contribution. Please answer the following:

[x] I acknowledge that I am authorized to submit this code under
the terms of the Apache License
[ ] All new public APIs are documented
[ ] All new public functions have tests
[ ] All new public functions have fuzzing tests

Never mind.
; find doc -name '*_*pod' | wc -l
     775

; find doc -name '*-*pod' | wc -l
     181


Model for Children

Looks like I have to switch from GET /drive/root:/{item-path}?expand=children to GET /drive/root:/{item-path}:/children. Sadly there doesn't seem to exist a model for that call. What must the model look like? Is the following enough?
public class Children {
    @SerializedName("value")
    public List<Item> Children;

<EMAIL_ADDRESS>    public String NextToken;
}

Looking at Item, there is a "List Children" defined there, if you add the expansion clause you should be able to retrieve children with that call.
If you look at https://github.com/OneDrive/onedrive-explorer-android/blob/master/app/src/main/java/com/microsoft/onedrive/apiexplorer/ItemFragment.java#L321 you can see how the expand clause is added to the item request

@peternied Thanks for the reply. Seems like you got me wrong.
What I've got up and running is GET /drive/root:/{item-path}?expand=children. Runs fine and I can access the children via Item.Children. But as I need to query more than 200 (and more than 1000) items I'll have to switch to GET /drive/root:/{item-path}:/children, query the children directly and use the pagination token to get all results.
Question is: Is there a model that matches the result GET /drive/root:/{item-path}:/children returns? I guess not - at least I don't see a fitting one. The mentioned API-call returns {value:[Item]} (plus @odata.nextLink for pagination).
Question 2 is: Do you think that the class I described above will suit the result? Guess I'll just give it a shot.

This issue can be closed, above code runs fine.

FYI - We are actively building our legit SDK now, and one of the things we are baking into the design is supporting pagination on the expansion items, for scenarios exactly like this.  If you have a solution that you'd like to push into this example that would be awesome, but as a team are keeping our heads down on the overall SDK effort at the moment.

Good to hear that.
I'm using the above code now. Extracting the query from the nextLink and fetching additional results is pretty straight forward (though Uri.parse() seems to choke on braces or something so I had to use regexes).
I was thinking about a prettier, self-contained approach like
public class Children {
    @SerializedName("value")
    public List<Item> Items;

<EMAIL_ADDRESS>    public String NextToken;

    // fetch next items if possible and update this.Items w/ the result, return false on EOR
    public boolean next(){}
}

but I guess I won't touch my code anymore.


How does RRateLimiter set the expiration time of permits and values?

Looking at the source, try converting RRateLimiter to RedissonRateLimiter and then use its expireAsync method:
    public RFuture<Boolean> expireAsync(long timeToLive, TimeUnit timeUnit, String param, String... keys) {
        return super.expireAsync(timeToLive, timeUnit, param, new String[]{this.getRawName(), this.getValueName(), this.getClientValueName(), this.getPermitsName(), this.getClientPermitsName()});
    }

   protected RFuture<Boolean> expireAsync(long timeToLive, TimeUnit timeUnit, String param, String... keys) {
        return this.commandExecutor.evalWriteAsync(this.getRawName(), LongCodec.INSTANCE, RedisCommands.EVAL_BOOLEAN, "local result = 0;for j = 1, #KEYS, 1 do local expireSet; if ARGV[2] ~= '' then expireSet = redis.call('pexpire', KEYS[j], ARGV[1], ARGV[2]); else expireSet = redis.call('pexpire', KEYS[j], ARGV[1]); end; if expireSet == 1 then result = expireSet;end; end; return result; ", Arrays.asList(keys), new Object[]{timeUnit.toMillis(timeToLive), param});
    }

This method seems to set the expiration time of permits and value, but it is found to be invalid after experiments, and only the expiration time of the current limiter can be set. Is there a way to deal with it?

Can you describe the issue? Why expire methods RExpirable interface isn't enough?

First I use the method.like:
rRateLimiter.expire(24, TimeUnit.HOURS);

But only the expiration time of the current limiter is valid

I want to set  expiration time of the "permits" and "value",but they  expiration time is -1:

Is so much key in my redis, but want to invalidate them.
I had tried another method,like
expireAsync(long timeToLive, TimeUnit timeUnit, String param, String... keys)

but also not work

Which Redisson version do you use?

3.17.1

Unable to reproduce. Below is the test code.
        RRateLimiter rateLimiter = redisson.getRateLimiter("test1");
        rateLimiter.trySetRate(RateType.OVERALL, 10, 10, RateIntervalUnit.SECONDS);
        rateLimiter.acquire();

        rateLimiter.expire(15, TimeUnit.SECONDS);

        Thread.sleep(20000);

        assertThat(redisson.getKeys().count()).isZero();

My test code,
        RRateLimiter rateLimiter = redissonClient.getRateLimiter("test1");
        rateLimiter.trySetRate(RateType.OVERALL, 10, 10, RateIntervalUnit.SECONDS);

        rateLimiter.expire(100, TimeUnit.SECONDS);

        rateLimiter.acquire();

        Thread.sleep(20000);

initialized rateLimiter and set expiration time before invoke acquire method.
think that rateLimiter should be initialized expiration time first ,then use acquire or tryAcquire method.

Fixed. Thanks for report


added thank you modal

solves: #648
I have added the thank you modal. It has a "ok" button which closes the modal. I have also added confetti effect.
https://github.com/Anushkabh/krishiconnect/assets/152094228/15507e98-aeef-4f6a-b646-ceaff2115b3d

ok I will improve resolve the issue.

you can review the pull request i have resolved the issue. Now the thank You message pops up only when cart is filled.
Screen Recording 2024-07-02 180158.zip


Validate pk in job api url

Summary
Validate pk in the job api url to prevent SQL Injection
Details and comments

At the-end I think this PR doesn't apply, I think. Should we close it @akihikokuroda ?

OK. I close


User-reported unhelpful error message

Program: https://code.world/#PSQv5_AO75YVPxOQvByspcg
Message:
program.hs:1:1-12: error:
    Parse error: An equation was expected here.
    Are you missing the equal sign?

Missed this.  I don't see anything obvious to do to fix it.


movement system

wasd is moving a bit weird, arrows are doing the same movements - apparently this isnt supposed to happen
maybe we should consider having one set for camera angles and one for forwards, backwards, left, right

we fixed it yipee


Update select-transact-sql.md

See https://github.com/MicrosoftDocs/sql-docs/issues/4764

@HugoKornelis : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@VanMSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hey @HugoKornelis - Thanks for this, but column_positio and [ ,...n ] should not be removed. It is part of the syntax. https://docs.microsoft.com/sql/t-sql/language-elements/transact-sql-syntax-conventions-transact-sql. I think carets make more sense in this case.

Hi Van To,
Please read the issue I raised earlier and its comments. Then carefully
review my proposed change. You will see that |column_position| and |[
,...n ]| are both included in the detailed description of the ORDER BY,
on page
https://docs.microsoft.com/en-us/sql/t-sql/queries/select-order-by-clause-transact-sql?view=sql-server-ver15
My proposed change makes it clear that users should check that page for
the syntax details. This solves issue 4764.
Frankly, it really should not be this difficult for users to contribute
a simple improvement to your documentation.
Regards,
Hugo
Op 21-10-2020 om 15:56 schreef Van To:

Hey @HugoKornelis https://github.com/HugoKornelis - Thanks for this,
but |column_position| and |[ ,...n ]| should not be removed. It is
part of the syntax.
https://docs.microsoft.com/sql/t-sql/language-elements/transact-sql-syntax-conventions-transact-sql.
I think carets make more sense in this case.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/sql-docs/pull/5605#issuecomment-713596104,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADJXKBLOFFHDPMAFT2JGGE3SL3R7HANCNFSM4SZZWBXQ.

@VanMSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks, @HugoKornelis! I see your point. I'll go ahead and approve the changes. Thanks again for taking the time on this.
#sign-off


Where in the code do the actors receive new parameters from the Learners?

I'm sure it is in there somewhere, but I don't see it.

It happens implicitly. The parameters are shared (with tf.device(shared_job_device):) so at every run call on an actor, the parameters are copied (and cached for the entire run call) to the actor.


Auto Disk Ripper Change Output Directory

Would it be possible to add the option to use the Disc Source Name instead of the Disk Label for the output directory?

It seems that the disk name cannot be obtained without having to fully open it.  In other words, it is not an information that is known before starting the ripping process.  At least, this is not something offered currently by the MakeMKV cli.

Closing this issue.  Please re-open if needed.


mimetic will fail the build with gcc-11: error: ordered comparison of pointer with integer zero ('char*' and 'int')

gcc-11 now disallows ordered comparison against pointers:
$ nix-build -E 'with import <nixpkgs> {}; mimetic.override { stdenv = gcc11Stdenv; }'
...
mmfile.cxx: In member function 'bool mimetic::MMFile::map()':
mmfile.cxx:60:14: error: ordered comparison of pointer with integer zero ('char*' and 'int')
   60 |     if(m_beg > 0)
      |        ~~~~~~^~~

Notify maintainers
@leenaars
Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute: mimetic

Closing as INVALID.


Cluster Controller should update Package Controller

Maybe this is in there already, but I don't think the cluster controller currently updates the package controller. If a new EKS Anywhere bundle is applied, the package controller should be updated. We need to at least test to verify this works.

I'm told this is done


Apollo 2.0 version

I know it is still in beta, but it would be great to start playing around with v2.
So after following this tutorial, I wanted to upgrade to Apollo 2 beta but I'm having trouble to get it working.
The upgrade guide is still quite incomplete: https://github.com/apollographql/apollo-client/blob/master/Upgrade.md
If someone can get a working version of this repo with Apollo 2 beta would be great. We might keep it in a separated branch.

Just happened 🎉


test fail

The test window remains blank and does work.

$sudo howdy test
Opening a window with a test feed
Press ctrl+C in this terminal to quit
Click on the image to enable or disable slow mode
X Error: BadAccess (attempt to access private resource denied) 10
Extension:    130 (MIT-SHM)
Minor opcode: 1 (X_ShmAttach)
Resource id:  0x4600003
X Error: BadShmSeg (invalid shared segment parameter) 128
Extension:    130 (MIT-SHM)
Minor opcode: 5 (X_ShmCreatePixmap)
Resource id:  0x460000d

Please use the search function before opening a new issue. An open issue with this exact error and a solution can be found at #60. Your error is even in the title.

I'll keep in mind next time and thanks for the solution


Event aggregate interfaces

@rultor merge

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 1min)


Strip first two directories instead of keeping the last two

Since we don't know how many subdirectories there will be, we'ld rather strip the leading /dist/dev directories instead of keeping the last two.
Note: Even though we only want to get rid of two directories, the starting index needs to be 3 because the first forward slash is its own value.

@Groschenroman makes sense. Would you rebase and push again?

Something went wrong with the rebasing (it was challenging to get it anyway…).
I'll close this PR and open a new one.


moving integration tests to graph unit tests

Addresses #12255
Signed-off-by: Srini Brahmaroutu<EMAIL_ADDRESS>

@cpuguy  @jfrazelle  please review.

LGTM

LGTM


Allow dragging images from web browser into VSCode explorer

Currently it's possible to drag and drop files from Windows explorer into the VSCode Explorer. It's also possible to drag and drop files from a Web browser (Chrome) into Windows Explorer.
It'd be nice to also be able to drag and drop files directly from the Web browser into VSCode, instead of having to first drag it into Explorer and then VSCode.

Somewhat duplicate of https://github.com/microsoft/vscode/issues/91132

That issue seems to be describing an issue of dragging from VS Code --> Other apps, where this issue is talking about Other apps --> VS Code. Are you sure that it's the same issue?

We can reopen this one if you prefer. Point being if we start looking into improving the DnD behavior we will look it at both directions

IMO, it makes more sense to keep this one open, to avoid falling off the radar completely. Wouldn't want someone to later pick up that issue who doesn't have any context for this issue, and then not realize that the problem is in both directions.

Hey,
there were never any updates here is this going to implemented anytime soon ?


chore(main): release 1.3.4

:robot: I have created a release beep boop
1.3.4 (2023-02-06)
update

更新页面布局 (746020d)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/School-of-Website-Engineering/TinyWaste/releases/tag/v1.3.4 :sunflower:


Link in readme is incorrect

Formatting guide with examples (the C# version of the library currently doesn't implement all the formatters, but they will be added as needed): https://messageformat.github.io/messageformat/page-guide

This link in the Repository's readme leads to a 404. The correct link would appear to be https://messageformat.github.io/messageformat/ or https://messageformat.github.io/messageformat/guide/

This issue can now be closed, fixed in PR #590
Thanks for finding this!


Disable default features for chrono, avoid CVE

By default the oldtime feature is enabled, which brings in the deprecated version of time dependency, which exposes dependency the risk of CVE-2020-26235.
This fix manually disables the oldtime feature of chrono.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Superseded by #193


testing a dotnet core class library with Specflow

I've been trying to understand what this means for a couple of days now. My understanding (probably totally wrong) was that i could use VS2017 to develop a DOTNET CORE class library and then test it using another DOTNET CORE Test Project, using the SpecFlow.NetCore NuGet package (and modifications to the app.config).
The behaviour appears conflicting.
The .feature.cs gets generated but the Techtalk.Specflow library is missing.
If I include SpecFlow 2.1.0 the build fails with incompatible .net versions.
Am I simply trying to use this in an impossible way or is there a workaround.
We use Specflow universally and a attempting to start a DOTNET CORE project right now and failing miserable.
Thnaks

Hi Jim! I had exactly the same problems: “.feature.cs” gets generated with TechTalk references or I get “incompatible .NET versions” error. I ended up moving all of the logic out into a separate .NETStandard 1.4 class library, referenced it by original .NETCoreApp 1.1 project and had .NET 4.6.1 SpecFlow Test project testing just the business logic in 1.4 class library the “old” way.

As @erik-lundgren mentioned, it is a case of SpecFlow still being stuck on full framework (see #39).
@igor-1024's suggestion is the best workaround for now.


How to hide  image , or set image content to nil

I need to reset image content to nil. Kindly advise how.
Thanks.

Yep this works ok!
Great working library man @huynguyencong , thx!

You're welcome


Using /reconnect says Unknown command

Describe the bug
Using /reconnect says Unknown command
To Reproduce
Steps to reproduce the behavior:

Type /reconnect in any window
You'll get the error Unknown command

Expected behavior
User should reconnect to the current network

Thanks for the bug report. This fix will be part of v6.02.


Networking/Windows Time Service: TechNet blog URL

Description:
As reported in issue ticket #4449 (Link to announcement blog broken), the TechNet blog URL redirects to the Tech Community Networking topic.
This PR resolves the broken redirect by using the new URL to the blog.
Thanks to @troyphil for reporting the URL redirect issue.
Changes proposed:

Replace the outdated technet URL with the new techcommunity link (3)
Update metadata date field to annotate the change (needs future changes anyway)
Whitespace corrections:

Remove redundant end-of-line blanks
Add MarkDown indent marker compatibility spacing (3)
Normalize number of contiguous blank lines to 2
Normalize bullet point list spacing to 1 space (7)
Remove nonstandard whitespace (different from blank) (1)
Add missing NewLine (line break) at end-of-file

Ticket closure or reference:
Closes #4449

#sign-off


Add Screen Snip Windows + Shift + S to Shortcut Guide

Summary of the new feature/enhancement
Please add Windows + Shift + S to the Shortcut Guide.
Screen Snip is a great tool for taking screenshots rather than pressing Print Screen key. I always forget about which shortcut was for the Screen Snip, please consider adding it.
Proposed technical implementation details (optional)
Please note that Windows + Shift + S key combination enabled after Creators Update. So depending on the WIndows version the key combination changes. The key combination used to be Alt + M but not anymore.
Also OneNote 2016 might collide with the Screen Snip feature. OneNote's screen clip registry is under this path:
"HKEY_CURRENT_USER\Software\Microsoft\Office\16.0\OneNote\Options\Other"
ScreenClippingShortcutKey is the DWORD registry key to override Screen Snip's shortcut. If the shortcut is overridden by OneNote, maybe a message can be shown next to the shortcut guide.

Hi @BuraChuhadar, thanks for your suggestion!
The Win + Shift + S was already proposed in https://github.com/microsoft/PowerToys/issues/379. We are working on adding those and other shortcuts to the Shortcut Guide.


Support "advanced mode" yaml editor for EKS driver

We have gotten many requests for small enhancements and tweaks to our EKS integration. We are addressing them one-by-one by exposing new fields for EKS, but EKS works by creating a K8S control plane and then use several cloud formation tempaltes to create the networking, storage, and VMs for the worker nodes. This means that the literally anything you can do in EC2 is possible. We won't be able to support every single enhancement request for EKS.
So, as an alterantive, we want to expose an "advance mode" where we expose the cloud formation templates we are using to create the worker nodes (and their networking and storage) and let the user edit them in the UI and just use exactly what the user submits for those yaml files.

I havent thought through the design/implementation in detail, so first thing we need is an analysis of if it can be done, how it can be done, and how long it would take.

This will also fix  #16730


fix(artifacts): support optional input artifacts, Fixes #3491

…proj/argo/issues/3491
Checklist:

[x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
[x] The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
[ ] I've signed the CLA.
[ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
[ ] My builds are green. Try syncing with master if they are not.
[ ] My organization is added to USERS.md.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


RFC: Restructure data models to use more default relationship handling

I've had a quick look through the data model relationships in this module.
ElementalArea defines OwnerClassName and handles its value internally. This should really be at polymorphic has one relationship.
This is presumably so that things other than pages can have Elemental applied to them, for example if a dev was using DataObjects as pages and not using the CMS.
The owner (page etc) should also have the ability to define extra has_one ElementalAreas to add new areas.
The way I see it is:
- Page (or other)
  - has_one "ElementalArea" (default)
    - has_one "Owner" (inverse relationship - polymorphic)
    - has_many "Elements"

- BaseElement
  - has_one "Parent" ElementalArea

The API should support us accessing:

the page from the element (via the elemental area or parent elements) e.g. $page = $element->getPage() (pre-existing API)
the page from the elemental area e.g. $page = $elementalArea->getPage() (currently is called getOwnerPage, polymorphic relationship would make it Owner())
the elemental area from the page e.g. $page->ElementalArea()
the elements fro the page (via elemental area) e.g. $elements = $page->ElementalArea()->Elements()

Also the terminology - in some places we refer to "Owner" and others we refer to "Page". These should be standardised to "Owner" (wary of potential Extension conflicts with extending this code though). Another option Container().
I guess my RFC is to remove the custom Owner handling in ElementalArea and make it a polymorphic has one. This should be reasonably backwards compatible, but we also have the opportunity right now to make breaking changes in master for elemental 4.x.

Basically, there is a fair amount of technical debt and responsibility in methods such as ElementalArea::getOwnerPage() that could be alleviated by using out of the box ORM relationships in this instance

Huge 👍 from me. I think this is a great time to essentially fix this.

More core; more default; more betterer 👍

Yep, we should use core features where available. The owner terminology is also used for DataExtension, so if you're using an extension on a block, you'll end up with $this->getOwner()->getOwner(), which is a bit weird. But that can be make clearer through $block = $this->getOwner(); $page = $block->getOwner(); so I'm not too concerned.
Does this have performance implications? If so, I'd consider this impact/high in terms of prioritisation.

The performance implications should've been resolved in #368

This could be adjusted to include versioning the relationship. Currently publishing a page does not remember the version of an elemental area (and the blocks within the area)

Currently publishing a page does not remember the version of an elemental area (and the blocks within the area)

This is discussed at https://github.com/silverstripe/silverstripe-versioned/issues/195, let's split this out from this data modeling discussion if possible.
@robbieaverill The resolution to the performance aspects was described as "fixed in project code". Assuming that it's not acceptable for every larger scale blocks implementation to have project specific performance workarounds, is there work left on this card?

I think it still makes sense to refactor the relationships for elemental - They're still not very sensical. However I think it has missed the cutoff for 4.0 and it's questionable how much of a performance difference it will make right now. Changing it to use a more standard approach would mean that updates to ORM performance would be inherited here though.
TL;DR I think this issue should remain.

I agree with @ScopeyNZ - we should look at the architecture of the model relationships here.
@chillu re your question about the project code, we added optimistic relationship list caching in the project. The problems with elemental and performance are really framework problems, so the "eager loading" RFC would probably be the required step to fix this for everyone I guess

Example of a bug that probably wouldn't exist if we did this: #671


Update tutorials.rst

Typo mentioned in https://github.com/IMRCLab/crazyswarm2/discussions/529#discussioncomment-9859984

I've also fixed another part of the installation as well that someone mentioned in discussions https://github.com/IMRCLab/crazyswarm2/issues/526#event-13251592566


Add 16 KB support for Android 15

Hi, Android 15 is introducing a 16 KB page size development mode and asking new apps to work in this mode, so that future devices can use 16 KB pages. You may want to ensure your SDK works in this mode, so that app developers using this software package don't have to update themselves. Thank you!
Read more at https://developer.android.com/16kb-page-size.

Thanks for the heads up.
Do you see any specific issues that need to be fixed in glog? Other than that, we do not provide Android binaries. Users can decide themselves whether they enable 16 kb page size support or not.

No, I don't see any specific issues. 16 KB page size should be the default build alignment - it will work on 4 KB and 16 KB devices.


cleanup api implementation

Signed-off-by: Vasiliy Tolstov<EMAIL_ADDRESS>

@hzhou8 this is first try to cleanup and rename all stuff.
I don't know about idiomatic names for methods like ASAdd...
May be Client need to have methods like
AddressSet()
LogicalSwitch()
...
they returns interface type with needed methods. For ex LogicalSwitch() return
type LogicalSwitch interface {
Add(xxx)
Del(ssss)
List()
Get(xxx)
}
what do you think?

this pr waiting for https://github.com/eBay/libovsdb/pull/11

rebased, merged and fixed

@hzhou8 please check this too, if all ok and it will be merged i can push first steps to automatic unmarshaling map[string]interface{} to struct of needed type


adds MudTabNavLink and MudTabNavGroup (#4137)

Description
Adds navigation to Tabs with two new controls: MudTabNavLink and MudTabNavGroup
see #4137
How Has This Been Tested?
Only visually yet
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[ ] I've added relevant tests.
[ ] Css classes have to be created

(this is from the issue)

@Garderoben : I now have some time to implement it. You asked to implement this without MudTabNavMenu but with MudTabs (which makes sense to me) and without MudTabNavGroup. The latter I don't understand, how should we declare groups then? The NavMenu also does this via MudNavGroup. I think it is quite convenient for the user if we keep the naming and how its implemented, or?
What are your thoughts?

My though was not to support groups, it kinda makes no sense to have it for tabs.
I will / we will add a horizontal navmenu options in the future that should of course have groups but for tabs i think we should skip it since the breaks the whole point of tabs.

My though was not to support groups, it kinda makes no sense to have it for tabs.

Okay, I see your point that tabs itself are a little bit abused to use as whole horizontal navigation. But I am not that sure that if we don't support groups, if it is very useful. My company for instance does need groups, otherwise it can't be used by us.
Maybe an idea would be to use it as it for now (with groups) and remove it again in the future entirely when the horizontal navigation comes out? The horizontal navigation, if I understand correctly, will be a completly new component?

My though was not to support groups, it kinda makes no sense to have it for tabs.

Okay, I see your point that tabs itself are a little bit abused to use as whole horizontal navigation. But I am not that sure that if we don't support groups, if it is very useful. My company for instance does need groups, otherwise it can't be used by us.
Maybe an idea would be to use it as it for now (with groups) and remove it again in the future entirely when the horizontal navigation comes out? The horizontal navigation, if I understand correctly, will be a completly new component?

I agree with @Garderoben that it doesn't make sense to add drop down menus for tabs. I am against merging this PR just as a workaround for horizontal nav menus like you suggested. That would just create unnecessary breaking changes

Okay, sp I will remove the MudTabNavGroup again from this PR and will use for our software my own implementation, if there are no other thoughts?

Okay, so I will remove the MudTabNavGroup again from this PR and will use for our software my own implementation, if there are no other thoughts? Or should we cancel this completely and wait for the horizontal nav?

No please continue but remove the MudTabNavGroup and it will be merged after reviewed.
On a side note i have experimented a lot lately with horizontal navmenu in other apps using MudBlazor, the issue there is not how i can make it its rather i haven't made up my mind for best solution.

@maxreb sorry, is everything done, should i review/check it again?

@maxreb sorry, is everything done, should i review/check it again?

I'm currently on vacation, but I had an idea how the implementation maybe could be a little cleaner as we don't use the groups anymore. I will check it mid next week and will mention you here if the code is ready :)

@Garderoben Now I'm done. I tried to find a way to make it work with NavLink but there is no way, as we can't get a ElementReference from NavLink so we have to use a and NavigationManager. In the last commit I added support for INavigationEventReceiver


Pinch to zoom is not working

It seems like "Pinch to Zoom" is not working.
Calling  camera.setZoom(CameraKit.Constants.ZOOM_PINCH);  doesn't work.
Can you resolve this issue quickly.

This is not implemented yet, so there is nothing to "resolve".
If you read the README, you'll see:
Coming soon: Built-in pinch to zoom.
The code to enable the option is in the lib, but the functionality is not there yet.

having huge client demand for this feature, hope it gets implemented soon

i added pinch to zoom, pull #72

Hi sir i am using this version of the library com.flurgle:camerakit:0.9.17 is pinch zoom is intergated as tried it .Its not working sir

@android-dataticket  i had tried your pull request but pinch to zoom is not working

@android-dataticket i had tried your pull request but pinch to zoom is not working

I took @android-dataticket pull request and integrated into my fork, I had to do a few things to get it working such as passing on the onTouchEvent, I also switched over to a gesture scale. It isn't working perfectly yet, but it is close. I am using jitpack and have a release tagged https://github.com/adamwlarson/CameraKit-Android/releases/tag/1.0.4

sorry I've sorta abandoned this thread @adamwlarson - I made the pinch to zoom pull request and then had to make some more adjustments to get it to work and never updated the PR
looks like you figured it out, i think the creator of this library has abandoned it.. i gave up.
i have a working fork that i use in my app and haven't updated it in months, it gives me some memory issues here and there but it works for the most part, i wish this library was a little more up-kept by the creator but oh well, he's a busy young man i guess

any one to solved this problem  plz tell me i was finding from long time

Has anyone solved this issue, yet? Pinch to zoom is critical to my app and everything else about this fits my app well except the lack of zoom

@abhisheksingapore @KalpeshJadvani I've updated the pull request with some changes that I made afterwards which work for my application

@android-dataticket please confirm when can i get the pinch to zoom feature?

@android-dataticket Can you reOpen the PR? @aravindhkumar23 this is something we are working on, you can expect it in the next week.

@austinkettner i am not that great of a programmer and what i've done is forked and tweaked to work with only my application.. for instance consider the following:
in my PR, i remove DisplayOrientationDetector - some may need this, but i did not
in my PR, i removed the handleFocus(event, params) method call, it gave issues when touching the screen to pinch
i also add some quirky try catches and thread sleeps, but if you really want me to do a fresh PR, i will fork a new copy and upload the files that i've changed

@android-dataticket No worries! Thanks for the clarity, we are actually working on a solution to this today internally, so no PR needed! Really appreciate your willingness to help though! =)

Hi @austinkettner any updates regarding pinch to zoom feature? or any workaround to get it done?
i have been waiting for this feature to be implemented in one of my project..

@aravindhkumar23 We actually just pushed this in the release/0.13.0 branch (https://github.com/wonderkiln/CameraKit-Android/tree/release/0.13.0), check it out via compile 'com.wonderkiln:camerakit:0.13.0-Snapshot'

when i use compile 'com.wonderkiln:camerakit:0.13.0-Snapshot'
i get error msg when building gradle

Failed to resolve: com.wonderkiln:camerakit:0.13.0-Snapshot

when i use compile 'com.wonderkiln:camerakit:0.12.0' the gradle builds successfully
but i face issue in using listener events

cannot find symbol class CameraListener

my app build.gradle is here
android {
    compileSdkVersion 27
    buildToolsVersion '27'
    defaultConfig {
        applicationId "com.smthing.nothing"
        minSdkVersion 16
        targetSdkVersion 27
        versionCode 1
        versionName "1.0"
        testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
        vectorDrawables.useSupportLibrary = true
        dataBinding {
            enabled = true
        }
    }
    buildTypes {
        release {
            minifyEnabled false
            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
        }
    }
}

dependencies {
    compile fileTree(dir: 'libs', include: ['*.jar'])
    androidTestCompile('com.android.support.test.espresso:espresso-core:2.2.2', {
        exclude group: 'com.android.support', module: 'support-annotations'
    })
    compile 'com.android.support:appcompat-v7:27.0.0'
    compile 'com.android.support.constraint:constraint-layout:1.0.2'
    compile 'com.android.support:design:27.0.0'
    compile 'com.github.yalantis:ucrop:2.2.1'
    compile 'com.wonderkiln:camerakit:0.12.0'
}

--i'am a newbie in android app development can u guys help me to solve this

There is a temporary issue with Bintray current preventing the builds from being accessible, you can use compile 'com.wonderkiln:camerakit:0.13.0-Snapshot' in the meantime. @aravindhkumar23

@austinkettner compile 'com.flurgle:camerakit:0.13.0-Snapshot' zoom works but the listener part shows error on building and running the project,

cannot find symbol class CameraListener
cannot resolve method setCameraListener()

Pinch to zoom and capture image have been resolved in 1.0.0. Closing this issue.


how to understanding the model_size?

I download the ssd_300_vgg.ckpt,  it's about 100M.
But when I initialize the ssdnet randomly I get a 300M model_cpkt.
And when I restore from the ssd_300_vgg.ckpt, and finetune the network, I also get a 300M model.
How to understanding this? can you help me.

Hi, where did you get the ssd_300_vgg.ckpt model file, which is 100M.
Could it be this version of the model is used only for inference and have all training related stuff in the graph remvoed, and thus have a smaller footprint?

I got ckpt from https://github.com/balancap/SSD-Tensorflow. I did not know whether it is used only for inference or not. Besides I want know will slim model be useless in the feature? Cause the official said they only support keras.
Finally，may I ask if I can follow your wechat，I guess you are Chinese...（my number is   921156593）

Hi I had some experience with Keras, yes, it's very easy to use, and is indeed very good.
I am aware that Keras is now part of stardard tensorlfow distribution, but I think the same applies to slim.
In my experience, Slim allows us more flexibility in terms of customizing/reusing exising pretrained models,  it has has a fantastic growing computer vision related model zoo, which comes handy if we are to work in this area.
Will add your wechat now :)

yes！ Please。


Add README.md for KeyVault.Certificates/samples directory

@pakrym I opened this based on something you said, but not sure if it's to track converting services' samples to markdown, or have a README as a sort of index in the directory. If the former, this is done and I can close this; otherwise, if the latter, IMO that seems superfluous since there's only a few sample files and they have descriptions at the top already.

I think we can close this in favor of question 1 in https://github.com/Azure/azure-sdk/issues/769


feature: Feature Set Management improve error message on saving feature set

Feature Request
Describe the Feature Request

t is not possible to save the created feature set without adding variables, this a a requeried value, if user try to save it with not variables the error message is not clear to them. Improve error message by specify the clear error

App shows error from backend


Stratify circRNA calls

Per sample <sampleName>.circRNA_counts.txt is created with the columns:

#
ColumnName

1
circRNA_id

2
strand

3
<sampleName>_ntools

4
<sampleName>_circExplorer_read_count

5
<sampleName>_ciri_read_count

6
<sampleName>_dcc_read_count

7
<sampleName>_mapsplice_read_count

8
<sampleName>_nclscan_read_count

9
circExplorer_annotation

10
ciri_annotation

11
dcc_annotation

12
mapsplice_annotation

13
nclscan_annotation

circExplorer_annotation is either known or novel
ciri_annotation is JunctionType##Start-End Region from CircCoordinates file
mapsplice_annotation is fusion_type##entropy.. fusion_type is either normal or overlapping, while higher entropy values are better!
nclscan_annotation is 2 for intragenic and 1 for intergenic

We can then use these annotations along with <sampleName>_ntools to stratify the circRNA calls.

The above per-sample output is available in v0.7.0 and later.


[issue]Pb convert to tflite :how to calculate output min max of concatenation layer

I notice that tensorflow source code in quantized_concat_op.cc use the function of CalculateInputAndOutputRange() to caculate the minmax value of input and output feature maps, which just let the output min value be the minimum of the  input_mins[i], and max value be the maximum of the  input_maxes[i].
But when i convert pb file to tflite, the minmax value of output feature map of  concat layer not be the value  what it should be.
this is my convet command:
toco
--graph_def_file=rpn_190516.pb
--output_file=rpn_190516_tt.tflite
--input_shapes=1,2048,2048,3
--input_arrays='input_rpn'
--output_arrays='concat'
--inference_type=QUANTIZED_UINT8
--mean_values=128
--std_dev_values=128
--change_concat_input_ranges=false
--allow_custom_ops
and the reslut screenshot:

i would appreciate it , if someone can explain the result.

Has the problem been solved? I also encountered the same problem.

@MasterGG you specified --change_concat_input_ranges=false

@freedomtan  thank you for reply! Do you mean that if i want to use toco to convet pb files , i should always set the flag  --change_concat_input_ranges=true?
Also i have found in tensorflow/lite/toco/graph_transformations/quantize.cc ,which has code as below :

Does it means that if  the flag is true ,concatenation's output minmax just equal to the minmax of the first input arrays?

yes, but as far as I can remember the the parameters of input was changed before the code snippet you showed.

@freedomtan  Hi, i have tried some trials, if i set --change_concat_input_ranges=true, i got some tflite whoese minmax of all inputs  and outputs of  concat layers change to the same value; but some other tflite  just make the minmax of outputs be the same as the first input array,and didn't change the minmax of other inputs arrays.
So i am confused about the rules how to set the toco convert flags to get valid minmax values of concatenation layers. Can you give me some guidance about the Complete  rules?

@MasterGG Could you please let us know if this issue still persists ? If it is resolved then please feel free to move this issue to close status ? refer link . Thanks!


[FLINK-8071][build] Bump shade-plugin asm version to 5.1

What is the purpose of the change
This PR bumps the ASM dependency of the maven-shade-plugin to 5.1 as a workaround to a bug in ASM. This bug causes some error during the shading of akka, making it unusable.
Verifying this change
I can't guarantee 100% that this fixes the issue, since the shading issue only manifests sometimes. This means a simple recompilation of flink-runtime can resolve the issue temporarily.
I've compiled flink-runtime, flink-dist and ran the flink-yarn-tests in a loop and switched the version bump on and off. It only failed with the old ASM version,
To verify that the maven-shade-plugin uses ASM 5.1, run mvn -X package in an arbitrary module and check the dependency tree.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

I don't think we have a choice other than trusting your analysis and loop-testing. Looks good to merge! 👍

Some more info that i just stumbled on:
This doesn't actually happen on master, or on release-1.4 for that matter.
For FLINK-7419 we're adding another relocation pass to flink-dist for jackson, and this appears to trigger the error.
master: succeeds

relocation in flink-dist: fails, always
asm dependency bump: succeeds

Will rebase the PR and merge it once travis is green.


Lazy PInvoke resolution on Unix

This tracks finishing up what was started in pull request #1240.
Known work items:

Remove // TODO: Test and make this work on non-Windows in PInvokeMarshallingILEmitter.cs to enable the feature on Unix
Steal .so probing logic from CoreCLR (the thing that attempts prefixing library name with lib, etc.). This needs to be implemented either in CoreLibNative_LoadLibrary(), or on the managed side.
Bug fixing. This code never successfully ran on Unix.

(I'm leaving the Unix portion of the pull request in a separate commit for easy future reference.)

This was fixed in #2470.


tinc: 20160511 -> 20160924

Motivation for this change
Fix broken build for haskellPackages.tinc.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x ] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Personally, I'd prefer Nixpkgs to ship a copy of tinc that resembles what people get when they download the pristine copy from upstream. If what we're distributing here is essentially a fork, then it should be clearly labeled so. IMHO, the proper way to get Nix-specific features in is to submit pull requests upstream.

I think it's great that you're making the nix integration better. If you want to make a long-standing fork I suggest you rename the package to tinc-nix. Or try to work with upstream and see if you can land your own changes. Just changing the source is probably misleading to the users and will cause confusion.

Thanks for the feedback. I have created a branch at the upstream for this. Hopefully, this is less confusing.


ManyToMany form field is not scrollable

The manytomany form in the admin panel is not scrollable particularly in the case of permission field in the Group model of django auth app.

Fixed #421


missing glMatrixMode and glTexCoord2f

Every OpenGL tutorial I come across on the internet references these functions, yet they aren't in this library.
This library has a function TexCoordP1ui which does not seem to be part of the OpenGL spec and also has no documentation.
What am I not understanding?

This post is quite old and I found it by accident, but this answer may perhaps help others who somehow get here.
 This API design is ancient and I think it stems from how GPUs were programmed in the 90s. Modern graphics drivers do the bare minimum to support it, as modern GPUs can't be cleanly mapped to that programming model (and by modern I mean like 2008 and newer).
This may be a bit disappointing to hear, but you should learn how to use slightly newer versions of the API, like OpenGL 3. It's pretty old by now too, but all of OpenGL is almost deprecated nowadays, you know lol. The website learnopengl.com has a pretty decent tutorial on it. You should avoid using tutorials for OpenGL 2.0, as that's not really how GPUs work nowadays. You won't be using functions like glMatrixMode in modern OpenGL, as managing data passed to the GPU becomes your responsibility (and you'll be able to use as many matrices as you'd like!), which also means the code will be slightly more complicated. If you just want a simple API to draw stuff on the screen, I recommend looking into dedicated 2D/3D libraries for that, or even outright game engines. They're much more optimized for modern hardware, and have a lot more useful functionality.
As for why the bindings don't have these functions. The main gl crate exposes bindings for Core profile of OpenGL 4.6, which is the newest version as of writing (and probably for the rest of time). The Core profile removes all deprecated OpenGL functions, including fixed-function pipeline ones.
If you're still hell-bent on using obsolete OpenGL functionality, I've had success manually using the gl-generator crate to create bindings for OpenGL 2.0. OpenGL 3.0 with the Compatibility profile also works, just not 3.3 because I think by that point the deprecated APIs were fully gone from both Core and Compatibility profiles. But beware, GPU drivers may be even more glitchy there than they are on modern OpenGL.
As for the glTexCoordP1ui function, it seems to be a part of the ARB_vertex_type_2_10_10_10_rev extension. I didn't read much into it, though.


Create a way to make submission of HTP flat files easier

These
https://www.pombase.org/submit-data/bulk-annotation

https://www.youtube.com/watch?v=nyNp09WYLzw&ab_channel=ISCB ?

would this be a possible LinkML project

I don't think so.  As I understand it, LinkML is a way of describing data.  We need a way to upload data files and to then store/manage the files.

I think you can use a LinkML data structure/ associated Tools to create input forms to match the data model. This might not be helpful though.


power shell appears as default terminal instead of users preferences

Does this issue occur when all extensions are disabled?: couldn`t check

VS Code Version: 1.6.0
OS Version: Windows 10

Steps to Reproduce:

Install previous version  VS Code
set git bash console as default terminal
update vscode to 1.6.0

Actual result: power shell appears as default terminal
Expected result: git bash appears as default terminal according to users preferences

/duplicate of #132150 and will be fixed in upcoming 1.60.1 recovery release


Dilbert is being cancelled, Dunce is taking over

Scott Adams' controversy aside, you may agree or disagree with his views, but no matter what - Teknisk Ukeblad are jumping on the cancellation hype-train, and Dilbert is gone, starting March 13th 2023[1].
We will have to update Comicbot to support the new comic Dunce, and it will be a simple matter of fetching the URL in this format: https://www.tu.no/api/widgets/comics?name=dunce&date=2023-03-13

[1] I guess they had already queued up a few Dilbert cartoons, 'cause Comicbot found Dilbert today, even if it's not listed on the website.. 😆

Lunch has a new URL format as well: https://www.tu.no/api/widgets/comics?name=lunch&date=2023-03-14

Curiously, there are still Dilbert comics being published:


Response-Transformer deal JSON error!

Hi,everyone
when i use response transformer to deal the response of my api, I can add or remove some header, but when i remove or add a JSON key ,maybe don't validate. the kong version is 0.14.1
SUMMARY_GOES_HERE
Steps To Reproduce

1

.
2.
3.
4.
Additional Details & Logs

Kong version ($ kong version)
Kong debug-level startup logs ($ kong start --vv)
Kong error logs (<KONG_PREFIX>/logs/error.log)
Kong configuration (the output of a GET request to Kong's Admin port - see
https://getkong.org/docs/latest/admin-api/#endpoint)
Operating system

JJMEI - can you please provide the information in the template? Can you try configuring the plugin using the Admin API to confirm it is a kong problem and not a problem in the admin UI you are using?
Regards,
Rob

JJMEI - can you please provide the information in the template? Can you try configuring the plugin using the Admin API to confirm it is a kong problem and not a problem in the admin UI you are using?
Regards,
Rob

thanks your replay , i will try it  ^_^

JJMEI - can you please provide the information in the template? Can you try configuring the plugin using the Admin API to confirm it is a kong problem and not a problem in the admin UI you are using?
Regards,
Rob

here i use the admin api to add this plugin, but is not useful

Closing issue due to inactivity.


nice bug

Dear mryab.
Please add this nice bug to hw1, it's almost impossible to find. students would definitely enjoy it.

Hi @IvanSedykh, thank you for the contribution! Unfortunately, I will close the PR, as merging it as is will simplify the detection of this bug due to the blame view. Still, if we consider adding a form of this bug to the future versions of the exercise, we will definitely acknowledge your idea!


Update the sort options for "Books" to match the attached issue

To match issue 231
Here is the updated design (there are two variations for sort)

@jkotin I had to revise this to make sure it matches what has been discussed in issue #231 – Additionally, @rlskoeser and @thatbudakguy let me know that there can't be any line breaks in the open sort options (i.e. each option will be in one line, no matter how long it is) – Therefore, I have changed the styling so that the "lowest-highest" type of info will be in grey for better readability
Please review this and let me know what you think

@jkotin never mind! @rlskoeser just informed me that the colors can't change either – so just comment on the language please and I'll fix the styling

@jkotin @rlskoeser @thatbudakguy Here is the 3rd version – after trying another route that RSK suggested I ended up coming back to this version – currently, this seems the most usable way – just eliminated it back to one color (black) and instead added parentheses to help with readability – if there are strong objections with the parentheses I'm ok with dropping them, I think they slightly help visually – Let me know what you think and if this matches what is being implemented.
I appreciate feedback on the language with "Circulation" – I think it is more immediately comprehensible in comparison with "activity" or "events" and is consistent with the "circulation" tab in books  – also just wanted to double check on "frequency" and if it still makes sense.

@gissoo Thank you.  Just to confirm: we need the double options (A – Z and Z – A) because users won't be able to toggle/reorder the results by column?
Do we need the word "frequency"?  Couldn't we have "Circulation (Highest – Lowest)?"  What does "relevance" evaluate, and should it be first and the default?
FWIW, abebooks.com uses "ascending" and "descending" for publication date -- I'm not sure if that's better.

@jkotin thanks for writing!

This is for the book search page – so I think we need the double options (A – Z and Z – A) I'm not sure I understand when you say "users won't be able to toggle/reorder the results by column?" – are you thinking of the "circulation" tab?

It makes sense to me without "frequency" – which is why I'm raising the question – can't remember our discussions before that led to "frequency" making more sense – unless @rlskoeser thinks there are logical reasons for it

"Relevance" is always the default when the user has input keywords or has used the filters – but when they are just browsing (i.e. not entering terms into the search box or filtering relevance won't be available/active) – I don't even think it should show up in this drop down now that I think about it or if it does it should be visually inactive/not selectable.

thanks for the reference with the screenshot! I did not prefer this before. I understand that it works for terms such as "ascending" and "Descending" – I'm a little hesitant but it logically makes sense as I keep thinking about it! @rlskoeser does this make sense to you?

@jkotin this sort dropdown is the one that appears on the main books search, not on the circulation activity table.
I'm not convinced we need the reverse sorting options (Z-A, reverse chronological, etc) here. I think sorting (like the search itself) is primarily designed to help you find a single item quickly; people who might be doing work like "find the oldest item in the library" are probably in the minority and could also answer that question in a more detailed way with a data download. I'm also not sure what value there is in reverse sorting all of the results when the user could simply jump to the last page and keep clicking the "previous" button to achieve the same effect.
On that note, labeling the sorts if we don't offer reverse options becomes a lot simpler. "Date" virtually always implies chronological order, "Title" implies alphabetic order, etc...there's no need to qualify them with "A - Z" or similar.
on "circulation frequency" - does this capture the whole story? aren't we including non-borrowing events, which would not fit the definition of "circulation" (e.g. purchases)?

@thatbudakguy Thanks for writing. I like to know what RSK and Josh think about your comment – From what I understand though – according to what you have written, we won't want "Date" to imply earliest-latest (because as you said "...are probably in the minority and could also answer that question in a more detailed way with a data download..") – So even if we choose only one direction, I think it needs labeling "Publication Date Newest – Oldest" rather than only "Publication Date" – especially since there are multiple options, it can be easily confusing without it.

Thanks for pointing out about "Circulation" – if we do not use "circulation" for the reason you are mentioning above – then I think we will also have to change it to something else in the "circulation tab" – but as I keep thinking about it more I think it still makes more sense than any other language we have used in its cohesiveness (also because a book/item might have been borrowed before it was purchased at some point)?

I like the comments from @thatbudakguy about simplifying the menu by deleting the reverse sorting options. Re: "Circulation" -- I think it's OK, but Nick is technically correct. Other options would be "Frequency" or "Most Borrows/Purchases" or going back to "Activity." All these seem acceptable to me. The colors/design is great.

Hi, all, trying to catch up on all the conversation here.
Comments/responses:

I don't think "circulation frequency" makes sense; just "circulation" is better
I think "circulation" is probably expansive enough to include other kinds of book movements besides borrowing activity (also, the vast majority of events are borrows). Also, we're already using it on the book detail pages, so it's consistent within the site.
I agree with Nick and Josh that we don't need all of the reverse options; it will be much simpler and more readable if we don't have so many options
I agree with Gissoo that it's not obvious which date order would be default (it depends on the content and the use cases)
relevance sort option will be disabled when it's not applicable, we just haven't implemented that yet for books

Questions:

@jkotin if we only include one publication date sort option, do you want oldest to newest or newest to oldest?
@jkotin are you fine with dropping all reverse sorts, or are any of them interesting enough to highlight? (lowest circulation?)
@gissoo using "circulation" here doesn't impact the use of "borrowing" on the individual member detail page, does it? I think we discussed that and you decided borrowing was more intelligible than something more accurate but ambiguous like "book activity", but wanted to check.
@gissoo does it matter we don't include any kind of circulation count anywhere? book search result or bibliography page?

Great, I think we are all getting on the same page.  Re: questions from @rlskoeser --

It's tricky because a SIGNIFICANT number of items won't have dates because they are "unidentified" or written before the printed book.  How would we order those books?  I could enter dates for the pre-Gutenberg books, but that would only solve part of the problem. Do these facts help illuminate an answer?  I'm not sure.

Yes, I think we can drop all reverse sorts.  There are 1000s of books with a circulation of 1.

@jkotin I'm configuring the sort so that missing values sort last, and I'm adding a secondary sort on title. Does that help with the number of books with no publication date?

@jkotin @rlskoeser Thanks for writing:

re "Circulation" – I agree with Nick's point if we are only sticking to logic, however most often when designing to create intuitive and usable projects logic needs to be incorporated with context and language is important and is most often influenced. "Circulation" sounds a lot more intuitive and relatively logical here from everything I have seen and understood (as far as the hierarchy and frequency between "borrow" and "purchase", "gift", and etc. In general, if it proves otherwise after usage I'm more than happy to learn and revisit.

re "Circulation" vs. "Circulation Frequency", I totally agree with "Circulation" as the latter has stopped making sense to me.

re reverse sorting: @jkotin @rlskoeser @thatbudakguy I totally agree that eliminating the reverse sorts makes this specific feature simple and easier to use, and we didn't do any usability testing for this feature to find out with reason rather than making assumptions, and I'm generally leaning towards a more simple setting, where features could be added later on if it's learned that users will indeed need it – however, I would like to remind you that the reverse sorts maybe more powerful now specifically because we don't have the "publication date" and "creators tab" as mvp – had to point it out

re @rlskoeser 's Q1 – @rlskoeser do you mean the name of the "Borrowing" tab on the activities section of a member? (I don't see any "borrowing" on the member's biography page – just making sure – if that is what you mean I think "borrowing" is ok, I'm certain that "circulation" won't make sense here, however I'm thinking whether "Transactions" or "transactional" is better – I have mixed feelings about the word because there are some overlaps between "transaction" and "membership".

re @rlskoeser 's Q2 – I'm tempted to say it's better to include the count on the search results and the bibliography page – but it also depends on the data – from what @jkotin is saying there are 1000s of book with a circulation of 1, I doubt about how meaningful it will be enough.

@jkotin I was wrong, I have empty sorting last for author and title but not pub date. That makes me inclined to sort newest first when sorting by publication date, but I don't know if I'm suggesting that for the wrong reasons.

@gissoo yes, I meant the borrowing activities section. I think it's ok, and it seems better than circulation or transactions, but wanted to check with you if we were being inconsistent.
Good point about the counts of one - that does suggest it might not be as useful, I'm interested to hear what @jkotin thinks.
It struck me when I was reviewing the designs yesterday in relation to these conversations: the member detail page design is specifically about the person in the context of the library, while the book bibliography page is more straight-up bibliographic data without any summary or context of the book in the library. It seems like adding event counts and circulation years might help with that. (🤔 I wonder if we could do a book timeline like we do for members, and if we did how useful or interesting it would be?)

@rlskoeser I think the reason for what you are noticing with the designs is derived from our our ways of thinking about them at the time (which I remember had a lot to do with data work that made me feel more limited in designing) which led to what we agreed on – I do think it's useful to have the circulation years there (but it was not in scope or spoken of since we had other priorities) – thanks for revisiting, I remember that I had also suggested about the book timeline very early on, I do think it would be nice to have the timeline and the circulation years on the bibliography page.

I'm OK with "circulation" as a general description of book events, but would also be fine with just "activity" or Josh's suggestion of "transaction" too - whatever we think is the clearest.
@rlskoeser I like where you're going with adding more context to the work detail page; the addition of a book timeline seems like a natural parallel.

I don't follow the question about referenced in "Good point about the counts of one - that does suggest it might not be as useful, I'm interested to hear what @jkotin thinks."

@jkotin sorry for lack of context, this is in relation to my suggestion of including a circulation event count on the book search result card and the book detail bibliography page and your comment that there are thousands of books with 1 event. Would event counts be interesting?

Thank you!  Yes @rlskoeser , I think event counts would be interesting.  Even the 1s are interesting: you think, wow, only 1, and then realize that the only reason we are thinking about the book is that it was borrowed once, and thus kept alive.
Also it's fascinating to compare counts of books by the same author.

@jkotin @rlskoeser @thatbudakguy Before this conversation becomes harder to track, I appreciate your response on these (to reach an agreement) – From what I understand in the comments:

We'll keep "Circulation" language for the sort option
re eliminating reverse sort options: this is my earlier comment in case it got lost: "@jkotin @rlskoeser @thatbudakguy I totally agree that eliminating the reverse sorts makes this specific feature simple and easier to use, and we didn't do any usability testing for this feature to find out with reason rather than making assumptions, and I'm generally leaning towards a more simple setting, where features could be added later on if it's learned that users will indeed need it – however, I would like to remind you that the reverse sorts maybe more powerful now specifically because we don't have the "publication date" and "creators tab" as mvp – had to point it out" – can we confirm we are still eliminating sort options? If yes,
are we eliminating:

Author Z-A?
Title Z-A?
Publication Date (newest - oldest)?  (also maybe better to say "earliest-latest" - sparked by RSK's comment)
Circulation (fewest-greatest)?

referring to comments on #562: Are we adding the "Circulation Date (earliest-latest)" sort now – or is the sort option wishlisted? – Need to be considered as I update the designs
referring to comments on #562: Are we wishlisting the addition of "Circulation Dates" on the search results and bibliography pages? – They will need design work
referring to comments on #562: Are we wishlisting the addition of the book timeline for the bibliography page? – It will need design work
are we adding circulation counts on the search page and the bibliography pages now? or are we wishlisting? – They will need design work

This all looks right to me. I'll defer to @rlskoeser on the publication date sort-order question.  I prefer "descending/ascending" to "fewest - greatest, and "newest - oldest" or "newest first" to "earliest-latest."
Re: wishlist, I'd prioritize circulation date, and then the book timeline.  But I'm eager to hear what others thing.

@gissoo thank you for summarizing!
You're correct on the list of sort options we're eliminating, with the one caveat that we need to decide which publication date order we want to include.
Publication date order: I'm inclined to newest first because I think it will work better with the data we have. @gissoo any concerns?
I feel like "ascending/descending" takes slightly more mental effort to process, but I don't feel strongly about not using it; @gissoo what do you think?
I'm ok with adding circulation date to the sort options now - you're already revisiting the designs and it doesn't increase the complexity of the sort logic much. @gissoo is this ok for you? How can the label make it clear that this is the first circulation date?
You are right, everything else should go on the wishlist. Thanks for confirming they will require design work, I thought they probably would. Should we create wishlist issues to keep track of these ideas? Who can do that?

@rlskoeser @jkotin Here are the revised designs, v4 – Please read below and let me know what you think.

@rlskoeser I think as I mentioned regarding "publication date" and "author" I'm a bit concerned and unsure of which is more useful mainly because the filters that would have been helpful to have are not mvp anymore – I find them both equally important (the a-z and z-a, and the oldest-newest and newest-oldest) – but I trust your instincts and knowledge about the data we have, so I think it's fine and, in general think it probably won't be disastrous.
@jkotin @rlskoeser  "ascending/descending" is not intuitive from my perspective when we talk about the concept of time, I strongly recommend that we don't use it. I like "Newest – Oldest" the best then.
@rlskoeser I've already added the circulation date to the sort options! by "this is the first circulation date" do you mean how to make it clear that the first item that will show up as a result of this sorting was the first item ever circulated in the S&Co library? – If this is what you mean then I think "oldest" still makes sense here! From my perspective, I don't have a concern with this. – Do you have specific concerns I'm missing?
@rlskoeser, great! I will create issues to address the new wishlisted design work in the best way possible.

@gissoo these updates look good!
One more small wording comment:

"greatest / fewest" doesn't make sense with Circulation to me (I don't think you would say something had the "greatest circulation" - would you?). What about most/least or highest/lowest?

Regarding the circulation date: I agree that oldest makes sense in terms of labeling the direction of the sort. What I'm concerned about is potential confusion when an item circulated for multiple years. We can only sort on a single value, which will be the first time an item circulated. To be most accurate, the label should be "First Circulation Date (Oldest - Newest)" - but that's pretty long! I just want to be sure you think it's not going to be confusing without this.

@gissoo Thank you for creating the issues to track the wishlist ideas that came out of this conversation!

@rlskoeser I get your point about the "greatest/fewest" – the reason I picked that was because it's a "count" and lowest or highest to me are more relevant for "frequency" than the actual number of times something happened. (I read it as "greatest/fewest number of circulation") – but if I'm the only one this is bothering then I'm happy to go back to "most/least"

I also understand your point about the "first circulation date" – that 's what I also suspected you are concerned with – my answer is I don't think it's necessary to be communicated in the sort option – I think it's something that will need to be tackled when we list it in the search result of the item and on its bib page. Is this ok with you? (Because to me, it's on a different level, it's not what the sort is mainly addressing)

Interesting! Technically we're sorting on a count, but "circulation" doesn't read exactly like a count to me... IDK what that means, though.
Yes, I'm fine with not labeling it as first circulation date if you think it's ok! That's all I wanted to confirm. I agree that adding more details to the search results and bibliography pages will help with this.

I'm getting caught up on the discussion. I don't think I have much to add, looking at the latest designs @gissoo sent out.  (Thank you everyone for thinking through these issues so brilliantly.)
I wonder if "circulation date" should come before "circulation" on the menu?  Publication date and circulation date seem to go together in my mind.
Re: terminology.  I am going to ask my mother (a librarian) re adjectives for circulation.  "Highest" and "lowest" seem good to me.

I wrote to my mother and she said that "Circulation (highest – lowest)" is fine.  She also suggested "Most Borrowed" or "Most Circulated."
Here is a portion of her note:
I would use the word “circulation” and I think it’s well understood because it’s used in the world of magazine and newspaper subscriptions too.  However I also know that some libraries try to use non library jargon and so here are the other terms just in case you want alternatives!
“Check-outs” (this is used quite often even at Academic libraries)
“Loans” or “Loaned”
“Borrowed” (mostly used in England)
Libraries sometimes rationalize no longer having certain books in their collections because the item was never “checked out.”

@jkotin Thank you for writing!! This is so valuable and interesting, thank you for asking your mother!!
I think it will be the least confusing and the most clear to use "Circulation (Highest – Lowest)" here, within this project. (I personally prefer "check-outs" but I have a lot of worries with using it here and our edge cases, so wouldn't recommend it)

I can rearrange the "circulation date" and "circulation" – to flip the order, it might be easier to read if flipped. (I thought about it and wanted users to see the more basic sort option first, i.e. the counts before seeing the date, because to me the circulation count is less of a detail than the circulation date, but I really don't know how much it matters)

@jkotin @rlskoeser Here is the revised design
@jkotin please let me know what you think and if there are any issues so I can revise, otherwise please close it.


posts.all.title throws php errors and ajax errors

I have another one for you, when setting 'posts.all.title' => 'title' I get the following php error,
Notice: Undefined index: post_type in /var/www/html/wp-content/plugins/intervention-master/src/Admin/Posts/All.php on line 113
and when running Query Monitor I get the following php ajax error in the browser console on the All Posts page that continues to repeat every 10 seconds or so,
Object { key: "6cca9fbdd5457d43a614d4f7f4251b6f", type: "notice", message: "Undefined index: post_type", file: "wp-content/plugins/intervention-master/src/Admin/Posts/All.php", line: 113, stack: (5) […], component: "Plugin: intervention-master" }

It also does not set the menu title, even when using 'posts.all.title.menu', and it sets the page title of all post types to the new posts title (Pages and CPT's). I've attached a couple screenshots for reference.

This does not occur when setting 'pages.all.title', however it does not change the Pages menu title, even when specifying it with 'pages.all.title.menu'.

@grahammtbr
Thanks for picking this up. I had some issues when initially developing this feature actually, particularly across post types.
I have separated the x.title.menu and x.title.page which allows me to check for those keys individually rather.
Do you mind testing? 59eb5ccf263ad64f1c6fedeafaf2d5e41de3f059

@grahammtbr
Thanks for picking this up. I had some issues when initially developing this feature actually, particularly across post types.
I have separated the x.title.menu and x.title.page which allows me to check for those keys individually rather.
Do you mind testing? 59eb5ccf263ad64f1c6fedeafaf2d5e41de3f059

Hi @darrenjacoby, sorry for the late reply. I tested and the errors are gone :)


pageserver: start refactoring into TenantManager

Problem
See: https://github.com/neondatabase/neon/issues/5796
Summary of changes
Completing the refactor is quite verbose and can be done in stages: each interface that is currently called directly from a top-level mgr.rs function can be moved into TenantManager once the relevant subsystems have access to it.
Landing the initial change to create of TenantManager is useful because it enables new code to use it without having to be altered later, and sets us up to incrementally fix the existing code to use an explicit Arc instead of relying on the static TENANTS.

The test_timeline_resurrection_on_attach test failures are https://github.com/neondatabase/neon/pull/5803


[RELEASE] 2022.11.1

Release Checklist
Release details
Scheduled release date - 2022-11-30
Release captain responsible - @iameskild
Starting point - a new release is out

[x] Create this issue to track and discuss the upcoming release.
[x] Use the previous release issue for any final release-specific discussions, then close.

This can be a good time to debrief and discuss improvements to the release process.

Looking forward - planning

[x] Create milestone for next release (if it doesn't already exist) and link it back here.
[x] Triage bugs to determine what be should included in the release and add it to the milestone.
[x] What new features, if any, will be included in the release and add it to the milestone.

This will be, in large part, determined by the roadmap.
Is there a focus for this release (i.e. UX/UI, stabilitation, etc.)?

Pre-release process

[x] Decide on a date for the release.

What outstanding issues need to be addressed?
Has documentation been updated appropriately?
Are there any breaking changes that should be highlighted?
Are there any upstream releases we are waiting on?
Do we need to update the dask versions in the nebari-dask?
Will there be an accompanying blog post?

[x] Prepare for the release.

[x] Announce build freeze.
[x] Release Candidate (RC) cycle.

Is this a hotfix?

[x] Create a new branch off of the last version tag.

Use this branch to cut the pre-release and the "official" release.

[x] git cherry-pick the commits that should be included.

[x] Perform end-to-end testing. Use the Testing Checklist template.

For minor releases, relying on the end-to-end integration tests might suffice.

[x] Cut RC via GHA release workflow (w/ "This is a pre-release" checked).
[x] End-user validation.

If possible, pull in volunteers to help test.
(Repeat steps if necessary)

[x] Update RELEASE.md notes.

Cut the official release
These steps must be actioned in the order they appear in this checklist.

[x] Tag, build and push docker images
[x] Update and cut release for nebari-dask meta package on Conda-Forge.
[x] Cut PyPI release via GHA release workflow.

Avoid appending v to tag.

Copy release notes from RELEASE.md.

[ ] Merge release branch into main
[ ] Merge automated release PR for nebari on Conda-Forge.

I had to spoof the test PyPI release because it was failing to download the release test release (even though it exists). Either way, the actual PyPI release is live 🙌


Implement uncovered circle path functionality

Signed-off-by: Jaron Lee<EMAIL_ADDRESS>

Fixes #41 by implementing an uncovered circle path function.
Changes proposed in this pull request:

Refactored uncovered_pd_paths into a protected function _uncovered_paths that exposes the original function and uncovered_circle_paths.
Added boolean argument into _uncovered_paths that changes the behavior (enforces o-o vs. o-> edges)

Before submitting

[X] I've read and followed all steps in the Making a pull request
section of the CONTRIBUTING docs.
[X] I've updated or added any relevant docstrings following the syntax described in the
Writing docstrings section of the CONTRIBUTING docs.
[X] If this PR fixes a bug, I've added a test that will fail without my fix.
[ ] If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

[ ] All GitHub Actions jobs for my pull request have passed.

To add your name to the contributor list, just follow the pattern that others have and then add a line in _contributors.rst inside doc/whats_new/.
We should also log your contribution re the m-separation speedup for the MixedEdgeGraph. FYI I ported the class over from networkx PR because I think getting that into networkx will take quite a bit of time. In the meantime, we will maintain it in-house until all the kinks are resolved.

I'll review the code and logic later this weekend

To add your name to the contributor list, just follow the pattern that others have and then add a line in _contributors.rst inside doc/whats_new/.

I will do this.

We should also log your contribution re the m-separation speedup for the MixedEdgeGraph. FYI I ported the class over from networkx PR because I think getting that into networkx will take quite a bit of time. In the meantime, we will maintain it in-house until all the kinks are resolved.

Should I create a separate PR for that?

Some minor nitpicks.
Is it possible to elaborate in the Notes section of the pd_path and circle_path what is the difference relative to each other? It seems like uncovered_circle_path is a subset of the uncovered_pd_path?

Let me investigate further.  I understood that to be true in the literature but the documentation of the existing uncovered_pd_path function didn't seem to reflect this.
In particular:
    bidirected arrows, bidirected circle arrows, or opposite arrows.
    In addition, every node beside the endpoints are unshielded,
    meaning V(i-1) and V(i+1) are not adjacent.

seems like it is excluding circle path due to no bidirected circle arrows.
Would a better refactor strategy be:

return to having only an uncovered_pd_path function
check that this function also accounts for circle paths (and amend documentation accordingly)
add an option e.g. circle_path_only so that uncovered_pd_path searches for only circle paths
?

Let me investigate further. I understood that to be true in the literature but the documentation of the existing uncovered_pd_path function didn't seem to reflect this.
In particular:
    bidirected arrows, bidirected circle arrows, or opposite arrows.
    In addition, every node beside the endpoints are unshielded,
    meaning V(i-1) and V(i+1) are not adjacent.

seems like it is excluding circle path due to no bidirected circle arrows.

Ah good catch. Checking the Zhang paper, I think this is a mistake: https://reader.elsevier.com/reader/sd/pii/S0004370208001008?token=B11038210A2EF8C67786AE0A3CBA24516AE2B23FF7A7F8D3E69BFC1D46F1A2D0740C966C9B241369C1B38DDEF6705E1E&originRegion=us-east-1&originCreation=20230203144418

Would a better refactor strategy be:

return to having only an uncovered_pd_path function

I'm okay with the current implementation you have, but the main thing would be to update the unit test in uncovered_pd_path to also allow bidirected circle paths.

check that this function also accounts for circle paths (and amend documentation accordingly)

+10 (good catch on this bug!)

add an option e.g. circle_path_only so that uncovered_pd_path searches for only circle paths

Sure. This is also fine w/ me. Whichever one is easier.

OK, I'll fix it up and push in a bit.

Codecov Report

Merging #42 (2ba17c0) into main (21b4f90) will decrease coverage by 0.04%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   68.45%   68.41%   -0.04%
==========================================
  Files          27       27
  Lines        2000     2007       +7
  Branches      482      486       +4
==========================================
+ Hits         1369     1373       +4
- Misses        526      528       +2
- Partials      105      106       +1

Impacted Files
Coverage Δ

pywhy_graphs/algorithms/pag.py
73.66% <62.50%> (-0.49%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

OK, I think I have integrated all the requested changes and all the checks are passing.

Thanks @jaron-lee !


Fix change team password showing 500

Fix this bug cause i introduced changes in a PR without testing everything.

I don't get why it works but it works.

Id is a named parameter that was incorrectly renamed during a lint commit.


Update the Cell and Component name resolution to use K8s Labels taken from API Servers 🔨

Purpose

Update the Cell and Component name resolution to use K8s labels taken from the API Servers to overcome the issue with long names causing the UUID to shrink.

Goals

Allow the user to observe component pods with long names.

Approach

A new Event Source is added to watch component pods to improve the accuracy of the Pod Information collected by the Stream Processor. The Siddhi Apps are changed to use the collected Pod info to resolve the Cell and Component name rather than using a regex to extract the information from the Pod name. This is done to avoid any potential issues with lng names causing the pod name to change.

User stories

As a user I need to provide long names to the component (ultimately to the pod names), and observe them without any issue.

Release note

N/A

Documentation

N/A

Training

N/A

Certification

N/A

Marketing

N/A

Automation tests

Unit tests

N/A

Integration tests

N/A

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
Ran FindSecurityBugs plugin and verified report? yes
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

Samples

N/A

Related PRs

N/A

Migrations (if applicable)

N/A

Test environment

N/A

Learning

N/A

Codecov Report

Merging #43 into master will increase coverage by 3.09%.
The diff coverage is 91.08%.

@@             Coverage Diff              @@
##             master      #43      +/-   ##
============================================
+ Coverage     20.23%   23.32%   +3.09%
- Complexity       40       73      +33
============================================
  Files            67       71       +4
  Lines          3391     3546     +155
  Branches        763      790      +27
============================================
+ Hits            686      827     +141
- Misses         2340     2342       +2
- Partials        365      377      +12

Impacted Files
Coverage Δ
Complexity Δ

...ty/k8s/client/GetComponentPodsStreamProcessor.java
92.06% <100%> (ø)
14 <0> (?)

...ava/io/cellery/observability/k8s/client/Utils.java
100% <100%> (ø)
5 <5> (?)

...lery/observability/k8s/client/K8sClientHolder.java
83.33% <66.66%> (ø)
3 <1> (?)

...rvability/k8s/client/ComponentPodsEventSource.java
89.47% <89.47%> (ø)
11 <11> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a10c850...29153b4. Read the comment docs.


fixing camera_position for culling

this fixes issue #1203 .

Verified this fixed Issue #1203.
This scene now renders (with animation) correctly.

good find!

Needs GearVRf-DCO-1.0-Signed-off-by

gvr-shadows crashes due to nullptr de-reference.

Is the fix complicated?

waiting for @NolaDonato

The fix will fail if the camera does not have an owner object. If you are rendering a shadow map or render target, this will be the case.

Should we close this?


Async validation

Validation shouldn't need to throw an error. It doesn't fit with the way the rest of the code works. It should be allowed to return a promise or act on a callback like everything else does.
I need async validation.
@dthree Any concerns?

I recently updated it (like 2 days ago) so you can just return true, or false, or a message.
https://github.com/dthree/vorpal/wiki/api-|-vorpal.command#commandvalidatefunction
I agree with async as an option, sorry, I just hadn't gotten to it. :+1: on implementing.

What's the status of this one? Still interested? I'd also like async validation.