fix #97 PEP420: find_packages()

make find_packages() find also PEP420 namespace packages when supported

I think there were objections to making the Namespace packages finder the default. I don't see those objections addressed here or in #97. This change, if I understand it correctly, will break the expectation of many packages, where they have 'tests' and 'docs' without a __init__.py that are currently not installed, but with this change will get installed. Surely such a change can't be accepted without serious consideration of the consequences and a good writeup of what users should expect to do about it.

I'm also -1 on changing the default, especially changing the default only on Python 3. People find it hard enough to reason about writing a 2/3 compatible setup.py without this.
I think having a way to use find_packages with namespace packages is important, but having find_packages do it automatically is not worth the mental overhead this adds.

One consideration, these implicit namespace packages only work for Python 3-only packages, right?
I guess it happens at different times, but it would probably be a good idea to check the python_requires when an implicit namespace package is detected and throw a warning if it is either empty or includes Python 2.

@jaraco in #97 a requirement was stated that in case that the PEP420 was supported, it should be default, so this PR is about meeting that requirement.
However, I would be totally fine with just exporting a find_packages_ns() method instead.
What do you think, @jaraco @pganssle

Yes, I was thinking about this in my waking hours this morning. Ultimately, Python 3.4 (and earlier) will get old and all namespace packages will look like PEP420 namespace packages. When that happens, we'd like for setuptools and libraries like setuptools to have an interface that's clean and free of legacy cruft.
To get there without breaking existing packages, I believe we need a mechanism for the find_packages behavior to remain unchanged (for now), but signal that in future versions, the behavior will change.
Here's an idea. What if:
phase 1
find_packages will invoke both finders and where the results differ, warn that in the future find_packages will return the larger set of packages and indicate that to retain existing behavior, use find_packages excluding the unwanted packages, but setuptools use the compatible set.
phase 2
About 6 months later, as a backward-incompatible release, find_packages uses PEP420Finder.find.
I could imagine a 3-phase release that retains the legacy behavior, but the more I think about it, the less important that seems to retain.

@jaraco I mostly don't like that the default behavior changes based on what interpreter you use to run setup.py with. I'm fine with the default behavior changing to something else, but it should happen for all interpreters, possibly issuing a warning when a project uses implicit namespaces on a too-old version of Python.
That said, the "legacy behavior" is probably the overwhelmingly common case here. I think most packages use a single folder with an __init__.py, and that's not going to change even once everyone is 3.4+. A large fraction of those have a tests/ folder or other various non-package folders without an __init__.py in it, sibling to the main package folder. If I'm understanding the failure mode correctly here, I think there's reasonably strong case for leaving namespace packages as opt-in, or at least making the legacy behavior as simple as a feature flag or variant function.

@pganssle the current solution supports both, the legacy and the future.

the current solution supports both, the legacy and the future, yet one might need to exclude additional paths.

What I meant was that if the PEP 420 find_packages ends up creating a lot of extra work for non-namespace packages who now have to write find_packages(exclude=['tests/', 'scripts/'] or something when they didn't have to before, then I don't think this is a real improvement.
The default should be the thing that works correctly in the common case, with an easy upgrade path for the uncommon case. If 1% of packages use implicit namespaces (I think this number is probably a dramatic over-estimate), and 20% have a tests/ and/or scripts/ file with .py files in them, that means we are making 20% of people write:
find_packages(exclude=['scripts/', 'test'])
Just so that 1% of people don't have to write:
find_packages(namespace=True)
We're also at a pretty significant risk of having a bunch of packages not realize that this has happened and accidentally installing scripts and tests packages into the root namespace!

>>> from setuptools import PEP420PackageFinder as pf
>>> from setuptools import find_packages

>>> print(find_packages())
['dateutil', 'dateutil.tz', 'dateutil.test', 'dateutil.zoneinfo', 'dateutil.parser']

>>> print(pf.find())'
['dateutil', 'build', 'ci_tools', 'docs', 'dist', 'dateutil.tz', 'dateutil.test', 'dateutil.zoneinfo', 'dateutil.parser', 'build.lib', 'build.lib.dateutil', 'build.lib.dateutil.tz', 'build.lib.dateutil.zoneinfo', 'build.lib.dateutil.parser', 'docs.samples']

This would be a very dangerous change to the default, for very little gain. Some of those directories are generated directories (meaning that running setup.py twice would give different results). I think namespace packages should remain opt-in indefinitely.

@pganssle you need to define the excludes when running find()

@pganssle considering for example the maven over at java world, it defines some common grounds, e.g. test-sources, test-resources, sources, and resources. all of these are based on specific conventions, especially the location on where to find these resources. yet, one can still configure the otherwise heavily biased build system to their likings.
and the same is true with include and exclude, both of which have been there for a very long time, but due to python supporting only one kind of package idiom, namely the one with __init__.py, nobody actually cared about these mechanisms. nobody? no wait, there are actually a lot of people using these idioms, especially the exclude.

@silkentrance I know how to write the excludes, what I'm saying is that currently find_packages() just works for a large fraction of all Python projects. Most Python projects are not using namespaces and the src layout is not as popular as the "package directly in root".
What that means is that by changing the default thing that find_packages does, for most people we're making find_packages harder to use, not easier. What's more, if you continued to use find_packages as the majority of people do - which is to say using find_packages() or find_packages(excludes=['tests']) or some limited thing, when someone starts using python setup.py with a recent version of setuptools, it will silently start including a bunch of directories like build and test. A lot of them won't even notice this is happening.
 On the other hand, we could easily make this behavior opt-in, so that anyone with a namespace package can just do:
PACKAGES = find_packages(include=['src'], implicit_namespace=True)

And it will work just fine. If it's so easy for people to manually include and exclude their package directories, why is it so difficult to ask people with implicit namespace packages to opt-in to this behavior? After all, you want the default option to be the common case and the opt-in to be the uncommon case. Implicit namespace packages are decidedly the uncommon case.

we could easily make this behavior opt-in

Just please don't have a boolean flag in the parameters to the function. Use a different function name for selecting different behavior (e.g. find_packages_ns or similar with the same signature as find_packages).

Just please don't have a boolean flag in the parameters to the function.

I'm fine with it being a separate function. Normally I'm not a big fan of a bunch of proliferating boolean parameters, but I think this is a borderline case. It's fundamentally the same function used in one of two modes. All the rest of the input parameters are the same and have the same effects and the result is the same (conceptually). This sort of "mode" flag is just providing information about whether this is a package with implicit namespaces or not in the same way that include tells you where the base package locations are and exclude tells you what parts are not part of the package.
In any case, if you're fundamentally against a boolean parameter I don't see a problem with keeping it separate. I've been promoting using alternate constructor-style variants lately because I prefer find_packages.namespace to find_packages_namespace, but find_package_ns works too.

@pganssle @jaraco I have changed the commit accordingly. find_packages will behave as normal and will not change its behaviour with newer python versions. find_packages_ns needs some more work though, in case it is running on a python version that does not support PEP420 namespace packages.

@silkentrance I think you maybe forgot to push or commit your changes or something, because I'm still seeing the version where find_packages is set to find_packages_ns in Python 3.

@pganssle I have changed the exports and tests accordingly. find_packages_ns is exported only for Python 3.3+. Similarly, the tests will now be executed for Python 3.3+.

One possible objection in favor of letting this find_packages_ns exist on older versions of Python is that as a general rule you cannot count on the version of Python used to invoke setup.py being the same as the version of Python for which you are installing the package and the script doesn't actually require Python 3 to work.
That said, it would be pretty unusual to create Python 3-only packages using Python 2, so I think I'm in favor of leaving it the way it is.

@jmbowman Yes, I think there are no substantive objections to adding this, it just needs documentation and a changelog entry as you mention.
Ideally once we have the documentation built on PRs, we can rebase this PR and look at the docs. I'd really like to reconsider how this looks in the API documentation before merging.

@pganssle I have rebased to master and dropped find_packages_std.

@pganssle rebased and resolved conflicts. what is the status about this?

@pganssle I have removed the PY3 check altogether since you mentioned that Python < 3.3 is no longer supported.
I have also updated the documentation and the changelog.

Python 2.7 is still supported.

@pganssle argh. okay, will include the checks again.

@silkentrance FYI I moved the changelog entry into changelog.d and rewrote the history of the branch to separate the commits into the logical changes (that's not necessary it's just something I like to do). I'd like to take a quick look at the documentation before merging but I think it's essentially ready.

@pganssle how did you separate the forced commits? or did you do new commits, assuming my user name when committing?

Hm, where should we put it then? As for exact caveats, what do you have in mind? Present the user with a possible project structure and folders underneath some source root that look like packages but should be excluded?

I made some changes to the documentation and pushed them to this branch. I was going to make it a PR against your fork, but there was some sort of problem with that, not sure what was going on there.

how did you separate the forced commits? or did you do new commits, assuming my user name when committing?

Are you sure you want to know this? I have been afflicted by this knowledge in the sense that now that I know it is possible to rewrite commit histories to align with my aesthetic preferences, I feel compelled to do so, which really makes the "Merge pull request" button a less useful :P.

Thanks for your contribution @silkentrance!

You are welcome.


Changing envoy zipkin bit tracing

The 128 bit tracing of zipkin is interfering with one of my applications. Is there a way to change it to 64 bit?

I believe the only configuration option for Zipkin is the address of the Zipkin.
https://preliminary.istio.io/docs/reference/config/istio.mesh.v1alpha1/#Tracing-Zipkin
How is 128 bit tracing interfering with your app, and why will 64 bit fix it?

@esnible I'm working with Confluence and it isn't compatible with 128 bit tracing only 64 bit.

@michael-lancaster This is currently hardcoded in the bootstrap config: https://github.com/istio/istio/blob/master/tools/packaging/common/envoy_bootstrap_v2.json#L600

you could use https://github.com/istio/istio/tree/master/samples/custom-bootstrap

Proper api is tracked in https://github.com/istio/istio/issues/24287. Workaround is mentioned above. I think we can close this. Thanks!


mock fail because document doesn't contain root

It seems that using mock: true doesn't works .
throw new Error('hydrateRoot(...): Target container is not a DOM element.');
          ^

Error: hydrateRoot(...): Target container is not a DOM element.
    at hydrateRoot (repo\node_modules\.pnpm\react-dom@18.2.0_react@18.2.0\node_modules\react-dom\cjs\react-dom.development.js:29403:11)
    at hydrateRoot$1 (repo\node_modules\.pnpm\react-dom@18.2.0_react@18.2.0\node_modules\react-dom\cjs\react-dom.development.js:29810:10)
    at file:///repo/node_modules/.pnpm/vite-react-ssg@0.5.2_react-dom@18.2.0_react-router-dom@6.21.1_react@18.2.0_vite@5.0.11/node_modules/vite-react-ssg/dist/index.mjs:172:11
    at Object.startTransition (repo\node_modules\.pnpm\react@18.2.0\node_modules\react\cjs\react.development.js:2433:5)
    at file:///repo/node_modules/.pnpm/vite-react-ssg@0.5.2_react-dom@18.2.0_react-router-dom@6.21.1_react@18.2.0_vite@5.0.11/node_modules/vite-react-ssg/dist/index.mjs:171:15

I think the problem came from
      const container = typeof rootContainer === "string" ? document.querySelector(rootContainer) : rootContainer;

here, the document is the default document from JSDomGlobal . And so, doesn't contain the rootContainer

Thanks for pointing this out, it will be fixed soon.

Thanks for pointing this out, it will be fixed soon.


Add Swift Package Manager support

Hello,
Flutter is migrating to Swift Package Manager. Please add Swift Package Manager support to your plugin.
Flutter will eventually deprecate and then remove support for CocoaPods. Adding Swift Package Manager support future-proofs your plugins.
How to add Swift Package Manager support to your plugins
You can find the migration guide here: https://docs.flutter.dev/packages-and-plugins/swift-package-manager/for-plugin-authors#how-to-add-swift-package-manager-support-to-an-existing-flutter-plugin
If you run into issues or have questions, please reach out to the Flutter team. You can ping me at @loic-sharma, send a message to the #hackers-ios channel on Flutter’s discord, or open a GitHub issue.
Thank you for your wonderful contributions to the Flutter ecosystem!
Why is Flutter migrating to Swift Package Manager?
CocoaPods is now in maintenance mode.
Swift Package Manager support is one of Flutter’s most requested features: flutter#33850.
Flutter's Swift Package Manager integration has several benefits:

Access to the Swift package ecosystem. Flutter plugins can use the growing ecosystem of Swift packages.
Simplifies Flutter installation. Swift Package Manager is bundled with Xcode. In the future, you won’t need to install Ruby and CocoaPods to target iOS or macOS.

@loic-sharma thanks for that. Do you know when SPM support will hit stable, since according to the docs, it says that it's still under development.
Once SPM support is stable, then I'll go ahead and migrate it.

@diegotori We're doing a release this month that will make the SwiftPM feature stable behind an opt-in.
However, the SwiftPM package structure is already stable today. Plugin authors are encouraged to begin migrating today :)
Please let me know if you have any follow-up questions!

@loic-sharma in that case, I won't be able to get to it until after the 19th, since I'm gonna be out of the country for the next couple of weeks.
I'm assuming by then, you guys would have released a new Flutter version. I'll definitely get it done then.

@loic-sharma I also accept PRs if this makes the process go smoother.

There's no rush - feel free to land this when you're ready. I hope you have wonderful holidays :)

@loic-sharma one more thing: when I add SPM support, what happens to the existing Cocoapods integration? Will SPM replace Cocoapods, and not live in parallel to SPM, for cases such as backwards compatibility.
Just curious how the transition will work when not every package will migrate to SPM right away.

For now, your plugin should support both CocoaPods and SwiftPM in parallel. This allows your plugin to be used by folks that are on both new and old Flutter SDKs. For more information, see: https://docs.flutter.dev/packages-and-plugins/swift-package-manager/for-plugin-authors#how-to-add-swift-package-manager-support-to-an-existing-flutter-plugin
When Flutter's SwiftPM feature is available, Flutter will use the SwiftPM to build a plugin if it supports it. Flutter will fallback to using CocoaPods for plugins that don't support SwiftPM yet.
In the future, we'll remove CocoaPods support from Flutter and unmigrated plugins will be broken. This is likely at least a year away from happening, if not later.
Please let me know if you have more questions! :)


Add object collision primitives

In the recent force push, I added a line to the top of the ObjectCollisionBox class definition that details why it inherits ObjectCollisionConvexHull. This might be overkill, and I'm interested in thoughts on it.


Fix syntax error when join unrelated entity with discriminator entity

When joining a unrelated entity with a discriminator the join contains the table name and alias in brackets which is a syntax error (at least in SQL Server).

@Deltachaos 🚢 and backported! Thanks!


wrong documentation

This answer its ambiguous, it not clear that is talking about the scanner (Microsoft Purview (formerly Azure Purview) doesn't support scanning SharePoint and OneDrive) and let admins think that purview does not support, but it support,  but the article its talking about scanner.
Currently, Microsoft Purview (formerly Azure Purview) doesn't support scanning SharePoint and OneDrive. Scanning for on-premises SharePoint sites and libraries is provided through the Azure Information Protection scanner. The scanner is available for use through a customer's Microsoft 365 subscription with the following SKUs: AIP P1, EMS E3, and Microsoft 365 E3. If you have any one of these SKUs, you should have the right entitlements to start using the Azure Information Protection scanner.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0a701383-9762-d874-e191-bf7ec0f1871a
Version Independent ID: 782d7f98-294b-0c2d-1c11-a7018870e229
Content: Frequently asked questions (FAQ) - Microsoft Purview
Content Source: articles/purview/frequently-asked-questions.yml
Service: purview
GitHub Login: @SunetraVirdi
Microsoft Alias: suvirdi

@sergiojuchem
Thanks for your feedback! We will investigate and update as appropriate.

@sergiojuchem - Thank you. I'll make some updates to try and make this clearer.
I am updating it to this:
Scanning for on-premises SharePoint sites and libraries is provided through the Azure Information Protection scanner. The scanner is available for use  through a customer's Microsoft 365 subscription with the following SKUs: AIP P1, EMS E3, and Microsoft 365 E3. If you have any one of these SKUs, you should have the right entitlements to start using the Azure Information Protection scanner. Currently, Microsoft Purview (formerly Azure Purview) doesn't support scanning SharePoint and OneDrive into the Microsoft Purview Data Catalog.
Is that clearer?

Hi, for sure its more clear now, but may be, if you think that make sense, you can refer the URL from docs where admin can consult data types for sharepoint and one drive to help to know the diference= https://learn.microsoft.com/en-us/microsoft-365/compliance/data-classification-overview?view=o365-worldwide#top-sensitivity-labels-applied-to-content
Many thanks.
Obter o Outlook para Androidhttps://aka.ms/AAb9ysg

From: Whitney Henderson @.>
Sent: Thursday, March 23, 2023 3:29:41 PM
To: MicrosoftDocs/azure-docs @.>
Cc: sergiojuchem @.>; Mention @.>
Subject: Re: [MicrosoftDocs/azure-docs] wrong documentation (Issue #107048)
@sergiojuchemhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsergiojuchem&data=05|01||1d21488c4f4a45f55d4c08db2bcc91b3|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638151929845773162|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=n1wsmpDuRK0YREGTDFSVyH9tE5zOkUZroJ8Df0GS%2B6U%3D&reserved=0 - Thank you. I'll make some updates to try and make this clearer.
I am updating it to this:
Scanning for on-premises SharePoint sites and libraries is provided through the Azure Information Protection scanner. The scanner is available for use through a customer's Microsoft 365 subscription with the following SKUs: AIP P1, EMS E3, and Microsoft 365 E3. If you have any one of these SKUs, you should have the right entitlements to start using the Azure Information Protection scanner. Currently, Microsoft Purview (formerly Azure Purview) doesn't support scanning SharePoint and OneDrive into the Microsoft Purview Data Catalog.
Is that clearer?
—
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F107048%23issuecomment-1481701334&data=05|01||1d21488c4f4a45f55d4c08db2bcc91b3|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638151929845773162|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=qITnN4YyIIyRvAcBSQd2rIXDbvts55wrj44WHkVmMpg%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAK3BQREJ657ITLR47CUG6XTW5SJBLANCNFSM6AAAAAAWEJ42BM&data=05|01||1d21488c4f4a45f55d4c08db2bcc91b3|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638151929845773162|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=IhPJ49FTgyjnxscYgYeQjAQ6%2BJ5Bb7be8wsOcVqT3Y8%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

@sergiojuchem - Yeah, that's a great idea! I can do that.
I've made the request and you should see those changes by Monday at the latest.
Thanks so much for taking the time!

#please-close


Add tzdata-info to run rails server in docker

I rule and have completed some work on Case Manager that's ready for review!
This pull request makes the following changes:

Adds tzinfo-data gem to make docker-compose run web not choke on a timezone error
Includes everything in #724

@DarthHater @mchelen can you all take a look and confirm this is cool? This seemed like the least painful solution to the problem (other stuff involves stackoverflow or docker repo arguments over what wild workaround is the least unobtrusive).

Current coverage is 98.81% (diff: 100%)

Merging #725 into master will increase coverage by 0.33%

@@             master       #725   diff @@
==========================================
  Files            28         28
  Lines           589        589
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            580        582     +2
+ Misses            9          7     -2
  Partials          0          0

Powered by Codecov. Last update a684be6...bd15800

This looks fine to me. I don't have the issue locally but if it works for you then A+ +1


Dependabot cherry-pick 2

PR summary
Gather dependabot PRs into one PR.
PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit messages follow the
Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] New tests
[ ] Build/CI related changes
[ ] Documentation content changes
[x] Other (please describe)

What is the current behavior?
This PR has all the commits from dependabot PRs:

https://github.com/IBM/cloudant-java-sdk/pull/41 -> sdk-core
https://github.com/IBM/cloudant-java-sdk/pull/42 -> maven-checkstyle-plugin
https://github.com/IBM/cloudant-java-sdk/pull/43 -> jacoco-maven-plugin
https://github.com/IBM/cloudant-java-sdk/pull/44 -> gson
https://github.com/IBM/cloudant-java-sdk/pull/45 -> maven-project-info-plugin

What is the new behavior?
This PR bumps the dependencies to the versions mentioned in the commit messsages.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Thanks for the reviews @bessbd and @emlaver! I'm about to merge this!


Fixes issues #52 and #53 - creates changelog and moves updates from readme to it

Perfect thanks. Can you also add your name to the Contributor List?

 I went ahead and submitted a PR to the contributor list w/ my name on it.


Update work item service create method to accept both inmemory and API data

This is taken care of in this PR - https://github.com/almighty/almighty-ui/pull/113


setFixedLengthStreamingMode Fix for API < 19

Description
setFixedLengthStreamingMode(Long) requires at least Android API 19. If that method is not found, call the old setFixedLengthStreamingMode(Int).
Type of change
Check all that apply

[X] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactoring (a change which changes the current internal or external interface)
[ ] This change requires a documentation update

How Has This Been Tested?
Tested this with my app and API 15.
Checklist:

[X] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation, if necessary
[X] My changes generate no new compiler warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[ ] Inspect the bytecode viewer, including reasoning why

That is great for personal objects, but not for business.

Keeping minsdk low because you have < 1% of your users on annold phone that no longer receives security updates is a bad business practice.
I see absolutely no value supporting an SDK below 21, let alone 19.

I kinda agree with @SleeplessByte, I think we should support > 21 ... Shall we bump the minSDK instead of this?
@rumboalla Do you have a strong reason to support < 21?


Linkcheck and warnings

Fixed links using linkcheck in Sphinx. Lots of http -> https and some real fixes.
(My philosophy is that using URLs which is redirected at target webpage is just a broken link waiting to happen, so all URLs have been changed to their redirectes.)
Also replaces broken link mentioned in #159.
What type of change is this?
Doc update
Checklist

I added a line to the CHANGELOG.rst file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
[x] I ran all tests on my computer and it's all green (i.e. invoke test).
[x] I ran lint on my computer and there are no errors (i.e. invoke lint).
[ ] I added new functions/classes and made them available on a second-level import, e.g. compas_fab.robots.Configuration.
I have added tests that prove my fix is effective or that my feature works.
I have added necessary documentation (if appropriate)

Need to test if http -> https broke description loading in integration tests.

@gonzalocasas: Reasoning behind: 0b0c101
We could use regex instead, something like b"xmlns=http[s]?://..." but that will be a pain to keep compatible between 2 and 3.
The schema could be specified with either, the http url redirects to https.

Is this still relevant?

Is this still relevant?

Now it's as relevant as it was when I opened it, so yeah a little bit? Haha!

@gonzalocasas: Reasoning behind: 0b0c101
We could use regex instead, something like b"xmlns=http[s]?://..." but that will be a pain to keep compatible between 2 and 3.
The schema could be specified with either, the http url redirects to https.

I wrote this, but I don't remember the compat problem. If I know myself I tried regex before str.replace.

@tetov  :+1:


Testing: TestPipelineExceedMaximumServing

--- FAIL: TestPipelineExceedMaximumServing (0.01s)
	pipeline_test.go:100: failed to send out message
2016-09-09 22:04:30.068434 I | rafthttp: started HTTP pipelining with peer 1
2016-09-09 22:04:30.079030 I | rafthttp: stopped HTTP pipelining with peer 1
2016-09-09 22:04:30.079704 I | rafthttp: started HTTP pipelining with peer 1
2016-09-09 22:04:30.090107 I | rafthttp: stopped HTTP pipelining with peer 1
2016-09-09 22:04:30.090789 I | rafthttp: started HTTP pipelining with peer 1
2016-09-09 22:04:30.091157 I | rafthttp: stopped HTTP pipelining with peer 1
2016-09-09 22:04:30.091562 I | rafthttp: started HTTP pipelining with peer 1
2016-09-09 22:04:30.091932 I | rafthttp: stopped HTTP pipelining with peer 1
2016-09-09 22:04:30.092380 I | rafthttp: started HTTP pipelining with peer 1
2016-09-09 22:04:30.092741 I | rafthttp: stopped HTTP pipelining with peer 1
2016-09-09 22:04:30.093341 I | rafthttp: started HTTP pipelining with peer 1
2016-09-09 22:04:30.093703 I | rafthttp: stopped HTTP pipelining with peer 1
2016-09-09 22:04:30.094310 I | rafthttp: started HTTP pipelining with peer 1
2016-09-09 22:04:30.097785 I | rafthttp: stopped HTTP pipelining with peer 1
2016-09-09 22:04:30.098431 I | rafthttp: start to send database snapshot [index: 0, to 1]...
2016-09-09 22:04:30.099874 I | rafthttp: receiving database snapshot [index:0, from 0] ...
2016-09-09 22:04:30.100052 I | snap: saved database snapshot to disk [total bytes: 5]
2016-09-09 22:04:30.100117 I | rafthttp: received and saved database snapshot [index: 0, from: 0] successfully
2016-09-09 22:04:30.100379 I | rafthttp: peer 1 became active
2016-09-09 22:04:30.100414 I | rafthttp: database snapshot [index: 0, to: 1] sent out successfully
2016-09-09 22:04:30.100909 I | rafthttp: start to send database snapshot [index: 0, to 1]...
2016-09-09 22:04:30.101732 W | rafthttp: database snapshot [index: 0, to: 1] failed to be sent out (ioutil: short read)
2016-09-09 22:04:30.101803 I | rafthttp: receiving database snapshot [index:0, from 0] ...
2016-09-09 22:04:30.101919 E | rafthttp: failed to save KV snapshot (unexpected EOF)
2016-09-09 22:04:30.102497 I | rafthttp: start to send database snapshot [index: 0, to 1]...
2016-09-09 22:04:30.103658 I | rafthttp: receiving database snapshot [index:0, from 0] ...
2016-09-09 22:04:30.103729 W | rafthttp: database snapshot [index: 0, to: 1] failed to be sent out (ioutil: short read)
2016-09-09 22:04:30.103817 E | rafthttp: failed to save KV snapshot (unexpected EOF)
2016-09-09 22:04:30.104227 I | rafthttp: start to send database snapshot [index: 0, to 1]...
2016-09-09 22:04:30.105222 W | rafthttp: database snapshot [index: 0, to: 1] failed to be sent out (ioutil: expect EOF)
2016-09-09 22:04:30.105363 I | rafthttp: receiving database snapshot [index:0, from 0] ...
2016-09-09 22:04:30.105466 E | rafthttp: failed to save KV snapshot (unexpected EOF)
2016-09-09 22:04:30.106642 I | rafthttp: started streaming with peer 1 (writer)
2016-09-09 22:04:30.106719 I | rafthttp: peer 1 became active
2016-09-09 22:04:30.106760 I | rafthttp: established a TCP streaming connection with peer 1 (stream Message writer)
2016-09-09 22:04:30.107668 W | rafthttp: closed an existing TCP streaming connection with peer 1 (stream Message writer)
2016-09-09 22:04:30.107710 I | rafthttp: established a TCP streaming connection with peer 1 (stream Message writer)
2016-09-09 22:04:30.108795 W | rafthttp: closed an existing TCP streaming connection with peer 1 (stream Message writer)
2016-09-09 22:04:30.108866 I | rafthttp: established a TCP streaming connection with peer 1 (stream Message writer)
2016-09-09 22:04:30.127550 I | rafthttp: closed the TCP streaming connection with peer 1 (stream Message writer)
2016-09-09 22:04:30.127627 I | rafthttp: stopped streaming with peer 1 (writer)
2016-09-09 22:04:30.130066 I | rafthttp: started streaming with peer 1 (writer)
2016-09-09 22:04:30.130168 I | rafthttp: peer 1 became active
2016-09-09 22:04:30.130227 I | rafthttp: established a TCP streaming connection with peer 1 (stream Message writer)
2016-09-09 22:04:30.130334 E | rafthttp: failed to write 1 on stream Message (blah)
2016-09-09 22:04:30.130375 I | rafthttp: peer 1 became inactive
2016-09-09 22:04:30.131429 W | rafthttp: lost the TCP streaming connection with peer 1 (stream Message writer)
2016-09-09 22:04:30.131522 I | rafthttp: stopped streaming with peer 1 (writer)
2016-09-09 22:04:30.155729 I | rafthttp: started streaming with peer 2 (stream Message reader)
2016-09-09 22:04:30.166170 I | rafthttp: peer 2 became active
2016-09-09 22:04:30.166255 I | rafthttp: established a TCP streaming connection with peer 2 (stream Message reader)
2016-09-09 22:04:30.166334 W | rafthttp: lost the TCP streaming connection with peer 2 (stream Message reader)
2016-09-09 22:04:30.166527 I | rafthttp: stopped streaming with peer 2 (stream Message reader)
2016-09-09 22:04:30.189377 I | rafthttp: started streaming with peer 2 (stream Message reader)
2016-09-09 22:04:30.189660 I | rafthttp: started streaming with peer 1 (writer)
2016-09-09 22:04:30.190654 I | rafthttp: peer 1 became active
2016-09-09 22:04:30.190717 I | rafthttp: established a TCP streaming connection with peer 1 (stream Message writer)
2016-09-09 22:04:30.190765 I | rafthttp: peer 2 became active
2016-09-09 22:04:30.190799 I | rafthttp: established a TCP streaming connection with peer 2 (stream Message reader)
2016-09-09 22:04:30.191176 W | rafthttp: lost the TCP streaming connection with peer 2 (stream Message reader)
2016-09-09 22:04:30.191247 I | rafthttp: stopped streaming with peer 2 (stream Message reader)
2016-09-09 22:04:30.194575 I | rafthttp: started streaming with peer 1 (writer)
2016-09-09 22:04:30.197213 I | rafthttp: started streaming with peer 2 (stream Message reader)
2016-09-09 22:04:30.199112 I | rafthttp: peer 1 became active
2016-09-09 22:04:30.199183 I | rafthttp: established a TCP streaming connection with peer 1 (stream Message writer)
2016-09-09 22:04:30.199371 I | rafthttp: peer 2 became active
2016-09-09 22:04:30.199426 I | rafthttp: established a TCP streaming connection with peer 2 (stream Message reader)
2016-09-09 22:04:30.199917 W | rafthttp: lost the TCP streaming connection with peer 2 (stream Message reader)
2016-09-09 22:04:30.199991 I | rafthttp: stopped streaming with peer 2 (stream Message reader)
2016-09-09 22:04:30.205364 I | rafthttp: started streaming with peer 1 (writer)
2016-09-09 22:04:30.207941 I | rafthttp: started streaming with peer 2 (stream MsgApp v2 reader)
2016-09-09 22:04:30.209955 I | rafthttp: peer 1 became active
2016-09-09 22:04:30.210246 I | rafthttp: established a TCP streaming connection with peer 1 (stream MsgApp v2 writer)
2016-09-09 22:04:30.210473 I | rafthttp: peer 2 became active
2016-09-09 22:04:30.210542 I | rafthttp: established a TCP streaming connection with peer 2 (stream MsgApp v2 reader)
2016-09-09 22:04:30.211930 W | rafthttp: lost the TCP streaming connection with peer 2 (stream MsgApp v2 reader)
2016-09-09 22:04:30.212032 I | rafthttp: stopped streaming with peer 2 (stream MsgApp v2 reader)
2016-09-09 22:04:30.223443 I | rafthttp: closed the TCP streaming connection with peer 1 (stream MsgApp v2 writer)
2016-09-09 22:04:30.223546 I | rafthttp: stopped streaming with peer 1 (writer)
2016-09-09 22:04:30.224670 I | rafthttp: closed the TCP streaming connection with peer 1 (stream Message writer)
2016-09-09 22:04:30.224751 I | rafthttp: stopped streaming with peer 1 (writer)
2016-09-09 22:04:30.227687 I | rafthttp: closed the TCP streaming connection with peer 1 (stream Message writer)
2016-09-09 22:04:30.227753 I | rafthttp: stopped streaming with peer 1 (writer)
2016-09-09 22:04:30.228946 I | rafthttp: starting peer 1...
2016-09-09 22:04:30.229324 I | rafthttp: started HTTP pipelining with peer 1
2016-09-09 22:04:30.231999 I | rafthttp: started streaming with peer 1 (writer)
2016-09-09 22:04:30.235914 I | rafthttp: started streaming with peer 1 (writer)
2016-09-09 22:04:30.250668 I | rafthttp: started streaming with peer 1 (stream MsgApp v2 reader)
2016-09-09 22:04:30.251175 I | rafthttp: started streaming with peer 1 (stream Message reader)
2016-09-09 22:04:30.251446 I | rafthttp: started peer 1
2016-09-09 22:04:30.251751 I | rafthttp: added peer 1
2016-09-09 22:04:30.251898 I | rafthttp: stopping peer 1...
2016-09-09 22:04:30.252037 I | rafthttp: stopped streaming with peer 1 (writer)
2016-09-09 22:04:30.252157 I | rafthttp: stopped streaming with peer 1 (writer)
2016-09-09 22:04:30.252308 I | rafthttp: stopped HTTP pipelining with peer 1
2016-09-09 22:04:30.252424 I | rafthttp: stopped streaming with peer 1 (stream MsgApp v2 reader)
2016-09-09 22:04:30.252521 I | rafthttp: stopped streaming with peer 1 (stream Message reader)
2016-09-09 22:04:30.252590 I | rafthttp: stopped peer 1
2016-09-09 22:04:30.252990 I | rafthttp: starting peer 1...
--
FAIL
coverage: 76.1% of statements

lgtm


Deployment produces error message: Can't find app with name ""

Deployment consistently produces the message below:
Can't find app with name "nabgnbfunc"
VERBOSE: Using Bicep v0.17.1
VERBOSE: Performing the operation "Creating Deployment" on target "nabgnb".
VERBOSE: 3:56:36 PM - Template is valid.
VERBOSE: 3:56:37 PM - Create template deployment 'configDeployment'
VERBOSE: 3:56:37 PM - Checking deployment status in 5 seconds
VERBOSE: 3:56:42 PM - Resource Microsoft.Resources/deployments 'dpnabgnb-signalRUpstream' provisioning status is running
VERBOSE: 3:56:42 PM - Checking deployment status in 13 seconds
New-AzResourceGroupDeployment: C:\Users\resilv\projects\nab\GraphNotificationBroker\deploy.ps1:76:9
Line |
76 |          New-AzResourceGroupDeployment -ResourceGroupName $ResourceGro …
|          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| 3:56:55 PM - The deployment 'configDeployment' failed with error(s). Showing 1 out of 1 error(s). Status Message: At least
| one resource deployment operation failed. Please list deployment operations for details. Please see
| https://aka.ms/arm-deployment-operations for usage details. (Code: DeploymentFailed)  - Unable to process template language
| expressions for resource
| '/subscriptions/fc32e9bf-e5fe-4f57-ae78-583aa2772cfd/resourceGroups/nabgnb/providers/Microsoft.SignalRService/signalR/nabgnbsignalr' at line '1' and column '1360'. 'The language expression property 'signalr_extension' doesn't exist, available properties are ''.' (Code:InvalidTemplate)   CorrelationId: a99566d8-xxxx-xxxx-xxxx-xxxxxxxxx
Looking in Azure portal, I can see that the function was deployed, but the error persists

@RenSilvaAU thanks for registering the issue. Apologize for the delay in working this thru. Will update here when we have a resolution for it.

So I was able to figure out the issue in my case.  The older version of the Azure Core Tools was not successfully deploying the azure function, which means that the signalr_extension key was not available for the rest of the script to find, since that is only available after the function is deployed.
I was able to fix all of this by uninstalling the Azure Core Tools then reinstalling the newest version from
https://learn.microsoft.com/en-us/azure/azure-functions/functions-run-local
The following issue https://github.com/MicrosoftDocs/azure-docs/issues/122341 helped me to resolve this.  I initially though the Could not load file or assembly System.Net.Http.Formatting, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35. The system cannot find the file specified. error was coming from the build but realized it was coming from the deploy script calling  func azure functionapp publish "$($ApplicationName)func" --csharp and that the Azure Core Tools itself was the problem.


[Explore]: Source code to Image conversion

Background
Blocked By
[Explore]: Packaging source code as Carvel's imgpkg
Based on the recommendation from cloudfoundry/cf-k8s-api#35, explore on how to convert source code into the recommended image format.
Things to remember

Ease of Scalability
Performance

Acceptance Criteria
The pair working on this story can decide b/w documenting the decision in an ADR or a proposal document.
Number of days this exploration is expected to take. This is what is “pointed”.
No response
Dev Notes

One approach is to implement this as a separate service 'registry-service' or another way would be to make it part of the api-shim itself.

Superseded by cloudfoundry/cf-k8s-api#46

Closing this ^^


Feature request : Images in cell

Hi,
Can we add images instead of text inside any cell via url? Or can we assign 'Image' type to any column? Something like the following -

Would be great to have this feature.Thanks!

Hello,
I have the same requirement. I would like to insert an image in each line of the table, but I cannot open the website you gave. Could you provide another link to jsfiddle？ Thanks.


Added MetaMask.Blazor

Added the MetaMask.Blazor project https://github.com/michielpost/MetaMask.Blazor to use the MetaMask browser extensions with Blazor

Thanks!


Slowing down on first call to cloud function on android device

Unity editor version: 2019.1.8f1
Firebase Unity SDK version: 6.1.1
Firebase plugins in use (Auth, Database, etc.): analytics, auth, messaging
Additional SDKs you are using (Facebook, AdMob, etc.): Facebook 7.17.0
Platform you are using the Unity editor on (Mac, Windows, or Linux): Windows
Platform you are targeting (iOS, Android, and/or desktop): Android
The first time call a function after running app, get a response after approximately two minutes.
exports.test = functions.https.onRequest((req, res) => {     const now = Date.now();     return res.send(JSON.stringify(now)); });
The first time call a function, it responds slowly, but after I receive it, I get a very fast response.
In addition, when using Wi-Fi on the Android terminal, I get a very fast response. When use LTE, receive a very slow response.
In some cases, people who have tested on their Android devices receive quick response while using LTE.
What's wrong? I hope you help me.

@berabue
If I understand you correctly, you were using Firebase Cloud Function Unity SDK to call a Cloud Function.  The first time you call the function after launching the app would usually take a long time like 2 minutes.  But the following call would take a much shorter time.
A couple of question:

Could you check your Firebase Console and see if your Cloud Function logged any error?

Does it happen if you play in the editor too?
When did it start to happen?  Did you upgrade the SDK before it started to happen?
Could you try to upgrade to our latest SDK (6.6.0 now) and see if the issue is resolved?  You can also see the execution time there.

Shawn

@chkuang-g
The function was used through the http request without invoking it using the Unity SDK.

Firebase console check result error log not logged.
If exit and rerun the app using Application.Quit() in Unity, I will receive a quick response, but if exit and rerun the app using the Android device Menu, I will receive a slow response.
Get a quick response from the editor.
There was no problem two weeks ago.
I will try Unity SDK and record additional threads.

"I will try Unity SDK and record additional threads."
Please do.  6.1.1 was released on June 7.  Many thing can be improved during this time.
Please let us know if the long delay still happens to you in the latest Firebase SDK.
Shawn

@chkuang-g
Testing using the version 6.1.1 of the Firebase Cloud Functions SDK confirmed that the request was completed without delay.
However, a delay occurs when the SDK is not used and the http request is made.
I will be forced to add SDK due to delay in response from app in service.
But I don't think that's a fundamental solution. Is there any way to get a quick response to a http request?

Since on android, OkHttpClient is used to make the request it might be related to this issue: https://github.com/square/retrofit/issues/1489

@berabue if a delay occurs without the Unity SDK it makes me wonder whether you're forming the same request that is being generated by the SDK.  The Unity SDK uses the C++ and Android SDKs i.e it ends up hitting the code here https://github.com/firebase/firebase-android-sdk/blob/69f29d43f4b4e14bed7f5c44a1dc3883c11cce57/firebase-functions/src/main/java/com/google/firebase/functions/FirebaseFunctions.java#L238 which follows the protocol https://cloud.google.com/functions/docs/reference/rest/v1/projects.locations.functions/call .
To @markchandler-google 's point if you're using a different HTTP client like OkHttp it's possible a bug in that library is causing the slow start.


[2.0] nextTick don't guarantee this.$el in in-document

Vue.js version
2.0.3
Steps to reproduce
I try to use this but Chrome logs an error Uncaught TypeError: Cannot read property 'getBoundingClientRect' of undefined:
mounted() {
   this.$nextTick(() => {
       this.calendarHeight = this.$el.querySelector('.calendar').getBoundingClientRect().height
   })
}

You could add a jsfiddler to provide more context.

This doesn't seem to be related to wether it's in-document or not: the query for .calender returned undefined (shouldn't it be null?).
If .calendar should be rendered in the component's template but is not there when the component is mounted, then this is a bug; however this seems highly unlikely so a repro is needed.

I will try my best to repro this because I face this problem when working in a private repo.


Laravel 11.23.2 Shift

This pull request includes updates for the recent minor version release of Laravel as well as updates to your package dependencies. Feel free to commit any additional changes to the shift-ci-v11.23.2 branch.
Before merging, you need to:

Checkout the shift-ci-v11.23.2 branch
Review all pull request comments for additional changes
Run composer update
Thoroughly test your application (no tests?, no CI?)

:warning: The Shift build servers run PHP 8.2. If you are running a different version of PHP you should run composer update locally to ensure you have the proper versions of your dependencies to reflect your PHP environment.

Nothing extra from PHP8.3 composer update


url_launcher 5.0.2 mailto scheme doesn't work on iOS where there are dots in the email address

For example:
mailto:fake.name@gmail.com?subject=hi
Android: works
iOS: doesn't work
mailto:fakename@gmail.com?subject=hi
Android: works
iOS: works

you need to URL encode it

I am using WebView_flutter to use WebView but when I click on Mailto: it going on Page not Found. if i use url_launcher to handle mailto: link it open Default mail app but My page also going PAGE NOT FOUND
https://stackoverflow.com/q/56421218/9489285

@rockgecko-development @techximumsolutions do you still experience the issue?

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


Fixed source select bug

The source selection box switches to an empty string briefly between selections, this was causing an error for the service call.

Thanks!


Inject Internet permission at build time

When we create a new Flutter app, we add this to AndroidManifest.xml:
    <!-- The INTERNET permission is required for development. Specifically, flutter needs it to communicate with the running application
         to allow setting breakpoints, to provide hot reload, etc.
    -->
    <uses-permission android:name="android.permission.INTERNET"/>

Developers are expected to remove this when producing release builds if their app does not need this permission. However, as there is only a single manifest file used for both debug and release that means you need to edit the file whenever you are switching between debug and release.
It would be much better if we could inject this permission into the build at build time (for debug builds only!).

See also https://github.com/flutter/flutter/issues/2138.

Looks like this was fixed by #22139, #26450


Old link in README

In the README there is such a link
[repository settings](https://github.com/escience-academy/escience-academy.github.io/settings).
it can be automatically redirected to https://github.com/esciencecenter-digital-skills/esciencecenter-digital-skills.github.io/settings which however is a 404 page.
I have no idea how to fix it, maybe it's because I don't have access to the settings page.

Hello @CunliangGeng thank you for reporting this. I updated the URL


Unnecessary text

Even though you owe us nothing, have shared your talent with us and own this work I think you went too far with the issue from zdm that you deleted. You had made your point and there was no need to add an extra message that was abusive. You may feel justified in lashing out at people because they are not as talented as you but I would like to say to you now, categorically, you are not. I think you should remember back to the people who helped you learn. I'm sure you were never on the receiving end of abuse for an oversight when you were a newbie. There is no purpose to it. I used to think you were caustically funny but you crossed a line for me last week. You have created a community around your work and you don't have to answer us anymore than you already do or change your hard-ass tone (of which I have been on the receiving end of) but you're not justified  in going to the extra effort of abusive ranting. Words matter as you pointed out in your screed. Feel free to delete this when/if you read it. I have no wish to start a debate.

Github needs to get that Discussions feature going, pretty sure that will solve the problem, instead of creating issue for every random question which are intended for bug reports etc, I post some dumb stuff from time to time, but check out this Discussion feature looks pretty cool https://github.com/vercel/next.js/discussions

I'm about 110% categorically justified in expressing anything between heaven and earth, thank you very much.
We've had extensive freedom of expression laws established in Sweden since before USA was even an idea. Of course, if you want to forcefully limit the written word to only a tiny safe space bubble where no criticism may exist you can always go to China or North Korea. But it won't favor you, anyways.
I could have been more friendly in this particular case, sure, but analphabetic stupidity has no place in this repo and it makes me angry. We have a lowest bar and if you fall below it you can go do finger painting somewhere else.


On-Board project to the .NET Foundation

We're getting ready to bring the project into the .NET Foundation, but before we
do we need to do the following:
Getting into the .NET Foundation

[x] Make sure the project has a good name that is easy to remember and
spell. Check that it doesn't conflict with another existing project
[x] Make sure the people involved in the project want to join the .NET Foundation
[x] Make sure the project has a clear understanding about how it accepts contributions and the process
it follows when selecting new committers to the project.
[x] Register an interest in joining the .NET Foundation
[x] Work with the .NET Foundation to fill out an On-Boarding Questionaire
[x] .NET Foundation sends out completed questionaire to .NET Foundation Advisory Council for comments
[x] .NET Foundation Executive Director submits new project proposal to the .NET Foundation Board
[x] Configure a CI build for the project and ensure build status badges are available from the README

Once accepted into the .NET Foundation

[x] Sign the contribution / assignment agreement
[x] Agree a date to move into the .NET Foundation
[ ] Prepare a guest blog post announcing the move on the .NET Foundation Blog
[x] Read the code of conduct,
link to it in your code and
understand what to do if you are concerned about any behaviour or have
concerns reported to you.
[ ] Tell the world we have joined!
[x] Get CLA Automation enabled to ensure contributors can easily sign the
Contribution License Agreement
[ ] Send a PR to add the Project into the .NET Foundation
list
[x] Ensure the repo contents are up to date with .NET Foundation guidance
[ ] Review the README guidance and update if necessary
[ ] If applicable update the LICENSE file to show Copyright has been assigned to the .NET Foundation
and look to update any file headers.
[ ] If applicable, update any copyright statements in websites owned by the project to reflect
assignment to the .NET Foundation
[ ] If applicable, update any websites associated with the project to include
"Supported by the .NET Foundation" or
similar link back to the .NET Foundation in the footer. If applicable, please
include image links from our swag repo. (We think a link in the footer using the horizontal logo looks very nice.)
[x] Sign up for Project Leader news
[ ] Configure any resources requested from the .NET Foundation (SSL Certs, Code Signing,
Secret Management, Build Servers etc)

any news on this?

[x] .NET Foundation sends out completed questionaire to .NET Foundation Advisory Council for comments
[x] .NET Foundation Executive Director submits new project proposal to the .NET Foundation Board

Closing as completed


Do you plan to make a subset of cppformat available for more constraint environment?
Specifically:

Ability to turn off POSIX error handling. I don't have stderr, I only have serial.
Ability to turn off classes that requires dynamic memory allocation - stack based alternative for MemoryWriter, and ability to turn off support for basic_string.
Ability to turn off wchar support, which is not always available, and not always cost-effective to implement.
Ability to use custom printing function, without requiring user to take all the c++ streams abstraction.

Would you accept pull requests in this direction?

Hi,
Thank you for the nice feedback.

Do you plan to make a subset of cppformat available for more constraint environment?

No, I don't have any plans specifically targeting constrained environments.

[1] Ability to turn off POSIX error handling. I don't have stderr, I only have serial.

I'm not sure what you mean by that. The errors are reported as exceptions, but you can provide your own error handling mechanism via FMT_THROW.

[2] Ability to turn off classes that requires dynamic memory allocation - stack based alternative for MemoryWriter, and ability to turn off support for basic_string.

I think turning off classes with dynamic memory allocation completely via conditional compilation will be too messy, but writing to a fixed, possibly stack-allocated, array is already supported:
char buffer[100];
fmt::ArrayWriter w(buffer);
w.write("The answer is {}", 42);

This could be wrapped in a function for even easier use:
char buffer[100];
format_array(buffer, "The answer is {}", 42);

[3] Ability to turn off wchar support, which is not always available, and not always cost-effective to implement.

Again, I think it would be too messy to turn off completely, but it doesn't add any overhead if you don't use it.

[4] Ability to use custom printing function, without requiring user to take all the c++ streams abstraction.

IOStreams are already optional and only used when formatting types that provide an overloaded ostream operator<<. You can provide a custom formatting function by overloading format instead:
void format(Formatter &f, const char *&format_str, const MyType &value) {
  // parse format_str and format value
}

I'm also open to pull requests that improve support for such environments provided that they don't obscure the code by introducing a lot of conditional compilation or similar. If you have any specific ideas, I recommend discussing them here or in separate issues before preparing a full PR (although a small prototype to demonstrate the idea might be useful).

I'm closing this for now, but feel free to reopen or open another issue to discuss any specific suggestion in more details.


Mention add-ons in setup section overview

This is a Feature Request

What would you like to be added
Add a section near the end of the text in https://kubernetes.io/docs/setup/ that mentions add-ons, and links to some information about adding them to your cluster.
Why is this needed
Kubernetes is a platform for building platforms. Once you have a cluster, you're very often going to want to add things to it such as:

a resource metrics pipeline
additional workload scaling APIs and controllers
storage plugins
ingress controllers

…the list goes on.
Comments
The setup page should signpost readers to understand that a cluster with working container runtimes and cluster networking is not the endpoint; it is perhaps more like the end of the beginning!
/language en
/kind feature

/triage accepted

/assign

/remove-lifecycle rotten


Call to undefined method Illuminate\Foundation\Application::share()

The method ::share() is now deprecated and you should use the ->singleton() method instead.
$container->singleton('foo', function () {
    return 'foo';
});

I've juste merged a PR that should add support for Laravel 5.4+ by fixing this problem. Thanks for reporting and sorry for the late answer.


💥 Merge lock-directory into the filename, support formatting

Apologies that I'm jumping right into a pull request, but I wrote the code already to check that it really works first, and then I thought that code speaks better than words.

Replace lock-directory/lock-filename with one lock-filename option, and also enable context formatting for it.
I think it is more convenient to specify the path to the config file once, rather than through two separate parameters.
Now one can write this, once:
lock-filename = "requirements/{env_name}.lock"

And, because we enabled context formatting the env_name will be actually substituted to the current environment name. Which can then be inherited as a template.

Hey @oprypin, this looks like a very welcome change, thank you! I'm running out the door now but hope to take a closer look this weekend.

Sure! No rush


non-steamworks dedicated server crowdcontrol mod crash

Hey David. Latest update to your Crowd Control mod appears to have broken Dedicated Server functionality where steamworks is disabled. I did some testing and have confirmed that it'll load in the dedicated tmodloader server if I enable Steam Server on tmodloader server start. The instant I disable steam server, it crashes your mod per the attached screenshot.
Not an issue if I'm hosting and playing through tmodloader itself, but becomes an issue if I want to host a dedicated server and play at the same time as steam counts it as trying to play the same game on two different devices if steam server is enabled.
The previous version 1.0.9. loaded fine without steamworks. Not sure what's changed

Thank you for submitting this issue. I'm currently looking into it.
Could you let me know how to start a dedicated with Steamworks disabled? I have launched start-tModLoaderServer.bat and inputted n so that it doesn't use Steam servers. Is there a step I'm missing?
Thanks.

that's how I was doing it. I fully redownloaded the mod too and tried before submitting the issue.

I see. Unfortunately I am unable to replicate the issue you're having. However I may have a fix.
Are you able to get in contact with me on Discord (davidfdev#8262) so I can send a custom build of the mod (GitHub won't let me attach it here).
When you receive the build can you: unsubscribe from the workshop, ensure the mod is uninstalled, then place the provided file in your mods folder (My Documents/My Games/Terraria/tModLoader/Mods/), ensure the mod is installed in-game.
Finally, start the dedicated server as you normally would and check if the issue still occurs.
Thanks.

Closing issue. Cannot reproduce.


Master

I think master branch is on 2.0 and shouldn't be merged with 1.4

This got to be an error so I'm closing it.


Upgrade to a version ESRP Release that supports federated auth

EsrpRelease@6 required a custom service connection that held an aad app secret in its configuration. The latest version, EsrpRelease@7, uses a standard ARM service connection, moving most of the configuration settings (KeyVaultName, AuthCertName ...) from the custom connection into the task itself.

/check-enforcer override
The failing jobs in the core and template pipelines are unrelated to the release task change


[FLINK-32355][table] Support to list procedures

What is the purpose of the change
To make Flink support list procedures.
Brief change log

Add an interface in Catalog to list procedure
Add a parsing rule for Show Procedure to parse the syntax to SqlShowProcedures in flink-sql-parser
Add a converter to convert SqlShowProcedures  to ShowProceduresOperation.
Add the actual execution logic in ShowProceduresOperation.

Verifying this change
UT&IT
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Most of the logic is the same, but there are some common logics, can you review it for me, and I'm sorry for the late reply.

Shall we add show procedures in user docs?

I would like to do it in another pr to keep this pr fouces.

@luoyuxia Hi, yuxia. I also submit a PR #22903. Most of the logic is the same, but there are some common logics, can you help to review it? thanks and i'm sorry for the late reply.

Review done. PTAL.

Hi, it looks good to me. but ci failed, maybe error usage of '<>' in javadoc.

@luoyuxia hi, yuxia. I leave a few minor comments, PTAL.

@luoyuxia Thanks for your review. I hope I have addressed your comments.

@luoyuxia Thanks for your review. I hope I have addressed your comments.

Hi, yuxia. i mean your likeType and likePattern both @Nullable. If user give a not null likeType and null likePattern, can we throw exception in Constructor phase rather than rely on method implementation.

@chucheng92 Thanks. I got you. I have updated it.

Looks good. +1 for the PR. @luoyuxia

@chucheng92 Thanks for the review. WIll merge later.


[Setting - Startup]: Screen reader is not announcing the sub-text information for 'Launch size' and 'Launch parameter'.

Windows Terminal version
1.19.2481.0
Windows build number
23529.1000
Other Software
Test Environment:
OS: Windows 11 Version Dev (OS Build 23529.1000)
App: Windows Terminal Preview
Steps to reproduce
Repro Steps:
1.Open Windows Terminal.
2.Open Settings page using 'Ctr+,'
3. Navigate to the Startup page.
5. Navigate over the 'Launch size' and 'Launch parameter' using Narrator and observe the issue.
**User Experience: **
When a screen reader does not provide complete information, it is difficult for people using assistive technology (like screen readers) to understand the functionality of the control. Having complete information about the control will help users to use the control as per their required task.
MAS Reference:
https://www.w3.org/WAI/WCAG21/Understanding/info-and-relationships
Attachment :
Screen reader is not announcing the sub-text information for 'Launch size' and 'Launch parameter'..zip
Expected Behavior
Screen reader should announce the sub-text information for 'Launch size' and 'Launch parameter'.
Actual Behavior
Screen reader is not announcing the sub-text information for 'Launch size' and 'Launch parameter'.

Logged by mistake


Blank template option when creating a turbo repo project

Which project is this feature idea for?
Turborepo
Describe the feature you'd like to request
There is only one template when creating a turbo repo project. It should have an option to remove the default template and use a blank one.
Describe the solution you'd like
For some developers, who are already familiar with Turborepo they would like to use turborepo from a blank template that has no apps and packages.
Describe alternatives you've considered
Provide steps in the docs on how to setup a blank project.

Yes, I'm looking for a way to create a turbo repo project with no apps and packages.

You can use the canary version (should land in latest soon) of create-turbo with templates support for this!
npx create-turbo@canary -e https://github.com/tknickman/turborepo-empty-starter


Add checkpoint structure for BlockContext

BlockContext::checkpoint() returned a whole copy of BlockContext, while only a subset of its fields were actually part of the checkpoint. The other fields, unused, were filled by default values.
Instead, use a structure dedicated to BlockContext checkpoints, containing only the relevant fields.

Could you confirm that rows and cols fields of BlockContext never change (that were copied to and restored from the checkpoint, I did not included them here)?

Coverage decreased (-0.05%) to 82.581% when pulling d3673b89939e3e98882b9e3193f993ed0a038cb2 on rom1v:checkpoint into 65bd158b585e47384a928a243689ea1c5c3ce74a on xiph:master.


"Deform Prefabs" makes trigger volumes turn into regular physics volumes instead

As per title

TODO: Investigate whether or not "Deform to Terrain" has the same effect.


Migration Log

This is an auto-generated issue. The migration log is in the following comment(s).

Log Chunk 1
[2023-11-29T11:08:56Z] INFO -- Migration started by ChristianLejdstrom from https://github.com/vfg-digital/devise_ldap_authenticatable to test-migration-2/devise_ldap_authenticatable
[2023-11-29T11:08:56Z] INFO -- Migration ID: c8178203-8f9a-40da-86f6-9dbf7939cd7c
[2023-11-29T11:08:56Z] INFO -- -----------------------------
[2023-11-29T11:08:56Z] INFO -- Git source migration started
[2023-11-29T11:09:35Z] INFO -- Git source migration completed
[2023-11-29T11:09:35Z] INFO -- -----------------------------
[2023-11-29T11:09:35Z] INFO -- Extraction started
[2023-11-29T11:09:41Z] INFO -- Extraction complete
[2023-11-29T11:09:41Z] INFO -- -----------------------------
[2023-11-29T11:09:43Z] INFO -- Transformation started
[2023-11-29T11:09:49Z] INFO -- Transformation complete
[2023-11-29T11:09:49Z] INFO -- -----------------------------
[2023-11-29T11:09:49Z] INFO -- Import started
[2023-11-29T11:09:49Z] WARN -- 'Allow Forking' setting could not be enabled for the repository because it is not enabled at the organization level.
[2023-11-29T11:10:01Z] INFO -- Import complete
[2023-11-29T11:10:01Z] INFO -- -----------------------------
[2023-11-29T11:10:01Z] INFO -- Migration complete
[2023-11-29T11:10:01Z] INFO -- -----------------------------


localhost keycloak broken

AUTH_DISCOVERY_URI=https://auth.permaplant.net/realms/PermaplanT/.well-known/openid-configuration
AUTH_CLIENT_ID=localhost

leads to an error when logging in https://auth.permaplant.net/realms/PermaplanT/protocol/openid-connect/auth?client_id=localhost&redirect_uri=http%3A%2F%2Flocalhost%3A5173%2Fmap&response_type=code&scope=openid&state=...&code_challenge=...-...&code_challenge_method=S256&response_mode=query
We are sorry...
Invalid parameter: redirect_uri

It happened on #404 but is probably unrelated to that.
Probably an issue with the the configured redirct uris.
Keycloak should allow all redirect URIs starting with http://localhost:5173

The login works for me on the base uri: http://localhost:5173

Thx, this can be used as workaround!

According to the docs:
https://github.com/ElektraInitiative/PermaplanT/blob/a488fb88e200f473eaf57bde2ea169c93fac6eea/doc/setups/keycloak/README.md?plain=1#L26-L28
{
  "clientId" : "localhost",
  "name" : "localhost",
  "rootUrl" : "http://localhost:5173/",
  "adminUrl" : "http://localhost:5173/",
  "redirectUris" : [ "/*" ],
  "webOrigins" : [ "+" ],
  "publicClient" : true
}

so those seem to match.
Maybe we need to add the full rootUrl to redirectUris.

According to the docs:
https://github.com/ElektraInitiative/PermaplanT/blob/a488fb88e200f473eaf57bde2ea169c93fac6eea/doc/setups/keycloak/README.md?plain=1#L26-L28
{
  "clientId" : "localhost",
  "name" : "localhost",
  "rootUrl" : "http://localhost:5173/",
  "adminUrl" : "http://localhost:5173/",
  "redirectUris" : [ "/*" ],
  "webOrigins" : [ "+" ],
  "publicClient" : true
}

so those seem to match.
Maybe we need to add the full rootUrl to redirectUris.

You have a slash at the end of rootUrl. That might make a difference.

 I totally missed the trailing slash! I'll take a look at this and other clients as well (e.g. #383).


NK-7: Investigate Travis-CI integration efforts

Check following issues:

[x] auto-creation of nightly branch from related branches
[ ] running unit tests

It turned out that it is possible to automatically create pre-release (nightly) branch with relevant topic branches merged into. To achieve this, a nighly_deployment branch has been created. It contains Travis YAML which performs following steps:

reset back to master
merge relevant topic branches
push commits to nightly branch


Inline diagnostics font color fix

Inline diagnostics font color fix. Previous (black) color is barely visible on a dark background. BTW - great theme!

Thanks for the participating in improving the theme!
Since I haven't used Visual Studio for quite a while, I wasn't aware of the availability of this feature. I hope now more people will be able to use it properly


Broken links in README

Describe the bug
There are multiple dead links in the README.
To Reproduce
Click on any of these links:

https://blog.getgauge.io/why-we-built-gauge-6e31bb4848cd (anchor text "Why gauge?")
https://docs.gauge.org/latest/writing-specifications.html (anchor text "terminologies")
https://docs.gauge.org/latest (anchor text "Gauge Documentation")

Logs
Not applicable
Expected behavior
The links should work.
Screenshots
Not applicable
Versions:
Not applicable
Additional context
As a new user thinking about using Gauge, stumbling on dead links in the README leaves a bad impression.

Thanks for reporting this!
The right links are

https://gauge.org/2018/05/15/why-we-built-gauge/
https://docs.gauge.org/writing-specifications.html
https://docs.gauge.org/latest

Do you want to send a pull request with these changes?

@zabil Sure, I will create a PR :)

@zabil I just noticed the third link is the same dead link as before


Use a different recipe for unit tests

Currently we use https://github.com/pangeo-forge/gpcp-feedstock/ for our unit tests, run with --prune. @rabernat suggested this might not be the best idea, and we should try something else. Opening this to track if we need to replace it, and if so, with what.

Following merge of #26 (where tests passed), tests subsequently failed with a 502:
raise ClientResponseError(\\naiohttp.client_exceptions.ClientResponseError: 502, message=\'Proxy Error\', url=URL(\'[https://www.ncei.noaa.gov/data/global-precipitation-climatology-project-gpcp-daily/access/1996\](https://www.ncei.noaa.gov/data/global-precipitation-climatology-project-gpcp-daily/access/1996/)')", "status": "failed"}\n'

I believe this is related, insofar as the issue here is instability of the gpcp source server?

Despite the fact that these ☝ tests failed on merge, I still released v0.5 to PyPI, which I believe is justified given that the unit tests passed on #26, and there were no code changes in between those passing tests and the failed tests on merge.


Paste not in the Context Menu on Chrome (42.0.2311.135m)

I am using Chrome and I don't see the Paste option in the Context Menu.
in the term.js I created I can not use the Ctrl + V, It is already used. So it looks like I stuck with the Paste from the General Menu of Chrome.
Is there another way to enable the Paste in the Context Menu?

I am running into the same issue here.. any thoughts?

the firefox fix will fix this issue too.

Hi,
Could you point me to this fix?
Thanks

https://github.com/chjj/term.js/issues/51

I made a Pull Request that support Copy and Paste using hidden textarea.
https://github.com/chjj/term.js/pull/97


⚠ Bofrost.at has degraded performance

In f7bd755, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1576 ms

Resolved: Bofrost.at performance has improved in 30f2c01 after 14 minutes.


Let BOHB directly use ConfigSpace file

What would you like to be added:
The possibility to use a native ConfigSpace configuration file to use with BOHB.
Why is this needed:
ConfigSpace is a very sophisticated framework to represent parameter configuration spaces. It supports conditional and forbidden configurations.
The NNI search space does not support conditional parameters directly and, for BOHB, does not support conditionals at all. Forbidden configurations are not supported in any way.
Without this feature, how does current nni work：
You use the possibilities that are given via the search space and its translation to ConfigSpace in BOHB which excludes conditionals and forbidden configurations.
Components that may involve changes:

Search space definition
BOHB advisor initialization

Brief description of your proposal if any:
I actually don't see an easy way to tackle this. Two possibilities would be

use ConfigSpace to begin with
extend NNI's search space definition to include conditionals and and forbidden configurations and translate them appropriately to ConfigSpace within BOHB.

I see that 1. would be a major overhaul that is most probably not desired. Also, ConfigSpace might have properties not desired by the NNI team.
2. Would seem to be quite some work.
For now, I went another, not quite clean, way in a personal NNI fork at https://github.com/khituras/nni:
There, I allow to specify a native ConfigSpace configuration file as a search space parameter like this:
{
    "ConfigSpace": {"_type":"choice", "_value": ["bohb-parameters.pcs"]}
}

In launcher.py, I check if such a parameter is there and, if so, extend the given path with trial code directory to make it absolute
In bohb_advisor.py, I check again for the ConfigSpace parameter and, if found, load the given file directly.

I could create a PR from that. I didn't until now because I don't expect this solution to be favorable for your framework. But it was a quick fix that seems to work fine for me.

Could you make the "bohb-parameter.pcs" an optional argument for BOHB advisor init function. When this pcs is available, it becomes the search space for tuner and directly ignores the search space json from NNI. I think this is more elegantly than defining a new search space format.

Thank you for the response! I would like the optional argument. However, the init function is called in a generic way, as far as I understand the code, so I wouldn't know how to actually pass the .pcs file (or the ConfigSpace .json file; ConfigSpace understands multiple file formats).
Any hints appreciated, I would love to make a useful contribution here.

Closing as PR has been merged.


Use temporary version of rust-dlc to circumvent bug

This is an attempt at dealing with the consequences of https://github.com/get10101/10101/issues/480.
I don't think rust-dlc#ln-dlc-channels intends to be backwards-compatible at this stage, so this is not something that we want to upstream.

The idea here is to use this branch to start up the mainnet coordinator and close a few DLC channels that are outdated. We can use the logs to identify which ones are old, or simply close all of them.
This is not guaranteed to "fix" #480, but it's the leading theory.

@luckysori I'll have a look whether this fixes the coordinator state I ran into on regtest.

The idea here is to use this branch to start up the mainnet coordinator and close a few DLC channels that are outdated. We can use the logs to identify which ones are old, or simply close all of them.

It looks like our mainnet is effected by this problem.

Storage error Nonsense bytes didn't map to the type they were interpreted as

We know that we do have a "broken" channel on mainnet.
Can we close said channel somehow?
What's the intention once the channel is closed?

@luckysori I believe we can now close this PR, right?


AxisRight inside Group

Is there an example of using <AxisLeft /> in conjunction with <AxisRight />? It might also be useful to upgrade the demo https://vx-demo.now.sh/axis to show <AxisRight /> as well.
When I try to use <AxisRight /> in the following example it is rendered in the middle of the graph. I'm not sure if this is a bug or incorrect usage on my part.

Edit: It appears that <AxisRight /> does not work when specified within a <Group />. Example https://codesandbox.io/s/9qlypmz9qy
Note that this is based on the example provided https://github.com/Flaque/vx-tut/blob/d537efd827c76f09bfeaf6643af0bdb4fd1281b5/pages/index.js and used in the getting started blog post

fixed by https://github.com/hshoff/vx/pull/271 and confirmed fix in https://github.com/hshoff/vx/pull/280


SidMenu not able to present half of the screen in ios13, but working in ios12

I have read the guidelines for contributing and I understand

[ ] My issue is happening in the latest version of SideMenu (older versions are no longer maintained).
[ ] My issue was not solved in the README.
[ ] My issue can not be answered on stackoverflow.com.
[ ] My issue is not a request for new functionality that I am unwilling to build and contribute with a pull request.
[ ] My issue is reproducible in the demo project.

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

I have the same problem...

Same here...

@Imtiazaa I suggest you edit and check. (Latest Version, README, StackOverflow, Not new functionality)

It's unclear what the problem is from this issue but in iOS 13 modals are presented differently by default.

@Imtiazaa the issue https://github.com/jonkykong/SideMenu/issues/492 could help you!

You might want to set the modalPresentationStyle = .fullscreen


Remove outdated tier information

Resolve issue #60

Coverage remained the same at 94.846% when pulling 6214de65b556d28ee099cc95b17db6192ae74857 on iss-60 into 1196f3f25f8afe449dedf50e9cb108a993c3193f on master.

Oops, this PR should be for the dev branch.


Update uca_guide.md

Added the instructions on how to create pull requests and how to edit documents in general. Not sure if images are working though (I already added them to the "img" folder).

There seems to be conflicts and I can't commit the branch? @nkrusch can you check if I have the syntax for the images correct?


save/load datasets with personal github repo

Once we have github OAuth integration in place we can create a repo for each user on their behalf to act as a store for their datasets: profile, switch, trace, etc.
Each page (packet, profile, switch, simulation) would load the existing data sets found on that users github//flowsim.datasets/ repository.
Saving changes to any data set would case a git hub push to the appropriate remote set.
This allows a few things:

users data can grow with their own accounts
users can make their data sets private if they wish

Github has a very straight forward interface for 3rd party interaction.
https://developer.github.com/v3/


RecursionError in pyjl JuliaMethodCallRewriter & is_list

For input
import io

class X:
    io = io

    def y(self):
        rawio = io.FileIO("abc", "wb")

main backtrace:
...
pyjl/transpiler.py:29: in visit_Call
    rv = is_list(node.func.value)
py2many/tracer.py:68: in is_list
    and is_list(var.assigned_from.value)
py2many/tracer.py:68: in is_list
    and is_list(var.assigned_from.value)
py2many/tracer.py:68: in is_list
    and is_list(var.assigned_from.value)
E   RecursionError: maximum recursion depth exceeded in comparison

v0.2.1 backtrace:
Traceback (most recent call last):
  File "./py2many.py", line 16, in <module>
    main()
  File "./py2many/cli.py", line 354, in main
    rv = _process_once(settings, source, outdir, env=env)
  File "./py2many/cli.py", line 278, in _process_once
    transpile(
  File "./py2many/cli.py", line 104, in transpile
    tree = rewriter.visit(tree)
  File "/usr/local/Caskroom/miniconda/base/lib/python3.8/ast.py", line 363, in visit
    return visitor(node)
  File "/usr/local/Caskroom/miniconda/base/lib/python3.8/ast.py", line 439, in generic_visit
    value = self.visit(value)
  File "/usr/local/Caskroom/miniconda/base/lib/python3.8/ast.py", line 363, in visit
    return visitor(node)
  File "/usr/local/Caskroom/miniconda/base/lib/python3.8/ast.py", line 439, in generic_visit
    value = self.visit(value)
  File "/usr/local/Caskroom/miniconda/base/lib/python3.8/ast.py", line 363, in visit
    return visitor(node)
  File "/usr/local/Caskroom/miniconda/base/lib/python3.8/ast.py", line 439, in generic_visit
    value = self.visit(value)
  File "/usr/local/Caskroom/miniconda/base/lib/python3.8/ast.py", line 363, in visit
    return visitor(node)
  File "/usr/local/Caskroom/miniconda/base/lib/python3.8/ast.py", line 448, in generic_visit
    new_node = self.visit(old_value)
  File "/usr/local/Caskroom/miniconda/base/lib/python3.8/ast.py", line 363, in visit
    return visitor(node)
  File "./pyjl/transpiler.py", line 19, in visit_Call
    if is_list(node.func.value) and fname.attr == "append":
  File "./py2many/tracer.py", line 70, in is_list
    and is_list(var.assigned_from.value)
  File "./py2many/tracer.py", line 70, in is_list
    and is_list(var.assigned_from.value)
  File "./py2many/tracer.py", line 70, in is_list
    and is_list(var.assigned_from.value)
  [Previous line repeated 979 more times]
  File "./py2many/tracer.py", line 65, in is_list
    var = node.scopes.find(get_id(node))
  File "./py2many/scope.py", line 58, in find
    defn = find_definition(scope, "vars")
  File "./py2many/scope.py", line 52, in find_definition
    if get_id(var) == lookup:
  File "./py2many/analysis.py", line 19, in get_id
    if isinstance(var, ast.alias):
RecursionError: maximum recursion depth exceeded while calling a Python object

Dart has the same problem:
pydart/transpiler.py:144: in visit_Attribute
    if is_list(node.value):
py2many/tracer.py:68: in is_list
    and is_list(var.assigned_from.value)
py2many/tracer.py:68: in is_list
    and is_list(var.assigned_from.value)
py2many/tracer.py:68: in is_list
    and is_list(var.assigned_from.value)
E   RecursionError: maximum recursion depth exceeded in comparison
!!! Recursion detected (same locals & position)


Revert "zfs: unlock for 5.15"

Motivation for this change
This reverts commit 86e057aa5b6b44aa20b65ed194ec359e897bd89d.
Things done

[x] Fits CONTRIBUTING.md.

After having my zfs partition borked from the SEEK_HOLE issue, I'm apprehensive about pushing the bounds of zfs. I would like to be more on the side of caution. Especially since data integrity is the first priority for anything.

That was a zfs bug and not a compatibility issue but a zfs bug: https://github.com/openzfs/zfs/issues/11900

After having my zfs partition borked from the SEEK_HOLE issue, I'm apprehensive about pushing the bounds of zfs. I would like to be more on the side of caution. Especially since data integrity is the first priority for anything.

That was a zfs bug and not a compatibility issue: openzfs/zfs#11900

Although I absolutely agree, it still makes me more risk adverse.

You win some, you lose some I guess.
This in combination with #147446 means that I woke up the other day to not getting a graphical login screen. Turns out that thanks to 5.14 being EOL I'm now stuck on 5.10, where amdgpu does not yet have any support for my card at all (RDNA2).

Well. You can just apply https://github.com/Mic92/nixpkgs/commit/b31e0be77366618eab2a3f7a0648ec1786504732
I used for some weeks now without issues.

@TredwellGit 2.1.2 is out, and lists 5.15 support :pleading_face:

https://github.com/NixOS/nixpkgs/pull/150923


Implement new Meter Sink for measuring/reporting Pipeline throughput

Measurements will include frames-per-sec-per-source (fpsps) and average-frames-per-sec-per-source (afpsps).
The Sink type will be derived from a fake Sink and will be sufficient for a Pipeline to link/play, meaning that no other Sink will be required for Pipeline operation.
The client will register a handler function on Sink construction, to "handle" the reported measurements as needed (write to console, etc.) Returning false from the callback will disable the Meter... true and the Meter will continue to take measurements.
Client Callback
typedef boolean (*dsl_sink_meter_client_handler_cb)(double** fps_list, double** avg_fps_list,
    uint list_size, void* client_data);

Sink Construction:
DslReturnType dsl_sink_meter_new(const wchar_t* name, uint interval,
    dsl_sink_meter_client_handler_cb client_handler, void* client_data);

with reporting interval in seconds.  Sink will be enabled by default.
Services to get/set the enabled setting and interval will be included.
DslReturnType dsl_sink_meter_enabled_get(const wchar_t* name, boolean* enabled);
DslReturnType dsl_sink_meter_enabled_set(const wchar_t* name, boolean enabled);
DslReturnType dsl_sink_meter_interval_get(const wchar_t* name, uint* interval);
DslReturnType dsl_sink_meter_interval_set(const wchar_t* name, uint interval);

done


Change to :aom-21: (autumn) emoji

It's almost autumn! Here's the emoji I'm proposing. Let me know if i should make any changes:

also I declare autumn has began

Awesome 😎


Yosys design to ODIN_II netlist transformation

This PR provides in memory transformation of Yosys design to ODIN-II netlist with respect to fpga architecture and config file via newly introduced odintechmap pass. Moreover, osinsim pass is implemented for testing purpose to be sure the transformation is flawless.

git submodule update --init --recursive should be executed before make for vtr submodule.

a short description on added/updated files:

added:
passes/odintechmap/odintechmap.cc --> the most important one
passes/odintechmap/odinsim.cc
.github/workflows/test-linux.yml
.github/workflows/test-mac.yml
.gitmodules

updated:
Makefile
.github/workflows/vs.yml

other files within passes/odintechmap/ and techlibs/odintechmap/ directories are intact (copied).

Thanks @poname, for the clarification. I am reviewing it; once it's done will leave all comments here.


Segfault in 'Simplify the CFG' pass with Pony 0.22.6

Got a segfault compiling my hobby project on Arch Linux x86_64:
https://bitbucket.org/bytefu/funky/src/simplify-cfg-fail/
$ ponyc
Building builtin -> /usr/lib/pony/0.22.6/packages/builtin
Building . -> /home/burjui/Devel/funky
Building libfunky -> /home/burjui/Devel/funky/libfunky
Building files -> /usr/lib/pony/0.22.6/packages/files
Building time -> /usr/lib/pony/0.22.6/packages/time
Building collections -> /usr/lib/pony/0.22.6/packages/collections
Building ponytest -> /usr/lib/pony/0.22.6/packages/ponytest
Building buffered -> /usr/lib/pony/0.22.6/packages/buffered
Building term -> /usr/lib/pony/0.22.6/packages/term
Building promises -> /usr/lib/pony/0.22.6/packages/promises
Building strings -> /usr/lib/pony/0.22.6/packages/strings
Building signals -> /usr/lib/pony/0.22.6/packages/signals
Building capsicum -> /usr/lib/pony/0.22.6/packages/capsicum
Building format -> /usr/lib/pony/0.22.6/packages/format
Building itertools -> /usr/lib/pony/0.22.6/packages/itertools
Building libfunky/ast -> /home/burjui/Devel/funky/libfunky/ast
Generating
 Reachability
 Selector painting
 Data prototypes
 Data types
 Function prototypes
 Functions
 Descriptors
Optimising
Stack dump:
0.      Running pass 'Simplify the CFG' on function '@Main_val_process_ooo'
[1]    9226 segmentation fault (core dumped)  ponyc

Though the segfault goes away after uncommenting the line 66 in main.pony:
token_count = token_count + 1

GDB shows the following stacktrace:
#0  0x00007ffff4f747c4 in llvm::removeUnreachableBlocks(llvm::Function&, llvm::LazyValueInfo*) () from /usr/lib/libLLVM-6.0.so
#1  0x00007ffff5376dab in ?? () from /usr/lib/libLLVM-6.0.so
#2  0x00007ffff47efdc1 in llvm::FPPassManager::runOnFunction(llvm::Function&) ()
   from /usr/lib/libLLVM-6.0.so
#3  0x00007ffff47efebd in llvm::legacy::FunctionPassManagerImpl::run(llvm::Function&)
    () from /usr/lib/libLLVM-6.0.so
#4  0x00007ffff47f0405 in llvm::legacy::FunctionPassManager::run(llvm::Function&) ()
   from /usr/lib/libLLVM-6.0.so
#5  0x00005555555fc8b4 in optimise(compile_t*, bool) ()
#6  0x00005555555fca40 in genopt ()
#7  0x000055555560b031 in genexe ()
#8  0x000055555559a96e in codegen ()
#9  0x0000555555579be7 in compile_package ()
#10 0x000055555557978d in main ()

It would appear to be read code removing a giant chunk of the program and then getting angry.
What was the last version of Pony that you know this compiled with?

@burjui could you try to create a more minimal example?

This was introduced by 9222f08c97f0079f0d5d7f732d246c09969daa4d and my fix for https://github.com/ponylang/ponyc/issues/2735 which was also caused by the same commit didn't fix this. A minimal example would go a long way to helping with this.

Here's a minimal example that I think is the same.
actor Main
  new create(env: Env) =>
    var token = U8(1)
    repeat
      (token, let source) = (U8(1), U8(2))
    until token == 2 end

@jemc @Praetonus I think this one is past my current compiler knowledge paygrade.

I tested the fix and it works, thank you. I have never seen bugfixes coming that soon after reporting an issue, wonderful!

Interesting. Its looking like a different bug. But I need more time to triage. @burjui I might ask you to open a different issue.

@burjui this is a different bug that appears in the same kind of way. can you open an issue for it?

This existed at least as far back as 0.21.3

This goes back to the introduction of the _ as valid syntax. Without that, this compiles now, so when opening a new issue, we should note that.


New gradle logo

In a recent update of intellij (2018.2 beta 2) it has a new gradle logo, hereby my request to update the logo

This has been implemented in the rewrite.


Add docker-compose

This PR attempts to consolidate the docker scripts into a single docker-compose setup. AFAIK, the mariadb-proxy container runs mariadb-proxy-rs which sends commands to mariadb-server and tendermint. I'm not totally clear on how TM makes its way in there; perhaps someone could clarify based on the links sections in the docker-compose.yml.
Omitted from docker-compose is the mysql client container since it requires sleeping for 30s before mariadb comes online, and then immediately exits as the terminal is non-interactive. I could use some help understanding where exactly the mysql client is used (if not exclusively from mariadb-proxy-rs). Is it for verifying that data has been committed? In that case, one can always docker exec mariadb-server mysql --user=root --host=localhost --port=3306 --password=devpassword and feed it commands.
Otherwise, to run,
docker-compose up

and, to enter the rust container, make shell.
Currently, the tendermint container exits with a permission denied error, but that seems to be due to this issue. If I had an example of how the integration tests use the proxy and TM, I'd be better able to get this part running.

https://www.docker.com/blog/maintainable-integration-tests-with-docker/


Update manual submission process to reflect new policies in effect for spam report processing

The Microsoft Security Research Spam Analysis team replied to a manually submitted spam report saying their automation cannot process spam reports sent without Abuse Reporting Formatting standards. Outlook does not add ARF when a message is sent with the offending email attached. The documentation for manual submission does not reflect this requirement. According to the spam analyst who informed the customer of the inability to process the submitted attachment, their team is not allowed to open attachments sent to<EMAIL_ADDRESS>or<EMAIL_ADDRESS>If the sender uses the Outlook junk mail reporting add-in, the proper format is added to the submission.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5b12c078-eccb-7786-dec6-ea1bdb91d088
Version Independent ID: aa1e8002-a8db-383e-cbeb-abf92c033bd3
Content: Manually submit messages to Microsoft for analysis - Office 365
Content Source: microsoft-365/security/office-365-security/submit-spam-non-spam-and-phishing-scam-messages-to-microsoft-for-analysis.md
Product: m365-security
Technology: mdo
GitHub Login: @Dansimp
Microsoft Alias: dansimp

@langjtl, so it sounds like manually reporting messages by sending them to email addresses is effectively no longer supported. I removed the topic and any references to it, and redirected it to the main Report messages and files to Microsoft.
Thanks for the feedback.
Closing


Reduce frame_shift_ms?

I changed the following parameters:
frame_length_ms=25,
frame_shift_ms=5,
max_iters=500,
The training gives good alignment audio, but alignment plot is non-sense, and evaluation (by running demo_server.py) at step 106000 give inaudible output. I am still running the training (although loss reduce very slowly now), but may be I have done something wrong with the above parameters.
Please tell me the correct way to reduce frame_shift_ms , thanks!

@t3t3t3 why do you want to reduce frame_shift_ms?


Stubs for views

I just wanted to ask if a feature can be implemented where a blade templated would be dynamically created by a command like php artisan view:make, it would be there like, sven/artisan-view but would be generated through a stub?

Feel free to send a PR for a concrete proposal