Eliminate possible recursion in Custom Comparer

Hello there,
I work with this library on a private project and it's been a huge help.
We are looking to apply custom compare logic only if certain attributes apply to the compared objects. Otherwise, we'd like to use the default compare functionality. Calling the base RootComparer.Compare() in this case results in recursion as the custom comparer gets called again.
Here's an example:
    public class CustomPetComparer : BaseTypeComparer
    {
        private readonly RootComparer _rootComparer;

        public CustomPetComparer(RootComparer rootComparer) : base(rootComparer)
        {
            _rootComparer = rootComparer;
        }

        public override bool IsTypeMatch(Type type1, Type type2)
        {
            return type1 == typeof(Pet);
        }

        public override void CompareType(CompareParms parameters)
        {
            var pet1 = (Pet) parameters.Object1;
            var pet2 = (Pet) parameters.Object2;

            if (pet2.TailWags > 5)
            {
                // create a custom difference
                AddDifference(parameters.Result, new Difference
                {
                    Object1 = parameters.Object1,
                    Object2 = null
                });
            }
            else
            {
                // process with default compare logic
                _rootComparer.Compare(parameters);
            }
        }
    }

I can work on a PR for this as time permits, but curious your thoughts. Thank you.

@jennilynhowell The else portion is not needed.  Delete that code and you should be fine.
            else
            {
                // process with default compare logic
                _rootComparer.Compare(parameters);
            }

Hey Greg,
Thanks for taking a look.
Removing the else statement results in the objects being marked as equal. Calling AddDifference(parameters); resolves that, but only identifies the objects as not equal.
The comparer is able to identify inequalities within objects of other types, and I'd like to have that same level of granularity within custom comparers (i.e. Item Expected.Name != Actual.Name). In other words, have the ability to define when the custom compare logic should and shouldn't be applied.
I added a gist that may explain better.
Appreciate your time!

@jennilynhowell I am sorry but I am not understanding at all what you are requesting.  The Gist did not help.  I think it would be best if you simply implement IComparable since it seems this is a lot of custom logic.

Hi @jennilynhowell
I have exactly the same use case and problems as yours. Did you find a solution?

Hi @jennilynhowell
I have exactly the same use case and problems as yours. Did you find a solution?

Hey @RedaAouad -- Honestly can't remember what we were trying to solve, but I think we resolved it by implementing "pre-processing" that manipulates the objects (typically List<object>s in our case) to be compared in order to achieve the desired result.
So in the above example, we would determine before comparing that pet2.TailWags > 5 and remove it from that List<Pet> ListTwo, so that it comes back as null in the comparison difference.
Hope that makes sense / helps. Happy coding!


Fix export default expression comment

Fixes #48305

I have a question about why removeAllComments is needed.

I have a question about why removeAllComments is needed.

The Input is still in the output code. And the preserveJsDoc  will not remove the original comments.
It's will be duplicated if we don't remove the comments.

@sandersn
If I add removeAllComments(input);, it will be
/**
 * JSDoc Comments
 */
declare const _default: any;
export default _default;

If I remove removeAllComments(input);, it will be
/**
 * JSDoc Comments
 */
declare const _default: any;
/**
 * JSDoc Comments
 */
export default _default;


[Cleanup] Refactor multikueue adapter tests

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Too much of repetitive code for tests.
Which issue(s) this PR fixes:

Relates #2552
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

/ok-to-test

/rerun-tests

/retest

@alculquicondor @tenzen-y here is the test refactor, please take a look

/lgtm
/approve


Pushing master -> live

Docs Build status updates of commit c9a0db2:
:clock10: Full build: the average full build time is 13 min(s) 20 sec(s), this is based on the last 525 build(s) for this repository.


Detect network errors for Node.js environment

Describe the feature
If user is offline any https request will end up with net::ERR_INTERNET_DISCONNECTED, but ofetch throws FetchError: Failed to fetch () without any way to find out that user is offline
Additional information

[ ] Would you be willing to help implement this feature?

Since it is only possible for node.js entry, we might support an option to transform error message and pass it internally.

I'm talking about client side, not server side requests. Actually most browsers support this API: https://developer.mozilla.org/en-US/docs/Web/API/Navigator/onLine
Maybe use it for network status detection?
Now if you try to call fetch() while offline in Chrome you'll get:

fetch that is internally used by ofetch differs from server side to client side.
I think implementing a logic that depends on browser-only API (i.e. navigator) in ofetch brings complexity and make the package harder to maintain (additionally, although there also seems to be a way to check internet connectivity in Node.js, it's hacky and irresponsible).
IMHO, ofetch should be kept simple and aways try to send request whenever it's called, regardless of the network situation, and instead a wrapper logic should be implemented, which checks network situation and determines whether it should call ofetch.
In the context of Nuxt, composables could be such a wrapper.


release checklist

[x] block device handling (see #19)
[ ] revocation: being able to upload a CRL which then kills potentially running vms that are revoked now; appropriate CA utilities for this (not mandatory)
[ ] vmmd_influx over TLS (not mandatory)
[x] reporting exit code properly in vmmc_* (enabled via tls.0.9.3) see #31
[x] statistics (at least interface stats) for Linux (see #2, solved in #44 #45)
[x] memory (kinfo_proc) statistics on FreeBSD (stack, data, resident in pages)
[x] document / generate ASN.1 grammar (done in #48)
[x] shellcheck packaging scripts
[x] FreeBSD provide vmmd_tls startup script
[x] linux systemd init scripts (#25)
[ ] use strings for sending data (not mandaory)
[x] poper teardown of vmmd (kill all VMs)

now an initial 1.0.0 is released. I'll open specific issues for the leftover.


Add Beta disclaimer and contact info

@ewoo @BrightMeow you all can suggest edits to the copy. @broham89 can you suggest styling?
Should read something like:

Thanks for trying Articulate! We're excited that you've joined us in testing this software. I hope you enjoy using it as much as we do.
This is a pre-release of Articulate and is certain to have bugs or short comings. If you have any questions please create an issue or join us on Gitter.
Built with Rasa NLU

The create an issue should link to the new issue page and the join us on Gitter should link to our Gitter channel.
I think we should put it here:

Your draft copy works!

There is any design available for this already?

@dcalvom I will send you a html/css version of it.

@dcalvom Here are the places i've added the code for above issue.

Index.html line 38-41
scss/components/_sidenav.scss line 80-105

nlu-styles.zip

@dcalvom think you'll have a chance to get to this one soon? I want this in the release before we package up for the announement.


Fix typo in info text

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Proposed changes

This PR fixes small typos in info text of DELAY node and BATCH node.
Checklist

[x] I have read the contribution guidelines
[x] For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
[x] I have run grunt to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

Coverage remained the same at 87.755% when pulling 3b7bf04e22c195906c73a84485fcf4f7f9851c76 on node-red-hitachi:fix-typo-in-info-text into 9066cedc297025f8c219d19f788a0708dc6bfb34 on node-red:master.

Coverage remained the same at 87.755% when pulling 3b7bf04e22c195906c73a84485fcf4f7f9851c76 on node-red-hitachi:fix-typo-in-info-text into 9066cedc297025f8c219d19f788a0708dc6bfb34 on node-red:master.

Coverage remained the same at 87.755% when pulling 3b7bf04e22c195906c73a84485fcf4f7f9851c76 on node-red-hitachi:fix-typo-in-info-text into 9066cedc297025f8c219d19f788a0708dc6bfb34 on node-red:master.


bpy issue

which version of bpy did you use?
bpy.ops.mesh.boundbox_add() throw an error "AttributeError: Calling operator "bpy.ops.mesh.boundbox_add" error, could not be found".
This was occurred in bpy version 3.6.0, 3.5.0, 3.4.0.

I use blender3.0, and you can find how to add the function of the bounding box here:
https://blender.stackexchange.com/questions/14070/create-and-export-bounding-boxes-for-objects


Removed non-compliant condition in orders initialization

Issue Reference
#5123, #5118
Description
Removed non-compliant condition in orders initialization because that property is not in the order response
How To Test This?
Just enter the orders section in the administrative panel.
Documentation

[ ] My pull request requires an update on the documentation repository.

Hi @mreduar,
Yes, I am agreed with this. That property is not present.
Thanks for the contribution. :rocket:

Hi @jitendra-webkul
The issue still persist on my side.


cookbook ideas for glob crate

Come up with ideas for nice introductory examples of using glob, possibly in combination with other crates, that would be good to show in the Rust Cookbook. Please leave a comment here with your ideas! You don't necessarily have to write the example code yourself but PRs are always welcome!
The ideas should be very short and simple (not to collide with walkdir crate examples).
Most likely 1-2 examples will suffice

possible ideas:

find all png files recursively
find all files with given pattern ignoring filename case.

Those ideas sound fine to me! I've filed the issues and will post to twir.


.toggleOff() for a non-active filter removes all current filters

Hi Patrick,
When I run .toggleOff() for a non-active filter, it seems to remove all current filters. Please change it to ignore the parameter & not to remove any current filters.
Context from a real life scenario: Custom handling of <select multiple="multiple">. change handler in jQuery only works on <select>, not on its <option> children. jQuery event object doesn't indicate which option was un/selected. The obvious way is

iterate over $('option:selected') tags, use the result for a subfilter .toggleOn() - that works
iterate over $('option:not(:selected')) tags, use the result for a subfilter to .toggleOff() - if there are any options that were unselected before the change and are still unselected, then this upsets toggleOff().

A workaround is to generate a full filter string, then use mixitUpInstance.filter(myConcatenatedFilter). But that's more error-prone and less obvious to users.

Fixed in https://github.com/patrickkunka/mixitup/releases/tag/v3.2.2


Upgrade renv to v1.0.0

The shinyapps.io deployment failed because the project uses renv 0.17 but renv 1.0.0 is installed. These updates restore functionality.

Skipping review since these are auto-generated files and the deployment workflow fix was confirmed.


Start stop stream functionality added

buttons disabled on start stop

Can you update the README.md with how to get started? Or may be something like INSTALL.md

All recommended changes pushed


Encapsulate WriteSiteNotFound error

1. What does this change do, exactly?
Encapsulates writing of error response when no served vhosts match the requested host.
If HTTP version is 2.0 or above, 421 status code is written, otherwise - 404. Error now is a bit more descriptive.
2. Please link to the relevant issues.
N/A
3. Which documentation changes (if any) need to be made because of this PR?
N/A
4. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I am willing to help maintain this change if there are issues with it later

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

The RFC mentions:

This status code MUST NOT be generated by proxies.
I haven't really looked at the code flow, but this seems to be true, right? This code doesn't get hit if proxying?

@francislavoie Yeah, if we're proxying, the user would receive a proxied site, rather than this error message.

Welcome to the project, @sergeyfrolov - thanks for your first contribution!

@mholt thank you! Glad to be part of the project!


Update packages

Coverage increased (+0.2%) to 93.423% when pulling 4393b0227a0f44dc07cf66723f8ea276663a80e2 on gl3nn:update-packages into fd987eb76c3ac9b0e4f5a296eb84bae70b987fed on kayak:master.


Schedule log aggregation thread when applications finish instead of w…

…hen they start

Description of PR
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 45s

trunk passed

+1 :green_heart:
compile
1m 35s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
1m 25s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 43s

trunk passed

+1 :green_heart:
mvnsite
0m 50s

trunk passed

+1 :green_heart:
javadoc
0m 51s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 36s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
1m 37s

trunk passed

+1 :green_heart:
shadedclient
20m 51s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 19s
/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
hadoop-yarn-server-nodemanager in the patch failed.

-1 :x:
compile
0m 21s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server-nodemanager in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

-1 :x:
javac
0m 21s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server-nodemanager in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

-1 :x:
compile
0m 21s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08.txt
hadoop-yarn-server-nodemanager in the patch failed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08.

-1 :x:
javac
0m 21s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08.txt
hadoop-yarn-server-nodemanager in the patch failed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08.

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 2 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
0m 15s
/buildtool-patch-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
The patch fails to run checkstyle in hadoop-yarn-server-nodemanager

-1 :x:
mvnsite
0m 22s
/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
hadoop-yarn-server-nodemanager in the patch failed.

-1 :x:
javadoc
0m 20s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server-nodemanager in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

-1 :x:
javadoc
0m 21s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08.txt
hadoop-yarn-server-nodemanager in the patch failed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08.

-1 :x:
spotbugs
0m 20s
/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
hadoop-yarn-server-nodemanager in the patch failed.

-1 :x:
shadedclient
10m 58s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 22s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
hadoop-yarn-server-nodemanager in the patch failed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

81m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5258/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5258

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux ce884c587773 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fdb9f37c876906e8d17b2e465c39e80fd76a3a2c

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5258/1/testReport/

Max. process+thread count
607 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5258/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m 25s

trunk passed

+1 :green_heart:
compile
1m 37s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
1m 28s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 38s

trunk passed

+1 :green_heart:
mvnsite
0m 48s

trunk passed

+1 :green_heart:
javadoc
0m 47s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 33s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
1m 38s

trunk passed

+1 :green_heart:
shadedclient
21m  5s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 38s

the patch passed

+1 :green_heart:
compile
1m 23s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
1m 23s

the patch passed

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
1m 18s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 3 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
0m 26s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: The patch generated 36 new + 184 unchanged - 1 fixed = 220 total (was 185)

+1 :green_heart:
mvnsite
0m 40s

the patch passed

+1 :green_heart:
javadoc
0m 31s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 30s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
1m 28s

the patch passed

+1 :green_heart:
shadedclient
21m  6s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
26m 52s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

124m 35s

Reason
Tests

Failed junit tests
hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5258/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5258

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 3a24d57aa1f3 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c257e61598a2246ba2e9707b0a15460d3025f206

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5258/2/testReport/

Max. process+thread count
555 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5258/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m 15s

trunk passed

+1 :green_heart:
compile
1m 30s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 40s

trunk passed

+1 :green_heart:
mvnsite
0m 50s

trunk passed

+1 :green_heart:
javadoc
0m 47s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 37s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
1m 38s

trunk passed

+1 :green_heart:
shadedclient
21m 25s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 39s

the patch passed

+1 :green_heart:
compile
1m 24s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
1m 24s

the patch passed

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
1m 18s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 26s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: The patch generated 36 new + 184 unchanged - 1 fixed = 220 total (was 185)

+1 :green_heart:
mvnsite
0m 38s

the patch passed

+1 :green_heart:
javadoc
0m 32s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 27s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
1m 31s

the patch passed

+1 :green_heart:
shadedclient
20m 56s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
27m  5s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

124m 43s

Reason
Tests

Failed junit tests
hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5258/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5258

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 59a87447b6cd 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3d877b8016ff192a135eb8142338a96d7e0a0cc8

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5258/3/testReport/

Max. process+thread count
562 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5258/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
40m 58s

trunk passed

+1 :green_heart:
compile
1m 36s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 37s

trunk passed

+1 :green_heart:
mvnsite
0m 46s

trunk passed

+1 :green_heart:
javadoc
0m 46s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 33s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
1m 35s

trunk passed

+1 :green_heart:
shadedclient
24m  5s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 37s

the patch passed

+1 :green_heart:
compile
1m 24s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
1m 24s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 25s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: The patch generated 36 new + 184 unchanged - 1 fixed = 220 total (was 185)

+1 :green_heart:
mvnsite
0m 38s

the patch passed

+1 :green_heart:
javadoc
0m 31s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 27s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
1m 28s

the patch passed

+1 :green_heart:
shadedclient
23m 10s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
26m 39s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

130m 42s

Reason
Tests

Failed junit tests
hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5258/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5258

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux b51bb4bd1793 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3d877b8016ff192a135eb8142338a96d7e0a0cc8

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5258/4/testReport/

Max. process+thread count
603 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5258/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


unable to resolve the dependency in vagrant 2.2.9

After updating to Vagrant 2.2.9 the plugin doesn't work.
Error message given during initialization: Unable to resolve dependency: user requested 'vagrant-disksize (= 0.1.3)'

It works just okay.
$ vagrant --version
Vagrant 2.2.9
$ VBoxManage --version
6.0.22r137980

Vagrantfile (partial, of course):
config.vagrant.plugins = ['vagrant-disksize']
config.disksize.size = '50GB'

$ vagrant up
Vagrant has detected project local plugins configured for this
project which are not installed.

  vagrant-disksize
Install local plugins (Y/N) [N]: y
Installing the 'vagrant-disksize' plugin. This can take a few minutes...
Fetching vagrant-disksize-0.1.3.gem
Installed the plugin 'vagrant-disksize (0.1.3)'!

Vagrant has completed installing local plugins for the current Vagrant
project directory. Please run the requested command again.

During the next vagrant up the disk was changed to VDI and resized:
Resized disk: old 10240 MB, req 51200 MB, new 51200 MB


Update examples

Palo Alto Networks Cloud Python SDK version: v1.4.0
Python version: 2.7, 3.5+
Operating System: any

Description
Update all existing examples and add examples as needed.

Example(s) updated for new 2.0 API


Update License for One Dark Theme from 2016 to 2019

Requirements for Contributing a Performance Improvement

Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
The pull request must only affect performance of existing functionality. To contribute other changes, you must use a different template. You can see all templates at https://github.com/atom/.github/tree/master/.github/PULL_REQUEST_TEMPLATE.
After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see https://github.com/atom/.github/tree/master/CONTRIBUTING.md#pull-requests.

Description of the Change
I updated the license for the One Dark theme from 2016 to 2019, because it's no longer 2016 and it's best policy to keep license up to date.
Quantitative Performance Benefits
Quantitatively, an updated license will increase performance by allowing other people perform useful tasks instead of worrying about outdated license.
Possible Drawbacks
This change might be a hassle and a waste of time of those who review and approve it.
Verification Process
It's a single character change in a file that does not affect the application's behavior.
Applicable Issues
N/A
Release Notes
The Atom One Dark theme licence was updated for 2019.

View rendered packages/one-dark-syntax/LICENSE.md

In a copyright you always specify the first year of publication, not the most recent year.


Create spec and reconciler for awss3 source

Won't do, there is no S3 source in the awss3 directory.


advanced translation pipeline

Hi @SchrodingersGat I thought a bit about how one could streamline the translation pipeline - especially for people who are not familiar with Djangos language system. An OS-project I love and use (Snipe-It) uses crowdin. I setup a test check it out here which watches the django.po file in my master and pushes all changed translation into a translation branch. Coupled with an action that regenerates the .po with each commit that could greatly automate the whole translation system and maybe enable more languages.
Crowdin is free with advanced features for OS.

I found a flow diagram I made for another thing, shows how the process / dataflow could work.

Interesting, I had not heard of this before. I've been wondering for a while how to make the translation process easier for anyone to contribute.
Are there any examples of using crowdin with a django project in particular? I'm trying to find some django specific examples without much luck so far.

I do not know of any examples with Django but I configured the shown configuration to try it out in my fork.

@SchrodingersGat the crowdin project with CI enabled is hosted here.
The github action creates the current po files and pushes them to the base branch.
The crowdin translations are pushed every 10 minutes to this branch

@matmair I've had a look at the crowdin page, it looks really good - I'd like to make this the "official" way to do translations :)
How do we proceed from here?
FYI the github action link you posted doesn't work

https://github.com/inventree/InvenTree/pull/1498 adds some more locale entrypoints too

And looks like crowdin supports translation status badges we can include in README.md
https://store.crowdin.com/products/bds

@matmair I've had a look at the crowdin page, it looks really good - I'd like to make this the "official" way to do translations :)
How do we proceed from here?
FYI the github action link you posted doesn't work

@SchrodingersGat  Cool ;-) I restructured the action and everything else a few days ago to have a CI - example.
I deleted the example-project so the 'inventree' name and URL are free now. I have a full and working CI-example here, if you provide me an e-mail (twitter DM for example) I can make you a manager to have a look around and see how I configured everything.

I just checked out bds, seems to be cool - I added an exampe here

@matmair can you add me as a maintainer on your example project? My crowdin username is @SchrodingersGat
Cheers

@SchrodingersGat I am trying for a few minutes now, seems like a free user (without open source project) can only have one manager.

Interesting that I could be made manager on your project.
I just looked how the 'official' project is set up now, will submit PR to crowdin-file to fix the multiple files showing up. It is all controlled by the file.

@SchrodingersGat I see you fixed it already 👍

Trail and error :p

I think I can happily close this now ;-) thank you @SchrodingersGat for picking this up, will reduce the manual work for translating a lot.

@matmair So if I understand correctly, every new PR will create a push to Crowdin to process the translation, then create new GitHub PR with the updated translation files? No need to run inv translate anymore?

@eeintech at the moment yes. If it works, I will create a PR to only run when pushed to master - to reduce unnecessary work for ppl. translating.
Short version: no more inv translate + semi-automated translations -> better quality.

Cool, I'm trying out Crowdin's editor but I don't know how to push suggested translations... Do you need write access to the project? Where is the "send for review" button or similar?

There are 2 steps:

you translate the string and the indicator switches from red to green
you approve or get aproved the string (with the checkmark-symbol)

crowdin checks every few minutes for new aproved strings or changes in the source-translation-files and pushes or pulls them.

Oh I see the server is polling the suggestion is you go, I thought you would have to push yourself.
I started playing with it, it seems that I cannot approve but only suggest, so I don't have a checkmark symbol.
The only indicator is the item turns green:

It's a neat system overall! Well done with that implementation!
My french (native language) is so rusty haha

@eeintech if you start translating to french I would suggest to translate the core-name like below. You can insert them on the right sight of the translator view. Those entries are used in the suggestions so you can make translating much faster.

Englisch
Deutsch

allocation
Zuweisung

Zuordnung

Barcode
Barcode

Strichcode

batch code
Losnummer

Chargennummer

BOM
BOM

Stückliste

BOM Item
BOM-Eintrag

Stücklistenposition

BOM-Position

build order
Bauauftrag

Bau

build output
Bau

Bau-Ausgabe

Endprodukt

IPN
IPN

location
Standort

Lagerort

overage
Überschuss

parameter
Parameter

part
Teil

purchase order
Bestellung

EK-Bestellung

report
Report

Bericht

revision
Revision

sales order
Bestellung

Auftrag

VK-Auftrag

serial number
Seriennummer

stock
Lagerbestand

Bestand

Lager

stock expiry
Lager Ablaufdatum

stock item
Lagerobjekt

Bestandsobjekte

stocktake
Inventur

Bestandsaufnahme

Bestandsänderung

supplier
Zulieferer

Oh I see the server is polling the suggestion as you go, I thought you would have to push yourself.
I started playing with it, it seems that I cannot approve but only suggest, so I don't have a checkmark symbol.
The only indicator is the item turns green:

I just checked; you are right. I gave you permissions to approve French.

It is a neat system overall! Well done with that implementation!

Another project in which I submit a lot of translations uses this system, it opens up translating to non-programmers as it lowers the bar.

My french (native language) is so rusty haha

I know that feeling. Sometimes I wonder if my German or English is worse. But to be fair there is quite a dialect in my area so most Germans do not understand me either.

@matmair Ummm I see, it is less intuitive to start there because the editor is pulling random (?) phrases in the left panel, it would be nice if it started with those "core" translation at the top of the list. Any way those words can be marked as "core" and Crowdin picked them up first?

This is seriously addictive and takes me at least 2 min per word to be certain that's the way it would be used in French :sweat_smile:
Question: is it case sensitive?
For instance if I translate "Part" with "composant", will it automatically make the first letter uppercase?

if you start translating to french I would suggest to translate the core-name like below. You can insert them on the right sight of the translator view. Those entries are used in the suggestions so you can make translating much faster.

@matmair Ummm I see, it is less intuitive to start there because the editor is pulling random (?) phrases in the left panel, it would be nice if it started with those "core" translation at the top of the list. Any way those words can be marked as "core" and Crowdin picked them up first?

Well the phrases it shows you are somewhat sorted - it shows you stuff it can use for suggestions later. I do not know how one could highlight translations but I will look into it.

Question: is it case sensitive?
For instance if I translate "Part" with "composant", will it automatically make the first letter uppercase?
EDIT: I am actually looking for the correct translation of "Part" because there is no generic word in french that I know of...

It uses the strings the way you input them. The QA looks out if the first and last letter match the source string.
Finding good translations is hard.

Understood.
Other few questions:

what does Crowdin do with "suggested" translation? Where can I review and approve of all it at once?
what does it do with "approved" translation (push to InvenTree branch l10n)?

On the project-site you can select a language and then 'Proofread' to approve suggested strings

Approved translations are pushed to l10n, from where they then will need to be manually pulled. That can be done for all languages in one operation.


Changing the name of the triggered pipeline will break the trigger

Describe the issue
Changing the name of the triggered pipeline will break the trigger
**Extension **

Extension: Trigger Azure DevOps Pipeline
Version: Seen with both v 1.* and 2.*

To Reproduce
Steps to reproduce the behavior:

Setup a working build pipeline trigger as normal.
Verify it works.
Rename the triggered pipeline.
Rerun the triggering pipeline - it will fail with a "Problem occured while getting the build" error.

Expected behavior
A clear and concise description of what you expected to happen.
Situation (please complete the following information):

Agent type:  windows-latest
Autentication: PAT
Extension Version: As above.

Have obviously fixed this myself by updating the child pipeline in the task afterwards, but thought you should know :) Not sure how this works under the hood, but the definition id doesn't change on rename.

Fix is in the release pipeline. It will use the Id by default


No translation found

Debug
[STDERR: alfred.workflow.input.scriptfilter] ./translate: line 2: warning: setlocale: LC_ALL: cannot change locale (en_GB@currency=UAH.UTF-8): No such file or directory
[INFO: alfred.workflow.input.scriptfilter]

No translation found!
icon.png
”h” in English.

[STDERR: alfred.workflow.input.scriptfilter] ./translate: line 2: warning: setlocale: LC_ALL: cannot change locale (en_GB@currency=UAH.UTF-8): No such file or directory
[INFO: alfred.workflow.input.scriptfilter]

No translation found!
icon.png
”h” in German.

[STDERR: alfred.workflow.input.scriptfilter] ./translate: line 2: warning: setlocale: LC_ALL: cannot change locale (en_GB@currency=UAH.UTF-8): No such file or directory
[INFO: alfred.workflow.input.scriptfilter]

No translation found!
icon.png
”h” in French.

[STDERR: alfred.workflow.input.scriptfilter] ./translate: line 2: warning: setlocale: LC_ALL: cannot change locale (en_GB@currency=UAH.UTF-8): No such file or directory
[INFO: alfred.workflow.input.scriptfilter]

No translation found!
icon.png
”hello” in English.

[STDERR: alfred.workflow.input.scriptfilter] ./translate: line 2: warning: setlocale: LC_ALL: cannot change locale (en_GB@currency=UAH.UTF-8): No such file or directory
[INFO: alfred.workflow.input.scriptfilter]

No translation found!
icon.png
”hello” in German.

[STDERR: alfred.workflow.input.scriptfilter] ./translate: line 2: warning: setlocale: LC_ALL: cannot change locale (en_GB@currency=UAH.UTF-8): No such file or directory
[INFO: alfred.workflow.input.scriptfilter]

No translation found!
icon.png
”hello” in French.

It seems the script parses an odd value of<EMAIL_ADDRESS>out of your locale settings, causing an invalid script locale to be set and the whole thing to fail. I’m on holiday right now and have a rather busy few weeks coming up after that, but I’ll get back to you as soon as I can.

Thank you!

Thank you!
FYI, i get rid of that message with a locale fail but still negative result
Starting debug for 'Google Translate'
[INFO: alfred.workflow.input.scriptfilter]
No translation found!
icon.png
”h” in German.
[INFO: alfred.workflow.input.scriptfilter]
No translation found!
icon.png
”h” in English.
[INFO: alfred.workflow.input.scriptfilter]
No translation found!
icon.png
”h” in French.
[INFO: alfred.workflow.input.scriptfilter]
No translation found!
icon.png
”hi” in German.
[INFO: alfred.workflow.input.scriptfilter]
No translation found!
icon.png
”hi” in French.
[INFO: alfred.workflow.input.scriptfilter]
No translation found!
icon.png
”hi” in English.

Thank you!
FYI, i get rid of that message with a locale fail but still negative result
Starting debug for 'Google Translate'
[INFO: alfred.workflow.input.scriptfilter]

No translation found!
icon.png
”h” in German.

[INFO: alfred.workflow.input.scriptfilter]

No translation found!
icon.png
”h” in English.

[INFO: alfred.workflow.input.scriptfilter]

No translation found!
icon.png
”h” in French.

[INFO: alfred.workflow.input.scriptfilter]

No translation found!
icon.png
”hi” in German.

[INFO: alfred.workflow.input.scriptfilter]

No translation found!
icon.png
”hi” in French.

[INFO: alfred.workflow.input.scriptfilter]

No translation found!
icon.png
”hi” in English.

[INFO: alfred.workflow.input.scriptfilter]

No translation found!
icon.png
”r” in English.

[INFO: alfred.workflow.input.scriptfilter]

No translation found!
icon.png
”r” in German.

[INFO: alfred.workflow.input.scriptfilter]

No translation found!
icon.png
”r” in French.

[INFO: alfred.workflow.input.scriptfilter]

No translation found!
icon.png
”rid ” in German.

[INFO: alfred.workflow.input.scriptfilter]

No translation found!
icon.png
”rid ” in English.

[INFO: alfred.workflow.input.scriptfilter]

No translation found!
icon.png
”rid ” in French.

Thanks!
FYI, I get rid of previous message but still result is negative
[INFO: alfred.workflow.input.scriptfilter]

No translation found!
icon.png
”h” in French.

[INFO: alfred.workflow.input.scriptfilter]

No translation found!
icon.png
”h” in English.

[INFO: alfred.workflow.input.scriptfilter]

No translation found!
icon.png
”h” in German.

[INFO: alfred.workflow.input.scriptfilter]

No translation found!
icon.png
”hi” in French.

[INFO: alfred.workflow.input.scriptfilter]

No translation found!
icon.png
”hi” in English.

[INFO: alfred.workflow.input.scriptfilter]

No translation found!
icon.png
”hi” in German.

I figure out that in the morning it works for a couple of time and after something blocking the IP address. Then I changing IP address (VPN let's say) it will work again for a couple of times and after another IP will be blocked.

That sound as if Google has started rate limiting requests. Newer versions of Alfred have an option to only start a query when typing ends (in the workflow settings); could you check what happens when you activate that on a “clean” IP?

I tried it, still the same. Limit is about 5 to 10 request from one IP (I tried a couple of IP's), also I tried to remove one language and the number of available request increased.

@kopischke, any updates about what could be the issue? I'm having the same problem as @malinni4 with exact repro steps.
Thanks!

Sorry for the inconvenience, but RL is keeping me away from my Mac for a while, so I have no way to debug this. I’ll look into this as soon as I can get back to my machine.

That's not a problem! Just wanted to know if there were any updates.
Thanks again for taking a look and no rush at all!
On Wed, Oct 28, 2015, 19:27 Martin Kopischke<EMAIL_ADDRESS>wrote:

Sorry for the inconvenience, but RL is keeping me away from my Mac for a
while, so I have no way to debug this. I’ll look into this as soon as I can
get back to my machine.
—
Reply to this email directly or view it on GitHub
https://github.com/kopischke/alfred-workflows/issues/4#issuecomment-151942373
.

--

Arturo

Hi and good day,
Same problem here - on Yosemite -
I see "Translate to German" f ex then:
"No translation found."
/
with best regards,
Omar KN
Stockholm, Sweden

Thanks a lot for reporting, and apologies for not reacting, but the workflows published here are, as far as I am concerned, deprecated: I haven’t been using Alfred since macOS revamped Spotlight, which is good enough for me, especially as my main work machine is an iPad by now. I will archive the repo, no fixes planned.


bump Rust

My hypothesis is that this will replicate https://travis-ci.com/rust-lang/miri/jobs/220221687 (so we know which commit range caused it).

The regression landed with https://github.com/rust-lang/rust/pull/63043; the likely cause is https://github.com/rust-lang/rust/pull/62982.

Dang, the log is too long for Travis... but then how can we debug this? :/

My best guess so far is that it has something to do with the find_foreign_static machine hook. That one emulates the existence of __cxa_thread_atexit_impl and maybe using the type there is not the right call?

Relevant part of the log:
 INFO 2019-07-28T10:50:36Z: rustc_mir::interpret::eval_context: CONTINUING(17) getrandom::macos::fetch_getentropy
 INFO 2019-07-28T10:50:36Z: rustc_mir::interpret::step: // bb1
 INFO 2019-07-28T10:50:36Z: rustc_mir::interpret::step: StorageDead(_6)
 INFO 2019-07-28T10:50:36Z: rustc_mir::interpret::step: _4 = move _5 as *const i8 (Misc)
 INFO 2019-07-28T10:50:36Z: rustc_mir::interpret::step: _3 = _4
 INFO 2019-07-28T10:50:36Z: rustc_mir::interpret::step: StorageDead(_5)
 INFO 2019-07-28T10:50:36Z: rustc_mir::interpret::step: _2 = const libc::unix::dlsym(const libc::unix::bsd::RTLD_DEFAULT, move _3) -> bb2
 INFO 2019-07-28T10:50:36Z: rustc_mir::interpret::eval_context: ENTERING(0) libc::unix::bsd::RTLD_DEFAULT
 INFO 2019-07-28T10:50:36Z: rustc_mir::interpret::step: _0 = const -2isize as *mut std::ffi::c_void (Misc)
 INFO 2019-07-28T10:50:36Z: rustc_mir::interpret::step: return
 INFO 2019-07-28T10:50:36Z: rustc_mir::interpret::eval_context: LEAVING(0) libc::unix::bsd::RTLD_DEFAULT
 INFO 2019-07-28T10:50:36Z: rustc_mir::interpret::step: // bb2
 INFO 2019-07-28T10:50:36Z: rustc_mir::interpret::step: StorageDead(_3)
 INFO 2019-07-28T10:50:36Z: rustc_mir::interpret::step: StorageDead(_4)
 INFO 2019-07-28T10:50:36Z: rustc_mir::interpret::step: StorageLive(_7)
 INFO 2019-07-28T10:50:36Z: rustc_mir::interpret::step: _7 = _2
 INFO 2019-07-28T10:50:36Z: rustc_mir::interpret::step: _0 = const std::mem::transmute::<*mut std::ffi::c_void, std::option::Option<unsafe extern "C" fn(*mut u8, usize) -> i32>>(move _7) -> bb3

Fix submitted at https://github.com/rust-lang/rust/pull/63076

Why.. did GitHub do that?!?

With the fix landed in rustc, this should work now.
@bors r+

:pushpin: Commit 784ad6953edf5a82382e74223225382cb9ed12c4 has been approved by RalfJung

:hourglass: Testing commit 784ad6953edf5a82382e74223225382cb9ed12c4 with merge a254eaa4f4c75d4b8c3ce4f975c15ae78f5b277d...

@bors r+ retry

:pushpin: Commit 87f20fede528a2a99c06e6aae480adac91f5ecc2 has been approved by RalfJung

:hourglass: Testing commit 87f20fede528a2a99c06e6aae480adac91f5ecc2 with merge 656066376d82f3c4408b6fed66244b28878a04b9...

:broken_heart: Test failed - checks-travis

Why... did GitHub do that?!?

Because of the Fixes a bug in the other PR's description. The a bug is a link to this PR, so fixes closes it. If you hover over the Fixes, it will say This pull request closes pull request #862.

Looks spurious.
@bors retry

:hourglass: Testing commit 87f20fede528a2a99c06e6aae480adac91f5ecc2 with merge 5aa730803ebfa840507be4f79ab6db6ab9a97ac0...

:sunny: Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing 5aa730803ebfa840507be4f79ab6db6ab9a97ac0 to master...


thread/lock mechanism appeared bugged in the console, indeed!

I was trying lock mechanism through the following code:
from threading import Thread,Lock
from time import sleep

lock=Lock()

def mythread(arg,name):
  for i in range(arg):
    with lock:
      print(name,'i  ----> ',i)
    sleep(1)

def test():
  thread1 = Thread(target = mythread, args = (5,'thread1'))
  thread1.start()
  thread2 = Thread(target = mythread, args = (5,'thread2'))
  thread2.start()
  thread1.join()
  thread2.join()

test()

With a possible output (completely wrong) in the console
thread1 i  ----> thread2  0i  ---->
 0
thread2 thread1i  ---->   i  ----> 1
1
thread2thread1  i  ----> i  ---->   22

thread2 thread1i  ---->   i  ----> 3
3
thread2 i  ---->  4
thread1 i  ---->  4

I expected nice print separation between the 2 threads (no overlap) in the console. But instead the print statements are scrambled. Strangely it seems to be due to spyder, as in a python or ipython consoles it works properly.
Any hint on this very strange behavior?
Last everything (win10), except python 3.5.3.

It is the qt-console. I will submit there.

Thanks!


Update the nightly build schedule to accommodate more geos

In the last hours of a typical work day in Canada, all the test machines are in use and there are none available for use for running Grinders and development tasks.
This issue proposes looking at the build/test pipeline schedule and shifting it slightly to accommodate the teams based in EST and Mountain time (in Canada).
Looking here: https://ci.adoptopenjdk.net/view/Build and Test Pipeline Calendar/#date=2022-03-09|view=week-view, it seems it may be possible to shift nightlies back and accommodate both teams in Canada and in UK/Europe.

The schedules are set in the pipelines/jobs/configurations jdkXX.groovy files, such as: https://github.com/adoptium/ci-jenkins-pipelines/blob/master/pipelines/jobs/configurations/jdk17u.groovy#L46-L49.  We should discuss options for improving the schedule.

Moving to tagged builds instead of nightly so this is no longer needed.


Release arrow-rs / parquet version 52.0.0

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
50.1.0 https://github.com/apache/arrow-rs/issues/5453 was released about 2 months ago: https://crates.io/crates/arrow/51.0.0 (March 18, 2024)
Describe the solution you'd like
A new release.
Describe alternatives you've considered

Additional context
Suggested content for the release:

[ ] https://github.com/apache/arrow-rs/issues/5654

Hi @tustvold, could we consider to prioritize this?

(I can handle the release mechanics when we decide it is time)

I think https://github.com/apache/arrow-rs/issues/5654 and getting the various view arrays to a somewhat stable state, e.g. if we do decide to add a view abstraction or similar.
I intend to cut the release towards the end of May as a stepping stone to the 3 month breaking release cadence that people are asking for.

I see -- so perhaps we release 52 at the end of may and then target 52.1.0 in June and 52.2.0 in July and then 53.0.0  (next breaking API) release in August 🤔

I'm loathe to commit to a rigid cadence, there isn't much point going through the rigmarole if not much has changed, but I think we can commit to the next breaking release afterwards being no earlier than August

I'm loathe to commit to a rigid cadence, there isn't much point going through the rigmarole if not much has changed, but I think we can commit to the next breaking release afterwards being no earlier than August

The reason to have a regular cadence is so that we don't hold up releasing things like bug fixes . I agree it is overhead on maintainers

I filed https://github.com/apache/arrow-rs/pull/5737# to try and document what the current thinking for releases is. Feedback welcome.

Hi @alamb, I'd like to include https://github.com/apache/arrow-rs/pull/5753 in our release train for version 52.

Thanks @Xuanwo  -- added to the list above. 🚋

I think getting a resolution / fix on https://github.com/apache/arrow-rs/issues/5731 would be valuable for this release.

Added to the list @matthewmturner  -- thank you
Are you driving the resolution on https://github.com/apache/arrow-rs/issues/5731 ?

@alamb i am happy to, i will review and propose next steps

Definitely not a necessity, but sorting out null handling for nested comparison is something that may need breaking changes and would therefore be something we may want to include in this release - https://github.com/apache/arrow-rs/issues/5426
I can try to find some time to look into this, I know I keep promising this, but it keeps getting ousted by more urgent things :sweat_smile:

Quick update:

I believe we have the last PR we are waiting for https://github.com/apache/arrow-rs/pull/5817 (which is approved and I expect it to merge very soon)
@tustvold plans to make the release candidate next week, so we are looking like we'll have the release on crates.io at the end of next week (June 6)

I think we should at least try to get https://github.com/apache/arrow-rs/issues/5827 and #TBD in as well, now that we're not able to make breaking changes as frequently

I think we should at least try to get #5827 and #5777 in as well, now that we're not able to make breaking changes as frequently

I think this release has waited long enough already. There is too much in this release already (and too many people waiting on it)   (like the object store update, and now the datafusion upgrade). We need a new major release asap
If there is critical demand for new breaking features before the end of the summer we can handle them separately (like consider more breaking releases) but I don't think we should hold this release any longer

It would be great to include https://github.com/apache/arrow-rs/pull/5832 as a supplement for #5769

I would observe that it hasn't been 3 months since the last breaking release yet (March 18th), and people are waiting on breaking changes. This is ultimately what people asked for 😅
I'll cut the release today, but I suspect the release cadence may need review in a month or so's time

Release thread: https://lists.apache.org/thread/vmo9dt0s9hx73o09vb09ztyl369r1gks

Filed https://github.com/apache/arrow-rs/issues/5905 to track next release


Property best_iteration not reflecting the best iteration when trained without early stopping

I think I found what I consider to be an issue related to the best_iteration property of a fitted model. When training a model without early stopping, the best_iteration property gets filled with the last iteration number, even though it may not be the best iteration. This can be misleading, as it implies that the last iteration was the best iteration, even when that's not the case.
To find the true best iteration, one can perform an argmin on the evals_result list of RMSEs after the training is complete. This will reveal that there are better iterations than the last one - which is the one stored in the best_iteration property. The workaround for this issue is to use early_stopping_rounds with a value greater than or equal to num_estimators.
One potential improvement to this issue would be to make the best_iteration property always have the iteration number where the eval_metric was the best. This would make the property more informative and accurate and would help avoid confusion and errors caused by relying on the last iteration number as the best iteration.
Also, docs say the best_iteration property only has a value when early stopping is active, which is not true.

Thank you for raising the issue. Let me take a closer look into it.


Insert spaces when user enters tabs

As a configurable option, obviously.

Right now it uses CodeMirror's default of 2 spaces, let me know if this works for you.

Yep, it works great, but the option wasn't very easy to find.


Emit llvm.dbg.declare intrisics immediately after the described alloca.

This cleanup change doesn't change the semantics, but it makes the
resulting IR much easier to read and debug.

@swift-ci please test

@swift-ci please test and merge

@swift-ci test and merge


feat: optimize pushbytes by removing unreachable minimal check

In rust-bitcoin, read_scriptint checks NonMinimalPush, which makes an additional minimal check needless and PushBytes inefficient.

We should add a fuzztest which tries to decode scripts both with master and 0.12.
Can wait til after #780 gets in, since that already includes a similar fuzztest for parsing expression strings.

Can wait til after https://github.com/rust-bitcoin/rust-miniscript/pull/780 gets in, since that already includes a similar fuzztest for parsing expression strings.

Working on it this week

I'm gonna go ahead and merge this. Will add the fuzztest in a later PR.


Assigning a curve to a uniform causes an error spam in the console until the scene is reloaded

Godot version
v4.0.dev.custom_build [087ec7b8a]
System information
Linux Arch, Radeon RX 590
Issue description
Assigning a curve texture to a shader material causes the console to fill with errors
niforms were never supplied for set (3) at the time of drawing, which are required by the pipeline
  Uniforms supplied for set (3):
  Set: 3 Binding: 0 Type: UniformBuffer Length: 128
  Set: 3 Binding: 1 Type: Texture Length: 1
  Set: 3 Binding: 2 Type: Texture Length: 1
  Set: 3 Binding: 3 Type: Texture Length: 1
  are not the same format as required by the pipeline shader. Pipeline shader requires the following bindings:
  Set: 0 Binding: 1 Type: Sampler Length: 12
  Set: 0 Binding: 2 Type: Sampler Length: 1
  Set: 0 Binding: 3 Type: Sampler Length: 1
  Set: 0 Binding: 4 Type: Sampler Length: 1
  Set: 0 Binding: 5 Type: StorageBuffer Length: 0
  Set: 0 Binding: 6 Type: StorageBuffer Length: 0
  Set: 0 Binding: 7 Type: StorageBuffer Length: 0
  Set: 0 Binding: 8 Type: UniformBuffer Length: 4224
  Set: 0 Binding: 9 Type: StorageBuffer Length: 0
  Set: 0 Binding: 10 Type: StorageBuffer Length: 0
  Set: 0 Binding: 11 Type: Texture Length: 1
  Set: 0 Binding: 12 Type: Texture Length: 1
  Set: 0 Binding: 13 Type: StorageBuffer Length: 0
  Set: 0 Binding: 14 Type: StorageBuffer Length: 0
  Set: 0 Binding: 15 Type: UniformBuffer Length: 368
  Set: 1 Binding: 0 Type: UniformBuffer Length: 2656
  Set: 1 Binding: 1 Type: StorageBuffer Length: 0
  Set: 1 Binding: 2 Type: Texture Length: 1
  Set: 1 Binding: 3 Type: Texture Length: 1
  Set: 1 Binding: 4 Type: Texture Length: 1
  Set: 1 Binding: 5 Type: Texture Length: 1
  Set: 1 Binding: 6 Type: Texture Length: 8
  Set: 1 Binding: 7 Type: Texture Length: 8
  Set: 1 Binding: 8 Type: StorageBuffer Length: 0
  Set: 1 Binding: 9 Type: Texture Length: 1
  Set: 1 Binding: 10 Type: Texture Length: 1
  Set: 1 Binding: 11 Type: Texture Length: 1
  Set: 1 Binding: 12 Type: Texture Length: 1
  Set: 1 Binding: 13 Type: Texture Length: 1
  Set: 1 Binding: 14 Type: Texture Length: 1
  Set: 1 Binding: 15 Type: Texture Length: 1
  Set: 1 Binding: 16 Type: Texture Length: 1
  Set: 1 Binding: 17 Type: UniformBuffer Length: 896
  Set: 1 Binding: 18 Type: Texture Length: 1
  Set: 2 Binding: 0 Type: StorageBuffer Length: 0
  Set: 3 Binding: 1 Type: Texture Length: 1
  Set: 3 Binding: 2 Type: Texture Length: 1
  Uniforms were never supplied for set (3) a

Steps to reproduce
Open MRP, assign a curvetexture and a curve to meshinstance, observe console
Minimal reproduction project
curvetextureerrorspam.zip

This issue has been fixed for awhile, but I don't know exactly when


Code comments needed for asfdata.py

As the subject says: the file has almost no comments.

Many comments have been added.


build(deps): update package dependencies

Signed-off-by: fsl<EMAIL_ADDRESS>fix github.com/docker/distribution vuln to 2.8.1 reference link https://github.com/advisories/GHSA-qq97-vm5h-rrhg
fix github.com/opencontainers/image-spec vuln to 1.0.2 reference link https://github.com/advisories/GHSA-77vh-xpmg-72qh

/test

CI hit unrelated failure https://github.com/cilium/cilium/issues/23176 . No need to block merging on that. Thanks for the fix!


When will keras support float16 for BatchNorm layer?

I've encountered this issue https://github.com/keras-team/keras/issues/9582(url) and it still hasn't solved the problem.. I'm trying to utilize the GPU with floatx=float16 but fail to use batch normalization layer.
from keras.models import Sequential
from keras.layers import Conv2D, BatchNormalization
model = Sequential()
model.add(Conv2D(32,3, input_shape = (224,224,3)))
model.add(BatchNormalization())

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-2-f051fa3daa13> in <module>
      3 model = Sequential()
      4 model.add(Conv2D(32,3, input_shape = (224,224,3)))
----> 5 model.add(BatchNormalization())

/usr/local/lib/python3.5/dist-packages/keras/engine/sequential.py in add(self, layer)
    179                 self.inputs = network.get_source_inputs(self.outputs[0])
    180         elif self.outputs:
--> 181             output_tensor = layer(self.outputs[0])
    182             if isinstance(output_tensor, list):
    183                 raise TypeError('All layers in a Sequential model '

/usr/local/lib/python3.5/dist-packages/keras/engine/base_layer.py in __call__(self, inputs, **kwargs)
    455             # Actually call the layer,
    456             # collecting output(s), mask(s), and shape(s).
--> 457             output = self.call(inputs, **kwargs)
    458             output_mask = self.compute_mask(inputs, previous_mask)
    459

/usr/local/lib/python3.5/dist-packages/keras/layers/normalization.py in call(self, inputs, training)
    183         normed_training, mean, variance = K.normalize_batch_in_training(
    184             inputs, self.gamma, self.beta, reduction_axes,
--> 185             epsilon=self.epsilon)
    186
    187         if K.backend() != 'cntk':

/usr/local/lib/python3.5/dist-packages/keras/backend/tensorflow_backend.py in normalize_batch_in_training(x, gamma, beta, reduction_axes, epsilon)
   1862         return _fused_normalize_batch_in_training(
   1863             x, gamma, beta, reduction_axes,
-> 1864             epsilon=epsilon)
   1865     else:
   1866         if sorted(reduction_axes) == list(range(ndim(x)))[:-1]:

/usr/local/lib/python3.5/dist-packages/keras/backend/tensorflow_backend.py in _fused_normalize_batch_in_training(x, gamma, beta, reduction_axes, epsilon)
   1837         beta,
   1838         epsilon=epsilon,
-> 1839         data_format=tf_data_format)
   1840
   1841

/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/nn_impl.py in fused_batch_norm(x, scale, offset, mean, variance, epsilon, data_format, is_training, name)
    907       data_format=data_format,
    908       is_training=is_training,
--> 909       name=name)
    910   return y, batch_mean, batch_var
    911

/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/gen_nn_ops.py in fused_batch_norm_v2(x, scale, offset, mean, variance, epsilon, data_format, is_training, name)
   3835         "FusedBatchNormV2", x=x, scale=scale, offset=offset, mean=mean,
   3836         variance=variance, epsilon=epsilon, data_format=data_format,
-> 3837         is_training=is_training, name=name)
   3838     _result = _op.outputs[:]
   3839     _inputs_flat = _op.inputs

/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/op_def_library.py in _apply_op_helper(self, op_type_name, name, **keywords)
    607               _SatisfiesTypeConstraint(base_type,
    608                                        _Attr(op_def, input_arg.type_attr),
--> 609                                        param_name=input_name)
    610             attrs[input_arg.type_attr] = attr_value
    611             inferred_from[input_arg.type_attr] = input_name

/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/op_def_library.py in _SatisfiesTypeConstraint(dtype, attr_def, param_name)
     58           "allowed values: %s" %
     59           (param_name, dtypes.as_dtype(dtype).name,
---> 60            ", ".join(dtypes.as_dtype(x).name for x in allowed_list)))
     61
     62

TypeError: Value passed to parameter 'scale' has DataType float16 not in list of allowed values: float32

I've created this layer:
https://github.com/Golbstein/KerasExtras/blob/master/BN16.py

I've created this layer:
https://github.com/Golbstein/KerasExtras/blob/master/BN16.py

I dont see how different from Keras BN ?

This is still an issue. Any solution?

Hi everybody,
I want to do the implementation from tensorflow. That means, instead of import keras directly, do it as import tensorflow.keras
I changed the code as follows:
from tensorflow.keras.layers import BatchNormalization, Layer, InputSpec
from tensorflow.keras import initializers, regularizers, constraints
from tensorflow.keras import backend as K
from tensorflow.python.keras.backend import _regular_normalize_batch_in_training
import tensorflow as tf

And I had this error:
FailedPreconditionError: 2 root error(s) found.
  (0) Failed precondition: Attempting to use uninitialized value batch_normalization_f16/moving_mean/biased
	 [[{{node batch_normalization_f16/moving_mean/biased/read}}]]
	 [[metrics/categorical_accuracy/Identity/_681]]
  (1) Failed precondition: Attempting to use uninitialized value batch_normalization_f16/moving_mean/biased
	 [[{{node batch_normalization_f16/moving_mean/biased/read}}]]
0 successful operations.
0 derived errors ignored.

Any idea what is going on? Thanks in advance!

@janaal1 Thanks for the issue! Can you please open this on the main tensorflow github?


(MODULES-7467) Update apt to support Ubuntu 18.04

@david22swan can you fix the commit history for this, the ticket mentioned is for vcrepo


Point mbta.ninja to heroku deployment at mbta-ninja.herokuapp.com

@davidlago DNS setup is done, if you add www.mbta.ninja and mbta.ninja to valid domains on the Heroku side we should be good.

Done. Thanks @geoffreylitt!


Why not directly use the easily computable basis functions? in the question 566

I am currently researching the "nedelec element" for "nurbs versions" for IGA. I carefully read the answer to question #566 and noticed that the Ti matrix only exists in the calculation of shape functions for triangular or tetrahedral elements. Why don't we directly use the simple and easy to calculate basis functions, and why do we need to undergo a transformation。Is it because the basic function of this simple calculation does not meet this condition:f_j(φ_i)=δ_{i,j}?

Yes, we need basis functions on individual elements in the mesh that can be easily stitched together globally. This easy with the "nodal" basis {φ_i} while with the "easy to evaluate" basis {ψ_i} it is not.


Migrate flutter_driver to null safety

Currently, the driver directory (the stuff that runs on the host) is still opted out.
/cc @dnfield

I am working on this

I am working on this

Any updates...? It seems that it does not support this :(


Number of people with disabilities calculation

Create a calculation "number_disabled" in the population dataframe based on annual population estimates and the proportions calculated in the disability dataframe which is based on the 2011 data.

Due to merge of PR https://github.com/ONSdigital/SDG_11.2.1/pull/115 this can be closed.


NuScnens dataset splitting

Hello ~ Thank you for your work which has been very helpful to me! I would like to ask a question about data set splitting. I want to train the proposed network on both the training set and the validation set. But I noticed that the dataset created does not have the nuscenes_infos_trainval.pkl file. How can I do to perform the training on both training and validation sets?
I am looking forward to your reply. Good luck!

You may directly concatenate the lists in nuscenes_infos_train.pkl and nuscenes_infos_val.pkl to get the desired file. This is how we create trainval infos.

Loading these two files (nuscenes_infos_train.pkl & nuscenes_infos_val.pkl) generates two dictionaries. I wonder how to merge the two dictionaries properly. Can you release this part of the code for me? Thank you very much!


[Usage] KeyError: 'LlavaConfig' when evaluating with model_vqa.py

Describe the issue
Hi!  I'm attempting to re-train LLaVA on some of my own data but to start, I've just been training on the repo's data.  I've pretrained and finetuned (with lora) without trouble but when I attempt to evaluate my lora finetuned model, I run into some trouble.
python model_vqa.py --model-path checkpoints/llava-v1.5-13b-lora/ --question-file playground/data/coco 2014_val_qa_eval/qa90_questions.jsonl --image-folder playground/data/coco2014_val_qa_eval/val2014/ --answers-file my_answers.jsonl --model-base liuhaotian/llava-v1.5-13b-lora
Gives error:
/opt/conda/lib/python3.11/site-packages/bitsandbytes/cextension.py:34: UserWarning: The installed version of bitsandbytes was compiled without GPU support. 8-bit optimizers, 8-bit multiplication, and GPU quantization are unavailable.
warn("The installed version of bitsandbytes was compiled without GPU support. "
/opt/conda/lib/python3.11/site-packages/bitsandbytes/libbitsandbytes_cpu.so: undefined symbol: cadam32bit_grad_fp32
[2024-01-25 18:05:55,136] [INFO] [real_accelerator.py:110:get_accelerator] Setting ds_accelerator to cuda (auto detect)
model_path checkpoints/llava-v1.5-13b-lora/, model_name llava-v1.5-13b-lora, model_base liuhaotian/llava-v1.5-13b-lora
Traceback (most recent call last):
File "/mnt/ceph_rbd/LLaVA/model_vqa.py", line 114, in
eval_model(args)
File "/mnt/ceph_rbd/LLaVA/model_vqa.py", line 36, in eval_model
tokenizer, model, image_processor, context_len = load_pretrained_model(model_path, args.model_base, model_name)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/mnt/ceph_rbd/LLaVA/llava/model/builder.py", line 51, in load_pretrained_model
tokenizer = AutoTokenizer.from_pretrained(model_base, use_fast=False)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/conda/lib/python3.11/site-packages/transformers/models/auto/tokenization_auto.py", line 718, in from_pretrained
tokenizer_class_py, tokenizer_class_fast = TOKENIZER_MAPPING[type(config)]
~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
File "/opt/conda/lib/python3.11/site-packages/transformers/models/auto/auto_factory.py", line 663, in getitem
model_type = self._reverse_config_mapping[key.name]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
KeyError: 'LlavaConfig'
Do you have any suggestions on how to fix this error?

@emmaking-smith Did you manage to fix this?

has anyone fixed it?

Yes, I think the solution is as follows.  I found the answer from a previous question https://github.com/haotian-liu/LLaVA/issues/963.
They key here is that --model-base is NOT liuhaotian/llava-v1.5-13b-lora but lmsys/vicuna-13b-v1.5, which you can see is the case in the config.json file that's deposited after model training.


AttributeError: 'HttpRequestBot' object has no attribute '_pending_file_attachment_tasks'

description:
modified the example code from https://github.com/poe-platform/server-bot-quick-start/blob/main/langchain_openai.py and tried to use the openai.
my bot code:
class HttpRequestBot(fp.PoeBot):
    def __init__(self, OPENAI_API_KEY: str):
        self.chat_model = ChatOpenAI(openai_api_key=OPENAI_API_KEY)
    async def get_response(
        self, request: fp.QueryRequest
    ):
        messages = []
        for message in request.query:
            if message.role == "bot":
                messages.append(AIMessage(content=message.content))
            elif message.role == "system":
                messages.append(SystemMessage(content=message.content))
            elif message.role == "user":
                the_prompt = message.conten
                messages.append(HumanMessage(content=the_prompt))

        response = self.chat_model.invoke(messages).content
        if isinstance(response, str):
            yield fp.PartialResponse(text=response)
        else:
            yield fp.PartialResponse(text="There was an issue processing your query.")

setup code
REQUIREMENTS = ["fastapi-poe==0.0.36", "langchain==0.1.13", "openai==1.14.2","langchain-openai==0.1.0","langchain-core==0.1.33"]
image = Image.debian_slim().pip_install(*REQUIREMENTS)
stub = Stub("http-request")

@stub.function(image=image)
@asgi_app()
def fastapi_app():
    OPENAI_API_KEY = "MASKED"
    bot = HttpRequestBot(OPENAI_API_KEY=OPENAI_API_KEY)
    POE_ACCESS_KEY = "MASKED"
    # app = make_app(bot, access_key=POE_ACCESS_KEY)
    app = fp.make_app(bot, access_key=POE_ACCESS_KEY)
    return app

error message:
Error processing pending attachment requests Error processing pending attachment requests Traceback (most recent call last):   File "/usr/local/lib/python3.11/site-packages/fastapi_poe/base.py", line 407, in handle_query     await self._process_pending_attachment_requests(request.message_id)   File "/usr/local/lib/python3.11/site-packages/fastapi_poe/base.py", line 299, in _process_pending_attachment_requests     *self._pending_file_attachment_tasks.pop(message_id, [])      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AttributeError: 'HttpRequestBot' object has no attribute '_pending_file_attachment_tasks'    POST / -> 200 OK  (duration: 9.98 s, execution: 5.89 s)
my questions:
why AttributeError: 'HttpRequestBot' object has no attribute '_pending_file_attachment_tasks' occurs? Is there anything missed from the example code?
thanks

it worked well when removing the "def init(self, OPENAI_API_KEY: str):  self.chat_model = ChatOpenAI(openai_api_key=OPENAI_API_KEY)"
guess the example is incomplete or something missed. not a bug. closing the issue

it worked well when removing the "def init(self, OPENAI_API_KEY: str): self.chat_model = ChatOpenAI(openai_api_key=OPENAI_API_KEY)"
guess the example is incomplete or something missed. not a bug. closing the issue


Add multiple endpoints for GMC pipeline via gmcrouter

Description
Add multiple endpoints for GMC pipeline via gmcrouter.

Support new router verb dataprep for gmcrouter
Support multipart/form-data header for gmcrouter

Issues
https://github.com/opea-project/GenAIInfra/issues/168
https://github.com/opea-project/GenAIInfra/issues/207
https://github.com/opea-project/GenAIComps/issues/366
Type of change
List the type of change like below. Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would break existing design and interface)

Dependencies
n/a.
Tests
Query before Intel Gaudi information is injected:

Injecting the Intel Gaudi information

Query after Intel Gaudi information is injected:

A question: how we expose the /dataprep in router service's status?

For the curl (52) error, please wait for PR #249 to land in with the workaround to unblock the issue #258

Hi @mkbhanda and @irisdingbj, for multiple dataprep REST API definition, I have opened an issue: https://github.com/opea-project/GenAIComps/issues/394 to track it. By following the best practice, there should be only one REST API for the microservice: /v1/dataprep, and for all other VectorDB, they really do have only one REST API /v1/dataprep. So I think let's see and keep current implementation. And I also add the logic for checking and providing information if there is no dataprep router. Does it make sense?

Hi @mkbhanda and @irisdingbj, one more thing is that I remove the request size limitation because there is no size limitation in dataprep-redis microserivce now.

Let's address listService and dynamic adding endpoints seperately.


Preprocessing Scripts

Hi,
Thank you for codebase; it is quite informative. I was wondering if you opensourced your preprocessing pipeline anywhere. I am working with the dataset and ran into some of the issues that you mentioned with the background, so I am looking to preprocess the dataset as well. Can you point me to this?
Thanks!

Hi,
Unfortunately we don't have full preprocessing pipeline as it has been done in collaboration with other RSNA challenge participants some time ago and included radiograph segmentation and key points detection. Quite significant part of the overall project.

Sounds great; thanks for the quick response.


[5.1] Add an alias for the Collection avg method

After #10386 being closed, this is an alternative, not renaming the avg method but merely providing an alias for it, following the naming of methods like random() over rand(), etc.

@GrahamCampbell this follows the same return type as avg, which relies on sum, which also has a mixed return type. In fact, it's mixed all the way down to array_reduce.


Allow GeoIP overrides and fix server geoip randomization

First and foremost, this allows a director to configure IP blocks that we want to directly map to a lat/long pair. Valid IPs include IPv4 and IPv6, both masked and unmasked. In the event that MaxMind either doesn't contain a coordinate for an IP or we just don't like the coordinate it returns, we can now set where we want a director to think the server is. Note that this affects both servers (origins/caches) as well as clients, because we update server coordinates at ad recording time, and we get client coordinates at redirect time.
One small change is that we now log at the Director when an IP address results in the null coordinate. This should allow us to filter such requests in the logs when we're collecting metrics.
This also fixes another small bug that's been annoying me -- we don't treat the null address as a "bad" coordinate, which means that if MaxMind can't resolve a lat/long for a particular incoming client request, we send them to null island. Instead, the change in this commit that checks for lat/long == (0,0) in SortServers will cause a client IP resolving to the null coordinate to be redirected to a randomly-ordered list of caches.
One thing to note is that I don't test some of the functions I modify if those functions require access to a MaxMind database. That's definitely something we want to figure out at some point, and while we could create an API key for caching the database in our GH runners, we'd also want to set up the tests to skip if no database/key are present. That seems like it's outside the scope of what I'm trying to do here.

@jhiemstrawisc - I think this is ready to go once you address the minor refactor / use of go:embed suggested by Haoming.


[Loc][Regression] The popup box in the bottom right corner of the page after Configure is not localized

More info:
1. This issue does not reproduced on CMake tools version 1.20.17(pre-release), so it is a regression issue
2. Repro Language: All loc languages
3. Repro platform: Windows, Linux, Mac
Repro steps:
1. Download and unzip test 4.zip
2. Open it with VSCode and change the display language to CHS
3. Open above project with VS Code.
4. Click F1 to run command "CMake: Configure"
5. Check if the popup box in the bottom right corner of the page is localized
Expected result:
The popup box in the bottom right corner of the page has been localized after configuration

Actual result:
The popup box in the bottom right corner of the page is not localized after configuration

@gcampbell-msft This issue has been fixed on latest CMake tools version v1.20.24(pre-release), you can get the details below. Thank you!

Language
Verify Result

CHS

CHT

CSY

DEU

ESN

FRA
xc

ITA

PLK

PTB

TRK

RUS

KOR

JPN


fix swagger

i'm trying to use OpenAPI Generator to generate client side code for casdoor, but got this error

please fix the swagger issue

@0xyjk can you make a PR?

@0xyjk what language of client side code do you want to generate?

I've run into this issue as well when attempting to use a different client generator (https://crates.io/crates/paperclip). I don't necessarily think the problem is in the target language but in whether or not the client generator tool requires strict adherence to the OpenAPI spec -- I was able to generate a client using a different generator with seemingly more lax interpretation of the spec (https://github.com/swagger-api/swagger-codegen).
The casdoor swagger json that I downloaded from a locally dev instance of casdoor definitely does not follow the spec. For example, consider the /api/add-user-keys endpoint definition:
        "/api/add-user-keys": {
            "post": {
                "tags": [
                    "User API"
                ],
                "operationId": "ApiController.AddUserkeys"
            }
        },

This contains one pathItem with an operation called "post". The operation type in this spec requires a responses field.
My interpretation/understanding of the way the spec is defined gets a little fuzzy at this point (this is my first time reading an openapi spec) but it looks to me like the responses field requires a minimum of one element; this interpretation makes sense to me since I don't see why an HTTP API endpoint+operation would not be expected to return any response at all. In fact, IETF RFC 9110 agrees with this interpretation:

A server responds to a client's request by sending one or more "response" messages, each including a status code (Section 15).

(also, I've never encountered a situation where a HTTP request by a client not followed by a HTTP response from the server was anything other than an timeout error)

So to expand on why I think that it's most likely a casdoor spec issue (rather than a generator or target language issue), here is the struct field definition in paperclip that makes the responses field for operations required:

https://github.com/paperclip-rs/paperclip/blob/555a460cdfbc295edb504c3d7f441253a5c681ae/core/src/v2/models.rs#L715

If you're unfamiliar with rust and its widely used serialization framework, what makes this field required in this generator and what makes it fail to generate code for casdoor's swagger spec is  the fact that it's
pub responses: BTreeMap<String, Either<Reference, R>>,

rather than
pub responses: Option<BTreeMap<String, Either<Reference, R>>>,

Based on both the swagger/openapiv2 spec definition and the fact that HTTP requests always require at least once response according to IETF RFC 9110, I believe paperclip's behavior here is correct.
I suspect since casdoor is written in golang that somewhere there is a json: omitempty tag on the responses field in the operation struct and that whatever tooling is populating the data structure that defines casdoor's openapi spec is neglecting to include a valid response. Or maybe it's not generated at all? Is that file just manually maintained here?

Aha, I found the source of the error I encountered. It looks like casdoor uses a framework called beego which generates swagger spec based on comment annotations on api controller methods. For example for the endpoint paperclip was complaining to me about there are no annotations indicating what responses to expect for success OR failure: https://github.com/casdoor/casdoor/blob/b985bab3f3cddb550c22baa8f313a621e2259fc9/controllers/user.go#L579-L599
// AddUserKeys
// @Title AddUserKeys
// @router /add-user-keys [post]
// @Tag User API

To generate correct swagger docs this would have look more like
// AddUserKeys
// @Title AddUserKeys
// @router /add-user-keys [post]
// @Tag User API
// @Success 200 {int} int The count of filtered users for an organization

@0xyjk @waynr partially fixed for Java client: https://github.com/casbin/casdoor/commit/21f394847e5b384875f0f4eb9ea456e3f24ef80f


build error with opencl_dev

hi
when i use the branch of opencl_dev, and update the submodule, when i build use
export USE_OPENBLAS=1
export ANDROID_ABI="armeabi-v7a-hard-softfp with NEON"
./build.sh <path/to/ndk>
occurs error:
-- Found OpenCL: /home/niewei/work/DL/Android-Caffe/caffe-android-lib/android_lib/opencl-android/lib/libOpenCL.so
CMake Error at cmake/Dependencies.cmake:79 (message):
ViennaCL required for GREENTEA but not found.
Call Stack (most recent call first):
CMakeLists.txt:75 (include)
-- Configuring incomplete, errors occurred!
could you help me?
thanks in advance!

@neil1899 You need ViennaCL, and you could get it via get_viennacl.sh.

hi @sh1r0
i found a issue: my platform is qualcomm 820, the lib of libOpenCL.so has so many dependences, so i want to use dlopen function to using the libOpenCL.
now, i can build done, but it always shows that:
:0:0: note: this is the location of the previous definition
Is it ok?
thanks in advance!

Sorry, I'm not sure about that. Note that the opencl_dev branch as its name suggest is in developing stage and is currently pending due to the performance issue I mentioned before.

hi @sh1r0
what's the test did you run? when i run the test_net, it Aborted

@neil1899 Yes, I used that before for testing, but I'm not sure if it still working.

Could be reopened if needed.


Configure artifact publishing to Maven central

Would be good to get github actions setup: https://github.com/exceptionless/Exceptionless.Java/actions/new so we can get builds / tests running with every commit / pr :) I can help if you want I just don't know much about java builds (yet).

Let me have a look 👀. This will be my first open-source project as a maintainer so have to explore. I Will let you know if need help 😄


Use range loop in packBufferWithCompressionMap

This is mostly cosmetic.

Codecov Report

Merging #837 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #837      +/-   ##
==========================================
- Coverage   57.88%   57.83%   -0.06%
==========================================
  Files          42       42
  Lines       10824    10820       -4
==========================================
- Hits         6266     6258       -8
- Misses       3473     3476       +3
- Partials     1085     1086       +1

Impacted Files
Coverage Δ

msg.go
77.79% <100%> (-0.79%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ae05cd...d186d0f. Read the comment docs.


Explain why prefixes and suffixes are outside inputs

This explanation was provided in the backlog, but is not in the guidance.

You can preview this change here:
Built with commit 5c23731781906bf7b13be9b85f2a99b22527ae30
https://deploy-preview-1365--govuk-design-system-preview.netlify.app

@calvin-lau-gds - I think it's less likely, as we could add internal padding to accomodate text and internally positioned affixes.
The real issue is with things that the browser (or a browser plugin) 'injects' into the form field - because we have no way of detecting and accommodating for that.

Ahh understood, thanks for explaining.
I've updated the suggested edit in the comment you resolved above. I've just removed the autofill bit.
Can you take a look and commit the suggestion if it looks good (or I can do).
Thanks!

@timpaul I've now removed the autofill bit and made one last commit. I assume your commit on my earlier suggestion was an approval on the overall edit.
I'll give this a final look over in a bit and merge the pull request.


Chatbot State

When files are new, cancelled , failed. Chatbot is not connected to share the response.

Done