Add backup job

Small pull to add managing the gitlab backup cron job

This one has been on my list also, but I think it needs some things before it can be merged. Mainly, removing hardcoded values in favor of parameters.

@LongLiveCHIEF have updated with params for minute and hour.  i also added a param for the gitlab-rake bin although this should not really change.  I dont think this needs any further paramertisation but feel free to suggest some

Those were the ones I was worried about in order to make it a good PR.  If you really wanted bonus points, you could add SKIP's.  LGTM as is though.

Unfortunately the addition will cause a broken command syntax. Skips need
to be in a very specific unspaced, comma-sepatated format, and this prints
them out as an array.
The quick win here would be just to change the attribute type to a string
and allow entry of whatever is passed in, leaving it up to the implementer
to pass a valid value for skips.
The other option would be to have a parameter called other_args and just
append that to the backup cron.
On Sep 5, 2017 8:46 AM, "John Bond"<EMAIL_ADDRESS>wrote:

SKIPs was pretty easy to add so have updated the pull request
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/vshn/puppet-gitlab/pull/155#issuecomment-327179885,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADIVgW6X-loxM0k7V2FszRwgbKHypASVks5sfVCagaJpZM4O7h-X
.

@LongLiveCHIEF you may have missed the join (https://github.com/vshn/puppet-gitlab/pull/155/files#diff-0ac866172efd29d0ddc2aa75ae6f182dR81) although it was joining them on white space before so i have fixed that to a comma

Further to this the reason i prefer an array over a string is for data validation when we move to puppet4.  at that point we can do something like
types/skip.pp
type Gitlab::Skip = Enum['db', 'uploads', 'repositories', 'builds', 'artifacts', 'lfs', 'registry', 'pages']

manifests/init.pp
class gitlab {
 ...
 Array[Gitlab::Skip] $backup_cron_skips
 ...
}

Yeah, missed that. And speaking of skips... Puppet 5? Lol
On Sep 6, 2017 6:16 AM, "John Bond"<EMAIL_ADDRESS>wrote:

Further to this the reason i prefer an array over a string is for data
validation when we move to puppet4. at that point we can do something like
types/skip.pp
type Gitlab::Skip = Enum['db', 'uploads', 'repositories', 'builds', 'artifacts', 'lfs', 'registry', 'pages']
manifests/init.pp
class gitlab {
...
Array[Gitlab::Skip] $backup_cron_skips
...
}
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/vshn/puppet-gitlab/pull/155#issuecomment-327452751,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADIVgXgOoxpF2Mg2Zq5JEL_LceaG3UD3ks5sfn8KgaJpZM4O7h-X
.

anything preventing this?

Thanks


CoreFoundation: use C99 macro expansion

Rather than defining the various flavours of CFAssert requiring the user to
count the number of substituted parameters, collapse them to CFAssert.  The C99
variadic macro expansion permits us to ensure that the arguments are all
passable.  At the same time, the compiler validation of the printf conversion
will still catch the missing arguments (which could still be possible to have in
the previous case by just using the wrong count).

On the surface this looks pretty good; however I am going to need to make certain that it will work for merging this. Will this prevent MSVC builds for older versions of VisualStudio?

It should work with the older releases of MSVC.  At least VS2013+, though, I expect this to work with even older releases.

So I did some research on merging this: tentatively I think we can do this (the only issue that will happen is that when I merge this back into the mainline we will need to retain the CFAssertN macros due to other usage points outside of the open source CF. But that can be addressed at a later point.


Weird navigationBar behavior when containing a UIPageViewController (UIViewControllerRepresentable) ?

Hi @gaetanzanella!
I have a dynamic overlay that presents a UIPageViewController via the UIViewControllerRepresentable protocol. The whole thing is presented over another view, which is contained in a fullscreenCover and a NavigationView.
I've hidden the navigation bar on the content of my inner NavigationView (so I can push views from the dynamic overlay, inside the fullscreen's navigation context).
My problem:
The navigation bar is hidden as expected, but as soon as I swipe the UIPageViewController, the navigation bar appears.
I can't pinpoint if the problem comes from OverlayContainer or UIPageViewController 🙁
It only happens when I swipe the PageViewController's pages, not when I drag the overlay (it works as expected).
What do you think?  Have you come across something like this with Dynamic Overlay or OverlayContainer?
To recap, my hierarchy looks like (in pseudo code) :
contentView
  .fullScreenCover(
      NavigationView {
          mapView
              .navigationBarHidden(true)
              .dynamicOverlay(OverlayView)
      }
  )

(OverlayView contains a swiftUI UIViewControllerRepresentable component that manages a classic UIPageViewController. Using a TabView with PageTabViewStyle was too sluggish and unoptimised for my use case)

could you provide a sample code? it would be great to debug the issue

Hi @gaetanzanella
Sorry for the delay... I am on vacation right now so I'll provide an example next week. But as I am not sure about the exact role of DynamicOverlay in this behavior (could be a more general issue with SwiftUI and UIKit components), I would consider this as a very low priority ;)

Hi, sorry about the delay..
After investigation, it was not related to DynamicOverlay, nor OverlayContainer ;)


[Bug]: Puppeter works locally on Windows, but doesnt work on docker container.

Bug description
I have a project that runs nodejs locally on windows without problem. The firefox is downloaded automatically from npm install puppeteer@latest in the node_modules/puppeteer/.local-firefox
const puppeteer = require('puppeteer');
    const browser = await puppeteer.launch({
            product: 'firefox',
            headless: true,
            defaultViewport: {
                width: 3544,
                height: 3544,
            },
        });

The problem is when I try to do the same on docker.
    const puppeteer = require('puppeteer');

    const browser = await puppeteer.launch({
          product: 'firefox',
          headless: true,
          defaultViewport: {
            width: pageSizePx.width,
            height: pageSizePx.height,
          },
        });

And That's the result on docker linux.

The installation is normal, the firefox is there in the same place. node_modules/puppeteer/.local-firefox
Puppeteer version
13.0.1
Node.js version
12.15.0
npm version
6.13.14
What operating system are you seeing the problem on?
Linux
Relevant log output
[20:27:27 error] Failed to launch the browser process! spawn /app/node_modules/puppeteer/.local-firefox/linux-98.0a1/firefox/firefox ENOENT

TROUBLESHOOTING: https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md

I have been working getting a docker container working today. The following docker file and nodejs setup worked for me.
dockerfile

FROM node:12.2.0-alpine

# set working directory
WORKDIR /app

# add `/app/node_modules/.bin` to $PATH
ENV PATH /app/node_modules/.bin:$PATH

RUN apk update && apk add --no-cache nmap && \
    echo @edge http://nl.alpinelinux.org/alpine/edge/community >> /etc/apk/repositories && \
    echo @edge http://nl.alpinelinux.org/alpine/edge/main >> /etc/apk/repositories && \
    apk update && \
    apk add --no-cache \
    chromium \
    harfbuzz \
    "freetype>2.8" \
    ttf-freefont \
    nss

ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true

run.js
/* Build Docs */
(async () => {
  const browser = await puppeteer.launch({
    executablePath: "/usr/bin/chromium-browser",
    headless: true,
    args: ["--disable-dev-shm-usage", "--no-sandbox", "--disable-gpu"],
  });
})();

I have been working getting a docker container working today. The following docker file and nodejs setup worked for me.
dockerfile

FROM node:12.2.0-alpine

# set working directory

WORKDIR /app

# add `/app/node_modules/.bin` to $PATH

ENV PATH /app/node_modules/.bin:$PATH

RUN apk update && apk add --no-cache nmap && \

    echo @edge http://nl.alpinelinux.org/alpine/edge/community >> /etc/apk/repositories && \

    echo @edge http://nl.alpinelinux.org/alpine/edge/main >> /etc/apk/repositories && \

    apk update && \

    apk add --no-cache \

    chromium \

    harfbuzz \

    "freetype>2.8" \

    ttf-freefont \

    nss

ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true

run.js

(async () => {

  const browser = await puppeteer.launch({

    executablePath: "/usr/bin/chromium-browser",

    headless: true,

    args: ["--disable-dev-shm-usage", "--no-sandbox", "--disable-gpu"],

  });

})();

Hi, thank you for the response. With chromium I have no problem but in my case It must work with Firefox. Because in my project I work with images and I have an issue in chromium related to the image orientation but this issue doesn't exist in firefox. So in chromium it works normally for me as well but it's not enough.
Cheers.

Did you try installing firefox separately and giving executable path?

@oxycash  I was able to make it work with the executablePath, and I was having the problem with the printscreen (target closed). But then I realized the problem was memory and after use the container with free memory limit, the printscreen was working.
The solution was install the firefox-esr on alpine and use the executable path 'usr/bin/firefox'.
Thank you.


Incompatibility with Array{Bool}

Hi,
Juice only accepts DataFrames constructed from BitArrays. As far as I know, this is not documented anywhere. Here's a minimal reproducible example:
using ProbabilisticCircuits, DataFrames
D = DataFrame(convert(BitArray, rand(Bool, 100, 4)))
pc = learn_circuit(D; maxiter = 2) # Learns fine with a BitArray
T = DataFrame(rand(Bool, 20, 4))
learn_circuit(T; maxiter = 2) # Crashes
EVI(pc, T) # This also is incompatible with Juice

This is because of how Juice optimizes code. Here's the backtrace:
ERROR: MethodError: no method matching num_chunks(::Array{Bool,1})
Closest candidates are:
  num_chunks(::DataFrame) at /home/renatogeh/.julia/packages/LogicCircuits/OwAjF/src/Utils/data.jl:99
  num_chunks(::Union{BitArray{1}, LogicCircuits.Utils.CuBitVector}) at /home/renatogeh/.julia/packages/LogicCircuits/OwAjF/src/Utils/data.jl:100
Stacktrace:
 [1] num_chunks(::DataFrame) at /home/renatogeh/.julia/packages/LogicCircuits/OwAjF/src/Utils/data.jl:99
 [2] init_satisfies(::DataFrame, ::Nothing, ::Int64) at /home/renatogeh/.julia/packages/LogicCircuits/OwAjF/src/satisfies_flow.jl:57
 [3] satisfies_all(::LogicCircuits.BitCircuit{Array{Int32,1},Array{Int32,2}}, ::DataFrame, ::Nothing) at /home/renatogeh/.julia/packages/LogicCircuits/OwAjF/src/satisfies_flow.jl:48
 [4] satisfies_flows(::LogicCircuits.BitCircuit{Array{Int32,1},Array{Int32,2}}, ::DataFrame, ::Nothing, ::Nothing; on_node::Function, on_edge::Function, weights::Nothing) at /home/renatogeh/.julia/packages/LogicCircuits/OwAjF/src/satisfies_flow.jl:209
 [5] (::ProbabilisticCircuits.var"#139#153"{LogicCircuits.BitCircuit{Array{Int32,1},Array{Int32,2}}})(::DataFrame) at /home/renatogeh/.julia/packages/ProbabilisticCircuits/I8vDU/src/parameters.jl:217
 [6] iterate at ./generator.jl:47 [inlined]
 [7] _collect(::Array{DataFrame,1}, ::Base.Generator{Array{DataFrame,1},ProbabilisticCircuits.var"#139#153"{LogicCircuits.BitCircuit{Array{Int32,1},Array{Int32,2}}}}, ::Base.EltypeUnknown, ::Base.HasShape{1}) at ./array.jl:699
 [8] collect_similar at ./array.jl:628 [inlined]
 [9] map at ./abstractarray.jl:2162 [inlined]
 [10] estimate_parameters_cpu(::LogicCircuits.BitCircuit{Array{Int32,1},Array{Int32,2}}, ::DataFrame, ::Float64; weights::Nothing, entropy_reg::Float64) at /home/renatogeh/.julia/packages/ProbabilisticCircuits/I8vDU/src/parameters.jl:216
 [11] estimate_single_circuit_parameters(::StructSumNode, ::DataFrame; pseudocount::Float64, use_sample_weights::Bool, use_gpu::Bool, component_idx::Int64, entropy_reg::Float64) at /home/renatogeh/.julia/packages/ProbabilisticCircuits/I8vDU/src/parameters.jl:55
 [12] #estimate_parameters#117 at /home/renatogeh/.julia/packages/ProbabilisticCircuits/I8vDU/src/parameters.jl:19 [inlined]
 [13] learn_chow_liu_tree_circuit(::DataFrame; pseudocount::Float64, algo_kwargs::NamedTuple{(:α, :clt_root),Tuple{Float64,String}}, vtree_kwargs::NamedTuple{(:vtree_mode,),Tuple{String}}) at /home/renatogeh/.julia/packages/ProbabilisticCircuits/I8vDU/src/structurelearner/init.jl:14
 [14] learn_chow_liu_tree_circuit at /home/renatogeh/.julia/packages/ProbabilisticCircuits/I8vDU/src/structurelearner/init.jl:10 [inlined]
 [15] learn_circuit(::DataFrame; pick_edge::String, pick_var::String, depth::Int64, pseudocount::Float64, entropy_reg::Float64, sanity_check::Bool, maxiter::Int64, seed::Nothing, return_vtree::Bool) at /home/renatogeh/.julia/packages/ProbabilisticCircuits/I8vDU/src/structurelearner/learner.jl:18
 [16] top-level scope at REPL[6]:1
 [17] run_repl(::REPL.AbstractREPL, ::Any) at /build/julia/src/julia-1.5.3/usr/share/julia/stdlib/v1.5/REPL/src/REPL.jl:288

Since Array{Bool} does not deal with chunks, Juice crashes. Instead, Juice should either accept Array{Bool} or at least convert the offending data into a BitArray. If we implement #58, we might also want to extend data to Array{Int} as well.

The main issue with Array{Bool} is they are much slower in our use cases of computing flows, etc (about 4x or sometimes more). I guess one solution is to do the conversion behind the scene for the users.

Currently these are the assumptions about the data representation:
1/ Complete data

Bool data:

DataFrame of (Cu)BitVector

Float data:

DataFrame of (Cu)Vector{Float}

2/ Incomplete data:

Bool data:

DataFrame of Vector{Union{Bool,Missing}}
DataFrame of CuVector{Int8} where typemax represents missing

Float data:

DataFrame of Vector{Union{Float,Missing}}
DataFrame of CuVector{Float} where typmax represents missing

It would make sense to take other data formats and convert them to these standards automatically, so that we don't need to support too many cases.

In v0.4 will be using Matrix{Union{....}} instead of dataframes, will update the docs when that is out.
Then in that case Matrix{Bool} works for queries.


application description, draft 1

resolves #10
please review for grammer/flow

I think this looks good. Lise, when you done reviewing, probably you can merge? thx.


[Propsal] mesos-go talks to Multiple Mesos Masters

Hi All,
We use mesos-go for a couple of our projects and it is really useful.
We have a requirement to make the framework written using golang binding talk to multiple masters at the same time.

We tried with creating multiple driver objects
go func() {
if stat1, err1 := driver1.Run(); err != nil {
        log.Infof("Framework stopped with status %s and error: %s\n", stat.String(), err1.Error())
        time.Sleep(2 * time.Second)
        os.Exit(1)
    }
}()

go func() {
if stat2, err2 := driver2.Run(); err != nil {
        log.Infof("Framework stopped with status %s and error: %s\n", stat.String(), err2.Error())
        time.Sleep(2 * time.Second)
        os.Exit(1)
    }
}()
.
.

for the same scheduler object, we get offers from all the master to the same call backs which is really convenient but what we want to know is that will there be scope for potential race conditions by doing so?
Could we make mesos-go natively talk to multiple Masters? If yes what is the effort you foresee  in this project?
We would like to volunteer in this effort and raise a PR as this is really important to us. What we really appreciate is some sort of basic design document of this project that you had at the time of writing this repo and some directions of where to start.
We did spend a couple of days on this but the mesos-go is reasonably complex any help would be awesome for us to get started with.
@jdef
Thanks in Advance,
Dhilip

Are you asking for a single driver to support multiple mesos masters, or to ensure that multiple drivers can exist without interfering with any global state? Multiple masters is fairly unusual, but the latter option should be straightforward if it's not already supported (basically just grep for global var's and see what uses them, and make them non-global, and you should be set).
If you're asking for multiple master support with a single driver, what generic use cases do you imagine would be better served with this than just having two drivers?

There's no reason that a single process couldn't connect to multiple mesos masters. This is probably easier to deal with using the APIs in the "next" branch (also see #274). By design a Mesos framework only connects to a single master; that said, a single process could spin up multiple embedded frameworks if desired. You'd just need to keep your events organized so that you're not communicating with master2 about events from master1.

@jdef  Thanks fro the response we solved this by creating multiple drivers, that was pretty straight forward


KYLIN-3830 return wrong result when 'SELECT SUM(dim1)' without set a …

just remove FUNC_SUM in BUILT_IN_AGGREGATIONS, which make the kylin doesn't support query sum(dim1) without set a relative metric of dim1

Can one of the admins verify this patch?

Pull Request Test Coverage Report for Build 4225

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.001%) to 26.942%

Files with Coverage Reduction
New Missed Lines
%

core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java
1
78.12%

Totals

Change from base Build 4216:
-0.001%

Covered Lines:
18955

Relevant Lines:
70355

💛  - Coveralls

Thanks for the pr; With this change, Kylin will reject such query, is that true?

Yes, I have tested it. when query by SELECT SUM(SELLER_ID) FROM KYLIN_SALES;, kylin throw
No realization found for OLAPContext, CUBE_NOT_READY, CUBE_NOT_READY, CUBE_UNMATCHED_AGGREGATION[FunctionDesc [expression=SUM, parameter=1_317b3789:DEFAULT.KYLIN_SALES.SELLER_ID, returnType=null]], CUBE_NOT_READY, CUBE_NOT_READY, CUBE_NOT_READY, CUBE_NOT_READY, CUBE_NOT_READY, CUBE_NOT_READY, CUBE_NOT_READY, rel#59:OLAPTableScan.OLAP.[](table=[DEFAULT, KYLIN_SALES],ctx=,fields=[0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12]) while executing SQL: "SELECT SUM(SELLER_ID) FROM KYLIN_SALES LIMIT 50000"

Because I have found FunctionDesc.BUILT_IN_AGGREGATIONS only used in CubeCapabilityChecker:tryDimensionAsMeasure:235, which judge the FunctionDesc(SUM,COUNT,MAX,MIN,PERCENTILE,COUNT_DISTINCT) can be used as Dimension as measure.
As we discussed before, the SUM can't be calculated right. So I remove it to reject such query. Although the error message seems obscure, the commit can fix this bug with least change.


Dev conf demo

Some fixes for brakes
The model used in the conference for the demo

hop hop ça force merge


Next build when run inside outer Koa project picks up Koa .babelrc and crashes

When running next build inside my Koa project, it picks up the .babelrc file for the Koa project instead of using its own internal babel configuration. It then fails to build the client files and crashes. If I rename my .bablerc file to something else it builds fine using its own internal file. I do need to keep the Koa .babelrc file to enable me to use async functions etc. in my outer koa environment.
Additionally, I'm not sure if the build option is correct to use in development. I see all the development scripts seem to assume next is a stand alone server. Is it possible to have next-dev-no-server and next-build-no-server scripts.

https://github.com/zeit/next.js#customizing-babel-config

You should separate your frontend (next.js) and API Backend (Koa).

@albinekb  tried to separate them initially but I ran into problems with the working directory, so reverted (but I think the problem was elsewhere so will try again.
@sedubois I tried to use the presets but they did not seem to work, the next build crashed, when I tried that, however do I need to download the next/babel npm, if so I could not find it.
Finally my workaround is to edit next/dist/server/build/find_config.js and either set filename=null or babelrc: false. It would be nice to expose the bablerc flag in the next.config option, or get the preset approach to work corretly

I moved next into its own sub-directory with its own package.json and without a .babelrc file, in order to ensure that the working directory for the next build was contained. The build continued to fail until a put a  .babelrc file in the next sub-directory. From the babel documentation, babel will recursively search up the directory structure untill it finds a .babelrc file to use. So even though I was trying to isolate next in its own directory it was inadvertantly using the Koa .babelrc file.
Please add this into the documentation to assist others.
I also feel that next should be split into two packages one with the core and one with its own server. This would streamline it to be run in a higher-level container.

I also feel that next should be split into two packages one with the core and one with its own server. This would streamline it to be run in a higher-level container.

In what case would this make sense? Do keep in mind that we have hundreds (maybe thousands looking at the stars) of users who all have very different use cases 😄
FYI:
When you add a .babelrc to the next.js directory (or above) with the following content, it'll automatically use the default babelrc:
{
  "babelrc": false
}

We had this exact usecase for the examples directory: https://github.com/zeit/next.js/blob/v3-beta/examples/.babelrc 👍
If you feel it's valuable to add that to the readme feel free to send a pull request 👌
Thanks for the feedback! 🙏

Happy to create a pull request, never done so before but willing to try.
My use case is the followings (chip in if you have other suggestions):

I need to redirect to https. (middleware required)
I need to split the site into a private area and public area and do an oauth process. (more middleware, with session etc)
I need to install a graphql server on one of the routes, I also want compression on the graphql side (more middleware)
I want to use next to build a more progressive web app. I have extensive experience with SPA react and want to leverage my skill and existing components to be in a position to tune the startup time of some of my components. I'm probably not as sold as you guys on extensive SSR everywhere, but I realise for some of my react component it makes absolute sense for a first render. I'm looking for an isomorphic experience in this regard, so I can experiment.
I will need to pass my session object into the next.render() method so the components can use the information to do graphql queries for data and also render in the right language/locale etc. which is stored in my session object.

From a container perspective it would be nice to be able to pass the already parsed request and response objects into next.render or even the koa context itself without reverting the the low level req and res objects.
Finally recognition of properties i.e. additional parameters to the render method, (ideally treated as react properties) flowing from the container wrapper down into the next/react page component.
It feels as though running next in a container is more of a hack at the moment, but I think next should keep the focus on the react progressive web app side and making it easier to integrate into the three main node servers i.e. express koa, hapi. This would be similar to the approach taken by the graphQL server libraries which have variants which play nicely with the above mentioned servers
I'm sure you've heard all these cases before, so I hope this helps.

These are all issues you get from wanting to build a monolith application with Next.js. Like @albinekb  pointed out earlier (https://github.com/zeit/next.js/issues/2258#issuecomment-308439695) you'll want to separate the frontend and backend. Think of Next.js as a frontend server, it should only be responsible for rendering html based on api calls to an external api. The custom server (programmatic) api is provided to let you handle custom routing and caching.

@serle using babel for server is kind a tricky. Since it might mix with next's client side (and ssr) babel config.
We want to fix it but it's complicated. And currently you can hack with babel by using different environment and using custom config for each.
Anyway, this is how I'd deal with this problems like this:

I use Node 8 for the server and I got all the new features except import / export
And I use cookies for authenticating on the server and client. (See sample app)
Always try to use a separate server for data apis and communicate them with HTTP (or WS)

Anyway, here the original issue is babelrc is getting mixed up with the server. It's true and it'll hard to fix without making our babel config complex.
We don't want to address it right now.
So, I suggest to use Node 8 for the server.


"USER_ERROR__missing_dlib_all_source_cpp_file__OR__inconsistent_use_of_DEBUG_or_ENABLE_ASSERTS_preprocessor_directives" when compile examples

Expected Behavior

Compile examples
Current Behavior

[ 34%] Linking CXX executable video_tracking_ex
Undefined symbols for architecture x86_64:
  "_USER_ERROR__missing_dlib_all_source_cpp_file__OR__inconsistent_use_of_DEBUG_or_ENABLE_ASSERTS_preprocessor_directives_", referenced from:
      __GLOBAL__sub_I_video_tracking_ex.cpp in video_tracking_ex.cpp.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [video_tracking_ex] Error 1
make[1]: *** [CMakeFiles/video_tracking_ex.dir/all] Error 2
make: *** [all] Error 2

Steps to Reproduce

mkdir build; cd build; cmake .. ; cmake --build .

Version: 19.16
Where did you get dlib: Github repo
Platform: macOS 10.14
Compiler: Xcode 10.0

Multiple dlib in path


no way to set VCPKG_ALLOW_APPLE_CLANG

When building on Mac with xcode installed, I am given the following message:
Building the vcpkg tool requires support for the C++ Filesystem TS.
Apple clang versions 9 and below do not have support for it.
Please install gcc6 or newer from homebrew (brew install gcc6).
If you would like to try anyway, set VCPKG_ALLOW_APPLE_CLANG.

However, setting this environmental variable does nothing and results in the same error.
It looks like this line in the CMakeLists should be reading from the environment $ENV(VCPKG_ALLOW_APPLE_CLANG).
https://github.com/Microsoft/vcpkg/blob/a6986fdbea87c5af4ab9c1eb4d8c3d52563aee65/toolsrc/CMakeLists.txt#L9

@liangqi I think no, this issue is related to #4475 , but this issue focused on how set VCPKG_ALLOW_APPLE_CLANG not how to build vcpkg on apple, in another word this issue is part of #4475


MetaProperty fields as Identifier

According to https://github.com/estree/estree/blob/master/es2015.md#m…etaproperty the meta and property members are Identifier not plain strings.
Keep support for plain strings for backward compatibility.

Is there something else needed to get this merged ?

@Cellule Nope.

Thanks !


Image.java:37-38: Continue implementing the operations...

The puzzle 86-390ec7ae from #86 has to be resolved:
https://github.com/amihaiemil/docker-java-api/blob/68ad57f1a8ee7cde78b455fa65efff79f5e63446/src/main/java/com/amihaiemil/docker/Image.java#L37-L38
The puzzle was created by amihaiemil on 26-Apr-18.
Estimate: 30 minutes,
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@amihaiemil/z please, pay attention to this issue

@0pdd/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

There is an unrecoverable failure on my side. Please, submit it here:
PID: 4@ab56d234-9c5a-4a94-9bc9-5e54c14be93d, thread: BkParallel-5
com.mongodb.MongoCollectionImpl[558] com.mongodb.MongoWriteException: quota exceeded

1.0-SNAPSHOT

Job #96 is now in scope, role is DEV

There is an unrecoverable failure on my side. Please, submit it here:
PID: 4@ab56d234-9c5a-4a94-9bc9-5e54c14be93d, thread: BkParallel-2
com.mongodb.MongoCollectionImpl[558] com.mongodb.MongoWriteException: quota exceeded

1.0-SNAPSHOT

There is an unrecoverable failure on my side. Please, submit it here:
PID: 4@ab56d234-9c5a-4a94-9bc9-5e54c14be93d, thread: BkParallel-6
com.mongodb.MongoCollectionImpl[558] com.mongodb.MongoWriteException: quota exceeded

1.0-SNAPSHOT

There is an unrecoverable failure on my side. Please, submit it here:
PID: 4@ab56d234-9c5a-4a94-9bc9-5e54c14be93d, thread: BkParallel-9
com.mongodb.MongoCollectionImpl[558] com.mongodb.MongoWriteException: quota exceeded

1.0-SNAPSHOT

The job #96 assigned to @llorllale/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this

@0crat waiting on review for #101

@0crat waiting on review for #101 (here)

@llorllale The impediment for #96 was registered successfully by @llorllale/z

The puzzle 86-390ec7ae has disappeared from the source code, that's why I closed this issue.

@0pdd the puzzle #103 is still not solved.

Order was finished: +30 point(s) just awarded to @llorllale/z

The job #96 is now out of scope


Missing Palm-oil.svg file added

What

Missing palm-oil.svg file which was causing error in onboarding has been added.

Screenshot
After adding the file there is no error in on-boarding screen:
https://user-images.githubusercontent.com/83439329/159876052-213dc7e4-d1b7-40eb-8171-30cb977ad674.mp4
Fixes bug(s)

#52

Part of

https://github.com/openfoodfacts/smooth-app/issues/525
(please be as granular as possible)

Hello @PrabeshPP, this PR is useless.
Please add the file in #1310 directly please :)

Oops sorry, I didn't understand the difference between #1310 and this one

In this PR, if I understand well, you should only add the missing SVG file. But you have 6 changes.

@monsieurtanuki  but in the palm-oil-svg branch only one file was changed.

@g123k  @monsieurtanuki  since the Pull request for the Svg file was created after the Consent Analytics UI PR ,this branch contains all the file changed in the analytics UI branch ,as the Analytics UI branch is till open and has not been merged yet. This branch is showing the changes from the Analytics UI branch.

@PrabeshPP I wouldn't be able to tell you what the best practice in github would be in that particular case, because I'm not good with github.
What I would suggest though is to create a clean PR, possibly from another branch, with just one file - especially in this case where that file is connected to nothing. Much cleaner IMHO.

@PrabeshPP That said, if you're currently stuck in a github rabbit hole, you may quietly wait until the previous PR is merged provided that it unblocks the situation. There's no rush with the current PR: no strong need, not blocking other PRs either.

@vik4114  yup that looks great.

Mmm, unfortunately, no that's still not OK :/
Look at the "Files changes" tab: there is still a data.png file and two other Dart classes that you want to remove

@g123k  I think I have to wait until the previous PR gets merged. Then only, I will be able to create a new PR for this  file without having changes from previous PR.

@g123k I think I have to wait until the previous PR gets merged. Then only, I will be able to create a new PR for this file without having changes from previous PR.

No

@PrabeshPP That said, if you're currently stuck in a github rabbit hole, you may quietly wait until the previous PR is merged provided that it unblocks the situation. There's no rush with the current PR: no strong need, not blocking other PRs either.

Or you can just create a new branch from develop and add the SVG there

.

@vik4114  thanks mate for the help . It worked now .

@g123k  I have created a new PR for this. I think we can now close this PR.

Ok your new PR is Ok.
I close this one


formidable is stuck at parse function's callback

Support plan

Which support plan is this issue covered by? (Community, Sponsor, Enterprise): Community
Currently blocking your project/work? (yes/no): yes
Affecting a production system? (yes/no): no

Context

Node.js version: v16.20.1
Release Line of Formidable (Legacy, Current, Next): Next
Formidable exact version<EMAIL_ADDRESS>Environment (node, browser, native, OS): node
Used with (popular names of modules): express

What are you trying to achieve or the steps to reproduce?
I am trying to create an API endpoint that accepts uploading an Excel file in Node.js with Express and Formidable. After uploading the Excel file, I will parse the content of the file with another package to insert the parsed data to MongoDB using Mongoose. Currently, I am stuck at the parse function of Formidable.

const express = require('express')
const cors = require('cors')
const { IncomingForm } = require('formidable')

const app = express()
app.use(cors({ origin: true }))
app.use(express.json()) // Commenting this line does not make it work either

const router = express.Router()
router.post(
  '/upload',
  (req, res, next) => {
    const form = new IncomingForm({})
    console.log(form)
    form.parse(req, (err, fields, files) => {
      if (err) {
        throw err
      }
      console.log(fields)
      console.log(files)
      res.send('hi')
    })
  }
)

app.use('/', router)

module.exports = app

To call the API endpoint on Postman, here's what I did. The uploaded file is 15KB.

What was the result you got?
The request got stuck when I tried to hit that API endpoint using Postman. It does log the console.log(form) statement, but anything beyond that seems to never run.
What result did you expect?
To be able to log what fields and files contain as well as sending a hi as a response in Postman.

Just came here with the exact same use case. The callback never resolves, no error either.

Try again with node v20, and without express

@GrosSacASac just curious but... why? The docs say node > 10.13 is supported, and there is explicit express integration support in the docs.

Face the same issue today, but it end up I forget to disable the nextjs bodyParser.
export const config = {
  api: {
    bodyParser: false,
  },
};

I have found the main issue for my case. It wasn't because of the Node version or the Express version, but instead on which I ran my Express app: Google Cloud Functions.
It turns out that Google Cloud Functions implement some middleware that converts inputs that are files into raw data type (Buffer) in req.rawBody (full description here: https://stackoverflow.com/a/47319614). It seems that Formidable requires the data type unmodified, and as the data is automatically modified when running on an Express app on Google Cloud Functions, I concluded that my case is not the right use case to use Formidable.
At the same time, I tried running Formidable on a regular Express app and it worked with the Node version I provided in the original issue submission.
For others facing the same issue, you can instead parse the raw data using Busboy.

Next time test locally before making an issue.
Someone made https://github.com/Amit-A/formidable-serverles that uses req.rawBody. I am not sure that it is a clean solution.

related https://github.com/node-formidable/formidable/issues/594

Sorry to resurrect this, but shouldn't formidable throw some kind of error if it can't parse the request? Would a PR exposing the error be accepted? Could blow things up, but it's better than silent failure.


protos importing another protos in different packages not working

Example:
src/test/foo/a.proto:
package foo; message t1{     string a = 1; }
src/test/bar/b.proto:
package bar; import "foo/a.proto"; message t2{    string b = 1;    foo.t1 test = 2; }
executing these commands in src/test folder:
protoc --go_out=. foo/a.proto
protoc --go_out=. bar/b.proto
While compiling b.proto, throws error:
Import "foo/a.proto" was not found or had errors

You're missing a -I.; the proto compiler doesn't add the current directory to the import path by default.

Tried -I. as well.  Same issue

cd src/test
protoc -I. --go_out=. bar/b.proto


Update and verify Packet Generator provisioning code to work with dual-port Mellanox (ConnectX4) HW configuratio at Packet.net

[x] Update code (ansible playbook) to work with dual-port Mellanox (ConnectX-4)
[x] Verify deployment is successful

[x] VLANs correctly assigned to node
[x] NFVbench configuration updated with correct VLANs
[x] NFVbench container starts and works as expected

Command for running playbook:
ansible-playbook -i "<remote_host>," packet_generator.yml -e server_list=dualmellanoxtest01 -e deploy_env=test1 -e dual_mellanox=true -e facility=sjc1

Comma (,) after <remote_host> is needed
Make sure <remote_host> is accessible from the cnfdeploytools container

Code has been pushed, but leaving in "review" for visibility


Vue warns about missing required prop that has a default value

Version
2.5.13
Reproduction link
http://jsfiddle.net/df4Lnuw6/207/
Steps to reproduce
Specify a required prop with a default value:
Vue.component('comp', {
    template: '
{{ typeof x }} {{ x }}
',
    props: {
        x: {
            type: Number,
            required: true,
            default: 5,
        },
    },
});

Render the component without specifying a value for that prop:
<comp></comp>

What is expected?
The component should render the following without any prop validation errors:

number 5

What is actually happening?
The component renders OK, but warns about missing required prop x.

While it's true that prop x is not specified, since it has a default value, there should be no warning message.
What exactly does required check for? It appears that it checks two things:

The prop should be provided, as in at least <comp :x="..."></comp>.
The prop value should be non-null and non-undefined.

I think in the case where a required prop has a default value, (1) should be relaxed.
Otherwise, how can I enforce a prop to never be null while also providing a default value if the prop value was not provided?

TLDR; Maybe we should indeed allow required + default value in this check
By saying the prop is required you expect the user to always provide a value, so making it have a default value defeats the purpose of the prop being required.
When you require a prop, it means that you need that information from the user and that there is no way for you to provide a fallback value.

Otherwise, how can I enforce a prop to never be null while also providing a default value if the prop value was not provided?

No, because null and undefined values always skip validation
If you want to take a deeper look at how the prop validation works, you can check https://github.com/vuejs/vue/blob/dev/src/core/util/props.js#L94
After doing some research in past issues, I found this comment

Hmm, yeah so it needs to be more accurate:

null indicates the value is explicitly marked as not present and it should remain null.
undefined indicates the value is not present and a default value should be used if available.
required: true indicates neither null or undefined are allowed (unless a default is used)

I agree this could be confusing, just as the existence of null vs. undefined in the language itself. But the design was trying to stay close to what these values are designed represent in JS, and changing them would be break

Yeah, currently the issue that is required: true implies that the prop cannot be absent, but then if required: false and the prop value is nully then validation is skipped altogether. There is no way to enforce a prop to be non-nully at all times without required: true and hence prop omission is disallowed.
I also think the docs could be more clear about the precise definition of the required option.

The validation will always be skipped with nully values though.
Contributions to docs are always welcome 😄

The validation will always be skipped with nully values though.

Seems NOT when required: true is given. http://jsfiddle.net/df4Lnuw6/225/

That's right! it is for undefined that validation is skipped with non-required props

How about a new flag useDefaultForNull
Vue.component('comp', {
    template: '
{{ typeof x }} {{ x }}
',
    props: {
        x: {
            type: Number,
            default: 5,
            useDefaultForNull: true
        },
    },
});

It also reads ... awkwardly. Am I the only one who thinks that? Personally I'd go with adding nullable as a type declaration and using that as a flag, but I realize that's a little outside of the typical Vue approach.

By saying the prop is required you expect the user to always provide a value, so making it have a default value defeats the purpose of the prop being required.

Actually, required: ture and default value are coexisting. If the value is undefined, the default value will apply.

By saying the prop is required you expect the user to always provide a value, so making it have a default value defeats the purpose of the prop being required.

Actually, required: ture and default value are coexisting. If the value is undefined, the default value will apply.

In fact it works as intended, it just warns for no reason (since property IS present cause not null in code being it the default value)

Is there any new information on this issue?
We got the same issue with vue spamming the developer console with "missing prop" even though it has a default.
Maybe i understood this wrong and there is a solution for this?

Is there any new information on this issue? We got the same issue with vue spamming the developer console with "missing prop" even though it has a default. Maybe i understood this wrong and there is a solution for this?

Perhaps. Ny recent experience with this has lead to some thoughts on this issue that I think could be helpful.
Composition vs. Options
in our case the confusion seems to arise from because of the differing defaults of composition API's setup script and options API required: boolean option.
We use a combination of defineProps and withDefaults like so with composition API and Typescript,
// for example
export interface Props {
  label: string
  isDisabled: boolean
}

const props = withDefaults(defineProps<Props>(), {
  isDisabled: false
});

Did you see it? The typo was as easy as missing an ? on the optional prop when defining the props,
// fixes the warning
export interface Props {
  label: string
  isDisabled?: boolean
}

Which is reasonably easy to miss, especially since you might have read this line in the docs here (can you forgive me for skim reading?),

which would mean (like silly me) you would've missed this segment farther down,

In fact it works as intended, it just warns for no reason (since property IS present cause not null in code being it the default value)

Yes it does, however I might be forgiven for quickly parsing the docs and making the wrong assumption.
assumptions about withDefaults
I would also point to this page here that seems to indicate the opposite unless I'm completely misreading it,

This will be compiled to equivalent runtime props default options. In addition, the withDefaults helper provides type checks for the default values, and ensures the returned props type has the optional flags removed for properties that do have default values declared.

What could be improved here?
Commentary without suggestion isn't very helpful in my mind - so here's two things I would like to see improved,

This section on prop validation should probably link to this section on composition API's Typescript validation. These topics go hand in hand and they currently feel disjointed.
I feel the usage of withDefaults should automagically make the prop optional, as mentioned above, this would be my assumption reading about it in the docs

The former seems quite simple and I'd happily take a look at contributing to the docs if that seems acceptable.
The latter is more opinionated though but at the very least I think the docs could be less confusing. Personally, I would expect that using withDefaults would implicitly define the provided props as being optional. Otherwise what's the point? I find this the exact kind of footgun that creates confusion in the first place, as it requires me to remember to specify optionality in two separate places (the prop definition as well as the default hook call) - but this is purely my opinion.


mlt: 6.10.0 -> 6.12.0

Motivation for this change
https://github.com/mltframework/mlt/releases/tag/v6.12.0
Notes mention new VA-API support, and other goodies..
among many important fixes! :)
Should look through them more closely,
possibly adding new deps (for vaapi?).
(note to myself but open to anyone with a second :))
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

The configure flag --enable-gpl is repeated twice?

The configure flag --enable-gpl is repeated twice?

That's how you enable gpl x2 => gplv2 code, right?! :rofl:
Cleaning up, thank you for review and apologies for missing these things!
Oh hooray: in my defense the configureArgs were already dup'd haha.
Okay I'll check they don't somehow actually help xD.

Seems we half-upgraded this by bumping qt-enabled variant in b0f912b6d94aa56ada9065a2676f6bd71a7cfecb or so.  Rebasing/fixing underway...

Merged the two mlt expressions, which seems high-level good (as well as a few dependencies that seem no heavier than what's already pulled in) but should make sure shotcut and kdenlive both still work.  I nuked the "fix motiv.dev" postInstall as likely kruft but will revisit.

This seems to have suffered some bitrot, if we have a better PR or so feel free to close :).  Hopefully will be revisited eventually if not :).

Master already has version 6.22.1. If you want to move any of the other changes over please open a new PR.


Expose Driver.Url()

Scenario:
Sometimes is needed to get the current URL and verify it contains a certain string
Actual Result:
URL method is not exposed
Expected Result:
Method should be exposed

now you can use Browser.Url to get the Uri object
4bdbc50


Data not updated

Hi! Are you guys still updating all the data? Because I've seen it's not been updated since June 4th. Thank you

Can confirm, not updated since 7th June.

Hi @saramt89 @raahimfareed, yes the data wasn't updated due to an error with the cron. I haven't been active for the past few days to check if it's been updated. I've fixed the issue and it should be working fine. Sorry for the delay


In the "Attribute" window text in the tabs are cropped.

In the "Attribute" window text in the tabs is cropped.

By the way.
Is it possible to save the status of the position of the Attribute and Status windows when opening Transmission Web Control, for example, that would open the above windows when launching?

Just a little bit wider. ;-)


ENETDOWN

When i start the monitor it runs. But after a while i get the error message: "ENETDOWN" how do i solve it?

I believe i solved it, it happens when my computer goes into sleepmode. I guess the server goes down then?

Yeah... Use digitalocean or something similar

Hi @wulds were you able to find a way to keep the program running while the computer is on sleepmode?

@msuyat42 yes, i had to reinstall mongodb, and had to manually set the data directory.

@wulds do you mind helping me out with that?

@msuyat42 sure add me on discord, ludwig#0808

@wulds sent you a friend request


Send follower message to the chat in addition to the console.

Closes #41
Not an expert in Typescript or git, but getting there :)

Looks good @John-Kryspin!  Could you do me a favor though?  This is totally my fault because we didn't have a CONTRIBUTING.md, but could you make this change in the vNext branch and PR back to vNext?  That way you're working against the latest changes.
This repo treats master as the actual code published to the VS Marketplace.  It's a holy place where no one dares venture without a tag. 😆
We'll review & merge live on stream as soon as it's ready to go.  Thanks!

yeah Sure! @MichaelJolley I'll fix it for Thursdays stream 👍


Add redAcademy

@JamesRedPanda First stage of verification passed, official domain for redAcademy is redacademy.co.za as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@philipto Thanks for the update :) If you need our SAQA (South African Qualifications Authority) or NQF (South African Qualifications Authority) documents, please let me know


Issues with RT-5.1 test (Singleton Interface)

Hi,
There are two issue with RT-5.1. Can u please help to resolve the issues.

The test sets the MTU at the subinterface/ipv4 and ipv6 level (https://github.com/openconfig/featureprofiles/blob/d29b222f35ae6bf795ad667e08f67e63218ac9f6/feature/interface/singleton/ate_tests/singleton_test/singleton_test.go#L121) without setting the MTU for the physical interface. The MTU for the interface should be set to tc.MTU+14 (i.Mtu = ygot.Uint16(tc.mtu + 14)), otherwise the IPV4/6 should be dropped that will result in test failure.
The test assumes that the number of output unicast packets from ATE that is captured at the flow level should be equal or larger than the number of inbound unicast packets  by the DUT (https://github.com/openconfig/featureprofiles/blob/d29b222f35ae6bf795ad667e08f67e63218ac9f6/feature/interface/singleton/ate_tests/singleton_test/singleton_test.go#L337). This assumption is not correct due to
1- The flow statistics does not account for the control packets, but DUT's interface counter does account for it.
2- Also, ATE sends ICMPv6 since the ipv6 is configured on the ATE interface. Below figure shows that three control packet is received by the DUT that  results in inbound packet to be larger than (+3) outbound packets.

To fix this issue, either we should have a threshold (+3) to account for the control packets or change the test logic to read the number of packets in a way to account for the control packets. I think ATE statistics at the port level  account for control packets.

@dplore @bstoll - I would suggest if any IP (or upper layer) MTU is being altered that a prerequisite would be to alter the interface MTU otherwise IP MTUs cannot be set.  We should not introduce any internal implicit behaviors of treatment to the interface MTU if only an IP MTU is set but rather this should be explicit intent.
It is likely the YANG node descriptions for the mtu leafs should be updated to reflect this behavioral expectation as well

We did have a deviation for omitting/setting the L2 MTU some point in the past. I agree that devices that don't allow setting the L2 MTU is not fully compliant.

While #412 is intended to rectify a more precise language for the deviation, I want to explain how I interpret the OpenConfig MTU spec here.

/interfaces/interface/config/ - Set the max transmission unit size in octets for the physical interface. If this is not set, the mtu is set to the operational default -- e.g., 1514 bytes on an Ethernet interface.
`/interfaces/interface/subinterfaces/subinterface/ipv4/config/' - The size, in octets, of the largest IPv4 packet that the interface will send and receive. The server may restrict the allowed values for this leaf, depending on the interface's type. If this leaf is not configured, the operationally used MTU depends on the interface's type.

So if we have these scenarios, this is how I interpret the OpenConfig compliance:

Device A: enforces that L2 MTU >= L3 MTU and L2 MTU default is 1514. (compliant)
Device B: allows L3 MTU to override L2 MTU. (also compliant)
Device C: can only set L3 MTU but not L2 MTU (not compliant)

Is this something we can agree on?

IMO, the test should be modified to set both the L2 and L3 MTU to appropriate, compatible values. All compliant devices should allow setting of both these MTUs.
Agreed that scenario/device B scenario is compliant to the test requirements as they appear now.  It is implementing behavior that is not prohibited and not specified by OpenConfig.

After #412 is approved, I'll send a follow up to add setting of L2 MTU as a deviation.

Done.  IMO, L2 MTU should be the standard and if useful,  we could  add a deviation to disable of setting the L2 MTU.
If this doesn't sound right to you, we can discuss offline and see if/why it makes sense.

Sorry, I mean add the setting of L2 MTU, but add a deviation to omit the setting of L2 MTU.

Re: the second issue above "The test assumes that the number of output unicast packets from ATE that is captured at the flow level should be equal or larger than the number of inbound unicast packets"
Upon looking at this more closely, I agree that the direction of the less-than is an error. Fortunately, we've always had the ATE and DUT packet counters be equal at least for the unicast packets because I think the control packets tend to be broadcast, so that's why we didn't observe any test failures.

Still seeing the issue , ipv6 control packets is still not accounted for
singleton_test.go:356: ATE received too few destination packets: got 260906, want >= 260909

Yes, we are sure. If you notice the difference is only three packets (max six packets depending on the execution time of the test). We did the packet capture and the difference matches with the control packets (ipv6 neighborliness advertisement generated by ixia). We also do not see this issue when we disable ipv6 (we could pass the for ipv4 cases).


F#750 snapshot type in list

Description

Show snapshot type in snapshot list, snapshot detail and dataflow main snapshot tab
Filtering by snapshot type in snapshot list

Related Issue :

#750
How Has This Been Tested?

1 . Snapshot Tab > Check if snapshot list shows snapshot type (eg. hdfs, local, staging db)

2 . Snapshot Tab > Check filtering by snapshot type

Snapshot detail > Check if snapshot type is shown

Dataflow main grid > snapshot list tab > Check if you can see the type of snapshot

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project. it will be added soon
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document. it will be added soon
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Additional Context

run build
deploy to 2


False positives for "requireCapitalizedComments"

I have a couple of seemingly-false positives coming up when validating my code with this rule.

In each case, the block is about two lines however, in the final example, it is two, two-line textblocks.
Here's a copy-past of the last one:
// Calculate the position of the price point as a proportion of
            // the range.
            // Adjust by 50% to accommodate 0% being the minimum left value
            // for the containing html element.
            pricePosition = MIDPOINT + (priceDifference / range) * 100;

Note: I'm running Windows 8.1.

Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

I can reproduce the bug with version 1.11.1 using the following .jscsrc
{
    "validateIndentation": 4,
    "requireCapitalizedComments": true
}

The bug does however not occur, if I use any of these rules alone...
We actually have a test for comments like this, see require-capitalized-comments.js#L57-L61. But the test only sets requireCapitalizedComments and not validateIndentation in the config.

Nice spot! I can confirm I use 4 spaces for indentation.

@ashclarke thanks for reporting!
@alawatthe would you like to look into it?

@alawatthe what's the actual repro case please?

@ashclarke You can (temporarily) fix the problem yourself, by placing the validateIndentation rule after the requireCapitalizedComments rule in your jscsrc.
I found the problem: The validate indentation rule reorders the lines of the comment. E.g.:
Consider the comment
// A textblock may also have multiple lines.
// Those lines can be uppercase as well to support
// sentense breaks in textblocks

The file object, which goes into the  validateIndentation rule has a commentsproperty like this
"comments": [
  {
    "type": "Line",
    "value": " A textblock may also have multiple lines.",
    "range": [
      // ...
    ],
    "loc": {
      // ...
    }
  },
  {
    "type": "Line",
    "value": " Those lines can be uppercase as well to support",
    "range": [
      // ...
    ],
    "loc": {
      // ...
    }
  },
  {
    "type": "Line",
    "value": " sentense breaks in textblock",
    "range": [
      // ...
    ],
    "loc": {
      // ...
    }
  }
],

It somehow modifies the object such that the object afterwards looks like this (the location and range info are still correct, just the ordering in the array is different):
"comments": [
  {
    "type": "Line",
    "value": " sentense breaks in textblock",
    "range": [
      // ...
    ],
    "loc": {
      // ...
    }
  },
  {
    "type": "Line",
    "value": " Those lines can be uppercase as well to support",
    "range": [
      ..
    ],
    "loc": {
      // ...
    }
  },
  {
    "type": "Line",
    "value": " A textblock may also have multiple lines.",
    "range": [
      // ...
    ],
    "loc": {
      // ...
    }
  }
],

i.e. requireCapitalizedComments thinks the comment looks like this:
// sentense breaks in textblocks
// A textblock may also have multiple lines.
// Those lines can be uppercase as well to support

which should throw an error.
@mikesherov you are the master of validateIndentation, would you like to have a look at this?

@mikesherov The Repro case:
// A textblock may also have multiple lines.
// Those lines can be uppercase as well to support
// sentense breaks in textblocks

with jscsrc:
{
    "validateIndentation": 4, // or any other value here
    "requireCapitalizedComments": true
}

The ordering is important! The following jscsrc is working:
{
    "requireCapitalizedComments": true,
    "validateIndentation": 4
}

OH, duh. reverse is in place. Fix coming in a minute.

That was quick, nice work :-D
Perhaps we should (deep) freeze the file object, to prevent modifications or check if rules modify the file object...

:smile: :+1:

@ashclarke There were 3 rules affected by this bug:

disallow-mixed-spaces-and-tabs
maximum-line-length
validate-indentation

So probably you have some of them before requireCapitalizedComments ;-)

Disallow mixed spaces and tabs :)


Fix monitoring-2-0 test

Test name
Status

recreate
passed

haproxy
passed

scheduled-backup
passed

storage
passed

init-deploy
passed

self-healing
passed

restore-to-encrypted-cluster
passed

limits
passed

self-healing-advanced
passed

monitoring-2-0
passed

demand-backup
passed

affinity
passed

one-pod
passed

auto-tuning
passed

operator-self-healing
failed

proxysql-sidecar-res-limits
passed

pitr
passed

users
passed

demand-backup-encrypted-with-tls
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/869/commits/e32e90099d0fbe46e7b077b9aa83a3878711c05c
image: perconalab/percona-xtradb-cluster-operator:PR-869-e32e9009

Test name
Status

storage
passed

upgrade-haproxy
passed

big-data
passed

haproxy
passed

scheduled-backup
passed

recreate
passed

scaling
passed

init-deploy
passed

scaling-proxysql
passed

self-healing
passed

security-context
passed

restore-to-encrypted-cluster
passed

upgrade-proxysql
passed

self-healing-advanced
passed

limits
passed

smart-update
passed

monitoring-2-0
passed

operator-self-healing
passed

affinity
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

users
passed

demand-backup
passed

upgrade-consistency
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

pitr
failed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/869/commits/e16ce4cd427e719e53c745c3115aa28122436d5f
image: perconalab/percona-xtradb-cluster-operator:PR-869-e16ce4cd

Test name
Status

storage
passed

self-healing
passed

self-healing-advanced
passed

scheduled-backup
passed

operator-self-healing
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring-2-0
passed

affinity
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

users
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

recreate
passed

restore-to-encrypted-cluster
passed

demand-backup
passed

pitr
passed

demand-backup-encrypted-with-tls
passed

big-data
passed

upgrade-haproxy
passed

scaling
passed

scaling-proxysql
passed

security-context
passed

upgrade-proxysql
passed

smart-update
passed

upgrade-consistency
passed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/869/commits/e32e90099d0fbe46e7b077b9aa83a3878711c05c
image: perconalab/percona-xtradb-cluster-operator:PR-869-e32e9009


How to change to PEFT model dynamically?

python==3.7.12
PEFT==0.3.0
@BenjaminBossan
I fine-tune the eleventh transformer of Bert as below:
target_modules = []
target_modules.append("11.attention.self.query")
target_modules.append("11.attention.self.value")

lora_config = LoraConfig(
    r = self.args.lora_rank,
    lora_alpha = self.args.lora_alpha,
    target_modules = target_modules,
    lora_dropout = 0.05,
    bias = "none"
)

After training for a few epochs, I also want to fine-tune the first transformer. How to achieve this?

This is not directly possible. What you could try is to add all the layers you want to eventually train into target_modules. Then, you go through the modules and manually disable the gradient of those you don't want to train:
target_modules = [
    "0.attention.self.query", "0.attention.self.value",
    "11.attention.self.query", "11.attention.self.value",
]
...
model = get_peft_model(...)
for name, module in model.named_modules():
    if name ...:
        module.requires_grad_(False)

I've never tried this, so not 100% sure if it'll work, but worth a try.

Yes, if you create more LoRA layers, the random seed will be ticked more often. But I don't understand what the big issue would be with that. Maybe you could show your code and explain what you expect vs what actually happens.

Just to know whether it's the reason of random seed.
Thanks a lot for your reply.


Sample that shows how to display toolbar item by default.

Currently the samples show you how to add a combobox or other toolbar item. Right now the user has to right click the toolbar and select the appropriate menu option to then display the toolbar item.
But how can you make that item appear in the toolbar automagically, when your extension is loaded for the very 1st time, for your specific project type?
A sample showing this would be great!

Thanks for trying this out and giving us feedback!  The feature you're asking for is not available in the new command model yet.  When we do implement it, we'll be sure to provide a sample showing how it can be done.


update docker workflows

Going to close this -- it's not possible to add the necessary prefix tag to our images via this official Docker action yet.


Update FillModel.cs

Made LimitFill element of StopLimitFill act in accordance with the LimitFill Model.
Motivation and Context
Previous StopLimitOrders were not being executed properly -- that is, they didn't properly follow Stop-triggers-LimitFill
Requires Documentation Change
No
How Has This Been Tested?
Unit test, see Issue 2904
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Please review tests.
Errors and Failures:
1) Test Failure : QuantConnect.Tests.Common.Orders.Fills.ImmediateFillModelTests.PerformsStopLimitFillBuy
     Expected: 101.75m
  But was:  101.66m

at QuantConnect.Tests.Common.Orders.Fills.ImmediateFillModelTests.PerformsStopLimitFillBuy () [0x001b6] in <c6c7ee11232e497da6791c122004581d>:0

2) Test Failure : QuantConnect.Tests.Common.Orders.Fills.ImmediateFillModelTests.PerformsStopLimitFillSell
     Expected: 101.5m
  But was:  101.66m

at QuantConnect.Tests.Common.Orders.Fills.ImmediateFillModelTests.PerformsStopLimitFillSell () [0x001b6] in <c6c7ee11232e497da6791c122004581d>:0```

Yes, working on pushing test changes


set might be enough

A typical idiom to get the unique elements of a list:
>>> a = [1, 1, 2, 3, 5]
>>> list(set(a))
>>> a
[1, 2, 3, 5]

On repl.it:

https://repl.it/@miku/DaringPoorCygwin

set doesn't work because of special cases. that's why i've implemented this uniq. i forgot to change the comment too.


RxNetty library version that Zuul 2 uses ( 0.4.x or 0.5.x)

Hi.
I plan to make a gateway solution, based on Zuul2.
Final release of zuul2 isn't Open sourced, so I test zuul 2.x.mdm version.
I found that Zuul 2.x.mdm version reference the RxNetty 0.5.2-SNAPSHOT library.
I understand that RxNetty 0.5.x version is not stable and should not be applied to the operating environment.
I would like to know which version of the RxNetty library the final release of Zuul 2.x uses.
Thank you.

The RxNetty libraries will be removed from the final Zuul 2.0 release. We found that we got more flexibility and simplicity in the Zuul 2 core by working directly with the Netty core than the RxNetty abstractions.


add support to screen-stream

If you felt like contributing your macOS ffmpeg config to screen-stream.

Great idea! Will do


How to match to route with multiple slashes?

I would like to build a simple file server returning a html file with a directory tree, but I can't find how I can make a route that takes a path with "/" in it:
router!(request,
    (GET) (/{path: PathBuf}) => {
        handle_path(path.as_path())
    },
    _ => Response::empty_400()
)

This route does not seem to match something like "localhost:8000/src/main.rs".
I would like to have several deep directories in my server root, so I would like to extract a full path from a route url. How would I do this with rouille?

Seems like match_assets does the job: https://docs.rs/rouille/3.0.0/rouille/fn.match_assets.html


[output] Fix for alert processor cli and pagerduty incidents

to: @ryandeivert
cc: @airbnb/streamalert-maintainers
size: small
Background
Related to https://github.com/airbnb/streamalert/pull/652, this is needed for testing alerts using the new format of the PagerDuty output and storing the service and escalation policies IDs.
Changes

Adding mocked service_id and escalation_policy_id in the alert processor CLI tests.

Testing
$ rm .coverage && ./tests/scripts/unit_tests.sh
...
----------------------------------------------------------------------
Ran 555 tests in 10.902s

OK

$ ./tests/scripts/pylint.sh

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

$ python manage.py lambda test --processor rule all
...
StreamAlertCLI [INFO]: (63/63) Successful Tests
StreamAlertCLI [INFO]: (34/34) Alert Tests Passed
StreamAlertCLI [INFO]: Completed

Coverage remained the same at 95.652% when pulling a9ab80e672f21b608acc957117874b4bd7a8dff6 on javier-fix-alert-cli-tests into 79c7f75ede009680e7a767a59b79e12879ae8183 on master.


ScoreAttempt enchantment

When a player score and there was an exist score and the difference between the new and older score shown in the new score's output.
Sorry for the bad english.

Hi,
thanks for your interest in this project.
I planned to add this feature and now the first version is finished (See Pull Request).
It will be merged and added to the running gema servers later today.
No problem with the description, I perfectly understand what you mean.

Hi,
thanks for your interest in this project.
I planned to add this feature and now the first version is finished (See Pull Request).
It will be merged and added to the running gema servers later today.
No problem with the description, I perfectly understand what you mean.


Hide newsfeed noise unfold button does not work

Description
The hide newsfeed noise option folds down releases and similar information like so:

However, the 'unfold button' to the right does not do anything.
Logs:
Error: Could not parse repoName from GitHub url: https://github.com/ [repo.ts:92](webpack://sourcegraph/shared/src/backend/repo.ts)
Browser extension is enabled [codeHost.tsx:600](webpack://sourcegraph/browser/src/shared/code-hosts/shared/codeHost.tsx)
SyntaxError: Element.matches: '#dashboard :is(.watch_started, .fork):has(a[href^="/klieret"]),#dashboard .body:has(.watch_started, .fork):has(a[href^="/klieret"])' is not a valid selector 12 [refined-github.js:4953](moz-extension://4db98c48-5dd8-4f6c-b2cd-478fd3054d36/refined-github.js)
SyntaxError: Element.matches: '#dashboard :is(.watch_started, .fork):has(a[href^="/klieret"]),#dashboard .body:has(.watch_started, .fork):has(a[href^="/klieret"])' is not a valid selector 5 [refined-github.js:4953](moz-extension://4db98c48-5dd8-4f6c-b2cd-478fd3054d36/refined-github.js)

How to replicate the issue + URL
Replicate: Go to your newsfeed, find release note, click 'unfold' button
Expectation: I can see details about the release
Reality: Nothing happens
Extension version
23.3.31
Browser(s) used
firefox 111.0.1 MacOs

This is because Firefox doesn't support the has() selector and there's no other way to target these elements.
The last related PR:

https://github.com/refined-github/refined-github/pull/6306

Ah, so the intended behavior was to hide both the details and the line we see above? And because firefox doesn't support the selector, it is left over?
Thanks for clearing that up 👍

For the future finders of this issue: You can enable :has() in Firefox as of today by going to about:config and enabling the layout.css.has-selector.enabled. This is not recommended, as the implementation is still buggy. For example, hide-newsfeed-noise will still not work because of a bug.
The alternative fix I am using is just to take the selectors from hide-newsfeed-noise.css and create a uBlock Origin filter with it. uBO ships its own implementation of :has()


Going through VersionedForeignKey for filter() has strange edge cases with as_of()

This test should illustrate the issue:
class FilterOnRelationTest(TestCase):
    def test_filter_on_relation(self):
        team = Team.objects.create(name='team')
        player = Player.objects.create(name='player', team=team)
        t1 = get_utc_now()
        sleep(0.1)
        l1 = len(Player.objects.as_of(t1).filter(team__name='team'))
        team.clone()
        l2 = len(Player.objects.as_of(t1).filter(team__name='team'))
        self.assertEqual(l1, l2)

For the first Player.objects.as_of()-query, we get the player object; for the second, we get no results.
My understanding is that VersionedForeignKey.get_extra_restriction() adds WHERE-clauses as appropriate wrt. version_start_date and version_end_date for the active querytime.  (Or for the "current" version if there is no active querytime.)
With the JOIN constructed by Django, we get a join on primary key, which would match only the newest version, and if the newest version is not the appropriate one for the querytime the WHERE-clause discards it, and we get no result where one was expected.
Unfortunately, I don't have any good solution to this; modifying logic that sets up joins so that as_of()-queries might join on identity instead of id (as the existing get_extra_restriction() should ensure that we get only one) where appropriate, without breaking table creation, without breaking the currently working queries through versioned many-to-many relations, would seem to require overriding a lot of methods on Query with only minor changes...  That might work, though it sounds rather messy...  Hopefully, you can come up with a better idea?

Hi @arild-haugstad,
thanks for your contribution. This is just to inform you that I've taken up your test case and I'm currently working on a solution to this issue. As you've mentioned, there are quite a couple of potential conflicts with existing tests.
I'll keep you updated as soon as I've got something usable.
-Manuel

@arild-haugstad I've written a fix in PR #50 for the problem you reported. I hope this enables you in proceeding to use CleanerVersion!
Thanks for contributing,
-Manuel


Add performance logging to database things

I was thinking/musing that it would probably not be too difficult to hijack the DAO/CMSCouch interfaces, connect them to the alerts interface, then connect the alerts interface to something like Graphite or RRDTool to get some #s on where things need to be optimized. Extra credit for (once we update to a recent version of couch) tracking how long our couch instances spend updating views.
I have an (unfounded) hunch that we have some views that we spend a lot of time building and then never call enough to justify burning all the CPU on. Getting some metrics for that would be nice.

seems interesting, but I don't think we''ll ever work on it (3 years have past) :-)
@ticoann should we close this one?


singleton_map is too limited

Thanks for picking up this very useful crate!  I learned about it on the forum.  While I understand why dtolnay wanted to abandon it, the limitations he pointed to don't apply to my use case.  For me, the crate is perfect.  Nearly perfect, anyway.
The singleton_map is useful for opting out of the new enum serialization behavior introduced in serde_yaml 0.9. But it's a little bit too limited.

It can't be used in combination with a field that needs another serialize_with attribute for some other reason
It can't be used within a struct that has a custom Serialize or Deserialize implementation.

Would it be possible to relax these restrictions? An easy way would be to simply make the SingletonMap structure public.  I can submit a PR if you'd accept such a thing.

I just saw the thread on the user forum, and chimed in in there. This is something I can try to take a stab at it.

This is fixed in https://crates.io/crates/serde_yaml_ng/0.10.0


[Task] Share link of the app with Angel and go over testing procedures

The frontend team should share the AWS link to the Shared Filing App with @angelcardoz after the current sprint so that he can ensure that the user stories have been completed to spec. We'll have to have a meeting with Angel to talk about how to test the app by asking devs for keycloak changes / AWS freeze during that process.

I think this old ticket about testing can be safely closed after all our bug bashes.


Removes redundant (?) More Information section.

Note that this also removes a jinja template variable -- more_resources -- in favor of just the more_information

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


isAutoRefreshDisabled parameter causes non-empty plan even after it was applied before

Hi,
For dynatrace_dashboard module I have hundreds of dashboards exported with provider. After switching from 1.16.0 to 1.22.0 version, each plan and apply contains changes regarding isAutoRefreshDisabled parameter:
tile {           + unknowns                    = jsonencode(                 {                   + isAutoRefreshDisabled = false                 }             )             # (7 unchanged attributes hidden)             # (2 unchanged blocks hidden)         }

Hello @pgudalewicz ,
The attribute isAutoRefreshDisabled for Dashboard Tiles was until recently not directly supported by the provider. For such attributes (that got introduced into the REST API, but are not yet part of the terraform schema) the unknowns attribute usually takes over.
We recently took care of that attribute - you are now explicitly able to specify auto_refresh_disabled for Dashboard Tiles. As a result the provider removes it from the list of attributes contained within the unknowns attribute - which is admittedly a bit inconvenient if you already have existing modules and want to keep your plan empty.
In your case you simply can get rid of the empty plans by removing the unknowns attributes from your tile resource blocks - at least that's how we expected users to handle situations like these, hoping that flow was acceptable.
But because you have hundreds of dashboard resources and I was able to come up with an easy solution, that doesn't require you to modify your modules, I went ahead and included it into our next release. We're planning to push out 1.23.0 still this week.


Add warning for missing uid in provisioned datasources

Some users reported confusion with data linking not working between logs/traces.
This is because a uid must be set for the datasource. All UI-configured datasources generate one automatically, but not all provisioned datasources have one. I have added a warning to the config page to remind users to add one.
Changes:

added warning banner when uid is not set
updated changelog

Example of what this warning looks like:

Thank you @SpencerTorres! Has this been reported internally or is there an open issue related to this?

This was something found internally with one of our users. There's no alternative fix so it seemed best to simply add a warning. I believe this would affect all datasources, perhaps a warning could be added at the Grafana level at some point


App insights Telemetry for Commands

Added a Telemetry package with App Insight resource (the infra would change and so the instrumentation key)
We have added for following commands :
Create
Query
Open
Config
It also capture if sqlcmd run from : legacy /modern.
Following is the snapshot of example commands triggered through sqlcmd and gettig logged in App Insight resource:

These basic method definitions are good for a POC.
It needs to be fleshed out, such as defining an interface for the internal telemetry implementation and using the dependency inversion infrastructure to pass the instance of the interface to the command implementations like we pass other services. We don't want to have all the commands calling a global singleton directly. Tests can provide a mock implementation of that interface to verify the commands log the expected telemetry when run.


Bad performance in Citrix env.

Hello,
one of our clients uses Citrix environment. I saw that Open Layers works very low on this env. I found old ticket http://osgeo-org.1560.x6.nabble.com/OpenLayers-2-13-how-to-avoid-animated-zooming-td5060774.html that animated zooming should generate the problem. Now we are using 5.X version. How we can disable "animated zooming"? Did anyone have a similar problem and can give me any tips? Thanks in advance.

You can set zoom durations in the default controls and interactions
https://openlayers.org/en/v4.6.5/apidoc/ol.control.html#.defaults (version 4 link as the documentation in later versions seems to be broken)
https://openlayers.org/en/latest/apidoc/module-ol_interaction.html#~defaults
for example:
import {defaults as defaultControls} from 'ol/control';
import {defaults as defaultInteractions} from 'ol/interaction';
  ...
  ...
  ...
var map = new Map({
  controls: defaultControls({zoomOptions: {duration: 0}}),
  interactions: defaultInteractions({zoomDuration: 0}),
  ...
  ...
  ...
});


Fixed auto location of vpnkit socket

Fixes https://github.com/moby/hyperkit/issues/253

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:yinzara/hyperkit.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

This PR maintains legacy behavior if the older versions of Docker for Mac are installed but supports the new location if the file exists.


Make SourceConn clonable and bump Arrow/Datafusion

Hi folks 👋🏻
We're using connector-x to build a remote table querying capability in Seafowl (an analytical, cache friendly, time travel-able database we're building on top of Datafusion).
Given that on one hand we rely on tokio async runtime, while on the other hand some of the DB drivers block the thread when executing queries, we're forced to run the queries in a closure using spawn_blocking.
In turn, instead of creating a single SourceConn upon instantiating the remote table, we're forced to instantiate a new SourceConn for each query execution,  since otherwise we can't pass the ref to the get_arrow function inside the closure due to lifetimes incompatibilities (borrowed data escapes outside of associated function).
Long story short, to mitigate this we'd really only need SourceConn to be cloneable (unless this is for some reason a bad idea?), as then we could get away with keeping a single one in remote table struct and clone it or it's fields when needed, hence this PR.
Additionally, I bumped Arrow and Datafusion to the latest available versions (26 and 14 respectively).

@wangxiaoying I think this should be fine. We are only making a string container clonable as far as I can tell for this PR. Would love to know your thoughts.

Hi @gruuya , thanks for the PR! To pass the CI, I made a minor change to align arrow version in rust with cpp and python crates. I'm going to close this PR and redirect to #399 .

Great, thank you!


Get current git revision using IFD if we are not on Hydra

This is much more reliable than looking inside .git, which can be in
weird states and is best not to make assumptions about.
Wonderfully, since Nix is lazy, we can do this despite IFD being
disallowed on Hydra: in that case we'll have declInput so we'll never
evaluate the bit that needs IFD.
XXX: does not work for worktrees yet

Perhaps there is a way to override when using work trees or alternatively just wait until someone tries to use a worktree and it fails and then think about fixing it.

I use worktrees but I don't build the playground server so often so I can live with it. Could also do an override.

Okay, I think this now works.
I am a bit aware of the downsides: every PR (including doc-only PRs) will now rebuild the playground jobs (which are slow!) on every commit. I wonder if we could somehow only apply the overlay when we're building them for the docker images?

this is essential in the deployed versions as well I think

Sure, I just want a "deployed version" derivation that's only referenced from those rather than from every time we do anything.

I guess that would actually work fine - i.e. we can do the derivation overriding that we do in the overlay separately. We'd need it in the overlay if there were packages that depended on the playground packages, but there aren't.

But that can be future work.

agreed, I was just typing something similar.


New lazy-load version

SUMMARY
Add some new features, bump required node version up to 8.0.0, and release as a new major version. Fixes #7.
DETAILS
lazyLoadTasks
A new lazy-load implementation of loadTasks (which loads all files containing grunt tasks from a local directory).
This implementation allows the user to specify the various files in the folder and which tasks will be loaded by each one.  See README updates for syntax.
lazyLoadNpmTasks
The engine behind the scenes has changed, but the existing API hasn't changed (anyone using the old grunt-lazyload should be able to upgrade with zero changes, as long as they are on node v8+).
renameTask
The lazy loader now tracks task renames for pending tasks, allowing you to perform multiple renames on tasks that aren't loaded yet and have them behave as expected when you run them.
TESTS

Existing tests tweaked due to the new behavior of the lazy loader (some assumptions changed).
Tests added for new functionality.

Let me know if there's any other changes you'd like to see before a merge. :+1:

release has been published to NPM


toObject in viewFor annotation

I'm trying to get an object from an ABFAnnottation, in the previous version I could get this object, but after the update I can not anymore.
func mapView(_ mapView: MKMapView, viewFor annotation: MKAnnotation) -> MKAnnotationView? {

        if (annotation is MKUserLocation) {
            //if annotation is not an MKPointAnnotation (eg. MKUserLocation),
            //return nil so map draws default view for it (eg. blue dot)...
            return nil
        }

        if let annotationABF = annotation as? ABFAnnotation {
            if annotationABF.type == .unique {
                if let element = annotationABF.safeObjects.first {

                    let object = element.toObject(MyObject.self)

                    // my custom pin configurations

                    return pinView
                } else {
                    return nil
                }

            } else {

                let view = ABFClusterAnnotationView(annotation: annotationABF, reuseIdentifier: "cluster")
                view.color = UIColor(red:0.093, green:0.741, blue:0.335, alpha:1)
                view.count = UInt(annotationABF.safeObjects.count)
                view.canShowCallout = true

                return view

            }
        }
        return nil
    }

Whenever it will do the toObject it hangs at this point
extension ABFLocationSafeRealmObject {
    public func toObject<T>(_ type: T.Type) -> T {
        return unsafeBitCast(self.rlmObject(), to: T.self)
    }
}

 fatal error: can't unsafeBitCast between types of different sizes

Snap! Same problem for me.

let object: MyObject =  annotationABF.safeObjects.first.rlmObject() as! MyObject
It's working for me.

Exactly the same problem here. Tried @cybkuz solution but the compiler was throwing force cast violation so I ended up having something like
 guard let object = annotationABF.safeObjects.first?.rlmObject() as? YourObject else {
      return nil
}

//do stuff with your object


Handling deletion of api and operator

Description:
At the moment when the user deletes an api or the operator; the related services, configmaps, secrets, jobs and other resources are not deleted. User will have to manually clean up all the garbage resources. The operator has to facilitate automatic deletion of related resources when user wants to delete a particular api, as well as if the user wants to delete the operator.
Suggested Labels:

Suggested Assignees:

Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:

This is added.


authedClient.getOrders return Internal server error

I run this:
authedClient.getOrders({ status: "open" }, (err, response, data) => {       console.log(err, data);     });
Got:
null { message: 'Internal server error' }

Cannot reproduce; although, the err shouldn't be null, and that's a dupe of #208 which was fixed in #210.
Try npm install coinbase/gdax-node to incorporate that particular fix.

I am using coinbase/gdax-node, and am getting Internal server error in sandbox environment, however live environment returns successful. Also curious, in the sandbox call that fails, response is null (I was expecting response.status to be 500). In that case err is populated with "Error: HTTP 500 Error: Internal server error"

I am having the same problem as dereksan. getOrders() is not working with the sandbox environment but it was working last week.

@rmm5t I was requesting to Gdax Sandbox. Maybe the production one works, just like @dereksan said.

This miraculously started working successfully again on its own. I can now perform getOrders on both live and sandbox.

Yes, it works again!  I will close this issue.

Hi, i'm using gdax node v0.8.0 and i'm experiencing a similar issue on getOrder() function.
The issue is random. It can happen only once in 5 days sometimes.
I tried to add some traces and found that an internal server error can occur with an HTTP code 200 from response.
This is not the expected behaviour, according to documentation.
https://docs.pro.coinbase.com/#requests
Internal server error may return an HTTP code 500.
2018-07-23 19:04:41 [19706] [verbose]: 	Refreshing order d69b3c5e-e2e2-4efa-9c14-469f64479a66 status ...
2018-07-23 19:04:41 [19706] [error]: 	Internal Server Error
2018-07-23 19:04:41 [19706] [verbose]: 	Got response HTTP 200 from exchange

In my case, HTTP 200 is returned by err.response.statusCode, not response.statusCode.
Do i need to consider any HTTP code from err.response as an error in all cases or is this a real issue ?
Thanks,
Regards.


Casting from and to ArrayBox variable type

Currently, I don't see a way to extract the real value wrapped up in ArrayBox typed variable. This would be convenient if one would like to use a package with higher precision. I.e. if one wants to use numpy.ndarray with bigfloat.BigFloat type, one can just iterate over ndarray do the calculation using bigfloat package, convert back to ndarray and continue on.
The error I'm currently facing states
TypeError: Unable to convert argument Autograd ArrayBox with value 0.01297563222656762 of type <class 'autograd.numpy.numpy_boxes.ArrayBox'> to BigFloat
Casting ArrayBox to ndarray returns:
TypeError: expected sequence object with len >= 0 or a single integer
So it would be nice if there was a way to cast ArrayBox variables in to any other numpy variable and vice versa. Even though it would make the algorithm slower in cases the conversion is used, it would be beneficial to have that option if needed.

The ArrayBox object has a _value attribute, where the real values are stored as a numpy array. But of course you will lost the gradients if useing the values directly.


Can't see a user's farms

My threebot ID on mainnet is 185 and my farm ID is 173655.
When you load farm management tab on the dashboard it fails to load farms. It tries to load following url:
https://explorer.grid.tf/api/v1/farms?owner=185
but it should not go to api/v1 for the farms, instead it should be:
https://explorer.grid.tf/explorer/farms?owner=185
This is because the capacity pools is not live on mainnet yet!

@DylanVerstraete when you create issue maybe its better to start the title, with the platform tested / where you found the issue,
e.g. Explorer: Can't see a user's farm


REALLY need a way to sanity check a bash command before executing

Lots of times there's a syntax error before submitting. We need to check the bash script before submission.

Nevermind, I'm a couple days late ;)

Complete


Is your BBMetalVideoWriter support 4k video recording along with 60fps ?

Is your BBMetalVideoWriter support 4k video recording along with 60fps ?

Sorry, now it doesn't work well for 4k 60FPS. Some frames are dropped.

Thanks , do you have any suggestions or solutions? if have then it will very helpful to me on way to change in creating custom video writer


[Feature]: drop the requirement to install @react-native-vector-icons/common

Is your feature request related to a problem?
My suggestion is to simplify installation instructions by not requiring to install the common package.
Describe the solution you'd like
Current state
The common package exposes two utility functions  which are available on the individual Icon components. Historically (if I remember correctly), these would mostly be used with legacy components in React Native core which no longer exists such as ToolbarAndroid and TabBarIOS.
AFAICT, the use cases for these functions are limited these days, and 99% of users don't need them. The functions could be extracted into another package where people who do need them could use them from there.
Pros and cons
The benefit of doing this is removal of native code from the typical usage path, and not requiring users to install the extra package - the individual icon packages would still depend on it, and package manager would install it. (The reason it's not done this way already now is probably because React Native CLI tooling links only the native modules which are listed in the root package.json file - so installing it explicitly is now a requirement.). This would make usage easier.
The only downside AFAICT is that it's a breaking change on an API that has been around for a long time.
Describe alternatives you've considered
No response
Additional context
No response

i think they'd be a great fit for a separate package related to font handling, such as expo-font. one change we could make here that would be less disruptive is to move them to a react-native-vector-icons subpackage like @react-native-vector-icons/get-image-source - so people could install this if they need those utils, and as @vonovak pointed out, we can then just make the common package a dependency of each vector-icons subpackage so we don't require that people install @react-native-vector-icons/common just to use a single icon family

I like this general idea as it solves for the 99%.
I sort of wish we'd thought of it before the 11.0 release :smile:
@oblador Any thoughts?
I might have a go at making this work over xmas. We haven't sent any general announcements about the new release yet so we could squeeze this in before we do that.

Fun fact, when I originally wrote this lib one of my goal was not requiring a native library - which is still the case only autolinking kinda made this an opt out rather than opt in.
Question is, for non-expo cases, we kinda still want it for ease of integration right @johnf?
For the API part, I think we can keep it as is but using an optional import and throwing an error if not present, just like we do if native module isn’t linked.

@oblador I had a quick look the other day and the only native code still left is getImageForFont and getImageForFontSync.  So thinking along the lines above I think we could

Remove the native code from common and only have the common js as a straight dependency
Move the code into get-image
Update the docs to not require installing common
Update the docs to tell folks using getImageForFont that they need to install an extra node module
Modify getImageForFont to throw an error if get-image is not installed

@vonovak @brentvatne I was thinking about this some more this week, and I realised I forgot something, so I'm not convinced this is a good idea anymore.
The common package is also responsible for copying the fonts. It detects which font packages are installed and copies them to the right place. It does this via Gradle on Android and script_phase on iOS.
This functionality is essential for most use cases, especially on Android, as it makes the whole setup zero-touch once you install the packages.
Thoughts?


Web root should placed under public

I understand, that you wouldn't have access to node_modules folder that way.
But now I successfully downloaded .env file!!!

Hope you understand what can I do then.

It aimed for shared hosting user. Almost Shared Hosting cannot use command line in server. It server is the cheapest and a lot of our citizen uses the shared hosting.

Almost all of shared hostings, have SSH.
But, it actually doesn't matter, because I use it only for show you.
Really, I had downloaded .env with web-browser.
Again, I need to take my bash, to show you another thing:

This is right perms:

Advise you to do this
find . -type d -exec chmod 755 {} +
find . -type f -exec chmod 644 {} +
And then set X perms only to files really need it.
Also you'd better to add this to .htaccess file:
<Files .env>
    Order Allow,Deny
    Deny from all
</Files>

noted it.


Heatmap: double[,] opacity

We recently added a global opacity property (#2484) but there is interest in being able to customize the transparency of each square (#2461, #2435). If this isn't already a feature, perhaps it should be...
Thanks @bukkideme and @HaveHair for suggesting it

Oof, nevermind, Update() already accepts double[,] opacity as an argument
https://github.com/ScottPlot/ScottPlot/blob/32896522327192af322c2f3c0129e1205ecf5799/src/ScottPlot4/ScottPlot/Plottable/Heatmap.cs#L203


include ember-get-config v2 in supported version range

Going to have to invest some time into why the tests are failing, or change the supported version 😦

I dont have a problem with the change.
Because of ember-data changes, we are going to have to make changes here that mostly will not even require ember-get-config anymore

Thank you @jelhan! This has been already updated in master as part of some other changes


Licensing

If we're interested in forking and using some of your code, is there a particular open source license you plan to release this under?

@CrafteeD Hi.
It's a public domain project. You can edit or release your own version of it freely.

@pjc0247 Thanks for the response!
Do you think you could help out by adding a license file that matches that intent to the repository?
The MIT license should be a good fit:
https://opensource.org/licenses/MIT
It would really help out - thanks!

@CrafteeD Sure!
https://github.com/pjc0247/jenkins-client.net/commit/81d36c15ac718a4abc7ffea81724bbef99f7ae9e

Thanks @pjc0247, that really helps!