bot doesn't do anything after start

I did all the step and when I start the server it still doesn't do anything except start the extension.

It stopped after the last line and nothing happen in the game. I use the AngelHaloNew scenario btw.

Here is the screenshot when I try the old halo one.

Do you use the master or dangerous branch?

I think I use the master one, I don't know where is the dangerous branch.

https://github.com/Frizz925/gbf-autopilot/tree/dangerous
If you use Git for pulling the source codes, just run git checkout dangerous and re-do the building steps.

Okay I will try it now, I will let you know if it work, thanks.

Thanks, the bot work now, but I still have trouble with the scenarios, I tried both the halo js but at the first step instead of clicking on halo it keep clicking the primarch trials instead, and then when I tried again it just click randomly on screen (sometime crew button, sometime event), is there any game setting I need to do for the bot to run properly?

You need to set the game size to medium and 100% window zoom and display scaling (Windows 10 display options)


#requires reports misleading error when used with an unsupported argument (e.g. due to a typo)

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
Put the following in a script file and run it; note the misspelling of 'Administrator':
#requires -RunAsAdminstrator

Expected behavior
An error message along the lines of:
Unknown #requires parameter: -RunAsAdminstrator

Actual behavior
Parameter RunAsAdminstrator requires an argument.

That is, the error message falsely suggests that the misspelled parameter is actually recognized and recommends a confusing, ineffective resolution.
Error details
No response
Environment data
PowerShell 7.4.0-preview.4

Visuals
No response

@mklement0 this seems like a problematic idea.
In general, I'm not in favor of anything more in the PowerShell syntax reporting an error for an unknown circumstance.
A warning, maybe, but an error presets problems.
As it currently stands, #requires could be used for much more than it currently is.
For example, one could put a #requires npm package or #requires go package, and that could be honored by ecosystems built atop PowerShell, such as PipeScript or Braid.
If the @PowerShellTeam starts throwing errors for every typo, that constraints the possibilities of the ecosystem, as it constraints the syntax of PowerShell's entire ecosystem.
Also, I believe this sort of thing is what the feedback providers feature are meant to address.

@StartAutomating You misunderstand the request. PowerShell is already showing an error for typos like: #requires -RunAsAdminstrator the request is just to make the error message accurate.


Table not helpful B1

Hi there,
The main headline say "privileged" and the Table "B-1: Built-in and Default Accounts and Groups in Active Directory"
is a simple List of default Groups and accounts.
That is not helpful to identify privileged Groups and accounts.
Every admin can see these accounts List, by simply spinning up a new AD Test-Server....

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1329c1d1-c6bd-6005-39e3-f04763735ae4
Version Independent ID: 0915e4bb-7383-b971-9f9b-7aba95ab501c
Content: Appendix B - Privileged Accounts and Groups in Active Directory
Content Source: WindowsServerDocs/identity/ad-ds/plan/security-best-practices/Appendix-B--Privileged-Accounts-and-Groups-in-Active-Directory.md
Product: windows-server
Technology: identity-adds
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

Understood but many like it. #please-close


Design Topics around services + messaging

So here are a couple things I am realizing as I am working on services and stuff. This should probably be a couple issues/action items, but I am dumping my thoughts here instead of in chat.
We should think about our use of alloc in kernel services
Originally, I loosely had the plan that "services can alloc when starting, but shouldn't alloc later". This is why you see all the "how many clients/messages/frames does this service take" in register() calls.
On one hand: it'd probably be good for smaller systems to have bounded memory usage, more or less just acting like a bump allocator on startup, and not requiring variable runtime allocation.
On the other hand: It's sometimes a pain in the butt to actually do this/very convenient to alloc whenever.
I dunno if there is a "right" answer, but picking one and being consistent is probably a good thing.
Messaging should be easier/better encapsulated
There's a LOT of impl details exposed to every service. The core interface is:

Servers receive messages (from many clients)
Servers optionally reply to messages

There is SOME shenanigans whether the message types are Serialize or not, that limits whether a server can advertise ONLY to other kernel client entities, or (in the future) userspace or proxied/remote client entities, but right now there are a ton of Message/Envelope whatever whatever types that are kinda gross to actually use.
This could probably use some better encapsulation, and nicer APIs on both the server and client side.
Service definition should be more consistent
I'm sort of learning how services "should be" as we are writing them.
I think at the moment, my best practice guide is:

Services should be defined (whenever possible) in the kernel
Services should provide a reasonable client implementation
RegisteredDriver should be implemented on a "nothing" type, that can be used to get a client Nothing::from_registry() -> NothingClient or so.
Services defined in the kernel SHOULD NOT provide a Server implementation, unless they only rely on other services (like SerMux does).

There's no way to have multiple of something
For example, if you have 5 UARTs, you can't register 5x SimpleSerial services.  It is unclear how this would work in practice when you want a specific serial port, like one that is wired up to a coprocessor or something.
I'm not certain this is a problem to solve, but it does force a specific design pattern, and will be more relevant as we have more resources in the future.
As a counterpoint to "you want a specific item", like UARTs, things like DMA channels on the D1 are a case where you want "any one of 16 items" that could all work.

We should think about our use of alloc in kernel services

Another "lesson learned" for me is that, with the async mnemos-alloc API, the failure mode for OOM conditions is "a task trying to allocate memory waits forever". When some allocations are dynamic and short-lived, this isn't terrible, as that memory may later be released and the task can just wait until its available. However, if the allocation occurs while initializing a kernel task that lives for the entire runtime of the OS, such as a driver service, and the only other existing allocations are for similarly long-running driver services, the whole system just gets completely stuck. And, because the allocator doesn't have any logging or similar diagnostics, there's no way to determine why the system is stuck.
It might be advantageous to add a mode switch to the allocator which makes allocations panic if there's no available memory, rather than wait for it to become available. We could have the kernel switch modes so that during initialization, if there's not enough heap space to initialize all the driver services, the system panics so that the kernel developer knows we can't run all the necessary kernel driver services in the current heap configuration. Once we've finished initializing driver services and are running user tasks, we would switch to the current mnemos-alloc behavior and always wait on OOM conditions.
Alternatively, we could just add a fallible try_alloc_FOO family of methods to the heap, and have driver services prefer to use those over the asynchronous alloc_foo methods during their initialization.

I think if we stick with the async allocator, it would make sense to do one or both of:

Add a way to "block on" the initialize items to complete, or reach some level of readiness (todo: how to determine this?)
Add a flag to force the allocator into "now or never" mode, where OOM panics, until we are done with the initialization phase.

Reading a little bit about how the linux kernel handles allocation, it might make sense to have a couple of allocation features anyway, especially if/when we ever get to caching and paging of memory, where having something async (like resident memory wired) might make more sense to have async options, in addition to immediate mallocs.


Missed a couple links in DSL2 docs update

We should replace these with commit URLs, but I don't have time atm


Limit on number of logic apps connected to On Premise Data Gateway?

Is there any limit on number of logic apps connected to Data gateway? In the documentation, it is mentioned that the amount of data sent can affect the results. How to measure the limit in this case and where to stop?
I would also like to know best practices for using data gateway for different app services. If I have a enterprise Data Gateway, is it okay to use a single data gateway for different services like Logic Apps, Power Bi and Power apps etc?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0deaa8b2-66a2-b45c-3ecd-7ea2d08503ed
Version Independent ID: 364890ed-d3ba-9e01-c40a-ce78600319f1
Content: Install on-premises data gateway - Azure Logic Apps
Content Source: articles/logic-apps/logic-apps-gateway-install.md
Service: logic-apps
GitHub Login: @ecfan
Microsoft Alias: estfan

@PawandeepK001 , can you please share me the documentation Link which you are referring here to help you better?

I am referring to FAQ section in this documentation: https://docs.microsoft.com/en-us/azure/logic-apps/logic-apps-gateway-install#general
there is a question on network bandwidth.

@PawandeepK001 Logic Apps aren't really connected to the gateway as such but any connectors that require access to on-premises data have their requests routed through the gateway when executed. Technically, there is no limit on the number of connections that I am aware of. And the requests are really sent via a service bus queue.
I believe, depending on the expected load, having separate gateways for data sources with high volume of requests would be best. Also, you should consider setting up high availability for your gateways as well.

@PawandeepK001 Just following up here... Hope my previous comment clears things up.

@PawandeepK001 Hope my previous comment clears things up.
Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Fix repo url for npm page and cleanup package.json.

Hi!
This PR fixes the repo url for the npm page and cleanup package.json.

@jdalton Thanks!


Cannot read property 'Item' of undefined

Hi!
Once I try to run this directive - without doing anything, just injecting it - I receive this:

any clue how to solve this?

👍  I'm having the same issue.

So I got it to work...
bower install jquery jquery-bridget --save and then move them above angular-masonry.
So you have something like this:
{
  "name": "yourapp",
  "version": "1.0.0",
  "dependencies": {
    "angular": "~1.5.0",
    "jquery": "^2.2.3",
    "jquery-bridget": "^2.0.0",
    "bootstrap-sass-official": "~3.1.1",
    "bootstrap": "~3.1.1",
    "bootstrap-social": "~4.9.1",
    "angular-resource": "~1.5.0",
    "angular-cookies": "~1.5.0",
    "angular-sanitize": "~1.5.0",
    "angular-bootstrap": "~1.1.2",
    "font-awesome": ">=4.1.0",
    "lodash": "~2.4.1",
    "angular-socket-io": "~0.7.0",
    "angular-ui-router": "~0.2.15",
    "angular-validation-match": "~1.5.2",
    "angular-masonry": "^0.16.0"
  },
  "devDependencies": {
    "angular-mocks": "~1.5.0"
  },
  "resolutions": {
    "angular": "~1.5.0",
    "jquery": "^2.2.3"
  }
}

@macdonaldr93 this still isn't working for me :cry:

@aviadhahami are you using wiredep by any chance?

I ended up having to add overrides to my wiredep too. Forgot to include that. Here's what my gulp task looks like now.
// inject bower components
gulp.task('wiredep:client', () => {
    return gulp.src(paths.client.mainView)
        .pipe(wiredep({
            "overrides": {
              "isotope": {
                "main": [
                  "js/item.js",
                  "js/layout-mode.js",
                  "js/isotope.js",
                  "js/layout-modes/vertical.js",
                  "js/layout-modes/fit-rows.js",
                  "js/layout-modes/masonry.js"
                ]
              },
              "outlayer": {
                "main": [
                  "item.js",
                  "outlayer.js"
                ]
              }
            },
            exclude: [
                /bootstrap-sass-official/,
                /bootstrap.js/,
                /json3/,
                /es5-shim/,
                /bootstrap.css/,
                /font-awesome.css/
            ],
            ignorePath: clientPath
        }))
        .pipe(gulp.dest(`${clientPath}/`));
});

@macdonaldr93 No wiredep on my end.
I got this to work by explicitly calling the masonry.pkgd.js like this:
<script src="bower_components/masonry/dist/masonry.pkgd.js"></script>
and also by re-arranging the items as you suggested.
Thanks for that :+1:

np! So I guess this issue is good to close @aviadhahami ?

@macdonaldr93 Yes, for me it is solved, it this isn't a robust solution...
But I guess you can close this :+1:
Happy Passover!

True true, I was reading further and it looks like the problem is with masonry and not this fork of it.
You too!

Thanks @macdonaldr93 your combined suggestions fixed the issue for me


SDL1: when we come back from iconification, the window is not active by default.

Title says it all, currently in SDL1 when we do iconify application and then iconify it back, then it not active by default. SDL2 realisation of iconification is ok in that terms, window active after de-iconification, so its only SDL1 issue.

It works now, thanks !


⚠ Bofrost.de has degraded performance

In b649b44, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 903 ms

Resolved: Bofrost.de performance has improved in 0099dd0 after 6 minutes.


Attack threshold not updated when base stat is changed

Investigation found that sheet was correctly applying skill proficiency bonuses


Further tests for HTTP header filtering.

Some more stuff that we could/should test, but does not block the release of the feature.

[x] Client sending multiple matching requests in the same connection.
[x] Multiple requests in one connection, where some of the requests are unmatched.
[ ] Valid HTTP responses to unmatched requests after invalid HTTP responses by buggy application on the same connection.

Please add to the list if you have more ideas (and check off the list any tests that were implemented).

I think we have this already? @Razz4780

I think we have this already? @Razz4780

I think first two cases are covered by E2E, but I don't recall seeing the third one.

I think we can close - seems to be enough coverage and will add as we go.


Modify Get-NetSessions / Add function to get disk sizes and free space

Add the things mentioned by Alby_Bara in the comments on https://www.powershellgallery.com/packages/FileShareUtils

I added a new function: Get-NetShareDiskspace
Also Get-NetSessions has now a level option


Included cleanup check in hyperconverged test-suite

Signed-off-by: swarna<EMAIL_ADDRESS>
What this PR does / why we need it:

Enhance ansible playbooks to deploy applications on their own namespace and set flag for cleanup result.(Hyperconverged test-suite)
Stern logger moved to prereq.yml
Runs each application on its own namespace
Performs apply/delete applications using modularization by passing required arguments.
-Cleanup gives out result by setting flag"Cleanup Pass" or "Cleanup Fail"

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
@ksatchit Updated the changes for percona-diff-NS and drain-node and scaleup-cassandra-pods playbooks. Can you please review it.

cassandra-scaleup.txt
Ansile-lint output:
devops@devops-virtual-machine:~/openebs/e2e/ansible/playbooks/hyperconverged/test-scaleup-cassandra-pods$ ansible-lint test-scaleup-cassandra-pods.yml
devops@devops-virtual-machine:~/openebs/e2e/ansible/playbooks/hyperconverged/test-scaleup-cassandra-pods$

@dargasudarshan Implemented the review comments, Please review it.


Multi lidar localization question

Hi,
is it possible to use ndt_mapping and ndt_matching with multiple LiDAR configuration?
For example, for large scale vehicle I can't just put LiDAR on top of it because of beams intersection with vehicle, but I can put LiDARs on each side of the vehicle. Is this case supported? If not, my intuition is to union all point clouds into one point cloud and probably make such transformations to each point cloud that they seems to belong to one virtual LiDAR in the center of the vehicle. Does it make sense? I highly appreciate any advice.

@greenfield932 Yes of course, please use points_concat_filter to merge and apply transform points provided from each lidar. You need pointcloud and /tf between each frame_id.
https://github.com/CPFL/Autoware/blob/master/ros/src/sensing/filters/packages/points_preprocessor/nodes/points_concat_filter/points_concat_filter.cpp
For now, we can use up to 8 lidars in develop branch. #1254

@aohsato, thanks a lot!


Games - Schedule

We require a way for games to be run at a specific time after they are created.
Ex: Admin / Event Coordinator Creates a game and wants it to start in 1 hour.
Solutions:

Manual: Add a start now feature that will allow admins / event coordinators to kick a game of manually
Automated: Add a scheduler system chime is a simple Clojure solution to this problem.

This works as expected but isn't super user-friendly. The scheduled time must be provided in UTC (in Swagger), and it's easy to enter an incorrect time (i.e. one that has already passed). Might be good to prevent the user from creating a game with a start time in the past?
Manually starting a game is also broken since implementing schedule (known issue). See #264.
With all that in mind, moving this to closed.


feat: make kk menu more reliable

Description

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

High Risk PRs Require 2 approvals

What protocols, transaction types or contract interactions might be affected by this PR?

Testing

Engineering

Operations

Screenshots (if applicable)

#6550  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gomesalexandre and the rest of your teammates on  Graphite


docs: add info about dangling negs

Explain how to destroy the environment in case there are dangling NEGs even after deleting the cluster.

@laurentgrangeau Can you review this one as well? Thanks!


Excluding network errors from upstream_rq_5xx

ATitle: Exclude network errors from upstream_rq_5xx
Description:
Envoy's stats classify per try timeouts (and presumably other network errors) as 5xx style errors. Pre-try timeouts are not actually 5xxs from upstreams, and I need to track those separately. Is there an established mechanism for distinguishing them (there seems to be this in the context of outlier detection)?
> grep mycluster stats.txt | grep -E 'per_try_timeout|upstream_rq_504'
cluster.mycluster.external.upstream_rq_504: 658
cluster.mycluster.upstream_rq_504: 658
cluster.mycluster.upstream_rq_per_try_timeout: 658

Additionally, is there any documentation or discussion we can refer to about these classifications?

There isn't any way to do this today though it's a reasonable feature request.

Additionally, is there any documentation or discussion we can refer to about these classifications?

I don't think so. Whatever we have would be here: https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/router_filter#statistics. It would be great to do a doc PR if you are so inclined to make the current behavior more clear.
In terms of the "why," in general my philosophy (which is where this originally came from), is that if a decision that Envoy makes on behalf of an upstream leads to a failure, the failure should be charged to the upstream. This has worked well in most operational deployments that I know of.

Thanks -- that philosophy is certainly understandable.
I think I'll probably do a little grepping of the codebase to reason about
what the various relationships between the stats are and then open up just
such a PR.
On Sun, May 15, 2022 at 11:32 PM Matt Klein @.***>
wrote:

There isn't any way to do this today though it's a reasonable feature
request.
Additionally, is there any documentation or discussion we can refer to
about these classifications?
I don't think so. Whatever we have would be here:
https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/router_filter#statistics.
It would be great to do a doc PR if you are so inclined to make the current
behavior more clear.
In terms of the "why," in general my philosophy (which is where this
originally came from), is that if a decision that Envoy makes on behalf of
an upstream leads to a failure, the failure should be charged to the
upstream. This has worked well in most operational deployments that I know
of.
—
Reply to this email directly, view it on GitHub
https://github.com/envoyproxy/envoy/issues/21295#issuecomment-1127178858,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOK43LXF3H3CWT2LOAAVITVKG6UFANCNFSM5V4VELOQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


Add inexistant columns in documentation test

Describe the feature you'd like
If a column in the properties file is not in the related model, this will not be catched by dbt, and may cause the documentation to be out of sync with the model exposed in the database. It would be super helpful for me to have this as a pre-commit check that ensures that all columns in the documentation are in the model.
Additional context
In the catalog.json, dbt stores all the existing columns in a model, which could help to identify which columns in the properties file are not in the model.

Hi @qmoret, correct me if I am wrong but I think that this hook should check that - https://github.com/offbi/pre-commit-dbt/blob/main/pre_commit_dbt/check_model_has_all_columns.py.

Oh indeed apologies, I hadn't seen that it was also checking for deleted columns, that's great !
In my case we have only a fraction of our columns that are documented, so the full hook would be an overkill. But we would still like to check that those that are documented are not deleted. Maybe the hook could be split in two ?


Support MIDI

Some mad lad finally did it. A MIDI inscription.
Not sure how to support it. Maybe a JS MIDI library, similar to how we render PDFs?

audio/mod too. I want to support these bad boys so bad:
https://ordinals.com/inscription/a84e1bf6e5184cafe55c831613c0c992ab058079350966b46fe76b5e25394a8ei0


[meta] Cannot /assign to the users recommended by k8s-ci-robot

The bot gives bad advice and/or code OWNERS files are out of date. See here: https://github.com/helm/charts/pull/10305#issuecomment-450540277

Yes, I noticed the same in my minio pull request

I think this is something for @mattfarina or @unguiculus maybe. Nobody noticed the issue until now.
We think the k8s bot configuration has an issue and OWNERS assignments don´t work at the moment.

The issue here is that the https://github.com/helm/charts#owning-and-maintaining-a-chart process was not followed. The person being recommended was not added as a collaborator.
#12501 should fix this instance of the problem.


With ActiveMQ version: Video stream can continue if browser terminates

It appears that the video traffic between the NVR and loud can sometimes continue if a browser hosting a video id terminated uncleanly.

Fixed. NVR was ignoring close socket messages.


Scan for duplicate frames and delete?

Not a bug but is there an option to scan for duplicate frames and delete them?

Sometimes people might want duplicate frames, like if their gif is 2 fps but they want a frame on for a second.

Nevermind, texture packer does this.


Add a temporary 1ES hosted pool with pre-provisioned machines

The runtime team would like their own exclusive pool to work on their migration to the 1ES pipeline templates.
They would like to have machines instantly available when they queue their builds and not have to wait for machines to spin up, so this pool will need to have machines pre-provisioned, just like the netcore1espool-publishing-internal pool.
Note that the helix-machines deployment code does not yet support adding pre-provisioning to the pool.

Release Note Category

[ ] Feature changes/additions
[ ] Bug fixes
[ ] Internal Infrastructure Improvements

Release Note Description

I believe we mentioned keeping 5 machines around? We'll need to figure out how pre-provisioning works with multiple images, maybe we'll need to keep 5 machines around for each image that the pool uses?

the helix-machines deployment code does not yet support adding pre-provisioning to the pool

… yet. @epananth is working on this in her #2082 work.

maybe we'll need to keep 5 machines around for each image that the pool uses?

that will be a significant sunk cost, albeit short term


Default values disappear from field

Great tool! Noticed that when you set a default value for a key, the "Default" checkbox is checked but the value "disappears" from the UI.
On export, the default values are defined in the entity though.
Nice work overall and very useful. Thanks!

Thanks for reporting it @batlanyard. Will publish the fix tomorrow night (23:00 GMT) max.
Hope you are enjoying it :)

Strangely enough I have tried to reproduce it many times but I could not!

I noticed it when editing a model I'd already created. Maybe it's the reopen to edit? I also find that the .rmd files are not selectable on the "Open" dialog from the app.
Just passing info along!

Hi @batlanyard, sorry for the late reply. I also tried to reproduce it using a saved document but could not reproduce.
If it is possible to list the steps which leads to the bug please do, maybe there is something I am missing.

Sorry for the delay as well! Here's a short screen capture of what I'm seeing. The default values are not shown once set (in the space next to the default checkbox):
https://db.tt/k4ecsbs6

Hi @batlanyard,
You can try the latest version (0.0.3) it should be fixed now.


rust-rgb20 build problems

When I execute git checkout v0.8.0-rc.3 , the dockerfile disappears.
Based on 1, I execute git checkout master and docker build -t rgb20:v0.8.0-rc.3 ., but there is an error.

It seems you've opened the issue on the wrong repository. I think you are referring to https://github.com/RGB-WG/rust-rgb20/tree/v0.8.0-rc.3. Moreover, please notice that the rust-rgb20 repository has been archived, you should look at https://github.com/RGB-WG/rgb and https://github.com/RGB-WG/rgb-schemata


Mat-select overlapped with mat-label

Reproduction
Use StackBlitz to reproduce your issue: https://stackblitz.com/edit/angular-buq6rw?embed=1&file=app/select-overview-example.ts&view=preview
but download the source code and run it local in safari

Steps to reproduce:

use simple mat-select with mat-label and mat-form
create the component
add setInterval with logic that adding in the array that include values and update the mat-select value at the same time

for the summary open the stackblitz link and download the source code then run it localy in the safari
Expected Behavior
the mat-label should be above the mat-select value
Actual Behavior
mat-label value overlapped with mat-select value
Environment

Angular: 8
CDK/Material: 8.0.2
Browser(s): Safari
Operating System : macOS

I have the Same issue Thanks for the reproducing it.

That's because the app that you're downloading from Stackblitz doesn't include a theme. There's even a warning about it in the console:
Could not find Angular Material core theme. Most Material components may not work as expected. For more info refer to the theming guide: https://material.angular.io/guide/theming


sv -added application.properties file under test/resources to ignore the data.sql file during tests

In this PR we added application.properties file under test/resources to ignore the data.sql file during tests

What purpose does this serve? While I understand that we don't need the placeholder data in the database during the tests, is there a particular test that fails if we don't include this change?

Unfortunately, we were unable to get this approach to pass on CI.   We will need to work on this more over break and try again in W21.
In the meantime, we will need to use a different work around to solve the problem this was designed to solve, namely that sometime the mvn test suite fails when you have the data.sql file in place.
Namely: if the tests are failing with data.sql in place, just rename data.sql to data.sql.SAVE before running mvn test.


Inject transactions from past eras when forging a block

When the mempool verifies transactions, it injects transactions from past eras
into the current era. However, block production was not doing this.
Debugging this was made more difficult because the trace message that we were
outputting after creating a block (TraceAdoptedBlock) recorded the
transactions from the mempool, not the transactions that were actually included
in the block.
This means that injection now happens 3 times: once when we add transactions
into the mempool, once when we revalidate the mempool when we produce a block,
and then a third time when we actually construct the block. Streamlining this
however we can do at a later stage.

Oh and feel free to squash these little fixup patches too of course.

One test failure.
Looks unrelated to this PR, but perhaps is related to the recent patch to support wall-clock times moving backwards by a small amount?
    delayClockShift:                         FAIL (0.31s)
      *** Failed! Falsified (after 78 tests and 5 shrinks):
      Schedule {getSchedule = [11.5,9.5]}
      Expected exception but got [SlotNo 0,SlotNo 11,SlotNo 12,SlotNo 13,SlotNo 14,SlotNo 15,SlotNo 16,SlotNo 17,SlotNo 18,SlotNo 19,SlotNo 20,SlotNo 21,SlotNo 22,SlotNo 23,SlotNo 24,SlotNo 25,SlotNo 26,SlotNo 27,SlotNo 28,SlotNo 29,SlotNo 30,SlotNo 31,SlotNo 32,SlotNo 33,SlotNo 34,SlotNo 35,SlotNo 36,SlotNo 37,SlotNo 38,SlotNo 39,SlotNo 40,SlotNo 41,SlotNo 42,SlotNo 43,SlotNo 44,SlotNo 45,SlotNo 46,SlotNo 47,SlotNo 48,SlotNo 49,SlotNo 50,SlotNo 51,SlotNo 52,SlotNo 53,SlotNo 54,SlotNo 55,SlotNo 56,SlotNo 57,SlotNo 58,SlotNo 59,SlotNo 60,SlotNo 61,SlotNo 62,SlotNo 63,SlotNo 64,SlotNo 65,SlotNo 66,SlotNo 67,SlotNo 68,SlotNo 69,SlotNo 70,SlotNo 71,SlotNo 72,SlotNo 73,SlotNo 74,SlotNo 75,SlotNo 76,SlotNo 77,SlotNo 78,SlotNo 79,SlotNo 80,SlotNo 81,SlotNo 82,SlotNo 83,SlotNo 84,SlotNo 85,SlotNo 86,SlotNo 87,SlotNo 88,SlotNo 89,SlotNo 90,SlotNo 91,SlotNo 92,SlotNo 93,SlotNo 94,SlotNo 95,SlotNo 96,SlotNo 97,SlotNo 98,SlotNo 99,SlotNo 100,SlotNo 101,SlotNo 102,SlotNo 103,SlotNo 104,SlotNo 105,SlotNo 106,SlotNo 107,SlotNo 108,SlotNo 109]

Squashed and fixed the test failure. Unfortunately, reintroducing the assertion based on HasTxs is not trivial (a known problem we forgot about), so I'm leaving that out for now.

bors merge


Segmentation fault in tf.image.combined_non_max_suppression

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: N/A
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): v1.12.1-38999-g56548c2425 2.4.0-dev20200811
Python version: 3.7.6
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source): N/A
CUDA/cuDNN version: N/A
GPU model and memory: N/A

Describe the current behavior
A segfault occurs when max_total_size is large.  If I execute the same input repetitively, I get different errors in different executions such as Segmentation Fault, what():  vector::_M_fill_insert, and what():  terminate called recursively.
Describe the expected behavior
I would expect a runtime exception in python rather than a segfault.
Standalone code to reproduce the issue
import tensorflow as tf
tf.image.combined_non_max_suppression(boxes=tf.ones((11,8,2,4)), scores=tf.ones((11,8,2)), max_output_size_per_class=5, max_total_size=311452676677046672)

Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.
Segmentation fault (core dumped)

what():  terminate called recursively

what():  vector::_M_fill_insert

@mjkim720
I ran your code on 1.15 and do not see "Segmentation fault (core dumped)", as there is support for tf 1.15 and 2.x, please upgrade to later versions and let us know if you are still facing any issue.
please find the gist for tf 1.15.

Actually, I used the nightly version as of 20200811, not 1.15. I can reproduce the issue with the latest version in Colab.  The session crashed due to the fault in c++ here.

Was able to reproduce the issue in TF 2.6.0-dev20210528,please find the gist here..Thanks !

With the latest tf-nightly I believe the issue has been resolved with no crash anymore:
# python3
Python 3.8.10 (default, Jun  2 2021, 10:49:15)
[GCC 9.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import tensorflow as tf
2021-09-02 15:21:04.937701: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libcudart.so.11.0'; dlerror: libcudart.so.11.0: cannot open shared object file: No such file or directory
2021-09-02 15:21:04.937746: I tensorflow/stream_executor/cuda/cudart_stub.cc:29] Ignore above cudart dlerror if you do not have a GPU set up on your machine.
>>> tf.image.combined_non_max_suppression(boxes=tf.ones((11,8,2,4)), scores=tf.ones((11,8,2)), max_output_size_per_class=5, max_total_size=311452676677046672)
2021-09-02 15:21:06.423863: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libcuda.so.1'; dlerror: libcuda.so.1: cannot open shared object file: No such file or directory
2021-09-02 15:21:06.423905: W tensorflow/stream_executor/cuda/cuda_driver.cc:269] failed call to cuInit: UNKNOWN ERROR (303)
2021-09-02 15:21:06.423943: I tensorflow/stream_executor/cuda/cuda_diagnostics.cc:156] kernel driver does not appear to be running on this host (ip-172-31-87-192): /proc/driver/nvidia/version does not exist
2021-09-02 15:21:06.424317: I tensorflow/core/platform/cpu_feature_guard.cc:151] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  AVX2 FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.8/dist-packages/tensorflow/python/util/traceback_utils.py", line 153, in error_handler
    raise e.with_traceback(filtered_tb) from None
  File "/usr/local/lib/python3.8/dist-packages/tensorflow/python/framework/ops.py", line 7096, in raise_from_not_ok_status
    raise core._status_to_exception(e) from None  # pylint: disable=protected-access
tensorflow.python.framework.errors_impl.InvalidArgumentError: cannot compute CombinedNonMaxSuppression as input #3(zero-based) was expected to be a int32 tensor but is a int64 tensor [Op:CombinedNonMaxSuppression]
>>>

@mjkim720 I will close this issue for now, but feel free to re-open if the issue persists.


Feature Pack 8 Designer problems

I tried to install the xockets 3.0.2 into Designer and got problems.

I tried to install OpenNTF Extension Library and that did not help either. I am not able to build my application now.

The server side plugin seems to work just fine and I did not install the OpenNTF extension library on the server, since FP8 contains it already.

This problems is something local, nothing to do with the github repo.

Actually, I think Csaba was correct on this one. I had to add in some sources from the extension library and re-build xockets so it didn't depend on the extension library being installed in Designer. xockets.io was searching for these plugins:
com.ibm.domino.das
com.ibm.domino.commons
com.ibm.domino.services
After I added those plugins to the xockets project and re-built I was able to build the projects in Designer once more without the extension library and with FP8 installed. I wasn't able to find IBM's equivalent of com.ibm.domino.das (if they even included one in FP8), which is why I couldn't just exchange the library in the xockets src and re-build. I'm sure you'll find a more clever way of solving this.
I, however, ran into problems when I changed the minimum support release to 9.0.1FP8. Application wouldn't run.


Import "gravityai" could not be resolved

Hi, I followed the example and tried importing gravityai but it gives the error
Import "gravityai" could not be resolved
I installed gravityai with the following commands
pip install gravityai

python3.9 -m pip install gravityai

My code as below
from gravityai import gravityai as grav
.
.

Please let me know what can I do to fix this?

Sorry for the trouble, our package did not build correctly.  Please use the latest version available in Pypi (0.1.4.post2).


Texture not using SetTexture?

Hello guys, I am now at the point where I have to make some game specific hacks. For this I detect textures and assign a "special role" to them.
Replacing the texture is already working...

however, I would rather like to skip the geometry alltogether.
So my idea was to store the "special role" of the current texture, but I cannot find it.
HRESULT m_IDirect3DDeviceX::SetTexture(...)
...
m_IDirect3DTextureX *pTextureX = nullptr;
lpTexture->QueryInterface(IID_GetInterfaceX, (LPVOID*)&pTextureX);
...
CurrentTextureSpecialRole = pSurfaceX->GetSpecialRole();

if(CurrentTextureSpecialRole == SurfaceSpecialRole::HandDecal)
{
	LOG_LIMIT(100, __FUNCTION__);  // never triggers
}

Any suggestions? Thank you

For this I detect textures and assign a "special role" to them.

How are you detecting the texture to assign it a role?

Are you sure that the correct SurfaceX is getting the role and that the surface is one that is actually used in a SetTexture() calL?  Try logging the address of the SurfaceX that you assign the role to and then logging all the SetTexture() calls to see the game ever calls SetTexture on that surface.
Are you using the correct SetTexture() function?  From the code above it looks like the wrong one.  There are two SetTexture functions.  This game only calls the one that looks like this:  HRESULT m_IDirect3DDeviceX::SetTexture(DWORD dwStage, LPDIRECTDRAWSURFACE7 lpSurface)

The role is correctly assigned, which the texture replacement already uses.
I cannot see any SetTexture for that surface. Here is what the log lists for the surface 1A2AA0F0.
It is a dynamic texture, the shadow of the hand, that is why I need to prevent the game from locking it, otherwise it would be replaced again.
3636 20:01:39.461 m_IDirectDrawSurfaceX::IsLost (1A2AA0F0)
3636 20:01:39.461 m_IDirect3DDevice9Ex::TestCooperativeLevel (09220420)
3636 20:01:39.461 m_IDirectDrawSurfaceX::Lock2 (1A2AA0F0)
3636 20:01:39.461 m_IDirect3DDevice9Ex::TestCooperativeLevel (09220420)
3636 20:01:39.461 m_IDirect3DDevice9Ex::TestCooperativeLevel (09220420)
3636 20:01:39.461 m_IDirectDrawSurfaceX::LockD39Surface (1A2AA0F0) prevent lock of hand decal!
3636 20:01:39.461 m_IDirectDrawSurfaceX::LockD39Surface (1A2AA0F0) prevent lock of hand decal!
3636 20:01:39.461 m_IDirectDrawSurfaceX::Lock2 Error: failed to lock surface texture. is Texture Size: 32x32 Format: D3DFMT_A4R4G4B4 dwCaps: 0x10405008 IsLocked: 0 IsInDC: 0
3636 20:01:39.461 m_IDirectDrawSurfaceX::Unlock (1A2AA0F0)
3636 20:01:39.461 m_IDirect3DDevice9Ex::TestCooperativeLevel (09220420)
3636 20:01:39.461 m_IDirect3DTexture9::UnlockRect (1A2D0E68)
3636 20:01:39.461 m_IDirect3DDevice9Ex::TestCooperativeLevel (09220420)
3636 20:01:39.461 m_IDirectDrawSurfaceX::Blt (092DA7A0)
3636 20:01:39.461 m_IDirect3DDevice9Ex::TestCooperativeLevel (09220420)
3636 20:01:39.461 m_IDirect3DDevice9Ex::TestCooperativeLevel (09220420)
3636 20:01:39.461 m_IDirectDrawSurfaceX::QueryInterface (1A2AA0F0) IID_GetInterfaceX

Okay I found it. It is handled through blitting.

LOL.  Yeah, that is the other option I was going to say but left off for some reason.  I wonder why the game author chose to blit the hand texture rather than just using SetTexture.

I am sure there was a good reason for it. In 1999. :p


0.4.1 release is broken?

On version 0.4.1 /dist folder is missing, while still being referenced in package.json.

If I downgrade to 0.4.0 it magically appears.

Hi I released a fix: 0.4.2
Sorry for the inconvenience, I have to invest some time into github actions


Renaming folder

PUlL THIS FIRST PLZZZ
kog_levels fix 1

changed title variables name and reference call to new fancy title

Images

reorganized images (check assets/images)
added fancy title

Additional

changed folder name

It's easy to empty/replace those txt files, you can put a PR for that whenever you want.


minilinks bool_exp implementation

@ivansglazunov can we close this issue? Looks like minilinks have query funciton and it works with bool_exp. Or something else should be done to close that issue?


Texture extraction when using the BFM2009

Hi! Just wanted to register a problem I am having with the fitting algorithm.
I run into no problem when running the demo fitting script located at https://github.com/patrikhuber/eos/blob/master/python/demo.py
I can also successfully produce the "bfm2009.bin" file from the Basel Model downloaded at their website, and I can generate perfect vertex coloured .obj files of human faces from a  eos.morphablemodel.MorphableModel loaded from bfm2009.bin.
However, when, in the demo.py script, I change line 10:
model = eos.morphablemodel.load_model("../share/sfm_shape_3448.bin")
to load the above mentioned bfm2009.bin instead of sfm_shape, i run into a segmentation fault. I believe this is related with the mathematical optimization process.
I am using Ubuntu 18.04 with gcc 6.4.0.

I can generate perfect vertex coloured .obj files of human faces from a eos.morphablemodel.MorphableModel loaded from bfm2009.bin.

When, in the demo.py script, I change line 10: model = eos.morphablemodel.load_model("../share/sfm_shape_3448.bin") to load the above mentioned bfm2009.bin instead of sfm_shape, i run into a segmentation fault.

I am a bit confused, these two statements seem contradictory to me. The first one say you can load the bfm2009.bin, the second one says you can't?

The model loads fine, but the Segmentation Fault occurs latter on in the demo.py script. I believed it came from the fit_shape_and_pose method, but it actually comes from line 30, in extracting texture (uncommented in my case). That is: the model loads, fits, but a Segmentation Fault happens if you try to extract texture to the mesh.

Hi @patrikhuber . I didn't know about this difference. Thanks for explaining it.
This is related to a more fundamental problem I am having. I wanted to fit the full Basel model, WITH the texture parameters. But the "demo.py" script does not do that, instead, it tries to extract the texture from the visible portion of the face in the image. This leads to bad, non-simmetrical results. Basel model solves this offering texture parameters. But they have to be fitted.
Is it possible to use eos to do this? To fit the shape parameters AND the texture parameters of a model like Basel's?
Sorry if the question is dumb. I am beginning in computer vision and could not find a way to do this with the fit_shape_and_pose function. My impression is that it is not possible to fit the texture coordinates of the Basel model in eos.

I don't know if I was clear in the above question. When I load Basel model, I can do
sample = model.draw_sample([1.0, -0.6], [1.0, 1.0])
And I get a mesh WITH color, in the sample.colors attribute. But, when using the fitting function, there is no resulting color in the mesh. Is it possible to fit the PCA color coefficients?

I think you are in general confusing "texture extraction" (or "texture remapping") and "PCA texture model"/"texture fitting", also more correctly called PCA albedo model or albedo fitting. These are two completely different things.
eos indeed does do shape fitting (and texture extraction), but it does not contain a direct algorithm for albedo model fitting. If you just want a linear solve, that would be relatively easy to set up though (you could see Aldrian & Smith 2013, link is in the Readme). Actually there's even a first-run example of nonlinear albedo fitting in eos, you could have a look at fit-model-ceres. Beware that you're getting into a difficult topic though ;-)

I did know about the difference between the two concepts already, but since I could not find a way to do texture fitting in eos, I was trying texture extraction as a temporary solution.
Anyway, thank you very much for the references! I'm starting to think I will need to learn C++ in order to do Computer Vision effectively.

I see!
Well you can get a long way with Python I think :-) Good luck!


[W5.7][T13-1]Liu Zhaoyu

It's a great enhance of find command. The original find command can only retrieve by name, which is too simple to use effectively.


Key Stuck in unobtainable position

In Celestial Resort room 13-b, there is usually a Winged Berry hidden below spikes. In my most recent attempt at a randomizer (sadly did not think to check the seed until after I quit out), there was a key placed in this position, unobtainable without using Debug. Image below
https://imgur.com/Y6KPH2w
Blueye also experience an issue with an unobtainable key. The beginning of seed 86884 on Preset C requires you to complete Farewell Room d-02 to obtain a key, however, the room is stuck with electricity on, making the seed impossible almost immediately. Image of the debug map is below.
https://imgur.com/iFXLdt9

I fixed the latter issue this morning, it'll be in the next release. For the former issue, I believe it should have been fixed in version 0.2.2. Are you playing on a version lower than that?

thanks for your response! yes, the former issue was performed before the release of version 0.2.2, and I have since updated to that version.


Filter Unit Tests, Documentation Improvements, & 2D Action Classifier

Created unit tests for filters such that everything has at minimum 70% coverage, updated the README and commented a few functions to begin building a more in depth series of function comments throughout the code base.
In addition, added a UDF for a 2D action classifier and the initial outline of a respective unit test.

It looks like the Travis CI failed due to an environment issue. I'll update environment_mac.yml so that it includes what's in environment.yml

Requested changes were fixed, however a previous merge on upstream unrelated to me or this PR is causing CI to fail.


GEODE-6110: Add .java-version to .gitignore and rat ignore list.

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

That's a good question!  It seems strange that we rat everything we can find, rather than, say, tracked files.

@PurelyApplied Where does .java-version come from?


test of travis with pip install of amuse

this is a very naieve test..wip

clearly not the way to do it


Templates a11y

I didn't review the code but I did install nvda and play around with the branch build. Most of these are probably not an issue but heres what I found playing around:

when closing autocomplete, term in input disappears
any way to select an autocomplete term without clicking on it to then redirect? Looks like it requires you to type the term to then see the rest of autocomplete results for that term. Would probably require keyboard navigation to focus term then hit right arrow?
autocomplete terms - use tab to go to to 2nd list option, then down key will read option 3 is focused but outline remains on 2nd option. Pressing tab again then goes to 4th. Same thing happens with facet values
Sortby/per page dropdowns - cannot use up/down arrows within list
Sortby/per page dropdowns - open dropdown, press down, tab, focus goes to next outside element and dropdown remains open
Sortby/per page dropdowns - outline only applies to label text
category hierarchy facet - after selection a top level category, should the next subcategory read out the previous selection? May be hard to know how a category filter is intended to be used?
when selecting a layoutoption, sort by, or per page value, the page jumps/scrolls down (happening due to spacebar scroll?)
Can't tab to product price - how can you get the reader to read prices? Or should they be part of the name reading?
slider facet - when using arrows, needs a timeout to allow multiple arrow presses? Or increment by larger value? Or should PageUp/PageDown keys increment by larger values? Holding arrow buttons causes page to freeze (looks to be applying url changes for each increment but only rerenders after unfreezes)
slider facet - when handle is focuses, pressing up/down arrows scrolls the page
focusing price slider handle reads "price slider slider button slider price slider slider button"
on product page bundle - Add All to Cart button after clicked says "unavailable" from button disabled state? But if clicking with mouse it then reads "bundle added"


dot net core hosting issue

Hi,
I'm calling dotnet framework 4.8 built dll from native c++, using the .net core implementation but my application is failing when I'm making init_fptr funtion call during loading of .net core. It is showing Init failed: -2147450730 , when .net sdk version 5 is already installed. Is there a bug of some kind or incompatibility of framework and core versions. Any help would be appreciated.
Thanks

Hey @shivamdabas ,
can you please tell more about what you are trying to do, need more clarification on this... If you can share any snip / code.
Its just dlls are not compatible probably error is due to target framework incompatible.


Error: No such file or directory (os error 2) when run anchor build -p marginfi

I run anchor build -p marginfi in the project root directory, but I get Error: No such file or directory (os error 2). Why is this?
github: https://github.com/mrgnlabs/marginfi-v2
cxp@CXPfromR9000P:~/solana_learn/marginfi-v2$ anchor build -p marginfi
Error: No such file or directory (os error 2)

Do you have avm installed?

Yes
cxp@CXPfromR9000P:~/solana_learn/marginfi-v2$ avm -V
avm 0.30.1

cxp@CXPfromR9000P:~/solana_learn/marginfi-v2$ anchor -V
anchor-cli 0.29.0

[toolchain]
anchor_version = "0.30.1"
solana_version = "1.18.11"

After keeping the version the same as Anchor.toml, the problem was resolved.


subjectDictance with value "undef"

When scan a photo with metadata value not valid, there is an error. I have a photo with the field  'subjectDistance' with the value that is not a float.
The error log:

2022-10-16 08:48:17,417 : directory_watcher.py : rescan_image : 255 : ERROR : job c58d0a84-cf7d-4d90-8768-107ba5cea573: could not load image /data/uploads/web/IMG_20150313_163656.jpg. reason: Field 'subjectDistance' expected a number but got 'undef'.
Traceback (most recent call last):
File "/usr/local/lib/python3.10/dist-packages/django/db/models/fields/init.py", line 1687, in get_prep_value
return float(value)
ValueError: could not convert string to float: 'undef'
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/code/api/directory_watcher.py", line 246, in rescan_image
photo._extract_exif_data(True)
File "/code/api/models/photo.py", line 542, in _extract_exif_data
self.save()
File "/code/api/models/photo.py", line 135, in save
return super().save(
File "/usr/local/lib/python3.10/dist-packages/django/db/models/base.py", line 753, in save
self.save_base(using=using, force_insert=force_insert,
File "/usr/local/lib/python3.10/dist-packages/django/db/models/base.py", line 790, in save_base
updated = self._save_table(
File "/usr/local/lib/python3.10/dist-packages/django/db/models/base.py", line 872, in _save_table
updated = self._do_update(base_qs, using, pk_val, values, update_fields,
File "/usr/local/lib/python3.10/dist-packages/django/db/models/base.py", line 926, in _do_update
return filtered._update(values) > 0
File "/usr/local/lib/python3.10/dist-packages/django/db/models/query.py", line 803, in _update
return query.get_compiler(self.db).execute_sql(CURSOR)
File "/usr/local/lib/python3.10/dist-packages/django/db/models/sql/compiler.py", line 1522, in execute_sql
cursor = super().execute_sql(result_type)
File "/usr/local/lib/python3.10/dist-packages/django/db/models/sql/compiler.py", line 1143, in execute_sql
sql, params = self.as_sql()
File "/usr/local/lib/python3.10/dist-packages/django/db/models/sql/compiler.py", line 1488, in as_sql
val = field.get_db_prep_save(val, connection=self.connection)
File "/usr/local/lib/python3.10/dist-packages/django/db/models/fields/init.py", line 823, in get_db_prep_save
return self.get_db_prep_value(value, connection=connection, prepared=False)
File "/usr/local/lib/python3.10/dist-packages/django/db/models/fields/init.py", line 818, in get_db_prep_value
value = self.get_prep_value(value)
File "/usr/local/lib/python3.10/dist-packages/django/db/models/fields/init.py", line 1689, in get_prep_value
raise e.class(
ValueError: Field 'subjectDistance' expected a number but got 'undef'.

thanks :smiley:


add flagd provider

Signed-off-by: agardnerit<EMAIL_ADDRESS>This PR

Adds a Python FlagD Provider

Hey @agardnerIT, I applied your commits to the python-sdk-contrib repo and opened a PR. You can find it here.
I think this PR can be closed now :slightly_smiling_face:


⚠ Site ANTS has degraded performance

In e59ae13, Site ANTS (https://ants.gouv.fr) experienced degraded performance:

HTTP code: 200
Response time: 4519 ms

Resolved: Site ANTS performance has improved in 5031a4c after 46 minutes.


Bug about using ROME to edit

Hello, when I tried to use ROME to edit gpt2-xl according to the example of ROME from the Docs and Colab, I met some bugs.
The code is:
from easyeditor import ROMEHyperParams
from easyeditor import BaseEditor
hparams = ROMEHyperParams.from_hparams('./hparams/ROME/gpt2-xl')
prompts = ['Ray Charles, the',
'Grant Hill is a professional',
'The law in Ikaalinen declares the language'
]
ground_truth = ['piano',
'basketball',
'Finnish'
]
target_new = ['violin',
'soccer',
'Swedish'
]
subject = ['Ray Charles',
'Grant Hill',
'Ikaalinen'
]
editor = BaseEditor.from_hparams(hparams)
metrics, edited_model, _ = editor.edit(
prompts=prompts,
ground_truth=ground_truth,
target_new=target_new,
subject=subject,
# locality_inputs=locality_inputs,
keep_original_weight=False
)
I met a bug:
Traceback (most recent call last):
File "/home/yangwanli/EasyEdit/test_rome.py", line 25, in
metrics, edited_model, _ = editor.edit(
File "/home/yangwanli/EasyEdit/easyeditor/editors/editor.py", line 200, in edit
edited_model, weights_copy = self.apply_algo(
File "/home/yangwanli/EasyEdit/easyeditor/models/rome/rome_main.py", line 41, in apply_rome_to_model
deltas = execute_rome(model, tok, request, hparams)
File "/home/yangwanli/EasyEdit/easyeditor/models/rome/rome_main.py", line 104, in execute_rome
left_vector: torch.Tensor = compute_u(
File "/home/yangwanli/EasyEdit/easyeditor/models/rome/compute_u.py", line 112, in compute_u
u = get_inv_cov(
File "/home/yangwanli/EasyEdit/easyeditor/models/rome/compute_u.py", line 42, in get_inv_cov
stat = layer_stats(
File "/home/yangwanli/EasyEdit/easyeditor/models/rome/layer_stats.py", line 148, in layer_stats
loader = tally(
File "/home/yangwanli/EasyEdit/easyeditor/util/runningstats.py", line 104, in tally
cached_state = load_cached_state(cache, args, quiet=quiet)
File "/home/yangwanli/EasyEdit/easyeditor/util/runningstats.py", line 1485, in load_cached_state
print("%s %s changed from %s to %s" % (cachefile, a, dat[a], v))
File "/home/yangwanli/anaconda3/envs/EasyEdit/lib/python3.9/site-packages/numpy/lib/npyio.py", line 249, in getitem
raise KeyError("%s is not a file in the archive" % key)
KeyError: 'sample_size is not a file in the archive'
I found the bug come from "File "/home/yangwanli/EasyEdit/easyeditor/util/runningstats.py", line 1485, in load_cached_state":
if a not in dat or dat[a] != v:
if not quiet:
print("%s %s changed from %s to %s" % (cachefile, a, dat[a], v))
return None
a was not in dat, but you used dat[a], so it raise the KeyError.
But I don't know how to fix the bug. I tried to comment the print codes, but it raise other errors.

Now that I've set all mom2_adjustment to False by default, please update the easyedit code and try again.
If your problem has been resolved, please help close this issue.

Thanks for your help! It's correct. Now I can use ROME to edit gpt2-xl successfully. Thanks for your great contributions again!


Application Fingerprinting(BYO-repo)

Right now, we sort of leave the exercise of figuring out what services are needed to move an app to Azure up to the developer. We should be able to provide them with more of an opinionated take so that we can decrease the cognitive load. We should also do this in approachable, non-Azure language so that folks without deep background can get started.
User flow:

Run azd init in a codebase dir (non-templatized)
User is provided with a series of prompts to walkthrough and accept the "suggested" services needed to move their app to the cloud (e.g. azd sees React and so we suggest Static Web Apps), with smart defaults + configurations
At each prompt, user is provided with the opportunity to either accept the default suggestion or amend an azd-suggested service and choose another option (maybe I don't want Cosmos and actually want Azure SQL)
As a result of the command executing, the user receives all the appropriate IaC assets in their project written in Bicep to run azd up with little to no amendments

We will evaluate both an AI and non-AI powered version of this.
### Tasks
- [ ] https://github.com/Azure/azure-dev/issues/1907
- [ ] https://github.com/Azure/azure-dev/issues/1594
- [ ] https://github.com/Azure/azure-dev/issues/1260
- [ ] Prototype AI variant
- [ ] Prototype non-AI variant
- [ ] Create initial design explorations for the Golden Path scenario
- [ ] Create initial design explorations for Error and Troubleshooting scenarios

In addition to forming an opinionated infrastructure folder we should also explore generating default github actions / azdo pipeline files to help enable pipeline configuration.

@savannahostrowski @ellismg Not in scope for GA. Moving this to Gallium.

With fingerprinting, we may be able to add a subsequent feature. as @vhvb1989 suggests here:
services:
  web:
    project: ./src/web
    language: auto # may be omitted

Detecting the project file based on the folder would be fairly trivial. If we can't, we can simply emit an error.

We should also figure out how this fits in with azd init,and whether this solves the problem of azd init in current directory vs azd new in new directory etc. Original comment here

07/07/2023 | End of week design update
This week

Created initial Application Fingerprinting golden path prototype in Figma
Reviewed prototype with @savannahostrowski
Reviewed prototype with design team during crit and captured feedback

Next week

Present Golden Path scenario prototype during team demo time (cc: @rajeshkamal5050)
Incorporate feedback from design crit and team demo
Create initial flow explorations for language detection failure and DB config [See blocker below]

Blockers
Unable to create designs for the incorrect language detection, DB configuration, and other edge-case scenarios until we have a better understanding of how the language detection will work and how accurate it will be (cc: @weikanglim)
Team, feel free to comment here or in the prototype linked above if you have feedback, thoughts, or concerns

Other scenarios to prioritize for Ignite:

Support for Dockerfiles - today, we are leveraging buildpacks when targeting ACA. We should also allow a developer to define their own Dockerfile
Managed add-ons - Running Redis in a container on ACA is faster to provision. We should lean on managed add-ons where possible

Closing this for now in favour of smaller items. Will discuss with @weikanglim


Requiring that keypoints stay within the image bounds

A feature idea. Not sure if it fits within the scope of this library or should be rather handled by the user, but this comes up quite often when using augmentation: We want to warp the image but not so much that important bits (keypoints) fall out of frame.
One solution is to carefully craft the ranges of translation/scaling/rotation for the particular dataset and hope that most keypoints will remain within the image frame after augmentation.
Another approach, that I take now, is to sample new augmentations with aug.to_deterministic() in a loop until I get one where all keypoints remain within frame. This can of course slow things down significantly depending on the configuration. It may also happen that there doesn't even exist such a transform, so the number of trials should be limited.
This may be useful to have within imgaug, for example as a boolean argument to the augmenter functions that take keypoints as parameters (augment_keypoints, augment_batches). For example with a name like keep_keypoints_visible or force_keypoints_within_image_bounds or something better.

Setting reasonable ranges for the parameters and dropping bad augmentations is probably the best one can do with the library right now. Changing this to a parameter like keep_keypoints_visible would likely be very difficult to get into the library, because currently images and keypoints are augmented in completely separate steps and are only "synchronized" by the determinism, while such a parameter would require some kind of one-step handling. It would also break the current philosophy that parameters should only be sampled conditionally dependent on the random state and image shape.


Calulate uid

Make uid a calculated unique value so you dont have to truncate to add old date.

Current way is fine

So current way is not fine will try to implement this

Issue fixed within dev will pull to main soon. Issue closed


Dynamic Volume Provisioning

Bug
Environment

Platform: aws
OS: flatcar-linux
Release: v1.17.3
Terraform: Terraform v0.12.21

Problem
We are trying to deploy a stateful set on the kubernetes cluster and unable to dynamically create volumes. I have tried to add the changes from https://github.com/poseidon/typhoon/pull/76/ and running into infinite loop of "null_resource.bootstrap". Would appreciate if I can find a way to deploy a statefulset on the Typhoon kube cluster with ebs as the pvc.
Desired Behavior
Provision Dynamic volumes for the pods.

I've mentioned in several issues that cloud-provider options are not implemented or in-scope (and nodes are not given any IAM permissions, regardless of cloud). So naturally, I'm not fielding bug reports for how to implement features I've said aren't in scope.
You may perhaps be interested in https://github.com/kubernetes-sigs/aws-ebs-csi-driver (not an endorsement, I do not use it)


ImportError: No module named cmdline

I have successfully installed version 1.16.0 but when I try to run "twitter" from my linux terminal it says like this: http://s17.postimg.org/wim9qyqnz/angel_beats_bg5.jpg
I had no error in version 1.15.0

These three look like duplicates: #67 #162 #281.

Yep. Dupe of #67,


Improved performance of forms.widgets.Media.merge()

As highlighted in https://github.com/django/django/pull/13874 OrderedSet can be a little "slow". Now that we can rely on dictionaries to be ordered the quickest way to get an ordered list of unique items is list(dict.fromkeys(iterable)).
While OrderedSet is not used that much in Django's codebase, one example is in widget Media. My benchmark shows this patch is 13% quicker than the current OrderedSet approach.
@felixxm -- Does this change need a ticket? -- I'd like to review the other uses for OrderedSet but to review them properly and to write benchmarks will take time. I'm also conscious of the upcoming feature freeze -- so there's an option of considering this as a standalone change, or we could wait for a more comprehensive review.

@smithdc1 Thanks for this patch :+1: however I'm not sure if it's worth readability, there is a small performance improvement but both methods are really fast :thinking: :

Python 3.10:

before: Mean +- std dev: 7.72 us +- 0.64 us
after: Mean +- std dev: 6.73 us +- 0.39 us

Python 3.8:

before: Mean +- std dev: 6.64 us +- 0.41 us
after: Mean +- std dev: 6.02 us +- 0.32 us

@smithdc1 Thanks for this patch :+1: however I'm not sure if it's worth readability, there is a small performance improvement but both methods are really fast :thinking: :

Python 3.10:

before: Mean +- std dev: 7.72 us +- 0.64 us
after: Mean +- std dev: 6.73 us +- 0.39 us

Python 3.8:

before: Mean +- std dev: 6.64 us +- 0.41 us
after: Mean +- std dev: 6.02 us +- 0.32 us


ops-3105 Fixed previewImageSource()

Issue #: ops-3105
Description of changes:

app version = 5.4.2a
fixed previewImageSource()

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

/gcbrun

Temporary Url for review: https://business-create-dev--pr-563-g2wi72es.web.app

^^ I got Travis' verbal OK to proceed with this PR. I also had pressure from Mihai et al to get this fix into Prod asap.


Feature blocks

Implement feature blocks.
Feature blocks are a grouping for render state and shader code.
Required components for this issue:

Feature block
Render state

Requires #168 for shader support
Check FIP-1 for specs

Hey team! Please add your planning poker estimate with ZenHub @Kryptos-FR @satendrapalsingh


Bug: dotnet publish with --no-build flag creates corrupted application dependencies manifest (app.deps.json) file for netcore21 target in multitarget projects

Input data:
There is some netstandard2.0 assembly that should works on .net core 2.1 and net472 frameworks.
For example let it's contains only one class:
namespace Test
{
	public static class Get5Class
	{
		public static int Get5() => 5; // just return 5 for test purpose
	}
}

For this assembly it is required to run unit tests both for .netcore2.1 and net472. To avoid create 2 separate test projects it is possible to use multitarget test project. For our purpose let it be nunit test project:
<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFrameworks>netcoreapp2.1;net472</TargetFrameworks>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="coverlet.collector" Version="1.2.1">
      <PrivateAssets>all</PrivateAssets>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
    </PackageReference>
    <PackageReference Include="NSubstitute" Version="3.1.0" />
    <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.9.9">
      <PrivateAssets>all</PrivateAssets>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
    </PackageReference>
    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.6.1" />
    <PackageReference Include="NUnit" Version="3.12.0" />
    <PackageReference Include="NUnit3TestAdapter" Version="3.16.1">
      <PrivateAssets>all</PrivateAssets>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
    </PackageReference>
    <PackageReference Include="NunitXml.TestLogger" Version="2.1.62" />
    <PackageReference Include="StyleCop.Analyzers" Version="1.1.118">
      <PrivateAssets>all</PrivateAssets>
    </PackageReference>
  </ItemGroup>
  <ItemGroup>
    <ProjectReference Include="..\TestClass\TestClass.csproj" />
  </ItemGroup>
</Project>

and here is code of test:
using NUnit.Framework;
using Test;

namespace NunitTest
{
	[TestFixture]
	public static class TestClassTests
	{
		[Test]
		public static void CheckThatGet5Returns5()
		{
			Assert.That(Get5Class.Get5(), Is.EqualTo(5));
		}
	}
}

Problem:
I'm trying to run .net core 2.1 nunit test that published with --no-build flag on win10 machine and get error like:
dotnet test .\netcore21\NunitTest.dll --results-directory:.\cover --logger:"nunit;LogFilePath={assembly}{framework}.xml"
Microsoft (R) Test Execution Command Line Tool Version 16.6.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...

A total of 1 test files matched the specified pattern.
Testhost process exited with error: Error:
  An assembly specified in the application dependencies manifest (NunitTest.deps.json) was not found:
    package: 'Microsoft.Win32.Registry', version: '4.3.0'
    path: 'runtimes/win/lib/netstandard1.3/Microsoft.Win32.Registry.dll'
. Please check the diagnostic logs for more information.
Results File: C:\home\work\Prototypes\NunitTest\NunitTestNETCoreApp21.xml

Test Run Aborted.

Originally this error was found in some big solution (>150 projects)  and error messages was different for different tests (different packages and different pathes).
This test was build by commands:
dotnet restore
dotnet build -c Release
dotnet publish NunitTest.csproj  -f netcoreapp2.1 -o .\netcore21 --no-build --configuration Release

After some investigation it was found that problem is in application dependencies manifest (app.deps.json). Publishing with or without --no-build flags makes different *.deps.json. In case if you just replace corrupted *.deps.json by good one it makes possible to run tests successfully.
So, in question of why we can not just remove "--no-build" flag from publish command:
It is because we have big solution that builds about 20 minutes and there are many unit tests so it is required to reduce time of publishing to makes builds as far as possible for our CI/CD.
net472 is not affected by this problem.
Version and runtimes:
dotnet --info
.NET Core SDK (reflecting any global.json):
 Version:   3.1.301
 Commit:    7feb845744

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.17763
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\3.1.301\

Host (useful for support):
  Version: 3.1.5
  Commit:  65cd789777

.NET Core SDKs installed:
  2.1.202 [C:\Program Files\dotnet\sdk]
  2.1.503 [C:\Program Files\dotnet\sdk]
  2.1.504 [C:\Program Files\dotnet\sdk]
  2.1.508 [C:\Program Files\dotnet\sdk]
  2.1.509 [C:\Program Files\dotnet\sdk]
  2.1.805 [C:\Program Files\dotnet\sdk]
  3.1.100 [C:\Program Files\dotnet\sdk]
  3.1.101 [C:\Program Files\dotnet\sdk]
  3.1.301 [C:\Program Files\dotnet\sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.All 2.1.4 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.8 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.12 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.13 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.14 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.17 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.19 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.4 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.8 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.12 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.13 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.14 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.17 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.19 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.1.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.1.5 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 2.0.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.4 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.8 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.12 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.13 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.14 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.17 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.19 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.1.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.1.5 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 3.1.0 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 3.1.5 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

This repo is no longer actively monitored. Closing up old issues that have not had activity in while. If this is still an issue, please open a new issue in an appropriate repo listed in microsoft/dotnet#1275

This repo is no longer actively monitored. Closing up old issues that have not had activity in while. If this is still an issue, please open a new issue in an appropriate repo listed in microsoft/dotnet#1275


cannot drag scroll bar when add offset

scrollbarDown function need to count with scrollbarOffsetHorizontal?
if (local.y > this.boxHeight - this.scrollbarSize) {

if (local.y > this.boxHeight - this.scrollbarSize + this.options.scrollbarOffsetHorizontal) {

Is this working properly or should I look at it?


update

This looks like a localized update that should not be merged to the main theme repository.

this looks like your local udpate :sweat_smile: sorry but I close this.


Replaced byte[] with BinaryData in implementation methods where a response body is expected.

Fixes: #39494.
Also removed bomAwareToString() from CoreUtils, as we already have a definition for it in ImplUtils.

/azp run java - clientcore - ci


Replaced ELCImagePicker => GMImagePicker

In short, this is a severe refactoring which basically replaces the ELCImagePicker with the GMImagePicker in order to support lacking iOS 8 features with the first.
Effort has been put into this by @mrbasque, @micheladrion and @hanssens.
Features & Improvements

Supports iOS 8 Photos Framework, incl. shared albums and non-local photos (optimized cloud storage)
[IOS] Fixes issue #56: Selecting photos from a Shared Album results in 'null'
[IOS] Fixes issue #57: Unselectable photos and empty albums when Optimized Storage is enabled
[IOS] Enables fetching of images on-demand that aren't stored locally
[IOS+Android] Response now returns both original image path but now also the thumb path as well
No further clientside/consumer impact
[IOS] Added orientation-fix to correctly display the returned result
[Enhancement] Options allow you to enable or disable selection of video's through allow_video
[Enhancement] Options allow you to provide a custom title and message in the selection screen

Important Changes

Removed ELCImagePicker in favor of GMImagePicker
[IOS] Changed DeliveryMode from "FastFormat" => "HighQualityFormat" in GMImagePicker
[IOS] Only support for iOS 8+

Known issues

Fetching duration of an image from iCloud (on-demand) can range from a second to a couple of seconds
Could seriously use a codereview

Awesome job - I'm seriously considering reviewing/testing/adding this to my fork. Perhaps it needs some kind of graceful iOS7 handling but need to study this first a bit.

In the latest commit the plugin.xml is now included as well. This means it's quite final and ready for comments. Despite that we're all quite busy and this PR is a tough one to swallow, I would sure like to hear if this something that's worth continuing on. Thanks!

Great job!! Please release these changes. I need it for my work!

@TheKiteEatingTree + @CSullivan102 perhaps you might want to share your quick thoughts on this PR?

For those interested, this update works just fine on iOS 9 as well.

Note that since the last commit to master, about 8 days ago, there seem to be conflicts. This is logical, considering this PR totally replaces ELC.
But if there's any interest, I'll gladly update it to the latest master. /cc @ DMcNamara

Definitely interested in this PR. I'm running into issues with users trying to select images from icloud... it sure sounds like this could help with that.

Awesome, thanks. This indeed is iCloud-compatible and works great in production. Although, as @EddyVerbruggen also mentioned, it breaks iOS 7 support and should perhaps be handled accordingly.
With this in mind, it would justify making a v2.0 release perhaps?

Hi - we, too, are having issues with icloud.  Any update on this PR?

Hey @hanssens, I've reviewed you changes because I felt it was time folks shouldn't care about iOS7 too much anymore ;)
I've pulled your cool PR to the fork I maintain here and made a few changes on top (these are partly personal taste, so don't take it ehm.. personally):

Changed the default title and message so they reflect how it looked in the previous version of the plugin (no nasty surprises for developers).
Re-added base64 encoding of iOS images which was already available in my fork.
I removed the thumbnail feature to remain compatible with users of the old version (this also gets rid of two new jars Android needed).
I've re-added the width, height and quality params which were still used for Android, but no longer for iOS after this PR was merged.
Fixed an (old) issue on Android where base64 encoded images didn't obey the passed-in quality setting.
Removed the 'fetching' text on top of the progress indicator on iOS. I thought it was a bit too much ;)

@EddyVerbruggen I can only say... excellent! :+1:

Hey, just wanted to let you all know that we haven't forgotten about this and aren't just ignoring it. This PR is awesome, and I'm really excited about it. It's also really big. We're a small team and always busy (who isn't, though?), but I've been trying to steal more time to maintain our OS projects whenever I can. This PR is top on my list, and I am actively reviewing it whenever I get a chance, so hopefully we'll have a 2.0.0 release soon!

Thanks for the follow-up, @DMcNamara. Sounds great! Let me know where I can assist...

I spent a long train ride last weekend going through this and it looks really great. I've just got a few comments and questions on mainly documentation stuff.

allow_video should really be camelCase allowVideo, at least in imagepicker.js, since the maximumImagesCount option is already camelCase. It's easier if option naming is consistent.
In the readme:

Do any of the examples need to be updated? I don't think so, but I'm not sure.
Are there any new features that should be mentioned in there? I see the new outputType option listed in the options, but it would be good to list the other new options, like allow_video, title, and message too. There's probably some other things that could use a mention too.
Something about upgrading from 1.0 would also probably be good. Definitely need to mention dropping support for iOS 7.
There's also a paragraph at the end that mentions ELCImagePicker that should now say GMImagePicker.

There's a // TODO pass in quality comment in GMGridViewController.m. It seems like it does quality conversion elsewhere, so is that just for display, or is it a forgotten comment?
Having a demo is awesome, but I think there's one comment in there that should probably be removed before release since it seems development related, the one about "if no title is passed".

Is this merged to main branch already?

Hey guys,
when will these changes be available in the master branch?
I am really looking forward to the new features.
I am not able to use the new awesome features until it is merged to master, am I?
A short answer would be highly appreciated!
Thanks

You can install the plugin from @hanssens or @EddyVerbruggen repos to use the new GMImagePicker.  I looked into pulling this in and unfortunately there are a few things I'd want to change to use it that I just don't have the time to do right now.  I think we will pull this in eventually, but it could take quite a long time.  There are a lot of great changes in it though.

@TheKiteEatingTree
Thanks for your reply! I tried using @hanssens repo but I really need the paths to the original files (I need the EXIF data). And as far as I have seen, his repo returns only the paths to the thumbnails, doesn't it?
There are many repos out there that provide great features but as far as I know yours is the only one wich combines all features I need for a file picker.
I need these features:

multi selection
video selection
paths to original files

I would really really really appreciate if you could merge into master branch in the near future.
Regards

+1

Any news/plans/roadmap on this @DMcNamara / @sdushay ? :)


react-native 0.59 support

Thanks for opening a PR!
Since this is a volunteer project and is very active, anything you can do to reduce the amount of time needed to review and merge your PR is appreciated.
The following steps will help get your PR merged quickly:
Update the documentation
If you've added new functionality, update the README.md with an entry for your prop or event.
The entry should be inserted in alphabetical order.
Update the changelog
After you open the PR, update the CHANGELOG.md file with an entry pointing to your PR.
Provide an example of how to test the change
If the PR requires special testing setup provide all the relevant instructions and files. This may include a sample video file or URL, configuration, or setup steps.
Focus the PR on only one area
Testing multiple features takes longer than isolated changes and if there is a bug in one feature, prevents the other parts of your PR from getting merged until it gets fixed.
If you're touching multiple different areas that aren't related, break the changes up into multiple PRs.
Describe the changes
Add a note describing what your PR does. If there is a change to the behavior of the code, explain why it needs to be updated.
https://github.com/react-native-community/react-native-video/issues/1585
bug fixed for this issue

Anything else required for this to get merged?

Is this backwards compatible to react-native 0.58?

@n1ru4l despite of the title I think it is more related to android sdk / gradle version.
Maybe @cobarx knows more about this.
I will try also to ask on monday at work if it can introduce incompatibility, but I am seeing lots of libraries that have grandle with implementation.
https://stackoverflow.com/a/44493379


Fix typos

@brondani, thanks for catching these defects in the documentation.
@chaws , we still seem to see Windows failing frequently... Who could we ask for help on this?

Thanks @brondani for the fixes!
@jkrech I think I got the windows tests really "fixed" this time: https://github.com/Open-CMSIS-Pack/cpackget/pull/87
I'll keep an eye for any intermittent test regarding this windows feature.


Create: 1822-sign-of-the-product-of-an-array

File(s) Modified: 1822-sign-of-the-product-of-an-array.cpp
Language(s) Used: C++
Submission URL: _https://leetcode.com/problems/sign-of-the-product-of-an-array/submissions/1080806497/_

Important
Please make sure the file name is lowercase and a duplicate file does not already exist before merging.

Thanks!

🤙🏼


Basic example of a java sse plugin

Status
[ ] Under development
[x] Waiting for code review
[x] Waiting for merge

Information
[ ] Contains breaking changes
[ ] Contains new API(s)
[x] Contains documentation
[ ] Contains test
[x] Contains examples

To-do list
[x] [The secure connection in the example is statically linked to OpenSSL and APR-lib. It is possible to do this dynamically, see https://github.com/grpc/grpc-java/blob/master/SECURITY.md. Have anyone done this? ]

I have now split the code into three files and updated the documentation to reflect that. I have also (hopefully) fixed the problems pointed out by @qlikmats except for the part about storing packages as com/qlik/sse since maven automatically stores them in the local repository when you run mvn package.

I was asked to review this (I guess) because we mainly work with Java and that we have made a prototype with a Java SSE. So here are my comments.
It is great to get an example to start with! It will save a lot of time building SSEs using Java.
One thing that is a bit awkward in Java when building SSEs is the way incoming metadata is handled compared to how grpc is integrated in other languages. It would be helpful to explain the purpose of the interceptor and the thread local storage used for metadata. That is a good insight that it takes some time to get when starting building Java SSEs. A comment in the code explaining this mechanism in PluginServerInterceptor and JavaPlugin would be good.
Folders and package names must match. Normally the structure used here should not compile. I guess the build script does something unconventional to make it compile.
Do not import classes in same package. They are automatically visible.
Use package names starting with a lower case letter. The correct thing to use here would be something like com.qlik.sse.basicExample but for an example it might be easier with folder hierarchies that are not that deep so qlik.basicExample is ok. That would imply that the source files would be in src/main/java/qlik/basicExample.

@cjpersson Thank you for your comments! On the metadata explanation, would it be better to have a more detailed explanation in the documentation or do you want that explanation in the code? or both?


Update contributing guides

testing

testing
hello

testing
hello

This is an automated comment
Deployed demos for this PR:


[video_player] Video persisting memory after dispose

Steps to reproduce

Press button to show video
Wait for video to initialize
Press the button to hide video and dispose
Repeat

Expected results
Expected memory to be released after disposing the video.
Actual results
Memory keeps increasing when displaying videos. It does not happen every iteration.
I have tried on iOS with and without impeller. It's definitely more frequent to see an increase when the video plays after initialising.
It appears to have something to do with the memory allocated in FVPVideoPlayer copyPixelBuffer
Device : iPhone 8
Software version: 14.7.1
Regarding flutter versions I have tried 3.22.1 ( as in flutter doctor ) and 3.24.4 ( on stable channel )
1st screenshot - VM memory that was created and persisted. You can see persisted memory increases over time.
2nd screenshot - IOSurface, which seems to be the problematic entry, you can also see the persisted memory increasing over time as well as the code trace ( all entries are the same )
Code sample
Code sample
import 'package:flutter/material.dart';
import 'package:video_player/video_player.dart';

void main() {
  runApp(
    MaterialApp(
      home: _App(),
    ),
  );
}

class _App extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      key: const ValueKey<String>('home_page'),
      appBar: AppBar(title: const Text('Video player example')),
      body: OnOffVideo(),
    );
  }
}

class OnOffVideo extends StatefulWidget {
  const OnOffVideo({Key? key}) : super(key: key);

  @override
  State<OnOffVideo> createState() => _OnOffVideoState();
}

class _OnOffVideoState extends State<OnOffVideo> {
  int counter = 0;
  bool isVisible = false;

  @override
  Widget build(BuildContext context) {
    return Column(crossAxisAlignment: CrossAxisAlignment.center, children: [
      Center(
        child: GestureDetector(
          onTap: () {
            setState(() {
              isVisible = !isVisible;
            });
          },
          child: Container(
            color: isVisible ? Colors.red : Colors.green,
            height: 50,
            width: 50,
            child: Text(isVisible ? 'Hide' : 'Show'),
          ),
        ),
      ),
      if (isVisible) _BumbleBeeRemoteVideo(key: ValueKey<int>(counter++)),
    ]);
  }
}

class _BumbleBeeRemoteVideo extends StatefulWidget {
  const _BumbleBeeRemoteVideo({Key? key}) : super(key: key);

  @override
  _BumbleBeeRemoteVideoState createState() => _BumbleBeeRemoteVideoState();
}

class _BumbleBeeRemoteVideoState extends State<_BumbleBeeRemoteVideo> {
  late VideoPlayerController _controller;

  @override
  void initState() {
    super.initState();
    _controller = VideoPlayerController.networkUrl(
      Uri.parse('https://flutter.github.io/assets-for-api-docs/assets/videos/bee.mp4'),
      videoPlayerOptions: VideoPlayerOptions(mixWithOthers: true),
    );

    _controller.addListener(() {
      setState(() {});
    });
    _controller.setLooping(true);
    _controller.initialize().then((value) => _controller.play());
  }

  @override
  void dispose() {
    _controller.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return SingleChildScrollView(
      child: Column(
        children: <Widget>[
          Container(padding: const EdgeInsets.only(top: 20.0)),
          const Text('With remote mp4'),
          Container(
            padding: const EdgeInsets.all(20),
            child: AspectRatio(
              aspectRatio: _controller.value.aspectRatio,
              child: Stack(
                alignment: Alignment.bottomCenter,
                children: <Widget>[
                  VideoPlayer(_controller),
                ],
              ),
            ),
          ),
        ],
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[!] Flutter (Channel [user-branch], 3.22.1, on macOS 14.6.1 23G93 darwin-arm64, locale en-PT)
    ! Flutter version 3.22.1 on channel [user-branch] at /Users/user/flutter
      Currently on an unknown channel. Run `flutter channel` to switch to an official channel.
      If that doesn't fix the issue, reinstall Flutter by following instructions at https://flutter.dev/docs/get-started/install.
    ! Upstream repository unknown source is not a standard remote.
      Set environment variable "FLUTTER_GIT_URL" to unknown source to dismiss this error.
    • Framework revision a14f74ff3a (6 months ago), 2024-05-22 11:08:21 -0500
    • Engine revision 55eae6864b
    • Dart version 3.4.1
    • DevTools version 2.34.3
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
    • Android SDK at /Users/user/Library/Android/sdk
    • Platform android-35, build-tools 35.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15F31d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)

[✓] VS Code (version 1.92.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (3 available)
    • macOS (desktop)                 • macos                 • darwin-arm64   • macOS 14.6.1 23G93 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad • darwin         • macOS 14.6.1 23G93 darwin-arm64
    • Chrome (web)                    • chrome                • web-javascript • Google Chrome 130.0.6723.93

[✓] Network resources
    • All expected network resources are available.

Thanks for the report @TiagoAraujo54
Are you seeing this in debug mode or in profile mode ?

Thanks for the update. I tried the same on iphone 6s with profile mode but not getting the reported behavior. I see that your code sample is very similar to the plugin example, but it has more code that can you try using your config to see if using it, you still get same behavior still ?

As you have requested I have tried with the plugin example and it exhibited the same behaviour. ( I only put the 3 tabs as the network video without changing anything else as I did not have the assets). I swiped between the tabs and pressed play a couple of times and saw the same problem.

Nevertheless I also tried with the default example and it definitely the problem still occurs it just seems that it has a lower rate of it happening.
Also placed a print on the network video dispose and waited for the dispose print before performing another swipe either way the problem persisted

Thanks for the update. I tried it again few times after which I was able to replicate the reported memory behavior.
I think I've seen a related / similar issue of memory being persisted after video is disposed but it was causing an exception. In this case, it doesn't throw any exception or error log.
Keeping this issue open for team's tracking.
stable : 3.24.4
master: 3.27.0-1.0.pre.412

Yes on my side I have also not seen any exceptions/errors. Thank you for your time so far

any updates on this ?

It appears to have something to do with the memory allocated in FVPVideoPlayer copyPixelBuffer

I think this class of problems should go away when https://github.com/flutter/packages/pull/8237 merges. We should check back in after.

I see now that there is still a way to use textures in that PR.  @FirentisTFW do you think https://github.com/flutter/packages/pull/8237 will resolve this, given you've rewritten a lot of it?  Did you happen to fix a memory leak along the way? 🙂

Hmm, I haven't done anything specifically in that regard. I think that textures should still work the same way after the refactoring. So if there was a bug, I'm afraid it could still be there :/ However, I just run the code sample from the first comment on my branch and I did not observe the issue. I used iPhone 8, iOS 16.7.10.
I'm not sure how urgent this issue is (though I see P2 assigned), but would it make sense to wait for the PR8237 to be merged, and then we would test it again?

I'm not sure how urgent this issue is (though I see P2 assigned), but would it make sense to wait for the PR8237 to be merged, and then we would test it again?

Yes, let's reevaluate after that lands. Thank you so much!