Certain MSBuild warnings/errors aren't being put in the error list

Got the following warnings, none of them showed in the error list:
1>------ Build started: Project: ConsoleApp43, Configuration: Debug Any CPU ------
1>C:\Users\davkean\Documents\Visual Studio 2017\Projects\ConsoleApp43\ConsoleApp43\ConsoleApp43.csproj : warning MSB4011: "C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\Sdks\Microsoft.NET.Sdk\Sdk\Sdk.props" cannot be imported again. It was already imported at "C:\Users\davkean\Documents\Visual Studio 2017\Projects\ConsoleApp43\ConsoleApp43\ConsoleApp43.csproj". This is most likely a build authoring error. This subsequent import will be ignored.
1>C:\Users\davkean\Documents\Visual Studio 2017\Projects\ConsoleApp43\ConsoleApp43\ConsoleApp43.csproj : warning MSB4011: "C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\Sdks\Microsoft.NET.Sdk\Sdk\Sdk.targets" cannot be imported again. It was already imported at "C:\Users\davkean\Documents\Visual Studio 2017\Projects\ConsoleApp43\ConsoleApp43\ConsoleApp43.csproj". This is most likely a build authoring error. This subsequent import will be ignored.
1>ConsoleApp43 -> C:\Users\davkean\Documents\Visual Studio 2017\Projects\ConsoleApp43\ConsoleApp43\bin\Debug\netcoreapp1.0\ConsoleApp43.dll
========== Build: 1 succeeded or up-to-date, 0 failed, 0 skipped ==========

There seems to be some weirdness around errors showing up in output window but not in the error list. Can you work with @heejaechang to chase this down?

There's some real weirdness here, if I add the following to the project:
 <Target Name="AfterBuild" AfterTargets="Build">

    <Error Text ="This is an error"/>

  </Target>

It is never output in the Error List. If I add the same thing to a desktop project, it is run.

I deleted my comment above, it was incorrect.

Dup'd this against: https://github.com/dotnet/roslyn-project-system/issues/1154

I mean: https://github.com/dotnet/roslyn-project-system/issues/1154

Closing in favor of #1218 then.


Clarify that public/index.html is special

As discussed in https://github.com/facebook/create-react-app/issues/8004

@andriijas missed this! I completed the CLA 😄

@davetapley  Rebase your branch as well since its been a while :) thanks


On microservices, should the use case call the another service?hi

Hi,
If I try a structure with microservices, should the use case call the other service or should be the API?
Is OK if my use case call another microservices (Rest API)?

Hello @leandrofagundes,
I think it's definitely OK if it's part of the business logic (using some abstraction like IFriendlyService and implementing it in the infrastructure layer).

Hi @qpippop thanks for participating,
so, thinking about a monolyth, where I have many modules and contexts.
If I need to run a rule from a specific module from another module, can one Use Case call another Use Case implementing it as a service or should all the rule about one use case be done inside itself?

Every use case is piece of (isolated) business logic. So it can (and probably should) be combined if needed. However if you call IUseCase directly there could be difficulties with sharing (or not sharing) connections/transactions and other stuff. So i would implement special aggregator to accomplish this task. I can't answer how exactly without deep dive into concrete problem

Very nice explanation @qpippop. I totally agree :)


Undertow 1.2.7.Final

Windows Build 1463 is now running using a merge of 50ffccf8fd73b97a459e60105bb4a033963032e7

Linux Build 1910 is now running using a merge of 50ffccf8fd73b97a459e60105bb4a033963032e7

Core - Full Integration Build 1050 is now running using a merge of 50ffccf8fd73b97a459e60105bb4a033963032e7

Windows Build 1463 outcome was SUCCESS using a merge of 50ffccf8fd73b97a459e60105bb4a033963032e7
Summary: Tests passed: 3122, ignored: 71 Build time: 0:20:43

Linux Build 1910 outcome was SUCCESS using a merge of 50ffccf8fd73b97a459e60105bb4a033963032e7
Summary: Tests passed: 3122, ignored: 71 Build time: 0:22:57

Core - Full Integration Build 1050 outcome was FAILURE using a merge of 50ffccf8fd73b97a459e60105bb4a033963032e7
Summary: Tests failed: 1 (1 new), passed: 2887, ignored: 375 Build time: 0:52:15
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.messaging.mgmt.JMSQueueManagementTestCase.removeJMSQueueRemovesAllMessages: <no details avaliable>


Error (code 6) on "eune"

Describe the bug
When trying to set the region to eune I get thrown an error code 6
To Reproduce
Steps to reproduce the behavior:

LeagueApi::summoner('eune')->name($result->account_ign)
"ERROR (code 6): Specified region could not be resolved."

Expected behavior
I'm supposed to receive summoner information .
Desktop (please complete the following information):

OS: Windows 10
PHP Version: 7.2.10
RiotQuest Version: 1.3.4

Hi, eune does currently not resolve into a valid region (https://github.com/supergrecko/RiotQuest/blob/master/src/RiotQuest/Components/Engine/Utils.php#L34)
I'll update it so it'll resolve.

Thanks could you do the same check up for the other regions? I'd really appreciate it that way in case it happens again I don't post here, also if you don't mind how can I handle exceptions? Since they're just throwing a complete error page instead of something I can work with

You can catch the LeagueException type. I'm going to create a more intuitive exception handling system for the next major release which will be a while after PHP 7.4's release.

Sorry for being annoying but could you give me a snippet just to check if what I wrote is wrong or not (I'm using Laravel in case it helps)

Hello, this code snippet works perfectly fine for me on 1.3.4
dump(Client::summoner('eune', 1)->name('abc'));

And to answer your second question:
use RiotQuest\Contracts\LeagueException;

try {
    dump(Client::summoner('eune', 1)->name('abc'));
} catch (LeagueException $ex) {
    // deal with $ex
}

Is there anything on your end which could be breaking it or are you passing the literal `'eune'` string?

Oh I think I found the problem the method ->getRanked() is the one throwing the exception it looks like

This has been resolved, you can grab it via 1.3.5


How to handle with "createAlias" for crossplatform app

In the documentation you always refer to "Signup phase" when speaking about createAlias.
But how to handle this thing if the app is cross-platform (Desktop, Webapp, Android, iOS in my case). In fact I've already a lot of users who are already registered when they download the app, and the login is skippable so it's doesn't merge datas when I identify after they logged in since I doesn't use createAlias yet.

hi @loryhuz thanks for writing in about this!
the best practice here is to call createAlias when a user initially signs up, and then call identify with the value used for the alias on all future app opens (typically done in didFinishLaunchingWithOptions).
provided you know who a user is on the new platform -- by some id -- you can simply call identify with the alias on app open and the user will be linked to other platforms. if you do not know who the user is, and they do not need to authenticate, things do get tricky -- is there anything you know on your end we can tag this user by to be able to correct link their account across platforms?
there is more info on this here and if you let me know your specific scenario i am happy to help further!

"if you do not know who the user is, and they do not need to authenticate, things do get tricky"
In fact this is the case, login is skippable and you only need to login when you want to validate your cart (e-commerce app). So without creating alias we lost user data before the cart validation if it was considered as an anonymous.
"is there anything you know on your end we can tag this user by to be able to correct link their account across platforms?"
When you are logged in we have a userId returned by our webservice but it doesn't resolve (I think) our main problem (merging data between the anonymous and the logged user, both are the same person) that createAlias can be used only once.

hi @loryhuz -- given your scenario, there are a few options here to keep your data consistent for these users:

keep separate profiles for users on the different platforms
hold off on sending events from the client side until a user signs in so you can correct their distinct id
utilize a hybrid server-client implementation to ensure id stays consistent pre-login

ultimately the choice you make here really depends on your scenario -- for ex, if most users sign up on iOS without a web account anyways then this may be an edge case you address specially. mind emailing<EMAIL_ADDRESS>and we can discuss a solution tailored to your scenario in detail?


v0.47.12 "--skip-original-if-edited" No such option

Describe the bug
Updated to v0.47.12 and "--skip-original-if-edited" option isn't working.
% osxphotos --skip-original-if-edited
Usage: osxphotos [OPTIONS] COMMAND [ARGS]...
Try 'osxphotos -h' for help.

Error: No such option: --skip-original-if-edited

To Reproduce
Steps to reproduce the behavior:

Run command with option
osxphotos --skip-original-if-edited

Expected behavior
Command should run and skip originals if they are edited.
Desktop (please complete the following information):

OS: macOS 12.3.1
pipx
osxphotos version 0.47.12

Disregard, I think I have something wrong with the new osxphotos version --run 'pipx upgrade osxphotos'

The --skip-original-if-edited option only works with the export command.  That is:
osxphotos export /path/to/export --skip-original-if-edited

The --skip-original-if-edited option only works with the export command.

@RhetTbull Ya, I'm a dork and realized it is a separate command. ;-) thanks.


Bind HTTP service to GraphQL endpoint

Description:
Ballerina GraphQL implementation should be using Ballerina HTTP listener inside the GraphQL listener. Then from the inside there should be an HTTP service to act as the GraphQL endpoint. This endpoint path should be user defined, with the default  value of /graphql.

Completed


How to render aligned math equations?

Hi,
I am trying to render aligned math equations from markdown to HTML. For example
This is a markdown file.

$$
\begin{align}
f &= ma \\
e &= mc^2
\end{align}
$$

Specifically, the main issue is that the new line in the math block is tokenized as </br> in the output html and Katex fails to render.
Thanks for creating and maintaining this great library!

@AntixK, can you share code snippet / are you sure you are using the MathJaxRenderer? For me, it outputs the expected output:
<p>$$
\begin{align}
f &= ma \\
e &= mc^2
\end{align}
$$</p>
<script src="https://cdnjs.cloudflare.com/ajax/libs/mathjax/2.7.0/MathJax.js?config=TeX-MML-AM_CHTML"></script>

Hi, thanks, that works. I was trying out a custom rendered for math with labels. I missed out the mathjax renderer.


highlight return-rw for returning is-rw containers

http://doc.perl6.org/language/containers

For explicit returns, return-rw instead of return must be used.

Looks good to me, thanks!


bump: upgrade gopkg.in/yaml.v2 to gopkg.in/yaml.v3

Signed-off-by: yxxhero<EMAIL_ADDRESS>fix: https://github.com/helmfile/helmfile/issues/394
bump: upgrade gopkg.in/yaml.v2 to gopkg.in/yaml.v3

@mumoshu done. Added more test for the yaml overwrite feature.


Jan 31 Spot Check

Jan 31
database, with database schema change

[ ]  Show db.Column changes you have made to model/python file in Visual Studio Code
[ ]  Show initialization data code in VSCode
[ ]  Demo delete database and run ./migrate.sh
[ ]  Demo corresponding schema change in SQLite3
[ ]  Demo initialization data captured in Column in SQLite3
[ ] postman with /authentication screen

Show /authenticate endpoint code in Visual Studio Code

[ ]  Show and Demo /authenticate in Postman…
[ ]  Demo calling to endpoint
[ ]  Show JSON data passed in call
[ ]  Show Response window
[ ]  Show Cookie acquired window
[ ]  Cut/Copy/Paste Cookie into jwt.io and show decrypting payload
[ ] postman with /api screen to access data under authentication

Show /api CRUD code in Visual Studio Code, expecting READ/GET code

[ ]  Show and Demo /api READ/GET endpoint in Postman…
[ ]  Demo calling to endpoint that requires Cookie
[ ]  Show Response/Data
[ ]  Demo Deleting cookie
[ ]  Demo calling endpoint again
[ ]  Show Response/Failure

Question 2: Postman with Authentication Screen (0.90)

[x] Show authenticate endpoint code in VsCode

[x] Show and demo authenticate in Postman

[x] Demo calling to endpoint

[x] Show JSON data passed in call

[x] Show Response window

[x] Show cookie acquired window

[x] Cut/Copy/Paste Cookie into jwt.io and show decrypting payload

Question 3: Postman with Api screen to access data under authentication (0.89)

[x] Show /api CRUD code in Visual Studio Code, expecting READ/GET code

[x] Show and Demo /api READ/GET endpoint in Postman

[x]  Demo calling to endpoint that requires Cookie

[x] Show Response/Data

[x] Demo deleting cookie

[x] Demo calling endpoint again

[x] Show response/failure


[Search v2] [App] Create Description filter

Implement this section of the design doc for the Description filter only!
cc @adamgrzybowski @Kicu @WojtekBoman @Guccio163

Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue!

All yours @SzymczakJ

Sounds good. I think we can close this issue in favor of https://github.com/Expensify/App/issues/46032


I downloaded the lighting file, I don’t know how to use it for razer connect

I downloaded the lighting file, I don’t know how to use it for razer connect.Don't know how to import files

This portion shows you how to use the LED lights. once open make sure you have razer open as well and razer connect should auto place the LED lights.
https://github.com/nicolasdeory/leagueoflegends-led#usage


Fix nodeTypes warning shown on shallow equals

Currently a warning about memoizing the the nodeTypes object  is shown when the types are shallowly equal. Instead it should be shown when the consequent nodeTypes are not shallowly equal.

Not it doesn't. It gives a warning when you send a static object declared at the module level.

Think about it. Even the static objects declared at the module level are also shallow equals.
const nodeTypes =  { custom: NodeType }

shallow({ custom: NodeType }, { custom: NodeType }) // true
shallow(nodeTypes, nodeTypes) // true

I think you are not taking hot reloading into account or something. I can guarantee you the second case gets invoked during hot reloads. Maybe the useMemo always runs on a hot reload, even if the values are referentially equal.

With shallow we are not checking the nodeTypes, but just the keys. When useMemo detects a change but the keys stay the same, we are showing the error message, because we assume that it was done by mistake.


Widget header and shared components

Changes with merges of dashboard and widget code
Added widget header and integrated between dashboard and widget content
Working configuration in widget header
Shared modal components

Still working on test cases, not ready to merge


V1.5.39 - Flatten bugfix

Updated README with better LDV information
Fix issue reported by Katherine West with Rollup.flatten method
Fixed a few date literal edge cases that have shown up in the new year

@ssk42 such a strange set of errors though - I find it funny that they were really only rearing their collective heads at these sentinel dates (like crossing into a new year) but that function ended up cleaning things up nicely


Theme presets not updating themes

Hi,
I've just noticed a weird behavior of theme presets, I think it's a bug. BTW, all caching is off.
I've created my own preset for the Elemental theme. Everything worked fine for some time. I changed a few colors and so on. But at one time, I've changed my @body-link-color back to what it was before, and it did not change. No matter what, it's just stuck at that color. I could change the color in the content.less directly - it worked. I had no ideas what to do. And then I've just gone to the page Design, changed my theme preset for any other and then back to mine - and yes, it worked!!! And from then on, most of the changes I make in the preset do not propagate until I change the preset in the page design a couple of times.
Any ideas what's going on?
Thank you.

Hi linuxoid,
This is an unconfirmed bug, please post this to the official concrete5 bug tracker so that it can be confirmed and voted on.
http://www.concrete5.org/developers/bugs

Please note I am not linuxoid. Thank you.

On Jul 4, 2015, at 11:05 PM, Karl Dilkington<EMAIL_ADDRESS>wrote:
Hi linuxoid,
This is an unconfirmed bug, please post this to the official concrete5 bug tracker so that it can be confirmed and voted on.
http://www.concrete5.org/developers/bugs
—
Reply to this email directly or view it on GitHub.


Release 3.0.0-alpha.0

publish with experimental tag
Checklist

[ ] I have ensured my pull request is not behind the main or master branch of the original repository.
[ ] I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
[ ] I have written a commit message that passes commitlint linting.
[ ] I have ensured that my code changes pass linting tests.
[ ] I have ensured that my code changes pass unit tests.
[ ] I have described my pull request and the reasons for code changes along with context if necessary.

npm dist-tag ls

experimental: 3.0.0-alpha.0
latest-0: 0.21.1
latest: 2.14.1
next: 2.9.0
v1: 1.7.0


Examples gallery

Render the example scripts in a new 'Examples' section of the documentation site with sphinx-gallery.
~Temporarily disabled multi-version build since sphinx-multiversion cannot execute code properly at build time, and we don't have any stable versions yet. One solution when we revisit this after releasing v0.1.0 is to loop over tagged versions in the make file.~
Edit: Build fails when running make publish locally on this branch because examples/README.rst does not exist in main yet.
Fix #69 as the scripts are executed in CI except for the too expensive ones (e.g. writing large files or viewing in napari).
Developers: for guide on writing and building the new examples, see the updated CONTRIBUTING file.

@ziw-liu
I got these warnings when building the documentation
generating gallery for auto_examples... [100%] run_single_fov_ome_zarr.py
computation time summary:
WARNING: The version switcher "file:///home/jordao/Softwares/iohub/docs/build/html//main/_static/switcher.json" file cannot be read due to the following error:
FileNotFoundError(2, 'No such file or directory')
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 12 source files that are out of date
updating environment: [extensions changed ('2')] 20 added, 0 changed, 3 removed
reading sources... [100%] index
/home/jordao/Softwares/iohub/docs/source/auto_examples/run_coordinate_transform.rst:187: WARNING: Content block expected for the "note" directive; none found.
/home/jordao/Softwares/iohub/docs/source/auto_examples/run_coordinate_transform.rst:188: WARNING: Explicit markup ends without a blank line; unexpected unindent.
/home/jordao/Softwares/iohub/docs/source/auto_examples/run_large_array_ome_zarr.rst:30: WARNING: Explicit markup ends without a blank line; unexpected unindent.
/home/jordao/Softwares/iohub/docs/source/auto_examples/run_large_array_ome_zarr.rst:76: WARNING: Explicit markup ends without a blank line; unexpected unindent.

Everything else worked great! The examples are nicely displayed.
I noticed that ClearControl's example follows a different format (my bad). Is it worth making it similar to the others?
napari package's examples follows a pattern where they are all executed but without calling the napari.run to block the execution.  Is that worth doing for our napari examples rather than not running them?

I got these warnings when building the documentation

The version switcher warning is a bug in the theme (cannot load json from local files properly) but works fine when deployed.
I fixed the markup warnings.

Is there any way of testing at least a part of that without taking on napari as a [doc] dependency and dealing with GH Linux runner's Qt issues?

I did some changes to this branch on #154, what do you think?

Credit to @AhmetCanSolak for suggesting this point in a meeting (agenda item 4).

Test failing because of #160

@ziw-liu This bug wasn't created in this PR, but I think you could fix it.
The make help command doesn't reflect the current functionalities of the make file.
$ make
Please use `make <target>' where <target> is one of
  html       to make standalone HTML files

Make file doesn't have html command, it only has help, clean, build, and publish.
$ make html
make: *** No rule to make target 'html'.  Stop.

Everything else is great.
I didn't have time to improve the ClearControl example as you suggested. We can open an issue about it if you prefer.

I didn't have time to improve the ClearControl example as you suggested. We can open an issue about it if you prefer.

Done in https://github.com/czbiohub-sf/iohub/pull/153/commits/6b03c5f12bc2f4ae048ad8dd86d54d909af21f40 and https://github.com/czbiohub-sf/iohub/pull/153/commits/8a5d754fa96c070c9be53dd6fc361ab9e7bd5a8e.

Just a sanity check, napari isn't available on the CI, right? So it won't open the viewer and block the execution.

Yes, it will just pass for that block.


refactor: gracefully exit ticker

Ref: #28

@rhnvrm Seems to work fine. Just tested it out.
Have attached two screenshots.

Your code on my local machine.
Refreshing connections in the same process without exiting (have blurred out my app key, secret and access token)
Getting live ticks again.

@rhnvrm ICYMI ^


Remove versioneye from README

New Pull Request Checklist

[x] I have read and understood the CONTRIBUTING guide

[x] I have read the Documentation

[x] I have searched for a similar pull request in the project and found none

[x] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

[x] I have added the required tests to prove the fix/feature I am adding

[x] I have updated the documentation (if necessary)

[x] I have run the tests and they pass

[x] I have run the lint and it passes (pod lib lint)

This merge request fixes / reffers to the following issues: ...
Pull Request Description
It's time to say goodby to versioneye. It has shut down.

Codecov Report

Merging #2424 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2424      +/-   ##
==========================================
- Coverage    74.4%   74.19%   -0.21%
==========================================
  Files          36       36
  Lines        3934     3934
==========================================
- Hits         2927     2919       -8
- Misses       1007     1015       +8

Impacted Files
Coverage Δ

SDWebImage/SDWebImageDownloaderOperation.m
85.43% <0%> (-2.92%)
:arrow_down:

SDWebImage/SDImageCache.m
63.84% <0%> (-0.42%)
:arrow_down:

SDWebImage/SDWebImageManager.m
75.22% <0%> (+1.35%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3378cc3...1c0ae2c. Read the comment docs.

Thanks @zhongwuzw


Spring Rest Service Tutorial "gs-rest-service" - No converter found for return value of type: class hello.Greeting

Hi Guys,
I am having a problem running the Spring Rest Service Tutorial... gs-rest-service
(See: "https://spring.io/guides/gs/rest-service/")
There appears to be issues around mapping Java/JSON.
The error I get is...
"No converter found for return value of type: class hello.Greeting"
The URL I'm using...
"http://localhost:8080/greeting?name=User"
I'm running the app from within STS as...
"Spring Boot App"
My environment is:
Windows 7
Java 8 (1.8.0_144)
Maven 3.5.2
Spring Tool Suite Version: 3.9.1.RELEASE ( Platform: Eclipse Oxygen.1a (4.7.1a) )

It happens with both the self-built "gs-rest-service-initial" and the completed version "gs-rest-service-complete"
These are things I've already checked after reading other peoples suggestions...
Yes, the Greeting does have getters
The jackson databind, annotaions and core libraries are present (all at version 2.8.10)
I tried commenting out the org.springframework.boot in the pom.xml but it made it worse
I also tried restarting STS but it had no effect

I also tied exporting it as a jar to run outside of STS but I got all kinds of issues but that may have been my "jar-ing"
I did an export as runnable jar with the option "Package required libraries into generated jar"
Anyone have any ideas?
Thanks

Hi GWReeves,
I had the same issue to resolve it: I overwrite Spring default dependencies for JSON in pom.xml like this:
<!-- JSON via Jackson --> <dependency> 	<groupId>com.fasterxml.jackson.core</groupId> 	<artifactId>jackson-databind</artifactId> 	<version>2.5.3</version> </dependency> <dependency> 	<groupId>com.fasterxml.jackson.core</groupId> 	<artifactId>jackson-annotations</artifactId> 	<version>2.5.0</version> </dependency> <dependency> 	<groupId>com.fasterxml.jackson.core</groupId> 	<artifactId>jackson-core</artifactId> 	<version>2.5.3</version> </dependency>

In my case, I had this issue because the jackson-databind jar was corrupt. It worked after deleting such jar and recompiling.

At the time of writing the project uses Jackson library version 2.9.5. I was able to work around the "No converter found for return value of type: class hello.Greeting" issue by downgrading to 2.9.4.
<dependency>
	<groupId>com.fasterxml.jackson.core</groupId>
	<artifactId>jackson-databind</artifactId>
	<version>2.9.4</version>
</dependency>
<dependency>
	<groupId>com.fasterxml.jackson.core</groupId>
	<artifactId>jackson-annotations</artifactId>
	<version>2.9.4</version>
</dependency>
<dependency>
	<groupId>com.fasterxml.jackson.core</groupId>
	<artifactId>jackson-core</artifactId>
	<version>2.9.4</version>
</dependency>

I had just exlude com.fasterxml.jackson.core from spring-boot-starter-web

org.springframework.boot
spring-boot-starter-web

com.fasterxml.jackson.core

and added the dependencies like @kekbur and all things work well
thanks all


Support to set window theme and expose system window theme changed event

Objective

Fixes https://github.com/bevyengine/bevy/issues/8586.

Solution

Add preferred_theme field to Window and set it when window creation
Expose winit WindowThemeChanged event

could you add something in example https://github.com/bevyengine/bevy/blob/main/examples/window/window_settings.rs showing how to change the theme on a key press?

Took a shot at adding the above to the example here: https://github.com/lewiszlw/bevy/pull/1

Thanks @hate to update example!


exportdata / loaddata cycle doesn't work, possibly due to abstract models?

So I did something that seems to be pretty simple to me, but maybe I'm just doing it wrong since its been a  few versions since I worked with django, as what I think should be should be simple is failing in a way that suggests ether I have no idea what I am doing, or something is really wrong.
Problem
Once a manage.py cities_light has been done, I cant do a exportdata/loaddata cycle without the load cycle side failing to import anything due to a "Country matching query does not exist." error.
Software Used
python 2.7
django 1.8 - yesterdays release of the new version
django-cities-light - pulled this form pip yesterday
Repro steps
(1). Create new empty dkango project.
(2). Add models to the first app of the project.  Make sure to add Country, Region, and City models that literally only look like this for each of them:
from cities_light.abstract_models import AbstractCountry
from cities_light.receivers import connect_default_signals

class Country(AbstractCountry):
    pass
connect_default_signals(Country)

(3). Do the 2+ hour import of the city-light data.
(4). Do an exportdata to export all the data in the db  a city_light.json file:
python manage.py dumpdata --all > city_light.json

(5). Delete the sqlite db to trick django into thinking it needs to be created again.
 C:\Users\Duane\Dropbox\code\github\mouser>del db.sqlite3

(6). I then do a full migration of my app so that it re-initalizes a new empty database with the correct schema that I had before.
C:\Users\Duane\Dropbox\code\github\mouser>python manage.py migrate
C:\Python27\lib\site-packages\south\modelsinspector.py:20: RemovedInDjango19Warning: django.contrib.contenttypes.generic is deprecated and will be removed in Django 1.9. Its contents have been moved to the fields, forms, and admin submodules of django.contrib.contenttypes.
  from django.contrib.contenttypes import generic

Operations to perform:
  Synchronize unmigrated apps: staticfiles, messages
  Apply all migrations: sessions, admin, auth, launcher, contenttypes, cities_light
Synchronizing apps without migrations:
  Creating tables...
    Running deferred SQL...
  Installing custom SQL...
Running migrations:
  Rendering model states... DONE
  Applying contenttypes.0001_initial... OK
  Applying auth.0001_initial... OK
  Applying admin.0001_initial... OK
  Applying contenttypes.0002_remove_content_type_name... OK
  Applying auth.0002_alter_permission_name_max_length... OK
  Applying auth.0003_alter_user_email_max_length... OK
  Applying auth.0004_alter_user_username_opts... OK
  Applying auth.0005_alter_user_last_login_null... OK
  Applying auth.0006_require_contenttypes_0002... OK
  Applying cities_light.0001_initial... OK
  Applying cities_light.0002_city... OK
  Applying cities_light.0003_auto_20141120_0342... OK
  Applying cities_light.0004_auto_20150403_2001... OK
  Applying launcher.0001_initial... OK
  Applying launcher.0002_auto_20150403_2001... OK
  Applying sessions.0001_initial... OK

(7). Now at this point the database should be  EXACTLY the same schema as it was when I did the data export. Exactly,just with no data. Right?
(8). Now attempt to load the data from the saved city_light.json file into the database with the hope of never having to do another 2 hour long import of just city data again:
C:\Users\Duane\Dropbox\code\github\mouser>python manage.py loaddata -v 3 city_light.json
C:\Python27\lib\site-packages\south\modelsinspector.py:20: RemovedInDjango19Warning: django.contrib.contenttypes.generic is deprecated and will be removed in Django 1.9. Its contents have been moved to the fields, forms, and admin submodules of django.contrib.contenttypes.
  from django.contrib.contenttypes import generic

Loading 'city_light' fixtures...
Checking 'C:\Users\Duane\Dropbox\code\github\mouser\launcher\fixtures' for fixtures...
No fixture 'city_light' in 'C:\Users\Duane\Dropbox\code\github\mouser\launcher\fixtures'.
Checking 'C:\Users\Duane\Dropbox\code\github\mouser' for fixtures...
Installing json fixture 'city_light' from 'C:\Users\Duane\Dropbox\code\github\mouser'.
Traceback (most recent call last):
  File "manage.py", line 12, in <module>
    execute_from_command_line(sys.argv)
  File "C:\Python27\lib\site-packages\django\core\management\__init__.py", line 338, in execute_from_command_line
        utility.execute()
      File "C:\Python27\lib\site-packages\django\core\management\__init__.py", line 330, in execute
        self.fetch_command(subcommand).run_from_argv(self.argv)
      File "C:\Python27\lib\site-packages\django\core\management\base.py", line 390, in run_from_argv
        self.execute(*args, **cmd_options)
      File "C:\Python27\lib\site-packages\django\core\management\base.py", line 441, in execute
    output = self.handle(*args, **options)
      File "C:\Python27\lib\site-packages\django\core\management\commands\loaddata.py", line 60, in handle
        self.loaddata(fixture_labels)
  File "C:\Python27\lib\site-packages\django\core\management\commands\loaddata.py", line 90, in loaddata
    self.load_label(fixture_label)
  File "C:\Python27\lib\site-packages\django\core\management\commands\loaddata.py", line 147, in load_label
    obj.save(using=self.using)
  File "C:\Python27\lib\site-packages\django\core\serializers\base.py", line 173, in save
    models.Model.save_base(self.object, using=using, raw=True)
  File "C:\Python27\lib\site-packages\django\db\models\base.py", line 734, in save_base
    update_fields=update_fields)
  File "C:\Python27\lib\site-packages\django\dispatch\dispatcher.py", line 201, in send
    response = receiver(signal=self, sender=sender, **named)
  File "C:\Python27\lib\site-packages\cities_light\receivers.py", line 28, in set_display_name
    instance.display_name = instance.get_display_name()
  File "C:\Python27\lib\site-packages\cities_light\abstract_models.py", line 114, in get_display_name
    return '%s, %s' % (self.name, self.country.name)
  File "C:\Python27\lib\site-packages\django\db\models\fields\related.py", line 602, in __get__
    rel_obj = qs.get()
  File "C:\Python27\lib\site-packages\django\db\models\query.py", line 334, in get
    self.model._meta.object_name
launcher.models.country.DoesNotExist: Problem installing fixture     'C:\Users\Duane\Dropbox\code\github\mouser\city_light.json': Country matching query does not exist.

As you can see it seems to be failing to detect the models after loading the abstract ones.
I'm totally blocked, and I have no idea what to do.  I have done everything according to the docs that I am aware of, and I expect to be able to export/import data at will, that does not work in my experience so far.
What I Am trying to do
I want my app to be initialized from migrations, as that is the new django way and I want to embrace the future.  I don't want to have to download a large file form the internet and suffer though a huge deployment every time I deploy; I want to do it at most once, then have all the data in a django migration i just apply and am done with, that I can also check into our source control (git, in this case).  That is what I am trying to do

Hi Duane!
Precise, have you specified CITIES_LIGHT_APP_NAME = 'yourapp' in your settings?
'yourapp' here must be the name of the app, where you define your custom cities_light models (check docs for details).
By the way, if you don't need to customise the cities_light models, you can just ignore abstract_models, i.e. don't inherit them.

Yes I have.  I have set CITIES_LIGHT_APP_NAME to the app name in question in the settings file.
I'm using my own version of the models so that  can support editing them later with migrations.

@st4lk  could you reproduce it ?
I'm working on a new app (django-referendum) and i'm testing django-swappable-models, it seems pretty well supported by migrations. Should we try that ?

@jpic i'll try to reproduce in next couple of days
As for django-swappable-models, it is interesting, will be good to try. Currently can't say pros and cons for this, but it looks good.

Ok, i have reproduced the problem. It is linked to usage of abstract models, but looks like it is not a problem of abstract models itself. It is caused by the order of custom models.
So, here what i tried. My custom main/models.py:
from cities_light.abstract_models import AbstractCountry, AbstractRegion, AbstractCity
from cities_light.receivers import connect_default_signals

class City(AbstractCity):
    pass
connect_default_signals(City)

class Country(AbstractCountry):
    pass
connect_default_signals(Country)

class Region(AbstractRegion):
    pass
connect_default_signals(Region)

Pay attention, models are declared in this order: City, Country, Region.
Now, fill database:
python manage.py cities_light --force-import-all

Create fixture (--indent 4 just for readability):
python manage.py dumpdata --all --indent 4 > city_light.json

Everything is ok for now.
Lets look at the beginning of city_light.json. It will contain something like this:
[
// some contenttypes
{
    "fields": {
        "model": "city",
        "app_label": "main"
    },
    "model": "contenttypes.contenttype",
    "pk": 7
},
{
    "fields": {
        "model": "country",
        "app_label": "main"
    },
    "model": "contenttypes.contenttype",
    "pk": 8
},
{
    "fields": {
        "model": "region",
        "app_label": "main"
    },
    "model": "contenttypes.contenttype",
    "pk": 9
},
{
    "fields": {
        "display_name": "Yerres, \u00cele-de-France, France",
        "name": "Yerres",
        "country": 1,
        "region": 11,
        "alternate_names": "",
        "search_names": "yerresfrance yerresiledefrancefrance",
        "longitude": "2.49338",
        "geoname_id": 2967245,
        "feature_code": "PPL",
        "name_ascii": "Yerres",
        "latitude": "48.71785",
        "slug": "yerres",
        "population": 28897
    },
    "model": "main.city",
    "pk": 1
},
// other cities ...
{
    "fields": {
        "code2": "FR",
        "code3": "FRA",
        "name": "France",
        "tld": "fr",
        "alternate_names": "",
        "continent": "EU",
        "geoname_id": 3017382,
        "phone": "33",
        "name_ascii": "France",
        "slug": "france"
    },
    "model": "main.country",
    "pk": 1
},
// other countries ...
{
    "fields": {
        "display_name": "Rh\u00f4ne-Alpes, France",
        "name": "Rh\u00f4ne-Alpes",
        "country": 1,
        "alternate_names": "Rh\u00f4ne-Alpes Region",
        "geoname_id": 2983751,
        "geoname_code": "B9",
        "name_ascii": "Rhone-Alpes",
        "slug": "rhone-alpes"
    },
    "model": "main.region",
    "pk": 1
},
// other regions ...
// and some other django models, not interesting here ...
]

As we can see, fixture reflect the order of our declared models: first goes City then Country and finally Region.
Now, delete db.sqlite3, create new by applying migrations, and try to loaddata. We'll get the same error, as in description of this issue.
Why?
Because some pre_save signals are connected to your models. And one of them, (exactly set_display_name) will cause access to model by ForeignKey. Before saving the city models this signal receiver will try to get city.country by foreignkey. But, as we can see for fixture, City will be loaded first, whereas Country is not in the database yet. And we get DoesNotExist error.
How to fix?

Simple but not beautiful solution. Just comment the signals connection to your models:
 # connect_default_signals(Country)
 # connect_default_signals(City)
 # connect_default_signals(Region)

when you do loaddata and uncomment after (all fields already was populated and saved in fixtures).

Good, but complicated solution. Declare you custom cities_light models in the same order, as cities_light package does:
 class Country(AbstractCountry): pass
 class Region(AbstractRegion): pass
 class City(AbstractCity): pass

Now, it is needed to create fixture again (so models will be saved in correct order).
Keep in mind, that your database is not changed, you just change the order of models declaration and create new fixture. In that case, when you'll delete the database and create new one (empty), database will be filled with contenttypes objects automatically.
But, as order of our models is changed, those contenttypes objects will also have different order and consequently other ids (different from our fixture, that was created from another database).
If we will try to loaddata now, following error probably gonna to happen:
 django.db.utils.IntegrityError:
     Problem installing fixture '.../city_light.json':
     Could not load contenttypes.ContentType(pk=7):
     UNIQUE constraint failed: django_content_type.app_label, django_content_type.model

To avoid it, we must manually set correct ids in our city_light.json for contenttypes.
Or, after changing order of custom cities_light models, delete database, do
python manage.py cities_light --force-import-all again and make fixture from this database. In that case no manual work with contenttypes is needed.

So, as i see, nothing to do with cities_light package according to this issue.
Maybe we just need to mention in the docs, that order of custom models matters in case of fixtures and signals.

By the way, even when custom models are used, original cities_light tables will be created because of migrations (in django >= 1.7):
Applying cities_light.0001_initial... OK
Applying cities_light.0002_city... OK
Applying cities_light.0003_auto_20141120_0342... OK
Applying cities_light.0004_auto_20150403_2001... OK

They don't break anything, just empty tables, but it is not very good. I think swappable models is the better choice because of this.
I'll work at this direction soon.

Thing is I'm not using an order for models; each model is a separate file so I have no way to control the order.

I'm actually not using an order for models at all; each model is a separate file as its own object inside a > 'models' package directory so I have no way to control the order they get declared.

Order matters, when you install objects from fixtures, as some pre_save signals are connected to cities_light models. These signals can access related objects (that could not be loaded yet). You can check the order by looking in your fixtures files.

If I comment out the default signals, my attempt to migrate also fails and the data is never added to the DB

What do you mean by "fails"? What traceback, what error message?
By the way, for simplicity you can just not override the default models. Such customisation surely can involve some issues, as you modifying the code of library in fact.
So by choosing the customisation you should take in mind, that this is an advanced topic.

Could you maybe reproduce your issue in a minimal test project ?
http://docs.yourlabs.org/en/latest/guidelines.html#yourlabs-community-guidelines
Thanks !

@st4lk, Thank you, you're right. Order matters and it should be:
Country, Region and City

Cities are in Regions, Regions are in a Country... That makes perfect sense. But it was not how the system handled it.

Today (24th, April, 2020) I had a similar problem with Django 2.2 (nothing related to django-cities-light)
My fixtures file was as simple as this:
[
{
    "model": "contenttypes.contenttype",
    "pk": 1,
    "fields": {
        "app_label": "admin",
        "model": "logentry"
    }
},
{
    "model": "contenttypes.contenttype",
    "pk": 2,
    "fields": {
        "app_label": "auth",
        "model": "permission"
    }
}]

When I ran ./manage.py loaddata initial_data.json, I got:
django.db.utils.IntegrityError: Problem installing fixture '/home/user/reponame/projectname/initial_data.json': Could not load contenttypes.ContentType(pk=2): UNIQUE constraint failed: django_content_type.app_label, django_content_type.model
What I did to make it work was just rename the pk to id for the contenttypes.contenttype model. After that, the migration worked as expected.
./manage.py loaddata initial_data.json
Installed 2 object(s) from 1 fixture(s)

After the change, my initial_data.json file was:
[
{
    "model": "contenttypes.contenttype",
    "id": 1,
    "fields": {
        "app_label": "admin",
        "model": "logentry"
    }
},
{
    "model": "contenttypes.contenttype",
    "id": 2,
    "fields": {
        "app_label": "auth",
        "model": "permission"
    }
}]

It is worth mentioning that my original initial_dataj.json has many other models, but renaming pk to id only for the contenttypes.contenttype solved my problem.


Pull functions from code

If a user defines a function we treat it as a variable.
We need to extract the function and inject into cell that uses it

Timeout


Fixing the exclusive resolver type on fusion quote responses

GitHub Actions are not correct because the wrong base branch was chosen initially


Suggest to update TOC.md

'Using on HDInsight' -> 'Using MapReduce on HDInsight'

@yoichinak : Thanks for your contribution! The author, @, has been notified to review your proposed change.

@twooley - Would you review the proposed changes? Thanks.

Merging typo fix


Restructure cloud networking tables to allow for Network-only providers

There have been requests to have Neutron as a standalone component, amongst many other requests for networking providers.  As such, the current CloudNetwork structure is insufficient.  This is the current design for a new Networking provider and Network manager, that is cloud-oriented (for now).  It should handle all of the Cloud providers we have right now, as well as allowing for new standalone Network providers.
One interesting aspect of this design is that it allows for a single network manager to be shared by multiple providers.  As can be seen in the image, one could add a NetworkProvider for Neutron, and then later add in an OpenStack cloud provider and have it reference the same manager.  This would allow visually walking the data from two provider entrypoints, without having to duplicate the underlying data.  It also allows for a specialized network managers, for example for Nuage's Neutron plugin, which can be exposed as a subclass of NetworkManager.

Also available is the .dot file from which this image was generated.  I will keep this post updated with changes as we discuss them.
cc @Ladas @blomquisg

@Fryguy changes:

For OpenStack and GCE, we will not have a NetworkGroup, so there should be also ext_management_system -> subnet

For OpenStack and GCE, we will have cloud_network -> cloud_subnet

I think that the main difference of NetworkGroup and CloudNetwork will be, that you can use CloudNetwork instead of CloudSubnet, for deploying of the VM. Then the provider internally picks some subnet. And NetworkGroup is just a wrapper for subnets and others. So those two will be different concepts.
GCE doesn't even have subnets now (it's in beta) just the cloud_network, so we will probably create fake subnet.

Most of the tables have a direct link to ext_management_system, do we want to keep that? We need at least VM belongs_to :ext_management_system, since AWS can have VMs outside of the VPC

For OpenStack, we will keep NetworkRouter belongs_to :cloud_network, which is modeling the router gateway for OpenStack now. Until we will find a better model.

For the Dual ipv4 and ipv6 subnet, I still haven't figured it out. In OpenStack, they do change how the IPv6 floating IPs will work, there will be no NAT anymore, so not sure what it will do to our router relations. From the doc, it seems like you can define multiple ipv4 and ipv6 subnets per network.

https://specs.openstack.org/openstack/neutron-specs/specs/kilo/multiple-ipv6-prefixes.html

Port-create operations without an explicit list of fixed IPs: There will be no change from the current design. When a port-create operation does not include an explicit list of fixed IPs, the following subnets on the associated network will be associated with the port:
One subnet from all IPv4 subnets
One subnet from all IPv6 DHCPv6-stateful subnets
All SLAAC-enabled subnets

Of course it doesn't really work that way, seems like it assigns IPs from all subnets, not just the SLAAC, but only subset of them actually works. :-) So the IPv6 is still kinda an opened question, I need to play with it more.

regarding 5.) we will need to somehow model, that network_port can have multiple subnets and IPs assigned.  e.g http://paste.openstack.org/show/487155/
So here are propositions, that should also include how Nuage is modelling Dual stack ipv4 and ipv6, which should be basically one subnet with ipv4 CIDR and ipv6 CIDR.
5.1.)
we will have network_ports_cloud_subnets table (network_port_id :integer, cloud_subnet_id :integer, ipv4 :string, ipv6 :string)
and for OpenStack, each inet or inet6, you see in the paste, would be a one row. For Nuage there would be only one row or 2 (depending on 6)
5.2.)
we will have network_ports_cloud_subnets table (network_port_id :integer, cloud_subnet_id :integer, ip_address :string)
for OpenStack again, each inet or inet6, you see in the paste, would be a one row. For Nuage there would be 2 rows, one for ipv4 and one for ipv6, both pointing to the same subnet or 2 (depending on 6)
5.3) We will keep the architecture as it is, and just for OpenStack, we can create Fake/Virtual ports, and we would have network_port :has_many => cloud_subnets, :through => :virtual_network_ports, and virtual_network_port would belong to subnet. The neutron_port still have polymorphic relation, so we can easily do this. But it will be ugly I suppose.
6.) It's a question whether we should model Dual Stack Subnet as one (so adding cidr_v6 field and allocation_pools_v6?) Or we will model them as 2 subnets, as it it designed now.
6.1.)  Adding cidr_v6 field and allocation_pools_v6 to cloud_subnet
6.2.) Modeling Dual stack subnet as 2 subnets, one of type ipv4 one of type ipv6

I am inclining to 5.2 and 6.2, but it might complicate architecture of the other providers, for OpenStack's sake.

Concept of Floating IPs with ipv6 is unclear to me. And seems not even Liberty is solving that http://docs.openstack.org/liberty/networking-guide/adv_config_ipv6.html

Do you have something like Neutron Subnet pools in Nuage?

I don't anticipate we'll see other cloud network providers aligning with
OpenStack semantics here - all others I've seen do not expose a broadcast
domain as such, so the added complexity for OpenStack won't be useful
elsewhere.  That said, if we don't make it possible to expose the OpenStack
model at CloudForms, I'm sure someone will come up with a use case where
it's required.
Neutron Subnet pools can be used from OpenStack with Nuage, or in cases
where OpenStack isn't used, Nuage also has the concept of a subnet pool (in
Nuage case, it's a zone which can contain multiple subnets.  Each zone has
a pool of IPs where subnet CIDRs can be assigned from.
On Tue, Feb 16, 2016 at 11:00 AM, Ladislav Smola<EMAIL_ADDRESS>wrote:

regarding 5.) we will need to somehow model, that network_port can have
multiple subnets and IPs assigned. e.g
http://paste.openstack.org/show/487155/
So here are propositions, that should also include how Nuage is modelling
Dual stack ipv4 and ipv6, which should be basically one subnet with ipv4
CIDR and ipv6 CIDR.
5.1.)
we will have network_ports_cloud_subnets table (network_port_id :integer,
cloud_subnet_id :integer, ipv4 :string, ipv6 :string)
and for OpenStack, each inet or inet6, you see in the paste, would be a
one row. For Nuage there would be only one row or 2 (depending on 6)
5.2.)
we will have network_ports_cloud_subnets table (network_port_id :integer,
cloud_subnet_id :integer, ip_address :string)
for OpenStack again, each inet or inet6, you see in the paste, would be a
one row. For Nuage there would be 2 rows, one for ipv4 and one for ipv6,
both pointing to the same subnet or 2 (depending on 6)
5.3) We will keep the architecture as it is, and just for OpenStack, we
can create Fake/Virtual ports, and we would have network_port :has_many =>
cloud_subnets, :through => :virtual_network_ports, and virtual_network_port
would belong to subnet. The neutron_port still have polymorphic relation,
so we can easily do this. But it will be ugly I suppose.
6.) It's a question whether we should model Dual Stack Subnet as one (so
adding cidr_v6 field and allocation_pools_v6?) Or we will model them as 2
subnets, as it it designed now.
6.1.) Adding cidr_v6 field and allocation_pools_v6 to cloud_subnet
6.2.) Modeling Dual stack subnet as 2 subnets, one of type ipv4 one of
type ipv6
I am inclining to 5.2 and 6.2, but it might complicate architecture of the
other providers, for OpenStack's sake.

Concept of Floating IPs with ipv6 is unclear to me. And seems not even
Liberty is solving that
http://docs.openstack.org/liberty/networking-guide/adv_config_ipv6.html
2.
Do you have something like Neutron Subnet pools in Nuage?
—
Reply to this email directly or view it on GitHub
https://github.com/ManageIQ/manageiq/issues/6479#issuecomment-184831395.

Not actually finished in #6043, so reopening

Hey there, will there be a consideration for Fixed IPs as well as Floating IPs - not all customers / users use OpenStack with floating IP arranges. It would be worth considering that as addition to the model.

@christx2 hello, fixed ips are now stored in network_ports_cloud_subnets relation table, as a column address.
So for IPv4 there will be one record in this table, for Ipv6 you can have multiple addresses(subnets) associated to one port.
https://github.com/ManageIQ/manageiq/pull/8445 is adding methods fixed_ip_addresses and floating_ip_addresses on NetworkPort
So Neutron's provider public networks attached directly to an interface should work.
Does this cover your usecases?

Thanks @Ladas  - looks good, as long as there is some visibility IPv4/IPv6 fixed and floating ips, as per Liberty has the introduction of dual stacking that information. I believe this should cover the use case from the field from an inventory perspective.

Just wanted to see if the Schema and provider has been agreed on finalisation, I'd like to capture what workflows we can do and capture into the database. Thanks!

@christx2 yeah, the models should be final, so far it fits all the Cloud providers we have. Only NetworkGroup model is not shown in the UI, but it is used only by a Nuage provider now, it's interchangeable with CloudNetwork model, used by others.
Let me know if this fits your needs, we've been testing that dual stacking worked for OpenStack, when designing this. If you'll need something more, we can always extend the modeling. :-)

I'm sorry if I'm making misguided noise, but I'm wondering if this married to https://bugzilla.redhat.com/show_bug.cgi?id=1375639 and if coordination is underway with the Ansible team.  Does anyone know?

@b-long it is related, not sure if somebody created an Ansible BZ, let me check

Thansk @Ladas .  It looks like @quarckster created an issue over on the Ansible repo: https://github.com/ansible/ansible/issues/24920
cc/ @Cameronwyatt

This has been implemented by a number of providers in a similar way, so closing.


Read the body message on the register when the user already exists

Is your feature request related to a problem? Please describe.
Need to show to the user the parse message from the response.
Describe the solution you'd like
The server response with

HTTP status 409

{"message":"User Already Exist"}

On file src/views/Auth/Register.vue we need to read the message property and validate if this exists;
https://github.com/itsalb3rt/cloudcsv/blob/a81e0b969afc70013e8fac0a1e893c4d9d0f164e/src/views/Auth/Register.vue#L140
You can do any like that;

const message = error.response.data && error.response.data.message ? error.response.data.message : 'We have an error, please try again in a few moment.';
this.$store.commit("snackbar/setSnackbar", {
 show: true,
 message: message,
 color: "error",
 top: true
});

Describe alternatives you've considered
None

@itsalb3rt Working on it

sure @franciscoemanuel 🙌


Assignment "resets" already narrowed type

🔎 Search Terms
"assignment operator" "type narrowing"
🕗 Version & Regression Information

This is the behavior in every version in the Playground that I tried, and I reviewed the FAQ for entries about assignment operators and narrowing (there isn't any, though)

⏯ Playground Link
https://www.typescriptlang.org/play/?ts=5.8.0-dev.20241116#code/GYVwdgxgLglg9mABAdzgJwNYGcAUAPALkXAzDmTAEoiso0YwBzRAbwChFEZhEcoBPAA4BTODzyIAvNMQAiWvSazKrDp0QSA1JLkLZAbjWc0wqCDRI8+xAHobiAIIQIwwVGEATIgHI83rliIYACGaGjknohQcIjeCgyM3moAvojCADZYwqrqiCZmFnIGKWzJbGygkLAIiFgAFnAg6R4OmXAA6ugYAEIgUAAicMJYAHJwUPhEJGQU1LV0CTlcPHxCouJSMvILSirsuRI6WnJ1GelwBrb2vv4MeXWBMIFxO4kANLF+XEjpDwGx03IYCSuXy5ks1jsiAAKmtEABRMLoHxfJ6IAD6JiyUHRURi3kBFBBiFSGSyS2MpnBRUMnDKySAA
💻 Code
function works(x: unknown): string {
  if (typeof x === "string") {
    x += "str";
    return x; // Accepted: 'x' is narrowed to 'string'
  } else {
    return "";
  }
}

function shouldAlsoWorkButDoesNot(x: unknown): string {
  if (typeof x === "string") {
    x = x + "hello"; // 'x' in rhs is 'string', 'x' in lhs is 'unknown'
    return x; // Type Error: 'x' is _reset_ to 'unknown'
  } else {
    return "";
  }
}

🙁 Actual behavior
There is two problems:

as in shouldAlsoWorkButDoesNot, after the type of x is already narrowed to string, evaluating x = x + "hello" somehow "resets" the type of x to unknown.
the behavior of += and x = x + ... is inconsistent here.

🙂 Expected behavior
x = x + ... follow the behave of +=, which is correct, in the above code example.
Additional information about the issue
Concerning inconsistency between += and x = x + ..., also see #60520.

Duplicate of #27706


Cornerstone increases system memory usage - Please help

When I try to load 100s of Dicom files into my cornerstone viewer, Chrome crashes with increased memory usage. What could be the workaround ?

Any suggestions ?

What format are they ? try loading jpeg 12bit instead of jpeg200 or raw dicoms, I've had no problem with hundreds of those.
But in general you probably looking at smarter caching where you unload not recently used images etc ...

They are raw dicoms. I have tried to unload each image after they are displayed, but still no improvements on the memory utilization. Could you please give me a small code snippet, how you have been handling to unload images, etc

Sorry as I said above I load dicom 12 bits so I don't have memory issue. Why not compress them first ?
Your problem is probably that the images are still loaded into cornerstone imageCache, you need to find out how to also remove them from there.

[FIXED!!!] @algates90 even I had this issue, decache is not happening and browser used to crash.

ArunRagav - what file/line you are referring to ? can you submit a PR ?

@ArunRagav decache() or purge() both doesnt help.

@algates90  function decache(imagePromise, imageId) accepts deferred(promise) object doesn't accepts normal promiseobject. when you call decache method make sure that you are passing deferred promise object as parameter

It appears this issue stemmed from an API misunderstanding. If you're still experiencing this issue, please open a new PR and include a minimal reproduction/example.
FWIW, I am able to decache and purge successfully. I see a clear reduction in memory usage using the profiler and in Task Manager.


METRON-1319: Column Metadata REST service should use default indices on empty input

Contributor Comments
This PR adjusts the Column Metadata REST service to use a list of default indices when an empty list is passed in.  This behavior is similar to the search method and keeps the Alerts UI from having to track the current list of available indices.
I added test cases and verified the relevant tests in our Alerts UI end-to-end test now pass.  Still need to spin up full dev and validate there.  Will report back once I have successfully done that but this can be reviewed in the meantime.
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:

[x] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

[x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?

[x] Have you included steps or a guide to how the change may be verified and tested manually?

[x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
mvn -q clean integration-test install && build_utils/verify_licenses.sh

[x] Have you written or updated unit tests and or integration tests to verify your changes?

[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

[x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

[x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:
cd site-book
mvn site

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

Still need to spin up full dev and validate there. Will report back once I have successfully done that but this can be reviewed in the meantime.

@merrimanr Did you run this up in Full Dev?

The latest commit only includes comments and an additional LOG statement.  I didn't think rebuilding full dev was necessary.

Unless I missed it, I just don't see confirmation that you ran this change up in Full Dev. If you already did, I am just looking for confirmation.  I am not asking you to run it up again, after adding logging.

Stated differently... Your PR description says "I need to run this up in Full Dev."  I am just looking for confirmation that you did that.  That's all.

+1 LGTM.  No need to run it up again.


Small BoxLeastSquaresPeriodogam improvements

TODO: Plotting probably breaks due to the change in durations,

Codecov Report

Merging #438 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #438      +/-   ##
==========================================
- Coverage   86.94%   86.85%   -0.09%
==========================================
  Files          28       28
  Lines        5085     5083       -2
==========================================
- Hits         4421     4415       -6
- Misses        664      668       +4

Impacted Files
Coverage Δ

lightkurve/lightcurve.py
93.24% <ø> (ø)
:arrow_up:

lightkurve/periodogram.py
90.54% <100%> (+0.2%)
:arrow_up:

lightkurve/prf/tpfmodel.py
75.7% <0%> (-1.58%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 896e9f0...29f0084. Read the comment docs.


[New ATF recipe] atf: Rework recipe

This PR is expected to work together with https://github.com/xen-troops/meta-xt-rcar/pull/15

@lorc Could you please look into this PR?
I feel that It's not "well done", and need some more "roasting".
Also, https://github.com/xen-troops/meta-xt-rcar/pull/15 is an additional part of this change.

@otyshchenko1 @lorc
Could you please take a look into this PR, when possible?
I will be glad to hear all your comments because I understand that this PR is far from the best possible solution.

Hi @rshym,
You did a good job reworking this recipe. I'm fine with the code itself, but there are some comments:

This is patch for meta-renesas. We generally don't want to make own changes to meta-renesas. We have this layer on XenTroops Github only because Renesas provides some patches on top of their own layer. As we don't want Moulin to patch downloaded code, we store patches version on our GitHub.

So, in my opinion you need to move this recipe to meta-xt-rcar/meta-xt-rcar-fixups. Also, it would be cool to create PR to Renesas GitHub. Dunno if they will take it, but we can try at lest.

You need to split this patch into two parts:  first one should rework build and second one should add our own patches.

Thanks!
I will rework PR.


Upload Android APK to S3

At Chauffeur Privé, we are big fans of fastlane tools so we propose a simple plugin to be able to upload an APK to amazon S3.
The current s3 upload plugin is very helpful but unfortunately it doesn't handle very well APKs.. so we decided to create a S3 APK plugin inspired by the actual s3 plugin.
The plugin is available here :
https://github.com/transcovo/fastlane-plugin-s3-android
Feel free to download it, use it, comment it as needed :-)
I hope this will help some of us using fastlane with Android to build better apps
Cheeers

Thanks @jerome-cp 👍
I'm going to close this issue since there isn't action we can take here. We'll be sure to include this plugin in the available plugins list on our next release 🚀

Great ! 👍


Create single restaurant result page

-Heart icon for favoriting a restaurant
-Dollar icon for listing average price of a restaurant
-Photos, selection of photos feed (show limited amount of photos, default most recent, click see all to view full feed on separate component or page TBD)
-Reviews, selection of reviews (default sort  by recent)
-Map it, hyperlink address on google maps
-Phone number, tel hyperlink
Other:
change styles to name of file it is using the styles in (change RobynStyle.tsx to SingleSearchResultStyles.tsx naming convention)

@Kimberly-Rodriguez Use the getRestaurant() server call to get the dummy data. Its ready to go!

Need to display if this is a favorite or not for the specific user. Maybe just some kind of icon that turns yellow if it is and grey if its not?

Creating SingleRestaurant page

@MatteoThomas @johndavis92790 Dang, the API call broke since last merge into develop. Pull 122 https://github.com/Healthy-Plate-Project/Healthy-Eating-App/pull/122

Ok, I'll check it out

What error are you getting? It seems to work for me?

When I press Single Result in menu it was bringing in a restaurant, but no longer is now. There are a couple errors.

Failed to load resource: net::ERR_CONNECTION_REFUSED for the restaurant api
AxiosError code"ERR_NETWORK"

Yes I am up to date. Does test api call on home page work for you still?
I'll try on my other computer.
On Tue, Oct 18, 2022, 1:01 PM Matthew Elliott @.***>
wrote:

I hate to ask, have you pulled recently?
—
Reply to this email directly, view it on GitHub
https://github.com/Healthy-Plate-Project/Healthy-Eating-App/issues/12#issuecomment-1282935523,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD3BZR2E7X263O4RZZFXB4LWD36ZPANCNFSM553QEY6A
.
You are receiving this because you were assigned.Message ID:
@.***>

@MatteoThomas is working on my other computer now. Weird! Thanks for checking yours.


clean up asm.js/wasm entrypoint management

There were a few places where asm.js strayed needlessly from how js manages entrypoints.
In case of NativeAddress usage, there was a race condition that could lead to us calling direct JIT address rather than the JIT thunk, leading to CFG failure.
It also looks like we may have been leaking old entrypoints.
OS: 12228631

Like we talked yesterday, this is most likely breaking templatizedJit even further. But, we need to do a rework of how we handle entry points in asmjs/wasm anyway.
So as long as this fixes your bug, LGTM


Zoning + Alexa

Hi! I read about the post on zoning. But someone could explain me how to integrate to clean a specific area with the voice?

You can write a script which would send request with MQTT payload to device or use Home Assistant integration with alexa


chore: add stage to runtimes command [sc-00]

I hereby confirm that I followed the code guidelines found at engineering guidelines
Affected Components

[x] CLI
[ ] Create CLI
[ ] Test
[ ] Docs
[ ] Examples
[ ] Other

Notes for the Reviewer
Add missing stage property to runtimes command

@ianaya89 what problem does this solve? Please make PR's explicit.

It looks explicit enough to me,  the stage property is missing when you list runtimes...
I think it's good to know if the runtime is beta, stable or deprecated

@tnolet It looks explicit enough to me (it's a one-liner). The stage property is missing when you list runtimes... I think it's good to know if the runtime is beta, stable or deprecated.

@ianaya89 all good, let's merge


[Feature]: Build the Zufall Labs landing page

🌟 Situation
Currently there is only a placeholder present when visiting the Zufall Labs landing page.
🎯 Task
The task is to change the placeholder landing page to an actual landing page, which displays some information about Zufall Labs itself and the products which are being developed.
🛠 Action
Take the UI Figma prototype and implement the landing page accordingly. We decided on Svelte for the UI Framework, which should be used.
🏆 Result
The implemented Figma prototype in Svelte.
🙋♀ Are you willing to contribute to this feature?
Not at this time, but I'm excited to see it implemented!
📝 Code of Conduct

[X] I agree to follow this project's Code of Conduct

Update 20.08.2024: No progress, should be done within 2 weeks.

@RichardWeller Update?

Still missing:

GitHub integration

styling
fetching per API only returns the user stories of the user who sends the request

Mobile styling
Texts instead of placeholder
Fine tuning
General code quality (comments, ...)


add forbidden_dependency_binary! options.

add forbidden_dependency_binary!, Prevent the automatic compilation of dependent libraries into binary as well.

@ghostlordstar Thanks!


[Storage] Live test pipeline for storage-file-datalake

TO DO -

Use the storage account for file-datalake sdk created by the template,
properly propagate the values like DFS_ACCOUNT_NAME, etc and
have the pipeline setup similar to the other three storage-packages.

References

https://github.com/Azure/azure-sdk-for-js/pull/6982#issuecomment-582072692
https://github.com/Azure/azure-sdk-for-js/pull/7195

I think the live test pipeline is properly set up now for storage-file-datalake.
https://dev.azure.com/azure-sdk/internal/_build?definitionId=1808


chore: convert effect serializer to TypeScript

Refs #293. Draft, builds on #294.
Convert effect serializer and test directly over to TypeScript.

Rebased and reviewable now


Remove v2.ocaml.org

v2.ocaml.org is now a redirect to ocaml.org.

Looks like we need a dune promote to fix the lint error: https://ocaml.ci.dev/github/ocurrent/ocurrent-deployer/commit/a0ecce6fdecbf9b7ab60b163e21eae401f439361/variant/(lint-doc)


Erratic mouse tool behaviour when mousemove or mouseup are done out of the canvas

Describe the bug
Mouse events are lost when are done out of the canvas, producing erratic behaviours.
To Reproduce
Steps to reproduce the behavior:

Select move tool.
Click on the element to move and whitout releasing the button, move the mouse outside of the canvas.
Release the button clicked out of the canvas.
Return the pointer in the canvas and move it. The object continues moving as if the button was clicked, but it is not.

Expected behavior
The button clicked event should be applicable to all the window and not only to the canvas.
Currently the events of mouseup and mousemove are only listening when they are originated in the canvas.
    canvas.addEventListener("mouseup", (e) => this.mouseUp());
    canvas.addEventListener("mousemove", (e) => this.mouseMove(fromMouseEvent(e)));

Possible solution could be add these two listeners to the window:
    window.addEventListener("mouseup", (e) => this.mouseUp());
    window.addEventListener("mousemove", (e) => this.mouseMove(fromMouseEvent(e)));

Hi Victor,
Thanks for the feedback.
I'm not really in favor of listening mousemove events outside of the canvas since it would allow the users to move the streams outside without any way to move back it into the canvas if the mouse button had been released.
On the other hand I agree with you regarding the mouseup event, it should be listened even if it occurs outside.
I think this is a good compromise (listening to the mouseup event, if the user releases the button outside the canvas, he'll get out of the "move" mode, otherwise, he'll be able to keep moving the stream when the cursor comes back in the canvas)

Super! Thank you for your quick answer


Collections list from Solr as JSON

I'm using Solr 5.0 and ZooKeeper 3.4.6 and had problem with detecting collections.
I repeatedly got:
Found no Solr instance hosting collection testCollection
And I was sure that collection exists. So I debugged it a little and found out that variable data in getSolrCollections() is XML. So I did a little tweak and now if someone adds '&wt=json' to solrCollectionsGetEndPoint data is JSON and bundle can be created.
From here on everything works great.
Thanks.

d7ark,
Thanks for the contribution. I am adding your logics to version 0.2.0 now in develop branch.
I have elaborated a bit further and added support for solrconfig.xml specifying default query response writer other than XMLResponseWriter. I.e. the Solr collections GET end point may not even include e.g. 'wt=json' for the response to be of JSON content type. I thus added inspection of REST client response' content type for proper parsing of REST client data.

Darek,
What I had in mind was the possibility that you had installed the node-solr-smart-client with npm install in your own code project and thereafter made changes to its dependency on node-rest-client. But from your answer it sounds as if this is not the case. :)
If you use a fairly straight forward solrconfig.xml you surely need to add wt=json to get the result back in JSON format. The reason is that XMLResponseWriter is the default one if not explicitly configured in solrconfig.xml. As stated in comment in my Solr 4.10 solrconfig.xml:
<!-- Response Writers

         http://wiki.apache.org/solr/QueryResponseWriter

         Request responses will be written using the writer specified by
         the 'wt' request parameter matching the name of a registered
         writer.

         The "default" writer is the default and will be used if 'wt' is
         not specified in the request.
      -->
    <!-- The following response writers are implicitly configured unless
         overridden...
      -->
    <!--
       <queryResponseWriter name="xml"
                            default="true"
                            class="solr.XMLResponseWriter" />
       <queryResponseWriter name="json" class="solr.JSONResponseWriter"/>
       <queryResponseWriter name="python" class="solr.PythonResponseWriter"/>
       <queryResponseWriter name="ruby" class="solr.RubyResponseWriter"/>
       <queryResponseWriter name="php" class="solr.PHPResponseWriter"/>
       <queryResponseWriter name="phps" class="solr.PHPSerializedResponseWriter"/>
       <queryResponseWriter name="csv" class="solr.CSVResponseWriter"/>
       <queryResponseWriter name="schema.xml" class="solr.SchemaXmlResponseWriter"/>
      -->

But what puzzled about your pull request is that in the JSON return data processing, irrespective of whether wt=json is used or solrconfig.xml sets JSONResponseWriter as default, you added JSON.parse(data) in order to obtain an object. In my testing the parsing failed and I found that data was already a full-fledged object and not a string in the callback of node-rest-client's get.
Thanks a lot for the contribution. I really appreciate it. My time schedule is also pretty packed, thus this project does not get much of my attention. I only update when I have the need in other projects. :)
One thing I would like to add at some point is the ability to update the node-solr-client instance if the connected Solr server node one goes down. I.e. if the host pointed to by the node-solr-client instance yielded in node-solr-smart-client's createClient callback goes offline, /live_nodes in ZooKeeper is updated accordingly. Thus watching this znode one I reckon one should be able to update the node-solr-instance. Just some food for thought. :)
Regards, Jens Ivar


Only allow once cta per page load

Task/Issue URL:
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #2128

PR #2129
PR #2155
PR #2178
PR #2181
PR #2189   👈

PR #2188

This comment was auto-generated by Graphite.


Render order

Re-organise the rendering order of the game systems so components don't appear on top of each weirdly

Changed render order in SystemManager by splitting EffectsSystem:render() into multiple functions


Nightly deploy pinot to bintray

This PR adds code to nightly deploy pinot to bintray.

Closing this PR since the .m2 cache in this PR becomes too large and Travis couldn't load it in 10 mins.
The new finalized PR is in https://github.com/apache/incubator-pinot/pull/5190.


Update db.base.yml

solved following error when importing a dump:
ERROR 1419 (HY000) at line 693: You do not have the SUPER privilege and binary logging is enabled (you might want to use the less safe log_bin_trust_function_creators variable)
SEE here:
https://github.com/davidalger/warden/issues/354
close #354

Closing in favor of #403 which makes this setting no longer necessary as it only applies to MySQL where binary logging is enabled..


Need to specify compilers when building lldb

Simple tweak to build script so clang-cl is specified when building lldb on windows

The problem is that using clang-cl actually makes debugging lldb much harder.  Please add a note to that effect, and use the value clang-cl rather than the absolute path to clang-cl.

Ah I see, I assumed it was just a missing line in the code. It is probably fine to leave as in then, feel free to decline this pull request since I don't know the details of what you mean by "makes debugging lldb harder"

The debug info generated by clang is not as robust as the one built by Visual a studio, so you lose some of the expression evaluation and local variable information.  The PDB support in clang is improving but getting everything stable is the first goal (a small reduction in debugging after that won’t matter as much since you can try to find regressions and have the history to help you narrow down the changes).
I’m not opposed to the change, just think that it might be a good idea to explicitly call that out.

Looks like the documentation on master now has -DCMAKE_C_COMPILER=clang-cl, so I think that supersedes this PR, hence closing. Please feel free to re-open if closing this was a mistake!


cmd/cue: cue import unnecesarily escapes double quotes in multiline strings

commit ff306b79708eee06adaa73e6fb62449278727101
Running cue import on the following JSON produces CUE output that escapes the double-quotes even though there's no need to escape them unless there are three in a row:
{
	"x": "foo \n\"bar\""
}

This produces:
x: """
        foo
        \"bar\"
        """

I'd expect to see:
x: """
        foo
        "bar"
        """

See also https://github.com/cuelang/cue/issues/389

This issue has been migrated to https://github.com/cue-lang/cue/issues/541.
For more details about CUE's migration to a new home, please see https://github.com/cue-lang/cue/issues/1078.


OPEN POLL

just kidding, any issues or implementations that I can help with?

play music feature
editing the meme function so that it accepts images as input and update the default templates for it
host the bot in the cloud
update the AI function so we can access the history when generating a new reply
updating the README file

closing this issue and moving this chat to #3


patched missing write function from original repo

Your fork as it is did not compile and complained about a missing write function, I added it but as some naming have changed for width and height, I blindly copied from some similar to the file.
Now at least I compile and pop a hex out, but I'm still not confident enough to start with functionnal tests on the watch.

Thanks!


Feat/utf8

Default Option
goarch: amd64
pkg: github.com/bytedance/sonic/generic_test
cpu: Intel(R) Xeon(R) Platinum 8260 CPU @ 2.40GHz
                                          │ /tmp/tmpr2kzo8wd.source.txt │     /tmp/tmp7brs5a7z.target.txt      │
                                          │           sec/op            │    sec/op     vs base                │
UnmarshalConcrete/CanadaGeometry_Sonic-8                   1.022m ± 11%   1.190m ±  8%  +16.46% (p=0.000 n=10)
UnmarshalConcrete/CitmCatalog_Sonic-8                      6.418m ± 18%   6.629m ±  4%        ~ (p=0.739 n=10)
UnmarshalConcrete/GolangSource_Sonic-8                     17.13m ±  4%   17.55m ±  5%        ~ (p=0.123 n=10)
UnmarshalConcrete/StringEscaped_Sonic-8                   112.16µ ±  8%   96.83µ ±  5%  -13.67% (p=0.000 n=10)
UnmarshalConcrete/StringUnicode_Sonic-8                    11.07µ ±  5%   11.98µ ±  5%   +8.19% (p=0.000 n=10)
UnmarshalConcrete/SyntheaFhir_Sonic-8                      12.91m ±  4%   12.88m ±  4%        ~ (p=0.796 n=10)
UnmarshalConcrete/TwitterStatus_Sonic-8                    2.671m ±  4%   2.632m ±  5%        ~ (p=0.393 n=10)
UnmarshalInterface/CanadaGeometry_Sonic-8                  3.512m ±  7%   3.592m ±  4%        ~ (p=0.353 n=10)
UnmarshalInterface/CitmCatalog_Sonic-8                     11.45m ±  2%   11.61m ±  9%        ~ (p=0.739 n=10)
UnmarshalInterface/GolangSource_Sonic-8                    19.81m ±  6%   20.12m ±  2%        ~ (p=0.247 n=10)
UnmarshalInterface/StringEscaped_Sonic-8                   121.2µ ±  5%   105.9µ ±  6%  -12.57% (p=0.000 n=10)
UnmarshalInterface/StringUnicode_Sonic-8                   25.58µ ±  5%   25.68µ ±  4%        ~ (p=0.912 n=10)
UnmarshalInterface/SyntheaFhir_Sonic-8                     13.44m ±  7%   13.77m ±  4%        ~ (p=0.436 n=10)
UnmarshalInterface/TwitterStatus_Sonic-8                   3.895m ±  7%   3.987m ± 10%   +2.37% (p=0.023 n=10)
MarshalConcrete/CanadaGeometry_Sonic-8                     944.6µ ±  2%   927.6µ ±  7%        ~ (p=0.684 n=10)
MarshalConcrete/CitmCatalog_Sonic-8                        924.1µ ±  6%   980.3µ ±  5%   +6.08% (p=0.002 n=10)
MarshalConcrete/GolangSource_Sonic-8                       3.423m ±  4%   3.429m ±  9%        ~ (p=0.684 n=10)
MarshalConcrete/StringEscaped_Sonic-8                      7.195µ ±  6%   7.372µ ±  3%        ~ (p=0.325 n=10)
MarshalConcrete/StringUnicode_Sonic-8                      7.273µ ±  2%   7.100µ ± 12%        ~ (p=0.105 n=10)
MarshalConcrete/SyntheaFhir_Sonic-8                        12.67m ± 11%   12.68m ±  6%        ~ (p=0.912 n=10)
MarshalConcrete/TwitterStatus_Sonic-8                      421.9µ ±  9%   400.4µ ±  5%        ~ (p=0.190 n=10)
MarshalInterface/CanadaGeometry_Sonic-8                    1.607m ±  2%   1.668m ±  5%        ~ (p=0.353 n=10)
MarshalInterface/CitmCatalog_Sonic-8                       4.031m ±  5%   4.058m ±  5%        ~ (p=0.971 n=10)
MarshalInterface/GolangSource_Sonic-8                      11.04m ±  4%   11.72m ±  7%   +6.16% (p=0.029 n=10)
MarshalInterface/StringEscaped_Sonic-8                     13.34µ ±  6%   13.19µ ±  4%        ~ (p=0.353 n=10)
MarshalInterface/StringUnicode_Sonic-8                     13.47µ ±  3%   13.50µ ±  5%        ~ (p=0.912 n=10)
MarshalInterface/SyntheaFhir_Sonic-8                       7.203m ±  6%   7.291m ±  4%        ~ (p=0.684 n=10)
MarshalInterface/TwitterStatus_Sonic-8                     1.738m ±  5%   1.649m ±  7%   -5.11% (p=0.005 n=10)
geomean                                                    915.1µ         919.7µ         +0.50%

Std Option
cpu: Intel(R) Xeon(R) Platinum 8260 CPU @ 2.40GHz
                                             │ /tmp/tmp8yr04ke5.source.txt │     /tmp/tmpbzb9wb12.target.txt      │
                                             │           sec/op            │    sec/op     vs base                │
UnmarshalConcrete/CanadaGeometry_SonicStd-8                   1.016m ±  6%   1.146m ± 15%  +12.84% (p=0.000 n=10)
UnmarshalConcrete/CitmCatalog_SonicStd-8                      6.823m ±  4%   6.940m ±  4%        ~ (p=0.353 n=10)
UnmarshalConcrete/GolangSource_SonicStd-8                     18.87m ± 11%   18.06m ±  5%        ~ (p=0.190 n=10)
UnmarshalConcrete/StringEscaped_SonicStd-8                   108.36µ ±  5%   97.59µ ±  6%   -9.94% (p=0.003 n=10)
UnmarshalConcrete/StringUnicode_SonicStd-8                    19.83µ ±  5%   21.81µ ±  3%  +10.00% (p=0.000 n=10)
UnmarshalConcrete/SyntheaFhir_SonicStd-8                      14.45m ±  4%   14.31m ±  4%        ~ (p=0.436 n=10)
UnmarshalConcrete/TwitterStatus_SonicStd-8                    2.995m ±  6%   3.012m ±  4%        ~ (p=0.631 n=10)
UnmarshalInterface/CanadaGeometry_SonicStd-8                  3.477m ±  6%   3.474m ±  5%        ~ (p=0.579 n=10)
UnmarshalInterface/CitmCatalog_SonicStd-8                     12.63m ±  5%   12.53m ±  3%        ~ (p=0.481 n=10)
UnmarshalInterface/GolangSource_SonicStd-8                    23.90m ±  9%   23.23m ±  6%        ~ (p=0.353 n=10)
UnmarshalInterface/StringEscaped_SonicStd-8                   119.6µ ±  5%   107.7µ ±  3%   -9.95% (p=0.004 n=10)
UnmarshalInterface/StringUnicode_SonicStd-8                   39.89µ ±  4%   39.79µ ±  4%        ~ (p=0.869 n=10)
UnmarshalInterface/SyntheaFhir_SonicStd-8                     17.43m ±  6%   16.82m ±  4%        ~ (p=0.063 n=10)
UnmarshalInterface/TwitterStatus_SonicStd-8                   5.121m ±  7%   5.024m ±  7%        ~ (p=0.631 n=10)
MarshalConcrete/CanadaGeometry_SonicStd-8                     960.0µ ± 13%   954.5µ ±  5%        ~ (p=0.971 n=10)
MarshalConcrete/CitmCatalog_SonicStd-8                        1.009m ±  5%   1.090m ±  4%   +8.07% (p=0.000 n=10)
MarshalConcrete/GolangSource_SonicStd-8                       3.698m ±  8%   3.535m ±  4%   -4.40% (p=0.000 n=10)
MarshalConcrete/StringEscaped_SonicStd-8                      20.51µ ±  4%   21.85µ ±  3%   +6.58% (p=0.000 n=10)
MarshalConcrete/StringUnicode_SonicStd-8                      20.11µ ±  6%   22.40µ ±  6%  +11.40% (p=0.001 n=10)
MarshalConcrete/SyntheaFhir_SonicStd-8                        15.59m ±  5%   15.21m ±  6%        ~ (p=0.218 n=10)
MarshalConcrete/TwitterStatus_SonicStd-8                      480.2µ ±  6%   494.1µ ±  8%   +2.91% (p=0.023 n=10)
MarshalInterface/CanadaGeometry_SonicStd-8                    1.665m ±  4%   1.646m ±  2%        ~ (p=0.393 n=10)
MarshalInterface/CitmCatalog_SonicStd-8                       4.545m ±  4%   4.655m ±  8%        ~ (p=0.218 n=10)
MarshalInterface/GolangSource_SonicStd-8                      13.58m ±  4%   12.92m ±  3%   -4.86% (p=0.002 n=10)
MarshalInterface/StringEscaped_SonicStd-8                     30.45µ ±  5%   33.46µ ±  2%   +9.88% (p=0.000 n=10)
MarshalInterface/StringUnicode_SonicStd-8                     30.24µ ±  8%   33.12µ ±  5%   +9.54% (p=0.001 n=10)
MarshalInterface/SyntheaFhir_SonicStd-8                       8.194m ±  6%   8.336m ±  5%        ~ (p=0.971 n=10)
MarshalInterface/TwitterStatus_SonicStd-8                     2.457m ±  6%   2.524m ±  3%        ~ (p=0.315 n=10)
geomean                                                       1.184m         1.196m         +0.99%

Fuzztest
fuzz: elapsed: 24m51s, execs: 3374501 (0/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 24m54s, execs: 3382839 (2780/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 24m57s, execs: 3398065 (5076/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m0s, execs: 3399279 (405/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m3s, execs: 3399280 (0/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m6s, execs: 3400246 (322/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m9s, execs: 3441313 (13689/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m12s, execs: 3441326 (4/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m15s, execs: 3452488 (3720/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m18s, execs: 3458770 (2094/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m21s, execs: 3460909 (713/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m24s, execs: 3460909 (0/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m27s, execs: 3475142 (4747/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m30s, execs: 3484011 (2957/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m33s, execs: 3484565 (185/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m36s, execs: 3508689 (8041/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m39s, execs: 3513851 (1720/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m42s, execs: 3517690 (1280/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m45s, execs: 3522634 (1648/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m48s, execs: 3525419 (928/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m51s, execs: 3526398 (326/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m54s, execs: 3528995 (866/sec), new interesting: 57 (total: 3087)

this also fix #319, use cross-compile flags in Makefile.

Details:
Default Option
goarch: amd64
pkg: github.com/bytedance/sonic/generic_test
cpu: Intel(R) Xeon(R) Platinum 8260 CPU @ 2.40GHz
                                          │ /tmp/tmpr2kzo8wd.source.txt │     /tmp/tmp7brs5a7z.target.txt      │
                                          │           sec/op            │    sec/op     vs base                │
UnmarshalConcrete/CanadaGeometry_Sonic-8                   1.022m ± 11%   1.190m ±  8%  +16.46% (p=0.000 n=10)
UnmarshalConcrete/CitmCatalog_Sonic-8                      6.418m ± 18%   6.629m ±  4%        ~ (p=0.739 n=10)
UnmarshalConcrete/GolangSource_Sonic-8                     17.13m ±  4%   17.55m ±  5%        ~ (p=0.123 n=10)
UnmarshalConcrete/StringEscaped_Sonic-8                   112.16µ ±  8%   96.83µ ±  5%  -13.67% (p=0.000 n=10)
UnmarshalConcrete/StringUnicode_Sonic-8                    11.07µ ±  5%   11.98µ ±  5%   +8.19% (p=0.000 n=10)
UnmarshalConcrete/SyntheaFhir_Sonic-8                      12.91m ±  4%   12.88m ±  4%        ~ (p=0.796 n=10)
UnmarshalConcrete/TwitterStatus_Sonic-8                    2.671m ±  4%   2.632m ±  5%        ~ (p=0.393 n=10)
UnmarshalInterface/CanadaGeometry_Sonic-8                  3.512m ±  7%   3.592m ±  4%        ~ (p=0.353 n=10)
UnmarshalInterface/CitmCatalog_Sonic-8                     11.45m ±  2%   11.61m ±  9%        ~ (p=0.739 n=10)
UnmarshalInterface/GolangSource_Sonic-8                    19.81m ±  6%   20.12m ±  2%        ~ (p=0.247 n=10)
UnmarshalInterface/StringEscaped_Sonic-8                   121.2µ ±  5%   105.9µ ±  6%  -12.57% (p=0.000 n=10)
UnmarshalInterface/StringUnicode_Sonic-8                   25.58µ ±  5%   25.68µ ±  4%        ~ (p=0.912 n=10)
UnmarshalInterface/SyntheaFhir_Sonic-8                     13.44m ±  7%   13.77m ±  4%        ~ (p=0.436 n=10)
UnmarshalInterface/TwitterStatus_Sonic-8                   3.895m ±  7%   3.987m ± 10%   +2.37% (p=0.023 n=10)
MarshalConcrete/CanadaGeometry_Sonic-8                     944.6µ ±  2%   927.6µ ±  7%        ~ (p=0.684 n=10)
MarshalConcrete/CitmCatalog_Sonic-8                        924.1µ ±  6%   980.3µ ±  5%   +6.08% (p=0.002 n=10)
MarshalConcrete/GolangSource_Sonic-8                       3.423m ±  4%   3.429m ±  9%        ~ (p=0.684 n=10)
MarshalConcrete/StringEscaped_Sonic-8                      7.195µ ±  6%   7.372µ ±  3%        ~ (p=0.325 n=10)
MarshalConcrete/StringUnicode_Sonic-8                      7.273µ ±  2%   7.100µ ± 12%        ~ (p=0.105 n=10)
MarshalConcrete/SyntheaFhir_Sonic-8                        12.67m ± 11%   12.68m ±  6%        ~ (p=0.912 n=10)
MarshalConcrete/TwitterStatus_Sonic-8                      421.9µ ±  9%   400.4µ ±  5%        ~ (p=0.190 n=10)
MarshalInterface/CanadaGeometry_Sonic-8                    1.607m ±  2%   1.668m ±  5%        ~ (p=0.353 n=10)
MarshalInterface/CitmCatalog_Sonic-8                       4.031m ±  5%   4.058m ±  5%        ~ (p=0.971 n=10)
MarshalInterface/GolangSource_Sonic-8                      11.04m ±  4%   11.72m ±  7%   +6.16% (p=0.029 n=10)
MarshalInterface/StringEscaped_Sonic-8                     13.34µ ±  6%   13.19µ ±  4%        ~ (p=0.353 n=10)
MarshalInterface/StringUnicode_Sonic-8                     13.47µ ±  3%   13.50µ ±  5%        ~ (p=0.912 n=10)
MarshalInterface/SyntheaFhir_Sonic-8                       7.203m ±  6%   7.291m ±  4%        ~ (p=0.684 n=10)
MarshalInterface/TwitterStatus_Sonic-8                     1.738m ±  5%   1.649m ±  7%   -5.11% (p=0.005 n=10)
geomean                                                    915.1µ         919.7µ         +0.50%

Std Option
cpu: Intel(R) Xeon(R) Platinum 8260 CPU @ 2.40GHz
                                             │ /tmp/tmp8yr04ke5.source.txt │     /tmp/tmpbzb9wb12.target.txt      │
                                             │           sec/op            │    sec/op     vs base                │
UnmarshalConcrete/CanadaGeometry_SonicStd-8                   1.016m ±  6%   1.146m ± 15%  +12.84% (p=0.000 n=10)
UnmarshalConcrete/CitmCatalog_SonicStd-8                      6.823m ±  4%   6.940m ±  4%        ~ (p=0.353 n=10)
UnmarshalConcrete/GolangSource_SonicStd-8                     18.87m ± 11%   18.06m ±  5%        ~ (p=0.190 n=10)
UnmarshalConcrete/StringEscaped_SonicStd-8                   108.36µ ±  5%   97.59µ ±  6%   -9.94% (p=0.003 n=10)
UnmarshalConcrete/StringUnicode_SonicStd-8                    19.83µ ±  5%   21.81µ ±  3%  +10.00% (p=0.000 n=10)
UnmarshalConcrete/SyntheaFhir_SonicStd-8                      14.45m ±  4%   14.31m ±  4%        ~ (p=0.436 n=10)
UnmarshalConcrete/TwitterStatus_SonicStd-8                    2.995m ±  6%   3.012m ±  4%        ~ (p=0.631 n=10)
UnmarshalInterface/CanadaGeometry_SonicStd-8                  3.477m ±  6%   3.474m ±  5%        ~ (p=0.579 n=10)
UnmarshalInterface/CitmCatalog_SonicStd-8                     12.63m ±  5%   12.53m ±  3%        ~ (p=0.481 n=10)
UnmarshalInterface/GolangSource_SonicStd-8                    23.90m ±  9%   23.23m ±  6%        ~ (p=0.353 n=10)
UnmarshalInterface/StringEscaped_SonicStd-8                   119.6µ ±  5%   107.7µ ±  3%   -9.95% (p=0.004 n=10)
UnmarshalInterface/StringUnicode_SonicStd-8                   39.89µ ±  4%   39.79µ ±  4%        ~ (p=0.869 n=10)
UnmarshalInterface/SyntheaFhir_SonicStd-8                     17.43m ±  6%   16.82m ±  4%        ~ (p=0.063 n=10)
UnmarshalInterface/TwitterStatus_SonicStd-8                   5.121m ±  7%   5.024m ±  7%        ~ (p=0.631 n=10)
MarshalConcrete/CanadaGeometry_SonicStd-8                     960.0µ ± 13%   954.5µ ±  5%        ~ (p=0.971 n=10)
MarshalConcrete/CitmCatalog_SonicStd-8                        1.009m ±  5%   1.090m ±  4%   +8.07% (p=0.000 n=10)
MarshalConcrete/GolangSource_SonicStd-8                       3.698m ±  8%   3.535m ±  4%   -4.40% (p=0.000 n=10)
MarshalConcrete/StringEscaped_SonicStd-8                      20.51µ ±  4%   21.85µ ±  3%   +6.58% (p=0.000 n=10)
MarshalConcrete/StringUnicode_SonicStd-8                      20.11µ ±  6%   22.40µ ±  6%  +11.40% (p=0.001 n=10)
MarshalConcrete/SyntheaFhir_SonicStd-8                        15.59m ±  5%   15.21m ±  6%        ~ (p=0.218 n=10)
MarshalConcrete/TwitterStatus_SonicStd-8                      480.2µ ±  6%   494.1µ ±  8%   +2.91% (p=0.023 n=10)
MarshalInterface/CanadaGeometry_SonicStd-8                    1.665m ±  4%   1.646m ±  2%        ~ (p=0.393 n=10)
MarshalInterface/CitmCatalog_SonicStd-8                       4.545m ±  4%   4.655m ±  8%        ~ (p=0.218 n=10)
MarshalInterface/GolangSource_SonicStd-8                      13.58m ±  4%   12.92m ±  3%   -4.86% (p=0.002 n=10)
MarshalInterface/StringEscaped_SonicStd-8                     30.45µ ±  5%   33.46µ ±  2%   +9.88% (p=0.000 n=10)
MarshalInterface/StringUnicode_SonicStd-8                     30.24µ ±  8%   33.12µ ±  5%   +9.54% (p=0.001 n=10)
MarshalInterface/SyntheaFhir_SonicStd-8                       8.194m ±  6%   8.336m ±  5%        ~ (p=0.971 n=10)
MarshalInterface/TwitterStatus_SonicStd-8                     2.457m ±  6%   2.524m ±  3%        ~ (p=0.315 n=10)
geomean                                                       1.184m         1.196m         +0.99%

Fuzztest
fuzz: elapsed: 24m51s, execs: 3374501 (0/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 24m54s, execs: 3382839 (2780/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 24m57s, execs: 3398065 (5076/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m0s, execs: 3399279 (405/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m3s, execs: 3399280 (0/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m6s, execs: 3400246 (322/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m9s, execs: 3441313 (13689/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m12s, execs: 3441326 (4/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m15s, execs: 3452488 (3720/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m18s, execs: 3458770 (2094/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m21s, execs: 3460909 (713/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m24s, execs: 3460909 (0/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m27s, execs: 3475142 (4747/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m30s, execs: 3484011 (2957/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m33s, execs: 3484565 (185/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m36s, execs: 3508689 (8041/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m39s, execs: 3513851 (1720/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m42s, execs: 3517690 (1280/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m45s, execs: 3522634 (1648/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m48s, execs: 3525419 (928/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m51s, execs: 3526398 (326/sec), new interesting: 57 (total: 3087)
fuzz: elapsed: 25m54s, execs: 3528995 (866/sec), new interesting: 57 (total: 3087)


(Fix) link to Deployment Time & Gas in README

Fix the link in README to Deployment Time & Gas section in wiki

Pull Request Test Coverage Report for Build 1630

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 14.371%

Totals

Change from base Build 1624:
0.0%

Covered Lines:
351

Relevant Lines:
1930

💛  - Coveralls


Project logo

It would be awesome to have a pretty logo for this project, right?

Temporary logo set, with the Pacifico font.
Let's call it a day o/

nice


Implement Serialize for Value

Value doesn't seem to implement Serialize, but does implement Deserialize. Is there a reason for this? It would be handy to be able to serialize the value, since serializing doesn't need ownership of a value typically.

I started it but discontinued, since it's a lot of code to adjust and I didn't need it
I pushed the current (broken) state to the add_serialization branch, if you want to continue
https://github.com/PSeitz/serde_json_borrow/blob/add_serialization/src/ser.rs
Or start over from https://github.com/serde-rs/json/blob/master/src/value/ser.rs