V1.5 updates

Guys I pushed my changes. Here are things I see that we still need:
sec. 5.4 needs to be beefed up
please check the links to sections in the checklist section
Fig 1 needs to be replaced - they want $315 to use it
We need permissions for some of the other figures. I got the ones from my papers. Can someone track down the others? It is typically just an online request.
I didn't do anything with sections 6.3 and 6.4. They need work.
Need to write conclusions.

@ejmaginn
Great, I will look at this today.

sec. 5.4 needs to be beefed up

Do we just want to remove these special topics altogether? I personally do not know much about diffusion in membranes. Can we just mention the possible concerns and reference the literature?

Fig 1 needs to be replaced - they want $315 to use it

Alright. That was a pretty low quality image anyways, I was just trying to diversify our references. I will find something better or make my own image.

Can someone track down the others? It is typically just an online request.

Will do.

I didn't do anything with sections 6.3 and 6.4. They need work.

Yes, I agree. I will take a stab at this.

Need to write conclusions.

I think @dcarls0n was working on this. Do you have something to push yet?
I was thinking that we should include a section called "validation" where we recommend comparing your simulation results with the NIST standard reference simulation database. I think this would be important for improving reproducability and ensuring reasonable data output, which is right in line with the aims of this manuscript. Does anyone object to that?

It’s been rather busy this past week with the semester ending and family being in town. I should have the ‘rough’ conclusion pushed in the next couple days for review.
I like the “Validation” section idea.
On Wed, Apr 25, 2018 at 7:46 AM Richard Messerly <notifications<EMAIL_ADDRESS>wrote:
@ejmaginnhttps://github.com/ejmaginn
Great, I will look at this today.
sec. 5.4 needs to be beefed up
Do we just want to remove these special topics altogether? I personally do not know much about diffusion in membranes. Can we just mention the possible concerns and reference the literature?
Fig 1 needs to be replaced - they want $315 to use it
Alright. That was a pretty low quality image anyways, I was just trying to diversify our references. I will find something better or make my own image.
Can someone track down the others? It is typically just an online request.
Will do.
I didn't do anything with sections 6.3 and 6.4. They need work.
Yes, I agree. I will take a stab at this.
Need to write conclusions.
I think @dcarls0nhttps://github.com/dcarls0n was working on this. Do you have something to push yet?
I was thinking that we should include a section called "validation" where we recommend comparing your simulation results with the NIST standard reference simulation database. I think this would be important for improving reproducability and ensuring reasonable data output, which is right in line with the aims of this manuscript. Does anyone object to that?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/ejmaginn/TransportCheckList/issues/6#issuecomment-384292204, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AhJ9B6iSRbJPOBVIaGXVuGXIrfS9hTscks5tsH4cgaJpZM4TiqBG.
--
Thanks,
Daniel Carlson
(971) 300-9482
daniel.j.carlson<EMAIL_ADDRESS>

@ejmaginn
I am working on getting Figure permission. I realized that we should probably include this figure from your previous publication, along with a discussion about why to omit the noisy (but heavily weighted) short-time data. Do you need to ask permission from JCTC again even though we already got permission to use other figures in this publication? If we do need to ask permission again, could I ask you to do that?

No we should be OK on this one.
You are right - this is one of those details we want to tell people about. “tricks of the trade”.
Ed
Edward Maginn
Dorini Family Professor and Department Chair
Department of Chemical and Biomolecular Engineering
University of Notre Dame
Notre Dame, IN 46556 USA
cbe.nd.edu
<EMAIL_ADDRESS>@ejmaginn
view my papers: https://goo.gl/kgMMBe

On Apr 26, 2018, at 4:26 PM, Richard Messerly<EMAIL_ADDRESS>wrote:
@ejmaginn https://github.com/ejmaginn
I am working on getting Figure permission. I realized that we should probably include this figure from your previous publication, along with a discussion about why to omit the noisy (but heavily weighted) short-time data. Do you need to ask permission from JCTC again even though we already got permission to use other figures in this publication? If we do need to ask permission again, could I ask you to do that?
https://user-images.githubusercontent.com/23408516/39330107-cf0cb40c-495d-11e8-8812-bb0d45df96bb.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/ejmaginn/TransportCheckList/issues/6#issuecomment-384778067, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKiXa1DHDLbdxMwVMLkcih-C6so-iuUks5tsi2NgaJpZM4TiqBG.

@ejmaginn
Alright, great.
I am working on bulking up the viscosity Einstein section. As part of that I thought this simple figure would be helpful. This shows how averaging over three stress tensor terms only provides marginal improvement in the Einstein integral (I could do 6 but I think this is good enough). Whereas, using 30 replicates leads to very nice smooth curves where the slope is fairly constant and, more importantly, it is reliable at large times.

Also, Hess recommended taking the slope at short times from a single simulation. This figure helps illustrate his point. With just a single simulation you certainly should not take the slope as t goes to infinity. The initial slope is actually pretty close to the long-time slope. I am going to include a figure that compares the slopes you obtain when starting at t=0 and t=infinity.

@ejmaginn
Taylor and Francis also requested $315 for this figure that I included recently:

It probably does not help at all that I know the author of this manuscript, right? In other words, the author relinquishes ownership to the publisher. I find this strange that Taylor and Francis is so stingy with their publications. Is this typical?
As far as the manuscript goes, I guess I can just include a statement saying "see Figure X in Ref Y." This is not ideal for those that may not have access to this reference. But it will be hard to find a good replacement in the literature (that we have permission to use). The other option is to make our own figures. I did not want to go this route because then we probably need to provide some supporting information as to how we performed the simulations, the model, etc. Any suggestions?

@ejmaginn  @dcarls0n
I wanted to inform you that I have pushed my changes for the day. Just trying to avoid another merge problem.

This looks great!
Edward Maginn
Dorini Family Professor and Department Chair
Department of Chemical and Biomolecular Engineering
University of Notre Dame
Notre Dame, IN 46556 USA
cbe.nd.edu
<EMAIL_ADDRESS>@ejmaginn
view my papers: https://goo.gl/kgMMBe

On Apr 26, 2018, at 5:03 PM, Richard Messerly<EMAIL_ADDRESS>wrote:
@ejmaginn https://github.com/ejmaginn
Alright, great.
I am working on bulking up the viscosity Einstein section. As part of that I thought this simple figure would be helpful. This shows how averaging over three stress tensor terms only provides marginal improvement in the Einstein integral (I could do 6 but I think this is good enough). Whereas, using 30 replicates leads to very nice smooth curves where the slope is fairly constant and, more importantly, it is reliable at large times.
https://user-images.githubusercontent.com/23408516/39331788-bd592b0a-4962-11e8-8fe6-be6a36797f99.png
Also, Hess recommended taking the slope at short times from a single simulation. This figure helps illustrate his point. With just a single simulation you certainly should not take the slope as t goes to infinity. The initial slope is actually pretty close to the long-time slope. I am going to include a figure that compares the slopes you obtain when starting at t=0 and t=infinity.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/ejmaginn/TransportCheckList/issues/6#issuecomment-384788132, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKiXen7fTf1J5FBuFuyDuDhdchxdSfKks5tsjYIgaJpZM4TiqBG.

Ugh. Rip off. Yes, I think we can just refer to the figures in the text without showing them, and only reproduce free images. I’ll see if I can find an equivalent somewhere. We don’t want to make our own!
Edward Maginn
Dorini Family Professor and Department Chair
Department of Chemical and Biomolecular Engineering
University of Notre Dame
Notre Dame, IN 46556 USA
cbe.nd.edu
<EMAIL_ADDRESS>@ejmaginn
view my papers: https://goo.gl/kgMMBe

On Apr 26, 2018, at 5:42 PM, Richard Messerly<EMAIL_ADDRESS>wrote:
@ejmaginn https://github.com/ejmaginn
Taylor and Francis also requested $315 for this figure that I included recently:
https://user-images.githubusercontent.com/23408516/39333283-8c43bc42-4967-11e8-8439-3350e65e5c18.png
It probably does not help at all that I know the author of this manuscript, right? In other words, the author relinquishes ownership to the publisher. I find this strange that Taylor and Francis is so stingy with their publications. Is this typical?
As far as the manuscript goes, I guess I can just include a statement saying "see Figure X in Ref Y." This is not ideal for those that may not have access to this reference. But it will be hard to find a good replacement in the literature (that we have permission to use). The other option is to make our own figures. I did not want to go this route because then we probably need to provide some supporting information as to how we performed the simulations, the model, etc. Any suggestions?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/ejmaginn/TransportCheckList/issues/6#issuecomment-384798036, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKiXax1o2v_chiPuwV5ZSX3-L6E0LUzks5tsj8sgaJpZM4TiqBG.

@ejmaginn @dcarls0n
I wanted to follow up on Ed's concerns:

sec.  5.4 needs to be beefed up

Rather than beefing this up (since I don't know a ton about membrane diffusivity simulations) I simply cleaned it up so that it reads a little better. I foresee these special topics sections as placeholders for the future where experts (other than us) can contribute.

please check the links to sections in the checklist section

I think all the links are good

Fig  1 needs to be replaced - they want $315 to use it

I have removed this figure. I don't think we need to replace it, since the text does a good enough job explaining why replicates are better than a single long run.

We need permissions for some of the other figures. I got the ones from my papers. Can someone track down the others? It is typically just an online request.

I was able to get permission for most figures. I am currently just waiting to hear back from IOPscience regarding Figure 2. If we cannot use this one, we will need another log-log MSD plot.

I didn't do anything with sections 6.3 and 6.4. They need work.

I rewrote 6.3 so that it is easier to follow. I also beefed up 6.4 a bit.

Need to write conclusions.

Daniel wrote a conclusions section. I modified a few sentences but preserved the content.

@ejmaginn @dcarls0n
What is our plan moving forward? Do we want to have another video conference? Do we all want to go over the document one more time?
At the very least, I would appreciate some feedback on these Sections:
4.2.3- I tried to explain how to obtain lower and upper uncertainties. Let me know if this is still not clear enough.
4.4 - This is the new validation section. Let me know if the recommendations are clear, reasonable, and useful.
5.4 - Special topic for diffusion in membrane. Hopefully this is a little more structured now.
6.2.1 - I have subdivided the different data analysis methods. "Model fit to autocorrelation function" now discusses a "hybrid integration approach". "Model fit to running integral" includes an alternative exponential model from the literature. I included this additional information so that we are more inclusive of different approaches used in literature (that are all of comparable reliability). I would appreciate your feedback here. Also, I included a discussion about excluding low time points from fit.
6.3- Einstein section is still pretty thin, but since we do not recommend this approach it might be OK. I included Figure 9 to demonstrate why we need replicates if we want to take the slope at long time. Figure 9 is the only figure that we developed specifically for this work. Please let me know if the information in the caption is insufficient regarding how we produced these data.
6.4 - Let me know if this section is still inadequate. Like I said for section 5.4, the special topics are not intended to be complete, but they are supposed to raise possible concerns for a specific system.
7 - I have gone over @dcarls0n conclusions, but I think @ejmaginn should look at it too.
Do you think you can go over these sections and respond in the issues for what you like and do not like?
Thank you

Got it.
I think we should all read / review and then finalize this week. Have the other authors (DR, JRE) taken a look? I can do a detailed edit / review in the next couple days. I know we can all edit and merge using GitHub but maybe one of us (Richard????) could compile changes and we could all send in suggestions. Would that work?
Edward Maginn
Dorini Family Professor and Department Chair
Department of Chemical and Biomolecular Engineering
University of Notre Dame
Notre Dame, IN 46556 USA
cbe.nd.edu
<EMAIL_ADDRESS>@ejmaginn
view my papers: https://goo.gl/kgMMBe

On Apr 30, 2018, at 1:25 PM, Richard Messerly<EMAIL_ADDRESS>wrote:
@ejmaginn https://github.com/ejmaginn @dcarls0n https://github.com/dcarls0n
What is our plan moving forward? Do we want to have another video conference? Do we all want to go over the document one more time?
At the very least, I would appreciate some feedback on these Sections:
4.2.3- I tried to explain how to obtain lower and upper uncertainties. Let me know if this is still not clear enough.
4.4 - This is the new validation section. Let me know if the recommendations are clear, reasonable, and useful.
5.4 - Special topic for diffusion in membrane. Hopefully this is a little more structured now.
6.2.1 - I have subdivided the different data analysis methods. "Model fit to autocorrelation function" now discusses a "hybrid integration approach". "Model fit to running integral" includes an alternative exponential model from the literature. I included this additional information so that we are more inclusive of different approaches used in literature (that are all of comparable reliability). I would appreciate your feedback here. Also, I included a discussion about excluding low time points from fit.
6.3- Einstein section is still pretty thin, but since we do not recommend this approach it might be OK. I included Figure 9 to demonstrate why we need replicates if we want to take the slope at long time. Figure 9 is the only figure that we developed specifically for this work. Please let me know if the information in the caption is insufficient regarding how we produced these data.
6.4 - Let me know if this section is still inadequate. Like I said for section 5.4, the special topics are not intended to be complete, but they are supposed to raise possible concerns for a specific system.
7 - I have gone over @dcarls0n https://github.com/dcarls0n conclusions, but I think @ejmaginn https://github.com/ejmaginn should look at it too.
Do you think you can go over these sections and respond in the issues for what you like and do not like?
Thank you
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/ejmaginn/TransportCheckList/issues/6#issuecomment-385468618, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKiXXR71ywrkcufZjZcb12yOVS6KBEGks5tt0kEgaJpZM4TiqBG.

I know we can all edit and merge using GitHub but maybe one of us (Richard????) could compile changes and we could all send in suggestions. Would that work?

I'd like clarification on this too. I'm fine with either making edits to to main document (EMD_diffusivity_viscosity_restructured.tex) or just making suggestions via opening a GitHub issue. Let me know which is preferable.

@ejmaginn @dcarls0n @drroe @jrelliottoh
I think it might be easiest if we did this the old-fashioned way, i.e. we all make comments on our own PDF copy of the manuscript. Since we do not want these PDFs clogging up our GitHub repository, I will create an issue where we can upload our PDFs.
I know this does not utilize the full capabilities of Git version control, but this will avoid any merge issues and will be easier to compare everyone's suggestions. Does that work?

I’m OK with this!
Edward Maginn
Dorini Family Professor and Department Chair
Department of Chemical and Biomolecular Engineering
University of Notre Dame
Notre Dame, IN 46556 USA
cbe.nd.edu
<EMAIL_ADDRESS>@ejmaginn
view my papers: https://goo.gl/kgMMBe

On Apr 30, 2018, at 4:11 PM, Richard Messerly<EMAIL_ADDRESS>wrote:
@ejmaginn https://github.com/ejmaginn @dcarls0n https://github.com/dcarls0n @drroe https://github.com/drroe @jrelliottoh https://github.com/jrelliottoh
I think it might be easiest if we did this the old-fashioned way, i.e. we all make comments on our own PDF copy of the manuscript. Since we do not want these PDFs clogging up our GitHub repository, I will create an issue where we can upload our PDFs.
I know this does not utilize the full capabilities of Git version control, but this will avoid any merge issues and will be easier to compare everyone's suggestions. Does that work?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/ejmaginn/TransportCheckList/issues/6#issuecomment-385514174, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKiXf0Tzeg05bt24OnSbRR_3IuULWK5ks5tt2_kgaJpZM4TiqBG.

@ejmaginn
In Issue #8 I mentioned that I could put together a figure showing the range of viscosity values depending on the time interval selected. The figure below was obtained using the Einstein values from Figure 9 where we compare a single simulation with 30 replicate simulations. The start and end time refer to the time interval that is included when calculating the slope.
Clearly a single replicate simulation you need to use short (but not too short) times, while with more replicates you get a relatively constant slope. However, most of that information is already contained in Figure 9. I think this figure is visually appealing and informative, but I am not exactly sure how to incorporate it.
Do we want to include a circle that shows the region of feasible intervals over which you would want to report the variability? In other words, for the top panel we would label the bottom left corner as "Feasible interval" and the entire bottom panel is a feasible interval.

Richard,
Sorry for not replying earlier. I have been tied up lately.
This figure is cool but I am not sure I totally understand it. My main takeaway is that with N=30 you get a much more stable result and less dependence on where you take the slope, is that right? But that you can get the “right answer” wth N=1 if you only use the short time date? I think that really does emphasize how “risky” it is to use N=1 because you just can’t be sure where to take the slope. I would include this figure and expand the discussion of it in the text if you can.

On May 3, 2018, at 4:44 PM, Richard Messerly<EMAIL_ADDRESS>wrote:
@ejmaginn https://github.com/ejmaginn
In Issue #8 https://github.com/ejmaginn/TransportCheckList/issues/8 I mentioned that I could put together a figure showing the range of viscosity values depending on the time interval selected. The figure below was obtained using the Einstein values from Figure 9 where we compare a single simulation with 30 replicate simulations. The start and end time refer to the time interval that is included when calculating the slope.
Clearly a single replicate simulation you need to use short (but not too short) times, while with more replicates you get a relatively constant slope. However, most of that information is already contained in Figure 9. I think this figure is visually appealing and informative, but I am not exactly sure how to incorporate it.
Do we want to include a circle that shows the region of feasible intervals over which you would want to report the variability? In other words, for the top panel we would label the bottom left corner as "Feasible interval" and the entire bottom panel is a feasible interval.
https://user-images.githubusercontent.com/23408516/39601452-2d40454e-4edf-11e8-900c-63622c5314b9.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/ejmaginn/TransportCheckList/issues/6#issuecomment-386430845, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKiXcOsBFHYujfOITsub5trj-d1C-2Jks5tu2xLgaJpZM4TiqBG.


Fix crop area reset after keyboard appearance

Hi,
in my app, i use your awesome library in a way like whatsapp, showing the image to crop and a text input below.
When i change the crop area and then i tap on the edittext, the keyboard appearance make a crop area reset.
I configured the androidManifest.xml like this for this activity
<activity        ...        android:configChanges="orientation|screenSize"        android:windowSoftInputMode="adjustPan" > </activity>
and the layout xml is this one:
`

<RelativeLayout
    android:layout_width="match_parent"
    android:layout_height="0dp"
    android:layout_weight="1"
    android:gravity="center" >

    <com.theartofdev.edmodo.cropper.CropImageView
        android:id="@+id/imgPreview"
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        android:layout_centerInParent="true"
        app:cropGuidelines="on"
        app:cropInitialCropWindowPaddingRatio="0"
        app:cropScaleType="fitCenter" />

    <ImageButton
        android:id="@+id/btnRotate"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_alignParentRight="true"
        android:layout_margin="16dp"
        android:background="#424242"
        android:padding="4dp"
        android:src="@drawable/ic_action_rotate_right" />
</RelativeLayout>

<LinearLayout
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:orientation="vertical" >

...
`
Is there a way to keep the crop area? I have to change something on the activity configuration?
Thank you a lot for your efforts!

it's a bug i was too lazy to fix because it requires recalculate the crop window after size change...
will fix it soon
for now you can save the crop window before keyboard is shown and set it again after... it will work because it adjusts the calculation to original image bitmap... or wait a week or two :)

Thank you for your workaround, I'll try it!
But for sure i'll wait for the clean fix too.
Thanks again

fixed in 1.2.2


unit tests fail only in GHA but not locally

Description
https://github.com/sigstore/fulcio/runs/7397026209?check_suite_focus=true
2022-07-18T20:03:55.909Z	FATAL	app/http.go:56	parse "passthrough:///:0\x13\x00\x00\x00\x13\x00": net/url: invalid control character in URL
github.com/sigstore/fulcio/cmd/app.createHTTPServer
	/home/runner/work/fulcio/fulcio/cmd/app/http.go:56
github.com/sigstore/fulcio/cmd/app.setupHTTPServer
	/home/runner/work/fulcio/fulcio/cmd/app/http_test.go:61
github.com/sigstore/fulcio/cmd/app.TestHTTPDoesntLeakGRPCHeaders
	/home/runner/work/fulcio/fulcio/cmd/app/http_test.go:93
testing.tRunner
	/opt/hostedtoolcache/go/1.[18](https://github.com/sigstore/fulcio/runs/7397026209?check_suite_focus=true#step:7:19).4/x64/src/testing/testing.go:1439
FAIL	github.com/sigstore/fulcio/cmd/app	0.026s

Seems like a flake, but no longer occurring. Will reopen if it happens again.


Make cosmetic attributes public

Is your feature request related to a problem? Please describe.
There's no public way within the API to see if an already-existing attribute is cosmetic. ForceBalance needs to check if certain attributes are cosmetic. https://github.com/leeping/forcebalance/pull/151/files#diff-1075646a3fd36fc66a1baec7dfd03793R166-R167
Describe the solution you'd like
attribute.is_cosmetic() or attrib_name in parameter.cosmetic_attributes
Describe alternatives you've considered
attrib_name in parameter._cosmetic_attribs
Additional context
This is a necessary API point for ForceBalance

It would be great to have this! Currently we have to access private members of parameters to check if an attribute is cosmetic or not which is not great and breaks easily!


How to split up large controllers/views?

Hi, We have a fairly large application and had split up our controllers/views to change context and reuse them. So in our main template we would do the following to include a sub-view (like when having tabs which can have different types of controllers/views:
<ng-include
	src="'/js/subtopic/template/SubTopicTemplateInfo.html'"
    data-ng-controller="SubTopicTemplateInfoController"
	data-ng-model="subTopicTemplate.generalInfo">
</ng-include>

Then in the controller for that piece, we would get the actual data (context) that's need to be used by that controller like this (REMARK: I already have tranformed the controller to this styleguide):
SubTopicTemplateInfoController($scope, $attrs) {
	// $scope only used for $eval attributes!
	var vm = this;
	vm.info = $scope.$eval($attrs.ngModel); // How to do this now without $scope ???
},

This way, we can use the controller/view in other places of our app, and have it all more clear what context the controller is working on. I just can't see how we could get the data (context) in our controller without using $scope. I also don't find a similar situation in the demo application or in the styleguide. Can you please comment how this can be done? Or maybe another way of doing this?

I know this can be avoided if the back-end is also correctly modularized, as then you can give up an id which the controller can use to ask a service for the model. But this isn't always the case...

Not sure I follow. The ng-include has html/view. Why not put the controller inside the view that uses it?
It looks like you want to have the view use the content from the outer controller. That can work. But have you looked into isolating the views using ui-router and its states? That may wrk better.
BTW - probably a better place to ask this is StackerOverflow.

If I understand correctly, you're trying to communicate data from one controller to another; in this case you want to pass generalInfo to the inner "sub-controller",  SubTopicTemplateInfoController. I will proceed with that intent in mind.
The easiest solution is to not have the sub-controller at all. When you ngInclude the template with no controller specification, the template is bound to the outer controller and you're in good shape. But we'll assume you have good reasons for a separate controller.
You could specify that controller inside the template as John suggested. That is just fine even if the sub-controller is re-usable in other templates! Of course it doesn't work if the template can be bound to multiple controllers ... a circumstance I strive to avoid ... almost always successfully.
However, that doesn't solve the problem of conveying information from the outer controller to the sub-controller.
It is safe to say that the "controllerAs" syntax impedes your ability to access external context ... specifically context up the $scope inheritance chain. This is not a failing; it is by design!  One of the principle complaints about $scope is that it is a pseudo-global with unfettered access (and potential manipulation) across controller boundaries. That's one reason (not the only reason) that $scope is going away in version 2.  It's a reason we should be reluctant ... as a matter of style ... to appear to promote this form of cross-controller sharing.
I personally favor the use of a "controller state" service for this kind of thing. That's the generally accepted solution for preserving state across controller lifetimes. It works just as well here.
But if you don't like that and you're comfortable with "dirty", well ... there is always $scope. You've taken a rather round about way of doing it with $eval and all. Why pretend? You might as well just inject $scope and walk up the chain to get what you want (e.g., $scope.$parent.vm.generalInfo). Isn't that awful? It sure is. But I'd argue it's dirtier than calling $eval over text-based attributes. It's up to you.
IMO, neither of the dirty approaches belong in a style guide. If the guide tackles this problem at all, perhaps it should discuss the "controller-state" service gambit.
Cheers!


please add tf.size support

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
TensorFlow installed from (source or binary): pip
TensorFlow version (or github SHA if from source): 2.4.1

Provide the text output from tflite_convert
tf.size' of is neither a custom op nor a flex op

Standalone code to reproduce the issue
https://www.tensorflow.org/lite/tutorials/pose_classification
Also, please include a link to a GraphDef or the model if possible.
=====In Addition======
I know that the convert works if add following line,
converter.target_spec.supported_ops = [
        tf.lite.OpsSet.TFLITE_BUILTINS,  # enable TensorFlow Lite ops.
        tf.lite.OpsSet.SELECT_TF_OPS  # enable TensorFlow ops.  --> because tf.Size is not supported by tflite
    ]

but, this tflite model does not work on Android even if I add "tensorflow-lite-select-tf-ops.aar" inside my project.
So, could you please add tf.size support, please?
Or is there another way to replace tf.size when training this pose_classification model?
there're two place using the 'tf.size' inside the tutorial:
pose_center = tf.broadcast_to(pose_center,
                                [tf.size(landmarks) // (17*2), 17, 2])

Since Tensorflow Life supports limited number of builtin operators, however you can still enable tf.size with the select TF option.
Refer this documentation for more details. Thanks!

@zuozhen Regarding the part about not working in your app after converting with TF_SELECT.
Can you please follow the instructions here and let us know how it works

@zuozhen Regarding the part about not working in your app after converting with TF_SELECT. Can you please follow the instructions here and let us know how it works

@karimnosseir Thanks for your reply. I did follow that instruction step by step, but it crush at the native part.  In consideration of it works now by an alternative method, I'd close this issue.


PDF to DOCX conversion is not working for certain pdf files

Hi,
We are trying to convert a PDF stream to document stream using the adobe tools API.
Below is the sample code:
public MemoryStream ConvertPDFStreamToDocStream(Stream pdfMemoryStream)
{
              ExportPDFOperation exportPdfOperation = ExportPDFOperation.CreateNew(ExportPDFTargetFormat.DOCX);

                // Set operation input from a local PDF file
                FileRef sourceFileRef = FileRef.CreateFromStream(pdfMemoryStream, "application/pdf");
                exportPdfOperation.SetInput(sourceFileRef);

                // Execute the operation.
                FileRef result = exportPdfOperation.Execute(executionContext);

                MemoryStream outputStream = new MemoryStream();
                result.SaveAs(outputStream);

                return outputStream;

}

For certain PDF documents, it throws below error:

Could you kindly help here in debugging the issue?

@PriyankaRanganath : Would it be possible for you to share the document with us for further debugging?

Closing this issue since it has been idle from long. Please feel free to re-open it in case of further queries.


Xnero: Watch sandbox.jazzcash.com.pk

Xnero requests the watch of the watch_keyword sandbox\.jazzcash\.com\.pk. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

sandbox\.jazzcash\.com\.pk has been seen in 1 true positive, 1 false positive, and 0 NAAs.

Rejected by Suraj Rao in Charcoal HQ. Reason: 'affiliation unclear on fp'


File names for Un-keyed Sensors

Using the same config file as #3 the CSV files that get generated have long integer file names. Since the sensor name is in the config file and there is no ambiguity as to which stream is which, they ought to be named after the sensor.

Fixed in Revision 0.1.2.


PuppetPadchat: The contact.star() doesn't work

Provide Your Network Information

Where is the location of your server? (i.e. City, or In/Out China) U.S.
Which cloud platform(AliYun/Qcloud/DigitalOcean/etc) are you using? None

Run in docker
Wechaty v0.17.46 with Node.js v10.5.0
.on('message', async msg => {
  const contact = msg.from()
  const content: string = msg.text()
  const room: Room | null = msg.room()
  if (msg.self() || !contact)
  {
    return // skip self
  }
  const contact_star = await contact.star()
  console.log("contact star:", contact_star) //output null
})

Expected behavior
Boolean
Actual behavior
Null

Thanks!
And this feature hasn't been implemented by wechaty-padchat yet...

@lijiarui Please move this conversation to the puppet-padchat repo, thanks.

Ok


nginx websocket connection to daphne fails

Hi.
I'm trying to setup an environment where nginx serves as reverse proxy both for HTTP and Websocket connections.
Websocket connections work fine when making calls directly to daphne, which is listening on port 8000 but fail when going through nginx, which is listening on port 80 (and forwarding to daphne on port 8000).
Everything works fine in this environment except the nginx to daphne websocket connection. I'm using the following nginx configuration:
map $http_upgrade $connection_upgrade {
    default upgrade;
    '' close;
}

upstream daphne {
    server <IP_ADDRESS>:8000;
}

server {

    listen 80;
    charset utf-8;
    access_log  /var/log/nginx/default.access.log;
    error_log  /var/log/nginx/default.error.log;

    location /static/ {
        autoindex on;
        root /www;
    }

    location /media/ {
        autoindex on;
        #internal;
        root /www;
    }

    # websocket server path
    location /ws/ {
        proxy_pass          http://daphne;
        proxy_http_version  1.1;
        proxy_set_header    Upgrade             $http_upgrade;
        proxy_set_header    Connection          "Upgrade";
    }

    # webserver path
    location / {
        proxy_set_header    Host                $http_host;
        proxy_set_header    X-Real-IP           $remote_addr;
        proxy_set_header    X-Forwarded-For     $proxy_add_x_forwarded_for;
        proxy_set_header    X-NginX-Proxy       true;
        proxy_pass          http://daphne;
        proxy_redirect off;
    }

}

And to test the connection, I'm inserting the following code in Chrome's Dev Console:
socket = new WebSocket("ws://<IP_ADDRESS>");
(e) {
      alert(e.data);
     }
socket.send(1);

This code returns:
WebSocket connection to 'ws://<IP_ADDRESS>/' failed: Error during WebSocket handshake: Unexpected response code: 200
Using ngrep 'Host: <IP_ADDRESS>' port 80 in the nginx server yields something like:
interface: eth0 (<IP_ADDRESS>/<IP_ADDRESS>)
filter: (ip or ip6) and ( port 80 )
match: Host: <IP_ADDRESS>
####
T <IP_ADDRESS>:53021 -> <IP_ADDRESS>:80 [AP]
  GET / HTTP/1.1..Host: <IP_ADDRESS>..Connection: Upgrade..Pragma: no-cache..Cache-Control: no-cache..Upgrade: websocket..Origin: http://<IP_ADDRESS>..Sec-WebSocket-Version: 13..DNT: 1..User
  -Agent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.102 Safari/537.36..Accept-Encoding: gzip, deflate, sdch..Accept-Language: en-US,en;q=0.8..C
  ookie: djdt=hide; sessionid=qbbn0qred5naamavwxjydrbxlfwwi7bf; csrftoken=0itvvLQ6dja55PAwTcedYRJ7hXowjL7V..Sec-WebSocket-Key: EYOVw+nM66JeU23DO3as+Q==..Sec-WebSocket-Extensions: permessage-defl
  ate; client_max_window_bits....
#####

...and using ngrep 'Host: <IP_ADDRESS>' port 8000 in the daphne server yields something like:
interface: eth0 (<IP_ADDRESS>/<IP_ADDRESS>)
filter: (ip or ip6) and ( port 8000 )
match: Host: <IP_ADDRESS>
####
T <IP_ADDRESS>:39906 -> <IP_ADDRESS>:8000 [AP]
  GET / HTTP/1.0..Host: <IP_ADDRESS>..X-Real-IP: <IP_ADDRESS>..X-Forwarded-For: <IP_ADDRESS>..X-NginX-Proxy: true..Connection: close..Pragma: no-cache..Cache-Control: no-cache..Origin: http://
  <IP_ADDRESS>..Sec-WebSocket-Version: 13..DNT: 1..User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.102 Safari/537.36..Accept-Encoding:
  gzip, deflate, sdch..Accept-Language: en-US,en;q=0.8..Cookie: djdt=hide; sessionid=qbbn0qred5naamavwxjydrbxlfwwi7bf; csrftoken=0itvvLQ6dja55PAwTcedYRJ7hXowjL7V..Sec-WebSocket-Key: TxR8nozreG0i
  1R/4rIbFmQ==..Sec-WebSocket-Extensions: permessage-deflate; client_max_window_bits....
############

However, if I execute the same code on Chrome but using Daphne's port:
socket = new WebSocket("ws://<IP_ADDRESS>:8000");
(e) {
      alert(e.data);
`     }
socket.send(1);

...using ngrep 'Host: <IP_ADDRESS>' port 8000 in the daphne server yields something like:
interface: eth0 (<IP_ADDRESS>/<IP_ADDRESS>)
filter: (ip or ip6) and ( port 8000 )
match: Host: <IP_ADDRESS>
##########
T <IP_ADDRESS>:53005 -> <IP_ADDRESS>:8000 [AP]
  GET / HTTP/1.1..Host: <IP_ADDRESS>:8000..Connection: Upgrade..Pragma: no-cache..Cache-Control: no-cache..Upgrade: websocket..Origin: http://<IP_ADDRESS>..Sec-WebSocket-Version: 13..DNT: 1.
  .User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.102 Safari/537.36..Accept-Encoding: gzip, deflate, sdch..Accept-Language: en-US,en;q=0
  .8..Cookie: djdt=hide; sessionid=qbbn0qred5naamavwxjydrbxlfwwi7bf; csrftoken=0itvvLQ6dja55PAwTcedYRJ7hXowjL7V..Sec-WebSocket-Key: zddCqNWKRpTuqoGDDuOkBw==..Sec-WebSocket-Extensions: permessage
  -deflate; client_max_window_bits....
###

In this case, all works well and the expected alert is returned in Chrome.
I'm using docker and docker-compose looks like:
version: '2'

services:

  web:
    restart: always
    build: ./web
    ports:
      - "8000:8000"
    links:
      - postgres:postgres
      - redis:redis
      - memcached:memcached
    volumes:
      - ./web:/usr/src/app
      - ./web/static:/www/static
      - ./web/media:/www/media
    env_file: .env_dev
    command: daphne server.asgi:channel_layer --port 8000 --bind <IP_ADDRESS>
    #command: /usr/local/bin/python manage.py runworker

  nginx:
    restart: always
    build: ./nginx/
    ports:
      - "80:80"
    volumes:
      - ./nginx/log:/var/log/nginx/
    volumes_from:
      - web
    links:
      - web:web

  postgres:
    restart: always
    image: postgres:latest
    ports:
      - "5432:5432"
    volumes:
      - pg-data:/var/lib/postgresql/data/

  redis:
    restart: always
    image: redis:latest
    ports:
      - "6379:6379"
    volumes:
      - redis-data:/data

  memcached:
    restart: always
    image: memcached:latest
    ports:
      - "11211:11211"

volumes:
  redis-data: {}
  pg-data: {}

Am I missing something to route calls through nginx to daphne/channels?
Any help is greatly appreciated.
Regards,
Luis Freire

This is because your nginx configuration is configured to only route requests containing the path prefix /ws/ to Daphne, but your call in Chrome includes no path. Try this:
socket = new WebSocket("ws://<IP_ADDRESS>/ws/");

Call this a quick reply...
It had to be something obvious. My bad.
It worked.
Thanks a lot, Andrew.
Regards

No problem, I've often done the same thing - it took me three reads through to work out what it was!
In general, if the problem is "200 response", it means the request got routed to a HTTP-only server at some point; Daphne's failure mode is not that if it does drop the connection. Just had to find where that happened.


Double Eponines?

What happens when one of the twins dies?  Infinite loop?

Unclear, hard to reproduce. Maybe fixed now??


Inability to view own account (Old 333)

In gitlab by @A-Lawrence on Aug 31, 2015, 01:07
Remove the ability for user's with management functions to review or modify their own accounts.

In gitlab by @A-Lawrence on Aug 31, 2015, 01:10
mentioned in issue #296


Chapter 2 - BlinkLED with ATMega 328p

Hello, congratualations to this great book!
However, I had a very hard time getting BlinkLED from Chapter 2 to work... Figure 2-8 just wouldn't work with the "Atmega328p-pu Chip w/ Arduino UNO Bootloader" that I had purchased from Amazon. I knew that everything was fine with them, as they worked well in my Arduino Uno R3 board. I had the exact same setup as in Figure 2-8, and the Pocket AVR Programmer / usbTiny. However, I always got the "avrdude: initialization failed, rc=-1" error message. The programmer was working as I could see from its blinking lights upon transmission, but it couldn't talk to the Atmega.
On page 39, you are discussing possible causes for this "rc=-1" error - however, it is not mentioned that certain Atmega 328p's (such as mine) are configured such that they need an 8 Mhz or 16 Mhz quartz, as shown in https://www.arduino.cc/en/uploads/Tutorial/BreadboardAVR.png. For me, this was the only way I could overcome this issue. Added the 8 Mhz (16 Mhz) quartz and the 2 20pf capicators - problem solved. It took me 8 hours to figure that out, though :-(
It would be extremely helpful to at least mention this possibility in the book and put a pointer there, otherwise newbies will be extremely frustrated. Maybe for the next edition of the book?
Thanks for the great book otherwise,
Michael

@lambdamikel Michael. I experienced a similar issue as you and I was able to resolve it. I pulled my 328p-pu chip out of a working Arduino board and I program it with using my Evil Mad Scientist shield, but I couldn't get it to run independently on a board without a crystal. After doing some research this morning, I discovered my chip was set up to use the internal timer (crystal) vs internal. I ran the following command at the end of my regular avrdude command to set the fuses to enable the internal clock:
-U lfuse:w:0xe2:m -U hfuse:w:0xd9:m -U efuse:w:0xff:m
making my full command:
avrdude -v -p atmega328p -c avrisp -P /dev/cu.usbmodem1411 -b 19200 -U lfuse:w:0xe2:m -U hfuse:w:0xd9:m -U efuse:w:0xff:m
You can use the calculator here: http://www.engbedded.com/fusecalc
Reference: Section 9.6 Calibrated Internal RC Oscillator (page 34) of the Atmel ATmega 328 Datasheet (full version)
I hope this helps as I was in the same situation you are and was able to resolve it. Good luck & good programming!

Thanks for your reply. I know (and was able) to resolve this of course, my comment is more on improving the readbility of the book. The point is really that a book for beginners should at least discuss these options and present pointers as to how to resolve it, in the first or second chapter.

That's a great suggestion, honestly.
If I were re-doing the book (maybe a 3rd edition?) I would change the hardware platform.  Since the time the book was written, cheap "Arduino" mini clones have become the cheapest/easiest way to get started with AVRs.
There are only two changes you'd need to make.  One is hooking up the SPI wires correctly, and the other is making sure the delay and baud-rate functions know what speed your processor is running at.
Some of the clones have a 6-pin ISP header broken out on the thin side of the board opposite the serial adapter. Connect pins and plug it into the 6-pin header on your programmer.  Done.

Now, the chip is clocked at 16 MHz instead of 1 or 8.  You'll need to edit F_CPU in the Makefile accordingly to read 16000000UL.
And that's it.  The rest should work with the code in the book (untested!), and you get a convenient serial port connection to boot.  Let me know if you try this out.

Hi Elliott,
Feedback from someone who's working their way through the book, and seeing these comments after running into the same problem as others:
A few comments and to echo some of the feedback from others:

I actually prefer that you don't switch the book to a different hardware platform and stick to the bare chip approach your book uses, i've skimmed a few of the Arduino books previously and they obfuscate a lot of the details that are interesting and important. As I haven't gotten through the rest of the book, I can't really comment on the rest of the content.

The comments about the rc=-1 error are spot on, the book should include a note about the fuses, a few possible breadboard scenarios to overcome this, instructions on how to set the fuses with your programmer.

It would also be beneficial to include a prebuilt hex file that could be flashed once you overcome the external oscillator problem so you are starting in a "known good state". I've built the chapter 2 circuit about 5 times already and only got to blink the LED once. I can program the chip but my pin doesn't seem to do anything beyond that.

Thank you for the book, I am hoping to get through it to get a better understanding of underlying technologies for all things Arduino.


fix(cli): Help users know possible --target values

What does this PR try to resolve?
I was needing to do some more cross-compilation and forgot what the target triple was that I needed to run.  I realized i had to re-remember the command yet again.   Especially with #12585 in memory, I realized that --target isn't working like --package and other arguments that can report supported values.
In working on it, I realized I probably didn't want to report supported values yet out of concern for how big the list is (see also #12585), so I decided to just list the relevant commands for now.  We might be able to parse the rustup output to report those targets but I didn't receive a glowing endorsement from the rustup team about parsing the list (more of "yes, hyrums law and at least its interactive rather than CI").
Before:
error: a value is required for '--target <TRIPLE>' but none was supplied

For more information, try '--help'.

After:
error: "--target" takes a target architecture as an argument.

Run `rustup target list` to see possible targets.

(quotes were used because the other "list available" use them, we should probably work to be uniform in how we quote)
How should we test and review this PR?
First PR adds a test showing the existing output and then through the rest you can see how the output changed

@bors r+

:hourglass: Testing commit 802cb380edd093a952049e30ec70316f66792d89 with merge 77a9b2d19867127db128966449949fab863813ea...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing 77a9b2d19867127db128966449949fab863813ea to master...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing 77a9b2d19867127db128966449949fab863813ea to master...

:eyes: Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.


Get Lit Element from another source.

Not every place that renders Lovelace has ha-panel-lovelace defined. hui-view is a safer bet.
Preferably cards should be bundled or import a local Lit Element file.

Thanks, will be doing a conversion to TypeScript soon and will make this a bundled dependency.


JavaScript error: Cannot find module 'main', cannot open files via Windows file association

Description
I am unable to open any files associated with VSCode when in this state. From my observation, it seems there is a pending update in Task Manager and for whatever reason, this causes issues with VSCode's ability to open new files via File Explorer. In VSCode, if I use File > Open File..., the file opens perfectly fine. My hunch this is some situation that is caused on Microsoft managed machines and something activates a VSCode update while it is running. My machine is not a SAW. It happens at random and I haven't determined an exact cause at this point.
Other Notes
Closing VSCode in this state does not end any Code.exe instances in Task Manager. It also doesn't end the running VSCodeSetup-x64-*.exe either. Trying to run VSCode again while in this state also results in the same main JavaScript error (even after closing all Code.exe and VSCodeSetup-x64-*.exe instances(s). Only workaround listed at the bottom of the issue.
Related Issue
https://github.com/microsoft/vscode/issues/126628

Does this issue occur when all extensions are disabled?
Unknown. Restarting VSCode continues to cause the same issue. Thus, I cannot restart VSCode to see if an extension is to blame. Only workaround listed at the bottom of this issue.

Details
VS Code Version

Version: 1.66.2 (system setup)
Commit: dfd34e8260c270da74b5c2d86d61aee4b6d56977
Date: 2022-04-11T07:46:01.075Z
Electron: 17.2.0
Chromium: 98.0.4758.109
Node.js: 16.13.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19044

OS Version
Windows 10 Enterprise, 21H2, 19044.1706
Steps to Reproduce
Exact steps to reproduce are unknown. However, I've only observed this on my Microsoft office machine (Redmond) over the last year or so. It has happened at least half a dozen times. It hasn't happened on any other machine.

While VSCode is open and a VSCode setup is pending in Task Manager, attempt to open a file with a file association to VSCode.
Observe the follow message appears and the file does not open in the current VSCode instance.

Update EXE in Task Manager

Update EXE file location

GIF of issue

Known Workaround

Close VSCode
Open Task Manager
End task the currently running VSCodeSetup-x64-*.exe
End task all instances of Code.exe
Open the folder: C:\Windows\SoftwareDistribution\Download\Install
Run the VSCodeSetup-x64-*.exe located there and install VSCode
Launch VSCode

I also see this same issue on my Windows 10 Microsoft-owned desktop machine.

This is still happening for me. Just happened again today.

Current version info:
Version: 1.71.0 (system setup)
Commit: 784b0177c56c607789f9638da7b6bf3230d47a8c
Date: 2022-09-01T07:36:10.600Z
Electron: 19.0.12
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19044
Sandboxed: No

I've noticed within the last month or so, I come back to my work PC and now I have multiple of these dialogs appearing:

Setup has detected that Visual Studio Code is currently running. Please close all instances of it now, then click OK to continue, or Cancel to exit.

This prompt seems to have solved this particular issue since it is no longer trying to brute-force install VSCode while it is already running. For now, I'm going to close this issue since this prompt effectively blocks this issue from occurring.
CC @joaomoreno


Register Signer should allow more sharing options

The register signer screen when clicking on Vault details when signing with an external key only shows QR code, it should have the NFC, File, and Remote link options as well

Verified this issue on dev app v 1.2.18(410)


New page Bern (districts)

Bern revamped their Corona page, new URL for district data is:
https://www.besondere-lage.sites.be.ch/de/start/news/fallzahlen.html

Thanks for reporting David!
PR for the scraper and tests scraper is #1588
PR for the district scraper update is at #1591

Thanks for reporting David!
PR for the scraper and tests scraper is #1588
PR for the district scraper update is at #1591

both merged.

both merged.


cmake: disable assembly optimizations only when necessary

Based on discussion here https://github.com/grpc/grpc/issues/16376#issuecomment-414726024,
this is the first step to enable assembly optimizations where possible.
This change by itself doesn't really influence much as cmake is not used to build any artifacts on linux or macos, but it gives the opportunity to build with cmake with embedded boringssl while using the assembly optimizations (we can later make use of it when building e.g. C# artifacts).

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,952,962      Total (=)      1,952,962

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,664,803      Total (>)     10,664,796

 No significant differences in binary sizes

[microbenchmarks] No significant performance differences


infra: Remove black badge (doesn't do anything)

Also seeing if Codecov status check works
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General

[ ] I have read the CONTRIBUTING doc
[ ] I used the commit message format described in CONTRIBUTING
[ ] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov checks work; made the check required, closing PR

Codecov checks work; made the check required, closing PR


How to include the Top / Bottom Label inside chat bubble.

Currently if we see the cells then Chat bubble only appears on the message content either it is text or media item.My question is what is the recommended way if i want to include the Top/Bottom label inside the chat bubble. for both text and media items.

hey @TheEngineerz - the library doesn't support this out-of-the-box. this would require that you make custom cells. search for this in previous issues for details.

Thanks @jessesquires


Sharing ideas sketch.

Good ideas, Tim! I think you can restructure pretty much what's already in here a bit more like this for clarity

more detailed description of V1, including examples and lifecycle description (train, ingest, search in different context, dedup, etc)
summary of V2 enhancements and discussion of difference in capabilities (this may actually be more than one feature bucket)
misc features under question like eviction, Xor operators, etc

superseded by #96, I presume


IMAP Syncronisation

I last looked at ONLYOFFICE when it was called the Community Edition and though the functionality was great, but it was ultimately let down by the lack of IMAP synchronisation for the Mail module.
A year or more later and it's looking even more polished, but ultimately it's still an unusable solution without full IMAP synchronisation.  Most people want/need to deal with e-mail across multiple devices, and having to manage mail more than once doesn't fly.
Is it really that difficult to add this?  I'm hoping not as I'd really like to use it more and even look to promote it to some of my smaller clients as an alternative to O365, but as it stands I can't.

Hello @crazybadger,
thank you for report, we have plans to realize it, but not in the near future.

Thanks for the update.  This really should be at the top of your priority list, as without it the Mail module is unusable for most people.

have you considered using https://github.com/jstedfast/MailKit ?

Hi @melmawi ,
we are already using MailKit, what is the reason for your interest?


Options above and below selected are not visible

Hi
Thanks so much for this great plugin. I'm currently experiencing the following issue:
I have a date box on my page. It takes the correct options from the selects, and shows them. However, only the 'selected' values are visible.
Please see attached images.

I am having same problem. Rotations are wrong since for some reason not all elements of select day are not shown. For example i got only  16 figures shown instead of 31!

I have fixed this by adding:
.drum{
height: 25.3px !important;
}

@goors - thanks for the tip. I had the same issue here.


Results of running example code is different from example. The Version is 1.12.0

Should t the row appear?

It might be because of the way commands are sent to the terminal to clear the previous output. I'm not so sure tho. Anyway, this version isn't maintained anymore.
Try this fork:
https://github.com/vorpaljs-reforged/vorpal


V9 fox farming contract states 0.00% APY

Overview
The new fox farming contract still states 0 rewards even though it went out on the 11th. Not sure if there should be rewards accruing yet.
References and additional details

Acceptance Criteria
APY should be accurate representation of rewards being received,
Need By Date
No response
Screenshots/Mockups
No response
Ownership

[X] If my bounty needs engineering or needs product I have added the respective labels on the right
[X] As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort
No response
Sponsor / Stakeholder
No response
Bounty Hunters

Join our discord
Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
Please refer to this link for some basic info
Please do not start work on this issue until you are approved in Gitcoin.

@MBMaria is this still happening for you?

Nope :) looks like rewards are accruing now!

Closing as rewards have started and APY is now reflected in the app


Default Sheet Name 'Sheet1' Suggest

It is displayed in different languages of each country. I often forget this. I often think, "Why isn't it working?"
ENG: Sheet1
Korean: 시트1
It would be great if you could support in various languages.
&name=movie_manual&mode=manual
I can use this, but I don't use it when it's a single sheet.

Hey @amblerkr,
I added a new commit (https://github.com/tgel0/crssnt/commit/a7b584e6300140de69d178b779d7d10fb40ef67d) which introduces a new way of identifying the default sheet. Instead of looking for the name 'Sheet1' it now looks for the sheet with id = 0.
This way it doesn't matter what the name of the sheet is (you could even rename it and it would still work).
You can still use a totally different sheet name with the option &name=movie_manual.
Would be great if you could check it out/give feedback 😊

Hey @amblerkr,
I added a new commit (a7b584e) which introduces a new way of identifying the default sheet. Instead of looking for the name 'Sheet1' it now looks for the sheet with id = 0.
This way it doesn't matter what the name of the sheet is (you could even rename it and it would still work).
You can still use a totally different sheet name with the option &name=movie_manual.
Would be great if you could check it out/give feedback 😊

Perfect. Now it works without having to edit '시트1' to 'Sheet 1' or manual feature.

Perfect. Now it works without having to edit '시트1' to 'Sheet 1' or manual feature.


Payload file name mismatch?

Lines 11 & 12 in install.sh read as:
mv payloads/lfi.txt ~/tools/payloads/
mv payloads/ssti.txt ~/tools/payloads/

However lines 199 & 200 in garud read:
cat ~/tools/payloads/sstipayloads.txt | while read -r line; do cat domains/patterns/ssti.txt | qsreplace "$line" 2> /dev/null | anew -q temporary/ssti.txt;done
cat ~/tools/payloads/lfipayloads.txt | while read -r line; do cat domains/patterns/lfi.txt | qsreplace "$line" 2> /dev/null | anew -q temporary/lfi.txt;done

This produces a file not found error.
Not sure if it's a file name mismatch or whether lfipayloads.txt & sstipayloads.txt are distinct from lfi.txt & ssti.txt

Hii @frost19k,
Thanks for raising the issue. I have fixed it in the latest commit do update your garud code.
Regards,
R0X4R

No worries. While we're at it... line 215 in garud will fail with a ']' expected error. There's a space missing after "nuclei/critical.txt".
I'm working on a Docker container for your script, been running each line to make sure everything works. :-)

ok fixed it :)


Add link to data document

Add a link to the data description doc to TaxBrain. Full text is:

TaxBrain now offers users two data options: CPS and PUF. Both datasets contain tax unit level data, but they do not have all of the same variables. As a result, you will not be able to change some policy parameters, depending on which dataset you choose. A more detailed breakdown of the differences between the file can be found here.

cc @hdoupe @MattHJensen

LGTM. Here's the what the top of the TaxBrain inputs page looks like now:


How to preserve /goss/docker_output.log on failure?

Hi,
I use dgoss in my CI pipeline to test my docker images.
I have a http test defined and if it fails I would like to know what exactly went wrong.
The way I understand the dgoss script it cleans up after a failure and thus deletes /goss/docker_output.log
What would be the best way to get the output of my docker container on failure and print it to my build log?
Thank you!

merged/relesed fix in #519


[Feature Request] Add ability to modify configuration dynamically via messages

In particular the segment data, but probably others also.

The core nodes now have a method of doing this semi-automatically via msg.ui-control. but this is not yet available to third party nodes.  I would prefer wait for this to be made available, but in the short term may implement it manually for the segment data.

Done. Will be released in v1.1.0, probably tomorrow.


CoverFlowView doesn't render 100%

Please, there is any method to force CoverFlowView's render? It is happening an intermittent issue when my app start. The CoverFlowView doesn't render 100%, please find attached.

Yes, your image/frame should have the same size.
It's not an issue of this library. You should fix your markup
Can you share it with me? I will help (provide a sample)

set HeightRequest, use FillAndExpand. I cannot help without a sample.
But I am sure you missed anything in your markup


Drug Ontology

As a user, I want to have all medicine leaflets under an Ontology

@gcpdev : the leaflets have sections that describe components, diseases, and side-effects.
I have split it in tables as you can see at the image. Maybe, we can write down some script to fill in that tables and then run an experiment, to annotate it and check what we achieve.

I don't know if you agree, but we have almost all information to define an ontology.

@sandroacoelho yes, I do agree. We can start to build our ontology now. I'll look for compatible ontologies available in the LOD Cloud and so on.


Document optimizations

Anti Aliasing settings:

Also see:
https://docs.unity3d.com/Manual/class-QualitySettings.html
Other ones we should document:

Using Asset bundles
Minimizing shader compilation times
setting static objects
performance FPS meter (plus Unity-web round-trip time test)
mobile performance

More resources:

https://blog.kongregate.com/unity-webgl-memory-and-performance-optimization/
https://blogs.unity3d.com/2016/09/20/understanding-memory-in-unity-webgl/


Left panel can't be reopened #663

quarantest build successful. Demo link at
http://7a89d0f0.quarantest.iobio.io

quarantest build successful. Demo link at
http://c48f1048.quarantest.iobio.io


Slow rebuilds after upgrading to webpack 2.1.0-beta.23

Managed to upgrade asp.net core spa project to webpack 2.1.0-beta.23 and it is running fine. However, not sure if this issue is with webpack 2 or my project settings, hence pinging @SteveSandersonMS and @TheLarkInn to have a look at this  project, where rebuild starts quite late and actually builds slow as well:
In order to run with upgraded version, please switch to rebuilds branch.
Here is the current rebuild stats on my machine:
My project: based on webpack 2.1.0-beta.23

Compared to a fresh asp.net core spa project created from yo: based on webpack 1

Difference is quite large.
Greatly appreciate the time to have a look at this issue and point out the possible cause of this.

Is this using angular2 hmr or just css HRM capabilities? @sokra if you can weigh in.

This isn't using Patricks angular2-hmr or anything (wanted to try and get that in there eventually) @TheLarkInn
Just the basic stuff from webpack at the moment:
// Enable either Hot Module Reloading or production mode
const hotModuleReplacement = module['hot'];
if (hotModuleReplacement) {
    hotModuleReplacement.accept();
    hotModuleReplacement.dispose(() => { platform.destroy(); });
}

@TheLarkInn as Mark mentioned it isn't using angular2 hmr, just the webpack's build in HMR capability.
@MarkPieszak tried with above settings, but getting "platform is not defined".
Strange thing with this project's HMR is that it detects the change very late, I mean:
Initial, when we get: [HMR] connected
With a code change, [HMR] bundle rebuilding message appears after 2-3 seconds, and thats what's adding the delay in rebuilding, not sure if that helps in identifying the area problem.

Sorry, I don't know. If you can supply repro steps in the form of a minimal set of changes to the default Yeoman-generated project output then I'd be happy to have a look, but there are too many changes in this project to pin down a cause.

I'll close this as it's not an issue with the templates as they are (they use Webpack 1) but if you can identify a fault please reopen this with details. Hope that's OK!

hotModuleReplacement.accept(); doesn't work, it must be statically anlysable module.hot.accept.

@sokra It does work in Webpack 1. Is this a change in Webpack 2?

no, it works without argument, but hotModuleReplacement.accept("./file") will break.

@SteveSandersonMS There are quite a number of changes compared to original generator, including catering of some breaking changes since Webpack 2 beta.23
e.g:

no empty extension available in webpack 2 now so extensions: ['.js', '.ts'],
Change of loaders > rules property in webpack module configuration
Addition of SCSS loader
changing ts-loader with awesome-typescript-loader
Also, added, unsafeCache: true option as @sokra  mentioned in one old issues to try this to speed up builds, but that doesn't make any difference.
Some peer dependencies of webpack 2 upgrade as well.
Changing require('') > imports in polyfills.ts
Removed server rendering with Universal

@sokra OK, replaced with direct references to module['hot']. After TypeScript compilation, this will look like module.hot in the JS code, so I guess whether or not this works depends on when Webpack's static analysis runs (before or after ts-loader).

@SteveSandersonMS what I sensed from your comments is that there is no tight dependency of Webpack 1 the only option in dotnet core spa generator which may have caused this?

That's right. I'm not aware of anything locking you to Webpack 1 (but of course if you choose to upgrade, you will need to figure out solutions for any breaking changes introduced in Webpack 2).
We'll make the switch to Webpack-2-by-default once the final version of Webpack 2 is released.

@SteveSandersonMS Thanks for confirming that. Sure, in that case I think something wrong with the webpack 2 configuration somewhere which is starting the rebuild late.
Unfortunately nothing visible for me right now, which can give clue to what webpack 2 is doing after I have made the change, Random guess though, it could be DLL usage not working the way expected. Because what I have also experimented is that with or without DLL, rebuild takes same amount of time.

@sokra @TheLarkInn I think its around DLL configuration I have used with or without DLL, rebuild takes exactly same amount of time. Can you please have a look at DLL reference usage in vendor and main files

Hi guys, in desperation, I have raised same issue on stackoverflow as well, to target wider help.
Thanks

Did beta.24 help at all? @asadsahi

@MarkPieszak Didn't see beta.24 coming :)
Upgraded to beta 24, but its exactly same time with rebuilds.

Even webpack 2 beta.25 didn't make any difference. :(

@sokra @TheLarkInn any update on this issue? Is there a known issue with DLL plugin in webpack 2? Is there a working example we can follow for DLL in webpack 2 if it is good to use today?

Bingo!!!!!!!!!! The only reason for slow rebuilds was I changed ts-loader with awesome-typescript-loader. My goodness, tried every possible option I could to find out why rebuilds was slow. :(
Apologies, as I blamed webpack 2, .net core spa project not supporting webpack 2 perhaps etc, but both projects don't have any reason for slow rebuilds.
Now, question arose the claim made on awesome-typescript-loader repository here . Is this not valid any more or I have missed a particular option to set specifically to awesome-typescript-loader. Here are stats:
With ts-loader:

With awesome-typescript-loader:

@s-panferov any thoughts.
In case someone wants to experiment, this is my sample project.

Maybe you'll have a better chance asking in their project. Would you mind
linking to here if you do so I can keep an eye on it?
On Mon, Nov 14, 2016 at 1:59 PM Asad Sahi<EMAIL_ADDRESS>wrote:

Bingo!!!!!!!!!! The only reason for slow rebuilds was I changed ts-loader
with awesome-typescript-loader. My goodness, tried every possible option I
could to find out why rebuilds was slow. :(
Apologies, as I blamed webpack 2, .net core spa project not supporting
webpack 2 perhaps etc, but both projects don't have any reason for slow
rebuilds.
Now, question arose the claim made on awesome-typescript-loader repository here
https://github.com/s-panferov/awesome-typescript-loader. Is this not
valid any more or I have missed a particular option to set specifically to
awesome-typescript-loader. Here are stats:
With ts-loader:
[image: image]
https://cloud.githubusercontent.com/assets/3470892/20273985/1c5f2b18-aa8b-11e6-82ec-d6d1f30f498e.png
With awesome-typescript-loader:
[image: image]
https://cloud.githubusercontent.com/assets/3470892/20274107/6892a87a-aa8b-11e6-8cde-418b0baac4a8.png
@s-panferov https://github.com/s-panferov any thoughts.
In case someone wants to experiment, this
https://github.com/asadsahi/AspNetCoreSpa is my sample project.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/aspnet/JavaScriptServices/issues/325#issuecomment-260393837,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABeg9KWs5EIdkvn3y-F8MK1elSjdjCIWks5q-JNugaJpZM4KBlAy
.

@tinchou raised an issue as you've suggested. Not sure if typescript loaders in the context of .net core is a valid use case for them or not.

there's nothing special in the compilation of the client app, it's a regular Angular application compiled using Webpack and the related loaders.


fix: ignore personal spaces

This is to fix the automation to ignore workbooks that are created under personal spaces.

Codecov Report

Merging #9 (5054139) into main (592b820) will decrease coverage by 0.73%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   85.71%   84.97%   -0.74%
==========================================
  Files           8        8
  Lines         231      233       +2
  Branches       30       31       +1
==========================================
  Hits          198      198
- Misses         26       27       +1
- Partials        7        8       +1

Impacted Files
Coverage Δ

src/exposurescrawler/crawlers/tableau.py
89.70% <0.00%> (-2.72%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 592b820...5054139. Read the comment docs.


Add postgres as a driver in jdbc module #1155

Add postgres as a driver in jdbc module #1155
provide postgres jdbc driver with short name postgresql

Can one of the admins verify this patch?

Can one of the admins verify this patch?


Maps with non-string keys

In current implementation it's not possible to use other type than String - map is represented as StringMap or Dynamic, where field names is also strings. While msgpack spec allows keys to be any type, even different types. So most appropriate structure is array/list of key-value pairs with possible conversion to usual maps.
Actually, I ran into this because we use int as keys, so possible solution is to implement IntMap handling in encode, and to check first element type in readMap in !obj case.
I can make it, and send PR. What do you think?

Please do, I'll take a look at it.


where to find the version for nuscenes?

Hi, thanks for sharing your great work. I didn't find the mmdet version for nuscenes. Where to find it?

Hi, @sunnyHelen Sorry for being late, we have implemented the nuscenes version based on BEVDet and will realse the code in just a few days. And there might be issues and bugs, please feel free to let us know, thank you.

你好，nuscenes版本的代码公开了吗，是否可以发送给我呢 ？


[ES 2] No gamepad input when started via startx

When I start ES with "startx /usr/bin/emulationstation" the only thing I can do is close ES via pressing F4. This is not a general problem of X, since Retroarch accepts gamepad/keyboard input when launched via "startx".
When ES is launched via Window Manager(fluxbox) input works, too.
Platform: Arch Linux, Arch: x64
Anyone experienced the same problem?

any updates? 3 years and not fixed?

7 years and no solution even though a raspberrypi will do exactly this but correctly.


Admin Portal User Guide

Identified few issues in Admin Portal . Will be working on it once the issues get resolved


1.5.3-Release

Releasing to production 1.5.3, the #195 fix has been tested by the user confirming that the issue is resolved.
@micdenny up to you to release to NuGet for the first time :-)

@micdenny up to you to release to NuGet for the first time :-)

should I say thanks for this?! :stuck_out_tongue:
merging and praying :pray:

wait sorry.... this PR was requested against develop but shouldn't be against master?

wait sorry.... this PR was requested against  develop  but shouldn't be against  master ?

oh...crap...right...fixing...wait

oh...crap...right...fixing...wait

:smile: probably you will need to create a new PR


Feat: support specular intensity and F0 color in dielectric material

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature.
What is the current behavior? (You can also link to an open issue here)
KHR_materials_specular is not supported and F0 & F90 can't be modified in dielectric material.
What is the new behavior (if this is a feature change)?
Supported.
Other information:

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev/0.7@5086d41). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             dev/0.7     #697   +/-   ##
==========================================
  Coverage           ?   43.96%
==========================================
  Files              ?      410
  Lines              ?    21536
  Branches           ?     2976
==========================================
  Hits               ?     9469
  Misses             ?    12067
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5086d41...4b0cd6a. Read the comment docs.


'./data/words.txt' not found.

Dear Authors,
I tried running your code and got the error "No such file or directory: './data/words.txt"
I only want to do the inference. Can you please share how to get this file?
Thanks.

I am facing the same issue. Authors kindly clarify.

Updated the README to include the preprocessing steps that need to be run before training the model.


Update java-version to 17 for Jenkins Security Scan

With https://github.com/jenkinsci/jenkins/pull/9358 in effect, it makes sense to upgrade the action to run with Java 17.
Testing done
None.
Submitter checklist

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[ ] Link to relevant issues in GitHub or Jira
[x] Link to relevant pull requests, esp. upstream and downstream changes
[ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Thanks!


  Due to content security policy in chrome apps, one cannot use XmlHttpRequest to load local JS modules or inline scripts.

thanks for this question. Cloud you please be a bit more specific about this? Possibly with a coding example and/or practical use-case? From your description it will be really hard to help you through.
Thanks!

Hi Thilo,
Please see: https://developer.chrome.com/apps/contentSecurityPolicy
Even the simplest helloworld openui5 sample won't work as a Chrome packaged app.  First, all application resources are expected to be present within a chrome packaged app. Assuming I do that and then use sap-ui-core-all-dbg.js, then I get the following error when launching a packaged app in Chrome:
Uncaught Error: failed to load 'sap/ui/thirdparty/signals.js' from resources/sap/ui/thirdparty/signals.js: 0 - InvalidAccessError: Failed to execute 'open' on 'XMLHttpRequest': Synchronous requests are disabled for this page.

It appears that sap-ui-core-all.js isn't really a all in one js. Basically, we need a true all-in-one JS with all controls and all modules, so there are no xml http requests made for loading modules/libraries.
<!DOCTYPE html>
<html>
<head>
	<meta http-equiv="X-UA-Compatible" content="IE=edge"/>
	<meta charset="UTF-8">
	<title>SAPUI5 Walkthrough</title>
	<script
		id="sap-ui-bootstrap"
		src="resources/sap-ui-core-all-dbg.js"
		data-sap-ui-theme="sap_bluecrystal"
		data-sap-ui-libs="sap.m"
		data-sap-ui-compatVersion="edge">
	</script>
	<script src="app-init.js"></script>
</head>
<body class="sapUiBody" id="content">
</body>
</html>

sap.ui.getCore().attachInit(function () {
    new sap.m.Text({
        text: "Hello World"
    }).placeAt("content");
});

Thanks! this one I got. @codeworrior could you please have a look into this?

This is a known limitation to UI5 and our goal is to get rid of all sync requests. But we are not quite there.
Some time ago I wanted to enable offline support using a ServiceWorker which also does not support sync XHRs. Therefore I created some custom grunt build to re-bundle a core.js file that (at least almost) doesn't require sync XHRs (see my comments on the gist).
However this just a proof-of-concept. It might break whenever we are changing internals of the sap-ui-core.js.

Hi,
Is there any chance to fix this issue?
Regards
Krzysiek

@matz3 I'd also like to build a UI5 app (PWA) with ServiceWorkers API. Would it be feasible soon?

IMHO openui5/sapui5 should provide at least a list of files per library which need to be preloaded by a service worker in order to support complete offline operation afterwards.

Is this issue still in queue? 2.5 years of pending. I want progressive web app feature.

It is not only for PWA, but it is also for the user's experience. When navigating a UI5 app you can feel that is is clunky.

Wow, almost 5 years no response to this issue. Sorry that no updates were posted here. In the meantime many new developments were made in this direction.

UI5 Tooling, the successor of grunt tooling, provides a self-contained build
Asynchronous loading of JS resources
Asynchronous loading of i18n files
and many more.
I'll close this issue here, if you still experience some missing pieces to achieve your scenarios, feel free to open a new issue and provide further details.


fix more broken namespaces

AdaptiveSamplingPercentageEvaluatedCallback is another public object that changed namespaces
Fix Issue #727 .
Continuation of the same issue. found one more public object that was changed.

[x] I ran Unit Tests locally.

For significant contributions please make sure you have completed the following items:

[ ] Design discussion issue #
[ ] Changes in public surface reviewed
[ ] CHANGELOG.md updated with one line description of the fix, and a link to the original issue.
[ ] The PR will trigger build, unit test, and functional tests automatically. If your PR was submitted from fork - mention one of committers to initiate the build for you.

Are CI builds published to a myget feed at all? The one at https://www.myget.org/F/applicationinsights/api/v3/index.json doesn't seem to have any for the 2.6.x versions and it'd make verifying these changes easier.

@xt0rted I intend to publish THIS to MyGet today.
We don't auto-publish anything to MyGet as of today. Even though that's a private feed, those packages have to be signed by Microsoft for release, and that process has specific requirements.


chore(release): v0.1.1

:robot: I have created a release beep boop
0.1.1 (2023-02-13)
Performance Improvements

adjust header menu dropdown position. (d8aa04c)
reorganize global styles. (44d9ec6)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/riccox/meilisearch-ui/releases/tag/v0.1.1 :sunflower:


Make modulus (%) working

Recently we implemented some nice scientific functions, but modulus is not working.

I will take a look at it

Can you give me an example of an equation with modulus that is not working?

Oh well, it looks like it's working correctly! Sorry for wasting your time ;)


Fix typo.

A very small PR; Just fixes one small typo. :-)

A very small PR; Just fixes one small typo. :-)

Thanks for your time to contribute, even a little bit.


[HOLD for payment 2023-05-25] QR code share polish issues

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

3 bugs:
## Action Performed:
Go to settings >Share code
## Expected Result:
should not show any Console error

## Action Performed:

Go to settings >Profile >Display name
type long first and last name
Go to settings >Share code
check the name in Share code

## Expected Result:
Name cuts both side
## Actual Result:
Name should not cut

## Action Performed:

Login ND
Open Settings

## Expected Result
It is centered
## Actual Result:
It's not
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number:
Reproducible in staging?: yes
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @aman-atg @gadhiyamanan twice
Slack conversation:
https://expensify.slack.com/archives/C049HHMV9SM/p1684148520784279
https://expensify.slack.com/archives/C049HHMV9SM/p1684146498776949
https://expensify.slack.com/archives/C049HHMV9SM/p1684146466609189
View all open jobs on GitHub

@chrispader

heyoo github 👋🏼

Got some feedback from Design as well, should be an easy text color tweak. Let me know if I can help! 👍  https://github.com/Expensify/App/issues/18080#issuecomment-1548179869

@mountiny @robertjchen the PR is ready for review!

@mountiny was this an external issue? It seems like yes, and we'll pay out @chrispader for the PR?

@kevinksullivan Chris is from Margelo agency so they will handle payments differently
we just need to pay @aman-atg and @gadhiyamanan for reporting the bugs I believe. I think it would be $250 each

@kevinksullivan i think offer should be $500 to report two different($250 for each) bugs

@mountiny maybe I misunderstood your input here? Both @gadhiyamanan and @aman-atg  should be paid for reporting two individual bugs?

@kevinksullivan sorry its a bit unclear, I have combined 3 reports to this issue as they were all connected and related to one feature added and the original author fixed them all in one PR.
so we got:

$250 to @aman-atg
$500 to @gadhiyamanan for 2 reports.

@gadhiyamanan can you accept the offer? I'll add $250 to it.

Paid @aman-atg

@kevinksullivan accepted, thanks!

Paid @gadhiyamanan . Now upwork is giving me the "modal of death" where I can't continue finishing up the contract 🙃 . I'll come back around to closing out the contract.

This is being handled


Add an example implementation of vkGetValue

In the "pNext and sType" chapter, so that it is clear how it uses pNext and sType to set the value for b as well as for a.
For example (not sure if this is correct):
{
    a.value = 0;
    if (a.pNext != nullptr) {
        auto b = reinterpret_cast<VkB *>(a.pNext);
        if (b->sType == VK_STRUCTURE_TYPE_B) {
              b->value = 0;
        }
    }
}

I thought about this recently too, it would be nice to add a second part explaining that/giving example. I'm happy to write up something first for a review or you can


feat: scale down app/function service plans

Pull Request Template
Describe your changes
Suggestions to scale the app service plans

Functions for dev/test could potentially move down to basic (think it supports the same features required)
Apps (all envs) + functions (in prod) could move to v3 plans, increasing current memory allowance for less cost?

Can limit to appeals function app if no agreement
probably best to actually do this env by env to reduce risk
Useful information to review or test

Type of change 🧩

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Other (please explain in the description section above)

Checklist before requesting a review

[ ] My code follows the style guidelines of this project
[ ] My code changes do not include any hardcoded secrets or passwords
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] My Tech Lead is aware of any infrastructure changes that will cost money

App Service Plans are documented here: https://pins-ds.atlassian.net/wiki/spaces/CS/pages/1572110340/App+Service+Plan
I'm all for these kinds of changes.


set up at least 10 user stories

Use http://www.planitpoker.com or https://www.planningpoker.com

user stories must be described in three sentences or less
estimate them, include assumptions
discuss them
refine the estimates
implement them
track how long each took
document them in your GitHub Wiki


How to query an embedded entity (array of objects)?

Hi,
I do not know if it's the right place to post such a question, but I've searched GitHub issues and asked for some clue on SO without success.
Environment details

OS: Mac os High Sierra
Node.js version: 8.x.x
npm version: 6.2.0
@google-cloud/datastore version: 1.4.1

Steps to reproduce

Consider an entity containing the following embedded entity

{
  "values": [
    {
      "entityValue": {
        "properties": {
          "ACTION": {
            "stringValue": "proposal_created"
          },
          "TIMESTAMP": {
            "stringValue": "2018-08-02T11:42:00.000Z"
          }
        }
      }
    },
    {
      "entityValue": {
        "properties": {
          "TIMESTAMP": {
            "stringValue": "2018-08-02T11:42:12.000Z"
          },
          "ACTION": {
            "stringValue": "proposal_delivered"
          }
        }
      }
    },
    {
      "entityValue": {
        "properties": {
          "ACTION": {
            "stringValue": "proposal_expired"
          },
          "TIMESTAMP": {
            "stringValue": "2018-08-08T21:59:59.999Z"
          }
        }
      }
    }
  ]
}

I am perfectly able to query this embedded entity by TIMELINE.ACTION or TIMELINE.TIMESTAMP (even if TIMESTAMP is stored as a string and not as a date...).

However I'm totally unable to write a query of this kind:
Query all entities where ACTION = 'proposal_expired' and for which TIMESTAMP < new Date() ?

I heard about composite index (I do not know how if it's the road to walk), but I do not have any idea how to write such a query for Datastore, or even if that's possible.

Do you have any clue?
Documentation isn't helpful on this subject.
Thanks.

Not sure if this fits well for your implementation, but in our (somewhat similar) case what we did is put those embedded values in a separate table with their own keys, then use their key names (or id's) as the value to that row.
On the top of my head here's an example:
Orders

name/id
item
amount
payoutGroup

x1
burger
100
z1

x2
fries
200
z1

x3
shake
300
z1

Payouts

name/id
dateStart
dateEnd
paid
involvedOrders

z1
january1
january31
false
[x1, x2, x3]

In which case, I could filter the Orders by payoutGroup and other row values, and at the same time filter Payouts by involvedOrders by their involved / included orders alone.

Sorry for the delay, @charnould. This question doesn't appear specific to our library or Node, so would you mind opening an issue on StackOverflow?: https://stackoverflow.com/questions/tagged/google-cloud-datastore.

If you still can't get a good answer, please let me know and I can escalate as necessary. Thanks!


Fix issue with copying to a texture from a HTMLVideoElement

Description
A HTMLVideoElement has additional videoHeight and videoWidth properties. These are the intrinsic dimensions. If we rely on the height and width values, we can get sub optimal values, and – as in the case of the reported bug – sometimes 0 values, which can break the WebGL operation entirely.
While I was in that code, I also opted to use naturalHeight and naturalWidth for HTMLImageElement, as those the intrinsic, not scaled, dimensions.
Issue number and link
Fixes https://github.com/CesiumGS/cesium/issues/12219
Testing plan

Visit the Video.html Sandcastle example
Ensure the video is running on the sphere
Open the development console and ensure no WebGL errors are reported

Author checklist

[x] I have submitted a Contributor License Agreement
[x] I have added my name to CONTRIBUTORS.md
[x] I have updated CHANGES.md with a short summary of my change
[x] I have added or updated unit tests to ensure consistent code coverage
[ ] ~I have updated the inline documentation, and included code examples where relevant~
[x] I have performed a self-review of my code

@jjspace Could you please review this fix for tomorrow's release?

Thanks @jjspace! Updated!


Simplify pattern of reconcililing based on a non-standard event

As an Operator author, I want my operator to start reconciliation based on a custom event source.
Typically, operators begin a reconciliation when either the Primary or the Secondary resources change (and create an event). This story covers less common cases:

Reconcile if resources outside of the cluster are misbehaving
Running reconciliation based on metrics

If I understand correctly, this can be done by using a separate goroutine that emits a GenericEvent, add the goroutine as a Source, and adding that Source to the Channel.
It would be nice if there was a helper for this so operator authors don't need to go that deep into Controller Runtime, but if that isn't practical, this should be a documentation issue.

This belongs in best-practices doc IMO

Closing this issue in favor of https://github.com/operator-framework/operator-sdk/issues/6117


[BUG] Direct message filtering keeps resetting to 'Protect me'

Whenever I open the settings and go to Privacy, no matter what I had it set on before, the Direct message filtering will have 'Protect me' selected. I, of course, prefer living dangerously.

This will be addressed in the rewrite


[Study programme overview] Make graduation times graphs clearer

Average graduation times are sometimes a bit unclear. Currently the Bachelor + master studyright graph's start year is student's start year in the bachelor's programme (this is stated in the infobox).

Breakdown doesn't have any problems, but if we switch to median times view, things are not so clear anymore:

The number of people in a certain year class in the Bachelor + master studyright graph should be rethought. Currently it uses the number of students who started in the master's programme on that particular year but this obviously leads to problems. If we want to keep this information, I think the only reasonable number would be the students who have started in any bachelor's programme on a particular year and then later transferred to this specific master's programme. But even this approach has it's own problems as we can only count students who have already graduated from a bachelor's programme. Those who haven't finished their bachelor's degree cannot be counted because we don't even know which master's programme they are going to choose (most bachelor's programmes have multiple options).
Also the percentages on the Master studyright graph are not very good. If there's a percentage, it should probably be calculated with the number of students who only had the master's study right. If we don't do this, the percentage can never be 100% even if everybody with just the master's study right had graduated (unless it's a master's programme to which everyone needs to apply separately).

One possible solution would be to always use the start year in the master's programme as a start year in both graphs. Of course in the Bachelor + master studyright graph we would still use the start date in bachelor's programme to calculate how long it took for the student to graduate.

Commit f911ae9d1ced5eed6b29df88c5466ad6bce05327
Release 3.1.16


What sign language label?

Am I understanding your labels correctly - only subtitles in the spoken language? And also every gloss is in line with every sign? Phonological feature of sign?

Hi! There are only subtitles in spanish, no glosses/phonological information. The dataset is for translation only. We hope newer models will be able to skip glosses which in many cases were subjectively defined.


Add osx to the test matrix

OS X has distinct quirks wrt ps output.

Closing in favor of adding this to #71, so I can demonstrate green CI


Undeclared function delete for Asset and Assets interfaces

When trying to use the .detele() function for an instance of Asset, as defined in the sdk documentation, linter raises an error stating that "Property 'delete' does not exist on type 'Asset | Assets'.".

Below code is working fine.
import contentstack from "@contentstack/management";
const client = contentstack.client({host: 'HOST', authtoken: 'AUTHTOKEN'});
client.stack({ api_key: 'API_KEY'}).asset('ASSET_UID')
.delete()
.then((response) => console.log(response.notice))


Reduce plan memory

Why are the changes needed?
fix: #860
Brief change log
BaseUnkeyedTable get TableScan without includeColumnStats
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before making a pull request

Documentation

Does this pull request introduces a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@shidayang Can you rename the PR title to match community requirements？

@zhoujinsong From 190_989_776 to 16_682_384 in my case with about 8000+ files

@zhoujinsong From 190_989_776 to 16_682_384 in my case with about 8000+ files

Cool! That really is a big improvement!


Importing from django.core.urlresolvers is deprecated in favor of django.urls

Another deprecation warning for Django 2.0
/usr/lib/python2.7/site-packages/import_export/admin.py:16: RemovedInDjango20Warning: Importing from django.core.urlresolvers is deprecated in favor of django.urls.
  from django.core.urlresolvers import reverse

Fixed and send a pr

Continuing progress in https://github.com/django-import-export/django-import-export/issues/664
Thanks for reporting!


Rust Support

I'm considering moving over the majority of the code to Rust. https://www.rust-lang.org
I will not write up a long list of reasons here about it but the first goal is to just get the API up and running first.

[x] #89
[x] #93
[x] #98

Support for doing plugins in Rust has now been fully implemented!


feat: turn thorchain lending on

Description
Turns THORChain lending on.
Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[x] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

N/A
Risk

This turns THORChain lending on, so lending should obviously be happy

Testing

Do a final sanity check of THORChain lending before this goes in

Engineering

None, already tested by ops
Operations

☝🏽

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #5827   👈

This stack of pull requests is managed by Graphite.

@gomesalexandre - just to confirm, there are no fees on lending at the moment?

@gomesalexandre - just to confirm, there are no fees on lending at the moment?

That's correct @0xean - we could bring them in in the future, but can't do that at the moment as THOR endpoints don't support affiliate bps for lending, see https://github.com/shapeshift/web/pull/5813

perfect, thanks, was just talking with Tim and he asked me to confirm.