Handle panic when writing file

If we panic when writing a file we end up with an empty (or worse) file. The empty file makes header-check fail and then you have to manually remove it to re-run any tests you’re doing. So: let’s remove it.

Coverage decreased (-66.8%) to 0.0% when pulling 7f5439090766c4aec3bf5df163f2a323c196e551 on handle-panic into 809a295455d7f67ee2503df7d6c72f9c406450c8 on master.


IUmbracoApplicationContextAccessor rename

With references to PR #212, one of the queries (from PR #204) was the naming of IUmbracoApplicationContextAccessor.  How's about renaming it to IDittoContextAccessor?

I think it makes sense as it's not a processor context.

On 18 Mar 2017, at 07:25, Lee Kelleher<EMAIL_ADDRESS>wrote:
With references to PR #212, one of the queries (from PR #204) was the naming of IUmbracoApplicationContextAccessor. How's about renaming it to IDittoContextAccessor?
You can view, comment on, or merge this pull request online at:
https://github.com/leekelleher/umbraco-ditto/pull/213
Commit Summary
Renamed the context accessor from IUmbracoApplicationContextAccessor to IDittoContextAccessor.
File Changes
R src/Our.Umbraco.Ditto/Common/DittoContextAccessor.cs (8)
M src/Our.Umbraco.Ditto/Ditto.cs (18)
M src/Our.Umbraco.Ditto/Extensions/PublishedContentExtensions.cs (28)
M src/Our.Umbraco.Ditto/Our.Umbraco.Ditto.csproj (2)
M tests/Our.Umbraco.Ditto.Tests/GlobalSetupFixture.cs (4)
R tests/Our.Umbraco.Ditto.Tests/Mocks/MockDittoContextAccessor.cs (4)
M tests/Our.Umbraco.Ditto.Tests/Our.Umbraco.Ditto.Tests.csproj (2)
Patch Links:
https://github.com/leekelleher/umbraco-ditto/pull/213.patch
https://github.com/leekelleher/umbraco-ditto/pull/213.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Activity Classifier doc improvements

I was trying to reproduce the Activity Classifier example by following along and quickly got stuck as the example appears to skip over the essential part of generating the contents of hapt_data.sframe and how to actually run the example snippet.
Apart from the missing yet crucial step from HAPT Data Set.zip to hapt_data.sframe it is also not clear to somebody new to turicreate how to invoke the example snippet.
The example falls short on a couple of questions:

How does one generate or get ahold of the file hapt_data.sframe?
Where does one have to place the hapt_data.sframe file?
Where does one have to place the example's snippet? Within ~/venv/, or outside?
How does one actually run the example? Via python ./activity_classifier.py?
Does one first have to cd into ~/venv/ before running the example file via python …?
Where does one find the produced output (mymodel.model and MyActivityClassifier.mlmodel)?

It is very nice to have such a wide range of applications and examples for most (if not all) of them for turicreate.
But an example that cannot be followed through without prior knowledge or filling in the blanks à la here be dragons at the end of the day is of little to no use for anybody new to the project/codebase. 😟

Hi @regexident , thank you for taking interest in the activity classifier!
The steps for building the hapt_data.sframe are indeed missing from the current documentation, and you can find them here: https://github.com/apple/turicreate/issues/41#issuecomment-350538212
As for file paths (csv files to be loaded, saved sframe files and saved model files) - please note that all of the methods below except any full or relative path you'll provide them:
sf = tc.SFrame.read_csv('some/path/some_file.csv')
sf.save('some/other/path/my_data.sf')
loaded_sf = tc.SFrame('some/other/path/my_data.sf')
model.save('new_desired_path/my_model.model`)

The current path your running your python from doesn't matter - as long as you provide a valid path where you want sframes\models to be saved to or loaded from.
Also, it is not required to run your python script from within a specific path (venv or any other).
The only advice is to activate the virtualenv in which you've installed turicreate by doing: source ~/venv/bin/activate.
After you do - feel free to write your own .py script or ipython notebook. Such script will usually begin with:
import turicreate as tc
data = tc.Sframe.read_csv('some_data.csv')
#...
model = tc.activity_classifier.create(data, ...)
#...

Feel free to ask for any further clarifications.

Hi @igiloh and thanks for the prompt response!
I just left for home, but will give it another go tomorrow morning. I’ll let you know if your additional info is enough to get started with the example and no prior experience with turicreate and/or venv.

@igiloh From what @regexident is suggesting, we can do a few things:

Lets sort out #41 and make sure the example is runnable in this case
We could also have a general guide for those that are new to Python for the other set of things that were pointed out here.

@srikris - Sounds right. I've noticed you've assigned @afranklin for #41 .
I'll discuss with @znation about the second bullet, we'll agree on some format and I'll proceed from there.

@regexident - great, good luck!
Note that virtualenv is not required. It's just an easier way to sort out your various python libraries. You can skip it as a first step if it give you trouble.

a general guide for those that are new to Python can be easily googled not sure it's necessary to add it in the tutorial. Alternative you can also include jupyter file.

@coolioxlr That's a valid point. I wasn't implying that we add it to all tutorials. Just one place in the user guide for people who are new to Python to go to. What are your thoughts on that?

I tend to agree with @coolioxlr . Adding a notebook with a simple example and clear explanations is probably the way to go here.

@igiloh with the missing steps from #41 and information from https://github.com/apple/turicreate/issues/59#issuecomment-350796559 it was straight forward to follow, thanks!


fix: cannot find publish module if cli inside a monorepo package

Description
Fixes Cannot find package '@lerna-lite/publish' imported from ... error for monorepo projects.
Motivation and Context
How Has This Been Tested?

Clone https://github.com/volarjs/workspace
Run $ pnpm i && npm run setup:vue
Run $ cd volar && npm run release

Types of changes

[ ] Chore (change that has absolutely no effect on users)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@johnsoncodehk thanks for the contribution, it looks like the PR is failing because the pnpm lock file is outdated. I also wonder why you got this error and you didn't have this problem before with version 1.x. Are you having this problem because you mark @lerna-lite as an optionalDependencies? All I could find is this Stack Overflow, https://stackoverflow.com/a/66228639/1212166 and I guess it is indeed because of the optional deps, just want to confirm. Thanks
Note that I upgraded to pnpm v8 today, if you are still on v7 and need help to update the lock file then let know and I can update by forking your PR, they changed the lock file structure quite a lot in v8 (see pnpm v8)

Your understanding of peerDependenciesMeta is correct, the use of peerDependency is for publish to be promoted to a location that cli can access when using monorepo + pnpm, but there seem still have other similar problems.
I'll try to provide a minimal reproduction tomorrow.

wow do you ever sleep? go to bed, there's no rush 😉

@johnsoncodehk is the PR still required since I couldn't replicate with pnpm 8 (as per my previous comment)?

Sorry for the delay, I will find time to check today.

This is a minimal reproduction: https://github.com/johnsoncodehk/lerna-lite-573

@johnsoncodehk thanks for the repro, I tried it and do see the error. What I wonder however is this, do we need this change in other package as well? I'm asking because in this case you are only interested in publish since version is a dependency anyway but what about other commands (or even version installed alone without publish), will they suffer from the same problem and should we do this modif for all package? I'm not too familiar with this optionalDependencies so your input would be helpful

Yes you should make the same changes to all related packages, if you agree I will close the PR and leave it to you.

@johnsoncodehk yeah that's fine, I will merge your PR and contribution and apply this change to all packages later. I assume you can wait few more days right? I mean this is not a blocker is it? Because I have some small CLI issues to resolve with another user and it might take couple days since we aren't on the same TZ (like you and me too ;)

Oh thanks. :)

ok thanks, I'll ping you on the next release. Thanks for the contribution :)
Could you review PR #578 that I just opened for all optional commands. I also changed the peer to 2.x since it seems valid as per NodeJS docs and I don't want to update the peer deps every time, unless you think it should be fixed to each Lerna-Lite version release?

2.x is good enough, even * fine IMO.


[Feature] Add database and /api/submit pathway

Old behavior
No storage or collection of submitted data.
New behavior
We submit data to the MySQL database on our docker network.
Additional info (related issues, images, etc.)
Does this close an issue? Is the feature so cool you have to add a picture?

@cprbucat2 Can you take a look at the schema and lmk what you think? I'm looking at the https://github.com/cprbucat2/team-feedback/pull/47/commits/94fe2cd24d3af3852be8f431ad9f572040f116c7 revision of collect.js for my design. I think it makes sense to have a bunch of varchar comments in a separate table from the submission they're associated with but I'm not sure if it's necessary to generate a UUID to refer to them instead of using auto-increment ints. Can we assume that the ID will remain accurate to the data it refers to? Also I think there might be a SQL uuid type but idk if we can have an array of them.


Devtools Docs: Add step to checkout the correct branch

Include step to checkout v3 branch before building the old devtools extension. The current docs don't specify which branch to checkout before building the old extension.
It is specified in the README at https://github.com/facebook/react-devtools but should probably be specified here too.
https://github.com/reactjs/reactjs.org/blob/master/content/blog/2019-08-15-new-react-devtools.md#how-do-i-get-the-old-version-back

What’s wrong with building from master? Master isn’t v4.

What’s wrong with building from master? Master isn’t v4.

You can't build master, the source code has been removed.

Thanks for explaining. I forgot.


Wrong resizing of components with new grid system

Ionic version:  (check one with "x")
[ ] 1.x
[x] 2.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
We have a dashboard with 3 components (Move, Water, Temp&Hum) which are the same components  with some little different content
sensor-component:
<ion-card>
    <ion-card-header style="background-color: #00bcd4;">

{{sensor.description}}

    </ion-card-header>
   <ion-card-content>
     different content
   </ion-card-content>
</ion-card>

In the dashboard we load this 3 components doing this:
<ion-grid no-padding>
    <ion-row>
        <ion-col>

Configure Sensors

        </ion-col>
    </ion-row>
    <ion-row>
        <sensor
            *ngFor="let sensor of sensors; let i = index"
            ion-col
            col-lg-4 col-md-4 col-sm-6 col-xs-12
            [sensor]="sensors[i]"
            [configure]="true">
        </sensor>
    </ion-row>
</ion-grid>

As you can see I use col-lg-4 col-md4 col-sm-6 and col-xs-12 to resize and redraw the components, but this does not work as expected
In screenshot a) you can see the components expand with a size of 4/12 which is working great
in screensho b) you can see how the components expand with a size of 6/12, and also this is working
in screenshot c) is only some pixels smaller then screenshot b) but the size of the components pass from 6/12 to 4/12 which is a bug
in screenshot d) you which should be the col-xs-12 you can see the last component expand to 12/12 but the two components before have always a size of 6/12
a)

b)

c)

d)

Expected behavior:
The grid resizing should simple work :P
I tested this on different scenarios and I have always the same problem, I don't know if you can reproduce it? Are you able doing this?
Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
    Cordova CLI: 6.5.0
    Ionic Framework Version: 2.2.0-201703161917
    Ionic CLI Version: 3.0.0-beta.4
    ios-deploy version: Not installed
    ios-sim version: Not installed
    OS: Linux 4.8
    Node Version: v6.10.1
    Xcode version: Not installed

So the attribute col-xs-12 doesn't exist. It should be col-12 to apply to all breakpoints (since it starts at min-width: 0). The way the grid works the smallest breakpoint isn't actually included in the attribute because it applies to all screen sizes unless you add attributes with the larger breakpoints to specify otherwise. Take a look at the docs for default breakpoints:
http://ionicframework.com/docs/v2/api/components/grid/Grid/#default-breakpoints
Let me know if you have any ideas of how to make this more clear. 🙂

Sorry it was my mistake!


Mark failure to copy cred to user home as warning

Changes
Prior to this commit a message could be seen in step logs
when tekton failed to copy a credential from /tekton/creds
to /tekton/home or $HOME (if disable-home-override feature
flag is "true"). That message can be confusing because it
appears to be an error when in actual fact it's a warning.
The message appears when Steps inside a Task run with
varying UIDs - one UID may copy the credentials first
and then subsequent steps will attempt to copy over them.
If a Step running as root, for examples, copies creds
into /tekton/home, other non-root Steps will not be able
to utilize those credentials.
The message can also appear if a user has explicltly
mounted credentials (via workspace or volumemount) in
/tekton/home and has also attached a service account
to the task with creds-init credentials on it.
The message serves as an indicator of a potential problem but
not 100% guarantee that any issues in a Step are related to it.
This commit updates the message to include a "warning:"
prefix to indicate that it might (though not always)
be a potential source of issues in your Step.
This commit also adds documented to docs/auth.md to help
users diagnose the impact of this message (including when
they can safely ignore it).

Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[x] Commit messages follow commit message best practices
[x] Release notes block has been filled in or deleted (only if no user facing changes)

Release Notes
A message related to copying credentials has been more clearly marked as a warning to reduce confusion when it appears in Step logs.

/kind cleanup

/test check-pr-has-kind-label

/hold
This needs some additional documentation added in auth.md to help users searching for more info on the error message.

/remove-kind cleanup
/kind documentation

/hold cancel
I've added a section to our ever-growing auth.md to try and capture the reasons this warning appears and how to diagnose it.

/lgtm

/retest


Meteor, Angular, and Ionic WhatsApp tutorial issue step 3

I was going through the tutorial yesterday, and have noticed the new updates today that included ES6 classes.
I was on step 3 of the tutorial, but am now unable to access it.  I can get to everything else, but step 3.
I get a blank screen when entering this URL into my browser:
http://www.angular-meteor.com/tutorials/whatsapp/meteor/methods
The error I see when I inspect the console is this:
Uncaught Error: Multiple files in patch. Must specify filename which is one of: client/scripts/controllers/chat.controller.js, client/templates/chat.html

I will take look at the file in github =D.

I found the error message here in this diff.js file:
https://github.com/meteor/tutorial-tools/blob/master/tutorial-diff-box/diff-box.jsx
So right now this isn't true:
if (! this.filename) {
throw new Error(Multiple files in patch. Must specify filename which is one of: ${filenames.join(", ")});
}
Still looking around.  Sorry I'm a Meteor noob.

Thank you for bringing this issue for my attention, apparently I missed it. I will be fixing it today.

Here, it should be fixed now


Improve fs__chmod() and fs__access() to honor win32 ACLs

Given the building blocks here, we should also be able to upgrade fs__stat() to give reasonable results on Windows as well, but since it's not blocking anything, that's going to have to wait for a very, VERY, rainy day.

Epic!

This is ready to be merged.  I rebased out a few whitespace errors and I have confirmed that on Windows, this now passes the "permissions blind test" given in this PR: https://github.com/JuliaLang/Pkg.jl/pull/1573/files
I'll merge this presently, then build some new LibUV binaries and run the full test suite with it on the buildbots with a PR to Julia base.

Awesome this is a great fix. @staticfloat did you consider upstreaming this to the libuv project? It seems it would be beneficial to have this not only on the julia fork but more broadly.

Yes, I think we eventually should.  There's an open question on whether we want to put the work in to fix stat() as well though, which I think upstream would want.  X-ref: https://github.com/JuliaLang/julia/pull/35625#issuecomment-620814779

Typically we disallow merging here now unless it’s been accepted upstream, so we should at least wait to release until that is done.

If we disallow merging here until something has been accepted upstream, why maintain a fork? So that we can get patches that have been accepted but not merged upstream before they're merged?

why maintain a fork?

I agree—why indeed. We’re getting close on this front, though, finally. Only really a couple more fixes to upstream to close this era out.

Would you prefer that I revert this, then bundle a patch in JuliaLang/julia and on Yggdrasil?

No, we're even stronger against manually maintaining patch files, if we can avoid it. Those preferably need to be even closer to being merged upstream, or fixing a serious regression, before we consider adopting them.


updatehub: Remove initscript stop parameter

UpdateHub initscript doesn't need to stop at reboot/shutdown, it only
needs to start correctly.
Signed-off-by: Fabio Berton<EMAIL_ADDRESS>

@fbertux please backport this to the older branches.


preloadData() should be callable on the active route

Describe the problem
I have a route in which the user can view and update a resource.
When the user submits their changes the resource is modified server-side and the user wants to check the new version.
I could make the server return the updated resource on the PATCH request but that makes no sense from a back-end POV since the PATCH request won't be cached, will invalidate the GET request cache and the next GET request will hit the DB for the same information that was already returned on the PATCH request.
Ideally I would make a GET request for the updated resource, which would hit the DB a single time and populate the cache.
I tried the following and none of these work (they produce no network activity at all):
goto(location.href); //Try navigating to the current page (expecting it to re-run the page load function)

let {data}: {data: PageData} = $props();
const new_data = preloadData(location.href);
//Some error handling code
data = new_data.data;

I know about invalidate() but that re-runs all the parent layouts load functions as I use await parent_data() on the +page.ts file.
I would like to simulate navigating to the current page from another page sharing the same layout stack so only the deepest +page.ts load function is run.
Describe the proposed solution
Calling preloadData() on the current route re-runs that route load function without re-running the whole layout stack load functions as it currently does when navigating between routes sharing the same layout stack.
Alternatives considered
Copying or sharing the data fetching and transformation currently done on the +page.ts file into +page.svelte so I can update the data prop manually.
Importance
would make my life easier
Additional Information
No response

Nevermind, found the culprit: the data was being fetched in +layout.ts and transformed in +page.ts. +page.ts in corretly re-run when using preloadData() but it keeps transforming stale data since +layout.ts is not re-run.
I still struggle to find a way to only re-run the innermost +layout.ts and +page.data files without rerunning the whole layout stack.

Have you tried only invalidating the page load function by passing a custom identifier instead of the current URL?  https://kit.svelte.dev/docs/load#rerunning-load-functions-manual-invalidation

Another proble occurs when you try to
preloadData(location.href); using a custom +layout.server.ts that throw an error(403).
For example when you try to preloadData for a custom page under a path like this:
details/user/[id]/+page.svelte
details/user/[id]/+page.server.ts
Having a +layout.server.ts under
details/+layout.server.ts
And into +layout.server.ts you try to puth a code like this
export const load: ServerLoad = async ({ request, parent, isDataRequest }) => {
        throw error(403, {
            message: 'No access!!!'
        });
}

the preloadData function does not handle the exception but return always the result.type === 'loaded' and status === 200.
In addition the preloadData function return the previous loaded data into the current page.

closing this in favour of https://github.com/sveltejs/kit/issues/12399 since it has started a discussion for a potential solution. Really appreciate the additional thoughts in this issue though.


Update license and notice file for release 0.6.0

Description
This PR updates license and notice file for release 0.6.0.

Codecov Report

Merging #6219 into master will decrease coverage by 2.33%.
The diff coverage is 43.43%.

@@            Coverage Diff             @@
##           master    #6219      +/-   ##
==========================================
- Coverage   66.44%   64.10%   -2.34%
==========================================
  Files        1075     1238     +163
  Lines       54773    58750    +3977
  Branches     8168     8709     +541
==========================================
+ Hits        36396    37664    +1268
- Misses      15700    18346    +2646
- Partials     2677     2740      +63

Flag
Coverage Δ

unittests
64.10% <43.43%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...e/pinot/broker/api/resources/PinotBrokerDebug.java
0.00% <0.00%> (-79.32%)
:arrow_down:

...ot/broker/broker/AllowAllAccessControlFactory.java
71.42% <ø> (-28.58%)
:arrow_down:

.../helix/BrokerUserDefinedMessageHandlerFactory.java
33.96% <0.00%> (-32.71%)
:arrow_down:

...ker/routing/instanceselector/InstanceSelector.java
100.00% <ø> (ø)

...ava/org/apache/pinot/client/AbstractResultSet.java
66.66% <0.00%> (+9.52%)
:arrow_up:

.../main/java/org/apache/pinot/client/Connection.java
35.55% <0.00%> (-13.29%)
:arrow_down:

...inot/client/JsonAsyncHttpPinotClientTransport.java
10.90% <0.00%> (-51.10%)
:arrow_down:

...not/common/assignment/InstancePartitionsUtils.java
73.80% <ø> (+0.63%)
:arrow_up:

.../apache/pinot/common/exception/QueryException.java
90.27% <ø> (+5.55%)
:arrow_up:

...pinot/common/function/AggregationFunctionType.java
98.27% <ø> (-1.73%)
:arrow_down:

... and 1074 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa883b8...825f431. Read the comment docs.


[Python] Support Python enums in pyarrow

Describe the bug, including details regarding any error messages, version, and platform.
Hello!
Filing this as a bug, though it could be feature request or even usage question.
Code:
import pyarrow
from enum import Enum
import pandas as pd

class Unit(Enum):
    A = "A"
    B = "B"

df = pd.DataFrame({'x': [Unit.A, Unit.B]})

print(pyarrow.Table.from_pandas(df))

Expected:
smth like
pyarrow.Table
x: dictionary<values=string, indices=int8, ordered=0>
----
x: [  -- dictionary:
["A","B"]  -- indices:
[0,1]]

Got:
Traceback (most recent call last):
  File "x.py", line 12, in <module>
    print(pyarrow.Table.from_pandas(df))
  File "pyarrow/table.pxi", line 3475, in pyarrow.lib.Table.from_pandas
  File "/Users/a/venv/lib/python3.8/site-packages/pyarrow/pandas_compat.py", line 611, in dataframe_to_arrays
    arrays = [convert_column(c, f)
  File "/Users/avenv/lib/python3.8/site-packages/pyarrow/pandas_compat.py", line 611, in <listcomp>
    arrays = [convert_column(c, f)
  File "/Users/a/venv/lib/python3.8/site-packages/pyarrow/pandas_compat.py", line 598, in convert_column
    raise e
  File "/Users/a/venv/lib/python3.8/site-packages/pyarrow/pandas_compat.py", line 592, in convert_column
    result = pa.array(col, type=type_, from_pandas=True, safe=safe)
  File "pyarrow/array.pxi", line 316, in pyarrow.lib.array
  File "pyarrow/array.pxi", line 83, in pyarrow.lib._ndarray_to_array
  File "pyarrow/error.pxi", line 100, in pyarrow.lib.check_status
pyarrow.lib.ArrowInvalid: ("Could not convert <Unit.A: 'A'> with type Unit: did not recognize Python value type when inferring an Arrow data type", 'Conversion failed for column x with type object')

Extracting .name from enum values and converting to category works as expected.
Component(s)
Python

In general we don't support converting "random" python objects that don't have a direct mapping to one of the arrow types (so some exceptions from the stdlib are Decimals and datetime objects).
If you want to convert such an array or pandas column to arrow, you can do the conversion yourself in advance (i.e. in your case extracting the name from each value, and converting to a Categorical).

Would it make sense to support the specialized int/str variants of Enum?

enum.IntEnum
enum.StrEnum
enum.IntFlag?


Deep supervision

Hi.
The paper is a great read. I have a question regarding deep supervision, which is not explained in the paper, but you have that in the main figure. Did you use deep supervision for all the other models that are used for comparison? If not, how can we make sure that the performance improvement is not caused by deep supervision (which theoretically is the case)?
Thank you for the response.
Regards,
Ikboljon Sobirov

Hey Ikboljon,
Thanks for the question. Our main competitor during development was nnUNet - both nnUNet and MedNeXt uses deep supervision while allows for an equivalent comparison between these 2 nets.
Since a majority of the other baselines (4 out of the 6) didn't use deep supervision in their original publications - we decided to keep things uniform and not use deep supervision in all 6 model. However, you are right to point this out as this was raised in the MICCAI reviews as well - we hope to follow-up on this work and test deep-supervision to the 2 out of 6 baselines that used them in the original publication in later work.
Regards,
Saikat

Dear Saikat,
Thank you very much for the clarification.
Regards,
Ikboljon Sobirov


Indexable#reverse_map

We have compact_map, flat_map... why not reverse_map?
Here's a gist with Array benchmarks... the benchmarking seems favourable.
I've got a PR with tests ready #8997

I'm not sure about this. There are surely use cases for that.
We also have a lot more iteration methods than map. Why should we have reversed implementation for map only? There are a lot of methods in Indexable, Enumerable and Iterable which could have reversed implementeations.
We should discuss not only reverse_map but also reverse_reduce, reverse_index, reverse_each_*, reverse_join, reverse_cycle, reverse_group_by, reverse_flat_map and many more.
Maybe not all would be very useful, but it's hard to draw a line and certainly quite a few would seem at least as useful as reverse_map.
We already have efficient and composable iterators which can be used for that. A dedicated implementation is only significantly more performant for small sizes. The to_s specs reflect that, but I'm not sure why the i * 3 don't (supposedly a benchmarking error).

I agree, where does one draw the line with these specialised methods? I personally had a use for an efficient reverse_map so I put together a PR.
reverse_reduce would be a handy method. I wouldn’t mind putting together a PR for the other reversed methods.

I feel like these are getting too specialized. At the same time it seems to be why we support an open class model, so anyone can reopen any class. I think these should proliferate as shard, collection_helpers or so. If we see some of these get used a lot we can then always revisit upstreaming them.

Yes, I don't think these are common enough to belong in the standard library. And if you need such things it shouldn't be that frequent so adding a reverse in between is usually fine.


Not allow contract handle onblock?

Not allow contract handle onblock?
or
Single Node Testnet is not allow?

Sorry, not enough information.

How should I handle the "onblock" action?


Driver File Implementation

The driver file needs to be implemented into the sample app, as this file will hold all of the functionality of our framework. The sample app will call on this functionality as necessary.

Driver File fully implemented. Closing Issue.


Set tabBarVisible to false on android device, cause a blank screen with beta.8

Hi guys,
i've read some other issue, about something similar. But, anyway, i'm working on my android device.
I'm trying to set not visible the tabbar, but when i set tabBarVisible to false, this cause to have a blank screen.
And i'm using expo to build my app, and expo use sdk 16, and if i would change release of react navigation from beta.8 to beta.7, i cannot, because this case an error during npm install.
This is my code:
export const MainNavigator = TabNavigator({
 welcome: { screen: WelcomeScreen },
 auth: { screen: AuthScreen },
 ...
  }, {
   tabBarPosition: 'bottom'
  })
 }
}, {
 navigationOptions: {
  tabBarVisible: false
 },
 lazyLoad: true,
 tabBarPosition: 'bottom',
 tabBarOptions: {
  style: {
   width: SCREEN_WIDTH
  }
 }
});

am i missing something ?

CC: @satya164

Same here. The screen works when on android tabBarVisible: true (the default). It works on iOS with tabBarVisible: false, but on android it will causes a blank screen.

@mdeprezzo did you ever figure this one out?

@acomito I'm still trying to figure out why in beta 8 doesn't works.

I still see this on beta 9.

I also still have this problem with beta 9.

Thisis strange. For me works fine. How looks your navigator?
Il 1 mag 2017 14:14, "Gys"<EMAIL_ADDRESS>ha scritto:

I also still have this problem with beta 9.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/react-community/react-navigation/issues/1163#issuecomment-298325229,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGSe1p6cklEKrPob1Hq3esl05pR70qZ2ks5r1cyggaJpZM4NEmP_
.

@mdeprezzo Good question :-)
Below the navigation that I have now.
Problem: The 'Register' screen should have tabBarVisible = false, but then on Android only a blank screen is rendered.
The 'Register' screen is shown from screen 'EventsList' in case no user info is found:
componentWillMount() {
// redirect to registration page if no user is known
if (persistent.data.userID == 0) {
this.props.navigation.navigate('Register');
return
}
}
I found that if the tabBarVisible setting of the 'EventsList' screen is set to false as well, the 'Register' screen is rendered correctly ! But I want the tabBarVisible = true for that screen.
router.js:
`
export const EventsStack = StackNavigator({
EventsList: {
screen: pageEventsList,
navigationOptions: {
title: 'Events',
// tabBarVisible: false, // IF VISIBLE = TRUE THEN SCREEN 'REGISTER' IS SHOWN CORRECTLY
},
},
Register: {
screen: pageRegister,
navigationOptions: {
title: 'Register',
tabBarVisible: false,
},
},
});
export const Tabs = TabNavigator({
Feed: {
screen: EventsStack,
navigationOptions: {
tabBarLabel: 'Events',
tabBarIcon: ({ tintColor }) =>
},
},
Me: {
screen: pageProfile,
navigationOptions: {
tabBarLabel: 'Me',
tabBarIcon: ({ tintColor }) =>
},
},
});
export const Root = StackNavigator({
Tabs: {
screen: Tabs,
},
}, {
mode: 'modal',
headerMode: 'none',
});
`

But, are you trying to set tabbarvisible inside stacknavigator ? I mean, that option may only available for TabNavigator. Or am i missing something ?

Well it works for me on iOS. But not for Android. So is it a bug or a feature ?!

Having the problem on Android but not iOS with beta 9 too.
Here's my nav structure:
mainTab
|- tab 1
|  |- stack 1
|      |-screen 1
|      |-screen 2 (trying to hide tab bar here)
|- tab 2

I set the tabBarVisible on screen 2's navigationOptions.

This example shows the problem on beta 9 on Android.
https://gist.github.com/jsierles/24a425630a713d329c3013411e4c167f

@grabbou, will it be fixed in the coming release. This behavior is very necessary for our application. I was very confused by this case during migration from react-native-router-flux

I can't give a timeline. If you want to investigate why this happens, feel free to check and send a PR if possible.

@satya164 Fixed in https://github.com/react-native-community/react-native-tab-view/pull/233

@satya164 , hi again) When are you going to make release of navigation with new fixed version of react-native-tab-view? It's very necessary for our application because testing was stopped while we are waiting for release.

@NachtRitter you can workaround this in your app with following:
tabBarComponent: props => <View collapsable={false}><TabBarTop {...props} /></View>

Hi @satya164, I can confirm the same result from @lsps9150414.
I manually updated my react-native-tab-view with your workaround
tabBarComponent: props => <TabBarTop {...props} />
On Android, the page now renders, however tabbar is still visible.
On iOS, everything works fine!

@spencercarli , issue isn't reproduced on beta.11, so it could be closed.

@NachtRitter it is with 1.0.0-beta.11
screens only shows with:
  tabBarOptions: {
    style: {
      width: SCREEN_WIDTH // any value will work here
    }
  }

and the problem comes back with:
  navigationOptions: {
    tabBarVisible: false
  }

this issue only happens on android tho.

Hi @mstrk thanks for pointing out that the blank was caused by alignItems & justifyContent to center - it's an issue that happens not only with tabs but in some cases even with other react-native components, so be careful when having them ;)


HHH-13179 Subclass 2nd level caching now works for XML mappings

Fixes HHH-13179 and HHH-13173, regressions in 5.3 and forward.
Possibly originates from HHH-12146 - Support enabling caching at any level within a mapped hierarchy.

Thanks @larkar


Easy pip installation

Adding the package to https://pypi.org would make the code easier to introduce in workflows with pip install pdyna

The PyPI installation is now available!


Table names should be escaped in Postgres.

Expected behavior
Table names should be escaped with "name" when requested via NamingStrategy. This seems to work for MySQL but not for Postgres.
Actual behavior
Table names are left unescaped. This gives problems with table name like user.
Workaround
Explicitly escape the table name in schema,
val users = quote { querySchema[UserModel]("\"user\"") }

@getquill/maintainers

Have you tried PostgresEscape?
val ctx = new PostgresJdbcContext(PostgresEscape, "db")

Does it solve the problem?

I have new DoobieContext.Postgres(NamingStrategy(SnakeCase, PostgresEscape)) and it escapes things like column names, but not table names.

I can't reproduce this problem: https://scastie.scala-lang.org/7qMXC3SHQyyV8rtZoq9bXQ
@ochrons what version of Quill you are using? Can you please build an example in scastie?

Here https://scastie.scala-lang.org/yypFbJ7mSIOGxfRWTDZMog
Using querySchema brings this out

As you can see here, when using querySchema the names are Fixed by design, this was introduced last year via Fix NamingStrategy override of querySchema to fix an issue that stayed there for quite some time.
As far as I can tell, explicitly escaping the table name in schema is the way to go here.
/cc @deusaquilus @mdedetrich

Ah ok, makes sense. We have switched using schema+table naming, so this is not an acute issue for us anymore :)

Sorry for digging an old issue. I just want to share the workaround that (seemingly) saved me:
// quill 3.10

object TodosDao { // generated
    def query = quote {
        querySchema[Todos](
          "public.todos",
          _.todoId -> "todo_id",
          _.title -> "title",
          _.desc -> "desc",
          _.finishedAt -> "finished_at",
          _.createdAt -> "created_at",
          _.updatedAt -> "updated_at"
        )
      }
  }

object FixedPostgresNaming extends SnakeCase {
  override def table(s: String): String  = s"""\"${super.table(s)}\""""
  override def column(s: String): String = s"""\"${super.column(s)}\""""
}

// and create quill context with FixedPostgresNaming

CREATE TABLE "public"."todos" ("todo_id" serial NOT NULL, "title" Text NOT NULL, "desc" Text NOT NULL, "finished_at" timestamptz, "created_at" timestamptz NOT NULL DEFAULT now(), "updated_at" timestamptz NOT NULL DEFAULT now(), PRIMARY KEY ("todo_id") );

Compose existed like NamingStrategy(SnakeCase, PostgresEscape) did not fit our column names. Really glad that quill is flexible enough.


added npm run build instruction

I was getting errors without running starting the example but after I ran npm run build, I was able to start the example

thanks @fawadasaurus


Reexport SubmissionError and SubmissionResult

Fixed

Reexport SubmissionError and SubmissionResult types.

CC @kvark @msiglreith

@homu r+

On Apr 22, 2017, at 18:51, Eyal Kalderon<EMAIL_ADDRESS>wrote:
Fixed
Reexport SubmissionError and SubmissionResult types.
@kvark @msiglreith
You can view, comment on, or merge this pull request online at:
https://github.com/gfx-rs/gfx/pull/1236
Commit Summary
Reexport SubmissionError and SubmissionResult in gfx
File Changes
M src/render/src/lib.rs (2)
Patch Links:
https://github.com/gfx-rs/gfx/pull/1236.patch
https://github.com/gfx-rs/gfx/pull/1236.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

:pushpin: Commit 1121748 has been approved by kvark

:zap: Test exempted - status


Move config to decorator argument

First step in a stateless, configurable Radium. This is also going to be the basis for using plugins.

wtf github, I wanted this PR to go onto the plugin-dev branch. oh well, I'll just manually merge. FYI, this is not meant to be pulled onto master just yet.

Looks good :+1:

Closed in favor of #348.


Dependency not found

I installed the custom module as described but when I restart HA I get this error:
Platform error sensor.afvalwijzer - No module named 'Afvaldienst'
I see a dependency/requirement in the manifest.json:
"requirements": [
"afvaldienst==0.6.9"
]
Where do I find this?

Saw closed issues with the solution


[Dependency Graph] How to identify direct / indirect dependencies

With the current dependency graph specification, it seems to be not possible to exactly distinguish between direct and indirect dependencies.
Example:
Given the following dependency graph (taken from https://cyclonedx.org/ext/dependency-graph/):
    <dg:dependencies>
        <dg:dependency<EMAIL_ADDRESS>            <dg:dependency<EMAIL_ADDRESS>        </dg:dependency>
        <dg:dependency<EMAIL_ADDRESS>            <dg:dependency<EMAIL_ADDRESS>        </dg:dependency>
        <dg:dependency<EMAIL_ADDRESS>    </dg:dependencies>

Analyzing/interpreting the dependency graph, we can clearly identify the following:
Direct dependencies

<EMAIL_ADDRESS><EMAIL_ADDRESS>
Indirect dependencies

<EMAIL_ADDRESS>
But we can actually not conclude is if<EMAIL_ADDRESS>is a direct dependecy as well
Is this a known issue or done on purpose? And if so, why?
If not, is it possible to include this into the specification to resolve this issue?
Thanks and best regards,
Matthias

Sure it can.
Assuming the component defined in the bom metadata section has a bom-ref of acme-app, then the graph would like like:
<dependencies>
    <dependency ref="acme-app">
        <dependency<EMAIL_ADDRESS>        <dependency<EMAIL_ADDRESS>    <dependency>
    <dependency<EMAIL_ADDRESS>        <dependency<EMAIL_ADDRESS>    <dependency>
    <dependency<EMAIL_ADDRESS>        <dependency<EMAIL_ADDRESS>    </dependency>
    <dependency<EMAIL_ADDRESS></dependencies>

This would indicate that common-util is NOT a direct dependency of acme-app. If you wanted to indicate it IS a direct dependency, in addition to being a transitive dependency, then it would look like this:
<dependencies>
    <dependency ref="acme-app">
        <dependency<EMAIL_ADDRESS>        <dependency<EMAIL_ADDRESS>        <dependency<EMAIL_ADDRESS>    <dependency>
    <dependency<EMAIL_ADDRESS>        <dependency<EMAIL_ADDRESS>    <dependency>
    <dependency<EMAIL_ADDRESS>        <dependency<EMAIL_ADDRESS>    </dependency>
    <dependency<EMAIL_ADDRESS></dependencies>

Note to self, improve the use cases documentation to account for this scenario.

Examples at https://cyclonedx.org/use-cases/#dependency-graph have been updated.
If you're using CycloneDX v1.1, you'll need to use both the dependency-graph extension and the bom-descriptor extension to accomplish this. With CycloneDX v1.2, no extensions required.


Automatically clean prisma2 binary cache

Right now there is no way to clean the prisma2 binary cache. So cache folder is getting quite big in size.

So we need a way to clean the cache

Thanks a lot for reporting 🙏
This issue is fixed in the latest alpha version of prisma2.
You can try it out with npm i -g prisma2@alpha.
In case it’s not fixed for you - please let us know and we’ll reopen this issue!


Recently added accounts still appear in the 'Recently Updated' section after seven years

What happened?
No idea how widespread this issue is.
Department of Environment and Natural Resources
Wikidata history
What browsers are you seeing the problem on?
No response

For some reason the account isn't returned by our account-data.rq query:
https://w.wiki/Aig7

Looks like a Wikidata bug, according to the RDF the X account got an end-time: https://www.wikidata.org/wiki/Special:EntityData/Q3277331.rdf

Looks like the recently added feature does not take end-time into account.

Looks like the recently added feature does not take end-time into account.

I didn't even notice there was an end date -_-
related question: does the end date qualifier also remove social media pages from the website?

Yes, that should be the case.


Analyzer that flags [ClassCleanup] where the cleanup behavior is not set

Summary
Analyzer that flags [ClassCleanup] where the cleanup behavior is not set.
Background and Motivation
As of today, [ClassCleanup] will by default be run at the end of the assembly and not at the end of the class. Until we move to v4 and can break this behavior, it'd be interesting to introduce an analyzer that would flag when the behavior is not explicitely set so we can ensure the user really wanted to run at the end of the assembly.
Proposed Feature
Flag:
[TestClass]
public class C
{
    [ClassCleanup]
    public static Cleanup() {}
}

and the other overloads where the cleanup behavior is not specified.
Rule info:

Category: Usage
Severity: Info
Enabled by default: true

Alternative Designs
We could have edited the rule MSTEST0011 but this rule should not be warning by default on a minor release as we don't want to break build for something that doesn't result in a guaranteed runtime error.

@engyebrahim I am wondering if we should go one step further and not only report when it's not explicitely set but always report if that's not set to EndOfClass. I don't see much sense in using this attribute for EndOfAssembly.
@cremor I see you upvoted this rule, would you be ok with that change of scope?

Yes, that would be ok for me.
I upvoted this issue because I was surprised that there is even a configuration option, and even more by the default value.

I was surprised that there is even a configuration option, and even more by the default value.

Yeah we are doing many fun discoveries :) We can't wait for v4 for the big bang breaking changes of default and simplification of options.


[ratelimiting] X-RateLimit-Reset

The rate-limit plugin should return a third header for when the time-frame expires and the limit resets. This is especially important for people writing code to avoid going over their limits.
Here's how GitHub defines the header:

Header Name
Description

X-RateLimit-Reset
The time at which the current rate limit window resets in UTC epoch seconds.

Since we support multiple rate-limit timeframes we would need to make it the format chosen in https://github.com/Mashape/kong/pull/224

the #5335 is now merged, thus closing this.


Sema: Improve diagnostics for decls more available than their containers

Adopt new request-based utilities for looking up the enclosing declaration's availability when type checking an @available attribute. This consolidates implementations of the lookup and improves diagnostics by catching more cases where declarations are more available than their containers.
Builds on https://github.com/apple/swift/pull/62876.

@swift-ci please test

@swift-ci please test


Fix Lidar lag spike from RaycastLiDARSensor.cs

Fixed a performance bug when using lidar by changing the minimum raycast calculation per job.
As we see in the unity editor's profiling tool, there's a lag spike every time lidar run, and a single job seems to perform all the calculations.

After changing the minCommandsPerJob parameter from RaycastCommand.ScheduleBatch inside RaycastLiDARSensor.cs with a constant value of 256 (arbitrary value), we can see an improvement: there are no more lag peaks, the frame rate is now stable and tasks are better distributed between jobs.

So too much division of jobs is not good. :thinking:
I learned a lot. Thanks!!

So too much division of jobs is not good. 🤔 I learned a lot. Thanks!!

It's the opposite: before, all calculations were carried out on a single job; now, by giving job's tasks with 256 raycasts, calculations are parallel and equaly distributed between jobs.

Understood.
I misunderstood that argument to be “number of jobs” instead of “number of commands per job”. :laughing:


Bridge device configuration

Add 'waitport' to the bridge configuration options.

@oneswig Thank you for your pull request.
I will merge it now!


cmd ref: freeze/unfreeze 1.0 and improvements

Continuation of #1488

I will take on changing the messages in core

@pared do you approve the changes now?

@pared do you approve the changes now?
@jorgeorpinel, sorry for delay, I do


JIT BPF Call Stack

[x] Manage BPF call stack inside JIT

[x] Setup stack pointer
[x] Save and restore scratch registers
[x] Skip memory gaps on stack
[x] Handle return vs exit depending on stack depth
[x] Handle exceptions thrown deep inside BPF call stack

[x] Report unresolved call destinations
[x] Convert remaining VM stack tests
[x] CALL_IMM
[ ] CALL_REG

Open question:
What if one manipulates the stack pointer to point into a different but valid stack frame?
In the interpreter the stack pointer is reset at the next call or return.
However, in the JIT the program would get to the other stack frame, but the scratch registers would still be stored, leading to an inconsistency in the JITs host stack and the BPF client stack.

Maybe the BPF verifier can check for any modifications to the stack pointer

Opps, didn't mean to close


server/shadow: Fix compile error on win32.

This is introduced by previous standalone fixes.

LGTM

@realjiangms what's the reason for marking the X11_ShadowSubsystemEntry as FREERDP_API?

@bmiklautz
It is not necessary.
The problem is that the corrsponding windows entry point function need 'FREERDP_API' macro so that it could be exported and used by shadow.c
It fails to link on windows platform without this mark.
Actually the X11 function don't need it as Linux defaultly export the functions. But to be consistent, I mark 'FREERDP_API' for all of the 3 functions (Mac/X11/Win)
The 3 entry point function could be regarded as 'built-in' subsystem sample
Alternative solution is, we completely move the subsystem implementation out of libfreerdp-shadow and make them compiled together with shadow.c.
Therefore there's only shadow framework in libfreerdp-shadow. I may prefer to this approach. But this need changes in CMakeList.txt, and I want to test it on all three platforms.
I may make the effort to do it in later PR as I'm still seting up my MAC development.
Any preference?

LGTM, +1

+1

@bmiklautz any objections merging this PR or is the exported X11_ShadowSubsystemEntry a blocker for you? (compiling FreeRDP with WITH_SERVER currently doesn't work with VS without this PR merged)

@mfleisz nope I'm fine. But we should definitely handle the exported symbols at some point.

@bmiklautz agree with that.
@realjiangms maybe you can solve that issue as you proposed in a separate PR?

@mfleisz
@bmiklautz
Thanks.
For the exported symbols: I will post another PR to completely decouple the subsystem implementation and shadow framework (currently is not completed). In that PR I may move the subsystem implementations out of libfreerdp-shadow.  But therefore the user for libfreerdp-shadow can no longer call default subsystem implementation directly, I may need to notify @awakecoding for his comment


puppetwash's root should reflect script name

Wash's external plugin interface expects the plugin root to match the script's basename (w/o the extension) -- it will panic otherwise. Here, the plugin root's name is puppet while the script is puppetwash. We should consolidate this.

What does "consolidate" mean? We have a wrapper puppet that's called. Is the idea to get rid of that wrapper?

Nevermind, I didn't see that. Thanks!


Creating a 404 not found page for your website

Is your feature request related to a problem? Please describe.
if a user send req to unknown URL it should be handles in a proper manner
Describe the solution you'd like
A clear and concise description of what you want to happen.
Additional context

@Priyaaa1 please review the PR


Radar Chart Tick Formatting

Is it possible to remove or style the ticks on a Radar Chart?
I see examples of using the tickFormat() function on other charts. But when I log the values going into tickFormat() for a Radar Chart, I only see output from the value parameter which I'm able to change. But this doesn't let me change the ticks, just the values.
<RadarChart>
           tickFormat={(value, index, scale, tickTotal) => {
             console.log(value, index, scale, tickTotal);//value, undefined, undefined, undefined
             return value;
           }}
</RadarChart>

For anyone looking for the solution - you can hide this with the style prop-
 style={{               axes: {               ticks: {                 fillOpacity: 0,                 strokeOpacity: 0               },               text: { display: 'none' }             }           }}


"Nothing to map" message but mappings exist

I have created my mappings as per the documentation, but constantly getting the "Nothing to map" message.
use Sleimanx2\Plastic\Mappings\Mapping;
use Sleimanx2\Plastic\Facades\Map;
class AppModelsRecordsRecordType extends Mapping
{
//...
}

Has anyone come across this issue?

Just found the solution of this issue:
The mapping files should be in this format: app_models_records_recordtype.php


Issue #242 Less verbose logging

Reduced the verbosity of logs in VmApiProxyDelegate for #242
Also reviewed log levels in AppEngineAuthentication (and fixed some javadoc errors).

Looks good. 2 nits.

denitted

BTW, any preference of CI Travis vs CircleCi ?

@aozarov I'll defer to @joakime for a more definitive answer.     We've mostly used Jenkins and it is OK, but slightly confusing UI and I've not yet seen it integrated with github.
I have used circle a little bit and have mixed feelings about it - it can be nice and simple, but if it does not work then it can be hard to configure.   It can also have problems with large builds and reviewing the output of them can lock up your browser.
No recent experience with travis.


Add fb hand tracking sample project

Adds a sample project showcasing implementations of the OpenXR extensions: XR_FB_hand_tracking_aim, XR_FB_hand_tracking_capsules, and XR_FB_hand_tracking_mesh. Also removes the hand tracking aim demo from the repos general demo project.
This PR depends on https://github.com/GodotVR/godot_openxr_vendors/pull/168 so I'll leave this as a draft until that one is merged.

Also removes the hand tracking aim demo from the repos general demo project.

This will probably cause the XR Simulator test to fail, because the screenshots won't match anymore. Let me know if you want me to record a new VRS file for it, or if you'd like me to show you how :-)

Updated the VRS file!

Rebased and opened this PR!


[stable/gocd] Use the gocd-agent-docker-dind image of the tag same as  of GoCD app version

@GaneshSPatil please bump the chart version in Chart.yaml

/ok-to-test

/lgtm


add: anubhav1206

Description
[Include a brief description of the changes you've made]
Related Issues
[Include any related issues or pull requests that this PR addresses or is related to. Use GitHub's shorthand syntax to link to them, like #1234.]
Changes Proposed
[Describe the changes you've made in detail. Be specific and include any relevant code snippets.]
Checklist

[ ] I have read and followed the Contribution Guidelines.
[ ] All new and existing tests passed.
[ ] I have updated the documentation to reflect the changes I've made.
[ ] My code follows the code style of this project.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots
Note to reviewers

@anubhav1206 Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and Star the repo to help us grow even further!


Recording takes too much memory

I am recording video from 2 sources and audio from 1 source. Thus three mediaStreamRecorder instances are being used. I am recording with blob durations of 5 mins(timeslice  = 1000605). After recording and successfully saving the first few blobs, I notice that 3 GB of my RAM is being occupied b chrome due to this and is increasing. Is the data that has been saved not being cleared from memory. If so, then is there something that I can do to clear it?

1 this is something I'd be really interested in hearing how other people deal with this problem. I'd like to have extended recording of up to an hour but I need a way of controlling memory usage within the browser for this to be possible. I've come across a few methods for removing the video from the dom but none seem to work cleanly for me and I'm unable to get the stream to start back up and continue.


Question about deepcopy in your code

Thank you for your excellent work! So I want to ask a question about deepcopy. Why does deepcopy used in the experiments, I notice that you also modify the nn.Linear code to let the weight norm can be deepcopied.

I think at that time, I was experimenting with StochasticWeightAveraging, which requires all modules to support deepcopy. SWA ended up not making any difference to the performance, so I dropped that approach but didn't remove deepcopy code.

😃Got it.


Collection filtering on top of profile

collection filter on top of the profile
filter will be visible in the owned and created section
the collection thing is similar to the top collection in explore, one addition is the item count

shows how much items the user owns from the collection

👋


Feature request: function to replace ldd

Please see https://github.com/probonopd/linuxdeployqt/issues/24

Already have plans for it :)

referencing https://github.com/linuxdeploy/linuxdeploy/issues/8

This is WIP in the background. @azubieta is writing an implementation right now, using https://github.com/lief-project/LIEF.
I would suggest to retain an ldd based method as well, though, in case our own version doesn't work on some platform (ldd is just way better tested, I'd say, and we know it works fine). Users of the library could simply choose which version to use then. We could make ElfFile an interface, and provide different implementations for it (maybe putting an abstract class in between, containing all the common functionality).

Suggested class hierarchy:

Wow. Feels like Software Engineering rather than cobbling something together now. :+1:

There is no point on having an interface and an Abstract Base Class with almost the same public virtual methods.

In C++, there is nothing like interfaces anyway, this was just a UML-ish description of the idea (more like Java, I guess).

As those are two quite different responsibilities (read: "reason of change") therefore is a violation of the SRP. It's recommended to place it in a separated class, like ElfDependenciesResolver (tentative name).

So, your point is that a "dependency resolving" algorithm is a sort of "representation" which should not be generated by the class itself due to the SRP (as the underlying functionality might change over time)?
I guess I must've misunderstood you earlier. That might make sense. I'm not a fan of strictly following the SRP (it tends to generate lots of functors (a.k.a. objects with a single method only), and tend to put helper methods whose return value will always remain the same (here, a vector of paths) into the same class. Formally, you're right, the SRP might be violated.
The question is, does it matter to us? The output format won't ever change, I guess, it will always include all library dependencies (not excluding stuff from the excludelist etc.), and as long as we can guarantee that, we wouldn't run into issues.
If that isn't good enough for you, though, then let's add that ElfDependenciesResolver that decorates ElfFile.
Suggested class diagram:

Depending on e.g., user wishes, either implementation could be instantiated, and called through the abstract class's interface.

Clarification: in the above diagram, there is an extension relation between AbstractDependencyResolver and ElfFile. Is it intended to make AbstractDependencyResolver a kind of ElfFile?
Please re-read the last paragraph from the previous post, I missed a keyword on it, so I was meaningless. It's regarding if we should expose the concrete classes through the public API.

A decorator is one way of doing it (admittedly, the names are quite bad, should be e.g. AbstractDependencyResolvingElfFile etc.), providing a class whose methods and properties are  of the feature set ElfFile provides.
An alternative approach would be the strategy pattern, or the visitor pattern, the latter of which requires a method to be added to ElfFile accepting a visitor object that does all the work. The former allows for setting a property to the strategy that shall be used.
You implied to use a Servant, but they're generally discouraged, or maybe an Extension object, which is not as widely spread in programming, as it's not the cleanest approach.

Please check the new "interface draft" here. It's just a draft for discussion purposes, it doesn't even compile yet.
Two base classes are provided "elffile" and "elffiledependenciesresolver". To get instances of those classes the factory method pattern is used. This allow user to instantiated the "elffile" or "elffiledependenciesresolver" implementation they which without exposing the implementation details.
By the way we should use camel case or something else in the class names.

You seem to ignore that the class names are PascalCase (not camelCase), but the headers are all lowercase (sometimes with under_scores). That's a convention in the majority of C++ libraries. You always seem to do either option (both filename and class PascalCase, or all lowercase).
Please adhere to that convention developed in all other projects.

PascalCase (not camelCase)

It seems we have read different books see CamelCase

That's a convention in the majority of C++ libraries

There is no such convention, I invite you to search a bit about it. Every project uses the naming style they like the most. I just found useless to have different file name and class name.
As each header file should contain only one class declaration. Using UpperCamelCase for C++ classes headers and snake_case for c headers helps do difference them at first glance.

https://en.wikipedia.org/wiki/Camel_case
https://docs.microsoft.com/en-us/previous-versions/dotnet/netframework-1.1/x2dbyw72(v=vs.71)
http://wiki.c2.com/?CamelCase
https://www.quora.com/What-is-the-difference-between-Pascal-Case-and-Camel-Case

One could say, PascalCase is a specialization of camelCase, requiring the first character to be upper case. camelCase is used mostly for lower-case-first-letter stuff.
Example:
class MyClass { // PascalCase
    int my_var; // snake_case
    void myFunction(); // camelCase
...

There is no such convention

How would you judge that? Conventions aren't standards, if many projects use some pattern, you can call it a convention.
Examples using the convention involve boost, the C++ STL, etc., the most popular C++ libraries in the world. Also, AppImage software has always used lower case headers. No need to change that. And Qt uses lower-case for *.h headers as well, the #include <QSomething> stuff are aliases for the actual headers. You could as well say #include <qsomething.h>.

helps do difference them at first glance

As a user, I don't really care about the language, but the ABI. As all modern C headers can be used in C++ without having to wrap them with some ifdefs, they can be treated like C++ headers. I don't think that one should have to differentiate.


Update govuk-frontend to 0.0.28-alpha

Updated govuk-frontend to 0.0.28-alpha.
No additional changes to the Design System itself.

You can preview this change here:
Built with commit 856ef8eb5439e4cec2b061687128a75bcdfdaf96
https://deploy-preview-238--govuk-design-system-preview.netlify.com


KEP List

Provide the actual tweet content between the commented colons

Are you curious to track or search for enhancements within K8s? Then check out our new Kubernetes Enhancement Proposals (KEPs) list here: https://www.kubernetes.dev/resources/keps/

/validate

/validate

/validate

/validate

/lifecycle frozen


Improve Overlay samples

The current overlay samples use a shadow to show where the overlay is. This could be misleading, as the actual ms-Overlay has no shadow. Instead we could add some sample content and a button to toggle the overlay on and off, so that we can see its effect.

Fixed by PR #615. The new documentation page for Overlay has a button that opens a full screen overlay.


Stop-parsing symbol is unexpectedly interpreted as such when quoted.

Usually, quoting a token ensures that it isn't interpreted as a parameter name; e.g.:
PS> Write-Output '-InputObject'
-InputObject

However, this approach doesn't work for the stop-parsing symbol (--%).
Note: I'm  using a call to an external program to demonstrate, given that --% only makes sense in external-executable calls.
Steps to reproduce
On Windows:
# OK: an unquoted --% is recognized as the stop-parsing symbol and therefore removed.
cmd /c echo --% hi | Should -Be ' hi '

# BROKEN: Due to quoting, '--%' should be passed through as-is, but it is still interpreted as the stop-parsing symbok.
cmd /c echo '--%' hi | Should -Be '--% hi'

Expected behavior
Both tests should pass.
Actual behavior
The 2nd test fails with the following error:
Expected strings to be the same, but they were different.
Expected length: 7
Actual length:   3
Strings differ at index 0.
Expected: '--% hi'
But was:  ' hi'

PowerShell Core 7.1.0-preview.5 # originally reported for PowerShell Core 7.0.0-rc.1

Additionally, even though --% as an argument is removed, suggesting that the stop-parsing symbol is (unexpectedly) recognized, its usual behavior does not kick in, in that string interpolation still does take place:
# OK - literal use of --% causes the remainder of the command line to be passed as-is:
PS> cmd /c echo --% $PSVersionTable.PSVersion
 $PSVersionTable.PSVersion

# !! The *quoted* --% is HALF treated as the stop-parsing symbol:
# !!   * it is NOT passed to the target process
# !!   * however, normal string interpolation still takes place.
PS> cmd /c echo '--%' $PSVersionTable.PSVersion
 7.2.0-preview.2

Additionally, even though --% as an argument is removed, suggesting that the stop-parsing symbol is (unexpectedly) recognized, its usual behavior does not kick in, in that string interpolation still does take place:
# OK - literal use of --% causes the remainder of the command line to be passed as-is:
PS> cmd /c echo --% $PSVersionTable.PSVersion
 $PSVersionTable.PSVersion

# !! The *quoted* --% is HALF treated as the stop-parsing symbol:
# !!   * it is NOT passed to the target process
# !!   * however, normal string interpolation still takes place.
PS> cmd /c echo '--%' $PSVersionTable.PSVersion
 7.2.0-preview.2

The only solution I was able to find that works well both for PS echo and Linux /bin/echo is the following workaround :

In GetCommandArgumentExpression: if the parameter is --% which is SingleQuoted, then return '--%' (i.e. add back the ').
In InvokePipeline: if one of the parameters is '--%', change it back to --% (i.e. remove the ').

Since this is patchy and very specific solution (and may not be the right approach in any case) I understand that it may not  be worth considering.  I am still describing this solution as maybe it may help with finding a solution.


Make particular classes non-final

Would you be so kind to make classes like BriteDatabase, QueryObservable non-final for testing purposes?
PowerMock doesn't work with Mockito2.
Mockito2 final classes mocking feature is still in development and doesn't work good enough.
It is a bit tricky in this case to mock queried data.
Actually i needed to have db object wrapped and I then i had to use filled cursor to mock query map to list. It is not that convenient.

You don't need to mock QueryObservable since it has a public constructor and you can create instances with whatever behavior you want like this.
As to BriteDatabase, I'm not convinced that we should allow mocking. It's a complex API that if mocked would almost certainly lead to you writing a test that verified the interactions and arguments used. This would be a bad test because any change to those interactions or arguments would require the test to change–even if the resulting behavior didn't change. If you pass null as the DB path to your open helper an in-memory database will be used which lets you run your tests against the actual SQLite implementation without worrying about files on disk. This ensures you're testing against real behavior and not mocked behavior and also that you're not scripting database interactions. Conversely, if you do want to mock the database, I would recommend mocking at a higher level abstraction which is much more declarative to your domain instead of your database. That is, there should be a layer above BriteDatabase with methods like addUser(User), for example, which don't leak implementation details about the database itself into the API and allow your tests to mock out the entire storage layer instead of trying to just mock a database layer.

Thank you for your attention!
I can agree with you about BriteDatabase, although i am separating testing for working with data models and interaction with db.
I already have tests for a mapper (save / restore)
And for example I have an interactor with BriteDatabase inside.
I am testing interactor, and like with testing of interaction with retrofit api, sometimes you just need to test reaction to external services. So we are mocking the retrofit interface, and testing reaction of our interactor to whatever mocked interface "sends" to us.
So when i need the same behaviour from db, i loose it.
I am testing not the db, just reaction to data it sends to me.
For example i can't just mock Db.createQuery and use QueryObservable, that sends us a data via a method mapToList. 'cause these classes and methods are final.
All the flow goes through rx flow and i believe i don't really need to have real db in my interactor.
Code example (I need to emulate in the test a reaction to a restored list of SerpElement:
override fun getSerpElements(start: Int, limit: Int): Observable<LoadingState<List<SerpElement>>> {
       return db
               .createQuery(CacheTable.TABLE, PAGE_QUERY, key, limit.toString(), start.toString())
               .mapToList(SerpElementMapper())
               .map { LoadingState.Loaded(it) as LoadingState<List<SerpElement>> }
               .subscribeOn(schedulers.io())
               .startWith(LoadingState.Loading())
               .onErrorReturn { LoadingState.Error(throwableConverter.convert(it)) }
   }

I hope you understand my point.

Sorry for the long delay on this, but we're not going to be making this change.
The sample code you outlined conflates two things which is why it's challenging to test. You're interacting with the database via SQL and your presenting that interaction to the UI. These are two separate concerns and those concerns should be reflected in the code structure.
If these were separate, you could test the SQL with an in-memory DB integration test to ensure it produces the right outputs after being mapped to a list. The UI presentation could then be separately tested using an dummy observable that returned a fake list and ensured the correct interactions were performed.


feat: Implement getTokenInfo

Description:

Related issue(s):
Fixes #108
Notes for reviewer:

Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

Let's delete the branches of closed PRs (they can be restored later if needed).


NumLock / Capslock Indicator

Feature Request.
NumLock / Capslock Indicator, it has to be possible some how, if I toggle NumLock / Capslock on the remote computer, the usb keyboard connected to the host toggles the LED indicator.
Maybe send a NumLock / Capslock toggle by clicking the indicator on the host and remote computer match.
Right now I would need to click out of tiny pilot, toggle NumLock / Capslock on the remote computer and then click back to tinypilot and toggle NumLock / Capslock again on remote computer to match.
Numlock on remote computer
Numlock off on host computer
Type using the 17 numeric keypad

CapsLock off remote computer
CapsLock on on host computer
Type lower case letters

This is possible, but it would require some plumbing at the HID level. The HID interface does respond with data that indicates which LED lights on the keyboard should be lit:

Another interesting example is the caps lock test. Type –caps-lock and hit return. A report is then sent by the gadget and you should receive the host answer, corresponding to the caps lock LED status:
--caps-lock
recv report:2

https://www.kernel.org/doc/html/latest/usb/gadget_hid.html
But we currently ignore the response from the HID. Relevant code is here:
https://github.com/mtlynch/tinypilot/tree/9503ea56074f05412499e10d6eb9f68a715644f3/app/hid


IDVA6-1560 Vulnerabilities in dependencies fixed

Link to Jira:
https://companieshouse.atlassian.net/browse/IDVA6-1560
Changes:

Vulnerabilities in dependencies fixed

CI: No security warnings found


Solved issue #83

Used QDir::tempPath() function to get the users relative path for their Temp folder

lgtm


wrong i18n translation path while using rspec for views

Hello
I came across a strange behavior while trying to verify a translated variable with rspec. For example, if I have
<%= t('.info') %>

in an app/views/agency/orders/cancel.html.erb file, than while rendering it rspec will try to look for a translation here (talking about ru locale, for example):
ru, agency, orders, cancel, html, info

but not here:
ru, agency, orders, cancel, info

Is it posible to make it search in the right (default) place?

I have gotten the same with rails 3.1 and rspec-rails 2.7

@emadridm same question to you: can you verify the same problem doesn't happen in a Rails view test?

Same issue here, rails 3.1.3, rspec-rails 2.7.0
My view uses a lazy lookup, ie. t('.title'), and looks for da.shifts.index.table_summary
My view spec, however, searches for da.shifts.index.html.table_summary
Any other info I can I provide to aid debugging?

Any other info I can I provide to aid debugging?

@cabgfx yes - you can show that this issue does not happen when using a Rails view test (ActionView::TestCase), but does happen when using a comparable RSpec view spec?

Thanks for replying - I'm a bit unsure of how to approach this though; – should I set up a comparable test with Test::Unit, or is it just a matter of using regular assert_*'s in my spec?
Still a bit new to this, as you might have suspected :) :bowtie:

Hi guys, I am facing the exact same problem as everyone else in this thread.
I also created a TestUnit test to confirm that the bug is somewhere in my rspec setup. The TestUnit test is working just fine.
I am currently using rspec 2.8.0. When I check the rendered HTML I see lots of I18n tranlsation missing hints like translation missing: en.internal.musicians.edit.html.instruments. I get the specs running when changing my spec from
    describe "internal/musicians/edit.html.erb" do
    # spec
    end

to
    describe "internal/musicians/edit.erb" do
    # spec
    end

or
    describe "internal/musicians/edit" do
    # spec
    end

Any ideas how to tackle the problem?

@namxam Your solution is exactly what worked for me as well. It has to do with changes from 2.7 to 2.8 – issue #485 has a lot of info/details.

Nice… I didn't know about that. Thank you @cabgfx

@cabgfx #485 is due to changes in rails, not rspec. We're just trying to figure out the best way to follow along in rspec-rails.


CPPify GPIO and Pin

 libDaisy - GPIO C++ update

OK this is working well from the limited tests I've made. I'm certain there are bugs in here, but it's a big PR, so it would really benefit from the better unit test coverage we have coming down the pike.
Other than that, some reviews on the GPIO and Pin classes themselves would be good. I also updated hal_map to cpp as part of this.

I agree with @TheSlowGrowth's notes so far. I'll have some time later this week to give this a review myself.

I've marked this as a draft for now, and renamed to a more fitting name given that #451 handles the new types.
It might be worth just using this as a reference, and doing individual PRs to update each relevant peripheral/device to use the new Pin/GPIO structs in stead of the old types. It'll definitely be easier to review.
Fortunately, for the time being the new Pin object can be dropped in anywhere that the dsy_gpio_pin was previously used.

Due to the massive amount of conflicts, and the fact that it might be cleaner to piece-meal update the affected internal bits, Im going to close this for the time being
the Pin and GPIO have been added in master, and are usable with all typical user-facing APIs


Enable eager execution

In order to further optimize the development cycle eager execution will be big feature. The idea is that you can run partial pipelines / single components easily and get instant feedback on how your data is moving through your pipeline.
This is a interactive feature which makes the most sense in a notebook like environment which allows for partial code execution. I see a couple of blocks we need to solve:
Execution environment
Where will the code (eagerly) run. Can we use the runners for this? Or is this too slow and we will need a virtual runner?
Interface
How will we design the interface to allow this feature ? Ideally we do not disturb the current fondant pipeline definition code AKA we should be able to parts of a pipeline eagerly while still preserving a full pipeline definition.
Some ideas
Some pseudo pipeline code
pipeline = fondant.Pipeline(...)

dataset_1 = pipeline.read("some_read_component")

dataset_2= dataset_1.apply("some_transform_component")

_ = dataset_2.write("some_write_component")

We could call execute on the intermediate datasets
res = dataset_2.execute()

We could have a way to pass dummy data to the execution to avoid having to run all previous steps or/and we can handle the dependencies smartly by leveraging caching.
I did some experimentation on this for the xmas project week (see here)
Note:

this was before the lightweight components
this worked but ran in the current environment (So no docker)

### Tasks
- [ ] https://github.com/ml6team/fondant/issues/838

I quickly went through your PoC code for the Christmas project. Here are a few thoughts from my end.
When it comes to notebooks, in my opinion, we should aim for super-fast execution of components. We should be able to execute a cell and see results immediately. I would execute component in the interactive environment directly. I don't think we need to develop a new runner. If we apply some limitations to notebooks, only allow one Python version, and install all dependencies within the environment, we can come up with something else.
I considered constructing two additional classes, e.g., InteractivePipeline and InteractiveDataset . This would create a clear separation between the docker-based pipeline execution and an eager execution in the notebook. We have already implemented some checks to determine if we are executing code in an interactive environment or not. When we are in an interactive environment, I would use the InteractivePipeline  and InteractiveDataset as default. The interface does not change.
dataset = Pipeline(...).read("some_component")

In the case of lightweight components, we can directly execute the component code. We must ensure that all extra requirements are installed locally (if not, we can install them using subprocess calls).
In the case of reusable components, we should be able to load the component code and execute it. Currently, the components are part of the source folder. The difference is that we would have to use the yaml specification to evaluate the schema.
I'm unsure if this is scalable when we don't have all available reusable components in our repository, e.g., a community member pushing components to a different Docker Hub namespace, etc. However, this isn't possible at the moment either.
In both cases, the distinction from the existing classes would be executing the component immediately instead of just generating a ComponentOp.
I propose adding an option to limit the read operation. This would load only a single partition or a restricted size of the dataset, facilitating faster development iterations.
Another reason to use InteractiveDataset is that it allows us to contain a pandas dataframe and provide methods to share the dataset with others.
We could even override some functions, such as _repr_html_, to display the dataframe within the notebook using colab features.
class InteractiveDataset(Dataset):
  def __init__(self, dataframe: dd.DataFrame, pipeline):
    self.dataframe = dataframe
    self.pipeline = pipeline

  def _repr_html_(self):
    # using compute() here for demo purpose
    # if we work with small dataframes in interactive manner it should be fine
    # maybe we find a other way to handle this
    return self.dataframe.compute()._repr_html_()

  def apply(self, ref):
    # build ComponentOp and extend to self.pipeline using super methods
    # evolved_dataset = self._apply(...)
    # self.dataset = evolved_dataset
    component = ref()
    dataframe = component.transform(self.dataframe)
    return InteractiveDataset(dataframe=dataframe, pipeline=self.pipeline)

  def view(self):
    return self.dataframe.compute()

Using the view function could be a nice addition for data scientists to visualize and explore the data with the tools they are accustomed to. If we transform the data explorer into an explorer sdk, we might find a good overlap here as well. We could leverage this for visualization within the notebook.
The same strategy I would apply to the apply and write methods. We could implement the same behavior in the InteractiveDataset.
During the call of read, apply, and write in the InteractivePipeline, I would still add the component to a “real” pipeline. With the normal runner, we could retrieve the normal pipeline and execute it normally by submitting it to the remote runners.
A big downside of this approach is that the implementation differs from the real pipeline execution. We wouldn't write files to the base_path , we can't use the data explorer to investigate data, and we can't leverage caching.
However, I would argue that this isn't so dramatic since it is a development tool for notebook users. I expect people could use this with small datasets to build fast pipelines, execute specific steps sequentially (eliminating the need for caching), and utilize pandas features within the notebook environment (like the data explorer feature).
We could recommend starting development in a notebook, testing on a small sample, and then scaling it out using Vertex or Sagemaker.

Here are some small code snippets in a Colab to show what it could look like:
https://colab.research.google.com/drive/1H3KbEkypUDyKyBx4zVuXjbpiCLEvjHkt?usp=sharing

Thx @mrchtr! You are on the right track but I would be careful on how we make everything possible while keeping our code clean and single responsible:
I see 3 things we could tackle separately:

Enable eager execution:
I think we can make some choices here to make this feature manageable we can still evolve it later. This is mostly for interactive development environments (mostly notebooks). I would make some assumptions here to make this possible:

We run the component the moment it is defined this means we don't need to call a .execute() method on it. This also means that we can assume that all previous components have ran (since they are chained) so we don't need to start checking the graph to make sure all dependencies have ran. This means that we can limit eager execution to single component pipelines.
-It should work with every runner (we build single component pipelines under the hood). Not all runners are equally fast but that does not need to be a problem. This way we can also keep our code clean (runner agnostic). (also we would need a virtual environment runner to really support speed).
We keep the interface as is (as much as possible). Either we specify a global eager flag or we can set on a component level but ideally the interface is the same for eager execution.
We will need to rethink the usage of the Pipeline object since now we start with it but maybe we can alter it to make eager execution more intuitive. We are moving to a a more dataset centered approach then a pipeline one.
OPTIONAL: we could add support for feeding in dummy data samples for real quick iteration.

TBD

TBD

OPTIONAL: we could add support for feeding in dummy data samples for real quick iteration.
I think this one is highly related to #806. When we pass dummy data to the component we can infer the produces.
Maybe we could implement #752 as part of this epic here.


Failed to open stream: Permission denied (disappearing .fpt that is not regenerated)

Hello,
I have previously contacted you in regards to the php-xbase plug-in, and am happy to report that my original efforts to utilise the php-xbase plug-in to send data from a MySQL database to a .DBF file had been successful.
However, an attempt to use the same plug-in to perform the same functionality with the same code in the same folder on a different .DBF file has resulted in the following error message:
Warning: copy(C:\datafolder\wws_customers.fpt): failed to open stream: Permission denied in C:\projectfolder\vendor\hisamu\php-xbase\src\Memo\AbstractWritableMemo.php on line 104

The .fpt file has disappeared and has not been re-added to the data folder, resulting in the table being unusable. This issue exists despite the same code existing (except for different links) for the previous successful attempt to send data to a .DBF file.
The debugging process has included the following processes:

Folder permissions were checked, as this appeared to be an issue when I previously contacted you and your group, and the results confirmed that users could read and write to files, so permissions must not be an issue
The .DBF, .FPT and .CDX files had various upper and lower-case lettering, and had been previously listed as a possible issue, though this difference in lower-case has always existed, and was subsequently not found to be a cause of issues in the past (the code preserves the upper and lower-case lettering)
Comparing the original file that successfully added records to a different .DBF file side-by-side with the new file (no discrepancies found)
Determining when the plug-in reads a memo field, ensuring that all memo fields are read (all memo fields were successfully read)
Outputting memo data that is entered via the TableEditor (all memo fields displayed expected data)
Outputting data that is to be sent to pointers, to confirm correct data is being stored there (all data displayed was expected)
Outputting cloneFilepath and filepath in the AbstractWritableMemo file to confirm file path locations for the clone and main file paths respectively (both file paths utilise the same data folder, just like previous efforts to successfully utilise the php-xbase plug-in)
Outputting current user, and which user executed the script (they were both the same, as expected)

As a test, I created a copy of the .DBF file that is to be modified, but only with a few fields. None of them were memo fields. Data was sent correctly and appeared in the .DBF file as expected. Once a memo field was added to the .DBF copy, the warning message re-appeared. So this, in my opinion, means that the target .DBF file is not corrupted.
The .DBF files used, along with its supporting files, are in the same data folder.
The only difference of any kind that I have noticed between the previous successful attempt to send data to a .DBF file and this unsuccessful attempt is that there are three file formats missing from the current attempt, which is a .BAK, .TBK and .ERR file. Again, these should not prove to be significant. A .BAK and .TBK file refers to backups that are generated if a significant structural change is made to a .DBF file, which is not the case here. A .ERR file refers to what is effectively a text file to list any errors that may occur.
With all of the above information in mind, are there any other possibilities that could possibly account for the different outcome between the two applications of this plug-in? It feels like I have exhausted all reasonable avenues to account for any differences in code or files. Any helpful feedback would be greatly appreciated.
Regards,
Craig

As far as I remember, we have already discussed this problem in #116.
Please check editMode in TableEditor. What value is used? Can you change it to REALTIME and try with it?
https://github.com/luads/php-xbase/releases/tag/1.3.2


update: FAQ section

I will add the FAQ component in the QnA format.. Can I work on this issue for gssoc?

I also want to add the FAQ in the Q/A in the json file. I want to work on this for gssoc . could you please assign this to me

I also want to add the FAQ in the Q/A in the json file. I want to work on this for gssoc . could you please assign this to me

Please assign me this issue under GSSOC'23

@SINJINI-G are you working on it ??

Yes @PiyushKalyanpy, I am working on it.. will make a PR soon.. I have a small doubt regarding which I have messaged you on discord. Kindly check.

@PiyushKalyanpy sir i want to work on this issue under gssoc'23

hey @PiyushKalyanpy  I am interested in working in this issue. I will implement beautiful accordions for it.

We are closing this issue because it has been inactive for a long time.

Hey @PiyushKalyanpy I am interested in working on this issue if you still want the page.


Feature request : Create Categories for Questions

We should support categories in addition to tags.

The idea is to have a property called boolean attribute isCategory to Tag. Let me know if this looks fine so that i can submit a PR

👍


typo "patth" please fix it

https://github.com/hoanhan101/ultimate-go/blob/8fa8b47c12dbef0f63c49dbe367ce717324c6dee/go/language/exporting/exporting_1/exporting_1.go#L10

Thanks for the catch. I've fixed it!


sql result queried by xorm is different then I executed from client

problem summary
the sql result queried by xorm is different then I executed from client
I found this issue in my project and create a repo to demonstrate it, please check
environment
go: 1.12.4
mysql: 5.7.12
steps to reproduce

clone this repo  https://github.com/huahuayu/xorm-issue
have mysql installed
create a database named asset
execute the init.sql script to import the tables
modify main.go accordingly(DSN part)
go run main.go
check the output, the orderId result is not right

@lunny @BetaCat0

You should rename OrderID -> OrderId or you can use core.LintGonicMapper.

@lunny you are right, problem solved, thank you!


Remove roy mirror

Description of changes
Roy Marples started releasing his stuff via GitHub, instead of hosting tarballs on his website. Replace uses of mirror://roy with fetchFromGitHub and remove the mirror.
Fixes #231217.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Because this PR causes more than 500 rebuilds, please rebase this PR onto the staging branch. To avoid a github mass ping, follow the instructions in CONTRIBUTING.md.

Damnit, sorry. I followed the CONTRIBUTING.md instructions and the git rebase --onto upstream/staging... upstream/master didn't change anything. So I did a straight rebase onto staging and pushed that, and ... yeah. Sorry for the noise.

It looks like you accidentally mass-pinged a bunch of people, which are now subscribed
and getting notifications for everything in this pull request. Unfortunately, they
cannot be automatically unsubscribed from the issue (removing review request does not
unsubscribe), therefore development cannot continue in this pull request anymore.
Please open a new pull request with your changes, link back to this one and ping the
people actually involved in here over there.
In order to avoid this in the future, there are instructions for how to properly
rebase between branches in our contribution guidelines.
Setting your pull request to draft prior to rebasing is strongly recommended.
In draft status, you can preview the list of people that are about to be requested
for review, which allows you to sidestep this issue.
This is not a bulletproof method though, as OfBorg still does review requests even on draft PRs.


Search diminutive names

Use Elasticsearch's synonym filter and a list of common diminutives to allow searching for Bob <=> Robert, Matt <=> Matthew etc.

Don't merge this yet: we should test it a bit more (as it may have undesired side-effects).


Version 1.1.0

Template Updates

Removed SwiftLint warnings
Omitted application prefix in naming
Dropped class prefix in mock view model events

Added commentary explaining anti-pattern of adding view modifiers in coordinator root view
Alerts no longer managed by coordinators; their presentation is now individual view's responsibility
Scene Delegate

Introduced view modifier in helpers

Destination IDs

Integrated @EnumIdentifiersGenerator macro for auto-generating code for Hashable and Identifiable protocol conformance
The macro produces nested enum for ID generation for enum cases

Introduced FlowProvider in helpers
For coordinators, integrated ModalCoverModel<Destination> to avoid UI confusion regarding sheet and full screen cover presentation order

Prerequisites for Merging:

New projects must specify a key-value pair for LaunchScreen in Info.plist to ensure proper display
Macro

Requires importing EnumIdentifiersGenerator currently, but ideally, it should be part of FuturedArchitecture

UPDATE: Macro moved into a separate git repository

It doesn't account for situation when Destination ID needs to be computed using an associated value

UPDATE: DONE

Macro Expansion Example:


newrelic_fread_fwrite_intercept() error.

The exact issue is https://github.com/yiisoft/yii2/issues/8960.
We are using Yii2 frameworks, with newrelic enabled and using newrelic_fread_fwrite_intercept()
    public function actionTemp() {
        $stream = fopen('php://temp', 'r+');
        fwrite($stream, 'TEST');
    }

It returns Unexpected object type File. error.
When we remove newrelic_fread_fwrite_intercept(), it works.

Seems to be related to stream_socket_get_name:
<?php
$stream = fopen('/tmp/temp', 'r+');
var_dump(stream_socket_get_name($stream,true));

# hhvm test.php
[Mon Nov 30 11:40:07 2015] [hphp] [29752:7fb396985480:0:000001] []
Fatal error: Unexpected object type File. in /root/test.php on line 3

# php test.php
bool(false)


Fix resourceQuotaSpec with GPU

nvidia.com/gpu: "1" actually doesn't work.
requests.nvidia.com/gpu: "1" works well.
https://kubernetes.io/docs/concepts/policy/resource-quotas/#resource-quota-for-extended-resources

/ok-to-test
Preview: https://deploy-preview-2460--competent-brattain-de2d6d.netlify.app/docs/components/multi-tenancy/getting-started/

/assign

/lgtm
/approve
Thanks for fixing this @kim-sardine!


Does not work in android release

When building an APK with the command, the drawer menu does not work. The menu does not move to the side as expected, but instead says on the left. The content does seem to scale,as well as the borders round.
Steps to reproduce:
cd example
flutter build apk --release
adb install build/app/outputs/apk/release/app-release.apk

I just tested with flutter beta channel, and it seems to work.


Fix classes for backward compatibility

Hey, LA team 👋
ML team found some time to check out new client (v3) you provide for us. Here a PR to make everything work as it was. https://github.com/src-d/ml-core/pull/31 is the PR in ml-core that is waiting for a new release of bblfsh client.
It is more or less obvious what I changed and why, but ask me while reviewing if it is unclear. Every change is necessary or some test fails in ml-core`.

This change is

I cannot assign reviewers, so
cc @creachadair

yes, it was yesterday too. I just started to fix them, but I need your help because there is C extension involved and I am not familiar with it.
https://travis-ci.com/bblfsh/python-client/jobs/218999263#L332
iterator test fails. But if you change a position of the root node to 1 (root.start_position.offset = 1)
It works!
Any ideas what is wrong are welcome.

also If you take current master and change default positions from -1 to 0 (as it should be):
https://github.com/bblfsh/python-client/blob/f2a7d7ee9b0ffa6ae24fbad1af2013d48687a0c6/bblfsh/node.py#L235-L248
test also fails.

ok, I think this bug is unrelated to my changes and located somewhere in C extension code.
So, I fix the test to make it pass as it was.
If you want I can create an issue about the iterator I found.

that is true, but when we have a protobuf and the node did not have positions all three values were zeros. I agree that it is not the best way to put things, but some of our code rely on (0,0,0) position.

Ah! So you want to say that this testIteratorPositionOrder puts Nodes with invalid positions to the end? In this case, how iterator knows which position is invalid?

Ok, waiting for a merge (if everything is fine) and a new release so I can use all these changes in ml-core. 🤞

@creachadair friendly ping :)

Thanks! @dennwc Are we good to merge?
I am not familiar with a tool you use for a review but it is still pending


Refresh Token process not implemented - Causes re-auth issues with Google (maybe Facebook)

Using the Google Sign iOS SDK I am able to get the id_token, access_token, authorization_code, and refresh_token. The problem is that when authenticating to Azure, I get an hour session and the service does nothing with the refresh_token to get new valid tokens. This causes my app to have to show the login screen every time the token expires (1 hour).
In the case of Facebook, I can resend my access token and it lets me continue using Azure (related bug with Azure Facebook here: https://github.com/Azure/azure-mobile-apps-net-server/issues/60).
I've read on the forums here: https://social.msdn.microsoft.com/Forums/azure/en-US/1765c45d-c70e-44bd-ad6f-0b2659ec634f/authentication-tokens-expiring-quickly?forum=azuremobile, that they are working on working on the refresh token process. I wanted to create an issue here to officially track it. The Uservoice request for it is here: https://feedback.azure.com/forums/216254-mobile-apps-formerly-mobile-services/suggestions/11182890-implementation-of-refresh-tokens-for-azure-app-ser
If you need any additional information, please let me know.

Thanks. I'll leave this issue open until the solution is rolled out. We'll have more information and docs available as soon as it is ready for consumption.

@cgillum has written a great blog post documenting the token store. It explains how to use the new App Service Authentication feature for refreshing tokens (see the Refreshing Tokens section). There is a specific code sample there for Mobile Apps.