Helm/Kustomize panels should be disabled in cluster view

When I load resources from my cluster I expect the Helm / Kustomize panels to be disabled since they don't reflect any content in my cluster - currently I can still see the kustomizations/helm-charts of my last viewed local resources and preview them (which exits cluster mode)

what about this other issue https://github.com/kubeshop/monokle/issues/1983 ?
or maybe the ability to quickly compare a chart / kustomization with the cluster resources?
I'm thinking of the following workflows:

Load Cluster Mode
Go to Helm pane
Hover a values file and see a "Compare" quick action
Click on it and then the Compare modal opens up
One side would be the cluster resources that were loaded and the other side would be the preview resources

What do you think?

thanks @devcatalin - good point - that's a really nice workflow that would work for both kustomize and helm - i guess we should only remove the "preview" action for kustomizations/helm-charts to avoid my above scenario?
In regard to #1983 - could that be in a separate "Cluster Content" panel? Or should we add info about deployed helm-charts to the helm panel somehow!? @julioramosest what do you think?

I don't think going with a separate panel will be the right way to go, because we might have other features or panel affected by the Cluster Mode.
Maybe we should look into how we can inform the user which panels are affected by Cluster Mode and then continue with this issue.

agree with @devcatalin - I proposed something for https://github.com/kubeshop/monokle/issues/2023 (see comment there)

Is this already fixed?


Add dynamodb locking for s3 backend rename calls

Description
The description of the main changes of your pull request
Related Issue(s)

Documentation

Sorry @mosyp the rustdocs work that  did has brought some conflicts in that you'll need to resolve here :frowning_face:

@houqp That is reasonable but it conflicts (imo) with. some of the logic in https://github.com/delta-io/delta-rs/discussions/89#discussioncomment-606534, let's move our discussion into that comment section.
P.S. I'll move locking inside s3 rename and after that we'll decide what to do with repairing commits within lock

Considering the downside is minor code size increase, this seems like a good tradeoff.
@houqp @xianwill

Since most of the users would like to have safe and distributive writes I feel like this is what we should do. I might address that within my next PR if there's no objections.
AFAIK only @rtyler was asking regarding having it optional way before we started working on it

yeah, I feel like as long as we make it optional we should be good, i.e. not forcing every s3 users to setup and configure dynamodb.

Is dynamodb compulsory for rename now?

@hustnn it's not required if you only have a single writer and don't need concurrent write support.

@hustnn it's not required if you only have a single writer and don't need concurrent write support.

@houqp I found it throws exception if lock client doesn't exist. I removed it in my local branch https://github.com/hustnn/delta-rs/commit/23836cdaf2fc2120b1d1f4c7e55d87badca6d1a2

@hustnn that's not expected, could you send a PR to fix that?

ok


Fix CI

The CI script complains because it's trying to build infer with an old version of ocaml, so to remedy this I bumped the ocaml version in CI. It looks like the CI passes with this change, I did some testing on my own fork of infer and got the CI job to pass in Travis.

Thank you @waylon531, sorry we missed this when migrating to 4.08.


Power Toys lags

Microsoft PowerToys version
0.75.1
Installation method
Microsoft Store
Running as admin
Yes
Area(s) with issue?
ColorPicker, Environment Variables, FancyZones, File Locksmith, File Explorer: Preview Pane, File Explorer: Thumbnail preview, Keyboard Manager, Mouse Utilities, Mouse Without Borders, Paste as Plain Text, PowerToys Run, Quick Accent
Steps to reproduce
Launch the application.
✔ Expected Behavior
It should load.
❌ Actual Behavior
I can't describe what happened. Here is a picture.

Other Software
Where can I find this?

Hi, are you referring to the menu items that stay highlighted?

Are you able to open the menu?
Are you using a touch screen or a mouse?

/needinfo

Yes, I am referring to them. I couldn't describe them. The things that were highlighted took some time to load but the things that were not highlighted loaded properly. I am using a touch screen.

It has been a day they are still highlighted.


Notification image text no period name parse

When using the Notification icon generator and using text as the source. The system is unable to parse a period (.) into the automatic name file generator. Could you please implement this it is is not too much trouble.
For example:
Input source: 1.1
Output name: ic_stat_1
Desired output: ic_stat_1_1

Will be fixed in the next very bug update.


chore(deps): upgrade jenkins-x/jx3-versions to version 1.1.39

from: https://github.com/jenkins-x/lighthouse.git

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign hferentschik
You can assign the PR to them by writing /assign @hferentschik in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Document Traffic Router API Fully

The TR API has docs: https://traffic-control-cdn.readthedocs.io/en/latest/development/traffic_monitor/traffic_monitor_api.html
But they're incomplete, and not in a very visible place.
We should add explanations and examples of what they return.
We should also probably put the Router API docs in a more visible place. Maybe create a unified root "APIs" doc page, with links to the APIs of every component?

@rob05c - the issue title says TR but the link in description is to TM docs. can you fix?

The Traffic Router API has documentation now, and I've been told it's complete:
https://traffic-control-cdn.readthedocs.io/en/latest/development/traffic_router/traffic_router_api.html#tr-api


Feature/eventslistredesign

Attempt at making an alternative design for events page, because it feels a litt outdated
Thought of implementing the boxes we use on the frontpage, but came up with an new design
Implemented eventquery
Would like feedback from everyone on this
first draft looks like this:

Still needs icons for switching between old list view and imageview.
Could be neat with 3 different views, grid view, imagerowview, and textrow view.
Give Input.

Also may look a lot like infoboxes, so may need a way to look different from them

Kan du legge ved et bilde av hvordan det er i dag for sammenligning?

Idag:

Det kunne vært fint med bilde og hover effect. Utsolgte blir grå.

Etter sigves endringer, så kaster jeg denne vekk


Updated readme primary description.

DEV itself did not technically become Forem, only the code did, so I feel like this may clarify that point for those who might think DEV the website was renamed to Forem.

Yep, makes complete sense! Thanks for contributing!


Add Trunk All ports and connexions on VLAN Topology

Hello Mister the creator of this superb plugin
When we choose vlan filter to show topology VLAN we didn't have trunk all port.
I customize my views.py to integrate it.  (line 239)
interfaces = vlan.get_interfaces()
interfaces2 = Interface.objects.filter(mode='tagged-all')
filtred_devices = [d.id for d in nb_devices_qs]
filtred_interfaces = []
for interface in interfaces:
    if interface.is_connectable:
        direct_device_id = interface.device.id
        interface_trace = interface.trace()
        if len(interface_trace) != 0:
            termination_b_iface = interface_trace[-1][-1]
            connected_device_id = termination_b_iface.device.id
            if (direct_device_id in filtred_devices) or (direct_device_id in filtred_devices):
                filtred_interfaces.append(interface)

for interface2 in interfaces2:
    if interface2.is_connectable:
        direct_device_id = interface2.device.id
        interface2_trace = interface2.trace()
        if len(interface2_trace) != 0:
            termination_b_iface = interface2_trace[-1][-1]
            connected_device_id = termination_b_iface.device.id
            if (direct_device_id in filtred_devices) or (direct_device_id in filtred_devices):
                filtred_interfaces.append(interface2)

devices = []
for interface in filtred_interfaces:
    if interface.is_connectable:
        if interface.device not in devices:
            devices.append(interface.device)
        interface_trace = interface.trace()
        if len(interface_trace) != 0:
            termination_b_iface = interface_trace[-1][-1]
            if termination_b_iface.device not in devices:
                devices.append(termination_b_iface.device)

I think you can integrate it (code) better than me.
Thanks again for you work it's amazing
Bien à vous.

Hello @Naideus,
For a switch a "trunk all" port means all VLANS in that SW vlan database, but the device on netbox doesn't have a vlan database model, so by doing that you really can't know if that "trunk all" allow the filtred vlan on the query, and so your plot might have a lot of wrong devices and links, that's the same point in this discussion on [Netbox discussions](https://github.com/netbox-community/netbox/discussions/5702).

In my netbox implementation I never use the "trunk all" mode, I prefer to map all the vlans on the DB and add each one on the interface, and imho  I think that's a better way to deploy because on the vlan model I always can see the interfaces associated to a VLAN.
About the implementation @iDebugAll what do you think, if i was implement that feature I would go for itertools.chain with something like this:
interfaces = itertools.chain(
                                   vlan.get_interfaces(),
                                   Interface.objects.filter(mode='tagged-all')
                    )

and keep the rest of the code.

Malo @renatoalmeidaoliveira
thanks for your optimisation and your answer.
I agree with your point of view. The best way is never use  "Trunk All".
Have a good day
Regards


BUG(delete): Unexpected newline error on deletion confirmation

Describe the bug
Sometimes when using the --delete flag to remove unused resources from the cluster, the following occures:
When user is asked for confirmation, the following error raises when submitted:
$ kor sa --delete
Do you want to delete ServiceAccount test in namespace test? (Y/N): Failed to read input: unexpected newline

As the input was invalid, the resource is not deleted.
To Reproduce
Steps to reproduce the behavior:
Use --delete flag to remove resources and submit confirmation input.
Expected behavior
The input is accepted and kor proceeds to resource deletion.
Screenshots

OS version, architecture and kor version
e.g. Windows 10
Kor version: 0.5.1
Additional context
Add any other context about the problem here.

/assign
WIP in #323


Question: Does bluepill support running Xcode UI testing?

 However I'm getting the following error.  A bit googling suggests that this might be due to UI testing having different test template/config than "regular" XCTests. Is Xcode UI testing supported by bluepill? :)
Terminating app due to uncaught exception 'NSInternalInconsistencyException',      reason: 'No target application path specified via test configuration: <XCTestConfiguration: 0x60800011a9d0>
Thanks!

hey @dyang , we haven't actually tested this with Xcode UI testing. Our UI tests are all KIF tests.
We collect the test target by searching SampleApp.app/Plugin/*.xctest. You can test by adding a additional-xctests flag in the config file to the UI testing target and try from there.
It would be great if you can tweak the code base a bit and let us know the result.

When you compile an XCUITest there are no .xctest files generated in the target app's plugin folders. Instead it's placed inside the runner, named `TEST_TARGET_NAME-runner.app.
I gave that a whirl and all 5 sims exited with the same error:
[  INFO  ] Started Simulator 5 (PID 42860).
bp: invalid configuration
	iOS 10.1 is not a valid runtime.

When checking valid runtimes:
== Runtimes ==
iOS 9.3 (9.3 - 13E233) (com.apple.CoreSimulator.SimRuntime.iOS-9-3)
iOS 10.2 (10.2 - 14C89) (com.apple.CoreSimulator.SimRuntime.iOS-10-2)
tvOS 10.1 (10.1 - 14U591) (com.apple.CoreSimulator.SimRuntime.tvOS-10-1)
watchOS 3.1 (3.1 - 14S471a) (com.apple.CoreSimulator.SimRuntime.watchOS-3-1)

@krze that's another issue mentioned in #8 , you need to download iOS 10.1 simulator Or alternatively, search for BP_DEFAULT_RUNTIME and change the value to 10.2

Looks like the target application isn't being pulled from the XCUITest .xctest file:
2017-01-19 17:47:04.802 ApplicationNameX[44527:3337770] *** Assertion failure in -[XCUIApplication init], /Library/Caches/com.apple.xbs/Sources/XCTest_Sim/XCTest-11753/XCTestFramework/UI Testing/XCUIApplication.m:72
/Users/krze/develop/ApplicationName/UITests/TestHelpers.swift:0: error: -[UITests.AppRatingPromptTests testShowsAfterTestSetup] : failed: caught "NSInternalInconsistencyException", "No target application path specified via test configuration: <XCTestConfiguration: 0x60000011df40>
	                  testBundleURL:file:///Users/krze/develop/ApplicationName/TestBuild/Build/Products/UITest-iphonesimulator/UITests-Runner.app/PlugIns/UITests.xctest/
	         testBundleRelativePath:(null)
	              productModuleName:UITests
	                    testsToSkip:
	                     testsToRun:(null)
	             reportResultsToIDE:no
	              sessionIdentifier:18C96A25-3055-407C-8CEF-EFDAA68F8BFC
	     pathToXcodeReportingSocket:(null)
	      disablePerformanceMetrics:no
	treatMissingBaselinesAsFailures:no
	                baselineFileURL:(null)
	       baselineFileRelativePath:(null)
	          targetApplicationPath:(null)
	      targetApplicationBundleID:(null)
	               reportActivities:no
	       testsMustRunOnMainThread:no
	         initializeForUITesting:no
	 aggregateStatisticsBeforeCrash:(null)
"
(
	0   CoreFoundation                      0x000000011ab7834b __exceptionPreprocess + 171
	1   libobjc.A.dylib                     0x000000011a5e021e objc_exception_throw + 48
	2   CoreFoundation                      0x000000011ab7c442 +[NSException raise:format:arguments:] + 98
	3   Foundation                          0x00000001146dde4d -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 195
	4   XCTest                              0x000000012ba022a6 -[XCUIApplication init] + 195
	5   UITests                             0x000000012c409f1f _TTSf4n_g_n___TFE7UITestsCSo10XCTestCase11setUpTumblrfT8loggedInSb8withUserVS_11TumblrCreds_T_ + 207
	6   UITests                             0x000000012c3d23e0 _TFC7UITests20AppRatingPromptTests5setUpfT_T_ + 640
	7   UITests                             0x000000012c3d2726 _TToFC7UITests20AppRatingPromptTests5setUpfT_T_ + 22
	8   XCTest                              0x000000012b9e0e43 __24-[XCTestCase invokeTest]_block_invoke_2 + 173
	9   XCTest                              0x000000012ba197df -[XCTestContext performInScope:] + 190
	10  XCTest                              0x000000012b9e0d83 -[XCTestCase invokeTest] + 255
	11  XCTest                              0x000000012b9e159c -[XCTestCase performTest:] + 457
	12  XCTest                              0x000000012b9de664 -[XCTestSuite performTest:] + 491
	13  XCTest                              0x000000012b9de664 -[XCTestSuite performTest:] + 491
	14  XCTest                              0x000000012b9de664 -[XCTestSuite performTest:] + 491
	15  XCTest                              0x000000012b9ebd2b -[XCTestObservationCenter _observeTestExecutionForBlock:] + 602
	16  XCTest                              0x000000012ba1af0d _XCTestMain + 1050
	17  CoreFoundation                      0x000000011ab1d25c __CFRUNLOOP_IS_CALLING_OUT_TO_A_BLOCK__ + 12
	18  CoreFoundation                      0x000000011ab02304 __CFRunLoopDoBlocks + 356
	19  CoreFoundation                      0x000000011ab01a75 __CFRunLoopRun + 901
	20  CoreFoundation                      0x000000011ab01494 CFRunLoopRunSpecific + 420
	21  GraphicsServices                    0x000000011c739a6f GSEventRunModal + 161
	22  UIKit                               0x000000011877a964 UIApplicationMain + 159
	23  ApplicationName                     0x000000010effccdf main + 111
	24  libdyld.dylib                       0x000000011868e68d start + 1
)

Hmm, this should be doable, we just need to fill some extra fields in the XCTestConfiguration file.
Check XCTestConfiguration.h and SimulatorHelper.m
In SimulatorHelper.m:
Add [xctConfig setTargetApplicationPath:PATH_TO_APP]; to + (NSString *)testEnvironmentWithConfiguration:(BPConfiguration *)config; should do the trick.
Let me know if you that works :D

I tried the above solution and also added the target app bundle identifier like this
[xctConfig setTargetApplicationBundleID:BUNDLE_ID];
But I still can't get my tests to run. I don't think the test application is launching properly
<testcase classname="..." name="test..." time="61.096000">         <failure type="Failure" message="-[...Tests test...] : UI Testing Failure - Unable to update application state promptly.">

To make the UI Tests work, you need to set a few properties on XCTestConfiguration:

testsMustRunOnMainThread
initializeForUITesting
targetApplicationPath
targetApplicationBundleID

You can peek a bit here how Facebook is doing it: https://github.com/facebook/FBSimulatorControl/blob/master/XCTestBootstrap/Bundles/FBTestConfiguration.m#L85-L95

@plu love it, thanks!

@plu it turns out to be more complicated than I thought. I managed to set the environment same as the one Xcode is using to run UI test (arguments, environment and XCTestConfiguration)
    // XCTUITest configurations     [xctConfig setPathToXcodeReportingSocket:nil];     [xctConfig setTargetApplicationPath:config.appBundlePath];     [xctConfig<EMAIL_ADDRESS>    [xctConfig<EMAIL_ADDRESS>    [xctConfig setTestsToRun:[NSSet setWithObjects:@"BPSampleAppUITests/testExample", nil]];     [xctConfig setTestsMustRunOnMainThread:YES];     [xctConfig setInitializeForUITesting:YES];     [xctConfig setTreatMissingBaselinesAsFailures:NO];     [xctConfig setReportResultsToIDE:YES];     [xctConfig setReportActivities:YES];
And get:
Jan 20 01:34:23 khu-mn1 CoreSimulatorBridge[15027]: Launch successful for 'com.apple.test.BPSampleAppUITests-Runner' Jan 20 01:34:23 khu-mn1 assertiond[15022]: Could not create or rename power assertion for <BKNewProcess: 0x7ff009c10a90; com.apple.mobilecal; pid: 15102; hostpid: -1>: 0xe00002c9 Jan 20 01:34:23 khu-mn1 logd[15012]: metadata shared cached uuid is null (using logd's shared cache info) XCTRunner (15103) Jan 20 01:34:23 khu-mn1 logd[15012]: Failed to harvest strings for pathless uuid '00000000-0000-0000-0000-000000000000' Jan 20 01:34:23 khu-mn1 assertiond[15022]: Could not create or rename power assertion for <BKNewProcess: 0x7ff009c10a90; com.apple.mobilecal; pid: 15102; hostpid: -1>: 0xe00002c9 Jan 20 01:34:23 khu-mn1 XCTRunner[15103]: assertion failed: 15G1217 14C89: libxpc.dylib + 62677 [0339A402-6531-30E9-8BC2-589C463CD6D6]: 0x7d Jan 20 01:34:23 khu-mn1 watchlistd[15090]: Now playing app did change to '(null)' (playing: 0) from '(null)' Jan 20 01:34:23 khu-mn1 watchlistd[15090]: WLKPlaybackSummary - Parameter failed validation bundleID. It is nil Jan 20 01:34:23 khu-mn1 XCTRunner[15103]: Running tests... Jan 20 01:34:23 khu-mn1 XCTRunner[15103]: a Jan 20 01:34:23 khu-mn1 XCTRunner[15103]: c  // Before the launching app statement
And it got stuck at the launching app statement. Searched some old threads from Xctool, there is extra testmanagerdr to deal with to run XCTUITest?
Does FBSimualatorControl support running XCTUITest?

Does FBSimualatorControl support running XCTUITest

Yes, it's working there.

Some good news here. Finally got this working with the help in FBSimulatorControl. Will submit a PR for this.

@oliverhu when will this pr merged into the latest code to support xcode ui testing?

it is contingent on #55 , hopefully sometime next week :D

Update: the support is available in #68, please check it out. The branch works locally but can't pass CircleCI, still trying to figure out why 😕

@oliverhu I ran your branch locally and ran into two issues running UI tests.  In BPPacker.packTests(), I was getting a exception any on xctFile any time it tried to access part of it.  While debugging, looks like the file type for some reason is an Array so I fixed it locally by changing the data type from BPXCTestFile to NSArray and and used xctFile.firstObject.  Not sure if there is something different that should be done.  The other issue is a race condition when trying to run more than 1 UI test in parallel.  The same test runs across all the simulators.  If I put a debug point in BPRunner.run() after a simulator is started, specifically
[BPUtils printInfo:INFO withString:@"Started Simulator %lu (PID %d).", taskNumber, [task processIdentifier]];

and wait a few seconds to continue the program, then it will run different tests on the different simulators, without the breakpoint it runs the same test.  Let me know if you need more specifics.

@djrenfro it would be great if you could get a PR based on that branch to fix the first issue (and a test case to reproduce the second issue)

@oliverhu PR to fix the first issue in #82
For the 2nd issue, I created a branch on my fork with a second UI test added to the UI test class - https://github.com/djrenfro/bluepill/commit/ce317979156d91a210b16b2dcc4be314aaa39b0b.  If you put a debug point at the location mentioned in my previous comment and wait between 8-10 seconds after the first simulator is launched to continue, you'll see the tests run in parallel.  Without the debug point, the second test will run on both sims and the first will never run.  Let me know if you need more specifics.

@djrenfro Good catch! Merged #82. I'll take a look at the second issue tomorrow and this Friday.

@djrenfro found the problem - NSTemporaryDirectory() returns the same temporary path under different Bluepill-ci processes :(  And in my branch, I added a constant session identifier for all blupill-cli. Pushed a fix, should work now.

@oliverhu That fixed the issue I was having, working well now

Cool. Also for the CI issue, it is only reproducible with CircleCI but not with Travis, we are considering moving back to Travis and merge this branch in.

The PR is merged, please try it out and report issues :)

i tried running latest master with ui test bundle and just got
ERROR: (null)  as output.  Still working on debugging further.

@jimmyeisenhauer Try looking at https://github.com/linkedin/bluepill/pull/93

making the change in #93 got it working thanks!  Has anyone else tried the -i option with UI tests?  I just get the error {4364} 20170312.224328 [  ERROR ] Packing failed: (null)

it also looks like it will not run with ONLY a  UI test bundle - 2017-03-13 07:24:31.584 bluepill[9250:15794876] There is .xctest file under /Users/mos6y/Documents/workspace/sour-mash/./hack/Build/Products/Debug-iphonesimulator/sour-mash.app/Plugins ERROR: The folder “Plugins” doesn’t exist.

@jimmyeisenhauer could you open an issue for that?

submitted #98 #99 for the two above issues I posted. thanks!

I'm using the latest and greatest from master branch but I'm not able to run the Xcod UI Tests in parallel. They are all launched on one simulator only while my unit tests are properly parallel-ized.
Is it a well known issue or this should have been fixed on master?

@fabiomassimo is the number of UI tests >> the number of unit tests?
In current setup, if say you have 100 unit tests and 25 UI tests, and you have 5 simulators to run all of them - we will do the math as (100 + 25) / 5 = 25, so each simulator will take 25 tests. As a result, all UI tests will run in the simulator.

Thank you for explaining me that! It makes sense now.
What if I want to run only UI Tests then? In that case the algorithm should parallelise the UI test cases.
I started to look into this too but I wonder if the --exclude option is the right way to go.
The reason I'm asking is that I find it quite hard to apply to exclude all unit test cases because, as far as I understood, I have to manually specify all test cases and add them along as I add them.

@fabiomassimo I think you want the -t option that allows you to pass in a single .xctest bundle.

I can see why you've split the tests that way... but in a project where unit tests outweigh UI tests (trending towards optimal testing pyramid https://martinfowler.com/bliki/TestPyramid.html), little time-saving gains will be achieved.
It's more or less guaranteed that the length of any given UI test will exceed that of a given unit test, likely by order(s) of magnitude.
Would it be possible to treat the unit and UI test suites as separate entities? For example,
If I have 100 unit tests and 20 UI tests
And run blue pill with 4 simulators
Unit tests are split into 100/4 = 25
UI tests are split into 20/4 = 5
Unit tests are run first across 4 Sims
As soon as one sim finishes unit tests, UI tests begin on that sim

@DNCGraef  ;-) Read the read.me carefully, you'll find a flag called no-split, simply put your unit test target there.

Nice tip - I'll try that :D


Pdr web issue 284

Fixes #296 and https://github.com/oceanprotocol/pdr-web/issues/284
Changes proposed in this PR:

the get_predictoor_info script has been modularized
the pdr_backend/accuracy module is added with flask. It creates JSON output every 5 minutes and serves it with an endpoint
some methods have been replaced with their alternatives according to Trent's comments
tests are not completed created some tests but these are not working as expected, I need some backup about testing with Python

We should be using slot data to determine the accuracy for pairs. Predictoor data becomes available when predictoors claim payouts, otherwise it's not available and will output inaccurate results for pair accuracies.
The calculation based on slot data in pdr-web is correct.
I assume the /statistics endpoint would only be used for predictoor statistics and not for pairs.

thank you for the feedback, I will fix it asap and update the PR

tests are added now, I guess ready to review


When the loader is Quilt, certain Dependencies are not need prompted.

Example:
Fabric Kotlin Language -> Quilted Kotlin Library
Fabric API -> Quilt Standard Library

Duplicate of https://github.com/packwiz/packwiz/issues/173


Write Readme based on new template

Provide a thorough Readme file using the new template attached below.
Blank_readme.md

@birchamp Here is the Readme file link https://github.com/unfoldingWord-box3/gateway-edit-POC/blob/master/README.md create by us using the new template attached


degree interpolation patch

Patch to the interpolation function making sure that mlg respects degree/radian based interpolation.
A new test was added to test_common.py to support.
With the additional lines on test_common:
fig = plt.figure(figsize=(5,5))
plt.scatter(res_orig.flatten(), res_new.flatten())
plt.xlabel('RG')
plt.ylabel('MLG')

We see the following image with the previous interpolation:

With the revision:

Speed tests show minor performance loss (10%), but still an order of magnitude improvement from rg.  Some performance degradation is expected given the dimensionality increase.
@davidraythompson - ready for your review.

Excellent, thank you @pgbrodrick!

Looks good to me.


Release v1.2.7

test: in index.js, unref the timers so the test suite exits
chore: bump dep versions

Checklist:

[x] docs updated
[X] tests updated
[x] Changes.md updated

This fixes the issue with the hanging tests. When this merges, the test suite will run and assuming it completes and passes, the release will be automatically published to NPM.

Hey - just wanted to say thank you and sorry for causing a mess with the earlier release.  Thanks for getting a new release out quickly, it's much appreciated.

You're most welcome, I'm sorry to have created the MX lookup issue in the first place.


Implicitly named volumes created by the WithDataVolume() method can collide across AppHost projects with the same name

The various WithDataVolume methods create a container volume that's implicitly named based on the App Host project name and resource name, e.g. if the App Host project is named "TestShop.AppHost" and the resource the method is called on is named "postgres", the implicit volume name will be "TestShop.AppHost-postgres-data".
This can lead to collisions of these implicit volume names when the App Host project is not named uniquely between different solutions. I'm seeing more customer solutions where the App Host project is simply named "AppHost". If there are resources named simply such as "postgres" across those App Host projects, their implicit data volume names will collide.
This issue can be worked around currently by the developer by passing a custom volume name to the WithDataVolume method, but then it's the responsibility of the developer to ensure volume names don't clash between any container resource with a volume (or indeed any other non-Aspire created volume).
We should consider updating the implicit volume naming logic to include a hash of the App Host project path, or some other deterministic, stable value derived from the App Host project. Note this would be a breaking behavior change although we could consider quirking it (i.e. allowing the user to specify what implicit volume naming strategy is used) or some other mitigation.

Consider also using the type of resource https://github.com/dotnet/aspire/issues/3858


fix event slug url matching

See #113 for details :)
Django does not seem to provide an easy way to match slugs within URLs. The internet recommends to just use an regex for that. So I did. If you know a smarter way, just hit me up and I'll change this around.
The diff is kind of big, because I removed all the duplicate slug-matching from the URLs. This way I only had the replace the regex in three places.

Imports are incorrectly sorted.

I really need a commit hook for that.

The failed pylama tests seem to be in setup.py, which is not touched by this PR.

Hmm, this PR allows dashes, but does not include dots.
How about adding a SLUG_CHARS = 'a-zA-Z0-9.-' to events.models.event, and using it both in the urls.pys and in the RegexValidator on an event's slug field?

Sure, will do. :)

@rixx please take another look :)

Thank you!

42 open issues in the tracker, 42 open issues.
Assign one to me and merge it around, 41 open issues in the tracker! 🎶


Missing Content-Type in header

I noticed that going to https://obsidian.systems in Lynx the HTML was displayed as plain text.

I don't think this is an obelisk issue. Running the skeleton app in ob run gives me:
curl -I http://localhost:8000/
HTTP/1.1 200 OK
Date: Tue, 26 Nov 2019 02:21:57 GMT
Server: Warp/3.2.26
Content-Type: text/html; charset=utf-8

Most likely it's actually the nginx configuration on obsidian.systems that is incorrect.

Closing as it is not an issue. If you don't think that's the case, feel free to reopen.


[BUG] KoP cannot support a FETCH request with many partitions

Describe the bug
When I run performance tests on a topic with 100 partitions, the topic will be not available quickly. What's worse is the whole KoP cluster will be broken because in this occasion, no bookie will be available. So even a new topic was created after that, it would still be unavailable because Not enough non-faulty bookies available.

15:07:19.134 [BookKeeperClientWorker-OrderedExecutor-0-0] WARN  org.apache.bookkeeper.client.PendingAddOp - Failed to write entry (177, 15): Bookie operation timeout
15:07:19.143 [BookKeeperClientWorker-OrderedExecutor-0-0] WARN  org.apache.bookkeeper.client.RackawareEnsemblePlacementPolicyImpl - Failed to find 1 bookies : excludeBookies [Bookie:<IP_ADDRESS>:3181, Bookie:<IP_ADDRESS>:3181, Bookie:<IP_ADDRESS>:3181], allBookies [Bookie:<IP_ADDRESS>:3181, Bookie:<IP_ADDRESS>:3181, Bookie:<IP_ADDRESS>:3181].
15:07:19.143 [BookKeeperClientWorker-OrderedExecutor-0-0] WARN  org.apache.bookkeeper.client.RackawareEnsemblePlacementPolicyImpl - Failed to choose a bookie: excluded [Bookie:<IP_ADDRESS>:3181, Bookie:<IP_ADDRESS>:3181, Bookie:<IP_ADDRESS>:3181], fallback to choose bookie randomly from the cluster.
...
15:07:19.143 [BookKeeperClientWorker-OrderedExecutor-0-0] ERROR org.apache.bookkeeper.client.MetadataUpdateLoop - UpdateLoop(ledgerId=177,loopId=4ef321e8) Exception updating
1828 org.apache.bookkeeper.client.BKException$BKNotEnoughBookiesException: Not enough non-faulty bookies available

The root cause is Bookie operation timeout. It seems to lead to the result that all bookies are excluded.
After that, producer might still be enable to write some messages, but there could be a possibility that corrupted message could be written to BK, see https://github.com/streamnative/kop/issues/442 for reference. And then a direct memory leak will happen as well. https://github.com/streamnative/kop/pull/542 is to handle this corrupted messages.
When there's no connected consumer, this case won't happen.
To Reproduce
Deploy a KoP cluster, create
Steps to reproduce the behavior:

Deploy a KoP cluster (maybe standalone is more easy to reproduce?)
Create a topic with 100 partitions
Run a producer and a consumer. Even if the produce rate is not so large (like 10 MB/s), the

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
Bookie operation timeout should not happen.
Additional context
As I debugged, it may be caused by MessageIdUtils#getPositionForOffset:
https://github.com/streamnative/kop/blob/f831d3777c82d0b9ee19365ed7ddd7545448185d/kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/utils/MessageIdUtils.java#L96-L103
The call stacks are
KafkaTopicConsumerManager#remove
  KafkaTopicConsumerManager#createCursorIfNotExists
    KafkaTopicConsumerManager#getCursorByOffset
      MessageIdUtils#getPositionForOffset

The getPositionForOffset is a synchronous method that blocks until a CompletableFuture is completed. However, it is called in a CompletableFuture's callback (thenAccept) when the ManagedCursor was not cached.
To verify the point, I added a trick fix to getPositionForOffset:
    public static PositionImpl getPositionForOffset(ManagedLedger managedLedger, Long offset) {
        if (offset == 0L) {
            return ((ManagedLedgerImpl) managedLedger).getFirstPosition();
        }
        // ...

Then I succeeded testing a 100 partitions topic for a few minutes. Though, if the produce rate was too high (like 800 MB/s), after about one minute, the bug could still happen. It may be caused by a namespace unload, then getPositionForOffset could call getPositionForOffset again while offset is not zero.
Here're the logs. There's no warn/error logs in bookie.log.
bookie.log
broker.log

FYI @dockerzhang @aloyszhang Could you reproduce this bug in your own environment?

When pub-sub with 200 partitions topic, and in catch up read case, the producer throw the following exception
[2021-06-03 17:02:35,972] WARN [Producer clientId=producer-1] Received invalid metadata error in produce request on partition chenhang_kop_perf_consume_v3-154 due to org.apache.kafka.common.errors.NetworkException: The server disconnected before a response was received.. Going to request metadata update now (org.apache.kafka.clients.producer.internals.Sender)
[2021-06-03 17:02:35,972] WARN [Producer clientId=producer-1] Got error produce response with correlation id 280884 on topic-partition chenhang_kop_perf_consume_v3-3, retrying<PHONE_NUMBER> attempts left). Error: NETWORK_EXCEPTION (org.apache.kafka.clients.producer.internals.Sender)

in broker log, it creats a lot of non-durable cursor
pened new cursor: NonDurableCursorImpl{ledger=public/default/persistent/chenhang_kop_perf_consume_v3-partition-160, ackPos=1515:22839, readPos=1515:22840}
17:03:04.763 [pulsar-io-4-23] INFO  org.apache.bookkeeper.mledger.impl.NonDurableCursorImpl - [public/default/persistent/chenhang_kop_perf_consume_v3-partition-135] Created non-durable cursor read-position=1514:22840 mark-delete-position=1514:22839
17:03:04.763 [pulsar-io-4-23] INFO  org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl - [public/default/persistent/chenhang_kop_perf_consume_v3-partition-135] Opened new cursor: NonDurableCursorImpl{ledger=public/default/persistent/chenhang_kop_perf_consume_v3-partition-135, ackPos=1514:22839, readPos=1514:22840}
17:03:04.796 [pulsar-io-4-23] INFO  org.apache.bookkeeper.mledger.impl.NonDurableCursorImpl - [public/default/persistent/chenhang_kop_perf_consume_v3-partition-110] Created non-durable cursor read-position=1379:22745 mark-delete-position=1379:22744
17:03:04.796 [pulsar-io-4-23] INFO  org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl - [public/default/persistent/chenhang_kop_perf_consume_v3-partition-110] Opened new cursor: NonDurableCursorImpl{ledger=public/default/persistent/chenhang_kop_perf_consume_v3-partition-110, ackPos=1379:22744, readPos=1379:22745}
17:03:04.814 [pulsar-io-4-23] INFO  org.apache.bookkeeper.mledger.impl.NonDurableCursorImpl - [public/default/persistent/chenhang_kop_perf_consume_v3-partition-176] Created non-durable cursor read-position=1422:22715 mark-delete-position=1422:22714

and with bookie timeout exception
17:02:36.846 [BookKeeperClientScheduler-OrderedScheduler-0-0] INFO  org.apache.bookkeeper.proto.PerChannelBookieClient - Timed-out 7 operations to channel [id: 0x5197bff7, L:/xxx:48434 - R:xxx/xxx:3581] for xxx:3581
17:02:36.846 [BookKeeperClientWorker-OrderedExecutor-0-0] WARN  org.apache.bookkeeper.client.PendingAddOp - Failed to write entry (1566, 88495): Bookie operation timeout
17:02:36.848 [BookKeeperClientWorker-OrderedExecutor-0-0] WARN  org.apache.bookkeeper.client.RackawareEnsemblePlacementPolicyImpl - Failed to choose a bookie from /default-region/default-rack : excluded [<Bookie:xxx:3581>, <Bookie:xxx:3581>], fallback to choose bookie randomly from the cluster.
17:02:36.848 [BookKeeperClientWorker-OrderedExecutor-0-0] WARN  org.apache.bookkeeper.client.RackawareEnsem

It can be reproduced in a KoP standalone.

Create a topic with 100 partitions (here we use Kafka 2.7.1 because Kafka 2.0.0's admin tool must access ZK to read available brokers)
./bin/kafka-topics.sh --bootstrap-server localhost:9092 --create --topic my-topic --partitions 100 --replication-factor 1

Start a producer to produce messages in terminal 1
./bin/kafka-producer-perf-test.sh --topic my-topic --num-records 10000000 --throughput 5000 --record-size 1024 --topic my-topic --producer-props bootstrap.servers=localhost:9092

The produce rate is about 4.88 MB/s.

Start a consumer to consume messages
./bin/kafka-consumer-perf-test.sh --bootstrap-server localhost:9092 --group my-group --topic my-topic --messages 1000000

Then the consumer cannot consume any message, the output is:

start.time, end.time, data.consumed.in.MB, MB.sec, data.consumed.in.nMsg, nMsg.sec, rebalance.time.ms, fetch.time.ms, fetch.MB.sec, fetch.nMsg.sec
WARNING: Exiting before consuming the expected number of messages: timeout (10000 ms) exceeded. You can use the --timeout option to increase the timeout.
2021-06-08 17:24:29:663, 2021-06-08 17:24:39:783, 0.0000, 0.0000, 0, 0.0000,<PHONE_NUMBER>108, -1623144262988, -0.0000, -0.0000

Soon the producer cannot produce messages, there're a lot of logs like:

[2021-06-08 17:25:04,020] WARN [Producer clientId=producer-1] Got error produce response with correlation id 70600 on topic-partition my-topic-70, retrying<PHONE_NUMBER> attempts left). Error: NETWORK_EXCEPTION (org.apache.kafka.clients.producer.internals.Sender)
[2021-06-08 17:25:04,020] WARN [Producer clientId=producer-1] Received invalid metadata error in produce request on partition my-topic-70 due to org.apache.kafka.common.errors.NetworkException: The server disconnected before a response was received.. Going to request metadata update now (org.apache.kafka.clients.producer.internals.Sender)

From the KoP's logs, we can see:

17:25:04.772 [BookKeeperClientWorker-OrderedExecutor-0-0] WARN org.apache.bookkeeper.client.PendingAddOp - Failed to write entry (94, 715): Bookie operation timeout
17:25:04.779 [BookKeeperClientWorker-OrderedExecutor-0-0] WARN org.apache.bookkeeper.client.RackawareEnsemblePlacementPolicyImpl - Failed to find 1 bookies : excludeBookies [Bookie:<IP_ADDRESS>:3181], allBookies [Bookie:<IP_ADDRESS>:3181].


Note about asking for valid and unwrapped JSON

Hi,
This is a small edit to include a hint in a prompt-engineering.adoc guide for devs to ask for a valid, unwrapped JSON when working with DTO classes.
The Background
I was working with the following AI service:
@ApplicationScoped
@RegisterAiService
public interface Translator {

	@SystemMessage("""
			You are a professional translator.
			You translate provided text lines from a source language to a target language.

			Objective: Translate provided text lines from {sourceLang} to {targetLang}.
		""")
	@Timeout(value = 2, unit = MINUTES)
	Translation translate(String sourceLang, String targetLang, @UserMessage String texts);

	public static @Data class Translation {
		private List<String> translatedTextLines;
	}
}

To my surprise, it didn't work as intended and I was getting HTTP 500 when requesting my endpoint.
In the requests log I found the JSON requirement appended automatically by LangChain4j to my prompt:
You must answer strictly in the following JSON format: {\n\"translatedTextLines\": (type: array of string),\n}

However, the GPT-4 model in Azure was not kind enough to understand that it would be the JSON parser that consumes its output, and got me a markdown.
The Problem
HTTP 500 error was caused by an exception from JsonParser.
Caused by: com.fasterxml.jackson.core.JsonParseException: Unexpected character ('`' (code 96)): expected a valid value (JSON String, Number, Array, Object or token 'null', 'true' or 'false')
 at [Source: (String)"```json
{
"translatedTextLines": [
"Lithuania, my homeland! You are like health;",
"How much you must be valued, will only discover,"
]
}
```"; line: 1, column: 2]
	at com.fasterxml.jackson.core.JsonParser._constructError(JsonParser.java:2477)

It failed because JSON was wrapped in the markdown the parser was unable to handle:

Not only that. When I modified the prompt and asked for a plain text I got an invalid JSON with additional unwanted commas :D
{
"translatedTextLines": [
"Lithuania, my homeland! You are like health;",
"How much you must be valued, will only discover,", <--- HERE
]
}

I fixed these problems by adding two more lines in the system message, one to get valid JSON and a second one to get a plain text:
You must respond in a valid JSON format.
You must not wrap JSON response in backticks, markdown, or in any other way, but return it as plain text.

Since I spent some time debugging this issue, I decided to include this in the prompt-engineering.adoc for the next generations to come.
Just FYI, the LangChains4j is decorating the prompt by adding JSON conversion requirement here:
https://github.com/langchain4j/langchain4j/blob/f17f8349ac3597f9804bfe835554e4e618b15fa8/langchain4j/src/main/java/dev/langchain4j/service/ServiceOutputParser.java#L118
I was thinking if I should create a separate PR against the LangChains4j but I was afraid to mess on the low-level prompts there and accidentally break the JSON prompting compatibility.
If one is interested, I thought about change their prompt from:
return "\nYou must answer strictly in the following JSON format: " + jsonStructure(returnType);

To:
return "\nYou must answer with valid JSON strictly in the following format: " + jsonStructure(returnType);

Thanks for this!
I would like to have the opinion of @langchain4j on this one

Hi @sarxos!
Current implementation with this hardcoded prompt is ugly and unreliable, it is an outdated way to get JSON from the model, at least for OpenAI. What we should use instead is json mode or functions/tools, if the model supports it. Azure OpenAI support both, so the easiest would be to just enable json mode when creating an AzureOpenAiChatModel. Unfortunately there is no way to enable it in the current langchain4j api (hovewer it is possible in OpenAiChatModel.responseFormat), we should add it both to quarkus-langchain4j and langchain4j. Once you enable json mode, LLM will be forced to return you a valid json and your problem will be solved.

Hi @geoand and @langchain4j,
Thank you for your fast response.
After a bit of consideration and before I read your answers I already did a langchain4j PR https://github.com/langchain4j/langchain4j/pull/598 to address the problem with what we have in the API right now (not JSON mode). I suppose it can work as a temporary workaround until a JSON mode is well supported.

Ah, it's worth to note :)
The pure gpt-4 in Azure did fix the JSON without additional instructions. The *-turbo models were the problematic ones to return markdown and invalid JSON, both variants 4 and 3.5.


Client request for 4.8 does not match server version 4.2.2

I get this error message Client request for 4.8 does not match server version 4.2.2 when setting up an app with the deploy button and going to https://YOURAPPNAME.herokuapp.com/ghost.

Hi! Actually there is a problem with 4.8.X so I changed the Ghost version for now. You can now deploy the new Ghost instance on Heroku.


ci: support @typescript-eslint/no-inferrable-types

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows Conventional Commits
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Refactoring
[ ] Code style update
[x] Build or CI related changes
[ ] Documentation content changes

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@vladimirpotekhin please, review me)


Accessing this.params outside router

I've split my routes into separate files, however I cannot seem to access the params that way. I'm receiving the error Error: get '/foo/:id': 'middleware' must be a function, not 'undefined'. What am I doing wrong?
app.js
var koa = require('koa');
var router = require('koa-router')();

var app = koa();

var foo = require('./routes/foo.js');

router.get('/foo/:id', foo.specific);

app.use(router.routes());
app.use(router.allowedMethods());

if (!module.parent) {
  app.listen(8080);
}

routes/foo.js
exports.specfic = function *(id) {
  this.body = id;
}

Could be that you exported specfic and you are using specific ? (Typo)

Made a mistake while dropping my code in here, sorry about that. I fixed the typo, but the actual error still persisted for some reason.
Decided to recode the part and use this.params instead of the function parameter, and heck, it worked. Still don't know what I did wrong the first time, but I'm glad it works.
Thanks for your contribution!


Fixed Header and Footer on tables

I'm submitting a ...  (check one with "x")
[ ] bug report => search github for a similar issue or PR before submitting
[x] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior
I want to achieve something like this - https://datatables.net/extensions/fixedheader/examples/options/header_footer.html Having the header and footer a absolute position. I tried to do it with CSS and ngx-datatable is not responding to window events. Please suggest if there any way we can achieve as natively with the table.
Expected behavior
https://datatables.net/extensions/fixedheader/examples/options/header_footer.html - Having header and footer stick to as in the link mentioned above.
What is the motivation / use case for changing the behavior?
Sometimes we need to achieve a way for reporting ex. Financial report, Product report (eCommerce). Think you are going to deal with too much data and we implement the server side for getting the results, so its very important to see the things in the summary at the footer. If its fixed then this leads to rich user experience, I am sure everyone would be looking for this thing as it's been a part of many popular plugins.
Please tell us about your environment:
Angular6.x, MAC.

Table version:
13.0.1

Angular version:
6.x

any update on this?

Did anyone find a solution for this issue?

any updates?

any updates?

No updates so far.
just apply a fix height to the table and make the vertical scroll true.


Bzip2 Issue with Nvidia Source Tarball

The Nvidia provided source file located at the following link cannot be decompressed with bzip2 1.0.6 provided by the OE Layer:
https://devtalk.nvidia.com/default/topic/1056301/b/t/post/5355418/
The issue seems to be fixed by upgrading bzip2 to the latest version:
https://www.sourceware.org/bzip2/downloads.html
This issue is detailed in the following posts:
https://devtalk.nvidia.com/default/topic/1056301/b/t/post/5355418/
https://devtalk.nvidia.com/default/topic/1056381/jetson-agx-xavier/jetpack-4-2-xavier-install-failed/1

It's actually using your build host's version of bzip2, but yeah, I had the same problem over the weekend.  I worked around it by installing lbzip2 on my host (Ubunut, so sudo apt install lbzip2), then setting up my PATH so a bzip2 symlink pointing at /usr/bin/lbzip2 would come first.

Thanks.


Error when connecting to mailchimp

It says that the oauth failed, but if clicking the "connect with mailchimp" button again, it just works.

Could you please try again? I can't reproduce (neither staging nor production).

I cannot, since I don't know how to disconnect my mailchimp account :(

If you use incognito mode button will show up.

Nope, the button is there, but the account is already connected so I don't have to do the auth process.

You must do it in Mailchimp: user (top right) --> account --> extras --> api keys, and there press "X" at CartoDB row.

How can we change that icon?

Ok, I couldn't replicate.


Asset lib is unable to download zips from Github releases

Operating system or device - Godot version:
2..1.0
Issue description (what happened, and what was expected):
I have one repository with all my plugins. When I want to make a release I'm zipping them, creating new github release and upload those zips to release. The problem is that Godot asset store for some reason is unable to download those zips, I got 403 code:

Zip links comes from here:
https://github.com/kubecz3k/KivanoGodotPlugins/releases/tag/InitialRelease

@bojidar-bg could you take a look at this?

I'll be HDD-less until Monday, can't have a look until then, sorry

Haven't experienced this recently.


Load Balancer support

This is missing right now right?

Yup. Would happily accept a PR, if not I'll try to take a look this weekend.


npm package module version conflict; two scripts clauses

The npm package is broken, and gives the error
"Error: The module '/srv/clara/current/hub/node_modules/waitpid2/lib/binding/waitpid.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 48. This version of Node.js requires
NODE_MODULE_VERSION 57. Please try re-compiling or re-installing
"
We can fix this by either going yarn run install --update-binary in node_modules/waitpid2, or by installing from source by using "waitpid2": "git://github.com/joshiggins/node-waitpid2.git#2270e88" in our package.json
I have no idea why your npm binary is broken.   But having two "scripts" sections in your package.json is an obvious issue and may or may not be related.   I'm not sure which is the right one.

Thanks for the pull request :+1:
I do not think this affects behaviour - it was defined twice but the second definition seems to take precedent.
Duplicate keys in JSON is not technically invalid, but depends how you deserialise it.
In any case, it is better to be explicit which script is correct.


Heatzy Onyx

Hello,
The Onyx radiator is currently not compatible with the project.
I have two Heatzy Onxy radiators and am willing to assist with testing or any other non-coding tasks.
I do not have coding skills.
config_entry-heatzy-64670c2d97037e2f2f296aa0671c48f0.json.txt
The data appears to be coming through, but the integration is not recognizing it.
product_key": "bb10d064f8de409db633b750faa22a52"
Here is what is currently being sent to Home Assistant.

After analyzing the file, I think they have the same characteristics as the Glow model.
I just added the key in version 5.8.7
Please come back to me

Parfait :)

Thanks !

Hello,
sur la version 5.9 plus de climate sensor


WIP: get rid of employee_doctors

https://github.com/edenlabllc/ehealth.api/issues/739

Changes Unknown when pulling 241ae35bd9667865e691ded249ddc69ee7990013 on drop_employee_doctor#739 into ** on master**.

Changes Unknown when pulling d57eeba1e1596366327768bfae7314643f7ce25f on drop_employee_doctor#739 into ** on master**.


Add basic test for TargetManager.targetSet

Verify that if the configs change, target groups are cleaned out on TargetManager.reload (rather than having old ones linger around, even if they are no longer present in the configs).
This covers the bug fixed in #1907 -- I verified that by checking out source from before that commit.
This is a start on #1906
@beorn7 @fabxc

Thanks! I added a few comments.

Thank you! 👍


Implement @FailWith401 annotation

When an unlogged user tries to call a query with @Logged annotation, he receives a "Cannot query field \"foo\" on type \"Query\"." error.
Could be great if he receives a 401 response instead.
Temporary solution : @FailWith(null) (thanks @moufmouf)

I am probably going to make error throwing the default behaviour in GraphQLite 4.
Ideally, we should have a GraphQL error AND a HTTP 401. Not sure if I can do that though...

#67 generates a default error for @Logged and @Right fields now.
See the updated documentation here: https://graphqlite.thecodingmachine.io/docs/authentication_authorization

Note: the HTTP error code must be triggered by the middleware so this is not directly related to GraphQLite but to the middlewares / bundles used.
See: https://github.com/APIs-guru/graphql-over-http#status-codes

How can I use this @looged and @right in my code?
I added the @FailWith and I get null for type, but how can I control the logges in via Symfony?
Some config I miss?

Hey @crirus ,
It really depends on how you installed GraphQLite. If you use Symfony and the Symfony bundle, it should work out of the box. Same thing with Laravel. If you are using your own framework, you must implement 2 interfaces (as described here: https://graphqlite.thecodingmachine.io/docs/next/authentication_authorization#connecting-graphqlite-to-your-frameworks-security-module)
Then, you must register those 2 classes using
// Configure an authentication service (to resolve the @Logged annotations).
$factory->setAuthenticationService(new VoidAuthenticationService());
// Configure an authorization service (to resolve the @Right annotations).
$factory->setAuthorizationService(new VoidAuthorizationService());

See: https://graphqlite.thecodingmachine.io/docs/next/other-frameworks#integration

This is now fixed. New Security annotation allows in depth control of the behaviour of login:
https://graphqlite.thecodingmachine.io/docs/next/fine-grained-security


Add LP breakdown for stable swaps & Ferro

@sircryptomaxi Can you add documentation links in the address book additions?


Are the given pretrained models derived from 'end2end' training or 'end2end + retrain' training?

Are the pretrained models: cfp_res50_end2end and ijba_res18_end2end- just trained end2end or is the DREAM block retrained after end2end training?

The novelty of the paper lies in the fact that the DREAM block is retrained on profile-frontal face pairs for pose robust face recognition. Is there any specific reason why you have not provided the retrained model and if possible can you provide it as it would be very helpful for a college project I am working on?
Thanks!

@penincillin The given models all come from end2end training.But you said "The strategy ‘end2end+retrain’ gives the best performance over all." So can you provide the retrained model or tell me how to retrain the DREAM block after end2end training? I can't find retrain code in your public code.Thank you very much!


Allow removing user that uploaded files

Fix #5322

Please remark https://github.com/concrete5/concrete5/issues/5324

We've also had problems during updating sites from <IP_ADDRESS> to 8.x in other tables like FileAttributeValues vs AttributeValues. Where after the update the first table still contains rows with foreign keys to none existing rows in the later. Is that fixed by refreshing entities, or does that halt the update process?

@Ruud-Zuiderlicht I don't know. I'd file another issue for this

Only thing I notice is that I'm pretty sure we should have one migration per pull request instead of modifying the latest migration Otherwise this change won't be applied to sites who are using develop

I was going to suggest the exact opposite, merging all the migrations since 8.1 into just one migration... xD
Why? For instance, refreshEntities() is quite time consuming, and having more calls to it is useless...

@mlocati If it's a schema issue where you're not really impacting foreign keys you can simply update the one table $this->refreshEntities(['Concrete\Core\Entity\File\File']); from within the migration, and that will refresh just that one table.

Yeah, I think we ought to move this out to its own migration and see if we can just refresh the file entity.

Andrew, refreshing an entity in that way drops all foreign keys, which is a
major issue.
On Wed, Apr 12, 2017, 11:03 AM Andrew Embler<EMAIL_ADDRESS>wrote:
Yeah, I think we ought to move this out to its own migration and see if we
can just refresh the file entity.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/concrete5/concrete5/pull/5323#issuecomment-293605881,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAM-qXpYOi-5hnp8y4B_yO8pLIokTuigks5rvOddgaJpZM4M447z
.

Does it do it if all the tables with foreign keys are also included in the refresh?

Does it do it if all the tables with foreign keys are also included in the refresh?

With the code suggested by @Mnkras (and included in this PR) everything is working as expected.
Maybe passing to refreshEntities both Files and all its related entities could work (ie foreign keys are kept). The problem is calculating the related entities (and I guess the entities related to the related entities, and so on).

Even if you pass in the other entities you would have to recursively pass
in all their related entities recursively until you have all relations
which would just be refreshing everything anyway.
On Wed, Apr 12, 2017, 11:42 AM Michele Locati<EMAIL_ADDRESS>wrote:

Does it do it if all the tables with foreign keys are also included in the
refresh?
With the code suggested by @Mnkras https://github.com/Mnkras (and
included in this PR) everything is working as expected.
Maybe passing to refreshEntities both Files and all its related entities
could work (ie foreign keys are kept). The problem is calculating the
related entities (and I guess the entities related to the related entities,
and so on).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/concrete5/concrete5/pull/5323#issuecomment-293619831,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAM-qRoq617dR7KxOgGTpvOtAR4OHH-nks5rvPDNgaJpZM4M447z
.

Even if you pass in the other entities you would have to recursively pass
in all their related entities recursively until you have all relations
which would just be refreshing everything anyway.

Indeed... It's a rephrasing of what I wrote above, but in English (mine was only kind of English :wink:)

PS: BTW I moved the migration to its own class

@mlocati do we need this on the inverse relationship as well? It looks like we currently get an error deleting files that were uploaded using an express form

@korvinszanto I don't think so. Could you check directly the DBAL and see what you have for the on delete event of the foreign key?

I have a pull request open for that issue
On Wed, Apr 12, 2017, 4:39 PM Michele Locati<EMAIL_ADDRESS>wrote:

@korvinszanto https://github.com/korvinszanto I don't think so. Could
you check directly the DBAL and see what you have for the on delete event
of the foreign key?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/concrete5/concrete5/pull/5323#issuecomment-293700680,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAM-qTWEUPcmj4yCScrRDSJwTMMKvMlfks5rvTZ6gaJpZM4M447z
.

This will still fail if there are files left in the database that point to a user with id 0. Is there some other migration that takes care of that issue?

@ahukkanen Somethink like https://github.com/concrete5/concrete5/pull/5533 should work.

Sorry to wake the dead, but I get a similar error related to Calendar Events.

We're on version 8.5.2. Has this already been fixed (ref please, if so), or should I log it as a new bug?


Misc changes for working capabilities and workflows

Updates

Register contract reader service as LOOPP gRPC server
Bug fixes to WASM workflow targets
Support pointer type for SortByTimestamp

Testing
$ go test -count=1 -v -run="^TestRunner_Run_GetWorkflowSpec" ./pkg/workflows/wasm
=== RUN   TestRunner_Run_GetWorkflowSpec
--- PASS: TestRunner_Run_GetWorkflowSpec (0.00s)
PASS
ok      github.com/smartcontractkit/chainlink-common/pkg/workflows/wasm 0.324s

Not able to merge this PR because of unverified commits. Created a new PR due to this


Mention Sublime Text plugin in INTEGRATIONS.md

https://github.com/akatopo/GithubEmoji for Sublime Text is very similar to the Atom autocomplete-emojis package that you're already linking to.

Done ba4fb65a976f2f055079e1bed9c0b8a09c5080ac

Done ba4fb65a976f2f055079e1bed9c0b8a09c5080ac


Give marketing team access to Volume signup data

https://report.volume.finance/user
dm for username and password


event queue for proxy invocations

Listening to evnts over WS is brittle, because we'd miss events in the case of downtime. substrate doesn't support an event queue yet. We might need to implement a PR to paritytech/substrate for this functionality.

implement ringbuffer for runtime events of configurable depth
add an RPC call to asynchronously pull events from the ringbuffer
error handling in case of buffer overrun

it might be a good idea to just spawn the offline worker for finalized blocks because we have no recovery for orphaned blocks. Moreover, we could send only one receipt per block, containing the merkle root of all request hashes

Stefie supplied this solution:
We can query a few blocks back
for(i=50;i>=0;i--){
    var hash = await api.rpc.chain.getBlockHash(i);
    var events = await api.query.system.events.at(hash);
    console.log(`\n #${i} Received ${events.length} events:`);

    // loop through the Vec<EventRecord>
    events.forEach((record) => {
        // extract the phase, event and the event types
        const { event, phase } = record;
        const types = event.typeDef;

        // show what we are busy with
        console.log(`\t${event.section}:${event.method}:: (phase=${phase.toString()})`);
        console.log(`\t\t${event.meta.documentation.toString()}`);

        // loop through each of the parameters, displaying the type and data
        event.data.forEach((data, index) => {
        console.log(`\t\t\t${types[index].type}: ${data.toString()}`);
        });
    });
 }

And JAco adds:
1.5-beta gives you .range
const allEvents = await api.query.system.events.range([<startHash>, <endHash?>]);

Now that we have the worker execute upon block import into the chain_relay, this is no longer needed, is it?


Send accept language header

LiveURL: https://kiwicomsmart-faq-mtgpyxgbww.now.sh

Conflicts resolved, cc @kantord & @git-toni


Driver throws ArrayIndexOutOfBoundsException from internal code

Driver version

12.4.1-jre11
12.2.0-jre11
11.2.1-jre11

SQL Server version
Microsoft SQL Server 2019 (RTM-CU16) (KB5011644) - 15.0.4223.1 (X64)
Client Operating System
Linux (Redhat)
JAVA/JVM version
JDK 11
Table schema
Irrelevant
Problem description
When trying to call a stored procedure that uses Table Valued Parameters, the driver throws exception with the following stack trace.
I was able to write less rows using the same code, but I cant pinpoint if the problem is due to data size, this happens when I was passing 100k++ rows using table valued params.
If there's something wrong with the input data, I expect driver to report something that's more actionable
Expected behavior
It should either not throw or provide clearer error message if there's indeed a user error.
Actual behavior
I get error from System.arraycopy, coming deep inside the driver.
Error message/stack trace
Caused by: java.lang.ArrayIndexOutOfBoundsException: arraycopy: last destination index 26 out of bounds for byte[17]
	at java.base/java.lang.System.arraycopy(Native Method)
	at com.microsoft.sqlserver.jdbc.TDSWriter.writeInternalTVPRowValues(IOBuffer.java:5118)
	at com.microsoft.sqlserver.jdbc.TDSWriter.writeTVPRows(IOBuffer.java:4995)
	at com.microsoft.sqlserver.jdbc.TDSWriter.writeTVP(IOBuffer.java:4908)
	at com.microsoft.sqlserver.jdbc.DTV$SendByRPCOp.execute(dtv.java:386)
	at com.microsoft.sqlserver.jdbc.DTV.executeOp(dtv.java:1657)
	at com.microsoft.sqlserver.jdbc.DTV.sendByRPC(dtv.java:1902)
	at com.microsoft.sqlserver.jdbc.Parameter.sendByRPC(Parameter.java:1189)
	at com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement.sendParamsByRPC(SQLServerPreparedStatement.java:757)
	at com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement.doPrepExec(SQLServerPreparedStatement.java:1158)
	at com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement.doExecutePreparedStatement(SQLServerPreparedStatement.java:643)
	at com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement$PrepStmtExecCmd.doExecute(SQLServerPreparedStatement.java:567)
	at com.microsoft.sqlserver.jdbc.TDSCommand.execute(IOBuffer.java:7675)
	at com.microsoft.sqlserver.jdbc.SQLServerConnection.executeCommand(SQLServerConnection.java:4137)
	at com.microsoft.sqlserver.jdbc.SQLServerStatement.executeCommand(SQLServerStatement.java:272)
	at com.microsoft.sqlserver.jdbc.SQLServerStatement.executeStatement(SQLServerStatement.java:246)
	at com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement.execute(SQLServerPreparedStatement.java:544)

Any other details that can be helpful
Add any other context about the problem here.
JDBC trace logs

Hi @qingwei91,
We'll look into this. While we're doing so, do you have repro code to reproduce the issue?

Hi @Jeffery-Wasty , I will try to make one
From what I observe, it happens when we have BigDecimal in Table Value Param, and its scale or precision are too large, I havent found the exact value though

Regarding BigDecimal, we've done work recently around this and are interested whether a previous version of the driver, 12.2 would work for you. This version makes changes to how precision and scaling are computed from BigDecimal values, but was reverted due to performance issues we believe may have been caused by the changes. If you are able to test this, I would be interested in seeing the results.

Hi @Jeffery-Wasty , thanks for the tip, it however does not fix my issue.
My colleague says that he seen this before and was managed to fix it by forcing scale to a lower number, I will try that out, and see if I can find a way to trigger it.

Hi, I manage to reproduce this by setting scale of BigDecimal to 40, so looks like there's some assumption around how big the number can, if that's indeed by design it would be nicer to throw a more friendly error if possible
I will try to create a minimal reprod, but it might take a while.

Max precision with BigDecimal is SQL Server is 38. Setting a scale of 40, means the precision would need to be at least 40, which would cause an issue. If that is indeed the source of the issue (can you try with scale 38, i.e BigDecimal(0,38)), then the error produced should reflect that, and that's something we'll look into updating.

Hi @Jeffery-Wasty , so 38 precision is indeed the maximum the problematic code can handle
https://github.com/microsoft/mssql-jdbc/blob/main/src/main/java/com/microsoft/sqlserver/jdbc/IOBuffer.java#L5115
The DDC.convertBigDecimalToBytes produce a byte array where the length of bytearray can exceed 19, which then cause the code to fail.
I believe SQL Server cant handle precision larger than 38, I guess that's where the hardcoded 17 bytes come from, the library should probably do some checking at a higher level, I am using SQLSErverDataTable, this region might be relevant: https://github.com/microsoft/mssql-jdbc/blob/main/src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDataTable.java#L232-L236

Our thoughts as well, this should have been caught earlier up, to enforce the 38 limit. We'll make those changes when we can and leave this issue open until we do.

Hi @qingwei91,
I'm still interested in whether you're able to provide a repro for this.
When I try to create a table with BigDecimal column with precision/scale larger than 40, the driver successfully prevents this and errors out. When I try this in SSMS, I'm prohibited from creating column values with precision or scale larger than 38. I'm not clear on the process you are using to utilize BigDecimal objects with precision/scale greater than 38. A repro would help in this regard.

Hi @Jeffery-Wasty , can you try this?
https://github.com/qingwei91/mssql-debug
the readme contains the db setup (with docker)
The main code will reproduce the problem


Correctly handle non-master default upstream branches

What's wrong
If an upstream repository chooses a default branch other than master, and the recipe doesn't specify that branch, cloning will fail.  Here is an example:
https://github.com/minad/marginalia/issues/24
(In this case, it so happens that without f89731c (melpa/melpa#7274), it would have worked, but this does not negate the fact that straight.el should be handling default branches correctly.)
Directions to reproduce
(straight-use-package marginalia) will result in the git clone failure shown in https://github.com/minad/marginalia/issues/24.  This is because straight-vc-git-default-branch results in a default branch choice of master, which results in straight.el attempting to clone with --branch master.
Suggested fix
If no branch is specified, simply omit the --branch option from the git clone command.  This will allow git clone to do the right thing.  In fact I'm not sure if there's any need for straight-vc-git-default-branch at all; ideally it could be scrapped, because git already knows how to figure out the default branch, and in general that should not be overridden.
Version information

Emacs version: 27.1
Operating system: openSUSE Tumbleweed

Is this occurring for you on the most recent version of the development branch?
#630 should've taken care of this.
The following test case builds fine and has marganila checked out at it's "main" branch on my system:
Test Case
(straight-bug-report
  :user-dir "straight-marginalia"
  :pre-bootstrap
  (setq straight-repository-branch "develop")
  :post-bootstrap
  (straight-use-package
   '(marginalia :post-build
                (message
                 (shell-command-to-string "git branch")))))

Test run at: 2020-12-13 23:29:51
system-type: gnu/linux
straight-version: prerelease (HEAD -> develop, origin/develop) 742bc66 2020-12-05
emacs-version: GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.23, cairo version 1.17.4) of 2020-12-05

Output
Bootstrapping straight.el...
Bootstrapping straight.el...done
Rebuilding all packages due to build cache schema change
Looking for gnu-elpa-mirror recipe → Cloning melpa...
Looking for gnu-elpa-mirror recipe → Cloning melpa...done
Looking for emacsmirror-mirror recipe → Cloning gnu-elpa-mirror...
Looking for emacsmirror-mirror recipe → Cloning gnu-elpa-mirror...done
Looking for emacsmirror-mirror recipe → Cloning el-get...
Looking for emacsmirror-mirror recipe → Cloning el-get...done
Looking for straight recipe → Cloning emacsmirror-mirror...
Looking for straight recipe → Cloning emacsmirror-mirror...done
Building straight...
Building straight...done

Test run with version: prerelease (HEAD -> develop, origin/develop) 949a0a7 2020-12-13
Cloning marginalia...
Cloning marginalia...done
Building marginalia...

* main

Building marginalia...done

Oh, nice!  I was only testing on master and was not aware of #543 / #630.  I can now confirm that this works on develop.  Thanks a lot!


Get rid of 'ok-to-merge'

https://github.com/kubernetes/kubernetes/issues/24228

@lavalamp @bgrant0607 @david-mcmahon @davidopp

Thanks. I agree we should eliminate ok-to-merge

LGTM
The milestone system is better. ok-to-merge was a hold over from 1.0 code freeze, IMO. Thanks.

LGTM


Bug: preflight_continue=true

Hi found the reason, why i had some probs with my request. With preflight_continue=true kong adds incoming header to its header. So one problem is:
(Reason: CORS-Header 'Access-Control-Allow-Origin' don't fit '*, *')
default-Value for Origin is *. My Server return also an * in its header for the request. Kong concatenate the headers to ,. This produce the already shown error above and no cross site request could pass kong. Any Ideas or could you fix this?

Do some Quick'n'Dirty fix. Just saw that you strip Linux Variables out of your URL Requests, so just add data with --data "variable.origin=$test", so your API delete my variable and add only "" + incoming * to the header file. That results in only one * in Origin and enable my cross site requests

Pinging @Nijikokun who built the plugin

I think the problem is that the 2 header got concatenated. Just ignore your defaults and add only the header behind kong.

It appears that this is due to how NGiNX treats the headers table, instead of overwriting a value, it adds another header with the same name and then concatenates them in the response.

@Nijikokun to set an output header that overrides the proxied header, you need to use header_filter_by_lua

@Nijikokun ping

I will look into this.

Related to #241

+1
We are having the same issue; When an upstream server has already CORS enables, the CORS plugin should deal with it.

+1 Same issue.  Please fix.

Some additional info on why some APIs have CORS enabled as well. For some APIs registered on Kong, the API has an admin interface, which is not using the gateway to request the API (with restricted access). The admin interface used - mainly for maintenance and some other management tasks - triggers CORS from the browser. When we disable CORS from the API and add CORS policy on Kong, that's ok for integrating consumers, but not for those 'admin interfaces' going directly to the API.

@thefosk  ^

I have been through the code, plugin intercept the request and update all the headers according to configuration. If preflight_continue is set then request would be upstreamed. Seems like upstream server also updating the Access-Control-Allow-Origin header , which in above case concatenating the * . Once solution can be the Upstream server should itself check if CORS headers already set. Another solution would be handling the modification of CORS headers in body_filter context if preflight_continue is set otherwise in access context.

Hello - I have pushed a PR (#1240) that seems to be fixing this problem. Could you try it and let me know if it effectively closes this issue? (@Bl4ckM @t1tcrucible @mjhlobdell)

Thank you @thefosk, we'll test it out and provide feedback

@t1tcrucible if you guys could test it within 24h, and it works, I will make sure to include it in the 0.8.2 release on Wednesday

hi @thefosk it works, sorry for the late reply - but already in release :-). Thank you very much!

Perfect - 0.8.2 has been just released.


Update tcl to version <IP_ADDRESS>.299124

Thank you for the contribution. It was merged directly as 259bb7d46a9d47493a99ea5f80a5d6733a86c6f1 to keep commit history cleaner. Your contribution is still credited to you.


Deno middleware breaks binary artefacts in Safari

https://github.com/BuilderIO/qwik/blob/784225efe11aa7c9cf8926ed8276cda96037188e/packages/qwik-city/middleware/deno/index.ts#L112
This breaks non-text files like images in Safari. Chrome works fine.
When I replace Deno.readTextFile locally with Deno.readFile Safari is happy again.
This is in Safari Version 16.5 (186<IP_ADDRESS>.4) on MacOs 13.4 (22F66) on an M1.

would u be up to make a PR?

@manucorporat here ya go


Feature request: key binding to open link at task

I honestly don't know if this is at all possible or not. But, in my workflow, many tasks have links that point to other websites (i.e. links to scientific articles that I have to read/reference). If at all possible, it would be great to have a keybind to open the first link on a task (Ctrl+Enter;Shift+Enter).
Great work! This is a game-changer!

Hey there! I'm actually not the maintainer for this project, but shift + enter typically does exactly what you're describing. I'd noticed that the shortcut has been broken for me for a few days, but I wasn't sure if it was just an issue on my machine, so I didn't submit a ticket for it. So if shift + enter on a task doesn't click the first link of that task for you, the shortcut is broken and we should let Michael know!

Actually, I just did a bit of digging and noticed that the follow() function works properly, it's just that a link is never found for the function to click. Instead, "Didn't find a link to click" just gets logged to the console. @mgsloan just wanted to call that out so this is easier to fix.

Thanks for noticing that this is broken!  I believe that Todoist changed how it does links.
Fixed in version 71


Full-width image

[ ] Target sections with full-width metadata and image link metadata

make these sections have image as background, and span full width

This should be done without creating a block, either fully in styles.css, or if need for javascript in scripts.js


feat(Server): method called with apply

When using node-soap to create a soap server, one could prefer to declare and instantiate a class and pass that as the service object (although the current documentation does instruct developers to use anonymous objects). This would allow us to create more complex service implementations by using methods, properties, etc.
However, right now, doing so results in little gain since methods are being called directly, without correctly setting the "this" variable.
The correction is very simple, though: the owning object for method is port; it's just a question of instead of invoking it directly, just call apply and pass the port as it's this variable.

Coverage increased (+0.002%) to 94.857% when pulling 7bd697ef1de66f6e8c1e59be92dbb9f516891cba on bruno-brant:feature/add-support-for-this into 699b9847e5f562686e685da0ff5b0a3aecc12076 on vpulim:master.


Bug

Hello
There is an issue when I use the jar file here :
http://search.maven.org/remotecontent?filepath=com/optimaize/languagedetector/language-detector/0.5/language-detector-0.5.jar
The code used is exactly the same on the readme part "How to Use"
The exception is caused by this line :
List languageProfiles = new LanguageProfileReader().readAllBuiltIn();
And the exception is :
Exception in thread "main" java.lang.NoSuchMethodError: com.google.common.base.Splitter.splitToList(Ljava/lang/CharSequence;)Ljava/util/List;
at com.optimaize.langdetect.i18n.LdLocale.fromString(LdLocale.java:77)
at com.optimaize.langdetect.profiles.BuiltInLanguages.(BuiltInLanguages.java:21)
at com.optimaize.langdetect.profiles.LanguageProfileReader.readAllBuiltIn(LanguageProfileReader.java:118)
Please note that with v0.4 jar I don't have the issue and everthing is working fine

Hello Bouki and thanks for reporting.
This is an issue with different versions of the Google Guava library.
They have added the splitToList() method "recently".
The Guava version that is currently used (0.5) is 16.0.1 and that was not changed since 2014-02-28. Version 0.4 was released on 2014-08-28. So no change here.
Guava has added the feature in version 15.0 see http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/base/Splitter.html#splitToList(java.lang.CharSequence)
Therefore, from this point, all looks fine. Is it possible that in your build another older-than-15.0 Guava version is chosen instead?

Hello
Thank you for your answer
You're right I had a conflict, you can close this


chore: bump version of kfp sdk

What changes were proposed in this pull request?
This PR removed kfp-tekton from dependencies and allows only Argo to be used as controller runtime engine.
How was this pull request tested?
To test this PR:

Run a make clean install at the root. This should install elyra-server and jupyter extensions.
Configure the run time by setting up the endpoint to a v2 pipelines server.
Run a pipeline against the runtime server.

Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

/lgtm
thanks :+1:


Absence of ref_model_name in the file which located in docs/source/best_of_n.mdx

System Info

from transformers import pipeline, AutoTokenizer
from trl import AutoModelForCausalLMWithValueHead
from trl.core import LengthSampler
from trl.extras import BestOfNSampler

ref_model = AutoModelForCausalLMWithValueHead.from_pretrained(ref_model_name)
reward_pipe = pipeline("sentiment-analysis", model=reward_model, device=device)
tokenizer = AutoTokenizer.from_pretrained(ref_model_name)
tokenizer.pad_token = tokenizer.eos_token

# callable that takes a list of raw text and returns a list of corresponding reward scores
def queries_to_scores(list_of_strings):
  return [output["score"] for output in reward_pipe(list_of_strings)]

best_of_n = BestOfNSampler(model, tokenizer, queries_to_scores, length_sampler=output_length_sampler)

I pasted the code from the open-source script. The link is https://github.com/huggingface/trl/blob/main/docs/source/best_of_n.mdx
could u define the ref_model_name in the script?
Information

[X] The official example scripts
[ ] My own modified scripts

Tasks

[X] An officially supported task in the examples folder
[ ] My own task or dataset (give details below)

Reproduction

from transformers import pipeline, AutoTokenizer
from trl import AutoModelForCausalLMWithValueHead
from trl.core import LengthSampler
from trl.extras import BestOfNSampler

ref_model = AutoModelForCausalLMWithValueHead.from_pretrained(ref_model_name)
reward_pipe = pipeline("sentiment-analysis", model=reward_model, device=device)
tokenizer = AutoTokenizer.from_pretrained(ref_model_name)
tokenizer.pad_token = tokenizer.eos_token

# callable that takes a list of raw text and returns a list of corresponding reward scores
def queries_to_scores(list_of_strings):
  return [output["score"] for output in reward_pipe(list_of_strings)]

best_of_n = BestOfNSampler(model, tokenizer, queries_to_scores, length_sampler=output_length_sampler)

outputs:
---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)
[<ipython-input-4-6cdab4e940d5>](https://u5o1j4ybk99-496ff2e9c6d22116-0-colab.googleusercontent.com/outputframe.html?vrz=colab_20241218-060117_RC00_707469454#) in <cell line: 6>()
      4 from trl.extras import BestOfNSampler
      5
----> 6 ref_model = AutoModelForCausalLMWithValueHead.from_pretrained(ref_model_name)
      7 reward_pipe = pipeline("sentiment-analysis", model=reward_model, device=device)
      8 tokenizer = AutoTokenizer.from_pretrained(ref_model_name)

NameError: name 'ref_model_name' is not defined

Expected behavior
Define the variable of ref_model_name, pls.
Checklist

[X] I have checked that my issue isn't already filed (see open issues)
[X] I have included my system information
[X] Any code provided is minimal, complete, and reproducible (more on MREs)
[X] Any code provided is properly formatted in code blocks, (no screenshot, more on code blocks)
[X] Any traceback provided is complete

@aivolcano There is a notebook that is related to this. The updated notebook is here: https://github.com/huggingface/trl/blob/main/examples/notebooks/best_of_n.ipynb

thank u so much


Combine develop service doc

Description
There are currently 3 versions of similar content, which I am trying to fix:

https://dcos.io/docs/1.9/development/
https://dcos.io/docs/1.8/development/
https://docs.mesosphere.com/1.9/usage/managing-services/developing-services/

Here's the JIRA:

https://jira.mesosphere.com/browse/DOCS-1745
[ ] TODO: Add to enterprise merge script.

Urgency

[ ] Blocker
[ ] High
[x] Medium

Requirements

Test all commands and procedures.
Build content locally and test for formatting/links.
Add redirects to dcos-website/redirect-files.
Change all affected versions (e.g. 1.7, 1.8, and 1.9).
See the contribution guidelines.

Add @cruhland from packaging team instead of me.

@joel-hamill did a first pass; some comments apply to both the 1.8 and 1.9 versions of a page, even if they're only on one.

@cruhland i have addressed your feedback.

@joel-hamill I searched for /universe in the diff, it turns out there are a bunch of links that point to the old version-1.x and version-2.x branches. Those should be updated to point to the version-3.x branch.

@cruhland fixed https://github.com/dcos/dcos-docs/pull/950/commits/dbe625721f5a5e8f155996d83c58c1b27642087f


Add voice commands around power on/off

FYI the power command will turn on the TCL Roku TV (only tested with ethernet not wifi as that is my current setup)

Add voice commands to "power off",  "power on", and "turn on" roku
Keep in mind on a device such as TCL Roku TV the power command, regardless of what phrased used, will toggle the power

If it's on it will turn off
If it's off it will turn on

Power on may only work if it's been powered off recently.  Getting mixed behavior of it working while I'm playing around with turning it on/off but then coming back later after leaving it off for a while and it not powering on.


.Net 4.0 support

Hi
Is there a chance to support ZeroFormatter for Net 4.0?
Maybe someone within the community has already done this?

+1 for this, unfortunately I can't use ZeroFormatter as it requires .NET 4.5.


Upgrade Langchain to ^0.2.0, Refactor Embeddings to Singleton, and Add Azure Key Checks

Upgrade langchain to ^0.2.0, use langchain client (ChatOpenAI) for semantic matcher
Refactor Embeddings class to singleton pattern
Add checks for Azure keys
Add prepare command to allow install from git

Great contribution!
I will take the time to merge it (unless you do before me) and make sure a release is properly triggered, as it's proven to be a bit buggy.
Thanks!

I don't have the permissions to merge it, so I'll leave it to you. Thanks :-)


Update upgrade-and-coexistence-of-skypeforbusiness-and-teams.md

Removed extra word

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@LanaChin PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


解释 Hugo 项目的构建流程

描述: 逐步解释从内容创作到生成静态网站的完整构建流程。
详细描述: 让贡献者了解如何通过修改内容和模板，最终生成可发布的静态网站文件。

Could you provide a more detailed description of this issue?
Maybe I did not understand what this issue ask me to do.

which folder should i put the md file in


Revisit display of controls in ID timeline view.

For example hide rather than disable controls that don't make sense in the ID timeline view such as ID-level filters, y-axis sorting, and y-axis grouping.

Staying with disabled controls, and controls have been re-ordered so that controls that affect both views are positioned first.

Still thinking we should move to hidden controls, as discussed.

Test notes:

Verify that all controls except the ID view, event highlighting, x-axis scale, and event type filter are hidden in the ID view.

Tested and confirmed that in the single Participant view, the only visible, default controls are Participant view, Event highlighting, and X-axis scale and the only Filter is Event Type.


Announcement of the discontinuation of the LSV2 protocol

Apologies if this enquiry is a little off-topic, but I suspect I've found the right specialists here.
I have been told that the LSV2 protocol has been discontinued and will no longer be available on newer CNCs in about 2-3 years.
The successor is the RemoTools protocol, but that seems to be a crappy Microsoft COM+ component.
Then there is an OPC UA server. It seems really intuitive, but it is only available for newer cnc. With this python opc ua toolkit I have already made first experiences in controlling a heidenhain CNC via OPC UA.
As far as I understood, I have two options:

build a separate connection for old and new controls respectively:
1a) old cnc = LSV2
2b) new cnc = OPC UA
write a Python wrapper for the RemoTools COM component and connect all controllers via it.

Does anyone have experience of using com components in python?
It seems incredibly complicated to me.
I am grateful for any tips.

Hi @CuriousCrook!
Personally I would go for your option 1. It might be a bit more work during implementation to get the same data via both protocols but probably still less of a hassle than option 2.
Another thing to consider is the OS you want your application to run on. If you want to support anything other than Windows, the COM solution won't work without something like wine which adds another layer of complexity. This was also the reason for me to focus on LSV2 since I needed a solution that can run on MacOS.
In the end I am also skeptical of the time frame for the final discontinuation of the LSV2 interface. The latest software version of the TNC7 still supports LSV2. The only "limitation" is the requirement to use a SSH tunnel for the connection. In earlier versions this was optional, now you have to change a machine parameter (see manual page 2318 under notes) to allow connections without SSH. I also think that there are too many applications like tool setters out there that only support LSV2 since it doesn't require a software option on the control. People would be very unhappy if the had to by a new tool setter because the bought a new machine.

I thing OPC UA on Heidenhein is not realy, there are a lot of changes in the past and all Heidenhain tools from TNCremo and all the OEM tools still work with LSV2
OPC UA needs for every connection one licence and the setup is mutch more complex, i think the consumer are not happy with it...


poser.pugx.org is down

I am constantly getting timeouts. Also https://downforeveryoneorjustme.com/poser.pugx.org confirms

We are so sorry ... we are working hard to improve the stability of the architecture!

Seems to work now. Thanks for great servce! Feel free to close unless it serves other purposes.


UIImage.base64

Nowadays we have an extension that initializes an UIImage from a base64 String, but we don't have a way to easily convert an UIImage to base64
I'm currently in a project so I don't have time to open the PR. Will do it tomorrow
extension UIImage {

    var base64: String {

        let data = UIImageJPEGRepresentation(self, 1.0)
        return data!.base64EncodedString()
    }
}

Just return UIImageJPEGRepresentation(self, 1.0).base64EncodedString(). The let is superflous.


FIX: typo on ssl documentation

remove double locak_pk key

You need to re-create the branch from 2.x, not 2.x-memory-leak. The diff shows some additions which are not okay.


Add option to generate all templates from a generator assembly

For example, t4plus assembly src\codegeneration\bin\debug\net7.0\codegeneration.dll
This runs all ICodeGenerationProvider instances from codegeneration.dll. If we need command-line options, add them to the command. (I can think of DryRun and Path)
The command will detect all code generation providers using reflection.

Implemented in vnext branch


update docker

What does this PR do?
updating NGC docker for some base image issues
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

Didn't know 21.05 was out already!

well, it is already June :P


Update Troubleshoot.md

The manifest schema is updated, so the docs should be. 😀
cc @denelon
Microsoft Reviewers: Open in CodeFlow

I guess you have missed my PR as you have so much work, so, I am mentioning you (@denelon) again. 🙂

@denelon


figure out why some embeds show the whole LBRY site vs just player

Takes you to lbry.tv instead of the content page: https://dryburgh.com/coronavirus/2020/11/carl-heneghan-coronavirus-masks-do-not-work/

Example:

This ended up being an issue with the --- encoding the user ended up with. Seems to work fine with referral URLs


Spark docs

Added a "Use with Spark" doc page to document Dataset.from_spark

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Bug or Issue

Do we call it an bug or issue tracker? Do we use /bugs/{id} or /issues/{id}?

The main function is bugs; issues (aka questions) may possibly be a part of it, but they're not the main purpose of it.
Bug tracker.

Depends on the projects size probably. For smaller orgs like @amphp, there will probably more feature requests than bug reports.

Feature requests are actually bugs about not-yet-working functionality (which isn't implemented). :-P

I don't agree with that. ;-) Bug is very specific about the type of issue, while issue is general and can be used for more than just bugs.


A viewing mode？

Thank you for creating this Web-App！
Is it possible to provide a viewing mode? To be able to show several days of the diary at the same time, rather than having to click on a specific date to see it.
It might be easier to review what I've written before.

Hi, thanks for the idea!
So you mean a pure viewing-mode without editing, right?
Something like "all entries of a week" next to each other? Or all entries of a month?
But the normal switching between the days is going so quickly... You could only speed this "viewing" up by merging/uniting those "entries of a week" into a single text. I'm not sure if this is worth it.
When we're like talking about all entries of a month, then this already makes more sense - then this might also a good way to export text.

Can we just consider the days when we wrote our diary without considering specific dates?
Then take the first two to three lines of each journal and display multiple journals on the same page.
Alternatively, an export method can be provided: all journals can be exported to the same txt file.
In fact, there is only one thing: this work is indeed very convenient when writing a diary, but it seems that the review is not continuous enough.

First of all: sorry for the late reply.
I'll keep this issue open and when I continue coding on DailyTxT (will take some more month), I'll reconsider a possible solution for your idea :)

Or as a starting point let the user chose "open in edit mode" or "open in view mode". I don't want to change something accidnetly just during browsing through my entries

Or as a starting point let the user chose "open in edit mode" or "open in view mode". I don't want to change something accidnetly just during browsing through my entries

Well, if there is something coming like your viewing mode, then this will be without editing anyway.

Alright, anyway, thanks for your work, as mentioned on Reddit there are not many good diary applications out there!

Hi,
I'm now finally coming back to coding at DailyTxT and to your request.
Your main problem was, that switch between days was too slow (non-continuous), right? You mentioned the "clicking" on a specific date.
I wanna ask you, if you know, that there is [ALT]+[ARROW] existing, to quickly navigate from day to day?
This feature is sadly not working on a mac (as I recently noticed) - but I'll find a solution for this.
If these shortcut-keys are not enough: I could consider to implement a pure viewing mode of all entries of a month. So you could switch from month to month instead of day to day.