[HOLD for payment 2023-05-03] [HOLD for payment 2023-04-27] [$1000] Long pressing any of the app download link on mweb Safari does not open the copy to clipboard menu

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login to any account
Open the App download links in the About section.
Long press on any of the link.

Expected result:
Copy to clipboard menu item should show up
Actual result:
Copy to clipboard menu item does not show up
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[ ] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.2.94-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43996225/229945424-70ebe365-259b-475f-9996-608b37561013.MP4
https://user-images.githubusercontent.com/43996225/229945458-0bfbae2f-30d0-41ad-a957-955a409df300.MP4
Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680564052842509
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~014fb329f5e82a7436
Upwork Job ID:<PHONE_NUMBER>751460864
Last Price Increase: 2023-04-05

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Hi I'm Agata from Callstack - expert contributor group - maybe we could help with this one?

Job added to Upwork: https://www.upwork.com/jobs/~014fb329f5e82a7436

Current assignee @abekkala is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

Current assignee @mountiny is eligible for the External assigner, not assigning anyone new.

Proposal
Please re-state the problem that we are trying to solve in this issue.
When the app download links are displayed, long-pressing one of the menu items should display the "Copy to clipboard" menu item expected in a custom context menu, but the menu item text is being highlighted instead.
What is the root cause of that problem?
The root component of the custom MenuItem component is a React Native Pressable, which is capturing the onPressIn and onPressOut events, causing the event handlers for the similarly named events in the parent PressableWithSecondaryInteraction component to be ignored.
What changes do you think we should make in order to solve the problem?
After some testing, it appears that MenuItem should be refactored to make use of a PressableWithSecondaryInteraction component as its root component. A PressableWithSecondaryInteraction is already based on the Pressable component, so this shouldn't be a breaking change.
However, this would require refactoring PressableWithSecondaryInteraction to set the style prop to make use of a style passed as a property if the inline prop is false, in order to maintain compatibility with other components or pages that are already making use of the PressableWithSecondaryInteraction component.
https://github.com/Expensify/App/blob/0d2d52eaa4f5ce91585be007645ad1d4e6a230df/src/components/PressableWithSecondaryInteraction/index.js#L57
The style property would be refactored like so:
style={this.props.inline ? styles.dInline : this.props.style}
MenuItem would also be refactored to accept the following props: onPressIn, onPressOut and onSecondaryInteraction.
What alternative solutions did you explore?
Attempted to make use of the stopPropagation() and event.nativeEvent.stopImmediatePropagation() methods for the event parameter with the onPressIn and onPressOut event handlers, but these calls did not work.

Proposal
Please re-state the problem that we are trying to solve in this issue.
When long-pressing on a menu item in the app download links, the custom context menu is not being displayed correctly. Instead of showing a "Copy to clipboard" option, the menu item text is being highlighted.
What is the root cause of that problem?
The app download links are part of an existing codebase that uses React Native. The MenuItem component, which is used to display the menu items, has a root component of Pressable, which is causing the issue.
What changes do you think we should make in order to solve the problem?

Proposed solution
Refactor the MenuItem component to use the PressableWithSecondaryInteraction component as its root component. The PressableWithSecondaryInteraction component is based on the Pressable component, but it also includes support for secondary interactions like long presses. By using this component as the root, we can ensure that the custom context menu is displayed correctly when long-pressing on a menu item.
Benefits
Refactoring the MenuItem component to use PressableWithSecondaryInteraction will provide the following benefits:
The custom context menu will be displayed correctly when long-pressing on a menu item.
The MenuItem component will be more consistent with other components in the app that use the PressableWithSecondaryInteraction component.
The solution should be relatively straightforward to implement and test.
Implementation steps
Modify the MenuItem component to use the PressableWithSecondaryInteraction component as its root component.
Add the onPressIn, onPressOut, and onSecondaryInteraction props to the MenuItem component.
Update the style prop in PressableWithSecondaryInteraction to make use of the inline prop if it is provided, or use the style prop if the inline is false.
Test the MenuItem component to ensure that the custom context menu is displayed correctly when long-pressing on a menu item.
Potential drawbacks
The proposed solution should not cause any significant performance issues or require a significant amount of development time. However, there may be some minor changes required in other parts of the app that use the MenuItem component, as they may need to be updated to include the new onPressIn, onPressOut, and onSecondaryInteraction props.
Overall, the proposed solution provides a straightforward and effective way to address the issue of the custom context menu not being displayed correctly.

@eVoloshchak please review the proposals once you get time!

@eVoloshchak, @abekkala, @mountiny Whoops! This issue is 2 days overdue. Let's get this updated quick!

@eVoloshchak, @abekkala, @mountiny Whoops! This issue is 2 days overdue. Let's get this updated quick!

Not overdue, reviewing proposals today

📣 @b1tjoy! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@akinwale's proposal is correct in identifying the root cause.
I think removing the PressableWithSecondaryInteraction here and refactoring MenuItem to use PressableWithSecondaryInteraction is a good approach, since it allows us to get rid of nested pressables.
However, it adds a bug in Safari, the whole screen is highlighted when you long press
https://user-images.githubusercontent.com/9059945/231171261-6efc4d84-0028-42e8-99b1-76e6c5b0b5d3.MP4
@ImBIOS, correct me if I'm wrong, but your proposal uses approach identical to @akinwale's proposal

However, it adds a bug in Safari, the whole screen is highlighted when you long press

@eVoloshchak This is not a bug. This is intended behaviour. The idea is to have a modal with a primary action displayed at the bottom. This primary action is what actually copies the link. You can test this in Android Chrome to confirm.

@eVoloshchak This is not a bug. This is intended behaviour. The idea is to have a modal with a primary action displayed at the bottom. This primary action is what actually copies the link. You can test this in Android Chrome to confirm.

I don't see the same issue on Android Chrome
https://user-images.githubusercontent.com/9059945/231173542-45a678d2-d9d3-4efa-b21c-9e1273f831fd.mp4

@eVoloshchak This is not a bug. This is intended behaviour. The idea is to have a modal with a primary action displayed at the bottom. This primary action is what actually copies the link. You can test this in Android Chrome to confirm.

I don't see the same issue on Android Chrome

Unless I'm missing something, I'm seeing the same behaviour. The modal background just appears to be darker in the iOS video. Or do you mean that the whole screen becomes highlighted before the long press effect is completed? I'm not seeing that as a bug, but I can find a solution for that.

@akinwale, notice the blue border around the screen on IOS

@akinwale, notice the blue border around the screen on IOS

Oh, I actually didn't notice that at all. Nothing fundamental has changed with the implementation, we're just changing where the events are being handled, so I'm guessing it's related to the selection feature.

@eVoloshchak Yes I think any menu item which is a link should have this behaviour.

Any good proposals or could we give this to Callstack to investigate? @eVoloshchak

@mountiny, there are a couple of good proposals, but both create one small issue that needs to be resolved. I think we might wait a little for @akinwale or @b1tjoy to update their proposals

@b1tjoy, good job on finding the offending PR, and thanks for the thorough explanation
I can still see the bug with screen being highlighted with blue border in Safari, but weirdly, only with a physical device, the simulator doesn't have this issue. ControlSelection.block() in onPressIn handler and ControlSelection.unblock() in onPressOut handler are present, but I can still reproduce this on a real device

Ah, that explains some of it. I am also not seeing it in the iOS simulator. I will try to test with a real device to see if I can reproduce.

@eVoloshchak I'm not seeing the blue outline on an iPhone 12 Pro Max running iOS 16.3.1. Video attached. What iOS version are you running?
For reference, this is what the code listing would look like for the affected pages / components.
AppDownloadLinks.js
Remove PressableWithSecondaryInteraction from the map and use the MenuItem as the top level element.
<MenuItem
    title={props.translate(item.translationKey)}
    icon={item.icon}
    iconRight={item.iconRight}
    onPress={() => item.action()}
    shouldShowRightIcon
    key={item.translationKey}
    onPressIn={() => props.isSmallScreenWidth && DeviceCapabilities.canUseTouchScreen() && ControlSelection.block()}
    onPressOut={() => ControlSelection.unblock()}
    onSecondaryInteraction={e => showPopover(e, item.link)}
    ref={el => popoverAnchor = el}
    onKeyDown={(event) => {
        event.target.blur();
    }}
/>

MenuItem.js
<PressableWithSecondaryInteraction
    onPress={(e) => {
        if (props.disabled) {
            return;
        }

        if (e && e.type === 'click') {
            e.currentTarget.blur();
        }

        props.onPress(e);
    }}
    onPressIn={props.onPressIn}
    onPressOut={props.onPressOut}
    onSecondaryInteraction={props.onSecondaryInteraction}
    // ...
</PressableWithSecondaryInteraction>

PressableWithSecondaryInteraction
<Pressable
    style={this.props.inline ? styles.dInline : this.props.style}
    // ...

https://user-images.githubusercontent.com/4160319/231193287-0be26e0a-3559-4206-8f58-65f6ff9f2445.mp4

@b1tjoy, good job on finding the offending PR, and thanks for the thorough explanation
I can still see the bug with screen being highlighted with blue border in Safari, but weirdly, only with a physical device, the simulator doesn't have this issue. ControlSelection.block() in onPressIn handler and ControlSelection.unblock() in onPressOut handler are present, but I can still reproduce this on a real device

Ah, that explains some of it. I am also not seeing it in the iOS simulator. I will try to test with a real device to see if I can reproduce.

@eVoloshchak I'm not seeing the blue outline on an iPhone 12 Pro Max running iOS 16.3.1. Video attached. What iOS version are you running?
For reference, this is what the code listing would look like for the affected pages / components.
AppDownloadLinks.js
Remove PressableWithSecondaryInteraction from the map and use the MenuItem as the top level element.
<MenuItem
    title={props.translate(item.translationKey)}
    icon={item.icon}
    iconRight={item.iconRight}
    onPress={() => item.action()}
    shouldShowRightIcon
    key={item.translationKey}
    onPressIn={() => props.isSmallScreenWidth && DeviceCapabilities.canUseTouchScreen() && ControlSelection.block()}
    onPressOut={() => ControlSelection.unblock()}
    onSecondaryInteraction={e => showPopover(e, item.link)}
    ref={el => popoverAnchor = el}
    onKeyDown={(event) => {
        event.target.blur();
    }}
/>

MenuItem.js
<PressableWithSecondaryInteraction
    onPress={(e) => {
        if (props.disabled) {
            return;
        }

        if (e && e.type === 'click') {
            e.currentTarget.blur();
        }

        props.onPress(e);
    }}
    onPressIn={props.onPressIn}
    onPressOut={props.onPressOut}
    onSecondaryInteraction={props.onSecondaryInteraction}
    // ...
</PressableWithSecondaryInteraction>

PressableWithSecondaryInteraction
<Pressable
    style={this.props.inline ? styles.dInline : this.props.style}
    // ...

https://user-images.githubusercontent.com/4160319/231193287-0be26e0a-3559-4206-8f58-65f6ff9f2445.mp4

@akinwale, I can still reproduce this using the code you've provided.
I've tested on iPhone SE running iOS 16.3.1

@akinwale, I can still reproduce this using the code you've provided. I've tested on iPhone SE running iOS 16.3.1

Weird. I've also tested on a 2020 iPhone SE running iOS 16.3.1 and I still don't see the behaviour. Can you check if you have Full Keyboard Access in Settings > Accessibility > Keyboards enabled? If you do, can you turn it off, restart your device and then test again? Thanks.

@eVoloshchak
Alternatively, could you try adding this CSS to index.js to see if it changes anything?
*:focus:not(.focus-visible) {
  outline: none;
}

@eVoloshchak Can you reproduce whole page highlight on Safari using this proposal #16946 (comment)? I test it on real device but works fine.

Yes, I was also able to reproduce this with your proposal

@akinwale, huh, I think I've found why we have different results.
The issue is present only if app links page was the first page you entered (if you navigated to settings/about), if you enter this page from another screen - it's not present.
Notice in the video below the issue starts appearing only after I refresh the page
https://user-images.githubusercontent.com/9059945/231214014-596a475d-7cae-4013-98c7-ed93cc47f3b2.MP4

@eVoloshchak This is the CSS pseudo selector affecting the output.
https://github.com/Expensify/App/blob/99292fc00d0c12817b5dde204156e6d100b662ec/web/index.html#L45-L48
I'm not sure what exactly it's meant for, but after commenting it out, the blue border doesn't show up any more upon refresh. We need to find a way to make the selector more restrictive.

I can also reproduce this on other screens, so this is a separate issue, I'll report it on slack.
Could you post an updated proposal so as per this comment

any menu item which is a link should have this behaviour.

I can also reproduce this on other screens, so this is a separate issue, I'll report it on slack.
Could you post an updated proposal so as per this comment

any menu item which is a link should have this behaviour.

Done.

Proposal
Updated

📣 @akinwale You have been assigned to this job by @mountiny!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

Thanks, assigned!

Applied to the Upwork job. Should have a PR ready within an hour.

@abekkala Noting this is eligible for the speed bonus.

@eVoloshchak Before this gets closed out, I just wanted to say thanks for the thorough review. As a relatively new contributor, I don't think I would've been able to independently identify the vibration bug during testing. It's been a great learning experience and I hope to gain more insight as I take on more tasks over time.

@akinwale, thanks for your message and for your kind words!
You did a great job on the code, and your fast response time made it easy for us to complete the task quickly.
It's awesome to have new contributors, looking forward to working with you on more tasks in the future.

⚠ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

PR was reverted and new PR is up

Reviewing label has been removed, please complete the "BugZero Checklist".

Payments to be made on 2023-04-26
Issue reported by: @mallenexpensify - no payout for you. 😆
Selected Proposal for fix: @akinwale  [$1000] + [$500 PR Bonus]
C+ Review: @eVoloshchak [$1000] + [$500 PR Bonus]
Timeline:
Apr 11 - @akinwale was assigned to this job
Apr 11 - PR merged #17310 - 50% BONUS 🎉

@akinwale and @eVoloshchak
I have hired you both in Upwork and sent contracts. The $500 bonus will be added when I pay out! 🎉

@akinwale and @eVoloshchak I have hired you both in Upwork and sent contracts. The $500 bonus will be added when I pay out on the 26th! 🎉

Accepted. Thanks!

@abekkala I think we need to slow down here, the PR was reverted so 26th is not correct date and technically it was regression, although hard to test for.
I have updated the labels, lets get the new PR merged soon, I think we dont have to cut for the regression here given how active and helpful @akinwale ahas been here and it was a test case we did not anticipate.
But we should wait for the payout once the PR actually hits production (not even at staging now).

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.2-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/17310

If no regressions arise, payment will be issued on 2023-04-27. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@abekkala] Determine if we should create a regression test for this bug.
[ ] [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@vitHoracek

But we should wait for the payout once the PR actually hits production (not even at staging now)

Correct, I don't make any payments until I know everything is done/correct! I check everything on the 27th to ensure everything has been done before sending any payments out
.

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.5-6 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/17639

If no regressions arise, payment will be issued on 2023-05-03. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@eVoloshchak] Determine if we should create a regression test for this bug.
[ ] [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@mountiny I'm not sure why the title updated the payment date twice but didn't replace the date.
Can the 4-27 date be removed and payout is actually 05-03 now?

I'm not sure why the title updated the payment date twice but didn't replace the date. Can the 4-27 date be removed and payout is actually 05-03 now?

@abekkala correct always consider the later one unless said otherwise
But the code is dumb and adds the new hold without looking if there is already one 😄

Not overdue, will fill out first 3 items of the BZ checklist today

@eVoloshchak Bump

The PR that introduced the bug has been identified. Link to the PR:
n/a, this was missed during the initial implementation. As @b1tjoy said here,
This was caused by https://github.com/Expensify/App/pull/12987 for AboutPage specifically, but we ended up adding link context menus to all of the menu items on all pages, which was missed during the initial implementation

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: n/a

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: This should be caught during the PR review, I think there isn't much more we can do. We can add a checklist item All of the menu items should have a link context menu, but that seems obvious.

Determine if we should create a regression test for this bug.

Is it easy to test for this bug?

Yes

Is the bug related to an important user flow? (For example, adding a bank account)

No

Is it an impactful bug?

No
This is a non-breaking bug, that isn't affecting user flow. I don't think the regression test is needed here. It would mean testing that every menu item that has a link also has a context menu with the said link. A simple 1 step test, but for every menu item in the app.

@eVoloshchak and @akinwale
You've each been paid and contract ended in Upwork 🎉
Thank you!

@abekkala, I think the amount should be $500 instead of 1500$
This has caused a regression

@abekkala, bump on the above

Not sure whats the process on this one, maybe we can just cut the price down on some future payments

hmm, yeah, I can't retract a payment.

Each regression reduces the pay amount for C+ by 50% (only C+ gets reduced pay). Additionally, no efficiency bonus is paid for merging quickly if there are any regressions.

So yes, you're correct your payment for this should have been only $500 vs $1500.
A future job of yours will need to be reduced by $1000 to make up for the overpayment here.

@akinwale can you link some issue where you active that we could reduce the payment for to compensate for this please?

Oh damn yeah, was there no payment on the follow up issues/regression?

Oh damn yeah, was there no payment on the follow up issues/regression?

No, there wasn't. @eVoloshchak did the review for the follow up issue/regression as well (https://github.com/Expensify/App/issues/17656#issuecomment-1515046396). Note that this also covered a new issue that was discovered in a different commit.

@abekkala ok so we are all good here, thanks for raising this. With millions of issues its easy to get lost in this

@mountiny Only the C+ gets a reduced payment in the case of a regression. (in this case it would have meant a reduction for evoloshchak only - not akinwale)
Are you saying that there actually isn't a need for a reduction in payment due to this being an edge case?
I have a payment coming up for evoloshchak (on a different GH)  that I was going to reduce in order to even out this GH. Is that not necessary and I can just do a normal full pay out without reducing due to this GH regressIon?

Yes full pay out!
Oh I thought its both who get reduced payment.

I think everything was done and paid here so closing, thanks for all the help, please comment if otherwise


[Bug] Navigating to a non-existing user displays match history

Describe the bug
Navigating to a non-existing user displays match history
Steps to reproduce
navigate to http://localhost:8080/profile/does-not-exist
Expected behavior
We should see a 404 maybe
Environment
Not relevant
OS
Not relevant
Browser
Chrome
Version
Not relevant
Additional context
No response
Relevant log output
No response

fixed by #232


There is the possibility of integration with Vue.js 2.0?

There is the possibility of integration with Vue.js 2.0?

related #4594.


Ensure truss predict --published gets the right version

The current logic is actually correct, if you want to "Get the latest published version". The backend automatically sorts by timestamps descending.
Have we actually observed this returning the incorrect version? If not, let's roll forward with what we have. To actually clear this up, I think that we should have some better graphql queries and think about it a little bit more.


More gnome 3.32.1

Motivation for this change
Some more gnome 3.32.1 updates
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

mutter update in #59818


Experiment with the get/set timebase function read about in sleepex()

This caused no change at first.

Problem fixed in DoComm()... too frequent application.processmessages causes 'bursty' visual updates.

Decided to leave this as is (with get/set timebase function) for release and future unless a problem is detected.


How to mannualy create a dev_tasks.txt

I run ./scripts/train_tk_instruct.sh
But it cannot find dev_task.txt
I wonder whether it is a must.
Traceback (most recent call last):
  File "src/run_s2s.py", line 581, in <module>
    main()
  File "src/run_s2s.py", line 317, in main
    max_num_instances_per_eval_task=data_args.max_num_instances_per_eval_task
  File "/opt/conda/lib/python3.7/site-packages/datasets/load.py", line 1699, in load_dataset
    use_auth_token=use_auth_token,
  File "/opt/conda/lib/python3.7/site-packages/datasets/builder.py", line 596, in download_and_prepare
    dl_manager=dl_manager, verify_infos=verify_infos, **download_and_prepare_kwargs
  File "/opt/conda/lib/python3.7/site-packages/datasets/builder.py", line 690, in _download_and_prepare
    ) from None
OSError: Cannot find data file.
Original error:
[Errno 2] No such file or directory: 'data/splits/default/dev_tasks.txt'

Hi @LukeLIN-web, yeah we didn't provide the official dev set because we are not sure what should be used for validation in this cross-task generalization setting. We have a suggestion here for creating the dev tasks. Basically, you can copy some tasks in train_tasks.txt to dev_tasks.txt and the code should work fine.

I create dev_tasks.txt in data/splits/default/dev_tasks.txt. But it still has error :
Traceback (most recent call last):
File "src/run_s2s.py", line 591, in
main()
File "src/run_s2s.py", line 497, in main
train_result = trainer.train(resume_from_checkpoint=checkpoint)
File "/opt/conda/lib/python3.7/site-packages/transformers/trainer.py", line 1475, in train
self._maybe_log_save_evaluate(tr_loss, model, trial, epoch, ignore_keys_for_eval)
File "/opt/conda/lib/python3.7/site-packages/transformers/trainer.py", line 1602, in _maybe_log_save_evaluate
metrics = self.evaluate(ignore_keys=ignore_keys_for_eval)
File "/opt/conda/lib/python3.7/site-packages/transformers/trainer_seq2seq.py", line 70, in evaluate
return super().evaluate(eval_dataset, ignore_keys=ignore_keys, metric_key_prefix=metric_key_prefix)
File "/opt/conda/lib/python3.7/site-packages/transformers/trainer.py", line 2253, in evaluate
eval_dataloader = self.get_eval_dataloader(eval_dataset)
File "/opt/conda/lib/python3.7/site-packages/transformers/trainer.py", line 738, in get_eval_dataloader
raise ValueError("Trainer: evaluation requires an eval_dataset.")
ValueError: Trainer: evaluation requires an eval_dataset.

What is your running command? And what are included in your dev_tasks.txt?

running command:
./scripts/train_tk_instruct.sh
dev_task.txt
task1356_xlsum_title_generation
task893_gap_fill_the_blank_coreference_resolution
task641_esnli_classification
task1529_scitail1.1_classification
task202_mnli_contradiction_classification
task670_ambigqa_question_generation
task1393_superglue_copa_text_completion
task1344_glue_entailment_classification
task288_gigaword_summarization
task1387_anli_r3_entailment
task1664_winobias_text_generation
task1161_coda19_title_generation
task880_schema_guided_dstc8_classification
task738_perspectrum_classification
task1439_doqa_cooking_isanswerable
task645_summarization
task619_ohsumed_abstract_title_generation
task1728_web_nlg_data_to_text
task1640_aqa1.0_answerable_unanswerable_question_classification

{'loss': 1.8193, 'learning_rate': 5e-05, 'epoch': 0.17}
Traceback (most recent call last):
  File "src/run_s2s.py", line 591, in <module>
    main()
  File "src/run_s2s.py", line 497, in main
    train_result = trainer.train(resume_from_checkpoint=checkpoint)
  File "/opt/conda/lib/python3.7/site-packages/transformers/trainer.py", line 1475, in train
    self._maybe_log_save_evaluate(tr_loss, model, trial, epoch, ignore_keys_for_eval)
  File "/opt/conda/lib/python3.7/site-packages/transformers/trainer.py", line 1602, in _maybe_log_save_evaluate
    metrics = self.evaluate(ignore_keys=ignore_keys_for_eval)
  File "/opt/conda/lib/python3.7/site-packages/transformers/trainer_seq2seq.py", line 70, in evaluate
    return super().evaluate(eval_dataset, ignore_keys=ignore_keys, metric_key_prefix=metric_key_prefix)
  File "/opt/conda/lib/python3.7/site-packages/transformers/trainer.py", line 2253, in evaluate
    eval_dataloader = self.get_eval_dataloader(eval_dataset)
  File "/opt/conda/lib/python3.7/site-packages/transformers/trainer.py", line 738, in get_eval_dataloader
    raise ValueError("Trainer: evaluation requires an eval_dataset.")
ValueError: Trainer: evaluation requires an eval_dataset.

It's wired. Did you change anything in the script? If you have dev_tasks.txt, you should be able to load the eval_dataset here in this line. Can you check if the eval_dataset is correct here?

It's wired. Did you change anything in the script? If you have dev_tasks.txt, you should be able to load the eval_dataset here in this line. Can you check if the eval_dataset is correct here?

I clone the newest repo src/ and scripts/ , it run smoothly.


W030 false positive

Hello,
I've juste install JShint on atom and after some configuration it's working pretty well.
But here is a case where the errors does't seem to come from me :
	if (this.type === OBJECT_TYPE) {
		this.location[tab[1]] = location
		++this.max // W030 : Expected an assignment or function call and instead saw an expression
		return true
	}

By putting the ++ operand at the end of the statement or a semi-colon on the line above the warning deapper but both syntax are valid and increment this.max.

You can workaround this by adding a semicolon after location (or before ++, as you prefer)

yes, i've notice i can workaround this, but since it's a assigment and JShint say the opposite, i thinked this as to be reported.

On master that code also throws Missing semicolon. (E058) between ++ and this

I made some attempts to fix this issue, but I don't know which is the best :sweat_smile:

nicolo-ribaudo/jshint@9cd07e2475008212bdd5c1799b93cc8b6868394b

This is probably the simpler method. If ++ is on a new line, the expression function stops looping. I don't like this because I feel like the expression function should know as least as possible about the JavaScript syntax.

nicolo-ribaudo/jshint@be0af7de93a47aff9ed237b00f7877a0e1b1e997

Disable the led if ++ is on a new line (prefix operators should just have the nud method)


Add Datasette Desktop to installation documentation

See https://datasette.io/desktop and https://simonwillison.net/2021/Sep/8/datasette-desktop/

Especially relevant now that 0.2.0 is out which is a much higher quality release. https://github.com/simonw/datasette-app/releases/tag/0.2.0

Going with this for the copy:

Datasette Desktop is a packaged Mac application which bundles Datasette together with Python and allows you to install and run Datasette directly on your laptop. This is the best option for local installation if you are not comfortable using the command line.


[BEAM-3773][SQL] Init compiler factory with JDBC class loader

We should load the CompilerFactory at JDBC Driver loading time.

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

R: @kennknowles I hope this makes you cry less then the previous version did.

No more tears. Looks like what we've got to do ;_;

@kennknowles This is green!


Improve batch::Context safety

There is a number of issues with batch::Context as it stands now:

Using a RefBatch with a wrong context results in an undefined behavior and/or crash.
Easy to leak batch data (#464).
Unique resources are copied anyway (#351).

Possible solution to n1:

Don't allow Context to be constructed directly. Instead, have a macro that creates a new type that implements Deref<Context> and instantiates it.
Have RefBatch<T: ShaderParam, C: Deref<Context>>, thus making it only compatible with our new context.

Radically fixed in #757


Transformer not applied

Hi!
I have currently the problem that my transformer seems not to be applied, instead the fields from the eloquent model are exposed. I'm using lumen if that's important.
My model lies within app/Models and is as follows:
<?php

namespace App\Models;

use Illuminate\Database\Eloquent\Model;

/**
 * @property int id
 * @property string display_name
 */
class Gender extends Model
{
    /**
     * The table associated with the model.
     *
     * @var string
     */
    protected $table = 'genders';

    /**
     * The primary key associated with the table.
     *
     * @var string
     */
    protected $primaryKey = 'id';

    /**
     * Indicates if the model should be timestamped.
     *
     * @var bool
     */
    public $timestamps = false;

    /**
     * The attributes that are mass assignable.
     *
     * @var array
     */
    protected $fillable = [
        'display_name',
    ];

    /**
     * The attributes excluded from the model's JSON form.
     *
     * @var array
     */
    protected $hidden = [
    ];
}

That's the corresponding transformer:
<?php

namespace App\Transformers;

use App\Models\Gender;
use Flugg\Responder\Transformers\Transformer;

class GenderTransformer extends Transformer
{
    /**
     * List of available relations.
     *
     * @var string[]
     */
    protected $relations = [];

    /**
     * List of autoloaded default relations.
     *
     * @var array
     */
    protected $load = [];

    /**
     * Transform the model.
     *
     * @param  \App\Models\Gender $gender
     * @return array
     */
    public function transform(Gender $gender)
    {
        return [
            'id' => $gender->id,
            'name' => $gender->display_name,
        ];
    }
}

And here is the controller function:
public function index(Transformation  $transformation): array
    {
        return $transformation->make(Gender::all())->transform();
    }

Current result is:
{
 "id": 0,
  "display_name": "male"
}

And it should be according to the transformer:
{
 "id": 0,
  "name": "male"
}

I'm quite lost here and I'm thinking I might miss some cruicial point here. :-(
Thanks in advance!

Sorry I was just being dumb, reread the documentation and return responder()->success(Gender::all(), GenderTransformer::class)->respond(); solved the issue.


Project name is undefined in status bar

Hi, and thank you for this plugin that does exactly what I was looking for.
Seems that my project name (I assume, the "name" properties of package.json ?) doesnt show in the status bar, instead I have undefined.
I tried to reload / restart vscode, but same :

My bad, just saw in the sources that you're using "displayName" instead of juste "name". Closed !

Thanks for spotting that. Now defaults to "name" if "displayName" is not defined in v0-0-0-5.


cqui_settings_local.sql not working

The location of the cqui_settings_local.sql on my system:
e:\Steam\steamapps\workshop\content\289070\2115302648\Assets\
The file was there from the beginning, right after subscription.
I have commented out this line:
     ("CQUI_AlwaysOpenTechTrees", 1), -- Always opens the full tech trees

and saved the file.
When I start a new game and go to CQUI settings, popups section, Always open tech trees is disabled.

I think the file got updated yesterday with the push to the workshop, can you post the entirety of the file?
I didn't make any changes to the ModInfo file so it should load, so I'm thinking that there is an issue with the sql file itself

attached
cqui_settings_local.zip

I don't think it's a problem with the file, as all I did is changing 0 to 1 and removing -- from the line.

yep, repro'd this.  will look into it.

I screwed this up, sorry about that.
That last line should be:
("CQUI_DUMMY_SETTING_TO_END_THE_SETTINGS_LOCAL_FILE", 0);
(it was missing the , 0 in the parenthesis

@Sharky444 as you may have seen, the version now live in the Steam workshop is fixed.


Update README.md to include new version

Changed
| 0.11 | 0.1                      |

to
| 0.11 | 0.1.1                    |

in README.md

Thanks @Aztro-dev!


switch between chat windows

I miss the possibility to have each chat in an separate window.
This will give the possibility to switch between chats via ALT+TAB
Your Rocket.Chat version: Version 1.3.1

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

foud out that you can search vai CTRL+P (https://rocket.chat/docs/user-guides/keyboard-shortcuts/) also in the desktop client

ok, that is a way of doing the switching part. But i can still not visit more than one chat...

Currently we chose to stick with the single window style, so I'll close this issue as this is not going to get implemented in the near future. Thanks for your suggestion.


does the published weights fit the model?

I'm trying to synthesize using gen_forward.py and pretrained weights and getting an error in WaveRNN initialization:

Traceback (most recent call last):
  File "gen_forward.py", line 94, in <module>
    voc_model.load(voc_load_path)
  File "/mnt/sdb/ForwardTacotron_latest/models/fatchord_version.py", line 420, in load
    self.load_state_dict(torch.load(path, map_location=device), strict=False)
  File "/usr/local/lib/python3.7/dist-packages/torch/nn/modules/module.py", line 845, in load_state_dict
    self.__class__.__name__, "\n\t".join(error_msgs)))
RuntimeError: Error(s) in loading state_dict for WaveRNN:
	size mismatch for fc3.weight: copying a param with shape torch.Size([30, 512]) from checkpoint, the shape in current model is torch.Size([512, 512]).
	size mismatch for fc3.bias: copying a param with shape torch.Size([30]) from checkpoint, the shape in current model is torch.Size([512]).

And in ForwardTacotron initialization

Traceback (most recent call last):
  File "gen_forward.py", line 112, in <module>
    tts_model.load(tts_load_path)
  File "/mnt/sdb/ForwardTacotron_latest/models/forward_tacotron.py", line 195, in load
    self.load_state_dict(state_dict, strict=False)
  File "/usr/local/lib/python3.7/dist-packages/torch/nn/modules/module.py", line 845, in load_state_dict
    self.__class__.__name__, "\n\t".join(error_msgs)))
RuntimeError: Error(s) in loading state_dict for ForwardTacotron:
	size mismatch for embedding.weight: copying a param with shape torch.Size([148, 256]) from checkpoint, the shape in current model is torch.Size([127, 256]).

Am I  missing something?

Hi, the hparams.py changed some time ago. You have to set the - - hp_file flag to the file sitting in the notebook_utils. I'm going to update the Readme on this and copy the hparams.py to the pretrained folder.

Update done. Hope it helps!

While trying to finetune the pretrained forward tacotron model, using train_forward.py, getting an error
Traceback (most recent call last):   File "train_forward.py", line 78, in <module>     restore_checkpoint(model=model, optim=optimizer,   File "ForwardTacotron/utils/checkpoints.py", line 27, in restore_checkpoint     model.load_state_dict(checkpoint['model'])   File "/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1223, in load_state_dict     raise RuntimeError('Error(s) in loading state_dict for {}:\n\t{}'.format( RuntimeError: Error(s) in loading state_dict for ForwardTacotron: 	size mismatch for pitch_pred.rnn.weight_ih_l0: copying a param with shape torch.Size([192, 256]) from checkpoint, the shape in current model is torch.Size([384, 256]). 	size mismatch for pitch_pred.rnn.weight_hh_l0: copying a param with shape torch.Size([192, 64]) from checkpoint, the shape in current model is torch.Size([384, 128]). 	size mismatch for pitch_pred.rnn.bias_ih_l0: copying a param with shape torch.Size([192]) from checkpoint, the shape in current model is torch.Size([384]). 	size mismatch for pitch_pred.rnn.bias_hh_l0: copying a param with shape torch.Size([192]) from checkpoint, the shape in current model is torch.Size([384]). 	size mismatch for pitch_pred.rnn.weight_ih_l0_reverse: copying a param with shape torch.Size([192, 256]) from checkpoint, the shape in current model is torch.Size([384, 256]). 	size mismatch for pitch_pred.rnn.weight_hh_l0_reverse: copying a param with shape torch.Size([192, 64]) from checkpoint, the shape in current model is torch.Size([384, 128]). 	size mismatch for pitch_pred.rnn.bias_ih_l0_reverse: copying a param with shape torch.Size([192]) from checkpoint, the shape in current model is torch.Size([384]). 	size mismatch for pitch_pred.rnn.bias_hh_l0_reverse: copying a param with shape torch.Size([192]) from checkpoint, the shape in current model is torch.Size([384]). 	size mismatch for pitch_pred.lin.weight: copying a param with shape torch.Size([1, 128]) from checkpoint, the shape in current model is torch.Size([1, 256]).
are the provided pretrained model compatible with current code base?

Hi, the uploaded model is not really intended for finetuning. Imo the architecture should still work but probably the default params changed. AFAIR I increased the pitch_rnn_dims from 64 to 128 (you could try to set it to 64 again)


Expired dependency - HTTP/2

Hello,
I have a problem with arigaio/atla.
I build a docker image and the only content of the image is:
FROM arigaio/atlas:latest
so there is no other dependency.
I check with "snyk" the actuality of the dependencies. Here I get the following message:
Upgrade golang.org/x/net/http2 to version 0.0.0-20220906165146-f3363e06e74c, 1.18.6, 1.19.1 or higher.
Affected versions of this package are vulnerable to Denial of Service as an HTTP/2 connection can hang during closing if a shutdown was preempted by a fatal error.

do you use this package? Can you maybe update it? Or is there another way to solve this?

Hey @Seppskit, and thanks for reporting this 🙏
We don't use this package directly, but I'll check this issue and update you if we can do anything about it.

Hey, @a8m ,
is there any news?  :)

I think i found the line:
when you update line 97 in atlas/internal/integration/go.mod and update the corresponding file go.sum
golang.org/x/net v0.0.0-20220802222814-0bcc04d9c69b // indirect and change it with:
golang.org/x/net v0.0.0-20220906165146-f3363e06e74c should do it.

Thanks for the research, @Seppskit.

atlas/internal/integration is our integration test, so you don't have to be worried about it.
For atlas/cmd/atlas, the package golang.org/x/net is indirectly imported by one of the packages used in Atlas. Although we do not have an HTTP server active within Atlas, I am open to updating this dependency. You are welcome to contribute this change, or I can make the update later today.

Are you blocked by this somehow?

I am currently ignoring this message from "snyk". However, this has an impact on all the dependencies I have in my project. Therefore I have just built a workaround. It would be nice if this gets fixed.

Fixed with https://github.com/ariga/atlas/pull/1525. Thanks for raising up this, @Seppskit 🙏


What should the voting window be?

Right now it's 1 hour between 10am and 10pm PST, 6 hours otherwise.  Are these values too short or too long?
Relevant code
def get_voting_window(now):
    """ returns the current voting window for new PRs.  currently, this biases
    a smaller window for waking hours around the timezone the chaosbot server is
    located in (US West Coast) """
    local = now.to(settings.TIMEZONE)
    lhour = local.hour

    hours = 1
    if lhour <= 10 or lhour >= 22:
        hours = 6

    seconds = hours * 60 * 60 * settings.VOTE_WINDOW_SCALE
    return seconds

If you're finding 1hr is too long, the window could be based on a number of votes (e.g. .5*NumberOfForks)

Take into consideration that some of us want to contribute from different time zones (I am on Eastern European Summer Time now), I think that the right approach to do this is a big window timeframe and some sort of threshold (a PR does not go through unless there is some sort of agreement, where YAY or NAY).

@studiosi what kind of window and threshold are you thinking?

I have to think a little bit about that, but something like one full day for voting on each PR, so everyone can vote and then measure something like how fast the voting has happened (whether it is positive or not), and if the voting is positive or negative with enough speed accept (or reject) the PR before the 24 hours.

One thing to keep in mind with the longer voting windows would be https://github.com/chaosbot/chaos/pull/26#issue-230631280

A good speed measurement that also can contribute to the democracy here is just keeping a mean of the amount of positive and negative votes per hour per PR and just establish empirically a threshold of speed to just fast-accept or fast-reject.
Regarding #26, I saw it, and I made a proposal here which can help also to end the problem of too much merging.

Why wouldn't the window just be 24 hours? This way anyone in any time zone has within one day of a or to approve or reject it.

Some weird edge cases to consider:
If you submit a PR at 09:59:59, the voting window will extend until 15:59:59, while the window for a PR submitted 1 second later will close 5 hours earlier at 10:59:59. The opposite happens for the 22:00 mark.

@studiosi I quite like the idea of criteria for a fast reaction to a PR. The only issue I can think of  would be that one timezone could slip in changes that could hurt another timezone before they get the chance to react, e.g. votes are only counted if made between 2300 and 0500 UTC. I think people would have to be pretty evil to get that through though 😛

Maybe the threshold could vary based on how controversial the change is? So if a PR gets 20 upvotes and no downvotes whatsoever it could get merged within the hour, but if if instead gets 20 upvotes and 10 downvotes voting can go on for several hours. Even-ish splits (20 up, 19 down, etc) would go for the full 24 hours.

I agree with the previous. Have a base time of two hours, each upvote reduces it by 5 minutes and each downlaod increases it by 10 minutes.
If the PR got 20 upvotes and no downvotes it would be merged in 1 hour. If its controversial it gives time for users to discuss and argue before chaos decides its fate. If it got 20 upvotes and 5 downvotes, it would have an hour and a half for people to weigh in. If the outvotes outnumber the downvotes such that it would wait longer than 24 hours, then chaos would close and deny that PR before it got to that point to prevent pending PR flood.

wew


feat(use-hooks): add useBreakpoint hook

Adds a useBreakpoint hook so we can use our Tailwind breakpoints in a consistent way that matches how we use the in CSS.
Fixes DOC-1338 😱 🧟
Also fixed a bug with the API Client sidebar while I was in there (it used to be possible to do this if you opened the sidebar with a viewport between 780px and 800px)

Fixes DOC-1338 😱

Not a big fan of this one! Responsiveness in JS is a bad habit. What if we just removed it completely?

Yeah I mean I don't love it either but we use it in a bunch of places already and this at least keeps it aligned with our tailwind breakpoints.
There are certain things we can only do with media queries in JS like mounting and unmounting components (otherwise sometimes we might have big hidden DOM trees still being managed by Vue).
It's also worth note that these JS media queries use MatchMedia under the hood which should have similar performance to CSS media queries (or rather it's not like it's polling the viewport size or something)
What do you think if we add a blurb in the readme and on the JSDoc reminding folks to use CSS if at all possible?


GET /txs/:hash/withdrawals Broken

The  /txs/:hash/withdrawals endpoint returns "404 not found" when querying a known transaction that includes withdraws.
Tx in question: 2886e1539810fd92c8b4637a57faccc749379d0a09e9c4cadc3ac5d9a4113e31

@1000101  Confirmed it is now working.
Thank you for your fast reply.


Authentication page needs to be updated to reflect the new Credentials UI

The Credentials UI in Google Developers Console has been updated. Some of the things to be updated:

The nav hierarchy has changed. The phrases are different, but still recognizable with the old hierarchy.
New credentials wizard has been added to help guide the users to the right credential type.

Please update the Getting Started -> Authentication in gcloud-node to reflect these changes.

Thanks for bringing this up. I just merged https://github.com/GoogleCloudPlatform/gcloud-common/pull/37, so our site is updated as well.


Import: Add support for connect API: GET /v1/content/{GUID}

Update connect_client.go to provide the ability to call API
Update agent deployment import call to call connect_client functionality and log output
w/ Go unit tests
Testable via curl command

Not needed at this time. Instead going with functionality within #2286


Visualizing reverse order of inputs for some Concat modules in YOLOV5s

Netron app (website) : https://netron.app/
OS and browser version: macOS 12.5 (21G72) + Chrome Version 106.0.5249.119

Steps to Reproduce:

Upload yolov5s.onnx in netron.app
Concat Modules - [12, 16, 19, 22] are being given inputs in reverse order. (Correct order(Tensorboard) is in https://medium.com/analytics-vidhya/object-detection-algorithm-yolo-v5-architecture-89e0a35472ef)

@NKSagarReddy can you please share the specific ONNX file and a screenshot or example?

@lutzroeder
Yolov5s.onnx - https://drive.google.com/file/d/1-99xFLF2v3jz_PgS5mJI5rI9k4pkjf3i/view?usp=sharing

The Concat after model.18.conv is model.19
For the model.19 concat layer, the model.18.conv output should be the first argument, not the second.
Expected representation:

The order is listed in properties. The graph layout library does not support edge ordering. dagrejs/dagre#112


Add description

Codecov Report

Merging #124 (c560986) into master (cbf9e86) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #124   +/-   ##
=========================================
  Coverage     76.15%   76.16%
- Complexity      675      680    +5
=========================================
  Files           100      100
  Lines          1929     1934    +5
  Branches        203      204    +1
=========================================
+ Hits           1469     1473    +4
  Misses          402      402
- Partials         58       59    +1

Impacted Files
Coverage Δ

src/main/java/seedu/address/model/lab/LabMark.java
91.30% <0.00%> (-3.15%)
:arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


update custom elements jsbin

It needs to include latest canjs and be the same code as the example listed in the intro

http://donejs.com/Features.html#section=section_CustomHTMLElements


Win-acme and Zerossl

In the past when I downloaded win-acme and connected Zerossl it would always ask me for my API key, EAB credentials, or to create a new zerossl account. Now it doesn't ask that and when I finish doing all the steps it says certificate creation failed. Please help???

Could you share some log output?

What do you mean? (sorry, I don't have that much experience on coding or technology).

You can just copy paste the output from the screen, or find the log file in %programdata%\win-acme\{url}\log

Complete Log
` A simple Windows ACMEv2 client (WACS)
Software version <IP_ADDRESS>7 (release, trimmed, standalone, 64-bit)
Connecting to https://acme.zerossl.com/...
Scheduled task not configured yet
Please report issues at https://github.com/win-acme/win-acme
N: Create certificate (default settings)
M: Create certificate (full options)
R: Run renewals (0 currently due)
A: Manage renewals (0 total)
O: More options...
Q: Quit
Please choose from the menu: M
Running in mode: Interactive, Advanced
Please specify how the list of domain names that will be included in the
certificate should be determined. If you choose for one of the "all bindings"
options, the list will automatically be updated for future renewals to
reflect the bindings at that time.
1: Read site bindings from IIS
2: Manual input
3: CSR created by another program
C: Abort
How shall we determine the domain(s) to include in the certificate?: 2
Enter comma-separated list of host names, starting with the common name: *.robertzou.com, robertzou.com
Target generated using plugin Manual: *.robertzou.com and 1 alternatives
Suggested friendly name '[Manual] *.robertzou.com', press  to accept or type an alternative:
Validation plugin SelfHosting not available: Unsuppored target. Most likely this is because you have included a wildcard identifier (*.example.com), which requires DNS validation.
The ACME server will need to verify that you are the owner of the domain
names that you are requesting the certificate for. This happens both during
initial setup and for every future renewal. There are two main methods of
doing so: answering specific http requests (http-01) or create specific dns
records (dns-01). For wildcard domains the latter is the only option. Various
additional plugins are available from https://github.com/win-acme/win-acme/.
1: [http-01] Save verification files on (network) path
2: [http-01] Serve verification files from memory
3: [http-01] Upload verification files via FTP(S)
4: [http-01] Upload verification files via SSH-FTP
5: [http-01] Upload verification files via WebDav
6: [dns-01] Create verification records manually (auto-renew not possible)
7: [dns-01] Create verification records with acme-dns (https://github.com/joohoi/acme-dns)
8: [dns-01] Create verification records with your own script
9: [tls-alpn-01] Answer TLS verification request from win-acme
: Abort
How would you like prove ownership for the domain(s)?: 6
After ownership of the domain(s) has been proven, we will create a
Certificate Signing Request (CSR) to obtain the actual certificate. The CSR
determines properties of the certificate like which (type of) key to use. If
you are not sure what to pick here, RSA is the safe default.
1: Elliptic Curve key
2: RSA key
C: Abort
What kind of private key should be used for the certificate?: 2
When we have the certificate, you can store in one or more ways to make it
accessible to your applications. The Windows Certificate Store is the default
location for IIS (unless you are managing a cluster of them).
1: IIS Central Certificate Store (.pfx per host)
2: PEM encoded files (Apache, nginx, etc.)
3: PFX archive
4: Windows Certificate Store
5: No (additional) store steps
How would you like to store the certificate?: 2
Path to folder where .pem files are stored: C:\Certificates
Password to use for the private key .pem file or  for none:
1: IIS Central Certificate Store (.pfx per host)
2: PEM encoded files (Apache, nginx, etc.)
3: PFX archive
4: Windows Certificate Store
5: No (additional) store steps
Would you like to store it in another way too?: 5
Installation plugin IIS not available: This step cannot be used in combination with the specified store(s)
With the certificate saved to the store(s) of your choice, you may choose one
or more steps to update your applications, e.g. to configure the new
thumbprint, or to update bindings.
1: Create or update https bindings in IIS
2: Create or update ftps bindings in IIS
3: Start external script or program
4: No (additional) installation steps
Which installation step should run first?: 4
Failed to create order
Create certificate failed, retry? (y/n*)`

Duplicate with https://github.com/win-acme/win-acme/issues/1806


Add a suggestion hard limiter

In Auto-Depth mode even with the Split Limit the number of suggestions can get out of hand once you get deeper into inference.  There should be a way to limit the total number of beams returned so that it doesn't sit just there and run forever.
For these dense cases you probably want to disable Auto-Depth and manually step 6-8 tokens at a time until you get out of the woods.

Maximum Suggestions is available in the latest version.  This is not quite a hard limiter for reasons that are fairly complex, but beams will stop splitting after this threshold and in general you should end up within 10%.


Why some data class constructors show an missed branches?

Hi,
to understand the causes of the problem, we need additional information.
May you provide a compiled class-file for DrawCapOptionWithPrice class? And give an example of the original source code of this class.
Which version of the compiler was used?

Source code:
data class DrawCapOptionWithPrice(
    val rating: BandRating,
    val cost: Cost,
    val top: Boolean = false,
)
[DrawCapOptionWithPrice.class.zip](https://github.com/Kotlin/kotlinx-kover/files/11915933/DrawCapOptionWithPrice.class.zip)

Class attached
DrawCapOptionWithPrice.class
Compiler:
Azul Zulu SDK 17
Kotlin:
1.7.22

Thanks!
Also XML report would be helpful

<class name="com/example/scx/common/DrawCapOptionWithPrice" sourcefilename="CommonValueObjects.kt">
<method name="<init>" desc="(Lcom/example/scx/common/BandRating;Lcom/example/scx/common/Cost;Z)V">
<counter type="INSTRUCTION" missed="0" covered="28"/>
<counter type="BRANCH" missed="1" covered="1"/>
<counter type="LINE" missed="0" covered="4"/>
</method>

Also, this is not an exception. It happens to many data classes. It seems to affect those data classes that have extension methods.

@losiu97, is this for Kover version 0.7.2?

yes

@klys-equinix Unfortunately, I cannot reproduce your issue on my examples. Could you please share some more code? If your project is open-source, please share a link. Alternatively, it would be nice to have a small reproducer project. If it is impossible to reproduce with a small project, could you please share an example of an extension function for the class? (with bytecode preferably).

I tried reproducing this in a reproducer project, but i have not been able to see the same problems. I am at a loss why it happens in our main project. Unfortunetely, it would be hard to share the bytecode from that


add file test-pr.txt

first rule of learning how to use github: you don't learn it by doing things on a public repository (or you risk getting reported and perma-banned from it)


App Crashes in Samsung M51 with a pop up "This app has a bug. Please clear cache."

:ghost: Brief Description
App Crashes in Samsung M51 with a pop up "This app has a bug. Please clear cache." Even after clearing cache, it keeps crashing. It is opening for some seconds then closes automatically.
:pancakes: Action version
Version 17.0
:tophat: workflow configuration
Just install the app
Steps To Reproduce
Steps to reproduce the behavior:

Install the app frm Fdroid
Launch the app

:police_car: Expected behavior
App should run smoothly
:heavy_plus_sign: Additional context
Add any other context about the problem here. e.g. related issues or existing pull requests.

Same thing here in a POCO X3 Pro. App ver 17.0 crashes after launch. Show for a moment and force closes. It doesn't happen with the old version in PlayStore (v12.0), but sync is not working for me in this version using webdav.
Just install it, run, shows for a moment, and crash. Again and again.
Regards.

Thanks for reporting! Help with this would be much appreciated!

App installed from F-Droid v17 is crashing and cannot sync with Google Drive. App installed from PlayStore v7.12 works fine. Some minor visual bugs on start just for a couple of seconds, but the rest runs smoothly.
The app from F-Droid doesn't open the account selection to sync to Google Drive (haven't tried the other sync options). Instead it opens the web browser to login to Google.

@telmob Due to the related privacy issues the f-droid version doesn't support Google Drive Sync.


Updating README from branch Example

Updates
I updated the README file. Please review and accept.

Thoughts
I probably shouldn't, but okay. 👍


add nba back in

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?

👷 Deploy Preview for betsweatwin processing.

Name
Link

🔨 Latest commit
37df136c59daed0506d0374370e1f3e14264b422

🔍 Latest deploy log
https://app.netlify.com/sites/betsweatwin/deploys/653897da826a650008ce2ad7


Special caracters lower the name limit

Describe the bug
Special characters lower the 30 chars limit
seems to me like checking bytes not characters
To Reproduce
Steps to reproduce the behavior:

create a CSV with 29 chars name
append special character 'ä'
import file
observe wrong name

Expected behavior
The limit should count characters regardles of encoding
Additional context
Also as leading and trailing spaces are stripped, multiple spaces in between count to the length of name, but will be replaced by a single space. This leads to wrong marked names in the list with less than 30 character.

This should be discussed. Maybe we should check once the amount of chars and then the encoded chars, since this bug happens due to encoding.

for encoded data 50chars are fine in the qr code.
for space on the card 30 chars are fine.


SSLError not always translated to KubeException

There is a specific test that it should be (and #195 will add a second test):
https://github.com/abonas/kubeclient/blob/f489a35027a7/test/test_kubeclient.rb#L95-L105
but in reality I'm seeing an SSLError escaping:
https://gist.github.com/cben/faf8a9f7f104561c0b36c88ae02f2509
That makes sense, handle_exception only rescues RestClient::Exception.
Why does the test pass?
Aha.  RestClient has its own http://www.rubydoc.info/github/rest-client/rest-client/RestClient/SSLCertificateNotVerified, wraps some SSLErrors:
https://github.com/rest-client/rest-client/blob/8874463a4/lib/restclient/request.rb#L742-L761
      # TODO: deprecate and remove RestClient::SSLCertificateNotVerified and just
      # pass through OpenSSL::SSL::SSLError directly.
    ...
      if error.message.include?("certificate verify failed")
        raise SSLCertificateNotVerified.new(error.message)

In above gist the message was "hostname ... does not match the server certificate", not "certificate verify failed", so it isn't wrapped.

Looks unwise to depend on SSLCertificateNotVerified wrapping or not wrapping.
Would Kubeclient always wrapping SSLError be desired behavior?

I have a (weak) use case for distinguishing SSLError from other errors.  Would be nice to use a subclass, similar to #233.

Another alternative would be never wrapping.  This would require re-raising SSLCertificateNotVerified, and users having to expect either SSLError or SSLCertificateNotVerified. IMO less nice and unexpected.

I think either change would be slightly backward-incompatible.

@cben what's the final impact here. Does this deserve a bug to be tracked in MIQ?

Based on the link @cben posted I think we should catch OpenSSL::SSL::SSLError to keep the behavior we have (or thought we had). Introducing a new subclass sound good but I'd like to see this resolved first.
@cben do you plan to send a PR for this? I have some time to do that, let me know
(I think you have a lot on your plate ATM and this is high priority)

Some test code and different exceptions I got
test code
require 'kubeclient'

cert_store = OpenSSL::X509::Store.new
cert_store.add_cert(OpenSSL::X509::Certificate.new(IO.read('ca_bad.crt')))

ssl_options = {
    cert_store: cert_store,
    verify_ssl: OpenSSL::SSL::VERIFY_PEER
}
client = Kubeclient::Client.new(
  'https://vm-48-131.eng.lab.tlv.redhat.com:8443',
  'v1',
  :ssl_options  => ssl_options,
  :auth_options => {:bearer_token => token}
)
puts client.get_nodes

/home/mtayer/.gem/ruby/2.3.1/gems/kubeclient-2.3.0/lib/kubeclient/common.rb:107:in `rescue in handle_exception': SSL_connect returned=1 errno=0 state=error: certificate verify failed (KubeException)
	from /home/mtayer/.gem/ruby/2.3.1/gems/kubeclient-2.3.0/lib/kubeclient/common.rb:99:in `handle_exception'
	from /home/mtayer/.gem/ruby/2.3.1/gems/kubeclient-2.3.0/lib/kubeclient/common.rb:433:in `fetch_entities'
	from /home/mtayer/.gem/ruby/2.3.1/gems/kubeclient-2.3.0/lib/kubeclient/common.rb:423:in `load_entities'
	from /home/mtayer/.gem/ruby/2.3.1/gems/kubeclient-2.3.0/lib/kubeclient/common.rb:111:in `discover'
	from /home/mtayer/.gem/ruby/2.3.1/gems/kubeclient-2.3.0/lib/kubeclient/common.rb:78:in `method_missing'
	from /home/mtayer/.local/bin/kubeclient-local-ssl.rb:17:in `<main>'

/home/mtayer/.local/bin/kubeclient-local-ssl.rb:5:in `initialize': header too long (OpenSSL::X509::CertificateError)
	from /home/mtayer/.local/bin/kubeclient-local-ssl.rb:5:in `new'
	from /home/mtayer/.local/bin/kubeclient-local-ssl.rb:5:in `<main>'

/home/mtayer/.local/bin/kubeclient-local-ssl.rb:5:in `initialize': nested asn1 error (OpenSSL::X509::CertificateError)
	from /home/mtayer/.local/bin/kubeclient-local-ssl.rb:5:in `new'
	from /home/mtayer/.local/bin/kubeclient-local-ssl.rb:5:in `<main>'

I'm not sure we should catch & wrap, what rest client is doing is silly. It should be fix in rest client. Also It would break backward compatibility as @cben mentioned. So I'm favor of not changing anything in kubeclient
@simon3z @abonas What do you think?

Is there an issue reported on this to rest client repo?

Is there an issue reported on this to rest client repo?

https://github.com/rest-client/rest-client/issues/168 (from 2013)
This might also be related: https://github.com/rest-client/rest-client/issues/286


Can't modify include_ or exclude_dates via Config Flow

I might be missing it, but is it not possible to change include/exclude days once the sensor exists?

Go to Configuration/Integrations, select the sensor and then settings (top left corner).

i am trying to set an include and exclude for the holiday this week with the config flow and it seems to be ignoring it, still displaying my chosen day of the week as the next pickup. doesn't seem to change with newly created or editing an existing sensor.

Thanks. I see, will look at that. Looks lile adding the timezone broke quite a few things ....

@mrpeaches87 , did the release 2.6 fix that? Thanks!

i switched to yaml mode and it's still a day off. the update didn't help with this particular issue.
is the next date field supposed to have the full time in it? the date of this pickup is supposed to be 12-20
next date
2019-12-19T19:00:00-05:00

No, it is supposed to be just the date in ISO format.
Ok, it became quite messy with all the attempts to add timezone all around the place.
So, here is an attempt to fix that, I am going back where it started (using just date, without the time), but this time I am taking the current date from HA, which should be in the right timezone.
Can you @mrpeaches87, @lockyt, and @aolley do me a big favor, grab the development branch and try if it still works? It seems to work here, but I am only 1 hour from UTC. I have tried to change my timezone to try that, but it is apparently not that simple.
Thanks

Using the current development branch, I get a next date of:
2019-12-02T10:30:00+10:30
That should read 2019-12-02T00:00:00+10:30.
Putting myself back on v2.5, and I get the correct timestamp.

Ok, get it. Made one more change. Now it should render what you expect.
Does that work? Or I can do it without TZ, so it would read 2019-12-02T00:00:00.

working great now on the dev branch!

Solved by release 2.7


Unable to see resizable component.

Hi,
I am working on integrating react-grid for my demo. I am unable to see the grid resize component in my app. Please see the attached image.

Please find the demo source code: https://github.com/vigneshuvi/reactskeleton
Demo: https://vigneshuvi.github.io/reactskeleton/

Note: Enter valid any valid email and just four characters for password.

@vigneshuvi  For me the css was not being pulled it; it sets the position and other stuff of the handle.
Importing the css worked for me:
import 'react-grid-layout/css/styles.css'

Thanks, It is working fine now!


DWO cleanups

Follow up to #568
r? @khuey

Can we (you :) ) do a 0.25 with this?

I will in a few days after an object release.

0.25 is released.


[Doc] rewrite the installation guide

Refers to https://github.com/open-mmlab/mmdetection/pull/7897.


Chef container chef/chef:18.6.2: error while loading shared libraries: libcrypt.so.2

Description
Test kitchen fails to run with latest container from docker hub. The error message:
       Preparing data_bags
       Preparing validation.pem
       Preparing client.rb
       /opt/chef/embedded/bin/ruby: error while loading shared libraries: libcrypt.so.2: cannot open shared object file: No such file or directory

Chef Version
18.6.2
Platform Version
Docker amd64
Replication Case
docker pull chef/chef:18.6.2
docker run --name chef_1862 -it --rm -t chef/chef:18.6.2
/opt/chef/embedded/bin/ruby --version

Client Output
/ # /opt/chef/embedded/bin/ruby --version
/opt/chef/embedded/bin/ruby: error while loading shared libraries: libcrypt.so.2: cannot open shared object file: No such file or directory

Stacktrace
N/A

Compounding the problem - there is no way to revert back to 18.5.0 because the non-latest 18.x images are no longer published on Docker hub. Images for every 17.x version are available so it's unclear why they aren't for 18.x. Can we get all releases of 18.x re-published on Docker Hub so there's a fallback in case of issues like this?

Seeing this here as well.
root@buildkite:~# docker run -it chef/chef:latest /opt/chef/embedded/bin/ruby
/opt/chef/embedded/bin/ruby: error while loading shared libraries: libcrypt.so.2: cannot open shared object file: No such file or directory

It's broken all of our CI builds.

Looks like this is being addressed with #14762

There also never was a chef-client 18.5.0 as the last chef-client container release for 18.x was 18.3.0. The couple of builds between there were pipeline issues with the docker container builds and the versions were never published.

I suggest we use the fixes outlined in 14766, then we can build the docker containers with our pipelines on our end, and add tags accordingly.

Here is a fixed version of the docker image for Ubuntu / Debian systems: ghcr.io/firefishy/chef-docker-image:latest (currently 18.6.2)
Built by repo: https://github.com/Firefishy/chef-docker-image/
My fixed clone will be made redundant once this issue and https://github.com/chef/chef/issues/13907 have been fixed.


Graph container

still small bug when switching metric after already having graphed
basic functionality there with better styling now
functionally decomposed and using edits from code review

No bugs anymore, all functionality working.


plugins is not working

Summary
I want to use plugins like, uml,chart,etc. But, it's not working
Screenshots

Version
Write the version of the Editor you are currently using.
Latest
Additional context
Live
https://codesandbox.io/s/still-night-0feor?file=/src/App.js:2207-2214

Try as below in v3.0~!
$$uml
( * ) -> rahul
$$

@js87zz It's not working

@ats1999
It's worked well in your sandbox.

In My sandbox

My System
Ubuntu 20.04 LTS

Wrong src

With
const umlOptions = {
  rendererURL: "https://www.plantuml.com/plantuml/svg/"
};

Url becomes

But, image is not showing.


Change capitalisation of the project name to the commonly used form

…Testcontainers
Because 2 years after the project release is a fine time to finally settle whether it's TestContainers or Testcontainers
🙃

I don't now if you got every file, but those changes look good 😄


Clarity on the baseline procedure

Hi Dr. Ahlmann-Eltze,
I had trouble matching the code to the text, and I just have a simple question about that. I'm not sure if this is the right forum to ask -- please feel free to redirect.
The paper says the linear baseline learns a K by K matrix W (eqn 1) using a procedure that involves only PCA and replacement of some PCA outputs by other PCA outputs -- no ridge regression or gradient descent.

The code in run_linear_perturbation_prediction.R uses ridge regression in addition to PCA, and it learns a matrix of size K by the number of genes, not K by K.
The code itself makes a lot of sense but there seems to be a last step not described in the paper -- discard G and W and learn a replacement via ridge regression. Could you clarify?
Thanks very much, and congratulations on an important study that is garnering a lot of well-deserved attention.
Eric Kernfeld

This is very helpful! I will take a look at the details and follow up if needed. Thank you.


Support for A9MEM1580

In our setup, we are using several A9MEM1580 devices. It would be great to have them supported. Happy to send you one of the devices to include it into the integration.

Currently, the device is compatible, though not feature complete.
These are the ones that are currently missing:
Here's a brief list of what's missing;

RMS current on Neutral
Reactive power on phase
Total reactive power
Apparent power on phase
Power factor on phase
Power factor sign convention
AC frequency
Device internal temperature
Total active energy delivered/received (not resettable)
Set partial active/reactive energy delivered/received counter. The value returns to zero by PowerTag Link gateway.
Partial active/reactive energy received/delivered (resettable)
Active/Reactive/Apparent energy (on phase) delivered/received (resettable)

If you would like me to implement them, please send a device over so that I can test with it locally.

Hi,
I also use 1 of these tools. Unfortunately I can't see the energy used in the energy consumption sheet :( Can you help me?

What do you mean with 'the energy consumption sheet'? Are you looking for one of the things as described above?

Hi,
I was thinking of the Homa Assistant "Energy" tab (Energy dashboard).
I have an A9MEM1520 and an A9MEM1580 sensor. The 1520 works fine. For the 1580 I don't get partial energy data, so it doesn't show up on the chart.

Is just this entity missing, or the device all together? Can you check if you find it within the devices section?

Also please check that it's correctly configured in the PowerTag Link GUI.

I see it in the devices.
The entity also exists, but takes on an "unknown" value.
Other values (voltage, current, pf, etc.) are visible.
The partial energy is visible on the web interface of the data collection unit, it just doesn't come through to the Home Assistant.
What am I doing wrong? Should I try to delete the device in HA and add it again?

It's not you. I haven't fully supported yours yet. The ones I use for testing is the first one, but yours uses a separate register; the last one.

I'll give it a shot to implement the above, though bear in mind that I can't test it myself.

Okay. Thank you very much for your help!

Alright I've pre-released v0.1.5. Please test and give feedback.

Hello!
I've overridden the files in the custom_components folder and restarted Home Assistant. This should be enough, or do I need to delete the gateway and add it again?
The following values are still missing: partial energy (unknown), partial reactive energy received (unknown), total active energy (unknown), total energy (unavailable). Thank you for your efforts!

This should be enough, or do I need to delete the gateway and add it again?

Should be enough, specially since the entities that are giving you problems  are new ones.
Let me check these for you, please hold on.

Partial energy
Does seem to work for me, though there can be gaps in the data sometimes. Is this broken on your A9MEM1520 or A9MEM1580 sensor, or both? It's possible that your A9MEM1580 doesn't support this one, as it has more detailed entities available.

partial reactive energy received
Might it be possible that your powertag just hasn't received any reactive energy? My code does look valid on this one.
total active energy
My bad, you should have been seeing this on your A9MEM1580. Fixed this one in v.0.1.6.
Fixing this one will enable reactive power, frequency and temperature for this PowerTag as well. :)
total energy
No longer used, please delete.

Thank you very much, everything is working fine. What do I owe you?

Nothing lol.
Though if you know someone inside Schneider, I've got some devices on my wish list that would help further development.
Our PowerTag Links are being discontinued end of this year, I'm looking to support its replacement but I can't justify the cost.

I'm afraid I don't know anyone at Schneider. I do have a friend who has a business relationship with them. If you need information, they might be able to help, but I can't promise. Thank you again.

I would already be great if your friend could connect me with someone on the inside. :)
Been getting the cold shoulder from the forums / regional sales.


Renaming project:

Need to refactor a few lines in the project. Update CMake. This will be a breaking change and everyone will need to re-clone, re-build.
The new internal name is: Dog-Tales

Finished on PR acceptance.


Adding IsMultiRegionTrail support

Troposphere's CloudTrail is missing one of the parameters listed in the CloudFormation reference http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-cloudtrail-trail.html#cfn-cloudtrail-trail-s3bucketname.
This pull request adds this parameter.
The code has been tested manually.

Awesome, thanks!


Unable to locate "px4.launch"

According to mavros_sitl.launch
<include file="$(find px4)/launch/px4.launch">t  this line
ros go into package px4 and find px4.launch
But px4 firmware doesn't have px4.launch in V1.8 (recommended by the README.MD of this repo )
I know avoidance can't work with the master branch of Firmware. ( the drone can't be armed in mater )
Hence, how to solve this conflict?

@ElderWanng The avoidance does work with the latest Firmware master. Please use that. 1.8 is quite old and it doesn't support all the avoidance features (e.g. avoidance in mission mode)


Fixes and changes

Changed app name to Engagement Grid
Changed customer label to be a custom label and thus configurable both for Singular and Plural
Changed Contact fieldnames to start with EngGrid_ to differentiate from existing fields for Segment Science on Converse.

@jorrit-findock any idea when you will get around to having a look at this stuff? :)


Custom Pick List / Lookup

Implementation question..
Take for example I have a projects table with 2019-nnnn as their Name. I have some projects which are not yet real projects and I would like to be able to assign a pseudo project number such as PS19-nnnn.
I also have tasks that I must assign to either of these ..  (and this is where the custom lookup selection pick list would be - and I would need specifically the actual field and not the FK_Id)
So basically a user can select an existing project or a pseudo project (or create new pseudo project - if it is not in the list)
Should I just create a PseudoProject Table and do a join on the two tables and use that as a lookup ?
I would want the text value and not the Id in the task Column .

Difficult to write! There is 1 table projects, there a sign of pseudo or real project. and all the problems will be gone.

Yeah - as @Zahar661 says: Make one project table and a flag field (e.g. a bit field / boolean) with which you flag a project to be a pseudo project or not.
Then you also easily can put a quick filter on it to only show pseudo or real projects - or both.
With kind regards,
John

@JohnRanger  Yes - problem is the real project table has special code to generate a Real Sequence number in the form IDYY-NNNN and I do not want to use those for any pseudo projects.
Basically when we are evaluating projects for a customer it is not yet a real project - so this is why I had desired two tables - to keep them separate and track them separately - so I can know the time / resources (people)  that need to be applied to non-project projects and projects alike .  I guess I can hit the real table from another page and place the data in there as I like (perhaps using a different sequence number of say nnnnxxxx so I do not overwrite or duplicate (the field will allow it) ..
Simply allow a pick list from the real projects table to add in  - like they do in the multi - fields - I think I will need to check into that code for the multi field select - I do not remember where that was to allow that -maybe I saw it in the Movie sample.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_e9b1e5fd-e0ba-4ad7-b157-49f8b32d7b88/pull/1 is merged into live branch.
Auto archive content to https://github.com/huangmin-ms/docs-archive-test-target_e9b1e5fd-e0ba-4ad7-b157-49f8b32d7b88.git

Docs Build status updates of commit d8c9735:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-UserAccountBuildPermissionInsufficientError] Owner v-alji no longer has Read permission of the repository https://github.com/huangmin-ms/docs-archive-test-source. It might be due to recent GitHub changes on SSO. Please ask the owner v-alji to logon to Docs Portal https://ops.microsoft.com once again. If it is not the case, please ask anyone of Admin permission of the repo to assign a new owner via Docs Portal https://ops.microsoft.com

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit d8c9735:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-UserAccountBuildPermissionInsufficientError] Owner v-alji no longer has Read permission of the repository https://github.com/huangmin-ms/docs-archive-test-source. It might be due to recent GitHub changes on SSO. Please ask the owner v-alji to logon to Docs Portal https://ops.microsoft.com once again. If it is not the case, please ask anyone of Admin permission of the repo to assign a new owner via Docs Portal https://ops.microsoft.com

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel