KinesisVideoStream->putFrame() doesn't return

Hi @MushMal @zhiyua-git
I am using Gstreamer streaming thread to get video frames in appsink and use the same thread to push these video frames to Kinesis by calling putFrame. Something similar to what you guys suggest in gstreamer sample app. I am observing that occasionally, the putFrame API doesn't return making my gstreamer pipeline to go unresponsive.
I haven't seen any ERRORS/WARN on my stream when it got locked however in the past, I have seen STATUS_INVALID_PARSED_ACK_TYPE being thrown in the past.  [Check this issue] (https://github.com/awslabs/amazon-kinesis-video-streams-producer-sdk-cpp/issues/135)
I am currently using 1.7.7 version of SDK.
Regards,
Ameya

@ameyat2812 KVS SDK has two streaming modes. In the offline mode the SDK will block for the availability before proceeding with a putFrame call. The availability comes from storage or temporal availability. Could you please clarify a little more your scenario? If you intend to stream real-time then your streaming type (STREAMING_TYPE enum) in StreamCaps should be STREAMING_TYPE_REALTIME.

Here are the details of how I am using it

It is a simple NVR kinda use case where the NVR talks to multiple cameras. These cameras are context separated.
I am creating an instance of KinesisVideoProducer with all the necessary callback providers and keeping it handy in my wrapper class per camera. And I also have multiple streams to upload to per camera. These streams will be created, started, pushed frames to and stopped as and when needed. (mind that I am not using kvssink element and tapping into SDK myself)
There is a stream (let us call it an Activity stream) which uploads events of interest to kinesis. The Activity stream upload pipeline looks something like this

rtspsrc ! rtph264depay ! video/x-h264,stream-format=avc,alignment=au  ! appsink !  ! create and start if not created and upload to activity stream

All the streams per camera share the same producer instance and yes they are configured to be STREAMING_TYPE_REALTIME.

I do have mutex protection around the stream handles so that no other thread can call any of KinesisVideoStream member while another call is in progress.

The above-mentioned setup works 99% of the time and I also have ERROR handling to recreate streams for fatal errors and often call KinesisVideoStream->resetConnection() on stale connection and similar warning messages. However, the putFrame() blocking issue happens every now and then and that makes my whole pipeline go unresponsive.

@ameyat2812 thanks for the info. In case of the realtime streaming the PIC itself doesn't block (modulo the low-level interlocking for multi-stream scenario but in this case the operations are prompt so it shouldn't be an issue). This said, the PIC uses callbacks for various operations. All of these callbacks are intended to be "prompt" - aka - they should ideally complete their execution within the thread quanta or spin up a separate execution unit (another thread) to run the processing. For example, our networking API calls are inherently asynchronous. The result of the call is fed in after the call completes but the callback is not blocked.
Can you validate whether any of your callbacks can block? Including the authentication callbacks.

@MushMal Thanks for that insight.
I added some extra logs in the callback handling functions and can confirm that all the callbacks returned back to SDK.
I have a logic to map callback events to messages which are added to a queue in my wrapper class. I process and take appropriate actions mainly before I push any new frames to the stream. So here is an example scenario,

Create Stream
Start Stream - All the kinesis video callbacks are converted to respective messages and added to the queue at this point onwards
Push Video (do it in the loop)

Check for any error/connection stale messages in the queue
Recreate the stream on Error and reset the connection on stale connections
if stream ready then putFrame()

The locking issue is happening very frequently now, especially after I have added multiple cameras to the NVR. During busy hours a lot of the cameras detect activity and start pushing to Kinesis. I have also observed that sometimes I do get "STATUS_ACK_ERR_INVALID_MKV_DATA" error (I do return the error reporting callback) and then I don't seem to receive any Frag Acknowledgment back from SDK for a while. As I am still pushing to stream, the putFrame() gets locked and never returns.
BTW. I am not taking any actions for ERRORs STATUS_ACK_ERR_INVALID_MKV_DATA to STATUS_ACK_ERR_UNKNOWN_ACK_ERROR (0x5200005e to 0x5000006F) which also includes STATUS_ACK_ERR_INVALID_MKV_DATA error.
Looking forward to your response.

@ameyat2812 this sounds like a reasonable approach however it's extremely difficult to pinpoint the issue without any logs.
Could you please first of all eliminate the CPU load as a factor. Simply check to see if your threads are starving. I highly doubt that this would be a root cause as the SDK is very lightweight and it sounds like you are blocked for a long time but nevertheless.
In real-time mode the SDK doesn't block at all and this is why I am puzzled. Unless it blocks on the callbacks there is very little processing that it does. If the networking is an issue it will still package and put the frame even if it means evicting the oldest frame in the stream (causing frame dropped notification callback). If it still can't put the frame then the putFrame call will fail with an appropriate error.
I would like to get more information on the blocked thread. Does it ever return?

Hi @MushMal,
I was able to actually something similar locally and I have sent logs to<EMAIL_ADDRESS>Please have a look at it and let me know what you think.

@ameyat2812 would you mind forwarding again? We don't seem to have received it.

@MushMal the issue turned out to be because of the way I was using putFrame(). I had a lock around putFrame() call for the streamReady mutex. This was to check if the stream is ready before putting any frames into it. But that seemed to cause a deadlock if the stream would run into errors triggering multiple callbacks, sometimes on the same thread.
I have removed the lock and things are flowing again. Thanks a ton for your help.


Pyrus\XMLParser\Exception: Cannot open phar:///.../built-in-commands.xml

I've tried to use the pyrus.phar from packages.zendframework.com, which gave me the following error:
Pyrus\XMLParser\Exception: Cannot open phar:///.../pyrus.phar/Pyrus_Pharer-0.1.0/data/pyrus.net/Pyrus/built-in-commands.xml for parsing.
So I tried the official pyrus.phar from pear2.php.net, which gave me a similar but slightly different error:
PEAR2\Pyrus\XMLParser\Exception: Cannot open phar:///.../pyrus.phar/PEAR2_Pyrus-2.0.0a3/data/pear2.php.net/PEAR2_Pyrus/built-in-commands.xml
$ php -v
PHP 5.3.8-ZS5.5.0 (cli) (built: Aug 23 2011 09:15:05)
Copyright (c) 1997-2011 The PHP Group
Zend Engine v2.3.0, Copyright (c) 1998-2011 Zend Technologies
with Zend Extension Manager v5.1, Copyright (c) 2003-2010, by Zend Technologies
- with Zend Data Cache v4.0, Copyright (c) 2004-2010, by Zend Technologies [loaded] [licensed] [disabled]
- with Zend Guard Loader v3.3, Copyright (c) 1998-2010, by Zend Technologies [loaded] [licensed] [enabled]
- with Zend Download Server v1.5.0, Copyright (c) 1998-2010 Zend Technologies Ltd., by Zend Technologies [loaded] [licensed] [disabled]
- with Zend Java Bridge v3.1, Copyright (c) 2004-2010, by Zend Technologies [loaded] [licensed] [enabled]
- with Zend Job Queue v4.0, Copyright (c) 2004-2010, by Zend Technologies [loaded] [licensed] [enabled]
- with Zend Session Clustering v4.0, Copyright (c) 2004-2010, by Zend Technologies [loaded] [licensed] [disabled]
- with Zend Utils v1.0, Copyright (c) 2004-2010, by Zend Technologies [loaded] [licensed] [enabled]
- with Zend Optimizer+ v4.1, Copyright (c) 1999-2010, by Zend Technologies [loaded] [licensed] [disabled]
- with Zend Code Tracing v1.0, Copyright (c) 2009-2010, by Zend Technologies [loaded] [licensed] [enabled]
- with Zend Monitor v4.1, Copyright (c) 1999-2010, by Zend Technologies [loaded] [licensed] [disabled]
- with Zend Debugger v5.3, Copyright (c) 1999-2010, by Zend Technologies [loaded] [licensed] [enabled]
- with Zend Page Cache v4.0, Copyright (c) 2004-2010, by Zend Technologies [loaded] [licensed] [disabled]
Have not tried to reproduce this on different systems yet.

Could you please paste the exact command that resulted in this exception please? Having a simple way to reproduce the issue locally would greatly help.
Also, could you try to reproduce the issue with the current pyrus.phar archive at pear2.php.net? (Pyrus-2.0.0a4)
It seems the built-in-commands.xml file is indeed missing from both Pyrus-2.0.0a3 and Pyrus-2.0.0a4 (at least, that's what phar.phar tree -f pyrus.phar | grep data reports).

Any command failed with above exception, even trying to execute the pyrus.phar without any extra args.
This might have been a PHP error though, as I'm unable to reproduce this with the original phar I used to get above exception with, as well as the fresh copy from pear2.php.net.
Current cli version:
PHP 5.3.9-ZS5.6.0 (cli) (built: Dec 22 2011 09:12:52)
Copyright (c) 1997-2011 The PHP Group
Zend Engine v2.3.0, Copyright (c) 1998-2011 Zend Technologies
    with Zend Extension Manager v5.1, Copyright (c) 2003-2010, by Zend Technologies
    - with Zend Data Cache v4.0, Copyright (c) 2004-2010, by Zend Technologies [loaded] [licensed] [disabled]
    - with Zend Guard Loader v3.3, Copyright (c) 1998-2010, by Zend Technologies [loaded] [licensed] [enabled]
    - with Zend Download Server v1.5.0, Copyright (c) 1998-2010 Zend Technologies Ltd., by Zend Technologies [loaded] [licensed] [disabled]
    - with Zend Java Bridge v3.1, Copyright (c) 2004-2010, by Zend Technologies [loaded] [licensed] [enabled]
    - with Zend Job Queue v4.0, Copyright (c) 2004-2010, by Zend Technologies [loaded] [licensed] [enabled]
    - with Zend Session Clustering v4.0, Copyright (c) 2004-2010, by Zend Technologies [loaded] [licensed] [disabled]
    - with Zend Utils v1.0, Copyright (c) 2004-2010, by Zend Technologies [loaded] [licensed] [enabled]
    - with Zend Optimizer+ v4.1, Copyright (c) 1999-2010, by Zend Technologies [loaded] [licensed] [disabled]
    - with Zend Code Tracing v1.0, Copyright (c) 2009-2010, by Zend Technologies [loaded] [licensed] [enabled]
    - with Zend Monitor v4.1, Copyright (c) 1999-2010, by Zend Technologies [loaded] [licensed] [disabled]
    - with Zend Debugger v5.3, Copyright (c) 1999-2010, by Zend Technologies [loaded] [licensed] [enabled]
    - with Zend Page Cache v4.0, Copyright (c) 2004-2010, by Zend Technologies [loaded] [licensed] [disabled]


Conversions Update

This PR accomplishes two separate things:

It consolidates the hypoelastic pressure calculation within the s_compute_pressure subroutine.
It does all speed of sound calculations with the compute_speed_of_sound and eliminates a few parameters for the inline subroutine.

Tested on Bridges2 w/ GPU and visualized examples/2D_shockbubble correctly.

Can you do benchmark tests to see what degree this slowed things down?

Thanks! I found a few things, for example:
https://github.com/anshgupta1234/MFC/blob/ccf1f443679249277e013f5027bc3db1ca8dfe2b/src/post_process/m_derived_variables.f90#L250-L304
and
https://github.com/anshgupta1234/MFC/blob/ccf1f443679249277e013f5027bc3db1ca8dfe2b/src/simulation/m_data_output.fpp#L1038
https://github.com/anshgupta1234/MFC/blob/ccf1f443679249277e013f5027bc3db1ca8dfe2b/src/simulation/m_start_up.fpp#L1127

I'm a little concerned about the readability of these inline functions. The main problem is that you do not get to define a scope. So for example, in your case one needs blkmod1, blkmod2, etc. etc. to all be defined whenever one calls your inlined routine, which lives in a different file. This won't be obvious to the developer. This gets more complicated if one isn't sure what type a variable should be (in which case I suppose they would hunt around for another invocation of this routine and copy/paste that).
I'm open to ideas that make these "inlined" fypp macro functions more readable without sacrificing speed. One option is to make this a private subroutine that gets stamped at the bottom of all relevant f90 files on compilation. With this, you get to define the scope yourself, but you don't sacrifice speed because it will be in the appropriate module. There are a few problems with even this, though, like having to include the fypp file at the top of all the relevant modules (maybe this isn't such a high price?).
I think there is probably a better way than this suggestion though. @henryleberre ? @anshgupta1234 ? (any ideas..)

@anshgupta1234 can you recheck the runtimes on GPU? sorry

this does seem like quite the clean fix to the problem, though.

@sbryngelson I would certainly test it if Bridges2 would just give me a GPU!

You can also try Phoenix/Wingtip3/etc.

Master:

Riemann solvers: 6e-4
Total time: 20.6s

Current:

Riemann solvers: 7e-4
Total time: 28s

@sbryngelson

This is quite the change (a 50% increase in runtime!). I'm not sure we should proceed this way (or why it is so slow).

you should be able to see if the call was indeed inlined using Minfo=accel.  I'm guessing it wasn't.

@sbryngelson It looks like it's being inlined...

It does appear that way. And can you confirm that there is still this massive slowdown in m_riemann_solvers? if so, can you confirm it is associated with this subroutine by using nvtx statements (which will tell you how much time is spent in certain code regions when you perform a profile with Nsight Systems).

This is very odd...I just ran master and conversions_update on Phoenix SLURM, and the times were nearly identical! (28s vs 29s) I'll run it again tomorrow to make sure it's not a big slowdown.

Please also check on an older commit as well.

@sbryngelson Tested on a week-old commit. Still 28s.

Great. Can you do an nsight systems profile to check the proportions of which kernel takes however much time? Reimann solvers and WENO should be similar. This is useful information regardless, since I'm not sure the last time we did such a profile. In the future it will be in the CI workflow.

As expected, this branch and master are basically identical in benchmarking.
Benchmark
Test 1:

My Branch: 2.93e-2 s/timestep
Master: 3.04-2 s/timestep

Test 2:

My Branch: 1.57e-2 s/timestep
Master: 1.58e-2 s/timestep

These are 3D cases run on 2 V100s on Phoenix. I think this PR is good to go, I'll just compress it.

@henryleberre can you please have a quick review of this


Duplicate view non functionnal

When I duplicate a view, the duplicated view is empty and there is no error message
Version of Archi
5.3.0
Operating System
Windows
Expected Behaviour
view is duplicated including all elements
Actual Behaviour
Duplicated view is empty
Steps to Reproduce the Behaviour

select a view with some element
Duplicate view

Sorry, it was just a display issue


Scrapper support for datetime based scrapping instead of date

Fixes #63

Changes:
--num-days changed to --num-hours

Closing as planned to move to graphql based scrapping.


Icon notification still present after all messages read....

Please search to check for an existing issue (including closed issues, for which the fix may not have yet been released) before opening a new issue: https://github.com/k9mail/k-9/issues?q=is%3Aissue
Expected behavior
Tell us what should happen
Actual behavior
Tell us what happens instead
Steps to reproduce

Environment
K-9 Mail version:
Android version:
Account type (IMAP, POP3, WebDAV/Exchange):

I think, what the main author wanted to say is, this:

I have an IMAP account
When new messages appear, the new mail notifcation is shown.
When I mark the messages as read on another client, the message count in the laucher icon is updated. As well as the status of the messages in the message list.
But the new message notification still lingers in the notification bar.

Same with pop3 account...
Le 11 août 2017 08:36:39 GMT+02:00, huste<EMAIL_ADDRESS>a écrit :

I think, what the main author wanted to say is, this:

I have an IMAP account
When new messages appear, the new mail notifcation is shown.
When I mark the messages as read on another client, the message
count in the laucher icon is updated. As well as the status of the
messages in the message list.
But the new message notification still lingers in the notification
bar.

--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/k9mail/k-9/issues/2551#issuecomment-321740682

Luc
+33 6 73396660
Envoyé de mon téléphone Android avec K-9 Mail. Excusez la brièveté.

Most likely caused by the same underlying issue as #1921


Labels too close to the chart

Hello,
I am experiencing an issue where the labels are too close to the chart such that the text is clipping into the chart. There is enough view space for the text to be further apart but for some reason it doesn't do that. I also didn't find any way to change the label distance from the chart in the docs. Please add this option.

Hello, Thank you for opening the issue.
Added labelDistance prop to adjust the distance between labels and charts. Additionally, by adding the scale prop, you can adjust the size of the chart so that labels are not cut off within size.

Thank you for the quick update!

I forgot to build it. I published again. Thank you.


Material Parameters Problem

Dear David,
In the TwistingCube part, the E is [1,25] in your code(as well as your article) , what's the unit of E ?
We are tring to perform the steel matertial with E = 210e9. The problem is the train_loss is very huge

How to solve this problem?
Another question is the loading of each part seems the same. If I want to change the loading, what can I do? Should I retrain the model, which is timeconsuming.
Thank you very much!

By the way, since there are only three files in the simulation folder (displacement, theta, pe-values), whether the size of the model was changed when testing the model？

Hi there,
I'm not actually sure what units / scale are - I took this example straight from the FEniCS documentation here, where the units/scale aren't specified.
Regarding the loading value - the best thing to do is to give this value as an input to the emulator along with the material parameters, so that the GNN can generalise to different values without retraining. One thing to note on that - in the paper, I included material parameters after the message passing stage. You might want to try including this information (and the loading value) with the node features, which should give better accuracy.
It was however an unfortunate oversight on my behalf that I wrote the code assuming the loading value would be fixed (see for instance the fixed value external_forces.surface_force  on line 166 of this file). You will need to make updates to allow this value to vary during training.
Finally, yes, I did change the size of the model, but I only put one dataset online. Simulations for different mesh sizes can be run by a slight adjustment of the FEniCS code at the same link from above. I have also made available post-processing code to get raw FEniCS simulation data into a format suitable for the GNN in this notebook here.
Thanks,
David

Thank you very much for your reply, but I still have a couple questions that I haven't figured out yet:

when I need to change the model size, do I need to retrain the model?

on page 11, section 3.1 part of your paper, you set the Young's modulus to [5-10] kPa. But in the constuctive_law.py of your code (TwiceClamepedBeam), the range of E is [5e5, 10e5]. I would like to ask what should be the units here?

I tried the following simulation: a square film made of a linear elastic material with four fixed surfaces, front, back, left and right, with a uniformly distributed pressure applied to the upper surface.
I tried to modify the constitutive_law.py file to use the linear-elastic material, and modeled the data processing after your FenicsMeshProcessingLV.ipynbfile, which generates pressure-surface-facet.npy. But the error tends to drop from a few tens of millions as I train, the and jumps a lot throughout, and also the final prediction is completely different from the real value. Have you encountered similar problems?
Here's part of the code I modified in the constitutional_law.py file:

def LinearElastic(params, F, J, fibres=None):
    """Linear Elastic strain energy density function

    Inputs:
    -----------
    params: jnp.array
       Material parameter vector (E, nu)
    F     : jnp.array
       Deformation gradient
    J     : jnp.array
       Determinant of F
    fibres: None
       Not used here as we assume isotropic material

    Returns:
    ----------
    sed: float
       Strain energy density
    """

    # Extract material parameters
    E, nu = params

    # Convert to Lame parameters
    mu = E / (2 * (1 + nu))
    lambda_ = E * nu / ((1 + nu) * (1 - 2 * nu))

    # Right Cauchy-Green tensor
    C = jnp.matmul(F.T, F)

    # Green-Lagrange strain tensor
    E_tensor = 0.5 * (C - jnp.eye(3))

    # First invariant of the strain tensor
    I1 = jnp.trace(E_tensor)

    # Second invariant of the strain tensor (needed for the quadratic term)
    I2 = 0.5 * (jnp.trace(jnp.matmul(E_tensor, E_tensor)) - I1 ** 2)

    # Strain energy density function for linear elasticity
    sed = 0.5 * lambda_ * I1 ** 2 + mu * I2

    return sed

constitutive_law = LinearElastic

By the way, could you please give me a copy of the FEniCS code for the TwiceClampedBeam model? I would like to try to reproduce your model, but it is missing for example the density parameter.


Feature/payment

payment and payment manager are nearly complete.

You might want to take a look at my RoomServiceOrder class on the function MenuItemtoString, so you may amend the printout for the GenerateAndPrintBill() later on if that's found to be useful. I have no issue with the merging.

I've incorporated it in my code!


Deploy Reference Documentation (ALDoc) failed with custom

After my first deployment of the reference documentation, I noticed on the page following:

So I created a .aldoc/index.md file for a customized documentation.
In the CIDC workflow I get this error message now:
Error: Unexpected error when running action.
Error Message: An item with the specified name D:\a\customera\app1\.aldoc already exists., StackTrace: at
<ScriptBlock>, D:\a\_actions\microsoft\AL-Go-Actions\v4.1\BuildReferenceDocumentation\BuildReferenceDocumentation.ps1: line 50
 <- at <ScriptBlock>, D:\a\_temp\88d7209d-3ee8-46dc-bfce-5[35](https://github.com/louagej/app1/actions/runs/7798807399/job/21268832542#step:6:37)cd4e32e83.ps1: line 4 <- at <ScriptBlock>, <No file>: line 1
Error: Process completed with exit code 1.

Sounds like a bug - will investigate


Handle rotation better

It should be possible to preserve the relative position of calipers with rotation by exchanging X and Y axes and calculating relative positioning by multiplying by ratio of height and width.  Specifically, for example, if bar1Position in portrait view is X, then bar1Position in landscape view will be
(X/portrait-view-width) * (landscape-view-width)
with landscape-view-width = portrait-view-height.  Same type calculations for the crossbar and bar2.
This applies to rotating versions of EP Calipers (iOS and Android).

This has been fixed in all versions.

This has been fixed in all versions.


CI: adding rendering for local CI

While we deploy this documentation along with the notebooks, I think it would be useful to have a CI job here, too to show how the content would render.
We can then also add other checks relevant to narrative documentation, e.g. linkchecking on the URLs, spellchecker, etc.
(My main motivation to get this is sooner rather than later to have a preview for #39 where I wasn't confident if the code blocks would require extra empty lines around the block or not for rendering)

Note: this needs to be merged to get any effect, so I go ahead and merge, and then open a new PR with some minor fixes to see if all works as expected.


LG_SIZEOF_LONG should always be 2 on Windows

In jemalloc_internal_defs.h, sizeof(long) is always 4 on Windows no matter x86 or x64 is targeted.
BTW, _WIN32 is defined for both x86 and x64 targets. So _WIN32 alone cannot be used to distinguish the target.

You are right, maybe can change the order of _WIN64 and _WIN32's marco.

Any plan to follow latest jemalloc(4.0.4)?

Just remove the #elif defined(_WIN64) || defined(_M_X64) block, it is never used anyway (which is good because it contains wrong values!!! :)

This project isn't really needed anymore, since jemalloc now has official support for Visual Studio 2015.

@rustyx
Thanks for your notice.


Refactor tests

I had to make some changes to get the test suite running on my local machine.
I think the airbrake import relies on some credentials you have on your local machine for example.
Let me know what you think 😄  I'll add some more tests when this gets merged in!

Hey Matthew! Great! PR. We are getting some errors on travis so I'll guide you through this PR because I think it simplifies a lot our testings.

I think we also need to stop relying on Airbrake, because it is juts not helping at all so good.

Could you also create an Issue that references this PR please! @MrPowers

@FavioVazquez - Thanks for the comments.  I pushed up another PR to address your feedback.  Let me know if I missed anything or if you have any additional feedback.  Thanks!

Amazing @MrPowers! This fixes all the problems. Don't worry about the travis error because is just a SonnarQube error. All the tests passed.


Unable to add reaction to any message

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open any report
Click on any reaction emoji

Expected Result:
User is able to add emojis
Actual Result:
Unable to add emoji to any message
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.2.87-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679340319741179
View all open jobs on GitHub

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

This is more of an API deploy blocker https://github.com/Expensify/Expensify/issues/267361 if you switch to production API the issue is gone, I think we can close this since the deploy blocker is in Web-E and not in App

Ok, I'm going to close this out for now.


cache problem

The .appcache file is served with a "Cache-Control: max-age=0" header so that browsers will always check whether there's a newer version. The .appcache file contains an md5 hash in a comment which is generated based on the file contents in the RWB directory. The effect should be that whenever RWB code or data changes, browsers update their app cache. However, there's a problem. The cached page is itself cached by the CDN. This means that in some instances the browser will reload the application cache but will replace it with a cached version (at the CDN level) of the older page. When the CDN version is replaced, the application cache no longer will refresh it.
Thinking about solutions..

Attempting a fix to this by including the hash as a query parameter to the app cache file. If the hash sent from the cached page does not match the hash of the app cache file, the app cache file will output a timestamp to force an update. This should make the browser attempt to load a new version until it gets one which matches the app cache file.

Seems to be working


Added a Social Media Button and Added a Timing Section in Website

I have Added a Social Media Button and Added a Timing Section in Website.

It is very important to have many contact and social media links in website.
It is also important to have Timings details specially in Health website.

Thank you so much.

Please check my contributions.

Thank you for your response.
On Wed, 5 Oct 2022, 1:00 AM Ishita Kapoor, @.***> wrote:

Merged #99
https://github.com/ishitakapoor26/HealthBliss-Hacktoberfest2022/pull/99
into main.
—
Reply to this email directly, view it on GitHub
https://github.com/ishitakapoor26/HealthBliss-Hacktoberfest2022/pull/99#event-7519666098,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZE3GGXCUC2LV4HAB44DHULWBSEGTANCNFSM6AAAAAAQ4VVYBM
.
You are receiving this because you were assigned.Message ID:
<ishitakapoor26/HealthBliss-Hacktoberfest2022/pull/99/issue_event/7519666098
@github.com>


New version?

Hi,
Number of features have been added since 0.2.1 -- should there be another release? I can't use git dependency if I want to publish hal-impl to crates.io.
Are there any guildelines regarding versioning? Seems like any new feature merged to master should bump patch level, otherwise hal-impl can't really use them.

I agree both with the idea of bumping the version with each change and to have a new release soon.

What about releasing new version with revised list of unproven features?

I'd like to push a new version once we've landed #101, #102 and #105 (hopefully shortly), which will be an 0.X release (specifically 0.3.0) due to breaking changes, any comments @rust-embedded/hal ?

The falible digital traits PR (#105) is breaking

Right, but I was hoping we would release a non-breaking 0.2.2 before pulling that in.

Fine by me, we need more reviews on all the linked PRs so once 101 and 102 are reviewed and merged we can release an 0.2.3 then land 105 and 0.3.0.

I can see people wanting to stay on 0.2.x until all crates are ready for 0.3 which will take a while and the request to prove traits has been an elephant in the room for quite a while even longer than this ticket which is also is a few months old now.

I understand that people want proven traits, but I question the point of declaring traits with known issues proven, then breaking them due to those known issues.
Yes, it sucks that those traits have known issues, and that we have to make breaking changes to fix those known issues. I don't see how declaring those traits proven right before making those breaking changes benefits anyone.
I understand that those users who want the traits proven might stay on 0.2.x for a while. I don't see how not having to enable the unproven feature during this time benefits them. They'll have to fix their implementations when upgrading to 0.3 in any case. Declaring those traits proven will remove a minimal obstacle to using them (enabling a feature) at the cost at confusing people about the future stability of those traits.
But as I said previously: I'm not making a stand here. It's not what I would do, but if you want to merge #102, go ahead.

I understand that people want proven traits, but I question the point of declaring traits with known issues proven, then breaking them due to those known issues.

I'd like to see that we're sticking to the rules which were once decided (or change them).
Regarding the "issues" and breaking the traits in the next version: When the "digital" traits were conceived they were meant to cover regular GPIOs and operations on those usually can not fail so it didn't make sense to have them fallible. In hindsight it should have been clear that IO expanders and multiplexers exist (especially since people including me have used them in the past) and that someone will eventually come up with a driver.
I am no and (most likely never will be) a fan of replacing the previous digital traits with fallible versions of it under the same name because the old traits are widely used and the fallible ones are really only required for a few new and special use cases. This change will split the whole Rust "full-stack" embedded ecosystem in two and I have serious doubts that it'll quickly recover. This is a huge risk and could potentially cause a lot of harm. Hence I really prefer a separate set of traits which would be non-breaking and allow fallible and non-fallible versions to co-exist (and even better to be used at the same time) and phase out the old traits much later.

I understand that people want proven traits, but I question the point of declaring traits with known issues proven, then breaking them due to those known issues.

I'd like to see that we're sticking to the rules which were once decided (or change them).

Let me take a step back here, because I think it's important we're all on the same page:

#102 proposes to mark InputPin proven, with 2 participating team members being in favor, 1 (me) arguing against.
In #100, I proposed making the digital trait changes a clean break, which has been met with +1's and no opposition.

The combination of those two things is what I'm arguing against, because I think it makes no sense. But I don't think the combination of these two things is what you're arguing for. You want to go forward with #102, but you don't want to break the digital traits.
Let's revisit my proposal to make the digital changes a clean break. I proposed this because I started feeling bad about that pull request, and didn't want it turning into one of these months-long affairs, where the contributor is changing stuff again and again, due to changing reviews with ever new insights. Due to the response there (+1's, no opposition), I assumed that we'd be doing this.
I think I was wrong in at least one, possibly two ways. First, your comment has almost got me convinced that my proposal was wrong, and that we shouldn't do a clean break here. Second, even if I was right, it was wrong of me to assume we were going with this proposal after just a few days without opposition. I should have given you and others more time to respond.
So, if we won't break the digital traits, #102 makes a lot more sense. The digital traits can become proven (and possibly, at the same time, deprecated), while we go forward with a second set of traits. That's something I can get behind.
The question remains is how exactly we're going to transition (or whether we're going to transition at all). I think you're saying you might want to have two sets of traits in perpetuity, but I think that is not a workable solution, as I've previously explained.

I am no and (most likely never will be) a fan of replacing the previous digital traits with fallible versions of it under the same name because the old traits are widely used and the fallible ones are really only required for a few new and special use cases. This change will split the whole Rust "full-stack" embedded ecosystem in two and I have serious doubts that it'll quickly recover. This is a huge risk and could potentially cause a lot of harm. Hence I really prefer a separate set of traits which would be non-breaking and allow fallible and non-fallible versions to co-exist (and even better to be used at the same time) and phase out the old traits much later.

 I still think my proposal ([1], [2]), which is possibly the same as your proposal, is the best way to go here. @ryankurte is not convinced, though :)

I'm definitely less thinking of "in perpetuity" than a couple of months or a year. Having both traits side by  side would allow for a smooth transition (and as mentioned previously it's even possible to bridge between the fallible and non-fallible interfaces even without losing anything in the common case of MCU GPIOs) and then we can easily phase out the old traits. New drivers for multiplexers etc. could easily offer just the new traits thus softly nudging users to change the HAL impls and their software...
In cases like this (where I have two dozens of affected published crates and many more unpublished) I'm always considering how much pain it would cause me to have such breakage (and it would be immense!) and then I also have to consider when to make the change and how much pain it would cause to all users (or how many would then rather not take the new version and stay with the old one...). I'm not even sure how many GPIO examples we have in official documentation which would all require changing and big fat disclaimers and explanation of the two alternatives and how to choose...

I'm definitely less thinking of "in perpetuity" than a couple of months or a year.

Great, that's totally in line with what I'm thinking. I think our next step should be to reach consensus on a transition strategy in #100. I've gone ahead and blocked #102 and #105 until then.

In that case, what would y'all think of a 0.2.2 release from the current master?

(sorry, after landing 101)

@ryankurte Fine by me.

Now that 101 has landed, I'd love to get a new version published. :)

Looks to me like we need a PR with an updated changelog including all the changes introduced since v0.2.1 (looks like we need to be better at merging those as part of PRs) and a version bump in Cargo.toml. If you'd like to do that, it might speed up the process, otherwise one of us will hopefully have some time soon ^_^
@therealprof this action is exactly equivalent to my proposal in #100, see how it goes I guess?

Operational comment: dont forget to do the semver trick to allow interoperation between 0.2.2 hal-impls / drivers and 0.3.0 drivers / hal-impls, at least for the traits that didn't change between the two versions.

hi folks,
we've landed all the changes for fallible pins, which as far as i can see is currently non-breaking and only adds to the API (v1 is re-exported by default but marked depricated, v2 must be explicitly selected), which i think means we can consider this a minor release?
as an aside, running cargo semver over master highlights a set of errors on the serial module that i'm not sure about / probably need to be resolved prior to shipping anything, any ideas what this means?
error: breaking changes in `read`
  --> /home/ryan/projects/embedded-hal/src/serial.rs:14:5
   |
14 |     fn read(&mut self) -> nb::Result<Word, Self::Error>;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = warning: type error: expected enum `nb::Error`, found a different enum `nb::Error` (breaking)

@ryankurte Definitely a minor release since we're not at 1.0 yet. However I have a feeling you have a slightly different understanding of minor. This is going to be 0.3.0 and we should revisit anything that should be added for that.

as an aside, running cargo semver over master highlights a set of errors on the serial module that i'm not sure about / probably need to be resolved prior to shipping anything, any ideas what this means?

Who knows? 😅

@therealprof ahh good catch, s/minor/patch/g in my previous post, are there outstanding changes that require the planned minor bump over a patch release given the digital::* stuff is no longer breaking afaik?
Seems to me we only have additions so far, though we could switch the default pin implementation to v2.
also are there any other things we particularly want to land before a release?

Good question. But due to the intrusive nature of this chance I'd probably rather make it a minor release instead, even if not technically necessary.

@therealprof

Good question. But due to the intrusive nature of this chance I'd probably rather make it a minor release instead, even if not technically necessary.

That doesn't seem like a good reason enough to me. Incrementing the minor version will split the ecosystem, unless we do the manual work required to do the semver trick.
I mean, if you volunteer to do that work, then I don't mind, I guess. Still, there'd be a chance of you missing something and causing breakage. Seems like an unnecessary risk to me.

@hannobraun If you say so. My worry is more on the side of accidentally breaking existing applications than requiring an explicit opt-in to a new version.

Well, I think both ways have a risk of accidentally breaking applications. My way could introduce an unintended breaking change, your way could accidentally split the ecosystem. In both cases, the solution would be to release a fix and yank the offending crate. I prefer my way because it's simpler and less work.
But if we're going to release a new minor version anyway, I think we should switch the default gpio implementation to v2, as @ryankurte suggested.
In any case, I don't feel very strongly about this right now, so feel free to go ahead in whichever manner you think is best :-)

-wonders whether we could convince crater to regression test hal changes-
seems like it should be possible / could be valuable for us longer term, but, documentation is incredibly lacking

ooh, what about a patch pre-release as a reasonably low effort middle ground? no changes by us (and thus a decreased chance of Maintenance Induced Failures), opt-in testing, and if we haven't had any reports of failures after a while we could then push a normal release.

@ryankurte Is there a mechanism for that?

i've definitely seen prereleases in use and on further research it's supported by semver but i can't parse from this issue or seem to find any docs about how cargo handles it ¯_(ツ)_/¯

I'm fine with playing guinea pig here to unblock this.

a quick test with this suggests that cargo won't auto-update from 0.1.0 to 0.1.1-alpha.1, which seems okay.
just to be clear, is that an ack on publishing a pre-release? (also any thoughts about calling it an -rc release so it's easy with cargo-release?)

@rust-embedded/hal
Do we want to test the waters of the new version with a pre-release of the crate?
Ticky-boxes for the win:

[x] @ryankurte
[ ] @hannobraun
[ ] @thejpster
[ ] @ithinuel
[x] @therealprof

Please do whatever you think is best. As I already stated, I'd just do a patch release, but I didn't mean to block any decision here, and I apologize if I gave that impression.

@ryankurte Are we happy with this now?

i've been using 2.3-rc.1 for a while, but, turns out the -rc.X releases are not considered compatible by cargo so i haven't managed to test interop in a meaningful way :-(
that said, i think i'd be happy to release it and yank/fix if anything unforeseen crops up (partly because i'm not really seeing another option).

@ryankurte Let's release it.

aand 0.2.3 is published and released. thanks for all your efforts!


Update index.css

added bgcolor darrk and text color white

we are not going on this type of UI , you can make more tiles in the page with a consistent design so we can have a stable codebase. kindly look into it so we can discuss on this in the discussion page
@AnantInamdar77


Main Add WBTC asset n MEME price

-Add axlwbtc to chain info so it will look okay on it's pools, but not to Assets page
-Add Meme price to main so its pool reflects accurate liquidity

Confirmed with generated build that Pool 701 OSMO/MEME and 712 OSMO/WBTC look correct now.


Add methods to BeanConfigurator for applying decorators

Currently when adding a Bean<T> using jakarta.enterprise.inject.spi.AfterBeanDiscovery.addBean() or jakarta.enterprise.inject.spi.AfterBeanDiscovery.addBean(Bean<?>) any decorators declared or programatically added for the types of the Bean<T> are not automatically applied.
Not only is this perhaps surprising, there actually is no portable way to achieve this behaviour. Someone adding a bean must resort to SPIs and implementation specific code. For instance Soteria uses the following code:
afterBeanDiscovery.addBean(
    decorator.decorateBean(authenticationMechanismBean, HttpAuthenticationMechanism.class, beanManager));

Source
Where decorator.decorateBean is an SPI, that for Weld uses code such as the following:
public class DecorableWeldBeanWrapper<T> extends RIBean<T> implements Bean<T>, PassivationCapable {

    private final Bean<T> bean;
    private final CurrentInjectionPoint currentInjectionPoint;
    private final boolean isProxyable;
    private Class<T> type;

    private List<Decorator<?>> decorators;
    private Class<T> proxyClass;
    private boolean proxyRequired;
    private boolean isPassivationCapableBean;
    private boolean isPassivationCapableDependency;

    public DecorableWeldBeanWrapper(Bean<T> bean, Class<T> type, BeanManagerImpl beanManager) {
        super(
            bean,
            new StringBeanIdentifier(BeanIdentifiers.forBuiltInBean(beanManager, type, null)),
            beanManager);

        this.bean = bean;
        this.type = type;
        this.currentInjectionPoint = beanManager.getServices().get(CurrentInjectionPoint.class);
        this.isProxyable = Proxies.isTypesProxyable(getTypes(), beanManager.getServices());
    }

    @Override
    public void initializeAfterBeanDiscovery() {
        decorators = beanManager.resolveDecorators(getTypes(), getQualifiers());

        if (!decorators.isEmpty()) {
            proxyClass = new ProxyFactory<T>(getBeanManager().getContextId(), getType(), getTypes(), this).getProxyClass();
        }
    }

    @Override
    protected void internalInitialize(BeanDeployerEnvironment environment) {
        proxyRequired = getScope() != null && isNormalScoped();
        isPassivationCapableBean = Serializable.class.isAssignableFrom(type);
        isPassivationCapableDependency = isNormalScoped() || (isDependent() && isPassivationCapableBean());
    }

    @Override
    public T create(CreationalContext<T> creationalContext) {
        T instance = bean.create(creationalContext);

        if (decorators.isEmpty()) {
            return instance;
        }

        return getOuterDelegate(this, instance, creationalContext, proxyClass, currentInjectionPoint.peek(), getBeanManager(), decorators);
    }

Source
This code is difficult to come up with, difficult to maintain and error prone. The user must also make sure the right companion SPI implementation is available on the class path.
To simplify this, I'd like to propose a method for BeanConfigurator to signal to the runtime that enabled decorators should be applied to the instance returned from the Bean.create (`Contextual.create') method, just like happens for beans which implement the bean types directly and are discovered by CDI.
For instance:
public void afterBean(final @Observes AfterBeanDiscovery afterBeanDiscovery) {
        afterBeanDiscovery
            .addBean()
            .scope(ApplicationScoped.class)
            .types(MyBean.class)
            .id("Created by " + CdiExtension.class)
            .enabledDecorators()
            .createWith(e -> new MyBeanImpl("Hi!"));
    }

Several variants could be considered, like e.g.:

addEnabledDecorators()
decorators(Decorator<?>... decorators)
addDecorators(Decorator<?>... decorators)

We need to take a look at whether we can lift the spec restriction of not applying decorators to producers and synth beans https://jakarta.ee/specifications/cdi/4.0/jakarta-cdi-spec-4.0.html#decorators
If that doesn't work, we can at least take a look at having an API/SPI that will allow this explicitly for a given synth bean.

As per discussion during last CDI mtg (Dec 5), I am closing this issue.
It has been stale for three years now indicating that there isn't much interest nor are there any takers to submit proposal or impl drafts for this feature.

@manovotn can you re-open? I actually was working on a PR for this, but with the M1 deadline for security and such didn't had time to push it out yet.
This is still as important as before. Every spec (or library) that provides build-in beans via an Extension needs this, as those provided beans can not be decorated now. It seems there's no interest, but there is. People do run into this, but (almost) nobody understands that this issue is the root cause.
I think it's also somehow a testimony to us (as spec creators, including the other specs) failing to educate both our users and ourselves.

Thanks @starksm64


Wishlist is not working

Describe the bug
Wishlist is not working with message below
Screenshots

To Reproduce

Go to 'Shop home'
Mouse over the product and click heart icon

Desktop (please complete the following information):

OS: Windows, xampp dev. env.
Browser : chrome
Version : latest version 88.0.4324.150 (Official Build) (64-bit)

Additional context

When running a server using 'php artisan', it is working - PHP 7.4.6 (cli) (built: May 12 2020 11:38:54) ( ZTS Visual C++ 2017 x64 )
However, when it is running on apache server, above error occurs. - PHP 8.0.0
There is no error message in a log file in storage/logs

Use php composer.phar update s-cart/core  or download lasted full source.


Taking over as maintainer

Hello,
I would like to take over as the (temporary) project maintainer. As the last release was just two weeks ago, I hope the old maintainers are still around. @thomaskrause @sdruskat ?
Would you be so kind to grant me administrative rights for the project repository?

Hello,
thanks for taking over maintainership! I have made you the owner of the organization, which should also give you ownership over all repositories including this one.


Add invite-to-call to LOS (WIP)

Adds functions to invite to a jitsi call to LOS

following issue needs to be solved:
https://github.com/OpenSlides/openslides-icc-service/issues/30
following PR has to be merged:
https://github.com/OpenSlides/OpenSlides/pull/6305

Admin A who invites user B gets also the invite dialog.

Fixed it. Apparently the sender of ICC messages will always receive a copy of their own messages.

user B gets in every tab the invite dialog. After accept this all dialogs in other tabs should closed.

This might not be easy atm. indexedDB cannot detect changes on another tab, see
https://github.com/cyrilletuzi/angular-async-local-storage/issues/386
There is this browser API ( https://developer.mozilla.org/en-US/docs/Web/API/Broadcast_Channel_API ), but it seems to fairly new ( https://caniuse.com/?search=Broadcast )
I'll have a look at it.

Now with broadcast.service.ts for real time inter-tab-communication


Hash node Clone

🛠 Fixes Issue
Closes #499

👨💻 Changes proposed

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

This branch is 1 commit ahead, 10 commits behind Rayman-Sodhi:main.


Query about transitive closure for over regulates for MF by default

De we want to include regulates_closure for molecular function?
This give weird results. For instance if I search for all of the gene products with
"protein kinase activity" for pombe, the list includes
protein kinase activators and inhibitors like cig2 and rum1.
I think most people would find this misleading.
Val

This is most likely mostly a question for @cmungall (and @hdietze), as the best place to make any change along these lines would probably be during loading.

The general framework here would be to have the default closure field depend on the focus class. This will be required in any case for #201
E.g.

c in MF

Question: which gene products enable c?
isa_partof_closure
Why: enables o SubClassOf -> enables

c in BP

Question: which gene products are involved in c?
regulates_closure
Why: enables o (part_of|regulates) -> involved_in

c in CHEBI

Question: which gene products are involved in a process that have c as participant?
involved_in_o_has_participant_closure (see #201)
Why: enables o (part_of|regulates) o has_participant -> involved_in_o_has_participant

etc
Of course, the boundary between MF and BP can be arbitrary. Question for @ValWood -- what would you want the default behavior for protein phosphorylation to be? On the one hand, it's the exact same thing as with protein kinase acticity. However, there is an implicit difference in question, and I think GOC members would want kinase gene sets to exclude regulatory and phosphorylation gene sets to include regulatory. Is this just a GOC expectation? What would a wider cross-section of biologists think? Something for @dosumis to think about in the MF refactoring. Whichever way we model things, AmiGO provides the framework to answer the questions in a sound fashion.

#267 seems to be a reformulation.

@kltm correct, looks like I repeated myself: https://github.com/geneontology/amigo/issues/267#issuecomment-152879983
My fault, should not be using the tracker as a substitute for proper requirements documentation.
TL;DR: choose the default closure type based on the type of term. We should also do more to makethe reasoning more transparent and intuitive.


Communication Error when upload file object to netstorage

We have multiple threads to upload files simultaneously to netstorage from two different hosts.
Most of the time it performs well, but sometimes it will throw Communication Error.
Is there any enhancement related to it in the TODO list?

TODO: support rebinding on IO communication errors (eg: connection reset)
--
  | * TODO: support async IO
  | * TODO: support multiplexing of uploads
  | * TODO: optimize and adapt throughput based on connection latency
  | * TODO: support HTTP trailers for late SHA256 validation

Caused by: com.akamai.netstorage.NetStorageException: Communication Error
at com.akamai.netstorage.NetStorageCMSv35Signer.execute(NetStorageCMSv35Signer.java:359) ~[NetStorageKit-3.6.6.jar:?]
at com.akamai.netstorage.NetStorageCMSv35Signer.execute(NetStorageCMSv35Signer.java:364) ~[NetStorageKit-3.6.6.jar:?]
at com.akamai.netstorage.NetStorage.execute(NetStorage.java:68) ~[NetStorageKit-3.6.6.jar:?]
... 141 more
Caused by: java.net.SocketException: Socket closed
at java.net.SocketInputStream.socketRead0(Native Method) ~[?:1.8.0_232]
at java.net.SocketInputStream.socketRead(SocketInputStream.java:116) ~[?:1.8.0_232]
at java.net.SocketInputStream.read(SocketInputStream.java:171) ~[?:1.8.0_232]
at java.net.SocketInputStream.read(SocketInputStream.java:141) ~[?:1.8.0_232]
at sun.security.ssl.InputRecord.readFully(InputRecord.java:465) ~[?:1.8.0_232]
at sun.security.ssl.InputRecord.read(InputRecord.java:503) ~[?:1.8.0_232]
at sun.security.ssl.SSLSocketImpl.readRecord(SSLSocketImpl.java:975) ~[?:1.8.0_232]
at sun.security.ssl.SSLSocketImpl.readDataRecord(SSLSocketImpl.java:933) ~[?:1.8.0_232]
at sun.security.ssl.AppInputStream.read(AppInputStream.java:105) ~[?:1.8.0_232]
at java.io.BufferedInputStream.fill(BufferedInputStream.java:246) ~[?:1.8.0_232]
at java.io.BufferedInputStream.read1(BufferedInputStream.java:286) ~[?:1.8.0_232]
at java.io.BufferedInputStream.read(BufferedInputStream.java:345) ~[?:1.8.0_232]
at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:735) ~[?:1.8.0_232]
at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:678) ~[?:1.8.0_232]
at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1593) ~[?:1.8.0_232]
at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1498) ~[?:1.8.0_232]
at java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:480) ~[?:1.8.0_232]
at sun.net.www.protocol.https.HttpsURLConnectionImpl.getResponseCode(HttpsURLConnectionImpl.java:352) ~[?:1.8.0_232]
at com.akamai.netstorage.NetStorageCMSv35Signer.validate(NetStorageCMSv35Signer.java:270) ~[NetStorageKit-3.6.6.jar:?]
at com.akamai.netstorage.NetStorageCMSv35Signer.execute(NetStorageCMSv35Signer.java:348) ~[NetStorageKit-3.6.6.jar:?]
at com.akamai.netstorage.NetStorageCMSv35Signer.execute(NetStorageCMSv35Signer.java:364) ~[NetStorageKit-3.6.6.jar:?]
at com.akamai.netstorage.NetStorage.execute(NetStorage.java:68) ~[NetStorageKit-3.6.6.jar:?]

Any update to this or an example using it with Spring Integration. multi threaded application. is this meant to be used in a multi threaded environment. I can't create a singleton because I might have many uploads to different NetStorage environments. I create a NetStorage object when needed at the beginning of a task and use that through out the life of the task. there could be multiple tasks started.


Introduce conditional delete before replace for select resources

Consider introducing conditional delete-before-replace plans that would suggest to that Pulumi should delete first, and create later when replacing a resource when particular sensitive properties change.
Affected resources:

google_compute_global_address
google_compute_instance
google_compute_vpn_tunnel
google_project_iam_member
google_service_account_iam_member

We tried enabling delete-before-replace as the default strategy for these resources but decided to revert his behavior as it may not be appropriate for all users, for example for the compute instance resource, delete-before-replace may reduce liveness/availability and are not ideal for every update, see:

https://github.com/pulumi/pulumi-gcp/pull/2586
https://github.com/pulumi/pulumi-gcp/pull/2588

Instead of doing that, the suggestion is to identify the specific properties that require this treatment, build the bridge support so allow specifying this behavior per-property, and rolling forward:
https://github.com/pulumi/pulumi-terraform-bridge/issues/2605
References
#73
#190

Do we know if all of these resource require a Conditional DeleteBeforeReplace? Would some of them be fine with unconditional DBR?

The task includes investigating which properties or resource-wide DBR is appropriate for each of these.


The library doesn't use Levenshtein at all, or at least it's inconsistent

This library is described as fuzzy string matching with Levenshtein distance. However, it doesn't seem to use Levenshtein at all?
fuzz.ratio("tide", "diet") returns:

50 with python-Levenshtein installed
25 without python-Levenshtein

This is because python-Levenshtein uses Indel distance for ratio instead of Levenshtein. Issue 47 in python-Levenshtein mentioned that "Levenshtein.ratio is based upon the Indel distance and not on the Levenshtein distance". (That's the correct repo I think). Indel distance is similar to Levenshtein, but they are not the same and may produce different results.
But it doesn't seem to just end there. difflib, the fallback for when you don't have python-Levenshtein installed, doesn't seem to use Levenshtein distance either. Issue 128 in the older repository/version of this package mentioned that difflib uses "Ratcliff-Obershelp algorithm, not the Levenshtein distance".
To conclude:

This library doesn't seem to use Levenshtein distance at all.
Installing python-Levenshtein doesn't just simply give speed up. It will produce different results because different algorithms are used.

Note: This library uses ratio function from Levenshtein package or difflib for all of its function with ratio in its name.

Note that the Indel distance is the same as the Levenshtein distance with substitutions weighted as 2. Still I agree this is misleading. I think to a part this stems from python-Levenshtein, where Levenshtein.distance calculates the Levenshtein distance, but Levenshtein.ratio calculates the normalized Indel similarity (In my defense this was implemented before I became the maintainer of python-Levenshtein :sweat_smile: )

Note that the Indel distance is the same as the Levenshtein distance with substitutions weighted as 2.

Yeah, I also mentioned they're similar. Still, they're not the same.

I think to a part this stems from python-Levenshtein, where Levenshtein.distance calculates the Levenshtein distance, but Levenshtein.ratio calculates the normalized Indel similarity

Yup. I mentioned that too. I can't help but wonder why. The library is literally named Levenshtein. It could've been an option instead of the default, having "Indel" in the function name like it does for Jaro, or as an optional parameter.
Well, I think the readme should at least be changed to tell people about this. It's where they'd read first and it says "It uses Levenshtein Distance" at the very beginning.


IDNA support

/cc https://github.com/octodns/octodns/issues/199
/cc https://github.com/octodns/octodns/pull/903

Does this also handle IDN support in FQDN-type answers like CNAME and MX? Even TXT records? Or does octoDNS core take care of that?

Does this also handle IDN support in FQDN-type answers like CNAME and MX? Even TXT records? Or does octoDNS
core take care of that?

Heh. Nice catch. Was just going through the process of testing things and ran into the fact that it doesn't, and there are currently validation issues with utf-8 chars in record values.
Do IDN MX/SRV/NS records make sense? Even with CNAMEs the value people will see will be the encoded version since the DNS system itself doesn't know anything about the original utf-8 values and software likely wouldn't support running values in responses through their own decode/encode. octoDNS can definitely support it, I even have a not yet committed set of changes to octoDNS core to fix the validation issues.
It should be easy enough to encode/decode values here in NS so it probably makes sense to do it, my questions above are more thinking out loud about how the IDNA solution is kind of hacky in that it would let you think in utf-8, but when clients go to use it for anything "down the line" in values etc they'd be using/seeing the xn-... versions.

hrm, getting internal sever errors when I try and create dynamic CNAMEs with IDNA, specifically in the monitor create call:
{'active': True,
 'config': {'connect_timeout': 2000,
            'host': 'xn--zajzyk1-c9a.bar.com',
            'port': 443,
            'response_timeout': 10000,
            'send': 'GET /_dns HTTP/1.0\\r\\nHost: '
                    'cname.zajęzyk.pl\\r\\nUser-agent: NS1\\r\\n\\r\\n',
            'ssl': True},
 'frequency': 60,
 'job_type': 'tcp',
 'name': 'cname.zajęzyk.pl - CNAME - xn--zajzyk1-c9a.bar.com',
 'notes': 'host:cname.zajęzyk.pl type:CNAME',
 'notify_list': '62f29339f6491b0095148771',
 'policy': 'quorum',
 'rapid_recheck': False,
 'region_scope': 'fixed',
 'regions': ['lga'],
 'rules': [{'comparison': 'contains', 'key': 'output', 'value': '200 OK'}]}

I'm not 100% sure whether the Host header should use the utf-8 or idna version of the name (utf-8 makes more sense to me) but otherwise I don't see anything in here that should trip NS1 up. Maybe it doesn't like the -- in the host?  I'm going to poke around a little bit more, but if I don't figure out what's up quickly I make break this PR up into 2. The first adding IDNA support for "simple" records and then leaving dynamic record support for a later (more complicated) PR.

Or keep this even simpler with IDN support only for zone names and record labels. Leave value support for future when a use case actually arises 🤷♂

Closing this in favor of https://github.com/octodns/octodns-ns1/pull/22


Clarify Superset Version Number in the UI

Screenshot

Description
I've been seeing Superset users, at least once a week, get tripped by the fact that the Version number displayed in the Superset UI is always 0.999.0dev if people are using the latest tag or using bleeding edge master from Github.
Here's a recent user that was confused, wondering why they aren't on Superset v1.1: https://apache-superset.slack.com/archives/C0170U650CQ/p1616004990065000
Potential Solutions
Ideal User Experience:
It Just Works (TM). Wherever possible, show the real version (using the git sha as the 'data source') for this. No doubt this will require extra work, but this would enhance the first day / first week user experience!
Less than ideal but more helpful
Keep the git sha but remove the version number from the UI

this seems to be a highly requested change and will benefit all Superset users. @mayurnewase can you take a look? 🙏

In order to convenient debugging, not only add the current version but also show the commit hash here.

I'm not quite sure the best way to handle this, but I think the release maker script might be one option to set/bump this number in the file. It would still be overridable by orgs by changing the config of their deployment.

Let me review and test the PR by @mayurnewase this week so we can get it merged. I think the PR should work in most cases, but I just want to test a few more edge cases.

Not exactly the same issue but deeply related: It is also important to start support for versioned tags on official Docker images.
Not being able to pin down to a specific Superset (Docker image) version is really frustrating and insecure.

Having same problem where embedDashboard works on an earlier image and fails on the latest one with 403. How do I find the exact version of the earlier image?

I can see this issue still exists in the 3.0.0 release. Any chance of having this rolled out to the latest build? We really should be able to show the correct version in the front-end.

The 3.0 (or any) release should have the proper version number if you're running the actual release. Anything pulled from master is not an official version, so it will show a placeholder and a (hopefully) correct SHA.
Lately, it shows 0.0.0-dev as the placeholder. I wonder if we should just say "Unofficial Release" here or something, so people are less confused by it. Thoughts @kasiazjc @eschutho @michael-s-molina ?

Closing as stale... As I said about 9 months ago, we can replace the placeholder version with something else (e.g. just the SHA or "Unofficial") but that's about the best we could do. Anyone can bring the issue to a Town Hall sync or force the discussion via a PR or SIP if they'd like.


store & load comments using Datastore instead of using an ArrayList

I must have accidentally duplicated some of my commits--only the "store user comments via datastore" and "load user comments via datastore" commits were intended for this branch

I apologize I again somehow duplicated my commits on both branches--I will work to avoid this in the future. The commits that were intended for this branch are 'include Google AppEngine dependency' and 'update documentation comment'


Ensure image attachments are keyboard accessible

Context: https://github.com/microsoft/vscode/pull/230931#discussion_r1793888906

to verify:

must have the Vision for Copilot Preview installed
attach an image to chat
use Tab to navigate to an attached image
press Enter or click on the image to preview it in the editor.
Regular hover previews should be unaffected


provide onError props to logs any errors.

we decided to use onPathNotMatched props. this callback will gets an argument as follows:
{
    "message": "Error: path '/test' not matched",
    "details": "/test"
}

if you don't provide the props, it will crash the app with proper error message.


List the layers of an image

This is actually implemented already. Updating the command in #81 to use the new image reference though.


Profile page is responsive

The profile page is fully responsive .
Fixes #602

Give me Reply about this PR @arghadipmanna101

please give me a reply @arghadipmanna101


Error trying to run the code

I am trying to run the code in my system. I have followed the steps mentioned in the readme after cloning the code from here.
When I execute these

catkin_make --cmake-args -DCMAKE_BUILD_TYPE=Release
sudo rosdep install -y -i --from-paths ./src

commands from the documentation I am getting the errors shown below.

Does anyone has any leads where I am going wrong in this??

Thanks for checking out the project @Akhil23456 ! Which ros distro are you working with?


merge from arlac77/npm-package-template-kronos-module

package.json

chore(scripts): add ava --node-arguments '--experimental-modules' --timeout 2m (scripts.test)
chore(scripts): add c8 -x 'tests/**/*' --temp-directory build/tmp ava --node-arguments '--experimental-modules' --timeout 2m && c8 report -r lcov -o build/coverage --temp-directory build/tmp (scripts.cover)
chore(package): add ^3.4.0 remove ^3.3.0 (devDependencies.ava)

README.md

docs(README): update from template

Codecov Report

Merging #668 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #668   +/-   ##
=======================================
  Coverage   91.87%   91.87%
=======================================
  Files           4        4
  Lines         283      283
  Branches       13       13
=======================================
  Hits          260      260
  Misses         23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6afee43...3914e72. Read the comment docs.

:tada: This PR is included in version 8.1.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


MB-11596 : Add cypress test for PPM booking -dates and location page

Jira ticket for this change
Summary
This PR adds cypress test for the PPM booking for the dates and location form.
To review, check that the flows covered in the test make sense and call out anything that's missing
Verification Steps for Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

Messages

:book:
:link: MB-11596

  Generated by :no_entry_sign: dangerJS against 1e87505c4d2133cb6f1584f7b45271deecf25530

@jenniferlynparsons @YanZ777 I believe you both have experience with cypress testing so I've added you to this PR. Also, do you know if the happo diffs are okay to accept?

@jenniferlynparsons @YanZ777 I believe you both have experience with cypress testing so I've added you to this PR. Also, do you know if the happo diffs are okay to accept?

I followed this thread and accepted the happo changes https://ustcdp3.slack.com/archives/CP6PTUPQF/p1646158575883389

I think it's a little confusing that we now have milmove and mymove categories, granted you're usually only using this when creating or editing a new test

I think it's a little confusing that we now have milmove and mymove categories, granted you're usually only using this UI when creating or editing a new test but the folders will still appear similar in the codebase.

I'll defer to @gidjin on this, he created the PR that I pulled in to create the new milmove category

@duncan-truss @YanZ777 thanks for the reviews! I just pushed a commit that addresses all the comments left


use github actions rather than travis

@MattCowgill WE'RE BACK, BABY

@wfmackey WOAH BLAST FROM THE PAST

Done via deploy_bookdown.yaml and the gh-pages branch. Edits to Rmd files (unbuilt) will be reflected in the website


Add restriction on Event linking it to a TimeInterval

In the next major release (13.0.0) the property isCharacterizedAs will be gone as will the restriction on Event (isCharacterizedAs some Behavior). This will leave the definition of Event with no formal axioms. I propose adding a subclass restriction along the lines of (occursDuring some TimeInterval).
This would likely mean introducing a new property.

Planned events may not have planned dates, so we can't say all events occur during some time interval.

An Event occurs during a TimeInterval, but is not itself a TimeInterval, nor is a TimeInterval an Event.
Jamie: An event occurs during any number of time intervals (2-4pm today, 3-5pm today, 2023, the 21st century, etc.).
Steven: But there is a smallest time interval during which it occurs.
DECISION:

Add scope note to the effect that "An Event occurs during a TimeInterval, but is not itself a TimeInterval, nor is a TimeInterval an Event."
Do not add the proposed restriction.

@rjyounes

An Event occurs during a TimeInterval, but is not itself a TimeInterval, nor is a TimeInterval an Event.

This seems to be saying that Event and TimeInterval are disjoint. Do we want that as an axiom? Either way the scope note could be shortened to:

"An event occurs during a time interval, which is distinct from the event."

I like the idea of a formal disjunction - that will help allay some confusion, perhaps. And yes, your rewording of the note is also good.

I think you mean disjointness, not disjunction, which means OR / UNION.  In any event, given the past history of Event and TimeInterval, it may be prudent to leave out the formal axiom.

Yes - corrected above.

@rjyounes, do you agree to leave out the disjoint axiom, per above reasoning?

Yes, fine.


Spell slots and resources not showing for GMs, regardless of settings

Tested in a new world with only this module active. This is the character:

What the GM sees:

What a non-GM sees:

Settings:

Player permissions:

I can confirm I also have this issue. I have the latest version of foundry and DnD 5e.

I can confirm I also have this issue. I have the latest version of foundry and DnD 5e.


Integrates okHttp into the build process. Resolves spotbugs and checkstyle issues

@anuchandy Did you want to have this integrated into the build? Did you want to add more JavaDoc / code samples like we have for the netty builders? If so, feel free to push to this PR.

@JonathanGiles thank you for doing this! Let's merge this then I'll rebase my PR.


Fix aarch64 compiler install script

This PR closes #11 by providing the correct contents to the install_compiler.sh script for aarch64


Clarification on Encryption

Could you clarify the type of encryption in this document? For example in the Azure storage encryption document has the following line.

Azure storage platform is encrypted through 256-bit AES encryption, one of the strongest block ciphers available.

I'm assuming it's also AES 256 but it would be nice to be able to quote it from the documentation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7c068a1f-f3bf-0ea8-ffff-c5626f6da77a
Version Independent ID: 3adef505-3bd5-a55b-9697-1febe37d0a6a
Content: Encryption at rest in Azure Cosmos DB
Content Source: articles/cosmos-db/database-encryption-at-rest.md
Service: cosmos-db
GitHub Login: @rimman
Microsoft Alias: sngun

@slynickel Thank you very much for the detailed feedback. You make an excellent point but to clarify the question, if the Azure Storage service is detailing that the encryption implemented is XYZ, then any other Azure service that depends upon storage services will need to implement those encryption requirements to connect successfully.
I will assign to the content owner to evaluate and enhance this document as appropriate.

@Mike-Ubezzi-MSFT I think I'm following but let me make sure I understand.
The following line in the same document implies that Cosmos DB is backed by Azure storage, it follows that Azure storage uses AES 256, therefore Cosmos DB uses AES 256?

Cosmos DB stores its primary databases on SSDs. Its media attachments and backups are stored in Azure Blob storage, which is generally backed up by HDDs.

My feedback then would be that the document doesn't explicitly say that the primary database are stored on Azure Blob Storage (which uses AES 256). It just says the primary databases are stored on SSDs which as the reader I don't know is Azure Blob Storage. Or maybe it is Azure Blob storage? And that's all the clarification the doc needs.

The primary data, indexes, all the replicas are stored on local storage - SSDs and are encrypted by default.
Backups (see here https://docs.microsoft.com/en-us/azure/cosmos-db/online-backup-and-restore  are stored for more details) are stored in Azure Blob storage and also encrypted by default. Let me know if you need further clarification. Thanks.

@rimman Hi, the only clarification I'm looking for is what level of block cypher is used for the encryption of primary data, indexes and replicas, AES 256? When I tell a client that I use a database platform (any database platform) they always seem to want to know the block cypher is AES 256.
As an aside I realize this is somewhat pedantic. That said it would save me time in security discussions and reassure clients.

How are the encryption keys segmented?  I need to know whether or not two different Cosmos DB instances will have the same key or different keys.

@slynickel , @jwr456 All data in Azure Comsos DB is encrypted at rest. Encryption at rest is enabled by default and yes it uses AES - 256 on all regions where the account is running. We will get this added to the docs.

Submitted a fix to update the doc, we will close the issue if there aren't further questions.

Thank you! I'll close out as the original issue creator.


Error on edit profile page when saving changes

When I try to change certain fields on edit profile e.g. name, organisation, I hit an error and it says save has been unsuccessful. Two fields are highlighted in yellow (recovery email and password) suggesting these need to be re-entered. That's not the desired functionality though so this is a bug.
It's possibly something that was introduced when we were adding new tabs for email notifications so have added in to that milestone to link up.

@sjDCC the yellow highlighting may be the browser's autocomplete function

Some comments/questions about the intended functionality of this page:

Should recovery email be mandatory? i.e. does it need to be filled in before the user saves their profile?  It seems odd to require a user enter 2 emails on their profile.
Should the password field be mandatory on this page?

When I last worked on this page, it was only needed to edit the email field
If it is only mandatory for some edits, we need to make this clear to the user, perhaps by show/hiding the field

Should organisation be mandatory? I believe yes as a user needs to have an organisation for some of the assumptions the code makes.

Also is the intended behavior of the Org-not-listed button to select other from the list of organisations and to show a text field for a user to input their org name?  Currently it just clears out your selection.

@briri - do you guys need recovery email to be mandatory? It's less important in our context afaik, but I think you may need it to enable SSO unlinking? Maybe it's just mandatory when they unlink or is that too late as they've often lost access to institutional email then?
@xsrust I think we now make first name, last name, email, org, and password mandatory. These are all details that we want every account to have, but I don't think we should be asking anyone to re-enter anything to save changes.
I think we need a mandatory org, even just to state 'other' and enter freetext name
Other views?

The password is mandatory to have with a user account, but the goal of the password field on that page is to verify the identity of the user by entering their current password when doing sensitive actions such as changing the account's email.
There is a separate tab for changing password.

Ok, thanks for clarifying @xsrust
I think we want to limit the number of changes that require the password to be entered. I'm happy with that for changing email, but originally it seemed to be needed for any change (e.g. first name or org) which isn't necessary

Your correct, it's currently being required for all changes and i thought it was strange behavior.
I wolnt have time to complete this ticket before I'm away on holiday so un-assigning myself

Thanks @xsrust
@briri confirmed via Slack that it shouldn't be asking for the password to save any changes before I raised the ticket
One of us can pick this up while you're away - happy holidays!

Thanks Sam. Yes we went back and forth on whether or not to require the recovery email. The last conversation we had we decided to make it not required just haven't gotten around to changing it yet.

And yes the other org box should display. We seem to be missing the JS piece to that

@sjDCC we were thinking along those lines. Make the recovery email and passwords mandatory in certain situations like when the user unlinks their account. That will happen though on our version of the login/create account/manage profile workflow.
@xsrust yes, we want to make sure that password isn't required to change things like email address unless its vital to your particular workflow (I don't think it is). We can't require it for ours because we want users to create accounts via Shib and not have to worry about a password here.
There is another ticket #518 for the org/other org functionality

Given that the password change is on a separate tab, should we only have the password field appear when it needs to be entered to save sensitive changes? Having it display in the full list as normal is confusing currently. To me it suggests this field is editable like the others.

The password should not appear at all as field within that tab. Typically, you modify any information (sensitive or not) and before submitting an intermediate screen or popup asks for password to confirm these changes. Screenshot from github, for instance:

Added modal dialog to obtain the user's password when  they change their email address.

Added a comment to #746 to deal with the button alignment seen in the screenshot above

Modal box is being generated and looks good. It threw an error though when i tried to change the email. The first error was shown when I tried to change it to another email known by the system<EMAIL_ADDRESS>and the second showed when i changed to a new, unknown email. It doesn't seem the save is changing in either case.

@jollopre - I changed my email address and clicked to Save the changes. The modal popped up as expected and after entering my pw  I received a message that the system "successfully saved my password" (screenshot 1). Desired message and behavior is that it "successfully updated my profile information." When I navigated away from my profile and then returned to it my changes had not actually been saved - it still listed my original email (screenshot 2).

I tried again to replicate this in Chrome and Firefox and it always shows me the correct message. Can you try again @stephaniesimms and let me know if you are still experiencing it?

@briri - now it's working for me in Chrome and Firefox. But I can only achieve the desired results with the following steps:

change email
click Save
enter pw into modal
click Save again
then it displays the correct message and saves my changes

desired behavior is that user should not have to click Save a second time or at least they need some indication that this step is required

ok. makes sense.

All works fine - closing out


update

I was reading this documentation, and got to the point of this error:
"Blocks of type "storage_image_reference" are not expected here" while doing terraform validate
then realized that in the complete terraform script it is used the "source_image_reference" instead. it has to be updated.
cheers

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 163088fc-67d3-aa81-26e7-0155f3aaa90c
Version Independent ID: fafceb81-d8fc-8c20-72e5-b2dddc445f73
Content: Quickstart - Use Terraform to create a complete Linux VM in Azure
Content Source: articles/terraform/terraform-create-complete-vm.md
Service: terraform
GitHub Login: @TomArcherMsft
Microsoft Alias: tarcher

@zaistev Thanks for the feedback. I'll fix this and update this post when it's done.

@zaistev I just made the changes. The updated article should be live Monday morning (PST) at the latest.

@zaistev The changes are live: https://docs.microsoft.com/azure/terraform/terraform-create-complete-vm


PLEASE add timestamp and session-id into logging policy

Is your feature request related to a problem? Please describe.
In the legacy SDK, via boost logger, I can get detailed log entry with timestamp and session id such as the following:
2022-07-28 15:53:14 0433481E-1E0E-460C-8AA3-855F363E4C6D : Retry policy did not allow for a retry, so throwing exception: The account being accessed does not support http.
but in track2, after SetListener, the message captured in the listener only has the error message itself, for instance,
HTTP Transport error: Fail to get a new connection for: ://. URL using bad/illegal format or missing URL
there is NO timestamp and there is NO unique session id which could help in debugging multiple interleaved requests.
Describe the solution you'd like
add support for timestamp and session-id in built-in log policy. Or add an additional user input field in the SetListener callback so the caller can pass in additional info to track where the log comes from.
Describe alternatives you've considered
N/A
Additional context
Add any other context or screenshots about the feature request here.
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[ ] Description Added
[ ] Expected solution specified

@RickWinter
Is there a way you can provide an estimate when this will be implemented?  We are looking to productize this SDK in Q4 thus logging is a crucial component for us.
Thanks,
Yang

At what time do you want to print logs, before the request is sent over the wire or after receiving a response, or both
Both
What kind of information do you expect to be included in logs? Like request url, headers, status code, etc.
In trace (verbose) mode, we need timestamp, session id, url, headers and status/error string to be dumped to the log.  In warn or error mode, time stamp, url, status and error messages should be dumped.
Is there any other non-HTTP-specific information you’d like to include in logs except timestamp and session-id you’ve mentioned in the GitHub issue?
Perhaps from track2 SDK level, say operation completed or failed in verbose mode and also any error messages generated from the SDK in error/warn mode?

You can add a timestamp in your implementation of a log listener. For example, see how EnvironmentLogLevelListener does append a timestamp and a thread id: https://github.com/Azure/azure-sdk-for-cpp/blob/ccddc7f3ed7f0c71ad99a2d01398fcd3aa6596d7/sdk/core/azure-core/src/environment_log_level_listener.cpp#L121-L145

You could produce the timestamp the same way.
I do not know what a session ID is - I don't think this SDK has this concept, at least not at an SDK level.
That implementation could either append the timestamp to the message, or, if you are, for example, exporting to a database, could put it into a separate field.

Just for infornation, it is possible that EnvironmentLogLevelListener could work for you to some extent?
If you set an AZURE_LOG_LEVEL environment variable (https://github.com/Azure/azure-sdk-for-cpp/tree/main/sdk/core/azure-core#sdk-log-messages), then you could redirect standard error to the log file, and it will have timestamps (because EnvironmentLogLevelListener adds them)
myprogram.exe 2> log.txt


Request to add Ben Zvi High School

Hi,
This High School is located in Israel. Please find herein the school's web page for its 3 year Computer sciences program (in Hebrew) https://www.b-zvi.com/computers
Also attached is a PDF printout (redacted password) from the school assigning this email<EMAIL_ADDRESS>to me:
Gmail - Fwd תיכון ע_ש הנשיא י.בן צבי קרית אונו - הודעה בדבר תהליך רישום של הילה.pdf

@catsaysme0w Thank you for your patience while waiting for a review and processing your request. Pull request merged.
Please start requesting the licenses in about an hour, to let the changes to propagate through our system.

Thank you!
I've proceeded to apply for the education license.
On Thu, Oct 3, 2024 at 12:28 PM Philip Torchinsky @.***>
wrote:

@catsaysme0w https://github.com/catsaysme0w Thank you for your patience
while waiting for a review and processing your request. Pull request merged.
Please start requesting the licenses in about an hour, to let the changes
to propagate through our system.
—
Reply to this email directly, view it on GitHub
https://github.com/JetBrains/swot/pull/23983#issuecomment-2390943072,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BLQR5NP2WH72BXUDQAA5GADZZUE3ZAVCNFSM6AAAAABO7PR7UGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJQHE2DGMBXGI
.
You are receiving this because you were mentioned.Message ID:
@.***>


Advanced Feedback Visualization

Is your feature request related to a problem?
Some types of feedback are not easy to read. E.g. tables or graphs are currently only possible through ascii-art.
Describe the solution you'd like
Support for markdown rendering of the feedback would allow tables, svg-graphs and more.
Describe alternatives you've considered
No response
Additional context
No response

One alternative we thought some time ago would be a feedback attachment. I.e., the tutor can upload a (or multiple?) file(s) as part of the assessment process.
Concrete use-case for us would be

file upload exercises: download the PDF, annotate it, and upload it again

could be extended in the future to make use of the PDF view/annotation-tool already built into most browsers to allow for annotations directly in the browser (similar to functionality available in Moodle)
related: #4495

programming exercises: in case of exercises that have some UI task, let the tutor upload screenshots to show visual bugs we noticed during assessment

One use-case for us would be automatic feedback for performance. Just using plain numbers is possible, it would be interesting to show a graph with expected performance distribution for a given program and where your program currently is.
Another use-case would be math related testcases. This would allow feedback of the testcases to be consistent with the task-description, as math symbols are supported there.
For both, attaching a PDF to a submission is not really a viable solution, because then all test results would be rendered in the PDF and not properly recognized by the progress-bar or sub-task indicator in the assignment.


slam_toolbox: 1.1.1-1 in 'melodic/distribution.yaml' [bloom]

Increasing version of package(s) in repository slam_toolbox to 1.1.1-1:

upstream repository: https://github.com/SteveMacenski/slam_toolbox.git
release repository: https://github.com/SteveMacenski/slam_toolbox-release.git
distro file: melodic/distribution.yaml
bloom version: 0.8.0
previous version for package: 1.1.0-1

Second release is always the charm..


Dependency compiled to ES5 during build process even though target is ES2015 and ngcc is run on postinstall

🐞 Bug report
Command (mark with an x)

[x] build

Is this a regression?

Not that I'm aware of.
Description
 A clear and concise description of the problem...
Our CI (Jenkins) gets stuck in the build process after upgrading to Angular 10. After some investigation it turns out that the issue it that when building our apps in parallel it they all trigger ngcc at the same time. A warning about parallel builds is shown for all apps but the one, and those apps never exists the process even though the build is complete.
So the ngcc part is somehow causing the process to never finish. The main issue causing this I just discovered in the logs. If you look at the last line you can see that ngcc is compiling @fortawesome/angular-fontawesome into ES5, but the target of the applications are ES2015 and I'm running ngcc as a postinstall hook, so all modules are already compiled into ES2015.
web-app-prime
 |
 | ><EMAIL_ADDRESS>webpack C:\Users\***\repo\monorepo-new\packages\web-app-prime
 | > node --max_old_space_size=8192 node_modules\webpack\bin\webpack.js "--config" "config/webpack.prod.ts" "--bail"
 |
web-app-edit
 |
 | ><EMAIL_ADDRESS>webpack C:\Users\***\repo\monorepo-new\packages\web-app-edit
 | > node --max_old_space_size=8192 node_modules\webpack\bin\webpack.js "--config" "config/webpack.prod.ts" "--bail"
 |
web-app-prime
 |
 | Compiling @fortawesome/angular-fontawesome : module as esm5

As you can see it's compiled to ES2015:
><EMAIL_ADDRESS>postinstall C:\Users\***\repo\monorepo-new
> ngcc --properties es2015 browser module main --first-only --create-ivy-entry-points

Compiling @fortawesome/angular-fontawesome : es2015 as esm2015

🔬 Minimal Reproduction
https://github.com/JonWallsten/monorepo-new/tree/angular-10-repro
Start with a clean slate since the error goes away after first build.

npm run full-install
npm run build
Profit!

🔥 Exception or Error

 | ERROR in ngcc is already running at process with id 33256.
 | If you are running multiple builds in parallel then you should pre-process your node_modules via the command line ngcc tool before starting the builds;
 | See https://v9.angular.io/guide/ivy#speeding-up-ngcc-compilation.
 | (If you are sure no ngcc process is running then you should delete the lock-file at<EMAIL_ADDRESS>
🌍 Your Environment

Angular CLI: 10.0.1
Node: 12.16.1
OS: win32 x64

Angular: 10.0.2
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router
Ivy Workspace:

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.1000.1
@angular-devkit/build-optimizer   0.1000.1
@angular-devkit/core              10.0.1
@angular-devkit/schematics        10.0.1
@angular/cdk                      10.0.1
@angular/cli                      10.0.1
@angular/material                 10.0.1
@ngtools/webpack                  10.0.1
@schematics/angular               10.0.1
@schematics/update                0.1000.1
rxjs                              6.5.5
typescript                        3.9.5
webpack                           4.43.0

Anything else relevant?
"extends": "../../tsconfig.json",
"compilerOptions": {
    "target": "es2015",
    "outDir": "./dist",
    "strictNullChecks": true,
    "noImplicitReturns": true,
    "typeRoots": [
      "./node_modules/@types",
      "../../node_modules/@types"
    ]
}

We also have one Angular.JS application in the mix, but it's clear it's not involved.
Edit:
It seems like it's running on every build but the issue (and error) only appears when there's something to compile.
Note: The log in from another repo but with the same setup.
web-app-prime
 | Another process, with id 34620, is currently running ngcc.
 | Waiting up to 250s for it to finish.
 | (If you are sure no ngcc process is running then you should delete the lock-file at<EMAIL_ADDRESS>web-app-edit
 | Another process, with id 34620, is currently running ngcc.
 | Waiting up to 250s for it to finish.
 | (If you are sure no ngcc process is running then you should delete the lock-file at<EMAIL_ADDRESS> | Another process, with id 47668, is currently running ngcc.
 | Waiting up to 250s for it to finish.
 | (If you are sure no ngcc process is running then you should delete the lock-file at<EMAIL_ADDRESS>

Hi @JonWallsten, the incorrect resolution is caused because in your custom Webpack configuration you are not defining the right order for mainFields (https://github.com/angular/angular-cli/blob/master/packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/browser.ts#L75). It's important to point out that the Angular tooling team doesn't support custom Webpack configurations.
With regards to the lock file issue, I'll transfer the issue to the FW repo for a better triage.


Use z10 as default CPU for s390x

bors try amd64 --platform manylinux2014

bors retry

bors retry

#16 375.9 [ALL  ]    This target does not support --with-cpu.
#16 375.9 [ALL  ]    Valid --with options are: arch mode tune
#16 375.9 [ERROR]    make[2]: *** [Makefile:3843: configure-gcc] Error 1
#16 375.9 [ALL  ]    make[2]: Leaving directory '/build/.build/s390x-ibm-linux-gnu/build/build-cc-gcc-core-pass-1'
#16 375.9 [ERROR]
#16 375.9 [ERROR]  >>
#16 375.9 [ERROR]  >>  Build failed in step 'Installing pass-1 core C gcc compiler'
#16 375.9 [ERROR]  >>        called in step '(top-level)'
#16 375.9 [ERROR]  >>
#16 375.9 [ERROR]  >>  Error happened in: CT_DoExecLog[scripts/functions@376]
#16 375.9 [ERROR]  >>        called from: do_gcc_core_backend[scripts/build/cc/gcc.sh@735]
#16 375.9 [ERROR]  >>        called from: do_cc_core_pass_1[scripts/build/cc/gcc.sh@209]
#16 375.9 [ERROR]  >>        called from: main[scripts/crosstool-NG.sh@697]
#16 375.9 [ERROR]  >>

Doesn't work.