Supporting population allele frequencies

Issue: https://github.com/Ensembl/ensembl-hypsipyle/issues/19
Ticket: https://www.ebi.ac.uk/panda/jira/browse/ENSVAR-6165
Also includes bug fix for most_severe_consequence

[x] New endpoint for Population
[x] Testing variants (could not find a substitution example with non-null allele frequencies)

[x] 1:230710048:rs699 (bi-allelic snp)
[x] 13:32379902:rs202155613 (multi-allelic snp)
[x] 13:57932480:rs11276267 (insertion)
[x] 1:10123:rs1639546401 (deletion)
[x] 1:10153:rs1639547929 (indel)

[x] Update information in population_metadata.json (add gnomADg, gnomADe)

Thanks for adding in gnomAD genomes

@jamie-m-a @likhitha-surapaneni is there a mechanism in the population frequencies data that will allow the client to separate it by studies — e.g. 1000 genomes vs gnomAD version x, etc.?

Thanks for adding in gnomAD genomes

@jamie-m-a @likhitha-surapaneni is there a mechanism in the population frequencies data that will allow the client to separate it by studies — e.g. 1000 genomes vs gnomAD version x, etc.?

Hi @azangru, population_name has a prefix of the population study in the current data. Eg: gnomADg:afr belongs to gnomADg but it might not be descriptive as gnomAD genomes v3.1.2.

population_name has a prefix of the population study in the current data. Eg: gnomADg:afr belongs to gnomADg but it might not be descriptive: gnomAD genomes v3.1.2.

I should have mentioned that we would like something better than parsing the population name string :-) Partly because this is generally not a good idea, and partly because the design suggests that there will be some beautiful labels:

population_name has a prefix of the population study in the current data. Eg: gnomADg:afr belongs to gnomADg but it might not be descriptive: gnomAD genomes v3.1.2.

I should have mentioned that we would like something better than parsing the population name string :-) Partly because this is generally not a good idea, and partly because the design suggests that there will be some beautiful labels:

This may require querying the population object which contains the field display_group_name. This field contains information about the population group required by the website (information in the labels). population_allele_frequency->population_name can be matched with population->name to fetch population->display_group_name if that is feasible.  population_metadata.json should be updated accordingly from the API end.

This may require querying the population object which contains the field display_group_name. This field contains information about the population group required by the website (information in the labels). population_allele_frequency->population_name can be matched with population->name to fetch population->display_group_name if that is feasible. population_metadata.json should be updated accordingly from the API end. Does that work for the client @azangru ?

population->display_group_name sounds good, if there is no more information you would like to associate with 1000 genomes, gnomAD, etc. (i.e. you do not expect the client to ever need to provide a link to them). If there is such extra information, then something ExternalDB-shaped might be more appropriate.

This may require querying the population object which contains the field display_group_name. This field contains information about the population group required by the website (information in the labels). population_allele_frequency->population_name can be matched with population->name to fetch population->display_group_name if that is feasible. population_metadata.json should be updated accordingly from the API end. Does that work for the client @azangru ?

population->display_group_name sounds good, if there is no more information you would like to associate with 1000 genomes, gnomAD, etc. (i.e. you do not expect the client to ever need to provide a link to them). If there is such extra information, then something ExternalDB-shaped might be more appropriate.

Thank you @azangru , I discussed with @jamie-m-a  and population->display_group_name would be string for now. If the design changes in the future,  we will make the above suggested changes to VDM.

Hello all, why am I getting these emails?
On Tue, Jan 30, 2024, 17:04 Likhitha Surapaneni @.***>
wrote:

This may require querying the population object which contains the field
display_group_name. This field contains information about the population
group required by the website (information in the labels).
population_allele_frequency->population_name can be matched with
population->name to fetch population->display_group_name if that is
feasible. population_metadata.json should be updated accordingly from the
API end. Does that work for the client @azangru
https://github.com/azangru ?
population->display_group_name sounds good, if there is no more
information you would like to associate with 1000 genomes, gnomAD, etc.
(i.e. you do not expect the client to ever need to provide a link to them).
If there is such extra information, then something ExternalDB-shaped
https://github.com/Ensembl/ensembl-cdm-docs/blob/main/src/docs/external_db.md
might be more appropriate.
Thank you @azangru https://github.com/azangru , I discussed with
@jamie-m-a https://github.com/jamie-m-a and
population->display_group_name would be string for now. If the design
changes in the future, we will make the above suggested changes to VDM.
—
Reply to this email directly, view it on GitHub
https://github.com/Ensembl/ensembl-hypsipyle/pull/29#issuecomment-1917361419,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAN7Y2LRVGDYVQZSE66IF2DYREKZTAVCNFSM6AAAAABB6SRX2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJXGM3DCNBRHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hello all, why am I getting these emails?
…
On Tue, Jan 30, 2024, 17:04 Likhitha Surapaneni @.> wrote: This may require querying the population object which contains the field display_group_name. This field contains information about the population group required by the website (information in the labels). population_allele_frequency->population_name can be matched with population->name to fetch population->display_group_name if that is feasible. population_metadata.json should be updated accordingly from the API end. Does that work for the client @azangru https://github.com/azangru ? population->display_group_name sounds good, if there is no more information you would like to associate with 1000 genomes, gnomAD, etc. (i.e. you do not expect the client to ever need to provide a link to them). If there is such extra information, then something ExternalDB-shaped https://github.com/Ensembl/ensembl-cdm-docs/blob/main/src/docs/external_db.md might be more appropriate. Thank you @azangru https://github.com/azangru , I discussed with @jamie-m-a https://github.com/jamie-m-a and population->display_group_name would be string for now. If the design changes in the future, we will make the above suggested changes to VDM. — Reply to this email directly, view it on GitHub <#29 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAN7Y2LRVGDYVQZSE66IF2DYREKZTAVCNFSM6AAAAABB6SRX2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJXGM3DCNBRHE . You are receiving this because you were mentioned.Message ID: @.>

Sincere apologies for the notification, it was due to mistyped username tagging.


no styling possible under svelte

it is apparently not possible in picocss to define your own styles with svelte, because picocss always overwrites everything, no matter what and where it is defined. elements such as h1-h6 or variables of picocss cannot be overwritten. in the browser, the hierarchy is always in favour of picocss.
this makes cuotom styling impossible.

ok, the problem was caused by myself.
the order of the imports was the problem
import<EMAIL_ADDRESS>import './app.css'


Update extension version

Codecov Report

Merging #11730 into release-2020.05 will decrease coverage by 0.01%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           release-2020.05   #11730      +/-   ##
===================================================
- Coverage            60.74%   60.72%   -0.02%
===================================================
  Files                  619      619
  Lines                33751    33751
  Branches              4751     4751
===================================================
- Hits                 20502    20496       -6
- Misses               12257    12261       +4
- Partials               992      994       +2

Impacted Files
Coverage Δ

src/datascience-ui/react-common/arePathsSame.ts
75.00% <0.00%> (-12.50%)
:arrow_down:

src/client/common/utils/platform.ts
64.70% <0.00%> (-11.77%)
:arrow_down:

src/client/linters/pydocstyle.ts
86.66% <0.00%> (-2.23%)
:arrow_down:

src/client/datascience/debugLocationTracker.ts
76.56% <0.00%> (-1.57%)
:arrow_down:

src/client/common/process/proc.ts
14.49% <0.00%> (-0.73%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebaba5c...15eb489. Read the comment docs.


[FALSE-POSITIVE]

Domains or links
http://bcp.com.bo/
More Information
How did you discover your web site or domain was listed here?
Incorrectly marked as Phishing on VirusTotal (appears as clean to Phishtank and OpenPhish)
https://www.virustotal.com/gui/url/b06334bd013e94800e211c98b90066de49f65bb97bf563113f19dcb65979888c
Additional context
Recognizes as phishing an official site of "El Banco Central de Bolivia (BCB)", while the version with WWW is completely clean:
https://www.virustotal.com/gui/url/7498050549fa5bffd5695babc8156cb8ce397df8da45d9d10d309062d5027fb5
We also attach the site of the Bolivian Bank Association: https://www.asoban.bo/about
:exclamation:
We understand being listed on a Phishing Database like this can be frustrating and embarrassing for many web site owners. The first step is to remain calm. The second step is to rest assured one of our maintainers will address your issue as soon as possible. Please make sure you have provided as much information as possible to help speed up the process.
Send a Pull Request for faster removal
Users who understand github and creating Pull Requests can assist us with faster removals by sending a PR to mitchellkrogza/phishing repository, on the falsepositive.list file

https://github.com/mitchellkrogza/phishing/blob/main/falsepositive.list
Please include the same above information to help speed up the whitelisting process.

Hi, sorry to bother you, but how long does it take to update? As it is a bank website, it is important to know this information


changed dropdownIcon type to Widget

Needed to use an image asset as a dropdownIcon.

@jgeewax @KANekT @tritao @lingster
Please check this out, I really need this.
It just a change in the widget type of dropdownIcon

Hey @jabguru, thanks for your contribution. Much appreciated feature. We added a branch called next, where all breaking changes like this one belongs. Can you switch your target branch from master to next?


Good resource.

https://www.shadertoy.com/ is a good resource to play with GLSL and see others' work.

Thanks, added the link!


No option to enable email threads for Yandex Servers

Hi,
I am using yandex servers and while connecting there is no support for email threads under settings... what could be the possible error? Threads are working fine Google servers.. but not on yandex.. please advice..

Hi. Does Yandex servers supports IMAP threads?


[BUG][azure-spring-data-cosmos]Use between on partition key not return all datas

Describe the bug
Used version.
    <dependency>
      <groupId>com.azure</groupId>
      <artifactId>azure-spring-data-cosmos</artifactId>
      <version>3.20.0</version>
    </dependency>

When I passed a between criteria on a partition key, if it has multiple values, then only return one partition results.
Code Snippet
Criteria.getInstance(CriteriaType.BETWEEN, "date", List.of("2022/06/01", "2022/06/10"), Part.IgnoreCaseType.NEVER);

I see that isCrossPartitionQuery doesn't process between but only in criteria. Is that I'm using the wrong method?

@zhangxj1977 can you please provide a little more info? Mainly, what is the query you are executing after creating your criteria? And it seems you are saying you expect > 1 result from your query but you are only getting 1 result back?


In the Customer Group Pricing feature, there's a problem with the Fixed Price option accepting input values higher than the actual price of the product.

Terms

[X] Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected
Master
Issue Description
When created a product and added Price $100, and when assigning Customer group pricing to the same product with fixed price of $500 for 5 QTY, it is saved.
On checking the product view page of the same product there I can see that it is showing -> Buy 5 for $100.00 each and save 0.00%
Issue is it should not save the price more then the product price.
Preconditions

Admin must be logged in.
Atleast 1 product must be created.

Steps to reproduce

Go to Admin -> Catalog -> Products -> Create a Product -> Enter all Fileds and set price $100.
Click on Customer Group Price -> Enter Minimum QTY.
Select Price Type -> Fixed
Enter Price $500.
Save Product
here we can see product is saved.
Check the home page -> Search Product -> Product view page -> Check the customer group pricing text.
Buy 5 for $100.00 each and save this appears.

Expected Result
We should not be  able to see the customer group price more then the actual price of the product.
Actual Result
Currently we  are able to save the details. Please check the video for the same.
Video
https://github.com/bagisto/bagisto/assets/92721837/d0ac77e4-558c-4e00-af9a-faaed6916488
Screenshots
No response
Additional context
No response

@ashishkumar-webkul sir,
We are not implementing this type of validation for handling group price checks. As this is the admin panel, it is expected that the admin is aware of the appropriate prices to add in the group price section.

As per the discussion with @amit-webkul, hence I am closing the issue from here.


bug in 'create first test' step

the code for creating the first test has a few typos.  this worked for me:
using Xunit;
using PrimeServices;
namespace PrimeServices.UnitTests
{
public class PrimeService_IsPrimeShould
{
private readonly PrimeService _primeService;
    public PrimeService_IsPrimeShould()
    {
        _primeService = new PrimeService();
    }

    [Fact]
    public void ReturnFalseGivenValueOf1()
    {
        var result = _primeService.IsPrime(1);

        Assert.False(result, "1 should not be prime");
    }
}

}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e39c2f1b-f41a-bdf9-2646-09379941453d
Version Independent ID: 422811cb-6287-03af-ba8d-1daebee9744d
Content: Unit testing C# code in .NET Core using dotnet test and xUnit - .NET Core
Content Source: docs/core/testing/unit-testing-with-dotnet-test.md
Product: dotnet-core
GitHub Login: @ardalis
Microsoft Alias: wiwagn

actually never mind i just noticed i only copied the function not the namespace from the earlier test my bad

@stevebogar  then you should close this, confuses readers.
Regards

Thanks for the comment @fwd079
I'll close as resolved.


Typing is garbled in IE11

Typing "Typing a test message" (and messing it up the second time :smile_cat:) with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>
The event handler isn't doing anything asynchronous:
  handleTextChange(e) {
    this.setState({text: e.target.value})
  },

This only seems to happen when the component is controlled - working around it by using it without a value prop. as that suits my current use case.

Hm.. tried on a VM with IE11 downloaed from modern.ie:

Is the purpose of this line in componentWillUpdate() to resize the textarea when it's controlled and a new value is forced into it via a prop, rather than by using the textarea?
this._onNextFrameActionId = onNextFrame(this._resizeComponent);

Commenting this out makes IE11 behave when typing normally - could it be a difference in how IE implements requestAnimationFrame?

Can you try code in controlled branch? I removed rAF call there and simplified code to allow only controlled usage (also removed support for valueLink pattern).

Looks good to me in IE

Ok, I'll wait for feedback on #100 a little bit and then release it (or not :-)).

We also have users experiencing this issue, glad someone caught it!

Any updates on this? Is it ready to merge?

I would also like to see that being merged / fixed :) I'll have to disable this feature now, because I cannot ship to customers otherwise.

I had this problem in an application, not with just this module, but regular text inputs too. React made a change in v15 to how the change event is handled in IE11 and below - my solution was just to change the 'onChange' event to 'onInput'. After that everything worked just fine.

@andreypopp
what did happen with controlled branch? I dont see it included in the master and it got deleted I think, is there a plan to release it? I had to fork the repo and merge controlled in the past so I can ship my app without this bug, but would like to eventually include the original lib instead of a fork

@Andarist see https://github.com/andreypopp/react-textarea-autosize/pull/100 also I've stepped down  as a maintainer of react-textarea-component so @jdalton makes the call here

I noticed that some changes were made in React for IE 11 in the latest release (v15.4.2).
We might want to recheck these IE 11 bugs given React has resolved issues of its own regarding textarea elements.
#125 may also be affected.

I had problem with this too, after some PRs merged in and new release today Ive just tested it (manually ofc) on the computer with IE11 which was affected before bumping library version and the problem seems to be gone.
Other popped up, but aint sure if new. At least typing is not more garbled (for me). Going go to close this issue, but if anyone still suffers from this problem at the newest version of the library then please raise your voice, I will reopen and do my best to fix this.


Blank acctions after update

Alarmo Version
V1.8.2
HA Version
2021.12.9
Bug description
After updating to 1.8.2, the acctions I had, no longer works. If I go to the the accion tab, all the acctions are still there but if I click any, the page is just blank.
It is true that for most I use the yaml code for example one of the acction is the code bellow, that will run a script to sound a siren.
- service: script.turn_on   entity_id: script.1581864887624   service_data: {}
Steps to reproduce
No response
Relevant log output
No response

Duplicate of #369


node-gyp v3.8 throws error when doing 'npm install'

I have upgraded to the latest version of node-gyp.

Node Version: 16.13.0
Platform: Windows NT 10.0
Compiler:
Module:

Verbose output (from npm or node-gyp):
details in
log file.

Usage: npm install
(...)

Log file:
Attached

Throws error when trying to do 'npm install'.

error gyp info using<EMAIL_ADDRESS>
You are using node-gyp v3 and the current version is v9.

I solved the error by reinstalling Visual Studio 2019 (turns out I had two copies) and then running:
npm install -g --msvs_version=2019 node-gyp rebuild


Update README

Adds the package video_player to the dependencies file. From a superficial point of view, it seems as if the chewie package comes with video_player hence it can be confusing when trying to instantiate VideoPlayerController and there's an error.

Thanks!


this.revert(false) throws Uncaught TypeError: ready.call is not a function

When this.revert is called to revert any previously applied filter it throws below error in console.
Uncaught TypeError: ready.call is not a function
Root.Caman.Caman.revert @   caman.full.min.js:35
(anonymous function)    @   caman.full.min.js:124
Caman.version={release:"4.0.0",date:"1/6/13"}

Did you solve this problem?


How is SSH used?

Can you elaborate on:
Deleting the default network security group SSH rule and disabling the SSH service on the nodes prevents the Azure platform from performing maintenance tasks.

If I am the only one possessing the private key of the SSH pair, how does Azure interact with my nodes? I thought it was thru the Linux Azure waagent mechanism, which I believe do not require SSH?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e0fcc83c-c911-4d82-98af-ed8880ca6c4a
Version Independent ID: 00462d96-9a30-8cef-5932-c99bab237706
Content: Concepts - Security in Azure Kubernetes Services (AKS)
Content Source: articles/aks/concepts-security.md
Service: container-service
GitHub Login: @iainfoulds
Microsoft Alias: iainfou

Thanks for the question! We are investigating and will update you shortly.

@ams0 Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

PG has confirmed this was a hold-over from ACS, and the default SSH rules are no longer created as of one of the recent AKS releases. Doc has been updated to reflect current behavior.


Cannot create new Incident without User Admin role

We have just configured TEOC and our test users are getting this error when trying to create New Incident -

I tested with my account which has the User Admin role and i was able to create an Incident with no issue.
We do not use any group naming policies but we do not allow Users to create 365 groups.
We thought with the Group.ReadWrite.All permission, this would allow the app to create the group but is it actually looking to the user for their role? Are our only options to give these users User Admin role? Or would group admin work?

Hi @Shaun2027 ,
Thanks for reaching out to us.
Can you please confirm whether you have Group Naming Policy in your tenant? If that is the case, the group creations will fail for all users and it just works for User Admin and Global Admin role as they are exempted from the naming policy.
Please refer this thread # 55

Hi @v-prigunasek
No we do not have any group naming policies configured but we do not allow users to create m365 groups. (under Settings, General we have "Users can create Microsoft 365 groups in Azure portals, API or PowerShell" set to No). Should the Group.ReadWrite.All permission overwrite that?
Shaunagh

Hi @Shaun2027 ,
Thanks for sharing that information. If you have that setting enabled in your tenant, then only users in certain admin roles (Global admin, Users admin, Groups admin) can override it.
The "Group.ReadWrite.All" permission will not override those settings, it allows the app to create groups and read all group properties and memberships on behalf of the signed-in user.
Thanks!

Thanks @v-prigunasek.
After you confirmed the above, then we were able to use a group that has permission to create M365 groups - similar to this https://learn.microsoft.com/en-us/microsoft-365/solutions/manage-creation-of-groups?view=o365-worldwide
And this is now working for us! Thanks again

That sounds good. Thanks for updating us on this.


[Bug] Non -GPT model disable system prompt

Describe the bug
A clear and concise description of what the bug is.
Self-deployed large models will automatically inject system-level prompts, resulting in incorrect answers.
It should be that only gpt api injects the default system prompt.
自部署大模型会默认注入系统提示 导致回答错误
应该是只有gpt api注入才对
https://github.com/ChatGPTNextWeb/ChatGPT-Next-Web/pull/3684
这个pull似乎没有考虑到自部署大模型的情况
V2.10.1
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error
docker deployment and add environment variables.
docker部署并添加环境变量

CUSTOM_MODELS=-all,+Balanced-g4t-offline,+Creative-g4t,+Balanced-g4t,+Precise-g4t,+Creative,+Balanced,+Precise,+Creative-g4t-offline,+Precise-g4t-offline,+Creative-offline,+Balanced-offline,+Precise-offline
BASE_URL=https://bingai.zklcdc.xyz
HIDE_USER_API_KEY=1

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.

Deployment

[y] Docker
[ ] Vercel
[ ] Server

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional Logs
Add any logs about the problem here.
{"messages":[{"role":"system","content":"\nYou are ChatGPT, a large language model trained by OpenAI.\nKnowledge cutoff: 2021-09\nCurrent model: Balanced-g4t-offline\nCurrent time: 2024/1/31 20:21:45\nLatex inline: $x^2$ \nLatex block: $$e=mc^2$$\n\n"},{"role":"user","content":"hi"}],"stream":true,"model":"Balanced-g4t-offline","temperature":0.5,"presence_penalty":0,"frequency_penalty":0,"top_p":1}

test


"Hide Search Matches" box has low contrast on home page

📚 Documentation

At https://napari.org/stable/index.html:

The black box at the top says "Hide Search Matches", but it's very low contrast so not very readable.

Thanks for pointing it out, will fix!


Tidy up DocumentHelper

We shouldn't have to keep stubbing Search API v1 and v2 separately. This adds a helper method that stubs them both and cleans up repetitive code in each of the stub methods.

Nice. One question - is it possible that we will get a false positive test response due to this? (ie now that we're always stubbing both V1 and V2 requests, do we have tests that are currently working only on V1 where the test might accidentally use V2 and would miss a regression in V1). Or are the tests always very specific about what api they're using, and they'll still break in the right places?

Nice. One question - is it possible that we will get a false positive test response due to this? (ie now that we're always stubbing both V1 and V2 requests, do we have tests that are currently working only on V1 where the test might accidentally use V2 and would miss a regression in V1). Or are the tests always very specific about what api they're using, and they'll still break in the right places?

Good question. This whole kerfuffle comes out of the fact that the "all content" finder can still use v1 as an emergency fallback (with a feature flag), and we want to keep that behaviour for now, so anywhere v2 can be called needs to be able to stub v1 (but not vice versa).
You're right that there's a risk that now that we now stub v2 for a whole bunch of requests that it technically doesn't support (but may do so in the future), we might give someone false confidence that it does 😬
Have amended with a parameter to explicitly enable stubbing v2!


Add support for unique, bmm, xlogy

Description
Added support for Tensor.unique (for tests). Solves issue https://github.com/deepjavalibrary/djl/issues/2407
Added support for Tensor.bmm and Tensor.xlogy (pytorch impls only). Solves issue https://github.com/deepjavalibrary/djl/issues/2349

Codecov Report
Patch coverage: 75.37% and project coverage change: +1.79 :tada:

Comparison is base (bb5073f) 72.08% compared to head (8173a4e) 73.88%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2415      +/-   ##
============================================
+ Coverage     72.08%   73.88%   +1.79%
- Complexity     5126     6806    +1680
============================================
  Files           473      672     +199
  Lines         21970    29711    +7741
  Branches       2351     3063     +712
============================================
+ Hits          15838    21953    +6115
- Misses         4925     6270    +1345
- Partials       1207     1488     +281

Impacted Files
Coverage Δ

api/src/main/java/ai/djl/BaseModel.java
75.83% <0.00%> (+1.86%)
:arrow_up:

api/src/main/java/ai/djl/modality/cv/Image.java
69.23% <ø> (-4.11%)
:arrow_down:

...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java
76.00% <ø> (ø)

...rc/main/java/ai/djl/modality/cv/output/Joints.java
71.42% <ø> (ø)

.../main/java/ai/djl/modality/cv/output/Landmark.java
100.00% <ø> (ø)

...main/java/ai/djl/modality/cv/output/Rectangle.java
72.41% <0.00%> (ø)

...i/djl/modality/cv/translator/BigGANTranslator.java
21.42% <0.00%> (-5.24%)
:arrow_down:

.../modality/cv/translator/ImageFeatureExtractor.java
0.00% <0.00%> (ø)

.../ai/djl/modality/cv/translator/YoloTranslator.java
27.77% <0.00%> (+18.95%)
:arrow_up:

...ain/java/ai/djl/modality/cv/util/NDImageUtils.java
67.10% <0.00%> (+7.89%)
:arrow_up:

... and 643 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Instagram example do not work - demo page

Instagram example is not working. Please check the demo page:
https://justinmahar.github.io/react-social-media-embed/?path=/story/embeds-instagramembed--main-example

It seems Instagram Embed is not working in many places.
I've just tried without this library in a Nextjs project and I got the same error that I found here in the demo page:
Cross-Origin Read Blocking (CORB) blocked a cross-origin response.
Just inspect the embed.js script in the network tab that you'll find this 302 found response

@justinmahar any updates on this issue?

I seriously don't know what happened, but everything is working now, even the demo instagram section.
@offminded check and close the issue

I went through the same scenario as well. In my application, the Instagram embed stopped working, returning a 302 status code on the request for the embed.js file and it would stay in infinite loading.
The same thing happened on the Demo page, so it was probably a global issue that affected the entire Instagram embed functionality, because now everything is back to normal for me too.

Ok back to normal for me too, seems it was a global issue. Thanks for the input @matheusdamiao @GabrielNogueiraBR. Closing.


Error in Description of fc_run.cfg - configuration section of pb-assembly page

After successfully running the pipeline with arrow about eight months ago I am happy to see all the excellent engineering changes - with all these changes I mistakenly included a suggested line
pa_DBdust_option=true
and am hoping you might change this to
pa_DBdust_option=
so that other users don't include it.  Overall outstanding work!
Operating system
Red Hat Enterprise Linux Server release 7.6 (Maipo)
Package name
pb-assembly configuration section:
https://github.com/PacificBiosciences/pb-assembly
Conda environment
(partial list)
pb-assembly               0.0.5                    py27_2    bioconda
pb-dazzler                0.0.1                h516909a_0    bioconda
pb-falcon                 0.2.7            py27hc0aa232_1    bioconda
pbalign                   0.3.2                    py27_0    bioconda
pbbam                     0.23.0               h88345a9_0    bioconda
pbcommand                 1.1.1                    py27_2    bioconda
pbcopper                  0.4.2                h3f2a3d2_1    bioconda
pbcore                    1.7.1                    py27_0    bioconda
pbgcpp                    0.0.1                         0    bioconda
pbmm2                     1.0.0                ha888412_0    bioconda
Describe the bug
In the reccomended lines for fc_run.cfg there is
pa_DBdust_option=true
Error message
Including this line will set the opitions of DBdust to "true" and the run will fail at that point
To Reproduce
Any run will fail with this line included
Expected behavior
run failure

I think if you use any legal option for this it is fine - but "true" is not one of them - this is more for the greedy snippet snatcher like me who didn't catch this - I actually debugged this down to the tmp directory where the corresponding job threw an error because of this.  By the way - this pipeline is such an amazing improvement over the state of affairs in 2013 when I first started using it.  Thank you for all the detailed improvements.

I updated our cfg files to the suggested parameter setting: "pa_DBdust_option=". It also does not appear with the "true" option in the README: https://github.com/PacificBiosciences/pb-assembly/blob/master/README.md. Is there somewhere else that you're seeing this suggestion @pwmcclurg ?


Add Render method on SearchService

Closes #860
This PR adds SearchService.Render() to generate a json representation of the constructed query. This is useful for debugging, bug tracking, etc.

Hmm. I must have missed that. I'll give it a look. Thanks!


[REQ] "Orchestrated Auto FastFlags Tab"

Acknowledgement of preliminary instructions

[X] I have read and acknowledged the preliminary instructions.

What idea do you have?
I don't know how I'd title this, I did the best I could do.
I had an idea for client settings, specifically changing the FastFlags tab. The presets could be an orchestrated list of tested client settings that can be hot-loaded (or whatever) from another GitHub repository.
Too make it more understandable- When the FastFlags tab opens, Bloxstrap fetches a GitHub file that loads this "orchestrated list" of FastFlags into the UI showing a lot (more) presets to pick. (These changes are partially to move client settings suggestions away from the Bloxstrap repo issues)
Here are some misc. changes:

Change the name of the FastFlags tab to Client Settings.
Move the save button away from the close button.

This would also make no deprecated flags stay on the list.

We're already working on that. It won't be in the next version though, it'll be in the version after.

Move the save button away from the close button.

What

Move the save button away from the close button.

What

When the save button is literally right next to the close button, you might accidentally press the close button and vice versa.

Why do you even have a close button when the windows close button is already there?

Because why not? I've never (or don't think I have ever) experienced accidentally clicking the close button, and I don't think anyone has ever complained about it for the past 2 years that Bloxstrap has existed. It makes saving then closing a lot easier.


CE selection: FP-Lots

Preparation

[X] No one has asked for this feature before in other issues (even the closed ones)

Describe the feature
When selecting which CE is to be used with a script, may I ask for some of the FP-Point options?
JP added a few additional FP-CEs over the last couple of months, so it would be helpful to have them in as well.

EDIT:
And Beyond The Rain Cloud as well of course.
As the crypter-CEs would probably clutter the selection-screen maybe one can filter/organize the CEs in accordance to their effect? i.e. folders for QP, Bond, FP, Combat and the like?

You can use Support Image Maker to add any servant/CE images you want.
We don't want to bundle too much stuff by default in the app, so you can DIY for what you need.
You could also just use a file manager to put the CE images in folders for QP, Bond, etc.
Making an in-app interface for this is not worth it.


fix(project): fix incorrect zip files on MacOS

This PR pins electron-builder dependency to ~20.28.4 as versions after that generate incorrect zip files on MacOS. See this for reference: https://github.com/thejoshwolfe/yauzl/issues/48#issuecomment-266587526 regarding the error produced by yauzl after upgrade.
Closes #1048

It seems like this particular commit in electron-builder broke the zip files: https://github.com/electron-userland/electron-builder/commit/a6c5bc4a

Could you create an issue in electron-builder so that there is a chance that this issue gets fixed upstream, some day, maybe? Or does the issue already exist?

Sure, I'll take care of this.

@nikku added issue here: https://github.com/electron-userland/electron-builder/issues/3534


[Feature request] Add a possibility to persist artifacts besides the model itself

At the moment, only the model can be persisted and loaded. However, there are scenarios that necessitate saving and loading additional data.
E.g., assume that we have a regression problem. We want to normalize the targets to a certain range during training but when calling the predict service, data should be mapped back to the original range. Touching the targets is not part of an sklearn pipeline, so we may do it during data loading. However, when we start the prediction service, we need to have access to the mapping. Currently, we would have to load the data again to generate the mapping, or try to save the mapping as an attribute of the model.
Ideally, we would be able to just save and load the mapping using palladium tools. The solution should not be too specific to the example above, but be a more general solution to how to persist additional artifacts.

Another way to deal with this is to move the normalization into a model wrapper (or "meta-estimator" in scikit-learn).  A NormalizeTarget wrapper would normalize on the way in and out.  The model is somewhat more self-contained this way, which may be good regardless.

Yes, for this specific case, that would work. For other cases, that could be an awkward solution. I could imagine that a more general solution would have a "cache" that is just stored together with the model, so that there is no need for handling separate files.

There's this utility called palladium.interfaces.annotate which is used by Palladium to store the model version along with the model pickle.  It's a glorified way of sticking an attribute onto the object before it's pickled.
To stick something in you would call annotate(model, {'useful': 'stuffs'}), and to get it out again (say in production, after loading): stuffs = annotate(model)['useful'].

Okay, so you would suggest to use this if extra data needs to be saved?

Okay, so you would suggest to use this if extra data needs to be saved?

Hmm, just had another look and it seems that at least palladium.persistence.Database assumes it can call json.dumps on the annotations.  (It then stores the metadata in a separate column.)  So this won't work for all types of data.
Which leaves us with what you already did I assume, which is sticking attributes on the model object.  Not too nice, but probably nicer than having to worry about storing extra data somewhere else and having to support that in all persisters.
If you prefer to use something like annotate, then we could make a trivial change and add other keys, besides __metadata__, to annotate.  (__metadata__ is what it's trying to be clever about when persisting.)

But isn't the model just a blob? Instead of persisting the model, could we not persist something like {'model': model, 'cache': cache}? That way, we don't need to store something extra and worry about keeping model and extra in sync.

@benjamin-work maybe you want to have a look at https://github.com/orgesleka/webscikit which has the feature you are looking for. It stores additional metadata at model.metada, which is just a dicitonary you can fill with additional data. The model itself is also stored in this metadatata. For example: If you have a RandomForestRegressor rfr you could store it as metadata['rfr'] = rfr and then later read it back at predict(new_data) or transform(new_data) with rfr = self.metadata['rfr']
You could also store additional metrics, or pandas.DataFrames if you want in metadata which would be usefull for later to predict(new_data).
Kind regards
Orges Leka


Add ContractSetupStarted Cfd event

Allow reasoning about started contract setup, to be able to constrain available
actions and present the Cfd state in the UI.
Reinstate the ContractSetup UI state, both in the frontend and in the actor tests.
I wasn't sure about accessing db in started(), so opted for now for returning the event along with SetupParams. Happy to change that if deemed to be wrong.

bors r+


PrefilledProps for form nested arrays

In SmartForms, add support for prefilled props for nested array elements

Hi, I am trying to unit test this but I don't get the expected behaviour.
If I write <Form prefilledProps={{addresses: { street: "foobar" }} /> for example, the problem is that {street: "foobar"} will be the prefilled value for the whole array too, so rendering fails.
Maybe I misunderstood the expected syntax? Should it be addresses.$ instead?

You can checkout the "ErikDakoda-FormNestedArrayPrefilledProps" branch on Vulcan, I've tested adding ".$" to the prop name to fill the array children instead of the array itself.

Hi @eric-burel! That looks like a good change. Thank you! Could you create a pull request for your version?

Yep it's merged, both having prefilled props for the whole array and for new items using ".$" will work. So you can even differentiate the first few values and subsequent values. Thanks!


[Bug] Wrong seriaization of higher dimensional ndarrays that have been transposed multiple times

Have a look at the following script:
from io import BytesIO

import asdf
import numpy as np

def print_array_information(name, array):
    print(name)
    print("---")
    print("data[0]")
    print(array[0])
    print(f"data c_contiguous: {array.flags.c_contiguous}")
    if array.base is not None:
        print("base[0]")
        print(array.base[0])
        print(f"base c_contiguous: {array.base.flags.c_contiguous}")
    else:
        print("base is 'None'")
    print("\n")

arr1 = np.array([[[0, 1], [-1, 0]], [[0, 1], [-1, 0]]], dtype=float)
print_array_information("array", arr1)

arr2 = arr1.transpose(0, 2, 1)
print_array_information("transposed array", arr2)

arr3 = arr2 * 1
print_array_information("multiplied transposed array", arr3)

arr4 = arr3.transpose(0, 2, 1)
print_array_information("transposed multiplied transposed array", arr4)

assert np.array_equal(arr1, arr4)

tree = {"root": arr4}

# Write the data to buffer
with asdf.AsdfFile(tree, ignore_version_mismatch=False,) as ff:
    buff = BytesIO()
    ff.write_to(buff)
    buff.seek(0)

# read back data from ASDF file contents in buffer
with asdf.open(buff, copy_arrays=True, lazy_load=False) as af:
    data = af.tree
    print(data["root"])
    assert np.array_equal(arr4, data["root"])

All it does is that it creates a 3d array, swaps the 2 innermost dimensions, multiplies it by 1, swaps the innermost dimensions again, and writes the resulting array arr4, which is equal to the original array arr1, to an asdf file/buffer. If you restore the data from the file/buffer, the assertion assert np.array_equal(arr4, data["root"]) fails. Observing the data shows, that the innermost dimensions are transposed. The outputs of the print_array_information method show where the issue comes from.
relevant arr1 output:
data c_contiguous: True
base is 'None'

relevant arr2 output:
data c_contiguous: False
base[0]
[[ 0.  1.]
 [-1.  0.]]
base c_contiguous: True

relevant arr3 output:
data c_contiguous: False
base is 'None'

relevant arr4 output:
data c_contiguous: True
base[0]
[[ 0. -1.]
 [ 1.  0.]]
base c_contiguous: False

The problem here is the following: Transposing a matrix "destroys" the "c continuity". Transposing it twice restores it. Multiplication, division, and probably several other operations keep the current "c continuity"/data interpretation but write to a new block of memory, which resets the arrays base.
Because of this,  arr3.base is None but arr3.flags.c_contiguous is False as it is for arr2, even though it uses a fresh memory location. Now if we transpose again, arr4 has  c_contiguous data but a non c_contiguous base. Why is this a problem and causes an error?
I have looked into the ndarray to_tree method.
https://github.com/asdf-format/asdf/blob/f5b5900dc45f0668d04281203ae1d9a1c0f8ea1c/asdf/tags/core/ndarray.py#L418-L432
Here you only check if data is  c_contiguous (line 425) and correct it if not. However, in the find_or_create_block_for_array method, which is used afterwards to get the data that should be written into the file (if I am not mistaken), you use the data of base (line738 - below) without checking if it's underlying order/"c continuity" is still correct:
https://github.com/asdf-format/asdf/blob/f5b5900dc45f0668d04281203ae1d9a1c0f8ea1c/asdf/block.py#L716-L745
I guess this is what causes the error. Maybe a simple fix would be to add this:
if not base.flags.c_contiguous:
    base = np.array(base)

or something similar after line 738, but I don't know if that would break some other stuff. However, creating a new numpy array with the "constructor"/__init__ method will fix the c_contiguous issue of the base, since it resets it. When you replace arr4 = arr3.transpose(0, 2, 1) with arr4 = np.array(arr3.transpose(0, 2, 1)) in the script, the assertion passes.
Additional Notes
If one removes the second matrix or reduces the dimension to 2d, the error disappears. So it seems to be a problem of higher dimensional arrays.
For reference, here are the version numbers of my setup:
Python Version: 3.7.7
Numpy Version: 1.18.1
ASDF Version: 2.6.0

Thanks for the thorough report!  I opened #827 with an idea for a fix, though I'm not sure if that's the best approach.
@perrygreenfield in the library we take pains to only write out the base array in C order or Fortran order, but I don't see anything in the ASDF Standard that requires that behavior.  In this case the original base array is in neither order, so we convert it to C order before writing.  The conversion doesn't play well with the strides on the ndarray view since they were specified relative to the original memory order of the base array.
I can think of a few options:

Write out the base array in its original memory order
Continue converting the base array to C order, and modify the strides on the ndarray view to match
Make a copy of the view array when we detect that the base array is not in C or Fortran order

My PR implements option 1).

Option 1 seems like the most foolproof. I can see problems with the others if there are multiple views in the asdf tree to the same array, wouldn't you. Either you must edit all the views to be consistent, or if making copies, the assumption that it is a view is broken.  Or do I misunderstand?

We might be able to edit all the views to be consistent, since the base array isn't modified until later on in the write process -- but I'd rather avoid that anyway because determining the correct strides for the new form of the base array sounds complicated.


SiteMap

Rather than manually building a footer menu it would be good to have a site map.
A method like PublishSite->PublishMenuJSON() could build a menu (site map) with each pagetype as a menu item with a submenu.
Each submenu (PageType) would have a menuItem for each page for that PageType.

Respond does build the sitemap.xml file automatically.  If you want a visual sitemap, it is really easy to build using the list component (see http://respondcms.com/plugin/list).  Just drag a list for each page type onto the screen.

Thanks
Good to know about the list component and the sitemap.xml but I was  meaning something like the footer of this site www.seek.com.
What I really meant was a footer menu with all the site. But not a high priority, I will build footer up manually.

You can probably use the same concept in the footer (e.g. repond-list).  I am going to close this b/c it is not a bug.


PBRT output partially garbled, occasionally

 Issue by benjamin-heasly
Thursday Feb 14, 2013 at 22:19 GMT
Originally opened as https://github.com/DavidBrainard/RenderToolbox3/issues/2

Sometimes PBRT outputs look garbled.  When this happens, the lower left corner of the rendering has stripes and black parts, as though the data were written or read from a buffer with incorrect element size, stride, alignment, etc.
I've only noticed this with small renderings, about 100x100 pixels or smaller.
As far as I can remember, this only happens on my 2008-era Mac Book.
This would be a pain to debug, since the problem could happen as far upstream as the pbrt-v2-spectral Film implementation, and as far downstream as RenderToolbox3 MakeMontage()!
This bug is not yet problematic for any particular use case.

I'm going to close this to clean up the issues list.


Select Widget in @material-ui/core not working in native={false} mode

The select widget in @materila-ui/core is not working when native mode is false

Please provide a minimal reproduction test case. This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!

The error is sheetManager is not available

But while is use it in codesandbox i cant repopulate

@DomnicAmalan Let us know when you can. You might have an issue in your bundling steps


Mark priority mempool config fields as deprecated

The priority mempool was marked as deprecated for v0.37.x in #259. The mempool config fields TTLDuration and TTLNumBlocks are only used by the priority mempool and will be deleted in v0.38.x, but we forgot to marked them as deprecated. This PR fixes it.

The changes LGTM, however, could we also add a warning message, similar to what was done here?

Thanks @sergio-mena, I added the warning messages.


Support binary logical attributes

For #3758, implements the RFC in #3884
Change List

Drops support for external attributes in top-level props
Add attribute.setBinaryValue, support auto-packed attributes
Unit tests

TODO (follow-up PRs)

PathLayer
SolidPolygonLayer

Coverage increased (+2.7%) to 83.568% when pulling 24285eb83389c87f366885dfacd8beb97c622c82 on x/binary-logical-attributes into b4ce2e3424d356f7aa92ac16d567db3cbf244bd0 on x/variable-width-auto-update.

@tsherif What do you think of:

revert setVirtualBuffer back to setExternalBuffer (both Buffer instance and typed arrays are supported in this path)
rename setLogicalBuffer to setPackedDataSource (only typed arrays are supported)

Doing to a deep review on this now, will take some time, my initial thoughts are just as @tsherif says that we need to sort out the naming here. I will review carefully and also think about this from the perspective of the GPUTable proposal and see if we can align with that.
PS - I am 100% onboard with dropping support for external buffers in props, but can we still have a check for those props and just issue errors/warnings if we see them? These things tend to be very tricky for application upgraders to figure out, they are sometimes updating the deck.gl version in an app they haven't touched in over a year and now it will fail silently or at least mysteriously due to some obscure prop no longer being read...

Maybe setPackedDataSource -> setPackedArray? Otherwise, LGTM.

setPackedArray

I don't think this name offers sufficient clarity - we will still need to explain what packed means and how it relates to the value of the attribute.
I kind of like the term "logical" here. We also have logicalType in Attribute that may be GL.DOUBLE. If the main concern is Buffer vs Array maybe we can use setLogicalValue?

The term "logical" doesn't really say anything to me about the data. Is this usage common? I might just be missing the reference.
Either way, I'm ok with it as long as the definitions are documented.

@ibgreen Merging for now. If you have more comments I'll address in follow up PRs.


Location prompt should filter based on support for Elastic Premium plans

Repro steps:

Turn on advanced creation
Create a function app in West US 2

Expected:
The location prompt step only shows locations that support elastic premium
Actual:
The location prompts shows a bunch of locations and you get this error message:
Action: azureFunctions.deploy
Error type: Conflict
Error Message: The pricing tier 'ElasticPremium' is not allowed in this resource group. Use this link to learn more: http://go.microsoft.com/fwlink/?LinkId=825764
Version: 0.17.0
OS: win32
Product: Visual Studio Code - Insiders
Product Version: 1.34.0-insider
Language: en

Call Stack
module.exports.l.pipeline extension.bundle.js:262:3376627
s extension.bundle.js:262:110821
s extension.bundle.js:164:25754
extension.bundle.js:164:26994extension.bundle.js:164:26994
o extension.bundle.js:208:58625
extension.bundle.js:164:24675extension.bundle.js:164:24675
$.module.exports.t.requestLibrarySink.t.headersOnly.t.streamedResponse.t.body.function.t.body.pipe.a [as _callback] extension.bundle.js:1:606007
$.module.exports.$.init.t._callback.t.callback.t.callback extension.bundle.js:238:5462
$.emit events.js:182:13
$.<anonymous> extension.bundle.js:238:18275
$.emit events.js:187:15
IncomingMessage.<anonymous> extension.bundle.js:238:17117
Object.onceWrapper events.js:273:13
IncomingMessage.emit events.js:187:15
endReadableNT _stream_readable.js:1090:12
process._tickCallback next_tick.js:63:19

You probably already know, but there is this command this._client.listSkus.  I think SkuInfos might have the capabilities of the SKU.


console info snippet

added a new snippet that converts to a console.info call

Thanks a lot for the contribution and sorry for my late response.


Whitelisting LiteLLM Models

Bug Report
Description
Bug Summary:
Whitelist functionality to only show specific models are not applying to LiteLLM models. It's only currently working for local models, and models using the OpenAI API. The only way to make whitelisting work with LiteLLM models is to add it to the environment variables when creating the docker container.
Steps to Reproduce:
Configure Whitelist of models in the UI in the Admin Panel > Admin Settings > Users > Model Whitelisting
Expected Behavior:
Models that are not whitelisted should not be visible to the "users" group.
Actual Behavior:
LiteLLM models are displaying for users in the "user" group even though they are not added into the whitelist.
Environment

Operating System: [e.g., Windows 10, macOS Big Sur, Ubuntu 20.04]
Browser (if applicable): [e.g., Chrome 100.0, Firefox 98.0]

Ubuntu 22.04.4 LTS (GNU/Linux 5.15.0-101-generic x86_64)
Browser: Edge Version 123.0.2420.53 (Official build) (64-bit) and Chrome Version 123.0.6312.59 (Official Build) (64-bit)
Reproduction Details
Confirmation:

[ X] I have read and followed all the instructions provided in the README.md.
[X] I am on the latest version of both Open WebUI and Ollama.
[ ] I have included the browser console logs.
[ ] I have included the Docker container logs.

Logs and Screenshots
Browser Console Logs:
[Include relevant browser console logs, if applicable]
Docker Container Logs:
[Include relevant Docker container logs, if applicable]
Screenshots (if applicable):
[Attach any relevant screenshots to help illustrate the issue]

Installation Method
Installed Ollama via the command:
curl -fsSL https://ollama.com/install.sh | sh
Installed Open-WebUI using docker command:
docker run -d -p 3000:8080 --add-host=host.docker.internal:host-gateway -v open-webui:/app/backend/data --name open-webui --restart always ghcr.io/open-webui/open-webui:main
Additional Information
The workaround is to add environment variables into the docker command.
-e MODEL_FILTER_ENABLED=True
-e MODEL_FILTER_LIST="gemma:latest" \
Note
If the bug report is incomplete or does not follow the provided instructions, it may not be addressed. Please ensure that you have followed the steps outlined in the README.md and troubleshooting.md documents, and provide all necessary information for us to reproduce and address the issue. Thank you!

Thanks for your help in diagnosing this one on Discord @rfernandez760 🙏

Should be fixed on our dev branch, let me know if the issue persists!


Template strings not properly parsed

Template strings (new feature of TS 1.4) don't seem to be properly handled.
Working example:
throw new Error(`ruleSet "${ruleSet.description}" has no defined output tied to type: ${rule.type}`);

Not working example:
throw new Error(`ruleSet "${ruleSet.description}" has no defined output for type: ${rule.type}`);

Output:
(curly) service.ts[89, 93]: for statements must be braced
(no-unused-expression) service.ts[89, 103]: expected an assignment or function call
(no-unused-expression) service.ts[89, 103]: expected an assignment or function call
(no-unused-expression) service.ts[89, 105]: expected an assignment or function call
(no-unreachable) service.ts[89, 93]: unreachable code
(semicolon) service.ts[89, 113]: missing semicolon

In this example, for was interpreted as an instruction instead of a template string. It results in several errors.

Which version of tslint are you using?

Wrong repository: sorry, I was using gulp-tslint


genesis file does not match chaindata

Hi,
Running private network in Hyperledger-Besu. Node is stopped due to 'genesis file does not match with chaindata'. But we cannot modify the genesis file.
How to restore blocks from the chain?

Hi @neoblock8, thank you for opening this GH issue. Have you took a look at this in the docs? https://besu.hyperledger.org/en/stable/HowTo/Troubleshoot/Troubleshooting/#supplied-genesis-block-does-not-match-stored-chain-data


Now performs Module Validation for all META-INF/services entries

Now will try to directly load the META-INF/services folder after processing ends and validate whether the module-info has the required provides statements.

After a bit more testing this doesn't work as the other processors suddenly become unable to write services files

the other processors suddenly become unable to write services files

Got it working actually


[kitchen] Increase disk size of runners to avoid out of space errors

What does this PR do?
Increases main disk size for kitchen VMs.
Motivation
Prevent tests from failing to install the Agent package due to lack of space.

Superseded by #6006.


Notify a user that a repo does not have this branch. close #661

Deploy preview for landscape ready!
Built with commit 6f50a19f1e87af396796dd5493d47bc97fda7d2e
https://deploy-preview-664--landscape.netlify.com


fix: add class lozad to Defer offscreen images

https://community.e-com.plus/t/performance-da-loja-no-mobile/233/2?u=leonardo


Add CHECKSUM file to the release page

This PR adds CHECKSUM file to the release page.
Currently, everything in dist/release/ on the build machine(travis) is
pushed to release page as in the deploy job config in travis configuration
So, this PR just loops around contents of dist/release and generates sha256
for each file in the folder and puts them in a file by name CHECKSUM in the
same path(dist/release/) expecting it to be uploaded to the release page.
fixes #736
Signed-off-by: anmolbabu<EMAIL_ADDRESS>

Verified as in https://github.com/anmolbabu/odo/releases/tag/v0.0.13

Verified as in https://github.com/anmolbabu/odo/releases/tag/v0.0.13

Each filename in CHECKSUM is prefixed with ./dist/release/, ideally it should be just a filename
also it might be better to call  it CHECKSUMS 😊

Also, in the file is sum for CHECKSUM file itself, that is not valid. This shouldn't be there.
It might be good to rename it to SHA256_SUM or something like that to indicate what hash algorithm is used.

Force Merging based on acks from @kadel and @cdrage and after incorporating comments(https://github.com/redhat-developer/odo/pull/781#discussion_r223101172) from @cdrage


Disabled tab navigation issue fix + library update

Fixed an issue where tab navigation should be disabled when using 'tabs' stepper feedback & disabled tab navigation attribute (issue #105).
Updated Android Support Library to 25.3.1
Updated library version to 3.2.1

Codecov Report

Merging #106 into master will decrease coverage by 0.15%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master    #106      +/-   ##
===========================================
- Coverage     46.26%   46.1%   -0.16%
  Complexity      109     109
===========================================
  Files            22      22
  Lines           871     874       +3
  Branches         84      84
===========================================
  Hits            403     403
- Misses          404     407       +3
  Partials         64      64

Impacted Files
Coverage Δ
Complexity Δ

...per/internal/feedback/TabsStepperFeedbackType.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...main/java/com/stepstone/stepper/StepperLayout.java
33.99% <0%> (-0.23%)
17 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2706769...97aa761. Read the comment docs.


Move from Travis CI to GitHub Actions (8.x)

This is the Opencast 8 version of #2086
This moves the testing from Travis CI to GitHub Actions and expands the automation along the way by automatically updating translations on a weekly basis.
The move was planned for a while but accelerated due to Travis CI's new pricing which might easily cause problems otherwise.
Disable Travis CI
This patch disables the old Travis CI builds which will soon be causing
problems in their old form due to Travis CI's new pricing
Automatically Update Translations
This patch adds a workflow which will automatically update the
translations on develop and the latest three release branches every
Monday at 5am UTC.
Automatically Update Crowdin Keys
This patch adds a workflow which will automatically update the
translation keys on Crowdin after each push on develop or any release
branch.
Opencast CI Tests
This patch moves the CI tests from Travis CI to GitHub Actions. Every
push and every pull request will run the following tests:

Check if documentation builds using mkdocs
Run markdownlint on documentation
Perform a database upgrade from 2.2 onwards with MariaDB
Perform a database upgrade from 2.2 onwards with MySQL
Run admin interface front-end tests in Firefox
Run admin interface front-end tests in Chrome
Build Opencast with Java 8

Good catch. Fixed.


Files for topic circuitpython

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md.
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[x] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[x] Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
[x] Content (and my changes are in index.md)

This adds context to the existing tag circuitpython

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Foo

gh pr checkout 2968


Events not ingested when run as a plug-in app under Docker

The plug-in app should support Docker in theory (we include Linux binaries), but even with the GELF port mapped, events aren't currently ingested. Needs investigation. (Under Docker, using datalust/sqelf is recommended anyway, so this is not a critical issue.)

I think the subtelty here is how Docker wants you to map udp ports:
-p 12201:12201/udp

I gave this a test as a Seq app and it did seem to work out ok when the ports were opened, so I'll go ahead and close this one now.


UploadDirectory" calls GetListing MLSD with spaces in FilePath causing error

FluentFTP Version: 47.0.0
Framework: .NET 6
I am facing issue with upload directory with spaces in directory path
my code is
string rootpath = @"/non-prod-ftp";

//working fine with below directory as directory with no spaces
         //string dirPath = @"\non-prod-ftp\WebsiteTestFiles\dev\invoices-staging\bvk\20230811_101_City_and_County_of_D7";

//not working with belwo directory as direcorty having spaces
	   string dirPath = @"\non-prod-ftp\WebsiteTestFiles\dev\invoices-staging\bvk\20230811_101 City and County of D7";

 using var ftpClient = new AsyncFtpClient(ftpServer, username, password);
		  ftpClient.Config.LogToConsole = true;
		  await ftpClient.Connect();
		  await ftpClient.SetWorkingDirectory(rootpath);
var ftpResult = await ftpClient.UploadDirectory(localDirPath, dirPath, mode: FtpFolderSyncMode.Update, existsMode: FtpRemoteExists.Overwrite, verifyOptions: FtpVerify.Retry).ConfigureAwait(false);
 Console.WriteLine("FTP operations completed successfully.");

Attached logs
first time execution: Didnot throw exceptions but showing errors
upload_working.txt
second time execution : no change in code but throwing exception .
upload_notworking.txt
Please provide solution for the above scenerio upload directory with empty spaces in directory path.

Please provide solution for the above scenerio upload directory with empty spaces in directory path.

Maybe we are not the right people to ask.
If you read through: rfc3659, you will find under "2.2.  Pathnames" a specification as to how a server should handle pathnames.
Your previous issue, #1309, concerned basic APIs, like GetListing etc, whose behaviour you can customize to a certain degree if it is needful. For example, force using the LIST command to avoid problems with MLSD etc., you get what I am alluding to, I hope. Meaning to say: If the server does not implement the RFCs in the right way, you can use the basic APIs and even use very very basic Execute commands of your own to some communicate with the server. Or, you or some other poor guy who needs to communicate with a very special badly behaved FTP server can write a server extension for FluentFTP to handle these quirks.
Now, UploadDirectory assumes internally that it can use GetListing in the standard fashion, and this then uses MLSD in the standard fashion, since there is no custom replacement provided for that server (WSFTP).
Just like your own solution to #1309, you might want to code the UploadDirectory process yourself step by step and could achieve a solution as quickly as possible yourself - referring to the code of UploadDirectory, I can see it is not a big thing. All you would need is to put in the ForceList so that MLSD is not used.

And thanks for a good doc and clear problem desc.

@FanDjango ,
I've successfully implemented a custom directory upload method that handles spaces in the directory path. This method effectively uses the fluent FTP upload stream functionality, with added retry capability for enhanced reliability. Notably, I've avoided utilizing the Upload File method due to its internal use of the Get method, which conflicts with spaces in directory names.
During extensive testing, I've validated the custom upload directory method across various scenarios, including directories containing subdirectory1 300 files of 1 MB each, subdirectory2 with 10 files of 1 MB each, as well as files of sizes 200 MB and 300 MB in subdirectory3. The results have been consistently positive.
Thank you for your great support.

Thanks. I am sure that your code is not extremely complex, so I think for the moment it is the best solution.
One thing we never ever cleared up, and perhaps if you have time to try it, you could do me a favor:
Can you manually try the following, but it is not urgent.
client.SetWorkingDirectory("...path...with   spaces...")
client.GetListing("", FtpListOptions.NoPath)

Does that work for your WsFTP? It should then use only a clean MLSD without any parameters.
Perhaps it is for us to make an improvement in some of our internal APIs to get around problems of this kind, that we go CWD, then MLSD, then back to original WD.

I have opened up a "new" issue to address this topic in a more general fashion and some time in the future, this will be improved.
I am going to close this one, as I think we have reached a final point.

Thanks. I am sure that your code is not extremely complex, so I think for the moment it is the best solution.
One thing we never ever cleared up, and perhaps if you have time to try it, you could do me a favor:
Can you manually try the following, but it is not urgent.
client.SetWorkingDirectory("...path...with   spaces...")
client.GetListing("", FtpListOptions.NoPath)

Does that work for your WsFTP? It should then use only a clean MLSD without any parameters.
Perhaps it is for us to make an improvement in some of our internal APIs to get around problems of this kind, that we go CWD, then MLSD, then back to original WD.

@FanDjango  ,
Below code is working fine  in WS_FTP server. I have also attached logs which might be useful.
client.SetWorkingDirectory("...path...with   spaces...")
client.GetListing("", FtpListOptions.NoPath)

GetListingWithNoPath.txt

Very many thanks for this confirmation, you can see I opened a "general" issue concerning this topis and am evaluating possible avenues to improve this.
Too late for you, but perhaps when sometime this is improved you might move back to the FluentFTP own API on this.

See #1322


Editing fields on Review screen of sign-up doesn't work

Fails silently in production (nothing happens when clicking on edit button), fails with error in development (see attached image)

i wonder if this is similar/related to this bug that i fixed in the community templates branch: https://github.com/Hylozoic/hylo-evo/issues/579

Perhaps. I looked at the issue briefly when I noticed it and it seemed not
too difficult to track down. Likely something ref's related and has
probably been broken for a long time (likely since upgrade to React 16)
On Thu, Oct 29, 2020 at 8:22 AM Tibet Sprague<EMAIL_ADDRESS>wrote:

i wonder if this is similar/related to this bug that i fixed in the
community templates branch: #579
https://github.com/Hylozoic/hylo-evo/issues/579
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Hylozoic/hylo-evo/issues/685#issuecomment-718936690,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAABRFVWVURYL35V53BTBBDSNGXGPANCNFSM4TDR6S2A
.


markdown: Improve treatment of horizontal rules.

This PR improves the display of horizontal rules by a) having them participate with other information-density values and b) aligning them better, though not perfectly, when they open a message.
CZO discussion

Screenshots and screen captures:

Before
After

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Merged, thanks @karlstolley!


Client not disconnecting when trying to subscribe an unauthorised topic

Environment

VerneMQ Version: 1.11
OS: CentOS 7.6
Erlang/OTP version (if building from source):
VerneMQ configuration (vernemq.conf) : using redis based acl authentication/authorisation
Cluster size/standalone: 2 Node

Expected behaviour
Disconnect client when tried to subscribe an unauthorised topic.
Actual behaviour
We are mqtt client version 3.1.
At vernemq server we are using redis based authentication/authorisation. ACLs are added in realtime, so a ACL can be added for a client-id which is already connected now. If we add a ACL for publish and connected client wants to publish added topic and got disconnected, to overcome this we implemented auto reconnect feature. But if same issue occurs for subscription ACL client is not disconnecting from server and not getting updated ACL. How can we overcome this issue.
Example:
Say, my client-id is "test-client" and it is connected to server now.
adding a publish_acl for client id "test-client" to topic "a/b/c".
SET "[\"\",\"test-client\",\"test-user\"]" "{\"passhash\":\"$2a$12$WDzmynWSMRVzfszQkB2MsOWYQK9qGtfjVpO8iBdimTOjCK/u6CzJK\",\"publish_acl\":[{\"pattern\":\"a/b/c\"}]}"
Now if my connected client with client-id "test-client" wants to publish in topic a/b/c, it will disconnect and my application automatically reconnect and get the updated ACL and can publish in a/b/c topic.
Now i am adding a "subscribe_acl" for client id "test-client" to topic "d/e/f".
SET "[\"\",\"test-client\",\"test-user\"]" "{\"passhash\":\"$2a$12$WDzmynWSMRVzfszQkB2MsOWYQK9qGtfjVpO8iBdimTOjCK/u6CzJK\",\"subscribe_acl\":[{\"pattern\":\"d/e/f\"}]}"
Now if my connected client with client-id "test-client" wants to subscribe on topic d/e/f. In this case client is not disconnecting nighter getting any data because connected session don't have updated ACL info.
How can i overcome this issue? I am fully stuck here.

@zia069 your assumption is that an invalid SUBSCRIBE attempt will result in a server side disconnect. This is not the case. The server will still SUBACK with a failure code (128) but keep the connection.
As the ACL cache is set at connect time, you also don't see the updated ACL in the session. But that's exactly why there's the vmq-admin session reauthorize API you could call somehow after updating the ACL (in case you know for which Client).
Admittedly... this is not beautiful.

@ioolkos thank you for you quick response.
Is mqtt version 3.1 support SUBACK?
As i am thinking if client receive SUBACK with failure code (128) it will reconnect again.

@zia069 I suppose you have been able to sort this out, so closing the issue.


Make FileCheck a private Carthage dependency

What's in this pull request?
Renamed Cartfile to Cartfile.private.
Why merge this pull request?
Right now when installing SwiftCheck using Carthage, FileCheck dependency is fetched as well. As this is only a private test dependency, it should be moved to Cartfile.private.
This reflects the behavior of other supported package managers – Package.swift declares FileCheck as a test dependency and SwiftCheck.podspec doesn't mention it at all.

Thanks!
⛵


Fix info in README on metadata fallbacks in formatters' configs

The third element has to be an "semi-iolist".

:+1:


DBZ-5632 Incremental snapshot completion notifications

Added an optional configuration property to switch between logging snapshot completion status (LogSnapshotStatusNotifications - default) and sending the notification into a Kafka topic (KafkaSnapshotStatusNotifications).
A Kafka notification format:
Key = test_connector
Value = {"id" : "1b8d98f4-53ec-4beb-aa14-73ea35f185e7", "type":"incremental-snapshot", "data-collections": "schema1.table1", "additional-condition" : "updated_at>='2022-09-20'", "status" : "SUCCEEDED"}
Snapshot completion statuses:
EMPTY,
NO_PRIMARY_KEY,
SQL_EXCEPTION,
STOPPED,
SUCCEEDED,
UNKNOWN_SCHEMA

Closes: https://issues.redhat.com/browse/DBZ-5632

@kgalieva Hi thanks a lot, this is a great piece of work! Still I'd like to ask you to modify it a bit.

I've linked two other Jiras - we intend to provide an adminsitrative/notification topic we would like to use for sending messages like snapshot completed, incremental snapshot status as in this PR etc. It would be great to refactor this PR in a way that there will be generic notification service and this PR will provide incremental snapshot related messages.
The notification implementation for Kafka should be implemented in a different way - instead of using Kafka API to send the message the notification should send a notfication message via standard Kafka Connect channels. This way it won't be necessary to provide Kafka connection settings and at the same time it will be compatible with arbitrary sinks not only Kafka (for Debezium Server)

What is your opinion?

@kgalieva Hi, there is a https://github.com/debezium/debezium/pull/4515 from @mfvitale that introduces generic notificationmechanism and SPI. Would you be willing to take this PR and update it to intorduce Kafka notification channel based on that generic mechanism?
Thanks

Hi @jpechane! I think, https://github.com/debezium/debezium/pull/4515 already has Kafka notification channel Did you mean adding incremental snapshot completion notifications using the new generic notifications mechanism?

@kgalieva I am sorry for the confusion. I for whatever reason thought that you are using Kafka Client APIfor sending messages but you are right, it is the same. Could you please let us know then if the other implementation is fine from your PoV or if something is missing? Thanks

@kgalieva Thanks for confirmation. Closing this PR in its favour then.


PIP should have a way to tell if it's already assigned to some NIC/LB or available

that way you can tell if you can use a PIP for a VM or not. Portal has this knowledge.

see PIP's ipConfiguration()

addressed in https://github.com/Azure/azure-sdk-for-java/pull/1083/commits/210d02f423366620f1a50dc84336a7821c3601d2 and https://github.com/Azure/azure-sdk-for-java/commit/05bedf4c0154ac32e8a101d358c1529ea8f022b5


Issue with Histogram for Recursive QAOA

Information

Qiskit Aqua version: 0.8.0
Python version: 3.8.5
Operating system:  Windows 10, 64bit

What is the current behavior?
spsa = SPSA(maxiter=250)
backend = Aer.get_backend('qasm_simulator')
qaoa_mes = QAOA(optimizer=spsa, quantum_instance=backend)
qaoa = MinimumEigenOptimizer(qaoa_mes)
#result = qaoa.solve(qp)
cutoff = 3
rqaoa_solver = RecursiveMinimumEigenOptimizer(min_eigen_optimizer=qaoa, min_num_vars=cutoff,min_num_vars_optimizer=exact)
result2 = rqaoa_solver.solve(qp)
print(result2)
Steps to reproduce the problem
plot_histogram(result.min_eigen_solver_result.eigenstate, bar_labels=False)
What is the expected behavior?
It does not show a histogram for rqaoa
Suggested solutions
How can we plot the histogram for rqaoa algorithm also after solving the qubo problem. Because recursive eigensolver does not support histogram attribute

Aqua has been deprecated and the code for optimization has been moved to qiskit-optimization so I am transferring this there.


Feat: To make products/mobile deals section display as CARDS

Issue: #454
final result:

@arghadipmanna101


How to add image to the table view

Hello team. I am planing to work with this project. But I have a question how I can add image. When I try to add sit detail it's only need name description and the free version. How to add image in that. In the front end sit it showing image

Based on the conversation I got answer. So I closing the issue


Upgrade sandpack to fix code cutting issue in view only editor

Addresses

https://github.com/reactjs/reactjs.org/issues/3308#issuecomment-1046023982

I've upgraded 0.13.16-experimental.0 to 0.14.1 and build fails @danilowoz Is there any recommended version to upgrade?

seems worse after the fix because now it's focusable and has a cursor in it. also, you can "tab" inside.


[Forms][iOS] Error CS1703 Multiple assemblies with equivalent identity

I have a Xamarin cross client project which contain signalr. If i add the nuget package Microsoft.AspNetCore.SignalR.Protocols.MessagePack (all Versions) i get this error.
the package includes the reference to System.Reflection.Emit.
i found some workarounds to fix the error for example this:
<PackageReference Include="System.Reflection.Emit">
  <Version>4.3.0</Version>
  <ExcludeAssets>all</ExcludeAssets>
</PackageReference>

but it does not work i get an runtime error if i create an instance of an hub.
the nuget package is in a .net standard 2.0 Assembly which referenced.
please can someone remove the reference ?
Thx

We can't remove the reference because it comes from the message pack library we use (https://github.com/neuecc/MessagePack-CSharp), so they would have to remove the dependency. I believe it isn't used in our default configuration though, so it should continue to work. Can you provide a sample project that fails and describe where the failure occurs?

SampleProject.zip
Here the sample Project if you compile the ios project the failure occurs

I opened also an issue on the massagepack project !!!
https://github.com/neuecc/MessagePack-CSharp/issues/328

Looks like this is going to be part of fixing https://github.com/aspnet/SignalR/issues/3122. I'm going to close this and we can move discussion there.

Now we have the same with the signalR Client but other DLL.
https://github.com/xamarin/xamarin-macios/issues/5135#issuecomment-439597542
warning MSB3276: Found conflicts between different versions of the same dependent assembly. Please set the "AutoGenerateBindingRedirects" property to true in the project file. For more information, see http://go.microsoft.com/fwlink/?LinkId=294190.
MTOUCH : warning MT0109: The assembly 'System.Threading.Tasks.Extensions.dll' was loaded from a different path than the provided path (provided path: /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Threading.Tasks.Extensions.dll, actual path: /Users/macuser/src/SignalRTaskExtensions/packages/System.Threading.Tasks.Extensions.4.5.0/lib/netstandard2.0/System.Threading.Tasks.Extensions.dll).


Holes on top of panels

As of 1.12.2-1.9.7k, the top side of panels have holes / missing faces depending on what block is placed above:

Unfortunately this is necessary in order for the glass panes to not have bars in them and destroy the continuous effect.

I don't see why your mod wouldn't be able to do what other mods did in the past.

Show me

Vanilla panel on top, WarpDrive omnipanel on bottom

Yes.  It makes a horizontal bar on the interior of the glass like that.  Which is what I was trying to avoid.  I don't know a way around it at the moment.

that extra horizontal bar is fairly minor compared to missing it completely


sf::Music assertion failure when using Singleton

Prerequisite Checklist

[X] I searched for existing issues to prevent duplicates
[X] I searched for existing discussions on the forum to prevent duplicates
[X] I am here to report an issue and not to just ask a question or look for help (use the forum or Discord instead)

Describe your issue here

static void sf::priv::AudioDevice::unregisterResource(ResourceEntryIter): Assertion `instance && "AudioDevice instance should exist when calling AudioDevice::unregisterResource"' failed.

Introduced in this commit.
https://github.com/SFML/SFML/commit/cede2def8bd74f5bffd3044d27fcceccaaae56c2
Your Environment
Linux, GCC 13.1
Steps to reproduce
#include <SFML/Audio.hpp>

template <typename T>
class Singleton {
public:
	static T& the()
	{
		static T instance;
		return instance;
	}
};

class Test : public Singleton<Test> {
public:
	std::unique_ptr<sf::Music> music;
};

int main()
{
	Test::the(); // no issue if this line is commented out

	Test::the().music = std::make_unique<sf::Music>(sf::Music::openFromFile("input.ogg").value());

	// Test::the().music.release(); // no issue if this line is uncommented

	return 0;
}

Expected behavior
.
Actual behavior
.

The reason this is happening is because this exact code construction manages to swap the ordering of destruction of the AudioDevice and the sf::Music. The assumption made in cede2def8bd74f5bffd3044d27fcceccaaae56c2 was that the order of destruction would always be the opposite of construction but your code demonstrates this doesn't always have to be the case. I can't think of any other solution than to revert cede2def8bd74f5bffd3044d27fcceccaaae56c2 if we want to keep supporting the use case you described here.

I guess the question is, what is the tangible benefit of the commit? It looks like it was primarily an optimization? I have a hard time imagining the cost of reference counting being meaningful here.

I had my doubts as well in #3089, but in the end we ended up giving it a shot. I guess it turns out it didn't really work out as planned.

Surely #3147 must be reverted to support these particular use cases, however I am curious about the actual "real" code that caused this @danieljpetersen -- seems like the lifetime management could be simplified quite a bit, not sure why you'd ever need a sf::Music inside a std::unique_ptr inside a singleton...

I'm not sure why you felt the need to put real code in quotes. I'm also not sure why you felt the need to comment and chastise me for this given that you admit that we must revert, and also given that you quite publicly left the project.
I had an old project that I wanted to compile. It stored music on a singleton. I am not the only person that I know of who stored some SFML objects on singletons. I wrapped it in a unique pointer because that's how I chose to solve the issue in other contexts, and I wanted to deal with the removal of default constructors in a consistent manner. Wrapping them in a unique pointer seemed the least offensive way of doing so.
While I'm at it, I want to once again reiterate how unacceptable that change was to me. I've been using SFML for more than a decade, I root for and love this lib. I've now migrated away from SFML because of that change. I was trying to not come across as unhinged in my issue about that, but I perhaps underplayed how much I disliked it.
Cheers

I didn't put "real" in quotes to mock it, I put the quotes to emphasize that I wanted to see the real code and not a simplified example.
I did not mean to chastize you at all -- I apologize if you felt that way. What I wanted is to provide advice on simplifying the lifetime hierarchy of your resources as the snippet you posted seemed overly complex.
I also don't mind that the change needed to be reverted, 3.x is work-in-progress and trying things out means that sometimes they do not work out, reverting is a totally fine decision in this case if these use cases need to be supported.
Leaving the project also doesn't mean I don't want to be involved with it in any way or form in the future.

I wanted to deal with the removal of default constructors in a consistent manner. Wrapping them in a unique pointer seemed the least offensive way of doing so

I will reiterate, as mentioned in https://github.com/SFML/SFML/issues/3120#issuecomment-2184263169, that it is not necessary to reintroduce empty states via unique pointers or std::optional, and in fact that choice will make your user experience much worse than it needs to be -- the sf::Music doesn't need to be wrapped in any additional layer, it can be initialized through the constructor.
struct Test : public Singleton<Test>
{
    sf::Music music = sf::Music::openFromFile("input.ogg").value();
};

I was interested in seeing the real code to understand if the std::unique_ptr was somehow really necessary, or not.

https://github.com/SFML/SFML/compare/master...audio_construction_order_crash
I'm trying to write a test to recreate this crash but can't get it to fail. Did I not properly copy your example code?

master...audio_construction_order_crash
I'm trying to write a test to recreate this crash but can't get it to fail. Did I not properly copy your example code?

@ChrisThrasher: I can reproduce the issue with this code:
#include <SFML/Audio/Music.hpp>

#include <iostream>
#include <optional>

template <typename T>
class Singleton
{
public:
    static T& getInstance()
    {
        std::cout << "Singleton<T>::getInstance()\n";

        static T instance;
        return instance;
    }
};

struct MusicSingleton : Singleton<MusicSingleton>
{
    MusicSingleton()
    {
        std::cout << "MusicSingleton::MusicSingleton()\n";
    }

    std::optional<sf::Music> music;
};

int main()
{
    std::cout << "-- start of main --\n\n";
    MusicSingleton::getInstance();
    std::cout << "\n-- after first getInstance --\n\n";
    MusicSingleton::getInstance().music = sf::Music::openFromFile("resources/ding.flac").value();
    std::cout << "\n-- end of main-- \n\n";
}

Adding some printing to the various pieces involved explains why it fails:

Original example

Removing first `MusicSingleton::getInstance();` call

-- start of main --

Singleton<T>::getInstance()
MusicSingleton::MusicSingleton()

-- after first getInstance --

Music::openFromFile(...)
::getDeviceState()
DeviceState::DeviceState()
AudioResource::AudioResource() | rc = 1
AudioDevice::AudioDevice()
Music::Music(...)
::getDeviceState()
AudioResource::AudioResource() | rc = 2
Music::~Music()
::getDeviceState()
AudioResource::~AudioResource() | rc = 1
Singleton<T>::getInstance()
::getDeviceState()
AudioResource::AudioResource() | rc = 2
Music::~Music()
::getDeviceState()
AudioResource::~AudioResource() | rc = 1

-- end of main--

DeviceState::~DeviceState()
AudioDevice::~AudioDevice()
Music::~Music()
~SoundStream::Impl()
MiniaudioUtils::SoundBase::~SoundBase()
AudioDevice::unregisterResource(...)

(!) Assertion failed: "..."

-- start of main --

-- after first getInstance --

Music::openFromFile(...)
::getDeviceState()
DeviceState::DeviceState()
AudioResource::AudioResource() | rc = 1
AudioDevice::AudioDevice()
Music::Music(...)
::getDeviceState()
AudioResource::AudioResource() | rc = 2
Music::~Music()
::getDeviceState()
AudioResource::~AudioResource() | rc = 1
Singleton<T>::getInstance()
MusicSingleton::MusicSingleton()
::getDeviceState()
AudioResource::AudioResource() | rc = 2
Music::~Music()
::getDeviceState()
AudioResource::~AudioResource() | rc = 1

-- end of main--

Music::~Music()
~SoundStream::Impl()
MiniaudioUtils::SoundBase::~SoundBase()
AudioDevice::unregisterResource(...)
::getDeviceState()
AudioResource::~AudioResource() | rc = 0
AudioDevice::~AudioDevice()
DeviceState::~DeviceState()

-- all is well --

Basically, the first Test::the(); call ends up putting the music singleton on top of the stack of globals to be destroyed. When the music is created next, the AudioDevice is initialized, which is put on top of the globals stack.
When the stack is resolved, the AudioDevice gets destroyed before the music, causing the assertion failure.

https://github.com/SFML/SFML/commit/8277fe17101c8608918b1a2757f828bca292b18e
I was able to fix my problem by putting these new tests at the top of the TEST_CASE so they're ran before any other music objects are initialized.


Unstyle empty list item on Enter key

Summary
This appears to be standard functionality in text editors. If the list item has no text and the user pressed Enter, rather than creating a new list item, the current one should simply be removed. This is how it works in Google Docs, TextEdit, etc.
Test Plan

Open the Rich Text editor example.
Create a list item. Don't add any text to it.
Press enter

The list item should be removed.

@ericbiewener This change would be very useful. Any chance you can sign the CLA and we can get someone from Facebook to merge this?

@rylev I signed it a while ago. See the labels on the PR :)

@ericbiewener sorry about that :-D Ok I guess we just need to sit back and wait for someone from Facebook to review this.

Very nice!
As with https://github.com/facebook/draft-js/pull/762 I'd like to get a test for this, but that could be done as a follow-up. I can open an issue for the missing tests.
I'll see if we can get this merged. Great PRs! :D

@niveditc all set. Updated tests as well.

It seems that package.json still shows up in this stack & didn't get deleted on d12d823

@niveditc Sorry, good to go for real this time :)

Next steps are:

I'll import this and run FB's test stack.
Do a few sanity checks in the browser.
Provided the steps above are successful I'll merge it in.


Upgrade HashiCorp's TFE + AWS module for tf 0.12 compatibility

Applies https://github.com/hashicorp/terraform-aws-terraform-enterprise/pull/39
The existing module will fail with the following error:
Error: Unsupported block type

  on .terraform/modules/app/hashicorp-terraform-aws-terraform-enterprise-86d56f2/config.tf line 48, in data "template_file" "cloud_config":
  48:   vars {

Blocks of type "vars" are not expected here. Did you mean to define argument
"vars"? If so, use the equals sign to assign it a value.

In other words, tf 0.12 no longer supports passing vars {} via blocks and requires a map assignment (vars = {}). If this PR lands upstream I can probably reset our master branch to upstream.

@ryanwholey This is just an upstream PR. Adding you for review so someone else is aware we have a (temporary) fork here.


Sets the header row height

How to set the header height？SetHeight (), which I found in the documentation, can only be set to cells

There is not such method, but is possible to do that. Please, find the code:


⚠ Bofrost.at has degraded performance

In 96067d2, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2010 ms

Resolved: Bofrost.at performance has improved in 41e8cf5.


About the new connection failure of SensorFusionNanoDegree project

Hello, I am very interested in your method of Lidar, radar and camera fusion, and I want to learn your method.However, the latest gitlab link you provided has expired, can you provide the latest gitlab link or your gitlab personal homepage?Thank you very much！

Hi
here is the link
https://github.com/ptiwari0664/SensorFusionNanoDegree
Please check and LMK, if it works or not .
Regards,
Puneet Tiwari
ECN
On Mon, 7 Dec 2020 at 13:00, wang6342<EMAIL_ADDRESS>wrote:

Hello, I am very interested in your method of Lidar, radar and camera
fusion, and I want to learn your method.However, the latest gitlab link you
provided has expired, can you provide the latest gitlab link or your gitlab
personal homepage?Thank you very much！
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ptiwari0664/SensorFusionNanoDegree/issues/1, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AE23KGFYYCIMTDWSMS3UUGTSTR77RANCNFSM4UQBK3IQ
.

Hi
here is the link
https://github.com/ptiwari0664/SensorFusionNanoDegree
Please check and LMK, if it works or not .

Dear Mr.Puneet
Due to the time difference between the two places, I will reply to your message so late.Thank you very much for the project information, and best wishes to you.
Regards,
Wang Kai
------------------ 原始邮件 ------------------
发件人:                                                                                "ptiwari0664/SensorFusionNanoDegree"<EMAIL_ADDRESS>发送时间: 2020年12月9日(星期三) 凌晨2:23
收件人<EMAIL_ADDRESS>抄送: "592313576"<wangyong6342<EMAIL_ADDRESS>主题: Re: [ptiwari0664/SensorFusionNanoDegree] About the new connection failure of SensorFusionNanoDegree project (#1)
Hi
here is the link
https://github.com/ptiwari0664/SensorFusionNanoDegree
Please check and LMK, if it works or not .
Regards,
Puneet Tiwari
ECN
On Mon, 7 Dec 2020 at 13:00, wang6342<EMAIL_ADDRESS>wrote:
> Hello, I am very interested in your method of Lidar, radar and camera
> fusion, and I want to learn your method.However, the latest gitlab link you
> provided has expired, can you provide the latest gitlab link or your gitlab
> personal homepage?Thank you very much！
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/ptiwari0664/SensorFusionNanoDegree/issues/1>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AE23KGFYYCIMTDWSMS3UUGTSTR77RANCNFSM4UQBK3IQ>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Appveyor config

Added configuration file for Appveyor and imported the badge into readme and documentation

Codecov Report

Merging #11 into dev will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##            dev    #11   +/-   ##
===================================
  Coverage   100%   100%
===================================
  Files         1      1
  Lines       161    161
===================================
  Hits        161    161

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa4b08f...486b0b3. Read the comment docs.


Define Checkstyle and PMD rules

Above changes will not break in github workflow. But we add following commands in workflow, this will fail workflow, we might to have correct error first.

mvn checkstyle:check
Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (default-cli) on project api: You have 2838 Checkstyle violations
mvn spotbugs:check
Failed to execute goal com.github.spotbugs:spotbugs-maven-plugin:4.3.0:check (default-cli) on project api: failed with 81 bugs and 0 errors

Ah I see - so we need to define the project stds for checkstyle and PMD! :-)
Originally posted by @karianna in https://github.com/microsoft/gctoolkit/issues/33#issuecomment-897158855

Ii think the core committers should have the initial say here - but worth defining!

We should probably center on Google's style since it is IDE neutral, is actively maintained, and there are reformatting tools available.

completed


Fix: Only re-enable intents that were enabled before

Currently the app is doing this:

koan:Quiet - I disable all intents except koan:Talk.
koan:Talk - I re-enable all intents that are enabled by default and I disable the other ones.

However, at any time other apps could have enabled intents that are disabled by default and/or disabled intents that are enabled by default. So to play nice with other apps, I really should do the following:

koan:Quiet - Store the currently enabled intents in a list, and disable all these intents except koan:Talk.
koan:Talk - Re-enable all intents that were enabled before receiving koan:Quiet. The ones that were disabled before are not in our list, so they stay disabled.

According to https://github.com/snipsco/hermes-protocol/issues/78, Snips will probably add a way to get the currently enabled intents, but as it's MQTT based, it will be an asynchronous API.
When the proposed MQTT topic hermes/dialogueManager/configuration (and, I suppose, an equivalent Hermes Python callback) and the new behaviour of the hermes/dialogueManager/configure topic is added to the Snips platform, I could use the following approach in my app:

Subscribe to hermes/dialogueManager/configuration and store the list of enabled intents every time this topic is published. This means every time the dialogue configuration is changed or requested. However, it would be helpful if hermes/dialogueManager/configuration would make it clear it's published because of a change or a request, because we only have to store the list in the former situation.
Make a copy of this list in koan:Quiet
Use this list in koan:Talk to only enable the intents that are enabled in this list.

Closing this because development of this app has stopped.