It is possible to update parent modal window after closing child opened by push method?

Description
Hello! I cant update parent modal window after closing child opened by push method.
Steps to reproduce:

subscribe to close event ( view_closed )
use await this.client.views.push({...}) to open child modal window
press cancel button
I tried update with ack("response_action": "update",.....), client.views.update () but it does not work

What type of issue is this? (place an x in one of the [ ])

[ ] bug
[ ] enhancement (feature request)
[x] question
[ ] documentation related
[ ] example code related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report
Filling out the following details about bugs will help us solve your issue sooner.
Reproducible in:
package version:
node version:
OS version(s):
Steps to reproduce:

subscribe to close event ( view_closed )
use await this.client.views.push({...}) to open child modal window
press cancel button

Expected result:
What you expected to happen
Actual result:
What actually happened
Attachments:
Logs, screenshots, screencast, sample project, funny gif, etc.

Sorry, I used the client.views.update() method incorrectly. Used a hash from a closed window


Update codecov action

Description
Update to use latest codecov action step.
Status
Ready
Types of changes

[x] Non-breaking change (fix or new feature that would not break existing functionality).
[ ] Breaking change (fix or new feature that would cause existing functionality to change).
[ ] New tests added to cover the changes.
[ ] All tests passed locally by running ./src/run-tests-in-docker.sh.
[ ] Documentation comments included/updated.
[ ] User guide updated.
[ ] NGC publishing metadata updated.
[ ] I have updated the changelog

Codecov Report

Merging #89 (5a503c2) into main (cc46cf0) will decrease coverage by 0.03623%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##                main         #89         +/-   ##
===================================================
- Coverage   85.99580%   85.95957%   -0.03624%
===================================================
  Files            153         153
  Lines          13803       13803
  Branches         769         769
===================================================
- Hits           11870       11865          -5
- Misses          1653        1656          +3
- Partials         280         282          +2

Flag
Coverage Δ

unittests
85.95957% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/Server/Services/Jobs/JobSubmissionService.cs
93.47826% <0.00000%> (-2.71739%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc46cf0...5a503c2. Read the comment docs.


Fix TLSv1.3 compatibility by not adding TLS_FALLBACK_SCSV

TLS_FALLBACK_SCSV MUST NOT be set on first connect, see
https://github.com/yeriomin/YalpStore/issues/447#issuecomment-390105926
and RFC 7507 (https://tools.ietf.org/html/rfc7507)
Without this patch every android device not supporting TLSv1.3 trying to connect to an TLSv1.3 enabled server will fail!
Some more insights<EMAIL_ADDRESS>

@GuardianProject Why/how'd this tiny change cause the Travis build to fail⁉

@TPS It didn't. The emulator failed to start.

The command "echo no | android create avd --force -n test -t android-$FIRST_EMULATOR_API_LEVEL" exited with 1.

Maybe it is a travis build misconfiguration?

Thanks for digging into this!  Any idea how this will affect support for TLS 1.2, 1.1 and 1.0.  If I remember correctly, TLS_FALLBACK_SCSV  is some kind of fallback protection used in those TLS versions.
About the travis build, it needs to be modernized to use sdkmanager instead of android update.

I just read up a bit on TLS_FALLBACK_SCSV, it is required to prevent downgrade attacks in TLS 1.2, and 1.1.  The simple way to add TLS 1.3 support here would be to make a configuration method that only supports TLS 1.3, or TLS 1.3 and 1.2.  The ideal solution would be to find something that makes TLS 1.3 work while keeping TLS_FALLBACK_SCSV enabled.

Do you know of any TLS 1.3 servers that can be added to the tests?  Ideally there would be TLS 1.3 enabled, and TLS 1.3-only.

@eighthave The referenced issue is happening while trying to access https://android.clients.google.com. It supports TLSv1.0 and up.

@eighthave No, no, no!
TLS version negotiation works perfectly safe. TLS_FALLBACK_SCSV is only needed if the application is using some sort of this program flow (you can add TLSv1.3 on top of this list if you want):

connect to server enabling TLSv1.0 - TLSv1.2
if the connection fails, try connecting enabling ONLY TLSv1.0 - TLSv1.1
if this also fails, try connecting enabling ONLY TLSv1.0
(4. if this still fails, try reconnecting with SSLv3)

Because the TLS protocol/the TLS server at step 2 can not know that a connection once was tried using a higher protocol version in step 1, you have to set TLS_FALLBACK_SCSV in step 2 (and later in step 3 and step 4, too), so that the server knows that you once tried to connect with a higher protocol version (in step 1) but now disabled this version due to connection errors. If the server supports a higher version of the TLS standard than enabled now in step 2 (or step 3) it now lets the handshake fail.
If a MITM injected those connection/handshake errors this prevents a downgrade attack that would have been possible without TLS_FALLBACK_SCSV.
BUT:
Typically ONLY browsers do this sort of thing and no app developer using NetCipher will ever do this, because NetCipher controls the TLS settings, and allowing TLSv1.0 - TLSv1.2 (or even TLSv1.0 - TLSv1.3) will just use the secure TLS protocol negotiation build into the protocol which is NOT vulnerable to downgrade attacks.
See those two explanations if you want to read more about this:
<EMAIL_ADDRESS>https://crypto.stackexchange.com/a/10495

right, so according to your openssl-users link:

Do NOT set TLS_FALLBACK_SCSV, except for fallback connections that
downgrade the protocol version.

So my reading of that says TLS_FALLBACK_SCSV does need to be set, just not on the first attempt at negotiating a TLS version.

@eighthave Yes, but ONLY if you try to connect again after an handshake failure has happened and your second try does disable the highest protocol version you had enabled in your first connection attempt).
If you use NetCipher it NEVER will disable the highest protocol version, even on subsequent connection attempts --> you NEVER have to set TLS_FALLBACK_SCSV in this context here.
But in other contexts like modern browsers you need TLS_FALLBACK_SCSV.
And that is because those browsers enable different TLS versions in every connection attempt.

could you write a test for that?  I'm skeptical since NetCipher isn't setting TLS_FALLBACK_SCSV at all, and this patch is unsetting TLS_FALLBACK_SCSV.

I guess there is a difference here between "available" and "enabled".  NetCipher is just taking the list of available, and adding them to the list of enabled.

@eighthave yes exactly. see this list: https://developer.android.com/reference/javax/net/ssl/SSLSocket
TLS_FALLBACK_SCSV is on the supported list (you called it "available") but not on the enabled list.
Thus it gets spuriously  activated by just enabling all supported ciphers.

by the way: using NetCipher on a pre 16 phone (android 4.0.3 or lower) will NEVER allow you to connect to TLSv1.2 or TLSv1.1 enabled servers.
That's the same bug we are discussing here ;)

thanks for all this.  This discussion highlights exactly why I think a library like NetCipher is so important: there are so many tiny little technical details like TLS_FALLBACK_SCSV and it is easy to get one wrong, which then blows up and makes the whole TLS verification fail.  Or should I say goto fail  ;-)  The only way to do this safely is to have many people's eyes on common, shared code.

My last question is: how can we set up automated tests of this? But now that I think about this:

using NetCipher on a pre 16 phone (android 4.0.3 or lower) will NEVER allow you to connect to TLSv1.2 or TLSv1.1 enabled servers.

That turns out not to be true.  F-Droid has included NetCipher v2.0.0-alpha1 for a long time.  It also supported down to android-10 until v1.3-alpha0.  F-Droid v1.2 works fine on android-10 when connecting to f-droid.org, which does have TLSv1.2 and TLS1.1 enabled: https://www.ssllabs.com/ssltest/analyze.html?d=f-droid.org

@eighthave Oh, you are right. TLS_FALLBACK_SCSV is only supported on devices having android 21+, those old devices simply don't know this pseudo cipher, so it doesn't get enabled there.
But if it was known back then, my claim would have been right :D
About automatic testing: Use a recent openssl binary to set up a server enabling all protocols and try connecting to it from the emulator.
A second test would be to enable just a subset of protocols and test if NetCipher is available to connect, too. This woul account for future pitfalls.
Use openssl s_server -help to get a list of available options.
Especially those:
 -www                       Respond to a 'GET /' with a status page
 -cert infile               Certificate file to use; default is server.pem
 -key infile                Private Key if not in -cert; default is server.pem
 -cert_chain infile         certificate chain file in PEM format
 -named_curve val           Elliptic curve used for ECDHE (server-side only)
 -cipher val                Specify cipher list to be used
 -x509_strict               disable certificate compatibility work-arounds

And those to control what is tested (multiple tests with different set of options of this list):
 -no_ssl3                   Just disable SSLv3
 -no_tls1                   Just disable TLSv1
 -no_tls1_1                 Just disable TLSv1.1
 -no_tls1_2                 Just disable TLSv1.2
 -tls1                      Just talk TLSv1
 -tls1_1                    Just talk TLSv1.1
 -tls1_2                    just talk TLSv1.2

The idea of a local webserver for testing is appealing, but that would
require setting up a CA-signing cert, then installing it so that the
test webserver can use a certificate that will properly validate.  That
is even harder to do when running in the emulator.  I suppose this would
be possible using robolectric tests on the local JVM, but that then
doesn't test the details of the Android TLS stack, so would probably be
kind of useless.

Well, you have multiple options to solve this:

First, you could do something like this: https://www.ibm.com/blogs/sweeden/using-custom-certificates-and-hosts-file-with-android-emulator/
Your second option ist to disable certificate checks if NetCipher is run from the emulator.
And the third option is to use a certificate for a real host name (like test.guardianproject.info) obtained for free via letsencrypt and just change the hosts file in the emulator to point test.guardianproject.info to a local server using this certificate. (see the link in step 2 for pointers on how to change the hosts file inside the emulator after boot)
You could basically follow step 3 but don't change the hosts file inside the emulator and instead change the hosts file outside. With a proper setup (local dnsmasq instance) your android emulator will use the local resolver for resolving hostnames, which will resolve to the local webserver ip, as if the ip was added to the hosts file inside the emulator.

This seems really important, could someone merge it and tag a new version please?

Someone needs to test it, as described above, before this can be merged.
Changing TLS stacks without testing pretty much guarantees that you'll
introduce vulnerabilities.  Even better, write automated tests.

also, some citations of the Android code that implements this stuff
would be quite useful.  The RFC says how it should behave, but it does
not say how the Android stack sets it up and behaves.

Maybe this commit will convince you (it is out in the wild and thus "tested"): https://github.com/siacs/Conversations/commit/fd7a5c605aa14852398c514288ab5d1971573a47
It is very very unlikely this change will introduce any bug or security holes.
But well, my system is patched and works as intended, I'm out.

@yeriomin I can't find a version android.client.google.com that supports TLS 1.3, my guess is that it is only sometimes enabled:
https://www.ssllabs.com/ssltest/analyze.html?d=android.clients.google.com&s=<IP_ADDRESS>&latest

Ok, finally found one:

https://dev.ssllabs.com/ssltest/analyze.html?d=enabled.tls13.com&s=2400%3Acb00%3A2048%3A1%3A0%3A0%3A6810%3A7e22&latest
https://dev.ssllabs.com/ssltest/analyze.html?d=www.allizom.org&s=<IP_ADDRESS>&latest

@tmolitor-stud-tu looking at your commit again makes me this that the first part is wrong:
                 ArrayList<String> enabled = new ArrayList<String>(10);
-                Pattern exclude = Pattern.compile(".*(EXPORT|NULL).*");
+                Pattern exclude = Pattern.compile(".*(EXPORT|NULL|TLS_FALLBACK_SCSV).*");
                 for (String cipher : delegate.getEnabledCipherSuites()) {
                     if (!exclude.matcher(cipher).matches()) {
                         enabled.add(cipher);
                     }
                 }
                 super.setEnabledCipherSuites(enabled.toArray(new String[enabled.size()]));

If the core system enables TLS_FALLBACK_SCSV, then NetCipher shouldn't remove it.  That's what your change does.  That bit of code gets the list of enabled ciphers from the system, then filters out ciphers that should never be included.

I would accept this now with only the second change:
             ArrayList<String> enabledCiphers = new ArrayList<String>(10);
-            Pattern exclude = Pattern.compile(".*(_DES|DH_|DSS|EXPORT|MD5|NULL|RC4).*");
+            Pattern exclude = Pattern.compile(".*(_DES|DH_|DSS|EXPORT|MD5|NULL|RC4|TLS_FALLBACK_SCSV).*");
             for (String cipher : delegate.getSupportedCipherSuites()) {
                 if (!exclude.matcher(cipher).matches()) {
                     enabledCiphers.add(cipher);
                 }
             }
             super.setEnabledCipherSuites(enabledCiphers.toArray(new String[enabledCiphers.size()]));

[...] then filters out ciphers that should never be included.

Yes, TLS_FALLBACK_SCSV should NEVER be included.
That's exactly what I was arguing from the beginning.
That said, the core system will never add TLS_FALLBACK_SCSV to the enabled list for exactly this reason.
If so, this would be a real bug in the android core system.
NetCipher could fix this specific core system bug by always removing TLS_FALLBACK_SCSV but I doubt the core system will ever be broken that way.
--> Removing it or not removing it from the enabled list should make no difference at all.
Happy merging :)

@eighthave: I have TLS 1.3 enable in Firefox and simply visiting https://www.google.com/ I can see that is connected with TLS 1.3

@ale5000-git That's most likely not the final version of the spec, but draft 18 or 22 or somesuch.
ssllabs only shows servers supporting the final spec (and different draft versions aren't compatible with each other).

@tmolitor-stud-tu if the core OS will never add TLS_FALLBACK_SCSV to the Enabled Cipher List, then there should never be code that tries to remove it.  NetCipher shouldn't second guess the OS here for the Enabled Cipher List, and security sensitive code should never add code that does not have a tested and deliberate purpose.

@ale5000-git in order to have reliable tests, they need to use domains that always have TLS v1.3 enabled.  Most Google domains point to many different IPs that have different configs. They do that for A/B testing, staged rollouts, etc.

If you query the IP address <IP_ADDRESS> with Host header www.google.com it should always work I think.

@eighthave
This test server use TLS 1.3 (draft 28): https://tls13.pinterjann.is/ (listed in https://github.com/tlswg/tls13-spec/wiki/Implementations)
Firefox 61 properly support the latest TLS 1.3 draft and it is enabled by default.

I've tested this with F-Droid, and it solves the issue there (https://gitlab.com/fdroid/fdroidclient/issues/1040).
Can we have this merged and a new netcipher release including this?

Any chance we can get a new release with this? The latest release is an alpha version from 2016 :/

already posted to jcenter: 2.0.0-beta1

@eighthave: Is it possible to tag here on GitHub?

yup, sorry, I forgot to push the tags.


Fix Github Actions tests. Added testing 1.7.6.x and 1.7.7.x versions

Codecov Report

Merging #202 (6d94963) into master (eb5c69e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #202   +/-   ##
=========================================
  Coverage     30.30%   30.30%
  Complexity     2644     2644
=========================================
  Files           114      114
  Lines          8189     8189
=========================================
  Hits           2482     2482
  Misses         5707     5707

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Adding multi-GPU support for Nvidia monitoring

This MR adds the ability to monitor multiple Nvidia GPUs through nvidia-smi calls. It also adds some refactoring for the NvidiaMonitor. In detail, the changes include

Exposing the cmake variable GPU_MONITOR_NVIDIA as a C++ macro to automatically enable GPU monitoring in the example sample/main.cpp.
Simplifying the lib/igpumonitor.h abstract base class to the two basic functions getUsage and getMemory.
The NvidiaMonitor was changed the most by

removing the threading via watchGPU to read in the nvidia-smi calls and changing them to simpler popen(...) calls with no need for forked processes.
The containers to hold GPU usage, used, and total memory were changed to std::vectors to house monitored information for multiple GPUs. During construction of the NvidiaMonitor object, the number of available GPUs in the system is collected from nvidia-smi and the vectors are initialized.
The function void update_gpu_data(const std::vector<uprofile::NvidiaMonitor::Data>& data) was added to update the usage and/or memory vectors, depending on the passed data argument.

The watching checks for UProfileImpl::dumpGpuUsage() and UProfileImpl::dumpGpuMemory() functions were removed since they are no longer needed
The show-graph tool was updated to plot multiple GPU usage and memory.

Thanks @herrnils for the suggested changes and the detailed PR.
I will try to review the PR by the end of the day.

@herrnils FYI, as I did not get any feedback regarding my review, I opened another PR (#12) based on your work and I just merged it.
I therefore close your PR.
Anyway, thanks for your submission.


"Show accent colors on titile bars and window borders" in Personalization option Windows 11 disables backdrop effect

Steps to reproduce the behavior:

Go to 'Personalization' in settings Windows 11.
Enable 'Show accent colors on titile bars and window borders'
Backdrop effect dissappears.

It's need to apply effect on title bars with accent color.
Windows 11 Build 22621.1413

It's not a bug in a MFE, it's how Windows works.

This could be fixed by this PR: https://github.com/MicaForEveryone/MicaForEveryone/pull/259
Setting the caption colour to "None" will allow the backdrop to remain visible in the title bar.

This could be fixed by this PR

Unfortunately, this PR doesn't introduce "None" option for the backdrop, it only introduces option to set solid color for the titlebar.

I ended up using this  Autohotkey script, which adds border to active window — I modified it to use system accent color.
This way I could disable titlebar coloring in Windows settings to use Mica effects in titlebar, and preserve active window's border.


Update sbt-mdoc to 2.2.19

Updates org.scalameta:sbt-mdoc from 2.0.3 to 2.2.19.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "sbt-mdoc" } ]

labels: sbt-plugin-update, semver-minor

Superseded by #72.


Saving an empty (no elements) document yields an empty file and no error

This code:
XMLDocument doc;
doc.SaveFile( "some/valid/path.xml" );

yields an empty file on disk and XMLDocument::Error() being false. Is that expected?

Good question. Well, 3 questions:

Should we save or not save?
Is saving something empty an error?
Should we write the xml encoding declaration?

Actually my initial reaction is that the code should 1) save, 2) no error, and 3) yes, and the file produced is:
<?xml version="1.0" encoding="UTF-8"?>

But that would mean that a new document would be created with the encoding declaration. Which may be correct and would be replaced on load (to whatever is in the loaded file.) I'm a little concerned about breaking existing uses - specifically people who are adding the declaration by hand. So that's one meta question: should we insert that by default?
You question though is: what should we do now? I'd argue that the existing behavior is correct. The user created an empty XML file, saved it, and it resulted in an empty file. TinyXML-2 is being less helpful than it should, but I'm hesitant to introduce (more) behavior that conflicts with a future fix (if we create the encoding declaration.)
Thoughts? This is an edge case, but raises tricky issues about default behavior.

The empty cannot be loaded afterwards - that's why there's "empty.xml" in the testset. So the current implementation is happy to save an empty document but then will not load the result of such saving.

Spent some time looking at this. I acknowledge the bug; however, there are already test cases enforcing the asymmetric behavior. The only real answer I see is "injecting" the declaration and that's going to cause all sorts of trouble.


Add TZ option

Checks

[X] I have checked for existing issues.
[X] This report is about the User-Community Airflow Helm Chart.

Motivation
Hello,
I would like to have the option to choose my default TZ for airflow scheduler.
On the chart it's fixed to etc/UTC : https://github.com/airflow-helm/charts/blob/main/charts/airflow/templates/config/secret-config-envs.yaml#L15
Do you think it's a good idea to variabilize this option? Or to just remove it from this secret so we could configure it using the "config" section.
Thanks for your help here.
BR,
Implementation
If we could remove line 15 : https://github.com/airflow-helm/charts/blob/main/charts/airflow/templates/config/secret-config-envs.yaml#L15
Or add vars here.
Are you willing & able to help?

[X] I am able to submit a PR!
[X] I can help test the feature!

I highly recommend using UTC as your timezone, this is in line with Airflow's official recommendations.
Note, this will not stop you creating DAG schedules in any timezone you like:

https://airflow.apache.org/docs/apache-airflow/stable/authoring-and-scheduling/timezone.html#time-zone-aware-dags


User geometry: Shared user data in ray sequence

Hi,
conceptually, after each intersection a new ray is spawned (e.g. in the pathtracer or when rendering transparent geometry in the scivis renderer). Browsing through the code, it looks like ray instances are partially reused, but its members are reset.
For my user geometry code I am wondering if it's currently possible to have a shared user data for a complete sequence of rays? E.g. the first ray sets a value and the child ray can access/modify that value, and so on.
This could also be thought of as one user data object per framebuffer sample, where each ray contributing to that sample has access to the same data.
I'm not quite sure if this could be solved only within my user geometry code, or if this would require additional modifications to the renderers.
Thanks!
Tim

duplicate of #182


Jackknife performance

I did some benchmarking for the current jackknife implementation. Compared to my implementation it is orders of magnitude slower. For example, with N = 215 Float64 values Jackknife.jackknife takes about 1.8s, while my implementation takes about 0.026s.
The majority of the time is spent on circshift in leaveoneout. My implementation assumes that the supplied function g always acts on means and circumvents the temporary arrays/views that way. I assume this is the main difference.
Is there a reason to have mean as part of the supplied function? Or a case where g cannot be expressed with mean(x),  mean(x²), etc?
My implementation, for reference:
function my_jackknife(f::Function, args...)
    N = length(args[1])
    # sum each argument
    full_arg_sums = map(sum, args)
    # leave-out-one-means for each argument
    reduced_arg_means = map(args, full_arg_sums) do arg_values, arg_sum
        [(arg_sum - arg_values[i]) / (N-1) for i in 1:N]
    end
    # full means for each argument
    full_arg_means = map(x -> x / N, full_arg_sums)
    # result from full mean
    full_result = map(f, full_arg_means...)
    # results from leave-out-one-means
    reduced_results = map(f, reduced_arg_means...)

    # result and error
    full_result, sqrt((N-1) / N * sum((reduced_results .- full_result).^2))
end

Say I want to calculate the jackknife error of O = <x^2> / <x>^2.
A MWE with the current jackknife would look like this:
julia> x = rand(100);

julia> g(x) = mean(x.^2) / mean(x)^2
g (generic function with 1 method)

julia> jackknife(g, x)
0.05473074098696873

Ok, I guess it's
julia> f(x, x2) = x2 / x^2
f (generic function with 1 method)

julia> my_jackknife(f, x, x.^2)
(1.3267326732673268, 0.047429384932671174)

The function g, provided to the jackknife, must always produce a scalar. Hence it will always be a function of means. So I think your approach is fine.
From a users point of view, I sort of liked it that one has jackknife(myfunction, mydata) instead of jackknife(myfunction, mypuredata, mydatasquared, mydatainsomeotherform ...) depending on myfunction. However, I guess it's not that big of a deal and it matters a lot for performance.

Since I've checked the scaling anyway:

N values
jackknife_full
my_jackknife

100
62µs
8.5µs

1000
2900µs
23µs

10 000
310 000µs
160µs

measured with
g(x) = mean(x.^2) / mean(x)^2
f(x, x2) = x2 / x^2
sample = 1:100 |> collect
@btime Jackknife.jackknife_full($g, $sample)
@btime my_jackknife($f, $sample, $(sample).^2)

each time.

From a users point of view, I sort of liked it that one has jackknife(myfunction, mydata) instead of jackknife(myfunction, mypuredata, mydatasquared, mydatainsomeotherform ...) depending on myfunction. However, I guess it's not that big of a deal and it matters a lot for performance.

Yea, I see where you're coming from. Maybe we can play around with macros in the future to build something more pleasing. For example, @jackknife(f, x) generating second (third, ...) moments if f has two (three, ...) arguments. Though that might create more problems than it solves.

@ffreyer Want to prepare a PR that switches to your version?

I can start working on it tomorrow.  I believe I have a slightly more optimized version, but I can't check right now.

It would be nice to have a benchmark suite that indicates potential performance regressions systematically. https://github.com/JuliaCI/PkgBenchmark.jl provides the necessary tools but I've never used it before.

I haven't used it before either.


Move verifiers and shape functions to a separate file

Request description
There exist several shape functions in StablehloOps.cpp which need to be moved to StablehloTypeInference.cpp so that they can can be shared with MHLO. The expected timeline for this is end of Oct.

Work on this has started in https://github.com/openxla/stablehlo/pull/269.

https://github.com/openxla/stablehlo/pull/269 is merged to main.
As bounded dynamism work is prioritized, the related ops will be moved accordingly as next batch.

https://github.com/openxla/stablehlo/pull/269 is merged.
More ops will be moved later: the next batch is the ops which need bounded dynamism.

This is now actively in progress and expected delivery date is EOY 2022.

CollectivePermuteOp is another candidate for this refactoring. For example,
verifyCollectivePermuteSourceTargetPairs should be moved to TypeInference.cpp  to be leveraged by both StableHLO and MHLO. Here is the sharing opportunity in MHLO.

I am curious to know how are we going to decide on the amount of work (number of ops which might need the refactoring) needed here?
We cannot rely on the status.md's "Type inference column" as the spec-wprkstream  does not include this refactoring aspect while resolving items in the column to a yes.
@zhouxin913

Just a thought: In order to avoid creating a checklist of all the ops, that we need to revisit for refactoring, we can take this up as an action item while doing the interpreter, which in any way needs revisit on an op-by op basis (The exact details are TBD).

#783 only fixed this partially, reopening for now.


Added SendMessagesInThreads and StartEmbeddedActivities.

Adjusted owner perms.
Change UsePublicThreads -> CreatePublicThreads
Change UsePrivateThreads -> CreatePrivateThreads

removed extra ///


opentelemetry export format

Add the ability to parse opentelemetry data.

[ ] can parse logs
[ ] can parse other events types, and do nothing with them for now

Later we will ingest the non-log stuff, but for starts we focus ok just the logs.

Hi @aybabtme,
I want to implement the consumer of the OpenTelemetry exported data which is defined as OTLP here. Before starting to implement it, I want to clarify some details.
The examples in (00005-otel) look unfamiliar with the examples. I guess these are recognized as fmtlogs and humanlog processes them as fmt logs. Are they on purpose or just random logs?
Is the OTLP logs enough for the initial step? As I remember, and the examples are showing that, they are basically json formatted logs with special standardized fields that can be handled with the correct configuration with JSON parser.

@ferh6t i havent been following OTEL much in recent years since they were changing theirs spec quite frequently and i found it annoying.
I'll guess the example logs i have are from a otel logger that is not non-conformant?
My goal is to support out of the box most formats out there, conformant or not. So we should suppoort 00005-otel and also the new formats :)
However, I would like for special knowledge about OTEL components to be detected and extracted where possible. In particular, if they encode special meanings in special places, like log-levels, request/trace IDs, span IDs, etc. The logevent type is fairly limited now, but later it may gain more special fields.


Fixed typo in static files docs

Removed the use of double quotes inside double quotes in sample code,
see PEP-8: String Quotes
(https://www.python.org/dev/peps/pep-0008/#id25)
[x] Documentation builds without errors (make html)

This isn't a typo. The code in question is a Django template, not Python code.


Push Publishing for trusted sources

Implement the mediachain/node/publish protocol to allow trusted publishers to push statements to stable nodes.
Requires #12 to implement.

This will be very useful for paired alephs, should be relatively simple to impl via node-local whitelist

This is blocked until we have usable ECC keys in js side for signing statements.

It is actually usable without aleph signing support: we can use it to support public writes to stable nodes.
So a pure concat-concat push is possible.
Re-enstating to v1.2.


icontrol.exceptions.InvalidInstanceNameOrFolder: instance names and partitions cannot contain '/'

This may not be a bug, but perhaps a lack of documentation.  When trying to access Pool information when the pool is within an iApp, I get the above error.  When using a direct REST call, it parses as ~Common~SOMEAPP.app~SOMEPOOL?ver=<IP_ADDRESS>
Given the /Common/SOME.app/SOMEPOOL is what is being returned by mgmt.tm.ltm.virtuals.pool I would expect to be able to use the / in the path for iApp pools, stats, etc.

Try adding the kwarg transform_name: True

WONDERFUL.  after some trial and error (I'm new to python), I was able to do the call like such:  pool = mgmt.tm.ltm.pools.pool.load(transform_name=True, partition=lpool[1], name=lpool[2]+'/'+lpool[3])
I theorize I could change that to .load({transform_name: True, partition=lpool[1], name=lpool[2]+'/'+lpool[3]}) just as well.

the former will work, the latter will likely fail. The load method is looking for arguments, not a dictionary of arguments. Welcome to python, it's by far my favorite language to work in.


QRServ

Package name
dev.uint.qrserv
Hash(es)
DF:B4:DA:EE:79:FF:F9:95:B8:F8:75:29:5E:01:CF:E3:B3:9C:11:1E:D9:03:DE:E0:13:A5:A9:CA:AD:2B:BA:65
Source code link (Optional)
https://github.com/uintdev/qrserv

As of now, contributing through issues won't be accepted. Please check the updated https://github.com/soupslurpr/AppVerifier/blob/master/CONTRIBUTING.md for instructions. Thanks.


Add support for custom failure messages in Spec expectations

This PR introduces a breaking change if people happened to be using file and line as positional parameters, which is why I'd like to get this in before 1.0.  The reason I introduced this breaking change is because as a user I'd expect the failure message to come immediately after the expectation (as it is in RSpec), and I believe it will be much more likely for users to use custom error messages than file and line (based on my experience in Ruby with RSpec).
The fix for the file and line change is very straightforward.  In this PR I've fixed the core specs by using keyword notation, since core had both keyword-style and positional-style, and keyword-style seemed cleaner.  I had even considered "forcing" keywords to be used for the file and line parameters, but thought that might warrant some discussion first.
See also the brief discussion in this thread: https://forum.crystal-lang.org/t/spec-assertion-with-custom-message/1781

I would make file and line named arguments, even without this change. With it, even more so.

@straight-shoota I agree (just to clarify, when you say named arguments, you mean the "forcing" of the caller to use keywords, right?)

Probably should split the file,line named arguments thing into a separate PR, not to taint this one as breaking-change.

@oprypin failure_message replaces file as second positional argument, so it's definitely a breaking change. And it can even break silently. Although that shouldn't be too much of a problem because typically both file and line are passed and then the argument types don't match. And it's also "just" spec output, so if it fails and prints a message instead of a file name, that's not a big deal. You can easily fix it.

Can we add the following declarations to get deprecation warnings instead of compile-time errors?
    @[Deprecated("Use named arguments .should expectation, file: file, line: line")]
    def should(expectation, file, line)
      should(expectation, nil, file: file, line: line)
    end

    @[Deprecated("Use named arguments .should_not expectation, file: file, line: line")]
    def should_not(expectation, file, line)
      should_not(expectation, nil, file: file, line: line)
    end

There are some shards that are using file, line for custom error messages and I would rather offer a transition here.

Can we add the following declarations to get deprecation warnings instead of compile-time errors?
    @[Deprecated("Use named arguments .should expectation, file: file, line: line")]
    def should(expectation, file, line)
      should(expectation, nil, file: file, line: line)
    end

    @[Deprecated("Use named arguments .should_not expectation, file: file, line: line")]
    def should_not(expectation, file, line)
      should_not(expectation, nil, file: file, line: line)
    end

There are some shards that are using file, line for custom error messages and I would rather offer a transition here.


WagmiProvider rerender triggering "Cannot update a component while rendering a different component"

Describe the bug
Just upgraded to Wagmi 2. I'm rendering a WagmiProvider in a parent component that ends up rerendering (not remounting) that WagmiProvider in certain situations.
After some debugging, I determined that the code here will trigger a call to reconnect during every render of Hydrate here, which is itself rendered by WagmiProvider here.
In our case, the reconnect call is triggering a component that uses the useWalletClient hook to re-render. This is a no-no in React, as we're setting state during render. We see this error:
Warning: Cannot update a component (SomeComponent) while rendering a different component (Hydrate). To locate the bad setState() call inside Hydrate, follow the stack trace as described in https://reactjs.org/link/setstate-in-render

I'm not sure what the right solution is. I know that there are (limited) cases where calling setState from render is appropriate, such as animation transitions. I'm not sure if this particular use qualifies. My instinct is that it doesn't, but I haven't thought about it too deeply. (I also wonder if this error is supposed to fire even for appropriate uses... perhaps the doc I linked is outdated?)
Apologies for not having a MRE... I have limited cycles right now and was able to work around the issue by explicitly passing in reconnectOnMount={false} lifting WagmiProvider higher in the component tree. Figured it was still better to create an issue, since I suspect that many others are going to be experiencing this soon.
Link to Minimal Reproducible Example
No response
Steps To Reproduce
No response
Wagmi Version
2.5.18
Viem Version
2.9.5
TypeScript Version
No response
Check existing issues

[X] I checked there isn't already an issue for the bug I encountered.

Anything else?
No response

reconnectOnMount turns out to be be only one way that setState can be called by hydrate. Renamed and updated this issue to reflect that.
I was able to get around it by lifting WagmiProvider up higher in the component tree. That said, I still feel that Wagmi should be able to handle WagmiProvider being rerendered. I suspect (but am not sure) that the approach here is non-idiomatic for React, but I don't understand the tradeoffs (or other context) that lead to it being taken.

WagmiProvider should indeed be placed at a level where the first mount occurs to behave properly with hydration.


Last character is missing when copy & pasting

I have this one weird issue: When I copy text from a running tmux session (macOS) with your config files the last character is missing in the clipboard. It is always the last one, regardless of the symbol.
When I run tmux -L test -f /dev/null all characters can be copied flawlessly. I tested several different terminal applications (iTerm 2, Alacritty, macOS Terminal). That's not the reason. The issue only occurs with your configuration.
Is somebody else having this issue? How can I help to solve this problem - because it is bothering endlessly.

@ncreuschling I had the same issue with mouse copy/paste and I  solved it by compiling  tmux without --enable-utf8proc (brew version uses the flag by default)

Thank you for your comment. I will look into this.

Is this relevant to this issue?
https://github.com/tmux/tmux/issues/1579


rbox() returns NaN in IE for x & y properties

I noticed this happening then when I dug into the problem, it is because IE does not implement the window.scrollY and window.scrollX properties which are used as an offset on the x & y properties (see line 1829 of dist file). This is easily resolved by having an || and using the respective properties that IE provides:
// offset by window scroll position, because getBoundingClientRect changes when window is scrolled
this.x += window.scrollX || window.pageXOffset
this.y += window.scrollY || window.pageYOffset

I will happily fix this issue and submit a pull request if it is agreed that this is a reasonable fix.

Yes thank you! Isn't pageYOffset the standard anyway? Maybe we need only
this. May you check this?
Dan Ormisher<EMAIL_ADDRESS>schrieb am Di., 08.12.2015, 14:17:

I noticed this happening then when I dug into the problem, it is because
IE does not implement the window.scrollY and window.scrollX properties
which are used as an offset on the x & y properties (see line 1829 of dist
file). This is easily resolved by having an || and using the respective
properties that IE provides:
// offset by window scroll position, because getBoundingClientRect changes when window is scrolledthis.x += window.scrollX || window.pageXOffsetthis.y += window.scrollY || window.pageYOffset
I will happily fix this issue and submit a pull request if it is agreed
that this is a reasonable fix.
—
Reply to this email directly or view it on GitHub
https://github.com/wout/svg.js/issues/425.

Hey, it looks like pageXOffset is supported across the board and from IE 9+. I believe svgjs only supports IE 9+ so I assume this is fine. I have just done a quick test and compared the values of scrollY and pageOffsetY in the latest Chrome and Firefox and they both return the same value for each property.
I will do this now and submit a pull request.

Yes thank you
Dan Ormisher<EMAIL_ADDRESS>schrieb am Di., 08.12.2015, 14:41:

Hey, it looks like
http://www.w3schools.com/jsref/prop_win_pagexoffset.asp pageXOffset is
supported across the board and from IE 9+. I believe svgjs only supports IE
9+ so I assume this is fine. I have just done a quick test and compared the
values of scrollY and pageOffsetY in the latest Chrome and Firefox and
they both return the same value for each property.
I will do this now and submit a pull request.
—
Reply to this email directly or view it on GitHub
https://github.com/wout/svg.js/issues/425#issuecomment-162882618.

Closed with the PR


Add IE9 support, and cookie-based fallback for non-support of localStorage

This is my first github pull request; my apologies if I'm doing it wrong.

Going to close this one, I'm not too fussed about ie9 now :( Totally my fault for not paying enough attention, sorry!


[FLINK-36168][test] This is a slight improvement of the changes done in the previous FLINK-36168 commit

What is the purpose of the change
The previous fix of FLINK-36168 just move the state to Finished no matter what. We should, instead, call cancel on the scheduler and close the scheduler from there. This ensures that all the states are properly processed.
Brief change log

Adds cancel to the cleanup method of AdaptiveSchedulerTest
Makes the dummy states implement the appropriate state classes

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

The merge commit shouldn't have made it into the git history. But squashing the commits should fix the issue in the end.

@flinkbot run azure


Add language filter on the homepage.

Some languages are more apt for golfing than others and dominate the Top 5 . It would be nice to have a language filter to see the Top 5 for all holes per language.

Given the homepage doesn't show rankings anymore this ticket can be closed.


Merge branch 'zalando:master' into master

Pull in the latest upstream changes.

A: this is marked as a draft, but B: I'm not going to go through and review 3600 lines in zalando's upstream. If this rebase introduces errors that you've missed, we'll fix the bugs as we find them.

It's draft because I was fixing rebase errors last night. I think I got most of them though, but also share the (B) mentality. It compiles, passes lint, and I did check that each deleted rule in the left diff was added in the right, so all rules are in-tact.


Timed out trying to read data from the socket stream!

FTP OS: HP UNIX
FTP Server: wuftpd
Computer OS: Windows 7
Get this error on uploading file when no any file in target folder.
There is no error if target folder has file.
Logs :
target folder is empty and get error

# Connect()
Status:   Connecting to ***:21
Response: 220 FTP server (Revision 9.0 Version wuftpd-2.6.1 Mon Jun 30 09:28:28 GMT 2014) ready.
Command:  USER ***
Response: 331 Password required for xxxx.
Command:  PASS ***
Response: 230 User xxxxlogged in.
Command:  FEAT
Response: 500 'FEAT': command not understood.
Status:   Text encoding: System.Text.ASCIIEncoding
Command:  SYST
Response: 215 UNIX Type: L8
Status:   Auto-detected UNIX listing parser

# UploadFile("xxxxx", "xxxxx", Overwrite, False, None)

# FileExists("xxxxx")

# GetNameListing("xxxxx")
Command:  TYPE I
Response: 200 Type set to I.

# OpenPassiveDataStream(AutoPassive, "NLST xxxxx", 0)
Command:  EPSV
Response: 229 Entering Extended Passive Mode (|||40240|)
Status:   Connecting to ***:40240
Command:  NLST xxxxx
Response: 226 Transfer complete
Status:   Disposing FtpSocketStream...
Status:   Disposing FtpSocketStream...

# CloseDataStream()
Status:   Disposing FtpSocketStream...

# Dispose()
Status:   Disposing FtpClient object...
Status:   Testing connectivity using Socket.Poll()...
Status:   Testing connectivity using Socket.Poll()...
Status:   Testing connectivity using Socket.Poll()...
Command:  QUIT
Response: 221 Goodbye.
Response: 221-You have transferred 0 bytes in 0 files.
Response: 221-Total traffic for this session was 457 bytes in 0 transfers.
Response: 221-Thank you for using the FTP service on .
Status:   Disposing FtpSocketStream...
Status:   Disposing FtpSocketStream...

Message : "Timed out trying to read data from the socket stream!"
StackTrace : at FluentFTP.FtpSocketStream.Read(Byte[] buffer, Int32 offset, Int32 count)
   at FluentFTP.FtpDataStream.Read(Byte[] buffer, Int32 offset, Int32 count)
   at FluentFTP.FtpSocketStream.ReadLine(Encoding encoding)
   at FluentFTP.FtpClient.GetNameListing(String path)
   at FluentFTP.FtpClient.FileExists(String path)
   at FluentFTP.FtpClient.UploadFileInternal(Stream fileData, String remotePath, Boolean createRemoteDir, FtpExists existsMode, Boolean fileExists, Boolean fileExistsKnown, IProgress`1 progress)

================
target folder has file and without error

# Connect()
Status:   Connecting to ***:21
Response: 220 FTP server (Revision 9.0 Version wuftpd-2.6.1 Mon Jun 30 09:28:28 GMT 2014) ready.
Command:  USER ***
Response: 331 Password required for xxxx.
Command:  PASS ***
Response: 230 User xxxxlogged in.
Command:  FEAT
Response: 500 'FEAT': command not understood.
Status:   Text encoding: System.Text.ASCIIEncoding
Command:  SYST
Response: 215 UNIX Type: L8
Status:   Auto-detected UNIX listing parser

# UploadFile("xxxx", "xxxxx", Overwrite, False, None)

# FileExists("xxxxx")

# GetNameListing("xxxxx")
Command:  TYPE I
Response: 200 Type set to I.

# OpenPassiveDataStream(AutoPassive, "NLST xxxxx", 0)
Command:  EPSV
Response: 229 Entering Extended Passive Mode (|||61436|)
Status:   Connecting to ***:61436
Command:  NLST xxxxx
Response: 150 Opening BINARY mode data connection for file list.
Status:   Disposing FtpSocketStream...

# CloseDataStream()
Response: 226 Transfer complete.
Status:   Disposing FtpSocketStream...

# OpenWrite("xxxxx", Binary)
Command:  TYPE I
Response: 200 Type set to I.

# OpenPassiveDataStream(AutoPassive, "STOR xxxxx", 0)
Command:  EPSV
Response: 229 Entering Extended Passive Mode (|||57719|)
Status:   Connecting to ***:57719
Command:  STOR xxxxx
Response: 150 Opening BINARY mode data connection for xxxxx.
Status:   Disposing FtpSocketStream...
Response: 226 Transfer complete.
Command:  QUIT
Response: 221 Goodbye.
Response: 221-You have transferred 12717 bytes in 1 files.
Response: 221-Total traffic for this session was 13562 bytes in 2 transfers.
Response: 221-Thank you for using the FTP service on .
Status:   Disposing FtpSocketStream...

# Dispose()
Status:   Disposing FtpClient object...
Status:   Disposing FtpSocketStream...

Same as #122 #244. This ghost bug keeps coming back.

I was having this trouble in a machine running Windows Server 2008 r2 and I resolved it by upgrading the Filezilla Server version from 0.9.41 to 0.9.60.
The messages from TimedOut were almost always accompained by a 426 Could Not create Socket, if you have been looking for the root problem maybe you should try upgrading before wasting time in your implementation.

Discussion will continue in #122


Remove HAProxy zipkin check

Signed-off-by: Won Jun Jang<EMAIL_ADDRESS>Fixes https://github.com/jaegertracing/jaeger/issues/553

Coverage remained the same at 100.0% when pulling 34db6a611d2967864f2ba7d568455bb8faad31cb on remove_haproxy_check into e018d3e456822833488cf1b39cd8533dd88d0e5a on master.


dependentSchemas and propertyDependencies don't "define" properties

Coming out of a Slack discussion and #624, we need tests that show that properties listed in dependentSchemas and propertyDependencies don't affect the validation results of additionalProperties or unevaluatedProperties.

@gregsdennis  Can you please check if this test matches the requirements for this issue?
[
    {
        "description": "dependent schema with additionalProperties",
        "schema": {
            "$schema": "https://json-schema.org/draft/2019-09/schema",
            "dependentSchemas": {
                "foo": {}
            },
            "additionalProperties": false
        },
        "tests": [
            {
                "description": "dependentSchemas properties are counted as additional properties",
                "data": {
                    "foo": ""
                },
                "valid": false
            }
        ]
    },
    {
        "description": "dependent schema with unevaluatedProperties",
        "schema": {
            "$schema": "https://json-schema.org/draft/2019-09/schema",
            "dependentSchemas": {
                "foo": {}
            },
            "unevaluatedProperties": false
        },
        "tests": [
            {
                "description": "dependentSchemas properties are counted as unevaluated properties",
                "data": {
                    "foo": ""
                },
                "valid": false
            }
        ]
    }
]

Yeah, those should do.  We'll need similar tests for the new propertyDependencies in draft/next.

I think for propertyDependencies  test will be  same if i am not wrong .
@gregsdennis ?
[{
        "description" : "propertyDependencies with additionalProperties",
        "schema" : {
            "propertyDependencies" : {
                "foo" : {}
            },
            "additionalProperties" : false
        },
        "tests" : [
            {
                "description": "propertyDependencies properties are count as additionalproperties" ,
                "data" : {"foo" : ""},
                "valid" : false
            }
        ]
    },
    {
        "description" : "propertyDependencies with unevaluatedProperties" ,
        "schema" : {
            "propertyDependencies" : {
                "foo" : {}
            },
            "unevaluatedProperties" : false
        },

        "test" : [
            {
                "description": "propertyDependencies properties are count as the unevaluatedItmes" ,
                "data": {"foo": ""},
                "valid": false
            }
        ]
    }]

Is this test also require for dependentSchemas in draft/next or this behaviour is going to be change in next ?

@gregsdennis i think this one need to be close as it done in #732

Yes.


Can you share the code and data files for the two-dimensional Burgers equation?

Dear Professor Jagtap,
I reproduced the code for the two-dimensional Burgers equation from your cPINN article. I set the parameters the same as in your article.  But my loss is not as small as your article. Can you share the code and data for your two-dimensional Burgers equation? Looking forward to your reply.
Best regards,
Xiaojun

Could you also share the code and data for KdV equation?


Adding babel to transpile the source files

@kwadwo hey sorry, I didn't realize you created a PR. Would you mind explaining what you implemented?


pull request for e2e test at 01/24/2017 04:15:11

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat: expose command to install dependencies with recursive support

Description
As a developer, I want to be able to install dependencies for all packages within my current project. The command should ideally automatically determine whether to run flutter packages get or flutter pub get depending on the type of package and should be capable of recursively running the install command for each nested package.
Proposed Usage
# Install dependencies for the current package via `flutter packages get` or `flutter pub get`
very_good packages get

# Install dependencies recursively via `flutter packages get` or `flutter pub get`
very_good packages get --recursive
very_good packages get -r

Additional Context
very_good_cli already contains the functionality as part of https://github.com/VeryGoodOpenSource/very_good_cli/blob/ee37acd2f0ff1651a36f224c926110f3f55fd9b6/lib/src/flutter_cli.dart#L11 and addressing this issue would require exposing that functionality via a new command.

It would be awesome to specify flutter version to be used e.g. by path or fvm

It would be awesome to specify flutter version to be used e.g. by path or fvm

I would expect the command to run using whatever configured flutter version you already have. Can you provide a bit more context regarding the use-case and what the usage would look like? Thanks!

Using fvm I specify the flutter version to be used per directory basis. It may mean that I don't have flutter available globally or it can link to the different version of flutter than globally accessible. This would be the version that I'd like to use when resolving dependencies for a given project.
Some tools (like pubviz or bash scripts using flutter internally) require additional steps to make this happen like overriding flutter for the scope of a program, or temporarily changing flutter to link to the desired version, or sometimes even modifying the script itself. Being able to pass: very_good packages get --fluter ~/fvm/versions/beta/bin/ could be really handy.


Auto-open menu on focus when input is non-empty

What:
This auto-opens the menu when the input with value is focused. Previously, user has to type something (albeit he already had) to open up the menu.

Why:
A number of autocomplete components implement this feature, namely react-select. Google does this as well. I also think that this is a convenient UX.
This is easily doable outside Downshift, but I think it should be part of the core. In addition, we can add a prop that allows users to disable this option.

How:
By adding a new focus event listener.

Checklist:

[ ] Documentation
[ ] Tests
[ ] Ready to be merged
[ ] Added myself to contributors table

Not yet, I'd like to make this as a discussion starter - it's a pretty simple change anyway.
If this sounds good, I'd be happy to push tests.

Will put up GIFs within the hour (haha, never done them with Windows).

Thanks for the contribution! However I'm not going to merge this as it's really easy to do yourself: https://codesandbox.io/s/k2k73rw7lo
(the important part):
{...getInputProps({
  isOpen,
  placeholder: 'Enter a name',
  onFocus: openMenu,
})}

TIL. Looks like I wasn't paying enough attention to the docs. Thanks!


Stack allocator

There should be some common memory allocators that the engine uses to improve performance

Small block
Stack allocator

We should be able to pass this in as a pointer to any component or resource types.

Perhaps a binned allocator?

We can implement this like molecular matters: https://blog.molecular-matters.com/2012/08/27/memory-allocation-strategies-a-stack-like-lifo-allocator/
use cases: Things in the game that are used at runtime and can be rolled back (level loading)


Issues arising with Pangolin v4.0.x

Usher seems to consume an enormous amount of time - switching --analysis-mode to pangolearn helps a lot
beware of the upgrade process, I encountered major issues with faToVcf and ended up having to scrap the entire conda environment and re-install from scratch

Looks like we have to update sklearn to version 1.0.1

This did the trick:
(pangolin) art@orolo:~/git/duotang/data_needed$ pip install scikit-learn=="1.0.1"

RAM consumption is now a known issue:
https://github.com/cov-lineages/pangolin/issues/395


npm install fail due to<EMAIL_ADDRESS>

Hi!
Last angular (beta3) requires<EMAIL_ADDRESS>but this version seems not working correctly
><EMAIL_ADDRESS>postinstall ~/temporary/angular2-tour-of-heroes/node_modules/zone.js
> tsd install

sh: 1: tsd: not found

[...]

npm ERR! node v4.2.3
npm ERR! npm  v2.14.17
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn

npm ERR<EMAIL_ADDRESS>postinstall: `tsd install`
npm ERR! spawn ENOENT

I think this is an issue with the angular beta 3 npm package, you can get around it by installing the zone.js dependency in front of angular:
npm install<EMAIL_ADDRESS>--save-dev
npm install angular2 --save-dev

zone 0.5.11 is in the package. what are you proposing?

I just re-cloned this and ran npm i and it installs with no errors.

I had the same issue.
npm install<EMAIL_ADDRESS>--save-dev
npm install angular2 --save-dev
npm i

worked after trying everything; even upgrading to latest node/npm.

Just in case someone else runs into this issue.. For me, I did not have tsd installed globally.

Got the same problem. Did an npm install tsd. Worked.

@Kinnardian thanks!

@Kinnardian :+1:

@chundemer danke

@Kinnardian thanks mate, worked like a charm :)

Yep, I had to sudo npm install tsd

@Kinnardian, thank you sir, that fixed it for me as well.


Readme code not working

Running the following in Node is giving me an error [..css string..] has no method 'isNull'
var fs = require('fs')
var less = require('less-stream')

fs.createReadStream('test/main.less')
  .pipe(less())
  .pipe(fs.createWriteStream('out.css'));

+1 the first parameter passed to through2.obj, which I believe is a buffer, has no method isNull or isStream


revert previous DefaultRetentionPolicyName change

Required for all non-trivial PRs

[ ] Rebased/mergable
[ ] Tests pass
[ ] CHANGELOG.md updated

👍


[DO NOT MERGE] Add type definitions for flowtype

This change is

In JS community, Flowtype lost to TypeScript. Flowtype would be still a benefit for Facebook scale codebase. But it's not common usecase.
We recommnd to use https://github.com/joarwilk/flowgen


Microsoft.Garnet package: Server Initialization Fails with just --help, missing log message

Describe the bug
only some options seem to boot.  --port for example.  But specifying others fails, in a not-helpful way.
--help, for example, will show you the help options, then crash in the constructor.  It will show:
07::09::39 info: ArgParser[0] Configuration import from embedded resource succeeded. Path: defaults.conf.
Unhandled exception. Garnet.common.GarnetException: Encountered an error when initializing Garnet server. Please see log messages above for more details.
at Garnet.GarnetServer..ctor(String[] commandLineArgs, ILoggerFactory loggerFactory, Boolean cleanupDir, IAuthenticationSettings authenticationSettingsOverride)
at GarnetStart.Program.Main(String[] args) in C:\SEA\SmallProjects\Garnet\GarnetStart\GarnetStart\Program.cs:line 10
at GarnetStart.Program.(String[] args)
We believe this issue, whatever it is, might be what is not allowing us to feed it our garnet.conf file via the option when running as service - but it may not, it's really hard to tell!
Steps to reproduce the bug
Create console .net8.0 project
add Microsoft.Garnett (any recent version, 1.0.39 for example)
change main method:
 static async Task Main(string[] args)
 {
     using var server = new Garnet.GarnetServer(args);
     server.Start();
     await Task.Delay(Timeout.Infinite);
 }

Start project (fine)
Start from command line (fine)
Start from command line with --help option (display help, then crash)
Expected behavior
show help info, then quit gracefully, or keep running.
Screenshots
07::25::05 info: ArgParser[0] Configuration import from embedded resource succeeded. Path: defaults.conf.
Unhandled exception. Garnet.common.GarnetException: Encountered an error when initializing Garnet server. Please see log messages above for more details.
at Garnet.GarnetServer..ctor(String[] commandLineArgs, ILoggerFactory loggerFactory, Boolean cleanupDir, IAuthenticationSettings authenticationSettingsOverride)
at GarnetStart.Program.Main(String[] args) in C:\SEA\SmallProjects\Garnet\GarnetStart\GarnetStart\Program.cs:line 10
at GarnetStart.Program.(String[] args)
Release version
1.0.39
IDE
Visual Studio 2022
command line
Windows service
OS version
Windows 10
Windows server 20xx
Additional context
My end game is to get it up as a BackgroundService-ified version of the service as a windows service a la:

sc config "Famis Web PubSub" binPath="D:\AppsSvc\FamisPubSubService\FamisPubSubService.exe --config-import-path D:\AppsSvc\FamisPubSubService\garnet.conf"

seem to get more or less the same unspecified error in constructor, This does work on command line, so...odd:

FamisPubSubService.exe --config-import-path D:\AppsSvc\FamisPubSubService\garnet.conf

I think I'll be able to solve that, once the issue that prevents construction with just the --help option is sorted, and the missing log message shows up.

Hi @zachrybaker! Any other issues at start up other than running with --help? Are you able to successfully start with your garnet.conf file?

@TalZaccai, prompt work here!
To answer your question, using my garnet.conf file works fine - from command line. But using it when starting as a windows service fails with similar unhelpful error message. But it starts fine as a service when using  --port, so I’m unsure where to go. It does not appear to be permissions for the account running the service.

@zachrybaker Can you elaborate on how you're running your service? Are you using hosting/Windows/Garnet.worker?

I’m using a windows service, using nearly exactly identical code as the example you just referenced, which I had not seen before.

It's possible you also have a Redis service so the port clashes on startup. Since the original issue is fixed, please feel free to open a new one if you run into an issue when the port is not in use. Thank you


feat(plugin-slash): expose trigger key

[x] I read the contributing guide
[x] I agree to follow the code of conduct

Summary
This pull request expose trigger of plugin-slash for show content not only by the '/' key. It's possible to override shouldShow to do this approach, but you'd end up having to rewrite other functions like getContent(), and this change doesn't bring any breaking changes.
How did you test this change?
I implemented the same idea in a project by wrapping this plugin and it worked properly:

Thanks for your contribution.


blvr_hardware package is not building

colcon build --symlink-install
Starting >>> blv_diffbot_description
Starting >>> blv_diffbot_hardware
Finished <<< blv_diffbot_description [11.9s]
Starting >>> blv_diffbot_sim
Finished <<< blv_diffbot_sim [4.12s]
Starting >>> blv_diffbot_bringup
Finished <<< blv_diffbot_bringup [4.48s]
--- stderr: blv_diffbot_hardware
In file included from /home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/src/blv_diffbot_system.cpp:15:
/home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/include/blv_diffbot_hardware/blv_diffbot_system.hpp:44:18: error: ‘CallbackReturn blv_diffbot_hardware::BlvDiffbotSystemHardware::on_init(const hardware_interface::HardwareInfo&)’ marked ‘override’, but does not override
44 |   CallbackReturn on_init(const hardware_interface::HardwareInfo & info) override;
|                  ^~~~~~~
/home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/include/blv_diffbot_hardware/blv_diffbot_system.hpp:53:18: error: ‘CallbackReturn blv_diffbot_hardware::BlvDiffbotSystemHardware::on_activate(const rclcpp_lifecycle::State&)’ marked ‘override’, but does not override
53 |   CallbackReturn on_activate(const rclcpp_lifecycle::State & previous_state) override;
|                  ^~~~~~~~~~~
/home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/include/blv_diffbot_hardware/blv_diffbot_system.hpp:56:18: error: ‘CallbackReturn blv_diffbot_hardware::BlvDiffbotSystemHardware::on_deactivate(const rclcpp_lifecycle::State&)’ marked ‘override’, but does not override
56 |   CallbackReturn on_deactivate(const rclcpp_lifecycle::State & previous_state) override;
|                  ^~~~~~~~~~~~~
/home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/include/blv_diffbot_hardware/blv_diffbot_system.hpp:59:35: error: ‘hardware_interface::return_type blv_diffbot_hardware::BlvDiffbotSystemHardware::read(const rclcpp::Time&, const rclcpp::Duration&)’ marked ‘override’, but does not override
59 |   hardware_interface::return_type read(const rclcpp::Time & time, const rclcpp::Duration & period) override;
|                                   ^~~~
/home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/include/blv_diffbot_hardware/blv_diffbot_system.hpp:62:35: error: ‘hardware_interface::return_type blv_diffbot_hardware::BlvDiffbotSystemHardware::write(const rclcpp::Time&, const rclcpp::Duration&)’ marked ‘override’, but does not override
62 |   hardware_interface::return_type write(const rclcpp::Time & time, const rclcpp::Duration & period) override;
|                                   ^~~~~
/home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/src/blv_diffbot_system.cpp: In member function ‘CallbackReturn blv_diffbot_hardware::BlvDiffbotSystemHardware::on_init(const hardware_interface::HardwareInfo&)’:
/home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/src/blv_diffbot_system.cpp:30:44: error: ‘on_init’ is not a member of ‘hardware_interface::SystemInterface’
30 |   if (hardware_interface::SystemInterface::on_init(info) != CallbackReturn::SUCCESS)
|                                            ^~~~~~~
/home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/src/blv_diffbot_system.cpp:35:24: error: ‘info_’ was not declared in this scope; did you mean ‘info’?
35 |   hw_start_sec_ = stod(info_.hardware_parameters["example_param_hw_start_duration_sec"]);
|                        ^~~~~
|                        info
/home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/src/blv_diffbot_system.cpp:35:19: error: ‘stod’ was not declared in this scope; did you mean ‘std::cxx11::stod’?
35 |   hw_start_sec = stod(info.hardware_parameters["example_param_hw_start_duration_sec"]);
|                   ^~~~
|                   std::_cxx11::stod
In file included from /usr/include/c++/9/string:55,
from /usr/include/c++/9/stdexcept:39,
from /usr/include/c++/9/array:39,
from /usr/include/c++/9/tuple:39,
from /usr/include/c++/9/bits/unique_ptr.h:37,
from /usr/include/c++/9/memory:80,
from /home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/include/blv_diffbot_hardware/blv_diffbot_system.hpp:18,
from /home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/src/blv_diffbot_system.cpp:15:
/usr/include/c++/9/bits/basic_string.h:6642:3: note: ‘std::cxx11::stod’ declared here
6642 |   stod(const wstring& str, size_t* idx = 0)
|   ^~~~
/home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/src/blv_diffbot_system.cpp: In member function ‘virtual std::vector<hardware_interface::StateInterface> blv_diffbot_hardware::BlvDiffbotSystemHardware::export_state_interfaces()’:
/home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/src/blv_diffbot_system.cpp:113:25: error: ‘info’ was not declared in this scope
113 |   for (auto i = 0u; i < info.joints.size(); i++)
|                         ^~~~~
/home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/src/blv_diffbot_system.cpp: In member function ‘virtual std::vector<hardware_interface::CommandInterface> blv_diffbot_hardware::BlvDiffbotSystemHardware::export_command_interfaces()’:
/home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/src/blv_diffbot_system.cpp:129:25: error: ‘info’ was not declared in this scope
129 |   for (auto i = 0u; i < info.joints.size(); i++)
|                         ^~~~~
In file included from /opt/ros/foxy/include/rclcpp/client.hpp:40,
from /opt/ros/foxy/include/rclcpp/callback_group.hpp:23,
from /opt/ros/foxy/include/rclcpp/any_executable.hpp:20,
from /opt/ros/foxy/include/rclcpp/memory_strategy.hpp:24,
from /opt/ros/foxy/include/rclcpp/memory_strategies.hpp:18,
from /opt/ros/foxy/include/rclcpp/executor_options.hpp:20,
from /opt/ros/foxy/include/rclcpp/executor.hpp:33,
from /opt/ros/foxy/include/rclcpp/executors/multi_threaded_executor.hpp:26,
from /opt/ros/foxy/include/rclcpp/executors.hpp:21,
from /opt/ros/foxy/include/rclcpp/rclcpp.hpp:146,
from /home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/include/blv_diffbot_hardware/blv_diffbot_system.hpp:22,
from /home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/src/blv_diffbot_system.cpp:15:
/home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/src/blv_diffbot_system.cpp: In member function ‘hardware_interface::return_type blv_diffbot_hardware::BlvDiffbotSystemHardware::read(const rclcpp::Time&, const rclcpp::Duration&)’:
/home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/src/blv_diffbot_system.cpp:219:26: error: ‘info’ was not declared in this scope
219 |       hw_velocities[i], info.joints[i].name.c_str());
|                          ^~~~~
/home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/src/blv_diffbot_system.cpp:191:85: warning: unused parameter ‘time’ [-Wunused-parameter]
191 | urn_type BlvDiffbotSystemHardware::read(const rclcpp::Time & time, const rclcpp::Duration & period)
|                                         ~~~~~~~~~~~~~~~~~~~^~
In file included from /opt/ros/foxy/include/rclcpp/client.hpp:40,
from /opt/ros/foxy/include/rclcpp/callback_group.hpp:23,
from /opt/ros/foxy/include/rclcpp/any_executable.hpp:20,
from /opt/ros/foxy/include/rclcpp/memory_strategy.hpp:24,
from /opt/ros/foxy/include/rclcpp/memory_strategies.hpp:18,
from /opt/ros/foxy/include/rclcpp/executor_options.hpp:20,
from /opt/ros/foxy/include/rclcpp/executor.hpp:33,
from /opt/ros/foxy/include/rclcpp/executors/multi_threaded_executor.hpp:26,
from /opt/ros/foxy/include/rclcpp/executors.hpp:21,
from /opt/ros/foxy/include/rclcpp/rclcpp.hpp:146,
from /home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/include/blv_diffbot_hardware/blv_diffbot_system.hpp:22,
from /home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/src/blv_diffbot_system.cpp:15:
/home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/src/blv_diffbot_system.cpp: In member function ‘hardware_interface::return_type blv_diffbot_hardware::BlvDiffbotSystemHardware::write(const rclcpp::Time&, const rclcpp::Duration&)’:
/home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/src/blv_diffbot_system.cpp:250:7: error: ‘info_’ was not declared in this scope
250 |       info_.joints[i].name.c_str());
|       ^~~~~
/home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/src/blv_diffbot_system.cpp:225:86: warning: unused parameter ‘time’ [-Wunused-parameter]
225 | rn_type BlvDiffbotSystemHardware::write(const rclcpp::Time & time, const rclcpp::Duration & period)
|                                         ~~~~~~~~~~~~~~~~~~~^~
/home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/src/blv_diffbot_system.cpp:225:117: warning: unused parameter ‘period’ [-Wunused-parameter]
225 | e::write(const rclcpp::Time & time, const rclcpp::Duration & period)
|                                     ~~~~~~~~~~~~~~~~~~~~~^~
In file included from /opt/ros/foxy/include/class_loader/class_loader_core.hpp:57,
from /opt/ros/foxy/include/class_loader/class_loader.hpp:55,
from /opt/ros/foxy/include/pluginlib/class_list_macros.hpp:40,
from /home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/src/blv_diffbot_system.cpp:259:
/opt/ros/foxy/include/class_loader/meta_object.hpp: In instantiation of ‘B* class_loader::impl::MetaObject<C, B>::create() const [with C = blv_diffbot_hardware::BlvDiffbotSystemHardware; B = hardware_interface::SystemInterface]’:
/opt/ros/foxy/include/class_loader/meta_object.hpp:216:7:   required from here
/opt/ros/foxy/include/class_loader/meta_object.hpp:218:12: error: invalid new-expression of abstract class type ‘blv_diffbot_hardware::BlvDiffbotSystemHardware’
218 |     return new C;
|            ^~~~~
In file included from /home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/src/blv_diffbot_system.cpp:15:
/home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/include/blv_diffbot_hardware/blv_diffbot_system.hpp:38:7: note:   because the following virtual functions are pure within ‘blv_diffbot_hardware::BlvDiffbotSystemHardware’:
38 | class BlvDiffbotSystemHardware : public hardware_interface::SystemInterface
|       ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/include/blv_diffbot_hardware/blv_diffbot_system.hpp:26,
from /home/yash/blv_ws/src/blv_ros2_samples/blv_diffbot_hardware/src/blv_diffbot_system.cpp:15:
/opt/ros/foxy/include/hardware_interface/system_interface.hpp:48:23: note: 	‘virtual hardware_interface::return_type hardware_interface::SystemInterface::configure(const hardware_interface::HardwareInfo&)’
48 |   virtual return_type configure(const HardwareInfo & system_info) = 0;
|                       ^~~~~~~~~
/opt/ros/foxy/include/hardware_interface/system_interface.hpp:116:23: note: 	‘virtual hardware_interface::return_type hardware_interface::SystemInterface::start()’
116 |   virtual return_type start() = 0;
|                       ^~~~~
/opt/ros/foxy/include/hardware_interface/system_interface.hpp:122:23: note: 	‘virtual hardware_interface::return_type hardware_interface::SystemInterface::stop()’
122 |   virtual return_type stop() = 0;
|                       ^~~~
/opt/ros/foxy/include/hardware_interface/system_interface.hpp:128:23: note: 	‘virtual std::string hardware_interface::SystemInterface::get_name() const’
128 |   virtual std::string get_name() const = 0;
|                       ^~~~~~~~
/opt/ros/foxy/include/hardware_interface/system_interface.hpp:134:18: note: 	‘virtual hardware_interface::status hardware_interface::SystemInterface::get_status() const’
134 |   virtual status get_status() const = 0;
|                  ^~~~~~~~~~
/opt/ros/foxy/include/hardware_interface/system_interface.hpp:144:23: note: 	‘virtual hardware_interface::return_type hardware_interface::SystemInterface::read()’
144 |   virtual return_type read() = 0;
|                       ^~~~
/opt/ros/foxy/include/hardware_interface/system_interface.hpp:153:23: note: 	‘virtual hardware_interface::return_type hardware_interface::SystemInterface::write()’
153 |   virtual return_type write() = 0;
|                       ^~~~~
make[2]: *** [CMakeFiles/blv_diffbot_hardware.dir/build.make:63: CMakeFiles/blv_diffbot_hardware.dir/src/blv_diffbot_system.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:78: CMakeFiles/blv_diffbot_hardware.dir/all] Error 2
make: *** [Makefile:141: all] Error 2
Failed   <<< blv_diffbot_hardware [23.5s, exited with code 2]
Summary: 3 packages finished [25.0s]
1 package failed: blv_diffbot_hardware
1 package had stderr output: blv_diffbot_hardware

For various reasons, this repository is built with the ros2_control tag of 3.0.0 or higher instead of the default. Please clone ros2_control from Github and retry to build this repository.

can i run this with ros galactic?


build aar outputs web and macos plugins

Hello, I've noticed strange dependencies when using the following plugins:

image_picker (0.6.5)
shared_preferences (0.5.6+1)

We attach the Flutter module to an existing app by adding frameworks/aars, and we use the most recent beta.
Flutter 1.17.0 • channel beta • https://github.com/flutter/flutter.git
Framework • revision d3ed9ec945 (13 days ago) • 2020-04-06 14:07:34 -0700
Engine • revision c9506cb8e9
Tools • Dart 2.8.0 (build 2.8.0-dev.18.0 eea9717938)

our yaml:
dependencies:
  flutter:
    sdk: flutter
  flutter_localizations:
    sdk: flutter
  cupertino_icons: ^0.1.2
  flutter_spinkit:
  http:
  uuid:
  data_connection_checker:
  rxdart:
  get_it:
  shared_preferences:
  equatable:
  cached_network_image:
  image_picker:

After building frameworks:
flutter build ios-framework --xcframework --no-universal
The one name is very suspicious: flutter_plugin_android_lifecycle.
Android lifecycle for iOS? This one is added when we list image_picker in dependencies.
After building aars:
build-android-aars
There are multiple shared preferences folders, apart from simply "sharedpreferences", there are also shared_preferences_macos and shared_preferences_web, . The naming implies they shouldn't be built for Android, but for web or macOS. When I remove them - the app won't compile.
I have exactly the same outcome when using stable.

Hi @chris-rutkowski
if I'm interpreting your post and the posts from the linked issue
yours seems to be more a feature request than a reporting a bug within flutter
as the behaviour you are describing seems to be intended.
Thank you

@iapicca no, please ignore the linked issue, in that issue I was asked to create a separate issue for the mentioned problem. The renamed title is incorrect - I renamed it back.
Problem is very clear:

why there is flutter_plugin_android_lifecycle when building iOS frameworks
why there are shared preferenes for web and macOS when building Android aar

This is tracking two different issues.  @chris-rutkowski Let's use this one to track build aar outputting macos & web plugins.

The one name is very suspicious: flutter_plugin_android_lifecycle.
Android lifecycle for iOS? This one is added when we list image_picker in dependencies.

image_picker depends on flutter_plugin_android_lifecycle for the Android side of its behavior  and flutter_plugin_android_lifecycle on iOS is a no-op.  So you should be able to just not embed flutter_plugin_android_lifecycle in your host app?  I'm not sure if there's any way in the pubspec to specify a dependency only for a particular platform.
Can you file a new issue for this and @ me and we can discuss further in that issue so we don't confuse the build aar issue?

I will verify for you the not including flutter_plugin_android_lifecycle soon.
So let's keep this isssue purely about web and macos plugins for shared prefs.

This is a duplicate of https://github.com/flutter/flutter/issues/46304. The no-op Android implementations of those plugins are the expected side-effect of the workaround that will be removed once it's not needed for stable.


Can we do cropping after applying data augmentation transformations?

When using traditional DA like scaling/translation after applying CenterCrop, the output transformed show a black band:

Looking at how the prediction in the early epochs is considering this discontinuity at the image edge, I am concerned that the black edges might affect the performance of model training.
Is there a way to apply the CenterCrop after the transformation?

@jcohenadad how early are we talking in terms of epochs (at which point where these screenshots taken)? Also, was the model any good after the training?
I recognize this kind of pattern and I usually observe it in early epochs when training 2D segmentation models. Usually, after a few epochs, this phenomenon disappears. It's interesting that you suspect this would affect the model training, maybe you could expand on that thought? Personally, when I see these artifacts, it doesn't really bother me because in the early steps of the training process, the model has to overcome a certain trial-and-error phase where it slowly understands the problem it has to solve. Obviously this kind of result is unacceptable at convergence but if it only happens in the very first epochs, it doesn't strike me as problematic.

Excellent points @hermancollin. These were taken at ~10 epochs, and it is true that a longer epochs (>50) these patterns tend to disappear. As you pointed out, it is likely that at some point, this is not bothersome because the model 'learns' to ignore these edges. However, I was wondering if not having the edges would somehow improve the training process (ie: make it converge faster) and possibly improve the performance (ie: maybe the model has to learn that the edges need to be ignored, and this additional learning somehow removes the focus on finer details of the segmentation task). But I could be totally wrong. It should not be difficult to do a comparative test.

maybe the model has to learn that the edges need to be ignored, and this additional learning somehow removes the focus on finer details of the segmentation task

For this reason I think the convergence would indeed be faster. I think it depends on what kind of application we intend for the model. If we know the data will always have the exact same dimensions during inference, the model doesn't need to learn this additional "contextual" information about the borders. However, if we don't always have the same dimensions, maybe it is better for the model to learn to focus on the actual content of the image within the patch.

@jcohenadad In my understanding through several examples that I have seen online on how and where the data augmentation transformations are used, it is mostly the case the cropping (center or weighted) is done earlier followed by other transformations (e.g. flipping, scaling, affine, etc). This is also intuitive to me because we want to present the model the actual RoI first and then, transform it to add diversity only to the RoIs (and not the rest of the image).
Now, as per your question, if we do the transformations first, there is a high chance these transformations will alter the image such that the RoI will never be cropped later (or only be partially cropped). This can also negatively hurt the model performance, right?

This is also intuitive to me because we want to present the model the actual RoI first and then, transform it to add diversity only to the RoIs (and not the rest of the image).

Actually, in real life the opposite happens: you never expose the model during inference with black edges, hence my concern. My suggestion to perform DA before cropping is to match what the model sees during inference. Think about it that way: the DA is there to add variability in FOV placement, anatomical variability, etc. So, eg: if an FOV is slightly rotated, then the center crop that happens during inference does not include dark edges because there is signal outside of the cropping mask.


Resetting a custom setting throws error and removes setting

Tested versions

4.2.1 Stable

System information
Godot v4.2.1.stable - Windows 10.0.22631 - Vulkan (Forward+) - integrated Intel(R) UHD Graphics 620 () - Intel(R) Core(TM) i5-8265U CPU @ 1.60GHz (8 Threads)
Issue description
When I've added a custom bool setting in the project setting dialog and press the reset button, I get this error:

Steps to reproduce

create new bool setting from the project settings
click reset button.
Watch error

Minimal reproduction project (MRP)
N/A

It seems that this is because no initial value is declared. If you set an initial value for the setting with a line like this, you will notice that resetting the value works properly. ProjectSettings.set_initial_value("test/test/test_setting", false)

That's true. Still, it should "fail" more gracefully than this.
This issue may be a duplicate since it's not difficult to spot, but I'm not sure at the moment.

In my world there should be no reset button if there is no value to reset to...

In that case it would be impossible to remove any project setting without manually modifying the .project file, but that does not mean another solution cannot be found.

I would say it all ties into a lack of configuring settings from the editor, you cannot set initial values, manually delete, or change flags in settings without the use of helper scripts, or file modification.


Move to top-level packaging

Now that we have one source tree, most of the complications of building/packaging can go away. Move Jenkins to build from the toplevel cmake and delete the support scripts that were used to mangle all the different separate repos.

Fixed by #86


NuGet config causes project not to build

On a default installation of Visual Studio and NuGet, packages are downloaded to the CxCache folder. However, the csproj file in this repository references packages in a ..\packages folder. If you try to build this on a machine where you haven't redirected NuGet packages, you'll get an error:
This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them.  For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is ..\packages\Microsoft.Net.Compilers.1.0.0\build\Microsoft.Net.Compilers.props.
You can fix this by adding a Nuget.config file in the root that will ensure that for this solution packages are always downloaded into the ..\packages directory.

Thanks Jason! I wasn't able to repro this on a clean machine, so renamed one of my packages to simulate. I removed the EnsureNuGetPackageBuildImports target in the csproj file, which I read is another way to fix.


Contacted map authors list - OCN

Please don't edit this list for any reason unless you're adding another author who has been contacted.
Map authors who have given us permission

These map authors have given us permission to use their maps, and the maps are either on the site or on the list of maps to add.

AllttA

amactus

AMo

AntandRocky

Anthonny

Arzanex

AtlasGames

Avaleer

BeanButt

Beebou

bend

bleangamer

Brottweiler

CacklingPanda

Carterpaul

ch4teau

chle_

Claf

CoWinkKeyDinkInc

Creephunter

D347HxD

daeshik

Daffy_Duck01

dewtriod

DiamondAx

Diamyx

DoctorTardi

Doomyboy

Draeyx

Elijah

felipu_feliu

Flashee

GabeIsAwsome199

GammaRay89

GoldenOre

gushingblood

halfmaster1

HardstyleRaver2

HoldfastGames

iLifting

ItzaMeLuigi

JonnyBallgame

JSBach

Jtr

Kaleeka

KasiCrafter

Kaskito

koipen

Kroest

Lyzak

Matic0B

Mattato

matt772

McFanta_

Mikeg542

mitchiii_

Moo8x8

MrArchy

NadaStorm

Nanu

nintendoboy11

nixter1029

Obelistics

OllieGamerz

ollyj

Omnigarde

Oversoul96

Oxinous

pbat

PepsiDog

pikpikmerchant

PlasmaCross

Plastix

Qixit

raid3r

Rasta_Jol

Reshif

Rixiot

Ro_G

SailorMojo

samthecat43

SheriffSoco

Skirmisher47

snatimal

StealthMedia

Strmr

Teh_Myth

TheNoChillDude

Thungon

Timotheeee

Torn_Ares

UnPhair

ViceWaterColour

Vytr

whiskers434

whiteveR

Without_Regret

xCand

Yoyo_

Zan

_3Each

Map authors who have not given us permission

These map authors have not allowed us to use their maps, or have not allowed us to use any maps that have not been co-created by anyone else that we have permission to use.

Chicky

Cubist

Eclipsen

ElectroidFilms

Equus

Pugzy

rockymine

Strangey

Tjandra

Tywnis

_DISTRACTION

Map authors who we're still waiting to hear back from

These map authors have been contacted, but we have not heard a response from. It could be worth contacting these people again, maybe on a different platform.

BlockDrop74

Brumlington

crikimaruc

JETUB1

McSpider

McYukon

Mono0

oib5

SajinZero

Syvoxo

Map authors who do not need to be contacted further

These maps authors were contacted at one point in the past, but co-authors to all their maps have already given permission for us to use them.

auxdempster

BrunoTheMiner

Dino_Saurus

FlavorfulGecko5

TiggyLi

TruBuild

SpooksMcKenzie

Map authors who have not been contacted

These maps authors have not been contacted yet. Feel free to add anyone to this list.

__gavin

Eclipsen

LEGITME

OurLoneHero

Pyrolith

SajinZero

Solo_Runner

thegoodguy

way2hot4rs

https://github.com/MCResourcePile/mcresourcepile.github.io/projects/1


accuracy: Change accuracy() to a more suitable name

Pain Point
As of the recent merges, the high-level accuracy() function returns scores w.r.t different scorers selected. These could also be a resultant value of error.
Accuracy generally follows the phenomenon of "greater is better" but that is no longer the case here.
This could possibly be confusing for new users.
Proposed Solution
Change accuracy() to something like score() or evaluate()

Let's discuss this in the meeting, I think this might make sense.

I think I can pick this up if no one else is working on it , @mHash1m  are you working on this ?

@programmer290399 sure! I didn't get to this one yet.


"Aninoasa", "Săteni" are listed in the drop-down menu

Description:
When user writes ”Aninoasa”, ”Săteni” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Aninoasa"

Expected results
The location appears in the drop-down menu as "Sat Aninoasa, DÂMBOVIȚA (Aninoasa)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Săteni"

Expected results
The location appears in the drop-down menu as "Sat Săteni, DÂMBOVIȚA (Aninoasa)".

Step 3
Write in the search bar "Viforâta"

Expected results
The location appears in the drop-down menu as "Sat Viforâta, DÂMBOVIȚA (Aninoasa)".


Create an 0.1.0 milestone with a subset of the issues currently under the soon milestone

The soon milestone is intended to contain issues that I'd like to implement before general release, but I think it contains too many issues, and I should make a less-ambitious 0.1.0 release.
I should create a 0.1.0 milestone, and move a subset of the soon issues to it.

Done!


Update font css with guardian headline

It doesn't look like this will get done, and nobody appears to be crying out for it at the moment. I'll close this for now, we can reopen if necessary.


don't add location to amb nodes

@dwightguth what's the motivation for this change?

It's a bugfix; right now we are not initializing these struct fields and so the parser exercises undefined behavior by reading bits that are not initialized.


interop improvements

This started off by making things a touch more idiomatic with implementing From instead of using ad hoc conversion methods.
Then I found a couple features on Polars that we aren't using so I removed those (hopefully improving compile times and size of the .so).
Then I got stuck in removing dead code (esp from the dataframe api) in preparation for moving to lazy. Silly to have left things in from the original fork from ExPolars.

Why do the dataframes need to be stored in Rust? Why not a more mature language with more established interop tooling?

Despite their relative young age, the integration between Elixir and Rust is pretty solid. Plus many recent data efforts, such as Apache Arrow, have been centered around Rust.
In any case, backends are pluggable! So you are welcome to explore alternatives and we can discuss their inclusion based on their technical merits. :)


Does unilm have this function ?

Does unilm have this function ?
can we use unilm to calculate the probability that a input text as a real/resonable sentence base on the corpus we trained

The same question here! This can be very helpful and an essential feature.


Change scheduled list title

Fixes #531.

 Change the label "Scheduled for consultation" to "Consultation Scheduled for today [Date]"

Coverage decreased (-0.04%) to 61.762% when pulling 686f15fc4b6394f1e79a378905c0f54a7e33448e on ynurmahomed:schedule into 152682892ed124fe059559a8036e43be3b070916 on esaude:master.


Dropdown component included in a module not working

If you add a component that uses the dropdown..and that component is inside a module..then the dropdown stops working.. at least in the child component, attached is the build I made to test this.


chore(genesis): set deprecated fee values to 0 for localnet

Description
Related issue

Fixes #1341

Genesis file can't be modified!


feat: add lat/lon to shape distance notices"

Summary:
Summarize the changes in the pull request including how it relates to any issues (include the #number, or link them).
Expected behavior:
Explain and/or show screenshots for how you expect the pull request to work in your testing (in case other devices exhibit different behavior).
Please make sure these boxes are checked before submitting your pull request - thanks!

[ ] Run the unit tests with gradle test to make sure you didn't break anything
[ ] Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
[ ] Linked all relevant issues
[ ] Include screenshot(s) showing how this pull request works and fixes the issue(s)

@briandonahue is it possible to know if this is linked to an issue, or what is this solving?
Thanks

@isabelle-dr Apologies, I submitted as a draft PR, meant to update the description. It's related to this comment/conversation


make sure response is defined.

fixes this error:
 if (response.statusCode === 200) {
                    ^
TypeError: Cannot read property 'statusCode' of undefined

The changed code no longer exists, so closing this pull request


[Feature] Chromebook

Describe the solution you'd like
Is there plans for a chromebook version or is their future plans for Android 13?

I'm not familiar with the chromebook platform but since there are already releases for android and linux it should be possible. Maybe one of releases already works though it also requires the official app(s) to be installed and the data somewhere it can be found and imported.
The hitch with Android 13 is that it restricts one app from accessing the data of another app so the assets can't be imported from the official app.


fix: Add duration to getTask, addTask, quickAddTask and UpdateTask

Closes #241

@thales-fukuda thanks a lot for getting this done, it works perfectly 🎊
@pawelgrimm has a little bit more context on the duration feature, so I'd like his opinion before releasing this:

The API only accepts durations when a due date is set; otherwise, it silently discards the durations
The app is only displaying durations for tasks with due time and durations < 24h

Should we mimic these conditions in the SDK as well, or allow everything the API allows?

Thanks for the review @pawelgrimm!
I pushed a commit with the changes, please take a look to see if I didn't miss anything.
Also, I was doing an overview of the SDK types to see if something else is not aligned with the API documentation and I found some stuff. Should I open a new issue or can we discuss it here?


path is not defined

On win32 you get a Path not defined error on path.join.

yep this needs a merge!

Whoops!
Will be fixed in v0.9.1, as soon as I can get home and run npm publish.


Combine media-extend with obsidian-yt-transcript to navigate through transcripts

Hi everyone, recently I've been thinking of the optimal solution for taking video notes then I've found the two plugins media-extend and obsidian-yt-transcript, I want to navigate through transcripts, but there are some obstacles, cause I' am new to plugin development and don't know how to solve them. So I write it for some help.
media-extend could implement navigation through #, though there is a bug so need to put it inside a callout and inject css snippet  .workspace-leaf-content[data-type="media-view"] ~ .workspace-leaf-content[data-type="markdown"] { display:none; }
obsidian-yt-transcript generate timestamp link to jump to YouTube using ? and & in url, like below

my initial thought was to change the & to # in transcript link, but no luck, because url in editor register an event in media-extend while url in transcript view doesn't

I wonder if obsidian support any way to register an event from another plugin? or other approach to implement this and won't take much effort.Any insights or suggestions would be greatly appreciated !

I hope somebody will come up with a solution.
In the meantime I gave you my way of handling transcripts in an answer to your Obsidian Forum post

+1

Hi, @ichmoimeyo , @javiavid
I attempted to write it, see my fork here

I think Obsidian Timestamp Notes is a much more interesting plugin. You can regex the timestamps to make them compatible with ObsidianTimestampNotes
latest release 1.0.8 is from Jul 25, 2022
But a recent fork adds some very cool options like
Local media support, Add subtitle to local media, Snapshot support, Bilibili support, etc.

Hi, @TunaFFish
Thanks a lot, I didn't see the fork :(, I've tried Obsidian Timestamp Notes before, but it's timestamp syntax is a block and not allows to add description, so I give up haha.


Mobile: slide content scrolling issue with 3.4.1

#1467
how to deal this problem with v3.4.1
I add the code blew,not working
var swiper = new Swiper('.swiper-container', {
direction: 'vertical',
});
var startScroll, touchStart, touchCurrent;
swiper.slides.on('touchstart', function (e) {
startScroll = this.scrollTop;
touchStart = e.targetTouches[0].pageY;
}, true);
swiper.slides.on('touchmove', function (e) {
touchCurrent = e.targetTouches[0].pageY;
var touchesDiff = touchCurrent - touchStart;
var slide = this;
var onlyScrolling =
( slide.scrollHeight > slide.offsetHeight ) && //allow only when slide is scrollable
(
( touchesDiff < 0 && startScroll === 0 ) || //start from top edge to scroll bottom
( touchesDiff > 0 && startScroll === ( slide.scrollHeight - slide.offsetHeight ) ) || //start from bottom edge to scroll top
( startScroll > 0 && startScroll < ( slide.scrollHeight - slide.offsetHeight ) ) //start from the middle
);
if (onlyScrolling) {
e.stopPropagation();
}
}, true);

Issue is closed because of outdated/irrelevant/not actual/needed more information/inactivity.
If this issue is still actual and reproducible for latest version of Swiper, please create new issue and fill the issue template correctly:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with issue