Coinmaster Tokens

I am prepared to be told this is the wrong way to do this or that it is not a good idea at all.
There are a couple of Coinmasters that use multiple tokens and there is no way for a script to know what the possible tokens might be.  I did not want to break anything so I added a new Coinmaster proxy for multiple tokens.  A Coinmaster either has exactly one token in which the proxy token is used and the proxy multiple_tokens is "" OR it has multiple tokens and the proxy token is "" and the proxy multiple_tokens is a comma delimited list of tokens.
I then decided it would be nice if any token that was really an item would be recognized as such in a script.  So I changed some token values to match the corresponding item name.
I decided LUCRE needed to be FILTHY_LUCRE for no especially good reason.
I ran lint on ProxyrecordValue since I was already there.
I wrote two custom test scripts.  One checks that every Coinmaster has a proxy value for token or multiple_tokens but not both.  The other makes a list of Coinmasters that have non-item tokens.

I have to look a lot more closely at this. A few comments based on superficial scanning.

 IDE suggestions? Whatever; made it a lot harder to discern the actual PR changes.
Mr. Store has Mr. A and Uncle B.
I believe token names appear in the title of the appropriate panel of the CoinmastersFrame. They were intentionally shortened to fit in that context. You have lengthened them. Do they still fit?
Armory and Leggery tokens change every year. That is why it looks them up when you visit. Your intention is that we make a code change every year?

I'll comment more intently ehen zi am on my computer, rather than my phone. :)

Thank you.
"ran lint" was supposed to be understood as short hand for "ran a static code analyzer and accepted the suggestions that seemed reasonable".  If this continues as a viable PR then I can certainly back those out and put them in a different PR.
I missed Uncle Bucks.  Will add.
I will confirm that the token name is used the GUI.  If this means I have to resize GUI elements than it is too intrusive compared to what I am trying to do.
I don't like the A&L implementation either but it doesn't bother me because every year we have to add new rewards as items and a new trophy for Standard so adding two new currencies seemed like a reasonable yearly chore.
I'm ultimately interested in a scriptable way to generate a list of Coinmaster tokens.  This change lets me iterate over all Coinmasters to do so.  An alternative solution might be a RTL function is_Coinmaster_Token(item) and iterate over items.
Thank you again.

First of all, look at CoinmasterData.
A coinmaster deals in currencies other than Meat. If there is only one such currency, we call it the "token"

Note also that there is a method to derive all the currencies by looking at the "itemBuyPrice" of all items for sale:
  public Set<AdventureResult> currencies() {
    if (this.currencies == null) {
      this.currencies = new TreeSet<>();
      for (AdventureResult item : this.buyItems) {
        this.currencies.add(this.itemBuyPrice(item.getItemId()));
      }
    }
    return this.currencies;
  }

For Coinmasters with a static inventory with multiple currencies - the SpinMasterLathe, for example - we set them up at class initializatin time.
For Coinmasters with variable inventory and multiple currencies - MrStore, for example - we set them up when you visit the store and see what is on offer for what price.
Do not use "multiple tokens" with hard coded lists. Use "currencies" and let the CoinmasterData TELL you what they are.
I suggest you figure out which Coinmasters need to be visited to initialize their currencies.
Note that if a Coinmaster's inventory depends on player state - The Armory and Leggery, in particular - visiting will only detect items that are available for currencies you actually have.
Personally, I don't see the value of listing all the "pulverized standard rewards items". But, perhaps the Armory and Leggery could programmatically derive what its potential currencies are and what each is tradeable for. If you pulverize a Hardcore Standard reward, you can trade it for (any of) previous year's Hardcore rewards, right?
Perhaps we could have a data file: standard_rewards.txt:
2015	Hardcore	porcelain powder	Ceramic Suit
2015	Normal	polyesterene powder	Synthetic Suit
2016	Hardcore	bakelite bits	Bakelite Brigandine
2016	Normal	wickerbits	Wicker Wear
2017	Hardcore	wrought-iron flakes	Wrought Wrappings
2017	Normal	aerosolized aerogel	Aeroutfit
2018	Hardcore	fiberglass fibers	Fiberglass Finery
2018	Normal	gabardine smithereens	Gabardine Guise
2019	Hardcore	marble molecules	Marble Materials
2019	Normal	chalk chunks	Chalk Chostume
2020	Hardcore	terra cotta tidbits	Terra Cotta Tackle
2020	Normal	paraffin pieces	Paraffinalia
2021	Hardcore	stained glass shards	Stained Glass Suit
2021	Normal	velour veneer	Velour Vestments
2022	Hardcore	flagstone flagments	Flagstone Finery
2022	Normal	loofah lumps	Loofah Loungewear

If you can trade the pulverized item for any of the (6) previous year's rewards, the outfit defines those.

Thank you.  I had already decided to close this because Mr. Store actually has two tokens and using my new convention for multiple_tokens meant that I would break existing scripts because it would give them an empty string as the token.  The wisdom of that is supported by the fact that the token is used in the Coinmaster GUI and there is already code there that is handling multiple currencies (at least for Mr. Store).  This is not worth the overhead of doing the same thing differently in two places.
I agree that Set currencies() is a much better alternative and I will start there for my next exercise.
In general my application is
I have or can obtain X.
I can "transform" X into a member of a set Y.
Which member of Y should I choose if the goal is to sell it for meat?
I have, so far, not been able to get everything I want from coinmasters.txt.  The dynamic aspect of the data is problematic for speculative purposes - is it beneficial to obtain X? - because, for example, my wand of fudge control is usually in my DC.
I have a fantasy that there is a Unified Theory of Transformation and the right code could handle Coinmasters, the various creation methods, folding, zapping, using and anything else I have forgotten.  I think maybe I should give up on that Fantasy.
Probably should give up on speculation, too.
Thank you.


CI: Remove deprecated .github/workflow

Change Summary
Deprecated the avd base container
Component(s) name
ci
Proposed changes
remove the workflow
How to test
nothing to do 🎉
Checklist
Repository Checklist

[x] My code has been rebased from devel before I start
[x] I have read the CONTRIBUTING document.
[x] My change requires a change to the documentation and documentation have been updated accordingly.
[x] I have updated molecule CI testing accordingly. (check the box if not applicable)

No!


Tag version 1.3

There is no git tag for version 1.3. I need this to clone specifically at this version

oops I thought I'm opening this issue in the actual test262 repo.


KAFKA-724; Allow automatic socket.send.buffer from operating system in SocketServer

If socket.receive.buffer.bytes/socket.send.buffer.bytes are set to -1, use the OS defaults.

@ijuma PR #50  was done a while back, changes after rebase.Please have a look. thanks

Thanks for the PR @rekhajoshm. I left a couple of minor comments. Also, the PR title and description are used in the merged commit message. Can you please edit them to be:
PR title: KAFKA-724: Allow automatic socket.send.buffer from operating system in SocketServer
PR description: If socket.receive.buffer.bytes/socket.send.buffer.bytes set to -1, use the OS defaults work.

One more thing: we should also update the documentation in KafkaConfig and CommonClientConfigs stating that if the value is -1, the OS default is used.

done @ijuma Please have a look. thanks.

Thanks @ijuma Please have a look. thanks

The PR build failed @rekhajoshm.

my bad.fixed @ijuma Please have a look. thanks

Thanks, LGTM. Merged to trunk.

I am interested in such feature for configuring a producer but using -1 throws the following exception with Kafka clients <IP_ADDRESS>:
Exception in thread "main" org.apache.kafka.common.config.ConfigException: Invalid value -1 for configuration receive.buffer.bytes: Value must be at least 0
	at org.apache.kafka.common.config.ConfigDef$Range.ensureValid(ConfigDef.java:308)
	at org.apache.kafka.common.config.ConfigDef.parse(ConfigDef.java:153)
	at org.apache.kafka.common.config.AbstractConfig.<init>(AbstractConfig.java:49)
	at org.apache.kafka.common.config.AbstractConfig.<init>(AbstractConfig.java:56)
	at org.apache.kafka.clients.producer.ProducerConfig.<init>(ProducerConfig.java:315)
	at org.apache.kafka.clients.producer.KafkaProducer.<init>(KafkaProducer.java:156)
	...

I believe this is caused by an atLeast(0) validation in ProducerConfig.java that is not present in KafkaConfig for the server configuration:
  .define(SEND_BUFFER_CONFIG, Type.INT, 128 * 1024, atLeast(0), Importance.MEDIUM, CommonClientConfigs.SEND_BUFFER_DOC)
  .define(RECEIVE_BUFFER_CONFIG, Type.INT, 32 * 1024, atLeast(0), Importance.MEDIUM, CommonClientConfigs.RECEIVE_BUFFER_DOC)

I can create a separate PR for this but because CommonClientConfigs.java documentation was modified I am not sure if this feature was targeted at the server only or both the server and the clients.

@slaunay Yes, please create a PR.


Adding hover effects and improving Book Categories section

Hi @Trisha-tech I would want to improve this section. Could you assign me this task and add labels gssoc-ext and hactoberfest-accepted?

Thank you!

Hi  I’m interested in working on the hover effects and improving the Book Categories section. Could you please assign this task to me? I’d love to contribute to this project! Thank you.


[Web - HTML] InkWell splash does not render correctly in some Android browsers

When using HTML renderer, InkWell splash does not render correctly on Android in both debug and release mode.
This happens in Chrome and Samsung Browser, but not in Firefox or Opera (which is weird, because Opera is also Chromium based). It also doesn't happen in Chrome on Windows.
CanvasKit works well.
I've also tried it on DartPad using both beta and old channel, the problem still happens for me.
These are recorded on Samsung Galaxy S22 Ultra with the latest Android 12.
Chrome:

Chrome
Samsung Browser
Opera:

Lastly Chrome with CanvasKit renderer:
https://user-images.githubusercontent.com/13891066/172756860-35b8ca44-cc22-4da5-b9cc-1b3cc71164ce.mp4

Code sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  MyApp({Key? key}) : super(key: key);

  static const String _title = 'Flutter Code Sample';

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: MyApp._title,
      home: Main(),
    );
  }
}

class Main extends StatefulWidget {
  const Main({super.key});

  @override
  State<Main> createState() => _MainState();
}

class _MainState extends State<Main> {
  final List<int> _items = List<int>.generate(3, (int index) => index);

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: const Text(MyApp._title)),
      body: Column(
        crossAxisAlignment: CrossAxisAlignment.center,
        children: [
          TextButton(
            child: const Text('Button'),
            onPressed: (){},
          ),
          InkWell(
            onTap: (){},
            child: Container(
              height: 50,
            ),
          ),
          Flexible(
            child: ReorderableListView(
              children: <Widget>[
                for (int index = 0; index < _items.length; index += 1)
                  ListTile(
                    key: Key('$index'),
                    onTap: () {
                      ScaffoldMessenger.of(context).removeCurrentSnackBar();
                      ScaffoldMessenger.of(context).showSnackBar(SnackBar(
                        content: Text('Tapped item ${_items[index]}'),
                      ));
                    },
                    title: Text('Item ${_items[index]}'),
                  ),
              ],
              onReorder: (int oldIndex, int newIndex) {
                setState(() {
                  if (oldIndex < newIndex) {
                    newIndex -= 1;
                  }
                  final int item = _items.removeAt(oldIndex);
                  _items.insert(newIndex, item);
                });
              },
            ),
          ),
          Flexible(
            child: ListView(
              children: [
                for (int index = 0; index < _items.length; index += 1)
                  ListTile(
                    key: Key('$index'),
                    onTap: () {
                      ScaffoldMessenger.of(context).removeCurrentSnackBar();
                      ScaffoldMessenger.of(context).showSnackBar(SnackBar(
                        content: Text('Tapped item ${_items[index]}'),
                      ));
                    },
                    title: Text('Item ${_items[index]}'),
                  ),
              ],
            ),
          ),
        ],
      ),
    );
  }
}

Logs
flutter doctor -v
[√] Flutter (Channel stable, 3.0.1, on Microsoft Windows [Version 10.0.22000.675], locale en-GB)
    • Flutter version 3.0.1 at C:\Users\husar\AppData\Local\Flutter\SDK\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision fb57da5f94 (3 weeks ago), 2022-05-19 15:50:29 -0700
    • Engine revision caaafc5604
    • Dart version 2.17.1
    • DevTools version 2.12.2

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\husar\AppData\Local\Android\sdk
    X cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    X Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2022 17.3.0 Preview 1.1)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Preview
    • Visual Studio Community 2022 version 17.3.32519.111
    • The current Visual Studio installation is a pre-release version. It may not be supported by Flutter yet.
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 2021.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)

[√] IntelliJ IDEA Community Edition (version 2021.3)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2021.2
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart

[√] VS Code, 64-bit edition (version 1.67.2)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.42.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.22000.675]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 102.0.5005.63
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 101.0.1210.53

[√] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

EDIT: tried on Pixel 2 emulator running Android 11 and it doesn't happen there.

Hi @leoshusar, Thanks for filing the issue, I am quite not sure what this bug is reporting If I understand it right you mean when the pointer leaves the ListTile across its borders the Inkwell splash is still present is this the issue? if so I am not able to reproduce this on Xiaomi k20 pro (Android 11)
https://user-images.githubusercontent.com/31410839/172829042-9663c5da-ed59-483d-84c3-cfdbd5c6ed14.mov

flutter doctor -v (mac)
[✓] Flutter (Channel stable, 3.0.1, on macOS 12.3 21E230 darwin-arm, locale en-IN)
    • Flutter version 3.0.1 at /Users/mahesh/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision fb57da5f94 (3 days ago), 2022-05-19 15:50:29 -0700
    • Engine revision caaafc5604
    • Dart version 2.17.1
    • DevTools version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-32, build-tools 31.0.0
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! CocoaPods 1.10.2 out of date (1.11.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin
        usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 61.2.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.66.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.40.0

[✓] Connected device (4 available)
    • Redmi K20 Pro (mobile) • <IP_ADDRESS>:5555                     • android-arm64  • Android 11 (API 30)
    • iPhone 12 Pro (mobile) • 19FD0231-BFF0-441D-B584-AD94C4084525 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-15-2 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 12.3 21E230 darwin-arm
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 101.0.4951.64

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Thanks for your research @leoshusar, However enabling/disabling the GPU accelerated 2D canvas makes no difference on my side. Since that's an experimental feature in chrome, I believe that should be a bug in chrome. Also Can you please check if you see the same output in firefox too?

Firefox was ok even with accelerated canvas enabled.
No problem! I have filed an issue on Chromium tracker, so I think I can close this, at least for now. I'll see what they come up with.


Food

Friday evening pizza or dinner
Saturday breakfast, lunch, clojure cookie?

@kfoster32 will help this. Thanks!

@bridgethillyer do you think we still have time to order Clojure cookie? If so, where did you order last year?
In any case, we should have some sort of sweets for Saturday afternoon. If someone has ideas, please write here. Maybe, @jgkite knows well? Also, @kfoster32 ?

Mad Hatter. If you get the order in on Wed, I bet they can do them for you. They were kinda expensive.

@bridgethillyer seriously... hmm..

@yokolet @bridgethillyer I was planning on ordering pizza for Friday dinner and probably Foster's Market for lunch. I will bring in things for breakfast on Saturday. Did we ask for dietary restrictions at registration?

@kfoster32 The registration form does have a dietary restriction field. I have all, so will share with you.

For record, @kfoster32 ordered a cake which will have Clojure logo on it. Thanks!

Many thank you to @kfoster32 ! Student retro said food was good.


Introduce soap action error handling, part 4

Description
This this part 4 of PR series which suppose to add handling of soap failures.
In scope:

Bump nugget packages version.

Fixes RND-80626
Type of change

[ ] Bug fix.
[ ] Feature.
[x] Consolidation.

Checklist

[ ] Is breaking change.
[ ] Documentation updated.
[ ] Tests included (please specify cases).

@oleg-sokolansky  Let's also remove the temp tests that we added in the previous PRs


Increase invoke_tx_max_n_steps

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2139251) 68.86% compared to head (b6dea5b) 69.23%.
Report is 6 commits behind head on main-v0.13.1.

Additional details and impacted files
@@               Coverage Diff                @@
##           main-v0.13.1    #1477      +/-   ##
================================================
+ Coverage         68.86%   69.23%   +0.37%
================================================
  Files                59       59
  Lines              7993     8059      +66
  Branches           7993     8059      +66
================================================
+ Hits               5504     5580      +76
+ Misses             2032     2021      -11
- Partials            457      458       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


langchain[minor]: Couchbase document loader

Description:
Adds the document loader for Couchbase, a distributed NoSQL database.
Dependencies:
Added the Couchbase SDK as an optional dependency.

LGTM, just fix formatting in docs please!

Thanks for the comments and I have updated the PR accordingly.
@jacoblee93 one thing I was facing issue with building docs from about 3 days. It appears to be issue from .ipynb type docs. I have tried to detail it on discord Javascript-Contributing channel. A quick look from your end may help it out

Thank you! Still looks to be failing format but I'll fix


Add instructions for configuring GitLab CI

Motivation
The goal of this issue is to help GitLab users configure Uffizzi with GitLab CI, similar to how we have it configured with GitHub Actions.
Task
Add documentation/examples for configuring Uffizzi with GitLab CI. The GitLab CI integration is implemented here https://github.com/UffizziCloud/uffizzi_app/issues/184.  The instructions should be included in subdirectory ci/gitlab/. This issue depends on https://github.com/UffizziCloud/uffizzi_app/pull/202.
Include example YAML from gitlab-ci.yml along with other necessary information.

Add instructions to docs.uffizzi.com also.


Use error-prone for better compile-time analysis

error-prone can catch common bugs at compile-time that the Java compiler by itself does not.
There is a Gradle plugin that can be used to incorporate error-prone into the build.

I have enabled error-prone and it is already catching a good number of potential bugs, many of which are raised as compile-time errors:
/Volumes/Ocean/Projects/azkaban/azkaban/azkaban-common/src/test/java/azkaban/metric/MetricManagerTest.java:79: warning: [WaitNotInLoop] Because of spurious wakeups, wait(long) must always be called in a loop
        wait(2000);
            ^
    (see http://errorprone.info/bugpattern/WaitNotInLoop)
/Volumes/Ocean/Projects/azkaban/azkaban/azkaban-common/src/test/java/azkaban/project/ProjectTest.java:31: error: [LongLiteralLowerCaseSuffix] Prefer 'L' to 'l' for the suffix to long literals
    project.setCreateTimestamp(1l);
                               ^
    (see http://errorprone.info/bugpattern/LongLiteralLowerCaseSuffix)
  Did you mean 'project.setCreateTimestamp(1L);'?
/Volumes/Ocean/Projects/azkaban/azkaban/azkaban-common/src/test/java/azkaban/project/ProjectTest.java:32: error: [LongLiteralLowerCaseSuffix] Prefer 'L' to 'l' for the suffix to long literals
    project.setLastModifiedTimestamp(2l);
                                     ^
    (see http://errorprone.info/bugpattern/LongLiteralLowerCaseSuffix)
  Did you mean 'project.setLastModifiedTimestamp(2L);'?
2 errors
9 warnings
:azkaban-common:compileTestJava FAILED

and others as warnings:
:azkaban-execserver:compileJava
/Volumes/Ocean/Projects/azkaban/azkaban/azkaban-execserver/src/main/java/azkaban/execapp/FlowRunnerManager.java:356: warning: [SynchronizeOnNonFinalField] Synchronizing on non-final fields is not safe: if the field is ever updated, different threads may end up locking on different objects.
        synchronized (executionDirDeletionSync) {
                     ^
    (see http://errorprone.info/bugpattern/SynchronizeOnNonFinalField)
/Volumes/Ocean/Projects/azkaban/azkaban/azkaban-execserver/src/main/java/azkaban/execapp/FlowRunnerManager.java:554: warning: [SynchronizeOnNonFinalField] Synchronizing on non-final fields is not safe: if the field is ever updated, different threads may end up locking on different objects.
    synchronized (installedProjects) {
                 ^
    (see http://errorprone.info/bugpattern/SynchronizeOnNonFinalField)

What's awesome about error-prone is that it also links documentation about why these are potential bugs and suggested fixes.
I will open a PR with the changes to build.gradle and all the compile errors fixed. Because that patch may be somewhat meaty, I will open a separate one for fixing the remaining warnings.


Feature Request – Possibility to login with username or email

Actually I can login with username or if enabled with email. An option to login with both credentials would be nice (see twitter.com).

Are there any thoughts on the implementation of this? Right now if you're not using concrete.user.registration.email_registration then the email address doesn't have to be unique which might lead to problems. On the other hand, if you're using this setting then the username is the email address, they don't both exist (I don't think?).
Right now my only thought is to create another form of registration where the user is asked for both username and email, and both are checked for uniqueness on registration. Although this feels like we should really be setting a simple concrete.user.registration.type variable that encompasses both instead of having multiple bit toggles. Not sure what this looks like from a compatibility standpoint though.

This is something that could be done easily with an authentication type
within a package, I don't think this needs to be in the core because it
introduces some insecurities.
On Thu, Apr 9, 2015 at 9:10 AM Joe Meyer<EMAIL_ADDRESS>wrote:

Are there any thoughts on the implementation of this? Right now if you're
not using concrete.user.registration.email_registration then the email
address doesn't have to be unique which might lead to problems. On the
other hand, if you're using this setting then the username is the email
address, they don't both exist (I don't think?).
Right now my only thought is to create another form of registration where
the user is asked for both username and email, and both are checked for
uniqueness on registration. Although this feels like we should really be
setting a simple concrete.user.registration.type variable that encompasses
both instead of having multiple bit toggles. Not sure what this looks like
from a compatibility standpoint though.
—
Reply to this email directly or view it on GitHub
https://github.com/concrete5/concrete5-5.7.0/issues/2170#issuecomment-91276831
.

This is something that could be done easily with an authentication type
within a package, I don't think this needs to be in the core because it
introduces some insecurities.

That makes some sense... I don't think we do any kind of validation on usernames either so it might be possible to have username<EMAIL_ADDRESS>and a different user have an email address of<EMAIL_ADDRESS>and thus create a conflict. Obviously you could work around this by making usernames and emails be unique across the board but I'd agree it could just as easily go into a package.

Yeah, this should be its own custom authentication type.


Source release vs. git clone

Hi all,
what is the point in having source code releases (for instance https://github.com/ekg/freebayes/archive/v1.1.0.tar.gz), if one can not build the software from it, because they do not contain the submodules that one can get with:
git clone --recursive git://github.com/ekg/freebayes.git
For me a source code release only makes sense if I can actually build a software from it.
Would it be possible to provide a source code release tarball that includes the submodules ? For doing a test installation, a checkout of the current master branch is fine. But I would like to install freebayes 1.1.0 as part of a central software stack, which contains mostly versioned software. In order to transparently document this, I would need an official release, such that I can create an environment module, which requires a version number.
Best regards
Sam

@samfux84 I agree with you. But do you know how to make github do this?

This is a long standing problem with github's handling of source tarballs
that can be worked around by making a manual release.
On Tue, Jul 11, 2017, 10:37 Torsten Seemann<EMAIL_ADDRESS>wrote:

@samfux84 https://github.com/samfux84 I agree with you. But do you know
how to make github do this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ekg/freebayes/issues/385#issuecomment-314374371, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAI4EUhUwzayV-J81GIKx8cVh6zxy8DRks5sMzRIgaJpZM4NTx5x
.

@tseemann According to https://stackoverflow.com/questions/34719785/how-to-add-submodule-files-to-a-github-release even github support claims that it is not possible to include submodules in a release.
On hpc cluster, we try to provide a transparent versioning of softwares to users, which also allows for reproducible builds of the software.
If a scientist needs to reference a software in a publication to properly document where his results come from, then he can not just write something like
On 8. May 2017 I was running a git clone --recursive command on this or that repo.
My PhD supervisor always emphasized that from the information given in a paper (eventually including supplementary information which can be uploaded for some journals) it should be possible to reproduce the published results. In order to make this possible, a user should have some information on what version of a software he is using. This is good scientific practice.

It is possible to do this, but it will require an appropriate checkout and
submodule update to do. git clone ; git checkout <commit>; git submodule update --init --recursive if I remember correctly.
On Tue, Jul 11, 2017, 11:01 samfux84<EMAIL_ADDRESS>wrote:

@tseemann https://github.com/tseemann According to
https://stackoverflow.com/questions/34719785/how-to-add-submodule-files-to-a-github-release
even github support claims that it is not possible to include submodules in
a release.
On hpc cluster, we try to provide a transparent versioning of softwares to
users, which also allows for reproducible builds of the software.
If a scientist needs to reference a software in a publication to properly
document where his results come from, then he can not just write something
like
On 8. May 2017 I was running a git clone --recursive command on this or
that repo.
My PhD supervisor always emphasized that from the information given in a
paper (eventually including supplementary information which can be uploaded
for some journals) it should be possible to reproduce the published
results. In order to make this possible, a user should have some
information on what version of a software he is using. This is good
scientific practice.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ekg/freebayes/issues/385#issuecomment-314380344, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAI4EZgpvwN2w_vzC21FW5xZ_dn8h4-hks5sMznVgaJpZM4NTx5x
.


feat(watcher): now watcher can crawl for archived posts

this PR resolves #38

:tada: This PR is included in version 1.0.0-dev.1 :tada:
The release is available on:

GitHub release
v1.0.0-dev.1

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

v1.0.0
GitHub release
v1.0.0

Your semantic-release bot :package::rocket:


Minor corrections: Typo + clarification needed for token input

3 minor issues flagged with respect to the token input in the CLI:
Bug 1: Not really a bug, but rather a weird use case. When a user has already entered a valid token in a prior session (ie: not a new CLI user), if they type in any string that isn't a valid token, the CLI would continue to run as intended.
Not sure whether having the CLI throw an error for any invalid string (even if the user is not new to the CLI) would be a good idea.
Bug 2: This is an actual bug. If the user accidentally presses "ENTER" multiple times during the CLI's What is your access token prompt, the CLI will behave weirdly, and "skip" certain prompts.
Eg:

Typo: There is a very minor typo in the CLI beginning instructions. "amd" should be corrected to "and" in the part: If this is not your first time running the app amd have previously entered a valid token, you can just press enter on your keyboard.

Bug 1 isn't a bug and it throws the invalid token error if you have never entered a correct access token before. I have tested it in the past when I haven't gotten an access token and it would throw an error if you enter any random string. But the tool should run as intended even if you put in a random string as the access token if you already inputted a valid access token in the past on that device

Bug 1 isn't a bug and it throws the invalid token error if you have never entered a correct access token before. I have tested it in the past when I haven't gotten an access token and it would throw an error if you enter any random string. But the tool should run as intended even if you put in a random string as the access token if you already inputted a valid access token in the past on that device

Ok that sounds great then, sorry that was a misunderstanding on my part. I'll mark that as resolved then!


validate exit code should be 1 on error

liquibase validate exits with return code 0 even on validation error. To allow integration into scripts and development process tooling, it would be helpful if the best practice from unix was followed:

return 0 on success
return an int greater 0 on error. Having specific error codes for say xml validation error and a different one for syntactically sound but changed changesets would be a plus.

$ liquibase --changeLogFile master.xml validate
Starte Liquibase am Di, 25 Feb 2020 17:02:05 MEZ (Version 3.8.0, kompiliert am 2019-08-15T20:38:06Z)
echLiquibase Community 3.8.0 by Datical
o $?
Validation Error:
1 change sets have changed since they were ran against the database
change_88.xml::#BSLB-XXY: addColumn: departments::christof was: 8:28984dcd4c2a48cadab9994e8e40fc05 but is now: 8:2676116ef19fedfe8ba62352c10885e1
Liquibase: Der Befehl 'validate' wurde erfolgreich ausgefÃ¼hrt.
$ echo $?
0

┆Issue is synchronized with this Jira Bug by Unito

Thanks for reporting this! This is something that we have been thinking about already.

I may have a look at this soon but parking for now..

Hi @smcveigh941 I will get with the team about this one.

Hey all I just wanted to highlight that it's quite an issue, we are running Liquibase Validate as part of our CI and are not able to catch bugs

Same issue. Working on a CI pipeline for DB updates and Liquibase is really unfriendly when it comes to errors handling.

#2185 is the newer PR to handle this


dynatrace-track2-release

release for issue: https://github.com/Azure/sdk-release-request/issues/2769

/azp run prepare-pipelines

/azp run js - dynatrace - mgmt - ci


Calling Mutation onClick

I want to call mutations onClick on the buttons.
How Can I do that?
Like simple Post and Get calls without returning as a widget.
I am unable to find any example for that.
So please help me with the examples.
Using Client Without Widget for both Query and Mutations with Headers.
I tried the one example in ReadMe but I think its older one, many things have been changed after that,
Please help me with this.

You can now see some direct client usage in the bloc example.
Essentially you just QueryResult result = await client.query(options)
or QueryResult result = await client.mutate(options) directly on the client with their respective options objects.
Better direct client usage (and better docs in general) is on the roadmap will be more of a focus after #203 is merged


refactor: Adjust app service names in Spire seed script

If your build fails  due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:

[x] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[x] I am not introducing a new dependency (add notes below if you are)
[ ] I have added unit tests for the new feature or bug fix (if not, why?) N/A
[x] I have fully tested (add details below) this the new feature or bug fix (if not, why?)  N/A
[ ] I have opened a PR for the related docs change (if not, why?)  N/A

Testing Instructions
TBD
New Dependency Instructions (If applicable)

Codecov Report

Merging #4494 (ef57b85) into main (90e066c) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main    #4494   +/-   ##
=======================================
  Coverage   41.57%   41.57%
=======================================
  Files         106      106
  Lines        9749     9749
=======================================
  Hits         4053     4053
  Misses       5350     5350
  Partials      346      346

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Clicking on month/year next/previous buttons in DatePicker causes parent form to submit

Reproduction link
https://stackblitz.com/edit/ng-zorro-antd-ivy-zmsagn
Steps to reproduce
Put DatePicker inside of a <form> and click on one of the month/year next/previous buttons.
What is expected?
DatePicker shouldn't trigger form submission.
What is actually happening?
Form submission is triggered.

Environment
Info

ng-zorro-antd
12.0.1

Browser
Any

This is happening, because buttons miss type="button" attribute.

I have to use the following workaround to fix this issue in our application:

  /**
   * Makes sure that each button has a proper `type=button`
   * attribute, otherwise they could submit a parent form.
   */
  private fixCalendarButtons() {

    if (!('querySelector' in document)) {
      console.warn(`DOM query selector is not available`);
      return;
    }

    const element = this.getCalendarElement();

    element?.querySelectorAll('button:not([type])').forEach(
      element => element.setAttribute('type', 'button')
    );

  }

  private clearCalendarMutationObserver() {
    if (this.calendarMutationObserver) {
      this.calendarMutationObserver.disconnect();
      this.calendarMutationObserver = undefined;
    }
  }

  /**
   * Monitors calendar DOM for changes and
   * applies buttons fix automatically.
   */
  private setupCalendarMutationObserver() {

    // Clearing previous observer
    this.clearCalendarMutationObserver();

    const element = this.getCalendarElement();
    if (!element) {
      return;
    }

    this.calendarMutationObserver = (
      new MutationObserver(() => this.fixCalendarButtons())
    );

    this.calendarMutationObserver.observe(element, {
      subtree: true,
      childList: true,
    });

  }

  private getCalendarElement(): (HTMLElement | undefined) {

    if (!this.calendarElement?.nativeElement) {
      console.warn(
        `Can't obtain DatePicker DOM element, ` +
        `is it rendered?`
      );
      return;
    }

    return this.calendarElement.nativeElement;

  }

Mutation observer is needed, because some buttons are getting rendered dynamically and do change when navigating around the calendar.


OAK-11169 - MongoVersionGCSupport (oak-document-store) wrong syntax for sort mongodb function

Bug fixed adding Sorts.ascending in place of and(eq(MODIFIED_IN_SECS, 1), eq(ID, 1));

Overtaken by events, see https://github.com/apache/jackrabbit-oak/commit/ef5819f38d09038ce24cef821a5b45d9bee0f9e8.


Performance improvement when using multiple instances

Hi there, excellent library, love it! ❤
I noticed that when you instantiate the LanguageDetector multiple times, you end up with a memory leak.
Can be easily reproduced:
<?php

use Nitotm\Eld\LanguageDetector;

require_once 'vendor/autoload.php';

$startTime = microtime(true);
$detectors = [];

for ($i = 0; $i < 20; $i++) {
    $detectors[] = new LanguageDetector();
}

echo 'Memory usage: '.round(memory_get_usage() / 1024 / 1024, 2).'MiB (peak: '.round(memory_get_peak_usage() / 1024 / 1024, 2).'MiB), time: '.round(microtime(true) - $startTime, 2).'s';

Current main:
Memory usage: 958.19MiB (peak: 990.14MiB), time: 0.96s

After the PR:
Memory usage: 48.93MiB (peak: 80.8MiB), time: 0.05s

There are probably other ways to solve the issue but that was the quickfix :-)

Most of the time I use the web server (php-cgi), where this error does not reproduce, I'm guessing because of OPcache.
Anyways, this is just something I noticed, the code should not rely on any php cache, so you fix is good.
I will make sure I test things like this with non cgi.

Yeah usually people won't use multiple instances of the LanguageDetector anyway I guess but still, it's something that should be fixed :)

You've destroyed the whole point of this PR in your commit in https://github.com/nitotm/efficient-language-detector/commit/58b8a7e5915bbad5d4fa243c07496b400f325869 again because now it's not a static array anymore. Meaning that when you instantiate multiple LanguageDetector instances, it will again become slow.

You've destroyed the whole point of this PR in your commit in 58b8a7e again because now it's not a static array anymore. Meaning that when you instantiate multiple LanguageDetector instances, it will again become slow.

Hi, I'm looking at the code, and I am not seeing what you mean.
I see it is still static, I made tests and it works as expected.
You may have missed it, but your private static  array $fileContents = []; was on line 32, with bad format (double space), and now it is on line 19
The commit you are referencing it is a reformat, plus only one change, that is using require instead of require_once:
The reason of using require, is because the if condition will already prevent the same file to be loaded twice, and in the event there is an error, which I cannot foresee what could be, I thought it rather loads the file than fatally fail.
I reasoned it a little more, whether to use require, but since it is not the topic of your message I will not dwell on it. In any case, if you think that is a problem, I am open to reconsidering it.


Update case-app to 2.0.3

Updates com.github.alexarchambault:case-app from 1.2.0 to 2.0.3.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.github.alexarchambault", artifactId = "case-app" } ]

labels: library-update, semver-major

Superseded by https://github.com/coursier/http-server/pull/38.

Will update that another time.

Superseded by #53.


Update embedded bitcode support to work with llvm r269706.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

The original support for embedded bitcode used appending linkage for the
magic internal variables that hold the bitcode and command line options,
but that private linkage is a better fit. The only real reason for
appending linkage was to prevent those variables from being optimized away.
r269706 limits the use of appending linkage so that it cannot be used for
those variables, so this switches to use private linkage and keep the
variables alive with llvm.compiler.used. This is basically copied from
clang r269679. rdar://problem/28685198.
As of the swift-3.1-branch versions of Clang/LLVM, embedded bitcode is now
working well enough that the tests can be reenabled. rdar://problem/26247134

@swift-ci please smoke test


How to add more icons?

I want to add more social networking icons, could you help me please?

icon: the icon shown at /blog/ at each post, please reference http://fontawesome.io/icons/ and http://fizzed.com/oss/font-mfizz, it should be fa-xxx or icon-xxx
message from https://github.com/jarrekk/Jalpc/wiki/How-to-add-posts


query of table with both hash & sort keys fail if query is via only hash key

Primary key is missing for the parcel model

Error is due to the connector not creating a PK when no partition key is found available.
a possible hack to fix it would be appending a UUID to the id property if no sort key is found. The correct solution is probably implementing a new DAO for dynamodb which can handle loopback's generated methods correctly.

My newest version scraps the PK generation methodology and connects to loopback via composite IDs. this allows for me to query by just hash key.
My new implementation currently cannot update via API, but thats only because I havent converted the update function. overall it seems to be performing well.


Add ATB, IEA, and NREL 5 MW 126m turbines to library

Is your feature request related to a problem? Please describe.
Turbine power curves used in the 2020 ATB are not available by default in SAM.
Describe the solution you'd like
Adding the 2020 ATB turbines to wind turbine library file. Power curves are available here: https://github.com/NREL/turbine-models
Describe alternatives you've considered
Users can manually add files to the library file, but manual changes don't persist during updates.
Additional context
Add any other context or screenshots about the feature request here.

Here's the python code I used to get turbine specs from the power curve archive, https://github.com/NREL/turbine-models, in case anyone wants to use it.
A few notes:

You need a copy of the SAM turbine library file, 'Wind Turbines.csv', in the working directory.
There is a lot of overlap between existing turbines in the SAM library and the power curve archive, but names don't match exactly, so you may have to manually remove duplicates (this is the reason I ended up only adding the ATB, IEA, and NREL 5 MW 126m turbines)
This script uses the file naming convention in the power curve archive to extract turbine name, rotor diameter, and rated power, but the naming convention is not 100% consistent. I think I caught the current exceptions with some if statements...
IEC class is available for many of the turbines here https://nrel.github.io/turbine-models/index.html, but that information is not captured by this script. A more robust approach would pull data, including names, from https://nrel.github.io/turbine-models/index.html.
Please excuse any sloppy code.

import os
import pandas as pd

# download turbine .csv files from https://github.com/NREL/turbine-models
repo = "turbine-models"

!git clone https://github.com/NREL/{repo}.git

rootdir = 'turbine-models'

for subdir, dirs, files in os.walk(rootdir):
    for file in files:
        if file.endswith(".csv"):
            print(os.path.join(subdir, file))

            ## read data
            data = pd.read_csv(os.path.join(subdir, file))

            ## get turbine name, rotor diameter, and rated power from the filename
            temp = file[:-4] # remove ".csv" from end of filename
            # if it's a reference wind turbine ("RWT" near end of filename):
            ref = False
            if "_RWT" in temp:
                ref = True
                x = temp.find("_RWT")
                suffix = temp[x:len(temp)]
                temp = temp[0:x]
            # if it's an IEC or WTK normalized turbine, since those don't follow typical file name convention:
            if "IEC" in temp or "WTK" in temp:
                print("IEC or WTK")
                name = temp.replace("_", " ")
                rated_power = 1
                rotor_diameter = 1
            else:
                x = temp.rfind("_") # find position of last "_"
                rotor_diameter = temp[x+1:len(temp)] # extract rotor diameter (characters after the last "_")
                temp = temp[0:x] # trim off rotor diameter characters
                x = temp.rfind("_") # find position of new last "_"
                rated_power = temp[x+1:-2] # extract rated power
                rated_power_units = temp[-2:] # extract rated power units
                if rated_power_units == "MW": # if units are in MW, convert to kW
                    rated_power = float(rated_power) * 1000
                    rated_power_units = "kW"
                if ref: #if it's an "RWT" turbine
                    temp = temp+suffix
                name = temp.replace("_", " ") # replace "_" characters with spaces

            ## create wind speed and power curve arrays
            d2 = data.astype(str)
            in_wnd_spd = d2['Wind Speed [m/s]']
            wind_speed_array = str()
            for i in range(len(in_wnd_spd)):
                if i == 0:
                    wind_speed_array = wind_speed_array + in_wnd_spd[i]
                else:
                    wind_speed_array = wind_speed_array + '|' + in_wnd_spd[i]
            in_pwr_crv = d2.iloc[:,1]
            power_curve_array = str()
            for i in range(len(in_pwr_crv)):
                if i == 0:
                    power_curve_array = power_curve_array + in_pwr_crv[i]
                else:
                    power_curve_array = power_curve_array + '|' + in_pwr_crv[i]

            ## write to library csv file
            new_turbine_csv_row = name + ',' + str(rated_power) + ',' + str(rotor_diameter) + ',' + 'unknown' + ',' + wind_speed_array + ',' + power_curve_array
            with open('Wind Turbines.csv','a') as fd:
               fd.write(new_turbine_csv_row)
               fd.write("\n")  # Next line.


ng serve doesn't consider the timezone when printing the output

Bug Report or Feature Request (mark with an x)
- [x] bug report
- [ ] feature request

Command (mark with an x)
- [ ] new
- [ ] build
- [x] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions
Angular CLI: 6.2.4
Node: 8.12.0
Yarn: 1.10.1
OS: linux x64
Angular: 6.1.10
Repro steps
ng serve
The log given by the failure
As it's seen on the next image, the date on the machine and the date on the ng serve output differ (more precisely, the timezone is not being considered).

Desired functionality
The log should print the correct local date and time.

The time is in UTC notice the Z at the end of the time stamp.  This is intentional and intended.

For somebody who still wants to override this:
<EMAIL_ADDRESS>replace new Date().toISOString() with new Date().toString()


[$250] Workspace - An error page displayed when try to create a new Workspace

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app and login with any account
Go to Settings>Workspace
Open any existing workspace or create new
Click the three buttons on the top right and select new workspace

Expected Result:
A new workspace should be created
Actual Result:
An intermediate error page is visible when creating a new workspace
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): any
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/187276347-6ae0f21c-0a5a-47ba-8715-1af2554094bf.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Upwork job: https://www.upwork.com/jobs/~0130559a1d7f12c75c

Hey @Tushu17, thanks for reporting that bug. This issue is slightly different. This happens when creating a workspace, not deleting it. The error page is momentarily shown before the new workspace page is shown.

Okay @puneetlath, I think both of these bugs are very similar, So Ig it would be better if we merge them?

Proposal
we need to pass the array in this Promise.all in create function
https://github.com/Expensify/App/blob/22a0cba7aaeaa786f04a63a5ad74c650c4c35001/src/libs/actions/Policy.js#L136-L144
+return Promise.all([
  Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${response.policyID}`, {
      id: response.policyID,
      type: response.policy.type,
      name: response.policy.name,
      role: CONST.POLICY.ROLE.ADMIN,
      outputCurrency: response.policy.outputCurrency,
  }),
  Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY_MEMBER_LIST}${response.policyID}`, getSimplifiedEmployeeList(response.policy.employeeList)),
+]);

After fix:
https://user-images.githubusercontent.com/35371050/187528600-ea4adf16-76ee-4edc-aa97-3d894525a6ad.mp4
this same change will fix 10665 issue

I agree we can close this one since it's a duplicate of https://github.com/Expensify/App/issues/10665 (seems both were created at almost the exact same time haha)


iNaturalist thinks some insects are plants

These display as the green color on their maps as well as on the 'insects' map that otherwise shows only red dots
http://www.inaturalist.org/observations/1128559#comment-288765
http://www.inaturalist.org/observations/1088988
http://www.inaturalist.org/observations/1089009
They were each accidentally tagged as 'plants' and htne corrected to insects and their respective IDs but for some reason the map pin does not change.
Sorry, not sure if I should post this here or in windshaft I will repost there if that is where it belongs

yes this is a bug where the community ID change doesn't set the iconic_taxon_id - I've known about it but not sure anyone made an issue = thanks charlie

So if there's not an issue, can you explain what the underlying problem is in more detail? Sometimes the setting the community ID doesn't change the iconic taxon ID? If only sometimes, are there any consistent conditions?

In the case of the three I saw. they were accidentally entered into the
database as plants and then soon after corrected to an insect. The name
attaches correctly but the color of the pins on any maps still shows up as
green. I suspect maybe it is something like if it is changed too fast after
upload the indexer gets confused but i don't really know what i am talking
about so...
On Thu, May 21, 2015 at 10:07 PM, Ken-ichi<EMAIL_ADDRESS>wrote:

So if there's not an issue, can you explain what the underlying problem is
in more detail? Sometimes the setting the community ID doesn't change the
iconic taxon ID? If only sometimes, are there any consistent conditions?
—
Reply to this email directly or view it on GitHub
https://github.com/inaturalist/inaturalist/issues/565#issuecomment-104475791
.

--
Charlie Hohn
Montpelier, Vermont
coyot.es/slowwatermovement

Corrected how, but just changing the parent of the taxon record or by creating a taxon change?

this issue remains but was previously logged here https://github.com/inaturalist/inaturalist/issues/380


reject dropping messages?

I have 3 queues: main, main.retry and main.rejected. (I don't think retry matters for the problem I describe)
main has DLX of main.rejected
main.retry has a DLX of main with a TTL of n seconds
A message comes in on main and I reject it. It correctly goes into main.rejected. THEN, I use the message shovel to put it BACK in main. The subscriber processes it again and rejects it again. At this point, the message just disappears. Why?

I don't quite understand it yet, but this seems likely to be the cause. The headers on initial delivery are:
	"fields": {
		"consumerTag": "Maxs-iMac.local.node.41159.test.q",
		"deliveryTag": 3,
		"redelivered": false,
		"exchange": "test",
		"routingKey": "testkey"
	},

After rejection and using shovel, they are like this:
	"fields": {
		"consumerTag": "Maxs-iMac.local.node.41159.test.q",
		"deliveryTag": 4,
		"redelivered": false,
		"exchange": "",
		"routingKey": "test.q"
	},

Rejecting that second message dumps it into the aether.

I now realize this is me misunderstanding shovels. The default one in the UI blows up the exchange and routingkey values, but I can create a dynamic shovel in the UI that does not. So, not a rabbot bug at all.


Ensure uniform cache is updated when only maxLoc is null

MISC
Even if only maxLoc is null, the uniform cache should be updated.

This change is

Closing this out for inactivity. If this is still an issue in the future let's open a new PR.


Feature Request: MusicBot play Live Stream

Issue Type

[x] Feature Request

Description
can the Musicbot play the Live Stream like YouTube Twitch

yes.
[p]play [livestream url]

yea some here

Yes, playing live streams is supported, as shown above. If some streams aren't working, I would suggest waiting for the next release and trying with that when it is available.


unit / integration test for code completion

Yeah, i have a bunch of these locally that I'm running - they're a bit tricky to get into the repo because of their dependency on paths to infrastructure e.g. package roots, which are local.
They need turning into parameters of the tests. Do you have a defined list of where this stuff lives on Drone IO and what version of the VM it's running?

I suspect our readme (https://github.com/dart-lang/dart-services/blob/master/README.md) for setting up the server is out of date. Can you create some simple steps in a wiki or something? That'll help me figure out what we need for the buildbot.

The test and benchmarks are initiated from here: https://github.com/dart-lang/dart-services/blob/master/tool/travis.sh.

A simple test is now in. Will expand the set over time.


SPIKE: Investigate Slack functionality for issues channel

Background
Following the session on 28/11/24 when we reviewed how the issues channel is working, we would like to investigate some potential improvements on Slack.
Feature(s) Description

[x] Check whether it is possible to block direct posts into the Slack channel, except for our automated alerts when an issue is reported
[x] If it is possible to block direct posts into the Slack channel, as above, check if it is possible to allow users to respond only in a thread under the issue alert post
[ ] Investigate the possibility of having a developer rota in Slack
[ ] If a rota is possible, can the developer on duty be automatically assigned to tickets that are posted, or can we hook into a rota list outside of Slack?
[ ] If we had multiple options from the report an issue button, e.g. ask a question, could we have have those assigned to a different person or not assigned to anyone?

Feature champion
Nick

1. Check whether it is possible to block direct posts into the Slack channel, except for our automated alerts when an issue is reported
Yes, it’s possible to set posting permissions to adjust who can post to channels.
https://slack.com/intl/en-gb/help/articles/360004635551-Manage-channel-posting-permissions
2. If it is possible to block direct posts into the Slack channel, as above, check if it is possible to allow users to respond only in a thread under the issue alert post
It seems not possible to restrict users from responding only in a thread.

@HalcyonJAC I've followed those instructions, but I don't see the Posting permissions link in the Slack channel settings. Are you able to see it?
It seems like the control is not granular, either all members can post to the channel or individual members can be prevented from posting, but if you block direct posting, they would not be able to reply in a thread, is that correct?

@nickaddy It seems that we can set posting permissions in the #general channel as our subscription is Pro.

@nickaddy Yes, we can check which option it is first and then decide whether we should create a ticket on Zenhub/GitHub. I have tested it is doable to post a message via Slack API.


Xyi/add mac bender

I am doing a mini experiment on git pull request. Please make comments.

I made a mistake about the branch to pull the request from, sorry.


Link to https://f000.backblazeb2.com/ is broken

As the datasets are stored there, they can't be downloaded. Have the datasets been moved elsewhere?

which dataset?

The summarization dataset, for example: https://f000.backblazeb2.com/file/malay-dataset/summarization/dailymail/translated-dailymail-test.json

moved to https://huggingface.co/datasets/mesolitica/translated-cnn-dailymail/tree/main


chore(ops): add netlify config for branch/PR preview builds

Summary

adds a config so I can set up automatic build previews in PRs via Netlify like the Carbon repos have

Change List (commits, features, bugs, etc)

add netlify.toml config with our build commands/path

:tada: This PR is included in version 1.15.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.15.0 :tada:
The release is available on npm package (@release-1.x dist-tag)
Your semantic-release bot :package::rocket:


Default exit in scene

Add exit scene button if there is no other way to continue

If that happened, its a sign that something went terribly wrong. So I'd rather for the player to get 'stuck' and report it rather than silently continue but in a broken game state x3

Yeah, sorry, like I said, better for the player to get stuck rather than getting into an unintended/broken game state


Mac OS X support

Hi,
this is a Mac OS X compatible version of Nana. I added some configuration directives to make it work.
Please tell me if it's okay for you.
Benjamin

Great jobs! I will merge this pull request when release of 1.2 is ready. Thank you

Hi, would you please test the modifications with the latest code in develop branch? Thank you!


Return Result Object From Upload

Feature request
The Upload method on IStoreFileApi needs an IsSuccess flag and an error message.
Is your feature request related to a problem? Please describe.
I'm uploading files to a bucket, and the method is returning the path. However, the file never shows up in the bucket. Actually, I cannot upload files at all with this method. Clearly, the file is failing to upload, but I have no idea why.
Describe the solution you'd like
The Upload method should return a response model, like that in the other clients, and it should give an error to explain what went wrong. I've burned hours trying to upload a file and I still have no idea why it never shows up on the other side. It's probably just a permissions issue, but I have no feedback to tell me.
Describe alternatives you've considered
I can only think of using the JavaScript client instead.

@acupofjose Thankyou very much

@MelbourneDeveloper okay. I implemented it a little differently than you requested, but the Upload and Download methods will now throw exceptions if you are unauthorized to access them.
If it returns the path, you should now be confident in the path existing. I will be creating a new minor release with the updates here shortly before pushing it to the main supabase-csharp repo.
Again, apologies for the delay. But thank you for the issue, helpful bug catching here.


Scripts show up in Explorer, but not found when using 'npm: Run Script' command

I was in a single-root workspace with multiple package.jsons with different scripts defined.
Npm scripts all show up in the Explorer, but got No scripts found. when using 'npm: Run Script' command.
The output panel of npm was blank, and reloading window didn't help either.
npm.includeDirectories wasn't configured, and the package.json at the root dir doesn't have any scripts.
Extension version: v0.3.22
About VS Code:
Version: 1.59.0
Commit: 379476f0e13988d90fab105c5c19e7abc8b1dea8
Date: 2021-08-04T23:14:40.191Z
Electron: 13.1.7
Chrome: 91.0.4472.124
Node.js: 14.16.0
V8: 9.1.269.36-electron.0
OS: Darwin x64 20.6.0

Please provide more detailed steps for how to reproduce the problem.


Verify 'nopermissions' user can't see stuff they shouldn't.

The current test for how permissions interact with what appears on the sidebar only verifies that users without permissions can see what they should see. i.e. that they can see all the ordinary things like 'Collections', 'Namespaces', 'API Token', etc.
This PR extends that test to verify that users without permissions cannot see things that they shouldn't* see, i.e. that they can't see 'Users', 'Groups', and 'Approval'.

LGTM 👍


fix: deleted second largest.c

because i have moved it in a directory

but you are deleting that directory "second largest.c" file.

i'm not deleting the directory
i am deleting the file
which is without any folder in the codechrf directory

Okay.

This project is now under CrossWoC. If you want to contribute to this project, you can join the this program CrossWoC as a participant.


Update documentation.

A)Code Snippets were added.
B)Properties of the "Liberty" closure were added.
C)Updated .gitignore to ignore files related to Eclipse's projects.

Changes look good. Thanks!


[ Template ] New Bounty

Description
Write here the general description of what the project is about.
Context
If it's useful, explain the context in which this project is inserted
Acceptance criteria
Set clear and verifiable acceptance criteria for the project. If required, split into milestones and split the following Reward section accordingly
Milestone 1

[ ] Acceptance criteria 1
[ ] Acceptance criteria 2

Milestone M

[ ] Acceptance criteria N

Time estimation
If there is a deadline, or a specific requirement for the time required to develop this project, please set it here
Reward
Set the reward for this bounty (in USD). Depending on the Acceptance criteria section, this could be split into milestones.

[ ] Milestone I: X USD
[ ] Milestone II: Y USD
...

Put what you have in https://github.com/iotexproject/halogrants/blob/master/bounties/template.md and let's iterate from there and define the first 3-5 bounties

Closing this issue as it's been replaced by the standard Github issue templates


Branch report analysis implementation

closes #2

Pull Request Test Coverage Report for Build 274446651

48 of 83 (57.83%)  changed or added relevant lines in 10 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+5.6%) to 37.395%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

cmd/flag.go
0
1
0.0%

cmd/search.go
1
2
50.0%

cmd/version.go
0
1
0.0%

net/http/http.go
0
3
0.0%

sonar/sonarrestapi/searchprojects.go
0
5
0.0%

sonar/sonarrestapi/getserverversion.go
0
8
0.0%

cmd/validate.go
6
22
27.27%

Totals

Change from base Build 258519311:
5.6%

Covered Lines:
89

Relevant Lines:
238

💛  - Coveralls


Request: workbox-config.js

Requesting a file icon for workbox config files.
see https://developers.google.com/web/tools/workbox/
Thanks!

Request fulfilled! 😉

You people are Heroes!
On Sun, Mar 18, 2018, 11:45 AM John Gardner<EMAIL_ADDRESS>wrote:

Request fulfilled! 😉
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/file-icons/source/issues/35#issuecomment-373984988,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABZgNJ0r3AdLHGYBvYrzsj-abOefs9THks5tfiyrgaJpZM4Su7qD
.

--
Benny Powers
Licensed Israel Tour Guide
In Israel<PHONE_NUMBER>
In Canada<PHONE_NUMBER>
In the USA<PHONE_NUMBER>
bennypowers.com

It's just me, mate. Haha. 😀And thanks!


Fix "No matching autocommands" error

This PR suppresses "No matching autocommands" message on opening/closing filter window like this.
No matching autocommands: User Ddu:ui:ff:openFilterWindow
No matching autocommands: User Ddu:ui:ff:closeFilterWindow

How to reproduce

vimrc.vim

set nocompatible

set runtimepath^=~/.cache/vim/pack/minpac/opt/denops.vim
set runtimepath^=~/.cache/vim/pack/minpac/opt/ddu.vim
set runtimepath^=~/.cache/vim/pack/minpac/opt/ddu-ui-ff

call ddu#custom#patch_global(#{ ui: 'ff' })

autocmd FileType ddu-ff nnoremap i <Cmd>call ddu#ui#do_action('openFilterWindow')<CR>
autocmd FileType ddu-ff nnoremap q <Cmd>call ddu#ui#do_action('quit')<CR>

nnoremap @ <Cmd>call ddu#start()<CR>

Open Vim with vim -u /path/to/vimrc.vim
Type @ to start ddu.
Type i<CR> to open and close filter window.
Check messages by :mes

Environment

macOS Sonoma
Vim 9.1.429
deno 1.43.5
ddu.vim 8fadcc364c039997b997a7485155944251315c9c
ddu-ui-ff 1cb70c13bc80753184c08b3954fd2e532f0ff0a9

Hmm..., this PR likely reverts this fix: https://github.com/Shougo/ddu-ui-ff/commit/292d97640333d3508ad3377c890ae0ea8227a0e9
Does this PR give some other problems...?

Merged.

Does this PR give some other problems...?

I don't know...

Does this PR give some other problems...?

I don't know...

OK, thank you.


Horrible chat lag when checking if chat messages are passwords

DO NOT REMOVE THIS
Please make sure your issue complies with these guidelines:

[x] Be using PMMP

[x] Make sure the issue hasn't already been reported

[x] Make sure you are on the latest version of PMMP & PiggyAuth

[x] Have a detailed title like "Players are being kicked randomly"

[x] Provide any crash dumps or errors

General

When players chat, there is horrible lag when checking if messages are the password. (Currently removed from PiggyAuth)
Server Software:
 PMMP
Version of PiggyAuth:
 <IP_ADDRESS>
Data Provider:

[x] MySQL
[ ] SQLite

Steps to Reproduce the Issue

Chat a lot

Extra Information

Were in the code is it set to check for passwords?

EventListener

Show me the code were it checks please.

EventListener Line 194

OK let me see

It should work fine

What test server are you using?
1 how are you hosting?
2 how Mitch ram do you have
3 how mutch ram have you used?

it probably the same, since you are querying not via async

That shouldn't be the problem, you can have a server with one player and you can notice it.

@MCPEPIG @Aericio @Thunder33345 hmm can I see a video or a clip of it!?

@MCPEPIG @Thunder33345 @Aericio us there any error or spam in the console?

Me and @MCPEPIG already tested & confirmed this bug... there are no errors.

Confirmed by 3 people on 3 different servers.

Hmm ok

I agree to @Thunder33345 that is has to be done via async. To compare chat message and password it has to be generated a hash, which is almost done extra slow for security reasons.
(https://github.com/MCPEPIG/PiggyAuth/blob/master/src/PiggyAuth/Main.php#L240)
But also via async there would probably be a noticeable delay before it sends the message. I'm really unsure if there is a secure solution for this issue.

just include an option to not check it for now some owners dont really think this is a necessary feature at the price of speed, also how hereauth did it?
and other plugins who does anti share pwd things??

I think other plugins are using weaker hash algorithms so they are more easy to brute-force.
HereAuth and SimpleAuth are using a combination of salted SHA-512 and Whirlpool hash.
PiggyAuth is using BCrypt which is designed to make it hard to brute-force.
You could try reducing the cost value in config.yml which should also reduce the amount of time to compute: https://github.com/MCPEPIG/PiggyAuth/blob/master/resources/config.yml#L166

Is this really only related to chat messages? I'm experiencing a lag spike here when a player uses /login

I believe this is fixed in #76


Adopt v1.20.0 semconv

Per https://github.com/open-telemetry/opentelemetry-specification/releases/tag/v1.20.0
Related to https://github.com/open-telemetry/opentelemetry-go/issues/3988

Duplicates https://github.com/signalfx/splunk-otel-go/issues/2486


Issue in the current architecture

As far as I can see on https://github.com/SimplyVC/panic/blob/master/doc/DESIGN_AND_FEATURES.md and after testing the implementation in our current stack, nothing guarantee that the Validator doesn't have an issue or is still running while receiving Node Monitor status.

The node monitor deals with exactly one node, such that multiple node monitors are started up if you set up the alerter with multiple nodes. In a typical monitoring round, the node monitor:

1. Checks if the node is reachable from [RPC_URL]
2. Gets the node's status from [RPC_URL]/status
-Gets and stores the voting power
-Gets and stores the catching-up status
3. Gets the node's net info from [RPC_URL]/net_info
- Gets and stores the number of peers
4. Saves its state and the node's state
5. Sleeps until the next monitoring round

At each step, the network monitor goes through the data sources and picks the first full node that responds ([RPC_URL]/health). Having additional full nodes increases data source redundancy.

The issue is that the current design doesn't check if the information received is effectively being sent by the Cosmos validator. It could be cached data, wrong RPC calls, stuck in loop etc.
The node should at least compare fetched Validator state information with previous state. For example, if block number < previous block number, UTC time < previous UTC time etc then triggers error. Ideally, the information received by the node monitor should be signed by the validator and then verified by the node monitor, so that the node monitor can always be ensured that the validator is running fine.

Hi @bneiluj, thank you for opening the issue and for your interest in P.A.N.I.C.
From a Telegram status point of view, the /status command is meant to show that the monitors are still running. The /status command does not guarantee that the validator itself is still running; this is handled by the alerting part of P.A.N.I.C.
From an alerting standpoint, the node monitor does depend on the RPC calls providing reliable information. The node monitor does compare fetched validator state with previous state; this is how P.A.N.I.C. is able to let you know that the number of peers has decreased, for example. However, I do like the idea of comparing UTC time < previous UTC time as an extra alert, and the idea of signing the information; these could be great additions to P.A.N.I.C.
I would appreciate if you could elaborate on the three examples of incorrect data (cached data, wrong RPC calls, stuck in loop). As for cached data, from a Python point of view, the get requests being done do not use caching by default. Not exactly sure what is meant by wrong RPC calls. And as for getting stuck in loops, the get requests have timeouts set up, which if exceeded trigger an alert that delays are being experienced and subsequently that the node is offline.
In all of this, it is important to note the role of the network monitor, which uses an auxiliary node or set of nodes (i.e. excluding the validator itself) to make sure that, at the very least, the validator is not missing blocks. It does this by checking every height for the validator's precommit.

Thanks for your quick reply.
I understand how P.A.N.I.C is built and really like it. Let's look at an architecture point of view - without digging into the code or the different internal modules. Considering that P.A.N.I.C is a black box and that black box communicates with the Validator to fetch state information. The Black Box (P.A.N.I.C) also communicates with a telegram box to send and receive user information. To verify that the entire communication between  Telegram <-> P.A.N.I.C <-> Validator is running without any problem, the information received by the P.A.N.I.C node and at the end (Telegram) needs to be tampered proof by an intrinsic value coming from the Validator. Doing so it guarantees that the Validator hasn't been hacked, it's still running and the data doesn't come from fake data being pushed by the P.A.N.I.C node.

Yes, no worries Miguel. But my previous points were not so much about "hacks in mind" but rather about a broken flow in the current architecture implementation.
For example, basic scenario:

For some reasons, the Monitor goes offline / down
Right after that, the Validator goes offline / down

In the above scenario, the Telegram bot will receive no error messages even if the Validator is down since the Monitor responsible for the logging is down!
So, one of the major flaw in the current architecture is "If Validator fine then no messages on telegram bot". This statement is justified even if the Monitor instance goes down (or has a communication issue) first and then everything can happen. This issue can be fixed by implementing a regular status update (~2h or something like that) from the monitor to the telegram bot.
If you can't guarantee that the Monitor is running to catch errors then you are never 100% sure that the Validator is running fine, which makes the entire mission obsolete.

Your ideas are greatly appreciated Julien. What you are saying is accurate and correct. We can definitely put in an optional status update as a sign that the monitoring is still running.
With the current version of P.A.N.I.C, one can also greatly reduce the chance of the described scenario happening by running multiple instances in different geographical locations. Alternatively, the latest updates from each monitor can be queried from Redis (programmatically) and checked as a form of monitoring of P.A.N.I.C. We also recommend that P.A.N.I.C. is set up as a Linux service, to further reduce the possibility of P.A.N.I.C. being offline.


lazyload bug

This is a (multiple allowed):

[ ] bug

Swiper Version:3.4.0

Platform/Target and Browser Versions: windows chrome

when i use lazyload  slidesPerColumn=2,the lazyload broken.
P.S. Remember, an issue is not the place to ask questions. You can use Stack Overflow
for that.
lazy-load.js
i changed   tow line --s.params.slidesPerView*s.params.slidesPerColumn
Then it works:-)
![Uploading image.png…]()
    var spv = s.params.slidesPerView*s.params.slidesPerColumn;
                        var maxIndex = Math.min(s.activeIndex*s.params.slidesPerColumn + spv + Math.max(amount, spv), s.slides.length);

Plz review the codes

Issue is closed because of outdated/irrelevant/not actual/needed more information/inactivity.
If this issue is still actual and reproducible for latest version of Swiper, please create new issue and fill the issue template correctly:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with issue


Add missing Google Play Services dependency notations

They are all referenced here: https://developers.google.com/android/guides/setup

@LouisCAD Working on this, I'll create a draft PR shortly.


multi domain fail

Hi,
dkim_domains:
- example.com
- example.org
i'm trying to setup 4 domains by your example , but ansible generate only first one, and there  creates default.private and default.txt
shouldn't it be ?
/etc/opendkim/keys:
domain1/  default.private and default.txt
domain2/ default.private and default.txt

It is one key for all domains.

In a future release, we can probably make an option to generate separate keys for each domain.


Support for comparing functions

We are using react-fast-compare and I need to compare functions in react when they are used as props. I have created PR to the react-fast-compare repository. They referenced me to try to get the change implemented here.
Are you open for PR implementing function comparison?
Original commit.
https://github.com/marcelmokos/react-fast-compare/commit/887600a03fef8e93779f06c78367b8ee8dd5ebb4

Functions are compared by reference, as they should be - the test is here:
https://github.com/epoberezkin/fast-deep-equal/blob/master/spec/tests.js#L331


Prototype: support for symbolic Shaped

Discussion: https://github.com/quantumlib/Qualtran/issues/801

@mpharrigan @tanujkhattar could you take a look at this?