Add table aws_organizations_service_control_policy. closes #1561

Integration test logs

Logs
N/A

Example query results

Results
> select
  name,
  id,
  content ->> 'Version' as policy_version,
  content ->> 'Statement' as policy_statement
from
  aws_organizations_service_control_policy
where
  type = 'SERVICE_CONTROL_POLICY';
+---------------+-----------------+----------------+-------------------------------------------------------+
| name          | id              | policy_version | policy_statement                                      |
+---------------+-----------------+----------------+-------------------------------------------------------+
| FullAWSAccess | p-FullAWSAccess | 2012-10-17     | [{"Action": "*", "Effect": "Allow", "Resource": "*"}] |
+---------------+-----------------+----------------+-------------------------------------------------------+

> select * from aws_organizations_service_control_policy where type = 'SERVICE_CONTROL_POLICY'
+---------------+-----------------+--------------------------------------------------------------------------+------------------------+-------------+----------------------------------+----------------------------+---------------+---------------------------------------->
| name          | id              | arn                                                                      | type                   | aws_managed | description                      | content                    | title         | akas                                   >
+---------------+-----------------+--------------------------------------------------------------------------+------------------------+-------------+----------------------------------+----------------------------+---------------+---------------------------------------->
| FullAWSAccess | p-FullAWSAccess | arn:aws:organizations::aws:policy/service_control_policy/p-FullAWSAccess | SERVICE_CONTROL_POLICY | true        | Allows access to every operation | {                          | FullAWSAccess | ["arn:aws:organizations::aws:policy/ser>
|               |                 |                                                                          |                        |             |                                  |   "Version": "2012-10-17", |               |                                        >
|               |                 |                                                                          |                        |             |                                  |   "Statement": [           |               |                                        >
|               |                 |                                                                          |                        |             |                                  |     {                      |               |                                        >
|               |                 |                                                                          |                        |             |                                  |       "Effect": "Allow",   |               |                                        >
|               |                 |                                                                          |                        |             |                                  |       "Action": "*",       |               |                                        >
|               |                 |                                                                          |                        |             |                                  |       "Resource": "*"      |               |                                        >
|               |                 |                                                                          |                        |             |                                  |     }                      |               |                                        >
|               |                 |                                                                          |                        |             |                                  |   ]                        |               |                                        >
|               |                 |                                                                          |                        |             |                                  | }                          |               |                                        >
+---------------+-----------------+--------------------------------------------------------------------------+------------------------+-------------+----------------------------------+----------------------------+---------------+---------------------------------------->

@ParthaI @karanpopat  should we not add a canonical policy content column?

@misraved have added the column policy_std.

@karanpopat I don't see a policy_std column, has it been added?

@ParthaI @karanpopat For the design of this table, I feel we could implement the following:

This table should be named as aws_organizations_policy, per https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/organizations_policy.
Instead of using type as a KeyColumn, we should add it as an optional qual. This should be documented in the table docs page. Reference - https://docs.aws.amazon.com/organizations/latest/APIReference/API_ListPolicies.html
When we keep the content column as JSON, note that as per the response syntax mentioned in https://docs.aws.amazon.com/organizations/latest/APIReference/API_Policy.html#organizations-Type-Policy-Content, are we able to query it? Should the column be named as policy to maintain consistency across all the tables?
For canonicalizing the policy content, we should add another column policy_std so that the contents of the policy can be queried easily. Please refer https://github.com/turbot/steampipe-plugin-aws/blob/main/aws/table_aws_ecr_repository.go#L125 for more information

@misraved I have updated the table as per this comment, here is an update

Updated the table name to aws_organizations_policy as per the terraform doc.
As per the API the Policy Type is a required parameter so we can not use the type column as optional quals in list config we must need to pass the policy type value before making API call.
The column content does not provide the whole policy structure, It contains only policy version and policy statement of the policy. I do not think we should rename the column name to policy.
In other tables we are getting the policy as a json string and we are converting it to a canonical form for easier searching (https://github.com/turbot/steampipe-plugin-aws/blob/main/aws/table_aws_ecr_repository.go#L125 ). In this table we have everything is in a structural form should we add as separate column(policy_std)?


add functions for ROS2 graph introspection

Adding graph function:

rcl_count_publishers
rcl_count_subscribers
rcl_get_node_names
rcl_get_node_names_with_enclaves
rcl_get_publisher_names_and_types_by_node
rcl_get_publishers_info_by_topic
rcl_get_subscriber_names_and_types_by_node
rcl_get_subscriptions_info_by_topic
rcl_get_topic_names_and_types

On NIF layer:

rcl_wait_for_publishers
rcl_wait_for_subscribers

Regarding the wait operations, I not so sure how to integrate them best.
Is the Node a good place for the other functions? These are short running, so it shouldn't be required to run them in a dedicated process.

@FelixPe sorry for our late reply.
Because of the end of the fiscal year and the beginning of the fiscal year in Japan, we are all so busy with our various work. So it is difficult to find the time to review your wonderful work properly. Also, there is still some work to be done after the release of v0.10.0.
We hope you understand that it will still take some time for us to review and/or discuss your work.

@takasehideki I understand that you're currently pressed for time and I appreciate all the hard work you and your team are putting in. Here it's the opposite situation: Easter holiday season with some public holidays. I would like to share some of thoses with you. Please do not feel rushed or pressured to review it immediately. I fully support/understand, that the urgency and priority of the v0.10.0 release related remaining tasks is higher and of the fiscal year anyways. I will rebase on the changes that get introduced there.

To add the missing graph functions I will make this a draft. I will try to keep it always in a working state to welcome discussion/evaluation.

I think this PR follows after #313. So I'd like to work on this after #313 has been merged.
ref:
https://github.com/rclex/rclex/pull/313#issuecomment-2067943160

I think this PR follows after #313. So I'd like to work on this after #313 has been merged. ref: #313 (comment)

The support for introspection on clients required the client resource type. I would consider this PR as less important, so it can wait for #313.


Make a try

This is just a try to close a issue.

Good

Duplicate of #4 ok

This is just a try to close a issue.

好啊

This is just a try to close a issue.

好啊

ee

@Happy-Ding 号


Idea: TestScheduler to support marble diagrams for promises

It's annoying to have to fallback to timers and timeouts when testing code that needs to use Promises. Would be good to be able to write
var e1 = promise('---|', 'theResolveValue'); // or ---#

just like we can write
var e1 = cold('---(a|)', {a: 'someValue'});

As a by-product, test execution might get a bit faster.

I'm for it. But would this mean writing our own thennable pseudo-promise?  Or is there a promise  impl we can use that supports schedulers we can shoehorn?

I was hoping a regular virtual time action.execute() to resolve the promise would do the trick. Do you think it's possible?

That's not a bad idea. I like it.

See #745 for the reasons why I'm closing this issue.


core dump when call SetShapeFn in custom op under 2.0

@zh794390558 ,
Thank you for raising the issue, Please provide details about what platform you are using (operating system, architecture). Also include your TensorFlow version. Also, did you compile from source or install a binary?
Make sure you also include the exact command if possible to produce the output included in your test case. If you are unclear what to include see the issue template displayed in the Github new issue template.
We ask for this in the issue submission template, because it is really difficult to help without that information. Thanks!

@oanush ,
System information

OS Platform and Distribution : centOS 7.6
TensorFlow installed from (source or binary): binary
TensorFlow version (or github SHA if from source): tf2.0.0
-GCC version: gcc (GCC) 4.8.5
-test env:  import tensorflow as tf
from tensorflow.python.framework.ops import disable_eager_execution
disable_eager_execution()

SetShapeFn Code
Status AddRNAShapeFn(InferenceContext* c) {
ShapeHandle input_data;
TF_RETURN_IF_ERROR(c->WithRank(c->input(0), 1, &input_data));
int wav_len = c->Value(c->Dim(input_data, 0));
bool  if_add_rir;
TF_RETURN_IF_ERROR(c->GetAttr("if_add_rir", &if_add_rir));
c->set_output(0, c->Vector(wav_len));
return Status::OK();
}
**Error log **
tensorflow::shape_inference::InferenceContext::WithRank(tensorflow::shape_inference::ShapeHandle, long long, tensorflow::shape_inference::ShapeHandle*)
std::_Function_handler<tensorflow::Status (tensorflow::shape_inference::InferenceContext*), tensorflow::Status (*)(tensorflow::shape_inference::InferenceContext*)>::_M_invoke(std::_Any_data const&, tensorflow::shape_inference::InferenceContext*)
tensorflow::shape_inference::InferenceContext::Run(std::function<tensorflow::Status (tensorflow::shape_inference::InferenceContext*)> const&)
tensorflow::ShapeRefiner::RunShapeFn(tensorflow::Node const*, tensorflow::OpRegistrationData const*, tensorflow::ExtendedInferenceContext*)
tensorflow::ShapeRefiner::AddNode(tensorflow::Node const*)

--

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue?

@zh794390558
Can you please provide data in the standard template ? also should the same description be considered posted by @aishinchi ? Thanks!

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!


A default picture must be present if the image is not rendered.

Describe the bug
A default picture must be present if the image is not rendered.
Screenshots

Yes, that's a good suggestion. Do you want me to work on this, @aashay28 ?

It's fine, you can assign it to me.

Hello, I can do it as my first good issue! please assign it to me.

@masoudhsd there are still many good first issue,that you can contribute to

@JasonDsouza212 Please verify the changes.


Fix Angular "bug" whereby anchor tags don't work over slow connections

Fix issue reported in https://github.com/cloudfoundry/cli-plugin-repo/pull/279#issuecomment-462459606
Fix is to remove Angular.

@willmurphyscode - this PR should fix the Angular issue.

Hi @aeijdenberg, thanks for this work! I left some suggestions for minor fixes to the test assertions, but overall I like the direction.
We're still discussing the general approach as a team, and I want to make sure I'm not alone on the team on liking it before I merge it. You can see my thoughts here if you're curious: https://www.pivotaltracker.com/story/show/163893342/comments/199531284
My big assumption here was that you removed rata because it was hard to hook in Go templating with it?
It'd be nice to have a little more description in the commit message itself. Yes, this change will technically fix the anchor tags, but the bigger point is that we're replacing Angular with Go templating and rendering the list on the server instead of in the browser. At the moment that feels just like a small footnote instead of the main point.

@jenspinney - yes removed Angular because it seemed easier to simply remove than add more Angular to restore functionality that basic HTML has supported for over 20 years!
Removed rata because I spent maybe an hour mucking around trying to get it to work with an additional route to handle the templating without luck. Given that this is essentially a single page app, it seems unnecessary to need to use another 3rd party framework to handle routing.
I also noticed that components.css is over 1MB - Chrome seems to think that about 95% of that code is unused, but I was unable to easily make a smaller version of that - but that might be an interesting project for someone else to take on if they wish to reduce page load time.
Up to your team if you merge it or look for other approaches. My feedback would be for a small app, and one that's maintained on a somewhat part-time basis (as implied by the call to help), then the less 3rd party libraries used the better - less code, less to patch, lower bar to entry for new contributors.

Makes sense, and I'll chat with the team tomorrow about it. Thanks again for the contribution!

@aeijdenberg Thank you so much for doing this extra work! It should be deployed momentarily.


VERSION variable in root

Currently every package has its own version number. We decided to release on GitHub with a protected tag v* and use the same version in all NPM packages to avoid confusion and enforce consistency.

[ ] add the version number to a VERSION file in the root directory and use a variable in all places where the version is used

This tool seems to be a good way on how to solve it: https://github.com/jscutlery/semver


Deprecation of 'spectral' colormap in matplotlib

Several plots in the metrics package trigger the matplotlib deprecation warning as they use the 'spectral' colormap by default.
skplt.metrics.plot_roc_curve(y_train, y_probas)

MatplotlibDeprecationWarning: The spectral and spectral_r colormap was deprecated in version 2.0.
Use nipy_spectral and nipy_spectral_r instead.

Needs to be changed to 'nipy_spectral'

Fixed by #66


ak.argcartesian with nested = True doesn't broadcast like nested = False

Let a and b be some jagged arrays of same outer (axis = 0) lengths.
It is possible to do:
index = ak.argcartesian({"x": a, "y": b}, axis = 1, nested = False)
x       = a[index['x']]
y       = b[index['y']]

However, it would also be nice to have this working with nested = True
At the moment, this results in:
ValueError: too many jagged slice dimensions for array

This is motivated by the idea of having some a1, a2 and a3 that are identical in shape, only different in values. And having some b1, b2 and b3 that are also identical in shape (but different from the a ones), only different in values.
I need:
a1_b1 = ak.cartesian({"x": a1, "y": b1}, axis = 1, nested = True)
x1    = a1_b1['x']
y1    = a1_b1['y']
a2_b2 = ak.cartesian({"x": a2, "y": b2}, axis = 1, nested = True)
x2    = a2_b2['x']
y2    = a2_b2['y']
a3_b3 = ak.cartesian({"x": a3, "y": b3}, axis = 1, nested = True)
x3    = a3_b3['x']
y3    = a3_b3['y']

That works but seems slow and I hope to be faster by doing:
index = ak.argcartesian({"x": a1, "y": b1}, axis = 1, nested = True)
x1 = a1[index['x']]
y1 = b1[index['y']]
x2 = a2[index['x']]
y2 = b2[index['y']]
x3 = a3[index['x']]
y3 = b3[index['y']]

Which doesn't work (for me).

This doesn't work for nested=True because of what nested=True means:
>>> a = ak.Array([[1, 2, 3], [], [4, 5]])
>>> b = ak.Array([["a", "b"], ["c"], ["d", "e"]])
>>> index1 = ak.argcartesian({"x": a, "y": b}, nested=False)
>>> index2 = ak.argcartesian({"x": a, "y": b}, nested=True)
>>> index1.tolist()
[[{'x': 0, 'y': 0},
  {'x': 0, 'y': 1},
  {'x': 1, 'y': 0},
  {'x': 1, 'y': 1},
  {'x': 2, 'y': 0},
  {'x': 2, 'y': 1}],
 [],
 [{'x': 0, 'y': 0},
  {'x': 0, 'y': 1},
  {'x': 1, 'y': 0},
  {'x': 1, 'y': 1}]]
>>> index2.tolist()
[[[{'x': 0, 'y': 0}, {'x': 0, 'y': 1}],
  [{'x': 1, 'y': 0}, {'x': 1, 'y': 1}],
  [{'x': 2, 'y': 0}, {'x': 2, 'y': 1}]],
 [],
 [[{'x': 0, 'y': 0}, {'x': 0, 'y': 1}],
  [{'x': 1, 'y': 0}, {'x': 1, 'y': 1}]]]
>>> index1["x"].tolist()
[[0, 0, 1, 1, 2, 2], [], [0, 0, 1, 1]]
>>> index2["x"].tolist()
[[[0, 0], [1, 1], [2, 2]], [], [[0, 0], [1, 1]]]

index2["x"] doesn't have the same "shape" (in an extended-beyond-NumPy sense) as a. We could explicitly broadcast a to get the same shape:
>>> ak.broadcast_arrays(a, index2["x"])[0].tolist()
[[[1, 1], [2, 2], [3, 3]], [], [[4, 4], [5, 5]]]
>>> ak.broadcast_arrays(a, index2["x"])[0].tolist()
[[[1, 1], [2, 2], [3, 3]], [], [[4, 4], [5, 5]]]
>>> index2["x"].tolist()
[[[0, 0], [1, 1], [2, 2]], [], [[0, 0], [1, 1]]]

but it still doesn't work:
>>> ak.broadcast_arrays(a, index2["x"])[0][index2["x"]]
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/jpivarski/miniconda3/lib/python3.8/site-packages/awkward/highlevel.py", line 946, in __getitem__
    return ak._util.wrap(self._layout[where], self._behavior)
ValueError: in ListArray64 attempting to get 2, index out of range

because, for example, the 2 in [2, 2] is beyond all the indexes in the corresponding [3, 3] in the broadcasted a (there's only 0 and 1). The indexes refer to positions in the dimension one level higher: we've nested them more deeply than they were intended by broadcasting those arrays.

An easier way to deal with this conceptually, with possibly better performance as well, is to ak.zip all your "a" arrays into one package and all your "b" arrays into another, then do a single ak.cartesian on both groups.
>>> many_a = ak.zip({"a1": a, "a2": a, "a3": a})
>>> many_b = ak.zip({"b1": b, "b2": b, "b3": b})
>>> ak.cartesian({"x": many_a, "y": many_b}).tolist()
[[{'x': {'a1': 1, 'a2': 1, 'a3': 1}, 'y': {'b1': 'a', 'b2': 'a', 'b3': 'a'}},
  {'x': {'a1': 1, 'a2': 1, 'a3': 1}, 'y': {'b1': 'b', 'b2': 'b', 'b3': 'b'}},
  {'x': {'a1': 2, 'a2': 2, 'a3': 2}, 'y': {'b1': 'a', 'b2': 'a', 'b3': 'a'}},
  {'x': {'a1': 2, 'a2': 2, 'a3': 2}, 'y': {'b1': 'b', 'b2': 'b', 'b3': 'b'}},
  {'x': {'a1': 3, 'a2': 3, 'a3': 3}, 'y': {'b1': 'a', 'b2': 'a', 'b3': 'a'}},
  {'x': {'a1': 3, 'a2': 3, 'a3': 3}, 'y': {'b1': 'b', 'b2': 'b', 'b3': 'b'}}],
 [],
 [{'x': {'a1': 4, 'a2': 4, 'a3': 4}, 'y': {'b1': 'd', 'b2': 'd', 'b3': 'd'}},
  {'x': {'a1': 4, 'a2': 4, 'a3': 4}, 'y': {'b1': 'e', 'b2': 'e', 'b3': 'e'}},
  {'x': {'a1': 5, 'a2': 5, 'a3': 5}, 'y': {'b1': 'd', 'b2': 'd', 'b3': 'd'}},
  {'x': {'a1': 5, 'a2': 5, 'a3': 5}, 'y': {'b1': 'e', 'b2': 'e', 'b3': 'e'}}]]

Beyond that, Numba is generally faster than these array-at-a-time functions, though the array-at-a-time functions are generally more convenient. The second thing to try would be Numba.

Thank you for the fast response.
Could this be related to #555 ?

#555 is about adding a way to create new arrays-of-lists. It's something one can already do from the low level (directly manipulating layouts), but it would provide a high-level way to do it, motivated by JaggedArray.fromcounts in Awkward 0.x. I don't personally see the connection to this.
I've relabeled this issue as a question, because I think it was about technique, not new functionality. Zipping all of your arrays would let you do a single ak.cartesian, which might solve your speed problem. If this is a promising avenue, please close the issue. Thanks!

Okay, thank you for the clarification.
Your idea of zipping the 3 arrays works like a charm and is about 5 times faster.
However, a new speed problem arrives:
eta_cross = ak.cartesian({"x": eta, "y": eta}, axis = 1, nested = True)
phi_cross = ak.cartesian({"x": phi, "y": phi}, axis = 1, nested = True)
et_cross  = ak.cartesian({"x": et , "y": et }, axis = 1, nested = True)

The above takes 15s
eta_diff  = eta_cross['y'] - eta_cross['x']
phi_diff  = phi_cross['y'] - phi_cross['x']

The above  takes 1s
Now the new approach:
eta_phi_et = ak.zip({"eta": eta, "phi": phi, "et": et})
eta_phi_et_cross = ak.cartesian({"x": eta_phi_et, "y": eta_phi_et}, axis = 1, nested = True)

The above  takes 3s
eta_phi_et_x, eta_phi_et_y = ak.unzip(eta_phi_et_cross)
eta_x, phi_x, _  = ak.unzip(eta_phi_et_x)
eta_y, phi_y, et = ak.unzip(eta_phi_et_y)

The above  takes almost no time.
eta_diff  = eta_y - eta_x
phi_diff  = phi_y - phi_x

The above suddenly takes 11s
The new approach is faster in crossing but for some reason way slower in calculating the difference, which doens't make sense to me as eta_y and eta_x should be identical to eta_cross['y'] and eta_cross['x']

The trade-off is due to a difference in technique. When computing the Cartesian product (as well as several other operations) of records, we don't descend through every field of the record, computing the Cartesian product of each field. We create an IndexedArray of those records. I'll demonstrate.
For the Caresian product of two record arrays,
>>> one = ak.Array([[{"x": 1}, {"x": 2}, {"x": 3}], [], [{"x": 4}, {"x": 5}]])
>>> two = ak.Array([[{"y": 1}, {"y": 2}], [{"y": 3}], [{"y": 4}, {"y": 5}]])
>>> ak.cartesian([one, two]).tolist()
[[({'x': 1}, {'y': 1}),
  ({'x': 1}, {'y': 2}),
  ({'x': 2}, {'y': 1}),
  ({'x': 2}, {'y': 2}),
  ({'x': 3}, {'y': 1}),
  ({'x': 3}, {'y': 2})],
 [],
 [({'x': 4}, {'y': 4}),
  ({'x': 4}, {'y': 5}),
  ({'x': 5}, {'y': 4}),
  ({'x': 5}, {'y': 5})]]

The result is a ListOffsetArray of RecordArray of IndexedArrays, with the unduplicated data inside the IndexedArrays.
>>> ak.cartesian([one, two]).layout
<ListOffsetArray64>
    <offsets><Index64 i="[0 6 6 10]" offset="0" length="4" at="0x562c068de5d0"/></offsets>
    <content><RecordArray>
        <field index="0">
            <IndexedArray64>
                <index><Index64 i="[0 0 1 1 2 2 3 3 4 4]" offset="0" length="10" at="0x562c06903df0"/></index>
                <content><RecordArray>
                    <field index="0" key="x">
                        <NumpyArray format="l" shape="5" data="1 2 3 4 5" at="0x562c069f74e0"/>
                    </field>
                </RecordArray></content>
            </IndexedArray64>
        </field>
        <field index="1">
            <IndexedArray64>
                <index><Index64 i="[0 1 0 1 0 1 3 4 3 4]" offset="0" length="10" at="0x562c068e3ee0"/></index>
                <content><RecordArray>
                    <field index="0" key="y">
                        <NumpyArray format="l" shape="5" data="1 2 3 4 5" at="0x562c06a3e660"/>
                    </field>
                </RecordArray></content>
            </IndexedArray64>
        </field>
    </RecordArray></content>
</ListOffsetArray64>

The index of the IndexedArray has the duplication for the Cartesian product (0 0 1 1 2 2 3 3 4 4 and 0 1 0 1 0 1 3 4 3 4)—essentially what you were using the argcartesian for earlier—and the data within that are the original 1 2 3 4 5. Whenever you access a field of the new record, it goes through this IndexedArray indirection.
By contrast, if you did a Cartesian product of non-record arrays:
>>> ak.cartesian([ak.Array([[1, 2, 3], [], [4, 5]]), ak.Array([[1, 2], [3], [4, 5]])]).layout
<ListOffsetArray64>
    <offsets><Index64 i="[0 6 6 10]" offset="0" length="4" at="0x562c06a43ef0"/></offsets>
    <content><RecordArray>
        <field index="0">
            <NumpyArray format="l" shape="10" data="1 1 2 2 3 3 4 4 5 5" at="0x562c0688a7d0"/>
        </field>
        <field index="1">
            <NumpyArray format="l" shape="10" data="1 2 1 2 1 2 4 5 4 5" at="0x562c068e3ee0"/>
        </field>
    </RecordArray></content>
</ListOffsetArray64>

there are no IndexedArrays and the innermost NumpyArray data are duplicated.
Adding this IndexedArray layer to most operations with RecordArrays was a performance upgrade this summer: issue #204, PR #261. However, as you point out, it is a tradeoff. If you have records with few fields and frequently access the results (in most or all fields), then you'd rather do ak.cartesian separately and then ak.zip (for no IndexedArray). If you have records with many fields and access the results infrequently or only access a small subset of the results, then you'd rather ak.zip and then ak.cartesian together (to get an IndexedArray).
We were motivated to make the change because (1) many physics records are wide, and a given analysis typically doesn't use all of those fields and (2) it's also fairly common for records to contain VirtualArrays for lazy-reading of data. The IndexedArray indirection not only delays duplication, it also prevents unaccessed fields from being eagerly read. So we were seeing cases in which dozens of fields were "Cartesianed" and then ignored, as well as cases in which fields were unnecessarily read from disk, "Cartesianed," and ignored.
What you're seeing in your examples is just illustrating that you have to pay the price eventually: either up front or upon access. Since you will be using all of the fields of your record, there's not a strong advantage to one case or the other. We could imagine complicating the interface, adding compute-once caches to the IndexedArrays, but there's diminishing returns in that: the array-at-a-time interface is a balance of fast and convenient (at least, faster than Python loops and more convenient than writing a function in Numba). If you really need speed for a given application, you should probably turn to Numba. That avoids the whole intermediate arrays that duplicate the data: a traditional for loop will win on a CPU. (It's not as clear on a GPU, but the GPU implementations are far from ready.) This is the same reason Numba usually beats NumPy.
But this isn't a concession: the ability to mix Awkward Array operations with the occasional Numba-accelerated loop was part of the plan. It enables "non-premature optimization": you try it in Awkward operations because they're the most convenient, then replace just the hot-spots with Numba, leaving everything else intact.


Mark mappings along with root viewmodels - fixes #2574

Description of the pull request:
This adds a step to root model mark that iterates the mappings and marks them as well.
Fixes the following issues:
#2574
Is breaking:
Don't think so.
Reviewers:
Please.

Does that mark call happen on any upstream change from actual children? My concern would be that every change in the component data now causes cascading changes up to all mapped data.
Perhaps it should only be applied in the case of ractive.update() with no keypath specified.

mark only goes downstream at present. Would it be safer to go ahead and just move this to the update method in case that changes in the future?

Ah yes, it goes upstream here. I think it's fine, just wanted to check that we weren't spamming the mappings hierarchy. :)


updatedAt is actually updated_at

Versions

sequelize: 5.22.3
sequelize-typescript: 1.1.0
typescript: 4.1.2

I'm submitting a ...

[ x ] bug report
[ ] feature request
When I try to access to the property updatedAt of an istance of a model it returns undefined, due to the fact that it's actually called updated_at, the problem is that using myIstance.updated_at the linter gives back an error telling me that the property updated_at does not exist for myIstance type, i checked the definitions and it's effectively declared as updatedAt

Perhaps it's because of the naming strategy? It's hard to tell without any code or example.
https://sequelize.org/master/manual/naming-strategies.html

Perhaps it's because of the naming strategy? It's hard to tell without any code or example.
https://sequelize.org/master/manual/naming-strategies.html


merge from template-esm-only

.github/workflows/update_package_lock.yml

chore: (jobs.update_package_lock.steps)
chore: (jobs.update_package_lock.steps)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.334%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1032

Relevant Lines:
1288

💛  - Coveralls


Is the ip_adapter_sdxl_plus-face available for attitude control using t2i?

Is the ip_adapter_sdxl_plus-face available for attitude control using t2i?

For current version, it can't


Add an option to disable inline parsing

Use case
We use EarmarkParser in Livebook to parse (Live)Markdown files, but we only need the AST to analyze the block structure (headings, code snippets) and then render most of it back to Markdown. When the inline content is parsed, some information is lost (for example \ escapes, or emphasis type as in *a _b_ c*), which makes it hard to convert the AST back to Markdown.
Solution
Since we don't analyze the inline content, ideally we wouldn't even parse it and keep as-is in the AST. This PR enables that by setting using a new parse_inline: false option.
This seems to be the minimal change that does the job, but I'm happy to discuss if you have any alternatives in mind!
Example
markdown = """
some \\*escaped\\* content

* item _one_
* item _two_

this *should* stay [unchanged]()
"""

Regular AST
iex> EarmarkParser.as_ast(markdown)
{:ok,
 [
   {"p", [], ["some *escaped* content"], %{}},
   {"ul", [],
    [
      {"li", [], ["item ", {"em", [], ["one"], %{}}], %{}},
      {"li", [], ["item ", {"em", [], ["two"], %{}}], %{}}
    ], %{}},
   {"p", [],
    [
      "this ",
      {"em", [], ["should"], %{}},
      " stay ",
      {"a", [{"href", ""}], ["unchanged"], %{}}
    ], %{}}
 ], []}

AST with inline content intact
iex> EarmarkParser.as_ast(markdown, parse_inline: false)
{:ok,
 [
   {"p", [], ["some \\*escaped\\* content"], %{}},
   {"ul", [],
    [{"li", [], ["item _one_"], %{}}, {"li", [], ["item _two_"], %{}}], %{}},
   {"p", [], ["this *should* stay [unchanged]()"], %{}}
 ], []}

Pull Request Test Coverage Report for Build 288ed586d45825a28b824d1cfd42fcd0959cd628-PR-43

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 73.001%

Totals

Change from base Build 67e2e277d39b40c9cedb0f61833a7785e0967f06:
-0.2%

Covered Lines:
1041

Relevant Lines:
1426

💛  - Coveralls

@jonatanklosko sorry for the late reply need to check my notif settings
@jose pong me (I hereby decalre to ping to be an irregular English verb) and I understand that this is high priority, nevertheless I would appreciate if you had time to add a test.
If you do not I should find some time to do it myself after the merge late today.
I guess you need a release ASAP?
And thank you for helping out!

Hi @RobertDober , thanks for taking a look at this. :heart: There is already a test, do you need something else tested in particular? :)

ok I will check why coverage has gone down later,
Release?

My guess is that it is caused by the struct lines, which cannot be covered. :)

A release sounds great to us! :heart:

Thanks a lot! :cat:

Totally stressed out this morning, of course you added a test! :blush:
Released 1.4.15

yeah too bad, I just invited you as a collaborator

Great, thanks again :heart:


Sof 1001/version mismatch

Codecov Report

Merging #153 (13ddc79) into develop (f605266) will increase coverage by 5.50%.
The diff coverage is n/a.

:exclamation: Current head 13ddc79 differs from pull request most recent head 8ba396b. Consider uploading reports for the commit 8ba396b to get more accurate results

@@             Coverage Diff             @@
##           develop     #153      +/-   ##
===========================================
+ Coverage    69.65%   75.16%   +5.50%
===========================================
  Files          307       94     -213
  Lines        34869    24148   -10721
  Branches      4760     2355    -2405
===========================================
- Hits         24289    18151    -6138
+ Misses       10125     5990    -4135
+ Partials       455        7     -448

Impacted Files
Coverage Δ

meteor/lib/collections/PeripheralDeviceCommands.ts

...eor/server/migration/deprecatedDatabases/1_35_0.ts

meteor/server/api/client.ts

meteor/server/api/buckets.ts

meteor/lib/api/studios.ts

meteor/client/lib/rundownTiming.ts

meteor/lib/collections/BucketAdlibActions.ts

meteor/server/api/showStyles.ts

...eor/server/migration/deprecatedDatabases/0_25_0.ts

meteor/server/security/lib/access.ts

... and 203 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

I think version of the blueprints-integration should also be updated

I think version of the blueprints-integration should also be updated

Yes, if we don't we have test failing

I think version of the blueprints-integration should also be updated

It has been updated.
Apparently systemStatus.test.ts has mocks created that used that versionnumber, so it fails our tests if we don't :p


Move errorkind to consumererror

These errors are specific to the consumer interface.
Fixes https://github.com/open-telemetry/opentelemetry-service/issues/107

@tigrannajaryan any suggestion between consumererror and consumererrors?

any suggestion between consumererror and consumererrors?

No strong opinion. I think either works in this context. Let's go with the shorter one.
Go team does not seem to have strong opinion on this too, although it seems they use mostly singular: https://blog.golang.org/package-names

Codecov Report

Merging #117 into master will not change coverage.
The diff coverage is 20%.

@@          Coverage Diff           @@
##           master    #117   +/-   ##
======================================
  Coverage    69.8%   69.8%
======================================
  Files         101     101
  Lines        6389    6389
======================================
  Hits         4460    4460
  Misses       1695    1695
  Partials      234     234

Impacted Files
Coverage Δ

consumer/consumererror/consumererror.go
100% <ø> (ø)

...lector/app/sender/jaeger_thrift_tchannel_sender.go
0% <0%> (ø)
:arrow_up:

exporter/zipkinexporter/zipkin.go
73.62% <0%> (ø)
:arrow_up:

...occollector/app/sender/jaeger_proto_grpc_sender.go
0% <0%> (ø)
:arrow_up:

...ccollector/app/sender/jaeger_thrift_http_sender.go
0% <0%> (ø)
:arrow_up:

...nal/collector/processor/queued/queued_processor.go
47.61% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5d2503...af9df56. Read the comment docs.


White flicker when slides changes (real iPad/iPhone)

Demo.
I really want to know what caused it.
A CSS property? Device rendering/memory issues?
@nolimits4web

I believe this is a duplicate of #3527, unfortunately. :(

Duplicate of #3527


Clean up miro-sourced Wellcome Images in S3

Part of: #4809
After we've stored all images from miro in the storage service, then we should look at removing the images duplicated in s3 in the following buckets:

wellcomecollection-assets-workingstorage/miro
wellcomecollection-miro-images-public

Timetable:

[x] 15 March – send an email to Collections explaining the buckets are changing, and how to find images in the storage-service
[x] 29 March – send a reminder email
[x] 6 March – disable access to images in the platform account
[x] Delete objects from miro-images-public
[x] Delete objects from wellcomecollection-images
[ ] Delete objects from wellcomecollection-assets-workingstorage

Done!

tl;dr: I think we pause cleaning up the remaining Miro-sourced images from wellcomecollection-assets-workingstorage until we put the Editorial Photography images in the storage service.
Here's a quick summary of the current issue:

We assumed that Miro IDs were globally unique, and that two files with the same ID would refer to the same image. We now know this is wrong. In particular, we have examples from the Editorial_Photography folder where:

The same ID is used for an image at different stages of the process (e.g. one file is a single layer, another file is the complete image)

The same ID is used to describe entirely different photographs

In the latter case, we have examples of images that don't obviously exist anywhere outside wellcomecollection-assets-workingstorage – for example, there's an image labelled C0100987.jp2, but the photo it contains doesn't appear in Tandem Vault, the storage service, or the Editorial Photography backups bucket.

We will lose images if we do a blanket deletion on wellcomecollection-assets-workingstorage.
How many? I don't know; I don't have a good grasp of the scale of the issue. It could be a handful of images, it could be hundreds.
I've deleted the files which are "obviously" safe – that is, files that have another object with matching size, filename and ETag/checksum in wellcomecollection-storage. That leaves ~400k remaining objects to check.

We’d need to do a lot more work to check the remaining images.
A lot (all?) of the remaining images have a counterpart in the wellcomecollection-editorial-photography bucket. We've said something to the tune of "We have a file called C0123456.jpg in the assets bucket, and we can see a file called C0123456.tif in the editorial photography bucket. Those must be the same image, right?". This is no longer a safe assumption.
If we can no longer rely on filename matching, I think we want to look at image diffing (like we did for the Miro/DLCS migration). Pull an image from assets-workingstorage, pull an image from editorial-photography, run an image diff and check the numbers. I'd expect to see 99% matches if they're the same.
Unfortunately, the images in that bucket have all been lifecycled to Glacier. It wouldn't be too expensive to retrieve them (I'd guess ~$50), but it's more work and we have higher priorities.

So here's my proposal: We leave the unmatched Editorial_Photography images in wellcomecollection-assets-workingstorage as is, and we clean them up when we put the Editorial Photography images in the storage service.

There'll be more time to work on this
We can give it our full attention, rather than trying to rush it to round out the quarter
We'll be un-Glaciering all the images in the current editorial-photography bucket when that happens, so it'll be much easier and quicker to do image diffing

Returning to this as a lingering bit of cleanup. I don't know if I'll finish it, but I want to at least get a sense of how much work is involved.
All the Miro objects got sent to Glacier Deep Archive, so we need to restore them first. To do that I need a list of all the objects in an S3 Inventory or CSV, so I've set up an S3 Inventory job in the console for it.

I've kicked off an S3 Batch Operation to restore all the objects from Deep Archive, which should take a day or so to complete.

Okay, so what's left in the old bucket is 419,876 files, taking up ~8TB of data.

An awful lot of what's in here is Editorial Photography, which is spread across the storage service and the wellcomecollection-editorial-photography bucket. The latter is the canonical store of Editorial Photography images; it's managed by Goobi and nicely structured.
The reason they weren't caught last time is because the files aren't exact matches – those files have stored as a mixture of JP2, TIF and JPEG, and you can't just look at Size/ETag to confirm two files are similar. e.g. C0001234.jp2 and C0001234.tif might be the same or they might be different, but unless you download the files you have no way of telling.
I'm now downloading all the files; I've initiated a restore of the relevant objects in wellcomecollection-editorial-photography, and I'm doing visual diff by downloading the images and running them through a Python library – if there's an image in assets with a perfect match, I'm deleting it. It's quite slow, but it's the only way to be sure we aren't losing data.

I've taken a very substantial chunk out of this today, by doing visual diffs of the Editorial Photography images – we're down to 9,764 files, taking up ~300GB of data. For every image I deleted, I can point to an object in wellcomecollection-editorial-photography or wellcomecollection-storage that is a visual match.
What's left are the more "interesting" examples, e.g. irregular filenames like C1234a.tif when all my regexes are only looking for C1234.tif.
Unfortunately at least some of these point to historical errors – we've migrated between TIF and JP2 at various points for editorial photography, and I've already found two corrupted JP2 images in the storage service. The copy in wellcomecollection-assets-workingstorage may be the only "good" copy of these images.
I'll continue to investigate what's in here, but it'll be a slower process to whittle down the remaining images.

Down to 8,227 objects and 234.4GB.

transparency
increase lambda ephemeral storage
increase memory
further loosen name matches

The headline
Having spot-checked those remaining 525, most of the errors fall into three categories:

There's a corrupted image somewhere. There's corruption in both directions – some in the assets bucket, some in the storage service (or sometimes in both). I've found at least once case (C0131243) where the TIF and the JP2 are both corrupted, but the JPEG derivative is fine.
e.g. C0044452.tif in the assets bucket is fine, but C0044452.jp2 in the storage service is corrupted.

The same image ID refers to two completely different things; when you look in the storage service and the assets bucket you find two different images. (I'm now struggling to find an example, but I have seen them.)

The images are the same, but in a more difficult to determine way, e.g. one is a rotated version of the other.

I'm not sure we can do much about the corrupted images until everything gets reingested into METS – putting new Miro images in the storage service is possible, but fiddly; we threw away all the Archivematica code we used for the initial ingest.
I consider this a partial win – we haven't totally solved the problem, but it will be easier to identify the images that need fixing the next time we do some work on the Miro data.

I’m going to use this ticket to provide a brief recap of the Miro images, for anybody who stumbles upon this ticket in future.
Miro was the back-end management system for Wellcome Images, an image library that predates the current Wellcome Collection website and was hosted at wellcomeimages.org (now redirected to wc.org). It was a mixture of images from external contributors and images we'd produced in-house.
The image files were stored on an on-premise network file share, and organised by hand. Everything on this file share was uploaded to an S3 assets bucket before we removed the on-prem storage.
When we shut down Wellcome Images, we sorted the images into three buckets:

Library content – anything we could make publicly available in the new search, under a Creative Commons license. These are the images now available at wellcomecollection.org/search/images.
Private content – images we wanted to keep, but for staff use only. These were stored in Tandem Vault (now MediaGraph), and include a lot of Editorial Photography.
Cold store – images we didn't want to keep or make available, e.g. because they were from an external contributor who never replied to our messages about the closure of Wellcome Images

Most of the images were then copied from the assets bucket to the storage service, grouped based on which bucket they were in. There are also images in the editorial-photography bucket, which is where Goobi keeps all the Editorial Photography images.
We've removed most of what's in the assets bucket, by looking for matching images, which usually means some combination of:

Files are in the permanent storage buckets, i.e. the storage service or editorial-photography
The filenames match or are similar (e.g. C0001234.jp2 and C0001234.tif)
The files have the same size and ETag (which implies identical content), or the images are visually similar enough to be considered equivalent

There are ~500 images in the assets bucket which haven't yet been matched to anything in the permanent storage yet; it's possible that in some cases these are the last copy of a particular image and we don't want to delete them!
Eventually we should clean up all these images and put them in permanent storage, but each of these images will likely need checking by hand.

I'm going to put this ticket back in the backlog for now – although it's not completely done, the smaller image set is much easier to deal with.

Just to further complicate matters, it looks like not all the images in the editorial-photography bucket are safe. 😭
This is one example I found of image corruption: C0125908. On the left is the high-resolution TIF image from the editorial-photography bucket; on the right is the JPEG derivative from the assets bucket.

I was doing some spot checking, and realised we can probably peel off a few more images.
In particular, while I detected corruption in the previous pass, I didn't check where the corruption was. Here's another example: the high-resolution TIFF in the editorial photography bucket is fine, but the JPEG derivative in the assets bucket is corrupted. But that's not an issue for us – we can see they were the same image originally, and the high-resolution copy is fine, so we can delete the corrupted derivative.

Before this pass:

502 objects, totalling 8.9 GB, last modified 18 April

Here's another category of images which are essentially equivalent: the same image, but one of them is rotated differently. I could clean these up automatically, but it's easier to just work through them individually – there can't be many like this.

I reduced it by another 20%:

395 objects, totalling 6.5 GB, last modified 18 April

I've whittled this down to a couple of hundred images, so I'm going to go through what's left and make a spreadsheet of the errors, which we can pass to Collections and/or Production to deal with.


Xamarin.Forms Quickstart and 'Enable offline sync for your Xamarin.Forms mobile app' doc update to v.3.0.1 .NET client SDK

Azure doc link: Enable offline sync for your Xamarin.Forms mobile app

Will need some documentation for shared projects and PCLs with Interfaces or static methods of some sort:
http://motzcod.es/post/150988588867/updating-azure-mobile-sqlitestore-to-30

In progress :-)

Fixed and merged - awaiting publication (within next 24 hours)


Badge: NPM latest package update time

Fixes issue #10023
List of tasks:

[x] Add a service class extending BaseService
[ ] Add query parameter packageVersion
[ ] Write tests

Thanks for working on this, looking forward to it!


Wallet encryption

Add wallet_unlock, a command available during startup to unlock an encrypted wallet

Block wallet startup on successfully being unlocked

This will check the OS keychain for a lbryum password if the wallet is encrypted and the pw isn't provided. This means that if a user has an encrypted wallet and they have the password saved to their keychain, the daemon will start right up without blocking on pw entry. If the password isn't in the keychain, daemon startup gets blocked until it has been provided with the wallet_unlock api command.
There aren't yet any commands to update an existing wallet encryption pw, remove the pw, or add one to an unencrypted wallet (but the functionality is in lbryum).

I'll look this over by tomorrow

Attempting to run wallet_encrypt with use_keyring = False results in this error:
result = g.send(result)

File "/usr/local/lib/python2.7/dist-packages/lbrynet-0.19.0rc15-py2.7.egg/lbrynet/daemon/Daemon.py", line 1307, in jsonrpc_wallet_encrypt
self.session.wallet.encrypt_wallet(new_password)
File "/usr/local/lib/python2.7/dist-packages/lbrynet-0.19.0rc15-py2.7.egg/lbrynet/core/Wallet.py", line 1577, in encrypt_wallet
self._cmd_runner.update_password(new_password, update_keyring)
File "/usr/local/lib/python2.7/dist-packages/lbryum-3.2.0rc4-py2.7.egg/lbryum/commands.py", line 179, in update_password
raise ValueError("no keyring is available to update")
exceptions.ValueError: no keyring is available to update
I think this is a problem on the lbryum side in the command update_password()
The argument update_keyring is by default True, but should probablly be adjusted based on what the conf is set to.

Some more things:
We need to adjust API command settings_set to be able change use_keyring conf so the app has a way of adjusting it. Which brings up some more issue:
Should changing the use_keyring conf set the keyring password? Seems like it should
If  user can turn keyring on and off, there is a potential that the wrong password gets in the keyring (user changes password when keyring is off, turns it back on again). If the keyring password is wrong, then lbrynet needs to catch this problem and allow the user to recover from this problem (needs to at least error out with an information error message).

@kaykurokawa The encrypt_wallet method in the lbrynet side also has an update_keyring parameter which is set to True by default. I guess it would make sense to change it here. See https://github.com/lbryio/lbry/pull/783/files#diff-eafee006192cca2ffbca5ba91dc83eeeR1572

@akinwale we'll also need to make sure keyring is getting packed in the build

The app will also likely need some way of determining whether it should prompt the user for a password or not (whether its prompting to add a password for a wallet that's unencrypted , or prompting for a password on an encrypted wallet without a keyring)
Probably we need to add a new entry in the API command status that tells you whether a wallet is encrypted or not.

Having spent all of 30 seconds thinking about this, I don't think the app cares whether this is returned by status or settings_get

@kaykurokawa @kauffj wallet_is_encrypted is currently returned in the status call.

We need to adjust API command settings_set to be able change use_keyring conf so the app has a way of adjusting it. Which brings up some more issue:
Should changing the use_keyring conf set the keyring password? Seems like it should
Do we add another parameter to settings_set in order to accept the password? I'm guessing that also means that we would need to verify the password parameter is always present if use_keyring is set to true. We would also need to accept an old password (if set) before letting the user set a new password. I think this require some more thought and maybe we should create a new issue for it?

@kaykurokawa @kauffj wallet_is_encrypted is currently returned for the status call.

ah, ok i missed that.

Do we add another parameter to settings_set in order to accept the password? I'm guessing that also means that we would need to verify the password parameter is always present if use_keyring is set to true. We would also need to accept an old password (if set) before letting the user set a new password. I think this require some more thought and maybe we should create a new issue for it?

Yes the issue is a bit complicated, because there's different cases here:
wallet is unencrypted, use_keyring is set to True : nothing happens in this case I guess, or maybe we don't allow this to happen?
wallet is unencrypted, use_keyring is set to False: nothing happens in this case I guess
wallet is encrypted, use_keyring is set to True : password gets sent to the keyring
wallet is encrypted, use_keyring is set to False : do we delete the password from keyring here? not sure
I think adf0201 does not seem quite right to fix the exception I mentioned "exceptions.ValueError: no keyring is available to update". Now the behavior won't be right when you are using the keyring and you want to update the password, because update_keyring is now False. The root of the problem is here in lbryum:
https://github.com/lbryio/lbryum/blob/master/lbryum/commands.py#L169
The function update_password(self, new_password, update_keyring=True) takes an update_keyring argument which is set to default True but the decision to update_keyring should be dependent on whether Command._keyring exists nor not ( if self._keyring is not None: update_keyring = True)

I think adf0201 does not seem quite right to fix the exception I mentioned "exceptions.ValueError: no keyring is available to update". Now the behavior won't be right when you are using the keyring and you want to update the password, because update_keyring is now False. The root of the problem is here in lbryum:
https://github.com/lbryio/lbryum/blob/master/lbryum/commands.py#L169
The function update_password(self, new_password, update_keyring=True) takes an update_keyring argument which is set to default True but the decision to update_keyring should be dependent on whether Command._keyring exists nor not ( if self._keyring is not None: update_keyring = True)

The commit should fix the error that you encountered in your previous test (from the lbry side), since the update_keyring parameter in the lbry daemon previously defaulted to True, and the same parameter is passed on to the command runner's update_password method. I also tested this just to be sure it works.
The reason I raise the ValueError in lbryum is to handle cases where the parameter is set to True, but a valid keyring backend may not have been installed on the system (resulting in self._keyring being None). I believe it was expected for a keyring to always be present before the modifications to make it optional, and I think @jackrobison could provide some insight into what the original reason for having this parameter is.


Subkey: Update output granularity and consistency with UI

Goal is to be as helpful as possible for new users.
Update provides consistency with new user creating an account at PolkadotJS Apps Account page and those creating a new account with Edgeware

On second thoughts I think now may be a bad time to introduce these changes, as they may actually cause confusion for users given that the important Egdeware lock drop starts in a week and they have a blogpost with a screenshot of the existing subkey CLI output https://blog.edgewa.re/edgeware-lockdrop-how-to-participate/

Indeed.


Cfm reset index

Addresses issue where duplicated indices in cutoff_time dataframe results in duplicated rows in the feature matrix with calculate_feature_matrix. Solution is to reset the index in cutoff_time to remove the duplicates.

Codecov Report

Merging #198 into master will increase coverage by 0.08%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #198      +/-   ##
=========================================
+ Coverage   93.21%   93.3%   +0.08%
=========================================
  Files          70      70
  Lines        7727    7734       +7
=========================================
+ Hits         7203    7216      +13
+ Misses        524     518       -6

Impacted Files
Coverage Δ

...computational_backends/calculate_feature_matrix.py
96.98% <100%> (ø)
:arrow_up:

...utational_backend/test_calculate_feature_matrix.py
99.26% <100%> (ø)
:arrow_up:

featuretools/primitives/binary_transform.py
90.75% <0%> (+3.46%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee25b59...72c370d. Read the comment docs.

Looks good. Merging!


fix Serializer bug  - unserializing "numeric like" string

fix bug of Serializer which drop zeros , when unserializing a "numeric like" string within zeros at the beginning
bug like this:
"012345" unserialized as "12345"

Thanks!


How to set the default in the day

Now I have a lot of events (before, on the same day, after the event).I want to make it the default display position how to implement in the day?
thank you！

Now I have a lot of events (before, on the same day, after the event).I want to make it the default display position how to implement in the day?
thank you！


Historical claim values per address

Create an endpoint that returns claimed token amounts per queried address over the past 30days (total dollar value would be nice but not necessary)
watch these transactions:
cxd82fb5d3effecd8c9071a4bba3856ad7222c4b91
- claimRewards

cx10d59e8103ab44635190bd4139dbfd682fa2d07e
- claimRewards

cx203d9cd2a669be67177e997b8948ce2c35caffae
- claimDividends

cx28497aef34ec44ad2be9249daddfbe34b54f309a
- claimBribe

claimBribe might claim different tokens

For this one,
cxd82fb5d3effecd8c9071a4bba3856ad7222c4b91

claimRewards
I only get 4 records

curl -X 'GET' \
  'https://tracker.icon.community/api/v1/transactions?to=cxd82fb5d3effecd8c9071a4bba3856ad7222c4b91&method=claimRewards' \
  -H 'accept: application/json'

Seems like this data is just available via the existing API or am I missing something?
https://tracker.icon.community/api/v1/docs/index.html#/Transactions/get_api_v1_transactions

I don't know where else to get the data except for the tracker, but the point of the issue is to have a single endpoint for total user rewards per month. Is it possible?

So there are 4 contracts, and consolidate that into one endpoint?
Is the tracker data correct though?
If this is just to consolidate the data from what would be 4 API calls, this doesn't seem worth it.

Not burning. Fix the /logs endpoint so I can see if there is a real tracker based way - txs won't get the data

this is iceboxed for now


Refactor DataFrame code for handling null values associated with treatment and infusate

Summary Change Description

Made changes to several methods in "queryset_to_pandas_dataframe.py" for handling null values in the following cases

Animal.treatment_id
Infusate.name
Tracer.name
TracerLabel.name

Modified test code for DataFrames

Simplified code for calling example datasets
Consolidated tests into one class, and reconstructed cases for null tolerance tests.

Affected Issue Numbers

Resolves #585

Code Review Notes

The main change made to DataFrame code is to replace "null" values with a string assigned to null_rpl_str.  I opt to use "None" as it is consistent with web display of null values stored in database.

Modified code for obj_hyperlink filter in customtags to control wrapping of values in lists (e.g. webpages for study, animal, and infusate). The webpages are more user-friendly with such change while the search/filter/download features still work. Could explore other setting for tables using Bootstrap-table plugin to make more improvements in the future.

Checklist

[x] All issue requirements satisfied (or no linked issues)
[x] Linting passes.
[x] Migrations created & committed (or no model changes)
Tests

[x] Tests implemented (or no code changes)
[x] All tests pass
[x] All example load tests pass (remotely) (or their failures predated and are unrelated to this branch)

I wasn't really able to understand what the changes to tests were working to accomplish. Did the prior tests not test every situation? I didn't see anything wrong with them, I just wasn't sure what the updates were.

The short answer is that previous code had a bug with handling null values, and tests didn't cover every scenario.
A long story:
My previous code didn't take into account possible null values for Infusate.name, Tracer.name and TracerLabel.name.
Rob experienced TypeError for displaying data when data were loaded with disable_buffering. He tried to fix the code and added tolerance tests (main changes: setting the values for "id_name_list" fields to empty string).
In fact, the root problem was the output of get_infusate_gb_tracer_df method, which returned an empty DataFrame when performing "groupby" with tracers included null values.  This had chain effects on other DataFrames for infusate list, animal list, and study list (result in unexpected null values for several id_name_list columns).
To fix the bug, I introduced null_rpl_str to replace null values before running "groupby". The differences for data loading with enable/disable buffering are names for Infusate, Tracer, and TracerLabel, while the ID and other data fields are handled in same way. An Animal is always associated with an infusate_id regardless of name value.  Therefore, infusate_id_name_list (or tracer_id_name_list, or concentrations) are not expected to be null or empty string.
In this PR, I also added code to handle null values for treatment, as both id and name are allowed to be null based on Animal model (note: Animal.treatment: null=True; Animal.infusate: null=False; Infusate.name: null=True).
With my current code for bug fixing, some of previous tolerance tests would fail. In addition, previous tests didn't cover how "id_name_list"  (e.g. infusate_id_name_list for unique infusates for a study) values are converted with or without null values. So I added two methods (test_treatment_null, test_infusate_tracer_name_null) to show what values are expected during data conversions from queryset to DataFrame, and from DataFrame to dictionary.

The short answer is that previous code had a bug with handling null values, and tests didn't cover every scenario.
A long story:

Ah, excellent, thanks for the explainer @fkang-pu, makes sense. Go ahead and request a re-review whenever it's ready.

Adding a note before merging this PR into main. I made changes as suggested by @lparsons except keeping the following line in customtags.py:
'/div>
{}',
Tried the code with  tag, but it caused the list of infusates (or tracers) to wrap. My intention was to list one infusate (or tracer) per line on web display. If there are new suggestions or issues related to DataFrame code, I'll address them in a new PR.


Add feature gates for tech preview CSI drivers

Azure Disk and vSphere CSI drivers are introduced in OCP 4.8 as tech preview and we want to have them explicitly enabled behind TechPreviewNoUpgrade FeatureSet.
Note that these are OCP feature gates, observed only by cluster-storage-operator. I checked that kube-controller-manager and other Kubernetes components ignore them and only log "unrecognized feature gate: CSIDriverAzureDisk".

/lgtm
/approve
Recall that you'll need to bump at least the binaries you need to honor this.


Fix regression when using a URL with a query to apply remote build scripts

@bmuschko This restores the old behavior when a URL contains a query.  We do not try to cache these files.

It's sad that we can't cache a script referenced by URL with query string. Could we just say the cache key is the raw URL with the query string?

It's sad that we can't cache a script referenced by URL with query string.

Do we have a rough idea how much effort it would be to implement it?

@bmuschko could you take another look?
I tried to update ExternalResourceName and the related classes to handle query strings, but I think I'd rather keep these changes for 4.3.


Test out iiwa_ros2 for victor

https://github.com/ICube-Robotics/iiwa_ros2
Steps:

[x] Try out the iiwa_ros2 repo instructions

[ ]  ~Get one arm working without the gripper~

So it turns out that using the gripper is actually the tricky part here. Using the iiwa_ros2 java file is really simple, I got it working in the sense that the FRI interface is started and waiting for commands. So some next steps are:

[ ] Finish setting up the C++ FRI ROS2 side of things on the kukacontrol machine
[ ] Calibrate the gripper since the arm still needs to know the mass of the robotiq gripper even though it's not going to be controlling it directly anymore
[ ] Get the robotiq working. This means getting some code on the kukacontrol machine that works and making/using the right cables to connect the X651 port to the kuka control machine + power

I think a next step is to try to modify the controller to control both arms. Some steps (probably there are more)

[ ] start by forking the iiwa_ros2 repo into the armlab org
[ ] make an updated URDF with both arms. Probably start with the new urdf because theirs is very pretty, and just reference our victor.urdf to make a new victor.urdf. For now we can ignore the gripper in the urdf.
[ ] include all 14 joints (this will require renaming them!) here and here
[ ] In IiwaFRIHardwareInterface, create two robotClient_ objects, one for left and one for right, and update the code to handle that. We can just assume a fixed ordering (left then right) in the vectors.

However, the bad news is joint2 on the left arm is now making a crunchy bad noise.

FYI this happened before and we sent the robot back to Kuka for servicing. We had a loaner white kuka iiwa for awhile. I don't remember which arm

abandoning this in favor of just upgrading the stack in-place


TODO: check the operation with mros2 v0.5.0

mROS 2 v0.5.0 is out now!!
https://github.com/mROS-base/mros2/releases/tag/v0.5.0
This release includes additional support for ESP32 family. We do not anticipate any influence on this repository, but we need to check the operation with the latest version of mros2.
Points to be modified:

https://github.com/mROS-base/mros2-mbed/blob/main/mros2.lib#L1

fixed by #41


WPP-89: Add support for alternate Maximized URL.

Add input for maximized URL to configuration page and check update code to use this URL when window state is maximized, if present. This is a completely optional feature.
Did clean up indentation, so please use "git diff -b" to see the actual code changes and ignore spacing changes.

Merged out-of-band.


Set the Time as IST time

How to set the time as timezone as IST time in this library

The picker timezone is set to the user's locations. If you want to use different timezone, you could adjust the date time value from the picker in your own javascript code.

Not possible to set please share the example i want to set the timezone as IST

In Date time picker Default takes a System time . Is there Any possibility to set as IST in the given examples and lib

There is no example about this, because the picker dose not do any timezone setting. It simply returns a native Javascript Date object (if you uses OwnMomentDateTimeModule, it returns MomentJS object). You have to adjust the value coming from picker to your desire timezone.

Yes , I am new  thats why how can i set  IST in OwnMomentDateTimeModule

Hai how to set time zone America .. providers:[{ provide: OWL_DATE_TIME_FORMATS, useValue: MY_NATIVE_FORMATS },
{ provide: OWL_DATE_TIME_LOCALE, useValue: 'en' },
{ provide: OWL_DATE_TIME_FORMATS, useValue: MY_MOMENT_FORMATS },
{ provide: OwlDateTimeIntl, useValue: DefaultIntl },
{ provide: OWL_DATE_TIME_FORMATS, useValue: CUSTOM_DATE_TIME_FORMATS },

Hai


How can I add a link that spans through many resources related to Java/JVM?

I have been gathering a lot of Java-related resources related to AI/ML/DL here:

https://github.com/neomatrix369/awesome-ai-ml-dl/blob/master/details/java-jvm.md#java

and about GraalVM, Wasm, and related tech here

https://github.com/neomatrix369/awesome-graal

So these are not libraries or frameworks or packages but resources that are a collection of a whole lot of things
Would it be okay to add it under Documentation or Miscellaneous or Awesome lists or all of them? Please guide me, as I'll be creating a PR and would be happy to discuss this on it.

Cool

[ ] Cool****


Fix row conversion test

TBA

build

build

re-trigger to get a faster node for premerge. the previous one has a super slow CPU for compiling

build

Sure. Please go ahead.

Done.


use duck-typing to ensure underlying optimizer supports schedulefree hooks

the new duck-typing approach in https://github.com/huggingface/transformers/pull/30079 is causing build failures over there, because of the path through accelerate
/usr/local/lib/python3.10/site-packages/transformers/trainer.py:3448: in training_step
    self.optimizer.train()
/usr/local/lib/python3.10/site-packages/accelerate/optimizer.py:128: in train
    return self.optimizer.train()
E   AttributeError: 'AdamW' object has no attribute 'train'

we need to replicate that logic here, ensuring this code path is safe to call for all optimizers
cc @amyeroberts @muellerzr @winglian https://github.com/huggingface/accelerate/pull/2631

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

friendly ping cc @amyeroberts @muellerzr

IMO this could be confusing to debug and it would be better if there were a dedicated method to check this, like: if optimizer.supports_train_eval_mode() or so. But overall, the proposed solution is also okay.

Agreed - this would be a nicer way to handle!

@BenjaminBossan while that's good, there's the problem of minimum accelerate versions. We can do this, in a follow-up I'll include the supports_train_eval(), and then on the Trainer side we can do some if/else versions until the minimum Trainer requirement is accelerate 1.0+ (since that's probably when that'd be slammed onto)


docs(Menu): Remove duplicated SimpleMenu docs

As pointed out by @dohomi the docs of the SimpleMenu component are duplicated. This PR only leaves one version behind.
The duplication was introduced by the big documentation update.

Beleive it or not, those Readme files are generated. The bug is either

Duplicates in the readme.tsx file
Two components accidentally sharing the same displayName which would be a bug

Didn't know that these are generated. I can't find the duplication in the readme.tsx. 🤔

It might be that MenuSurface is not described in the docs? Or does it has the same props as Menu?

For me it seems like SimpleMenuSurface is replaced with SimpleMenu in the docs.

This was fixed yesterday with some updates to the docs. Had to do with an improper displayName being set on a component.


Add toolCallId to ChatMessage and make it mandatory when using tool messages

Description
Comply with the Mistral AI API and add tool_call_id to ChatMessage.
Issue
Closes #49
Changes Made

add toolCallId with assert to ChatMessage class

Checklist

[x] I have read the CONTRIBUTING.md document.
[x] I have tested my changes.
[x] I have added/updated documentation accordingly.

Everything looks good! The only thing I am wondering is if we should update this test in mistralai_client_dart_base_chat_test.dart:
test(
  'calling chat with all params '
  'should result in sending all params in request body',
  () async {
    final chatJsonParams = jsonDecode(chatCompletionParamsWithAllFieldsBody)
        as Map<String, dynamic>;

    testIfProperBodyParamsAreSent(
      apiJsonResponseBody: chatCompletionResponse,
      clientRequest: (client, bodyParams) =>
          client.chat(chatParamsWithAllFields),
      bodyParams: chatJsonParams,
    );
  },
);

by updating chatCompletionParamsWithAllFieldsBody with toolCallId?

Yeah I missed the place. I'll try to add it there and see if it works.


Changed MVectorFold to VectorFold and VectorFold to IVectorFold

Codecov Report

Merging #12 (2899860) into main (17e7732) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #12   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            4         4
  Lines          136       136
=========================================
  Hits           136       136

Impacted Files
Coverage Δ

src/immutable_vector.jl
100.00% <100.00%> (ø)

src/vector.jl
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17e7732...2899860. Read the comment docs.


Merge copybooks

This PR adds functionality to merge distinct copybooks into a larger one.  It should address the second point in the discussion on https://github.com/AbsaOSS/cobrix/issues/33#issue-402115655, and make it indifferent for a user to provide multiple copybooks or a single aggregated one.
It's currently missing a corresponding option on the spark-cobol module.  Maybe we could allow the copybook option to be comma-separated paths? Or add a copybooks option to explicitly add more copybooks?

The tests are not too useful now besides showing that the feature works (i.e. two copybooks merged look like a single larger copybook).  We can extend the tests later to combine it with a custom record header.

I like the feature and the tests. I think it is great!
Custom record headers is an orthogonal feature so it should work well in combination with merged copybooks. But yes, at some point in time it might be good to have a test that combines merging copybooks and custom record headers.

Looked through the code again and it looks perfect. Merging...

I'm going to take the feature to skip file header and trailing records to implement next week. I'm thinking offsets in bytes from the beginning and at the end of a file representing such records should be provided as an option. Cobrix will then skip that data while reading.

I'd like to play some more with the ANTLR parser before merging. Considering it a part of a major feature release, like 0.6.0.


correct the error handlings in the video device

Updated the changes on comparing the handle with the common marcro DS_ASSERT_AUTO_TERM_NUMERICAL.
Moved the UT_ASSERT_EQUAL into UT_ASSERT_EQUAL_FATAL.
Moved the UT_FAIL into UT_FAIL_FATAL
Corrected few l2 cases for compilation

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Just the sequence of the test number and the test ID may got different as positive and negative are segregated separately here during registrations.
Any idea why we are making DFC and Disable HDR Support into Suite 2 here?


No timeout in watch mode

No timeout in watch mode, which currently times out in 300 seconds.
The following exception is caused by a process timeout
Check https://getcomposer.org/doc/06-config.md#process-timeout for details

In Process.php line 1204:

  The process "asd '--watch' '/work/demo.xml'" exceeded the timeout of 300 se
  conds.

exec [-l|--list] [--] [<binary> [<args>...]]

これはgulpではなくcomposer?

Fixed with #162


MTA-2696: Documentation for multilanguage support

JIRA

MTA-2696

Support for .NET language added
Preview
https://vsodhi.github.io/previews/MTA/MTA-2696.html#_rulesets

@midays - please can you review. thanks


Start.sh unknown command

Remove Sudo from script.


Start Date and End Date not displayed in description summary on stage "Intake in Progress".

#1204 which is about the order of the request description history follows this one

This is fixed.

Reopening due to issues on DEV/TEST and need to retest

Checked again and this bug is fixed.


[stable/janusgraph] change deployment to apps/v1

Fix the error with deployment not being in version v1beta2:
Error: unable to build kubernetes objects from release manifest: unable to recognize "": no matches for kind "Deployment" in version "apps/v1beta2"
Therefore change the apiVersion to "apps/v1".

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @viglesiasce


Can global tern binary be use?

I am on NixOS and neovim.
I have tern available in my development shell (nix-shell).
$ which tern
/nix/store/n8in6vzvpklf1qpnrygz1dpqypqjab4f-node-tern-0.21.0/bin/tern

I get following error in vim when run :TernDoc
Failed to start server:
module.js:471
    throw err;
    ^
Error: Cannot find module '/home/wizzup/.config/nvim/plugged/tern_for_vim/node_modules/tern/bin/tern'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.Module._load (module.js:417:25)
    at Module.runMain (module.js:604:10)
    at run (bootstrap_node.js:389:7)
    at startup (bootstrap_node.js:149:9)
    at bootstrap_node.js:504:3

Press ENTER or type command to continue

Is there any configuration can I set to make use of tern in my $PATH instead of the one in plugin directory so I can have only single tern installation?
This is how I install plugin in $MYVIMRC using vim-plug.
    Plug 'ternjs/tern_for_vim', { 'for': 'javascript' }

If I run tern in another terminal,
$ tern
Listening on port 34195

The error is gone, and completion is working.

You could use somthing like  let g:tern#command = ['node', expand('~').'/lib/tern/bin/tern']
in your .vimrc

solved by let g:tern#command = ['tern']

Sorry to revive this, but you can also do: let g:tern#command = [ '${pkgs.nodePackages.tern}/bin/tern' ] if you don't want to rely on your user environment.


Problems with new module

Sorry if these are simple questions - I'm new to Angular and Webpack.
I've added a new module called dynamics-search to a new fork of this repo.  I've followed the structure of the 'about' module and basically just renamed everything so far to try and create a new 'page' for my new module.

I've also added a route for this new module in app.routes.ts in the same way that the 'about' route is defined.
export const routes: Routes = [     { path: '', redirectTo: 'home', pathMatch: 'full' },     { path: 'about', loadChildren: './about/about.module#AboutModule' },     { path: 'dynamics-search', loadChildren: './dynamics-search/dynamics-search.module#DynamicsSearchModule', } ];
Issues:

Visual Studio is telling me that the Angular module imports are broken with just a 'Cannot find module' error and red squigglies. However, I don't get an error when I build or run the application so is this just Visual Studio being weird?

When I run the app and click the new link that I've added to the navigation, it successfully loads the new module and the page displays as expected. However, if I think refresh the page, I get a 404. The same does not happen for the 'about' page - you get the 'Loading...' message and then the 'about' page is successfully displayed again. I feel like I've just missed something but not sure what.

Thanks

Also, is there a reason compileOnSave and buildOnSave are set to false in tsconfig?

Hey @andyfurniss4 ,

Also, is there a reason compileOnSave and buildOnSave are set to false in tsconfig?

Yes, we did not want to develop with automatic savings :)
Concerning your problem: Have you tried to name the module without the dash?
BR

Yes, we did not want to develop with automatic savings :)

OK, so it's a personal preference rather than for any specific reason? When do you compile your typescript if not on save/build?

Concerning your problem: Have you tried to name the module without the dash?

I will give this a go and let you know. Currently having problems getting my typescript to compile after changing the names of everything.

Have you tried to name the module without the dash?

Still no luck after removing the dash :( - It seems that navigating from the routerLink in the navigation works fine but from anywhere else it fails.
New route config:
{ path: 'dynamicssearch', loadChildren: './dynamicssearch/dynamicssearch.module#DynamicsSearchModule' }
And yeah, I figured it was a VS issue as everything seems to run OK. I'll consider using Code but I can live with it for now I think.

See #56

Thanks @robisim74 - I had missed the new route from the Startup class.
Feel free to close.


AsmJS: SIMD.Bool8x16.extractLane produces a wrong result

SIMD.Bool8x16.extractLane produces a wrong result while extracting "true" values.
Repo cmd:
el_bug.js.txt
function asmModule(stdlib, imports) {
    "use asm";

    var b16 = stdlib.SIMD.Bool8x16;
    var b16extractLane = b16.extractLane;

 function testExtractLane() {

		var b16const = b16(1, 0, 0, 0, 1, 1, 1, 0, 1, 0, 0, 0, 0, 0, 0, 0);
        return b16extractLane(b16const,6)|0;
    }

    return {testExtractLane:testExtractLane};
}

var m = asmModule(this, {});

print(m.testExtractLane());
print(m.testExtractLane());
print(m.testExtractLane());
print(m.testExtractLane());
print(m.testExtractLane());

print("PASS");

ch.exe -asmjs -simdjs -maic:0 -mic:0  el_bug.js

Expected Output:
Successfully compiled asm.js code
1
1
1
1
1
PASS

Actual Output:
Successfully compiled asm.js code
0
0
0
0
0
PASS

We will be submitting the fix shortly.

@dilijev , this is fixed by https://github.com/Microsoft/ChakraCore/pull/826
can you please close it ?

Closed by #826


hourglass-godot: Add version 0.9.4

Closes #11380

[x] I have read the Contributing Guide.

/verify


'kubectl run' example broken

Running kubectl run with -it switch does not work on my machine.
kubectl run -it --rm aks-ssh --image=debian
I updated it to:
kubectl run -i -t --rm aks-ssh --image=debian

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3b81a147-db1c-b92f-88d1-6dd0991a72fe
Version Independent ID: f5a2c949-498f-5848-d89c-031d1a757120
Content: SSH into Azure Kubernetes Service (AKS) cluster nodes
Content Source: articles/aks/ssh.md
Service: container-service
GitHub Login: @iainfoulds
Microsoft Alias: iainfou

@burnsalpine Thanks for your feedback. We are checking on this and will respond to you soon

@burnsalpine Thanks for posting here.
Both the commands should work well.
Where you tried to execute that command?
Also post a screenshot of the error you faced. That will help us to troubleshoot the error.

@burnsalpine is there any update

When I run the command from a windows shell I get this error:
kubectl run -it --rm aks-ssh --image=debian
kubectl : Unable to use a TTY - input is not a terminal or the right kind of file

But it appears to work fine when running from a Linux shell.
The documentation lists -i and -t as separate switches.

@burnsalpine Sorry for the delay. There is no problem with the switches or the order. The problem is that the shell which you are use is not supporting the tty.
I think you are using the command with git bash.
One solution would be using the winpty as per this comment.
Both powershell and command prompt should work well.
Simliar issue: https://github.com/kubernetes/kubernetes/issues/37471

@burnsalpine Did you got a chance to look at the above comment

@burnsalpine I will close this out for now. If you need additional help please let me know and we can reopen and continue.

It's working now after a windows update. Thanks!

This does nto work anymore. Can you please update documentation
kubectl run --generator=deployment/apps.v1 is DEPRECATED and will be removed in a future version. Use kubectl run --generator=run-pod/v1 or kubectl create instead.

@Sudharma That warning is fine. I think you are not getting the prompt.
Can you try pressing enter and see if you are able to see the Prompt to type commands


Show arm info in cpu dimension for LUCI M1 bots

Current M1 bot mac4 and mac5 are showing cpu: x86|x86-64, which doesn't reflect the arm status.
This info should be promoted to make it easy to tell whether a bot is M1. One example:

Mac5 is using an intel-compiled python, which returns incorrect cpu info:
bash-3.2$ /opt/swarming-support/bin/python3
Python 3.8.10+chromium.17 (default, May  5 2021, 18:52:52)
[Clang 12.0.0 (clang-1<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import platform
>>> platform.machine()
'x86_64'

We need to have an arm-compiled python on these M1 bots.

The mac-arm64 should be used.

Tried using arm64 python, but it fails to start the swarming server correctly.
From https://bugs.chromium.org/p/chromium/issues/detail?id=1312295#c7, we need to install pyobjc wheels.
Validated it works locally (mac41 and mac42) by manually installing pyobjc wheels.
The next step is to add these to salt to auto provision all bots. Currently blocked by salt master connection time out.

Arm64 python is being used for swarming server, and cpu info is showing correctly: https://chromium-swarm.appspot.com/botlist?c=id&c=task&c=device_os&c=device_type&c=mac_model&c=machine_type&c=os&c=status&d=asc&f=pool%3Aluci.flutter.staging&f=mac_model%3AMacmini9%2C1&f=device_os%3AiOS-15.1&k=device_os&s=id


remove redis-slave from test, as this is not required for test success. Upgrade redis chart

What this PR does / why we need it:
remove redis-slave from test, as this is not required for test success. Upgrade redis chart
Release note:

remove redis-slave from test, as this is not required for test success. Upgrade redis chart

@schrodit @dguendisch could you also take a look?

Sorry, I missed that additional reviews were pending.


onScrollListener onLoadMore gets triggered automatically without scrolling

The onScrollListenner triggers automatically at the first loading of data into the list.
So the program is busy loading the data from the server into the adapter but the listener keeps triggering load more whenever each new item gets added.
Please don't ask for code

See!

This pattern of infinite page 1 goes until the end!

You might want to play around with the new extension which adds support for the PagedListAdapter
https://github.com/mikepenz/FastAdapter/blob/develop/app/src/main/java/com/mikepenz/fastadapter/app/PagedActivity.kt

You might want to play around with the new extension which adds support for the PagedListAdapter
https://github.com/mikepenz/FastAdapter/blob/develop/app/src/main/java/com/mikepenz/fastadapter/app/PagedActivity.kt

Can you make it more simple?
Provide an example... this is the second day I'm wasting on your library.

I am not using PagedListAdapter at all

Is there any way to fix this without refactoring current code to PagedActivity.kt code?

Is there any way to fix this without refactoring current code to PagedActivity.kt code?
I just want to fix this with EndlessRecyclerOnScrollListener

All you need is love, and don't forget to star this library.


Problems installing lightbi

Thanks for creating the theme, i like it!
However, trying to get it running has been difficult:
I copied your example site/content into /content, but need to copy more to get menus, etc.
How/where do i put the _index.md? Or do i have to let Hugo generate it only?
How do i get search working?
Looked at i18n but was not clear on next steps.
Thanks. Can use hugo discourse or any other means of communication.
<EMAIL_ADDRESS>

Hi,
Thanks for the kind words and sorry for the troubles.
Can you check the full working demo here or my blog which showing the full steps to install this theme.

Hi,
Thank you for responding.
When i downloaded your example website last week, i got the latest version.
My 3 questions above still are not answered in your blog.
If possible, please answer, else i will keep puttering around :)
Thanks in advance

Hi,
You have to copy the hugo.toml in the content to the root folder for menu and other site parameters. Check the latest version, earlier the name was config.toml. I have mentioned the same in the blog under Modify Configuration section.
_index.md is required for every section in you blog like posts, notes, and collections. It is also available in the content folder.
Check here for multilanguages.
Please let me know the above helped or not.

Hi,
I tried on a windows machine from the very first instruction. Got everything setup, including copying the hugo.toml file.
I get this error, which i do not understand:
`> hugo server
Watching for changes in C:\Users\rajesh\Hugo\lightbi{archetypes,assets,content,data,i18n,layouts,static,themes}
Watching for config changes in C:\Users\rajesh\Hugo\lightbi\hugo.toml
Start building sites …
hugo v0.123.1-3f8434a62fc91a50f4e5bd43a4435d2d301844ff+extended windows/amd64 BuildDate=2024-02-21T08:17:45Z VendorInfo=gohugoio
ERROR The "tweet" shortcode requires two named parameters: user and id. See "C:\Users\rajesh\Hugo\lightbi\content\post\2020\jan\rich-content.md:24:1"
WARN  The author key in site configuration is deprecated. Use params.author.email instead.
WARN  The author key in site configuration is deprecated. Use params.author.name instead.
Built in 1139 ms
Error: error building site: logged 1 error(s)`

Hi,
Got everything work, including search, and its great. Now i can work on my content.
Just a couple of issues:

your new theme download still has the tweet author/param problem. I had to download the rich-content.md file separately.
the new theme example has an extra 'content' directory with 'layouts' in it. I had to move the layouts directory one level up and move the files from content/content up one level.
Thank you, hope to release my site in a week.

hey, can someone please help me with my issue? I really really need that theme right now:
https://github.com/binokochumolvarghese/lightbi-hugo/issues/57

Hi,
Happy to hear that it is working. I would love to see your creations and you can share your website link here.


View Audit Logs in Amino

http://service.narvii.com/api/v1/x159192087/s/admin/operation?start=0&size=10
//FOR Moderration Operrations
//maybe a helper function to get permission level

Did the module auditLogs.js, and wrote the example already. This new feature will be added at the 3.0.0-nightly
Closing due to finished


glibc pthread mmap calls are not hooked; break HEAP_PROFILE_MMAP (was: Inconsistent tracking mmap usage)

I am profiling a process starting up process's memory usage. Which creates about 1500 threads so it use much memory in pthread_create, which will call mmap internal.
First time, I profile the process with these environment variables, the profile shows that the leaf node in the graph is pthread_create, which consumes 3 GB memory(When compared with the thread number and the VIRT memory cost, we can see that this value is correct).
HEAP_PROFILE_ONLY_MMAP=1 HEAPPROFILE=x HEAPPROFILESIGNAL=30 HEAP_PROFILE_ALLOCATION_INTERVAL=0 HEAP_PROFILE_INUSE_INTERVAL=0 ./a.out

The second time, with these environment variables, only 500 MB memory usage is captured, which is the same value shows from tcmalloc's stats function, it seems that the mmap profile doesn't work.
HEAP_PROFILE_MMAP=1 HEAPPROFILE=x HEAPPROFILESIGNAL=30 HEAP_PROFILE_ALLOCATION_INTERVAL=0 HEAP_PROFILE_INUSE_INTERVAL=0 ./a.out

From the document we can see that it's fine to profile both mmap and malloc at the same time, is this a bug in my case?

gperftools version: 2.7
os version: RHEL 7.0
gcc version: 4.8.5

deduping this to #1010


escape "" command not executing properly

command = /looker am customer\, inc\.
Returns no results. When drilling into the link, the filter value is being populated with:
customer,inc\.
(missing the space after the comma, and not recognizing the second escape for the period).

This is actually working properly, it's just the wrong advanced syntax.
This command will work:
/looker am "customer, inc."


pfSense OS fails to run post installation setup

Device
Protectli v1210
RTE version
protectli_v1210_v0.9.2-rc4
OSFV version
698a2539e79f59b46f695e5abab986890336e098
Affected component(s) or functionality
No response
Brief summary
pfSense OS installation fails to run post installation setup
How reproducible
Always
How to reproduce
Start psSense OS installation from USB flashdrive.
At the end of the installation a:
efibootmgr: efi_get_variable: Bad address
efibootmgr: efi_get_variable: Bad address
Error: Failed to run the post installation script.```
is displayed.
However after reboot if you boot from the device that the OS was installed to it turns out that OS was installed corectly. Howver the boot entry was not created.

### Expected behavior

Post installation script finishes its run without errors.
Boot entry is correctly created.

### Actual behavior

Post installation script fails
Boot entry is not created.

### Link to screenshots or logs

[install-log.txt](https://github.com/user-attachments/files/16190704/install-log.txt)

### Additional context

_No response_

### Solutions you've tried

Manually added the correct boot entry. And it worked.
Chose to boot from the device that the OS was installed. And it worked too.

I guess it's not related to the test environment, is it? If so, please move to: https://github.com/Dasharo/dasharo-issues/issues


Make some minor tweaks to mysqldump_to_csv.py

Use .startswith(..) in place of the unrolled versions of the
equivalent functionality.
Use if foo: and if not foo: instead of if len(foo) != 0:
and if len(foo) == 0:. The former set of patterns is more
performant and it protects against foo potentially not being
an iterable object, or an object that doesn't implement
.__len__(..).
Change the mode of the script to 0755 so it's executable out of
the box.

Signed-of-by:	Enji Cooper<EMAIL_ADDRESS>

@jamesmishra: ping?