JavaScriptExceptions are caught by foreign ScriptEngines

Hi,
as ObjectInstances etc. have a reference to the ScriptEngine to which they belong, I assume one shouldn't take an ObjectInstance originating from one ScriptEngine and set it as property on another ScriptEngine. Is this correct?
In that case, I think the catch clauses for JavaScriptExceptions need to be adjusted. Currently, it is possible that one ScriptEngine throws a JavaScriptException, and if called recursively by another ScriptEngine, its JavaScript code may catch the exception. If that happens, it probably was unintended that a "foreign" JavaScriptException is catched in JS code.
We use Jurassic for extending an application with JavaScripts, where the transitions on the stack can be Native (.NET) -> JS (event handler or callback which calls a FunctionInstance), JS->Native (Script calls an API) and again Native -> JS (another callback).
Consider this simplified example:
EventProducer:
        class EventProducer
        {
            public event Action MyEvent;

            protected void OnMyEvent() => MyEvent?.Invoke();

            public void Run()
            {
                // Run a script which raises the event.
                string script = @"
try {
    api.raiseEvent();
} catch (e) {
    console.log('e.myGlobalVariable: ' + e.myGlobalVariable);
}
";

                ScriptEngine engine = new ScriptEngine();
                //engine.Compile
                engine.ForceStrictMode = true;
                engine.SetGlobalValue("console", new FirebugConsole(engine));
                engine.SetGlobalValue("api", new Api(engine, this));
                engine.Execute(script);
            }

            private class Api : ObjectInstance
            {
                private EventProducer producer;

                public Api(ScriptEngine engine, EventProducer producer)
                    : base(engine)
                {
                    this.producer = producer;
                    PopulateFunctions();
                }

                [JSFunction(Name = "raiseEvent")]
                public void RaiseEvent()
                {
                    producer.OnMyEvent();
                }
            }
        }

EventConsumer:
       class EventConsumer
        {
            private EventProducer producer;

            public EventConsumer(EventProducer producer)
            {
                this.producer = producer;
            }

            public void Run()
            {
                // Run a script which adds an event handler.
                string script = @"
var myGlobalVariable = 'Hi, this is a global variable.';

(function (globalObject) {
    api.addEventHandler(function () {
        // Throw the global object
        throw globalObject;
    });
})(this);
";

                ScriptEngine engine = new ScriptEngine();
                engine.ForceStrictMode = true;
                engine.SetGlobalValue("console", new FirebugConsole(engine));
                engine.SetGlobalValue("api", new Api(engine, this));
                engine.Execute(script);

            }

            private class Api : ObjectInstance
            {
                private EventConsumer consumer;

                public Api(ScriptEngine engine, EventConsumer consumer)
                    : base(engine)
                {
                    this.consumer = consumer;
                    PopulateFunctions();
                }

                [JSFunction(Name = "addEventHandler")]
                public void AddEventHandler(FunctionInstance instance)
                {
                    consumer.producer.MyEvent += () => instance.Call(null);
                }
            }

Main Program:
            var producer = new EventProducer();
            var consumer = new EventConsumer(producer);

            consumer.Run();
            producer.Run();

In that example, EventProducer has a event which is raised by JS code. EventConsumer runs JS code which adds an event handler to the producer's event, and in that handler, throws a JS object.
Both EventConsumer and EventProducer may not know that each other will also run JS code. However, the JS code in the EventProducer can use a catch clause to catch the JavaScriptException and get access to a foreign ScriptEngine's objects (the global object in that case).
To change this, I think the clauses like catch (JavaScriptException ex) would need to be adjusted to catch (JavaScriptException ex) when (ex.ScriptEngine == this.ScriptEngine) or something similar, if this is possible (e.g. in the TryCatchFinallyStatement class, however I don't know how to do this correctly).
Thank you!

as ObjectInstances etc. have a reference to the ScriptEngine to which they belong, I assume one shouldn't take an ObjectInstance originating from one ScriptEngine and set it as property on another ScriptEngine. Is this correct?

Yes.

To change this, I think the clauses like catch (JavaScriptException ex) would need to be adjusted to catch (JavaScriptException ex) when (ex.ScriptEngine == this.ScriptEngine) or something similar, if this is possible (e.g. in the TryCatchFinallyStatement class, however I don't know how to do this correctly).

Bit of a niche scenario, but I think you're right: that is probably the best solution.

Thanks!
I agree that this is not a common scenario. In our case we host different script engines (running different script code) that call API methods, in which case it is possible that two or more transitions from Native -> JS occur on the stack but use different ScripEngines. However we already catch all exceptions occuring in this steps, so it is currently not a problem for us.

I've checked in a fix for this issue.


Derive Serialize/Deserialize if possible

Motivation
Derive Serialize/Deserialize if possible (with serde dep).
Solution
See diff.
PR Checklist

[ x ] Added Tests
Not needed
[ x ] Added Documentation
Not needed
[ x ] Breaking changes
No

We do not intend these values to be (de)serialized, as they do not correspond to any standard data forma. We aren't really interested in pushing a new standard. For now, all of these types should be in-memory only
Closing as not planned

We do not intend these values to be (de)serialized, as they do not correspond to any standard data forma. We aren't really interested in pushing a new standard. For now, all of these types should be in-memory only
Closing as not planned

I can't understand. It's mostly harmless.

https://github.com/rust-ethereum/ethabi/blob/b1710adc18f5b771d2d2519c87248b1ba9430778/ethabi/src/token/token.rs#L21
Note ethabi also has these. If alloy is intended as an alternative to ethers-rs, it should also enable these derives, no?

For tracking pupose, https://serde.rs/remote-derive.html also doesn't work:
error[E0277]: the trait bound `DynSolValue: Deserialize<'_>` is not satisfied
    --> -:34:15
     |
34   |     pub args: Vec<DynSolValue>
     |               ^^^^^^^^^^^^^^^^ the trait `Deserialize<'_>` is not implemented for `DynSolValue`, which is required by `Vec<DynSolValue>: Deserialize<'_>`
     |
     = help: the following other types implement trait `Deserialize<'de>`:
               <bool as Deserialize<'de>>
               <char as Deserialize<'de>>
               <isize as Deserialize<'de>>
               <i8 as Deserialize<'de>>
               <i16 as Deserialize<'de>>
               <i32 as Deserialize<'de>>
               <i64 as Deserialize<'de>>
               <i128 as Deserialize<'de>>
             and 491 others
     = note: required for `Vec<DynSolValue>` to implement `Deserialize<'_>`


Created a modern UI for Contact page

Created a modern User-Interface for the contact page.
Here is what it looks now.

i would suggest you to fork latest version of the repo and add your changes,  submit button looks ugly please take reference empty cart button add css same way


Fork / move this repo to the vitrivr umbrella

Using the official guide, we should transfer this repo to the vitrivr org. This simplifies access rights, but allows access to things like CI builds etc. for all contributors.

I would very much argue for a transfer and against a fork, it would be clearer this way.

Done!


Unable to add more than one directory in gulp.dest

Hi Team,
I am trying to run jscs using the following code.
var _files = ["main.js", "src/*.js"];
gulp
.src(_files)
.pipe($.jscs(
{
configPath: __dirname+'/../.jscsrc',
esnext: true,
fix: true
}
))
.pipe(gulp.dest(''));
What should I pass in gulp.dest as i have files in two different directories.

Hey @kawaljeetdhesi. Thanks for the question, but you might not get much help on that issue here. I recommend checking out https://www.npmjs.com/package/gulp-jscs.
If all else fails, you can ask in our gitter room: https://gitter.im/jscs-dev/node-jscs

Thank you for your answer. I have asked the question in the gitter room.

What is $.jscs supposed to do? Shouldn't it be just jscs?  Also, you can just shell out to jscs -x with those files. Or use the sublime text plugin JSCS-Formatter.

$.jscs is probably from gulp-load-plugins.
Which is used like var plugins = require('gulp-load-plugins')();, probably named it to $ instead

@hzoo you are right.
@mrjoelkemp "jscs -x " individual works but i am creating a generic gulp task which will run JSCS on all the folders and automatically fix the issues.
and gulp.dest() only accepts one directory.
Is there any other way where i can pass an array of directories?

That's a question for the gulp repo. I'm not sure how to solve your issue,
but it has little to do with jscs it seems.
Sorry we can't be of more assistance. Post your question on Stack Overflow;
you'd have a greater chance of getting help.
On Aug 5, 2015 8:54 AM, "kawaljeetdhesi"<EMAIL_ADDRESS>wrote:

@hzoo https://github.com/hzoo you are right.
@mrjoelkemp https://github.com/mrjoelkemp "jscs -x " individual works
but i am creating a generic gulp task which will run JSCS on all the
folders and automatically fix the issues.
and gulp.dest() only accepts one directory.
Is there any other way where i can pass an array of directories?
—
Reply to this email directly or view it on GitHub
https://github.com/jscs-dev/node-jscs/issues/1598#issuecomment-127988477
.

Thank you @mrjoelkemp for your assistance.


Is it possible to have ReformatOnSave:True for VS plugin saved to source control?

Currently, it appears that the VS plugin saves the ReformatOnSave to the csharpier.json file in the .vs directory. Since this directory is typically excluded from source control, this means that all users must enable ReformatOnSave in their local environment. Additionally, if the .vs directory is deleted (e.g. running git clean on the repo) then the ReformatOnSave setting is lost.
Ideally, I think it would be nice if this setting were part of the .csharpierrc file and could be tracked by source control, thus enabling ReformatOnSave for all users reliably. I have not explored the VS Code plugin, but it should behave in the same manner as I describe.

Moving the setting into .csharpierrc would force it on all users.

Exactly :smile:
What if the settings in .csharpierrc and csharpier.json were hierarchical? If the ReformatOnSave setting is missing or null in .csharpierrc, then the value from csharpier.json is applied. If the setting is not null in .csharpierrc, then it takes precedence. This would also preserve backwards compatibility for everyone that is using the setting from csharpier.json.
The trickiest part would be having the VS UI reflect the correct value depending on what is defined and what isn't.

We have them same need, our developers are jumping between repos with different formatting solutions, so a solution that allows format on save to be turned on at a repo/directory level is ideal.
@belav would you be ok with the solution @DaveNay suggested where a default value can be pulled from the .csharpierrc/.editorconfig and can be overridden using the global and/or solution VS settings?
I am keen to create a PR for this, but it would mean that the config loading code would need to be shared between cli and visualstudio extension.  Also since VSCode already has a great way to do this with workspaces as you mentioned, the options would likely be named something like VsFormatOnSaveDefault.

I don't think it makes sense to add a VS specific setting to the CSharpier configuration files. It adds confusion to the documentation and the UI for the current settings in VS.
As I mentioned above, you can add .vs/[Project]/v17/csharpier.json if you want all team members to have format on save turned on.
The only thing I'd like to do is find a solution that allows the rider setting to be defined system wide.


PerfkitBenchmarker -> Perfkit Benchmarker

For searchability it might help to add a keywords section on the page and add perfkitbenchmarker,  pkb, benchmarking, etc.
This change might cause searchability to go done.  Otherwise it looks good.

Added some keywords and adjusted the copyright to include 2016.


Server-side HTTP API

Is your feature request related to a problem? Please describe.
To start Cadence workflow, you must use Cadence client SDK. Officially supported clients are Golang and Java based. It limits the way on how you can communicate with Cadence server.  Having HTTP based API opens more flexible way to start and control workflows.
I propose to add HTTP API to Cadence server. This will allow start/terminate/etc workflows using any programming language, even scripting languages when you invoke curl request.
Proposed Solution
YARPC gRPC/TChannel over HTTP invocation method
I propose to use YARPC gRPC/TChannel over HTTP invocation method. This has several advantages:

Quite easy to implement, open defined HTTP port
Using YARPC interceptor, config-based list of allowed API methods can be defined
Uses existing, RPC based implementation
IDLs dictates APIs and their parameters

Theoretically, config part could look like this:
rpc:
  frontend:
    http_port: 8899
  http_accept:
      - uber.cadence.api.v1.WorkflowAPI::StartWorkflowExecution
      - uber.cadence.api.v1.WorkflowAPI::TerminateWorkflowExecution

Other possible solutions:
Separate, dedicated HTTP API handler in Cadence server
Along with Thrift and Proto implementations, HTTP/json handler can be implemented.
Pros:

Implementation can be different
Some arguments can be generated on server-side, smaller API surface

Cons:

Need to reimplement API endpoints
Added maintenance is needed
Server redeployment is needed to release fixes

Side-car proxy service
A new application/service can be built to act as a proxy to Cadence server
Pros:

Granular control over list of API endpoints exposed
Some arguments can be generated on server-side, smaller API surface
No need to redeploy Cadence server, can be used for multiple Cadence clusters
Pick your own language
It is possible to hide Cadence server from access behind this proxy

Cons:

Need to track API changes, more maintenance needed.
Side-proxy service is an additional/external deployment with monitoring, logging and alerting needs.

Comment for alternative: if you run an IWF service, you have an HTTP service like that for APIs like terminate, cancel, reset etc
https://github.com/indeedeng/iwf#architecture
https://github.com/indeedeng/iwf-idl/blob/main/iwf.yaml

I like this idea and I think it's a bit overdue. REST was also a popular ask from users. To provide an option for any language, I think we should do this.
I'm okay with the proposed solution. Eventually we might want something more raw as your mentioned in the alternatives.


Dashed Polyline Support?

Dear team,
i'm using native google map, but i'm not able to add Dashed Lines.  please help me on this.

Not supposed

Hi, isnt this supported yet?

I don't think so man. I was used seri map.


textarea-caret: Reduce forced layout reflows.

Forced reflows are reduced after this change but I couldn't find any concrete difference in the time taken to compute this value on multiple samples with and without this patch even after 6x CPU slowdown.
Note that getCaretCoordinates is called in a loop by tippy to get the best placement for the typeahead which doesn't look like can be avoided.

before
after

Merged, thanks @amanagr!


AOT issue

Hello,
i m having the following error when running aot with the latest version:
Failed to read JSON file xxxx/node_modules/ag-grid-ng2/dist/aggrid.module.metadata.json
can you remove the comment you added at the top with the version number?
it makes the json not valid
Cheers

it s actually the case for all the .metadata.json in dist

can your replace in the gulp file
gulp.src('./dist/') =>     gulp.src(['./dist/', '!./dist/**/*.metadata.json'])
?

Additionally, one more trouble while building ng-grid2.
JSON files(*.metadata.json) must be in UTF8.
Reference angular/angular-cli#3970

@ghaiat Fixed in 7.2.2 - thanks for reporting
@EndarValuk - the default charset is utf8 and looking at the metadata files they appear to be utf8 - are you saying they're not?

@seanlandsman updated to 7.2.2 and problem is missing. Perhaps my local npm_packages was messed.
Anyway, TX for fast fix.


kontrol prove hangs while unable to stop the server

Kontrol hangs at the following stage:
[Info] Process request 17 implies
[Info#proxy] ImpliesM (using kore)
INFO 2024-02-16 17:51:57,979 pyk.kore.rpc - Received response from localhost:54420: 17 - implies
INFO 2024-02-16 17:51:58,372 pyk.ktool.kprint - Invoking kore_to_kast
INFO 2024-02-16 17:51:58,380 pyk.ktool.kprint - Invoking kore_to_kast
INFO 2024-02-16 17:51:58,381 pyk.proof.reachability - Subsumed into target node test%OptimismPortalKontrol.test_finalizeWithdrawalTransaction_paused((uint256,address,address,uint256,uint256,bytes),uint256,(bytes32,bytes32,bytes32,bytes32),bytes[]):0: (14, 6)
INFO 2024-02-16 17:51:58,392 pyk.proof.reachability - Wrote proof data for test%OptimismPortalKontrol.test_finalizeWithdrawalTransaction_paused((uint256,address,address,uint256,uint256,bytes),uint256,(bytes32,bytes32,bytes32,bytes32),bytes[]):0: out/proofs/test%OptimismPortalKontrol.test_finalizeWithdrawalTransaction_paused((uint256,address,address,uint256,uint256,bytes),uint256,(bytes32,bytes32,bytes32,bytes32),bytes[]):0/proof.json
INFO 2024-02-16 17:51:58,403 kevm_pyk.utils - Proof status: ProofStatus.PASSED
INFO 2024-02-16 17:51:58,404 pyk.kore.rpc - Stopping KoreServer: :::54420, pid=18702

when running the test shown below using some lemmas. @JuanCoRo suggested that it might happen since the response returned from the backend is too big for pyk to serialize correctly and it just silently crashes the server (I'll attach the bug report for this test once I manage to reproduce an issue and generate it an the same time).
contract OptimismPortalKontrol {
    ...
    OptimismPortal optimismPortal;

    function setUp() public{
        optimismPortal = new OptimismPortal();
    }

    /// @custom:kontrol-length-equals _withdrawalProof: 2,
    /// @custom:kontrol-length-equals _withdrawalProof[]: 32,
    function test_finalizeWithdrawalTransaction_paused(
        Types.WithdrawalTransaction memory _tx,
        uint256 _l2OutputIndex,
        Types.OutputRootProof calldata _outputRootProof,
        bytes[] calldata _withdrawalProof
    )
        external
    {
        optimismPortal.pause();
        vm.expectRevert();
        optimismPortal.proveWithdrawalTransaction(_tx, _l2OutputIndex, _outputRootProof, _withdrawalProof);
    }

contract OptimismPortal  {
    bool paused;

    modifier whenNotPaused() {
        require(paused == false, "OptimismPortal: paused");
        _;
    }

    function pause() external {
        paused = true;
    }

    function proveWithdrawalTransaction(
        Types.WithdrawalTransaction memory _tx,
        uint256 _l2OutputIndex,
        Types.OutputRootProof calldata _outputRootProof,
        bytes[] calldata _withdrawalProof
    )
        external
        whenNotPaused
    {    }

If this is casued by a segfault in the interpreter due to a stack overflow, you can print a stacktrace by enabling faulthandler in __main__.py:
import faulthandler

faulthandler.enable()

Then run the proof from the command line using a single process (propagation of segfaults between interpreters might not work).

Thanks @tothtamas28! Will try to reproduce the issue with faulthandler enabled.

The issue now also manifests on another test (test_double_add_sub_external) that I used to test CSE on (without any lemmas). Based on the console logs, it seems that the server doesn't get stopped after executing setUp:
import "forge-std/Test.sol";

contract ArithmeticCallTest is Test {
    ArithmeticContract arith;

    function setUp() external {
        arith = new ArithmeticContract();
    }

    function test_double_add_sub_external(uint x, uint y, uint z) external {
        uint a = arith.add_sub_external(x, y, z);
        a = arith.add_sub_external(a, y, z);
        assert(a > x);
    }
}

contract ArithmeticContract{
    function add(uint256 x, uint256 y) external pure returns (uint256 z) {
        z = x + y;
    }

    function add_sub_external(uint256 x, uint256 y, uint256 z) external view returns (uint256 res) {
        uint256 sum = this.add(x, y);
        res = sum - z;
    }
}

The execution gets stuck here:
INFO 2024-02-19 22:25:36,666 pyk.kore.rpc - Received response from localhost:65101: 8 - implies
INFO 2024-02-19 22:25:36,699 pyk.ktool.kprint - Invoking kore_to_kast
INFO 2024-02-19 22:25:36,729 pyk.ktool.kprint - Invoking kore_to_kast
INFO 2024-02-19 22:25:36,731 pyk.proof.reachability - Subsumed into target node test%ArithmeticCallTest.setUp():3: (4, 2)
INFO 2024-02-19 22:25:36,743 pyk.proof.reachability - Wrote proof data for test%ArithmeticCallTest.setUp():3: out/proofs/test%ArithmeticCallTest.setUp():3/proof.json
INFO 2024-02-19 22:25:36,779 kevm_pyk.utils - Proof status: ProofStatus.PASSED
INFO 2024-02-19 22:25:36,779 pyk.kore.rpc - Stopping KoreServer: :::65101, pid=23286

Enabling faulthandler didn't add any new output (@JuanCoRo said that he didn't see any new output in his experiments too), so I guess it may not be caused by a stack overflow in the interpreter. I'm attaching the bug report and the proof.json file written for setUp:
no_cse_test_double_add_sub_external.zip
proof.json

As reported by @PetarMax, the following test also hangs consistently after passing:
    function test_symbolic_bytes_length(uint256 l) public {
        vm.assume(0 < l);
        vm.assume(l <= length_limit);
        bytes memory fresh_bytes = kevm.freshBytes(l);
        assertEq(fresh_bytes.length, l);
    }

where
 uint256 constant length_limit = 48;

The issue still appears every now and then but can't be reliably reproduced. @PetarMax can you please remind me if it ended up happening in CI?

I don't think it happened in CI, althought there were some timeouts. Once the CSE tests were moved to their own job, they were passing without problems.

@palinatolmach How worried should we be about this. I realize that this issue is blocked, but without being able to reliably reproduce the issue, this is a bit like looking for a needle in a haystack...

I see it consistently on my Mac these days. As @Tamás Tóth
@.***> said, it's probably a data race of
some kind.
On Mon, Mar 18, 2024 at 3:12 PM yale-vinson @.***>
wrote:

@palinatolmach https://github.com/palinatolmach How worried should we
be about this. I realize that this issue is blocked, but without being able
to reliably reproduce the issue, this is a bit like looking for a needle in
a haystack...
—
Reply to this email directly, view it on GitHub
https://github.com/runtimeverification/kontrol/issues/375#issuecomment-2004179870,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACBFCSQVT5ZTDLBZDWWYUITYY374FAVCNFSM6AAAAABDLYB3SCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBUGE3TSOBXGA
.
You are receiving this because you were mentioned.Message ID:
@.***>

I saw it several times today too. I don't have a solution for it, but I also realised that we'll be doing a workshop some time between April 1-5, and it would be optimal if it didn't show up there.

As suggested by @geo2a and @goodlyrottenapple, some of the things we can try include:

sending a different signal (SIGTERM instead of SIGINT) to kill the server
investigate the difference between the interaction with the server in pyk/KEVM (where the issue hasn't appeared so far) and Kontrol
as a temporary workaround, do not block the execution waiting for the server to get killed (when the server and prove execution hangs, we end up with a zombie process anyway)

I don't think there's a significant difference between KEVM and Kontrol in terms of server interactions, but sending SIGTERM instead of SIGINT fixes the issue locally for me — at least, after a series of hanging servers, it stopped once I switched to SIGTERM in the local checkout. I also understand that @jberthold described some of the reasons for switching to SIGINT here, so alternatively we can also switch to not blocking the execution while the server isn't killed.


IOS sign in error code

Step 2: Describe your environment

Device: IPhone xsmax
OS version:  12.4
SDK version:  5.0.0

Step 3: Describe the problem:
when sign in with  GIDSignIn.sharedInstance()?.signIn()
then cancel
get error like this
Domain=com.google.GIDSignIn Code=-1

Got the same error
mine was from having the wrong URL scheme in the plist ... wich is really weird ..
"Your app is missing support for the following URL schemes: com.googleusercontent.appsxxxxxxxxx"

Same problem. https://github.com/googlesamples/google-services/issues/426 is related.


Support jailer cgroup args

Description of changes: This PR adds support for passing --cgroup args to jailer via the JailerCommandBuilder. It is intended as a slightly simpler alternative to https://github.com/firecracker-microvm/firecracker-go-sdk/pull/493/files which has been rebased on main. This simplified PR does not make any changes to the existing NumaNode configuration; instead, it just adds clarification that WithNumaNode is a shorthand for WithCgroupArgs("cpuset.cpus=...", "cpuset.mems=...")
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thanks! Changes look good to me, will run testing suite and see if I can get another member to review this.


setting video controls to true in android crash the app

Current behavior
App crash
Reproduction steps
1- play a video
2- navigate back
3- play the video again   ===> app crashh !
Platform

Android

Any sample to reproduce? Any version ? Any logs ?

This will help https://www.youtube.com/watch?v=vVI7ZAZq5e0

We have a solution check below
Validate your control boolean value with the source param name
const [videoSource, setVideoSource] = useState(String);
<Video
source={{
uri: file://'${videoSource},
}}
controls={videoSource ? true : false}
/>
try this it will work.....Worked for me...

This worked for me too

This worked for me too


Check failed: max_num_elems > 0 (0 vs. 0)

Describe the bug
I'm trying to execute the preprocessing command on the nerfstudio documentation:
ns-process-data video --data {data_path} --output-dir {output_path} --no_gpu

Using no_gpu flag as I do not have a display. Running these on a EC2 instance. AMD64, 20.04 Ubuntu with CUDA 11.6

But the following error appears:
[12:53:19] 🎉 Done converting video to images.                                                       process_data.py:178
[12:53:47] 🎉 Done downscaling images.                                                               process_data.py:322
           🎉 Done extracting COLMAP features.                                                       process_data.py:363
──────────────────────────────────────────────  💀 💀 💀 ERROR 💀 💀 💀  ───────────────────────────────────────────────
Error running command: colmap vocab_tree_matcher --database_path /home/ubuntu/Datasets/Processed/colmap/database.db
--SiftMatching.use_gpu 0 --VocabTreeMatching.vocab_tree_path /home/ubuntu/.local/share/nerfstudio/vocab_tree.fbow
────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
F20221025 12:53:48.190236 134291 cache.h:132] Check failed: max_num_elems > 0 (0 vs. 0)
*** Check failure stack trace: ***
    @     0x55602e3a7a00  google::LogMessage::SendToLog()
    @     0x55602e3a3f46  google::LogMessage::Flush()
    @     0x55602e3a819f  google::LogMessageFatal::~LogMessageFatal()
    @     0x55602db72bbd  colmap::LRUCache<>::LRUCache()
    @     0x55602db61dd7  colmap::FeatureMatcherCache::Setup()
    @     0x55602db6de96  colmap::VocabTreeFeatureMatcher::Run()
    @     0x55602dcc7ad1  colmap::Thread::RunFunc()
    @     0x7f0c8a74cde4  (unknown)
    @     0x7f0c8a86a609  start_thread
    @     0x7f0c8a544133  clone
    @              (nil)  (unknown)
Aborted (core dumped)

Reproduce
Installed colmap using the vcpkg succesfully. Then, run the command written above to preprocess custom data.
*Expected behavior
I expected colmap to run the preprocessing correctly.
Thanks in advance!

This error typically arrises when COLMAP fails to find poses. It can be cause by a number of issues such as too much motion blur, not enough images, or too many dynamic objects in the scene.

Hi @tancik do you know if nerfstudio has any video without any preprocessing to do the test to make sure that the problem is the video i'm using?
Thanks.

Yep, try giving this video a go - https://drive.google.com/file/d/19zEm-CpOjpVObFzGqrxou5ndBjb_fAui/view?usp=sharing

I guess it could be a problem with the libfreeimage version...? Out of curiosity, what is currently in your output_path directory after running the script?

My output_path is an empty folder created by me, with nothing in it. Once I execute the command ns-process-data the folder fills with the following folders/data:

colmap/ --> where the database.db is created
images/ --> I understand that is the place where the images are saved from each frame
images_2/
....

Ok, that seems to be working as expected. I just wanted to make sure that images existed in the images folder. I'm not really sure how to help at this point, it seems like the issue exists with colmap.

Thanks a lot for your time! I'm closing for now, reopen if someone has the same issue!

Just to clarify, I decided to install COLMAP using the source. And using the same video and the one @tancik provided this error disappeared. It worked fine. I don't know what happened during the vcpkg installation.

I ran into this issue yesterday as well when running a working nerfstudio Docker image on a new host with a different GPU.
For future readers, it's worth clarifying that this issue is a generic problem that means that COLMAP wasn't able to place any images. The actual reason COLMAP failed can vary. You can sometimes get more information by manually running the COLMAP feature extractor from the command line manually and checking the output for errors.  In my case I ran colmap feature_extractor --database_path test.db --image_path ./images --ImageReader.single_camera 1 --ImageReader.camera_model OPENCV  --SiftExtraction.use_gpu 0, and saw that COLMAP wasn't able to access my GPU for some reason.

hello, do you figure it out?


SILGen: make main hidden

The main entry point does not need to be made SILPublic (external linkage,
default visibility, export DLL storage) as it is internal to the application and
will be invoked by the C runtime.  Make it hidden instead (external linkage,
hidden visibility, default DLL storage).

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

Can one of the admins verify this patch?

Wonder if this is still borked?
@swift-ci test

Build failed
Swift Test Linux Platform
Git Sha - e9e3c5bb6d9a53aa52428ace993811f286be5949

Build failed
Swift Test OS X Platform
Git Sha - e9e3c5bb6d9a53aa52428ace993811f286be5949

@swift-ci please test Windows platform

Please update the base branch to main by Oct 5th otherwise the pull request will be closed automatically.

How to change the base branch: (Link)
More detail about the branch update: (Link)


useState within an existing hook (useEffect)

What version of this package are you using?
0.11.1
What problem do you want to solve?
Subscription (event listener / observer) without a hook.. here's the scenario:
Within a React functional component, I have a useEffect hook which performs an expensive operation, then I use the result for a variety of other things, such as in this example of baking a cookie, then eating it:
const CookieComponent = () => {

  useEffect(() => {
    let cookie
    const bakeCookie = async () => cookie = await bake('cookie')
    bakeCookie()

    // this is where I want teaful to watch for activity
    function eatCookie() {
      const [milk] = teafulState.milk()

      if (milk) eat(cookie)

       // I can do this instead: window.addEventListener('milk', () => eat(cookie))
    }
}

I'm trying to use teaful to replace my event bus, however I can't seem to use the subscriptions within a hook, where I currently use listeners.
What do you think is the correct solution to this problem?
Not sure, something like window.addEventListener?
Are you willing to submit a pull request to implement this change?
Yes, if I knew what needed to be done.
Thanks! Great state management tool :)

@jgentes was this solved?

No, but I found an alternate way to get rid of my event emitters. I'm using teaful, just not in the useEffect hook like I mentioned here.


Throw error if no placements, so fallback will work

#111

back atcha @cavis

@cavis back to you! Went the customerror route


requestParams does nothing

I need to add custom parameters to the querystring
Xamarin.Auth -Version <IP_ADDRESS>

i am also stuck with the same issue, if you have found the solution please share

@aandino-dev  do you have an example of how you liked to pass these parameters, compared to how you are using it with out?

this appears to implemented now.  you just need to override OnCreateInitialRequest as detailed here -> https://github.com/xamarin/Xamarin.Auth/issues/134 and here ->
https://github.com/xamarin/Xamarin.Auth/blob/ad7f6d6453506ced0ab3af499a7492f13973e3a3/source/Xamarin.Auth.LinkSource/OAuth2Authenticator.cs#L322


jdt-language-server: Call installlPhase hooks

This makes it easier to customize the derivation via overrides.
This is a follow up to #283304.
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@britter please resolve merge conflict

@kirillrdy done!


Get job status

Add an endpoint to get the status of a job.
Job-related events emitted by the worker should provide a thorough-enough picture to provide this.
Current job-related events:

job/started
job/compilation/started
job/compilation/ended
job/execution/started
job/execution/ended
job/ended

started
compiling
executing
ended


Fix strict language checks

The strict- values are meant to be used via the language key
See https://dart.dev/guides/language/analysis-options

VERY weird things got into this state!

Oh, analyze is failing now. I'll take a look later this morning.

Adding overrides for google_sign_in_web since the check doesn't detect comment-only changes.


Lirc, docker and NUC

Home Assistant release with the issue:
0.90.1
Last working Home Assistant release (if known):
Operating environment (Hass.io/Docker/Windows/etc.):
Docker under NUC with Debian 9
Component/platform:
LIRC:
Description of problem:
I have HA installed in docker in a NUC with Debian 9. I want to use its IR sensor to send commands. I had all this working in a Raspberry PI (without docker) and it was working fine.
I have installed lirc as it is explained at :https://www.home-assistant.io/components/lirc/ 2 but I had the following erros at HA log:
2019-03-23 23:04:30 ERROR (SyncWorker_9) [homeassistant.util.package] Unable to install package python-lirc==1.2.3: Failed building wheel for python-lirc
Command “/usr/local/bin/python -u -c “import setuptools, tokenize;file=’/tmp/pip-install-5g_64r_g/python-lirc/setup.py’;f=getattr(tokenize, ‘open’, open)(file);code=f.read().replace(’\r\n’, ‘\n’);f.close();exec(compile(code, file, ‘exec’))” install --record /tmp/pip-record-9o8pc9dk/install-record.txt --single-version-externally-managed --prefix --compile --user --prefix=” failed with error code 1 in /tmp/pip-install-5g_64r_g/python-lirc/
2019-03-23 23:04:30 ERROR (MainThread) [homeassistant.requirements] Not initializing lirc because could not install requirement python-lirc==1.2.3
2019-03-23 23:04:30 ERROR (MainThread) [homeassistant.setup] Setup failed for lirc: Could not install all requirements.

I have cehcked that IR is working properly outside HA.
Traceback (if applicable):
Additional information:

Please run pip install python-lirc==1.2.3, see what is blocking the installation

Inside de HA docker or in debian system?
I have ran the command in the sustem and I have the same result:
2019-03-25 22:38:04 ERROR (SyncWorker_10) [homeassistant.util.package] Unable to install package python-lirc==1.2.3: Failed building wheel for python-lirc
Command "/usr/local/bin/python -u -c "import setuptools, tokenize;file='/tmp/pip-install-erez6zfw/python-lirc/setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" install --record /tmp/pip-record-pzn7_v10/install-record.txt --single-version-externally-managed --prefix  --compile --user --prefix=" failed with error code 1 in /tmp/pip-install-erez6zfw/python-lirc/
This is my  docker command:
docker run -d
--name="Homeassistant"
--restart=always
--net=host
--device=/dev/lirc0:/dev/lirc0
-v /docker/homeassistant:/config
-v /docker/homeassistant/.lircrc:/.lircrc
-v /etc/localtime:/etc/localtime:ro
-v /docker/homeassistant/.ssh:/root/.ssh
homeassistant/home-assistant:latest

And this is the output if I run it inside docker:
Collecting python-lirc==1.2.3
Using cached https://files.pythonhosted.org/packages/20/37/5614ed0459439a96430e1aac479b6608b51e69ca0bd7d91277517d5895e9/python-lirc-1.2.3.tar.gz
Building wheels for collected packages: python-lirc
Building wheel for python-lirc (setup.py) ... error
Complete output from command /usr/local/bin/python -u -c "import setuptools, tokenize;file='/tmp/pip-install-1i49babh/python-lirc/setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" bdist_wheel -d /tmp/pip-wheel-2t57ls9e --python-tag cp37:
running bdist_wheel
running build
running build_ext
building 'lirc' extension
creating build
creating build/temp.linux-x86_64-3.7
creating build/temp.linux-x86_64-3.7/lirc
gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -I/usr/include/lirc/ -I/usr/local/include/python3.7m -c lirc/lirc.c -o build/temp.linux-x86_64-3.7/lirc/lirc.o
lirc/lirc.c:276:30: fatal error: lirc/lirc_client.h: No such file or directory
#include "lirc/lirc_client.h"
^
compilation terminated.
error: command 'gcc' failed with exit status 1

Failed building wheel for python-lirc
Running setup.py clean for python-lirc
Failed to build python-lirc
Installing collected packages: python-lirc
Running setup.py install for python-lirc ... error
Complete output from command /usr/local/bin/python -u -c "import setuptools, tokenize;file='/tmp/pip-install-1i49babh/python-lirc/setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" install --record /tmp/pip-record-k5g3yxku/install-record.txt --single-version-externally-managed --compile:
running install
running build
running build_ext
building 'lirc' extension
creating build
creating build/temp.linux-x86_64-3.7
creating build/temp.linux-x86_64-3.7/lirc
gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -I/usr/include/lirc/ -I/usr/local/include/python3.7m -c lirc/lirc.c -o build/temp.linux-x86_64-3.7/lirc/lirc.o
lirc/lirc.c:276:30: fatal error: lirc/lirc_client.h: No such file or directory
#include "lirc/lirc_client.h"
^
compilation terminated.
error: command 'gcc' failed with exit status 1
----------------------------------------

Command "/usr/local/bin/python -u -c "import setuptools, tokenize;file='/tmp/pip-install-1i49babh/python-lirc/setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" install --record /tmp/pip-record-k5g3yxku/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /tmp/pip-install-1i49babh/python-lirc/

Inside docker one is we are looking for

Did you followed the installation guide?
https://www.home-assistant.io/components/lirc/#installation
You need install dependency lib sudo apt-get install lirc liblircclient-dev

I followed installatiion guide but II made it outside docker...😰😰

Can this be closed now?

Sorry, but inside the docker the installation doesn´t works, this is the outpup:
Building dependency tree
Reading state information... Done
E: Unable to locate package lirc
E: Unable to locate package liblircclient-dev

@awarecan, do you know if it has been tested lirc component with Home assistant installed in a docker with debian in a nuc.
I have tried to execute apt-get install lirc liblircclient-dev in a fresh HA container and always appear the errors of the previous message.

I don't know. The generic HA container is build from Alpine, you may want to choose another one from
https://github.com/home-assistant/hassio-homeassistant, or build your own one from https://github.com/home-assistant/hassio-base

Thank you. I will study deeper how works Docker and the way to adapt and build my own.
Regards.

Well instead you make your own things, why not make a PR to extend the exists one?

Ok.
I am quite NOOB at docker but I will investigate it. If I get the key, I will ask you how to create a PR to extend existing container.


EVP_MAC API should not allow update calls after final call

This is a split of #13210, for just the EVP_MAC layer, which I think we should fix before 3.0.

@kroeckx can you elaborate on what needs to be done in this task?

no response, marking as inactive, to be closed at the end of 3.4 dev barring further input

Would it be worthwhile having a single issue about enforcing the documented algorithm life cycles (originally introduced by #14522)?

@paulidale in principle that sounds reasonable.  I'm not quite sure where that might fit on the development schedule though.  Do you think such a task would make sense as a community issue (or issues)?

I've no idea.  I'm not sure if the community would take it up or not.
I'd like to take a stab at it but am on other things for the foreseeable future and then it would be very low priority I suspect.

yeah, thats the issue, no one has time for stuff like this.  I'm going to mark this as a community issue for now, just so it stays open.  If someone gets to it, great, if not, we can revisit during a future planning session


operator loops forever when creating a vmagent or a vmalert

Creating this crd triggers a fast never ending loop.
apiVersion: operator.victoriametrics.com/v1beta1
kind: VMAgent
metadata:
  name: testxyz
  namespace: w6-ops
spec:
  remoteWrite:
    - basicAuth:
        password:
          key: password
          name: credentials
        username:
          key: username
          name: credentials
      url: 'https://victoria/api/v1/write'
  replicaCount: 1
  scrapeInterval: 1m

we see theses logs are producing quickly in the operator log :
{"level":"info","ts":1625776400.8874278,"logger":"controllers.VMAgent","msg":"Reconciling","vmagent":"w6-ops/testxyz"}
{"level":"info","ts":1625776400.9768188,"logger":"factory","msg":"creating default clusterrole for vmagent","controller":"vmagent.crud"}
{"level":"info","ts":1625776400.9845016,"logger":"factory","msg":"selected ServiceScrapes","servicescrapes":"w6-ops/vmagent-testxyz","namespace":"w6-ops","vmagent":"testxyz"}
{"level":"info","ts":1625776400.984525,"logger":"factory","msg":"selected PodScrapes","podscrapes":"","namespace":"w6-ops","vmagent":"testxyz"}
{"level":"info","ts":1625776400.9845345,"logger":"factory","msg":"filtering namespaces to select vmProbes from","namespace":"w6-ops","vmagent":"testxyz"}
{"level":"info","ts":1625776400.9845395,"logger":"factory","msg":"selected VMProbes","vmProbes":"","namespace":"w6-ops","vmagent":"testxyz"}
{"level":"info","ts":1625776400.9845507,"logger":"factory","msg":"selected VMNodeScrapes","vmagent":"testxyz","VMNodeScrapes":""}
{"level":"info","ts":1625776400.984558,"logger":"factory","msg":"selected StaticScrapes","staticScrapes":"","namespace":"w6-ops","vmagent":"testxyz"}
{"level":"info","ts":1625776401.002099,"logger":"factory","msg":"updating VMAgent configuration secret skipped, no configuration change"}
{"level":"info","ts":1625776401.0021315,"logger":"factory","msg":"selected PodScrapes","podscrapes":"","namespace":"w6-ops","vmagent":"testxyz"}
{"level":"info","ts":1625776401.0021732,"logger":"factory","msg":"selected ServiceScrapes","servicescrapes":"w6-ops/vmagent-testxyz","namespace":"w6-ops","vmagent":"testxyz"}
{"level":"info","ts":1625776401.0337205,"logger":"factory","msg":"create or update vm agent deploy","controller":"vmagent.crud"}
{"level":"info","ts":1625776401.0385828,"logger":"factory","msg":"vmagent deploy reconciled","controller":"vmagent.crud","vmagent.deploy.name":"vmagent-testxyz","vmagent.deploy.namespace":"w6-ops"}
{"level":"info","ts":1625776401.0431418,"logger":"controllers.VMAgent","msg":"reconciled vmagent","vmagent":"w6-ops/testxyz"}

The operator updates continuously the service account vmagent-testxyz : the last update time follows the wall clock.

$ oc get sa vmagent-testxyz -o yaml
apiVersion: v1
imagePullSecrets:
- name: vmagent-testxyz-dockercfg-sm86c
kind: ServiceAccount
metadata:
  creationTimestamp: "2021-07-08T20:26:54Z"
  finalizers:
  - apps.victoriametrics.com/finalizer
  labels:
    app.kubernetes.io/component: monitoring
    app.kubernetes.io/instance: testxyz
    app.kubernetes.io/name: vmagent
    managed-by: vm-operator
  managedFields:
...
  - apiVersion: v1
    fieldsType: FieldsV1
    fieldsV1:
      f:imagePullSecrets: {}
      f:secrets:
        k:{"name":"vmagent-testxyz-dockercfg-sm86c"}:
          .: {}
          f:name: {}
    manager: openshift-controller-manager
    operation: Update   <<<<###############
    time: "2021-07-08T20:48:23Z"  <<<<############### Follow the wall clock
  name: vmagent-testxyz
  namespace: w6-ops
  ownerReferences:
  - apiVersion: operator.victoriametrics.com/v1beta1
    blockOwnerDeletion: true
    controller: true
    kind: VMAgent
    name: testxyz
    uid: 5937c8f4-44cb-43ff-831b-4d094bef48eb
...

Any ideas how to troubleshooting and help to understand this behavior ?

Can you share your kubernetes version?  It will help to catch an issue.

$ oc version
Client Version: openshift-clients-4.6.0-202006250705.p0-168-g02c110006
Server Version: 4.6.25
Kubernetes Version: v1.19.0+a5a0987

We are currently seeing the same problem with vmsingle and vmagent.
The operator (v0.15.2) seems to be going in a continuous reconcilation loop and gets OOMKilled.
Same openshift/kubernetes version.

Thanks, will investigate it.

We have other clusters with the same version where the operator works fine. We haven't been able to find out which cause the issue.

Fix for serviceAccount endless loop will be included to the next release.
Also, since next release operator will expose /debug/pprof handlers at <IP_ADDRESS>:8435 port. For OOM issue, its would be usefull to collect memory profile with command curl http://localhost:8435/debug/pprof/heap > operator_heap.pprof and share at at issue.

I have just updated our current VM operator to the latest version (v0.16.0) and all works fine.
Thank you for resolving this issue


Feature/timeline

add timeline table

Changes Unknown when pulling 9be9b0f63c23e759b497944a8936fd7295b6d955 on feature/timeline into ** on master**.


Add multipart support for long sms's

Previously on long sms over 160 chars it used to throw SmsManager.RESULT_ERROR_GENERIC_FAILURE
Now you can send super long sms using this library

Need

@geordyvcErasmus is this still maintained ?

@geordyvcErasmus is this still maintained ?

it seems sms_maintained is unmaintained :v

@luanSaid
sms_maintained:
    git:
      url: https://github.com/andreimc/flutter_sms.git

use this


Integration Stopped - Logs suggest it can no longer communicate with BOM API (Have they blocked us?)

Log file
Error setting up entry Lal Lal for bureau_of_meteorology
Traceback (most recent call last):
File "/usr/local/lib/python3.9/site-packages/aiohttp/connector.py", line 1154, in _create_direct_connection
hosts = await asyncio.shield(host_resolved)
File "/usr/local/lib/python3.9/site-packages/aiohttp/connector.py", line 880, in _resolve_host
addrs = await self._resolver.resolve(host, port, family=self._family)
File "/usr/local/lib/python3.9/site-packages/aiohttp/resolver.py", line 33, in resolve
infos = await self._loop.getaddrinfo(
File "/usr/local/lib/python3.9/asyncio/base_events.py", line 856, in getaddrinfo
return await self.run_in_executor(
File "/usr/local/lib/python3.9/concurrent/futures/thread.py", line 52, in run
result = self.fn(*self.args, **self.kwargs)
File "/usr/local/lib/python3.9/socket.py", line 954, in getaddrinfo
for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno -3] Try again
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 313, in async_setup
result = await component.async_setup_entry(hass, self)  # type: ignore
File "/config/custom_components/bureau_of_meteorology/init.py", line 35, in async_setup_entry
await collector.async_update()
File "/config/custom_components/bureau_of_meteorology/PyBoM/collector.py", line 84, in async_update
async with session.get(URL_BASE + self.geohash) as resp:
File "/usr/local/lib/python3.9/site-packages/aiohttp/client.py", line 1138, in aenter
self._resp = await self._coro
File "/usr/local/lib/python3.9/site-packages/aiohttp/client.py", line 535, in _request
conn = await self._connector.connect(
File "/usr/local/lib/python3.9/site-packages/aiohttp/connector.py", line 542, in connect
proto = await self._create_connection(req, traces, timeout)
File "/usr/local/lib/python3.9/site-packages/aiohttp/connector.py", line 907, in _create_connection
_, proto = await self._create_direct_connection(req, traces, timeout)
File "/usr/local/lib/python3.9/site-packages/aiohttp/connector.py", line 1166, in _create_direct_connection
raise ClientConnectorError(req.connection_key, exc) from exc
aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host api.weather.bom.gov.au:443 ssl:default [Try again]

Strange indeed... it is still working for me.
Do you mind switching on debugging?
logger:
  default: warning
  logs:
    custom_components.bureau_of_meteorology: debug

Thank you.
After I turned on logging configuration, I rebooted the host and magically the integration restarted.
Apologies for not rebooting my host before raising the issue.
Thank you for an uniquely Aussie integration mate!

No worries! It could've been an issue with your internet connection at the time perhaps.

Thank you. Its great to have local/accurate/free weather data in Home Assistant. Your a good man!

On 27 Jan 2022, at 9:32 pm, bremor @.***> wrote:

Closed #97.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.

They were doing maintenance yesterday. My temp etc were all missing. The humidity and apparent temp went awol a week ago and are still missing.

Cheers @DavidFW1960
@bremor The issue is occurring again today. I suspect @DavidFW1960 is right, BOM are diddling with the API end-point :)

you can check here
http://www.bom.gov.au/nsw/observations/nswall.shtml?ref=hdr
that's for NSW and it looks ok right now... (I'm at Gosford)
Yesterday this page said it was down for maintenance
http://www.bom.gov.au/products/IDN60801/IDN60801.94782.shtml
The dewpoint, apparent temp and humidity have been gone for a few weeks but the pressure has been missing for years

I wonder if the VIC storms are causing their servers to be hammered. My integration has been coming on and off all day. The joy of an always on home assistant dashboard

On 28 Jan 2022, at 10:30 am, DavidFW1960 @.***> wrote:

you can check here
http://www.bom.gov.au/nsw/observations/nswall.shtml?ref=hdr
that's for NSW and it looks ok right now... (I'm at Gosford)
Yesterday this page said it was down for maintenance
http://www.bom.gov.au/products/IDN60801/IDN60801.94782.shtml
The dewpoint, apparent temp and humidity have been gone for a few weeks but the pressure has been missing for years
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.


Remove print chat option in mobile only

@bhardwajaditya  can you review this please when you have a chance?  I'd also like to understand how we can test, and what changes we might need made in the js script from the my.viasat team.  Thanks.

@bhardwajaditya @Shailesh351 please review and approve if the code looks good.  I'm going to reach out to Mark about having him integrate this into myViasat.  Thanks.


ci: merge opae-libs

Automated changes by create-pull-request GitHub action.
Must be use a normal merge (not squash-merge and not rebase-merge)

Coverage decreased (-0.04%) to 63.282% when pulling 6469e5592e0bd2c2a72df90dd287986de03dc1c3 on auto/update-libs into 5e785560b29ecc51d550b7503a32de56bd2844fe on master.


Defer tree initialization PRO-498

This is a first draft of deferring tree initialization. I have some open TODOs here that I would like some feedback on.

different versions of Duration are being used in different places. Is this intended? from chrono and std.
We need to delay TaskManager::start until after the tree initialization. It's not clear what the best way to do this is. Multiple routes we could take.
How should we handle the shutdown channel for spawn_monitored_with_backoff

It's a side effect of using tokio and sqlx. tokio uses std::Duration but TIMESTAMPTZ best maps to chrono::DateTime so that sometimes gets converted into chrono::Duration
We actually don't need to delay it - we can have the tasks running without the tree initialised and throwing errors periodically - this would give us better visibility into the initialization period of the sequencer as these errors will show up in our monitoring
If you mean for the purpose of the task ot initialise the tree - we can just start it in the task monitor, no? Then the shutdown sender is handled as before. Also something to note here is that failing to initialize the tree for any other reason than network issues (we do a call to the smart contract for the latest root) should panic and crash the process

We actually don't need to delay it - we can have the tasks running without the tree initialised and throwing errors periodically - this would give us better visibility into the initialization period of the sequencer as these errors will show up in our monitoring

Ah yeah if this is the desired behaviour we can definitely do that. Are we sure we want to throw errors like this though? I usually try and stay away from logging an error when it's expected behaviour, sorta reduces the signal to noise of your errors and can be pretty noisy.
If you think that's the best route though then it's definitely the easiest to do correctly. I can work on that right now if that's what we wanna do.

I feel we should go this way - other option is to do tree initialisation as a separate flow/task but then we'll need to provide custom visibility into it.
We should treat prolonged tree initialisation as an error anyway imo - we should aim for it to be at most 10 seconds or something along those lines.
So yeah, let's do tree initialisation in a TaskMonitor task and have other tasks fail while the tree is uninitialised


MQTT issues with 4.0.3

Hi,
I am having issues with 4.0.3 where none of my MQTT messages are being sent when testing the devices.  I have removed and re-added my devices and also spun up a new docker instance.
The logs show...
Decode Json for url items: [{"item":"{"clientId":"habridge","topic":"homie/amp/power/on/set","message":"false"}","type":"mqttMessage"}]
executing HUE api request to send message to MQTT broker: "{"clientId":"habridge","topic":"homie/amp/power/on/set","message":"false"}"
Which is the right data but that message is not received.  I also see the following in a temporary message in the top right of the screen which is not related to the message I am sending.
Request Executed: success {"/lights/1/state/on":false}
Thanks, Simon

I've had this issue since trying 4.0.1, I get no MQTT messages over the network when running 4.0.1, 4.0.2 or 4.0.3. Running 3.5.1 no problem. I have MQTT spy running with a # filter running and NO messages are sent. I did report this on 4.0.1 and it was labelled as bug and close, however issue still remains.
I have done a complete rebuild of all my devices and cannot get any output. It does register with my MQTT server, but thats all

Will look into

Verified. Loop control construct never goes and executes call.

Hi,
Initial testing is looking good.  Thanks so much for the really quick turn around!
The message in the UI when testing on and off still looks to be hard coded with... Request Executed: success {"/lights/1/state/on":false}... but this is only a minor thing.
Thanks again for a great piece of software.
Simon


Update and rename content/rest/reference/permissions-required-for-git…

…hub-apps.md to เนื้อหา/พักผ่อน/อ้างอิง/permissions-required-for-github-apps.md

Why:
Closes [issue link]

What's being changed:

Check off the following:

[x] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[x] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Hi


[S] Add new sub-area to Roche Lake Park

In A&R, add a new sub-area with Day Use activity under Roche Lake Park.

Acceptance Criteria:
Given I have a sysadmin role in A&R or the correct Roche Park and sub area permissions
When I go to Roche Lake Park in A&R
Then I can enter data under the ORV Trail sub-area under Day Use activity.
Given I have full permissions in redhat/keycloak
When I go to give a park operator or someone responsible for Roche Lake a role for A&R
Then I can give them ROche Lake (6892) and ORV Trail permissions so they can enter data on that sub-area.

Completed in Prod only.

Tested on PROD: Passed

Verified that the new sub area and the facility has been added to the A&R using A&R Admin portal, DynamoDB.
Verified that a user added only with permission to 6892:1022, has access and can add data from the A&R Admin portal.
Passing to PO review.

looks good in prod - moving to done


Clean workspace prior to installer jobs

The current buildInstallerMac/Windows() stages relied on the workspace being clean by the prior sign_build stage running on the same Jenkins master node. Now with 2 instances, it may not run on the same node. Thus this PR ensures each stage performs the workspace clean.
Fixes: https://github.com/adoptium/temurin-build/issues/2959
Signed-off-by: Andrew Leonard<EMAIL_ADDRESS>

Test job: https://ci.adoptopenjdk.net/view/work-in-progress/job/andrew-jdk-mac-x64-temurin/4/

run tests

run tests


Currently tektoncd/chains uses Deprecated in-toto/in-toto-golang Subject, StatementHeader, etc. structs.

Currently tektoncd/chains uses deprecated https://github.com/in-toto/in-toto-golang structs:

intoto.Subject{...}
intoto.StatementHeader{...}
intoto.ProvenanceStatementSLSA1{...}
intoto.StatementInTotoV01{...}

https://github.com/in-toto/in-toto-golang/commit/32351740df5f3e9c079d4fe12bcf27271e2290b1
https://github.com/in-toto/in-toto-golang/blob/master/in_toto/attestations.go#L32-L42
We should update tektoncd/chains code to use the correct structs
Possibly related: https://github.com/tektoncd/chains/issues/920

With the work we did in https://github.com/tektoncd/chains/pull/1111 and https://github.com/tektoncd/chains/pull/1118, we migrated the structs to the non-deprecated versions. I think it should be fine to close this issue @chitrangpatel

agreed!


Issue reporter blank

@kburtram You fixed an issue with this last time too - could you take a quick look to see if it's the same kind of issue?

Assigning to myself to take a look

verified in latest rc build. closing the issue now


after 1 epoch,  you  don't shuffle?

I also see this problem, and'train_set'seems to remain unchanged.

@Wallace-he   Have you solved this problem?

This is correct. I'm actually working on migrating this over to keras (for multiple reasons), this will be one of the problems solved by that. Could use some help figuring out a problem with model saving in keras tho

I didn't understand it before. But I want to ask you how I want to change the PSNR value after each test.

Sorry, this is my mistake! Now I want to output the PSNR value in each test. How can I achieve this?

You can watch this using tensorboard, that's how I recommend doing it.
If you want to print PSNR, you'll have to edit the train loop to evaluate PSNR from the graph and print that

Thank you. I'm sorry to bother you many times. But with your checkpoints and your own training results, the PSNR value of reconstructed images on set5 and test set and individual other pictures is even lower than that of traditional methods. Why?


not getting time of .webm caputured

I'm submitting a ...
[ X] bug report

when running the thing with .webm as output extension, recorder.getRecordDuration() gives always 00:00:00:00. the same exact code using .mp4 as output extension is working great. is it the same for you too?
thanks.

Same here, I get inconsistent duration when using .webm. After several testing it does not record anything anymore and outputs the file with 00:00:00 duration.


Fix/seek

This PR is focused on solving the following issue and has been split off from this PR which deals with combining skip and seek commands.

@dcvz please take a look at this PR which contains work that should be independent of the interface changes suggested for the seek methods.


Custom pluralization

Currently the library only supports the basic pluralization used in English, i.e. differentiating between the count "one" and "other". For instance "You have one message" and "You have 5 messages" .
In some languages this sentence would be needed to be written in more than two ways depending on the message count. In some languages the rule for what grammatically corresponds to one is different, e.g. that 21, 31, 41 etc use the same phrasing. as 1 (but 11 rarely does).
For this library to fully support more language, it would be useful if these rules could be specified in the language file similar to:
# Make every count ending with 1, but not ending with 11, grammatically correspond to 1.
pluralization_rule: {
  one: "x % 10 == 1 && x % 100 != 11"
}

Specification for keys: http://www.unicode.org/cldr/charts/29/supplemental/language_plural_rules.html#comparison

# Using Russian rules for this example/experiment.
# Use pluralization from first rule that matched x.
#
# In CLDR :many and :other is accidentally swapped in Russian, but kept as it is
# too late to change.
# http://cldr.unicode.org/index/cldr-spec/plural-rules#TOC-Choosing-Plural-Category-Names
#
# This explains the somewhat awkward :many rule "true", which matches all x.
# Ideally the first rule, matching all floats, should have been labeled :many,
# and the numerics, now regarded as :many, should fail all tests and fall back to
# :other.
ru = {
  other: "x.is_a?(Float)",
  one: "x % 10 == 1 && x % 100 != 11",
  few: "(x % 10).between?(2, 4) && !(x % 100).between?(12, 14)",
  many: "true"
}

def pluralize(count, rules)
  rules.each_pair do |plural, rule|
    x = count
    return plural if eval(rule)
  end

  # Always fall back to :other if no rule matched count.
  :other
end

pluralize(1, ru)
# => 1

pluralize(3, ru)
# => :few

pluralize(3.4, ru)
# => :other

5 different rules are implemented in 2c471f651dcc14fa83d7c176f784f4a890045dc3. The language files reference these by name as opposed to containing serialized executable code.
All languages supported by SketchUp should now be covered.


Fix issue #308

Coverage remained the same at 100.0% when pulling 64668a6326796476c01342eea43afcdafe219985 on issue_308 into da3c4bcfcb5285f2c2f4af08e242fcbf1ebf086a on master.


Gps blend timestamp

Please use PX4 Discuss or Slack to align on pull requests if necessary. You can then open draft pull requests to get early feedback.
Describe problem solved by this pull request
When GPS blending is enabled, vehicle_gps_position/time_utc_usec is always 0 even when the GPS sensors have a valid UTC time.
Describe your solution
Blend UTC timestamp from all receivers that are publishing a valid time_us value
Describe possible alternatives
Instead of blending, one could simply pick the first GPS with a valid timestamp. However, since the system timestamps are blended, I think it is suitable to blend UTC time as well.
Test data / coverage
Added unit test for GPS UTC time blending.
Additional context
Pls squash-merge :pleading_face:

Approved for merge given that the test passes. Also, I don't think the pull request is supposed to point to main? Probably aviant/1.13

Approved for merge given that the test passes. Also, I don't think the pull request is supposed to point to main? Probably aviant/1.13

Right, I see that i accidentally based this on the "main" of PX4. Will keep the changes, but change to aviant/1.13 and release/1.13

Closing and moving this to a common branch with other dual GPS fixes: https://github.com/aviant-tech/PX4-Autopilot/tree/aviant/gps-rtk-yaw


Provide helm chart

hi, would it be nice to provide a helm chart of kafkahq?

Hi,
Since there is more and more ask, will do it asap.
But PR are welcome to speed up this feature 😆

I am looking into creating one but I have a problem with starting it


Simplify the PickCommand VimL function.

The code works from vim.
Can you add something to warn people that it only works from terminal vim, not GUI vim.

I will merge this.


Automatically disable button while in pending state

add a property disableWhilePending, for compatibility being false by default
When true, will disable the button while being in pending state, i.e. promise returned from action is not settled
In v3.0.0 set disableWhilePending to true by default?

Related to #638. With a button yielded by a form, that would auto-disable the button while the form is submitting.
@jelhan thoughts?

Would be a helpful addition IMO.

In v3.0.0 set disableWhilePending to true by default?

I think an alias to preventConcurrency would be more helpful as for most use cases the button should be disabled if preventConcurrency is true. Maybe we want to consider toggling that default in v3.0.0?

I think an alias to preventConcurrency would be more helpful

Yes, but this is describing the case where the button is yielded by the form, so when yielding we can override disableWhilePending with whatever makes sense in the context of a <BsForm>. For a plain <BsButton> the default could still be set to true I think? (again, in v3)

I think an alias to preventConcurrency would be more helpful

Yes, but this is describing the case where the button is yielded by the form, so when yielding we can override disableWhilePending with whatever makes sense in the context of a <BsForm>. For a plain <BsButton> the default could still be set to true I think? (again, in v3)

Maybe I'm missing something but why shouldn't this be different for a plain <BsButton>? <BsButton> also has a preventConcurrency option. I don't see use cases for <BsButton @preventConcurrency={{true}} @disableWhilePending={{false}}> or <BsButton @preventConcurrency={{false}} @disableWhilePending={{true}}>.
I'm especially worried about edge cases if preventConcurrency defaults to false and disableWhilePending defaults to true and the defaults are not overriden. There might be timing issues in that case which still allows onClick action to be fired concurrently. At least I'm worried about the disabled attribute of the button not being updated yet by Glimmer VM but a second click event being fire. Not sure if this is prevented by some browser internals but we wouldn't have to worry about it, if both of them are in sync as long as consumer doesn't pass in both.
So maybe disableWhilePending should default to preventConcurrency and preventConcurrency should default to disableWhilePending. If both aren't set they should default to true. (Talking about v3 only right now).

<BsButton> also has a preventConcurrency option

Nevermind, I forgot about this! 🤦♂
So yes, then this absolutely makes sense!

While working on #834 I noticed that the design laid out here might be overcomplex. I'm not convinced anymore that we need a disableWhilePending property at all. Maybe it's enough to change disabled so that a button is disabled by default if the click action is pending and if the button should prevent concurrent clicks:
diff --git a/addon/components/base/bs-button.js b/addon/components/base/bs-button.js
index 54bd1545..1e9666d1 100644
--- a/addon/components/base/bs-button.js
+++ b/addon/components/base/bs-button.js
@@ -1,7 +1,7 @@
 import { scheduleOnce } from '@ember/runloop';
 import Component from '@ember/component';
 import { observer, computed } from '@ember/object';
-import { deprecatingAlias, equal, or }  from '@ember/object/computed';
+import { and, deprecatingAlias, equal, or }  from '@ember/object/computed';
 import layout from 'ember-bootstrap/templates/components/bs-button';
 import TypeClass from 'ember-bootstrap/mixins/type-class';
 import SizeClass from 'ember-bootstrap/mixins/size-class';
@@ -149,12 +149,15 @@ export default Component.extend(TypeClass, SizeClass, {
   /**
    * Property to disable the button
    *
+   * The button is disabled by default if and only if
+   * - a Promise returned by `onClick` action is pending and
+   * - `preventConcurrency` is `true`.
+   *
    * @property disabled
    * @type boolean
-   * @default false
    * @public
    */
-  disabled: false,
+  disabled: and('isPending', 'preventConcurrency'),

   /**
    * Set the type of the button, either 'button' or 'submit'

A consumer that overrides disabled is responsible itself for disabling the button if an action is pending. This also prevents edge cases like <BsButton @disabled={{false}} @disableWhilePending={{true}}>  in current design.

Maybe it's enough to change disabled so that a button is disabled by default if the click action is pending and if the button should prevent concurrent clicks

Sounds reasonable!

disabled: and('isPending', 'preventConcurrency')

I believe this will trigger a deprecation warning, as settings that prop (which we want to allow!) will override the CP, see https://deprecations.emberjs.com/v3.x#toc_computed-property-override


Cannot install arrow-odbc on Apple Silicon Macs

Not sure how much effort would be required to build suitable wheels for distribution (I believe GitHub does offer the necessary runners these days?), but would be great to be able to install on modern Macs without having to compile locally (which I tried, but temporarily gave up on as it was getting a little non-trivial).
pip will attempt to compile it on download, but fails to resolve the relevant paths for linking (assuming you have already downloaded the necessary libraries), etc...😅

Hello @alexander-beedie ,
thanks for reporting the issue. Yes, this would be straight forward if GitHub would offer ARM runners. Yet it doesn't. Not to look a gift horse in the mouth though. It is awesome that in this day and age I get this much infrastructure for free anyway.
Sadly I can not see the entire error based on the provided screenshot. The artefact should build nicely on ARM though. The workflow files in this repository should give some hints on what is required to build. On the top of my head:
You need to install unixodbc. You can use brew for this, but last time I had access to an ARM brew put the binaries in different directories on ARM systems, as opposed to other platforms. cargo would not be able to find and link them as a result. This might be outdated knowledge though. I would recommend installing unixodbc from source. See also the ARM section of the odbc-sys Readme: https://github.com/pacman82/odbc-sys. UnixODBC is both a bulid and a runtime dependency.
The second thing you need for the build to work is a rust toolchain, including its build and package manager cargo. Visit https://rustup.rs and follow the instruction. The latest stable toolchain with default options always works.
Feel free to come back here, if you get stuck.
Best, Markus

thanks for reporting the issue. Yes, this would be straight forward if GitHub would offer ARM runners. Yet it doesn't.

Ahh, I should have been much more specific that the official Apple Silicon runners have only been available (in public beta) for -literally- a few days (I could have sworn they cam out earlier, but apparently not) ;)

https://github.com/actions/runner-images/issues/8439

Cool, the blog post mentions some cost for these runners though. I already give my spare time maintaining this. I do not feel inclined to pay on top of it.

Cool, the blog post mentions some cost for these runners though. I already give my spare time maintaining this. I do not feel inclined to pay on top of it.

Ahh, didn't spot that, my bad - not to worry, entirely understandable!
Thanks  ;)

All good. Improving documentation to build help build locally is an entirely different beast though. Also, recently there has been some effort into making arrow-odbc available via the conda-forge channel. ARM pipeline is currently broken, but it used to work, and is likely to do so again in the future. So if you have anaconda or a similar package manager installed you can use that to install arrow-odbc without building locally yourself.
Best, Markus

Hello @alexander-beedie and @ldacey
reopened the issue, because I saw you both mentioning build errors on M1 machines. Sadly I do not have access to one to try myself, but it was one of my core goals to make building and updating arrow-odbc way easier compared to other libraries, by only relying on C-Interfaces to cross the language barrier and not be tied to any C++ ABI or system provided boost version.
With a little bit of help I could probably provide a good description on how to build on M1. If you have access to one of these machines and one of you would be up for a pair programming (well, building) session I would be game.
I am located in the Central European Time zone FYI.
Best, Markus

With a little bit of help I could probably provide a good description on how to build on M1. If you have access to one of these machines and one of you would be up for a pair programming (well, building) session I would be game.

Sounds like a plan; would be happy to help  :)
As far as timezones go, I'm only 2 hours off CET, so shouldn't be too challenging to find a good time.

@alexander-beedie I invited you to a repository with my contact data in order to connect.

For anyone who is trying to install arrow-odbc on Apple Silicon. First you need to install unixodbc - brew install unixodbc.
Now if you try to install arrow-odbc you will get following error:
    = note: ld: warning: ignoring duplicate libraries: '-lc', '-lm'
            ld: warning: search path '/Users/radek.tomsej/lib' not found
            ld: library 'odbc' not found
            clang: error: linker command failed with exit code 1 (use -v to see invocation)

All you need to do is create a simling to specified search path: sudo ln -s /opt/homebrew/lib /Users/radek.tomsej/lib. Then you are able to install it.

Thanks again @tomsej ,
this worked again here: https://github.com/pacman82/arrow-odbc/issues/75#issuecomment-1797394808

Thanks @ldacey for confirming it is working#

@pacman82 In case you need M1 runners in the future, you can try FlyCI's M1 and M2 runners. They are on average 2x faster and 2x cheaper than GitHub's AND we have a free tier for OSS projects (see below).
Install Instructions

Install FlyCI app and
Easily replace one line of code and start using FlyCI runners:

jobs:
 ci:
-    runs-on: macos-latest
+    runs-on: flyci-macos-large-latest-m1
   steps:
   - name: 👀 Checkout repo
     uses: actions/checkout@v4

500 mins/month Free for Public Repos
Since your repo is public, FlyCI offers 500 mins/month of free M1 runner usage with the flyci-macos-large-latest-m1 runner for public projects.
Don't hesitate to contact us in case the free tier doesn't suit your needs or you experience any issues with the runners. Our team is here to support you!
Best Regards,
Veselina Radeva
Product Manager at FlyCI

Hello @radeva ,
I am short on time atm. , yet this is indeed interesting. Soon, as I find myself having some time to spare, I will give it a look.
Best, Markus

Hello @radeva ,
thanks to FlyCI's free tier both arrow-odbc and odbc2parquet now enjoy a release for Mac ARM 64. Thank you!
Best, Markus


In Scanner::scanTokens() remove the EOF emplacement

EOF should only be added to the token vector if the end of the file has been reached. Right now EOF_LOX is added after every line of code rather than just at the end of the file. I'm not even sure if EOF needs to be a token. Check ahead in the book t see how it's used.

This issue is void. Adding EOF to the end of the file is useful.


Added new upload option to AppendNoCheck so that we can append with no check.

Added new upload option to AppendNoCheck so that we can append a file on the server without checking if it exists yet.  This is required if the server you are uplaoding to does not allow you to list the contents of the folder, but the file does exist.
The call will throw an exception when the NLIST command is used, this will bypass the exception since we are not checking the directory for the file.

Is it possible to have this merged in and published on NuGet? This will definitely be useful in this type of scenario and would be greatly appreciated

I'm still trying to understand it!!
On Sat, Feb 2, 2019, 12:47 PM everbalovas<EMAIL_ADDRESS>wrote:

Is it possible to have this merged in and published on NuGet? This will
definitely be useful in this type of scenario and would be greatly
appreciated
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/robinrodricks/FluentFTP/pull/362#issuecomment-459942920,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGe6KnDGCrT_XkXysXpmX1w7YSJKV1P1ks5vJTuQgaJpZM4aUiHa
.

Okay, lets do this. Thanks!

Thanks robinrodricks, let me know when you build out a version on NuGet, I see 19.2.4 but it doesn't include my change.
Thanks again!

Released in FluentFTP 20.0.0.


Make starting-strings like global or eslint configurable

I tried another package but it has this issue:
https://github.com/cartant/eslint-plugin-etc/issues/48
I can not enable it - it would warn about comments starting with TODO:, which it shouldn’t.
The same issue applies to this eslint-plugin-no-comments.
Since eslint-plugin-no-comments already ignored comments with specific 'starting strings' like global and eslint, it would be solved it these strings could be configured. This would also be helpful if people use other linters etc. to ignore comments like e.g.
// cSpell:ignore Lorem Ipsum
A solution could look like this:
{
  "plugins": ["no-comments"],
  "rules": {
    "no-comments/disallowComments": ["error", {
      "ignore": ["eslint", "global", "cSpell", "TODO:", "BUG:", "HOTFIX:"]
     }]
  }
}

Feature added, please check :)

Works like a charm!

…and btw. I was able to allow all JSDoc comments with that:
"allow": [ "\\*\n", "\\*\\s" ],

@DerZyklop, good point, basically you can add any kind of regex. I will add this information in the future to docs. Thanks for the feedback :)


Set Index Description

Description
Add set index description to files

Done.

@sarminh
Done!
Please double check and if everything is OK then close this issue ;-)
README.md
MEA.md

Everything is fine.


fix: use anon-const for wrapping expanded impls

On latest nightly, with the introduction of https://github.com/rust-lang/rust/issues/120363, proptest derives don't pass lints anymore, e.g.
error: non-local `impl` definition, they should be avoided as they go against expectation
  --> crates/primitives/src/account.rs:15:12
   |
15 | pub struct Account {
   |            ^^^^^^^
   |
   = help: move this `impl` block outside the of the current constant `_IMPL_ARBITRARY_FOR_Account`
   = note: an `impl` definition is non-local if it is nested inside an item and neither the type nor the trait are at the same nesting level as the `impl` block
   = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
   = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <https://github.com/rust-lang/rust/issues/120363>
   = note: the derive macro `AccountPropTestArbitrary` may come from an old version of the `proptest_derive` crate, try updating your dependency with `cargo update -p proptest_derive`
   = note: `-D non-local-definitions` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(non_local_definitions)]`
   = note: this error originates in the derive macro `AccountPropTestArbitrary` (in Nightly builds, run with -Z macro-backtrace for more info)

This fix is similar to https://github.com/dtolnay/typetag/commit/d51f4adc253f12a02939625ebbab9305ca66f567, i.e. use anon const expressions instead of named ones.

@matthew-russo PTAL when you have time, as it blocks nightly CIs on projects like Reth (https://github.com/paradigmxyz/reth/actions/runs/8048254493/job/21979197918).

@shekhirin
looks like nightly has failing unit tests
https://github.com/proptest-rs/proptest/actions/runs/8048322898/job/22017111787?pr=427#step:13:770
i'll try to give a look one evening this week. if you get to it first, let me know

@matthew-russo ah, it's an easy one, fixed! Can you please re-run the CI?

Thanks, I'll try to cut a release this week as we have a couple fixes pending

Hey @matthew-russo, any updates on this? I saw proptest was released but not proptest-derive, was this missed? Thanks!

Sorry I had to take some time away to deal with projects at home. I'll be triaging issues this week and throw cutting a derive release in there as well


Please document all protocol aspects of the app

Building on nostr means to be interoperable but I can't find which kinds of events are being used here.
I ask because I maintain the probably biggest repository of Bitcoin wallet apps at WalletScrutiny.com where we also recently started to add ratings for apps and I  would like to have synergy between the two projects as early as possible.

Sure! Here are some sample events so you get an idea of what we're using: https://github.com/zapstore/zapstore/wiki/Sample-app-events

So you have:

kind 1063: artifact event

url-tag links to binary artifact
x-tag hash of artifact
size-tag in bytes
p-tag: where does that come from? You set it manually? I saw you said you scraped github.

kind 30063: release event

d-tag global app identifier @ version
url-tag links to github release
a-tag links to kind-32267 app event and kind-1063 artifact event(s?)

kind 32267: Description of app

stuff describing the app except for an actual description

Why are artifact events not replaceable with the hash as the d-tag? I imagine the need of adding further data or correcting data.

Why does the artifact event not link to the git revision or the release event? With many artifacts matching the same release, it feels more logical to link from the artifact to the release and not list artifacts in the release event.

The example app event uses com.mutinywallet.mutinywallet in its d-tag which is the Android App ID I assume. In WalletScrutiny I had decided to prefix this with android/ to avoid ambiguity. I see you treat "Mutiny Wallet" as the app on all its platforms and with this app and the single code base that is ok but some apps are quite different depending on the platform.

Artifact events are NIP-94, it's a non-replaceable event. If you need to correct data update your release pointing to another kind 1063.
Reverse-domain notation is the standard and recommended but it's not me who will be creating these events. It's up to developers. They are welcome to create multiple 32267 app events for different platforms if it's more convenient.


Environment variables in the Readme

Description
This are the env variables and in this the HOME_GUILD string is missing which is needed for "npm start"
DISCORD_TOKEN=
EDDIEBOT_MONGO_CONNECTION_STRING=
DEBUG_HOOK=
HOME_GUILD=
NODE_ENV="development"
ADMIN_CHANNEL=
Screenshots
No response
Additional information
No response

Thanks for raising!
Please add to the README the code block ...
# .env file

# required: discord api token
DISCORD_TOKEN=

# required: mongo url connection string
EDDIEBOT_MONGO_CONNECTION_STRING=

# optional
DEBUG_HOOK=

# required: discord server id
HOME_GUILD=

# optional
NODE_ENV="development"

# required: channel id for logs
ADMIN_CHANNEL=

Created a pull request


fix: Rich Text link respect enableRichTextRelationship

Description
collection.admin.enableRichTextRelationship allows hiding collections in the selection of the Rich Text's relationship drawer. This configuration is not respected by the link button however. This PR aims to fix that by filtering the collections in the same way the relationship button already does.

[x] I have read and understand the CONTRIBUTING.md document in this repository

Type of change
I am split between these two; I would consider this a fix. I don't know if limiting the field to its relationship counterpart's selection is considered a breaking change. There might be people relying on this?

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] I have added tests that prove my fix is effective or that my feature works
[x] Existing test suite passes locally with my changes
[ ] I have made corresponding changes to the documentation

I would add an additional property for this since it is a separate concern. I've been discussing this exact thing https://github.com/payloadcms/payload/discussions/2567.
What do you think?

If you think that makes more sense, I don't mind that! It was just an inconsistency that came up in a recent usecase for one of our projects and using the same boolean that is also used for the relationships (since it's just a relationship field either way) seemed like the most straightforward way.
Sooooo, enableRichTextLink then? @DanRibbens

Hey @mvarendorff, thanks for being flexible. We do want to split the flag to do links separately from the relationships for RichTexts.

Alright, that's fair! I updated everything, let me know if something is missing :)

Looks great! Thank you @mvarendorff!


consider and improve the structure about directories / mix projects / modules

I think the current structure is not so bad. So I decided to close it without any modifications.


[core] Fix docs:api cleaning the wrong directory

[x] I have followed (at least) the PR section of the contributing guide.

Resolve #20162

@ro7584 Thanks!

My pleasure. 😊


Likelihood estimation

Hello Dr. @yang-song , thank you very much for this work.
I'm trying to estimate the likelihood for a given sample. I understand I have to do something very similar to what you do for computing the bpd, here.
As I understand, following eq. (39) in the paper, to obtain $\log(p_0(x_0))$ I have to "correct" $\log(p_T(x_T))$ using the integral of the divergence of the drift function: $\int_0^T \nabla \cdot \overset{-}{f}_\theta (x, t) dt$
In order to obtain a more accurate likelihood estimation using the Skilling-Hutchinson trace estimator, what I'm doing is using the $x$ and $t$ obtained from the SDE solver, like this:
t = solution.t
x = solution.y[:-shape[0], :]

and using these values to plug them into the equation $\epsilon^T  \nabla \overset{-}{f}_\theta (x, t) \epsilon $.
Then I sample many epsilons and average the results of this equation, to obtain an estimation of div_f.
Finally, I just compute the integral in time, like this:
div_f_integral = torch.trapz(div_f, t, dim=-1)

What do you think, is this correct?
The problem is that the result I'm obtaining is not as expected. When I compute $\log(p_T(x_T)) + \int_0^T \nabla \cdot \overset{-}{f}_\theta (x, t) dt$, I'm supposed to obtain $\log(p_0(x_0))$, but I obtain nonsense values, like log-probs greater than 0...
In summary, what can I do to obtain a more accurate likelihood estimation?
Many thanks in advance!
And any help or hint is very appretiated

Hello,
I am also studying the likelihood computation as described in the paper. However, I noticed that in the original code, the prior log probability (prior_logp) is calculated using this line. This formula calculates prior_logp based on the final output of the ODE solver (see line 101: zp = solution.y[:, -1]), which means the prior log probability is computed by inputting the final denoised image into a Gaussian distribution.
However, according to the formula in the paper, the final likelihood should be the likelihood of the Gaussian distribution plus an integral term. Am I misunderstanding something?
Any response would be greatly appreciated.


Database running out of space

We currently pay for a 5GB instance on http://www.objectrocket.com/, but we're fast running out of space. We currently pay $190 a month - to up to a 20GB instance would cost $500

https://github.com/theodi/csvlint/pull/196 is now live, and I've created the indexes on the box, so files should now die after 24 hours, which should mean much less space being wasted

We've just realised in #196 the TTL index was only set up for the Validations, which means GridFs files won't be deleted in 24 hours. Very sorry about this.
Might be best to revert to @bcouston's latest commit, and make the clean_up task execute itself after 24 hours, as was the initial plan?

Ah, I see. So it deletes the validations, but not the underlying GridFS files?

We could probably monkey patch Mongoid::GridFs to add the index?

is monkey patch downloading a local file and amending the class therein, or creating a class that inherits from Mongoid::GridFs?

 Would seem like that would work. Might be worth having a cursory glance over the Mongoid::GridFs repo - https://github.com/ahoward/mongoid-grid_fs

ok, that was the plan and you think it would work - so maybe attacking it along those lines is the resolution to this issue, rather than reopening the old issue?

Cool, sounds sensible :+1:

We're doing some research and we're not convinced this is a better solution that the one (periodic runner than empties the DB) which James and Ben worked on (ironically). Can this be parked until Monday and a discussion with @Floppy and others around the next sprint can transpire?

Yup, sounds like a plan :+1:

Cool - I think it's either go back to the previous solution, or replace the GridFS as the means of storing the temp files - it looks like a hard problem to delete the GridFS by TTL because the chunks to not have a date field

I'm a gonna close this. Think the issue is now fixed.


fix test required libraries

I fix that.
Also fix test without libeio on MacOS and disable test with embedded libeio only.

Looks good! Are you going to brush up the commits, or we could merge?

I don't have access to MacOS station, so can't fix MacOS embedded libeio test. So you can merge.

Landed. Thanks once again!


minute update

As suggested in email, please use Transifex https://transifex.com/citizens-foundation-1/your-priorities-1/client-app/ to upload the translations.


Needs authn/authz (CAS) on UI for creating certs and issuances

As-is anyone who knows the url of the server can create certs and issuances, this should be restricted to admins.

From my notes: CAS login for admin app -- check that GT Account is one of our approved admin

Login is currently working, needs to check local db for is_admin and redirect to the page you were trying to access when prompted for login.

CAS login is now limited to approved accounts, just need to fix the redirects.


Set datacontext to viewmodel

In 'Binding to a single item' section in the code for MainPage.xaml.cs you say:
this.ViewModel = new RecordingViewModel();
Do you mean:
this.DataContext = new RecordingViewModel(); ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2a9882c8-2945-54d0-c418-72e5464229da
Version Independent ID: debb8633-d2f4-bd60-7ddd-0e39d080e0f5
Content: Data binding overview - Windows UWP applications
Content Source: windows-apps-src/data-binding/data-binding-quickstart.md
Product: uwp
Technology: data-and-files
GitHub Login: @knicholasa
Microsoft Alias: nichola

No, this example uses {x:Bind}, which binds implicitly to 'this', as opposed to the older {Binding} which binds implicitly to the DataContext property.


possible bug report on witness verify with -s

see attached word document...
witness-verify-oci-uri-subject-param-bug.docx

https://docs.google.com/document/d/1LG-FsIcabsYtSfQBUtbtrkXX8B47mpQs/edit

fixed by https://github.com/testifysec/witness/pull/252   We will have an example once we cut a release


[Bug] https://pro-editor.antdigital.dev/components/layout at Stackblitz

💻 系统环境 | Operating System
Windows
🌐 浏览器 | Browser
Chrome
🐛 问题描述 | Bug Description
Basic Usage at
https://pro-editor.antdigital.dev/components/layout
then i use Stackblitz and then i got:
Import error, can't find files:
./chunks/wasm-dynamic.mjs
./themes.mjs
./langs/angular-html.mjs
./langs/angular-ts.mjs
./langs/astro.mjs
./langs/blade.mjs
./langs/c.mjs ...
🚦 期望结果 | Expected Behavior
i want the see the basic usage in Stackblitz
📷 复现步骤 | Recurrence Steps

I use Basic Usage at https://pro-editor.antdigital.dev/components/layout
then i use Stackblitz and then
i got a Import error

Import error, can't find files:
./chunks/wasm-dynamic.mjs
./themes.mjs
./langs/angular-html.mjs
./langs/angular-ts.mjs
./langs/astro.mjs
./langs/blade.mjs
./langs/c.mjs ...
📝 补充信息 | Additional Information
No response

this package is esm only


[Editor][Bug] Fix editors for integers

My recent PR (https://github.com/asc-community/MxEngine/pull/69) broke component editors for int32's as I just redirected them to int64 editors, whichs not correct, as rttr cannot assign the properties back, assuming they store values of different type. As a result, some editors were not working
Also decided to replace texture2D -> texture in this PR just for consistency

Okay that makes sense.


[HOLD for payment 2023-12-29] Fix require cycle from clearReportNotifications.ts

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: N/A
Reproducible in staging?: N/A
Reproducible in production?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: N/A
Expensify/Expensify Issue URL:
Issue reported by: @arosiclair
Slack conversation: N/A
Action Performed:
Run NewDot in dev on Android/iOS
Expected Result:
No warnings about require cycles appear in logs
Actual Result:
 WARN  Require cycle: src/libs/actions/Report.ts -> src/libs/Notification/clearReportNotifications/index.native.ts -> src/libs/Notification/PushNotification/index.native.ts -> src/libs/Notification/PushNotification/ForegroundNotifications/index.ios.ts -> src/libs/Notification/PushNotification/shouldShowPushNotification.ts -> src/libs/actions/Report.ts

Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012e8796edd86cd329
Upwork Job ID:<PHONE_NUMBER>306968576
Last Price Increase: 2023-12-17

@conorpendergrast no triage needed for this atm. This is a dev issue.

The PR that introduced the bug has been identified: https://github.com/Expensify/App/pull/31762
The offending PR has been commented on: Not needed since I reviewed the offending PR
A discussion in #expensify-bugs has been started: Not needed
Determine if we should create a regression test for this bug: No

This was just a follow up to this PR for an issue we missed. I implemented both and the same C+ (@s77rt) reviewed so this shouldn't need any extra payment. Closing this out


Add ComputerBase logo

Thank you for ESLint!
This pull request adds the ComputerBase Logo.

Could you rebase please?

Done.