[SPARK-36662][SQL] Special timestamps support for path filters -  modifiedBefore/modifiedAfter

What changes were proposed in this pull request?

Special timestamps support for path filters -  modifiedBefore/modifiedAfter
Why are the changes needed?

theses special values can be useful to be supported in path filters -  modifiedBefore/modifiedAfter. e.g. for daily scheduled jobs
Does this PR introduce any user-facing change?

yes, special timestamps are supported by modifiedBefore/modifiedAfter
How was this patch tested?

newly added tests

Test build #142971 has started for PR 33908 at commit dc1e0fe.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47472/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47472/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47472/

Test build #142971 has finished for PR 33908 at commit dc1e0fe.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142971/

Test build #142987 has started for PR 33908 at commit 74c4aad.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47488/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47488/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47488/

Test build #142987 has finished for PR 33908 at commit 74c4aad.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142987/

cc @cloud-fan @MaxGekk thanks very much

hmmm I thought we already have this. cc @HyukjinKwon @HeartSaVioR

We have modifiedBefore and modifiedAfter options but don't have the support of special timestamps yet. @yaooqinn mind showing a self-contained example in the Pr description and clarify which special timestamps will be supported after this Pr?

updated the pr description and the sql doc too

Test build #143012 has started for PR 33908 at commit a3b7d08.

I'm not sure these special notions are interpreted into "timestamp" in consistent way. No doubt they have clear semantics when they are used as "date", but I'm not very clear whether the "yesterday" should be interpreted to the yesterday  "00:00:00".
Suppose two sentences:

"Spark will read the files which are modified before yesterday."
"Spark will read the files which are modified after yesterday."

How we interpret these sentences? Is the time point (in timestamp) of "yesterday" same for both sentences?
For me, all files modified in yesterday should be excluded in both sentences, but it won't be interpreted like that if we consider the semantic of "yesterday" as yesterday "00:00:00".

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47514/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47514/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47514/

The current implementation also accepts timestamps in an incomplete form like, 2021-09, 2021-09-30.
We can replace these values with both sentences above, what happens to September or 30th, September 2021?

I'd rather say that should be considered as a bug instead of justifying the current behavior.
The behavior of being able to specify incomplete format of timestamp is NOT an intention. The doc is very clear about the format of timestamp - The provided timestamp must be in the following format: YYYY-MM-DDTHH:mm:ss (e.g. 2020-06-01T13:00:00).

How about the modified events between the specific one second when using before/after 2020-06-01T13:00:00? what are the differences when the time unit is day or second?

The confusion on time unit on second makes an error of "second". We don't care much about "millisecond" precision on the modified date in file, because we can't predict it. Please let me know if your use case needs to classify the millisecond precision.

For me, all files modified in yesterday should be excluded in both sentences, but it won't be interpreted like that if we consider the semantic of "yesterday" as yesterday "00:00:00".

When yesterday is a timestamp, it represents the point of the midnight of yesterday, see https://github.com/apache/spark/pull/33908/files#diff-6c1794137bfd408f6c785c42e67e82a82fce70d78560fa795c3bac2886b21b38R140.

I'm not a native speaker of English, so please correct me if I'm mistaken.

"Spark will read the files which are modified before yesterday."
"Spark will read the files which are modified after yesterday."

For me, I expect the same behavior from both sentences, "exclude them written in yesterday". The point of time represented as "yesterday' in both sentences are different. That said, Spark will show different behavior with natural language. That is due to the conversion of "date" representation to "timestamp".
I understand that the timestamp format is probably not convenient enough to use in some cases. I'm fine if everyone is OK with the new notion, but I'd rather address the other case relatively harder to represent as such timestamp format, intervals like "before 24 hours" which is relative to the current timestamp. The result is still the unit of timestamp.

Test build #143012 has finished for PR 33908 at commit a3b7d08.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143012/

These special datetime strings are like functions and we should limit where they can be used. For this particular use case, I think the spark application is able to generate the timestamp string for yesterday/today/tomorrow?

These special datetime strings are like functions and we should limit where they can be used. For this particular use case, I think the spark application is able to generate the timestamp string for yesterday/today/tomorrow?

I think the behavior is unambiguous and clear to the system but may not be that clear to human thought, which seems not a problem to me

but may not be that clear to human thought, which seems not a problem to me

The human being will code the query so the first class concern should be started from end users' view, not from machine.


If texture asset is unloaded before a model that uses it is first rendered, an exception occurs

Repro: https://playcanvas.com/editor/scene/1023697
Please 1 to induce the crash.

Thinking about what 'should' happen and what would happen if the user loads the asset after the entity is enabled. Should the texture show? Or should the engine do nothing?


Upgrade Rails, Mongoid and content-models

This upgrades Panopticon to Rails 4 and Mongoid 5, via the rails-mongoid-upgrade branch of govuk_content_models. This is the last application using that gem to be upgraded; once this is merged, we can do a proper release and move all the apps to that.
In doing this upgrade, I got slightly sidetracked into making wrap_parameters work, to avoid the special casing of the parameters in the artefacts and tags controllers. This involved a fair amount of changes to the tests to ensure that they were actually posting JSON so that they would trigger the wrapping behaviour. I'm aware that this is not really related to the upgrade, and may not be worth doing at all in an app that will eventually be killed - happy to discuss splitting that work out.
As with the other apps, this will need changes to puppet and deployment to add the SECRET_KEY_BASE and MONGODB_URI env vars, and to alphagov-deployment to remove the old configs.

Sorry @danielroseman, this needs a rebase after https://github.com/alphagov/panopticon/pull/339.

I've looked through the changes and it all looks good. https://github.com/alphagov/panopticon/pull/341/commits/24bfd7b5938625931c28045ba2a7fe02a55f7324 is perhaps the most risky change because we're moving core behaviour around. We should probably test this well on integration.

👍 from me, but as Tijmen says a thorough test on integration would be good

🎉 🎈


[BUG] Due date showing placeholders when modified

Description
If you add a due date to an issue or pr and then modify it. It will show you the placeholders instead.
Screenshots

Gitea Version
1.17.1
Can you reproduce the bug on the Gitea demo site?
Yes
Operating System
No response
Browser Version
FF 103

This was fixed by #20388 and subsequent backport #21032


tables_ impl in Case

fixed the implementation of tables_ in Case to use sets and add values to it correctly

Coverage increased (+0.1%) to 98.028% when pulling 2995287fab7728b0d66224b967ac5986942e9555 on fix_tables_in_case into e9ba375373047690ae082a004c5c01dcfce08ce9 on master.


fix(ci): fix e2e for hawtio-next for v4.x

@mmuzikar Can you rebase it?  The branch doesn't start from the latest main.


Page#setViewport required options

	await page.setViewport({width: WIDTH});

with no height, puppeteer rejects with the error message:
Protocol error (Emulation.setDeviceMetricsOverride): Invalid parameters width: integer value expected

However, the documentation https://pptr.dev/#?product=Puppeteer&version=v1.10.0&show=api-pagesetviewportviewport does not indicate that both height and width are required.
IMHO setting just the width should change the width while leaving the height untouched (default being the current width/height).  However, if the current behavior is desirable, the docs should be updated to reflect that.  Other functions like page#setCookie explicitly mark fields as required in bold, and the same thing should probably happen here.

However, if the current behavior is desirable, the docs should be updated to reflect that.

I'd appreciate a PR.

I'd love to take this


Tox failures due to the upgrade of importlib-metadata

Receiving test failures due to the recent upgrade of importlib-metadata to v3.0.0
virtualenv 20.2.0 has requirement importlib-metadata<3,>=0.12; python_version < "3.8", but you have importlib-metadata 3.0.0.

https://github.com/pypa/virtualenv/blob/ced984abfd4f1531f9075113e77af7ec01479d29/setup.cfg#L47
https://github.com/pypa/virtualenv/issues/2019

fixed by https://github.com/pypa/virtualenv/pull/2021


10/18/2018 17:50 : Create Pull Request for branch prTesting_2018101817 -> master

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Textures not rendering for Sketchfab export

Per @Cook4986 (https://github.com/IQSS/dataverse.harvard.edu/issues/306) Sketchfab exports are not rendering textures correctly.
This looks to be a lack of support for the unlit Three.js MeshBasicMaterial.

A quick and dirty proof-of-concept for unlit material support is here: https://github.com/Smithsonian/dpo-voyager/tree/dev-basic-material though there are definitely some aspects of our material options (and obviously lighting controls) that don't really work in this scenario. Maybe we consider converting unlit to lit? @Cook4986 is there a specific reason you need unlit models or is this an unintended artifact of the Sketchfab export?
@sdumetz If we do end up mapping basic to physical materials, it might be worthwhile bringing back a custom copy method (https://github.com/Smithsonian/dpo-voyager/pull/188) to make things cleaner...

I don't know, the copy method should work for any material no?
we should probably look for a way to extend materials without having to duplicate so much code because they are a bit painful to update on each THREE.js upgrades and this code is error prone (which was the reason behind #188).
Maybe Clay/XRay/Wireframe could be moved to a separate standalone material?
Cut Plane and Overlays can't be separated from the material's code but maybe something like ExtendMaterial would work?
Do you think we could isolate necessary changes to the GL fragments to the beginning/end of the file and just concatenate it with whatever THREE is shipping? That would make supporting many materials much less code-intensive.


Partially revert changes from #29587

#29587 introduced changes to allow the usage of the multimap_keys_values_side_input state key. Since some runners don't support this key yet, usage was wrapped in a try/except block so that when talking to the runner if an error state response was received then it would no-op. In practice, some runners close the data channel on unknown state keys, so this introduced a regression. This attempts to minimally fix the problem by reverting part of #29587

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @robertwb


fix(video-conferencing-service): Added Reusability

Description
issues:

the functions should be reusable rather than in the controller
business logic if any should be moved to a provider for any change.
update "crypto-random-string" package or use something else in place of it.

Fixes #307

Moved the functions in controller to the services(ChatArchiveService and ChatSessionService).
Created Provider for crypto-random-string.
Business Logic Moved to Services

How Has This Been Tested?
-Performed Successful unit testing.
Checklist:

[x]  Performed a self-review of my own code
[x] npm test passes on your machine
[x] New tests added or existing tests modified to cover all changes

@parul147 also add the test coverage.

@parul147 Please go through the code smells


H2 inverter integration

Hi, I have received from SAJ the H2 modbus document: https://drive.google.com/file/d/1IXDwdgg7BlkSw72qb2bc9Q5qTa4gidhJ/view?usp=drive_link
I wanted to understand if it is possible to integrate also H2 with this information in the Home assistant module.
Thank you.

See: https://github.com/stanus74/home-assistant-saj-h2-modbus
That custom component is a fork of this one, made specifically for the SAJ H2.


If-Match header inconsistency between frameworks

In .NET Core 3.1, empty If-Match headers are propagated through in the request.
In .NET Framework and .NET 6.0, they are removed.
We should evaluate what the correct behavior is here and standardize on it.

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Storage:0.20483035,Azure.Core:0.12141646,Service Bus:0.07229351'

Chatted with @pakrym about this - this seems like less of a concern than the other normalization fixes that we did because specifying an empty string for a header is not really a valid use case.

@JoshLove-msft given your above comment do you see us fixing this issue?


Color contrast of tree view selected item and its border is less than 3:1

Does this issue occur when all extensions are disabled?:
Observe color contrast with selected item and its border

Expected : Color contrast of keyboard focus on the selected item should be than 3:1.
Actual :  Color contrast is less than 3:1.

Hi ,@isidorn would you help us with this accessibility issue.

@setaskin thanks for opening this issue.
@misolori this somewhat makes sense. We should have a stronger contrast to make it more identifiable that a selected item is also focused. What do you think?
fyi @joaomoreno

This one is going to be tricky because we have an array of combinations of states for the border, but we can take a look:

hi,  @isidorn and @misolori .  Thank you for looking into this.  We are (Live Share) very close to get our Grade C back . This is one of the last 3 bugs remaining that blocks our grade. If it can be prioritized that would be amazing. :)

@misolori thanks for the investigation, and I like what path you took in that PR.

Hi @misolori, thanks for working on this! Do you have an ETA we could share with the accessibility team? Thank you again!

@curib we're waiting on https://github.com/microsoft/vscode/pull/152260 to be approved & merged, so hopefully within the next week.

@misolori , hi , accessibility team says it still fails on light theme. (Dark theme seems fine) They will post screen shots here. Has it been tested on light theme?

in dark theme it works well
in light mode it fails

version used
Version: 1.69.0-insider (user setup)
Commit: 0b3574dcef8f35fec4ee4f83dc958c1f16ef6fce
Date: 2022-07-01T05:17:04.343Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22000


Suggestion:Documentation httpPayload target string enum

Perhaps it should be maid clearer that the httpPayload trait can target string enums too
https://smithy.io/2.0/spec/http-bindings.html#httppayload-trait

The trait selector in the httpPayload trait documentation specifies that the trait can be applied to string members (member > :test(string,...)). String enums are a special case of strings as documented in the base spec (see: https://smithy.io/2.0/spec/model.html#shapes).
Im not sure additional documentation is necessary here as the base spec seems to cover this case. However, if more folks run into this Ill re-open the issue and re-assess.


net: FIN_ACK takes a long time with Go

Go version
<=1.22
Output of go env in your module/workspace:
Generic Linux

What did you do?
Depending on how load tests calculate "time to complete request", Go tends to either perform well, poorly or somewhere in the middle. It took quite a while to figure out what is happening, but I have been unable to determine WHY it is happening, and I'm beyond my expertise here, so I'm handing this off to you guys in the hopes that someone smarter than me can figure it out.
What did you see happen?
When under load, Go tends to delay FIN_ACK packets by up to ~600ms. Other languages (C was mainly compared, though also Rust) do not seem to have this issue. This can skew load tests if they are waiting for the FIN_ACK packet before sending another request, which some load testing tools appear to do (hey, was the tool this was noticed with).
This was measured via performing load tests and taking a packet capture, then examining the time between FIN and FIN_ACK packets.
What did you expect to see?
I expected to see FIN_ACK packets be emitted in a more reasonable amount of time (0-50ms).

please show a reproducer for the issue.

I mean, if you're serious:
package main

import (
	"fmt"
	"net/http"
)

func handler(w http.ResponseWriter, r *http.Request) {
	fmt.Fprint(w, "Hello World")
}

func main() {
	http.HandleFunc("/", handler)
	http.ListenAndServe(":8080", nil)
}

should reproduce the issue just fine.

Can you please post a packet capture of what you are seeing (.pcap and .pcapng files are welcome), and or the benchmark tool that reports 600ms so someone can see the 600ms results you are seeing on their machine ?
The code you sent implements HTTP 1.1 and net/http tries really hard to not rely on FIN for signaling the end of requests (ideally we use Content-Length to signal end of requests, else chunked encoding is used, and then if neither are possible then we close the TCP connection).
It is important to eliminate that we are not waiting ~600ms because the HTTP server wants to allow the client to reuse the TCP stream to send an other HTTP request which a non HTTP 1.1 compliant benchmarking tool would incorrectly understand as the server being slow.

@Jorropo:

Can you please post a packet capture of what you are seeing

I can get some more packet captures, I didn't keep them around.

The code you sent implements HTTP 1.1 and net/http tries really hard to not rely on FIN for signaling the end of requests (ideally we use Content-Length to signal end of requests, else chunked encoding is used, and then if neither are possible then we close the TCP connection).

It appears to be just about any socket, h2, grpc, etc (though I haven't tested raw tcp sockets specifically).
Thanks for pointing out content-length, I'll give that a test as well to see if it improves things. It's also a bit worrisome since once a stream is closed you aren't getting any more data out of it, even if content-length says there is more data.

It is important to eliminate that we are not waiting ~600ms because the HTTP server wants to allow the client to reuse the TCP stream to send an other HTTP request which a non HTTP 1.1 compliant benchmarking tool would incorrectly understand as the server being slow.

I may be wrong, as I'm not a network engineer, by any means, but IIRC, once a FIN packet is sent, the client cannot send any more data even if it wanted to; at least on that connection.
I'll write some low-level clients in C so we can better test this as well. I'd also like to rule out network hardware, if at all possible.


Undefined user agent

On getFingerprint:
var userAgent = browserData.ua;

this get undefined. Should be changed to:
var userAgent = browserData().ua;

My mistake. Sorry!


collapsePathways similar function?

In the absence of parent terms, is there any code that could do the equivalent of collapsePathways() function to reduce redundancy of significant terms? Thanks!

Excellent question!  There is not currently, but that is functionality that we should consider adding.
There is so much more that I would like to do with this project...


make image inputs compatible with langchain_ollama

why are we removing tool call ids? I believe that's a feature of e.g. mistral v3. Is it not compatible with some other models?

This is the definition of Message in ollama, it does not include tool_call_id so I removed. Lmk if that is the wrong approach:
class Message(TypedDict):
  """
  Chat message.
  """

  role: Literal['user', 'assistant', 'system']
  "Assumed role of the message. Response messages always has role 'assistant'."

  content: str
  'Content of the message. Response messages contains message fragments when streaming.'

  images: NotRequired[Sequence[Any]]
  """
  Optional list of image data for multimodal models.

  Valid input types are:

  - `str` or path-like object: path to image file
  - `bytes` or bytes-like object: raw image data

  Valid image formats depend on the model. See the model card for more information.
  """

  tool_calls: NotRequired[Sequence[ToolCall]]
  """
  Tools calls to be made by the model.
  """


Equivalent to pip show

How would this feature be useful?
I want to show information about a package, e.g. the installed version, dependencies etc.
Describe the solution you'd like
Just like the original pip, pip show should be there, but that command does not exist, appearently.
See https://stackoverflow.com/q/10214827/5008962
Describe alternatives you've considered

Dunno, how do I show the installed version of a package then??

Also list behaves differently than in pip, so I also cannot list the version there. (it seems to show me no libs)
Aaand, show the version number with list, even if I inject a package, I have no clue what version it installed…

I’d rather this feature is not duplicated in pipx, personally. Just use pipx runpip for this.

Version numbers for the main package are currently displayed with pipx list.
Version numbers for injected packages with pipx list --include-injected are in the development version of pipx and will be in the next release.

$ pipx runpip <pipx-venv-name> show <specific-package>

Closing, use runpip with show.


Rewrite pluralize to be more generic and future proof for localized translation of UI elements

I re-wrote the pluralize function to take an object that has translated text for each plural category of given languages and removed the hardcoded rules for appending text to existing words that only works for certain words in English. Although we only support English today, this allows us to more easily bring in alternate translations when we have them (and removes the existing logic that would be difficult to maintain as our UI vocabulary grows). All of the existing use cases of pluralize were fixed to use this new API.

\cc @dobromir-hristov

This looks great to me. I wonder a few things:

Should we extract such text strings to language files, so its easier to maintain and reduce clutter in the vue files?

Definitely in the future. I think once we start working on localization in the future, it would totally make sense to create some abstraction for having constants that refer to separate files where translations/pluralities are stored separately in JSON or strings files or whatever. I'm not sure we need it at the moment since we're only doing this for one piece of data.


spatial/r3: remove duplicated API

Mainly colour and movement. The Matrix method is deleted as extraneous, and it never got into a release, so it's not breaking; everything else otherwise just works the same way that it did and the new tests in #1774 are hooked into the old code.
Please take a look.

Codecov Report

Merging #1776 (37e6052) into master (f4e7114) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1776      +/-   ##
==========================================
- Coverage   73.41%   73.25%   -0.16%
==========================================
  Files         522      505      -17
  Lines       61709    61058     -651
==========================================
- Hits        45304    44729     -575
+ Misses      13852    13801      -51
+ Partials     2553     2528      -25

Impacted Files
Coverage Δ

spatial/r3/mat.go
65.55% <ø> (-4.35%)
:arrow_down:

spatial/r3/vector.go
95.83% <ø> (+7.12%)
:arrow_up:

spatial/r3/mat_unsafe.go
71.79% <100.00%> (+3.54%)
:arrow_up:

spatial/r3/rotation.go
100.00% <100.00%> (ø)

internal/asm/c64/conj.go
0.00% <0.00%> (-100.00%)
:arrow_down:

graph/formats/rdf/graph.go
71.23% <0.00%> (-0.46%)
:arrow_down:

spatial/r3/mat_safe.go

internal/asm/f64/l2norm_noasm.go

graph/internal/set/same_appengine.go

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4e7114...37e6052. Read the comment docs.


[getters] introduce the columnTypes getter

columnTypes is the columnName → columnType map for the current dataset.
This will avoid lines as below to proliferate:
const type = this.columnHeaders.filter(h => h.name === this.editedStep.search_column)[0].type;

since we can now use:
const type = this.columnTypes[this.editedStep.search_column];

Codecov Report

Merging #274 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
+ Coverage   95.92%   95.92%   +<.01%
==========================================
  Files          76       76
  Lines        1618     1621       +3
  Branches      249      249
==========================================
+ Hits         1552     1555       +3
  Misses         66       66

Impacted Files
Coverage Δ

src/components/stepforms/FilterStepForm.vue
96.96% <100%> (ø)
:arrow_up:

src/store/getters.ts
100% <100%> (ø)
:arrow_up:

src/components/stepforms/FillnaStepForm.vue
96% <100%> (ø)
:arrow_up:

src/components/stepforms/ReplaceStepForm.vue
97.05% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e2120b...0be365d. Read the comment docs.


Set skip_waiting_for_ssh_host_keys while Importing a Server

If this attribute is not set, Terraform wants to always destroy and recreate a the server while importing.

oh wow, how did you catch that?


Attempt to sync with master

@abonil91 ok I gave this a shot but need you to review that I haven't removed any of your work.


Cannot place text where i need it to be, or i just don´t understand it

Question about an existing feature
What are you trying to achieve?
Hi.
I am trying to add text to an image. It should be placed in the bottom of the image, in a new white area that i first create using "extend".
But regardless of what i try, the text is only centered on my image.
How can i place it in bottom of image using composite?
When you searched for similar issues, what did you find that might be related?
All i could find was how to generate text using SVG, but i am using the "built-in" composite function to generate the text, so i am unsure if any of the SVG info i find is helping in this case?
Please provide a minimal, standalone code sample, without other dependencies, that demonstrates this question
This is my code to extend image and place text.
image = await image.extend({
          bottom: 50,
          background: {
            r: 255,
            g: 255,
            b: 255,
            alpha: 1
          }
        })
        .composite([{
          input: {
            text: {
              text: textContent,
              rgba: true
            },
            gravity: "south"
          }
        }])

Please provide sample image(s) that help explain this question
This is regardless of input image.

Try moving gravity to be a sibling of input rather than a descendant:
.composite([{
  input: {
    text: {
      text: textContent,
      rgba: true
    }
  },
  gravity: "south"
}])

https://sharp.pixelplumbing.com/api-composite

Thanks, that was actually the only level i din´t test.
I thought it was to "far out", but now looking at it it makes sense.


Automated cherry pick of #6810: fix: 避免openstack磁盘和存储窜位

Cherry pick of #6810 on release/3.1.
#6810: fix: 避免openstack磁盘和存储窜位

Codecov Report

Merging #6813 into release/3.1 will decrease coverage by 0.37%.
The diff coverage is 9.72%.

@@               Coverage Diff               @@
##           release/3.1    #6813      +/-   ##
===============================================
- Coverage         7.48%    7.11%   -0.38%
===============================================
  Files              585      600      +15
  Lines            98953   105876    +6923
===============================================
+ Hits              7411     7528     +117
- Misses           90970    97774    +6804
- Partials           572      574       +2

Flag
Coverage Δ

#aFlag
7.11% <9.72%> (-0.38%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/cloudcommon/policy/policy.go
1.58% <ø> (+<0.01%)
:arrow_up:

pkg/cloudcommon/policy/resources.go
0.00% <ø> (ø)

pkg/cloudprovider/objectstore.go
2.51% <0.00%> (-0.01%)
:arrow_down:

pkg/cloudprovider/securitygroup.go
0.00% <0.00%> (ø)

pkg/compute/guestdrivers/managedvirtual.go
0.00% <0.00%> (ø)

pkg/compute/models/buckets.go
1.24% <0.00%> (ø)

pkg/compute/models/cloudproviders.go
0.96% <0.00%> (-0.01%)
:arrow_down:

pkg/compute/models/disks.go
0.55% <0.00%> (-0.01%)
:arrow_down:

pkg/compute/models/guestdisks.go
0.58% <ø> (+0.01%)
:arrow_up:

pkg/compute/models/regiondrivers.go
20.00% <ø> (ø)

... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f98104a...9def31d. Read the comment docs.


Issue with HashManager and the config

After installation plugin seems to be working but I'm not able to create a new user. Backend or Frontend throwing the same error:
"Undefined property: Illuminate\Hashing\HashManager::$config" on line 95 of C:\xampp\apps\xxxx\yyyyy\vendor\laravel\framework\src\Illuminate\Hashing\HashManager.php
October v2, Plugins were installed from project.
Any thoughts ?

Found the issue with different plugin and the third party Laravel package gloudemans/shoppingcart. I'm still in development of one small private plugin and I've tried to install gloudemans/shoppingcart from the root folder of the project, it has these issues:
Problem 1
- Root composer.json requires gloudemans/shoppingcart ^2.6 -> satisfiable by gloudemans/shoppingcart[2.6.0].
- gloudemans/shoppingcart 2.6.0 requires illuminate/support 5.1.* || 5.2.* || 5.3.* || 5.4.* || 5.5.|| 5.6. || 5.7.* -> found illuminate/support[v5.1.1, ..., 5.7.x-dev] but these were not loaded, likely because it conflicts with another require.

Hey @flyingbaba,
Indeed October v2 uses Laravel 6 and this is likely why the package won't install or has introduced an incompatible interface. You may need to contact this package author to ask if they are planning on supporting newer Laravel versions.
I hope this helps!


Non-specified kinetic energy variable in addGHMCStep

In https://github.com/choderalab/perses/blob/master/perses/annihilation/ncmc_switching.py#L911-L922 there are two kinetic energy variables, "kinetic" and "ke". However ke is never actually added to the set of global variables so it causes the NCMCGHMCAlchemicalIntegrator to behave improperly.

Whoops! That is indeed a bug!

Fixing this now.


spinnerwheel v.2.0

Guys, I've checked all the tickets for this repo, and marked items which are relevant to 2.0 version as 'fdev'.
While I'm getting my thoughts together, feel free to write your own ideas/suggestions for 2.0 version here.
Let's make Spinnerwheel great again!
Thanks.

What comes to mind first: it will be using Canvas, extending AdapterView. Year selection in stock Android will be used as design reference, but not that much (because it is SO basic).
Features to think of in no particular order:

Handling ripple effects (enabling/disabling/customizing?), maybe implementing my own (like ripples from bouncing)
Different sizes for scrolling items
Implementing some kind of viewportSize/totalSize (like for scrollViews)
overscrolling support
initial value (animated/non-animated)
customizable dimming
customizable effects/styles for selected item (including background)
support for layers (like animated arrow pointing to active element)

it seems there's lotsa decent wheel libraries out there, not sure it makes sense to write yet another one


feat: adds get/set config functions

WHY are these changes introduced?
Addresses ENG-7167 - Adds a setConfig and getConfig to the cart client.

WHAT is this pull request doing?

Adds a getConfig method that returns the string options passed to createCartClient
Adds a setConfig method to allow you to update the language and countryCode

How to Test

Checkout this branch mdarrik/shopify-cart/ENG-7167-add-setConfig-properties-to-cart
Run npm run test:ci - all tests should pass
Run npm run build - should build successfully
To test in a local repo - use npm link and try calling getConfig to see the options used in the cart, and test updating the language/country with setConfig

Personally, I find the results of getConfig somewhat unintuitive. I think it might make more sense to only return properties from getConfig that are settable in setConfig. I think it'd be perfectly fine to remove shopifyShopId from shopifyStorefrontAccessToken from the getConfig results, as this is something that we probably shouldn't expect devs to need to check in their code.

Yeah. I was sort of conflicted on this part of the getConfig piece. My thought on keeping it was that it provides a way to provide debugging/setup information which could be useful for merchant developers trying to debug setup, or for merchants with multiple shopify storefronts to cover their different locals. But happy to drop those fields if we think that's not all that useful/beneficial.

Ah, good to know. I think removing them from the getConfig response is probably the right move for now. We can always reevaluate that in response to feature requests etc.

or for merchants with multiple shopify storefronts to cover their different locales

For what it's worth, because of the nature of Shopify Markets, merchants should be able to accomplish international support via a single Shopify store (& token).

@NWRichmond removed those fields from getConfig. Also updated the docs to include both methods.
While I was in there I added an href to all of the method a tags so they are valid links. If we don't want them to be, we should switch them to spans instead.


if I want to train my own data, what do I need to do?

Please refer to https://github.com/michuanhaohao/reid-strong-baseline/issues/89


Is there a way to create, package and utlize custom filters for RTD?

I would like a way to create a custom filter for my RTD theme. I see that some filters are defined in theme.py inside mkdocs. Is there a way to define custom filters unique to my theme that can be utilized on RTD?

The rtd theme for mkdocs is provided by mkdocs itself, if you are able to do that locally it shouldn't be a problem in rtd. I guess you need an extension?

You can have a requirements.txt file with all your dependencies https://docs.readthedocs.io/en/latest/guides/specifying-dependencies.html


Contributing file

Overview
Create the CONTRIBUTING file
Action Items

[x] Create CONTRIBUTING file: Use information from README.md on how to use Git
[ ] Remove information from README.md on using Git

Resources/Instructions
Working file - Guide to Good Coding Practices
See this github guide for healthy repository https://docs.github.com/en/github/building-a-strong-community/creating-a-default-community-health-file
Refer to this file - https://github.com/100Automations/.github-automations/blob/master/CONTRIBUTING.md

I would like to work on this issue. Could you please let me know your requirements ?

Hi @anshdhinhgra47 thanks for getting in touch with us!
We'd love to have you on the team, please view https://www.hackforla.org/getting-started and take a look at the steps in the https://github.com/civictechindex/CTI-website-frontend/wiki for joining our project.
I'll see you on the Hack for LA slack, civic-tech-index channel!

Thank you so much for giving me this opportunity.
Could you assign me this issue ? My pull request has been pushed aside in the past, even though I was the first to approach the organization. I hope you understand.
Once again, thank you for giving me this opportunity.

@anshdhinhgra47 this particular issue is going to take an unlucky Product Manager about five minutes to do when he or she gets around to it. Please get in touch with us through channels as I described above, we'll find issues worth your talents. Looking forward to seeing you in the Hack for LA Slack!

Alright

Will change contributing file with content for README and link the content accordingly.

@mealthebear will write 5. Set up ESLint and 6. Best practices for Code Climate so we can include it in this file.

@mealthebear and @JafarIronclad will work together to create Guide to Good Coding Practices to be used in Contributing.md

@mealthebear and @JafarIronclad will work together to create Guide to Good Coding Practices to be used in Contributing.md

@kevinashworth will refine and update the contributing file to reflect his experience.

@kevinashworth will refine and update the contributing file to reflect his experience.

Progress: An improved version with text changes has been submitted as a PR. (There are remaining improvements that could be made to the content, and to the behind-the-scenes formatting of this file. Planning to submit add'l PR on those items.)
Blocks: PR approval
Availability: good
ETA: Jan 15

Progress: An improved version with text changes has been submitted as a PR. (There are remaining improvements that could be made to the content, and to the behind-the-scenes formatting of this file. Planning to submit add'l PR on those items.)
Blocks: PR approval
Availability: good
ETA: Jan 15

@kevinashworth I've approved and merged. Do another PR for any further changes you need to make.

@kevinashworth I've approved and merged. Do another PR for any further changes you need to make.


CoronaBuilder on 3684+ and Xcode 14.3 generates an error when uploading a build to the Apple App Store

CoronaBuilder on 3684+ and Xcode 14.3 results in the below error message when submitting to the Apple App Store
CoronaBuilder works fine with 3683 and Xcode 14.1.
Getting this:
Invalid Signature. A sealed resource is missing or invalid. The file at path “XXX.app/XXX” is not properly signed. Make sure you have signed your application with a distribution certificate, not an ad hoc certificate or a development certificate. Verify that the code signing settings in Xcode are correct at the target level (which override any values at the project level). Additionally, make sure the bundle you are uploading was built using a Release target in Xcode, not a Simulator target. If you are certain your code signing settings are correct, choose “Clean All” in Xcode, delete the “build” directory in the Finder, and rebuild your release target. For more information, please consult https://developer.apple.com/support/code-signing.

I had this today when I tried to build my previously Android only project for iOS - I believe this is not a bug.
Searching the forums it seems this is due to random non-project text files sitting in the main project folder.
In my case it was a readme.md file I had added for github, I added this to my excluded files in build.settings and it built immediately after ... try it!
excludeFiles =
{
  -- Exclude all Android icon files, .ogg files, git files and readme.md
  ipad = { "main.sublime-workspace", "Icon.png", "Icon-*dpi.png", "*.ogg", ".git*", "*.md" },

},


AVSBench_semantic Checkpoint

Hi,
Thank you for sharing this excellent work.
Could you please also share the checkpoints of COMBO for AVSBench_semantic?
Thank you!

Hello,
you can train the COMBO on AVSS on your own.
It would take around ~24 hours for training AVSS in a single A100-40G GPU to get a similar performance in our paper.
Note, we did not perform any specific optimization for our hyperparameters due to the time limition.
Therefore, you can obtain a better performance through hyperparameter search if you want.
Thank you!

Hi,
Thank you for your advice and instruction.
I try to train the model on my own. However, I got the FileNotFoundError after running sh scripts/res_train_avs4.sh.
It cannot find processed_frames/processed_labels_semantic/audio.pkl files.
Could you tell me the file/folder structure and content in COMBO-AVS/AVS_dataset/AVSBench_semantic?
|--AVS_dataset
   |--AVSBench_semantic/
      |-- ?
      |-- ?

Thank you!

Hello,
For question (1):
In order to save training time, we resize the video in advance.
The code is as below: process_avssimg2fixsize.py
About the audio.pkl, you should download the corresponding datasets, which contain this file.
The download link is shown below.
For question (2):
We download the AVSBench_semantic dataset from https://github.com/OpenNLPLab/AVSBench. (You should write an application form to them for this dataset.)
And the folder is as below：

Thank you!


compatibility to VueRouter is challenging

hi, thanks for this great work - I like it a lot even though it has some challenges because its lacking a closer integration with VueRouter. Background : I construct my VueRouter and vue-tree-navigation items dynamically from a simple JSON object. Doing so reveals the following issues

the vue-tree-navigation module uses a property route as routing context, VueRouter uses path - please align this to also use path
wouldnt it be great if vue-tree-navigation could be initialized in a way to pickup its items from VueRouter ? This would eliminate the steps to create config thats in sync for both

Thanks

Hey again,
as regards to 1., I checked codes in detail and spent more time on it and realized that I forgot about new behavior of v3 :) Currently, it works with router or without the router and both of these modes use route field. So it will be really better to name it path. It will be clear for people who want to use the library with router because we are all used to this name. And for people who don't want to use it together with router, path will be actually more intuitive name, too.
Thanks for noticing!

Implemented. Will be released as v4.0.0.


process.extract does not work with set objects

Calling process.extract with a set object currently causes a TypeError.  This occurs when accessing the set using an index:
# copy elements into Python List
result_list = PyList_New(<Py_ssize_t>limit)
for i in range(limit):
    result_item = (choices[results[i].index], results[i].score, results[i].index)
    Py_INCREF(result_item)
    PyList_SET_ITEM(result_list, <Py_ssize_t>i, result_item)

Similar to the code for the dictionaries it should already store the pointer of the in the result list, so it does not require this access.

The same applies to generators.

Fixed in https://github.com/maxbachmann/RapidFuzz/commit/1bfea8f462a7db752a284772d0229c79cd1946ee


[Bug] [Module Name] Health check failed

Search before asking

[X] I had searched in the issues and found no similar issues.

Operating system information
Linux
Python version information

=3.11

DB-GPT version
main
Related scenes

[ ] Chat Data
[ ] Chat Excel
[ ] Chat DB
[ ] Chat Knowledge
[ ] Model Management
[ ] Dashboard
[ ] Plugins

Installation Information

[ ] Installation From Source

[ ] Docker Installation

[ ] Docker Compose Installation

[ ] Cluster Installation

[ ] AutoDL Image

[ ] Other

Device information

Models information

What happened
在服务器部署DBGPT服务后，一段时间（可能几分钟、可能几小时）刷新页面会一直出现WARNING Health check failed for http://<IP_ADDRESS>:5670, error: HTTPConnectionPool(host='<IP_ADDRESS>', port=5670): Read timed out. (read timeout=10)，我调的是zhipu api，服务器也没什么问题，想知道可能原因是什么？
What you expected to happen

How to reproduce

Additional context
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

请问解决了吗


add a "Click to copy code" button

Is your feature request related to a problem? Please describe.
All popular website like tailwind css and documentation websites have a common feature of "Click to copy code" button on every code snippet. I believe we can also implement the same feature on our /learn platform
an example from our online /learn code editor.

Describe the solution you'd like
users should be able to click and copy code through a small button on top right position of the code snippet
something like this example from Shadcn UI

Describe alternatives you've considered
.
Additional context
No response

@Nirajn2311 @naomi-lgbt  @scissorsneedfoodtoo

I'd push back against this, actually.
There aren't many steps where we ask campers to copy code. Adding a button is just going to result in more forum posts for all of the steps where we have generic example code that campers think they should copy because of this button.

Sorry @JoyShaheb, it does not seem like a good idea to me either. It also just adds more clutter. We should keep that to a minimum.


Fix: sed compatible with mac os env

sed -i need explicit extention on mac, but linux is optinoal.
so for developer need a compatible request on macos

LGTM, thanks.


Extension Host terminated unexpectedly

VSCode Version: 1.46.1
OS Version: Windows_NT x64 10.0.18363 (Win 10 Pro 1909)

Steps to Reproduce:
As soon as I start working on any project, this issue arises.
The following steps have been tried to no avail:

code --disable-extensions
Reinstalling
Disabling/renaming extensions dir
Installing VC Studio Code Insiders (same issue)

Does this issue occur when all extensions are disabled?: Yes
Regards
Holger

I do not know why, but after some windows restarts, the error has gone?!?
Maybe a windows update?
So i will close the ticket.


Include cohorts in Ag3 sample metadata

The cohort metadata are very useful and it would make life easier if they were included with the sample metadata by default, rather than having to separately load and merge the sample metadata and cohort metadata dataframes. To implement this, the following changes could be made:

Modify the signature of the Ag3.sample_metadata() method to include a cohorts_analysis parameter with a default value to the latest cohorts analysis.
Modify the implementation of the Ag3.sample_metadata() method to load the cohorts metadata and join it to the general sample metadata, if the cohorts_analysis parameter is not None.

Note that a potential problem with doing this is that some future releases may be released before a new cohorts analysis is performed including it. In this case the release would have sample metadata but no cohorts metadata. This could be mitigated by either (a) ensuring we always run a cohorts analysis immediately following each release and before partners are notified, and/or (b) building in some logic to handle missing cohort files.

Hi @alimanfoo, I think the best thing to do with cohorts metadata is to always generate straight after a release, before informing partners. I feel the benefits outweigh the short delay.

Hi @alimanfoo, I think the best thing to do with cohorts metadata is to always generate straight after a release, before informing partners. I feel the benefits outweigh the short delay.

Hi Chris, yes I'm with you, let's go for that option and see how it works out.


Add select e2e test to demo issue when select within include

First thanks for the awesome project!
I found an issue in my production code so here is the e2e test to reproduce it.
When I select only some fields in a nested table, and the select clause is within another include clause, this bug happens. It doesn't automatically filter the deleted nested items any more. If I explicit select the deleted field, then it works as expected.
If you run this test, you will see findFirst with include and select is failed, but findFirst with include and select deleted field is passed.
Failed test:
 FAIL  test/e2e/select.test.ts
  ● select › findFirst › with nested select › findFirst with include and select

    expect(received).toHaveLength(expected)

    Expected length: 1
    Received length: 2
    Received array:  [{"id": 1}, {"id": 2}]

      224 |         expect(foundUser!.posts).toHaveLength(1);
      225 |         // TODO: this should be 1
    > 226 |         expect(foundUser!.posts[0].comments).toHaveLength(1);
          |                                              ^
      227 |         expect(foundUser!.posts[0].comments[0].id).toBe(comment1.id);
      228 |       });

I suspect it's due to this part of the code, as it skips the recursion:
https://github.com/olivierwilkinson/prisma-extension-soft-delete/blob/b64da3edecf6010b00bb3eeb225f22b5e8d5d949/src/lib/helpers/createParams.ts#L416-L420
But I'm not sure yet what's the right fix, or if there are any other pitfalls ahead.

Thank you for raising this, and for the e2e test!
I'm not sure right now what the fix is, but I will get to it as soon as I can 😄
I'm glad you are finding the library helpful, please don't hesitate to raise any other issues you find or any ideas you have 🙏


Add in Pyne Module Support and user Selection of Decay Method

Add in support for the Pyne module. See https://github.com/pyne/pyne/issues/1223 for details on how this can be done.

Issues with some Pyne decay chains, particularly metastable nuclides. May be some issues with restricting the knonw chains.


Enhance sample app

Updated sample app ✌  with following features

Loading multiple resources (quotes) from API page-by page 🔍.
Updated app to use material design 🎉 .
Also included circular reveal animation on quote card between page change .
To show loading state, progress bar ⚡ is shown till quote loads

https://user-images.githubusercontent.com/34616118/117104706-42aaf100-ad9a-11eb-8dc9-64be5dedea3e.mp4

This seems great enhancement. Great work.


Dotted notation for declaring class methods

This is a way I figured out of declaring methods without too much effort on the transpiling side
data List = Cons x xs | Nil;

List::append = \a b -> case a of
    Nil -> b
  | Cons x xs -> Cons x (xs.append b);

We'll end up putting these onto the prototypes of the List objects and having Cons and Nil extend from those. But we'll also want append to be available by itself, and for dispatch to happen on it. So you could define append for List but also for Set or something if you wanted to.

Insetad we're going to go with a :: notation. This will let me easily detect this.
How this will work is that this will get put as ```
List.prototype.append = function(arg){ return function(a){ return function(b){ ... }}(this)(arg)}

The double application will give us python-like "self" behaviour

This doesn't support constant values for now... we'll work on this later

implemented in #25


The fromDate in searches should be local time, not UTC

This wasn't intuitive to me, but the value passed to fromDate when searching activities should be local time, not UTC.
You can read more on this thread on the SmashRun forums.
It sounds like they may expose a fromDateUTC argument that would be suitable for the value generated by to_timestamp in this library.

Oh thanks for reporting this.
I think I just assumed that the fromDate was UTC without bothering to confirm...
I'll try to fix this and make a new release tonight.

@nall I created a PR (#7) that I think addresses this. I will merge it in in a few day if you don't have any objections.

I verified with that change I can backout my current workaround. Looks good, thanks!


[v7.0.1] Bug define custom Expressions not working

the sift.use function is no longer available.

Intentional as of 7.0.0

Remove global *.use() function.

But why?

I should have added a reason to that changelog, sorry about that.
The motivation behind removing the use was to make sift more pure & without side effects. I'd be happy to re-add this functionality in a different form, like:

// sift(filter[, array][, selectorFn][, customExpressions])
import { sift } from "sift";

const CUSTOM_EXPRESSIONS = {
  $mod: (a, b) => a % b;
};

const customSift = (query, values) => sift(query, values, null, CUSTOM_EXPRESSIONS);

const evenValues = customSift({ $mod: 2 }, [1, 2, 3, 4, 5]); // [2, 4]

What do you think?

The use function was great for creating lean queries for domain-specific problems. I see no problem in your proposal.
I would be happy if I could upgrade my apps to version 7 ;-).
thank you!

Awesome, I'll get around to adding this functionality later this week. Expect use to land in 7.1.0. 😄

Might save yourself some future-troubles if that fourth argument is a level deeper, like
{
  expressions: {
    $mod(value, arg) { return value % arg }
  }
}

Then if you need options for something else going forward the signature won't change.


Add Rhino 7 Yak deployment

https://github.com/arup-group/GSA-Grasshopper/blob/e329d51c50587e988c3c15f682385cfc73261b7b/.github/workflows/yakdeploy.yml#L36
from https://developer.rhino3d.com/guides/yak/creating-a-grasshopper-plugin-package/ :
Currently, if you publish a package with a rh6* distribution tag, it will not be installable for Rhino 7. If your plug-in also works in Rhino 7, please mark it as compatible by copying the .yak file, updating the distribution tag part of the filename (i.e. rh6_18 ➡ rh7_0) and pushing both to the package server.

Rhino 7 yak support added


Missing fields in pipeline reports when pipeline process fails

Description of the bug
The error handling in the pipeline can make certain fields relied on for reporting do not get populated. This issue is due to both processes running on cloud executors failing but also the default logic in handling errors allowing the pipeline to continue.
This issue will need to be resolved by getting feedback from users on preferred error handling. E.g. Failing hard on process failure potentially requiring a pipeline to be run again even if it was a pipeline utility causing failure or allowing the default behaviour to retry and ignore errors to persist.
Once issues in cloud execution are resolved, it would be worth testing this issue further.

Issue https://github.com/phac-nml/mikrokondo/issues/87 is related to this one. But more testing in cloud environments is required.

Issue is addressed in: https://github.com/phac-nml/mikrokondo/pull/102


errors object is not iterable

It  would be nice to have the errors object iterable. Is there an implementation limitation that precludes this?
Right now I'm having to suck the objects myself, via duplicated (once in validations:{}) hard-coded properties:
collectionItemErrors.getProperties("collectionItemImage", "authors", "publisher", "title", "publishedOn", "copyright", "credit");

From what I understand you want to get all the error messages? If that is the case here is a way is easier to yours and keys agnostic:
In your component/controller/etc:
Object.keys(x).map(key => x[key]).reduce((a,b) => a.concat(b), []);

In your template:
{{#each-in errors as |field fieldErrors|}}
  {{#each fieldErrors as |fieldError|}}
    {{!-- Do something with the fieldError here --}}
  {{/each}}
{{/each-in}}

Beware that each-in does not refresh automatically when errors change. Personally I ended up creating a simple component with the template solution when I want to display all the validations errors.

I am going to close this issue for now, feel free to reopen this issue if you feel like it's still relevant and we should take a look at it.


German translation for 1.0.25

I squashed your pull-request because there are too many commits, anyway it's merged now. Thanks.


Revert "update isosceles test"

Reverts exercism/xswift#105

https://github.com/exercism/xswift/issues/104

I'm tempted to suggest taking out the edge case, since the distinction between degenerate triangles and "not a triangle" is so subtle, and kind of beside the point here. What do you think?

I agree with this.


Rubinious scraper

closes #1

There are some flaws with this so far.

rubinius' version scheme is X.Y, whereas the build definitions in ruby-build use X.Y.0. Presently, this scraper emits build definition filenames matching rubinius' scheme, so it currently conflicts with ruby-build itself.
rbx builds >=3.0 install openssl-1.0.2e, whereas rbx builds 2.6 - 2.11 install openssl-1.0.1q. Presently, this scraper just uses 1.0.2e for everything, so pre-3.0 defs are wrong (maybe?)

Thoughts from @mislav on the above issues?

rbx builds >=3.0 install openssl-1.0.2e, whereas rbx builds 2.6 - 2.11 install openssl-1.0.1q.

Not sure which is the right one, but let's always use latest OpenSSL for everything.

rubinius' version scheme is X.Y, whereas the build definitions in ruby-build use X.Y.0.

Let's normalize the scheme to always be 3 numbers at least.
num_components="$(tr . $'\n' <<<"$version" | wc -l)"
[ $num_components -ge 3 ] || version="${version}.0"

Not sure which is the right one, but let's always use latest OpenSSL for everything.

Do you want the existing 2.* rbx definitions in ruby-build updated to newer OpenSSL? (It's trivial now that the scraper is working)

accidental close

As mentioned by @mislav in https://github.com/rbenv/ruby-build/pull/881#issuecomment-172417233, the rubinius checksums don't really offer much value since they are published at the same place as the downloads. (I partially disagree, since the checksums can still catch accidental corruption and/or lazy bad-actors. But they certainly won't help against competent malicious activity.)
Should the checksums be removed from the build defs for now? This solves the rubinius version issue, since they re-publish builds under the same version number. It removes the need for ruby-build to support 512-bit checksums (for now, at least). And it removes any false sense of security one has in the same-host checksums.

Yes I think ultimately we'll drop checksums from rbx definitions.


[ScrollView] How can make a 'onScrollEnd' listener on ScrollView ?

I want to make a general web page style component which include some introduction on the top and a Scroll-End-Load list on the bottom. Just like this.

How can I know the scrollView has been scrolled to the end ? Is there some props on scrollView can be use ?
And by the way,  Is it a bad usage if I put a ListView inside to ScrollView? ( I had try to do this , but feel uncomfortable when scrolling  )
So What is the best plan to put a dynamic loading list into a scrollView?

onEndReached

@brentvatne answered.

I kinda have the same question right now. How to do it with a ScrollView and not a ListView?  onEndReached gets only triggered by the ListView?

Since you control the content that goes into a ScrollView, between computing the layout of said content and listening to scroll events you should be able to determine when you've reached the end of the ScrollView.

@ide Thank you, I will try that. I read about "renderHeader" in the ListView documentation. Does the Header stay fixed or does it scrolls away? Because that is the reason I have to use the ScrollView every time instead of the ListView. I need the "Header" to scroll naturally away.

It's not fixed -- there's nothing special about the header really.

@ms88privat I've find the way that how to know scrollEnd in ScrollView just like this:
onScroll={(e)=>{
    var windowHeight = Dimensions.get('window').height,
        height = e.nativeEvent.contentSize.height,
        offset = e.nativeEvent.contentOffset.y;
    if( windowHeight + offset >= height ){
        //ScrollEnd, do sth...
    }
}}

But now I've turn to use ListView , and renderHeader meets my need too. :smile:


On some machines GUI is not displayed properly in the terminal.

The problem might be that the given terminal does not allow special chars. Why the first column is cut, however, I cannot explain.

Can confirm, seen on Ubuntu 16.04.3 LTS

I'm on it. Any info on what type of console you are using?

Could somebody please confirm if the problem still persists and report in such a case what kind of terminals fail? The terminal that I used to reproduce the issue looks acceptable on 0.2.2 now.

It's not in 0.2.2, yet. Please wait for 0.2.3

fixed


Mango to nodes

Overview
Move mango selector matching to the shard level
This moves the Mango selector matching down to the shard level.
This would mean that the document is retrieved from the index and
matched against the selector before being sent to the coordinator node.
That way only the documents that match the query are sent to the coordinator node.
Testing recommendations
Mango tests should all pass
Checklist

[x] Code is written and works correctly;
[x] Changes are covered by tests;
[ ] Documentation reflects the changes;

Also, have you had a chance to do any sort of performance testing with this? It seems like it'd be helpful but I'm having a bit of premature-optimization-itis wondering if it makes any difference in practice. I can certainly dream up some scenarios where it'd help a cluster in a specific set of circumstances but I can't remember ever having seen such issues crop up in production.

Thanks for reviewing @davisp and @tonysun83 I'm going to setup and run some perf tests on this, this week.

I've run some perf tests on this. First a very basic performance test. Below are metrics for network traffic between nodes. The first image is for current mango. The second image is CouchDB with this PR.

The graphs are not at the same scale which is a bit frustrating. There is no regression and a slight improvement on network traffic.
Then I ran a full regression test:

There are no regressions and in some cases a nice performance improvement.

From what I see there's basically no difference. For the network traffic graphs it looks maybe a bit less on the front end but then spikes badly on the second half. And if memory serves you were attempting to have a best case scenario for this test by restricting results to an empty set. Given there's not a dramatic difference I'm hesitant on whether this change is actually providing any benefit.
The regression tests I think are even more indicative of this not having much if any effect on the results. Your largest median change on a single test is only 23ms and it looks like nearly half of them are measuring nearly exactly the same suggesting this PR isn't providing a measurable difference.
Can you describe the tests you did for the network graphs? Perhaps we missed something there or we can figure out how to measure things better?

Up to you whether you want to keep it open or closed. We can always re-open later if you get more time for perf testing as well. Also agree that I would have expected a much starker difference which suggests we're either missing something (like maybe that timeout you found) or there's some other bottleneck that prevents this from having a noticeable effect. Doesn't mean we don't want to pursue this, just that we need to investigate more to figure out what's up before we can merge it.

+1, great work @garrensmith


WFLY-19142 Update the OIDC tests to use the 24.0.1 version of quay.io/keycloak/keycloak

https://issues.redhat.com/browse/WFLY-19142

Thanks @xstefank and @fjuma


JSON errors, mistakes and forgotten pieces in block files

blocks:

fence gates missing comma after first this_received_power function sound
slabs missing comma between upper and lower slab properties
leaves missing comma after transparent option
attached stems are missing a comma in the function placed stem
some blocks (at least barriers and cauldrons) still have cull_faces
some blocks (at least beacons and cobwebs) have tabs
concrete powder functions can be compacted (they respond to all block_changed ones already)
shulker box and chest open check of facing=up misses commas for vines states
shulker boxes miss comma after down face property of facing=north
comparator/repeater changing powered state functions miss commas in the received power details
chest state values uses {} rather than []
turn to single chest functions misses “name”: in front of “minecraft:chest”
dirt function misses comma after z values
portals have full sound events
furnace BurnTime still quoted
green concrete misses comma
creeper wall head has a comma after the loot table
ice because of cull_faces, remove the lines and it’s fine
hopper and 2 high plants missing command in front of the the state data
note blocks (unknown cause atm)
observers are missing a comma after state defining
portal misses last closing bracket
redstone wire missing “minecraft:tick”:
repeating command block missing one “value”: in in nbt condition

items:

buttons, slabs, trapdoors and lever missing commas after block face
cake missing comma after stack size
music discs and oxeye daisy missing comma after position
shears missing closing bracket after green sheep shearing

entity tags:

pressure plate activators double ocelot and missing comma after armor stand
wooden pressure plate activators missing comma after end crystal
fire resistant missing comma after ghast

found them all, except note block’s

Note blocks are fine

Lots of trailing commas in these places

Complete list of invalid JSON files:
minecraft/assets/minecraft/texts/credits.json
minecraft/assets/minecraft/texts/end.json
minecraft/assets/minecraft/texts/splashes.json
minecraft/data/minecraft/blocks/acacia_fence_gate.json
minecraft/data/minecraft/blocks/acacia_leaves.json
minecraft/data/minecraft/blocks/acacia_slab.json
minecraft/data/minecraft/blocks/attached_melon_stem.json
minecraft/data/minecraft/blocks/attached_pumpkin_stem.json
minecraft/data/minecraft/blocks/birch_fence_gate.json
minecraft/data/minecraft/blocks/birch_leaves.json
minecraft/data/minecraft/blocks/birch_slab.json
minecraft/data/minecraft/blocks/black_shulker_box.json
minecraft/data/minecraft/blocks/blue_shulker_box.json
minecraft/data/minecraft/blocks/brick_slab.json
minecraft/data/minecraft/blocks/brown_shulker_box.json
minecraft/data/minecraft/blocks/chest.json
minecraft/data/minecraft/blocks/cobblestone_slab.json
minecraft/data/minecraft/blocks/comparator.json
minecraft/data/minecraft/blocks/creeper_wall_head.json
minecraft/data/minecraft/blocks/cyan_shulker_box.json
minecraft/data/minecraft/blocks/dark_oak_fence_gate.json
minecraft/data/minecraft/blocks/dark_oak_leaves.json
minecraft/data/minecraft/blocks/dark_oak_slab.json
minecraft/data/minecraft/blocks/dark_prismarine_slab.json
minecraft/data/minecraft/blocks/dirt.json
minecraft/data/minecraft/blocks/ender_chest.json
minecraft/data/minecraft/blocks/gray_shulker_box.json
minecraft/data/minecraft/blocks/green_concrete.json
minecraft/data/minecraft/blocks/green_shulker_box.json
minecraft/data/minecraft/blocks/hopper.json
minecraft/data/minecraft/blocks/ice.json
minecraft/data/minecraft/blocks/jungle_fence_gate.json
minecraft/data/minecraft/blocks/jungle_leaves.json
minecraft/data/minecraft/blocks/jungle_slab.json
minecraft/data/minecraft/blocks/large_fern.json
minecraft/data/minecraft/blocks/light_blue_shulker_box.json
minecraft/data/minecraft/blocks/light_gray_shulker_box.json
minecraft/data/minecraft/blocks/lilac.json
minecraft/data/minecraft/blocks/lime_shulker_box.json
minecraft/data/minecraft/blocks/magenta_shulker_box.json
minecraft/data/minecraft/blocks/nether_brick_slab.json
minecraft/data/minecraft/blocks/note_block.json
minecraft/data/minecraft/blocks/oak_fence_gate.json
minecraft/data/minecraft/blocks/oak_leaves.json
minecraft/data/minecraft/blocks/oak_slab.json
minecraft/data/minecraft/blocks/observer.json
minecraft/data/minecraft/blocks/orange_shulker_box.json
minecraft/data/minecraft/blocks/peony.json
minecraft/data/minecraft/blocks/petrified_oak_slab.json
minecraft/data/minecraft/blocks/pink_shulker_box.json
minecraft/data/minecraft/blocks/portal.json
minecraft/data/minecraft/blocks/prismarine_bricks_slab.json
minecraft/data/minecraft/blocks/prismarine_slab.json
minecraft/data/minecraft/blocks/purple_shulker_box.json
minecraft/data/minecraft/blocks/purpur_slab.json
minecraft/data/minecraft/blocks/quartz_slab.json
minecraft/data/minecraft/blocks/redstone_wire.json
minecraft/data/minecraft/blocks/red_sandstone_slab.json
minecraft/data/minecraft/blocks/red_shulker_box.json
minecraft/data/minecraft/blocks/repeater.json
minecraft/data/minecraft/blocks/repeating_command_block.json
minecraft/data/minecraft/blocks/rose_bush.json
minecraft/data/minecraft/blocks/sandstone_slab.json
minecraft/data/minecraft/blocks/shulker_box.json
minecraft/data/minecraft/blocks/spruce_fence_gate.json
minecraft/data/minecraft/blocks/spruce_leaves.json
minecraft/data/minecraft/blocks/spruce_slab.json
minecraft/data/minecraft/blocks/stone_brick_slab.json
minecraft/data/minecraft/blocks/stone_slab.json
minecraft/data/minecraft/blocks/sunflower.json
minecraft/data/minecraft/blocks/tall_grass.json
minecraft/data/minecraft/blocks/tall_sea_grass.json
minecraft/data/minecraft/blocks/trapped_chest.json
minecraft/data/minecraft/blocks/white_shulker_box.json
minecraft/data/minecraft/blocks/yellow_shulker_box.json
minecraft/data/minecraft/items/acacia_button.json
minecraft/data/minecraft/items/acacia_slab.json
minecraft/data/minecraft/items/acacia_trapdoor.json
minecraft/data/minecraft/items/birch_button.json
minecraft/data/minecraft/items/birch_slab.json
minecraft/data/minecraft/items/birch_trapdoor.json
minecraft/data/minecraft/items/brick_slab.json
minecraft/data/minecraft/items/cake.json
minecraft/data/minecraft/items/cobblestone_slab.json
minecraft/data/minecraft/items/dark_oak_button.json
minecraft/data/minecraft/items/dark_oak_slab.json
minecraft/data/minecraft/items/dark_oak_trapdoor.json
minecraft/data/minecraft/items/dark_prismarine_slab.json
minecraft/data/minecraft/items/jungle_button.json
minecraft/data/minecraft/items/jungle_slab.json
minecraft/data/minecraft/items/jungle_trapdoor.json
minecraft/data/minecraft/items/lever.json
minecraft/data/minecraft/items/music_disc_11.json
minecraft/data/minecraft/items/music_disc_13.json
minecraft/data/minecraft/items/music_disc_blocks.json
minecraft/data/minecraft/items/music_disc_cat.json
minecraft/data/minecraft/items/music_disc_chirp.json
minecraft/data/minecraft/items/music_disc_far.json
minecraft/data/minecraft/items/music_disc_mall.json
minecraft/data/minecraft/items/music_disc_mellohi.json
minecraft/data/minecraft/items/music_disc_stal.json
minecraft/data/minecraft/items/music_disc_strad.json
minecraft/data/minecraft/items/music_disc_wait.json
minecraft/data/minecraft/items/music_disc_ward.json
minecraft/data/minecraft/items/nether_brick_slab.json
minecraft/data/minecraft/items/oak_button.json
minecraft/data/minecraft/items/oak_slab.json
minecraft/data/minecraft/items/oak_trapdoor.json
minecraft/data/minecraft/items/oxeye_daisy.json
minecraft/data/minecraft/items/petrified_oak_slab.json
minecraft/data/minecraft/items/prismarine_bricks_slab.json
minecraft/data/minecraft/items/prismarine_slab.json
minecraft/data/minecraft/items/purpur_slab.json
minecraft/data/minecraft/items/quartz_slab.json
minecraft/data/minecraft/items/red_sandstone_slab.json
minecraft/data/minecraft/items/sandstone_slab.json
minecraft/data/minecraft/items/shears.json
minecraft/data/minecraft/items/spruce_button.json
minecraft/data/minecraft/items/spruce_slab.json
minecraft/data/minecraft/items/spruce_trapdoor.json
minecraft/data/minecraft/items/stone_brick_slab.json
minecraft/data/minecraft/items/stone_button.json
minecraft/data/minecraft/items/stone_slab.json
minecraft/data/minecraft/recipes/crafting/sea_lantern.json
minecraft/data/minecraft/recipes/crafting/coloring/leather_boots.json
minecraft/data/minecraft/recipes/crafting/coloring/leather_chestplate.json
minecraft/data/minecraft/recipes/crafting/coloring/leather_helmet.json
minecraft/data/minecraft/recipes/crafting/coloring/leather_leggings.json
minecraft/data/minecraft/recipes/crafting/copy/map.json
minecraft/data/minecraft/recipes/crafting/pane/glass.json
minecraft/data/minecraft/tags/entities/fire_resistant.json
minecraft/data/minecraft/tags/entities/pressure_plate_activators.json
minecraft/data/minecraft/tags/entities/wooden_pressure_plate_activators.json


Difference in change logs format for change status

I observed we have different changelogs format for change status [admin down, reported, online] of servers.

     APICHANGE    Updated ADMIN_DOWN server: { }
  APICHANGE  Updated status [ ADMIN_DOWN ]

First, have Updated ADMIN_DOWN and second have Updated status [ ADMIN_DOWN ]
Second is quite common but sometimes I find first also. Do we have kept it different for any reason?

would appears to come from here:   https://github.com/apache/trafficcontrol/blob/master/traffic_ops/traffic_ops_golang/server/servers.go#L173

@tyagian Would you please provide an example that produces the first changelog message format that you observed?


Use display:none instead of opacity:0 to hide term a11y buffer

I noticed that opacity: 0 is the only thing preventing the buffer from displaying:

This is bad because it means that any resize to the container will still cause the monaco editor to layout, despite the user not being able to see it.

This might be part or all in xterm.js

Actually we need opacity so it can take the focus event 🤔, whatever we do we want to make sure monaco doesn't need to process a resize when it's hidden

could make a class that extends CodeEditorWidget for _bufferEditor with an override for layout that checks opacity and only then calls super.layout

wouldn't layout always get called with the right dimensions? why would we have to cache them?
also wouldn't have to track opacity change because we could just call layout when the accessible buffer gets focused

If we're suppressing layouts, we would need to store the last suppressed one so we can call layout when it's shown. Unless this is already happening?

we know the size of the container, so couldn't we just use those dimensions and call layout ourselves when needed IE when it's focused/becomes visible?

This is bad because it means that any resize to the container will still cause the monaco editor to layout

this doesn't get hit until I focus the accessible buffer
https://github.com/microsoft/vscode/blob/d4d02122bec716c1a86bdb02fe4b69a29c94629c/src/vs/editor/browser/config/elementSizeObserver.ts#L82

If it's only hit once that's good enough. I also noticed the editor is created eagerly on terminal startup which isn't great, but I'm assuming it's fast enough so let's tackle that if it becomes a problem.


control room enhancement: stream check

partially implemented at https://github.com/ruby-no-kai/takeout-app/pull/17
not yet: preview

done at https://github.com/ruby-no-kai/takeout-app/pull/41


optimize parted also for ext4

Instead of 0% to 100% start with 1024KiB and use parameter -s before

Code changes added. Needs testing in starting with a fresh fat32 formatted SSD and a new build sd card.

Its working so far for the v1.7.2 release ... but there is still a The resulting partition is not properly aligned for best performance warning ... moving the issue to v1.8.1 for a second look:
https://blog.hqcodeshop.fi/archives/273-GNU-Parted-Solving-the-dreaded-The-resulting-partition-is-not-properly-aligned-for-best-performance.html

Could you please change the follow line #https://github.com/rootzoll/raspiblitz/blob/b589b57215b57a0a1a97153d354a35716c4669fa/home.admin/config.scripts/blitz.datadrive.sh#L680`
to parted -s /dev/${hdd} mkpart primary ext4 0% 100% 1>&2 to fix the alignment when partitioning?

I am setting up a new pi and using a 2TB drive and found this warning.
Specifically:
Warning: The resulting partition is not properly aligned for best performance: 2048s % 65535s != 0s

I discovered 2 things:

I found the exact same blog article and using their script, I get this:

Using detected optimal_io_size alignment of 33553920 bytes in calc
Calculated alignment for /dev/sda (gpt) is: 65535s

Create partition with:
# parted /dev/sda mkpart [name] [type] 65535s<PHONE_NUMBER>s
Verify partition alignment with:
# parted /dev/sda align-check optimal 1

in the blitz.datadrive.sh status function, I get an error about bad input.

    if [ "${hdd}" != "" ]; then
      hddBytes=$(fdisk -l /dev/$hdd | grep GiB | cut -d " " -f 5)
      hddGigaBytes=$(echo "scale=0; ${hddBytes}/1024/1024/1024" | bc -l)
    fi

I think the issue is that the first line in my output uses TiB and not GiB:
Disk /dev/sda: 1.82 TiB,<PHONE_NUMBER>016 bytes,<PHONE_NUMBER> sectors
Disk model: SN570 2TB
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 33553920 bytes

Warning: The resulting partition is not properly aligned for best performance: 2048s % 65535s != 0s

This is happening to me with recommended SanDisk SSD Plus 2.5":
tested SSDs: 1TB and 2TB
tested branches: v1.8 and v1.9
tested hardware: orangepi 5B
tested OS: armbian

Will be part of v1.11.0 next release candidate


Chart - Clear stale data from front-end chart

Description

Ensure we consider the cutoff and points in the front-end Chart filtering of stale data.
Also extracted out the clearOldPoints function in the server-side to improve readibility/discoverability.

Related Issue(s)
Closes #755

Yeha, that E2E isn't looking healthy, I'll take a look when I have a chance

Test should now be fixed - rerunning in CI to be sure


Code doesn't work

Hi really impressed at your minimal dev style. can't seem to get your code to do anything. Pls help, really want to parse magnet URIs.

Experiencing a similar issue. Please fix.

Same here, @JohnHMoses can you reproduce?

Can you give us a few more details on what your issue is so we can reproduce it?

Magnet is neither nomadic nor dipole. URI does not parse, no results. Cannot run code. Instructions unclear.

I printed your code and it doesn't work with my Whirlpool. See below.

Currently we only officially support Subzero kitchen appliances.

 Whirlpool has not yet approached us with a open mind towards an open source extension of their software. In this day and age, we can't possibly support any company that doesn't support The Internet of Things with regards to torrenting refrigerators.


Disable code coverage reporting for netcoreapp 2.1

Fixes #5756
With both 2.1 and 3.1 reports uploading to coveralls.io, the last to be uploaded overwrites the first. Which one wins is random.

Pull Request Test Coverage Report for Build 255869

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 76.152%

Totals

Change from base Build 255861:
0.0%

Covered Lines:
23077

Relevant Lines:
30304

💛  - Coveralls


Add support for AES keys in importKey

Fixes key import to be more consistent with the WebCrypto API as specified at https://www.w3.org/TR/WebCryptoAPI/ under sections 25.7 (AES-CTR Operations), 26.4 (AES-CBC Operations), 27.4 (AES-GCM Operations), and 28.3 (AES-KW Operations).

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: ColtonProvias sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

thanks


Rename exception class to remove Error in name

Remove misleading Error from the OutOfCapacityError class name, as it is
an exception, not an error.

Codecov Report

Merging #2801 into master will increase coverage by 0.14%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #2801      +/-   ##
==========================================
+ Coverage    69.1%   69.24%   +0.14%
==========================================
  Files         909      909
  Lines       43232    43232
  Branches     5862     5862
==========================================
+ Hits        29874    29937      +63
+ Misses      11371    11307      -64
- Partials     1987     1988       +1

Impacted Files
Coverage Δ

...t/core/query/scheduler/OutOfCapacityException.java
100% <ø> (ø)

.../pinot/core/query/scheduler/PriorityScheduler.java
80.82% <0%> (ø)
:arrow_up:

.../core/query/scheduler/MultiLevelPriorityQueue.java
84.53% <100%> (ø)
:arrow_up:

...a/manager/realtime/RealtimeSegmentDataManager.java
75% <0%> (-25%)
:arrow_down:

...mpl/dictionary/DoubleOffHeapMutableDictionary.java
70.9% <0%> (-7.28%)
:arrow_down:

.../impl/dictionary/FloatOnHeapMutableDictionary.java
86.66% <0%> (-6.67%)
:arrow_down:

...inot/transport/netty/NettyTCPClientConnection.java
82.31% <0%> (-3.41%)
:arrow_down:

...ot/core/query/pruner/ColumnValueSegmentPruner.java
84.74% <0%> (-3.39%)
:arrow_down:

...regation/function/customobject/QuantileDigest.java
47.81% <0%> (-0.42%)
:arrow_down:

...impl/dictionary/FloatOffHeapMutableDictionary.java
87.27% <0%> (ø)
:arrow_up:

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29516e7...b15af2c. Read the comment docs.


How to get both edge and vertex properties?

After looking at the library I could not seem to find an example on How to get both edge and vertex properties in one query? is this possible with the current implementation?

you could use as/select as demonstrated in https://github.com/mpollmeier/gremlin-scala/blob/master/gremlin-scala/src/test/scala/gremlin/scala/SelectSpec.scala#L77
Note though that select.by doesn't work yet, there's an open PR that almost works: https://github.com/mpollmeier/gremlin-scala/pull/241

@mpollmeier I tried to follow one of the examples on the SelectSpec. So I came up with something like this.
val itm = g.V.has(KeyValue(TripModel.ID, id)).as("a").outE().as("e").select.head
Whenever I try to print out the value
 println(itm)
I always end up with a value like this.
e[{~label=includes, ~out_vertex={~label=trip, tripId=465760a0-073d-46a5-ab1e-debdb86de5b2}, ~in_vertex={~label=business, businessId=cf8c84c6-0fa4-4482-839d-19d9fa8ceb52}, ~local_id=1b214ce0-0141-11e9-b27f-6d2c86545d91}][{~label=trip, tripId=465760a0-073d-46a5-ab1e-debdb86de5b2}-includes->{~label=business, businessId=cf8c84c6-0fa4-4482-839d-19d9fa8ceb52}]
I have also tried something similar to one of the test spec which is this one.
val itm = g.V.has(KeyValue(TripModel.ID, id)).as("a").outE().as("e").select.head._1
The resulting code from above throws this exception
play.api.http.HttpErrorHandlerExceptions$$anon$1: Execution exception[[ClassCastException: org.apache.tinkerpop.gremlin.structure.util.detached.DetachedEdge cannot be cast to scala.Tuple2]] 	at play.api.http.HttpErrorHandlerExceptions$.throwableToUsefulException(HttpErrorHandler.scala:251) 	at play.api.http.DefaultHttpErrorHandler.onServerError(HttpErrorHandler.scala:178) 	at play.core.server.AkkaHttpServer$$anonfun$1.applyOrElse(AkkaHttpServer.scala:363) 	at play.core.server.AkkaHttpServer$$anonfun$1.applyOrElse(AkkaHttpServer.scala:361) 	at scala.concurrent.Future.$anonfun$recoverWith$1(Future.scala:413) 	at scala.concurrent.impl.Promise.$anonfun$transformWith$1(Promise.scala:37) 	at scala.concurrent.impl.CallbackRunnable.run(Promise.scala:60) 	at akka.dispatch.BatchingExecutor$AbstractBatch.processBatch(BatchingExecutor.scala:55) 	at akka.dispatch.BatchingExecutor$BlockableBatch.$anonfun$run$1(BatchingExecutor.scala:91) 	at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:12) Caused by: java.lang.ClassCastException: org.apache.tinkerpop.gremlin.structure.util.detached.DetachedEdge cannot be cast to scala.Tuple2 	at service.TripService.getTrip(TripService.scala:41) 	at controllers.trip.TripController.$anonfun$getTrip$1(TripController.scala:21) 	at play.api.mvc.ActionBuilder.$anonfun$apply$11(Action.scala:363) 	at scala.Function1.$anonfun$andThen$1(Function1.scala:52) 	at play.api.mvc.ActionBuilderImpl.invokeBlock(Action.scala:482) 	at play.api.mvc.ActionBuilderImpl.invokeBlock(Action.scala:480) 	at play.api.mvc.ActionBuilder$$anon$9.invokeBlock(Action.scala:331) 	at play.api.mvc.ActionBuilder$$anon$9.invokeBlock(Action.scala:326) 	at play.api.mvc.ActionBuilder$$anon$2.apply(Action.scala:419) 	at play.api.mvc.Action.$anonfun$apply$2(Action.scala:96)
Is there anything I have been doing wrong?

This works with Tinkergraph (haven't tested with a remote graph):
import gremlin.scala._
import org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerFactory

implicit val graph = TinkerFactory.createModern.asScala
val g = graph.traversal

val vLabel = StepLabel[Vertex]()
val propLabel1 = StepLabel[java.util.Map[String, Object]]()
val propLabel2 = StepLabel[java.util.Map[String, Object]]()
val trav = g.V.as(vLabel).valueMap().as(propLabel1).select(vLabel).outE.valueMap().as(propLabel2)
trav.select((propLabel1, propLabel2)).toList
// List[(java.util.Map[String,Object], java.util.Map[String,Object])] = List(({name=[marko], age=[29]},{weight=0.4}), ({name=[marko], age=[29]},{weight=0.5}), ({name=[marko], age=[29]},{weight=1.0}), ({name=[josh], age=[32]},{weight=1.0}), ({name=[josh], age=[32]},{weight=0.4}), ({name=[peter], age=[35]},{weight=0.2}))

Otherwise I guess it's better to run two queries (one for vertices, one for edges) and combine at the client.


C# issue with "HTTP/1.1" term

Please have a look to Microsoft.AspNet.Server.Kestrel.

You're referring to this line?
Linguist only selects the grammar to use for highlighting. atom/language-csharp is used to highlight C# code on GitHub. You should open an issue there (check that there isn't already one opened ;)

okay ;)


Problem: selectSlice always returns a type of Observable

Take the following example:
const vm$ = this.state.select(
  distinctUntilSomeChanged(['list', 'isItemRendered']),
  map(({ list, isItemRendered }) => ({
    list, isItemRendered
  }))
);

This produces the following return type:

Compare this with the equivalent code that uses selectSlice:
const vm$ = this.state.select(
  selectSlice(['list', 'isItemRendered'])
);

This produces the following return type:

Thx for reporting. We are aware about this issue and are already discussing possible solutions. I guess it will be fixed by the end of the week :)

Excellent and thanks
On Sat, Jun 20, 2020 at 11:17 AM Julian Jandl<EMAIL_ADDRESS>wrote:

Thx for reporting. We are aware about this issue and are already
discussing possible solutions. I guess it will be fixed by the end of the
week :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/BioPhoton/rx-angular/issues/146#issuecomment-646972937,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGYOPRMQG57TCKYOAJVXW3RXSEDTANCNFSM4ODISGWA
.

hi @christianacca, one of our fellow contributors fixed this issue. Look at his pr: https://github.com/BioPhoton/rx-angular/pull/150

Nice thanks guys
On Fri, 26 Jun 2020, 00:32 Julian Jandl<EMAIL_ADDRESS>wrote:

hi @christianacca https://github.com/christianacca, one of our fellow
contributors fixed this issue. Look at his pr: #150
https://github.com/BioPhoton/rx-angular/pull/150
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/BioPhoton/rx-angular/issues/146#issuecomment-649868103,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGYOPWS6BDN2JYBNSXD5LDRYPNBZANCNFSM4ODISGWA
.


not compiling on mac os 11.16.1

I get the following error:
of_v0.11.2/addons/ofxGenericDmx/src/DmxUsbProDevice.cpp:204:3: Non-constant-expression cannot be narrowed from type 'unsigned int' to 'unsigned char' in initializer list
on these 2 lines:
int r;
	unsigned char reqParams[2] = {
		userConfigLength & 0xFF,
		( userConfigLength >> 8	) & 0xFF

(I'm an OF newbie and first time playing with DMX, using enttec dmx pro usb)

Hi,
That seems to be due to changes in more recent compiler versions, I happened to run into it myself with another project.
I have not tried it myself, but this should fix it:
unsigned char reqParams[2] = {
	static_cast<unsigned char>(userConfigLength & 0xFF),
	static_cast<unsigned char>(( userConfigLength >> 8 ) & 0xFF)
};

Please let me know if that fixes it, and good luck with your DMX endeavours. :)

thnx so much, that worked!


Font size vars

This PR ensures we define font sizes in a single place (_fonts) and re-use them via variables.
Also, this ensures that the status bar defines it's variables locally, a pattern we already use in other places (Tabbed, ...)

Cleaned this PR up according to @pinussilvestrus comment (https://github.com/camunda/camunda-modeler/pull/2612#discussion_r762975584).
@smbea @pinussilvestrus Please have another look!


[PROJECT] Contribution Flow QA & papercuts

This project is about documenting small improvements that we can tackle to improve generally the Contribution flow.
Areas of focus:

With Credit Card (guest, new account, existing account)
With PayPal (guest, new account, existing account)
With Bank Transfer (guest, new account, existing account)

List of issues:
to be completed

[ ] Fix Captcha retry bug: https://github.com/opencollective/opencollective/issues/5063

some (ranked) suggestions

https://github.com/opencollective/opencollective/issues/5018
https://github.com/opencollective/opencollective/issues/3934
https://github.com/opencollective/opencollective/issues/4092
https://github.com/opencollective/opencollective/issues/4898
https://github.com/opencollective/opencollective/issues/4500
https://github.com/opencollective/opencollective/issues/4423
https://github.com/opencollective/opencollective/issues/4265 (to scope)

and some move incidental issues

https://github.com/opencollective/opencollective/issues/3538
https://github.com/opencollective/opencollective/issues/3563