MicroK8S unable to deploy CoreDNS on a Raspberry Pi 4 (Raspbian)

Hello,
After performing the steps in this thread https://github.com/canonical/microk8s/issues/2454 I finally got my MicroK8S stable. Now I want to deploy the dns addon ```microk8s enable dns`` but the CoreDNS pods are constantly crashing with the following error (image also to provide context):
Error: failed to create containerd task: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error setting cgroup config for procHooks process: openat2 /sys/fs/cgroup/kubepods/burstable/pod1287a9e5-81b5-4a75-89f1-f39a520e32a1/coredns/memory.max: no such file or directory: unknown

I've tried the following:

Restart MicroK8S
Append cgroup_enable=cpuset cgroup_enable=memory cgroup_memory=1 to /boot/firmware/nobtcmd.txt, /boot/firmware/cmdline.txt and /boot/cmdline.txt

inspection-report-20230206_161349.tar.gz

Hi @GBT55, I see this issue in the containerd logs (mirroring the error message you see with kubectl), which would hint that cgroupsv2 is not really available on the system in an unexpected way?
feb 06 12:09:27 raspberrypi microk8s.daemon-containerd[3037292]: time="2023-02-06T12:09:27.571558950+01:00" level=warning msg="error from *cgroupsv2.Manager.EventChan" error="failed to add inotify watch for \"/sys/fs/cgroup/kubepods/besteffort/podc1540cc4-a2d1-404b-b7b8-aab61ac9fccd/747b781200a9e79e5aa459a407c9d201374006e18cd46f74e869dd1e6a83cacf/memory.events\": no such file or directory"

Can you test whether using cgroupsv1 solves your issue? Please try:
# use cgroupsv1
sudo sed -i 's,${RUNTIME_TYPE},io.containerd.runc.v1,' /var/snap/microk8s/current/args/containerd-template.toml
sudo snap restart microk8s.daemon-containerd

# delete all pods to force recreate containers
sudo microk8s kubectl delete pod --all -A

Can you also share the output of the following command from your machine? Thanks a lot
mount | grep cgroup

Hi @neoaggelos, thank you for the quick response.
I tried this one and the error still remains, in fact I dont think the sed command is doing anything.

Can you test whether using cgroupsv1 solves your issue? Please try:
# use cgroupsv1
sudo sed -i 's,${RUNTIME_TYPE},io.containerd.runc.v1,' /var/snap/microk8s/current/args/containerd-template.toml
sudo snap restart microk8s.daemon-containerd

# delete all pods to force recreate containers
sudo microk8s kubectl delete pod --all -A

There you go
root@raspberrypi:~# mount | grep cgroup
cgroup2 on /sys/fs/cgroup type cgroup2 (rw,nosuid,nodev,noexec,relatime)
root@raspberrypi:~#

Can you also share the output of the following command from your machine? Thanks a lot
mount | grep cgroup

Hi @GBT55
Can you check the contents of /var/snap/microk8s/current/args/containerd-template.toml for instances of ${RUNTIME_TYPE} and io.containerd.runc.v1? Can you ensure that they are replaced with io.containerd.runc.v2 instead and restart containerd? This is what the sed command above should have done (but configure containerd to use cgroupv1 instead).
After restarting, again ensure that you delete all pods so that containerd restarts the shims with v2:
sudo microk8s kubectl delete pod --all -A

I was facing what may be a related issue with coredns not starting. Raspberry pi 4, 64bit, OS completely up to date.
58s         Warning   Failed                   pod/coredns-64c6478b6c-47z7s          Error: failed to create containerd task: failed to create shim: OCI runtime create failed: container_linux.go:380: starting container process caused: process_linux.go:545: container init caused: process_linux.go:508: setting cgroup config for procHooks process caused: openat2 /sys/fs/cgroup/kubepods/burstable/pod5cb3542a-4888-4094-942e-e13f7de62c81/coredns/memory.max: no such file or directory: unknown

The sed command to use cgroups v1 didn't work, but when I followed @neoaggelos suggestion to replace the line with v2, restart containerd, and delete the offending pod, it stayed up!
Not sure if this detail has anything to do with it either, but I did add the following to /boot/cmdline.txt and rebooted prior to it starting to work.
 cgroup_enable=memory swapaccount=1 cgroup_memory=1 cgroup_enable=cpuset

Hi, @neoaggelos
I have replaced all instances of io.containerd.runc.v1 with io.containerd.runc.v2.
By the way there are no lines containing ${RUNTIME_TYPE} in my /var/snap/microk8s/current/args/containerd-template.toml file.

I then restarted and the problem persists, I also added that line to /boot/cmdline.txt as @bhwarren suggested, but unfortunately it didn't do the workaround as it did for you.

Not sure if this detail has anything to do with it either, but I did add the following to /boot/cmdline.txt and rebooted prior to it starting to work.
 cgroup_enable=memory swapaccount=1 cgroup_memory=1 cgroup_enable=cpuset

By the way there are no lines containing ${RUNTIME_TYPE} in my /var/snap/microk8s/current/args/containerd-template.toml file.

 For some background, microk8s will attempt to pick cgroups2 (if available on the host) and otherwise fallback to v1.
How did you restart? Can you attempt a fresh install like this:
sudo snap remove microk8s --purge
sudo reboot
sudo snap install microk8s --classic

Hi @neoaggelos, still no luck… I've tried reinstalling as you said, I've rebooted a few times, and I've tried with io.containerd.runc.v2 and also with the ${RUNTIME_TYPE} variable. None of them have been successful, it keeps showing the same error:
Error: failed to create containerd task: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error setting cgroup config for procHooks process: openat2 /sys/fs/cgroup/kubepods/burstable/pod847514fc-ae4c-4345-a538-cc7ea6445b4f/coredns/memory.max: no such file or directory: unknown

Hi @GBT55 can you check whether setting any of the following on the cmdline.txt helps?
# disable cgroupv1 altogether
cgroup_no_v1=all

# use cgroupv2 for systemd
systemd.unified_cgroup_hierarchy=1

# disable hybrid cgroupv1
systemd.legacy_systemd_cgroup_controller=0

Hi, I appreciate the help, but I'm sorry to say… no luck yet. Maybe it's something on my side, but I don't know what it is.

Looking at similar issues in other projects, could it be that it is related to the kernel/systemd version you are running? Have you installed the latest system package updates?

Hi @neoaggelos. I re-installed the O.S and it seems the issue has been fixed. From a clean install I was able to enable the cgroups and install microk8s, then it worked perfectly.
It was something on my side, you can close the issue.


Find a way to avoid relative paths, like "../../Job". Requires path mapping, which is planned for 1.8 https://github.com/Microsoft/TypeScript/issues/5039

Sorry, accidentally posted into a wrong place.


Unsuccessful save-operation still causes the first method to return object with changed attributes

I've put a clean code example to help reproduce the issue: https://github.com/layerssss/parse-hook-error-quirk
When a hook yields an error in beforeSave hook. The change to an object is not applied. Call Query.find in browser again. API from parse-server are returning unchanged attributes of the object. But the Query.find is returning the changed object.
Expect: Query.find should return the unchanged object.
parse-server version: 2.3.2
Parse-JS-SDK: 1.9.2
Note: We have a running system with Parse-JS-SDK 1.5 with parse.com, on which this issue doesn't exist.
Cloud code:
    Parse.Cloud.beforeSave('Folder', (request, response) => {
      if (!request.object.name) {
        return response.error('Name is invalid.');
      }

      response.success();
    });

    (new Parse.Query('Folder')).first()
      .then(folder => {
        if (folder) return Promise.resolve();

        folder = new Parse.Object('Folder', {
          name: 'Untitled Folder'
        });

        return folder.save();
      });

Client code:
new Parse.Query('Folder').first()
  .then(folder => {
    console.log('expected old name: Untitled Folder');
    console.log('old name:' + folder.get('name'));
    folder.set('name', ''); // try to change it to invalid

    return folder.save()
      .fail(error => {
        console.log('name not changed: ' + error.message);
        return Parse.Promise.as();
      });
  })
  .then(() => new Parse.Query('Folder').first())
  .then(folder => {
    console.log('expected new name: Untitled Folder');
    console.log('new name:' + folder.get('name'));
  });

Please have a look, thanks!

It turns out that it's the expected behaviour when "single instance" mode is on (default in browser). On which version did this become the default behaviour? Can you point me to the relevant changelog entries?


Add getTickers to MarketDataService and implement Kraken

This extends #2388 and implements getTickers for Kraken

@timmolter agreed. Done


🔧 [Refactor] Generate Protobuf on compile

:zap: Refactor ticket

Generate Protobuf on compile. There is Protobuf compiles somewhere in the repository. Those should be generated, maybe cached in an external image to improve performance
Motive

Have a single source of truth

Currently in my build_and_run.sh script it will be checked if protobuf files were already parsed and only if they do not exist they will be parsed. So currently they should be parsed only once, by the first docker-compose up call.

But you checked in a compiled version didn't you? Like those header files with long hash values in it?

On Community Server the compiled protobuf files are checked in, in login-server not.
I have thought about checking in the compiled protobuf files also in login-server to make compiling more easy and to have the same approach.
The Login-Server Pages (HTTP-Interface) are also checked in compiled.
But now I understand you don't like the compiled files checked in?
Not easy for community-server. I must use the login-server docker container to parse th community server protobuf files and after that call in community-server composer dump-autoload
I don't know if it is even possible to do that.

Yes true, it is common practice to leave out binary files when committing. On the other hand we do have a compiling issue due to time. In the long run we should always have one source of truth ( having the compiled protobuffs checked in with the community server is violating this while at the same time makes it impossible for the common developer to understand if the files are up to date when comparing to the uncompiled sources).
And yes the same applies for the html pages. You can see how it clutters PRs with just generated changes which could be left out. When rebasing Stage2 this was a nightmare since the source line numbers are commented in those compiled html files.
Its both not very important tho, don't waste your time with it now - the html stuff will be left out of the login server at a given point and will solve itself, while the protobuff stuff comes into play when we try to go decentralised.

There not binary files. They are quellcode files.
Okay than the parsed proto files in Login-Server stay out of git.

And for community-server I will think about a solution.. at some point.

obsolete


Warning: findDOMNode is deprecated in StrictMode...

Hi,
I got these deprecation warnings.
It seems that we can replace ReactDOM.findDOMNode with React.createRef.
DraggableCore
Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of DraggableCore which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://fb.me/react-strict-mode-find-node...

WidthProvider
Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of WidthProvider which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://fb.me/react-strict-mode-find-node...

Still alive issue

I just ran into this as well

This issue still exists.
In documentation we've some information about innerRef:
// Ref for getting a reference for the grid's wrapping div.
// You can use this instead of a regular ref and the deprecated `ReactDOM.findDOMNode()`` function.
innerRef: ?React.Ref<"div">

However, covering GridLayout into div and passing its ref to GridLayout.innerRef not solving an issue.
Are there any recipes to solve findDOMNode is deprecated in StrictMode issue?

@STRML could you reopen please? It was closed by bot.

Yes, this is still an issue as GridItem uses findDOMNode.

@STRML Hi! Looks like issue was closed again because stale label is on issue.

@STRML any suggestion on how to solve this?

@STRML this is still an issue, is there a reason why it's closed?

This is still on my list of things to revisit but I just haven’t had the time to do so

any update?

still here

Hi @ViktoriyaBurdey,
Seems @STRML  already solved in this pull request:
https://github.com/react-grid-layout/react-grid-layout/pull/1425
Take a look into it. And upgrade to v1.2.3
Cheers,
Yi-Pei


[bug]: toggle in tooltip is not working

Describe the bug
I have this code:
<TooltipProvider>
  <Tooltip>
    <TooltipTrigger asChild>
      <Toggle
        variant="outline"
        aria-label="Toggle love"
        className="pl-2.5"
      >
        <HeartPlusIcon className="h-6 w-6 mr-2" />
        Love
      </Toggle>
    </TooltipTrigger>
    <TooltipContent side="bottom">
      Love this event
    </TooltipContent>
  </Tooltip>
</TooltipProvider>

Now, the toggle is not working. And my temporary solution is not to use asChild property in TooltipTriger, but it will come to another problem which is <button> in <button>.
Affected component/components
Tooltip, Toggle
How to reproduce
Just import tooltip, and toggle, and use them like the code above
Codesandbox/StackBlitz link
No response
Logs
No response
System Info
Chrome, Edge

Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues

 Heart

Bold

// Code

// Click

// Hover

  Check this will work

  In you code
  <TooltipPrivoder> // Spelling Mistake  --> TooltipProvider

        Love

Love this event

Thank you for your help. But, as I mentioned above, when using asChild in <TooltipTrigger>, the <Toggle> doesn't work. And when not using asChild, <button> in <button>, as shown below.

According to my research, it's because <TooltipTrigger> and <Toggle> both use the data-state field to manage their status.

For <TooltipTrigger>, it is data-state="close", and data-state="delayed-open".
For <Toggle>, it is data-state="on", data-state="off".

And when using asChild, <TooltipTrigger>'s data-state will overwrite <Toggle>'s data-state, making <Toggle>'s data-state unsatisfactory.
Therefore, to completely solve this problem, the data-state field of one of the two components above must be changed.

Using asChild and wrapping <Toggle> in a span seems to work for me.

Hi @shadcn,
Are there any updates on this one? The save valid not only for Toggle component, but many other as well. And seems like the reason is well described by @fredle09 comment above. Thanks

Hi, I believe to have a similar issue when using the sidebar component.
When I use SidebarMenuButton with asChild :
<SidebarMenuButton tooltip={item.title} asChild>
  <NavLink to={item.url}>
    {item.icon && <item.icon />}

{item.title}

  </NavLink>
</SidebarMenuButton>

it makes the tooltip not to show when the sidebar is collapsed.
To fix it I had to change the SidebarMenuButton component from:
<TooltipTrigger asChild>{button}</TooltipTrigger>

to
<TooltipTrigger>{button}</TooltipTrigger>


New user registration

This branch is made for adding usersin the frontend and connecting it to the backend. Only admins should be allowed to add new users.

Vue Cl complains about the imported math module, but I don't see what the reason for it is.


Save the customer's payment method at the time of payment

Feature request
Run Payments with Stripe
Is your feature request related to a problem? Please describe.
I want to save the customer's payment method at the time of payment. Currently, customers have to enter their credit card every time.
Describe the solution you'd like
We should be able to respond if we can change the relevant option when creating the checkout.
https://github.com/stripe/stripe-firebase-extensions/blob/next/firestore-stripe-payments/functions/src/index.ts#L105-L130
// example
    const {
      client = 'web',
      amount,
      currency,
      mode = 'subscription',
      price,
      success_url,
      cancel_url,
      quantity = 1,
      payment_method_types,
      shipping_rates = [],
      metadata = {},
      automatic_payment_methods = { enabled: true },
      automatic_tax = false,
      tax_rates = [],
      tax_id_collection = false,
      allow_promotion_codes = false,
      trial_from_plan = true,
      line_items,
      billing_address_collection = 'required',
      collect_shipping_address = false,
      customer_update = {},
      locale = 'auto',
      promotion_code,
      client_reference_id,
      payment_intent_data // add
    } = snap.data();

Or if there is a way to save payment methods in your existing configuration, please let me know. We thank you for your cooperation.

This is already the default behavior. The only thing is it doesn't set the payment method as default during first checkout.

This is already the default behavior. The only thing is it doesn't set the payment method as default during first checkout.

This is not true for Checkout Sessions where mode: 'payment', which this extension supports. You need to explicitly pass the payment_intent_data.setup_future_usage parameter. Docs here.


Example in documentation doesn't work

Checklist

[X] I have searched the existing issues for similar issues.
[X] I added a very descriptive title to this issue.
[X] I have provided sufficient information below to help reproduce this issue.

Summary
I've started reading the docs on running tests and came across this page in the docs. In the example for app.py, it doesn't work and returns an error:
AttributeError: st.session_state has no attribute "beans". Did you forget to initialize it? More info: https://docs.streamlit.io/library/advanced-features/session-state#initialization

Reproducible Code Example
"""app.py"""
import streamlit as st

# Initialize st.session_state.beans
beans = st.session_state.get("beans", 0)

st.title("Bean counter :paw_prints:")

addend = st.number_input("Beans to add", 0, 10)
if st.button("Add"):
    st.session_state.beans += addend
st.markdown(f"Beans counted: {st.session_state.beans}")

Steps To Reproduce

Paste the code in an editor and run with streamlit run app,py.

Expected Behavior
As an example, it should run with no errors and allow the counter to work. pytest also fails.
Current Behavior
Error:
AttributeError: st.session_state has no attribute "beans". Did you forget to initialize it? More info: https://docs.streamlit.io/library/advanced-features/session-state#initialization

Is this a regression?

[ ] Yes, this used to work in a previous version.

Debug info

Streamlit version: 1.28.2
Python version: 3.11.6
Operating System: macOS
Browser: Safari

Additional Information
This modified code works and passes the test in the doc example:
import streamlit as st

# Title
st.title("Bean counter :paw_prints:")

# Check if 'beans' is not in session_state, then initialize it
if 'beans' not in st.session_state:
    st.session_state.beans = 0

addend = st.number_input("Beans to add", 0, 10)

if st.button("Add"):
    st.session_state.beans += addend

st.markdown(f"Beans counted: {st.session_state.beans}")

@digitalghost-dev The issue has been fixed with #881. 😄 Please let us know if you spot other issues. 🎈


showing error when save the post

Steps to Reproduce

New a post

Click the setting icon, and change the Post URL, cause the

Sometimes, you will get the following error, not often

Attempted to handle event `becameError` on <ghost-admin@model:post::ember1696:97> while in state root.loaded.saved.

Technical details:

Ghost Version:
Version:  0.11.9 production

Node Version:
Version 7.0

Browser/OS:
Chrome with version 58.0.3029.110 (64 bit)  on macOS Serria

Database:
sqlite 3

Hey @hzb! Thanks for the report. This issue was reported already with #8551, so I'm closing this issue here as it's a duplicate.


Erroneous <IP_ADDRESS>:3000

I'm having a lot of connection errors in my output when running this, but I can't track down anywhere which might be causing this? Elastic search seems to be populating correctly and connection to the Magento API is fine.
2018-12-09T21:55:54.507Z - info: Product sub-stage 6: Geting product categories for BPCWBWS-B41
2018-12-09T21:55:54.507Z - info: Using category_ids binding for BPCWBWS-B41: 19,11,13
2018-12-09T21:55:54.508Z - info: Product sub-stages done for BPCWBWS-B41
2018-12-09T21:55:54.508Z - info: Importing 42 of 50 - [(495 - BPCWBWS-B41) Baby Parasol Compatible with Baby Weavers Scoot - Blue] with tsk =<PHONE_NUMBER>439
2018-12-09T21:55:54.508Z - info: Tasks count = 7
{ Error: connect ECONNREFUSED <IP_ADDRESS>:3000
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1113:14)
  errno: 'ECONNREFUSED',
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '<IP_ADDRESS>',
  port: 3000 }
debug: Response received.
2018-12-09T21:55:54.521Z - info: Product sub-stage 6: Geting product categories for BPCWBWB2T-HP6
2018-12-09T21:55:54.521Z - info: Using category_ids binding for BPCWBWB2T-HP6: 19,11,13
2018-12-09T21:55:54.522Z - info: Product sub-stages done for BPCWBWB2T-HP6
2018-12-09T21:55:54.522Z - info: Importing 43 of 50 - [(463 - BPCWBWB2T-HP6) Baby Parasol Compatible with Baby Weavers Baby 2 Twin - Hot Pink] with tsk =<PHONE_NUMBER>439
2018-12-09T21:55:54.522Z - info: Tasks count = 6
{ Error: connect ECONNREFUSED <IP_ADDRESS>:3000
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1113:14)
  errno: 'ECONNREFUSED',
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '<IP_ADDRESS>',
  port: 3000 }
debug: Response received.
2018-12-09T21:55:54.559Z - info: Product sub-stage 6: Geting product categories for BPCWBWC-LB16
2018-12-09T21:55:54.559Z - info: Using category_ids binding for BPCWBWC-LB16: 19,11,13
2018-12-09T21:55:54.560Z - info: Product sub-stages done for BPCWBWC-LB16
2018-12-09T21:55:54.560Z - info: Importing 44 of 50 - [(472 - BPCWBWC-LB16) Baby Parasol Compatible with Baby Weavers Citi - Light Blue] with tsk =<PHONE_NUMBER>439
2018-12-09T21:55:54.560Z - info: Tasks count = 5
{ Error: connect ECONNREFUSED <IP_ADDRESS>:3000
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1113:14)
  errno: 'ECONNREFUSED',
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '<IP_ADDRESS>',
  port: 3000 }
debug: Response received.
2018-12-09T21:55:54.561Z - info: Product sub-stage 6: Geting product categories for BPCWBWS-B37
2018-12-09T21:55:54.562Z - info: Using category_ids binding for BPCWBWS-B37: 19,11,13
2018-12-09T21:55:54.562Z - info: Product sub-stages done for BPCWBWS-B37
2018-12-09T21:55:54.562Z - info: Importing 45 of 50 - [(491 - BPCWBWS-B37) Baby Parasol Compatible with Baby Weavers Scoot - Black] with tsk =<PHONE_NUMBER>439
2018-12-09T21:55:54.562Z - info: Tasks count = 4
{ Error: connect ECONNREFUSED <IP_ADDRESS>:3000
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1113:14)
  errno: 'ECONNREFUSED',
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '<IP_ADDRESS>',
  port: 3000 }
debug: Response received.
debug: Calling API endpoint: GET https://fylo.store/rest/V1/configurable-products/BPCONF-006/children
debug: Response received.
2018-12-09T21:55:54.589Z - info: Product sub-stage 6: Geting product categories for BPCWBWCAIO-LB28
2018-12-09T21:55:54.589Z - info: Using category_ids binding for BPCWBWCAIO-LB28: 19,11,13
2018-12-09T21:55:54.590Z - info: Product sub-stages done for BPCWBWCAIO-LB28
2018-12-09T21:55:54.590Z - info: Importing 46 of 50 - [(483 - BPCWBWCAIO-LB28) Baby Parasol Compatible with Baby Weavers Condour All in One - Light Blue] with tsk =<PHONE_NUMBER>439
2018-12-09T21:55:54.590Z - info: Tasks count = 3
{ Error: connect ECONNREFUSED <IP_ADDRESS>:3000
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1113:14)
  errno: 'ECONNREFUSED',
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '<IP_ADDRESS>',
  port: 3000 }
debug: Response received.

The details I am using to connect are similar to this (private information removed):
export TIME_TO_EXIT=2000
export VS_INVALIDATE_CACHE_URL=http://dev.fylo.store/invalidate?key=hidden&tag=
export VS_INVALIDATE_CACHE=0
export PRODUCTS_SPECIAL_PRICES=true
export MAGENTO_CONSUMER_KEY=hidden
export MAGENTO_CONSUMER_SECRET=hidden
export MAGENTO_ACCESS_TOKEN=hidden
export MAGENTO_ACCESS_TOKEN_SECRET=hidden
export DATABASE_URL=https://aws-vpc-here.com
export REDIS_HOST=redis.host.is.here

echo 'Default store - in our case United States / en'
export MAGENTO_URL=https://fylo.store/rest

# node --harmony src/cli.js blocks
# node --harmony src/cli.js pages
# node --harmony src/cli.js reviews
node --harmony src/cli.js categories --removeNonExistent=true --extendedCategories=true
node --harmony src/cli.js productcategories
node --harmony src/cli.js attributes --removeNonExistent=true
node --harmony src/cli.js taxrule --removeNonExistent=true
node --harmony src/cli.js products --removeNonExistent=true --partitions=1

Thanks!

Hmm, the only connection to <IP_ADDRESS>:3000 is for clearing the cache:
https://github.com/DivanteLtd/mage2vuestorefront/blob/6d36b1c24612b557fb474441180e04cf57fef164/src/config.js#L14
It's probably because the config option is casted as string not as a boolean (as You have set it to 0)
https://github.com/DivanteLtd/mage2vuestorefront/blob/6d36b1c24612b557fb474441180e04cf57fef164/src/adapters/magento/product.js#L484
Can You try to fix it and create a Pull Request please?

No problem, thanks for getting back to me. Do we think a simple parseInt
would suffice?
On Mon, 10 Dec 2018, 10:36 Piotr Karwatka<EMAIL_ADDRESS>wrote:

Hmm, the only connection to <IP_ADDRESS>:3000 is for clearing the cache:
https://github.com/DivanteLtd/mage2vuestorefront/blob/6d36b1c24612b557fb474441180e04cf57fef164/src/config.js#L14
It's probably because the config option is casted as string not as a
boolean (as You have set it to 0)
https://github.com/DivanteLtd/mage2vuestorefront/blob/6d36b1c24612b557fb474441180e04cf57fef164/src/adapters/magento/product.js#L484
Can You try to fix it and create a Pull Request please?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/DivanteLtd/mage2vuestorefront/issues/56#issuecomment-445768300,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Arh9lO5kYLJF4PoCQu11bv-RACTk-Lv3ks5u3jkVgaJpZM4ZKWPp
.

Just using parseInt() will not work for boolean values true and false.
One way to support both booleans (true/false), integers and strings like "1" and "0" would be to do something like this:
 invalidateCache: Number(process.env.VS_INVALIDATE_CACHE) || false,
Notice that using strings for booleans "false" and "true" will not work using the above.

Thanks @Cyclonecode, PR submitted.


Add new module which adds graphql-java-datetime scalars to DGS

Pull request checklist

[ ] Please read our contributor guide
[ ] Consider creating a discussion on the discussion forum
first
[ ] Make sure the PR doesn't introduce backward compatibility issues
[ ] Make sure to have sufficient test cases

Pull Request type

[ ] Bugfix
[x] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Other (please describe):

Changes in this PR
Describe the new behavior from this PR, and why it's needed
This PR adds a new module, similar to graphql-dgs-extended-scalars which introduces the 7 custom datetime scalars available from graphql-java-datetime
Appreciate any feedback on this PR.  Very happy to iterate on this PR

Thanks for the PR @setchy, I wasn't aware this module existed. We would, however, like to avoid adding external dependencies that are not part of graphql-java as much as possible, so won't be merging this PR.


Add the linebender lint set

We should add a standardized set of rustc lints and clippy lints to all our projects. If we raise MSRV to 1.74, we can add them directly to Cargo.toml.
See zulip discussion for what our lint set should be. See https://github.com/linebender/peniko/pull/47/ for our current lint set.
Aside from the Cargo.toml lints, we should also add the following annotation to our crate root:
#![warn(clippy::print_stdout, clippy::print_stderr, clippy::dbg_macro)]

(We don't want a workspace-level lints for those because we want to tolerate prints in tests and examples.)
See this zulip thread for details.
We should add the following annotation at the crate roots:
We should also remove leftover prints, if any, or give them an opt-out.

See https://github.com/linebender/linebender.github.io/pull/68


Red and blue line from grid in 3D viewport blinking

Godot version:
3.1 cc71012
OS/device including version:
Windows 10 Intel HD 4600
Issue description:
When you open a new project and move the view with the mouse, the red and blue lines flash in the 3D view
I was surprised by this problem, but I think that this problem is well hidden from me
When I opened the FPS demo from documents, this problem does not appear
In GLES2 lines are barely visible
Steps to reproduce:

Open new project
In 3d viewport move view by mouse

GLES3 - https://streamable.com/zgpvf
GLES2 - https://streamable.com/2h8d1

CC @Calinou - neverending story...
I'm starting to wonder if we should not just revert all the changes made for this and keep the i = 0 lines hidden at all times.

This might be fixed by #22282, can you confirm?

Now works perfect


Update dependency argoproj-labs/argocd-vault-plugin to v1.14.0

This PR contains the following updates:

Package
Update
Change

argoproj-labs/argocd-vault-plugin
minor
v1.13.0 -> v1.14.0

Release Notes

argoproj-labs/argocd-vault-plugin (argoproj-labs/argocd-vault-plugin)
v1.14.0
Compare Source
What's Changed

docs: adding sap to the users by @MichaelSp in https://github.com/argoproj-labs/argocd-vault-plugin/pull/435
docs: note security risks of $helm_args by @crenshaw-dev in https://github.com/argoproj-labs/argocd-vault-plugin/pull/441
docs: add note about securing Redis and repo-server by @crenshaw-dev in https://github.com/argoproj-labs/argocd-vault-plugin/pull/442
feat: add vault-path validation by @c0deltin in https://github.com/argoproj-labs/argocd-vault-plugin/pull/454
feat: added keeper secrets manager backend by @robbert229 in https://github.com/argoproj-labs/argocd-vault-plugin/pull/468
chore(deps): replace aws-sdk-go with aws-sdk-go-v2 by @nvachhar in https://github.com/argoproj-labs/argocd-vault-plugin/pull/472
docs: Update plugin usage documentation by @Helcaraxan in https://github.com/argoproj-labs/argocd-vault-plugin/pull/475

New Contributors

@MichaelSp made their first contribution in https://github.com/argoproj-labs/argocd-vault-plugin/pull/435
@crenshaw-dev made their first contribution in https://github.com/argoproj-labs/argocd-vault-plugin/pull/441
@c0deltin made their first contribution in https://github.com/argoproj-labs/argocd-vault-plugin/pull/454
@robbert229 made their first contribution in https://github.com/argoproj-labs/argocd-vault-plugin/pull/468
@nvachhar made their first contribution in https://github.com/argoproj-labs/argocd-vault-plugin/pull/472
@Helcaraxan made their first contribution in https://github.com/argoproj-labs/argocd-vault-plugin/pull/475

Full Changelog: https://github.com/argoproj-labs/argocd-vault-plugin/compare/v1.13.1...v1.14.0
v1.13.1
Compare Source
What's Changed

chore(deps): bump github.com/hashicorp/vault from 1.10.3 to 1.10.6 by @dependabot in https://github.com/argoproj-labs/argocd-vault-plugin/pull/408
fix: AVP panics on reference to deleted secret version in Vault by @AlexanderProschek in https://github.com/argoproj-labs/argocd-vault-plugin/pull/411
ci: update GitHub actions with dependabot by @PascalBourdier in https://github.com/argoproj-labs/argocd-vault-plugin/pull/344
chore(deps): bump github/codeql-action from 1 to 2 by @dependabot in https://github.com/argoproj-labs/argocd-vault-plugin/pull/413
chore(deps): bump actions/setup-go from 2 to 3 by @dependabot in https://github.com/argoproj-labs/argocd-vault-plugin/pull/416
chore(deps): bump docker/setup-buildx-action from 1 to 2 by @dependabot in https://github.com/argoproj-labs/argocd-vault-plugin/pull/414
chore(deps): bump goreleaser/goreleaser-action from 2 to 3 by @dependabot in https://github.com/argoproj-labs/argocd-vault-plugin/pull/417
chore(deps): bump codecov/codecov-action from 1 to 3 by @dependabot in https://github.com/argoproj-labs/argocd-vault-plugin/pull/415
chore(deps): bump actions/checkout from 2 to 3 by @dependabot in https://github.com/argoproj-labs/argocd-vault-plugin/pull/423
docs: Add the ARGOCD_ENV prefix in the helm with args example by @kroustou in https://github.com/argoproj-labs/argocd-vault-plugin/pull/431

New Contributors

@PascalBourdier made their first contribution in https://github.com/argoproj-labs/argocd-vault-plugin/pull/344
@kroustou made their first contribution in https://github.com/argoproj-labs/argocd-vault-plugin/pull/431

Full Changelog: https://github.com/argoproj-labs/argocd-vault-plugin/compare/v1.13.0...v1.13.1

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Renovate Ignore Notification
Because you closed this PR without merging, Renovate will ignore this update (v1.14.0). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.
If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.


What the variable t1km_sum is

@FabianIsensee Hi, sir. I am still perusing your code and have learned a lot. Now I do not make it clear what the variable t1km_sum is  in the dataset.py and what role does it play. Thank you!

When segmenting these images clinicians typically look at a subtraction image between t1 and t1c to better recognize the enhancing tumor parts. I experimented with using that in the network but it did not provide any benefits. The code is still there though (that input channel is not used by the network)

Sorry, another question. In the line 179 of train_network.py: train_fn = theano.function([x_sym, seg_sym], [loss, acc_train, loss_vec], updates=updates), but in the line 238: loss_vec, acc, l = train_fn(data, seg). Maybe the losss_vec and loss location should be swapped, is it? Thank you!


Add arm64 support

Thanks to the work done previously (see https://github.com/cilium/tetragon/issues/487), it is pretty straightforward to build Tetragon on arm64 and it seems to mostly work out of the box. The exec probes seem to be working, and I tried to load some TracingPolicy with kprobe hooks that just worked.
Building
The makefile assumes that we are building using the clang docker image by default, and this one is built only for amd64 at the moment. I saw there was previously a PR attempt https://github.com/cilium/tetragon/pull/50 that was unfortunately reverted https://github.com/cilium/tetragon/pull/55 because it might have been really too early to build every images for arm64 (including the Tetragon one). It would simplify the workflow to build a multi-arch image and use it in the Makefile.

[x] Build the clang image for arm64 via emulation, push a multi-arch image and update the Makefile with the new multi-arch image
https://github.com/cilium/tetragon/pull/743

This part is done, and we can now easily build on arm64 just by using make tetragon-bpf.
Tests
I tried running the tests on arm64 and some stuff broke with obvious issues displaying messages like:
failed: creating perf_kprobe PMU: token __arm64___x64_sys_dup2: not found: no such file or directory

So we might have some quick wins on the tests and maybe some other more difficult things to fix.

[x] Some docker image used in the test could not run on arm64, bumping tag was enough: https://github.com/cilium/tetragon/pull/734/commits/0be8dae2e45bd037432b341afa75927bc318167c
[x] Issue: https://github.com/cilium/tetragon/pull/751
PR: https://github.com/cilium/tetragon/pull/752
Adapt the templates and the check to the new prefix-less syscalls symbols, see https://github.com/cilium/tetragon/pull/734/commits/d8fda5cd17a7b6d28d9533b2c0ee6a2c3cefb5bc.
[x] Adapt a test on Tracepoint format because char is unsigned on arm64, contrary to amd64, see Tracepoint: adapt a format test on task_newtask to arm64.

This part is done! Now tests can run on amd64 and arm64! 🥳
Trying Tetragon on arm64
# synchronize your git repo to my branch
git fetch && git checkout pr/mtardy/arm64
# compile Tetragon and the BPF programs
make tetragon tetragon-bpf
# run with
sudo ./tetragon --bpf-lib bpf/objs

I think you can submit this commit https://github.com/cilium/tetragon/pull/734/commits/d8fda5cd17a7b6d28d9533b2c0ee6a2c3cefb5bc  and the one related to it in a separate PR maybe?

I think you can submit this commit d8fda5c and the one related to it in a separate PR maybe?

Yes, I could because it was possible thanks to this separate PR https://github.com/cilium/tetragon/pull/752 but what would be the benefits of doing so? It's only done in order for Tetragon tests to pass on an arm64 host. If we can merge this directly without squashing what would be the advantages of doing a separate PR?

I think you can submit this commit d8fda5c and the one related to it in a separate PR maybe?

Yes, I could because it was possible thanks to this separate PR #752 but what would be the benefits of doing so? It's only done in order for Tetragon tests to pass on an arm64 host. If we can merge this directly without squashing what would be the advantages of doing a separate PR?

alright makes sense, thanks!


Validation of translation placeholders for localized (it) string component.meross_lan.issues.cloud_token_expired.fix_flow.step.profile.description failed

Registratore: homeassistant.helpers.translation
Fonte: helpers/translation.py:345
Prima occorrenza: 15:23:48 (1 occorrenze)
Ultima registrazione: 15:23:48
Validation of translation placeholders for localized (it) string component.meross_lan.issues.cloud_token_expired.fix_flow.step.profile.description failed
-->
Version of the custom_component
v5.0.2
If you are unsure about the version check the const.py file.
-->
Configuration
Add your logs here.

## Describe the bug
message in the log from HA 2024.3.0

Looks like a duplicate of #400. At any rate it falls in the same category and I'm awaiting to understand what's going on with HA core since this was likely due to a recent change committed to the core which has no great documentation

It's effectively a bug in translations file...couldn't reproduce it until I've switched to the italian translations..

I updated the meross_lan integration to 5.0.3 version  and I can confirm the issue is resolved.
Thanks a lot


Simple OCR fixes

Some simple post-OCR replacements would make proofreading easier:

replace | with । and || with ॥
replace "[letter]: with the visarga form (i.e., दै: --> दैः)

In addition to / instead of automatically fixing this, may also be useful to have some sort of highlighting in the editor, so that we can easily tell apart | from । and || from ॥ and : from ः

Agreed for | and ||.
: is often legitimately a colon, particularly when used with Hindi. From what I've seen so far, Google OCR also tends to be pretty good about distinguishing colons and visargas.


Document arguments to onSelectionChange

To update the documentation. Works on iOS, so I assume this is the same on Android.

@mkonicek ping :)

I don't see pings on GitHub (too many notifications). Message me please :)

I don't see pings on GitHub (too many notifications). Message me please :)

Thanks for improving the docs!
@facebook-github-bot shipit

@facebook-github-bot shipit


Fixes #32 Add used redis channel to incoming events

Adds the redis channel used to events, useful for selecting filters and add dynamic data to events

@suyograo Let me know if is necessary to add a setting to enable/disable this feature

@joac - I think this is fine as is.
LGTM

Hi guys, do you have a timeline for merging this PR? Thanks!

merged in https://github.com/logstash-plugins/logstash-input-redis/commit/809495173b57f2864f9d19b027a9cb7a76a7aac4


How do you get last video snapshot URL for notifications?

I noticed my reolink cameras entities have the last video URL. I wanted to set up a push notification with a thumbnail (the thumbnail works fine with entity_picture url) but the video's last snapshot doesn't.
For some reason when I try to use the video_url I get 401 Unauthorized error.
Here is an example of a video URL that my reolink camera entity has.
video_url: /api/reolink_dev/vod/31531113ea98adae763ada6d2d6cb8ce/Mp4Record%2F2022-08-23%2FRecS02_20220823_165312_000000_2B14908_0.mp4
Thanks for the help!

I also noticed that there is a service call called "reolink_dev.query_vods" maybe someone can post an example using that? As I have not been able to get anything of it as it's not documented.

I didn't, I just gave up and switched to Frigate. Which also comes with its own set of problems.
The main issue I have is that I dont get reliable notifications from this integration. I compared the log from Reolink portal to my HA sensor and only about 30% of notifications are logged, for many the sensor becomes unavailable around the time notification happens.
I am sure this is due to the camera being busy recording the event and analyzing the frames. .. .. I think another solution could be to have the camera record to a local ftp server, then mount that drive into HA and create a sensor for when a folder updates. Then you have notification for motion (if you set it to take snapshots) and you have access to the latest clip as well.

think another solution could be to have the camera record to a local ftp server, then mount that drive into HA and create a sensor for when a folder updates.

thanks for the reply.  That's actually what I am already doing now.  works okay.

Just ok? Or good enough? I might switch back from Frigate and go with this method 😉

Well.  It works okay as I said but I'm trying to figure the best approach to have a lovelace card reflect that latest jpg very quickly.  I tried creating a local_file camera entity that works with a picture-glance but doesn't refresh quick enough.  There really isnt a great method for an immediate update in lovelace when the local file updates.
But I do get the ftp records fairly quickly and the sensor I have updating pretty quickly and ontop of that I use a gallery-card.

You could try to use a Frigate Lovelace Card, it works without frigate and you can set it to auto update a snapshot every second or so, it also allows you to auto switch to the camera with motion based on any sensor you give it. I am using it with a few none frigate cameras and it works great.

YEah I just started looking at that.  Frankly I didn't think the card was usable without frigate integration itself but its really an awesome card without frigate as well.  Its working perfectly now.  Thanks!


Update Dockerfile

Skip deprecated go-wrapper, newer images

I'm sorry that I made commit (0623faa0bcfaad8da141270f10683a13a675a2cd) almost the same changes as this pull request. I found this PR after the commit was pushed.
I appreciate your pull request.


Fixed markings color bug

Description
Where has this been tested?

Platform(s): Windows
Python version(s): 3.7.9
Unreal Engine version(s): 4.26

Possible Drawbacks

This change is

Unreal/CarlaUE4/Plugins/Carla/Source/Carla/Commandlet/PrepareAssetsForCookingCommandlet.cpp, line 54 at r1 (raw file):
Previously, bernatx (bernat) wrote…

MarkingNodeCenterMaterial

It is better to rename this variable names with something like MarkingNodeYellow, and the other with MarkingNodeWhite

Done.

Unreal/CarlaUE4/Plugins/Carla/Source/Carla/Commandlet/PrepareAssetsForCookingCommandlet.cpp, line 215 at r1 (raw file):
Previously, bernatx (bernat) wrote…
Here we need to check the name of the material, because RoadRunner does not export always in the same order, some times the yellow material can be the first one and other times will be the second one. So, I suggest to make a loop and check for each material name, if it has the yellow word, then assign the yellow material, otherwise the white one.

Done.


BOSS in 32 bit

There are a lot of issues with using ligpargen, as I understand it is related to BOSS coming as a 32 bit compiled code.
i.e. it will NOT run on a Mac (thanks for the recent 64 bit upgrade!) or any Linux that is 64 bit.
PS - to check what is your machine use uname -a
if you run BOSS directy, you will see errors like:
./boss/autozmat -x -i boss -o pdb -p tmppar
./boss/autozmat: Exec format error. Binary file not executable.

if you run ligpargen, you will get misguiding errors like:
FileNotFoundError: [Errno 2] No such file or directory: 'plt.pdb'
or
ERROR!    Open Babel is not installed on your work station.
as mentioned in issue #1
I guess it all just boils to getting BOSS for 64 bit.
@Isra3l also tagging @leelasd as another ligpargen guru :)
**Is it possible to get BOSS as 64 bit or non-compiled? **
Thank you!

Hey Valentina!
I have just fixed the open babel NOT installed error.
Sadly, BOSS source code and BOSS64 are not available but you can run any 32 bits program like BOSS in a 64 bits Linux by installing a few libraries. I am not sure if it is possible for Windows(WSL) or Mac.
For ubuntu check this link --->    https://askubuntu.com/questions/454253/how-to-run-32-bit-app-in-ubuntu-64-bit
I have been using many different Linux 64 bits distributions and I never had any problem with 32 bits executables.
My machine --->
Operating System: Ubuntu 20.04.2 LTS
Kernel: Linux 5.4.0-96-generic
Architecture: x86-64
The missing 'plt.pdb' file is an error related to BOSS. Adding these missing 32 bits libraries you should be able to run BOSS and fix this issue.
I hope it helps,
Israel


Card element is not de-focused on input blur

I've spotted this (in the card.js file):
QJ.on(el, 'blur', function() {
      return QJ.removeClass(el, 'jp-card-focused');
});

I believe that the removeClass should be applied to out instead

Thank you for the bug report and triaging, I really appreciate it. This is definitely a bug and will be fixed.
This is a terrific candidate for a first time pull request from someone new to contributing or open source. In order to fix the issue, here's what needs to happen.

Fork then clone the repo and get development running on your computer. Instructions here.
Replicate the issue. You should see that as you enter information, the jp-card-focused class does not get removed from the matching fields to inputs you previously were in.
Find the line of code in card.coffee that corresponds with the code snippet above.
Change the code to removeClass from out (the outputted display <div>) rather than el (the input where you are typing).
Verify that your fix works and that the jp-card-focused field is now being removed correctly.
Run NODE_ENV=production gulp build to build your changes in the production build
Commit your changes with an informative description
Open a pull request to this repo with your new commit and mention that you are fixing this issue.
I'll merge it in, then we'll digitally celebrate.

🎉🎊💫✨
Who wants to give it a go?


Add fix for primary selection behavior

Hi,
I successfully modified your script to fix this issue : selected text in url bar is not in primary selection when using CTRL+L or clickSelectAll. Personally I use CTRL+L to select the URL in the address bar. This use to put the URL in primary selection so that I can paste it somewhere with middle click. I use this a lot to copy/paste links.
After some trial and error, I found that adding this line in your script works (I'm not sure why or what side effects to expect) :
edit_file 'selection' 's#!this.window.windowUtils.isHandlingUserInput ||#//!this.window.windowUtils.isHandlingUserInput ||#' "${unpack_dir}/modules/UrlbarInput.jsm"

I will try to send you a pull request.

@SebastianSimon  You can have a look at what I have done here. After reflection, I won't send a pull request because, as you said in https://github.com/SebastianSimon/firefox-selection-fix/issues/9#issuecomment-832075523, broadening the scope of your script is a significant task.

So, I’m finally back at this script again. I’m currently trying your suggestion and there are a few undesirable things happening and a few things I can’t yet fully understand:
Ideally, copying selection into the clipboard should happen after these additional cases:

Pressing Ctrl + L
Pressing F6
Single-clicking into URL bar which selects all (if this behavior was enabled again, which now, since one of the recent commits, it can be)
Single-clicking into search bar which selects all

It shouldn’t happen in this case:

Switching to another tab

For me, your adjustment works well with F6 and with single-click selecting all.
However, Ctrl + L only appears to work immediately after switching a tab. Also, given two tabs A and B, when you focus the URL bar of tab A, then focus the URL bar of tab B, then switch back and forth between these tabs, the URL bar will actually become selected. This probably shouldn’t trigger clipboard copying.
However, the selection after a tab switch doesn’t seem to always happen. It may depend on certain mouse events happening in between, and Ctrl + L behavior may have something to do with it.
In particular, note that in UrlbarInput.jsm, select and _on_select don’t seem to be always called. select not being called probably isn’t so bad, as clipboard copying is handled in _on_select anyway.
But why and when _on_select is not being called still requires some investigation.
Have you run in any other trouble so far with your suggestion?

Let’s revisit this:

Have two tabs open, called tab A and tab B
Focus the URL bar of both tabs
Switch back and forth between both tabs

Based on some trial and error, it actually looks like there is a timing-based mousemove handling:

If the mouse is not moved at all, and you switch tabs using Ctrl + Tab and Ctrl + Shift + Tab, then the URL bar of the tab you’re switching to will always be selected.
If you switch tabs by simply clicking them, then the URL bar will always be deselected.
If you switch tabs using Ctrl + Tab and Ctrl + Shift + Tab while moving the mouse over the tab you’re about to switch to, then the URL bar will always be deselected.
If you hover over a tab you want to switch to and not move the mouse for around two seconds and then click on it, then the URL bar will always be selected.

Whether the URL bar of a tab you’re switching to will be selected or not, depends on whether the mouse has been actively moved over the tab within the last two seconds.
Crazy implementation…

I had not noticed all this. I use mostly Ctrl + L  and sometimes "single click select all" and I haven't seen any issue so far (but I'm not sure it is very solid / future proof).
Did you use the "primary select fix" in combination with "preventClickSelectAll" ?
My setup

Ubuntu 20.04
Firefox 89.0.1
fixfx-selection.sh --fix primaryselect only (with my version)

Tests with one tab
For theses tests, I right click on a link and choose open in new window.

Ctrl + L works (no delay)
Click in urlbar bar to select all works
F6 does not work straight away (pressing 3 times F6 work)

With multiple tabs, there is indeed some weird things going on (might be a firefox bug).

Did you use the "primary select fix" in combination with "preventClickSelectAll" ?

I’m currently testing this with -o preventClickSelectAll=false. I’ve tested your version, but currently, I’m just trying to figure out what exactly happens in which situations.
Another case: when a tab shows a loaded page, then if you type something into the URL bar, you can press Esc to restore the original URL of the tab. The URL gets selected. Should the selected URL also be copied to clipboard in this case?

Another case: when a tab shows a loaded page, then if you type something into the URL bar, you can press Esc to restore the original URL of the tab. The URL gets selected. Should the selected URL also be copied to clipboard in this case?

My opinion is that it should be copied. There are two competing rationale : one is to say that selecting text is not the intention of the user so it shouldn't alter the clipboard state ; the other is to say that "text selected" implies "text copied to primary selection" whatever the context. I am in favor in the second rationale because as a user I want things to be easily predictable. If the text is selected and not copied to primary selection, I feel like there is a bug (that's why the upstream bug was created).

"text selected" implies "text copied to primary selection"

But the selection state of the URL bar is remembered across tabs. If you select the URL in tab A, then switch to tab B to highlight something from the page to insert it back into page A, then upon switching to tab A, the URL bar becomes focused again and sometimes selected, overwriting whatever you just copied in page B. You’d have to always remember to defocus the URL bar before switching tabs.
Or should there be a tweak to not even select the URL bar in the first place when switching tabs?

Well... For me it is "selecting text" (the action) that put the text in primary selection. If the selection state is remembered, switching tabs does not / should not cause a selection event.
LibreOffice Writer does remember selection state when switching from one window to another for example, and last selection wins.

I think, I’ll make the tab switch behavior another option. I think I’m close to a solution, though:

Ctrl+L goes through openLocation in chrome/browser/content/browser/browser.js:2841,
a tab switch goes through _adjustFocusAfterTabSwitch in chrome/browser/content/browser/tabbrowser.js:1385,
most other edge-cases do not matter because this._getSelectedValueForClipboard() is the empty string and the if (!val) { return; } in _on_select is very useful for this.

I think I can simply set a few custom flags on window.windowUtils in each of the methods in cases 1 and 2 that will tell me, where the call came from. Since Ctrl+L always triggers select, but doesn’t always trigger _on_select, I can explicitly call _on_select if the flag for openLocation is set. These flags would then be cleared in _on_select.
I’ll try that later today or tomorrow.

Findings so far:

Adding these properties doesn’t work at all due to “NS_ERROR_XPC_CANT_MODIFY_PROP_ON_WN: Cannot modify properties of a WrappedNative”.

All of this is above my head. I'm sorry I can't help.

Don’t worry, I think it’s finished now: commit 361c393.
There are several edge cases and lots of things to test, and I introduced two sub-options: enabling clipboard selection when switching a tab (which may select the URL bar), and enabling clipboard selection when typing a URL which becomes auto-completed (and the rest of the URL selected).
The sed edits are not trivial; there was some asynchronicity and general DOM event uncertainty to handle. I will write an in-depth explanation some day in this repo’s wiki.

I probably should mention it here (but it’s also available in the README):

The new behavior can be enabled with ./fixfx.sh -o autoSelectCopiesToClipboard.
If you want URL bar selection, which is caused by switching tabs, to also be copied to clipboard, use ./fixfx.sh -o autoSelectCopiesToClipboard -o tabSwitchCopiesToClipboard.
If you want URL bar selection, which is caused by auto-complete while typing a URL, to also be copied to clipboard, use ./fixfx.sh -o autoSelectCopiesToClipboard -o autoCompleteCopiesToClipboard.
If you want all of the above, use ./fixfx.sh -o autoSelectCopiesToClipboard -o tabSwitchCopiesToClipboard -o autoCompleteCopiesToClipboard.

Thanks !
I'm not sure about the terminology "clipboard". I think there is no buffer for the primary selection (if the application is closed, then the primary selection content is lost). With Wayland I don't know how it works.
Users of the script will probably know what to expect though.


Write logic to set an eagerness level

Not sure if this was in the brief but was needed for the app to function

onClick callback (?) functions that alert high / medium / low when option is selected
modify the eagerness state (already exists in the source code)
iterate through the potential values / select based on index


Provided long term solution for broken build.

Added support for .Net reference assemblies located outside repository.
Changed reference assemblies for .Net 4.6 to MSIL in order to get rid of compilation warnings.

Wow! This is awesome!!


Add Polyfill Object.values

from polyfill.io
this is at stage-4 and will be included in es2017, so should be good to add

Coverage remained the same at 80.741% when pulling acc7ca55da1e68ca0c757da0af01323d73d7aeae on scottmo/ObjectValues into d59df2da95ca1eed158d2d6713597170ac68d83a on master.


tooltip doesn't change based on javascript if condition

I have a simple html script, and I use bs v3.3.5, and jquery 1.11.3. In short, I make a simple form validation, and firstly the title of an input textbox is "Required", and when some conditions are met, the title will update according to that condition (fe, if the name contains less than 3 letters, and the user presses the submit button, then the new title should be "Please insert at least 3 letters", and the form should not be submitted).
The problem is that the tooltip isn't changing according to my conditions. Can you, please, offer some tips or solutions, because in the last few days I'm feeling like it's easy to reach the limit of the Universe, than to resolve this problem :(.
codepen with the example: http://codepen.io/anon/pen/gpJgQV
Thank you.

Hi @dancostinel!
You appear to have posted a live example (http://codepen.io/anon/pen/gpJgQV.html), which is always a good first step. However, according to the HTML5 validator, your example has some validation errors, which might potentially be causing your issue:

line 8, column 1 thru column 6: Stray start tag head.
line 10, column 1 thru column 100: Element link is missing required attribute property.
line 12, column 1 thru column 7: Stray end tag head.
line 13, column 1 thru column 6: Start tag body seen but an element of the same type was already open.
line 15, column 23 thru column 32: Stray end tag content.
line 49, column 1 thru column 7: End tag for  body seen, but there were unclosed elements.
line 14, column 3 thru column 31: Unclosed element div.
line 50, column 1 thru column 7: Saw an end tag after body had been closed.
line 50, column 1 thru column 7: End tag for  body seen, but there were unclosed elements.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

Per CONTRIBUTING.md please do not use the issue tracker for personal support requests. Stack Overflow (twitter-bootstrap-3 tag) or Slack, or IRC are better places to get help with these types of requests.


When I use streaming upload, streaming download, the memory will continue to increase, and finally crash

atlantis-proxyman (1.24.0)

This happens whether the client software is started or no！

Each request has ~1Mb Response body and it's a lot.
Does your app actively do it? I means: Make a lot of huge request.

Yes, the app is downloading concurrently. Uploading pictures will also have this situation!

thanks, so Atlantis captures a lot of huge requests -> Increase the RAM usage. It's a bug.
Atlantis should release RAM after sending the traffic to Proxyman macOS.

For now, I suggest using normal proxy. Here is the docs: https://docs.proxyman.io/debug-devices/ios-device


No URI for video?

Why I did not get any URI for selected video?

Hello @FaizIkhwan,
I need to test on it, can you share with me your Android version?

My android version is 4.4.4


Feature/geolocation new js

Current coverage is 65.58% (diff: 68.42%)

Merging #110 into master will decrease coverage by 1.79%

@@             master       #110   diff @@
==========================================
  Files             2          4     +2
  Lines           233        247    +14
  Methods          19         24     +5
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            157        162     +5
- Misses           76         85     +9
  Partials          0          0

Powered by Codecov. Last update 83571a7...58938c4

This seems to render the map well, I get the geolocation error though. A rebase from master might fix that, if not I'll see if my chrome check was dropped in all the rollbacks from #108.


update the DatabaseNotification model to have uuid and delete the uui…

update the DatabaseNotification model to have uuid and delete the uuid creation from the NotificationSender

Why?


Add support for critical alert sounds

APNs now supports a dictionary for the aps.sound field, which can contain fields pertaining to critical alerts. This commit lets node-apn take a dictionary for the sound field. See: https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server/generating_a_remote_notification#2990112

Coverage remained the same at 100.0% when pulling efbde3f60d756e16db50e94a52477497d3ac222e on expo:critical-sounds into<PHONE_NUMBER>499fe53c9974b19f1b169d25649039 on node-apn:native-http2.

Coverage remained the same at 100.0% when pulling efbde3f60d756e16db50e94a52477497d3ac222e on expo:critical-sounds into<PHONE_NUMBER>499fe53c9974b19f1b169d25649039 on node-apn:native-http2.


Install dnscrypt on USB Modem

I'm using Huawei e3372 4G, how to install dnscrypt on usb modem?

Can custom firmware be installed on that modem?
I'm not familiar at all with it, so it's probably better to ask on forums about hacking these specific modems.


Updated: Create Embed

Added a debug button for users that have problems with the new version of this action.

Please remove this before the release. Thx


Update disclaimer to call out high priority issues

What was the problem/requirement? (What/Why)
3dsMax is in alpha version. We want to improve the communication regarding the current state of the project, to set the right expectations of our users.
What was the solution? (How)

Highlight the sentence in the disclaimer section, that calls out that the project is in alpha.
List out two open issues that are impaction the use of the submitter and the adaptor.

What is the impact of this change?
Set the right expectations regarding the state of the project.
How was this change tested?
N/A
Was this change documented?
Yes.
Is this a breaking change?
No.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Oh, semantic PR check failed. Can you update the commit wording? Maybe just prefix with doc:

Please change the PR title to doc: Update disclaimer to call out high priority issues


fix: improve metadata serialization

improve metadata serialization with orjson instead of torch serialization.

Method
Time Taken (1000 calls)

torch
70ms

json
2 ms

orjson
0.3 ms

ujson.
0.8 ms

rust, eh 😁


Option to change colour of code blocks

Always felt that the code blocks for the minimal theme were a really abrasive colour, would be nice to be able to change these similar to how the accent colour can be.

This is now an option in Style Settings as of Minimal 4.1


change error to warning for nodata value mismatch

Fixes #280
odc accepts this value, so its not an error. It ideally should match but its not an error,
related to https://github.com/opendatacube/datacube-core/pull/1347

https://github.com/GeoscienceAustralia/dea-config/issues/1110

I may have missed some of the discussion....but if it's a value that doesn't fit in the data type, shouldn't either be removed from the doc or changed to something that does fit?

moving the issue to odc-core


select dot-contaminated field names

Hello,
I am running 0.9.1, and facing the following:
Connected to http://localhost:8086 version 0.9
InfluxDB shell 0.9
> create database test
> use test
Using database test
> insert foo foo.bar.baz=1,foo.bar.bar=2
> select * from foo
name: foo
---------
time                            foo.bar.bar     foo.bar.baz
2015-07-24T05:17:12.089448826Z  2               1

> select "foo.bar.baz" from foo
ERR: unknown field or tag name in select clause: foo."bar.baz"
> select foo.bar.baz from foo
ERR: unknown field or tag name in select clause: foo."bar.baz"

This is either lack of documentation and inconsistency (because if "foo.bar.bar" is illegal name, then it has not to be inserted successfully) or select-statement parser issue.

Interestingly enough it requires two dots in the field key for this to show up:
> use mydb1
Using database mydb1
> insert foo foo.bar.baz=1
> select * from foo
name: foo
---------
time				foo.bar.baz
2015-07-24T23:09:15.842965617Z	1

> select "foo.bar.baz" from foo
ERR: unknown field or tag name in select clause: foo."bar.baz"
> select foo.bar.baz from foo
ERR: unknown field or tag name in select clause: foo."bar.baz"

> insert foo foo.bar=1
> select * from foo
name: foo
---------
time				foo.bar	foo.bar.baz
2015-07-24T23:09:15.842965617Z		1
2015-07-24T23:10:04.756877936Z	1

> select "foo.bar" from foo
name: foo
---------
time				foo.bar
2015-07-24T23:10:04.756877936Z	1

>

A single period works but multiple periods render a field unqueryable if explicitly referenced:
> insert foo foo.bar.baz=T
> select * from foo
name: foo
---------
time				foo.bar.baz
2015-08-18T23:43:49.398196253Z	true

#explicitly selecting the field returns nothing
> select "foo.bar.baz" from foo
> select foo.bar.baz from foo

# single period is fine
> insert foo foo.bar=F
> select * from foo
name: foo
---------
time				foo.bar	foo.bar.baz
2015-08-18T23:43:49.398196253Z		true
2015-08-18T23:44:55.967966035Z	false

> select "foo.bar" from foo
name: foo
---------
time				foo.bar
2015-08-18T23:44:55.967966035Z	false

# more than 2 periods leads to no results, as well:
> insert foo foo.bar.baz.bat=1234
> select * from foo
name: foo
---------
time				foo.bar	foo.bar.baz	foo.bar.baz.bat
2015-08-18T23:43:49.398196253Z		true
2015-08-18T23:44:55.967966035Z	false
2015-08-18T23:46:40.447532248Z				1234

> select "foo.bar.baz.bat" from foo
>

This actually turns out to be a problem ONLY if the measurement matches the first segment of the field being asked for.
fails:
> use mydb1
Using database mydb1
> insert foo foo.bar.baz=1
> select * from foo
name: foo
---------
time                foo.bar.baz
2015-07-24T23:09:15.842965617Z  1

> select "foo.bar.baz" from foo
> select foo.bar.baz from foo

works:
> use mydb1
Using database mydb1
> insert cpu foo.bar.baz=1
> select * from cpu
name: cpu
---------
time                foo.bar.baz
2015-07-24T23:09:15.842965617Z  1

> select "foo.bar.baz" from foo
name: cpu
---------
time                foo.bar.baz
2015-07-24T23:09:15.842965617Z  1
> select foo.bar.baz from cpu
name: cpu
---------
time                foo.bar.baz
2015-07-24T23:09:15.842965617Z  1


[ibex/doc] initial ibex checklist

Creating this PR to address #773 - as mentioned in that discussion, we are assigning Ibex V1 status for right now, but we might need to slightly alter this checklist format to more directly address Ibex, since it doesn't follow any of the comportability guidelines.

@vogelpi - thanks for the comments!
@all - this PR got killed after I forked off the new OT repository, forcing me to create a new PR for this checklist, it is available at #872.

Merged the updated version https://github.com/lowRISC/opentitan/pull/872 instead.


Provide necessary auth to GitHub Actions bot

Trying to fix the problem that involves the package not appearing in its own repository.

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Broken: uses a non-existent function

I get this exception originating from the plugin when I try using it. Was this written for an old version of jquery, or with an undeclared dependency?
jQuery.Deferred exception: this.each is not a function r.fn.qrcode@http://localhost:8000/static/js/jquery-qrcode.min.js:26:69
shortcut_info.init/populateQR@http://localhost:8000/static/js/info.js:53:6
@http://localhost:8000/potato/?info:36:7
g/</j@http://localhost:8000/static/js/jquery.js:2:29946
g/</k<@http://localhost:8000/static/js/jquery.js:2:30262
 undefined

Guess this isn't maintained


Update explore.jsx

Same here.... you don't have to create a separate PR for each new commit/update....you could have pushed new commits to the same branch.... we would continue with the PR #5 for now :)


fix(algolia): make search footer respect searchPagePath

Pre-flight checklist

[x] I have read the Contributing Guidelines on pull requests.
[ ] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
[x] If this is a new API or substantial change: the PR has an accompanying issue (closes #8535) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs

LGTM thanks 👍


Update user and developer guide for customised alias

Pull Request Test Coverage Report for Build 84

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.114%

Totals

Change from base Build 83:
0.0%

Covered Lines:
1601

Relevant Lines:
1881

💛  - Coveralls


Added versioning to reset local storage on updates

On change in version, browser clears storage, sets latest version, and reloads page


Pin seven_zip cookbook for Chef-Client 12

The seven_zip cookbook has moved on to requiring Chef-Client 13 so pin to version ~3.0.0 which is the last to support Chef-Client 12.

Did the feedback myself in https://github.com/bloomberg/chef-bach/pull/1304/commits/29b8680a384016926af39ad95e28fb020e474ed6


Added "atomay" icon series #12

Some fun variations, for the enthusiasts out there. #12
Font used: Playfair Display

Thanks for contributing. Sorry for the delay in merging.


fix(executor): Remove 15s guard for Docker executor. Fixes #6415

Signed-off-by: Alex Collins<EMAIL_ADDRESS>Fixes #6415

@whynowy bump!


Fix Spring integration tests for sovereign clouds

Description
There's a bug in Spring Cloud Azure autoconfigure when copying properties from spring.cloud.azure.eventhubs.xxx to spring.cloud.azure.eventhubs.producer|consuemr|processor.xxx, if the latter already has a default value, the copy won't be effective.
This PR is to fix this bug and refactor IT modules to reduce the surfacing ENV variables.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

/azp run java - spring - tests-weekly

API change check
API changes are not detected in this pull request.

/azp run java - spring - tests-weekly

/azp run java - spring - tests-weekly

/azp run java - spring - tests-weekly

/azp run java - spring - tests-weekly

/azp run java - spring - tests-weekly

/azp run java - spring - tests-weekly

/azp run java - spring - tests-weekly

/azp run java - spring - tests-weekly

/azp run java - spring - tests-weekly

/azp run java - spring - tests-weekly

/azp run java - spring - tests-weekly

/azp run java - spring - tests-weekly

/azp run java - spring - tests-weekly

/azp run java - spring - tests-weekly

/azp run java - spring - tests-weekly

/azp run java - spring - tests-weekly

Hi @benbp, I ran into an issue of failing to provision the cosmos database in Azure China Cloud.
I tried to run ./eng/common/TestResources/New-TestResources.ps1 on my local machine or copy the ARM template to Azure Portal, and they all succeeded.
The ARM template file is like https://github.com/Azure/azure-sdk-for-java/blob/c8cb5c1b503367423c93b837057f28308ef920f9/sdk/spring/spring-cloud-azure-integration-tests/test-resources/cosmos/test-resources.json#L1-L211
and you can find the error message here https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1827368&view=logs&j=f6cd9d1b-db6b-5aad-05d5-bfb021ebbd54&t=aa69fa7e-1a04-55e2-c533-3157be69fd83&l=6674.
Since I don't have permission to access the logs correlated to the CorrelationId: 739c56db-c03f-4434-96bb-652ca9ed9731. So could you help take a look at this?

@saragluna the first error I'm seeing from that deployment is here
"message": "Database account creation failed. Operation Id: 43d9739f-845d-4422-b08a-c524aaa47472, Error : Service is currently unavailable. More info: https://aka.ms/cosmosdb-tsg-service-unavailable

We have been having some networking issues with our agents due to a new firewall that we are working on. My first suspicion is the error is either due to that, or a transient issue with the cosmosdb service in the china cloud. Was there much of a difference between the tests you ran on Wednesday (august 31st at 6:17am UTC) vs. the most recent run? Because the Wednesday tests looked to succeed for most runs except macOS.

@saragluna the first error I'm seeing from that deployment is here
"message": "Database account creation failed. Operation Id: 43d9739f-845d-4422-b08a-c524aaa47472, Error : Service is currently unavailable. More info: https://aka.ms/cosmosdb-tsg-service-unavailable

We have been having some networking issues with our agents due to a new firewall that we are working on. My first suspicion is the error is either due to that, or a transient issue with the cosmosdb service in the china cloud. Was there much of a difference between the tests you ran on Wednesday (august 31st at 6:17am UTC) vs. the most recent run? Because the Wednesday tests looked to succeed for most runs except macOS.

Thanks @benbp. Yes, there was a difference between them. The one on Wednesday I disabled the cosmos provision, and I kept seeing this error for 3 weeks.

/azp run java - spring - tests-weekly

Azure Pipelines failed to run 1 pipeline(s).

/azp run java - spring - tests-weekly

/azp run java - spring - tests-weekly

@yiliuTo, @Netyyyy, @moarychan please help review this PR.

/azp run java - spring - tests-weekly

/azp run java - spring - tests-weekly

/azp run java - spring - tests-weekly

/azp run java - spring - tests-weekly

/azp run java - spring - tests-weekly


Is this project actively maintained?

I need to implement a distributed auth system where policies are defined/ maintained in a central service while decision/ enforcement is delegated. Requests pass thru a central gateway that has access to the IAM system (to authenticate tokens and enrich the request with an ACL and info about the bearer) but not data from the destination system.
py-abac looks particularly nice because policies are succinct and serialisable. I could find/ match applicable policies in our gateway (on say subject and context attributes) and add them to the request and let the backend application enforce them. Best part of all I can use the same library in both places and not require further inter-service communication.
Is this library used in a production application anywhere do you know? Would you welcome pull requests to be able to achieve the above? I'm fairly new to ABAC, but I was thinking either:

create a new PAP that takes a storage instance and is able to match/ export a list of policies, or
extend the PDP to do the same

Appreciate your efforts so far... if nothing else it's helped to see how someone else has approached this design in Python :)
And thanks in advance for your thoughts!

Thanks @ketgo - what & where do you think the best api would be to query and return applicable Policy objects? Best to extend the current PDP implementation or in a new class?

Hi @followben, apologies for the late reply. Currently I am on commute for a few days and have bad internet connection. Regarding your question, I think creating a PAP which takes an instance of storage makes better sense. However, you would need to share the backend storage with the PDP since it would need it to retrieve policies for evaluation.


[FEAT] Workflow for closing Old PRs

The purpose of this feature is to automate the management of open pull requests (PRs) in a repository. It ensures that outdated or abandoned PRs are closed promptly, which helps maintain repository hygiene, improves workflow efficiency, and provides a better experience for both maintainers and contributors.

@thestarsahil I opened the same issues a few days back and this is how you responded to them:

and now you have assigned all the same issues to this guy, How can you do that bruh!!!

@thestarsahil You must close them all as you wanted issues focusing into Building WebApplication rather than this side part
Thank you!


Improve DX for ntl build + ntl deploy command sequence

Problem
Some users will run the build command followed by deploy with the expectation of it being a two-step process, in which the first command creates a set of artefacts that the second command deploys. Unfortunately, this isn't always the case.
For example, imagine a site with a plugin that modifies certain configuration properties related to functions, via a onPreBuild hook. When running build, those changes will affect the functions bundling stage and the generated zip archives will have the expected contents. But if a deploy command follows, the functions bundling stage will run again, except this time the plugin will not run, so the changes to the configuration will not take place and a new set of zip archives (with the wrong result) will be deployed instead of the ones generated previously.
Proposed solution
When functions are bundled as part of the deploy command, the zip archives are placed in a .netlify/functions directory. The deploy command could treat this directory as a bundling cache, so that if exists, it skips the bundling stage and directly uploads the archives that have been previously generated.
Caching is always difficult and we want to make sure we minimise the risk of deploying the wrong functions, so here are a few scenarios and how CLI would respond.
Scenario 1: Using ntl deploy without ntl build
A user uses ntl dev or any other development server to develop their site locally. To deploy, they run their build command (e.g. npm run build) and then deploy to Netlify using ntl deploy. They don't use ntl build as part of their workflow.
In this scenario, CLI would continue to work in the same way, since the deploy command does not create a .netlify/functions directory, so the functions would be bundled each time.
Scenario 2: Using ntl deploy --build
A user uses ntl dev or any other development server to develop their site locally. To deploy, they use the netlify deploy --build command, which will build their site and deploy it in one go.
In this case, we can safely skip the functions bundling (see https://github.com/netlify/cli/issues/2596), since we know for a fact that the build and the deployment are an atomic operation.
Scenario 3: Using ntl deploy followed by ntl build
A user uses netlify dev or any other development server to develop their site locally. When they're ready to deploy, they use the ntl build to build their site followed by ntl deploy to finalise the deployment.
In this case, we know that .netlify/functions will contain the correct functions, bundled and ready for deployment, by the time ntl deploy starts, so we can skip a second bundling stage.
It's worth noting that if the user modifies the source of a function between the ntl build and ntl deploy commands, CLI will deploy the wrong function (i.e. the cached version instead of the newly-modified one). However, in this scenario we've established that the user relies on the CLI to build their site, so I think it's reasonable to expect that a deploy needs to be preceded by the ntl build command, which in its turn would update the cache for the next ntl deploy invocation.
We could put some extra measures in place to reduce the likelihood of us deploying the wrong functions, such as:

Show a message as part of ntl deploy with the timestamp of the functions being deployed and instructions for forcing a refresh. Something like:

Deploying X functions created on 2021-07-27 at 17:49:00. To bypass the cache, run netlify deploy --build

(Note: the deploy command already has the flag it needs to force the functions to be re-bundled: --build)

Set a TTL for the cached functions. When ntl deploy finds a .netlify/functions directory, it discards it if it's older than a pre-configured interval.

When ntl deploy runs and finds a .netlify/functions directory, it compares the hash of each function in the cache against the hash of the functions it finds in the configured functions directory. If any of the hashes differ, the cached function is discarded.
⚠ Note: We don't know which files contribute to the function output until we bundle it, so it only makes sense to create a hash of the function's main file. In practice this means that we wouldn't be able to detect changes to the function's supported or included files using this mechanism, making its relevance questionable.

Any thoughts are very much appreciated! 🙇🏻

i think these are all great scenarios!
in scenario 1, does ntl deploy run the plugins in place of ntl build? right now i expect that from ntl build or ntl deploy --build
scenario 2 i probably find the most "confusing" out of the three. i've always found it a bit weird that the deploy command has a --build flag when ntl build exists, but that could just be me!
scenario 3 we discussed on slack and is the workflow i'm most used to/comfortable with. i could definitely see a case for doing away with ntl build if scenario 1 somehow does everything. i think this would mimic vercel's api.

Linking some issues for context, https://github.com/netlify/cli/issues/179, https://github.com/netlify/cli/issues/1671 and https://github.com/netlify/cli/issues/1591
Some users were/are expecting ntl deploy to run a build. As Build Plugins role in the build increases, this expectation becomes stronger.
For the specific use case of function bundling I think we can always deploy from .netlify/functions if exists.
@eduardoboucas, we'll need to consider that in some cases (e.g. Essential Next.js plugin) function changes can be generated by plugins, for example a user changes their site's code, the plugin generates a different function as a result, so we won't know which functions changes until we run a build.
I think we can experiment with TTL/Timestamps and see how it goes.
Another option is to do a breaking change in ntl deploy to always run a build and provide a flag to skip it.
Also we might provide additional warnings if the user has plugins configured (as those are the main reason to use ntl build at the moment).

Before anything else, I should clarify that the goal of the three scenarios above isn't to pick one flow in favour of the others. I was just trying to capture ways in which people might use the CLI today, and how well the proposed solution stacks up against people's expectations.
Now to @lindsaylevine's points:

in scenario 1, does ntl deploy run the plugins in place of ntl build? right now i expect that from ntl build or ntl deploy --build

No. Plugins would continue to run only on ntl build and ntl deploy --build.

scenario 2 i probably find the most "confusing" out of the three. i've always found it a bit weird that the deploy command has a --build flag when ntl build exists, but that could just be me!

I think there's place for both. If you know you want to build and deploy, I think it's useful to have a single command for that sequence of operations. But you might want to simply build the site, in which case it's important that ntl build exists on its own.
And @erezrokah's points:

For the specific use case of function bundling I think we can always deploy from .netlify/functions if exists.

I think this would solve the majority of problems we're currently seeing with the relationship between these two commands, since any functions created by ntl build (e.g. via plugins) would be respected in ntl deploy.

@eduardoboucas, we'll need to consider that in some cases (e.g. Essential Next.js plugin) function changes can be generated by plugins, for example a user changes the site's code, the plugin generates a different function as a result, so we won't know which function changes until we run a build.

Yes, I shouldn't even have mentioned point 3, despite the alert. I think any attempts to diff the functions will be problematic, so we should avoid going down that path.

Some users were/are expecting ntl deploy to run a build. As Build Plugins role in the build increases, this expectation becomes stronger.
(...)
Another option is to do a breaking change in ntl deploy to always run a build and provide a flag to skip it.
Also we might provide additional warnings if the user has plugins configured (as those are the main reason to use ntl build at the moment).

That's interesting! If ntl deploy runs a build, why would you ever use ntl build? I fear this would not help with the confusion between the two commands, and might actually contribute to it.
Also, one consequence of that breaking change would be people building their sites twice, if their workflows use ntl build + ntl deploy. This would catch people off-guard, since builds would continue to succeed but they would start taking twice as long.
I'm not saying I'm against it, I just think we need to have a deeper think about the commands we make available if we decide to go down this path, and whether some of them become redundant.


Prep package for upload to PyPI

@clintonb please review.
Note that I've not modified the .travis.yml in this repo to facilitate upload to PyPI. This doesn't appear to be a package that we expect to change frequently, and Travis doesn't currently watch this repo.

I've pushed a change upstream in https://github.com/jpadilla/django-rest-framework-oauth/pull/12 which eliminates the need for this fork. I'll close this and add a deprecation warning to this repo's README.


Add a support for pip install with sudo

I found that pip command's stderr doesn't containing any information for failure. This just looking into stdout as well as stderr to see what's the problem with pip command.
This fixes #136 which has not permission required text in stderr not filtered with rules/sudo.py.

@SanketDG Thank you for the comments. This was my terrible mistake. I fixed my source code.

Maybe it'll be better to add support of pip to sudo rule?

@nvbn If so, Is it okay to add filter for stdout as well as stderr in sudo rule? I'm worrying about side-effects.

@kimtree it's ok, I added it by myself.


refactor: using blacklist approach instead of whitelist for launch args

Suggestion for #2822, merges into that PR
Additional benefit is that it becomes easier to be aware of which arguments exactly are not supported by each launcher, just by looking at the code (work to be done to add support for some of these unsupported arguments?).

@raph-luc, regarding this PR, though the code looks compact, however, I think getting a view of the arguments specific to the type of the launcher at this level is good.
What do you think @seanpearsonuk, @mkundu1, @hpohekar

@prmukherj If we want to check which arguments are valid for each launcher by looking at the code, we can easily look at the already existing launcher __init__() methods instead to get the full list. However, we do not have the unsupported arguments easily listed anywhere that I've seen (outside of my suggestion here).

@raph-luc
I have identified this issue.
>>> from ansys.fluent.core.launcher import create_launcher
>>> from ansys.fluent.core.launcher import LaunchMode
>>> solver = create_launcher(LaunchMode.STANDALONE)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "D:\pyfluent\src\ansys\fluent\core\launcher\launcher.py", line 61, in create_launcher
    if kwargs["dry_run"]:
KeyError: 'dry_run'

Then if we update if kwargs["dry_run"]: to kwargs.get("dry_run"): then we get following error.
>>> from ansys.fluent.core.launcher import create_launcher
>>> from ansys.fluent.core.launcher import LaunchMode
>>> solver = create_launcher(LaunchMode.STANDALONE)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "D:\pyfluent\src\ansys\fluent\core\launcher\launcher.py", line 65, in create_launcher
    mode=kwargs["mode"],
KeyError: 'mode'

For each optional arguments we get key error due to use of kwargs[<argument_name>] if it is not provided by the user.

@hpohekar indeed, part of that is exactly what I said here: https://github.com/ansys/pyfluent/pull/2826#discussion_r1603013555. I see similar issues in your branch fix/launcher_argvals_refactoring:
>>> import ansys.fluent.core as pf
>>> from ansys.fluent.core.launcher.pyfluent_enums import LaunchMode
>>> pf.launcher.launcher.create_launcher(LaunchMode.STANDALONE)
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "C:\ansysdev\pyfluent\src\ansys\fluent\core\launcher\launcher.py", line 61, in create_launcher
    _process_invalid_args(kwargs["dry_run"], fluent_launch_mode, kwargs)
KeyError: 'dry_run'

The root issue here is not related to my changes. As I already mentioned here: https://github.com/ansys/pyfluent/pull/2826#discussion_r1603013555, if the intention is to expose create_launcher() directly to users, there some work that we still need to do so that it works properly for the various launch modes. I think these issues should be addressed in a separate PR as they already existed before these changes.

@hpohekar indeed, part of that is exactly what I said here: #2826 (comment). I see similar issues in your branch fix/launcher_argvals_refactoring:
>>> import ansys.fluent.core as pf
>>> from ansys.fluent.core.launcher.pyfluent_enums import LaunchMode
>>> pf.launcher.launcher.create_launcher(LaunchMode.STANDALONE)
Traceback (most recent call last):
  File "C:\ansysdev\pyfluent\src\ansys\fluent\core\launcher\launcher.py", line 61, in create_launcher
    _process_invalid_args(kwargs["dry_run"], fluent_launch_mode, kwargs)
KeyError: 'dry_run'

The root issue here is not related to my changes. As I already mentioned here: #2826 (comment), if the intention is to expose create_launcher() directly to users, there is some work that we still need to do so that it works properly for the various launch modes. I think these issues should be addressed in a separate PR as they already existed before these changes.
Edit: created an issue tracker so that we don't forget to address these issues: #2827

@raph-luc I will look into this issue. I have resolved this locally by using whitelist approach but we will merge this PR first then I will create a separate PR to address this. Thank you.

I'm generally fine with both approaches, I think both are equivalent w.r.t. catching unsupported arguments. The only thing about the blacklist approach, for example if I add a new argument for slurm launcher, I need to remember to exclude it from all other launchers (the testing requirement will not be isolated to my change).

Thanks @mkundu1, I think that is a fair point, though I don't think that is the best example as we already have a dict scheduler_options for the SlurmLauncher; there'd be no reason to add a new SlurmLauncher argument compared to just adding it to scheduler_options, in my understanding.
Regardless, I would raise the counterpoint that in general most launcher arguments should work for all launchers, do you agree/disagree? Outside of the obviously specific arguments such as container_dict and scheduler_options, all/most of the others should ideally work for all launchers in my opinion. For example, shouldn't we support the specification of journal_file_names, case_file_name, case_data_file_name, etc., for the DockerLauncher as well? Same thing for the others.
It follows that if we are adding a new argument (that I would expect is most of the time going to be relevant for all launchers), we should support it in all launchers, otherwise we will indeed need to specify which launchers do not support that new argument, which seems like good practice to me.
Does this make sense? Let me know if you prefer to discuss this in a meeting/call, we can discuss next week as well. Regardless, this was just a quick suggestion that is already resulting in way more discussion than I ever imagined, feel free to just disregard if you prefer.
Note also that the SlurmLauncher seems to be defined differently from the other launchers currently, and is just ignoring unsupported arguments with no warnings or anything of the sort.


celocli fails to execute lockedGoldUnlock on ledger

Received the following error on telegram today.

### Tasks

Just some extra info here. I am pretty sure issues start after @celo/... packages upgraded to version 5.x.x . Versions 4.x.x with<EMAIL_ADDRESS>still seem to work for now.
This same issue is blocking upgrade of @celo/... packages inside Celo Terminal too. If I upgrade them to 5.x.x versions, Ledger devices completely stop working.

Closing this as it's duplicate of #195


Pseudoterminal has invalid name in insider version

Does this issue occur when all extensions are disabled?: No

VS Code Version: 1.57.0-insider
OS Version: win10 19043.985

Steps to Reproduce:

Open task-provider-sample with insider version
Add some code to get the terminal name. In customTaskProvider.ts, add the following code in the beginning of open() of the CustomBuildTaskTerminal (line 91)

const terminals = vscode.window.terminals;
const terminalNames: string[] = [];
for (const terminal of terminals) {
	terminalNames.push(terminal.name);
}

Add a breakpoint after this part and start debugging.
Configure and run task custombuildscript: 32 incremental, VS Code will stop at the breakpoint, we can see the current terminal names, in the insider version, it's an empty string (see the red square):

Reopen task-provider-sample with stable version, follows the steps 2 and 3 above
Configure and run task custombuildscript: 32 incremental, VS Code will stop at the breakpoint, we can see the current terminal names, in the stable version, it's a valid string (see the red square):

Scenario: I'm developing an extension which might use terminal.show() by filtering the terminal names. If a terminal's name is empty the feature to show the terminal will not work.

I see the name is available shortly after initialization:

Marking candidate since this breaks at least one extension and it's a regression. I investigated it and the fix is also very low risk.

Thank you @Tyriar !


Bump tokio to 1.0 and reqwest to 0.11

Thanks! I will release a new crates.io version shortly.

Thanks! I will release a new crates.io version shortly.


Logger output does NOT appear in the Output Window

[Enter feedback here]
The article states:
"The Logger class contains static methods to write to the Output Window."
This is not correct.
Using Visual Studio Professional 2019 v16.11.16 with a C++ "Native Unit Test Project" project. When the tests are debugged or just run, Logger::WriteMessage("my message"); commands are not displaying anything in the Output Window.
I raised this issue on StackOverflow:
https://stackoverflow.com/questions/75439723/microsoft-native-unit-test-for-c-where-is-the-logger-output-going
Someone pointed out in a comment that the output is actually displayed in the "Test Detail Summary" section of Test Explorer. They tried this is Visual Studio 2022. I can confirm this is where my messages are being displayed in VS 2019 as well.
The documentation is wrong and misleading. Also, the feature is not very usable. In order to see the summary, you have to allow the whole test to complete, and you cannot see the message "live" as you debug. This might be its' intended use, in which case the documentation might point this out.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 51e3ec17-4193-8059-56de-fbad2fab239c
Version Independent ID: e0e84806-41ff-fa5e-1aa1-775beed16d78
Content: Microsoft.VisualStudio.TestTools.CppUnitTestFramework API - Visual Studio (Windows)
Content Source: docs/test/microsoft-visualstudio-testtools-cppunittestframework-api-reference.md
Product: visual-studio-windows
Technology: vs-ide-test
GitHub Login: @corob-msft
Microsoft Alias: corob

The issue (incorrect documentation) is still valid and should (hopefully) be actioned.

@abdekker -- thank you for your follow-up.
@TylerMSFT -- please look into this issue.

Will do, but this is lower on my priority list and my list is very long right now. I will mark this as triaged and get to it as I'm able.


Add type to projectsData.ts

Without this, I get a build failure due to the TS checker.

The project has strict mode set to false. You might have enforced it. In any case, thanks for the enhancement!