Add ssh url scheme handling

Fixes #2039
PR is ready to be merged
Tested and working in macOS.
App also sets itself as the default ssh protocol client (only need to change defaultSSHClient boolean in app/config/config-default.js if user desires otherwise).
The URL components are retrieved using some simple regular expressions, it currently supports URLs of the type ssh://[username@]hostname[:port][[/]initial/remote/path]
Here is a short video showing the feature working: https://www.youtube.com/watch?v=gprDu_8n0KM
Note: Although it appears as if package.json was heavily modified, only a few small changes were made, however indentation issues made git recognise it as otherwise

Travis CI's check failed because it timed out after 20 minutes downloading a file at very slow speeds, the previous commit passed without problems

Probably this error is related with Travis CI Status

@albinekb I believe all is ok now (once again)

I must test it against HyperCLI and test if we can add multiple URL schemes.
I will do it ASAP

Update:

ssh url parsing is now made using parse-url
path is now ignored
@chabou

@antonioalmeida I added 2 commits:

First one to remove Hyper from default client for ssh:// protocol when user change its config.
Second one to deal with parse-url dependency. We only use yarn (with pinned dependency) and its yarn.lock lockfiles. And we need to add package to app/package.json when it is used by main process.

It works great. Thank you so much 🙏 . I'll merge it ASAP.


Images with display:none get 0x0 dimensions

Whilst trying to get an image slider working with retina images I discovered that if images have the CSS property 'display:none' they will be assigned '0' to their width and height attributes, even if width and height are specified in the CSS or HTML.
I fixed this by checking that offsetWidth and offsetHeight are non-zero before assignment:
if (that.el.offsetWidth && that.el.offsetHeight) {
that.el.setAttribute('width', that.el.offsetWidth);
that.el.setAttribute('height', that.el.offsetHeight);
}

Yeah, still broken... Please fix!

This bug still not fixed in the 1.3.0 version.

Same problem with v1.3.0

Boy, they sure took their sweet time to roll in my proposed changes into the repo. Still, sweet, sweet validation at last! :lollipop:

Had this issue today, Can confirm resolved in above fork.... +1

+1

Still this issue today, v1.3.0

+1

+1

http://dense.rah.pw/
Works fine, also with hidden elements. (you only have to edit the glue var from _ to @)

KamoKamoAgiZsombor

masodikharmadikelsoelso

elsoharmadik


Revert "Update the iso_contours example using iso_surfaces operator"

Reverts ansys/pydpf-core#1164

Necessary due to incompatibility between this new version of the example and DPF 2024.1.pre0.
This PR should be revert itself once ansys-dpf-core for DPF 2024.1.pre1 is under preparation.

@PProfizi I don't understand. Wouldn't it be better to just mark it as limited to versions >=7.1?

@rafacanton sadly no, since it already appears in the doc in its older version, we can't just bump the required version to a DPF verion that is not released yet. The point is we don't want to it disappear upon the release of a new ansys-dpf-core, which is what would happen if we mark it as requiring a higher DPF version than what is currently available.

When generating the doc, we filter out the examples that require a DPF version superior to what is being used to generate the doc.


Changed oauth2AuthenticationProvider.qute to not be generated

Fixes: https://github.com/quarkiverse/quarkus-openapi-generator/issues/242
There's a tiny piece of code that still needs to be generated because of clientId: https://github.com/quarkiverse/quarkus-openapi-generator/pull/248/files#diff-1fa4a5b1488fae8e12f5730d80671494aee2bdff745d5f13df3911575b84a7b5R199-R210

Cherry-picked to quarkus2 branch: https://github.com/quarkiverse/quarkus-openapi-generator/pull/249


Support checkout

Closes #4
buildkite run

Currently basic set of tests pass for this PR :tada:

All tests passed for checking out different refs :tada:


Change swimming text to include "water safety"

Description
Change "Swimming" text to be "Swimming and water safety"
Issue(s)
Fixes

CUR-954
CUR-955
CUR-956
CUR-957
CUR-958

How to test

Enable cycle 2 locally and test for copy change
Go to https://deploy-preview-2867--oak-web-application.netlify.thenational.academy check for regressions

:tada: This PR is included in version 1.585.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fix: Mobile screen rotation fix

This pr fixes the current visual bug, when the plugin is used on a mobile device in landscape mode (See pictures).
Further more this pr also adds a "how to develop & test ui changes" to the contribution page, so that these issues wont arise again in a future ui change.
PC design

For reference: Old design used on a pc

New design used on a pc
Mobile design

For reference: Old design on a mobile device in landscape mode with the visual bug

New design on a mobile device in landscape mode

Old design on a small mobile device in landscape mode with visual bug

New design on a small mobile device in landscape mode
New contributing text

The thought process behind the end design
The whole thing broke because I didnt check the mobile landscape mode, when I developed the more detailed session progress title text and didnt assume that someone moved everything around so dramatically.
Someone wanted to make room in the mobile landscape mode and has thus moved all the buttons to the side, to open up some space in the middle (see #990 & #998).
To fix this, I moved the progress text to the card context area, shrunk down the response buttons for small screens and only moved the upper control buttons to the left side in the landscape mode, such that more space is opened up for viewing the cards. I did my best to respect the wish to have more viewing space and at the same time to have a good and consistant design


how to add decorator base core-decorator

I want to add some decorator based on  core-decorator. How to add ? Can the author support the AddDecorator API for developer? Not fork the repo~

If you'd like to have a new decorator added to core-decorators the best thing to do would be to create a proposal--basically just describe what it does and why you think it belongs in core-decorators instead of in its own library. 😄


Fix build for C++17

In C++17, std::unary_function was removed from the standard library. Also, the functor works fine without it.

Thanks!


Add troubleshooting guide

Disregard the recommendations below if you use Edit on GitHub button to improve the docs in place.
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This enables GitHub to link the PR to the corresponding bug and close it automatically when PR is merged.
Thank you for the contribution - we'll try to review and merge it as soon as possible. 🙏
Fixes #871

@jorgeorpinel @pared let's create a user guide Troubleshooting section. I don't like this duplication and complication of the command reference. We can create a separate page per error, or for now a single page with expandable blocks or h2 segments.

@pared let's wait on @jorgeorpinel before doing this change above ^^

@shcheklein my initial https://github.com/iterative/dvc.org/issues/871#issuecomment-566755326 was

If it will fit in a single paragraph I recommend using existing docs, probably some of the command references. It can be repeated in a few ones wherever it's appropriate.

We have several of these repeated notes, paragraphs, sentences in different docs already, especially command references. It makes sense since there's overlap in functionality or implementation details in many places.
I don't think we need a Common problems section though, since there's only one and can't foresee having others in the immediate future. Maybe just add the paragraph in the bottom of the Description section? Starting with "A known issue..."

If it will fit in a single paragraph

It looks like it does not, right? at least it'a big paragraph already :) And it would be an artificial constraint to try to keep error explanations like this very short.
also, this is an edge case, it's not that important to include it into description for all commands (3 places at least?)

We have several of these repeated notes, paragraphs, sentences in different docs already, especially command references.

they are usually small, there are not so many of them, and it might be a problem for some of them that they are repeated. And to my point above - they are usually general enough and highlight some important workflow (like installing S3 with DVC), they do not serve as an explanation of an error code.

I don't think we need a Common problems section though

I like Troubleshooting as the name, someone has used it already in some comment - it makes sense to me :)

can't foresee having others in the immediate future

I can easily add a few :)One of the most commons - what should I do when I get "DVC is busy" message. There will be more and more as we move forward and improve interface.

let's create a user guide Troubleshooting section

To be clear I'm not opposed to this. It's a good option, and just link from these command refs. Also @pared please notice my other https://github.com/iterative/dvc.org/issues/871#issuecomment-567231227 in the issue:

Maybe also checkout since it can include pull. Consider adding the note in the remote index page too.

at least it'a big paragraph already

Indeed, it's a long one @shcheklein even my shorter version. Would be nicer to split it in 2.

I like Troubleshooting as the name

Yes, I like it too. Or/and Known issues

I would say: Known issues and Troubleshooting have different meaning to me. First is about actual existing bugs (and probably our GH issue tracker represents it really well, though it can be complimented with some docs if some issues are not going to be fixed ... ever). Second is about solving troubles - they are not necessarily issues to me.

Agree. This file descriptor thing to me sounds like an issue that could have a code solution to me. Not sure though.

Agree. This file descriptor thing to me sounds like an issue that could have a code solution to me. Not sure though.

@jorgeorpinel yes, it is solvable, and this change is taking some time because we were discussing it a lot with @efiop and @Suor. Some of the conclusions can be found at
iterative/dvc#2866 and
iterative/dvc#2473
The conclusion was that we want to preserve quite high default value of jobs, and don't want to introduce complicated logic to adjust (only default) jobs value on a single remote (s3). In the future we will probably fix it by retrying after this fail, but that will probably need reorganizing error handling, so it will be bigger than try: except OsError
iterative/dvc#2965

@jorgeorpinel @shcheklein I created Troubleshooting User guide section and included @jorgeorpinel suggestion.

yes, it is solvable...

Thanks for all the context @pared! So, my point was that this may not be a "trouble" the way @shcheklein described it, but in fact a "known issue". I think you're confirming this?

@jorgeorpinel @pared if agree on it to be a "known issue" then we don't need this doc - let's open ticket in the Github DVC repo with a description, workaround, ETA on solving, etc. I don't think we need document this things. To me the current solution is a first iteration, but a solution - thus I was thinking this documentation makes sense and should be part of the troubleshooting.

if agree on it to be a "known issue" then we don't need this doc... I don't think we need extra documentation besides GitHub issue tracker for "known issues" and "known problems" (in a sense that they are actual design bugs, bugs and/or are going to be fixed)

To be or not to be! (A known issue) That is the question. I like the "regular workflow, you just hit bumps" argument but not sure it's accurate. I have to yield to you guys in the end to decide what this thing is. But I think Ivan is right that a fully described issue on GH would be enough for "known issues".

regular workflow, you just hit bumps

k, to be more precise :) regular workflow, advanced scenario. It can be considered somewhat similar to that "slow linking" message we have.

@jorgeorpinel, @shcheklein I guess its Known issue though I don't think we want to include solution in log, it's just too extensive. Let's just create an issue aiming to solve the problem once and for all?

@pared let's then create an issue that describes this and the workaround and link that issue instead of docs. I'm closing this for now then, will reopen if we reconsider this.

Not sure why we've closed this. The article talks about ulimit, which might bite the user in multiple ways (this is not only about fds, you might hit proc ulimit too). I think it should be documented in the dvc.org, we won't be able to resolve it in-dvc for every case.

I think we do want a Troubleshooting doc but this wasn't the best thing to initiate it (referring to [Errno 24] Too many open files). Feel free to reuse some of the changes in this PR to talk about the matters Ruslan mentioned, guys! Ivan also mentioned he can probably add some items to the doc once it exists.

@shcheklein I think we didn't understand each other - what I mean was to create an issue for automatically solving the problem if it occurs. I don't think that hanging, open issue describing the problem is a good idea. I saw somewhere your comment about creating Errors section in docs, maybe that should be the way?
Also, before closing this, I would like to achieve some kind of agreement about what do we decide to do.

sure, reopening it! Let's keep the discussion going. @efiop @pared before we do a change on the docs side we need a clear vision from the DVC project - is this considered a regular advanced workflow and/or is it a temporary solution (issue) that will be resolved. It's important since you can see otherwise we can't come with a right place to put it.

@pared Errors section in docs is similar to the troubleshooting in mind - this is section that describes public facing errors that are not bugs, or issue but are part of the regular workflow.

@shcheklein ulimit issues are universal, we won't fully get rid of them ever. E.g. our tests are adjusting proc and fd ulimits for that reason. I think the article proposed by @pared is useful and we should keep it in the docs. "Troubleshooting" is a useful section to have in the docs.

@efiop I'm not against it. (I think it was me who suggested the "troubleshooting" section in the first place.) My concern was that we were using confusing terminology for the section (e.g. "known issue"). Troubleshooting in my mind is about, let's say "advanced regular workflow" - this is something that will stay with us. We don't have a ticket for GH to fix this. Etc. If we are all on the same page with this, @pared please address some wording concerns we had, let's review it again and merge.

@shcheklein addressed the reviews, please check

@shcheklein I would leave this Errno 24. When this error is thrown, Too many open files and this error code are quite specific messages that can be easily found on troubleshooting guide, once it starts growing in size. Also, user will see this error, because we do not hide it behind some dvc-specific error.

Related: https://github.com/iterative/dvc/pull/3017

Letting Ivan merge this one as he still has a Q in https://github.com/iterative/dvc.org/pull/875#discussion_r362073177

@pared please, check my comment here https://github.com/iterative/dvc.org/pull/875/files#r362920851

Ok, lets sum up, and continue discussion here, instead of overloading one comment thread with information.
@shcheklein @jorgeorpinel @efiop :

we set up error.dvc.org
we assign custom error codes for problems described in troubleshooting guide
we set up errors logging in that way that they do point to newly created links.
Do I get it right?

Also, I have a big question: what is the advantage of assigning custom error codes to our troubleshooting use cases? That redirection part will be always on side of dvc.org, and we will not have to update dvc if the link for particular guide changes? In that case, we can just assign a custom redirection, like errors.dvc.org/too-many-open-files -> https://dvc.org/doc/user-guide/troubleshooting#too-many-open-files. In that case, we do not have to create an artificial concept of error code.

we can just assign a custom redirection, like errors.dvc.org/too-many-open-files -> https://dvc.org/doc/user-guide/troubleshooting#too-many-open-files

Here's a summary on that discussion from https://github.com/iterative/dvc.org/pull/875#discussion_r363310065 +:

I: how do we determine the suffix/"error codes"?
R: error codes are future-proof and easy to manage, but sometimes look uglier than text-based.Thinking about it, codes do seem pretty nice overall.
P: Ok, so we do agree to set up the codes right?
I: yep, you just agree with the team on the names ... just to come up with a nice and simple and stable URL

So Ruslan prefers numeric codes, while Pawel and Ivan seem neutral.
I recommend text though, but it should be very short, think of tiny URLS. In this case maybe error.dvc.org/many-files. It's equally future proof I think, because even if it's renamed in the future (unlikely), a new redirect to the same target can always be setup. The numeric codes have the problem of zero padding and maybe we would need to group them by hundreds or thousands similar to (HTTP statuses).

p.s. will the error link thing be implemented along with https://github.com/iterative/dvc/pull/3017#pullrequestreview-339988084 ?

@jorgeorpinel Yes, I was thinking that it will be a part of that change. But to be able to do it there, we need to have the troubleshooting guide in place altogether with links. I don't think that error codes are more "future-proof" than custom links redirecting to proper subsection and they introduce another "entity" to be managed by us. @efiop @shcheklein what do you think?

@pared I'm totally fine with some human readable suffixes!

@shcheklein ok, so lets set up errors.dvc.org?

Done @pared. See d2293b58 ^

p.s. I went for err.dvc.org/{hdr} -> dvc.org/doc/user-guide/troubleshooting#{hdr} BTW but feel fee to change it as needed.

@shcheklein @jorgeorpinel updated the address in docs, also the dvc PR, now it looks like that:

updated the address in docs...

Thanks @pared there's just this one matter to decide definitely on, I think: https://github.com/iterative/dvc.org/pull/875#pullrequestreview-341328486 please weight in if you can 🙂

And this one about 301 vs 302 response codes actually: https://github.com/iterative/dvc.org/pull/875#pullrequestreview-341328648 ...


[SPARK-27711][CORE] Unset InputFileBlockHolder at the end of tasks

What changes were proposed in this pull request?
Unset InputFileBlockHolder at the end of tasks to stop the file name from leaking over to other tasks in the same thread. This happens in particular in Pyspark because of its complex threading model.
How was this patch tested?
new pyspark test

LGTM

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

Test build #105388 has started for PR 24605 at commit fdbae70.

Test build #105388 has finished for PR 24605 at commit fdbae70.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105388/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10651/
Test PASSed.

Test build #105389 has started for PR 24605 at commit 7e1eafe.

Test build #105389 has finished for PR 24605 at commit 7e1eafe.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105389/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10652/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10653/
Test PASSed.

Test build #105390 has started for PR 24605 at commit bc2a874.

Test build #105390 has finished for PR 24605 at commit bc2a874.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105390/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10654/
Test PASSed.

Test build #105391 has started for PR 24605 at commit e30c6ab.

Test build #105391 has finished for PR 24605 at commit e30c6ab.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105391/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10655/
Test PASSed.

Test build #105392 has started for PR 24605 at commit 7ea89c0.

Test build #105392 has finished for PR 24605 at commit 7ea89c0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105392/
Test PASSed.

Pushed comments. Sorry it took so long, I was on a trip.

Test build #105702 has started for PR 24605 at commit c8c8d7b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10957/
Test PASSed.

Test build #105702 has finished for PR 24605 at commit c8c8d7b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105702/
Test PASSed.

Thanks! Merged to master, please manually backport to 2.4!


Remove MAX_LIMIT

https://github.com/xmunoz/sodapy/blob/0bcb2d16694a140c20feca68009e0e24d8399ca9/sodapy/constants.py#L1
MAX_LIMIT does not apply to SODA 2.1 endpoints

:+1:

Ok, I guess it's a little weird to do this checking preemptively, I'll open a PR.

It's in the newest release.


Simplified CountOccurrences and added edge case DivideTest

Good idea! I integrated it manually because I made some changes to the readme and tests too. Thank you.


Implement core::alloc::borrow::ToOwned

We have multiple instances of clone().into() which are of one specific type being boxed. This fits neatly into how core::alloc::borrow::ToOwned is meant to work!

Turns out this does not work because it conflicts with clone.


Django Example  Via Heroku Training not working.

I've followed the migration and train commands and have my django site running on Heroku but every message I give it results in "hello".
Here is my site live.
https://polar-basin-92507.herokuapp.com/
Here is my current source.
https://github.com/nonlin/SEBot
What am I missing to get this to train?

I checked it is working as expected. Could you please let me how you are Inputted your inputs

@vkosuri I try "How are you?",  "Good Morning". And different stuff.
What input did you try and what responses did you get?
I'm not sure exactly what input will work with the default training I'm using.

I found the source to the corpus and asking questions from there seems to work.

@nonlin could you place your solution, It helps others.


Adding protections for invalid flex parameters

Ok, not sure if there are better ways to clamp a value above a certain threshold. Also, is it fine to do the tests like that? I had to do it that way otherwise the test fails in release and passes debug.

I opted to keep add_child within with_child instead of relying on the add_flex_child function checking for flex values that are 0.0 or less.

What's the conclusion here?

In regards to what? Are there any other issues? The only one that came up was the tracing events need a subscriber created before the app is launched but that is a separate issue.
oh oops, I'm going to take out the tracing instrument for the add flex child function. I forgot. Other than that I think everything is fine.


Improve the UI of all pages for mobile view

Open: https://door.casdoor.com/ in mobile phone

Please assign it to me, so I can work on it.

I want do work on this issue sir so please assign me
Thank you


Added Randomized Color Lab (React project)

Title and Issue number

Want to add RandomizedColorLab project to React_JS Project | #867
Close #867

Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md

Screenshots

@pranjay-poddar Kindly review my PR. Thank you.😊

Thank you.💗


fix: markdown parser cause ios crash

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/45623
PROPOSAL: https://github.com/Expensify/App/issues/45623#issuecomment-2247727495
Tests

Log in to New Expensify
Navigate to any chat
Send message with any hyperlink, e.g. [link.com](https://link.com)
Edit the message
Try to add space at the end of link.com text part of hyperlink: [link.com ](https://link.com)

Verify that: No app crash or error log in console. But the space is not added to the hyperlink in the edited message

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Log in to New Expensify
Navigate to any chat
Send message with any hyperlink, e.g. [link.com](https://link.com)
Edit the message
Try to add space at the end of link.com text part of hyperlink: [link.com ](https://link.com)

Verify that: No app crash or error log in console. But the space is not added to the hyperlink in the edited message

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/b0ee8f40-6f10-4335-90c8-ced9e1269889

Android: mWeb Chrome

https://github.com/user-attachments/assets/b9088084-6eac-4917-a86e-468c124628cc

iOS: Native
https://github.com/user-attachments/assets/e58e0c74-d5ca-4bb7-b085-5955d0d0b411

iOS: mWeb Safari

https://github.com/user-attachments/assets/8539eaa9-566f-4a80-80cc-1f08c3079f3b

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/db369c09-25a3-4d55-a98b-cd01fc720c99

MacOS: Desktop

https://github.com/user-attachments/assets/f44a4205-6cc9-4fcb-899f-d946b9b12e51

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@Gonals Do you want to get new internal engineer in this PR?

I do! Alberto is out of office

@muttmuure Please remove him from both PR and linked issue

The engineer in the issue will be assigned to this PR automatically when I make an approval

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.21-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.21-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
failure ❌

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.21-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


DRILL-6703: Query with complex expressions in lateral and unnest fails with CannotPlanException

Initially to handle unnest with complex calls was introduced ProjectComplexRexNodeCorrelateTransposeRule. But this rule only matched LogicalCorrelate -> Uncollect -> LogicalProject pattern. So all other combinations, which have LogicalCorrelate, Uncollect and LogicalProject with rel nodes between LogicalCorrelate and Uncollect weren't handled.
The solution proposed in this PR is to make visitor based on ProjectComplexRexNodeCorrelateTransposeRule and apply it before applying rules, so all possible cases will be handled correctly.
For details please see DRILL-6703.

@HanumathRao could you please review?

Thanks for making the changes. Changes look good to me.

@HanumathRao thanks for the review!


Remove debiasing folder

Still todo; update docs/contributing.md

Question for @RuthBowyer do we want to keep any of these files?:

docs/deprecated_pipeline.qmd
notebooks/Assessing_bc_data/MethodsAssessment_DecWorkshop.Rmd
notebooks/Assessing_bc_data/Bias correction assessment.html

@sgreenbury Please could you have a quick look at the updated contributing.md doc?

@sgreenbury Please could you have a quick look at the updated contributing.md doc?

The updated contributing.md looks good to me, thanks @andrewphilipsmith. I added one suggestion above in the docs in case useful.

Question for @RuthBowyer do we want to keep any of these files?:

docs/deprecated_pipeline.qmd
notebooks/Assessing_bc_data/MethodsAssessment_DecWorkshop.Rmd
notebooks/Assessing_bc_data/Bias correction assessment.html

This was discussed offline. These files have been removed.


Errors on Android

I am getting an error when trying to refresh or with "Fast Refresh" enabled:
Error  while updating the property 'adUnitId' of a View managed by AppLovinMaxAdView null The specified child already has a parent. You must call removeView() on the child's parent first.
I am getting this error when I enable debug mode

 Consider providing alternative methods to expose this method in debug mode, e.g. by exposing constants ahead-of-time.`

Should be resolved in v1.1.4: https://github.com/AppLovin/AppLovin-MAX-React-Native/commit/2c4c06f35dd7631cda813aa2996eba898f4a5105

@thomasmso The issue when using debug mode has not been resolved.

This crash should not be happening anymore - so your project might be in a stale state. The code in the latest fix makes it impossible for the error to occur again - but feel free to send me the latest stack trace in case it's something different.

@thomasmso The errors that I mentioned are 2 different ones. The first one is indeed resolved.
I am still getting the error when using debug mode.
Invariant Violation: Calling synchronous methods on native modules is not supported in Chrome.

 Consider providing alternative methods to expose this method in debug mode, e.g. by exposing constants ahead-of-time.

With a fast search that I did it might be related this if you are using react-native-device-info

I can confirm that this is the issue.
I am using a native ui component and style it according to the instructions. After removing the .isTablet the error dissappears.

Where did you exactly remove isTablet?

I am using a native UI banner and I am trying to style it according to the instructions.
I have now removed the height: AppLovinMAX.isTablet() ? 90 : 50, part and the error dissapears.


[milvus] Fix key of config for zookeeper's PDB

What this PR does / why we need it:
The config name whether creating PDB for zookeeper of not is incorrect.
https://github.com/bitnami/charts/blob/51dac1ef2e068e1f357fdfa0c8e7e4142dd2d4e7/bitnami/zookeeper/templates/pdb.yaml#L7
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Title of the PR starts with chart name (e.g. [mychartname])
[x] PR only contains changes for one chart

@mrkm4ntr milvus-helm chart relies on the apache-pulsar helm chart which includes its own zk templates like this: https://github.com/apache/pulsar-helm-chart/blob/a919f309c6d73342196dbaf6bf146cfda8d9e8e8/charts/pulsar/values.yaml#L403.
And check more from: https://github.com/apache/pulsar-helm-chart/blob/pulsar-2.7.8/charts/pulsar/templates/zookeeper-pdb.yaml
We don't need to change this config.

Ah, yes. pdb.create is for Kafka's zookeeper. I mixed up them. Thanks.


apis: update Device CRD fields

Signed-off-by: Jason Liu<EMAIL_ADDRESS>Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist

[ ] I have written necessary docs and comments
[ ] I have added necessary unit tests and integration tests
[ ] All checks passed in make test

/hold

/cc @buptcozy @eahydra

/unhold

/approve


Copy on reduction op edge cases

My understanding is that the convention for reduction ops is to always return a new array.
This doesn't happen for the following edge cases, however:
        INDArray row = Nd4j.linspace(1,3,3);
        INDArray mean0 = row.mean(0);
        System.out.println(mean0 == row);       //True: same object (should be a copy)

        INDArray col = Nd4j.linspace(1,3,3).transpose();
        INDArray mean1 = col.mean(1);
        System.out.println(mean1 == col);       //True: same object (should be a copy)

This can be problematic... for example, X.mean(0).addi(Y) can be perfectly fine for most cases (i.e., X is unmodified), but then cause a hard to identify/debug edge cases for row vectors (where X is modified)

Fixed in my branch, will be merged a bit later today.


Another phase of masking,   Work done with @raychil

providing functions to do 2d/1d comparision with values inside of 3d/4d array after masking reduction.
This doesn't replace Hiro's masking function, just provides functions to do the dimensional conversion before and after the analysis is attempted.
@reychil

This looks helpful! Thanks for working on this, guys.


Feature request: Payment deviations

It would be nice to supply a list of extra payments and see how this affects the loan.

Tracks in AB#3


⚠ Bofrost.be has degraded performance

In 12314f9, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2478 ms

Resolved: Bofrost.be performance has improved in 627e549.


Expandable rows rendering incorrectly and column resizing lines overlap row data

When attempting to create a mui-datatable with a nested  mui-datatable I noticed that the component renders but is misaligned with the parent row data. In addition, when the expandable row is displayed, it gets overlapped by vertical lines used for the column resizing.
Expected Behavior

The expandable row component should render below the parent row. And the column resize lines should not overlap with the expanded row view.
Current Behavior

Column resize lines overlap the expanded row display in addition, the lines slide over to other columns. The underlying rendering within the expandable row ui component is not aligned under the datatable row, they get pushed out horizontally.
Steps to Reproduce (for bugs)

For the expandable row display offset, I created a mui-datatable and in the renderExpandableRow option defined:
const options = {
filter: true,
filterType: "dropdown",
resizableColumns: true,
responsive: "standard",
download: true,
print: false,
draggableColumns: {enabled: true, transitionTime: 1},
selectableRows: false,
rowsPerPageOptions: [5,10,25],
expandableRows: true,
renderExpandableRow: (rowData, rowMeta) => {
console.log(rowData, rowMeta)
const colSpan = rowData.length + 1;
return (

)
},
expandableRowsHeader: false
};

If you click the vertical column resizing bars and drag them, they easily overshoot across to other columns and overlap the other rows in the table.
If you click a dropdown arrow, there underlying table gets shifted from the parent table row.
Sandbox emulating the issues above: https://codesandbox.io/s/mui-datatables-expandable-rows-forked-kmn68?file=/src/ExpandableRowTable.js
Your Environment

Tech
Version

Material-UI
4.11.3

MUI-datatables
3.7.6

React
16.14.0

browser
chrome

etc

Fit the parent columns (rowData.length).
sample : https://github.com/gregnb/mui-datatables/blob/master/examples/expandable-rows/index.js
    renderExpandableRow: (rowData, rowMeta) => {
      const colSpan = rowData.length + 1;
      return (
        <TableRow>
          <TableCell colSpan={colSpan}>
            <MUIDataTable
              title={"ACME Employee list"}
              data={data}
              columns={columns}
              options={options}
            />
          </TableCell>
        </TableRow>
      );
    }

@wdh2100 Thank you so much for following up. I see that I needed a another component to wrap the child table and set the style length based on the parent row.
As a follow up question, is there a suggested strategy for passing data to the expandable row? I see that parent row data is baked in but I am uncertain of my options on how I should leverage the table load subsequent child data.
For instance,  would embedding an api call which is triggered by the row expand action be an appropriate strategy or is that better handled by a rowClick action used with a custom render?

Could you give us example, my child row is not aligning with the parent row currently


Make Documenter annotation actions moldable

It would be nice if the action performed when clicking on an annotation were modifiable in some way. Example: class annotations used to spawn an inspector, now it's a GtClassCoder. It would be nice to leave that choice to the author of the document, e.g. via an additional parameter, like for the preview.

Hi @khinsen: For now it behaves as before, spawning classes and method definitions.


Left navigation menu order

is there a way to order the left menu?
Version
The latest v2.0.0-rc.70
Description
I tried with
---
name: Changelog
route: /changelog
order: 10000
---

but it seems not working

Hey @gfazioli
Thanks for reporting this issue.
Unfortunately, order property support was removed in version 1 but I think we should support it again as it can be very useful.
To do that we'll probably need to do some changes to core/docz/src/hooks/useMenus.ts
Let's use this issue to track progress on it.
Meanwhile, you could shadow the Sidebar component (https://github.com/doczjs/docz/blob/master/core/gatsby-theme-docz/src/components/Sidebar/index.js) and add your own sorting to the menus from useMenus before rendering them.


Doesn't work on Android

Hi guys, it doesn't work on android but works perfect on iOS, here the code, anything wrong?
import React, { Component } from 'react';
import {
  StyleSheet,
  TextInput,
} from 'react-native';
import InputScrollView from 'react-native-input-scroll-view'; // 1.5.1

export default class App extends Component {
  render() {
    return (
      <InputScrollView>
        {Array(20)
          .fill()
          .map((_, i) => (
            <TextInput
              key={i}
              underlineColorAndroid="transparent"
              style={styles.text}
              placeholder={`Text ${i + 1}`}
            />
          ))}
      </InputScrollView>
    );
  }
}

const styles = StyleSheet.create({
  text: {
    height: 40,
    borderColor: 'gray',
    borderWidth: 1,
    marginBottom: 16,
    // paddingVertical: 4,
    paddingHorizontal: 8,
  },
});

Here the capture in both:

Yes, you are right, android devices are not fully supported, this is my next task.

Looks like something KeyboardAvoidingView could solve
https://facebook.github.io/react-native/docs/keyboardavoidingview.html

@outaTiME Try v1.6.0

Great @baijunjie I will check tonight ... thanks !!!

Hi again guy, im doing a new test today using Expo v33 and still no luck, here the example:
https://snack.expo.io/@outatime/form-into-scrollview
(try to click on multiline text field and keyboard overlaps textarea), any advice, thanks !!!


Users SBAT use invite code from partial invite text

Expected Behavior
Some phones cut off texts at 160 (?) characters which leads to an invite text that does not contain the full message, but does contain the full invite code (see image below). Users SBAT copy this partial message into the redeem invite screen.
Current Behavior
Invitation texts that are cut off fail. Users must select the code from within the message to redeem it. Usually users can paste the full text in and the app identifies the invite code, but this does not work with partial texts.
Example of partial text:

Seems to work for me, after copying up to "...You can install the C". As long as the full invite code is contained in the message you copied, it should work.  Are you still able to reproduce this?


⚠ Mobitopup has degraded performance

In ee4f0f9, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 5682 ms

Resolved: Mobitopup performance has improved in d59804a.


Scrolling to the end of recent topics is bugged

With Firefox: (Notice how the last entry is cut off and the scroll bar goes further down than it should)

With Chromium (Notice how the knob of the scroll bar goes further down than it should)

@zulipbot label "bug"

@zulipbot add "bug"


[SPARK-38335][SQL] Implement parser support for DEFAULT column values

What changes were proposed in this pull request?

Implement parser changes needed to support for DEFAULT column values as tracked in https://issues.apache.org/jira/browse/SPARK-38334.
Note that these are the parser changes only. Analysis support will take place in a following PR.
Background: in the future, CREATE TABLE and ALTER TABLE invocations will support setting column default values for later operations. Following INSERT, UPDATE, MERGE statements may then reference the value using the DEFAULT keyword as needed.
Examples:
CREATE TABLE T(a INT, b INT NOT NULL);

-- The default default is NULL
INSERT INTO T VALUES (DEFAULT, 0);
INSERT INTO T(b)  VALUES (1);
SELECT * FROM T;
(NULL, 0)
(NULL, 1)

-- Adding a default to a table with rows, sets the values for the
-- existing rows (exist default) and new rows (current default).
ALTER TABLE T ADD COLUMN c INT DEFAULT 5;
INSERT INTO T VALUES (1, 2, DEFAULT);
SELECT * FROM T;
(NULL, 0, 5)
(NULL, 1, 5)
(1, 2, 5)

Why are the changes needed?

This new API helps users run DDL and DML statements to add new values to tables and scan existing values from tables more easily.
Does this PR introduce any user-facing change?

No
How was this patch tested?

Added unit test coverage in DDLParserSuite.scala

Can one of the admins verify this patch?

jenkins merge

Before merging this PR, I would like to collect the opinions of more committers.
Supporting default column values is very common among DBMS. However, this will be a breaking change for Spark SQL
Currently Spark SQL
> create table t(i int, j int);
> insert into t values(1);
Error in query: `default`.`t` requires that the data to be inserted have the same number of columns as the target table: target table has 2 column(s) but the inserted data has 1 column(s), including 0 partition column(s) having constant value(s).

After supporting default column value:
> create table t(i int, j int);
> insert into t values(1);
> select * from t;
1	NULL

cc @cloud-fan  @dongjoon-hyun @viirya @dbtsai @huaxingao @maropu @zsxwing @wangyum @yaooqinn WDYT?

cc @aokolnychyi , @RussellSpitzer , @rdblue , too.

As this is a breaking change, I'd like to see some clarification on why this is necessary to have.

@viirya Column default support is very helpful for table schema evolution and DML operations on wide tables with sparse data.

Adding the default support itself should be fine - it's pretty common up to my best knowledge. My only concern is the breaking behavior (https://github.com/apache/spark/pull/35690#issuecomment-1057620996). I am fine w/ this as long as this matches w/ most of DBMSes. I suspect it's less critical since it failed before but now works.

Creating NULL default value for NOT NULL column
Type mismatch between default value literal and column type.
Upcasting or not in case of type mismatch

IMO:

Not Null column can't have Null default
Type mismatch between default value literal and column type:  we can simply forbid this. Note that we have many numeric types(Byte/Short/Int/Long/Decimal/Float/Double). If both default value literal type and column type are Numeric, it is not considered a mismatch.
Upcasting or not in case of type mismatch: casting can happen if both of the literal type and column type are Numeric

@dtenedor WDYT?

what is your release target for this

@dongjoon-hyun This is for Spark 3.4

Thank you for the confirmation.

Adding the default support itself should be fine - it's pretty common up to my best knowledge. My only concern is the breaking behavior (#35690 (comment)). I am fine w/ this as long as this matches w/ most of DBMSes. I suspect it's less critical since it failed before but now works.

I agreed with you. @HyukjinKwon
And thanks for clarification, @gengliangwang

Thanks for the work.
For the parser change itself, looks okay. As this is a breaking change, I'd like to see some clarification on why this is necessary to have. What issue we have if we don't have this (because we don't have the default value for long time) and do we have any workaround now?

This is for supporting the ANSI SQL syntax to specify default column values in DDL commands and then referencing them later in INSERT/UPDATE/MERGE commands. Examples:
CREATE TABLE T(a INT, b INT NOT NULL);
-- The default default is NULL
INSERT INTO T VALUES (DEFAULT, 0);
INSERT INTO T(b)  VALUES (1);
SELECT * FROM T;
(NULL, 0)
(NULL, 1)
-- Adding a default to a table with rows, sets the values for the
-- existing rows (exist default) and new rows (current default).
ALTER TABLE T ADD COLUMN c INT DEFAULT 5;
INSERT INTO T VALUES (1, 2, DEFAULT);
SELECT * FROM T;
(NULL, 0, 5)
(NULL, 1, 5)
(1, 2, 5)

This PR doesn't seem to have the full body yet, what is your release target for this, @dtenedor and @gengliangwang ? I'm curious about the general error handling.

Creating NULL default value for NOT NULL column
Type mismatch between default value literal and column type.
Upcasting or not in case of type mismatch

These are good questions.

The future plan for NOT NULL columns is to require a DEFAULT value. If no DEFAULT value is provided, the engine will throw an error. We can also return an error in the case of a provided DEFAULT NULL value for a NOT NULL column.
The engine can perform an explicit type coercion from the provided type to the required type, e.g. integer to floating-point. If these types are not coercible in this way, the engine can return an error, e.g. floating-point to boolean.

Creating NULL default value for NOT NULL column
Type mismatch between default value literal and column type.
Upcasting or not in case of type mismatch

IMO:

Not Null column can't have Null default
Type mismatch between default value literal and column type:  we can simply forbid this. Note that we have many numeric types(Byte/Short/Int/Long/Decimal/Float/Double). If both default value literal type and column type are Numeric, it is not considered a mismatch.
Upcasting or not in case of type mismatch: casting can happen if both of the literal type and column type are Numeric

@dtenedor WDYT?

Good questions, I replied above earlier. We can perform a type coercion from the provided type to the required type, or return an error if the types are not coercible in this way. We can use existing type coercion rules in the analyzer for this part for consistency with the rest of Spark. For example, coercing an integer to floating-point should work, but coercing a floating-point to boolean should return an error to the user.

This is ready for another review round @gengliangwang @viirya @wangyum @HyukjinKwon @dongjoon-hyun :)

(Note the prior merge conflict in the lexer has now been resolved.)

This is a parser-only change and the feature is not implemented yet, so definitely not a breaking change. But I'd like to confirm that, is every new SQL feature a breaking change? e.g. adding a new SQL function means that a query failed with "function not found" before, now succeeds. This doesn't seem like a breaking change to me. The same applies to accepting more parameters in a SQL function, accepting more parameter types, etc.
The code change itself LGTM.

@dtenedor Thanks for the first contribution!
@HyukjinKwon @dongjoon-hyun @viirya  @wangyum @cloud-fan thanks for the inputs! I am merging this parser-only PR to unblock @dtenedor's works in this feature.

@gengliangwang and @cloud-fan . Why do we have Spark 3.4 patch in master branch for Apache Spark 3.3?

@dongjoon-hyun This is for Spark 3.4

Are we going to revert this from branch-3.3? cc @MaxGekk

As I mentioned https://github.com/apache/spark/pull/35690#pullrequestreview-899459801, I assumed we are going to wait until @MaxGekk cut a branch-3.3.

@dongjoon-hyun I am merging this one to unblock @dtenedor's work on the actual changes in catalogs.
I will:

revert this one on branch-3.3
make sure no new related PRs merged to master until branch-3.3 is cut

Are we going to revert this from branch-3.3? cc @MaxGekk

If there is a risk that it can hurt stability. Let's revert it. I will open a blocker for 3.3 than to not forget this.

Thank you for your confirmations, @gengliangwang and @MaxGekk !

Hey, @MaxGekk . Did you make a block issue?
To @gengliangwang and @HyukjinKwon , I saw the JIRA was resolved as 3.3 because we want to avoid our merge script shows 3.4 as a new version.

Since today is the feature freeze day, I recover it to 3.4.

👍

Hey, @MaxGekk . Did you make a block issue?

Here is the blocker SPARK-38566


 We, however, need to have paths with only head operations in our project although it might be a rather uncommon use case.
The problem seems to be in the openapi-format.js in line 158 where head is not included in the list of httpVerbs.

hi @miriamgreis
You are correct. OpenAPI 3.0 supports get, post, put, patch, delete, head, options, and trace.
I'll extend the httpVerbs options with HEAD and alsoOPTIONS, TRACE.
Thanks for bringing it my attention.

FYI: The PR is ready and will probably land today.

@miriamgreis
I assume you want to do the "inverseMethods"?

No, I just wanted to filter for some flags and suddenly some operations were completely gone. But I tried with these filters then as well and also realised that even they don't work as I would expect it.

hmm 🤔
Can you share your filter config?
I extended the httpVerbs list in the PR, but wanted to double check that it solves your mentioned case.

hmm 🤔 Can you share your filter config?
I extended the httpVerbs list in the PR, but want to double check that it solves your mentioned case.

It was really just as easy as this:
flags:
  - x-exclude

I think the problem is line 625ff. Because based on the httpVerbs, it deletes all paths that don't have any verb from the list.

I extended a test with flags and the PR fixes your issue.

hi @miriamgreis
I just release openapi-format to version 1.22.4, you can test on the playground if the latest version fixes your problem with the "head".
Portman and openapi-format have different release cycles, so best is to bump openapi-format in your package.json to use the latest version.


add a flag like --ignore-path similar to Prettier

this is (right now) an idea specific to the cli.
# in a c/wasm project
glob -c"clang-format -i" "**/*.c" --ignore-path=.gitignore

👆 something like this to avoid clang-format-ing all the build/_deps/some-lib/src/thing.c from CMake deps would be very nice. 👈 that's just my use-case but i can imagine some others:

run some js analyzer that takes file arguments (not globs) on all non-dist js files
run glob -c"node --test" "**/*.test.js" without globbing dist
probably other tools i dont know about

right now I'm using this wrapper glob.js script

#!/usr/bin/env node
import { readFile } from "node:fs/promises";
import { spawn } from "node:child_process";

function ignoreToGlob(ignoreText) {
  return ignoreText
    .split(/\r?\n/g)
    .map((x) => x.trim())
    .filter((x) => x && !x.startsWith("#"))
    .map((x) => {
      if (x.startsWith("!")) {
        if (x.startsWith("!/")) {
          return x;
        } else {
          return `!**/${x.slice(1)}`;
        }
      } else {
        if (x.startsWith("/")) {
          return x;
        } else {
          return `**/${x}`;
        }
      }
    })
    .flatMap((x) => {
      if (x.endsWith("/")) {
        return `${x}**`;
      } else {
        return [x, `${x}/**`];
      }
    });
}

const index = process.argv.indexOf("--ignore-file");
if (index !== -1) {
  const [, ignorePath] = process.argv.splice(index, 2);
  const ignoreText = await readFile(ignorePath, "utf8");
  const ignoreGlobs = ignoreToGlob(ignoreText);
  const extraArgv = ignoreGlobs.flatMap((x) => ["-i", x]);
  process.argv.push(...extraArgv);
}

const child = spawn("npx", ["glob", ...process.argv.slice(2)], {
  stdio: "inherit",
});
child.on("exit", process.exit);

it would be nice if this feature were available included with the cli, but i understand if its out of scope.  this just a friendly feature request 😊

I can see how it'd be useful. Unfortunately, just having a cli script at all is pretty controversial, and past experience with npm has taught me that properly handling .gitignore "just like git does" is much less straightforward than one might expect. Your wrapper works fine for your use case, but once something like that is there, people start to expect it to properly handle absolute paths (which are mounted on the folder of the .gitignore file, not on the root of the fs as they are in this script), nested .gitignore files it finds, negated ignores within ignored folders (which aren't actually supported by glob ignores currently), and so on.
So I think yes, it is out of scope.


container.c: fix warnings of "format-overflow=" with new GCC

Change sprintf to snprintf and check the return values of snprintf
to handle this warning.
Fixes: #364
Signed-off-by: Hui Zhu<EMAIL_ADDRESS>

test this please, hykins


Torque vector in wrong direction

I believe we have a sign error in the torque vector. This makes the magnets rotate in the wrong direction.

Maybe the cross product mu x B is calculated in the wrong order somewhere in the code.

fixed in #6


Binaries for Testing

openpnp-capture-test.zip

OpenPnP_capture_win_17_7_2017.zip

openpnp-capture-win-17-7-2017-releasebuild.zip

Works with both of my webcams. One with exposure control, one without. Built on win64 using cmake to generate a vs2015 project file.

openpnp-capture-win-25-7-2017-releasebuild.zip
You might need to install the Visual Studio 2013 redistributable package for it to run.

openpnp-capture-win-1-8-2017-releasebuild.zip
Fixes:

Reports library version.
Can now open raw RGB streams (Logitech C270).
Supports zoom functionality.

You might need to install the Visual Studio 2013 redistributable package for it to run.
Please send feedback, screenshots, PPM captures, and/or text output dumps to: sofascener (email at sign here) gmail.com

I ran this with Visual Studio 2015 redistributable package installed.
The capture test program works with my 8MP chinese USB cam, but it has problems with the highest resolutions in MJPEG. Basically it lists all the IDs of the modes, but choosing anything above 2048 x 1536 just ends the program (see attachment - last part). For 2048 x 1536 it gives a slightly higher frame rate than what is given as supported (see attachment - first part). Not complaining about that one! ;-P
openpnp-test.txt

Thanks @kakemoms for running the test program and the report.
The higher resolution mode fail with a '[ERR ] Error calling RenderStream (HRESULT=80004005)' which means 'Unknown error'. RenderStream is a windows internal function that takes care of the MJPEG decoding etc. I don't own a 8MP camera so it will be very difficult to find the cause of the problem.
I will file an issue/bug report.
Regards,
Niels.

Ok. As noted I did install the Visual Studio 2015 redistributable package instead of the 2013 version. I will try to change to the 2013 version (if possible) and run things again. I may also try to install the 2017 version to see wether the error persists under that.

@kakemoms you will need to recompile the program to get it to work with different runtime versions.

(Y)
2017-08-28 14:35 GMT+02:00 Paul Jones<EMAIL_ADDRESS>
@kakemoms https://github.com/kakemoms you will need to recompile the
program to get it to work with different runtime versions.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openpnp/openpnp-capture/issues/3#issuecomment-325341267,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC8fnIisImBpmKb80PbKC1n9mrzsyHd1ks5scrQGgaJpZM4OaVhw
.

Long story short, the above attachment is hardcoded to use MSVCP120.dll and MSVCR120.dll
Here is one I made using VS2017, which uses the 2017 version of the runtime.
Debug.zip


Clean Up Lobby Code

Summary
There is some code in related to lobby creation that is inconsistent with our guidelines and should be cleaned up:

Inconsistent function name syntax in PlayerList.cs (Ex. readyPress isn't PascalCase)
Unused commented out code blocks (Ex. HandlePlayersStateChanged in PlayerList.cs )
Dead code (Ex. The scene names in HostManager.cs don't match up with any existing scenes, and there is unused code related to a character select screen)

Completed in commit id:2d4451ce5ea096218b7c47485705da0dfdaa196f


Js compile

Javascript compiles, need to check in paging as well.

Coverage increased (+3.9%) to 95.89% when pulling bcdb326d68d1089fca32b1be498087e985996efb on js-compile into 2e3afcdcedfd3d31013a9b8877375d08733098f3 on master.


Need way to invalidate comment count stored in yap when posting a new comment

There needs to be a way to invalidate a comment count or force a refresh once a new comment is posted from the device.

Comments don't appear immediately because they need to be approved so maybe it's fine to leave it as is


feat: update tensorflow to 2.5.3

closes: #13
Signed-off-by: Felix Moessbauer<EMAIL_ADDRESS>

@chombourger : Please note: I did only run simple tests on amd64 to see if the build is correct. Before merging, this has to be extensively tested.

@chombourger : Please note: I did only run simple tests on amd64 to see if the build is correct. Before merging, this has to be extensively tested.

agreed. I can have our QA team run their tests and provide feedback

Works fine with meta-iot2050.

@chombourger Any news on the QA? Shall we merge this?

For the sake of IOT2050, I would welcome to move forward with this.

Same here. Our team hasn't completed their testing but we haven't seen any red herrings either

Thanks for the update. Then let's merge this, so meta-iot2050 can move forward.


Add coveralls.io

Changes Unknown when pulling 6f0003a5d945870d451235cd2f99d9c7c0e047ed on develop into ** on master**.

Changes Unknown when pulling 9958297fe14a43fd80d7c82dd374499ab511427c on develop into ** on master**.


@:target directive (or similar) for templates

Following from https://github.com/planet42/Laika/pull/250#issuecomment-1026953323. Thanks! :)

Design note: The @:target directive should support external and internal targets. For internal targets, it needs to work exactly as the @:path directive, meaning it interprets relative paths as relative to the template and translates them to a path relative to the document it is applied to.


Permission issues with latest version

Describe the bug
Latest version of the ext-ci container can no longer be used as container resource in Azure pipelines.
It looks like azure agent expects to be able to create groups and users
To Reproduce
Steps to reproduce the behavior:

create a container job (job.job.container) with ext-ci latest as container image
pipeline will fail during container setup

log shows
/usr/bin/docker exec  d8a918305a996cf5c8cf819fb836050128bfea195eb943e1e82f8bcec79d01a5 bash -c "getent passwd 1001 | cut -d: -f1 "
/usr/bin/docker exec  d8a918305a996cf5c8cf819fb836050128bfea195eb943e1e82f8bcec79d01a5 bash -c "if [[ -e '/etc/alpine-release' ]]; then echo 'Alpine-based image detected.'; fi"
/usr/bin/docker exec  d8a918305a996cf5c8cf819fb836050128bfea195eb943e1e82f8bcec79d01a5 groupadd -g 127 docker_azpcontainer
/usr/bin/docker exec  d8a918305a996cf5c8cf819fb836050128bfea195eb943e1e82f8bcec79d01a5 useradd -m -u 1001 vsts_azpcontainer
##[error]Docker-exec executed: `useradd -m -u 1001 vsts_azpcontainer`; container id: `d8a918305a996cf5c8cf819fb836050128bfea195eb943e1e82f8bcec79d01a5`; exit code: `1`; command output: `useradd: Permission denied.`, `useradd: cannot lock /etc/passwd; try again later.`

Expected behavior
azure agent sets up its users and continues running like it did with previous iterations
workaround is to set options: --user root
This might be related to #172

Describe the bug Latest version of the ext-ci container can no longer be used as container resource in Azure pipelines.
It looks like azure agent expects to be able to create groups and users
To Reproduce Steps to reproduce the behavior:

create a container job (job.job.container) with ext-ci latest as container image
pipeline will fail during container setup

log shows
/usr/bin/docker exec  d8a918305a996cf5c8cf819fb836050128bfea195eb943e1e82f8bcec79d01a5 bash -c "getent passwd 1001 | cut -d: -f1 "
/usr/bin/docker exec  d8a918305a996cf5c8cf819fb836050128bfea195eb943e1e82f8bcec79d01a5 bash -c "if [[ -e '/etc/alpine-release' ]]; then echo 'Alpine-based image detected.'; fi"
/usr/bin/docker exec  d8a918305a996cf5c8cf819fb836050128bfea195eb943e1e82f8bcec79d01a5 groupadd -g 127 docker_azpcontainer
/usr/bin/docker exec  d8a918305a996cf5c8cf819fb836050128bfea195eb943e1e82f8bcec79d01a5 useradd -m -u 1001 vsts_azpcontainer
##[error]Docker-exec executed: `useradd -m -u 1001 vsts_azpcontainer`; container id: `d8a918305a996cf5c8cf819fb836050128bfea195eb943e1e82f8bcec79d01a5`; exit code: `1`; command output: `useradd: Permission denied.`, `useradd: cannot lock /etc/passwd; try again later.`

Expected behavior azure agent sets up its users and continues running like it did with previous iterations
workaround is to set options: --user root
This might be related to #172

Please try to specify the root as user into your pipeline!

dockerhub shows another sha
https://hub.docker.com/layers/floryn90/hugo/0.138.0-ext-alpine-onbuild/images/sha256-3d0d22acb1c2d85da1da344de9b6418f2994444b4f87cdde092c9dffacfad8db?context=explore
can you release a 0.138.1 patch version perhaps 🙏

workaround is to set options: --user root
This might be related to #172

Please try to specify the root as user into your pipeline!

Thanks - just to clear things up - is this going to be the solution going forward?
I'm just asking because we'll have to adjust quite a few pipelines to make them work again after the changes from #172

workaround is to set options: --user root
This might be related to #172

Please try to specify the root as user into your pipeline!

Thanks - just to clear things up - is this going to be the solution going forward?
I'm just asking because we'll have to adjust quite a few pipelines to make them work again after the changes from #172

Hi @horihel,
Yes, for security reasons, there is no more image with default root user but it’s present inside the image. The default user is hugo which has the permissions to write inside /src and /target

thank you for clarifying


IGPU oc patches doesnt work in E580

Model
E580

PatchSet
xx70_xx80_patches_v7.txt

OC igpu
It shows options but i doesnt work. Selected 1400 but it work as 250...

Notes
I think it doesn't work because the first part of oc patch failed but 2nd patch worked

Bios - IC version
1.38 - 1.38

Hi guys i tried to apply the igpu patch with the dumped bios using my ch341a, tried to patch, patches work partially but it doesnt work correctly. i think it works as 250MHz because my fps is too low...
Default Config:

1400Mhz Config:

Could someone help me to apply igpu OC?
Here is default bios:
E580 1.31 Bios
Thank you very much!

Surprising that it works on E580 at all. Try changing frequency via XTU instead of the UEFI setup.

@digmorepaka  I dont think the limitation is due to CPU, because i tried the patch with T580 bios variant (just to test if the problem is related with CPU) because T580 comes with i7-8550U.
But my E580 comes with i7-8550U too!

Output in UefiTool with T580 bios:
Hex pattern "09072C1300000209072D1300000309072E1300000409072F13000005" found as "09072C1300000209072D1300000309072E1300000409072F13000005" in Setup/PE32 image section at header-offset 6B8F2h
Hex pattern "00143100300030004D0068007A000000143100350030004D0068007A000000143200300030004D0068007A000000143200350030004D0068007A" found as "00143100300030004D0068007A000000143100350030004D0068007A000000143200300030004D0068007A000000143200350030004D0068007A" in Setup/PE32 image section at header-offset 53CA8h

Output from UefiTool with E580 bios:
Hex pattern "09072C1300000209072D1300000309072E1300000409072F13000005" could not be found
Hex pattern "00143100300030004D0068007A000000143100350030004D0068007A000000143200300030004D0068007A000000143200350030004D0068007A" found as "00143100300030004D0068007A000000143100350030004D0068007A000000143200300030004D0068007A000000143200350030004D0068007A" in Setup/PE32 image section at header-offset 526AAh

Logs from UefiPatch:
output-T580.log
output-E580.log
Intel XTU doen't install

But i forced the XTU install with https://github.com/gimdh/Intel-XTU-Install-Helper?tab=readme-ov-file to install the software.
I'm going to reboot to check if it works from XTU, altougth i dont think that it'll work because patcher doesnt find 09072C1300000209072D1300000309072E1300000409072F13000005 while with the other model (T580) it does find that hexadecimal pattern.

Installed v6.5 version, because XTU options in >=v7.6 are too limited. and if i install the latest version, doesnt find the drivers.
I had to follow this guide  to install Xtu with:
msiexec /i XTUInstaller.msi DISABLEPLATFORMCHECK=1
But in any case, in any XTU version I can't find how to overclock the igpu.
And I suspect that the first hexadecimal pattern in the E series are different in the bios, which would be the logic that overclocks the igpu.
Here the image of XTU:

Based on your output from UEFITool, it looks that the hex doesn't exist in the E580 bios. It may be under a different hex/pe32 image, or maybe isn't supported on that BIOS. Just speculation though.


Refactor duplicated PasswordWrapper

There is a component PasswordWrapper with exact same code in Login,LoginUpdatePassword and LoginPassword .
I move it to a new file , this should make styling after eject and future change in keycloakify a little bit easier .
@garronej If possible please take a look and merge , thanks🙏

Hello @uchar,
You've done excellent work here, and the implementation is solid. However, I have more ambitious plans regarding this issue.
I’m aware that this component is duplicated. In fact, many elements are duplicated and should be refactored to reduce redundancy.
What I'd like to achieve is the ability for people to provide their own basic components, which can then be used universally. For example, they could supply their own TextField or Select from the libraries they use, like MUI or Shadcn/UI.
This PR focuses on the PasswordField, but I’d prefer a more generic approach that applies broadly to various components.
Additionally, I believe these components should be placed in a directory other than pages/, as this directory is reserved for files that map to .frl page templates, and introducing components here breaks the current convention.
There’s another issue: in the current approach, components only get used in the pages that have already been ejected. I’d prefer a solution where components can be passed as props, similar to how it’s done with UserProfileFormField. Alternatively, using a provider might be an even better option, but I need more time to consider it.
For now, I believe users can handle component refactoring on their own. I aim to ship features that are straightforward and defer making complex, long-term technical decisions until necessary.
I really appreciate the quality of your PR, and I hope closing this doesn’t discourage you from contributing further. Just open an issue when you have an idea so we can discuss it beforehand, I'll be pretty quick to answer.
Thanks again for your work!

@garronej Hi ,
Tbh I consider this as very critical issue , one using keycloakify to completely change the UI , but he ends up doing tons of refactoring and manual changes which will be replaced completely on each update
I understand your reasoning, I also aware about discussion before change  but the thing is in the company my job is to reduce boilerplate codes and tasks that other developers need to do ,
This was sth I had to do , I also made a fork out of your repository and put it on npm with some changes for our usecases , but  just tought it might be useful here so I send this pull request .
It's actually way more than 10 minutes , After each update , we need to copy all files somewhere for reference , eject everything one by one , add story one by one , refactor everything, change all html components to Mui , apply styles again , test , review, fix bugs and a whole week will be pass and also document all sort of tweaks in the code so that if we fix sth we could do it again in future
It's actually almost impossible , only way is just stick to one version and never update it again which is then will compromise the whole idea about using a third party security package , with no update , volunerabilities will be never fixed ,
I actually made a tool for our use https://github.com/RionizSoftware/RionizKeycloakTheme/blob/main/src/codegen/MuiConvertor.ts  that remove all className add sx  and id to all components , replace all of them with Mui component , and optimize extra divs by removing them and make seperate files for styling using Mui https://github.com/RionizSoftware/RionizKeycloakTheme/blob/main/ejectPageFiles/outputs/v2/styles/Template.ts so that they won't lost on each update , plus keep a complete  history of changes https://github.com/RionizSoftware/RionizKeycloakTheme/blob/main/ejectPageFiles/outputs/v2/history/Template.json so that we could understand what was the component before all this changes , still there is a lot of manual stuffs in each update but atleast 70-80 percent of them done automatically.
About your solution actually the UserProfileFormField was the worst part please dont do it , It's just an input field with so many conditions and is very hard to debug and change and understand ,   at the same time it's being used in password , checkbox , text  , Changing it to e.g TextField caused many props to start giving build errors
IMO components need some serious refactoring right now

Hello @uchar,
Just letting you know that Keycloakify now supports custom handlers. You can override the default behavior for commands like eject-page and add-story.
The mechanism works by using a _keycloakify-custom-handler script declared by any module in the workspace. Keycloakify will pass the command name and build context to it via an environment variable.
This could be useful for implementing the changes you submited to be merged in your module. You could customize the eject-page command to eject everything and automatically update KcPage.tsx.
Here’s an example of a module with a custom handler: @keycloakify/angular
You can also check out the entry point: main.ts
Best,


Why is so slow between messages

Hello,
I'm trying to do as much ranges as I can between Tag and Anchor. But I see that time elapsed between: Transmitting Poll and receiving ACK from Anchor is 24ms
Transmitting Range and receiving Range Report is 30ms
These times are configuring devices at 110kb/s.
When configuring at 6800kb/s times are 8ms and 15ms.
I think that should be smaller in UWB.
I need maximung Range, so I have to configure at 100kb/s, but with this, only could make about 10 ranges in one second...
Are these times normal??
Maybe there is a restriction in code but I can't see it?
I'm using Arduino 1.8.2
Capture of 3 consecutives polls:
1524 ms transmitPoll
1548 ms receivedPollAck
1548 ms transmiRange
1578 ms receivedRangeReport
from: 100        Range: 0.59 m   RX power: -68.65 dBm
1626 ms transmitPoll
1650 ms receivedPollAck
1650 ms transmiRange
1680 ms receivedRangeReport
from: 100        Range: 0.65 m   RX power: -67.77 dBm
1728 ms transmitPoll
1752 ms receivedPollAck
1752 ms transmiRange
1782 ms receivedRangeReport
from: 100        Range: 0.58 m   RX power: -68.36 dBm
Thank you.

Hi ,
In my opinion there is 2 reasons for slow communications ;
1- Processing speed of Arduino which we can't change ,
2- Delayed transmissions
Delayed transmissions is set to 3000 us for symmetric ranging also You can look for "DEFAULT_REPLY_DELAY_TIME & replyDelayTimeUS" variables. But it might be optimized for stable working.
In fact with better MCU & if you care regulations ( 1 frame per microsecond ) you can finish your ranging <5ms with 6.8kb/s .

Hi @mikucukyilmaz , thanks for your coments.
But I'm using Teensy 3.2. Processing speed should not be a problem. But maybe I have to change some registers to speed up Teensy with this libraries based on Arduino??
Then, I know about delayed transmisions. I using delayed transmisions between 5000-4000us. But I think that this is a small time compared with 24-30ms used in send 1 Poll and receive Poll ACK.

I just using delayed transmissions for Final message because tag doesn't know about Final_tx timestamp before sending it. In 6.8Mbps 1 Tag 1 Anchor whole communication takes 6 ms. In my previous codes with decawave examples 110K whole communication takes 110ms. But now I'm using stm32 and ported version of this library. As I check all libraries are the same.Printf like functions take so much time you can try after closing in communication debug messages.Stm32 has Single-cycle multiplication and hardware division features. Also floating point math can slow down your mcu if doesnt have features like this. Freescale offers K20's with a floating point unit but it is optional.The Teensy 3.x use the non-floating point version of the chip.
You can try to speed up SPI communication.Also why you need that much delayed transmissions ?

Hi @mikucukyilmaz , When you say 1 Tag and 1 Anchor take 6ms in a whole comunication, you mean since send a Poll --> until receive range report?
I need this delayed time because I'm using this scheme:

Anchors need to respond in diferent timeslots in order to not speak at the same time.
So I'm using 5000us -> 5ms. If I try to reduce this time, it doesn't work. I don't know why.
But this 5ms used in delay, is very small compared to 30 ms that spend in send 1 poll and receive pollack.
I will try to speed up SPI comunications as you say.

Part of the reason is that for every transmitted frame the Decawave sends a preamble. If you operate the Decawave in a mode that transmits a long preamble, that is going to go at the cost of message transmission speed. If your objective is fast message sending then you should operate the Decawave in a mode with a short (e.g. 128 bit) preamble lengths. The message timestamps in the Decawave are the timestamps of when the actual payload starts to transmit, so before that time the preamble has already been transmitted.


RPC endpoint duplicate header - Access-Control-Allow-Origin

Description
After the recent mainnet update, the RPC endpoints have started to respond with duplicate HTTP headers. This creates issues especially for Access-Control-Allow-Origin header since the response is then blocked by browser due to CORS policy. Below is a screenshot from browser's developer tools and from postman.
Expected behaviour
Send Access-Control-Allow-Origin header only once per response
Actual behaviour
Access-Control-Allow-Origin is sent twice

Error message from browser's console

All fixed. Check it out.

@DarianShawn Looks good now, thank you


Wrong $timeFilter expansion

When grafana time selector is set for example to 'Yesterday' (2017-11-18 00:00:00 to 2017-11-18 23:59:59), 'WHERE $timeFilter' is expanded to:
WHERE event_date BETWEEN toDate(1510963200) AND toDate(1511049600) AND event_time BETWEEN toDateTime(1510963200) AND toDateTime(1511049600)
so event_date will be from 18-11-2017 to 19-11-2017 and event_time will be from 18-11-2017 00:00:00 to 19-11-2017 00:00:00 inclusive.
The right part of the time expression should be either exclusive or value of timestamp decreased by 1 second.

Hi @Perlovka
Pls see https://github.com/Vertamedia/clickhouse-grafana/releases/tag/1.2.2

In 1.2.2 some files are missing:
partials/query.editor.html
partials/query.options.html

Can't edit queries ;)
And time selection problem still persist. When time range is set as full period (e.g. now-10m/m - now-10m/m), time selector tooltip shows (2017-11-20 11:35:00 - 2017-11-20 11:35:59) but expanded time query is (2017-11-20 11:35:00 - 2017-11-20 11:36:00) inclusive

Indeed, I forgot to commit copied to src query.editor.html
query.options.html is dropped

And time selection problem still persist
I believe that it's just a bad release and cached files. Pls, try https://github.com/Vertamedia/clickhouse-grafana/releases/tag/1.2.3

Perfect! Thank you )


Initial Rust library

Rust library!
This is a big PR and there are many different things that need to be reviewed before we merge it. I'm going to break down some categories here and will ask people to review the PR for specific things. (Obviously you can comment on anything but hopefully having a theme in your head helps you filter out some of the noise.
Reviews
Some categories of review (please suggest more) and some thoughts on things to think about while reviewing.
Public Facing API
Do the publicly exposed functions match those of the other language integrations. Can you do all the same things you can do in other languages. Do names of functions / error cases / error messages all match up?
Ops
Can we package up the rust library and run the tests on each platform.
Does the release job include these tests.
Can that package be published to crates.io.
Library Testing
Are the tests run?
Are all the polar tests we have in other integrations tested in the rust tests?
Are the parity tests equivalent to
Do we have enough tests of the user class system.
Tooling
Do the repl / debugger / printing / warnings / debug_mode, etc all work like in the other languages?
Correctness
Are all operations that happen in the library correct?

Unify
Isa
Lookups
Do they handle errors in the same way that the other language libraries do?

Classes
The rust class system is complicated so having some reviewers focusing specifically on that will be very helpful.
Does it work the way you would expect it to (though verbosely)
Procedural macros to automate registration are out of scope for this pr and will be added in as a followup.
Docs and Examples
Outstanding Work
Here's outstanding work either already known or revealed in review. Things above the line need to be accomplished before merging this PR and things below will be followups.
TODO before merging

[ ] Package crate for crates.io
This currently doesn't work because the crate depends on rust-core which is an unpublished crate. We either need a way to embed it or rust-core itself has to be a published crate (which also causes some problems for packaging and testing as you can't package a crate that depends on a non published crate).

TODO as followups

[ ] Procedural macros to automate registering classes and methods via attributes.
[ ] Docs / Quickstart and examples.
[ ] Error handling.

Related issues

#291

I pushed a commit containing my REPL suggestions, and PR #400 is a minor follow-up for the other languages.

Thanks!

There is no debugger to review.

Added to todo list.

Errors from queries are reported correctly, but POLAR_LOG doesn't work at all.

Added "Handle Messages" to the todo list.

Errors from queries are reported correctly, but POLAR_LOG doesn't work at all.

Added "Handle Messages" to the todo list.

Ah, yeah I used tracing to handle all messages. So you can get them through RUST_LOG. Should configure tracing to use POLAR_LOG for that instead though.


ZEPPELIN-3181. Enable impersonation support for kerberized cluster

What is this PR for?
This is to enable kerberos support for spark yarn mode in impersonation. Spark has one limitation that you can not specify keytab & proxyuser together. So this PR would run kinit before launching spark interpreter. so that user can enable impersonation for secured cluster.
What type of PR is it?
[Improvement | Feature]
Todos

[ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-3181

How should this be tested?

Verified manually,  see the following screenshot.

Screenshots (if appropriate)

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

I suspect a problem with this PR if the Kerberos ticket duration is shorter than the interpreter lifetime.
That is why I previously opened a PR that explicitly do a ticket renewal at an interval defined by the user. Please check the following PR https://github.com/apache/zeppelin/pull/2719


[Secret Manager] Consider rebooting SF clusters after rotating associated secrets

We've been bitten a couple times when we've rotated a secret in use by the SF clusters and our services stop working because the secret wasn't updated. We should consider finding a way (whether it's rebooting the SF clusters or some other process) to update the SF cluster with the new secret when it's rotated.

Release Note Category

[ ] Feature changes/additions
[ ] Bug fixes
[ ] Internal Infrastructure Improvements

Release Note Description

This appears to describe a feature change for the Secret Manager service. It was suggested that this should be related to another epic regarding secret removals. However, this work seems out of scope for the goals for that epic.

The current work as described seems out of scope, but I would hope the epic that deals with secrets would determine whether this is something that will be needed after the work to remove secrets. I would like to keep it in that epic so that once it gets started, it can be triaged from there as something that we still need to do or not.


Allow multi-measurements on one qubit

wrong branch this one is merging to new main, should be deleted


PRN.NetworkRole doesn't exist

According to the documentation, it should
PRN.NetworkRole role;
        if (IsServer) {
            role = IsOwner? PRN.NetworkRole.HOST: PRN.NetworkRole.SERVER;
        } else {
            role = IsOwner ? PRN.NetworkRole.OWNER: PRN.NetworkRole.CLIENT;
        }

but it doesn't. Apparently, it was replaced by PRN.Actor.Actor?

PRN.NetworkHandler doesn't exist too, so there are four actors to replace it with different constructors.
I can't understand how to add these events now
networkHandler.onSendInputToServer += SendInputServerRpc;
networkHandler.onSendStateToClient += SendStateClientRpc;

Your last comment says it all, there was a Network namespace under PRN. Now that you point it, it feels useless and redundant with the 2 classes prefix, NetworkHandler and NetworkRole.
Those 2 classes are now directly under PRN namespace, so it matches the readme.
Thank you for pointing this out ;)


Edge case in InOutOctree generating incorrect results

A user reported warnings from the InOutOctree when using a specific input mesh. The mesh is roughly an axis aligned cylindrical shape.
After some investigation, the mesh appears to be valid (watertight, w/ properly oriented normals), so this appears to be a legitimate bug.
I tried to reproduce the problem using several different axis-aligned truncated cylinders (https://github.com/LLNL/axom_data/tree/feature/kweiss/truncated-cones/quest/cones), but none of the meshes I generated exhibited this problem.

I've isolated the problematic case:

We're trying to determine if the blue box (seen as a wireframe) is inside or outside the triangle mesh (gray surface).
The red circle is the query point (on the face between the blue and gray boxes in the x-direction)
The algorithm finds the blue triangle first and is inside w.r.t. that triangle.
Since there is an intersection, the code stops early before checking against the red triangle.

This mesh exhibits another problematic case!

Here, the  gray cube intersects a set of triangles (black wireframes)
It's neighbor block (green) does not intersect any triangles and gets marked correctly as INSIDE.  (Note the fact that we can see the upper boundary is a rendering artifact. I've verified that the rest of the block is inside)
The green block's neighbor (red) is OUTSIDE the mesh, but gets marked as INSIDE by the flood filling algorithm.

The problem here is that this violates an assumption that INSIDE and OUTSIDE blocks are always separated by octree blocks that intersect the surface.  The issue appears to be that the triangles graze the face planes of the blocks (within the fuzzy tolerance that we're using for intersection tests).
I'll have to think about an appropriate resolution.  Perhaps the issue is that the green block needs to be marked as intersecting the cube (and should index its triangles)?

I've posted the user's mesh in the axom_data repo.
In a branch for now: https://github.com/LLNL/axom_data/blob/feature/kweiss/adds-cap-mesh/quest/cap.stl