Processor assumes annotations are on the classpath

With AutoValue 1.6, the annotations are no longer part of the AutoValue processor and are in a separate dependency, auto-value-annotations. This processor assumes that these types will be present and so when updating to 1.6, a NoClassDefFoundException is thrown.
Caused by: java.lang.NoClassDefFoundError: com/google/auto/value/AutoValue
        at com.ryanharter.auto.value.moshi.AutoValueMoshiAdapterFactoryProcessor.getSupportedAnnotationTypes(AutoValueMoshiAdapterFactoryProcessor.java:61)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment$ProcessorState.<init>(JavacProcessingEnvironment.java:505)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment$DiscoveredProcessors$ProcessorStateIterator.next(JavacProcessingEnvironment.java:597)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment.discoverAndRunProcs(JavacProcessingEnvironment.java:690)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment.access$1800(JavacProcessingEnvironment.java:91)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment$Round.run(JavacProcessingEnvironment.java:1035)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment.doProcessing(JavacProcessingEnvironment.java:1176)
        at com.sun.tools.javac.main.JavaCompiler.processAnnotations(JavaCompiler.java:1170)
        at com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:856)
        at com.sun.tools.javac.main.Main.compile(Main.java:523)
        ... 58 more
Caused by: java.lang.ClassNotFoundException: com.google.auto.value.AutoValue
        ... 68 more

The processor should either declare a dependency on auto-value-annotations or migrate away from referencing the @AutoValue by class and instead look it up via FQCN or Types/Elements.

is there a workaround to be able to compile project with latest autovalue  and autovalue-moshi?

I am still experiencing this issue using AutoValue 1.6.3 and AutoValue: Moshi Extension 0.4.5, and gradle 5.1.1
Declaring auto-value-annotations as an additional dependency with the annotationProcessor configuration seems to work for me, similar to what @liujoshua found at one point in auto-value-gson.
annotationProcessor 'com.ryanharter.auto.value:auto-value-moshi:0.4.5'
annotationProcessor 'com.google.auto.value:auto-value-annotations:1.6.3' // include again for auto-value-moshi

It looks like this is fixed on master. When someone with the appropriate access rights has time for it, I hope we get a new release. Thank you.

Looks like master has a bunch of great fixes, but there's a few issues still targeted for the 0.5.0 milestone before release.  If possible it would be great to get the stuff that's already finished out onto mavencentral.

Working on it!
On Mon, Mar 25, 2019 at 1:06 PM Ned Twigg<EMAIL_ADDRESS>wrote:

Looks like master has a bunch of great fixes, but there's a few issues
still targeted for the 0.5.0 milestone before release. If possible it
would be great to get the stuff that's already finished out onto
mavencentral.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/rharter/auto-value-moshi/issues/106#issuecomment-476356536,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABTEvkJEgSnw0YWIV07yiRhJ4W1Df_Usks5vaSwwgaJpZM4TcxwT
.


Added Section About Singletons

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you for opening this pull request.
This is a standard message notifying you that we’ve reviewed your pull request and have decided not to merge it. We would welcome future pull requests from you.
Reason:  This content is plagiarized from https://cocoacasts.com/what-is-a-singleton-and-how-to-create-one-in-swift
Thank you and happy coding.


[SR-1553] [QOI] Warn on discarded binding of () result

Previous ID
SR-1553

Radar
None

Original Reporter
@ddunbar

Type
Improvement

Additional Detail from JIRA

Votes
0

Component/s
Compiler

Labels
Improvement, DiagnosticsQoI

Assignee
zsalloum (JIRA)

Priority
Medium

md5: a541dcf4281d920a0880df5d3eabc2fa

Issue Description:
Swift should warn on the code below:
$ cat x.swift
func f0() -> () {}
let _ = f0()

$ swiftc -c x.swift
$

This is somewhat related to SE-0047, in that if you use let _ = ... to discard results, and then later refactor the code to not return a result, Swift won't help you find the other places in the code base to update.

Auditing a some old type checker issue to see if they are valid. This looks to me still relevant and a good first issue. So I'm marking as Starter Bug.


[Bug]:  Bugs when camelCase names have numbers in them

Bug Description
w and b skip over the number
example (^ are the positions the cursor jumps to with w and b)
divisibleBy10Test
^--------^---^

end skips over subword before number
example:
divisibleBy10Test
--------^---^---^

kebab-case works as expected.
Reproduction & Sample Text
...
neovim version
0.9.4

Special Settings
not that I know of.

Make sure you have done the following

[X] In case I have an issue with using the motions in operater-pending mode (cw, de, …), I read the notes on operator-pending mode in the README.
[X] I have updated to the latest version of the plugin.

Ah, good call, actually never noticed since I rarely have numbers in my camelCase words. Fixed.


AST import traversal to generate requirements

UV is in an amazing place to solve the python import traversal and scanning issue for larger projects. There are existing projects that have tried to do this (and I've recently implemented one of them myself that tries to fix some of the issues, but there are still usability issues that I think UV is in a great place to solve).
Existing Projects
Projects that I know of that have tried to do this include:

https://github.com/rmad17/pyreqs
https://github.com/nmichlo/pydependence
more that I can't remember at the moment.

Problems
The main problem with past projects that generate dependencies from imports are that they usually have some combination of the following:

naively find all imports in a package and try to use them, WITHOUT, traversal correct traversal between modules

use all files in a folder instead of correctly traversing, or respecting python path, or discovering modules.

possibly hardcoded based on the current environment
have hardcoded import to package maps that cannot be configured

e.g. PIL to pillow, or cv2 to opencv-python and/or opencv-python-contrib
rather have default list for popular packages that can be overridden

only generate requirements.txt, no support for modifying pyproject.toml or generating optional dependency lists e.g. from some specific starting point by tracing code from that point instead of using the entire module

very useful for generating optional extras e.g. have main dependencies, and then specific starting points or including lazy imports can get you extras.

support for lazy imports, as well as custom hooks for lazy imports (usually imports inside functions)

same as above e.g. you have a machine learning library of models, each that depends on specific frameworks, but you only use some of them in practice. You can generate extras for each module and trace it through the system.
e.g. lazy_import("torch.nn") << custom but could support with hooks
e.g. def my_fn(): import torch.nn
e.g. if TYPE_CHECKING: import torch.nn

limited configurability or customisability or overridability

overriding import mappings, e.g. tests could be in multiple repos, or google.protobuf not google is installed by something specific, or packages that provide multiple modules

limiting or extending the scope of dependency resolution, including across multiple repos and projects

useful if you have multiple repos in a private org and want to generate global minimal requirements

pre-commit hooks

automatically run when you commit

overrides / extra imports for specific outputs

Partially resolved
I tried to resolve many of these issues with pydependence above, but there are still problems that I think UV could solve:

cannot automatically fetch dependencies that it wants to resolve against.

e.g. files need to be present on system before resolving (not super important, usually never used as you're doing this on your own code)

relatively fast, but could be faster, astral has great rust python parsing support
hardcoded versions

if imports are found and mapped to requirements, this could automatically be used with UV dependency resolution to generate a lockfile that could be used instead of maintaining this yourself.

a little too complex, too much configuration needed to get it working initially, could be simplified a lot.
examples:

generated dependencies (can also manually define):

pyproject.toml deps
pyproject.toml extras

config for the above (could be simplified):

pyproject.toml config

Why in UV:

difficult to maintain minimal needed requirements for projects as teams grow and context is lost
want to generate or install minimal needed requirements for specific code paths e.g. CLI or service contained in same repo

useful for dockerfiles or pyinstaller (can even pipe UV output into pyinstaller)

Is this something that UV would ever be open to and maybe a design discussion could be started? Possibly with a reduced set of features to start?
Possible Implementation (based on pydependence)
The fact that UV can resolve deps separately from the import scanning means that a lot of the complexity is removed from such  project as you just need to, UV also has much of this support functionality already stable and used in other parts of the codebase as far as I can tell. The general algorithm from pydependence is:

define where to find source files (can be PYTHONPATH-like, exact module paths, from the env, could even support git repos)
construct a graph of imports based on source files
traverse graph to find used imports (from configurable starting points, default would be all files)
map imports to requirements (default would be common packages, but can override or add more)
use existing functionality to generate requirements files OR modify pyproject.toml with deps/extras

Help on implementation
Its possible I could assist in an implementation.

Would happily help contribute towards this if I know where to start and desired scope. Although probably most beneficial for larger companies struggling to maintain deps across projects rather than standard users.
pydependence is probably the most flexible implementation that I know of currently, and can aim to replicate some of its functionality, possibly with a more simplified interface to start. e.g. just single repo resolution, and can then extend towards different starting scopes and multiple project resolution?


Observation mode "pixel" raises AttributeError

Hi, when trying to create an environment that runs in the observation mode "pixel", the environment crashes due to the attribute self.observation_space not being defined:
from causal_world.envs import CausalWorld
from causal_world.task_generators.task import generate_task

task = generate_task(task_generator_id='stacked_blocks')
env = CausalWorld(task=task,
                  observation_mode='pixel')

Error:
File causalworld.py:238, in CausalWorld._reset_observations_space(self)
    237 def _reset_observations_space(self):
--> 238     if self._observation_mode == "pixel" and self.observation_space is None:
    239         self._stage.select_observations(["goal_image"])
    240         self.observation_space = combine_spaces(
    241             self._robot.get_observation_spaces(),
    242             self._stage.get_observation_spaces())

AttributeError: 'CausalWorld' object has no attribute 'observation_space'

I am not sure if this might be caused by a new gym version. A quick fix is to simply define self.observation_space = None before calling self._reset_observations_space() in the init (line 171).

Thanks for bringing this to our attention. I believe this is indeed due to a new gym version. Could you try to see if you still experience that error with the latest master version?

Hi @ftraeuble, thanks for checking! Enforcing an older gym version (0.17.2), as in the new master, removes the error for me.


General: Move loader logic from avalon to openpype

Brief description
Move load workflow and related functions from avalon-core into OpenPype.
Description
Moved bases of Loader plugin and load functions and also change names of functions and classes to identify their job. Load logic also consist of few database query functions that are loading related and at this moment don't have a place where they could be moved so they're part of load workflow. Added functions to register/deregister plugins/paths and to discover them for loading.
Renamed variables

Loader class renamed to LoaderPlugin
SubsetLoader class renamed to SubsetLoaderPlugin
load function renamed to load_representation
remove function renamed to remove_container
update function renamed to update_container
switch function renamed to switch_container

Note
This is not final structure of load workflow. The final structure rely on other structures and functions that are not yet moved and at the same time they can't be moved without this PR.
Testing notes:

Run host
Show loader tool
Check if loader are available
Try to trigger load (at least one Loader)

Tested hosts

[x] Nuke
[ ] Flame
[ ] Maya
[ ] Houdini
[ ] Blender
[x] Photoshop
[x] AfterEffects
[x] TVPaint
[ ] Harmony
[ ] Standalone Publisher

Related to PR https://github.com/pypeclub/avalon-core/pull/431

load function renamed to load_representation
remove function renamed to remove_container
update function renamed to update_container
switch function renamed to switch_container

I'm not a fan of the new names. I understand that with full OpenPype potentially exposing a much larger API that their might be the urge to refactor the straight load, remove, update and switch but the new functions names to me feel less explicit because it doesn't sound like they belong together. All these functions are related to loading containers and managing their loaded state and having load_representation be the counterpart to remove_container just feels off to me. Can we simplify or streamline this more?
I could get used to the new names of course - but at first sight this seems like something that could also confuse newcomers.

Loader class renamed to LoaderPlugin
SubsetLoader class renamed to SubsetLoaderPlugin

Pretty much same question as my previous comment - is this absolutely necessary? Sometimes less is more. Anyway, it's fine with me - it just strikes me as odd that it wasn't done with e.g. LegacyCreator? Similarly we don't do it on e.g. all the Loaders that are implemented for the hosts - they are called PointcacheLoader, CameraLoader, etc.
I feel like less is more and actually is more explicit too in this case.

All these functions are related to loading containers and managing their loaded state and having load_representation be the counterpart to remove_container just feels off to me. Can we simplify or streamline this more?

I agree with this one. the function should be load_container to keep consistency.

I could get used to the new names of course - but at first sight, this seems like something that could also confuse newcomers.

I guess that will be a matter of perspective. Exactly due to the fact that OpenPype is a large codebase, with overlaps into many other APIs and hosts, we'd like to be super explicit on any core functions to be able to keep track of everything. Searching for LoaderPlugin in the codebase gives you relevant results. Searching for Loader give you a whole lot of everything, especially because a GUI also called Loader :).
But in general all of the work in the first phase is to remove the avalon repository dependency. Once that is done, the real cleanup and refactoring can start, but at the moment, ambiguity in names, needs to be lowered to make that process simpler to keep track of.

@iLLiCiTiT ready to merge


Add files_field.

We have file_field, but it only supports a single file. Would love to add a separate field partial that supports multiple files.

Been looking into this one today and it looks like it wouldn't be too difficult to add multiple: true to the file input, but I'm assuming we want to handle these individually by adding/removing a div per each file. I'm thinking we'll need to edit the file Stimulus controller, especially since the file removal logic clears all of the attachments as opposed to one at a time per id.
Will keep looking into this one unless other issues need more attention.

We can modify the existing file_field partial to also support multiple file uploads. This way we can maintain a 1:1 match with rails native helpers.
Then to render multiple file uploads we can use -
<%= render 'shared/fields/file_field', form: form, method: :attachment, options: {multiple: true} %>
The caveat is the partial will become huge and difficult to maintain.


Some Questions about vocab?

Dear friends,
I checked some vocab.txt under uncased_L-12_H-768_A-12, chinese_L-12_H-768_A-12, multilingual_L-12_H-768_A-12 and find some questions:

1. Many ##xxx in vocab.txt, for an example:
$ cat uncased_L-12_H-768_A-12/vocab.txt | grep "##" | sort |  more
##at
##ata
...
 $ cat uncased_L-12_H-768_A-12/vocab.txt | grep -w "at"
at
##at

My question is: we have "at" in vocab.txt, why needs "##at" ? what does "##at" mean here ?
2. Many numbers are there in vocab.txt, for an example:
 $ cat uncased_L-12_H-768_A-12/vocab.txt | grep 0
   1609
690
1910s
840
1086
...

My question is: digit numbers are unlimited, is it reasonable putting them into vocab.txt?
3.  Some common word missing in vocab, for an example:
Word "fax" does not exists in uncased_L-12_H-768_A-12/vocab.txt,
  $ cat uncased_L-12_H-768_A-12/vocab.txt | grep fax
halifax
fairfax

Thanks your answer in advance.

##xxx means 'xxx' can be part of an unknown single word, for example, a person name 'Hypatia', can be split into pieces 'h', '##yp', '##ati', '##a', you can check that '##yp', '##ati' and '##a' are contained in the vocabulary file.
Same for numbers.
I think this vocabulary is not cover-all, and I do not know which one can cover all.


add to liquidity

since yesterday I am trying to add funds to liquidity  for the usdt / dfi pair
What happened: went through process and confirmation was given since however the transaction did not go through. I tried a second and third time and I get always the message to wait for a transaction to finish which does not hppen
What you expected to happen: fix the issue so I can add to liquidity
How to reproduce it (as minimally and precisely as possible): trie to add add to liquidity several times, mdoes not work
 see above
picture of issue.pdf
What are your environment parameters? at home using the system without any changes

DeFi App Version:
Operating System (OS): 2.30

Anything else we need to know?:
 attached picture of issue

I had the same issue since my update on 2.3.0 before 3 Days, when I try to add Liquidity. I can send tokens or Change in DEX whiteout Problems. Only Add Liquidity show this error message.
Also since the update, my Wallet BTC-DFI can't show transactions... it show the text, no transactions available. On my other Computer with the app 2.1.7, there it shows the transactions. Also there I can add Liquidity without problems.
Update: today the same issue with add Liquidity. Then I try to remove Liquidity and it works without problems. Then I test to add Liquidity again, and now it works.

tried that, removed some no Problem but adding does not work

I tried all that , removing works, adding does not work, same error message.
even over night <i left the app open and no action, transactions are not
shown .
On Sun, Feb 28, 2021 at 11:33 AM Capswiss<EMAIL_ADDRESS>wrote:

I had the same issue since my update on 2.3.0 before 3 Days, when I try to
add Liquidity. I can send tokens or Change in DEX whiteout Problems. Only
Add Liquidity show this error message.
Also since the update, my Wallet BTC-DFI can't show transactions... it
show the text, no transactions available. On my other Computer with the app
2.1.7, there it shows the transactions. Also there I can add Liquidity
without problems.
Update: today the same issue with add Liquidity. Then I try to remove
Liquidity and it works without problems. Then I test to add Liquidity
again, and now it works.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/DeFiCh/app/issues/577#issuecomment-787430573, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ASUZQVMMNXB7DHDGFMRKSHLTBILWXANCNFSM4YK32ONQ
.

I had the same problem and have documented my solution here.
https://defichain-wiki.com/wiki/210226-Block-Error
Many other users have also reported this problem.

Hi @helhimm , sometimes the error occurs when there's too many transaction in the same block. Update v2.3.1 is out.
Do give a thumbs up to this comment if your issue has been resolved, otherwise, please leave a comment with new information (include screenshots) and app logs. Thank you.

Hi @helhimm @Capswiss , update v2.3.2 is out, this is a mandatory update.
Please read through the release notes before updating.
Do give a thumbs up to this comment if your issue has been resolved, otherwise, please send new information (include screenshots) and app logs. Thank you


Add Prettier

I want to merge this change because i add prettier to formate the js files.

#3404

Here is the report for f7606d9536df1f6bf2965eaa5ab2dbd3dbd2c80b (Julian-B90/saleor @ master)
Base comparison is 5f2dde844f806219e385175c58366da1c157090b.
No differences were found. (click me)

# api.benchmark checkout
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  add billing address to checkout            	         34	         34	             20
  add shipping to checkout                   	          7	          7	              0
  checkout payment charge                    	         14	         14	              0
  complete checkout                          	          6	          6	              0
  create checkout                            	         48	         48	             24

# api.benchmark homepage
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve main menu                         	          5	          5	              0
  retrieve product list                      	          4	          4	              0
  retrieve secondary menu                    	          5	          5	              0
  retrieve shop                              	          2	          2	              0

# api.benchmark product
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product details                            	         15	         15	              3
  retrieve product attributes                	         13	         13	              2

# api.benchmark variant
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve variant list                      	         18	         18	              8

# api product sorting attributes
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data     	         21	         21	              0

We should also fix formatting in other JS files in saleor/static/js (e.g. in components or stores) subdirectories.

This looks really good now! I'm waiting for the CI to pass and it will be ready to merge.
This issue is marked with hacktoberfest label and we have a special gift for people who take part in it - ultra-fast Saleor socks 😄. Email me at<EMAIL_ADDRESS>with your address and we'll send you a package! 🎉


Does phpbrew work on macOS Sierra?

I installed phpbrew on macOS Sierra. I installed php-5.6.29 and 7.1.0. When I go to localhost/phpinfo.php, it shows raw code.  etc. So how can I make it work on Sierra? Any suggestions?

Did you execute the install command with +apxs2?
btw, you need turn off rootless before you build php.

It seems that you didn't setup your php well. the OS X built-in apache2 doesn't support php. You will have to install one manually.
Please come back to re-open this issue if this was not resolved.


Release 1.2.1

docket:

#354

And that is all - small hotfix release.

This is complete:

https://pypi.python.org/pypi/pex/1.2.1
https://github.com/pantsbuild/pex/releases/tag/v1.2.1


[Event Request] Table 39 - Purchase Line - OnBeforeValidateJobLineDiscAmountLCY

Dear ALAppExtensions team,
through this issue we would like to request adding event publisher OnBeforeValidateJobLineDiscAmountLCY in Table 39 Purchase Line with the following signature:
[IntegrationEvent(false, false)]
local procedure OnBeforeValidateJobLineDiscAmountLCY(var PurchaseLine: Record "Purchase Line"; var TempJobJournalLine: Record "Job Journal Line" temporary; var IsHandled: Boolean)
begin
end;

which would be called as follows in the OnValidate trigger of field 1011 - Job Line Disc. Amount (LCY):
trigger OnValidate()
// >>>> New >>>>>>>>>>>>>>>>
var
    IsHandled: Boolean;
// <<<< New <<<<<<<<<<<<<<<<
begin
    // >>>> New >>>>>>>>>>>>>>>>
    OnBeforeValidateJobLineDiscAmountLCY(Rec, TempJobJnlLine, IsHandled);
    if IsHandled then
        exit;
    // <<<< New <<<<<<<<<<<<<<<<

    TestField("Receipt No.", '');
    if "Document Type" = "Document Type"::Order then
        TestField("Quantity Received", 0);
    if JobTaskIsSet then begin
        CreateTempJobJnlLine(false);
        TempJobJnlLine.Validate("Line Discount Amount (LCY)", "Job Line Disc. Amount (LCY)");
        UpdateJobPrices();
    end;
end;

Thanks in advance!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 47054.


PostgreSQL Version Update

PostgreSQL 10 is no longer going to be supported after Nov 2022. Also this appears to be a performance bottleneck for the system.

@CuriouzK0d3r this will be a clean update in case migrations are not feasible. Will connect issue when you open  upgrade PR.


Staging

Description
Configured Travis CI
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

Change Status

[x] Complete, tested, ready to review and merge

How Has This Been Tested?
Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] There are no merge conflicts

Looks good, but I'm seeing that it's out of date with respect to master, so I'm wondering what is going on. We can just go ahead and see what happens.

Yeah. Could also pull the changes from master into staging before merging. Most likely just readme updates.


models -song

Songs Table:
Stores information about individual songs.
id: Unique identifier for the song (Primary Key).
title: The song's title.
album: The album the song is from. r
elease_date: The date the song was released.
genre: The genre of the song.
artist_id: The id of the artist who performed the song (Foreign Key referencing Artists.id).


how to setup a prover node on mainnet

I follow the instruction in folder scroll/prover. When i run ./build/bin/prover ,  i see a very long error message in terminal. I think it may be because I didn't configure the JSON file. But how do I know the url of coordinator and the l2geth node.Or rather, what did I do wrong elsewhere. Could anyone tell me.

Please follow the instruction on the website. It seems they updated the docs.

We currently don't allow new 3rd-party provers to join our network. Once this changes we will publish step-by-step instructions.


Update code to use docker network instead of deprecated command

Currently a deprecated command is used called "New-ContainerNetwork" is used in our scripts here, so replacing it with docker network. Also, swapped docker install to happen before network creation so it can leverage the docker create network command.
Solves issue: #461
Tested by locally starting a servercore VM and running the updated script: .\install-docker-ce.ps1 -useDHCP, then used docker to pull and start a container.

Merging the solution for WS2022, if we need to add more case to handle Win 10, 11 we can add them in the future.


Suppress all output to console

Is your feature request related to a problem? Please describe.
I'm always frustrated when I do "az --version | Out-Null" or any version of this syntax where I'm trying to put the version information into a variable.  I always get
Please let us know how we are doing: https://aka.ms/azureclihats
and let us know if you're interested in trying out our newest features: https://aka.ms/CLIUXstudy

Describe the solution you'd like
If I pipe to Out-Null there is no console output.
My goal is control if and when I need to upgrade.  if something is out of date I ask the user if they want to upgrade.
My profile script checks the version information of many modules including az cli.
when I do
$v = az --version | Out-Null, most of it works but I still get that header on the console.
Describe alternatives you've considered

$v = az --version --output none,   Gives me the same header
Even tried
$v = az --version --output none | Out-Null,  Gets the same header
Additional context
I'd like to see the ability to check individual version numbers of modules & main az version # only
or something that just answers the question of needing an upgrade
az --needupgrade
OR
az --version --name azure-cli
PS> 2.20.0
az --version --name azure-devops
PS> 0.18.0

--output none only works for stdout . These survey lines
Please let us know how we are doing: https://aka.ms/azureclihats
and let us know if you're interested in trying out our newest features: https://aka.ms/CLIUXstudy

are written to stderr which can be disabled with 2> $null:
> az --version > $null 2> $null
>

az --version is only designed for better human readability. To only check the version, you may use az version which outputs a JSON:
> az version
{
  "azure-cli": "2.19.1",
  "azure-cli-core": "2.19.1",
  "azure-cli-telemetry": "1.0.6",
  "extensions": {
    "account": "0.2.1",
    "support": "1.0.2"
  }
}

As for

az --needupgrade

perhaps we can add a programmatic way to az version to detect if update is available? Something like:
> az version --check-upgrade
{
  "azure-cli": "2.19.1*",
  "azure-cli-core": "2.19.1*",
  "azure-cli-telemetry": "1.0.6",
  "extensions": {
    "account": "0.2.1",
    "support": "1.0.2"
  }
}

or
> az version --latest
{
  "azure-cli": "2.20.0",
  "azure-cli-core": "2.20.0",
  "azure-cli-telemetry": "1.0.6",
  "extensions": {
    "account": "0.2.1",
    "support": "1.0.2"
  }
}

@fengzhou-msft

I like the --latest option but...
I still like having an option that tells me if the core or extension needs updating. returning true of false.
something like
az version --name azure-cli --upgrade
or
az version --name azure-cli --islatest
You could apply that to any module or extension
this way I could write
if (az version --name azure-cli --upgrade) ) {
az upgrade
}
You suggestion for suppression output works, so I can work around that.
Thanks for the work you do and your help.
Joe

@SenseiJoe, glad to know it works for you!
Perhaps we can make something like
> az version --check-upgrade
{
  "azure-cli": true,
  "azure-cli-core": true,
  "azure-cli-telemetry": false,
  "extensions": {}
}

Then you may query the result with --query '\"azure-cli\"' (pay attention to Quoting issues with PowerShell).
Indeed, comparing version doesn't seem like a good option to me, as 2.10.0 can actually be smaller than 2.9.0 due to string comparison.

Thanks, I think that will work just fine. (as long as that banner doesn't show up) ;)

@SenseiJoe It looks like you may be interested in the auto-upgrade feature. You can enable it by running:
az config set auto-upgrade.enable=yes auto-upgrade.prompt=no Azure CLI will then periodically check for new versions and auto-upgrade when a command finishes running.


AWS endpoint issues around uploading and processing

@mojodna Quick summary follow up from our side convo about S3 regions. I didn’t resolve it but it seems to not be blocking so documenting here for others for further follow up.
tldr - seems to not matter when you’re deployed on an ec2. A Sydney region ec2 did not have any issues processing and uploading to a Sydney region S3 bucket with the original code.
Problem: when running locally, we were encountering an issue when using the upload form to S3 buckets not in the us-east-1 region. Items would upload to the temp bucket but not download to be processed. Since our buckets were in the Sydney region, but providing a default path-style endpoint http://s3.amazonaws.com/bucket, it wouldn’t resolve. https://github.com/hotosm/oam-browser/blob/oauth-login/src/components/uploader/home.js#L274-L277
Docs on paths: http://docs.aws.amazon.com/AmazonS3/latest/dev/UsingBucket.html#access-bucket-intro
Using a path-style endpoint, you can only use the http://s3.amazonaws.com/bucket endpoint if your bucket is in us east. otherwise you need to use a region-specific endpoint, http://s3-aws-region.amazonaws.com/bucket. Path-style endpoints seem to be easier to factor for since some virtual-style endpoints differ between regions.
BUT...
When changing the uploader form to use a region-specific path-style, everything processes using the dynamic tiler fine locally, but we encounter errors when trying to upload to the final bucket. I suspect in the same way there was an issue with the uploader form using the wrong endpoint, the tiler is as well. But I couldn’t pin point. It seems to happen here in the process.sh uploading step: log output.
Last BUT...
This doesn't seem to matter when you're deployed on an ec2 in the same region. When we deployed on a Sydney region ec2, the url format as it stands now seems to process fine.

Brief thought here:

When changing the uploader form to use a region-specific path-style, everything processes using the dynamic tiler fine locally, but we encounter errors when trying to upload to the final bucket. I suspect in the same way there was an issue with the uploader form using the wrong endpoint, the tiler is as well. But I couldn’t pin point. It seems to happen here in the process.sh uploading step: log output.

Setting AWS_DEFAULT_REGION=<current region> might address it (and is probably implicit when using AWS tools on EC2 instances).
I'm guessing that s3.amazonaws.com resolves locally (when on EC2) to the S3 endpoint in the same region.
Nice that it works on EC2, but we should definitely make it work everywhere.


Added feature to download boot jdk on demand

currenlty only dne for linux, shoudl be easy to extend for windows, not sure what whith other platfroms.
Is done via magic parameter of download for -J: -J download

The windows label is wrong. I can not change t on my own. Please fix it to (linux) if possible.
I think I will add windows support once I get some cygwn machine,  but it will take time.

I guess on windows, I will extract https://github.com/adoptium/temurin-build/blob/95385f4abc6cfe01e574f55cbde5a4c925bc031a/build-farm/platform-specific-configurations/windows.sh#L47-L99 to the downloader.sh as downloadWindowsBootJDK aybe with some adjustments... thoughts?

ps: I had noticed the bash-lint issues, mos tof them are valid. Will elaborate as the review progresses here.

Now works for windows and linuxes. I do not have  more paltforms to try on. Please consider this.

Thanx a lot for eyball!

@judovana Needs a rebase

@judovana Needs a rebase

yup. Thats exactrlythe reasonwhy I do not want to change the extracted download code in this PR.

/thaw

The windows label is wrong. I can not change t on my own. Please fix it to (linux) if possible. I think I will add windows support once I get some cygwn machine, but it will take time.

Tried but I don't trust the labeller not to add windows back in again ;-)

ping please?

@andrew-m-leonard  TY!
@sxa its upt o you now

Architecturally I'm not a fan of this. The stuff in the root of this repository and sbin is supposed to be fully independent. The bits in build-farm is for the adoptium build processes and configures the environment for our setup and wraps around the other stuff. Calling out from sbin to platform-specific-configurations is therefore not ideal.
I like the idea of the option to specify a boot JDK to download, but I think this implementation will need some refinement first.

I had resoled the major issue you had (the global variable) but the shared file remained in build-farm/platform-specific-configurations/downloaders.sh . I left it here, as all the code is originally from  build-farm/platform-specific-configurations/ files.  Maybe I would vote for leaving it there, with future work on other platforms, and move it only once it have been finished. But that can be very long time, thus the build-farm/platform-specific-configurations/downloaders.sh will be breaking the ' The stuff in the root of this repository and sbin is supposed to be fully independent." which I like, and do not want to be cause of its fade away.

done. Tested on win x86, el8 aarch64 and f38 x64 aganst jdk8,17 and 21.

/integrate

LGTM and I've very happy to see all of this logic moved out of the platform-specific-configurations directory :-)
I've done a few tests on Linux but not Windows.
In the future we should look at doing the same for AIX, Solaris and macos so I suggest creating an issue for that since I'm not going to mandate that we do it now.
Also, one other question for anyone else reading this - should we default to download if we can't find a JDK in any other location?

that would be NACK by me.  It is not small dependence, and one should have boot jdk around. The -J download is highly  comfortable option


Question about adding Genomes in snaptools snap-pre

Hi! Thanks for building this package, it's been really helpful so far!
I had a question about using snap-pre.
I work in chicken, and we recently had a new assembly come out (galGal6) that I've aligned my reads to. (and generated appropriate chrom.sizes)
When I specify
 --genome-name galGal6
it throws an error asking me if the name is correct. Since it works with
--genome-name galGal5
I've just used that and run, but will this cause issues down the line?
Thanks!
Austin

Hi Austin,
It will not cause any issue for downstream analysis.
Best,
Rongxin Fang
Ph.D. Student, Ren Lab
Ludwig Institute for Cancer Research
University of California, San Diego

On May 23, 2019, at 4:55 PM, Austin-s-h<EMAIL_ADDRESS>wrote:
Hi! Thanks for building this package, it's been really helpful so far!
I had a question about using snap-pre.
I work in chicken, and we recently had a new assembly come out (galGal6) that I've aligned my reads to. When I specify
--genome-name galGal6
it throws an error asking me if the name is correct. Since it works with
--genome-name galGal5
I've just used that and run, but will this cause issues down the line?
Thanks!
Austin
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/r3fang/SnapTools/issues/11?email_source=notifications&email_token=ABT6GG6A3PX4IPNOA244A3DPW4AD7A5CNFSM4HPKGVK2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GVR6ERA, or mute the thread https://github.com/notifications/unsubscribe-auth/ABT6GG7VCM22RPM5GZKY6GDPW4AD7ANCNFSM4HPKGVKQ.

Hi Austin, It will not cause any issue for downstream analysis. Best, -- Rongxin Fang Ph.D. Student, Ren Lab Ludwig Institute for Cancer Research University of California, San Diego
…
On May 23, 2019, at 4:55 PM, Austin-s-h @.***> wrote: Hi! Thanks for building this package, it's been really helpful so far! I had a question about using snap-pre. I work in chicken, and we recently had a new assembly come out (galGal6) that I've aligned my reads to. When I specify --genome-name galGal6 it throws an error asking me if the name is correct. Since it works with --genome-name galGal5 I've just used that and run, but will this cause issues down the line? Thanks! Austin — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#11?email_source=notifications&email_token=ABT6GG6A3PX4IPNOA244A3DPW4AD7A5CNFSM4HPKGVK2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GVR6ERA>, or mute the thread https://github.com/notifications/unsubscribe-auth/ABT6GG7VCM22RPM5GZKY6GDPW4AD7ANCNFSM4HPKGVKQ.

Hi, I also have a similar question.
It seems snaptools snap-pre cannot recognize homemade name.
To my understand, for example here, when we created index via snaptools index-genome, the --output-prefix should be galGal5 though the actual fasta is galGal6. Then, the next step via snaptools snap-pre, still use galGal5. Is it correct?
Or it will use internal real galGal5 to create snap files?
Thanks & best,
Menghan


fix: set to gauge

As per
https://docs.datadoghq.com/developers/metrics/counts/
and
https://github.com/lexmag/statix/blob/master/lib/statix.ex
Statix does not currently support sending counters as count
Overview
Changing wrong use of set to gauge so that we're able to show reductions, io operations etc.
Changes

set to gaguge + comment

Testing
/

Coverage remained the same at ?% when pulling 76e1d604e31469eed85b0570512519644845b691 on dd_tags into c8b37ee652d56d15f05b11cc1d86cdd82d578439 on master.


Hydrogen should expose types for page components and API functions

export type HydrogenAPIRoute = (request: Request, options: RequestOptions) => Promise<any>
export type HydrogenPage = (props: HydrogenPageProps & ServerState): => ReactComponentThingy

This ensures a developer building a TS project can get nice type hints and stuff.

I can work on this if you want :smile:

Go for it!

Sure, let's go!

An idea, instead of HydrogenAPIRoute resolving to an any promise, it could instead do something like:
type JSONValue =
    | string
    | number
    | boolean
    | JSONObject
    | JSONArray;

interface JSONObject {
    [x: string]: JSONValue;
}

interface JSONArray extends Array<JSONValue> { }

export type HydrogenAPIRoute = (request: Request, options: RequestOptions) => Promise<Response|string|JSONObject>


Increment version for cognitiveservices releases

Increment version for cognitiveservices releases

Can one of the admins verify this patch?


helper.js: Be more clear when a temp script cannot be run due to RAM issues.

FAIL: Attempt 5 of 5 raised an error: The temp script was not run (likely due to insufficient RAM).
This comes up quite a bit for early players, so it would be nice if there was a bit more information to guide them along. The trick will be to gather this information without leading to further errors and without consuming additional RAM!

Two ideas. First is to check the script ram requirement, and include it in the error message:

The second is to remind the user when daemon.js starts up that they are responsible for manually upgrading home ram!


1.7.0 here! Ready and willing!

Added new form - Mod Downloader. It could download most popular mods using your default web browser
Some code improvements
(I'm waiting for README.MD merge problem :-) )

Merge conflict
Oh boi this time it's a bit more to merge 😬 . Also the obligatory README.MD conflict ;-).
Conflicting files
DoW Mod Manager/DoW Mod Manager.csproj
DoW Mod Manager/ModManagerForm.cs
DoW Mod Manager/ModMergerForm.cs
README.md
changelog.txt

Make sure you merged the latest master branch into yours and resolved the conflicts proper. For this I am usually using http://meldmerge.org/ as the mergetool because it's so nicely verbose and you can easily merge text based files. 👌

About conflict merging tool - Meld looks nice but I have probably even
better thing - GitKraken. It's a full Git managing solution (create,
delete, merge - you name it). https://youtu.be/ub9GfRziCtU
I could even say that GitKraken for Git is the same as DoW Mod Manager for
Dawn of War - it makes it "casually easy" ;-)
About changes - yes I agree that opening ModDB is not that useful but it
opens MdDB + DawnOfWar Mods + sorting it by user rating. So it's kinda
useful... I'm not sure.
About alphabetical - I agree. I will change it now or in 1.8.1 (so very
soon in any way).
About it integration in main Frame or any improvements - yes I WILL
definitely improve it. For 1.8.0 his existence is already a good thing :-)
Maybe sorting it alphabetical is a good thing for 1.8.0
On Mon, Jun 8, 2020 at 1:21 PM Dennis S<EMAIL_ADDRESS>wrote:

@Fragjacker requested changes on this pull request.
Change request
Alright I have looked at the mod downloader and it looks pretty neat!
However I'd remove the Open ModDB.com button since it serves no purpose
really in the context of fetching particular mods. Also the list of
downloadable mods should be sorted alphabetically so it's easier to find
particular mods.
Optional suggestions
It would be also nice if all dependency mods, required to run the selected
mod, could also be easily downloaded directly. Maybe you could extend the
main window with such functionality since it already lists dependency mods.
Currently the user has to manually go over all dependancies and look them
up from the list of mods. Also you may even want consider adding a search
bar, in case the list of downloadable mods grows even larger.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/Fragjacker/DoW-Mod-Manager/pull/9#pullrequestreview-426096436,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APM5F34IHQ7FKHV2J264PP3RVS3UHANCNFSM4NYFHYFQ
.

Also the logic behind "Open ModDB.com" is like this:
"Ah shit! My favorite mod is not here!" - well that button opens ModDB on
DoW mods page. It's "Do it yourself" button.
Maybe I'll delete it in future. Or rename it to something more suitable.
Let it sit there for one patch :-)
On Mon, Jun 8, 2020 at 2:17 PM Igor Sandu<EMAIL_ADDRESS>wrote:

About conflict merging tool - Meld looks nice but I have probably even
better thing - GitKraken. It's a full Git managing solution (create,
delete, merge - you name it). https://youtu.be/ub9GfRziCtU
I could even say that GitKraken for Git is the same as DoW Mod Manager for
Dawn of War - it makes it "casually easy" ;-)
About changes - yes I agree that opening ModDB is not that useful but it
opens MdDB + DawnOfWar Mods + sorting it by user rating. So it's kinda
useful... I'm not sure.
About alphabetical - I agree. I will change it now or in 1.8.1 (so very
soon in any way).
About it integration in main Frame or any improvements - yes I WILL
definitely improve it. For 1.8.0 his existence is already a good thing :-)
Maybe sorting it alphabetical is a good thing for 1.8.0
On Mon, Jun 8, 2020 at 1:21 PM Dennis S<EMAIL_ADDRESS>wrote:

@Fragjacker requested changes on this pull request.
Change request
Alright I have looked at the mod downloader and it looks pretty neat!
However I'd remove the Open ModDB.com button since it serves no purpose
really in the context of fetching particular mods. Also the list of
downloadable mods should be sorted alphabetically so it's easier to find
particular mods.
Optional suggestions
It would be also nice if all dependency mods, required to run the
selected mod, could also be easily downloaded directly. Maybe you could
extend the main window with such functionality since it already lists
dependency mods. Currently the user has to manually go over all
dependancies and look them up from the list of mods. Also you may even want
consider adding a search bar, in case the list of downloadable mods grows
even larger.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/Fragjacker/DoW-Mod-Manager/pull/9#pullrequestreview-426096436,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APM5F34IHQ7FKHV2J264PP3RVS3UHANCNFSM4NYFHYFQ
.

Ah yes Gitkraken. I have been using it for a while but it is unfortunately proprietary software which has some functionality blocked behind a paywall. Another very similar and free tool is https://www.sourcetreeapp.com/ . I am however keep using command line tools such as Git bash and posh git https://github.com/dahlbyk/posh-git since you can do stuff with them that you can't do with GUI clients 😁 .

I like your idea - take good things from different sources so you could
have the best overall experience :-)
On Mon, Jun 8, 2020 at 3:24 PM Dennis S<EMAIL_ADDRESS>wrote:

Ah yes Gitkraken. I have been using it for a while but it is unfortunately
proprietary software which has some functionality blocked behind a paywall.
Another very similar and free tool is https://www.sourcetreeapp.com/ . I
am however keep using command line tools such as Git bash and posh git
https://github.com/dahlbyk/posh-git since you can do stuff with them that
you can't do with GUI clients 😁 .
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/Fragjacker/DoW-Mod-Manager/pull/9#issuecomment-640570147,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APM5F322M4VVV5L7EUP64YTRVTJ6PANCNFSM4NYFHYFQ
.

I'm sorry for creating MasterX branch but I couldn't merge to a normal master branch - button just doesn't work. I tried in Firefox 77.0.1 and Edge 44.19041.1.0

@IgorTheLight Here the command line tools prove to be king once again 😁 , check out this article https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/merging-an-upstream-repository-into-your-fork how to merge from another repository, then you can use some mergetool to resolve the conflicts proper locally then push to your repo.

Thanks.
It's strange that problems are appearing out of thin air. I resolved all
problems (all of them were stupidly easy to solve - Git could do that by
itself to be honest).
While I'm reading the article you could do a very simple thing - clone my
master branch and copy it on top of your master branch then push as a
commit. That's very "cheap" but it could be done in less than a minute. Our
differences are minimal (capital letter instead of non-capital or a few
spaces more + my new lines of code).
Or I will try to resolve it in a proper way very soon.
On Tue, Jun 9, 2020 at 3:06 PM Dennis S<EMAIL_ADDRESS>wrote:

@IgorTheLight https://github.com/IgorTheLight Here the command line
tools prove to be king once again 😁 , check out this article
https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/merging-an-upstream-repository-into-your-fork
how to merge from another repository, then you can use some mergetool to
resolve the conflicts proper locally then push to your repo.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Fragjacker/DoW-Mod-Manager/pull/9#issuecomment-641245973,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APM5F374Y44OGBF4KNX2I33RVYQSXANCNFSM4NYFHYFQ
.

I made two videos to show WHAT kind of problems Git couldn't resolve by itself and why I'm stuck:
https://www.youtube.com/watch?v=IYCqHJCJNpQ
https://www.youtube.com/watch?v=6YjcPwlW--I

Hehe yeah manual online merge conflict resolving is garbage. Either use some GUI client or command line tools to resolve them locally on your comp and then push directly to your repo. I am usually using Meld for this since it allows for swapping changes easily. Sourcetree should work too for this or any other client with a proper mergetool incorporated.

Alright I have used my divine command line tools powers to resolve the conflicts for you and merged it into master now 😁 .

Thanks!
I basically choose the second option - don't bother with 1.7.0 when 1.8.0
will have the same issues in a few days. Well - it most likely will :-)
But if you get the 1.7.0 - it's fine too! :-) You could test some mod
downloading capabilities of my wonderful (but very simple and without any
search and automated features) module!
SettingsManager is on the way! It already could read, show in UI, change
and write back the changes. It just lacks some polish. 1.8.0 will have NO
improvements for any other parts of the program - there will come in 1.8.1
and 1.8.2
But none the less - thanks for taking care of 1.7.0 :-)
On Fri, Jun 12, 2020 at 1:16 PM Dennis S<EMAIL_ADDRESS>wrote:

Alright I have used my divine command line tools powers to resolve the
conflicts for you and merged it into master now 😁 .
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Fragjacker/DoW-Mod-Manager/pull/9#issuecomment-643194580,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APM5F37UCJA4S72HSIMCJILRWH57LANCNFSM4NYFHYFQ
.

Hi!
1.8.0 is ready! I'm not sure what would be faster - create a pull request
with a ton of issues or you just grab my sources for Releases and commit
them as your own. I'm really not trying to run from the problems - just
trying to make our lives easier ;-) I will do as you ask in that regard.
Let's call that update... ummm... 1.8.0 - "The Machine Spirits are willing"
The next update would be 1.8.1 - optimizations and refactoring. Our EXE
file will be much lighter in 1.8.1 - I have a good idea how to do that ;-)
About other refactoring. I will basically see through ALL the code (again)
and will try to improve it. You have the last chance to say "Please no! Not
the improvements!" before I started ;-)
On Fri, Jun 12, 2020 at 11:39 PM Igor Sandu<EMAIL_ADDRESS>wrote:

Thanks!
I basically choose the second option - don't bother with 1.7.0 when 1.8.0
will have the same issues in a few days. Well - it most likely will :-)
But if you get the 1.7.0 - it's fine too! :-) You could test some mod
downloading capabilities of my wonderful (but very simple and without any
search and automated features) module!
SettingsManager is on the way! It already could read, show in UI, change
and write back the changes. It just lacks some polish. 1.8.0 will have NO
improvements for any other parts of the program - there will come in 1.8.1
and 1.8.2
But none the less - thanks for taking care of 1.7.0 :-)
On Fri, Jun 12, 2020 at 1:16 PM Dennis S<EMAIL_ADDRESS>wrote:

Alright I have used my divine command line tools powers to resolve the
conflicts for you and merged it into master now 😁 .
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Fragjacker/DoW-Mod-Manager/pull/9#issuecomment-643194580,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APM5F37UCJA4S72HSIMCJILRWH57LANCNFSM4NYFHYFQ
.

@IgorTheLight A pull request is definetely the way to go, even if I just merge it with my command line powers, just so that it shows up pull request history for anyone to know the origins of the changes 😁 .

Let's call that update... ummm... 1.8.0 - "The Machine Spirits are willing"

I am fine with that.

The next update would be 1.8.1 - optimizations and refactoring. Our EXE
file will be much lighter in 1.8.1 - I have a good idea how to do that ;-)
About other refactoring. I will basically see through ALL the code (again)
and will try to improve it. You have the last chance to say "Please no! Not
the improvements!" before I started ;-)

The code of my Mod Manager has been mostly written years ago so I am not surprised if there are better ways to do this. Cleanups and Refactorings are always a welcomed addition! Also feel free to remove unused outcommented old code. 😀

Ah thanks!
I think DoW Mod Manager is in a good state! It was in a good state even
before I joined :-)
I saw an interesting thing -
https://github.com/THEONLYDarkShadow/Dawn-of-War-Mod-Manager
So this one is a C++ (wxWidgets Framework) port of your earlier version?
There is also this thing (an ancient relic - 2006 year)
https://www.moddb.com/games/dawn-of-war/downloads/mod-manager-2-2
I never heard of this before! It seems like only your project has survived!
:-)
I'm not sure WHY I'm looking for all those relics - maybe that's some
Librarian thing going on ;-)
Don't worry - I'm not going anywhere! I'm just (suddenly) interested in Mod
Manager story. I used only this one. We don't even have a proper competitor!
That's most likely because DoW1 is not THAT popular and community is having
fun with your DoW Mod Manager and not really have any reason to create
another one.
Forks are created because someone is not satisfied with the program. Guess
there is no such problem here!
And after a few additions there will be even less reason to start a Heresy
;-)
On Mon, Jun 15, 2020 at 1:14 PM Dennis S<EMAIL_ADDRESS>wrote:

@IgorTheLight https://github.com/IgorTheLight A pull request is
definetely the way to go, even if I just merge it with my command line
powers, just so that it shows up pull request history for anyone to know
the origins of the changes 😁 .
Let's call that update... ummm... 1.8.0 - "The Machine Spirits are willing"
I am fine with that.
The next update would be 1.8.1 - optimizations and refactoring. Our EXE
file will be much lighter in 1.8.1 - I have a good idea how to do that ;-)
About other refactoring. I will basically see through ALL the code (again)
and will try to improve it. You have the last chance to say "Please no! Not
the improvements!" before I started ;-)
The code of my Mod Manager has been mostly written years ago so I am
not surprised if there are better ways to do this. Cleanups and
Refactorings are always a welcomed addition! Also feel free to remove
unused outcommented old code. 😀
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Fragjacker/DoW-Mod-Manager/pull/9#issuecomment-644038295,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APM5F35GUUAOXXCDIZ4HPW3RWXX7LANCNFSM4NYFHYFQ
.

https://github.com/THEONLYDarkShadow/Dawn-of-War-Mod-Manager

This one has an interesting feature. Reading the warnings.log file to prompt the user any issues if a mod crashes. This would be handy because currently the Mod Manager only scans for all *.module files and then checks if their folders exist and not if they are actually complete. Hence mods can crash even if they appear as installed because they are corrupted or didn't even fully installed all contents in the first place. Critical crashes in warnings.log files usually look like this MOD -- Fatal Data Error. It would be cool to have some handling by the Mod Manager for this case 😀 .

Sounds interesting! This may be a new feature for 1.9.0
Also I'm looking at "Time Resolution" an interesting Windows thing that all
games have to change to boost performance. I have to check if DoW changes
it or not.
Crysis 3 didn't change it before some patch :-)
https://vvvv.org/contribution/windows-system-timer-tool
https://github.com/tebjan/TimerTool
On Mon, Jun 15, 2020 at 6:12 PM Dennis S<EMAIL_ADDRESS>wrote:

https://github.com/THEONLYDarkShadow/Dawn-of-War-Mod-Manager
This one has an interesting feature. Reading the warnings.log file to
prompt the user any issues if a mod crashes. This would be handy because
currently the Mod Manager only scans for all *.module files and then
checks if their folders exist and not if they are actually complete.
Hence mods can crash even if they appear as installed because they are
corrupted or didn't even fully installed all contents in the first place.
Critical crashes in warnings.log files usually look like this MOD --
Fatal Data Error. It would be cool to have some handling by the Mod
Manager for this case 😀 .
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Fragjacker/DoW-Mod-Manager/pull/9#issuecomment-644195121,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APM5F37YFZF4OBUBG3NCPO3RWY24HANCNFSM4NYFHYFQ
.


[mempool] Mempool test updates

Modernizes some tests by combining duplicated logic / renaming so that it's clear you're starting up a mempool for a peer, rather than somehow initializing an smp / shared_mempool like 10 times.

/land


Support for AWS cloud-config

Config from: https://github.com/kubernetes/kubernetes/blob/release-1.6/pkg/cloudprovider/providers/aws/aws.go#L389-L429

@matlockx can we fire a CI run for this?

@rajiteh unfortunately i do not have the permissions to do that. @rsmitty ?

happy to ci check this, but I'd like to understand more about why this is needed vs. the current way we do it, by letting the cloud-provider figure out its own info through IAM roles.

ci check this

cannot say anything about the benefit...
ci job says 'passed' but state is not correctly presented here.

@rsmitty there are some provider configs that can only be set by the cloud config file. in our use case we just wanted to set aws_disable_security_group_ingress but i figure having full control over these options might be useful regardless.

@rsmitty do you think this PR can get merged? thanks

/lgtm
@rajiteh sorry for the delay, could you rebase?


Fix logic

Since we previously set the $namePrefix variable to $null when set to "EmptyNamePrefix" we should check for a $null value instead.

Thanks for your contribution, @wpouseele. I agree with it.


delete removeDes  from onePath instead of allPath

Reviewer checklist

[ ] Test coverage: stack test --coverage
[ ] Public API documentation: stack haddock

I removed the RemoveDestination steps after  DeriveSeq and DerivePar in these PRs: https://github.com/kframework/kore/pull/975 https://github.com/kframework/kore/pull/955
If that looks good to you I think you can close this.

thanks @ana-pantilie , i will close this PR.


Symphony might convert HTTP Request body to array

which leads to exception 'ErrorException' with message 'Array to string conversion' in /limoncello/src/Http/FrameworkIntegration.php:31

is this the reason why i can't make the "included" works?

I think it's not. I just found that on under some circumstances symfony unexpectedly (to me :smile: ) converts body string to array. So this issue is basically a reminder to fix it in the next release.
Actually symfony must return string for Request::getContent with $asResource = false input parameter but it did for under some conditions. I think it might be for empty body. Sadly I was in the middle of something when got the error and didn't make good notices what led to it.

I might accidentally passed an array as $content parameter to Request constructor and got the error. So there is no error at all probably. Just need to check a bit more.

I've found the reason. I passed the array myself during PhpUnit tests as a parameter to Symfony Request. Thus this issue cannot happen during production usage and can only be reproduced in tests.

Hi is there any clue to connect symfony with neomerx . Shall i directly implement it in api controller?

@nvshivakumar As far as I know @drewclauson did json-api integration bundle for Symfony


Auth fails if now ApiKey is provided

@Xenozite
Thanks for reporting this issue. It should be possible to connect even without an ApiKey (if allowed in the moonraker dashboard).
So this is a bug in 1.3.1-preview.

@Xenozite
Can you try one of those two methods? These are both methods to connect without an ApiKey. I have no running klipper printer on my side currently.
[Test]
public async Task BuildWitOneShotTokenAsync()
{
    try
    {
        client = new MoonrakerClient.MoonrakerConnectionBuilder()
            .WithName("Test")
            .WithServerAddress(_host, _port, _ssl)
            .Build();
        KlipperAccessTokenResult? token = await client.GetOneshotTokenAsync();

        client.OneShotToken = token?.Result ?? string.Empty;
        Assert.That(!string.IsNullOrEmpty(client.OneShotToken));

        KlipperMachineInfo? info = await client.GetMachineSystemInfoAsync();
        Assert.That(info is not null);
    }
    catch (Exception ex)
    {
        Assert.Fail(ex.Message);
    }
}

[Test]
public async Task BuildWitUserTokenAsync()
{
    try
    {
        client = new MoonrakerClient.MoonrakerConnectionBuilder()
            .WithName("Test")
            .WithServerAddress(_host, _port, _ssl)
            .Build();
        string? apiKey = await client.LoginUserForApiKeyAsync("user", "pwd");

        /*
         * Set by the LoginUserAsync() method
         * UserToken = queryResult?.Result?.Token ?? string.Empty;
         * RefreshToken = queryResult?.Result?.RefreshToken ?? string.Empty;
         */
        Assert.That(!string.IsNullOrEmpty(client.UserToken));
        Assert.That(!string.IsNullOrEmpty(client.RefreshToken));

        // This should be enough to authenticate.
        KlipperMachineInfo? info = await client.GetMachineSystemInfoAsync();
        Assert.That(info is not null);

        client.AuthHeaders.Clear();
        // Also try with the api key to verify
        client.ApiKey = apiKey ?? string.Empty;
        Assert.That(!string.IsNullOrEmpty(client.ApiKey));

        info = await client.GetMachineSystemInfoAsync();
        Assert.That(info is not null);
    }
    catch (Exception ex)
    {
        Assert.Fail(ex.Message);
    }
}

You see the tests here: https://github.com/AndreasReitberger/KlipperRestApiSharp/blob/ec459ed2f7a67645e3b5aac22d98d0e062c186bd/src/MoonrakerSharpWebApi.Test/MoonrakerSharpWebApi.Test.cs#L52
Thank you for helping out!


Fix bug at wait-ready-script

My last PR 720d21c6df83b85d8f038eee50469daf20b2ab03 introduced a bug.
Iteration goes from 0 to number, so it's ok to have the iterator addition at the beginning of the loop, and checking for number at the end.
Sorry for that!

I was wrong.
Last iteration is ok as it is already


[$250] [Group 3][Accessible Pressable] Migrate WorkspaceInitialPage

HOLD on https://github.com/Expensify/App/issues/16988
Description
Migrate WorkspaceInitialPage to use PressableWithoutFeedback
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0131b54ef3b915f78a
Upwork Job ID:<PHONE_NUMBER>453778432
Last Price Increase: 2023-06-06

Triggered auto assignment to @kadiealexander (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero process steps for feature requests for more details.

Can you assign me to this one?

Can you assign me to this one?

I want to work on it

Hi everyone 👋🏼
@Skalakid has a PR open for this here. The only payment that will be due is the C+ payment, and because these PRs are pretty simple we're going to start using a going rate of $250 for the C+ review, similar to what we're doing for functional component migrations and what we will do for the TypeScript migration.
Also, @muxriddinmuqimov77 @Vishrut19 for some additional context @Skalakid was hired separately and pre-approved to work on this issue. Most often, external contributors need to follow a different process to apply to work on our open-source jobs. That process is outlined in detail in our Contributing Guidelines.

@parasharrajat can you reviews the PR?

PR was merged, not overdue

PR is on staging, going to make this a weekly while we wait through the regression period.

Hired @parasharrajat

@parasharrajat are you running into issues accepting my offer in Upworks? I swear something is broken on their end...


Constructor Default Arguments

Summary
Currently the interpreter has no way to handle defaulted arguments to constructors. While they can be parsed, the way that constructors are currently evaluated and processed (statically) means that the default arguments never actually get applied.
Specification

Rework handling of constructors to return their results dynamically.
Ensure that defaulted constructor arguments actually work.
Matching is performed based on argument name rather than argument position, so if we have type Cons head rest, you can match Cons ~ { |rest, head| ... } and have it work properly.

Acceptance Criteria & Test Cases

Defaulted constructor arguments are functional.
They are well-tested.

The final portion of the specification has been decided against and will not be implemented.


Add Random Generator

Describe the issue (if no issue has been made)
This PR doesn't fix any issue.
This PR will add a new Random Generator as described below.
PR impact (Make sure to add closing keywords)
List of related issues/PRs this will solve:

Impact
Issue/PR

Issues this solves
None

Other PRs this solves
None

Proposed fix (Make sure you've read on how to contribute to Hazel)
This PR adds the following:

Random generator:

Adds RNG32 class which is a random generator.

Additional context
None.

How about taking a look at #225 first?

How about taking a look at #225 first?
I'm really sorry, for some reason I have overlooked the list and I didn't see that PR first.
I have just seen that PR and come back here to close this PR.

Close PR due to duplication with #225.


[MRG] Update pytest

This makes us update to the lastest pytest

Apparently I used fixtures in a bad way sometimes, which was still supported in old pytest versions but not anymore so I deleted fixtures and replaced them by regular functions when needed

Merged, thanks!


Add basic flag with text shown on hover

Federalist preview
This is a rough, first pass at #25 where I use the flag image that comes with the USWDS and show text on hover. It works well on large displays but needs work done to ensure it works on smaller displays.
Still to do:

[x] Use proper font (refs #26)
[ ] Use higher quality flag icon?
[x] Ensure the text is shown appropriately on smaller displays

@shawnbot I think this is ready to be merged. If we ultimately want to use a higher res flag icon that will be easy to do in the future.


[INLONG-2961][DataProxy] Check style error in DataProxy

Title Name: [INLONG-2961][DataProxy]Check style error in DataProxy
where XYZ should be replaced by the actual issue number.
Fixes #2961
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@ciscozhou there are some checkstyle errors for sort-standalone and tubemq, you can fix them with this PR.
TubeMQ

Sort

Sort-standalone

ok


Dockerhub is behind by 6 months

It would be great if dockerhub build was updated.

The Dockerhub container is 6 months old because the App hasn't really been updated in 6 months :-/  I have a series of changes occurring in the main MRtrix3 repository that will eventually need to be reflected in this App, but I've not been able to commit time to this App of late. Hopefully when I get back to completing the manuscript for this App I can add some outstanding things.
Regarding the original post:
Step 7/56 : RUN apt-key adv --recv-keys --keyserver pgp.mit.edu 2649A5A9
---> Running in e363055aeefa
Executing: /tmp/apt-key-gpghome.nB2rGV2iyT/gpg.1.sh --recv-keys --keyserver pgp.mit.edu 2649A5A9
gpg: keyserver receive failed: No data
The command '/bin/sh -c apt-key adv --recv-keys --keyserver pgp.mit.edu 2649A5A9' returned a non-zero code: 2

This unfortunately occurs sporadically, and is usally solved by just re-running the build. I saw a trick in another repository where they store the required key data in a file within the repository and import it into the container during the build process; I will likely use the same technique in the future.

Hmm, as far as I can tell, the last dockerhub build reports being a year old, not 6 months old.
The dockerfile available for viewing on dockerhub uses ubuntu 14.04. However, the dockerfile here: https://github.com/BIDS-Apps/MRtrix3_connectome/blob/master/Dockerfile is using ubuntu 18.

I'm not quite sure what's going on there. Both 0.3.0 and latest show as being 7 months old for me. But DockerHub doesn't seem to offer a great deal of control (at least from my account). I'll have a close look after pushing 0.4.0.

@dkp: Version 0.4.0 is now up on DockerHub. Changes described in #40.
It seems however that the Dockerfile showing on the DockerHub website is still out of date, i.e. is from an older version of the App, and I don't appear to have any control over that from within my DockerHub account. @chrisfilo: Have you encountered this previously? Any idea why the Dockerfile shown on the DockerHub website would not track the :latest tag?

I've pulled the image now and it updated a BUNCH of layers...(though I see a bunch of "failed" messages on dockerhub).  I've just told it to run with --debug mode on, and with --output_verbosity 3 but I am not sure what it is doing...I see no temp directory.  I tried running with --version and it did not return any info to the command line.
I'm new to this stuff, so my experiences are those of a novice.  Nevertheless, here are the problems I've dealt with getting dockerhub to behave :

I've had problems with the webhooks getting broken or corrupted (after I fooled around renaming and recreating the git repository on line).
AND I've had problems with the whole automated system producing corrupted builds of my project.  I had more success with manual builds like this:
push to the hub:

docker login (enter credentials)
docker tag bipbids diannepat/bipbids
docker push diannepat/bipbids


Revisit form layout

Currently, spacing between the login form header and body is created by a hidden error message. I think we need to revisit this approach because it's pretty fragile and relies on developers to limit text, etc. Also, other forms are going to require several different validation messages and this isn't reusable/scalable.

cc @matthewcarleton @mcarrano I believe this work was originally implemented in https://github.com/patternfly/patternfly-next/issues/1063

I agree with everything you are saying @mattnolting
From what I recall this was a difficult decision and came with some issues. Happy to be part of the discussion to push this along.

I know that this is a very controversial topic and the current approach was arrived at following multiple design iterations. We were getting lots of push back from certain product teams that complained about the way the login form would accordion when errors were reported so this was a compromise. Unless we have specific product feedback that says this is a problem, I'd like to not revisit this.
@LHinson FYI

@mcarrano, since you're looking for specific product feedback...
The assumption that every immediate child of .pf-c-form will be a .pf-c-form__group is very short sighted.  We have numerous forms in OpenShift where we need to insert nodes (e.g., a wrapping div) in to a form that are not simple form label/group combos (i.e., .pf-c-form__groups ).  The workaround we've identified is to insert a
 around .pf-c-form__groups that are nested in the inserted nodes.  This is far from ideal because the new
 should not be needed and is semantically poor (nested forms).  https://github.com/rhamilto/console/blob/3dad0870ceb6b882c79aa451367d19f056c4c02c/frontend/public/components/deploy-image.tsx#L330-L452 is an example of a form I started to migrate to PF4 when I identified this problem (note it did not merge as we identified it was going to be too much work to migrate all our forms prior to feature freeze and we did not want to ship two differently styled forms).  Further, spacing between form buttons is also dependent on .pf-c-form.  So in order to adopt PF4 buttons for use in our existing PF3 forms, we had to add .pf-c-form to .pf-c-form-group in order to get properly spaced buttons (e.g.,  https://github.com/sg00dwin/console/blob/a8dbd34060e5b4fac1d1d860281089f0020da7df/frontend/public/components/cluster-settings/basicauth-idp-form.tsx#L190).
cc: @spadgett, @alimobrem, @sg00dwin


Edge document w/o one vertex

Hi
After NEIGHBORS function returned following error:
Query: document not found (while executing)
I found out that our database has edge without one _to vertex:
[
{
"dstIntL2Name": "Et2/0",
"neiIp": "<IP_ADDRESS>",
"_id": "eCdp/3594035143268",
"_rev": "3594035143268",
"_key": "3594035143268",
"_from": "vIntL2/3593999950436",
"_to": "vIntL2/3551233647204"
}
]
_from vertex exists:
for i in vIntL2
filter i._id == "vIntL2/3593999950436"
return i
[
{
"name": "Et1/0",
"_id": "vIntL2/3593999950436",
"_rev": "3593999950436",
"_key": "3593999950436"
}
]
but _to vertex doesn't exists:
for i in vIntL2
filter i._id == "vIntL2/3551233647204"
return i
[]
Our app is quite complicated, so unfortunately I don't know how to replicate this.
Any ideas how this could happen or how to troubleshoot it?

When I tried to replace NEIGHBORS function with GRAPH_NEIGHBORS, then query doesn't throw error and _to vertex is in result null.
But similar to this issue #1543 (slow GRAPH_EDGE, which is fixed now), GRAPH_NEIGHBORS is not fixed and is slow as hell (compared to NEIGHBORS).
Here is query:
for dev in vertex
for srcIntL2 in NEIGHBORS(vDevice,eDevIntL2, dev, "outbound", [], {includeData: true})
for dstIntL2 in NEIGHBORS(vIntL2,eCdp,srcIntL2, "any", [], {includeData: true})
//for dstIntL2 in GRAPH_NEIGHBORS("network",srcIntL2, {direction : 'any', includeData: true, edgeCollectionRestriction: 'eCdp'})
return {srcIntL2, dstIntL2}
I running 2.8beta2 on Debian 8.

I can confirm NEIGHBORS could have thrown a document not found error in some cases. That should be fixed now (current 2.8 and devel).
That was caused by an edge pointing to a non-existing document. That an edge refers to a non-existing document may actually occur in practice. Edges are collections with special _from and _to attributes, which are mandatory to be filled in. When an edge is created, there will always be a check that the referenced collections do exist. However, there'll be no validation of whether the referenced documents exist. That means it is possible to create an edge that links non-existing documents from existing collections.
Additionally, when a (vertex) document gets deleted, any edges that reference it will not be affected. This may also cause edges pointing to non-existing documents.
In order to have additional checks enabled when creating or removing documents, the operations need to be performed via the general-graph module or API. This module provides operations that can e.g. remove a vertex from a graph, and will perform the required cross-checks. It has some overhead of course, as checking references is not for free.

Related (managed vs. unmanaged graphs):
http://stackoverflow.com/questions/26631854/aangodb-ghrarial-interface-vs-edges-documents#26632660

(we settled to call 'managed' named nowadays ;-)

I see, it's named and anonymous graphs now. (Un)managed would emphasize the fact that edges in anonymous graphs may have loose ends though.

Ok, thanks all for explanation, makes sense.
What about speed of GRAPH_NEIGHBORS function? Did you check it?

Also I was checking arangojs doc and it seems that there is no possibility to delete in named (managed) style delete vertex?

It seems that arangojs is indeed missing functionality for removing vertices and edges from a named (managed) graph.
There should be:

graphVertexCollection.remove(): this should be mapped to HTTP DELETE /_api/gharial/:graph/vertex/:collection/:key
graphEdgeCollection.remove(): this should mapped to HTTP DELETE /_api/gharial/:graph/edge/:collection/:key

GRAPH_NEIGHBORS is known to be slower than NEIGHBORS, for the following reasons:

NEIGHBORS() will use a single edge collection, which is known at query compile time, but GRAPH_NEIGHBORS may use an arbitrary number of collections, to be determined at runtime. That means it is more complex inside
NEIGHBORS() has a C++ implementation, but GRAPH_NEIGHBORS() does not. It will use V8 internally, which means there is the need to convert data when passing it into V8 and back. This conversion may be notable for bigger inputs or output values, or when called often (as in the 3-levels loops shown above).

Ok, thanks. Where possible, I will use C++ functions.
I just was wondering, because in my example query above the difference is really big. For small collection, NEI() speed was instantaneous, G_NEI() took about 20s. For larger collections where query with NEI() runs for longer (30s), then G_NEI() is unusable, after few minutes I stopped query.

@jsteemann they existed, but they're inherited from the (unmanaged) collection API, so they manipulate the collections directly rather than using the graph API.
That should be relatively trivial to fix. I've added an issue to arangojs.

Closing as progress on this is now tracked on the arangojs issue.


The lock icon doesn't auto display after acquiring lease for one ADLS Gen2 blob

Storage Explorer Version: 1.14.0-dev
Build: 20200521.3
Branch: master
Platform/OS: Windows 10/ Linux Ubuntu 16.04/ macOS Mojave
Architecture: ia32/x64
Regression From: Previous release (1.13.0)
Steps to reproduce:

Expand one ADLS Gen2 storage account -> Blob Containers.
Create a new blob container -> Upload one blob to it.
Acquire lease for this blob -> Check whether the lock icon auto displays or not.

Expect Experience:
The lock icon auto displays.
Actual Experience:
The lock icon doesn't auto display.
More Info:

The lock icon displays after manually refresh.
This issue also reproduces when breaking lease for one ADLS Gen2 blob.
This issue doesn't reproduce for one regular blob.

This issue is fixed on build master/20200522.4. So we close it.


update command

Does this make sense? Or would it be something best left to spm?

What about just using a second apo add for this? That would have to be smart enough anyways to check already installed package names and could overwrite in that case.


Question: All Done Event With Multiple

I am using this component to upload n files to an S3 bucket. I've checked the source code, and while I see an onFinish prop representing the completion of a single upload, I don't see a way to know when all files are completed (one way or another as errors may happen).
How would you suggest I do this?

@neilchaudhuri how did you resolved?

@neilchaudhuri how did you resolved?


Change ClientDeactivateThreshold Field to String Value in Protobuf

What this PR does / why we need it:
Change ClientDeactivateThreshold field to string value in protobuf.
This change is applied to ease client to see and update ClientDeactivateThreshold. Previous ClientDeactivateThreshold field was int64 value of nanoseconds, which made client hard to see and update field.
Which issue(s) this PR fixes:
No issue is related.
Special notes for your reviewer:
None.
Does this PR introduce a user-facing change?:
Adds ClientDeactivateThreshold update field in project settings

Additional documentation:

Checklist:

[x] Added relevant tests or not required
[x] Didn't break anything

With CLI added, I also added ClientDeactivateThreshold update field in dashboard's project settings.
Follow this PR: https://github.com/yorkie-team/dashboard/pull/107


keras.layers.experimental.preprocessing.Discretization fails for mixed precision training

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Databricks Runtime 7.3
TensorFlow installed from (source or binary):  binary
TensorFlow version (use command below): 2.3
Python version: 3
CUDA/cuDNN version: 10.1
GPU model and memory: AWS p3.xlarge

Describe the current behavior
keras.layers.experimental.preprocessing.Discretization fails when mixed precision is enabled
Errors:
TypeError: Value passed to parameter 'input' has DataType float16 not in list of allowed values: int32, int64, float32, float64
tensorflow/python/keras/layers/preprocessing/discretization.py in call(self, inputs)
     99           dense_shape=array_ops.identity(inputs.dense_shape))
    100     else:
--> 101       return math_ops._bucketize(inputs, boundaries=self.bins)  # pylint: disable=protected-access

raw_input = keras.Input(shape=1, name="raw_input")
boundaries = [0, 1, 2, 3]
discretization = keras.layers.experimental.preprocessing.Discretization(bins=boundaries)(raw_input)

This appears to come from tf.math.bucketize()
Describe the expected behavior
The replacement for TF Feature Columns should support mixed-precision training out of the box.
Standalone code to reproduce the issue
See above.
Other info / logs Include any logs or source code that would be helpful to
Work around:
raw_input = keras.Input(shape=1, name="raw_input")
boundaries = [0, 1, 2, 3]
discretization = keras.layers.experimental.preprocessing.Discretization(bins=boundaries, autocast=False)(raw_input)

However, I am having issues with serialization.

autocast doesn't appear to be serialized:
discretization.get_config()
Out[281]: {'name': 'discretization_5',
'trainable': True,
'dtype': {'class_name': 'Policy', 'config': {'name': 'mixed_float16'}},
'bins': ListWrapper([0, 1, 2, 3])}

To fix serialization, I just changed the code to:
  def call(self, floatx_inputs):
    import tensorflow.keras.backend as K

    inputs = K.cast(floatx_inputs, "float32")
 ....

/cc @tanzhenyu

@jeisinge,
Could you please install the latest TF-nightly version and check if you are facing the same issue. Thanks!

@amahendrakar It was reproducible I think you can route this forward

@jeisinge
Could you please try on latest version of tf and let us know if you still face the same issue.

I apologize for the delay.  I can confirm that this is no longer an issue with TF 2.4!  Thank you!


Newtonsoft.Json.JsonReaderException

I am aware of this issue and I'm working on a fix, it might take me some time because I'm very busy today and tomorrow

Fixed


update the image for the social network sharings

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind user-interface

/kind content

/kind translation

/kind event

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area blog

/area documentation

/area community

What this PR does / why we need it:
Update the image used when a link is shared on social networks
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 52a3cf477935de4284a80f74bb453802e7b1e369

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


First item is selected on enter

Hi,
First - thanks for the component! :-D
I want to use it as a search field - for example searching for countries (as in your example).
If I enter "s" I see 4 countries. If I don't select any item but only pressing enter I get Botswana.
Is there any way I can get the value "s" so that I can send the user to a more general search page listing all countries that contains "s"? If the user select a country I want to redirect him to the country page directly.
Is there any way to do this?

Hi @elhoo,
Thanks!
You are right first item shouldn't be selected on enter

Thanks @oferh!
I have updated my project and just want to say/confirm that it works!  👍


feat: improve error handling for log_metrics decorator

Issue #, if available:
Description of changes:

Change default behavior for log_metrics decorator: no longer throws exception if no metrics are emitted during the wrapped function's execution. Added parameter to revert this behavior if exception is desired in this case.

[X] Meet tenets criteria
[X] Update tests
[X] Update docs
[X] PR title follows conventional commit semantics

Breaking change checklist

Ignore if it's not a breaking change

RFC issue #:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #71 into develop will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           develop       #71   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           15        15
  Lines          508       510    +2
  Branches        48        49    +1
=========================================
+ Hits           508       510    +2

Impacted Files
Coverage Δ

aws_lambda_powertools/metrics/metrics.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 967d86e...42bb1a0. Read the comment docs.

I'm trying to think of an actual customer scenario where this would be common to have no validation by default - Could you share one or two use cases where you wouldn't have a metric if you want to use Metrics?
I thought about scenarios where metric value would be 0, but even then it's a data point rather than missing data point.

That’s fair enough - I thought you were also adding metrics on unhappy path
(my expectation).
I’m happy with the change - On my phone now, only change I’d request is to
use “raise_on...” rather than “raise_for...”
On Mon, 8 Jun 2020 at 17:37, Tom McCarthy<EMAIL_ADDRESS>wrote:

@cakepietoast commented on this pull request.
In aws_lambda_powertools/metrics/metrics.py
https://github.com/awslabs/aws-lambda-powertools-python/pull/71#discussion_r436842502
:

@@ -122,10 +131,13 @@ def decorate(event, context):
if capture_cold_start_metric:
self.__add_cold_start_metric(context=context)
finally:

           metrics = self.serialize_metric_set()

           self.clear_metrics()

           logger.debug("Publishing metrics", {"metrics": metrics})

           print(json.dumps(metrics))

           if not raise_for_empty_metrics and not self.metric_set:

I added it to the decorator rather than base because I think the behavior
should be different for the decorator.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/awslabs/aws-lambda-powertools-python/pull/71#discussion_r436842502,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZPQBAEJCOB6HNJILPIPETRVUHVFANCNFSM4NYPVZBQ
.

That’s fair enough - I thought you were also adding metrics on unhappy path (my expectation). I’m happy with the change - On my phone now, only change I’d request is to use “raise_on...” rather than “raise_for...”
Done!


Bump 21.05

Motivation for this change
Prepare for a pending release upgrade cycle to 21.05, update nix to 2.3.16.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Note that this is a fast-forward merge. github.com/NixOS/nixpkgs/release-21.05 == github.com/awakesecurity/nixpkgs/awake-21.05

I am so confused GitHub, why This branch cannot be rebased due to conflicts?


Add Go execution traces to Agent Flare

What does this PR do?

Add powerful Go execution traces to a flare.
Motivation

For troubleshooting perf issues.
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

kubectl exec datadog-agent-pvzzw -c agent -- agent flare --profile 30
kubectl cp -c agent datadog-agent-pvzzw:/tmp/datadog-agent-2024-05-16T01-16-19Z-off.zip /tmp/flare.zip
unzip -d /tmp /tmp/flare.zip

# There are *.trace files.
find /tmp/i-09df1e4674d40f561/profiles/ -name '*.trace'
/tmp/i-09df1e4674d40f561/profiles/core.trace
/tmp/i-09df1e4674d40f561/profiles/process.trace
/tmp/i-09df1e4674d40f561/profiles/system-probe.trace
/tmp/i-09df1e4674d40f561/profiles/trace.trace

go tool trace ~/Downloads/i-09df1e4674d40f561/profiles/core.trace
2024/05/16 10:43:24 Parsing trace...
2024/05/16 10:43:27 Splitting trace...
2024/05/16 10:43:32 Opening browser. Trace viewer is listening on http://<IP_ADDRESS>:58545

/merge


[Feature] getCldVideoUrl examples

Feature Request
Is your feature request related to a problem? Please describe.
Add examples to the getCldVideoUrl documentation page.
Describe the solution you'd like
Replicate all of the examples on CldVideoPlayer, but utilizing the URL construction function, passing it off to the native <video element.
See  getCldImageUrl for similar examples.

Hi, I'd like to work on this issue

Hi @colbyfayock! Shall I work on this?

sure!

@colbyfayock I believe only the basic usage and cropping&resizing example can be replicated from the CldVideoPlayer... As the other examples are specific to the video player... Let me know if I'm mistaken...
And where can I find the possible options that can be passed to getCldVideoUrl

You're right about the examples, perhaps you could add an additional example for a text overlay? should work similar to this: https://astro.cloudinary.dev/guides/text-overlays
getCldVideoUrl uses essentially the same API as the image version. it needs documentation though: https://astro.cloudinary.dev/cldimage/configuration