Running ng test fails with Uncaught ReferenceError: [TYPE_NAME] is not defined

Bug Report or Feature Request (mark with an x)
- [X] bug report -> please search issues before submitting
- [ ] feature request

Versions.
$ ng --version
    _                      _                 ____ _     ___
   / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
  / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
 / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
/_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
               |___/
@angular/cli: 1.0.0
node: 6.9.1
os: win32 x64
@angular/common: 4.0.0
@angular/compiler: 4.0.0
@angular/core: 4.0.0
@angular/forms: 4.0.0
@angular/http: 4.0.0
@angular/platform-browser: 4.0.0
@angular/platform-browser-dynamic: 4.0.0
@angular/router: 4.0.0
@angular/cli: 1.0.0
@angular/compiler-cli: 4.0.0

Windows 10
Repro steps.
Step 1
Run the following command
ng new myapp

Step 2
Add following file MyType.ts in the folder where the generate app.conponent.ts is located.
export class MyType {
    constructor(public id: string){}
}

Step 3
Modify app.conponent.ts so it looks like this:
import { Component, Input } from '@angular/core';
import { MyType } from "app/MyType";

@Component({
  selector: 'app-root',
  templateUrl: './app.component.html',
  styleUrls: ['./app.component.css']
})
export class AppComponent {
  title = 'app works!';

  private selectedId: string;
  @Input() set setSelectedId(myType: MyType | undefined) {
    if (product !== undefined) {
      this.selectedId = myType.id;
    }
    else {
      this.selectedId = myType;
    }
  }
}

Step 4
Run the following command
ng test

The log given by the failure.
Result:
$ ng test
25 03 2017 07:37:40.092:WARN [karma]: No captured browser, open http://localhost:9876/
25 03 2017 07:37:40.107:INFO [karma]: Karma v1.4.1 server started at http://<IP_ADDRESS>:9876/
25 03 2017 07:37:40.108:INFO [launcher]: Launching browser Chrome with unlimited concurrency
25 03 2017 07:37:40.185:INFO [launcher]: Starting browser Chrome
25 03 2017 07:37:41.275:INFO [Chrome 57.0.2987 (Windows 10 0.0.0)]: Connected on socket 9t52BW0h_NVdN1zYAAAA with id 31811334
Chrome 57.0.2987 (Windows 10 0.0.0) ERROR
  Uncaught ReferenceError: MyType_1 is not defined
  at webpack:///src/app/app.component.ts:13:43 <- src/test.ts:52770

Chrome 57.0.2987 (Windows 10 0.0.0) ERROR
  Uncaught ReferenceError: MyType_1 is not defined
  at webpack:///src/app/app.component.ts:13:43 <- src/test.ts:52770

Desired functionality.
I would like to to have the test being run :)
Mention any other details that might be useful.
App is working fine, so it seems to be only when running tests. I know that it worked in version 2.x of the cli and Im pretty sure it is related to the typescript version, where it worked with TS 2.0.x and not with TS 2.2.x.
Alto, it works if @Input is not used and app.component.ts looks this:
import { Component } from '@angular/core';
import { MyType } from "app/MyType";

@Component({
  selector: 'app-root',
  templateUrl: './app.component.html',
  styleUrls: ['./app.component.css']
})
export class AppComponent {
  title = 'app works!';

  private selectedId: string;
  set setSelectedId(myType: MyType | undefined) {
    if (product !== undefined) {
      this.selectedId = myType.id;
    }
    else {
      this.selectedId = myType;
    }
  }
}

Same issue here, it seems to be related to using typescript union types in method signatures, either @Input or constructor in my case

Further investigation leads me to the direction of metadata reflection combined with interface unions, however I'm still stumped on a solution

Another update. So I was able to find a temporary fix - in tsconfig.spec.json, change module to es2015 and target to es6. Mine looks like:
{
  "extends": "../tsconfig.json",
  "compilerOptions": {
    "outDir": "../out-tsc/spec",
    "module": "es2015",
    "target": "es6",
    "baseUrl": "",
    "types": [
      "jasmine",
      "node",
      "faker"
    ]
  },
  "files": [
    "test.ts"
  ],
  "include": [
    "**/*.spec.ts",
    "**/*.d.ts"
  ]
}

This does not fix the issue however, as switching to targeting es6 is obviously risky when runtime uses es5, and it also breaks the coverage reporter completely.

Same issue here. My testing matches yours in that it is caused by a combination of  @Input() with union types. The latest version of typescript that works for me is 2.1.4

My repro steps can repro this issue without using discriminated union types.

@IngvarKofoed the one in your description of the original issue? That has method signature set setSelectedId(myType: MyType | undefined). Unless you mean another repro?

@zakhenry Oh yea, totally did not see that, sorry :)

Getting the same issue here....
Updating tsconfig.spec.json as suggested by @zakhenry (module="es2015") does resolve the issue for running ng test.
However, this completely breaks code coverage collection (ng test --cc).
I've created a separate issue to track this bug: https://github.com/angular/angular-cli/issues/6142

Any solutions other than the suggested module change?

Using module="es2015" isn't a real fix for the problem at hand, your browser might understand ES2015 modules but tooling (like the code coverage karma reporter) might not support it. This resulted in @orazyto's #6142.
I don't have another solution myself to be honest, nor do I know if it's a problem with the CLI or with Typescript. @sumitarora will investigate.

I was able to replicate this issue outside of any angular-cli usage.
I have an angular application using webpack 2.5.1, typescript 2.3.2, and angular 4.1.0.   If I have an @Input() decorated property and put it in a type union with "| null", then the modules built by webpack end up producing this error because they aren't including the module for the primary object type in the union.
I don't have a minimal replication yet, but removing the "| null" causes the issue to go away.

@zakhenry @filipesilva I was just able to fix mine but doing something a bit crazy.  I realized that components where I have an object (ex: MyObj) as an @Input parameter type but where I don't use the type in the code in the module are the only modules giving me issues.  So I added a usage of the type in the module and the issues goes away.
So if you have 'MyObj' as the type for the @Input with null, try adding a protected method to the component that simply returns a new instance of that type.  Doesn't have to be called, just has to use the type.  Once I did that it worked again.
Example:
class MyComp {
   @Input() myObj: MyObj | null = null;

   protected _notCalled(): any {
      return new MyObj();
   }
}

Crazy hack I know, but it worked for me.

did anyone else find a real fix or any details on the underlying issue?

If this helps, here's what I debugged so far from this particular code:
import { MenuPositionX, MenuPositionY } from '@angular/material';

export class FooComponent {
  private _xPosition: MenuPositionX = 'after';
  ...
}

In an es2015 output with es6 target obviously it'll output a normal class declaration with the methods declared as:
...
constructor() {
  this._xPosition = 'after';
  ...
}

This is close to what production build would output, but as a function declaration:
function FooComponent() {
  this._xPosition = 'after';
  ...
}

But then this is what tsconfig.spec.json would generate with commonjs and es5:
__decorate([
    core_1.Input(),
    __metadata("design:type", Object),
    __metadata("design:paramtypes", [typeof (_b = typeof material_1.MenuPositionX !== "undefined" && material_1.MenuPositionX) === "function" && _b || Object])
], FooComponent.prototype, "xPosition", null);

This results in:
Chrome 61.0.3141 (Mac OS X 10.12.4) ERROR
  Uncaught ReferenceError: material_1 is not defined
  at http://localhost:9876/_karma_webpack_/main.bundle.js:4584

If I have to assume (with my limited TS compiler and Karma knowledge), this is the output of decorators from experimentalDecorators actually wanting to do a type check for MenuPositionX, but I don't think this information gets passed through Webpack to make sure that material_1 or @angular/material gets required by Webpack.
A configuration of es2015 and es5 (which I assume is just like production) returns this:
__decorate([
    __webpack_require__.i(__WEBPACK_IMPORTED_MODULE_0__angular_core__["c" /* Input */])(),
    __metadata("design:type", Object),
    __metadata("design:paramtypes", [typeof (_b = typeof MenuPositionX !== "undefined" && MenuPositionX) === "function" && _b || Object])
], FooComponent.prototype, "xPosition", null);

Notice how this __decorate call is different compared to when the type is actually imported in:
__decorate([
    __webpack_require__.i(__WEBPACK_IMPORTED_MODULE_0__angular_core__["_13" /* ViewChild */])('rawContent'),
    __metadata("design:type", typeof (_a = typeof __WEBPACK_IMPORTED_MODULE_0__angular_core__["m" /* ElementRef */] !== "undefined" && __WEBPACK_IMPORTED_MODULE_0__angular_core__["m" /* ElementRef */]) === "function" && _a || Object)
], BarComponent.prototype, "rawContent", void 0);

That's for a @ViewChild('rawContent') rawContent: ElementRef.
I'm assuming this has to do with how the logic on Webpack for tests when it comes to loading dependencies has to do with "if it's just loading a dependency for the type checks, don't"?

I am still running into this in quite a few places in our code.  Has anyone found a reported bug in webpack, typescript, or elsewhere that would fix this finally?

+1

@Brocco can you take a look?

We solved this by including our global scripts in the assets folder. We
then found we needed to register them with the CLI, karma.config, and
include them as an import in index.html.
We were struggling with these issues for a while, as we use global scripts
to handle environment specific variables n CI. When this story came out in
the docs https://github.com/angular/angular-cli/wiki/stories-global-scripts
I followed it to a tee, but found it didn't work. We still had to register
globals in index.html.
On Wed, Jul 5, 2017, 2:41 PM Allen<EMAIL_ADDRESS>wrote:

I am still running into this in quite a few places in our code. Has anyone
found a reported bug in webpack, typescript, or elsewhere that would fix
this finally?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/angular/angular-cli/issues/5651#issuecomment-313205626,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADQeYkJjYVnNXm4cN19SbFQ51EJJoc1dks5sK-blgaJpZM4Mo_V2
.

As of the most recent cli version 3, we found duplicate declarations having globals referenced in index.html,  karma.config and angular-cli.json. it appears the cli is in fact now bundling them. Removing them from the index and karma.config does the trick of removing the duplicate reference errors.

I had the same issue initially with ng test as was provided in the description. It was fixed by changing module and target to es2015 and es6 appropriately . But after upgrading to ng 5.x even this fix stopped working + JIT compilation stopped working with the same error as well...
The another workaround for me was assigning the type which causes this error to any variable before class definition. With this fix everything started working even with initial module=commonjs ad target=es5. Here is an example:
import {MyIssueService} from 'path_to_service';
[other imports]

const hack = MyIssueService;
export class ConsumerClass {
   constructor(private service: MyIssueService) {
   }
   ...
}

I had this problem not with the test but the main code itself when I upgraded from Angular 4.3.0 to 5.2.9 and Angular Material from 2.0.0-beta-2 to 5.2.4. The problem was an @Injected service inside a parent component.
export abstract class ParentComponent {
    constructor(@Inject(WhateverService) protected service: WhateverService,
            protected dialog: MatDialog, protected error: Error) { }
}

---

export class ChildComponent extends ParentComponent {
    constructor(service: WhateverService, dialog: MatDialog, error: Error) {
        super(service, dialog);
    }
}

That was giving the error:
ERROR Error: Uncaught (in promise): ReferenceError: material_1 is not defined
ReferenceError: material_1 is not defined

As wrong as it might look, it was working with the older versions.
Well, investigating the transpiled js, I saw that the material_1 was for the dialog and I spent hours in that parameter. Until I saw that if I put the MatDialog parameter first, the problem was transferred to the third parameter. That's when I realized that the problem was with the service. So the solution for me was to put the @Inject annotation into the ChildCompoment (which makes more sense).
export abstract class ParentComponent {
    constructor(protected service: WhateverService,
            protected dialog: MatDialog, protected error: Error) { }
}

---

export class ChildComponent extends ParentComponent {
    constructor(@Inject(WhateverService) service: WhateverService,
            dialog: MatDialog, error: Error) {
        super(service, dialog);
    }
}

And now it's working fine. Well, it might be a little unrelated to the issues you are reporting, but I hope it helps you to find the solution to your environment.

So the solution for me was to put the @Inject annotation into the ChildCompoment (which makes more sense).

Thanks to your reply, I found my bug: I accidently added an Inject() annotation in the constructor of an abstract base class for my components. Removing it solved this issue.

@kleber-swf YOU ARE MY HERO <3 Actually, putting @Injectable on top of the class with mixed @Inject/non-@Inject constructor solved the problem as well!

Hi guys,
I just found a workaround create a type alias type MyTypeOptional = MyType | undefined; and use it in the @Input , it should work.

I'm sorry, but we can't reproduce the problem following the instructions you provided.
Remember that we have a large number of issues to resolve, and have only a limited amount of time to reproduce your issue.
Short, explicit instructions make it much more likely we'll be able to reproduce the problem so we can fix it.
If the problem persists, please open a new issue following our submission guidelines.
A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.


Language bar in Chat stays empty

What happened?
Hi there ! I haven't been able to make this module work unfortunately.
With default settings.
Thanks for your help/fix,
Ugun

Reproduction Steps
Enable the polyglot module
Which game system, and which version, are you using?
DnD5 2.4.1
Which Polyglot version are you using?
2.4.6

Fixed with update of DnD5 to v3.1.0 :)


Make UITableView-compatible

There's no reason not to use DiffyTables on iOS.
Watch-specific code ought to be separated from the general algorithm itself.
Then, a UITableView(Controller) extension could be added to make this easy to work with.

I might want to tackle this at some point, but if someone is willing to do this work, I would gladly accept a PR


Fix stack overflow

I just got bitten by this today! Wish I had looked at the open PRs before trying to fix it myself. :-)


Service exited due to Segmentation fault: 11

Hi, I tried to create new app. Everything works fine, but now I got this strange error. I think there is no reason for this
My repository is here
https://github.com/b4rtt/app_template
Executing before-watch hook from /Users/roman/Desktop/HelloWorld/hooks/before-watch/nativescript-dev-typescript.js
Found peer TypeScript 2.1.6
objc[3912]: Class PLBuildVersion is implemented in both /Applications/Xcode-beta.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk/System/Library/PrivateFrameworks/AssetsLibraryServices.framework/AssetsLibraryServices (0x123717cc0) and /Applications/Xcode-beta.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk/System/Library/PrivateFrameworks/PhotoLibraryServices.framework/PhotoLibraryServices (0x12352e6f0). One of the two will be used. Which one is undefined.
1   0x109a3b7cb NativeScript::FFICallback<NativeScript::ObjCMethodCallback>::ffiClosureCallback(ffi_cif*, void*, void**, void*)
2   0x10a1101ee ffi_closure_unix64_inner
3   0x10a110b22 ffi_closure_unix64
4   0x10ae3410b -[UIViewController __viewWillAppear:]
5   0x10ae6d899 -[UINavigationController _startTransition:fromViewController:toViewController:]
6   0x10ae6e74b -[UINavigationController _startDeferredTransitionIfNeeded:]
7   0x10ae6f889 -[UINavigationController __viewWillLayoutSubviews]
8   0x10b061354 -[UILayoutContainerView layoutSubviews]
9   0x10ad4e6eb -[UIView(CALayerDelegate) layoutSublayersOfLayer:]
10  0x10fee6924 -[CALayer layoutSublayers]
11  0x10feda546 CA::Layer::layout_if_needed(CA::Transaction*)
12  0x10feda3c0 CA::Layer::layout_and_display_if_needed(CA::Transaction*)
13  0x10fe69eb2 CA::Context::commit_transaction(CA::Transaction*)
14  0x10fe96150 CA::Transaction::commit()
15  0x10fe96b57 CA::Transaction::observer_callback(__CFRunLoopObserver*, unsigned long, void*)
16  0x10d8c3717 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__
17  0x10d8c3687 __CFRunLoopDoObservers
18  0x10d8a8038 CFRunLoopRunSpecific
19  0x10ac8550f -[UIApplication _run]
20  0x10ac8b5b4 UIApplicationMain
21  0x10a11097d ffi_call_unix64
22  0x1275371e0
file:///app/tns_modules/@angular/compiler/./bundles/compiler.umd.js:14575:24: JS ERROR Error: Can't resolve all parameters for HomePage: (?).
Apr  3 15:55:30 Roman-MacBook-Air com.apple.CoreSimulator.SimDevice.AB4B81E5-D9EF-40EB-B3D9-CDACC149964A.launchd_sim[3768] (UIKitApplication:org.romansimr.HelloWorld[0x3be4][3790][3912]): Service exited due to Segmentation fault: 11
15:55:35 - Compilation complete. Watching for file changes.

@b4rtt the key is in Can't resolve all parameters for HomePage: (?).
The parameter that can not be resolved is the changeDetectorRef in your DrawerPage constructor (which you are using to extend HomePage). To overcome this limitation, you can simply provide the changeDetectorRef in the constructor in your extended HomePage class (which in my opinion should be named home-page.component so it will be obvious that we are working with an Angular component while the same is not valid for DrawerPage)
e.g.
home.page.ts
import { Component, ChangeDetectorRef, AfterViewInit } from "@angular/core";
import {DrawerPage} from "../drawer.page";

@Component({
    selector: 'home-page',
    templateUrl: './pages/home/home.page.html',
    styleUrls:  ['./pages/home/home.page.css'],
})

export class HomePageComponent extends DrawerPage implements AfterViewInit {
    constructor(private _changeDetectorRef: ChangeDetectorRef) {
        super();
    }

    ngAfterViewInit() {
        this._changeDetectorRef.detectChanges();
    }
}

while removing the changeDetector from your drawer-page
    constructor() {
        this.menu = false;
    }

    ngAfterViewInit() {
        this.drawer = this.drawerComponent.sideDrawer;
    }


Expired exposed constant should not be 0

Go defaults to 0 so in case we want to return EntryStatus (Expired) back to the caller; Expired cannot be differentiated.
@cristaloleg this is opened in line with comment on https://github.com/allegro/bigcache/pull/168

send PR https://github.com/allegro/bigcache/pull/181


Set Up examples for the wrappers.

Required Info

Camera Model
SR300

Operating System & Version
{Win (10)

Kernel Version (Linux Only)

Platform
PC.

SDK Version
2.10.1

Issue Description
Please provide examples using the wrappers, specifically for the .NET (C#) wrapper using this example:
https://github.com/IntelRealSense/librealsense/tree/master/examples/measure

[Realsense Customer Engineering Team Comment]
@eebanos
The issue is solved in 2.11.0 LibRS, please refer to the cs-tutorial-3-processing example inside the csharp wrapper folder.


#1139: Added support for srcset attribute

Coverage decreased (-0.01%) to 30.365% when pulling a1cbbde2c85702bb55582b20f25ea23031083618 on insideaem:feature/1139 into 6cfb82e8a1eacaa98f5e01ff1d1fcca796378019 on Adobe-Consulting-Services:master.

Coverage decreased (-0.01%) to 30.365% when pulling a1cbbde2c85702bb55582b20f25ea23031083618 on insideaem:feature/1139 into 6cfb82e8a1eacaa98f5e01ff1d1fcca796378019 on Adobe-Consulting-Services:master.

Coverage decreased (-0.01%) to 30.365% when pulling a1cbbde2c85702bb55582b20f25ea23031083618 on insideaem:feature/1139 into 6cfb82e8a1eacaa98f5e01ff1d1fcca796378019 on Adobe-Consulting-Services:master.

I think it would be better to generalize this as a configuration property which defines which attributes (following the same <element>:<attribute name> syntax as the attributes configuration property. The default can be img:srcset.
Please also add unit tests.

ok thanks for the feedback.
What about we introduce a new property matchingPatterns only for properties
where a simple pre-prend of host on the value would not work.
It would look like: matchingPatterns =
[::,::]
In the case of srcset:
matchingPatterns: [img:srcset: (.+.[jpg|png])] (Or whatever regex is
correct)
In the code we then do:
String matchingPattern = matchingPatterns.get(elementName+":"+attrName);
if(matchingPattern){
Pattern patt = Pattern.compile(matchingPattern);
Matcher m = patt.matcher(attrValue);
StringBuffer sb = new StringBuffer(attrValue.length());
while (m.find()) {
String url = m.group(1);
// prepend host
url = prependHostName(url);
m.appendReplacement(sb, Matcher.quoteReplacement(url));
}
m.appendTail(sb);
newAttrs.setValue(i, sb.toString());
}
else{
// do as currently...
}
Whta do you think?
On Tue, Oct 17, 2017 at 2:05 AM, justinedelson<EMAIL_ADDRESS>wrote:

I think it would be better to generalize this as a configuration property
which defines which attributes (following the same : syntax as the attributes configuration property. The default can be
img:srcset.
Please also add unit tests.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/1140#issuecomment-336880406,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFp9FnKi86MNGXofA8iikhtR4fO4x5Isks5ss1SQgaJpZM4P6EVS
.

--
Nono Junang
Technical Director
InsideAEM Limited
38 Waingaro Lane, RD 3
Kerikeri 0293
M +64 21 400 319
W www.insideaem.com

Conceptually I think this works, although it would be best to avoid doing recompilation of the regex. The compiled Pattern object should be stored in the map. Also, you can use StringBuilder there (but I know this is just pseudo-code).

Coverage increased (+0.1%) to 30.501% when pulling 5325ad808f3a0e31bdd57c2d5b4108b288d59d01 on insideaem:feature/1139 into 6cfb82e8a1eacaa98f5e01ff1d1fcca796378019 on Adobe-Consulting-Services:master.

ok.
Please review my changes and let me know if that works for you. I could not
use StringBuilder because the Matcher methods expect a StringBuffer.
Cheers,
On Tue, Oct 17, 2017 at 10:02 AM, justinedelson<EMAIL_ADDRESS>wrote:

Conceptually I think this works, although it would be best to avoid doing
recompilation of the regex. The compiled Pattern object should be stored
in the map. Also, you can use StringBuilder there (but I know this is
just pseudo-code).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/1140#issuecomment-337042250,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFp9FhJoepk_vNOlw3nGDGpUwIHSWw3Mks5ss8R8gaJpZM4P6EVS
.

--
Nono Junang
Technical Director
InsideAEM Limited
38 Waingaro Lane, RD 3
Kerikeri 0293
M +64 21 400 319
W www.insideaem.com

I made a few minor tweaks as well as ensure that the unit test also covers the regular img:src attribute. Thanks!

ok. Could you please point me to where to provide documentation for the additional property? Any idea when that code will be released? Will that be part of the 6.3 version as well?

if you can add documentation to https://github.com/Adobe-Consulting-Services/adobe-consulting-services.github.io/blob/master/_acs-aem-commons/features/utils-and-apis/static-reference-rewriter/index.md that would be great.
This will be in the 3.11.0 release which will be compatible with 6.2 and 6.3. I'm hopeful we'll do a release in the next week or so.

Any chance we can get this change for the 2.xxx version as well?

Any chance we can get this change for the 2.xxx version as well?

untested backported is in #1147


[feat] Add dbt osmosis utility to hub

Adds the dbt osmosis utility to meltano hub.
Checklist

[x] Add/update the file in the appropriate folder (/taps or /targets). The name of the file should match the name of the tap. If there is already one, add a descriptor to the name such as -search.
[x] Add/update the PNG logo image in /assets/logos/<taps or targets>. The image name must match the YAML file name.
[x] Tag @tayloramurphy or @pnadolny13 to flag it for review. Or post to the #hub channel on Meltano slack.

Reviewer Checklist

[x] Validate file against JSON Schema. https://www.jsonschema.net/home is an option.
[x] Build website locally and validate everything works.

@tayloramurphy @pnadolny13
Up for review!

@z3z1ma One last thing you just need to move your logo because the assets/logos/.. directory was migrated into static/assets/logos/... Then I should be able to test an add from my project just to verify its working as expected.

@pnadolny13
Got it, all done -- give it a whirl!


MultipartBody with Content-Type at the top, but not in the parts

I'm communicating with a server in an embedded device that doesn't have a robust server implementation.  I need to upload a multipart form with a file on it. It works fine from Google Chrome, but doesn't work using this client.
I've realized that the problem was because the server doesn't recognize the header Content-Type inside a Body Part. This is not that uncommon, as it's mentioned in #2604.
However, the workarounds present in there are of no use for me. They work by returning -1 in the contentLength method. If you do that, you also can't know the contentLength of the whole request.
If the contentLength of the whole request is unknown, instead of the Content-Length header the Transfer-Encoding: chunked header is used.
I want to have the Content-Length header at the top of the request, but don't want to have it inside a body part.
I've managed to solve this by rewriting the MultipartBody class, deleting the place where the Content-Length header is written. Since the most popular HTTP client in the world (Google Chrome) doesn't use this header, I thought it would be nice to upstream the change.
Here is my pull: https://github.com/square/okhttp/pull/7139

Please copy MultipartBody into your project and customize to taste.


Update collect-cluster-metrics.md

need extra whitespace before replicas: 2  or else invalid yaml

Proposed changes

Unreleased project version (optional)

Related issues (optional)

Deploy preview for docsdocker ready!
Built with commit 530076c6f70350693f6de02ec32063b45a74d728
https://deploy-preview-7857--docsdocker.netlify.com

LGTM


Integrate EAS

EAS has an SDK that we can leverage to see whether an address is a badgeholder or not. Here is the badgeholder schema that we will need to determine whether a user has voting privileges or not.
We will likely be using EAS to look at other schemas so we should make sure our methods are somewhat un-opinionated if possible.

@escottalexander did you have a particular reason to use the SDK instead of hitting the GraphQL API? It seems like the SDK is geared more toward writing attestations than querying them, and that the GraphQL API might be what we're looking for.

@swellander I assumed the SDK was for reading and writing. We most likely won’t be writing so feel free to use the GraphQL api if it is more straight forward.

@swellander Let me research this some more and get back to you.

Sounds good, thanks!

@escottalexander any word on this? Or should I just go with the graphql API?

@swellander I am adding the waiting tag to this because it is possible that this data will be accessed through a different API (Agora) but their API is not providing it yet. We will need to integrate with their API for other data too so might save some time if we just use them and forget about a direct EAS integration.

Got it, that sounds good :+1:


Don't use setTimeouts in loading flow.

Don't use setTimeouts in loading flow.
Solved traits initial T pose and glitches issue.

Re-targeted to new-ui-implementation branch and merged.


How to visualize the experiment result?

Thanks for easily understandable codes.
I have a question. After experiment, how to render agent  especially mujoco environment(Ant-Dir, ..)
please show me.
Thanks

This is actually not my codebase but a fork from https://github.com/tristandeleu/pytorch-maml-rl. Maybe I messed up the repo and it's not showing where this repo if forked from..


Add log index and tx hash to returned events of rest endpoints

closes https://github.com/trustlines-protocol/relay/issues/419?

This is actually too annoying to have it separate from https://github.com/trustlines-protocol/relay/pull/472 as they will conflict and I need this to test getting transfer details from event id.

Can you not just build 472 on top of this one?


A helpful scalars library

https://github.com/sanae10001/graphql-go-extension-scalars
@pavelnikolov Can i transfer the repository to graph-gophers?

@sanae10001 I don't think that this should be a separate project. You can add it to the /examples folder. However, it'd be better if you remove the external dependencies for the unit tests.

@pavelnikolov How do you use the extension scalars from the library https://github.com/sanae10001/graphql-go-extension-scalars with graphql-go? Can you guide me a little? Thanks

@pavelnikolov thanks for the info! But it's still not really clear to me how to make them register as a scalar in graphql-go


feat: Extended SQL expressions

Codecov Report
Attention: Patch coverage is 68.46847% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 84.86%. Comparing base (af33f88) to head (dc4a826).

Files
Patch %
Lines

server/src/lang/parser/mod.rs
58.33%
35 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   85.25%   84.86%   -0.40%
==========================================
  Files          24       25       +1
  Lines        4620     4697      +77
==========================================
+ Hits         3939     3986      +47
- Misses        681      711      +30

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


I want to communicate Kinesis webrtc datachannel to python, but kensis webrtc is not having any sdk in python, how to I do that, or is there any way to communicate C function where datachannel messages are incoming to python / C++ code ?

I am trying to develop a communication between Kinesis Webrtc and ROS. Hence I need to communicate the webrtc datachannel  with python/C++ node how do  I do that!

Unfortunately we are not able to provide guidance on specific implementation questions like this. At this time we do not have any python resources.


TC: Handle mutually recursive constant definitions, including cyclic imports

#419  is due to this.

Things to be done:

Handle mutually recursive definitions
Handle reassignment
Handle immutable reassignment (i.e. merges)


Fix issue 600

Better error message when parameter detector_size is missing.
Fix #600
Contributor Checklist:

[ ] I have added a changelog entry for my contribution
[x] I have added/updated test cases

is bugfix folder the right place to add changelog entry for this issue ?

is bugfix folder the right place to add changelog entry for this issue ?

Yes!

Added changes as requested.

Added changelog entry as you suggested.

If you like, you can also update your description in creators.json - you have by now done a bit more than just fixing issue 81!

Thx :) I will update in some other pull request.
Sorry for late reply, I'm having internal exam this week. I couldn't invest enough time as I thought of.

Added changelog entry as you suggested.

:+1:

Thx :) I will update in some other pull request.

Ok :+1:

Sorry for late reply, I'm having internal exam this week. I couldn't invest enough time as I thought of.

All okay! Thanks, will merge now!


Possible to share deployment guide?

hello,
Able to share the deployment guide?

Hi!
I just added the deployment guide to the readme. You need to create a developer account with Twitter and put in your credentials @ backend/data/twitter_stream.js in order to access their APIs.
You can create a Twitter developer account here: https://developer.twitter.com/en/apply-for-access

Hi!
I just added the deployment guide to the readme. You need to create a developer account with Twitter and put in your credentials @ backend/data/twitter_stream.js in order to access their APIs.
You can create a Twitter developer account here: https://developer.twitter.com/en/apply-for-access


ENH: Improve linking from user guide to API reference

It is useful to be able to quickly read the API reference when reading the user guide. Ideally, every type/function (basically anything generic in code fences) should be able to be linked to the API reference.
This is a bit of extra work but it really would help improve the usefulness of the guide. This would also in theory support showing inbounds links in the API guide as a "usage guide mentions" features. But that's not necessary for this to be useful.
As a start, this could be added to PR contribution guidelines/checklist link to API reference.
One challenge is how to deal with usage guide being sometimes language agnostic. So one may need to have multiple links, maybe like this:

pl.Duration [rs] [py]
hough this would be noisy. Or alternatively:
pl.Duration[rs]
where the default link could be Python.

One could also only use the more commonly used API (probably Python?) if the above is considered too noisy.

Hi!
The updated user guide should have this covered. In the tabbed code blocks there are links to the API documentation for each language separately.

Wow, the way this is implemented in the new guide is amazing. Well done! <3


feature request: crop tool-corner preview

When cropping a document and moving the handles, one cannot see the exact placement of the crop tool corners. A magnified preview that would appear in the opposite side of the screen related to the moved corner, which would show the precise positioning of the cropping boundaries would help tremendously.

Duplicate #25


fix ReplaceRenderer class. Method Parse, NullReferenceException

close #355

The original intention of the adjustment is that when the model attribute is assumed to be null after release, it is difficult to find obvious errors in the corresponding stack
System.NullReferenceException: Object reference not set to an instance of an object.
   at FluentEmail.Core.Defaults.ReplaceRenderer.Parse[T](String template, T model, Boolean isHtml)
   at FluentEmail.Core.Defaults.ReplaceRenderer.ParseAsync[T](String template, T model, Boolean isHtml)


Unrecognized prop in simple example

See:
https://github.com/marmelab/admin-on-rest/blob/f4872a37d50ef50ac40e06c4ee61a9f3353ce85f/example/comments.js#L140
This prop is not implemented in SimpleList

Fixed by #1535


External catalog tables not seen in Database Navigator when using Redshift Spectrum.

Redshift recently added support for querying external tables in AWS S3 as described by an external "Hive like" catalog that is serviced either by the AWS Athena Data Catalog Service (based on the Hive Metastore Service) or an actual Hive Metastore Service, like on an AWS EMR cluster.
When declaring an external schema in Redshift, the schema itself shows up as empty, but the external tables in the schema are not showing up in the "Database Navigator" in DBeaver.
I suspect DBeaver does not yet know how to query the contents of the Redshift external catalog to see the external tables.

Yes.
I'll need to setup S3 Athena to test/fix this.
Thanks for report.

This was fixed by the AWS Redshift JDBC driver release  <IP_ADDRESS>3 downloadable here: http://docs.aws.amazon.com/redshift/latest/mgmt/configure-jdbc-connection.html.  I've tested and am using the new driver in DBeaver EE v4.0.5.
The Redshift JDBC driver without the AWS SDK classes injected into the driver is the one you what to choose to use with DBeaver due to classloader conflicts.  I'm not using it, but I think you'll need to add the AWS SDK jar(s) to your classpath in the DBeaver Driver Manager in order to use IAM mediated authentication and SSO features introduced in another feature of this driver version.

Thank you for the information. Redshift driver version will be updated in 4.1.3


Adjust thread counts for compiles and tests

Adjust thread counts for compiles and tests to avoid under-utilization and congestion.
The free Github Actions VMs have 2 cores, the dedicated s390x VM has 4 cores.
This will hopefully shave off a little of the wait time for each PR to complete its CI runs.

Comparing compile time, there is some variance, but it seems most runs are about 20-30sec faster after this change.
When it comes to tests, the variance is much bigger, sometimes a full minute faster, sometimes 20sec slower. But it seems to average out to being the same or slightly faster. This is not a big surprise since running 6 parallel threads on 2 cores is going to make for a lot of contention, and reducing that to 3 threads is only freeing up the wasted time taken by doing all the extra context switching. The spurious big slowdowns are probably related to the VM contending with another VM for the use of the actual cpu cores, as there is nothing else here that would cause that.


Fixed wrong command line function.

The @go command is unrecognized, should be go.

Ty @maxmijn !!


Replace array iteration with standard for-loop to avoid producing garbage

Thanks for the great library

Great, thanks!


Small optimizations regarding coverage data

Current coverage is 100.00%

Merging #2 into master will not affect coverage as of 110076c

@@            master      #2   diff @@
======================================
  Files            4       4
  Stmts           68      68
  Branches         0       0
  Methods          0       0
======================================
  Hit             68      68
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of 110076c

Powered by Codecov. Updated on successful CI builds.

Merging and fixing later in 1 commit

Could you tag it once ready to ensure a new pypi version?


Make sure datetimes are timezone aware

Description

Fixes the issue that event list and event detail page times were mismatched. Also fixes the warnings in the tests about naive datetimes.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have added tests to cover my changes.
[ ] All new code is fully covered by tests (see coverage report)

The makeaware is only necessary in the tests because it gives naive datetime objects, when going through the actual form it automatically converts it to timezone aware objects I believe


some question occur while using two screen

Which operating system does the issue occur on?
arch linux
If on linux, are you using X11 or Wayland?
x11 and use nvidia

problem show in the gif, if i has two screen, some problem occured

this gif is screened in second screen

If I understand your issue correctly, it seems like your issue is the same as https://github.com/jwilm/alacritty/issues/1631.
If you have Rust installed, you can give #2438 a shot and let me know in #1631 if that helps.


Fixed #15165 -- Prevented wrong results with perimeter on geodetic field

buildbot, test on oracle

buildbot, test on oracle.

On Oracle:
Traceback (most recent call last):
  File "/mnt/jenkinsdata/workspace/pull-requests-oracle/database/oragis11/python/python3.5/django/test/testcases.py", line 1068, in skip_wrapper
    return test_func(*args, **kwargs)
  File "/mnt/jenkinsdata/workspace/pull-requests-oracle/database/oragis11/python/python3.5/tests/gis_tests/distapp/tests.py", line 697, in test_perimeter_geodetic
    list(CensusZipcode.objects.annotate(perim=Perimeter('poly')))
AssertionError: NotImplementedError not raised

If you have a local Oracle instance, could you test and report the result of CensusZipcode.objects.annotate(perim=Perimeter('poly'))[0].perim in that test ? I'd like to be sure Oracle behaves like other backends.

Not on my laptop, I'll do it when I return home on the weekend if still needed.

@jtiai Maybe you can check that?

@claudep sure, I'll check it when I get back from my vacation.

On Oracle: "18406.3818954314 m"

@jtiai could you advise if we should use the Oracle specific value here?

Yes. It's geographical distance which is due different triangulation algorithms. Relative error between those two values is about 0.011 %

Claude, if you can advise what should be done about Oracle, I can finish it up if needed.

The assertion should probably simply made more permissive, as we cannot do anything about the precision difference.

I understand that part, the issue is that Oracle doesn't raise NotImplementedError as described in a comment above. Do we need to add a Perimeter.as_oracle() method which does that?

Sorry. Based on your input, it seems Oracle might support proper calculating a perimeter on geodetic coordinates, right? Then if we don't want to special-case Oracle explicitly in the test, we might add a gis db feature for that.

How does this look? http://dpaste.com/0WDK5X5

Looks good. If tests are happy with that, so am I!

Great, I applied my patch in https://github.com/django/django/pull/5901 to verify tests.


Removed references to username in AssumeRole

username isn't used for that message anymore. I'm leaving it in the
message definition in case there are any potential compatibility issues
with old clients/new servers, etc.
Fixes https://github.com/AdRoll/hologram/issues/32

LGTM


Refactor internal error handling to use exceptions

Extracted the exception based error handling from #48 and put it in this separate PR.
Disclaimer: I didn't run any tests on this other than that it compiles (I don't have a hardware device)

@daniel-j-h: Ok, I

made error.hpp and error lower case
changed to unqualified includes
changed the error translation a bit

I did not incorporate the rest of your feedback and am waiting for your responses to my comments instead. I'm not sure, why git marks them all as outdated

Rebased onto master

Rebased on master and rewrote error handling in win/serial.cc to use exceptions

So ist there any chance this will get merged in the near future?

Yes, please excuse my inactivity I'm out until late next week. Maybe
@dcyoung can jump in here - otherwise you will have to wait a bit. I
want to get us to switch to exceptions and references for sure.
On 03/05/2017 12:08 AM, MikeGitb wrote:

So ist there any chance this will get merged in the near future?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/scanse/sweep-sdk/pull/59#issuecomment-284191550, or
mute the thread
https://github.com/notifications/unsubscribe-auth/AAgLiYC1yaPcQRpsUymHY9bNDE0_xZb-ks5rie71gaJpZM4MFTU8.

No rush. Main question is, if you are OK with the general structure of this PR as it is now.

Closing this for now - I think after the last round of changes a merge is no longer possible. I won't delete the branch though, as parts might be salvageable for future PRs


How to close client pool ?

import (
    "github.com/go-mysql-org/go-mysql/client"
)

pool := client.NewPool(log.Debugf, 100, 400, 5, "<IP_ADDRESS>:3306", `root`, ``, `test`)
// ...
conn, _ := pool.GetConn(ctx)
defer pool.PutConn(conn)

conn.Execute() / conn.Begin() / etc...

In some usecases, we want to close the pool and also close the underlying mysql connections to avoid resource leaks, but I didn't find a method like pool.Close to implement it.

yes currently we don't have this feature. You can open a PR to implement it


save  button

1-
The save  button doesn't bring back the main screen
2-
the reload choice tacks time, so reopening it is more effective.

Can I solve it?


No default settings file

@femtotrader - Now that the majority of the qstrader source lives under the /qstrader directory, we need to include a default settings.py in order for the strategies to "work out of the box".
I'm not too sure of the changes to the codebase as of yet (I'm still working through them), so I was wondering if you'd be happy adding a Pull Request with a default settings file?

Ahhh...I see it is actually in qstrader/settings.py. I'm just having some trouble running the strategy test code again. I'll try and sort this out.

When I run "strategy_backtest.py" I receive this traceback:
Traceback (most recent call last):
  File "examples/strategy_backtest.py", line 68, in <module>
    main(settings.DEFAULT, testing=False)
  File "examples/strategy_backtest.py", line 28, in main
    csv_dir, events_queue, tickers
  File "/home/mhallsmoore/venv/qstrader/lib/python3.4/site-packages/qstrader-0.0.1-py3.4.egg/qstrader/price_handler/price_handler.py", line 59, in __init__
  File "/home/mhallsmoore/venv/qstrader/lib/python3.4/site-packages/qstrader-0.0.1-py3.4.egg/qstrader/price_handler/price_handler.py", line 84, in _merge_sort_ticker_data
  File "/home/mhallsmoore/venv/qstrader/lib/python3.4/site-packages/pandas/tools/merge.py", line 812, in concat
    copy=copy)
  File "/home/mhallsmoore/venv/qstrader/lib/python3.4/site-packages/pandas/tools/merge.py", line 845, in __init__
    raise ValueError('No objects to concatenate')
ValueError: No objects to concatenate```

The problem, as far as I can tell is that in qstrader/settings.py, the SettingsDefault is correctly coded, but somehow even when I modify this file locally the _CSV_DATA_DIR attribute is not changing, as if it's being cached somewhere else.

Any ideas, @femtotrader? Is there something I'm missing about how you've restructured the code?

Cheers,

Mike.

You just need to
from qstrader import settings

config = settings.DEFAULT is default settings

config = settings.TEST is settings for continuous integration

they all have a CSV_DATA_DIR attribute and a OUTPUT_DIR attribute
You can bypass default settings by defining 2 environment variables:
QSTRADER_CSV_DATA_DIR and QSTRADER_OUTPUT_DIR
You can also create your own (inherited configuration class)
class SettingsUserdefined(SettingsDefault):
    _CSV_DATA_DIR = "~/data"
    _OUTPUT_DIR = "~/qstrader"

conf = SettingsUserdefined()

so that ~ is automatically expanded...

If you create a ~/data directory with data inside and an empty ~/qstrader directory
you shouldn't get any issue.

Great - I'll take a look at this over the next few days and write some more up to date documentation for the README.md. I'll also have a look through getting it put into a package, at which point the installation docs will be a lot clearer.

Good idea.

I had 2 requirements pyyaml http://pyyaml.org/wiki/PyYAMLDocumentation to parse this kind of file and Munch it's a dot accessible dict https://github.com/Infinidat/munch
so you access key of a dict like attribute of an object... a very convenient library !

Maybe we can close this


fix: do not overwrite release chart step

Signed-off-by: ankitm123<EMAIL_ADDRESS>

/approve

/approve


feat: add magic signer

this is a work in progress - pls don't review seriously yet :)

Wait I thought we were gonna build directly into aa-sdk rather than a staging repo?

yes, just sandboxing for our disucssion first


RabbitMQ should support running with "rabbit@IP" long-name

We are running RabbitMQ on Kubernetes. For clustering I tried rabbitmq-autocluster plugin with Etcd2. It would be great if Erlang distribution directly used IP. The latest discussion about this topic I found is http://lists.rabbitmq.com/pipermail/rabbitmq-discuss/2009-December/005650.html
Based on that I came up with:
sed -i  '/RABBITMQ_USE_LONGNAME/iRABBITMQ_NODENAME="$RABBITMQ_NODENAME -name test$$@${RABBITMQ_NODENAME##*@}"'  /usr/lib/rabbitmq/lib/rabbitmq_server-${RABBITMQ_VERSION}/sbin/rabbitmqctl ; sed -i '/start_rabbitmq_server() {/iRABBITMQ_NAME_TYPE="-name"' /usr/lib/rabbitmq/lib/rabbitmq_server-${RABBITMQ_VERSION}/sbin/rabbitmq-server
then I also do export RABBITMQ_NODENAME="rabbit@$(hostname -i)" before starting "rabbitmq-server". (Note that I don't set RABBITMQ_USE_LONGNAME at all, with it it doesn't work)
With RabbitMQ 3.6.0 that trick worked fine, but not in later 3.6 versions. I can workaround by using rabbit_cli.beam from 3.6.0 with a later version. This hack is in use for development but I wouldn't really dare to run it in production.
I believe https://github.com/rabbitmq/rabbitmq-server/blob/master/src/rabbit_cli.erl#L183 is not really fine. What I mean is: i'd expect when RABBITMQ_NODENAME and RABBITMQ_USE_LONGNAME are set, RabbitMQ should use those settings. If RABBITMQ_NODENAME is not set or not a FQDN it can still fall back to old logic.
In my case I don't really want to use DNS for inter-cluster communication, but as far as I understand it also wouldn't work if I did (due to the ".no-domain" addendum).
Thanks for your help.

Err, i wanted to submit this to rabbitmq of course, sorry about the mistake. Just a cross-link if anyone will find it interesting https://github.com/rabbitmq/rabbitmq-server/issues/1182


begin_left and end_right should change active column

Currently, begin_left and end_right don't change active column. That is, suppose the first column is active, press Shift-End and the last column is displayed, but the active column is still the first one, then press left and nothing happens (counter-intuitively!). I expected that the last -1 column would be active.
Is it possible to change this behavior or introduce new commands which scroll to beginning/end of line and set first/last column to be active?

I will consider.
This has concerns about the behavior when it starts or ends with a delimiter
and when the columns are misaligned.

Implemented. thank you.


Remove commented-out code and hints

…dable code

Breaking change

Proposed change

Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New integration (thank you!)
[ ] New feature (which adds functionality to an existing integration)
[ ] Deprecation (breaking change to happen in the future)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

[ ] The code change is tested and works locally.
[ ] Local tests pass. Your PR cannot be merged unless tests pass
[ ] There is no commented out code in this PR.
[ ] I have followed the development checklist
[ ] I have followed the perfect PR recommendations
[ ] The code has been formatted using Black (black --fast homeassistant tests)
[ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
[ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

[ ] I have reviewed two other open pull requests in this repository.

Description:
Codesmell:Remove commented-out code and hints, replace code hints with more readable code
Motivation: Removing the commented-out code improves code quality by eliminating redundancy and clutter. It ensures that the code remains clean, concise, and easier to read, fostering a more efficient and maintainable codebase. To make things simpler i have removed the commented-out code .

looks good


RHOAIENG-3783 - Fix codeflare sdk tests

RHOAIENG-3783

Added scripts for python 3.9 Virtual environment setup for codeflare-sdk python tests
Updated the Go tests to CodeFlare SDK python tests
Add the SDK authentication test

@jiripetrlik @sutaakar While testing in CI noticed below error in tear down at  step
13:12:12  Component codeflare state was set to Removed
13:12:12  Component ray state was set to Removed
13:12:12  ./ods_ci/tests/Resources/Page/DistributedWorkloads/cleanup_python_virtual_env.sh: line 19: sudo: command not found
13:12:12  Virtual environment venv3.9 deleted successfully.

Is there any other approach i can use here , without sudo permission denied error throwing

Is there any other approach i can use here , without sudo permission denied error throwing

No idea

@jiripetrlik @sutaakar While testing in CI noticed below error in tear down at step
13:12:12  Component codeflare state was set to Removed
13:12:12  Component ray state was set to Removed
13:12:12  ./ods_ci/tests/Resources/Page/DistributedWorkloads/cleanup_python_virtual_env.sh: line 19: sudo: command not found
13:12:12  Virtual environment venv3.9 deleted successfully.

Is there any other approach i can use here , without sudo permission denied error throwing

still need to figure it out for uninstall python error in CI.. Will it make sense to remove only python virtual environment?

Tests were working fine against the main branch after this changes TokenAuthentication in codeflare-sdk oauth tests.. Since we are testing with latest tag , i think we need to wait until latest codeflare-sdk new release to merge this PR

Tests were working fine against the main branch after this changes TokenAuthentication in codeflare-sdk oauth tests.. Since we are testing with latest tag , i think we need to wait until latest codeflare-sdk new release to merge this PR

@jiripetrlik @sutaakar Modify the tests to run against main branch and created a RHOAIENG-5070 to track to update to run tests against latest tag


Set RAILS_LOG_TO_STDOUT to true/1

What happened?

What were you attempting to do?

Build a rails app that sends logs to stdout

What did you expect to happen?

I expected RAILS_LOG_TO_STDOUT to be enabled so that our environment config could pick it up and use it to set the appropriate logger to direct logs to stdout for the container

What was the actual behavior? Please provide log output, if possible.

It is not enabled, the logs were directed to a file
Build Configuration

What platform (pack, kpack, tekton buildpacks plugin, etc.) are you
using? Please include a version.

What buildpacks are you using? Please include versions.

What builder are you using? If custom, can you provide the output from pack inspect-builder <builder>?

Can you provide a sample app or relevant configuration (buildpack.yml,
nginx.conf, etc.)?

Checklist

[ ] I have included log output.
[ ] The log output includes an error message.
[ ] I have included steps for reproduction.

@genevieve @paketo-buildpacks/ruby-maintainers This has been open for a bit. Is this still a need? Is there a workaround available?

Its not a bug. Its a feature request. Users routinely need to set this environment variable so that they can have their logs streamed to stdout in the container rather than the default location of a file inside the container. The workaround is just to set that environment variable when starting the container, but they shouldn't need to as having the buildpack set it by default would be pretty obviously better.

Makes sense.
Until the buildpack sets this environment variable, users can get this behaviour today by setting BPE_RAILS_LOG_TO_STDOUT=true in the build environment. This would ensure that RAILS_LOG_TO_STDOUT=true automatically when the container starts (see docs).

@robdimsdale I think this logic would go into the rails-assets buildpack. Its the most closely related, if not completely aligned with the intent of this feature.
We'll want to set this variable as a default using https://pkg.go.dev/github.com/paketo-buildpacks/packit/v2#Environment.Default. This would allow users to still override this value if needed.

I'm probably not going to get to this just yet, so anyone else who is interested is welcome to pick it up!


Improve README

This is my attempt at attempting to improve the README a bit since there were grammatical and spelling mistakes.
I've rewritten a good chunk of it, but I couldn't really understand some parts so let me know if I wrote some stuff wrong related to FlxAnimate

Why does everyone in the world do this?

Why does everyone in the world do this?

Do what, wdym?

You should change some of that stuff, but either way it looks good to me!

Just pushed a commit changing stuff like you asked to

Seems good to me!
I'll merge the pull request.
If you have more PRs to make, feel free to do them, I'll gladly look if it's for FlxAnimate's interest to take lol


Feature/14

Describe changes
Describe a summary of the changes and the related issue to communicate to the maintainers why we should accept this pull request.
Issue number or link
Types of changes
What is the type of code change?
Put an x in the boxes that apply

[ ] Bugfix (changes that resolve errors)
[x] New feature (changes which adds functionality)
[ ] Breaking change (big changes that affect existing functionality)
[ ] Documentation Update

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the "README.md"
[x] My code follows the style guidelines of this project
[x] My changes generate no new warnings
[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation
[x] Any dependent changes have been merged and published in downstream modules

Further comments
Please let me know if there's anything else to explain

Hmm...the changes are all fine, not causing any error, working perfectly well as I mean. LGTM!
But sonarcloud says it's not. I'm merging anyway. I hope it won't be trouble.


Upsert: add field renaming

~For example, an enterprise gdb in postgres stores length as st_length(shape) while AGOL stores it as Shape__Length (note double underscore).~
Edit: geometry was a red herring. Still, adding field mapper to allow field renaming if needed.

These are auto generated and should not be updated explicitly. I'm not sure they will let you update them explicitly. I think they can safely be ignored completely and the feature service will manage them.

hmm, I'll have to test. It makes sense that they're auto-generated, but previous file gdb to AGOL updates have worked the shape/area fields included... I wonder if it's just ignoring them. Time to test.

What was the result of those tests?

I've only ever really worked with palletjack on point data. There are a lot more considerations for polygon data, and I also need to add some sanity checks for projections. The field renaming may still be useful, so I pushed that through on its own.


Training code

Hi, I really appreciate your work. I wonder if the training code is available

Hi, I really appreciate your work. I wonder if the training code is available

Thanks for your interest, we are cleaning up the training code and expect to officially release it after the ECCV Rebuttal.

Hi, I really appreciate your work. I wonder if the training code is available

Thank you for your attention, we are cleaning up the training code and expect to officially release it after the paper is accepted.

Thank you for your great work, and how long will it take to release the full code. Approximate time when the paper will be accepted？

Thank you for your great work, and how long will it take to release the full code. Approximate time when the paper will be accepted？

Thanks for your interest, we expect to release the full code by the end of May

@liming-ai any update about releasing the training code?

Thanks for your great work, I wonder when will the training code be released?

Hi @trouble-maker007 @yyrui,
I  will open the training code after this paper be accepted. If all goes well, we will open source it at the end of this month

Hi @yyrui @trouble-maker007 @liwenyang-911 @WangYuXuan2022
Now we have released the training, evaluation code. Please refer to the implementation.


[Rancher2] Add note to v2.5 and v2.6 rollbacks docs clarifying that UI will be unavailable during the process

Request Summary:
Add note to both the v2.5 and v2.6 rollbacks docs clarifying that the UI will be unavailable until the rollback process is completed. This is because scaling the rancher deployment pod down to 0 will result in both Rancher and its UI to not be in a running state.
https://rancher.com/docs/rancher/v2.5/en/installation/install-rancher-on-k8s/rollbacks/
https://rancher.com/docs/rancher/v2.6/en/installation/install-rancher-on-k8s/rollbacks/
Details:
cc @flrichar

Since the UI is not available, you need to use the original cluster kubeconfig (since rancher pods are unavailable to authenticate you) with the restore yaml file.  I copied the Restore yaml before scaling down the Rancher pods, then edited the yaml to give a value to metadata.name, then ran:
kubectl apply -f restore.yaml

It might be better as an enhancement if the restore operator scaled down the Rancher pods for you, then did the restore.

It might be better as an enhancement if the restore operator scaled down the Rancher pods for you, then did the restore.

@wpwoodjr I'd recommend filing an issue in rancher/rancher. Feel free to tag me in a comment for it.


CentauriDreams

First netkan created by new automated script
hand verified

closes #4309

Looks good to me. Merging with thanks!


[feature request] add support for unicode identifier for variable name

I wanna be able to do stuff like
💬 'OK OK OK', 'god dammit', 23
📡 = require'satellite'

in no way is this an incredibly important or helpful idea, but i would be happy to use it if it existed.

Added unicode identifier support for variable names, table indexing, goto labels, macro names and other syntax that can be possible via commit e61cce21ef7def2c2e52dd6cb6a5b540ebcac29d.
The code
💬 = print
💬 'OK OK OK', 'god dammit', 23
📡 = require'satellite'

will be compiled to:
local _ud83d_udcac = print
_ud83d_udcac('OK OK OK', 'god dammit', 23)
local _ud83d_udce1 = require('satellite')

And that will leave a problem when you are using unicode names for global variables:
global 🌛 = "moon"
assert _G.🌛 == 🌛, "can not access this global variable with the unicode name"

compiles:
_ud83c_udf1b = "moon"
return assert(_G["🌛"] == _ud83c_udf1b, "can not access this global variable with the unicode name")


Avoid sanitization in some fields

There is a way to avoid sanitization in some fields?
I'm interested on sanitization to parse date strings into date object(otherwise, validation fails), but at the same time i don't want to sanitize other fields. I want them to fail.

Hi @YagoQuinoy
Can you give me an example?

Let's see this example:
exports.index = function(req, res) {
  var parsedUrl = url.parse(req.url);
  var queryObj = queryString.parse(parsedUrl.query);
  var search = JSON.parse(queryObj.q);

  var sanitized = inspector.sanitize(searchSchema, search); // Example: ISODate Strings parsed into Date due to type sanitization.
  var result = inspector.validate(searchSchema, sanitized); // If more data is wrong, search is not valid.

  if (!result.valid) {
    console.log(result.format());
    return handleError(res, new Error('Very bad!'));
  }

  return res.status(200).json({
    message: 'Everything is fine'
  });
}

I found a solution for tis example using the 'pattern' option.

Ok I see, what you can do is to use 2 different schemas, one for the sanitization and one for the validation. This is how I always do.
The pattern option is one solution too yes!

That's a nice solution! It would be nice that you could add those kind of tips at the documentation.

I will, than you @YagoQuinoy!


Update Systems collection

Removing physical systems from system collection
Updating computer system unit tests to get new system collection data
Closes: https://github.com/HewlettPackard/oneview-redfish-toolkit/issues/295

All comments were fixed on last commit. Please, check them @sidneifranco @ricardogpsf @adriane-cardozo


Revert Node 18.14 -> 18.13

Reverts https://github.com/kamilkisiela/graphql-hive/commit/dea5cbedd570346da9dab4aa84af93b8caf35cb5

@kamilkisiela should we close this one? I think the issue was Yoga+fastify?


Can't use session.Mouse.ContextClick()

I am trying to perform a right click on my application and I can't find anything in the samples that show how to do this except for session.Mouse.ContextClick(). Visual Studio lets me know that this is deprecated, but there isn't any other documentation on how to use this. Is there something I'm missing?
I do see that there is a message to use Action or the ActionBuilder class. How do I use these?

This is not depreciated.  How this works is that you need to specify the element as a parameter like so:
session.Mouse.ContextClick(element.Coordiantes);
By default, WinAppDriver is binded to find the coordinates by querying the inspection of UI elements in the session (the app you are testing).


Search $PATH for nvim

use builtin find executable to obviate the need for hard coded path to nvim binary.

closes #2


restAsync in a loop

Hi @osiset
I'm trying to create/delete multiple webhooks,
I tried doing it like this where $webhook is the webhook id but it take a bit long time (about 4-5 seconds)
        foreach ($webhooks as $webhook) {
            $delete[] = $this->shopify->rest('DELETE', '/admin/webhooks/' . $webhook . '.json');
        }

I tried to do it like this thinking that by doing that i will be able to do multiple requests at the same time but it didn't work at all even with single webhook without loop
        foreach ($webhooks as $webhook) {
            $delete[] = $this->shopify->restAsync('DELETE', '/admin/webhooks/' . $webhook . '.json');
        }

I tried using the following function to create 11 webhooks and it only takes around 800ms to finish but using Basic-Shopify-API it takes over 5-9 seconds to create all webhooks if i did that by adding the "rest" method inside a loop.
    public function registerWebhooks()
    {
        $topics = [
            'customers/create',
            'customers/update',
            'checkouts/create',
            'checkouts/update',
            'orders/create',
            'collections/create',
            'collections/update',
            'products/create',
            'products/update',
            'products/delete',
            'app/uninstalled'
        ];

        foreach ($topics as $topic) {
            $params[] = [
                'webhook' => [
                    'topic'   => $topic,
                    'address' => SRC_PATH . 'includes1/webhook_handler.php',
                    'format'  => 'json'
                ]
            ];
        }

        $url = 'https://' . $this->shop . '/admin/api/2020-04/webhooks.json';

        $headers = array(
            'Content-Type:application/json',
            'X-Shopify-Access-Token:' . $this->token
        );

        $curly = array();
        // data to be returned
        $result = array();

        $mh = curl_multi_init();
        foreach ($params as $id => $d) {
            $json_params = json_encode($d);
            $curly[$id]  = curl_init();
            curl_setopt($curly[$id], CURLOPT_URL, $url);
            curl_setopt($curly[$id], CURLOPT_HTTPHEADER, $headers);
            curl_setopt($curly[$id], CURLOPT_RETURNTRANSFER, 1);
            curl_setopt($curly[$id], CURLOPT_POST, 1);
            curl_setopt($curly[$id], CURLOPT_POSTFIELDS, $json_params);
            curl_setopt($curly[$id], CURLOPT_CUSTOMREQUEST, 'POST');
            curl_multi_add_handle($mh, $curly[$id]);
        }
        $running = null;
        do {
            curl_multi_exec($mh, $running);
        } while ($running > 0);

        foreach ($curly as $id => $c) {
            $result[$id] = json_decode(curl_multi_getcontent($c));
            curl_multi_remove_handle($mh, $c);
        }
        curl_multi_close($mh);

        $settingModel = new SettingModel($this->shop);
        $settingModel->sync = 1;
        $settingModel->storeSync();

        return $result;
    }

So i was wondering if there is a good way to achieve a similar performance using this library.
Thank you

It's probably the rate limiter kicking in my first guess. I'm not sure what I can do besides have an option to turn off the rate limiter.
If it's not the rate limiter than its Guzzle or something within Guzzle itself.


element.scope() is not allowed when $compileProvider.debugInfoEnabled(false);

viewport.scope() is not allowed when $compileProvider.debugInfoEnabled(false);
https://docs.angularjs.org/guide/production

When creating an issue, please provide more details. Most importantly what breaks when, and what you would expect.
In this specific case, you should probably at least mention the module concerned.


#5020 Possibility to define caught keys on Android

See #5020:
Besides the menu or back key, there are some other keys that need to be catched when used: Volume Up/Down, Fast Foward buttons are some examples. When targetting for FireTV devices and using the buttons available on the FireTV Remote Controller, Amazon rejects the game submission if the game does not return that the key event was handled. (They give the reason that a media player in background will react on the key events, which is true.) There is no easy way to solve this problem at the moment.
This PR adds the ability to set other catched keys than just back/menu.

Clicked the wrong button, I wanted to request changes.

@EtK2000
I thought about adding it, and it is easy to implement.
I skipped it because it is another change of the interface with "empty" return false implementations in all other backends and I don't see much benefit: I never used any of the isCatch.. methods - either a key should be catched or not, depending on the game's state.
What do the audience think? Do we need isCatchKey(...)?

This looks okay to me. To be honest, I'd almost rather the specific methods for back and menu get removed in favor of calling the new methods.

Maybe they can be depricated to keep it backwards compatible.

I did not remove the old methods because I was afraid that this won't get merged when backwards compatiblity is broken and I suspect many projects out there are using them. But of course, adding a deprecation tag or removing the old method is all fine for me so I'll do what the maintainers prefer.

Merged manually. Thanks @MrStahlfelge


Update excoveralls to 0.4.5 just like in elixir-thrift

Upgrade all elixir project to use same version as in elixir-thrift:
reference
pinterest/elixir-thrift@1240703
https://github.com/pinterest/elixometer/pull/27

merged
https://github.com/pinterest/elixometer/pull/27


Revert pac4j v6

Description
Revert pac4j v6 upgrade. We found sometimes the cookie wasn't deserializing. I've been able to repro it by jumping back and forth between commits and having an active session.
Checklist
General
Read the full guidelines for PRs here

[x] Added the correct label: < feature | enhancement | bug | under-development | dependencies | infrastructure | ignore-for-release | database >
[x] Assigned to a specific person, civiform/developers, or a more specific round-robin list

I imagine people who cleared their cookies before will need to clear them again after this.

Yes. I'll remind them.


fix!: Major compile fix for non-servers

If building outside a headless server, one may experience compile errs due to fields missing since we now include HathoraServerMgr in any builds (for convenience, mostly). The server commands don't matter without an auth key, so we simply compile without an auth key to non-servers.
Discovered the bug while testing webgl support as a Client.
Before
Compile-time remove the entire auth key prop
After
Compile-time remove only the setters and override getters to return null

Closing this pr - it was already merged from another already in main


teyjus: 2.0b2 -> 2.1

Semi-automatic update. These checks were done:

built on NixOS
ran /nix/store/s3a893figs9wwy07swfzxbf2ai7g6f1d-teyjus-2.1/bin/tjcc --help got 0 exit code
ran /nix/store/s3a893figs9wwy07swfzxbf2ai7g6f1d-teyjus-2.1/bin/tjdepend --help got 0 exit code
ran /nix/store/s3a893figs9wwy07swfzxbf2ai7g6f1d-teyjus-2.1/bin/tjdis --help got 0 exit code
ran /nix/store/s3a893figs9wwy07swfzxbf2ai7g6f1d-teyjus-2.1/bin/tjlink --help got 0 exit code
ran /nix/store/s3a893figs9wwy07swfzxbf2ai7g6f1d-teyjus-2.1/bin/tjsim --help got 0 exit code
found 2.1 with grep in /nix/store/s3a893figs9wwy07swfzxbf2ai7g6f1d-teyjus-2.1
found 2.1 in filename of file in /nix/store/s3a893figs9wwy07swfzxbf2ai7g6f1d-teyjus-2.1

cc @bcdarwin

Failure on x86_64-darwin (full log)
Partial log (click to expand)
Package ‘teyjus-2.1’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/compilers/teyjus/default.nix:24 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Partial log (click to expand)
shrinking /nix/store/s3a893figs9wwy07swfzxbf2ai7g6f1d-teyjus-2.1/bin/tjdepend
shrinking /nix/store/s3a893figs9wwy07swfzxbf2ai7g6f1d-teyjus-2.1/bin/tjdis
shrinking /nix/store/s3a893figs9wwy07swfzxbf2ai7g6f1d-teyjus-2.1/bin/tjsim
shrinking /nix/store/s3a893figs9wwy07swfzxbf2ai7g6f1d-teyjus-2.1/bin/tjlink
shrinking /nix/store/s3a893figs9wwy07swfzxbf2ai7g6f1d-teyjus-2.1/bin/tjcc
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/s3a893figs9wwy07swfzxbf2ai7g6f1d-teyjus-2.1/bin
patching script interpreter paths in /nix/store/s3a893figs9wwy07swfzxbf2ai7g6f1d-teyjus-2.1
checking for references to /tmp/nix-build-teyjus-2.1.drv-0 in /nix/store/s3a893figs9wwy07swfzxbf2ai7g6f1d-teyjus-2.1...
/nix/store/s3a893figs9wwy07swfzxbf2ai7g6f1d-teyjus-2.1

Success on aarch64-linux (full log)
Partial log (click to expand)
shrinking /nix/store/4wzcflhky7nkswjrayvrymiw02jd6sng-teyjus-2.1/bin/tjsim
shrinking /nix/store/4wzcflhky7nkswjrayvrymiw02jd6sng-teyjus-2.1/bin/tjlink
shrinking /nix/store/4wzcflhky7nkswjrayvrymiw02jd6sng-teyjus-2.1/bin/tjdis
shrinking /nix/store/4wzcflhky7nkswjrayvrymiw02jd6sng-teyjus-2.1/bin/tjdepend
shrinking /nix/store/4wzcflhky7nkswjrayvrymiw02jd6sng-teyjus-2.1/bin/tjcc
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/4wzcflhky7nkswjrayvrymiw02jd6sng-teyjus-2.1/bin
patching script interpreter paths in /nix/store/4wzcflhky7nkswjrayvrymiw02jd6sng-teyjus-2.1
checking for references to /build in /nix/store/4wzcflhky7nkswjrayvrymiw02jd6sng-teyjus-2.1...
/nix/store/4wzcflhky7nkswjrayvrymiw02jd6sng-teyjus-2.1

This change does not do what the commit message claims (it probably fixes the hash but does not perform any update). @ryantm did you look at this patch before opening this PR?

@vbgl no. I think it might just be changing the hash format even. I will try to look into how I can prevent this mistake and fix this.

Ah, I missed that, too, sorry

It would have been hard to notice the version update anyway: https://github.com/teyjus/teyjus/issues/117


chore(blog): project proposal template submission to GSoD 2022

In this blog post about AsyncAPI Docs 📑, I wanted to share with all technical writers about our organization’s plan for participation in Google Season of Docs 2022 (GSoD) and the required project proposal template from Google we're submitting to GSoD 2022.
✨ DRAFT PR still in progress... 👩🏻💻

do we need to publish it before you apply?

do we need to publish it before you apply?

@derberg yes! The deadline is March 25th, and I am 100% working on this post today + tmw to get it done and prioritize getting this live by 23rd for example, so that I can submit the Google application early.

🚨 Important Question 😬, @derberg:
Since this is a first for me, I don't even know what to put in our budget section that is also a part of the Google's application format they require.
How should I fill this section out for us?

Project budget
General guidelines You can include your budget in your proposal, or as a separate link. If your budget is fewer than ten items, we recommend including it in your proposal. All budgets should be in US dollars. We expect grants to range from US$5000 to US$15000; if your project is outside of that range, please provide additional information to justify your budget. We expect the bulk of your budget (60-70% minimum) to be allocated to the technical writer working on your project. We recommend budgeting on a per-project basis wherever possible. We expect open source projects to use open source tools whenever possible; if your project absolutely requires funds for proprietary software licenses or support, please include a justification for the amount. Other possible expenses include: Design work to create branding, logos, templates, or other design assets for your documentation site Minimal amounts (<US$200) for project swag (t-shirts or stickers for your participants). If you use the Season of Docs logo, it must be accompanied by your project or organization logo or name. Your swag may not use the name Google. Minimal stipends for volunteers who take on considerable mentorship or guidance roles in the project (we recommend no more than $500 per volunteer, please) Downstream donations to other open source projects should be no more than 10% of your budget total. Include other budget items as needed, along with justification for the amount sought. Expense justifications should highlight how the expenditure will contribute to the success of the project as a whole.

https://developers.google.com/season-of-docs/docs/org-proposal-template#sample_budget

@alequetzalli oh, wait. So they do not offer grants? Google doesn't pay students for the work like in the case of Google Summer of Code? Do I get it right?

@alequetzalli ignore my previous question. I got some more explanation from @HarshCasper offline.
Since we apply for the first time and we have just 2 mentors for now, I assume no more than 2 projects. I would just make things simple for first year and request $10000 budget, so we could have $5000 per project. Rework of generator docs and adding more tutorials is a work for few months for sure. Not sure what projects you had in mind for GSoD

@alequetzalli ignore my previous question. I got some more explanation from @HarshCasper offline. Since we apply for the first time and we have just 2 mentors for now, I assume no more than 2 projects. I would just make things simple for first year and request $10000 budget, so we could have $5000 per project. Rework of generator docs and adding more tutorials is a work for few months for sure. Not sure what projects you had in mind for GSoD

@derberg  Oh nice, glad to hear @HarshCasper had some knowledge to share too. Sound great, those facts will be what I put into our proposal.
You can read what I have so far already too, it's mostly done :)
Not mentioning tutorials, I am making IA our proposed project, and that includes re-purposing/migrating CLI and/or some Tools docs. Tutorials are new content and for now, we have a lot of current content that is amazing and needs to be visible/added to main Docs site.
My goal is to add you/other folks as reviewer and make this into a PR no later than Wed am PST, but shooting for Tuesday.

Yikes, ready for review now!! 🙊😬😬😂😂😂🙏🏽
@derberg @fmvilas

There is only error of self-closing tag img and that is because you haven't closed with the single /.

<img> tags do not need a closing tag.

There is only error of self-closing tag img and that is because you haven't closed with the single /.

@akshatnema As mentioned in another comment, this is incorrect. <img> tags do not need a closing element. This is because it is a VOID element that is not allowed child nodes.

Here we go again, tagging @derberg @fmvilas again for the next round of review 😄✨🎉🎉🎉

@akshatnema As mentioned in another comment, this is incorrect.  tags do not need a closing element. This is because it is a VOID element that is not allowed child nodes.

@alequetzalli I agree with your point that img is a void element, but you can write this in HTML file, not in JSX. Whatever we are writing in the doc file is converting into JSX files, using gray matter and hence, a self closing tag is required there. Also, img tag don't have any child elements present, so it is either to be created by React.createElement or just make it self closing. Do check this article for reference.

It only looks great when you open the post and can see the image nicely, as you can see in the below screenshots. Do you think I should change our feature image?

From the image size point of view in asyncapi.com/blog page, the image required here should have an aspect ratio of 2:1 in length:breadth parameters, to have proper orientation and full display of image. Whereas the image right now uploaded has aspect ratio more than 3:1. If you can adjust the image sizing or crop
the image accordingly, you can get desired results.

The TOC links (links on the right side) are not working in the preview when clicked. They are not going to the desired heading when clicked. Please do check it.

@alequetzalli

as for the logo and how it displays on blog landing page. There are many different versions (horizontal and vertical and sizes of the logo, check them out https://developers.google.com/season-of-docs/images/logo/SeasonofDocs_Logo.zip. I do not think we can come up with some better/quicker fix for that to have the article released tomorrow. If we change object-cover to object-contains here https://github.com/asyncapi/website/blob/master/components/navigation/BlogPostItem.js#L29 then the rest of images will look "strange"
remove SeasonofDocs_Logo.png that is not used

Hey @HarshCasper, in the future it would be better if you jump in with a review earlier, instead of one day before the Google applications close and the blog post has gone through several iterations. :)  This is because waiting till the end makes it harder to get this post LIVE by the due date. Now I am going to instead copy/paste the gist of what is here so far and open a GH Discussion thread and share that link instead with google because it's the most professional link I will be able to share in time :)
P.S. On a different note, I loved your participation and contribution to this PR. You took the time to write detailed ideas and feedback to improve our application and that's awesome. Thank you!

@derberg  I have published a new Docs category GH Discussion with the latest draft of this post. (As in, I copied the latest I have after making improvements from the latest round of feedback.) I have used this GH Discussion link to formally apply to GSoD, and the great thing is that we can easily update it as/if needed, regardless of this blog post PR. 👍🏽👍🏽

I used that option because I like what @HarshCasper mentions about doing it on an official AsyncAPI org GH page. I think a Discussion page from our GH is far better than only being able to share a Netflify preview link for now 😄.

@derberg @fmvilas, ready for review again

well done @alequetzalli 👏🏼 feel free to create a follow-up issue to figure out for the future how to handle these cover pictures to they always display nice. Like maybe we could have a metadata for the article where you can say that for a given article, cover picture should display differently
@akshatnema @HarshCasper thanks folks for taking time to provide feedback 🙇🏼
@fmvilas thanks for being you ❤ 😆

Oh interesting @derberg ... yes that sounds like a really valuable addition… I'm making a note of it so that I can open an issue on it.
A big thank you to everyone who took a lot of time to review with care and provide lots of awesome feedback to improve our application! Regardless of our acceptance, I am proud of all the great work that went into our application. We will also be able to use this write up for our current community to show them what's going on in the docs ecosystem, so this write up is useful either way I believe. ♥✨✨


[SPARK-11762] [network] Account for active streams when couting outstanding requests.

This way the timeout handling code can correctly close "hung" channels that are
processing streams.

Test build #46027 has started for PR 9747 at commit 4df514c.

Test build #46027 has finished for PR 9747 at commit 4df514c.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * class StreamingListener(object):\n

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46027/
Test PASSed.

/cc @rxin @zsxwing

LGTM.
BTW, StreamInterceptor should catch exception from callback.onComplete, onData, onFailure. Otherwise, it may screw up the stream.

BTW, StreamInterceptor should catch exception from callback.onComplete, onData, onFailure. Otherwise, it may screw up the stream.

@vanzin could you fix this in a separate PR?

BTW, StreamInterceptor should catch exception from callback.onComplete, onData, onFailure.

Oops. Hit the wrong thing.

BTW, StreamInterceptor should catch exception from callback.onComplete, onData, onFailure. Otherwise, it may screw up the stream.

It's not as simple as catching the exceptions. StreamInterceptor would have to switch to a mode where it ignores all future data until the stream is over, if the channel is to be kept open.
Right now an exception will bubble up and end up handled by TransportChannelHandler, which will close the channel.

Right now an exception will bubble up and end up handled by TransportChannelHandler, which will close the channel.

Sounds acceptable since #9530 uses a separate channel to stream files.

Merging to master.


right align first month, second month, delta columns

Fixes #4
Examples
❯ go build && ./aws-cct

+-------------------------------------------------+-------------+-------------------------+-------------+
| SERVICE                                         | 2020-09-01  | 2020-10-01 (PROJECTION) | DELTA       |
+-------------------------------------------------+-------------+-------------------------+-------------+
| Amazon EC2 Container Registry (ECR)             |     $119.56 |                 $116.22 |      -$3.34 |
| Amazon EC2 Container Service                    |      $64.22 |                 $136.54 |      $72.32 |
| Amazon Inspector                                |      $33.99 |                  $46.22 |      $12.23 |
| Amazon Kinesis Firehose                         |       $0.06 |                   $0.00 |      -$0.06 |
| AWS CloudTrail                                  |   $3,460.04 |               $3,445.68 |     -$14.36 |
| AWS Security Hub                                |     $168.90 |                 $221.33 |      $52.43 |
| Amazon Macie                                    |       $0.00 |                  $53.23 |      $53.23 |
+-------------------------------------------------+-------------+-------------------------+-------------+
| TOTAL                                           | $130,994.11 |             $112,235.16 | -$18,758.96 |
+-------------------------------------------------+-------------+-------------------------+-------------+

❯ ./aws-cct --start 2020-08-01 --end 2020-09-01 --service "Amazon Relational Database Service"

+-----------------------------+------------+------------+-----------+
| SERVICE                     | 2020-08-01 | 2020-09-01 | DELTA     |
+-----------------------------+------------+------------+-----------+
| Multi-AZUsage:db.m4.xlarge  |    $947.86 |    $917.28 |   -$30.58 |
| DataTransfer-In-Bytes       |      $0.00 |      $0.00 |     $0.00 |
| InstanceUsage:db.m5.large   |      $1.39 |     $48.64 |    $47.25 |
...
| USE1-EU-AWS-In-Bytes        |      $0.00 |      $0.00 |     $0.00 |
| Multi-AZUsage:db.m4.2xlarge |    $947.86 |    $917.28 |   -$30.58 |
+-----------------------------+------------+------------+-----------+
| TOTAL                       | $50,197.13 | $50,956.53 |   $759.41 |
+-----------------------------+------------+------------+-----------+

@rgoomar thanks, updated to align the footers as well!

Thanks for contributing this!


Selected Snack - Confirmation Screen of Selected Snack

NAME OF PAGE/COMPONENT
Selected Snack
PART OF DESIGN NOT MATCHING
The selected snack screen should display so the user can confirm what snack they have selected.

Duplicate - #221


Support for gradients in color themes

Is your feature request related to a problem? Please describe.
Support for gradients in color themes
Describe the solution you'd like
Allow users to define gradients as colors for themes
Describe alternatives you've considered
n/a
Additional context
n/a

Abandon


Remove redirect entries for docs/admin/... pages

The redirection entries in static/_redirects contains some very old data.
This PR is part of a series of actions to clean it up.

/lgtm


Migrate to grafana-operator

Details
Describe the solution you'd like:

Migrate setup to use grafana-agent-operator and CRDs.
Anything else you would like to add:

This is already in-flight. I just need to collect documentation and the existing commits and attach to this issue.
Additional Information:

Variable assignments should be more straightforward and gitops friendly.

Remaining items:
[] Fix roles in keycloak to additionally map to GrafanaAdmin (vs just Admin)
[] Ensure Data sources are actually used correctly.
[] Determine if I need to do anything special to import the configMap dashboards
[] Import remaining dashboards.

Remaining items:
[] import the configMap dashboards
[] Import remaining dashboards.

Need to fix the flux-grafana-provider to use the new instance


files manifest option should warn when destination does not appear to be a directory

Given the following manifest configuration:
files = [{ source = "static/foo.txt", destination = "bar.txt" }]

I would expect at least a warning as I believe destination must always be a directory. If source is a file, that file will be located inside the destination directory, and if source is a directory, all the files will be available at destination. I imagine we can't always error because paths that look like file names are still legal directory names (i.e., "foo.txt" can be a directory name), but we can at least issue a warning as this is more than likely a bug.
Edit: it seems that destinations as files are allowed, but this will break in very weird ways if source is a directory and not a file.

I'm not sure I see an obvious heuristic for this warning. Dots in directory names aren't very common but they occur often enough (e.g. the somewhat common config.d/* pattern) that I wouldn't want to introduce noise for what I would expect to be a relatively rare mistake: { source = "dir", destination = "why-would-this-be-a-file.txt" }

A somewhat-fiddly option here would be to:

Allow a trailing slash in directory destinations (if we don't already; I didn't check)
Don't warn on e.g. destination.txt/
Warn on e.g. destination.txt, with a note that the warning can be suppressed by adding /

This might just be a documentation issue. The docs aren't very clear about the possible permutations here, and that might have been enough to avoid the confusion I ran into.


Add conda instructions

Please see https://github.com/mhallsmoore/qstrader/issues/356#issuecomment-774730614 for more context around what this PR aims to address.

Coverage remained the same at 69.61% when pulling 51bfa25943e17fe6d1b7908023d146e19ec94294 on zzhengnan:conda-instructions into 609a1ca6ebec8c863f9582d4480e1f20ff758350 on mhallsmoore:master.

Thanks @zzhengnan for taking care of this!
I've now merged.


clean_dump_file.py accidentally stripping away some tags

I used these tools to import a variety of cvs packages to git, and noticed that clean_dump_file.py was accidentally stripping away some of the tags (not consistently, and not on every package).
For example, if you go to this folder: /sdf/group/fermi/u/monzani/Move2git and then run: diff cvs2git-tmp-FaM/git-dump.dat cvs2git-tmp-FaM/git-dump-clean.dat | grep tags, the output contains:
< reset refs/tags/FastMon-05-01-01
< reset refs/tags/v5r1p1
< reset refs/tags/FastMon-05-03-00
< reset refs/tags/v5r3p0
< reset refs/tags/FastMon-05-03-05
And sure enough, tags FastMon-05-03-05, FastMon-05-03-00 and FastMon-05-01-01 do not show up on the git repository: https://github.com/fermi-lat/FastMon/tags
I can use a different method to clean the dump files, but I figured I'd report this in case this was observed across different packages.

@jchiang87: not sure if I should have tagged you explicitly. I don't seem to have permissions to assign the issue.


Possible performance problem Adyen_Payment_Model_Billing_Agreement_Observer::_addOneClickMethodsToConfig

When profiling our site we see this takes quite long (and seems to first been seen since the last upgrade). Can someone confirm this?
Adyen_Payment_Model_Billing_Agreement_Observer::_addOneClickMethodsToConfig 2.9391
ps. and is there a possible workaround? (disable oneclick recurring maybe??)

Hi Sean,
This is strange because you do not have recurring_contract notification enabled on your account. Do you have any billing agreements in your magento store? You can just disable the Adyen OneClick payment method.
Regards,
Rik
Adyen

ah maybe this is where it goes wrong, so my options are

turn on recurring_contract? and then Adyen OneClick payment method
works. Is this correct?

Turn off Adyen OneClick payment

thanks, Sean
On Mon, Mar 7, 2016 at 9:09 AM, Rik ter Beek<EMAIL_ADDRESS>wrote:

Hi Sean,
This is strange because you do not have recurring_contract notification
enabled on your account. Do you have any billing agreements in your magento
store? You can just disable the Adyen OneClick payment method.
Regards,
Rik
Adyen
—
Reply to this email directly or view it on GitHub
https://github.com/Adyen/magento/issues/546#issuecomment-193147170.

Hi Sean,
Both are correct.
Regards,
Rik

We turned off oneclick. Also debugging with AOE profiler.  Now log is couple of MB with this:
Dont knoww exactly what it is. Rik?
2016-03-08T15:24:18+00:00 DEBUG (7): [INVALID NESTING!] Found: OBSERVER: adyen_payment_billing_agreement | Expecting: Adyen_Payment_Model_Billing_Agreement_Observer::_addOneClickMethodsToConfig
2016-03-08T15:24:18+00:00 DEBUG (7): Auto-stopping timer "Adyen_Payment_Model_Billing_Agreement_Observer::_addOneClickMethodsToConfig" because of incorrect nesting

Hi Sean,
I have installed this profiler now but can't see this issue in my logs. It could be that it is caused by external modules as for example a checkout module.  If you have turn oneclick off this code should not be executed at all. I have looked into the invalided nesting issue and it can be safely ignored. You can just disable the logging of this in the settings of the AOE profiler configurations.
I can see that the core of magento code they have this issue as well see for example:
2016-03-09T09:38:36+00:00 DEBUG (7): [INVALID NESTING!] Found: mage::dispatch::controller::action::checkout_onepage_progress | Expecting: layout/db_update: checkout_onepage_progress_billing
Regards,
Rik
Adyen

I suggest to close issue


todo

[x] include lat/long polygon

check himawari

[x] check himawari nulls
[x] simplify/remove compact

Closed with commit
4617fc105737fa2e0d2acd737bbdab3872e67620


Be feature nhan friends followers

Codecov Report

Merging #323 (a253c1e) into dev (9306df9) will increase coverage by 0.86%.
The diff coverage is 100.00%.

:exclamation: Current head a253c1e differs from pull request most recent head 6145e4f. Consider uploading reports for the commit 6145e4f to get more accurate results

@@            Coverage Diff             @@
##              dev     #323      +/-   ##
==========================================
+ Coverage   54.70%   55.56%   +0.86%
==========================================
  Files          15       15
  Lines        2360     2370      +10
==========================================
+ Hits         1291     1317      +26
+ Misses       1069     1053      -16

Impacted Files
Coverage Δ

citrus_home/tests/test_views.py
100.00% <100.00%> (ø)

citrus_home/views.py
41.09% <0.00%> (+0.90%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9306df9...6145e4f. Read the comment docs.


VW not playing nice with spongeforge, crashing server.

EDIT: Delete this, I was unaware I was using a version from 13 months ago. (From curseforge)
https://pastebin.com/catZPzsb
Worked fine before I put in spongeforge, then the server crashed. Then I took VW out and the server worked fine without it. So spongeforge and VW cannot coexist at the moment apparently. The pastebin is the console output from the start of the server until the crash, since the server didn't produce a proper crashlog.

You can mark as closed 😄

Easiest close of my life.


Snippets not automatically available in .ts and .tsx files

Following a clean installation of WebStorm version 2023.3.4 and the latest plugin version 1.0.2, I've encountered an issue where code snippets are not automatically available or functioning in .ts and .tsx files. Despite attempting to use snippets in these TypeScript files, they fail to appear in the autocomplete suggestion list.
To access the desired snippets, it's currently necessary to navigate to Editor > Live Templates and manually activate each snippet for use in TypeScript files.

update OTW

great, tyty