Allocation based on a FileDescriptor Value ?

Hey,
I found out there was an allocation in libUV done from a file descriptor value, in the Linux version :
Here :
https://github.com/libuv/libuv/blob/4e766761d00759e9c53d37ca0c04e2872cba6006/src/unix/core.c#L911
Maybe_resize is called to create a allocation with w->fd + 1, and w->fd comes from :
https://github.com/libuv/libuv/blob/4e766761d00759e9c53d37ca0c04e2872cba6006/src/unix/async.c#L223
from a call to eventFd.

it looks really fragile to create an allocation where the length value is a FileDescriptor
I'm on an exotic platform (console), and the FileDescriptor value that is returned is more than 30 millions, creating an allocation of 500 Mo for each loop.

Version: latest version , 1.45.0
Platform: console / Linux

Have you confirmed that the allocation is happening? Can you provide more information about the platform you're using?

it looks really fragile to create an allocation where the length value is a FileDescriptor

It works fine on posix-y platforms where a newly created fd is always the lowest available fd number. If your platform doesn't honor that convention, then you're in for a bad time, yes. What platform is it?

I can't tell anything more on the platform for NDA reasons.
the OS probably has a very loose implementation of posix.
Yes the allocation really occurs, and it's 500Mo for each loop at this point.
I still think making an allocation from a FD value is just terrible design and asking for future issues.
if a process updates the ulimit to open a lot of files, this will make a crazy allocation, just for nothing.
Also ( but I don't know this code at all, so I can be very wrong ) , I'm not sure what is the purpose of this allocation. It's only called once on the init / start of the loop, so it's just used to store 1 value, and to be able to access it as a hashmap ( loop->watchers[fd] ).

You're entitled to your opinion but well, that's all it is: your opinion. Get in touch with your vendor if their posix emulation is so shoddy.

No pb, I just feel it right to report it, but if you're ok with that, it's fine for me.
You know the code and its implication and I don't.


about the training data of the the pretraind model

hello, what is the training data of your provided pretrained kitti model, do you split the kitti 3d detection training dataset into train and val? I don't understand The results are the 3D detection performance of moderate difficulty on the val set of KITTI dataset the val set, very appreciate for your reply.

Yes. We divide the kitti offical training set into training set and validation set as our data/kitti/ImageSets. The results in our readme are evaluated in validation set.

ok, thanks for your reply!! @jihanyang


Fix for the automated installation script: do not fail on unbound variable

The installation script needs to source thisframework.sh which relies on the possibility of $FRAMEWORKSYS being undefined. Setting 'set -u' in the calling script propagated to thisframework.sh causing it to fail during automated installation in environments where thisframework was never sourced before.
The latter was the reason why I never discovered this problem before (I practically always have FRAMEWORKSYS set to something already). However, the failure during automated installation was reported to me by several users.

I run the script on two different computers, both Ubuntu 22.04.
Seems that everything worked and no errors were encountered.


HP USB printers are not supported

I have an HP Deskjet 1010 printer and when I try to print a document, the system does not show any printers on it.

That one doesn't have internet connectivity.

Yes. USB printers possibly need to be set up in CUPS in that way.

Is there a way to make it plug and play, this is too much trouble.

First step is to make it work at all. Does it work like this?

It doesn't respond when I press apply here.

Maybe you need to use
System -> Applications -> Preferences -> Print Settings

I do use that one.

I tried it, it didn't work.

Does your printer work on e.g., GhostBSD?

Is working.

Can you find out why it works there but not here? Do they ship additional packages related to that printer? Do they run additional processes?

Tell me how to check.

Again the question, can you add the printer in http://localhost:631/admin, by clicking on "Add printer" ?

it works and can go next.

Just one thing, on GhostBSD, if you use your link, you will end up with an error, you can only use the detect hardware option from the menu to be fine.

Just to be extra sure: On helloSystem can you add the printer in http://localhost:631/admin, by clicking on "Add printer" and it works?

I can only confirm that it is still stuck on this problem in the Hello system.
https://github.com/helloSystem/ISO/issues/460
And ghostbsd is successfully adding the printer with the URL, but there is an error notification after adding the printer with the URL.


Landing page category icons need to be highlighted on mouseenter

These icons need to be highlighted (color changed, enlarged, etc.) on cursor enter. It's hard to know if they are links.

Those are gone.


provide no-jdk distribution

Is your feature request related to a problem? Please describe.
we want to be able to control the JDK being used (we have our own base docker images with a JDK configured the way we want (correct vendor, up-to-date security fixes, etc.) and thus don't need a JDK to be shipped with OpenSearch.
Describe the solution you'd like
please provide a no-jdk distribution (at least of the current "minimal" distribution) which - as the name implies - does not come with a pre-packaged JDK.
Describe alternatives you've considered
downloading the existing archive and manually removing the JDK would be a huge overhead and would also make the docker image larger (if we do this in the docker image; we could of course do it in a pre-step but that'd make things even more complicated) and it would be a non-standard setup which is harder for others to replicate.
Additional context
this has been discussed in the forum: No-jdk distribution of opensearch?

[Triage] The build process can support this, it would need to be integrated and tested so it could be released.

[Triage] @dblock @CEHENKLE Does the opensearch-min artifact generation process (gradle) support this today?

[Triage] @dblock @CEHENKLE Does the opensearch-min artifact generation process (gradle) support this today?

AFAIK yes, but I am not familiar with details

out of interest: where's the code which packages the JDK with the ZIP file? is this here or in the opensearch repo? i couldn't find it in either with a cursory glance (plus i'm not certain if this is even something which could easily be contributed by somebody who doesn't have access to the complete build infrastructure as, after all, the no-jdk dist will have to be published and linked to in various places?)

It's in OpenSearch, search for no-jdk, e.g. https://github.com/opensearch-project/OpenSearch/blob/0ba0e7cc26060f964fcbf6ee45bae53b3a9941d0/qa/os/src/test/java/org/opensearch/packaging/util/Distribution.java#L60
I think the first step for this one is to produce the no-jdk distribution as part of the daily build. Probably the easiest is to always make a JDK and no-JDK build by changing https://github.com/opensearch-project/opensearch-build/blob/main/scripts/default/opensearch/build.sh#L68. We pickup everything in build/distributions, so that would just get included for the ride across all platforms/architectures.

i browsed around a bit and found the following relevant things:

this commit added no-jdk distributions in the first place: https://github.com/opensearch-project/OpenSearch/commit/8f09c77777024500be62330328053ade640cfb2c
https://github.com/opensearch-project/OpenSearch/blob/main/distribution/archives/build.gradle (this seems to already generate no-jdk files?)
https://github.com/opensearch-project/OpenSearch/blob/main/distribution/packages/build.gradle (also seems to already generate no-jdk packages?)

what i haven't seen yet at first glance is where gradlew assemble would define what should be created during tests (then again, i've only been clicking around on the web UI and haven't even cloned the repo yet... i'll do that next year if nobody picks it up until then).

@rursprung I think the next step is to add it to https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/opensearch/distribution-build.jenkinsfile, so it starts appearing in the build output

@rursprung I think the next step is to add it to https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/opensearch/distribution-build.jenkinsfile, so it starts appearing in the build output
These currently run in a private Jenkins instance, but are this close to being run in public https://build.ci.opensearch.org/, see opensearch-project/opensearch-ci#2.

thanks, that's good news!
however, i'm not sure how much sense it'll make if i'll try to contribute to this as i can't test whether my changes to the script would work.
and, if i understood the script correctly, it'd need some changes to buildAssembleUpload (which might still be somewhere in the not-yet-opensourced part?) - but then again i admittedly don't quite see yet where the script decides which artifact to pull in (it e.g. never seems to explicitly say whether it wants x64 or arm64?).

Thanks a lot for your feedback @peterzhuamazon! That does sound more complicated than it sounded initially!
I ran a quick test (on the latest main branch and on Windows) and it does seem that the standard assemble call already builds both the non-jdk as well as the bundled package (both [..]\distribution\archives\windows-zip\build\distributions\opensearch-min-3.0.0-SNAPSHOT-windows-x64.zip and [..]\distribution\archives\no-jdk-windows-zip\build\distributions\opensearch-min-3.0.0-SNAPSHOT-no-jdk-windows-x64.zip were generated). So maybe there’s no need to call a new gradle target and instead this is already part of the target being called?
There also seem to be gradle targets for no-jdk deb & rpm packages: https://github.com/opensearch-project/OpenSearch/tree/main/distribution/packages
Note that I raised the ticket explicitly for OpenSearch, not OpenSearch Dashboards – we’re currently not using that, so it’s of no relevance for me. Though I can see that the same discussion can be had there, I think it should be split away (and be driven by somebody involved in / using OpenSearch Dashboards) and could potentially also result in a different decision (AFAIK Node.JS versions are more finicky than JDK versions?).

I think the next step is to add a step to https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/opensearch/distribution-build.jenkinsfile that would call these gradle tasks that exist.

@rursprung all the non-jdk task I have seen so far:

distribution:archives:no-jdk-darwin-tar:assemble - Assembles the outputs of this project.
distribution:archives:no-jdk-freebsd-tar:assemble - Assembles the outputs of this project.
distribution:archives:no-jdk-linux-tar:assemble - Assembles the outputs of this project.
distribution:archives:no-jdk-windows-zip:assemble - Assembles the outputs of this project.
distribution:packages:no-jdk-deb:assemble - Assembles the outputs of this project.
distribution:packages:no-jdk-rpm:assemble - Assembles the outputs of this project.
distribution:archives:no-jdk-darwin-tar:build - Assembles and tests this project.
distribution:archives:no-jdk-freebsd-tar:build - Assembles and tests this project.
distribution:archives:no-jdk-linux-tar:build - Assembles and tests this project.
distribution:archives:no-jdk-windows-zip:build - Assembles and tests this project.
distribution:packages:no-jdk-deb:build - Assembles and tests this project.
distribution:packages:no-jdk-rpm:build - Assembles and tests this project.
distribution:archives:no-jdk-darwin-tar:clean - Deletes the build directory.
distribution:archives:no-jdk-freebsd-tar:clean - Deletes the build directory.
distribution:archives:no-jdk-linux-tar:clean - Deletes the build directory.
distribution:archives:no-jdk-windows-zip:clean - Deletes the build directory.
distribution:packages:no-jdk-deb:clean - Deletes the build directory.
distribution:packages:no-jdk-rpm:clean - Deletes the build directory.
distribution:archives:no-jdk-darwin-tar:assembleDist - Assembles the main distributions
distribution:archives:no-jdk-freebsd-tar:assembleDist - Assembles the main distributions
distribution:archives:no-jdk-linux-tar:assembleDist - Assembles the main distributions
distribution:archives:no-jdk-windows-zip:assembleDist - Assembles the main distributions
distribution:packages:no-jdk-deb:assembleDist - Assembles the main distributions
distribution:packages:no-jdk-rpm:assembleDist - Assembles the main distributions
distribution:archives:no-jdk-darwin-tar:distTar - Bundles the project as a distribution.
distribution:archives:no-jdk-freebsd-tar:distTar - Bundles the project as a distribution.
distribution:archives:no-jdk-linux-tar:distTar - Bundles the project as a distribution.
distribution:archives:no-jdk-windows-zip:distTar - Bundles the project as a distribution.
distribution:packages:no-jdk-deb:distTar - Bundles the project as a distribution.
distribution:packages:no-jdk-rpm:distTar - Bundles the project as a distribution.
distribution:archives:no-jdk-darwin-tar:distZip - Bundles the project as a distribution.
distribution:archives:no-jdk-freebsd-tar:distZip - Bundles the project as a distribution.
distribution:archives:no-jdk-linux-tar:distZip - Bundles the project as a distribution.
distribution:archives:no-jdk-windows-zip:distZip - Bundles the project as a distribution.
distribution:packages:no-jdk-deb:distZip - Bundles the project as a distribution.
distribution:packages:no-jdk-rpm:distZip - Bundles the project as a distribution.
distribution:archives:no-jdk-darwin-tar:installDist - Installs the project as a distribution as-is.
distribution:archives:no-jdk-freebsd-tar:installDist - Installs the project as a distribution as-is.
distribution:archives:no-jdk-linux-tar:installDist - Installs the project as a distribution as-is.
distribution:archives:no-jdk-windows-zip:installDist - Installs the project as a distribution as-is.
distribution:packages:no-jdk-deb:installDist - Installs the project as a distribution as-is.
distribution:packages:no-jdk-rpm:installDist - Installs the project as a distribution as-is.
distribution:archives:no-jdk-darwin-tar:buildEnvironment - Displays all buildscript dependencies declared in project ':distribution:archives:no-jdk-darwin-tar'.
distribution:archives:no-jdk-freebsd-tar:buildEnvironment - Displays all buildscript dependencies declared in project ':distribution:archives:no-jdk-freebsd-tar'.
distribution:archives:no-jdk-linux-tar:buildEnvironment - Displays all buildscript dependencies declared in project ':distribution:archives:no-jdk-linux-tar'.
distribution:archives:no-jdk-windows-zip:buildEnvironment - Displays all buildscript dependencies declared in project ':distribution:archives:no-jdk-windows-zip'.
distribution:packages:no-jdk-deb:buildEnvironment - Displays all buildscript dependencies declared in project ':distribution:packages:no-jdk-deb'.
distribution:packages:no-jdk-rpm:buildEnvironment - Displays all buildscript dependencies declared in project ':distribution:packages:no-jdk-rpm'.
distribution:archives:no-jdk-darwin-tar:components - Displays the components produced by project ':distribution:archives:no-jdk-darwin-tar'. [incubating]
distribution:archives:no-jdk-freebsd-tar:components - Displays the components produced by project ':distribution:archives:no-jdk-freebsd-tar'. [incubating]
distribution:archives:no-jdk-linux-tar:components - Displays the components produced by project ':distribution:archives:no-jdk-linux-tar'. [incubating]
distribution:archives:no-jdk-windows-zip:components - Displays the components produced by project ':distribution:archives:no-jdk-windows-zip'. [incubating]
distribution:packages:no-jdk-deb:components - Displays the components produced by project ':distribution:packages:no-jdk-deb'. [incubating]
distribution:packages:no-jdk-rpm:components - Displays the components produced by project ':distribution:packages:no-jdk-rpm'. [incubating]
distribution:archives:no-jdk-darwin-tar:dependencies - Displays all dependencies declared in project ':distribution:archives:no-jdk-darwin-tar'.
distribution:archives:no-jdk-freebsd-tar:dependencies - Displays all dependencies declared in project ':distribution:archives:no-jdk-freebsd-tar'.
distribution:archives:no-jdk-linux-tar:dependencies - Displays all dependencies declared in project ':distribution:archives:no-jdk-linux-tar'.
distribution:archives:no-jdk-windows-zip:dependencies - Displays all dependencies declared in project ':distribution:archives:no-jdk-windows-zip'.
distribution:packages:no-jdk-deb:dependencies - Displays all dependencies declared in project ':distribution:packages:no-jdk-deb'.
distribution:packages:no-jdk-rpm:dependencies - Displays all dependencies declared in project ':distribution:packages:no-jdk-rpm'.
distribution:archives:no-jdk-darwin-tar:dependencyInsight - Displays the insight into a specific dependency in project ':distribution:archives:no-jdk-darwin-tar'.
distribution:archives:no-jdk-freebsd-tar:dependencyInsight - Displays the insight into a specific dependency in project ':distribution:archives:no-jdk-freebsd-tar'.
distribution:archives:no-jdk-linux-tar:dependencyInsight - Displays the insight into a specific dependency in project ':distribution:archives:no-jdk-linux-tar'.
distribution:archives:no-jdk-windows-zip:dependencyInsight - Displays the insight into a specific dependency in project ':distribution:archives:no-jdk-windows-zip'.
distribution:packages:no-jdk-deb:dependencyInsight - Displays the insight into a specific dependency in project ':distribution:packages:no-jdk-deb'.
distribution:packages:no-jdk-rpm:dependencyInsight - Displays the insight into a specific dependency in project ':distribution:packages:no-jdk-rpm'.
distribution:archives:no-jdk-darwin-tar:dependentComponents - Displays the dependent components of components in project ':distribution:archives:no-jdk-darwin-tar'. [incubating]
distribution:archives:no-jdk-freebsd-tar:dependentComponents - Displays the dependent components of components in project ':distribution:archives:no-jdk-freebsd-tar'. [incubating]
distribution:archives:no-jdk-linux-tar:dependentComponents - Displays the dependent components of components in project ':distribution:archives:no-jdk-linux-tar'. [incubating]
distribution:archives:no-jdk-windows-zip:dependentComponents - Displays the dependent components of components in project ':distribution:archives:no-jdk-windows-zip'. [incubating]
distribution:packages:no-jdk-deb:dependentComponents - Displays the dependent components of components in project ':distribution:packages:no-jdk-deb'. [incubating]
distribution:packages:no-jdk-rpm:dependentComponents - Displays the dependent components of components in project ':distribution:packages:no-jdk-rpm'. [incubating]
distribution:archives:no-jdk-darwin-tar:help - Displays a help message.
distribution:archives:no-jdk-freebsd-tar:help - Displays a help message.
distribution:archives:no-jdk-linux-tar:help - Displays a help message.
distribution:archives:no-jdk-windows-zip:help - Displays a help message.
distribution:packages:no-jdk-deb:help - Displays a help message.
distribution:packages:no-jdk-rpm:help - Displays a help message.
distribution:archives:no-jdk-darwin-tar:model - Displays the configuration model of project ':distribution:archives:no-jdk-darwin-tar'. [incubating]
distribution:archives:no-jdk-freebsd-tar:model - Displays the configuration model of project ':distribution:archives:no-jdk-freebsd-tar'. [incubating]
distribution:archives:no-jdk-linux-tar:model - Displays the configuration model of project ':distribution:archives:no-jdk-linux-tar'. [incubating]
distribution:archives:no-jdk-windows-zip:model - Displays the configuration model of project ':distribution:archives:no-jdk-windows-zip'. [incubating]
distribution:packages:no-jdk-deb:model - Displays the configuration model of project ':distribution:packages:no-jdk-deb'. [incubating]
distribution:packages:no-jdk-rpm:model - Displays the configuration model of project ':distribution:packages:no-jdk-rpm'. [incubating]
distribution:archives:no-jdk-darwin-tar:outgoingVariants - Displays the outgoing variants of project ':distribution:archives:no-jdk-darwin-tar'.
distribution:archives:no-jdk-freebsd-tar:outgoingVariants - Displays the outgoing variants of project ':distribution:archives:no-jdk-freebsd-tar'.
distribution:archives:no-jdk-linux-tar:outgoingVariants - Displays the outgoing variants of project ':distribution:archives:no-jdk-linux-tar'.
distribution:archives:no-jdk-windows-zip:outgoingVariants - Displays the outgoing variants of project ':distribution:archives:no-jdk-windows-zip'.
distribution:packages:no-jdk-deb:outgoingVariants - Displays the outgoing variants of project ':distribution:packages:no-jdk-deb'.
distribution:packages:no-jdk-rpm:outgoingVariants - Displays the outgoing variants of project ':distribution:packages:no-jdk-rpm'.
distribution:archives:no-jdk-darwin-tar:projects - Displays the sub-projects of project ':distribution:archives:no-jdk-darwin-tar'.
distribution:archives:no-jdk-freebsd-tar:projects - Displays the sub-projects of project ':distribution:archives:no-jdk-freebsd-tar'.
distribution:archives:no-jdk-linux-tar:projects - Displays the sub-projects of project ':distribution:archives:no-jdk-linux-tar'.
distribution:archives:no-jdk-windows-zip:projects - Displays the sub-projects of project ':distribution:archives:no-jdk-windows-zip'.
distribution:packages:no-jdk-deb:projects - Displays the sub-projects of project ':distribution:packages:no-jdk-deb'.
distribution:packages:no-jdk-rpm:projects - Displays the sub-projects of project ':distribution:packages:no-jdk-rpm'.
distribution:archives:no-jdk-darwin-tar:properties - Displays the properties of project ':distribution:archives:no-jdk-darwin-tar'.
distribution:archives:no-jdk-freebsd-tar:properties - Displays the properties of project ':distribution:archives:no-jdk-freebsd-tar'.
distribution:archives:no-jdk-linux-tar:properties - Displays the properties of project ':distribution:archives:no-jdk-linux-tar'.
distribution:archives:no-jdk-windows-zip:properties - Displays the properties of project ':distribution:archives:no-jdk-windows-zip'.
distribution:packages:no-jdk-deb:properties - Displays the properties of project ':distribution:packages:no-jdk-deb'.
distribution:packages:no-jdk-rpm:properties - Displays the properties of project ':distribution:packages:no-jdk-rpm'.
distribution:archives:no-jdk-darwin-tar:tasks - Displays the tasks runnable from project ':distribution:archives:no-jdk-darwin-tar'.
distribution:archives:no-jdk-freebsd-tar:tasks - Displays the tasks runnable from project ':distribution:archives:no-jdk-freebsd-tar'.
distribution:archives:no-jdk-linux-tar:tasks - Displays the tasks runnable from project ':distribution:archives:no-jdk-linux-tar'.
distribution:archives:no-jdk-windows-zip:tasks - Displays the tasks runnable from project ':distribution:archives:no-jdk-windows-zip'.
distribution:packages:no-jdk-deb:tasks - Displays the tasks runnable from project ':distribution:packages:no-jdk-deb'.
distribution:packages:no-jdk-rpm:tasks - Displays the tasks runnable from project ':distribution:packages:no-jdk-rpm'.
distribution:archives:no-jdk-darwin-tar:cleanEclipse - Cleans all Eclipse files.
distribution:archives:no-jdk-freebsd-tar:cleanEclipse - Cleans all Eclipse files.
distribution:archives:no-jdk-linux-tar:cleanEclipse - Cleans all Eclipse files.
distribution:archives:no-jdk-windows-zip:cleanEclipse - Cleans all Eclipse files.
distribution:packages:no-jdk-deb:cleanEclipse - Cleans all Eclipse files.
distribution:packages:no-jdk-rpm:cleanEclipse - Cleans all Eclipse files.
distribution:archives:no-jdk-darwin-tar:cleanIdea - Cleans IDEA project files (IML, IPR)
distribution:archives:no-jdk-freebsd-tar:cleanIdea - Cleans IDEA project files (IML, IPR)
distribution:archives:no-jdk-linux-tar:cleanIdea - Cleans IDEA project files (IML, IPR)
distribution:archives:no-jdk-windows-zip:cleanIdea - Cleans IDEA project files (IML, IPR)
distribution:packages:no-jdk-deb:cleanIdea - Cleans IDEA project files (IML, IPR)
distribution:packages:no-jdk-rpm:cleanIdea - Cleans IDEA project files (IML, IPR)
distribution:archives:no-jdk-darwin-tar:eclipse - Generates all Eclipse files.
distribution:archives:no-jdk-freebsd-tar:eclipse - Generates all Eclipse files.
distribution:archives:no-jdk-linux-tar:eclipse - Generates all Eclipse files.
distribution:archives:no-jdk-windows-zip:eclipse - Generates all Eclipse files.
distribution:packages:no-jdk-deb:eclipse - Generates all Eclipse files.
distribution:packages:no-jdk-rpm:eclipse - Generates all Eclipse files.
distribution:archives:no-jdk-darwin-tar:idea - Generates IDEA project files (IML, IPR, IWS)
distribution:archives:no-jdk-freebsd-tar:idea - Generates IDEA project files (IML, IPR, IWS)
distribution:archives:no-jdk-linux-tar:idea - Generates IDEA project files (IML, IPR, IWS)
distribution:archives:no-jdk-windows-zip:idea - Generates IDEA project files (IML, IPR, IWS)
distribution:packages:no-jdk-deb:idea - Generates IDEA project files (IML, IPR, IWS)
distribution:packages:no-jdk-rpm:idea - Generates IDEA project files (IML, IPR, IWS)
distribution:archives:no-jdk-darwin-tar:check - Runs all checks.
distribution:archives:no-jdk-freebsd-tar:check - Runs all checks.
distribution:archives:no-jdk-linux-tar:check - Runs all checks.
distribution:archives:no-jdk-windows-zip:check - Runs all checks.
distribution:packages:no-jdk-deb:check - Runs all checks.
distribution:packages:no-jdk-rpm:check - Runs all checks.
distribution:archives:no-jdk-darwin-tar:checkExtraction
distribution:archives:no-jdk-freebsd-tar:checkExtraction
distribution:archives:no-jdk-linux-tar:checkExtraction
distribution:archives:no-jdk-windows-zip:checkExtraction
distribution:packages:no-jdk-deb:checkExtraction
distribution:packages:no-jdk-rpm:checkExtraction
distribution:archives:no-jdk-darwin-tar:checkLicense
distribution:archives:no-jdk-freebsd-tar:checkLicense
distribution:archives:no-jdk-linux-tar:checkLicense
distribution:archives:no-jdk-windows-zip:checkLicense
distribution:packages:no-jdk-deb:checkLicense
distribution:packages:no-jdk-rpm:checkLicense
distribution:packages:no-jdk-deb:checkLicenseMetadata
distribution:packages:no-jdk-rpm:checkLicenseMetadata
distribution:archives:no-jdk-darwin-tar:checkNotice
distribution:archives:no-jdk-freebsd-tar:checkNotice
distribution:archives:no-jdk-linux-tar:checkNotice
distribution:archives:no-jdk-windows-zip:checkNotice
distribution:packages:no-jdk-deb:checkNotice
distribution:packages:no-jdk-rpm:checkNotice
distribution:archives:no-jdk-darwin-tar:checkPart1
distribution:archives:no-jdk-freebsd-tar:checkPart1
distribution:archives:no-jdk-linux-tar:checkPart1
distribution:archives:no-jdk-windows-zip:checkPart1
distribution:packages:no-jdk-deb:checkPart1
distribution:packages:no-jdk-rpm:checkPart1
distribution:archives:no-jdk-darwin-tar:checkPart2
distribution:archives:no-jdk-freebsd-tar:checkPart2
distribution:archives:no-jdk-linux-tar:checkPart2
distribution:archives:no-jdk-windows-zip:checkPart2
distribution:packages:no-jdk-deb:checkPart2
distribution:packages:no-jdk-rpm:checkPart2
distribution:archives:no-jdk-darwin-tar:cleanEclipseProject
distribution:archives:no-jdk-freebsd-tar:cleanEclipseProject
distribution:archives:no-jdk-linux-tar:cleanEclipseProject
distribution:archives:no-jdk-windows-zip:cleanEclipseProject
distribution:packages:no-jdk-deb:cleanEclipseProject
distribution:packages:no-jdk-rpm:cleanEclipseProject
distribution:archives:no-jdk-darwin-tar:cleanIdeaModule
distribution:archives:no-jdk-freebsd-tar:cleanIdeaModule
distribution:archives:no-jdk-linux-tar:cleanIdeaModule
distribution:archives:no-jdk-windows-zip:cleanIdeaModule
distribution:packages:no-jdk-deb:cleanIdeaModule
distribution:packages:no-jdk-rpm:cleanIdeaModule
distribution:archives:no-jdk-darwin-tar:copyEclipseSettings
distribution:archives:no-jdk-freebsd-tar:copyEclipseSettings
distribution:archives:no-jdk-linux-tar:copyEclipseSettings
distribution:archives:no-jdk-windows-zip:copyEclipseSettings
distribution:packages:no-jdk-deb:copyEclipseSettings
distribution:packages:no-jdk-rpm:copyEclipseSettings
distribution:archives:no-jdk-darwin-tar:eclipseProject - Generates the Eclipse project file.
distribution:archives:no-jdk-freebsd-tar:eclipseProject - Generates the Eclipse project file.
distribution:archives:no-jdk-linux-tar:eclipseProject - Generates the Eclipse project file.
distribution:archives:no-jdk-windows-zip:eclipseProject - Generates the Eclipse project file.
distribution:packages:no-jdk-deb:eclipseProject - Generates the Eclipse project file.
distribution:packages:no-jdk-rpm:eclipseProject - Generates the Eclipse project file.
distribution:archives:no-jdk-darwin-tar:ideaModule - Generates IDEA module files (IML)
distribution:archives:no-jdk-freebsd-tar:ideaModule - Generates IDEA module files (IML)
distribution:archives:no-jdk-linux-tar:ideaModule - Generates IDEA module files (IML)
distribution:archives:no-jdk-windows-zip:ideaModule - Generates IDEA module files (IML)
distribution:packages:no-jdk-deb:ideaModule - Generates IDEA module files (IML)
distribution:packages:no-jdk-rpm:ideaModule - Generates IDEA module files (IML)
distribution:archives:no-jdk-darwin-tar:resolveAllDependencies
distribution:archives:no-jdk-freebsd-tar:resolveAllDependencies
distribution:archives:no-jdk-linux-tar:resolveAllDependencies
distribution:archives:no-jdk-windows-zip:resolveAllDependencies
distribution:packages:no-jdk-deb:resolveAllDependencies
distribution:packages:no-jdk-rpm:resolveAllDependencies
distribution:archives:no-jdk-darwin-tar:wipeEclipseSettings
distribution:archives:no-jdk-freebsd-tar:wipeEclipseSettings
distribution:archives:no-jdk-linux-tar:wipeEclipseSettings
distribution:archives:no-jdk-windows-zip:wipeEclipseSettings
distribution:packages:no-jdk-deb:wipeEclipseSettings
distribution:packages:no-jdk-rpm:wipeEclipseSettings

Notable:
distribution:archives:no-jdk-darwin-tar
distribution:archives:no-jdk-linux-tar
distribution:archives:no-jdk-windows-zip
distribution:packages:no-jdk-rpm

Basically covered all the distributions we are looking at.

I think the next step is to add a step to https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/opensearch/distribution-build.jenkinsfile that would call these gradle tasks that exist.

this is where i got stuck in may (see our comments from may 5 & 6) - i haven't seen how that build script decides what to actually build, i.e. i haven't understood what i'd have to add/change to get a no-jdk build. if you could point me in the right direction there (and tell me how to test it) that'd be great!

So from the top:
                            buildManifest(
                                componentName: "${COMPONENT_NAME}",
                                inputManifest: "manifests/${INPUT_MANIFEST}",
                                distribution: 'tar',
                                snapshot: true
                            )

This says take a manifest, e.g. https://github.com/opensearch-project/opensearch-build/blob/main/manifests/3.0.0/opensearch-3.0.0.yml and build it with build.sh ... + bunch of arguments such as the above  distribution and snapshot=true/false. That calls That calls https://github.com/opensearch-project/opensearch-build/blob/main/scripts/components/OpenSearch/build.sh in which you can see a big switch that ultimately turns this into a ./gradle ... command. I think you want to start modifying that build.sh to support nojdk-tar so it can be referenced from the above snippet.

Alternatively, and possibly easier, build.sh for opensearch could always produce both a JDK and no-JDK distribution, so you would add a second line below ./gradlew :distribution:$TYPE:$TARGET:assemble -Dbuild.snapshot=$SNAPSHOT -Dbuild.version_qualifier=$QUALIFIER in https://github.com/opensearch-project/opensearch-build/blob/main/scripts/components/OpenSearch/build.sh. Then that file would be automatically collected and published next to the min distribution that we have today.

i've now added it on the same line even (makes the build much faster as it avoids running the other tasks twice):
./gradlew :distribution:$TYPE:$TARGET:assemble :distribution:$TYPE:no-jdk-$TARGET:assemble -Dbuild.snapshot=$SNAPSHOT -Dbuild.version_qualifier=$QUALIFIER

however, this does require that every target called this way also has a corresponding no-jdk target.
i've checked the targets in the OpenSearch repository and saw that the following are currently missing:

:distribution:archives:no-jdk-linux-arm64-tar
:distribution:archives:no-jdk-linux-s390x-tar (though the s390x platform is anyway currently unsupported by build.sh - was this intentional @pantovad (you recently introduced support for s390x with https://github.com/opensearch-project/OpenSearch/pull/4001))
:distribution:archives:no-jdk-integ-test-zip (probably not needed: integ-test-zip sounds like a special target and is unsupported in build.sh?)
:distribution:packages:no-jdk-arm64-deb
:distribution:packages:no-jdk-arm64-rpm

is there a specific reason why these do not exist or could/should they be added?
i'm also a bit surprised that for some targets there's a sub-folder with an empty build.gradle in archives and packages and for others (e.g. the s390x platform) there isn't. are these even still needed or could they be deleted to avoid confusion (i first didn't notice that platform because i looked at the folders and only looked at the actual gradle targets in a second step).
suggested next steps (if you agree with them):

add the missing no-jdk targets (see list above; everything but no-jdk-integ-test-zip) to OpenSearch on main
update the build.sh line here as indicated on main
optional, unrelated: remove the (probably unnecessary?) empty folders for the targets in OpenSearch on main to avoid confusion in the future

does the build.sh of this repository need to be compatible with multiple OpenSearch releases (i presume so, based on the fact that it's pretty version-agnostic otherwise?). if so, would we have to add the missing no-jdk targets also to older OpenSearch releases (where applicable)?

is there a specific reason why these do not exist or could/should they be added?

I don't know of any specific reason, simply unused.

i'm also a bit surprised ...

That's because it is unused, so no "good" reason.

suggested next steps (if you agree with them):

add the missing no-jdk targets (see list above; everything but no-jdk-integ-test-zip) to OpenSearch on main & 2.x
update the build.sh line here as indicated on main
optional, unrelated: remove the (probably unnecessary?) empty folders for the targets in OpenSearch on main to avoid confusion in the future

Sounds good!

does the build.sh of this repository need to be compatible with multiple OpenSearch releases (i presume so, based on the fact that it's pretty version-agnostic otherwise?). if so, would we have to add the missing no-jdk targets also to older OpenSearch releases (where applicable)?

We have been moving build.sh's into each repo so that it branches with the repo, and you can do the same for OpenSearch repo. The default in this repo can go away if all built branches in opensearch-project/OpenSearch have script/build.sh.

i've done the first and third step in the PRs https://github.com/opensearch-project/OpenSearch/pull/4722 and https://github.com/opensearch-project/OpenSearch/pull/4723 (the latter isn't actually relevant for this topic here, just a cleanup).

We have been moving build.sh's into each repo so that it branches with the repo, and you can do the same for OpenSearch repo. The default in this repo can go away if all built branches in opensearch-project/OpenSearch have script/build.sh.

where exactly should the file go? directly as /script/build.sh or in another location? then i'd just copy it over from the current main branch of this repository here?
and what about the other files in /scripts/components/OpenSearch? do they stay here or should they be moved as well?
do you maybe have an example PR where you already did such a move to see what should be changed?

where exactly should the file go? directly as /script/build.sh or in another location? then i'd just copy it over from the current main branch of this repository here?

Yes.

and what about the other files in /scripts/components/OpenSearch? do they stay here or should they be moved as well? do you maybe have an example PR where you already did such a move to see what should be changed?

They can stay here until there's a build.sh in all active branches of OpenSearch. We should backport build.sh all over the place, and then delete here.

all active branches of OpenSearch

is there a full list of those? my presumption would be that it's the following:

main
2.x
1.x

and maybe also the following?

2.3
2.2
2.1
2.0
1.3

though with pure semver i don't see why they'd still be maintained (or why they exist as branches at all), as e.g. (random example) 2.4.0 with a bugfix would be a perfectly valid upgrade path for a user on 2.1.0, so no 2.1.1 would be needed. but that'd then be a discussion for elsewhere 😄

and then delete here.

does it afterwards automatically look for the correct script in the other repo or are more changes needed here (or elsewhere) than just deleting the files?

@rursprung That list is here: https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/check-for-build.jenkinsfile#L17
Yes. No other changes needed. The logic is documented in https://github.com/opensearch-project/opensearch-build/tree/main/src/build_workflow#custom-build-scripts and implemented in https://github.com/opensearch-project/opensearch-build/blob/main/src/paths/script_finder.py.

@peterzhuamazon Am I correct for the list of active branches? I don't see 1.3.x being built in that list, but I know we just released 1.3.6. Do you typically add that on demand? Should @rursprung backport build.sh changes to 1.x and 1.3 in opensearch?

@peterzhuamazon (or anyone else who knows this): is there anything else left to be done so that the files created by the build process are also published to artifacts.opensearch.org?
the other question is: where should these files be linked to? i'd suggest to just add them in the package dropdown of OpenSearch on the downloads page.

@peterzhuamazon (or anyone else who knows this): is there anything else left to be done so that the files created by the build process are also published to artifacts.opensearch.org?

Based on the email exchange let's start some discussion on this.
I will sync up with you on the necessary steps.
cc: @setiah @bbarani
Thanks.


Issue Broadcasting Transactions??

I have no idea what this is.

hum.. is it possible to have more details ilke the rawtx and the compose args ?

Params:
Source: 13Hnmhs5gy2yXKVBx4wSM5HCBdKnaSBZJH
Dest: 17LV3y5KhExPdVcqS81zXuVUfNV9pmaGA
Asset: GAMESOFTRUMP
Amount 1
Fee: 0.00009213
Error:
Error validating transaction: Transaction 339270705c15bb9b14b3c38ed40b5f9106f8f5129f8a2f05a8643077eda05 orphaned, missing reference

$ curl -X POST http://localhost:4000/api/ --user rpc:rpc -H 'Content-Type: application/json; charset=UTF-8' -H 'Accept: application/json, text/javascript' --data-binary '{
    "method": "create_send",
    "params": {
      "source": "13Hnmhs5gy2yXKVBx4wSM5HCBdKnaSBZJH",
      "destination": "17LV3y5KhExPdVcqS81zXuVUfNV9pmaGA",
      "asset": "GAMESOFTRUMP",
      "quantity": 1,
      "allow_unconfirmed_inputs": true,
      "fee": 9213
    },
    "jsonrpc": "2.0", "id": 0
    }' | python -m json.tool
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   691  100   375  100   316    199    168  0:00:01  0:00:01 --:--:--   367
{
    "result": "0100000001da83d841e286e1e7938a10af94813f8c645b9bde4ffbf95f65789c46967ea5a7010000001976a914191d1d4dda01b86d21aa2ba6e7e0e7daf29445b288acffffffff020000000000000000306a2e7b9360eb5e1cbcbb6b3a504c43160812fe45d10349efe6b7dfa109769aeb17d82e9d5b688669728a52a04c8e188e32aa4e01000000001976a914191d1d4dda01b86d21aa2ba6e7e0e7daf29445b288ac00000000",
    "id": 0,
    "jsonrpc": "2.0"
}

then using https://live.blockcypher.com/btc/decodetx/ with the result I get:
{
    "addresses": [
        "13Hnmhs5gy2yXKVBx4wSM5HCBdKnaSBZJH"
    ],
    "block_height": -1,
    "block_index": -1,
    "confirmations": 0,
    "data_protocol": "unknown",
    "double_spend": false,
    "fees": 9213,
    "hash": "36fb9c942ff444526c7fb313817915ad1fb13c3d1a5073ec6759304db5bfc232",
    "inputs": [
        {
            "addresses": [
                "13Hnmhs5gy2yXKVBx4wSM5HCBdKnaSBZJH"
            ],
            "age": 839224,
            "output_index": 1,
            "output_value": 21941807,
            "prev_hash": "a7a57e96469c78655ff9fb4fde9b5b648c3f8194af108a93e7e186e241d883da",
            "script": "76a914191d1d4dda01b86d21aa2ba6e7e0e7daf29445b288ac",
            "script_type": "pay-to-pubkey-hash",
            "sequence":<PHONE_NUMBER>
        }
    ],
    "outputs": [
        {
            "addresses": null,
            "data_hex": "7b9360eb5e1cbcbb6b3a504c43160812fe45d10349efe6b7dfa109769aeb17d82e9d5b688669728a52a04c8e188e",
            "script": "6a2e7b9360eb5e1cbcbb6b3a504c43160812fe45d10349efe6b7dfa109769aeb17d82e9d5b688669728a52a04c8e188e",
            "script_type": "null-data",
            "value": 0
        },
        {
            "addresses": [
                "13Hnmhs5gy2yXKVBx4wSM5HCBdKnaSBZJH"
            ],
            "script": "76a914191d1d4dda01b86d21aa2ba6e7e0e7daf29445b288ac",
            "script_type": "pay-to-pubkey-hash",
            "value": 21932594
        }
    ],
    "preference": "low",
    "received": "2024-04-15T10:51:53.135721691Z",
    "relayed_by": "<IP_ADDRESS>",
    "size": 167,
    "total": 21932594,
    "ver": 1,
    "vin_sz": 1,
    "vout_sz": 2,
    "vsize": 167
}

everything seems to be OK!
It appears to be an unconfirmed mempool and transaction issue but I can't do anything without at least having a rawtransaction that triggers this error.


Fixed one way to create an empty mask

Motivation and context
Because getDrawnObjectsWrappingBox returns incorrect [right, bottom] values in case if some shapes are drawn out of the image. See the gif:

Also it does not disable eraser and polygon-minus tools when it is necessary
How has this been tested?

Checklist

[ ] I submit my changes into the develop branch
[ ] I have created a changelog fragment
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (see GitHub docs)
[ ] I have increased versions of npm packages if it is necessary
(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)

License

[ ] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.38%. Comparing base (1a86ccd) to head (735a27b).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7915      +/-   ##
===========================================
+ Coverage    83.35%   83.38%   +0.02%
===========================================
  Files          380      380
  Lines        40024    40024
  Branches      3766     3766
===========================================
+ Hits         33364    33373       +9
+ Misses        6660     6651       -9

Components
Coverage Δ

cvat-ui
79.31% <100.00%> (+0.04%)
:arrow_up:

cvat-server
87.13% <ø> (ø)


Ts declarations

This PR contains a new round about Typescript declarations.

Currently declarations are not shipped via npm: the user still has to make the compilation locally to get the files. This is due to a line in git ignore which prevents committing the declaration folder located in ./dist/
Various improvements to declarations, mainly function parameters which had been wrongly typed previously. This collection of fixes comes from unwarranted typescript errors that were raised in a project I am working on. Notably: color parameter can be a string (was limited to numbers), autoview() can take a selection string as a parameter, labelText takes an array of strings,...

Issue with the cylinders solved (spurious testing code introduced has been removed)

Do you want me to make a release and check declarations get pushed?

Thanks for this!
Yes a release would be nice.
I think we can make 2.1 as we have the sdf v3000 new feature.

I've pushed 2.1.0-0 with the @next tag (i.e.npm install ngl@next). That seems to have packed the declarations in with it. Let me know if it's okay and I'll push it as 2.1.0 (latest tag)

Yes! I've done a quick test: create a new repository, npm install ngl@next, create a .ts file, and I can import from NGL modules and have all the typings at hand!
Thanks a lot! This actually concludes the TS migration initiated 5 years ago 💯

2.1.0 released


Switch from CURSORLESS_TEST to CURSORLESS_MODE environment variable

It can be either "test", "develop", or unset. If it is unset, it means production, because we don't have an easy way to set it in production and prob best not to have extra env vars in production just in case

[ ] We should also try to avoid using extension.runMode
[ ] We could also add an assert that extension.runMode is equal to CURSORLESS_MODE for sanity checking

Note that this is how it is done in our neovim support
See also https://github.com/cursorless-dev/cursorless/pull/2301

To bring a bit of clarification, in neovim our neovimIDE.runMode is actually returning the CURSORLESS_MODE environment variable

@saidelike what do you do in production? Will that environment variable be set?

The environment variable is not set in production, but internally we set runMode to "production".
  get runMode(): RunMode {
    const runMode = process.env.CURSORLESS_MODE;
    const ret =
      runMode == null
        ? "production"
        : runMode === "test"
          ? "test"
          : runMode == "development"
            ? "development"
            : "unknown";
    if (ret === "unknown") {
      throw Error("Invalid runMode");
    }
    return ret;
  }


Fixes for rendering of nested Output Widgets

Also added/enabeld some much needed IPyWidget tests

Codecov Report

Merging #10502 (8bbb050) into main (b821681) will decrease coverage by 12%.
The diff coverage is 80%.

:exclamation: Current head 8bbb050 differs from pull request most recent head 52d9dcd. Consider uploading reports for the commit 52d9dcd to get more accurate results

@@           Coverage Diff            @@
##            main   #10502     +/-   ##
========================================
- Coverage     71%      58%    -13%
========================================
  Files        467      467
  Lines      28073    28090     +17
  Branches    4736     4743      +7
========================================
- Hits       19944    16413   -3531
- Misses      6239    10092   +3853
+ Partials    1890     1585    -305

Impacted Files
Coverage Δ

...c/kernels/execution/cellExecutionMessageHandler.ts
62% <80%> (-11%)
:arrow_down:

...ve-window/debugger/jupyter/debugCellControllers.ts
23% <0%> (-74%)
:arrow_down:

src/kernels/debugger/kernelDebugAdapterBase.ts
6% <0%> (-73%)
:arrow_down:

...views/extension-side/variablesView/variableView.ts
18% <0%> (-72%)
:arrow_down:

src/interactive-window/interactiveWindow.ts
7% <0%> (-68%)
:arrow_down:

src/interactive-window/debugger/helper.ts
33% <0%> (-67%)
:arrow_down:

src/notebooks/export/exportToPythonPlain.ts
21% <0%> (-66%)
:arrow_down:

src/notebooks/debugger/kernelDebugAdapter.ts
20% <0%> (-65%)
:arrow_down:

src/interactive-window/helpers.ts
36% <0%> (-64%)
:arrow_down:

src/notebooks/debugger/runByLineController.ts
12% <0%> (-64%)
:arrow_down:

... and 203 more


Network details: container list is not working for Docker < 1.12

Description
I've pulled the current portainer/portainer:latest image from docker.io and started portainer on the same host via
/bin/docker run \
    --name portainer --rm \
    --net=nextcloud \
    -v /var/run/docker.sock:/var/run/docker.sock \
    -v /docker/portainer/data:/data \
    -p 9000:9000 \
    portainer/portainer

and connected it to the local endpoint. After setting the initial password for admin, I can see all networks and running containers without problem.
If I open details to a network, I can see the basic informations, but not the list of containers. It is empty.
Steps to reproduce the issue:

Run a container with a dash (minus sign) in its name, e.g. "foo-bar"
Go to "Networks" view
Klick on the name of a shown network
In the Network details view, look at the "Containers in network" area. There are no containers shown, even not the connected ones
Open the chrome developer tools and the console there
See the error message and stack trace:

TypeError: Cannot set property 'Id' of undefined
    at https://myserver.tld/js/app.48ab848b.js:26:10479
    at Array.forEach (native)
    at https://myserver.tld/js/app.48ab848b.js:26:10430
    at https://myserver.tld/js/app.48ab848b.js:7:24972
    at https://myserver.tld/js/app.48ab848b.js:3:4140
    at n.$eval (https://myserver.tld/js/app.48ab848b.js:3:11598)
    at n.$digest (https://myserver.tld/js/app.48ab848b.js:3:10148)
    at n.$apply (https://myserver.tld/js/app.48ab848b.js:3:11892)
    at i (https://myserver.tld/js/app.48ab848b.js:2:19224)
    at u (https://myserver.tld/js/app.48ab848b.js:2:21437)
    at XMLHttpRequest.y.onload (https://myserver.tld/js/app.48ab848b.js:2:21912)

If I inspect the Network tab in chrome developer, I can see the JSON answer from portainer which contains the array with all container connected to that network. So I suspect that there is a bug in the javascript code analyzing the JSON answer.
I suspect that at some point in the javascript code, the container name is used without "escaping" it via ticks.
If I stop the container with the dash in its name, the view with the containers of a network show up as expected.
Technical details:

Portainer version: 1.11.1
Portainer Docker image tag: latest
Target Docker version: 1.10.3
Target Swarm version: none
Platform: centos 7.3
Browser: Chrome v55 on Windows 7

Ok I've been able to reproduce this. It's not related at all to the fact that a container has a dash in its name. It is due to the fact that we use the network filter to retrieve the containers in the network via the Containers endpoint https://docs.docker.com/engine/api/v1.24/#/containers
Thing is, this flag has been introduced in Docker 1.12 (API version 1.24). So this bug will appear when accessing the network details view on Docker < 1.12.

Verified to work with docker 1.11.2 pulled from https://hub.docker.com/r/portainer/portainer/
Thank you @deviantony !


Fix ArrayIndexOutOfBoundsException in AliMissingOverrideAnnotationInspection

Related to #999
Add checks for empty arrays in AliMissingOverrideAnnotationInspection.kt to prevent ArrayIndexOutOfBoundsException.

Add a check for empty infos array before accessing elements in the buildFix method.
Add a check for null psiElement before calling buildFix in the manualBuildFix method.

For more details, open the Copilot Workspace session.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add XML docs to enhance discoverability in IDEs

Add XML docs to extensions, so that one can see what does given function do without the need to dig into docs. From the other side, XML docs can also be used do generate docs for the library's API.

Just started working on it.
Here is the first commit with documentation for Result structure https://github.com/pizycki/Monacs/commit/a2df319fb624332cc5c950b50661b91ff77efa26
I assumed that Result can become Success or Failure and that way I'd like to continue commenting the code. If you have any thoughts on this, please share.
The english might not be perfect, so if something doesn't sounds good and should be rewritten, point it out as well.

Good start 👍 I will add some comments to the commit, feel free to reply and point out good and bad ideas ;)
As for the ways to call the paths, I'm thinking of using the track naming, like "Result is on success track" or "Result is on error track" to indicate the path. Thoughts?
And don't worry about the language at this point, we can do final review once all is done and improve it if there will be such need :)

Cool, i'll continue working:)

I've added some sample docs in this PR, feel free to comment there as well and use it as an example.

Just updated Result doc in this commit https://github.com/pizycki/Monacs/commit/af1c9eaf6750b91d6c13059ef847931624bef22b

Updates in-code doc for Unit and Option.
I didn't want to document ErrorDetails as I'm not sure how it's supposed to work. I think I'll need some examples for this.

I've recently created develop branch where I will be merging changes in preparation for release. Please rebase your branch on it, there are some new docs merged there as well.
If you won't be sure what to put in the docs for some type or method you can leave it to me or put TODO in comments and we can work on it together when the PR will be created.

Documentation added in version 0.2.0 :)


Back-end TypeDefs

Below is a list of TypeDefs that we need set up on the back end. Type Query is already done, it just needs to be uncommented in typeDefs.js. Likewise, the addProfileImage mutation is already done. For the rest of them, I just left a comment to mark what we want to return with our typeDefs. You will have to add the datatype (String, Int, etc.) Refer to the models if you are unsure what datatype to use. Feel free to reach out with questions.
type PET

_id
username
email
petType
image
age
sex
bio
humanStatus
tails
friends
friendCount

type TAIL

_id
tailText
createdAt
petUsername
comments
commentCount

type COMMENT

_id
commentText
createdAt
petUsername

type Auth

token
pet

Type Query just needs to be uncommented
type Query {
me: Pet
pets: [Pet]
pet(petUsername: String!): Pet
tails(petUsername: String): [Tail]
tail(_id: ID!): Tail
}
type Mutation

login
addPet
addTail
addComment
addFriend
addProfileImage(imageUrl: String!): User          (add image is already done, it just needs to be uncommented)

They look good, thanks Dylan.


Move Client Code into an ops subdir

Purpose
Move client code into an ops subdir in prep for the repo merge
Changes

[x]  nest the client code into ops
[x]  update all path references
[x] update workflow tests

Checklist

[x] Update CHANGELOG.md file

[x] Merge in main so the most recent CHANGELOG.md file is being appended to
[x] Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
[x] Add a link to this PR at the end of the description with the PR number as the text. example: #1

[x] Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
If docs updated (select one):

[x] documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
[ ] documentation issue created (tag docs-team to complete issue separately)

[ ] Good unit test/integration test coverage
[ ] This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
[ ] The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket
Fixes #965

the meaningful files to review here are:

dockerfile
package.json
.dockerignore
docs files that got updated

This integration test failure is different than the flaky one from before, but the test was passing before and the latest change you made couldn't possibly make it fail. I wonder if this has turned up a new flaky test. I'm going to restart it to see what happens.


Develop

Coverage increased (+0.5%) to 96.825% when pulling 7e8b38981e3b9b412d734c2d10ce873e45f83358 on develop into<PHONE_NUMBER>2eb28daa996a4952b5de549c6c2749 on master.


Update README.md

In case you have multiple trusted network , or if other docker container  want to talk to the relay directly from the docker network

Thanks, nice call out!


encourage the creation of custom profile components

This PR updates ProfilePage to redirect to an accountId's custom profile page if it exists.

Was thinking about this more. Maybe this could use a wrapper (tabs?) such that the viewing user can switch between the custom profile component and the standard one? The standard one may serve as a source of truth about users.

@gabehamilton sounds interesting. But let's move this to the discussions, @charleslavon WDYT?

uh-mazing @charleslavon ! 💪 Thank you so much for putting some time in on your weekend off to hack on this! 🙏
@gabehamilton I like your idea for adding more options here (re: tabs/toggle) and also have some ideas as far as wanting to standardize some things on the profile page such as contact info, contribution graph, profile image, sponsor/tip button etc. This way the most common things people want to find are highly discoverable and people don't have to play "Where's Waldo" if they wanna reach out to a dev or tip them.
I'm a big fan of being Aglie and shipping small incremental improvements rather than blocking progress here. IMO we should ship this as is (or make a minor tweak if needed) and then think more deeply about this with the design team (@heycorwin @sarahmills)
cc @ravigautham


NaN cannot be represented in JSON

NaN values cannot be represented in JSON. The python module json creates NaN literals in JSON
by default, but they are not compliant with the JSON standard.
In the past, I used a special JSON encoder from bokeh which creates "NaN" instead. This was then
correctly parsed in bokehJS.
Now this encoder is not available any more and the question is, whether it's now okay to allow NaN in JSON
because bokehJS can deal with it or what should be done here.
Probably this will resolve automatically, when we can switch to a stable bokeh version 3.x.x (probably 3.1),
because according to this Migration guide nan, inf and -inf can be serialized then.

This issue describes the problem well.
We cannot switch to a stable bokeh 3.x.x until this is available
through bokeh 3.1.


Extra dataset metadata

The trade portal introduced some extra metadata terms using http://gss-data.org.uk/def/metadata/ontology:
@prefix :      <http://gss-data.org.uk/def/metadata/> .
@prefix dct:   <http://purl.org/dc/terms/> .
@prefix rdf:   <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
@prefix rdfs:  <http://www.w3.org/2000/01/rdf-schema#> .

:status  a                rdf:Property ;
        rdfs:isDefinedBy  :ontology ;
        rdfs:label        "Status" .

:source  a                rdf:Property ;
        rdfs:isDefinedBy  :ontology ;
        rdfs:label        "Source" .

:recommendedUsage  a      rdf:Property ;
        rdfs:isDefinedBy  :ontology ;
        rdfs:label        "Recommended usage" .

:ontology  a        <http://www.w3.org/2002/07/owl#Ontology> ;
        rdfs:label  "COGS metadata terms" ;
        dct:title   "COGS metadata terms" .

:weaknesses  a            rdf:Property ;
        rdfs:isDefinedBy  :ontology ;
        rdfs:label        "Weaknesses" .

:strengths  a             rdf:Property ;
        rdfs:isDefinedBy  :ontology ;
        rdfs:label        "Strengths" .

We should add a class for these terms so that an engineer can add extra metadata in a notebook and further so that we could encode these properties in info.json and add it to the dataset metadata.

Closing this as we'll have our application profile decided on soon, we can't do anything until that's complete.


Can't install svelte-slidy through yarn

When I try to install svelte-slidy through yarn, I get the following error:
error https://registry.yarnpkg.com/svelte-slidy/-/svelte-slidy-2.7.1.tgz: Extracting tar content of undefined failed, the file appears to be corrupt: "ENOENT: no such file or directory, open 'C:\Users\Username\AppData\Local\Yarn\Cache\v6\npm-svelte-slidy-2.7.1-7cd8cac2d1b16a2f4298d37f2dc3bd5d6d0354f8-integrity\node_modules\svelte-slidy\Icon\r'".
Is there a way to fix this?

I'm haven't Windows system for testing your error...
But on unix-like system command yarn add -D svelte-slidy works good🤷🏻♂


Zoho Book Conflicts with python3

I am trying to use the zoho books with python3. But there are lot of conflicts. Tired resolving a few but looks like its endless. Can I have python wrappers compatible with python3 also?

Did you check https://github.com/deepubansal/books-python-wrappers ?

I used the GitHub repo that you suggested. But I am getting this error.
`import os,sys
sys.path.append('./books')
from config import *
from books.model.Organization import Organization
from books.model.Address import Address
from books.api.OrganizationsApi import OrganizationsApi
from books.service.ZohoBooks import ZohoBooks
organizations_api = OrganizationsApi("auth_token", "org_id")
print (organizations_api.get("org_id"))
`
Error:
URL: https://books.zoho.in/api/v3/organizations/60009660202?organization_id=org_id Traceback (most recent call last):   File "test_zoho.py", line 19, in <module>     main()   File "test_zoho.py", line 15, in main     print (organizations_api.get("60009660202"))   File "/home/dell/xyz/testing/zoho_books/books/api/OrganizationsApi.py", line 55, in get     resp = zoho_http_client.get(url, self.details)    File "/home/dell/xyz/testing/zoho_books/books/util/ZohoHttpClient.py", line 36, in get     resp, content = http.request(url, 'GET', headers=headers)   File "/usr/lib/python3/dist-packages/httplib2/__init__.py", line 1313, in request     (response, content) = self._request(conn, authority, uri, request_uri, method, body, headers, redirections, cachekey)   File "/usr/lib/python3/dist-packages/httplib2/__init__.py", line 1063, in _request     (response, content) = self._conn_request(conn, request_uri, method, body, headers)   File "/usr/lib/python3/dist-packages/httplib2/__init__.py", line 986, in _conn_request     conn.connect()   File "/usr/lib/python3.7/http/client.py", line 1422, in connect     server_hostname=server_hostname)   File "/usr/lib/python3.7/ssl.py", line 423, in wrap_socket     session=session   File "/usr/lib/python3.7/ssl.py", line 870, in _create     self.do_handshake()   File "/usr/lib/python3.7/ssl.py", line 1139, in do_handshake     self._sslobj.do_handshake() ssl.SSLError: [SSL: TLSV1_ALERT_PROTOCOL_VERSION] tlsv1 alert protocol version (_ssl.c:1076)

I had got this error while using this repo also


디자인에 맞게 마이너한 수정

🤔 해결하려는 문제가 무엇인가요?
디자인에 맞게 마이너한 수정
🎉 변경 사항

질문 tag 높이 수정
input placeholder 색상 수정

Codecov Report
Patch and project coverage have no change.

Comparison is base (b75112d) 91.92% compared to head (f22a652) 91.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #236   +/-   ##
=======================================
  Coverage   91.92%   91.92%
=======================================
  Files          38       38
  Lines         285      285
  Branches       52       52
=======================================
  Hits          262      262
  Misses         23       23

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Allow templateUrl and styleUrls to exclude path

As per our discussion with @wardbell @Brocco and @filipesilva , we'd like to make the CLI be comfortable when a module.id exists in the @Component( ... ) decorator such that the url properties can simply be the name of the file. Examples that should work:
// no module.id
@Component(
  templateUrl: './foo.html'
) export class FooComponent { ... }

@Component(
  // module.id and just a file name, defaults to ./
  moduleId: module.id,
  templateUrl: 'foo.html'
) export class FooComponent { ... }

@Component(
  // module.id and uses the existing specified path /.
  moduleId: module.id,
  templateUrl: './foo.html'
) export class FooComponent { ... }

Webpack's loader-utils helper methods urlToRequest and stringifyRequest should probably be used in _replaceResources inside the CLI's loader.
I was looking at putting a PR together awhile ago but haven't had time.

Per conversation with @hansl, we should prepend ./ unless there is a /, regardless of moduleId.

That's essentially what the helper functions do. Plus support the webpack specific tilde which would most likely be expected if the loader is used independently of the CLI.

@clydin coolio, I'll use them then. I wasn't too familiar with those helper so I appreciate the explanation.

@filipesilva , Whether moduleId is present or not, 'foo.html', '/foo.html' & './foo.html' will point to the same file and will be bundled. Am i right?

@CarreraPHP /foo.html and ./foor.html are different. Consider you have src/app/one/two/folders/foo.ts and `src/tsconfig.json'.

/foo.html is src/foo.html
./foo.html is ``src/app/one/two/folders/foo.html`

That is the difference.

@filipesilva , Thanks for the clarification. '/foo.html' is not the way angular style guide suggests and not the way angular-cli generates files so couldn't realise this basic path concepts. However, the confusion came up due to the way static resources like images are referenced relative to the folder that contain the html template file (don't know if this is not the way it is done currently, the angular-cli version i used at that time was beta.17).

@CarreraPHP I actually gave you some bad information there: that example only applies to AoT compilation. JiT does not have access to tsconfig, so / will be the value of the <base> tag href property.
In the CLI we always inline styles and templates so we go by AoT rules.


Add remark feature

this is how the UI look like:

I limit the length of remark to 150 characters long, longer the 150 is invalid remark.
If there is no remark, UI will show "No remark"

Is it better to not show the remark card if there is not remark?

Do you plan to update the output display when adding a person with remarks? Currently when we use the add command, the output will not show information about the remarks. However, remarks tend to be lengthy and I am not very sure should we show it in the output. What do you think?


Regarding T28 fitness sensor

Hi Mark,
I would like to buy T28 fitness tracker just for the GPS sensor and Temparature sensor. Are you able to get any info from these sensors? Any recommendations on where to buy these fitness sensors from Europe?

Sorry for the delay. I bought mine from aliexpress. I believe gearbest also sell them. Lemdoie is just one of the brands, i searched for gps smartwatch from memory.
The gps is a simple serial ublox device, so a library like tinygps will work. The pinout is in the t28 variant.h. Check out my last commit, I'm pretty sure one of my changes was in the comment on those pins.
I'm pretty sure the temperature is on the nrf52. Should be easy to find (look at sandeeps repo), but i wouldn't trust it. I have two watches that have temperature, neither was cheap and they are both very inaccurate

Thanks for the info. I think you mentioned that there is a separate temperature sensor HP203B. Hope it works. I will order this one.

Ah yes, i forgot about that. Just a heads up that the software i2c library is a little broken. Its not throttled and doesn't work with some devices. The hp203b will still work hardware i2c (need to modify variant.h pins), I just can't remember if it works for the software i2c.
I was planning to look at stm32duino repo as that has a software i2c library that should work

Okay, great. I will test my luck.

It looks like the t28 is getting harder to get. @curtpw - can you recommend a watch with gps and temp sensor? I noticed you have rev engineered a lot of the new colour screen watches.

I found a t28 https://s.click.aliexpress.com/e/bBTPQ1nL
I searched aliexpress for "gps nordic"
This one might be worth trying?
F18 - https://s.click.aliexpress.com/e/bXxxKRqp
Colour round oled, nrf52832, optical hr and apparently has gps. The back cover unscrews too


Support dot notation

Because of some other libraries I'm used to use a.b as a key. This change adds support for keys with a dot notation.
Any objections? :)

This reminds me of underscore's _.getPath() or lodash's _.get(). I'll probably merge this.
Would you like to write a unit test for it?

Merged at 7fb430f7158753f0dd5e0143123c1f2e57706d13
Thanks for the code!


Provide minimized stack lines

Using the function name only method for minimization results in a
function with two different malloc related bugs to get bucketed
together.
This provides a minimized stack without function address of stack depth.
For entries without source information, such as:
# 34 0xf19113f in ChromeMain+0x13f (C:\\clusterfuzz\\bot\\builds\\chrome-test-builds_media_win32-release\\revisions\\asan-win32-release-335593\\chrome_child.dll+0x113f)
users will see this:
ChromeMain+0x13f
For entries with source information, such as:
# 20 0x58bd3bb in v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) ../../v8/src/builtins/builtins-api.cc:137:5
users will see this:
v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) builtins-api.cc:137:5

Will review this after conflicts resolved; please tag me in when ready!


Operating systems supported by the project

I'd like to ask if the only operating system supported by this program is linux.

to be honest, I only build and run this project on ubuntu.

Traceback (most recent call last):
File "C:\Users\lees_\PycharmProjects\SVG_Render\SVGDreamer\svgdreamer.py", line 17, in
from svgdreamer.pipelines.SVGDreamer_pipeline import SVGDreamerPipeline
File "C:\Users\lees_\PycharmProjects\SVG_Render\SVGDreamer\svgdreamer\pipelines\SVGDreamer_pipeline.py", line 23, in
from svgdreamer.painter import (CompPainter, CompPainterOptimizer, xing_loss_fn, Painter, PainterOptimizer,
File "C:\Users\lees_\PycharmProjects\SVG_Render\SVGDreamer\svgdreamer\painter_init_.py", line 5, in
from .painter_params import (
File "C:\Users\lees_\PycharmProjects\SVG_Render\SVGDreamer\svgdreamer\painter\painter_params.py", line 15, in
import pydiffvg
ModuleNotFoundError: No module named 'pydiffvg'

How do I fix this? :(

This error means that your python environment has not successfully installed pydiffvg. If you want to reproduce this project, you'd better make sure that your computer is a linux system first, because some python libraries are only available in linux versions.

请叫我老pai
@.***

------------------ 原始邮件 ------------------
发件人: @.>;
发送时间: 2024年7月31日(星期三) 上午9:29
收件人: @.>;
抄送: @.>; @.>;
主题: Re: [ximinng/SVGDreamer] Operating systems supported by the project (Issue #15)
Traceback (most recent call last):
File "C:\Users\lees_\PycharmProjects\SVG_Render\SVGDreamer\svgdreamer.py", line 17, in
from svgdreamer.pipelines.SVGDreamer_pipeline import SVGDreamerPipeline
File "C:\Users\lees_\PycharmProjects\SVG_Render\SVGDreamer\svgdreamer\pipelines\SVGDreamer_pipeline.py", line 23, in
from svgdreamer.painter import (CompPainter, CompPainterOptimizer, xing_loss_fn, Painter, PainterOptimizer,
File "C:\Users\lees_\PycharmProjects\SVG_Render\SVGDreamer\svgdreamer\painter_init_.py", line 5, in
from .painter_params import (
File "C:\Users\lees_\PycharmProjects\SVG_Render\SVGDreamer\svgdreamer\painter\painter_params.py", line 15, in
import pydiffvg
ModuleNotFoundError: No module named 'pydiffvg'
How do I fix this? :(
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

okay i am installing ubuntu-desktop through wsl and everything else necessary, if i follow the same instructions but inside of ubuntu-desktop it should work?

Of course, if your computer has a gpu graphics card, everything is fine.
请叫我老pai
@.***

------------------ 原始邮件 ------------------
发件人:                                                                                "ximinng/SVGDreamer"                                                                                @.>;
发送时间: 2024年8月1日(星期四) 上午8:24
@.>;
<EMAIL_ADDRESS>主题: Re: [ximinng/SVGDreamer] Operating systems supported by the project (Issue #15)
okay i am installing ubuntu-desktop through wsl and everything else necessary, if i follow the same instructions but inside of ubuntu-desktop it should work?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

hi i am on linux ubuntu 20.04 i did the docker install thing and this is what i got:
Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error running hook #0: error running hook: exit status 1, stdout: , stderr: Auto-detected mode as 'legacy' nvidia-container-cli: initialization error: load library failed: libnvidia-ml.so.1: cannot open shared object no such file or directory: unknown.

hi i am on linux ubuntu 20.04 i did the docker install thing and this is what i got:
Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error running hook #0: error running hook: exit status 1, stdout: , stderr: Auto-detected mode as 'legacy' nvidia-container-cli: initialization error: load library failed: libnvidia-ml.so.1: cannot open shared object no such file or directory: unknown.

Hi, I don't have that problem.
I think it may be because docker does not support Nvidia, can you confirm that your docker supports GPU calls?

hi i was using linux ubuntu 20.04 on windows 11, i am now using LTS ubuntu linux 24.04, it seems when i run the docker image or install shell script, i am missing a lot of requirements before it, like cmake, nvidia gpu stuff, and other things :( is there a list of things i need to do my linux install before running the install.sh or running the docker image ?? sorry for all the messages i am dying trying to get this installed

hi i was using linux ubuntu 20.04 on windows 11, i am now using LTS ubuntu linux 24.04, it seems when i run the docker image or install shell script, i am missing a lot of requirements before it, like cmake, nvidia gpu stuff, and other things :( is there a list of things i need to do my linux install before running the install.sh or running the docker image ?? sorry for all the messages i am dying trying to get this installed

I understand how you feel, and I want to help you. But I need more information.
For example, what happens when you run install.sh?
Can you give me some screenshots or error messages?


python312Packages.govee-local-api: 1.5.1 -> 1.5.2

Diff: https://github.com/Galorhallen/govee-local-api/compare/refs/tags/v1.5.1...v1.5.2
Changelog: https://github.com/Galorhallen/govee-local-api/releases/tag/v1.5.2
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 341461 at 1e32d722 run on aarch64-darwin 1

2 packages built successfully:

python311Packages.govee-local-api
python312Packages.govee-local-api


Imageinfo - add more constructors

Description of Change
Adds some more ctor overloads.
API Changes
None.

Behavioral Changes
None.

Required skia PR
None.
PR Checklist

[ ] Has tests (if omitted, state reason in description)
[ ] Rebased on top of main at time of PR
[ ] Merged related skia PRs
[ ] Changes adhere to coding standard
[ ] Updated documentation

@dotnet-policy-service agree


how to use dbContext.Database.BeginTransaction()?

i like this architecture ,i want to know use dbContext.Database.BeginTransaction()? in domain

@wanghaoxing interesting idea and will look at this

@wanghaoxing I looked at DBContext Transactions https://docs.microsoft.com/en-us/ef/core/saving/transactions and I am not doing anything that would need transactions. I would use them when I add the ability to save associated data for an entity type.


Setting initialValue to Zero does not work

<Slider min={0} max={40} step={1}
                        valueOnChange={value => setValue(value)}
                        initialValue={1}
                        knobColor='red'
                        valueLabelsBackgroundColor='black'
                        inRangeBarColor='purple'
                        outOfRangeBarColor='orange'
                    />

With the above, when I drag the slider more than 10, it bounces back to Zero.
I do not understand why this is happening. If I set it back to 12 as the initial value, it works well.

@AnatuGreen sorry but couldn't reproduce. does it still happen?
if yes, which platform - android/ios/both?


Fix for invalid escape sequences in strings

Regular expressions containing invalid escape sequences should avoid
the normal escape sequence replacement using raw strings (r'...')
The replacement for regex is quite different from the usually used.

Thanks @set-soft, you are doing a great job with revision and those fix.


[DO NOT MERGE] Remove error handling

https://trello.com/c/Uzpw1bDA/243-document-how-error-pages-work-on-govuk
Depends on: https://github.com/alphagov/email-alert-frontend/pull/774
This reverts https://github.com/alphagov/slimmer/pull/243, and removes all other error
handling code, since the end result is discarded in favour of
generic error pages rendered by our infrastructure.

Adding a "DO NOT MERGE" warning.
Removing this will mean we are missing (albeit at least more correct!) error pages for: 405, 429, 499, 409. 401 and 426 are also missing, but probably not worth bothering with.
Of these:

499 is unnecessary, as the client closed the request
405 can be similar to our current 403
401 can be similar to our current 403
429 is for rate limiting (new page)
409 is unnecessary, as it's internal only (conflict)
426 is only handled at the Nginx level


Arrow thing

Describe your problem here.
How do I do the Disruption arrow thing? Here is a video:
https://www.youtube.com/watch?v=9RM48cXVj4k&t=8s
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No, i didn't

use the tween stuff

What's that? Idk how to code.

What's that? Idk how to code.

in the wiki go to the tweens and timers thing

I read it but I still don't understand.

come back when you learn how to code lua

There isn't a function in Lua to do this, you'll have to edit some stuff in the code to do this. I am working on adding these functions to Lua scripting.

I don't know how to do this in Haxe completely yet

Oh, ok

Oh, ok.

there is

There isn't a function in Lua to do this, you'll have to edit some stuff in the code to do this. I am working on adding these functions to Lua scripting.

there is ya doughnut XD tweens and timers
https://github.com/ShadowMario/FNF-PsychEngine/wiki/Lua-Script-API:-Tweens-and-Timers
just put a 0.00001 duration and linear tweening method thing then in will be instantanious


Add ability to resend verification email

If the user is trying to upload a survey with an unverified account we currently show a warning to click on the verification email first. It can happen that the user has registered a while ago and so the verification email might have been deleted from the email account by then.

From #78

If there is any way of priorotising this I would be really grateful. We have about 100 blocked users at the moment. I just tried to do a bulk unblock but that doesn't seem to have worked: "The application did not respond in time."
@CCarvell for info.

@kazlauskis Martin is on leave this week but this is an urgent issue that needs to be resolved quickly if possible please.
I'm not sure I can do much to help?
I was going to put a short Tweet out to report that we have having technicall issues with app registration but would like to know a bit more first, and also cannot deal with a flood of enquiries myself today!
@kazlauskis let me know if a quick chat would help?
Example email to poms from Website Feedback:
I have tried to reset my FIT count app but keep  getting no response. I had posted several datasets ok but these have been wiped out.
Please can you sort this out?
With thanks
Kit Welchman
P.S. i think I now have 2 accounts -<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Neither of which work for FITcount.
I have tried  changing my password severaltimes

Yes, the website might be failing to send the registration emails so we should investigate that area first.

OK @kazlauskis glad you have seen this! Do you mean yes to a quick chat or yes to investigating the website emails issue yourself now?

Sorry, I am in meetings all day today but I am free after 6pm. I wouldn't have the capacity to investigate the server email issues now, but Biren has set it up so he should be able to look into this.

@kazlauskis & @CCarvell Email works fine but this is to do with users already registered in the warehouse. so they don't email if they have already registered in the warehouse.

@kitenetter @BirenRathod I have responded with several points under #114 on the PoMS website GitHub - this all seems to be linked. Also this just happened:
I just logged out of my app account and back in again.
Now I cannot see any of my Uploaded surveys showing on the app - it says "No uploaded surveys". This seems to be the same as for Kit Welchman above who said "I had posted several datasets ok but these have been wiped out." and " i think I now have 2 accounts"
Do we have a major issue with the app and Warehouse account/s registration here?

Any data, including the uploaded surveys, will be removed from the device after the user logs out or reinstalls the app. When logging out there is an option to leave the local data - uncheck the 'Discard local data' checkbox.


Upgrade packages such as eslint

Upgrade packages such as eslint to fix some security vulnerabilities detected by npm.
In the process of upgrading eslint, had to change some code so that it confirmed with https://eslint.org/docs/rules/no-prototype-builtins. This has the side effect that, for example, a schema can now have a property called hasOwnProperty and not break rjsf.

Hello @epicfaace ,
I would suggest to update to the latest eslint, and inside the travis runner, specify to use the latest version for the lint (as we want to support node 6 for end-users, not for developpers of rjsf).
That is what I do for another project of mine for about a year or more to continue testing on "older" nodejs versions but still be able to use eslint or tooling that works only on newer versions : https://github.com/open-xml-templating/docxtemplater/blob/master/.travis.yml
There is the magic command : - nvm use $TRAVIS_NODE_VERSION which allows me to use the base travis node version after doing the linting and running babel.


Providing interface for setting up QED symbol

Hello! Thanks for your excellent work. I am considering switching from ntheorem to create-theorem, since with the former package the adjustment of any theorem-like environment can only be done by redefining it.
However, there is one major feature that I believe is absent from create-theorem, the QED symbol, which is particularly useful in proof environment and has already been implemented by many of the package's counterparts. Therefore, would you please add the above-mentioned feature?
A desired example may look like
\CreateTheorem{proof}{
    name = {
        heading = {证明}
    },
    numberless,
    qed-symbol = {\ensuremath{\QED}} # new interface
}

Thank you for mentioning this, indeed a good suggestion :)
When I created this package, there was already built-in setup for QED symbols in my own document class so I didn't think about it. I shall adopt your syntax but this might take a day or two to be done.
Also, taking advantage of this opportunity, I suggest that one could define in the same time two more environments, say with a + sign, for usual theorem-type environments (say proposition), for example, proposition+ and proposition+*, for numbered and unnumbered proposition environment with a QED symbol, which are for those propositions without proof in the document. But this is not a final decision, I would like to hear your opinion about it (especially on the syntax).

This has been achieved in Update 2022-05-31 (b2f3e92c120fd86e2a3d9d19c1dbee11db69655b).
Note that:

The key is named as qed, but qed-symbol also works.
You can directly use the key qed-symbol without specifying its value, the default would be \qedsymbol.
I have already added \ensuremath in the code. If you wish to use regular text, you shall have to write \mathrm (which is actually a good thing as text in \mathrm shall not be affected by the surrounding text style).

As for my suggestion above, after some consideration, I decided to left it to the users. It's not hard, by the way, the following two lines will work (provided that proposition and proposition* is already defined):
\CreateTheorem { proposition+ } { copy-existed = proposition, qed }
\CreateTheorem { proposition+* } { copy-existed = proposition*, qed }

I am totally astonished at your efficiency. Honestly during the last few hours I was still hesitating about how the syntax should look like.
Thanks for the enhancement anyway : D


Update TUSD LOGO

Update TUSD LOGO

Hi @RandomGly - sth is wrong with this logo - can you fix/update, please? https://github.com/MetaMask/contract-metadata/blob/905324583cfb4154cc423a25b78d921589c0c2aa/images/tusd.svg

@RandomGly if you have access to updated logotypes - can you add all TrustToken products? https://www.trusttoken.com/products to this repo?

@RandomGly if you have access to updated logotypes - can you add all TrustToken products? https://www.trusttoken.com/products to this repo?
https://trueusd.medium.com/scaling-trust-announcing-tusds-next-stage-of-growth-f1fb58d62b
https://www.trusttoken.com/  change  https://www.trueusd.com/

https://www.trueusd.com/ update TUSD LOGO

Hi @RandomGly - in this repo we require SVG images. Please change the uploaded PNG to SVG one

Hi @RandomGly - in this repo we require SVG images. Please change the uploaded PNG to SVG one

It's OK this time

You have to rename TUSD.svg to tusd.svg or update JSON

You have to rename TUSD.svg to tusd.svg or update JSON

Ok Thank you!  Update completed

You have to rename TUSD.svg to tusd.svg or update JSON

Ok Thank you! Update completed
MetaMask Wallet's TUSD logo not update

MetaMask Wallet's TUSD logo not update

Hi @RandomGly you have to wait for the release in this repository and then release of new MM version - this can take 2-3 weeks from now.

Hi @RandomGly you have to wait for the release in this repository and then release of new MM version - this can take 2-3 weeks from now.

Hi @RandomGly you have to wait for the release in this repository and then release of new MM version - this can take 2-3 weeks from now.

Ok Thanks!


Quick Accent activation method is dreadful (for first timers and power users)

Description of the new feature / enhancement
The two existing activation keys are:

Key + Space within X delay.
Key + Left/Right Arrow within X delay.

The problems:
Key + Space within X delay:

If the delay is too short, there's a chance you can trigger accent causing the following output:
Expected:
hello my name is mario
Got:
hellómy naméiímario
If the delay is too long, because your typing speeds and/or method varies, then you end up with a huge disruption to the flow when writing. Oddly timed pauses, here and there, trying to get the accent to work.

Key + Left/Right Arrow within X delay:

If the trigger is too short you might not reach the key.
The key forces you to move your hand around (depending on the keyboard).

My conclusions:
The current implementation:

Places too much burden on the user.
When things go wrong, it's very disruptive. And due to the human element quite "random", almost "buggy" at times. (Note the many issues mentioning variations of this with other words, sometimes reported as bugs)
When things go right, you have to wait, you have to rush, or that's what it feels anyway. Should I hold the key a bit longer? Am I going too fast? Too slow? Again, burdening the user.

An ideal implementation would:

Not get in the way of the user typing. You shouldn't be surprised when you type the same phrase you have typed all your life, just to find out you have a tendency to hold spacebar a bit longer, or an equivalent.
Not require the user to move the hand away from what they are doing in the given moment (typing, not editing)
Be able to use it multiple times in a single sentence and word, without disrupting the writing speeds (mid word for example).

Scenario when this would be used?
This scenario applies to every single user using this feature. Bringing benefits to all, from first timers to power users.
For first timers a better implementation would prove to be a less frustrating experience. Allowing the user to adopt it without the burden it currently has.
Supporting information
No response

I think instead of the arrow keys or the space bar the default key for activation should be the left alt/option key.  This would also be consistent with the keybind some other accent typing apps use, and avoids the problems that are commonly faced when using the arrow keys or the space bar as the activation key, that the creator of this issue has already elaborated on.

Another possibility is simply to hold the key down as one would do on a smartphone or macOS.
The current convention of repeating a letter when holding a key down has its origin all the way back to electronic typewriters. We have copy/paste and several other features today. There is no reason that holding down a key should repeat a letter anymore.

PeterBrodersen

What about video games though? One can't practically blacklist all video games from Quick Accent before playing them, but without blacklisting them the quick accent window at the top would appear randomly while playing video games. It is common for many video games to require the player to hold down many keys at once, some of which may be accent-able characters like e or i.

I am not entirely sure about what the proper solution is just yet as I have not put a lot of thought into it; however, I have put a lot of thought about what shouldn't happen with the solution:

The user should not be surprised when performing a common action, this is a bad experience, especially for something that affects the bandwidth between the human and the computer.

It should not depend on timers or holds, as they affect the bandwidth in which the issue inputs content. Slow typists and Fast typists should be able to work with the same system without having to tinker with timers.

I think instead of the arrow keys or the space bar the default key for activation should be the left alt/option key. This would also be consistent with the keybind some other accent typing apps use, and avoids the problems that are commonly faced when using the arrow keys or the space bar as the activation key, that the creator of this issue has already elaborated on.
This key is easily reachable by users when they want to use the quick accent feature, unlike the right/left arrow keys which require one to either switch hands or move their hand to the other side of the keyboard. Very inconvenient.
Unlike the space bar, the alt/option key is also not very commonly used, preventing users from accidentally typing in accented characters when they just meant to use the space bar. Users of the other accent typing apps that I already talked about could also more easily adjust to using Microsoft PowerToys if it were using the keybind they're already used to.
One last thing, and slightly unrelated, but the option to customize the activation keybind should be made available to the user. The same 2 options cannot suit everybody's needs

I believe that one of the reasons why alt + letter is not used is because it would collide with "native functionality" for example, notepad Alt + letter; however, I do agree that this would be the ideal solution as it would allow for interoperability for the user.

I believe that one of the reasons why alt + letter is not used is because it would collide with "native functionality"

Ah, that appears to be a major flaw with my suggestion. I think that the best way to resolve it would be to instead use the right alt key. As far as I know, the file-edit-format-view-help toolbar isn't triggered when using the right alt key. I just tried it out with Notepad, Notepad++ (scintilla), and Anki (Qt) and the right alt key does not trigger that particular menu in those apps.
I don't know if Apple keyboards have two option keys though. And some non-tech savvy users may get confused and try using the left alt key instead, and they may get frustrated with it. I know PowerToys is advertised to power users but I think a lot of its features would help a lot of regular Windows users who may not be very tech savvy, and features should be designed while also keeping them in mind.

PeterBrodersen

What about video games though? One can't practically blacklist all video games from Quick Accent before playing them, but without blacklisting them the quick accent window at the top would appear randomly while playing video games. It is common for many video games to require the player to hold down many keys at once, some of which may be accent-able characters like e or i.

This is already an issue in video games with the current implementation. Blacklisting them automatically as suggested in #27643 might offer a solution.

Another possibility is simply to hold the key down as one would do on a smartphone or macOS.
The current convention of repeating a letter when holding a key down has its origin all the way back to electronic typewriters. We have copy/paste and several other features today. There is no reason that holding down a key should repeat a letter anymore.

I'd personally love to see this, at least as an option. I miss this feature a lot from macOS and I was hoping Quick Accent could provide a similar experience.

My only issue with the hold key to output is that if it's released as the default it has some of the same issues as the original, where failing timings become an exercise in a loop of: Waited too long -> Didn't wait enough -> Backspace. Too much burden on the user, prone to surprises.
As for interesting ideas that could work based on what has been mentioned in this thread:

Providing the user with the option to use ALT + ( LEFT, RIGHT or EITHER ) to enter the accent mode, to let the user define what key they want to "sacrifice" and use for accents.
The mechanism works as follows:

Something like that would allow for:

Type as fast or slow as you want, no delays: Right Alt + e <released> is always the first item in accent list (or most used depending on configuration).
Find a specific accent without wait, just dance: Right Alt + e + e + e is always the third accent in list.
Allows back and forth navigation of the accent list with repetitions.
Allows for existing functionality to exist, doesn't happen often in my language, but allowing users to repeat the key, like: quéééééééééééééééééééééééééé
Let the user keep one Alt intact, letting the user define their accessibility needs. Can't be bothered to blacklist things? Use Right Alt, and have that awareness. Added bonus is that you now can use accents in online games.

Hope this helps guide the discussion and implementation one day.

@MarioRicalde
See my lengthy blogpost about this issue and my provided solution.

It doesn't look like this will ever get addressed. Are there any forks where they just replaced the spacebar with some other activation key, or let you pick it yourself? Almost anything else would be better.

Right Alt (labelled "Alt Gr" in German keyboards) would be quite handy indeed. It's a commonly used key in ISO-DE layouts, because it is required to type: @, €, {, }, [, ], ~.
I use quick accent, because I am German speaking, but use ANSI keyboards for programming. Still, I do have to type German in chat and email. Switching back and forth with Win+Space is confusing, because y and z switch places and the special symbols are all in different places. Also I can't type < and > using an ANSI keyboard in German language mode, because that is mapped to a key that just doesn't exist in ANSI.
The current solution in quick accent with key+space is however only just a bit less annoying. Right Alt in ANSI layout seems like a perfect fit for a modifier key. Also if right Alt + e would produce a €.


regarding checkpoints issue

my model got stopped middle but i got some checkpoints , how can i convert that to model.safetensors ?

You can use resume_from_checkpoint and train for 1 epoch.