Idea for GPU support

I have most of the scripts done to support two different DLLs even on .NET Core and .NET Framework - duplicating every entry point.
Should I deliver the GPU libraries as a separate package?   Or should it just have all batteries included?

For applications on a PC with lots of HDD I don't think it matters.  Where it might be important is if the library is used on an embedded device with memory constraints.

tensoflowsharp-gpu would be a simple way to highlight that it supports gpu and mirrors the tensorflow and tensorflow-gpu layout on python. the gpu package still requires setup of cuda and cudnn.

Hi Miguel, did you came up with a solution regarding the distribution of the package?

I have not, sadly the state of art on this area is quite primitive.   There might be a way to do this with .NET Core:
We can get some inspiration from:
https://github.com/Microsoft/workbooks/pull/305/commits/d6a6f7b0be09b99dcd945bf0df2fd9f4d7f8d6aa

If possible, there should be a TensorFlowSharp.Graph package that includes the common classes for graph creations, and dedicated packages for sessions: TensorFlowSharp.CPU, TensorFlowSharp.GPU, and eventually TensorFlowSharp.TPU or TensorFlowSharp.Interactive.

@migueldeicaza  I have created build automation to download&extract assemblies from official pypi site and published them separate nuget packages, it works with sample projects in tensorflowsharp
https://www.nuget.org/packages/tensorflow-batteries-windows-x64-cpu/
https://www.nuget.org/packages/tensorflow-batteries-windows-x64-gpu/

One thing to consider here is how to enable library authors to target TensorFlowSharp without restricting any consumers to either the CPU or GPU versions. If there were separate TensorFlowSharp.CPU and TensorFlowSharp.GPU Nuget packages, a library targetting TFS.CPU wouldn't be able to be consumed by someone using TFS.GPU.
My proposed solution would be,

TensorFlowSharp.Shared: containing all .NET code for the project, but no native tensorflowlib binaries.
TensorFlowSharp.CPU: contains only native tensorflowlib CPU binaries and has a NuGet dependency on TensorFlowSharp.Shared
TensorFlowSharp.GPU: contains only native tensorflowlib GPU binaries and has a NuGet dependency on TensorFlowSharp.Shared

If you were writing an executable then you would reference either of the CPU/GPU packages, and it will just work (NB: this assumes that there will never be a requirement to switch CPU/GPU versions at runtime?)
Library authors could target TensorFlowSharp.Shared. You wouldn't be able to execute these directly, but could be referenced by any other projects (other library projects, as well as exes targetting both CPU and GPU).

The problem with the approach of having two sets of NuGet packages is that the project ends up taking a dependency on the package.
The route that I want to take is to use an approach similar to what GRPC for .NET does, that is, it dynamically loads the proper library and calls to it via a trampoline.   This would allow users to set a flag at startup and choose CPU or GPU and we could make this default to the right one.
There is a branch with the loader code, but there is a bunch of work that needs to be done to move all 100 or so P/Invokes to this system (you can see this in the dllloader branch here)

Great... If you can get dynamic bindings working then that is better. 😀

@migueldeicaza I have created build automation to download&extract assemblies from official pypi site and published them as separate nuget packages, it works with sample projects in tensorflowsharp
https://www.nuget.org/packages/tensorflow-batteries-windows-x64-cpu/
https://www.nuget.org/packages/tensorflow-batteries-windows-x64-gpu/

I have nuget your gpu version libtensorflow.dll and copy it with python36.dll to debug folder, but I still got the error:

Can you tell me how I can use it correctly?

Check this: https://github.com/migueldeicaza/TensorFlowSharp/issues/236
On Tue, Sep 18, 2018 at 6:15 AM, tengfly<EMAIL_ADDRESS>wrote:

@migueldeicaza https://github.com/migueldeicaza I have created build
automation to download&extract assemblies from official pypi site and
published them as separate nuget packages, it works with sample projects in
tensorflowsharp
https://www.nuget.org/packages/tensorflow-batteries-windows-x64-cpu/
https://www.nuget.org/packages/tensorflow-batteries-windows-x64-gpu/
I have nuget your gpu version libtensorflow.dll and copy it with
python36.dll to debug folder, but I still got the error:
[image: image]
https://user-images.githubusercontent.com/22902650/45680925-caeb1200-bb6e-11e8-9fce-4283c26b69c7.png
Can you tell me how I can use it correctly?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/migueldeicaza/TensorFlowSharp/issues/256#issuecomment-422337046,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQekfZtlGrwMkSaDp9juUxX0TUKCbzDwks5ucMfegaJpZM4TVTDC
.

@lurium
It works. Thanks a lot!

My approach has been to move away from trying to package external cross platform libs in nuget packages. Ultimately tensorflowsharp has a dpendency on tensorflow but i find it improper that tfsharp controls that dependency considering its place in the heirarchy of dependencies. I deploy all my apps with docker containers and have about a dozen different built versions of tensorflow depending on what platform im deploying my .net application on. In my use case i always just end up deleting the .so files tfsharp supplies and linking the .so to my tf binary thats installed at the container level.


Use autogenerated tdlib libraries to enable CI

Hi, I saw you disabled the CI steps in https://github.com/aCLr/rust-tdlib/blob/master/.github/workflows/rust.yml because of "tests disables in case of unavailable tdlib =(".
I just made a github action flow that compiles tdlib, it's at https://github.com/dorak88783/tdlib-builder. If you want you can use this to get a tdlib library available to run the tests. I have it working in a private repo. If you like this idea/flow I can try to make it work in this repo and make PR. What do you think?

I wanted to make this, but do not have enough time.
Your action flow looks great but currently it uses tdlib 1.7.1. I'm just working on that version and it is not finished yet.
It would be better to specify particular tdlib version within particular rust-tdlib branch.
Also I think that if we will build tdlib each time it can take a lot of extra time. What if we will use a docker-image with already build tdlib?

I think I could make it such that it compiles different versions, I can check. Which one do you prefer right now?
In my view, the TDlib library compilation only happens once, in this td-builder repository. You can just clone this repository in your action and get the library from there, which is quick. I didn't propose to copy my action flow to your action flow.

Ok. I almost finish 1.7.0 support and going to implement tests run with github actions as soon as possible.

@dorak88783 I have just tried to use library from your repo and build fails with /usr/bin/ld: cannot find -ltdjson.
I think that the most right config may looks like that:
RUSTFLAGS: "-C link-args=-Wl,-rpath,tdlib-builder/lib"
Here is more logs: https://github.com/aCLr/rust-tdlib/runs/2222307705.
Could you provide linker args that you use?

It took me some time to get it working as well :) I now have
RUSTFLAGS: "-C link-args=-Wl,-rpath=./tdlib-builder/lib/,--verbose -L./tdlib-builder/lib/"
I think the -L argument is the only part missing from your command.

Great, I've just checked it on my laptop and it works fine thanks.
I will integrate it in a couple of hours.
вт, 30 мар. 2021 г. в 10:37, dorak88783 @.***>:

It took me some time to get it working as well :) I now have
RUSTFLAGS: "-C link-args=-Wl,-rpath=./tdlib-builder/lib/,--verbose
-L./tdlib-builder/lib/"
I think the -L argument is the only part missing from your command.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/aCLr/rust-tdlib/issues/1#issuecomment-809990087, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABRBAYG2JO347MNWL27SYITTGF5VFANCNFSM4XKWJBXQ
.

ok, it's done. thanks for your help.


Update user to support multiple jurisdictions

Description
Update user to support multiple jurisdictions
What type of PR is this? (check all applicable)

[x] 🍕 Feature
[ ] 🐛 Bug Fix
[ ] 📦 Chore (Release)
[ ] ✅ Test

Related Tickets & Documents
BPHH-1267
Steps to QA
Verify general happy paths still work as expected (especially for reviewers/review managers)
UI Accessibility Checklist

Note the following checklist is not an exhaustive list. Check
the WebAIM checklist for
a user-friendly checklist with more details. Aim to meet at least AA conformance level where applicable. Check
the WCAG guidelines for the full guidelines.

[ ] Markup uses semantic HTML?
[ ] Additional context added through aria-roles and aria-labels?
[ ] Checked
with Wave Browser Extension
for accessibility errors?
[ ] Usable with a keyboard and navigable in a logical order?
[ ] Usable using a screen reader (e.g. Voiceover for Mac) with enough context for the user?

General Checklist

[ ] ✅ Provide tests for your changes where relevant
[x] 📝 Use descriptive commit messages
[ ] 📗 Update any related documentation and include any relevant screenshots
[ ] 📱 For UI-related tasks, ensure responsive design is implemented across multiple screen size
[x] 🗂 Move your relevant story/task to the Ready for Code Review state

[optional] Are there any post-deployment tasks we need to perform?
n/a

in our enums.ts file we have:
 export enum EUserRoles {   submitter = "submitter",   reviewManager = "review_manager",   reviewer = "reviewer",   superAdmin = "super_admin", }
should we consider adding the new role? perhaps user helper methods? Does the new role have a new home screen?

I'm noticing that for some reason, the wrong role is being assigned to the review_manager after signup...

I'm noticing that for some reason the wrong role is being assigned to the review_manager after I log in with bceid:

for some reason the role of "submitter" is being assigned to the review_manager bceid

@LaurelOlson I rebased this and the integration branches so you will need to pull again


Add E2E tests run as part of PR check

Is your enhancement related to a problem? Please describe
We are proposing new CI workflows in the repo, there is a CI to be run on after merge (https://github.com/containers/podman-desktop-extension-bootc/pull/208).
To get better and faster results of the changes done in code and while being suggested (new PR), we should have e2e tests run on PR check.
Describe the solution you'd like
Idea would be to include new steps in PR check workflow (https://github.com/containers/podman-desktop-extension-bootc/blob/main/.github/workflows/pr-check.yaml), similar to what e2e-test-main (once merged) workflow offers, except a couple of adjustments.
It would be ideal to have extension image to be built locally (I guess we cannot really push into registry since we are on PR check and cannot use secrets), then the local image would be used as the one to be installed as an extension in the tests, we can probably use env.vars.  to get image uri.
Describe alternatives you've considered
No response
Additional context
No response

@deboer-tim @cdrage Hey guys in order to get the e2e tests running on pr check we'd need to be able to build the extension locally on the GHA runner, is the process to how to do that available anywhere?

@deboer-tim @cdrage Hey guys in order to get the e2e tests running on pr check we'd need to be able to build the extension locally on the GHA runner, is the process to how to do that available anywhere?

Hi! It's on the README:
https://github.com/containers/podman-desktop-extension-bootc?tab=readme-ov-file#contributing

@cdrage great, thank you


chore: add url tests

Hi! I'm the autofix.ci troubleshooter bot.
It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Error login in with Google Error Domain=com.google.GIDSignIn Code=-2 "keychain error" UserInfo={NSLocalizedDescription=keychain error}

Completely randomly I'm getting this error when calling
[[GIDSignIn sharedInstance] signIn];
What's the reason of this on what can I do to fix it?

same here, did you happen to find a solution for this ?

Not yet... looking forward on a response from the team

I am seeing this same problem. Not sure how should we proceed. One interesting observation is that if I use the Google's GIDSignInButton I don't see this issue. Only if  I use custom sign in button , I see this problem.

I noticed the same behavior.
I’ve been having issues with the programmatic sign in so switched to manual for now

On Oct 19, 2015, at 2:16 PM, kraghavan-cc<EMAIL_ADDRESS>wrote:
I am seeing this same problem. Not sure how should we proceed. One interesting observation is that if I use the Google's GIDSignInButton I don't see this issue. Only if I use custom sign in button , I see this problem.
—
Reply to this email directly or view it on GitHub https://github.com/googlesamples/google-services/issues/82#issuecomment-149349996.

Hi, sorry for the delay in replying. I'm trying to reproduce and investigate the issue, I will update this thread as soon as I find something. Could you let me know which versions of the library are you on?

I am trying it on V 2.3.2

The usecase was to signin, then signout, then signin and do this a few times to see that it fails to sign in with keychain error

+1

Another observation: It seems to be happening only if I run the app from xcode. If I disconnect the phone from XCode and repeat the usecase, it doesn't happen.

 I believe it could be caused by this issue.

I believe that it only happens to me on debug as well. But I haven't pushed to the App Store yet, so I don't have a big user base to test this on. @silvolu, if that issue is the responsible, can we expect something here or we have to wait on Apple to fix that?
Thanks!

Unfortunately, there's nothing we can do :/
On Tue, Nov 3, 2015 at 8:59 AM Jan Lübeck<EMAIL_ADDRESS>wrote:

I believe that it only happens to me on debug as well. But I haven't
pushed to the App Store yet, so I don't have a big user base to test this
on. @silvolu https://github.com/silvolu, if that issue is the
responsible, can we expect something here or we have to wait on Apple to
fix that?
Thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/googlesamples/google-services/issues/82#issuecomment-153417483
.

@silvolu What do you mean there is nothing we can do ? Im getting this "keychain error" behaviour too, but does that mean... We just can't test the SignIn functionality while connected to Xcode ? this is crazy :(

@omarojo Silvano is saying there is a bug in general keychain access when the xcode debugger is attached, which we can't easily work around :(

same problem

I found that it happens only with XCode and that too only with one phone that I use for development . If I changed my phone and tried running from XCode it doesn't happen at all.

+1

I have found a tricky fix, use a delay on the signIn method of the AppDelegate
func signIn(signIn: GIDSignIn!, didSignInForUser user: GIDGoogleUser!,
    withError error: NSError!) {
        if (error == nil) {
            Lab4TimeUtils.delay(1.0, closure: { () -> () in
                let nav = self.window?.rootViewController as! UINavigationController
                if let vc = nav.visibleViewController as? LoginTableVC {
                        vc.googleSiginCallback()
                }
            })
        } else {
        }
}

Randomly and only happens when App running by XCode.
XCode 7.2.1, iOS 9.2.1, OSX 10.10.5

I had the same issue, here is my Env: (XCode: 7.2, iOS: 9.2, OSX: 10.11.2).
Just stop the debug from XCode (Cmd + Shit + .) then go to your iPhone or Simulator and try to log in with Google.
This works fine ;)

Anyone still experiencing this? Apple just updated the thread today and said they believe they have fixed this issue, in some circumstances, with the iOS 9.3 update, but that there are still other causes for this that exist.
Here's the thread: https://forums.developer.apple.com/thread/4743
I've been fighting this issue all day. It only started when I deleted the app from my physical iPhone that I use for development. I've tried adding a delay, signing out, running without Xcode attached, and running in release but nothing works.

I'm getting this error in the iOS 10.0 simulator (even when running the Simulator app directly).
Xcode 8.0 beta 6 (8S201h)

@aleclarson - same here! Also integrating directly into my project, I'm getting a Google Sign-In button that does absolutely nothing when clicked.

Have the same issue on iOS10 simulator with XCode8 beta 6.
Found this workaround works by enable keychain sharing of target settings
http://stackoverflow.com/questions/38812761/gidsignin-keychain-error-ios-10-xcode-8

The problem you are trying to solve is connected with keychain access. To fix issue you simply should go to Target->Capabilities and enable keychain sharing

This should be fixed in XCode 8.2 in the simulator AFAIK - let me know if you're seeing the keychain error in that version or above though!

I also have the same issue. It is fixed by enabling 'Keychain sharing' in Target capabilities.

what is Lab4TimeUtils?


math

I guess math must be in beginner page? At least before studying stats or probability

Stats and prob in beginner phase are just basics :) and when we reach a higher phase it gets more difficult in level.
if i put math at the beginning, i think people will just get bored or the may not continue>
also, imo, what is important is taking math before going through ML regardless of how i partitioned the roadmap in levels.


[Event Request] Report 2 General Journal - Test: OnBeforeWarningIfPositiveAmt

Function: WarningIfPositiveAmt
Publisher: OnBeforeWarningIfPositiveAmt

The new publisher was implemented in BC 14 CU 01, with subsequent code change as shown:


Friends - Somtimes Sender is not updated when pending request is accepted

Issue:
When User A sends User B a friend request and User B accepts, sometimes User A will not be updated and request will remain in pending.
OS:
MacOS
Linux
Windows
Screenshots:
In this scenario, Linux sent a friend request to PhillMacAir and PhillMacAir accepted

On Linux side request still appears as pending and has yet to update. If PhillMacAir was to remove Linux as a friend, request would still remain as pending to Linux

This is likely due to the relay data restrictions. Although the data sent should be small enough to go through the relay (in the event upnp, and direct connection failing and falling back to the relay), it may be that the other end is either slowly transmitting or is failing to transmit. I will look into this (especially since i know direct connection isnt successful for @phillsatellite, so i may do additional testing with him to get additional log information to investigate on how to improve that upstream). Using the experimental flag should improve on this though due to the higher data limit.


React Native- There is way to display all the data in tables when using swiper to swipe to the next table?

Which OS ?
There is way to display all the data in tables when using "swiper" to swipe to the next table ?
How can I view all the data as I flip between table and table?
At the moment it only shows me one table and not the rest of the tables.
import Swiper from 'react-native-swiper'

export default class InfoTable extends Component {
    constructor(props) {
        super(props);
        this.state = {
            tableHead2: ['banana'],
            tableData2: [
                ['kind', this.props.headerInfo.ORDER_TYPE_TXT],
                ['name', this.props.headerInfo.INITIATOR_NAME],
                ['place', this.props.headerInfo.FUNC_LOC_TXT],
                ['equipment', this.props.headerInfo.EQUIPMENT_TXT]]
        }
    }
    componentWillReceiveProps(nextProps) {
        if (nextProps.headerInfo != null) {
            this.setState({ tableHead0: [nextProps.headerInfo] })
        }
        alert(JSON.stringify(nextProps))
    }
    render() {
        const state = this.state;
        return (
            <Swiper style={styles.wrapper} showsButtons={true}>
                <ScrollView>
                    <View style={styles.container}>
                        <Table borderStyle={{ borderWidth: 2, borderColor: '#d83dff' }}>
                            <Row data={state.tableHead2} style={styles.head} textStyle={styles.headText} />
                            <Rows data={state.tableData2} textStyle={styles.text} />
                        </Table>
                    </View>
                </ScrollView>
            </Swiper>
        )
    }
}

Version
Which versions are you using:

react-native-swiper v?
react-native v0.?.?

Expected behaviour
Actual behaviour
How to reproduce it>
To help us, please fork this component, modify one example in examples folder to reproduce your issue and include link here.
Steps to reproduce

Have you try something like this?
nestedScrollEnabled={true} put in scrollview tag
<ScrollView nestedScrollEnabled = {true}>
 ......
  <ScrollView nestedScrollEnabled = {true}>
    .....
  </ScrollView>
</ScrollView>


Fix empty column issue (#13641)

Co-authored-by: Monica Gupta<EMAIL_ADDRESS>
This PR fixes #

Pull Request Test Coverage Report for Build 399371270

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.157%

Totals

Change from base Build 399141707:
0.0%

Covered Lines:
21844

Relevant Lines:
48622

💛  - Coveralls


Use SQLite as a persistent cache layer

Background: #87
Should switch to SQLite as the underpinning cache implementation.
Easiest path would be adding sqlite as a backend for kv-cache and changing the pipeline to default to it.

To reduce cache overhead for read misses, it's probably worth applying a select key from cache query during initialisation. This would allow us to no-op misses instantly.

have you considered leveldb?

Just took a bit of a poke around, looks like it might offer better performance characteristics for writes. Most benchmarks I've seen place sqlite and leveldb roughly equivalent for random reads.
Both provide batching of operations, so you can get some massive wins over a simple FS abstraction.
Besides leveldb's faster writes, it doesn't seem to offer much that sqlite doesn't. Write-perf isn't too much of a concern as the current implementation runs them without blocking any build phases.
At this stage, I'm inclined towards sqlite simply because it's a more mature abstraction with more well-known quirks and issues.


Azure CLI V2 sets "--allow-no-subscriptions" argument

Question, Bug, or Feature?
Type: Bug
Enter Task Name: AzureCLIV2

Agent - Private:

Name
Value

Agent.Version
2.165.0

Agent.OS
Windows_NT

Agent.OSArchitecture
X64

Agent.OSVersion
10.0.18363

AzurePS
1.6.1

Task YAML:
steps:
- task: AzureCLI@2
  displayName: 'Upload DeploymentServerInterfaceDLL to Azure'
  inputs:
    azureSubscription: 'Visual Studio Ultimate with MSDN(Converted to EA) (xxx)'
    scriptType: ps
    scriptLocation: inlineScript
    inlineScript: |
     #my script here
    addSpnToEnvironment: true
    useGlobalConfig: true
    workingDirectory: '$(System.DefaultWorkingDirectory)\$(Release.PrimaryArtifactSourceAlias)'

Task fails with the following error:
The subscription of 'xxx' doesn't exist in cloud AzureCloud'.
I have noticed this failure in AzureCLI V2.0.14 where the only difference is "--allow-no-subscriptions" argument is being set. I am not sure why that argument is now being provided, as there have been no changes to the task on our end.

Last successful run was in AzureCLI V2.0.8

@MetalWing we set --allow-no-subscription to let customers run commands that are not scoped to one specific subscription.
The issue is not reproducible from my end.
It is likely that the service principal you're using for login, doesn't have access to the subscription any more (maybe it has expired). Could you try with a new Service Principal?

You can run the command az account list to list all subscriptions that the service principal you use have access to.

@issacnitin Thank you very much for your response!
You might be onto something. I will check the subscription access as soon as I can.
However, I think it's worth mentioning that we have two Azure CLI tasks. One is Azure CLI V1 and the following is Azure CLI V2.
They are setup the same way,  and run one after another.

Our agent is set to use OAuth token:

And the tasks (V1 and V2) are both configured as follows:

I am a bit confused why Azure CLI V1 (1.163.1) passes:

And Azure CLI V2 (2.0.14) fails (screenshots in original post) despite identical setup.
I can confidently say that all of our Azure CLI V1 tasks are working and are able to access the subscription.
Thoughts?

@MetalWing  I came across a bug in Az CLI version 2.0.71
https://github.com/Azure/azure-cli/issues/11059
Please update az cli version in your private agent to 2.0.77+, that should do the trick

@issacnitin Thank you! That fixed the issue :)


check if the specified channels in the appliance metadata exist

Description
The current topography metadata checker only checks if the specified metadata is "valid".
It however might as well be the case that a channel that was specified in the metadata section is not at all present in the subblock collection, rendering the topography spec invalid.
This PR adds functionality to check the subblock collection for the channels that the TopographyDataItem wishes to see in the image document.
Fixes #8
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
I created a new "broken" image for test purposes to verify the intended behaviour. I'd like to add/replace this new file to the testdata collection and include the new "expected results" in the repo to have this test included to the CI pipeline.
Checklist:

[x] I followed the Contributing Guidelines.
[x] I did a self-review.
[x] I commented my code, particularly in hard-to-understand areas.
[ ] I updated the documentation.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] New and existing unit tests pass locally with my changes.

Btw, not related to this PR: line 154 and 157 look fishy to me - I mean accessing static members with this->.
I am referring to this part:
    string topography_path{ this->kImageAppliancePath };
    topography_path
        .append("/Appliance[Id=")
        .append(this->kTopographyItemId)
        .append("]");

I'd think this should better read:
    string topography_path{ CCheckTopographyApplianceMetadata::kImageAppliancePath };
    topography_path
        .append("/Appliance[Id=")
        .append(CCheckTopographyApplianceMetadata::kTopographyItemId)
        .append("]");


section 02-02 is now very long. split across multiple pages?

done in https://github.com/rh-aiservices-bu/insurance-claim-processing/pull/92


Fix locale format in internal opengraph template

In response to #8296. This PR updates the internal opengraph template and allows you set the locale for an entire translation in the site config. You can still override the language locale in your front matter.
Set your language locale in your site config:
# config.toml
defaultContentLanguage = "en"

[languages]
    [languages.en]
        locale = "en_US"

Generates:
<meta property="og:locale" content="en_US">

But you can override the locale in your content file:
---
locale: en_GB
---

Generates:
<meta property="og:locale" content="en_GB">

I've also added the og:locale:alternate meta property. So if you have the same page in multiple languages it will also generate like this:
<meta property="og:locale:alternate" content="es_ES" />
<meta property="og:locale:alternate" content="fr_FR" />

this PR looked good and shouldn't be marked as stale.

The linked Issue for this was closed today, but the PR looks good. Needs a review from @bep though.


HBASE-22262 Removed deprecated methods from Filter class

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
39
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 3 new or modified test files.

_ master Compile Tests _

0
mvndep
27
Maven dependency ordering for branch

-1
mvninstall
83
root in master failed.

-1
compile
16
hbase-client in master failed.

-1
compile
28
hbase-server in master failed.

-1
compile
24
hbase-rest in master failed.

+1
checkstyle
123
master passed

+1
shadedjars
281
branch has no errors when building our shaded downstream artifacts.

-1
findbugs
60
hbase-client in master has 83 extant Findbugs warnings.

-1
findbugs
153
hbase-server in master has 3 extant Findbugs warnings.

-1
findbugs
24
hbase-rest in master failed.

-1
javadoc
14
hbase-client in master failed.

-1
javadoc
18
hbase-server in master failed.

_ Patch Compile Tests _

0
mvndep
13
Maven dependency ordering for patch

-1
mvninstall
78
root in the patch failed.

-1
compile
15
hbase-client in the patch failed.

-1
compile
28
hbase-server in the patch failed.

-1
compile
24
hbase-rest in the patch failed.

-1
javac
15
hbase-client in the patch failed.

-1
javac
28
hbase-server in the patch failed.

-1
javac
24
hbase-rest in the patch failed.

+1
checkstyle
35
hbase-client: The patch generated 0 new + 352 unchanged - 26 fixed = 352 total (was 378)

+1
checkstyle
74
hbase-server: The patch generated 0 new + 42 unchanged - 2 fixed = 42 total (was 44)

+1
checkstyle
13
The patch passed checkstyle in hbase-rest

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
279
patch has no errors when building our shaded downstream artifacts.

-1
hadoopcheck
44
The patch causes 10 errors with Hadoop v2.7.4.

-1
hadoopcheck
86
The patch causes 10 errors with Hadoop v3.0.0.

-1
findbugs
26
hbase-rest in the patch failed.

-1
javadoc
14
hbase-client in the patch failed.

-1
javadoc
19
hbase-server in the patch failed.

_ Other Tests _

-1
unit
16
hbase-client in the patch failed.

-1
unit
28
hbase-server in the patch failed.

-1
unit
25
hbase-rest in the patch failed.

+1
asflicense
27
The patch does not generate ASF License warnings.

2076

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/162

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux e1202aa03048 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 8ec93ea193

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/1/artifact/out/branch-mvninstall-root.txt

compile
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/1/artifact/out/branch-compile-hbase-client.txt

compile
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/1/artifact/out/branch-compile-hbase-server.txt

compile
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/1/artifact/out/branch-compile-hbase-rest.txt

findbugs
v3.1.11

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/1/artifact/out/branch-findbugs-hbase-client-warnings.html

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/1/artifact/out/branch-findbugs-hbase-server-warnings.html

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/1/artifact/out/branch-findbugs-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/1/artifact/out/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/1/artifact/out/branch-javadoc-hbase-server.txt

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/1/artifact/out/patch-mvninstall-root.txt

compile
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/1/artifact/out/patch-compile-hbase-client.txt

compile
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/1/artifact/out/patch-compile-hbase-server.txt

compile
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/1/artifact/out/patch-compile-hbase-rest.txt

javac
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/1/artifact/out/patch-compile-hbase-client.txt

javac
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/1/artifact/out/patch-compile-hbase-server.txt

javac
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/1/artifact/out/patch-compile-hbase-rest.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/1/artifact/out/patch-javac-2.7.4.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/1/artifact/out/patch-javac-3.0.0.txt

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/1/artifact/out/patch-findbugs-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/1/artifact/out/patch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/1/artifact/out/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/1/artifact/out/patch-unit-hbase-client.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/1/artifact/out/patch-unit-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/1/artifact/out/patch-unit-hbase-rest.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/1/testReport/

Max. process+thread count
83 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
24
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 3 new or modified test files.

_ master Compile Tests _

0
mvndep
27
Maven dependency ordering for branch

+1
mvninstall
276
master passed

+1
compile
110
master passed

+1
checkstyle
128
master passed

+1
shadedjars
284
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
300
master passed

+1
javadoc
84
master passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
252
the patch passed

+1
compile
106
the patch passed

+1
javac
106
the patch passed

+1
checkstyle
35
hbase-client: The patch generated 0 new + 352 unchanged - 26 fixed = 352 total (was 378)

+1
checkstyle
70
hbase-server: The patch generated 0 new + 42 unchanged - 2 fixed = 42 total (was 44)

+1
checkstyle
17
The patch passed checkstyle in hbase-rest

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
271
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
559
Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.

+1
findbugs
335
the patch passed

+1
javadoc
76
the patch passed

_ Other Tests _

+1
unit
202
hbase-client in the patch passed.

-1
unit
7563
hbase-server in the patch failed.

+1
unit
266
hbase-rest in the patch passed.

+1
asflicense
92
The patch does not generate ASF License warnings.

11199

Reason
Tests

Failed junit tests
hadoop.hbase.security.token.TestZKSecretWatcher

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/162

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 9ce6db6b80b5 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 268bcce76f

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/2/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/2/testReport/

Max. process+thread count
4685 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/2/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

The test failure seems to be unrelated to the actual change.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
23
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 3 new or modified test files.

_ master Compile Tests _

0
mvndep
29
Maven dependency ordering for branch

+1
mvninstall
260
master passed

+1
compile
109
master passed

+1
checkstyle
121
master passed

+1
shadedjars
269
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
284
master passed

+1
javadoc
81
master passed

_ Patch Compile Tests _

0
mvndep
17
Maven dependency ordering for patch

+1
mvninstall
244
the patch passed

+1
compile
102
the patch passed

+1
javac
102
the patch passed

+1
checkstyle
33
hbase-client: The patch generated 0 new + 352 unchanged - 26 fixed = 352 total (was 378)

+1
checkstyle
67
hbase-server: The patch generated 0 new + 42 unchanged - 2 fixed = 42 total (was 44)

+1
checkstyle
16
The patch passed checkstyle in hbase-rest

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
265
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
508
Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.

+1
findbugs
337
the patch passed

+1
javadoc
77
the patch passed

_ Other Tests _

+1
unit
199
hbase-client in the patch passed.

+1
unit
7596
hbase-server in the patch passed.

+1
unit
266
hbase-rest in the patch passed.

+1
asflicense
90
The patch does not generate ASF License warnings.

11095

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/162

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 716c71e53a49 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / f30d6c958a

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/3/testReport/

Max. process+thread count
4726 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/3/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

For sure deprecated for a whole major version? Deprecate in hbase 2.0.0 release?

I think 'a whole major version' just means we can not remove deprecated stuff if it is first deprecated in the same major version? For example, it is OK to remove a class in 3.0.0 if it is deprecated in 2.1.0, but you can not remove it in 2.2.0.

"An API needs to be deprecated for a major version before we will change/remove it."
... in "Client API compatibility" in http://hbase.apache.org/book.html#hbase.versioning.post10

I had the same understanding as @Apache9. I know we had a discussion about this some time ago, but wasn't able to find it anymore. Probably the documentation needs some more details (an example would be good), because it is up to some kind of interpretation. I think if we deprecate something in 2.0.0 we can remove it in 3.0.0. But what about the minor versions? If we deprecated something in 2.3.0 and the next version to be released is 3.0.0 we don't really have a deprecation for a major version. Removing it in 3.3.0 also doesn't seem to be good. With that the next major version would be 4.0.0, so removing it after 1.5 major versions.

My interpretation is that you have to wait at least a major version so as per your example, it'd be 4.0.0 if deprecation was added in anything after 2.0.0.

My interpretation is that you have to wait at least a major version so as per your example, it'd be 4.0.0 if deprecation was added in anything after 2.0.0.

That would be too tough? I think a major release is where we do breaking changes. And I found this in our ref guide

Example: A user using a newly deprecated API does not need to modify application code with HBase API calls until the next major version. *

So I think it is OK to remove deprecated classes in a major release? We can leave it there for some reasons, but removing  it is also acceptable.

Sounds like we need to get clarification here. I think the 'Example' sentence is open to various interpretation. ML?

I have already done some removal of deprecated classes on master...
But I think your point on 'at lease a whole major release' is also valid. For example, we have deprecated something on 2.1.0, but users may upgrade to 3.0.0 from 2.0.0, so they will not see the deprecation and find out some APIs are gone...
So maybe we need a guide on rolling upgrading, for example, 2.x users must upgrade to, for example, 2.3.0 first, before upgrading to 3.0.0? And we must make sure that, all classes deprecated after 2.3.0 release, must be retained until we release 4.0.0.
What do you think?

Lets discuss on ML. I think asking folks to rolling upgrade to the most minor version before going to next major may be an unfair expectation.

Anyway we have already done lots of removal and it is not likely that we can add them back, so...

Also agree to discuss it on the ML. Will create a thread later today. We definitely need to make the documentation more clear. Regarding this PR: The two methods in the Filter class were deprecated in 2.0.0, so we should be fine to remove them for 3.0.0.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
267
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 3 new or modified test files.

_ master Compile Tests _

0
mvndep
26
Maven dependency ordering for branch

+1
mvninstall
273
master passed

+1
compile
109
master passed

+1
checkstyle
121
master passed

+1
shadedjars
262
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
293
master passed

+1
javadoc
72
master passed

_ Patch Compile Tests _

0
mvndep
26
Maven dependency ordering for patch

+1
mvninstall
269
the patch passed

+1
compile
106
the patch passed

+1
javac
106
the patch passed

+1
checkstyle
35
hbase-client: The patch generated 0 new + 340 unchanged - 26 fixed = 340 total (was 366)

+1
checkstyle
69
hbase-server: The patch generated 0 new + 42 unchanged - 2 fixed = 42 total (was 44)

+1
checkstyle
15
The patch passed checkstyle in hbase-rest

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
269
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
545
Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.

+1
findbugs
336
the patch passed

+1
javadoc
72
the patch passed

_ Other Tests _

+1
unit
205
hbase-client in the patch passed.

-1
unit
17532
hbase-server in the patch failed.

+1
unit
490
hbase-rest in the patch passed.

+1
asflicense
74
The patch does not generate ASF License warnings.

21583

Reason
Tests

Failed junit tests
hadoop.hbase.master.procedure.TestSCPWithReplicas

hadoop.hbase.client.TestAdmin1

hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated

hadoop.hbase.client.TestConnectionImplementation

hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas

hadoop.hbase.client.TestFromClientSide3

hadoop.hbase.master.TestSplitWALManager

hadoop.hbase.client.replication.TestReplicationAdminWithClusters

hadoop.hbase.client.TestFromClientSide

hadoop.hbase.client.TestHbck

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/162

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 4e273caea6f0 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 184568cadd

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/4/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/4/testReport/

Max. process+thread count
5138 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-162/4/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

So, we got clarification on the ML. How does it effect the patch? Thanks.

@saintstack It shouldn't affect the patch, because the two methods were deprecated in 2.0.0 and with that can be removed in 3.0.0. In my opinion we're ready to merge.

@HorizonNet Ok. +1 on commit sir.


replace lookbehind regex with two regex

Safari is not so smart
fixes https://github.com/yourlabs/django-autocomplete-light/issues/1226

Just came across this issue. Would love to see a release with this fix included.


Dead lock on update with no rows

If an update sql command is performed having 0 result record,  the lock is kept on the engine.
ie update mytable set valx = 'test' where id= 5;
and the record 5 doesn't exists, the engine is keeping a lock.
The command Commit or Rollback doesn't affect the query and the lock is not removed.

I can't reproduce such behavior. What is your database?
Although I don't think that this is related to DBeaver.


[SF Symbols Search] Two commands have the same keyboard shortcut

Extension
https://www.raycast.com/peteschaffner/sf-symbols-search
Description

Steps To Reproduce
Search for a symbol.
Open the commands for a symbol.
Current Behaviour
the commands for copying the name and the symbol has the same Command+Shift+C keyboard shortcuts
Expected Behaviour
I would prefer to use the Command+Shift+C to copy the name

Hey @atacan! To be honest I haven't used or touched the code for this extension in a really long time—even those command titles in that screenshot seem different from what I remember implementing (IIRC there was a PR a while back, but it wasn't authored by me).
I'd like to dig back into this one day as I'd like to start using it again myself, but it was quite a gnarly extension to get working and maintain, so no promises :(


Stuff is not correctly set when a load function returns error

Describe the bug
When error (or status !== 2xx) is included in the returned object from a load function inside a route, while also providing a stuff object, the $page.stuff store is empty.
Reproduction
https://github.com/flavioosh/sveltekit-stuff-error-repro
Logs
No response
System Info
System:
    OS: Linux 5.18 Arch Linux
    CPU: (16) x64 AMD Ryzen 7 3700X 8-Core Processor
    Memory: 23.23 GB / 31.27 GB
    Container: Yes
    Shell: 5.9 - /usr/bin/zsh
  Binaries:
    Node: 16.16.0 - ~/.nvm/versions/node/v16.16.0/bin/node
    npm: 8.14.0 - ~/.nvm/versions/node/v16.16.0/bin/npm
  Browsers:
    Firefox: 102.0.1
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.60
    @sveltejs/kit: next => 1.0.0-next.374
    svelte: ^3.44.0 => 3.49.0
    vite: ^3.0.0 => 3.0.0

Severity
serious, but I can work around it
Additional Information
I'm not sure if this is expected behaviour, but it seems that even if the object returned from a load function contains either error or a non-200 status, we should still get the stuff passed through to the layout or error pages. I'm not sure if I'm doing something wrong but this seems counter-intuitive.

I'm trying to get around this issue by using a store; I use store.set(...) in the load function of the route, and then subscribe to the store with $store in the layout file. A similar issue to the one described above happens, where the store is reverted back to its initial value, but only on the client side. If I disable JavaScript, the store is still populated with the value set in the load function, unlike with stuff. I have created a branch in the above repo called store-alt to show this, not sure if it's a separate issue or not.

I've managed to trace a part of this to the normalize function in runtime/load.js, where stuff from the loaded isn't used at all (perhaps intentionally). Using it in the output of the normalize function will then provide it for the error page, and it will be accessible when rendered by the server.
However, during hydration on the client, because only the error page load function is executed, the stuff from the errored out load is never present, and is reset back to {}. From what I can tell, stuff isn't passed to the start (and subsequently _hydrate) function. That's where my ability to traverse the code ends unfortunately.

There are multiple parts to this:

insize normalize, stuff is not returned
inside the "load correct nodes"-loop of both client and server, stuff is incorrect because it's only the stuff of the last node that loaded without an error
If 1 and 2 are fixed, the hydration on the client still brings up wrong results because the nodes passed from the server are only the layout nodes leading up to the __error page that is selected, so in this case the page is not loaded and therefore its stuff isn't known/used and is missing from the final stuff result.

1 and 2 are rather easy to fix, but 3 is tricky - we would need to replay the logic leading up to the error, so we need all nodes and call their load functions, also those discarded by the error.

Closing as outdated due to #5748. +error.svelte files can no longer load things, which means the opportunity for this to break no longer exists


fixing OSS filter_fuzz_test OOM issue when thread_count is 800 million.

Signed-off-by: Yanjun Xiang<EMAIL_ADDRESS>
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

When running OSS filter_fuzz_test, we are seeing an OOM issue with file system buffer extension filter when thead_count is configured to be extremely large, like 800 million.  The test logs are below:
/bazel-bin/test/extensions/filters/http/common/fuzz/filter_fuzz_test test/extensions/filters/http/common/fuzz/filter_corpus/clusterfuzz-testcase-minimized-filter_fuzz_test-5022310482706432  -l trace > ~/yanjunxiang/test.log
[2022-11-01 21:21:25.197][3683384][info][misc] [test/fuzz/main.cc:47] Corpus file: test/extensions/filters/http/common/fuzz/filter_corpus/clusterfuzz-testcase-minimized-filter_fuzz_test-5022310482706432
[2022-11-01 21:21:25.206][3683384][debug][misc] [test/extensions/filters/http/common/fuzz/filter_fuzz_test.cc:75] Filter configuration: name: "envoy.filters.http.match_delegate"
typed_config {
[type.googleapis.com/envoy.extensions.common.matching.v3.ExtensionWithMatcher] {
extension_config {
name: "."
typed_config {
[type.googleapis.com/envoy.extensions.filters.http.file_system_buffer.v3.FileSystemBufferFilterConfig] {
manager_config {
thread_pool {
thread_count: 811335680
}
}
}
}
}
}
}
[2022-11-01 21:21:25.330][3683384][info][misc] [test/test_common/utility.cc:63] TestRandomGenerator running with seed<PHONE_NUMBER>
[2022-11-01 21:21:25.382][3683384][info][misc] [test/test_common/utility.cc:63] TestRandomGenerator running with seed<PHONE_NUMBER>
[2022-11-01 21:21:25.383][3683384][info][config] [./envoy/registry/registry.h:413] Factory 'envoy.network.dns_resolver.cares' (type '{"envoy.extensions.network.dns_resolver.cares.v3.CaresDnsResolverConfig"}') registered for tests
[2022-11-01 21:21:25.384][3683384][info][config] [./envoy/registry/registry.h:456] Removed test factory 'envoy.network.dns_resolver.cares' (type '{"envoy.extensions.network.dns_resolver.cares.v3.CaresDnsResolverConfig"}')
[2022-11-01 21:21:25.384][3683384][info][misc] [test/extensions/filters/http/common/fuzz/uber_filter.cc:69] filter name envoy.filters.http.match_delegate
[2022-11-01 21:21:25.384][3683384][warning][misc] [source/common/protobuf/message_validator_impl.cc:35] message 'envoy.extensions.common.matching.v3.ExtensionWithMatcher' is marked as work-in-progress. API features marked as work-in-progress are not considered stable, are not covered by the threat model, are not supported by the security team, and are subject to breaking changes. Do not use this feature without understanding each of the previous points.
[2022-11-01 21:21:25.398][3683384][warning][misc] [source/common/protobuf/message_validator_impl.cc:35] message 'envoy.extensions.filters.http.file_system_buffer.v3.FileSystemBufferFilterConfig' is contained in proto file 'envoy/extensions/filters/http/file_system_buffer/v3/file_system_buffer.proto' marked as work-in-progress. API features marked as work-in-progress are not considered stable, are not covered by the threat model, are not supported by the security team, and are subject to breaking changes. Do not use this feature without understanding each of the previous points.
[2022-11-01 21:21:25.398][3683384][warning][misc] [source/common/protobuf/message_validator_impl.cc:35] message 'envoy.extensions.common.async_files.v3.AsyncFileManagerConfig' is contained in proto file 'envoy/extensions/common/async_files/v3/async_file_manager.proto' marked as work-in-progress. API features marked as work-in-progress are not considered stable, are not covered by the threat model, are not supported by the security team, and are subject to breaking changes. Do not use this feature without understanding each of the previous points.
[2022-11-01 21:21:25.398][3683384][warning][misc] [source/common/protobuf/message_validator_impl.cc:35] message 'envoy.extensions.common.async_files.v3.AsyncFileManagerConfig.ThreadPool' is contained in proto file 'envoy/extensions/common/async_files/v3/async_file_manager.proto' marked as work-in-progress. API features marked as work-in-progress are not considered stable, are not covered by the threat model, are not supported by the security team, and are subject to breaking changes. Do not use this feature without understanding each of the previous points.
[2022-11-01 21:21:25.398][3683384][info][main] [source/extensions/common/async_files/async_file_manager_thread_pool.cc:41] AsyncFileManagerThreadPool created with id '', with 811335680 threads
terminate called without an active exception

The decode is below:
+----------------------------------------Release Build Stacktrace----------------------------------------+
  | Command: /mnt/scratch0/clusterfuzz/resources/platform/linux/unshare -c -n /mnt/scratch0/clusterfuzz/bot/builds/clusterfuzz-builds_envoy_13d8ff3fd8b6e12ff5bbd32d951c40c9e1c6513f/revisions/filter_fuzz_test -rss_limit_mb=2560 -timeout=60 -runs=100 /mnt/scratch0/clusterfuzz/bot/inputs/fuzzer-testcases/oom-71797470bea5299a678f6b9eef8d6f405b8113c3
  | Time ran: 3.469438076019287
  |
  | INFO: found LLVMFuzzerCustomMutator (0x205a650). Disabling -len_control by default.
  | INFO: Running with entropic power schedule (0xFF, 100).
  | INFO: Seed:<PHONE_NUMBER>
  | INFO: Loaded 1 modules   (577515 inline 8-bit counters): 577515 [0x7d6c188, 0x7df9173),
  | INFO: Loaded 1 PC tables (577515 PCs): 577515 [0x7df9178,0x86c9028),
  | /mnt/scratch0/clusterfuzz/bot/builds/clusterfuzz-builds_envoy_13d8ff3fd8b6e12ff5bbd32d951c40c9e1c6513f/revisions/filter_fuzz_test: Running 1 inputs 100 time(s) each.
  | Running: /mnt/scratch0/clusterfuzz/bot/inputs/fuzzer-testcases/oom-71797470bea5299a678f6b9eef8d6f405b8113c3
  | ==7650== ERROR: libFuzzer: out-of-memory (malloc(6490685440))
  | To change the out-of-memory limit use -rss_limit_mb=
  |
  | #0 0x20298e1 in __sanitizer_print_stack_trace /src/llvm-project/compiler-rt/lib/asan/asan_stack.cpp:87:3
  | #1 0x1f48218 in fuzzer::PrintStackTrace() /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerUtil.cpp:210:5
  | #2 0x1f2c1b5 in fuzzer::Fuzzer::HandleMalloc(unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:131:3
  | #3 0x1f2c0ca in fuzzer::MallocHook(void const volatile*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:100:6
  | #4 0x2030d67 in __sanitizer::RunMallocHooks(void const*, unsigned long) /src/llvm-project/compiler-rt/lib/sanitizer_common/sanitizer_common.cpp:318:5
  | #5 0x1fa0f14 in __asan::Allocator::Allocate(unsigned long, unsigned long, __sanitizer::BufferedStackTrace*, __asan::AllocType, bool) /src/llvm-project/compiler-rt/lib/asan/asan_allocator.cpp:600:5
  | #6 0x1fa0853 in __asan::asan_malloc(unsigned long, __sanitizer::BufferedStackTrace*) /src/llvm-project/compiler-rt/lib/asan/asan_allocator.cpp:953:34
  | #7 0x201f865 in __interceptor_malloc /src/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:70:10
  | #8 0x2103f44 in operator new(unsigned long)
  | #9 0x4e16850 in __libcpp_operator_new /usr/local/include/c++/v1/new:245:10
  | #10 0x4e16850 in __libcpp_allocate /usr/local/include/c++/v1/new:271:10
  | #11 0x4e16850 in allocate /usr/local/include/c++/v1/__memory/allocator.h:105:38
  | #12 0x4e16850 in allocate /usr/local/include/c++/v1/__memory/allocator_traits.h:262:20
  | #13 0x4e16850 in __split_buffer /usr/local/include/c++/v1/__split_buffer:306:29
  | #14 0x4e16850 in std::__1::vector<std::__1::thread, std::__1::allocatorstd::__1::thread >::reserve(unsigned long) /usr/local/include/c++/v1/vector:1489:53
  | #15 0x4e156f1 in Envoy::Extensions::Common::AsyncFiles::AsyncFileManagerThreadPool::AsyncFileManagerThreadPool(envoy::extensions::common::async_files::v3::AsyncFileManagerConfig const&, Envoy::Api::OsSysCalls&) /proc/self/cwd/source/extensions/common/async_files/async_file_manager_thread_pool.cc:42:16
  | #16 0x4df9f70 in __shared_ptr_emplace<const envoy::extensions::common::async_files::v3::AsyncFileManagerConfig &, Envoy::Api::OsSysCalls &> /usr/local/include/c++/v1/__memory/shared_ptr.h:294:37
  | #17 0x4df9f70 in allocate_shared<Envoy::Extensions::Common::AsyncFiles::AsyncFileManagerThreadPool, std::__1::allocatorEnvoy::Extensions::Common::AsyncFiles::AsyncFileManagerThreadPool, const envoy::extensions::common::async_files::v3::AsyncFileManagerConfig &, Envoy::Api::OsSysCalls &, void> /usr/local/include/c++/v1/__memory/shared_ptr.h:953:55
  | #18 0x4df9f70 in make_shared<Envoy::Extensions::Common::AsyncFiles::AsyncFileManagerThreadPool, const envoy::extensions::common::async_files::v3::AsyncFileManagerConfig &, Envoy::Api::OsSysCalls &, void> /usr/local/include/c++/v1/__memory/shared_ptr.h:962:12
  | #19 0x4df9f70 in Envoy::Extensions::Common::AsyncFiles::AsyncFileManagerFactoryImpl::getAsyncFileManager(envoy::extensions::common::async_files::v3::AsyncFileManagerConfig const&, Envoy::Api::OsSysCalls*) /proc/self/cwd/source/extensions/common/async_files/async_file_manager_factory.cc:61:29
  | #20 0x4dbb63c in Envoy::Extensions::HttpFilters::FileSystemBuffer::FileSystemBufferFilterFactory::createFilterFactoryFromProtoTyped(envoy::extensions::filters::http::file_system_buffer::v3::FileSystemBufferFilterConfig const&, std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > const&, Envoy::Server::Configuration::FactoryContext&) /proc/self/cwd/source/extensions/filters/http/file_system_buffer/config.cc:26:57
  | #21 0x4dbdca7 in createFilterFactoryFromProto /proc/self/cwd/source/extensions/filters/http/common/factory_base.h:71:12
  | #22 0x4dbdca7 in non-virtual thunk to Envoy::Extensions::HttpFilters::Common::FactoryBase<envoy::extensions::filters::http::file_system_buffer::v3::FileSystemBufferFilterConfig, envoy::extensions::filters::http::file_system_buffer::v3::FileSystemBufferFilterConfig>::createFilterFactoryFromProto(google::protobuf::Message const&, std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > const&, Envoy::Server::Configuration::FactoryContext&) /proc/self/cwd/source/extensions/filters/http/common/factory_base.h:0
  | #23 0x3886108 in Envoy::Common::Http::MatchDelegate::MatchDelegateConfig::createFilterFactoryFromProtoTyped(envoy::extensions::common::matching::v3::ExtensionWithMatcher const&, std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > const&, Envoy::Server::Configuration::FactoryContext&) /proc/self/cwd/source/common/http/match_delegate/config.cc:257:33
  | #24 0x388c437 in createFilterFactoryFromProto /proc/self/cwd/source/extensions/filters/http/common/factory_base.h:71:12
  | #25 0x388c437 in non-virtual thunk to Envoy::Extensions::HttpFilters::Common::FactoryBase<envoy::extensions::common::matching::v3::ExtensionWithMatcher, envoy::extensions::common::matching::v3::ExtensionWithMatcher>::createFilterFactoryFromProto(google::protobuf::Message const&, std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > const&, Envoy::Server::Configuration::FactoryContext&) /proc/self/cwd/source/extensions/filters/http/common/factory_base.h:0
  | #26 0x2176dff in Envoy::Extensions::HttpFilters::UberFilterFuzzer::fuzz(envoy::extensions::filters::network::http_connection_manager::v3::HttpFilter const&, test::fuzz::HttpData const&, test::fuzz::HttpData const&) /proc/self/cwd/test/extensions/filters/http/common/fuzz/uber_filter.cc:76:19
  | #27 0x205b5fc in TestOneProtoInput /proc/self/cwd/test/extensions/filters/http/common/fuzz/filter_fuzz_test.cc:78:12
  | #28 0x205b5fc in LLVMFuzzerTestOneInput /proc/self/cwd/test/extensions/filters/http/common/fuzz/filter_fuzz_test.cc:13:1
  | #29 0x1f2e493 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:611:15
  | #30 0x1f18fa2 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:324:6
  | #31 0x1f1e84c in fuzzer::FuzzerDriver(int*, char***, int ()(unsigned char const, unsigned long)) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:860:9
  | #32 0x1f489d2 in main /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerMain.cpp:20:10
  | #33 0x7f16350e60b2 in __libc_start_main /build/glibc-eX1tMB/glibc-2.31/csu/libc-start.c:308:16
  | #34 0x1f0f16d in _start
  |
  | SUMMARY: libFuzzer: out-of-memory

/assign @ravenblackx

@ravenblackx I think we need to add a PGV to guard the max limit of the thread_count.  But not sure what number should we put it there.  If this is not the right fix, please feel free to create a new PR.

@htuch this is waiting for API shepard lgtm

Can you add a minimized testcase to validate that the fuzz issue is solved? /wait
Thanks for the comments!

Yes, the issue is resolved by running the bazel test with the same test case file. The PGV blocked such configurations, thus the test passed. That reminds me we should commit the fuzz test case file. This is the PR for this leftover part: https://github.com/envoyproxy/envoy/pull/23806.
Regarding your offline question about why the upper bound is 1024, why not bigger 4096, or why not less, like 256, and how much is the memory size  for each case?

The code which do the malloc is here:
thread_pool_.reserve(thread_pool_size);
https://github.com/envoyproxy/envoy/blob/36203ded7fc55b6ea0ab5d0e1ccb57a9846539de/source/extensions/common/async_files/async_file_manager_thread_pool.cc#L42

And thread_pool_ is defined as:
std::vectorstd::thread thread_pool_;
https://github.com/envoyproxy/envoy/blob/36203ded7fc55b6ea0ab5d0e1ccb57a9846539de/source/extensions/common/async_files/async_file_manager_thread_pool.h#L66
each std::thread data structure size is 8 bytes.
Thus 1024 threads is 8192 bytes. 256 threads is 2048 bytes, 4096 is 32k, et.al.
811335680 threads is<PHONE_NUMBER> bytes, 6.5G----- this the number printed in the trace back.

To not OOM, I think Envoy is bounding it to be 2560M. To achieve that, we just need to upper bound thread_count to be somewhere within 2560 M/ 8 = 320 million.

However,  thread_count is reflecting the concurrent threads hardware supports: https://github.com/envoyproxy/envoy/blob/36203ded7fc55b6ea0ab5d0e1ccb57a9846539de/api/envoy/extensions/common/async_files/v3/async_file_manager.proto#L22.
In that sense, 1024 is a sufficient big number for that,. At same time doesn't cause OOM(8K here).
Also,  do we need to keep this upper bound smaller, like 256 or 512? I think this is a good question. But I guess we don't have to make it that tight.


about givepal command and more 2 suggestions

zvend you givepal command gives a pal with 0/0/0 iv's , id suggest if possible you change the command to give some pal with random iv and gender, like a wild pal.
another suggestion is, if possible, the giveitems works for many steamid's in same line, like the itens.
another suggestion is you create a giveegg_j , where we can create a egg from a exported json.
i know you working alot, but when you have a little time. ty.

I wish you would have opened another issue for the "2 more suggestions" :P
I just added that every command that grants or spawns pals will now be initialized with default parameters. That means random Gender, random IVs etc. UNLESS you overwrite it in the paljson file.


fix issue 109: resolved unnecessary request when input is empty

Description
Form is no longer doing a request when input is empty and you click enter or click on search icon
Checklist

[x] I am making a proper pull request, not spam.
[x] I've checked the issue list before deciding what to submit.

Related Issues or Pull Requests
NA
Add relevant screenshot or video (if any)

Resolve #113


test: NFS

adds NFS tests

I can't approve this because it is my PR but it looks good !

@cristiGuranIonos also add in CHANGELOG.md please.


Adding configuration methods with ?

Closes #508
@projecthydra-labs/hyrax-code-reviewers

@jcoyne I thought you might ask that.


DiagonalMatrix / Scalar

import scid.matvec;

void main() {
    auto m = DiagonalMatrix!double([1.0, 2, 3]);
    eval(m / 3.0);
}

scid\ops\expression.d(403): Error: static assert  "Types 'BasicMatrix!(BasicDiagonalMatrixStorage!(RefCounted!(CowArray!(double),cast(RefCountedAutoInitialize)1),cast(DiagonalMatrixStorageType)0))' and 'double' do not define a promotion. "
scid\ops\expression.d(376):        instantiated from here: PromotionImpl!(BasicMatrix!(BasicDiagonalMatrixStorage!(RefCounted!(CowArray!(double),cast(RefCountedAutoInitialize)1),cast(DiagonalMatrixStorageType)0)),double)
scid\ops\expression.d(312):        instantiated from here: Promotion!(BasicMatrix!(BasicDiagonalMatrixStorage!(RefCounted!(CowArray!(double),cast(RefCountedAutoInitialize)1),cast(DiagonalMatrixStorageType)0)),double)
scid\ops\eval.d(70):        instantiated from here: ExpressionResult!(Expression!(op,BasicMatrix!(BasicDiagonalMatrixStorage!(RefCounted!(CowArray!(double),cast(RefCountedAutoInitialize)1),cast(DiagonalMatrixStorageType)0)),Expression!(op,double,double)))
test.d(5):        instantiated from here: eval!(Expression!(op,BasicMatrix!(BasicDiagonalMatrixStorage!(RefCounted!(CowArray!(double),cast(RefCountedAutoInitialize)1),cast(DiagonalMatrixStorageType)0)),Expression!(op,double,double)))

Yeah, like I mentioned in a commit message, DiagonalMatrices are in need of quite a bit of attention, they were left behind in a refactoring a while back - should I prioritise it higher? I actually didn't think they would be this useful, but you seem to be using them quite a bit.

I've been working on integrating Dstats into SciD (definitely still a work in progress) and I need diagonal matrices for singular value decomposition and weighted least squares regression.  That's where all this is coming from.  Overall, though, I don't think diagonal matrices are that high a priority.  I just seem to have stumbled on the few use cases where they're needed lately.  Just to give a complete answer, here are the things I would put ahead of diagonal matrices, in order of priority.  Maybe this should be on the wiki, too, with anything you would add:

Lapack wrappers for basic matrix factorizations. I'm already working on this slowly but surely.  SVD and Cholesky are there already because those are the two I happened to have an urgent need for.  I want to get around to QR factorization, eigenvalue decomposition, and LU decomposition.  I understand that inv(m) * v uses LU decomposition under the hood, but I think it should still be exposed in scid.linalg.

Improving the tests.  scid.demo seems to have tests, but they're just not run.  I know OPTLINK gets in the way here, though.

Misc. bug fixes.

Fixing symmetric and triangular matrix operations.  These are basically unusable right now IIRC.  (I haven't really tried to use them because the few things I did try were so horribly broken that I figured they were still a work in progress.)

Benchmarking/performance improvements.


useflags for gentoo (mainly python)

Are these use flags different than the defaults for these packages?

I don't know, if we need these useflags we need it. Defaults can change (users can remove all defaults from all packages, often done in minimal builds) and being more specific will not break anything.

In general we see to define the targets as minimally as possible to decrease maintenance burden down the line for maintaining the rules. Since any time the available packages changes the rosdep rules must be changed to match. And we don't have any way of tracking that at the moment.
There's not much analogy for use flags in the other distros. Typically what's in a package is what's in a package. And users cannot set flags to enable or disable parts. Supporting the use case of a user who explicitly changes defaults is hard. My analogy for that would be that the user added an Ubuntu PPA with a custom version of a package in our database.
I'm not super familiar with how gentoo overlays these rules. If they've turned off all defaults this will still win? Similarly can use flags conflict?

If they've turned off all defaults this will still win?

Because of the way the ebuilds are generated, yes. The issue is that portage would just use the USE flags that are specified.

Similarly can use flags conflict?

Yes, they can definitely conflict (qt4 and qt5 generally conflict, for example).

@tfoote Please review the current state of the PR. I don't know enough about Gentoo to make a decision here.

@tfoote ping

Since the targets work as they currently stand with the default use tags. I'd recommend closing this instead of merging. Although these definitions are more precise they will increase our burden of maintenance and take away the delegation of judgement from the upstream maintainers.

These useflags are not default and ae needed in two ways:

to get the right feature enabled on install time when you install ros manually
in the ebuilds to install the packages with the right features and keep them installed


CRL: Explicit tagging for onlyContainsUserCerts tolerated

OpenSSL 1.0.1f 6 Jan 2014
Is: Implicit and explicit tagging for onlyContainsUserCerts is parsed.
Should: Only implicit tagging should be parsed.

Why is this a problem?

No problem so far. I just reported a violation of the strict standard compliance, which may be a hint to an inaccuracy, and thus may help the openssl developers to improve the quality. I do not know if this non-standard feature has been introduced on purpose; if yes, the motivation could be documented (compatibility with some software? which?); if no, the code in question should be reviewed and/or sanitized. In both cases, 'wontfix' is a possible resolution, with a proper justification.

My guess is that this is done on purpose to work around broken encoders. I haven't tested it but I don't think this is restricted to this one field (I expect that this will happen anywhere there is implicit tagging). In any case changing that behaviour is probably inadvisable unless we can identify a real issue that causes a problem as a result. It is quite possible that there are "real" encodings out there produced by (broken) encoders that do this. If we "fix" it then suddenly we will not be able to read those encodings - which represents an interop break. If there is no harm being caused then we are better off not fixing it from an interop perspective. Of course we won't know if this really is an issue until we pushed such a change - but by then its a bit late.
My thinking at the moment is that this should be "won't fix".

As long as the code supports both implicit and explicit on purpose (i.e. as long as the parser is still under strict control), I agree that 'wontfix' is acceptable, or even recommendable for compatibility. Also, I would not be surprised if some encoders use implicit/explicit improperly (here and/or at other places), because the ASN.1 rules governing implicit/explicit are unfortunately intricate.

Ok - closing this as "won't fix".


Missing required parameter for [Route: en.individuals.edit] [URI: en/individuals/{individual}/edit]...

Illuminate\Routing\Exceptions\UrlGenerationException
Missing required parameter for [Route: en.individuals.edit] [URI: en/individuals/{individual}/edit] [Missing parameter: individual].
:dart: Illuminate\Routing\Exceptions\UrlGenerationException::forMissingParameters
:page_facing_up: /app/vendor/laravel/framework/src/Illuminate/Routing/Exceptions/UrlGenerationException.php
33          $message .= '.';
34
35*         return new static($message);
36      }
37  }

Open in Flare

I believe this was triggered when trying to look through the Sign Language Interpretations in the admin panel. Which had triggered a 500 error. I wonder if this may be related to a route parameters flag being turned off in error.


Fixes faulty bounds checking for keysRemaining in key upload

Upstream https://github.com/cds-snc/covid-alert-server/pull/112

cc @maxneuvians


Unable to use @searchable with sort param, breaks pagination

Describe the bug
When calling the search query on a @model with @searchable generated from the API, it inaccurately returns an empty array when sorting AND paginating. If I remove the sort param, it returns all the values as expected.
To Reproduce
If I have the following model
type Foo
  @model
  @key(fields: ["id"])
  @searchable
 {
  id: ID!
  bar: ID!
  count: Int!
}

the following query
query searchFoo {
  searchFoo(
    filter: { bar: { eq: "SOME_ID" },
    limit: 5,
    nextToken: "SOME_NEXT_TOKEN_OR_UNDEFINED",
    sort:{ field: count, direction: desc }
  ) {
    items {
      id
      count
    }
    nextToken
  }
}

If I comment out sort:{ field: count, direction: desc }, nextToken format is e19097z0-f5f9-22f1-3369-addd5aacf3d0, and I am able to successfully paginate through all the data. if I call it with sort,

the token becomes the float value of the int count
when the nextToken is 0.0, pagination breaks and the payload has an empty array for items, when I should be getting some.

I've also noticed that if I have 9 items, and I remove the limit (it then defaults to 10), it still returns a nextToken value of "0.0", which if used as nextToken returns empty items array. Expected behavior for the return, but strange that nextToken is populated if there are no more items...
Expected behavior
Pagination to work when sorting a search query

Environment
 System:
    OS: macOS 10.15.3
    CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
    Memory: 120.73 MB / 16.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 10.16.0 - ~/.nvm/versions/node/v10.16.0/bin/node
    Yarn: 1.10.1 - /usr/local/bin/yarn
    npm: 6.9.0 - ~/.nvm/versions/node/v10.16.0/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Browsers:
    Chrome: 84.0.4147.105
    Safari: 13.0.5
  npmPackages:
    @apollo/client: ^3.0.0-rc.3 => 3.0.0-rc.3
    @apollo/react-common: 3.1.3 => 3.1.3
    @apollo/react-components: 3.1.3 => 3.1.3
    @apollo/react-hoc: 3.1.3 => 3.1.3
    @apollo/react-hooks: 3.1.3 => 3.1.3
    @apollo/react-testing: 3.1.3 => 3.1.3
    @aws-amplify/auth: 2.1.6 => 2.1.6
    @aws-amplify/core: 2.2.5 => 2.2.5
    @aws-amplify/storage: 2.2.1 => 2.2.1
    @babel/core: 7.5.0 => 7.5.0
    @babel/runtime: 7.5.1 => 7.5.1
    @react-native-community/datetimepicker: 2.2.1 => 2.2.1
    @react-native-community/masked-view: 0.1.6 => 0.1.6
    @react-native-community/netinfo: 4.7.0 => 4.7.0
    @react-navigation/bottom-tabs: 5.0.0 => 5.0.0
    @react-navigation/material-top-tabs: 5.0.0 => 5.0.0
    @react-navigation/native: 5.0.0 => 5.0.0
    @react-navigation/stack: 5.0.0 => 5.0.0
    @types/bugsnag: 2.5.28 => 2.5.28
    @types/jest: 24.0.15 => 24.0.15
    @types/lodash: 4.14.144 => 4.14.144
    @types/moment: 2.13.0 => 2.13.0
    @types/pluralize: 0.0.29 => 0.0.29
    @types/react: 16.8.23 => 16.8.23
    @types/react-native: 0.57.65 => 0.57.65
    @types/react-native-material-textfield: 0.12.3 => 0.12.3
    @types/react-native-vector-icons: 6.4.4 => 6.4.4
    @types/react-test-renderer: 16.8.2 => 16.8.2
    @types/uuid: 3.4.6 => 3.4.6
    amazon-cognito-identity-js: 3.2.0 => 3.2.0
    apollo-cache-inmemory: 1.6.3 => 1.6.3
    apollo-client: 2.6.10 => 2.6.10
    apollo-link-context: 1.0.19 => 1.0.19
    apollo-link-error: 1.1.12 => 1.1.12
    apollo-link-http: 1.5.16 => 1.5.16
    aws-amplify-react-native: 4.0.3 => 4.0.3
    aws-appsync: 3.0.2 => 3.0.2
    aws-appsync-auth-link: 2.0.1 => 2.0.1
    aws-appsync-react: 3.0.2 => 3.0.2
    aws-appsync-subscription-link: 2.0.1 => 2.0.1
    babel-jest: 24.8.0 => 24.8.0
    babel-plugin-module-resolver: 3.2.0 => 3.2.0
    bugsnag-react-native: 2.23.2 => 2.23.2
    graphql: 14.6.0 => 14.6.0
    graphql-anywhere: 4.2.7 => 4.2.7
    graphql-tag: ^2.10.4 => 2.10.4
    husky: 3.0.0 => 3.0.0
    jest: 24.8.0 => 24.8.0
    lodash: 4.17.15 => 4.17.15
    lottie-ios: 3.1.3 => 3.1.3
    lottie-react-native: 3.3.2 => 3.3.2
    metro-react-native-babel-preset: 0.58.0 => 0.58.0
    moment: 2.24.0 => 2.24.0
    pluralize: 8.0.0 => 8.0.0
    prettier: 1.19.1 => 1.19.1
    react: 16.11.0 => 16.11.0
    react-apollo: 3.1.3 => 3.1.3
    react-native: 0.62.2 => 0.62.2
    react-native-animatable: 1.3.3 => 1.3.3
    react-native-animation-hooks: 1.0.1 => 1.0.1
    react-native-camera: 3.8.0 => 3.8.0
    react-native-confetti-cannon: 1.1.3 => 1.1.3
    react-native-device-info: 5.5.8 => 5.5.8
    react-native-fast-image: 7.0.2 => 7.0.2
    react-native-geocoding: 0.4.0 => 0.4.0
    react-native-gesture-handler: 1.5.2 => 1.5.2
    react-native-haptic-feedback: 1.10.0 => 1.10.0
    react-native-image-picker: 0.27.1 => 0.27.1
    react-native-image-resizer: 1.2.0 => 1.2.0
    react-native-image-viewing: 0.1.6 => 0.1.6
    react-native-location: 2.5.0 => 2.5.0
    react-native-material-textfield: github:n4kz/react-native-material-textfield#729008b847eb38129d0b886e98253d4c11f6d4d3 => 0.16.1
    react-native-modal: 11.3.1 => 11.3.1
    react-native-reanimated: 1.4.0 => 1.4.0
    react-native-safe-area-context: 0.6.2 => 0.6.2
    react-native-screens: 2.0.0-alpha.23 => 2.0.0-alpha.23
    react-native-svg: 9.9.4 => 9.9.4
    react-native-svg-transformer: 0.13.0 => 0.13.0
    react-native-vector-icons: 6.6.0 => 6.6.0
    react-test-renderer: 16.11.0 => 16.11.0
    tslint: 5.18.0 => 5.18.0
    tslint-config-prettier: 1.18.0 => 1.18.0
    tslint-config-standard: 8.0.1 => 8.0.1
    tslint-react: 4.0.0 => 4.0.0
    typescript: 3.7.2 => 3.7.2
    uuid: 3.3.3 => 3.3.3
  npmGlobalPackages:
    @aws-amplify/cli: 4.26.0
    amplify-cli: 1.0.0
    amplify: 0.0.11
    gatsby-cli: 2.7.21
    npm: 6.9.0
    react-native-cli: 2.0.1
    react-native-git-upgrade: 0.2.7
    tslint-to-eslint-config: 0.5.1

Hi @VicFrolov
I have a question:

When you put a limit of 5 and you have 9 items , does it directly returning next token as 0.0?
2)Can you tell me which amplify version you are working on?

Hey @akshbhu ,

yes it does.
shoot, I can't remember which version I was on, I'm on 4.27.3 right now, but I updated recently

Another more simple example just turned up with sorting not working on another @model I have:
searchFoo(
  filter: { id: { eq: "bar" } }
  sort: { field: updatedAt, direction: asc } # if I comment this, it returns all the values
) {
  items {
    id
  }
}

assuming the filter attribute is valid, I get the values I want if I comment out the sort line, but if I add it (I tried createdAt and updatedAt), empty array is returned.
I do my PUT/CREATE operations via a custom lambda function, and I set updatedAt/createdAt myself. My format is: 2020-08-13T21:16:43.608Z, perhaps this is causing issues? I doubt it, because when I check out kibana, it is able to parse updatedAt/createdAt without any issues in the GUI.

In case it's helpful, here is the data for one of these new Foo items in ES:
{
  "_index": "newFooExample",
  "_type": "doc",
  "_id": "05d6d41b-81c0-4287-a1c4-6a0e10e00a27|98aa805f-3867-4be6-9b93-cda139f285d0",
  "_version": 1,
  "_score": 1,
  "_source": {
    "createdAt": "2020-08-15T21:16:43.608Z",
    "owner": "98aa805f-3867-4be6-9b93-cda139f285d0",
    "bar": "someBarString",
    "id": "5d2a5a8b-bad8-4d58-bce8-48eb431ebcb8",
    "friendeeUserID": "05d6d41b-81c0-4287-a1c4-6a0e10e00a27",
    "updatedAt": "2020-08-15T21:16:43.608Z"
  },
  "fields": {
    "createdAt": [
      "2020-08-15T21:16:43.608Z"
    ],
    "updatedAt": [
      "2020-08-15T21:16:43.608Z"
    ]
  }
}

@akshbhu bump, don't want this issue to be marked stale

I have the same issue.
When I use sort with field id, it returns correct size of result, but it doesn't work correctly with any other sort field.

Hi @VicFrolov
I think there are 2 issues. One with sorting with createdAt and other with bar field.
For the bar field I tried to reproduce this but I am getting sorted results correctly  using the same filter you described above.
I tried with the latest amplify version.
Can you also tell me if @searchable was added to any existing project or you created a new project when faced this error?
@taneba  @VicFrolov
For the search results when using createdAt , Can you check if in your schema this field has type String or AWSDateTime?
If its a String Type,  can you convert that to AWSDateTime and try the seach again?
Let me know if that works for you?

Closing this due to lack of response. Feel free to comment if the above thing doesnt works for you

Closing this due to lack of response. Feel free to comment if the above thing doesnt works for you

Hi @akshbhu , Sorry for the late reply, for the above case I did a workaround and called it a day, but the issue has crept back in the same fashion.
Exactly same issue as original comment: I have an attribute fooBar that is of type Float!, if I sort, descending on fooBar, I only get the first page of values (or values that are > 0.0), once I reach 0.0, pagination stops. if I remove the sort, I get all values as expected, and the nextToken is not "0.0".
I created this project a while ago, and have definitely upgraded the cli various times, currently on the latest version. I added @searchable a while ago, and ran the migration script in the documentation.


Change gcc-multilib to use i686 gcc compiler.

This is necessary to allow these toolchains to be built for a non linux/amd64 Docker image, and the specifics internally are the same, as we can see from the package details:
g++-multilib needs gcc-multilib (both not supported on aarch64), which uses libc6-dev-i386 for the i686 glibc. In short, this should produce identical code.

bors try --target i686-unknown-linux-gnu

bors r=Emilgardis


Removed extra space from welcome page

Description : Extra space found in the welcome page text "You can change this at any time from  settings"
Fix: Removed extra space

@agarwalishita
Please link the issue in the description.

I suggest to add a small space/margin between the info bar and the page content (release notes). Currently it looks a bit squashed.

sure, I will add that, but currently a test case is failing

but currently a test case is failing

@agarwalishita
I think you can ignore this. It's only a flakiness of our CI. I think the next commit will pass CI.

but currently a test case is failing

@agarwalishita I think you can ignore this. It's only a flakiness of our CI. I think the next commit will pass CI.

Sure, will push the next change then

@htcfreek hey, can you please review and approve?

@agarwalishita thanks!!!


Support for System.Text.Json 4.7.2

Hello @vitalybibikov!
Do you have any plans of upgrading to provide support for System.Text.Json 4.7.2?
I recently updated a nuget library in my project that references System.Text.Json 4.7.2, but unfortunately,
this caused an error in SwashBuckleStartup (builder.AddSwashBuckle...).
Many thanks!

As soon as it will be possible.
Mostly, Microsoft.Azure.WebJobs.Extensions.Http should be updated prior to that :/
Or CustomFotmatter instead SystemTextJsonOutputFormatter should be used.

Hi @vitalybibikov - any guidance on dropping in a custom formatter for this? I was trying to work around the issue till versions align

Can you please explain why it is blocked?

I was getting the same Method not found: 'Void Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonOutputFormatter ... exception upon startup.  I removed the (thankfully) unused project that was referencing System.Text.Json 4.7.2 and the exceptions went away.

same sorta issue
'Method not found: 'Void Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonOutputFormatter..ctor(System.Text.Json.JsonSerializerOptions)'.'

@rory-a-hunt I was trying in  here, currenlty with no luck
https://github.com/vitalybibikov/AzureExtensions.Swashbuckle/tree/branch/trying-update-json

Do you have more information about the error?

Do you have more information about the error?

Hey,
Did small video. Basically login to my account. Then entering my phone
number, then getting message :
'An existing Discord account is already using this number. Please remove it
before it can be used with new account'
On Thu, Jan 14, 2021 at 2:54 PM zackariya el khalfaoui (Infeeny) <
<EMAIL_ADDRESS>wrote:

Do you have more information about the error?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/vitalybibikov/AzureExtensions.Swashbuckle/issues/30#issuecomment-760211150,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABXQCCZDKZ7TSZBR4647IU3SZ3ZS3ANCNFSM4OGXD2EQ
.

--
Pozdrawiam,
Marcin Dudek

Hey,
Did small video. Basically login to my account. Then entering my phone
number, then getting message :
'An existing Discord account is already using this number. Please remove it
before it can be used with new account'
On Thu, Jan 14, 2021 at 2:54 PM zackariya el khalfaoui (Infeeny) <
<EMAIL_ADDRESS>wrote:

Do you have more information about the error?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/vitalybibikov/AzureExtensions.Swashbuckle/issues/30#issuecomment-760211150,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABXQCCZDKZ7TSZBR4647IU3SZ3ZS3ANCNFSM4OGXD2EQ
.

--
Pozdrawiam,
Marcin Dudek

@vitalybibikov , is there a reason not to use Newtonsoft.JSON based IOutputFormatter until the issue is resolved downstream?

Do we have any update on this? I started using this package and it really is the easiest one to set up. I tried some stuff on my end (changing the text output formatter to newtonsoft's
The error I am getting when using 4.7.2:
[2021-05-13T02:48:31.744Z] A host error has occurred during startup operation '4f8f215c-c4e6-4d60-8484-fb7e9da81496'.
[2021-05-13T02:48:31.745Z] AzureFunctions.Extensions.Swashbuckle: Method not found: 'Void Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonOutputFormatter..ctor(System.Text.Json.JsonSerializerOptions)'

I am ready to team up at any time to try to fix this,
Thanks for your work

Hi @vitalybibikov, I was trying to solve this issue for a while and at the end, I ended up using Swashbuckle libraries in a more straightforward way. But what I realised is that you actually don't need to call the function which makes your library fail with later versions of System.Text.Json. You don't need to pass return type to ApiExplorer. So, you can remove this code as well as the failing line. Instead, you can implement a simple IOperationFilter which will pass the right information to the OpenApi schema:
internal class ProducesResponseOperationFilter : IOperationFilter
{
    public void Apply(OpenApiOperation operation, OperationFilterContext context)
    {
        var attrs = context.MethodInfo.GetCustomAttributes(typeof(ProducesResponseTypeAttribute), false)
            .OfType<ProducesResponseTypeAttribute>();
        if (!attrs.Any())
            return;

        foreach (var attr in attrs)
        {
            if (attr.Type == null || attr.Type == typeof(void))
                return;

            if (!context.SchemaRepository.TryLookupByType(attr.Type, out OpenApiSchema schema))
                schema = context.SchemaGenerator.GenerateSchema(attr.Type, context.SchemaRepository);

            var code = attr.StatusCode.ToString();
            if (operation.Responses.ContainsKey(code))
                operation.Responses.Remove(code);
            operation.Responses.Add(code, new OpenApiResponse
            {
                Content = new Dictionary<string, OpenApiMediaType> {
                    { "application/json", new OpenApiMediaType {
                        Schema = schema
                    } }
                }
            });
        }
    }
}

You already do this for several other things, so this should be OK. I hope this helps. I'm sorry, but I don't have enough time to create a proper pull request.

Any progress on this issue?

Just to update on this, we ended up pivoting back to swashbuckle as there were issues with https://www.nuget.org/packages/Microsoft.Azure.WebJobs.Extensions.OpenApi
We now use it in the most unlovely way though. We can't register swashbuckle when we're running our app, so we have a custom version of our app that only registers swashbuckle. We harvest the swagger.json from there and use it for various purposes; but we no longer serve up swagger directly on our API.
It's not a great solution but it's giving us enough to achieve our goals. I see two ways forward here:

maybe moving to .NET 6 makes this a non issue?
perhaps swashbuckle could make use of Newtonsoft.json instead (but I lack the context to know if that's reasonable)

Hi there (thanks in advance),
I'm currently running on this problem.
Can someone highlight which are the conditions that trigger this incompatibility?
We are trying to understand how to change the shape of the project so that the library becomes usable.

If you follow my findings above, you shall be able to use the newer version of System.Text.Json.

If you follow my findings above, you shall be able to use the newer version of System.Text.Json.

⚠ I know this is not acceptable for all cases.
What we have done is upgrade the project to use Func v4.0. It solves the problem for us by upgrading the System.Text.Json.


Enhancement/sexual behaviour

Very much WIP but useful to make things visible. I have also taken out the probability.py file and replaced with the scipy class, because that most closely resembled the approach I had taken so far with my class, but that may be swapped out for numpy if it turns out to be a better approach when I try to integrate this all into a simulation
Next steps for me:

Need to move sexual behaviour stats into a config file and add a randomised selection function
Add calculation of num partners to the simulation so we can see it change over time

The test failing is the one about deaths occurring, which is no longer valid. We can disable it for now, I'll adapt it while addressing #17.


search_remote_tap spec: fix test offline

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.
[x] Have you successfully run brew tests with your changes locally?

As pointed out by @jcount, the method being tested always returns [] immediately if HOMEBREW_NO_GITHUB_API is set even though we stub the JSON response. As a result, we get an expected [] to match ["homebrew/foo/some-formula"] failure when --online isn't passed. Unsetting HOMEBREW_NO_GITHUB_API for this one test should be safe.

Thanks!


Add MAX_CHAR_LENGTH.

Sometimes retweeted articles and comments will exceed the tokens limit, plus a maximum character limit, if this limit is exceeded then the last content of the article will be deleted from the comments until the maximum character limit is met.

https://github.com/bdim404/HackerNews-Summarize-Telegram-Bot/pull/16


Error Installing on Pixel 8 Pro

Hi, getting a failed install message when trying to install from F-Droid.
On latest Android 14

The error is actually this:

Failure [INSTALL_FAILED_DEPRECATED_SDK_VERSION: App package must target
at least SDK version 23, but found 19]

I guess rebuilding for target SDK 23 isn't very hard. Any volunteers?

@ildar  , @nikp79 ,
The list of behavior changes for Android 14 includes this note regarding a workaround for apps with targetSdkVersion < 23 :
https://developer.android.com/about/versions/14/behavior-changes-all#minimum-target-api-level

If you need to test an app targeting an older API level, use the following ADB command:
adb install --bypass-low-target-sdk-block FILENAME.apk

I just tested this on my phone running crDroid / Android 14 and it worked like a champ!  Android will throw up a warning dialog on your phone that you'll need to answer, just click "Install anyway" and this time the installation will not be blocked.
@fedefernandez ,
Thank you for this utility!  It's sweet and "simple" but it filled (and still fills) a great need.  Hopefully someone can step in and pick up where you left off...

My previous success with the ADB install --bypass-low-target-sdk-block option, using the latest Android SDK Platform Tools version "35.0.2 (July 2024)", was on a Redmi Note 8 running the latest version of crDroid 10.7 / Android 14 ...
A few minutes ago I tried the same thing on a Samsung Galaxy Tab S2 running UNOFFICIAL LineageOS 21 / Android 14.  On this device I was getting this error:
P:\platform-tools>adb install --bypass-low-target-sdk-block com.projectsexception.myapplist.open_16.apk
Performing Streamed Install
adb: failed to install com.projectsexception.myapplist.open_16.apk: Error: failed to write; splice failed: EINVAL (Invalid argument)

The solution was to disable Streamed Install with the --no-streaming option, like this:
P:\platform-tools>adb install --no-streaming --bypass-low-target-sdk-block com.projectsexception.myapplist.open_16.apk
Performing Push Install
com.projectsexception.myapplist.open_16.apk: 1 file pushed, 0 skipped. 129.9 MB/s (1718886 bytes in 0.013s)
Success

Android will still throw up a warning dialog; just look for the non-obvious "Install anyway" link (practically buried in the middle of that dialog).
Hope this helps!


using nextForwardToken returned to determine  EOF while pulling CW log

Issue: https://github.com/aws-actions/aws-codebuild-run-build/issues/171
Description of changes:
This change is to use nextForwardToken returned from GetLogEvents response to determine EOF.
AWS CloudWatch Doc: https://docs.aws.amazon.com/AmazonCloudWatchLogs/latest/APIReference/API_GetLogEvents.html#CWL-GetLogEvents-response-nextForwardToken

This change is not the root cause, cancel this PR


error message from CI

https://github.com/upptime/uptime-monitor/pull/214#issue-1757062095
tldr, it will fixed itself after this pr is merged

it is fixed


Internal error on Overiew page

I'm getting this "internal error (500) on Overview page of projects. Although, it's OK on Roadmap.
Environment:
Redmine version                3.4.6.stable
Ruby version                   2.5.1-p57 (2018-03-29) [x86_64-linux-gnu]
Rails version                  4.2.8
Environment                    production
Database adapter               PostgreSQL
SCM:
Git                            2.17.1
Filesystem
Redmine plugins:
progressive_projects_list      3.0.1
BTW, it doesn't matter which combination of checkboxes I set. Even if all checks are off.

Can you please try to install the plugin from the PR #84 and let me know if it works correctly?

I got and apply the new code. It solved part of the problem, which is before adding Target version.
As soon as I add a new version (with or without assigning an issue to it), I'm getting the same error.
By the way, It' OK on Roadmap.

Escape the percent in '%0.0f%%',
Tested on redmine 3.4.6, ruby 2.5.1

Hi. I fixed it. Can you please try again to install the plugin from the PR #84?

Worked all right.
Thanks.

Fixed by #84.