GoodbyeDPI doesn't seem to affect Brave Browser

Operating system / операционная система
Windows 10 22H2
Running as service / Запуск программы как сервис
I installed it as a service / Установил как сервис Windows
Describe the bug / Опишите ошибку программы
Brave, for some reason, isn't affected by active GoodbyeDPI, so if a website is blocked — I still can't open it in Brave while easily opening it in any other browser (Firefox, Chrome, Edge, Opera GX).
Additional information / Дополнительная информация
I tried turning off Security measures in it, but got no result, still won't load.

chrome://flags/#enable-tls13-kyber set to "Disabled"

chrome://flags/#enable-tls13-kyber set to "Disabled"

Works now! Bless you.


target entity component

[ ] Target(Entity) component [edit: Targets(Vec<Entity>)]

so we can have entities that do things to others based on inputs
like control a white hole's open field, or anything really

[ ] :set target 4v2

[x] remember to FromWorld and MapEntities

maybe have 2? so it can make connections?

omb!

okay, having thoughts here.. so an entity can store targets, it can do-whatever-the-op-defines to those targets? this merges this issue and #43 cause a transform propagation can be an op
in process, or in a separate system?

all this junk and all the connections mess will be yeeted the moment we have relations :rainbow:

f2a9621, 4bed595, ddf9872, and ff13bc1


Helper utils for plugin developer

It would be nice to have some utils, developer can use to create their own plugins/custom properties, such as compile-to-CSS which helps to support :visited, :placeholder and other pseudo classes that can not be replicated too easy, others using just plain javascript

This can now easily be solved using the StyleSheet.toCSS-method.


update types to avoid React.ComponentProps with Box

Overview
This PR removes our use of typeof Box which breaks React typings because Box has custom types to support generics (React types don't support generic inference).
Screenshots (if applicable)
NA
Testing

[x] Updated Typescript types and/or component PropTypes
[ ] Added / modified component docs
[ ] Added / modified Storybook stories

I think this may break any consumers that pass the is prop though. Might need to make it more generic like Box<any> :(

I'd like to get typing tests in place. // cc @colinlohner


update to axios 0.18

willl there be an update to axios and other packages to latest versions ??

I use this peace of code as hack:
const jsonApi = new JsonApi({apiUrl:''});
jsonApi.axios = axiosInstance;
No problem until now

There's a security flaw in axios <= 0.18 (see CVE-2019-10742), so upgrading axios to 0.19.0 would be appreciated.

Fixed with PR: https://github.com/twg/devour/pull/178

Fixed in https://github.com/twg/devour/pull/178


[V2 Code Generator] Fix validation method failure for optional properties

Fixes: https://github.com/Azure/autorest.csharp/issues/885

Merging after customer confirmed it works.


Update JSON Library

Description

Upgrade our JSON lib (NewtonSoft.Json) from 10.0.3 to 12.0.3
Apply fix to TypeChangeJsonConverter

Related Issue

N/A
Motivation and Context

Upgrading our packages
Requires Documentation Change

N/A
How Has This Been Tested?

All regressions are passing.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] Refactor (non-breaking change which improves implementation)
[ ] Performance (non-breaking change which improves performance. Please add associated performance test and results)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Ran into some issues with live testing, unsure if unrelated to the current PR.

^^^ Maybe the price multiplier is off somewhere here. These holdings were already existing in IB prior to the launching of the live algo.

^^^ Kind of the same situation here; only have $3k USD worth of holdings but it says that it's $300k USD

^^^ Another issue altogether, seems futures don't have MOO orders. Will open an issue about this shortly

Ran into some issues with live testing, unsure if unrelated to the current PR.

^^^ Maybe the price multiplier is off somewhere here. These holdings were already existing in IB prior to the launching of the live algo.

^^^ Kind of the same situation here; only have $3k USD worth of holdings but it says that it's $300k USD

^^^ Another issue altogether, seems futures don't have MOO orders. Will open an issue about this shortly


Add integration tests

Add Integration Tests
This pull request adds integration tests to the contacts application. For the time being, not all endpoints have been tested, but I was eager to push some code.
The challenging part was figuring out how to launch the contacts application and reset the Postgres database between tests. At this point, I have it pretty well figured out, so it should hopefully be straightforward to add new tests.
Here's a brief summary of the major changes I've made.

Create the MigrateDB function — I needed a way to run migrations repeatedly, so I moved the migration code to its own exported function. Also worth mentioning: the MigrateDB function takes a sql.DB type, so it can be reworked to use something other than gorm.AutoMigrate without breaking the tests.

Running a Test Postgres Container — Contributors to the contacts application don't have to configure a local Postgres database to run integration tests. When the integration tests run, a Postgres container will automatically spin-up. The gRPC server will connect to this Postgres container, some tests will run, then the container will exit and delete itself.

Building and Running Binaries — The integration TestMain will build the gateway and server binaries, run them as separate processes (for the time being), then delete the binaries when finished.

Alright, I updated the pull request with @dmacthedestroyer's feedback. I did a bad job of adding commits as a went, so here's an overview of the changes.

Remove log.Fatal calls inside the "library" code. Errors are now handled in MainTest instead.
Moved the building-and-running code into a file called exec.go to help organize the package.
Wrote a generic RunContainer function inside exec.go that runs a user-specified image. I did this to keep the exec.Cmd code contained in one spot. The PostgresDBConfig calls this function to spin-up a new container.
Added the transport.go file (please suggest a better name if you can think of one). It includes the GetOpenPortInRange function, which helps avoid hard-coding a port number.


[CL][Swap Router Module]: improve TestMultihopSwapExactAmountIn and TestMultihopSwapExactAmountOut

Background
Desired test cases are listed here for TestMultihopSwapExactAmountIn:
https://github.com/osmosis-labs/osmosis/blob/d76deee64911cdd21ae3914ef2912ff633bb960a/x/swaprouter/router_test.go#L131-L140
and here for TestMultihopSwapExactAmountOut:
https://github.com/osmosis-labs/osmosis/blob/d76deee64911cdd21ae3914ef2912ff633bb960a/x/swaprouter/router_test.go#L131-L140
Acceptance Criteria

all proposed test cases are covered
new test cases are added if applicable

Hello anyone working on it? I would like to work with it

Hi @hieuvubk . I'm afraid it’s currently blocked on: https://github.com/osmosis-labs/osmosis/pull/3170
I’m planning to finalize that PR soon. Will lyk once this issue is unblocked. Thanks

Yes thank u

This is now blocked on https://github.com/osmosis-labs/osmosis/issues/3238 since we need proper routing to work first

Some progress towards this has been done in: https://github.com/osmosis-labs/osmosis/pull/3490
However, there is still more to test. swaprouter module is currently on code-freeze until we finish merge to main

We still need to add a test with a concentrated liquidity pool, upon merging the module to main


build(deps-dev): consolidate request package versions

The versions of request package were consolidated to one version to avoid using insecure cryptiles
dependency

:tada: This PR is included in version 0.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Doc Enhancement][User Specific Views][2288508]

Docs Build status updates of commit a58a438:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/task-modules-and-cards/cards/Universal-actions-for-adaptive-cards/User-Specific-Views.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/task-modules-and-cards/cards/Universal-actions-for-adaptive-cards/User-Specific-Views.md
94
3
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/task-modules-and-cards/cards/Universal-actions-for-adaptive-cards/User-Specific-Views.md
94
3
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 71e4bca:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/task-modules-and-cards/cards/Universal-actions-for-adaptive-cards/User-Specific-Views.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


[23] Deprecate the ServerHelper and move the utilities to new utiliti…

…es that are more appropriate for the server running.
resolves #23

replaced by #25


Contact information

Hello I would like to ask more about beta testing of the app. But I cannot find email contact.

Hi, please use the form at www.mitado.com. Thank you.

I tried to contact you here, but I dont understand even this is correct website as you are asking question about budget I have no budget and im not company. And I dont know your company has any relation to this sofware. I expect you are some indie freelance developer and I will find your personal email.

Yes, it's the correct website. There's even a link on the app page.
You can select whatever budget.


[Bug][Sort] Change the restriction of Hive catalogName from not nullable to nullable

What happened
flink hive connector parame of default is hive
What you expected to happen
only one hive cluster, unnecessary parameter
How to reproduce
hive load
Environment
macOS 10.15.7
InLong version
master
InLong Component
InLong Sort
Are you willing to submit PR?

[X] Yes, I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Fixed by #4036


[#3244] Improvement(core): add hidden property names cache for list catalog info

What changes were proposed in this pull request?

cache hidden property names when creating a catalog if necessary
get hidden property names from cache for list catalog info

Why are the changes needed?
Because directly accessing catalog hidden property names requires switching the class loader context, it will incur additional overhead, which will increase as the number of catalog provider types grows.
Fix: #3244
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests

@LauraXia123 @ch3yne Can you help investigate the reasons for the Fronted IT failure?

@jerryshao @FANNG1 It's ready for review now

Since the cache does not solve the cold start problem, close this PR and use #3611


Azure Data Studio: no longer able to 'select top 1000' from table

Azure Data Studio Version: 1.47.1
OS Version: Windows 10.0.19045

when using Azure Data Studio, with a specific DB connection, I get a consistent error now when trying to view the contents of a table from the database view. See attachments for context.

ADSlogs.txt
20240213T120321.zip
This was working correctly for several months, but started failing a month or two ago. Thanks in advance
Steps to Reproduce:

open ADS, choose specific azure DB
right-click a table and choose 'show 10000 records'
observe error

Does this issue occur when all extensions are disabled?: Yes/No
yes

@caobhin
What is the engine edition of this Azure database?
Please run and share output for: SELECT SERVERPROPERTY('productversion'), SERVERPROPERTY ('edition')


Slugify content titles on wide screen

Closes #183
Not sure if I’m overengineering here, but I am auto-inserting the dash for spaces on wide-screen (when we also show chrome://) and showing a space on mobile.

PTAL


Updated new SDK link and branding from Oculus to Meta.

The original "Oculus Integration" package has been deprecated since the release of the Quest 3.
However, luckily the people over at Meta have really thought about backward compatibility and hence we're able to just replace the Oculus Integration with the Meta XR Core SDK package without any technical changes to UltimateXR or our code.

PR #75 has been used instead.


Information on this page about sharing reports is confusing

Please read this page again and make the modifications if required. In the Venn diagram while comparing difference between Power BI Desktop and Service. Sharing is written t be the unique feature of Power BI Service but the text in the first para states the Power BI desktop can also share reports directly.
It is confusing as to sharing reports is unique feature available in Service or Both

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e0ba6184-412b-7e75-ef74-46ae14d62dd6
Version Independent ID: bf97c0bc-6511-e0f0-8df3-9e4f83492fe9
Content: Comparing Power BI Desktop and the Power BI service - Power BI
Content Source: powerbi-docs/fundamentals/service-service-vs-desktop.md
Service: powerbi
Sub-service: pbi-fundamentals
GitHub Login: @mihart
Microsoft Alias: mihart

Thanks for your comment, @devjain1987. This issue has been assigned to the doc author for review.

Hi @devjain1987 ,
Thank you for your suggestion.  We've made the update and set the article to republish.
All the best,
The DOCS team


error with make_lsq_spline() function with spicy 1.3

My issue is about how to use make_lsq_spline() method correctly. I am using spicy 1.3 and numpy 1.16.3.
Reproducing code example:

import numpy as np
import scipy.interpolate as si

x = np.array([0.03350967, 0.06701934, 0.100529  , 0.13403867, 0.16754834,
       0.20105801, 0.23456768, 0.26807734, 0.30158701, 0.33509668,
       0.36860635, 0.40211602, 0.43562568, 0.46913535, 0.50264502,
       0.53615469, 0.56966435, 0.60317402, 0.63668369, 0.67019336,
       0.70370303, 0.73721269, 0.77072236, 0.80423203, 0.8377417 ,
       0.87125137, 0.90476103, 0.9382707 , 0.97178037, 1.00529004,
       1.03879971, 1.07230937, 1.10581904, 1.13932871, 1.17283838,
       1.20634805, 1.23985771, 1.27336738, 1.30687705, 1.34038672,
       1.37389639, 1.40740605, 1.44091572, 1.47442539, 1.50793506,
       1.54144472, 1.57495439, 1.60846406, 1.64197373, 1.6754834 ,
       1.70899306, 1.74250273, 1.7760124 , 1.80952207, 1.84303174])

y = np.array([0.1040807 , 0.10382307, 0.10323297, 0.10276147, 0.10257906,
       0.10253339, 0.10236513, 0.10225094, 0.10208078, 0.10168483,
       0.10103374, 0.10016549, 0.0992114 , 0.09833254, 0.09753467,
       0.09679354, 0.09588709, 0.09510592, 0.09425722, 0.09309047,
       0.09207683, 0.09155676, 0.09093702, 0.09022714, 0.08975676,
       0.08955236, 0.08930825, 0.11663662, 0.11668795, 0.11723575,
       0.11800538, 0.11901272, 0.12012716, 0.12158163, 0.12319893,
       0.12419895, 0.12573243, 0.1254061 , 0.1250039 , 0.12455747,
       0.124469  , 0.1247247 , 0.12429177, 0.12363416, 0.12318804,
       0.12259555, 0.12239772, 0.12225429, 0.12194444, 0.12136568,
       0.12067843, 0.11981264, 0.11873786, 0.11807431, 0.11748397])

knots=np.linspace(x[0],x[-1],5)
t=np.r_[(x[0],)*4, knots, (x[-1],)*4]
spl=si.make_lsq_spline(x,y,t)

Error message:

---------------------------------------------------------------------------
LinAlgError                               Traceback (most recent call last)
<ipython-input-33-c19ae7c64e41> in <module>
----> 1 spl2=si.make_lsq_spline(x,y,t)

/usr/local/lib/python3.7/site-packages/scipy/interpolate/_bsplines.py in make_lsq_spline(x, y, t, k, w, axis, check_finite)
   1015     # have observation matrix & rhs, can solve the LSQ problem
   1016     cho_decomp = cholesky_banded(ab, overwrite_ab=True, lower=lower,
-> 1017                                  check_finite=check_finite)
   1018     c = cho_solve_banded((cho_decomp, lower), rhs, overwrite_b=True,
   1019                          check_finite=check_finite)

/usr/local/lib/python3.7/site-packages/scipy/linalg/decomp_cholesky.py in cholesky_banded(ab, overwrite_ab, lower, check_finite)
    280     c, info = pbtrf(ab, lower=lower, overwrite_ab=overwrite_ab)
    281     if info > 0:
--> 282         raise LinAlgError("%d-th leading minor not positive definite" % info)
    283     if info < 0:
    284         raise ValueError('illegal value in %d-th argument of internal pbtrf'

LinAlgError: 1-th leading minor not positive definite

Scipy/Numpy/Python version information:

import sys, scipy, numpy; print(scipy.__version__, numpy.__version__, sys.version_info)
1.3.0 1.16.3 sys.version_info(major=3, minor=7, micro=3, releaselevel='final', serial=0)

I am not an expert but looks like that sharp discontinuity is causing problems. Probably needs to be handled better.

Changing t=np.r_[(x[0],)*4, knots, (x[-1],)*4]  to t=np.r_[(x[0],)*3, knots, (x[-1],)*3] makes the error go away. You were creating five-fold boundary knots where you likely meant four-fold knots for a cubic spline.

@ev-br thanks a lot. it is really my bad.

@yf13 glad it helped. This corner of scipy.interpolate needs work, so if you have spare cycles, it'd be appreciated!

I was actually following the tutorial here for k=3 case, it duplicates first and last item (k+1) times.  https://docs.scipy.org/doc/scipy/reference/generated/scipy.interpolate.make_lsq_spline.html
@ev-br do you think if the document needs any revisions?

Sure, in the docstring example the internal knots are != x[0]. Thus four-fold boundary knots.
I'd gladly review a PR with an improvement to that example.

Very clear now. Thank you so much @ev-br!

@ev-br no promises, but if you can give a reference to the SVD-based method, maybe I can scrape the time to do the grunt work.

https://www.netlib.org/lapack/lug/node32.html
lists lapack SVD drivers. These routines are available from scipy.linalg.cython_lapack, so the work is to construct the design matrix in the banded storage and use the correspinding lapack routines instead of constructing A.T @ A. Maybe make_lsq_spline can grow a method keyword to switch between the alforithms.

@ev-br is there any way I can contact you privately about this?


partial contiguous storage functionality

Merging with the main branch.
Feature(s) added:

Storage Module: Contiguous Allocation (Partial)


error

Error	14	Resource name 'Sales_Managment_System.Sales_Managment_System.Add_Cat.resources' cannot be used more than once.	sale
error visual basic

@Abdullhfidh Which article were you following when you received this error?


singularize Returns Incorrect Values

irb [2.3.7] (class2)$ Strings::Inflection.singularize("a")  # expect "a"
=> "on"
irb [2.3.7] (class2)$ Strings::Inflection.singularize("gas")  # expect "gas"
=> "ga"
irb [2.3.7] (class2)$ Strings::Inflection.singularize("gas", term: :verb) # expect "gas"
=> "gasses"
irb [2.3.7] (class2)$ Strings::Inflection.singularize("la")   # expect "la"
=> "lon"
irb [2.3.7] (class2)$ Strings::Inflection.singularize("ala")   # expect "ala"
=> "alon"
irb [2.3.7] (class2)$ Strings::Inflection.singularize("ss")  # expect "s"
=> "s"

Using a lot of .* for regexes. Well at least in the case of "a" this is certainly the problem.
Also not sure if this is a feature or bug:
irb [2.3.7] (class2)$ Strings::Inflection.singularize("cars\ntrucks\nbikes")
=> "car\ntrucks\nbikes"

I think bug but saw you were using \A and $ instead of \A and \z so just asking.

Thanks for sharing these!
The gem could do with 'tightening up' some regexes and rules to keep such edge cases at bay. I guess the single characters can be dealt with relatively easily. With others, I don't know, tweaking the rules is rather hard. It may be that some of the rules could do with replacing .* for .+. Do you have time to contribute a PR?
Just curious how did you come about these? Are you actively using the gem in your project? Always keen to get feedback.
The intention was for the methods to accept a single word.
The methods could be extended to accept a variable number of nouns/verbs but I would be less inclined to support chunks of text with newline delimiters and such. So this would be my preferred approach:
Strings::Inflection.singularize("cars", "trucks", "bikes")

Do you have time to contribute a PR?

I'm not opposed to a good ol' fashioned PR. Feel free to remind me in 2 months if I don't do it!
⏳

Just curious how did you come about these? Are you actively using the gem in your project?

Trying, to use it in my project: class2. Currently it uses ActiveSupport for these sorts of things and I'd like to add the word "lightweight" to class2's docs but this would be a programming crime considering it's using ActiveSupport!
The branch with your gems is here.

The intention was for the methods to accept a single word.

I don't want more than 1 I just noticed that you're regex was matching on end of line so wasn't sure if  it was a bug or a feature.


Change default branch name

Would it be possible to change the name of the default branch in this repo from "master" to "mainline" or some other alternative? This is already a convention at Amazon internally, and would be compliant with the recommendation by the IETF: https://tools.ietf.org/id/draft-knodel-terminology-00.html
Thanks!

https://github.com/aws/aws-cdk/issues/8485

I personally very much dislike mainline and would be much more favorable to main. We've been asking our open source support team whether they have any recommendation or standard with respects to the new branch name.
In any case, we are looking into this, but it might take a little while because of the implications (our CI/CD infrastructure is tied to a particular branch name, and changing that will require treading carefully; so we need to plan our way first 😅).


Publish Local SNAPSHOT Configuration Not Found

steps
sbt version: 1.2.8
problem
When I publish YouI (https://github.com/outr/youi) locally and then try to use it from another project I've started getting this:
io.youi#youi-core_2.12;0.11.8-SNAPSHOT: configuration not found in io.youi#youi-core_2.12;0.11.8-SNAPSHOT: 'master'. It was required from io.youi#youi-stream_2.12;0.11.8-SNAPSHOT compile

Actually, I just confirmed this is even happening when I publishLocal with non-snapshots

Thanks for the report. This is a duplicate of #2874.


Requires Visual Studio installed to start the service

This requires Visual Studio installed on the PC to start the service, even when published as a release build.
Trying to run on a PC that does not have Visual Studio installed will give a 1053 error when trying to start the service.
The service will start successfully on a PC other than the one it was built on, provided that Visual Studio is installed on that PC as well.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 75152e30-b486-3ba0-c606-25ada7347b22
Version Independent ID: e797ddfe-a9d3-93a4-61bd-fd6dc9b8d6b4
Content: Tutorial: Create a Windows service app - .NET Framework
Content Source: docs/framework/windows-services/walkthrough-creating-a-windows-service-application-in-the-component-designer.md
Product: dotnet-framework
GitHub Login: @gewarren
Microsoft Alias: dotnetcontent

Disregard: Have realised that the .NET 6.0 runtime needs to be installed on the target PCs.
Don't I feel silly now!


Maps missing tiles on Android devices

Steps to reproduce the behavior:
take a working app (Fine on iOS browser, iOS Cordova, MacOS browser)
Run on Android device - as Cordova App, or just HTML (with identikits tidal code as iOS)

...

Expected behavior
Map to be displayed fully
Current behavior
Only some tiles are displayed (usually just the top part of any map)
Environment

Leaflet version: 1.04
Browser (with version): Safari (Mac); Silk (Android)
OS/Platform (with version): iOS 12; Fire OS <IP_ADDRESS> (same issue on users' Google devices)

Which tile servers are you running? Are you logging tile errors and network traffic?

Or is this the dreaded "I forgot to run map.invalidateSize() when the container changed size so only the top-left part displays properly" problem?

I have two versions of the app using the same code base. The main version has the map tiles embedded in teh app; if the app detects the tiles folder is missing the maps are drawn by reference to OSM. Both versions work fine in any Mac browser and as an iOS app and as a MacOS app. Both versions do not work as an app on Android (same issue with built in and OSM tiles) only some tiles are drawn. If I point a browser at the HTML it works fine on Mac or iOS but not on Android (or Amazon Fire). If you PM me at<EMAIL_ADDRESS>I can point to the code for you to try...
Thanks for your attention to this

I'm gonna go with "public demo which consistently reproduces the bug or it didn't happen". Asking to switch to a private conversation is bad etiquette here.
I suggest reading "How To Ask Questions The Smart Way" and "http://www.chiark.greenend.org.uk/~sgtatham/bugs.html"

I only wanted a PM to avoid posting a private web link in a public forum…
From: Iván Sánchez Ortega<EMAIL_ADDRESS>Reply to: Leaflet/Leaflet<EMAIL_ADDRESS>Date: Wednesday, 17 April 2019 at 15:27
To: Leaflet/Leaflet<EMAIL_ADDRESS>Cc: Jeff Maynard<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [Leaflet/Leaflet] Maps missing tiles on Android devices (#6606)
I'm gonna go with "public demo which consistently reproduces the bug or it didn't happen". Asking to switch to a private conversation is bad etiquette here.
I suggest reading "How To Ask Questions The Smart Way"http://www.catb.org/esr/faqs/smart-questions.html and "http://www.chiark.greenend.org.uk/~sgtatham/bugs.html"http://www.chiark.greenend.org.uk/~sgtatham/bugs.html
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/Leaflet/Leaflet/issues/6606#issuecomment-484112917, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AH5dYzLpFmtluHUjbU2Tz4KIdEjbCChfks5vhy8ygaJpZM4c1BfB.


Add ignore missing fields support

Currently, fields to be ignored must be explicitly specified using a // goverter:ignore FieldName comment.
I.e.:
https://github.com/jmattheis/goverter/blob/edc349e6e6a7f48d692325a952bf4411dcef9470/builder/struct.go#L29
However, in my case I want to ignore missing fields by default.
Possible solutions I can think of:

A new comment, e.g. // goverter:ignoreAll
Allow regexp in the ignore names, e.g. // goverter:ignore To.* (in my case, I could do: // goverter:ignore .*

I'm unsure if this should be implemented, I really like explicitly defining what goverter should do as this makes things more obvious. Adding this, could produce unwanted behavior. F.ex when renaming struct fields goverter would not warn that there are more fields which have no mapping.

This would be a breaking change for us (we actually want goverter to stay strict and report missing fields by default). If you decide to take this on, please expose a global flag to enable strict behavior back on.

Having explicit missing fields definition is a nice feature, so I vote against having this behavior by default.
However, having explicit annotation for pattern matching seems like a reasonable feature to have, and also I don't see how this is a breaking change. This can be done with a new annotation like goverter:ignorePattern

I'm okay with adding another tag like goverter:ignoreMissing that can be added to a method or the converter to support this behavior. This is similar to the proposal in #58.

With v0.16.0 you can use goverter:ignoreMissing to ignore all missing exported fields. https://goverter.jmattheis.de/#/conversion/mapping?id=ignore If you also want to ignore unexported fields, then you've to add goverter:ignoreUnexported


Update Tamnoon_Custome_30062022.json

adding replacement for d9 original rule Ensure IAM users have either access key or console password enabled D9.AWS.IAM.65---> TM.AWS.IAM.65

@marfasegal Is it still relevant?


splash:runjs returns a table, not a string in case of failure

According to the docs, splash:runjs should return a string as the second return value in case of error. But for me it returns a table. Here is an example script:
function main(splash)
  local url = "http://google.com"
  assert(splash:go(url))
  assert(splash:wait(0.5))
  ok, reason = splash:runjs("document.getElementById('foo').click(); ")

  json = require('json')
  assert(ok, json.encode(reason))
  return {
    html = splash:html(),
    png = splash:png(),
    har = splash:har(),
  }
end

And here is the output:
Lua error: [string "function main(splash)
..."]:8: {"js_error_type": "TypeError", "type": "JS_ERROR", "splash_method": "runjs", "js_error_message": "null is not an object (evaluating 'document.getElementById('foo').click')", "js_error": "TypeError: null is not an object (evaluating 'document.getElementById('foo').click')", "message": "JS error: \"TypeError: null is not an object (evaluating 'document.getElementById('foo').click')\""}

Due to this, I can't use the usual assert(splash:runjs) pattern. If I try to just pass reason to assert, I get:
Lua error: [string "function main(splash)
..."]:8: bad argument #2 to 'assert' (string expected, got table)

The behavior was changed in https://github.com/scrapinghub/splash/pull/307, but for no apparent reason, and table doesn't play well with assert indeed.

For what it worths, Lua 5.3 should fix this issue - assert can work if a second argument is a table. But Lua 5.3 support is not implemented in lupa. error can raise any Lua object as well, not only a string, even in Lua 5.2.
So I guess we should fix it for now, and then investigate reverting the fix and switching to Lua 5.3.

Thanks @kmike !


Create Java object from model.yaml

A ModelInfo class created from the model.yaml file would be very useful!

The class ModelDescriptor does this https://github.com/bioimage-io/JDLL/blob/main/src/main/java/io/bioimage/modelrunner/bioimageio/description/ModelDescriptor.java


Error 400 on gapi.client.init for reseller api

It appears the discovery service for https://www.googleapis.com/discovery/v1/apis/reseller/v1/rest is not working.
see https://github.com/google/google-api-javascript-client/issues/517
init makes the following call,
https://content.googleapis.com/discovery/v1/apis/reseller/v1/rest?pp=0&fields=kind%2Cname%2Cversion%2CrootUrl%2CservicePath%2Cresources%2Cparameters%2Cmethods%2CbatchPath%2Cid&key=<API_KEY>
and returns the following error,
{
  "error": {
    "code": 400,
    "message": "Request contains an invalid argument.",
    "status": "INVALID_ARGUMENT",
    "details": [
      {
        "@type": "type.googleapis.com/google.rpc.BadRequest",
        "fieldViolations": [
          {
            "field": "kind,name,version,rootUrl,servicePath,resources,parameters,methods,batchPath,id",
            "description": "Error expanding 'fields' parameter. Cannot find matching fields for path 'kind'."
          }
        ]
      }
    ]
  }
}

note: following steps here, https://developers.google.com/admin-sdk/reseller/v1/quickstart/js produces the error.

I have the same issue with the reseller API.
My code worked for months and stopped a couple of weeks ago with the same error 400

This is being investigated.

This was fixed.


Removed end-of-stream, finally as fast as morgan.

@davidmarkclements 🎉 !

chatting with @mafintosh - we may need to check for on .('close' event,
way to test this is to forge an HTTP req (e.g. via telnet) that doesn't end

also we need to a check that handlers aren't called twice

req.on('close') or res.on('close')?
We are currently avoid double calls by removing our listener: https://github.com/mcollina/express-pino-logger/blob/master/logger.js#L28-L29

ah yes - I wonder if it's faster to have a flag check? back in the jQuery days it was always faster to flag check than to toggle listeners

What about req or res? Can you add a unit test for this case, I'm missing why that could happen.
Regarding the flag check, we still need to remove the handler from 'error'.


feature/testingCenterCameras -> dev

This change is

Reviewed 16 of 16 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

app/src/main/java/edu/byu/suite/features/campusCameras/CampusCamerasMainActivity.kt, line 12 at r1 (raw file):

 */
class CampusCamerasMainActivity: ByuActivity() {

Looks like your kotlin default is to use spaces instead of tabs. Please change that in your preferences and CMD-OPT-L all of these files

app/src/main/java/edu/byu/suite/features/campusCameras/CampusCamerasMainActivity.kt, line 19 at r1 (raw file):

        fragmentManager.beginTransaction().replace(R.id.frameLayout, CamerasGridFragment()).commit()
    }

Remove excess new lines

app/src/main/java/edu/byu/suite/features/testingcenter/controller/TestingCenterMainActivity.java, line 19 at r1 (raw file):

		super.onCreate(savedInstanceState);
		setContentView(R.layout.activity_view_pager);
		ViewPager viewPager = findViewById(R.id.viewPager);

Use kotlin extensions

app/src/main/java/edu/byu/suite/features/testingcenter/controller/TestingCenterMainActivity.java, line 20 at r1 (raw file):

		setContentView(R.layout.activity_view_pager);
		ViewPager viewPager = findViewById(R.id.viewPager);
		ByuFragmentPagerAdapter adapter = new ByuFragmentPagerAdapter(getFragmentManager(), new ByuFragment[] {new ScoresFragment(), CamerasGridFragment.Companion.newInstance("TESTING CENTER LINES", "testingCenter"), new ScheduleFragment()});

I don't think "Companion" should be needed here. Talk to me if you have issues removing it

app/src/main/java/edu/byu/suite/features/testingcenter/controller/TestingCenterMainActivity.java, line 20 at r1 (raw file):

		setContentView(R.layout.activity_view_pager);
		ViewPager viewPager = findViewById(R.id.viewPager);
		ByuFragmentPagerAdapter adapter = new ByuFragmentPagerAdapter(getFragmentManager(), new ByuFragment[] {new ScoresFragment(), CamerasGridFragment.Companion.newInstance("TESTING CENTER LINES", "testingCenter"), new ScheduleFragment()});

Save "TESTING CENTER LINES" and "testingCenter" as static const vals somewhere (wherever makes most sense). Also, are these needed?

app/src/main/java/edu/byu/suite/features/testingcenter/controller/TestingCenterMainActivity.java, line 27 at r1 (raw file):

			public void onPageSelected(int position) {
				if (position == 1) {
					adapter.executeCodeOnFragment(getFragmentManager(), 1, fragment -> ((CamerasGridFragment) fragment).updateShowingImages());

In kotlin, the way you cast is using the as keyword. For instance, you will want this to be your lambda:
(fragment as? CamerasGridFragment)?.updateShowingImages()

support/src/main/res/layout/camera_feed_cardview.xml, line 8 at r1 (raw file):

											 android:layout_margin="2dp">

	<android.support.v7.widget.CardView

Normally, when using card view, you make that the parent layout. Then, inside of it, you would put your ConstraintLayout. This one, however, doesn't feel like it needs a Constraint layout at all.... Talk to me if you have questions

support/src/main/res/layout/camera_feed_layout.xml, line 6 at r1 (raw file):

											 android:layout_width="match_parent"
											 android:layout_height="match_parent"
											 android:layout_gravity="center">

Why do we need the center gravity? Aren't we constraining everything anyways?

support/src/main/res/layout/camera_feed_layout.xml, line 12 at r1 (raw file):

		android:layout_width="match_parent"
		android:layout_height="match_parent"
		android:adjustViewBounds="true"

What does this one do?

support/src/main/res/layout/camera_feed_layout.xml, line 23 at r1 (raw file):

		android:layout_height="0dp"
		android:background="@drawable/image_title_gradient"
		app:layout_constraintDimensionRatio="4:1"

Can you show me how to do this?

support/src/main/res/layout/camera_feed_layout.xml, line 33 at r1 (raw file):

		android:layout_width="0dp"
		android:layout_height="2dp"
		android:layout_margin="3dp"

What is this margin doing?

support/src/main/res/layout/cameras_fragment_recycler_layout.xml, line 7 at r1 (raw file):

											 android:layout_height="match_parent">

	<ProgressBar

What is this guy?

support/src/main/res/layout/cameras_fragment_recycler_layout.xml, line 27 at r1 (raw file):

		<include
			android:id="@+id/camera_feed_full_screen"
			layout="@layout/camera_feed_layout"

So why did you decide to divvy this one out into it's own layout file?

support/src/main/res/values/colors.xml, line 25 at r1 (raw file):

	<color name="textLighter">#37000000</color>
	<color name="loginHintTextColor">#55000000</color>
	<color name="transparent">#00000000</color>

Who uses this?

Comments from Reviewable

Review status: 12 of 16 files reviewed at latest revision, 14 unresolved discussions.

app/src/main/java/edu/byu/suite/features/campusCameras/CampusCamerasMainActivity.kt, line 12 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Looks like your kotlin default is to use spaces instead of tabs. Please change that in your preferences and CMD-OPT-L all of these files

Done.

app/src/main/java/edu/byu/suite/features/campusCameras/CampusCamerasMainActivity.kt, line 19 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Remove excess new lines

Done.

app/src/main/java/edu/byu/suite/features/testingcenter/controller/TestingCenterMainActivity.java, line 19 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Use kotlin extensions

This is still a java file because I just modified a few lines but I can convert it to Kotlin and use the Kotlin extensions. Should I do that?

app/src/main/java/edu/byu/suite/features/testingcenter/controller/TestingCenterMainActivity.java, line 20 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
I don't think "Companion" should be needed here. Talk to me if you have issues removing it

You need "Companion" when you are accessing a Kotlin static constant from a Java class. It might be worth it to rewrite this class in Kotlin and then I wouldn't need it.

app/src/main/java/edu/byu/suite/features/testingcenter/controller/TestingCenterMainActivity.java, line 20 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Save "TESTING CENTER LINES" and "testingCenter" as static const vals somewhere (wherever makes most sense). Also, are these needed?

I use these to set the fragment title which is used on the testing center viewpager and to set the filter to filter the list for testing center cameras. The idea behind this is that if in the future we want to reuse this fragment in another activity and we wanted to filter out other cameras you would just but the category string in here and it would filter by that.

app/src/main/java/edu/byu/suite/features/testingcenter/controller/TestingCenterMainActivity.java, line 27 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
In kotlin, the way you cast is using the as keyword. For instance, you will want this to be your lambda:
(fragment as? CamerasGridFragment)?.updateShowingImages()

Right, maybe I can convert this file to Kotlin.

support/src/main/res/drawable/image_title_gradient.xml, line 7 at r1 (raw file):

	<gradient
		android:angle="90"
		android:endColor="@color/transparent"

This is where I use the transparent color from the color res folder.

support/src/main/res/layout/camera_feed_cardview.xml, line 8 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Normally, when using card view, you make that the parent layout. Then, inside of it, you would put your ConstraintLayout. This one, however, doesn't feel like it needs a Constraint layout at all.... Talk to me if you have questions

I've made it so that the CardView is the parent layout and put a ConstraintLayout inside of it because the layout_constraintDimensionRatio uses it to make it square. I also set constraints on the ProgressBar.

support/src/main/res/layout/camera_feed_layout.xml, line 6 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Why do we need the center gravity? Aren't we constraining everything anyways?

It was unnecessary and has been removed.

support/src/main/res/layout/camera_feed_layout.xml, line 12 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
What does this one do?

This allows the image view to adjust it view bounds to preserve the aspect ratio of the drawable. It is important for use in the expanded view. Otherwise, the drawable stays really small while the image view fills the screen.

support/src/main/res/layout/camera_feed_layout.xml, line 23 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Can you show me how to do this?

Yes. A simple explanation is that because the width is constrained but the height is not, it will make the height 1/4 of the width.

support/src/main/res/layout/camera_feed_layout.xml, line 33 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
What is this margin doing?

This gives the progress bar some room from the edges of the view. I thought it looked better than having it squished against the edge because the progress bar has rounded ends that look weird to me when they are touching the sides of the view.

support/src/main/res/layout/cameras_fragment_recycler_layout.xml, line 7 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
What is this guy?

I noticed that on the iOS version of the app there is a loading bar in the center as it loads the list of camera streams (not the camera images itself, just the list of them). This is the same thing. It shows up on the center of the blank screen while it is retrieving the camera streams. Usually it loads fast enough that you don't really see it but it is helpful for slow connections.

support/src/main/res/layout/cameras_fragment_recycler_layout.xml, line 27 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
So why did you decide to divvy this one out into it's own layout file?

It is the same layout that is used in the card views so I didn't want to copy and past that into here. That way, if we want to change how the progress bar looks, for example, we can just change it in the one layout file and it shows up in the card views and the expanded view.

support/src/main/res/values/colors.xml, line 25 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Who uses this?

The gradient for the image view on testing center uses it. I put a comment on the file where it is used.

Comments from Reviewable

Reviewed 5 of 5 files at r2.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

app/src/main/java/edu/byu/suite/features/testingcenter/controller/TestingCenterMainActivity.java, line 27 at r1 (raw file):
Previously, aarowhead (Aaron Hill) wrote…
Right, maybe I can convert this file to Kotlin.

Do it

app/src/main/java/edu/byu/suite/features/testingcenter/controller/TestingCenterMainActivity.java, line 16 at r2 (raw file):

public class TestingCenterMainActivity extends ByuActivity {

	private static final String TESTING_CENTER_LINES = "TESTING CENTER LINES";

rename variable and make value title cased

support/src/main/res/layout/camera_feed_layout.xml, line 33 at r1 (raw file):
Previously, aarowhead (Aaron Hill) wrote…
This gives the progress bar some room from the edges of the view. I thought it looked better than having it squished against the edge because the progress bar has rounded ends that look weird to me when they are touching the sides of the view.

Show this one to me

support/src/main/res/layout/cameras_fragment_recycler_layout.xml, line 7 at r1 (raw file):
Previously, aarowhead (Aaron Hill) wrote…
I noticed that on the iOS version of the app there is a loading bar in the center as it loads the list of camera streams (not the camera images itself, just the list of them). This is the same thing. It shows up on the center of the blank screen while it is retrieving the camera streams. Usually it loads fast enough that you don't really see it but it is helpful for slow connections.

Gotcha. Would this be easier to use a view pager for? Or do you like having the progress bar show/hide functionality?

Comments from Reviewable

Reviewed 4 of 4 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

app/src/main/java/edu/byu/suite/features/testingcenter/controller/TestingCenterMainActivity.kt, line 17 at r3 (raw file):

	companion object {

		const val LINES_TITLE = "Testing Center Lines"

Can these be private?

support/src/main/res/layout/cameras_fragment_recycler_layout.xml, line 4 at r3 (raw file):

<ViewSwitcher
	xmlns:android="http://schemas.android.com/apk/res/android"
	android:id="@+id/loading_grid_view_switcher"

CMD-OPT-L

Comments from Reviewable

Review status: 15 of 17 files reviewed at latest revision, 2 unresolved discussions.

app/src/main/java/edu/byu/suite/features/testingcenter/controller/TestingCenterMainActivity.kt, line 17 at r3 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Can these be private?

Done.

support/src/main/res/layout/cameras_fragment_recycler_layout.xml, line 4 at r3 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
CMD-OPT-L

Done.

Comments from Reviewable

Reviewed 2 of 2 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Auto-add mapname/description to config if missing

if these aren't in the config or main anywhere, add them
call SetMapName( "Just another Warcraft III map" )
call SetMapDescription( "Nondescript" )

From what I observed, these were of lower importance in pre-Reforged, when maps in listings only derived their map name from the 512-byte header before the MPQ. Reforged parses and runs the entire script for all maps it encounters to get these values out of config. While this allows localizations, it's the reason Reforged times out from bnet when opening large folders in its listing.
TLDR: important. better yet, try to match the string in war3map.wts and insert the TRIGSTR_1234 from there.

Ya, I copy/pasted "Just another Warcraft III map" as a placeholder. When actually coding, should definitely use the correct name if possible.


feat: use extra_agg_config_file_system and register bagpacker

PR Type

Improvement

Related Links
https://github.com/autowarefoundation/autoware.universe/pull/537
Description

use extra_agg_config_file_system and register bagpacker diag in it

Review Procedure

Please confirm related PR is merged.
In rqt_robot_monitor, /system/debug_data_logger/storage_error is appeared.

Remarks

Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.

[x] Code follows coding guidelines
[x] Assign PR to reviewer

Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.

[x] Commits are properly organized and messages are according to the guideline
[x] Code follows coding guidelines
[ ] (Optional) Unit tests have been written for new behavior
[x] PR title describes the changes

Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.

[ ] All open points are addressed and tracked via issues or tickets
[ ] Write release notes

CI Checks

Build and test for PR: Required to pass before the merge.
Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

I'll change ready after finishing sync-upstream for tier4/autoware.universe

I finished sync-upstream for tier4/autoware.universe https://github.com/tier4/autoware.universe/pull/20.
So, I'll merge this PR.


SecGPT - LlamaIndex Integration

Description
SecGPT is an LLM-based system that secures the execution of LLM apps via isolation. The key idea behind SecGPT is to isolate the execution of apps and to allow interaction between apps and the system only through well-defined interfaces with user permission. SecGPT can defend against multiple types of attacks, including app compromise, data stealing, inadvertent data exposure, and uncontrolled system alteration. We develop SecGPT using LlamaIndex because it supports several LLMs and apps and can be easily extended to include additional LLMs and apps. We implement SecGPT as a personal assistant chatbot, which the users can communicate with using text messages.
New Package?
Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

[ ] Yes
[x ] No

Version Bump?
Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

[ ] Yes
[x ] No

Type of Change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Added new unit/integration tests
[x ] Added new notebook (that tests end-to-end)
[ ] I stared at the code and made sure it makes sense

Suggested Checklist:

[x ] I have performed a self-review of my own code
[x ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added Google Colab support for the newly added notebooks.
[x ] My changes generate no new warnings
[x ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I ran make format; make lint to appease the lint gods

@Yuhao-W submitted a PR to your fork/main branch. It brings in the necessary pants build files to pass our checks.
https://github.com/llm-platform-security/llama_index/pull/1

@Yuhao-W looks like lint/fmt checks are failing. Can you please run:
make lint and make format then commit and push?

@nerdai Thanks, Andrei. I just fixed this.

@nerdai Hi, Andrei. I see that some checks failed. Is there anything that needs to be changed?

I think I figured out the errors and updated the package by mainly including dependency information in the pyproject.toml file under our package path. I also set up a unit test environment and ran it locally. The unit test was passed on my end. @nerdai  and/or @logan-markewich, would appreciate if you can review the changes!

I think I figured out the errors and updated the package by mainly including dependency information in the pyproject.toml file under our package path. I also set up a unit test environment and ran it locally. The unit test was passed on my end. @nerdai and/or @logan-markewich, would appreciate if you can review the changes!

thanks, lets run the checks and see what happens!

I think I figured out the errors and updated the package by mainly including dependency information in the pyproject.toml file under our package path. I also set up a unit test environment and ran it locally. The unit test was passed on my end. @nerdai and/or @logan-markewich, would appreciate if you can review the changes!

thanks, lets run the checks and see what happens!

Thanks @andrei, it failed again : ( this time because the requirements.txt was named requirements.tx
I have made a new commit. Not sure but we may still see errors after, would appreciate a deeper look if it fails. Thank you!

@logan-markewich we're still running into some errors here. Perhaps we need to add a dependency in pants? This is the error we're seeing in the tests:
llama-index-packs/llama-index-packs-secgpt/llama_index/packs/secgpt/sandbox.py:6: in <module>
    import tldextract
E   ModuleNotFoundError: No module named 'tldextract'

But tldextract is indeed included in the pyproject.toml as a dep for the project.
(CC @Yuhao-W)

@Yuhao-W got checks to pass 🥳. Needed to remove the requirements.txt file as it was tripping up pants having deps listed in both requirements.txt and pyproject.toml

@nerdai Thanks for the feedback on the PR!

Hi @nerdai . Thank you for checking with me. I’m currently working on it and will be able to make a push over the weekend.

@Yuhao-W Thanks for this contribution! I'm really excited about this :)
I left some comments on your PR. As another blanket comment, I do think your pack would greatly improve if you were able to include some doc/class strings throughout your code (i.e., quick descriptions of funcs/classes and its params/args).

Thanks for your suggestions. I have addressed all your comments and included doc/class strings for all classes and functions.


Remove the restriction of key prefix to Cache

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Fixed issues
#62

👍


Feature request: quit after all windows are closed

A lot of applications offer an option to quit the application when the last window/file is closed. I personally prefer this over keeping the application open, especially if it's a lightweight app such as TableTool.

Thank you for sharing. Do you believe this should be the default behavior?
If yes, can you please reference a few other applications where this is also the default behavior?
I am checking a few built-in apps:

TextEdit -- stays open
Numbers -- stays open
Preview -- stays open

Actually I can't find any app that works the way you describe.

Hi! You’re right, it’s the default behavior of Apple’s own apps, so you’re not wrong to do it the same way. I personally would prefer an option to change that default behavior, but I don’t expect Apple to ever do that. 😅 I’m traveling without a laptop right now, so I’ll get back to you with some examples next week when I’m back home!

I was asked to reopen the issue from someone who can possibly implement this. 👍

I know this issue is closed but just adding some more context in case it helps anyone in the future:
Notes is primary a single-window app, not a document-based app. Each individual note can be thought of as a document, but the app intentionally does not correspond individual notes to files on disk. Notes is designed as a single-window app, just like how System Preferences is designed as a single-window app. Single-window apps that don't do useful tasks in the background (e.g., iTunes can still play music when you close the main window) close when the primary window is closed.
In general, document-based apps don't close when the last window is closed. The rationale behind this is probably that the user might want to close the open document and then immediately open/create another one. TableTool is design as a document-based app, so it should not close on last window close either.

@szhu Thanks for providing some context! I haven't really thought about that at all, but it does make sense. I guess my reasoning is that all those document-based apps that stay open are cluttering my app switcher even though they don't have a window associated to them.
Sent with GitHawk


Implement remainder of todos for local Vcs

Description

Testing Instructions

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#8871  👈
#8870
#8826
#8780
#8847
#8845 : 1 other dependent PR (#8846 )
#8843
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bgw and the rest of your teammates on  Graphite

Moved to the next.js repo: https://github.com/vercel/next.js/pull/68474


Sample AccountController does not populate ViewBag.LoginProviders on Login

ViewBag.LoginProviders is populated on GET Login action, but not on POST, which results in a RuntimeBinderException when trying to login.
https://github.com/aspnet/Identity/blob/dev/samples/IdentitySample.Mvc/Controllers/AccountController.cs#L42

Update the sample to match the templates

267d0ac20671ec80ae0d45c1988f1347a2dff0b9

Fixed this specific login provider bug.  Updating the samples entirely will be done later


Pod and SwiftPM have different module names

When using Podfiles, you have to import as SwiftCardStackUI, while SwiftPM requires importing as CardStack.

Good catch! There was already a pod named CardStack so I had to use another name for CocoaPods. Turns out we can still define the module name. Both CocoaPod and SPM will use CardStack on the next release.

Fixed in version 0.0.4


Repeat-Interval does not accept wide range/large input

I can not set R-Interval on for example 3600e3700.
Can this be fixed or is this not possible?

Hi Actually 3600e3700 is very large number for range we need to find out different solution as exponential is supported number and allowed by browser we thought to use e for range. But looks like you need to give time interval of 1 hour . We are again doing rework on it


Style sheet lists sometimes cause non-deterministic behavior

I have noticed a small bug regarding the current implementation of multiple style sheets and collisions. Despite each layer of the style sheet being written in the intended order, the current cache implementation stores all properties and tracked entities in a hash map based of the asset ID of individual style sheet assets. As assets may have their ID assigned at random, depending on the order they are loaded, this causes the order in which style sheets to be applied to have a random effect with each client restart.
My proposed solution to this would be to change away from the style sheet asset ID behind used as the identifier, and instead using the id of the Entity that contains the StyleSheet component.
https://github.com/afonsolage/bevy_ecss/blob/e32ed2cd4e90308ad3f4482497c592143bd097e6/src/system.rs#L100-L107
https://github.com/afonsolage/bevy_ecss/blob/e32ed2cd4e90308ad3f4482497c592143bd097e6/src/property/mod.rs#L250-L257
Shown above in system.rs line 103, and property/mod.rs line 254, I believe that switching to using an Entity as a map key would be better here, but I'm unsure if this is the best approach. My reasoning is that because all style sheets are stored with a different key, they are not applied at the same time. If an entity has 3 style sheet assets attached to it, all 3 assets should be merged into the same (TrackedEntities, SelectedEntities) and thus all be applied at the exact same time as if they all existed within the same asset.
I would like some feedback before opening a PR.
https://github.com/afonsolage/bevy_ecss/blob/e32ed2cd4e90308ad3f4482497c592143bd097e6/src/property/mod.rs#L325-L336
Here, in property/mod.rs line 333, it's shown how the order of style sheets can be rearranged when being applied to an entity after already being cached. Since this iterator is based off the arbitrary order of Asset IDs instead of the order in which they were written, all style sheets have a separate ID and are effectively applied in a random order.

I understood where the problem is. Like you said, the root of the problem is in StyleSheetState since it doesn't track the order of insertion when prepare_state is ran and insert StyleSheetAsset ids.
At this point I think the better approach (or at least the one that I would take) is to rework StyleSheetState to be aware of insertion order.
Since StyleSheetState is precomputed whenever a stylesheet has to be applied, this component can be backed by a Vec. I used HashMap just for convenience. At the top of my head and taking a quick look on the code, I don't see any problems by switching from HashMap to Vec, since the O(n) cost wont matter since usually the StyleSheet count should be fewer than a couple of hundreds at its peak.

@afonsolage Implemented.


I actually tested logfire with the new inline-snapshot version before the release, but only my branch, where I added the Is(...) expressions.
#149 should solve this issue.
I don't know if you are interested in commit where I added the Is(...) expressions and used --inline-snapshot=update to change some strings and remove some default values.
https://github.com/pydantic/logfire/compare/main...15r10nk:logfire:inline-snapshot-update-fixes
The resulting code reports no changes for update any more, which is also something you asked for.

fixed in 0.15.1


fix: allow insert with subselect

Summary
Adds logic to parse a statement and validate if the query is mutating a single table while including a subselect statement.
Details
The core logic change uses a regex /select\s+.*?\s+from\s+(\w+)/gi to check each individual statement within a batch call. It looks for a SELECT FROM and grabs the ensuing table name. Then, it checks if this table name exists in the tables names array returned from the SQL parser's normalize method. If so, "ignore" this table by filtering it out of the array.
If the tables array's names only affect a single table, the statement can be executed; else, more than one table is being mutated, and it'll throw.
How it was tested
Added two tests:

when batching single statement, including subselect, affecting two tables throws an error
when batching mutations works with a subselect

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

@dtbuchholz In general this looks good. Your branch is not starting off the tip of main, can you either rebase it or merge main into it?

cool, thanks! as far as merging, since this is a bug fix, i can merge into main?

cool, thanks! as far as merging, since this is a bug fix, i can merge into main?

Yeah, merge away.  After the merge you can also publish via the Publish action.  Looks like this will be 4.4.1

@dtbuchholz Hope it's ok, I'm gonna merge and publish so I can get this into the local tableland release today.


ci: use netlify preset on cf pages

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[x] Bugfix
[ ] Feature
[ ] Refactoring

What's new?

[x] just noticed somehow deployment to cf-pages not working properly https://github.com/kodadot/nft-gallery/pull/4853#issuecomment-1407416414. I guess that nitro is still not stable (experimental) on cf-pages. source: https://nitro.unjs.io/deploy/providers/cloudflare#cloudflare-pages

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[ ] I've posted a screenshot of demonstrated change in this PR

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[ ] My fix has changed something on UI; a screenshot is best to understand changes for others.

pay 50 usd
if it works

😍 Perfect, I’ve sent the payout
💵 $50 @ 36.68 USD/KSM ~ 1.363 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0xf01680c87802d7d10ecb76ace48469c4ba80a153b3539a102ce8723a5ed2c3bd
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


Invalid limits (NPROC) set after switching to the user "root" using sudo inside the container (pam_limits.so in sudo session)

Required information

Distribution: Ubuntu Server
Distribution version:16.04
The output of "lxc info" or if that fails:

Kernel version: 4.4.0-169-generic
LXD version: 3.0.3-0ubuntu1~16.04.1
Storage backend in use: LVM

Issue description
In a non-privileged container, when switching to the "root" user using sudo from a user logged in via SSH, limits (e.g. NPROC) are not set correctly despite pam_limits.so enabled in /etc/pam.d/sudo.
Current behavior:
Limits are set only within the allowed limits for a regular user from which switching to the "root" account has been made.
Expected behavior:
limits for the "root" user should be set according to the entries in the /etc/security/limits.conf file
Additional informations:
After logging in directly to the root account using SSH, the limits are set correctly:
root@ap-test-debian9:~# ulimit -u
9000
root@ap-test-debian9:~# ulimit -Hu
10000

Steps to reproduce
The test was performed on the debian 9 system inside the container.

Enable pam_limits.so in /etc/pam.d/sudo

#%PAM-1.0
session    required   pam_limits.so

@include common-auth
@include common-account
@include common-session-noninteractive

Set limits in the /etc/security/limits.conf file are as follows:

* soft nproc 2000
* hard nproc 3000
test soft nproc 5000
test hard nproc 7000
root soft nproc 9000
root hard nproc 10000

Login to a standard user via SSH
Check the limits of a regular user ("test") logged in using SSH:

test@ap-test-debian9:~$ ulimit -u
5000
test@ap-test-debian9:~$ ulimit -Hu
7000

Switch to the "root" user using sudo and check the limits:

test@ap-test-debian9:~$ sudo su
root@ap-test-debian9:/home/test/test# ulimit -u
5000
root@ap-test-debian9:/home/test/test# ulimit -Hu
7000

The following message appears in auth.log:
sudo: pam_limits(sudo:session): Could not set limit for 'nproc' to soft=9000, hard=10000: Operation not permitted; uid=0,euid=0

When the (NPROC) limits for the "root" account are set below the limits for the "test" account, the error does not occur and the limits are set correctly.

Nothing LXD can do about this. Unprivileged containers are as their name implies, unprivileged.
So root in the container doesn't have any more rights to raise ulimit than a random user on the system.

Limits for non-real-root can only be lowered, never be raised, that's what's hitting you there.

thank you for the quick reply.
When logging in directly with SSH to the "root" account, the limits are set correctly.
If I understand You correctly, the problem is not in setting limits for the "root" account (as it happens when logging in directly to this account), but in raising / changing them using pam_limit.so in sudo when switching from different user?

Correct, sshd itself likely has a high limit so logging in as root either causes no changes or a lowering.
Your user session running sudo is on a low value and needs to be raised, which isn't possible.


Add remote builder pattern.

Open to feedback! I have worked with a handful of folks looking for examples on how to run a potentially more expensive build step separately from the rest of a given build to conserve costs. This pattern displays how to do so.
(first time contributing here, so please let me know if there are other guidelines for adding examples. thank you!)

Thank you!  Can you add license headers?

Quickly checking in - please let me know if I need to add anything else to make this useful!

Sry about that! Next time feel free to use the re-request review button so it comes back into my Pull Requests tab:


Failed to construct OpenVINOImageInference ... can't protect

My server :
OS : Ubuntu 18.04 LTS
CPU : Intel® Xeon(R) Gold 6248R CPU @ 3.00GHz × 96
RAM : 376GB
I'm using openvino_2020.4.287 to detect the person in the .mp4 file .
model : ssd_mobilenet_v1_coco_2018_01_28 .
First , I use the model_optimizer convert the tensorflow model ( .pb ) to OpenVINO IR model ( .xml + .bin ) .
My OpenVINO IR model -> version = 10 , type = FP32 , batch = 16 .
Then I use the DL workbench to convert my model from FP32 -> INT8 .
I have run the pipeline :
gst-launch-1.0 -v  filesrc location=/root/videos/output.mp4 ! decodebin ! videoconvert ! video/x-raw,format=BGRx ! gvadetect model=/root/models/16_int8/frozen_inference_graph_16_INT8.xml device=CPU ! queue ! gvafpscounter ! fakesink
It's successful : FPSCounter(average): total=534.66 fps, number-streams=1, per-stream=534.66 fps
Then I started running multiple pipeline same times ( MultiStream ) .
I add five at a time 5 , 10 , 15 .
It's work normal .
But when I add the pipeline to 20 , there was a problem :
Failed to construct OpenVINOImageInference ... can't protect

Then I try to run 19 pipeline , it's work normal :

The error seems to mean that my CPU cannot be loaded .
But when I'm running 19 pipeline , my cpu usage only 30% .
So , what problem did i get ?
Please excuse my poor English.
Thanks all,
Leo

Hi Leo,
I recommend to set "model-instance-id" parameter of gvadetect element. (Identifier for sharing a loaded model instance between elements of the same type. Elements with the same model-instance-id will share all model and inference engine related properties). It allows to run multichannel pipelines with reusing the loaded model.
You can use benchmark sample as a reference.
Thanks,
Anton

Hi @leo851001,
Does our suggestion solved your problem yet?
Mark

Hi @leo851001,
@adranit suggested to use the model-instance-id so the model can be shared among elements. This should result the better performance and higher stream density. Did you try it?
If you are not interested in this issue, I will close it in a couple days.
Mark

Performance recommendations for DL Streamer pipelines on Xeon(CLX):

run each video stream in a separate process with as much as possible limited number of threads within one process (ideally 1-3)
explicitly turn off thread pinning in inference engine (CPU_BIND_THREADS=NO) to let operating system to do proper scheduling
to get slightly better and more stable/reproducible performance, in simple benchmarks on two socket Xeon system, bind even/odd processes out of arbitrary number of streams to different NUMA nodes using “numactl” utility
set “cpu-throughput-streams” equal to CPU_THREADS_NUM value
set “nireq" equal to 1.5x-2x of CPU_THREADS_NUM value
depending on NN models complexity, change the balance of threads within one process btw media and inference.
for lightweight models, set one thread for media operations and one thread for inference (CPU_THROUGHPUT_STREAMS=1; CPU_THREADS_NUM=1; nireq=2).

filesrc ! qtdemux ! avdec_h264 max-threads=1 ! videoconvert n-threads=1 ! video/x-raw,format=I420 !
gvadetect model=mobilenet-ssd.xml cpu-throughput-streams=1 nireq=2 ie-config=CPU_THREADS_NUM=1,CPU_BIND_THREAD=NO !
gvafpscounter ! fakesink async=false
for heavy models, use one thread for decode and multiple (ex.: 3) threads for inference.
filesrc ! qtdemux ! avdec_h264 max-threads=1 ! videoconvert n-threads=1 ! video/x-raw,format=I420 !
gvadetect  model=face-detection-adas-0001.xml cpu-throughput-streams=3 nireq=5 ie-config=CPU_THREADS_NUM=3,CPU_BIND_THREAD=NO !
gvaclassify model=face-reidentification-retail-0095.xml model-proc=face-reidentification-retail-0095.json cpu-throughput-streams=1 nireq=2 ie-config=CPU_THREADS_NUM=1,CPU_BIND_THREAD=NO !
gvafpscounter ! fakesink async=false

@leo851001,
Please tell us if you are satisfied with @adranit's answers, I will wait for a week to close this if you don't response.
Mark

I’m very sorry. I ignored this part of the test because of an emergency a while ago. I will start the test again. Thank you very much for your answers.

@leo851001 ,
Do you have any result?
If no more question, could I close it?
Mark

@mliu2020 Sure!! It's work well for me. Thanks!!

Thanks so much,
Let me close it now and feel free to re-open it or submit a new issue.
Mark


Completion dropdown gets hidden when on bottom

There should be a mechanism to recalculate it's y position if called from the bottom or something else to keep being usable.

Thanks for logging the issue, @badosu !
This is related to the popover issue in #526 too (for QuickInfo). The positioning determination should be generalized, and leveraged for both autocompletion and quickinfo.
In the case you showed where autocompletion is hitting the bottom, it should open upwards so it isn't clipped.


User selecting colors

The project requirements specify that the user selecting the color of the drawings is desired, but not required.

Solved on pull request #4.


Indenting not fixed

Discussed in https://github.com/PHPCSStandards/PHP_CodeSniffer/discussions/399
Converting to an issue as requested.

Originally posted by adam-nielsen March 15, 2024
I have a bunch of poorly formatted code, but I can't figure out how to get basic stuff like the indenting fixed.  For example this file:
if (!$a) {
    if ($b) {
                    // Single line comment indented too far.
                     $a = $b;
    }
else {
                   /* Comment indented too far. */
                 $x = true;

          /* Another comment indented incorrectly. */
                       $y = true;
    }
}

When I run it, it says:
$ php phpcbf.phar --standard=PSR12 test.php

PHPCBF RESULT SUMMARY
----------------------------------------
FILE                    FIXED  REMAINING
----------------------------------------
test.php                4      0
----------------------------------------
A TOTAL OF 4 ERRORS WERE FIXED IN 1 FILE
----------------------------------------

Time: 65ms; Memory: 8MB

But all it has done is put that else back on the same line, it hasn't fixed the indenting of any statements or of the comments inside the curly braces.
What am I doing wrong?

Closing issue - per the linked discussion, the issue was that unlike linters in other languages, the default rules in phpcs don't enforce any indenting rules.  Manually turning them on makes it work as expected.


Fix the cmdCompleteCallback name in prvMqttUnSubscribe in ota_demo_core_mqtt.c

Fix the cmdCompleteCallback name in prvMqttUnSubscribe in ota_demo_core_mqtt.c
Fixes aws/amazon-freertos#3118
Checklist:

[ x ] I have tested my changes. No regression in existing tests.
[ x ] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/bot run checks

/bot run checks


[Legend SQL] Fix error handling

What type of PR is this?
Improvement

What does this PR do / why is it needed ?

Use exception throwing assert library instead of java asserts which are disabled by default
Set error status on trace span when exception is thrown
Minor updates in code style for tests

Does this PR introduce a user-facing change?
No user-facing changes

Looks good.


allow python 3.10

There weren't any AST changes in Python 3.10, so it should probably just work?

this is now in 2.3.1


Filing "hyper" under "servers" is confusing

Hyper do include a client. Since this is mentioned (as "planned") for rotor-http, I think it should be mentioned for hyper.

May I ask, why this would be confusing? If you are looking for a client, you'd be checking the "Clients"-Topic and you'd find Hyper is also mentioned there (as the first, I might add): http://www.arewewebyet.org/topics/clients/#pkg-hyper . Some things aren't only one.

If you are talking about the description, which mentions the clients part for rotor, this directly pulled from crates.io description and I'd rather not temper with that but leave the control of that section to the authors. I am actually hoping that having it displayed so prominently on this website makes them improve their descriptions (as many are ... short, to say the least).

Indeed, these are the crates.io descriptions. I will close this then!
I just clicked on "HTTP stack" and was surprised to see no mention of Hyper being usable as a client (made me check, then open this issue).


feature: switch input method automatically

Did you check the docs?

[X] I have read all the vscode-neovim docs
[X] I understand the fundamental limitations of the plugin and believe this request to be reasonable

Is your feature request related to a problem? Please describe.
I want to switch the input method automatically in normal mode, it works fine in neovim, but not in vscode. I  don't know how to make the 'esc' key trigger from vs code
Describe the solution you'd like
vim.api.nvim_create_autocmd({"InsertLeave"},{
  pattern={"*"},
  callback = function()
        vim.fn.system("im-select com.apple.keylayout.ABC")
  end
})

it works in neovim.
Describe alternatives you've considered
vim.api.nvim_create_autocmd({"InsertLeave"},{
  pattern={"*"},
  callback = function()
        vim.fn.system("im-select com.apple.keylayout.ABC")
  end
})

Additional context
No response

#1370


FormatTag's TryFrom shouldn't need a binrw error, refactor

  571  impl TryFrom<&FormatTag> for u16 {
  572      // infalible, but binrw seems to need TryFrom?
  573      type Error = binrw::io::Error;

closed by 4f9b71e183a6626b88075c1db075282c38408711


Bug fixes for March 2023 monthly deployment

This issue is to maintain a list of bug fixes for March 2023 monthly deployment (week of May 6).

all_features YAML files

CoughDx: search_term:cough, limit:2
AgeStudyStart: hard coded as UMLS:C0001779

I believe this has been taken care of.


Remove autocomplete from some form fields

autcomplete is a pain in some fields, so disable it for 👍
Links form, descriptions
Songs form, titles

autocomplete   => 'off' in field definition


[FEATURE] Add "group by" setting to per document monitor

Is your feature request related to a problem?
No, it is not a problem
What solution would you like?
Group by occurences of specific keywords/fields just like in per bucket monitor and also add as table column in the alerts table.
Also list all of the findings in one overview.
What alternatives have you considered?
per bucket monitor but it does not have all document findings

@AWSHurneyt is this something which could be implemented in the near future or is it rather low prio?


Config changes to reflect the default branch from master to main. Please merge to complete the default branch renaming job.

Auto branch renaming content.

Docs Build status updates of commit d44224b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Support mock servers in eks fargate

https://github.com/aws-observability/aws-otel-test-framework/blob/terraform/terraform/eks/main.tf#L170-L174 look here for setting the url of the mock server. Note sample app url is already set up

Create ingress for mock server sample app ingress here https://github.com/aws-observability/aws-otel-test-framework/blob/terraform/terraform/eks/otlp.tf#L255-L287

Check how pod type works  for sample app then use for mock server https://github.com/aws-observability/aws-otel-test-framework/blob/terraform/terraform/eks/otlp.tf#L234-L253


Isolate.spawnUri seems to be slower than starting a new VM in another process (on macos)

This came up here https://github.com/dart-lang/pub/issues/2492
@mkustermann @a-siva
I made a small reproduction:
// bin/spawn.dart
import 'dart:io';
import 'dart:isolate';

main(List<String> args) {
  if (args.isNotEmpty && args.first == 'isolate') {
    Isolate.spawnUri(Uri.parse('hello.dart'), [], null);
  } else {
    Process.runSync(Platform.resolvedExecutable,
        [Platform.script.resolve('hello.dart').toString()]);
  }
}

// bin/hello.dart
main() {
  print('hello world');
}

> dart --version
Dart VM version: 2.8.3 (stable) (Tue May 26 18:39:38 2020 +0200) on "macos_x64"
> dart --snapshot=bin/spawn.dart.snapshot ./bin/spawn.dart
> time  dart bin/spawn.dart.snapshot isolate
hello world

real    0m0.642s
user    0m0.697s
sys     0m0.113s
> time  dart bin/spawn.dart.snapshot

real    0m0.288s
user    0m0.335s
sys     0m0.092s

I would have expected using an isolate would save some time by sharing some amount of resources, or at least be on par with starting a new process.
Using an isolate is slightly faster if I don't snapshot the spawning script.
> time  dart bin/spawn.dart

real    0m0.964s
user    0m1.027s
sys     0m0.197s
> time  dart bin/spawn.dart isolate
hello world

real    0m0.882s
user    0m0.980s
sys     0m0.163s

This was measured on macos.
On my linux machine using an isolate seems to be faster (note here I use a dev-version, just what I had in my path...):
> dart --version
Dart VM version: 2.9.0-5.0.dev (dev) (Thu Apr 30 13:02:02 2020 +0200) on "linux_x64"
> dart --snapshot=bin/spawn.dart.snapshot ./bin/spawn.dart
> /usr/bin/time dart bin/spawn.dart.snapshot isolate
hello world
0.25user 0.15system 0:00.28elapsed 141%CPU (0avgtext+0avgdata 127504maxresident)k
0inputs+0outputs (0major+22664minor)pagefaults 0swaps
> /usr/bin/time dart bin/spawn.dart.snapshot
0.37user 0.15system 0:00.34elapsed 153%CPU (0avgtext+0avgdata 122164maxresident)k
0inputs+0outputs (0major+27981minor)pagefaults 0swaps

Thanks for the simple reproduction case, will take a look.


Integration test for a pipeline with multiple process workers

Description
Adds an integration test to Data Prepper core which validates that multiple process workers functions correctly.
Issues Resolved
N/A
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #2017 (960ba5f) into main (805f0ea) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2017      +/-   ##
============================================
- Coverage     93.99%   93.95%   -0.04%
- Complexity     1563     1636      +73
============================================
  Files           199      204       +5
  Lines          4643     4747     +104
  Branches        367      381      +14
============================================
+ Hits           4364     4460      +96
  Misses          196      196
- Partials         83       91       +8

Impacted Files
Coverage Δ

...rch/dataprepper/model/metric/JacksonHistogram.java
95.91% <0.00%> (-4.09%)
:arrow_down:

...pper/peerforwarder/PeerForwarderConfiguration.java
88.17% <0.00%> (-1.06%)
:arrow_down:

.../opensearch/dataprepper/model/event/EventType.java
100.00% <0.00%> (ø)

...earch/dataprepper/plugin/DefaultPluginFactory.java
100.00% <0.00%> (ø)

.../dataprepper/expression/OperatorConfiguration.java
100.00% <0.00%> (ø)

...warder/certificate/CertificateProviderFactory.java
100.00% <0.00%> (ø)

...xpression/LiteralTypeConversionsConfiguration.java
100.00% <0.00%> (ø)

...ch/dataprepper/typeconverter/BooleanConverter.java
64.28% <0.00%> (ø)

...rch/dataprepper/typeconverter/StringConverter.java
100.00% <0.00%> (ø)

...ch/dataprepper/typeconverter/IntegerConverter.java
100.00% <0.00%> (ø)

... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Update Clang Format to 17.0.1 (and support CLion)

Summary

Changelist

Testing Done

Resolved Issues

Checklist
Please change [ ] to [x] when you are ready.

[x] I have read and followed the code conventions detailed in README.md (This will save time for both you and the reviewer!).
[x] If this pull request is longer then 500 lines, I have provided explicit justification in the summary above explaining why I cannot break this up into multiple pull requests (Small PR's are faster and less painful for everyone involved!).

Fixes SW-66


Update dependency spdlog

Hi, I made an update to spdlogs 1.14.* but waybar supports one 1.12, how can I help to upgrade the version? I saw a file https://github.com/Alexays/Waybar/blob/master/subprojects/spdlog.wrap but I'm not sure about if there is only changing the version, I did a downgrade to go back to spdlogs 1.12 and waybar works as expected

I am having the same problem now except with waybar wanting spdlogs 1.14 but the system updated to spdlogs 1.15

For now, you can simlink libspdlogs.so.1.15 to libspdlogs.so.1.14 and it seems to work, but it should be e temporary solution.


Background color of the carousel box containing the text can't be changed

Operating system and version (Windows, Mac OS X, Android, iOS, Win10 Mobile)

Mac OS X

Browser and version (Chrome, Firefox, Safari, IE, MS Edge, Opera 15+, Android Browser)

Chrome 59.0.3071.115

Reduced test cases and potential fixes using JS Bin

See index.hml file containing the example here : https://gist.github.com/cmoulliard/3e4ad6fc84f44a89d5f733c5ef8057c0
When we change the background color of the class carousel-inner
https://gist.github.com/cmoulliard/3e4ad6fc84f44a89d5f733c5ef8057c0#file-gistfile1-txt-L9946-L9948
, the color displayed is always grey dark and not green

Bug reports must include a live demo of the problem. Per our contributing guidelines, please create a reduced test case via JS Bin or CodePen and report back with your link, Bootstrap version, and specific browser and OS details.

You have images in your carousel items:
<img class="first-slide" src="data:image/gif;base64,R0lGODlhAQABAIAAAHd3dwAAACH5BAAAAAAALAAAAAABAAEAAAICRAEAOw==" alt="First slide">


Fix render format example in README

Seems that the local type had been renamed, but the README was not yet adapted.

@tp thnanks!


Adapt to new mkdocs version in pony theme

as this is required for new mkdocs 1.0.4 the ponylang theme is now based on ( the pages section is now deprecated).
[skip ci]

@SeanTAllen do you want to take a look at this? Otherwise I think this should be good to go.

I trust in @mfelsche. I know nothing about this really.


[Sprint: 47] XD-2931 Refactor Login so that it is SPA-based

Add Spring Session
Add support for x-auth
Maintain compatibility with basic-auth
Remove Thymeleaf

LGTM, rebased and merged as 59948bf785c2f29523eb678de79c9939fb42f486


How to prioritise the queue in rabbitmq

I know it is possible to prioritise the rabitmq queue. I will pass header with transactional and promotional to seperate them  and based on the header I am gonna prioritise the queue. I hope it would be the right way to go.Could you please guide me which file I need to look out for?

There is currently no support for prioritization of messages. Are you running into large backlogs?


Update readme with CI badges & default py version

Description
Update readme with CI badges & default py version
Update version of package to released version
How Has This Been Tested?
No-op
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules
[ ] New check tests, if applicable, are included

I see this was merged before I got my comments in...

Sorry I wanted to push the fix to the version number in the package quickly. That README is very minimal it needs work, let me move those fixes in a new PR


Reward calculation issue when the same player update in a row

When the same user updates the pixels twice,  the reward doesn't get accumulated.

It seems that this happens also when a user update twice, not just in a row.
For example: Alice updates 2 pixels, Bob updates 2 pixels, Alice updates 2 pixels - reward will be lost.
See here  for a simple test scenario that shows this by printing Dixel's balance.
But if Alice updates, then Bob updates, then Carol updates - then the calculation is ok.
So it doesn't need to be twice in a row.
I'll try looking at it further if you won't fix it by the time I'm able to.

OK, I was too curious and continued to look at it 🙂 I believe the problem is that the code doesn't take into account that for example in this scenario:

Alice updated
Bob updated
Alice updated

Of the reward that was added in the last step, part of it belongs to Alice because of her first deposit. We are neglecting that part when we set the rewardDebt at the end.
To fix, we need to calculate how much reward Alice earned from her new reward - playerEarned :
            uint256 playerEarned;
            // Update acc values before updating contributions so players don't get rewards for their own penalties
            if (totalContribution != 0) { // The first reward will be permanently locked on the contract
                _increaseRewardPerContribution(reward);
                playerEarned = player.contribution * reward / totalContribution;
            }

(Note that at this point player.contribution still doesn't contain the new contribution)
And then substract it from rewardDebt so the user can claim it.
player.rewardDebt = _totalPlayerRewardSoFar(player.contribution) - pendingReward - playerEarned;

Perhaps more testing is needed, but this fixes the issue based on a quick test that I did.

And if you don't want that Alice's second update will reward Alice's contribution from first update, I believe this is the change that is needed:
Update _increaseRewardPerContribution to also take the totalContribution/shares as parameter:
function _increaseRewardPerContribution(uint256 rewardAdded, uint256 totalShares) private {
        unchecked {
            accRewardPerContribution += (1e18 * rewardAdded) / totalShares;
        }
    }

After updating the increase of shares and calculating how much of it belongs to the updating user, we use _increaseRewardPerContribution to add that reward to the rest of the users:
            uint256 userEarned;
            // Update acc values before updating contributions so players don't get rewards for their own penalties
            if (totalContribution != 0) { // The first reward will be permanently locked on the contract
                _increaseRewardPerContribution(reward, totalContribution);
                userEarned = player.contribution * reward / totalContribution;
                _increaseRewardPerContribution(userEarned, totalContribution-player.contribution);
            }

And we keep rewardDebt the same - so it already takes userEarned into account and the user can't claim it.
player.rewardDebt = _totalPlayerRewardSoFar(player.contribution) - pendingReward;

Oh Alice's second update should reward Alice's first update. I just tried to prevent rewarding from the current update.
For example,

Alice creates 10 reward at the beginning -> No one is prior to Alice, so reward is just locked on the contract forever
Alice creates another 20 reward -> Alice gets the 20 reward from her first update
Bob creates another 40 reward -> Alice gets all 40 because Bob shouldn't be rewarded by his own contribution
Bob creates another 30 reward -> So far, Alice contribution: 2 / Bob contribution: 1 -> Alice gets 20 / Bob gets 10
Carol creates 40 reward -> Alice contribution: 2 / Bob contribution: 2 -> Alice gets 20 / Bob gets 20

Assumption: All event increases the player's contribution by 1 (1 pixel update)

Alright, cool. So this first fix that I suggested will fix it.
I have created test script for the scenario you just described.
See here. Seems to be working with the fix. You can add the test to Dixel.test.js.
[Note: there's some repetition in the test, maybe you'd like to extract some of it to a different function to remove the repetition.
I tried to do it but honestly I haven't used JS in a while, so so far I didn't manage to get the right scoping to be able to access all the variables.
Anyway this way is not a disaster and you can see what's happening.]

Thank you so much for your help on this issue @assafom 👍🏻
It looks fine now, but please let me know if there's more edge cases you can think of.


Default service generator?

service SearchService {
  rpc Search(SearchRequest) returns (SearchResponse);
}

It would be nice to have a default service generator that, for the previous service, generates the following trait.
trait SearchService {
  fn search(search_request: SearchRequest) -> SearchResponse;
}

That way users could use it as follows.
struct MySearchService;

impl SearchService for MySearchService {
  fn search(search_request: SearchRequest) -> SearchResponse {
    println!(search_request);
    SearchResponse { ... }
  }
}

fn main() {
  let request: &[u8]; // An encoded call to the Search method of SearchService
  prost::Service::from(MySearchService).decode_and_handle(request);
}

This generation process does not seem to depend on the way it is implemented in the project. Is it planned and not implemented because there hasn’t been any one to do so, or do you think it shouldn’t be implemented?

I don't understand what you are asking.
If you are looking for a complete service implementation, then you should look into gRPC and tonic.
Else, you need to explain more of what you are trying to do, primarily because prost::Service::from(MySearchService).decode_and_handle(request); seems to be completely made up, and you don't explain what you expect of it.

What I wanted was to make an RPC interface with prost but manage transport myself. So I expected the, indeed made-up example of prost::Service::from(MySearchService).decode_and_handle(request); to create an object with a method to decode a request and call the corresponding method on the trait. Basically like when decoding a message, but it decodes a request instead, and instead of returning an object it calls the appropriate trait method and returns the response the trait method returns. So one can manage transport themselves, and when receiving a request on the stream, they just have to call the decode_and_handle with the received bytes and write the bytes it returns. Prost handles the logic of decoding and encoding, and provides a nice RPC interface.

As I understand, the transport needs to provide the method name to be called. There is wire specification for the service itself, just for the request and response objects. There is no protobuf specification for what you are looking for.
The C++ implementation did have something like you are describing, but that seems to be deprecated. A transport-specific implementation is deemed more efficient.
If you are willing to contribute an implementation of your proposal, I am open to discussing that.


fix typo

I wish you bought a nice display :)

Thanks a lot for the fix! [ I did end up buying this exact one... ]


Content jumping when avatar loads

When you load the page, the avatar images are not yet loaded. As they load, content starts jumping around, especially if the page consists of short posts (1-2 lines of text). Might seem nit-picky but I think things like this affect first impressions a lot.
Maybe set a min-height equal to the avatar height + padding on the entire post element, or set width/height on the avatar img element itself if they are always the same size.

The problem can easily be replicated by setting the display css attribute to none and toggling it on and off.
Thanks for creating this issue!


composer 安装失败

运行  php composer.phar install
提示：
Problem 1
- The requested package nmred/kafka-php 0.2.* is satisfiable by nmred/kafka-php[v0.2.0-beta] but these conflict with your requirements or minimum-stability.
新手，没用过composer 这个问题该怎么解决呢

Your minimum-stability by default is stable so yes nmred/kafka-php is not allowed to be installed as dev-master by that minimum-stability, either you require it with "@dev" as requirement, or you change the minimum-stability to dev.


Will you consider releasing a docker image?

Midori is a tool I love and it's so stable that I want to use it for my own services.
Considering that my existing service is built on the docker platform, I need a midori docker image.
But I couldn't find any official or unofficial midori images on docker.com,
do you have any plans to release docker images in the future?

You can refer to shadowsocks-rust's dockerfile to build a image on your own.

zephyrchien/midori I've built one just now, it is for x86_64.
To build images for other platforms, you can fork this project and make use of github workflow.(also refer to shadowsocks-rust)