Uncaught Exception: Attempting to call a function in a renderer window that has been closed or released. Function provid

An uncaught exception was reported.
Info:
OS: win32
Arch: ia32
GPMDP Version: 3.0.1
Time: Sat Mar 19 2016 22:34:58 GMT 0100 (W. Europe Standard Time)
Error:
Attempting to call a function in a renderer window that has been closed or released. Function provid
Error: Attempting to call a function in a renderer window that has been closed or released. Function provided here: Object.<anonymous> (C:\Users\Roel Hospel\AppData\Local\GPMDP_3\app-3.0.1\resources\app\build\inject\GPMInject\interface\mouseButtonNavigation.js:8:8.
    at BrowserWindow.callIntoRenderer (C:\Users\Roel Hospel\AppData\Local\GPMDP_3\app-3.0.1\resources\atom.asar\browser\lib\rpc-server.js:201:19)
    at emitTwo (events.js:92:20)
    at BrowserWindow.emit (events.js:172:7)
    at EventEmitter.<anonymous> (C:\Users\Roel Hospel\AppData\Local\GPMDP_3\app-3.0.1\resources\app\build\main\features\core\controlBar.js:12:45)
    at emitTwo (events.js:87:13)
    at EventEmitter.emit (events.js:172:7)
    at EventEmitter.<anonymous> (C:\Users\Roel Hospel\AppData\Local\GPMDP_3\app-3.0.1\resources\atom.asar\browser\api\lib\web-contents.js:134:25)
    at emitTwo (events.js:87:13)
    at EventEmitter.emit (events.js:172:7)

This issue was created automatically inside the uncaughtException handler

Closing this automatically reported issue as a duplicate of #470


ci: fix bundle check

Current dependencies on/for this PR:

main

PR #2299   👈

This comment was auto-generated by Graphite.


Bval-241 method validation

I am pushing this request in the name of Gunnar to be able to send feedbacks

I also see a couple of missing changes

add getParameterNameProviderClassName to ConfigurationSource interface
push changes to beanvalidation-api as well

add getParameterNameProviderClassName to ConfigurationSource interface

Ah, I've added this to the post-review branch.

push changes to beanvalidation-api as well

Most parts were already there, just the branch name was misleading. I've renamed it to BVAL-241 now to be consistent with the branch in beanvalidation-spec.


Channel Item Object $ref field resolution rules

Description of the $ref field explicitly says:

Allows for an external definition of this channel item. The referenced structure MUST be in the format of a Channel Item Object. If there are conflicts between the referenced definition and this Channel Item's definition, the behavior is undefined.

As a tooling author I have couple of questions here:
Allowing only external definition
Why are we allowing only external definition and not an internal as well? By changing wording to Allows for a referenced definition of this channel item. we open a possibility to reference other Channel Items defined in the same document. This constraint (external definition) can be easily bypassed by defining a $ref field as URL+JSON Pointer fragment, where URL has the same baseURL as the root document.
Rules of resolving
Rules of resolving are missing entirely. It is not clear how to do the actual resolution. I can only assume what the rules might be by reading one of the paragraph in Reference Object section:

For this specification, reference resolution is done as defined by the JSON Reference specification and not by the JSON Schema specification.

So if resolution for Reference Object is done using JSON Reference spec, I'd assume the same for Channel Item Object. This assumption can be wrong thought. In order to remove un-clarity I propose to mention following sentence in Channel Item Object.$ref field description: Resolution is done as defined by the JSON Reference specification.
I can open PR with proposed changes if/when we agree on them.

This is a very good question, I was wondering about the $ref field too. OpenAPI has the same issue with Operation Objects. Could we either

Remove the $ref field from Channel Item Object, this way forcing all Channel Item Objects to be defined in the same document
Make it union type (either a Channel Item Object or a Reference Object) and make it behave like all other referenceable pieces of the schema?

I think either would be

This is a very good question, I was wondering about the $ref field too. OpenAPI has the same issue with Operation Objects. Could we either

I guess you mean Path Item Object in OpenAPI. I am already driving effort to eliminate it in v3.2: https://github.com/OAI/OpenAPI-Specification/issues/2635

Remove the $ref field from Channel Item Object, this way forcing all Channel Item Objects to be defined in the same document
Make it union type (either a Channel Item Object or a Reference Object) and make it behave like all other referenceable pieces of the schema?

I think either would be better than the mixture of both

For this I’ve already submitted a proposal to remove $ref field and replace it with Reference Object: https://github.com/asyncapi/spec/issues/607
This particular issue exclusively deals with rules of resolution for Channel Item Object with $ref field

Just pinging here. Clarification from the spec authors can help move this forward. After the clarification and further discussion I can issue a PR to amend the specification.

If we finally move forward with https://github.com/asyncapi/parser-js/issues/401, the idea will be that Parser-API will define all the bundling and ref/dereferencing logic Parsers should follow. Meaning the spec documentation will link to it for tool developers. See https://github.com/asyncapi/parser-api/issues/30
Btw, your feedback is more than welcome in the parser-js issue!

@smoya I've read the intention driven proposals and the article. IMHO it's completely separate from this issue. It should be clear from specification how to create the implementation, which is not at this point - implementation is not the source of truth, the specification is. What I'm proposing is it to remove the unclarity by making the specification better.

@smoya I've read the intention driven proposals and the article. IMHO it's completely separate from this issue. It should be clear from specification how to create the implementation, which is not at this point - implementation is not the source of truth, the specification is. What I'm proposing is it to remove the unclarity by making the specification better.

Yes, I totally agree with your point. Let me clarify that the idea around https://github.com/asyncapi/parser-api is not only about defining such intent-driven API (what the post talks about) for parsers but also defining the cross-cutting concerns of them, such as (but not limited to) bundling.
However, I agree specification should contain, at least, a statement on how bundling is expected to work on an AsyncAPI document.
I would suggest we extend the scope to improve the whole documentation and not only the channels part.
BTW, I have been lately discussing how the bundling could be improved in future versions at https://github.com/asyncapi/spec/issues/649#issuecomment-979078673, just in case you are interested to join forces as well.

However, I agree specification should contain, at least, a statement on how bundling is expected to work on an AsyncAPI document.
I would suggest we extend the scope to improve the whole documentation and not only the channels part.

The problem is actually only with Channel Item object. It's the only object within the spec which allows referencing data apart from Reference Object. Currently it says it allows only external definition which given other sections of the spec means - definition contained in external document and not this one. That doesn't necessarily mean that the URL for $ref field is defined as absolute, it can also be defined as relative to the baseURI of the document. And that's basically what this issue is about - defining rules of resolution for this single field and currently in my opinion it's not defined and it's up for implementor intrepretation.
It's also work mentioning that there is RFC1 about removing $ref field from Channel Item Object - https://github.com/asyncapi/spec/issues/607

BTW, I have been lately discussing how the bundling could be improved in future versions at #649 (comment), just in case you are interested to join forces as well.

I'll take a look, thanks!

This is now limited to version to specification version >= 2.0.0 <= 3.0.0. The reason is https://github.com/asyncapi/spec/issues/699, which removes the $ref field from Channel Item Object.

PR attached to this issue is: https://github.com/asyncapi/spec/pull/779

Closing as the #779 has been merged to master as editorial change.

Recent comments about the release from the bot were added by mistake. More details in https://github.com/asyncapi/spec/issues/899


Is Bun supported?

Component or Package Name:
Component or Package Version:

Documentation Is:

[x] Missing
[ ] Needed
[ ] Confusing
[ ] Not Sure?

Please Explain in Detail...
If yes, it could be added to the docs besides npm, yarn and pnpm :)
Your Proposal for Changes

Not sure! I'm not a Bun or Deno user. Good bet if Bun supports React.
We have a discord server and discussions for general Q & A, that's a better spot than issues. Feel free to open an issue with a reproduction with a filled-in template if something doesn't work right.

Well that's what I get for viewing on mobile :) Sorry for the misstep.

@Jarred-Sumner anyone on staff that could give this a spin with bun to answer OP's question of support?

Well, looks so (vite and react are supported, so why not)

That's good news! We'll update the docs very soon. Thanks for taking a look at that

I am not on bun staff BTW 😳
But just followed try it and see
You may want to wait for their response

The try it and see is good enough for me. That screenshot shows me what I needed to know.
side note: was it any faster?

build ~2x faster

alright bun support was pushed and should be visible on the sight in a few minutes! thanks @XMadFoX


[🐞] this is undefined in server$ function when called consequentially.

Which component is affected?
Qwik City (routing)
Describe the bug
When two or more $server functions called one after each other the second called function would have this === undefined
This doesn't happen when they called concurrently in Promise.all
const serverFunctionA = server$(async function () {
  console.log('serverFunctionA', this);
  return true;
});

const serverFunctionB = server$(async function () {
  console.log('serverFunctionB', this); // <--- here `this` would be undefined
  return true;
});

export default component$(() => {
  const resource = useResource$(async () => {
    const resultA = await serverFunctionA();
    const resultB = await serverFunctionB();

    return { resultA, resultB };
  });

  return (
    <Resource
      value={resource}
      onResolved={({ resultA, resultB }) => (
        <>
          {resultA} {resultB}
        </>
      )}
    />
  );
});

Reproduction
https://stackblitz.com/edit/qwik-starter-jdcnqd?file=src%2Froutes%2Findex.tsx
Steps to reproduce
No response
System Info
System:
    OS: macOS 13.3
    CPU: (10) arm64 Apple M1 Pro
    Memory: 75.86 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 16.17.0 - ~/.nvm/versions/node/v16.17.0/bin/node
    Yarn: 3.5.1 - ~/.nvm/versions/node/v16.17.0/bin/yarn
    npm: 8.15.0 - ~/.nvm/versions/node/v16.17.0/bin/npm
    Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
  Browsers:
    Chrome: 113.0.5672.126
    Firefox: 95.0.2
    Safari: 16.4
  npmPackages:
    @builder.io/qwik: 1.1.4 => 1.1.4
    @builder.io/qwik-city: ~1.1.4 => 1.1.4
    @builder.io/qwik-react: ^0.5.0 => 0.5.0
    undici: 5.21.0 => 5.21.0
    vite: 4.2.1 => 4.2.1

Additional Information
No response

I might not have time to fix this in the coming weeks. However, I can share where this issues arises from.
In use-core.ts, when  x_component_resource_useResource_hash (the qrl callback of useResource) is ran, the invoke context is removed after the first server function (serverFunctionA) is scheduled. This is because useResource does return a ResourceReturn object, before values are resolved. The context should somehow be kept through this async flow.

What's the status on this?

@genox reported a similar issue in a Discord thread: https://discord.com/channels/842438759945601056/1160923192538439711/1160923192538439711.

Is there any info when it will be fixed? :+1:

I'll look at it 😊

this was auto closed. @wmertens can cut a new release. I had tests to confirm it only worked with the fix. bun, deno, and cloudflare supports async_hooks


Precompiled files do not work with linux

It is not possible to run the precompiled files in linux. Even a simple help output does not seem to work and the error message seems always the same. I tested all linux builds from "pytorch" in Google Colab and I got this output. The same error appears in "it actually works sometimes".
!./cain-ncnn-vulkan -h

./cain-ncnn-vulkan: error while loading shared libraries: libvulkan.so.1: cannot open shared object file: No such file or directory

apt-get install libvulkan

!apt-get install libvulkan
E: Unable to locate package libvulkan

But !sudo apt-get install -y libvulkan-dev works. Thank you. You may want to add this information in the readme. I thought this is only required when it is built from source.
Small sidenote: You should probably place cain-ncnn-vulkan,  cain.bin and cain.param in the same folder. The output is a gray interpolated image by default. Currently  cain.bin and cain.param are inside /cain and creates this error.
[0 Tesla P100-PCIE-16GB]  queueC=0[16]  queueG=0[16]  queueT=1[1]
[0 Tesla P100-PCIE-16GB]  bugsbn1=0  buglbia=0  bugcopc=0  bugihfa=0
[0 Tesla P100-PCIE-16GB]  fp16p=1  fp16s=1  fp16a=1  int8s=1  int8a=1
fopen cain.param failed
fopen cain.bin failed
find_blob_index_by_name x.1 failed
find_blob_index_by_name x.3 failed
find_blob_index_by_name 4070 failed
...


Remove henrik as a CODEOWNER

I think just setting the AR to llvm-ar instead of the target-specific one should fix it.


Add static checkers

What does this do / why do we need it?

What should your reviewer look out for in this PR?
N/A.
Do you need help or clarification on anything?
No.
Which issue(s) does this PR fix?
None that I know of.

Done!
On Mon, Sep 11, 2017 at 4:17 PM, sam boyer<EMAIL_ADDRESS>wrote:

@sdboyer requested changes on this pull request.
omg. it's like zombies rising from the dead!
just one thing, then yes, this seems like it'd be good - generally very
few false positives from this kind of analysis.
In internal/gps/selection.go
https://github.com/golang/dep/pull/1157#discussion_r138172775:

@@ -93,25 +89,6 @@ func (s *selection) getRequiredPackagesIn(id ProjectIdentifier) map[string]int {
return uniq
}

-// Compute a list of the unique packages within the given ProjectIdentifier that
-// are currently selected, and the number of times each package has been
-// independently selected.
-func (s *selection) getSelectedPackagesIn(id ProjectIdentifier) map[string]int {
let's mark an exception for this one in the linter - it's helpful to keep
around for future solver plans, especially because it reflects a
performance problem we'll run into when we do try to use it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/golang/dep/pull/1157#pullrequestreview-61934451, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABdsPIoWDCkHSWcooJJh-dsJbcMsa-Vtks5shZVPgaJpZM4PToDX
.

lint is something we should be enforcing via codeclimate, though honestly i'm pretty consistently underimpressed with the feedback we get from them, so i'm fine with adding it back to travis.

Cool. As with #1154, if you could merge this without squashing, I'd appreciate it.

Green!


Empty Array after using getProducts()

I'm currently having a problem when using this library related to the getProducts() function.
Version of react-native-iap
I'm using version 4.5.0.
Version of react-native
I'm using version 0.63.1.
Platforms you faced the error (IOS or Android or both?)
Faced this problem on Android.
Expected behavior
initConnection() : Showing true as a result.
getProducts() : Getting the list of active items registered on Google Play Developer Console.
Actual behavior
initConnection() : Showing true as a result.
getProducts() : Getting an empty array :(
Tested environment (Emulator? Real Device?)
I've tested this using a real device, as suggested by other issues.
Steps to reproduce the behavior

Add the BILLING permission to AndroidManifest.xml as follows:

In the src/debug/ and src/main/ folder I added both of this line.
<uses-permission android:name="com.android.vending.BILLING" />

Making a simple button using React Native, then have the button do an onPress action.
Create the onPress function to be tested. I created this to test:

  const itemSkus = Platform.select({
    android: ['storeticket_0', 'storeticket_1', 'storeticket_2'],
  });
  ...
  const handleSubscription = async () => {
    try {
      setProcessing(true);

      await initConnection()
        .then(async (conn) => {
          console.log(conn); // Expected and Actual outputs true!
          return await getProducts(itemSkus);
        })
        .then((test) => {
          console.log(test); // Outputs an empty array (on my device)
          setProcessing(false);
        });
    } catch (err) {
      setProcessing(false);
    }
  };

My SKUs:

Upload the APK file after building to the Play Console.

What I've been doing is following several guides and issues all over the place, but I have no success with it :( Here's what I've tried so far:

Some people said that I'm required to wait several hours/days for the products to register on the console (Source: this SO post). Waited for almost a week, still doesn't work.
Fixed my codebase so the package name matches the package name on the Play Console, but still no luck.

Did I do something wrong? Or maybe the review time is just very long in my case? As in the console it's being announced that they are currently taking longer to review apps. My current state of the app on the Play Console:

What else do I need to do and setup in order to test for at least getting the in app products and for further testing (like testing the payment system)? Thanks in advance! :)

Hi there, i dont see anything wrong after looking over your code.
However I would suggest you check the status of your app on Google Play Console. We need google to complete its pending review before the API for your store items to be available for you to fetch.
It could take couple days though its best to wait and work on some other tasks now.

@kennguyen1506 I see, thanks for the response. I'll wait for the status to be changed. I'll report back when it does.

Sorry for the late reply, can confirm that may code already works and it is required to wait your app to be approved in the Play Console. Thanks for the help!

@mkamadeus @kennguyen1506 I am using react-native-iap for iOS the latest version 12.10.5 and I am getting empty array? is it required to get IAP plans approve on the App Store only then I can get products. But if I will do this how can I test my app to do code further without getting this in my first version?

@mkamadeus @kennguyen1506 I am using react-native-iap for iOS the latest version 12.10.5 and I am getting empty array? is it required to get IAP plans approve on the App Store only then I can get products. But if I will do this how can I test my app to do code further without getting this in my first version?

Exactly...this is confusing. In iOS the products are available before any approval. Seems Google has the cart before the horse here?

Looking at the setup in Google Play Console it looks like they will approve for a closed track where you can do the testing before going live...I guess I'll find out in a minute lol

any updates on this issue? Seems Google still wants to approve for a closed track to test

now i'm facing this issue, in my case getproduct() works on ios but gives empty array in android, i check and tested all the things, all things are ok and working well, but i get empty array, my code is this
export const availableProducts=async()=>await getProducts({skus:Object.values(Platform.OS==='android'?
VERBA_SUBSCRIPTION_OBJ.ANDROID:VERBA_SUBSCRIPTION_OBJ.IOS)})
and my sku is this : export const VERBA_SUBSCRIPTION_OBJ = {
ANDROID: {
MONTHLY: "sub_test_monthly",
YEARLY: 'sub_test_yearly'
},
IOS: {
MONTHLY: Config.VERBA_MONTHLY,
YEARLY:  Config.VERBA_YEARLY
}
}
so why i face this error, in google play console the status is active,


Arcana Auth SDK support

Description
Added a package to support the Arcana Auth SDK. See the included documentation for more information.
PLEASE NOTE- Checklist must be complete prior to review.
Checklist

[x] Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
[x] Check the box that allows repo maintainers to update this PR
[x] Test locally to make sure this feature/fix works
[x] Run yarn check-all to confirm there are not any associated errors
[x] Confirm this PR passes Circle CI checks
[x] Add or update relevant information in the documentation

Docs Checklist

[x] Include a screenshot of any changes (see docs README on running locally)
[x] Add/update the appropriate package README (if applicable)
[x] Add/update the related module in the docs demo (if applicable)
[x] Add/update the related package in the docs/package.json file (if applicable)

Added documentation for the new package.

If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/
Tests with demo app (injected) – Not relevant

[ ] send transaction
[ ] switch chains
[ ] sign message
[ ] sign typed message
[ ] disconnect

Tests with demo app (SDK)

[x] send transaction
[x] switch chains
[x] sign message
[x] sign typed message
[x] disconnect – Requires some changes right now

So, how is the documentation package supposed to install a unpublished package? Should I split this into two PRs, so that the package can be published first?

@mmjee Overall- looking good. Don't worry about the docs not building- we can check the docs when the alpha package is published on merge into develop. I tested in the demo and was able to connect, disconnect, sign a message, and sign a typed message. However- I could not send a Goerli transaction- video of my test: https://www.loom.com/share/f95f53bfd01c404e9d816876ec1e1eb6

I tried to reproduce the above issue but I couldn't actually get it to switch to Görli because of Infura (and the API key is hardcoded).

you can update the goerli rpc url in packages/demo/src/App.svelte
https://ethereum-goerli.publicnode.com

@leightkt Updated the RPC URL, it should work assuming you have Görli ETH in the address.

@mmjee I still get the same 'UNSUPPORTED_OPERATION' error shown in my testing video above (able to switch to goerli, have test ETH in my account)

@mmjee moving this to draft until the 'UNSUPPORTED_OPERATION' error when sending a transaction can be address. Thx!

On 6/27/23 22:34, Kat Leight wrote:

@mmjee moving this to draft until the 'UNSUPPORTED_OPERATION' error when sending a transaction can be address. Thx!

Yes, it looks like we are mishandling EIP-1559 transactions so this is blocked until we figure out what the problem is and fix it.
Regards,

@leightkt Can you confirm whether the issue above still occurs?

@mmjee I can no longer connect to the wallet

@mmjee I can no longer connect to the wallet

Updated the packages, should be working now. Works locally.

On ২৬/৭/২৩ ২১:৫০, Kat Leight wrote:

Do you see anything in the DevTools Network Tab? This is a web wallet so
everything should be loaded in dynamically. Does that work on a browser
w/o extensions?
I can confirm it works locally.
Regards,

@mmjee I was able to login only on a browser where I can no other extensions installed. Please make a note in the arcana README
Once logged in, I can switch chains, sign a message, sign a typed message, and disconnect the wallet.
I cannot send a Transaction on Goerli:

On 7/28/23 03:13, Kat Leight wrote:

@mmjee I was able to login only on a browser where I can no other extensions installed. Please make a note in the arcana README
Arcana Auth is supposed to work with all popular browsers and works even when 3rd party cookies are blocked. It should work by default for most browsers even with extensions. If you can, please narrow it down to an extension and/or configuration that could be causing it.
Once logged in, I can switch chains, sign a message, sign a typed message, and disconnect the wallet.
I cannot send a Transaction on Goerli:

Can you please retry again? We have added a few more fixes to EIP-1559 transaction handling.
Regards,

@mmjee success! Please add a note to the the Arcana readme and docs page that users may need to disable other wallet extensions in order to connect to Arcana.
Also- the Arcana docs page needs to be moved to [..1]arcana to respect alpha order. I can push that change (and handle the renaming of the other docs pages to keep the order) if you want to give me write access.
Once those two things are completed it's good to go!

@mmjee success! Please add a note to the the Arcana readme and docs page that users may need to disable other wallet extensions in order to connect to Arcana.
Also- the Arcana docs page needs to be moved to [..1]arcana to respect alpha order. I can push that change (and handle the renaming of the other docs pages to keep the order) if you want to give me write access.
Once those two things are completed it's good to go!

Got it, fixing docs and readme as suggested above. cc: @mmjee  @leightkt

@leightkt All changes are ready to be reviewed.

@mmjee getting two errors trying to build the package on circleci:

@mmjee getting an error on our circleci build- please put up a new PR to fix:

@leightkt Should be fixed by #1860.


releases not deleting when in composition with a gke cluster

What happened?

When i have a XR and the composition contains a cluster (gke), helm provider config and helm charts, when i delete the XR it should remove all releases (releases.helm.crossplane.io).
it starts deleting the cluster or the kubeconfig secret before helm provider has a chance to clean up.    Error message failed to extract kubeconfig: cannot get credentials secret: Secret "f70c8c2a-4be7-46eb-8487-a78333a6dd02-gke-cluster" not found
How can we reproduce it?

Create a gke cluster, nodepool, helm-provider-config and some helm charts into the composition of an XR.   Then delete the XR.
What environment did it happen in?
Crossplane version:   1.5.0

This is similar to https://github.com/crossplane-contrib/provider-kubernetes/issues/38 and is a general problem when provisioning resources into a K8S cluster that has been created in the same composition.   It slows down the provider to the point where it is essentially unusable.  There needs to be a way for the provider to clean up these resources when they have been marked deleted.

https://github.com/crossplane/crossplane/issues/3393 proposes a generic solution for these issues


Implemented code fix SA1302:InterfaceNamesMustBeginWithI

Fixes #431.

Works as expected for most code, but we definitely need to address #436.


tolerate predicting failures on feasible clusters

What type of PR is this?
kind/feature
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Codecov Report

Merging #705 (92216fd) into main (e2ffa5f) will decrease coverage by 0.62%.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #705      +/-   ##
==========================================
- Coverage   13.60%   12.98%   -0.62%
==========================================
  Files          66       76      +10
  Lines        7492     8693    +1201
==========================================
+ Hits         1019     1129     +110
- Misses       6391     7480    +1089
- Partials       82       84       +2

see 47 files with indirect coverage changes


Allow dragging the four corner points of the Transform cage independently

This lets the user skew the perspective of the rectangle with some arbitrary affine transform. The user can access this by dragging a corner of the transform cage while holding Ctrl.

I do not believe this is possible with an Affine2.
You wish to allow the user to transform a unit square with vertices at (0,0) (1,0) (1,1) (0,1) into any arbitrary quadrilateral.
An affine transformation represented by a translation (which must be used to transform the point at the origin ). There is also a two by two matrix. The first column of the matrix (i) is the result of the transform of the vector (1,0) and the second column (j) is the result of the transformation of the vector (0,1). The transformation of the vector (1,1) is always equal to i+j (the two columns added together).
A visual proof that there is often no linear transformation to any arbitary points:

Note that during a linear transformation, the thin black grid lines must remain parallel and evenly spaced.

I think we can mandate no convex angles, so the right image would be clamped to forming a triangle. Does that work with an affine transform?

Only sometimes, see the following stack exchange answer: https://math.stackexchange.com/a/614375

Is an affine transform a subset of a perspective transform? Should we consider switching our transforms to perspective transforms?

Our current 2D affine transformations are a subset of perspective transformations.

Ok, that's helpful to know. Are you aware of any impediments to switching to the superset, and do you know how much effort (and affected code) would be involved in such a refactor?

@Keavon Search for DAffine2 - you will find 308 occurrences in 50 files.

@Keavon another issue is that we frequently transform a bézier curve by an affine transform to be another bézier curve. However it is not possible with a perspective transform unless a more general NURBS is used as output.

That's an interesting challenge. From a bit of research it looks like rational Bezier curves are needed to represent perspective transforms, which is a special case of a regular Bezier curve. And rational Beziers are special cases of NURBS (see here). So I wonder if we want to just support all of NURBS and have a hierarchy of data complexity/purity, then build Bezier-rs functionality to approximate NURBS as Bezier segments similar to some of the existing algorithms it already has involving approximations like reduce, offset, and arcs.
There's this video on projective geometry which gives a taste of homogeneous coordinates that I found helpful in starting to understand these concepts:
https://youtube.com/watch?v=XXzhqStLG-4
Further reading:

https://ftp.unpad.ac.id/ctan/macros/latex/contrib/lapdf/bezinfo.pdf (section 1.4)
https://www.rose-hulman.edu/~finn/CCLI/Notes/day22_23.pdf
https://www.rose-hulman.edu/~finn/CCLI/Notes/day21.pdf


Automatically select last time step if time scope is not set

📝 Description of the feature
by default, the last available time step should be selected if the time scope is not specified in the result definition. Currently the backend throws an error if the time scope is empty
💡 Steps for implementing the feature

Improve the backend as described above. Check if time can be "last" (string) or a float. Last would become the new default. This allows to explicitly expose it in the front end as well. -1 is another default to select the last instead of handling the none case.
in pyDPF Composites, use the new default in CompositeScope and ResultDefinition.

🔗 Useful links and references
No response

Required changes in the backend were merged on February 8t, 2023.


Fixes for TTS and var names

Modified responses for TTS integration+fixed variable names as per naming standard.

Closing and resubmitting


Show bridge URL when executing keptn configure bridge --output

It would be great to also see the bridge URL when executing
keptn configure bridge -o

The current output shows:
user: keptn
password: Axxxxxxxx

To access the bridge, another command, such as keptn status is needed that gives you the URL of the Keptn installation.
It would be great to have the output such as
$ keptn configure bridge -o

Your Keptn Bridge is available under: https://yourkeptn.com/bridge

These are your credentials
user: keptn
password: Axxxxxxxx

Can I submit a PR for this issue?
I faced the same problem while going through the quick start guide. I went through cli/cmd/configure_bridge.go and it seems like we just need to print out the endpoint string.

@PrayagS a PR is highly appreciated!

@johannes-b I just submitted a PR (#4102). Please have a look.


Replace Spyder logotype in splash screen with revised Title Case, small caps version as on readme and docs banner

Issue Report Checklist

[x] Searched the issues page for similar reports
[x] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[x] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[x] Completed the Problem Description, Steps to Reproduce and Version sections below

Task Description
Currently, the Spyder logotype used in the splash screen is all lowercase, like this:

For consistency, it should match the Title Case, small caps version from the docs banner, readme banners, Spyder homepage, etc:
EDIT: Realized I copied the wrong image

Also, as part of this we might want to either tweak the background's position to improve contrast (avoid light on light). but the current dark BG logo is probably still fine and I think looks a little better her anyway, IMO. The best way to do that, if you have the margin, is just to bump the BG image up by a little so the dark parts cover the white web strands from the logo.

@dalthviz, please work on this one.

You can get high-resolution PNGs of both the light and the dark versions in the relevant directory on our Google Drive. I'd use SVGs, but I've been getting very inconsistent output between Illustrator, Inkscape and various display programs.

@CAM-Gerlach, given the comments in PR #8028, I'm going to close this one because we don't have time to implement it for Spyder 4.
What we really need to do is to create a new icon and use it in the splash screen. But that's work for Spyder 5 at this point.

The core problem with that PR was that it changed to the logo and the text to the version adapted for light backgrounds, when there was nothing wrong with the original there and no reason to change the text color to white. All that needed to be done here, as stated above in the OP and even the title, was to change the text to Title Case and small caps, so its consistent with everywhere else. I did say

Also, as part of this we might want to tweak the background's position to improve contrast (avoid light on light)

But then explicitly clarified

but the current dark BG logo is probably still fine and I think looks a little better her anyway, IMO.

Simply changing the font case as @dalthviz already did (which is exactly what this issue is about) is a strict improvement in both look and consistency on the previous for relatively little effort, as @bcolsen 's (valid) comments 2 and 3 only apply to changes this PR explicitly said to not do (changing the logo and text color), and comment 1 is an issue either way and not affected by the changes, so it shouldn't be a reason not to merge a PR with just a change to the font.
If we are going to make more substantial changes (which indeed should wait for at least Spyder 5), I agree we should hire a designer. However, while I am far from one to talk down the importance of good design in general (after all, I was raised by a graphic designer (my mom) who constantly instilled in me a strong sense of the importance thereof), I'm of the belief we should concentrate our very limited resources that we've been entrusted with on fixing bugs, adding features and developing plugins that our users actually want and need, rather than paying >= hundreds of $ to a professional designer for a prettier logo and splash screen, at least until we get closer to the level of Jupyter in terms of wads of cash to burn.
Therefore (TL;DR), given this won't otherwise be touched anytime soon, @dalthviz or I should simply make the actual change requested in this issue (that he already made, among others), i.e. making the font case consistent with everywhere else the logotype is used, and then be done with it if and until we hire a designer sometime well in the future.

@ccordoba12 my intervention in PR #8028 was not to suggest closing the PR, but to avoid that we waste time trying to correct small details about "flaws" in the design of our current logo. Also, note that I made my comment thinking the logo and banner were currently being worked on by a professional designer for the release of Spyder 4, as it was discussed previously in Gitter.
That being said, I agree with @CAM-Gerlach that @dalthviz could simply revert back using the standard dark background color logo and make the text white in his PR and that's it. I think the PR could be merged like that, without further modifications.

I should submit a PR with just the simple change to the Spyder logotype (Title Case/Small Caps) that this issue requests as he already included there, as its a strict minimal-effort improvement in look and consistency.

Ok, I agree only with this.

@CAM-Gerlach, please take care of it.

I know I said not to waste time on this, but this was before I knew that the splash was not going to be reworked in Spyder4.
So, here is what I'm proposing to fix this Issue and also to improve the contrast between the logo/text and background.

Make the logo and text larger
Change the font from Quattrocento Sans  to Candara, because the former doesn't support small caps and Candara is the font used in the banner and other Spyder logo.
Add a subtle shadow to improve contrast

Ok, here is a version with a smaller logo and more subtle shadow. I think it looks better.

@jnsebgosselin Great work! The subtle drop shadow fixes the contrast issue with the highlights without any position tweaks, and overall its a much better solution.
Do you think you could move the 4 down a little so it isn't quite such an extreme supercript (perhaps so the horizontal bar of the 4 is even with the letter height of the small caps)? Especially due to the small caps, it looks rather disconnected from the Spyder text.
Also, you could consider keeping the logo the same (or perhaps even a tad smaller, but increasing the font size of the Spyder logotype just a bit, so the latter doesn't dominate the former and is closer to the ratio in the other sources.
Thanks!

I really like these improvements @jnsebgosselin!

Here is a version with the banner size and position, with the 4 down a little as suggested by @CAM-Gerlach .

@jnsebgosselin Sure, just send me the file. There really shouldn't be much more to do then fixing the vertical alignment of the Spyder name (so its centered with the logo again), maybe dropping the "4" a tad more and submitting a PR with the final design, and I don't want to drag this out as @ccordoba12 cautioned against.

Thanks @CAM-Gerlach for finishing @jnsebgosselin's work!

@ccordoba12 I haven't done anything yet, as I'm still waiting on the file. He did 99% percent of it anyway; 90% of what I do is just getting the SVG to open, render and output properly.

Sorry for the delay. I need to cleanup a little bit my file and I'll send it to you @CAM-Gerlach .

@jnsebgosselin Thanks!

On the Drive.

Thanks! I'll take care of it when final exams and projects are done next week.

This no longer applies, so I'm going to close it.


⚠ Samsung has degraded performance

In 7bfb7e3, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 3069 ms

Resolved: Samsung performance has improved in 13a79b5.


Fix multithreading checkpoint loading

What does this PR do?
Fixes #17665
Currently, loading checkpoint does not work when using a multithreading-based strategy (for example, XLA + PJRT). The context manager pl_legacy_patch makes legacy module lightning.pytorch.utilities.argparse_utils temporarily available in its context by adding it to the sys.modules on enter and removing it on exit. But when used with threading, because sys.modules is shared between threads, one of them tries to delete already deleted entry, causing exception (but silently on XLA).
This PR fixes this issue by introducing following changes:

Fixes broken test test_legacy_ckpt_threading which always passes even though exceptions are raising from threads.
Re-introduce locking to pl_legacy_patch context manager which was reverted in commit 277b0b811fb1419d6c06e7953941d6f6076eaf6d

Before submitting

[x] Was this discussed/agreed via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Me neither. I don't remember. RIP :(


Demo in Readme

It'd be great to have a gif or webm embedded somewhere to show what this reading approach offers, eg the Key features of Sprint Reader: section's contents both in its current form and then next to it an alternative.

Does this help:
https://www.youtube.com/watch?v=f2obJtSWEkU
It's not a new video but does explore the key concepts.


doc: added contributing and cleaned CHANGELOG

This PR adds a CONTRIBUTING.md file and a similar file in the documentation.
I have also clenaed up the CHANGELOG.md/changelog.rst files as previously discussed (for the first release we do not provide any details about added/change/fixed..., that will only be added for next releases)

Looks good to me!


Upgrade to v0.16.1

Describe the bug:
Installing v0.16.1 via official helm chart hangs strangely:
./core-certs/deploy.sh
Switched to context "xxx".

ok"jetstack" has been added to your repositories
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "jetstack" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 1 charts
Downloading cert-manager from repo https://charts.jetstack.io
Deleting outdated charts
==> Linting .
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, 0 chart(s) failed
Ensuring namespace is present...
Error from server (AlreadyExists): namespaces "core-certs" already exists
Upgrading release...
history.go:52: [debug] getting history for release core-certs
upgrade.go:121: [debug] preparing upgrade for core-certs
upgrade.go:434: [debug] resetting values to the chart's original version
upgrade.go:129: [debug] performing update for core-certs
upgrade.go:308: [debug] creating upgraded release for core-certs
client.go:173: [debug] checking 39 resources for changes
client.go:440: [debug] Looks like there are no changes for ServiceAccount "core-certs-cert-manager-cainjector"
client.go:440: [debug] Looks like there are no changes for ServiceAccount "core-certs-cert-manager"
client.go:440: [debug] Looks like there are no changes for ServiceAccount "core-certs-cert-manager-webhook"

And here it hangs
Expected behaviour:
Deployment runs normally
Steps to reproduce the bug:
Switch chart from v0.16.0 to v0.16.1 in Chart.yaml dependencies section
Anything else we need to know?:
Environment details::

Kubernetes version (e.g. v1.10.2): v1.17.5
Cloud-provider/provisioner (e.g. GKE, kops AWS, etc): Bare Metal cluster
cert-manager version (e.g. v0.4.0): v0.16.1
Install method (e.g. helm or static manifests): Helm v3.2.4

/kind bug

Is related to https://github.com/jetstack/cert-manager/issues/3121
Hopefully fixed in Helm soon
/close


Improve default operations loading

Description:
When device-details page loads, invokes following APIs to get details of the device and display those on device detail page.

/api/device-mgt/android/v1.0/admin/devices/info
/api/device-mgt/android/v1.0/admin/devices/location

Therefore when you refresh the device detail page, above APIs will be invoked.
This is the default behavior of the IoTS. Hence, if some user required to disable above APIs invocations when the device-details page load, it is impossible with the current implementation.
Therefore it is worth to have a new configuration where it allows users to enable/disable above-mentioned API invocations when device detail page loading.
Affected Product Version:
IoTS 3.3.0

This improvement has added to the latest source and it will be released with 3.3.1 release.


msgpack: rename from libmsgpack

Motivation for this change
The project does not use the name "libmsgpack". It variously uses "msgpack" and
"msgpack-c", and "msgpackc" for the name of the library.
This should be merged after #45283.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Success on x86_64-linux (full log)
Attempted: msgpack
Partial log (click to expand)
-- Installing: /nix/store/2kss14sq901iylfsglmzcq3rp3is6n2n-msgpack-2.1.5/lib/cmake/msgpack/msgpack-targets-release.cmake
-- Installing: /nix/store/2kss14sq901iylfsglmzcq3rp3is6n2n-msgpack-2.1.5/lib/cmake/msgpack/msgpack-config.cmake
-- Installing: /nix/store/2kss14sq901iylfsglmzcq3rp3is6n2n-msgpack-2.1.5/lib/cmake/msgpack/msgpack-config-version.cmake
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2kss14sq901iylfsglmzcq3rp3is6n2n-msgpack-2.1.5
shrinking /nix/store/2kss14sq901iylfsglmzcq3rp3is6n2n-msgpack-2.1.5/lib/libmsgpackc.so.2.0.0
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2kss14sq901iylfsglmzcq3rp3is6n2n-msgpack-2.1.5/lib
patching script interpreter paths in /nix/store/2kss14sq901iylfsglmzcq3rp3is6n2n-msgpack-2.1.5
checking for references to /build in /nix/store/2kss14sq901iylfsglmzcq3rp3is6n2n-msgpack-2.1.5...

Success on aarch64-linux (full log)
Attempted: msgpack
Partial log (click to expand)
-- Installing: /nix/store/4ljaiz866w8p5db4y01r7xms3vla8xpp-msgpack-2.1.5/lib/cmake/msgpack/msgpack-targets-release.cmake
-- Installing: /nix/store/4ljaiz866w8p5db4y01r7xms3vla8xpp-msgpack-2.1.5/lib/cmake/msgpack/msgpack-config.cmake
-- Installing: /nix/store/4ljaiz866w8p5db4y01r7xms3vla8xpp-msgpack-2.1.5/lib/cmake/msgpack/msgpack-config-version.cmake
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4ljaiz866w8p5db4y01r7xms3vla8xpp-msgpack-2.1.5
shrinking /nix/store/4ljaiz866w8p5db4y01r7xms3vla8xpp-msgpack-2.1.5/lib/libmsgpackc.so.2.0.0
strip is /nix/store/4md2i310zklkkl5j41yw70gcwgn4kav5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4ljaiz866w8p5db4y01r7xms3vla8xpp-msgpack-2.1.5/lib
patching script interpreter paths in /nix/store/4ljaiz866w8p5db4y01r7xms3vla8xpp-msgpack-2.1.5
checking for references to /build in /nix/store/4ljaiz866w8p5db4y01r7xms3vla8xpp-msgpack-2.1.5...

Success on x86_64-darwin (full log)
Attempted: msgpack
Partial log (click to expand)
-- Installing: /nix/store/nbbqbbxypi84ixdzzzr2zrgkx2f4i8d6-msgpack-2.1.5/include/msgpack/zone_decl.hpp
-- Installing: /nix/store/nbbqbbxypi84ixdzzzr2zrgkx2f4i8d6-msgpack-2.1.5/lib/pkgconfig/msgpack.pc
-- Installing: /nix/store/nbbqbbxypi84ixdzzzr2zrgkx2f4i8d6-msgpack-2.1.5/lib/cmake/msgpack/msgpack-targets.cmake
-- Installing: /nix/store/nbbqbbxypi84ixdzzzr2zrgkx2f4i8d6-msgpack-2.1.5/lib/cmake/msgpack/msgpack-targets-release.cmake
-- Installing: /nix/store/nbbqbbxypi84ixdzzzr2zrgkx2f4i8d6-msgpack-2.1.5/lib/cmake/msgpack/msgpack-config.cmake
-- Installing: /nix/store/nbbqbbxypi84ixdzzzr2zrgkx2f4i8d6-msgpack-2.1.5/lib/cmake/msgpack/msgpack-config-version.cmake
post-installation fixup
strip is /nix/store/bg39mxc401qqxgjasxfgardi6xl2ikmc-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/nbbqbbxypi84ixdzzzr2zrgkx2f4i8d6-msgpack-2.1.5/lib
patching script interpreter paths in /nix/store/nbbqbbxypi84ixdzzzr2zrgkx2f4i8d6-msgpack-2.1.5

still it needs to rebased.

Success on x86_64-linux (full log)
Attempted: msgpack
Partial log (click to expand)
-- Installing: /nix/store/5d58nvaizas10qhwsj95ayhym1sr6pif-msgpack-3.0.1/lib/cmake/msgpack/msgpack-targets-release.cmake
-- Installing: /nix/store/5d58nvaizas10qhwsj95ayhym1sr6pif-msgpack-3.0.1/lib/cmake/msgpack/msgpack-config.cmake
-- Installing: /nix/store/5d58nvaizas10qhwsj95ayhym1sr6pif-msgpack-3.0.1/lib/cmake/msgpack/msgpack-config-version.cmake
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5d58nvaizas10qhwsj95ayhym1sr6pif-msgpack-3.0.1
shrinking /nix/store/5d58nvaizas10qhwsj95ayhym1sr6pif-msgpack-3.0.1/lib/libmsgpackc.so.2.0.0
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5d58nvaizas10qhwsj95ayhym1sr6pif-msgpack-3.0.1/lib
patching script interpreter paths in /nix/store/5d58nvaizas10qhwsj95ayhym1sr6pif-msgpack-3.0.1
checking for references to /build in /nix/store/5d58nvaizas10qhwsj95ayhym1sr6pif-msgpack-3.0.1...

Success on x86_64-darwin (full log)
Attempted: msgpack
Partial log (click to expand)
-- Installing: /nix/store/g2iiispa2jvxriis72i2rg0i84c64x1a-msgpack-3.0.1/include/msgpack/zone_decl.hpp
-- Installing: /nix/store/g2iiispa2jvxriis72i2rg0i84c64x1a-msgpack-3.0.1/lib/pkgconfig/msgpack.pc
-- Installing: /nix/store/g2iiispa2jvxriis72i2rg0i84c64x1a-msgpack-3.0.1/lib/cmake/msgpack/msgpack-targets.cmake
-- Installing: /nix/store/g2iiispa2jvxriis72i2rg0i84c64x1a-msgpack-3.0.1/lib/cmake/msgpack/msgpack-targets-release.cmake
-- Installing: /nix/store/g2iiispa2jvxriis72i2rg0i84c64x1a-msgpack-3.0.1/lib/cmake/msgpack/msgpack-config.cmake
-- Installing: /nix/store/g2iiispa2jvxriis72i2rg0i84c64x1a-msgpack-3.0.1/lib/cmake/msgpack/msgpack-config-version.cmake
post-installation fixup
strip is /nix/store/bg39mxc401qqxgjasxfgardi6xl2ikmc-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/g2iiispa2jvxriis72i2rg0i84c64x1a-msgpack-3.0.1/lib
patching script interpreter paths in /nix/store/g2iiispa2jvxriis72i2rg0i84c64x1a-msgpack-3.0.1

Success on aarch64-linux (full log)
Attempted: msgpack
Partial log (click to expand)
-- Installing: /nix/store/9xsfzwjssdhsl9mab8bzk9vfibb1p36q-msgpack-3.0.1/lib/cmake/msgpack/msgpack-targets-release.cmake
-- Installing: /nix/store/9xsfzwjssdhsl9mab8bzk9vfibb1p36q-msgpack-3.0.1/lib/cmake/msgpack/msgpack-config.cmake
-- Installing: /nix/store/9xsfzwjssdhsl9mab8bzk9vfibb1p36q-msgpack-3.0.1/lib/cmake/msgpack/msgpack-config-version.cmake
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9xsfzwjssdhsl9mab8bzk9vfibb1p36q-msgpack-3.0.1
shrinking /nix/store/9xsfzwjssdhsl9mab8bzk9vfibb1p36q-msgpack-3.0.1/lib/libmsgpackc.so.2.0.0
strip is /nix/store/4md2i310zklkkl5j41yw70gcwgn4kav5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9xsfzwjssdhsl9mab8bzk9vfibb1p36q-msgpack-3.0.1/lib
patching script interpreter paths in /nix/store/9xsfzwjssdhsl9mab8bzk9vfibb1p36q-msgpack-3.0.1
checking for references to /build in /nix/store/9xsfzwjssdhsl9mab8bzk9vfibb1p36q-msgpack-3.0.1...


Expand doesn't handle dynamic shaped tensors.

System Info
AWS p3.8xlarge (https://aws.amazon.com/ec2/instance-types/p3/)
Who can help?
No response
Information

[ ] The official example scripts
[X] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[ ] My own task or dataset (give details below)

Reproduction
test_expand_dyn.py.txt
# SPDX-FileCopyrightText: Copyright (c) 2022-2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import unittest

import numpy as np

# isort: off
import torch
import tensorrt as trt
# isort: on
from polygraphy.backend.trt import (CreateConfig, EngineFromNetwork, Profile,
                                    TrtRunner)

import tensorrt_llm
from tensorrt_llm import Tensor

class TestFunctional(unittest.TestCase):

    def setUp(self):
        tensorrt_llm.logger.set_level('error')

    def test_expand_dyn_input(self):
        # test data
        dtype = 'float32'
        input_shape = (-1, 10)

        # construct trt network
        builder = tensorrt_llm.Builder()
        net = builder.create_network()
        with tensorrt_llm.net_guard(net):
            network = tensorrt_llm.default_trtnet()
            input = Tensor(name='input',
                           shape=input_shape,
                           dtype=tensorrt_llm.str_dtype_to_trt(dtype))
            shape = tensorrt_llm.functional.constant(np.array([1, 10]))
            output = tensorrt_llm.functional.expand(input, shape)
            output_shape = tensorrt_llm.functional.shape(output, 0)

        # trt run
        profiles = [Profile().add('shape', (1, 1), input_shape, (10, 10))]
        build_engine = EngineFromNetwork((builder.trt_builder, net.trt_network),
                                         config=CreateConfig(profiles=profiles))

    def test_expand_dyn_inout(self):
        # test data
        dtype = 'float32'
        input_shape = (-1, 10)

        # construct trt network
        builder = tensorrt_llm.Builder()
        net = builder.create_network()
        with tensorrt_llm.net_guard(net):
            network = tensorrt_llm.default_trtnet()
            input = Tensor(name='input',
                           shape=input_shape,
                           dtype=tensorrt_llm.str_dtype_to_trt(dtype))
            shape = tensorrt_llm.functional.constant(np.array([-1, 10]))
            output = tensorrt_llm.functional.expand(input, shape)
            output_shape = tensorrt_llm.functional.shape(output, 0)

        # trt run
        profiles = [Profile().add('shape', (1, 1), input_shape, (10, 10))]
        build_engine = EngineFromNetwork((builder.trt_builder, net.trt_network),
                                         config=CreateConfig(profiles=profiles))

Rename the above file to test_expand_dyn.py and run:
python3 -m unittest test_expand_dyn.py
Expected behavior
The test should succeed.
actual behavior
The test fails with the following:
[TensorRT-LLM] TensorRT-LLM version: 0.10.0
[07/03/2024-22:05:51] [TRT] [E] ITensor::getDimensions: Error Code 4: Internal Error (Tensor (Unnamed Layer* 1) [Slice]_output has axis 0 with inherently negative length. Proven upper bound is -1. Network must have an instance where axis has non-negative length.)
[07/03/2024-22:05:51] [TRT] [E] ITensor::getDimensions: Error Code 4: Internal Error (Output shape can not be computed for node SHAPE_4.)
E.
======================================================================
ERROR: test_expand_dyn_inout (test_expand_dyn.TestFunctional)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/TensorRT-LLM/tests/functional/test_expand_dyn.py", line 72, in test_expand_dyn_inout
    output_shape = tensorrt_llm.functional.shape(output, 0)
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/functional.py", line 1779, in shape
    return gather(res, dim=0, indices=dim).view([])
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/functional.py", line 1831, in gather
    assert input.rank() == indices.rank()
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/functional.py", line 476, in rank
    return len(self.trt_tensor.shape)
ValueError: __len__() should return >= 0

----------------------------------------------------------------------
Ran 2 tests in 1.425s

FAILED (errors=1)

additional notes
When compiling a llama-like model using trtllm-build, tensors with a batch size dimension have that dimension set to -1.  But operators like expand and inherently slice seem to have issues supporting an input or output tensor with a dimension with size -1, so subsequent operations using the output fail to build.

I found a proper way to do it now: Basically the dynamic shape itself should be a model input.

@jxchenus hello,I meet the same problem. how do you use the dynamic shape as a model_input?
https://github.com/pytorch/TensorRT/issues/3140
when the batch_size used as. input, I must use batch_size= grouped_features["batch_size"].item() to get, it will encounted anther bug
queries = query.unsqueeze(1).expand(batch_size, max_seq_length, -1)

I found a workaround by using slice fill mode instead.  The shape of the output can be dynamically passed in:
https://github.com/NVIDIA/TensorRT/issues/3979#issuecomment-2207755877


A tag for jre9

Any plan for support jre9?

Absolutely, opened https://github.com/docker-library/tomcat/pull/101 to gauge whether our existing tests pass. :+1:

Alpine still not support?

Nope, the openjdk image still has no Alpine support for 9


AWS Session Tokens not loaded from .credentials file

When relying on loading a Credentials object from a specific profile, you should include the token as well if it is present within the .credentials file. For example, this is the format of my credentials file. aws_session_token and aws_security_token are both the same value. This format works with the current AWS S3 CLI, but I get an access denied when it's processed by this library.
[teamname/account_name]
aws_access_key_id=<redacted>
aws_secret_access_key=<redacted>
aws_session_token=<redacted>
aws_security_token=<redacted>

@cutler-scott-newrelic  thank you for the report, I'll carve some time to implement over the weekend hopefully :)

@cutler-scott-newrelic version 0.18.5 will be pushed to crates.io today, it should pull tokens from the file correctly

Awesome, thank you very much!


📝 Add myself to users list

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

NONE

Thanks!
/lgtm
/approve
/override dco
/kind documentation

/ok-to-test


Exodus

App Logo (Required)
(Attach image here)
App Details (Required)
Type: Wallet or Dapp
Name: Exodus Wallet
Homepage Url: https://www.exodus.com
Chains supported:
App Url (Required - at least one)
Browser Url:
iOS Url:
Android Url:
Mac Url:
Windows Url:
Linux Url:
Mobile Linking (Optional)
Deep Link:
Universal Link:
Desktop Linking (Optional)
Deep Link:
Universal Link:
Metadata (Optional)
Short Name:
Primary Color:
Secondary Color:

Logo missing and App url... also can you confirm that Exodus supports WalletConnect and you represent their team in any form?


com.chamburr.Glance.QLPlugin failed during preview of this document.

If I have quickview open on a document type that doesn't work at all such as .md (markdown) files, then move to another file type using the cursor keys, such as json, the preview for that json will show. If I then move off the file, then back again, the preview failed message appears and glance is now broken for all supported file types.
Re-opening Glance generally fixes it.
monterey 12.6.3 (21G419), m1
glance v1.5.0

Cannot reproduce. Glance works fine on markdown files.


[BUG]: Using an existing postgres-js driver throws could not find package postgres error

Report hasn't been filed before.

[X] I have verified that the bug I'm about to report hasn't been filed before.

What version of drizzle-orm are you using?
0.38.0
What version of drizzle-kit are you using?
0.30.0
Other packages
<EMAIL_ADDRESS>Describe the Bug
Hello!
I'm running drizzle-orm with Deno 2.0 and using postgres-js driver from deno.land (https://deno.land/x/postgresjs@v3.4.5).
Following these steps from docs:

If you need to provide your existing driver:

// Make sure to install the 'postgres' package
import { drizzle } from 'drizzle-orm/postgres-js';
import postgres from 'postgres';
const queryClient = postgres(process.env.DATABASE_URL);
const db = drizzle({ client: queryClient });
const result = await db.execute('select 1');

I get this error: Could not find package 'postgres' from referrer<EMAIL_ADDRESS>Seems like it's expecting to have postgres installed from npm, even when using an existing driver.

Trying to reproduce your issue locally, everything seems to work fine. Could you provide more detailed explanation of reproduction steps or an reproduction repo?


[BUG] Current folder with spaces does not watch

Describe the bug
On my local computer, the project I'm working on includes spaces on the folder, trying to run 'nx serve api' bugs out with the message:

watch : The project file 'C:\Users\user\Documents\Projects\Team Workload\apps\api\C:\Users\user\Documents\Projects\Team' does not exist..

I tried to solve the problem locally and the solution is easy, on DotNetClient.run just convert the cmd variable to an array of parameters:
let cmd = watch ? [`watch`, `--project`, project, `run`] : [`run`, `--project`, project];

Do the proper changes to accumulate the function parameter 'parameters'. And to print the message on the console just do a .join(' ')
To Reproduce
Steps to reproduce the behavior:

run 'nx serve api'

Expected behavior
The project API should be served as described in the documentation.
Environment:

OS: used Windows but probably any OS
Version: 1.8.0
DotnetClient

How can I push the fix to the repository?

Hey @asinino, sorry I've been away for paternity leave at work, and trying to stay away to spend time with family. If you have WSL setup on windows, I can verify the repo works well under it. Further tooling changes would have to wait for me to be back, unless you feel like working on those and then I can review them.

Hello
Took some time to have spare time to do this.
I added a PR that encloses the project path + name with double quotes (present ao all commands referencing a project).
I did not add a test for this situation, a name with spaces and or a parent folder name with spaces, is the test a requirement? If needed how can I develop this solution?

The test would be nice, but this is fine as-is IMHO. The dotnet package itself is pretty light on tests, if one were to be added I'd recommend just adding an e2e test in the core-e2e project since there are not currently e2e tests set up for the dotnet project.
Eventually, we should probably set up e2e for it, shouldn't be hard but isn't currently done.

Hmmmm, that doesn't seem like something that should have been changed by your previous PR. We've always passed fully resolved paths to the dotnet commands, and the updates you added shouldn't have changed anything with that. Let me look into it real quick.

Ok, I'll convert the cmd into an array of arguments, it should fix the issue.
I'm having some trouble testing it offline, how can I run it locally? I changed the way Verdaccio is called and now it's correctly initialized. But the command to publish-local is falling (I'll open a new issue for this and try to properly supply a fix).
I don't control everything on my current machine and the environment does not allow me to have WSL :/

Also, change this ticket back to open because the currently applied fix is breaking the package.

Running into the same issue:

Installed this lib via npm install --save-dev @nx-dotnet/core
Created a new web api project via nx console
Executed serve for project via nx console (command used is npx nx serve my-project-name

Output
Executing Command: dotnet watch --project "/home/username/code/reponame/apps/my-project-name/My.Project.Name.csproj" run --configuration Debug
watch : The project file '/home/username/code/reponame/apps/my-project-name/"/home/username/code/reponame/apps/my-project-name/My.Project.Name.csproj"' does not exist.

When executing the command listed above in bash directly the web api starts up right away no issues, for refrence this is the command that works:
dotnet watch --project "/home/username/code/reponame/apps/my-project-name/My.Project.Name.csproj" run --configuration Debug

Given that the issue is path based this seems rather central and I would guess that right now running dotnet apps via the serve command is broken in general in the latest version.
Any timeline on a fix?

CC @asinino I pushed some updates to your branch and went ahead and merged it. Going to cut a release soon to fix since its pretty urgent bug. Everything looks fine testing locally, and E2E passed.

I can confirm this fixed the bug for us. Hella quick turnaround guys, keep it up !!!

I couldn't test it locally, it always failed, with my version of dotnet-format it still fails because the parameter "--check" does not exist.
Still, I pushed a fix to execute return the buffer from stdout. Can you see the change? Do I need another pull request?

@asinino Open a new issue for the dotnet-format bug, I verified it worked with dotnet 5.0.203 and 6.0.200 locally.


Cleanup CLI tool options/command

Ask @boogheta for his expertise in the subject.

Either three verbs or domains.


gpxsee: 7.11 -> 7.12

Motivation for this change
Changelog:

Added support for SeeYou CUP files.
Added support for Geographic 2D projection in vector maps.
Fixed lat/lon reference parsing in big endian EXIF entries.

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@grahamcofborg build gpxsee


$ in password

i have the $ symbol in my password, and this code doesn't work:
@task
def create_database(name):
    password = 'test'
    name = 'test'
    mysql_password = prompt("Insert you password: ")
    with settings(mysql_user='root', mysql_password=mysql_password):
        if not fabtools.mysql.user_exists(name):
            fabtools.mysql.create_user(name, password=password)
        if not fabtools.mysql.database_exists(name):
            fabtools.require.mysql.database(name, owner=name)
    return password

Thanks for the report.
The code in fabtools attempts to quote the password (see https://github.com/ronnix/fabtools/blob/master/fabtools/mysql.py#L33), but it looks like it is not enough. :(


/list shows me in every rank I inherit

Using PEX, as 'Owner', inheriting Admin, which inherits Mod, etc...
I show up as every rank in /list.

Fixed in 88d56657b9ef58f582e3108e74545475b977900a


Security group ingress/egress fix

In version 0.6.0 of terraform, ingress/egress rules that are both self referencing and contain a CIDR block are sometimes combined in the tfstate output. If the resources are separate in the .tf template, this causes terraform plan to show a large diff. This PR will combine rules that have the same protocol and port range, and that are both self referencing and contain a CIDR block. This effects both .tf and .tfstate output. This fixes https://github.com/dtan4/terraforming/issues/92.

LGTM :+1: Thanks :exclamation: :exclamation:


Increase test coverage

@lepture Please review.

Coverage increased (+16.67%) to 100.0% when pulling 90af020bc4359de89a893260d7cdee9468511795 on test-cov into 16903a924eaf24ab626dc47e3eaf53a6ad125bec on master.

Coverage increased (+16.67%) to 100.0% when pulling 90af020bc4359de89a893260d7cdee9468511795 on test-cov into 16903a924eaf24ab626dc47e3eaf53a6ad125bec on master.

done


Add block size to dd command

Without configuring the block size a default of 512 bytes is used, which can
slow down the transfer speed massively.
In a test I've done with a semi-decent USB stick, I only get a transfer speed
of around 180 KB/sec when not specifying the block size but see 27 MB/sec when
setting the block size to 1 MB. This makes the transfer of the minimal
installation ISO take half a minute instead of an hour.
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Please squash commits.

Did you check the manual on macOS? I guess that's where this is relevant.
man dd on a macOS 12.3 machine says:

Where sizes or speed are specified, a decimal, octal, or hexadecimal number of bytes is expected.  If the number ends with a “b”, “k”, “m”, “g”, “t”, “p”, or “w”, the number is multiplied by 512, 1024 (1K), 1048576 (1M),<PHONE_NUMBER> (1G),<PHONE_NUMBER>776 (1T),<PHONE_NUMBER>842624 (1P) or the number of bytes in an integer, respectively.  Two or more numbers may be separated by an “x” to indicate a product.

It works with either uppercase or lowercase though, so I can still change it if you'd like.

Did you check the manual on macOS? I guess that's where this is relevant.
man dd on a macOS 12.3 machine says:

Where sizes or speed are specified, a decimal, octal, or hexadecimal number of bytes is expected.  If the number ends with a “b”, “k”, “m”, “g”, “t”, “p”, or “w”, the number is multiplied by 512, 1024 (1K), 1048576 (1M),<PHONE_NUMBER> (1G),<PHONE_NUMBER>776 (1T),<PHONE_NUMBER>842624 (1P) or the number of bytes in an integer, respectively.  Two or more numbers may be separated by an “x” to indicate a product.

It works with either uppercase or lowercase though, so I can still change it if you'd like.

Ok, then I think only macOS dd is flexible on the lower vs upper case. On NixOS (with GNU coreutils):
$ dd if=/dev/zero of=/dev/null bs=1m
dd: invalid number: ‘1m’

$ dd if=/dev/zero of=/dev/null bs=1M
^C7896+0 records in
7896+0 records out
8279556096 bytes (8.3 GB, 7.7 GiB) copied, 0.685209 s, 12.1 GB/s

Ah okay, I'll change it then so it works more universally. This is on macOS:
~ % dd if=/dev/zero of=/dev/null bs=1m count=10
10+0 records in
10+0 records out
10485760 bytes transferred in 0.000782 secs<PHONE_NUMBER>6 bytes/sec)
~ % dd if=/dev/zero of=/dev/null bs=1M count=10
10+0 records in
10+0 records out
10485760 bytes transferred in 0.000712 secs<PHONE_NUMBER>1 bytes/sec)

Thanks!


How to use this plugin with ionic 6 ? Also can anybody confirms that this plugin support to use google ads anywhere in my view in mobile app e.g. ads can be placed between a list of elements.

Bug report

[ ] I confirm this is a suspected bug or issue that will affect other users

[ ] I have reproduced the issue using the example project or provided the necessary information to reproduce the issue.

[ ] I have read the documentation thoroughly and it does not help solve my issue.

[x] I have checked that no similar issues (open or closed) already exist.

Current behavior:

Expected behavior:

Steps to reproduce:

Screenshots

Environment information

Cordova CLI version

cordova -v

Cordova platform version

cordova platform ls

Plugins & versions installed in project (including this plugin)

cordova plugin ls

Dev machine OS and version, e.g.

OSX

sw_vers

Windows 10

winver

Runtime issue

Device details

e.g. iPhone X, Samsung Galaxy S8, iPhone X Simulator, Pixel XL Emulator

OS details

e.g. iOS 12.2, Android 9.0

Android build issue:

Node JS version

node -v

Gradle version

ls platforms/android/.gradle

Target Android SDK version

android:targetSdkVersion in AndroidManifest.xml

Android SDK details

sdkmanager --list | sed -e '/Available Packages/q'

iOS build issue:

Node JS version

node -v

XCode version

Related code:
insert any relevant code here such as plugin API calls / input parameters

Console output

console output

// Paste any relevant JS/native console output here

Other information:

completed? how?


Remove old feature flags - TEMPLATE_SERVICE_PROVIDERS_ENABLED and PROVIDER_STRATEGIES_ENABLED

User Story - Business Need

[ ] Ticket is understood, and QA has been contacted (if the ticket has a QA label).

There were old feature flags identified when working on #1711. While reviewing which task definitions to be removed, it was observed that several task definitions were old feature flags that were all set to True or never turned on. These feature flags with their related task definitions, code paths, and tests should be removed. This user story focused specifically on TEMPLATE_SERVICE_PROVIDERS_ENABLED and PROVIDER_STRATEGIES_ENABLED.
TEMPLATE_SERVICE_PROVIDERS_ENABLED and PROVIDER_STRATEGIES_ENABLED feature flags appear in if statements in the client_to_use method. Both have been set to True in all ENVs for at least 3 years.
Since the method returns a client if the feature flag  PROVIDER_STRATEGIES_ENABLED is True, the rest of the method is NOT used.
We need to remove the feature flags TEMPLATE_SERVICE_PROVIDERS_ENABLED and PROVIDER_STRATEGIES_ENABLED. And remove any unused logic and related tests.

User Story(ies)
As a    VA Notify Developer,
I want remove old feature flags PROVIDER_STRATEGIES_ENABLED and TEMPLATE_SERVICE_PROVIDERS_ENABLED with related code paths, and task definitions
So that the code runs efficiently and continues to be maintainable.
Additional Info and Resources

See spreadsheet created for ticket #1711 - filter by 'feature flag removal' under the 'removal status' column.
Acceptance Criteria

[ ] TEMPLATE_SERVICE_PROVIDERS_ENABLED and PROVIDER_STRATEGIES_ENABLED feature flags with related task definitions, code paths, and tests are removed
[ ] Unused logic in client_to_use is removed and test updated appropriately
[ ] Test suite and regression test run without fail
[ ] Sending an sms to a provider works as expected (Note: Deliver sms celery task. client_to_use is apart of this code path)
[ ] Sending an email to a provide works as expected (Note: Deliver email celery task. client_to_use is apart of this code path)

QA Considerations

[ ] Sending an sms to a provider works as expected (Note: Deliver sms celery task. client_to_use is apart of this code path)
[ ] Sending an email to a provide works as expected (Note: Deliver email celery task. client_to_use is apart of this code path)

Potential Dependencies

Hey team! Please add your planning poker estimate with Zenhub @cris-oddball @EvanParish @k-macmillan @MackHalliday @mchlwellman


[gsoc2020] Add deprecation notice

Add deprecated notice in the repository after it is merged with the openwisp-ipam module.

We should also archive the repo to make it readonly.

We should also archive the repo to make it readonly.
I don't have the permission to do it, I think you'll have to do it from settings! :smile:


Bump Devise to v4.9.0

The new version of Devise includes support for Hotwire/Turbo.
We're not using Turbo, so we shouldn't need to change anything.
Changelog

Ready to UAT on staging


Bump the webhook version to 0.4.0-rc3

@tomleb, I will add a link to this timeout-changing commit to the issue intending to introduce a long-term fix.


It's difficult to switch to a different language in news from the English language

Is your feature request related to a problem? Please describe.
I tried to swap to the Spanish language in /news, had to go Spanish article, clicked the link in the image below to navigate to Spanish article, then clicked on freeCodeCamp to reach https://www.freecodecamp.org/espanol/news

Describe the solution you'd like
Add a menu, in the news. With language selector and how to contribute section.
Describe alternatives you've considered
none
Additional context
none

Your steps to reproduce this are not cohesive or clear to me. Can you write the issue as plainly as possible for a better understanding?

I read this atleast three times and I understand all you are asking is we have a menu item like below

Correct?

Thanks.
It's highly unlikely that we will implement this because it has been discussed in the past and confirmed that the majority of the users reach news articles from outside news.
I understand that we need to showcase more available languages, but I am not sure that we want a menu. I believe we do not want many options.
In fact, with the recent addition of "the thank you for supporting.." banner for donors on news, we got rid of any apparent way to even reach learn from the news.

I am going to go ahead and close this and we can reopen this after discussing internally.


Add dependency review action

This action will scan dependency files and ensure
we're not introducing anything with known vulnerabilities.

Codecov Report

Merging #12 (14a1576) into main (4f9b33e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #12   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            7         7
  Lines          149       149
=========================================
  Hits           149       149

Flag
Coverage Δ

unittests
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f9b33e...14a1576. Read the comment docs.


Fix: Default FromEmail/HelloName values causing incorrect "deliverable" results

Hey! 👋
The current default values for "FromEmail" and "HelloName" are causing incorrect "deliverable" results during SMTP checks. Would be great to update these defaults in the package.
It currently gives the following error (with some providers):
550 5.7.27 Sender address rejected: Domain example.org does not accept mail (nullMX) error

Quick fix:
Update the default from email and hello name.
verifier := emailverifier.NewVerifier().
    FromEmail("email@gmail.com").
    HelloName("gmail.com")

To the maintainers of this repo, i recommend updating the default values for this fields 👍
This is the fix to this related issue: https://github.com/AfterShip/email-verifier/issues/72
Thanks, hope it helps

Change them and use your domain
On Wed, Oct 30, 2024 at 7:29 PM David Emiliano calzada morales <
@.***> wrote:

Hey! 👋
The current default values for "FromEmail" and "HelloName" are causing
incorrect "deliverable" results during SMTP checks. Would be great to
update these defaults in the package.
It currently gives the following error (with some providers):
550 5.7.27 Sender address rejected: Domain example.org does not accept mail (nullMX) error
Quick fix:
Update the default from email and hello name.
verifier := emailverifier.NewVerifier().
@.***").
HelloName("gmail.com")
To the maintainers of this repo, i recommend updating the default values
for this fields 👍
This is the fix to this related issue: #72
https://github.com/AfterShip/email-verifier/issues/72
Thanks, hope it helps
—
Reply to this email directly, view it on GitHub
https://github.com/AfterShip/email-verifier/issues/133, or unsubscribe
https://github.com/notifications/unsubscribe-auth/BEDTLKXYL35O4V4FGUNO3S3Z6DQ4VAVCNFSM6AAAAABQ4FZOYWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGYZDIMRQGY2TGMI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Important Feature: Add validation in Signup and Sign In form

Feature description
JS validation add in sign up, sign in form to enhance user experience
Now,  without any validation it submitting the form .

@SauravMukherjee44 @rohanbabbar04 I would like to  contribute on this project under  GSSOC'23
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Can you assign me this issue under gssoc'23?

Go ahead @Geeta259


docs: remove reference to globalShortcut

As far as I am aware this module does not use globalShortcut behind the scenes anymore.
Feel free to close if I missed something somewhere 😆

As far as I am aware this module does not use globalShortcut behind the scenes anymore.

Yes, that's true: globalShortcut is not used anymore, but I forgot to remove the note. Thank you!


Replace csv delimiters in text

Edit replaces any semicolon characters in text that would otherwise mess up reading the created CSV file.

Thank you for this PR. Given the text in the CSV file is quoted, extra semicolons shouldn't mess up the generated CSV file. However, I'm happy to include this.
Could you add a second commit updating the resulting CSV files (articles.csv, train.csv, and test.csv)?

Hey, sorry, my mistake! You are right, I only noticed that the delimiters are quoted after I already made the PR. No changes needed, I will close the PR!
But maybe it would be helpful to add a short info to the readme about this, took me quite some time to figure out how load this properly into pandas (but maybe that's just me) 😄
Could be something like:
Reading the data with Pandas:
import csv
import pandas
data = pandas.read_csv("articles.csv", sep = ";", names = ["Topic", "Article"], quotechar = "\'", quoting = csv.QUOTE_MINIMAL, encoding = "utf-8")


PGSync SQLAlchemy errors when trying to sync a column "items" with type integer, but works with other integer columns

Operating System: Ubuntu 20.04.3 LTS (GNU/Linux 5.4.0-96-generic x86_64)
PGSync version: 2.1.10
Postgres version: 13.5
Elasticsearch version: 7.16.3
Redis version: 5.0.7
Python version: Python 3.8.10
Problem Description:
PGSync SQLAlchemy errors when trying to sync a column called "items" with SQL type integer, but it works with another integer column called "owners". The error appears during syncing, not during bootstrap.
My SQL schema looks like:
name: text (Primary Key)
policy_id: text (Unique)
items: integer
owners: integer

My schema.json:
[
  {
    "index": "test_index",
    "setting": {
      ... // Omitted for brevity
   },
    "nodes": {
      "table": "collections",
      "schema": "public",
      "columns": [
        "policy_id",
        "name",
        "owners", // Owners column works
        "items" // Items column fails with the error below
      ],
      "transform": {
        "mapping":  {
            "name": {
               "type": "text",
               "analyzer": "custom_edge_ngram_analyzer"
              }
          }
        }
      }
    }
]

Error Message (if any):
 2022-01-22 21:00:33.169:ERROR:pgsync.elastichelper: Exception (psycopg2.ProgrammingError) can't adapt type 'method'
 [SQL: SELECT anon_1."JSON_BUILD_ARRAY_1", anon_1."JSON_BUILD_OBJECT_1", anon_1.name
 FROM (SELECT JSON_BUILD_ARRAY() AS "JSON_BUILD_ARRAY_1", JSON_BUILD_OBJECT(%(JSON_BUILD_OBJECT_2)s, collections_1.policy_id, %(JSON_BUILD_OBJECT_3)s, collections_1.name, %(JSON_BUILD_OBJECT_4)s, collections_1.display_name, %(JSON_BUILD_OBJECT_5)s, collections_1.hero_image_file_type, %(JSON_BUILD_OBJECT_6)s, collections_1.owners, %(JSON_BUILD_OBJECT_7)s, %(JSON_BUILD_OBJECT_8)s) AS "JSON_BUILD_OBJECT_1", collections_1.name AS name
 FROM public.collections AS collections_1
 WHERE CAST(CAST(collections_1.xmin AS TEXT) AS BIGINT) < %(param_1)s) AS anon_1]
 [parameters: {'JSON_BUILD_OBJECT_2': 'policy_id', 'JSON_BUILD_OBJECT_3': 'name', 'JSON_BUILD_OBJECT_4': 'display_name', 'JSON_BUILD_OBJECT_5': 'hero_image_file_type', 'JSON_BUILD_OBJECT_6': 'owners', 'JSON_BUILD_OBJECT_7': 'items', 'JSON_BUILD_OBJECT_8': <bound method ColumnCollection.items of <sqlalchemy.sql.base.ImmutableColumnCollection object at 0x7f36c68dbf90>>, 'param_1': 8753184}]
 (Background on this error at: https://sqlalche.me/e/14/f405)
 Traceback (most recent call last):
   File "/usr/local/lib/python3.8/dist-packages/sqlalchemy/engine/base.py", line 1802, in _execute_context
     self.dialect.do_execute(
   File "/usr/local/lib/python3.8/dist-packages/sqlalchemy/engine/default.py", line 732, in do_execute
     cursor.execute(statement, parameters)
 psycopg2.ProgrammingError: can't adapt type 'method'
 The above exception was the direct cause of the following exception:
 Traceback (most recent call last):
   File "/usr/local/lib/python3.8/dist-packages/pgsync/elastichelper.py", line 106, in bulk
     self._bulk(
   File "/usr/local/lib/python3.8/dist-packages/pgsync/elastichelper.py", line 172, in _bulk
     for _ in helpers.parallel_bulk(
   File "/usr/local/lib/python3.8/dist-packages/elasticsearch/helpers/actions.py", line 472, in parallel_bulk
     for result in pool.imap(
   File "/usr/lib/python3.8/multiprocessing/pool.py", line 868, in next
     raise value
   File "/usr/lib/python3.8/multiprocessing/pool.py", line 125, in worker
     result = (True, func(*args, **kwds))
   File "/usr/lib/python3.8/multiprocessing/pool.py", line 144, in _helper_reraises_exception
     raise ex
   File "/usr/lib/python3.8/multiprocessing/pool.py", line 388, in _guarded_task_generation
     for i, x in enumerate(iterable):
   File "/usr/local/lib/python3.8/dist-packages/elasticsearch/helpers/actions.py", line 155, in _chunk_actions
     for action, data in actions:
   File "/usr/local/lib/python3.8/dist-packages/pgsync/sync.py", line 823, in sync
     for i, (keys, row, primary_keys) in enumerate(
   File "/usr/local/lib/python3.8/dist-packages/pgsync/base.py", line 783, in fetchmany
     result = conn.execution_options(stream_results=True).execute(
   File "/usr/local/lib/python3.8/dist-packages/sqlalchemy/engine/base.py", line 1289, in execute
     return meth(self, multiparams, params, _EMPTY_EXECUTION_OPTS)
   File "/usr/local/lib/python3.8/dist-packages/sqlalchemy/sql/elements.py", line 325, in _execute_on_connection
     return connection._execute_clauseelement(
   File "/usr/local/lib/python3.8/dist-packages/sqlalchemy/engine/base.py", line 1481, in _execute_clauseelement
     ret = self._execute_context(
   File "/usr/local/lib/python3.8/dist-packages/sqlalchemy/engine/base.py", line 1845, in _execute_context
     self._handle_dbapi_exception(
   File "/usr/local/lib/python3.8/dist-packages/sqlalchemy/engine/base.py", line 2026, in _handle_dbapi_exception
     util.raise_(
   File "/usr/local/lib/python3.8/dist-packages/sqlalchemy/util/compat.py", line 207, in raise_
     raise exception
   File "/usr/local/lib/python3.8/dist-packages/sqlalchemy/engine/base.py", line 1802, in _execute_context
     self.dialect.do_execute(
   File "/usr/local/lib/python3.8/dist-packages/sqlalchemy/engine/default.py", line 732, in do_execute
     cursor.execute(statement, parameters)
 sqlalchemy.exc.ProgrammingError: (psycopg2.ProgrammingError) can't adapt type 'method'
 [SQL: SELECT anon_1."JSON_BUILD_ARRAY_1", anon_1."JSON_BUILD_OBJECT_1", anon_1.name
 FROM (SELECT JSON_BUILD_ARRAY() AS "JSON_BUILD_ARRAY_1", JSON_BUILD_OBJECT(%(JSON_BUILD_OBJECT_2)s, collections_1.policy_id, %(JSON_BUILD_OBJECT_3)s, collections_1.name, %(JSON_BUILD_OBJECT_4)s, collections_1.display_name, %(JSON_BUILD_OBJECT_5)s, collections_1.hero_image_file_type, %(JSON_BUILD_OBJECT_6)s, collections_1.owners, %(JSON_BUILD_OBJECT_7)s, %(JSON_BUILD_OBJECT_8)s) AS "JSON_BUILD_OBJECT_1", collections_1.name AS name
 FROM public.collections AS collections_1
 WHERE CAST(CAST(collections_1.xmin AS TEXT) AS BIGINT) < %(param_1)s) AS anon_1]
 [parameters: {'JSON_BUILD_OBJECT_2': 'policy_id', 'JSON_BUILD_OBJECT_3': 'name', 'JSON_BUILD_OBJECT_4': 'display_name', 'JSON_BUILD_OBJECT_5': 'hero_image_file_type', 'JSON_BUILD_OBJECT_6': 'owners', 'JSON_BUILD_OBJECT_7': 'items', 'JSON_BUILD_OBJECT_8': <bound method ColumnCollection.items of <sqlalchemy.sql.base.ImmutableColumnCollection object at 0x7f36c68dbf90>>, 'param_1': 8753184}]
 (Background on this error at: https://sqlalche.me/e/14/f405)
  0:00:38.467140 (38.47 sec)
 Traceback (most recent call last):
   File "/usr/local/lib/python3.8/dist-packages/sqlalchemy/engine/base.py", line 1802, in _execute_context
     self.dialect.do_execute(
   File "/usr/local/lib/python3.8/dist-packages/sqlalchemy/engine/default.py", line 732, in do_execute
     cursor.execute(statement, parameters)
 psycopg2.ProgrammingError: can't adapt type 'method'
 The above exception was the direct cause of the following exception:
 Traceback (most recent call last):
   File "/usr/local/bin/pgsync", line 7, in <module>
     sync.main()
   File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 1128, in __call__
     return self.main(*args, **kwargs)
   File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 1053, in main
     rv = self.invoke(ctx)
   File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 1395, in invoke
     return ctx.invoke(self.callback, **ctx.params)
   File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 754, in invoke
     return __callback(*args, **kwargs)
   File "/usr/local/lib/python3.8/dist-packages/pgsync/sync.py", line 1125, in main
     sync.pull()
   File "/usr/local/lib/python3.8/dist-packages/pgsync/sync.py", line 975, in pull
     self.es.bulk(self.index, self.sync(txmin=txmin, txmax=txmax))
   File "/usr/local/lib/python3.8/dist-packages/pgsync/elastichelper.py", line 106, in bulk
     self._bulk(
   File "/usr/local/lib/python3.8/dist-packages/pgsync/elastichelper.py", line 172, in _bulk
     for _ in helpers.parallel_bulk(
   File "/usr/local/lib/python3.8/dist-packages/elasticsearch/helpers/actions.py", line 472, in parallel_bulk
     for result in pool.imap(
   File "/usr/lib/python3.8/multiprocessing/pool.py", line 868, in next
     raise value
   File "/usr/lib/python3.8/multiprocessing/pool.py", line 125, in worker
     result = (True, func(*args, **kwds))
   File "/usr/lib/python3.8/multiprocessing/pool.py", line 144, in _helper_reraises_exception
     raise ex
   File "/usr/lib/python3.8/multiprocessing/pool.py", line 388, in _guarded_task_generation
     for i, x in enumerate(iterable):
   File "/usr/local/lib/python3.8/dist-packages/elasticsearch/helpers/actions.py", line 155, in _chunk_actions
     for action, data in actions:
   File "/usr/local/lib/python3.8/dist-packages/pgsync/sync.py", line 823, in sync
     for i, (keys, row, primary_keys) in enumerate(
   File "/usr/local/lib/python3.8/dist-packages/pgsync/base.py", line 783, in fetchmany
     result = conn.execution_options(stream_results=True).execute(
   File "/usr/local/lib/python3.8/dist-packages/sqlalchemy/engine/base.py", line 1289, in execute
     return meth(self, multiparams, params, _EMPTY_EXECUTION_OPTS)
   File "/usr/local/lib/python3.8/dist-packages/sqlalchemy/sql/elements.py", line 325, in _execute_on_connection
     return connection._execute_clauseelement(
   File "/usr/local/lib/python3.8/dist-packages/sqlalchemy/engine/base.py", line 1481, in _execute_clauseelement
     ret = self._execute_context(
   File "/usr/local/lib/python3.8/dist-packages/sqlalchemy/engine/base.py", line 1845, in _execute_context
     self._handle_dbapi_exception(
   File "/usr/local/lib/python3.8/dist-packages/sqlalchemy/engine/base.py", line 2026, in _handle_dbapi_exception
     util.raise_(
   File "/usr/local/lib/python3.8/dist-packages/sqlalchemy/util/compat.py", line 207, in raise_
     raise exception
   File "/usr/local/lib/python3.8/dist-packages/sqlalchemy/engine/base.py", line 1802, in _execute_context
     self.dialect.do_execute(
   File "/usr/local/lib/python3.8/dist-packages/sqlalchemy/engine/default.py", line 732, in do_execute
     cursor.execute(statement, parameters)
 sqlalchemy.exc.ProgrammingError: (psycopg2.ProgrammingError) can't adapt type 'method'
 [SQL: SELECT anon_1."JSON_BUILD_ARRAY_1", anon_1."JSON_BUILD_OBJECT_1", anon_1.name
 FROM (SELECT JSON_BUILD_ARRAY() AS "JSON_BUILD_ARRAY_1", JSON_BUILD_OBJECT(%(JSON_BUILD_OBJECT_2)s, collections_1.policy_id, %(JSON_BUILD_OBJECT_3)s, collections_1.name, %(JSON_BUILD_OBJECT_4)s, collections_1.display_name, %(JSON_BUILD_OBJECT_5)s, collections_1.hero_image_file_type, %(JSON_BUILD_OBJECT_6)s, collections_1.owners, %(JSON_BUILD_OBJECT_7)s, %(JSON_BUILD_OBJECT_8)s) AS "JSON_BUILD_OBJECT_1", collections_1.name AS name
 FROM public.collections AS collections_1
 WHERE CAST(CAST(collections_1.xmin AS TEXT) AS BIGINT) < %(param_1)s) AS anon_1]
 [parameters: {'JSON_BUILD_OBJECT_2': 'policy_id', 'JSON_BUILD_OBJECT_3': 'name', 'JSON_BUILD_OBJECT_4': 'display_name', 'JSON_BUILD_OBJECT_5': 'hero_image_file_type', 'JSON_BUILD_OBJECT_6': 'owners', 'JSON_BUILD_OBJECT_7': 'items', 'JSON_BUILD_OBJECT_8': <bound method ColumnCollection.items of <sqlalchemy.sql.base.ImmutableColumnCollection object at 0x7f36c68dbf90>>, 'param_1': 8753184}]
 (Background on this error at: https://sqlalche.me/e/14/f405)

Thanks for this report. This has been fixed in the master branch.

Thank you!


Which method gives the highest accuracy on the IMDb dataset.

The examples directory in keras repo has Python scripts giving various accuracies on the IMDb dataset. But which of them gives the highest accuracy on the IMDb dataset?. It would be helpful if the accuracies are commented on the top of the scripts for specific hyperparameters like epochs, optimizer etc.

Some of the files do contain the accuracies on the test  dataset. I noticed that the CNN based method is actually giving more accuracy than the bidirectional lstm, the lstm and the CNN+lstm based methods. Isn't this behaviour quite contradicting?

Francois Chollet (creator of Keras) writes in his book on page 206: "LSTM's aren't helpful for sentiment-analysis problem ....there are more difficult NLP problems out there, where the strength of LSTM will become apparent."
Word order is of limited importance, so bi-directional LSTM's are not useful.
Attention: this is a small dataset. Neural networks are hungry and perform better with more data. Much more. Additionally, we have to be careful with comparisons: are we comparing apples with apples? Is there a cross validation? If yes, 5x? 10x? This can easily knock down your accuracy by >5%.
to my knowledge, accuracy:

around 89% for Vanilla NN , CNN's and Logistic Regression (see below)

https://gist.github.com/prinsherbert/92313f15fc814d6eed1e36ab4df1f92d

https://github.com/ShankulShukla/Sentiment-analysis


[SQL] Infer row types

Created InferredSqlRowTypeCoder to wrap the original element coder and logic to convert it to Rows. Plugged it into Beam SQL's QueryTransform

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand:

[ ] What the pull request does
[ ] Why it does it
[ ] How it does it
[ ] Why this approach

[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

R: @reuvenlax @kennknowles take a look if something like this aligns with schema-aware PCollections

rebased, added tests

moved to core, converted to @AutoValue, made it Serializable

run java gradle precommit

run java gradle precommit

Sorry for the delay. Can your rebase?

@kennknowles  rebased on top of Schemas

There's some remaining renames of RowType to Schema, but not related to this PR. Pretty good to go IMO.

Reviewed 11 of 11 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

sdks/java/core/src/main/java/org/apache/beam/sdk/values/reflect/RowFactory.java, line 85 at r1 (raw file):

  }

  public <T> Schema getRowType(Class<T> elementType) {

getSchema?

Comments from Reviewable


@diogoab @r0oth3x49  Udemy Says : 400 Bad Request ['Oops, something went wrong.muc2'] ...

@diogoab @r0oth3x49  I am getting the same error

Originally posted by @danielotieno in https://github.com/r0oth3x49/udemy-dl/issues/303#issuecomment-473458906

I am getting the same error . I took the pull now and still the same error .

Use cookie to login : https://github.com/r0oth3x49/udemy-dl/issues/341