"Open in Folder" after table export goes to wrong location

Storage Explorer Version
1.22.0

Regression From
unknown

Architecture
x64

Storage Explorer Build Number
20211211.10

Platform
Linux

OS Version
Ubuntu 20.04 (snap)

Bug Description
The "Open in Folder" action for a completed export activity does not open the folder containing the export file. It only opens the user's Home directory.
Steps to Reproduce

Launch Storage Explorer and open a table.
Export the table to the default location (under /home//Downloads)
Wait for the activity to complete, then click the "Open in Folder" button.

Actual Experience
File explorer window opens to /home/
Expected Experience
File explorer should open to /home/Downloads and highlight the export file.
Additional Context
This is not reproducible in a local dev build. I'm not sure if this reproduces for a released .tar.gz.

This issue doesn't reproduce for a released .tar.gz.
Here is the record:

Our snap appears to have all the right connections to the necessary slots. Viewing the snap from Ubuntu's Software app, it even says Storage Explorer has permissions to access"file's in your home folder". Unless I'm misunderstanding something, this may be an external issue.
I've opened https://github.com/electron/electron/issues/33804 for tracking.


Fix gt output

This is what I'm seeing on line 194 + 195 of 03_Restructuring-Data.Rmd slide:

Shows up later in this section as well

Shows up later in this section as well

Actually, this is showing up throughout the slides for me.

Actually, this is showing up throughout the slides for me.

these gt objects are what I see when I knit

Im on xaringan 0.18.1 but will look into this asap

these gt objects are what I see when I knit

Im on xaringan 0.18.1 but will look into this asap

Super weird. I just updated xaringan to 0.19 but still have this issue. FWIW it works for me on the pizza_orders slide in the common issues section, but nowhere else.

Super weird. I just updated xaringan to 0.19 but still have this issue. FWIW it works for me on the pizza_orders slide in the common issues section, but nowhere else.

sorted, this recent comment on a xaringan issue explains the problem
https://github.com/yihui/xaringan/issues/293#issuecomment-761973964

sorted, this recent comment on a xaringan issue explains the problem
https://github.com/yihui/xaringan/issues/293#issuecomment-761973964


Refactor user access and sources API requests

Refactor API requests to ensure user access and sources are fetched prior to rendering each page. This will help to ensure RBAC and source updates are reflected in the UI.
https://issues.redhat.com/browse/COST-2268

Codecov Report

Merging #2320 (4338dc3) into master (37a7c71) will decrease coverage by 0.35%.
The diff coverage is 38.00%.

@@            Coverage Diff             @@
##           master    #2320      +/-   ##
==========================================
- Coverage   70.01%   69.66%   -0.36%
==========================================
  Files         402      404       +2
  Lines        7597     7670      +73
  Branches     1659     1677      +18
==========================================
+ Hits         5319     5343      +24
- Misses       2249     2287      +38
- Partials       29       40      +11

Impacted Files
Coverage Δ

src/components/accountSettings/accountSettings.tsx
35.48% <0.00%> (+0.48%)
:arrow_up:

src/components/async/asyncComponent.tsx
100.00% <ø> (ø)

src/components/currency/currency.tsx
31.91% <ø> (ø)

...odels/createCostModelWizard/generalInformation.tsx
55.55% <ø> (ø)

...rc/store/accountSettings/accountSettingsReducer.ts
90.00% <25.00%> (-10.00%)
:arrow_down:

src/store/metrics/reducer.ts
84.21% <25.00%> (-15.79%)
:arrow_down:

src/store/priceList/reducer.ts
84.21% <25.00%> (-15.79%)
:arrow_down:

src/store/providers/providersReducer.ts
83.33% <25.00%> (-16.67%)
:arrow_down:

src/store/rbac/reducer.ts
84.21% <25.00%> (-15.79%)
:arrow_down:

src/store/sourceSettings/reducer.ts
85.71% <25.00%> (-14.29%)
:arrow_down:

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37a7c71...4338dc3. Read the comment docs.


Added a new section with links to various Coding Sites

Thank you for adding those sites! 💪

happy to help on this 👍


Show playlist for Sonarr

There is a piece of software called sonarr_youtubedl that allows for automated download of series. But it does require that one specifies the playlist of the show. Is anyone familiar if shows on CBS and CW, for instance, if there is a way to get the playlist of the shows? Thank you in advance.

I suppose you mean https://github.com/whatdaybob/sonarr_youtubedl?
From the blurb it appears that this is just yt-dl in a Docker container suitable for linking into the Sonarr application.
Neither the CBS nor the CWTV extractor supports playlists, although apparently the latter at least has playlist pages on its geo-blocked site.
So no.
If someone who cares wishes to analyse the respective sites and propose pull requests for playlist support, the answer might change.

I suppose you mean https://github.com/whatdaybob/sonarr_youtubedl?
From the blurb it appears that this is just yt-dl in a Docker container suitable for linking into the Sonarr application.
Neither the CBS nor the CWTV extractor supports playlists, although apparently the latter at least has playlist pages on its geo-blocked site.
So no.
If someone who cares wishes to analyse the respective sites and propose pull requests for playlist support, the answer might change.

Yes, that is precisely the container. I tried looking for a playlist somewhere on their sites but could not find one. Thank you for the quick answer.


text recognition

Hi. Do you use this method for text recognition? I want to do text recognition of image , but I don't know where to start. Do you have any good suggestions？

没有，效果不理想，可以参考百度的paddleocr(https://github.com/PaddlePaddle/PaddleOCR)或者mmocr(https://github.com/open-mmlab/mmocr)


More OpenAL fixes

Summary of the PR
Fixes various bugs in OpenAL.
What version does this PR target?
1.X
Related issues, Discord discussions, or proposals
https://discordapp.com/channels/521092042781229087/607634593201520651/699292696434573408
Further Comments

This is ready for review.


Changed installation instruction for Gentoo/Funtoo

Since neofetch is now in Gentoo's official repository, a third party repo will not be needed anymore.

Awesome news! :+1:


Unable to update from version 2.0.3 - throws 404 error for new jar fle

Ripme version: 2.0.5-29-8710220b
java version "1.8.0_381"
Operating system: Version 10.0.19045.3208

Exact URL you were trying to rip when the problem occurred:
Please include any additional information about how to reproduce the problem:

Expected Behavior
"Check for updates" should update the version I have
Actual Behavior
I get 404 error from Ripme Updater

I noticed that the URL in the updater is releases/download/2.1.4/ but the file is actually in /releases/download/2.1.5
Not sure if it helps.

updated the 2.1.4 tag to point to commit 836a7494, and used 2.1.3-15-1b83dc68 for the previous.


Scale OOBE window

Summary of the Pull Request
What is this about:
What is included in the PR:
How does someone test / validate:
Quality Checklist

[ ] Linked issue: #xxx
[ ] Communication: I've discussed this with core contributors in the issue.
[ ] Tests: Added/updated and all pass
[ ] Installer: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Docs: Added/ updated
[ ] Binaries: Any new files are added to WXS / YML

[ ] No new binaries
[ ] YML for signing for new binaries
[ ] WXS for installer for new binaries

Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.

I see "manual" declaring for width and height, but I had the idea that (with the right code) dpi was more automated? What happens if dpi changes while oobe is open?

 All CLA requirements met.

Why did the bot activate here?

 All CLA requirements met.

Why did the bot activate here?

I had to sign the agreement again, for some reason. My signature might've expired or some terms changed, perhaps.


Unable to get camera URL with 2023.8.2

Unsure whether this is a problem with my setup, but it looks like HomeAssistant is no longer returning the camera URL via the supervisor API:
core/info returns fine:
curl -fsSL -H "Authorization: Bearer ${SUPERVISOR_TOKEN}" "http://supervisor/core/info"
{"result": "ok", "data": {"version": "2023.8.2", "version_latest": "2023.8.2", "update_available": false, "machine": "qemux86-64", "ip_address": "<IP_ADDRESS>", "arch": "amd64", "image": "ghcr.io/home-assistant/qemux86-64-homeassistant", "boot": true, "port": 8123, "ssl": false, "watchdog": true, "audio_input": null, "audio_output": null}}

Any core/api calls return with 401:
[core-ssh config]$ curl -fsSL -H "Authorization: Bearer ${SUPERVISOR_TOKEN}" "http://supervisor/core/api/camera_stream_source/camera.front_door_doorbell"
curl: (22) The requested URL returned error: 401

It's working for me as of now, with latest Home Assistant:

Maybe your token isn't working for some reason. Can you try rebooting your host? Also, try using a long-lived access token instead of the supervisor token, as well as the HA URL instead of the supervisor proxy.

Closing by lack of response.


⚠ Bofrost.be has degraded performance

In eb796fd, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1179 ms

Resolved: Bofrost.be performance has improved in 7ddca64 after 13 minutes.


Missing binding /myproject/node_modules/node-sass/vendor/linux-x64-57/binding.node while build

Hi ,
I'm getting following error while build my project. Actually error says "Missing binding /myproject/node_modules/node-sass/vendor/linux-x64-57/binding.node", but i have "/myproject/node_modules/node-sass/vendor/linux-x64-48/binding.node". I don't know Why it is not refering "linux-x64-48"?
Error says Run npm rebuild node-sass --force, i did so but no luck. Please help me git rid of this issue.
node version: v8.9.1
npm version: 5.5.1
node-sass version:  4.5.3
Error:
Module build failed: Error: Missing binding /myproject/node_modules/node-sass/vendor/linux-x64-57/binding.node
Node Sass could not find a binding for your current environment: Linux 64-bit with Node.js 8.x

Found bindings for the following environments:
  - Linux 64-bit with Node.js 6.x

This usually happens because your environment has changed since running `npm install`.
Run `npm rebuild node-sass --force` to build the binding for your current environment.
    at module.exports (/myproject/node_modules/node-sass/lib/binding.js:15:13)
    at Object.<anonymous> (/myproject/node_modules/node-sass/lib/index.js:14:35)
    at Module._compile (module.js:635:30)
    at Object.Module._extensions..js (module.js:646:10)
    at Module.load (module.js:554:32)
    at tryModuleLoad (module.js:497:12)
    at Function.Module._load (module.js:489:3)
    at Module.require (module.js:579:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/myproject/node_modules/sass-loader/lib/loader.js:3:14)
    at Module._compile (module.js:635:30)
    at Object.Module._extensions..js (module.js:646:10)
    at Module.load (module.js:554:32)
    at tryModuleLoad (module.js:497:12)
    at Function.Module._load (module.js:489:3)
    at Module.require (module.js:579:17)
 @ ./node_modules/vue-style-loader!./node_modules/css-loader!./node_modules/vue-loader/lib/style-compiler?{"vue":true,"id":"data-v-6ef6ca5e","scoped":true,"hasInlineConfig":false}!./node_modules/sass-loader/lib/loader.js!./node_modules/vue-loader/lib/selector.js?type=styles&index=0&bustCache!./src/components/MyProfile.vue 4:14-346 13:3-17:5 14:22-354
 @ ./src/components/UserProfile.vue
 @ ./src/router.js
 @ ./src/main.js
 @ multi ./build/dev-client ./src/main.js

ERROR in ./node_modules/css-loader!./node_modules/sass-loader/lib/loader.js!./src/assets/scss/main.scss
Module build failed: Error: Missing binding /myproject/node_modules/node-sass/vendor/linux-x64-57/binding.node
Node Sass could not find a binding for your current environment: Linux 64-bit with Node.js 8.x

Found bindings for the following environments:
  - Linux 64-bit with Node.js 6.x```

Looks like you upgraded node to version 8 but didn't delete your
node_modules folder.
On 21 Nov. 2017 5:45 pm, "Thavaprakash"<EMAIL_ADDRESS>wrote:

Hi ,
I'm getting following error while build my project. Actually error says
"Missing binding /myproject/node_modules/node-sass/vendor/linux-x64-57/binding.node",
but i have "Missing binding /myproject/node_modules/node-
sass/vendor/linux-x64-48/binding.node". I don't know Why it is not
refering "linux-x64-48"?
Error says Run npm rebuild node-sass --force, i did so but no luck.
Please help me git rid of this issue.
node version: v8.9.1
npm version: 5.5.1
node-sass version:
Error:
`ERROR in ./node_modules/css-loader!./node_modules/vue-loader/lib/
style-compiler?{"vue":true,"id":"data-v-6ef6ca5e","scoped"
:true,"hasInlineConfig":false}!./node_modules/sass-loader/
lib/loader.js!./node_modules/vue-loader/lib/selector.js?
type=styles&index=0&bustCache!./src/components/UserProfile.vue
Module build failed: Error: Missing binding /myproject/node_modules/node-
sass/vendor/linux-x64-57/binding.node
Node Sass could not find a binding for your current environment: Linux
64-bit with Node.js 8.x
Found bindings for the following environments:

Linux 64-bit with Node.js 6.x

This usually happens because your environment has changed since running npm
install.
Run npm rebuild node-sass --force to build the binding for your current
environment.
at module.exports (/myproject/node_modules/node-sass/lib/binding.js:15:13)
at Object. (/myproject/node_modules/node-sass/lib/index.js:14:35)
at Module._compile (module.js:635:30)
at Object.Module._extensions..js (module.js:646:10)
at Module.load (module.js:554:32)
at tryModuleLoad (module.js:497:12)
at Function.Module._load (module.js:489:3)
at Module.require (module.js:579:17)
at require (internal/module.js:11:18)
at Object. (/myproject/node_modules/sass-loader/lib/loader.js:3:14)
at Module._compile (module.js:635:30)
at Object.Module._extensions..js (module.js:646:10)
at Module.load (module.js:554:32)
at tryModuleLoad (module.js:497:12)
at Function.Module._load (module.js:489:3)
at Module.require (module.js:579:17)
@ ./node_modules/vue-style-loader!./node_modules/css-
loader!./node_modules/vue-loader/lib/style-compiler?{"
vue":true,"id":"data-v-6ef6ca5e","scoped":true,"hasInlineConfig":false}!./
node_modules/sass-loader/lib/loader.js!./node_modules/vue-
loader/lib/selector.js?type=styles&index=0&bustCache!./src/components/MyProfile.vue
4:14-346 13:3-17:5 14:22-354
@ ./src/components/UserProfile.vue
@ ./src/router.js
@ ./src/main.js
@ multi ./build/dev-client ./src/main.js
ERROR in ./node_modules/css-loader!./node_modules/sass-loader/lib/
loader.js!./src/assets/scss/main.scss
Module build failed: Error: Missing binding /myproject/node_modules/node-
sass/vendor/linux-x64-57/binding.node
Node Sass could not find a binding for your current environment: Linux
64-bit with Node.js 8.x
Found bindings for the following environments:

Linux 64-bit with Node.js 6.x`

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/sass/node-sass/issues/2162, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAjZWLZvbOsA-AkiJFEqiAkQu_TOnBc1ks5s4nGOgaJpZM4QlW7q
.

Hi @xzyfer,
I have deleted node_modules, then i run npm install(node modules got reinstalled successfully). However I'm getting same error while run npm run build.

npm rebuild node-sass worked well for me. Thanks @xzyfer. You can close this issue.

Uncaught Error: Module build failed: ModuleBuildError: Module build failed: Error: Missing binding /project/node_modules/node-sass/vendor/darwin-x64-57/binding.node
Node Sass could not find a binding for your current environment: OS X 64-bit with Node.js 8.x
Found bindings for the following environments:

OS X 64-bit with Node.js 7.x

Having same issue as described above for macOS 10.12.6.
nodejs 9.0
npm 5.8.0
nvm 7.0
tried:
npm uninstall node-sass
npm install node-sass
nvm version 7.0
nvm version 8.0
npm rebuild node-sass
Tried multiple node-sass 4.x.x versions no luck.
Please help

@goufang please the comments above. You error message tells you what's going on and how to resolve it.

Node Sass could not find a binding for your current environment: OS X 64-bit with Node.js 8.x

You're using Node 8.

OS X 64-bit with Node.js 7.x

But you ran npm install with Node 7.

This usually happens because your environment has changed since running npm install.
Run npm rebuild node-sass --force to build the binding for your current environment.

@xzyfer try running your windows power shell as administrator. And re-run npm rebuild node-sass --force


Fix zoom in callback for CanvasItemEditor to use correct numeric sign

In commit 74bfe88267, the zoom handling code moved, but only the mouse wheel down part was transferred (original -> moved).  As a result mouse wheel up behaved improperly, not exactly reversing the effect of a mouse wheel down of equal amount.
This commit checks the sign of the vertical mouse wheel amount and uses +1 or -1 accordingly, and checks the absolute value to decide if the more precise adjustment is needed or not.
To reproduce before this commit:

open the editor
switch to 2D view
click the zoom amount in the top left to reset to 100%
mouse wheel down once to zoom out to the first level less than 100% (89.1% for me)
mouse wheel up once to try to zoom back to 100%
note that the zoom is not 100% (99.1% for me)
repeat steps 3-6 with larger mouse wheel changes to see greater error

Thanks!


Expose String.http_escape and String.http_unescape

Expose http_escape and http_unescape to script bindings.
The name of these functions might be ambiguous. How about rename to uri_encode and uri_decode

+1 for uri_encode / uri_decode

Since those methods are bound in GDNative already as http_escape/http_unescape, I guess we should probably keep their current name for now for compatibility.
But they could be renamed in 4.0, you can add a mention to them in #16863.

Thanks!


Ookla download

This would be better if it accepted a date range - e.g.
start = pd.to_datetime('2019-01-01')
end = pd.to_datetime('2022-08-01')
speeds = ookla.get_ookla_data(start,end)
(Resulting dataframe would be a single aggregated dataframe of all the Ookla parquet files inside the date range, aggregated by mean(up/down), sum(total_devices) )


[Feature Request]: Snake Game is Not working at all .

Is there an existing issue for this?
And Its Not Snake Game when user clicks he want to feel that nostalgia of snake scoring points

[X] I have searched the existing issues

Feature Description
Currently Snake Game is Not Working I want to Fix That:
https://apu52.github.io/METAVERSE/Projects/Snakes_Game/
Use Case
It will Enhance User Experience
Benefits
No response
Add ScreenShots

Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I'm a SSOC'24 contributor
[X] I have starred the repository

hey @apu52  can i work on this.

@nishant0708 u are contributing under GSSOC right??

@apu52 yes


Basic layout 4: Grid Layout

bron: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_grid_layout


Speed up CI builds by caching development dependencies

[will provide more info if this works]

Coverage remained the same at 99.582% when pulling c97fe563242fcc2eecc3450c8ac259482acd81ab on Siilwyn:speed-up-ci into b8685a13e8a194af3ee0ad0f0a76d8cbadf0d86f on ben-eb:master.

Coverage remained the same at 99.582% when pulling 0875a398a622f0fc282d5e51f4ae4d962d829d74 on Siilwyn:speed-up-ci into b8685a13e8a194af3ee0ad0f0a76d8cbadf0d86f on ben-eb:master.

Coverage remained the same at 99.582% when pulling 0875a398a622f0fc282d5e51f4ae4d962d829d74 on Siilwyn:speed-up-ci into b8685a13e8a194af3ee0ad0f0a76d8cbadf0d86f on ben-eb:master.

Coverage remained the same at 99.582% when pulling 3a26e64ce96182a9b3218de43eda00fd4b49370e on Siilwyn:speed-up-ci into b8685a13e8a194af3ee0ad0f0a76d8cbadf0d86f on ben-eb:master.

Coverage remained the same at 99.582% when pulling 9febd80c9d40a23bd283a362bc8a8cc72873a0a0 on Siilwyn:speed-up-ci into b8685a13e8a194af3ee0ad0f0a76d8cbadf0d86f on ben-eb:master.

Thanks, looks great! 👍

Any ideas why this is now failing? 😄
https://travis-ci.org/ben-eb/cssnano/jobs/254631764

:0 that is weird, let's try to debug it.


my two cents to awesome-ee-spectral-indices

Hey @davemlz nice work in awesome-ee-spectral-indices :+1: . I just restructured the repo and made some small changes :rocket: .

Two cents? This is like 1000 EUROS! Thank you, @csaybar!


Homebrew Cask install for macOS

It would be fantastic if Championify could be installed through cask. I'm not quite sure how hard it would be to set up and keep up to date, but it would be much appreciated!

It's not terribly hard. It's just a ruby script in the Cask github repo and remembering to update it. I'll keep it in mind. :)

I might give it a try this week.

Hi,
I just submitted a pull request on cask repo to add championify. See HERE.

@dustinblackman The pull request has been accepted from homebrew cask. I think the issue can now be closed :-)

Thanks!

@julian-poidevin Fantastic, thanks a lot!

Keeping Casks up to date is super easy.
Check out cask-repair (details in CONTRIBUTING). ie. to update to the latest version, you could use cask-repair -v 2.0.1 championify. You could even make it part of your release process.
(I'm a Homebrew Cask maintainer)

@adidala That's fantastic, I didn't know about that. Going to reopen and add it to my release tasks.


release v1.1

Closing in favour of https://github.com/containers/podman-desktop-extension-ai-lab/issues/1030


Add the name of the community in the title of the page for better bookmarking

Would be nice to show "OAK Wallet"  instead of "Citizen Wallet"

14cec9be407216a4fc40c485d998ad99cd3fddb0 done
"add to Homescreen" functionality uses the PWA manifest.json which is compiled as a single file. We would need to generate a different one and serve it for that specific community to get it to work there

Also updated the title on the page itself to use the one from the community.


chore(dependencies): Update actions/cache action to v3.3.2

This PR contains the following updates:

Package
Type
Update
Change

actions/cache
action
patch
v3.3.1 -> v3.3.2

Release Notes

actions/cache
v3.3.2
Compare Source
What's Changed

Fixed readme with new segment timeout values by @kotewar in https://github.com/actions/cache/pull/1133
Readme fixes by @kotewar in https://github.com/actions/cache/pull/1134
Updated description of the lookup-only input for main action by @kotewar in https://github.com/actions/cache/pull/1130
Change two new actions mention as quoted text by @bishal-pdMSFT in https://github.com/actions/cache/pull/1131
Update Cross-OS Caching tips by @pdotl in https://github.com/actions/cache/pull/1122
Bazel example (Take #2⃣) by @vorburger in https://github.com/actions/cache/pull/1132
Remove actions to add new PRs and issues to a project board by @jorendorff in https://github.com/actions/cache/pull/1187
Consume latest toolkit and fix dangling promise bug by @chkimes in https://github.com/actions/cache/pull/1217
Bump action version to 3.3.2 by @bethanyj28 in https://github.com/actions/cache/pull/1236

New Contributors

@vorburger made their first contribution in https://github.com/actions/cache/pull/1132
@jorendorff made their first contribution in https://github.com/actions/cache/pull/1187
@chkimes made their first contribution in https://github.com/actions/cache/pull/1217
@bethanyj28 made their first contribution in https://github.com/actions/cache/pull/1236

Full Changelog: https://github.com/actions/cache/compare/v3...v3.3.2

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.1.9 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


API Add some convenience method for recording call to extend on Extensible trait

Occasionally, I want to write unit tests that confirms that some extensions hooks have been called on a class that uses the Extensible traits. Right now, I would normally create a dummy extension that implement the methods I want to test and apply it to my targeted object during my unit test.
I wondering it it wouldn't be better to make it part of the actual Extensible API.
My idea would be to have a method call enableRecordExtendCalls on Extensible that would trigger extend to start recording all its calls. Then your unit test could call extendCallsFor to retrieve the list of extend calls and run some assertions on that.
This would remove the need to have dummy extension like this one: https://github.com/silverstripe/silverstripe-admin/blob/1/tests/php/ModelAdminTest/ModelAdminExtension.php
If people think this could be helpful I can write some extra unit test for it.

Isn’t this what mock objects/->expects() are typically used for?

Would that work with mocking extension methods? I guess I could mock the extend method on the main object if mocking the extension method is not possible.

I don't think we should be adding this kind of test code to classes. Mocks should be more than capable of recording calls to extends methods...

Would that work with mocking extension methods? I guess I could mock the extend method on the main object if mocking the extension method is not possible.

I was thinking more that you could create a mock of the extension itself, and then apply that mock extension with ::add_extension($mock) (and maybe remove the original with ::remove_extension())

Yeah, I've done that before, there's definitely a bit of help that could be given by SS to add mock extensions, but it's possible.

I am in complete agreement with @dhensby's statement:

I don't think we should be adding this kind of test code to classes.

We can provide test API for make asserting extensions easier - but we shouldn't be adding code for testing our non-test classes.
In my head, the perfect way for this to work would be to have some class that encapsulates calling extension methods rather than a trait - although a trait could be provided to make it easier to consume this class. Then you could have a "test version" of that class with API like what's proposed here, that leverages DI to be used in test runs.

Thanks everyone. That's very useful feedback. I'll go back to drawing board.


Converting product page to graphql

BREAKING: Chloe realized in writing this PR that since the data handling is happening in <manifold-product> the graphql should probably be there as well, of course! So I guess converting the product-page means converting the other components that are connected to it/wrapping it first..does that seem true? I want to post this for review just so people can give me feedback on my attempt though, and I'll see if doing it in the product component makes more sense. :)
Reason for change
Adding a graphql query and new fetch statement to the <manifold-product-page>. Got a little confused on how to know where the variables for the query are coming from, unrelated to graphql but just as far as data handling goes (I assume it should get passed in as a prop?).
Testing
Storybook renders the product-page inside of product which uses fetch and catalog to pass data to the product-page, so testing there isn't accurate to this component. Might mean we need a new story, or to add graphql to product, or might very well mean I misunderstood how the data in this component was supposed to work.

Is this still WIP @batgirl?

@batgirl what’s the status on this? I have availability to help with this if needed. It’d be good to get this in this week!

@dangodev this was on hold while we finished more pressing Render priorities. But now I should be free to finish it up! It can definitely be finished early this week!

Based on feedback we’ve gotten around our graphql endpoint being slow, I’m going to close this WIP PR (but I’ll keep the branch for future reference). Basically it’ll be a while before we can merge this, and in that time this will become further diverged from the codebase.


test-utils component specs throw on undefined document element

Hi there. In general, I'm a huge fan of this Flux implementation, and absolutely LOVE the test-utils module. (By far the most elegant attempt at testing React apps that I've seen -- and I've been shopping around!).
There's only one problem: while I can get working tests for actions, stores, etc... My component tests are irreparably and inscrutably broken. I'm 99% confident the bug reduces to a failure to initialize the DOM document element, but am clueless as to why this is happening or how to fix the bug.
I hewed as closely as possible to the settings in the example tests project (specifically, this test when setting it up, but am stuck with a wall of inscrutable error messages and little room to test debugging hypotheses.
Hoping someone can help me out of the mire and that it might help point the way to a bug fix. Also happy to work on documenting how to avoid the problem for those who come after!
Here is the test in question (which places this component under test):
const sinon = require('sinon');
const chai = require('chai');
const sinonChai = require('sinon-chai');
chai.use(sinonChai);
const should = chai.should();
const React = require('react');
const Application = require('../../src/application');
const { RED, GREEN } = require('../../src/constants/Colors');
const { createStore, createApplication } = require('marty/test-utils');
const testTree = require('react-test-tree');

const GoButton = require('../../src/components/GoButton');

describe('GoButton Component', () => {

  const setup = (spy) => {
    const app = createApplication(Application, {
      stub: {
        goButtonStore: createStore({
          getColor: spy
        })
      }
    });
    return [app, spy];
  };

  describe('GoButton Component', () => {

    it('contains a tappable svg circle', () => {
      const spy = sinon.spy();
      const app = setup(spy)[0];
      const gb = testTree(<GoButton color={RED} />, { context: { app: app }});

      gb.svg.getAttribute('width').should.equal(220);
      gb.svg.getAttribute('height').should.equal(220);
      gb.circle.getAttribute('cx').should.equal(110);
      gb.circle.getAttribute('cy').should.equal(110);
      gb.circle.getAttribute('r').should.equal(110);
      gb.circle.getAttribute('fill').should.equal(RED);
    });
  });

});

When I run it using mocha like this:
mocha --recursive --compilers js:babel/register

I get the following error:
  1) GoButton Component Inner Component contains a tappable svg circle:
     ReferenceError: document is not defined
     at Context.<anonymous> (test/components/GoButton.spec.js:33:18)

When I run it using karma (see below for karma.config.js) I get the following error:
Chrome 44.0.2403 (Mac OS X 10.10.1) ERROR
  Uncaught Error: Invariant Violation: _registerComponent(...): Target container is not a DO
M element.
  at /var/folders/dl/vfr2j80d2dj47w4df8q4tz4r0000gp/T/2b96c2f769fa819a8f6003dfa1972fc3.brows
erify:41527:0 <- node_modules/react/lib/invariant.js:50:0

Googling around for that React error message a bit, it turns out you usually get it when the document element isn't defined. Chasing the error through the debugger in karma a bit, I wound up at this line in react-test-tree (namely: testTree.js:14) before execution terminated:
  var container = document.createElement('div');

This echoed the error message when running from mocha and confirmed the hypothesis that the bug is independent of testing framework. Sadly, it still leaves me at a complete loss as to how to get my test working.
Happy to do more debugging and try to turn up more useful error logs if you'll point the way. REALLY can't emphasize enough how much I love this kit and very much want to use it and get other people to use it.
Can you help?
PS: In case it's useful, here are some reference files:

this is a link to my repo as it stood at the commit with the bug

this is my package.json:

{
  "name": "whereat-web",
  "version": "1.0.0",
  "description": "location sharing app for activists",
  "engines": {
    "node": "0.12.x",
    "npm": "2.11.x"
  },
  "main": "main.jsx",
  "scripts": {
    "dev": "npm run dev-serve | npm run dev-build",
    "dev-build": "webpack-dev-server --devtool eval --progress --colors --hot --content-base build --port 8090 --config webpack_dev_config",
    "dev-serve": "http-server -p 8080 ./build/dev",
    "prod-build": "NODE_ENV=production webpack -p --config webpack_prod_config.js",
    "test": "karma start",
    "test-mocha": "mocha --recursive --compilers js:babel/registert",
    "test-debug": "node-inspector --web-port=9000 & mocha --recursive --compilers js:babel/register --debug-brk"
  },
  "repository": {
    "type": "git",
    "url": "git@github.com:the-learning-collective/whereat-web.git"
  },
  "keywords": [
    "mobile",
    "web",
    "location",
    "socialJustice"
  ],
  "author": "@aguestuser",
  "license": "GPL-3.0",
  "bugs": {
    "url": "https://github.com/the-learning-collective/whereat-web/issues"
  },
  "homepage": "https://github.com/the-learning-collective/whereat-web",
  "dependencies": {
    "babel": "^5.6.23",
    "babel-core": "^5.4.7",
    "babel-loader": "^5.1.3",
    "babel-runtime": "^5.7.0",
    "bulk-require": "^0.2.1",
    "classnames": "^2.1.2",
    "css-loader": "^0.13.1",
    "expose-loader": "^0.7.0",
    "file-loader": "^0.8.3",
    "html-webpack-plugin": "^1.4.0",
    "image-webpack-loader": "^1.4.0",
    "imagemin": "^3.2.0",
    "immutable": "^3.7.3",
    "imports-loader": "^0.6.3",
    "jsx-loader": "^0.13.2",
    "less": "^2.5.1",
    "less-loader": "^2.2.0",
    "lodash": "^3.9.1",
    "marty": "^0.10.1",
    "node-libs-browser": "^0.5.0",
    "node-sass": "^3.1.2",
    "node-uuid": "^1.4.3",
    "postcss-loader": "^0.5.1",
    "react": "^0.13.3",
    "react-bootstrap": "^0.22.6",
    "react-hot-loader": "^1.2.7",
    "react-tappable": "^0.5.7",
    "react-tools": "^0.13.3",
    "style-loader": "^0.12.2",
    "superagent": "^1.2.0",
    "url-loader": "^0.5.5",
    "webpack": "^1.9.10",
    "webpack-dev-server": "^1.8.2",
    "xml-loader": "^1.0.0"
  },
  "devDependencies": {
    "babelify": "^6.1.3",
    "bulkify": "^1.1.1",
    "chai": "^2.3.0",
    "chai-as-promised": "^5.0.0",
    "jsx-require-extension": "^0.2.0",
    "karma": "^0.13.3",
    "karma-browserify": "^4.2.1",
    "karma-chrome-launcher": "^0.2.0",
    "karma-cli": "^0.1.0",
    "karma-mocha": "^0.2.0",
    "karma-spec-reporter": "0.0.20",
    "lessify": "^1.0.1",
    "mocha": "^2.2.5",
    "mocha-babel": "^3.0.0",
    "react-test-tree": "^0.2.2",
    "sinon": "^1.15.4",
    "sinon-chai": "^2.8.0"
  },
  "browserify": {
    "transform": [
      "babelify",
      "lessify",
      "bulkify"
    ]
  }
}

and this is my karma.conf.js:

module.exports = function(config) {
  config.set({
    basePath: '',
    frameworks: ['mocha', 'browserify'],
    files: [
      //'test/setup.js',
      'src/**/*.js',
      'src/**/*.jsx'
    ],
    preprocessors: {
      'test/setup.js': ['browserify'],
      'src/**/*.js': ['browserify'],
      'src/**/*.jsx': ['browserify']
    },
    browserify: {
      bare: true,
      debug: true
    },
    reporters: ['spec'],
    port: 9876,
    colors: true,
    logLevel: config.LOG_DEBUG,
    autoWatch: true,
    browsers: ['Chrome'],
    singleRun: false
  });
};

ps: it's perhaps worth adding that this is the line that the tests throw on:
const gb = testTree(<GoButton color={RED} />, { context: { app: app }});

PS: if it would be more helpful to move this to the react-test-tree issues page, please let me know, and I'd be happy to do that! :smile:

So... happy to report, I solved my own problem. Still at a complete and total loss as to how to get this to work with karma. But the good news is you don't need to!
If any other hapless Googler stumbles on this sometime in the future, you can ditch the entire karma approach and run the marty test-utils and their dependency on react-test-tree completely within mocha, provided you use the jsdom npm package and export it properly into the global.window object along the lines of this excellent post.
With one caveat, you need to put React into global scope for react-test-tree to pickup. That's easily accomplished by modifying the code for dom.js required in mocha.opt from what's provided in the post to the following:
var jsdom = require('jsdom');
var React = require('react');

var doc = jsdom.jsdom('<!doctype html>');
var win = doc.defaultView;
global.document = doc;
global.window = win;
propagateToGlobal(win);

// from mocha-jsdom https://github.com/rstacruz/mocha-jsdom/blob/master/index.js#L80
function propagateToGlobal (window) {
  for (let key in window) {
    if (!window.hasOwnProperty(key)) continue;
    if (key in global) continue;

    global[key] = window[key];
  }
  global.React = React;
}

for my part: this is the commit that fixed it and this is the passing test. huzzah! and hopefully this helps somebody else down the line.
:heart:
:octopus:

You're doing something very odd. You should try to get a basic test up and running in Karma and Chrome first - I don't have time to pull your repo right now, but it looks like it'd be a Karma config issue, since that code should be running in the browser, where document is set.
That environment check is not due to the React.render call - it's to avoid doing the other setup in that block, which is not relevant in the context of a test.

thanks for taking a look, @taion! i realize this is a super hacky fix (and very unseemly to be tossing values into the global namespace like that!), BUT... I lost maybe 8 hours yesterday trying to get the karma setup to work, whereas this fix worked right away and is got me back to focusing on what i needed to be focusing on: writing passing tests and closing tickets -- which is what i care about, particularly since i'm on production deadline. (the "it just works" metric is a pretty powerful one in that context!)
if i were to try to dig pack into the karma battle, i'd probably start by trying to use webpack instead of browserify for the compile step. however, i'm very nervous doing that, since the only docs i have to go off of are john's example tests, and i had such a doozy of a time trying to get them to work copying his config (karma.conf.js and package.json) nearly verbatim.
to my (very humble and very appreciative that this framework even exists in the first place!) eye, it seems like this is a good example of a corner case that could use a bit more directly and carefully addressed in the examples and/or docs. if i'm able to figure it out (help appreciated!), i'd gladly contribute a PR to the docs to help other people like me figure this out first time around.
i think it's REALLY important!
so many highly skilled, thoughtful react developers i know blow right through and never write tests because the toolchain is uncommonly complex and its so easy to visually confirm changes with hot-loader, etc... this toolkit is a SHINING example of a team that's figured out how to make testing really frictionless, recovering the sort of ease that will encourage people to actually be disciplined in their testing practices. it's a huge selling point IMHO to distinguish marty from other flux impls, and -- if documented properly -- could go a long way toward counteracting a trend i've observed (at least anecdotally) of undertesting react code.
for all those reasons, i think it's a great contribution to the ecosystem, and i'd love to help in any way i can to make the test kit as well documented and accessible as possible.
in the meantime, i'll mull over your suggestion that i risk another lost day to figure out karma. (the advantages of testing in an actual browser env and cross-testing across multiple browsers aren't lost on me.) most importantly: thanks for responding! i know we're all busy and it can be really hard to give attention to stuff like this on OSS projects, and it always means a lot to me whenever people do. :)

You can verify pretty easily in a basic Karma setup that you have access to document from your tests. I really can't speak to what specifically is happening in your case, but it does seem like an issue with your testing environment.

Right, but I don't actually think it's an issue with access to document.  That was the problem with the pure mocha strategy (solved with jsdom, which provides a document object, which I injected into the global namespace.) The whole problem I've hit with the Karma stack is that I first got (1) the invariant error message, then (2) an error with no message at all(!!!). With nothing else to go on, it seems like an inadvisable direction to point my energies... Perhaps a pointer on how to dig into the call stack would be a good starting place? A suggestion on where to insert a debug point? Will work on it on my own and try to come back with more helpful breadcrumbs, but that's the main thrust of my reluctance: no bread crumbs to chase! An intelligent debugger's nightmare! ;)

PS, out of pure curiosity, @taion: why do you think the jsdom approach is not worth pursuing? Granted it's hacky, and as you say "very odd." But one could say that the very idea of the virtual DOM itself is "very odd," (insofar as it is roundabout) and because of that initially came under attack by people who said it could never be performant (since proved wrong). And without the "very odd" virtual DOM, we would have neither React nor Marty.
Isn't jsdom essentially just doing a similar trick of abstracting over the DOM so we can get some benefits we want (in this case faster/simpler testing)?  Is there perhaps a reason why it's a fairly popular alternative to Karma among at least some folks who know their testing?
Given all that, I wonder: why -- in objective technical terms (correctness, performance, maintainability, etc...) -- do you think it's a bad approach to testing? Not sure I see the drawbacks... And want to make sure that other people who might find themselves in a hard place like I did and might stumble on this thread in their efforts to fix things aren't needlessly steered away from a solution that might help them.
Also completely willing to change my mind! :) (And reading up on karma with webpack with that express possibility in mind.)

The point of your tests is to ensure that your code works. What does "works" mean for client-side front-end code? It means that it runs on your users' browsers.
When you use Karma with an actual browser, you're running the tests in the browser, and picking up any bugs that might happen there. That's essentially the point of Karma - if all you want is jsdom, then you don't need anything beyond just Mocha.
But generally if you're testing anything on the DOM, then you'd want to make sure your code works in browsers, with all of their quirks.

fair enough. i'm (almost 100%) sold. solid argument from correctness. sure i can ensure my logic is correct on the DOM with jsdom, but if i'm concerned with correctness in the environment in which my program will actually be run (and why wouldn't i be?), then i probably want a test bracket big enough to cover browsers. (unless i'd rather find out post-release that some small part of the code doesn't work on IE-blah-blah... which i don't!) will dig into trying to get a webpack/karma config setup and document any gotchas or workarounds here. thanks again for engaging. :D


[OSPRH-12359] Fix getting IPSets

Turns out IPSets use the node's hostname as defined in the nodeset CR, not the node's name. These 2 might be the same, but they might differ and in case they differ, the controller doesn't find them and it uses the ansible inventory secret to get the IPs instead.
Unfortunatelly the hostname from the nodeset isn't always copied into the ansible inventory secret. It either gets copied into the canonical_hostname variable as is or a DNS domain is appended to it, so I introduced a bit of code to pick the correct parts of the canonical_hostname.
This worked for both cases described above when I tested it, there is also still the fallback to using the ansibleHost from the inventory secret.

/retest

/retest

/retest

/retest

/retest


Minor: SetCursor parameter should be optional

Hey!
I found a minor annotation error, the "cursor" parameter for the API function SetCursor should be optional.
I changed line 1278 in API4.lua to (and updated the wiki page:
---@param cursor? string

🫰

Oh, thanks. Is that an explicit nil or can it just be omitted?
The extension should pick it up in the next update.

Never mind, it does have to be an explicit nil.
I just tested it again. When it was pushed to in-game testing I was actually passing nil through a variable to it so I didn't notice.
I'll revert back the wiki changes if I can (I saw you added the brackets I left out).


[Python AWS Lambda SDK] Enable performance tests

Related issue https://linear.app/serverless/issue/SC-593/python-sdk-big-latency-overhead

@medikoo ready for review please 🙏  Would be good if we can merge it after https://github.com/serverless/console/pull/584 so that it runs against the increased threshold.


fixed 0019 and 0020 on multidb setups

Fixes migration issue

Coverage remained the same at 78.215% when pulling 4e51558de814cd6eb1a8ac6ecaa28a21d32605de on pglotov:fixMigrations into 006367b6787b1ec884c1e5423a0cfc1a53305328 on divio:develop.


Don't redirect non-existing assets to index.html

Hi, this is a great tool.
One thing I think could be improved is to prevent asset files like js, css, jpg that do not exist from being redirected to index.html.
This can for example be a problem when you update your deployment, but a user has the old version open and for example navigates to a part of of the app that dynamically requires javascript. The browser will then receive index.html for the asset file which will fail, but may be also cached by the browser, so that even after a reload the user will still get a broken app.
Does that make sense?

@Narretz it makes sense. At the moment I don't know a solution to this problem. I think I have to find a way to prevent redirection after receiving 404 HTTP Code. But this should not affect the general redirection for angular routes...

Hi  @julianpoemp the way I did it in the end was this:
# If the requested resource doesn't exist, use index.html but only if it's not an asset file
RewriteCond %{REQUEST_URI} !\.(css|js|jpeg)$
RewriteRule ^(.*) /index.html [NC,L]

This obviously assumes that the routes in your angular app never end in .css, .js .jpeg which could be tricky with clean urls I guess?
Caveat is also that I did it for a toy project and don't actually know that much about htaccess rules and possible unwanted side effect.

@Narretz thanks. I experimented a little bit and found a solution. Can you try it, please?
Uncomment the line that contains index.html and add the following line:
# Redirect all non-file routes to index.html
RewriteRule ^(?!.*\.).*$ index.html [NC,L]

It worked for me.


remove redundant function call

... and definition

I think skipping the lines after md_links_header is almost always what is intended.
This makes commands such as
command! -buffer -range=% LinkConvertRange
            \ <line1>,<line2>TagLinks |
            \ <line1>,<line2>call mdlink#ConvertRange() |
            \ call MoveSignatureToEnd()

work as intended, not scrambling the links section

I think the better way is to check in ConvertRange is the range is all of the buffer, and then use the 'all' logic

Everything has been done, just replace if a:type ==# 'all' by if a:firstline = 1 && a:lastline = line('$') in the function and leave it as is otherwise.
The rest as in this PR.

That's exactly what I did at first, but I noticed that's redundant too. Just limiting l:max_line_nr to be maximum the heading line number was enough.

True, that's even less redundant, nice observation


Can I get a JSON response with the basic plug in ?

Hi,
First, thank you so much for this plug in :-)
It just work for me except one thing.... I can't get a json response from the server. With the example you give, it's ok. The upload.php return a JSON response.
But in my code, I just use the fileupload.js (not the ui version) and the script always return text/plain back. I've even force the header to json/application but still not ok.
I need to use the response because the upload.php may have to change the "just" uploaded file name. I'd like to get the definitive name in the response.
So question is : does I have to use the UI version ?
If answer is Yes, I'll face to another pb : with the UI version, I got a "c.tmpl is not a function" javascript error....
Thanks for your help, sorry for my english (french people) and above, some details.
Hope you hear me :-)
Bye
Here is the response :
[{"name":"20111105_222600_0.jpg","size":699114,"type":"image/jpeg","url":"/opt/local/apache2/htdocs/modules/photositetmp/sandBox/tmp/20111105_222600_0.jpg","thumbnail_url":"/opt/local/apache2/htdocs/modules/photositetmp/sandBox/tmp/thumbs/20111105_222600_0.jpg","delete_url":"/cgi-bin/upload_photositetmp.php?file=20111105_222600_0.jpg","delete_type":"DELETE"}]
And the header (I've force it to json) :
Date	Thu, 17 Nov 2011 16:40:03 GMT
Server	Apache/2.2.17 (Unix) mod_ssl/2.2.17 OpenSSL/1.0.0c DAV/2 PHP/5.3.5
X-Powered-By	PHP/5.3.5
Pragma	no-cache
Cache-Control	private, no-cache
Content-Disposition	inline; filename="files.json"
X-Content-Type-Options	nosniff
Vary	Accept
Content-Length	383
Keep-Alive	timeout=5, max=77
Connection	Keep-Alive
Content-Type	application/json

Set the dataType option to "json" - see here:
https://github.com/blueimp/jQuery-File-Upload/wiki/Basic-plugin

Hi,
Ok. Setting this attribute solve the response type. Now, I got json in the header without forcing it.
But... The response still not have the JSON control in the firebug console...
And I now got a js error (without dataType, no error)  : test is nul in jquery.min.js...
Here is my fileupload code :
jQuery(this).fileupload(
{ 	dataType: 'json',
	formData:[{name: 'photo_name',value: photo_name}],
	add: function (e, data) {
  		var jqXHR =	data.submit()
	            .fail(function (jqXHR, textStatus, errorThrown) {alert('Error!!! Contact LeChat ! ');}
	            .done(function (result, textStatus, jqXHR) {
						var test=jQuery.parseJSON(result);
						console.log(test.name);
						});
});

Oh ok, sorry. Now, result contains a JS object. It seems to be good !
I'll try to figure out how to manage this object (I guess your plugin already do the JSON parsing).
Thank you very very much !!!!

Ok. It definitivly resolve my issue. I'll close it.
Thanks !


[#4938]feat(lakehouse-paimon): Support S3 filesystem for Paimon catalog.

What changes were proposed in this pull request?
Add support for Paimon S3 filesystem.
Note: related documents will be added in another PR.
Why are the changes needed?
for better user experience.
Fix: #4938
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
Test locally and IT

@FANNG1
Please help to take a look again.


sed command seemed to trim a bit off the key in latest version of flux

What is this MR for?

the sed part of the command seemed to trim a bit of the key off for
me.

Thanks


Istio dual-stack support at ingress

### Kubernetes are supporting the dual-stack::
https://kubernetes.io/docs/concepts/services-networking/dual-stack/
We also need a dual-stack support for Istio ingress traffic in Kubernetes dual-stack clusters.
Currently, IPV6 or IPV4 is only supporting
Internal traffic handled by Istio is still single-stack using the K8s default family (the one you get if the ipFamily is not explicitly specified in the manifest).
[ ] Docs
[X] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[X ] Developer Infrastructure
Affected features (please put an X in all that apply)
[X] Dual Stack
Expected behavior
The stats listener should listen on both IPv4 and IPv6 in a dual-stack environment
K8s dual-stack
The service can be specified to support dual-stack traffic to the istio-ingressgateway with two IP's at LoadBalance i.e. one IPV4 and other one IPV6
apiVersion: v1
kind: Service
metadata:
name: istio-dual
namespace: istio-system
spec:
ipFamilyPolicy: PreferDualStack
ports:

name: http2
port: 80
protocol: TCP
targetPort: 8080
name: https
port: 443
protocol: TCP
targetPort: 8443
selector:
app: istio-ingressgateway
type: LoadBalancer

This is currently being worked on and will be presented to various groups soon. There is no ETA for when it will be completed. Included is a reference implementation of a working system in Istio 1.9.
config_dump.json.zip

Is there any update on the target release for Dual Stack Ingress support?

Hi @sronanrh, you can use the experimental branch here for your dual stack support. For master branch, I think you can focus on this issue: https://github.com/istio/istio/issues/40394

There is a PR#42712 for ingress gateway support got merged

close per https://github.com/istio/istio/pull/42712. Thanks!


ESP32 with samples\net\wifi gives: net_if: There is no network interface to work with!

On an ESP32 trying to run the Zephyr WiFi sample in the samples\net\wifi directory and it fails with:
I (29) boot: compile time 12:56:29
I (29) boot: chip revision: 1
I (32) boot_comm: chip revision: 1, min. bootloader chip revision: 0
I (45) boot.esp32: SPI Speed      : 40MHz
I (45) boot.esp32: SPI Mode       : DIO
I (48) boot.esp32: SPI Flash Size : 8MB
I (52) boot: Enabling RNG early entropy source...
I (58) boot: Partition Table:
I (61) boot: ## Label            Usage          Type ST Offset   Length
I (69) boot:  0 nvs              WiFi data        01 02 00002000 00006000
I (76) boot:  1 phy_init         RF data          01 01 00008000 00001000
I (84) boot:  2 factory          factory app      00 00 00010000 00100000
I (91) boot: End of partition table
I (95) boot_comm: chip revision: 1, min. application chip revision: 0
I (102) esp_image: segment 0: paddr=0x00010020 vaddr=0x3f400020 size=0x04574 ( 17780) map
I (118) esp_image: segment 1: paddr=0x0001459c vaddr=0x3ffb0000 size=0x00124 (   292) load
I (120) esp_image: segment 2: paddr=0x000146c8 vaddr=0x3ffb0124 size=0x00050 (    80) load
I (129) esp_image: segment 3: paddr=0x00014720 vaddr=0x3ffb0174 size=0x00064 (   100) load
I (138) esp_image: segment 4: paddr=0x0001478c vaddr=0x3ffb01d8 size=0x008f4 (  2292) load
I (148) esp_image: segment 5: paddr=0x00015088 vaddr=0x3ffb0acc size=0x00088 (   136) load
I (156) esp_image: segment 6: paddr=0x00015118 vaddr=0x3ffb0b54 size=0x000c0 (   192) load
I (165) esp_image: segment 7: paddr=0x000151e0 vaddr=0x3ffb0c14 size=0x00100 (   256) load
I (174) esp_image: segment 8: paddr=0x000152e8 vaddr=0x3ffb0d14 size=0x00030 (    48) load
I (183) esp_image: segment 9: paddr=0x00015320 vaddr=0x3ffb0d44 size=0x00044 (    68) load
I (192) esp_image: segment 10: paddr=0x0001536c vaddr=0x40080000 size=0x00400 (  1024) load
I (201) esp_image: segment 11: paddr=0x00015774 vaddr=0x40080400 size=0x0a8a4 ( 43172) load
I (229) esp_image: segment 12: paddr=0x00020020 vaddr=0x400d0020 size=0x07094 ( 28820) map
I (240) esp_image: segment 13: paddr=0x000270bc vaddr=0x4008aca4 size=0x02a7c ( 10876) load
I (252) boot: Loaded app from partition at offset 0x10000
I (252) boot: Disabling RNG early entropy source...
⸮*** Booting Zephyr OS build zephyr-v2.6.0-420-ge62c3c533a37  ***

uart:~$ [00:00:00.529,000] <err> net_if: There is no network interface to work with!
uart:~$ uart:~$

Any tips on how to get it working?

@torntrousers Please, use samples/boards/esp32/wifi_station as reference.

Thanks @sylvioalves . I've got that to run but it does not seem to connect. I've tried putting in the incorrect password and th elog is the same. Is there some thing I can do to debug what is happening?
*⸮P⸮V⸮⸮ET⸮Q⸮UU⸮T⸮⸮-⸮QR⸮⸮⸮T⸮⸮⸮RUJ⸮⸮⸮⸮Z⸮j⸮⸮T⸮J⸮R⸮J⸮⸮⸮Ԯ⸮⸮⸮U⸮⸮*ZQBU⸮⸮j⸮⸮EJ⸮R⸮Z⸮Q⸮WխQ(⸮uT⸮Z⸮QJ-]⸮Z⸮,Q⸮⸮R⸮Z⸮QڬR⸮Z⸮Q⸮⸮⸮⸮I⸮⸮⸮T⸮U⸮UZU%u⸮Ք⸮⸮(U⸮UVK%u⸮⸮⸮⸮(U⸮⸮⸮⸮⸮%u⸮ՔTQ⸮QR⸮⸮TU⸮⸮⸮T⸮i⸮⸮⸮U⸮u⸮⸮⸮⸮⸮T⸮\EQE⸮⸮jZUUEj⸮⸮P⸮E⸮QU⸮T⸮⸮⸮U⸮P⸮U⸮KRJ⸮u⸮U⸮Q⸮ZUTU⸮⸮UTE⸮⸮⸮⸮JU⸮u⸮*TJUTB⸮⸮⸮⸮V⸮E*ժBRJ⸮J⸮⸮U⸮⸮V⸮⸮U⸮I (28) boot: ESP-IDF 22e757632 2nd stage bootloader
I (28) boot: compile time 12:09:28
I (28) boot: chip revision: 1
I (31) boot_comm: chip revision: 1, min. bootloader chip revision: 0
I (44) boot.esp32: SPI Speed      : 40MHz
I (44) boot.esp32: SPI Mode       : DIO
I (47) boot.esp32: SPI Flash Size : 8MB
I (52) boot: Enabling RNG early entropy source...
I (57) boot: Partition Table:
I (61) boot: ## Label            Usage          Type ST Offset   Length
I (68) boot:  0 nvs              WiFi data        01 02 00002000 00006000
I (76) boot:  1 phy_init         RF data          01 01 00008000 00001000
I (83) boot:  2 factory          factory app      00 00 00010000 00100000
I (91) boot: End of partition table
I (95) boot_comm: chip revision: 1, min. application chip revision: 0
I (102) esp_image: segment 0: paddr=0x00010020 vaddr=0x3f400020 size=0x0b57c ( 46460) map
I (129) esp_image: segment 1: paddr=0x0001b5a4 vaddr=0x3ffb0000 size=0x00100 (   256) load
I (129) esp_image: segment 2: paddr=0x0001b6ac vaddr=0x3ffb0100 size=0x000bc (   188) load
I (135) esp_image: segment 3: paddr=0x0001b770 vaddr=0x3ffb01bc size=0x00100 (   256) load
I (144) esp_image: segment 4: paddr=0x0001b878 vaddr=0x3ffb02bc size=0x01920 (  6432) load
I (156) esp_image: segment 5: paddr=0x0001d1a0 vaddr=0x3ffb1bdc size=0x00080 (   128) load
I (162) esp_image: segment 6: paddr=0x0001d228 vaddr=0x3ffb1c5c size=0x000d8 (   216) load
I (171) esp_image: segment 7: paddr=0x0001d308 vaddr=0x3ffb1d34 size=0x0004c (    76) load
I (180) esp_image: segment 8: paddr=0x0001d35c vaddr=0x40080000 size=0x00400 (  1024) load
I (189) esp_image: segment 9: paddr=0x0001d764 vaddr=0x40080400 size=0x028b4 ( 10420) load
I (202) esp_image: segment 10: paddr=0x00020020 vaddr=0x400d0020 size=0x3c4cc (246988) map
I (301) esp_image: segment 11: paddr=0x0005c4f4 vaddr=0x40082cb4 size=0x1147c ( 70780) load
I (343) boot: Loaded app from partition at offset 0x10000
I (343) boot: Disabling RNG early entropy source...
⸮⸮I (721) wifi:wifi driver task: 3ffb1ee8, prio:2, stack:3584, core=0
I (722) wifi:wifi firmware version: 1865b55
I (722) wifi:wifi certification version: v7.0
I (724) wifi:config NVS flash: disabled
I (727) wifi:config nano formating: disabled
I (731) wifi:Init data frame dynamic rx buffer num: 32
I (736) wifi:Init management frame dynamic rx buffer num: 32
I (741) wifi:Init management short buffer num: 32
I (746) wifi:Init dynamic tx buffer num: 32
I (750) wifi:Init static rx buffer size: 1600
I (754) wifi:Init static rx buffer num: 10
I (758) wifi:Init dynamic rx buffer num: 32
phy_version: 4500, 0cd6843, Sep 17 2020, 15:37:07, 0, 2
I (896) wifi:mode : softAP (8c:aa:b5:83:60:19)
I (897) wifi:Total power save buffer number: 16
I (897) wifi:Init max length of beacon: 752/752
I (901) wifi:Init max length of beacon: 752/752
*** Booting Zephyr OS build zephyr-v2.6.0-420-ge62c3c533a37  ***
I (911) wifi:mode : sta (8c:aa:b5:83:60:18)
[00:00:00.916,000] <inf> esp32_wifi: WIFI_EVENT_STA_START
[00:00:02.968,000] <inf> esp32_wifi: WIFI_EVENT_STA_DISCONNECTED
[00:00:05.019,000] <inf> esp32_wifi: WIFI_EVENT_STA_DISCONNECTED
[00:00:07.071,000] <inf> esp32_wifi: WIFI_EVENT_STA_DISCONNECTED
[00:00:09.123,000] <inf> esp32_wifi: WIFI_EVENT_STA_DISCONNECTED

@torntrousers Have you set that at the prj.conf file? What is the wifi security type?

Yes, I found CONFIG_ESP32_WIFI_SSID and CONFIG_ESP32_WIFI_PASSWORD in zephyrproject\zephyr\samples\boards\esp32\wifi_station\prj.conf  and set those for my Wifi access point. I haven;t changed anything else , so whatever the default security type is?

Any ideas @sylvioalves ?

@torntrousers I checked that with latest main branch and it worked.  Have you performed west update and west espressif update in your env? Is your wifi network configured as WPA or WPA2?

Thanks @sylvioalves . Network is WPA2-Personal (according to WIndows Network Properties). The ESP32 connects to it ok with the ESP32 Arduino framework.
I had not run those west commands, I have now but after rebuilding and flashing there is no difference.
west update
=== updating cmsis (modules/hal/cmsis):
HEAD is now at c3bd209 DSP: fix compiler warning on inline attribute
=== updating hal_atmel (modules/hal/atmel):
HEAD is now at d17b7dd winc1500: nmspi: Don't force definition of USE_OLD_SPI_SW
=== updating hal_altera (modules/hal/altera):
HEAD is now at 23c1c1d hal_altera: Conditionally include the Altera HAL
=== updating canopennode (modules/lib/canopennode):
HEAD is now at 468d350 Merge pull request #2 from vestas-wind-systems/update_to_v1_3_master
=== updating civetweb (modules/lib/civetweb):
HEAD is now at 094aeb41 cmake: relax minimum version requirements
=== updating hal_espressif (modules/hal/espressif):
HEAD is now at 22e757632 wifi: event: move event handler to wifi driver
=== updating fatfs (modules/fs/fatfs):
HEAD is now at 1d1fcc7 fat_fs: Expose _VOLUMES to Kconfig
=== updating hal_cypress (modules/hal/cypress):
HEAD is now at 81a059f Merge pull request #1 from nandojve/pdl_scb_spi_i2c
=== updating hal_infineon (modules/hal/infineon):
HEAD is now at f1fa824 hal: infineon: initial commit of XMCLib
=== updating hal_nordic (modules/hal/nordic):
HEAD is now at 74b3b21 drivers: nrf_802154: Update the IEEE 802.15.4 component
=== updating hal_openisa (modules/hal/openisa):
HEAD is now at 40d049f openisa: Make openisa hal a zephyr_library
=== updating hal_nuvoton (modules/hal/nuvoton):
HEAD is now at b4d31f3 hal: nuvoton: add license to numicro m480 series hal
=== updating hal_microchip (modules/hal/microchip):
HEAD is now at b280eec modules: microchip: mec1501: Add Analog comparator register defines
=== updating hal_silabs (modules/hal/silabs):
HEAD is now at be39d4e modules: hal_silabs: Add Silabs Gecko HAL for EFR32FG13P SoCs
=== updating hal_st (modules/hal/st):
HEAD is now at 575de9d sensor/stmemsc: Align stmemsc i/f to v2.00
=== updating hal_stm32 (modules/hal/stm32):
HEAD is now at f8ff8d25 dts/st: use a pull-down for SPI SCK pin
=== updating hal_ti (modules/hal/ti):
HEAD is now at 3da6fae zephyr: use k_ms_to_ticks_ceil32 instead of z_ms_to_ticks
=== updating libmetal (modules/hal/libmetal):
HEAD is now at 39d049d lib: update libmetal to release v2021.04.0 + VERSION path fix
=== updating hal_quicklogic (modules/hal/quicklogic):
HEAD is now at b3a66fe Remove references to FPGA IP core drivers
=== updating lvgl (modules/lib/gui/lvgl):
HEAD is now at 31acbaa3 lv_font: Fix compiler warning when compressed fonts are disabled (#1880)
=== updating mbedtls (modules/crypto/mbedtls):
HEAD is now at 5765cb7 mbedtls: update README with laterst version information
=== updating mcuboot (bootloader/mcuboot):
HEAD is now at 7a51968 Merge: synhronize up to https://github.com/mcu-tools/mcuboot/commit/680ed07e42f
=== updating mcumgr (modules/lib/mcumgr):
HEAD is now at 5c5055f snapshot: Update mcumgr to commit e64f5060bd from upstream
=== updating net-tools (tools/net-tools):
HEAD is now at f49bd13 net-capture: Listen captured traffic and save to pcap file
=== updating hal_nxp (modules/hal/nxp):
HEAD is now at 0d11138 mxrt600: Relocate power driver to SRAM
=== updating open-amp (modules/lib/open-amp):
HEAD is now at 6010f05 lib: update open-amp lib to release v2021.04.0
=== updating loramac-node (modules/lib/loramac-node):
HEAD is now at 12019623 zephyr: radio: sx127x: override buffer read/write functions
=== updating openthread (modules/lib/openthread):
HEAD is now at f460532d4 Merge pull request #41 from kkasperczyk-no/ot_upmerge
=== updating segger (modules/debug/segger):
HEAD is now at 3a52ab2 config: Use zephyr provided options
=== updating sof (modules/audio/sof):
HEAD is now at 779f28ed4 Merge pull request #11 from nashif/kconfig_main_menu
=== updating tinycbor (modules/lib/tinycbor):
HEAD is now at 40daca9 zephyr: Remove TINYCBOR from interface libraries
=== updating tinycrypt (modules/crypto/tinycrypt):
HEAD is now at 3e9a49d cmake: Fix conditional in root CMakeLists.txt
=== updating littlefs (modules/fs/littlefs):
HEAD is now at 9e4498d lfs_util: fix log declaration when logging is disabled
=== updating mipi-sys-t (modules/debug/mipi-sys-t):
HEAD is now at 75e6715 zephyr: move platform.h to zephyr tree
=== updating nrf_hw_models (modules/bsim_hw_models/nrf_hw_models):
HEAD is now at a47e326 HW_models: NRF_RTC: Fix compare event missed when interrupt disabled
=== updating TraceRecorderSource (modules/debug/TraceRecorder):
HEAD is now at 5b5f8d7 Merge pull request #5 from nashif/update_003
=== updating hal_xtensa (modules/hal/xtensa):
HEAD is now at 2f04b61 zephyr: add SoC overlay for intel_tgl_adsp
=== updating edtt (tools/edtt):
HEAD is now at 7dd56fc Add FIXME note to handle incorrect LL/CON/MAS/BV-27-C implementation
=== updating trusted-firmware-m (modules/tee/tfm):
HEAD is now at e18b7a9b trusted-firmware-m: platform: lpcxpresso55s69: Remove pull_drivers.cmake
=== updating tfm-mcuboot (modules/tee/tfm-mcuboot):
HEAD is now at 4aa516e Bump versions for v1.7.2
=== updating nanopb (modules/lib/nanopb):
HEAD is now at d148bd2 Add zephyr module support
=== updating tensorflow (modules/lib/tensorflow):
HEAD is now at dc70a45a7cc tensorflow: add tensorflow 2.4.1 as a zephyr module
=== updating lz4 (modules/lib/lz4):
HEAD is now at 8e303c2 zephyr: make this repo a zephyr module

C:\Users\Administrator.CQ-LAP-000001\zephyrproject\zephyr>west espressif update
=== updating ESP-IDF submodules..
=== updating ESP-IDF submodules completed

C:\Users\Administrator.CQ-LAP-000001\zephyrproject\zephyr>

@torntrousers Is the file prj.conf modified (except for for ssid and pass)?

@sylvioalves no. It looks like this:
CONFIG_WIFI=y
CONFIG_WIFI_ESP32=y
CONFIG_HEAP_MEM_POOL_SIZE=98304

CONFIG_NETWORKING=y
CONFIG_NET_L2_ETHERNET=y

CONFIG_NET_IPV6=n
CONFIG_NET_IPV4=y
CONFIG_NET_DHCPV4=y

CONFIG_NET_MGMT=y
CONFIG_NET_MGMT_EVENT=y

CONFIG_NET_LOG=y
CONFIG_NET_SHELL=n

CONFIG_MBEDTLS=y
CONFIG_MBEDTLS_ENTROPY_ENABLED=y
CONFIG_MBEDTLS_KEY_EXCHANGE_ECDHE_ECDSA_ENABLED=y
CONFIG_MBEDTLS_ECP_ALL_ENABLED=y

CONFIG_ESP32_WIFI_SSID="BT-QHATQC"
CONFIG_ESP32_WIFI_PASSWORD="xyz..."

@sylvioalves I've tried this with my Wifi access point and also using a hotspot on my Android phone (also WPA2-Personal). Neither work with Zephyr but both work with ESP32 Arduino environment.
To workout if its some problem with my Zephyr install/build how about would it be possible for you to build the sample and send it to me so I can try you binary? My hotspot ssid/password is Balloon1/qaz123456.
Or what is some other way to debug the problem?

@torntrousers I have just tested with my phone as well and it worked with same credentials.
Find the bin file attached.
Hum, You have been working on Windows, right? I'll try in Windows as well.
I (729) wifi:wifi firmware version: 1865b55
I (729) wifi:wifi certification version: v7.0
I (731) wifi:config NVS flash: disabled
I (734) wifi:config nano formating: disabled
I (738) wifi:Init data frame dynamic rx buffer num: 32
I (743) wifi:Init management frame dynamic rx buffer num: 32
I (748) wifi:Init management short buffer num: 32
I (753) wifi:Init dynamic tx buffer num: 32
I (757) wifi:Init static rx buffer size: 1600
I (761) wifi:Init static rx buffer num: 10
I (765) wifi:Init dynamic rx buffer num: 32
phy_version: 4500, 0cd6843, Sep 17 2020, 15:37:07, 0, 2
I (894) wifi:mode : softAP (4c:11:ae:f4:98:61)
I (895) wifi:Total power save buffer number: 16
I (895) wifi:Init max length of beacon: 752/752
I (899) wifi:Init max length of beacon: 752/752
*** Booting Zephyr OS build zephyr-v2.6.0-385-g2d3195c8a2e2  ***
I (910) wifi:mode : sta (4c:11:ae:f4:98:60)
[00:00:00.915,000] <inf> esp32_wifi: WIFI_EVENT_STA_START
[00:00:02.962,000] <inf> esp32_wifi: WIFI_EVENT_STA_DISCONNECTED
I (4290) wifi:new:<11,0>, old:<1,1>, ap:<255,255>, sta:<11,0>, prof:1
I (4936) wifi:state: init -> auth (b0)
I (4942) wifi:state: auth -> assoc (0)
I (4946) wifi:state: assoc -> run (10)
I (4996) wifi:connected with Balloon1, aid = 1, channel 11, BW20, bssid = e6:d7:9e:81:74:80
I (4996) wifi:security: WPA2-PSK, phy: bgn, rssi: -43
[zephyr.zip](https://github.com/zephyrproject-rtos/zephyr/files/6693025/zephyr.zip)

I (4998) wifi:pm start, type: 1

I (5078) wifi:AP's beacon interval = 102400 us, DTIM period = 2
[00:00:05.001,000] <inf> esp32_wifi: WIFI_EVENT_STA_CONNECTED
[00:00:05.948,000] <inf> net_dhcpv4: Received: <IP_ADDRESS>
[00:00:05.948,000] <inf> esp32_wifi_sta: Your address: <IP_ADDRESS>
[00:00:05.948,000] <inf> esp32_wifi_sta: Lease time: 3599 seconds
[00:00:05.948,000] [0m<inf> esp32_wifi_sta: Subnet: <IP_ADDRESS>
[00:00:05.948,000] <inf> esp32_wifi_sta: Router: <IP_ADDRESS>

Oh, its Zephyr isn't it - I'm on a older build than you. How do I update that?

I think it is something related to the board config itself. Let me check, I'll get back to you..

@sylvioalves , I have just joined the Zephyr slack so yes I have an account now.

Hi @sylvioalves , any ideas yet? Did that binary built on my system work for you on yours?

With help from @sylvioalves on slack this has been resolved - it was the Heltec board itself and using a different ESP32 module and it all works fine. Not sure what the problem is with the Heltec board as it works fine with the Arduinio/ESP32 environemnt, but that can be for another day.


Mark some common project settings as basic

This marks advanced settings that were agreed upon in https://github.com/godotengine/godot/issues/50620 as basic.

No comments on the settings being defined twice. Probably should be split into a separate proposal.

Fair enough, there's quite a few in that situation.

Thanks!


REGRESS tests should be integration-only

[ ] Consider adopting the --integration mechanism from cgpm.
[ ] Mark REGRESS tests as integration tests.
[ ] Add a bayeslite-master-integration job to jenkins.

The --integration mechanism could be used to replace the existing __ci_slow convention.
We probably should explicitly mark --integration with a reason, for example __ci_slow versus __ci_dependency, since integration tests might be slow, or might require optional dependencies, etc.

While addressing the issue of integration tests and dependencies, we should also address this pattern for skipping tests based on dependencies from tests/test_loom#L33-L37:
def loom_analyze(csv_filename):
    try:
        import loom
    except ImportError:
        pytest.skip('no loom')
        return

...

def test_loom_dha__ci_slow():
    loom_analyze(dha_csv)

def test_loom_satellites__ci_slow():
    loom_analyze(satellites_csv)

My idea with --integration was to mark that as the one for integration tests requiring a full suite of dependencies; we could separately have --slow, --network, &c., and maybe --all to run them all.


chore: update project name in cargo manifest

Looks like the project was renamed at some point, but the name in the Cargo.toml was never updated.

@mlieberman85 looks like there was another instance of the old name in the clap configuration. I updated that as well.


Add dynamic schema spec to machine pools

CI won't pass for https://github.com/rancher/rancher/pull/40730 until the apis are updated and pulled into the webhook.

@jiaqiluo I did, no changes were generated. I think this is because it's trivial to copy string types in go, since only pointers, list, and maps are copied in the generated deep copy functions.


Set ua_session of Http2ConnectionState nullptr when ua_session is freed

There're some race of freeing Http2ClientSession vs  freeing Http2ConnectionState.
Http2ConnectionState::destroy() is called from Http2ClientSession::free() and when it called, ua_session should be set nullptr.
This could be fix #2711

I don't think it's a fix. It might avoid the crash but would hide the root cause. How can ua_session be nullptr after checking it?

Should we not land this?

 I just think we can’t close the issue with this change.

Alrighty, I'll leave the issue open and we land this into the 7.1.x branch.


Discussion: CIP-94

Do we require a minimal voting power? Or do we allow a faster update if the voting is unanimous?
Do we need an option to vote for unchange or just let the user to distribute the votes for both increase and decrease?
Do we want new votes to override old votes or do we want every vote to be final?
Do we need to store the vote data in a way that they can be garbage collected after each vote period?
Do we need separate interfaces to vote for one or multiple parameters?

For 2, removing the unchange option will make the contract use fewer storage entries and also reduce the cost for each vote in general,. However, a user who wants to vote for unchanged will use more data to send the vote, and he cannot perfectly cast all its votes if he has an odd number of votes.


@conda-forge-admin, please add user @matthiasdv

Add Matthias as maintainer

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added user @matthiasdv in conda-forge/coiled-feedstock#51.


Ancillary teams

Ancillary teams are bodies composed of organization members, who are given responsibility, authority and limited autonomy over a given matter or area, subject to the general supervision of their parent body and/or the Steering Council.
Assigning authority and responsibility over a particular matter or area to a dedicated group of people ensures delineation of proper duties (knowing who does what) and proper scrutiny of that matter or area (if it would otherwise be cumbersome or difficult for another body to undertake those responsibilities).
The ancillary teams concept is meant to provide a uniform skeleton for the establishment of working groups, task forces, subteams, committees, panels, or other bodies, which take responsibility for some matter or area.
While the individual ancillary team may be referred officially by another name (such as those mentioned previously), as long as they are defined as an ancillary team, they are included under that umbrella team.
Works in progress

[ ] Proofreading the as-of-writing (2023-09-05) draft

Please discuss this in the Goverance thread on the Discord server. Thank you.
View the current draft of the uniform skeleton document on the draft/sci/governance branch.

See https://github.com/neoforged/governance/issues/2#issuecomment-1712563278


fix race condition with session thread migration

This is a fix for a race condition (found and debugged in ats92) when a session is taken from the session pool and migrated to another thread.  This is with GLOBAL session pools.  There are still rare cases where events are still leaking through to the VC in the pre-migrated thread causing various different asserts.
This PR moves thread migration out of the session manager acquire critical section and locks and stops events on the original thread netvc during migration.  Global (and likely hybrid) pool performance is improved in this case.
Initial testing using test case verifies that ats master crashes (quickly and a lot) without the patch and runs fine the patch.
NOTE: the general session pool handling is dramatically slower in ATS master compared with ATS 91/92, perhaps due to libswoc migration.
Will test in prod for stability.
should close #9690
Also related to: https://github.com/apache/trafficserver/issues/9689

Current proposed fix will drop 1-2 bytes from the content body instead of aborting.

[approve ci]


Nesting of Overriden Themes

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Theme nesting is not working as expected.
In below example, "MuiInput root of theme1" and "MuiInput underline of theme2" both should work.
Current Behavior

But here "MuiInput underline of theme2" works well but it does apply properties of "MuiInput root of theme1".
Steps to Reproduce (for bugs)

import React from 'react';
import { createMuiTheme, MuiThemeProvider } from 'material-ui/styles';
import Input, { InputLabel } from 'material-ui/Input';

const theme1 = createMuiTheme({
  typography: {
      fontFamily:
        'Hind Vadodara',
      body1: {
        fontSize: 16,
      },
    },
    overrides: {
      MuiInput: {
        root: {
          fontSize: 16,
          color: 'red',
        },
      }
    },
  });

  const theme2 = outerTheme => ({
  ...outerTheme,
  overrides: {
      MuiInput: {
        underline: {
          '&::before': {
            height: 0,
          },
        },
      },
    },
  });

function Demo() {

  return (
    <MuiThemeProvider theme={theme1}>

           <InputLabel style={{ margin :8 }}>Title</InputLabel>
           <Input id="title" />

        <MuiThemeProvider theme={theme2}>
            <InputLabel style={{ margin :8 }}>Title</InputLabel>
            <Input id="title" />
        </MuiThemeProvider>

    </MuiThemeProvider>
  );
}

export default Demo;

Your Environment

Tech
Version

Material-UI
v1.0.0 beta.23

React
16.0.0

Theme merging won't happen by magic. Right now, you are rewriting the whole overrides object in theme2.


"Close connection fast if TIME_WAIT support is off" broke active close support

https://github.com/zephyrproject-rtos/zephyr/pull/539 / https://github.com/zephyrproject-rtos/zephyr/commit/210c30805b9e90f65edc988e92df8324a7a64094 broke standard Internet services implementations, when client makes a request, server sends a response, and closes connection. After the above patch, a client doesn't notice connection close (e.g. telnet/curl keep running, waiting for more data).
This issue wasn't spotted apparently because we don't have an implementation of a standard Internet server in Zephyr codebase (instead we have more advanced things like HTTP 1.1 pipeline connections which don't do server close).
The issue was found using https://github.com/micropython/micropython/blob/master/examples/network/http_server.py sample application with MicroPython Zephyr port.

Looking at the above patch, it doesn't do the right thing. Its description talks about TIME_WAIT, but the code doesn't touch anything directly affecting TIME_WAIT. A patch optimizing out TIME_WAIT, should do following: queue FIN (as the original code does), wait for ACK to it (including retransmit on timeout), and only after that, it can unref context immediately, whereas the RFC requires it to go into TIME_WAIT state, and live in it for quite some time.
Suggestion re: above patch: revert.

Ok, lets revert the commit 210c308 then, please submit the patch to master. There was a reason I submitted the patch but now I do not recall the exact reasoning for that and the commit message does not tell enough info.
Can you add to the revert patch some more info why we are reverting so that it is not a mystery later why we did this?

@jukkar, If you think that reverting is good idea, that per info in https://github.com/zephyrproject-rtos/zephyr/issues/729, I'd rather instead submit a patch on top of it which fixes an immediate issue. Let me wait a bit though, if there will be comments re: synchronizing access to global array raised https://github.com/zephyrproject-rtos/zephyr/issues/729#issuecomment-313935976 . If there won't be, I'll submit just quick fix by the end of day, leaving sync issues for later. Thanks.

I investigated this a bit more and the reasoning in commit 210c30805 for putting the queue_fin() behind CONFIG_NET_TCP_TIME_WAIT was that if the TIME_WAIT support is not enabled (default), then the context was never released properly if the peer FIN was lost.
Anyway, after looking the code, we should probably send a FIN always, and just unref the context unconditionally, otherwise the context might be left hanging a long time.

I did some experimenting, and it seems that we need a timer to make this work nicely. So we should send a FIN when closing the connection, then install a timer (just in case the peer FIN is lost), and then unref the net_context inside the close timer if the peer FIN was lost. I can cook a patch for doing this.

Thanks!

Related to this, the passive close support got broken when implementing the syn-ack backlog support. I will send a patch that fixes this too.

Fixes for active and passive close issues at #736

Fixed.


The owners API returns different results bewteen first response and subsequent responses

How to reproduce:

Go to https://master.demo.geonode.org/
Open the browser's dev tools
Open the filters and expand the "Owners" select box
A request to https://master.demo.geonode.org/api/v2/owners?page_size=20&page=1 is executed
Response contains the owners key
Open the same request on a new browser tab -> response contains owners
Refresh the page -> response contains users (and this will be returned for any susequent request)

I suspect something wrong happens between the OwnerSerializer and UserSerializer.
Moreover OwnerSerializer should only return owners. The way it is now it returns all users (doing the same as UserSerializer). Any comment @marthamareal?

The owners API returns only users with at least one resource, as it filters users using this function here
The issue i see is the key name in response changing from owners to users on different calls. but data remains correct


RaReactPageInput not working with react-admin

Hi, I'm trying to connect react-page with react-admin, based on example code.
I downgraded couple of packages (React to v17, react-admin to ^3.14.2).
Problem is that when the content is empty, toolbar is in one line horizontally, and when there is an content, everything is spread out to the sides.
{
  "name": "test-admin",
  "version": "0.1.0",
  "private": true,
  "dependencies": {
    "@emotion/react": "^11.10.0",
    "@emotion/styled": "^11.10.0",
    "@react-page/editor": "^5.0.2",
    "@react-page/plugins-background": "^5.0.2",
    "@react-page/plugins-divider": "^5.0.2",
    "@react-page/plugins-html5-video": "^5.0.2",
    "@react-page/plugins-image": "^5.0.2",
    "@react-page/plugins-slate": "^5.0.2",
    "@react-page/plugins-spacer": "^5.0.2",
    "@react-page/plugins-video": "^5.0.2",
    "@react-page/react-admin": "^5.0.2",
    "@testing-library/jest-dom": "^5.14.1",
    "@testing-library/react": "^13.0.0",
    "@testing-library/user-event": "^13.2.1",
    "@types/jest": "^27.0.1",
    "@types/node": "^16.7.13",
    "@types/react": "^18.0.0",
    "@types/react-dom": "^18.0.0",
    "prop-types": "^15.8.1",
    "ra-data-fakerest": "^4.2.6",
    "ra-data-json-server": "^4.2.6",
    "react": "^17.0.2",
    "react-admin": "^3.14.2",
    "react-dom": "^17.0.2",
    "react-katex": "^3.0.1",
    "react-scripts": "5.0.1",
    "styled-components": "^5.3.5",
    "typescript": "^4.4.2",
    "web-vitals": "^2.1.0"
  },
  "scripts": {
    "start": "GENERATE_SOURCEMAP=false react-scripts start",
    "build": "react-scripts build",
    "test": "react-scripts test",
    "eject": "react-scripts eject"
  },
  "eslintConfig": {
    "extends": [
      "react-app",
      "react-app/jest"
    ]
  },
  "browserslist": {
    "production": [
      ">0.2%",
      "not dead",
      "not op_mini all"
    ],
    "development": [
      "last 1 chrome version",
      "last 1 firefox version",
      "last 1 safari version"
    ]
  }
}

make sure to include import<EMAIL_ADDRESS>somewhere in your admin code.
That should fix the issue

make sure to include import<EMAIL_ADDRESS>somewhere in your admin code.
That should fix the issue

Thanks :) Fixed everything

make sure to include import<EMAIL_ADDRESS>somewhere in your admin code.
That should fix the issue

Thanks :) Fixed everything


composer: sort paths

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Do you mind creating this patch against composer/composer so that it can be reviewed by the Composer team ?

Yes that's the plan. I'm not sure if I applied the patch to correct package here. I'm going to close it for now.


[BUG] Websocket's icon in footer is showing wrong

Describe the bug
Websocket's icon in footer is showing wrong.

Expected behavior
The name of the websocket icon should be displayed correctly.

Verified on master-head 20220512
Result Pass
All web socket icon display correctly :

volume
node
setting
engineImage
event
backingImage
recurringJob
BackupVolumes
Backups

Those icon will switch between open/closed when browse different Longhorn page
Opened icon in each page :

Dashboard : volume, node, event
Node : volume, node, setting
Volume : volume, node, setting, engineImage, backingImage, backingImage
Recurring Job : recurringJob
Backup : node, setting, backingImage, recurringJob
Setting - General : setting


[Feature] : Add issue template for feature request

@PiyushKalyanpy I think this a good feature to have and can organize the issues more

Sure @Tushar98644 you can start working on it 🙌


Add hutch shutter device

Closes #611
Needed for MX#110
Instructions to reviewer on how to test:

Check logic makes sense
Run tests

Checks for reviewer

[ ] Would the PR title make sense to a scientist on a set of release notes
[ ] If a new device has been added does it follow the standards
[ ] If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
[ ] Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

For the moment, I have only added this device to i24.py. Any other beamlines it should be added to at this time?


Use Dockerfile to make development and deployment easier

Hot damn.
Closes #37
Closes #115
This PR finally does away with S2I on OKD (It's currently pulling from this branch on Prod!) by setting up a Dockerfile for this project that can be used on proxmox and both rq pods. Instructions are included for setting everything up as well.

For some reason, proxstar doesn't want to exit cleanly from its container. Whenever I do podman stop proxstar it hangs and has to resort to killing it. It happens for proxtar, and both rq containers.
WARN[0010] StopSignal SIGTERM failed to stop container proxstar-rq in 10 seconds, resorting to SIGKILL

This works OK for local development, but I'm not sure it will work for OKD.

There's no way to check this on the build logs 🤦🏻 I'm tempted to add another layer that just echos the environment variable.

yeah this sucks.

https://artsy.github.io/blog/2018/09/10/Dockerhub-Stamping-Commits/

https://docs.openshift.com/container-platform/3.4/dev_guide/builds/build_hooks.html

https://github.com/openshift/origin/issues/615


🐛 [firebase_crashlytics] How to disable firebase_crashlytics from getting android_id?

I want to get the android_id only after the user agrees, or not.
Now detected "com.google.firebase.crashlytics.internal.common" gets android_id, what should I do?

@lizhuoyuan
I think your question is better suited for support channels like StackOverflow, where, a Firebaser can probably give you a solution.
Closing from here, as this is more of a how to question and not a bug or feature request.

https://github.com/firebase/firebase-android-sdk/issues/3826

hey , I found https://github.com/firebase/firebase-android-sdk/pull/3840
But the flutter version of android is a dependent  "classpath 'com.google.firebase:firebase-crashlytics-gradle:2.9.2'", otherwise it will prompt an error, how can I ensure that the flutter version can use the updated code


⚠ DesiTorrents has degraded performance

In 1222733, DesiTorrents ($DST) experienced degraded performance:

HTTP code: 200
Response time: 1513 ms

Resolved: DesiTorrents performance has improved in 12ae75e.


Add automated coverage checks

Should be able to rig something up with gcov, coveralls.io, cpp-coveralls

Done, but only 99%!


Speed up the animation of a destroying unit by a bit

It's a bit too slow currently.

I also just noticed that I'm using the wrong animation for destroying the unit, but I kind of like the current one. I'm going to implement a patch that makes you choose between the original and my animation.
First, I will fix this issue by speeding up the animation from 16 to 8 steps. The original game also uses 8 steps.


Chrome perf. problem when running on the same PC

Test done: apply simple mask (all 1s) from API, repeat same from GUI (with disk mask analysis, maximum radius). All from filesystem cache.
Data: EMPAD 4GiB, MIB 4GiB, FRMS6 8.6GiB
Observation: the Python API is fast-ish (~0.2s for EMPAD, ~1.6s for MIB, ~8.1s for FRMS6), while the GUI is sometimes drastically slower (~0.5s for EMPAD, ~9s for MIB, ~30s FRMS6).
So, two things: 1) something makes processing in the GUI slower, dependent on the file type, 2) the FRMS6 reader is not yet as fast as it could be (IMHO, even though it does a bit more work, like dark frame substraction and unfolding the weird half-frames)
Can't say I have found the culprit yet, but one more observation: the (UDF-based) average frame calculation is also affected, and there disabling visualization of intermediate results helps, but the same is not true for the mask job result, even throwing away all results and not reducing them into the result buffer doesn't help.
Possible next steps:

need to do some system-wide perf profiling again
write a mask UDF and compare perf. to apply mask job
run libertem server on moellenstedt/madmax and GUI on laptop and see if perf. is better
implement some basic performance tracing (for example, emit the chrome event tracing format which can be visualized in chrome://tracing/)

one more observation: the (UDF-based) average frame calculation is also affected, and there disabling visualization of intermediate results helps, but the same is not true for the mask job result, even throwing away all results and not reducing them into the result buffer doesn't help.

This is actually because the mask job result has a busy indicator on the apply button, whereas the average frame visualization only has the spinner on top of the result image. On Chrome, this has a huge performance impact somehow (maybe related to my system configuration, too?), which I have yet to properly debug/understand.
This is also visible in the system wide profile, where the slow case for the average frame calculation had chrome and related programs visible. The fast case was dominated by the Python processes of LiberTEM. Taken using perf record -a -g -- sleep <something>, processed by perf script and visualized using flamescope and selecting the "hot" parts:
Slow:

Fast:

Using Firefox, the performance impact is still there, but much less severe (at least a factor 2 less impact than chrome).
Disabling all busy indicators and updates for partial results confirmed this: both Firefox and Chrome are almost exactly as fast as the scripted version. Here is a profile from Chrome (with intermediate results disabled, so this is about the best case):

As you can see, as indicated by the green bars in the "Frames" row, there are only redraws at the beginning (as I was clicking the apply button and moving the mouse out of the window); afterwards, only when the full results are received, a redraw occurs.
Compare to the case with running animations:

The Frames row is completely green, as we need to render 60 times per second. Zooming in a bit:

We can see that most frames even take more than 16ms, so the 60fps target isn't even hit. I'm going to stop this session here and next try to find out why Chrome is so much slower than Firefox, and maybe also look at it on different systems.
Btw: look at these beautiful flamescope patterns!

This is very, very interesting. 👍👍👍

@sk1p is this still current?

When I last tested this, it was on a different laptop - on my current one, I can't reproduce a significant performance difference between firefox and chrome - I'll close it for now. Some food for thought - in some situations performance may improve by having less worker processes, and having a bit leftover compute for browsers etc.


[Help] How does one measure the performance gains?

This is not exactly an "issue" with the library. But a few pointers on how to measure the performance gains (in release mode) would help me justify using this library in our app. TIA!

I use it in my react-native app and I have a huge performance gain when switching to dark mode or changing language in my app because it updates only the focused screen and updates the other screens when they are focused.

The <profileable> tag in the AndroidManifest.xml was probably the best way I found to profile RN Applications on Android in release mode. You can also set it up conditionally to avoid including it in true release builds as was done in https://github.com/valora-inc/wallet/pull/2995.