Updating the deployment example to use volumes, not configure

Yay

:+1:

Running jet steps in the 8.deployment-container folder fails on my local machine.
A general questions I'm not sure how this specific example would show creating a deployable container as the container doesn't actually contain the build artifact. Its stored in a volume and when I push the container to a registry would the volume be pushed with it?
From my understanding the volume would only be available on the build machine thus once we push the container somewhere else its basically empty (and creates a new volume there).
To make sure we have some kind of general test infrastructure for this repo I set up services and steps file and added it to our org on Codeship. Build running here: https://codeship.com/projects/103513/builds/f090ac3c-3f2f-498c-9b61-0c46b56715d6
@bfosberry I can send you the log output as well

Ran with the latest version again and now it worked fine on my machine. But there is still the question if this actually creates a container with the artifact?

Volume won't be stored with the container. Idea is you:
Build artifact in container with volume mounted as /artifacts
Build production container with volume mounted as /artifacts. During the
build you:
RUN cp /artifacts/app /app
So /app is not a volume, thus it is part of the container.
It's like using a USB key between computers.
On Sep 19, 2015 9:36 AM, "Florian Motlik"<EMAIL_ADDRESS>wrote:

Ran with the latest version again and now it worked fine on my machine.
But there is still the question if this actually creates a container with
the artifact?
—
Reply to this email directly or view it on GitHub
https://github.com/codeship/codeship-tool-examples/pull/10#issuecomment-141668363
.

@ngauthier yup thats what I thought too, but the Dockerfile is empty so the RUN cp /artifacts/app /app  step is missing

Cool. We should probably add it. Maybe in the example also run something
with the production container to show the artifact is inside without the
volume.
On Sat, Sep 19, 2015 at 10:08 AM, Florian Motlik<EMAIL_ADDRESS>wrote:

@ngauthier https://github.com/ngauthier yup thats what I thought too,
but the Dockerfile is empty so the RUN cp /artifacts/app /app step is
missing
—
Reply to this email directly or view it on GitHub
https://github.com/codeship/codeship-tool-examples/pull/10#issuecomment-141671758
.

OK so just to reiterate on what should be happening here according to my understanding (but isn't already):
We start an instance of compiledemo which has the tmp folder of the repository mounted as a volume. When we write to that tmp folder its written into the source repository folder on the host so its available for the next Docker deploy build (which is not as a volume, but simply because its in the folder)
Then in the deploy build we're copying the date file out of tmp/date into the container with COPY tmp/date /app/date which puts the date file (which is our artefact) into the deploy container. Currently this is not happening, but it should I assume, how else would it be getting into the container so we can push the container somewhere else.
The deploy container then has the artefact and is ready to be pushed to a registry with all files it needs to run in production (which here is only the date file)
Therefore the deploy container doesn't need to share the same data volume or use volumes_from as its not reading anything from a volume, but it already copied the date file as part of the Docker build. So the volumes_from should be removed in codeship-services.yml and the cat call in the steps.yml shouldn't reference the file in the volume, but the path that we copied the file into
According to docker/docker#14080 its not possible to use volumes during a Docker build and from my local trial the volume is also not as described above linking to the host source repository, but a named volume on the Host. Thus the file is simply not there during the Docker build and the Docker build fails.
@bfosberry could you describe the workflow you have in mind for this example without configure so we can make sure we think about the same thing. Because it seems to me at the moment this is not equivalent to what configure does.

So this was intended to be an example of providing an artifact to a running container. I'll extend this to add an example of building said artifact into a container to allow containers to be used as build artifacts.
There is an open question around how this should be handled. If we allow users to mount directories on the host we risk subsequent build affecting each other locally (and maybe on the hosted platform eventually). A solution to this would be to use a capistrano style subdirectory layout (tmp/builds/BUILD_ID, tmp/builds/current) which would mean we would have to enforce mounted volumes were under a certain dir, and docker builds would be able to consistently pull from tmp/builds/current. The problem with this approach is that it becomes difficult to maintain consistent artifact interaction for the user between docker builds and volume mounting. Saving a file to a volume may involve just setting A.txt, while adding it to a docker build may mean COPY tmp/builds/current/A.txt.
Rather than this approach I think it's reasonable to expect the user to manage their artifacts. All we should do is ensure that the mounted host volume is under the checkout folder, and document the fact that the user should be aware of possible old build artifacts and clean the folder before use as needed.

Keep in mind in the future we plan to run builds on a swarm, and there may
be more than one host. What about adding a commit option to a step to
allow a user to run a command that copies something from a volume into the
container, then we commit it to a new image? Or maybe some other way to
avoid host linking?
On Sep 21, 2015 10:22 AM, "Brendan Fosberry"<EMAIL_ADDRESS>wrote:

So this was intended to be an example of providing an artifact to a
running container. I'll extend this to add an example of building said
artifact into a container to allow containers to be used as build
artifacts.
There is an open question around how this should be handled. If we allow
users to mount directories on the host we risk subsequent build affecting
each other locally (and maybe on the hosted platform eventually). A
solution to this would be to use a capistrano style subdirectory layout
(tmp/builds/BUILD_ID, tmp/builds/current) which would mean we would have to
enforce mounted volumes were under a certain dir, and docker builds would
be able to consistently pull from tmp/builds/current. The problem with this
approach is that it becomes difficult to maintain consistent artifact
interaction for the user between docker builds and volume mounting. Saving
a file to a volume may involve just setting A.txt, while adding it to a
docker build may mean COPY tmp/builds/current/A.txt.
Rather than this approach I think it's reasonable to expect the user to
manage their artifacts. All we should do is ensure that the mounted host
volume is under the checkout folder, and document the fact that the user
should be aware of possible old build artifacts and clean the folder before
use as needed.
—
Reply to this email directly or view it on GitHub
https://github.com/codeship/codeship-tool-examples/pull/10#issuecomment-141997180
.

With that in mind I'm leaning towards a flocker-powered static build artifact volume linked to jetter, that we can attach to build containers as needed, and is available during the docker build since that is attached to jetter.
This would look something like this

New build starts, new volume is created mounted to the host (and later via flocker for swarm support)
Jetter is started attached to the volume
Any time a step runs with a host volume specified, we mount to the host into the same folder jetter is using. Later we mount using flocker
Because these objects are available in jetter they can be used to build images

Cool. Now for local execution, would we just mount straight to the host?
On Sep 21, 2015 11:07 AM, "Brendan Fosberry"<EMAIL_ADDRESS>wrote:

With that in mind I'm leaning towards a flocker-powered static build
artifact volume linked to jetter, that we can attach to build containers as
needed, and is available during the docker build since that is attached to
jetter.
This would look something like this

New build starts, new volume is created mounted to the host (and
later via flocker for swarm support)
Jetter is started attached to the volume
Any time a step runs with a host volume specified, we mount to the
host into the same folder jetter is using. Later we mount using flocker
Because these objects are available in jetter they can be used to
build images

—
Reply to this email directly or view it on GitHub
https://github.com/codeship/codeship-tool-examples/pull/10#issuecomment-142009676
.

So for now we can simply mount to the folder within jetter, in the future we'll want to split it out to support flocker and swarm but that depends on the implementation of flocker.

@bfosberry what are the next steps that need to happen to get this set up? What needs to be changed in jet to support this directly?
Running with host source repository connected and flocker in the future (if that can be properly connected into a build container) sounds good to me.

Update this PR to include an example of building an image with artifacts
Enforce/namespace host volume mounts to within the checkout directory (adding story, low priority)

Update this PR to include an example of building an image with artifacts

Is that possible at the moment without any changes to jet? Can we use the source repository on the Host as a volume right now?
On 21 Sep 2015 at 21:44:24, Brendan Fosberry<EMAIL_ADDRESS>wrote:

Update this PR to include an example of building an image with artifacts
Enforce/namespace host volume mounts to within the checkout directory (adding story, low priority)

—
Reply to this email directly or view it on GitHub.

Currently on jet you can mount host volumes, but that gives the user access to the entire host so its a security risk we'll want to patch in the future. The problem is the user doesnt know what dir we'll checkout into, so it's hard for them to specify the safe directory. For now we can let them use whatever, but in the future we'll want to prepend the project dir by default.
I also had a great convo with nick about possibly allowing binary injections though Commit, rather than dockerfile. We'll probably be exploring this in the future as an alternative to host volumes

Also my other idea, which I like the best right now, is to use add_docker
and run your compilation then run a docker build manually. IMO it's am
advanced enough use case we can support it with docs and docker in docker,
doesn't have to be a configurable situation.
On Sep 22, 2015 5:05 PM, "Brendan Fosberry"<EMAIL_ADDRESS>wrote:

Currently on jet you can mount host volumes, but that gives the user
access to the entire host so its a security risk we'll want to patch in the
future. The problem is the user doesnt know what dir we'll checkout into,
so it's hard for them to specify the safe directory. For now we can let
them use whatever, but in the future we'll want to prepend the project dir
by default.
I also had a great convo with nick about possibly allowing binary
injections though Commit, rather than dockerfile. We'll probably be
exploring this in the future as an alternative to host volumes
—
Reply to this email directly or view it on GitHub
https://github.com/codeship/codeship-tool-examples/pull/10#issuecomment-142421495
.

Currently on jet you can mount host volumes, but that gives the user access to the entire host so its a security risk we'll want to patch in the future. The problem is the user doesnt know what dir we'll checkout into, so it's hard for them to specify the safe directory. For now we can let them use whatever, but in the future we'll want to prepend the project dir by default.

Agreed prepending the source repository definitely makes sense, so people can't break out of that specific repo. Would this be a massive change in the current implementation?

Also my other idea, which I like the best right now, is to use add_docker
and run your compilation then run a docker build manually. IMO it's am
advanced enough use case we can support it with docs and docker in docker,
doesn't have to be a configurable situation.

Imho its not really an advanced feature as this is how we want people to build clean Docker containers. Its definitely a best practice to separate building the artifacts from the actual deployable container (and has come up numerous times during the Demos) so this should be something built very much into the platform to be very easy. Having to do add_docker, commiting and then pushing through Docker is too complex for a best practice that we want people to follow in my opinion. @AlexTi thoughts?

Build fails because there is no global steps file :P

Looks good. I like that volumes must be local. Seems safe.

@bfosberry is that working on your local system? Not working on mine (which might be due to docker-machine not being able to create locally shared folders even with the virtualbox machines)


merge package template from arlac77/npm-package-template

package.json

chore(devDependencies): update<EMAIL_ADDRESS>from template

Coverage remained the same at 64.49% when pulling 74f4dae4a5820e40d6ccec1fd1efafc2961eceb1 on template-sync-1 into c345c0858786273138a3f54e85da5531f5bcaca4 on master.

Codecov Report

Merging #343 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #343   +/-   ##
=======================================
  Coverage   69.45%   69.45%
=======================================
  Files           4        4
  Lines         203      203
=======================================
  Hits          141      141
  Misses         62       62

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c345c08...74f4dae. Read the comment docs.


There should be a way to extend the usage of IMDB example

I think the examples provided with IMDB sentiment analysis is cool, but it is specifically written for imdb dataset.
I think, the idea of this example is text classification, with a set of documents with label, then use this dataset to predict the label of new document.
It would be better if there is another utilities which will read the bunch of documents and analyze the frequency of these documents, so there will be X_train, X_test automatically, and x_train, x_test can be fetched manually.
So, it may looks like:
docs = doc.load_data (path_to_directory_contains_all_documents)
label = doc.load_label (path_to_file_contains_label_of_all_documents)
docs_train = ...
docs_test = ...
...

Easy to do by yourself. There are text processing utilities in Keras (and also in sklearn) that make this quick and simple.

Yeah, you are right, I found it easily to do. Thanks a lot,


Boost build doesn't find ICU

ICU is required for Boost.Locale (while not mandatory)
Steps to reproduce (Windows 7 Pro, Visual Studio 2015 Pro Upd 3)

cd c:\
git ... vcpkg
cd vcpkg
bootstrap-vcpkg.bat
vcpkg install icu boost

In the build log (attached) you will see:
    - has_icu builds           : no
    - icu                      : no

boost-x86-windows.zip

Attaching icu build logs
icu-x86-windows.zip

This code with ICU
#include <iostream>
#include <boost/locale.hpp>

int main()
{
	setlocale(LC_ALL,"");

	using namespace boost::locale;

	generator gen;
	std::cout.imbue(gen("de_DE.windows-1252"));

	double value = 12345.67;

	std::cout << as::spellout << value << "\n\n";
}

Is expected to output
zwölf-tausend-drei-hundert-fünf-und-vierzig Komma sechs sieben

The issue is with the way Boost tries to detect ICU. I could overcome this issue by setting both ICU_PATH and ICU_LINK in the bjam command line.
It is working for x86:windows. I didn't tested yet for static or x64.
Is there any interested on a PR for this?

ICU support would certainly be nice to have in Boost.Locale (and in Boost.Regex too!).
One issue I see here is that Boost doesn't seem to support ICU when compiling with /MT:
https://github.com/boostorg/locale/blob/develop/build/has_icu_test.cpp#L19
I'm guessing the main rationale here is that usually ICU on Windows is built as DLLs, in which case linking Boost with static runtime would indeed be problematic. Our ICU port however supports all of the (desktop) build combinations so maybe we could simply patch out this assertion.

@codicodi by "compiling with /MT" you mean the static triplets?

That's correct

OK, thanks.
ICU detection fails with x86-windows-static but not because of that assertion.
It seems that Boost is not honoring the "variant=release" and "runtime-link=static" options when building has_icu_test.
I'm getting these errors (release build):
icuin.lib(coll.ao) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '0' doesn't match value '2' in has_icu_test.obj
icuin.lib(coll.ao) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MDd_DynamicDebug' in has_icu_test.obj
Debug build has:
icuind.lib(coll.ao) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MTd_StaticDebug' doesn't match value 'MDd_DynamicDebug' in has_icu_test.obj
I'm not familiar with Bjam. I don't know how to fix Regex and Locale jam files.
Any idea?

This is fixed after Boost port redesign.


Outdated download link on https://prometheus.io/download/#alertmanager

What did you do?
Opened https://prometheus.io/download/#alertmanager
What did you expect to see?
Download link and checksums of released Alertmanager 0.20.0
What did you see instead? Under which circumstances?
Releases 0.19.0 and 0.20.0-rc.0

Hmm, the docs build on Netlify is failing with:
11:22:05 AM: bundle exec nanoc
11:22:06 AM: bundler: failed to load command: nanoc (/opt/build/cache/bundle/ruby/2.4.0/bin/nanoc)
11:22:06 AM: LoadError: /lib/x86_64-linux-gnu/libssl.so.1.0.0: version `OPENSSL_1.0.2' not found (required by /opt/buildhome/.rvm/rubies/ruby-2.4.3/lib/ruby/2.4.0/x86_64-linux/openssl.so) - /opt/buildhome/.rvm/rubies/ruby-2.4.3/lib/ruby/2.4.0/x86_64-linux/openssl.so
11:22:06 AM:   /opt/buildhome/.rvm/rubies/ruby-2.4.3/lib/ruby/2.4.0/openssl.rb:13:in `require'
11:22:06 AM:   /opt/buildhome/.rvm/rubies/ruby-2.4.3/lib/ruby/2.4.0/openssl.rb:13:in `<top (required)>'
11:22:06 AM:   /opt/buildhome/.rvm/rubies/ruby-2.4.3/lib/ruby/2.4.0/net/https.rb:23:in `require'
11:22:06 AM:   /opt/buildhome/.rvm/rubies/ruby-2.4.3/lib/ruby/2.4.0/net/https.rb:23:in `<top (required)>'
11:22:06 AM:   /opt/build/cache/bundle/ruby/2.4.0/gems/nanoc-4.11.0/lib/nanoc.rb:50:in `require'
11:22:06 AM:   /opt/build/cache/bundle/ruby/2.4.0/gems/nanoc-4.11.0/lib/nanoc.rb:50:in `<top (required)>'
11:22:06 AM:   /opt/build/cache/bundle/ruby/2.4.0/gems/nanoc-4.11.0/bin/nanoc:4:in `require'
11:22:06 AM:   /opt/build/cache/bundle/ruby/2.4.0/gems/nanoc-4.11.0/bin/nanoc:4:in `<top (required)>'
11:22:06 AM:   /opt/build/cache/bundle/ruby/2.4.0/bin/nanoc:23:in `load'
11:22:06 AM:   /opt/build/cache/bundle/ruby/2.4.0/bin/nanoc:23:in `<top (required)>'
11:22:06 AM: make: *** [compile] Error 1

Haven't found out yet why.

I restarted the Netlify build with a clean cache, and now it built fine.


fix(HUB-237): fixes how drop-down-list is displayed

Fixes HUB-237 and HUB-230

@jog1t CF build failed


Abstracting GUIDs out of the API

the goal here is primarily to:

pick up changes to patristic
improve the API, so users of this lib dont need to touch GUIDs

i expect youll want to change what ive done w package.json if/when a new version of patristic is released.

hey. just wondering if i should close this, or if there is something youd like changed, etc..


[Doc Issue][SBS guides - Subscription details -2][2331825]

Docs Build status updates of commit 7745074:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/Tab-ME-SSO/app-overview.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Tab-ME-SSO/go-to-resource.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Tab-ME-SSO/register-bot.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-Messaging-Extensions-Search/bot-page.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-Messaging-Extensions-Search/botdeployment.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-Messaging-Extensions-Search/review-plus-create.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-link-unfurling/bot-page.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-link-unfurling/botdeployment.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-link-unfurling/review-plus-create.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/bot-page.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/botdeployment.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/adaptive-cards/azure-bot-ui.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/adaptive-cards/bot-home-page.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/adaptive-cards/create-azure-bot.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/adaptive-cards/go-to-resource-card.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/adaptive-cards/validation-pane.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/bots/Azurebotcreate.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/bots/Azurebotresource.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/bots/aadapp.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/bots/createaresourcezurebot.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/calls-and-meetings/CM1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/calls-and-meetings/go-to-resource.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/calls-and-meetings/validation.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meeting-content-bubble/meeting-content-bubble-creating-resource-group.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meeting-content-bubble/meeting-token-generator-botdeployment.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meeting-content-bubble/meeting-token-generator-review-plus-create.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meeting-token-generator/meeting-token-generator-bot-page.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meeting-token-generator/meeting-token-generator-botdeployment.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meeting-token-generator/meeting-token-generator-review-plus-create.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meetings-side-panel/bot-page.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meetings-side-panel/bot-page1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meetings-side-panel/botdeployment.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meetings-side-panel/botdeployment1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meetings-side-panel/review-plus-create.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meetings-side-panel/review-plus-create1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-messagingextension-action/azure bot.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-messagingextension-action/create-azure-bot.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-messagingextension-action/create-azurebot.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-messagingextension-action/created-azure-bot.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-messagingextension-action/resource-file.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/home-png.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/reg-azure-1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/resource-group.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/app-service-create-new.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/blazor/azure.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/blazor/resource-group.PNG
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 46c1637:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/Tab-ME-SSO/app-overview.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Tab-ME-SSO/go-to-resource.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Tab-ME-SSO/register-bot.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-Messaging-Extensions-Search/bot-page.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-Messaging-Extensions-Search/botdeployment.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-Messaging-Extensions-Search/review-plus-create.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-link-unfurling/bot-page.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-link-unfurling/botdeployment.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-link-unfurling/review-plus-create.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/bot-page.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/botdeployment.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/adaptive-cards/azure-bot-ui.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/adaptive-cards/bot-home-page.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/adaptive-cards/create-azure-bot.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/adaptive-cards/go-to-resource-card.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/adaptive-cards/validation-pane.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/bots/Azurebotcreate.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/bots/Azurebotresource.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/bots/aadapp.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/bots/createaresourcezurebot.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/calls-and-meetings/CM1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/calls-and-meetings/go-to-resource.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/calls-and-meetings/validation.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meeting-content-bubble/meeting-content-bubble-creating-resource-group.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meeting-content-bubble/meeting-token-generator-botdeployment.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meeting-content-bubble/meeting-token-generator-review-plus-create.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meeting-token-generator/meeting-token-generator-bot-page.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meeting-token-generator/meeting-token-generator-botdeployment.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meeting-token-generator/meeting-token-generator-review-plus-create.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meetings-side-panel/bot-page.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meetings-side-panel/bot-page1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meetings-side-panel/botdeployment.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meetings-side-panel/botdeployment1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meetings-side-panel/review-plus-create.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meetings-side-panel/review-plus-create1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-messagingextension-action/azure bot.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-messagingextension-action/create-azure-bot.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-messagingextension-action/create-azurebot.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-messagingextension-action/created-azure-bot.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-messagingextension-action/resource-file.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/home-png.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/reg-azure-1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/resource-group.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/app-service-create-new.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/blazor-vs-preview2/app-dev-rg-azure.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/blazor-vs2019-publish4.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/blazor-vs2019-publish5.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/blazor-vs2019-publish6.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/blazor/azure.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/blazor/resource-group.PNG
:white_check_mark:Succeeded
View

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 8f2ae95:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/Tab-ME-SSO/app-overview.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Tab-ME-SSO/go-to-resource.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Tab-ME-SSO/register-bot.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-Messaging-Extensions-Search/bot-page.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-Messaging-Extensions-Search/botdeployment.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-Messaging-Extensions-Search/review-plus-create.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-link-unfurling/bot-page.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-link-unfurling/botdeployment.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-link-unfurling/review-plus-create.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/bot-page.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/botdeployment.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/adaptive-cards/azure-bot-ui.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/adaptive-cards/bot-home-page.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/adaptive-cards/create-azure-bot.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/adaptive-cards/go-to-resource-card.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/adaptive-cards/validation-pane.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/bots/Azurebotcreate.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/bots/Azurebotresource.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/bots/aadapp.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/bots/createaresourcezurebot.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/calls-and-meetings/CM1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/calls-and-meetings/go-to-resource.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/calls-and-meetings/validation.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meeting-content-bubble/meeting-content-bubble-creating-resource-group.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meeting-content-bubble/meeting-token-generator-botdeployment.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meeting-content-bubble/meeting-token-generator-review-plus-create.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meeting-token-generator/meeting-token-generator-bot-page.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meeting-token-generator/meeting-token-generator-botdeployment.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meeting-token-generator/meeting-token-generator-review-plus-create.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meetings-side-panel/bot-page.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meetings-side-panel/bot-page1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meetings-side-panel/botdeployment.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meetings-side-panel/botdeployment1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meetings-side-panel/review-plus-create.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/meetings-side-panel/review-plus-create1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-messagingextension-action/azure bot.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-messagingextension-action/create-azure-bot.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-messagingextension-action/create-azurebot.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-messagingextension-action/created-azure-bot.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-messagingextension-action/resource-file.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/home-png.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/reg-azure-1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-file-upload-bot/resource-group.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/app-service-create-new.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/blazor-vs-preview2/app-dev-rg-azure.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/blazor-vs2019-publish4.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/blazor-vs2019-publish5.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/blazor-vs2019-publish6.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/blazor/azure.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/blazor/resource-group.PNG
:white_check_mark:Succeeded
View

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Closing this PR


chore: import repository https://github.com/Sathwik-Anumala/jenkinsx-node-sample.git

this commit will trigger a pipeline to generate the CI/CD configuration which will create a second commit on this Pull Request before it auto merges

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Correction for raw affiliation INRA-UMR 1083 SPO, Montpellier, France

Correction needed for raw affiliation INRA-UMR 1083 SPO, Montpellier, France
raw_affiliation_name: INRA-UMR 1083 SPO, Montpellier, France
new_rors: 05y503v71;04w07sc25
previous_rors: 05y503v71
works_examples: W1978503036
contact: 63fac5328c44d6c2ead3d9f2f58b20b9:891f1b5e094cb3f0f5e1b23ab06a56636831 @ inrae.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-09. The new affiliations should be visible within the next 7 days.


Add a 2nd Solar unit into the Card

I have read the wiki about what to try first before creating a bug report.
Which version of HA do you use? core-2021.5.3
Which version of the card do you use? 0.1.5
Describe the bug
I've two Solar units installed in two different date, FTV Casa and FTV Garage, but I'd like to have both included into the same Power wheel card. Should be great to see both, but in case not possible, at least the total of both.
Configuration of the card
type: 'custom:power-wheel-card'
title: Bilancio energetico
solar_power_entity: sensor.ftv_casa_power
grid_power_entity: sensor.enel_imm_prel_power
debug: false
production_is_positive: true
![Power wheel card](https://user-images.githubusercontent.com/83531973/118276254-b9956780-b4c7-11eb-87f2-5ec6d40d28c0.png)

Many thanks

I labeled it as feature request. In the meantime as some kind of workaround please be aware that it's possible to use more than one power-wheel-card.

Ok, at the moment I've made the below two cards, one for the PV installed on house roof (FTV_Casa) and the secons for the PV installed on the garage roof (FTV_Garage).
Looking forward to receive your updates.

Many thanks, Ale

Hi, Have you done something on they way to include two solar_power entities into the same card??

No, sorry. I'm currently not very active on my custom card.


add useQuery and useMutation hooks

I use these hooks in my projects and I think they can be useful in this lib.
This is a first version, we can imagine improving them with onComplete and onError callbacks to increase the control of the user during his interactions with the db.

@luca-montaigut Thank you very much for this PR! I'll review everything tonight. I'll try to add soon a publish pipeline and versionning mechanism to get these new hooks you did released!

Thank you very much for the contribution. I just want to improve a bit the typings to provide a fully typed experience on the hooks.
I potentially will also introduce these ideas in a current piece of work I am doing if that is fine with you.

Totally agree with you I'm not very proud of these 'any'... But I didn't really know how to do it, I'll dig into the subject.
You can of course use these hooks! I use them for this project: supabase-starter-kit and I intend to rework it with your lib once the hooks are clean and merged.
And then maybe I'll write a little something (like a tutorial or a blog post) about my starter-kit and this lib (plus it's my first contribution to open-source 🎉 )

@luca-montaigut Merci beaucoup pour la contribution!!
I've added useTable but added some features on top of your approach such as generics and SWR capacities. It was a great idea to implement this into the lib. Do you want to try a similar approach to the useMutation and try to add it to the lib?

@luca-montaigut Merci beaucoup pour la contribution!!
I've added useTable but added some features on top of your approach such as generics and SWR capacities. It was a great idea to implement this into the lib. Do you want to try a similar approach to the useMutation and try to add it to the lib?

I managed to type for useQuery but for useMutation I'm missing a little something: typing works for "normal" query (.from) but not for auth (.auth.signUp etc...). Let me know what you thing about this second version 😃
useTable is cool for easily grabbing a whole table =) 💪  good job!
However, I have a few questions (sorry if the answers are obvious but I'm still a junior):
1/ I don't see the point of the useSupabase() vs importing the client => you still have to import something no? (+ the context)
I have the impression that it makes the code less standard compared to the doc, to other projects or stackoverflow answers without a real benefit since the client does not change.
2/ Why import a second fetch lib (SWR)? I think we can manage it without adding another dependency
=> I saw that you didn't put a loading state and that you use !data instead. For the query it's ok but I'm not sure we can do without for the mutation, I tried in a sandbox project and I couldn't manage without it.

@luca-montaigut Here I don't see swr as a fetching library, the fetching implementation is actually left to the user. The goal of the lib really is to get revalidation based on UX usage versus listening to the whole table events that could get expensive the more there are.
We could do away with useSupabase for sure. I'm evaluating if there will be future usage to having a singleton client eventually in context. Not sure yet but I'll keep it for a bit while we explore the topic.
Loading will happen totally for useMutation, I'll incorporate your PR as it is for it actually

@luca-montaigut Here I don't see swr as a fetching library, the fetching implementation is actually left to the user. The goal of the lib really is to get revalidation based on UX usage versus listening to the whole table events that could get expensive the more there are.
We could do away with useSupabase for sure. I'm evaluating if there will be future usage to having a singleton client eventually in context. Not sure yet but I'll keep it for a bit while we explore the topic.
Loading will happen totally for useMutation, I'll incorporate your PR as it is for it actually

Maybe to split the difference with the useSupabase() we can keep it but not force tu usage of hook like useQuery / useTable in the context ?
Do you have an idea to finish typing the useMutation so that this also works:
  const registerWithEmailAndPassword = async (
    email: string,
    password: string,
  ) => {
    execute(
      supabase.auth.signUp({
        email,
        password,
      }),
    );
  };

@luca-montaigut Here I don't see swr as a fetching library, the fetching implementation is actually left to the user. The goal of the lib really is to get revalidation based on UX usage versus listening to the whole table events that could get expensive the more there are.
We could do away with useSupabase for sure. I'm evaluating if there will be future usage to having a singleton client eventually in context. Not sure yet but I'll keep it for a bit while we explore the topic.
Loading will happen totally for useMutation, I'll incorporate your PR as it is for it actually

Maybe to split the difference with the useSupabase() we can keep it but not force tu usage of hook like useQuery / useTable in the context ?
Do you have an idea to finish typing the useMutation so that this also works:
  const registerWithEmailAndPassword = async (
    email: string,
    password: string,
  ) => {
    execute(
      supabase.auth.signUp({
        email,
        password,
      }),
    );
  };

Good idea! I'll check tomorrow for the types and splitting the difference

Hey @gbibeaul , I've added a refetch mecanism on useQuery, it was usefull on my projet.
For typing I still searched but without success. I may not be good enough in TS but I have the impression that there are too many different types possible and that they don't combine with each other


New Extensition: Elegant Cold Extensition

hello, I just release a library make Markwon support more elegant code block style.
see: MarkwonCodeEx

Hey @kingideayou !
Sorry, I must've missed it somehow. I will update README to include your extension (interesting technique to render code spans!)

Hey @noties
Thanks a lot. I am honored to be recommended ! 😬


[MINOR] Add a compaction job in hudi-examples

What is the purpose of the pull request
This diff adds a scala example of a compaction job, in request of https://apache-hudi.slack.com/archives/C4D716NPQ/p1626912143349100
Brief change log
Based on compaction in HoodieWriteClientExample.
Verify this pull request
Manually verified the change locally.
Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Hi @codope Thanks for your contribution. Based on the official contribution guide, this PR is not suitable for the "MINOR" category. You should file a Jira ticket then change the title of the PR.

Hi @codope Thanks for your contribution. Based on the official contribution guide, this PR is not suitable for the "MINOR" category. You should file a Jira ticket then change the title of the PR.

Thanks @yanghua for reviewing. I have edited the title and created an umbrella jira for adding more examples: https://issues.apache.org/jira/browse/HUDI-2224


Default RESTMapper returns stale resources

Bug Report

What did you do?
When applying multiple interdependent resources, e.g. CRD's + CR's, a race condition can result in an infinite loop where cached resources become stale.
What did you expect to see?
I expect to eventually receive the resource I created.
What did you see instead? Under which circumstances?
I kept getting the stale one
Environment

operator-sdk version:
v0.7.0

go version:
1.11.4

Kubernetes version information:
Client Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.3", GitCommit:"721bfa751924da8d1680787490c54b9179b1fed0", GitTreeState:"clean", BuildDate:"2019-02-01T20:08:12Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"12", GitVersion:"v1.12.0", GitCommit:"0ed33881dc4355495f623c6f22e7dd0b7632b7c0", GitTreeState:"clean", BuildDate:"2018-09-27T16:55:41Z", GoVersion:"go1.10.4", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes cluster kind:
minikube

Are you writing your operator in ansible, helm, or go?
go

Possible Solution
Upstream bug: https://github.com/kubernetes-sigs/controller-runtime/issues/321
Additional context
Potential fix: https://github.com/openshift/cluster-network-operator/pull/95

FYI: https://github.com/operator-framework/operator-sdk/issues/1330 is the same problem

This doesn't solve my problem as reported in #1330
After upgrading to 0.8.0, I still see this:
Make sure I'm running 0.8.0:
{"level":"info","ts":1558465126.8952413,"logger":"cmd","msg":"Go Version: go1.12.5"}
{"level":"info","ts":1558465126.8952928,"logger":"cmd","msg":"Go OS/Arch: linux/amd64"}
{"level":"info","ts":1558465126.895298,"logger":"cmd","msg":"Version of operator-sdk: v0.8.0"}
{"level":"info","ts":1558465126.895325,"logger":"cmd","msg":"Watching namespace.","Namespace":"kiali-operator"}

But I still see the error:
{"level":"error","ts":1558465170.3098834,"logger":"proxy","msg":"Could not get rest mapping for: monitoring.kiali.io/v1alpha1, Kind=MonitoringDashboard","error":"no matches for kind \"MonitoringDashboard\" in version \"monitoring.kiali.io/v1alpha1\"","stacktrace":"github.com/operator-framework/operator-sdk/vendor/github.com/go-logr/zapr.(*zapLogger).Error\n\tsrc/github.com/operator-framework/operator-sdk/vendor/github.com/go-logr/zapr/zapr.go:128\ngithub.com/operator-framework/operator-sdk/pkg/ansible/proxy.shouldAddOwnerRef\n\tsrc/github.com/operator-framework/operator-sdk/pkg/ansible/proxy/inject_owner.go:151\ngithub.com/operator-framework/operator-sdk/pkg/ansible/proxy.(*injectOwnerReferenceHandler).ServeHTTP\n\tsrc/github.com/operator-framework/operator-sdk/pkg/ansible/proxy/inject_owner.go:89\ngithub.com/operator-framework/operator-sdk/pkg/ansible/proxy.(*cacheResponseHandler).ServeHTTP\n\tsrc/github.com/operator-framework/operator-sdk/pkg/ansible/proxy/cache_response.go:127\nnet/http.serverHandler.ServeHTTP\n\t/home/travis/.gimme/versions/go1.12.5.linux.amd64/src/net/http/server.go:2774\nnet/http.(*conn).serve\n\t/home/travis/.gimme/versions/go1.12.5.linux.amd64/src/net/http/server.go:1878"}
{"level":"error","ts":1558465170.309941,"logger":"proxy","msg":"Could not determine if we should add owner ref","error":"no matches for kind \"MonitoringDashboard\" in version \"monitoring.kiali.io/v1alpha1\"","stacktrace":"github.com/operator-framework/operator-sdk/vendor/github.com/go-logr/zapr.(*zapLogger).Error\n\tsrc/github.com/operator-framework/operator-sdk/vendor/github.com/go-logr/zapr/zapr.go:128\ngithub.com/operator-framework/operator-sdk/pkg/ansible/proxy.(*injectOwnerReferenceHandler).ServeHTTP\n\tsrc/github.com/operator-framework/operator-sdk/pkg/ansible/proxy/inject_owner.go:92\ngithub.com/operator-framework/operator-sdk/pkg/ansible/proxy.(*cacheResponseHandler).ServeHTTP\n\tsrc/github.com/operator-framework/operator-sdk/pkg/ansible/proxy/cache_response.go:127\nnet/http.serverHandler.ServeHTTP\n\t/home/travis/.gimme/versions/go1.12.5.linux.amd64/src/net/http/server.go:2774\nnet/http.(*conn).serve\n\t/home/travis/.gimme/versions/go1.12.5.linux.amd64/src/net/http/server.go:1878"}


Fails to decode specific sequence

decode(encode(vec![0u8, 223u8, 124u8])) returns None.

Fixed in cfdca9c. Thanks @bondo!


Bech32 & consistent outputs format

This PR adds support for bech32 addresses in the public API. It also makes the SDK always use the Output[] format (not the map[addr]value format) when submitting coinSelection outputs to the server.
Extracted out another function for validating an address against a network, since bech32 addresses should not be used on BCH.

Changes Unknown when pulling af84a49593838ae46860304ab2049ec5493dfa6b on bech32-support into ** on master**.

code style checkers don't agree :/


Python 3.7 as min.  requirement

Add python 3.7 as requirement in setup.py

I was already searching for an answer, so I've submitted PR #42. This seems to be the usual approach.


Shipping API required properties missing

So far, we have encountered the following properties marked as required but not returned in the response in all circumstances:

PackageResults_ShippingLabel.GraphicImagePart
ShipmentResults_Form.Description
ShipmentResults_Form.Code

Thank you for bringing this concern to our attention.  Our technical team is looking into it and will provide a more substantive response shortly.

Hi, our team has taken a look and come to the following conclusion.
- PackageResults_ShippingLabel.GraphicImagePart: Thank you, we have fixed this.
- ShipmentResults_Form.Description: The description and code are always required when the form element is returned; however, the form element is not required to be returned in the ShipmentResults.
- ShipmentResults_Form.Code: The description and code are always required when the form element is returned; however, the form element is not required to be returned in the ShipmentResults.


Why changing GitHub repository language not working?

i have been made a repository in GitHub with as Xcode project with Objective-C language.
Beside .gitignore file in root of my project made .gitattributes file and set this code in it:
* linguist-vendored
*.objective-c linguist-vendored=false

But does not show any language in Github homepage.

Is this repository public?  If so, can you provide a link so we can see what you're seeing.

OHHHhhhhh it's works. with several days delay. @lildude   tnx.

Oh now i was wrong  My repo
It's not working. @lildude

I can't find any .objective-c files in your repository.

.m and .h files
These are not Objective C ?
I had this problem in swift but solved with
* linguist-vendored
*.swift linguist-vendored=false

code ...  @pchaigno @lildude @defunkt

The *.stuff needs to match files. Try:
`* linguist-vendored
*.c linguist-vendored=false
*.h linguist-vendored=false

SOLVED:
I tried this and it's woks.
* linguist-vendored
*.c linguist-vendored=false
*.h linguist-vendored=false
*.c linguist-language=Objective-C
*.h linguist-language=Objective-C
*.m linguist-language=Objective-C

Great!


Add show_output attribute for machine_execute.

I have a machine_execute at the end of my provision recipe that runs system integration tests from a node in the cluster. It's nice to see the output without having to use -l debug. I use chef-provisioning as a developer so that my co-workers can provision their own development clusters and it's cool to run the tests at the end automatically.
I suppose a similar effect could be achieved by capturing the output on the remote server and then downloading and displaying it on the provisioning server...

Hmm, it might be a good idea to mimick the arguments to machine.execute here--what do you think about calling it stream?  I'm a huge :+1: on having an attribute :)

I think stream describes how it actually shows the output as opposed to some sort of buffering, so stream is a better name. :+1:

Renamed to live_stream to better match the Chef ShellOut stuff, and checked in as d99ad1557a1f15fea66e378750b34fc6b5601fd3!  Thanks :)

Awesome!


mysql default charset used for connection

I set up a mysql database with utf8mb4 charset, but when the setup tries to put something in the settings table, the following error is produced:
database error.txt
I believe this is because the database connection is initiated as UTF8 instead of UTF8mb4, despite the usage of emoji in the setup process. As far as I know, emoji requires an UTF8mb4 charset. From the documention of the mysql module:

charset: The charset for the connection. This is called "collation" in the SQL-level of MySQL (like utf8_general_ci). If a SQL-level charset is specified (like utf8mb4) then the default collation for that charset is used. (Default: 'UTF8_GENERAL_CI')

At least I cannot find utf8mb4 being specified anywhere in the code.
So if this is true, would it make sense to initialise the database connection with the proper charset?
Alternatively, the emoji can also be dropped for better compatibility.

According to knex docs, we can only set the charset for MySQL using this library and it has to be done during creation of the tables. That being said and chibisafe shipping with sqlite support by default you could edit the relevant files (4 of them) to add the charset if you really want to use emoji, or drop them as you suggested.

Sets the charset for the database table, only available within a createTable call, and only applicable to MySQL.

I'm in the middle of rewriting chibisafe so I'll take this into account for the next version.

From what I can see, the tables are created with the proper charset:

| settings | CREATE TABLE settings (
key varchar(255) DEFAULT NULL,
value varchar(255) DEFAULT NULL
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 |
I think it has more to do with the database connection used with the mysql module and not knex, but I am not well versed in these kind of things.
After I removed the emoji from some files, the setup runs correctly. Thanks for the suggestion.

Glad you could sort it out, I'll keep an eye for this in the rewrite.
Since most people use chibisafe with sqlite or postgresql this hasn't been brought up until now, so thanks for letting me know!


strange problem when i use when and otherwise

strange problem happened that when condition is fulfilled, expression 1 executed but expression 2 also executed.
when(condition) {
   expression 1
} .otherwise{
   expression 2
}

You'll need to show us a lot more code than that to get an idea of what the issue could possibly be.
Are you by chance using var variables in combination with the scala = assignment inside of your when/otherwise statements?

A full example showing what you are doing may help, but I'm guessing that you may be getting confused between elaboration and the actual generated hardware as well as what is a Chisel type and what is a Scala type. Taking a stab, but possibly in the wrong direction.
Every statement inside a Chisel module, that would follow the normal execution of a Scala program is executed. The internals of a Chisel module are the description of what you want your hardware to look like. In you specific example you're describing a mux keyed by a condition. when and .otherwise are parts of Chisel. These are not the same as if and else which are Scala constructs.
Consider the following simple module. This mixes println (a Scala print) inside when/otherwise. During elaboration, both printlns print, but you wind up getting the correct hardware.
class FooIO extends Bundle {
  val a: Bool = Input(Bool())
  val b: Bool = Output(Bool())
}

class Foo extends Module {

  val io: FooIO = IO(new FooIO)

  val isTrue: Bool = io.a === true.B
  val notA: Bool = ~io.a

  when (isTrue) {
    println("[info] elaborate true condition")
    io.b := io.a
  } .otherwise {
    println("[info] elaborate otherwise condition")
    io.b := notA
  }

}

This then produces the following log text:
[info] [0.003] Elaborating design...
[info] elaborate true condition
[info] elaborate otherwise condition
[info] [0.120] Done elaborating.
Total FIRRTL Compile Time: 903.5 ms

And the following Verilog:
module Foo(
  input   clock,
  input   reset,
  input   io_a,
  output  io_b
);
  wire  notA;
  assign notA = ~ io_a;
  assign io_b = io_a ? io_a : notA;
endmodule

There's a similar StackOverflow question/answer that may help shine some light on this.

@ccelio @seldridge Thanks for reply. The code is here. I want to assign inputs_pad when row or col is not zero, in which case the index of io.inputs can not be out of bounds. But when elaborating, it will execute this assignment "inputs_pad(idx) := io.inputs(idx_in)",but when row = 0 ,the idx_in is negative. so it gives the error message
java.lang.IndexOutOfBoundsException: -6

code is here
  val in_pad_width = 2*pad + width
  val in_pad_height = 2*pad + height
  val inputs_pad = Reg(Vec(in_pad_width * in_pad_height, UInt(w.W)))

  for (row <- 0 until in_pad_height){
     for (col <- 0  until in_pad_width){
         val idx = row * in_pad_width
         when(row.asUInt(w.W) === 0.U || col.asUInt(w.W) === 0.U ){
             inputs_pad(idx) := 0.U
             //println(s"true, row = $row, col = $col ")
         }.otherwise{
             val idx_in = (row-1) * width + col - 1
             inputs_pad(idx) := io.inputs(idx_in)
             //println(s"false, idx_in = $idx_in, row = $row, col = $col ")
         }
     }
  }

Here's my best guess at what you are trying to do, in particular I am guessing at the structure of your inputs. This should still provides some help even if I got this assumption wrong
class PadProblem(pad: Int, width: Int, height: Int, w: Int) extends Module {
  val in_pad_width  = 2*pad + width
  val in_pad_height = 2*pad + height
  val padSize = in_pad_width * in_pad_height

  val io = IO(new Bundle {
    val inputs = Vec(width * height, Input(UInt(w.W)))
  })

  val inputs_pad    = Seq.fill(in_pad_width * in_pad_height){ Reg(UInt(w.W)) }

  for (row <- 0 until in_pad_height) {
    for (col <- 0  until in_pad_width) {
      val idx = (row * in_pad_width) + col

      if(row == 0 || col == 0 || row == in_pad_height - 1 || col == in_pad_width - 1) {
        println(s"padding at ($row,$col) idx $idx")
        inputs_pad(idx) := 0.U
      }
      else {
        val idx_in = ((row-1) * width) + (col - 1)
        println(s"connecting ($row, $col) $idx from $idx_in")
        inputs_pad(idx) := io.inputs(idx_in)
      }
    }
  }
}

Notes

It seems like you creating a 2d set of registers that are mapped to a 2d set of inputs
The set of registers are padded around the outside

The pad registers are initialized to 0.U

Unless you need to use hardware addressing of a structure you do not need to create a Vec

Instead just keep track of them using Scala structures

You do not need when, instead you need to conditionally construct hardware

That means use scala if
println helps show how it initializes during construction

The above elaborates correctly given my assumptions
Let me if this helps

This is an extra refinement of the code above. Assuming in fact what is going on here is some 2 dimensional mapping of inputs into a register array, you should take advantage of the ability to represent the problem in a 2D fashion in your code. I think it makes this easier to read and easier to reason about. Here is an example of the same Module but written in 2D model.
class PadProblem2D(pad: Int, width: Int, height: Int, w: Int) extends Module {
  val in_pad_width  = 2*pad + width
  val in_pad_height = 2*pad + height

  val io = IO(new Bundle {
    val inputs = Vec(height, Vec(width, Input(UInt(w.W))))
  })

  val inputs_pad    = Seq.fill(in_pad_width, in_pad_height){ Reg(UInt(w.W)) }

  // put zeros around edges
  // first do bottom and top row
  inputs_pad.head.foreach { cell => cell := 0.U }
  inputs_pad.last.foreach { cell => cell := 0.U }
  // do first and last column
  inputs_pad.indices.foreach { index =>
    inputs_pad(index).head := 0.U
    inputs_pad(index).last := 0.U
  }

  // wire the interior of the padded registers to the inputs
  for (row <- 0 until height) {
    for (col <- 0  until width) {
      inputs_pad(row + 1)(col + 1) := io.inputs(row)(col)
    }
  }
}

Note:

I have made the inputs a Vec of Vecs (2D)
I have used Seq.fill in a 2D context to create the register array
I initialize the outside of the register array using scala seq methods
The interior of the register array is more neatly described using 2d indexing
The generated firrtl is not any shorter but the final names are more readable as 2D indices
You could also rely on Chisel's last connect semantics to initialize them all to zero

your later connects would override the zeros in the interior of the register array
note the RegInit instead of Reg
you could then remove the `//put zeroes around the edges`` code section

  val inputs_pad    = Seq.fill(in_pad_width, in_pad_height){ RegInit(0.U(w.W)) }

One further thought. This is a good question, but as a question (as opposed to an issue or problem with Chisel) It would probably be better to ask it on StackOverflow and tag it with the #chisel tag. For questions stackoverflow makes the answers a bit easier to find for other users experiencing similar questions. We regularly monitor stackoverflow and try to answer promptly
-cheers

@chick Thanks very much for your help. Great help for me. and I also found my error in my code. Thank you very very very much :)

One further thought. This is a good question, but as a question (as opposed to an issue or problem with Chisel) It would probably be better to ask it on StackOverflow and tag it with the #chisel tag. For questions stackoverflow makes the answers a bit easier to find for other users experiencing similar questions. We regularly monitor stackoverflow and try to answer promptly
-cheers

@chick OK. I will ask question on StackOverflow next time.Thank you very much.


Added API to get server users list from backend DB

:nut_and_bolt: Description: What code changed, and why?
List the users in a server from back end DB

:chains: Related Resources
https://github.com/chef/automate/issues/5732
:+1: Definition of Done
I have added API to list the users in a server from back end DB
:athletic_shoe: How to Build and Test the Change
Steps to build:
rebuild components/infra-proxy-service
rebuild components/automate-gateway

Steps to test:

Ensure Chef Infra Server is running. If it is not start it with start_chef_server
Add the chef-server test environment credentials and extract the SERVER IDs

Request
curl -sSkH "api-token: $(get_admin_token)" 'https://a2-dev.test/api/v0/infra/servers/SERVER_ID/automateinfraserverusers'
Response
{
    "users": [
        {
            "id": "123",
            "server_id": "local-dev",
            "infra_server_username": "Infrauser1",
            "credential_id": "145",
            "connector": "local",
            "automate_user_id": "autouser1",
            "is_server_admin": false
        },
        {
            "id": "321",
            "server_id": "local-dev",
            "infra_server_username": "Infrauser2",
            "credential_id": "147",
            "connector": "local",
            "automate_user_id": "autouser2",
            "is_server_admin": true
        }
    ]
}

:white_check_mark: Checklist
All PRs must tick these:

[x] I have read the CONTRIBUTING document.
[x] All commits signed-off for the Developer Certification of Origin.

With occasional exceptions, all PRs from Progress employees must tick these:

[x] Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
[x] Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
[x] Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
[x] Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
[x] Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

[ ] Tests added/updated? (all new code needs new tests)
[ ] Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.
:camera: Screenshots, if applicable

We need to add unit tests, integration tests and test scripts. @vinay033  Please create issues for these and @sonali523 please make sure we take it up in the upcoming sprints.


how to train a seg mentation model

thank you

Thanks for your attention. The segmentation repo is re-organizing for the release.


String.localeCompare crashes in Node mode

When running in Node mode, String.localeCompare will crash the process, see also https://github.com/atom/atom/issues/4725.

@zcbenz, any movement on this?  I can't release the next version of atom-typescript-tools without it.

@zcbenz,  ha you beat me too it I got it in my head to try and fix this getting as far as discovering it was the ICU that was not quite set up correctly.  Thanks for so much for fixing this.  Perhaps I will win the race next time, now that I went to all the trouble to learn how to compile and debug the project :)


Repository create forbidden

PAC 0.4.3
As a project administrator I can't create a repository. A cluster administrator must first add my user to openshift-pipeline-as-code-clusterrole.
$ oc project ocpapp-pac-utv
Now using project "ocpapp-pac-utv"

$ oc auth can-i create secret
Yes

$ tkn-pac repository create
? Enter the namespace where the pipeline should run (default: ocpapp-pac-utv):
? Enter the Git repository url containing the pipelines (default: https://git.se/myuser/pac-demo-2):
? Enter the target GIT branch (default: main):
? Enter the Git event type for triggering the pipeline:  pull_request
Error: repositories.pipelinesascode.tekton.dev is forbidden: User "MYUSER" cannot create resource "repositories" in API group "pipelinesascode.tekton.dev" in the namespace "ocpapp-pac-utv"

MYUSER isn’t a cluster administrator and I presume that pipelines as code must work for user != cluster admins?
So far we have solved it by adding role to user MYUSER:
$ oc policy add-role-to-user openshift-pipeline-as-code-clusterrole MYUSER

UPDATE:
After adding role to user MYUSER the error above remains. We also hade to add "create" to ClusterRole openshift-pipeline-as-code-clusterrole:
  - apiGroups: ["pipelinesascode.tekton.dev"]
    resources: ["repositories"]
    verbs: ["get", "list", "update", "create"]

Before adding create:
$ oc auth can-i create repository
no

After adding create:
$ oc auth can-i create repository
yes

I think we addresses this in operator release.

Still seems to be a problem
As namespace admin
$ tkn-pac create repository
? Enter the Git repository url (default: https://gitlab.internal/repo):
? Please enter the namespace where the pipeline should run (default: repo):
✓ Repository repo has been created in repo namespace
Error: could not detect Pipelines as Code configmap on the cluster, please reinstall

As cluster-admin
$ oc get cm -n openshift-pipelines
NAME                            DATA   AGE
config-artifact-bucket          0      59d
config-artifact-pvc             0      59d
config-defaults                 2      59d
config-defaults-triggers        2      59d
config-leader-election          3      59d
config-logging                  3      59d
config-logging-triggers         4      59d
config-observability            5      59d
config-observability-triggers   1      59d
config-registry-cert            0      59d
config-service-cabundle         1      59d
config-trusted-cabundle         1      59d
feature-flags                   9      59d
feature-flags-triggers          2      59d
kube-root-ca.crt                1      721d
openshift-service-ca.crt        1      636d
pipelines-as-code               7      59d
pipelines-as-code-info          3      59d
pipelines-info                  1      59d
triggers-info                   1      59d


Fix ShowOnShift

Resolved / Related Issues
The functionnality ShowOnShift is bugged.
The expected behavior of ShowOnShift is to show the command only if shift is pressed.
The real behavior of ShowOnShift is to show the command in More when Shift is not pressed.
This is the cause of #4850.
Details of Changes
When Shift is not held, the items with ShowOnShift are not displayed.
Else the items are displayed, in the main or more menu, depending on the settings.
Validation
How did you test these changes?

[ ] Built and ran the app
[ ] Tested the changes for accessibility

@winston-de the second chart is closer to the expected behavior, the only difference is that it shouldn't automatically be moved to the overflow menu when it's turned on. It should only move to the overflow menu if there are more than three items before it.

Hiding ShowOnShift items entirely when shift isn't held makes them inaccessible to touch users. There were also issues where users were unable to find the "pin to start" menu item because they did not realize they had to hold shift to be able to see it. That's why ShowOnShift items were moved to the overflow menu instead of being hidden in the first place (see here).
I would suggest something more like this to help avoid confusion about when items are shown and to keep features accessible when using a touchscreen.

Move items to overflow enabled
Move items to overflow disabled

Shift pressed
shown
shown

Shift not pressed
shown in overflow
shown

@winston-de That looks like a satisfactory solution.

@yaichenbaum @winston-de Ok, I do it tomorrow.

@yaichenbaum @winston-de The branch is commited.


[BUG]

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?

i have this problem i cant fix  can anyone help us?

Send the log file

Issue has been awaiting clarification for over a month, closing as stale. If you have anything further to add, just respond and I'll reopen


Link region dashboard links to briefing pages

Link the club/league etc links in the info boxes of the region dashboard to the relevant briefing pages (instead of dashboards)

and allow to copy club / league member addresses to clipboard by clicking on a member info box


Add automated golint on pull requests

Problem
Automated golint on pull requests
Solution
Add golint to travis.yml

#dibs

#dibs next...

PR submitted (https://github.com/docker/swarm/pull/514), but depends on Issue #500 before it can be merged. If there is no PR by @peggyl (no rush :) ) maybe we can knock that out together @gegere ?

@technolo-g @gegere Sorry for the delayed response; a few other things came up this week and I didn't get a chance to revisit this after the Docker SF event on Wednesday.
I started on #500 but so far have mostly fixed the naming/casing issues. The remaining golint fixes are for adding comments on exported functions and variables, which is a bit more non-trivial since it requires reading enough of the source code to include accurate/helpful comments. Still working on this, but I'll open a PR for what I have tonight and comment on #500 so others can work on it as well. Might be easier to split it up by package?

@technolo-g @peggyl I am still pretty new to Go and thought this would be something I could tackle at the hackathon. Any chance a future hangout would work and explain a few details. Happy to be a grunt, need to take on some more knowledge. Thanks!


Export Mist playback statistics

Data currently gets logged so should be available through Loki, not much else to do on the Mist side


docs: use em dash instead of ellipsis for text continuation

Only made the change in a couple of files, looking for more feedback before changing other files as well.
Basically there's a bit of noise when grepping for '...' looking for instances of rest parameters, using the em dash seems a bit visually cleaner as well. I'm not sure if I want to get into discussions on whether it has the correct semantics or not, but it seems to be at least as applicable as the ellipsis for these cases.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

This really doesn't seem like the correct punctuation to me. You can grep ...] rather than. ...


Generate Readme.md

Did some refactoring to generalize the generator... probably going to break into another PR.
Closes #???
Description

For contributor use:

[ ] Targeted PR against master branch
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
[ ] Code follows the standards mentioned here
[ ] Updated relevant documentation
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Added appropriate labels

Codecov Report
Attention: Patch coverage is 61.58940% with 58 lines in your changes missing coverage. Please review.

Project coverage is 29.56%. Comparing base (3b885aa) to head (e85b77e).

Files with missing lines
Patch %
Lines

internal/super/generator/generator.go
70.90%
8 Missing and 8 partials :warning:

internal/super/setup.go
0.00%
14 Missing :warning:

internal/super/generate.go
0.00%
9 Missing :warning:

internal/super/generator/contract_template.go
78.04%
7 Missing and 2 partials :warning:

internal/super/generator/test_template.go
66.66%
4 Missing :warning:

internal/super/generator/script_template.go
70.00%
3 Missing :warning:

internal/super/generator/transaction_template.go
70.00%
3 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1762      +/-   ##
==========================================
- Coverage   29.65%   29.56%   -0.09%
==========================================
  Files          89       94       +5
  Lines        5197     5175      -22
==========================================
- Hits         1541     1530      -11
+ Misses       3469     3466       -3
+ Partials      187      179       -8

Flag
Coverage Δ

unittests
29.56% <61.58%> (-0.09%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix Node package.json

Trailing commas are disallowed in JSON.
Also fixes indenting, capitalizes GoogleCloudPlatform org correctly.

Codecov Report

Merging #1282 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1282   +/-   ##
=========================================
  Coverage     86.41%   86.41%
  Complexity     3812     3812
=========================================
  Files           374      374
  Lines         15173    15173
  Branches       1696     1696
=========================================
  Hits          13112    13112
  Misses         1609     1609
  Partials        452      452

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d3d4cb...5ccc52e. Read the comment docs.


disk method support error

disk support error

Thanks for this change.
A big feature that makes go-journal interesting is the fact that it's verified correct, with a corresponding specification and proof in the perennial repo (https://github.com/mit-pdos/perennial).  I don't think we would want to change that, at least for the master branch, so I expect we wouldn't merge changes without a corresponding updated proof.  Updating the proof can require a fair bit of background, though..


segmentedControl may disappear under a translucent navigation bar

Hi,
my navigationBar is translucent and when I scroll down my tableview, the segmentedControl may disappear under the navigationBar

Sorry guys, I've fixed deselecting "Extend edges: under top bars" checkbox from my ViewController


Example/Documentation

give an example of how and where to start using the importer

There are two examples of this in GenSSI:
https://github.com/genssi-developer/GenSSI/blob/master/Examples/BIOMD0000000003/runBIOMD0000000003.m
https://github.com/genssi-developer/GenSSI/blob/master/Examples/BIOMD0000000010/runBIOMD0000000010.m


Update community-hub-release-parent POM to 1.3.1

For folks using the community-hub-release-parent POM, an update is required because we recently moved from Nexus to Artifactory (learn more here). Please make sure you are using version 1.3.1 to avoid failed deployments.

Hello again! You will also need to update to your GitHub release Action to the latest release -- right now, v. 1.2.1 -- to make sure your Action works.


functional crates (no more plungers)

FM, Taros and Boosts awards from killing mobs should be pretty accurate now. A temporary formula for adjusting player/mob level gap is implemented, but it will probably need to be adjusted in the future

Mobs now drop correct crates

Crates can be opened and give you correct items
This includes regular mob crates, world boss crates, mission crates, IZ race crates, E.G.G.E.R.s, golden Eggs, and Event Crates.
Keep in mind that neither IZ races or golden Eggs are implemented, but if you spawn such a crate it can be opened.

All data is read from a json file, for which I'm going to release a tool soon so it's easily adjustable

There is a new setting for enabling events, which enables dropping extra event crates
These are Knishmas, Halloween and Easter

Merged manually in dd546686


Don't you have some roadmap to transform a normal play proyect in a mavenized one

Hi,
Our company developed a play 1.4.3 project, and now our client requires to put it in some maven managed environment.
I've seen your project https://github.com/play1-maven-plugin/play1-maven-plugin, the project for mavenizing, i've created the pom.xml, and i'm finding some troubles, first the compiler version (we are using java 8), missing libraries.. ¿ Don't you have some roadmap to transform a normal play proyect in a mavenized one ?
Thanks
Hans

There is no roadmap, nobody asked for it before.
Generally, Play! Framework 1.x is not particularly Maven friendly. That's why pom files are very verbose and that was the reason to create default parent poms.
To set compiler version to 1.8 add:
                <plugin>
                    <groupId>org.apache.maven.plugins</groupId>
                    <artifactId>maven-compiler-plugin</artifactId>
                    <configuration>
                        <source>1.8</source>
                        <target>1.8</target>
                    </configuration>
                </plugin>

to pom.xml file and:
java.source=1.8

to conf/application.conf file.
Tell me about your other troubles here.


Can Not Install v1.3.2 In Blender 3.3.X

Current Behavior

Downloaded "io_scene_gltf2_msfs.zip" from the github/Releases/1.3.2/Assets page
Opened Blender 3.3.7 (I also tried in v3.3.2)
Opened Edit/Preferences/Addons/Install
Chose file " io_scene_gltf2_msfs.zip" in my Downloads folder
Searched for "msfs" in the installed addons list with nothing found
The addon is not on the list
I looked in location   C:\Users****\AppData\Roaming\Blender Foundation\Blender\3.3\scripts\addons
Folder "io_scene_gltf2_msfs" is located there and everything is intact inside.

I also attempted to install the addon using the alternate method by manually placing the folder and I have the exact same results.

I have been working on this for 3 days now. I tried rebooting the PC after doing the install. I've tried several Blender 3.3.x versions but none work.

Expected Behavior

Downloaded "io_scene_gltf2_msfs.zip" from the github/Releases/1.3.2/Assets page
Opened Blender 3.3.7 (I also tried in v3.3.2)
Opened Edit/Preferences/Addons/Install
Chose file " io_scene_gltf2_msfs.zip" in my Downloads folder
After instal complete enable the addon

Steps To Reproduce
Same as Current behavior
Environment
- OS: Win 11
- Blender: 3.3.7
- glTF-Blender-IO-MSFS: 1.3.2

Anything else?

Hi, you have to push the install in Blender Preferences, then choose zip File and install.
Dont forget to activate after.

That's exactly what my step #3 shows I did. Continue reading the steps.

Solved:
This issue was caused by my PCMatic AintiVirus not being disabled


Decrease input font size at small breakpoint

Type
🐛 Bugfix

[x] Demoed to @Heesoomoon

Value
Enables more characters to fit on screen (e.g. 'Search image collections' placeholder text isn't cut off at 320px wide).
Screenshot

Mergin, I'll get it out with my deploy.


Fine-tuned Mistral 7B model always gets reported as torch_dtype Float32 in config.json

Please check that this issue hasn't been reported before.

[X] I searched previous Bug Reports didn't find any similar reports.

Expected Behavior
Config.json that reports the correct torch d_type.
Current behaviour
Hi,
I'm having a little trouble and I'm not sure if it's a bug or just my own ignorance. I'm fine-tuning Mistral 7B on either 2 or 3 A100s on RunPod. Whenever I do a full fine-tune the config.json at the end reports the torch d_type as "float32" even though I have set it to bf16 in my config.yml. However, if I use Deepspeed the config.json has the correct torch d_type "bfloat16" at the end.
I'm not sure if this is having any bearing on the end model. I don't think so? But I'd like to understand what's going on, as other people don't seem to have float32 in their configs.
Thanks.
Steps to reproduce

Run a full fine-tune on Mistral 7B with multi-GPUs on Runpod, not using Deepspeed.

Config yaml
base_model: mistralai/Mistral-7B-v0.1
model_type: MistralForCausalLM
tokenizer_type: LlamaTokenizer
is_mistral_derived_model: true

load_in_8bit: false
load_in_4bit: false
strict: false

datasets:
  - path: /workspace/axolotl/datasets/ConversationalShuffledUpdated.jsonl
    type: orcamini

dataset_prepared_path:
val_set_size: 0.015
output_dir: ./out

sequence_len: 4096
sample_packing: false
pad_to_sequence_len: false

wandb_project: Mistral
wandb_entity:
wandb_watch:
wandb_run_id:
wandb_log_model:

gradient_accumulation_steps: 2
micro_batch_size: 2
eval_batch_size: 2
num_epochs: 5
optimizer: adamw_bnb_8bit
lr_scheduler: cosine
learning_rate: 0.000005

train_on_inputs: false
group_by_length: false
bf16: true
fp16: false
tf32: false

gradient_checkpointing: true
early_stopping_patience:
resume_from_checkpoint:
local_rank:
logging_steps: 1
xformers_attention:
flash_attention: true

warmup_steps: 10
eval_steps: 50
eval_table_size:
eval_table_max_new_tokens:
eval_sample_packing: false
save_steps:
save_total_limit: 4
debug:
deepspeed:
weight_decay: 0.0
fsdp:
fsdp_config:
special_tokens:
  bos_token: "<s>"
  eos_token: "</s>"
  unk_token: "<unk>"

Possible solution
No response
Which Operating Systems are you using?

[X] Linux
[ ] macOS
[ ] Windows

Python Version
3.10
axolotl branch-commit
main
Acknowledgements

[X] My issue title is concise, descriptive, and in title casing.
[X] I have searched the existing issues to make sure this bug has not been reported yet.
[X] I am using the latest version of axolotl.
[X] I have provided enough information for the maintainers to reproduce and diagnose the issue.

Hello, could you please try it on latest to see if problem still occurs?
Mine seems to be fine (with a different lora config).
  "torch_dtype": "bfloat16",

I've tried it pretty recently (a few days back) and still had the issue. I will try it with the latest pull.
This problem does not occur with lora or qlora training. It is specific to when I do a full fine-tune of Mistral 7B without Deepspeed. With Deepspeed 2 or 3 enabled the config.json of the outputted model reports the dtype correctly as bfloat16.

I’ve tried it pretty recently (a few days back) and still had the same issue. I will try it with the latest pull.
This problem does not occur with lora or QLoRA training. It is specific to when I do a full fine-tune of Mistral 7B without Deepspeed. With Deepspeed 2 or 3 enabled the config.json of the outputted model reports the dtype correctly as bfloat16.

Ok, I can reproduce this now with a full finetune. Leaving this config for repo
base_model: openaccess-ai-collective/tiny-mistral
flash_attention: true
sequence_len: 1024
bf16: true
lora_r: 32
lora_alpha: 64
lora_dropout: 0.05
lora_target_linear: true
val_set_size: 0.1
special_tokens:
  unk_token: <unk>
  bos_token: <s>
  eos_token: </s>
datasets:
  - path: mhenrichsen/alpaca_2k_test
    type: alpaca
num_epochs: 2
micro_batch_size: 2
gradient_accumulation_steps: 1
output_dir: temp_dir
learning_rate: 0.00001
optimizer: adamw_torch
lr_scheduler: cosine
max_steps: 20
save_steps: 10
eval_steps: 10
dataset_processes: 1

Could be due to this casting:
https://github.com/OpenAccess-AI-Collective/axolotl/blob/3678a6c41d051ca6376d013c11c948e55b4c8b4f/src/axolotl/utils/models.py#L519-L528
and not casting it back https://github.com/OpenAccess-AI-Collective/axolotl/blob/3678a6c41d051ca6376d013c11c948e55b4c8b4f/src/axolotl/utils/models.py#L549-L558

Yes, that was it.
Changing to this resolved it:
# LlamaRMSNorm layers are in fp32 after kbit_training or full finetune, so we need to
    # convert them back to fp16/bf16 for flash-attn compatibility.
    if needs_fa2_dtype or (cfg.flash_attention and (cfg.is_llama_derived_model or cfg.is_mistral_derived_model)):
        LOG.info("converting modules to %s for flash attention", cfg.torch_dtype)
        for name, module in model.named_modules():
            if "norm" in name:
                module.to(cfg.torch_dtype)
            if "lm_head" in name or "embed_tokens" in name:
                if hasattr(module, "weight"):
                    module.to(cfg.torch_dtype)

Interestingly, I think the loss profile of the training run I did with this was different, so it may have been having an effect on output. Still need to check how it goes in inference. Thanks for your help.

I also got a bit different loss, but it was within 0.05.
A side effect of this issue is that weights are stored in fp32, which isn't necessary. I have opened a PR to address this for Mistral. I haven't tried other models.

Yes, loss changes are minimal. Big gains in VRAM efficiency with flash attention and BF16 working correctly though. I’ve been able to move up to a global batch size of 16 on a fft of Mistral 7B compared with 4 previously.

That PR was merged. Closing this.


Packages: create new react package

Context

Summary
Move some of the code from design-system and edit-story to /packages/react/src/
This includes but is not limited to:

useBatchingCallback
useWhyDidYouUpdate
createContext and the like from use-context-selector
useContextSelector
useCombinedRefs
useReduction
useUnmount
usePrevious
useDebouncedCallback

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

QA

[x] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

UAT

[x] UAT should use the same steps as above.

This PR can be tested by following these steps:

Reviews
Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

[x] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[x] I have tested this code to the best of my abilities
[x] I have verified accessibility to the best of my abilities (docs)
[x] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[x] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[x] I have added documentation where necessary
[x] I have added a matching Type: XYZ label to the PR

Fixes #8159

Some minor merge conflicts now

Some minor merge conflicts now

Again 🙈

Again 🙈

That package.lock is killing me. Merged main now.


Subscription page integration

Addresses:

#156

Changes

Subscription Detail

Depends

https://github.com/IFRCGo/alert-hub-web-app/pull/173

This PR doesn't introduce:

[x] typos
[x] conflict markers
[x] unwanted comments
[x] temporary files, auto-generated files or secret keys
[x] console.log meant for debugging
[x] codegen errors

Code added in https://github.com/IFRCGo/alert-hub-web-app/pull/173


flock() not getting file handle all the time

Removed the assumption of successful file handle acquisition while trying obtain a lock on a cache file. This has caused the following errors to pop up in my logs:
flock() expects parameter 1 to be resource, boolean given
In other words we shouldn't try and get a lock on a file we can't open. I suppose the eventual solution would be to find why the file can't be opened in the first place, but, this only happens occasionally so it might be some kind of race condition or something.

Looks good, thanks!


Feature/GitHub action

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Make sure that extended/implemented classes are initialized first

This should ensure that dependencies are loaded in the correct order
by recursively setting the rank accordingly
Followup of #742 addressing #702
This seems to work so far, needs some testing

@ovr
Tested it so far with

pretty big (private) project
the mentioned testcase of #702
an autogenerated random testbase ( https://gist.github.com/steffengy/67b6b2af2efeaf0d0a26 )

Any other ideas?
Until now everything seems to work perfectly.

@phalcon @andresgutierrez
Could you take a look at this?

This PR is bugged
https://github.com/owl-framework/owl
PHP Notice:  Undefined index: \Exception in /Users/ovr/projects/zephir/zephir/Library/Compiler.php on line 1558

Notice: Undefined index: \Exception in /Users/ovr/projects/zephir/zephir/Library/Compiler.php on line 1558
PHP Warning:  Invalid argument supplied for foreach() in /Users/ovr/projects/zephir/zephir/Library/Compiler.php on line 1558

Warning: Invalid argument supplied for foreach() in /Users/ovr/projects/zephir/zephir/Library/Compiler.php on line 1558
PHP Notice:  Undefined index: \Exception in /Users/ovr/projects/zephir/zephir/Library/Compiler.php on line 1558

Notice: Undefined index: \Exception in /Users/ovr/projects/zephir/zephir/Library/Compiler.php on line 1558
PHP Warning:  Invalid argument supplied for foreach() in /Users/ovr/projects/zephir/zephir/Library/Compiler.php on line 1558

Warning: Invalid argument supplied for foreach() in /Users/ovr/projects/zephir/zephir/Library/Compiler.php on line 1558

And Phalcon 2....
Please fix notices, and retest it

@ovr
the warnings should be fixed, it was just a minor missing check.

@steffengy
:+1:
And please add a test case from #702

@ovr
I'm not quite sure where to place the files.
Would "test/ooimpl" be appropriate?
(Since it seems to have similiar tests testing extend functionality)

@ovr
Hopefully the files are located fine there :)

@steffengy

Would "test/ooimpl" be appropriate?

Yeap

@ovr
test/ooimpl is not appropriate :)
(since it is for interfaces where implements functionality is tested)
I think they are fine, where I put them though :)
Hopefully now the formatting is alright now...

@ovr
Hopefully this won't be as much commit spam as the phalcon repository received issues xD
But now it hopefully is correct xD

Tested on projects:
Phalcon 2
Ice
Owl
Thank you @steffengy for this PR :+1:

Changes Unknown when pulling c837d084488778504cee92de0e62014a36542828 on steffengy:fix_initorder into ** on phalcon:master**.


Not aligned after smoothing

After smoothing the smpl results will be not aligned.

And my code is:
def export_smpls_group_npy(dir_path):
    smpls_save_path = join(dir_path, 'new_smpls')
    os.makedirs(smpls_save_path, exist_ok=True)
    obj = bpy.data.objects[OBJ_NAME]
    arm_ob = bpy.data.objects[ARM_OBJ_NAME]
    scene = bpy.data.scenes['Scene']
    obname = "m_avg"

    for frame in range(scene.frame_start, scene.frame_end):
        smpl, cam = reverse_blender_para_to_smpl(obj, arm_ob, obname, bpy.data.scenes['Scene'], frame=frame)
        betas = torch.tensor(smpl['betas'], dtype=torch.float32)
        global_orient = torch.tensor(smpl['global_orient'], dtype=torch.float32)
        body_pose = torch.tensor(smpl['body_pose'], dtype=torch.float32)
        smpl_output = model.smpl(betas=betas, global_orient=global_orient, body_pose=body_pose, pose2rot=False)
        smpl_outs = {
            'global_orient': smpl['global_orient'],
            'betas': smpl['betas'],
            'body_pose': smpl['body_pose'],
        }
        pred_vertices = smpl_output.vertices.reshape(1, -1, 3)
        all_verts = []
        all_cam_t = []
        for n in range(pred_vertices.shape[0]):
            verts = pred_vertices[n].detach().cpu().numpy()
            all_verts.append(verts)
            all_cam_t.append(cam)

        img_size = 256.0

        scaled_focal_length = np.array(5000.0)

        results_dict_for_rendering = {
            "verts": all_verts,
            "cam_t": all_cam_t,
            "render_res": np.array([img_size, img_size]),
            "smpls": smpl_outs,
            "scaled_focal_length": scaled_focal_length,
        }

        frame_save_path = join(smpls_save_path, f"frame_{frame:05d}.npy")
        np.save(frame_save_path, results_dict_for_rendering)

Could anyone told me what is wrong?

I found I forgot to reverse the Y-axis. It is solved now.
for n in range(pred_vertices.shape[0]):
            verts = pred_vertices[n].detach().cpu().numpy()
            all_verts.append(verts)
            cam[1] *= -1
            all_cam_t.append(cam.astype(np.float32))

https://github.com/user-attachments/assets/1963e45f-917e-4ca6-bbf4-1d7c0c64ff57


fix: build audio classifier for armv7

fix the build error.
https://github.com/homuler/MediaPipeUnityPlugin/actions/runs/7725698637

I confirmed that python build.py build --android armv7 --bazel_build_opts="--copt='-mfpu=neon'"  worked, so close this PR.


CSS variables approach in components not the best one

For those who just want to customize BS using the provided CSS variables, they face a problem.
Since the generated variable values are concrete values, overriding component styles forces to a duplication of CSS code for each of the components to restyle and it's variants and also, a deep understanding of how the components mix with each other.
Why are these values being set as concrete values instead of using the color variables?
if color variables were used in components, changing colors across all of them would only require to change the color variables avoiding CSS like
.btn-primary {
--bs-btn-bg: red;
}
.btn-info {
--bs-btn-bg: green;
}
Even some base BS variables use concrete values instead of color variables:
--bs-primary: #0d6efd; instead of --bs-primary: var(--bs-blue);
If the issue for not using color variables is because you need to generate lighter or darker colors, you can also do that using just CSS:
Check this example of darkening a color set in a variable and using it on hover state
What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
Microsoft Edge
What version of Bootstrap are you using?
5.2.3

Yes, this has been covered in our blog posts and issues—we're limited by backwards compatibility in changing key components like buttons and more. We're also limited by color manipulation in vanilla CSS vs Sass.