[WFLY-6776] Unclear error message when creating multiple thread pools of the same type for a workmanager

Jira: https://issues.jboss.org/browse/WFLY-6776

@jesperpedersen @maeste  Could you please review this? Thank you!

Just fix @ctomc comments. Otherwise LGTM

Linux with security manager Build 4863 outcome was FAILURE using a merge of bef7935b741c6c4e4bece9c55d326da420ab65d5
Summary: Tests passed: 541, ignored: 53; exit code 1 (new) Build time: 00:03:39

Linux Build 10076 outcome was FAILURE using a merge of bef7935b741c6c4e4bece9c55d326da420ab65d5
Summary: Tests passed: 544, ignored: 53; exit code 1 (new) Build time: 00:04:08

Windows Build 5117 outcome was FAILURE using a merge of bef7935b741c6c4e4bece9c55d326da420ab65d5
Summary: Tests passed: 544, ignored: 53; exit code 1 (new) Build time: 00:08:13

@ctomc rebased
I still think that we cannot use the ParameterValidator to solve this problem, because we only know the parameter value in the method: validateParameter(), in this case, it might be the name of long-running-threads. We actually need to know both the name of the long-running-threads and the name of it's parent resource workmanager. Attributes are defined static where no OperationContext can be used in ParameterValidator to get the parent resource information.
Besides, the thread pool related resources are defined in wildfly-threads subsystem, we cannot update the attributes in that subsystem just to fit this JCA case.
Hope that I make myself clear ... :)

Linux Build 10842 outcome was FAILURE using a merge of 5da87b46980f2124fa053e956bbd75e66b4e0b57
Summary: Tests failed: 1 (1 new), passed: 3570, ignored: 171 Build time: 01:09:49
Failed tests
org.jboss.as.test.integration.domain.mixed.eap640.MixedDomain640TestSuite: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: Could not start container
	at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.awaitServers(DomainLifecycleUtil.java:451)
	at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.start(DomainLifecycleUtil.java:253)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSupport.startAndAdjust(MixedDomainTestSupport.java:175)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSupport.start(MixedDomainTestSupport.java:93)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getSupport(MixedDomainTestSuite.java:96)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getSupport(MixedDomainTestSuite.java:59)
	at org.jboss.as.test.integration.domain.mixed.eap640.MixedDomain640TestSuite.initializeDomain(MixedDomain640TestSuite.java:44)
------- Stdout: -------
INFO  [org.jboss.remoting] JBoss Remoting version 5.0.0.Beta7
INFO  [org.xnio] XNIO version 3.4.1.Final
INFO  [org.xnio.nio] XNIO NIO Implementation Version 3.4.1.Final
INFO  [org.wildfly.security] ELY00001: WildFly Elytron version 1.1.0.Beta13
 [0m06:41:58,035 INFO  [org.jboss.modules] (main) JBoss Modules version 1.6.0.Beta3
 [0m [0m06:41:58,272 INFO  [org.jboss.as.process.Host Controller.status] (main) WFLYPC0018: Starting process 'Host Controller'
 [0m[Host Controller]  [0m06:41:58,737 INFO  [org.jboss.modules] (main) JBoss Modules version 1.6.0.Beta3 [0m
[Host Controller]  [0m [0m06:41:58,997 INFO  [org.jboss.msc] (main) JBoss MSC version 1.2.7.Final [0m
[Host Controller]  [0m [0m06:41:59,050 INFO  [org.jboss.as] (MSC service thread 1-7) WFLYSRV0049: WildFly Full 11.0.0.Alpha1-SNAPSHOT (WildFly Core 3.0.0.Alpha12) starting [0m
[Host Controller]  [0m [0m06:41:59,455 INFO  [org.jboss.as.domain.management] (Controller Boot Thread) WFLYDM0136: Registered OpenSSL provider [0m
[Host Controller]  [0m [0m06:41:59,707 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'permgen-size' in the resource at address '/host=master/jvm=default' is deprecated, and may be removed in future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m06:41:59,707 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'max-permgen-size' in the resource at address '/host=master/jvm=default' is deprecated, and may be removed in future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m06:41:59,739 INFO  [org.jboss.as.host.controller] (Controller Boot Thread) WFLYHC0003: Creating http management service using network interface (management) port (9990) securePort (-1) [0m
[Host Controller]  [0m [0m06:41:59,743 INFO  [org.xnio] (MSC service thread 1-5) XNIO version 3.4.1.Final [0m
[Host Controller]  [0m [0m06:41:59,750 INFO  [org.xnio.nio] (MSC service thread 1-5) XNIO NIO Implementation Version 3.4.1.Final [0m
[Host Controller]  [0m [0m06:41:59,782 INFO  [org.jboss.as.patching] (MSC service thread 1-2) WFLYPAT0050: WildFly Full cumulative patch ID is: base, one-off patches include: none [0m
[Host Controller]  [0m [0m06:41:59,798 INFO  [org.jboss.remoting] (MSC service thread 1-8) JBoss Remoting version 5.0.0.Beta7 [0m
[Host Controller]  [0m [33m06:41:59,799 WARN  [org.jboss.as.domain.management.security] (MSC service thread 1-4) WFLYDM0111: Keystore /opt/buildAgent/work/a31d203e70e89f90/testsuite/mixed-domain/target/domains/MixedDomain640TestSuite/master/configuration/application.keystore not found, it will be auto generated on first use with a self signed certificate for host localhost [0m
[Host Controller]  [33m [0m [0m06:41:59,819 INFO  [org.wildfly.security] (MSC service thread 1-8) ELY00001: WildFly Elytron version 1.1.0.Beta13 [0m
[Host Controller]  [0m [0m06:41:59,884 INFO  [org.jboss.as.remoting] (MSC service thread 1-8) WFLYRMT0001: Listening on [::1]:9999 [0m
[Host Controller]  [0m [0m06:42:01,240 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'security-realm' in the resource at address '/profile=default/subsystem=undertow/server=default-server/https-listener=https' is deprecated, and may be removed in future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m06:42:01,278 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'security-realm' in the resource at address '/profile=ha/subsystem=undertow/server=default-server/https-listener=https' is deprecated, and may be removed in future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m06:42:01,314 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'security-realm' in the resource at address '/profile=full/subsystem=undertow/server=default-server/https-listener=https' is deprecated, and may be removed in future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m06:42:01,350 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'security-realm' in the resource at address '/profile=full-ha/subsystem=undertow/server=default-server/https-listener=https' is deprecated, and may be removed in future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m06:42:01,689 INFO  [org.jboss.as] (Controller Boot Thread) WFLYSRV0060: Http management interface listening on http://[::1]:9990/management [0m
[Host Controller]  [0m [0m06:42:01,690 INFO  [org.jboss.as] (Controller Boot Thread) WFLYSRV0054: Admin console is not enabled [0m
[Host Controller]  [0m [0m06:42:01,690 INFO  [org.jboss.as] (Controller Boot Thread) WFLYSRV0025: WildFly Full 11.0.0.Alpha1-SNAPSHOT (WildFly Core 3.0.0.Alpha12) (Host Controller) started in 3333ms - Started 47 of 51 services (18 services are lazy, passive or on-demand) [0m
INFO  [org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil] HostController started in 4279 ms
[Host Controller]  [0m [33m06:42:03,606 WARN  [org.jboss.as.messaging] (management-handler-thread - 1) WFLYMSG0071: There is no resource matching the expiry-address jms.queue.ExpiryQueue for the address-settings #, expired messages from destinations matching this address-setting will be lost! [0m
[Host Controller]  [33m [0m [33m06:42:03,607 WARN  [org.jboss.as.messaging] (management-handler-thread - 1) WFLYMSG0072: There is no resource matching the dead-letter-address jms.queue.DLQ for the address-settings #, undelivered messages from destinations matching this address-setting will be lost! [0m
[Host Controller]  [33m [0m [0m06:42:04,485 INFO  [org.jboss.as.controller.management-deprecated] (management-handler-thread - 3) WFLYCTL0028: Attribute 'default-stack' in the resource at address '/' is deprecated, and may be removed in future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m06:42:04,947 INFO  [org.jboss.as.controller.management-deprecated] (management-handler-thread - 4) WFLYCTL0028: Attribute 'stack' in the resource at address '/' is deprecated, and may be removed in future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m06:42:05,023 INFO  [org.jboss.as] (MSC service thread 1-1) WFLYSRV0050: WildFly Full 11.0.0.Alpha1-SNAPSHOT (WildFly Core 3.0.0.Alpha12) stopped in 23ms [0m
[Host Controller]  [0m [0m06:42:05,024 INFO  [org.jboss.as] (MSC service thread 1-1) WFLYSRV0049: WildFly Full 11.0.0.Alpha1-SNAPSHOT (WildFly Core 3.0.0.Alpha12) starting [0m
[Host Controller]  [0m [0m06:42:05,056 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'permgen-size' in the resource at address '/host=master/jvm=default' is deprecated, and may be removed in future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m06:42:05,057 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'max-permgen-size' in the resource at address '/host=master/jvm=default' is deprecated, and may be removed in future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m06:42:05,068 INFO  [org.jboss.as.host.controller] (Controller Boot Thread) WFLYHC0003: Creating http management service using network interface (management) port (9990) securePort (-1) [0m
[Host Controller]  [0m [0m06:42:05,073 INFO  [org.jboss.as.patching] (MSC service thread 1-1) WFLYPAT0050: WildFly Full cumulative patch ID is: base, one-off patches include: none [0m
[Host Controller]  [0m [33m06:42:05,076 WARN  [org.jboss.as.domain.management.security] (MSC service thread 1-1) WFLYDM0111: Keystore /opt/buildAgent/work/a31d203e70e89f90/testsuite/mixed-domain/target/domains/MixedDomain640TestSuite/master/configuration/application.keystore not found, it will be auto generated on first use with a self signed certificate for host localhost [0m
[Host Controller]  [33m [0m [0m06:42:05,077 INFO  [org.jboss.as.remoting] (MSC service thread 1-1) WFLYRMT0001: Listening on [::1]:9999 [0m
[Host Controller]  [0m [0m06:42:05,222 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'default-stack' in the resource at address '/profile=full-ha/subsystem=jgroups' is deprecated, and may be removed in future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m06:42:05,294 INFO  [org.jboss.as] (Controller Boot Thread) WFLYSRV0060: Http management interface listening on http://[::1]:9990/management [0m

Windows Build 5877 outcome was FAILURE using a merge of 5da87b46980f2124fa053e956bbd75e66b4e0b57
Summary: Tests failed: 1 (1 new), passed: 3571, ignored: 172 Build time: 01:26:30
Failed tests
org.jboss.as.test.integration.domain.management.cli.DomainDeploymentOverlayTestCase.testSimpleOverrideWithRedeployAffected: org.jboss.as.cli.CommandLineException: The controller is not available at [::1]:9999
	at org.jboss.as.protocol.ProtocolConnectionUtils.connectSync(ProtocolConnectionUtils.java:131)
	at org.jboss.as.protocol.ProtocolConnectionManager$EstablishingConnection.connect(ProtocolConnectionManager.java:259)
	at org.jboss.as.protocol.ProtocolConnectionManager.connect(ProtocolConnectionManager.java:70)
	at org.jboss.as.protocol.mgmt.ManagementClientChannelStrategy$Establishing.getChannel(ManagementClientChannelStrategy.java:162)
	at org.jboss.as.cli.impl.CLIModelControllerClient.getOrCreateChannel(CLIModelControllerClient.java:180)
	at org.jboss.as.cli.impl.CLIModelControllerClient$3.getChannel(CLIModelControllerClient.java:132)
	at org.jboss.as.protocol.mgmt.ManagementChannelHandler.executeRequest(ManagementChannelHandler.java:135)
	at org.jboss.as.protocol.mgmt.ManagementChannelHandler.executeRequest(ManagementChannelHandler.java:110)
	at org.jboss.as.controller.client.impl.AbstractModelControllerClient.executeRequest(AbstractModelControllerClient.java:263)
	at org.jboss.as.controller.client.impl.AbstractModelControllerClient.execute(AbstractModelControllerClient.java:168)
	at org.jboss.as.controller.client.impl.AbstractModelControllerClient.executeForResult(AbstractModelControllerClient.java:147)
	at org.jboss.as.controller.client.impl.AbstractModelControllerClient.execute(AbstractModelControllerClient.java:75)
	at org.jboss.as.cli.impl.CommandContextImpl.tryConnection(CommandContextImpl.java:1296)
	at org.jboss.as.cli.impl.CommandContextImpl.connectController(CommandContextImpl.java:1142)
	at org.jboss.as.cli.impl.CommandContextImpl.connectController(CommandContextImpl.java:1181)
	at org.jboss.as.test.integration.domain.management.cli.DomainDeploymentOverlayTestCase.setUp(DomainDeploymentOverlayTestCase.java:147)
------- Stdout: -------
The command is not available in the current context (e.g. required subsystems or connection to the controller might be unavailable).
The command is not available in the current context (e.g. required subsystems or connection to the controller might be unavailable).
The command is not available in the current context (e.g. required subsystems or connection to the controller might be unavailable).
The command is not available in the current context (e.g. required subsystems or connection to the controller might be unavailable).

retest this please

Windows Build 5882 outcome was FAILURE using a merge of 5da87b46980f2124fa053e956bbd75e66b4e0b57
Summary: Tests failed: 1 (1 new), passed: 3571, ignored: 172 Build time: 01:35:03
Failed tests
org.jboss.as.test.integration.domain.management.cli.DomainDeploymentOverlayTestCase.testSimpleOverride: org.jboss.as.cli.CommandLineException: The controller is not available at [::1]:9999
	at org.jboss.as.protocol.ProtocolConnectionUtils.connectSync(ProtocolConnectionUtils.java:131)
	at org.jboss.as.protocol.ProtocolConnectionManager$EstablishingConnection.connect(ProtocolConnectionManager.java:259)
	at org.jboss.as.protocol.ProtocolConnectionManager.connect(ProtocolConnectionManager.java:70)
	at org.jboss.as.protocol.mgmt.ManagementClientChannelStrategy$Establishing.getChannel(ManagementClientChannelStrategy.java:162)
	at org.jboss.as.cli.impl.CLIModelControllerClient.getOrCreateChannel(CLIModelControllerClient.java:180)
	at org.jboss.as.cli.impl.CLIModelControllerClient$3.getChannel(CLIModelControllerClient.java:132)
	at org.jboss.as.protocol.mgmt.ManagementChannelHandler.executeRequest(ManagementChannelHandler.java:135)
	at org.jboss.as.protocol.mgmt.ManagementChannelHandler.executeRequest(ManagementChannelHandler.java:110)
	at org.jboss.as.controller.client.impl.AbstractModelControllerClient.executeRequest(AbstractModelControllerClient.java:263)
	at org.jboss.as.controller.client.impl.AbstractModelControllerClient.execute(AbstractModelControllerClient.java:168)
	at org.jboss.as.controller.client.impl.AbstractModelControllerClient.executeForResult(AbstractModelControllerClient.java:147)
	at org.jboss.as.controller.client.impl.AbstractModelControllerClient.execute(AbstractModelControllerClient.java:75)
	at org.jboss.as.cli.impl.CommandContextImpl.tryConnection(CommandContextImpl.java:1296)
	at org.jboss.as.cli.impl.CommandContextImpl.connectController(CommandContextImpl.java:1142)
	at org.jboss.as.cli.impl.CommandContextImpl.connectController(CommandContextImpl.java:1181)
	at org.jboss.as.test.integration.domain.management.cli.DomainDeploymentOverlayTestCase.setUp(DomainDeploymentOverlayTestCase.java:147)
------- Stdout: -------
The command is not available in the current context (e.g. required subsystems or connection to the controller might be unavailable).
The command is not available in the current context (e.g. required subsystems or connection to the controller might be unavailable).
The command is not available in the current context (e.g. required subsystems or connection to the controller might be unavailable).
The command is not available in the current context (e.g. required subsystems or connection to the controller might be unavailable).

retest this please

@kabir  updated by adding the check in another step.


[Feature] GitHub table on the website

Before Requesting

[X] I found no existing issue matching my feature request
[X] This request is related to Millennium, and not a request for a specific theme/addon

Describe the feature you'd like!
Support of the GitHub table system on the Millennium website

Anything else?
No response

thx ❤


Provide options to set network timeout and delay

From Mark Chadwick:

We’ve been doing some work with our main internet provider as they have been making firewall and routing changes between our datacentres recently. There’s another major one coming up soon, so we thought we might address an issue we have with slink2dali. Namely when the firewall/route change happens the slink2dali tool will hang for the prescribed 300 seconds before realising the other end has gone away and does a reconnect (with livens up the firewall packet matching etc., and it all starts to work happily).

At the same time there have been some suggestions to change the netdly and netto parameters (mainly for connections within the datacentres rather than for connections out into the field), so I’ve had a quick go at adding them to the source of slink2dali-0.7.  I couldn’t find an associated IRIS git repo so a gist of the patch may be better than me sending patch files via email (which I know our spam filters don’t like).

It’s a pretty simple change but just in case you or other users may benefit here’s the link.

https://gist.github.com/ozym/e6ba61fb43c738571d282ccb953e0edf

I’ve changed the version number, but that’s only so we can track the version once it’s deployed.

I'm using slink2dali to pull data from stations with digitizers that support seedlink (Obsidian) and the 300 second timeout seems too large for this use. In many cases a manual restart will reconnect well before the timeout hits. So configuring it would be useful. It would also be useful if the configuration was file based instead of command line args.

It would also be useful if the configuration was file based instead of command line args.

Can you describe in which cases it would be useful as opposed to command line?

I use slink2dali to retrieve data from a station that has a seedlink enabled Obsidian. It is started from systemd at boot time, but that means that even though the command itself is run as a normal user, the startup file is owned by root and in /etc/systemd/system, which means edit requires sudo. But if slink2dali could accept a single arg that was a config file, then that config file could live with all the rest of my config files in a directory owned by the user. Ringserver, for example, uses a single conf file and I find that style much easier to keep track of and update.


new toolset compiler - 2.6.0-beta1-62126-01

This was a "special" build, so there is no public VSIX for this.
The old one should be ok, for most scenarios.
When VS 15.5 preview1 is available it will match this compiler feature-wise by default.

@VSadov,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot


0 match with Flatline

I got hits but 0 matches.
The idea is to get an alert if number of events is less than 5000 (threshold) in last 24 hours
index: "logstash-*"

name: Client - Sending emails amount too low

type: flatline

# (Required)
# PagerDuty settings
pagerduty_client_name: PagerDuty # Pager duty client account name
pagerduty_service_key: pdkey # PagerDuty API Service key

filter:
- query:
    query_string:
      query: "app_name: Micro-Alert-Service AND NOT email_categories: now-tracking AND client_identifier: client"

threshold: 5000

timeframe:
  hours: 24

alert:
  - pagerduty

use_local_time: false

and the config file:

run_every:
  minutes: 1

buffer_time:
  minutes: 15

es_host: elasticsearch.xxx.com

# The Elasticsearch port
es_port: 9200

writeback_index: status-elastalert

alert_time_limit:
  days: 2

And the result is something like this

elastalert_status - {'hits': 2876, 'matches': 0 }

Have you tried with a more little time window ? i.e 1 hour. Is it working ?

It needs to run for at least 24 hours before it can actually alert. Try running it with a --start flag to test.

@Qmando can you expand on that? why does a flatline rule need to run for 24 hours before triggering a match?


Optional dynamic ThingsBoard usage

Instead of relying on MaxFieldsAmt and using StaticJsonDocument. I added the ability to optionally enable dynamic ThingsBoard usage #define THINGSBOARD_ENABLE_DYNAMIC, which removes the need to set MaxFieldsAmt and instead simply uses std::vector and lets itself resize automatically.
The same for non C++ STL supported boards, which use the added class Vector, which is basically just a barebones c-style array that implements the needed methods from std::vector. So it can be used easily with the ThingsBoard Arduino SDK.
Furthermore I fixed the worflow file for ESP8266, which previously used an older version of the Arduino library which did not support the C++ STL yet. This has changed and the compilation for all examples now run successfully as well.
Additionally the overhead for non ESP boards seems to have decreased as well, because there are only 2 examples that are currently not running on the Arduino Uno, because they don't have enough memory.

In addition I added commits to include the changes from the pull request #118, like I mentioned in my feedback.
The version has been increased to 0.9.4, there have been no breaking API changes and the documentation has been updated accordingly as well.
@imbeacon Would be nice if this could be merged and you can close #118, as the features have been implemented in this pull request as well.

Hi @MathewHDYT ,
We decided to make a fork of a pubsubclient and add some improvements from the origin repository, because as you mentioned, the last update of the main repository was in 2020. But the library is really useful.
So, probably we can just add the forked repository as a submodule to the project and use it, with required changes. What do you think?

@imbeacon Sounds good I can make a pull request from my fork onto yours, it includes the changes we need to fix the issue you mentioned.
To include the new fork it is more difficult for Arduino and pretty easy when using PlattformIo. Because when using the latter I can simply specify in the options file that it should get the library from this Github repository. For Arduino it is more difficult, because as far as I know it you can simply enter a name and it then gets the newest version of that library with the given name.
So to do that the library would need to have another name and have a release GitHub version + be included in the Arduino Libraries.

For the first step I'll simply create the pull request for now so the fork you did includes the changes we need.
The second thing then would be creating a new release on our fork and giving it another name and uploading it to Arduino Libraries (not sure how you do that never had to do it before).
Once that is all done we can simply adjust the build files in this project and it should all work.

Tried to pull request my fork into yours, sadly this doesn't seem to work. Because I would need to make a fork of your fork to make a Pull Request for it.
Because the changes are so little, it's probably easier if you just integrate the changes from my fork.

@MathewHDYT I will add changes from your repository to pubsub client.
According to ArduinoLibraries - don't worry, I will create a PR to them, but, probably we will need to change the repository name. Whenever it is not difficult to add library to Arduino libraries, but it will take some time.

@imbeacon That's what I expected. I think the best idea for now would be to simply merge this pull request so all devices work for now, even if it requires removing the C++ STL capabilities of the ThingsBoard Arduino SDK and releasing it as a new version 0.9.4
Then once the ArduinoIDE and PlattformIO libraries have been published you can simply create a new version that includes the updated library(.properties/.json) like mentioned above in a 0.9.5 release.

@imbeacon That's what I expected. I think the best idea for now would be to simply merge this pull request so all devices work for now, even if it requires removing the C++ STL capabilities of the ThingsBoard Arduino SDK and releasing it as a new version 0.9.4
Then once the ArduinoIDE and PlattformIO libraries have been published you can simply create a new version that includes the updated library(.properties/.json) like mentioned above in a 0.9.5 release.

I think we can do in the different way - we can create a branch in the PubSubClient fork and move required files from master branch to newly created. In the sdk repository we can create a GitHub sub module and get PubSubClient.h and PubSubClient.cpp directly to the library from newly created branch on PubSubClient repository.
You may see how it works on thingsboard/thingsboard-gateway repository- we are getting tb-mqtt-client from another repository.
It may be helpful at least before adding repository to Arduino Libraries.

@imbeacon That seems like a good idea or to make it even simpler, be could just include the 2 files needed for the PubSubClient in this library directly and remove the dependencies on PubSubClient.
That would make a lot of work not necessary and make it really simple to update the PubSubClient because it is directly included in this library itself.
We could even tailor the PubSubClient to be more specific and useful for this specific repository if we do it like that. The only thing is other people wouldn't really be able to use the PubSubClient with the included fixes.
I personally think that way could work as well and it would probably produce much less work.

Hi @MathewHDYT,
Finally, I was able to add a library to Arduino Libraries, it should be available soon. I was also forced to update a name of the library to TBPubSubClient, due to Arduino Library policy.

That's what I expected did the actual #include change at all? Or is it still #include <PubSubClient.h>?
If it changed the include would need to be adjusted in the ThingsBoard.h file.

Updated ThingsBoard.h, as well as library dependencies, includes now should be TBPubSubClient.h.

@imbeacon Seems good I think this can be merged into the main branch and released as version 0.9.4

I will test with Arduino Nano Connect board and with Raspberry Pi Pico W and then make a new release.

Should work the problem of course is that currently with Arduino the library is not released yet that is why the automatic compiles will fail as well.

Let's keep the link to the repository.

@imbeacon What I meant is that the library.json needs to include the TBPubSubClient like this "https://github.com/thingsboard/pubsubclient.git": "^2.9.0" or if it is included like this "thingsboard/TBPubSubClient": "^2.8.1" it needs to be registered on this webpage.


Pin wandb version in llm-finetuning repo

need to pin wandb version, otherwise get this error: https://github.com/wandb/wandb/issues/7406

Ah nice, this bit me when I updated the Axolotl container version and I (falsely) attributed it to that.
I don't immediately understand why CI is failing but it seems not great?

oof yeah that is a lot of failing tests

oh you deleted src/inference.py by accident :D

🤦♀ sorry I had some local changes that I didn't want to include and forgot about that.

pulled this change into #48


sincos intrinsic not working

Can be repeated by simply having a call like.
float s, c;
sincos(1.0, s, c);

This will fail claiming no overload applicable to arguments of type (float, float, float)
Looking into a little bit we see in  RefPtr<Expr> ResolveInvoke(InvokeExpr * expr) that it finds 3 candidates but they all have the status
[0] = {flavor=UnspecializedGeneric (2) status=GenericArgumentInferenceFailed (0) item={declRef={name="sincos" loc=904629} ...} ...}
Presumably this being something to do with 2nd and 3rd args being out parameters.

On checking 0.24.49 this appears to be working correctly.


add a variable for minimum_protocol_version

it's currently hard coded to TLSv1, but that's mostly being deprecated.
Thanks

submitted a PR


Training time

Thanks weiwei for sharing this code!
Have you tried to train pvnet from scratch on multi-GPUs with DDP? How long does it take to train one epoch?

Sorry, I haven't tried to train on multi-GPUs. I seem to remember that the training time is about half an hour on a single GPU.


Make styling consistent #2

Update edit views also same as pull#45

Thanks 👍

I fixed a missing " and tagged 1.25.6 😄

Thanks :D then it was missing in both new and old.

Oh damn ok, fixed it on the new as well.


[ERROR] reels download error

I'm reporting a bug while I'm using it.
When downloading after entering the reel URL, an error message is displayed as follows.
error code is 500.
Please check.
URL: https://www.instagram.com/p/C5NZ2_3Sr6e/?igsh=Y2tpcjRha29xb3o2

Thank you, @gooson , for bringing this issue to our attention. Currently, I'm actively working on enhancing the download speed and reinforcing the security infrastructure in the backend. As part of this effort, I've performed a migration that necessitated temporarily turning off the service. I apologize for any inconvenience this may cause. The server will be back online within 24 hours, and I'll provide an update on the ticket status accordingly.

Getting the same error is their any solution? @VishwaiOSDev  @gooson

Is there any estimation when the APIs will be working again?


fix(capi): add void as paramter instead of ()

Hi,
Empty argument list generates warning with some compilers.

Duplicate of https://github.com/thorvg/thorvg/pull/2316


Explain config and the force

Refs #78

We should start a new PR after finishing Config related work.


Theme change does not work

When I try to use different theme in book.json the output is broken.

@pitrew can you give a bit more detail about what is broken?

Sure, so I followed instructions to enable this plugin from README.md. Then instead of using default theme I've changed it to dark:
"pluginsConfig": {
  "prism": {
    "css": [
      "prismjs/themes/prism-dark.css"
    ]
  }
}

and it does not display correctly.
Checking DOM I notticed that there is astructure like this:

   Code....

then I eddited those nodes manually to

   Code....

it was working fine.

by any chance do you have a sample repo with the issue?  if not I can try and recreate later today.

I created a sample repo gitbook-prism-example and was able to recreate the issue.

@pitrew Thanks for the heads up.  The color themes were not being applied without the proper classes on the
 and <code blocks.  PR #10 should have a a workaround.

@robmcguinness good stuff, thanks


I think the last release has killed the sandbox?

Describe the bug (required)
https://codesandbox.io/s/github/tannerlinsley/react-table/tree/master/examples/basic
INVALID_REQUEST - No commit found for SHA: master
Provide an example via Codesandbox! (required)
😅
Steps To Reproduce (required)
Steps to reproduce the behavior:
Go here: https://codesandbox.io/s/github/tannerlinsley/react-table/tree/master/examples/basic

Seems to be fixed now in 17fe3a879466fdd323a608dcdd50db896e3930ad

Yeah, that's true. I can't access codebox on the example given on the website.

The sandboxes have been changed to point at the v7 branch. If you find any old sandboxes that don't work, change the master in their URL to v7 and you'll be fine.


JWT Authentication setup failing

Here's my code running on windows 10.
import feathers from 'feathers';
import rest from 'feathers-rest';
import bodyParser from 'body-parser';
import auth from 'feathers-authentication';
import jwt from 'feathers-authentication-jwt';

const init = () => {
  const app = feathers();

  app.configure(rest());
  app.use(bodyParser.json());
  app.use(bodyParser.urlencoded({ extended: true }));
  app.configure(auth({ secret: 'my-secret' }));
  app.configure(jwt());
  app.use('/messages', {
    get(id, params) {
      console.log(params);
      return Promise.resolve({
        id,
        read: false,
        text: 'Feathers is great!',
        createdAt: new Date()
          .getTime()
      });
    }
  });

  app.listen(3030);
};

export const run = () => init();

Have also tried this:
import feathers from 'feathers';
import rest from 'feathers-rest';
import bodyParser from 'body-parser';
import auth from 'feathers-authentication';

const init = () => {
  const app = feathers();

  app.configure(rest());
  app.use(bodyParser.json());
  app.use(bodyParser.urlencoded({ extended: true }));
  app.configure(auth({ token: { secret: 'my-secret' } }));
  app.use('/messages', {
    get(id, params) {
      console.log(params);
      return Promise.resolve({
        id,
        read: false,
        text: 'Feathers is great!',
        createdAt: new Date()
          .getTime()
      });
    }
  });

  app.listen(3030);
};

export const run = () => init();

Getting this error in both cases:
D:\code\playground\core-new\feathers\node_modules\feathers-authentication\lib\services\token.js:25
    tokenService.before({
                 ^

TypeError: tokenService.before is not a function
    at EventEmitter.<anonymous> (D:\code\playground\core-new\feathers\node_modules\feathers-authentication\lib\services\token.js:25:18)
    at EventEmitter.configure (D:\code\playground\core-new\feathers\node_modules\feathers\lib\application.js:138:8)
    at D:\code\playground\core-new\feathers\node_modules\feathers-authentication\lib\index.js:184:11
    at Array.forEach (native)
    at EventEmitter.<anonymous> (D:\code\playground\core-new\feathers\node_modules\feathers-authentication\lib\index.js:154:25)
    at EventEmitter.configure (D:\code\playground\core-new\feathers\node_modules\feathers\lib\application.js:138:8)
    at init (D:/code/playground/core-new/feathers/server.js:16:7)
    at Object.run (D:/code/playground/core-new/feathers/server.js:44:26)
    at Object.<anonymous> (D:\code\playground\core-new\feathers\bootstrap.js:2:21)
    at Module._compile (module.js:570:32)
[nodemon] app crashed - waiting for file changes before starting...

@zusamann, please post the version numbers of each of the imported modules.

Latest ones on  NPM I think, since I just did a npm i -S ......
    "feathers": "^2.0.3",
    "feathers-authentication": "^0.7.11",
    "feathers-authentication-jwt": "^0.3.1"

@marshallswain

If you are using feathers-authentication-<strategy> you need to explicitly install<EMAIL_ADDRESS>

But as you can see above @daffl I did two attempts, with and without feathers-authentication-<strategy> got the same error in both cases.

Ok here I am using "feathers-authentication": "^1.0.2" and getting a slightly different error.
import feathers from 'feathers';
import rest from 'feathers-rest';
import bodyParser from 'body-parser';
import auth from 'feathers-authentication';
import jwt from 'feathers-authentication-jwt';
import sequelize from 'feathers-sequelize';
const db = require('./models');

const init = () => {
  const app = feathers();

  app.configure(rest());
  app.use(bodyParser.json());
  app.use(bodyParser.urlencoded({ extended: true }));
  app.configure(auth({ secret: 'my-secret' }));
  app.configure(jwt());

  Object.keys(db.sequelize.models)
    .map(key =>
      app.use(`/rest/${key}`, sequelize({
        Model: db[key],
        paginate: {
          default: 5,
          max: 25
        }
      }))
    );

  app.listen(3030);
};

export const run = () => init();

D:\code\playground\core-playground\feathers\node_modules\feathers-authentication-jwt\lib\verifier.js:32
      throw new Error('options.service does not exist.\n\tMake sure you are passing a valid service path or service instance and it is initialized before feathers-authentication-jwt.');
      ^

Error: options.service does not exist.
        Make sure you are passing a valid service path or service instance and it is initialized before feathers-authentication-jwt.
    at new JWTVerifier (D:\code\playground\core-playground\feathers\node_modules\feathers-authentication-jwt\lib\verifier.js:32:13)
    at EventEmitter.app.setup (D:\code\playground\core-playground\feathers\node_modules\feathers-authentication-jwt\lib\index.js:84:22)
    at EventEmitter.listen (D:\code\playground\core-playground\feathers\node_modules\feathers\lib\application.js:145:10)
    at EventEmitter.listen (D:\code\playground\core-playground\feathers\node_modules\uberproto\lib\proto.js:30:17)
    at init (D:/code/playground/core-playground/feathers/server.js:29:7)
    at Object.run (D:/code/playground/core-playground/feathers/server.js:32:26)
    at Object.<anonymous> (D:\code\playground\core-playground\feathers\bootstrap.js:2:21)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.runMain (module.js:604:10)
    at run (bootstrap_node.js:394:7)
    at startup (bootstrap_node.js:149:9)
    at bootstrap_node.js:509:3

@zusamann, check out the default options for the jwt plugin here: https://github.com/feathersjs/feathers-authentication-jwt#default-options.  You probably need to fix the service attribute (Or create a user service if you haven't, yet.)

Yes you are right @marshallswain this error is not thrown anymore. I had to add the following:
import memory from 'feathers-memory';
// ...
// ...
app.use('/users', memory());

Now I was looking to finally use the authentication on all of my endpoints which I'm generating procedurally like so:
  Object.keys(db.sequelize.models).map(key =>app.use(`/rest/${key}`, sequelize({ Model: db[key] })));

So I added the following:
  app.service('authentication').hooks({
    before: {
      all: [
        auth.hooks.authenticate('jwt')
      ]
    }
  });

But it is generating the following error:
D:\code\playground\core-playground\feathers\server.js:64
  app.service('authentication').hooks({
                                ^

TypeError: app.service(...).hooks is not a function
    at init (D:/code/playground/core-playground/feathers/server.js:32:33)

@zusamann you probably just need to install the hooks plugin: https://github.com/feathersjs/feathers-hooks

But not import it anywhere?

Use the quick start I just linked.

Right again @marshallswain, had to add the following to the code:
import hooks from 'feathers-hooks';
// ...
// ...
app.configure(hooks());

And modify the service creation so the hooks are added over the keys.map.
  Object.keys(db.sequelize.models)
    .map(key =>
      app.use(`/rest/${key}`, sequelize({
        Model: db[key],
        paginate: {
          default: 5,
          max: 25
        }
      }))
      .hooks({
        before: {
          all: [
            auth.hooks.authenticate(['jwt'])
          ]
        }
      })
    );

Thank you so much for your help.
I was wondering if the docs could be updated to reflect some of the nuances covered above. Of placing a users service and configuring hooks, etc.

The Auk docs will contain all of the information for<EMAIL_ADDRESS> Just out of curiosity, why did you decide to install feathers-authentication-jwt?  How did you discover it?  I ask because the current release of feathers-authentication on npm already includes that functionality.  We decided to implement auth plugins in the upcoming release (which you've just upgraded to using)

I have actually just recently discovered feathers, like 1-2 days ago and have just been reading all the repos, documentation, changelog, issues I could find. Learned about auk release there itself.
I just started doing some PoCs today, hence hitting all these confusions and errors.

I see.  We have big docs updates underway as the final part of the Auk release, so the confusion will disappear, shortly.

Glad to hear that, do you think the already out releases of Auk like the new authentication plugin are stable enough to use in production? Cause I'm really looking forward to using all of what I can find.

feathers-permissions will see some changes.  Everything else is stable.

Great! Looking forward to it.

In the meantime, using<EMAIL_ADDRESS>you'll probably want to familiarize yourself with the old authentication hooks.  Some might work, but others you might have to modify.  https://github.com/feathersjs/feathers-legacy-authentication-hooks

Back again, having trouble setting up the client side usage.
/**
     server.js
    "feathers": "^2.0.3",
    "feathers-authentication": "^1.0.2",
    "feathers-authentication-jwt": "^0.3.1",
**/

import feathers from 'feathers';
import rest from 'feathers-rest';
import bodyParser from 'body-parser';
import auth from 'feathers-authentication';
import jwt from 'feathers-authentication-jwt';
import hooks from 'feathers-hooks';
import errorHandler from 'feathers-errors/handler';
import memory from 'feathers-memory';
import sequelize from 'feathers-sequelize';
import cors from 'cors';
import socketio from 'feathers-socketio';
const db = require('./models');

const init = () => {
  const app = feathers();

  app.use(cors());
  app.configure(socketio({
    wsEngine: 'uws'
  }));
  app.configure(rest());
  app.use(bodyParser.json());
  app.use(bodyParser.urlencoded({ extended: true }));
  app.configure(hooks());
  app.configure(auth({ secret: 'secret' }));
  app.configure(jwt());
  app.use('/users', memory());

  Object.keys(db.sequelize.models)
    .map(key => {
      app.use(`/db/${key}`, sequelize({
        Model: db[key],
        paginate: {
          default: 10,
          max: 25
        }
      }));
      app.service(`/db/${key}`).hooks({
        before: {
          all: [
            auth.hooks.authenticate(['jwt'])
          ]
        }
      });
    });

  app.use(errorHandler());
  app.listen(3030);
};

export const run = () => init();

/**
    client.js
    "feathers-client": "^1.9.0",
**/

import feathers from 'feathers-client';
// import io from 'socket.io-client';
import axios from 'axios';

const host = 'http://localhost:3030';
const client = feathers()
  // .configure(feathers.socketio(io(host)))
  .configure(feathers.rest(host).axios(axios))
  .configure(feathers.hooks())
  .configure(feathers.authentication({
    storage: window.localStorage
  }));

export default client;

/**
    App.js (client side)
**/

class App extends Component {
  constructor() {
    super()
    this.state = { films: [] }
    client.authenticate({
      type: 'token',
      endpoint: '/authentication'  // without this the default post is to /auth/token, a bit confusing
    })
    .then(res => {
      console.log(res) // get a token with rest client, nothing comes with io client
      window.localStorage
        .setItem('feathers-jwt', res.accessToken); // tried without this first, that didnt work either
      client.service('/db/film').get(1).then(console.log) // errors out, 401 unautho...
    })
    .catch(rej => console.log(rej))
//...

So having trouble setting the fetched token in rest client, and with io client not getting any token at all. Both resulting in 401s.

On further exploration, this works on with the rest client, but doesn't with the io client.
/**
    App.js (client side)
**/

class App extends Component {
  constructor() {
    super()
    this.state = { films: [] }
    client.authenticate({
      type: 'token',
      endpoint: '/authentication'
    })
    .then(res => {
      client.set('token', res.accessToken)
      client.service('/db/film').get(1).then(console.log)
    })
    .catch(rej => console.log(rej))
//...

@zusamann Looks like you're still using the old version of the auth client.  You can upgrade by importing the new client plugin:
import auth from 'feathers-authentication-client'

...

.configure(auth({
    storage: window.localStorage
  }));

I'm actually not using the individual clients. Rather  "feathers-client": "^1.9.0", you suppose it's better to use broken up clients?

Nah.  You can keep everything else the same.  Just change the auth plugin part.

Ok will try that and revert

/**
    "feathers-authentication-client": "^0.1.7",
    "feathers-client": "^1.9.0",
**/

// client.js
import feathers from 'feathers-client';
import auth from 'feathers-authentication-client';
// import io from 'socket.io-client';
import axios from 'axios';

const host = 'http://localhost:3030';
const client = feathers()
  // .configure(feathers.socketio(io(host)))
  .configure(feathers.rest(host).axios(axios))
  .configure(feathers.hooks())
  .configure(auth({
    storage: window.localStorage
  }));

export default client;

// App.js
class App extends Component {
  constructor() {
    super()
    client.authenticate({
      type: 'token',
      endpoint: '/authentication'
    })
    .then(console.log)
    .catch(console.error)
  }
  render() {
// ...

Getting this error in my browser console twice.
base64_url_decode.js:14Uncaught (in promise) TypeError: Cannot read property 'replace' of undefined
    at module.exports (base64_url_decode.js:14)
    at module.exports (index.js:12)
    at passport.js:266

@marshallswain

The API has changed.  You now need to specify the strategy, which refers to the name of the PassportJS strategy being used on the server.  In the case of feathers-authentication-jwt, the name is just jwt.  You can see, from looking at the expected params in the README.md: https://github.com/feathersjs/feathers-authentication-jwt#expected-request-data, that you also need to provide an accessToken property, which is the actual JWT.
client.authenticate({
  type: 'jwt',
  accessToken: window.localStorage.getItem('feathers-jwt')
})

A shortcut to the above would be to simply call client.authenticate(), with no params.  The above and below are functionally equivalent.
client.authenticate()

Actually I tried with all the various combinations of params. And just now I tried the below again.
    client.authenticate()
    .then(console.log)
    .catch(console.error)

Tried setting the token manually too
    client.authenticate()
    .then(res => window.localStorage.setItem('feathers-jwt', res.accessToken))
    .catch(console.error)

Getting the same error as above on both.

It's actually erroring out even before the .authenticate() is being made. I commented out all code in my App.js except for import client from './client'; and getting an error there itself.
So there must be some thing wrong with this:
/**
    "feathers-authentication-client": "^0.1.7",
    "feathers-client": "^1.9.0",
**/

// client.js
import feathers from 'feathers-client';
import auth from 'feathers-authentication-client';
// import io from 'socket.io-client';
import axios from 'axios';

const host = 'http://localhost:3030';
const client = feathers()
  // .configure(feathers.socketio(io(host)))
  .configure(feathers.rest(host).axios(axios))
  .configure(feathers.hooks())
  .configure(auth({
    storage: window.localStorage
  }));

export default client;

Hmmm... Try switching to the individual modules.

feathers/client
feathers-hooks doesn't need to be changed.
feathers-rest/client
feathers-authentication-client

/**
    "feathers": "^2.0.3",
    "feathers-authentication-client": "^0.1.7",
    "feathers-hooks": "^1.7.1",
    "feathers-rest": "^1.6.0",
**/

import feathers from 'feathers/client';
import hooks from 'feathers-hooks';
import rest from 'feathers-rest/client';
import auth from 'feathers-authentication-client';
import axios from 'axios';

const host = 'http://localhost:3030';
const client = feathers()
  .configure(rest(host).axios(axios))
  .configure(hooks())
  .configure(auth({
    storage: window.localStorage
  }));

export default client;

Same error sadly.

base64_url_decode.js:14Uncaught (in promise) TypeError: Cannot read property 'replace' of undefined
    at module.exports (base64_url_decode.js:14)
    at module.exports (index.js:12)
    at passport.js:266

There's something else going on here.  What's the path to passport.js in your project or node_modules?  There is no reference to the replace function anywhere in the passport.js that's included in feathers-authentication-client.  Which version do you have installed?

Oh you posted that above.

I thought it was this file: https://github.com/feathersjs/feathers-authentication-client/blob/master/src/passport.js
But it's not in that file, directly.  Can you trace it down?

Looks like it's the dep jwt-decode
// ./~/jwt-decode/lib/base64_url_decode.js

Can you post your code in a repo that I can pull?

Yes sure, give me few minutes

@marshallswain here is the code:
https://github.com/zusamann/feathers-poc
There are two folders client-side and server-sideyou need to go to both and do annpm i&npm start`. As for the database I'm using postgres with the sample db I found here http://www.postgresqltutorial.com/load-postgresql-sample-database/
In order to connect with your own db you'll have to change line 15 in server-side/models/index.js
let sequelize = new Sequelize('postgres://postgres:password@localhost:5432/dvdrental', databaseOptions);

You can alternatively load some completely different db and models as you see fit.

Were you able to have a go? In any case what would be your suggestion @marshallswain
@daffl , should I downgrade to a pre 1.0 feathers-authentication on my server and try there?

Trying this out right now.

@zusamann I made a PR to your repo.  https://github.com/zusamann/feathers-poc/pull/1
Both local and jwt auth should work, now.  You'll need to integrate the client.

@marshallswain sorry but I'm getting the same error on the client side. Can you have a look at the client side code?
base64_url_decode.js:14Uncaught (in promise) TypeError: Cannot read property 'replace' of undefined
    at module.exports (base64_url_decode.js:14)
    at module.exports (index.js:12)
    at passport.js:266

Could it be a windows thing, perhaps? Also didn't really understand the change you made to thee server side code. I mean apart from excluding the local auth strategy, it seems like you replaced memory with nedb.
Also this change in server.js actually stopped my server from running as the file bootstrap.js expects a function run to work, so not sure how you were running the server. That's a minor point though.
-- export const run = () => init();
++ module.exports = () => init();

@zusamann

Can you have a look at the client side code? It's in the client-side folder.

I'll take a look later today.

Also didn't really understand the change you made to thee server side code.

The most important part was registering the hook on the /authentication service.  None of the auth plugins will work without that.

@zusamann I think you might have a problem with your environment.  I don't get the error you pasted, above.  I just submitted another PR where I got auth working.  Try removing your node_modules folders on the client and reinstall.  It probably shouldn't matter, but I installed modules using Yarn.

The most important part was registering the hook on the /authentication service. None of the auth plugins will work without that.

@marshallswain actually I was using /authentication to generate the tokens and using them to call the /db/films end point. This was an intended behavior actually for my customer facing landing page where the freely generated token is then used to authenticate lots of calls to the backend.

As for the server change,  I was just using node server to run the code after I switched back to CommonsJS.

Try removing your node_modules folders on the client and reinstall. It probably shouldn't matter, but I installed modules using Yarn.
Ok trying

I was using /authentication to generate the tokens and using them to call the /db/films end point. This was an intended behavior actually for my customer facing landing page where the freely generated token is then used to authenticate lots of calls to the backend.

I see.  Let me try this.

I just tried this and got no errors.  I think we're back to this being an environment issue.

I think you might have a problem with your environment. I don't get the error you pasted, above. I just submitted another PR where I got auth working. Try removing your node_modules folders on the client and reinstall. It probably shouldn't matter, but I installed modules using Yarn.

Just tried again with a rm -rf node_modules and a yarn install inside the client-side folder and tried again. Same error actually, coming from the jwt-decode lib. Did you use the actual code in the client-side folder?
Also just to be clear the server side implementation was working as intended. A call to the open /authentication endpoint gave me a token which successfully let me call the other authenticated endpoints /db/....
It's just the client-side code is giving troubles.
Do you think it could be a windows issue? Should I try to setup the entire thing in vagrant or something?

I see you have pushed another PR, let me try with that once.

Oh, maybe this IS a Windows issue.  I literally just opened the client-side folder, installed deps and ran npm start.  It booted up your client code and immediately authenticated.

It could also be an issue with create-react-app framework because the optimized production build that one gets after running npm run build is actually not giving me that error 😐
I'll try and set this up without a fancy framework tomorrow and get back to you. I will also try and set up this thing in a dev env on vagrant to isolate the issue.
Thank you and my apologies for the trouble 😅
@marshallswain

Okay last test result for tonight.
Simply doing a node client.js in the console without any browser works fine for the rest client but not for the ws client. Will test some more tomorrow in the real browser tomorrow.
const feathers = require('feathers/client');
const hooks = require('feathers-hooks');
const rest = require('feathers-rest/client');
const auth = require('feathers-authentication-client');
const socketio = require('feathers-socketio/client');
const io = require('socket.io-client');
const axios = require('axios');
const localStorage = require('localstorage-memory');

const host = 'http://localhost:3030';
const client = feathers()
  // .configure(rest(host).axios(axios))
  .configure(socketio(io(host)))
  .configure(hooks())
  .configure(auth({
    storage: localStorage
  }));

client.authenticate({
  strategy: 'jwt'
})
.then(res => {
  console.log(res);
  client.service('/db/film').get(1)
  .then(console.log)
  .catch(console.error)
})
.catch(console.error)

Ok now I can fully confirm that the above client side error was a webpack-dev-server issue and not a feathers-authentication-client issue.
https://github.com/webpack/webpack-dev-server/issues/381
https://github.com/webpack/webpack-dev-server/issues/117
I turned off my adblock extension on chrome and the error went away.

But haven't been able to solve the complete issue.
The intended behavior is the /authentication endpoint can freely issue tokens which are then used to make authenticated calls to other endpoints.
Now the rest client works fine in the above flow but the io client returns a 401. Please pull the latest code from https://github.com/zusamann/feathers-poc and give it a go.
@marshallswain

Also when this whole thing pans out, I was hoping that I could push this entire thing as a documented demo somewhere? Both the client and server side code as a full realized app.

Slightly off-topic, but I was looking to use feathers-authentication-jwt and looked into migrating to the new modules and APIs. Just some feedback -- there are a lot of moving parts involved. After spending 3 hours wiring things up, I gave up and resorted to forking the legacy branch and making it accept configurable functions for passport/checkCredentials and JWT sign/verify. gist here
For context -- we have an external token management microservice that issues a JWT based access_token along with a refresh_token, and I was looking to reuse the client + server auth stack in feathersjs to quickly build a web frontend.

Had a small discussion with @marshallswain and we concluded that the exact flow that I was trying to achieve was not really a supported strategy in the current system.
A hypothetical feathers-authentication-anonymous adapter would be something that solves this problem completely. For now an anonymous auth only seems to work through the rest client and not the io client.

@shirish87 I think such issues are bound to happen with a release that is not even out yet. But I think it should come out soon, with proper docs, etc,

@zusamann Totally agree. I was alluding to the convenience of a single-module approach (legacy feathers-authentication) vs. the flexibility of wired-up individual modules.
Both approaches have their pros and cons, but the community eventually gravitates to find the right balance :)

@zusamann if you have an anonymous feature request feel free to open an issue. It actually should work pretty much out of the box. I'll be working on documenting anonymous user auth. Going to close this now as things seem to be fairly sorted for you and this is a pretty lengthy thread. 😄


feat: add SSE streams

Description of change
Added SSE client to fetch the streaming of events from Home Assistant API
Added cli commands to tests this functionality
Some fixes were required for Event model, because if the json received didn't contained the | None fields (such as name and uri), it raised an InvalidFieldValue exception. Also int wasn't included as a posible value type.`
I deleted the ContentType as is not required (SSE client does use the text/event-stream automatically
Also deleted get_all_events function because always returns a stream by default, and if application/vnd.bsh.sdk.v1+json is specified, it will return an 405 HTTP error.

Pull-Request Checklist

[x] Code is up-to-date with the main branch
[x] This pull request follows the contributing guidelines.
[ ] This pull request links relevant issues as Fixes #0000
[x] There are new or updated unit tests validating the change
[ ] Documentation has been updated to reflect this change
[ ] The new commits follow conventions outlined in the conventional commit spec, such as "fix(api): prevent racing of requests".

If pre-commit.ci is failing, try pre-commit run -a for further information.
If CI / test is failing, try poetry run pytest for further information.

Yeah, we can even prepare an boolean option that allows to switch between the real API and simulator API (so we change the endpoints an all the stuff)

Btw, all data classes at models that have attributes with | None type should be defaulted to None, just like we did with Event data class


slow execution after running script on a new datadump

Thanks for building this tool!  Its saved me a ton of time in gathering the migrating the Discogs Data for a pet project of mine.
I have a question about the intended usage of the package AFTER an initial data dump parse:  If I run the script on a batch of xml files from October and then run it again on the next set of files in November, is there an intermediate action I should take?
Not sure if it's due to the indices on the release-related tables, but I've been running the script on the newest data dump after having filled the tables with last months dump and I'm finding the COPYing process to be pretty slow.  Over 12 hours now and it still hasn't finished.
Am I better off just dropping the tables altogether and then refilling them with the new data?  That way it can just bulk copy?

Hey! Now that you mention it, I never thought about doing incremental dumps.
What is probably happening now is that it's loading everything twice, that's why it is so slow (the tables where you are dumping are already gigantic!).
For now I'd recommend you drop everything before. Not the nicest solution but will do for now.
In the future I may think about adding support for "updating" a dump.
Cheers 🙌

Yeah that extra functionality would be dope!  I've never written anything in Haskell, but I might try my hand at it and send you a pull request.
For my purposes, I still need to be able to read from those tables while the bulk-copy update is happening, so I'm thinking to:

have the script bulk copy to temp tables
build the indexes
drop the old tables and ALTER TABLE to rename the temp tables to the original names

Still not incremental, but allows the built tables to continue to be read from while the new ones are being copied in.

Oh yeah sure, any DB trick will work there.

For now I'd recommend you drop everything before. Not the nicest solution but will do for now.

This worked for me!


cmd/cgo: map sized integer types to C equivalents

(Removing the template since this is an enhancement proposal)
The type mappings at https://golang.org/cmd/cgo/#hdr-Go_references_to_C don't state which Go types the sized C integer types int8_t etc. are mapped to. In C, these types have the same requirements as the corresponding Go types: they are not allowed to have padding bits and have to use two's complement representation, see https://en.cppreference.com/w/c/types/integer. Therefore, these types are guaranteed to have the same domain and representation as the corresponding Go types. So I propose to always represent these types with each other and formally document that fact. It would reduce the need for casts and would make it more obvious that there's no chance of data loss.

This seemed like a reasonable idea, but it breaks existing code (see #31093) and I don't see any way to fix that without losing good error reporting.  So I'm going to roll back the two changes and leave this issue closed.  Sorry.  Perhaps this would have been a good approach if we had started that way, but we didn't.

I don't see any way to fix that without losing good error reporting.

Could you elaborate? It seems like we could define ulong, ushort, etc. as type aliases for the corresponding exact-width C types, but I haven't thought through the full implications of that.
(See also #13467.)

I tried exactly that--defining them as type aliases--and the effect was that the misc/cgo/error err2.go test failed.  It failed because expressions like C.ushort("x") gave an error referring to an error converting to the type uint16, rather than the type C.ushort.  I don't think this change gives us enough of an improvement to merit making the error messages that much more confusing.

Can this issue be reopened now that the PR has been reverted?

Above I commented that I was going to leave the issue closed, because I don't think there is a way to do this that doesn't break existing code.  Do you see a way?

It seems to me that the way to do it would be a two-step process:

Improve the diagnostics emitted by the compiler for aliased types (tracked in #21866).

Change cgo to define and use type aliases for all numeric C types (so that, for example, if C's unsigned long type is 64 bits, _Ctype_ulong is an alias for uint64, not a new defined type).

To my knowledge, no one is working on part (1), but that issue is still open. If/when it is addressed, then this issue could likely also be addressed.

Above I commented that I was going to leave the issue closed, because I don't think there is a way to do this that doesn't break existing code. Do you see a way?

Ah sorry, I had overlooked that statement. I don't really see a good way either. However, if https://github.com/golang/go/issues/29878#issuecomment-520560664 is true, then this might be an option.

OK, reopening.


MOBILE-994 panels: Disable swiping for tablets

I'm sorry but Moodle Mobile 1 is not maintained anymore so I have to close the issue


Added Min/MaxChildren to HasChildFilterDescriptor

.. correspondingly as it was implemented in HasChildQueryDescriptor.cs. This fixes #1505

Yikes - CLA signed and sent.

Awesome! thanks for taking the time to submit a PR @jbattermann
Small nag mind installing the editorconfig visual extension (https://visualstudiogallery.msdn.microsoft.com/c8bccfe2-650c-4b42-bc5c-845e21f96328) and reformatting your changes? http://editorconfig.org/ allows you to have per project indent/line ending settings.

Ahh I had missed that one, too.. but sure thing @Mpdreamz ! Updated the PR after installing the Extension and performing a 'Format Document' on the changed file. Hope it looks good now :)

LGTM :+1: ty for taking the time to fix up indentation, much appreciated :smile:


VSCode started injecting GIT_EDITOR=code --wait to remote container environment variables

All my remote container environments suddenly started having the GIT_EDITOR=code --wait environment variable injected. This means that any git operation run from a terminal window causes a new tab to open the COMMIT_EDITMSG instead of the environment default (typically nano).
VSCode open to a local folder does not have this issue, git operations open in nano as expected.
I tried to find a new setting that might control this behaviour but I did not find anything, nor did I find mention of such a change in recent release notes.
The worst part for me is that this variable takes precedence over any value in ~/.gitconfig, and VSCode overrides any variable set in my .devcontainer folder; I tried adding it to my docker-compose.yaml file and rebuilding the container but the code --wait value persists. e.g.:
services:
  vscode:
    image: mcr.microsoft.com/vscode/devcontainers/base:debian
    user: vscode
    environment:
      GIT_EDITOR: nano

I hope this is not a new default setting that we cannot change and is just a configuration change that I messed up locally, unfortunately this change is highly disruptive for me (and probably many other that prefer to work in the terminal).  😰
Any tips to go back to the original behaviour are appreciated!

VSCode Version: 1.58.2
Local OS Version: macOS BigSur
Remote OS Version: ubuntu:focal
Remote Extension/Connection Type: Docker
Logs:

Steps to Reproduce:

Open a remote container
try to git commit

Does this issue occur when you try this locally?: No
Does this issue occur when you try this locally and all extensions are disabled?: N/A

@jkeech @joshspicer We could update the content here to first check to see if GIT_EDITOR is already set to a value before overriding it.

Oops, I didn't think to check if was an addition to the scripts!
It might be better to check if git config --get core.editor returns a value, it looks like the ~/.gitconfig is copied from the host to the container, where the editor may already be set.

Thanks for the PR.  Merged!


Please merge revision c1e58bfb6981ba78ea6e248ba74411aee42b6aa5 into dev channel

@whesse @mit-mit @kasperl @jmesserly @keertip
This fixes https://github.com/dart-lang/sdk/issues/30591 which is blocking the internal roll.
Merge commit is c1e58bfb6981ba78ea6e248ba74411aee42b6aa5
I have tested the merged code on the dev branch.
Unfortunately rietveld can't handle the dart_sdk.js files.  I pushed a branch with the merge commit here:
https://github.com/dart-lang/sdk/tree/merge_ddc_sdk_fix

Is this getting merged in, or did we decide to just roll a later dev build that already included it?

This is included in the latest dev - dev.16.0


[FEATURE REQUEST] Possibility to share PDF files with OSS Wallet

Describe the solution you'd like
I want to be able to share PDF files with the Wallet. The PDF will be imported then.
Is that possible?
See the screenshot attached

@cs-nero it should already be possible. Will look at it when i am back.
Thanks

@cs-nero It is now released !

Works, nice! Thanks


Error

Hello,
after a few seconds that I open the door contact I get an error and does not update most of the door icon
thanks for help

Unhandled error in Deferred:
Unhandled Error
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/twisted/internet/base.py", line 1192, in run
self.mainLoop()
File "/usr/lib/python2.7/dist-packages/twisted/internet/base.py", line 1201, in mainLoop
self.runUntilCurrent()
File "/usr/lib/python2.7/dist-packages/twisted/internet/base.py", line 824, in runUntilCurrent
call.func(*call.args, **call.kw)
File "/usr/lib/python2.7/dist-packages/twisted/internet/task.py", line 218, in call
d = defer.maybeDeferred(self.f, *self.a, **self.kw)
---  ---
File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 139, in maybeDeferred
result = f(*args, **kw)
File "controller.py", line 129, in status_check
self.send_pushbullet(door, title, message)
File "controller.py", line 178, in send_pushbullet
door.pb_iden = json.loads(conn.getresponse().read())['iden']
exceptions.KeyError: 'iden'
_____________________________________________________________________-

I'll take a look on my end.  I think I'm getting the same error because my notifications are no longer going through to pushbullet.  Maybe their API has changed.

I just set this up on my desk to start testing and am getting the same thing.

The problem is that I accidentally checked in the config file with the notification set to "pushbullet". And without a token that won't work.   I'll change the config when I get to a computer but in the meantime set that value to None.

The property to be set to none is AlertType


Add links to table of contents in README.md

Fixes #298
Add links to the table of contents in README.md.

Table of Contents

Add links to "Live URL", "Frontend", "Backend", "Google Lighthouse", and "Features" sections.
Add links to subsections "General", "Design", "Accessibility", and "Devops / Code quality" under "Features".

For more details, open the Copilot Workspace session.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.53%. Comparing base (4995d46) to head (5b8fe60).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #299   +/-   ##
=======================================
  Coverage   99.53%   99.53%
=======================================
  Files          23       23
  Lines         214      214
  Branches       63       63
=======================================
  Hits          213      213
  Misses          1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Demo link is not working

The link provided as demo doesn't seems to be original link. Chrome complains privacy error and there no date picker found on the page. Page seems to me hijacked.

demo is back online!

offline again... sorry :)


The qwen2.5 system command does not work

I don't know if it's a problem with my use. Under the same system instructions, qwen 2.5 3B does not follow the system instructions.

貌似在ollama更新后好了


Documentation + minor tests

Add documentation for the multi-model journal pub-sub protocol

Codecov Report

Merging #142 into master will increase coverage by 0.47%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #142      +/-   ##
=========================================
+ Coverage   91.62%   92.1%   +0.47%
=========================================
  Files          26      26
  Lines        1708    1709       +1
=========================================
+ Hits         1565    1574       +9
+ Misses         81      76       -5
+ Partials       62      59       -3

Flag
Coverage Δ

#dot
92.1% <100%> (+0.47%)
:arrow_up:

#dot_data
65.78% <ø> (ø)
:arrow_up:

#dot_sync
87.37% <ø> (+0.66%)
:arrow_up:

#dot_undo
100% <ø> (ø)
:arrow_up:

#dot_x_db_mongodb
81.17% <ø> (ø)
:arrow_up:

#dot_x_db_mysql
87.5% <ø> (ø)
:arrow_up:

#dot_x_db_pg
87.95% <ø> (ø)
:arrow_up:

#dot_x_journal
100% <100%> (+2.42%)
:arrow_up:

#dot_x_journal_ws
100% <ø> (+5.35%)
:arrow_up:

Impacted Files
Coverage Δ

ot.go
100% <100%> (ø)
:arrow_up:

x/journal/journal.go
100% <100%> (+4.54%)
:arrow_up:

x/journal/model.go
100% <0%> (+1.38%)
:arrow_up:

sync/reconciler.go
89.84% <0%> (+1.56%)
:arrow_up:

x/journal/ws/ws.go
100% <0%> (+5.35%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23cdbad...0f9fc26. Read the comment docs.


Side by side Hotspot

Dear all,
I have a question about how I can create a hotspot in side by side rendering.
https://www.marzipano.net/demos/side-by-side/
I managed to put my panorama image in side by side :) but I couldn't create a hotspot in both layers :(
So if anyone gave me and code example about that, it will be very helpful.
Thanks in advance

@tjgq What needs to be done to add this to Marzipano exactly? I think it's a very much needed feature for Marzipano to be able to work with hotspots within "VR-mode" the same way

@tjgq What needs to be done to add this to Marzipano exactly? I think it's a very much needed feature for Marzipano to be able to work with hotspots within "VR-mode" the same way


NRF52 Timer - Achieve Low Power When Off

This PR implements a suggested work around to achieve low power with timer off.
NRF52832 Errata v1.9 - 3.19 [78] TIMER: High current consumption when using
timer STOP task only
Symptoms
Increased current consumption when the timer has been running and the STOP task is used to stop it.
Conditions
The timer has been running (after triggering a START task) and then it is stopped using a STOP task only.
Consequences
Increased current consumption.
Workaround
Use the SHUTDOWN task after the STOP task or instead of the STOP task.

@wes3 Agreed. I think the clear timer makes sense.


Failed to connect: IoError(Os { code: 2, kind: NotFound, message: "No such file or directory" })

The rpc application is normally created on https://discord.com/developers/applications/
fn main() {
	App::new()
		.add_plugins(DefaultPlugins)
		.add_plugin(RPCPlugin(RPCConfig{
			app_id: token(),
			show_time: true,
		}))
                .add_system(update_presence)
		.run();
}

fn update_presence(
	mut state: ResMut<ActivityState>,
){
        state.instance = Some(true);
        state.details = Some("Hello World".to_string());
        state.state = Some("This is state".to_string());
}

Function token() simply returns my token variable
But I get this error for some reason:
Failed to connect: IoError(Os { code: 2, kind: NotFound, message: "No such file or directory" })
OS: Ubuntu Budgie 20.04
Kernel: 5.13.0
Library Version: 0.2.2
Bevy Version: 0.7

Could you please add the following information:
OS: Eg. Windows
Kernel: (only if on Linux) Eg. 5.17
Library Version: Eg. 2.1.7
Base library or user within Bevy,
Thanks :)

If I am not mistaken, this occurs when the user does not have Discord open.
I will ensure that this error does not result in a process kill ever as it shouldn't.

Will be resolved in #4

Could you please add the following information:
OS: Eg. Windows Kernel: (only if on Linux) Eg. 5.17 Library Version: Eg. 2.1.7 Base library or user within Bevy,
Thanks :)

I've added this information, sorry

If I am not mistaken, this occurs when the user does not have Discord open.
I will ensure that this error does not result in a process kill ever as it shouldn't.

And the Discord is openned. It's not snap/flatpak, but only regular .deb

Please, @jewlexx , reopen the issue :)

@andezitgq Thank you for adding the info. I believe that this is an issue with how Linux installs the Discord application.
Could you clone this repository, and checkout fix/unix, then run cargo run --bin discord_presence and let me know if it works.

I've found out the problem - it was because of snap installation (but I thought it was regular :P). In .deb installation all works fine, but I am afraid, whether a user will have snap installation or simply a closed Discord, and his game will crash ;(
Could you make an app not crash if not finding a launched copy of Discord, but ignore it?

I am not sure why the game is freezing.
Freezing = crashing, because in the example the game doesn't crash immediately, but "freeze", if Discord is closed

I haven't been able to replicate this issue on my end. If you could link a repository with a minimal example, or even just a main.rs file so I can replicate it and debug some more.

Sorry for inaction, you wanted a minimial example, which makes the issue, so there is: https://gist.github.com/andezitgq/c12e19fa7e3fd41c75ed0277299d9593
It is a simple code, made from bevy example, where it works, when Discord is openned, and freezes the game, when it is closed. It is pretty strange, that nobody have opened the issue yet.
Also after update to 0.5.3 there is an another error now...
Failed to connect: IoError(Os { code: 111, kind: ConnectionRefused, message: "Connection refused" })

I am unfortunately still unable to replicate the issue. The game doesn't seem to freeze and I don't get any error message.
Could you please describe in detail what happens vs what you expect to happen?
I noticed you're on Ubuntu Budgie so I will quickly install that in a VM and see if that allows me to reproduce the issue.

Could you please describe in detail what happens vs what you expect to happen?

I don't actually know, what to add :)
I've noticed, that in your code there is creating a thread of connection, and there, if it doesn't connect, it freezes the thread for 10 seconds and tries to reconnect each time, so it is an infinite loop. Could you try to rethink it? I'll try it too by myself

I've downloaded discord-presence and bevy-discord-rpc packages, and... It is working :)
Error message is the same, but it doesn't freeze anything. Maybe there is a problem in the packages of crates.io.

I've downloaded discord-presence and bevy-discord-rpc packages manually, having compiled them, and... It is working :) Error message is the same, but it doesn't freeze anything. Maybe there is a problem in one of the packages of crates.io.

Nice to hear it is working! I'll update the crates.io index ASAP
I am going to work on moving to the tracing crate for logging, which will allow the developer to hide the error messages should they please (I will put them under the debug log level)


[BUG] Doors do not udate for other players on multiplayer servers.

Important Information
Minecraft Version: Forge 1.19.2
Mod Loader System: Forge (Forge or Fabric)
DramaticDoors Version: DramaticDoors-Forge-1.19.2-2.1.10
Describe the bug
The door states are bugged they update on the server side and client side for the person interacting with the door but do not update on another player on the same server.
To Reproduce
The steps to recreate are as follows:

Run mod on a forge server 1.19.2 Ver.
Need 2 players
Ask one player open the custom door from the mod Dramatic doors.
You will now see the door in closed state even if the door is open for the other person and on server side aswell.

Expected behavior
When another player interacts with the door the door should open for both the players on the server where as the state of the door is only updated on the interacting players client and not the passive players client
Screenshots
Cannot provide screenshots.

That is a tricky one to fix, I may have to look into it. Have you tried opening using redstone. Does it update for other players?

That is a tricky one to fix, I may have to look into it. Have you tried opening using redstone? Does it update for other players?

Nah it does not even work for the  person who is activating the redstone itself

This is unusual as I tried running a dev test server with 2 clients connected. When one player opens and closes the door, the other player still sees the door updating.

Quick update. It doesn't seem as though your mod is the only one. Security Craft's reinforced doors do the same. They are activated by redstone so there is no "active" player. Meaning that although Dramatic doors only open for the player who placed, and opens the doors, the reinforced door shows up and then refuses to show its opened. The only way to do it is by powering it, then clicking each section of the door to force a block update. After seeing that I decided to test the same for the Dramatic doors with an identical result. Door is powered, noise of door opening plays, but the door visibly stays shut. If you walk into the door you are blocked as if it were closed, click the sections of the door to force the block update and bam, like magic it works and you can walk theough. Same thing vis versa. Door is opened, unpower it, it stays visibly opened but trying to walk through results in rapid teleporting backwards to the outside of the door.

It's a strange issue. Maybe other mods could possibly be causing some sort of block update suppression or something?

i am having this same issue too
forge 43.2.14
mc 1.19.2
dramatic doors 1.19.2-2.3.7_1
i will say i also have double doors mod, which could be part of the issue for you guys if you have it
i think quark also has a door related feature perhaps if you guys had that

I have the same issue, disabling double doors on quark didn't fix the problem and I am not using the double doors mod.


botan2: 2.19.3 -> 2.19.4

Full release notes: https://botan.randombit.net/news.html#version-2-19-4-2024-02-20
Selected items:

Fix DoS with arbitrary length primes of ECC curves
Switch to constant time GCD
Fix for NIST KeyWrap
Add support for short nonces with AES-XTS

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 302530 run on aarch64-darwin 1

2 packages marked as broken and skipped:

biboumi
step-kms-plugin

1 package failed to build:

monotone

14 packages built:

botan2
botan2.dev
chickenPackages_5.chickenEggs.botan
esphome
esphome.dist
esptool
esptool.dist
keepassxc
qownnotes
rehex
rnp
rnp.dev
rnp.lib
softhsm

Weird, it builds fine on aarch64-darwin for me. Maybe it's a fluke? Botan also doesn't seem very relevant for manpage generation.
@ofborg build monotone

Thanks for chiming in @lheckemann, maybe you could share details about your test setup?
I've fetched this PR branch using git fetch origin pull/302530/head:pr/302530 and switch to the branch using git switch pr/302530 and then build monotone using nix build -L .#monotone with which I reliably run into the manpage install error.

@afh does this also happen for you on master (using the --rebuild flag or --check for older nix-build)?

Thanks for the suggestion, @risicle. Using nix build --rebuild .#monotone fails with the same error on master

On an M1 macbook air (ignore the silly hostname):
linus@windows7 master % git show
commit 59ef524f69962e5b5de5b767aadb9af325dd7f65 (HEAD)
Author: Markus Theil<EMAIL_ADDRESS>Date:   Sun Mar 24 16:37:50 2024 +0100

    botan2: 2.19.3 -> 2.19.4

    Full release notes: https://botan.randombit.net/news.html#version-2-19-4-2024-02-20

    Selected items:
    * Fix DoS with arbitrary length primes of ECC curves
    * Switch to constant time GCD
    * Fix for NIST KeyWrap
    * Add support for short nonces with AES-XTS

    Signed-off-by: Markus Theil<EMAIL_ADDRESS>
diff --git a/pkgs/development/libraries/botan/2.0.nix b/pkgs/development/libraries/botan/2.0.nix
index 53b4e167a7d9..c9a45218dfb4 100644
--- a/pkgs/development/libraries/botan/2.0.nix
+++ b/pkgs/development/libraries/botan/2.0.nix
@@ -2,6 +2,6 @@

 callPackage ./generic.nix (args // {
   baseVersion = "2.19";
-  revision = "3";
-  hash = "sha256-2uBH85nFpH8IfbXT2dno8RrkmF0UySjXHaGv+AGALVU=";
+  revision = "4";
+  hash = "sha256-WjqI72Qz6XvKsO+h7WDGGX5K2p2dMLwcR0N7+JuX8nY=";
 })
linus@windows7 master % nix-build -A monotone
/nix/store/gn16vxq006mbgbh3n9pj7w1ln8w3a8nv-monotone-1.1-unstable-2021-05-01
linus@windows7 master % nix eval -f . monotone.drvPath
"/nix/store/98sp6x3a70hd2znyi9yg11agw45cpkyy-monotone-1.1-unstable-2021-05-01.drv"

!? it turns out I had the build sandbox disabled for some reason. However, either it's not being enabled correctly or the build still succeeds in the sandbox.
Given that it's broken on ofborg too though, the breakage is not a fluke.

I got access to a Macbook myself. The following error happens:
> $ bin/mtn manpage
*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[__NSCFString stringByStandardizingPath]: unrecognized selector sent to instance 0x600003328930'
*** First throw call stack:
(
	0   CoreFoundation                      0x000000019bf92ccc __exceptionPreprocess + 176
	1   libobjc.A.dylib                     0x000000019ba7a788 objc_exception_throw + 60
	2   CoreFoundation                      0x000000019c04502c -[NSObject(NSObject) __retain_OA] + 0
	3   CoreFoundation                      0x000000019befccdc ___forwarding___ + 1580
	4   CoreFoundation                      0x000000019befc5f0 _CF_forwarding_prep_0 + 96
	5   Foundation                          0x000000019cffbcd4 -[NSProcessInfo arguments] + 188
	6   CoreFoundation                      0x000000019c00eaac __getDefaultArguments_block_invoke + 96
	7   libdispatch.dylib                   0x000000019bc8e3e8 _dispatch_client_callout + 20
	8   libdispatch.dylib                   0x000000019bc8fc68 _dispatch_once_callout + 32
	9   CoreFoundation                      0x000000019c00e448 _addBackstopValuesForIdentifierAndSource + 652
	10  CoreFoundation                      0x000000019bec83dc __81-[_CFXPreferences(SourceAdditions) withNamedVolatileSourceForIdentifier:perform:]_block_invoke + 144
	11  CoreFoundation                      0x000000019c00e0e4 -[_CFXPreferences withNamedVolatileSourceForIdentifier:perform:] + 272
	12  CoreFoundation                      0x000000019bece764 -[CFPrefsSearchListSource addNamedVolatileSourceForIdentifier:] + 136
	13  CoreFoundation                      0x000000019c04d54c __108-[_CFXPreferences(SearchListAdditions) withSearchListForIdentifier:container:cloudConfigurationURL:perform:]_block_invoke.155 + 296
	14  CoreFoundation                      0x000000019c04d1f4 -[_CFXPreferences withSearchLists:] + 84
	15  CoreFoundation                      0x000000019bec9cb4 __108-[_CFXPreferences(SearchListAdditions) withSearchListForIdentifier:container:cloudConfigurationURL:perform:]_block_invoke + 300
	16  CoreFoundation                      0x000000019c04d3a0 -[_CFXPreferences withSearchListForIdentifier:container:cloudConfigurationURL:perform:] + 384
	17  CoreFoundation                      0x000000019bec95d8 -[_CFXPreferences copyAppValueForKey:identifier:container:configurationURL:] + 156
	18  CoreFoundation                      0x000000019bec9500 _CFPreferencesCopyAppValueWithContainerAndConfiguration + 112
	19  libintl.8.dylib                     0x0000000100a4424c _nl_locale_name_default + 72
	20  libintl.8.dylib                     0x0000000100a42480 libintl_dcigettext + 1984
	21  mtn                                 0x000000010011b100 _Z1FPKc + 24
	22  mtn                                 0x00000001001be2f4 _ZN8commands9cmd_storeC2Ev + 200
	23  mtn                                 0x00000001001bff48 _GLOBAL__sub_I_cmd_merging.cc + 1212
	24  dyld                                0x000000019bad105c ___ZZNK5dyld46Loader25findAndRunAllInitializersERNS_12RuntimeStateEENK3$_0clEv_block_invoke + 168
	25  dyld                                0x000000019bb0f0d4 ___ZNK5dyld313MachOAnalyzer18forEachInitializerER11DiagnosticsRKNS0_15VMAddrConverterEU13block_pointerFvjEPKv_block_invoke.202 + 172
	26  dyld                                0x000000019bb0299c ___ZNK5dyld39MachOFile14forEachSectionEU13block_pointerFvRKNS0_11SectionInfoEbRbE_block_invoke + 496
	27  dyld                                0x000000019bab22fc _ZNK5dyld39MachOFile18forEachLoadCommandER11DiagnosticsU13block_pointerFvPK12load_commandRbE + 300
	28  dyld                                0x000000019bb01930 _ZNK5dyld39MachOFile14forEachSectionEU13block_pointerFvRKNS0_11SectionInfoEbRbE + 192
	29  dyld                                0x000000019bb04208 _ZNK5dyld39MachOFile32forEachInitializerPointerSectionER11DiagnosticsU13block_pointerFvjjRbE + 160
	30  dyld                                0x000000019bb0edc8 _ZNK5dyld313MachOAnalyzer18forEachInitializerER11DiagnosticsRKNS0_15VMAddrConverterEU13block_pointerFvjEPKv + 432
	31  dyld                                0x000000019bacd070 _ZNK5dyld46Loader25findAndRunAllInitializersERNS_12RuntimeStateE + 524
	32  dyld                                0x000000019bad3614 _ZNK5dyld416JustInTimeLoader15runInitializersERNS_12RuntimeStateE + 36
	33  dyld                                0x000000019bacd45c _ZNK5dyld46Loader23runInitializersBottomUpERNS_12RuntimeStateERN5dyld35ArrayIPKS0_EE + 220
	34  dyld                                0x000000019bad10ec _ZZNK5dyld46Loader38runInitializersBottomUpPlusUpwardLinksERNS_12RuntimeStateEENK3$_1clEv + 116
	35  dyld                                0x000000019bacd628 _ZNK5dyld46Loader38runInitializersBottomUpPlusUpwardLinksERNS_12RuntimeStateE + 380
	36  dyld                                0x000000019baf04d8 _ZN5dyld44APIs25runAllInitializersForMainEv + 464
	37  dyld                                0x000000019bab6f7c _ZN5dyld4L7prepareERNS_4APIsEPKN5dyld313MachOAnalyzerE + 3156
	38  dyld                                0x000000019bab5edc start + 1844
)
libc++abi: terminating due to uncaught exception of type NSException
[1]    8998 abort      bin/mtn manpage

I disabled the manpage generation and tested the command used in the Makefile.

Shall we fix this or live without a monotone manpage on MacOS?


Abuse by online casino

Casino Vulkan Vegas-online is continuously placing nodes in various parts of Germany looking like this:
onosm.org submitted note from a business:
name: Casino Vulkan Vegas-online
phone: 49 2571 51600
website: https://casino-vulkanvegas-online.com/
twitter: undefined
hours:
category: Video Game Stores
address: Saerbecker Str. 2 Greven North Rhine-Westphalia 48268
It is an online casino with a contact number in Cyprus. Every time I raise this as spam and it gets removed, a new one pops up somewhere else with the same content but different address. A current note is 2322821 but it might not live very long.
Please prevent such a systematic abuse of the app.

Thanks for flagging this. This system will never be able to entirely prevent spam like this. If there's a specific change you can suggest to make it harder to abuse, I'm open to ideas.

Thank you for your response.
Are there actually any spam filters already implemented?
Here is a list of websites, these casinos use:
https://vegasslots777.com/
https://slottyvegas.com/en
https://vulkan-vegas-de.com/
https://vulkanvegas-online-casino.com/
https://slottyvegas.info
https://casino-vulkanvegas-online.com/
There are actually two, vulkanvegas from Cyprus and Slottyvegas from Malta. (Of course, these might actually be the same.)
An idea would be the following:

Block the creation of any nodes submitted through onosm which contain at least two of the strings
"vulkan", "vegas" and "slotty".

This would block all the nonsense. Of course, they can react to this, but let's see if they do.
Best, Limes


[BUG] Kaoto backend not providing full list of kamelets from the catalog when connected to minikube

Describe the bug
The issue I'm facing is related to the response from the endpoint http://localhost:8081/v1/steps?dsl=KameletBinding&namespace=default
The start and end kamelets are not present in the response - the only start kamelet present is the "knative" and the end ones are "knative-sink" and "stop EIP"
To Reproduce
Steps to reproduce the behavior:

run minikube locally with camel-k installed (kamelet catalog is present)
be logged into the minikube with kubectl
in the UI - view the kamelet catalog, or go to
See error

Expected behavior
Previously the response provided all of the start and end kamelets from the kamelet catalog.
Environment (please complete the following information):

minikube with camel-k 1.10.2-nightly
Kaoto Version - built from latest master, running in dev mode (mvn quarkus:dev -pl api)

Additional context
Add any other context about the problem here.

I think this is calling for strengthening the way we configure our sources for steps. Right now if there is a connection to a kubernetes cluster, it reads kamelets from there. But if the cluster is empty or you don't have privileges to read the kamelets, you may not get any.

@Delawen with the latest Kaoto backend version, this no longer seems to be an issue. I think it can be closed


Talking about API "Contracts"

Pascal Thesing und Florian Büscher

List of available authorities
/merchant-api/authorities

Login
/merchant-api/login

Params
{
"email": "",
"password": ""
}
´``

# Registration

/merchant-api/register

## Params
```json
{
"authority": "",
"email": "",
"password": "",
"name": "",
"firstName": "",
"lastName": "",
"salutation": "",
"street": ""
"zipCode": "",,
"city": "",
"country": "",
"phoneNumber": ""
}

# Profile

GET /merchant-api/profile

## Response
Returns the profile

PATCH /merchant-api/profile

## Params:

{
"description": "";
phone,
website,
"name": "",
"firstName": "",
"lastName": "",
"salutation": "",
"street": ""
"zipCode": "",,
"city": "",
"country": "",
"phoneNumber": ""
}

# Products

List

GET /merchant-api/products

GET /merchant-api/products/[ID]

POST /merchant-api/products

## Params

```json
{
name,
description,
images,

}

DELETE /merchant-api/products/[ID]

There are still apis missing a think.

login is done through sales-channel-api/v1/customer/login

Closed as documented now in https://github.com/shopware/portal/wiki/Merchant-API