get 400 when using cloudflare

hi. im using wstunnel with cloudflare. but i get this error:
2024-06-07T13:37:46.875975Z  INFO wstunnel::tcp: Opening TCP connection to cdn.example.com:8443
Jun 07 14:37:46 sajjad wstunnel[3912]: 2024-06-07T13:37:46.890491Z ERROR tunnel{id="018ff2eb-6e81-73ed-90e7-a333b0bcaaf3" remote="localhost:2083"}: wstunnel::tunnel::client: failed to do websocket handshake wit>
Jun 07 14:37:46 sajjad wstunnel[3912]: Caused by:
Jun 07 14:37:46 sajjad wstunnel[3912]:     Invalid status code: 400
my server and client commands are:
server:
wstunnel server wss://<IP_ADDRESS>:8443
client:
wstunnel client -L tcp://<IP_ADDRESS>:443:localhost:443 -L tcp://<IP_ADDRESS>:2083:localhost:2083 wss://cdn.example.com:8443
i have a nginx on server side. Please help me solve this issue.

Try with the port 443 first, not sure port 8443 is allowed everywhere.

i cant. 443 is used by nginx. 8443 is allowed from cloudflare. one of the best benefit of wstunnel is that we can point client to the server with a domain behind cloudflare cdn. this feature work in v5 but not in v9. please help me solve this issue.

Can you provide the logs of the client and server, and both started with --log-lvl=debug ?

client:
Jun 14 08:34:39 sajjad wstunnel[17544]:     Invalid status code: 400
Jun 14 08:34:39 sajjad wstunnel[17544]: 2024-06-14T07:34:39.660500Z DEBUG rustls::common_state: Sending warning alert CloseNotify
Jun 14 08:34:39 sajjad wstunnel[17544]: 2024-06-14T07:34:39.664319Z ERROR tunnel{id="019015ab-8009-7862-93f2-a75b4207d9fe" remote="localhost:2083"}: wstunnel::tunnel::clie>
Jun 14 08:34:39 sajjad wstunnel[17544]: Caused by:
Jun 14 08:34:39 sajjad wstunnel[17544]:     Invalid status code: 400
Jun 14 08:34:39 sajjad wstunnel[17544]: 2024-06-14T07:34:39.664408Z DEBUG rustls::common_state: Sending warning alert CloseNotify
Jun 14 08:34:39 sajjad wstunnel[17544]: 2024-06-14T07:34:39.691875Z  INFO wstunnel::tls: Doing TLS handshake using SNI DnsName("p2cdn.ninjav.com") with the server(wss://cdn.example.com:8443)
Jun 14 08:34:39 sajjad wstunnel[17544]: 2024-06-14T07:34:39.692072Z DEBUG rustls::client::hs: Resuming session
Jun 14 08:34:39 sajjad wstunnel[17544]: 2024-06-14T07:34:39.693402Z  INFO wstunnel::tls: Doing TLS handshake using SNI DnsName("p2cdn.ninjav.com") with the server (wss://cdn.example.com:8443)
Jun 14 08:34:39 sajjad wstunnel[17544]: 2024-06-14T07:34:39.693544Z DEBUG rustls::client::hs: Resuming session
server:
Jun 14 07:33:20 sajjad wstunnel[63451]: Rejecting connection
Jun 14 07:33:20 sajjad wstunnel[63451]: CLOSE connection to localhost:443
Jun 14 07:33:21 sajjad wstunnel[63451]: NEW incoming connection from <IP_ADDRESS>:63072 [("X-Forwarded-For","2a0f:2b8:2a:2:1:1:7>
Jun 14 07:33:21 sajjad wstunnel[63451]: CONNECTING to localhost:443
Jun 14 07:33:21 sajjad wstunnel[63451]: NEW incoming connection from <IP_ADDRESS>:31240 [("X-Forwarded-For","2a0f:2b84:2a:2:1:1:7>
Jun 14 07:33:21 sajjad wstunnel[63451]: CONNECTING to localhost:443
Jun 14 07:33:21 sajjad wstunnel[63451]: NEW incoming connection from <IP_ADDRESS>:64584 [("X-Forwarded-For","95.38.24...")]
Jun 14 07:33:21 sajjad wstunnel[63451]: Rejecting connection
Jun 14 07:33:21 sajjad wstunnel[63451]: NEW incoming connection from <IP_ADDRESS>:52902 [("X-Forwarded-For","2a0f:2b84:2a:2:1:1:75>
Jun 14 07:33:21 sajjad wstunnel[63451]: CONNECTING to localhost:443


Specify module for CMinx API documentation

Is this pull request associated with an issue(s)?
Fixes #39.
Description
Based on the updates from CMakePP org .github PR 18, CMinx API documentation can be generated if an api_docs_module name is provided. In this case, that will be cmakepp_lang. This should generate the API documentation when the deploy_docs action is performed.

@ryanmrichard I forgot to add the [skip ci] tag to my commit, but I don't think this affects the unit tests at all, so the tests should be able to be skipped.


Showcase this paper on the showyourwork docs?

Hey @afeinstein20, would you be interested in showcasing this paper on the showyourwork documentation? It's just a matter of entering the metadata in this JSON file via a PR.

Oh, this is sweet! I will definitely enter our info here. Thanks!!


Operation metadata

The Operation item is missing in the metadata tables. Can you please add this given it's a required item?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4ef1dd8e-af23-c899-9613-01e8d4a2b0a3
Version Independent ID: 238b4ce3-4f2f-934f-2653-3cbd27e5ea2c
Content: Enable one-time password (OTP) verification - Azure AD B2C
Content Source: articles/active-directory-b2c/one-time-password-technical-profile.md
Service: active-directory
Sub-service: b2c
GitHub Login: @mmacy
Microsoft Alias: marsma

@ Thank you for your feedback. We will investigate and update the thread further.

Thanks for your feedback. I fixed this issue and created a pull request.

Fixed by https://github.com/MicrosoftDocs/azure-docs-pr/pull/103093
#please-close


Figure 42 generation command

Hi,
Book 1, figure 42 : how do you have this screen ?
Because if I enter zowe, in groups, I do not have copy.

OK : zowe files


Update ConfigManagementPlugins handling

Make configmanagement plugins optional
Allow for old style cmp's via legacyConfigManagementPlugins
All for "CMP 2.0" plugins aka sidecar plugins (now preferred)
Add new argoCD key to clusterGroup values with needed schema changes

Note: experimentation seems to indicate that CMP 2.0 deliberately makes it difficult (that is, practically impossible) to run executables inside the repository, so this feature will not support doing that with CMP 2.0. Users who really need that can used the CMP 1.0 framework (Which this PR supports) or plan to migrate.


Update README.md

Just a few spelling corrections in the readme.

Thanks! Can you fix one more, comparisions should be comparisons

No problem.
Removed whitespace as requested; also, comparisions is now comparisons (both committed to my fork)


fix race condition in update_image

Abort async job always, this prevents previous item job finishing and showing incorrect image for current item.

Thanks!


PowerShell LanguageMode can break shell integration

See https://github.com/PowerShell/PowerShell/issues/17900

/duplicate #158548


Using ROAD on Tabular data with SHAP

Hi, I'm interested in running ROAD on scikit-learn models which are trained on tabular data (pandas dataframes). I'm also planning to use SHAP as the explainer. Would ROAD work in such a setting?

Hi, thanks for this interesting question! The current implementation is targeted towards images, but the theory behind ROAD is more general: It defines the notion of a minimally revealing imputation, which does not permit to infer which pixels were original an which were imputed. Therefore, you need to find a minimally revealing imputation scheme for your tabular data set.
Maybe you can try running an imputer like MissForest (https://pypi.org/project/missingpy/) or GReaT (https://openreview.net/forum?id=cEygmQNOeI), however I would not recommend the Noisy Linear Imputation for this purpose. I hope this answers your question!
Best wishes!

Thank you! I'll give it a shot and check back in with you.


Remove custom partitioning pointer from pre-compiled HLO

When hashing the pre-compiled IR during computation of the JAX compilation cache key, function that use custom_partitioning produce a different hash every time even for the same underlying computation. This is because of the backend_config pointer changing across runs. To make the compilation cache work for functions that implement custom_partitioning, this PR includes a flag, which when set will set that pointer to be a constant.

@nouiz @jaro-sevcik

We may want to consider just putting a counter on the MlirContext. That way we can make stable uuids.

We may want to consider just putting a counter on the MlirContext. That way we can make stable uuids.

@pschuh What would be the goal of that counter?

@hawkinsp I think this is ready to be merged?


Issue in Snapshot taking

Hi all,
while taking snapshot in s3 repo, getting below expections
{"error":"RemoteTransportException[[nodename][inet[/ip:port]][cluster/snapshot/create]]; nested: SnapshotCreationException[[my_s3_repository:snapshot_1] failed to create snapshot]; nested: IOException[Failed to get [snapshot-snapshot_1]]; nested: AmazonS3Exception[AWS authentication requires a valid Date or x-amz-date header (Service: Amazon S3; Status Code: 403; Error Code: AccessDenied; Request ID: xxxxxxxxxxxxxxxxx)]; ","status":500}
can any one help us!!!

This repo is now closed. Please ask on discuss.elastic.co with all details like versions (jvm, elasticsearch)


Troubleshoot tails file rollover

Put tails file up from admin API.
Simplify issuer revocation registry state machine and related issue-credential logic.

I think we got it! Tested as follows:

create new test schema
create new cred_def based on new schema, supporting revocation

simulated outage on tails-server during creation so that tails files could not get uploaded

the agent created two revocation registries (that would not have a tails file on the server): marked both of them full
issue credentials until the first registry is full, revoke all of them
continue issuing credentials on the next registry, and revoke them

Everything seemed to work as expected so hopefully we're good. There is a chance of additional outages happening right when one of the "next" tails-files is being uploaded to the tails-server, but haven't pushed my luck that far with testing since it really looks like an even rarer edge case considering now we have multiple retries to upload.


Don’t enforce export/declare overload modifier consistency across module augmentations

Fixes #58756
These rules are only there because it looks confusing to have overload declarations like
// what does this mean??
declare function foo(): any;
function foo(s: number): string;
export declare function foo(s: string): number;

But if the overloads came from a module augmentation, it's reasonable for them to have different modifiers (see code comment and tests for the differences that are allowed).

@typescript-bot test it

I feel like I don't have a good understanding of the old behavior to be able to assess the new one. Why was the old behavior in place? What are the bad scenarios we're trying to avoid, exactly?

Stating my understanding, but I might have some of the details wrong. AFAIK, overloads are additional declarations of the same method/function symbol. Since there’s ultimately only one merged symbol, all these modifiers necessarily apply uniformly to the symbol. We don’t really have mechanisms in place to reason about what it would mean for some signatures to be exported while others aren’t. And the presence or absence of declare on an overload signature doesn’t really have any meaning at all, since overloads aren’t a runtime/emitting construct anyway. So I think the rules are in place because the mixing of modifiers like
export function foo(x: T1): T2;
export function foo(x: T3): T4;
       function foo(x: T5): T6;
export function foo(x: any): any {
  // ...
}

looks like it might make the third overload file-local, but there’s actually nothing in place to make that happen, so we want to enforce consistency in the modifiers.


Stack overflow

Windows 10, Postgres 14.4, Postgis 3.4, Dbeaver 21.2.2
Stack overflow in line: 1
when clicking on the Spacial tag in a select with a geometry geom column (after displaying the results correctly in the Grid and Text tags)

Hello @solisgb,
Can you please provide footage showing the issue? Thanks.

Thank you for your interest,
I run the select and visualize the results in text mode (DBeaver_01.png)
I press Spacial and after a while I get a popup window (Desbordamiento de
pila en la línea: 1, en English Stack overflow in line: 1, DBeaver_02.pnp)
I press Aceptar, Accept, and nothing is displayed (DBeaver_03.png)
I press Text and I can return to the results of the select (DBeaver_01.png)
If I execute the same select in QGIS I can visualize the results.
This data can be downloaded from:
http://centrodedescargas.cnig.es/CentroDescargas/locale?request_locale=en
Then press:Municipal, provincial and autonomous boundaries
And the shp is:
lineas_limite.zip\SHP_ETRS89\recintos_autonomicas_inspire_peninbal_etrs89\
Luis
PS. Attached are screenshots
El jue, 14 jul 2022 a las 14:31, ShadelessFox @.***>)
escribió:

Hello @solisgb https://github.com/solisgb,
Can you please provide footage showing the issue? Thanks.
—
Reply to this email directly, view it on GitHub
https://github.com/dbeaver/dbeaver/issues/17082#issuecomment-1184390953,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJBSDB3IX4TFGDOSY5BG4OLVUACA3ANCNFSM53RUYH4Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

Unfortunately, I can't see any of your attachments. You have to attach them on GitHub.

I hope you can now see the images:

It seems that it's not enough information, unfortunately.
Could you please send me the log files? You can find instructions here: https://dbeaver.com/docs/wiki/Log-files/.

I include one of the log files. I have others as a result of this problem with the same content.
dbeaver_sql_20220714.log
Thank you and best regards

There should be the dbeaver-debug.log file. That one you've sent doesn't contain any useful information.

Here it is
dbeaver-debug.log

I'm still unable to find anything useful, sorry.
Please make sure that the issue persisted during the last session. Delete these log files, reproduce the issue, and then send logs again.

I have reproduced the error. I am afraid that the log files do not indicate anything relevant, I include them for you
dbeaver_sql_20220719.log
dbeaver-debug.log

I'm still unable to find anything useful :(
Can you please make a thread dump when you experience this issue? Thanks. https://github.com/dbeaver/dbeaver/wiki/Making-a-thread-dump

The select returns 20 geometries of multipolygon type; 693,297 points in all geometries; the geometry with the most points has 140,155 points.
I include the process ID in Windows 10.

Application status

ID: 11916

Applications open at the time of the incident

It seems that the error is related to the number of points in the geometry.
If I run a select for each geometry, the problem only appears with gid 10 (geometry with 140,155 points) and gid 13 (geom127,037 points), but no longer with gid 17 (geom 101,704 points).
If I run a select with all rows except gid 10 and 13 the geometries are represented correctly.
I include a csv file (zipped) with these geometries in text format in case it can help you.
gid|st_npoints|
---+----------+
10|    140155|   <- Warning
13|    127037|   <- Warning
17|    101704|
20|     51828|
18|     44566|
12|     41221|
8|     40321|
14|     32344|
15|     21579|
9|     20550|
6|     17328|
16|     16517|
19|     13732|
11|     10330|
7|      5471|
5|      3256|
4|      2758|
1|      1855|
3|       646|
2|        99|
gid_13_10.zip


Fix build broken by simultaneous PR merges.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d2a3ff3). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #90   +/-   ##
=========================================
  Coverage          ?   84.62%
=========================================
  Files             ?       40
  Lines             ?     5659
  Branches          ?        0
=========================================
  Hits              ?     4789
  Misses            ?      870
  Partials          ?        0

Impacted Files
Coverage Δ

endpoints/test/openapi_generator_test.py
87.15% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2a3ff3...b526992. Read the comment docs.


Add advertisement interval support in BLE HAL

Add advertisement interval support in BLE HAL
Description
Add new params usMaxAdvInterval and usMinAdvInterval in BTGattAdvertismentParams_t structure to configure advertisement intervals.
This also fixes #1514
Checklist:

[ ] I have tested my changes. No regression in existing tests.
[ ] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/bot run checks


M5 cardputer launch UIFlow2 reboots in a loop

Already change the partition scheme to "UIFLOW2"
M5Launcher version 2.3.0
UIFlow version 2.1.6
download from the OTA and install, but can't lanch, reboots in a loop
anybody can help me?

Hello my friend,
thank you for the Report!
UIFlow Application became bigger than what Launcher can handle in this last update... Launcher reserves an area of 0x450000 bytes for it ( https://github.com/bmorcelli/M5Stick-Launcher/blob/34b126141dd7962053e0df7663f14931051c8139/custom_8Mb.csv#L21 ), and in a quick analysis UIFlow factory application increased to 0x45B190 bytes.. So I need to adjust it to at least 0x460000 bytes
So I need to remake the partition scheme for this, and I´ll release the next version on M5Burner in a few hours.

Solved in this release 2.3.1, use the webflasher.. i will upload to m5burner in a few hours


Add BV-variable with condition inference

Closes #25 .

It's kind of clunky, and it doesn't really work, but I think merging this now is the right idea, because there are two PRs that will come from this later.


feat: streaming files

I also took the liberty to update some outdated references to Deno.File.

I think we should also mention the higher level API (ie readable.pipeTo(writable) call). In my view, pipeTo and pipeThrough methods are sufficient for most streaming programs.

Should piping be a different example?

A different example for piping sounds good.

I was thinking about how to integrate piping into this example but I'm not sure how to go about it.

How about the examples of piping between fetch body to fs writable stream, fs readable stream to stdout.writable, etc.

Is showing the lower-level api even valuable?

I now think this example is good enough for demonstrating streaming with granular control. Let's iterate on the balance between lower-level APIs and higher-level APIs.


Add option: Choose new tech/civic button goes to tree instead of picker

Strongly support this change.  Though it is easy to get to the trees via keybind, currently you've still got the extra panel unnecessarily open and needing to be closed.

Just a thought, atm when you reach the end of the Culture tree you can't reselect the last two (globalization and can't remember :p) you have to do it via the side panel. With this change it would be great to be able to do it from the tree.


BIGTOP-2858:Add AArch64 support for Debian 9

Change-Id: I5c77ba239375658223eb9025308f98d2bdb57e58
Signed-off-by: Yuqi Gu<EMAIL_ADDRESS>

While I am not sure we are going to have the official support for Debian 9 - well, I just don't remember if we have discussed it yet ;) - the patch looks good and I am committing this. Thanks!


scipy.linalg.norm do not respect matrix sparsity

scipy.linalg.norm takes a dense array of matrix/vector entries as an input. If one has a large and sparse matrix, the only correct way for calculating e.g. L1 matrix norm is to convert it to call todense() first. Would be good to have calculation of norms respecting matrix sparsity.

There is sparse.linalg.onenormest for L1 norm.

Thanks for the reference. But its good to have more matrix norms: L2/largest singular value, Frobenius, min singular value similar to linalg.norm etc. I actually need to estimate condition numbers, and just realised there is no easy way.

Would be good to have calculation of norms respecting matrix sparsity.

This has been on the scipy todo list for a long time (https://github.com/scipy/scipy/issues/545)!
After abstract linear operator PRs like https://github.com/scipy/scipy/pull/4316 and https://github.com/scipy/scipy/pull/4294 are merged I plan to revive https://github.com/scipy/scipy/pull/4095 and also to implement the condition number estimation.  Searching the scipy github for sparse matrix norm PRs/issues I also see https://github.com/scipy/scipy/pull/3303.

Seems you have a plan. I did not look into PRs like #4316 and #4294 yet, but from the discussion in  #3303 it seems it's nearly done.
Do you feel it makes any sense reviving #3303 (if it's quick)? I might be able to spend a little time on that, but since this would be my first commit to scipy, I'll need some basic guidance.

Do you feel it makes any sense reviving https://github.com/scipy/scipy/pull/3303

Yes, but I'm not great with git/github, so I'm not sure what is the best way to deal with PRs that may or may not be abandoned.  The crudest way would be to make your own new branch and just copy the changes from that PR into your branch, but this would lose the original meta-data.  I'm not sure how much people care about that -- I probably care about it less than I should.
The complication that killed that PR seems to have been complex matrices, which the original contributor probably didn't need.
Another complication is the distinction between np.ndarray vs. np.matrix conventions for scipy.sparse, especially if the axis keyword is included.  The current behavior includes
>>> scipy.sparse.identity(4).sum(axis=1)
matrix([[ 1.],
        [ 1.],
        [ 1.],
        [ 1.]])

but I'd guess that no one would want to continue this convention for hypothetical new functions like norm(scipy.sparse.identity(4), axis=1).  On the other hand maybe they do, I don't know.

Well, one thing to do is to to make a new branch, then do a pull from the existing branch.  You'll likely have to fixup the merge issues to get this to complete.  So
[mooreew@xavier scipy2]$ git pull https://github.com/perryism/scipy.git master
remote: Counting objects: 49, done.
remote: Compressing objects: 100% (21/21), done.
remote: Total 49 (delta 28), reused 40 (delta 28)
Unpacking objects: 100% (49/49), done.
From https://github.com/perryism/scipy
 * branch            master     -> FETCH_HEAD
Auto-merging scipy/sparse/__init__.py
Auto-merging scipy/sparse/base.py
Auto-merging scipy/sparse/csc.py
Auto-merging scipy/sparse/csr.py
Auto-merging scipy/sparse/data.py
CONFLICT (content): Merge conflict in scipy/sparse/data.py
Auto-merging scipy/sparse/linalg/__init__.py
Auto-merging scipy/sparse/tests/test_base.py
CONFLICT (content): Merge conflict in scipy/sparse/tests/test_base.py
Automatic merge failed; fix conflicts and then commit the result.

Another option is to checkout the branch in question, and then do a git checkout -b new_branch_name, followed by a rebase.  During the rebase you'll have to correct the same failures that you'd hit using the pull based approach.
I don't know that it matters which approach you take, but it's probably worth trying to keep the authorship information intact if you can.

scipy.sparse.linalg.norm supports more than L1 now.
See https://github.com/scipy/scipy/pull/4671 and https://github.com/scipy/scipy/pull/4505


Document proper method of passing location attributes for contacts

https://trello.com/c/65GjnSbx/2696-1-contacts-api-location-fix

no longer relevant


Create text file to document contribution guidelines

As we keep deciding on how tests should be constructed, naming schemes, formatting tools, docstrings, etc. we should have a markdown text file (a "CONTRIBUTING.md") to define our guidelines for writing code, submitting PRs, etc. that we can refer newcomers to and use to remind ourselves.
This way we also have a list of conventions to double check for in PR reviews to maintain consistency and confidence a PR has checked all the boxes.

I can share things that I have seen are effective at "herding cats" when working with teams having between two and two dozen engineers of diverse skill levels.

tests: $ make test is Green, and we have decent coverage. When adding a new feature function, expect that test code will exercise at least one line of that function. Or queue up a subsequent PR to add a test.
naming: PEP 8. It's easy to do, and it's universal within the python community. Linters and reviewers can flag issues.
formatting: black, then verify a clean $ ruff check. One can get ruff to write fixes, but I find that makes it harder to communicate an idea to newbies than a simple "black + ruff", "write + read", would be. Even simpler: $ make lint, and have that group imports with isort. I tend to assume that modern python code shall have type annotations -- no reason to omit them.
docstrings: This is the only topic that is "hard".

We conduct a code review during the PR process to assess two things:

Is it correct?
Is it maintainable?

The easy-to-run $ make lint test gives an objective answer the first. I offer this example.
The author likely believes that anyone in the team could fix a bug or add a feature to the code they just wrote. But only another teammate could give an answer of, "yes! I think I grok this new code and could maintain it." That's why we do reviews, to helpfully reveal blind spots in the author's thinking. What is obvious to the author won't be universally obvious, so we give other folks an opportunity to chime in, before they're stuck with supporting that code.
We desire that functions should compose, so each author takes care to spell out a new function's contract. Sometimes the pre- and post- conditions are clear from the signature. If not, we need at least a one-sentence docstring. A reviewer should be able to articulate what the contract is. Imagine there is no unit test. By examining the function's signature and contract (but not its source code), a reviewer should be able to write meaningful unit tests. If not, it is appropriate to push back, to suggest improvements to the PR prior to merging down to main.

Those all sound solid to me, I imagine this document would be 70-80% standard python practices with just a little bit of our own preferences for communication and workflow.

@skyfenton would you like to take a crack at it? There's probably templates you can use to get started.

Sure, I'll draft something up. I'll def want to review it next week with everyone to make sure there aren't any important gaps.

Awesome, sg

Let's document:

Adding descriptive commit messages for individual commits
Merging main instead of rebasing
Not force pushing active PRs
Linking issues from PRs

And much much more!


Updated migrations.rst to correct usage of CURRENT_TIMESTAMP.

The documentation for "Creating a Table" was using CURRENT_TIMESTAMP on a datetime field instead of a timestamp field.

Thanks for your contribution! In the future please follow these rules when making PRs for this project. Setting up a tool like static-review can help you verify your commits.


gleam: fix darwin build

Description of changes
This should fix the darwin build, I'm waiting for ofborg to confirm
@NixOS/beam
@tcoopman this should fix the build, let me know if you have time to test
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 266669 run on aarch64-darwin 1

1 package built:

gleam

Thank you!


lightweight dependency

Is it possible to build only the necessary modules for online evaluation of the model?  If so, is it possible to do it for scala 2.12?

@NetanelRabinowitz Hey, do you mean all of the models in mleap-core? We can get them building, but it will take a little bit of work.
We currently only build for 2.10 and 2.11. We need to get sbt-doge working in order to build modules across more versions of Scala.
The reason we need sbt-doge is because mleap-spark requires scala versions 2.10 and 2.11 in order to support Spark 2.0 and up. Building cross-versions for specific submodules is not supported out of the box by SBT. sbt-doge provides support for change cross-versions between different submodules, but breaks our build for reasons we can go into more if you are interested.
We would very much like to support this, and we need to moving forward!

@hollinwilkins I meant for mleap-runtime as a standalone jar. anyway for now 2.12 is awesome anyway :) it seems like mleap is the way to go for us, but in order to get it into production we need 2.12. please do share the details, maybe I can get my hands on it and help.
Thanks!

@NetanelRabinowitz sbt-doge I am pretty sure is the way to go. We have got it working a couple of times now. The only issue is that it breaks our build because of some issue with sbt-pgp, which we rely on for signing our artifacts before we deliver them to maven central.

@ancasarb May have some more details on exactly what the issue is too

@hollinwilkins  I will try to get it working this weekend and let you know what are my findings.

@ancasarb any updates? how did you overcome the fact that the runtime depends on spark-mllib-local but it available only for scala 2.11?

@NetanelRabinowitz this is how we were trying to use sbt-doge plugin to build mleap-scoring only for scala 2.11 and not scala 2.10.
https://github.com/combust/mleap/compare/master...ancasarb:mleap_serving_project?expand=1
This unfortunately breaks the publishing of artifacts, as Hollin was saying, which is what I am looking at the moment.

@NetanelRabinowitz We will have to get rid of spark-mllib-local as a dependency. This should be pretty straightforward to do, as most of the functionality is already in Breeze. It will be some work though because of the number of models that depend on it. Would you be interested in having a look at this?

I will. Thanks!

@NetanelRabinowitz Great, let me know how it's going or if you need anything. This would be a very welcome refactoring of code.

Closing this issue, as we're adding support for scala 2.12 here https://github.com/combust/mleap/pull/496 and tracking it here https://github.com/combust/mleap/issues/445. Please re-open if you think adding support 2.12 is not enough for what you had in mind, thanks!


Couple quick explanations.

"There's also commands to enter and eject a sequin mode, which I have no idea what does. It currently has no effect on the preview document."

Sequins are little round shiny things that sometimes are applied to fabric. This is often sewn on by an embroidery machine. The sequin_mode command brings the hopper out and each time a JUMP is issued it ejects a sequin. So JUMP will at that point block the needlebar and eject a sequin on the specialty machines that have that attachment. For the most part they are ignored since it's not only an embroidery machine but a specialty embroidery machine that uses them. I have written some code that visualizes them at points. They are usually circles with like 3mm or 5mm diameters. You are perfectly fine ignoring them. I included them in the documentation for completeness, but the files with sequins are actually quite rare.
If you somehow wanted to visualize them, you actually could in a SVG, since they are generally circles with circles removed from them and throwing that in a <def> and calling it up in various places would be possible but even while I included every format known reading and writing, I never ever bothered to do that.
The files have no stitch information in them. While there are some additional formats like .edr that contain dst colors, these are rare. There's also sometimes extended dst headers which contain the thread information but these are even rarer than .edr. Most often a threadchart is printed up which lists the threads, colors, and order they are used. The machine itself reads DST and it comes from punchcard days and had no use for any color information.
--
Code all looks fine. Feel free to take liberally from https://github.com/EmbroidePy/pyembroidery if you need anything.

Hi
Thanks for that explanation! I looked it up some time later and found a description of what the sequin actually was, and concluded similarly to you that it doesn't really seem that important to handle.
I had some trouble getting the SVG to render correctly early on, and found some Python code I looked at, which probably was pyembroidery, so thanks for that as well :)


GDEV-190 Created S3 Logging module based on aws/s3 module for storing…

… logs, updated labeler, updated README.md

[ ]  Set variables for configurations, but default to best security practices

[ ] Review 3rd party modules for additional configurations


Which other dependencies for Python+Linux?

Am following the instructions in the official docs, and had all the mentioned deps in place to install fbprophet in my virtualenv (see screen below):

But apparently, there seem to be some other (OS-specific?) dependencies one might need to have in place, so as to finally successfully install the package. It's rather annoying, because the package deps-check indicated all other deps are satisfied, but during the build, possibly around pystan phase, the build fails, and the error seems to indicate there's some other package - possibly a library package, that's required for the build to work.
So, for those who have gotten this to work on a vanilla Debian, which other packages did you have to install?
Note: I've already tried to install python-dev, build-essentials, libxml2-dev and libxslt1-dev. But none of these seem to solve this. I hate having to just follow blind-install workarounds as some popular SO answers for such scenarios recommend. So, what do we do?

I'm on vanilla Debian (testing) and I don't think I have any special packages installed. Can you verify that pystan is working?
>>> import pystan
>>> model_code = 'parameters {real y;} model {y ~ normal(0,1);}'
>>> model = pystan.StanModel(model_code=model_code)
>>> y = model.sampling(n_jobs=1).extract()['y']
>>> y.mean()  # with luck the result will be near 0

I'm wondering if it could be something like this: https://github.com/stan-dev/pystan/issues/207

First, concerning the pystan-issue you linked to; the eventual solution to that thread involved ensuring that Cython was >=0.22 (mine is Cython==0.25.2), and that both Cython and Pystan were installed via pip. I've installed both via pip, and have pystan==<IP_ADDRESS>. Yet, even with this, the problem persists.
But, when I attempt to run your sample code, it fails at the 3 step:

Note: the error is the same as that I was getting when running PIP above!
When I checked the logs during the running of your provided code-snippet, I noticed that it  got stuck at this step for a while...

INFO:pystan:COMPILING THE C++ CODE FOR MODEL anon_model_5944b02c79788fa0db5b3a93728ca2bf NOW.

And so made me think there might be issues with memory or something... So, I went to look at my memory usage (while that line continued running), and on my VPS, this processed seemed to be the one consuming the most memory:

USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
nemesis+ 41377 31.1 72.4 1355292 1243220 pts/2 D+   16:24   0:46 /usr/lib/gcc/x86_64-linux-gnu/5/cc1plus -quiet -I /tmp/tmpeqBpLN -I /home/nemesisfixx/labs/prophet/env/local/lib/python2.7/site-packages/pystan -I /home/nemesisfixx/labs/prophet/env/local/lib/python2.7/site-packages/pystan/stan/src -I /home/nemesisfixx/labs/prophet/env/local/lib/python2.7/site-packages/pystan/stan/lib/stan_math_2.14.0 -I /home/nemesisfixx/labs/prophet/env/local/lib/python2.7/site-packages/pystan/stan/lib/stan_math_2.14.0/lib/eigen_3.2.9 -I /home/nemesisfixx/labs/prophet/env/local/lib/python2.7/site-packages/pystan/stan/lib/stan_math_2.14.0/lib/boost_1.62.0 -I /home/nemesisfixx/labs/prophet/env/local/lib/python2.7/site-packages/pystan/stan/lib/stan_math_2.14.0/lib/cvodes_2.9.0/include -I /home/nemesisfixx/labs/prophet/env/local/lib/python2.7/site-packages/numpy/core/include -I /usr/include/python2.7 -imultiarch x86_64-linux-gnu -D_GNU_SOURCE -D_REENTRANT -D NDEBUG -D _FORTIFY_SOURCE=2 -D BOOST_RESULT_OF_USE_TR1 -D BOOST_NO_DECLTYPE -D BOOST_DISABLE_ASSERTS /tmp/tmpeqBpLN/stanfit4anon_model_5944b02c79788fa0db5b3a93728ca2bf_7653448178952472436.cpp -quiet -dumpbase stanfit4anon_model_5944b02c79788fa0db5b3a93728ca2bf_7653448178952472436.cpp -mtune=generic -march=x86-64 -auxbase-strip /tmp/tmpeqBpLN/tmp/tmpeqBpLN/stanfit4anon_model_5944b02c79788fa0db5b3a93728ca2bf_7653448178952472436.o -g -g -O2 -O2 -Wall -Wstrict-prototypes -Wdate-time -Wformat=1 -Werror=format-security -Wno-unused-function -Wno-uninitialized -fwrapv -fno-strict-aliasing -fstack-protector-strong -fPIC -ftemplate-depth=256 -fstack-protector-strong -Wformat-security -o /tmp/ccIpjIZM.s

Am just hypothesizing, but it could be that a lack of sufficient memory could cause the building of the model to fail? Am not at all experienced with Pystan or Stan itself, and so, I might be going over the edge here, but someone more experienced could help look more into this.
Note: am running this on a "micro" server via Microsoft's Azure cloud, with just 1GB of RAM. So, perhaps that is a show-stopper?

Memory!
I increated the memory of the vm to 3.5G, and when I run the code sample, am now able to finish the entire demo... [@bletham mean is 0.011148514562947815 ;-) ]
Also, the installation now works effortlessly. So, clearly, having enough RAM seems to be a hidden /implicit requirement here. How much is enough? The experts can tell us, but in my case, the above solved this.
What's not clear now, is how much more RAM I might need when using the lib itself -- but, that's kind obvious - bigger workloads, more memory sir!


Custom API endpoint setting

Currently the app directs every request to the static setting api.openrouteservice.org/.. - for a developer with a local ORS setup it would be handy, if the api endpoints could be changed in settings on the fly, so giving the user an option to send it to localhost:8080/ors.. etc.

Closed by d939576d84f0a46617295f7b6f94aad13b830596


how to set margins and paddings best with the mixins available

I got an email with some questions regarding padding and margin whilst using Sassifaction
    --------------------------------------------------------------------------------------------------

Got a quick (newbie) question if I may? Thanks in advance for your time. :)
It’s to do with the best method of setting padding and margin on elements. I can see there are a few ways to do it in Sassifcation.

Typography mixin - obviously applied solely to type and only affects margin and line-height.

Maths mixin - the remit function allows you to create, say, a margin-bottom in rems with px fallback.

RWD padding and margin mixin - various mixing for creating pixel-less padding and margins.

Can I ask how you typically apply margins and padding to non-type elements? Do you generally use the RWD padding and margin mixin? If so can you help me figure out how to use it? It’s the $content variable I can’t figure out how to use?
Or do you just use the remit mixin, if it’s for something like vertical margins which require rems with px fallback? I can see how both would be appropriate, but the RWD more appropriate for horizontal padding?

I'm just testing this


support prettier v3

It should be possible to upgrade to Prettier v3 or support both: prettier: "^2.0.0 | ^3.0.0"
May be the only thing to care about is the change of the apis to async
// v2
export function format(source: string, options?: Options): string;

// v3
export function format(source: string, options?: Options): Promise<string>;

It seems that some used packages/services expect format to be sync.

Prettier is integrated via yaml-language-server. There’s already a PR to update Prettier (https://github.com/redhat-developer/yaml-language-server/pull/909). If that’s merged and released, monaco-yaml can update too.

I’m closing this, as it’s currently not actionable. It really depends on the upstream issue being resolved and released.


Updated description & example usage

Made changes per issue #25844:

Updated description to mention tf.Keras model.
Added the missing line in the example usage for SavedModel and tf.keras model.

This PR has been approved but 2 checks failed. What's the next step on this?

@margaretmz could you please check build errors

@dynamicwebpaige please advise the next steps on this PR, which has been approved a long time ago but 2 checks were not successful. Thanks!


library selected video only display in sqaure

_I am uses this library to record video and showing it in next screen then apply filter using SCSwipeableFilterView,
I am facing issue while selecting video from library, selected video only display in square mode, I am using same class here SCSwipeableFilterView.
//code uses to
```
filterSwitcherView = [[SCSwipeableFilterView alloc] init];
filterSwitcherView.frame = CGRectMake(0, 64, SCREEN_WIDTH, SCREEN_WIDTH);
filterSwitcherView.contentMode = UIViewContentModeScaleToFill;
SCFilter *emptyFilter = [SCFilter emptyFilter];
emptyFilter.name = @"#nofilter";
filterGroups = [[NSMutableArray alloc] initWithObjects: [UIImage new],
filterSwitcherView.filters = @[
emptyFilter,
[SCFilter filterWithCIFilterName:@"CIPhotoEffectChrome"],
[SCFilter filterWithCIFilterName:@"CIPhotoEffectFade"],
[SCFilter filterWithCIFilterName:@"CIPhotoEffectInstant"],
[SCFilter filterWithCIFilterName:@"CIPhotoEffectNoir"],
[SCFilter filterWithCIFilterName:@"CIPhotoEffectMono"],
[SCFilter filterWithCIFilterName:@"CIVignette"],
[SCFilter filterWithCIFilterName:@"CIPhotoEffectTonal"],
[SCFilter filterWithCIFilterName:@"CISepiaTone"],
[SCFilter filterWithCIFilterName:@"CIPhotoEffectProcess"],
],nil];//[SCFilter filterWithCIFilterName:@"CIColorCube"]
[self.view addSubview:filterSwitcherView];
player = [SCPlayer player];
player.loopEnabled = YES;
player.delegate = self;
[player setVolume:10];
player.autoRotate=NO;
player.SCImageView = filterSwitcherView;

//**************************************************************//
I also tried different approach by using SCVideoPlayerView than video display fine as there respective mode (eg. landscape, portrait)
but hurdle is,
when I uses SCFilterImageView class apply filter its than  black out comes,

//code uses

playerView = [[SCVideoPlayerView alloc] initWithPlayer:player];
playerView.frame = CGRectMake(0, 0, SCREEN_WIDTH, SCREEN_WIDTH);
playerView.playerLayer.videoGravity = AVLayerVideoGravityResizeAspect;
[self.view.superview insertSubview:playerView aboveSubview:self.view];
[self.view addSubview:playerView];
// Render the video directly through a filter
SCFilterImageView *filterView = [[SCFilterImageView alloc] initWithFrame:playerView.bounds];
filterView.filter = [SCFilter filterWithCIFilterName:@"CIPhotoEffectProcess"];
[playerView addSubview:filterView];

player.SCImageView = filterView;

``

When you set the playerView and filterSwitchView frame you set the Width and Height to be both SCREEN_WIDTH (Which will mean you end up with a square frame).
Change this:
filterSwitcherView.frame = CGRectMake(0, 64, SCREEN_WIDTH, SCREEN_WIDTH);
playerView.frame = CGRectMake(0, 0, SCREEN_WIDTH, SCREEN_WIDTH);

To this:
filterSwitcherView.frame = CGRectMake(0, 64, SCREEN_WIDTH, SCREEN_HEIGHT);
playerView.frame = CGRectMake(0, 0, SCREEN_WIDTH, SCREEN_HEIGHT);

But in playerView, video is displayed proper by using,
playerView.playerLayer.videoGravity = AVLayerVideoGravityResizeAspect;
as landscape Video in landscape mode, vise versa.
but I am not fined anything like this when using SCSwipeableFilterView which always results video in square mode.


Remove subnet data source

Remove the subnet data source as this causes a cycle due to the associated network security group id in the data source object.

Lgtm!!!

Just updating examples


Generate trust roots SecCertificate for Transport Services

This PR is a result of another #321.
In that PR I provided an alternative structure to TLSConfiguration for when connecting with Transport Services.
In this one I construct the NWProtocolTLS.Options from TLSConfiguration. It does mean a little more work for whenever we make a connection, but having spoken to @weissi he doesn't seem to think that is an issue.
Also there is no method to create a SecIdentity at the moment. We need to generate a pkcs#12 from the certificate chain and private key, which can then be used to create the SecIdentity.
This should resolve #292

The actual change seems to be lost in reformatting (which also reformats it in the wrong way (eg. moves qualifiers before extension instead of the individual members)). Could we undo everything that's not the actual change you'd like to make?

Sorry I'm running a newer version of swift format and submitted all the other files by mistake.
The public infront of extension is caused by a new rule extensionAccessControl which is defaulted to on by default. I have it disabled in soto because its a pain. You could use it to force the positioning of the public qualifier through. Do you guys intend to upgrade from v0.44.6 at some point?

@swift-server-bot add to allowlist

@Lukasa do we need some more tests for converting between TLSConfiguration and NWProtocolTLS.Options?

@Lukasa @weissi Anything left to do here?

After chatting to @adam-fowler: we're not calling SecEvaluateTrust on the right queue at the moment.

And then after reviewing code I realised we were.
Although we did come across another issue where a file load could happen on the EventLoop. To avoid this I have moved the whole NWProtocolTLS.Options  generation to the DispatchQueue.


openssl: 1.1.1h -> 1.1.1i

Motivation for this change
New upstream release.
https://www.openssl.org/news/changelog.html#openssl-111
Fixing EDIPARTYNAME NULL pointer de-reference (CVE-2020-1971)
https://www.openssl.org/news/secadv/20201208.txt
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Closes #106218

Thanks! @mweinelt would you mind porting this to staging-20.09 as well? :)


Group Policy Software Installation

Why on earth is Group Policy mentioned in this context with mentioning Group Policy Software Installation?  This article seems as though it was written by someone who kept hearing Group Policy mentioned in connection with application packaging but didn't realise it was Group Policy Software Installation that people were talking about.
If MSIX is going to be useful it's going to have to be able to be deployed using Group Policy Software Installation and MSI is today.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b4cb9373-33f7-a4c9-18ba-ac6323d0bba8
Version Independent ID: cc621151-fe24-7cad-8314-8a341a216458
Content: How Group Policy work with MSIX packaged apps - MSIX
Content Source: msix-src/group-policy-msix.md
Product: msix
GitHub Login: @dianmsft
Microsoft Alias: diahar

Will provide additional sentence to clarify article.


WP-004: Documentation and test requests

👨🏽💻 Description
Describe what are your changes and why they are needed.
✅ Testing
How did you test your changes?

[ ] ♻ Adding/updating unit test for impacted functionality
[ ] 📕 Adding/updating stories in Storybook for impacted components

🖼 Evidence
Please include some evidence of how the changes work.

Codecov Report
Patch and project coverage have no change.

Comparison is base (9b178e3) 87.83% compared to head (571fc05) 87.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   87.83%   87.83%
=======================================
  Files          10       10
  Lines         263      263
=======================================
  Hits          231      231
  Misses         32       32

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Cool new functions for camera: fade,flash,shake

usage :
a color for your fade,a position for fade,how fast the fade should apply
fade(Color(255,255,255),Vector2(-200,-150),.3)
a color for your flash,a position for flash,how fast the flash should apply
flash(Color(255,255,255),Vector2(-200,-150),.3)

Yes they're cool, but I personally think this should be done by script, at the same time keeping API more generic.

I'm all for this. A few generic effects built-in will only make things easier, and they're very unobtrusive. People can still script whatever they want, if the built-ins aren't good enough.

It looks like @Murii deleted his Godot fork, so there is no chance to see this PR rebased against the current master branch.
If there is still interest in adding those functions, feel free to open a new PR; if you do it based on the above commit, please try to improve the coding style to match the rest of the codebase, currently there is no real visible convention, many parameters are misspelled, etc..

And actually the above change was probably broken as the header is not updated (it is then partly done in #1103, but that wouldn't compile either).

@akien-mga  Back then I wasn't such a good C/C++ coder so that's why I did not respect Godot's style. Anyway I don't have any more the repository so I can't help.


Automation: Update docker instructions

Use sudo consistently for image building and publishing
Do not use cache when building the image
Use a variable for the version for easier copy and pasting

Signed-off-by: Till Maas<EMAIL_ADDRESS>

Coverage remained the same at 66.588% when pulling f410a1db01789b519bb059e6a7390116170af0af on tyll:docker_instructions into c0f56a424240d4729e0bde387c04b87fe7c72cc2 on nmstate:master.


1.1 The app opens in both IOS and Android.

IOS part of the project have been terminated for now. We will only focus on Android.


[patch] double header issue

Just directly patching the double headers that was reintroduced into the codebase. ref  #106
Side-note, it seems to be part of a bigger issue: #116

@terryweiss is this project still active?
the last commit was on May 15th
will you continue reviewing PRs and is there any point in creating them?

@thealjey Note, there is a call for maintainers since December 2014 - #75
May be you can help with maintaining project - possibly a joint responsibility with other contributors?!

@mwittig sure, but, how would I do that?
I'd love to, as this is one of the most promising themes out there
btw, I would not accept this particular path, because it does not resolve the issue (it removes the wrong header :smiley:)
but there's certainly room for discussion

@thealjey we've moved the project to a shared organisation. I want to sort things out, are you interested in helping?
I'm closing this issue in favour of sorting things out in #125

@lukeapage absolutely, it's one of the 3 best templates for JSDoc today (the other 2 being minami and jsdoc-react).
I'd really love to have a template that combines all of the best parts of the 3 and more.
And, I'm positive that with a little bit of effort it is possible to make one.


unstableGitUpdater: Use stableVersion, update to new format, offer hardcoded 0 version

Description of changes
With #280312, we now have more complete guidelines on what unstable versions should look like in our post-#234201 world. As a first step towards that, update unstableGitUpdater update script - and all users of it, to avoid update errors - to actually use it.

Remove stableVersion option, the stable version schema will always be used now.
The only usage of this option inside of Nixpkgs that I could find (gnomeExtensions.dash-to-dock, back when it was manually packaged) was removed ~ 2 years ago. GitHub-wide code search was only able to find stale Nixpkgs clones with that one usage, so it seems fine to just drop it?
Add a hardcodeZeroVersion option, for projects without any releases & incompatible tagging systems. This skips the tag search in favour of a hardcoded version 0.

Not 100% sure yet if the way this is implemented in the script is the best way of doing it, but it's a start. Open for complaints / alternative solutions :slightly_smiling_face:.
Closes #291729
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

closes https://github.com/NixOS/nixpkgs/pull/294213

Add a :+1: reaction to pull requests you find important.

I have pushed a treewide change that updates all users of unstableGitUpdater:

Added hardcodeZeroVersion or tagPrefix as needed, so the script can "find" a tag
Updated the versions of affected packages to the new schema, so running updaters in bulk (for example nix-shell maintainers/scripts/update.nix --argstr maintainer OPNA2608 doesn't error out on "the version is different, but the ref / hash is the same" situations

Running maintainers/scripts/rebuild-amount.sh says:
Estimating rebuild amount by counting changed Hydra jobs (parallel=unset).
    718 x86_64-darwin
   1029 x86_64-linux

…which should be fine for master, although more than I would've liked :sweat:.
I'll leave notes on individual packages where I think it's worth to point unusual / problematic things out.

@OPNA2608 greetings !
first, thank you for working on this. you have clearly put fair bit of work into this! Good stuff
initial impression is, that this approach is at least not very intrusive ( eg easy to change )
my first question would be, can we avoid hardcodeZeroVersion = true for repositories that clearly don't have any tags ?

Because we default to using a shallow clone (shallowClone ? true), most of the time we start with an incomplete/missing list of all tags. The update script handles this by incrementally fetching more commits & associated tags:
depth=100
while (( $depth < 10000 )); do
  # <check & break if tag found>

  ${git}/bin/git fetch --depth="$depth" --tags
  depth=$(( $depth * 2 ))
done

The only 100% accurate ways of determining if the repo has any tags that I can see is if we either:

don't use a shallow clone so we have all tags, at the cost of always requiring more time & space to fetch, or
fetch everything once the 10000 incremental fetching range has been reached, going "we tried the quick way but it failed, now let's go the thorough route"

(Otherwise I'm not sure if the updater wouldn't just break / produce an incorrect bump if a repo had a 1.2.3 tag 10001 commits ago. I would assume it would happily submit foobar: 1.2.3-unstable-2024-02-05 -> 0-unstable-2024-02-06.)
I can add that, so we can avoid hardcodeZeroVersion = true for tag-less repos.

this is scoped to unstableGitUpdater
there are significantly more derivations(projects) with no tags, should we assume hardcodeZeroVersion as default.

as for repos with some tag

maintainers of derivations opt in to fetch tags
Or we pass version to updater, and updater will prepend that version
if a derivation is using unstableGitupdater, maybe version is no longer relevant, and 0 is ok to use

@OPNA2608 what do you think ?

* there are significantly more derivations(projects) with no tags, should we assume `hardcodeZeroVersion` as default.

as for repos with some tag
* maintainers of derivations opt in to fetch tags

* Or we pass version to updater, and updater will prepend that version

* if a derivation is using `unstableGitupdater`, maybe version is no longer relevant, and `0` is ok to use

I think most of these aren't really bringing us closer to the goal of the guideline.

The point is to have a real base version. Defaulting to lying about it by hardcoding 0 and requiring maintainers to opt into "real" versions seems to me like a bad design.
Just because there are currently no tags doesn't mean that there will never be tags. I think having the version in a bump jump from zero to non-zero would be a good indicator that the derivation could potentially stop using the unstable schema.
Allowing a hardcoded base version to be passed feels like something that will be set once and never updated. Hardcoding 0 despite tags, I hope, would only be used for wholly incompatible tagging systems.

When there are no tags at all, then i think adding the fallback is the best option - that saves us a hardcodeZeroVersion for the most common situation.

@OPNA2608 what do you think about https://github.com/NixOS/nixpkgs/issues/291729 ?

@eclairevoyant what are your thoughts on this PR

I haven't had a chance to look in depth; it looks involved and I like to avoid reviewing when I'm low on sleep :)

I have added 2 more options, which should help us with covering possible situations:

tagFormat: Filter tags to match a certain grep -Eo format. This should help with upstreams that provide pointless latest tags.

I don't have an immediate use for this inside of Nixpkgs, but I have seen upstreams that do this.

tagConverter: Points to a command that should convert a prefix-stripped tag passed via stdin into our version format on stdout. This should provide better flexibility in handling tagging formats like release_x_y_z.

We have a single user of this, chirp.
cegui would also use this, if we weren't using a branch that lacks any tags. It's kind of pointlessly set there, as a "this is what we would do" kinda thing.

With that, the only packages that need to rely on hardcodeZeroVersion and their reasons are:

mpvScripts.mpv-webm: Upstream only provides a constantly-retagged latest tag
open-watcom-v2-unwrapped: Upstream provides monthly YYYY-MM-DD-Build, and constantly-retagged Current-build, Last-CI-build & Coverity-scan tags

Potentially a use case for tagFormat if gitUpdater supported it

nelua: Upstream provides a very stale latest tag, and a single random YYYYMMDD tag from a month ago. Not sure what upstream's strategy is, and there was no compatible tag for the longest time, so keeping it at 0 to be safe.
c2ffi: Upstream provided tags matching their LLVM base version, but stopped doing so 2 years ago. The full name for the current version would be c2ffi-llvm-16.0.0-<IP_ADDRESS>-unstable-2023-11-18… which is pure nonsense.
lua{51,52,53,54,jit}Packages.luarocks-nix: The base luarocks provides consistent tags. nix-community/luarocks-nix only merges their upstream periodically and doesn't inherit the tags anymore, so the tags on that repo are lying. So I felt it made the most sense to not engage with the versions & tags and hardcode 0. For reference:

Latest inherited tag from upstream luarocks: v3.7.0, 2021-04-13
Latest custom tag: nix_v3.5.0-1, 2021-07-28
Latest luarocks version actually merged into the tree: v3.9.2, 2022-12-08

nix-search-cli: Almost every commit is tagged as release-<unix timestamp>-<commit>, software doesn't seem to keep track of its version in any way. Hardcoded 0 matches the upstream intention the closest IMO.

once this gets merged the new options will need to be documented in the nixpkgs manual, although for the sake of getting this done, my vote is that can be done in a seperate PR

once this gets merged the new options will need to be documented in the nixpkgs manual

I don't think unstableGitUpdater is documented at all in the (Nixpkgs) manual? The most I can find about our updaters in general is:

A common pattern is to use the nix-update-script attribute provided in Nixpkgs, which runs nix-update:
passthru.updateScript = nix-update-script { };

well, then someone (maybe i'll give it a shot) should probably write a section about updater scripts in nixpkgs.
however, like i said, this should be doable in a separate PR after this one, and i think the fact it already isn't documented only strengthens that.

perhaps if you factored the changes to unstableGitUpdater out into a seperate PR (without the changes to version numbers) this would be easier to merge?  that should also bring the number of rebuilds down from thousands to zero.

As much as I dislike temporarily breaking updaters by not fixing all uses of unstableGitUpdater together with this, you're prolly right… Rebuild counts aside, some of the packages get auto-updated very frequently which causes merge conflicts, and I kinda don't have as much spare time as I'd like to keep this updated every day.
Leaving only the changes to unstableGitUpdater here, will submit the treewide changes to everything afterwards.

Oh! Did not realise this was as yet unmerged. Apologies.
Thanks for the work on this!


changed languages dropdown option logic into reusable

fixes #9
I have made dropdown logic reusable
IMO:- I think we should use MUI library for components which will give us some styling as well, let me know what do you think, if you want I can integrate MUI in this project.
@DhanushNehru

@Chaitanya1672 yes you can integrate MUI libraries on the project, even you can update the react existing libraries if necessary without breaking any feature


Compute mu_k terms via iterative exponentiation, instead of keyed hashing

Suggestion from Sarang in #monero-research-lab:
sarang: You can actually do a single hash execution for the `mu` terms instead of one each, and substitute a field multiplication instead
sarang: So instead of `mu_k = hash(stuff,k)` for each `k`
sarang: You set `mu = hash(stuff)` and then define `mu_k = mu^k`
sarang: and you can define the former iteratively
sarang: So if your scalar ops are sufficiently faster than your hash function, you can shave some time off that
sarang: I demo this in the C++ code that I linked
sarang: * sarang updates the preprint too
sarang: Note that there's nothing wrong with the original method, except the speed difference
sarang: s/former/latter

This should be trivial to implement and offer some performance benefit over the current Blake2b(mu, k)

In trying to implement this, I realize that computing mu_k as the kth exponent of mu does not scale as well as originally thought. As such, I have decided not to make this change.
The problem is that the prover must randomly access different mu_k[l] for each l corresponding to the indices of his input witnesses. This requires l multiplications for each input, which becomes very expensive for large transactions. Conversely, the existing keyed hash allows random access of any mu_k with a single hash operation.
I am still interested in reducing the cost of performing a hash for each mu_k. Efficient iterative computation is preferred, but efficient random access is also important.

To achieve efficient random access of mu^k, it may be worth writing a macro or utility to perform fast exponentiation. For example, fast exponentiation via sums of squares requires O(log(N)) multiplications, instead of O(N). This may be sufficient.

https://github.com/cargodog/arcturus/pull/26 addresses the bulk of this issue. I have left a few todo's to address the comments left above.


enhance physx for further development

There are multipy enhance for physx binding:

use userdata in shape instead of PXFilterData to store shape id, otherwise the PXFilterData will be used in CollisionGroup enable/disable.
add collison class to store collidershape which will add more information about collision in the future
add CloseExtension when release whole physx package

Codecov Report
Patch coverage: 14.28% and project coverage change: -0.25 :warning:

Comparison is base (0700b98) 49.28% compared to head (97f128e) 49.04%.

:exclamation: Current head 97f128e differs from pull request most recent head 6b99a51. Consider uploading reports for the commit 6b99a51 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff             @@
##           dev/1.0    #1421      +/-   ##
===========================================
- Coverage    49.28%   49.04%   -0.25%
===========================================
  Files          361      362       +1
  Lines        18358    18377      +19
  Branches      2636     2636
===========================================
- Hits          9048     9013      -35
- Misses        8380     8433      +53
- Partials       930      931       +1

Impacted Files
Coverage Δ

packages/core/src/physics/PhysicsManager.ts
26.66% <0.00%> (-2.97%)
:arrow_down:

packages/core/src/Script.ts
89.23% <100.00%> (ø)

packages/core/src/physics/Collision.ts
100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Podfile.lock and Pods/Manifest.lock comparison not working

I ran into a problem running pod check in our CircleCI build environment. I had updated a pod in my local build, and then the /Pods directory on the build server was out of date (had the wrong version of the pod in the Manifest.lock).
If I did a diff on the two files, I had a different version number on the pod and a different checksum. If I ran pod check (v1.0.0 and cocoapods v1.0.1) it said Pods are up to date. My current work around is to do the diff myself, and run pod install if the files differ - it looks to me like this should be handled in /lib/pod/command/check.rb but it doesn't seem to be working.
This issue might be related to #1 but it also relates to actual version mismatches, not just the checksum.

Hey sorry I'm just now seeing this. Could you reply with the diff output?

from memory it was the checksum and the pod version that were different - everything else was teh same. i don't know which build this was, it was a few weeks ago, and we have tons of failed builds.

I have a PR for this #9

Fixed in v1.0.2.


Add additional param support to WebSearch

[x] I have read and agree to the contributing guidelines for submitting new pull requests.

Describe your changes
Added

Optional params field to WebSearch's search schema that the LLM can be steered into using.

Changed

BREAKING: api_key and search_id are now required fields in GoogleWebSearchDriver.
GoogleWebSearchDriver and DuckDuckGoWebSearchDriver now use kwargs passed to the run method.

Issue ticket number and link
#823
Example
import os
from griptape.structures import Agent
from griptape.rules import Rule
from griptape.drivers import GoogleWebSearchDriver
from griptape.tools import WebSearch
from griptape.drivers import OpenAiChatPromptDriver

agent = Agent(
    prompt_driver=OpenAiChatPromptDriver(model="gpt-4o", use_native_tools=True),
    rules=[
        Rule(
            "When asked to search within a date range, use the `date_range` parameter of the Search Client. Example: 20210101:20220101"
        )
    ],
    tools=[
        WebSearch(
            web_search_driver=GoogleWebSearchDriver(
                api_key=os.environ["GOOGLE_API_KEY"],
                search_id=os.environ["GOOGLE_API_SEARCH_ID"],
            )
        )
    ],
)

agent.run("Search for articles about the history of the internet from 1990 to 2000")

[07/24/24 12:23:21] INFO     ToolkitTask c44ca1659a8743be8afe367b8a1e6240
                             Input: Search for articles about the history of the internet from 1990 to 2000
[07/24/24 12:23:23] INFO     Subtask 7c3f79c38dd94481b498c99a0300d622
                             Thought: I need to search for articles about the history of the internet within the date range of 1990 to 2000.
                             Actions: [
                               {
                                 "tag": "search_history_internet_1990_2000",
                                 "name": "WebSearch",
                                 "path": "search",
                                 "input": {
                                   "values": {
                                     "query": "history of the internet",
                                     "params": {
                                       "date_range": "19900101:20000101"
                                     }
                                   }
                                 }
                               }
                             ]

Note that in the example I had to disable use_native_tools here. With the default of use_native_tools=True, OpenAi refused to use the params portion of the schema. Anthropic also had no issue which makes me think there is a lack of chain-of-thoughting happening behind the scenes in OpenAi's function calling.
I tried a few solutions to no avail:

Simplify the Tool schema by removing values
Add an explanation field to the schema as proposed here. This kind of worked, but it still took a few tries each time.

This has me wondering whether use_native_tools=True is a good default for OpenAiChatPromptDriver.

@collindutter in your example, you show use_native_tools to True, but it needs to be false for this to work correctly, right?
Also, it's unfortunate that you still need to use a rule to get the driver to do the right thing - is this something that can be owned on the driver side instead of the agent side?
It makes it so the user needs to do some prompt engineering if they're switching between drivers to get it to work correctly.
cheers,
Jason

@shhlife take another look at the new approach.


Remember patch load order

CURRENT BEHAVIOR
Every time there is any change in what patches to use via the "Select patch" button, one must reorder the patches, even if most of the patches are the same.
PROBLEM STATEMENT
This is inconvenient. I would like to be able to slap one additional patch into my patch list without having to reorder the entire list.
TARGET BEHAVIOR
Remember the load order of all previously loaded patches, or even just the patches that were loaded most recently. A simple implementation that comes to mind is simply storing this data in a .txt or .csv file.
loadOrder.csv e.g.:
0,Patch_A.kh2pcpatch
1,Patch_B.kh2pcpatch
2,Patch_C.kh2pcpatch
...
A0,Patch_D.kh2pcpatch
A1,Patch_E.kh2pcpatch
A2,Patch_F.kh2pcpatch
...

Good idea. Although I might be lazy enough to allow .txt to be a selectable format and if the user selects a .txt file, parse its lines, with each line being the path to a .*pcpatch file (ignoring the ones that don't end in .*pcpatch) and use those as the input files.
Will think about it, thanks!


speed up development env with swc-loader and hmr

With this change, startup of dev server is faster and provides hot module reloading without full page refresh.

Replace ts-loader with swc-loader but only for dev mode.
Add webpack plugin ReactRefreshWebpackPlugin for fast hot module reloading.
Add webpack plugin ForkTsCheckerWebpackPlugin to fork type checking to a separate thread.
Add webpack plugin https://github.com/stephencookdev/speed-measure-webpack-plugin for measuring startup times.

To measure startup times use: MEASURE=true npm run start:dev:ext.
Start up times for frontend npm run start:dev:ext
swc-loader:
General output time took 33.89 secs
General output time took 31.31 secs
General output time took 31.66 secs

ts-loader:
General output time took 46.79 secs
General output time took 45.35 secs
General output time took 41.036 secs

Prior to any changes:
General output time took 1 min, 27.1 secs
General output time took 1 min, 25.41 secs
General output time took 1 min, 27.89 secs

Start up is faster
Updates after a code change is a lot faster.
I haven't seen any issues.
/lgtm
(now if only we could get it to stop faster on a cntrl-c)

Ah got it. No worries then, I don't see a problem with merging.


Errors when writing to the root directory.

Hi.  I found that writing to the root directory throws an error, at least on my Mac.  It might be safer and more obvious to write to the working directory.

I read that you have a bunch of changes coming.  Didn't want to add unnecessary noise to your project so I decided maybe it was best to close it after all.


Fix unicode truncate by number of words

Solve problems when unicode chars in content.

thanks for your commit and sorry for this late integration


Adding custom AnimationBuilder helper methods

I'm trying to add my own helper method for AnimationBuilder to support this use case: https://github.com/Multirious/bevy_tween/issues/13
But the problem is that all the struct fields are private:
https://github.com/Multirious/bevy_tween/blob/417c173df1a73f4d103665e90fcfd60b875f720d/src/combinator.rs#L259-L263
Would it be reasonable to make those fields public?

It's currently private to minimize future breaking changes as I assume they won't be stable. What field needed to be public? Could  also this be solved by wrapping this struct to a new struct with new extension trait?

For the specific method I'm trying to implement, I'd need mutable access to EntityCommands so that I can add additional components to the entity. The method would need to be able to add the SkipTweener component, a custom component to store the previous tween entity and also call the set_paused method.
I don't think a wrapper struct would let me access those fields though.

Oh you can access EntityCommands before calling .animation You can also use .paused method on AnimationBuilder. Would this work?

Yeah, but what I'm hoping is that I can do all that in a single method. Something like .animation().insert(/* ... */).after(/* entity */) would be super clean.

Hmm, having .after method after .insert probably wouldn't work since .insert* method will insert the TimeRunner automatically and TimeRunner won't be accessible after. I'm happy to allow access on EntityCommands in any case, seems like a good thing to have.

Oh, yeah you're right, the .after would have to be done before .insert right?

Alright, I've pushed 63437d6. I've added getters to the inner TimeRunner and EntityCommands.

Oops wait I think the method should return &Option<TimeRunner> not Option<&TimeRunner>

Thank you! I'll experiment with it a bit before closing the issue.

Ok, I think it's working pretty well. Thanks again!


Populate my shop from the CLI

Anyway to get this done? I am looking for a way to maybe process a store in a VPS and update it programmatically with new listings, update prices, and descriptions.

For the moment you may have to build your own using docopt and the REST/WS APIs.

Apart from that you can host the server remotely on a VPS (like I do) and connect to it remotely with the client. Let me know if you want help with that.


How to get the Matrix Name as a Variable

Is there a variable I can use to get the name of the matrix e.g. in the example below, it would be Linux, Mac or Windows.
stages:
- stage: Build
  jobs:
  - job: Build
    strategy:
      matrix:
        Linux:
          vmImageName: 'ubuntu-latest'
        Mac:
          vmImageName: 'macos-10.13'
        Windows:
          vmImageName: 'windows-latest'
    pool:
      vmImage: $(vmImageName)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dd7e0bd3-1f7d-d7b6-cc72-5ef63c31b46a
Version Independent ID: dae87abd-b73d-9120-bcdb-6097d4b40f2a
Content: Variables - Azure Pipelines
Content Source: docs/pipelines/process/variables.md
Product: devops
Technology: devops-cicd
GitHub Login: @andyjlewis
Microsoft Alias: alewis

@RehanSaeed Thanks for your question. It looks like you're working through an issue with your scenario or implementation, rather than an issue with the documentation. Here are a few options where you might consider asking your question:

Azure DevOps on Stack Overflow
Azure DevOps Support Bot


Add "onDownloadProgress" callback for chromium download

I thought it might be useful to give the user some information about the download progress of chromium.

Thanks for the proposal.
Can you do it using package:http?
I really want to limit the number of third party dependencies. package:http is already there and is maintained by the Dart team.

@xvrh sure, should work now

Thanks for the contribution!


Adding Flask-CORS

Just updating the existing PR to the latest version of master.

Coverage decreased (-0.1%) to 80.848% when pulling cb9ab44f92623281dc50a4d0a52aa94aa08319e9 on harmoney-dev:cors-enabled into 190bbe3823476bc235a93348dae50da4fd9c4222 on seatgeek:master.

Can you add docs for this to the readme? Also, what exactly does this enable (my memory of cors is hazy at best).

+1

@markcatley still needs docs.

Coverage decreased (-0.1%) to 80.848% when pulling 9a01a6cf0661d26fc2a015339160a8d3d44b4a12 on harmoney-dev:cors-enabled into ddbec4181ba0cad51a2a128a4ebbec8873cf5f4d on seatgeek:master.

Coverage decreased (-0.1%) to 80.848% when pulling e14ed394bc262e7539fe18be68c70f677e127ea9 on harmoney-dev:cors-enabled into ddbec4181ba0cad51a2a128a4ebbec8873cf5f4d on seatgeek:master.

@josegonzalez I have added a line in the readme.

@zackkitzmiller fixed.

Coverage decreased (-0.1%) to 80.848% when pulling dbf0c5b7208f2083743e08f31945f40ebea779f5 on harmoney-dev:cors-enabled into ddbec4181ba0cad51a2a128a4ebbec8873cf5f4d on seatgeek:master.

Released as 2.6.0, can you test @kuroisuna?

It is working perfectly, thanks a lot @markcatley, @josegonzalez


Add test for pagination links with base

Description

Closes #1886
Fixes an edge case how custom prev/next links in frontmatter are handled
In general a custom prev/next link was applied directly to an existing link object, which produced the correct behaviour. How in the edge case where a link object wasn’t already available (e.g. pagination is disabled, or the page is first/last, so has no prev/next link), we were using a makeLink() utility designed for sidebar items that did some additional processing. This rarely caused issues, but if a user had base set, this led to inconsistencies where the base would prepended to links only in these rare edge cases.
This PR fixes this by ensuring links created for pagination purposes are never processed and always reflect 1:1 with the authored link in frontmatter

size-limit report 📦

Path
Size

/index.html
5.96 KB (0%)

/_astro/*.js
21.87 KB (0%)

/_astro/*.css
13.77 KB (0%)


[R] don't remove CMakeLists in cleanup

currently installing the R-pacakge will leave the repo in dirty state, since
CmakeLists.txt is already checked in. This fixes the cleanup
script to not delete this file.

Merging.  @hcho3 @RAMitchell but we need to figure out what to do with shotgun test.  Maybe we should just limit it to single thread during testing?


Add new community call coords to README.md

Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Please use commit -a -s to sign the commit and push it again...

@lresende signed off


fix: replace deprecated elements with equivalent up-to-date items in at_commons_flutter

Closes https://github.com/atsign-foundation/at_widgets/issues/842
- What I did

Replaced deprecated elements inat_commons_flutter's example app with up-to-date design elements

- How I did it

BackgroundColor in MaterialApp() was previously deprecated and now removed. The latest version's equivalent of BackgroundColor is called 'surface' which is now used in the examples.

- How to verify it

Static analysis should pass. Also, requires manual testing to ensure design elements are not broken

- Description for the changelog

fix: replace deprecated elements with equivalent up-to-date items in at_commons_flutter

@srieteja have you done the manual testing, or does that need somebody else to step in?

@cpswan I've just setup my emulators. Will be doing the testing now

@CurtlyCritchlow 👀 can you please sanity check this (manual tests to ensure layout isn't broken)

I've completed the manual testing for this one. I'm not sure if this can be merged yet. We can proceed with one of the following actions:

We merge this since all the stable static analyses are passing (or)
We wait for this merge until https://github.com/atsign-foundation/at_widgets/issues/847 is closed (which would ensure all the beta channel static analyses pass too)

@cpswan need your input on this.


[SPARK-11117] [SPARK-11345] [SQL] Makes all HadoopFsRelation data sources produce UnsafeRow

This PR fixes two issues:

PhysicalRDD.outputsUnsafeRows is always false
Thus a ConvertToUnsafe operator is often required even if the underlying data source relation does output UnsafeRow.

Internal/external row conversion for HadoopFsRelation is kinda messy
Currently we're using HadoopFsRelation.needConversion and dirty type erasure hacks to indicate whether the relation outputs external row or internal row and apply external-to-internal conversion when necessary.  Basically, all builtin HadoopFsRelation data sources, i.e. Parquet, JSON, ORC, and Text output InternalRow, while typical external HadoopFsRelation data sources, e.g. spark-avro and spark-csv, output Row.

This PR adds a private[sql] interface method HadoopFsRelation.buildInternalScan, which by default invokes HadoopFsRelation.buildScan and converts Rows to UnsafeRows (which are also InternalRows).  All builtin HadoopFsRelation data sources override this method and directly output UnsafeRows.  In this way, now HadoopFsRelation always produces UnsafeRows. Thus PhysicalRDD.outputsUnsafeRows can be properly set by checking whether the underlying data source is a HadoopFsRelation.
A remaining question is that, can we assume that all non-builtin HadoopFsRelation data sources output external rows?  At least all well known ones do so.  However it's possible that some users implemented their own HadoopFsRelation data sources that leverages InternalRow and thus all those unstable internal data representations.  If this assumption is safe, we can deprecate HadoopFsRelation.needConversion and cleanup some more conversion code (like here and here).
This PR supersedes #9125.
Follow-ups:

Makes JSON and ORC data sources output UnsafeRow directly

Makes HiveTableScan output UnsafeRow directly
This is related to 1 since ORC data source shares the same Writable unwrapping code with HiveTableScan.

Merged build triggered.

Merged build started.

Test build #44445 has started for PR 9305 at commit c161bf9.

Test build #44445 has finished for PR 9305 at commit c161bf9.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44445/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #44477 has started for PR 9305 at commit ee5c018.

Test build #44477 has finished for PR 9305 at commit ee5c018.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44477/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #44551 has started for PR 9305 at commit 65a68e2.

Test build #44551 has finished for PR 9305 at commit 65a68e2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44551/
Test PASSed.

Merged build finished. Test PASSed.

overall looks good to me. @davies do you want to do the final sign-off?

@liancheng Will this break any third-party data sources?

@davies I don't think so. Third-party HadoopFsRelation data sources only overrides buildScan and always return RDDs containing external Row. The buildInternalScan method automatically converts external Row to safe InternalRow and then UnsafeRow.

Just checked spark-csv and spark-avro, both conform to this assumption.

@liancheng Thanks, LGTM.

Merged build triggered.

Merged build started.

Test build #44577 has started for PR 9305 at commit 831d1c9.

Thanks for the review. Will merge this to master pending Jenkins.

Test build #44577 has finished for PR 9305 at commit 831d1c9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44577/
Test PASSed.

Merged build finished. Test PASSed.

@liancheng Took another look before merging, sorry for the late comments.

Merged build triggered.

Merged build started.

Test build #44687 has started for PR 9305 at commit 5d8fdac.

Test build #44687 has finished for PR 9305 at commit 5d8fdac.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44687/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #44721 has started for PR 9305 at commit ecc5345.

Test build #44721 has finished for PR 9305 at commit ecc5345.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44721/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #44733 has started for PR 9305 at commit 5ef0fc7.

Test build #44733 has finished for PR 9305 at commit 5ef0fc7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44733/
Test PASSed.


Clicking "View in CloudFormation" for a backend environment intermittently redirects to list stack screen instead of showing the particular stack information

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

App Id
All
AWS Region
us-east-1
Amplify Hosting feature
Not Applicable
Describe the bug
When we clicking "View in CloudFormation" for a backend environment intermittently redirects to list stack screen that is similar to "https://console.aws.amazon.com/cloudformation/home?region=us-east-1#/".
Expected behavior
However, the expected redirect should similar to "https://us-east-1.console.aws.amazon.com/cloudformation/home?region=us-east-1#/stacks/stackinfo?filteringText=&filteringStatus=active&viewNested=true&hideStacks=false&stackId="
Reproduction steps

Navigate to the Amplify Application
Navigate to backend environments
Click on any backend environment and click "View in CloudFormation" under the overview section

Build Settings
No response
Log output

# Put your logs below this line

Additional information
No response

Hi @anurag128 👋🏽 I'm not able to replicate this behavior on my end. You described this as intermittent - are you seeing this behavior when making an update to the backend? How often does this occur?


Implement keepUnused config property

@daidodo I have run into a bit of a pickle and I could use advice on how to proceed further.
Instead of solving it inside the sortImports I thought I would actually filter the usage based on keepUnused and then ImportNode.removeUnusedNames would be considering only those unused that don't match that configuration. This is what I started with...
https://github.com/daidodo/tsimportsorter/compare/master...FredyC:keep-unused?expand=1#diff-5161f4a1c904cc67c6e75c2f19a6f2c5R26-R39
The problem is that usage.unusedNames is just a list of names without relation to import node or path. I cannot filter it like that.
I can think of two bad solutions

Don't filter beforehand and include whole unused logic inside ImportNode.removeUnusedNames
Change usage.unusedNames to Map where the key would be a reference to ImportNode

Fixes #12

@FredyC, very fast work! I can see almost the shape!
Instead of hacking into usage, I'd suggest to extract and transform keepUnused in sortImports, then pass it as a 2nd parameter to n.removeUnusedNames.
Now inside of removeUnusedNames, you have enough info to decide final unused names.
One edge case is that when multiple elements in keepUnused match the path, you should combine the names, e.g. ['abc'] + [] => [].

One edge case is that when multiple elements in keepUnused match the path, you should combine the names, e.g. ['abc'] + [] => [].

I don't follow. You mean with a config like this it shouldn't match any names? How does that make sense? :)
keepUnusued: [
  { path: "A", names: ["B"] },
  { path: "A", names: [] },
]

Or is that a typo and you mean it will be ["B"]. To be clear what about this situation?
keepUnusued: [
  { path: "A", names: ["B"] },
  { path: "A", names: ["C"] },
]

As a user, I would have expected to keep both B and C for matching path A.

From the specification:

You need to match both paths and names to keep an unused name.
If names is null or empty, all names are kept.

So that [{"path": "abc", "names": ["Hi"]}] keeps Hi from abc.
And [{"path": "abc", "names": []}] keeps all names from abc.
When combining the names:

["A"] + ["B"] ==> ["A", "B"]
["A"] + [] ==> [] (which means all names)

Alright, I have a first working version now with passing tests. Have a look at it please and even you have some more test scenarios in mind, let me know. I will push docs update later.
FYI, about tests, I am running on Windows and some tests are failing because of CRLF vs LF, for example, insert-lines/head/use-strict/keep, the 0.origin.ts is saved with CRLF, but result.ts with LF. I guess there is some intention to normalize it but doesn't work on Windows because CRLF is default. 🤷♂

When combining the names:

From the specification:

You need to match both paths and names to keep an unused name.
If names is null or empty, all names are kept.

So that [{"path": "abc", "names": ["Hi"]}] keeps Hi from abc.
And [{"path": "abc", "names": []}] keeps all names from abc.
When combining the names:

["A"] + ["B"] ==> ["A", "B"]
["A"] + [] ==> [] (which means all names)

I don't particularly agree with this, specifying the [] for names feels too magical in my opinion. If you want to keep all names, either omit names completely or set it to null. That's how it's done now. If the array is empty, it won't keep any names except default import if present.

Hm, I actually tried to add a test case for the empty names array and behavior was kinda unexpected - it removed a whole node :)
So I've modified it the way you are proposing because it's easier. I personally don't care that much about that edge case to complicate the code for it more :)

Alright, updated schema, package, and readme - hopefully, it's enough like that. It's pretty much ready for the roll-out.

As I said above, I don't feel like spending time on this already. I consider the current state good enough given the rare cases of when this will be used.
Of course, feel free to dig in and rewrite a whole thing if you like. I tried my best and I am satisfied with it 💪

Wow, you really did rewrite it and it still passes all tests. Amazing how you managed to simplify it. I guess I was bit overengineering it :)

Although, readability is arguable, with all those one letter variables I am totally lost in there, but it's your choice if you like it that way.

I changed a few code and added more test cases. Now I'm ok to merge it.

Thank you very much for the contribution!

And I thank you for finishing it up. Hopefully, you can push a new version soon so I can get rid of those disable comments :)


util: remove some workarounds for GNU tests

I propose removing some of these replacements. Some of these test files seem to work now without replacing program XYZ with /usr/bin/XYZ on my machine. Let's see if the continuous integration build agrees. If it shows no change in the GNU test suite, then you should consider this change successful.

Good idea, it didn't regress:
Warning: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0


Remove itemtype from metatags

When encountering itemtype within a metatag, the parser would incorrectly assume the block is over early.

Now after merging this you'd need to publish new version and update the version in serpent repo

Also you can bump the minor version in packages.json as part of this PR.


Unhelpful error message running dev-server on Travis CI

I'm trying to get puppeteer running with a gatsby site on Travis CI. My jest-puppeteer.config.js is as follows:
module.exports = {
  server: {
    command: './node_modules/.bin/gatsby serve',
    port: 9000,
    debug: true,
  },
  launch: {
    args: ['--no-sandbox', '--disable-setuid-sandbox'],
  },
};

When jest --runInBand --ci is run I get the following output:
Jest dev-server output:
7
Server has taken more than 5000ms to start.

☝ You can set "server.launchTimeout" in jest-puppeteer.config.js
error Command failed with exit code 1.

I'm not sure where the error is coming from. How can I best debug this further?

server has a launchTimeout property that you can configure (in milliseconds). You could try increasing it.
If you look inside jest-dev-server package, inside src/globals.js, you can see that the default value is set to 5000ms.
const DEFAULT_CONFIG = {
  debug: false,
  options: {},
  launchTimeout: 5000,
  port: null,
  usedPortAction: 'ask',
}

As mentioned above, your config is missing launchTimeout. That's why it's defaulting to 5000ms as the error suggests.
Here's what you want:
module.exports = {
  server: {
    command: './node_modules/.bin/gatsby serve',
    launchTimeout: 30000, // set to 30s
    port: 9000,
    debug: true,
  },
  launch: {
    args: ['--no-sandbox', '--disable-setuid-sandbox'],
  },
};

https://github.com/smooth-code/jest-puppeteer/tree/master/packages/jest-dev-server#launchtimeout

I appreciate the help, both of you. I extended the launch timeout to 30 seconds and that seems to have done it.


Upload your own dataset - auto-select all counties in state

In the Upload Your Own Dataset module on PROD, selecting a state for a service area should auto-select all counties for that state and trigger the loading of the RPs. This means removing the "ALL" button that is currently displayed.
We chose to do this to simplify how users define a 'service area' and because they can filter out their analysis by county in the analysis page anyway.

Keeping current behavior for now (Custom is disabled on PRD). To be revisited in the future.