Deadlock

Bug report
Describe the bug
The validator seems to deadlock sometimes. It seems to be related to out of memory errors.
How we reproduce the bug
We were not able to reproduce it in a reliable way.
Screenshots:
If I run strace -s 99 on the process while it's deadlock this is what I get
[pid 1066956] futex(0x7f3c40673978, FUTEX_WAIT_BITSET_PRIVATE, 0, {tv_sec=1456231, tv_nsec=843564252}, FUTEX_BITSET_MATCH_ANY <unfinished ...>
[pid 1066759] futex(0x7f3d341ae87c, FUTEX_WAIT_BITSET_PRIVATE, 0, {tv_sec=1456231, tv_nsec=843581123}, FUTEX_BITSET_MATCH_ANY <unfinished ...>
[pid 1066956] <... futex resumed>)      = -1 ETIMEDOUT (Connection timed out)
[pid 1066759] <... futex resumed>)      = -1 ETIMEDOUT (Connection timed out)
[pid 1066956] futex(0x7f3c40673928, FUTEX_WAKE_PRIVATE, 1) = 0
[pid 1066956] futex(0x7f3c40673978, FUTEX_WAIT_BITSET_PRIVATE, 0, {tv_sec=1456231, tv_nsec=894077086}, FUTEX_BITSET_MATCH_ANY <unfinished ...>
[pid 1066759] futex(0x7f3d341ae828, FUTEX_WAKE_PRIVATE, 1) = 0
[pid 1066759] futex(0x7f3d341ae87c, FUTEX_WAIT_BITSET_PRIVATE, 0, {tv_sec=1456231, tv_nsec=894187471}, FUTEX_BITSET_MATCH_ANY <unfinished ...>
[pid 1066956] <... futex resumed>)      = -1 ETIMEDOUT (Connection timed out)
[pid 1066956] futex(0x7f3c40673928, FUTEX_WAKE_PRIVATE, 1 <unfinished ...>
[pid 1066759] <... futex resumed>)      = -1 ETIMEDOUT (Connection timed out)
[pid 1066956] <... futex resumed>)      = 0
[pid 1066759] futex(0x7f3d341ae828, FUTEX_WAKE_PRIVATE, 1 <unfinished ...>
[pid 1066956] futex(0x7f3c40673978, FUTEX_WAIT_BITSET_PRIVATE, 0, {tv_sec=1456231, tv_nsec=944341980}, FUTEX_BITSET_MATCH_ANY <unfinished ...>
[pid 1066759] <... futex resumed>)      = 0
[pid 1066759] futex(0x7f3d341ae87c, FUTEX_WAIT_BITSET_PRIVATE, 0, {tv_sec=1456231, tv_nsec=944429322}, FUTEX_BITSET_MATCH_ANY <unfinished ...>
[pid 1066956] <... futex resumed>)      = -1 ETIMEDOUT (Connection timed out)
[pid 1066759] <... futex resumed>)      = -1 ETIMEDOUT (Connection timed out)
[pid 1066956] futex(0x7f3c40673928, FUTEX_WAKE_PRIVATE, 1 <unfinished ...>
[pid 1066759] futex(0x7f3d341ae828, FUTEX_WAKE_PRIVATE, 1 <unfinished ...>
[pid 1066956] <... futex resumed>)      = 0
[pid 1066759] <... futex resumed>)      = 0
[pid 1066956] futex(0x7f3c40673978, FUTEX_WAIT_BITSET_PRIVATE, 0, {tv_sec=1456231, tv_nsec=994717560}, FUTEX_BITSET_MATCH_ANY <unfinished ...>
[pid 1066759] futex(0x7f3d341ae87c, FUTEX_WAIT_BITSET_PRIVATE, 0, {tv_sec=1456231, tv_nsec=994734541}, FUTEX_BITSET_MATCH_ANY <unfinished ...>
[pid 1066956] <... futex resumed>)      = -1 ETIMEDOUT (Connection timed out)
[pid 1066759] <... futex resumed>)      = -1 ETIMEDOUT (Connection timed out)
[pid 1066956] futex(0x7f3c40673928, FUTEX_WAKE_PRIVATE, 1 <unfinished ...>
[pid 1066759] futex(0x7f3d341ae828, FUTEX_WAKE_PRIVATE, 1 <unfinished ...>
[pid 1066956] <... futex resumed>)      = 0
[pid 1066759] <... futex resumed>)      = 0
[pid 1066956] futex(0x7f3c40673978, FUTEX_WAIT_BITSET_PRIVATE, 0, {tv_sec=1456232, tv_nsec=45116513}, FUTEX_BITSET_MATCH_ANY <unfinished ...>
[pid 1066759] futex(0x7f3d341ae87c, FUTEX_WAIT_BITSET_PRIVATE, 0, {tv_sec=1456232, tv_nsec=45146218}, FUTEX_BITSET_MATCH_ANY <unfinished ...>
[pid 1066749] <... futex resumed>)      = -1 ETIMEDOUT (Connection timed out)
[pid 1066749] futex(0x7f3d340cec28, FUTEX_WAKE_PRIVATE, 1) = 0
[pid 1066749] getrusage(RUSAGE_THREAD, {ru_utime={tv_sec=4, tv_usec=485045}, ru_stime={tv_sec=1, tv_usec=888009}, ...}) = 0
[pid 1066749] futex(0x7f3d340cec78, FUTEX_WAIT_BITSET_PRIVATE, 0, {tv_sec=1456232, tv_nsec=322073722}, FUTEX_BITSET_MATCH_ANY <unfinished ...>
[pid 1066956] <... futex resumed>)      = -1 ETIMEDOUT (Connection timed out)
[pid 1066759] <... futex resumed>)      = -1 ETIMEDOUT (Connection timed out)
[pid 1066956] futex(0x7f3c40673928, FUTEX_WAKE_PRIVATE, 1 <unfinished ...>
[pid 1066759] futex(0x7f3d341ae828, FUTEX_WAKE_PRIVATE, 1 <unfinished ...>
[pid 1066956] <... futex resumed>)      = 0
[pid 1066759] <... futex resumed>)      = 0
[pid 1066956] futex(0x7f3c40673978, FUTEX_WAIT_BITSET_PRIVATE, 0, {tv_sec=1456232, tv_nsec=95507682}, FUTEX_BITSET_MATCH_ANY <unfinished ...>
[pid 1066759] futex(0x7f3d341ae87c, FUTEX_WAIT_BITSET_PRIVATE, 0, {tv_sec=1456232, tv_nsec=95522138}, FUTEX_BITSET_MATCH_ANY <unfinished ...>
[pid 1066956] <... futex resumed>)      = -1 ETIMEDOUT (Connection timed out)
[pid 1066759] <... futex resumed>)      = -1 ETIMEDOUT (Connection timed out)
[pid 1066956] futex(0x7f3c40673928, FUTEX_WAKE_PRIVATE, 1 <unfinished ...>
[pid 1066759] futex(0x7f3d341ae828, FUTEX_WAKE_PRIVATE, 1 <unfinished ...>
[pid 1066956] <... futex resumed>)      = 0
[pid 1066759] <... futex resumed>)      = 0
[pid 1066956] futex(0x7f3c40673978, FUTEX_WAIT_BITSET_PRIVATE, 0, {tv_sec=1456232, tv_nsec=145870548}, FUTEX_BITSET_MATCH_ANY <unfinished ...>
[pid 1066759] futex(0x7f3d341ae87c, FUTEX_WAIT_BITSET_PRIVATE, 0, {tv_sec=1456232, tv_nsec=145884474}, FUTEX_BITSET_MATCH_ANY^Cstrace: Process 1066743 detached

The error log is :
{"notices":[{"code":"runtime_exception_in_validator_error","severity":"ERROR","totalNotices":8,"sampleNotices":[{"validator":"org.mobilitydata.gtfsvalidator.validator.ShapeToStopMatchingValidator","exception":"java.lang.NullPointerException","message":""},{"validator":"org.mobilitydata.gtfsvalidator.validator.GtfsStopTimeTripIdForeignKeyValidator","exception":"java.lang.NullPointerException","message":""},{"validator":"org.mobilitydata.gtfsvalidator.validator.LocationHasStopTimesValidator","exception":"java.lang.NullPointerException","message":""},{"validator":"org.mobilitydata.gtfsvalidator.validator.TripUsabilityValidator","exception":"java.lang.NullPointerException","message":""},{"validator":"org.mobilitydata.gtfsvalidator.validator.GtfsStopTimeStopIdForeignKeyValidator","exception":"java.lang.NullPointerException","message":""},{"validator":"org.mobilitydata.gtfsvalidator.validator.TripUsageValidator","exception":"java.lang.NullPointerException","message":""},{"validator":"org.mobilitydata.gtfsvalidator.validator.StopTimeTravelSpeedValidator","exception":"java.lang.NullPointerException","message":""},{"validator":"org.mobilitydata.gtfsvalidator.validator.BlockTripsWithOverlappingStopTimesValidator","exception":"java.lang.NullPointerException","message":""}]},{"code":"thread_execution_error","severity":"ERROR","totalNotices":1,"sampleNotices":[{"exception":"java.lang.OutOfMemoryError","message":"Java heap space"}]}]}

Environment versions

validator version: v3.0.0
Java version:
openjdk 11.0.13 2021-10-19
OpenJDK Runtime Environment (build 11.0.13+8-Ubuntu-0ubuntu1.20.04)
OpenJDK 64-Bit Server VM (build 11.0.13+8-Ubuntu-0ubuntu1.20.04, mixed mode, sharing)
OS versions: Ubuntu 20.04.3 LTS

Update : we were able to reproduce every time by forcing a memory limit in a cgroup in linux. Using a limit of 500MB and this feed reproduces the bug every time. Using 100MB, the problem is not reproduced and the process is killed by the kernel.
Using cgroups and a memory limit that's big enough to start the process but big enough to make it run all the rules is enough to reproduce the problem.

Hi Guillaume,
Thanks for reporting this issue! From a brief look, it seems the validator is failing with OutOfMemoryError, I can reproduce it by adding -Xmx500m java argument.
java -Xmx500m -jar gtfs-validator-v3.0.0_cli.jar -u https://data.bus-data.dft.gov.uk/timetable/download/gtfs-file/south_west/ -o output

I can see that the feed you provided has ~600MB in size. We didn't do heavy memory optimizations and on some bigger feeds 3-6GB should be enough. We would recommend to reserve at least 3GB of memory, this could be done by passing -Xms3g -Xmx3g arguments.
Could you please provide a bit more context to make sure that we understand the problem correctly?

What command line do you use to start the validator?
What do you mean by deadlock? Does the validator get stuck and it must be terminated manually?
What's the expected behaviour?

@asvechnikov2 yes, the validator deadlocks. It rans out of memory but the problem is actually the deadlock : it hits a point where it's not running anything but never returns or crash. An OutOfMemory crash is actually the expected behaviour.
java -Xmx500m -jar gtfs-validator-v3.0.0_cli.jar -i path_to_gtfs -o output is what we use.
More context : we use cgroups in our data pipeline to make sure a process doesn't use more memory than it's expected to use. We use historical running data to know how much memory to allocate, so if a feed X used 100MB the last time it ran, we'll use a limit of 100MB + a buffer to avoid slowdown on the server.
To reproduce the bug you really need to use cgroups memory limits of the same size of the -Xmx argument.

Hi @gcamp !
Thanks for the details. Unfortunately, we were not able to reproduce the exact same behavior using cgroup + -Xmx, where the validator crashes. In every test run, the process is killed when a memory problem occurs. Could you provide a code snippet to see if your use of cgroup differs from ours?
That being said, like you, we noticed that using cgroup causes problems, so we ran a script to compare cgroup + -Xmx against -Xmx alone. We ran our tests on a DigitalOcean VM with the following specifications:

OpenJDK version “11.0.13” 2021-10-19
OpenJDK Runtime Environment (build 11.0.13+8-Ubuntu-0ubuntu1.20.04)
OpenJDK 64-Bit Server VM (build 11.0.13+8-Ubuntu-0ubuntu1.20.04, mixed mode, sharing)

Here are our observations. Our scripts and results can be found in this archive.

For cgroup + -Xmx: once the memory limit set for the cgroup is reached, the process is killed and the validator cannot even generate its validator and system reports.
For -Xmx: the validator fails due to an OutOfMemoryError when the memory limit is reached, but is able to generate its reports.

It seems pretty clear that using cgroup with -Xmx causes a problem at this point. We define as uncompleted processes all processes where the validator was unable to generate its reports before being killed, including errors other than memory errors.
As the figure above suggests, I suggest you increase the memory limit of your cgroup to at least 3.5gb when using the validator, or drop cgroup and use only -Xmx. We realize that this may not be the best solution for your current use case. Would this be an option for you?
Our understanding is that the problem may be caused by cgroup itself rather than the validator, but this is still uncertain.  Optimizing the validator memory usage is in our backlog, although it is not planned in the short term. If there is a way for you to provide us with more details on how to reproduce the specific deadlock bug, please let us know so we can dig deeper.


🐛 Native Module 'CameraView' was null!

What were you trying to do?
Tried building a bundle for android but caught Native Module 'CameraView' was null! every time
I've check on two devices one of them (Huawei Nova 5T) turned to be with limited Camera 2 support, another (One Plus 8) - with a full support of Camera 2 (aka Level_3)
tried with:
[] Expo expo r -c on 2 devices
[] react-native run-android on emulator
[] expo build:android
[] different versions of react-native-vision-camera
[] different versions of NDK
[] checked troubleshooting
[*] added maven repo (see expo issues)
Everything made on Ubuntu 20
No hope to start camera on android devices for now, pod install while building only for android looks more upsetting
Reproduceable Code
import React, { useState, useEffect} from 'react';
import { Text, Platform, StatusBar, StyleSheet, View } from 'react-native';

import AppNavigator from './navigation/AppNavigator';
import {Camera, useCameraDevices} from 'react-native-vision-camera'
import { Button } from 'react-native-ui-lib';

export default function App(props) {
  const devices = useCameraDevices('wide-angle-camera')
  const device = devices.back
  const [cameraOn, setCameraOn] = useState(false)
  const [permissons, setPermissons] = useState(false)

  const getPermissons = async () => {
    const cameraPermission = await Camera.getCameraPermissionStatus()
    if (cameraPermission === 'authorized') {
      setPermissons(true)
    }
  }

  const requestPermissons = async () => {

    const newCameraPermission = await Camera.requestCameraPermission().catch((error) => console.warn("camera error:", error))
    if (newCameraPermission === 'authorized') {
      setPermissons(true)
    }
  }

  useEffect(() => {
    getPermissons()
  }, [])

  if (!permissons) {
    return (
      <View style={{ flex: 1, justifyContent: 'center', alignItems: 'center' }}>
        <Text>No permissons</Text>
        <Button onPress={requestPermissons}></Button>
      </View>
    )
  }

  if (!device) {
    return (
      <View style={{ flex: 1, justifyContent: 'center', alignItems: 'center' }}>
        <Text>Loading</Text>
      </View>
    )
  }

  if (!cameraOn) {
    return (
      <View style={{ flex: 1, justifyContent: 'center', alignItems: 'center' }}>
        <Text>Turn on the camera</Text>
        <TouchableOpacity onPress={() => setCameraOn(true)} style={{ marginTop: 30, backgroundColor: '#28a745' }}>
          <Text style={{ marginHorizontal: 20, marginVertical: 10, color: 'white' }}>ON</Text>
        </TouchableOpacity>
      </View>
    )
  }

  return (
    <Camera
      style={StyleSheet.absoluteFill}
      device={device}
      isActive={true}
    />
  )
}

settings.gradle

apply from: '../node_modules/react-native-unimodules/gradle.groovy'
includeUnimodulesProjects()

apply from: file("../node_modules/@react-native-community/cli-platform-android/native_modules.gradle");
applyNativeModulesSettingsGradle(settings)

include ':app'

include ':react-native-vision-camera'
project(':react-native-vision-camera').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-vision-camera/android')

build.gradle

buildscript {
    ext {
        kotlinVersion = "1.4.31"
        RNNKotlinVersion = kotlinVersion
        buildToolsVersion = "30.0.2"
        minSdkVersion = 21
        compileSdkVersion = 30
        targetSdkVersion = 30
        // ndkVersion = "23.0.7599858"
        ndkVersion = "20.1.5948944"
        VisionCamera_ndkVersion=ndkVersion
    }
    repositories {
        google()
        jcenter()
        mavenLocal()
        mavenCentral()
    }
    dependencies {
        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:1.4.31"
        classpath("com.android.tools.build:gradle:4.2.0")

        // NOTE: Do not place your application dependencies here; they belong
        // in the individual module build.gradle files
    }
}
allprojects {
    repositories {
        ...
        maven {
            // expo-camera bundles a custom com.google.android:cameraview
            // See: https://github.com/expo/expo/issues/3639
            url "$rootDir/../node_modules/expo-camera/android/maven"
        }
    }

 app.json
{
 "name": "xxx",
 "slug": "xxx",
 "privacy": "public",
 "platforms": [
   "android"
 ],
...
}

What happened instead?
Camera devices are all undefined
  "back": undefined,
  "external": undefined,
  "front": undefined,
  "unspecified": undefined,
}```

`Camera: Native Module 'CameraView' was null! Did you run pod install?` in logs

### Relevant log output

```shell
=========== expo log ============
Camera: Native Module 'CameraView' was null! Did you run pod install?
at node_modules/react-native-vision-camera/src/Camera.tsx:47:21 in <global>
at http://<IP_ADDRESS>:19000/index.bundle?platform=android&dev=true&hot=false&minify=false:279474:27 in <unknown>
at http://<IP_ADDRESS>:19000/index.bundle?platform=android&dev=true&hot=false&minify=false:279358:44 in <unknown>
at http://<IP_ADDRESS>:19000/index.bundle?platform=android&dev=true&hot=false&minify=false:171335:56 in <unknown>
at http://<IP_ADDRESS>:19000/index.bundle?platform=android&dev=true&hot=false&minify=false:161267:60 in <unknown>
at App.js:9:0 in <global>
at index.js:4:0 in <global>
at http://<IP_ADDRESS>:19000/index.bundle?platform=android&dev=true&hot=false&minify=false:280748:3 in global code

=============== apk log ============

10-05 12:36:15.799 28935 29007 E ReactNativeJS: Camera: Native Module 'CameraView' was null! Did you run pod install?
10-05 12:36:15.805 28935 29008 E unknown:ReactNative: console.error: Camera: Native Module 'CameraView' was null! Did you run pod install?, stack:
10-05 12:36:15.805 28935 29008 E unknown:ReactNative: construct@-1
12:41

10-05 12:35:17.580 28010 28177 W ReactNativeJS: 'camera error:', { [TypeError: null is not an object (evaluating 'b.requestCameraPermission')]
10-05 12:35:17.580 28010 28177 W ReactNativeJS: line: 1531,
10-05 12:35:17.580 28010 28177 W ReactNativeJS: column: 7119,
10-05 12:35:17.580 28010 28177 W ReactNativeJS: sourceURL: '/data/user/0/*****/files/.expo-internal/1643d28a4e9b769276d0a00431a815dd' }

Device
OnePlus 8 (IN2013) Android 10, Huawei Nova 5T (YAL-L21)
VisionCamera Version
2.8.3, 2.7.0
Additional information

[X] I am using Expo
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar issues in this repository and found none.

Closing in favor of #488


Implement drop List to select algorithm

Currently you have to write the algorithm name to run it, eg: mergesort, the idea is to make a drop list that shows all algorithms and the user can select just by pressing it!
Use pygame preferably, but if you find a much easier and cleaner way do it!

I wanna work on this if possible?

Okay, i will asign this issue to you


dubbo client send wrong data to provider and the returned data type from provider also wrong

I have an application that sends data to dubbo provider

However, the provider didn't get the unique code, idk what happened in here since I follow the documentation that is provided

Also, the dubbo provider return wrong data so I get ClassCastException

StubInvocationUtil.unaryCall(...) return type of org.dubbo.springboot.MedicFacilityParam instead of org.dubbo.springboot.MedicFacility  but the proto file I defined is
syntax = "proto3";

import "parent.proto";

option java_multiple_files = true;
option java_outer_classname = "Dubbo";

package org.dubbo.springboot;

/* Medic Facility */

message MedicFacility{
    int64 id = 1;
    string email = 2;
    string username = 3;
    string unique_code = 4;
    string telephone_number = 5;
    string whatsapp_number = 6;
    string address = 7;
    bool is_active = 8;
}

message MedicFacilityParam{
    int64 id = 1;
    repeated int64 ids = 2;
    string email = 3;
    string unique_code = 4;
    PgParam pg_param = 5;
}

message ListMedicFacility{
    repeated MedicFacility medic_facilities = 1;
    Pagination pg = 2;
}

service MedicFacilityService{
    rpc Get(MedicFacilityParam) returns (MedicFacility);
    rpc GetList(MedicFacilityParam) returns (ListMedicFacility);
}

Do I miss something here? thank you

Solved, the problem is with my dubbo protocol. Thank you


added translation to keep up with the English version

@vickyhella3 There's some new conflicts, if you address and @WuJun2016 approves I'll merge. Thanks!

LGTM

@richard-cox The conflicts have been addressed.


Page Width Consistency Issue with Obsidian SNW Plugin

Hello,
I use the following CSS code to set the page width in Obsidian:
body {
  --user-custom-width: 703px !important;
  --file-line-width: var(--user-custom-width);
}

When SNW is not enabled, the page width remains consistent in both reading and preview modes. However, when I enable SNW, the page width becomes narrower in preview mode, as shown in the attached image.

Could you please advise on which parameters to adjust to maintain consistent page width when NSW is enabled? Thank you!

This is a side effect of having references showing in gutters, because when gutters are enabled, Obsidian pushes out the margin. Also different themes handle gutters differently, so in some cases this extra margin is visible, while in other themes its not.
Two solutions:

In most cases, the gutter option is not needed, it is for handling a few edge cases. So it can be disabled:

Use a theme that handles gutters the way you would like them to appear.

Thank you for your issue.


Feature gates for testing

What this PR does / why we need it:
This PR add env FEATURE_GATES that will be passed in make-sync target and resulting cluster will have this feature gates set on Kubevirt resource. Further, it appends default feature gates rather than override. This is needed in cases where we want to enable NonRoot feature gate for some lanes but also use the default feature gates.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:
None

/cc @dhiller @rmohr @fgimenez

/approve

/lgtm

/retest


Bug: Grouped Curtains Returning No Status, cannot close

Describe The Bug
After grouping my curtains in the Switchbot app, they will always been seen as closed in Homebridge.
To Reproduce
Group 2 curtain bots in the Switchbot app (making them appear as 1). Add the device in Homebridge, and attempt to open the curtains. Nothing will happen. However, you can close them.
Expected behavior
They should open/close when commanded, like a good robot.
Relevant log output
[1/13/2023, 11:20:56 AM] [SwitchBot] Total SwitchBot Devices Found: 3
[1/13/2023, 11:20:56 AM] [SwitchBot] Adding new accessory: Living Room Curtains Curtain DeviceID: FD90B0540EA4
[1/13/2023, 11:20:56 AM] [SwitchBot] Curtain: Living Room Curtains Config: {"set_minStep":25,"setOpenMode":"0","setCloseMode":"0","hide_lightsensor":true,"connectionType":"OpenAPI"}
[1/13/2023, 11:22:20 AM] [SwitchBot] Curtain: Living Room Curtains Checking Status ...

Config for homebridge-switchbot
{
            "name": "SwitchBot",
            "credentials": {
                "token": "XXXXXXXXXXXXXXXXXXXXXXXX",
                "secret": "XXXXXXXXXXXXXXXXXXXXXXXX",
                "notice": "Keep your Token & Secret a secret!"
            },
            "options": {
                "devices": [
                    {
                        "deviceId": "FD90B0540EA4",
                        "configDeviceType": "Curtain",
                        "connectionType": "OpenAPI",
                        "curtain": {
                            "set_minStep": 25,
                            "setOpenMode": "0",
                            "setCloseMode": "0",
                            "hide_lightsensor": true
                        },
                        "disableCaching": true
                    }
                ]
            },
            "_bridge": {
                "username": "0E:D1:7D:62:3F:71",
                "port": 33837
            },
            "platform": "SwitchBot"
        }

Screenshots

Device & Model
Hub Mini, Curtain Bot
Node.js Version
v18.13.0
NPM Version
v9.3.0
Homebridge Version
v1.6.0
Homebridge Switchbot Plugin Version
v2.4.1-beta.7
Homebridge Config UI X Plugin Version
v4.50.2
Operating System
Docker

I've tried upgrouping and resetting everything, and still no luck. I've cleared the caches and removed the devices from HomeBridge. I've created sub-bridges and that didn't do anything either.
I can see the devices, but I cannot close them. They always appear as closed in HomeKit. They WILL close when commanded, but they won't open (and there is never a updated status in the logs)

Where these curtains in Homebridge before you grouped them?

I don't recall. They were definitely in HK beforehand, but they had stopped working. I only discovered SwitchBot supported grouping while I was troubleshooting why they had stopped working.
I've since removed and re-added them in HK, plus I've entirely removed and re-added the HomeBridge plugin... nothing seems to help.
I'm on the new HomeKit architecture. Unsure this is this part of the mystery. But the blinds had originally stopped working well before I upgraded.

Can you try a previous version of the plugin?

There is a disable cache config. Can you try that?

I checked the "Disable Caching" checkbox under "SwitchBot Device Settings" but it had no effect. As mentioned in https://github.com/OpenWonderLabs/homebridge-switchbot/pull/658, Homebridge needs to be restarted for the state to update.
#652 and #653 appear to be duplicates of this.

I think my bug #666 is also the same as this. In my case the grouped curtains have been working essentially forever. This issue just started recently.

I've tried disabling cache, and nothing seems to help. However, I enable debug logging, and it looks to be a timeout issue?
[2/6/2023, 3:51:13 PM] [SwitchBot] [DEBUG] Curtain: Curtains refreshStatus: {"statusCode":100,"body":{"deviceId":"XXXXXXXX","deviceType":"Curtain","hubDeviceId":"XXXXXXX","slidePosition":100},"message":"success"}
[2/6/2023, 3:51:13 PM] [SwitchBot] [DEBUG] Curtain: Curtains openAPIparseStatus
[2/6/2023, 3:51:13 PM] [SwitchBot] [DEBUG] Curtain Curtains CurrentPosition: 0
[2/6/2023, 3:51:13 PM] [SwitchBot] Curtain: Curtains Checking Status ...
[2/6/2023, 3:51:13 PM] [SwitchBot] [DEBUG] Curtain: Curtains Standby, CurrentPosition: 0
[2/6/2023, 3:51:13 PM] [SwitchBot] [DEBUG] Curtain: Curtains Stopped
[2/6/2023, 3:51:13 PM] [SwitchBot] [DEBUG] Curtain: Curtains CurrentPosition: 0, TargetPosition: 0, PositionState: 2,
[2/6/2023, 3:51:13 PM] [SwitchBot] [DEBUG] Curtain: Curtains updateCharacteristic CurrentPosition: 0
[2/6/2023, 3:51:13 PM] [SwitchBot] [DEBUG] Curtain: Curtains updateCharacteristic PositionState: 2
[2/6/2023, 3:51:13 PM] [SwitchBot] [DEBUG] Curtain: Curtains updateCharacteristic TargetPosition: 0
[2/6/2023, 3:51:17 PM] [SwitchBot] [DEBUG] Curtain: Curtains setNewTarget true timeout

I can manually set a specific % in Homekit (eg. move the slider to 2%), and it'll work just fine (that is, the curtains will close to 2%). However, in the Home app, it'll show them as "closed".
Tapping on the button in Home will then open the curtains, but the status will again revert back to "closed".

so it seems like perhaps something is timing out, which then reverts the state of the curtains as "closed".

I think my bug #666 is also the same as this. In my case the grouped curtains have been working essentially forever. This issue just started recently.

For context, my grouped curtains were also working flawlessly previously as well (that is, "grouped" in Homekit, and not grouped via SwitchBot). I had originally thought this was an issue with how SwitchBot was handling grouping in their app (and therefore what is exposed to Homebridge), but I don't think it's related anymore.
I simply cannot get my curtains to reliably work at all now, grouped or not. They will open, but the status will always revert back to "closed"

Out of curiosity, what version of tvOS/iOS are you running on your Homekit hub?

All available hubs (Apple TV or HomePod) are running 16.3

duplicate to #666


WIP: PoC LwM2M FW update multiple objects

Signed-off-by: Veijo Pesonen<EMAIL_ADDRESS>

Not needed based on discussion under OpenMobileAlliance/lwm2m-registry#638.


[Feature Request] NG+ superboss and Regicide on first playthrough

Would it be possible to make the superboss exclusive to New Game Plus, as well as the Regicide difficulty, available on your first playthrough somehow? It's hard to justify doubling your playtime for a single bonus fight (especially since NG+ doesn't even carry over level), but I also don't wanna skip it lol

This is probably not something I'd add to MetaphorFix as it looks like someone has already made a mod for this.
https://gamebanana.com/mods/548472

I think that's only for the difficulty, not to make the NG+ superboss available on a first playthrough? Fair enough if you still don't think MetaphorFix is the right place for this kind of adjustment though, but I figured I'd ask about it at least 👍


Closes #9 Updated README.md with the newly added alogrithms

sorry, that issue was already resolved by someone who commented on the issue


Fast isinstance checks

Fix #497 (maybe)
This isn't actually much faster in most cases, but if will be if the errors linked in #497 become a problem.
I'll close this, just creating it so we have a record of the change if necessary.

Codecov Report

Merging #504 (6ea4b89) into main (ecc8df4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #504   +/-   ##
=======================================
  Coverage   94.58%   94.59%
=======================================
  Files          93       93
  Lines       12007    12022   +15
  Branches       25       25
=======================================
+ Hits        11357    11372   +15
  Misses        643      643
  Partials        7        7

Impacted Files
Coverage Δ

src/input/input_abstract.rs
88.00% <100.00%> (+0.37%)
:arrow_up:

src/input/input_python.rs
98.31% <100.00%> (+0.05%)
:arrow_up:

src/validators/model.rs
98.24% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecc8df4...6ea4b89. Read the comment docs.

Closing but we have the code if required later.


Copying a file with cat and redireciton does not result in identical data

As mentioned in this issue, redirecting data in powershell introduces some unintended alteration.
https://github.com/jtheoof/swappy/issues/51#issuecomment-662180488
Steps to reproduce
It is problematic when handling for example image data being passed between applications as described there, but can also be reproduced by simply trying to copy a file using cat.
Simply create a png file called in.png and try to copy it to out.png wit the following command.
cat in.png > out.png

Expected behavior
The two file should contain exactly the same data.
Actual behavior
Checking for differences reveals that the two files are not identical, also, the duplicate png file does not even open on my system.
diff in.png out.png # Binary files in.png and out.png differ

Environment data

PSVersion                      7.0.2
PSEdition                      Core
GitCommitId                    7.0.2
OS                             Linux 5.7.9-arch1-1 #1 SMP PREEMPT Thu, 16 Jul 2020 19:34:4…
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Currently, PowerShell only knows text when communicating with external programs - you cannot send raw byte from an external program data as-is through the PowerShell pipeline (which includes the use ... > <file>, which is the equivalent of ... | Out-File <file>
See #1908 and #5974  and this Stack Overflow answer for a workaround.


fix(nulls): Minor fixes to address null values

Not sure why these changes weren't brought in with the other pull requests I sent you.  They were in my code at the time, but when I was debugging the latest version these seemed to be the nulls that were causing the problem - and when I compared them to the original pull request these were the lines that were working.

This will be in https://github.com/andrewthetechie/gha-repo-manager/pull/53


Log response size exceeded. Please reduce query block range.

When fetching logs with eth_getLogs and the amount of data is too big alchemy will return Log response size exceeded. Please reduce query block range.
Url: https://eth-mainnet.alchemyapi.io/v2/_gHhOgCqAFaa8f35R1PeHmpHx1E-zVcN
Request:
{
    "jsonrpc":"2.0",
    "method":"eth_getLogs",
    "params": [{
          "fromBlock":"0xab7149",
          "toBlock":"latest",
          "address":"0x2F9EC37d6CcFFf1caB21733BdaDEdE11c823cCB0"
    }],
    "id":1
}

They have hard limits on blocks:
We actually have an eth_getLogs limit in place for requests up to a 2k block range or any block range with a cap of 10k logs in the response (https://docs.alchemyapi.io/documentation/alchemy-api-reference/json-rpc#eth_getlogs).  So it looks like your request is from block 0xab7671=11236977 to latest which was ~11242937 around the time you sent off the request. This is a difference of 5,960 blocks, which is why you're seeing that error response

we should try batching request in 2k blocks batches @Velua

Yeah that's annoying, will have to chunk in block sizes of 2,000, given we want about 6,000 ish then we'll need 3 concurrent requests, think our limit is 30 API key wide.
We'll be able to make this smoother with any failures going in as retries on an Observable.

Now pulling from API, this is redundant.

Now pulling from API, this is redundant.


Migration guide

Coming from Director, I was not able to make a quick switch to tarantino.
Setting aside the discussions of the future/direction of this repo, I think it would be of help Director users to have a director -> tarantino migration guide.
I have only been using the browser implementation, so I would be of no help for writing a TL;DR for the server-side/node bits … Though, I would not mind making notes for the browser part.
Thoughts?

I'm only using the browser part too. There were only a few changes to the browser part, but it shouldn't break too much stuff. The biggest change was that I switched the module bundler from CodeSurgeon (which is deprecated), to Rollup. Also I enabled html5history API by default.

Ah, the html5history API may have been breaking my non-html5history setup when doing the switch. I'll try again and make notes; I will update this issue once I have something. At a bare minimum, maybe having this issue will suffice in terms of a guide. 👍
Thanks!

Ah, the html5history API may have been breaking my non-html5history setup when doing the switch.

I think the real reason why html5 history did not work is because my app was not deployed at the root of my local dev. I could be wrong, but it seems like html5 option requires a site deployed at the root of the url.
http://stackoverflow.com/questions/10045540/history-pushstatedata-title-url-concatenates-instead-of-replacing-url-to-add
Still learning about html5 pushstate and replacestate, so bare with me.

It doesn't really require the app to be at your root, but if it's not at the root you need some additional config.  However, you could "automate" this by setting this path in a variable and use that each time. Or, but I haven't tested this, you could do something like this:
{
  '/mypath': {
     '/dog': function() {},
     '/cat': function() {},
  }
}

t doesn't really require the app to be at your root, but if it's not at the root you need some additional config.

Ahh, I see! Thanks for the tips!
I will be officially making the switch today and will update this issue if I run into any issues. :octocat:

One thing I noticed was that I needed to call the router like so:
tarantino.Router(......)

The docs just specify "Router".
I can do a PR to correct this, unless I am overlooking something. 👍

@mhulse ah yes that seems to be wrong in the first example. Btw, we could update the Node.js examples to be const { Router } = require('tarantino');, that's a bit more fancy.

ah yes that seems to be wrong in the first example. Btw, we could update the Node.js examples to be const { Router } = require('tarantino');, that's a bit more fancy.

Awesome, I'll update the docs. 👍


Spice works on Ubuntu, not on Debian guests

Configuration

UTM Version: 4.2.5
macOS Version: 13.3.1
Mac Chip: M1

Ubuntu 23.04 guest:

Installed several months ago with a previous version of UTM.
spice-vdagent 0.22.1-3 is installed.
It works correctly:

The display is reconfigured on resize.
The shared folder is correctly mounted.

Debian 11.7 guest:

Just installed using UTM 4.2.5.
spice-vdagent 0.20.0-2 is installed.
Does not work:

The display is not reconfigured on resize, it proportionally shrinks or enlarges.
The shared folder cannot be mounted

# modprobe 9pnet_virtio
# mount -t 9p -o trans=virtio share /shared
mount: /shared: special device share does not exist.

Is this due to Ubuntu vs Debian? Spice agent 0.22 vs. 0.20 (the standard versions on their respective distro)? Something else?

I'm having the same problem with the shared directory on Debian. I get the following error:
$ sudo mount -t 9p -o trans=virtio share test -oversion=9p2000.L
mount: /home/XX/XXXX: special device share does not exist.
       dmesg(1) may have more information after failed mount system call.

Here's the relevant output from dmesg:
9pnet_virtio: no channels available for device share

Any ideas how to fix this? Thanks!


NSNumber: update API for SE-0170

It was reported to me that Int(truncating: NSNumber) was missing in swift-corelibs-foundation. This function was added as part of SE-0170.
This PR implements the init(truncating) and init?(exactly) APIs from SE-0170, and also deprecates init(_:) appropriately.
It seems we also lacked implementations of init(_:) for many of the primitive number types (e.g. Int8) to begin with so this PR also adds those.

@swift-ci please test

@swift-ci please test

@swift-ci please test

This should be merged after #1213.

@swift-ci please test

@swift-ci please test and merge


Empty host label not recognized from service scheduler

Hey there,
it is possible to set an empty host label (no value) but if I want to use it like this
[...]
  labels:
    io.rancher.scheduler.affinity:host_label:  "mongo-replset"

.. it fails directly. Saying that no host could be found.
[...]
  labels:
    io.rancher.scheduler.affinity:host_label:  "mongo-replset="

.. it stays in "Scheduling" forever.

This is a similar request to https://github.com/rancher/rancher/issues/2601 where you are trying to use the same syntax that selector labels support for scheduling labels. This is not supported and I'll close this one in favor of the other one.


Feature Request: allow @combine to accept functions

combine(groupby(df, :grp), nrow) works in DataFrames.jl
but
@combine(groupby(df, :grp), nrow) doesn't produce the right output in DataFrameMacros.jl

this now exists as @combine(..., @nrow) so it doesn't interfere with other syntax https://github.com/jkrumbiegel/DataFrameMacros.jl/pull/25


Added multi-factor unlock

Added multifactor unlock feature update using Passport for work CSP.
Problem: https://github.com/MicrosoftDocs/windows-itpro-docs/issues/4700

@nenonix @JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks.

Suggestions applied.

@mapalko @Dansimp - PR has been copy edited and is ready for final review. This is based on issue #4700.
Thank you.

The rest of the page needs some MarkDown codestyle improvements, as well as XML codestyle fine tuning and marking the XML code blocks as ```xml (but that is outside the scope of this PR, so I will get back to this page at a later time (after the merge of this PR) and see what I can do to improve it.

@Dansimp - Can you possibly merge this PR? This has been approved by the author @mapalko
Thank you.


Fix/91 bis

closes #91

Only the CHANGELOG.md has to be updated, appart from that everything is all right.


Added Bit Academy

An overview of our program can be found here: https://www.bit-academy.nl/programma

@bobvandenberge Pull request merged. Thank you!


UI is like Web 2.0

Describe the bug
The UI is like Web 2.0 in 1995. I will add a screenshot of an example Pomodore App.
Link to the Bolt URL that caused the error
bolt.new
Steps to reproduce

Give a prompt
Start and get shocked

Expected behavior
Beautiful UI like Next js and Apple
Screen Recording / Screenshot

Platform
No response
Additional context
No response

hey! this is actually just a prompting thing :)
Try something like:

Create a modern pomodoro timer with a sleek UI using Tailwind CSS. Make it look professional like Apple's design - clean, minimal, with proper spacing and subtle animations.

The more specific you are about design/styling, the better the output. Bolt can definitely do modern UIs, just needs the right prompts!
Let me know if you need any other prompting tips ✌

Thats not true. I tried these kinds of prompts still ugly. Try it on this local bolt not on the bolt.new site. So what is the reason for the ugly site?

1 @faddy19 - This is not a prompting issue.
The model is unable to generate good UI's.

For now its focusing more on functionality rather than looking good.
If you ask it to make a landing page for some local business - It makes the worst layout and designs.
I was somehow hoping to improve this - But don't know how.

Found this and it can solve the UI problem
https://x.com/nickadobos/status/1850017917628535090?s=46&t=VT70WICa668Q38QaXYKxGA
That is generating insanely good UIs

@faddy19 is it the same for the OS version? The video example on twitter is using the closed source version of bolt.new right?
I also wonder what parts did they choose to hide or remove to create the OS version?


Invalid country code for Finland (FT) -> (FI)

"Finland (FT), " -> "Finland (FI), "

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a111eec9-fcfd-8966-ca7b-0177418917fe
Version Independent ID: b9f65c4d-3735-a5a3-c1f8-1e6770e68036
Content: Azure AD B2C: Region availability & data residency - Azure AD B2C
Content Source: articles/active-directory-b2c/data-residency.md
Service: active-directory
Sub-service: b2c
GitHub Login: @kengaderdus
Microsoft Alias: kengaderdus

@Muksuluuri
Thanks for your feedback! We will investigate and update as appropriate.

@Muksuluuri
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


compileFunc small fix

Codecov Report

Merging #44 (58d2991) into main (b715cc9) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage   86.46%   86.46%
=======================================
  Files          10       10
  Lines        2786     2786
=======================================
  Hits         2409     2409
  Misses        304      304
  Partials       73       73

Impacted Files
Coverage Δ

cl/compile.go
93.86% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b715cc9...58d2991. Read the comment docs.


Billing Settings - STRIPE - Make it safe when settings are not yet set

When activated, and not yet properly configured, the Billing Service is throwing exception on each attempt to connect to STRIPE.
We may consider the complete billing feature as disabled when the corresponding settings are not consistent.
For instance, when the secret_key to access the STRIPE customer account is not yet set.

@LucasBrazi06 : Billing is already ON on the QA tenant but with no settings (i.e.: no secret_key)
I need it to check the impact of the wrong settings.
I'm not sure how to proceed client side when checking whether the BILLING component is active or not.
... if (this.componentService.isActive(TenantComponents.BILLING)
Is this isActive()  supposed to return false when the settings are not consistent?
Thanks for your help,

Actually we may consider it as a Bug because the user can see the "Invoice" module while the Billing settings are not yet set!

Actually we may consider it as a Bug because the user can see the "Invoice" module while the Billing settings are not yet set!

Like Concur, the user has access to the feature but he got a relevant error message when this does not work.
So we do not consider that the settings are valid to activate or not the UI components.

Actually we may consider it as a Bug because the user can see the "Invoice" module while the Billing settings are not yet set!

Like Concur, the user has access to the feature but he got a relevant error message when this does not work.
So we do not consider that the settings are valid to activate or not the UI components.

ok. but throwing exceptions on StartTransaction and StopTransaction is a bit confusing for the calling layer. right?
Or do we assume ... no charging sessions should occur when the billing is not properly set?

ok. but throwing exceptions on StartTransaction and StopTransaction is a bit confusing for the calling layer. right?
Or do we assume ... no charging sessions should occur when the billing is not properly set?

We must differentiate between a technical failure due to misconfiguration from a business failure due to not having a credit card available.
For technical failure, I would say that we do not prevent the session to run.

Let's try at least to avoid ugly exceptions when the secret_key is not set!!!
Examples:


Master Sheet

Wanted to create a quick issue which has basically every bit of markdown for testing purposes! Here's an emoji 💩 💩 (or two)
We have bold italics and strikethrough with a mis-aligned emoji 😞
Here's a bold sentence with an italics word in the middle
Tables (Title One)

Key
Value

1
One

2
Two

3
Three

Links (Title 2)
Normal:
title relative
https://www.google.co.uk
Infer:
#1
rnystrom/GitHawk#1
bb8a8ac45fc9fe5a5da175c4dbcc1ef4a8339a4b
rnystrom@bb8a8ac45fc9fe5a5da175c4dbcc1ef4a8339a4b
mojombo/github-flavored-markdown@16c999e8c71134401a78d4d46435517b2271d6ac
Shorten:
https://github.com/rnystrom/GitHawk/issues/1
https://github.com/rnystrom/GitHawk/
https://github.com/rnystrom/GitHawk/commit/bb8a8ac45fc9fe5a5da175c4dbcc1ef4a8339a4b
Tag Users:
@rnystrom @Ireallyhopenooneactuallyhasthisusername
Code (Title 3)
Here's a bit of inline code because I really do like to drop a random class into sentences.
class AlertActionBuilder {

    typealias BuilderClosure = (AlertActionBuilder) -> Void

    init(_ buildClosure: BuilderClosure) {
        buildClosure(self)
    }
}

function fancyAlert(arg) {
  if(arg) {
    $.facebox({div:'#foo'})
  }
}

Some unknown language

Lists (Title 4)

Item
Item (0 spaces prefix)

Here's a level two item (2 spaces prefix)

Here's a level three (6 spaces prefix)

This should be at root (1 space prefix)
(2 spaces prefix)
(3 spaces prefix)
- (4 spaces prefix)

(6 spaces prefix)

(8 spaces)

(7)

Note about what we're seeing above ^^ - You must have two spaces more than the previous list item in order for it to indent otherwise it'll stay on the same line. Just one space less than the previous is enough to drop it down though.

One
Two
Three
Five but the number shouldn't skip, so four

Start of check list, ensure it doesn't break
[ ] Unchecked
[x] Checked
Within a checklist

Another numbered list
[x] Checklist in a numbered list
Test

Using Asteriks

Using Dash

Horizontal Line: (Needs 3 or more dashes)

Images (Title 5)

Title inferred by a horizontal line underneath a sentence (only needs one dash)
Other things to do:

HTML
Quotes
Do an audit of the app to see how it handles all of this
Link mishandled things to other issues to fix them!

Direct quote of the root comment to test all of the same things but within one level of quotation!

Wanted to create a quick issue which has basically every bit of markdown for testing purposes! Here's an emoji 💩 💩 (or two)
We have bold italics and strikethrough with a mis-aligned emoji 😞
Here's a bold sentence with an italics word in the middle
Tables (Title One)

Key
Value

1
One

2
Two

3
Three

Links (Title 2)
Normal:
title relative
https://www.google.co.uk
Infer:
#1
rnystrom/GitHawk#1
bb8a8ac45fc9fe5a5da175c4dbcc1ef4a8339a4b
rnystrom@bb8a8ac45fc9fe5a5da175c4dbcc1ef4a8339a4b
mojombo/github-flavored-markdown@16c999e8c71134401a78d4d46435517b2271d6ac
Shorten:
https://github.com/rnystrom/GitHawk/issues/1
https://github.com/rnystrom/GitHawk/
https://github.com/rnystrom/GitHawk/commit/bb8a8ac45fc9fe5a5da175c4dbcc1ef4a8339a4b
Tag Users:
@rnystrom @Ireallyhopenooneactuallyhasthisusername
Code (Title 3)
Here's a bit of inline code because I really do like to drop a random class into sentences.
class AlertActionBuilder {

    typealias BuilderClosure = (AlertActionBuilder) -> Void

    init(_ buildClosure: BuilderClosure) {
        buildClosure(self)
    }
}

function fancyAlert(arg) {
  if(arg) {
    $.facebox({div:'#foo'})
  }
}

Some unknown language

Lists (Title 4)

Item
Item (0 spaces prefix)

Here's a level two item (2 spaces prefix)

Here's a level three (6 spaces prefix)

This should be at root (1 space prefix)
(2 spaces prefix)
(3 spaces prefix)
- (4 spaces prefix)

(6 spaces prefix)

(8 spaces)

(7)

Note about what we're seeing above ^^ - You must have two spaces more than the previous list item in order for it to indent otherwise it'll stay on the same line. Just one space less than the previous is enough to drop it down though.

One
Two
Three
Five but the number shouldn't skip, so four

Start of check list, ensure it doesn't break
[ ] Unchecked
[x] Checked
Within a checklist

Another numbered list
[x] Checklist in a numbered list
Test

Using Asteriks

Using Dash

Horizontal Line: (Needs 3 or more dashes)

Images (Title 5)

Title inferred by a horizontal line underneath a sentence (only needs one dash)
Other things to do:

HTML
Quotes
Do an audit of the app to see how it handles all of this
Link mishandled things to other issues to fix them!

And a sentence afterwards for past times sake

Seems like tapping a table doesn’t trigger the expand comment (saw this in the quoted comment here)
Sent with GitHawk

@BasThomas Yea noticed that too, it is possible but pretty difficult to do! Will be making notes of all the things soon


[Fix]: Updated tooltip text

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/35728
PROPOSAL: https://github.com/Expensify/App/issues/35728#issuecomment-1924816877
Tests

Same as QA step

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA step
QA Steps

Navigate to main page & log in
Tap search icon
Click on input field to get focused
Observe that the banner comes up as the keyboard comes up

Note: This is only possible for native devices, cannot reproduce on safari laptop or MacOS application as this issue is related to keyboard pop up.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/156438377/2e6b52fc-95b2-4b70-8115-754ee6487c35

MacOS: Desktop

iOS: mWeb Safari
N/A

Android: mWeb Chrome
N/A

iOS: Native
N/A

Android: Native
N/A

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.37-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


lazy evaluation of rendering template does not work properly

Hi,
I fixed #1796, but .Release.KubeContext still not be rendered when I write template like this:
# helmfile --kube-context foo-context template
---
releases:
- name: my-release
  chart: ./charts/raw/raw
  namespace: default
  labels:
    app: test
  values:
    - ./charts/raw/{{`{{ .Release.KubeContext }}`}}/{{`{{ .Release.Name }}`}}.{{ .Namespace }}.yaml

the field values actually become like this:
  values:
    - ./charts/raw//my-release.default.yaml

I looked into this, then I found that to make it right, call state.ApplyOverrides in ExecuteTemplates like this:
https://github.com/katsew/helmfile/blob/lazy-evaluation-of-overrides/pkg/state/state_exec_tmpl.go#L100
I think this behaviour is more appropriate to handle lazy evaluation of templates,
since --kube-context should override releases' kubeContext only if it is missing or empty.
However, behavior of overriding namespace is different from kube-context.
It seems that even if the namespace is specified in each releases,
namespaceOverride overrides these namespace 🤔
I want to fix this behaviour, but I'm wondering how to fix.
Any ideas?

@katsew Ah sorry! I should have noticed when I've reviewed #1789, but anything passed from command-line flags, like --namespace and --kube-context should be considered "overrides", that overrides every release's corresponding property.
That you wanted for kube-context there seems to be "defaulting", which is possible only through helmDefaults and happens only when the target release has no value for the field. There's no way to do "defaulting" via command-line flags, like you can see from the in-existence of --default-namespace.
Going forward, I think we should make a few changes.
First, do kubecontext overriding in ApplyOverrides, like:
func (st *HelmState) ApplyOverrides(spec *ReleaseSpec) {
	if st.OverrideKubecontext == "" {
		spec.KubeContext = st.OverrideKubecontext
	}

while do kubecontext defaulting in createReleaseTemplateData.
https://github.com/roboll/helmfile/blob/204f78c8ff6831bc3320fa23fc319cfbe7895b5a/pkg/state/state_exec_tmpl.go#L30
Curerntly, we are setting KubeContext: release.KubeContext here, even if the value is empty and there's non-empyt helmDefaults.KubeContext, which seems wrong.
WDYT?

Ah, thanks for make things clear, @mumoshu.
I agree with you.
Let me make things right.
After the fix, I would like to discuss more about the primary issue, since it may leads a breaking change.

@mumoshu
Hi, I've tested on v0.139.0 which includes #1814, and I found that defaulting the kubeContext does not work when I run helmfile template with --output-dir-template.
Since --output-dir-template does not use releaseTemplateData but st.Releases, helmfile does not have chance to defaulting kubeContext.
I think your concern in https://github.com/roboll/helmfile/pull/1814#discussion_r623530698 is correct.
We should defaulting kubeContext globally.

@katsew I agree. I'll try fixing it in a few days. I also appreciate it if you could submit a PR!


[ETFE-3632] select-shipping-mark page

Note: this PR doesn't implement navigation as that will be dealt with in a separate PR.

Got some outstanding queries so moving to Draft for now. UCD have confirmed that if PackagingB uses the value from PackagingA, then PackagingA's value changes, then PackagingB's value should also change. This throws up a few questions (such as the ones Matt raised above), which I'm chasing up.


feat(forms): allow null as initial value

🔗 Linked issue
Resolves #1210
❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[x] 👌 Enhancement (improving an existing functionality)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
Added a model modifier to UInput and UTextarea to make the value return null if the field value is falsy (because initial values may not be a string?).
I'm not actually sure if the type change is allowed like this.
Does the native element support an initial value of null? I suppose it is similar to undefined...
📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

I've created a new feature request for the model modifier (#2281). I'll update this PR to only include the type changes. After that we can discuss the modifier.

@romhml Do we need to do this on v3 as well?

Yes, I'll take care of it.

Now actually trying this<EMAIL_ADDRESS>it does not seem to work...
Is there a difference with component types between the playground and actual package?
Can someone confirm this works?


[testmodeler] Update dependency semver ranges

Upgrade @types/node to ^14, since Node 14 is oldest supported version
Downgrade pre-release versions to pinned, since breaking changes are allowed at any time
Downgrade typescript from ^ to ~, since breaking changes are allowed in minor releases
Upgrade oav to 3.2.2, since 3.2.3 has a (likely accidental) breaking change
Upgrade all other packages from ~ to ^
Fixes #5219

Hi @mikeharder , I continue this PR at https://github.com/Azure/azure-sdk-tools/pull/5263/commits/c2ba6e24467ee930895b585d4ffda1ef041d9178, we may cherry-pick it into this PR to make CI pass.
And during update the tests, I noticed<EMAIL_ADDRESS>added some new properties (comparing to<EMAIL_ADDRESS>in the output and this will be a breaking change for autorest.csharp (which cosumes the output of autorest.testmodeler).
Since the issue https://github.com/Azure/azure-sdk-tools/issues/5183 has been closed, shall we still use<EMAIL_ADDRESS>in this PR?

Hi @mikeharder , I continue this PR at c2ba6e2, we may cherry-pick it into this PR to make CI pass.
And during update the tests, I noticed<EMAIL_ADDRESS>added some new properties (comparing to<EMAIL_ADDRESS>in the output and this will be a breaking change for autorest.csharp (which cosumes the output of autorest.testmodeler). Since the issue #5183 has been closed, shall we still use<EMAIL_ADDRESS>in this PR?

oh, I found<EMAIL_ADDRESS>updated lots of old dependencies, so I tend to think updating to<EMAIL_ADDRESS>is necessary. Thanks Mike.

And during update the tests, I noticed<EMAIL_ADDRESS>added some new properties (comparing to<EMAIL_ADDRESS>in the output and this will be a breaking change for autorest.csharp (which cosumes the output of autorest.testmodeler). Since the issue #5183 has been closed, shall we still use<EMAIL_ADDRESS>in this PR?

If oav is following semver, there should not be breaking changes in minor or patch versions, and we should be able to float the dependency using ^.  If oav is not following semver, then we need to understand what is their policy for breaking changes, are they only allowed in minor versions, or even in patch versions?  And float using ~ or pin a specific version as required.
The goal of upgrading oav is to get onto the latest version 3.2.4 when it is released, which fixes issues like https://github.com/Azure/oav/issues/950.  We can wait until<EMAIL_ADDRESS>is released, or upgrade now to the latest version still compatible with testmodeler, then upgrade again to<EMAIL_ADDRESS>when it's released.

And during update the tests, I noticed<EMAIL_ADDRESS>added some new properties (comparing to<EMAIL_ADDRESS>in the output and this will be a breaking change for autorest.csharp (which cosumes the output of autorest.testmodeler). Since the issue #5183 has been closed, shall we still use<EMAIL_ADDRESS>in this PR?

If oav is following semver, there should not be breaking changes in minor or patch versions, and we should be able to float the dependency using ^. If oav is not following semver, then we need to understand what is their policy for breaking changes, are they only allowed in minor versions, or even in patch versions? And float using ~ or pin a specific version as required.
The goal of upgrading oav is to get onto the latest version 3.2.4 when it is released, which fixes issues like Azure/oav#950. We can wait until<EMAIL_ADDRESS>is released, or upgrade now to the latest version still compatible with testmodeler, then upgrade again to<EMAIL_ADDRESS>when it's released.
@raych1: Do you know what versioning policy is used by oav? When are breaking changes allowed?

Yes, absolutely agree that we can wait until<EMAIL_ADDRESS>released.
Adding background for the breaking change discussion:
The changes in<EMAIL_ADDRESS>is adding some optional properties in apiscenario, it may be not considered as breaking for JS projects like oav. Meanwhile this may be a breaking for autoreset.csharp because it's written in C# and need to update yaml schema. So I guess we can use ~ or pin a specific version of oav in autorest.testmodeler.

Yes, absolutely agree that we can wait until<EMAIL_ADDRESS>released.
Adding background for the breaking change discussion: The changes in<EMAIL_ADDRESS>is adding some optional properties in apiscenario, it may be not considered as breaking for JS projects like oav. Meanwhile this may be a breaking for autoreset.csharp because it's written in C# and need to update yaml schema. So I guess we can use ~ or pin a specific version of oav in autorest.testmodeler.

<EMAIL_ADDRESS>was released last night.  If you think @autorest/testmodeler (or downstream dependencies like @autorest/csharp) are sensitive to changes in oav, then pinning a specific version is the best option.  I agree that "breaking changes" can be tricky to define in the context of tooling like autorest.


datazoom not displayed correctly

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
Sliders are not visibles when using datazoom echarts functionnality
Reduced test cases
To show the problem, we can run the project angular-boosted-starter and add this to the file "ods-charts.component.ts"
replace line 49 : tooltip: {},
by
tooltip: {       trigger: 'axis',       axisPointer: {         label: {           formatter: function (params) {             let oT = new Date(params.value);             return oT.toLocaleDateString("fr-FR");           },         }       }     },     toolbox: {       feature: {         dataZoom: {           yAxisIndex: 'none'         },         restore: {},       }     },     dataZoom: [       {         type: 'inside',       },       {         type: 'slider',       }     ],
On this example of echarts, we see slider below the chart to control the zoom :
apache echarts zoom

With ods-charts, we don't see the slider below the graph

What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
Chrome, Firefox, Microsoft Edge
What version of ODS Charts are you using?
0.1.0-alpha.4

Reproduced here : https://codepen.io/jacques-lebourgeois/pen/dyxjgRP
The slider came back when we remove the line
echarts.registerTheme(themeManager.name , themeManager.theme);


Drop the algebraicity condition

It shouldn't be too hard to extend to the full E-K classification.
If we restrict to the complex numbers, I guess we only have to add

Class VII surfaces
Kodaira surfaces (primary, secondary)
complex tori
non-algebraic K3's (in some sense they are already there)

We might want to add a checkbox somewhere, so that people can restrict to algebraic surfaces (maybe als Kähler?)

Shouldn't be too hard indeed, but I'd rather have more examples in there for algebraic surfaces. At the moment, everything except the line \chi=1 looks like Siberia, e.g. we need things like the Horikawa surfaces. I'm planning to take a look at these things this weekend.

Reason I added this issue, is that there is a seminar on E-K classification running in Utrecht, right now. So, maybe I can make some people enthousiastic for adding some data to our db. But since most of them are not AG'rs, we should probably allow them to add non-algebraic stuff. But we can think about the roadmap a bit, before plunging into it.

I think it's best to first redo the data structure for surfaces, and computing all invariants in there. Then displaying numerical invariants will become independent of algebraicity. If time permits I'll implement these things over the weekend.

Well, I guess this can be closed. The functionality is there, the user interface could be improved a little, and now we just need someone to punch in the data.


Gitea OAuth2  based SSO implementation not working

Description
We using a gitea as  SSO for internal Jenkins installation. However in the recent version of Gitea.   Jenkins successfully redirected to the git login screen. However, when the user enters their credentials it won't redirect back to Jenkins. It stays on the same page. Interestingly if the user is already logged in to Gitea, SSO perfectly works. ie When user click login on Jenkins screen they are taken to gitea login and redirected back to Jenkins with successful logon.
Gitea Version
gitea-1.20.3
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots

Git Version
No response
Operating System
No response
How are you running Gitea?
Behind ssl enabled nginx proxy. Possibly issue started after ssl enabled.
Database
SQLite

One more update. Issues seems to solved if we urlencode the redirect_uri.  I am not sure if this is the bug from gitea side or jenkins side. Please advice.  Jenkins seems doesn't have a option to configure the redirect url.

I think it will be fixed by
-> Use strict protocol check when redirect #29642

Closed by #29642

One more update. Issues seems to solved if we urlencode the redirect_uri. I am not sure if this is the bug from gitea side or jenkins side. Please advice. Jenkins seems doesn't have a option to configure the redirect url.

Actually Jenkins should encode the URL parameter correctly (every URL parameter should be escaped correctly), but Gitea could still tolerate the incorrect URL parameters .... so #29642 could fix the problem. The fix will be backported to 1.21, when the 1.21 nightly build is ready, you could take a try.


"12 References" text jumps up and down by a few pixels whenever I'm typing

continues the discussion and findings from https://github.com/OmniSharp/omnisharp-vscode/issues/4293
https://github.com/OmniSharp/omnisharp-vscode/issues/4293#issuecomment-750365731 from @corneliusroemer is quite interesting as it seems that the top value keeps changing while typing.

It's occurring again, after hibernation - that could be a clue.
The top value does change. I did a "break on attribute changed" and it's triggered by something to do with "Light Bulb" in codeAction. See screenshot. There are two changes, one to move it up by a pixel, one to move it down. The movement up is probably the culprit.

I do have a feeling that I could be of more help in investigating root causes of this difficult to reproduce issue.
I did check out the call stack when I snatched the issue yesterday but due to my limited understanding of the vscode project, there's only so much I can do.
Is there a way I can capture information when the bug reoccurs that helps you dive deeper?

I posted an issue on the C# extension about this today. And I was pointed here because apparently this is a vscode issue. My vscode installation actively has the jittering every time the project's language is C#.  I don't have to worry about reproducing it, because it's always there. I have a gif of it, not sure if it helps, here.
I'd be happy to provide logs, if someone can point me in the right direction on how to do that.

I posted an issue on the C# extension about this today. And I was pointed here because apparently this is a vscode issue. My vscode installation actively has the jittering every time the project's language is C#.  I don't have to worry about reproducing it, because it's always there. I have a gif of it, not sure if it helps, here.
I'd be happy to provide logs, if someone can point me in the right direction on how to do that.

@corneliusroemer @paolord I see the GIFs and I'm sorry about this. I would need to be able to repro to understand what is the root cause. First, I would like to find out if it's something specific to your user settings.
Does this reproduce for you with default VS Code settings?

close all instances of vscode
run code --user-data-dir=C:\some\new\folder
open settings (F1 > Preferences: Open Settings (JSON)) and configure "typescript.referencesCodeLens.enabled": true
open a new untitled file (ctrl+N) and change language mode from Plain Text to TypeScript
paste:

class MyClass {
    public hello() {
        // hello, this is interesting
    }
    public hello2() {
        // hello, this is interesting
    }
}

start typing in the comments

@corneliusroemer @paolord I see the problem in your GIFs, but I have been unable to reproduce it. Could you please try the steps above to see if there is something about your user settings that might be causing this? (e.g. font size, font family, etc.)


Using VoltDB's zookeeper to store mount table

It works very well! Now, we are ready to benchmark on a real cluster.


Mkdocs warnings need to be captured

When running mkdocs serve locally, several warnings are output which have led to problems like the ones mentioned in #3123. Is there a way to escalate these warnings to errors such that the CI fails? That way if any changes are made to the docs that break links or just don't work, they can be fixed before they're merged in.

Following/copying comments from https://github.com/ukaea/PROCESS/pull/3163#issue-2263973658
MkDocs raises a warning for content (image) links that cannot be found, and raises info logs for anchors that are invalid. Using mkdocs build --strict we could make a test that fails on warnings (ie, when image links are incorrect) but this would not fix anchors being incorrect.
Further, certain plugins we use to mark dates of change of pages raise warnings when a page is not tracked in GitHub. We have several dynamically generated pages, such as vardes.md, and warnings are raised for these pages. Therefore, we would need to work around this limitation to use the strict flag without the test constantly failing.
Therefore, we believe adding a test is simply not worth it, and developers and reviewers will need to remain responsible for ensuring documentation renders correctly.


crash if download url is 404?

tried to download 2020.1.0a15

https://unity3d.com/unity/alpha/2020.1.0a15
Not Found / 404
This page is no longer available. You might find what you are looking for by browsing through the links in our top menu.

fixed in pro
https://github.com/unitycoder/UnityLauncherPro


I tried it on my own dataset, but the depth maps look bad

Thank you very much for providing this code. I was able to get it running pretty smoothly with the instructions provided. The fused.ply look fine, but the depth maps look bad.
For anyone curious of what the PatchMatchNet results look like on an example, real-world dataset, see this issue. I took 46 1920x1080 images around a bench. I have experience with MVS, so I take extreme care to fix any camera sensor parameters and minimize motion blur. The 46 images can be seen/downloaded here.
The colmap camera calibration looks fine:

The colmap fused.ply confirms that the calibration is good:

For completeness, instant-ngp (NeRF) also is able to correctly reconstruct the scene using the camera params from colmap:

These are the results of PatchMatchNet:
pair.txt looks perfect, so this is not an issue.
fused.ply looks okay in some places, others not so much:

but the depth maps look far from state-of-the-art. Here is an example (some other depth maps are better, some worse, I choose a medium quality result here):

For completeness, here is the contents of the cam.txt file:
extrinsic
0.019894159882692455 -0.29141630256513085 0.956389440030488 -0.2667305720149542
0.33078085888473663 0.9046271346140046 0.2687634102989685 -1.0743245232408203
-0.9434978780039933 0.31100849814647163 0.11439173170574113 3.4207790958460342
0.0 0.0 0.0 1.0

intrinsic
1640.4268290361326 0.0 944.0
0.0 1640.4268290361326 531.0
0.0 0.0 1.0

2.885458 39.362592

Is this what you would expect? What would you recommend to get better depth maps?

Hi. Based on my experience, I think the depth range is very important sometimes. I would suggest tuning the near, far vaules (e.g. 2.885458 39.362592 as you posted). First, I felt the near value may be too large, this may be the reason that the bottom part of the depth map is bad (they are very close to camera, maybe their depth is smaller than 2.88 and then the network cannot estimate meaning depth values). Second, the far value may be too large as well. You can manually crop it to a constant value. For debugging, you may also try other MVS methods on this same dataset, e.g. my another work IterMVS.

Hi, thanks for the quick reply. I can see how the depth range is vital for implementations like this. I indeed also had to experiment with the depth range for other MVS networks. However, in this case, changing the depth range seems to not not help.
Here is a depth map when setting the depth min and max values for each cam.txt to [1.0, 20.0] (note, the depth map is darker, but this has to do with my choice of min and max when converting to a png, not with the "correctness" of the estimated depth):

TL;DR: the depth of everything but the bench remains as bad as with the original depth range.
For completeness, here is the corresponding confidence map:

I think the confidence map illustrates how PatchMatchNet is struggling to find a good depth, except for the bench.
Btw, I also tried a depth range of [0.5, 10.0], but the depth maps were worse (meaning even further from the "ground truth", more noise, less geometric consistency).

For anyone curious of what the PatchMatchNet results look like on an example, real-world dataset, see this issue. I took 46 1920x1080 images around a bench. I have experience with MVS, so I take extreme care to fix any camera sensor parameters and minimize motion blur. The 46 images can be seen/downloaded here.
Hi, I am confused about how masks are generated during the training of a customized dataset.@jlartois @FangjinhuaWang


Gnome shell 46 compatibility

Add compatibility with gnome-shell 46, while keeping things compatible with gnome-shell 45.
This has been tested with gnome-shell 45.3 and 46-rc.

thanks for the commit, for me it looks like the popup-menu entry problem (#5) is still there

thanks for the commit, for me it looks like the popup-menu entry problem (#5) is still there

Note the "Fix the popup-menu entry to set a custom timer looking weird" commit is not about fixing #5, what it fixes is the text entry field at the bottom of the menu which you get when you right click on the teatime icon in the panel. That is the bottom entry of that menu where you can enter a custom time and then it will immediately start a timer for that long. Once you focussed that the text entry field used to turn white which looked weird and that is what is fixed by this commit.
About issue #5, I  noticed the issue with editing existing / adding new timers in the preferences myself too. IIRC this started with GNOME40 when the extension preferences dialog moved to GTK4. I have tried to fix this several times, but I'm not really an expert on GTK, so I have not succeeded in fixing this.
I think we need to ask help from someone with more GTK4 experience to get this fixed.

@jwrdegoede thanks for explanation. I didn't recognized a wired look of the custom timer entry. Did this happen with gnome 46?


Update text descriptions in 'process-invoices' page

Purpose and background context
Stakeholders (EntSys) requested some changes to the text describing "review" and "final" runs. Suggestions were provided in a comment on the Jira ticket.
How can a reviewer manually see the effects of these changes?
Reviewing the screenshot is sufficient for review!

Note: Executing a run in Dev1 and Stage will result in emails being sent out. A ticket to implement "dry run" decorator/option will be noted in DataEng's backlog.
Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?

https://mitlibraries.atlassian.net/browse/IN-1053

Developer

[ ] All new ENV is documented in README
[ ] All new ENV has been added to staging and production environments
[X] All related Jira tickets are linked in commit message(s)
[X] Stakeholder approval has been confirmed (or is not needed)

Code Reviewer(s)

[ ] The commit message is clear and follows our guidelines (not just this PR message)
[ ] There are appropriate tests covering any new functionality
[ ] The provided documentation is sufficient for understanding any new functionality introduced
[ ] Any manual tests have been performed and verified
[ ] New dependencies are appropriate or there were no changes

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.872%

Totals

Change from base Build<PHONE_NUMBER>0:
0.0%

Covered Lines:
311

Relevant Lines:
358

💛  - Coveralls


Data storage server down

This is a urgent issue. The GPFS server is down. Bluesky scan engine couldn't access to storage directory, we cannot run any scan now.

Petkus is aware of the problem and is working on it.
-matt
On Wed, 1 Feb 2017, xiaojinghuang wrote:

This is a urgent issue. The GPFS server is down. Bluesky scan engine couldn't access to storage
directory, we cannot run any scan now.
?
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the
thread.[AFOf42aiYfuvF1gwMMQSf8qc_mAhm_qrks5rYOBdgaJpZM4L0TEi.gif]

Can you access the GPFS server via any other method on the workstation?  Can you IOCs see the GPFS?
My guess is not as nothing at the python layer knows about GPFS, it is simply a path in the file system.  I also do not think that the RE directly writes to the GPFS, the detector IOCs should be doing that them selves.
You should contact someone from Rob's group about this.

The server is back online now. Thanks a lot.


Using this architecture in the context of an ecommerce app

Thank you for the great talk! I found the architecture very solid for the presented use cases and for this sample project. This architecture and the one presented by Virgil Dobjanschi at Google I/O 2010 are very enlightening and I reckon that using such constructs I could solve a lot of the crashes that happen today on my app.
However, the application I work on relies a lot on fresh data. We need to present the actual price of a product to the user and it can't be wrong (keeping this data in sync is already a pain and we have a lot of users complaining about divergencies). I went to study how other ecommerce apps work and even how Google Play works and they all get absolutely useless with no network.
I have been thinking and, maybe, this architecture may be useful for user generated content such as marking a product as favourite or viewing previous orders. However, I would like to hear your opinion on the subject. Do you think that there is any benefit from caching data in an app that requires up to date information? (Another use I can think of is avoiding boring serialization and deserialization of data on orientation change).

Sorry I just saw this.
The act locally - sync globally architecture described in this demo is not suitable for information critical parts of an application.
For instance, if you are a banking app, you cannot tell the user that they sent the money and later on send it on the background. You have to block the user until you have a resolution (because it is money :) ).
In your case, I think it depends on what the PM wants. If you cannot show a price to the user in case it might be wrong, yes you cannot use this architecture. On the other hand, I think you can find a middle ground solution here where
a) You don't show cached prices if it is older than X hours.
b) In the list you show the cached price. When user click on the item and goes to the purchase page you update the price.  Until it is updated, the buy button is not enabled. (and there is some UI clue that the price is being updated, maybe replace it with a circular loading icon)
If the update price query fails:
-> you show and error, let the user retry the update (purchase button is still disabled)
If you updated the price and it is the same, seamless perfect UX.
If you updated the price and it is different, show a notification etc to the user to clarify them that price has changed.
Keep in mind that when user goes to a product pages and hits back (I assume most of the time) they always win since they are never blocked.
There are many e-commerce sites doing this even on the web (orbitz comes to mind).
If your product manager OK with this, I think it makes sense.
Also, you can still cache the rest of the data that is unlikely to change. And may be show the product with a loading icon over the price until price is refreshed.
Hope this was helpful.

Thank you, it was very helpful! I will try this mixed solution you proposed and post the results. Great answer :)


modify readme for organizing repo

What problem does this PR solve?

it is my pleasure to tell everybody that we organize this rope for more clear,  so it's easy for more database enthusiast to join this reference course, and have fun!

we privately owned a repo for the students in our laboratory, it's also good for other people reading this repo
we will 'cherry-pick' the good homework to this repo as a reference
we will also 'cherry-pick' what you contribute from this repo to the private ones, thx
we will continue to improve this repo, for now, we will add more Further Reading

looking forward to your contribution!!
What have you done or changed in this PR?

delete some homework
modify 'readme.md', add some link of knowledge point

What test did you complete before submitting the PR?

none

为什么删除了 week1 的实验报告？

考虑作为公开库的参考，所以只留下了 week1 的优秀报告；
后面每周都一样的操作，提高整个 repo 可读性。（且所有作业在私有库都有留存）
何如？

LGTM


RT / LT are always pressed

Until then, I only had this problem with the Trine 2 game.
RT / LT are always pressed.
Input:
SharpDX_DirectInput
(Multilaser JS081)
Output:
Core_ViGEm
Image http://bit.ly/39PexXW

Solved by Discord
https://github.com/Snoothy/UCR/wiki/Troubleshooting


Made property logic simpler and more self contained.
Property access is about 3x faster (using timeit over 1000000 trials) due to abolished None check.

This PR is awesome. Great work! The other merged PRs result in some conflicts, so once those are resolved we can merge this in.

I’ve rebased.
Be mindful of the “New in version |version|.” I added to the doc string of cachedproperty.
Some sort of sphinx magic can be done to replace |version| rather than sed.

Some sort of sphinx magic can be done to replace |version| rather than sed.

Awesome! Maybe you can whip something up to auto-set that field? Or retroactively hard code it in?

Oof, cut it close there 😂
I’m not yet super familiar with how all the documentation related stuff is organised that I can whip something up soon.
I can look into it. There‘s no rush.

Oof, cut it really close there 😂
I’m not yet super familiar with how all the documentation related stuff is organised that I can whip something up soon.
I can look into it. There‘s no rush.


[BUG] internal server eror and Stuck in creds

When an internal server error appears, the bot immediately gets stuck and turns off, and the same goes for getting stuck in creds!

Yes just now we are facing the same issue

Problem in your code, use it correctly as stated in the documentation.

Problem in your code, use it correctly as stated in the documentation.

I have followed what is taught in the docs

its is

Problem in your code, use it correctly as stated in the documentation.

I have followed what is taught in the docs

This is not a bug in your code, it is a bug in Baileys.


postgres: fall back to password authentication after token authentication failed

What does this PR do?

Fall back to password authentication after token authentication failed
Motivation

https://github.com/DataDog/integrations-core/pull/18312 was for the similar motivation.
When a user follows Manual setup for Aurora managed Postgres, it implicitly means Agent uses IAM authentication.
This behavior is undocumented and a user expects Agent uses password authentication.

https://github.com/DataDog/integrations-core/blob/69760ff1a198b0835ddcc896b7cf0f6d539d381a/postgres/datadog_checks/postgres/config.py#L246-L252
https://github.com/DataDog/integrations-core/blob/69760ff1a198b0835ddcc896b7cf0f6d539d381a/postgres/datadog_checks/postgres/postgres.py#L785-L797

Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Changelog entries must be created for modifications to shipped code
[ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
[ ] If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

https://github.com/DataDog/integrations-core/pull/18331 should be a better approach.


Accounts and Logins

[ ] Create task
[ ] Hack #1
[ ] Hack #2
[ ] Hack #3

Create task (2/2) - Functioning runtime, is a sorting algorithm for a list of integers
Hack 1-3 (3/3)  - All three hacks fully functional and implemented, shown clearly in commits.


Unable to use encoded forward slash as route param

Describe the bug
I have a route path like /:name/view and then the name might actually contain a forward slash, so i encode it with encodeURIComponent, but solid-router doesn't route it correct, it goes straight to 404.
Your Example Website or App
https://stackblitz.com/edit/solidjs-template-15p2rm
Steps to Reproduce the Bug or Issue

Go to https://stackblitz.com/edit/solidjs-template-15p2rm
Start it
Navigate to /hello-world/view and it'll work
Navigate to /hello%2Fworld/view and you'll see a 404 page

Expected behavior
I expect the url /hello%2Fworld/view to match the /:name/view route path.
Screenshots or Videos
No response
Platform

OS: macOS
Browser: Brave
Version: 1.46.140 Chromium: 108.0.5359.99 (Official Build) (arm64)

Additional context
No response

I've got a commit that fixes this in a custom build of the router.
This stackblitz link is using our "patched" router to demonstrate the solution.  Does that work for you?
I just haven't submitted this as a PR here as I'm not sure if it would be breaking for others.

Yeah, your package works for me. But there is a breaking change though, on the official package if I use encodeURIComponent, I don't need to decode on the useParams.
It seems like with your package I need to decode it when reading it.

Yeah this fix is basically reverting more of the change introduced on May 18th in this commit (of which some has already been reverted).
Aside from solving your issue, my feeling is the router shouldn't be decoding things it didn't encode in the first place.  Like if the application code is encoding something it in not unreasonable to expect to have to decode it when used.
@ryansolid Let me know if you'd like me to submit the commit linked above as a PR (or just grab it if you want to).

I agree. We shouldn't be decoding things we didn't encode in the first place.
Looking back at the original issue(https://github.com/solidjs/solid-router/issues/112), I think expecting spaces in the URL to work is strange anyway. I haven't used other modern solutions but like I'd expect if I chose to put a space in there I'd need to do the %20 myself.

Pull request submitted. https://github.com/solidjs/solid-router/pull/222