Extract duplicate type to types file

Changes Proposed

Check List

[x] The title of my pull request is a short description of the changes
[ ] This PR relates to some issue:
[x] I have documented the changes made (if applicable)
[ ] I have covered the changes with unit tests

The exact same type was inside installReleaseChartModal and installRepoChartModal - extracted into the types file

Codecov Report
Patch and project coverage have no change.

Comparison is base (7f89fed) 30.04% compared to head (cac0d30) 30.04%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@                Coverage Diff                 @@
##           helm-dashboard-v2     #453   +/-   ##
==================================================
  Coverage              30.04%   30.04%
==================================================
  Files                     10       10
  Lines                   1348     1348
==================================================
  Hits                     405      405
  Misses                   902      902
  Partials                  41       41

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Laravel 7 Support

Can you add Laravel 7 Support?

I have forked this package and published to packagist as xint0/laravel-optimistic-locking.
You can install it using composer:
composer require xint0/laravel-optimistic-locking

Development is hosted at gitlab.com/xint0/laravel-optimistic-locking.

I just published an improvement over this package at https://github.com/qtsolv/laravel-locking please see and report any issues/feddback you may have.


Update CONTRIBUTING.md

Things to include:-

How to contribute to the repo
Use of necessary screenshots
Proper use of links, easy to read and follow

Hi Mohit, I'm Zainab and I'd love to contribute to this project and hopefully get it assigned to me. I'm a beginner in open-source and would love to get started with documentation.
thank you.

update the readme file and modify the contributing.md file

@m0hit-kumar Kindly merge my pull request. thank you.

@m0hit-kumar Kindly merge my pull request. thank you.

see you have a conflict with the main branch and also one change is requested


Add ex

Motivation for this change
This adds some (all?) versions of the ex editor, the predecessor for vi.
Things done

[ ] Tested using sandboxing
(nix.useChroot on NixOS,
or option build-use-chroot in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Please suggest enhancements to the codebase.

Is there a specific reason we need all those versions?

@fpletz No, I added them just for historic reasons.

I think it is unlikely for us to maintain multiple ex expressions in nixpkgs. How do you feel about us only having one?

Well, then I'll remove them and only add the latest version. I would, though, keep the commits for them around, if you don't mind.

Trimming down to just one never happenned?

I don't even know which one to keep, so I'll close this unmerged I guess.


Implement the DSL for commentFilePath to fix #514

@samrocketman, had some issues with the other PR.  This one has the collection of changes and is up to date with master.

Maybe make a seed job and have it try to process a dsl with this option on?

I don't have time to work on testing this at the moment since I'm preparing for Jenkins World next week where I'm presenting.

Yeah, the job dsl testing happens manually at this time.

@samrocketman
Merging is blocked
Merging can be performed automatically with 1 approving review.
I pushed the README update requested by @Kentalot.

@samrocketman Any updates on this one? 👍

Not available for coding.  Traveling on vacation at the moment.

I will be back home Oct 17th.  If you see no action in the week following that date feel free to ping me again to remind me.

@bjoernhaeuser feel free to merge LGTM

@samrocketman thanks for approving.

Awesome now that this is merged, any way we could get https://github.com/jenkinsci/ghprb-plugin/pull/682 merged? :)

@bjoernhaeuser I tested this on my DSL job and it seems to not work as it somehow does not seem to find commentFilePath method that takes in a closure.  Not sure what's happening.  Your #664 update also fails with a similar error.  I checked to make sure i have the latest ghprb plugin version (1.42.0). commitStatus and buildStatus extensions work just fine.  I don't see anything wrong with your code and the only difference I could see between the working ones (commitStatus and buildStatus) and the non-working ones (commentFilePath and cancelBuildsOnUpdate) is the latter ones have their methods public.  I doubt that's the issue, but I couldn't see any other difference.
Here's the error:
Processing DSL script PipelineJob.groovy
ERROR: (PullRequestTrigger.groovy, line 110) No signature of method: javaposse.jobdsl.dsl.helpers.triggers.TriggerContext.cancelBuildsOnUpdate() is applicable for argument types: (jobs.utils.builders.pipelines.scripts.PullRequestTrigger$_addTriggerTo_closure1$_closure2$_closure3$_closure6) values: [jobs.utils.builders.pipelines.scripts.PullRequestTrigger$_addTriggerTo_closure1$_closure2$_closure3$_closure6@6052ddc2]

and the code snippet:
extensions {
                    commitStatus {
                        context(gitStatus.toString())
                        triggeredStatus('Triggering Jenkins...')
                        startedStatus("Running $gitStatus on Jenkins...")
                        addTestResults(true)
                        completedStatus('SUCCESS', 'Tests passed')
                        completedStatus('FAILURE', 'Tests failed')
                        completedStatus('PENDING', 'Testing in progress...')
                        completedStatus('ERROR', 'Pipeline crashed')
                    }
                    buildStatus {
                        completedStatus('SUCCESS', successMessage)
                        completedStatus('FAILURE', failureMessage)
                        completedStatus('ERROR',
                                'There was an error in the infrastructure, please contact the Jenkins maintainer.')
                    }
                    cancelBuildsOnUpdate {
                        overrideGlobal(true)
                    }
                    commentFilePath {
                            commentFilePath(extraCommentFilePath)
                    }
                }


Fix provider to be found by AutoService

r: @damondouglas

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

only license pull failed in PreCommit


need shortcut for container log

can we have a command to check container log ?

👍

Basic feature added in fe2d054


Add point to a PDF

Hello
I'm currently developing an application on Android with AndroidPDFViewer :
I want to create a functionality, when the user touch the screen, it put a point on the PDF at this location. After I want to measure the distance between 2 points but it's an other problem.
I don't understand how to do this functionality, put a point on PDF. I found this : https://github.com/barteksc/AndroidPdfViewer/issues/554
So it's possible but how ? I don't get it.
I suppose I need to create a bitmap.
Currently, I have this :
`override fun onCreate(savedInstanceState: Bundle?) {
    super.onCreate(savedInstanceState)
    setContentView(R.layout.activity_pdf)
    val pdfName = intent.getStringExtra("pdfName")
    openPdf(pdfName)

    mLayout = findViewById(R.id.framelayout);
    l = findViewById<RelativeLayout>(R.id.rl)
    child = l?.getChildAt(1)!!

    child?.isEnabled = false

    var mesureButton = findViewById<ImageButton>(R.id.mesureButton)
    mesureButton.setOnClickListener{
        child?.isEnabled = true
        val bitmap: Bitmap= Bitmap.createBitmap(child?.width!!, child?.height!!, Bitmap.Config.ARGB_8888)
        val canvas: Canvas = Canvas(bitmap)
        var shapeDrawable: ShapeDrawable
        shapeDrawable = ShapeDrawable(RectShape())
        shapeDrawable.setBounds(100, 100, 200, 200)
        shapeDrawable.paint.color = Color.parseColor("#009944")
        shapeDrawable.draw(canvas)
        (child as ImageView)?.setImageBitmap(bitmap)
        shapeDrawable = ShapeDrawable(OvalShape())
        shapeDrawable.setBounds(600, 600, 650, 650)
        shapeDrawable.paint.color = Color.parseColor("#009944")
        shapeDrawable.draw(canvas)
        (child as ImageView)?.setImageBitmap(bitmap)
        child?.isEnabled = false

    }

fun openPdf(pdfName: String) {
    pdf = findViewById(R.id.pdf) as PDFView
    val f = File(pdfName)
    pdf?.fromFile(f)!!.load()`

Here, when i push my button , I draw 2 shapes for test but the shape doesn't stay at the right position of the pdf. When I scroll, it moves.
I spend my week on it and search but I don't get it.
And I can't use https://github.com/barteksc/PdfiumAndroid to have a image because when I zoom on it, it's blurry.
I'm desperate ahah.
Thanks for your time.

Very simply, I use to create a watermark which remains static on the page when scrolled,
When they touch you just place the marks on the screen in the method below and it will remain on the page then a case of getting the angle and distance to the other marker which from my gaming development is a large calculation to get the angle... think it was a quadrilateral equasion..
Happy programming you have a way to go yet to implement the measuring...
public void onLayerDrawn(Canvas canvas, float pageWidth, float pageHeight, int displayedPage) {

Thanks for your awnser
How do you access to this function ? I can't have it in my code.

I work with the source,
This will make you smile, just copy paste into your pdfviewer code and your good to start the mission.
.onDrawAll(new OnDrawListener() {
@Override
public void onLayerDrawn(Canvas canvas, float pageWidth, float pageHeight, int displayedPage) {
}

Do you have some example. I've got errors with this code :
pdf?.fromFile(f)!!.onDrawAll(OnDrawListener(){             override fun onLayerDrawn(canvas: Canvas, pageWidth: Float, pageHeight: Float, displayedPage: Int){             }         })
or do I have to implements the interface at the beggining and do that :
`class PdfActivity : AppCompatActivity(), OnDrawListener {
override fun onLayerDrawn(canvas: Canvas?, pageWidth: Float, pageHeight: Float, displayedPage: Int) {
    TODO("not implemented") //To change body of created functions use File | Settings | File Templates.
}`

I code in Kotlin by the way, but it's same in Java

inside the onDraw use a canvas.drawBitmap( which bitmap you want and where you want it, the layers are redrawn and the image should stay in place but remember you only need one draw otherwise i guess it will move you will see what i mean when you test your code.

Ok it's working thanks. I finnaly put something on the PDF !!
Last question I think : How do you get the position of the finger when I touch the screen.
Do I have to put onTouchEvent() inside the onLayerDrawn() or outside ?
For the moment I draw something but everytime at the same place

I have some code where i use a mini pdfviewer to take the main pdf viewer to the selected page, i guess i use a point to a degree let me see what i can find i did that code months ago.

Here is enough to get you going and it would of taken you a while to figure this much out, i know it took me a while.
Basically implement a tap event as below.
private class onTapListener implements OnTapListener {
    public onTapListener(Context baseContext) {
    }

    @Override
    public boolean onTap(MotionEvent e) {

Ok I finally got this :
`fun openPdf(pdfName: String) {
    pdf = findViewById(R.id.pdf) as PDFView
    val f = File(pdfName)
    pdf?.fromFile(f)
            ?.onDraw(object : OnDrawListener {
        override fun onLayerDrawn(canvas: Canvas, pageWidth: Float, pageHeight: Float, displayedPage: Int) {
            if(effacer == 0){
                var p = Paint()
                p.color = Color.BLUE
                canvas.drawLine(x.toFloat(), y.toFloat(), (x+10).toFloat(), y.toFloat(), p)
            }

        }
    })
           '?.onTap(object: OnTapListener{
                override fun onTap(e: MotionEvent?): Boolean {
                    x = e?.x!!.toInt()
                    y = e?.y!!.toInt()
                    effacer = 0
                    return true
                }

            })
        ?.load()
}`

But :

The line is draw about 100 pixels on the right of my touch, I don't know why

The drawing stay at his place when I scroll or something bu he got weird move when I zoom. I think That you explained with the 'DrawBitmap'. But I've go some errors when I code it.

Thanks a lot by the way.
I have more progress today than the whole week

Ah your welcome nice to know i am able to help, you learn more when you work through the issues yourself.  Sounds like you are making progress, i believe you need to set the left value on the drawline as your point you have pressed that should remove the offset that you are having issues with, get this offset value from the ontap from memory.

Everything it works  but now I've got an other problem. How do you handle the rotation of the screen? I store object in a list bu when I rotate, he don't draw anything

Okay, im back at my mac....
Either fix to portrait in manifest or basically store the locations and restore them after a rotation, did you manage to resolve the image moving on a zoom? I know my code isn't quite right since the latest beta version but not looked into fixing it.

During the rotation, my list with all the drawings is erased. I supposed I need to store the list with the context.
Yeah it's good for my drawing when i zoom. It is a really mess with the zoom, the offset but it works at the end.
The doubleTap zoom is annoying me also, it creates bug when I touch for draw, and when I disable it, the onTap doesn't work anymore...

get the double tap to do nothing so its ignored it normally jumps to set zoom levels,
Store the locations of the points then restore them, simple enough.  A Rotation destroys the activity and recreates so you lose everything, just save and restore on rotation.

How do you do ? I can't rewrite the doubleTap

@Override the event, just as you have done to create the tap event... but leave it blank,

Your very welcome, if you wish to privately share your code that would be a bonus so i can maybe use it if i ever need too as i continue to develop my app.
Maybe a bit cheeky but if you don't ask you don't get !

@1stmetro  Thanks for your support, I have a similar challenge.
I am currently able to create the point on the pdf using the tapListener. Now if I tap on the dot which I created, it should show some toast, or if the points match some action will be performed.
When the pdf is on default zoom and using currentPageOffset I am able to find out the point, but when I click, the event points from tapListener is different from the points marked at the time of default zoom.
Can you please help me for the same.
I have opened an issue for more information. #757

Can anyone please tell how can I add a watermark to the pdf


Adding *.VC.db to the .gitignore file

This file is generated by Visual Studio, for use with its intellisense. It often gets rebuilt and will differ between users. Being that the file is binary, it makes merging difficult.

Oh, I didn't remember we had x360ce "integrated".
It would be nice if we could just link it via subdmodules.
And given they at-least-officially dropped XP.. This seems a good excuse for that PR I was thinking opening to them but I hadn't specific reasons about.

Apparently if you make a pull request, then commit more code, it will add the new commits to the previous pull request. I only wanted to merge in the first commit mentioned, so that the *.VC.db files would stop being committed, to avoid unnecessary merge conflicts.
I'm closing this merge request.


Link to the H3.6M dataset on Readme is not working

Hi! The link for downloading the H3.6M zip file is no longer working. Would you mind sharing a new link or explaining how the dataset has to be downloaded?

Hi! I saw that the external link original from Stanford has been shut down. I think you need to download the original dataset from http://vision.imar.ro/human3.6m/description.php.


error: implicit declaration of function 'THLongStorage_calculateExpandGeometry'

The error was
/tmp/luarocks_cutorch-scm-1-6613/cutorch/lib/THC/generic/THCTensor.c:304:3: error: implicit declaration of function 'THLongStorage_calculateExpandGeometry' [-Werror=implicit-function-declaration]

The last stack trace was
Scanning dependencies of target THC
[ 81%] Building CXX object lib/THC/CMakeFiles/THC.dir/THCCachingAllocator.cpp.o
[ 82%] Building CXX object lib/THC/CMakeFiles/THC.dir/THCCachingHostAllocator.cpp.o
[ 83%] Building C object lib/THC/CMakeFiles/THC.dir/THCGeneral.c.o
[ 84%] Building C object lib/THC/CMakeFiles/THC.dir/THCStorageCopy.c.o
[ 86%] Building CXX object lib/THC/CMakeFiles/THC.dir/THCStream.cpp.o
[ 86%] Building C object lib/THC/CMakeFiles/THC.dir/THCTensorCopy.c.o
[ 87%] Building CXX object lib/THC/CMakeFiles/THC.dir/THCTensorRandom.cpp.o
[ 88%] Building C object lib/THC/CMakeFiles/THC.dir/THCTensor.c.o
In file included from generic/THCTensor.c:1:0,
                 from /tmp/luarocks_cutorch-scm-1-6613/cutorch/lib/THC/THCGenerateAllTypes.h:17,
                 from /tmp/luarocks_cutorch-scm-1-6613/cutorch/lib/THC/THCTensor.c:7:
/tmp/luarocks_cutorch-scm-1-6613/cutorch/lib/THC/generic/THCTensor.c: In function 'THCudaByteTensor_newExpand':
/tmp/luarocks_cutorch-scm-1-6613/cutorch/lib/THC/generic/THCTensor.c:304:3: error: implicit declaration of function 'THLongStorage_calculateExpandGeometry' [-Werror=implicit-function-declaration]
   THLongStorage_calculateExpandGeometry(tensor->size,

when building the gpu cuda8.0 docker image.

btw I have fixed this adding RUN luarocks install torch && \ since that is due to a not up-to-date torch repository.


DON'T MERGE: upgrade private registries ready for deno2

Fixes #671

Closing, fixed in another PR


Make Code Executed with Run Selection/Line in Interactive Window Accessible with Up Arrow

When using the interactive shell, you can either directly enter code into the interactive terminal, or select code in a script and run it in the interactive shell with the Run Selection/Line in Interactive Window  option. However, if you press the up arrow in the interactive terminal, it only registers code that was typed and executed from the interactive terminal. It would be very helpful if pressing the up arrow pulled up code that was executed using the Run Selection/Line in Interactive Window option.

closing for lack of supporting votes.
similar request: https://github.com/microsoft/vscode/issues/129081
note you can also use %run file.py from the input box, which will be added to the history


Docs/docusaurus

An overhaul of the existing documentation website with Docsaurus, reorganized existing documentation to be more digestable, fixed broken links.

@dcvz this PR would technically supersede this one https://github.com/doublesymmetry/react-native-track-player/pull/1487 if you want to move this direction.
For the record I think it's a massive improvement. You can run it locally and take a look. The reorg makes things easier to find and understand, we'll be able to easily integrate with Algolia for doc searching (which will be really nice), and a few other nice things.
Let me know your thoughts.
One thing I wanted to confirm is I think we can remove the iOS Enable Swift Modules instructions here https://react-native-track-player.js.org/install/
As I'm fairly certain I didn't do that last time I setup a project, but I could be forgetting.

@dcvz

Also one question, will this automatically deploy via our Github CI just like the current one?

So TBH I'm not sure how the current one is deploying. Not sure I have visibility into that. But here's what I do know
cd docs && yarn build will generate a static website located at docs/build. The files there just need to be pushed to the CDN.

@jspizziri I'm actually also not sure how the current one is deploying 👯
But I found this article about deploying docasaurus in Github Pages:
https://evantay.com/blog/docusaurus-gh-action/

@jspizziri looks like Github automatically deploys your docs if you're using Jekkyl: https://docs.github.com/en/pages/getting-started-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site

@dcvz I just pushed some new workflows based on the docusaurus documentation with gh-actions. I think it will work. There's a test workflow in there for whenever someone makes a PR to main.

I'm going to check one more thing. There might be some special config for js.org. I think there needs to be a change file which I deleted.

@dcvz I had to push the CNAME file which got removed in the refactor. That's all that changed. I can merge once you hit the approve button again.


Current Streak is not accurate

Issue Description
The Current Streak on the User Stats Page is reset to 1 even though there is still an active streak. In the screenshots below, Current Streak should have a value of 7 days and so should Longest Streak. This is possibly caused by the fact that it is counting current streaks of Challenges and not the other activities (Projects or Algorithms)
This slide (https://www.freecodecamp.com/challenges/configure-your-profile) does specifically state you need to complete challenges to get a streak, but I think Project and Algorithms should count towards this as well because it could take a couple days to get through an entire Algorithm or Project section before getting back to Challenges.

Closing in favor of https://github.com/freeCodeCamp/freeCodeCamp/issues/7925

Yikes sorry @raisedadead , I even did an issue search before opening :man_facepalming:

@donofriov Sure thing, not a problem.


Increase Operate retention period

Since dated indices are creates per day, if we define retention period for 30 minutes, indices are deleted and recreated again and again, provoking archiver failures and retries. This does not seem optimal.
Increased retention period till 1day.

I'm closing this PR as stale, feel free to reopen.


dark mode for http://flowchart.js.org/?

possible to work a dark mode to http://flowchart.js.org/ ? under win10 dark mode/chrome, http://flowchart.js.org/ is completely unreadable with both background and fonts being white

You can define your custom colors and styles: https://github.com/adrai/flowchart.js/blob/master/example/index.html#L42
if you want a built-in dark mode detection etc... feel free to provide a PR

thanks for the follow up.


[FLINK-31656][runtime][security] Obtain delegation tokens early to support external file system usage in HA services

What is the purpose of the change
At the moment there are no delegation tokens available when HA services is starting. If the HA services uses an external file system where the authentication type is delegation token based (typically S3) then it throws and exception since there are no credentials.
In this PR I've moved the delegation token manager initialization before HA services and trigger a manual token obtain + local JVM receiver propagation. Additionally deferred base directory creation in FileSystemBlobStore and FileSystemJobResultStore.
Brief change log

The delegation token manager initialization moved before HA services and trigger a manual token obtain + local JVM receiver propagation. This is the solution for the job manager side.
Deferred base directory creation in FileSystemBlobStore and FileSystemJobResultStore. This is the solution for the task manager side.
Changed the DelegationTokenManager API documentation for better clarity
Changed a log message for better clarity

Verifying this change
Manually on cluster.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): yes
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

I've just fixed the unit tests + changed the title and description. The cluster tests are green.

cc @gyfora @mbalassi


AudioPlayer and SpeechRecognizer capability agent interactions -- SDK v1.6

In SDK v1.6, I am seeing a certain level of asynchronous behavior between the two capability agents (AudioPlayer and AIP) which is causing us problems for some user experiences e.g. glowing LED's etc.
Here is the use-case.

User asks to play a tune-in URL. "Alexa, play tunein"
AudioPlayer Play directive is received as expected.
Next as TuneIn is being streamed, user barges in and asks a question
At this point, the AudioInputProcessor Capability Agent informs our observer through the DialogUXStateAggregator that the state has changed. Here, we call our routine to glow the LED's to listening state
However the AudioPlayer capability agent does not call MediaPlayer::Pause immediately as it waits for the focus to arrive so it can move to background.
Sometimes gstreamer takes time to pause the stream and the LED is glowing in the LISTENING phase without the stream being paused.

We are trying to minimize this experience but there is no way for us to actually glow the Listening LED's only when the stream has actually paused. This knowledge is resides in the AIP Capability Agent.
Is there a way to enhance the SDK to have a central controller of all capability agents that can relay the state when things actually happen? i.e. in this example when the music is acutally paused. In effect, we should get a call back or the SDK should open the stream only after step #6 has happened.
Please let me know.
Sincerely,
@adpandit

Hi @adpandit,
Thanks for bringing this up. The central controller you're referring to is supposed to be the FocusManager. At first glance, it looks like we may need to have the AIP acquire foreground focus a bit sooner. I'll investigate this a bit further and get back to you.
Thanks,
Sanjay

Hi @adpandit,
I've added this to our internal backlog to investigate and come up with a solution to have the AudioInputProcessor acquire focus sooner (immediately in the AudioInputProcessor::recognize() or AudioInputProcessor::executeRecognize() calls).
I think that should be able to solve your issue (in case you want to try it out locally). We will update this thread once we come up with a solution.
Thanks,
Sanjay

We believe this is now addressed in our 1.10 release, so I will close this out.  Please create a new ticket if this, or a similar issue is still found, so we can track separately, thanks.


Questions about experimental results

Hi @yuyangw , thanks for sharing your nice works! :)
I've pre-trained the mix-aug GIN model from scratch, and got the finetuned results on QM7 database.
In supported yaml files, the number of max epoch is set to 100.
BTW, when I checked tensorboard logs, the training seemed not to be sufficient.
So I've tried to finetune the models for 1k epochs on QM7, and got MAE results as 63.4±0.89 for 3 runs (c.f., 87.2±2.0 in the paper).
Target:  u0_atom Test loss: 0.2730964422225952 Test MAE: 62.36752 Best Valid metric: 80.150856 @ epoch: 400
Target:  u0_atom Test loss: 0.2805113196372986 Test MAE: 64.06087 Best Valid metric: 80.38328 @ epoch: 385
Target:  u0_atom Test loss: 0.2787664532661438 Test MAE: 63.66238 Best Valid metric: 82.99878 @ epoch: 295

(pick the model when the valid metric shows minimum value)
Have you ever experienced about finetuning the models for more epochs?
Here are the detailed configuration for finetuned results: (trained on Tesla V100-SXM2-32gb)
batch_size: 4096
dataset:
  data_path: data/qm7/qm7.csv
  num_workers: 4
  splitting: scaffold
  target: u0_atom
  task: regression
  test_size: 0.1
  valid_size: 0.1
epochs: 1000
eval_every_n_epochs: 5
fine_tune_from: ckpt/pubchem_Apr25_12-12-28/checkpoints/model.pth
fp16_precision: false
gpu: cuda:0
init_base_lr: 5.0e-05
init_lr: 0.0005
log_every_n_steps: 50
model:
  drop_ratio: 0.3
  emb_dim: 300
  feat_dim: 512
  num_layer: 5
  pool: mean
  pred_act: softplus
model_type: gin
task_name: qm7
weight_decay: 1e-6

Thanks in advance! :)
Sincerely,
YKim

Hi YKim,
Thanks for your interest in our work!
It is possible that training for more epochs leads to better results. In our work, we set the maximum epoch as 100 due to the limitation of computational resources and consistency with supervised GCN/CIN baselines.
Hope this helps.
Best,
Yuyang

Thank you for your sincere reply! :)
It could be helpful.
YKim


azureBlobTranscriptStore has performance issues and does not reverse order results

The problem with this implementation is that, conversation history is pulled from the beginning i.e. if a conversation history is of 100 lines, and I want to load the latest 20 lines, it give me lines 1 to 20 (oldest ones), instead of 81 to 100. Another issue with this implementation is each message is sent via websocket, which is resulting in a long time to load the conversation history.

Describe the solution you'd like
A solution that allows for reverse ordering results and has good performance.
Additional context
We need a complete story that works well with connector.conversations.sendConversationHistory
[enhancement]

This should be replaced with the EventHubs model for pushing transcripts to Azure.

As part of this, depricate the AzureBlobTranscriptStore and complete the EventHub model.

@daveta can you take over this effort?

@munozemilio : Let me know if you need help.  I'd vote we shift AzureBlobTranscriptStore to sample status, I think it's still useful in certain scenarios.

We need an all-up story around Transcripts.


QueryDemo won't build

I downloaded the package and opened QueryDemo but I'm getting a compile error (Xcode 13.2)

Hello @icanzilb, that's a pity!

I got the same problem from a fresh clone, with erased DerivedData folder.
However, after opening the demo project, seeing this error, then quitting Xcode and reopening the project, the build ran fine.
Is it the same for you?
I wonder if there is a way to workaround this Xcode glitch...

It's the same with Xcode 13.2 beta 2. Talk about a bad first contact 😞
I'll see what I can learn on Google about local packages caveats. Thanks for reporting!

Huh, you are right ... closing and opening the project again builds and runs with no issues 😬 This is definitely an issue with Xcode, good that you already have a sample project to attach if you create a feedback 😁

This is definitely an issue with Xcode, good that you already have a sample project to attach if you create a feedback 😁

Good idea 👍 Reported as FB9781232.

I'll close and pin this issue. This is just an Xcode bug, nothing we can really fix.


pip-tools should be installed in the project's virtual environment

see: https://github.com/jazzband/pip-tools/issues/1021

Changelog-friendly one-liner: Make the readme more imperative about installing into a project's virtual environment to avoid confusion
Contributor checklist

[ ] Provided the tests for the changes.
[ ] Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
[ ] Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev I've moved the details into the suggested sections, how does it look now?


Replacing match to search not working (/xyz cgn)

When I want to replace multiple occurrences of a term in VIM, I search for it, type "cgn", enter the replacement and press "." to replace the remaining occurrences. In jupyterlab-vim that doesn't work for me.
Host Ubuntu 18.04
Client Chrome 72.0.3626.119 on Mac OS 10.14.3

Ooh, I didn't even know about "gn" operations until now! I would love to be able to use those in JupyterLab too, now that I know about them :)

@benlindsay Once you know them you can't go without ;)

FWIW https://github.com/codemirror/CodeMirror/issues/3851


Change repo ACL

Repo to change access: solang, solang-llvm, solang-aqd
GitHub ID to add: salaheldinsoliman

One of:

https://github.com/orgs/hyperledger/teams/solang-contributors
Role:

Write

Cc: @xermicus @salaheldinsoliman

@seanyoung invite sent. the default role is "maintain", do you want another team with only "write" access?

@ryjones I didn't receive an invite, can you re-send it please?

@salaheldinsoliman I think if you visit https://github.com/hyperledger it should appear at the top of the page

@ryjones Got it, thanks!

@seanyoung invite sent. the default role is "maintain", do you want another team with only "write" access?

I did not realize "maintain" was the default access level. "maintain" is good, no reason for another group

Thank you @ryjones


add option for (remember trusted extension in create backup )

Describe your suggested feature
if added option for remember trusted extension in backup you don't need to manually add trust again for extension when you need for some reason uninstall or update and it demands again
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an official extension, I should be opening an issue in the extensions repository.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I will fill out all of the requested information in this form.

add option (separate backup) for (automatic (of choice/category) backup) add (backup frequency) add (separate folder location)


woodpecker-agent not accepting --filter arguments

Component
agent
Describe the bug
When providing key-pairs for --filter, these are not being used by the agent.
To replicate:
Start an agent with a filter of key-value pair:
./woodpecker-agent --grpc-password secret --backend-engine local --filter type=exec

Add label to pipeline yaml:
labels:
  type: exec

Expected:
agent will run the tack
Experienced:
agent does not pick up the task.
Issue seems to be in cmd/agent/agent.go: for _, v := range c.StringSlice("filter-labels") { as per my PR.
System Info
7a4827bb

Additional context
No response
Validations

[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.

Edit: fix yaml formatting

Thank you, confirmed now also in the docker image.


Repo: Update Analog SFC app to use .ag extension instead of .analog extension by default

Which scope/s are relevant/related to the feature request?
Don't know / other
Information
We've added support for the .ag extension when using the Analog SFC. This would update the ng-app in the repo to use the new extension instead.
We're updating the Analog Language Tools and IDEA Plugin to support the extension also.
Describe any alternatives/workarounds you're currently using
No response
I would be willing to submit a PR to fix this issue

[ ] Yes
[ ] No

Easing my way into this repo. I'd like to tackle this one @brandonroberts.

Nice @nickytonline


Suggestion: Settings/Config UI

This may already be on the roadmap, but where could I start in mapping configuration settings in the config.json to a UI?

OOH! This would be great! To check we're on the same page, are you saying you'd like to update the settings page with a more form-like / user-friendly controls for updating the more commonly updated propertied of the ipfs config file?
The design discussion for the settings page is here https://github.com/ipfs/ipfs-gui/issues/15 and we have some initial design proposals, that'll add there shortly.

That's exactly what I'm looking for!

Closing this issue in favor of https://github.com/ipfs/ipfs-gui/issues/15 - thanks!


Kristin Boyd - scissors

I cant get the tests to pass. Everything works but for some reason the tests take too long to load and end up timing out. I'm not sure if I did something incorrectly? I'll keep trying to make it work.


implement heuristics

depends on #8 for bookkeeping on where variables occur.
in order of priority (should only need 2):

[ ] Bohm: gives preference to variables that are satisfying small clauses or that are reducing the size of already small clauses

[ ] MOM

[ ] Jeroslow-Wang

[ ] conflict-based stuff

[ ] Random

[ ] DLIS

[ ] JS-TS


Sorting Creates Duplicates in Datatable That Are Not in DB - Eager Loaded Relationship

Hey,
thanks for this awesome package, it's been going great so far. But I stumbled on a problem that I can't seem to figure out now.
I'm eager loading a relationship and when I'm sorting the datatable in my view, the Datatable all of a sudden has duplicate rows that aren't in the database. It has something to do with the amount of relationships but I can't figure out what.
/**
     * Process dataTable ajax response.
     *
     * @param \Yajra\Datatables\Datatables $datatables
     * @return \Illuminate\Http\JsonResponse
     */
    public function dataTable()
    {
        $landers = Lander::with('tags')
                         ->select('landers.id', 'landers.lander_label', 'landers.lander_domain', 'landers.lander_path_uuid', 'landers.created_at');

        return Datatables::of($landers)
                         ->addColumn('tags', function (Lander $lander) {
                             return $lander->tags->map(function ($tags) {
                                 return $tags->tag_label;
                             })->implode(',');
                         })
                         ->addColumn('preview', function ($data) {
                             $preview = $data->lander_domain . '?lp_preview=' . $data->lander_path_uuid;

                             return view('landers.datatables.preview', compact('preview'));
                         })
                         ->addColumn('action', function ($id) {
                             return view('partials.datatables.checkbox', $id);
                         })
                         ->rawColumns(['action', 'preview'])
                         ->blacklist(['action', 'preview'])
                         ->make(true);
    }

$(function () {
        $('.datatable').DataTable({
            processing: true,
            serverSide: true,
            ajax: '{{ route('api.landers') }}',
            "order": [],
            columns: [
                @can('delete_landers')
                {data: 'action', name: 'action', orderable: false, searchable: false},
                @endcan
                {data: 'lander_label', name: 'landers.lander_label'},
                {data: 'lander_domain', name: 'landers.lander_domain'},
                {data: 'tags', name: 'tags.tag_label'},
                {data: 'created_at', name: 'landers.created_at'},
                {data: 'preview', name: 'preview', orderable: false, searchable: false},
            ],
            "pagingType": "full_numbers"
        });
    });

select `tags`.*, `lander_tag`.`lander_id` as `pivot_lander_id`, `lander_tag`.`tag_id` as `pivot_tag_id` from `tags` inner join `lander_tag` on `tags`.`id` = `lander_tag`.`tag_id` where `lander_tag`.`lander_id` in ('1', '2', '5', '8', '11', '14', '17', '18', '21')

the actual pivot table for lander_tag:

This is the resulting table:
(As you can see the row with ID 21 is listed three times, exactly as many times as there are tags relationships.

Expected result:
The table sorted by tags, with just one table row for ID 21.

PHP 7.1
Laravel 5.4
Datatables v7.8.0

Ok so I've investigated further, this does not happen on the original query when datatable is first build, it only happens on column sort of a belongs to many column.
This works, and displays the table correct with the tags that belong to the Lander model, in the same row
$landers = Lander::select('landers.id', 'landers.lander_label', 'landers.lander_domain', 'landers.lander_path_uuid',
            'landers.created_at')->with('tags')->distinct();

        return Datatables::of($landers)
                  ->editColumn('tags', function (Lander $lander) {
                      return $lander->tags->pluck('tag_label')->implode(',');
                  })
                  ->addColumn('preview', function ($data) {
                      $preview = $data->lander_domain . '?lp_preview=' . $data->lander_path_uuid;

                      return view('landers.datatables.preview', compact('preview'));
                  })
                  ->addColumn('action', function ($id) {
                      return view('partials.datatables.checkbox', $id);
                  })
                  ->rawColumns(['action', 'preview'])
                  ->blacklist(['action', 'preview'])
                  ->make(true);

But when I order the Tag column, it creates new duplicate rows:

@madsem I think this is the default behavior on the SQL LEVEL. I usually disable sorting on has many relations.

@yajra thanks, I figured it's probably something like that, still learning :)
It's also what I ended up doing, disabled ordering and left searchable because that works.
Can you explain off the top of your head why this happens in SQL? Just trying to understand it. When I run the query in sequel pro, I get two results (i expected that) I just thought the package would then loop over those and not also make a second row?
Why is this happening?

AFAIK, this is how it works.
Given:
users
id | name
1 | A
2 | B

posts
id| user_id | title
1 | 1 | Post 1
2 | 1 | Post 2
3 | 2 | Post 3

WITHOUT RELATION SORTING
When we load users, the usual query generated is:
select users.* from users order by id

Output:
1 | A | post 1 + post 2 (collection of posts)
2 | B | post 3

WITH RELATION SORTING
But when we order by relation, we are then force to join the relation to be able to do so:
select users.* from users
left join posts on users.id = posts.user_id
order posts.title

Output:
1 | A | post 1
1 | A | post 2
2 | A | post 3

Hi,

But since we are eager loading posts. The output will become:
1 | A | post 1 + post 2
1 | A | post 1 + post 2
2 | B | post 3

I'm using the latest version and this is not happening to me.
Controller function that is called by the datatable:
    public function datatable(Request $request)
    {
        if ($request->expectsJson()) {
            $columns = ['ingredient_types.id', 'ingredient_types.published', 'ingredient_types.created_at'];
            $with = ['translations'];

            $builder = IngredientType::with($with)->select($columns);

            return Datatable::ingredientTypes($builder);
        }
    }

Helper function to create the datatable:
    public static function ingredientTypes($ingredientTypes)
    {
        return DataTables::eloquent($ingredientTypes)
            ->editColumn('name', function (IngredientType $ingredientType) {
                return $ingredientType->translations->map(function ($translation) {
                    return str_limit($translation->name, 30, '...');
                })->implode('<br>');
            })
            ->rawColumns(['name'])
            ->toJson();
    }

JS:
      $('#datatable').DataTable({
                responsive: true,
                processing: true,
                serverSide: true,
                pageLength: 25,
                orderClasses: true,
                order: [1, 'desc'],
                pagingType: "full_numbers",
                ajax: {
                    url: "{!! route('backend.ingredient-type.ajax.datatable') !!}",
                    type: 'POST',
                    dataType: 'json',
                    cache: false
                },
                columns: [
                    {data: 'id', name: 'id'},
                    {data: 'name', name: 'translations.name'}
                ]
        });

Output:

How do i just show one row per ID? This only happens when the sorting is applied in the relation column. If the sorting is applied tn the ID it shows correctly. But i looked in your examples and this doesnt occur... what am i missing here? Thanks.


Correction for raw affiliation Montpellier Interdisciplinary Center of Sustainable Agri-Food Systems (UMR MoISA), Montpellier University and French Agricultural Research Center for International Development (CIRAD), Montpellier, France

Correction needed for raw affiliation Montpellier Interdisciplinary Center of Sustainable Agri-Food Systems (UMR MoISA), Montpellier University and French Agricultural Research Center for International Development (CIRAD), Montpellier, France
raw_affiliation_name: Montpellier Interdisciplinary Center of Sustainable Agri-Food Systems (UMR MoISA), Montpellier University and French Agricultural Research Center for International Development (CIRAD), Montpellier, France
new_rors: 05kpkpg04;051escj72;011xg1225
previous_rors: 05kpkpg04;051escj72
works_examples: W4390411341
contact: 4127860d6ede161230b8ac4e84b06285:abc25ffd0e924b85 @ supagro.fr

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


[Suggestion] An item to copy/paste filter settings

It's annoying to set up 10 furnaces, put exporters on them and then define settings in each exporter, an item to help with that would be nice.

I was thinking about adding shift click support to specimen slots. Maybe that is a better alternative?

This is how it can work now

While this is certainly better but still doesn't solve when I'm adding more machines and  don't have the items on me, and it'd be very annoying to figure out which items I'm missing exactly and see if I even have any.
I still think that a tool to copy and paste settings across exporters and such is needed.

I don't think such a tool belongs in RS


Cleanup and development of flag to enable/disable rendering

Motivation and Context
This PR is a continuation of Eric's PR here: #1258
Here is the todo list in the PR and how I addressed them:

The hacky use of a global g_createMagnumRenderer var.

The flag is now stored in SimulatorConfiguration and passed around using getter methods. GenericDrawable also has a copy of the flag that is set in its constructor.

Probably not all cases of graphics context use have been properly disabled/guarded, e.g. PbrDrawable.

Turns out the PbrDrawable codepath is impossible to reach when createRenderer=false. See https://github.com/facebookresearch/habitat-sim/pull/1308#discussion_r652931814

Let's add a test of creating a non-renderer sim and using various APIs like drawObservation.

See SimTest.cpp.

We should handle primitives correctly or at least fail gracefully. If we need to disable primitive-loading/use, we should issue a proper warning to users if they try to use a primitive that's unavailable.

This was referring to the skipping of the ResourceManager::initDefaultPrimAttributes method if the flag is off. The concern was that because of this, primitives would not be loaded correctly and thus should not be used. However, it appears that the only thing disabling this method affects is the visualization of bounding boxes, which doesn't matter when not using a renderer anyways.

We need to reconcile with the existing SimulatorConfiguration::createRenderer. From discussion with @jturner65 , it sounds like the existing functionality of the existing flag (including disabling physics manager) isn't needed at all. So we instead hook up the createRenderer flag to the new functionality introduced in this PR (and discard the no-physics-manager code path altogether?).

The old createRenderer flag and its codepath have been deleted. The new flag has been renamed to createRenderer.

Decide whether to create a stub Renderer object (discussed below).

Decided in meeting against this approach.

reconcile two related features: disabling usage of OpenGL (this PR) and disabling loading of render assets (separate feature). After team discussion on 6/1, we agree this can be implemented separately. However, one suggestion is to have an enum for all the combinations of usage, instead of two independent flags. However, we all agreed that this PR doesn't need to implement the second feature, disabling loading of render assets (that can be a future PR).

Done (first feature). GL::Mesh and Shaders::FlatGL are no longer created when the flag is set.
How Has This Been Tested
A test case demonstrating the functionality (what still works, what doesn't work) when the flag is disabled has been added in SimTest.cpp.
Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have completed my CLA (see CONTRIBUTING)
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

FYI the GL::Mesh can be constructed as GL::Mesh{NoCreate} without a GL context present. So you could keep passing GL::Mesh& around, which could reduce the amount of changes and additional logic in this PR quite a bit.
Same is for textures (GL::Texture2D{NoCreate} won't need a GL context to exist).
(Apologies if this suggestion came too late, was too busy to check PR reviews regularly.)

FYI the GL::Mesh can be constructed as GL::Mesh{NoCreate} without a GL context present.
As you say, this suggestion is coming a bit late. :) For this PR, we removed GL::Mesh creation as you originally requested in our Slack discussions. This PR has been under review for a while and we'd like to get it merged. Let's do the switch to GL::Mesh{NoCreate} as a separate refactor PR.

FYI the GL::Mesh can be constructed as GL::Mesh{NoCreate} without a GL context present.
@mosra : Great. Good to know. However, I guess one reason they changed them to pointer is that they can easily tell if the simulator is initialized with the renderer (just checking if the pointer is NULL).
In the way you suggested, how can this be done?


Sign container images

Signing generated containers allows end users to verify that any container they pull actually came from us. With GitHub Actions new support for OIDC ^1 it's now possible to use cosign ^2 to sign containers in GitHub Actions without any human interaction or storing long-lived keys as secrets.
Here's a demo someone put together explaining how to set it all up: https://github.com/chrisns/cosign-keyless-demo

Very interesing, needs some more refactoring of out docker builder to support this for all our images

GitHub blog post on the same topic: https://github.blog/2021-12-06-safeguard-container-signing-capability-actions/


HTML

#HTML
User story
As a bootcamp user
I want my prework notes to be structured on a webpage
so I can easily find and read information
Acceptance criteria
GIVEN a prework study guide website
WHEN I visit the website in a browser
THEN I should be able to see four areas titled HTML, CSS, JS, and Git with associated nodes listed

HTML code added


configuring the cli using env is not possible

Hi,
aliyun-cli should be able to be configured using ALICLOUD_ACCESS_KEY_ID, ALICLOUD_ACCESS_KEY_SECRET and SECURITY_TOKEN.
However after the default installation the seems to be a predefined default account in ~/.aliyun/config.json with mode set to AK, which prevents the the logic to automatically set the mode to STS if SECURITY_TOKEN is set.
Also, if the active profile has any other data already set, the environment variables do not have any effect.
It would be nice to be able to configure aliyun-cli completely via environment variables

Command Format:

Execution Command:

Output:

I have been in this situation too; where you need to generate those values and pass it through configure.
Also to mention; doesn't fall down the order for the auth method, e.g if the ECS instance holds ram role it should just read it from metadata yet it requires configuration saying which ram role you want to use (given its only possible to set 1 role per instance).
Also, the deletion of any added role will take you to default; which would be empty in the above situation.

CLI reads configuration file parameters first, please try to call after configuration.

CLI reads configuration file parameters first, please try to call after configuration.


Add child_kwargs to PolymorphicSerializer

This enables passing in a dictionary param, child_kwargs, to
a PolymorphicSerializer. In doing so the child_kwargs will not
be applied to the Polymorphic Serializer - but will be applied to
the child serializers alongside kwargs.
This resolves issue #33

Yep that is the crux of the PR. Interesting idea on having type specific kwargs.
Definitely possible, question is what would be the best API for this? Do we want to do it based on specific object instance? or specific serializer type? My specific usecase for instance would want to do it on serializer type.
Could do something like:
child_kwargs = {
    "SerializerType": serializer_type_kwargs,  # Applies only to SerializerType children
    "*": global_child_kwargs,  # Applies to all children.
}


rhel: upgrade to ubi9

Description
upgrade container to ubi9, will always stick to latest version of ubi9/go-toolset:1.20
For compatibility install compat-openssl11 for fdo compilation (to remove when fdo-data container is upgraded to ubi9)
Type of change
What is it?

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update
[ ] Refactor

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] I run make pre-commit to check fmt/vet/lint/test-no-fdo

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4e3e49f) 62.11% compared to head (c9ae4bb) 62.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2368   +/-   ##
=======================================
  Coverage   62.11%   62.11%
=======================================
  Files          88       88
  Lines       13232    13232
=======================================
  Hits         8219     8219
  Misses       4336     4336
  Partials      677      677

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

/retest

/retest

@mergifyio rebase

/retest

/retest

/retest

/retest

/retest


Move local_datetime, local_date and local_time to cal:: namespace

This closes #866 and #875

Fixed by #929


All text input controls disabled in IE11 after removing reCAPTCHA with ngIf

I was looking into this strange behaviour when I found this article: Textbox occasionally gets disabled on IE11 and I believe they are related.
It seems to occur when reCAPTCHA pops up its image picker (which is in an IFRAME) and the user chooses correctly (placing focus into the IFRAME), then clicks on a 'Next' button on the UI, wherein there is logic that causes Angular to destroy the DOM node containing it due to an *ngIf on a parent container - imagine this as the first step in a wizard or tabbed-navigation interface.
It seems that possibly the DOM is being destroyed basically during the mouseup event of the button, thereby not fully migrating focus away from the IFRAME. Then when it is destroyed, the browser bug triggers and no text boxes are focusable anymore. Well, you can click on them but no cursor appears and typing into them is disabled.
The problem does not occur if you were to click into a text box before clicking the 'Next' form button (focus is pulled out of the IFRAME).
We might need a way to refocus the container in the ngOnDestroy event... I will look into it but I'm posting this here to keep a record of it (and hopefully help anyone else who might be experiencing this issue).

Any updates regarding this?

I'm not sure if it can be solved purely by this component, without requiring additional effort on the part of the consumer. To grab the focus back from the iframe, you need to call .focus() on a focusable element - an input, anchor, button, textarea, img with map links, etc. or an element with an explicit tabindex. Any old div just doesn't work.
It would also be preferable to try to maintain the tab order, i.e. not just reset the focus to the body or first focusable element on the page, as this would destroy usability for keyboard users.
As I see it there are 2 viable options... 1 (the option that we went with) is to require the consumer to take responsibility for ensuring a known element on the page has focus, at some point after the token is received, but before the reCAPTCHA is removed from the page. So in our button (click) handler we explicitly focus the submit button (using an ElementRef), then use a setTimeout to toggle the flag bound to the *ngIf on the reCAPTCHA, ensuring that the button will have focus before this component is destroyed.
A second option might be to add some API to this component where you could pass an ElementRef (or maybe a CSS selector?) and it would attempt to push focus to that element from ngOnDestroy. I'm not 100% sold on this but I could be convinced if there was demand for it.

As my use case is solved I am happy if you want to close this issue.
However as I said, if others are experiencing the same problem and are interested in my second option, try to convince me and I might make a PR ;)

Thanks @BeheadedKamikaze . Let's come back to this one if it comes up again.


[BUG] ResNetClassifier fails tests

Describe the bug
ResNetClassifier fails all the tests due to an issue cloning the classifier
E RuntimeError: Cannot clone object ResNetClassifier(batch_size=4, n_epochs=10, optimizer=(None,)), as the constructor either does not set or modifies parameter optimizer
Steps/Code to reproduce the bug
_config, comment out resnet, then run test_all_estimators
Expected results
pass the tests
Actual results
estimator = ResNetClassifier(batch_size=4, n_epochs=10, optimizer=(None,))
def clone(estimator, *, safe=True):
    """Construct a new unfitted estimator with the same parameters.

    Clone does a deep copy of the model in an estimator
    without actually copying attached data. It returns a new estimator
    with the same parameters that has not been fitted on any data.

    Parameters
    ----------
    estimator : {list, tuple, set} of estimator instance or a single \
            estimator instance
        The estimator or group of estimators to be cloned.
    safe : bool, default=True
        If safe is False, clone will fall back to a deep copy on objects
        that are not estimators.

    Returns
    -------
    estimator : object
        The deep copy of the input, an estimator if input is an estimator.

    Notes
    -----
    If the estimator's `random_state` parameter is an integer (or if the
    estimator doesn't have a `random_state` parameter), an *exact clone* is
    returned: the clone and the original estimator will give the exact same
    results. Otherwise, *statistical clone* is returned: the clone might
    return different results from the original estimator. More details can be
    found in :ref:`randomness`.
    """
    estimator_type = type(estimator)
    # XXX: not handling dictionaries
    if estimator_type in (list, tuple, set, frozenset):
        return estimator_type([clone(e, safe=safe) for e in estimator])
    elif not hasattr(estimator, "get_params") or isinstance(estimator, type):
        if not safe:
            return copy.deepcopy(estimator)
        else:
            if isinstance(estimator, type):
                raise TypeError(
                    "Cannot clone object. "
                    + "You should provide an instance of "
                    + "scikit-learn estimator instead of a class."
                )
            else:
                raise TypeError(
                    "Cannot clone object '%s' (type %s): "
                    "it does not seem to be a scikit-learn "
                    "estimator as it does not implement a "
                    "'get_params' method." % (repr(estimator), type(estimator))
                )

    klass = estimator.__class__
    new_object_params = estimator.get_params(deep=False)
    for name, param in new_object_params.items():
        new_object_params[name] = clone(param, safe=False)
    new_object = klass(**new_object_params)
    params_set = new_object.get_params(deep=False)

    # quick sanity check of the parameters of the clone
    for name in new_object_params:
        param1 = new_object_params[name]
        param2 = params_set[name]
        if param1 is not param2:

          raise RuntimeError(

                "Cannot clone object %s, as the constructor "
                "either does not set or modifies parameter %s" % (estimator, name)
            )

E               RuntimeError: Cannot clone object ResNetClassifier(batch_size=4, n_epochs=10, optimizer=(None,)), as the constructor either does not set or modifies parameter optimizer
....\venv\lib\site-packages\sklearn\base.py:98: RuntimeError
Versions
No response

I am not following, why are we cloning the optimizer ? and why is it failing only for ResNet ? I thought it was fixed in the latest update of deep learners #433

cloning happens in testing, this type of error is usually because something declared in constructor is being incorrectly set somewhere else. Related to the underscore suffix thing.


Create a general component for starting Docker containers

[x] Create namespace cmr.dev.env.manager.components.common.docker
[x] Support non-daemon process fork
[x] Capture the container ID and track this in the component's data
[x] Provide a means of checking the container's status
[x] Use the container ID to shutdown the correct container

Done.


read deployments from previous deployment scripts

It would be really nice for forge-deploy to support something like deployments.read() like hardhat-deploy does, so I can again re-use my past deployments in either future deploy script or in test suites across different chain networks .
I also note that I still love how tags and dependency work, but I still do not know the context to deal with them in solidity.

I did make something for it meanwhile if you're interested:
https://github.com/Abracadabra-money/abracadabra-money-contracts/blob/7180d51d4ffe673ab0f8341c47e3610417709363/hardhat.config.js#L123

Thanks for replying.
I have made it worked. I use forge-deploy  's deployer.getAddress like:
`
function deploy() external returns (Proxy) {
    proxyAdmin = deployer.getAddress('ProxyAdmin');

    return Proxy(
		deployer.deploy_Proxy(
			"L2OutputOracleProxy",
			proxyAdmin
		)
	);

`
But I still love to have tag and dependencies implemented so I dont have to re-write and re-import deployment script in test suites

Was going to reply there is indeed the following method on the deployer:
  /// @notice function that tell you whether a deployment already exists with that name
  /// @param name deployment's name to query
  /// @return exists whether the deployment exists or not
  function has(string memory name) external view returns (bool exists);

  /// @notice function that return the address of a deployment
  /// @param name deployment's name to query
  /// @return addr the deployment's address or the zero address
  function getAddress(string memory name) external view returns (address payable addr);

  /// @notice function that return the deployment (address, bytecode and args bytes used)
  /// @param name deployment's name to query
  /// @return deployment the deployment (with address zero if not existent)
  function get(string memory name) external view returns (Deployment memory deployment);

for tags and dependencies, let's make a different issue.
Not sure how this would work in solidity which is not dynamic. I guess this could be done with a specific executor that would in turn call forge script....


how can I find the corresponding coordinates of these RGB values in the point cloud? If this is not possible with RGB values, how can I find them with RGBD values?

Hi  I am a new user of D405 depth camera. In my project, I need to detect an object and find its 3D coordinates in the point cloud. I detect the object on the RGB image and get the RGB values of the object. At the same time, I save the object in the point cloud with the D405 camera. I read the coordinates in the point cloud with open3d.
how can I find the corresponding coordinates of these RGB values in the point cloud? If this is not possible with RGB values, how can I find them with RGBD values?

Hi @Fc6868  If your pointcloud is an RGBD textured pointcloud where the RGB color data is mapped onto the depth pointcloud to produce an aligned image then the RGB coordinate of a particular point should be the same as the depth coordinate.

Thanks for your response. What I need to understand from this message is that I can find the correct coordinates by using the D(depth) and Z(z-axis) equality condition to find the coordinate values in the point cloud. If this statement is correct, you can close the topic. have a good day.

The depth value and z-axis value would be the same thing, since depth = z-distance.


feat!: Bump minimum to iOS 14

Raise minimum supported OS to iOS 14 to match Maps SDK for iOS 8.0.0
Fixes #451, #456, #458, #459

Any chance this gets merged soon? Running into some bugs that version 8 fixes.

@wangela is there any reason not to merge this? you need help? This blocks #451

It's been over a year since the PR was opened, google maps SDK 9 is out now with minimum supported iOS being 15.
Is it going to be a release with SDK 8 support and minimum iOS 14 anytime soon?

@jcesarmobile We are getting close! See #473 for analysis, status, and roadmap.


[PGOAPI ERROR] Only few with api error but still lv2

Hello,
i tested monocle now and it did very fine with a test of 7 accounts(2x3), i started another try but the workers told me that there is an pgoapierror.
All the accounts are now lv 2-3, but the 3 Which cause the error are "just" lv 2. I dont know why they are even 2 if there was the error from the start on, can you help me out maybe?

I am also experiencing this error. I ran for weeks with 100 accounts with no problems, increased to 150 with no problems. When I increased to 200 accounts, now I am seeing anywhere from 15-30 accounts at a time throwing this error.

Also getting this error, logs show:
Traceback (most recent call last):
File "c:\Users\Michael\Monocle\monocle\worker.py", line 625, in visit
return await self.visit_point(point, bootstrap=bootstrap)
File "c:\Users\Michael\Monocle\monocle\worker.py", line 756, in visit_point
raise ex.UnexpectedResponseException('Bad MapObjects response.')
pogo_async.exceptions.UnexpectedResponseException: Bad MapObjects response.
[2017-02-23 19:51:28][   ERROR][worker-1] UnexpectedResponseException
Traceback (most recent call last):
File "c:\Users\Michael\Monocle\monocle\worker.py", line 742, in visit_point
map_objects = responses['GET_MAP_OBJECTS']
KeyError: 'GET_MAP_OBJECTS'

get_player = responses['GET_PLAYER'] also throws an ignored KeyError.

RPC requests are failing with status_code 100

This is fixed with latest commits.

Closing since this has likely been fixed. Reopen it if it's not, and include what the actual error is (from your scan.log).


In water hotkey always use skimmer

Every time I use the hotkey in water, the skimmer is selected. Can´t select the skiff.
Selection: Center behavior is nothing.
The skiff can be selected only near water on land.

center behavior is nothing.

Use the latest pre-release and make sure you are on the water surface, otherwise the skiff cannot be summoned.

That did the trick ! :)
...used the Addon Manager for install.
Thank You!


feat(*): Update dependencies to use rustls instead of openssl

This makes it so we don't have to compile against specific versions
of openssl and might make Windows easier.
This also updates our kube and openapi dependencies
Closes #247

Realized I still need to test a few things locally so moving to draft

How do we want to address the e2e failure?
Error: ReqwestError(reqwest::Error { kind: Request, url: "https://<IP_ADDRESS>:32768/api/v1/nodes/krustlet-wascc", source: hyper::Error(Connect, Custom { kind: Other, error: "invalid dnsname" }) })
thread 'test_wascc_provider' panicked at 'assertion failed: `(left == right)`
  left: `1`,
 right: `0`: the test returned a termination value with a non-zero status code (1) which indicates a failure', <::std::macros::panic macros>:5:6

@bacongobbler That is the feature work I mentioned to you offline. Still working on it

A couple of notes on this:

This makes it really easy to build on windows once this patch gets merged upstream
This does not entire remove openssl from the equation. We are still using native-tls for the kubelet API. This means on linux it will still use the local openssl. I am going to create another issue to track the work for that. It will require that we switch to PEM only instead of pkcs12

Currently holding off on this as TLS bootstrapping is going to require the openssl dependency any way to generate CSRs

Ok, so I found a way using the rcgen crate to generate a CSR and private key without openssl, so once TLS bootstrapping hits, we can refactor to use that and have a completely openssl-less build. We will still want the features this PR adds so that people can still develop locally with kind/minikube (rustls doesn't currently support certs with IP SANs)


[17-11-15] CQUI makes start positions invisible in World Builder

I have no idea why it interferes with the World Builder but when CQUI it active start positions become invisible on the map. See screen shots of same area of same map with/without CQUI.
\Skodkim

As I said in #152 CQUI is not needed in the world builder and you can disable it easily. It's still not a priority for now to fix this.

skodkim, could you tell me where can I find the world builder please?

hmm, went back to civ5 a while ago and don't remember. Isn't it in the civ startup screen under additional content or something..? Otherwise Google is your friend :-)
\Skodkim
Sendt af BlueMail
Den 10. mar. 2018 14.32, fra 14.32, tamaroide<EMAIL_ADDRESS>skrev:

skodkim, could you tell me where can I find the world builder please?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/Azurency/CQUI_Community-Edition/issues/223#issuecomment-372030227


open graph image fix

Below og tag is used for open graph image

And https://www.abbreve.tech/src/assets/thumbnail.png url is loading home page not image.

https://github.com/Njong392/Abbreve/issues/362
Closes #

What new changes did you make? Tick all applicable boxes

[ ] Added new abbreviation
[x] Fixed something in the source code
[ ] Added a new feature
[ ] Fixed the docs (README.md, CONTRIBTUING.md, etc)

Describe the new changes you added.

using a relative path like /src/assets/thumbnail.png assumes that the image is located at the specified path relative to the current URL
this approach can lead to incorrect routing and loading of the home page instead of the image

Share a screenshot of new changes

Thank you very much for the PR! Apologies for getting to it late. I see that you have changed the link to the og image. We want a specific image, located in the assets folder to serve as some sort of social media preview image. The link you added loads the home page and not the image.

Hi @Njong392 looks like you can't access the image from the src directory, to access it you need to move the assets to the public directory, I tried it works

but getting logs like this

Instead of /public/assets/btw.png, put the file in the src directory, and use /src/assets/btw.png instead.

need your confirmation!

Hi @Njong392 any update on this PR


fix: requirements parsing adapted to newer pip versions

Every time I tried to install the develop version of the atmos package either via pip install or pipenv install, I was facing an error most likely related to the issue that was addresed in issue #8. The req module has been moved to the pip._internal.req submodule, so the try except in setup.py seems to solve the issue of importing the parse_requirements function.
However, some extra changes might have happened on the  pip side, because apparently, now, the ParsedRequirement class has had its req attribute renamed to requirement, which caused an AttributeError.
I solved this in my machine via another try and except clause that should handle older and newer pip versions, feel free to include this in the main develop branch!

Thanks Alejandro! Much appreciated!


Renewing access tokens fails when running IPFS

When recreating the docker image I'm able to authenticate just fine. However, I'm assuming after the token expires, I'm being redirected back to my OAuth provider (Google) clicking on my account and then getting the Not authorized response.
From traefik I'm seeing:
traefik                 | time="2020-07-25T23:47:38Z" level=debug msg="Remote error http://traefik-forward-auth:4181. StatusCode: 307" middlewareType=ForwardedAuthType middlewareName=forward-auth@file

--- (Some more investigation)
What's weird is that I'm running an IPFS on my docker-compose host. As soon as I shut this one service down, everything works fine. I think it has something to do with my IPFS Firefox extension that is hammering traefik/traefik-forward-auth API endpoint. I have the forward-auth middleware attached to this service as I don't want to expose this to the internet.

Could you post the logs from traefik-forward-auth also?
It sounds like you may be hitting #113

I'm closing this one now, but please reopen if you have more info


Barb Assault Buy Fix

Enables you to buy items again using your honour points, if no quantity is provided quantity is set as 1

[x] I have tested all my changes thoroughly.

Reopened as I think it should be merged and can always be moved to a buy command at a later point.


nrf5*: crash when Bluetooth advertisements and flash write/erase are used simultaneously

Describe the bug
nrf52840 platform (but probably whole nrf5 family) crashes when both Bluetooth advertisements are enabled and there are some flash write/erase operations done from application thread (like DFU operation). There is a pointer dereferencing done in "ticker" callback (as part of nrf flash driver), which dereferences thread stack that might no longer be valid, which results in system crashes.
Please also mention any information which could help others to understand the problem you're facing:

What target platform are you using? - nrf52840 based devices, but this whole nrf5* family might be affected
What have you tried to diagnose or workaround this issue? - workarounds are part of referenced branch that contains sample that allows to reproduce this issue; however provided workaround might not be enough, as the target application still crashes from time to time
Is this a regression? If yes, have you been able to "git bisect" it to a specific commit? - probably Zephyr 2.7.0 was already affected (could try to confirm if that information is valuable), but not sure about earlier versions; i.e. it does NOT look like a recent regression.

To Reproduce
Steps to reproduce the behavior:

west init -m https://github.com/mniestroj/zephyr.git --mr nrf-flash-bt-issue (1 commit includes nrf_flash_bt_issue sample to reproduce this issue easily; other commits just add logs/workaround for the issue)
west update
west build -b nrf52840dk_nrf52840 zephyr/samples/nrf_flash_bt_issue
west flash
Attach console over UART to see logging messages
See warning messages from soc_flash_nrf_ticker module:

*** Booting Zephyr OS build zephyr-v3.1.0-3968-g5327d9c4dce5  ***
[00:00:00.254,211] <inf> bt: Bluetooth initialized
[00:00:00.254,730] <inf> bt: Advertising started
[00:00:00.255,035] <inf> main: Writing image
[00:00:03.225,189] <wrn> soc_flash_nrf_ticker: Unbalanced ticker take!
[00:00:07.756,134] <wrn> soc_flash_nrf_ticker: Unbalanced ticker take!
[00:00:12.634,948] <wrn> soc_flash_nrf_ticker: Unbalanced ticker take!
[00:00:19.488,311] <wrn> soc_flash_nrf_ticker: Unbalanced ticker take!
[00:00:19.813,903] <wrn> soc_flash_nrf_ticker: Unbalanced ticker take!
[00:00:22.749,450] <wrn> soc_flash_nrf_ticker: Unbalanced ticker take!
[00:00:31.069,976] <inf> main: Image written
[00:00:31.159,362] <inf> main: Image flushed
[00:00:31.159,362] <inf> main: Rebooting

Referenced branch already contains some workarounds and warning log messages that point out the problem and try to mitigate the problem. However checking out (git checkout ...) at the first commit in this branch, which is samples: nrf_flash_bt_issue: reproduce BT+Flash ticker/mayfly issue and rebuilding results in Zephyr crashes as shown below (those crashes are not as consistent as the warning messages generated, i.e. system crashes with approx 20% rate):
*** Booting Zephyr OS build zephyr-v3.1.0-3970-gb891918b9259  ***
[00:00:00.398,040] <inf> bt: Bluetooth initialized
[00:00:00.398,559] <inf> bt: Advertising started
[00:00:00.398,864] <inf> main: Writing image
[00:00:23.057,220] 00:23.057,250] <wrn> main: Failed to write image: -140
[00:00:23.058,807] <err> STREAM_FLASH: flash_write error -140 offset=0x000b6e00
[00:00:23.058,807] <wrn> main: Failed to write image: -140
[00:00:23.060,333] <err> STREAM_FLASH: flash_write error -140 offset=0x000b6e00
[00:00:23.060,333] <wrn> main: Failed to write image: -140
[00:00:23.061,614] <err> STREAM_FLASH: flash_write error -140 offset=0x000b6e00
[00:00:23.061,828] <wrn> main: Failed to write image: -140
[00:00:23.063,110] <err> STREAM_FLASH: flash_write error -140 offset=0x000b6e00
[00:00:23.063,110] <wrn> main: Failed to write image: -140
[00:00:23.064,636] <err> STREAM_FLASH: flash_write error -140 offset=0x000b6e00
[00:00:23.064,636] <wrn> main: Failed to write image: -140
[00:00:23.066,070] <err> STREAM_FLASH: flash_write error -140 offset=0x000b6e00
[00:00:23.066,070] <wrn> main: Failed to write image: -140
[00:00:23.067,352] <err> STREAM_FLASH: flash_write error -140 offset=0x000b6e00
[00:00:23.067,382] <wrn> main: Failed to write image: -140
[00:00:23.068,359] <err> os: ***** USAGE FAULT *****
[00:00:23.068,389] <err> os:   Illegal use of the EPSR
[00:00:23.068,389] <err> os: r0/a1:  0x20006ff4  r1/a2:  0x00000000  r2/a3:  0x00000002
[00:00:23.068,420] <err> os: r3/a4:  0x20006fd0 r12/ip:  0x00000001 r14/lr:  0x00016fb7
[00:00:23.068,420] <err> os:  xpsr:  0x2000001b
[00:00:23.068,450] <err> os: Faulting instruction address (r15/pc): 0x00000002
[00:00:23.068,450] <err> os: >>> ZEPHYR FATAL ERROR 0: CPU exception on CPU 0
[00:00:23.068,481] <err> os: Fault during interrupt handling

[00:00:23.068,481] <err> os: Current thread: 0x20000a08 (unknown)
[00:00:24.333,068] <err> os: Halting system

Expected behavior
There should be no warning messages about "unbalanced" k_sem_give/k_sem_take. Those messages just point out that one of the problems is that time_slot_callback_work() and/or time_slot_delay() are called even after nrf_flash_sync_exe() already finished execution. As a result, in body of time_slot_callback_work() callback, there is context pointer dereferenced as struct flash_op_desc *op_desc with rc = op_desc->handler(op_desc->context); code line. As struct flash_op_desc is created on thread stack (https://github.com/zephyrproject-rtos/zephyr/blob/fda3f54002408f7cb5a28285b89ce3fd9300f238/drivers/flash/soc_flash_nrf.c#L299 or https://github.com/zephyrproject-rtos/zephyr/blob/fda3f54002408f7cb5a28285b89ce3fd9300f238/drivers/flash/soc_flash_nrf.c#L317), which tries to write/erase flash, this stack variable might no longer be valid (stack might get unwound at this point).
Impact
Showstopper for using Bluetooth (at least in advertisement "state") and flash write/erase at the same time. This means that any device built around nrf5* board that uses Bluetooth and allows to operate on flash (like saving settings, doing firmware upgrade, etc) is potentially buggy.
Environment (please complete the following information):

OS: Linux
Toolchain: Zephyr SDK 0.15.0-beta2 (but issue was reproducible with older SDKs as well)
Commit SHA or Version used: tip of main (32a87215d7aa97191097357f602237f7da4a3536), 3.1.0; probably 3.0.0, 2.7.0 (did not confirm that)

Additional context
This issue references a minimal sample application that allows to reproduce this issue. This sample application does following things that seem important to reproduce this issue:

Bluetooth advertisements enabled,
Flash erase/write from application thread,
Some (in this example k_timer) interrupts firing in the background.
(optional, but improves reproducibility rate) CONFIG_IMG_ERASE_PROGRESSIVELY=y option enabled

The real problem is with downstream application, that uses nrf52840 + esp-at WiFi driver. System crashes when saving new firmware during DFU (Device Firmware Upgrade) downloaded over WiFi. In this application, there are no k_timer interrrupts triggered, but instead a lot of UART RX interrupts, which are the result of downloading big payload (new firmware) using esp-at WiFi driver.

@mniestroj I would like you to check somethingL
Use lower priorities for other SoC peripherals used in your application by having the below
#define NRF_DEFAULT_IRQ_PRIORITY 5
inside your application folder in dts/arm/nordic/override.dtsi file.
and then check the zephyr.dts file, the interrupt priorities should be 5 instead of 1.
Meanwhile, I will try to reproduce it at my end today.

@mniestroj Thank you for providing a simple sample, it has helped me reproduce the issue, and here is the fix #49791. Please verify and revert back.


Replace XML codeblock spaces with tabs

XML files use tabs for base indentation and spaces for codeblock indentation. This mixup makes it annoying to write code examples, because you have to add spaces manually, which is very error-prone.
This PR makes codeblocks use tabs.

https://github.com/godotengine/godot/blob/7a42afbba050822a66ea5b4c620f6db1b98c49af/modules/mono/editor/bindings_generator.cpp#L162-L169
This needs an update as well (to not remove the tabs).

I think breaking class ref docs PRs once for increased QoL for everyone forever is worth it. Currently, it would impact ~80 docs PRs at most, not nothing, but IMO not catastrophic to rebase those.
Translations are harder for me to judge. Would it result in affected translations being marked as "source changed, please review/update", would those lines still show up in the mean time? Or would it invalidate all affected lines and basically everything would need to be re-"translated"/ confirmed on Weblate to show translations again? Can we automate this?
How many translations do we currently have that are reasonably complete for the class ref? I can't gauge at all how much work this would cause.

Because KoBeWi is a lead contributor I can see merit in at least ensuring the other documentation PRs are merged before this.

Translations are harder for me to judge. Would it result in affected translations being marked as "source changed, please review/update", would those lines still show up in the mean time?

Yes to both. Because this is about spacing I feel like a majority of translated code samples would no longer display correctly, at least in the built-in docs. Preferably this PR should still make "4 spaces" a viable way to indent code, for compatibility, at least for the time being.
But if not, it's worth considering what other "non-retrocompatible" changes could be made now (e.g. support of [ul]/[ol]), so that at least they're done all at once and feel more justifiable.

Fixed mono.

Because KoBeWi is a lead contributor I can see merit in at least ensuring the other documentation PRs are merged before this.

Rebasing over this change is easy, because you can overwrite with your changes and manually replace indentation.

In that case, I'd make whether we merge this PR dependent on whether we can do that with the PO files, because otherwise this indeed seems a bit harsh on translators otherwise. Can someone else (me or someone here) edit the PO files and you just review + do the sync (as that seems like a destructive action) so we don't spend your time on this? :)

I would have to document how to sync https://github.com/godotengine/godot-editor-l10n properly as this needs to be done mid sync:

Freeze Weblate translations
Pull from Weblate
==> Do the fixes for spaces vs tabs <==
Sync with Godot
Push to Weblate
Reset Weblate repo
Unfreeze Weblate

And this needs to be done fast or translators will complain that Weblate is frozen :P

I'll look into that for now, and also will see if we can get those 80 PRs down a bit before we move further with this PR.

Removed the additional reviews as nothing content-wise changed in the documentation. Pushing to implement this PR as soon as possible.

To be it does sound easier to transition to tabs all at once, although it's probably because it links back to a personal goal I'd like to explore by 4.4.
If we have to somewhat "break compatibility" and make it more difficult to cherry-pick class reference, it would be nice to do it in one sweep. Although keeping support for 4 spaces for at least one version doesn't sound like a terrible idea.

However, this is going to break translations everywhere.

Isn't there a way around this? akien-mga wrote above that we could freeze Weblate, merge this PR, do some manipulations with the localization repository and Weblate, then unfreeze Weblate. This way translators would be spared the need to manually change spaces to tabs.
By the way, one more question. While this change is definitely good for contributors since we get rid of mixed indentation, won't it create a problem for translators? Browsers don't support tabs by default, even in <textarea> (instead, the Tab key always moves focus to the next interactive element). Probably not, since indentation only exists in code blocks that translators are unlikely to actively edit, just to be sure.

Yeah tabs pretty much only exist in code blocks. Also, even if you want to edit codeblock, you can just copy the original and apply your changes, so you don't need to touch indentation.
It is possible to write tabs in browser, but it's inconvenient. On Windows you can use Alt+09 to insert a tab, then copy/paste it to add more tabs easier.

By the way, one more question. While this change is definitely good for contributors since we get rid of mixed indentation, won't it create a problem for translators?

Having managed to get the Italian class reference from 2% to 92% all on my own,
For the most part there's a lot of copy-pasting done for translations. Entire code blocks are copied, pasted, then translated if absolutely needed. Changing code examples outside of comments or names is very ill-advised (for perhaps obvious reasons).
Even then, if necessary, Weblate allows you to write a tab character manually.

Isn't there a way around this? akien-mga wrote above that we could freeze Weblate, merge this PR, do some manipulations with the localization repository and Weblate, then unfreeze Weblate. This way translators would be spared the need to manually change spaces to tabs.

Absolutely, that's the idea. But someone has to do it in due time.


Problem with Web UI classpath?

Hello, I am very much a Scala newbie, so I apologize if this is an inappropriate question for this tracker. I was able to build CM-Well and mostly (g) to start it up. But after building up most of its components after a pe install I ran into a missing method:
Info:     Web Service boot in progress ()
Info:   waiting for ws...
java.lang.NoSuchMethodError: akka.util.Helpers$.toRootLowerCase(Ljava/lang/String;)Ljava/lang/String;
  at akka.stream.StreamSubscriptionTimeoutSettings$.apply(ActorMaterializer.scala:518)

and instead of getting the Web UI at localhost:9000 I got the message Infoton not found.
I would appreciate any advice on where to start debugging this-- I can find a number of akka-actor JARs in the project after building, and I believe that akka-actor is the library in question, but I'm not quite sure which ones are in use or how that is determined.

This is a known & annoying issue. The install process levreges the scala REPL, which loads on the classpath the jars on your local scala installation lib dir. One of this jars is akka-actor, and this results in the issue you describe. A quick workaround is to simply delete the jar from the scala installation dir.
Maybe we should consider using another REPL library (ammonite?).

@ajs6f if you haven't seen it before, check out the building tutorial which touches on the Akka conflict.

That did it, guys, thanks very much!


fix: JVM_ARGS should be parameterised and configured on jmeter pods

Setting the JVM_ARGS env in pods get reflected in jmeter process.


Dimensionality of key and values for Attention

I have two questions about the key and value calculation in Attention (and similarly for KNNAttention).
The relevant line is:
https://github.com/lucidrains/memorizing-transformers-pytorch/blob/83fa1479d6f7881dd977fbff55681e709e3b250e/memorizing_transformers_pytorch/memorizing_transformers_pytorch.py#L135

Why is there only one Linear layer to_kv, instead of 2 linear layers to_k and to_v?
Why is the last dimension dim_head*2? I get that *2 is for both k and v, but what about dim_head? I thought q, k, v should all have the same final dimension (i.e. inner_dim==dim_head*heads). My understanding is that this means that either a) there is only 1 attention head, or for b) all heads, k and v are shared. Is there a reason this is done, or am I misunderstanding?

In your Attention class for Performer, q, k, v all have the same dimensions.
Thanks in advance!

I guess this commit cites the paper that does 1 headed attention:
https://github.com/lucidrains/memorizing-transformers-pytorch/commit/9f77fd5e4e449d70c02b9cd25a98e1d5ef5f0a72

@manestay yup, one headed key / values is an old Noam Shazeer paper seeing a resurgence in usage by LLMs such as Alphacode and the 500B parameter PaLM model

Thanks! What about this question:
Why is there only one Linear layer to_kv, instead of 2 linear layers to_k and to_v?

@manestay it comes out to be faster if you do one matrix multiplication and then break it up later

I see, thanks!
An unrelated question, just to confirm my understanding, regarding the following line:
https://github.com/lucidrains/memorizing-transformers-pytorch/blob/83fa1479d6f7881dd977fbff55681e709e3b250e/memorizing_transformers_pytorch/knn_memory.py#L153
Can I ask why we have num_indices (i.e. batch_size) number of KNN objects for each KNNMemory? What does each KNN hold that is different from the other ones? And how does this interact with KNNMemory.add and KNNMemory.search, which will add/search each key/query to a different KNN?
Thanks in advance again.

To provide more context of the KNNMemory.add function, here's an example on my understanding:
https://github.com/lucidrains/memorizing-transformers-pytorch/blob/83fa1479d6f7881dd977fbff55681e709e3b250e/memorizing_transformers_pytorch/knn_memory.py#L201
Suppose we have in the batch (size=4) the key vectors corresponding to the sentences:
<s> hello
<s> goodbye and
<s> ok .
<s>

When the above line is called, it will add each key to a different KNN. So I don't get why this is the case -- don't we want all of the keys in the memory? If we have in a later batch a query vector corresponding to <s> goodbye and good, it seems that the most relevant entry is in the 2nd KNN. But we have no guarantee that this query will be in the 2nd position of the batch.
Is my above understanding correct? If so, then I don't see why we have multiple memories, as the paper did not mention that. If not, then please correct me. Thank you.

@manestay I think Figure 3 in the paper answers your question. Each batch appears to steam documents to maintain a consistent within-document memory. And then, a batch of size B contains chunks from B distinct documents that each have their own memory.

@manestay I think Figure 3 in the paper answers your question. Each batch appears to steam documents to maintain a consistent within-document memory. And then, a batch of size B contains chunks from B distinct documents that each have their own memory.

Okay, I see what you're saying. I was having some trouble interpreting this figure, but your explanation makes sense. Thanks!
I guess I was confused by the train.py script in this repo, since it doesn't handle document level stuff, just loads enwik8 sequentially in chunks. But I do see that this is a WIP repo, so maybe that is yet to be implemented. Appreciated once again!


[SDL-0192] Button subscription response from hmi

This PR is ready  for review.
Summary
Remove redundant registerComponent 'Buttons.OnButtonSubscription'
for testing feature "SDL-092 Button Subscription response from HMI"
Changelog

removed registerComponent 'Buttons.OnButtonSubscription'

@jordynmackool this PR is ready for review and is approved by Ford.


Update doc

Part of the support team reviewing the documentation

@scanum does closing mean the change will be manually part of another branch update?

Hi @wobba Hope all is doing well. Could youn please review the copy review and confirm the changes if you approve?

Looks good to me 👍

@SerdarSoysal
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Add hybrid cryptosystem mode to confidential transaction execution

Description

Currently fabric uses Public-key cryptosystems to encrypt and decrypt transaction data (chaincode ID, payload, metadata).
Whenever each transaction is executed with confidential mode, 4 step process is done.

public key(P1) and private key(P2) are created.
Transaction data is encrypt with public key(P1), besides private key(P2) is encrypt with public key(P3) of chain key and transferred to Peer.
Peer get private key(P2) by decrypting message with private key(P4).
Peer get transaction data by decrypting message with private key(P2).

Generally Public-key cryptosystems are used to skip sharing a key between the sender and the receiver.
However it takes long time to process message than symmetric-key cryptosystems.
If we add hybrid cryptosystem mode, transaction processing time will reduce.
This mean that Common-key cryptosystems is used to encrypt and decrypt transaction data.
Besides, Public-key cryptosystem are used to encrypt and decrypt common key which is used to encrypt transaction data.
Transaction process will change as follows.

Common key(C1) is created.
Transaction data is encrypt with common key(C1), besides common key(C1) is encrypt with public key(P3) of chain key and transferred to Peer.
Peer get common key(C1) by decrypting message with private key(P4).
Peer get transaction data by decrypting message with common key(C1).

Describe How to Reproduce

N/A. It's a suggestion to add new encryption method.

@yuki-kon we've migrated to using Jira for issue tracking, please open an issue there and close this one. You'll need a Linux Foundation ID to login.
Thanks


Discussion: Gorilla websockets are in read-only mode

Hey I was wondering if there would be any reason to change out the websockets library that discordgo uses since gorilla is no longer maintained.
If yes, I'd be able to work on the changes around May/June as I am currently finishing University and have quite a heavy workload

The repo has been unarchived 2 weeks ago and there's an open PR to update things at https://github.com/gorilla/websocket/pull/840. Perhaps this won't be necessary anymore https://github.com/gorilla/.github/commit/a3cb1a368388c609a1fac39b4bd7646ad27d3a6e
On the other hand it looks like it will only support recent go versions (1.19 and 1.20) while this library is still supporting 1.13.


where are user statistics api calls?

on Web UI there is this statistics window

I couldnot find anything on qbittorrent wiki page,google doesnot show anything useful and in chromium nothing shows up except jsut the HTML of that window.
so here I am after 2 hours of research and nothing.
how can I get that values?

https://github.com/qbittorrent/qBittorrent/blob/4259b4571ceb962a778a0bdce803c6e7600e726c/src/webui/www/private/scripts/client.js#L731-L744
Looking at the WebUI source, this panel displays information from the maindata syncing endpoint.  With this library, you would collect QBittorrentClient.syncMainData() and read the relevant fields from MainData.serverState.
Currently serverState is represented as a JsonObject? so you'll have to extract each field manually, see the WebUI for field names/types.  A statically typed data model for serverState would be appreciated if you'd like contributing one :).