[Bulk] Validation: Fixed HTML issues in skypedocs

This PR fixes 30 disallowed HTML attribute issues.

Docs Build status updates of commit 59f3195:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/UCMA/extending-the-call-class.md
:bulb:Suggestion

Details

Skype/UCMA/media-stack-performance-counters.md
:bulb:Suggestion

Details

Skype/UCMA/operations-performance-counters.md
:bulb:Suggestion

Details

Skype/UCMA/personas.md
:bulb:Suggestion

Details

Skype/UCMA/planning-performance-counters.md
:bulb:Suggestion

Details

Skype/UCMA/privacy-management.md
:bulb:Suggestion

Details

Skype/UCMA/extending-the-call-class.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.
Line 18, Column 127: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/dotnet/api/microsoft.rtc.collaboration.audiovideo.audiovideocall?view=ucma-api' will be broken in isolated environments. Replace with a relative link.
Line 18, Column 127: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.rtc.collaboration.audiovideo.audiovideocall?view=ucma-api. Otherwise, remove the view parameter.
Line 18, Column 536: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/dotnet/api/microsoft.rtc.collaboration.call?view=ucma-api' will be broken in isolated environments. Replace with a relative link.
Line 18, Column 536: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.rtc.collaboration.call?view=ucma-api. Otherwise, remove the view parameter.
Line 18, Column 630: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/dotnet/api/microsoft.rtc.collaboration.componentmodel.mediaprovider?view=ucma-api' will be broken in isolated environments. Replace with a relative link.
Line 18, Column 630: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.rtc.collaboration.componentmodel.mediaprovider?view=ucma-api. Otherwise, remove the view parameter.
Line 18, Column 761: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/dotnet/api/microsoft.rtc.collaboration.componentmodel.mediaflow?view=ucma-api' will be broken in isolated environments. Replace with a relative link.
Line 18, Column 761: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.rtc.collaboration.componentmodel.mediaflow?view=ucma-api. Otherwise, remove the view parameter.
Line 62, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 77, Column 17: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/dotnet/api/microsoft.rtc.collaboration.call.handletransfernotificationreceived?view=ucma-api' will be broken in isolated environments. Replace with a relative link.
Line 77, Column 17: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.rtc.collaboration.call.handletransfernotificationreceived?view=ucma-api. Otherwise, remove the view parameter.
Line 82, Column 17: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/dotnet/api/microsoft.rtc.collaboration.call.handletransferreceived?view=ucma-api' will be broken in isolated environments. Replace with a relative link.
Line 82, Column 17: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.rtc.collaboration.call.handletransferreceived?view=ucma-api. Otherwise, remove the view parameter.

Skype/UCMA/media-stack-performance-counters.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Skype/UCMA/operations-performance-counters.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Skype/UCMA/personas.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Skype/UCMA/planning-performance-counters.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.
Line 22, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 23, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 70, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 71, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 118, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 119, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 166, Column 6: [Suggestion: disallowed-html-attribute - See documentation] HTML attribute 'style' on tag 'col' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

Skype/UCMA/privacy-management.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.
Line 86, Column 430: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/dotnet/api/microsoft.rtc.collaboration.userendpoint?view=ucma-api' will be broken in isolated environments. Replace with a relative link.
Line 86, Column 430: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.rtc.collaboration.userendpoint?view=ucma-api. Otherwise, remove the view parameter.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 2251205:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/UCMA/extending-the-call-class.md
:bulb:Suggestion

Details

Skype/UCMA/privacy-management.md
:bulb:Suggestion

Details

Skype/UCMA/media-stack-performance-counters.md
:white_check_mark:Succeeded

Skype/UCMA/operations-performance-counters.md
:white_check_mark:Succeeded

Skype/UCMA/personas.md
:white_check_mark:Succeeded

Skype/UCMA/planning-performance-counters.md
:white_check_mark:Succeeded

Skype/UCMA/extending-the-call-class.md

Line 19, Column 127: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /dotnet/api/microsoft.rtc.collaboration.audiovideo.audiovideocall?view=ucma-api. Otherwise, remove the view parameter.
Line 19, Column 484: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /dotnet/api/microsoft.rtc.collaboration.call?view=ucma-api. Otherwise, remove the view parameter.
Line 19, Column 552: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /dotnet/api/microsoft.rtc.collaboration.componentmodel.mediaprovider?view=ucma-api. Otherwise, remove the view parameter.
Line 19, Column 657: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /dotnet/api/microsoft.rtc.collaboration.componentmodel.mediaflow?view=ucma-api. Otherwise, remove the view parameter.
Line 78, Column 17: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /dotnet/api/microsoft.rtc.collaboration.call.handletransfernotificationreceived?view=ucma-api. Otherwise, remove the view parameter.
Line 83, Column 17: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /dotnet/api/microsoft.rtc.collaboration.call.handletransferreceived?view=ucma-api. Otherwise, remove the view parameter.

Skype/UCMA/privacy-management.md

Line 87, Column 430: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /dotnet/api/microsoft.rtc.collaboration.userendpoint?view=ucma-api. Otherwise, remove the view parameter.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit aecfbd2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/UCMA/extending-the-call-class.md
:white_check_mark:Succeeded

Skype/UCMA/media-stack-performance-counters.md
:white_check_mark:Succeeded

Skype/UCMA/operations-performance-counters.md
:white_check_mark:Succeeded

Skype/UCMA/personas.md
:white_check_mark:Succeeded

Skype/UCMA/planning-performance-counters.md
:white_check_mark:Succeeded

Skype/UCMA/privacy-management.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@lindalu-MSFT
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you’d like to see. Thank you!

Docs Build status updates of commit 43e167b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/UCMA/extending-the-call-class.md
:white_check_mark:Succeeded

Skype/UCMA/media-stack-performance-counters.md
:white_check_mark:Succeeded

Skype/UCMA/operations-performance-counters.md
:white_check_mark:Succeeded

Skype/UCMA/personas.md
:white_check_mark:Succeeded

Skype/UCMA/planning-performance-counters.md
:white_check_mark:Succeeded

Skype/UCMA/privacy-management.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit a536700:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/UCMA/extending-the-call-class.md
:white_check_mark:Succeeded

Skype/UCMA/media-stack-performance-counters.md
:white_check_mark:Succeeded

Skype/UCMA/operations-performance-counters.md
:white_check_mark:Succeeded

Skype/UCMA/personas.md
:white_check_mark:Succeeded

Skype/UCMA/planning-performance-counters.md
:white_check_mark:Succeeded

Skype/UCMA/privacy-management.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Issue with pulling nodal stress from rst file

Before I'd actually start describing  issue I'd like to compliment author's work - pyAnsys is truly amazing tool, great job ! I have some experience in APDL and I'm relatively new to python, but still setting up pyansys took me significantly less time than developing APDL script.
Anyway, there are two things I'd like to comment:

is there a plan to include other result components ? At this moment I'm looking for nodal principal stress - I know I can achieve that by applying laws of mechanics to stress components in python (and I might end up doing that), but it would nice have them directly from ansys.

I'm trying to read whole RST and rewrite it to text file with 10 columns (node ID, XYZcoord, stress components). I've executed following code:
`
import pyansys
import numpy
result=pyansys.ResultReader('myRstfile.rst')
nnum = result.nnum
disp = result.GetNodalResult(0)
stress = result.NodalStress(0)
print ("Nodes size: " + str(numpy.shape(nnum)))
print ("Displ size: " + str(numpy.shape(disp)))
print ("Stress size: " + str(numpy.shape(stress)))
'

and as a result I've received:
Nodes size: (727562,)
Displ size: (727562, 3)
Stress size: (554638, 6).
First two look as I expected, third is surprising: how come row count is different ?
Thank you in advance,
Kind Regards,
Pawel.

Thanks for the kind comments about the code!  We used to use MATLAB and python to read in results from text results outputted from ANSYS and found it was much easier to directly read them from the binary file, especially when visualizing.
To answer your questions:

ANSYS doesn't store principle stresses in the result file.  These are computed in ANSYS upon request.  Only a few results are actually stored in the result file and many results, such as principle stress, are computed from data stored in the result file as this keeps the result file size down.  I'l add in code that computes these quickly for the next version in a week or two.  If you need it right now, follow the code in the website below:
https://robsiegwart.com/principal-stresses-in-3d/

Nodal stress is computed by evaluating stress at the elements and averaging those strains in the same manner as ANSYS for the edge nodes.  What you're seeing is the stress only at the edge nodes and not at mid-side nodes.  ANSYS computes displacement at mid-side nodes (based on the solution of the eigensolution), but stress is only evaluated at the edge nodes (which is what you'd get from ANSYS as well).

Here's the documentation explaining this:
http://pyansys.readthedocs.io/en/latest/loading_results.html#accessing-solution-results
http://pyansys.readthedocs.io/en/latest/loading_results.html#pyansys.ResultReader.NodalStress

Thanks a lot for the prompt reply. So regarding point 2: let's say I want to export nodes and corresponding stress components for edge nodes only. How do I do that ? I don't see a way to tell which row in nodeIDs array correspond to which row in stress array.

Oops, I've just read documantation again and found answer. Thanks a lot!

Could you post the section where you found that?  It might be helpful for other users to have that.  I'll also spell that out more in the function doc string.

Added principal stress computation.  See the latest release 0.21.0


[Bug] Factorise get_commodity_id in api.py

Rework get_commodity_id to use fetch_data in api.py
This way we are sure cache is properly used.
Make sure fetch_data is properly try/catching exception like get_commodity_id used to.

Also create a generic post_data that will be used by perform_trade.
In this POST you have to make sure is_production is properly passed from ConfigManager


recurrent events now break plugin completely. What has changed?

For the last five days, the plugin has been horrible broken: it finds huge numbers of recurrent events from past years ands spews them into my daily note, complaining about "Invalid date" — this with a template that was working perfectly well before Christmas.
Using this template fragment (adjusted to fit the way I name my diaries):
<%*
var events = await app.plugins.getPlugin('ics').getEvents(moment(tp.file.title,'DD MMMM YYYY - dddd'));
if (events.length) {
    tR+= `>[!Danger]- Today's Schedule\n`
    events.sort((a,b) => a.utime - b.utime).forEach((e) => {
        const calendar = e.icsName.replace(" ","-");
        const callUrl = e.callUrl? ` [${e.callType}](${e.callUrl})` : '';
        const location = e.location? ` 📍 *(${e.location})*` : '';
        tR+=`- [ ] ${e.time}-${e.endTime} **${e.summary}**${location}${callUrl} #${calendar}\n`
        if (e.description) {
            const inlineDescription = e.description.replace(/(?:\r\n|\r|\n)/g," ").replace(/\s{2,}/g," ");
            tR+=`    - ${inlineDescription}\n`
        }
    })
}
%>

I get hundreds of lines complaining of "Invalid date" in recurring events that have long since passed, and don't in any case affect today:
like this:
# testing ICS
- [ ] Invalid date-Invalid date **Mary Heley** 📍 *(XXXXXX)* #seatrout
  {Repeat 17 times}

- [ ] Invalid date-Invalid date **Renew prescription** #seatrout
- [ ] {repeat 164 times}

- [ ] Invalid date-Invalid date **RMC editorial meeting** 📍 *(zoom see below)* #seatrout
 { repeat 12 times}

 ... and so on, some of these errors going back *20 years*

I have tried this with a conventionally named date template too: it is clearly something in the handling of recurrent events in the plugin.

Looking at the console, there are 983 messages from the plugin (no errors) — of which this is a typical fragment :
Cloned event: Object
plugin:ics:22 Found a recurring event to clone:  Ann the cleaner  on  Invalid Date at  Wed Jan 12 2022 11:30:00 GMT+0000 (Greenwich Mean Time)
plugin:ics:22 RRULE origOptions: Object
plugin:ics:22 Event rrule.origOptions.tzid: Europe/London
plugin:ics:22 Cloned event: Object
plugin:ics:22 Found a recurring event to clone:  Ann the cleaner  on  Invalid Date at  Wed Jan 12 2022 11:30:00 GMT+0000 (Greenwich Mean Time)
plugin:ics:22 RRULE origOptions: Object
plugin:ics:22 Event rrule.origOptions.tzid: Europe/London
plugin:ics:22 Cloned event:

Thanks for the report. When I moved the repo I updated the node-ical package. That likely broke the recurring rule parsing.
My apologies. You can try the previous release of you'd like while I revert the dependency upgrade in the next few hours.

Likely culprit: https://github.com/cloud-atlas-ai/obsidian-ics/commit/1469250ff8f679eba268f39aedd490eb6f95eb27
Which leads to https://github.com/jens-maus/node-ical/issues/291

Reverting back to 0.16.1

@seatrout - what calendar providers are you using? I'm trying to reproduce the issue and I don't see the issue with Google Calendar feeds.

I tried 0365 calendars too without being able to reproduce.
From looking at the provided screenshot I see APPLE-TRAVEL-ADVISORY-BEHAVIOR which I believe is an Apple specific calendar entry, will see if I can create an iCloud hosted calendar.

I'm using Google. I don't know where the Apple thing came from, except that one of these Google calendars is shared with my wife, who does keep an Apple calendar.

The "RMC Editorial meetings" may also be shared with people who use Apple providers. But most of the calendars referenced in the file are Google, even if they are shared.

Do shared calendars put out a different ICS feed/ That seems very unlikely to me, but what would I know?

You are correct, they should not be any different.
@seatrout - can you try the release before the update? https://github.com/cloud-atlas-ai/obsidian-ics/releases/tag/1.5.0 . Replace main.js in your <vault>/.obsidian/plugins/ics with the one at that release and then import the day's events again. Thanks!

@seatrout - can you try the release before the update? https://github.com/cloud-atlas-ai/obsidian-ics/releases/tag/1.5.0 . Replace main.js in your <vault>/.obsidian/plugins/ics with the one at that release and then import the day's events again. Thanks!

Oh, and you'll need to restart Obsidian before trying to re-import

Yay! That works again. Thank you — what exactly changed to break things?
Anyway, thank you so much for fixing this so quickly.

Yay! That works again. Thank you — what exactly changed to break things? Anyway, thank you so much for fixing this so quickly.

I haven't changed anything yet. ;)
1.5.0 works for you?

Just to confirm: 1.50 works again, yes.
(That Obsidian is taking minutes to reload — presumably to rebuild — its cache files when restarted is not your problem)

So it was the update in node-ical  which broke this?

So it was the update in node-ical which broke this?

I believe so, which in turn pulled in changes to rrule.
I'd rather not revert to 0.16.1 as it's showing a dependency on a vulnerable axios:
node_modules/axios
  node-ical  0.14.0 - 0.16.1
  Depends on vulnerable versions of axios
  node_modules/node-ical

I am exploring other options now, would love help testing once I get an idea...

k, looks like I can lock rrule to a previous version even while updating node-ical... Testing that locally.

Happy to help test this
But when I look at these complications and dependencies I am so glad I am not a developer.

@seatrout , https://github.com/cloud-atlas-ai/obsidian-ics/releases/tag/1.5.1-lockrrule3 works for me locally (but I never suffered the breakage). In this release I keep the update to node-ical but lock rrule to 2.6.6.
Hoping this no longer shows the erroneous recurring events for you when you try it. You'll replace the main.js again, restart and then try again.
Thanks!

One more https://github.com/cloud-atlas-ai/obsidian-ics/releases/tag/1.5.1-lockrrule4 - this uses the last rrule 2.6.8 release on the 2.6 version.

But when I look at these complications and dependencies I am so glad I am not a developer.

It's all part of the cost of being able to make computers do all the things they do. ;)

Actually, I realized that the above build still had the older axios dependency.
@seatrout : Please let me know if the latest, https://github.com/cloud-atlas-ai/obsidian-ics/releases/tag/1.5.3 release maintains the fix and we can close this. If you're still seeing it, I am sure we can find some other solution...

Is it only main.js that's changed and needs replacing?

Yes. if you want the version number to show up correctly that's in manifest.json

The 1.5.3 version works, both when there is an event that day, whether it recurs or not, and when there are none. Thank you so much.

Thanks for the report and helping test. I wish I could reproduce the issue so I can test against whatever is going wrong in future releases.
For now I'll count on you and other users to let me know if the issue comes back. ;)

Everything still works, and I am still grateful :-)
But in the night I thought of a reason that you might not have been able to reproduce this bug: all of the problems I can remember were expired sequences of recurring events. Recurring events which are still recurring today didn't, so far as I can remember, trigger the bug. But eg "Ann the cleaner" (from my example upthread) no longer comes to clean, so all her end dates showed up as invalid. I think that's it, anyway.

Everything still works, and I am still grateful :-)

😌 , phew, I was worried the issue came back the next day when I saw the email notification!

a reason that you might not have been able to reproduce this bug: all of the problems I can remember were expired sequences of recurring events.

Thanks @seatrout , I'll see if that helps in reporducing the issue.


Small inconsistant in the docs: src/app/ or app/?

Hi,
What docs page needs to be fixed?

Section: Using Redux/Setup and Organization
Page: Setup with Next.js
https://github.com/reduxjs/redux/blob/1ea45b97ec8ff998b4916a07b5239d5d60129028/docs/usage/nextjs.mdx#L210

What is the problem?
The page states that both /app and src/app work, but almost everything in the page uses /app, except that line. Is it just a small typo/inconstancy?
Thanks!

Just a typo.  That said, the Next CLI lets you either have all the folders like app and lib exist at the top level of the repo, or nested inside of src.

Thanks!


MINOR: Update RPC as per latest KIP spec.

Update Read, Write RPCs as per spec.
Rename ReadOffsets RPC to ReadStateSummary
Update all accompanying classes.

@apoorvmittal10 @adixitconfluent
Plz update calls in SharePartition to pass the correct leaderEpoch id.
I have added 0 currently for successful build.
lines: sharepartition: 726, 1325


Verify window hides behind the bottom

Hi!
If you go to the page and immediately open the form, then when the captcha is called, the window is displayed incorrectly and hides behind the bottom of the browser and user can't click verify button.

If you close the form, scroll up and down and open the form when the lower part of the browser is hidden, the captcha is displayed normally

Repo is just for PHP client issues. This is about the reCAPTCHA service.


Add heroku deployment support

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/apareciumlabs/gulp-static-seed/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #19   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines           6      5    -1
  Branches        1      1
=====================================
- Hits            6      5    -1

Impacted Files
Coverage Δ

src/scripts/global.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e7b800...dd1effb. Read the comment docs.


Hook insertion

Building on top of #1, a mechanism is required to insert function call hooks into the recompilation output. This will be mainly used to add overlay load hooks into games.
Hooks should provide a function name and the VRAM address of the instruction to insert the hook before. Hooks meant to be placed at the end of a function can provide the VRAM value of the instruction following the last one in the function. Hooks that omit an instruction VRAM address will be inserted at the start of a function, which will likely be the most common use case for hooks.

Addressed by #73


docs: add charts page

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type
What kind of change does this PR introduce?

[X] Documentation content changes
[X] clarity.design website / infrastructure changes

What is the current behavior?

no documentation for using clarity with charts
Issue Number: N/A

What is the new behavior?

adds Charts page under Foundation

Does this PR introduce a breaking change?

[X] No

Other information

work in progress

I changed the branch target to topics/chart so we can refine the content before release but also asking @mathisscott and @hippee-lee to help with a review next week so we can close this out in the interim.


Update sbt-scalajs, scalajs-compiler, ... to 1.5.1

Updates

org.scala-js:sbt-scalajs
org.scala-js:scalajs-compiler
org.scala-js:scalajs-library
org.scala-js:scalajs-test-bridge

from 1.3.1 to 1.5.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (1.3.1).
You might want to review and update them manually.
doc/changelog/0.2.6.md
doc/changelog/0.9.0.md

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-js" } ]

labels: library-update, semver-minor, old-version-remains

Superseded by #196.


Incorrect error reported when using class extends null and re-opening interface

🔎 Search Terms
class extends null interface
🕗 Version & Regression Information

This is the behavior in every version I tried (at least up until 3.3, which is the oldest build in the playground).

⏯ Playground Link
https://www.typescriptlang.org/play?lib=true&ts=5.1.6#code/JYOwLgpgTgZghgYwgAgEJwM4oN4CgC+uuCANphsgMLIQAekIAJhSAK4knJ7I-IID2IDGCisEYflAAUASi65eyQoVCRYiFNToNmaTDnxA
💻 Code
interface Base {
}

class C extends null {
    constructor() {
    }
}
interface C extends Base {}

🙁 Actual behavior
Reports the following error:
Class static side 'typeof C' incorrectly extends base class static side 'null'.

🙂 Expected behavior
No error. inteface Base does not describe the static side of anything, and reopening a class using something like interface C extends Base {} is common practice for shims.
Additional information about the issue
I ran into this when implementing a class that utilizes return override in a constructor when combined with class extends null while experimenting with the Shared Structs origin trial (whose constructors produce objects with a null prototype). Though native extends null has some issues in ES2015+, it still works fine with explicit return override in a constructor in any engine:
class C extends null {
  constructor() {
    return {};
  }
}
new C(); // works just fine.

hi @andrewbranch, if you haven't done it, could you let me try please, but if you can also give some tips on how to get to a possible solution


added Background with video

What is the change?
I created a responsive component with a video as background.
Related issue?
closes: #issue_number
How was it tested?
I tested the component in different browsers and differents viewports.
Checklist:
Before you create this PR, confirm all the requirements listed below by checking the checkboxes [x]:

[x] Have you followed the Contribution Guidelineswhile contributing.
[x] Have you checked there aren't other open Pull Requests for the same update/change?
[x] Have you made corresponding changes to the documentation?
[x] Have you tested the code before submission?
[x] Have you formatted your code ? (You can use any html,css beautifier)
[x] My changes generates no new warnings.
[x] I'm Hacktoberfest'21 contributor.
[ ] I have commented my code, particularly in hard-to-understand areas.

GIF/video of the working of component you created:
Add here the GIF you created

.

Next time open a issue first!

Thanks i will  do better next time


fix(json): fix typo

Found a small typo with checking if a string is blank,

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Inconsistent grid points when changing screens

Hi @hanspi42,
I wanted to thank you for creating this very useful software.
I've encountered an issue that I'd like to report. When I open a saved graph on a different PC with a different monitor and resolution, the snap grid is displaced, causing all nodes to shift out of alignment with the grid. This is a minor inconvenience, as I need to manually adjust each node to snap back into place with the new grid position every time I change computers.
Steps to reproduce:

Save a graph on one PC with a specific monitor and resolution.
Open the saved graph on a different PC with a different monitor and resolution.
Observe the grid displacement and node shifting.

Expected behavior: The grid and nodes should maintain their original positions and alignment, regardless of the PC or monitor used to open the graph.
Thanks for your attention to this issue!
Regards,
2nOrderEDO

Thanks! This is related to #5, and it unfortunately will force me to rewrite the whole graphics part.


Pass the implicit end time from the query executor to the select call

The select call and the query executor would both calculate the time
range, but in separate ways. The query executor needed some way to pass
in the implicit end time that is placed there by the query executor.
Fixes #5636.

@benbjohnson @jwilder

:+1:

Rebased and modified so the Select() calls from added tests match the new signature. I'll merge after it turns green.


Restricting custom domains to specific SSH keys

I am having some trouble setting up custom domains and restricting them to specific SSH keys.
For context this is my setup:

sish domain: t.hrsn.net - this is the domain used in the SSH command to connect to sish and is the default hostname when not using a custom domain (e.g. tunnel123.t.hrsn.net).
Custom domain: t.wdh.gg - this is the domain I'm trying to restrict to a specific SSH key. A CNAME record is configured for t.wdh.gg and *.t.wdh.gg pointing to t.hrsn.net.
Cloudflare proxy is disabled.
I am using Docker compose to host sish.

In my config file I have the following:
bind-any-host: false
bind-hosts: t.wdh.gg

Now, this config works and I can setup subdomains on t.wdh.gg like tunnel123.t.wdh.gg however even though I have a TXT record set at _sish.t.wdh.gg with the content:
SHA256:yQ2G5ra7npl6ROKw3BJQWULROIG37u14aMfbfKoWFqQ

Even though that TXT record is in place, anyone regardless if they are using that SSH key are able to use t.wdh.gg subdomains even though it should be restricted to that specific key.
I have tried the following, none of which worked:

Removing the bind-hosts key entirely, however when attempting to use a subdomain of t.wdh.gg like tunnel123.t.wdh.gg it would instead bind to tunnel123.t.wdh.gg.t.hrsn.net.
Removing the SHA256: bit from the TXT record, which did not work.
Using the old DNS configuration by creating the following TXT record at t.wdh.gg (attempted with and without the SHA256: bit):

sish=SHA256:yQ2G5ra7npl6ROKw3BJQWULROIG37u14aMfbfKoWFqQ

Please let me know how I can setup custom domains and restrict them using TXT records to specific SSH keys. Thanks!

Hey @antoniomika, no rush, but are you able to look into this? Thanks 😄

Are you using the main branch version? When I have that running and try to bind without the TXT being set to the current key, it will bind to a subdomain instead.

I'm using v2.16.0.

@EpicEric Are you able to share your config and exactly what you put in the TXT record?

The documentation referring to the _sish record is in accordance with this change, which hasn't been released in a tagged version yet. I believe you still need to use sish=SSHFINGERPRINT in your case.
I'm running sish with these options:
# compose.yml
services:
  sish:
    # ... snip ...
    image: docker.io/antoniomika/sish@main
    command: |
      --ssh-address=:22
      --http-address=:80
      --https-address=:443
      --authentication-keys-directory=/pubkeys
      --private-keys-directory=/keys
      --https-certificate-directory=/ssl
      --https-ondemand-certificate=true
      --https-ondemand-certificate-accept-terms=true
<EMAIL_ADDRESS>      --https=true
      --force-https=true
      --log-to-client=true
      --idle-connection=false
      --bind-random-aliases=false
      --bind-random-ports=false
      --bind-random-subdomains=false
      --bind-random-subdomains-length=6
      --http-load-balancer=true
      --tcp-load-balancer=true
      --alias-load-balancer=true
      --time-format=2006-01-02T15:04:05
      --domain=my.domain

I believe the only relevant command is --bind-random-aliases=false.

Even when using the Docker image you are using, no matter whether I'm using the old TXT record or new one, it still allows anyone to bind to it.
This is my full config:
authentication-keys-directory: "/pubkeys"
banned-subdomains: localhost, www
bind-any-host: false
bind-hosts: t.hrsn.dev,t.wdh.gg
bind-random-aliases: false
bind-random-ports: true
bind-random-subdomains: false
bind-random-subdomains-length: 12
domain: "t.hrsn.net"
http-address: "tcp://<IP_ADDRESS>:80,tcp6://[2604:4300:a:149::6d96:2e33]:80"
https: true
https-address: "tcp://<IP_ADDRESS>:443,tcp6://[2604:4300:a:149::6d96:2e33]:443"
https-certificate-directory: "/ssl"
port-bind-range: 1000-1999
private-keys-directory: "/keys"
redirect-root: true
redirect-root-location: https://hrsn.net/#tunnels
ssh-address: "tcp://<IP_ADDRESS>:2222,tcp6://[2604:4300:a:149::6d96:2e33]:2222"
tcp-address: "tcp://<IP_ADDRESS>,tcp6://[2604:4300:a:149::6d96:2e33]"

This is my Docker compose file:
services:
  sish:
    image: antoniomika/sish:main
    container_name: sish
    volumes:
      - /etc/letsencrypt:/etc/letsencrypt
      - ./pubkeys:/pubkeys
      - ./keys:/keys
      - ./ssl:/ssl
      - ./config.yml:/config.yml:ro
    command: |
      --config=/config.yml
    network_mode: host
    restart: always

It has to be from either of the user's key. Both generate the same fingerprint:

Yes.
Also yes.

A friend who's using sish has run into a similar issue, and --bind-any-hosts fixed it in his case, although the root cause couldn't be determined yet.

Actually, reading on the documentation for --bind-hosts, it seems that you must specify the root host, i.e. "Requested hosts should be subdomains of a host in this list". So perhaps changing it your config to bind-hosts: hrsn.dev,t.wdh.gg could do the trick.

A friend who's using sish has run into a similar issue, and --bind-any-hosts fixed it in his case, although the root cause couldn't be determined yet.

So I should set that option to true and remove the bind-hosts bit?
FYI, I intend to host subdomains on t.wdh.gg, not wdh.gg, (e.g. tunnel123.t.wdh.gg).

Alright, in that case you can leave that as is.
If you add force-requested-aliases: true to the config, does it give any errors?

You can leave that as is, then.

With the current implementation of verifyDNS, _sish.t.wdh.gg will only apply for t.wdh.gg, not any subdomains. The appropriate TXT entries would have to be added for each subdomain as well.
Going through the code, I believe the option you'll want is force-requested-subdomains: true. This should error when the user doesn't have the appropriate permission to bind to it.

I tried that option with both types of TXT records, and it didn't work, not sure why. I also tried both with and without bind-any-host enabled.
Is it possible that the TXT record verification system is just completely broken?

It definitely works for me, as it doesn't let me bind on a subdomain if the TXT is missing. I'm not really sure what else could be causing this issue, unfortunately.


Fix TileSize property

GridLayer.Size is incorrectly named and maps to a non-existent JS property (actual property is tileSize).

@Mehigh17 is there something you need to me amend to this PR? It seems to have fixed the issue on my end.
(In particular, a Mapbox layer was rendering very strangely before, and this seems to have been the cause.)

@Mehigh17 is there something you need to me amend to this PR? It seems to have fixed the issue on my end.
(In particular, a Mapbox layer was rendering very strangely before, and this seems to have been the cause.)

Thanks for the contribution. I did some cleanup through the project and forgot to merge this.


[WIP] _prepare_fsdp: keep optimizer's 8-bitness and pagedness when reconstructing optimizer

Fixes https://github.com/huggingface/accelerate/issues/1902
Mostly raising this draft so I have something to point at and so that the proposed solution doesn't get lost.
See the TODOs for why I wouldn't necessarily merge it as-is.

Hello, as mentioned in https://github.com/huggingface/accelerate/issues/1902#issuecomment-1697194776, this shouldn't be required when using the latest releases of Transformers and Accelerate. The important point to note here is that the recommended way when using FSDP is to prepare model before preparing optimizer as mentioned in the docs here https://huggingface.co/docs/accelerate/usage_guides/fsdp#a-few-caveats-to-be-aware-of:


Update tutorial-ingress-controller-add-on-existing.md

When you use an application gateway and its Virtual Network in a different resource group from the AKS cluster and node resource group MC_resource-group-name_cluster-name_location , the managed identity created ingressapplicationgateway-{AKSNAME} once this add-on is enabled in the AKS nodes resource group must have Contributor role set in the Application Gateway and its Virtual Network resource as well as Reader role set in the Application Gateway resource group.

Error message without Contributor role on Application Gateway Virtual Network
E1027 05:35:39.194604       1 controller.go:141] network.ApplicationGatewaysClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status= Code="ApplicationGatewayInsufficientPermissionOnSubnet" Message="Client with object id 72d4f7b3-04b5-433b-a4a0-397171a359fa does not have permission on the Virtual Network resource /subscriptions/68be2809-9674-447c-a43d-261ef2862c29/resourceGroups/m1rg/providers/Microsoft.Network/virtualNetworks/m1appgwvnet/subnets/default to perform action Microsoft.Network/virtualNetworks/subnets/join/action. For details on the required permissions, please visit https://aka.ms/agsubnetjoin." Details=[]
E1027 05:35:39.194759       1 worker.go:62] Error processing event.network.ApplicationGatewaysClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status= Code="ApplicationGatewayInsufficientPermissionOnSubnet" Message="Client with object id 72d4f7b3-04b5-433b-a4a0-397171a359fa does not have permission on the Virtual Network resource /subscriptions/68be2809-9674-447c-a43d-261ef2862c29/resourceGroups/m1rg/providers/Microsoft.Network/virtualNetworks/m1appgwvnet/subnets/default to perform action Microsoft.Network/virtualNetworks/subnets/join/action. For details on the required permissions, please visit https://aka.ms/agsubnetjoin." Details=[]
I1027 05:35:39.194617       1 event.go:282] Event(v1.ObjectReference{Kind:"Pod", Namespace:"kube-system", Name:"ingress-appgw-deployment-c85bbd76b-5bd8l", UID:"cd72c2a8-bd46-4e05-abd1-305606ab682d", APIVersion:"v1", ResourceVersion:"24409", FieldPath:""}): type: 'Warning' reason: 'FailedApplyingAppGwConfig' network.ApplicationGatewaysClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status= Code="ApplicationGatewayInsufficientPermissionOnSubnet" Message="Client with object id 72d4f7b3-04b5-433b-a4a0-397171a359fa does not have permission on the Virtual Network resource /subscriptions/68be2809-9674-447c-a43d-261ef2862c29/resourceGroups/m1rg/providers/Microsoft.Network/virtualNetworks/m1appgwvnet/subnets/default to perform action Microsoft.Network/virtualNetworks/subnets/join/action. For details on the required permissions, please visit https://aka.ms/agsubnetjoin." Details=[]

@greg-lindsay
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

@greg-lindsay - The existing and new text seems to be ungrammatical. Can you revise it (or tell us how to) to make sense or be more clear?
#hold-off

I will edit the grammar in another PR. #please-close

Changing this to:

[!IMPORTANT]
When you use an application gateway in a different resource group than the AKS cluster resource group, the managed identity ingressapplicationgateway-{AKSNAME} that is created must have Contributor and Reader roles set in the application gateway resource group.


ENH: update package version

Hi! This is the friendly automated conda-forge-webservice.
I've started a version update as instructed in #5.
I'm currently searching for new versions and will update this PR shortly if I find one! Thank you for waiting!
Fixes #5

@conda-forge-admin, please restart ci

Hi @BastianZim , In my haste, I messed up. I thought I was updating this PR, but instead committed a change directly into main from the web interface. I am working on cleaning it up.

No worries at all, that happens. Let me know if I can help!

Glad you asked ... lol. I have a Travis run that keeps failing at the test phase complaining that the _test_env can't be solved, would you know how to debug it?
https://app.travis-ci.com/github/conda-forge/sbcl-feedstock/builds/270822120

Oh God... Travis is a mess! Let me have a look.

In which PR is that happening? Travis can be generally fixed by re-rendering or restarting the job as many times as it takes to run successfully.

This PR, I used it quite a bit already. The fail does not say why the test environment can't be solved, but I need libc >=2.28 and zstd:
https://github.com/conda-forge/sbcl-feedstock/pull/16

Ahh hmm. I just pre-rendered it because that fixes many issues but I will have a look after that.

@conda-forge-admin, please rerender


docs(_footer): update copyright texts to 2016

Sorry this is my first PR if I did something wrong, let me know!

Handled by commit 21ad7eff11a2b53347b119ebcdebe3a01e2c7657.  Thanks for helping though


Enable DPRReaderRanker to copy meta information to the matches.

As a user of DRPReaderRanker, I would like to copy meta information to the matches besides the text.
We have some prototype in the video search QA example, https://github.com/jina-ai/example-video-qa/blob/main/executors.py#L106-L285.
After this task is done, we need to use jinahub+docker://DPRReaderRanker in the example-video-qa.
TODO:

[x] migrate DPRReaderRanker to a single repo
[x] add support to copying arbitrary meta information

Migrated to https://github.com/jina-ai/executor-text-transformers-dprreader-ranker

Meta information preserved by copy over the tags:
https://github.com/jina-ai/executor-text-transformers-dprreader-ranker/blob/c78a1062936a74120578e91a74423e4155d8d4c7/dpr_reader.py#L181
Is this enough?
All tests except GPU ones are passing.


Fix sharpe ratio

Supersedes #874
See #853.

@twiecki , doc of sharpe_ratio in risk.py says the second parameter---treasury_return,  is Annual treasury return percentage. but calculate_sharp in cumulative.py pass a daily_treasury to sharp_ratio.
also, note that param algorithm_return in calculate_sharp is an array, it does not have an index.
I assume that you want to calculate annualized sharpe ratio from daily algorithm return. In this case, calculate_sharpe should not be called daily(i.e. should not update every trading day)
F.Y.I.
https://www.quantstart.com/articles/Sharpe-Ratio-for-Algorithmic-Trading-Performance-Measurement

Thanks @FayolChang.

@twiecki , doc of sharpe_ratio in risk.py says the second parameter---treasury_return, is Annual treasury return percentage. but calculate_sharp in cumulative.py pass a daily_treasury to sharp_ratio.

I believe daily_treasury refers to the annual risk-free rate on every day. At least, I don't see where any decompounding is being done.

also, note that param algorithm_return in calculate_sharp is an array, it does not have an index.

You're right, that needs to be fixed yet.

I assume that you want to calculate annualized sharpe ratio from daily algorithm return. In this case, calculate_sharpe should not be called daily(i.e. should not update every trading day)

That's correct and something we wanted to fix for some time but it's a larger refactoring and I'd rather fix it here and make it more efficient later.

Could you add a whatsnew entry?

I'd like to talk to Joe and Rich about this before we merge - will track everyone down tomorrow morning.

Currently pondering this change which breaks this PR: https://github.com/quantopian/zipline/commit/bfa94e9c91fae2316f587fb6c84a124dc93411c5 by @ehebert. It causes algo returns to have a different length than the other metrics. I think a better approach would be to just set risk metrics to nan if they can't be computed if e.g. only a single day is present.

@twiecki I think a nan on the first day makes sense. For some context, that patch was to provide compatibility with live trading (minute emission) results on the first day.

We talked yesterday. Thomas is the master of deciding "what is right" and is also the person who should reach out and let us know when changes are coming.

I think this fix is pretty critical but it's turning into a bigger challenge to make changes to the risk metrics than anticipated.

I could use some engineering help to get this over the finish line. Specifically, the pattern of appending zeros (https://github.com/quantopian/zipline/commit/bfa94e9c91fae2316f587fb6c84a124dc93411c5) should be reverted and instead support nans.

Unfortunately I still don't have time to fix the nan issue properly. The math in this PR is correct but it'd be great if someone could help solving that last issue and fixing up the tests.

#8343

Closing in favor of https://github.com/quantopian/zipline/pull/1322.


Throwing callback leads to program terminations in absl::Cleanup

Describe the bug
Let  Callback be a type, whose operator() is noexcept(false) and actually throws.
When an object of such a type is passed as the callback for absl::Cleanup, then the destructor ~Cleanup will always abort the program at runtime, because it is (implicitly) noexcept.
I would expect one of the following two possibilities:

The program doesn't compile, because Cleanup static_asserts that the callback type is nothrow_invocable.
The destructor propagates the exception (this would require marking it noexcept(std::is_nothrow_invocable_v<Callback>).

Steps to reproduce the bug
Consider the following minimal example:
#include <absl/cleanup/cleanup.h>
int main() {
  try {
    absl::Cleanup cl{[]() {throw 42;}};
  } catch(...) {}
}

Link to godbolt
What system are you using
I am using Ubuntu 22.04 and G++ 11.1, but the behavior should be the same on
any standard-conforming compiler and platform.
Additional context
I am aware that "throwing destructors" are a somewhat controversial topic. Maybe a compromise would be, to static_assert as a default, but to provide a possibility to opt out of that assertion, e.g.:
absl::Cleanup cl{[]() noexcept {}};  // Fine
absl::Cleanup cl2{[]() {throw 42;}};  // Assertion failure, not noexcept
absl::Cleanup<absl::IKnowThatMyDestructorThrows> cl3{[]() {throw 42;}}; // Fine

I am willing to provide an implementation as soon as we have discussed, what the desired behavior should be.
A problem might be, that the "safer" suggestions (involving the static_assert) are a breaking change for callback types that do not throw, but are not explicitly marked noexcept.
Best regards
Johannes

Hi Johannes! I'm the author of absl::Cleanup, though I no longer work at Google. I just took a look at this and I think the problem comes down to the default behavior of a lambda in C++. Unfortunately, auto f = [](){}; is not considered to be noexcept. One must explicitly opt into it via auto f = []() noexcept {};. Static asserting that all callacks are noexcept would impact the ergonomics of absl::Cleanup and would break many existing users.
The candidate approach here to make the destructor of cleanup explicitly noexcept(false) may work when executed via normal code paths (closing brace, return, break, goto). However, if an exception is thrown during handling of another exception, the program will terminate, leaving us with roughly the behavior that it already has. Since a primary use-case of absl::Cleanup is running code during stack unwinding, I don't think noexcept(false) on the destructor makes sense. Do you disagree?


Add Android "R/W External Storage" runtime permission request

Permission request came with Android 6. Because if you need to make sensitive operation like write or read external storage, you need to ask to user for permission an make this operation. In Godot has only include camera, record audio and vibration permission. We need to write and read some data in game for save and load states. So I add write and read external storage permission requests and all permission request result callback but I am not sure results were emiting on Main Loop.
Edit:
3.1 branch PR: #31583

Why did you close the previous request?

It gives clang format error and I revert the commit and fix-push again.

@akien-mga why PR is waiting for merge?

Because someone has to review it before merging :)

Okay, I suppose pr was revived 😂

I'm not against about adding signal but now we seems to have to deal with all kinds of permission.
there should be a way to simply handle this.

I think we can only add permission requests easily but only request. If I add location permission in here simply but I need to write location operation base code.In this PR we only ask users for R/W permission, Godot handle file R/W for a long time.

I'm not against about adding signal but now we seems to have to deal with all kinds of permission.
there should be a way to simply handle this.

The list of permissions in the manifest can be retrieved at runtime via the PackageInfo#requestedPermissions field. So a better way to deal with arbitrary permissions would be to query the manifest at runtime, and request to the user the permissions declared there.
In addition, we should include an api to allow GDScript to request arbitrary runtime permissions, and be notified of the result via notifications. I'll create an issue to track it. It may be relatively short to implement (~1 week), so we may want to hold off on this PR if time's not an issue.

I think we can wait. 😄

@cagdasc Should this PR be closed since it'll be replaced by PR #32246?


Update static-files.rst

Fix typo in filename

Hi @johnnyreilly, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

Merged into Docs! Thanks! 0aedeb16173b371f831798fea86a53566506ff96


Fix #310

Change core destory message order

#310 isn't an actual issue, I explained why there

@iEli2tyree011 Okay! I'll close this


FR: Sort template filenames alphabetically when displaying the drop down

I would make it easier to find templates in a sizeable list.
Options for different sorting options could be kept in the field settings or in config (but to be honest, just alphabetical would be great!)

Pull Request: https://github.com/sjelfull/craft3-templateselect/pull/10


importing troposphere causes yaml.load to output OrderedDict.

I installed troposphere from the git master (3a3004a183fd0d70e57b9c9d1b92763b2962d09e) and yaml.load behavior changed:  Here's a test script:
#!/usr/bin/env python3
from pprint import pprint
import yaml
from troposphere import Template
yaml_string = '''
base:
  - name: everyone
    ips: [ <IP_ADDRESS>/0 ]
'''

config = yaml.load(yaml_string)
pprint(config)

It shows "base" as a list of OrderedDict.   If I run off of 1.9.4  it's just a list of a dict.

The cfn_flip module is the one causing this.

I've opened a PR:
https://github.com/awslabs/aws-cfn-template-flip/issues/14

Thanks for the issue and adding the cfn_flip issue as well.

@jeffreyctang I haven't seen any comments yet in the aws-cfn-template-flip issue. While I understand this is a change in behavior for your existing yaml uses I'd like to understand the impact of keeping the yaml changes (cfn_flip) in the code vs. pulling it or rewriting it.

I've got 6k lines of yaml configuration for building our AWS assets using troposphere.
I imagine there's some way of isolating the aws-template-flip yaml settings from mine.   I'm no python expert amd the 10 minutes I spent on it yielded no solutions.
If this was included in a release, I would be forced to either

figure out the yaml isolation, which I'm not confident I can do or is reasonably possible.
postprocess my yaml.load output and convert all the OrderedDicts, which I'm confident I can manage.

I could live with it and I am waiting for the next release for a couple of items.
That said, I would imagine many other users of troposphere are loading  yaml in some capacity or another and this would break things for them.   It's a disconcerting error and not at all obvious that it's related to troposphere.

Fixed in cfn_flip now :)

@stilvoid thank you for making the change. @jeffreyctang can you verify from your side and then we can close this out?

Confirmed.  The new cfn_flip modules doesn't affect my yaml parsing.

Thanks! Closing due to upstream fix.


PageStorage: Fix the WAL snapshot dumped into file may contains invalid "being_ref_count"

What problem does this PR solve?
Issue Number: close https://github.com/pingcap/tiflash/issues/4957, close https://github.com/pingcap/tiflash/issues/4986
Problem Summary:

issue 4975:

We can not prevent being_ref_count to be modify unless we stop the write threads while dumping snapshot of WAL log files

issue 4986:

The encryption info of WAL log files are not removed after snapshot dumped

What is changed and how it works?

Create a reader for WAL log files and load the edit into another temporary PageDirectory instance, and dump it as a snapshot edit to the snapshot log file
Remove the encryption info of WAL log files after snapshot dumped

Check List
Tests

[x] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[x] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests

Addressed, PTAL again @jiaqizho

/merge

/merge


Tdd contributor uniqueness

@mattwr18 this lgtm wdyt?

@soey I was trying to remove the unrelated changes removing the telegram_chat_id from the changes here and did an interactive rebase to squash some commits. Unfortunately, the changes remained and I was confused, until I realized that even though the changes had been merged they were not in main. I went back and saw that you used this PR as the base of the changes. I don't know if this was purposeful, but I think we should avoid this. Of course, if the changes are related and we want to merge small PRs into a release branch as we've done before, I think it's ok, but the changes were completely unrelated and cost time and will be associated with this PR even though they are not related.
I also added a test to the telegram webhook spec to show that the contributor who is completing their onboarding with the same telegram_id as another that is in another relationship works as expected. I wanted to add this line of code to the receive_polling_job_spec, but it's more complicated because it involves re-recording a VCR for the receive messages from the other organizations signal server phone number. Since, it is the same as Telegram, I decided not to spend more time now.
We can always extend it, if we decide.


Upgrade to Go 1.18

is there any plan to update the project to go 1.18?

You can use it with go 1.18 no problem.
Or you mean something else?

i meant upgrade the go.mod file to 1.18 version

What's the benefit?

mainly generics and fuzz testing

What's the benefit for gocqlx of just bumping a string in go mod?

So people could use new features to contribute into the project instead of being held by a string on go.mod

I reckon it will have sense after 1.17 is not used anymore. Now lots of services in production still use go 1.17.


Icon component bugs

Fix icon component doesn't work with xo-color index 0.

Fix icon component to show the correct size on load.

Could you fix conflicts?


Use bundled zlib

@ethomson Any reason not to go ahead and do this now?
That way the only remaining native dependency is OpenSSL.

Absolutely.


PDF output does not render keyboard shortcut graphics

I'm wondering if this will be added at some point. It's a very useful feature in the HTML output but in the PDF it just renders the key combination as the string you entered in the macro.
kbd:[Alt+F4] does not become the Alt + F4 buttons but just says (in literal type) Alt+F4. While this technically does not lose information it's a shame.

Well I have themed it that way:

Is it what you are looking for?
If so, add to you theme:
literal:
  font_color: #c0006a
  font_family: Literal
  font_size: $base_font_size
  background_color: #eeeeee
  border_color: #eeeeee
  border_radius: 1
  border_width: 0
  border_offset: 1

The drawback is that it is literal meaning that all your inline code will be styled that way. Which for me is ok. :)

I believe this is a duplicate of #313. The necessary groundwork is now in place, to we're looking to add the configuration in beta.2.

I believe this is fixed now?
I have tried recent master and was able to confiure key block to have distinct bordered shortcuts.

Absolutely correct. We addressed this in #313 (though technically this issue was more descriptive for this case). I'll mark it as fixed in beta.2.


Change Module name

Change module name to github.com/swerv-ltd/swyftpay-go

I just updated, trying to figure some stuff out you can continue from there


Support rate control for removing peer (#2226)

What problem does this PR solve?
cherry-pick #2226.
What is changed and how it works?

add a region-remove type store limiter
save the StoreLimit in a map, and use the type as the key

Release note
Support rate control for removing peer
Check List
Tests

Unit test

Code changes

Has HTTP API interfaces change

/run-all-tests

/run-unit-tests

/merge


ENH: Make cKDTree.tree more efficient

What does this implement/fix?
Traversal of cKDTree.tree dynamically creates cKDTreeNode objects for each attribute access when travering the kd-tree in Python. Data indices are collected recursively when the indices and data_point properties are called, making it potentially very inefficient.
This PR makes the whole cKDTree.tree appear in all its glory at the first access and also collects data indices as the tree is created. It makes it possible to subclass cKDTree from Python and make reasonably efficient custom queries.
Additional information

The remaining CI failures seem to be related to a timeout and some problem with AR pack. It is likely orthogonal to this PR.

Rebased on scipy/master and squashed into single commit.

It seems I managed to loose a commit when rebasing on current master.

Ok, now its all green again.

And after the stale import is removed, it goes red in some checks but in ways which are probably unrelated to the PR.

@rainwoodman any comments about this?

Thanks @sturlamolden, merged.

Oh. I just saw this. I think this is good. We probably also had (node.lesser is node.lesser == False) before this change, which was a somewhat surprising.

This enhancement PR is connected to a bugfix in #12504 so I'll tentatively label for backporting, though it would be ideal if the "bug fix" were uncoupled from any specific enhancements. Maybe that's not possible though.

Any access to self._node outside the method cKDTreeNode.setup is a bug (potential dangling pointer) so you could consider this PR and  #12504 a bugfix. The conditions by which this bug can manifest is rather uncommon though, which is why it has gone silently under the radar for years.
Another option for squashing this bug in backports is something similar to
https://github.com/scipy/scipy/pull/12504/commits/b65c1f273f66cf30b68de6e26a06d56e83b2a798
It would possibly also require cdef class cKDTree to be decorated with @cython.no_gc_clear.
As the API is not changed, I am not sure why this would be a better option than just backporting this PR along with #12504.

thanks, should be "ok" then


Provide regexes in text format then python wrapper

If you provide the regexes in a language agnostic format, pure text, json, .ini, whatever, you'll allow more people to benefit from it or contribute to it. You can then just provide a Python wrapper loading the reggexes. This would also allow you to have multilingual descriptions matching each regexxes.

@sametmax ,
This seems like a good idea.

@sametmax I think that is good idea and i hope that we can do it. Now expynent is only experimental project and we fix it in version 1.0.0

@the-zebulan Can you give me your email? A want to add you to collaborators.

@the-zebulan If you are interested in the project, together we can make something worthwhile.

@the-zebulan I send you invitation. Now, you're collaborator.

@lk-geimfari ,
Thanks for the invitation! It's an interesting idea, I have a few ideas in mind.

@the-zebulan Nice!

@the-zebulan If you are from Canada, I can offer you also take part in another project, where we really need to add support for Canadian data.


Can't use html-webpack-plugin templating features

:bug: Not able to use some of html-webpack-plugin's templating features.
Example from https://github.com/jantimon/html-webpack-plugin/blob/master/README.md#generating-multiple-html-files
<title><%= htmlWebpackPlugin.options.title %></title>

is rendered by this plugin as
<title><%= htmlWebpackPlugin.options.title %></title>

This is actually more of an EJS problem - ejs templates don't mix nicely with HTML.  I don't have a great recomendation right now other than to avoid using this with ejs templates.  Handlebars should work fine, or skip templating altogether since you can just do:
// custom-prerender.js
export default function(params) {
  document.title = 'A Custom Title';
  return '
some prerendered html
';
}

  <title>Default Title</title>

  {{prerender:custom-prerender.js}}

For things folks might have been doing in ejs like script and stylesheet insertion, there are already automated html-webpack-plugin plugins that handle those things in a way that works nicely with prerender-loader.

Hi there! I was struggling for making templating and pre-rendering work together properly, and realized that the order of file processing should be changed. That seemed to me quite hard to do, so I came up with having a plugin instead of loader. That allows to render html that has been processed by all loaders, templating stuff etc., and do not interrupt/change the usual flow. Here is my version of the plugin, it's quite simple but worked for me:
https://gist.github.com/idudinov/1814a4ce4647c1ec6f9d513a90a5f6b0
Its rendering code and idea in general fully based on prerender-loader project, but simplified just to make simple things without additional options.
Hope this helps someone!

Well, I see Webpack philosophy as a way when some new content/assets produced by plugins, but loaders just transform assets to another representation.
Initial idea of prerender-loader seems to me being a loader, which transforms html page to rendered html page. But this issue just demonstrates that in some cases build pipeline would not accept prerendering logic as loader step.
I think there could be cases where exactly loader needed (to integrate rendering between some steps), although not sure about real examples. From my point of view, in most cases rendering would be the final step of build process, after all transformations have been applied.


free variables in-line python

For both !py -strings and pypyr.steps.py, add support for free variables.
This is less edge case than it might sound: it comes up with very unfriendly and not easily understood errors when you attempt to use nested comprehensions:
[(x, y) for x in list1 for y in list2]. In this case, list2 will not resolve even if it is in context, leading to much WTF-ing for something that looks like it should work and in fact does work when you run it against the normal python compiler.
These pypyr inline python functions rely on eval and exec under the hood. Both of these, although taking both a globals and locals argument, only resolve free variables against globals.

See adr 0001-namespace-on-eval-and-exec


Make the lightmap render result affected by the WorldEnvironment.

I suggest the environment map should affect the result of the Lightmapper.
Godot version:
ea99b90
OS/device including version:
Doesn't matter.
Issue description:
The WorldEnvironment doesn't affect the render result of the BakedLightmap.

Has the lightmapper been remade in 3.2? I thought rendering changes will be done for 4.0?

Can anyone still reproduce this bug in Godot 3.2.3 or any later release?
If yes, please ensure that an up-to-date Minimal Reproduction Project (MRP) is included in this report (a MRP is a zipped Godot project with the minimal elements necessary to reliably trigger the bug). You can upload ZIP files in an issue comment with a drag and drop.

This is still the case in 3.2.3 – the lightmapper doesn't take the environment light into account. It will be fixed by https://github.com/godotengine/godot/pull/40035 once it's merged.

Closing as fixed by #44628

Closing as fixed by #44628


fix: managed policy arns deprecated

Updating deprecation warning:
│ Warning: Argument is deprecated
│
│   with module.serverless-streamlit-app.aws_iam_role.eventbridge_invoke_streamlit_event_bus,
│   on .terraform/modules/serverless-streamlit-app/main.tf line 1313, in resource "aws_iam_role" "eventbridge_invoke_streamlit_event_bus":
│ 1313:   managed_policy_arns = [
│ 1314:     aws_iam_policy.eventbridge_invoke_streamlit_event_bus_policy.arn,
│ 1315:   ]
│
│ The managed_policy_arns argument is deprecated. Use the aws_iam_role_policy_attachment resource instead. If Terraform shouldexclusively manage all managed policy attachments
│ (the current behavior of this argument), use the aws_iam_role_policy_attachments_exclusive resource as well.
│
│ (and 6 more similar warnings elsewhere)

The first version this is available for is 5.72.0

/do-e2e-tests


Add purls (Package URLs) to PackageRecord

This CEP describes a change to the PackageRecord format and the corresponding repodata.json file to include purls (Package URLs of repackaged packages to identify packages across multiple ecosystems.
rendered

Awesome CEP! :)

Would this also help us address Repology's needs for supporting Conda packages ( https://github.com/repology/repology-updater/issues/518 )?

Where in the current meta.yaml we should define the PURLs. about seems to be the most obvious one, which means this will probably end up in info/about.json.

I agree that about makes the most sense. However, this adds the redundancy of defining the upstream package twice in the recipe. A more sophisticated solution would be adding a new purl source type for the source section, which gets resolved to a PyPI tarball URL by conda build. The purls for a package could then be automatically inferred from the sources it has been built from. In all cases, a manual option to define the purls likely has to remain for some specific use cases.
While this would facilitate simplicity, avoid redundancy, and avoid errors in the recipe, I see the following downsides with that solution:

different package outputs or variants may not actually use all sources that are available, requiring manually overriding the purls or another clever solution for that
how to verify the hash of a source tarball is more evident if the source URL is stated explicitly in the recipe
to avoid complexity, we could only support a subset of purl types. PyPI is by far the most important IMO. It could confuse people if only a subset of purls are valid sources.
introducing a new source type is simply more work than introducing a new about field - especially in related tooling such as cf-scripts or conda-smithy
backward compatibility?

Whether to serve the PURLs separately in a purls.json or not. I honestly don't think putting it in repodata.json is a good idea. I get that it makes sense if you want to have a canonical link between PyPI in conda-forge so Pixi can solve things nicely. It might also be served in channeldata.json (since most of the time PURLs are tied to the source not the platform-dependent, target artifact).

I do not have a strong opinion here since I am not too involved with the tools that would need to process that data.

I think a broader question is whether package-urlcan be adopted more directly by the ecosystem. Relying on "the URL where you get your package" or "what it's called on disk" aren't as effective as an agreed-upon grammar for identifying packages, especially in the "is this CVE relevant to me" scenario.

Brief aside, and likely worth including in the text

A purl is a URL composed of seven components:
 scheme:type/namespace/name@version?qualifiers#subpath

To put this in the context of the above, a given .conda package might claim a PURL as a proxy in one or more other types, but by existing, it should claim one in the conda type.  Indeed, a subset is already part of the spec. For example, an old version of django:
It might make sense to advocate for some changes to the conda part of the spec (and test data), namely:

update the default channel from r.a.com -> c.a.org

then the namespace part of the url would encode the conda channel (e.g. pkg:conda/conda-forge/django)
i don't know what the "new null" would be, but pretty sure it can't be defaults

use label for e.g. main (not channel, as in the example)

While i don't think much can be done about "where you got the source tarball" (because GitHub sources, etc), I don't think a recipe author should have to calculate all these things... but certainly could given the available data today:
# meta.yaml
{% set version = "1.10.1" %}
package:
  name: django
  version: {{ version }}
# ...
about:
  # ...
  purls:
    - pkg:pypi/django@{{ version }}
    # this should be fully automated, either at build time (weird?) or trivially-derivable
    - pkg:conda/{{ channel_targets.split(" ")[0] }}/django@1.10.1?subdir={{ target_platform }}&label={{ channel_targets.split(" ")[1] }}&build=py{{ py }}_{{ build_number }}

So the above full purls might expand to
purls:
-<EMAIL_ADDRESS>- pkg:conda/conda-forge/django@1.10.1?subdir=win-32&label=main&build=py35_0


Add files via upload

This is the whole BGFramework with my audio manager level in the use case 1 under PlatformLv 2

This is the whole BGFramework with my audio manager level in the use case 1 under PlatformLv 2


onConnect does not exist in the react hook, use onOpen

whoops, good catch thank you!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Some plugins are not set up correctly

If I install a plugin I created (https://github.com/Shadowigor/fish-ssh-agent), it doesn't immediately recognize the new function. fisher ls lists it, but running it gives me a fish: Unknown command. After I run fisher up, everything works fine. I have to run fisher up for every terminal I open to make it work. For a different plugin I made (https://github.com/Shadowigor/plugin-errno-grep), everything works right away. I cannot see the difference why one would work and the other not. Rebooting and reinstalling don't help.

Make sure you are running fish 2.3 or superior.

I'm running fish 2.3.1.

I had a look at your plugin.
The reason is that the function name is ssha and the file name ssh-agent.fish.
They must have the same name.

Oh, ok, I didn't know that. Is this written somewhere in the documentation?

Try the fish docs https://fishshell.com/docs/current/tutorial.html#tut_autoload
It could be more explicit IMO.


Add warning about change in the service name.

Add warning about change in the service name of docker-compose file that contains _ in it to -.
Fixes: #538
cc: @cdrage @surajssd @surajnarwade @containscafeine

@pradeepto PTAL.

LGTM but wait for someone else to +1. Then feel free to merge. cc @surajnarwade  @surajssd @containscafeine @kadel @cdrage

LGTM :+1:

LGTM


Bugfix: bitcoin-tx: scriptPubKey may be null, so accept outscript=:

ACK, cause travis tested it already.


[Question]: Anthropic with Bedrock, "Put words in Claude's mouth"

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
Anthropic recommends to Put words in Claude's mouth for a more reliable response.
What is the best way to do this when using the Bedrock class?

For example, if I do the following:
prompt_str = """
Human: Please generate a question about Paul Graham's life regarding the following topic: {topic}

Assistant: Here is a question about Paul Graham's life regarding the above topic:
"""
prompt_tmpl = PromptTemplate(prompt_str)

llm = Bedrock(
    model="anthropic.claude-v2:1",
    region_name="us-east-1",
    model_kwargs={
        "temperature": 0.5,
        "max_tokens_to_sample": 500,
        "stop_sequences": ["\n\nHuman:"],
    },
)

p = QueryPipeline(
    chain=[prompt_tmpl, llm], verbose=True
)

p.run(topic="college")

The prompt will actually be formatted in the following unintended way:

Human:
Human: Please generate a question about Paul Graham's life regarding the following topic: graduation

Assistant: Here is a question about Paul Graham's life regarding the above topic:

Assistant:

This does not work with Bedrock.

from llama_index.core import ChatPromptTemplate
from llama_index.core.llms import ChatMessage, MessageRole

message_templates = [
    ChatMessage(content="You are an expert system.", role=MessageRole.SYSTEM),
    ChatMessage(
        content="Generate a short story about {topic}",
        role=MessageRole.USER,
    ),
]
chat_template = ChatPromptTemplate(message_templates=message_templates)

https://docs.llamaindex.ai/en/stable/module_guides/models/prompts/usage_pattern.html#defining-a-custom-prompt

@logan-markewich There's something wrong here. I've tried the following:
from llama_index.llms import Bedrock
from llama_index import ChatPromptTemplate
from llama_index.llms import ChatMessage, MessageRole
from llama_index.query_pipeline.query import QueryPipeline

message_templates = [
    ChatMessage(
        content="You are an expert system.",
        role=MessageRole.SYSTEM
    ),
    ChatMessage(
        content="Please generate a question about Paul Graham's life regarding the following topic: {topic}",
        role=MessageRole.USER,
    ),
    ChatMessage(
        content="Here is a question about Paul Graham's life regarding the above topic:",
        role=MessageRole.ASSISTANT,
    ),
]
chat_template = ChatPromptTemplate(message_templates=message_templates)

llm = Bedrock(
    model="anthropic.claude-v2:1",
    region_name="us-east-1",
    model_kwargs={
        "temperature": 0.5,
        "max_tokens_to_sample": 500,
        "stop_sequences": ["\n\nHuman:"],
    },
)

p = QueryPipeline(
    chain=[chat_template, llm], verbose=True
)

response = p.run(topic="college")
print(response)

But the prompt ends up being:
Human: <system>You are an expert system.</system>

Human: Please generate a question about Paul Graham's life regarding the following topic: college

Assistant: Here is a question about Paul Graham's life regarding the above topic:

(notice the incorrectly added Human:  prefix to the system message)

@austinmw ah right. This is because anthropic/bedrock does not support system prompts

If this has changed, it may require a PR

Hmmm. Yeah it should support system prompts:
https://docs.anthropic.com/claude/docs/how-to-use-system-prompts

@logan-markewich
Anthropic does support system prompts, you just need to remove Human: and the <system> tags. I think you just need to update the string here to not have those things.

Not sure what's up, but I updated both

/home/ubuntu/llama_index/llama-index-integrations/llms/llama-index-llms-anthropic/llama_index/llms/anthropic/utils.py
/home/ubuntu/llama_index/llama-index-legacy/llama_index/legacy/llms/anthropic_utils.py

in a pip install -e of LlamaIndex, removing those sections and still got the same output. I guess I need to look further into how these packages are installed.

I think this should be fixed with #10603


Logic: Alias changes

This PR refactors the alias feature and adds sane default aliases.
e.g. a -> add, d -> delete, etc.
It also splits alias -d into a new command, unalias. The rationale is that using command flags was inconsistent with other commands, such as the add and delete pair.
Notable changes
UserPrefs is now a Singleton.
Moving forward
Should we remind users that there are aliases if they use the full command? A similar feature for the zsh shell is alias-tips.
e.g. list -> Alias tip: l

Coverage increased (+1.2%) to 90.904% when pulling 2ba98f57b492846a77b6ec386140abdb283afb0b on goweiwen:alias-command-initial into aee7792a7cb879493eacb00ea489c880b0aa8a4c on CS2103AUG2017-W11-B4:master.


Migrate the OpenAPI Tool to ballerina-openapi repository

Purpose

Migrate the OpenAPI Tool to ballerina-openapi repository

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email<EMAIL_ADDRESS>to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to<EMAIL_ADDRESS>and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

Unit tests

Code coverage information

Integration tests

Details about the test cases and coverage

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes/no
Ran FindSecurityBugs plugin and verified report? yes/no
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes/no

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.16 out of 21 committers have signed the CLA.:white_check_mark: manuranga:white_check_mark: MaryamZi:white_check_mark: pahans:white_check_mark: hasithaa:white_check_mark: gimantha:white_check_mark: hevayo:white_check_mark: wggihan:white_check_mark: SupunS:white_check_mark: NipunaMarcus:white_check_mark: hemikak:white_check_mark: pubudu91:white_check_mark: lnash94:white_check_mark: warunalakshitha:white_check_mark: daneshk:white_check_mark: Kishanthan:white_check_mark: chamil321:x: Manuri:x: DimalChandrasiri:x: lankavitharana:x: Anoukh:x: arukshaniYou have signed the CLA already but the status is still pending? Let us recheck it.


[5.8] Added ability to update other columns when performing soft deletion

Added ability to update other columns when performing soft deletion.
Currently need to call save() method in static::deleting(). Tests included.
Example usage:
<?php

use Illuminate\Database\Eloquent\Model;

class SomeModel extends Model
{
    use SoftDeletes;

    protected static function boot()
    {
        static::deleting(function (self $model) {
            $model->somecolumn = 'some-new-value';
//            $model->save(); - not needed from now
        });
    }
}

$model = SomeModel::create([
    'somecolumn' => 'somevalue'
]);
$model->delete();

I don't see why this is necessary tbh. It's better to be explicit in the deleting callback imo and note that you want to save the changes.

It will be second query - not good for performance

In any case this is a breaking change and best sent to master imo.

In any case this is a breaking change and best sent to master imo.

Switched to master.
But why it is breaking change? Without calling save it will never work. With calling - same behavior, two queries.

@ddzobov because people could currently set changes on this listener and don't expect them to be saved.

@ddzobov updating dirty attributes together with deleted_at column on delete() sounds like a bad change that can lead to a lot of problems like @driesvints already pointed out.
Someone might have filled model's attributes with some values, but then decided to delete this model in the code - expected (and logical) behavior here would be that those changes will not be persisted into database (since we haven't called save() implicitly), but with your changes they will be.
I would certainly vote for similar change to be introduced in the non-breaking (disabled by default unlesss you override/change something within the model) manner. Also, currently if the need arrives to update other columns and extra update query is an issue you can always just override trait's runSoftDelete() method to introduce this specific behavior.

It's also a case of what you expect. I personally don't expect other stuff to be saved when I perform a "delete". I expect a delete to do the bare minimum necessary to delete the model.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


[BUG] dbt-dry-run Ignoring Partitions from dbt-external-tables

I've encountered an issue where dbt-dry-run fails to recognize the partitions defined in a YAML configuration for a BigQuery table. Despite the correct specification of partitions under the dbt-external-tables setup, the dry run process results in a BadRequest error, indicating that the partition could not be found.
Steps to Reproduce

Define a table in YAML with the following structure:

version: 2

sources:
  - name: dataset_name
    tables:
      - name: table_name
        external:
          location:  "gs://bucket/path/to/table/table_name/*.json"
          options:
            format: json
            hive_partition_uri_prefix: "gs://bucket/path/to/table/table_name"
            ignore_unknown_values: true
          partitions:
            - name: ts
              data_type: STRING
        columns:
          - name: uuid
            data_type: STRING
          - name: name
            data_type: STRING
          ...

Observe the error:
400 POST https://bigquery.googleapis.com/bigquery/v2/projects/project_id/jobs?prettyPrint=false: Name ts not found inside a at [15:9]

Hey 👋
Thanks for raising an issue and PR! Am I understanding this correctly that the final schema of the table is the union of the columns defined in partitions and defined in columns ? Is it possible for partitions to be defined and columns to be empty? I know that might not be very useful but the dry runner should handle that case as well if so.

Hey, I hope you're doing well!

Am I understanding this correctly that the final schema of the table is the union of the columns defined in partitions and defined in columns ?

Yes, you're right. The table columns are a combination of the columns and partitions. This happens because the Hive partitions are active. So, in storage, we'll see a pattern like this: gs://bucket/path/to/table/col_partition_1=value/col_partition_2=value/file_without_col_partitions.json. In this case, if you apply a 'where' condition like col_partition_1=value, BigQuery will only access the files in this folder.

Is it possible for partitions to be defined and columns to be empty? I know that might not be very useful but the dry runner should handle that case as well if so.

I've never tried this specific case, but I think the code covers situations where the columns or partitions are empty. Pydantic uses a default factory for these fields, so when they are empty, the model will have an empty list of partitions and an empty dictionary of columns. Then, the unpacking should work without any issues.


Problem with method count

Versions

scout-elastic-driver: latest
laravel/framework: 5.8
php: 7.2
elasticsearch: 7.7.0

Description
Hello. Have a little problem with method count.
It not working when you have additional method calls from builder.
Example #1 (count work as expected):
$products_default_rule_match = Product::search($this->search_query)->rule(DefaultRule::class);
dump($products_default_rule_match->count());

Example #2 (count throw error):
$products_default_rule_match = Product::search($this->search_query)->rule(DefaultRule::class)->select('id');
dump($products_default_rule_match->count());

It has small relation to #130
Need to fix buildSearchQueryPayloadCollection() method or probably add new method for build query payload when run count().
I can provide PR if needed.

Hi, it really seems like a bug. Could you elaborate a PR to fix it?

Hello. Yes, I will try to find some time for this.


Fix memory leaks in multiplexrer plugin

We were running jemalloc/jeprof against the multiplexer plugin, and we have identified a memory leak.
Attached is the jeprof graph illustrating the issue -

Please review!

I think we should backport this to 8.1.x and 9.0.x
@shinrich can you take a look as well? Thanks.

[ci approve]

[approve ci]

[approve ci docs]

Cherry-picked to v9.0.x branch.


Documentation

https://kennycjy.github.io/tp/DeveloperGuide.html#5-testing
Need Sean to follow up. I added content for testing, need Sean to help do ToC and coverage cause i did this in parallel with his other work.

Please update the ToC (main and the side ones). I will look through around 4am.


Running aqt without arguments produces error

If you run aqt without arguments, you get a confusing error:
C:\Users\nyanpasu64\scoop\apps\consolez\current>aqt
Traceback (most recent call last):
  File "c:\users\nyanpasu64\appdata\local\programs\python\python38\lib\runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "c:\users\nyanpasu64\appdata\local\programs\python\python38\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\nyanpasu64\.local\bin\aqt.exe\__main__.py", line 7, in <module>
  File "c:\users\nyanpasu64\.local\pipx\venvs\aqtinstall\lib\site-packages\aqt\__init__.py", line 38, in main
    return cli.run()
  File "c:\users\nyanpasu64\.local\pipx\venvs\aqtinstall\lib\site-packages\aqt\cli.py", line 248, in run
    args.func(args)
AttributeError: 'Namespace' object has no attribute 'func'

I think you should print help, if no subcommand is recognized. Maybe via Cli.parser's func, not sure though.

Thanks for report. Confirmed. Does #136 work as expected?


Could you please provide a privacy policy?

A project is asking for a privacy policy here.

That's the second request for something from that project, I don't really see how Skip Redirect fits in there... Anyway, what should that policy look like? Skip Redirect does not connect to anywhere and hence can't track or forward anything to third parties.

@sblask For example, like this:
https://addons.mozilla.org/en-US/firefox/addon/decentraleyes/privacy/

Privacy is a universal right.
Decentraleyes does not collect any data of any kind.

How about This extension does not collect or send data of any kind to third parties? Do you want to have it on Github (in the readme?) or on addons.mozilla.org or both?

:+1: Seems great to me, sorry for bothering.

👍 Seems great to me, sorry for bothering. If you add a line in the readme, that will be perfect.

Done.


Zowe demo video strategy

We have many great demo videos for different components and they would be very helpful for users to learn about features and functions. To embed the demo videos in docs or link to them in docs, a strategy needs to be defined. For example:

where to host the demo videos. OMP's Youtube channel is now used for Zowe videos (system demos, overview videos, webinars, etc.) but for short demo videos that will be frequently uploaded, the location for these videos need to be considered.
how to maintain these demo videos. Some demo videos might change per release. Need a process to allow squads to maintain them and upload new ones, for example, via a PR, or allow squad leads to upload directly.
how to ensure consistent look and feel. for example, use the same starting and ending screen.
some other considerations:

the demo videos should also be searchable in search engines
how to version videos

A draft for the video process is in progress: https://github.com/zowe/docs-site/tree/video-strategy#adding-videos-to-docs