wine{Unstable,Staging}: 6.20 -> 6.22

Motivation for this change
Replaces / extends #144845.
Things done
Currently running the review...

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 146807 run on x86_64-linux 1

20 packages built:

grapejuice
lutris
lutris-free
lutris-unwrapped
pipelight
winbox
wine-staging (winePackages.stagingFull)
wine64Packages.staging
wine64Packages.stagingFull
wine64Packages.unstable
wine64Packages.unstableFull
winePackages.staging
winePackages.unstable
winePackages.unstableFull
wineWowPackages.staging
wineWowPackages.stagingFull
wineWowPackages.unstable
wineWowPackages.unstableFull
yabridge
yabridgectl


Remove references to Codebreakers from location notes (#2432)

What does this change?
Remove all references to Codebreakers from the location note, derived from MARC field 535.
This does not remove Codebreakers references from the description field — it was decided that this would be removed in the underlying data (see here for more info).
Instead of matching all sentences which contain the Codebreakers keyword, it seemed safer and more predictable to only match specific sentences. There are only 5 such sentences in the data, which I verified in the reporting cluster. The entered query searches for 535 MARC fields which mention Codebreakers but are not one of the 5 hard-coded sentences. If there was another sentence mentioning Codebreakers, it would show up in the results.
How to test
I included a few unit test cases.
How can we measure success?
The 'Location of original' and 'Location of duplicates' sections on the 'works' page should no longer mention Codebreakers. For example, this item currently has Codebreaker references in both sections. This change should result in both of them being removed.
Have we considered potential risks?

Do you know how to test your change in the staging env?


remote db management

Could it be possible to expose the db port ( port 3306 for mysql) to permit remote db management based for example on a (y/N) and a 'port number?' user input  when running new-site.sh ?

Hello @nnachtegael,
Sure it is possible, but normally when this is required, might be better use some proxy for it or manually, once there might be multiple sites and databases, and we must have only one service open for each port, in that case, if we set port 3306 for wordpress db, we will have an error and firing new site. But this might be an option in new script to open db for remote access informing the url or even creating a db proxy. I will think of something in this matter.


How to use a layermask for the atmosphere and ocean shader/post processing?

Not so much an issue but since this is the closest thing to a forum about this here I am again.
With the way the shader works right now even disabling a celestial body or making it invisible to a specific camera doesn't remove the ocean and atmosphere. Is there a simple way to implement a layermask for which atmospheres/oceans a post processing effect can render (which would be different per camera)? Thanks.

What would be a way of interfering with its checks like you suggested? I have pretty limited knowledge on this. Would there be a way to check for a tag on a GameObject that has the Celestial Body Generator, maybe when it gets the materials from the body settings? I don't know.

Solved! In PlanetEffect.cs line 76, in the if statement you can put any check you want. If the if statement runs, then the atmosphere for the planet will be displayed. Let me show an example.
// Atmospheres
if (displayAtmospheres) {
	if (effectHolder.atmosphereEffect != null) {
		effectHolder.atmosphereEffect.UpdateSettings (effectHolder.generator);
		postProcessingMaterials.Add (effectHolder.atmosphereEffect.GetMaterial ());
	}
}

I believe that's what the original code looks like. Changing the if statement I can do a check for if the gameobject is on, because currently, disabling a gameobject still allows the atmosphere to show.
if (displayAtmospheres && effectHolder.generator.transform.parent.gameObject.activeSelf)
Now the global displayAtmospheres AND the planet object needs to be enabled for its atmosphere to renderer.
I make the check be for the parent of the generator instead of the generator object itself (called Body in my case) because turning off the Planet (parent of Body) doesn't count as Body being set to inactive.
Obviously, here you could do any check you want. All you need to know is that the if statement runs for every generator in the scene - effectHolder.generator is the generator it is currently looping through. So you can do a layer or tag check on the planet and stuff like that!


Move jump functionality to separate class

Both dinosaur and windup reference this jump and use internal functions
Remove jump tests from dinosaur, add to jump class
Add dinosaur to windup test to allow that test to pass
What's this PR do?
Moves duplicated Jump code that was in both windup and dinosaur to its own class that is used in both
Where should the reviewer start?
With Jump file - that is the code that was duplicated in both and removed
How should this be manually tested?
Probably play the game - two player version to make sure both dinos and windups are jumping properly
Any background context you want to provide?
Screenshots (if appropriate)
Functionality is the same
What gif best describes this PR or how it makes you feel?
Not my thing :)
@rrgayhart @ksk5280 @erinnachen
closes #98

This looks like a good refactor. It makes sense to pull the duplication jump functions into a separate class.

It feels like there are a lot of statements like new Jump().jump(args). It seems like you want to use a class method here.

Juicy refactor! 🚢

I'm going to merge this. I like the extraction, but I think we can work on the syntax...


Process crash when raising an error in "async void" method

Calling a method void A() that calls async void B() in a controller crashes the ASP.NET Core process if B raises an error.
Make a GET request using the url http://localhost:5000/test to be able to reproduce the issue.
csproj-File
<Project Sdk="Microsoft.NET.Sdk">

    <PropertyGroup>
        <OutputType>Exe</OutputType>
        <TargetFramework>netcoreapp2.2</TargetFramework>
    </PropertyGroup>

    <ItemGroup>
      <PackageReference Include="Microsoft.AspNetCore.App" Version="2.2.7" />
    </ItemGroup>

</Project>

Program.cs incl. the controller
using System;
using Microsoft.AspNetCore;
using Microsoft.AspNetCore.Builder;
using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.Mvc;
using Microsoft.Extensions.DependencyInjection;

namespace AspnetCoreCrash
{
   class Program
   {
      static void Main(string[] args)
      {
         WebHost.CreateDefaultBuilder()
                .ConfigureServices(services => services.AddMvc()
                                                       .AddApplicationPart(typeof(TestController).Assembly))
                .Configure(app => app.UseMvc())
                .Build()
                .Run();
      }
   }

   [Route("[controller]")]
   public class TestController : Controller
   {
      [HttpGet]
      public IActionResult Test()
      {
         RaiseEvent();

         return Ok("ok");
      }

      private void RaiseEvent() => RaiseEventVoidAsync();

      private async void RaiseEventVoidAsync() => throw new Exception("Error!");
   }
}

Raised exception inside .NET
System.Exception: Error!
   at AspnetCoreCrash.TestController.RaiseEventVoidAsync() in C:\Projects\Tests\ConsoleApp4\AspnetCoreCrash\Program.cs:line 36
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.<>c.<ThrowAsync>b__7_1(Object state)
   at System.Threading.QueueUserWorkItemCallback.<>c.<.cctor>b__6_0(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location where exception was thrown ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.QueueUserWorkItemCallback.ExecuteWorkItem()
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
   at System.Threading._ThreadPoolWaitCallback.PerformWaitCallback()

Additional context
.NET Core SDK (reflecting any global.json):
Version:   2.2.402
Commit:    c7f2f96116
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.17763
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\2.2.402\
Host (useful for support):
Version: 2.2.7
Commit:  b1e29ae826

Thanks for contacting us, @PawelGerr.
Why are you interested in having async void?

Async void methods have different error-handling semantics. When an exception is thrown out of an async Task or async Task method, that exception is captured and placed on the Task object. With async void methods, there is no Task object, so any exceptions thrown out of an async void method will be raised directly on the SynchronizationContext that was active when the async void method started.

http://blogs.microsoft.co.il/dorony/2013/10/30/async-void-methods-can-crash-your-process/


Add a filter() overloaded method that accepts a SpEL expression and a FilterEndpointSpec too.

Add a filter() overloaded method that accepts a SpEL expression and a FilterEndpointSpec too.
Could not run unit test as my setup currently does not allow me to use JDK 8, but I hardly expect any impact with this change... that said, caveat developer :)
UPDATE: Would it be possible to include it in the next released version?

@gdelprete , thank you for the PR, but before we take a look to your work, you should confirm that you have signed CLA: https://github.com/spring-projects/spring-integration/blob/master/CONTRIBUTING.md
And the PR against top-level branch, not master

Top level branch you mean the 1.0.x branch?

He meant topic branch - see A Day in the Life of a Contributor and be sure to "sign" the CLA.

UPDATE: Would it be possible to include it in the next released version?

@gdelprete , yes, we definitely will include it to the 1.1 release (somewhere this summer). Until that you can use this workaround:
.filter(new ExpressionEvaluatingSelector("payload instanceOf String"),
                   e -> e.id("filter")

Maybe that was a reason why I haven't included this your fix to the original implementation...

@garyrussell ok, so you mean create a topic branch. Can I name it however I want? There's no ticket for this enhancement. Also, which branch do I base the topic branch on? Master or 1.0.x ?
@artembilan is it really impossible to have a 1.0.2 release? I am waiting for the fix in #13 .

@gdelprete , OK. Let it be: we'll include it to the 1.0.2.
Anyway you should confirm that you have signed CLA for the PR acceptance.
Yes, would be better to create a GH ticket on the matter and make branch with the name based on the number of that GH issue. Of course, if you are still going to push a change to the Framework. Otherwise we'll do that for you.
Just let us know!

See PR #18


[language] more inclusive

Description

Moves language to be more inclusive.
Replaces white with allow in all usage.
Uses allowed vs. allowlist where appropriate.

Link to any related issue(s):
Type of change:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Required Checklist:

[ ] I have signed the MongoDB CLA
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added any necessary documentation (if appropriate)
[ ] I have run make fmt and formatted my code

Further comments

Needs a follow-up once the various API URLs are updated.
Terraform PR here: https://github.com/terraform-providers/terraform-provider-mongodbatlas/pull/258.
Happy to write a "Breaking change" note where appropriate.  Looks like these are typically captured in the CHANGELOG.md post-merge.
Does not update the previous comments in the CHANGELOG.md as they are relevant to those changes.  Happy to update if preferred.

Thank you very much @drewrothstein for the PR to change our language to be more inclusive.   MongoDB fully supports changing our language to better reflect our values.  We currently have a multi-team project underway to update the nomenclature in our core product in August (estimated timeframe, may move due to complexity).  Once that is completed we will schedule the work to update the MongoDB Atlas Go Client, Terraform Provider, and similar projects.  I'll close this PR for now but feel free to reach out directly<EMAIL_ADDRESS>


[Feature Request] Generate item.yaml from existing Ad

Would be nice to not have to recreate the ad in CLI (takes a while and not user friendly), but instead use an existing ad and generate item.yaml from it.

Yes, this would be useful. Would someone like to take a stab at this one?

This is essentially the same request as #64 (albeit that one references the old ad post format)

Closed as issue is  duplicate


Removed api-key and workshop functionality

Purpose

Removed the api-key auth functionality from chat,py and related files to make the sample truly keyless
Removed GitHub workshop functionality -- GitHub Model and Local Model support

Does this introduce a breaking change?

[X] Yes
[ ] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[X] Other... Please describe:

* Using an api key has been removed from the sample
* Using a model from github models has been removed from the sample
* Using a local model with Ollama has been removed from the sample.
``

How to Test

Get the code
Run as directed in readme.

git clone https://github.com/ms-johnalex/openai-chat-app-quickstart.git
cd openai-chat-app-quickstart
git checkout -b remove-api-key-auth-092624

Test the code

What to Check
Verify that the following are valid

...

Other Information

This also seems to have a merge conflict with main btw

This also seems to have a merge conflict with main btw

It's the README Files.

Can you run the pre-commit hook? Formatting failed

Can you run the pre-commit hook? Formatting failed

Black doesn't like something I changed in testapp.py.

Can you run the pre-commit hook? Formatting failed

Added NewLine to EOF in testapp.py. Black is happy now.


PHPUnit 9 compatibility

When I attempt to composer require this package in my PHPUnit 9 project it fails with the following dependency/version error:
    - Root composer.json requires wp-graphql/wp-graphql-testcase ^2.1.3 -> satisfiable by wp-graphql/wp-graphql-testcase[v2.1.3].
    - wp-graphql/wp-graphql-testcase v2.1.3 requires phpunit/phpunit ^7.5 || ^8.5.0 -> found phpunit/phpunit[7.5.0, ..., 7.5.20, 8.5.0, ..., 8.5.26] but it conflicts with your root composer.json require (^9.5).

See Supported PHPUnit versions for PHPUnit's release timeline.

Issue is that TraversableContains becomes an abstract in 9.x so we'd need a shim for TraversableContainsIdentical to maintain compat with 8.5 and below.
I'd offer, but phpunit is not my wheelhouse.

@galbus @justlevine This issue should be fixed with the release of v2.2.0

@kidunot89 you sure ?

Its also causing WPGraphQL's core GH actions to fail (since wp-graphql-testcase was set to ~2.1, it gets updated to 2.3 by the docker entrypoint )
cc: @jasonbahl


Only Retrieves JSON

Who I am + Context:
minimum coding background, found your git while trying to figure out how to download a free course hosted through thinkific course, got the basics of how to setup docker/IDE etc.
Followed the instructions to get CLIENT_DATE and COOKIE_DATA + run docker in Visual Studio Code
Course
Case Interview Fundamentals at Crafting Case Studies: https://students.craftingcases.com/
==============
My .env looks like this
# For downlaoding all content, use the course link.
COURSE_LINK="https://students.craftingcases.com/api/course_player/v2/courses/case-interview-fundamentals
"
# For selective content downloads, use the JSON file created from Thinki Parser.
# Copy the file to Thinki Downloader root folder (where thinkidownloader3.php is there).
# Specify the file name below. Ex. COURSE_DATA_FILE="modified-course.json"
COURSE_DATA_FILE=""

CLIENT_DATE="2024-04-24T16:46:03.899Z"
COOKIE_DATA="_thinkific_session=VFM4NGY0N0p4SldCbUtLNUFCaFR5VjZVM3dkck9TL2xJZFdidkJOSktXNUZITjlFV1V1NmRlUlQ3dnk2YkVLT0xYSjFyU0FDMmdpM2toUW44Z3RRMFRWRWN0Tlo3Rnd3Tm5lU0ZSTnZMMTFCN0puV1pXU3loWjArOVdjbTZTTGNYQWlrd1E2aFhJTjQ0a0FIVjJuTHdRd2FvbFptcVdMNEd3S2IzQjNUS2JIL0hQMzhKUkdGZnZyRFNuRytLMVZuRTVHOFJjbjFkU1VDTCt3aHpwa0tEcEFIWVpHSlprY0U0QVZ1RFdKU0VUKy9WLzE3SUo0TC9CTUpPRHpEckxDTkFkQXpxRHR6Z2tVQ1NsaWc2U0Y4aGFJR1hUM24yem5ERE00ckE3NmNlVE9hZFRyV0RmMFNCUC9hWG9sL1IxUWdnZjc3MGVoTEhkRmVObFBGdmtzWk1zRCtSeW1ubjdqQnlFL3hFZkZadTdGTFR2MHV0TEJDZ3Q0OEVtSmJWMmt4MUIzY3BvVjJPZ1dSNTVNbUhNRHdzbHp6YXdnQmlnemZXd01SMVZxZzF3eWt0UmNCdFZLRVlRRGc5eTZQeVkwMzQrWlI0M3dNeThESGpOMFhsUE1CdHR1YzI5STE4TmRxeHVmV0NWcnA2bjEwQUUyRmkxaUxzMG53T0tXZUhqWVQtLVZUZFlEOGZyU2NmOFN6dTBKRkg2Mmc9PQ%3D%3D--ff4012c793643318036482ba0e5219e8e7fe5c59; path=/; secure; HttpOnly; SameSite=None
"

# Quality Available: "Original File", "1080p", "720p", "540p", "360p", "224p"
VIDEO_DOWNLOAD_QUALITY="720p"`

Terminal looks like this:
PS C:\Users\katie\Documents\Thinki Git\Thinki-Downloader> docker-compose up
[+] Running 1/0
 ✔ Container ThinkiDownloader  Created                                                0.0s
Attaching to ThinkiDownloader
ThinkiDownloader  | THINKIFIC DOWNLOADER
ThinkiDownloader  | Revision 6.3.2 ~ 16th December 2023
ThinkiDownloader  | Author : SumeetWeb ~ https://github.com/sumeetweb
ThinkiDownloader  | Consider buying me a coffee at : https://www.ko-fi.com/sumeet
ThinkiDownloader  | Want to download only selected videos? Thinki-Parser Experimental is available!
ThinkiDownloader  | ----------------------------------------------------------
ThinkiDownloader  | Fetching Course Contents... Please Wait...
ThinkiDownloader exited with code 0

===========================
All I get is a .JSON file
My guess is that I messed up on grabbing the CLIENT_DATE and COOKIE_DATA or maybe some thinkific courses are setup different?
Adding Screenshots of what I grabbed too

Hello there. Thank you for trying out the script.
Can you try using the cookie data from request headers, not the response header and try again?
It seems to work here.

Thanks, Resolved!
Had a friend try too and he also ended up with an empty JSON. Trouble shot further by replicating your exact process with the dentistry website and when I tried again with Crafting Case Studies the files properly downloaded. Not sure what was going on.
My guess is the cookie timed out or something like that.
Thanks!


Menu dropdowns are broken on tariff viewer

The JS powered dropdowns in the main menu bar don't work on https://openprescribing.net/tariff/
I'm assuming this is due to the JS error that gets thrown:
openprescribing.min.js:1 Uncaught Highcharts error #16: www.highcharts.com/errors/16

but I haven't investigated this yet.

Fixed in #689


Fix order of parametersFix order of parameters in pubsub Subscriber create_subscription docs in the subscriber guide

I signed it!
On 20 December 2017 at 16:57, googlebot<EMAIL_ADDRESS>wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll
verify. Thanks.

If you've already signed a CLA, it's possible we don't have your
GitHub username or you're using a different email address on your commit.
Check your existing CLA data https://cla.developers.google.com/clas
and verify that your email is set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.
If your company signed a CLA, they designated a Point of Contact who
decides which employees are authorized to participate. You may need to
contact the Point of Contact for your company and ask to be added to the
group of authorized contributors. If you don't know who your Point of
Contact is, direct the project maintainer to go/cla#troubleshoot. The email
used to register you as an authorized contributor must be the email used
for the Git commit.
In order to pass this check, please resolve this problem and have
the pull request author add another comment and the bot will run again. If
the bot doesn't comment, it means it doesn't think anything has changed.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/google-cloud-python/pull/4636#issuecomment-353084854,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAv3ZafJEIdgGlWVtN8hgUd8c4Ij19XAks5tCSBsgaJpZM4RIgba
.

--
George-Cristian Bîrzan


fixes #202 by retrying on an UNKNOWN error code

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

[x] Tests and linter pass
[x] Code coverage does not decrease (if any source code was changed)
[x] Appropriate docs were updated (if necessary)

A unit test for this would be lovely :)

@JustinBeckwith , sure I thought about duplicating the one we have for errcode 10 so easy to add :)


feat(Msgpublish): support select message header by selector

PR Checklist
If you have any questions, you can refer to the Contributing Guide
What is the current behavior?
None.
Issue Number
https://github.com/emqx/MQTTX/issues/455
What is the new behavior?
support quick select message header:

check one option it will be auto-complete the payload`topic\retain` options.
and when we send a message with a new header, this option will be added to the selector item.(max item number is 10 now).
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information

@ysfscream PTAL, how about this design?

@ysfscream PTAL, how about this design? :)

YES! It's GOOD.


Migrate to Docker

As the title suggests, we can avoid writing scripts.

#8 docker migration done.


[Android] 6.17-6.18的代码更新导致编译失败

Describe the bug
6.17号之前的版本是可以编译成功的, 6.19号早上更新后编译失败, 信息如下:
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':playground:mergeDexDebug'.

com.android.build.api.transform.TransformException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: com.android.builder.dexing.DexArchiveMergerException: Unable to merge dex

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 5.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/4.10.1/userguide/command_line_interface.html#sec:command_line_warnings
BUILD FAILED in 6m 17s
123 actionable tasks: 66 executed, 57 up-to-date
编译环境 window10, ndk-r16

In order to obey Google's 64 bit supporting rule, Weex update NDK 16 to 18.
Please upgrade to ndk 18 or higher, thanks. I will update the document soon.
Feel free to reopen this issue if you have further questions. I only response to issues that are open.


[bug] tauri-cli incorrectly parses application arguments

Describe the bug
Running cargo tauri dev -- -- --myoption causes tauri to pass --no-default-features to my application. That means cargo build doesn't get that flag, and it means my application crashes because clap isn't expecting the --no-default-features flag in my application.
This seems to be due to this code: https://github.com/tauri-apps/tauri/blob/4036e15f5af933bdc0d0913508b5103958afc143/tooling/cli/src/interface/rust.rs#L303
After that line the rest of the function splits up args into args and run_args by looking for --.  Since --no-default-features is pushed onto args beforehand, it will incorrectly end up in run_args.
Likely the code that pushes --no-default-features should either use an insert to put the flag at the beginning of args, or the push needs to occur after run_args has been split off.
Reproduction
No response
Expected behavior
No response
Platform and versions
Environment
  › OS: Mac OS 12.6.0 X64
  › Node.js: 18.10.0
  › npm: 8.19.2
  › pnpm: Not installed!
  › yarn: Not installed!
  › rustup: 1.25.1
  › rustc: 1.64.0
  › cargo: 1.64.0
  › Rust toolchain: stable-aarch64-apple-darwin

Packages
  › @tauri-apps/cli [NPM]: 1.1.1
  › @tauri-apps/api [NPM]: 1.1.0
  › tauri [RUST]: 1.1.1,
  › tauri-build [RUST]: 1.1.1,
  › tao [RUST]: 0.14.0,
  › wry [RUST]: 0.21.1,

App
  › build-type: bundle
  › CSP: unset
  › distDir: ../dist
  › devPath: http://localhost:1420/
  › framework: React

App directory structure
  ├─ dist
  ├─ node_modules
  ├─ public
  ├─ src-tauri
  ├─ .vscode
  └─ src

Stack trace
No response
Additional context
No response

This bug also causes the app ui not updating when frontend file changes. Cargo do not receive '--no-default-features', so the app is not connecting to frontend dev server but using old dist files.

@e792a8 This issue was fixed in the cli v1.2.0. Can you make sure your dependencies are up to date?
Also you can remove the default-features from the Cargo.toml file without any consequences (starting with v1.3 it won't be part of the templates anymore).


1851 modify syncdb to allow for the population of structured content

🗣 Description
Updated syncdb to create some organizations have the parentId field populated in the database and those organizations are other organizations in the database to simulate users creating suborganizations.
💭 Motivation and context
This closes 1851 and was needed to test the new organization, suborganization
🧪 Testing
Manual testing:
Start the backend and the db. Then run the npm run syncdb -- -d populate and ensure that some of the organizations have the parentId populated.
Run crossfeed locally and make sure everything still loads and works on the organizations screen.
✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All future TODOs are captured in issues, which are referenced
in code comments.
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[x] Tests have been added and/or modified to cover the changes in this PR.
[ ] All new and existing tests pass.

✅ Pre-merge checklist

[ ] Revert dependencies to default branches.
[ ] Finalize version.

✅ Post-merge checklist

[ ] Create a release.

We should include this work in the current ticket. We need to preserve the functionality for global admins to view all organizations, otherwise management will be very difficult.

We should include this work in the current ticket. We need to preserve the
functionality for global admins to view all organizations, otherwise
management will be very difficult.
--
Ashwin Ramaswami
On Wed, May 24, 2023 at 7:13 AM Matthew Bachtell @.***>
wrote:

@.**** commented on this pull request.
Works as intended but this introduces the need for larger change.
A Global Admin should be able to see all organizations when "My
Organizations" is selected. After this change a global admin sees an empty
screen because they are not members of the given organizations (see
screenshot).
@epicfaace https://github.com/epicfaace, @stewartl97
https://github.com/stewartl97 - Should this work be rolled in to this
ticket, individual tickets, or be a sprint in and of itself because of the
work involved?
[image: image]
https://user-images.githubusercontent.com/126006749/240584491-38082cd6-c38c-4a92-b7a4-2a9deef6d99e.png
—
Reply to this email directly, view it on GitHub
https://github.com/cisagov/crossfeed/pull/1929#pullrequestreview-1441575285,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAM4MXYORXSKQV5DIK63EBLXHXUPBANCNFSM6AAAAAAYKZNCTI
.
You are receiving this because you were mentioned.Message ID:
@.***>


X-Forwarded-For in Public/Private Frontends

The public/private frontends should set X-Fowarded-For and friends when they're not set in the HTTP request.

Tangentially related comment about the x-forwarded-host host header we decided not to support in the frontend: https://github.com/openziti/zrok/pull/492#issuecomment-1857144310

This is already implemented and working well.


[WIP][jvm-packages] xgboost-spark warning when Spark encryption is turned on

Tracking Github issue: https://github.com/dmlc/xgboost/issues/3647
Issue: Apache Spark users running XGBoost on Spark may expect over-the-wire encryption for XGBoost based on Spark confs, but they will not get it and may never know about the security issue.
This PR changes XGBoost.trainDistributed to check the Spark conf spark.ssl.enabled and throw an exception if the user expects encryption over-the-wire.
In the error message, this tells the user how to get around this security check at their own risk.
The user can tell xgboost-spark to ignore spark.ssl.enabled by setting an xgboost-specific conf in the SparkConf: xgboost.spark.ignoreSsl.
This adds 1 unit test with XGBoostClassifier to check this behavior.

The last failure was spurious (from timeout).  Pushing NOP update to retest.

It seems like other Travis builds are having timeout issues too.  Will return to this tomorrow.

@CodingCat OK definitely understandable that you're busy!
@hcho3 Any chance you'd be able to check this out?  I appreciate it!

@jkbradley Wish I knew anything about Java world hehe :)

Thank you!  Btw, do you know what the ETA for a new release of xgboost-spark is?


Update README.md

Codecov Report

Merging #7 (efde3fc) into master (90e4ab4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #7   +/-   ##
=========================================
  Coverage     20.00%   20.00%
  Complexity        2        2
=========================================
  Files             4        4
  Lines            20       20
=========================================
  Hits              4        4
  Misses           16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90e4ab4...efde3fc. Read the comment docs.


musl: 1.2.3 -> 1.2.5

Description of changes
https://musl.libc.org/releases.html
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

There is already an open PR: #229439

Oops, thanks @tobim

Help PRing fixes for later musl versions is very welcome!


performance

cool project :)
there are certainly much faster frameworks than React these days (though most will require a JS/browser env).
https://krausest.github.io/js-framework-benchmark/current.html
i'm not sure about the advertised performance claims here, however.
ImGUI in the browser suffers from the same idle perf issues, see this ImPlot demo: https://github.com/epezent/implot/discussions/183#discussioncomment-4618915
i think there's a way to mitigate this somewhat by suspending the render loop or something, but dunno how this works out in real life.

I haven't done any proper CPU/GPU profiling yet and haven't constructed benchmark-worthy tests, so so far it's just a bunch of hand-waiving and wishful thinking on my side 😃.
I will adjust the docs to add a big note explaining that the library hasn't been battle tested yet.
Regarding CPU usage – I will have to dig much deeper into that at some point.
I am not sure what is the 'Reduce FPS when app is idle' in the comment you linked. Most browsers automatically pause requestAnimationFrame() when tab is inactive: StackOverflow answer.
If you have some resources about JS profiling, performance, CPU/GPU usage topics – I would be very grateful for any links!

https://renderdoc.org/ is the gold standard AFAIK but hard to get working for WebGL. Spector.js seems lile next best thing: https://github.com/BabylonJS/Spector.js/
https://twitter.com/gordonnl/status/1208127522044596225
https://twitter.com/bitnenfer/status/886003748371353600?lang=en
https://old.reddit.com/r/webgl/comments/xo7wwu/profiling_tools_for_webgl/

Thanks so much! This is incredibly useful.

@tchayen there is still value in stopping the render loop when the tab is open. My imgui/canvas apps all have the same problem of eating a bunch of battery and overheating phones when looked at for too long. And you don't really need to re-render most of the time, only when interactions or animations happen.


Error with RSpec/ChangeByZero

Hi,
While running Rubocop (1.64.1) w/ rubocop-rspec (3.0.1), I'm getting the following error:
5 errors occurred:
An error occurred while RSpec/ChangeByZero cop was inspecting /home/runner/work/platform-atlas/platform-atlas/spec/controllers/product_directory/codeowners_controller_spec.rb:102:8.
An error occurred while RSpec/ChangeByZero cop was inspecting /home/runner/work/platform-atlas/platform-atlas/spec/controllers/product_directory/codeowners_controller_spec.rb:135:8.
An error occurred while RSpec/ChangeByZero cop was inspecting /home/runner/work/platform-atlas/platform-atlas/spec/controllers/product_directory/products_controller_spec.rb:124:8.
An error occurred while RSpec/ChangeByZero cop was inspecting /home/runner/work/platform-atlas/platform-atlas/spec/controllers/product_directory/teams_controller_spec.rb:135:8.
An error occurred while RSpec/ChangeByZero cop was inspecting /home/runner/work/platform-atlas/platform-atlas/spec/controllers/product_directory/teams_controller_spec.rb:312:8.
Errors are usually caused by RuboCop bugs.
Please, report your problems to RuboCop's issue tracker.
https://github.com/rubocop/rubocop/issues

Inspecting [16](https://github.com/department-of-veterans-affairs/platform-atlas/actions/runs/9489870762/job/26152087527#step:6:17)4 files
....................................................................................................................................................................

164 files inspected, no offenses detected
Mention the following information in the issue report:
1.64.1 (using Parser <IP_ADDRESS>, rubocop-ast 1.31.3, running on ruby 3.2.4) [arm64-darwin23]

Unfortunately this repo is currently private, but the following lines, respectively, caused the 5 errors:
change(ProductDirectory::Codeowner, :count).by(0) X 2
change(ProductDirectory::Product, :count).by(0)
change(ProductDirectory::Team, :count).by(0) X 2
Hopefully that's all you need to investigate - Thank you!!

@ryan-mcneil Thank you for your report.
I could not reproduce it with just the code you provided. Can you give us the code to reproduce it?

If you can’t provide a full example, perhaps you can run rubocop with -d flag and provide the error and rubocop backtrace?

Hey, apologies for the delay.
So, I dug in a bit to see how I could provide enough context code to get it to work properly. It wasn't my code, so I had to figure out what they were trying to do. Turns out, they were using that line incorrectly. They were using change(ProductDirectory::Codeowner, :count).by(0) AS an expectation, vs being used in conjunction with an expectation
expect { some_action }.to change(ProductDirectory::Codeowner, :count).by(0).
Fixing that, the errors actually went a way. So this may not be an edge case you need to fix. But perhaps an idea for a future cop could be checking for orphaned, useless matchers 🙃 😆
Sorry for the false alarm!

Thanks for the feedback!
We’ve just merged a new cop that helps with similar situations, but bot exactly what you describe.


proj: Serenata de amor

This project only deals with brazil government.
However, based on the FAQ, they'd be happy about adoptions for other countries.
It's debatable whether it should be included in this list.

Will fix the linting errors
$ yamllint serenata_de_amor.yaml
serenata_de_amor.yaml
  7:1       error    trailing spaces  (trailing-spaces)
  20:81     error    line too long (104 > 80 characters)  (line-length)
  21:81     error    line too long (111 > 80 characters)  (line-length)
  31:81     error    line too long (81 > 80 characters)  (line-length)


⚠ pishem-otzivi has degraded performance

In bb1c5c6, pishem-otzivi (https://пишем-отзывы.рф/) experienced degraded performance:

HTTP code: 200
Response time: 9079 ms

Resolved: pishem-otzivi performance has improved in 2898ed9.


Attention sign instead of yellow halo in overview checkbox

The yellow halo around overview checkbox, when the overview mode doesn't fit on screen is not very informative.
Replace it with atention/warning sign.

replace green halo with nothing (everything is fine)
replace yellow halo with this icon: http://fontawesome.io/icon/exclamation-triangle/

Issue moved to Caleydo/lineupjs #413 via ZenHub


bump kyma_verison  to master-9ec03fed

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

/test all

@lauraanddola it looks like it could be closed. Please verify

it is outdated and closed it.


balance tx with additional utxo map

Closes #1000 .
@klntsky Can you please check if this is according to the guidelines and what else is needed? I did a rough test. I successfully chained three dependent transactions into one block.
Pre-review checklist

[X] All code has been formatted using our config (make format)
[ ] Any new API features or modification of existing behavior is covered as defined in our test plan
[ ] The changelog has been updated under the ## Unreleased header, using the appropriate sub-headings (### Added, ### Removed, ### Fixed), and the links to the appropriate issues/PRs have been included

@the-headless-ghost sorry for slow response. Could you please resolve the conflicts?

I just noticed that the UtxoMap type changed. Instead of TransactionOutput we have TransactionOutputWithRefScript. I don't know if this still makes sense in this context. Should I keep this type, or should I change it to Map TransactionInput TransactionOutput?

Reopening as #1046. We need it to be on a local branch for CI to run.


Dev - Unable to send new message, getting console error

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to any chat report
Send a message

Expected Result:
Message should be sent
Actual Result:
Message is not sent, and there are console errors
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: Dev 1.3.39-7
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/4edd3913-b992-463c-9bdc-f4ed278e4620
Expensify/Expensify Issue URL:
Issue reported by: @hoangzinh
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689118735900729
View all open jobs on GitHub

Is any compensation due here @hoangzinh?  I don't see a trail for the commit above or via the Slack discussion to what fixed this

Thanks @hoangzinh , closing


Concept list to Concepticon before release?

I'll have a look at the data in a bit; one small question before that: Having the concept list in Concepticon proper instead of in this repository would be nice. Have you talked about this before, @ilchec and @LinguList?

Sorry to not answer to this earlier: the current procedure we have the best experience with is to have a release of the code, publish the paper, and then add the concepts to Concepticon, as this means that the paper is also there and not quoted as "forthcoming" and we have to update the information in Concepticon later (e.g., also changing the year in the ID of concepts). This worked so far okay with Gerardi-2021-414, although this is not the prime example, since in this dataset, the number of concepts in the paper differs from the actual number in the data, etc., but it would've been Gerardi-2020-404 first, and then Gerardi-2021-414, etc., so lots of changes.

Sorry to not answer to this earlier: the current procedure we have the best experience with is to have a release of the code, publish the paper, and then add the concepts to Concepticon, as this means that the paper is also there and not quoted as "forthcoming" and we have to update the information in Concepticon later (e.g., also changing the year in the ID of concepts). This worked so far okay with Gerardi-2021-414, although this is not the prime example, since in this dataset, the number of concepts in the paper differs from the actual number in the data, etc., but it would've been Gerardi-2020-404 first, and then Gerardi-2021-414, etc., so lots of changes.

No worries and thanks for the explanation! At the time of opening the issue, I wasn't aware that the paper is still to be published. Makes sense to wait then. :)

No worries and thanks for the explanation! At the time of opening the issue, I wasn't aware that the paper is still to be published. Makes sense to wait then. :)

Therefore we also have the different wording, since this paper
supplemnets the CLDF directly, upon publication.

Therefore we also have the different wording, since this paper
supplemnets the CLDF directly, upon publication.


Top level completion item order should prioritize by snippets

Description:
Top level completion item order should prioritize by snippets

Duplicate of #13550


Failed to parse 1 export

When I try to open some assets, I get the error "Failed to parse 1 export" and can't change anything in the Export Data because it's empty.
Game: Lego 2K Drive
UE4 version: <IP_ADDRESS>
I tried latest release: v<IP_ADDRESS> (9418e64 - a5978d9)
Also tried latest build (follow compilation process): v<IP_ADDRESS> (d0773e5 - 79e998b)
OS: Win10
Here are example files:
assets.zip

Sorry for the wait! Fixed in atenfyr/UAssetAPI@2aa8334


Skip TestMeshNetworking test

There are a bunch of flakes and blocking other PRs fxing flakes from
gonig in
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[x] Does not have any changes that may affect Istio users.

Force merging since there are co-dependant test fixing PRs


add ssh support

To use private repo's through Glide, we need SSH support in the docker container.
In addition to this, when using the container you will need to mount your SSH keys, through docker-compose you can add the following volume

~/.ssh/id_rsa:/root/.ssh/id_rsa

Should we just delete this one and merge https://github.com/graze/docker-golang-tools/tree/ssh-ability as it has everything needed?

https://github.com/graze/docker-golang-tools/pull/4 if you want to swap

Closing as duplicate


GLES2 Lightmap baking issue with GridMap

Godot version:
3.2.1, godot-bin packaged from Arch User Repository.
OS/device including version:
Arch Linux latest 2020-04-06
Kernel version:  5.5.13-arch2-1
NVidia module driver version: 440.64
CPU: Intel(R) Core(TM) i7-4790K CPU @ 4.00GHz
GPU: 01:00.0 VGA compatible controller: NVIDIA Corporation GP107 [GeForce GTX 1050 Ti] (rev a1)
Issue description:
Got Artifacts by baking the Lightmaps for GLES2 with a GridMap.
screenshot.png
Steps to reproduce:
Import  the glTF 2.0 file into Godot as scene with Light Baking: Gen Lightmaps as import setting to auto unwrap uv2 maps. Export the Scene as tiles.meshlib.
Add following Nodes:

Add WorldEnvironment and Environment with ProceduralSky.
Add GridMap with tiles.meshlib.
Add DirectionalLight and transform the rotation.
Add BakedLightmap change Mode to RayTrace and Quality to High.

Draw a test case in the GridMap and change the extends of the BakedLightmap suitable for the test case.
Click on Bake Lightmaps button.
Minimal reproduction project:
https://github.com/vansoest/GLES2LightmapIssue

Duplicate of #29203 and #30929. The lightmapper will be rewritten in Godot 4.0.


Prevent invisible/inactive cpupparticles2d to redraw

While investigating my game's performance bottleneck, I found several problems in CPUParticles2D.

case
initial state
problem

1
non-visible, emitting off
_update_render_thread() keep calling on every frame, and causes needless multimesh updates.

2
non-visible, emitting on
same as case 1

3
visible, emitting off
_update_render_thread() is not called, but keep drawing multimesh using glDrawElements

My game had frame drops because of these problems since our characters normally have explosion effects off by default(whatever cases described above).
I confirmed that our game gain quite a lot fps increase with this fix.
I would like @reduz or someone to review this PR and merge before 3.1 release.

@reduz says it looks good, but the same changes need to be done for CPUParticles (3D).

Thanks for your review. I've applied the same logic to CPUParticles(3d).

Thanks!


Sum Of Two Integers Questions

Calculate the sum of two integers a and b, but you are not allowed to use the operator + and -.
Example 1:
Input: a = 1, b = 2
Output: 3
Example 2:
Input: a = -2, b = 3
Output: 1

Please add the entire question on top as a comment. Check the other codes in the repository for reference.


Delete old unix makefiles and scripts

This pull request works in-conjunction with issue #343 which moves the repository over to cmake only build system. I have removed some unix makefiles and scripts and other ancient artifacts that are no longer relevant to the cmake build system.
Note: This pull request will fail any review checks that rely on these old systems.

As I already told you on IRC, the configure script is not going away.
At the very least we would then have to have cmake 2.8-support in place again. That was removed last year with the reasoning that we still had 'configure' that for example the long-term-stable enterprise distros can use, and thus we could safely make use of more of the modern cmake features from cmake 3+.

I thought you said it was not going away until cmake support matched configure support, as with my PRs it now does.


Unread counts not updating as new messages come in

On version 1.0.18, the app seems to not update to add new unread message counts after the app is loaded?  At least, I just got into a state where the "Unread" tab was blank, and then some messages were sent to a stream I'm on (showing up as unread in the webapp) , and neither the "Unread" tab not the "Subscribed" tab showed those messages as unread, even though the webapp did.

Actually this seems like a potentially deeper issue; I closed and restarted the app, and that view is still blank.  Maybe worth checking Sentry to see if my phone is throwing exceptions.

This is an old issue with multiple fixes and improvements since then.
Considering it fixed.


Add gitignore

Add gitignore so git tree is not dirty after a build

I don't like .gitignore.
I rather like to have a "clean" build process.
Use "make clean" and git status to see that nothing is left over.
The ignore file suppress left over files after "clean"
But this is my own opinion, i will let Frank decide.

IMHO Most projects I use I expect to be able to build and still have a clean git tree.
You can still do "make clean" then "git clean -dfx" to see what's left after a "make clean".  "git clean -fdx" won't take .gitignore into account.  It'll clean everything and tell you what it deleted.

thanks Mikey, i was not aware abou this feature, so, yes than we can take this branch.


Peer and Team Grading Tests

When grading my Team Test using the github.io page, submit your scores here.

Testing utterances


Adding action drain on node

Feature: Ability to drain node

drain action available on node

if drained successfully, state should show drained, else it'll stay in draining state and error message would be displayed in logs, UI and under conditions (NodeCondition Drained)

to stop the draining process / or activate a drained node - action uncordon is available. node should then return to active state.

to call drain from API, the input would look like -

curl -u $token --insecure -H 'Content-Type: application/json' https://localhost:8443/v3/nodes/local:machine-k6ct9?action=drain-X POST -d '{"deleteLocalData":"true","force":"false","gracePeriod":"-1","ignoreDaemonSets":"true","timeout":"20"

Information about the params and default values -

type NodeDrainInput struct {
	// Drain node even if there are pods not managed by a ReplicationController, Job, or DaemonSet
	// Drain will not proceed without Force set to true if there are such pods
	Force bool `json:"force,omitempty"`
	// If there are DaemonSet-managed pods, drain will not proceed without IgnoreDaemonSets set to true
	// (even when set to true, kubectl won't delete pods - so setting default to true)
	IgnoreDaemonSets bool `json:"ignoreDaemonSets,omitempty" norman:"default=true"`
	// Continue even if there are pods using emptyDir
	DeleteLocalData bool `json:"deleteLocalData,omitempty"`
	//Period of time in seconds given to each pod to terminate gracefully.
	// If negative, the default value specified in the pod will be used
	GracePeriod int `json:"gracePeriod,omitempty" norman:"default=-1"`
	// Time to wait (in seconds) before giving up for one try
	Timeout int `json:"timeout" norman:"min=1,max=10800,default=60"`
}

https://github.com/rancher/rancher/issues/14265
https://github.com/rancher/types/pull/498

Two things to think about.

when a handler runs on a key it locks that key and no other handlers run on it.  So while drain is running, no changes can be done to nodes.  That probably isn't good as drain can take a long time.  So it would be better to run drain in the go routine, not blocking the handler method.
You should be able to cancel a drain operation.  I haven't read this PR in depth, so I'm just guessing that there is no cancellation today.  Basically you should be running drain in a background goroutine, passing a context.Context object to it.  If the user changes the state so it does undrain, then the context should be canceled.  There could be a different approach if kubectl drain actually watches for changes in the node and cancels itself.  That I don't know.

@ibuildthecloud Thank you!!
Yeah, currently kubectl doesn't watch for changes, they just say  You should not operate on the machine until the command completes. It can only be prevented from taking a long time by giving shorter timeout. I'll update to use the go routine and passing the context.

LGTM


Grouping labels & fields

A common use case when building forms is the need to group labels and fields, or multiple fields together. Let's discuss these cases.
A label + a field
It's the most common use case. That's for instance what is generated by Rails scaffolding:

    <%= form.label :first_name %>
    <%= form.text_field :first_name %>

When the field is a check_box or a radio_button, you usually want to invert the label and the input:

    <%= form.check_box :accepts_terms %>
    <%= form.label :accepts_terms %>

We could have a ViewComponent::Form::GroupComponent for this purpose.
We could also add a label option to some helpers (see #16).
Errors
When a field has errors, it's a good practice to display them next to the field. The errors could be handled by the ViewComponent::Form::GroupComponent.
Hints
Some fields require additional information to help the user. The ViewComponent::Form::GroupComponent could accept a hint option for this. See GOV.UK for an example implementation.
A group of fields (and their labels)
The <fieldset> element is used for this.
<fieldset>
  <legend>Your identity</legend>

    <%= form.label :first_name %>
    <%= form.text_field :first_name %>

    <%= form.label :last_name %>
    <%= form.text_field :last_name %>

</fieldset>

Rails does not provide a dedicated helper for this element.
We could have a ViewComponent::Form::FieldsetComponent for this purpose, or reuse the ViewComponent::Form::GroupComponent (but it would make it more complex).

Here are some syntax options for groups, which one do you prefer? Or maybe we can implement both?
1. Additional params to the existing Rails helpers
We could pass strings:
<%= f.text_field :first_name, label: "First name", hint: "How should we call you?" %>

  First name
  How should we call you?
  <input type="text" id="user_first_name" name"user[first_name]" />

In this case the label and the hint come from the locale files:
<%= f.text_field :first_name, label: true, hint: true %>

# config/locale/en.yml
helpers:
  label:
    user:
      first_name: First name
  hint:
    user:
      first_name: How should we call you?

We can also pass hashes with a :text key. This allows us to add more params later (for instance to add class or position). That's similar to what GOV.UK does.
<%= f.text_field :first_name, label: { text: "First name" }, hint: { text: "How should we call you?" } %>
<%= f.text_field :first_name, label: { text: "First name", class: "my-custom-label" }, hint: { text: "How should we call you?", position: :after_input } %>

  First name
  <input type="text" id="user_first_name" name"user[first_name]" />
  How should we call you?

2. Using a group helper, with a block
<%= f.group :first_name, hint: "How should we call you?" do %>
  <%= f.text_field :first_name %>
<% end %>

  First name
  How should we call you?
  <input type="text" id="user_first_name" name"user[first_name]" />

I personally prefer the second one

After discussing it, we'll go for the second option (Using a group helper, with a block).
While working on a first implementation, we hit the following roadblocks:

it would be useful for the input to "inherit" some options from the containing group (for instance if the group has the class .form-group you may want the input to have .form-group-input)
there will be some similar I18n lookup logic in the group (label, hint) and in the input (placeholder), we should try to keep it DRY
when implementing the hint, we need to add the hint element ID in an aria-describedby attribute of the input.
when the group contains a collection of checkboxes or radio buttons, we don't want to use a  element for the group label, since the labels are already attached to each checkbox / radio

A potential solution to 1. 2. 3. is for the block to receive its own FormBuilder instance as an argument, so instead of:
<%= f.group :first_name, hint: "How should we call you?" do %>
  <%= f.text_field :first_name %>
<% end %>

we would have
<%= f.group :first_name, hint: "How should we call you?" do |g| %>
  <%= g.text_field :first_name %>
<% end %>

Then we could inject the class, placeholder, aria-describedby.
For 4. we may need to create another helper, such as collection_group or maybe pass a param label_tag: :div to group?
Feel free to contribute ideas :pray:

Hi, it would be great to have the "primitives" for this in the code...
I think having such a group method could be the second step, as the primitives "hints" and "error message" are always useful.
I created something like this. Maybe it is useful for anyone: https://gist.github.com/tmaier/22966c6bddac86e3612c8eddc072b919

Hi, it would be great to have the "primitives" for this in the code... I think having such a group method could be the second step, as the primitives "hints" and "error message" are always useful.

Hi @tmaier I opened an issue for this (#97) would you like to contribute a PR for this?

Related to #127

I've been playing around with a slot-based solution for this. There are some downsides as the syntax is not exactly the same as using a proper FormBuilder.
# frozen_string_literal: true

class Form::GroupComponent < ViewComponent::Form::FieldComponent
  renders_one :input, ->(input, options = {}) do
    "Form::#{input.to_s.camelize}FieldComponent".constantize.new(
      form,
      object_name,
      method_name,
      default_input_options.merge(options)
    )
  end

  def show_label?
    options[:hide_label] != true
  end

  def hint
    options[:hint] # || t(some.translation.key.default)
  end

  def default_input_options
    return {} unless hint.present?

    {aria: {describedby: hint_id}}
  end

  def hint_id
    form.field_id(method_name, :hint)
  end
end

<fieldset>
  <% if show_label? %>
    <label for="<%= method_name %>" class="block text-sm font-medium leading-6 text-gray-900"><%= label_text %>
  <% end %>

      <%= input %>

      <% if method_errors? %>

          <%= render IconComponent.new(name: :circle_exclamation, scheme: :alert) %>

      <% end %>

    <%= form.hint method_name, hint, id: hint_id %>
    <%= form.error_message method_name %>

</fieldset>

<%= form.group :email, hint: "What is the email you signed up with?" do |group| %>
  <%= group.with_input :email, autocomplete: "email", class: "w-full" %>
<% end %>

<fieldset>
  Email

      <input aria-describedby="admin_email_hint" autocomplete="email"
        class="w-full block rounded-md border-0 shadow-sm py-1.5 ring-1 ring-inset focus:ring-2 focus:ring-inset sm:text-sm sm:leading-6 text-slate-900 ring-slate-300 placeholder:text-slate-400 focus:ring-slate-500"
        type="email" name="admin[email]" id="admin_email">

    <div skip_default_ids="false" allow_method_names_outside_object="true" id="admin_email_hint"
      object="#<Admin:0x0000000170f4ac88>" class="mt-1 text-sm text-gray-500">What is the email you signed up with?

</fieldset>

It needs some more work (I have no idea, why it outputs an Admin instance), but I think there is some potential.


Using session for authentication

Modeling your App's User Session

We might want to use DynamoDB from Lambda

I don't know if Fluct itself can support it but I'll give it a try anyway in https://github.com/r7kamura/fluct-example.

I took a look about Amazon Cognito, but it does not so match with Web application use like fluct, so I decided to create sessions and users tables on Amazon DynamoDB.

session can be stored in cookies in encrypted format like Rails' session cookie store

I'll close this issue because fluct does not directly support this feature. It's an application's concern, but fluct will support the low-level features needed for that such as custom response headers, status code, etc.


Clicking from dropdown item hinder opened modal textinput to be focusable

Bug report
Current Behavior
When I click one dropdown item and open a modal, modal text input area not focusing. When I try to open the modal by simple button it does not hinder modal text input area to be focusable. I am not sure if both of the modal and dropdown opens in react portal led to this problem. See also my dom when using dropdown to open modal. I am using react flowbite modal also and it is opening on another portal

Using radix-ui dropdown component to open the modal(not work)

        <Dropdown
          open={open}
          onOpenChange={(event) => {
            setOpen(true);
          }}
          modal
        >
          <Dropdown.Trigger>click me</Dropdown.Trigger>
          <Dropdown.Portal>
            <Dropdown.Content side="bottom" forceMount>
              <Dropdown.Item>Item 1</Dropdown.Item>
              <Dropdown.Item>Item 2</Dropdown.Item>
              <Dropdown.Separator />
              <Dropdown.Item
                onSelect={(event) => {
                  setIsModalOpen(true);
                }}
              >
                Item 3
              </Dropdown.Item>
            </Dropdown.Content>
          </Dropdown.Portal>
        </Dropdown>

      <FileListContextModalNewFolder
        showModal={newFolder}
        setShowModal={setNewFolder}
        folderId={folderId}
        isModalOpen={isModalOpen}
      />

trigger the modal opening with simple button (works)

      <button
        onClick={() => {
          setIsModalOpen(true);
        }}
      >
       click me to open modal with simple button
      </button>

      <FileListContextModalNewFolder
        showModal={newFolder}
        setShowModal={setNewFolder}
        folderId={folderId}
        isModalOpen={isModalOpen}
      />

Expected behavior

Modal text input area should be focusable
Reproducible example
CodeSandbox Template
Suggested solution

Additional context

Your environment

Software
Name(s)
Version

Radix Package(s)

React
n/a

Browser

Assistive tech

Node
n/a

npm/yarn

Operating System

Can you provide a sandbox with code shown above? It'll be more easier to look into it

@joaom00  this is the codeSandbox for it
https://stackblitz.com/edit/react-6zrdi7?file=src/App.js

@sayinmehmet47 here a working example

is the trick here to use onCloseAutoFocuse? Can you explain it a little bit ? this was my sandbox . I need to use isModalOpen prop to send it to children. I dont understand how you solve it ?
https://stackblitz.com/edit/react-6zrdi7?file=src%2FApp.js
    onCloseAutoFocus={(event) => {
              inputRef.current.focus();
              event.preventDefault();
            }}

When a menuitem is selected, the menu is closed and trigger is focused, that is why your input isn't focused. If event.preventDefault() is called in onCloseAutoFocus the trigger will not be focused and your input inside of modal will receive focus

@joaom00 thanks your solution worked for me :)


Error when pinging bot on Discord, will not respond.

2024-12-05 11:41:47,511 ERROR: Ignoring exception in on_message
Traceback (most recent call last):
  File "C:\Users\Blue\AppData\Local\Programs\Python\Python312\Lib\site-packages\discord\client.py", line 449, in _run_event
    await coro(*args, **kwargs)
  File "C:\Users\Blue\Desktop\llmcord\llmcord.py", line 92, in on_message
    provider, model = cfg["model"].split("/", 1)
    ^^^^^^^^^^^^^^^
ValueError: not enough values to unpack (expected 2, got 1)

I know very little about python besides it causing me headaches, but did I manage to set this up all the way to the bot being online, connected to discord, and the config set to use LM Studio. I followed the pinned thread in issues to ensure everything was up to date, I just downloaded all of this today. I've tried multiple models, nothing is working to get me past the error above. Any input would be greatly appreciated.

From the looks of it, you have model set incorrectly in the config. It should be in the format of <provider name>/<model name>. For LM Studio you can try lmstudio/model (I don't think the model name matters with LM Studio unless you have multiple models loaded).

From the looks of it, you have model set incorrectly in the config. It should be in the format of <provider name>/<model name>. For LM Studio it should be lmstudio/model (I don't think the model name matters with LM Studio unless you have >1 models loaded).

Bingo! Thanks a lot, must've missed the difference in how to reference it. And here I was just typing in the model's api identifier and nothing else. Thanks again!

Sweet, enjoy 🫡


Document the dependencies on linux

I've left out wayland and gtk dependencies, because those backends aren't working anyway.
Fixes #46

Sure, makes sense. I made my best guess at the packages that need to be installed on fedora and debian/ubuntu. I'm not able to easily test the instructions, unfortunately...


modulePath returns incorrect path for nested-module structures

If you define your project in such a way you have more than one layer of modules, whenever you run tests for a specific class it will start a gradle task on the topmost parent module in the hierarchy.
For instance, imagine we have the following project structure:

myProject root

model
domain
presentation

feature1
feature2
featureN

Running any contextual testing action for a feature class will trigger a gradle task for the whole presentation module.
That can be problematic for projects with dozen of other sibling modules.
Executing tasks: [verifyPaparazziDebug, --tests, com.company.presentation.feature1.myClass] in project /Users/alex/git/myProject/presentation

The problem seems to be caused by the Path.modulePath extension, which probably assumes there will be only one layer of modules.
https://github.com/getyourguide/paparazzi-plugin/blob/c062d36f549f598a28b663f41638ad1c73870105/src/main/kotlin/com/getyourguide/paparazzi/Utils.kt#L63-L70

I checked the getModuleDir result for my project and it returned strange module paths under .idea folder, like:
/Users/USER/MyProject/.idea/modules/presentation/feature1

An easy workaround would be removing the ".idea/modules" from the module's path.
In additional to that, because we have nested modules, we need to get the path that is closer to the file. This can be solved by ordering the paths by size and choosing the first match with the biggest size.
The following implementation works and address both issues mentioned above:
internal fun Project.modulePath(file: VirtualFile): String? {
    return modules.asSequence().map {  it.getModuleDir().replace(".idea/modules/", "") }
            .sortedByDescending { it.length }
            .firstOrNull { file.path.startsWith(it) }
        ?: basePath?.let { projectPath ->
            val relativePath = FileUtil.getRelativePath(projectPath, file.path, File.separatorChar)
            val moduleName = relativePath?.split(File.separator)?.firstOrNull()
            if (moduleName != null) projectPath + File.separator + moduleName else null
        }
}


Add drug name matching query

Essentially identical to the Gene matching query, run one query to bucket the search terms into match types and get the IDs of the matched drugs, then query the drugs endpoint with the list of IDs.
Example query:
{
  drugMatches(searchTerms: ["SUNITINIB", "ZALCITABINE", "LINCOCIN", "TRASTUZUMAB", "PHLORETIN", "NOTREAL"]) {
    directMatches {
      searchTerm
      matches {
        id
        name
      }
    }
    ambiguousMatches {
      searchTerm
      matches {
        id
        name
      }
    }
    noMatches {
      searchTerm
    }
  }
}

Definitely! I forgot we had those now

Test added!


Push release for 0.7.0

@robert-bor I'm not able to push a release on this to sonatype.  Can you release 0.7.0?  The top commit has a bug fix.
Thanks,
Jeremy

Released under new GroupId for now as 'com.github.hazendaz'


From 1.7.2, upgrade to Orchard CMS 1.9.2 makes the Layout blank

After upgrading to Orchard CMS 1.9.2 from 1.7.2, in the edit page - view, I see these issues:
I am using Terra theme from Bind.

I see both body and layout seen.
The layout is empty.
It doesn't show the option Use existing layout
Some drag-and-drop elements in the layout are not seen.

probably has to do with the fact you have both BodyPart and LayoutPart in the ContentDefinition for that ContentType


Comment: State 'docker.loaded' found in SLS 'foo' is unavailable

I'm unsure if I am using this correctly but I am seeing the following error:
In my init.sls I have the following:
app-container-file:
docker.loaded:
- name: gunicorn-app-test
- source: salt://native/gunicorn-app-test.tar
Produces errors
      ID: app-container-file
Function: docker.loaded
    Name: gunicorn-app-test
  Result: False
 Comment: State 'docker.loaded' found in SLS 'native' is unavailable
 Started:
Duration:
 Changes:

docker-py                 0.5.0 (and tried 0.6.0)
Salt                           2014.7.0

@mooperd This isn't salt's issue tracker. Perhaps you should file this issue on https://github.com/saltstack/salt. We can't help you.


bootstrap issue - Cannot read properties of undefined (reading 'getStore')

As per the documentation here I chose to setup using the app.Use method and it looks like below
const app = await NestFactory.create<NestFastifyApplication>(AppModule,new FastifyAdapter());

//https://papooch.github.io/nestjs-cls/
const options: ClsMiddlewareOptions = {
  mount: true,
  setup: (context, req: Request, res: Response) => {
    if (!req.url.startsWith('/api'))
      context.set(SystemConstants.CurrentContext, new CurrentUserContext());
  },
};
app.use(new ClsMiddleware(options).use);

Then I have registered the ClsService in my AppModule like below
@Module({
  imports: [
    AppSettingsModule
  ]
  ,controllers: [AppController]
  ,providers: [ClsService]
})
export class AppModule implements NestModule{
  configure(consumer: MiddlewareConsumer) {
    consumer.apply(SwaggerAuthMiddleware).forRoutes('api');
  }
}

After that I inject the ClsService in one of my guards and use it like below
  @Injectable()
    export class AuthGuard implements CanActivate {
      constructor(private readonly contextService:ClsService, private readonly authService:AuthService, private readonly reflector: Reflector) {}

      async canActivate(context: ExecutionContext): Promise<boolean> {

    const test = this.contextService.get(SystemConstants.CurrentContext)
    return true;
}
    }

and at this line const test = this.contextService.get(SystemConstants.CurrentContext) it gives this error Cannot read properties of undefined (reading 'getStore')
I can't figure out any missing configurations I may have done. Btw. I am using FastifyAdapter. So not sure whether it has something to do with it.

There's multiple things going on in your setup that are wrong, let me go through them one by one:

If you're mounting the middleware manually, you need to set mount to false. However, in your setup it does not make a difference because you're not passing the options through ClsModule.forRoot

I do not understand why you're trying to mount the ClsMiddleware globally and then filter the route inside the setup. If you don't absolutely need to do that because of the order of other middlewares used, I would recommend mounting it n the AppModule instead

Even if you register the middleware manually, you need to register the ClsModule.forRoot and do not put ClsService in providers. It's provided by ClsModule.

The error you're seeing is caused precisely by this^. The ClsService has one constructor parameter, which is the AsyncLocalStorage instace which you don't provide and Nest can't inject it  - it's an implementation detail though, you shouldn't ever be putting 3rd party classes into providers because there's usually more that needs to be set up by the module.
It's like if you were to put CacheService from @nestjs/cache-manager directly into the providers array. It wouldn't work because it needs external setup like the data store configuration, which is done by the CacheModule.register method, which also in turn provides the CacheService for injection. The providers array should only be used for your application's providers - 3rd party ones are usually brought in via a module.

That said, the correct code (in my opinion) should look like this:
@Module({
  imports: [
    AppSettingsModule,
    ClsModule.forRoot({
      global: true // <- make ClsService available for injection globally
                   // alternatively, import `ClsModule` explicitly in modules where it is needed
      middleware: {
        mount: false // <- do not mount automatically (default, but better to set explicitly)
        setup: (context, req: Request, res: Response) => {
          context.set(SystemConstants.CurrentContext, new CurrentUserContext());
        }
      }
    })
  ],
  controllers: [AppController],
  providers: []
})
export class AppModule implements NestModule{
  configure(consumer: MiddlewareConsumer) {
    consumer.apply(
      ClsMiddleware, // <- mount middleware manually here, settings from module will apply
      SwaggerAuthMiddleware
    ).forRoutes('api');
  }
}

If, for some reason, you do need to mount the middleware in main.ts, you still have to import the ClsModule.forRoot(Async) to provide the ClsService.

great! got it to work and thank you!


Update fileset dependency

Closes #653

This also fixes the vulnerabilities introduced by this dependency as reported on issue #678.
This really needs to be merged in once the build is fixed.
@ntwb can you take a look why it is failing?

Looks, like there is an overall solution: #673


Could not ind ivy.xml

When trying to install node, yarn and npm with this configuration
node {
    download = true
    version = '8.9.1'
    distBaseUrl = 'https://nodejs.org/dist'
    npmVersion = '5.5.1'
    yarnVersion = '1.5.1'
    nodeModulesDir = file("${project.projectDir}")
}

The following error is received
Could not get resource 'https://nodejs.org/dist/v8.9.1/ivy.xml'.
Indeed, no ivy.xml file exist on nodejs.org website. What's wrong here ? How to fix ?

Could you please give more info on

which gradle version you use
how your build.gradle looks like
complete output

I have the same issue. There you go my build.gradle:
plugins {
    id "com.moowork.node" version "1.2.0"
}

node {
    distBaseUrl = 'https://nodejs.org/dist'
    version = '8.11.2'
    download = true
}

I am trying to run just nodeSetup behind the proxy. The Output looks like:
14:47:41: Executing task 'nodeSetup'...

> Task :nodeSetup
> Task :nodeSetup FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':nodeSetup'.
> Could not resolve all files for configuration ':detachedConfiguration1'.
   > Could not resolve org.nodejs:node:8.11.2.
     Required by:
         project :
      > Could not resolve org.nodejs:node:8.11.2.
         > Could not get resource 'https://nodejs.org/dist/v8.11.2/ivy.xml'.
            > Could not GET 'https://nodejs.org/dist/v8.11.2/ivy.xml'.
               > Connect to nodejs.org:443 [nodejs.org/<IP_ADDRESS>, nodejs.org/<IP_ADDRESS>] failed: Connection timed out: connect

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 50s
1 actionable task: 1 executed
Connection timed out: connect
14:48:32: Task execution finished 'nodeSetup'.

I'm also facing the same kind of issue, any solution/update on this would be great?

This is definitely a proxy issue. It's silently failing to get the dist zip and falling back to trying to get ivy.xml which doesn't exist.
For me, all my proxy settings were correct, but px was timing out for some mysterious reason. Swapping back to using cntlm worked. Using the proxy directly would also likely work.

Hi there,
Same problem on my side :(
Any idea how to solve this issue ? This ivy.xml seems to no longer exist in nodejs.org/dist ...
Thanks for your help :) !
14:37:07.077 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] * What went wrong: 14:37:07.077 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] Execution failed for task ':nodeSetup'. 14:37:07.077 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] > Could not resolve all files for configuration ':detachedConfiguration1'. 14:37:07.077 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]    > Could not resolve org.nodejs:node:8.11.2. 14:37:07.077 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]      Required by: 14:37:07.077 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]          project : 14:37:07.077 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]       > Could not resolve org.nodejs:node:8.11.2. 14:37:07.077 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]          > Could not get resource 'https://nodejs.org/dist/v8.11.2/ivy.xml'. 14:37:07.077 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]             > Could not GET 'https://nodejs.org/dist/v8.11.2/ivy.xml'. 14:37:07.077 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]                > sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderExcepti on: unable to find valid certification path to requested target

any progress on this ?

There's not much to do here, it's a proxy issue on your end.
The only progress that could be made on this issue is adding better logging/error messages when it occurs.

Had the same issue on one project, other project worked. Only difference was gradle wrapper version.
I now reverted the newer project from gradle 6.0 to gradle 4.10.3 and that works fine ;)
To change gradle wrapper version in your project you can use this cmd:
gradle wrapper --gradle-version=4.10.3
So I think this is related to the ticket: https://github.com/srs/gradle-node-plugin/issues/351
Also note: ivy.xml was a fallback and does not actually exist (saw that when checking the older project where it works for me.)
And secondly "proxy issue" doesn't make sense. Otherwise it would work for all or no projects on the same machine, which is not the case for me.
Hope that gives some insight to many devs suffering from this issue.

are there some plans to fix it?

I have seen this issue as well.  The problem is related to some optimization in the gradle repository resolution logic.  In gradle 6 the default behavior is to look only for metadata files and not the actual artifact (which is a second HTTP Get).  The old behavior can be restored with some additional configuration to the repository definition.
The issue with the node plugin is that for fetching the node artifacts the repository definition is somewhat hard coded in com.moowork.gradle.node.task.SetupTask.addRepository method, which will remove all configured repos for the project, set in a specific repo to use for node resolution, and will restore the project repos later when node is resolved.  To restore the old gradle resolution behavior requires a change like the following to this code to have gradle search for both the ivy metadata or the artifact (note the metadataSources enclosure).

    this.repo = this.project.repositories.ivy {
        url distUrl
        layout 'pattern', {
            artifact 'v[revision]/[artifact](-v[revision]-[classifier]).[ext]'
            ivy 'v[revision]/ivy.xml'
        }
        metadataSources {
            ivyDescriptor()
            artifact()
        }
    }

When I added this hack to a copy of the node plugin code and rebuilt it, I was able to get past this issue.
Another solution would be to get the ivy metadata file added for the node artifact in the repo hard coded in the gradle plugin: https://nodejs.org/dist (or point to a repo that has the missing ivy descriptor for this artifact).

The reason we forked this is because of Gradle 5+ compat, if you can live without grunt/gulp (or can use NpxTask to run them) there's https://github.com/node-gradle/gradle-node-plugin

Hello,
Thank you @deepy for solution! I can confirm that this is working well on Gradle 6.0.1
plugins {
    // id("com.moowork.node") version "1.3.1"
    id("com.github.node-gradle.node") version "2.2.0"
}

node {
    download = true
    version = "12.13.1"
    npmVersion = "6.9.0"
    yarnVersion = "1.17.3"
    nodeModulesDir = project.file("ui")
    workDir = project.file("${project.buildDir}/nodejs")
    npmWorkDir = project.file("${project.buildDir}/npm")
    yarnWorkDir = project.file("${project.buildDir}/yarn")
}

and now my Gradle tasks working as expected:
./gradlew nodeSteup
./gradlew npmSteup
./gradlew npm_i
./gradlew npm_run_build

Regards,
Maksim

Thank you @deepy for solution!

can confirm that @deepy's solution also worked for me. thx!
Thx @daggerok for testing and posting!

The reason we forked this is because of Gradle 5+ compat, if you can live without grunt/gulp (or can use NpxTask to run them) there's https://github.com/node-gradle/gradle-node-plugin

Hi, what should I do if our project use gulp.
apply plugin:'com.moowork.gup' node{      download = true      version='11.15.0' }
It cannot find ivy.xml and node-v11.15.0-linux-x86.tar.gz
I am running on Windows 10 with JDK 8 (64 bit) and JAVA runtime (64 bit)
Thank you.

How reliant on gulp are you? Could you use gulp through npx as a workaround?

How reliant on gulp are you? Could you use gulp through npx as a workaround?

@deepy
The project used to run fine for my Windows machine. Till we added
`

npm_run_build.mustRunAfter gulp_html
processResources.dependsOn gulp_html
`
do you know where I can find implementation documents about npx? Thank you!

Hello @daggerok
Any idea how I can use the defined node version into a Exec Task?
For example, the following build.gradle uses node 13 in the yarn_install task, but it uses the latest npm and latest node 18 in the Exec npm run ci Task.
plugins {
  id("com.github.node-gradle.node") version "3.5.1"
}

node {
    distBaseUrl = 'https://nodejs.org/dist'
    version = '13.9.0'
    download = true
}

// declare a build task
task build

// declare a task to ci test
task ci(type: Exec) {
    inputs.file("package.json")
	  commandLine "npm", "run", "ci"
}

//declare task dependencies
build.dependsOn ci
ci.dependsOn yarn_install

Hey there 👋 Node.js team here.
This behaviour was introduced with https://github.com/nodejs/build/issues/3223 so that y'all can track why this is happening now. Note that is expected behaviour. And that this https://github.com/srs/gradle-node-plugin/issues/292#issuecomment-562848790 comment above is a proper fix for the issue.
Extra details are also available here https://github.com/nodejs/nodejs.org/issues/5149#issuecomment-1476537829

Adding the ,plugin I still get the same error. Could it be because I am using node version 10 and that is not supported anymore?

You need Gradle 4.5 or newer, if you cannot upgrade from Gradle 4 I recommend you upgrade to the latest Gradle 4.10.3

Hi guys,  change distBaseUrl like this:
node {
  ...
  distBaseUrl = 'https://direct.nodejs.org/dist/'
  ...
}

ref from https://github.com/nodejs/nodejs.org/issues/5149#issuecomment-1470896878