Cache Chromium

It would be nice if Chromium used by puppeteer was cached in npm-cache folder. It's a quite big download and changing branches/cleaning local node_modules leads to redownloading from scratch.

Seems reasonable. I'm not an expert in how npm's cache works (or how it works with yarn). PRs welcome.

@JoelEinbinder I'm not an expert either :/ There must be some way we can do this. From a quick look I couldn't find any info, though.
BTW, this change might seem trivial to many people, but if you have a slow internet speed, it'll make a huge difference. ~123 MB isn't a small download.

Maybe just caching the download in the tmp folder would be a good first step? Although cache won't stick if one clears their temporary folder. I still cannot find any docs about this.

It would be nice if Chromium used by puppeteer was cached in npm-cache folder.

@XhmikosR I have a few concerns regarding this:

Using designated npm-cache, if there's any, will raise some questions regarding yarn-compatibility.
if you store all chromium revisions in the same designated folder, you'll have to have back-references to the installed puppeteer packages so that you can cleanup unused chromium versions. I'm not sure this is quite manageable.

This all makes it too complicated for us to get into; I'd wait for a better solution to appear somewhere.

It's a quite big download and changing branches/cleaning local node_modules leads to redownloading from scratch.

I can easily understand the pain; there are a few workarounds I can think of:

If you're using puppeteer directly, you can use PUPPETEER_SKIP_CHROMIUM_DOWNLOAD env variable and BrowserFetcher to manage chromium instances on your end.
you can also install puppeteer globally and hack NODE_PATH to teach require to get the module from the global install.
you can have a local proxy that will cache chromium revisions on its end. You can point puppeteer to use your proxy with a PUPPETEER_DOWNLOAD_HOST env variable.

Closing this since I don't think this is actionable on our end.

Thanks, but IMO your reply isn't the proper one. Anyway, I guess every packager which depends on puppeteer will have to struggle with this.

Would also love to see this feature added
Cypress was just recently dealing with the exact same problem of a big binary being redownloaded everytime and not cached. They recently solved the problem and I think it might help to have a look at how they did it, you might be able to do the same
https://github.com/cypress-io/cypress/issues/1300
https://github.com/cypress-io/cypress/commit/a4fa1b32f7f12483382466864d7e995936622dc3

Hi, you should try tiny-puppeteer

it's a shame you can't override executable download path via env_var
look how cypress did it

It's a shame you can't override executable download path via env var. Look how cypress did it.

@sdwvit it's totally possible. There's the PUPPETEER_SKIP_CHROMIUM_DOWNLOAD env variable, but even more handy is puppeteer-core package: puppeteer vs puppeteer-core

we really do need a way to change the download location.  right now puppeteer uses it's own directory, which means it gets downloaded to node_modules.  i frequently find myself using npm ci to prevent modifications to package-lock.json.  as others have mentioned, any dependency that requires puppeteer in a way that prevents hoisting will result in chromium being downloaded multiple times.  puppeteer-core also isn't feasible when you're dealing with dependencies of dependencies.  i find the quick dismissal of this issue to be unfortunate.

This shouldn't be closed. Any project with Puppeteer installed loses the ability to install its dependencies from the cache. Someone who cares about CI breaking when the site hosting Chromium goes down might want to fix this, for example.

Not caching chromium in npm-cache defeats the speed gains made by using npm ci. In fact, using npm ci Downloading the same build of chromium every time CI is run is super wasteful.

Electron had similar issue and it uses cache for downloaded binaries: https://www.electronjs.org/docs/tutorial/installation#cache

Maybe I'm missing something, but simply moving the downloadFolder to the home directory, or OS-cache directory, or at least making it configurable with an environment variable would make the default experience so much simpler.
https://github.com/puppeteer/puppeteer/blob/master/src/BrowserFetcher.ts#L146
Locally:

Why do I need to download the exact same revision of Chromium for every single project that uses puppeteer?
Want to nuke node_modules real quick? Congratulations now you're downloading ~200MB of chrome and offline/cached npm installs are broken (this has happened to me on multiple train rides/flights).

CI:

Why do I need to write a custom script and do environment variable fumbling to cache the chromium download?

Yes, it is possible to achieve this caching behavior with the skip download environment variables and all that, but it is incredibly cumbersome.
This issue is not about something not working at all, this issue is about a broken default.
I'd rather clean up my chromium download cache folder manually if I run out of diskspace (i.e. never) than stumbling over this literally every single time I'm using puppeteer.
The install script could log a warning if there are too many chromium versions installed. Good enough imo.
Thanks for considering something like this 🙏

For other struggling with this:
If you put the dependency under devDependencies in package.json and run npm install or npm ci with the --production flag, installation of puppeteer will be skipped along with Chromium download.
Making the dependency dev only might have some other implications. See https://docs.npmjs.com/cli/v6/configuring-npm/package-json#devdependencies.


Setting current page number for surveys with visibleIfs leads to incorrect behaviour

Are you requesting a feature, reporting a bug or asking a question?
Reporting a bug
What is the current behavior?
I am building an application where I show the user a survey with multiple pages (each page has one question).
On answering every question I store the currentPageNo of the survey and the survey responses with onPartialSend callback.
I store the current-page number since if the user refreshes the page, I populate the survey with whatever answers already given, and bring the user to the last-answered question. I do this by means of passing the answers in the data property and setting the page number in the currentPageNo property. Everything was working as intended when the survey questions were simple (no conditionals like visibleIfs).
I've encountered a couple of scenarios with some surveys(with visibleIfs in the survey-json) where after answering some questions and refreshing the page, the incorrect page number, and hence the incorrect question, is being displayed by the survey component. Printing the currentPageNo in onAfterRenderSurvey callback makes it clear.
Here are a couple of examples where the current page number being rendered is incorrect. I've fed the data to the survey as if its already refreshed.
How would you reproduce the current behavior (if this is a bug)?
Example 1 - This contains a simple survey-json with 4 questions
Survey without visibleif.
Setting the current-page-no works properly.
https://plnkr.co/edit/YmR8r2Mk0AfHwLyDfFjg?p=preview
Survey with visibleif
Setting the current-page-no as 2 does not seem to work
https://plnkr.co/edit/fztrUdbUcbGbTxCOoaFP?p=preview
Example 2 - A complex survey-json where the current-page number is incorrect
https://plnkr.co/edit/f7796gy1f87RpOezxijR?p=preview
Although the current-page-no is set to 9, it always jumps to 11 on rendering.
NOTE: All the currentPageNo values being set in examples are basically the values returned from survey-js after answering every question. I am hard-coding them in the example to make it easy to demonstrate the issue.
Specify your

browser: Firefox
browser version: 64.0.2 (64-bit)
surveyjs platform (angular or react or jquery or knockout or vue): react
surveyjs version: 1.0.66

@gnithin I have looked at the first plunker. It works fine to me.
currentPageNo is starting from 0. survey.currentPageNo = 0; will show the first page.
Should I look for other examples?
Thank you,
Andrew

@andrewtelnov The first plunker example was with survey-json entries without any visible-ifs. They do work fine, check out the next two -
Survey with visibleif
Setting the current-page-no as 2 does not seem to work
https://plnkr.co/edit/fztrUdbUcbGbTxCOoaFP?p=preview
Example 2 - A complex survey-json where the current-page number is incorrect
https://plnkr.co/edit/f7796gy1f87RpOezxijR?p=preview
Although the current-page-no is set to 9, it always jumps to 11 on rendering.

@gnithin I have changed your first plunker and it works now.
The problem, that it is important how to set here. You should set at first data, so the visibleIf should work and hide (questions/pages) before setting currentPageNo. Otherwise, the result maybe incorrect.
Thank you,
Andrew

@andrewtelnov That worked! I didn't know I can set those same values on the model object.
I simply used the properties in react component uptil now. Not sure if this a bug or not.
You can go ahead and close the issue if you think that this is not a bug to be fixed in the react-survey module.
Thank you so much for your help.

Thank you,
Andrew


Notes for deploying cloudblock on a Proxmox LXC

Please don't accept this pull request until we figure things out. Nevertheless, here are my notes so far for creating the LXC, everything after the container setup is the same as the local ubuntu install. Note that I also changed the playbook lines 179 to the following, but did not add this change to the pull request since we're still testing:
    - name: Cloudflared image
      ansible.builtin.shell: |
        docker build --security-opt apparmor:unconfined -t cloudflared_doh .
      args:
        chdir: /opt/cloudflared/

Closing this for now as I was not able to resolve getting Cloudblock working on a Proxmox LXC


Return default value processing

Default value processing when database is not returned

Thank you @china-live ,
We will look at it.
Best Regards,
Jonathan


API consistency with statsmodels

I noticed a few inconsistencies with how statsmodels works. For example, the results summary is a method in SM but a property in LM. Is this intentional?
I also see that predict method is missing, but it is implemented for many SM models. Are there plans to implement a predict function? Handling fixed effects (and lagged dependent variables if implemented) would be nice.

I'll also ask about the relationship to statsmodels.  Both this and "arch" look really well put-together.  How do you decide what goes in these packages vs what you contribute to sm?

For example, the results summary is a method in SM but a property in LM. Is this intentional?

Yes, this is intentional.  It has no arguments and so I find it simplest to use properties for values that do not accept options.

I also see that predict method is missing, but it is implemented for many SM models. Are there plans to implement a predict function? Handling fixed effects (and lagged dependent variables if implemented) would be nice.

predict is conceptually hard in FE models since one has to think hard about what a FE is.  In the standard fixed-T, large-N framework, fixed effects cannot be consistently estimated and so I can't see how a "prediction" is meaningful. Predict is similarly difficult for many other estimators, e.g., Between Effects or First Difference.   It is also very fragile when models can be specified using a formula since the prediction matrix has to be carefully constructed to match the original data structure.

I'll also ask about the relationship to statsmodels. Both this and "arch" look really well put-together. How do you decide what goes in these packages vs what you contribute to sm?

They try to be SM-like although there are differences, as noted above. I tried to make some large changes through SM to the unit root stuff but I found the process too slow to get in and the release schedule too long for my tastes- when I write something that is well tested, I prefer to make it easily available for users to install.  There are other challenges specified to linearmodels such as the time it takes to run the test suite which would timeout travis for statsmdoels.


Display information about downloadable object

Displays information about a downloadable object, including size and format.
fixes #235

I think there's an issue with state here, where once the info is displayed for one object (objects/UhixZnaWBmeXGNkZ74hYpE), it displays the same info for other objects when I select them. Maybe this is just because that info is not available for these objects, so it doesn't replace what is already there?

OK, a couple of things going on here

requests that errored out were not resetting the downloadSize property in state
using the props.location.match.id was not producing the desired result, since that prop didn't update right away. Instead, we now use the identifier from the fetched data.

Ah, ok! Yeah, this is looking good.


select Html Element Not Updating Correctly After Specific Interactions

Which package(s) are affected?
Lit Core (lit / lit-html / lit-element / reactive-element)
Description
link to playground lit
I've encountered an issue with select html elements in Lit where the selectedIndex property does not update as expected after a series of specific steps, even though the HTML updates correctly. This results in the second dropdown not resetting to its default state.
Expected Behavior:
After selecting a item from dropdown 1, dropdown 2 should reset to its default state ('b0') regardless of the previous selections.
Additional Details:
This issue seems to occur only after a specific sequence of interactions with the dropdowns, suggesting that it might be related to how state changes are handled or propagated.
Could you please help investigate this issue? It seems to impact the usability of forms that rely on conditional dropdown selections.
Reproduction
Go to the provided Lit playground link
Perform the following sequence of actions:

Select 'a1' from dropdown 1, then select 'b1' from dropdown 2. At this point, everything works as expected, and if you select 'a2' from dropdown 1, dropdown 2 resets to 'b0'.

Now, select 'a1' again, choose 'b1' from dropdown 2, then select 'b0', and 'b1' again from dropdown 2. Finally, when you select 'a2' from dropdown 1, the issue occurs: dropdown 2 incorrectly stays on 'b1' instead of resetting to 'b0'.

<select id="tselect2" data-sel2="b0">
            <option value="b0" selected>b0</option>
            <option value="b1">b1</option>
            <option value="b2">b2</option>
</select>

Despite the selected attribute being correctly set to "b0" in the HTML, the selectedIndex property of the select element incorrectly remains at 1, causing 'b1' to be displayed as the selected option instead of 'b0'.
Workaround
I have not found a workaround
Is this a regression?
No or unsure. This never worked, or I haven't tried before.
Affected versions
Failing in 3.2.0
Browser/OS/Node environment
Browser: Chrome
SO: MacOS 14.3.1

Changing the boolean attribute bindings to property bindings seems to fix it. I didn't fully digest the logic, but in general binding to attributes for live updates is not good since the platform generally uses attributes for interactive controls only until the user has interacted with the element.

Yeah, if you want more background, check out:

The dirtiness of an option element is a boolean state, initially false. It controls whether adding or removing the selected content attribute has any effect.


Support for Bedrock heads with prefix

I am running a server with GeyserMC enabled (Java x Bedrock crossplay) and I have a DiscordSRV plugin bot that uses this service for webhook PFPs. I would like to see this service support getting Bedrock heads if the username is prefixed with a * or a .. Please let me know of this is possible or if there is already a solution!

+1


Investigate Alaska Data Coverage for Existing Products

The NCEP Stage IV Mosaic 1hr, 6hr, 24hr products are produced for Alaska. These grids are not being downloaded at present, but sit adjacent to where the CONUS Stage IV grids are being acquired right now.

Not worth the effort to support AK until someone from that region provides all the relevent details (projections etc...)


Update iot-hub-device-management-iot-extension-azure-cli-2-0.md

The listed examples for setting tags or desired properties have syntax errors. Thus I propose to

remove obsolete spaces in value to key assignments
remove obsolete closing curly bracket in the tag setting example

@phylomeno : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@chrissie926 - Could you review the proposed updates to your article? Thanks.

When assigning variables in CLI, you do NOT put spaces around the = sign. It sohuld just be like avariable=thisisthevalue.

#sign-off

@robinsh: I'm sorry - only the author of this article, @chrissie926, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

I'm on the content team. Please accept and merge this change.

@robinsh: I'm sorry - only the author of this article, @chrissie926, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@robinsh Thanks for the review.


Cleanup

These changes are sometimes simplifications sometimes unnecessary references. None of them change the functionality of anything but are mostly just easier to read or slightly increase Performance(like using Mutex::get_mut instead of Mutex::lock).

Thanks for the feedback! I implemented the changes you requested.
I also updated the dependencies which didn't require further changes.

@Nereuxofficial Thanks, it's merged!

@Nereuxofficial I added you as collaborator so you don't have to fork every time

@Nereuxofficial  I also added CI so tests are run before merging

Thanks! I sadly don't have much experience yet with NEAT or GRUs but i'm reading into it.


feat: ability to search in installed apidocs

i think this feature is useful. maybe it's a little crude, but it's better than not having the feature at all...

Intersting, I didn't know I needed this until now. But naming it DevdocsGrep would be better I think.

Sure, I can rename it a little later today! Why I wrote it was crude...

it doesn't respect the setting to pipe though glow
it shows the internal filenames such as 1.md instead of the real keys such as.. String.reverse or whatever

But going all the way would be quite a lot more work, and possibly too slow to be useful. I guess this is good enough, and can be improved though time potentially.

modified the PR to now use the Grep terminology.

I think displaying the raw markdown is okay in this case, using glow actually doesn't make sense.
I found that we can hook in the live_grep builtin and change the display by passing a custom entry_maker. Having this with floating window would aso be nice but it seems that we can't directly change the default selection mapping, so that'd require some silly workaround. I'll take a closer look later but I think it can be improved.

So I improved the result display format...

* it doesn't respect the setting to pipe though `glow`

I only realize it now, I thought you were talking about the previewer. The picker would just open the file in the current implementation.

We could get the last preview buffer using telescope.state but the main problem is making it work with glow. We don't have enough information so we'd have to pass the entire buffer to glow, and you know what'd would happen with large files, I also don't know how we can implement jumping in this case.
Any thoughts on this?

Glow output doesn't necessarily match the original one so jumping to the specified line won't always work. But this feature is still great and I just learned about conceallevel, with it set to 3 previewing raw markdown in neovim with treesitter is almost good as using glow. I'm working on some fixes now and I'll set it to 3 by default.


Test Flyover Vision Pipeline

Test Flyover Vision Pipeline
Problem
Flyover Vision code hasn't been tested and it is unknown how well things work.
Solution
Run code in flyover_vision_pipeline.py on images taken during flight tests to see how well it detects images.

Hello,
can i work on this?


ELECTRON-676 - Fixing Developer Tools window flashes before the popup

Description
"Developer Tools" window flashes briefly before "Dev Tools disabled" pop-up displays ELECTRON-676
Expected Result:
"Developer Tools" window should not flashes when displaying "Dev Tools disabled" pop-up
Fixing

Before

After

QA Checklist

[x] Unit-Tests
[ ] Automation-Tests

Attach unit & spectron tests results in PDF format against the above task lists for this branch

@vrbsm What is the difference between the old code and new code?

@VishwasShashidhar The old code allows show devtools when user call using command+shift+d. The devtools is closed in the 'devtools-opened' callback. My new code removes the 'devtools-opened' callback and doesn't register the accelerator: command+shift+d if codition is false (devToolsEnabled). Basically, the 'devtools-open' callback creates this bug

I'll merge this once we have the new build ready.


[DRAFT] feat: handle IfElseOp in qiskit_to_tk

Description
NOT WORKING YET
Handling an IfElseOp as two conditional CircBoxes.
Related issues
Please mention any github issues addressed by this PR.
Checklist

[ ] I have performed a self-review of my code.
[ ] I have commented hard-to-understand parts of my code.
[ ] I have made corresponding changes to the public API documentation.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have updated the changelog with any user-facing changes.

The test case I added is now working.
I'll need to add more diverse test cases before I'm confident in merging this as well as negate the "else" condition properly and see what the story is for more complex conditions.


Update to Rails 5.0

This PR updates the application to Rails 5.0 and resolves all deprecation warnings which should make the transition to 5.1 easier.
This also removes the local environment with development and adds a staging environment for non-production deployments.

So CI is green again, but our build went from 45s to 6.5m. I'm going close this PR while I play with tweaking the travis config so this stops spamming the team.


Move @nuxt/schema to dev deps

Move @nuxt/schema dependency into dev deps and mark it as external to avoid breaking types every time Nuxt updates.

This didn't fix the problem

It works with npm.  This seems to be fixed, closing


Example for ensembles with ModelWrapper.

We should have an example on how to use EnsembleModelWrapper.
Basically:
wrapper = EnsembleModelWrapper(..)
N_MODELS = 5

for _ in range(N_MODELS):
   wrapper.model.apply(reset_weight_method)
   wrapper.train_on_dataset(train_dataset, ...)
   wrapper.add_checkpoint()

# We now have 5 models when we use predict!

# The shape will be the same as MC-Dropout [batch_size, C, ..., Iterations]
predictions = wrapper.predict_on_dataset(...)

Fixed in Baal 1.3


Fixed doc typo example get_user_stream_strings

Fixed typo in documentation
Issue: https://github.com/pan-unit42/dotnetfile/issues/6

Thanks for your contribution, the typo has been fixed in version 0.2.4


Question: How is this different from those 'awesome' lists on GitHub?

https://github.com/sindresorhus/awesome

I guess this is more like a list of one-hit ko of topics :hand: :

It's not. Doesn't have to be. :)

I hope that remains to the idea of one single link for topic

@ghpabs The link your shared is AWESOME! I didn't know that list exists before, so thanks for sharing it here 👍
I often found it difficult to start learning new tech because there are just too many resources available online. I thought it would be nice to have a list where each topic only has one link and is recommended by someone who has experience with the technology.
I first created the list to help underclassmen in my college to get started in doing side projects. And I have ABSOLUTELY no ideas how this repo got so popular. In the future, this list will be maintained in the same way. Quoting @Ibrahim-Islam, it is going to be "a list of one-hit ko of topics" 🎯


A wrong error caught in initializing process?

Hi, there. I set the slider component with following params, which interval is specified to 0.005:
{
    width: "auto",
    tooltip: 'hover',
    min: 1,
    max: 4,
    interval: 0.005,
    disabled: false,
    clickable: false,
    tooltipStyle: {
        "backgroundColor": "#000",
        "borderColor": "#000"
    }
}

The appearance and operation is normal in the interface, but I found a error info in the console with [Vue-slider warn]: Prop[interval] is illegal, Please make sure that the interval can be divisible.
I found the logic to judge the effectiveness of interval is (this.maximum - this.minimum) % this.interval !== 0, and I think it may be not exactly right since the precision of JavaScript itself can not strictly support such operation's judgement? Such as some integer is JavaScript would be represented as a bug number, 4 -> 4.0000000000000000003.
I think you can replace the division part to something else, such as modified the maximum value slightly according to user's interval setting. Hope the information can help you a little bit. Thanks for your effort in contributing in this component.

What is the version you are using now?
This bug may be the same as mentioned in #24 .

Sorry about that, the version I used is 2.1.2. I updated it to v2.2.2 and the error log disappeared.
I should search it before open the issue, sorry about the bothering.

It doesn't matter.

https://jsfiddle.net/2xy72dod/2477/
When use keyboard, there was the same bug

@Danilmet Thank you for your feedback, which was fixed in version 2.6.2.


chore: Show Tabs on recent access order

Description
Update IDE tabs order and limits

Show only recently accessed tabs
If recent tab is was already on screen, do not update order
Limit to just 5 active tabs

PR fixes following issue(s)
Fixes #30365
Media
https://github.com/appsmithorg/appsmith/assets/12022471/a53a93cd-1b5e-4341-ba4f-289c6bd82b6d

Type of change

Chore (housekeeping or task changes that don't impact user perception)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[ ] Manual
[ ] JUnit
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

Summary by CodeRabbit

New Features

Introduced new actions to manage JavaScript and query tabs within the IDE.
Enhanced IDE to update tabs based on route changes.

Enhancements

Improved tab management for JavaScript and queries in the IDE.

Bug Fixes

Ensured consistent IDE tab states during navigation.

/build-deploy-preview skip-test=true

@hetunandu How will this feature behave on page load? In the future, will the order of the tabs persist across multiple sessions of me opening the app?

@hetunandu I found an issue in this algorithm. So when a user is selected the last tab, and he want to goto any new tab which is not there in the tabs list. So now what will happen is the last tab will get pushed out of the list and the new one get added in the first place(like FIFO manner). But as a user, I want to see the recent tab I was in(I guess this is the understanding here). CHeckout the video attached here.
https://github.com/appsmithorg/appsmith/assets/87797149/0685a0e0-9eb9-4f8f-b793-1cd76f5eac0f

@hetunandu How will this feature behave on page load? In the future, will the order of the tabs persist across multiple sessions of me opening the app?

Eventually we will have this information stored on the server and pull it at the start so that it can last across sessions and clients.
Soon, I will make a change to make it persist locally
Right now it is not persisted so that testing becomes easy

@hetunandu I found an issue in this algorithm. So when a user is selected the last tab, and he want to goto any new tab which is not there in the tabs list. So now what will happen is the last tab will get pushed out of the list and the new one get added in the first place(like FIFO manner). But as a user, I want to see the recent tab I was in(I guess this is the understanding here). CHeckout the video attached here.
Screen.Recording.2024-01-19.at.12.25.17.PM.mov

This is the expected behaviour. The Recent order is not changed throughout the session. Only additions are accounted for as they will be added at the beginning of the list. More details are added in the solution doc: https://www.notion.so/appsmith/IDE-Solution-behaviour-8607a3b4df254970a77bd077290d3690?pvs=4#3d7f04820e174389b377037bc2c29906


change dialog edit of the torrc to vitor

https://github.com/nyxnor/vitor
It is like visudo/vidoas but for the torrc. It copies the torrc to a temporary file, lock it to not be edited on another instance. Than it lets you edit with your favorite editor. After saving and closing the editor, the file will be verified with tor --verify-config -f FILE. If okay, save it, if not, let you choose between e (edit again), x (exit without saving), Q (quit and save changes DANGER).
Main reason is preventing people from using an invalid configuration on the torrc because it can break tor as not starting again.
It can be installed from git or build the debian package from source. Has manual and video demonstration.

Vitor was added to TorBox https://github.com/radio24/TorBox/issues/134 on v.0.5.0

This is great and good work with the video!
How to install?

lol. completely forgot to put on the readme.
git clone https://github.com/nyxnor/vitor.git
cd vitor

install placing file on path:
./configure.sh -h
sudo ./configure.sh install
vitor -h

or build the deb package:
sudo apt install -y devscripts
## now inside the git folder:
sudo mk-build-deps --remove --install
sudo dpkg-buildpackage -b

Found it in the meantime, works well, but sure need that in the readme :)

readme with installation instructions
https://github.com/nyxnor/vitor#installation
and fixed debian build
Don't worry about error of gpg signing key because it is not needed for personal use, just for distribution. But as one is building from source, it does nothing.

I don't know how you guys are gonna go about this because it is literally one single script to be used so it could be included directly into raspiblitz.
But this delays updates that could be commited upstream faster and there is also the manual page to be integrated.

Repo changed name to https://github.com/nyxnor/onion-wash
Vitor is included + Onion-Parser to parse torrc elegantly in order.

@nyxnor you wanna target this for soonish v1.8 or push it up to v1.8.1?

trying to close the feature list for v1.8.0 ... pushing this to v1.8.1 (which should be a quick service release). But let me know if you have it very soon.


Improve the Write testimonial button

Feature request-
Improve the Write testimonial button.

Make sure to reuse css classes and pre-made colors wherever possible.

Note:

Do mention if your are working under GSSoC'21.
If you want to work on an issue, you should check if it has already been assigned to anyone. If the issue is free you can comment /assign to get the issue assigned to you.
If you are raising a new issue and want to work on it then also you should comment /assign under the issue to get it auto assigned.
Please refrain from adding labels to your issue/pull-request on your own. It is the job of the Project Admin and the Mentors to review your issue/pull-request and add labels accordingly.
According to the level of the issue, respective time will be allotted under which the task needs to be completed/resolved by the assigned person. If the issue is not resolved within the given time, it will be assigned to the next person. In case of any discrepancies, the decision of the maintainer will be final.

level - 0: 2 days
level - 1: 3 days
level - 2: 4 days
level - 3: 5 days

/assign

@Pranav016 should I reduce the font size it is looking very big in comparison

Something like this


show.ipynb link returns 404 error

The show.ipynb is linked at the bottom of the readme, but the link returns a 404 error.

Fixed, thanks for reporting!


SIDE-826 Window Sensor

https://crosschx.atlassian.net/browse/SIDE-826
Create LDK to allow users to get info about the windows on current system.  Currently provides options to get the active window, stream the active window. get all windows and stream all windows.

@scottkipferOlive, just a heads up that there are merge conflicts now (from a recent PR merge).


Updated dependencies on dnn-resource-manager

Fixes https://github.com/dnnsoftware/Dnn.Platform/issues/5290
The actual fix for the reported issue was done in https://github.com/DNNCommunity/dnn-elements/pull/579
This PR pulls in that new version and also updates the other dependencies on this project.

/azp run

/azp run

/azp run

Build error from second run:


fix(select): Fixed nested labelField and valueField error

Before submitting a pull request, please make sure you have at least performed the following:

[x] read and followed the CONTRIBUTING.md guide.
[x] linted, built and tested the changes locally.
[x] added/updated any applicable API documentation. (nothing to do)
[x] added/updated any applicable demos. (nothing to do)

Solves #381

Thank you for the PR 🎉
Will get this looked at and hopefully merged next week.

Thank you for the PR 🎉
Will get this looked at and hopefully merged next week.

Thank you again for this fix. Will be cutting a new next version soon, and it will be live properly in the next release.

No problem. Thank you for your work on this repo :)


[Feature] constructor injection

instead of this
 @CommandLine.Parameters(
    index = "1..*",
    description = "path to configuration directories separated by space"
  )
  @SuppressWarnings({ "NullAway.Init" })
  private List<String> args;

write this
private final List<String> args;

MyFoo(
 @CommandLine.Parameters(
    index = "1..*",
    description = "path to configuration directories separated by space"
  )
List<String> args
)
{
   this.args = args;
}

this makes the code easier to test and safer to use. It also follows the Dependency Inversion principle.

Have you had a chance to read previous discussions on this topic in https://github.com/remkop/picocli/pull/1107 and https://github.com/remkop/picocli/issues/1195 ?

... but long story short: my conclusion after all that analysis is that this will be a lot of work to get it right, with relatively little benefit.
To be honest, I don't see myself working on this in the near future.
That said, if someone is willing to provide a high-quality PR (docs, tests, preserves backwards compatibility, etc), I will consider it. (No guarantees: I would still need to see how much additional complexity this would introduce in practice...)

hmm... I just went about starting to try my hand at writing some tests against my application class, and I realized that it's hard because of the lack of this, and that there doesn't immediately seem to be a way to tell picocli to inject args like it would if I called new CommandLine(new Application()).execute(args); without actually executing it.

Hey @xenoterracide!
There is the CommandLine.parseArgs method that populates the annotated fields from the command line arguments without invoking the Runnable/Callable.
Is that what you are looking for?

I renamed  #1195 to make it easier to find.
Closing this ticket since the feature request is already tracked in  #1195.


Move forward and drop python < 3.5. Version 2.0

No six magic anymore.
All typehints is embedded.
Less requirements, simple code.

Pull Request Test Coverage Report for Build 178

176 of 179 (98.32%)  changed or added relevant lines in 9 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.4%) to 99.475%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

exec_helpers/exceptions.py
8
9
88.89%

exec_helpers/subprocess_runner.py
18
20
90.0%

Files with Coverage Reduction
New Missed Lines
%

exec_helpers/proc_enums.py
1
98.04%

Totals

Change from base Build 175:
-0.4%

Covered Lines:
948

Relevant Lines:
953

💛  - Coveralls


String.fromEnvironment() not working inside async its outputting null

void main() async {
  const constEnv = String.fromEnvironment("APP_ENV");
  print('constEnv=$constEnv');

  var varEnv = String.fromEnvironment("APP_ENV");
  print('varEnv=$varEnv');

  String stringEnv = String.fromEnvironment("APP_ENV");
  print('stringEnv=$stringEnv');

The output is:
I/flutter (16722): constEnv=staging
I/flutter (16722): varEnv=
I/flutter (16722): stringEnv=
I would expect all three lines to output 'staging'
Flutter doctor -v
[✓] Flutter (Channel stable, v1.17.5, on Mac OS X 10.15.5 19F101, locale en)
• Flutter version 1.17.5 at /Users/csaride/Downloads/flutter
• Framework revision 8af6b2f038 (2 weeks ago), 2020-06-30 12:53:55 -0700
• Engine revision ee76268252
• Dart version 2.8.4

Duplicate of https://github.com/dart-lang/sdk/issues/42177


Feat: Add animated cycle plotter

A spinoff of the cycle plotter that makes it animated with the option of saving it as a gif.

This might need re-investigating, but probably as part of the core rather than here.


Avoid string allocations in some Concat overloads

Previously, if you called something like string.Concat("", null, "123") it would try to allocate a new string and return the result. This is wasteful, since if all of the other parameters are null/empty then you can just return the remaining parameter.
This PR avoids such allocations by delegating down to other overloads of Concat which perform such checks, which lets us reap perf benefits without resorting to spaghetti code. It also avoids checking for the (very unlikely) case of all 3/4 parameters being null.

Hi @jamesqo, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;


Maths anchor

Don't we want to avoid branching in such low level functions ? At some point we will want to pack data and operations and having a branch in the hot loop doesn't seem good.

Don't we want to avoid branching in such low level functions ? At some point we will want to pack data and operations and having a branch in the hot loop doesn't seem good.

We could make multiple versions of these functions, but note that the condition is already executed in the hot path currently (with use_anchor), so it feels like it could be done later.


Allow modifying history without redirecting to the new url

Default behaviour is unchanged. All tests still pass.

You may have noticed that 2.0 is out with a new kind of router so I'm closing this since it's no longer relevant.
https://muut.com/riotjs/
Hope you like the new version!


Displaying a friendlier error for unknown fields found in configuration files

Intent
In order to have more standardized errors handling, this PR introduces error types - to be expanded as we add more "known" errors.
Screenshot

Fixes #2157
Type of Change
Improvement
Approach
On the vscode extension UI code, changes made to getSummaryStringFromError allow to get a human consumable error message when the error contains a known JSON agent response - otherwise, a tracing-style message is returned to help diagnose.
Automated Tests

Updated backend tests as needed.
Added new UI tests for the new code. (Run locally and will add something to test on CI too)

Directions for Reviewers

Edit the active configuration and add an invalid entry (such as abc = 123).
Save the file.
Notice the error displayed in the notification.

Checklist

[ ] I have updated CHANGELOG.md to cover notable changes.

@sagerb @mmarchetti Thanks for the feedback 🙇  I'll move some things around and re-request review when it is ready for a second look

@sagerb @mmarchetti This PR is ready for another look 🙂

@dotNomad pushed a couple commits related to your questions. Things seem to be better now:

test files evaluated by TS compiler
Adjusted JsonResult to receive status and be used thoroughly


tar corrupts archive contents on macOS

Description
The bsdtar binary installed in the virtual environment produces tarballs with corrupted file contents.
This was first observed months ago:
https://github.com/actions/upload-artifact/issues/151
https://github.community/t/bizarre-issue-with-tar-archive-for-macos-build/145377
The silent corruption resulted in our GitHub workflows producing unusable release assets for months before anyone noticed, and cost some in our team half a day of rubbing our eyes, running our build system locally to check for broken output, and questioning our sanity. #1534 provides a band-aid by installing GNU tar into a location that is not listed in PATH, but it assumes that the workflow users are either aware about this bug or have other reasons not to use bsdtar.
Area for Triage:
Apple
Question, Bug, or Feature?:
Bug
Virtual environments affected

[ ] Ubuntu 16.04
[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[x] macOS 10.15
[ ] macOS 11.0
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

Image version
20210130.1
Expected behavior
The tarballs produced by tar contain files with their original content intact.
Actual behavior
The tarball created to pack some binaries is unpacked to corrupted files that cannot be executed.
Repro steps
This workflow:
https://github.com/mzabaluev/jormungandr/blob/2d9ad4c97a7051d2a19bec5bfc42c36243d37f23/.github/workflows/release.yml#L273
The resulting macOS asset with corrupted binaries: https://github.com/mzabaluev/jormungandr/releases/download/nightly.20210204/jormungandr-0.10.0-nightly.20210204-x86_64-apple-darwin-generic.tar.gz

This incident, and the duration for which it has remained unfixed since it has been reported and discussed in the community forums, disturbs me enough that I would like the resolution to include a post-analysis on how the problem has occurred.

@mzabaluev, bsdtar is pre-installed on clean macOS system by Apple and it is not something that we install during image-generation from our side. So I guess it is better to report this issue on Apple forum.
Also images contain GNU tar so you can use it instead of bsdtar.

@maxim-lobanov I admit it was a bit presumptive of me to think that Apple would not let that kind of breakage go unnoticed due to having actually good QA... But I appear to be right: tar on my laptop macOS 11.2, with the same version as reported by the virtual environment, does not corrupt the locally built binaries on archival.
I don't have a macOS 10.15 installation at hand to verify there, but I assume that if this issue was present on Macs in general, we would have heard of this.

Hello @mzabaluev,
Could you please provide minimal steps to reproduce the issue to speed up the investigation?
We are looking forward to your reply.

Hello,
I reported this issue to Github support back in December. Links to my reports are in the top post.
@maxim-lobanov I can confirm that tar on my multiple physical Mac machines works as expected. It is only on the Github runners that this problem manifests.
@Darleev The minimal steps appear to be running an Action that uses the tar command on a Mac runner. I assume it is possible for someone at Github to ssh into a runner and run interactive commands? I think it would be instructive to see what the output of running tar on some files like this would be.

It does not seem to be straightforward to repro: a test run with archiving a smaller hello world binary had it come out as Mach-O (MacOS won't let me run it after unpacking it from the downloaded artifact, so it's possible that it is still corrupted). With the larger build linked in the description, the files are described only as "data" by file, and the redundancy of their content is a lot more than what uncorrupted binaries should have judging by the archive size being about 1/3 of normal.

Will try with some larger binary from the system and checksums, some time later tonight.

Tried archiving clang and ld copied from /Library/Developer/CommandLineTools/usr/bin, no corruption seen with these files.

Hello, @mzabaluev
I've tried to reproduce your archive and have checked hashes of original and extracted files - all works without any errors:
https://github.com/andy-mishechkin/Azure-PipeLine-Test/runs/1862611131?check_suite_focus=true
Workflow yaml is here:
https://github.com/andy-mishechkin/Azure-PipeLine-Test/blob/master/.github/workflows/test.yml
May you provide some other repro steps where you've got corrupt archive. And did you get this corruption regularly or sometimes ?
Thank you

https://github.com/actions/cache/issues/403#issuecomment-677967547

What makes it really weird...if I add sleep 10 after cargo test and before creating the tar, it works fine.

It seems to occur with binary outputs of two compiler/linker toolchains based on LLVM: clang and rustc.
It does not occur with every output, either: a small hello-world binary is not corrupted.

My only plausible guess is that the virtual filesystem used by the macOS runner has a bug that is triggered by specific file access patterns of the linker and bsdtar.

May you provide some other repro steps where you've got corrupt archive. And did you get this corruption regularly or sometimes ?

The workflow linked in the description has produced corrupt binaries regularly since at least the end of October. It seems to not corrupt with 100% regularity though: this release had two tarballs with macOS binaries built with different CPU optimization settings; only one of the archives got its contents corrupted.

Thanks @mzabaluev for digging this deep!

@mzabaluev , could you please add sleep 10 after cargo / rust invocation before using tar to check if it helps as @Cyberbeni  mentioned above?
It looks like that process that creates / builds files, blocks them for some additional time after execution. And tar tries to archive files that were not written fully yet. It explains why we can't reproduce it with tar directly and why sleep 10 helps to resolve the issue.
We don't tweak filesystem somehow from our side during image-generation so there shouldn't be any difference with local system.
Does it reproduce for you only with Rust? We still can't reproduce the issue on small project.

(I also had this issue using the @actions/cache npm package in my GitHub Action after building with the Swift compiler which is also LLVM based, fixed with v1.0.6 since that uses gnu-tar on macOS)

@mzabaluev , could you please add sleep 10 after cargo / rust invocation before using tar to check if it helps as @Cyberbeni mentioned above?

It seems to eliminate the corruption, indeed. In a run with the same steps except sleep 10, tar archives file contents that are different from what shasum had read just prior.

It looks like that process that creates / builds files, blocks them for some additional time after execution. And tar tries to archive files that were not written fully yet.

I doubt it: the compiler process that has built the jormungandr binary exits some 7 minutes before tar is invoked, yet both binaries end up corrupted in the archive. cargo runs the compiler as a regular child process, it's not left running in the background when the command exits. It's not that the files are incomplete, either: the file utility does not recognize the Mach-O magic in the heads of the extracted files, meaning that their content is completely different. The size of both files also corresponds to what they would likely be originally, but gzip is able to compress the contents to about 1/3 of the expected size of the archive, meaning that the entropy of the corrupted content is much larger.
Perhaps the idle 10 seconds let some settlement happen in an OS or virtualization storage layer that is otherwise prevented by busy processes?

We don't tweak filesystem somehow from our side during image-generation so there shouldn't be any difference with local system.

You do run it under VMWare on a virtual disk volume, though.

Does it reproduce for you only with Rust? We still can't reproduce the issue on small project.

I was unable to reproduce it with a smaller Rust project, or by archiving copies of some large binaries installed in the system.

I would use DTrace to see how the linker and tar access the files, but it does not seem to be possible with the cloud-hosted runners.

@mzabaluev it seems the problem is the build has not completed at the moment you are calculating the checksum and starting to tar the binaries.
I've just confirmed the 10.15 osx tar works as expected on the any artificial binary files generated with dd if=/dev/random and i  suspect there's something wrong with the binaries produced by the build.
While i'm still investigating the cargo step can you please try to enforce the disabling any parallel build settings if there are any?

Calling sudo /usr/sbin/purge before building the tarball on a macOS is a known workaround.
See https://github.com/marketplace/actions/rust-cache#cache-details
and https://github.com/rust-lang/cargo/issues/8603
and https://github.com/actions/cache/issues/403

it seems the problem is the build has not completed at the moment you are calculating the checksum and starting to tar the binaries.

It does not seem so from anything I can observe: the cargo process has exited after waiting on any tool processes it has launched to build the executables before tar gets to run. I'd like to run a tracing tool to capture the timeline of the processes, but lack the knowledge to do it on macOS.
There is a report of this (or similar?) problem being reproducible on a MacBook Pro: https://github.com/Homebrew/brew/issues/6539#issuecomment-542799372
https://github.com/rust-lang/cargo/issues/8603#issuecomment-684085412 suspects an interaction of tar with sparse files on APFS can be at fault. I can't confirm if the LLVM toolchain really uses that feature.

@mzabaluev as the first step can you please to check if the problem can be solved with -S tar option during the unpacking process tar -xzSf ...?
For the further investigation we need to reproduce the problem on the SIP disabled machine - do you think it is possible to reduce the faulty build to the less size? Unfortunately we can not use the artefacts because they copying the binaries to the artefacts may skip their sparse-ness.

@mzabaluev as the first step can you please to check if the problem can be solved with -S tar option during the unpacking process tar -xzSf ...?

This did not solve it: https://github.com/mzabaluev/jormungandr/runs/2112154653

For the further investigation we need to reproduce the problem on the SIP disabled machine - do you think it is possible to reduce the faulty build to the less size?

I'm not sure, the result seems sensitive to how sizable the binaries are. This run produced a small test binary that was archived without corruption.

@mzabaluev ok, and as the last step to confirm the problem is not related to the sparse files can you please issue ls -ls  agains every binaries to be included into the archive. This command will show actual blocks used to store the file content. This way we know either the files created by the build are sparse or not.

@mzabaluev ok, and as the last step to confirm the problem is not related to the sparse files can you please issue ls -ls  agains every binaries to be included into the archive. This command will show actual blocks used to store the file content. This way we know either the files created by the build are sparse or not.

Here you are, though I can't make much of this information.
I have also reduced the build to a single binary that is the smaller of the two.

according to
diskutil info -all | grep "Block Size" the macos latest images has mounted filesystems of 512 or 4096 bytes blocks
From the other side ls -s output
328 -rwxr-xr-x  2 runner  staff  8554552 Mar 16 14:56 jcli
shows the total file size of 8554552 is much more than 328 x 4096 = 1 343 488. This is the evidence jcli is a sparse file and  osx tar skips "holes" inside it and thus CRS sum of untarred file is different from the the input.
@mzabaluev in order to confirm we have sparse file issue can you please confirm the untarred binaries still work as expected despite the CRS check fails?

@maxim-lobanov most likely we have sparse files to be archived and  osx tar and GNU tar handle them different. Gnu tar by default does not make attempt to detect "holes" and include them to archive (https://www.gnu.org/software/tar/manual/html_node/sparse.html) and  osx tar might skip them while tarring and does not create on restoring.
As a result i see nothing we can do with the problem.

osx tar might skip them while tarring and does not create on restoring.

This still does not explain why does it work after a 10 second sleep. Does the OS patch the holes in the sparse files in the meantime? I suspect the problem may be in the kernel.

@mzabaluev in order to confirm we have sparse file issue can you please confirm the untarred binaries still work as expected despite the CRS check fails?

https://github.com/mzabaluev/jormungandr/runs/2132586952?check_suite_focus=true#step:9:29
The original sparse file binary can be run by the OS. The untarred file is not recognized as an executable format.
I have also added a sleep 10 step and run ls -ls on the original binary again, the block count does not change.

https://github.com/actions/virtual-environments/issues/2619#issuecomment-788397841
Does calling sudo /usr/sbin/purge before building the tarball workaround this issue?

@mzabaluev can you please add another line of shell code to your build ls /usr/local/opt/runner/settings/instancename?
It will print a string we can use to identify the environment the build is executed in.

@mzabaluev as an addition to @dsame comment — we suspect some storage issues in particular environments but need to gather enough data to prove it

#2619 (comment)
Does calling sudo /usr/sbin/purge before building the tarball workaround this issue?

It does: https://github.com/mzabaluev/jormungandr/runs/2153654779

@mzabaluev can you please add another line of shell code to your build ls /usr/local/opt/runner/settings/instancename?
It will print a string we can use to identify the environment the build is executed in.

Voilà

we suspect some storage issues in particular environments but need to gather enough data to prove it

Good if this information helps, but the issue has been 100% reproducible with a particular source tree.

@mzabaluev not 100% actually. I've forked your repo and made a few runs to prove our assumptions. 2 out of 4 passed and we observe the correlation with particular environments.

Moreover looks like we understood why it happens, but not sure we can fix it from the image side since it's related to the underlying infrastructure.
We're going to escalate the issue to the engineering team, but unfortunately, I'm not sure how much time it will take them to fix it.

FWIW I had the same problem, using the system tar -czvf command without installing gnu-tar
system tar seems to work fine when I do the same locally on my macbook
and sudo /usr/sbin/purge work-around in the Action seems to have fixed it
before:
https://github.com/anentropic/chuckd/runs/2470461074#step:10:7
after:
https://github.com/anentropic/chuckd/runs/2470588309#step:11:7

The problem happens on archiving sparse files (common case is the binary created by llvm tools), apple tar removes the "holes" during the compressing and can not restore the executable in its original size.
There's no known workaround except either use GNU tar or try apply "-S" option with "-x" mode of apple tar.


FancyZones: Windows does not adjust to other presets

Microsoft PowerToys version
0.67.0
Installation method
Microsoft Store
Running as admin
Yes
Area(s) with issue?
FancyZones
Steps to reproduce

Set PowerToys to run at startup (issue occurs in both admin mode and user mode).

Turn on FancyZones hold shift to activate zones while dragging option.

Turn on when zone layout changes windows assigned to a zone will match new size option.

Create 2 custom FancyZones layouts.

Assign a quick switch number to each of the custom layouts.

Restart the machine.

Once booted do not interact with the PowerToys UI in any way.

Open a window and assign it to a zone with Shift+Drag.

Switch zone layouts using quick switch shortcut e.g. CTRL+WIN+ALT+number.

✔ Expected Behavior
The window should resize to match the new layout when the zone layout is changed after a restart via quick layout shortcut keys
❌ Actual Behavior
Windows are stuck in the old layouts position
Other Software
None
PowerToysReport_2023-02-03-16-42-46.zip

Also seeing this on 0.67.0.  Rolling back to v0.66.0 fixes the issue.

This issue has been fixed in the 0.67.1 release. Please update PowerToys to get it. Thank you!


refactor code structure

These are the changes:

Move Cursor and Slice definitions to cursor.rs.
Move Storage & StorageInner to a separate module storage.rs.
Move impl blocks for Iter, IterMut and Pointer after their definitions.

I started refactoring the code for better legibility while I was studying the crate, and I thought maybe you like it better this way too.
I used rustfmt and clippy, and it works well with 0 warnings.
BTW thank you for creating this, that elegantly adds the missing piece of graph-like connectivity to the classic ECS...

Awesome work, thank you!
Would be great to add Clippy to our CI, too :)


Conditionally defined properties on functions should be considered optional

function readFile() {
}

if (Math.random()) {
  readFile.sync = () => {}
}

readFile.sync();

Expected: readFile.sync has the type (() => void) | undefined and it is an error to call it.
Actual: readFile.sync has the type () => void and there is no error present.

Note that if the property is definitely assigned there should be no error:
function readFile() { }
if (Math.random()) {
  readFile.sync = () => {}
}
else {
  readFile.sync = 'was'
}
readFile.sync.length

So the full fix needs control flow from the container object.

So the full fix needs control flow from the container object.

Less the containing object and more from the start of where the reference becomes available 😛
if (Math.random()) {
  readFile.sync = () => {}
}
else {
  readFile.sync = 'was'
}
readFile.sync.length
function readFile() { } // function declarations are hoisted, so this is fine


[Template] Create a Service blueprint template

Current Behavior
Currently for new users we do not have enough starter templates that they can use as introductory material.
Desired Behavior
We want to create a Service blueprint template to allow new users to understand how they can create a Service blueprint diagram with Kanvas. So we'd want contributors to not just create a design template but also add tips or notes they think a new user would need if they are starting out with little to no context of the capabilities Kanvas offers.
Implementation
Make sure you use Kanvas to create this template and keep the template private.

[ ] Provide a brief overview of what this template does and can help with, maybe highlight a usecase
[ ] Add a template that can be directly copied and used instantaneously
[ ] Add a step by step process to create this template
[ ]  Once the design is completed, publish it and share the private link with our team, or tag us in the comment component to receive feedback.

Acceptance Tests

Template has been submitted for publishing to the catalog and accepted; is published and available in the Meshery Catalog.
We are in need of well annotated and described templates like this one.

Mockups
This FigJam template can be used for recreating the Service blueprint Template
Perks
By contributing to this task, your efforts will have a lasting impact! Once published, your design will be cloned and used by countless users as a go-to starting point for creating Service blueprint in Kanvas. You'll not only help newcomers understand the platform but also see your work adopted widely by the community. Plus, as a token of appreciation, you'll receive a special shoutout, recognising your valuable contribution. Your effort won’t go unnoticed—you're directly helping shape the experience for future users!

Contributor Guides and Handbook

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

@SAHU-01 , ma'am can you assign this issue to me

Sure @NishantSinghhhhh , do let me know if you have any queries.
Once you feel the design template is ready for review, do add a comment in the design by pressing a Ctrl/Cmd + M and tagging @Ankita Sahu in the comments. I can review it and we can go ahead with publishing your design!


Does it support Angular 2.1.0?

Does it support Angular 2.1.0?

It works fine for me using angular 2.3.1

Hi @enghelewa  can you share code how you do it?

@Haseeb717  this should work for you
My Module
...

import {Ng2BreadcrumbModule, BreadcrumbService} from 'ng2-breadcrumb/ng2-breadcrumb';
import {AppComponent}  from './app.component';

...

@NgModule({
    imports: [
        ... ,
        RouterModule.forRoot(APP_ROUTES), //constant holds my routes
        Ng2BreadcrumbModule.forRoot(),
    ],
    declarations: [
        AppComponent,
        ...
    ],
    providers: [
        ...
        BreadcrumbService,
        ...
    ],
    bootstrap: [AppComponent]
})
export class AppModule {
}

My App Component
...

import {BreadcrumbService} from 'ng2-breadcrumb/ng2-breadcrumb';

...

@Component({
    selector: 'body',
    templateUrl: '../templates/app.component.html'
})
export class AppComponent implements OnInit,OnDestroy {

    constructor(private breadcrumbService: BreadcrumbService) {
    }

    ngOnInit() {
        this.breadcrumbService.addFriendlyNameForRoute('/home', '');
        this.breadcrumbService.addFriendlyNameForRoute('/campaigns', 'Campaigns');
        this.breadcrumbService.addFriendlyNameForRoute('/projects', 'Projects');
        this.breadcrumbService.addFriendlyNameForRoute('/services', 'Services');
        this.breadcrumbService.addFriendlyNameForRoute('/gallery', 'Gallery');
        this.breadcrumbService.addFriendlyNameForRoute('/about', 'About us');
        this.breadcrumbService.addFriendlyNameForRoute('/contact', 'Contact us');

    }
}

App Component Template

    <app-header></app-header>

            <breadcrumb></breadcrumb>

        <router-outlet></router-outlet>

    <app-footer></app-footer>

in module where you get BreadcrumbService??

You should import the service alongside with module
import {Ng2BreadcrumbModule, BreadcrumbService} from 'ng2-breadcrumb/ng2-breadcrumb';
you could also remove it from the app module and just put it in your app component providers and the rest of the code remains as it

It gives an error
EXCEPTION: this.hideRoutes.includes is not a function

after follow same code

Unhandled Promise rejection: this.hideRoutes.includes is not a function ; Zone:  ; Task: Promise.then ; Value: TypeError: this.hideRoutes.includes is not a function(…) TypeError: this.hideRoutes.includes is not a function

Where did you use this be careful it could point to another thing if you use it inside a function callback

Let me show you my code

app.component.ts
import { Component, OnInit } from '@angular/core';
import {BreadcrumbService} from 'ng2-breadcrumb/ng2-breadcrumb';

@Component({
  selector: 'app-root',
  templateUrl: './app.component.html'
})

export class AppComponent implements OnInit {
	constructor(private breadcrumbService: BreadcrumbService) {
	}

	ngOnInit() {
    this.breadcrumbService.addFriendlyNameForRoute('/dashboard', 'Home');
    this.breadcrumbService.addFriendlyNameForRoute('/alerts', 'Alerts');
  }
  title = 'e-risk';
}

aap.module.ts
...

import {Ng2BreadcrumbModule, BreadcrumbService} from 'ng2-breadcrumb/ng2-breadcrumb';
import {AppComponent}  from './app.component';

...

@NgModule({
    imports: [
        ... ,
        RouterModule.forRoot(APP_ROUTES), //constant holds my routes
        Ng2BreadcrumbModule.forRoot(),
    ],
    declarations: [
        AppComponent,
        ...
    ],
    providers: [
        ...
        BreadcrumbService,
        ...
    ],
    bootstrap: [AppComponent]
})
export class AppModule {
}

The code you provided looks fine!
Please search your code for this.hideRoutes.includes I think like you miss used the this keyword and probably it points to another thing rather than the component class

This may be different, but may also be related. This is what I'm seeing, but only on Safari 8.0.6 (i.e. webkit) and not on Chrome / Firefox. I'll open a separate ticket if needed.
undefined is not a function (evaluating 'this.hideRoutes.includes(route)')
Note: I am using v0.5.6, with webpack, angular 2.4.5, angular router 3.2.4.

Btw, I rebuilt after replacing hideRoutes.includes() calls with hideRoutes.indexOf() tests, things were happier. Then I poked some more on latest Safari versions for OSX Yosemite, which I'm still on (as are many). Looks like I'm quite a bit out of date on Safari updates (10.x is latest), so the issues is my Safari version isn't ES5 compatible and hence there is no includes() methods on the Array prototype. Oops.
Worth taking a look at if others experience similar undefined issues. I only ran into this during testing of multiple browsers. I see no mention of browser versions in this thread, which might be helpful for diagnosing.

@arimus  on chrome and mozilla also you get this error or not?
undefined is not a function (evaluating 'this.hideRoutes.includes(route)')

No, not on my versions. It was only on and older version of Safari that I
personally got the error, but this may still be a problem for folks trying
to reach a broad audience with browsers that are potentially older. And
there are older mobile browsers to think about as well.
It's worth noting that only this library gave me issues out of dozens of
libraries including the latest angular 2.x versions. Given how small the
change is, it may be worth making...even if I it makes those couple of
lines a tad less modern :)
On Feb 12, 2017 2:56 AM, "Haseeb Ahmad"<EMAIL_ADDRESS>wrote:
@arimus https://github.com/arimus on chrome and mozilla also you get this
error or not?
undefined is not a function (evaluating 'this.hideRoutes.includes(route)')
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gmostert/ng2-breadcrumb/issues/44#issuecomment-279210530,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAN8KuIOQSl7njxJtVor3te6FSFYPSmyks5rbuV2gaJpZM4L5c5O
.

Btw, it also looks like this is an issue in IE 11 (11.0.9600.18792, update: 11.0.46). I get the following:

Object doesn't support property or method 'includes'.

Btw, any word on an update to solve this for browsers that don't support 'includes' on the Array prototype? I'll have to resort to a polyfill otherwise. This library could always just add in a polyfill if includes is not detected, ala...
https://stackoverflow.com/questions/31221341/ie-does-not-support-includes-method
Granted, we don't want to stomp on other potentially loaded polyfills if we can avoid it, so using indexOf() or a filter would be ideal.


test: remove create_deploy_test_state part 1

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.78%. Comparing base (a42e365) to head (c3e3861).

Additional details and impacted files
@@                                               Coverage Diff                                               @@
##           arni/maintainance/remove_create_state/deprecated_create_deploy_test_state/pt_1    #1593   +/-   ##
===============================================================================================================
  Coverage                                                                           69.78%   69.78%
===============================================================================================================
  Files                                                                                60       60
  Lines                                                                                8220     8220
  Branches                                                                             8220     8220
===============================================================================================================
  Hits                                                                                5736     5736
  Misses                                                                               2018     2018
  Partials                                                                              466      466

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add goodix-gpdwin3 dkms driver

Add fixed goodix-gpdwin3-dkms driver with modified blacklist config. Can be enabled with device-quirks. Must install goodixgpdwin3.conf in /etc so device-quirks can edit it without frzr-unlock. This file will blacklist this driver so that it doesn't conflict with goodix_ts. Device-quirks will need to change this blacklist to goodix_tx. This will enable touch support for win3 devices.

Not sure I like having a whole driver in here. Can we not make this a separate package in the AUR?

Not sure I like having a whole driver in here. Can we not make this a separate package in the AUR? Or at least obtain the driver source code from somewhere else?

There is a package in the AUR already, buy it won't work for our purposes. I suppose I could make this a git repo and the PKGBUILD here could build from there. Thoughts?

Not sure I like having a whole driver in here. Can we not make this a separate package in the AUR? Or at least obtain the driver source code from somewhere else?

Updated. PKGBUILD now uses https://github.com/pastaq/goodix-gpdwin3-dkms as source and is tagged to the current HEAD.

There are still the sources in this PR. Also seems to be a typo in the directory name?

There are still the sources in this PR. Also seems to be a typo in the directory name?

Woops, forgot to push lol.

There are still the sources in this PR. Also seems to be a typo in the directory name?

Fixed


Console: Orders no longer open "stuck" in orderbook (spot market)

Description
There seems to be orders that are stuck in orderbook, the market is not in auction and you can see that the bids are higher than the offers.
Steps to Reproduce
Not sure, it is available on fairground market, changing datanode, refreshing page and/or market does not seem to help.
https://vegafairground.eth.limo/#/markets/051987b65c660de2451e94528b050442508cd3559003ab39db0dbfa9398dc455
Expected behaviour
https://github.com/vegaprotocol/frontend-monorepo/assets/100769129/9bcc321c-2eb6-4f0e-a6ef-6713f91193f3

the issue still exists.
but it seems like console is displaying correctly the response data that we get from the market (depth) queries and subscriptions.
maybe @bglownia can take an extra look to confirm before we transform this into a core ticket.
cc @JonRay15


Joining a crew and doing /me messages are also commands?

What

Unfortunately the /me command output can't be reliably caught, though I will fix the other thing

Ah ok


Re-publishing kata gives You do not have permissions to view this page

I was trying to edit this kata to update the Haskell version, but even a blank re-submit gives me the You do not have permissions to view this page page after an auto-refresh, and the changes are not saved.

Can you check the value of code_challenge.rank in the payload when republishing?
This might be related to a bug that removed a rank from a kata when I republished. The permission issue doesn't prevent the change when I do it because I'm the admin. It happened at least twice in the past.

The rank is already empty even in the kata editor, so I wouldn't expect the payload to have the correct value for it.

Thanks, that's the cause of this permission error.
This should be some data issue (maybe also related to the cause of #2111).

I think this is one of the kata you had set the rank outside of the range allowed by the editor through the API. The kata editor doesn't have the rank set because it's an invalid value.

 That's easy to fix then, I'll just add a 4kyu option in the front end and submit it with that selected.


Add japanese chapter7 md1 and mx2

Hi @lewtun
I add
ja/chapter7/1.mdx
ja/chapter7/2.mdx
please review.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Hi @webbigdata-jp !
Thank you very much for your great work!
As suggested here please follow the instructions and make sure that you have run make style before pushing :)

Hi @younesbelkada
I think it may be because the version of python is different.
I haven't solved it yet, but I'll try it in 3.6 tomorrow.

hi @lewtun .
This is second try. I add Japanese chapter7/md1, 2.
I recreated the environment.
I also have done git add before make style.


Add cal:: prefix to local_date

Without prefix it doesn't work.

I signed CLA. Is there any problem with my side?

I'm not sure what's up with the CLA bot, maybe you'll need to agree again on next pr. Anyways, doesn't matter for a small docs fix. Thank you! Merged.

@kafein It seems like the commit was made using an email address that is not associated with your github profile, and this confused the CLA bot.

@elprans you are right. just get new computer and forgot to update my gitconfig :)


More authentication methods

Also it would be better if email link auth included a temporary code the user can enter in, in case you open the email on a different device from the one you're trying to log in with. That can also help users get around those (stupid, despicable) embedded web browsers that mobile apps are so fond of using.

New version of Biff is a lot simpler, and I think just doing email link authentication in the starter project makes sense. The authentication code is very easy to change (it's all contained in the template code). If anyone wants passwords/sso they can implement it themselves and blog about it, then we could link to the blog post from the biff docs.

Also it would be better if email link auth included a temporary code the user can enter in, in case you open the email on a different device from the one you're trying to log in with. That can also help users get around those (stupid, despicable) embedded web browsers that mobile apps are so fond of using.

this would still be nice. Notion's implementation makes a good reference. But for now I'll leave this closed until someone brings it up.


Bobcat rate limit

What happened
When using this exporter it seems to rather regularly fail to fetch temperature data because it receives a 429 response. I can reproduce this issue at polling intervals all the way up to 1m so I am pretty sure it is not the scraping frequency that is the culprit.
time="2022-07-08T00:08:26Z" level=error msg="Can't scrape /temp.json: HTTP status 429" source="main.go:205"
time="2022-07-08T00:09:26Z" level=error msg="Can't scrape /temp.json: HTTP status 429" source="main.go:205"
time="2022-07-08T00:10:26Z" level=error msg="Can't scrape /temp.json: HTTP status 429" source="main.go:205"
time="2022-07-08T00:11:26Z" level=error msg="Can't scrape /temp.json: HTTP status 429" source="main.go:205"

Debugging
I did some debugging and I think the issue is the tight loop that this exporter uses. I think, and this is sorta ironic, that the code executes the call to /temp.json  too soon after calling /status.json.
In some cases, 429 errors come with a Retry-After header that could be used to space out the requests but I don't see that in the response from the miner.

I went looking for documentation from bobcat but I can't seem to find any details on the miner HTTP server or how it is configured...
By testing, I found the limit, at least on my miner, could be as low as 1 request per 1.5s!

Possible solution
I think there are a couple of things that could be done:

The fetch routine could be improved to have a retry with a back-off
There could be a configurable constant sleep time for requests (seems questionable to me)
The fetching could be done in the background instead of on-demand. I think this is "best" but does not really fit with what you had going here. It also adds a lot of complexity.

I mention the above because I am happy to do any of them but since this is not my project, and I don't wanna fork it, I wanted to see what you the author thought.
Let me know and if I have some time I may send a PR your way.
Take care!

Also just learned that as of the time of writing the status.json endpoint is being removed. As of:
Bobcat Firmware version updated to <IP_ADDRESS>
Helium Firmware version updated to 2<IP_ADDRESS>_GA
Bobcat miners will be lite so they will not have a sync status. Syncing will be done by validators I guess... So the above might be a non-issue. The only metric you can really track without impacting the bobcat would be the temperature.


pkg_config files are in share, not lib

for the reasoning behind this, please see https://github.com/mirage/mirage-solo5/pull/15

Actually both are used. share should be for ach-independent things, but judging from what I've got installed on my system, it's a toss-up between the two.
So we'll do both.

thanks!


Look into Samotop and it's efforts / smtp grammars etc

https://gitlab.com/BrightOpen/BackYard/Samotop/

SMTP Relay Server (MTA) library and a sample simple server implemented in Rust with focus on spam elimination and privacy. The motivation is to revive e-mail infrastructure and architecture, address current problems and allow new systems to integrate SMTP. It's called SaMoToP, which could be a nice Czech word.

Anything you need to know?

Hey, thanks for appearing and asking :)
There is no immediate question but maybe it's interesting for you to hear that @dignifiedquire and me have had several discussions towards a new SMTP/IMAP async-rust server that is able vast amounts of active connections, and for a MVP implements enough so that it can work well with https://delta.chat whose core is implemented fully in Rust (used by all apps on all platforms) and in turn using async-email repos itself ...  maybe we could do an a/v about this sometime?

Ehlo, yes, I'm very interested. What is vast in your terms? Why not postfix or another big boy? I supect latency is a big deal for delta.chat. We can meet.jit.si ;)

message you from holger at deltachat de -- as to "vast" it's a not quantified ... we were trying to find out the kernel-limits, but 100K active smtp/dovecot connections seems to be doable, with in-ram delivery so that when in many cases, when smtp-send-mail says "250 ok" the message is already imap-delivered to the recipient(s) and has never been written to disc.  Another goal is to get a cargo-installed server, easy to configure and deploy a best-practise smtp server. Postfix/Dovecot are a fine combination today but that doesn't need to stop playing with some potential game-changing innovations :)

If you are interested, @jocutajar, let us still talk some time again, you can contact me at holger at deltachat de anytime ;)


Error in Build regarding router-loader

After following the instructions for routing from the documentation, and running the build script it errors out with the below:
ERROR in ./pages/container.js
Module build failed: TypeError: Cannot read property 'length' of null
    at Object.module.exports (.../loaders/route-loader.js:8:7)

Note:
For the route itself I am wrapping the component in a container using connect() from react-redux but shouldn't kill the routing?
./src/routes.js

./src/pages/index.js

And here Component is simply pointing to a container component like:
import Component from './component'

function mapStateToProps() {
// some mapping here..
}

export default connect(mapStateToProps)(Component)

Let me know if additional info is required :v:

@bytewiz, the pages folder should be used to only define files with routes, its very necesaary because route loader tries to add magic in every file inside pages folder, as you have added Compnent inside pages folder, its breaking the code, try moving Component to app folder and it should work just fine.
Let me know if this helps!

@tirthbodawala thanks, that seemed to work out but ran into another problem loading an image and the weird thing is I am loading in an image from the same location that works.
this is the error
ERROR in ./assets/img/coverphoto.jpg
Module build failed: Error: dyld: Library not loaded: /usr/local/opt/libpng/lib/libpng16.16.dylib
  Referenced from: /Users/nielshansen/Documents/external-event-website/node_modules/mozjpeg/vendor/cjpeg
  Reason: image not found

    at Promise.all.then.arr (/Users/nielshansen/Documents/external-event-website/node_modules/execa/index.js:231:11)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)
 @ ./app/eventWebsite/Hero/index.js 23:18-63
 @ ./app/eventWebsite/index.js
 @ ./app/container.js
 @ ./pages/index.js

@bytewiz Can you please share the code of /app/eventWebsite/Hero/index.js ?

Also to solve the error for dyld: Library not loaded Please make sure you have libpng installed:
Ubuntu:
sudo apt-get install libpng-dev
Mac (with brew)
brew install libpng

Let me try that and additionally:
Loading the image from ./src/app/eventWebsite/Hero/index.js
and the image is used in the same file like this:
backgroundImage: linear-gradient(to bottom, rgba(0, 0, 0, 0.4), rgba(0, 0, 0, 0.4)), url(${DefaultHeroImg}),

like so: import DefaultHeroImg from '../../../assets/img/coverphoto.jpg';
and assets is found in ./src/assets/img/coverphoto.jpg

@tirthbodawala That worked 👍  Now only problem I am left with is
ERROR in server.js from UglifyJs
    Unexpected character '`' [server.js:109,84956]

But let me see if I can solve that :v:

Please move the require("../styles/fonts.css") from routes to src/client.js
As styles need to be managed via client it would make more sense and won't hinder compilation of server.js

@tirthbodawala I moved require("../styles/fonts.css") to the component instead but I am still getting the same UglifyJS error 😞

@bytewiz Is there a way I can assist you remotely? you can reach me at tirthbodawala [at] atyantik.com

@tirthbodawala I can't share the code, but let me try to reproduce it with another example :v: then I will share that

@bytewiz I just create a gitter channel for react-pwa if you wish to join:
https://gitter.im/react-pwa/Lobby?utm_source=share-link&utm_medium=link&utm_campaign=share-link


Please publish the 1.11.0 version to Rubygems

The latest version, 1.11.0 is not published on rubygems: https://rubygems.org/gems/twirp/versions/
Can you please upload it?

@darronschall You're right, I was misled by the tags:
https://github.com/arthurnn/twirp-ruby/blob/v1.10.0/twirp.gemspec
https://github.com/arthurnn/twirp-ruby/blob/v1.11.0/twirp.gemspec
So my request would be to release the version v1.11.0, as the current v1.10.0 is not usable at all, because there's a missing rack dependency.
This is the fix we need: https://github.com/arthurnn/twirp-ruby/blob/v1.11.0/twirp.gemspec#L24C1-L24C71
Would it be possible to release a new version, to cover it?

@darronschall  Here is the commit that fixed the problem: https://github.com/arthurnn/twirp-ruby/commit/aa4000f8ea9ff84447060ab8a7f425ed70e0bf56
There's also another use complaining about the same problem and asking for a release that would include that commit.

@fidalgo Unfortunately, I can't help you further as I'm not a maintainer of this gem (see #114).
You can set up your Gemfile to use the main branch, though, instead of waiting for a new release:
gem "twirp", github: "arthurnn/twirp-ruby"

Thank you for your reply, unfortunately this is a dependency of a gem, so I cannot use that github syntax.
I will for now stick the version to the previous working version and maybe this will catch @arthurnn 's attention.

Would also be great if we could get thegoogle-protobuf dependency bumped/relaxed as well
https://github.com/arthurnn/twirp-ruby/blob/v1.11.0/twirp.gemspec#L22
google-protobuf v3.25 has a bug that prevents it from building properly on certain linux distros. The gem then jumps from 3.25 directly to 4.26, but the current dependency specifier in the gemspec prevents us from upgrading.

Would also be great if we could get thegoogle-protobuf dependency bumped/relaxed as well

done: https://github.com/arthurnn/twirp-ruby/pull/122

https://rubygems.org/gems/twirp/versions/1.12.0 release with latest.
see here why 1.11.0 was not release to rubygems.


Added full package recommendation to Core

What problem is being solved here? There was probably a reason these were split out in the first place, which would be undermined by this change.


MessageSign hash applied?

Description
Hi to everyone I would like to ask how can I get the hash of the message I am signing starting from the message I put inside the function, since it seems is not exactly the hash of the message itself
Is there any algo or encoding applied?
Thanks
Solution
No response

Which address are you signing the message with? We use different hashes depending on the address since we use bip322 for the ordinals address and ECDSA signing for the payments address 👀

You can see the bip322 hash generation here: https://github.com/secretkeylabs/xverse-core-private/blob/develop/connect/bip322Signature.ts#L20


initial installation

We added all techs to start

@redmarverick , @theresetuyi
you can refresh your dev branch now.


Enhancement: Allow copying of item /resources

Story Maps and other apps use the /resources endpoint to store images (ex. http://www.arcgis.com/sharing/rest/content/items/7c72e12d01f44c47b224b6fd8e54daaa/resources/) - an enhancement to AGO Assistant would allow the app to copy /resources when copying an item that includes them (and reference them directly in the new version).

Duplicate of #181  ;-)

Ah, sorry, someone from your team suggested it so I figured it wasn't already there :(


Support mocks of asynchronous context managers and asynchronous iterators

While we support the async and await syntax. Several features of the pep 492 aren't yet supported by asynctest.
We must support asynchronous iterators (__aiter__, __anext__) and asynchronous context managers (__aenter__, __aexit__).
see: https://www.python.org/dev/peps/pep-0492/

I close this issue as #29 is a duplicate, and there are a few more comments there.


[Feature request] Add an ability to add table borders

Sorry for russian here 🙈. I store my scheduling in obsidian, so I made it in html table and the only thing I don't like here is the borders. It was better when the table had borders, so I would like to have a setting for this case.

Have you looked into creating a CSS snippet? This should be just a couple lines of code, something like
table { border:1px solid var(--background-modifier-border; }

You can use table tr or table td depending on which element you want a border around
You can also get help on the forum and Discord with small customizations like that
https://forum.obsidian.md/t/getting-comfortable-with-obsidian-css/133

Okay, this one looks nice, but how can I center text in td tags? I'm not very good at css, so sorry for like a noob question :(

I would recommend asking this question on the Obsidian forum or Discord because it's not really related to this plugin.
There are a few solutions to this, one would be in the markup of your file, another would be as a CSS snippet that applies to all tables, or use YAML to define classes that will only apply to a specific file
The basic code is as follows, but you'll likely need to add more specific selectors
table td { text-align: center;}

Okay, further questions I will ask on the forum, thanks a lot for your help and this theme, looks pretty good!


Item is replaced by multiple items

I'd like to ask if replacing the item with multiple items is considered a valid status.
I'm struggling with these Items:

https://lindat.mff.cuni.cz/repository/xmlui/handle/11858/00-097C-0000-0023-1AAF-3 It is replaced by two items
https://lindat.mff.cuni.cz/repository/xmlui/handle/11234/1-2375 It is replaced by two items
https://lindat.mff.cuni.cz/repository/xmlui/handle/11234/1-3185 it replaces three items
https://lindat.mff.cuni.cz/repository/xmlui/handle/11234/1-4595?show=full it replaces three items

Generally, it is a valid status for both replaces and replaced by.
Item can replace multiple items if it has all their data and some extra annotation on top of that. So the relations is more than pure haspart. That'd be the case for PDT-C and the treebanks it consolidates.
Item can be replaced by multiple items if it splits into multiple projects (like dspace now having fe and be separately).
Though, with those concrete examples, you've posted, I'd need to check my records. CzeDLex surprises me a bit.

It's kind of mentioned in https://github.com/ufal/clarin-dspace/blob/8a6ba5c98547942d7115b74cf4978e0b29ca50e4/dspace-rest/src/main/java/org/dspace/rest/ItemsResource.java#L1076-L1086

Yes, that can happen and here it really did happen. For instance there were two succesors of PDT 3.0, because one kept the data and added some more annotation (analysis), and the other project merged the parent treebank with more data.
So it can happen both ways: father with more children, and also a child with more parents (merging datasets into one).


Added Canary careers page

I hate long recruiting forms too. :)

Thanks a ton for the addition! :)


add Java base image for version 10

Unfortunately it looks like gradle does not support Java 10 before release 4.2. For the moment I want to focus on getting a new release out. This means I prefer not to make major changes to the build system unless critical for releasing. Once a new release is completed we can revisit the upgrade of gradle as well to fix this and thus support java 10 in the core.
Sorry for the inconvenience :)


right-tabs is locked in primary side

Watch video in two column
Go to channel page ( or search or home, etc)
close the mini player if any
resize to single column
load the video in single column
resize to two column

fixed in 4.72.40


add project to Projects using Docile / Lexicon

hi,
I would like to add your project to Projects using Docile / Lexicon
if that is fine with you.
Thanks.

Sure, feel free.

Thanks a lot


Add Groupban Status to API response

A simple PR that adds the groupban status of a user to the API response of the /user endpoint

Wait why did it add the help page thing?

Gonna remake this without the help page stuff, one sec


window.Vaadin.server.views contains all routes not just server-side routes

Describe the bug
FS Router's generated routes from the frontend/views directory along with the registered server-side routes are being stored in the window.Vaadin.server.views by RouteUnifyingIndexHtmlListener. Either the Vaadin.server.views should only hold the server-side views, or the object should be renamed to something more general e.g. Vaadin.views (in case it doesn't clash with another existing global object). It's confusing to have all views under Vaadin.server.views. Also, the term "views" is probably better to change to "routes".
Expected-behavior
No response
Reproduction
N/A
System Info
N/A

The vision for the long run is that it should be possible to filter and modify (e.g. translate menu titles) both client-side and server-side views through a Java API. Based on that, I would suggest that we keep all views in the structure but rename it.


modified code with better syntax and readability in a new file

Added a new file with the same functionality and made it more readable.
Since I didn't understand the algorithm, I couldn't test it properly.
But matching the original code output with the new code I wrote, both seem to work the same.
Open a issue or discussion and mention me if there's something that's not working or you don't understand certain parts of it.

This works well. It's a bit further into concepts i am not familiar so i'm not going to replace my code, but i plan to incorporate a lot of the concepts you've used in time. Thank you for contributing!


[Question] Readability of crash diagnosis

Describe the bug
Is there a way to have better readability of lastFunctionName/callName of a crash when it's recorded? Only showing the <redacted> infos without the additional substring?
Steps to reproduce
Trigger a crash to get the diagnosis from crash report
Crash report or stack trace
e.g. Originated at or in a subcall of $s16<redacted>18<redacted>C10<redacted>33_0DCC8E338A8DEB9FDDDEFBFF121F7EC2LL7forTypeyAC0dQ0AELLO_tF
Note: <redacted> in the example above are the: app name, file name,  function name
KSCrash version
2.0.0-rc.8
Operating System
iOS
OS version
iOS 17.7.2
Device model
No response
Xcode version
16.1
Additional context
No response

Hi!
I see you're encountering <redacted> placeholders in function names, but I'm not sure I fully understand your request. KSCrash itself doesn't add these redactions. Could you:

Share a complete crash report example
Explain what output format you're expecting to see instead

This will help me better understand how to assist you.

Hey, thanks for getting back! Sorry if it's confusing to you.

Originated at or in a subcall of
$s16App_Name18ClassNameC10FunctionName33_0DCC8E338A8DEB9 FDDDEFBFF121F7EC2LL7forTypeyAC0dQ0AELLO_tF

I have to omit the app name, class name and function name for confidentiality hence, the <redacted> in the original post.

I prefer to have it in this format:
Originated at or in a subcall of AppNameClassNameFunctionName

Is there a way to beautify it or remove the remaining substring?
Thanks.

Sorry for the delay—looks like my earlier message got lost. If you want to make your crash reports easier to read, try using the KSCrashDemangleFilter. It takes care of demangling Swift symbols, so your reports are much clearer. You can add it to your crash report processing pipeline, and it’ll automatically handle demangling during the sendAllReports call. If you’re using the Installations API, this module is already enabled by default.


Conflict watcher is eating CPU time like crazy

ConflictingFileWatcher:watchConflictingFiles creates a watcher for observing conflicts. It has no throttle, and when there's a conflict in the local repo, it's using massive amounts of CPU time.

I've band-aided this by adding a Thread.sleep in the watch method within the thread that's created. I've added a TODO in the InterruptedException to do something reasonable, but right now it does nothing. I suspect the right thing to do is set a boolean variable and break out of the loop if an interruption happens, like we do in RepositoryMonitor:watchRepoForRemoteChanges, but I'm not sure. Someone needs to carefully look at this and see what the right thing to do is for an InterruptedException.
I also made the thread low priority. That's didn't solve the CPU problem, but it seemed like a good idea anyway.


Get more than just chromosome 20 output from Indexcov

To avoid overwhelming output during debugging, indexcov currently only "officially" returns chr20 related files -- the others are generated but are technically not considered WDL outputs. We should be returning everything.

New globbing method has been shown to grab outputs from all chrs


Update README.md

Adjusted grammar in the readme

ping @michaelRadigan
Got some conflicts (blame @egnwd as usual)

Fixed as part of 4cca541


Make postMessage's 2nd param, targetOrigin, optional

Fixes Microsoft/TypeScript#30042.

This is wrong, it is a must.
https://developer.mozilla.org/en-US/docs/Web/API/Window/postMessage
https://html.spec.whatwg.org/multipage/window-object.html#the-window-object:dom-window-postmessage

Thanks for pointing that out @saschanaz. I got confused by the part of the spec linked from Microsoft/TypeScript#30042 that references the options object, where targetOrigin is optional.

Reverted.