Jax support

i have a couple of links but I'm slightly confused what the recommended jax implementation of flash-attention.
here are the links:

jupyter: https://github.com/jax-ml/jax-triton/blob/main/examples/JAX_%2B_Triton_Flash_Attention.ipynb
indepedent repo: https://github.com/lucidrains/flash-attention-jax

Which one should I be using? Or should I be implementing my own in jax?
I need both forward & backward passes.
Related tf: https://github.com/HazyResearch/flash-attention/issues/35

I don't use Jax, so I'm not sure. We have a PyTorch interface that calls the CUDA implementation.
Alternatively there's an implementation in Triton that can be called from PyTorch.
My understanding is that jax-triton is a way to call Triton from Jax. You'd just need to connect it to the forward and backward in Triton.
My impression is that flash-attention-jax is an implementation in pure Jax that probably doesn't have the speed benefit of FlashAttention (but might still be memory-efficient).

I don't use Jax, so I'm not sure. We have a PyTorch interface that calls the CUDA implementation. Alternatively there's an implementation in Triton that can be called from PyTorch.
My understanding is that jax-triton is a way to call Triton from Jax. You'd just need to connect it to the forward and backward in Triton. My impression is that flash-attention-jax is an implementation in pure Jax that probably doesn't have the speed benefit of FlashAttention (but might still be memory-efficient).

that's helpful thanks Tri! Will figure out what to do and report back.

My impression is that flash-attention-jax is an implementation in pure Jax that probably doesn't have the speed benefit of FlashAttention (but might still be memory-efficient).

👀

I think it would be straightforward, since most of the code is just CUDA kernels, with a Pytorch interface. The only place in the CUDA kernels that uses Pytorch is reading the random seed from the Pytorch RNG.

I've written a jax binding as a fork of this repo. There's a few features not implemented yet, such as dropout, but I see how to do it and doesn't seem too hard, so I'll probably have that working soon too. https://github.com/nshepperd/flash_attn_jax

@nshepperd Have you looked into the new pallas JAX kernel at all?
Thanks for sharing your flash attention implementation!

I haven't. I would interested to see a benchmark comparison of pallas JAX vs this repo. I don't expect pallas kernels to be as efficient, but who knows, maybe it's actually good.

One weekend I might learn it and give it a shot. I'll let you know


Create the Landing Page in React.

Deliverables:
Add the deliverables with their description here.

[x] Follow the design from Here
[x] Use Material UI to create the page.

Screenshots

Illustrations will be available by tomorrow.

is that navbar is not yet created?

@ashuvssut material ui is our go to library for this app. So that navbar needs to be created using material ui and yes it can be created by over riding some values. So yes if you can create something close using the material-ui I can assign you this page.

There will a lots of makeStyles overriding
So, in this issue, contributor has to work on that landing page and that Navbar too?

Is that navbar fixed or will it move up and hide iteself

For now create the rest of webpage , Nav bar needs another issue. You can create one issue, I'll add tags.

You want to be assigned to it?

For now create the rest of webpage , Nav bar needs another issue. You can create one issue, I'll add tags.
alright! i was just confirming this

Plz assign me this issue.

Ilustrations added at client/src/assets/svg/ , all the best brother.

Closing this issue @ADRE9


WARNING **: Error retrieving accessibility bus address: org.freedesktop.DBus.Error.ServiceUnknown: The name org.a11y.Bus was not provided by any .service files

Error output by Gtk applications.
 $ echo $XDG_CONFIG_DIRS

/home/netsu/.nix-profile/etc/xdg:/nix/var/nix/profiles/default/etc/xdg:/run/current-system/sw/etc/xdg

 $ tree /run/current-system/sw/etc/xdg/

/run/current-system/sw/etc/xdg/
├── autostart
│   ├── pulseaudio.desktop -> /nix/store/b8f56ikl1bvgg5va62p6cj7hgshjp6c9-pulseaudio-8.0/etc/xdg/autostart/pulseaudio.desktop
│   └── wicd-tray.desktop -> /nix/store/2ijqyvnms7j9h1fmn798g27igicm5p54-wicd-<IP_ADDRESS>/etc/xdg/autostart/wicd-tray.desktop
└── systemd -> /nix/store/d1w81dnv8wr55hwhwxdawwwx40f75ykx-systemd-230/etc/xdg/systemd

2 directories, 2 files

 $ tree /nix/store/0kq005z0cc5bfjais88ma92ycwrfwwxq-at-spi2-core-2.20.1/etc/xdg

/nix/store/0kq005z0cc5bfjais88ma92ycwrfwwxq-at-spi2-core-2.20.1/etc/xdg
└── autostart
    └── at-spi-dbus-bus.desktop

1 directory, 1 file

Could be solved by NO_AT_BRIDGE=1,  but this's temporary hack.

Also error fixed if launch directly /nix/store/0kq005z0cc5bfjais88ma92ycwrfwwxq-at-spi2-core-2.20.1/libexec/at-spi-bus-launcher

FYI: I don't use any DE, maybe this cause an issue.

I've seen similar problems running XMonad and no DE; would be interested in seeing what people suggest.

Maybe I should enable services.gnome3.at-spi2-core.enable?

Yes, it solved issue.

So, in case of this error, here at least two options:

to disable

variables = {
  NO_AT_BRIDGE = "1";

to enable

services.gnome3.at-spi2-core.enable = true;

I solve this in ubuntu by installing 'at-spi2-core' package

I solve this in ubuntu by installing 'at-spi2-core' package

This solved the issue for me as well running on Lubuntu 16.04

Solved this issue for me as well, by installing 'at-spi2-core' package in Siduction 17.10 patience (based on Debian testing/unstable)..
Thanks...

Would it be a good idea to set NO_AT_BRIDGE=1 in at-spi2-core.nix when the service is not enabled? Something like this:
  config = mkMerge [
    mkIf config.services.gnome3.at-spi2-core.enable {
      environment.systemPackages = [ pkgs.at_spi2_core ];

      services.dbus.packages = [ pkgs.at_spi2_core ];
    };

    mkIf !config.services.gnome3.at-spi2-core.enable {
      environment.variables.NO_AT_BRIDGE = 1;
    };
  ]

It seems like a good idea to me; do you want to make a PR?

It still produces the warning for me, even with the service enabled.

The issue with missing systemd unit error will be fixed in #28856
Error retrieving accessibility bus address: org.freedesktop.systemd1.NoSuchUnit: Unit at-spi-dbus-bus.service not found.

Me too. No, no, not that, I mean the warning message. As of March 2018 that was still popping up for me a lot in a plain Ubuntu 16.04 made from the mini.iso with x, lightdm, and openbox & no DE per se every time I used zenity for example. Installing at-spi2-core eliminated it.


Custom Event Indexer API

Adds a new field for an Event Indexer in the Connections modal.
Try https://eventindexer.l3test.taiko.xyz(L3 events) or maybe http://<IP_ADDRESS>:4101 (L2 events but it's missing a lot of data I think , need to fix it)
Default is still https://eventindexer.test.taiko.xyz
Regards,  Spach

Resolves #2

LGTM, thanks


ci: inverted sliders, honor inverted key down handler for horizontal sliders

Fix for the issue: https://github.com/zillow/react-slider/issues/286
Tested on localhost:6060 and all sliders still work as expected
https://zillow.github.io/react-slider/
See the slider "An inverted slider with custom marks" and attempt to press the left and right arrow keys, that behavior will now be inverted with this change

@kris-ellery Management on my team is eager to get this functionality into our app, are you the person for me to ask to pr this change?

@Ryan-Haig12 can you add supporting tests for this use case?

I sure can, I will get on that as soon as I get around to it. Thanks man

@kris-ellery I added some basic tests here. React-test-renderer is far from my strongest skill so if there is a simpler way to do this or you would like me to change anything please let me know

@Ryan-Haig12 thank you, I'll do my best to merge in few open PRs and craft a release this week. Apologies for the delay.

@kris-ellery friendly reminder

@kris-ellery Friendly reminder, we're still a few weeks out from our release that requires this functionality for our app. Management would just like to get this in sooner rather than later if possible

You're the man @kris-ellery thanks a bunch!

Thank you for your patience. Merged and published in v2.0.5


Invalid date with date format = 'dd/mm/yyyy'

When you fill a date with the date format = 'dd/mm/yyyy', and continue to fill till max numbers, there is an invalid date error. You must check if it is a valid date before updating model.
Something like this (did not tried):
if (this.value.length === this.mask.length && isDate(this.value)) {
  const date = this.host.parseValueFromString(this.value);
  this.host.updateModel(date);
}

was looking through the primeng calendar doc, and these are the options:
d - day of month (no leading zero)
dd - day of month (two digit)
o - day of the year (no leading zeros)
oo - day of the year (three digit)
D - day name short
DD - day name long
m - month of year (no leading zero)
mm - month of year (two digit)
M - month name short
MM - month name long
y - year (two digit)
yy - year (four digit)
@ - Unix timestamp (ms since 01/01/1970)
! - Windows ticks (100ns since 01/01/0001)
'...' - literal text
'' - single quote
anything else - literal text

this lib still doesn't support all the formats, but for your case the correct date format should be dd/mm/yy

will fix the readme later today, to be clear what date format does it support, but if you still get errors with the date format that i sent, then i'll lookup to fix it 🎩

Yeah sorry, i wanted to say 'date format = dd/mm/yy'.

Strange, will lookup what is happening

oh, found out what is wrong, my bad, forgot the validation. fixed it on 0.0.6 🎩

Did you try?

Sorry for forgetting to test (this was pretty bad by my part) but was on a hurry here, if there is any problem just open an issue or a PR 👍


Clojurescript should be a dev dependency

Onyx (https://github.com/onyx-platform/onyx) uses clj-fuzzy as a dependency, however we have to exclude clojurescript, as it is an unnecessary dependency for clojure users, and can cause conflicts in our user's projects. I think you would be best served by making it a dev dependency, as any of your cljs users will need clojurescript as a dependency anyway.
Thanks for a great project!

Hello @lbradstreet. You are right indeed. However, I can't find the way to do so in the project.clj file. How do you designate a dependency to be dev with leiningen?

You can add a dev profile to your project.clj, like so:
:profiles {:dev {:dependencies [[org.clojure/clojurescript "0.0-3308"]]}}
Thanks!

@lbradstreet I just pushed a commit to update the project.clj file. Can you check it and tell me if this looks good so I can publish a 0.3.3 release please?

Perfect! Thank you

Thanks @lbradstreet. v0.3.3 is now released on both npm and clojars.


Copy link and enter word will result error

@pftom This issue seems resolved. Please re-check it.

@mRcfps Yup, I'll close it


OneKE - Storage nodes misconfigured if using custom or cloned Image

Bug Info
Description:
If VM Template of a storage node was altered to use custom Image(or clone of the original image) as a second mounted drive - the VM never finishes its configuration and not joining the k8s cluster.
 2/3 Configuration step is in progress...

 * * * * * * * *
 * PLEASE WAIT *
 * * * * * * * *`

Some of the symptoms:

The resolv.conf is different than on a healthy node:
RKE2 agent tries to query itself
The RKE2-agent configuration is also different than on a healthy node (the server set to: server: https://:9345)

Affected OneKE versions are both 1.29 and 1.27
Important note
Please note that the behaviour is going to differ whether second network (private) is isolated or not. But result is going to be the same - storage node is misconfigured and not joined the cluster!
If Private Network isolated:

The resolv.conf is missing on the damaged node, while it exists on a healthy node.
/var/log/one-appliance/configure.log is going to contain errors to communicate with OneGate Failed to open TCP connection to <IP_ADDRESS>:5030 (Network is unreachable - connect(2) for "<IP_ADDRESS>" port 5030)
rke2-agent systemd service is going to be dead

If Private Network is routable (easiest way - hook both networks to the same Vnet):

resolv.conf is pointing to the network defined by the Vnet
no errors in the /var/log/one-appliance/configure.log - I, [2024-10-25T13:52:33.674020 #1449]  INFO -- : Join storage: oneke-ip-172-16-100-4
RKE2-Agent errors: Oct 25 13:54:42 oneke-ip-172-16-100-4 rke2[1552]: time="2024-10-25T13:54:42Z" level=error msg="failed to get CA certs: Get \"https://<IP_ADDRESS>:6444/cacerts\": read tcp <IP_ADDRESS>:51308-><IP_ADDRESS>:64>

Steps to reproduce:

install miniONE.
Import OneKE 1.29 service.
Clone the default image that is used as a second disk for storage role nodes. (typically: Service OneKE 1.29-storage-2-*-1 and is 10G in size)
Change the Service OneKE 1.29-storage-2 VM Template to use the cloned Image as a second disk instead of a default one.
Instantiate service using the preferred method and make sure that k8s environment is running as expected (set enable traefik, longhorn, dns, route, NAT)
Scale the storage role by changing its cardinality to 1

Result:
The storage VM can't finish its configuration thus not added to the cluster.
Service stuck in Scaling state.
Workaround:
You can resize the disk after the VM is up and set the desired value.

Hi @rsmontero , please find the .json export attached.
fsun-3.json
I've conducted some additional research based on my guess that the problem is a bit wider and might affect more than just OneKE service.  And it seems that it's somehow related to the FSunstone. Here are some evidences:
I've simplified the change - just set the hypervisor to KVM (because it's the minimal change you can do and also is the mandatory one if you edit the template). Such a small change results to storage role not being scaled properly and service stuck.
Tried to perform the same process of setting the hypervisor type using the NSunstone and the service got scaled without any issues.
Next I did a few cross-checks:

Took the service that contains the template edited using NSunstone,  and instantiated that in FSunstone , and then scale the storage role. The result is - storage node added without issues.
Took the service that contains the templated edited in FSunstone using the NSunstone, and then scale the storage role. The result - storage node misconfigured and thus not added to the k8s cluster.

If we compare two templates of the same origin - the huge part of CONTEXT is missing from the FSunstone:
Template after the edit in FSunstone:
fsun-storage-tmpl.json
Template after edit in NSunstone:
ogsun-storage-tmpl.json
Original template:
defaults-storage-tmpl.json
If VM Template is getting cloned - no issues, the issue appears only after editing and saving the template in FSunstone.

Thanks @alpeon I'm moving this to the OpenNebula repo to look into the FSuntone issue there.
Thank you for the detailed description and log files :heart:


i18n(zh-CN): improve Chinese translations and add missing localizations

@NekoAria  Hi, and thank you for your interest in contributing to this project!
Since Chinese is already being maintained on Crowdin, it would be great if you could submit your translations there instead. Managing translations in one place helps ensure consistency and makes maintenance easier.
Thanks again for your support🙏


"postMessage" declartion in 'lib.dom.d.ts' may have a little problem

TypeScript Version:  3.3.3

postMessage declartion in lib.dom.d.ts is

declare function postMessage(message: any, targetOrigin: string, transfer?: Transferable[]): void;

Its second parameter targetOrigin is set as a must.
But I found samples on MDN about postMessage don't pass it.
There may lack a ? after targetOrigin.
When I set use strict of comile options true and don't pass targetOrigin, compiler will warn me ,which makes me X﹏X.

Indeed optional according to the living "whatwg" specs.
https://html.spec.whatwg.org/multipage/web-messaging.html#posting-messages
"A target origin can be specified using the targetOrigin member of options. If not provided, it defaults to "/". This default restricts the message to same-origin targets only."
The fix probably needs to come from https://github.com/Microsoft/TSJS-lib-generator

OK,Thank you.

The relevant location, I think, is:
https://github.com/Microsoft/TSJS-lib-generator/blob/master/inputfiles/overridingTypes.json#L474
or, if master changes and the line isn't relevant, open overridingTypes.json and search for postMessage.

Actually, as @saschanaz points out, https://html.spec.whatwg.org/multipage/window-object.html#the-window-object:dom-window-postmessage shows that the parameter targetOrigin is required. When you provide an options object instead, the options object has an optional property named targetOrigin.

@saschanaz  @sandersn could you please check it out again? The docs you linked to say:
  void postMessage(any message, USVString targetOrigin, optional sequence<object> transfer = []);
  void postMessage(any message, optional WindowPostMessageOptions options);

which means postMessage([anything]) is a valid call. Perhaps the real issue is the types missing the overloaded signature (that has the optional options object).

@AviVahl I think @saschanaz fixed this in Microsoft/TSJS-lib-generator#679. Mind taking a look to see if that's the case?

@sandersn issue does seem to be fixed in @saschanaz's PR.
you guys are awesome.

All thanks go to @saschanaz ! I am just a newbie in this space.


getStoreValue(storeName)

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior
Usually retrieving the value from a story works flawlessly with the query. But there are might be occasions where you want to get the value without using the query cause the query is not reachable at the moment.
What is the motivation / use case for changing the behavior?
I'm thinking of the runStoreAction function, which lets you perform crud operations. Now why not having it the otherway around.
getValueFromStore(storeName: string), so you can get the a snapshot of information from a store. If this issue got a positive feedback i can do a PR.

You can already access the store by using getStoreByName.

yes agreed. getStoreByName works fine for me!


"All" page should only list an item once for the stable version

Example:

Given that we are viewing /en/all and no version is implied by the URL, the docs viewer currently displays every topic title for every version. This results in many duplicated titles/versions.
In this instance should we assume the stable version, and use that to list the topic titles just once?
cc @tractorcow

Yep that would be nice. It seems a bit excessive to list everything.
How about forcing 'all' to a version? e.g. 'https://docs.silverstripe.org/en/3/all' instead of 'https://docs.silverstripe.org/en/all'

I like that. Then you can still list all topics by each version. Will update my pull request.

@tractorcow I've updated the PR a little to include the version in the URL while still filtering by it.


Matcher integrated with POS tagger

Not an issue, just a question, I find the matcher to work great! Would it be feasible to integrate the matcher with the POS tagger so that items entered into the matcher are automatically tagged as nouns or direct objects, though they may also be other parts of speech as in titles of movies, books, songs, etc?
The idea being that if I create a matcher data structure containing many song titles such as 'a horse with no name', 'sister golden hair' or 'I need you' the entire phrase is tagged as a direct object in sentences like: 'At the concert last night the band played 'sister golden hair.'

Thought I replied to this already. Maybe I'm confusing this with another question.
Okay so, one possibility is to use the .merge method on the Doc object. This retokenizes into a single token. You'll lose any internal structure, and be able to give the whole thing a single POS tag. You also get a Token object, instead of a Span object, which is a bit easier to deal with.
Does that help?

I can't get it to work, can you tell what I'm doing wrong?
from future import unicode_literals
import spacy.en
from spacy.en import English
text = 'WKRO played songs by the beach boys all night'
nlp = English()
doc = nlp(text, tag=True, parse=True)
merge 'The Beach Boys'
doc.merge(4, 6, 'NAMED', 'LEMMA', 'TYPE')
parse the doc
for token in doc:
print '\n'' + token.orth_ + '''
print 'pos: ' + token.pos_
print 'dep head: ' + token.head.dep_
print 'dep: ' + token.dep_
for child in token.children:
print 'child: '' + str(child) + '''

Interface is a bit rough here --- sorry.
The start and end indices are character offsets, not token indices. The reason for this is, if you want to be merging things, you're going to be changing the token indices, so it's nice to define things by character offsets instead.
But I get that this is awkward and confusing. I'm still trying to refine this part of the workflow. The implementation of merge() is also a bit shakey.
So, what you need is something like this:
from __future__ import unicode_literals, print_function

import spacy.en
from spacy.en import English

text = 'WKRO played songs by the beach boys all night'

nlp = English()
doc = nlp(text, tag=True, parse=True)

# merge 'The Beach Boys'
doc.merge(doc[4].idx, doc[6].idx + len(doc[6].orth_), 'NAMED', 'LEMMA', 'TYPE')

# parse the doc
for token in doc:
    print("\n'" + token.orth_ + "'")
    print('pos: ' + token.pos_)
    print('dep head: ' + token.head.dep_)
    print('dep: ' + token.dep_)

    for child in token.children:
        print("child: '" + child.orth_ + "'")

Thanks for your very quick reply. This works great to merge the words into a single token, however the POS tag isn't updated to 'NAMED' as I expected. Isn't it supposed to be?
There also seems to be a bug in merge concerning rebuilding the child nodes as the last for loop iterating over the token.children causes a Segmentation Fault 11 on my MacBook Air if the merge is performed (no fault if the merge isn't).

Re: the part-of-speech...
So, spaCy tracks two different types of part of speech tags:

Coarse-grained tags, enumerated in spacy.parts_of_speech, drawn from the Google Universal Tag Set. This tag is recorded in token.pos.

Fine-grained tags, defined by the treebank used to train the tagger. For the English model, this means the 45 tags from the Penn Treebank. This tag is recorded in token.tag.

So, probably you're looking at the token.pos tag, which isn't changing currently. This is probably wrong.
Normally what happens is, a coarse-grained .tag value is mapped down to a coarse-grained .pos value. You can see the default English mapping in lang_data/en/tag_map.json. It's also accessible from nlp.vocab.morphology.tag_map.
Probably the best solution here is to require the user to assign a tag defined in the tag_map. We can allow users to add new definitions if they need them. That way, the user's tag can be used to calculate the appropriate .pos and morphological features.

Thanks for reporting the .children bug. Fixed.


add Brand University of Applied Sciences, Hamburg

@mmaul-bu Thank you for your patience while waiting for a review and processing your request.
Pull request merged. Thank you!


Performance with default parameters looks completely off...

I am following exactly every step, and the firs couple of epochs look like:
Header pof m30k_deen_shr.train.log:
epoch,loss,ppl,accuracy
0, 9.15762, 9486.43847,0.014
1, 9.14988, 9413.27772,4.100
2, 9.13908, 9312.21408,10.980
3, 9.12995, 9227.57595,11.952
4, 9.12218, 9156.17200,12.014
5, 9.11489, 9089.63892,12.015
6, 9.10745, 9022.23094,12.015
7, 9.09957, 8951.48423,12.019
8, 9.09133, 8877.95168,13.178
9, 9.08266, 8801.31062,16.358
Which is tootally off compared with the README plot. Is there a customized parameter I should use to replicate the author's performance number?

I believe the default parameter means batch size 2048, warmup 4000, and learning rate 2.0. In my case, I set batch size 128, warmup 128000, and learning rate 8.0. It took about 120 epochs to achieve the reported results (ppl ~ 10.5 and accuracy ~ 58.5% on the validation set). Hope this helps.


Editor multi window support

Godot version:
3.1
OS/device including version:
linux
Issue description:
It would be very useful to have multi window support in the editor. Currently I find I waste a large amount of time flipping between tabs and layouts.
It would be useful to have support for a seperate window dock where the user can drag the ide, the viewport or the docks.
I find this extremely useful when working in other software over multiple monitors, or on linux, multiple virtual desktops.

Duplicate of #9059 (and other issues linked there)


Converting to romanji when the text is tokenized

Hi Paul
Thanks for the awesome library. I have a problem where I'm trying to convert a tokenized Japanese text to Romanji.
" 何人ですか ?" is correctly "Nanijindesu ka"?
But if i tokenize the text to [何, 人, ですか, ?] and convert each token to romanji it is incorrect because the text is missing.
How would I covert Japanese text to Romanji so I can get two matching tokenized arrays?

Glad you're enjoying the library. Please note the word "romaji" has no "n".
何人ですか would normally be read "Nannin desu ka" ("How many people?"). "Nanijin" is also valid but drastically less common.
If you need aligned tokens and romaji you can use the romaji_tokens functionality that was added recently.
import cutlet

katsu = cutlet.Cutlet()
words = cutlet.tagger(cutlet.normalize_text("何人ですか"))
toks = katsu.romaji_tokens(words)

for tok, word in zip(toks, words):
    print(word.surface, tok.surface, sep="\t")

Oh you're a life saver. Am I missing something?
AttributeError: module 'cutlet' has no attribute 'tagger'

Sorry, there was a mistake in the example code. It should be katsu.tagger - the tagger object is on the instance, not the class.

Amaze balls!


[Unified Recorder] TestProxyClient takes test context to generate recordings at desired location

Issue https://github.com/Azure/azure-sdk-for-js/issues/17384
Changes in the PR

TestProxyClient takes test context to generate recordings at the desired location.

this.currentTest is supposed to be obtained from the beforeEach block to be passed on to the TestProxyHttpClient.
Docker volume to be mapped at the root of the repo (/base-path/azure-sdk-for-js/)
We get the file name for the recordings from the test context's title and fullTitle properties. ({node|browser}/describe_block_title/recording_test_title)
We get the path to recordings folder

from the testContext in node (sdk/service-folder/project-folder/recordings)
with an additional env variable(RECORDINGS_RELATIVE_PATH) in the browser.   (sdk/service-folder/project-folder/recordings)

Joining the above gives the full-fledged path to the recording

Example /base-path/azure-sdk-for-js/
|_ sdk/service-folder/project-folder/recordings/{node|browser}/describe_block_title/recording_test_title.json

Adds a server for the tests, to play the role of actual service to be able to test the proxy-tool end-to-end.

Using "concurrently" to run the node server and the test command in parallel, the command exits when one of the processes end, which in this case would be the test script, be it mocha or karma.

Disabled the test scripts(in the recorder-new folder), for now, will enable them back as soon as the "starting the proxy-tool(and stopping)" part is figured out.

Meanwhile, to run the tests in recorder-new folder, start the proxy-tool and run the temp-integration-test:node and temp-integration-test:browser commands.

Next Steps

Add sanitizers
Add transforms
Add starter script for the proxy-tool
Enable the test scripts in recorder-new
Document how to write a test using the unified recorder

Fixes #17750, fixes #17384

I like what we’re doing here. I think I’d like to have a better perspective of what’s the short-term, mid-term and long-term perspective of this recording. What about making a roadmap? Similar to the long-term goals of other SDKs. I’m asking this because I want to know where we’re heading beyond this PR.

What about making a roadmap? Similar to the long-term goals of other SDKs. I’m asking this because I want to know where we’re heading beyond this PR.

https://github.com/Azure/azure-sdk-for-js/pull/17989 @sadasant


Update link

Erick, your post on  http://ericholscher.com/blog/2013/sep/25/help-me-improve-documentation/ needs update, particularly on Gittip (now Gratipay). The same faith, I think, goes to this document.

Thanks :)


Login screen placeholder text color changed

Galaxy S4 issue for placeholder text color is fixed.
JIRA: https://openedx.atlassian.net/browse/MOB-1515
cc @rohan-dhamal-clarice  @shahidtamboli

:+1:

:+1:


feat(DlTypography): add markdown and plaintext

Thank you for your contribution to the repo. Before submitting this PR, please make sure:

[x] Your code builds clean without any errors or warnings
[x] You are using approved terminology
[x] You have added unit tests
[x] You have updated documentation
[x] You have tested your changes

Please provide a description of the changes proposed in the pull request and reference any related issues in the repository.
Please indicate if this PR contains:

[ ] A bug fix
[x] A feature request
[ ] Breaking changes
[ ] An enhancement

Changes

Add markdown and plaintext support in DlTypography component
DlTypography moved to Composition API (vue-demi)

@letavocado Hey, thanks for your contribution.
We have a component that uses the marked library already called DlMarkdown.
The component itself is simple and can be built upon with the highlight feature you used and so on.
Please refactor the code so as to use said component inside the DlTypography if a specific prop is passed called markdown, the prop will be a boolean type.

Hey @fadiDL! Awesome, I'm aware that DlMarkdown is exist. I even thought about using it. But based on @RotemDl's  suggestion, I've made it as a prop of DlTypography.

Please refer to the preexisting md component (DlMarkdown). Don't create a new and redundant one. You can improve it if you need to.
I suggest adding the md support as a prop to dl-typography.

© @RotemDl

Cool, I'll refactor it, and use DlMarkdown inside of DlTypography.

But there is no highlight feature, even in code. I'll add it.

Hey @fadiDL @RotemDl. Please check it out! I've also added the missing tests and stories. 😊


Ajax Grid render.

Hi,
I have menu in my MainPage like this

                                              @Ajax.ActionLink("Services", "Services", "PrivateCabinet", new AjaxOptions { UpdateTargetId = "main" })

                                         @Ajax.ActionLink("Service categories", "ServiceCategories", "PrivateCabinet", new AjaxOptions { UpdateTargetId = "main" })
and div what I updateting

Than I would like to show some partialViews on click ActionLink in main div. I place in those partialView MvcGrid.
@model IEnumerable<Service> @(Html         .Grid(Model)     .Build(columns =>     {         columns.Add(model => model.ServiceCategory.Name).Titled("Service category");         columns.Add(model => model.Description).Titled("Description");         columns.Add(model => model.SortOrder).Titled("Sort order");     })     .Filterable()     .Sortable()     .Pageable(pager =>     {                 pager.RowsPerPage = 14;     })     .Css("table-hover") )
But need to change it as AjaxGrid because of paging not working on this what I have now.
I don't know how to use @Html.AjaxGrid(Url.Action("Services"))
Please help me.
Thank you.

Does it not work at all or after loading your content? Could you share a small repro?

Hi here is som repro solution. Go to About View.. There is some comments.
TestGrid (2).zip
Thank you.

There are a few possibilities here, on click you could:

Load a new partial with ajax grid included in that partial view (don't forget to intialize the grid after load).
Render the grid in hidden container and just unhide it.


Update setup-ha-etcd-with-kubeadm.md

fixes : #41420

issue: #41420

please change this to "fixes #41420"

fixes : #41420

should be without the :

/assign @tengqm
PTAL

/approve


Feature/ios background location

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Adds an additional option to Apple settings that allows the user to configure the background location indicator that needs to be set to true if the application is started up in the background by some other process and it then requests a location.
:arrow_heading_down: What is the current behavior?
Cannot be set currently.
:new: What is the new behavior (if this is a feature change)?
Exposing the CLocation manager setting to the user
:boom: Does this PR introduce a breaking change?
No it doesn't.
:bug: Recommendations for testing
One will have to start the application in the background through a system event or reminder and then request the location.
:memo: Links to relevant issues/docs
N/A
:thinking: Checklist before submitting

[X] I made sure all projects build.
[X] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[X] I updated CHANGELOG.md to add a description of the change.
[X] I followed the style guide lines (code style guide).
[X] I updated the relevant documentation.
[X] I rebased onto current master.

Applied as per suggestions.


Feature Request: Fix for liquids not using smooth lighting even if it is enabled

Is your feature request related to a problem? Please describe
In vanilla Minecraft, water does not use smooth lighting even if it is enabled.
Describe the solution you'd like
I think it would be a cool feature of Alfheim to fix this.
This is what water currently looks like in vanilla MC and even with Alfheim installed:

Indeed would be cool

i believe Fluidlogged API fix this issue


adds fixer support for hfmt

added a fixer for haskell files using hfmt
hfmt is a tool for formatting Haskell programs. Currently it is simply a gofmt style wrapper of the excellent tools hlint, hindent, and stylish-haskell.
i didn't include the options since they're mostly for different kinds of print output.

great, thanks again

Cheers! :beers:


Fix issue where source files could get corrupted.

This could happen when you had multiple language services, and they were sharing some files.
If a file got edited in one LS, it could get corrupted in the other.  Now, the DocumentRegistry
serves as the canonical source of 'good' source files.  Language services always go to it to get
the correct source file instead of trying to manually update their own source files when they
are notified about changes from the host.

unit test?
:+1:

@mhegazy adding tests.


mr-0 class added to fix user avatar alignment on RTL mode.

#2701

A new inspection was created.

I close this PR because I'm going to make other one with one more change. The change I've made had some side effects. So, I added extra commit to cover.


SSL Connection Issue

I think there's an issue with SSL:
C:/Ruby22-x64/lib/ruby/2.2.0/net/http.rb:923:in `connect': SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B: certificate verify failed (OpenSSL::SSL::SSLError)
        from C:/Ruby22-x64/lib/ruby/2.2.0/net/http.rb:923:in `block in connect'
        from C:/Ruby22-x64/lib/ruby/2.2.0/timeout.rb:73:in `timeout'
        from C:/Ruby22-x64/lib/ruby/2.2.0/net/http.rb:923:in `connect'
        from C:/Ruby22-x64/lib/ruby/2.2.0/net/http.rb:863:in `do_start'
        from C:/Ruby22-x64/lib/ruby/2.2.0/net/http.rb:852:in `start'
        from C:/Ruby22-x64/lib/ruby/2.2.0/open-uri.rb:318:in `open_http'
        from C:/Ruby22-x64/lib/ruby/2.2.0/open-uri.rb:736:in `buffer_open'
        from C:/Ruby22-x64/lib/ruby/2.2.0/open-uri.rb:211:in `block in open_loop'
        from C:/Ruby22-x64/lib/ruby/2.2.0/open-uri.rb:209:in `catch'
        from C:/Ruby22-x64/lib/ruby/2.2.0/open-uri.rb:209:in `open_loop'
        from C:/Ruby22-x64/lib/ruby/2.2.0/open-uri.rb:150:in `open_uri'
        from C:/Ruby22-x64/lib/ruby/2.2.0/open-uri.rb:716:in `open'
        from C:/Ruby22-x64/lib/ruby/2.2.0/open-uri.rb:34:in `open'
        from C:/Ruby22-x64/lib/ruby/gems/2.2.0/gems/rails_real_favicon-0.0.6/lib/generators/favicon_generator.rb:66:in `block in download_file'
        from C:/Ruby22-x64/lib/ruby/gems/2.2.0/gems/rails_real_favicon-0.0.6/lib/generators/favicon_generator.rb:65:in `open'
        from C:/Ruby22-x64/lib/ruby/gems/2.2.0/gems/rails_real_favicon-0.0.6/lib/generators/favicon_generator.rb:65:in `download_file'
        from C:/Ruby22-x64/lib/ruby/gems/2.2.0/gems/rails_real_favicon-0.0.6/lib/generators/favicon_generator.rb:55:in `download_package'
        from C:/Ruby22-x64/lib/ruby/gems/2.2.0/gems/rails_real_favicon-0.0.6/lib/generators/favicon_generator.rb:34:in `block in generate_favicon'
        from C:/Ruby22-x64/lib/ruby/2.2.0/tmpdir.rb:88:in `mktmpdir'
        from C:/Ruby22-x64/lib/ruby/gems/2.2.0/gems/rails_real_favicon-0.0.6/lib/generators/favicon_generator.rb:33:in `generate_favicon'
        from C:/Ruby22-x64/lib/ruby/gems/2.2.0/gems/thor-0.19.4/lib/thor/command.rb:27:in `run'
        from C:/Ruby22-x64/lib/ruby/gems/2.2.0/gems/thor-0.19.4/lib/thor/invocation.rb:126:in `invoke_command'
        from C:/Ruby22-x64/lib/ruby/gems/2.2.0/gems/thor-0.19.4/lib/thor/invocation.rb:133:in `

I'm on Windows 10. Ruby and rails should be the latest versions.
(BTW thanks so much for this awesome project for free!)

I can't reproduce the issue (Ruby 2.2.4 on Ubuntu).
The certificate used by RealFaviconGenerator is a regular certificate issued by RapidSSL and valid for 3 more months. It should work just fine.
Could you look for general guidance regarding certificate authentication failure with Ruby? As an alternative,  you can temporarily hack https://github.com/RealFaviconGenerator/rails_real_favicon/blob/master/lib/generators/favicon_generator.rb#L26 and replace the URL with a site you know must succeed (eg. Google, Amazon...). Do you still have the SSL error?

It would be nice if we could pass -v to get more details on the command line. I'll look into it a little more.

I couldn't find a more "official" way to update openssl certs. Here's how I made it work:
https://gist.github.com/fnichol/867550

Ah! Great! Thank you for the feedback. I think I encountered this issue years ago on a totally different project.


Merge swift 2.0 to master

I think it would good to cut an official release for swift 2.0 as it's now officially released.
Thanks!

Sorry, what do you mean? I'd released Swift 2.0 support version and merged swift-2.0 branch to master already.

@kishikawakatsumi I missed this! Sorry :beers:


Is the project dead?

No activity for 4 months

Yes it is, confirm on the discord

As much as I would like to work in PCR I haven't had time. Maybe I'll get around to more maintenance later but I can't commit to any timeframes atm.


Figure out strategy for /events

We use meetup.com to organize brigade events, but would also like to have event pages on codeforsanfrancisco.org. Consider strategies for synchronizing the event information (either from or to meetup.com) with the site.
Some considerations:

Each hack night will have an agenda document
Some events will have their own picture
Jekyll event metadata is structured

I've created a sample event for use as reference.

Added documentation in 8c1c51f


Add  Central Arizona College

Institution/School Name
Central Arizona College
Instiution/School Website
https://centralaz.edu
Email Users
stu.txt
<EMAIL_ADDRESS>[X]Students
Academic/Teaching Staff
Other/Support Staff
Alumni
Education Levels
Please place an x between the square brackets if yes
Post-graduate research
Graduate School
College (University) or Undergraduate School or equivalent
Community College or equivalent
[X] High School or equivalent
Elementary School or equivalent

@Manz19 I am sorry, I have to close the request without merging, because you made a mistake in a request and requested to merge too many files, most of them do not relate to the organization which you would like to add to this repository. Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


AutoScaler Profile Change

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[x] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

@NullMDR how do we suppress the lint warnings? An example of a valid autoScalerProfile
autoScalerProfile: {
"scan-interval": "20s",
"param-num-2": "45m",
}

The valid keys aren't camel-cased.

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk


eth_getLog() returns null instead of list if there are no transactions

example:
curl -XPOST 'https://testnet.evm.nodes.onflow.org' -H "Content-Type: application/json" -d '{"jsonrpc":"2.0","id":1318572,"method":"eth_getLogs","params":[{"blockHash":"0x4967b45f073cb74e750536d41fdb70ae3923d8a151abdbef25e4fd77d27fe253","address": ["0x0000000071727de22e5e9d8baf0edac6f37da032"],"topics": ["0x2da466a7b24304f47e87fa2e1e5a81b9831ce54fec19055ce277ca2f39ba42c4","0x49628fd1471006c1482da88028e9ce4dbb080b815c9b0344d39e5a8e6ec1419f","0xd1c19fbcd4551a5edfb66d43d2e337c04837afda3482b42bdf569a8fccdae5fb"]}]}' | jq
return:
{
  "jsonrpc": "2.0",
  "id": 1318572,
  "result": null
}

Problem
should return empty list instead of null

Completed by https://github.com/onflow/flow-evm-gateway/pull/697


Add support for KVC for RealmSwift's DynamicObject

IIRC, this is also an issue on dynamic RLMObjects in Objective-C?

Actually, I believe the issue is that the dynamically created accessor class will descend from RLMObject  rather than RealmSwift.Obejct


Uploading big .exe files failes

Hello,
I am happy using Filegator for a while now but I got the following issue where uploading bigger .exe files (±150Mb) fail.
The uploading of the data chunks succeed (chunksize is set to default (1Mb)) but merging the multipart files takes forever and stops around 30Mb.
When uploading an MP4 file (200Mb) the merging of the multipart files is swift and takes around 2 second.
Have you ever experienced the issue?
The website is running on IIS.
Best regards
Petje1972

Hi,
I'm not using windows so I cannot try or confirm this. However, from your description above, I can only assume that some other process is involved here, maybe an antivirus or something similar which detects the executable and try to parse it. I suggest opening your task manager and looking at the cpu/memory consumption of the processes at the time of the actual merge.
Cheers

Thanks 4 the quick response.
I am going to check this out.
Keep up the good work!
Grtz P


Changes default cassandra load balancing policy to dc-aware round-robin

Before, the default cassandra load balancing policy was to consider all
datacenters local. This could lead to high latency when storing or
receiving spans. This changes the default policy to be datacenter aware.
The impact is that the first host's datacenter will be chosen as the
local one, and any hosts that aren't in that datacenter will be ignored.
As before, the local datacenter can be pinned via CASSANDRA_LOCAL_DC.

For those listening at home.. the following log from the datastax driver says which datacenter won
17:17:01.645 [main] INFO  c.d.d.c.p.DCAwareRoundRobinPolicy - Using data-center name 'datacenter1' for DCAwareRoundRobinPolicy (if this is incorrect, please provide the correct datacenter name with DCAwareRoundRobinPolicy constructor)

pinging cassandra peeps @michaelsembwever @kristofa @danchia @yurishkuro @prat0318 @eirslett

Or even @openzipkin/cassandra

lgtm

lgtm. we didn't have any pinned local dc till now, so half of our inserts would be going to remote dc. this change should improve the query perf.

Thanks for the review, folks!

:+1:


Spaces seem to delimit command line arguments

I have a simple C++ program
#include <stdio.h>

int main(int argc, char **argv)
{
    printf("argc: %i\n", argc);
    for (int i = 0; i < argc; ++i)
    {
        printf("argv[%i]: %s\n", i, argv[i]);
    }
    return 0;
}

which I compile as cl /nologo /Zi main.cpp
When I run it:
E:\>main.exe -a something_here -b  "something here with spaces"
argc: 5
argv[0]: main.exe
argv[1]: -a
argv[2]: something_here
argv[3]: -b
argv[4]: something here with spaces

While in raddebugger

Fixed in 1ade5e44fac4272f7f9a3e0a9bd4714f021b0964. I've also fixed the debugger's lack of support for serializing double quotes in target arguments (and other places) in 3fd9014c20461c1e7fa4aec6f7aab93117c27b65.


Live reload resets app to original state on ionic serve, emulate, or run

Ionic version:  (check one with "x")
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[x] 3.x
[ ] 4.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
Current behavior:
When running ionic serve --cs or ionic cordova run android --livereload and a change is made the app is reset to the initial page.
Expected behavior:
Ionic v1 applies update without resetting the app. This should also happen on these versions, as this has a huge impact on development time.
Steps to reproduce:
Just follow instructions under "current behavior"
Ionic info:
cli packages: (/Users/philipbennison/code/stroll/stroll-mobile/node_modules)

    @ionic/cli-utils  : 1.18.0
    ionic (Ionic CLI) : 3.18.0

global packages:

    cordova (Cordova CLI) : 7.1.0

local packages:

    @ionic/app-scripts : 3.0.0
    Cordova Platforms  : android 6.3.0 ios 4.5.3
    Ionic Framework    : ionic-angular 3.7.1

System:

    ios-deploy : 1.9.2
    ios-sim    : 6.1.2
    Node       : v7.8.0
    npm        : 5.5.1
    OS         : macOS Sierra
    Xcode      : Xcode 9.0.1 Build version 9A1004

Environment Variables:

    ANDROID_HOME : not set

Misc:

    backend : legacy

Hello! Thank you for opening an issue with us!
It depends on your navigation strategy. With Ionic v3 there are basically three:

default - creates a nav stack manipulated via push/pop, but does not change the URL
deep-linking - still have a nav stack with push and pop but URLs are generated based on the deep-link configuration
lazy-load - similar to deep link, but each @IonicPage() is in its own module and (most importantly) gets its own bundle, so everything is not in a single bundle like with the other two strategies. Really this is a form of deep-link, so it has URLs as well.

So, with deep-linking and lazy-load, whatever URL you are on reloads and you thus stay on the same page.
With default, you are always at the "root" URL, so the app essentially starts at root with a reload.
Ionic v1 used the UI-State router making it most analogous to the current deep-linking strategy, so it would also just reload whatever the current URL was.
If you need to have the "stay on the same page" reloading, I suggest modifying your application to use either deep-linking or lazy-loading if possible.
I will close this issue for now. If you are using deep-linking or lazy loading and still having this issue, please provide a sample application via GitHub demonstrating the issue so we can use for debugging and testing. In that case, though, note that this will likely not be addressed until after v4 has shipped due to heaving modifications that are occurring in the nav area.
Hopefully that all made sense. Let me know if you have any questions.
Thank you for using Ionic

@kensodemann I'm using Ionic v3 in a while and my application always reload completely with livereload when I save some file (excluding scss files), even though I use the lazy-loading strategy with @IonicPage() using a module for each page and then importing this page module inside app.module.ts, is there anything extra to do?

@fzamperin - do you have a sample application you can share? Also, can you clarify exactly what you mean and what you are looking for? Your app should reload completely, but it should do so using whichever URL you are on, which means you should be on the page for that URL. Any specific info you could provide would be helpful.

@kensodemann do you have an email where I can send you the code?
I'm having the same issue as @fzamperin
It's making development almost impossible.
It happens the same when using ionic serve
It's using Angular 6 & Ionic 3

@NicksonYap - it would be best if you either provide your code on GitHub (or some other cloud based public repo site) or create a sample application that demonstrates the same behavior and share that via a GitHub repo.

@kensodemann
Here's the Starter I used, that has the issue
ionic.zip

@NicksonYap - this is working the way I would expect things to work with an Ionic v3 app. Can you explain what behavior you are looking for?

@kensodemann
Yes, that's the issue where it always resets to home.
Actually in app.component.ts, rootPage was set to HomePage
so if the whole app is hard reloaded, it would surely go to HomePage.
Everytime livereload is triggered, the webview flashes white for an instant, plus console logs will always print "Angular is running in the development mode. Call enableProdMode()..."
It shows that livereload refreshs the whole page, instead of reloading the page/component itself.
I was expecting the page/component to reload only when editing the component's script and html
Is this normal?
Well at least when editing scss, the page stays there


Failed to disable 'x-powered-by' header in firebase hosting and cloud functions

I am having some problem in disabling the 'x-powered-by' header. The following code should be able to disable the header, but I still see the header in the response.

Express version: 4.16.4

import * as functions from 'firebase-functions';

import * as express from 'express';
import * as rateLimit from 'express-rate-limit';

const xssFilter = require('x-xss-protection');

import * as sendgrid from '@sendgrid/mail';

const APP = express();
const API_CONTACT_FORM_LIMITER = new rateLimit({ windowMs: 60 * 1000, max: 50});

APP.disable('x-powered-by'); // <== This should disable the header

APP.use(xssFilter());
APP.use('/api/test', API_CONTACT_FORM_LIMITER);

sendgrid.setApiKey(functions.config().sendgrid.key);

APP.post("/api/test", async (request, response) => {
  response.send('Hi');
});

export const api = functions.https.onRequest(APP);

But I got the following when sent a POST request:

> firebase serve
> curl -i -X POST http://localhost:5000/api/test

HTTP/1.1 200 OK
x-powered-by: Express // <== This should not be here
cache-control: no-cache, no-store, must-revalidate
pragma: no-cache
expires: 0
x-xss-protection: 1; mode=block
x-ratelimit-limit: 50
x-ratelimit-remaining: 49
date: Sat, 06 Apr 2019 08:05:01 GMT
x-ratelimit-reset:<PHONE_NUMBER>
content-type: text/html; charset=utf-8
content-length: 2
etag: W/"1-VP0XESCfscB4EJI3QTLGbnniJBs"
connection: close
vary: Accept-Encoding, Authorization, Cookie

Hi

Was there any problem in my code? And how could I solve this?
I have read issue#2790, but it does not solve my problem.
Thanks a lot.

So i removed the Firebase parts from your code so I could run it and the header is successfully disabled. Can you check the following?

Change something in your code like the Hi and deploy it and check that you see the new response to make sure it is not just stale code.
Change your code to just functions.https.onRequest((req, res) => res.end("test")) to see if that header is there or not without Express.

I have tried to change my code and the header still here, I think it is not the problem with stale code.....
And I have tried changing my code to
export const api = functions.https.onRequest((req, res) => res.send('hi')); as you mentioned, but I still got the following:

HTTP/1.1 200 OK
x-powered-by: Express // <== It is still here
cache-control: no-cache, no-store, must-revalidate
pragma: no-cache
expires: 0
content-type: text/html; charset=utf-8
content-length: 2
etag: W/"2-witfkXg0JglCjW9RssWvTAveakI"
date: Sun, 07 Apr 2019 01:38:33 GMT
connection: close
vary: Accept-Encoding, Authorization, Cookie

hi

Full code:

import * as functions from 'firebase-functions';

import * as express from 'express';
import * as rateLimit from 'express-rate-limit';

const xssFilter = require('x-xss-protection');

import * as sendgrid from '@sendgrid/mail';

const APP = express();
const API_CONTACT_FORM_LIMITER = new rateLimit({ windowMs: 60 * 1000, max: 2});

APP.disable('x-powered-by');

APP.use(xssFilter());
APP.use('/api/sendcontactform', API_CONTACT_FORM_LIMITER);

sendgrid.setApiKey(functions.config().sendgrid.key);

export const api = functions.https.onRequest((req, res) => res.send('hi'));

Thanks.

So if you tried code without loading express and the x-powered-by header is there, then it cannot possibly be this module adding it, right? How if the header there when you don't use express in your code?

You need to contact Firebase support or open a pull request to this module with a fix.

Ok, thanks for your help.

It seems that Firebase is adding that header, as that would be the only explanation for why it would show up when you didn't use Express. Which would also be why disabling it here has no effect.
I searched Google and it seems that people are saying the same conclusion as well: that Firebase itself adds that header.

Okay, I will try to contact Firebase see if they can help. Anyway, thanks a lot.

@Kynson Have you found a solution to remove the header?

@rfgamaral Unfortunately, I cannot find any. The header seems to be added by Firebase on the server, and no way to remove it.


Implement local file system

close https://github.com/apache/skywalking/issues/10839

[x] Update the CHANGES log.

Codecov Report

Merging #341 (1d3dec3) into main (2cf42aa) will decrease coverage by 1.46%.
Report is 2 commits behind head on main.
The diff coverage is 20.77%.

@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
- Coverage   39.87%   38.42%   -1.46%
==========================================
  Files         111      114       +3
  Lines       11938    12595     +657
==========================================
+ Hits         4760     4839      +79
- Misses       6709     7280     +571
- Partials      469      476       +7

Files
Coverage Δ

banyand/tsdb/shard.go
57.07% <100.00%> (+0.66%)
:arrow_up:

banyand/tsdb/tsdb.go
53.93% <100.00%> (+0.56%)
:arrow_up:

pkg/fs/error.go
0.00% <0.00%> (ø)

banyand/tsdb/block.go
50.91% <50.00%> (-0.21%)
:arrow_down:

banyand/kv/kv.go
0.00% <0.00%> (ø)

banyand/kv/badger.go
8.90% <65.38%> (ø)

banyand/stream/tstable.go
0.00% <0.00%> (ø)

banyand/measure/tstable.go
0.00% <0.00%> (ø)

banyand/tsdb/buffer.go
68.99% <67.77%> (+0.42%)
:arrow_up:

pkg/fs/local_file_system.go
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Using %all% as file name is usually too long for Windows, how do I fix it?

When I download a pic, and I set %all% %md5%.%ext% as file name, it often gets cut off. Windows probably has a file name limit, how do I bypass it?

There's no way around it.
Windows has filename limits, so unless you use another file system you won't be able to have filenames longer than 260 or 255 characters.
More details: https://msdn.microsoft.com/en-us/library/aa365247.aspx

I see, that's too bad. Why does this feature exist if it doesn't really work, though?

The feature works on other filesystems. Also, you can still store these tags in a database or an external text file.
The software provides the information, it's up to the user to see how he wants to present/use it.


CodeQL is failing

i broke codeql via setup_clang.sh yesterday
we landed a fix today but it seems not to have resolved

this seems to be fixed now


Checking responseError

Handling the exception like below
pdblp.pdblp:INFO:Event Type: 'PARTIAL_RESPONSE'
pdblp.pdblp:INFO:Message Received:
ReferenceDataResponse = {
    responseError = {
        source = "bbdbd2"
        code = -4001
        category = "LIMIT"
        message = "uuid: xxxxxxx, SN: xxxxx, sid: xxxxx Daily capacity reached. [nid:xxxx] "
        subcategory = "DAILY_CAPACITY_REACHED"
    }
}

For pull requests please include the following:

[ ] closes #74
[ ] tests added / passed
[ ] passes git diff upstream/master -u -- "*.py" | flake8 --diff
[ ] whatsnew entry

Notes:
To run the git diff on the upstream/master branch make sure this is set
up, e.g.
git remote add upstream git@github.com:matthewgilbert/pdblp.git
git fetch upstream

See here
for more details.
Unfortunately automated testing using TravisCI is not possible since many tests
require a valid Bloomberg connection. Please verify that
pytest pdblp/tests -v has been run and all tests are passing.
Commit
For most simple feature implementations please squash your commit to one entry
and follow the style of https://chris.beams.io/posts/git-commit/ in your
commit message, i.e.

Separate subject from body with a blank line
Limit the subject line to 50 characters
Capitalize the subject line
Do not end the subject line with a period
Use the imperative mood in the subject line
Wrap the body at 72 characters
Use the body to explain what and why vs. how

@matthewgilbert  I just started writing Python code in a few days and also new to Github workflow and I am not sure what is wrong with the Travis CI build failure. Can you quickly glance the error and see if there is anything I need to do?

@matthewgilbert It seems like Python 3.7 archive is not found according to the log. Can you see if you can fix it?
Downloading archive: https://storage.googleapis.com/travis-ci-language-archives/python/binaries/ubuntu/14.04/x86_64/python-3.7.tar.bz2
travis_time:start:13f0cc32
$ curl -sSf --retry 5 -o python-3.7.tar.bz2 ${archive_url}
curl: (22) The requested URL returned error: 404 Not Found
travis_time:end:13f0cc32:start=1575224763792916890,finish=1575224763840117564,duration=47200674,event=configure
Unable to download 3.7 archive. The archive may not exist. Please consider a different version.

Another CI pipeline fails with the error below which I believe the master branch was failing already. This https://github.com/pytest-dev/pytest/issues/1688 seems to be related??
==================================== ERRORS ====================================
__________________ ERROR collecting pdblp/tests/test_pdblp.py __________________
pdblp/tests/test_pdblp.py:88: in
    ifbbg = pytest.mark.skipif(pytest.config.cache.get('offline', False),
E   AttributeError: module 'pytest' has no attribute 'config'
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
=============================== 1 error in 0.16s ===============================
travis_time:end:0630fa56:start=1575224805702769490,finish=1575224807512339826,duration=1809570336,event=script
The command "pytest pdblp/tests -v --offline" exited with 2.


[ST-Engine][Design] Resource Manager design from seatunnel engine

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
Purpose Of Design

It can provide the resource address required for the execute of the Job
Ability to dynamically scale nodes in third-party resource management services
Each Worker can support running multiple tasks of different Jobs to make full use of resources
Worker can recover in time if abnormality occurs

Resource Definition
Unit resources
public class Worker {
    private Slot[] slots;
}

public class Slot {
    private Resource resource;
}

Unit resource definition
The number of resources each unit slot should have
public class Resource {
    private Memory memorySize;
    // only work on kubernetes
    private CPU cpu;
}

SeaTunnel supports normal worker memory allocation, and if running on Kubernetes, it can also support allocation for the CPU running the worker.
Implementation process
Standalone

The Master and Worker are started, the Worker registers the information to the ResourceManager, and the status is monitored by regular heartbeat.
JobMaster requests resources from ResourceManager
If the resources are sufficient, the corresponding Worker information will be provided to the JobMaster. If not enough, the JobMaster will not have enough resources.
After the JobMaster receives the feedback, it determines whether to start scheduling the task or throw an exception

Third Party Resource Manager

The Master and Worker are started, the Worker registers the information to the ResourceManager, and the status is monitored by regular heartbeat.
JobMaster requests resources from ResourceManager
If the resources are sufficient, provide the corresponding Worker information to the JobMaster, if not, apply for resources from the third-party resource management and start the Worker.
Worker registers with ResourceManager
After the JobMaster receives the feedback, it determines whether to start scheduling the task or throw an exception
Return resources to ResourceManager after JobMaster execution ends
According to the policy, the ResourceManager determines whether the worker needs to be released and then returned to the third-party resource management system or reserved for the next task.

The specific process is as follows:

Worker's slot allocation
Each Worker needs to allocate its resources to different Slots for the Job to run and use. How to split the Worker into different Slots?
There are two allocation strategies:

When the Worker starts, the average distribution is completed according to the configuration information
Dynamic allocation. When a task applies for resources, the corresponding slot is dynamically created. The size of the slot is determined according to the number of resources required by the task. This can maximize the use of resources and improve the success rate of scheduling large-resource tasks.

Usage Scenario
No response
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

If you have better designs or suggestions, please leave a message

In my view, I perfer call Slot as Grid

Dynamic allocation. When a task applies for resources, the corresponding slot is dynamically created. The size of the slot is determined according to the number of resources required by the task. This can maximize the use of resources and improve the success rate of scheduling large-resource tasks.

Yes, I think Dynamic allocation is better. Our TaskExecutionService can run task in shared thread, So I think the TaskExecutionService can run more tasks if every task only have a small dataset.

How do we achieve memory isolation?

How do we achieve memory isolation?

There is no real isolation, only logical occupation. In fact, other tasks on the same worker can exceed his memory limit. This is for the fact that we only use heap memory at present. If we use out-of-heap memory in the future, we can complete isolation in the true sense.

How do we achieve requested resource are locked,  or release after a task running crash

How do we achieve requested resource are locked, or release after a task running crash

Locked by Resource Manager, Release by JobMaster and tell Resource Manager

public class Resource {
private Memory memorySize;
// only work on kubernetes
private CPU cpu;
}

Does standalone use this Resource too? If I want run 500 task in a node(this is possible because of shared threads), How do we define the number of slots supported by a node？And, how many CPU and memorySize a slot use?

public class Resource {
private Memory memorySize;
// only work on kubernetes
private CPU cpu;
}

Does standalone use this Resource too? If I want run 500 task in a node(this is possible because of shared threads), How do we define the number of slots supported by a node？And, how many CPU and memorySize a slot use?

First, standalone yes. The number of our slots is configurable, such as 1024M of memory, 1024 slots can be declared (if you want to). It means that you can run 1024 tasks at the same time, and each slot has 1M memory resources (declarative, not occupied. Later, consider implementing occupied resource application in off-heap memory). By the way, we can share one slot with multi-task in the future.


[BUG] Inconsistent Display of Delegated Voting Power on 'Abstain' or 'No Confidence' Votes"

Context & versions

When I, as a registered DRep with delegated voting power, attempt to delegate my own vote to "Abstain" or "No Confidence," the card initially displays voting power after the transaction. However, within a few seconds, the delegated power value changes.

Steps to reproduce

Register as a direct voter.
Delegate your vote to "Abstain" or "No Confidence."
Observe the card displaying the message: "You have delegated A123 to 'Abstain'"

Actual behaviour

The card consistently displays the delegated voting power after the transaction, reflecting the intended selection.

After a few seconds, the voting power is modified, and the preview reflects the intended selection.

There is such update @MSzalowski @Sworzen1. Looks like the voting power is more update after this change.

It might be cause by the recalculation of the voting power on the chain. On frontend we display that value directly from the backend (without any parsing on the FE side). And that value on the backend is taken directly from DB-sync.
That might not be the issue that we on the govtool side are able to handle, but please @jankun4 could you have a look if there is some part missing?

The delegated amount is strictly related to the amount of Ada at the user's wallet. Each transaction (including delegating to Abstain) requires paying transaction fee which in turn lowers user's ada-holder voting power a bit.

@MSzalowski  any update on this ?

As I previously and @jankun4 in a recent comment describe  - the voting power is calculated directly by db-sync and we don't have any logic around this.
The difference between these values is because of fee (as @jankun4 described) and the reason why it is not displayed right after the transaction is that at this moment the value isn't calculated.
I think that we could close this issue as GovTool has nothing to do around this topic.
What do you think @kneerose ?

@kneerose and I just had a discussion about this issue. Because of the occasional mismatch in voting power, the tests has become flaky for us. We can understand the reasoning that this value is coming from DbSync. But from the user perspective, this difference could be confusing, and should be addressed. (Maybe an update the copy that the value shown could be slightly different).
We can close the issue here as issue caused by the dependency, however, we recommend that this should be fixed, be it in the DbSync. We can wait until the next release of DbSync and retest it again. If the issue exists, then I think we should create an issue on DbSync repo so devs there can debug and fix the issue.

I believe this issue is because;

GovTool is showing the incorrect delegation value before the transaction is finalised on-chain
So when DBSync updates the voting power based on latest transaction then the voting power is updated
this is causing flakiness in tests

This is a tricky one, because at any time a wallet's voting power may change
The user may send or receive ada at any time (regardless of GovTool)
So I feel it would be the right thing to extra logic to Govtool to preempt the cost of transaction fees
@kneerose can you point me to the test case that this is effecting please
for me, it might make more sense to change the testcase rather than anything else

So I feel it would be the right thing to extra logic to Govtool to preempt the cost of transaction fees

Can we expect a scenario in which the value calculated by GovTool will differ from the final value anyway? Even if we know all the values needed for such a calculation, can we guarantee that these values will not vary?
@Ryun1 I wouldn't go for the solution where some of the voting powers (or some other ADA values) are taken from db-sync (calculated there) and some others are calculated by GovTool at least, not as a solution for flaky tests. We should have single source of truth that emits events if values changes

oops! I wrote the opposite of what I meant
So I feel it would NOT be the right thing to extra logic to Govtool to preempt the cost of transaction fees

@MSzalowski @Ryun1 Do we have an understanding of whats needed here?

@kneerose @MSzalowski @Ryun1 Can we close this one?


implement dial and stream opening timeouts

Currently, the dial future (and soon the stream opening future) never timeout, so they can potentially take forever if the remote side never sends a corresponding response.
We should implement some timeout (5s?) that will cause the future to resolve in an error if the response isn't received by then.

after #13 is merged, this includes clearing out pending stream data after the timeout.


add tests for hashmap and linkedlist

In all my enthousiasm, started writing tests for linkedlist as well. Technically not on the correct branch, but they run, so no harm done when merging.
refers: #5

Pull Request Test Coverage Report for Build 21

6 of 14 (42.86%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+21.7%) to 27.626%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/be/wyckd/datastructures/LinkedList.java
6
14
42.86%

Files with Coverage Reduction
New Missed Lines
%

src/main/java/be/wyckd/datastructures/LinkedList.java
1
49.38%

Totals

Change from base Build 19:
21.7%

Covered Lines:
71

Relevant Lines:
257

💛  - Coveralls


Create AutoDiffCostFunction in cost functions.

Creating a ceres::AutoDiffCostFunction requires specifying numbers
of residuals and variables, so it is safer to implement this within
the cost functions, which know best.

@cschuet PTAL at the late commit f68cd854d9e8147f6108c718b7594b14c1202a5c


Fix typos discovered by codespell

% codespell --ignore-words-list=crate,fo,ser --write-changes

https://github.com/codespell-project/codespell/blob/master/README.rst

Very nice!

It is unfortunate to put the misspelling in the commit message like:

Fix typo: argumant -> argument (#1257 by kianmeng)

Fix readme typo: interpetation -> interpretation (#578 by [Plommonsorbet]
Fix typo: chracter -> character (#561)

because then it is difficult to find that misspelling again with automated tools.

Yah, agreed. Definitely my fault, I usually write the commit messages. And we can't really run codespell as an action on the commit messages, since I usually write them from the interface on github.com in the squash-and-merge button.


confint

Codecov Report

Merging #4 (6f75ce4) into main (8cb9754) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   99.45%   99.52%   +0.07%
==========================================
  Files           3        3
  Lines         182      210      +28
==========================================
+ Hits          181      209      +28
  Misses          1        1

Files Changed
Coverage Δ

ext/BoxCoxMakieExt.jl
98.70% <100.00%> (+0.12%)
:arrow_up:

src/BoxCox.jl
100.00% <100.00%> (ø)


Remove version: Aserto.Topaz version 0.32.27

installers return following HTTP status code: 404
Microsoft Reviewers: Open in CodeFlow

/azp run

[Policy] Needs-Manual-Merge

URL: https://github.com/aserto-dev/topaz/releases/download/v0.32.27/topaz_windows_x86_64.zip
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 923)

Hi @gertd,
Do you approve of these changes?
(Automated response - build 897.)


[ddc] Generator functions element type soundness issue

This is the DDC specific issue for #54159, which has the details.

FYI - a new API was added to the CFE to make this easy to implement on the backends. See for example https://dart-review.googlesource.com/c/sdk/+/341397


ProgressRing Masks Not Working (On-Device Only)

As reported by a user of my ProgressRing plugin, the masking does not appear to be working on-device using modern "offline build" versions of Solar2D (tested on both iOS and Android, same results). The result is that what should be a circular progressRing object appears rectangular with the outer masking not present when run on an actual device.
Notably, this is not happening in the simulator, nor on device when built using the last "CoronaLabs" version of the simulator (2020.3583), so it appears to be some sort of regression related to masks in recent builds.
See this screenshot of the Solar2D simulator (left) and iOS Simulator (right) running the same project for a visual example of how this looks: https://ibb.co/D9Q3XwF
To test this yourself, simply build the plugin sample project, accessible here: https://schroederapps.github.io/progress_ring_sample.zip

I have modified the code a bit.
progressRingTest.zip


[Feature] Logic validation for multiple suits

More Info
Currently, only one suit is supported, logic-wise. When starting a new game, there is the option to start with 1, 2, or 4 suits, but playing with 2 or 4 acts exactly like a 1 suit game (a completed set using a variety of suits can be pulled out, which cases issue when undo-ing).
Proposed Implementation

[x] In GameViewModel's validateIndex(forColumn:), add logic to check for a change in suit and update the validityIndex based on that.
[ ] In GameViewModel's `checkForCompletedSet(forColumn:), add logic to check for a change in suit and deny completion when suits do not match.

[ ] Add GameEngine class which handles the rules of the game, separating that logic from the GameViewModel
[ ] Follow same steps in implementation 1

Fixed with #5


vimPlugins: Add --proc flag to update script.

This is based on discussion in #83008 and replaces it.

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

After reading #83008 it looks like what we really need is rate-limiting (maybe that is also the reason why I had to implement the exponential backoff in the first place). But this can already help, so I think we can merge this now.
Better to wait for ofBorg though. I'm not sure what the current issue is (seems like master is broken). Ping me again tomorrow if I haven't merged by then.

Also I want to say that I think the contribution, code and git commits are of very high quality, which might get lost in my nitpickyness here.

^ That comment was meant for #83788. It also applies here, but the change is of course much smaller.

@GrahamcOfBorg eval


rowClassName is overridden by default style.

Describe the bug
rowClassName is overridden by default style.
To Reproduce
Create a DataTable.
create a useStyles hook with createStyles from @mantine/core and use it in your DataTable component. Add a field called row with a backgroundColor of red or something.
add rowClassName={classes.row}
Expected behavior
Rows should now be red.
However, the default background-color has a higher specificity.
Can add !important to resolve, but it should not be necessary. Following the same patterns that Mantine docs describes for custom components and styles would resolve these sort of issues.

Actually, this is a common problem with emotion-based UI frameworks.
In this case, the default style is overriding yours because it's applied with a selector like .mantine-1cbzqls tr, which is more specific than your class name (due to the ending tr).
Instead of using !important, you could increase your class specificity by defining it like so:
const useStyles = createStyles({
  row: { '&&': { backgroundColor: 'red' } },
});

This will override the default Mantine style.
See this on StackOverflow for more information: https://stackoverflow.com/questions/62660480/is-there-a-way-to-increase-specificity-by-adding-the-element-with-emotion

I get the same problem. I want to change background color on hover. And i have only one decision which i finded:
const useStyles = createStyles((theme) => ({
    blueishRow: {
        '&:hover': {
            backgroundColor: theme.colorScheme === 'dark' ? theme.colors.blue[9] + "!important" : theme.colors.blue[2] + "!important",
        },
    },
}))

Maybe i can do it better?


No polyfill has been done

Doesn't this library use Babel for polyfill? Then operators like?./??/... will report errors when running in a low-version browser environment, unless a Lodash is recompiled in the host environment.

That's not a polyfill, it's called syntax downpiling.
Libraries aren't responsible for such a thing, unless you're talking about a CDN build. Generally though, I would discourage using CDN builds, especially for a library like Radash, where you only use a small portion of what exists. Read this post for more reasons.


Fix/delete enrollments on order cancellation

Purpose
As enrollments have unique constraint per user and course run, we have to delete
enrollments on an order cancellation to allow a user to enroll once again to a
course run from a new order.
Proposal

[x] Delete enrollments on order cancellation
[x] Improve order admin actions

Have you thought of relaxing the constraint to include the order ID in the key?

Have you thought of relaxing the constraint to include the order ID in the key?

Yes, I first replace the unique_together by a couple of UniqueConstraints :

[user, course_run] if order__isnull=True
[user, course_run, order] if order__isnull=False

But I found this workaround more complicated and it could lead to weird cases I think.

On second thought, I think we should have only one enrollment per user/course run BUT the order should look for an existing one and link to it... the state of the course run can oscillate from active to inactive like in OpenEdX and several orders can be linked to it... WDYT?

Closed and replaced by #94


score2perf; AttributeError: 'module' object has no attribute 'ModalityType'

While running t2t_trainer, got the following error. Tried tensor2tensor version 1.10.0, 1.11.0, 1.12.0 but had the same issue.
Magenta-gpu version 1.0.2
Python version 3.6 (also reproed in 2.7 as well)

Traceback (most recent call last):
File "/data/ai/magenta/magenta/tensor2tensor/t2t_trainer.py", line 38, in
console_entry_point()
File "/data/ai/magenta/magenta/tensor2tensor/t2t_trainer.py", line 34, in console_entry_point
tf.app.run(main)
File "/home/kangmo/.conda/envs/gcp-p27/lib/python2.7/site-packages/tensorflow/python/platform/app.py", line 125, in run
_sys.exit(main(argv))
File "/data/ai/magenta/magenta/tensor2tensor/t2t_trainer.py", line 29, in main
t2t_trainer.main(argv)
File "/home/kangmo/.conda/envs/gcp-p27/lib/python2.7/site-packages/tensor2tensor-1.12.0-py2.7.egg/tensor2tensor/bin/t2t_trainer.py", line 390, in main
exp = exp_fn(create_run_config(hparams), hparams)
File "/home/kangmo/.conda/envs/gcp-p27/lib/python2.7/site-packages/tensor2tensor-1.12.0-py2.7.egg/tensor2tensor/utils/trainer_lib.py", line 806, in experiment_fn
return create_experiment(run_config, hparams, *args, **kwargs)
File "/home/kangmo/.conda/envs/gcp-p27/lib/python2.7/site-packages/tensor2tensor-1.12.0-py2.7.egg/tensor2tensor/utils/trainer_lib.py", line 696, in create_experiment
add_problem_hparams(hparams, problem_name)
File "/home/kangmo/.conda/envs/gcp-p27/lib/python2.7/site-packages/tensor2tensor-1.12.0-py2.7.egg/tensor2tensor/utils/trainer_lib.py", line 817, in add_problem_hparams
p_hparams = problem.get_hparams(hparams)
File "/home/kangmo/.conda/envs/gcp-p27/lib/python2.7/site-packages/tensor2tensor-1.12.0-py2.7.egg/tensor2tensor/data_generators/problem.py", line 499, in get_hparams
ret = self.hparams(hp, model_hparams)
File "/data/ai/magenta/magenta/models/score2perf/score2perf.py", line 165, in hparams
defaults.modality = {'targets': t2t_modalities.ModalityType.SYMBOL}
AttributeError: 'module' object has no attribute 'ModalityType'

Here is my code to repro the issue.

DATA_DIR=pwd/datagen
HPARAMS_SET=transformer_base
MODEL=transformer
PROBLEM=score2perf_maestro_language_uncropped_aug
TRAIN_DIR=pwd/train_dir
HPARAMS=
"label_smoothing=0.0,"
"max_length=0,"
"max_target_seq_length=2048"
python $SCRIPT_HOME/tensor2tensor/t2t_trainer.py
--data_dir="${DATA_DIR}"
--hparams=${HPARAMS}
--hparams_set=${HPARAMS_SET}
--model=${MODEL}
--output_dir=${TRAIN_DIR}
--problem=${PROBLEM}
--train_steps=1000000

Wondering if this commit is causing this issue.
https://github.com/tensorflow/magenta/commit/89f9c29b59bb309af4dbe86328e2788448dc6621

In my environment, reverting the above commit from v1.0.2 fixes the issue.
Not sure if the above commit was the root cause though.

@dustinvtran do you know what's going on here?

Got the same error, I'm gonna try reverting to that commit.

Seems like a dependency issue. Latest T2T release (v.1.12.0) doesn't have ModalityType. @afrozenator

We'll have to do a t2t release soon
On Sat, Feb 16, 2019, 1:25 PM Dustin Tran<EMAIL_ADDRESS>wrote:

Seems like a dependency issue. Latest T2T release (v.1.12.0) doesn't have
ModalityType. @afrozenator https://github.com/afrozenator
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/magenta/issues/1435#issuecomment-464387206,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABFCFj3DunsbKNW5OKj8j0EGOaGvFWxNks5vOHdegaJpZM4au049
.

I'm getting the same error. how did you fix it? how do i revert to a previous commit?

using this command:
DATA_DIR=/Users/xxxxxx/transformer-model/tfrecord/
HPARAMS_SET=transformer_base
MODEL=transformer
PROBLEM=score2perf_maestro_language_uncropped_aug
TRAIN_DIR=/Users/xxxxxx/transformer-model/training/
HPARAMS=
"label_smoothing=0.0,"
"max_length=0,"
"max_target_seq_length=2048"
t2t_trainer
--data_dir="${DATA_DIR}"
--hparams=${HPARAMS}
--hparams_set=${HPARAMS_SET}
--model=${MODEL}
--output_dir=${TRAIN_DIR}
--problem=${PROBLEM}
--train_steps=1000000
i get the following error:
Traceback (most recent call last):
File "/anaconda3/envs/magenta/bin/t2t_trainer", line 10, in
sys.exit(console_entry_point())
File "/anaconda3/envs/magenta/lib/python2.7/site-packages/magenta/tensor2tensor/t2t_trainer.py", line 34, in console_entry_point
tf.app.run(main)
File "/anaconda3/envs/magenta/lib/python2.7/site-packages/tensorflow/python/platform/app.py", line 125, in run
_sys.exit(main(argv))
File "/anaconda3/envs/magenta/lib/python2.7/site-packages/magenta/tensor2tensor/t2t_trainer.py", line 29, in main
t2t_trainer.main(argv)
File "/anaconda3/envs/magenta/lib/python2.7/site-packages/tensor2tensor/bin/t2t_trainer.py", line 390, in main
exp = exp_fn(create_run_config(hparams), hparams)
File "/anaconda3/envs/magenta/lib/python2.7/site-packages/tensor2tensor/utils/trainer_lib.py", line 806, in experiment_fn
return create_experiment(run_config, hparams, *args, **kwargs)
File "/anaconda3/envs/magenta/lib/python2.7/site-packages/tensor2tensor/utils/trainer_lib.py", line 696, in create_experiment
add_problem_hparams(hparams, problem_name)
File "/anaconda3/envs/magenta/lib/python2.7/site-packages/tensor2tensor/utils/trainer_lib.py", line 817, in add_problem_hparams
p_hparams = problem.get_hparams(hparams)
File "/anaconda3/envs/magenta/lib/python2.7/site-packages/tensor2tensor/data_generators/problem.py", line 499, in get_hparams
ret = self.hparams(hp, model_hparams)
File "/anaconda3/envs/magenta/lib/python2.7/site-packages/magenta/models/score2perf/score2perf.py", line 162, in hparams
defaults.modality = {'targets': t2t_modalities.ModalityType.SYMBOL}
AttributeError: 'module' object has no attribute 'ModalityType'

Clicked on the commit link that Kangmo posted and then I manually deleted the code in red and pasted the code in green in it's place and then saved the file. Now I don't get that error anymore.

oh weird, I had to do the opposite -> replace the "green" with the "red" and now it's training. i must have an old version in my environment?

Yeah, my bad. It's the opposite way.


Please share the link to download spark-thrift-server-4.8.0-SNAPSHOT-spark-job.jar

Please share the link to download spark-thrift-server-4.8.0-SNAPSHOT-spark-job.jar To Run Spark Application

See this issue closed: https://github.com/cloudcheflabs/dataroaster/issues/40


Replaced get_token_info calls with the request.auth.application

Fixes

Fixes #3514 by @sarayourfriend
Description

Incomplete PR, since during test_throttle we will need to reinitialize the authed_request fixture with the updated token each time.
Since earlier that was not needed as the saved access token used to be fetched from the database at every get_cache_key call with the get_token_info. So the test cases only needed to reinitialize the access_token fixture before.
I am unfamiliar with pytest and Django testing so a little help would be appreciated regarding how to go about reinitializing the authed_request fixture or drop the use of fixture to simulate the mock request and instead use something else maybe @sarayourfriend thoughts?
Testing Instructions

Checklist

[x] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[ ] My commit messages follow best practices.
[ ] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Let's wait for #3505 to get merged, then we can rebase this PR and see what else is left with the tests. That other PR has a nice fix for some of what might be causing issues in this one.

@sarayourfriend any updates after the PR merge?

@kb-0311 I'm on holiday at the moment but just popping in so you don't think you're getting ignored! Please rebase the PR and then ping @WordPress/openverse-api for review :slightly_smiling_face:

@kb-0311 Just a heads up, I am rebasing this PR now and will push changes to the branch soon.

@kb-0311 I've pushed the changes.
@stacimc @dhruvkb can one of y'all take a look?

@sarayourfriend Yes, Thanks a lot for your help :)

Drafting until feedback can be addressed - @kb-0311 let us know if you would like any further pointers or assistance on this 🙂

@kb-0311 Would you be able to resume this work soon? We would appreciate it if you let us know in any case.

@krysal I am so sorry but I currently have my exams so won't be able to complete this PR till next week.
By that time I think if anyone is interested they can push commits in this branch itself for the problem.

I've taken the liberty to go ahead and push a final version of this PR, with all required changes. I did so in a single commit, rebased on the current main, rather than updating the existing commits, because the conflicts were too pesky in each commit of the original branch to resolve.
I'm opening this back up for review and pinging @stacimc and @dhruvkb to request reviews on this PR, so we can finally get it merged.

I fixed an issue with the logic for detecting is_anonymous (it was just inverted). I'm looking into the remaining test failure in the search controller; the authentication is determined correctly when I test manually 👀

Thanks again @kb-0311 for kicking off this PR. It's a great performance improvement for our application and I'm excited to see it finally merged. Thank you especially for your patience in the review cycle these months.


[Ruby: cli] Refactor calls to --listresources and --listfunctions

Metadata

Implementation plan

Context
CLI can be simplified by removing Turbine calls to --listresources and --listfunctions, and instead getting the necessary information from the deployment spec.
As we are reverting default IR changes, we are keeping calls to listresources and listfunctions, but also adding checks on IR specs.
If https://github.com/meroxa/turbine-core/issues/9 has not been completed, ensure that the IR DeploymentSpec struct has a function to populate function image. This function will be used by the CLI to populate the image after it is done building.
Acceptance

[ ] Refactor CLI to use IR spec along side with making calls  to --listresources and --listfunctions.

At the current moment, we have reverted default use of IR back to old orchestration. For Ruby, we will be using the listresource and listfunction calls to mirror other languages for now. Closing this.


Fix dynamic embedding bugs that may lead to segmentation faults

Hi TorchRec Team,
We've recently been trying to use the dynamic embedding feature in torchrec contrib, but we  have encountered a few challenges. The process may result in a segmentation fault. After debugging, we've identified two potential problems.
1） fetch_notifications_ is not thread-safe.
2）Tensor data might be recycled during pushing operations.
For the first issue, the fetch_notifications_ variable is accessed in both the pull and sync fetch functions. As these functions are called in different threads, there might be a thread safety issue.
For the second issue, the tensor generated by concat in the push function is a temporary variable. The subsequent call to io.push is asynchronous and does not copy the data. Therefore, the data might have been recycled by the time it is executed asynchronously, leading to access to invalid data.
In light of these findings, we have undertaken some corrective measures to address these issues. We appreciate your attention to this Pull Request and eagerly await your valuable feedback.
Thank you for your time and consideration.

Hi, I don't have expertise on dynamic embeddings, so probably will just cc @colin2328
also probably make an issue as well, since it is easier to track there

sorry for the late response. I have created an issue here: https://github.com/pytorch/torchrec/issues/2006. I would appreciate any further suggestions regarding the pull request.

Please address CI failures and then you are good

Please address CI failures and then you are good

thanks! sorry for the failures and I've fixed them and pushed the changes to the merge request. However, it seems that the workflow requires approval again.

CI looks good, previously flaky test. Feel free to merge!


JsonPath doesn't convert to explicit type when specified

From<EMAIL_ADDRESS>on October 03, 2011 16:49:07
E.g.
from(json).getList("something", int.class);
doesn't convert
Original issue: http://code.google.com/p/rest-assured/issues/detail?id=114

From<EMAIL_ADDRESS>on October 03, 2011 10:24:30
Status: Fixed


Sage dynamic select input - select2

Description
Adds a select2 input type for sage forms
API Options:
url: String,
label: String,
name: String,
id: String,
has_error: [:optional, TrueClass],
message: [:optional, String],
required: [:optional, TrueClass],
// sets default selected option for the input
default_value: [:optional, String, Integer],
default_text: [:optional, String],
// enables pagination for 25 rows at a time
paginate: [:optional, TrueClass],
// allows user to search through retrieved results
search: [:optional, TrueClass],
// displays an x button for the user to clear the selected value
clear: [:optional, TrueClass],
placeholder: [:optional, String],
// toggles legacy select2 input preset options would be "sage" or "bootstrap"
theme: [:optional, String],

Screenshots
Component States
Empty state

Selected state

Input open w/ search

Input open w/o search

input w/ error

Testing in sage-lib

Testing in kajabi-products

(LOW/MEDIUM/HIGH/BREAKING) Description of the change and its impact with QA as the audience.

[ ] One more examples of the component in use to either test the change or verify the change has not had adverse effects.

Related

Thank you for your review @philschanely! I was able to refactor some nesting which definitely helps with readability. I did have som questions regarding adding the input to our docs site, would love to sync with you around this.


What is the official pypi package link for the python SDK?

Hi, do you have a published pypi python pakacge for the python SDK?

Hi, do you have a published pypi python pakacge for the python SDK?

Hi, do you have a published pypi python pakacge for the python SDK?

Hi Edpruuv, we will release our official pypi package very soon. Will keep you posted and thanks!

Thanks @jasonchentt, looking forward to it!

@edpruuv We have released the pip library: tiktok-business-api-sdk-official. Please use the latest version 1.0.1


Update quickstart-ide-orientation.md

@wuhanyumsft : Thanks for your contribution! The author, @gewarren, has been notified to review your proposed change.


Deep Links for Files

It is possible to create deep links for editing/viewing files within Teams? Is it possible to deep link using the urls that begin with https://teams.microsoft.com/_#/docx/viewer, though it´s not clear how we would build up the urls

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a891841a-a110-d18e-25c1-fc29e7d4a5e3
Version Independent ID: c1a11eb8-00d1-e1d2-1e9d-71d059a6478a
Content: Create deep links - Teams
Content Source: msteams-platform/concepts/deep-links.md
Product: msteams
GitHub Login: @o365devx
Microsoft Alias: o365devx

Are you trying to deep link a file to Bot or Tab ?

We are trying to deep link from a custom tab. We´ve found out that we can use the executeDeepLink JavaScript SDK method and send in a url with the following structure. But have had to figure this out from what is happening on the files tab. This seems to work, but we´d prefer to be using something that is documented.
https://teams.microsoft.com/_#/{docxExtenstion}/viewer/teams/{encodedSharepointFileUrl}/?threadId={channelId}&baseUrl={encodedSharepointBaseUrl}&fileId={sharepointFileId}&ctx={files|new_file}&viewerAction=edit


vupdated: add Prometheus query metric type

it would be cool to be able to configure a dial to display the results of executing a Prometheus query. of course, the query would need to return a value between 0-100 or be clamped.
the config would presumably take a Prometheus URL and a PromQL query.

https://docs.rs/prometheus-http-query/latest/prometheus_http_query/ seems like it's probably the library to use...


Issue shifting months at end of month

Steps to reproduce
iex(1)> now = Timex.now()
#DateTime<2019-05-31 01:08:01.943916Z>
iex(2)> now |> Timex.shift(months: -1)
#DateTime<2019-05-01 01:08:01.943916Z>

Description of issue
I would expect the shift to be the 30th day of April.

Fixed in master


Wrong HTTP API endpoint in docs

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
This link claims that the main API endpoint for making policy decisions is the /api/check REST endpoint.
This endpoint is marked as deprecated in the API documentation and the new endpoint is /api/check/resources.

Expected Behavior
The documentation must point users to the new /api/check/resources endpoint instead.
Steps To Reproduce
Open https://docs.cerbos.dev/cerbos/latest/api/ in a browser of your choice.
Environment
- OS: All OSes
- Cerbos version: Latest (0.29.0)
- Docker version: Irrelevant
- Go version: Irrelevant

Anything else?
No response

If my claim is valid, I can open a PR and make fixes.

@oguzhand95 I created a PR for the fix.


onValueMouseOver doesn't work with LineMarkSeriesCanvas

onValueMouseOver event cannot be triggered for LineMarkSeriesCanvas, but can be triggered for LIneMarkSeries

Is there any concern that don't have onValueMouseOver work with LineMarkSeriesCanvas? If it's ok I can open a PR for this.
Thanks,
Renhao