Cannot set third party color scheme as sudo

Description of the problem or steps to reproduce
On an up to date system run sudo apt install  followed by sudo apt update and sudo apt upgrade. Download dracula theme to ~/.config/micro/colorschemes. I also gave catppuccin themes a try, same results.
Specifications
Third party colorschemes do not work under sudo. They do as a regular user and the themes provided by micro itself can be changed under sudo.
Regarding Issue 2201 I went into .bashrc and added the line export MICRO_CONFIG_HOME=/home/myusername/.config/micro/. I also gave the value "~/.config/micro/" a try, both times with and without quotation marks. Everytime I did a change, I saved the file, backed out of it, closed alacritty, restarted alacritty, ran sudo micro and tried to set a scheme with CTRL+E->set colorscheme dracula->Enter. Unfortunately I get faced with "dracula is not a valid colorscheme". Everything works fine when using micro without sudo privs.
I also ran sudo micro -config-dir /home/myusername/.config/micro/ again, once with and once without quotation marks. After both runs a blank file opened and I hit CTRL+E->set colorscheme dracula->Enter. No Error-Message, but also no change in the visuals. When backing out of the file and running sudo micro, there still is no change in the visuals, when now trying to change the scheme again, I am hit with "dracula is not a valid colorscheme".
The export which is set in the .bashrc itself seems to work though as there are now a folder called buffers, a bindings.json and settings.json file in the /.config/micro/ folder. The settings.json file does hold the data colorscheme	"dracula" as expected.
Commit hash: 2.0.11
OS: Debian 12
Terminal: Alacritty
Shell: bash 5.2.15

This is not a bug of micro and no bug at all.
By invoking sudo the default behavior is to ignore the environment of the invoking user. This can be changed by using sudo -E [COMMAND].
So in your scenario you've to add -config-dir= with sudo or using sudo -E, which will then respect $MICRO_CONFIG_HOME.

Or set "autosu": true

Yes, this can be a further solution, but many users are already familiar with the invocation of sudo or sudoedit and they need to preserve the environment to user their normal user settings.


Fix contributors link typo

Thanks!! 🙏🏻 I was wondering why the workflows are failing but then I saw you sent it in from a fork, which doesn't have access to the Code Climate test reporter token. So I think it's safe to merge this one.


started to remove PyMol from notebook 10

@jaimergp
Started to remove pymol from notebook 10, turned out more difficult than expected because there's protein alignment using pymol too.
Used biotite package for sequence alignment, then MDAnalysis for coordinate alignment, from what I could tell, there isn't a clean way to sequence & coordinate align in one package.....
Got down to the rmsd matrix calculation, there's still some binding pocket rmsd to do still.
My first PDB ID ended up being the "worst" one, so I think my alignment results ended up being worse because all proteins were aligned to the worst PDB ID....

Continued in #10


ci: ensure milestones are assigned when undrafting, merging a PR

What feature or improvement would you like to see?
It appears undrafting doesn't run the assignment?

From https://github.com/orgs/community/discussions/25722 it appears we need to also run on "ready_for_review"


Fix: waitProjectStart handle async request

Improve async handling of response and retry mechanism.
 AsyncResult<T> is a generic class to be used also in future PRs (e.g. for Complex Flow implementation)

@gciavarrini please rebase on top of https://github.com/parodos-dev/parodos/pull/230


chore: remove styfle/cancel-workflow-action usage

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#concurrency
https://github.blog/changelog/2021-04-19-github-actions-limit-workflow-run-or-job-concurrency

Codecov Report
Patch and project coverage have no change.

Comparison is base (d0418f8) 96.96% compared to head (ee6fb49) 96.96%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #101   +/-   ##
=======================================
  Coverage   96.96%   96.96%
=======================================
  Files          13       13
  Lines        2111     2111
  Branches      396      396
=======================================
  Hits         2047     2047
  Misses         63       63
  Partials        1        1

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Not enough generation capacity - dummy technology to cover rest of load

Hi all,
in our model we have so called "slack-cost". They are applied to the amount of energy that is missing in the system due to shortage in generation. Do you have something similar in your models? If so, do we need a parameter to harmonize those cost? Do you have any uncovered load anayway?

Yes, we do have the functionality of said slack costs (with incredible high costs so they are really only triggered if necessary). But so far, we do not see these being required in the current model runs.

I would suggest to use a very high value: 999999


Feat: JWT Authentication

Added JWT Authentication

Summary by CodeRabbit

New Features

Introduced constants for cache management (GC_TIME, STALE_TIME).
Added a new hook useAccountsList to retrieve account data in the Accounts component.
Enhanced authentication flow with new functions for token management.
Implemented a deduplication mechanism for fetch requests.
Added functionality for signing messages with installation keys.

Bug Fixes

Improved error handling during logout and API interactions.

Documentation

Updated comments for clarity on logout tasks and error handling.

Chores

Removed unused API signature management functionality.

I can verify that I know this is functional against the new backend changes.
I've asked for further audit and Slack here: https://xmtp-labs.slack.com/archives/C05GBHEAGPP/p1733926004965479
Specifically, I have questions about what rabbit mentioned about replay attacks, and nonces.
I think another lingering question we had was about whether or not there were any security applications related to how to install installations with the same inbox ID would create their tokens


Vue useFloating cannot return middlewareData

Describe the bug
Trying to return the middlewareData from floating-ui@vue returns nothing using useFloating
To Reproduce

<template>

        Button

            this is a tooltip

</template>

Steps to reproduce the behavior:

Copy the code into any vue file and run it. The console will show nothing is returned using .value but not outputting the .value will show the _value inside it.

Expected behavior
It should return precisely the middleware data so the arrow key can be positioned. Currently it is returning {}
Screenshots
attached screenshot

If you add setTimeout() around the access to middlewareData.value, is the object no longer empty?


Bump .NET versions and fix docker build script

I tried to build a Docker image of NetPad, but it failed. I fixed the Dockerfile and then incidentally upgraded .NET to 8.0 and also upgraded most of the NetPad dependencies to the latest version.
This pull request includes these changes:

Bump .NET to 8.0 and bump almost dependencies to latest version
Fix & enhance docker build script
Support launching the OmniSharp server by dotnet exec OmniSharp.dll due to the container limitation

Thank you @Deliay. A rather large refactor is under way on the solution-refactor branch, including the upgrade to .NET 8. I will hold off on this PR until that is concluded, in a week or so, since it makes large sweeping changes. Once that's done I will revisit the changes introduced here and let you know.
Thanks for the work on the docker script, I haven't really maintained it at all. I appreciate the contribution.

Update: PR #211 is merged into main. I will be reviewing the changes here soon to see how it needs to change

@Deliay I requested some changes before merging the PR.
In addition let's hold off on commit (Bump .NET to 8 and bump dependencies to latest version). The package upgrade has a little more to it, especially related to the swagger generated API client. For .NET 8 I want to run some tests on my end to make sure everything still works with that upgrade so I'll go ahead and update to .NET 8 in a later PR once I've validated it. Can you also revert the change to v8 in the README introduced in ac357ba.
Lastly, the change that you introduced in (Support lanuch OmniSharp server via 'dotnet exec OmniSharp.dll') did you test this still works when running the app without docker?

@tareqimbasher would you be interested in another pr mainly for fixing the docker file? I have a a working dockerfile on my pc that uses a multistage build.

@Jogai yes I would be interested. Thanks for the contribution!


Release3.6

Updated templates to deploy OpenShift Container Platform 3.6.
Please view CHANGELOG.md for summary of changes from previous version.
Parameters have changed as well.  Please review parameters file prior to testing.

Found an issue.  Closing for now. and will reopen when fixed.


Solc error while parsing the solc code with pattern similar to "pragma solidity >= 0.5.0 < 0.6.0"

Description

mythril/ethereum/util.py/extract_binary() --> Returns binary of solc compiler to compile the Solidity file. Usually, it returns compiler that supports specific Solidity version according to the Solidity file.
extract_binary() calls extract_version() from the util.py
mythril/ethereum/util.py/extract_version() --> It takes the Solidity file as a string and returns back the version of the Solidity file.
extract_version() looks for a line that has "pragma solidity" in it and returns the version.
pragma solidity in Solidity code specifies the version of solc compiler in which the code should get compiled.
The problem with extract_version() is that it handles patterns like pragma solidity ^0.5.0 but fails it handle pragma solidity >= 0.5.0 < 0.6.0.
When the Solidity file with version name specified like pragma solidity >= 0.5.0 < 0.6.0 is given to myth then extract_version() returns wrong compiler version (0.8.X) to extract_binary() and extract_binary() returns wrong binary. As a result the Solidity file does not compile and myth produces solc error.
A change in the functionality of extract_binary() will solve the problem. Moreover, trying different solc compiler versions for patterns like pragma solidity >= 0.5.0 < 0.6.0 will make the solution as stronger as patterns like this suggest that one or more versions from the specified range compiles the solc code successfully.

How to Reproduce

When the Solidity file with version name specified like pragma solidity >= 0.5.0 < 0.6.0 is given to myth then extract_version() returns wrong compiler version (0.8.X) to extract_binary() and extract_binary() returns wrong binary. As a result the Solidity file does not compile and myth produces solc error.

Input: solc file that has line: "ragma solidity >= 0.5.0 < 0.6.0;"

Output:
ParserError: Source file requires different compiler version (current compiler is 0.8.18+commit.87f61d96.Linux.g++) - note that nightly builds are considered to be strictly less than the released version
--> unchecked_buggy_4.sol:5:1:
|
5 | pragma solidity >= 0.5.0 < 0.6.0;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   SolidityVersionMismatch: Try adding the option "--solv <version_number>"

Expected behavior
extract_version() should return correct solc compiler version irrespective of what is specified by user in pragma solidity. Sometimes, myth should try different solc compiler version to parse smart contract without solidity errors.
Environment
Please modify for your setup

Mythril version: v0.23.15
Solidity compiler and version: NA
Python version: Python 3.8.10
OS and Version: Ubuntu 20.04.3 LTS

Thanks for logging the bug. There are a lot of such cases that mythril cannot currently support due to some limitations of NPMSpec library.
Ex: pragma solidity ^0 .   5.    0; is a valid solidity pragma but wouldn't work. Requires some painfully long regex or using some parser.

Thanks for the reply. I have a small suggestion. Until the bug is fixed, extract_binary() can return the default solc binary, and the user who calls myth can set solc version accordingly by using solc-select.

Can you check if the bug is fixed on the develop version?

You can also use --solv 0.5.0 flag to restrict Mythril to a certain solc version, so, there's no need for solc-select.


re-instate the ignore rule for seen aggregates.

fixes #4721
Signed-off-by: Paul Harris<EMAIL_ADDRESS>Documentation

[X] I thought about documentation and added the documentation label to this PR if updates are required.

Changelog

[X] I thought about adding a changelog entry, and added one if I deemed necessary.

The other piece to remove is processedAggregateAttestations in AttestationManager.  The validator will ignore duplicate attestations again so we don't need to do it in AttestationManager.

ready for re-review


Is it possible for Stepper to navigate steps programmatically?

For example, there are five steps and current active step is 1, i want to navigate to step 2 programmatically.
Is is possible?

@spiegelp Thanks~

Could you provide an example while using XAML ? From my viewmodel I have no reference to the controller :-/

@Coloris  Take a look at StepperTemplates.xaml line 450. The buttons in the template bind their Command property to commands of Stepper to trigger navigation: Command="{x:Static controls:Stepper.ContinueCommand}".

What if I want to go back to the first step by setting a property (just like a tabitem), I don't get how to bind to a Static property from my view model

Do you like to set the current step via a data binding? There is an ActiveStep property, but it is readonly. It could be extended with a setter, to accomplish something like this:
<materialDesignExtensions:Stepper ActiveStep="{Binding Path=MyViewModel.StepToShow}">

Are you looking for this?

Yes, just like a tabitem, you can bind a property to change from viewmodel the current tab (since it's an index)


No equivalent of AddControllersAsServices() for VC's

If you have an external assembly, contianing a Controller, and a ViewComponent, you can register the controller with MVC by calling AddControllersAsServices()
However there is no equivalent for the ViewComponent.
The default behaviour seems to be if you have a project reference to the assembly then the VC is picked up, but if you don't have a project reference to it (i.e ILibraryManager is not aware of it) - because for example, it's a standalone "plugin" assembly, then VC's are not detected.
Could you add a method similar to AddControllersAsServices() but for VC's?
Or perhaps add some sort of "IncludeMvcServicesFromAssemblies()` method, that will make sure the assemblies are treated as candidates for all types of services that MVC looks for - i.e Controllers, VC's, and whatever else.

And here is a repro showing the issue, that you can load an assembly at runtime, register its controllers, but not the VC's: https://github.com/dazinator/mvc6-view-components/tree/issue-noprojectreferences

We should also look at adding a more general mechanism for injecting everything from an assembly: https://github.com/aspnet/Mvc/issues/4089.

We should also support constructor injection in view components by default like we do for controllers.

And we should do the same for Tag Helpers.

Not sure if this is related, have raised #4100 to do with ViewModels not being resolved when they live in an external assembly with a razor view.

@dazinator - Razor uses your project's referenced assemblies as its inputs for compilation. We need to figure out a good all-up way to handle these scenarios.
What's stopping you from referencing this assembly at compile time?
Can you enumerate all assemblies you want to "include" at startup time?

What's stopping you from referencing this assembly at compile time?

I'm building an application that is designed to be extensible. This means extensions can be installed at runtime, after the application is deployed. So far, the only blockers for this is that VC's don't work without a project reference, and neither does Razor View compilation.

Can you enumerate all assemblies you want to "include" at startup time?

Yep. At startup time, my application registers an IAssemblyProvider that returns the union of the DefaultAssembyProvider plus my additional "plugin" assemblies. This doesn't seem to effect Razor Compilation or VC Discovery though.

Then you need to hook more than just the assembly provider, in rc2 you can more easily add assemblies to the razor compilation. In rc1 it's a bit cumbersome but possible.

after the application is deployed

Yep. At startup time ...

These two aren't the same (at least not in my mind). Are you saying that you want to add assemblies after startup? Or is the set of assemblies fixed at startup time?

This doesn't seem to effect Razor Compilation or VC Discovery though.

VC's use the assembly provider. If it's not finding your extra assemblies, this is something weird. https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.ViewFeatures/ViewComponents/DefaultViewComponentDescriptorProvider.cs#L49
================

Then you need to hook more than just the assembly provider, in rc2 you can more easily add assemblies to the razor compilation. In rc1 it's a bit cumbersome but possible.

We should still make this easier if it's just adding more "MVC" assemblies.

@rynowak

VC's use the assembly provider. If it's not finding your extra assemblies, this is something weird. https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.ViewFeatures/ViewComponents/DefaultViewComponentDescriptorProvider.cs#L49

You are right! Implementing an IAssemblyProvider that includes my VC assembly has actually fixed this issue, I just wasn't testing correctly! :)

We should still make this easier if it's just adding more "MVC" assemblies.

Yes please, so it's as easy as AddControllersAsServices() !

These two aren't the same (at least not in my mind). Are you saying that you want to add assemblies after startup? Or is the set of assemblies fixed at startup time?

When the application starts up, the set of assemblies is fixed, but it consists of the assemblies that were project referenced (that ILibraryManager knows aboutand the set that have been placed in some location through the concept of installing an extension into the application which happens at runtime, after the application has been deployed somewhere. Installing an extension basically dumps additional assemblies somewhere, and restarts the application, so that on startup the new assemblies are detected, and the MVC components can be correctly registered with the framework. It's this second part - correctly registering these assemblies with the MVC framework that has been challenging, as some things have API's likeAddControllersAsServicesand some things require that you implementIAssemblyProvider` or some other hook :)

@davidfowl

In rc1 it's a bit cumbersome but possible.
Are you able to point me in the right direction for how to do this with RC 1 as I'd love to get that working?

https://github.com/aspnet/Mvc/issues/4089 - iterating on design in this area

@dazinator - sorry, I missed your comment here.
@pranavkm - how can you add more assemblies as references for Razor compilation at startup time?

@dazinator, there's a callback on RazorViewEngineOptions that lets you configure the Roslyn compilation context:
var previous = options.CompilationCallback;
options.CompilationCallback = (context) =>
{
    if (previous != null)
    {
        previous(context);
    }

    var references = myAssemblies.Select(Assembly.Load).ToArray();
    context.Compilation = context.Compilation.AddReferences(references);
};

@pranavkm - options.CompilationCallback doesn't appear to be a thing in 6.0.0-rc1-final. Is there an alternative for RC1 or would we have to upgrade to perhaps RC2? or Core?

We added that as part of RC2.Looking at the code, there isn't a hook to configure compilation in RC1. Perhaps you could copy https://github.com/aspnet/Mvc/blob/6.0.0-rc1/src/Microsoft.AspNet.Mvc.Razor/Compilation/RoslynCompilationService.cs in to your application for the time being and remove it once you upgrade to RC2?

Reopened until I check-in the tag helpers part


Cannot read property 'value' of null

Issue Id: 04611604-cb83-5e5d-d74d-035e57007c47Versions - 1.17.2Stack TypeError: Cannot read property 'value' of null/vs/workbench/services/extensions/electron-browser/extensionService.ts#L246:16 (value)/vs/base/common/winjs.base.raw.js#L1566:0 (onComplete)/vs/workbench/services/extensions/electron-browser/extensionService.ts#L245:41 (then)/vs/workbench/services/extensions/electron-browser/extensionService.ts#L230:15 (_activateByEvent)/vs/platform/commands/common/commandService.ts#L36:44 (activateByEvent)/vs/editor/browser/view/viewController.ts#L73:22 (executeCommand)/vs/editor/browser/controller/textAreaHandler.ts#L219:25 (type)/vs/base/common/callbackList.ts#L36:22 (apply)/vs/base/common/event.ts#L123:26 (call)/vs/editor/browser/controller/textAreaInput.ts#L252:18 (fire)

I have this problem right now,it says: "Cannot read property value of null", and I can't edit anything in the code editor, I don't know what is happening, help please!!

same here, can't enter anything, but copy & paste and delete work just fine

@damasofc @CharryWu Do you have any reproducible steps? Do you see any additional errors in the developer console (Help > Toggle Developer Tools) ?

@jonhenneberg I got similar error messages from the dev console. I have just figured out it is the C/C++ extension that caused the problem. If I disable the C/C++ extension vscode works again, so perhaps it is the code linting that causes the problem. Try disabling extensions that does code linting.

@CharryWu Thanks, disabling the C/C++ extension seemed to solve it.

Would note that my Code instances are still acting strange thou. After startup it consumes 2G ram, and is very sluggish. Helps to run a garbage collect in the dev tools, then it lowers to 500M of ram.
Tried disabling all plug-ins, did not affect that in the slightest.

Thanks, disabling that extension, solve it

This might be a bug, and a bug report has been submitted to the repository for C++ extension.

Same problem here. At startup Code eats up to 3 GB of RAM. Only disabling C/C++ extension makes editor responsive again.

I ended up completely removing Code, including settings and extension folders. And installing a clean version. Then the issue with high Load / Ram usage was gone, and i could apply my settings again + install the extensions (incl. C/C++) and everything works as great again.

If anyone is currently seeing this issue, can you please enable our development logging for the cpptools extension to see if it is receiving any messages from VS Code or not.  In your settings, please add "C_Cpp.loggingLevel": "6".  Ignore the squiggle in your settings.json file.  This is an undocumented option.
When this setting is enabled, we will print out all messages received from the VS Code protocol in the Output Window under the "C/C++" channel.  In particular, you should look for textDocument/didChange.  If these messages are not appearing, then VS Code is not sending our extension any information about your edits.  I highly suspect this is a VS Code issue because extensions do not have the capability to intercept keystrokes.  We have to be notified about them by VS Code.

@bobbrow
The problem here is that the extension host process crashes / quits unexpectedly, in the initialiaztion phase AFAICT. Most of the reports claim that disabling the C++ extension leads to the extension host process not crashing.
I will add some logging to VSCode around extension activation code to be able to track this down in our upcoming release.

@alexandrudima, so has VS Code even attempted to load our extension at this point?  Looking at the code where the crash happens it looks like our extension hasn't even been activated yet which means that none of our extension's code would have run yet (unless I'm reading it wrong).

@bobbrow I 100% do not understand what you're talking about. The stack trace present in this error telemetry issue occurs on the renderer process, as a direct result of the extension host process crashing in the initialization path.
In other words, I can avoid this specific stack trace by checking for a null pointer, but the root cause of this error is that the extension host crashes very early in its lifecycle, most likely when activating eager (* and workspaceContains:) extensions.

I know nothing about how VS Code initializes extensions.  All I know is that at some point VS Code calls our "activate" method and passes in an ExtensionContext and at that point we are "active".  The code at the crash site looks like this:
	protected _activateByEvent(activationEvent: string): TPromise<void> {
		if (this._extensionHostProcessFinishedActivateEvents[activationEvent] || !this._extensionHostProcessProxy) {
			return NO_OP_VOID_PROMISE;
		}
		return this._extensionHostProcessProxy.then((proxy) => {
			return proxy.value.$activateByEvent(activationEvent);  // <-- crash here
		}).then(() => {
			this._extensionHostProcessFinishedActivateEvents[activationEvent] = true;
		});
	}

I don't know what $activateByEvent is, but it looks like VS Code is still working with an activationEvent string, not an ExtensionContext which made me think that VS Code had not passed us the context yet. So this reads to me like our extension's code has not been loaded or executed by VS Code yet.  Are you saying that our extension has already begun execution?  Like I said, I don't pretend to know what this code is doing.  I'm just asking if our extension's activate method has already been called at this point.

@bobbrow VS Code is a multi-process tool. The UI of VS Code executes in what we call a renderer process. VS Code spawns a separate process, which we call the extension host process. Source code from extensions is loaded and executes in this separate process.
To facilitate programming through a message-passing IPC protocol, we have built a proxy infrastructure to make talking between processes look like method calls. The above source code that you show will execute on the renderer process. proxy.value.$activateByEvent will send a message to the extension host and ask it that it activates all the extensions that depend on an activation event.
But proxy is null. It is null because the extension host process crashes in its initialization phase. The initialization phase includes ... initialization ... and activation of eager extensions. Eager extensions are the ones that activate on * or workspaceContains:.
I do not have definite proof that the crash occurs due to the C++ extension, but the reports from users who disable it make me believe the activation path of the C++ extension may lead to a crash of the extension host. The easiest type of crash it could cause would be an OOM crash.
For November, I have pushed code that logs to our brand new logging infrastructure. Once we ship the November stable release of VS Code, I will ping folks involved in this thread to enable tracing and try to reproduce the crash. Then, we can collect the extension host process log and see, together, how far in the initialization path, the extension host process made it before it crashed. Hopefully, that gives us sufficient information to be able to pinpoint the root cause.

Thanks for the explanation.  That makes sense.

There is no clear root cause here and no clear code change that can be done in VS Code. This error is a result of another error. i.e.
It means the extension host process crashed, but does not identify why it has crashed (the root cause). I will close, as the issue is not actionable...


Abstract Silex

Currently, CRUDlex is tightly coupled with Silex. But the end of Silex is near: http://symfony.com/blog/the-end-of-silex
So the framework depedency needs to be abstracted out with Silex as a first implementation followed by Symfony 4 as second one.

Done with https://github.com/philiplb/CRUDlexSilex2 and https://github.com/philiplb/CRUDlexSilex2Sample


[Select] Prop aria-describedby is passed down to hidden input element

I am trying to use Select component with accessibility support. It works pretty well except for the usage with FormHelperText . When the select toggle button is focused the screen reader does not read the contents of FormHelperText. I have also tried using the TextField component with select prop for better support as mentioned in docs.

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
The screen reader does not reads the helper text provided using aria-describedby prop to Select component or simply by passing id prop to TextField component with select prop. Instead the prop is passed down to the hidden (aria-hidden) input element. I have narrowed down it to following piece of code:
https://github.com/mui-org/material-ui/blob/174b64f8a3adffb8df3c13285f4edc2437a8547a/packages/material-ui/src/TextField/TextField.js#L176
https://github.com/mui-org/material-ui/blob/174b64f8a3adffb8df3c13285f4edc2437a8547a/packages/material-ui/src/Select/SelectInput.js#L398
Expected Behavior 🤔
It should pass the aria-describedby prop to wrapper div of select component. May be in following line:
https://github.com/mui-org/material-ui/blob/174b64f8a3adffb8df3c13285f4edc2437a8547a/packages/material-ui/src/Select/SelectInput.js#L372
Steps to Reproduce 🕹
I am implementing it as follows:
<FormControl
  fullWidth
  error={hasError}
>
  <InputLabel id="select-label">Please select an option</InputLabel>
  <Select
    labelId="select-label"
    id="select-field"
    value={value}
    onChange={onChange}
  >
    {options.map((option) => (
      <MenuItem key={option.value} value={option.value}>
        {option.title}
      </MenuItem>
    ))}
  </Select>
  {hasError && (
    <FormHelperText id="select-field-helper-text">
      {errorMessage}
    </FormHelperText>
  )}
</FormControl>;

Context 🔦
I would like to make screen readers read the helper text for form validation purpose.
Your Environment 🌎

`npx @material-ui/envinfo`

  System:
    OS: macOS Mojave 10.14.6
  Binaries:
    Node: 14.15.0 - ~/.nvm/versions/node/v14.15.0/bin/node
    Yarn: 1.22.5 - ~/.yarn/bin/yarn
    npm: 6.14.8 - ~/.nvm/versions/node/v14.15.0/bin/npm
  Browsers:
    Chrome: 87.0.4280.88
    Edge: Not Found
    Firefox: 72.0.2
    Safari: 13.0.5
  npmPackages:
    @material-ui/core: ^4.11.0 => 4.11.0
    @material-ui/icons: ^4.9.1 => 4.9.1
    @material-ui/styles:  4.10.0
    @material-ui/system:  4.9.14
    @material-ui/types:  5.1.0
    @material-ui/utils:  4.10.2
    @types/react: ^16.9.0 => 16.9.49
    react: ^16.13.1 => 16.13.1
    react-dom: ^16.13.1 => 16.13.1
    typescript: ^4.0.5 => 4.0.5

@HVish Thanks for reporting the issue. I could reproduce on VoiceOver with this demo https://next.material-ui.com/components/text-fields/#select. It works with the native select but fails with the nonnative implementation. What do you think about this fix? Do you want to work on a pull request? :)
diff --git a/docs/src/pages/components/text-fields/SelectTextFields.tsx b/docs/src/pages/components/text-fields/SelectTextFields.tsx
index 124b6085cf..5f00b6278b 100644
--- a/docs/src/pages/components/text-fields/SelectTextFields.tsx
+++ b/docs/src/pages/components/text-fields/SelectTextFields.tsx
@@ -33,7 +33,7 @@ const useStyles = makeStyles((theme: Theme) =>
   }),
 );

-export default function MultilineTextFields() {
+export default function SelectTextFields() {
   const classes = useStyles();
   const [currency, setCurrency] = React.useState('EUR');

diff --git a/packages/material-ui/src/Select/SelectInput.js b/packages/material-ui/src/Select/SelectInput.js
index 34244bb0ef..4ba999d576 100644
--- a/packages/material-ui/src/Select/SelectInput.js
+++ b/packages/material-ui/src/Select/SelectInput.js
@@ -28,6 +28,7 @@ function isEmpty(display) {
  */
 const SelectInput = React.forwardRef(function SelectInput(props, ref) {
   const {
+    'aria-describedby': ariaDescribedby,
     'aria-label': ariaLabel,
     autoFocus,
     autoWidth,
@@ -367,6 +368,7 @@ const SelectInput = React.forwardRef(function SelectInput(props, ref) {
         aria-haspopup="listbox"
         aria-label={ariaLabel}
         aria-labelledby={[labelId, buttonId].filter(Boolean).join(' ') || undefined}
+        aria-describedby={ariaDescribedby}
         onKeyDown={handleKeyDown}
         onMouseDown={disabled || readOnly ? null : handleMouseDown}
         onBlur={handleBlur}
@@ -439,6 +441,10 @@ const SelectInput = React.forwardRef(function SelectInput(props, ref) {
 });

 SelectInput.propTypes = {
+  /**
+   * @ignore
+   */
+  'aria-describedby': PropTypes.string,
   /**
    * @ignore
    */

At first, I got confused with the difference with aria-labelledby. This blog post clarified it.

@oliviertassinari Of course! Actually I was about to send the pull request :D
I have one more question. Like other form components could we have aria-invalid attribute for Select component? Obviously I tried implementing it before sending the pull request but one test failed with message:

The attribute aria-invalid is not supported by the role button  jsx-a11y/role-supports-aria-props

So I was wondering if we could do some work around with non-native select component?

I'm not familiar with this prop, maybe @eps1lon has more context on it?


Auto generate binder links

Currently, they are hard-wired, but switching to a theme supporting notebooks should resolve this issue, too.

The binder links are now nicely auto-generated, close this PR once the old, static links are cleaned up.


Wii U support

Support for Wii U discs and CDN contents would be good. There is an implementation here: https://github.com/Maschell/fuse-wiiu

I've been thinking about it sometimes so maybe. I don't know the format of Wii U discs though and I am concerned about reading GPL code as a reference when this project is MIT licensed. I could do CDN contents though since I already made some scripts for this: https://github.com/ihaveamac/wiiu-things


Add simple landing page with login

Redirects to classroom feed

Branch issue-1-add-simple-landing-page-with-login created for issue #1.


Misc cmake packaging enhancements

Some additions to the CMake package configs to be more consistent with common CMake packaging guidelines:

Use namespaces for imported targets
Allow package configs in build directory
User-defined install location for package configs

Coverage remained the same at 100.0% when pulling 33a2154f8dbff1382d84d6e463e31a5ac9f3da18 on chuckatkins:misc-cmake-packaging-enhancements into 29362c6ace9d9b002a7269c5bf90b190c09fe706 on nlohmann:develop.

Thanks a lot!


Use allow function as much as possible and move to common utils

change this
components/melecules/ConnectedWallet
function shortenAddress(str: string) {
  return `${str.substring(0, 6)}...${str.substring(str.length - 4)}`;
}

to allow function and this general one needs to move to common utils

same to
  const shortenAddress = (str: string) => {
    return `${str.substring(0, 6)}...${str.substring(str.length - 4)}`;
  };

components/organisms/NFTDetail
Let's keep code DRY.

Do you mean consolidate both of these functions into 1 function that is used in place of these?


Empty array passes 'string' validation rule (2)

I asked this question earlier, but it got closed because the question was misread, and no reaction was given when I pointed this out.
So, I experienced the problem that empty arrays pass the string validation rules, since empty arrays are falsy and thus seen as an empty string. Passing this value in the query builder as string will break it however.
After some searching I found out that it was a known issue (See #10747). A fix has been made in commit 980d098ad091a5087a93202ebd4c091e336f3e58. However, this has been reverted later on in commit a7142dc041eb5a5c0507569817f5e450489c5981.
So two questions: (a) Why was this fix reverted, and (b) does this mean that this is intended behaviour?

Sorry, we don't process questions here.

To be fair, if an empty array really does pass a string validation rule, then that sounds like a bug to me.


startConversationWithUser doesn't work with emulator

Issue
According to core docs, startConversationWithUser(reference: ConversationReference) should work in the core without any adapter.
When I try to use it with the emulator, the async call to client.conversations.createConversation(parameters) inside botworker.ts seems to hang and the conversation is never started.
Demo
I made a simple working demo app here that you can clone to see the issue.

Start the emulator
Say "ref" to save a conversation reference to be used later (see console log output)
The bot should automatically start a new conversation using the ref, but instead it hangs

Debugging info
Apparently after about 5 minutes, the socket hangs up with this dump:
Error: socket hang up
    at new RestError (botkit-issue-demos/node_modules/@azure/ms-rest-js/dist/msRest.node.js:1397:28)

{
  code: 'REQUEST_SEND_ERROR',
  statusCode: undefined,
  request:
   WebResource {
     url: 'http://localhost:52343/v3/conversations',
     method: 'POST',
     body:
      '{"isGroup":false,"bot":{"id":"342e1f30-f4fa-11e9-aad8-0d5bc2ce5f40","name":"Bot","role":"bot"},"members":[{"id":"a97ee945-eace-4201-a682-a45e2ed2af22","name":"User","role":"user"}],"activity":null,"channelData":null}',
  ...
}

It's unclear from the async stack trace where this request originates.
Context

Botkit version: 4.6.1
Messaging Platform: Emulator
Node version: 10.15.3
OS: Mac 10.14

Hrm!! I'll research.

Note this is still an issue in botkit v4.6, but the workaround described in https://github.com/howdyai/botkit/issues/1844 works well enough for my purposes.
I simply changed startConversationWithUser(ref) => changeContext(ref) and I can begin a convo with the emulator. Demo has been updated accordingly.

I am implementing a workaround for this in Botkit.
However, I also opened a bug in the emulator repo, and we should remove this workaround when it is fixed.
https://github.com/microsoft/BotFramework-Emulator/issues/2097


Add docker image and usage documentation

I've created a docker image based on your repository, but I couldn't make google and manual crawl work.
So I've disabled them for now to make container work, but I've opened an issue and posted the errors.
If I could make it work in docker container too I will commit again on my fork and afterwards you can merge my pull request if you want.

Actually I realized it's pretty useless to make it work for now in docker image, so I've enabled google and manual crawling in docker image so you can see errors for yourself too.

Made a small change in the Dockerfile, please update it with the one in your repository for updating the building/pulling process with Docker later.
Thanks for the PR :+1:

Are you sure this works?

All set, thanks!

I've implemented Travis CI check for myself too, I don't know if it's necessary to create a pull request for that too, although it won't do any harm and you can later add check for your source code too.


Fixes NixOS configuration for initializing zsh-vi-mode

initExtra is used for home-manager, while interactiveShellInit is used for a global zsh config


firefox: add Kerberos support

Motivation for this change
Firefox supports using Kerberos to authenticate to webservers, this change to the package allows that support to be used.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
Only for the binary version, ran out of space compiling the source version.
[X] Fits CONTRIBUTING.md.

Thanks!


Failure, no download button or option

This has happened before, Media Download link has disappeared from page. Please rectify.

Have the same issue, the download button disappeared from the main Twitter user page while only remaining under each post, hope will be fixed soon.

@Troubleshoot23 @dilettoveleno Fixed in <IP_ADDRESS>. It's already updated on Chrome Web Store

the user script version is outdated and still broken

Sometimes I have to put "www." before "twitter.com" in my url bar and it will appear. No amount of refreshing will fix it but "www." has a 50/50 chance of working for me.


Manage_Settings_DeveloperTool:dropdown is defined as null. (Accessibility)

Date: 2021-08-06T05:23:36.445Z
VS Code: 1.56.0
OS: Windows_NT x64 10.0.19043
Repro Steps:
Tab till settings button and press enter.
Tab till dropdown.
Open developer tool using ctrl+shift+I and check if the name is defined for dropdown.
Actual:
The name for the format:Identifier case dropdown is defined as null.
Expected:
The name should be defined as the label for the dropdown.
User Impact:
Screen Reader users will get wrong information regarding the combo box.

I don't think anything is missing here. The setting container has information about the setting itself. When you focus the selectbox, it will read the value of the selectbox as expected.


Can You Control Creativity (temperature) of Response through the Model Description?

The answer is yes, but this is considered a bad practice by the OpenAI team. Still need a formal test case.


When will the data for LCB release v5 be available?

Thank you for your hard work. Could you let me know when the data collection for release v5 will be completed? I really appreciate it.

Thank you for the additional interest. We are planning to introduce additional difficulty to the problems and will hopefully release many new problems after the holidays.

thank you


Add a flutter upgrade command

This command upgrades the version of flutter that you're using and runs
pub upgrade to update the transitive dependencies.

LGTM


chore: tidb pipelines on master use go1.20

merged pipeline on tidb master upgrade to go1.20.1.

/lgtm


Patch for the new variant consequence

G2P-101

Merged into release/111 and master

Patch added to the live DB


Culver's

All Locations -->  http://www.culvers.com/locator/view-all-locations
/cc @iandees

Fixed in https://github.com/iandees/all-the-places/commit/cbf11a38981d978ab1577911e4dc7dc28ccb3175


Prevent superblock from being staked by ineligible neural node partic…

Decrease the chances of abuse occurring from a malicious user sending a malicious superblock.

This is a step towards making superblock stakes more secure.

Does it prevent nn votes from ineligible nodes too?

No it does not. And it also uses coin address, which can be generated in large quantities to meet the tarhet requirement. Making this No-Op.

the grc address in the block is the one put there by default wallet address it does a check to make sure they are the participant hash (25%). its not perfect as people can forge that sure in the block but I am add a check to see if that address is even valid. and this is just another way to reduce the chance (not completely) and as for the nn votes that is other code. this is simply the receiving end of a staked superblock another check to make sure they are eligible to do so (but doesn't work if they find a legit grc address in there wallet and check its hash before going to stake a forged superblock. I am looking at other ways but unfortunately you cant verify that someone even owns a grc address r know all the addresses they own.

and as for the nn vote system that's different I guess we could run the grc address as well in there and decide whether or not to accept it based on wheather or not its participating.

Yeah. I think we either need all nodes to participate or elected trusted witnesses voted by the community.

witnesses can be forged as well unfortunately the whole system will never be able to be secure fully. nothing that can be overly done about that. all you can do is make it harder

I will look into the increment of votes in nn on c++ side and see if the default wallet address in the block can be checked as an extra step . anything that makes it a little more difficult to do such things is helping security wise.

@tomasbrod if u have any suggestions or more things we can do here id gladly work through this with u. my only goal is to lower the chances of a bad superblock being formed. I believe can we reduce it by all these various steps and more. the harder the less possibility someone will make the effort to circumvent it. I'm all ears:)

Have you read my wiki paper about Incompatible changes? There is described dynmic and automatic node selection for NN. It is fairly complex, but should be secure.

yes I have and I agree with most parts of it.

Wait! This is actually good. Just add same check for nn vote counting and it will be for the next mandatory.

lol. jee I actually was gonna do the exact same thing for nn votes as well check the grc address is valid and the participant is participating.

least I made backups as I just merged the dev branch to update mine and didn't keep my changes haha


Adding JSON support to FormData polyfill

Hi team !
In some circumstances, we need to send a JSON payload as a part of the FormData.
For instance, here is what we need to send, as a final payload:
--boundary_1234-abcd
Content-Type: application/json
Content-Disposition: form-data; name="mywine"
{
    'key' : 1,
    'title' : 'red wine'
}
--boundary_1234-abcd--

Today, the FormData class does not allow us to specify Content-Type if the payload is not a blob uri.
This PR fixes this issue, allowing the user to pass a JSON payload with a type property Content-Type: application/json.
To do it, the FormData value provided by the user, must have a value property, containing the JSON object:

{
 value: {}, // JSON Payload
 type : 'application/json',
 name: 'arbitrary_name'
}

Basically, here is a straightforward sample:

    let payload = {
      key: 1,
      title : 'red wine'
    };

   formData.append('json', {
      value: payload,
      type: 'application/json',
      name :'mywine'
   });

Changelog:
[General][added] - Add JSON support to FormData polyfill
Test Plan:
The FormData is updated.
See Librairies/Network/__tests__/FormData-test.js

This change will diverge the FormData.append API from the Web standard.
https://developer.mozilla.org/en-US/docs/Web/API/FormData/append
Another way to achieve this would be to have a way to create a JSON Blob and then pass that to append.
const value = new Blob([JSON.stringify(stuff)], { type: 'application/json' });
formData.append('name', value);

Yes @newyankeecodeshop you're totally right on this point !
I'm not really proud of this implementation, at least It's working on my case...
I'm trying to evolve the code to use the Blob standard, as you said, using new Blob([JSON.stringify(stuff)], { type: 'application/json' });
The problem is that I need to read the blob, and the getParts method is not a Promise:
Here is what I have so far:
    readBlob(blob) {
        return new Promise((rs, rj) => {
            var reader = new FileReader();
            reader.onload = () => rs(reader.result);
            reader.onerror = (error) => rj(error);
            reader.readAsText(blob);
        });
    }

    async getParts() {
        return await Promise.all(this._parts.map(async ([name, value]) => {
            var contentDisposition = 'form-data; name="' + name + '"';
            var headers = { 'content-disposition': contentDisposition };
            if (typeof value === 'string') {
                var itemstring = { string: value, headers, fieldName: name };
                return itemstring;
            }

            if (value instanceof Blob && typeof value.type === 'string' && value.type == 'application/json') {

                headers['content-type'] = value.type;
                var str = await this.readBlob(value);
                return { string: str, headers, fieldName: name };
            }

            // The body part is a "blob", which in React Native just means
            // an object with a `uri` attribute. Optionally, it can also
            // have a `name` and `type` attribute to specify filename and
            // content type (cf. web Blob interface.)
            if (typeof value.name === 'string') {
                headers['content-disposition'] += '; filename="' + value.name + '"';
            }
            if (typeof value.type === 'string') {
                headers['content-type'] = value.type;
            }

            return { ...value, headers, fieldName: name };
        }));
    }

I'm continuing to investigate.
If I'm not able to resolve this standardization issue, I will close the PR.
Sebastien


Tenant issues list

Tenants' issues list now displays with some hard written fakeData.

Damnit. Meant to choose Dev as base.


Problem with Gitlab private registry and Swarm Stack using web editor

Before you start please confirm the following.

[X] Yes, I've searched similar issues on GitHub.
[X] Yes, I've checked whether this issue is covered in the Portainer documentation or knowledge base.

Problem Description
For a long time now, creating a stack using the web editor and filling a docker-compose in using a private registry which is existing in the Registries menu and that we can browse normally and see the related image, does not work as attended.
Stack fails to deploy with the following error :
Feb  7 09:23:15 docker dockerd[3741060]: time="2024-02-07T09:23:15.056607119+01:00" level=error msg="Not continuing with pull after error: errors:\ndenied: requested access to the resource is denied\nunauthorized: authentication required\n"
Feb  7 09:23:15 docker dockerd[3741060]: time="2024-02-07T09:23:15.057113552+01:00" level=info msg="Ignoring extra error returned from registry" error="unauthorized: authentication required"
Feb  7 09:23:15 docker dockerd[3741060]: time="2024-02-07T09:23:15.060066974+01:00" level=error msg="pulling image failed" error="pull access denied for registry.gitlab.com/toto/toto_project/toto-img, repository does not exist or may require 'docker login': denied: requested access to the resource is denied" module=node/agent/taskmanager node.id=os43f7oac0t1ldwqn6i6gxd3g service.id=hyz3frcbj571blhnbhnh0g58e task.id=xmwjcgjpfxvi6jzep19q0y62z
Feb  7 09:23:15 docker dockerd[3741060]: time="2024-02-07T09:23:15.060366644+01:00" level=error msg="fatal task error" error="No such image: registry.gitlab.com/toto/toto_project/toto-img" module=node/agent/taskmanager node.id=os43f7oac0t1ldwqn6i6gxd3g service.id=hyz3frcbj571blhnbhnh0g58e task.id=xmwjcgjpfxvi6jzep19q0y62z

Even if we try to do a docker login, same error is logged without the "repository does not exist or may require 'docker login'" log.
Sometimes, it works for a couple of days before being stuck again with these errors at the next webhook or manual polling.
The same container is successfully deployed if using Services and choosing the registry in the UI, instead of Stack which does not permit to use docker compose.
It sounds like the stack is not able to successfully use Registries credentials added successfully to portainer.
Expected Behavior
Stack is successfully deployed using the Registries set in Portainer and the associatied token with no error.
Actual Behavior
Stack is not successfully deployed using the Registries set in Portainer and the associatied token with authorization / authentication errror.
Steps to Reproduce

Add a private gitlab registry using the Registries menu with a token that allow to use images (or with all permission, same result)
Deploy a stack with the web editor using an image in the previously created gitlab registry as a container image
Stack fails to deploy the image with the previous authentication/authorization error

Portainer logs or screenshots
Feb  7 09:23:15 docker dockerd[3741060]: time="2024-02-07T09:23:15.056607119+01:00" level=error msg="Not continuing with pull after error: errors:\ndenied: requested access to the resource is denied\nunauthorized: authentication required\n"
Feb  7 09:23:15 docker dockerd[3741060]: time="2024-02-07T09:23:15.057113552+01:00" level=info msg="Ignoring extra error returned from registry" error="unauthorized: authentication required"
Feb  7 09:23:15 docker dockerd[3741060]: time="2024-02-07T09:23:15.060066974+01:00" level=error msg="pulling image failed" error="pull access denied for registry.gitlab.com/toto/toto_project/toto-img, repository does not exist or may require 'docker login': denied: requested access to the resource is denied" module=node/agent/taskmanager node.id=os43f7oac0t1ldwqn6i6gxd3g service.id=hyz3frcbj571blhnbhnh0g58e task.id=xmwjcgjpfxvi6jzep19q0y62z
Feb  7 09:23:15 docker dockerd[3741060]: time="2024-02-07T09:23:15.060366644+01:00" level=error msg="fatal task error" error="No such image: registry.gitlab.com/toto/toto_project/toto-img" module=node/agent/taskmanager node.id=os43f7oac0t1ldwqn6i6gxd3g service.id=hyz3frcbj571blhnbhnh0g58e task.id=xmwjcgjpfxvi6jzep19q0y62z

Portainer version
2.19.4
Portainer Edition
Business Edition (BE/EE) with Starter Plus license
Platform and Version
Docker Swarm 24.0.7
OS and Architecture
Debian 11.8 AMD64
Browser
Chrome 121
What command did you use to deploy Portainer?
version: '3.8'

services:
  appv2:
    image: registry.gitlab.com/toto/toto_project/toto-img:latest
    restart: always
    ports:
      - "6889:443"
    extra_hosts:
      - "toto.toto.chc:<IP_ADDRESS>"
    deploy:
      resources:
        limits:
          cpus: '6'
          memory: 2048M
      update_config:
        order: start-first
      restart_policy:
        condition: any

Additional Information
We did a new fresh install of Portainer 2.19.4, the result is exactly the same.

I'm experiencing the same error in the same conditions, I can't pull my private images

Similar issue with private self-hosted gitlab instance, and multiple registries from the same instance with different access tokens.

I have the same issue too, can we have an update on this please ?

Hi,
Any news on that issue please ?
Thanks

Having the same issue. Multiple environments and each environment has one or two stacks. Each registry is for each stack but when I check into images I see preselected different registries.

Keep having this issue in the latest LTS 2.21.4, still cannot used stack with private gitlab registry.


How to deploy to Docker ?

I try to follow instructions from nextJS docs but it does not found the node_modules from packages/app so I tries to do a local build with minimun steps to copy standalone and public folder into docker and after that run the serve.js but it fails to load dependencies.
Here mi docker file:
FROM node:16-alpine
WORKDIR /app

ENV NODE_ENV production
# Uncomment the following line in case you want to disable telemetry during runtime.
# ENV NEXT_TELEMETRY_DISABLED 1

RUN addgroup --system --gid 1001 nodejs
RUN adduser --system --uid 1001 nextjs

# You only need to copy next.config.js if you are NOT using the default configuration
COPY  next.config.js ./
COPY public ./public
COPY package.json ./package.json

# Automatically leverage output traces to reduce image size
# https://nextjs.org/docs/advanced-features/output-file-tracing
COPY .next/standalone ./
COPY .next/static ./.next/static

USER nextjs

EXPOSE 3000

ENV PORT 3000

CMD ["node", "server.js"]

(Im a Mobile developer so i dont have much experience with web envs)

Hi, a few things:

why are you using docker for this? i think it’s too complicated, I think you should just use Vercel
have you tried using the starter app?

Mi Infrastructure is based on DigitalOcean Kubernetes, thats why im using Docker, same behaviour with starter app.

this isn't something I'll be able to help with. I also don't exactly understand why a Next.js app would need such a complicated setup instead of just using Vercel, but I'll move this to a discussion


Getting " error LNK2005" on Windows

In my project, I checkout spdlog & spdlog_setup as submodules and use add_subdirectory to add them to my project. This works fine on all platforms, but on Windows I get:
spdlogd.lib(fmt.obj) : error LNK2005: "public: void __cdecl fmt::v6::internal::error_handler::on_error(char const *)" (?on_error@error_handler@internal@v6@fmt@@QEAAXPEBD@Z) already define
d in gateway_main.obj [C:\Users\gegles\Workspaces\ibm\fasp.io\_builds\windows-vs\cpp\gateway\fasp.io-gateway.vcxproj]
spdlogd.lib(fmt.obj) : error LNK2005: "public: virtual __cdecl fmt::v6::format_error::~format_error(void)" (??1format_error@v6@fmt@@UEAA@XZ) already defined in gateway_main.obj [C:\Users\
gegles\Workspaces\ibm\fasp.io\_builds\windows-vs\cpp\gateway\fasp.io-gateway.vcxproj]
C:\Users\gegles\Workspaces\ibm\fasp.io\_builds\windows-vs\bin\Debug\fasp.io-gateway.exe : fatal error LNK1169: one or more multiply defined symbols found [C:\Users\gegles\Workspaces\ibm\f
asp.io\_builds\windows-vs\cpp\gateway\fasp.io-gateway.vcxproj]

I've tried different things (e.g. checkout fmt also as a submodule and use SPDLOG_FMT_EXTERNAL) but I get the same error.
Any thoughts?

This is an excerpt of my 3rdparty/CMakeLists.txt:
  ### spdlog
  option(SPDLOG_INSTALL "" ON)
  add_subdirectory(spdlog)
  set_target_properties(spdlog PROPERTIES FOLDER 3rdparty)

  ### spdlog_setup
  option(SPDLOG_SETUP_CPPTOML_EXTERNAL "Use external CPPTOML library instead of bundled" ON)
  add_subdirectory(spdlog_setup)

Even though I don't refer to any spdlog:: in main.cpp, I had to also include spdlog.h for it to work:
#include <spdlog/spdlog.h>
#include <spdlog_setup/conf.h>

So, not sure if this is still a bug....

Seems like libfmt has been somehow inlined more than once.
May I know the tag/commit versions of spdlog and spdlog_setup that you are using?

I was just able to repro this again with the latest of both projects:
 79259fdb3f57283f65185a8e41840968dae4043c 3rdparty/spdlog (v1.2.1-1017-g79259fdb)
 ebfbb0754bd194ff9417b395306acbcdf67caf4d 3rdparty/spdlog_setup (v0.3.0-1-gebfbb07)


Fix undefined location access in Window.startTimer

I have encountered some instances where if an error occurs on a timer callback after the window has been closed (from the done callback of jsdom.env), accessing the href property of window.location throws an error because location is undefined.
The thing is that stopAllTimers is called, but this callback is still being called. You can test this with http://www.github.com

The thing is that stopAllTimers is called, but this callback is still being called. You can test this with http://www.github.com

This sounds like the actual bug here. If we can repro this, we should fix that too.

Yes. In any case, nothing will be accepted without tests.

You are right, I just found out that the problem is the timer being set after the document is already deleted (probably from a callback of an ajax call). So the fix was not really solving anything.
I think the real solution would be checking for if (!window.document) at the beginning of startTimer to avoid setting new timers.
I'll try to add tests for this later, but I'm not used with the testing structure so it'll probably take me some time.


Question: Per-block vs entire-chain accumulator?

I'm still trying to understand the design here, but would it be that you have a single accumulator per block or would it be feasible to have a single accumulator for the entire chain?
Over the entire chain seems like better UX but less ideal as locating primes in that fashion feels very heavy.
Can the developers share any insights here?

Hi @SilentCicero.

but would it be that you have a single accumulator per block or would it be feasible to have a single accumulator for the entire chain?

I'm not sure if I get this question. There's only one accumulator that represents the utxo set at a given height.

Over the entire chain seems like better UX but less ideal as locating primes in that fashion feels very heavy.

Could you please clarify what you mean here? Do you mean finding a node inside the forest? We keep an index of node hashes and node positions to help with that.


RGB create to RGB crate (small typo fix)

Fixing the small documentation typo:

The RGB/RGBA pixel types are from the RGB create, ...

to

The RGB/RGBA pixel types are from the RGB crate, ...

Thanks. That's a typo I can't stop making :)


fix: subsequent requests cannot be sent until 'num_concurrent_requests' requests have all finished in non-block mode

issues
https://github.com/ray-project/llmperf/issues/43
https://github.com/ray-project/llmperf/issues/56
Summary

Subsequent requests cannot be sent until whole requests have all finished even in non-block mode.
Fixing the request launcher was challenging due to its dependency on Ray, so I used multiple threads and request launchers, each holding one client and controlling only one request.

Hey, was there any progress regarding this issue ? it seems its detrimental for the correct operation of llmperf but on the other hand no one gives it any attention.

I guess maybe it might be better to move it to a different file in an overlay manner instead of modifying the token_benchmark_ray.py file..
Anyway, I have been using llmperf well since applying this commit without any errors.

I had made a commit 5 months ago to move the prompt construction outside the send loop so the benchmark doesn't get slowed down. I didn't know this affects the num_concurrent_requests mode. Let me know if I can help in some way.

@gracehonv
I rebased my code onto your commit, and it didn't slow down.

It does look like in your commit you have prepared all of the prompts before launching all the concurrent requests so there shouldn't be any slowdown. Thanks for fixing!

The y axis is the number of concurrent requests.
The pattern on the left is with the current token_benchmark_ray, the pattern on the right is with your fix.
Thanks for the fix!

@cpwan,
Thank you for your analysis and visualization related to this PR.

@avnishn @rickyyx
Would it be possible to get this PR reviewed please? Thank you.


[RPC][GUI] Fixed netstakeweight value in getstakinginfo rpc call

closes #539
Fixed netstakeweight value in getstakinginfo rpc call

A new build of 1603d16e8e12407745b6b8b34a729a27b6e135b2 has completed succesfully!
Binaries available at https://build.nav.community/binaries/fixed-netstakeweight

A new build of 9c7cc20bb4befe8ccd737087fdf587c7fa7a1b8c has completed succesfully!
Binaries available at https://build.nav.community/binaries/fixed-netstakeweight

@aguycalled I've added the EDR to the GUI

A new build of 656034cec8cdb5cabc59061ed10b34360fb1d25a has completed succesfully!
Binaries available at https://build.nav.community/binaries/fixed-netstakeweight

should we also add the expected time for next reward?

should we also add the expected time for next reward?

Up to you guys, I think it's confusing (Use might set there for the time it says, then realize it's an estimate and won't get the stake yet) 😄

should we also add the expected time for next reward?

Up to you guys, I think it's confusing (User might set there for the time it says, then realize it's an estimate and won't get the stake yet) 😄

I changed my mind, I think we should add it 🗡
It will just be called ETA, so for sure they know it's not a fixed timer

As smaller the staker are, the more unstable will the ETA become.
But most stakers are small stakers and I would not like to get them all frustrated.
I remember Users became angry because the old ETA wasn't right.

I think we should discuss this a bit more.

maybe we can hide the information by default and let users who want to see it to activate it. then after some time we can decide based of users feedback

Sounds good

A new build of 21c9794c9a157d7c6eaff585bd1cadc5b10ea650 has completed succesfully!
Binaries available at https://build.nav.community/binaries/fixed-netstakeweight


Fix close method of pseudo modal

When removing the version flag, the actual hide-call wasn't implemented.

Hey,
thanks for your contribution.
Please move your PR to the https://github.com/shopware/platform repository, as this repo is read-only as stated in the README.


AutoGrid uses the default renderer, if a custom path is set.

Describe the bug
Having two entities Order and Customer in a Many-To-One-Relation, I use AutoGrid to display Orders and I would like to configure AutoGrid to display customer.name in the column for Customer using a custom path:
<AutoGrid
    model={OrderModel}
    service={OrderService}
    columnOptions={{
      customer: {
        path: "customer.name",
      }
    }}
/>

Unfortunately, AutoGrid keeps using the default renderer and ignores the custom path:

If I also override the default renderer by setting it to null, I get the desired result:
<AutoGrid
    model={OrderModel}
    service={OrderService}
    columnOptions={{
      customer: {
        path: "customer.name",
        renderer: null
      }
    }}
/>

Expected-behavior
AutoGrid should automatically remove the default renderer, if a custom path is set. It should be sufficient to configure a custom path. Setting the renderer to null should not be required.
Please also see the comment by @sissbruecker in this Vaadin Forum Thread, where this issue was raised as a question.
Reproduction
Create two entities like Order and Customer:
@Entity
@Table(name = "orders")
public class Order {

    @Id
    @GeneratedValue(strategy= GenerationType.IDENTITY)
    Long id;

    @NotNull
    private LocalDate created;

    @NotNull
    @ManyToOne(targetEntity = Customer.class, optional = false)
    private Customer customer;

   // Getters and Setters omitted

}

@Entity
@Table(name = "customers")
public class Customer {

    @Id
    @GeneratedValue(strategy= GenerationType.IDENTITY)
    Long id;

    @NotBlank
    String name;

    @NotBlank
    @Email
    String mail;

   // Getters and Setters omitted
}

Create a OrderService:
@BrowserCallable
@AnonymousAllowed
public class OrderService extends CrudRepositoryService<Order, Long, OrderRepository> {}

Use AutoGrid like this:
<AutoGrid
    model={OrderModel}
    service={OrderService}
    columnOptions={{
      customer: {
        path: "customer.name",
      }
    }}
/>

Actual result:

Expected result:

System Info
Hilla: 24.4.0.alpha21
Hilla CLI: 2.0.1
Java: 21.0.2
OS: macOS Sonoma 14.4.1 (23E224)

Thanks, looks like a bug indeed.
By the way, another possible workaround is to use a custom column, see https://hilla.dev/docs/react/components/auto-grid#adding-custom-columns

After fixing this, let us make sure that changing path in column options is sufficiently documented.

I would like to try and provide a pr for this, but I need a little help upfront, please. Where will I find the relevant code, that handles this logic? Is it in vaadin/hilla or is it somewhere else, like in vaadin/react-components?

The Auto* components are in the Hilla repo itself. The relevant logic should be here (see also the defaults defined in the function above): https://github.com/vaadin/hilla/blob/be9a911be3413770a16b1e2af8314434fd7adb8f/packages/ts/react-crud/src/autogrid-columns.tsx#L103-L117

Thank you @sissbruecker! I already had a look at this piece of code, but I wasn't sure, if this is the right place. I think I need to invest some time to understand how the pieces fit together.

I'm not sure which way to go here. It could be possible to do something like this:
  return customColumnOptions
    ? {
        ...typeColumnOptions,
        headerFilterRenderer,
        ...customColumnOptions,
        ...(customColumnOptions?.path && customColumnOptions.renderer === undefined) && { renderer: null }
      }
    : typeColumnOptions;

This would ensure the default renderer and would probably "fix" this issue.
Instead, we could go further, and we could create/load a ModelInfo instance for the referenced entity. This way we could determine which renderer to use, based on the type of the entity property referenced in path.

Btw, Another way of dealing with simple cases such as rendering the "customer.name" instead of the json representation of customer entities is to utilize the visibleColumns, e.g. in your case:
<AutoGrid model={OrderModel}
          service={OrderService}
          visibleColumns=['created', 'customer.name']
          columnOptions={{
              customer: {
                   header: "Customer"
              }
          }}
/>

This way, the default header filter is also working without any further efforts.


(Async non-blocking)how to check request comes, and not block current thread.

it is useful in client-update mode.
there seems no exist example use async-non-block-mode.
async-mode test code is one-ask-one-answer, which is useless.

Just to clarify, are you interested in a non-blocking check API or some sort of active notification to the current thread?

yeah, if i run an loop for my app(like game, both server&&client), i may not want to be blocked.

It's probably worth exposing the deadline from the C api up into
CompletionQueue::Next. It's there to solve this problem.
On Wed, Mar 11, 2015 at 8:14 AM w359405949<EMAIL_ADDRESS>wrote:

yeah, if i run an loop for my app(like game, both server&&client), i may
not want to be blocked.
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/1004#issuecomment-78282981.

Yup, seems like it should be a change with very few lines of code... will address.

It'll need some small amount of thought as to what the return value should
be (how do you distinguish shutdown from timeout?)
On Wed, Mar 11, 2015 at 3:18 PM Vijay Pai<EMAIL_ADDRESS>wrote:

Yup, seems like it should be a change with very few lines of code... will
address.
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/1004#issuecomment-78385019.

It will also require writing a test for this.

As for return value, I would suggest that the return value should be true (not shutdown) but the tag should be set to NULL. That way it's clear that we're not shutting down but at the same time we have nothing available for us.

NULL tag values are legal.
It almost needs to be a tri-state return value: {OK, SHUTDOWN, TIMEOUT}.
On Wed, Mar 11, 2015 at 3:46 PM Vijay Pai<EMAIL_ADDRESS>wrote:

As for return value, I would suggest that the return value should be true
(not shutdown) but the tag should be set to NULL. That way it's clear that
we're not shutting down but at the same time we have nothing available for
us.
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/1004#issuecomment-78389368.

Oops, wasn't aware that NULL was a valid tag. Ok, we need a tri-state return then.

The use case is for casting an integer index into an array into a void* as
a tag value.
On Wed, Mar 11, 2015 at 3:54 PM Vijay Pai<EMAIL_ADDRESS>wrote:

Oops, wasn't aware that NULL was a valid tag. Ok, we need a tri-state
return then.
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/1004#issuecomment-78390602.

I have created a pull request with the relevant diff, but there is no test yet for the nonblocking next case. That still needs to be written before any merge.

ok, i think i forgot something, "does non-blocking can also work in sync-mode?"

Pull request #1023 addresses this issue and hopefully will merge soon. But I'm not sure that I understand your last followup: "does non-blocking can also work in sync-mode?" I am assuming that you're referring to making client side stream read operations nonblocking - is that correct? In which cases would you like to see a nonblocking check in sync mode?

Pull request #1023 has been merged.

a nonblocking check in sync mode

For which sync operations would you like to use this check?

example:
while (reader->Read(&point)) {
point_count++;
if (!GetFeatureName(point, feature_list_).empty()) {
feature_count++;
}
if (point_count != 1) {
distance += GetDistance(previous, point);
}
previous = point;
}
i do not know how many point may read,  blocked. if all cpu_core_nums threads blocked. nothing can work now.
if a sync reader/writer can stored in a std::map/vector/set, it is more easy to understand and use for me.
a chatroom example like this:
class ChatRoom
{
public:
Status EnterRoom(request, writer) //Subscripe, rpc method from .proto
{
// check request.username, request.token.
    peer_writers.push_back(writer);
    return OK;
}

Status PeerSay(reader, response)  // rpc method from .proto
{
     std::string message;

    while(reader.Read(message)) { // more than one message.
        foreach(peer_writer : peer_writers) {
             peer_writer.Write(message);
        }
    }
     return OK;
}

private:
std::vector peer_writers;
};

and i also confused the way to use async-non-blocking.
example:
  void AsyncBidiCallback(server_stream)
{
    std::string message;
    server_stream.Read(message);
    server_stream.Write(message);
}

service_.RequestBidiStream(&srv_ctx, &srv_stream, &srv_cq_, AsyncBidiCallback);
/*
 * after a while. does it work like below?
 */
AsyncBidiCallback* callback_tag;
srv_cq_->Next(&callback_tag, &ok)
callback_tag(srv_stream);

Thanks for the detailed example! I'll follow up with you on making that work in sync mode with some nonblocking checks

The tag is just a value that you can use however you want to. You can use it as a function pointer if you like, but you can also use it for any other purpose (as it is just used in async_end2end_test.cc as an integer to check the message sequence). But the basic idea is as you described it; you call the Request for each supported RPC method with context, the reader/writer structure that you use for managing the stream, the completion queue, and the tag, and then in the future you call Next (or now AsyncNext) with a pointer for the tag and the boolean ok. You should also check the return value of Next to see if it's a shutdown situation (or timeout in the case of AsyncNext).

so.....it's weird.
first, server_cq_, it may mixed variable tags(callbacks), i do not know the diffrences of tags(define a Closure and call Run, like protobuf2 did?).
second, before i recieve an async call, i must "register" a tag after call Next at evertime? i should never know when and how many times the method  will be called, and i think it should be auto finished by the protobuf(like protobuf2) or grpc.

You can use the tags for callbacks or closures if you like, but there is no requirement to do so; they are a value associated with each event for you to use as you please.
I'm going to create a new issue for the 2nd paragraph of your last request, as it's a different API feature request and likely to get forgotten if not separated.

Status report since this issue hasn't been touched in a week: the desired feature is fully in place in the async case but we have not yet decided an API for the sync case. Hope to move forward on this in the near future.

I'd like to close out this issue since it was originally about the async API. I will open up a new issue for the sync API.


feat: use DS dashboard for switches/config

Purpose
Closes #3
Todo

[ ] Dashboard Layout

[x] Camera
[x] Autonomous Enabled
[ ] Autonomous Mode
[ ] Autonomous Mode Options
[x] Autonomous Delay
[x] Demo Enabled
[ ] Drivetrain thing
[x] Field

NOTE: actual implementation of this will be done in a separate issue (to be linked)

[ ] Dashboard Subsystem

[x] Get if autonomous is enabled
[x] Get autonomous mode
[ ] Get autonomous mode options
[x] Get autonomous delay
[x] Get demo mode enabled
[x] Set autonomous modes
[ ] Set autonomous mode options

[ ] Handle autonomous mode in robot container

[x] If autonomous is enabled, return the correct autonomous command
[ ] Also inject autonomous mode options

[ ] AutonomousCommandBase

[ ] Add methods for updating mode options

After some more research, I am looking back at Sendable Choosers
This looks like it might be able to let me populate options, and I will test when I get to the lab tonight.

After more testing at the lab, LabView is being a real pain...I am looking into using shuffleboard or something different that is eons easier to work with.

I am going ahead with Shuffleboard, and I am making good progress

Currently most things are working, however it appears that when the autonomous mode is updated (via combobox), the program crashes. More information attached for future reference.
Unhandled exception: java.util.ConcurrentModificationException
   from: java.base/java.util.ArrayList$Itr.checkForComodification(Unknown Source)
     at: at java.base/java.util.ArrayList$Itr.checkForComodification(Unknown Source)
     at: at java.base/java.util.ArrayList$Itr.next(Unknown Source)
     at: at edu.wpi.first.wpilibj.shuffleboard.ShuffleboardTab.buildInto(ShuffleboardTab.java:144)
     at: at edu.wpi.first.wpilibj.shuffleboard.ShuffleboardInstance.update(ShuffleboardInstance.java:64)
     at: at edu.wpi.first.wpilibj.shuffleboard.Shuffleboard.update(Shuffleboard.java:67)
     at: at edu.wpi.first.wpilibj.IterativeRobotBase.loopFunc(IterativeRobotBase.java:388)
     at: at edu.wpi.first.wpilibj.TimedRobot.startCompetition(TimedRobot.java:131)
     at: at edu.wpi.first.wpilibj.RobotBase.runRobot(RobotBase.java:365)
     at: at edu.wpi.first.wpilibj.RobotBase.startRobot(RobotBase.java:453)
     at: at frc.robot.Main.main(Main.java:29)

Error at java.base/java.util.ArrayList$Itr.checkForComodification(Unknown Source): Unhandled exception: java.util.ConcurrentModificationException
at java.base/java.util.ArrayList$Itr.checkForComodification(Unknown Source)
at java.base/java.util.ArrayList$Itr.next(Unknown Source)
at edu.wpi.first.wpilibj.shuffleboard.ShuffleboardTab.buildInto(ShuffleboardTab.java:144)
at edu.wpi.first.wpilibj.shuffleboard.ShuffleboardInstance.update(ShuffleboardInstance.java:64)
at edu.wpi.first.wpilibj.shuffleboard.Shuffleboard.update(Shuffleboard.java:67)
at edu.wpi.first.wpilibj.IterativeRobotBase.loopFunc(IterativeRobotBase.java:388)
at edu.wpi.first.wpilibj.TimedRobot.startCompetition(TimedRobot.java:131)
at edu.wpi.first.wpilibj.RobotBase.runRobot(RobotBase.java:365)
at edu.wpi.first.wpilibj.RobotBase.startRobot(RobotBase.java:453)
at frc.robot.Main.main(Main.java:29)
The robot program quit unexpectedly. This is usually due to a code error.
The above stacktrace can help determine where the error occurred.
See https://wpilib.org/stacktrace for more information.
Warning at edu.wpi.first.wpilibj.RobotBase.runRobot(RobotBase.java:379): The robot program quit unexpectedly. This is usually due to a code error.
The above stacktrace can help determine where the error occurred.
See https://wpilib.org/stacktrace for more information.
The startCompetition() method (or methods called by it) should have handled the exception above.
Error at edu.wpi.first.wpilibj.RobotBase.runRobot(RobotBase.java:386): The startCompetition() method (or methods called by it) should have handled the exception above.

Everything should be done, pending some testing.

ok more testing done and it's basically ready, just need to adjust positions/sizes of certain elements, then it will be ready for merge


Failed Test PR #9 - Error on yarn build (Dexalot)

Summary and Screenshots
Getting this error when trying to execute yarn build using the latest commit 6e541a8.

Steps To Reproduce

Clone gateway and checkout on this branch
On the gateway directory run yarn and yarn build afterwards

Test Result Comparison

Attachments
N/A

@rxlxrxsx Pls confirm that issue is fixed

Tested on commit 9875184 and confirmed fixed.


Recompiles workspace crates every time

Currently, running cargo llvm-cov run recompiles the workspace crates every time, making merging multiple runs with --no-report and --no-run --html unfeasible.

Could you provide an example to reproduce this?
Also, old results will be removed unless you pass --no-report to cargo llvm-cov run.
cargo llvm-cov run --no-report -- a
cargo llvm-cov run --no-report -- b
cargo llvm-cov --no-run --html

I've got the repro ready and then tried putting --no-report after run, and it worked!
Might still be unexpected behaviour however, that:

--no-report before run is silently ignored and
--no-report affects whether a rebuild happens

--no-report before run is silently ignored and

This is https://github.com/taiki-e/cargo-llvm-cov/issues/151, and will be fixed by https://github.com/taiki-e/cargo-llvm-cov/pull/197

--no-report affects whether a rebuild happens

readme example describes cargo llvm-cov clean as a command to remove artifacts.

This is https://github.com/taiki-e/cargo-llvm-cov/issues/151, and will be fixed by https://github.com/taiki-e/cargo-llvm-cov/pull/197

:+1:

readme example describes cargo llvm-cov clean as a command to remove artifacts.

Sorry if I wasn't clear - I've already figured out how to do / not do a rebuild, but it's still unexpected for a new user that adding --no-report will also change the build behaviour (it will force a rebuild every time).

I've already figured out how to do / not do a rebuild, but it's still unexpected for a new user that adding --no-report will also change the build behaviour (and not just whether a report is generated)

Indeed. Adding a document to mention it seems like a good idea.

I see that the workspace's bin crates are recompiled everytime as well. I can reproduce with the provided repro repo.
My usage:
while :; do cargo llvm-cov --all-targets --all-features --locked --frozen; done

# Note: plain cargo test call does not recompile things:
while :; do cargo test --all-targets --all-features --locked --frozen; done

Please advise.

@fenollp adding --no-report should help. In my cases, I've ended up running it once and then running the compiled binary multiple times directly during my integration tests.

Added --no-clean flag as a workaround for this. See #214 for more.


remove unuse import jsonFormat

#8477
@caishunfeng
it removes unuse import jsonFormat

Codecov Report

Merging #8548 (4e5ec0e) into dev (4a4acce) will decrease coverage by 0.01%.
The diff coverage is n/a.

:exclamation: Current head 4e5ec0e differs from pull request most recent head 0d62256. Consider uploading reports for the commit 0d62256 to get more accurate results

@@             Coverage Diff              @@
##                dev    #8548      +/-   ##
============================================
- Coverage     45.25%   45.23%   -0.02%
+ Complexity     4041     4039       -2
============================================
  Files           690      690
  Lines         26873    26873
  Branches       2884     2884
============================================
- Hits          12161    12157       -4
- Misses        13564    13566       +2
- Partials       1148     1150       +2

Impacted Files
Coverage Δ

...apache/dolphinscheduler/api/dto/ScheduleParam.java
0.00% <ø> (ø)

...rg/apache/dolphinscheduler/api/dto/gantt/Task.java
0.00% <ø> (ø)

...he/dolphinscheduler/api/dto/treeview/Instance.java
0.00% <ø> (ø)

...he/dolphinscheduler/common/model/DateInterval.java
38.88% <ø> (ø)

...g/apache/dolphinscheduler/common/model/Server.java
0.00% <ø> (ø)

...lphinscheduler/common/model/WorkerServerModel.java
0.00% <ø> (ø)

...e/dolphinscheduler/dao/entity/CycleDependency.java
0.00% <ø> (ø)

...apache/dolphinscheduler/dao/entity/DataSource.java
73.17% <ø> (ø)

...e/dolphinscheduler/dao/entity/DqExecuteResult.java
0.00% <ø> (ø)

...pache/dolphinscheduler/dao/entity/Environment.java
100.00% <ø> (ø)

... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a4acce...0d62256. Read the comment docs.


Unexpected messages are logged at startup

Hi
When I restart node-red then it is logging several messages related to the [Slack Bot In] and [Slack Bot Out] which are a bit concerning.
E.g.

Welcome to Node-RED
31 Jan 23:57:03 - [info] Node-RED version: v0.17.5
31 Jan 23:57:03 - [info] Node.js  version: v4.8.4
31 Jan 23:57:03 - [info] Linux 4.9.24-v7+ arm LE
31 Jan 23:57:04 - [info] Loading palette nodes
31 Jan 23:57:09 - [info] Dashboard version 2.6.1 started at /ui
31 Jan 23:57:17 - [info] Settings file  : /home/pi/.node-red/settings.js
31 Jan 23:57:17 - [info] User directory : /home/pi/.node-red
31 Jan 23:57:17 - [info] Flows file     : /home/pi/.node-red/flows_pi3one.json
31 Jan 23:57:17 - [info] Server now running at http://<IP_ADDRESS>:1880/
31 Jan 23:57:18 - [info] Starting flows
31 Jan 23:57:21 - [info] [Slack Bot In:stemija slackbot] IN: new slack session
31 Jan 23:57:21 - [info] [Slack Bot In:stemija slackbot] Slack not connected
[Wed Jan 31 2018 23:57:21 GMT+0100 (CET)] INFO Connecting...
31 Jan 23:57:21 - [info] [Slack Bot Out:stemija slackbot response] OUT: using an old slack session
31 Jan 23:57:21 - [info] [Slack Bot Out:stemija slackbot response] Slack already connected
31 Jan 23:57:29 - [warn] [google-credentials:6e76318c.44294] trying to refresh token due to expiry
31 Jan 23:57:30 - [info] Started flows
31 Jan 23:57:30 - [info] [slack:#cv channel] {[deleted part json msg]}
...
31 Jan 23:57:30 - [info] [mqtt-broker:9c9ae2bc.63652] Connected to broker: mqtt://<IP_ADDRESS>:1883
31 Jan 23:57:30 - [info] [Slack Bot In:stemija slackbot] in: Logged in:
31 Jan 23:57:31 - [info] [Slack Bot In:stemija slackbot] Slack already connected
31 Jan 23:57:31 - [info] [Slack Bot Out:stemija slackbot response] Slack already connected

Especially the last 2 messages are strange.  Why is it saying that it is already connected ?
For each connection, I would expect a single message like it is done for the mqtt-broker (see above).
kr
Jan

Resolved by 2.0.0.


why i cant see peer's video using RTCMultiConnection

why i cant see peer's video using RTCMultiConnection.
i use RTCMultiConnection in my web.and set stun and turn server as demos.that is
var iceServers = [];
    iceServers.push({
        url: 'stun:stun.l.google.com:19302'
    });

    iceServers.push({
        url: 'stun:stun.anyfirewall.com:3478'
    });

			iceServers.push({
			    url: 'turn:webrtcweb.com:3478', //ori is 3478
			    username: 'muazkh',
			    credential: 'muazkh'
			});

			iceServers.push({
			    url: 'turn:webrtcweb.com:5349', //ori is 5349
			    username: 'muazkh',
			    credential: 'muazkh'
			});

			iceServers.push({
			    url: 'turn:webrtcweb.com:5544', //new added part
			    username: 'muazkh',
			    credential: 'muazkh'
			});

and we chat in different city.and we cant chat in any way.
Is the stun or turn server urls right?thanks

有 qq吗？ ｄｏ　ｙｏｕ　ｈｖａｅ　ＱＱ？


Some errors when using multi-GPU

I try to train by using multi-GPU. When I test it, there are some problems:

When options -nparallel 2 and -gpuid 14 are set, the first GPU and the second GPU are used.(I have 16 GPUs.) So I can't set the specific GPU when using multi-GPU. The first and the second GPU are running other programs. And here is error:

Loading data from './data/test-train.t7'...

vocabulary size: source = 10002; target = 10004
additional features: source = 0; target = 0
maximum sequence length: source = 50; target = 51
number of training sentences: 9453
maximum batch size: 16
Building model...
using input feeding
Initializing parameters...
number of parameters: 28777004
Preparing memory optimization...
sharing 70% of output/gradInput tensors memory between clones
Start training...

/home/beichao/torch/install/bin/lua: ./onmt/train/Optim.lua:83: Assertion `THCTensor_(checkGPU)(state, 1, self)' failed.  at /home/beichao/torch/extra/cutorch/lib/THC/generated/../generic/THCTensorMathReduce.cu:180
stack traceback:
[C]: in function 'norm'
./onmt/train/Optim.lua:83: in function 'prepareGrad'
train.lua:294: in function 'trainEpoch'
train.lua:411: in function 'trainModel'
train.lua:548: in function 'main'
train.lua:551: in main chunk
[C]: in function 'dofile'
...chao/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:145: in main chunk
[C]: in ?

When options -nparallel 2, -gpuid 14 and -async_parallel are set, the first GPU and the second GPU are still used. It can run first epoch but when saving the model, there is an error:

Loading data from './data/test-train.t7'...

vocabulary size: source = 10002; target = 10004
additional features: source = 0; target = 0
maximum sequence length: source = 50; target = 51
number of training sentences: 9453
maximum batch size: 16
Building model...
using input feeding
Initializing parameters...
number of parameters: 28777004
Preparing memory optimization...
sharing 70% of output/gradInput tensors memory between clones
Start training...

Epoch 1 ; ... batch 50/610
Epoch 1 ; ... batch 100/610
Epoch 1 ; ... batch 150/610
Epoch 1 ; ... batch 200/610
Epoch 1 ; ... batch 250/610
Epoch 1 ; ... batch 300/610
Epoch 1 ; ... batch 350/610
Epoch 1 ; ... batch 400/610
Epoch 1 ; ... batch 450/610
Epoch 1 ; ... batch 500/610
Epoch 1 ; ... batch 550/610
Epoch 1 ; ... batch 600/610
Epoch 1 ; Iteration 612/610 ; Learning rate 1.0000 ; Source tokens/s 620 ; Perplexity 10669.35
Saving checkpoint to 'en2zh_test_model_checkpoint.t7'...
/home/beichao/torch/install/bin/lua: ./onmt/utils/Tensor.lua:81: Assertion `THCTensor_(checkGPU)(state, 1, self_)' failed.  at /home/beichao/torch/extra/cutorch/lib/THC/generic/THCTensorMath.cu:21
stack traceback:
[C]: in function 'zero'
./onmt/utils/Tensor.lua:81: in function 'reuseTensor'
./onmt/utils/Tensor.lua:120: in function 'initTensorTable'
./onmt/modules/BiEncoder.lua:118: in function 'forward'
train.lua:166: in function 'eval'
train.lua:413: in function 'trainModel'
train.lua:548: in function 'main'
train.lua:551: in main chunk
[C]: in function 'dofile'
...chao/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:145: in main chunk
[C]: in ?
In a word, I meet the same problems when I train by synchronous parallelism and asynchronous parallelism, can't specify the GPUs and Assertion `THCTensor_(checkGPU)(state, 1, self_)' failed. Anyone can help me? Thanks anyway.

Yes that is an issue if GPUs can't be set.
@jsenellart-systran Maybe we should drop the -nparallel option and support a list of comma-separated GPU identifiers with -gpuid. What do you think?

actually, the problem can be fixed by using CUDA_VISIBLE_DEVICES=xx,yy and then set -gpuid 1 (the 1 here will be xx, and the second GPU used with be yy)
In any case this method is preferable otherwise you will be using some memory on all GPUs.
@guillaumekln - I do like however, your suggestion too - so we can drop -nparallel that is replaced by the list on the -gpuid option. but here also we need to combine with CUDA_VISIBLE_DEVICES (except if we can programmatically do that before loading cutorch?

Right. Then dropping -nparallel is not so nice because GPU identifiers need to be listed in -gpuid and CUDA_VISIBLE_DEVICES.
I will document the use of CUDA_VISIBLE_DEVICES in the guide.

Thanks！
I just set -gpuid 1, and there is no error. But if gpuid > 1, the first and the second gpu are used, then the error is appeared.

I am not sure to understand, I recommend using -gpuid 1 and control the actual GPU with CUDA_VISIBLE_DEVICES - does this work?

When I set -gpuid 1 and control the actual GPU with CUDA_VISIBLE_DEVICES, it works well. But there is an error when I set -gpuid 2 and CUDA_VISIBLE_DEVICES=1, 14. Do I have to set -gpuid 1 when using multi-GPU?

Yes - it was designed like that and there is no constraint since you can even order CUDA_VISIBLE_DEVICES differently if you need.
More generally, I think we need to think more about the option -gpuid 1 and how to use it. I will think more about it. Thanks for your testing.

Thanks for your reply !


new PR for the PostgreSQL Direct Queries

@wtrocki I hope now things are at there place

Unit tests are missing. Additionally we will need helper to consume this class as the other data providers. Finally we should move to use this provider in sample app

Thanks for update sir

I'll return to you asap

@jaskeerat789 Sorry for closing this PR. We have some internal chat and decided that we will hold of with PostgreSQL integration until we make some other internal changes. Thank you so much for contribution


parse-input not working

I use parse-input="parseInput()", but the function I add on the $scope is not called.
I have tried to use focus-in and it's working.
So, it's seems the angucomplete-alt not handling this attribute.
<div  			angucomplete-alt id="ex1"   			placeholder="Search contact"   			maxlength="255"   			pause="200"   			selected-object="selectedContact"   			remote-url="/phone-book/top10?contact="   			search-fields="phoneName"   			title-field="phoneName"   			description-field="phoneNumber"   			minlength="1"   			input-class="form-control form-control-small"   			match-class="highlight"   			input-name="contact"   			field-required="true"   			parse-input="parseInput()"   			focus-in="focusIn()">   		</div>
	    $root.parseInput = function(){ 	    	console.log("parseInput called..."); 	    }

I've never seen that you can define a function under $root object.
Does it really work?
Usually, you inject $rootScope and define something under $rootScope.

I am sorry, somethings modify the $rootScope into $root during the copy-paste.
Of course the usage of $root not working :D
In my code I use $rootScope, but the parse-input attribute not working. The injected callback function doesn't called.

What is not working?
parseInput is a function that needs to take a string and returns a string.
By the way, I should update the README on how to use parseInput.
If your parseInput is like you described, it won't do anything good but harm as it does not return anything.

I have try to use parseInput to take a string as input and returns a string.
$rootScope.parseInput = function(data){ console.log("parseInput called..."); return data; }
But the parseInput function still not called.

What version of angucomplete-alt.js are you using?

I use 2.2.0 version from CDN https://cdnjs.cloudflare.com/ajax/libs/angucomplete-alt/2.2.0/angucomplete-alt.min.js

parseInput is working as you can see in this example:
http://plnkr.co/edit/Gq0529?p=preview
If you create your example, I can have a look.

Yes, it's absolutely working.
I'v tried to copy and paste your code, but not working yet.
I think something wrong with my code.
But I know now that parse-input attribute is actually working.
So, thank you very much for your help.


Cow: Watch digimanzil.com

Cow requests the watch of the watch_keyword digimanzil\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

digimanzil\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by VLAZ in Charcoal HQ


GCW has NA Instrument names

@bpbond also just realized my x axis is incorrectly ordered, any thoughts on how to fix this?
 mutate(
           ts_str = format(date, "%b-%Y"),
           ts_fct = factor(ts_str, levels = unique(ts_str)))

arrange(date) %>%
mutate(
           ts_str = format(date, "%b-%Y"),
           ts_fct = factor(ts_str, levels = unique(ts_str)))

?

Hmmm no, the dataset is arranged correctly with this but is graphing the same. I just pushed up availability_graph.R to heatmap branch if you want to take a look at the entire code

See PR! I didn't test it on the full dataset though—please lmk if it doesn't fix things

Fixed in #206


[read/write set] handle addresses flowing into/out of structs via pac…

…k and unpack
Previously, the read/write set analysis treated packs and unpacks as no-ops. However, this is incorrect
because the analysis must track addresses flowing into and out of structs.
This PR adds support for pack and unpack in the natural way by:

adding each packed field of type struct or address to the locals trie
adding each unpacked field of type struct or address to the locals trie

In the process of supporting pack/unpack, I uncovered a bug in AccessPath::substitute_footprint (see the use_results function in pack_unpack.move and the TODO in access_path.rs). Fixing this bug will require a fairly significant refactoring, so I will defer it to a subsequent PR.

CC @danhper

:exclamation: Invalid command

Bors help and documentation

Bors is a Github App used to manage merging of PRs in order to ensure that CI is always green. It does so by maintaining a Merge Queue. Once a PR reaches the head of the Merge Queue it is rebased on top of the latest version of the PR's base-branch (generally master) and then triggers CI. If CI comes back green the PR is then merged into the base-branch. Regardless of the outcome, the next PR is the queue is then processed.
General

This project's Merge Queue can be found here.
This project requires PRs to be Reviewed and Approved before they can be queued for merging.
Before PR's can be merged they must be configured with "Allow edits from maintainers" enabled. This is needed for Bors to be able to update PR's in-place so that Github can properly recognize and mark them as "merged" once they've been merged into the upstream branch.

Commands
Bors actions can be triggered by posting a comment which includes a line of the form /<action>.

Command
Action
Description

Land
land, merge
attempt to land or merge a PR

Canary
canary, try
canary a PR by performing all checks without merging

Cancel
cancel, stop
stop an in-progress land

Cherry Pick
cherry-pick <target>
cherry-pick a PR into <target> branch

Priority
priority
set the priority level for a PR (high, normal, low)

Help
help, h
show this help message

Options
Options for Pull Requests are configured through the application of labels.

          Option
Description

Indicates that the PR is high-priority. When queued the PR will be placed at the head of the merge queue.

Indicates that the PR is low-priority. When queued the PR will be placed at the back of the merge queue.

Before merging the PR will be squashed down to a single commit, only retaining the commit message of the first commit in the PR.

/land

:broken_heart: Test Failed - ci-test

/land

@sblackshear :exclamation: This PR is still missing approvals, unable to queue for landing

/land

:broken_heart: Test Failed - ci-test

/land

/cancel

/land


Substitute murmurHash32 for spark32BitMurmurHash3 [databricks]

Fixes #10487
Signed-off-by: Gera Shegalov<EMAIL_ADDRESS>

build

build

CI failed due to #10656

build