Change SpanData to use span name instead of display name.

Codecov Report

Merging #423 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #423   +/-   ##
=========================================
  Coverage     90.15%   90.15%
  Complexity      581      581
=========================================
  Files           100      100
  Lines          2051     2051
  Branches        210      210
=========================================
  Hits           1849     1849
  Misses          148      148
  Partials         54       54

Impacted Files
Coverage Δ
Complexity Δ

...main/java/io/opencensus/trace/export/SpanData.java
100% <ø> (ø)
2 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec7ae97...359da78. Read the comment docs.


Can parquet-dotnet be use to serialize a Web API response?

Question -
Can parquet-dotnet be use in Web API to serialize responses?
I am wondering if it can be use like protobuf, messagepack or any other format.

You can definitely do that, however it won't be very effective. Where parquet really shines is querying relatively large amounts of data. In fact, parquet stores it's own metadata in the file in Thrift format (similar to protobuf). Writing parquet is CPU intensive due to logical and physical compression.
For general purpose web API i'd go for protobuf or thrift (although later is poorly supported/designed on .net as I found out when building parquet). You can also look at Google Flatbuffers if speed is an issue, it's used in Apache Arrow and is generally faster than Thrift. Protobuf has excellent tooling for IDEs like VS and good fast libraries (see protobuf-net).

@bryanjhogan yes makes perfect sense, I just checked that we don't actually rely on generics internally, it's only used in public method signature, so adding an overload should be trivial.

That would be a helpful addition to the ParquetConvert class.

will be fixed as a part of bigger issue


Fixed #25361: Unpickling of QuerySet fails in presence of abstract intermediate model

This is to fix this issue with pickling fields on abstract models.
https://code.djangoproject.com/ticket/25361#comment:2

I should mention this is a little ugly in how it resolves the issue by using import_string, but I'm not sure how to get around it. On the plus side it will resolve it for most cases where this is a problem. But if you inherit from an abstract models that is outside of models.py you will run into issues.
Feedback appreciated.

I think we need a programmatic way to retrieve the path of an abstract model, not just a way that guesses the path. By the way, the pull request should go to master and include a test, perhaps in tests/model_regress/test_pickle.py.
If it's not a regression from a previous release or a major bug in a new feature it won't be backported. See our supported versions policy.

I'd be happy to add a test and find a cleaner method of doing this, I just wanted a few pointers.
However, I need this in v1.8 as I can't upgrade and 1.8 is in LTS. If I have to spend a half a day working out a solution, I'd rather one I can use in the more immediate future (eg. for 1.8) rather than one I can use as some indefinite point in time (eg. master, 1.10, etc...).

Nevermind - I have a monkey patch working which should work until the bug is fixed or I upgrade. Thanks anyway. https://gist.github.com/LegoStormtroopr/f014801e63474971e7ffc23980f0b1d1


docs(content): fix typo "need" in docs

Short description of what this resolves:
A simple, easily missed typo in ion-content docs: simply adds correct tense to "need" in description, first paragraph.
Changes proposed in this pull request:

replace "need" with "needed"

Ionic Version: 2.x / 3.x

Thanks! 🙂


dein does not automatically delete commented out packages

Problems summary
If you install a plugin with dein#add('some/repo') and then later comment out the line, dein will not detect the changes to the vimrc and therefore not recache.
Expected
Commenting out the line should cause a recache.
Environment Information

OS: macOS 10.12.1
Vim version: 8.0.106

Provide a minimal .vimrc with less than 50 lines (Required!)
" Your minimal .vimrc
set runtimepath^=~/path/to/dein.nvim/
call dein#begin(path)
call dein#add('Shougo/neosnippet')
call dein#end()

The reproduce ways from Vim starting (Required!)

run the above vimrc
comment out the call dein#add('Shougo/neosnippet')
rerun the above vimrc

There will be no recaching.

dein merge plugin by default. and the cache will not autoupdate. if you do not want to merge plugin, use {'merge':0}

I cannot reproduce the problem.
The recache works.
I think your dein.vim is old.


Unipop Elasticsearch plugin working only on 10000 docuements

I have an index where one field has has a value of  department in which the employee is present in.
Below is present Unipop elasticsearch configurations
{
  "class": "org.unipop.elastic.ElasticSourceProvider",
  "addresses": "http://<IP_ADDRESS>:6968",
  "vertices": [
    {
      "index": "employee_records",
      "id": "@department",
      "label": "hastags",
      "properties": {
        "value": "@department"
      }
    },
    {
      "index": "employee_records",
      "id": "@unique",
      "label": "unique",
      "properties": {
        "value": "@unique"
      }
    }
  ],
  "edges": [
    {
      "index": "employee_records",
      "id": "@_id",
      "label": "connects",
      "properties": {},
      "outVertex": {
        "ref": true,
        "id": "@unique",
        "label": "unique"
      },
      "inVertex": {
        "ref": true,
        "id": "@department",
        "label": "hastags"
      }
    }
  ]
}

And below are results
{v[Tech]=3159, v[Analysis]=3726, v[Admin]=2111, v[Support]=1003}
And Here is my gremlin query => g.V().outE('connects').inV().groupCount()
There are total of 65000 employee records. But the above result totals to 9999
In my above configurations i have mapped department of employees with employee id.
So count of all the departments should total out to 9999 whereas it should be 65000.
This means that unipop is picking only 10000 documents from elasticsearch.
This might me due to limit of elasticsearch of fetching 10000 documents in one request and scroll api is not been used.

@babiy8 @eyalmar100  didn't you recently add support for the scroll API?

The problem is still there of only 10000 documents being fetched from elasticsearch. Can anyone help?

@HenShalom is this bug happening to you as well?

Hi
My name is Eyal, and I'm one of the developers of Unipop.
Do you want to send me all the necessary details of your project to my email ?
I will try to reconstruct the issue and see why its not working for you.
My email is<EMAIL_ADDRESS>

This is a long shot, but in the DocumentController class there is field :
.. private final int maxLimit = 10000;
try  to change it and see what happens ..

The maxLimit field is the maximum number of documents elasticsearch can
fetch and to my knowledge we haven't implemented the scroll API yet.
On Wed, Sep 5, 2018, 5:26 PM eyalmar100<EMAIL_ADDRESS>wrote:

This is a long shot, but in the DocumentController class there is field :
.. private final int maxLimit = 10000;
try to change it and see what happens ..
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/unipop-graph/unipop/issues/135#issuecomment-418750724,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AK8elAx95dWAWUnERupyTdH7OvdgItmyks5uX98SgaJpZM4WPWlq
.

@eyalmar100 thats not a good idea, and not a scalable solution.
I know for a fact that you worked on solving this, because I sat with you and @babiy8 to solve the scroll API issues. What happened with that? did you push the needed fixes?

I didn't know why/what this field refers to .. now  I know after  @seanbarzilay  answered .
Sometime its good to have some remarks/documentation ..
Anyway, we started to implement the scroll  API , but did not finish it yet ( the scroll API is based on 'polling' mechanism)  , and we have to think how to interact/ cooperate with the 'client' to make it work right.
We will finish it soon.

@eyalmar100 If you want we can talk, before I left I had an idea on how to implement the scroll API.

@seanbarzilay  - Yes . I will be happy to talk :)
my mail is<EMAIL_ADDRESS>you can send me a message with your contacts information  ( phone , etc .)
Thanks

@eyalmar100 @babiy8  thats very unfortunate. I believe we wrote most of the code when I sat with you. You guys said you'll finish it and push it. What happened?

Hi All
Can you tell me till when the fixes would be done.
I wish to explore it further and do performance testing on large datasets

Hן
I'm exploring it , and hope it will be fixed during next week .

Great Thanks.

Hey @eyalmar100  - Is it fixed - picking all the documents matching the query from elasticsearch.
Actually I am not a developer of this and I am not familiar with its code.

Hi
Yes, its working.I tested it few times, and seems working correct.

@eyalmar100 - The problem is still there. Its still only fetching 10000 documents.
On which branch you have updated code? I am using master branch.

Hi
Yes, its in the master branch
You can validate that you use the correct code if you open the file I wrote above comment : DocumentController.java
and see the snippet  code ..
Anyway, later on ( today or by the end of week )I'm going to add some printing to console to make sure you synchronized with the correct code.
P.S
You don't have to be developer to open the file and read the code :)

Hey @eyalmar100 - The last release was 0.2.1 . Can you tell me how to install unipop-elastic  plugin not from a release but from a branch master and also add a new release , it becomes easy for everyone else who uses this.

Hi @gaurav6041 ,
you can download again all the files  ( the same way you downloaded it before - using  "download zip" file or "git clone ..")
build the elastic module ( mvn clean install) , after that , copy the output jar (  unipop-elastic-0.2.2-SNAPSHOT.jar ) to your tinkerpop folder  ( ../name_tinkerpop_folder/ext/unipop).
.

Hey @eyalmar100  Thanks.
I mentioned this because as per the wiki of the unipop , a new plugin can directly be installed using command below on tinkerpop console command -> :install com.github.unipop-graph unipop-elastic 0.2.1 .
Anyway i tried building the project , but i am getting an exception as below
Caused by: org.apache.maven.project.DependencyResolutionException: Could not resolve dependencies for project com.github.unipop-graph:unipop-elastic:jar:0.2.2-SNAPSHOT: Failed to collect dependencies for [pl.allegro.tech:embedded-elasticsearch:jar:2.1.0 (compile), org.elasticsearch.client:transport:jar:5.3.1 (compile), org.apache.logging.log4j:log4j-api:jar:2.9.1 (compile), org.elasticsearch.plugin:transport-netty4-client:jar:5.3.1 (compile), com.esotericsoftware.yamlbeans:yamlbeans:jar:1.09 (compile), com.googlecode.json-simple:json-simple:jar:1.1.1 (compile), com.github.unipop-graph:unipop-core:jar:0.2.2-SNAPSHOT (compile), org.elasticsearch:elasticsearch:jar:5.3.1 (compile), io.searchbox:jest:jar:5.3.3 (compile), org.json:json:jar:20090211 (compile)] 	at org.apache.maven.project.DefaultProjectDependenciesResolver.resolve(DefaultProjectDependenciesResolver.java:158) 	at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies(LifecycleDependencyResolver.java:185) 	... 22 more Caused by: org.sonatype.aether.collection.DependencyCollectionException: Failed to collect dependencies for [pl.allegro.tech:embedded-elasticsearch:jar:2.1.0 (compile), org.elasticsearch.client:transport:jar:5.3.1 (compile), org.apache.logging.log4j:log4j-api:jar:2.9.1 (compile), org.elasticsearch.plugin:transport-netty4-client:jar:5.3.1 (compile), com.esotericsoftware.yamlbeans:yamlbeans:jar:1.09 (compile), com.googlecode.json-simple:json-simple:jar:1.1.1 (compile), com.github.unipop-graph:unipop-core:jar:0.2.2-SNAPSHOT (compile), org.elasticsearch:elasticsearch:jar:5.3.1 (compile), io.searchbox:jest:jar:5.3.3 (compile), org.json:json:jar:20090211 (compile)] 	at org.sonatype.aether.impl.internal.DefaultDependencyCollector.collectDependencies(DefaultDependencyCollector.java:258) 	at org.sonatype.aether.impl.internal.DefaultRepositorySystem.collectDependencies(DefaultRepositorySystem.java:308) 	at org.apache.maven.project.DefaultProjectDependenciesResolver.resolve(DefaultProjectDependenciesResolver.java:150) 	... 23 more Caused by: org.sonatype.aether.resolution.ArtifactDescriptorException: Failed to read artifact descriptor for com.github.unipop-graph:unipop-core:jar:0.2.2-SNAPSHOT 	at org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.loadPom(DefaultArtifactDescriptorReader.java:331) 	at org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.readArtifactDescriptor(DefaultArtifactDescriptorReader.java:186) 	at org.sonatype.aether.impl.internal.DefaultDependencyCollector.process(DefaultDependencyCollector.java:412) 	at org.sonatype.aether.impl.internal.DefaultDependencyCollector.collectDependencies(DefaultDependencyCollector.java:240) 	... 25 more Caused by: org.apache.maven.model.resolution.UnresolvableModelException: Could not find artifact com.github.unipop-graph:unipop:pom:0.2.2-SNAPSHOT 	at org.apache.maven.repository.internal.DefaultModelResolver.resolveModel(DefaultModelResolver.java:126) 	at org.apache.maven.model.building.DefaultModelBuilder.readParentExternally(DefaultModelBuilder.java:813) 	at org.apache.maven.model.building.DefaultModelBuilder.readParent(DefaultModelBuilder.java:664) 	at org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:310) 	at org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:232) 	at org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.loadPom(DefaultArtifactDescriptorReader.java:322) 	... 28 more Caused by: org.sonatype.aether.resolution.ArtifactResolutionException: Could not find artifact com.github.unipop-graph:unipop:pom:0.2.2-SNAPSHOT 	at org.sonatype.aether.impl.internal.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:538) 	at org.sonatype.aether.impl.internal.DefaultArtifactResolver.resolveArtifacts(DefaultArtifactResolver.java:216) 	at org.sonatype.aether.impl.internal.DefaultArtifactResolver.resolveArtifact(DefaultArtifactResolver.java:193) 	at org.apache.maven.repository.internal.DefaultModelResolver.resolveModel(DefaultModelResolver.java:122) 	... 33 more

@eyalmar100 you can publish a new version to maven, so users won't have to build it themselves.
Ask @seanbarzilay for help if needed.

ok, I will do it soon, thanks

@randanman @eyalmar100  - Thanks. Please let me know when you guys publish a new version

Hi
Sure. I will update you soon  :)

@randanman @babiy8 - Can you please deploy the new version which we talked about earlier.

Hi @gaurav6041
Sorry for the delay ..had some problems,
I will deploy it next week ( hopefully )
Thanks

@eyalmar100 - Can you please tell me till when will it be deployed. I have tried building it on my own. But i am still getting some error.


[MM-47931] a/b test for reduced onboarding task list item

Summary
This PR allows A/B testing for reducing onboarding task list item. With feature flag ON the following three items are not displayed in the onboarding task list

Download the Desktop and Mobile Apps
Complete your Profile
Visit the System Console to configure your workspace

For testing, I have created the following users having different roles in the spinwick server.

role
user id
password

admin
<EMAIL_ADDRESS><EMAIL_ADDRESS>

user
user-1
User-1@123

guest
<EMAIL_ADDRESS><EMAIL_ADDRESS>

Ticket Link
https://mattermost.atlassian.net/browse/MM-47931
Related Pull Requests

Has server changes (https://github.com/mattermost/mattermost-server/pull/21571)

Screenshots

before/feature flag: off
after/feature flag: on

ADMIN USER

MEMBER

GUEST

Release Note
NONE

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/258555

@stevemudie gentle ping for this QA review so we can cherry pick for next cloud release

@mhd-sln Looking at the screenshots, it seems it's not showing the tour for boards and playbooks in the list. Is this intended?

@mhd-sln Looking at the screenshots, it seems it's not showing the tour for boards and playbooks in the list. Is this intended?

Oh this is probably being hidden from the UseCaseOnboarding flag that used to not show it unless the user selected that use case. Is that the case @pvev ?

Oh this is probably being hidden from the UseCaseOnboarding flag that used to not show it unless the user selected that use case. Is that the case @pvev ?
Edit: It seems that it is because the plugins are not installed here

yes, it is because the plugins are not installed in the workspace.

Can we  get rid of the play button in both A/B test options so it is just the emoji?j https://mattermost.atlassian.net/browse/MM-48361
Can we  get rid of the play button in both A/B test options so it is just the emoji?j

Can we get rid of the play button in both A/B test options so it is just the emoji?j https://mattermost.atlassian.net/browse/MM-48361
Can we get rid of the play button in both A/B test options so it is just the emoji?j

I've made this change in https://github.com/mattermost/mattermost-webapp/pull/11581

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Cherry pick is scheduled.


Create technical-planning.md

Result of spike on improving ADR process in sprint 35

Review link: https://github.com/drud/handbook/blob/63c77aa393c3020dd7c20cb5f148bc7638e2c15e/docs/engineering/technical-planning.md

Notes from retro:

Business rule around a 2 day window for feedback before making a decision / taking a next step on it
Slack convo about the mechanics of it is here: https://drud.slack.com/archives/CPD5YFH9V/p1600711985007600?thread_ts=1600708261.000700&cid=CPD5YFH9V


Feat: Adding a SignUp button at the top-gnear the Sin

Describe the feature
Place a prominently styled signup button at the top right corner of the homepage and main screens, using contrasting colors, rounded corners, and hover effects for visibility. Implement the button in HTML and CSS with responsive design adjustments for smaller screens. Add JavaScript to redirect users to the signup page upon clicking the button. This setup ensures the button is appealing, functional, and responsive.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I have checked the existing issues
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Please assign me this issue @Satyam1923


[e2e]: container workflow_dispatch main default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/5250866575
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Tue Jun 13 03:17:07 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/5250866575
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Tue Jun 13 03:49:35 UTC 2023
Tests are passing now. Closing this issue.


Spear.subscribe/4 can return an {:ok, _} tuple even when subscription failed

This issue seems to make the API less predictable, unless there are unknown to me reasons for it working like this.
Imagine we create a subscription like this:
{:ok, subscription} = Spear.subscribe(conn, self(), :all)

This code could succeed even when there are problems with the connection - e.g. esdb://wrong:password@host:2113/. And this is because Spear.subscribe/4 does return an {:ok, _} tuple even in some failure cases:
Success (as documented) - subscription created:
{:ok, #Reference<0.508686625.3000238081.184532>}

Access denied (no events will be received by self()):
{:ok,
 %Spear.Connection.Response{
   status: 200,
   type: {:event_store_db_gpb_protobufs_streams,
    :"event_store.client.streams.ReadResp"},
   headers: [
     {"date", "Wed, 09 Nov 2022 13:48:31 GMT"},
     {"content-type", "application/grpc"},
     {"server", "Kestrel"},
     {"content-length", "0"},
     {"exception", "access-denied"},
     {"grpc-status", "7"},
     {"grpc-message", "Access Denied"}
   ],
   data: ""
 }}

401 (no events will be received by self()):
{:ok,
 %Spear.Connection.Response{
   status: 401,
   type: {:event_store_db_gpb_protobufs_streams,
    :"event_store.client.streams.ReadResp"},
   headers: [
     {"date", "Wed, 09 Nov 2022 13:48:03 GMT"},
     {"server", "Kestrel"},
     {"www-authenticate", "X-Basic realm=\"ESDB\""},
     {"content-length", "0"}
   ],
   data: ""
 }}

That should definitely be tagged as an error 👍. Spear.Connection.Response should also be used internally only, I don't think any function should end up returning that struct.
Spear.connect_to_persistent_subscription/5 has a nice pattern for this that I think could be reused in Spear.subscribe/4: https://github.com/NFIBrokerage/spear/blob/352bc5f38bcc77a3501f1ea07fb65a79c1d4a7da/lib/spear.ex#L2314-L2331
And we can add test for this case in test/spear/connection_test.exs:
  test "a connection with an incorrect password cannot subscribe to a stream" do
    config =
      update_in(@good_config[:connection_string], &String.replace(&1, "changeit", "foobarbaz"))

    conn = start_supervised!({Spear.Connection, config})
    assert {:error, reason} = Spear.subscribe(conn, self(), :all)
    assert reason.message == "Bad HTTP status code: 401, should be 200"
  end

Would you like to make a PR?


Notification trigger for snow removal parking bans

Suggested by IFTTT user tdickins7112.

See here for some information on parking bans.


High rate of producer errors with async producer

Versions
Please specify real version numbers or git SHAs, not just "Latest" since that changes fairly regularly.
Sarama Version:1.19
Kafka Version:0.11
Go Version:1.11
Problem Description
I have been getting a lots of producer errors with aysnc producer. The message size if 2KB but kafka is erring out with "kafka server: Message was too large, server rejected it to avoid allocation error." Is there a way to bring the rate of publish errors down?

I have had the same issue one day. My understanding is that it is not related to an individual message but rather to a batch of messages. Kafka default is 1Mb as far as I remember, so I have increased  it to 20Mb in Kafka but I found out that you also need to increase in the producer code with config.Producer.MaxMessageBytes = 20000000.
   config := sarama.NewConfig() 	config.Net.SASL.Enable = true 	config.Net.SASL.User = cfg.user 	config.Net.SASL.Password = cfg.password 	config.Net.TLS.Enable = true 	config.Net.TLS.Config = &tls.Config{InsecureSkipVerify: true} 	config.Producer.RequiredAcks = sarama.WaitForAll 	config.Producer.Retry.Max = 5 	config.Producer.MaxMessageBytes = 20000000 	config.Producer.Return.Successes = true

Did that help you, coz only thing that works for me is https://github.com/Shopify/sarama/blob/master/sarama.go#L92

Fixed.


more syscall wrappers

Codecov Report

Merging #226 (72f97c3) into add-starknet-syscall-handler-trait (7d550c2) will decrease coverage by 0.72%.
The diff coverage is 0.00%.

@@                          Coverage Diff                           @@
##           add-starknet-syscall-handler-trait     #226      +/-   ##
======================================================================
- Coverage                               73.10%   72.38%   -0.72%
======================================================================
  Files                                      82       82
  Lines                                    9744     9840      +96
======================================================================
  Hits                                     7123     7123
- Misses                                   2621     2717      +96

Impacted Files
Coverage Δ

src/starknet.rs
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


remove temp directory in afterEach()

Fixes #191

Approved. @kkaempf you just need to make your commit "conventional" :) You may want to install the git hook on your machine: https://github.com/SUSE/carrier/blob/main/docs/development.md

Commit changed, thanks for the review !


cannot get "move window" options when right-clicking app preview

Issue Type: Bug
When the top of the app window is not visible (e.g. after switching to multi-monitor), I expect to be able to right-click on the window preview on the start bar and get the menu that shows "move" ().  However, ADS/VSC does not show it; instead the preview goes away.
VS Code version: Code 1.62.3 (ccbaa2d27e38e5afa3e5c21c1c7bef4657064247, 2021-11-17T08:11:14.551Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 x 2592)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.81GB (5.68GB free)

Process Argv
C:\Work\slds\Workspace\SSIS packages\deploy.ps1 --crash-reporter-id 38117117-93df-44fc-b7cb-d91fa6ce4e27

Screen Reader
no

VM
0%

Extensions (8)

Extension
Author (truncated)
Version

vscode-docker
ms-
1.18.0

csharp
ms-
1.23.17

remote-containers
ms-
0.205.2

remote-wsl
ms-
0.58.5

powershell
ms-
2021.10.2

vscode-xml
red
0.18.1

vba
spe
1.7.1

prophet
Sqr
1.4.25

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythontb:30283811
pythonvspyt551cf:30345471
pythonptprofiler:30281270
vsdfh931:30280409
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
pythonrunftest32:30373476
pythonf5test824:30373475
javagetstartedt:30391933
pythonvspyt187:30373474
vsaa593:30376534
pythonvs932cf:30408637
vscop804cf:30404767
vscop341:30404997
vsrem710:30405998
vscexrecpromp3t3:30407764

Please check if the issue is present with latest stable 1.73

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Option to search all mirrors or multiple mirrors

In europe, the fastest mirror must not be in your country, so it would be great, if you could select more than one Country mirror

maybe just add an option to select your own mirror list site file?

Agreed, see #16. Unfortunately, I don't have much time to work on this project anymore.


[tls] Add copy constructor for TlsCredentialsOptions

cc @veblush

Thanks for the PR @dawidcha and apologies for the delay in getting this reviewed. The change looks great, will approve once all of the tests are passing. :)

Other than clang_format error, others don't look relevant to this PR. Please rebase it into the master and fix the clang-format issue by running tools/distrib/clang_format_code.sh

@veblush @matthewstevenson88
Rebased onto master and fixed clang format as requested


Add extension support for MusicXML (.mxl). Addresses issue #3641.

The changes are:

add entry in languages.yml for MXL
add samples to samples/MXL/

Here is some in-the-wild usage:
https://github.com/search?p=3&q=extension%3Amxl+www.musicxml.org&type=Code&utf8=✓
(Addresses issue #3641.)

I couldn't find many MusicXML files in-the-wild. Most .mxl files appear to be ZIP archives.

My apologies, the first few pages are from a single user with compressed .mxl files.
find plenty of examples here:
https://github.com/search?p=3&q=extension%3Amxl+www.musicxml.org&type=Code&utf8=✓
Here is a specific example from MIT Research lab's. It is a Johann Sebastian Bach MXL score:

https://github.com/cuthbertLab/music21/blob/e523f802c002ad93085d66dcadb53d3752f6cb7c/music21/corpus/bach/bwv133.6.xml

Here are some test .mxl scores for a .NET MusicXML parser:

https://github.com/vdaron/MusicXml.Net/tree/develop/MusicXml.Unit.Tests/TestData

Here are more, all different users:

https://github.com/shanahdt/mus7921/blob/4513847a7c73748d66bbdb389527b0fd1045713f/corpus/Monody/Misc/syrinx.mxl
https://github.com/morganecf/music21/blob/521ff85a3d757ca513fc9ff6927609e9c089240d/music21/corpus/luca/gloria.mxl
https://github.com/rdhyee/ScoreDiff/blob/5f57d63ae99e1f7823e5a2a305c9b98a5c97a3b3/src/test_cases/bwv66.6.mxl
https://github.com/bewest/music21-bewest.clone/blob/8975116677ce4feb6209933a03501984cbe2dbc5/music21/corpus/luca/gloria.mxl
https://github.com/jonathanmarmor/homemadehouse/blob/a03e71cd49d202caadd1bbbc617477d4ca7f230b/output/tests/musicxml_test.mxl

Best regards,
Nolan

Hello, @pchaigno .
Updated above are plenty of in-the-wild MusicXML (.mxl) documents.
Please review when you have a chance.
Thank you!
-Nolan

Updated above are plenty of in-the-wild MusicXML (.mxl) documents.

I'm afraid I disagree. 30 between 6 users (from your own search query) isn't sufficiently popular at this time.

Closing in favor of #4219. We'll monitor the popularity of the extension there.
If you have an improved search query compared to the one used in #4219, please post it here and I'll update #4219.


Merge latest changes from upstream

I do not believe this is required for our current priorities as we realistically need to return to hardware data collection for the next version.

@juliakreger I agree, just a victim of my PR opening spree

@elfosardo A "PR opening spree" it has been :)

/lgtm


Add jgraham to the list of reviewers

r? @metajack @Manishearth

@bors-servo r+

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

:hourglass: Testing commit 3ed1bae with merge d6f5e39...

:pushpin: Commit 3ed1bae has been approved by metajack

:sunny: Test successful - travis


select-box()

We should add basic styling for select dropdowns ala http://bavotasan.com/2011/style-select-box-using-only-css/ (obviously one that looks better, but the basic code premise is right.)
I'll post codepen example soon.

https://github.com/filamentgroup/select-css

+1 for this. Second example looks great

Need to do some more customization and testing but I have basic mixin going here:
http://codepen.io/dbox/pen/ZGZzmW?editors=110
Best part is you can pass a custom dropdown image or, if not it will default to using Axis' triangle. :)

This is lovely. Nice and clean and basic, just how we need it :+1:

Well the alt image WAS working .... May end up being too problematic. but I"ll keep tinkering

Ah, they were just preventing hotlinking.
It does bring up the issue though, if we're goin to do custom image option, user will have to pass image height/width :/

Sweet! PR dat :+1:

I just have to come up with one little fix so that borders look better with dark backgrounds, then i will!

Okay this thing just got bonkers but it will be insanely handy:
http://codepen.io/dbox/pen/ZGZzmW?editors=110
Don't get too freaked out about # of arguments. Most use cases could be done just with $border-radius and background-color. It uses the same logic as button() to dynamically change font-size and a few other attributes based on background-color.
Sample usage:
div.custom-select
  select-box()

div.custom-select
  select-box(0, blue)

Pretty much ready to go. Here's a better demo (pretend like it's stylus)
http://s.codepen.io/dbox/debug/xwNMZd

:+1:

available in 2.0


Curl command not working

File: ee/ucp/admin/configure/create-audit-logs.md
In https://beta.docs.docker.com/ee/ucp/admin/configure/create-audit-logs/#procedure step 4:
The curl command returns the following when using the cert in the bundle downloaded from UCP:
curl -k --cert ./cert.pem --key ./key.pem --cacert ./ca.pem -H "Content-Type: application/json" -X PUT --data $(cat auditlog.json) https://${UCP_HOST}/api/ucp/config/logging
curl: (58) unable to load client key: -8178 (SEC_ERROR_BAD_KEY)

I used a Bearer Token and got the following:
curl -sk -H "Content-Type: application/json" -H "Authorization: Bearer $AUTHTOKEN" -X PUT --data $(cat auditlog.json) https://${UCP_HOST}/api/ucp/config/logging
{"message":"unable to parse request body: unexpected end of JSON input"}

It was missing some quotes for the --data parameter:

curl -sk -H "Content-Type: application/json" -H "Authorization: Bearer $AUTHTOKEN" -X PUT --data "$(cat auditlog.json)" https://${UCP_HOST}/api/ucp/config/logging
{"logLevel":"INFO","auditLevel":"metadata","supportDumpIncludeAuditLogs":false}

Thank you for your feedback. The Docker Enterprise platform business, including products, customers, and employees, has been acquired by Mirantis, inc., effective 13-November-2019. With this change, we are currently evaluating our documentation. In line with this, additions and updates are temporarily on hold, including product descriptions, instructions, illustrations, etc. while we evaluate the state of our documentation.


Styles broken in Demo package

Description

There was recently a bug with duplicate styled-components imports IIRC. Did styled-components become a peer dependency?
Steps to reproduce
npm run bs
npm run build
cd packages/demo-gatsby
gatsby develop
Expected result
pretty UI
Actual result
missing styled
Environment
MAC OSX Chrome

If i run npm install && npm run start in the demo-gatsby it seems to fix the issue

yeah looks like its a peer dep now - https://github.com/tinacms/tinacms/commit/2c852088bf550decf27e9f14aa129e5dee5592d9 - it's odd cause after i run bootstrap styled-components is in node_modules...

Yeah this is a weird one. I suspect there's somehow multiple versions of styled-components getting installed because of the peerDependency shift.
The reason I think this, is because it is only styles from @tinacms/styles that aren't working. I think the styles defined directly in tinacms are good. (That needs to be confirmed)

For reference #362


Change default Fulcio URL to match cosign's

Currently cosign is using https://v1.fulcio.sigstore.dev as the default. Changing chains to use the same.
Signed-off-by: Nghia Tran<EMAIL_ADDRESS>

/lgtm

/ok-to-test


Type collision when using quasar and vee-validate and typescript

Versions

vee-validate: 2.2.0
vue: 2.6.10
quasar: 1.0.0-beta.15
typescript: 3.2.4
vue-cli-service: 3.5.3

Describe the bug
I'm using quasar in combination with vee-validate and this combination throws the following typescript error:
Interface 'QUploader' incorrectly extends interface 'Vue'.
  Types of property 'fields' are incompatible.
    Type 'Function | any[] | undefined' is not assignable to type 'FieldFlagsBag'.
      Type 'undefined' is not assignable to type 'FieldFlagsBag'.

I cannot fix this problem seeing how fields are added to the vue instance using declare module and as far as i know there is no way of overwriting these inside your project because this gives:
Subsequent property declarations must have the same type.  Property 'fields' must be of type 'FieldFlagsBag', but here has type 'any'.

To reproduce
Steps to reproduce the behavior:

Create a vue project using dependencies mentioned above
Build project using vue-cli-service
See error

Expected behavior
Don't declare the vee-validate types in such a way that it cannot be changed inside your project.
Desktop (please complete the following information):

OS: Ubuntu 18.04.2 LTS
Browser: N.A.
Version: N.A.

@380Z What did you end up doing? We're having the same problem except it's conflicting with Bootstrap-Vue.

a workaround to override vee-typings locally:
https://stackoverflow.com/a/55734147/3499604

This issue should not have been closed, as Vee-Validate should be fixing this potential conflict with other packages.
The injection should be prefixed with a namespace, or not be placed into the typings at all.

This is addressed here https://github.com/baianat/vee-validate/commit/fedea704e01aaa64749c04c891b74c1be6d70c12


Add additional facebook instant article settings

@spra85 @mparent61 @benghaziboy
Added in these settings so we can test instant articles in development mode on testing

👍

@mparent61 updated

👍

Coverage decreased (-9.3%) to 76.896% when pulling c2f45dd632f1df3690af168d588bf6818219b14f on ia-fb-flag into 8028d23f01e522b1803d8813f61ba470d87a3dd8 on master.


fixed misconfigs alert

Based on the CIS Type for a detection the misconfigurations would never alert. Here is a snippet of the raw JSON.
'Detections': [{'Detection': {'ID': '39e4d5', 'Type': 'CIS', 'Name': '
Added another type and created an array for the misconfig check so it will alert on the CIS type. This would never alert unless the Type was "Misconfigurations" which I have never seen and I am not certain it exists.
Example:
INFO    Searching for misconfigurations in scan report...
WARNING Alert: Misconfiguration found

I think this makes sense. @isimluk thoughts?

This is definitely improvement.
I was aware of the CIS type, but there needs to be more work following this. We need to be able to print-out specific information about the misconfiguration. Also, it would be useful to see of what kind of CIS failures we may get in order to educate end-user about these. But this is definitely step towards that goal. :+1:


Inject tracid and spanid

Hello,
I have a highly scaled microservice app and my messages passed through a nats.io already process IDs, correlationIDs and parentIDs. Everything actually to reconstruct the complete directed call graph.
Is there a way to inject these IDs to an opentracing solution? I would not use new IDs but using the already existing ones allowing me to adopt the flow implicitely from the message bus.

It's not a question of OpenTracing, but of the specific tracing library implementation you bind your code to. For example, in Jaeger you can force the use of the external trace ID (but not span IDs) provided it is  representable as a 8-bytes or 16-bytes array.

Do you know any library allowing me to inject those IDs?
I mean most of the services I'm working with are fragmented in time and the "built-in" ID generation is a show stopper for me.
Thanks!

I don't know if any tracer is able to accept completely arbitrary IDs. These IDs are usually captured in the span and stored in the tracing backend, so the backend data model puts additional limitations on what can be used as an ID.
I would say reusing IDs not generated by the tracing infrastructure is not where the industry is going to (e.g. https://github.com/w3c/trace-context), but some tracing platforms might support them for legacy services. E.g. in Jaeger, as long as your legacy/external IDs fit in 16-bytes array, it can still capture/represent them in the storage.
There is still going to be an issue with using message-id as span-id, because APIs like OpenTracing/OpenCensus don't allow you to provide a custom id when creating a new span (you'd need to hack the tracer implementation a bit), and you do need to create a span for  the producer generating a message in order to capture proper causality between spans in the trace.

Hello, ok I understand better a little bit. How do you track a workflow which is fragmented in time and space? A digital contract is suspended and continued after a few weeks of delay? How should I connect the new spans to the old ones? Or in a stock market platform where some part of the process is cultivated in a different system / counrty? Should I persist the context and inject it manually? Thanks...

Yes, you can persist the trace context with the data/message and use it to resume the trace later. But many tracing systems wouldn't work very well with workflows that takes days/weeks to complete.


Add the ability to use pyarrow  + on on disk parquet/csv in duckdb

Adds the ability to use pyarrow tables instead of pandas dfs and also allows you to load parquet/csv files directly from disk into duckdb.

Some examples:
PyArrow
I've also included code for reading parquet files and left this commented out.
from splink.duckdb.duckdb_linker import DuckDBLinker
import pyarrow.csv as pc
import pyarrow.parquet as pq

from tests.basic_settings import get_settings_dict

f = "tests/datasets/fake_1000_from_splink_demos.csv"
test_arrow = pc.read_csv(f, convert_options = pc.ConvertOptions(
    strings_can_be_null = True
))

# f = "tests/datasets/test.parquet"
# lineitem = pq.read_table(f)

linker = DuckDBLinker(
    test_arrow,
    get_settings_dict(),
)
linker.predict().as_pandas_dataframe()

Reading directly from a file
I've also added some tests for this.
from splink.duckdb.duckdb_linker import DuckDBLinker
import pandas as pd
from tests.basic_settings import get_settings_dict

df = pd.read_csv("./tests/datasets/fake_1000_from_splink_demos.csv")

linker = DuckDBLinker(
    "tests/datasets/fake_1000_from_splink_demos.csv",
    get_settings_dict(),
)
linker.predict().as_pandas_dataframe()

Ref https://github.com/moj-analytical-services/splink/issues/680


How to update submodules

After running git-subtract  --auto-exclude update I was trying to update my submodules to their latest commits. The Readme states that all the git submodule commands keep working, so I tried git submodule foreach git pull origin master which pulled from the super project’s master branch and broke everything. What would be the correct command to update the submodules?

I think the root cause of the problem is changing the source url for all the submodules to . erases the true upstream information. Any fresh clone of the repo will have no pointer to the true upstream (short of digging into .gitmodules' history).
I'm gonna brainstorm some solutions, some of which are obviously bad:

Never change your .git/config, even after adopting git-subtrac and rewriting .gitmodules. Users can shove it :D
Save .gitmodules-subtrac to the repository; add documentation about swapping it out
Build some smarts into git-subtrac to automatically do the previous?
Extend git submodules to support multiple urls?
Find out if "alternates" is a usable option? submodule.alternateLocation seems interesting at first glance, but maybe not.


⚠ Bofrost.de has degraded performance

In 64966c6, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1010 ms

Resolved: Bofrost.de performance has improved in e88ee27 after 7 minutes.


Finish implementing COBC file system

Description
So far we only have basic file system commands like creating and deleting files and directories, or writing to and reading from files. What we actually need is functions to store programs that are to be sent to the EDU and results that come from the EDU. Of course, we also need to be able to delete them, check their integrity, etc. Since the file system is on the flash with which we communicate via SPI, we furthermore need to implement a fallback behavior for all those functions, in case the flash does not work.
To do

[x] #215
[ ] #216
[ ] #217
[ ] #218
[ ] #219
[ ] #220

Blocked by #186

Blocked by #273


Authentication Method Reference

The UserAccountInterface should provides a method to know which AMR(s) have been used.
See https://tools.ietf.org/html/draft-ietf-oauth-amr-values

https://github.com/OAuth2-Framework/OAuth2-Framework.github.io/issues/8


Images are missing for all module

Module: ALL
Images are missing for all modules.  When can we expect the repo to be updated?
Repro steps:

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team


Change default encoding to utf8 for DataHasher, Fixes #11

This was an issue for cached requests with unicode parameters

Coverage remained the same at 95.946% when pulling dd0ff5cc9122af9a588ae2969f60e861caae316f on sknat:fix/hash-default-encoding into d75f6f944bc5a72fef5d7811e4973e124d9921dd on bionikspoon:develop.

Coverage remained the same at 95.946% when pulling dd0ff5cc9122af9a588ae2969f60e861caae316f on sknat:fix/hash-default-encoding into d75f6f944bc5a72fef5d7811e4973e124d9921dd on bionikspoon:develop.

Coverage remained the same at 95.946% when pulling dd0ff5cc9122af9a588ae2969f60e861caae316f on sknat:fix/hash-default-encoding into d75f6f944bc5a72fef5d7811e4973e124d9921dd on bionikspoon:develop.


SwiftyJSON @ 11fdc5c doesn't exist

I'm trying to use this repo in CocoaPods but there's an error retrieving the mentioned version of SwiftyJSON. I think it's just matter of pointing to the right tree.

I'm suffering from this too, there seems to be no Swift 2.0 support with SwiftyJSON yet. Also, NSError is still in the source code, looks like ErrorType should replace it in Swift 2.0.

I ended up with a solution that works great in Swift 2.0 and Xcode 7. I just made a little modification to the file in order to resolve the NSError issue.
https://gist.github.com/gabovanlugo/c1c0588ab929df81b3a7
You need to import that file into your project tree manually (no CocoaPods). However, don't forget to install Alamofire and SwiftyJSON for Swift 2.0
Here's my Podfile:
# Uncomment this line to define a global platform for your project
platform :ios, '8.0'
use_frameworks!

target 'yourApp' do
  pod 'SwiftyJSON', :git => 'https://github.com/SwiftyJSON/SwiftyJSON.git', :branch => 'xcode7'
  pod 'Alamofire', '~> 2.0'

end

In this example you can see how I'm using it.
override func viewDidLoad() {
        super.viewDidLoad()
        // Do any additional setup after loading the view, typically from a nib.

        // Mark: API call

        let url = "http://<IP_ADDRESS>:3000"
        var templateRemoteData: JSON = [:]

        Alamofire.request(.GET, url)
            .responseSwiftyJSON({ (request, response, json, error) in
                if(error != nil) {
                    print(error)
                    print(request)
                    print(response)
                }
                else {
                    self.templateRemoteData = JSON!(json)
                    print(self.templateRemoteData)

                    // My API returns a ["data"] object, don't forget to change it to whatever you need
                    for item in self.templateRemoteData["data"].arrayValue {
                        // Do whatever you want with your remote data
                        }
                    }
                }
            })

    }

Need to mention that you need to import:
import SwiftyJSON
import Alamofire

... in your ViewController as well.
Another thing, I'm getting data from a local server I did with Node.js, it isn't HTTPS so you can get some warning coming from Xcode 7. You can solve it this way: http://stackoverflow.com/questions/31254725/transport-security-has-blocked-a-cleartext-http
Hope it helps.

Thanks @gabovanlugo

No problem, @Gumarelo.
By the way, for those who are already in OS X "El Capitan", there's a known bug (Even in Xcode 7.1 - 7B91b) that does't allow us to connect to a localhost through an IP address.
// This won't work
let url = "http://<IP_ADDRESS>:3000"

Simple solution as the Xcode Release Notes says (As for October 2015):
Simulator
"When running in the Simulator, an app cannot communicate with TCP/IP services locally hosted by the Mac via the Mac’s local IP address.
Connect via a loopback address, such as localhost or <IP_ADDRESS>. (22453539)"
// This WILL work
let url = "http://localhost:3000"

More info here: https://forums.developer.apple.com/thread/20919
And here: https://developer.apple.com/library/ios/releasenotes/DeveloperTools/RN-Xcode/Chapters/xc7_release_notes.html#//apple_ref/doc/uid/TP40001051-CH5-DontLinkElementID_162
Of course, if anyone is having such problem.

Thanks @gabovanlugo Closing for now.


Check data-type of fileLumisList

In order to extract element from the dict we need to ensure that provided object is indeed a dict data-type. This PR provides this fix for issue https://github.com/dmwm/CRABServer/issues/7378

@amaltaro , @mapellidario please review the change I applied to dbsClient to check data type of the object. If you'll sign off this change I'll push it forward and create new dbsClient tag and upload it to PyPi

It's hard to review it when you do not know the expected data structure, but I managed to find a dump from 2019, where we can see that this file_lumi_list is supposed to be a list of dictionaries:
https://amaltaro.web.cern.ch/amaltaro/forYuyi/dbsuploader_block.json
I am reviewing your changes now.

Sure, we can test this in testbed before merging

@amaltaro I think we should keep code as is (with changes I provided) as it suppose to work with both DBS server implementations. As we gradually move from one to another I doubt it would be wise to change code to satisfy one server implementation details as we may (even with a small probability) to rollback DBS server and it would be harder to go back with changes. Therefore are some parts which will need clean-up but this step was post-poned until we perform full migration to new implementation.

Dario,
I'm awaiting your word before merging. Please let me know if you test it on
cmsweb-testbed.
Thanks,
Valentin.
On  0, Dario Mapelli @.***> wrote:

Sure, we can test this in testbed before merging
—
Reply to this email directly, [1]view it on GitHub, or [2]unsubscribe.
You are receiving this because you authored the thread. Message ID:
@.***>
References

https://github.com/dmwm/DBSClient/pull/73#issuecomment-1228685077
https://github.com/notifications/unsubscribe-auth/AAA6RUT225DUM6ATYAXH3OTV3DUR3ANCNFSM57XBK45A

While having a better look, I noticed that in your changes you sometimes use fileLumiList and fileLumisList.
Assuming that it is a typo, I changed the code to only use fileLumiList and it works smoothly. thanks Valentin!

@mapellidario, thanks for spotting a typo. I fixed it now and will proceed with release.


add ID to Mount / Unmount for docker 1.12

Because docker added IDs to Mount() / Unmount()
Right now we choose to do nothing with the ID but add it to our plugin layer so that calls will continue to work with docker 1.12
https://clusterhq.atlassian.net/browse/FLOC-4480
https://github.com/ClusterHQ/flocker/issues/2854

Thanks @wallnerryan
Please address or answer the comments above and merge when all the tests have passed.
Probably worth forcing the acceptance tests too....the  non-loopback ones listed under the "cron"

@wallrj how come the acceptance tests under cron dont kick off automatically ?

how come the acceptance tests under cron dont kick off automatically ?

Because they're so slow.
We made a decision that it was sufficient to see the loopback acceptance tests pass .
The loopback accceptance tests use the loopback backend and therefore don't  include any of the multi-node, dataset moving tests.
The full acceptance tests are run nightly on master.
And the idea is that we check the build results on master and notice any new errors.

part of combined branch https://github.com/ClusterHQ/flocker/pull/2880


Automated cherry pick of #1905: huawei elb support

Cherry pick of #1905 on release/2.11.
#1905: huawei elb support

/lgtm
/approve

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11@36f091b). Click here to learn what that means.
The diff coverage is 1.44%.

@@              Coverage Diff               @@
##             release/2.11   #1975   +/-   ##
==============================================
  Coverage                ?   7.19%
==============================================
  Files                   ?     445
  Lines                   ?   69245
  Branches                ?       0
==============================================
  Hits                    ?    4982
  Misses                  ?   63850
  Partials                ?     413

Flag
Coverage Δ

#aFlag
7.19% <1.44%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/regiondrivers.go
20% <ø> (ø)

pkg/compute/models/cloudsync.go
0% <ø> (ø)

pkg/mcclient/options/loadbalancerbackendgroups.go
0% <ø> (ø)

pkg/mcclient/options/loadbalanceracls.go
0% <ø> (ø)

pkg/mcclient/options/loadbalancercertificates.go
0% <ø> (ø)

pkg/compute/models/loadbalancerlistenerrules.go
2.04% <0%> (ø)

pkg/util/aws/loadbalancerbackend.go
0% <0%> (ø)

pkg/util/aws/loadbalancerlistenerrule.go
0% <0%> (ø)

pkg/util/aws/wire.go
0% <0%> (ø)

pkg/compute/models/loadbalancerlisteners.go
1.69% <0%> (ø)

... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36f091b...ca80762. Read the comment docs.


Is there a way to view cached data

I'm using next.js and are trying to cache SSR. I'm trying to follow the simple solution described here: https://www.christopherkaiser.de/ssr-request-cache-for-react-next/
Is there a way to view the cached data either by consoling it or by browsing through a directory.

Hey,
It depends where are you storing the data. See https://github.com/Kikobeats/cacheable-response#cache
If you use a regular database connector, then you can see the data with any GUI client 🙂


JSMA untargeted selects target at random

The JSMA untargeted attack selects the target class at random, a better result can be obtained by modifying the minimization objective to make the original class more-wrong instead of a random class less-wrong.
The FGM, BIM, and CW attacks have untargeted behave in this way, and it would be more clear if JSMA behaved this way too.

This would be a change in the attack's behavior, which would be more confusing to people who are just looking for an implementation of the paper in my opinion. It might be less confusing to make it a variant of the attack than modifying the original behavior I guess.

I would vote for calling this something different then. Or putting a docstring warning maybe.

Just wondering: do you already have code for this or is this more like a feature request?

I have code that does this sitting somewhere, yeah.

I agree that some kind of warning would be helpful here, I was expecting the untargeted JSMA attack to make the original class more wrong. I'd be willing to submit a PR for this once symbolic JSMA is merged.

It looks like we should standardize the expected behavior across all attacks to have consistent behavior in the simple misclassification (untargeted) mode as opposed to the source-target misclassification mode (untargeted). Given that the JSMA is a source-target attack by design, this will require some thinking to adopt a default behavior that is most natural.

So the attack I have is targeted by design, and the untargeted attack is just a corresponding flip-the-objective type of thing. I think we can apply that to JSMA too. This is what I did some time earlier last year when I wanted JSMA to be untargeted. It would definitely be best to try out a few things and make sure that we pick the right choice though.
Let me simplify notation for github since it can't stylize math and assume JSMA to just operate over one pixel p instead of paris pq. In JSMA, for image x and target t let's define
a_p = (d/dx_p) Z(x)t
b_p = sum{j != t}  (d/dx_p) Z(x)_j
So that to perform JSMA, we optimize for argmax_p (-a_p*b_p) * (a_p > 0) * (b_p < 0)
Where the terms here correspond to:

a_p > 0 : make the target class more likely
b_p < 0: make the best other class less likely
(-a_p*b_p) : break ties by making the change biggest

To do this in an untargeted manner, we just have to set t to be the original class and flip a few signs, and instead optimize for argmax_p (a_p*b_p) * (a_p < 0) * (b_p > 0)
So that now we have

a_p > 0 : make the target (original) class LESS likely
b_p < 0: make the best other class MORE likely
(-a_p*b_p) : break ties by making the change biggest

I think this worked when I did it.

I'm a bit confused by the use of "more-wrong" and "less-wrong" in this thread. Do you mean "less probable" and "more probable" respectively?

@npapernot What's the status of this issue? It has been open for a long time without activity. Do we need to more actively find someone to take the baton on this? Maybe prioritize it at the next work session?

I don't think anyone is working on it but I think it's OK to leave this issue open unless we would like to keep ideas for enhancement somewhere else? For instance in a MD file at the root of the repo or a wiki page so we don't clutter the issue tracker?

Seems fine, just going to mark it as "help wanted" for "nobody has the baton"

Thank you Catherine!

@npapernot Can I work on this one? I think Carlini's idea will work just fine.

I'm not sure we ever settled on what the best option is here. It would probably call for a bit of research to compare the different ways to make the attack untargeted. Maybe it would make sense to build in a consistent behavior across the different targeted attacks that allows the user to select different strategies when no specific target labels are specified like choose the target label to be (a) runner up according to softmax probabilities, (b) label with smallest softmax probabilities, (c) random target label

@npapernot  I think all the three options you have mentioned are heuristic based targetted attacks.  These will note be pure untargetted like how FGSM method works. Based on the Carlini's idea, I have created JSMA untargetted. It does not require a target label for generating attack. I have compared it with perturbations required in targetted format. Here is the graph.

The untargetted JSMA is better compared to averaged targetted JSMA and works in purely untargetted form. I had to do very small changes to your original JSMA. I have kept it as a pull request #458

Thank you Aashish for making a PR and running the experiment above, I appreciate the contribution. There are a few issues with PR #458:

we should keep the API consistent with other attacks. The SaliencyMapMethod class has a parameter called y_target that can be used to trigger the untargeted attack when it is set to None.
a lot of the code for jsma_symbolic_untargetted in PR #458 is duplicated from jsma_symbolic. We should avoid duplicating code and instead try to merge both functions.
as mentioned previously (see #451), we should not create a new tutorial for the untargeted JSMA (file mnist_tutorial_untar_jsma.py) and instead modify the existing JSMA tutorial to include the untargeted behavior.

Given the amount of code that would need to be changed to address these comments, it will be easier to start the PR from scratch so I think it is easier to close this PR for now and keep all of the conversation here in one single place (if needed for future reference). This way we can discuss first how we'd like to implement this change before we work on a new PR.
Back to the conversation we had above, there are four strategies that surfaced in the discussion to address the case where no specific target label is provided by the user to the attack class:

minimize the probability of assigning the correct class
maximize the probability of assigning the runner up class (the class that is originally assigned the second largest softmax probability)
maximize the probability of assigning the least likely class (the class that is originally assigned the smallest softmax probability)
maximize the probability of assigning a randomly chosen class (a class is selected at random for each test point attacked)

(Definitions of 2-4 assume that the attack is only fed correctly classified test inputs, which is a reasonable thing to do and assume in my opinion.)
Currently, the FGM, BIM, and CW attacks are following strategy 1. when no target is provided and y_target is set to None. This the strategy that Nicholas suggested a variant of the JSMA for above and that you implemented in #458. I think it makes sense to include a strategy like that to be the default behavior (when y_target is set to None) modulo some minor modifications (see below for comments on the specific strategy).
I think it would also make sense to include the strategies 2-4 in all attacks. One way to do this would be to accept as a value for argument y_target the following three strings: runnerup (for strategy 2.), leastlikely (for strategy 3.) and rand (for strategy 4.). This would help with benchmarking the attacks in the targeted mode without having to specify specific targets manually for each test input.
Coming back to the implementation of strategy 1. for the JSMA, I agree that optimizing for argmax_p (a_p*b_p) * (a_p < 0) * (b_p > 0) is consistent with the spirit of the original targeted JSMA attack. One potential limitation is that without a specific target class, the attack might oscillate between different classes that differ from the original class before one of them is assigned a larger logit than the correct class. For this reason, I'd be interested in comparing the success rate and mean perturbation of strategies 1. and 2. on the full MNIST & CIFAR10 test sets before we set strategy to be the default untargeted strategy, i.e. the strategy followed when y_target=None in SaliencyMapMethod. This will help clarify whether that's an issue we should be concerned about or not at all.

2-4 are all targeted attacks with different ways of defining the target, right? Should we just leave the attacks taking a y_target argument and make easy ways to calculate the target?
For example:
2. Pass y_target = runner_up(x, model)
3. Pass y_target = least_likely(x, model)
4. Pass y_target = random_class(nb_classes)
This way we don't need to have all the attacks implement all the target selection strategies, parse a lot of if statements to decode string names of target selection strategies, etc.

That a good suggestion yes, we could make three functions runner_up, least_likely and random_class that take in either a single input or a batch of inputs as well as a model and return the target classes encoded as a hot one vector or labels.

@npapernot
I agree with the suggestion.
Continuing on the discussion. I collected Data for JSMA attack on MNIST test set. Here are the results from the experiment. On this graph, I have sorted the prediction probabilities & perturbations from the targeted attacks and identified which class the minimum perturbation belongs to. I have ignored the true class.(model prediction accuracy was 99.33).

It was no surprise that the 1st runner_up class scored the highest but beyond that there was good spread in other classes. This means choosing 1st runner_up class as the target class will result us in the least perturbed adversarial images around ~30% of time.
Also as part of the experiment I evaluate the average perturbation for runner_up classes and compared them to the un-targeted JSMA perturbations. Here are the result.

As we can see un-targetted JSMA performs quite good on an average. I agree that there is possibility of oscillation in un-targetted attacks but the correlation between runner_up predicted class and perturbations is not high enough, resulting in inferior attacks on an average.
These results are for JSMA attacks only. Since it's an iterative attack with quite small updates, makes it good candidate to analyze perturbations.

Thanks for the detailed analysis. This is sufficient evidence to start implementing strategy 1 as described above as the untargeted JSMA strategy. Could you put a PR together while addressing the comments left above?
Also, if you have enough time, it would be nice to implement in a separate PR the 3 functions for strategies 2-4 as Ian suggested in his comment. If you don't have time, I'll flag it as a feature improvement waiting for a contributor in the issue tracker.
I will be offline until August 10 at which point I will take a look at the PR(s) unless someone else already approved the changes before I get back to it.

If no one is currently working on this, can I take it up? I need to decrease the probability of assigning the correct class, and then implement the three alternative strategies (2-4), right?

@vikramnitin9  @npapernot  I was busy with some release.I will be submitting the pull request for the feature in a week's time.

Okay


[FLINK-8849][Documentation] Fix link to chaining docs

OK, after reading through the (very helpful) contributing text, it looks like you'd rather not have Jira issues for minor doc fixes, right?

We don't require JIRAs for small doc fixes, whether you open one is up to you.

merging.


fix: Could not override GoldenTestTheme

Description
All our tests failed because the default GoldenTestTheme changed the background colour. The GoldenTestTheme cannot be overwritten as it is not exported via the barrel file.
Type of Change

[ ] ✨ New feature (non-breaking change which adds functionality)
[x] 🛠 Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑 Chore

We use AlchemistConfig.runWithConfig() for our tests. The background colour is applied with the changes. But at the time when the TableBorder is to be coloured, Zone.current[currentConfigKey] is suddenly null, which is why our colour is not applied.

@Brainyoo it looks like there are a couple tests that need to be updated for these changes!

We use AlchemistConfig.runWithConfig() for our tests. The background colour is applied with the changes. But at the time when the TableBorder is to be coloured, Zone.current[currentConfigKey] is suddenly null, which is why our colour is not applied.

@Brainyoo am I correct in saying that this would still exist after your PR lands, i.e this PR does not address this bug?

The current failures are (partly) my fault, need to fix the job as it's failing to find the golden failures. Will open a PR to unblock this.

@Brainyoo looks like just one failing test for borderColor

Thank you @Brainyoo!


MvvmDialogs

I'm looking at your source code in samples and see this in the ViewModel.
public async void ShowInputDialogAsync()
{
    var dialog = new ContentDialog()
    {
        Title = "Let's go ...",
        PrimaryButtonText = "Ok :-)",
        SecondaryButtonText = "Not OK :-(",
        CloseButtonText = "Leave me alone!"
    };

    var viewModel = new CustomContentDialogViewModel(dialog);
    dialog.Content = new ContentDialogInputExample()
    {
        DataContext = viewModel
    };

    _ = await dialog.ShowAsync();
}

If it's a sample that people refer to for best-practices, then there are a couple of issues here. Referring a View from the ViewModel is a big no-no. Creating the new ViewModel instance can work here, but if it requires Dependency Injection, it becomes an issue pretty quick. It can't be unit-tested.
A better approach, using MvvmDialogs library (that I redesigned and ported to Avalonia)
https://github.com/mysteryx93/HanumanInstitute.MvvmDialogs
I'm going to look into adding support for FluentAvalonia dialogs to MvvmDialogs.Avalonia, I'll post updates of the progress here.

I was looking at what would need to be implemented. It's basically ContentDialog and TaskDialog. Either one of them could be used to replace MessageBox.Avalonia.
As for CoreWindow, it derives from Window, so showing a CoreWindow dialog should work exactly the same.
As for updating the samples? I notice that you purposely avoid external dependencies to keep the code simple, and hiding the actual code behind MvvmDialogs abstraction definitely has its downsides here. So perhaps I'm better to just create my own samples then.

I've added preliminary support for FluentAvalonia in MvvmDialogs.
It will require more work to support more advanced features.
Since the samples keep it simple while avoiding 3rd-party dependencies, I'll close this.


fix: only set ARGO_PROGRESS_FILE if self reporting progress (#13089)

Fixes point 5 of #13089

Replaced by #13743


chore(package): update bitbucket-repository-provider to version 2.1.0

Coverage remained the same at 81.739% when pulling 7b3f10b32a9de724138cf5449ab6629908bb5fba on greenkeeper/bitbucket-repository-provider-2.1.0 into 194c2f4680aec383b7e88d36b738f73f56559a7a on master.


Fix Go Dependency Errors

Description

Fixes errors with go mod tidy by switching to newer version of cosign
Removes etcd and go-tuf vulnerable versions

Fixes #244
Fixes #245
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

@susanshi No worries! hopefully this unblocks the release. apart from the replace statements. I had to upgrade cosign to the latest commit hash. That seemed to do the trick!


chore: analytics, crashlytics, core, messaging -  remove unused deprecated V1 embedding

Description
This PR removes deprecated embedding functions from analytics, crashlytics, core and messaging.
It also migrates the use of FlutterMain to FlutterLoader in messaging since this is also deprecated.
Related Issues
See #6745
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (melos run analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change.
[x] No, this is not a breaking change. > Because embedding v2 is supported since flutter 1.12, and the minimum required for these packages is flutter 1.12, i don't think anyone will be affected.

Since this will probably also have effect on other packages i think it's good to first discuss this in #6745 if we want to remove this in all packages or not.

@juliansteenbakker We're happy for it to be removed from all plugins. It appears that crashlytics and analytics are failing. You need to remove the V1 embedding and also the generated file associated

@juliansteenbakker We're happy for it to be removed from all plugins. It appears that crashlytics and analytics are failing. You need to remove the V1 embedding and also the generated file associated

Sounds good.
So besides analytics, crashlytics, core and messaging i'll remove them from the other plugins aswell. Do you want this all in this PR? Or should i make a separate PR for that?

@juliansteenbakker We're happy for it to be removed from all plugins. It appears that crashlytics and analytics are failing. You need to remove the V1 embedding and also the generated file associated

Sounds good.
So besides analytics, crashlytics, core and messaging i'll remove them from the other plugins aswell. Do you want this all in this PR? Or should i make a separate PR for that?

Let's get this one in first. I'd prefer another set of eyes before rolling out for other plugins as I may have missed something. You can also safely ignore firebase_ml_vision & firebase_admob.

Let's get this one in first. I'd prefer another set of eyes before rolling out for other plugins as I may have missed something. You can also safely ignore firebase_ml_vision & firebase_admob.

Ok! I've updated this PR and i think it's ready to merge.


Table definition problem

Hello, great library.
In some PDF examples, the сv2 library does not quite correctly define the table. For example, in the first PDF file on the second page, the first three tables have merged into one, although there is a visual separation between them. Can you tell me what this might be connected with, and how we can improve the readability of this table?
I experimented a little with the median_line_sep parameter of the TableImage class, and found that when median_line_sep = 25, the tables are read correctly, maybe the incorrect calculation of the tables is due to an error in the calculations of this parameter?
1_tab.docx
1_exp.pdf
I was also faced with the fact that if a column in a table is completely filled with the symbol "-", then this column is not included in this table during parsing; I am attaching an example. On the second sheet of the PDF, near the very first table, the second column with the symbol "-" merged with the next column, and the last column was not included in the content of this table at all. Here I could not determine a clear reason why this could happen.
2_exp.pdf
2_table.docx
Photos in Word files, I couldn’t attach clean photos, I also used PaddleOCR("ru") for recognition

Hello,
For your first point, the median_line_sep parameter is computed automatically based on image characteristics and is used in other parts of the code so I would not advice modifying it. This can be solved in a more general manner on my end with some adjustments to the image processing which is performed.
Second point: this is a known issue on my end as I am checking that there is "content" in at least one cell of the column. However, my method to detect text fails to identify dashes as such as of now.
In conclusion, I am pretty confident that I will fix the first issue but unsure on the second one.

Thanks for the answer.
Regarding the second point, can you tell me in which module this check occurs, I would also like to try to find solutions to this problem.

Thanks for the answer. Regarding the second point, can you tell me in which module this check occurs, I would also like to try to find solutions to this problem.

This is done here.
Basically, it performs a connected components analysis in order to isolate text from other artefacts (lines, images...) and to create contours that should represent all the text present within the image.
In general, dashes are excluded either because of their aspect ratio or because their area is too small

Hi,
A new release has been published and has fixed those issues.


snitch doesn't compile

context: 1.2.2 release, header-only mode, newest VS (17.8.0 preview 2)
Even compiling a trivial
#define SNITCH_IMPLEMENTATION
#include <snitch/snitch_all.hpp>

TEST_CASE("Factorials are computed", "[factorial]") {
   REQUIRE(true);
}

results in error C2397: conversion from 'long' to 'size_t' requires a narrowing conversion

I think I nailed it down to this line, specifically the __LINE__ macro. That might need a cast or something.

Thanks for reporting this, and indeed that was my suspicion as well. A cast in the macro should fix it. Feel free to open a PR, otherwise I will do it tomorrow or this weekend.

A neater alternative would be to use std::source_location, but I was worried of the potential compilation time overhead. Perhaps unjustifiably so since I never measured it.

This was probably more or less the place for which std::source_location was intended, so I'd give it a go yeah.

https://github.com/cschreib/snitch/pull/130/commits/a7d9e462ba30dcb4d638fda3eb4be35de34f74b4 should fix the problem, if you get a chance to test it.
I'm refraining from using std::source_location for now. Its main advantage is that it doesn't require macros, but since snitch checks are macro-based, this isn't something we really benefit from. It would just create overhead, since eventually we want to store a {std::string_view, std::size_t}, that it would need converting into. It will be more useful when reflection comes in and can decompose expressions without macros, then snitch can become mostly macro-free. But we're not there yet!

So many things will get easier with reflections :<. I'll test tomorrow,
thanks.
On Sat, Sep 30, 2023, 11:43 Corentin Schreiber @.***>
wrote:

a7d9e46
https://github.com/cschreib/snitch/commit/a7d9e462ba30dcb4d638fda3eb4be35de34f74b4
should fix the problem, if you get a chance to test it.
I'm refraining from using std::source_location for now. Its main
advantage is that it doesn't require macros, but since snitch checks
are macro-based, this isn't something we really benefit from. It would just
create overhead, since eventually we want to store a {std::string_view,
std::size_t}, that it would need converting into. It will be more useful
when reflection comes in and can decompose expressions without macros, then
snitch can become mostly macro-free. But we're not there yet!
—
Reply to this email directly, view it on GitHub
https://github.com/cschreib/snitch/issues/129#issuecomment-1741727200,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABODVHRHT3BAXNQK2GIBS3TX47SSPANCNFSM6AAAAAA5LNNMTM
.
You are receiving this because you authored the thread.Message ID:
@.***>

Merged and released; I assumed all went fine :)


[MD] update functional tests on edit/update datasource as per UX changes

Signed-off-by: mpabba3003<EMAIL_ADDRESS>Description
[MD] update functional tests on edit/update datasource as per UX changes
Issues Resolved
#2621
#2622
Screenshots
https://user-images.githubusercontent.com/109986843/197042408-f0f58e3e-1c94-4aae-ad92-8329426b715f.mp4
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mpabba3003 The workflow is failing to start OpenSearch https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/3298509590/jobs/5491312242 I do see that you have tested locally as the video shows. Wondering whether your change in OSD side has been merged.
Also the PR is in draft status. Please change to "Ready for review" when it is ready.


[ux] Disable auto-scroll after scrolling "up" while model is generating an answer

ChatGPT and similar apps automatically disable scrolling after scrolling upwards while the model is generating output.
Currently I can't start reading the response until it's fully generated because output is scrolling automatically. In other apps scrolling to the top stops the automatic scrolling which seems like a good solution.

To add to this, on Android the auto scroll is quite jarring even though my phone has 120Hz refresh rate. Could the scrolling be smoothed along with the above?


itest: continued itest refactor and fix - I

Depending on #6759, this PR continues the refactor work to fix the itest flakes. A few bugs have been found and documented in new issues along the way. Most of the work has been dedicated to making icase=test_multi-hop_htlc to pass on all backends. I think due to the current itest situation, this test failed or even didn't get a chance to be run due to its preceding tests failed.
These might be the only two "hard" PRs. The rest would be straightforward, just replacing old patterns and fixing flakes if found.
Only the last 28 commits are relevant.
Depends on #6868

@yyforyongyu, remember to re-request review from reviewers when ready

@crypt-iq: review reminder
@yyforyongyu, remember to re-request review from reviewers when ready

@crypt-iq: review reminder
@yyforyongyu, remember to re-request review from reviewers when ready

@yyforyongyu, remember to re-request review from reviewers when ready

@crypt-iq: review reminder
@yyforyongyu, remember to re-request review from reviewers when ready

@yyforyongyu, remember to re-request review from reviewers when ready

Can be rebased now!


feat(storage-resize-images): put failed resizes in a separate directory

fixes: #563

Note
If the extension is configured to generate multiple sizes, the image will be copied to the failed folder even if only one size fails

closing in favour of https://github.com/firebase/extensions/pull/1374


Calibration Dashboard: no calibration data state

Overview
If there is no calibration data, users should be pushed to this state of the calibration dashboard.
Implementation details
Users will access this state of the dashboard if there is no calibration data and they click "Launch calibration" from the robot settings page.
Design
https://www.figma.com/file/2xjSLHXquNsKvC1mV9NMjr/Milestone-2?node-id=2304%3A194016
Also incorporate these min width designs: https://www.figma.com/file/2xjSLHXquNsKvC1mV9NMjr/Milestone-2?node-id=2304%3A194016
Acceptance criteria

[ ] Deck calibration is the only calibration a user can instigate
[ ] "Calibrate" leads to deck calibration wizard
[ ] Left and Right pipette mount accordions can be opened
[ ] TLC and POC in disabled state when accordions opened
[ ] "Missing calibration data" banner at top of page
[ ] X button closes the page
[ ] Minimum width renders correctly

Selectors for E2E

[ ] X button
[ ] Calibrate
[ ] Open and close accordions

This was released as 6.3.


Improves functionality of ANT Neuro reader

Improves functionality added in #12792
What does this implement/fix?

Adds following meta information in RawANT.info:

'subject_info' ('his_id', 'first_name', 'sex', 'birthday')
'device_info' ('type', 'model', 'serial', 'site')
'meas_date'

Enables lazy data reading (i.e.preload=False argument) in read_raw_ant()

Additional information
This requires bumping up the antio version to 0.3.0.dev0.

@mscheltienne here is the MNE pull request. Could you please review the test functions? Thanks!

@mscheltienne how shall we handle different datasets for testing? If I use pytest.mark.parametrize("dataset", ["ca_208", "andy_101"]) and never mention andy_101 explicitly, I see the following vulture error:
mne/io/ant/tests/test_ant.py:74: unused function 'andy_101' (60% confidence)
Does it anything to do with removal of testing.requires_testing_data decorator?

I'll cut the 0.3.0 release tomorrow and will have a look at this PR then, I'm not sure I understand this last comment from my phone only.

@mscheltienne how shall we handle different datasets for testing? If I use pytest.mark.parametrize("dataset", ["ca_208", "andy_101"]) and never mention andy_101 explicitly, I see the following vulture error: mne/io/ant/tests/test_ant.py:74: unused function 'andy_101' (60% confidence) Does it anything to do with removal of testing.requires_testing_data decorator?

I haven't looked closely as to why you need to define those extra funcs (ca_208 and andy_101) and whether they specifically need to be in the test file, but FYI Vulture is finicky. It might be happier if you moved those definitions into our conftest.py file. If that doesn't work, you can add the func name to tools/vulture_allowlist.py

I pushed a couple of changes, LGTM. If vulture complies, then the function should be added to tools/vulture_allowlist.py (done in the last commit). Let me know if that looks good to you!

@mscheltienne  Thanks a lot!


Issue with permissions while deploying IR with VNET integration

Hi,
Question based on the following documentation: https://docs.microsoft.com/en-us/azure/data-factory/continuous-integration-deployment
I get this error when I want to deploy IR with VNET integration from Azure DevOps:
Forbidden: {
  "error": {
    "code": "LinkedAuthorizationFailed",
    "message": "The client 'XXXXXXXXXXXXX' with object id 'XXXXXXXXXXXXXXX' has permission to perform action 'Microsoft.DataFactory/factories/integrationRuntimes/write' on scope '***/providers/Microsoft.DataFactory/factories/XXXXXXXXXX/integrationRuntimes/XXXXXXXXXXXX'; however, it does not have permission to perform action 'join/action' on the linked scope(s) '/subscriptions/XXXXXXXXXXXXXXXXXXXXXX/resourceGroups/XXXXXXX/providers/Microsoft.Network/virtualNetworks/XXXXXXXXXX'."
  }
} undefined

Could you please tell me how to grant this right?
Thank you

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1e22e4d6-366f-fbf8-e141-8905ca7ab7ae
Version Independent ID: 5be2acf2-66e7-cadf-6666-5a85a65b9771
Content: Continuous integration and delivery in Azure Data Factory
Content Source: articles/data-factory/continuous-integration-deployment.md
Service: data-factory
GitHub Login: @gauravmalhot
Microsoft Alias: gamal

@bertrandpons
Thanks for the feedback! We are currently investigating and will update you shortly.

@YutongTie-MSFT do you have an update about your investigation? Thank you!

@bertrandpons Thank you for your follow-up and sorry for the delay. @himanshusinha-msft is working on it. I believe there should be an update shortly.

@bertrandpons : We were not able to repro the issue at our end , I am going to give it a try again today and let you know that goes .

@bertrandpons : We tried again , but things works fine on our side . We will continue working with you on this with you and we have created a MSDN issue to follow . I am pretty sure the error is coming from some permission issue on the IR .
Please let us know the following

While following the document , on which steps you are encountering this error ?
2.Is this a shared IR used for all the environment ?
3.This IR is a part of custom VNET , is this IR working for any other ADF ?
Can you please check and confirm if you sharing he full error ?

MSDN Issue : https://social.msdn.microsoft.com/Forums/en-US/049ac40e-c28a-41f2-99e2-7ef0d7d8c3db/issue-with-permissions-while-deploying-ir-with-vnet-integration?forum=AzureDataFactory

@himanshusinha-msft thank you for your efforts reproducing the issue.
I am sure also that's about permission at IR level but I can't see how to fix it.

I am not following a specific point in the document. I generated ARM template, added parameters for VNet and subnet in order to apply the template to other environments. While deploying, everything works except the join to VNet
2. The IR is specific to one environment.
3. The IR works in my dev environment with VNet

I confirm that I am sharing the full error

Thanks @bertrandpons , I am closing this issue as this is not related to the document , the steps in the document does seem to work fine .
We will discuss on the below MSDN thread .
https://social.msdn.microsoft.com/Forums/en-US/049ac40e-c28a-41f2-99e2-7ef0d7d8c3db/issue-with-permissions-while-deploying-ir-with-vnet-integration?forum=AzureDataFactory

@bertrandpons  As it appears  we have to engage few other teams to get this resolved .Can you please email us at<EMAIL_ADDRESS>Please provide us with your subscription ID and the URL for this thread.

@himanshusinha-msft Ok thank you. I send an email right now


First attempt in code refactor

    * Add some spacing

    * Remove unused imports

    * Use is instead of == with None

    * Rearrange imports to separate built in modules and external dependencies

    * Remove the dependency on line index variable i

Added the changes you suggested. Thanks.


MTN migrate CI on github action

Tentative to migrate CI on github action.

Codecov Report

Merging #154 (3aa3c16) into master (141574d) will decrease coverage by 0.16%.
The diff coverage is n/a.

:exclamation: Current head 3aa3c16 differs from pull request most recent head 3094535. Consider uploading reports for the commit 3094535 to get more accurate results

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
- Coverage   67.30%   67.14%   -0.17%
==========================================
  Files          39       39
  Lines        1817     1817
  Branches      290      290
==========================================
- Hits         1223     1220       -3
- Misses        508      511       +3
  Partials       86       86

ok !


Use backtick to format reference to file name in working-with-the-npm-registry#publishing-a-package-using-publishconfig-in-the-packagejson-file

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-npm-registry#publishing-a-package-using-publishconfig-in-the-packagejson-file
This issue is intended for newcomers to the OS Docs repo! 💛
If you are veteran of the OS Docs repo and are looking for issues to work on, take a look at our help wanted section ✨
What part(s) of the article would you like to see updated?

Verify the repository field in your project's package.json.

Format reference to file name using backticks per our style guide
Additional information
No response

_ExportResults_2024_02_11 23_01_10.xlsx


Switch to GitHub PR-based development

It would be great to switch to GitHub PR-based development and review as opposed to pushing from internal LinkedIn branches.
This will help expand the community around Pinot and make it a first-class piece of open source software.
Currently Druid does a much better job of engaging the community, and Pinot will not be able to compete under its current model.
This will also allow key Pinot engineers (@dhaval2025, @fx19880617) to maintain a higher level of engagement if they can.

Hi Greg,
This is good idea and something that has been pending from our side. We
will get this done over the holidays.
thanks,
Kishore G
On Fri, Dec 11, 2015 at 2:42 PM, Greg Brandt<EMAIL_ADDRESS>wrote:

It would be great to switch to GitHub PR-based development and review as
opposed to pushing from internal LinkedIn branches.
This will help expand the community around Pinot and make it a first-class
piece of open source software.
Currently Druid does a much better job of engaging the community, and
Pinot will not be able to compete under its current model.
This will also allow key Pinot engineers (@dhaval2025
https://github.com/dhaval2025, @fx19880617
https://github.com/fx19880617) to maintain a higher level of engagement
if they can.
—
Reply to this email directly or view it on GitHub
https://github.com/linkedin/pinot/issues/71.

Awesome, thanks @kishoreg !

+10 for this.  This project will not succeed unless it properly opens up (c.f. Voldemort)

All development on Pinot now goes through GitHub pull requests. :)


[Seagate CORTX Integration Challenge: Singapore] H2O Integration

Describe your changes in brief
H2O.ai + CORTX

Hi @ccdougl
Thanks for the PR as part of the CORTX Hackathon :+1:
Notice your PR is missing a DCO ( https://github.com/Seagate/cortx/blob/main/doc/dco_cla.md ) and can't be accepted to CORTX without it ( https://github.com/Seagate/cortx/blob/main/CONTRIBUTING.md#contribution-process ).
Please sign your commits so that the DCO test can pass. If you need help, don't hesitate reaching out to me.

@ccdougl  can you include a link to the video in your .rst file?

Thanks for your participation in our hackathon and thanks for a great integration!  I'll be merging this soon.  Sorry for the delay.


support macOS from 10.15

#151

add support macOS 10.15
support AppKit and UIKit both!
update run-test.sh for iOS, macOS both!

Awesome!!!!👍👍👍👍👍

thank you!!!! 👍👍👍👍👍


Switch to java 11 by default and adapt to runtime 1.3.x

Fixes #1327

Release Note
Switch to Java 11 as minimum java version
Expose http services through the platform-http service

The e2e test TestRunInitGeneratedExamples fails on kubernetes/buildah for timeout but the same one does not fail with spectrum or when running locally so I think it is not related to the test


browser.saveElementScreenshot() does not work

browser.saveElementScreenshot([fileName], elementSelector) does not seem to work for me. elementSelector was 'body'. It fails silently - I'll try provide more debug info... can someone confirm that this works/doesn't work on the latest version?

Can you post the test you're running? I was able to successfully run it just now.

I'll write a small standalone script to see if I can replicate it.

@klamping - works fine actually. Thanks for giving me a sanity check 👌


restart failing due to weird batterylevel level=none errors

Home Assistant release with the issue:

0.84.6
Last working Home Assistant release (if known):
Operating environment (Hass.io/Docker/Windows/etc.):
hass.io
Component/platform:

ha
Description of problem:
when clicking restart in frontend the restart is not working and the following is found in the error logs:
2019-01-01 19:49:39 ERROR (MainThread) [homeassistant.core] Error executing service <ServiceCall homeassistant.restart (c:73d4134c66934c5b92ef2274adde153a)>
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/homeassistant/core.py", line 1130, in _safe_execute
    await self._execute_service(handler, service_call)
  File "/usr/local/lib/python3.6/site-packages/homeassistant/core.py", line 1143, in _execute_service
    await handler.func(service_call)
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/hassio/__init__.py", line 268, in async_handle_core_service
    error = await async_check_config(hass)
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/hassio/__init__.py", line 148, in async_check_config
    raise HomeAssistantError() from None
homeassistant.exceptions.HomeAssistantError
2019-01-01 19:50:14 ERROR (SyncWorker_11) [pyhap.characteristic] BatteryLevel: value=None is not a numeric value.
2019-01-01 19:50:14 ERROR (SyncWorker_9) [pyhap.characteristic] BatteryLevel: value=None is not a numeric value.
2019-01-01 19:50:14 ERROR (SyncWorker_3) [pyhap.characteristic] BatteryLevel: value=None is not a numeric value.
2019-01-01 19:50:14 ERROR (SyncWorker_7) [pyhap.characteristic] BatteryLevel: value=None is not a numeric value.
2019-01-01 19:50:14 ERROR (SyncWorker_14) [pyhap.characteristic] BatteryLevel: value=None is not a numeric value.
2019-01-01 19:50:14 ERROR (SyncWorker_16) [pyhap.characteristic] BatteryLevel: value=None is not a numeric value.
2019-01-01 19:50:14 ERROR (SyncWorker_11) [pyhap.characteristic] BatteryLevel: value=None is not a numeric value.
2019-01-01 19:50:14 ERROR (SyncWorker_0) [pyhap.characteristic] BatteryLevel: value=None is not a numeric value.
2019-01-01 19:50:14 ERROR (SyncWorker_7) [pyhap.characteristic] BatteryLevel: value=None is not a numeric value.
2019-01-01 19:50:14 ERROR (SyncWorker_19) [pyhap.characteristic] BatteryLevel: value=None is not a numeric value.
2019-01-01 19:50:14 ERROR (SyncWorker_10) [pyhap.characteristic] BatteryLevel: value=None is not a numeric value.
2019-01-01 19:50:14 ERROR (SyncWorker_5) [pyhap.characteristic] BatteryLevel: value=None is not a numeric value.
2019-01-01 19:50:14 ERROR (SyncWorker_14) [pyhap.characteristic] BatteryLevel: value=None is not a numeric value.
2019-01-01 19:50:14 ERROR (SyncWorker_4) [pyhap.characteristic] BatteryLevel: value=None is not a numeric value.
2019-01-01 19:50:14 ERROR (SyncWorker_12) [pyhap.characteristic] BatteryLevel: value=None is not a numeric value.
2019-01-01 19:50:14 ERROR (SyncWorker_13) [pyhap.characteristic] BatteryLevel: value=None is not a numeric value.
2019-01-01 19:50:14 ERROR (SyncWorker_16) [pyhap.characteristic] BatteryLevel: value=None is not a numeric value.
2019-01-01 19:50:14 ERROR (SyncWorker_18) [pyhap.characteristic] BatteryLevel: value=None is not a numeric value.
2019-01-01 19:50:14 ERROR (SyncWorker_8) [pyhap.characteristic] BatteryLevel: value=None is not a numeric value.
2019-01-01 19:50:14 ERROR (SyncWorker_19) [pyhap.characteristic] BatteryLevel: value=None is not a numeric value.
2019-01-01 19:50:14 ERROR (SyncWorker_10) [pyhap.characteristic] BatteryLevel: value=None is not a numeric value.
2019-01-01 19:50:14 ERROR (SyncWorker_0) [pyhap.characteristic] BatteryLevel: value=None is not a numeric value.
2019-01-01 19:50:14 ERROR (SyncWorker_15) [pyhap.characteristic] BatteryLevel: value=None is not a numeric value.

only way for now I can restart HA is to use hass.io ssh access ;/

I seem to have missed this one. Is this still happening?

I don't see it anymore but I changed my homekit usage so that might explain it.
I do though still see restart not taking effect before I pushed restart a 2-3 times - but nothing in error log. But I reckon that is a separate issue.

Thanks for the feedback!


DNF doesn't pick up the latest package version

VSCode Version: code-1.14.2-1500507068.el7.x86_64
OS Version: Fedora 26 - 4.12.9-300.fc26.x86_64 #1 SMP Fri Aug 25 13:09:43 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

Steps to Reproduce:

Install the package code-1.14.2-1500507068.el7.x86_64
Follow steps on https://code.visualstudio.com/docs/setup/linux#_rhel-fedora-and-centos-based-distributions to add the vscode repository.
Install vscode:

$ sudo dnf install code

The message shown is:
Last metadata expiration check: 0:00:27 ago on Wed 06 Sep 2017 10:09:01 AM EDT.
Package code-1.14.2-1500507068.el7.x86_64 is already installed, skipping.
Dependencies resolved.
Nothing to do.
Complete!

The package code-1.15.1-1502904099.el7.x86_64 is in the repository but the DNF command doesn't recognize as the latest package. To overcome this issue I had to install the package directly like:
sudo dnf install https://packages.microsoft.com/yumrepos/vscode/code-1.15.1-1502904099.el7.x86_64.rpm

I can't update to 1.16! Please see attached screenshot, I assume it is the same bug.

STILL BROKEN. Is Fedora still supported? Any feedback?

1.19.0 has been pushed to the repo, let me know if it didn't work and I'll reach out to the repo team.


Websites' deployment link added to the README

The website has been published online also known as "Deployment" using Github pages, with editing the README file to contain a section that includes the website link.

Hi @Ofarouq310  👋 ,
Your project is complete!  There is nothing else to say other than... it's time to merge it 🥇 :
Congratulations! 🎉

Highlights
✅ No linter errors
✅ Good pull request
✅ Good Deployment
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.