Isometric TiledComponent not working properly.

Hello)
Isometric display of the map does not working properly.
Here is the code -
import 'package:flame/game.dart';
import 'package:flame_tiled/flame_tiled.dart';
import 'package:flutter/material.dart';
import 'package:flame/flame.dart';

void main() async {
  WidgetsFlutterBinding.ensureInitialized();
  await Flame.device.setLandscape();
  await Flame.device.fullScreen();

  final game = TheGame();

  runApp(MaterialApp(
    home: GameWidget(
      game: game,
    ),
  ));
}

class TheGame extends FlameGame {
  @override
  Future<void>? onLoad() async {
    await super.onLoad();

    final tiledMap = await TiledComponent.load('10x10.tmx', Vector2.all(64));
    print(tiledMap.tileMap.map.orientation);
    add(tiledMap);
  }
}

Here is the content of 10x10.tmx and iso-64x64-building.tsx files -
10x10.tmx -
<?xml version="1.0" encoding="UTF-8"?>
<map version="1.5" tiledversion="1.7.2" orientation="isometric" renderorder="right-down" width="10" height="10" tilewidth="64" tileheight="32" infinite="0" nextlayerid="2" nextobjectid="1">
 <tileset firstgid="1" source="iso-64x64-building.tsx"/>
 <layer id="1" name="Tile Layer 1" width="10" height="10">
  <data encoding="csv">
1,21,21,21,21,21,21,21,21,21,
1,3,3,3,3,3,3,3,3,3,
1,3,3,3,3,3,3,3,3,3,
1,3,3,3,3,3,3,3,3,3,
1,3,3,3,3,3,3,3,3,3,
1,3,3,3,3,3,3,3,3,3,
1,3,3,3,3,3,3,3,3,3,
1,3,3,3,3,3,3,3,3,3,
1,3,3,3,3,3,3,3,3,3,
1,3,3,3,3,3,3,3,3,3
</data>
 </layer>
</map>

iso-64x64-building.tsx -
<?xml version="1.0" encoding="UTF-8"?>
<tileset version="1.5" tiledversion="1.7.2" name="iso-64x64-building" tilewidth="64" tileheight="64" tilecount="80" columns="10">
 <image source="iso-64x64-building.png" width="640" height="512"/>
</tileset>

This is what spriteSheet looks like iso-64x64-building.png -

And here is how the map is rendered -

No isometric(
Maybe I'm doing something wrong, but in the comments to the code https://github.com/flame-engine/tiled.dart/blob/main/lib/src/tiled_map.dar support for isometric map display is indicated

Unfortunately flame_tiled doesn't support isometric tilemaps yet, we have the IsometricTilemapComponent that supports isometric, but that isn't created from tiled. We are of course open for PRs that implement this feature.


Exec enabled

Hi @georgepstaylor - can you put some detail into the PR notes for this one please? It doesn't look particularly controversial and I see what you're doing, but some context would be helpful in future.

Hi @georgepstaylor - can you put some detail into the PR notes for this one please? It doesn't look particularly controversial and I see what you're doing, but some context would be helpful in future.

Apologies, looks like I forgot all about this PR!


Bump nginx, nginx-rtmp-module, alpine

nginx: 1.19.7 -> 1.21.0
nginx-rtmp-module: 1.2.1 -> 1.2.2
alpine: 3.13 -> 3.14

Thanks for the upgrade, @oxzi. I will test this out and merge if all is good.

Thanks!

Ok, this is strange, but the Alpine 1.14 build is failing with a make: Operation not permitted only in Docker Hub when building the image and in the TravisCI build. Building locally seems fine, though. 🤔
I reverted back to 1.13 for the meantime. I'll have to see if the next maintenance version fixes this.

Thanks a lot for your fast review and merging!

Ok, this is strange, but the Alpine 1.14 build is failing with a
make: Operation not permitted only in Docker Hub when building the
image and in the TravisCI build. Building locally seems fine, though.

Indeed, this is strange. Locally I have tested the changes successfully
and even deployed the new container.

I reverted back to 1.13 for the meantime. I'll have to see if the
next maintenance version fixes this.

Thanks again for your efforts.


Scalafmt 2.5.1

Codecov Report

Merging #257 into master will not change coverage.
The diff coverage is 72.54%.

@@           Coverage Diff           @@
##           master     #257   +/-   ##
=======================================
  Coverage   62.17%   62.17%
=======================================
  Files          38       38
  Lines        1285     1285
  Branches        8        7    -1
=======================================
  Hits          799      799
  Misses        486      486

Impacted Files
Coverage Δ

cli/src/main/scala/laserdisc/cli/CLI.scala
0.00% <0.00%> (ø)

...e/src/main/scala/laserdisc/protocol/ClusterP.scala
67.54% <ø> (ø)

core/src/main/scala/laserdisc/protocol/GeoP.scala
86.01% <ø> (ø)

...src/main/scala/laserdisc/protocol/SortedSetP.scala
0.94% <0.00%> (ø)

...re/src/main/scala/laserdisc/protocol/StringP.scala
5.17% <0.00%> (ø)

fs2/src/main/scala/laserdisc/fs2/MkResource.scala
0.00% <ø> (ø)

core/src/main/scala/laserdisc/laserdisc.scala
68.57% <62.50%> (ø)

...c/main/scala/laserdisc/protocol/EitherSyntax.scala
71.42% <66.66%> (ø)

core/src/main/scala/laserdisc/protocol/Read.scala
76.66% <68.96%> (ø)

.../src/main/scala/laserdisc/protocol/RESPFrame.scala
93.33% <80.00%> (ø)

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b55c16...dfd8c37. Read the comment docs.


breaking change in tsserver public API in ts2.5

Hi. I reported several similar issues before. We (WebStorm) use tsserver (in fact tsserverlibrary) integration. This commit broke our integration because we have to implement the logger interface manually.
Can you provide a default logger implementation for avoiding such problems in future?
//cc @andy-ms

We will get the change reverted, and an @insiders drop released later today.

typescript@rc should now point to<EMAIL_ADDRESS>which has a revert to this change. sorry for the hassle.


improve typescript typings

it would be cool if typescript typings are installed together.  Also the current one is hot really helpful, since they don't define types of events.

I don't think we have types at all, but PR is welcome.

Probably in next minor or major release. We have more important issues and PRs before that. If you want to help and submit typings, that would be great.

@Nemo157 Can you update the declaration file of typescript.

I'm far out of the typescript ecosystem now

Ah! But I'm looking forward to your return

PR for merging types here is welcome! :)

Ask for the type maintainer to make a PR here, or you can do a PR yourself. Closing since there is no further actions on our side.

Ask for the type maintainer to make a PR here, or you can do a PR yourself. Closing since there is no further actions on our side.

Let's try to type it for v2/v3, linking #635 as a reminder.

Let's try to type it for v2/v3, linking #635 as a reminder.


change(deps): Enable a tinyvec feature to speed up compilation

Motivation
Enable a feature in tinyvec that speeds up compilation by about half a second per crate. It also speeds up compilation in any dependencies of that crate.
This could make Zebra builds a few seconds faster.
https://github.com/Lokathor/tinyvec/issues/161
Review
This is a low priority fix.
Reviewer Checklist

[ ] Tests pass

@mergifyio update


App crashes after React-Native Update

Hey there, i am now using React-Native 29.2 and facebook-login 1.2.0
Since i have processed the update my app crashes as soon as i try to call the FBLogin:
E  FATAL EXCEPTION: main
E  Process: com.mobileemotion.camigo, PID: 2681
E  java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.equals(java.lang.Object)' on a null object reference
E      at com.facebook.login.LoginClient.getLogger(LoginClient.java:367)
E      at com.facebook.login.LoginClient.logAuthorizationMethodComplete(LoginClient.java:417)
E      at com.facebook.login.LoginClient.tryNextHandler(LoginClient.java:200)
E      at com.facebook.login.GetTokenLoginMethodHandler.getTokenCompleted(GetTokenLoginMethodHandler.java:119)
E      at com.facebook.login.GetTokenLoginMethodHandler$1.completed(GetTokenLoginMethodHandler.java:74)
E      at com.facebook.internal.PlatformServiceClient.callback(PlatformServiceClient.java:157)
E      at com.facebook.internal.PlatformServiceClient.handleMessage(PlatformServiceClient.java:141)
E      at com.facebook.internal.PlatformServiceClient$1.handleMessage(PlatformServiceClient.java:62)
E      at android.os.Handler.dispatchMessage(Handler.java:102)
E      at android.os.Looper.loop(Looper.java:135)
E      at android.app.ActivityThread.main(ActivityThread.java:5254)
E      at java.lang.reflect.Method.invoke(Native Method)
E      at java.lang.reflect.Method.invoke(Method.java:372)
E      at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)

My Crashlytics reports me that the crash is in
LoginClient.java line 367 com.facebook.login.LoginClient.getLogger

I really don´t know why, but after updateing my build gradle from
    classpath 'com.android.tools.build:gradle:1.3.1'

to
    classpath 'com.android.tools.build:gradle:2.1.2'

and rebuilding, everything works fine
Any ideas how this is related?

could be that the fb sdk is using a newer version of the gradle build tools for something specific.
by relation that would be my only conclusion from what you say.
if you downgrade, does it break again?

Nope, that wasn´t the issue...I have reverted everything, and now it still works :P Sorry, but i can´t reproduce the error.

close

cool no prob

I just encountered this exact error and solved it by walking through the Android setup for this module. I was missing the string resources and a few lines in the manifest.
Hope this helps anyone who encounters this error in the future!


Auditor skeleton

Closes #18.

Just to prove the concept out here, I've hooked everything up the CLI:
$ pip-audit --dry-run
INFO:pip_audit.audit:Dry run: would have audited attrs
INFO:pip_audit.audit:Dry run: would have audited black
INFO:pip_audit.audit:Dry run: would have audited bleach
INFO:pip_audit.audit:Dry run: would have audited certifi
INFO:pip_audit.audit:Dry run: would have audited charset-normalizer
INFO:pip_audit.audit:Dry run: would have audited click
INFO:pip_audit.audit:Dry run: would have audited colorama
INFO:pip_audit.audit:Dry run: would have audited coverage
INFO:pip_audit.audit:Dry run: would have audited dataclasses
INFO:pip_audit.audit:Dry run: would have audited docutils
INFO:pip_audit.audit:Dry run: would have audited flake8
INFO:pip_audit.audit:Dry run: would have audited idna
INFO:pip_audit.audit:Dry run: would have audited importlib-metadata
INFO:pip_audit.audit:Dry run: would have audited iniconfig
INFO:pip_audit.audit:Dry run: would have audited isort
INFO:pip_audit.audit:Dry run: would have audited keyring
INFO:pip_audit.audit:Dry run: would have audited mccabe
INFO:pip_audit.audit:Dry run: would have audited mypy
INFO:pip_audit.audit:Dry run: would have audited mypy-extensions
INFO:pip_audit.audit:Dry run: would have audited packaging
INFO:pip_audit.audit:Dry run: would have audited pathspec
INFO:pip_audit.audit:Dry run: would have audited pip
INFO:pip_audit.audit:Dry run: would have audited pip-api
INFO:pip_audit.audit:Dry run: would have audited pip-audit
INFO:pip_audit.audit:Dry run: would have audited pkginfo
INFO:pip_audit.audit:Dry run: would have audited platformdirs
INFO:pip_audit.audit:Dry run: would have audited pluggy
INFO:pip_audit.audit:Dry run: would have audited pretend
INFO:pip_audit.audit:Dry run: would have audited py
INFO:pip_audit.audit:Dry run: would have audited pycodestyle
INFO:pip_audit.audit:Dry run: would have audited pyflakes
INFO:pip_audit.audit:Dry run: would have audited Pygments
INFO:pip_audit.audit:Dry run: would have audited pyparsing
INFO:pip_audit.audit:Dry run: would have audited pytest
INFO:pip_audit.audit:Dry run: would have audited pytest-cov
INFO:pip_audit.audit:Dry run: would have audited readme-renderer
INFO:pip_audit.audit:Dry run: would have audited regex
INFO:pip_audit.audit:Dry run: would have audited requests
INFO:pip_audit.audit:Dry run: would have audited requests-toolbelt
INFO:pip_audit.audit:Dry run: would have audited rfc3986
INFO:pip_audit.audit:Dry run: would have audited setuptools
INFO:pip_audit.audit:Dry run: would have audited six
INFO:pip_audit.audit:Dry run: would have audited toml
INFO:pip_audit.audit:Dry run: would have audited tomli
INFO:pip_audit.audit:Dry run: would have audited tqdm
INFO:pip_audit.audit:Dry run: would have audited twine
INFO:pip_audit.audit:Dry run: would have audited typed-ast
INFO:pip_audit.audit:Dry run: would have audited types-dataclasses
INFO:pip_audit.audit:Dry run: would have audited types-requests
INFO:pip_audit.audit:Dry run: would have audited typing-extensions
INFO:pip_audit.audit:Dry run: would have audited urllib3
INFO:pip_audit.audit:Dry run: would have audited webencodings
INFO:pip_audit.audit:Dry run: would have audited zipp
Package Version ID Description Affected Versions
------- ------- -- ----------- -----------------

Whoops, that was a premature merge. That reminds me to set up the review guards...


lineidx for custom TSV file

Thank you for your great work on this model and repo.
I'm trying to use this model to caption some of my own images and created an image TSV file as described in the README.md with two columns, one with the image key and one with the encoded byte string. However, when I run the example single TSV command with my own tsv file, entitled my_images.tsv , I get the following error:
FileNotFoundError: [Errno 2] No such file or directory: 'my_images.lineidx'

What is the lineidx mean here? Evidently, there is something else that I need to include in order for the model to run on my TSV but I can't find any information about it in the repo. What else do I need to do?

To generate tsv data, please use the following function
https://github.com/microsoft/GenerativeImage2Text/blob/b22f8e3b5ab1c14815abf90759d1cefe1c307753/generativeimage2text/tsv_io.py#L356
Some examples to use this function: https://github.com/microsoft/GenerativeImage2Text/blob/b22f8e3b5ab1c14815abf90759d1cefe1c307753/generativeimage2text/data_prepare.py#L40
The lineidx file tells the byte offset for each line, such that it can support random seeking. Feel free to re-open it for any other questions.


Any plan to support api v2?

https://github.com/GoogleCloudPlatform/ios-docs-samples/tree/master/dialogflow/

Seems like a backend/cloud functions are the way to go in mobile applications.

Any feedback for this one, please, it is very important to me?

Any update on api V2?

any V2 support using Objective C or Swift?


archive, graphdriver: double decompress fix

the magic DecompressStream is buried through pkg/archive, pkg/chrootarchive and how (*daemon/graphdriver.Driver).ApplyDiff() consume the tar stream.
This was causing a double decompression, and when the tar layer is empty results in premature EOF.
This adds functions to operate on Uncompressed streams, and set the expectation that (*graphdriver.Driver).ApplyDiff() on handles uncompressed streams.
/cc @tiborvass @icecrime

@vbatts it looks like there are some lint errors:
Errors from golint:
pkg/chrootarchive/archive.go:23:1: comment on exported function UntarUncompressed should be of the form "UntarUncompressed ..."
pkg/chrootarchive/archive.go:50:8: should omit type io.Reader from declaration of var r; it will be inferred from the right-hand side

---> Making bundle: validate-lint (in bundles/1.8.0-dev/validate-lint)
Errors from golint:
pkg/chrootarchive/archive.go:23:1: comment on exported function UntarUncompressed should be of the form "UntarUncompressed ..."
pkg/chrootarchive/archive.go:50:8: should omit type io.Reader from declaration of var r; it will be inferred from the right-hand side

golint!

wait on this for a sec

Spent a lot of time yesterday determining that #15087 is unrelated to this...
This does fix the issue with EOF on empty v1 layers. I will now check out the errors on experimental.

Thanks for the prompt fix! Overall looks good, but I haven't done a thorough review yet.
Ping @stevvooe @dmcgowan: please review!

@dmcgowan switched to the ioutil.NopCloser
PTAL

LGTM
Just a few questions though

LGTM, but would love to see the CI green on this one ;)

Waiting for CI.

LGTM

Green \o/

cherry picked into #15091


"Failed to match key"

So I have Hactool, I've been trying for the past 2 hours to get my SSBU modded and I run into this:
Failed to match key errors running down my cmd
I'm trying my hardest to know whats going on... I've put prod.keys into a .switch folder and i have my gamedump in my Hactool directory. Please someone help!

"Failed to match key" is not your problem, that just shows up whenever you have extra unneeded keys in the prod.keys file (for whatever reason).
What's the size of the file you're trying to extract?

you mean my nsp correct? 489,475 kb

sorry if im wrong with anything here, not used to this stuff

You might want to censor that picture since sharing keys is illegal

how please quick XD

do i just upload a different one with them blacked out or can i do it here

or we'll just do that as the problem isnt the keys

ill be back in the morning so sorry if anyine says anything and i cant respond

489,475 kb

Smash is over 13gb, not 489mb.

Thats very strange why it would give me that file do you know of any reason why it would do that? I used that SD to KSP thing

Well i may have just found something... I dont know how the program would react to this but i realized that i dont have much storage left... i have a hard drive on me to try it again but my switch is taking up my usb slot... any way to unplug and keep the process safe so i can use my hard drive?

Welp i think i found it... Again, as I'm unfamiliar with programs like this, I pulled a dumb move and didn't know the process took a while to complete... Then again i still didn't have the storage so I'm trying a different computer that has the storage. I've redone almost everything so i should be ok

To link to what Bakugo said, it can be seen in hactool 1.4.0 extkeys.c:213#extkeys_initialize_settings where it retrieves all of the keys with their values from the file first and iterates through that list.


Manual change of dag_run state, leaves database in inconsistent state

Environment

Version of Airflow: 1.6.2
Operating System: Linux
Python Version: Python 2.7.11

Description of Issue
When you try to manually change the state of a dag_run via this view:

the dag_run is not correctly updated in the database. Indeed, in the Tree view the global state of the dag_run becomes white (=no satus). See below:

And if you click on the white box, I get an error page with following error:

Can you please create a Jira issue for this?


Add OpenTelemetry instrumentation

Pass parent context to HTTP requests and use the OTEL transport to make sure that traces are propagated. The OTEL transport will also create spans for all HTTP requests.
This matches the current behavior of the Trino JDBC driver. It also doesn't create explicit spans for the whole query.
Supersedes #92
I'll keep this as a draft before doing some manual testing.

@wendigo @losipiuk the OTEL libraries require Go 1.20. Do you think we can raise the minimum required Go version here? Go 1.20 was released Feb. 1, 2023. On the other hand, there are very few new features in this driver, so users who can't immediately upgrade Go can lock in an older version of this driver.


new logo

ready your logo 😃. if you wanna make any change dont worry, here you have all the files for having the full control of your logo Google Drive

Thanks!

Oops. Forgot to merge the pull request. Sorry.


How to fetch the last batch in a multigpu model

The new dataset API is awesome, but I don't know to fetch the last batch in my model

@TomorrowIsAnOtherDay I'm sorry, but I'm not understanding from your screenshot what the problem is. You've set a batch size of 12, and the dataset returns 8 batches of that size, consuming 96/100 of the values in your dataset. Are you expecting the batch on the next call to be filled out somehow?

@cy89 yes, I wanted to feed the last examples(97/98/99)into my multi-gpu model

Thanks, @TomorrowIsAnOtherDay. I think the interface is working-as-intended. It's probably a bad idea for datasets to automatically pad your data for you out to the desired batch size, as this might have weird effects on your training. I would expect that randomization plus setting some number of epochs is the answer to uniformly using data that doesn't exactly match the batch size.
This question is better asked on  StackOverflow since it is not a  bug or feature request. There is also a larger community that reads questions there. Thanks!

I agree it's a bad idea to pad data, but it'll be helpful to return a tensor of smaller batch.
For example, if we want to calculate accuracy on a validation set, each sample needs to be fetched before an OutOfRangeError is raised. In tensorpack we have a remainder=False option for this purpose.

@cy89 @ppwwyyxx Thanks, Maybe I should provide an parameter to specific whether to drop the last batch or not.
@ppwwyyxx But in my case, The problem is not whether to use a small batch size or not to fetch the last batch.I can't fetch the last batch in multigpu model.If I use only one gpu and the problem doesn't exist, because Dataset API will provide the last batch with a smaller batch.
#12855


Pressing on garbage icon in file list still triggers load the blocks file

which destroys the javascript code. The click event propagation is not properly stopped.

1924d0cb363df6d3fe977598b951f39ef0e845cf


Remove API Client and HTTP Request Factories

Summary of changes

Remove core API class
Add SecureTokenServiceAPI
Add TrackingEventsAPI
Remove HTTP Request Factories and move request building logic into API layer

Checklist
~- [ ] Added a changelog entry~
Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire

ADR: Remove Core API and HTTP Request Factories


8.0.3 broken?  Module jest-puppeteer should have "jest-preset.js" or "jest-preset.json" file at the root.

🐛 Bug Report
Jest refuses to run due to an error in the preset
● Validation Error:

  Module jest-puppeteer should have "jest-preset.js" or "jest-preset.json" file at the root.

  Configuration Documentation:
  https://jestjs.io/docs/configuration

To Reproduce
npm init -y
npm install --save-dev jest-puppeteer puppeteer jest
echo '{"preset":"jest-puppeteer"}' > jest.config.json
npx jest

System:

OS: macOS 13.2.1
CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
Memory: 73.23 MB / 16.00 GB
Shell: 3.6.0 - /usr/local/bin/fish

Binaries:

Node: 18.13.0 - /usr/local/bin/node
Yarn: 1.22.11 - /usr/local/bin/yarn
npm: 9.6.0 - /usr/local/bin/npm

npmPackages:

jest-puppeteer: ^8.0.3 => 8.0.3

It worked, thanks! I'll probably report more issues later (I'm updating some deps in https://github.com/fregante/webext-dynamic-content-scripts/pull/56)

@fregante I am also experiancing a bunch of chrome windows being sparned. Do you know any way to work around this?


next-gen base cluster: validate that it meets requirements

In 0.9.x, a "base cluster" replaces the "cluster spec". It can be arbitrarily complex CAPI manifest. In order to use it as a base for other clusters, gen2 arlon currently imposes several requirements:

No namespace must be specified (to allow argocd Application to override the namespace)
Only one Cluster resource
All CAPI (and in the future crossplane) resources must be stored in a single YAML file (the manifest). The name can be chosen by user, it will automatically be detected
There must be a kustomization.yaml file. It references the manifest as a resource, and the configurations.yaml file as a configuration.
There must be a configurations.yaml file with the right nameReference spec to allow prefixing the name of all CAPI resources.

Arlon needs to have an API and CLI to validate that a base cluster source in git meets those requirements.

duplicate of #100


Optimize_Images_for_Better_Performance

We need to optimize images on our website to improve loading speed and overall performance. This includes compressing existing images and converting them to more efficient formats like WebP.
Compress Images:
Use tools like TinyPNG or ImageOptim to reduce the file size of current images without sacrificing quality.
Convert to WebP Format:
Change image formats from JPEG/PNG to WebP where appropriate to enhance performance.

@StephCurry07

so you are instructing me by adding a note in highlight?

Also you instructed wrong...ill surely assign you 'hacktober-accepted' 😊

Hacktoberfest-accepted!!

@StephCurry07 are you assigning me??


issue#270 solved: Tag Picker Display Issue with 15 or More Tags

demo of the solution:
https://github.com/lucavallin/first-issue/assets/91373023/5944ce98-88cb-422e-8d97-d2db7f933449

Hey @Vivek-04022001! There are a few conflicts because of the recent redesign.

okay, I will look into my code.
But I would really  appreciate the new look of the website. The deep blue color and golden yellow color looks so awesome.


Kibana Index and data seems loosing after restart.

(Original issue 6 created by saliniashok on 2018-09-07T07:04:06.521606+00:00)
I used the command
sudo docker run -d -p 9200:9200 -p 5601:5601 nshou/elasticsearch-kibana
to start
After stopping, the index and data seems loosing. I used the command
sudo docker stop

(Original issue 6 last updated on 2019-09-02T17:13:53.068606+00:00)
(Issue automaticaly closed due to status in Bitbucket: resolved)

(Original comment by nshou on 2019-01-12T06:36:44.200904+00:00)
The index and data should not have been lost only by stopping/starting the container even without any volume-mounting trick. I've just confirmed by the following commands and it worked well:
#!shell
$ docker run -d -p 9200:9200 -p 5601:5601 nshou/elasticsearch-kibana
0ab0dcb42735ac2a0c002791f64a2eaa1235b351c56f9b43b782a90cc03605ae
$ docker ps -aq
0ab0dcb42735
# Insert a bunch of data...
$ docker stop 0
0
$ docker start 0
0
# Now I can see the inserted data!

I would appreciate it if you could post a series of the command lines and its output to reproduce the issue.

(Original comment by nshou on 2019-09-02T17:13:49.273180+00:00)
I am closing this issue due to inactivity.


Update Containerized Data Importer (CDI) resource - 1977

[Auto generated]
Number: [#1977]

openshift-python-wrapper[pull_request][4f0f-11ef-9610-b30f390725ed][PR 1977]: Closing issue for PR: Update Containerized Data Importer (CDI) resource.
PR was closed.


All Internet Archive links, used in reference testing, are broken

Apparently the Internet Archive, which we depend on for a very large number of (linked) reference test-cases, has recently changed how they serve PDF files.
Previously, a URL such as http://web.archive.org/web/20160112115354/http://www.fao.org/fileadmin/user_upload/tci/docs/2_About Stacks.pdf would return a PDF file directly. However, now a HTML file is returned instead (which then points to the actual PDF file).
For someone cloning the PDF.js repo, and attempting to set-up testing for the first time, this means that all linked test-cases will now fail. Furthermore, it also means that we cannot use the Internet Archive when adding new test-cases.
Since the HTML file returned does contain a direct link to the PDF file, embedded in an <iframe> tag, we could perhaps add special-casing for Internet Archive URLs in test/downloadutils.js, such that the HTML file is first downloaded and parsed to obtain a direct PDF link.

It looks like we can just update all links to add if_ after the ID in the URL. For example, this is current linked test case (issue1127.pdf.link):
https://web.archive.org/web/20160114105739/https://vmp.ethz.ch/pdfs/diplome/vordiplome/Block 1/Algorithmen_%26_Komplexitaet/AlgoKo_f08_Aufg.pdf
This can be changed to:
https://web.archive.org/web/20160114105739if_/https://vmp.ethz.ch/pdfs/diplome/vordiplome/Block 1/Algorithmen_%26_Komplexitaet/AlgoKo_f08_Aufg.pdf
to get the direct link.
I have tested this with a number of linked testcases and it seems to work for all of them.

It looks like we can just update all links to add if_ after the ID in the URL. For example, this is a current linked test case (issue1127.pdf.link):

I've noticed that as well, but I'm not sure if we really want to assume that the format will be constant in the future (it could potentially even depend on e.g. load balancing or similar things). I'd hate for us to do search-and-replace on all *.pdf.link files now, just to have to redo it in a couple of months time.

Correct, but doesn't the same apply for HTML parsing? If the markup changes, we may get the same problem. Personally I'm fine with either solution by the way, because I'm really on the fence about which one is faster/more future-proof.

There is also fallback code at https://github.com/mozilla/pdf.js/blob/master/test/downloadutils.js#L40 which I assume does not work anymore. I also think we should remove that because silently handling errors does not sound right in the context of testing.
Since we have Internet Archive-specific code there anyway, I think I'm fine with handling this over there. Let's try to consolidate the code in one block as much as possible.

I'd rather have things fail loudly so we know there is an error and can fix it properly.

Just FYI: I attempted to implement something along those lines in PR #7947, but the resulting discussion indicated that failing hard wasn't really desirable behaviour here.

I have one more solution for this. It's a bit of a hybrid approach for the two solutions. How about in test/downloadutils.js we detect that we are dealing with an Internet Archive URL and perform the if_ transformation there? That we we don't have to search/replace and can easily adjust the code if the Internet Archive were to change its format again (or implement HTML parsing there later on)?

@timvandermeij https://github.com/mozilla/pdf.js/issues/8920#issuecomment-330047410 seems like a good compromise for now! Time permitting, do you want to take a stab at implementing it (since the current state isn't great for someone attempting to run tests for the first time)?

Yes, I'm hoping I can take a look at this in the coming weekend.


gnu-chess: add HEAD

add HEAD.
remove unrecognized argument --disable-debug.
remove doc.install as they are not real docs, but source files for making docs.
modify test to better handle versions, e.g, comparing 6.2 vs 6.2.1 would have still passed.

@BrewTestBot test this please

Merged in d302380ed0abb0280948721d4e659f05ef74db5a ♔♕


Disable debugger statments

We don't want these guys getting through to production code as they can potentially stop a sites operation.
debugger;
I suggest we disable them by default in our lint config. We can still use them during development if we need to however this will now cause a build or lint to fail.. which i think is what we want.

Great idea @jennasalau. I'm good with this.


Version 3 using grep

This based on our discussion, this solution is simplified over the last #147 , and its very fast as well.
I wanted to try that first, and it seems quick (I added some tests) and flawless. I looked only for about 10 min at the bisect documentation, so if you still want me to develop a solution based on that let me know - I don't mind. Just trying to allocate resources appropriately!

I reworked this using git show instead of git checkout, generalizing a bit, and returning CGI responses.
I looked at git bisect but you were right: it looks too complicated for this.
Now I'll try to hook it up to the server.

I reworked this using git show instead of git checkout, generalizing a bit, and returning CGI responses.
I looked at git bisect but you were right: it looks too complicated for this.
Now I'll try to hook it up to the server.


Update documentation to lightning 2.0

What does this PR do?
Fixes #1632

Removed references to DP
Updates train_epoch_end -> on_train_epoch_end

Before submitting

[ ] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure to update the docs?
[ ] Did you write any new necessary tests?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?
Make sure you had fun coding 🙃

@SkafteNicki could you pls also update the integration tests accordingly: https://github.com/Lightning-AI/metrics/blob/master/tests/integrations/test_lightning.py

@Borda should be good now :)


WIP Signup

With @bantic. This completes many of the edge cases around signup.

Display validation errors for organization name
Add stack handle to the app creation page (will need style, and a checkbox for phi-ready. Would need explanation that phi-ready will require a production plan on the next page)
Create stack, and optionally apps and databases, after payment info is entered

TODO:

[x] needs rebase

I would like to make provisioning databases (both upon validating an email and upon entering payment info when an email is valid) a separate PR.

Pending a passing build, this is good-to-go imo

rebased. @sandersonet I'm going to kick this to you since @bantic and I already paired on much of it.


Missing/Insufficient Environment Vars and Links

Built using:
python3 docker_openvino.py build --package_url https://storage.openvinotoolkit.org/repositories/openvino/packages/2020.3.2/l_openvino_toolkit_data_dev_ubuntu18_p_2020.3.355.tgz

Then use it as base image for some other image.
"model_downloader" path missing in PYTHONPATH and PATH //unlike model_optimizer
(removed 2nd issue written earlier): my 11th Gen Rocket Lake doesn't have "/dev/dri" directory to run DLStreamer vaapih264enc  on Ubuntu20. Not in scope for this repo.

Hi @ojjsaw,

PYTHONPATH and PATH variables are set inside a container using setup environment script. We discuss the ability to add Model Downloader paths to this script. We will also add a native environment to a container for future releases starting from 2022.1.
We have this configuration guide for GPU. You can follow it to configure a container to use GPU capabilities.


Feedback needed: make the network yours!

Ok, so the network website is now up and running, but that's just the start of it. I really need your input to help understand how to make the network as inclusive and useful as possible.
A couple of things I'd specifically like feedback on are:

Does the welcome message on the home page feel like it's speaking to you? If not, why not?
What do you want from the network? What would help you develop your data science/analysis/statistics skills?

Any and all feedback is welcome: please reply here (signing up for GitHub only takes a few seconds) or message me on Twitter or Mastodon.

Congratulations! Getting this far is an achievement in itself
For the front page, I'd add a some lines on 'what do we mean by data science?' and 'why statistics?' because it might not be obvious to everyone.

I know how hard it is to change a project mid-stream around the disruption of COVID. You want to honour the previous thinking but also need to (sometimes radically) update plans.
With that in mind, I'd separate the 'how the project got here' bits (which are a great example of transparency) from the 'what next' bits. Having that historical information is great, but putting text together across different documents to understand what concrete actions and outputs you're currently planning is hard.
Questions I had include: where are the learner hours coming from - are you planning on running events, or directing people to existing courses? What does joining the network mean in concrete terms? What can people do to help you build the network? How will you show (not tell) relevant work?
And going back to specific updates - after commenting on github, what are the next calls to action, and can you put them on the front page?


Documentation uses SHA-1 (deprecated)

Change your documentation at step 14 to state SHA-2 instead of SHA-1.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2e75c5bf-aefe-154e-de20-a01ab982adf6
Version Independent ID: 92189653-36bb-7e01-aa84-20fbad5808c8
Content: Install the Certification Authority
Content Source: WindowsServerDocs/networking/core-network-guide/cncg/server-certs/Install-the-Certification-Authority.md
Service: windows-server-threshold
GitHub Login: @shortpatti
Microsoft Alias: pashort

Hi @visualblind, thanks for catching.  I've updated the document with SHA2.


Use Dfe sign in for support staff authentication

Context
We currently have a devise based login for the support console of AYTQ/Check.
This is complexity we probably don’t need now we have a DfE Sign in integration.
Switch to using DfE Signin.

Changes proposed in this pull request

Remove Devise configuration for Staff/Support authentication.
Add staff specific DSI omniauth configuration.
Reuse common auth methods across Check/Support controllers.
Add support specific sign in and sign out functionality similar to Check.
Refactor system specs to cover DSI authentication.
Refactor Check system specs to work with common authentication steps.

Guidance to review

Link to Trello card
https://trello.com/c/1PcLM39J/117-use-dfe-signin-for-support-login

Checklist

[x] Attach to Trello card
[x] Rebased main
[x] Cleaned commit history
[x] Tested by running locally

 Use DfE Signin for support login


Object and elf files are deleted after build

I don't know why, but each time I build a project, after building, the intermediate object files and the elf file, are deleted, just after the the output binary padding. It always looks like this (notice the last line doing the rm):
dd if=temp.bin of=out.bin bs=8K conv=sync
8+1 records in
9+0 records out
73728 bytes (74 kB) copied, 0.000230092 s, 320 MB/s
rm mw/module1.o main.o mw/module2.o out.elf

I had a look to the Makefile, and it's a mystery for me why these files are deleted, as the only places in which $(RM) is invoked, don't look like to be the ones that are deleting these files.
I do not want these files to be deleted, as sometimes I examine them (e.g. disassemble using objdump), but I have no clue why they are deleted.

That's standard Make stuff.  Intermediate files such as .elf .o are deleted by default.  There are probably switches you can send to make to prevent this.

Didn't know about "intermediate files" in makefiles (and my own produced simple makefiles never automatically delete object files). I have been reading a bit, and got the files to persist by adding to the makefile:
.SECONDARY: $(RESOURCES) out.elf

Thanks for the tip!
BTW, I think deleting object files each build doesn't make too much sense, as it will force you to rebuild them even if their source files have not been modified.


Add function names to error messages

What's this PR do?
Adds a suffix to error messages in our Model static functions (and a new Phoenix fetchCampaign helper function) to help troubleshoot where network errors come from.
How should this be reviewed?
Try to break things. One way to see the prefix in action is by attempting to post a signup keyword (for a campaign you haven't signed up for), but with an invalid DS_PHOENIX_API_PASSWORD config variable. Instead of a 500 error, the returned response should look like:
{
 "error": {
   "code": 401,
   "message": "Signup.post error:Unauthorized"
 }
}

Any background context you want to provide?
We mostly see these errors when during high volume after sending out a broadcasts.
Relevant tickets
Fixes #816 , Refs #810
Checklist

[x] Tested on staging.

Our memory usage spiked after deploying this (v290)

I've rolled back the Heroku deployment and memory immediately down to 8%, will keep 👀  on it

22 hours later and it seems safe to say the issue is somewhere in this PR 🤕

yes... but for some obscure reason. I'm going to attack this all day today. I'll update you later on what I find. That code would mostly impact users that are reporting back. That is a little cumbersome to test at scale, but I'll try to devise some strategy to do that.

Thanks @rapala61 -- really thankful you can take a look, let me know if I can be helpful. There are 2 main changes in this PR:

creating copies of a caught error,  and altering the message

replacing all calls to phoenix.Client.campaigns.get with the helper function phoenix.fetchCampaign, for the sake the first change (customizing the caught error message)

Got it. Could you also rollback the release in Github? Thanks!

Chatted with @rapala61 about ☝ in Slack -- holding off on reverting these commits for now, as it'd be a bit messy -- and we're still unsure of the cause.
I was noticing that the memory usage jumped up around 3 hours after deployment, which seems to be timed with when Quicksilver should have sent Relative Reminder messages out. We've redeployed 3.6.1 (v292) to see if we see the same spike around 12 PM EST today. The past half-hour it's been running on production hasn't shown a increase in mem usage... but we'll 👁


Add an Issue Template to Contributing Guide

There is no format on how to create an issue in the contributing guide and I believe that just as making a PR and commiting good, clear messages are important, creating a good issue that is clear and straight forward is just as important.

@geekiedj here is the issue. Do you have any idea on how the format can look like?


Shared libraries are not getting generated..

What platform/OS are you using?
Linux Cross compilation - arm-linux-gnueabihf
Which version of the SDK?
1.7.190
What compiler are you using? what version?

arm-linux-gnueabihf - 6.6.1

What are your CMake arguments?
cmake ../aws-sdk-cpp -DCMAKE_TOOLCHAIN_FILE=../aws-sdk-cpp/ToolchainFile.cmake  -DBUILD_ONLY="lambda" -DCMAKE_PREFIX_PATH=/mvoiceapp/avs/alexa/prebuilts -DBUILD_SHARED_LIBS=ON
Can you provide a TRACE level log? (sanitize any sensitive information)
Installing: /usr/local/bin/libaws-cpp-sdk-kinesis.a

Hi @sakthisg,
Can you provide the error you are getting?

You only build lambda by specifying -DBUILD_ONLY="lambda", it's not a surprise that kinesis is not installed.

Correct, It is building all .a libraries. I need to build only .so for
Lambda..Is there anything wrong in the cmake command?
On Thu, Sep 26, 2019 at 11:32 PM Andrew Tang<EMAIL_ADDRESS>wrote:

You only build lambda by specifying -DBUILD_ONLY="lambda", it's not a
surprise that kinesis is not installed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aws/aws-sdk-cpp/issues/1246?email_source=notifications&email_token=AHP2WX7DWVZK4OQDF6HFYYLQLT2KFA5CNFSM4I23EA5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7WORNY#issuecomment-535619767,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHP2WX34ZCQ3CV7PJHOQ73DQLT2KFANCNFSM4I23EA5A
.

@sakthisg, unless you specifically set "-DBUILD_SHARED_LIBS=OFF" the libs generated should be ".so" by default (on linux).
The only thing I can think that may cause this the cmake cache, could you try deleting it and re running your cmake and make command?

Yes, that is what i have learnt from the documentation.  I have deleted the
cmake cache, build folder. Running the cmake and make. Still i face the
same issue. (only static libraries are generated)
On Fri, Sep 27, 2019 at 10:53 PM Gilberto Lopez Zayas <
<EMAIL_ADDRESS>wrote:

@sakthisg https://github.com/sakthisg, unless you specifically set
"-DBUILD_SHARED_LIBS=OFF" the libs generated should be ".so" by default (on
linux).
The only thing I can think that may cause this the cmake cache, could you
try deleting it and re running your cmake and make command?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aws/aws-sdk-cpp/issues/1246?email_source=notifications&email_token=AHP2WXYN65HOWHQSB4ET3NDQLY6RPA5CNFSM4I23EA5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7ZSEBA#issuecomment-536027652,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHP2WX3IHLTDBMYOB36TIATQLY6RPANCNFSM4I23EA5A
.

@sakthisg , could you check the ../aws-sdk-cpp/ToolchainFile.cmake and see if you're not setting a flag for shared libraries?
Or to make sure that the problem is not part of the sdk, can you try building without that argument?

I am confused by
Can you provide a TRACE level log? (sanitize any sensitive information)
Installing: /usr/local/bin/libaws-cpp-sdk-kinesis.a
Why do you need that toolchain file?
Can you please just try cmake ../aws-sdk-cpp -DBUILD_ONLY="lambda" -DBUILD_SHARED_LIBS=ON

As I need to cross compile so i am using the tool chain file. And i am not setting the shared libraries flag in  ../aws-sdk-cpp/ToolchainFile.cmake!

It's helpful to post your CMake output when cross-compiling SDK

CMakeOutput.log
Please find the attached file CMakeOutput.log

I didn't see anything related to CPP SDK in your output log.


.setProperty should not work with camelCase

According to the official spec, CSSStyleDeclaration.setProperty()'s
propertyName parameter should be the CSS property name in hyphen-case
only. It shouldn't set any styles when the property name is in
camel case or any other form. This is the behavior found in browsers,
so this library should align with it.
https://developer.mozilla.org/en-US/docs/Web/API/CSSStyleDeclaration/setProperty
Closes #60

This is more of an attempt to get the ball rolling on fixing #60, than an actual finished proper solution. I'm obviously open to suggestions on getting the code to how it needs to be.

Hello?

Hey @reyronald, thanks for the PR! Apologies for the delay, I was not receiving notifications for this for some reason (fixed now!)
I have reviewed the code and also the original jsdom issue. It seems that browsers will apply a lowercase transform to the propertyName before setting it, so we need a more robust check inside of setProperty. isCamelCase('FoNt-SiZe') returns true for what is technically a valid property.
With a proper implementation we should be able to assert:
style.setProperty('FoNt-SiZe', '12px');
test.equal(style.fontSize, '12px', 'font-size: 12px');
test.equal(style.getPropertyValue('font-size'), '12px', 'font-size: 12px');

Tested in Chrome, Firefox and Safari console:
var div = document.createElement('div');
div.style.setProperty('FonT-SiZe', '12px');
console.log(div.style.fontSize); // 12px
console.log(div.style.getPropertyValue('font-size')); // 12px;

Hey @jsakas ,you are absolutely right, what a great catch! Hadn't noticed that mysef.
I think the correct approach here would be to check if the given property name is a valid one directly,  instead of using workarounds with utility functions like that. I mean something like this:
// `validProperties` would be a `new Set(['align-content', 'align-items', ... ])`
// only containing the dashed property names
var lowercaseName = name.toLowerCase();
if (!validProperties.has(lowercaseName)) {
	return;
}
// ...

We could generate that set along with the property setters & getter using the generate_properties.js script, it should be straight forward and minimal. We could then also re-use that set in the test file and then we would have a single source of truth for the property list, instead of having to redefine it there! That would allow us to remove line 11 from the following snippet and just import it instead.
https://github.com/jsakas/CSSStyleDeclaration/blob/a8c2467b5a2ca12a574c2eeabe5ca1205fd1aeaf/tests/tests.js#L11-L14
I think this is what would be the most consistent with what the browser is doing, and your suggested test would pass (along with all others). Do you see any downsides with it, or have a different approach?

@reyronald I agree that we need to do a property name check. I think we can use MDN's data repository here: https://github.com/mdn/data/blob/master/css/properties.json

@jsakas Correct me if I'm wrong, but the CSSStyleDeclaration class requires setters and getters for each property to be applied properly, and those are defined in ./lib/properties. If we grab them from that json we would be letting pass as valid some that won't actually be able to be set. This is the case of the align-self property:
// with cssstyle

var style = new cssstyle.CSSStyleDeclaration();
style.setProperty('align-self', 'auto');
console.log(style.cssText); // '', because there are no accessors for the `alignSelf` property
// (but there should be!)

// in the browser

var div = document.createElement('div')
div.style.setProperty('align-self', 'auto');
console.log(div.outerHTML); // '

' as expected

We could use that json to identify the getters and setters that we are missing and add them, but not using the json directly for the validity check. I'm not sure if I'm getting my point across very well, thoughts?
Let me know if I'm missing something, I might be wrong.

Bump @jsakas

@reyronald ideally we would use that data to generate this entire library, but that is what we should do for the re-write.
In the interim we could easily use the JSON to check valid properties. Here is some untested pseudo code:
const properties = require('mdn/data/css/properties.json');

const validProperties = Object.keys(properties);

const isValidProperty = validPropertes.indexOf(someVar) > - 1);

Also, because there are custom properties like --my-custom-prop, we might need to use regex, or treat --* as a special case.

So I did an intersection between the CSS properties that we currently have in this repo and the ones exposed by the MDN data json, and there are tons of that are missing (261 to be exact), which leads me to believe that maybe that data is not actually complete and perhaps it wouldn't be a good idea to use that to generate this entire library :/. Here's a snippet with the exact list: https://gist.github.com/reyronald/cc67f9c3bb02449e88f13c46ef28a92b.
There are some tests that are relying on some of those properties, so they fail with the suggested approach. Also, the code of consumers of this library will end-up breaking too if we're not careful.
Do you know of any other npm package that has more reliable/official data?

Ah, well that is unfortunate. Thanks for taking the time to do more thorough research on that. I am going to look for a more complete data source or integration we can use.

No problem! I'll see if I can find one too when I have some more spare time.
Keep me updated!

Thought this comment could be relevant to this conversation, so adding it here as a reference: https://github.com/mdn/data/issues/149#issuecomment-349283127

Circling back to this, do you think we should then post-pone this issue until after the rewrite, or could we go with the approach I suggested in https://github.com/jsakas/CSSStyleDeclaration/pull/61#issuecomment-403167292 ?

@reyronald I think your approach of creating a valid properties array is a good solution for now. I would maybe put it in its own file though, something like:
// validProperties.js
module.exports = [
  'azimuth',
  'background',
  'backgroundAttachment',
  // etc..
];

That way the diff will be clearer if we need to add more, and it keeps the other file a little cleaner.

@jsakas Done! How you feel about it now?
By the way I used a Set instead of an array so that the check would be a lot faster, O(1) instead of O(n). Also, I used multiple .add() calls instead of the constructor that takes an iterable because the latter is not supported on IE11. On top of that, the .add calls span multiple lines so the file would be incredibly more  readable anyway, using the iterable constructor would put everything in a huge, long line.
Let me know what you think.

@reyronald this is looking good. Going to test today and will get back to you. I wish we had a similar document for CSS3 properties!

Awesome @jsakas ! Thank you too for your support !


console error when use table in mdx

Bug Report
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Please try to build a small repo with a repro of your problem and provide a link to it.
Doing that allows more people to quickly help you.
If you can't provide a repo then provide clear steps describing how to reproduce the issue.

create-docz-app my-docz-app && cd my-docz-app
Change src/index.mdx to

### Some mdx content
![1118](https://user-images.githubusercontent.com/44964193/94368447-be630200-0116-11eb-81e9-e6df35288e43.png)

1	2

Run npm run docz dev
See error in console

The pseudo class ":first-child" is potentially unsafe when doing server-side rendering. Try changing it to ":first-of-type".

I'm with similar issue. My personal table component has overwritted styles by docz and injected some :first-child on styles.

I'm with similar issue. My personal table component has overwritted styles by docz and injected some :first-child on styles.

Hi，can you paste your code？ Thank you！


QUESTION_Excel Export not start from A1

Please prefix your issue with one of the following: [BUG] [PROPOSAL] [QUESTION].
Package version, Laravel version : 5.1
Expected behaviour
Actual behaviour
Exception stack trace
Screenshot of Excel file

Steps to reproduce the behaviour

Please show us your code. Not sure how I'm magically need to guess what you're doing? ;)


Stop + wait 1 second + go to charge

Adding the Stop robot, wait 1 second for the robot to process the action and go to charge.
On top of that, making sure we refresh the state. I'm having issues lately with the latest version where my Home app shows the robot as still cleaning when it's actually charging...
/cc @c-o-m-m-a-n-d-e-r

i will give this a try and report back

Successfully published<EMAIL_ADDRESS>


Fix use of -mcx16 flag - only use if it compiles cleanly.

This fixes #5017 and #7642
This could be backported to ATS 9 easily.

[approve ci docs]

[approve ci]

This has been a problem for at least a year, it should be put in 9.1 at a minimum.

Cherry-picked to v9.0.x branch.
Cherry-picked to v9.1.x branch.


Something like tailscale's "magicdns"?

Networking is not my specialty, sorry if this is stupid, obvious, etc. A built in DNS solution would be interesting, like tailscale's magic dns, but maybe less magic and more better?
L1: It assigns each peer it's own DNS entry, so you can do dave:8000 to connect to whatever IP dave has been assigned. Much easier that way.
L2: Would be even better if dave could name his port, so I could connect to webserver.dave for 8000
L3: Dreaming, what if two IP's could both be associated with one DNS entry, and each one can claim ports, so if I have two homelab servers for instance, one has claimed nextcloud.lab as port 3333 and the other has claimed plex.lab as 1234
L4: DNS entries can also be unrelated to peers, so nextcloud could simply map to lab:3333, how whimsical is that?
Past L1, tailscale gets beaten. I'm not looking for something magic like theirs, but powerful and flexible like the rest of this wonderful program. Unless it was not clear, these L's are not demands by any means, I'm just very excited about this idea and tossing around ideas :)
Perhaps there is some alternative program I can use that is like this?

Related
https://github.com/tailscale/tailscale/issues/3847 https://github.com/tailscale/tailscale/issues/1543 https://github.com/tailscale/tailscale/issues/4455

Hi @boehs, innernet already assigns human hostnames like myhost.mynet.wg for each peer (unless disabled). It currently does by editing /etc/hosts (or equivalent), but that's and implementation detail that can change.
I fear that embedding a port into hostname cannot work, as hostname resolution library functions usually have no means of returning a port number.

That makes sense, unfortunate. I am still interested in L1? I understand if it's not a priority but myhost would be preferable. If not I understand, thanks for the awesome project

I fear that providing bare myhost names would not be general enough for innernet (multiple interfaces could then clash). But you should be able to emulate the same effect by "search domains". See manpage for resolv.conf in case of UNIX systems.

Perhaps there is some alternative program I can use that is like this?

As mentioned, the "level 2" and beyond steps aren't doable by DNS resolver
It doesn't really overlap with the innernet project at all, but:
For HTTP traffic, the use cases are all (more or less) doable with a "reverse proxy" HTTP server. E.g you point webserver.dave and webserver.emma etc etc to the same IP where the reverse-proxy is running, then when you navigate to any of those domain names, based on the Host: ... in the HTTP request the proxy redirects the traffic to the approriate server. This all works because the HTTP protocol is designed for this (virtual hosting) - it wouldn't work for most other things (e.g SSH has no way of knowing if packets were destined for a particular domain-name)
Something like nginx can be configured to do this proxying; and things like Traefik are a more specialized version of this (I have a vague feeling like it's possible to write some kind of innernet-traefik integration to do exactly what you describe, but, it's most likely a huge amount of effort for a fairly unusual use-case)

Your point about nginx is very very interesting. Seems like a fun side project honestly, so to the backlog it goes! If you so wish, you are welcome to close this issue.
FWIW I apologize for my initial naivety but am glad I opened this issue because it's prompted really interesting ideas like @dbr 's suggestion. Keep the thinking going and thanks to everyone for making an awesome project happen.

For what it's worth, I think with the advent of more DNS implementations that support plugins like CoreDNS, innernet can and should focus on offering multiple name resolution options besides the hacky hostsfile implementation it currently uses.

I fear that embedding a port into hostname cannot work, as hostname resolution library functions usually have no means of returning a port number.

You can of course let libc do the work (or how do you think "telnet host smtp" is working). Just as you are augmenting /etc/hosts you could modify /etc/services (or extend the relevant nis database). But it seems a bit useless to me; if someone really needs it he can start reading up on nss and nsswitch.confq.
I'd rather add unbound to the innernet-server or dig out prehistoric nis (which has been torturing me for decades and still leaves you with fun things like nsswitch.conf).

In the effort to provide an alternative to editing /etc/hosts, I made a simple NSS module for innernet, which just reads the JSON files in /var/lib/innernet.  It's possible to use the HTTP API directly instead.
I looked into an integrated DNS solution (e.g. trust-dns, aardvark-dns, dcompass), but I think just the configuration of the server (e.g. forwarding, TLS, HTTP) would dwarf the simplicity of innernet.  Even then, there remain questions about how it's served (by innernet-server or locally at each client) and how forwarding works (or if we defer that problem to another resolver like systemd-resolved's DNS routing domains.)

innernet-server sounds like a better idea to do the dns resolving as that would let you centrally manage dns resolution, great for places like routers where you want the clients to just get the same treatment.


fix cannot install packages with pacman provider

Installing packages with pacman failed with
Error: /Stage[main]/Main/Package[git]: Could not evaluate: Error while getting installed groups
This is fixed by allowing a non-zero exit code for some of the pacman calls.
https://tickets.puppetlabs.com/browse/PUP-4635

CLA signed by all contributors.

Hi @vdloo.  Thanks so much for taking the time to put up a PR to fix this!  Generally it looks like your fix is good.  Other than the above comments, I think we should add a test for the condition where pacman returns 1 for the group query.  The rspec code can be a little confusing, so if you're unable to figure out adding that test let me know and I can add one.

@vdloo Also, could you amend your commit message per our contributing guidelines?  We generally prefix the commit message to reference the ticket, like so: (PUP-4635) Fix pacman provider to handle failure on group queries. or some such.  Thanks!

Review note: the AppVeyor failures are known issues and can be ignored.

@vdloo Also, I have a feeling that we'll want to target this fix at stable.  If it's not too difficult would you mind applying the fix to the stable branch with the above corrections and putting up a new PR against that branch?  That way the fix can go into the next 4.1.x release and then we'll merge it up into the 4.2.x release branch (which is currently master).  Please let me know if you would like me to do this for you instead.  Thanks!

I tried adding the following to pacman_spec.rb:229
     it "should return 1 as exit code" do
       executor.expects(:execpipe).with(["/usr/bin/pacman", '-Q'])
       executor.expects(:execpipe).with(["/usr/bin/pacman", '-Sgg', 'package'], false).stubs(:exitstatus).returns 1
       provider.query
     end

but that seemed to have no effect (when changing the 1 to 0).
I'm not familiar with ruby at all so I'm afraid that figuring this out will take me a lot of time + I am in a train with limited internet all day unfortunately. If you could fix the test and make the pr for the stable branch that would be fantastic, thanks for the quick response!

@vdloo Thanks again for putting this forward.  I will get this fixed up and re-target against stable.

@vdloo After discussion with @kylog, we don't need to target this against stable and can keep it at master.

Hi @vdloo.  I've put up a PR that includes your commit that was amended with the above fixes along with some additional tests that we were missing for group? and get_installed_groups: https://github.com/puppetlabs/puppet/pull/3974.  As such, I'm going to close this PR in favor of that one.  When you have a chance, can you please test the changes out to your satisfaction?  Cheers.


value 0 not getting painted when passed through config.value

It must be stringified. Maybe a null check instead of if(...).

Closing ticket. The master branch will be updated soon to reflect the 'big-refactor' branch (v2 release). If you have a continued issue with big-refactor branch please open a new ticket or email<EMAIL_ADDRESS>


Pick and Place File for PCB Assembly

I'm ordering PCBs for assembly at https://jlcpcb.com/order and can't seem to find the pick and place file that I assumed would be in EDA directory somewhere near https://github.com/TesCustoms/TesMufflerDongle/tree/main/EDA/PiOBD_CM4_MultiBoard_V1.1/TopBoard/Project Outputs for TopBoard
Linked below is a sample CPL file that JCL PCB provided:
https://www.icloud.com/iclouddrive/050_UZ1zaG_tQxW3B6V0IZN7w#JLCSMT_Sample_CPL1

Hi @OpenSourceIronman , the team which worked on the hardware dongle is currently on their Christmas and New Years break. So I am afraid that we will not have a good answer to your question until next week. Sorry about that.

What @eriksven said. I will try to reach out to our hw gurus and see what we can do. Might take some days though. What I can say, the reason, we did not notice this particular information missing is, that for our first production  run our "Pick & place machines" where human-based...

Thanks guys! I will also probably hand solder paste and then drag solder the first two PCBs myself 🤓
But then plan to make ~100 units in May 2023, 400 more in Aug 2023, and then final 1500 more in Oct 2023.
https://docs.google.com/presentation/d/1vmfBdLqMhj65gBI4U_X0QDvzo5LgiAgdK-cK7LWeqZQ/edit

If you really manage to make them (sourcing is a bit difficult for some of the components), I am pretty sure you could also have customers outside your specific project.
We saw quite a bit interest around the "Software Defined Vehicle" Open Source community, to use this for various projects, but so far we did not manage pre-financing a complete batch.
So if you do manage to move forward with this design, or something based on it, be sure to ping us, or advertise here https://sdv.eclipse.org
At least it might help you getting some additional volume 🤓
We updated the manufacturing files to include Pick&Place, fresh Gerber export and some other documentation improvements. We should(tm) not have missed any vital files and PCB should not have  been changed, but just to be sure, previous master is tagged here: https://github.com/eclipse/kuksa.hardware/tree/hardware2_v11

I really appreciate the update. I will double check everything and get back to the team in 7 to 10 days.


[Symfony-toggle] Allow multiple driver implementations

Epic: https://github.com/pheature-flags/pheature-flags/issues/97 Symfony Toggle
Package: https://github.com/pheature-flags/symfony-toggle
Description:
Allow running multiple driver implementations at the same time, in order to define different feature flags depending on the driver (in memory and dbal right now).

Thanks;-D. I think that we can do this as a core feature, applying chain decorators(like with Strategies and Segments). For example, we can imagine a ChainFeatureFinder that gets available toggles both from the in-memory finder and the Dbal finder as well.


Integration upgrades wagtail 41 - 42 - 50

This integrates to pieces of work which can be closed in favour of this PR

https://github.com/torchbox/wagtail-webstories/pull/19
https://github.com/torchbox/wagtail-webstories/pull/20
https://github.com/torchbox/wagtail-webstories/pull/21

Merged in f85bbed86e765f2ba05e7cc0fcdb2efd357b053e + parents.


Autocomplete of internal links suddenly not working

Apologies if I've done something stupid without realizing it, but as of about a month ago (although I didn't notice until a few days ago), the autocompletion of internal links no longer seems to be working.  I did upgrade to Yosemite somewhere in that time, so don't know if that helps.  But as far as I can tell, I made no changes to my nvalt preferences (i.e., "Suggest titles for note-links" is still checked).
Help greatly appreciated.

I also have this problem. Both with Notational Velocity and nvALT. It flickers back and forth between working and not. Usually when I start up the program it works initially. Thanks.

I also have this issue. Just downloaded the application, made sure autocomplete was checked, but no dice. The only difference between my problem and yours is that I just haven't seen the feature work, period.
I'm on MacOS 10.12.4, with nvAlt version 2.2.7 (126)

Auto-complete works does not work for me either (never worked).
nvALT version 2.2.8 (128), M1 iMac 2021 on macOS 12.3.1


No spell-check underlines

the neovim TUI and vanilla vim's gvim show spelling and grammar errors with set spell, but neovim.as seems to be missing them:
neovim TUI:

vanilla gvim:

neovim.as:

I've implemented support for underine and undercurl in the master branch.
But unfortunately, seems that the color is not correct, in vim there used to be a sp_color, but I didn't find it in neovim.

getting the colors right depends on https://github.com/neovim/neovim/issues/2040


doesn't work or i can't understand which app token to use

hello.
i have a instagram app
i generate a long life token but dosnt work.
invalid oauth access token - cannot parse access token
can you help me
thanks

Hi! I'm so sorry, I moved to a new job and kinda neglected side projects while settling in and I missed this message. Do you still have a problem? Can you tell me the steps you took to generate the token?

Closing this as it seems abandoned. Feel free to comment on this and we'll reopen it


Reconsider state.isTransitioning and completeTransition action

I think the "complete transition" action may have been a bad move. Storing isTransitioning in navigation state means extra unnecessary state changes, and the event system is very confusing because of it. Also it encourages people to use the action to configure the transition (eg, the "immediate" flag), rather than declaratively configuring the transition on the screen itself.
Instead, a navigator could fire a callback inside the navigation prop while a state change is happening, to register that a longer transition is in progress, and the event system can fire didFocus/blur actions when the transition completes. If the navigator doesn't call this hook, then the transition completes immediately.
Opening this here to start a discussion and to see if others agree

@ericvicenti have your thoughts evolved on this at all? What's your current thinking?


Control plane nodes won't join on latest master

/kind bug
What steps did you take and what happened:
Props to @dims awesome e2e testing coverage for GCP, we noticed that additional control plane machines never reach running state.
[preflight] FYI: You can look at this config file with 'kubectl -n kube-system get cm kubeadm-config -oyaml'
error execution phase preflight:
One or more conditions for hosting a new control plane instance is not satisfied.

failure loading key for CA: couldn't load the private key file /etc/kubernetes/pki/ca.key: open /etc/kubernetes/pki/ca.key: no such file or directory

Please ensure that:
* The cluster has a stable controlPlaneEndpoint address.
* The certificates that must be shared among control plane instances are provided.

/assign @chuckha

/lifecycle active

Reproduced easily. It looks like everything works from the AWS console but the actual cluster does not have all the nodes that are created.
Using this YAML https://gist.github.com/chuckha/9d4ab8252709a426dbd493f603d9ac64

The issue is that we are trying to manage all the certs and we need three cases, control-plane init, control-plane join and worker join, but we only have 2 cases, control-plane init + worker.
They each have their own set of certificates they need and must be treated separately.

this is looking better :)
chuckh-a02:capi-dev cha$ export KUBECONFIG=my-target-cluster.conf
chuckh-a02:capi-dev cha$ k get nodes
NAME                                       STATUS     ROLES    AGE     VERSION
ip-10-0-0-196.us-west-2.compute.internal   NotReady   master   13m     v1.16.0
ip-10-0-0-45.us-west-2.compute.internal    NotReady   master   2m22s   v1.16.0
ip-10-0-0-84.us-west-2.compute.internal    NotReady   master   3m8s    v1.16.0

Nice!


Added support for Not Applicable/Unspecified mods

XSD, XML, and C# changes to add 00 values to system
Fixed Air Detonation typo (extra space)
Made HQTFFD and Amplifier 0 values comply with standard

This PR addresses the concerns in #170 and in military-features-data issue 45
@jrweakland , please review these changes against your domain range changes in the gdb template.


Installing linecache19 (0.5.12) with native extensions fails

Trying to deploy my rails 3 applicaiton on heroku and gettign the error that follows:
Installing linecache19 (0.5.12) with native extensions Unfortunately, a fatal error has occurred. Please report this error to the Bundler issue tracker at https://github.com/carlhuda/bundler/issues so that we can fix it. Thanks!
/usr/local/lib/ruby/1.9.1/rubygems/installer.rb:483:in rescue in block in build_extensions': ERROR: Failed to build gem native extension. (Gem::Installer::ExtensionBuildError)        /usr/local/bin/ruby extconf.rb        checking for vm_core.h... no        checking for vm_core.h... no        *** extconf.rb failed ***        Could not create Makefile due to some reason, probably lack of        necessary libraries and/or headers.  Check the mkmf.log file for more        details.  You may need configuration options.        Provided configuration options:        --with-opt-dir        --without-opt-dir        --with-opt-include        --without-opt-include=${opt-dir}/include        --with-opt-lib        --without-opt-lib=${opt-dir}/lib        --with-make-prog        --without-make-prog        --srcdir=.        --curdir        --ruby=/usr/local/bin/ruby        --with-ruby-dir        --without-ruby-dir        --with-ruby-include        --without-ruby-include=${ruby-dir}/include        --with-ruby-lib        --without-ruby-lib=${ruby-dir}/lib        /usr/local/lib/ruby/1.9.1/fileutils.rb:243:in mkdir': Read-only file system - /usr/local/include/ruby-1.9.1/ruby-1.9.2-p180 (Errno::EROFS)
from /usr/local/lib/ruby/1.9.1/fileutils.rb:243:in fu_mkdir'        from /usr/local/lib/ruby/1.9.1/fileutils.rb:217:in block (2 levels) in mkdir_p'
from /usr/local/lib/ruby/1.9.1/fileutils.rb:215:in reverse_each'        from /usr/local/lib/ruby/1.9.1/fileutils.rb:215:in block in mkdir_p'
from /usr/local/lib/ruby/1.9.1/fileutils.rb:201:in each'        from /usr/local/lib/ruby/1.9.1/fileutils.rb:201:in mkdir_p'
from /tmp/build_1l59fqsea4v4l/vendor/bundle/ruby/1.9.1/gems/ruby_core_source-0.1.5/lib/ruby_core_source.rb:59:in block in create_makefile_with_core'        from /usr/local/lib/ruby/1.9.1/tempfile.rb:320:in open'
from /tmp/build_1l59fqsea4v4l/vendor/bundle/ruby/1.9.1/gems/ruby_core_source-0.1.5/lib/ruby_core_source.rb:51:in create_makefile_with_core'        from extconf.rb:19:in '
Requesting http://ftp.ruby-lang.org/pub/ruby/1.9/ruby-1.9.2-p180.tar.gz
Downloading http://ftp.ruby-lang.org/pub/ruby/1.9/ruby-1.9.2-p180.tar.gz
Gem files will remain installed in /tmp/build_1l59fqsea4v4l/vendor/bundle/ruby/1.9.1/gems/linecache19-0.5.12 for inspection.
Results logged to /tmp/build_1l59fqsea4v4l/vendor/bundle/ruby/1.9.1/gems/linecache19-0.5.12/ext/trace_nums/gem_make.out
from /usr/local/lib/ruby/1.9.1/rubygems/installer.rb:486:in block in build_extensions'        from /usr/local/lib/ruby/1.9.1/rubygems/installer.rb:446:in each'
from /usr/local/lib/ruby/1.9.1/rubygems/installer.rb:446:in build_extensions'        from /usr/local/lib/ruby/1.9.1/rubygems/installer.rb:198:in install'
from /tmp/build_1l59fqsea4v4l/vendor/bundle/ruby/1.9.1/gems/bundler-1.1.pre.8/lib/bundler/source.rb:92:in block in install'        from /tmp/build_1l59fqsea4v4l/vendor/bundle/ruby/1.9.1/gems/bundler-1.1.pre.8/lib/bundler/rubygems_integration.rb:78:in preserve_paths'
from /tmp/build_1l59fqsea4v4l/vendor/bundle/ruby/1.9.1/gems/bundler-1.1.pre.8/lib/bundler/source.rb:82:in install'        from /tmp/build_1l59fqsea4v4l/vendor/bundle/ruby/1.9.1/gems/bundler-1.1.pre.8/lib/bundler/installer.rb:64:in block (2 levels) in run'
from /tmp/build_1l59fqsea4v4l/vendor/bundle/ruby/1.9.1/gems/bundler-1.1.pre.8/lib/bundler/rubygems_integration.rb:93:in with_build_args'        from /tmp/build_1l59fqsea4v4l/vendor/bundle/ruby/1.9.1/gems/bundler-1.1.pre.8/lib/bundler/installer.rb:63:in block in run'
from /tmp/build_1l59fqsea4v4l/vendor/bundle/ruby/1.9.1/gems/bundler-1.1.pre.8/lib/bundler/installer.rb:55:in run'        from /tmp/build_1l59fqsea4v4l/vendor/bundle/ruby/1.9.1/gems/bundler-1.1.pre.8/lib/bundler/installer.rb:12:in install'
from /tmp/build_1l59fqsea4v4l/vendor/bundle/ruby/1.9.1/gems/bundler-1.1.pre.8/lib/bundler/cli.rb:213:in install'        from /tmp/build_1l59fqsea4v4l/vendor/bundle/ruby/1.9.1/gems/bundler-1.1.pre.8/lib/bundler/vendor/thor/task.rb:22:in run'
from /tmp/build_1l59fqsea4v4l/vendor/bundle/ruby/1.9.1/gems/bundler-1.1.pre.8/lib/bundler/vendor/thor/invocation.rb:118:in invoke_task'        from /tmp/build_1l59fqsea4v4l/vendor/bundle/ruby/1.9.1/gems/bundler-1.1.pre.8/lib/bundler/vendor/thor.rb:263:in dispatch'
from /tmp/build_1l59fqsea4v4l/vendor/bundle/ruby/1.9.1/gems/bundler-1.1.pre.8/lib/bundler/vendor/thor/base.rb:386:in start'        from /tmp/build_1l59fqsea4v4l/vendor/bundle/ruby/1.9.1/gems/bundler-1.1.pre.8/bin/bundle:13:in <top (required)>'
from vendor/bundle/ruby/1.9.1/bin/bundle:19:in load'        from vendor/bundle/ruby/1.9.1/bin/bundle:19:in '
!
!     Failed to install gems via Bundler.
!
!     Heroku push rejected, failed to compile Ruby/rails app

dpiddy-
Your explanation worked for me.

How do I do this in Heroku?

Heroku runs bundle install with --without development test by default. You just need to make sure ruby-debug/ruby-debug19 are in either the development or test group in your Gemfile.

Thanks for the explanation.  Was having the same problem and moving rdebug to the development group fixed it.

Thanks @danp


Fix rgb2hsv method

There is currently a method called rgb2hsv that lives in /lib/rgb2hsv.js.
It is incomplete and needs to be fixed!
For this method, you will need to round decimal values to 3 digits. Check out the toFixed method to see how to do this. This issue may be a bit harder than some of the others on this repo!
Acceptance Criteria:

Running yarn test rgb2hsv results in tests passing.
You have written a skeleton method for someone else to work on.
You have written tests surrounding your skeleton method.
Running yarn lint does not print any errors to the console!
Optional: write one or two more tests surrounding the method you are solving to account for potential edge cases.

Please include the skeleton of a new method + an accompanying test for someone else to work on at the time of creating a pull request! A pull request will most likely be denied if it does not contain a skeleton method for someone else to work on! For more information, please read the Contributing Guide.
Thank you so much for your contribution!

ill take this.

Cool deal @xxDOOMbox ! Thanks!!


empty recordedById in dwc_fields DWC Occurrence Report task

Describe the bug
When there are more than one determiner and/or collector for an occurrence with no orcid, the row still shows a delimiter
To Reproduce
Steps to reproduce the behavior:

Have an collectionobject with a different determiner and collector, neither of whom have orcids
Navigate to the DWC Occurrence Report task
The recordedID field shows a delimiter and nothing else

Expected behavior
I expect the field to be empty if neither person has an identifier (orcid)
Environment (please identify where you experience this bug:
*** One of ***

Development: dwc_fields branch, a92a0c95a32fa133f9f79e116dad9b0c3898ad0e

@LordFlashmeow IIRC, I'll check, but you must have ORCID ids for users who added the record.  I don't believe this is an error.  See user params.
Steps:

Create a Person representing you/others as a user.
Create an ORCID identifier for that person

The value should map.

What if they don't have an ORCID?

Then there is no ID to share, and it fails the semantics of the field.
Note that IIRC the field is not supported by DwC, it probably shouldn't be there... yet.


Local image asset isn't found

When passing in an image file that exists locally within the app Android is unable to find the file:
window.MusicControls.create({
                    track: 'Title',
                    artist: 'Artist',
                    cover: 'img/logo.jpg',
                    isPlaying: false,
                    dismissable: true,
                    hasPrev: false,
                    hasNext: false,
                    hasClose: true
                });

03-03 15:40:38.771 31274 31290 W System.err: java.io.FileNotFoundException: img/logo.jpg: open failed: ENOENT (No such file or directory)

On a OnePlus One running Android 6.0.1

The 'cover' attribute should be an absolute path. If you are using cordova file plugin, you can use cordova.file.applicationDirectory or cordova.file.externalApplicationStorageDirectory do build the full path.

And if I'm not using the file plugin?

Instead of
Uri uri = Uri.parse(localURL);
File file = new File(uri.getPath());
FileInputStream fileStream = new FileInputStream(file);
BufferedInputStream buf = new BufferedInputStream(fileStream);

I made the following change
InputStream fileStream = cordovaActivity.getAssets().open("www/" + uri);
BufferedInputStream buf = new BufferedInputStream(fileStream);

and now the image loads fine with no errors. Having said that, I'm NOT great at Java and have no idea if this would cause issues.

I commited the changes, it should work now.

Sweet! That I could help out.


Define eu usecase

closes #157

Need to check what happens when nc files with different year ranges are opened correctly.


feat(consensus): rename topic in config to network_topic

This is prep for adding sync_topic.

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#406  👈
#404
#389 : 1 other dependent PR (#403 )
#387
#386
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @matan-starkware and the rest of your teammates on  Graphite

Merge activity

Aug 15, 3:23 AM EDT: @matan-starkware started a stack merge that includes this pull request via Graphite.


rustup update fails because of missing directory

Same issue as: https://github.com/rust-lang-nursery/rustup.rs/issues/938
$ rustup update stable
info: syncing channel updates for 'stable-x86_64-apple-darwin'
info: downloading component 'rustc'
37.8 MiB / 37.8 MiB (100 %) 10.2 MiB/s ETA: 0 s
info: downloading component 'rust-std'
53.8 MiB / 53.8 MiB (100 %) 10.2 MiB/s ETA: 0 s
info: downloading component 'cargo'
3.6 MiB / 3.6 MiB (100 %) 799.6 KiB/s ETA: 0 s
info: downloading component 'rust-docs'
11.4 MiB / 11.4 MiB (100 %) 11.1 MiB/s ETA: 0 s
info: downloading component 'rust-src'
31.9 MiB / 31.9 MiB (100 %) 10.5 MiB/s ETA: 0 s
info: rolling back changes
error: failure removing component 'rust-src', directory does not exist: '"lib/rustlib/src/rust/src/llvm/test/tools/llvm-objdump/X86/Inputs/internal.exe.coff-x86_64"'

$ rustc --version
rustc 1.17.0-nightly (b1e31766d 2017-03-03)

Same issue here:
$ rustup update
info: syncing channel updates for 'stable-x86_64-unknown-linux-gnu'
info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
270.6 KiB / 270.6 KiB (100 %) 101.8 KiB/s ETA:   0 s
info: latest update on 2018-02-19, rust version 1.25.0-nightly (27a046e93 2018-02-18)
info: downloading component 'rustc'
info: downloading component 'rust-std'
info: downloading component 'cargo'
info: downloading component 'rust-docs'
info: downloading component 'rls-preview'
info: downloading component 'rust-src'
info: downloading component 'rust-analysis'
info: removing component 'rustc'
info: rolling back changes
error: failure removing component 'rustc-x86_64-unknown-linux-gnu', directory does not exist: '"share/doc/rust/COPYRIGHT"'
info: checking for self-updates

       stable-x86_64-unknown-linux-gnu unchanged - rustc 1.24.0 (4d90ac38c 2018-02-12)
  nightly-x86_64-unknown-linux-gnu update failed - rustc 1.23.0-nightly (d0f8e2913 2017-11-16)

$ rustup --version
rustup 1.11.0 (e751ff9f8 2018-02-13)

I'm curious here... why the removal of a component fails because the absence of a directory (and in this specific case, a doc/copyright one)? Isn't it safe to just warn (if it is not expected) and keep going?

Well... after I removed my toolchains manually with:
$ rm -frv ~/.rustup/toolchains/*
$ rustup show
# ... downloaded some stuff

and then it worked.
This is what I think that happened:
I think something went wrong during the download of the initial toolchains. Then, rustup update got confused because some files were missing during removal of components (should it be?). After a cleanup on the toolchains directory, rustup fresh installed it all again and it worked fine.
Does rustup do integrity check after the download/installation of the toolchains already? If it does, then the corruption occured after that.
Anyway, wouldn't it be better to differentiate which error occurred during component removal? It's ok to abort the proccess when a permission error happens, but if it was an ErrorKind::ComponentMissingFile or ErrorKind::ComponentMissingDir error, I think the component removal shouln't be affected because of that).
https://github.com/rust-lang-nursery/rustup.rs/blob/master/src/rustup-dist/src/component/components.rs - at "// Remove parts" on lines 277

Same issue:
rustup update stable
info: syncing channel updates for 'stable-x86_64-unknown-linux-gnu'
info: latest update on 2018-03-01, rust version 1.24.1 (d3ae9a9e0 2018-02-27)
info: downloading component 'rustc'
info: downloading component 'rust-std'
info: downloading component 'cargo'
info: downloading component 'rust-docs'
info: downloading component 'rust-std' for 'armv7-unknown-linux-gnueabihf'
info: downloading component 'rust-std' for 'arm-unknown-linux-gnueabihf'
info: removing component 'rustc'
info: rolling back changes
error: failure removing component 'rustc-x86_64-unknown-linux-gnu', directory does not exist: '"share/man/man1/rustdoc.1"'

I've deleted ~/.rustup/toolchains/* and now it works.

Probably belongs here, worked after I did what @danielpclark said above on Arch Linux.
> error: failure removing component 'rustc-x86_64-unknown-linux-gnu', directory does not exist: '"share/doc/rust/COPYRIGHT"'

Similar problems when trying to update. error: failure removing component 'rust-std-x86_64-apple-darwin', directory does not exist: '"lib/rustlib/x86_64-apple-darwin/lib/liblog-34f173aa5845f490.rlib"' using rustc 1.25.0 (84203cac6 2018-03-25)

Closed in favour of #1480, please comment there if you have further information.


Update all dependencies

Pretty sure he has a bot that does this periodically.

Not doing any updates without testing, and if you think (wrongly, of course) I have a bot for doing this, do it better. Not sure why I would have to do this...

I think you have misunderstood me. I meant the dev of this project uses dependabot to keep dependencies updated, so users don't need to put up PRs for it, as you have done here. I wasn't intending to say you were using a bot.

Ah ok, sorry @BHydden  for misunderstanding.

All good, I should try harder not to use unclear language 👍

Thanks!


Add Diego Arroyo as contributor

@all-contributors add @nightroy99 for translation and review

@all-contributors please add @nightroy99 for translation and review


disable react/react-in-jsx-scope for react versions 17 and above

disable react/react-in-jsx-scope for react versions 17 and above because importing react for jsx components was deprecated in react 17 and will be removed in react 18

See #2928, #3021, and please discuss changes in an issue before filing a PR.

Adding a quote from the README here, for those who wants to get rid of this warning in modern React where React does not need to be imported for every jsx/tsx file:

If you are using the new JSX transform from React 17, extend react/jsx-runtime in your eslint config (add "plugin:react/jsx-runtime" to "extends") to disable the relevant rules.


Fix Benchmark Test (BenchmarkReadMessage/Funding_Locked) in the lnwire  package

Change Description
This PR fixes #7152
The benchmark tests failed as described in the issue. Currently the tests produce random data for the ExtraOpaqueData field of most of the message types. This can be dangerous as soon as new data is added to a msg type via a tlv record. In this case other tests will fail too, if they use the random data generator for the tlv part.
The benchmark tests failed now, because the funding_locked msg type is the first message in the code base which has an tlv record nested in the overall message type therefore this behaviour was not observed before.
My approach was to narrow down the funding_locked message, discarding the random part of the ExtraOpaqueData data and including the new AliasScid tlv record, this way the tests will test the encode and decode method of the funding_locked msg more throughly.
Though as soon as another msg type introduces a new nested tlv field the tests will fail again. So maybe we should get rid of the random message generation part for the ExtraOpaqueData field for all msg types, or restrict its size to 0, and add additional tests which really try to push the max size of the whole message to its boundaries to actually test the size limits of the payload etc.
Moreover should we also include the Benchmark tests in the overall testrun sothat we capture future failure more reliably?
Steps to Test
In the lnwire directory run: go test -v  -bench=BenchmarkReadMessage
Pull Request Checklist
Testing

[ ] Your PR passes all CI checks.
[ ] Tests covering the positive and negative (error paths) are included.
[ ] Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

[ ] The change obeys the Code Documentation and Commenting guidelines, and lines wrap at 80.
[ ] Commits follow the Ideal Git Commit Structure.
[ ] Any new logging statements use an appropriate subsystem and logging level.
[ ]  There is a change description in the release notes, or [skip ci] in the commit message for small changes.

📝 Please see our  Contribution Guidelines for further guidance.

The benchmark tests failed now, because the funding_locked msg type is the first message in the code base which has an tlv record nested in the overall message type therefore this behaviour was not observed before.

Don't we do something similar for UpfrontShutdownScript in OpenChannel and AcceptChannel?  Why do the benchmarks pass for them?

Moreover should we also include the Benchmark tests in the overall testrun sothat we capture future failure more reliably?

Yes, I think this is the best way to avoid bit rot.  Then when a new TLV is introduced, the test will fail and alert us that we need to update the benchmarks.

Thanks for your review, appreciate it :)
Good point, thats because the upfrontscript needs to be in the tlv-data, thats a hard requirement according to the bolts:
if both nodes advertised the option_upfront_shutdown_script feature:
MUST include upfront_shutdown_script with either a valid shutdown_scriptpubkey as required by shutdown scriptpubkey, or a zero-length shutdown_scriptpubkey (ie. 0x0000).

https://github.com/lightning/bolts/blob/master/02-peer-protocol.md
therefore the  compelete random string of ExtraOpaqueData gets swapped for the new 0x0000 byte tlv record. Thats why when ready this tlv record everything is fine and no random data is in the Opaque field. For the funding_locked there is no mandatory field in the tlv record therefore the random stream is written to the ExtraOpaqueData
The swapping happens here

Hmm I understand your points regarding adding it to the CI tests, so the initial issue of this PR was, because it was not on anyone's radar that the Benchmark tests were failing. But adding them to the CI is also maybe not the right approach. Maybe only execute them for specific releases so that we make sure they do not fail and pass at least ?

Hmm I understand your points regarding adding it to the CI tests, so the initial issue of this PR was, because it was not on anyone's radar that the Benchmark tests were failing. But adding them to the CI is also maybe not the right approach. Maybe only execute them for specific releases so that we make sure they do not fail and pass at least ?

Perhaps we can just run the benchmark tests on master branch? So they would be run after each merged PR but at least not for each update of each PR, which already saves some cycles but would still be noticed when they break (when we actually have fully green CI which is hopefully very soon).
What I mean is: if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/master' }} in the unit-bench job.

I like your idea so I changed the CI workflow for Benchmark tests.

@ziggie1984, remember to re-request review from reviewers when ready

@ziggie1984, remember to re-request review from reviewers when ready

At the moment, for a particular PR, we run benchmarks twice, one before and one after, to assess the performance improvement brought by the PR. Running benchmarks alone, however, doesn't provide us with any useful info.

What do you mean by "run twice" here, are the benchmarks already included in some kind of test-script or "should" a developer run the benchmark tests twice?
Anyways I agree maybe just put them out of the CI for now as you said and look in a separate PR how we can integrate the benchmarks properly.

@ziggie1984, remember to re-request review from reviewers when ready

@ziggie1984, remember to re-request review from reviewers when ready

@ziggie1984, remember to re-request review from reviewers when ready

@ziggie1984, remember to re-request review from reviewers when ready

@ziggie1984, remember to re-request review from reviewers when ready

@ziggie1984, remember to re-request review from reviewers when ready

@ziggie1984, remember to re-request review from reviewers when ready

@ziggie1984, remember to re-request review from reviewers when ready

@ziggie1984, remember to re-request review from reviewers when ready

Maybe this can be rebased and merged🧐

Maybe this can be rebased and merged🧐

Rebased and ready to be merged I think.


Put MSBuild on the PATH

Describe the bug
Can you put C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\MSBuild on the PATH please?
Virtual environments affected

[ ] macOS 10.14
[ ] Ubuntu 16.04 LTS
[ ] Ubuntu 18.04 LTS
[ ] Windows Server 2016 R2
[x] Windows Server 2019

Hello!
Could you please check answer in #294? I believe it will resolve this issue too

I think this should work out of the box @maxim-lobanov - is there a reason it can't?

On my local box, MSBuild is available only from Visual Studio Command Prompt. It is not available from Command Line. So I believed that it is expected.
If it works for you locally, probably, it may depend on version of VS / .NET Framework. Do you have any documentation links to confirm that msbuild should be available outside Visual Studio Command Prompt?

No, it's not based on documentation - rather than how I thought this would intuitively work. If I installed a package on any Linux distro and the executables weren't available in PATH afterwards, I'd consider the installation process broken... .NET Core does this properly, for instance.
Maybe my expectations are just not aligned with how this is supposed to work on Windows (where everything seems to be 10x more painful!).

Hm, good point. I didn't consider that msbuild is on PATH for macOS / Ubuntu and available without Visual Studio Command Prompt. For macOS, for example, it comes from /Library/Frameworks/Mono.framework/Versions/Current/Commands/msbuild
In this case, probably, we should add it on PATH for Windows too.
@alepauly , @al-cheb , any thoughts?

@maxim-lobanov @lol768 I wouldn't expect it to be in the PATH on Windows and instead I would want to use the Dev Command Prompt bat to set it up (or maybe a platform agnostic action, say setup-msbuild?). One thing to consider is that it's possible that there are differences between dotnet core MSBuild and the one packaged with Visual Studio. It could be confusing to know which one is getting used. I rather we don't add too many things to the PATH since it can create problems going forward.

@lol768 thanks for your suggestion but I'm going to close this as won't fix . If you feel strongly about it and want to discuss it further please don't hesitate to reopen.


Report Generation Query

Allow users to query for report generation history. This is to support a better onboarding experience.
Blocked by https://github.com/impactasaurus/server/issues/176

 Onboarding 2.0


Update versions to 2.4.0-SNAPSHOT

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/10196/
Test FAILed.


Wrong tasks displayed after filtering

How to reproduce:

Have yesterday tasks
Start a task today
Filter by yesterday

Observed:
Today's task is visible.
Expected:
Today's task is not visible.

/tdbot label bug


Update harness-provisioning-tutorial.md

Hi, this is the Documentation Manager at Harness, Michael Cretzman.
The URL for step 5.a is causing confusion because it uses a Harness account ID. People are using the ID listed in your doc, instead of using their own Harness account ID. I have updated that step to make it clearer.
Please accept this revision. Thank you.

@michaelcretzman : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@zchia Would you review the proposed update to the tutorial? Thanks.

any chance this can be done in the near future?

@michaelcretzman I'll send email to the content owner, @zchia. Thanks.

sign-off

#sign-off

Thanks for the review @zchia


intword uses English units regardless of the active localization

Not all languages group large numbers into A103 + B106, etc.  For example, Japanese has no word for 106.  Instead, it has a word for 104, and 106 is written as 100 of those.  Unsurprisingly, 2e7 is not written 20 × 100 × 104, but as 2000 × 104.  Translations should be able to specify which powers of 10 have special names.
What did you do?
>>> import humanize
>>> humanize.i18n.activate("ja_JP")
<gettext.GNUTranslations object at 0x102fcca00>
>>> humanize.intword(234909023)
'234.9 百万'
>>> humanize.intword(2349090)
'2.3 百万'

What did you expect to happen?
>>> humanize.intword(234909023)
'2.3億'
>>> humanize.intword(2349090)
'234.9万'

What actually happened?
>>> humanize.intword(234909023)
'234.9 百万'
>>> humanize.intword(2349090)
'2.3 百万'

(This is the equivalent of putting in 23490902 and getting "234.9 hundred thousand" in English)
What versions are you using?

OS: Fedora 39
Python: 3.12
Humanize: 4.9.0

Thanks for the report. I'm not sure how well suited this library is to adapt for this, but would review a PR if you'd like to look into it.


Adjust whitespace and use {% unless %} tag

Some additional minor changes to your Read more PR upstream.
Merging this PR here will automatically update your PR there.

closing as not applicable anymore


Add files via upload

https://www.auburn.k12.il.us/
https://sites.google.com/auburn.k12.il.us/academic-services/course-scheduling?authuser=0

@Kyomade Pull request merged. Thank you!


The "code relevance check" has a lot of false negatives around IC programming.

I get the "Sorry, but I can only assist with programming related questions." a lot while learning about firmware and IC programming. Sometimes my questions are more towards the hardware and I could understand that gets flagged. I'm in a Zephyr project and Copilot has been helpful many times as well.

VS Code Version: e7e037083ff4455cf320e344325dacb480062c3c
OS Version: MacOS 13.4.1
Logs:

This is after a few back and forth messages, including a decent code snippet reply, on the topic of interrupt handling, so It's not like my questions are out of context.
Steps to Reproduce:

Ask questions around firmware, IC communication, electronics.

Sorry to hear. We have updates on the off-topic filter planned and will make sure we got your test cases covered.

I can reproduce the error when I don't have any repo open and start the conversation fresh (so no previous code context). But once I have any tabs open, this seems to go away. @Voxar do you have all the context when you see the errors? Cc @zhiguoyu

I can reproduce it too

@Voxar , @felipe-ds-lima thanks for your patience. We've deployed an update that addresses this. Please let us know if you're still hitting these issues!

Closing for now, as those questions work. Please file new issues for follow-up reports.