Time difference between your browser and the server

General information

OS: macOS
Hypervisor: hyperkit
Did you run crc setup before starting it  - Yes

CRC version
version: 1.0.0-beta.5+f2aa58c
OpenShift version: 4.1.14 (embedded in binary)

CRC status
CRC VM:          Running
OpenShift:       Running (v4.x)
Disk Usage:      13.68GB of 16.09GB (Inside the CRC VM)
Cache Usage:     21.23GB
Cache Directory: /Users/yurak/.crc/cache

CRC config
no result.
Host Operating System
ProductName:	Mac OS X
ProductVersion:	10.14.6
BuildVersion:	18G95

Steps to reproduce

crc start
oc scale --replicas=1 statefulset --all -n openshift-monitoring; oc scale --replicas=1 deployment --all -n openshift-monitoring
user: kubeadmin
see also: https://github.com/code-ready/crc/blob/79013666bdf0e8aced766700dba325bbd5bc9735/docs/source/getting-started/content/proc_starting-monitoring-alerting-telemetry.adoc
open https://prometheus-k8s-openshift-monitoring.apps-crc.testing/graph in browser

Expected
No Error occurred.
Actual
Warning! Detected 105706.78 seconds time difference between your browser and the server. Prometheus relies on accurate time and time drift might cause unexpected query results.

Logs
check date -R
on crc node:
$ oc get nodes
NAME                 STATUS   ROLES           AGE   VERSION
crc-vsqrt-master-0   Ready    master,worker   12d   v1.13.4+3bd346709
$ oc debug nodes/crc-vsqrt-master-0
$ date -R
Fri, 27 Sep 2019 00:48:33 +0000

on Mac:
Sat, 28 Sep 2019 15:04:18 +0900
$ oc describe po/prometheus-k8s-0 -n openshift-monitoring
Name:               prometheus-k8s-0
Namespace:          openshift-monitoring
Priority:<PHONE_NUMBER>
PriorityClassName:  system-cluster-critical
Node:               crc-vsqrt-master-0/<IP_ADDRESS>
Start Time:         Fri, 27 Sep 2019 07:52:51 +0900
Labels:             app=prometheus
                    controller-revision-hash=prometheus-k8s-66b4f5d48f
                    prometheus=k8s
                    statefulset.kubernetes.io/pod-name=prometheus-k8s-0
Annotations:        k8s.v1.cni.cncf.io/networks-status:
                      [{
                          "name": "openshift-sdn",
                          "interface": "eth0",
                          "ips": [
                              "<IP_ADDRESS>"
                          ],
                          "default": true,
                          "dns": {}
                      }]
                    openshift.io/scc: restricted
Status:             Running
IP:                 <IP_ADDRESS>
Controlled By:      StatefulSet/prometheus-k8s
Containers:
  prometheus:
    Container ID:  cri-o://ace99b773b2632eecc0d9ee006a0b7872b997518ec1ff75cce6efea33a2f6aab
    Image:         quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:38e663d919d2c96af52656b42d18556cf457b84ef3160e27496f6db36ffa92a3
    Image ID:      quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:38e663d919d2c96af52656b42d18556cf457b84ef3160e27496f6db36ffa92a3
    Port:          <none>
    Host Port:     <none>
    Args:
      --web.console.templates=/etc/prometheus/consoles
      --web.console.libraries=/etc/prometheus/console_libraries
      --config.file=/etc/prometheus/config_out/prometheus.env.yaml
      --storage.tsdb.path=/prometheus
      --storage.tsdb.retention=15d
      --web.enable-lifecycle
      --storage.tsdb.no-lockfile
      --web.external-url=https://prometheus-k8s-openshift-monitoring.apps-crc.testing/
      --web.route-prefix=/
      --web.listen-address=<IP_ADDRESS>:9090
    State:          Running
      Started:      Fri, 27 Sep 2019 07:53:54 +0900
    Last State:     Terminated
      Reason:       Error
      Exit Code:    1
      Started:      Fri, 27 Sep 2019 07:53:27 +0900
      Finished:     Fri, 27 Sep 2019 07:53:27 +0900
    Ready:          True
    Restart Count:  1
    Environment:    <none>
    Mounts:
      /etc/prometheus/config_out from config-out (ro)
      /etc/prometheus/configmaps/kubelet-serving-ca-bundle from configmap-kubelet-serving-ca-bundle (ro)
      /etc/prometheus/configmaps/serving-certs-ca-bundle from configmap-serving-certs-ca-bundle (ro)
      /etc/prometheus/rules/prometheus-k8s-rulefiles-0 from prometheus-k8s-rulefiles-0 (rw)
      /etc/prometheus/secrets/kube-etcd-client-certs from secret-kube-etcd-client-certs (ro)
      /etc/prometheus/secrets/kube-rbac-proxy from secret-kube-rbac-proxy (ro)
      /etc/prometheus/secrets/prometheus-k8s-htpasswd from secret-prometheus-k8s-htpasswd (ro)
      /etc/prometheus/secrets/prometheus-k8s-proxy from secret-prometheus-k8s-proxy (ro)
      /etc/prometheus/secrets/prometheus-k8s-tls from secret-prometheus-k8s-tls (ro)
      /prometheus from prometheus-k8s-db (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from prometheus-k8s-token-cmngb (ro)
  prometheus-config-reloader:
    Container ID:  cri-o://6c33f02208969d692991f3b4c1ffb4a81bbe92c166a7221a03d9aaeff23f6d77
    Image:         quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:6c0551dd87cc7eacc18ccbac093043b1178225f64843f13435f02ae7c2b4d91e
    Image ID:      quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:6c0551dd87cc7eacc18ccbac093043b1178225f64843f13435f02ae7c2b4d91e
    Port:          <none>
    Host Port:     <none>
    Command:
      /bin/prometheus-config-reloader
    Args:
      --log-format=logfmt
      --reload-url=http://localhost:9090/-/reload
      --config-file=/etc/prometheus/config/prometheus.yaml
      --config-envsubst-file=/etc/prometheus/config_out/prometheus.env.yaml
    State:          Running
      Started:      Fri, 27 Sep 2019 07:53:39 +0900
    Ready:          True
    Restart Count:  0
    Environment:
      POD_NAME:  prometheus-k8s-0 (v1:metadata.name)
    Mounts:
      /etc/prometheus/config from config (rw)
      /etc/prometheus/config_out from config-out (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from prometheus-k8s-token-cmngb (ro)
  prometheus-proxy:
    Container ID:  cri-o://4b1272021f73be87c5a50d4ef0042a33f8c69c9e4fa9adb2edba0f0c84711c2b
    Image:         quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:383360705efc0605760c3b2b1d0fa288094eb6dad8158c540d950f661b4ba880
    Image ID:      quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:383360705efc0605760c3b2b1d0fa288094eb6dad8158c540d950f661b4ba880
    Port:          9091/TCP
    Host Port:     0/TCP
    Args:
      -provider=openshift
      -https-address=:9091
      -http-address=
      -email-domain=*
      -upstream=http://localhost:9090
      -htpasswd-file=/etc/proxy/htpasswd/auth
      -openshift-service-account=prometheus-k8s
      -openshift-sar={"resource": "namespaces", "verb": "get"}
      -openshift-delegate-urls={"/": {"resource": "namespaces", "verb": "get"}}
      -tls-cert=/etc/tls/private/tls.crt
      -tls-key=/etc/tls/private/tls.key
      -client-secret-file=/var/run/secrets/kubernetes.io/serviceaccount/token
      -cookie-secret-file=/etc/proxy/secrets/session_secret
      -openshift-ca=/etc/pki/tls/cert.pem
      -openshift-ca=/var/run/secrets/kubernetes.io/serviceaccount/ca.crt
      -skip-auth-regex=^/metrics
    State:          Running
      Started:      Fri, 27 Sep 2019 07:53:40 +0900
    Ready:          True
    Restart Count:  0
    Environment:    <none>
    Mounts:
      /etc/proxy/htpasswd from secret-prometheus-k8s-htpasswd (rw)
      /etc/proxy/secrets from secret-prometheus-k8s-proxy (rw)
      /etc/tls/private from secret-prometheus-k8s-tls (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from prometheus-k8s-token-cmngb (ro)
  kube-rbac-proxy:
    Container ID:  cri-o://b30466c9a26125e810a0f2e94c3dc76b2d3ab57f8048ce9e17f6946652af89ad
    Image:         quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:dab4af2713fa59499ee8d2cb169d636ddb425590e6924bc2c03597c0b10bd246
    Image ID:      quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:dab4af2713fa59499ee8d2cb169d636ddb425590e6924bc2c03597c0b10bd246
    Port:          9092/TCP
    Host Port:     0/TCP
    Args:
      --secure-listen-address=<IP_ADDRESS>:9092
      --upstream=http://<IP_ADDRESS>:9095
      --config-file=/etc/kube-rbac-proxy/config.yaml
      --tls-cert-file=/etc/tls/private/tls.crt
      --tls-private-key-file=/etc/tls/private/tls.key
      --tls-cipher-suites=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,TLS_RSA_WITH_AES_128_CBC_SHA256,TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256,TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256
      --logtostderr=true
      --v=10
    State:          Running
      Started:      Fri, 27 Sep 2019 07:53:41 +0900
    Ready:          True
    Restart Count:  0
    Environment:    <none>
    Mounts:
      /etc/kube-rbac-proxy from secret-kube-rbac-proxy (rw)
      /etc/tls/private from secret-prometheus-k8s-tls (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from prometheus-k8s-token-cmngb (ro)
  prom-label-proxy:
    Container ID:  cri-o://6e3b94f1e9c592d0b79eed7808e8ad82e2db2ee2c34ef23550ef4e33297cabb3
    Image:         quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:c77261cc981cc8a5193ca1199c0a119db5757de135f4f7f5e558744371d2bd8a
    Image ID:      quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:c77261cc981cc8a5193ca1199c0a119db5757de135f4f7f5e558744371d2bd8a
    Port:          <none>
    Host Port:     <none>
    Args:
      --insecure-listen-address=<IP_ADDRESS>:9095
      --upstream=http://<IP_ADDRESS>:9090
      --label=namespace
    State:          Running
      Started:      Fri, 27 Sep 2019 07:53:52 +0900
    Ready:          True
    Restart Count:  0
    Environment:    <none>
    Mounts:
      /var/run/secrets/kubernetes.io/serviceaccount from prometheus-k8s-token-cmngb (ro)
  rules-configmap-reloader:
    Container ID:  cri-o://c6c6fdfb6adbca27553e4bf7f6abf6b45d8c0c24aa787925d7b65ad60ca459b6
    Image:         quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:84bb7a8504eb34ff5e4e9ca92aab960c078ededed07ab0fe79620c0b9f32a51f
    Image ID:      quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:84bb7a8504eb34ff5e4e9ca92aab960c078ededed07ab0fe79620c0b9f32a51f
    Port:          <none>
    Host Port:     <none>
    Args:
      --webhook-url=http://localhost:9090/-/reload
      --volume-dir=/etc/prometheus/rules/prometheus-k8s-rulefiles-0
    State:          Running
      Started:      Fri, 27 Sep 2019 07:53:52 +0900
    Ready:          True
    Restart Count:  0
    Environment:    <none>
    Mounts:
      /etc/prometheus/rules/prometheus-k8s-rulefiles-0 from prometheus-k8s-rulefiles-0 (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from prometheus-k8s-token-cmngb (ro)
Conditions:
  Type              Status
  Initialized       True
  Ready             True
  ContainersReady   True
  PodScheduled      True
Volumes:
  config:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  prometheus-k8s
    Optional:    false
  config-out:
    Type:       EmptyDir (a temporary directory that shares a pod's lifetime)
    Medium:
    SizeLimit:  <unset>
  prometheus-k8s-rulefiles-0:
    Type:      ConfigMap (a volume populated by a ConfigMap)
    Name:      prometheus-k8s-rulefiles-0
    Optional:  false
  secret-kube-etcd-client-certs:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  kube-etcd-client-certs
    Optional:    false
  secret-prometheus-k8s-tls:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  prometheus-k8s-tls
    Optional:    false
  secret-prometheus-k8s-proxy:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  prometheus-k8s-proxy
    Optional:    false
  secret-prometheus-k8s-htpasswd:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  prometheus-k8s-htpasswd
    Optional:    false
  secret-kube-rbac-proxy:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  kube-rbac-proxy
    Optional:    false
  configmap-serving-certs-ca-bundle:
    Type:      ConfigMap (a volume populated by a ConfigMap)
    Name:      serving-certs-ca-bundle
    Optional:  false
  configmap-kubelet-serving-ca-bundle:
    Type:      ConfigMap (a volume populated by a ConfigMap)
    Name:      kubelet-serving-ca-bundle
    Optional:  false
  prometheus-k8s-db:
    Type:       EmptyDir (a temporary directory that shares a pod's lifetime)
    Medium:
    SizeLimit:  <unset>
  prometheus-k8s-token-cmngb:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  prometheus-k8s-token-cmngb
    Optional:    false
QoS Class:       BestEffort
Node-Selectors:  beta.kubernetes.io/os=linux
Tolerations:     node.kubernetes.io/not-ready:NoExecute for 300s
                 node.kubernetes.io/unreachable:NoExecute for 300s
Events:
  Type    Reason     Age                From                         Message
  ----    ------     ----               ----                         -------
  Normal  Scheduled  31h                default-scheduler            Successfully assigned openshift-monitoring/prometheus-k8s-0 to crc-vsqrt-master-0
  Normal  Pulling    31h                kubelet, crc-vsqrt-master-0  Pulling image "quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:38e663d919d2c96af52656b42d18556cf457b84ef3160e27496f6db36ffa92a3"
  Normal  Pulled     31h                kubelet, crc-vsqrt-master-0  Successfully pulled image "quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:38e663d919d2c96af52656b42d18556cf457b84ef3160e27496f6db36ffa92a3"
  Normal  Pulling    31h                kubelet, crc-vsqrt-master-0  Pulling image "quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:6c0551dd87cc7eacc18ccbac093043b1178225f64843f13435f02ae7c2b4d91e"
  Normal  Pulled     31h                kubelet, crc-vsqrt-master-0  Successfully pulled image "quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:6c0551dd87cc7eacc18ccbac093043b1178225f64843f13435f02ae7c2b4d91e"
  Normal  Pulled     31h                kubelet, crc-vsqrt-master-0  Container image "quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:383360705efc0605760c3b2b1d0fa288094eb6dad8158c540d950f661b4ba880" already present on machine
  Normal  Created    31h                kubelet, crc-vsqrt-master-0  Created container prometheus-config-reloader
  Normal  Started    31h                kubelet, crc-vsqrt-master-0  Started container prometheus-config-reloader
  Normal  Created    31h                kubelet, crc-vsqrt-master-0  Created container prometheus-proxy
  Normal  Pulled     31h                kubelet, crc-vsqrt-master-0  Container image "quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:dab4af2713fa59499ee8d2cb169d636ddb425590e6924bc2c03597c0b10bd246" already present on machine
  Normal  Started    31h                kubelet, crc-vsqrt-master-0  Started container prometheus-proxy
  Normal  Created    31h                kubelet, crc-vsqrt-master-0  Created container kube-rbac-proxy
  Normal  Started    31h                kubelet, crc-vsqrt-master-0  Started container kube-rbac-proxy
  Normal  Pulling    31h                kubelet, crc-vsqrt-master-0  Pulling image "quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:c77261cc981cc8a5193ca1199c0a119db5757de135f4f7f5e558744371d2bd8a"
  Normal  Created    31h                kubelet, crc-vsqrt-master-0  Created container prom-label-proxy
  Normal  Pulled     31h                kubelet, crc-vsqrt-master-0  Successfully pulled image "quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:c77261cc981cc8a5193ca1199c0a119db5757de135f4f7f5e558744371d2bd8a"
  Normal  Started    31h                kubelet, crc-vsqrt-master-0  Started container prom-label-proxy
  Normal  Pulled     31h                kubelet, crc-vsqrt-master-0  Container image "quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:84bb7a8504eb34ff5e4e9ca92aab960c078ededed07ab0fe79620c0b9f32a51f" already present on machine
  Normal  Created    31h                kubelet, crc-vsqrt-master-0  Created container rules-configmap-reloader
  Normal  Started    31h                kubelet, crc-vsqrt-master-0  Started container rules-configmap-reloader
  Normal  Pulled     31h                kubelet, crc-vsqrt-master-0  Container image "quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:38e663d919d2c96af52656b42d18556cf457b84ef3160e27496f6db36ffa92a3" already present on machine
  Normal  Started    31h (x2 over 31h)  kubelet, crc-vsqrt-master-0  Started container prometheus
  Normal  Created    31h (x2 over 31h)  kubelet, crc-vsqrt-master-0  Created container prometheus

This is a known issue with hyperkit (macOS) as the hypervisor does not resync the clock after suspension/sleep and hibernate. You can prevent this by stopping the VM and starting the cluster when needed.
We will take note and see what can be done, ...

I understood.
So, How can I change Timezone the crc VM?
Current:
Fri, 27 Sep 2019 00:48:33 +0000
Expected:
Fri, 27 Sep 2019 09:48:33 +0900

Is this difference in the timezone used by the VM causing issues?

I’m not sure because time synchronization can’t be done.
It may be one of the reason.

It's intentional that the VM uses UTC as its timezone. The time difference issue you had was because your laptop was suspended while the VM was running, and this is a known limitation of hyperkit.

I'm closing this as there is not much we can do on crc side

I also believe the note you saw was a 'warning' and not directly an error.
If issues do occur, please consider re-opening the issue or add a new one,
but provide detailed information about what does not work as expected.

For those who need to refresh the time of the server's (VM), it's possible (and easy) with ntpupdate
sudo apt-get update
sudo apt-get install ntp
sudo ntpdate pool.ntp.org

This fixed my issue on Windows WSL2 Ubuntu 20.04

For those who need to refresh the time of the server's (VM), it's possible (and easy) with ntpupdate
sudo apt-get update
sudo apt-get install ntp
sudo ntpdate pool.ntp.org

This fixed my issue on Windows WSL2 Ubuntu 20.04

Had the same issue. Fixed it in my WSL2 with a slight modification to this solution. Modified the second line to:-
sudo apt-get install ntpdate

@scotgopal Why are you running CRC from WSL2 ?

I wasn't running CRC actuall @gbraad . But had an issue with Prometheus that had the similar problem whereby the VM's time not in sync with the OS's.

Just confirming, as we 'disallow' the use of CRC from WSL2. As this would start a nested virtualization setup. While it can work (KVM from Hyper-V) it is not an ideal setup as startup and performance suffers.


PID rollover

r? @ebroder
cc @nelhage @papillon97

I have no idea what :upgrade means here, but my copy/paste seems to work :D

I can't come up with anything wrong with this. If one of @zenazn or @nelhage also agrees that they can't find anything wrong with it, then LGTM.

Yeah, I think this should suffice.


Test Pull Request.

A test to see the tests run on pull requests.

Testing in progress...

Testing in progress...

Test Failure:
Some test logs

Test Failure:
More logs


[6.4.x] kie-server: JSON marshaller fixes to support known use cases

back port of #371 to 6.4.x

Jenkins retest this

+1 to merge

merged into 6.4.x


Remove driver namespace

After a while, I think we don't need the ::Driver namespace, modules and classes can be defined inside the Mattermost module. Ex: Mattermost::Client

@castanhob What are your thoughts about this?


Login with email address

Dear all,
I have setup membershipreboot and configured it to use the email as username.
This scenario does not seem to be supported by the MembershipRebootUserService. Is this correct?
If so will it be supported or should I overwrite the AuthotenticateLocalAsync and perform a conversion trick in there.
Thanks for any help you can provide me with.
Alexandre

Do you have the MR configuration class configured to use email as username?

Any update?

Dear,
Thanks for the follow. I was using the wrong configuration. Everithing seems to be working fine.
Regards.
Alex
Sent from my Samsung device
-------- Original message --------
From: Brock Allen<EMAIL_ADDRESS>Date: 13/07/2015  02:50  (GMT+01:00)
To: "IdentityServer/IdentityServer3.MembershipReboot"<EMAIL_ADDRESS>Cc: Alexandre Roba<EMAIL_ADDRESS>Subject: Re: [IdentityServer3.MembershipReboot] Login with email address (#26)
Any update?
—
Reply to this email directly or view it on GitHub.


Remove Dockerfile.controller to prevent confusion

Having two Dockerfiles and different ways to build images within the repo is confusing to users. It also may be preferable to remove the option to build your own image from the deploy-federation.sh script eventually, but for now the script is just modified to keep the image build consistent with the Makefile and imagebuild.sh script.

Using the Makefile can be done in a follow-up PR.

/approve


read timeout values from config (or fallback to default)

Timeouts can be configured using the connect_timeout, sock_connect_timeout and `sock_read_timeout" kwargs.
Documentation for these can be found in the aiohttp docs: https://docs.aiohttp.org/en/stable/client_reference.html?highlight=clienttimeout#clienttimeout.
Setting these to 0 or None disables the timeouts entirely.
closes #15

Before adding config, I think we should research why the timeout is occurring, because this does not solve the default use case (timeout is an escape hatch, but very few will know about this).
The last time I checked, it seemed like a bug on how aiohttp considered timeout for streaming/chunked downloads/uploads.

Before adding config, I think we should research why the timeout is occurring, because this does not solve the default use case (timeout is an escape hatch, but very few will know about this).

Does it hurt to have the config?
We could at least suggest users facing the problem a workaround while we research where the timeout comes from?

@skshetry I agree. I'm researching the cause of the timeout, but I think it's worth to have this configurable by users in order to let users avoid failures with push on http remotes. It's only a workaround, but at least this will unblock some users.


StyleGuide - Add link to the set of tslint rules based on the style guide

Codelyzer (which at the moment is only a set of tslint rules based on the style guide) can provide style checking based on static code analysis. This way developers will be automatically warned if there's an issue in their code based on the recommended styles.
It might be beneficial for developers to have a link to it somewhere in the docs.
Currently the set of rules is used in:

angular-cli
angular2-seed
angular2-webpack-starter

Here's link https://www.npmjs.com/package/codelyzer.
// cc @johnpapa

Are you proposing adding a tslint.json to the guide?
Or are you proposing adding codelyzer link in the guide?
Or both?
I like both ideas :)
For the tslint.json, I'd like to compare it to what is here. Can you take a look? https://github.com/johnpapa/event-view/blob/master/tslint.json

Suggesting both :-)
codelyzer is only a set of Angular specific tslint rules for now.
I merged your existing tslint.json with the specific configuration of codelyzer's rules that align to the style guide. You can find the tsconfig here in this PR https://github.com/IdeaBlade/angular.io/pull/19/files.

Should we show the tslint.json in the guide itself? I think that'd be cool. @wardbell can you merge this https://github.com/IdeaBlade/angular.io/pull/19/files and then verify that we can use the makeExample to link to that tslint.json file?

@mgechev this is now linked to from the guide. Please update your github repo to point to this guide's link instead of your former guide repo.

I'll do that today.

this is all in the guide now.
we can close this (i dont seem to have permissions in this issue)

Yes, the link is updated as well.


Fix #84111

This PR fixes #84111

Thanks! Will be in the next VS Code insiders build and is scheduled to go out with VS Code 1.41


Support CDK Aspects

feat: Aspect POC
feat: Add datadog aspect
feat: No need to forward logs, addFunctions will do that
docs: Document Aspects in readme

What does this PR do?
Allows our construct to be imported and used as an Aspect, which makes it easier to instrument all functions in a stack without re-importing or re-declaring the Datadog construct.
Motivation

Testing Guidelines

Additional Notes

Types of Changes

[ ] Bug fix
[ ] New feature
[ ] Breaking change
[ ] Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

[ ] This PR's description is comprehensive
[ ] This PR contains breaking changes that are documented in the description
[ ] This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
[ ] This PR impacts documentation, and it has been updated (or a ticket has been logged)
[ ] This PR's changes are covered by the automated tests
[ ] This PR collects user input/sensitive content into Datadog

holding off on merging this because apparently this issue still remains.


Relax the version constraints of pyarrow.

What do these changes do?
Then we can work with other versions of pyarrow.

Codecov Report

Merging #103 (3ec6dce) into main (f21daf4) will increase coverage by 14.49%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #103       +/-   ##
===========================================
+ Coverage   62.09%   76.58%   +14.49%
===========================================
  Files          52       52
  Lines        3817     3784       -33
===========================================
+ Hits         2370     2898      +528
+ Misses       1447      886      -561

Impacted Files
Coverage Δ

src/server/services/etcd_meta_service.cc
81.48% <0.00%> (+5.55%)
:arrow_up:

src/common/util/status.h
48.86% <0.00%> (+5.68%)
:arrow_up:

src/common/util/status.cc
25.39% <0.00%> (+6.34%)
:arrow_up:

src/server/services/etcd_meta_service.h
92.00% <0.00%> (+12.00%)
:arrow_up:

src/common/util/protocols.cc
91.71% <0.00%> (+15.79%)
:arrow_up:

src/server/memory/stream_store.cc
64.48% <0.00%> (+16.33%)
:arrow_up:

src/server/async/socket_server.cc
82.50% <0.00%> (+16.75%)
:arrow_up:

src/server/util/meta_tree.cc
76.19% <0.00%> (+18.41%)
:arrow_up:

src/server/services/meta_service.h
75.81% <0.00%> (+28.59%)
:arrow_up:

src/server/server/vineyard_server.cc
74.12% <0.00%> (+32.54%)
:arrow_up:

... and 3 more


DLL search PATH for windows

A pitfall I ran into trying to run this on windows is that usd_from_gltf.exe depends on USD and ZLIB DLLs which it dynamically loads, and if these are not found it silently exits.  I had to use dependency walker to track down these missing run time dependencies and make sure the executable can find them.  I would add a hint to the README that these DLLs need to be added to PATH, or make the exe print an error.

Thanks for letting us know! I've added it to our task backlog.

I have the aforementioned DLLs in my PATH but it still seems to fail, not so silently but not very informatively. Any suggestions?
-------- Installing DRACO --------
  DRACO: File already exists, skipping download: D:\usd_from_gltf_build\src\draco.zip
  DRACO: Unpacking to: D:\usd_from_gltf_build\src\draco-1.3.5
  DRACO: CWD: D:\usd_from_gltf_build\build\draco-1.3.5
  DRACO: Run: cmake D:\usd_from_gltf_build\src\draco-1.3.5 -DCMAKE_INSTALL_PREFIX=D:\usd_from_gltf_build -DCMAKE_PREFIX_PATH=D:\usd_from_gltf_build -DCMAKE_POSITION_INDEPENDENT_CODE=1 -DCMAKE_GENERATOR_PLATFORM=x64
  DRACO: ERROR: [WinError 2] The system cannot find the file specified


Auto-detect user folders paths

User folders paths are stored in Windows Registry.
You can find them there : HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\User Shell Folders

Folder
Windows Registry Key

Desktop
Desktop

Downloads
{374DE290-123F-4565-9164-39C4925E467B}

Documents
Personal

Pictures
My Pictures

Music
My Music

Videos
My Video

(Source)
You should be able to get these by using Microsoft.Win32.Registry.GetValue.

I believe we are already detecting user paths, the only one that is not using that method at moment is the downloads folder, thank you for the registry key.

@KaKi87 would this work?         public static string DownloadsPath = string)Registry.GetValue(@"HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\User Shell Folders", "{374DE290-123F-4565-9164-39C4925E467B}", null);

@KaKi87 Can you verify #209 helps, if not I will need to know what changes to make, thanks.,

Send me an APPX and I'll tell you

@KaKi87 Are you still on discord?

I leaved UWP Community.

Ok, try getting it from here https://1drv.ms/u/s!AsMjD6AbL8azjrsBdZBSzqXv7SdY_w?e=c561Be

I'm not ARM but x64 and the certificate seems not to work. Error code 0x800B0109

@KaKi87 I will need to create a new package for you, I will try to do it later today.

@KaKi87 This is fixed for the v0.7 release. Thank you for your patience.


Changed png to text

Fixes #86

Please review @sarthology

Resolve conflicts

Resolved the conflicts. Please check @sarthology

Still there

Resolved the conflicts again @sarthology. Please check


🐛 [firebase_storage] SocketException: OS Error: Connection reset by peer, errno = 104, address = firebasestorage.googleapis.com, port = 48310

Cannot display any network image that are uploaded to Firebase Storage. Throws socket exception.
When I connect with VPN all everything works as expected.
There is general problem in TURKEY. Other developers around Turkey report the same problem.
Also trying to get download url throw an exception. Sign in or Sign out result is same.
Here is the log:
W/ExponenentialBackoff( 6677): network unavailable, sleeping.
E/StorageUtil( 6677): error getting token java.util.concurrent.ExecutionException: com.google.firebase.internal.api.FirebaseNoSignedInUserException: Please sign in before trying to get a token.
W/NetworkRequest( 6677): no auth token for request
W/NetworkRequest( 6677): No App Check token for request.
V/NativeCrypto( 6677): SSL handshake aborted: ssl=0xb4000073a73c4988: I/O error during system call, Connection reset by peer
W/NetworkRequest( 6677): error sending network request GET https://firebasestorage.googleapis.com/v0/b/aradiginhersey.appspot.com/o/ads%2FyXTZ4QWAjWjvcxPTbqCz%2FIMG-20211027-WA0031.jpg
W/NetworkRequest( 6677): javax.net.ssl.SSLHandshakeException: SSL handshake aborted: ssl=0xb4000073a73c4988: I/O error during system call, Connection reset by peer
W/NetworkRequest( 6677): 	at com.google.android.gms.org.conscrypt.NativeCrypto.SSL_do_handshake(Native Method)
W/NetworkRequest( 6677): 	at com.google.android.gms.org.conscrypt.NativeSsl.doHandshake(:com.google.android.gms<EMAIL_ADDRESS>(150400-410302452):6)
W/NetworkRequest( 6677): 	at com.google.android.gms.org.conscrypt.ConscryptFileDescriptorSocket.startHandshake(:com.google.android.gms<EMAIL_ADDRESS>(150400-410302452):16)
W/NetworkRequest( 6677): 	at com.android.okhttp.internal.io.RealConnection.connectTls(RealConnection.java:196)
W/NetworkRequest( 6677): 	at com.android.okhttp.internal.io.RealConnection.connectSocket(RealConnection.java:153)
W/NetworkRequest( 6677): 	at com.android.okhttp.internal.io.RealConnection.connect(RealConnection.java:116)
W/NetworkRequest( 6677): 	at com.android.okhttp.internal.http.StreamAllocation.findConnection(StreamAllocation.java:186)
W/NetworkRequest( 6677): 	at com.android.okhttp.internal.http.StreamAllocation.findHealthyConnection(StreamAllocation.java:128)
W/NetworkRequest( 6677): 	at com.android.okhttp.internal.http.StreamAllocation.newStream(StreamAllocation.java:97)
W/NetworkRequest( 6677): 	at com.android.okhttp.internal.http.HttpEngine.connect(HttpEngine.java:289)
W/NetworkRequest( 6677): 	at com.android.okhttp.internal.http.HttpEngine.sendRequest(HttpEngine.java:232)
W/NetworkRequest( 6677): 	at com.android.okhttp.internal.huc.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:465)
W/NetworkRequest( 6677): 	at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getResponse(HttpURLConnectionImpl.java:411)
W/NetworkRequest( 6677): 	at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getResponseCode(HttpURLConnectionImpl.java:542)
W/NetworkRequest( 6677): 	at com.android.okhttp.internal.huc.DelegatingHttpsURLConnection.getResponseCode(DelegatingHttpsURLConnection.java:106)
W/NetworkRequest( 6677): 	at com.android.okhttp.internal.huc.HttpsURLConnectionImpl.getResponseCode(HttpsURLConnectionImpl.java:30)
W/NetworkRequest( 6677): 	at com.google.firebase.storage.network.NetworkRequest.parseResponse(NetworkRequest.java:417)
W/NetworkRequest( 6677): 	at com.google.firebase.storage.network.NetworkRequest.performRequestStart(NetworkRequest.java:250)
W/NetworkRequest( 6677): 	at com.google.firebase.storage.network.NetworkRequest.performRequest(NetworkRequest.java:270)
W/NetworkRequest( 6677): 	at com.google.firebase.storage.network.NetworkRequest.performRequest(NetworkRequest.java:289)
W/NetworkRequest( 6677): 	at com.google.firebase.storage.internal.ExponentialBackoffSender.sendWithExponentialBackoff(ExponentialBackoffSender.java:113)
W/NetworkRequest( 6677): 	at com.google.firebase.storage.internal.ExponentialBackoffSender.sendWithExponentialBackoff(ExponentialBackoffSender.java:68)
W/NetworkRequest( 6677): 	at com.google.firebase.storage.GetDownloadUrlTask.run(GetDownloadUrlTask.java:77)
W/NetworkRequest( 6677): 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
W/NetworkRequest( 6677): 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
W/NetworkRequest( 6677): 	at java.lang.Thread.run(Thread.java:923)

Steps to reproduce

Create a Project
Add network image widget
Example: Image.network("https://firebasestorage.googleapis.com/v0/b/aradiginhersey.appspot.com/o/ads%2FyXTZ4QWAjWjvcxPTbqCz%2FIMG-20211027-WA0040.jpg?alt=media&token=b0fa40ff-92ca-4e1a-8d68-82ea25db7470")
See the error on screen.
This image can be displayed on browser.

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
Package Version: firebase_storage: ^10.1.0

[✓] Flutter (Channel stable, 2.5.3, on Mac OS X 10.15.7 19H15 darwin-x64, locale tr-TR)
• Flutter version 2.5.3 at /Volumes/ExtremeSSD/Sdklar/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 18116933e7 (5 weeks ago), 2021-10-15 10:46:35 -0700
• Engine revision d3ea636dc5
• Dart version 2.14.4

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
• Android SDK at /Volumes/ExtremeSSD/Sdklar/Android/sdk
• Platform android-31, build-tools 31.0.0
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
• All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 12.4, Build version 12D4e
• CocoaPods version 1.11.2

[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] VS Code (version 1.59.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension can be installed from:
🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] VS Code (version 1.62.3)
• VS Code at /Volumes/ExtremeSSD/Uygulamalar/Visual Studio Code.app/Contents
• Flutter extension can be installed from:
🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] VS Code (version 1.47.3)
• VS Code at /Volumes/ExtremeSSD/Yedekler/Downloads/Visual Studio Code.app/Contents
• Flutter extension can be installed from:
🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (3 available)
• Redmi Note 9 Pro (mobile) • 7c575471 • android-arm64 • Android 11 (API 30)
• macOS (desktop) • macos • darwin-x64 • Mac OS X 10.15.7 19H15 darwin-x64
• Chrome (web) • chrome • web-javascript • Google Chrome 95.0.4638.69

• No issues found!

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 2.14.4
Flutter SDK 2.5.3
image_test 1.0.0+1

dependencies:
- cupertino_icons 1.0.4
- flutter 0.0.0 [characters collection meta typed_data vector_math sky_engine]

dev dependencies:
- flutter_lints 1.0.4 [lints]
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher meta source_span stream_channel string_scanner term_glyph typed_data]

transitive dependencies:
- async 2.8.1 [collection meta]
- boolean_selector 2.1.0 [source_span string_scanner]
- characters 1.1.0
- charcode 1.3.1
- clock 1.1.0
- collection 1.15.0
- fake_async 1.2.0 [clock collection]
- lints 1.0.1
- matcher 0.12.10 [stack_trace]
- meta 1.7.0
- path 1.8.0
- sky_engine 0.0.99
- source_span 1.8.1 [collection path term_glyph]
- stack_trace 1.10.0 [path]
- stream_channel 2.1.0 [async]
- string_scanner 1.1.0 [charcode source_span]
- term_glyph 1.2.0
- test_api 0.4.2 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher]
- typed_data 1.3.0 [collection]
- vector_math 2.1.0

Cloud anyone help?

I faced the same error. It's about Google Servers. When I conveyed this situation to them, they stated that they were aware of it and that they were working to fix the problem. For now, the situation has improved with the Turkcell internet provider, but the problem continues for TurkTelekom. I hope it will be fixed soon.

Hi @ctykaya, Thanks for filing the issue.

When I connect with VPN all everything works as excepted.

So this seems to be an issue with your ISP, Unfortunately, the plugin has no control over this.  Closing this issue as invalid if you disagree feel free to write in the comments and I will reopen it.
Thank you.


⚠ Bofrost.be has degraded performance

In d696342, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1260 ms

Resolved: Bofrost.be performance has improved in 594120b.


Traienr Icon

After downloading the latest trainer I click on the icon and nothing happens, and it doesn't open. Any suggestions?

Did a previous version work? Did you extra the newtonsoft dll as well?

My solution is to unistall .net and install back

Great. You need the latest version which is linked to in the readme

Yes, I was using an older version and then downloaded the newest version and the newest version wouldn't even attempt to open. I'll try again, tho. BTW, the trainer is awesome and am glad you are keeping up on the updates for us. Much appreciated.
On Saturday, March 18, 2017 3:19 AM, Joff<EMAIL_ADDRESS>wrote:

Closed #52.—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

So, I figured out the problem could be that I didn't extract Newtonsoft. How do I extract it through WinZip, and where do I extract it to? Your help is much appreciated.
On Saturday, March 18, 2017 3:33 PM, david watts<EMAIL_ADDRESS>wrote:

Yes, I was using an older version and then downloaded the newest version and the newest version wouldn't even attempt to open. I'll try again, tho. BTW, the trainer is awesome and am glad you are keeping up on the updates for us. Much appreciated.
On Saturday, March 18, 2017 3:19 AM, Joff<EMAIL_ADDRESS>wrote:

Closed #52.—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


[OAP-COMMON] rename common package

What changes were proposed in this pull request?
rename common package
How was this patch tested?
UT

@winningsix


Atomic Relayer

This patch adds the atomic relayer-- a different relayer that doesn't use self destruct.  Additionally:
We add Manifest, a way to deterministically deploy contracts (not used for Relayer right now, but it's a cool feature derived from the existence of CodeJar). We do improve deployments by switching to a Foundry script and relying way less on bash scripting.
Also, we add Invariants-- the ability to attach code that must always hold after any transaction on your account.

merged, per @hayesgm 's request


Add files via upload

Your checklist for this pull request
Author name
Anayal8er
About your game
What is your game about?
exploring a simple maze as a blue stick figure
How do you play your game?
Press WASD to move, J to restart. Reach the star to go onto the next level
Code
Check off the items that are true.

[ x] The game was made using the Sprig editor.
[ x] The game is placed in the in the /games directory.
[ x] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[x ] The game runs without errors.
[ ] The name of the file/game contains only alphanumeric characters, -s, or _s.
[ ] The game name is not the same as the others from gallery

Image (If an image is used)

[ ] The image is in the /games/img directory.
[ ] The name of the image matches the name of your file.

Thanks for your PR!

Please contact me directly to move forward w/ this PR and desired Sprig grant.


implement AD for lax.reduce_window

In this  example I define 4 identical pooling functions,
https://colab.research.google.com/gist/romanngg/fdd96829faaf0a7e666bccc5fd27ba58/pooling_fail.ipynb
p = r.normal(r.PRNGKey(1), (1, 1))
args = (1, 1), (2, 1), [(0, 0), (1, 0)]

def pool_1(p):
  return lax._reduce_window_sum(p, *args)

def pool_2(p):
  return lax.reduce_window(p, np.zeros((), p.dtype), lax.add, *args)

pool_1_jit = jit(pool_1)
pool_2_jit = jit(pool_2)

but as you can see differentiating their jitted versions doesn't work, producing different errors, e.g.
for lax.reduce_window:
NotImplementedError: Differentiation rule for 'reduce_window' not implemented

or for lax._reduce_window_sum:
RuntimeError                              Traceback (most recent call last)
/usr/local/lib/python3.7/dist-packages/jax/interpreters/xla.py in backend_compile(backend, built_c, options)
    383   # we use a separate function call to ensure that XLA compilation appears
    384   # separately in Python profiling results
--> 385   return backend.compile(built_c, compile_options=options)
    386
    387 def _execute_compiled_primitive(prim, compiled, result_handler, *args):

RuntimeError: Invalid argument: Window dimensions {
  size: 1
  stride: 1
  window_dilation: 1
  base_dilation: 1
}
dimensions {
  size: 1
  stride: 1
  window_dilation: 1
  base_dilation: 1
}
dimensions {
  size: 1
  stride: 1
  padding_low: -1
  window_dilation: 1
  base_dilation: 1
}
 has a negative low padding.
	, for instruction %reduce-window = f32[2,1,1]{2,1,0} reduce-window(f32[2,1,2]{2,1,0} %parameter.1, f32[] %constant.5), window={size=1x1x1 pad=0_0x0_0x-1_0}, to_apply=%primitive_computation_add.6, metadata={op_type="reduce_window_sum" op_name="jit(vmap(transpose(jvp(pool_1))))/reduce_window_sum[ base_dilation=(1, 1, 1)\n                                                     padding=((0, 0), (0, 0), (0, 0))\n                                                     window_dilation=(1, 1, 1)\n                                                     window_dimensions=(1, 1, 1)\n                                                     window_strides=(1, 1, 1) ]" source_file="<ipython-input-2-ee69b86aa221>" source_line=6}

Failed after simplification

The first error has all of the information:
NotImplementedError: Differentiation rule for 'reduce_window' not implemented

We need to implement AD for this primitive.
Regarding the second error, we should always try to avoid generating invalid HLO that results in XLA runtime errors, but note that this one came about by differentiating a non-public function from jax internals, which isn't allowed.
One idea there is to validate window dimension in the jaxpr checker, so that we catch this before lowering to HLO.

Thanks Roy, maybe naive question, but shouldn't this rule be already implemented if I'm able to differentiate it without jit (and it only throws the NotImplementedError if I jit it), so I wonder if there's some bug in interacting between jit and AD?

Thanks for highlighting that! I overlooked it in the notebook that you shared.
What's happening is a bit tricky, but has to do with how we handle a special case of lax.reduce_window as an optimization just before binding the underlying primitive (which has no AD rule):
https://github.com/google/jax/blob/e7e5140dc9fd192154e866794424d073e5c8d2b0/jax/_src/lax/lax.py#L1387-L1393
This tries to identify known monoids (an associative operation with an identity element) as the reduction function and initial value. For instance, if we successfully notice a reduction with (+, 0), then we proceed to call an internal _reduce_window_sum, rather than following the general path. The sum-specific path has AD rules.
When jax transforms a function, it interprets it with abstract arguments. The degree of abstraction depends on the transformation involved. For autodiff alone, we still have enough information to concretely identify the 0 part of the (+, 0), but once we involve compilation as well, we abstract the computation further (to shapes/dtypes) and can at most say that we have addition with a float32 scalar initial value, i.e. "(+, f32[])." Since we can't guarantee the 0 initial value, we continue on the general path, for which there is no AD rule.
Note also that, if you were to reduce with an operation other than +, this would also send you down the general path, and hence would err with or without jit.
I was about to suggest, as a workaround, to hard-code the initial value as a constant zero by rewriting:
import numpy as onp

def pool_2(p):
  return lax.reduce_window(p, onp.zeros((), p.dtype), lax.add, *args)

pool_2_jit = jit(pool_2)
print(jacobian(pool_2_jit)(p))

But it turns out this actually reproduces your original XLA runtime error, from differentiating pool_1_jit, using only public lax functions! We must be hitting the same bug here that you encountered when differentiating _reduce_window_sum directly. In hindsight, your code set up that test case correctly, even if calling internal functions isn't otherwise allowed. Apologies there!
In summary, we have a feature request (for AD on the general path) and a bug (with staging+AD on special path) at the same time.

I posted #7860 for the bug and we can keep this as the feature request.

Thanks a lot for such detailed explanation Roy!

Has there been any progress on this? I wrote this quick implementation of a jvp rule utilizing the fact that reduce_window can take multiple operands. I first tried setting it as the rule for the reduce_window_p primitive but couldn't figure out how to get the function argument passed in params (#4918). Still need to implement a transpose rule, though an explicit vjp may be more straightforward as a scatter_add of the computation-level vjp  into the original shape.
from typing import Any, Callable, Sequence, Union, Optional

import jax
import jax.lax as lax
import jax.numpy as jnp

from functools import partial

Array = Any

@partial(jax.custom_jvp, nondiff_argnums=range(2, 8))
def reduce_window(
    operand: Array,
    init_value: Array,
    computation: Callable,
    window_dimensions: Sequence[Union[int, Any]],
    window_strides: Sequence[int],
    padding: Union[str, Sequence[tuple[int, int]]],
    base_dilation: Optional[Sequence[int]]=None,
    window_dilation: Optional[Sequence[int]]=None
):
    return lax.reduce_window(
        operand=operand,
        init_value=init_value,
        computation=computation,
        window_dimensions=window_dimensions,
        window_strides=window_strides,
        padding=padding,
        base_dilation=base_dilation,
        window_dilation=window_dilation
    )

@reduce_window.defjvp
def reduce_window_jvp(
    computation: Callable,
    window_dimensions: Sequence[Union[int, Any]],
    window_strides: Sequence[int],
    padding: Union[str, Sequence[tuple[int, int]]],
    base_dilation: Optional[Sequence[int]],
    window_dilation: Optional[Sequence[int]],
    primals: Array,
    tangents: Array
):
    def fun(*args):
        primals, tangents = zip(*args)
        return jax.jvp(computation, primals, tangents)

    def make_zero(tan):
        return lax.zeros_like_array(x) if type(tan) is ad.Zero else tan

    tangents = tuple(make_zero(tan) for tan in tangents)

    primals, tangents = lax.reduce_window(
        operand=(primals[0], tangents[0]),
        init_value=(primals[1], tangents[1]),
        computation=fun,
        window_dimensions=window_dimensions,
        window_strides=window_strides,
        padding=padding,
        base_dilation=base_dilation,
        window_dilation=window_dilation
    )
    return primals, tangents

x = jnp.linspace(-12., 12., 25).reshape(5, 5)
x_dot = jnp.ones_like(x)
test = reduce_window_jvp(lax.add, (3, 3), (1, 1), ((1, 1), (1, 1)), None, None, (x, 0.), (x_dot, 0.))
true = jax.jvp(lambda x: lax.reduce_window(x, 0., lax.add, (3, 3), (1, 1), ((1, 1), (1, 1))), (x,), (x_dot,))
print([jnp.allclose(elem1, elem2) for (elem1, elem2) in zip(test, true)]) #[Array(True, dtype=bool), Array(True, dtype=bool)]

I realized the computation function is passed as a Jaxpr and created a jvp-rule for the reduce_window primitive. I've also implemented custom_vjp that I should be able to adapt into a transposition operation for general pytrees. However, it seems that linearize requires that the primal values be partially evaluated without knowing the tangents, which is not possible for this op. Is this a computation requirement or a convention?
def accumulator(computation):
    def fun(x, y):
        z = computation(x[0], y[0])
        index = jnp.array(x[1], dtype=jnp.int32)
        rest = jnp.stack(x[2:], axis=0)
        rest = jnp.where(jnp.arange(len(rest)) == index, z, rest)
        rest = jnp.where(jnp.arange(len(rest)) == len(rest) // 2 + index, y[1], rest)
        rest = jnp.split(rest, len(rest))
        rest = [elem.squeeze() for elem in rest]
        return z, index + 1., *rest
    return fun

def reduce_window_fwd(
    operand: Array,
    init_value: Array,
    computation: Callable,
    window_dimensions: Sequence[Union[int, Any]],
    window_strides: Sequence[int],
    padding: Union[str, Sequence[tuple[int, int]]],
    base_dilation: Optional[Sequence[int]]=None,
    window_dilation: Optional[Sequence[int]]=None
):
    size = reduce(mul, window_dimensions)
    location = jnp.arange(operand.size, dtype=operand.dtype).reshape(operand.shape)
    new_operand = (operand, location) + (jnp.zeros_like(operand),) * (2 * size)
    new_init_value = (init_value, 0.) + (0.,) * size + (-1.,) * size

    out, _, *intermediates = lax.reduce_window(
        operand=new_operand,
        init_value=new_init_value,
        computation=accumulator(computation),
        window_dimensions=window_dimensions,
        window_strides=window_strides,
        padding=padding,
        base_dilation=base_dilation,
        window_dilation=window_dilation
    )
    return out, (operand, init_value, intermediates)

def reduce_window_bwd(
    computation: Callable,
    window_dimensions: Sequence[Union[int, Any]],
    window_strides: Sequence[int],
    padding: Union[str, Sequence[tuple[int, int]]],
    base_dilation: Optional[Sequence[int]],
    window_dilation: Optional[Sequence[int]],
    context,
    tangents
):
     def step(carry, x):
        tout = carry
        input1, input2 = x
        _, vjpfun = jax.vjp(computation, input1, input2)
        tin1, tin2 = vjpfun(tout)
        carry, targ = map(
            partial(jnp.where, jnp.isfinite(input2)), [tin1, tin2], [tout, 0.])
        return carry, targ

    operand, init_value, intermediates = context
    length = len(intermediates)
    index = jnp.stack(intermediates[length // 2:], axis=0).astype(jnp.int32)
    indices = jnp.unravel_index(index, operand.shape)
    init_value_broadcast = jnp.full(operand.shape, init_value)
    input1 = jnp.stack(
        [init_value_broadcast] + intermediates[:length // 2 - 1], axis=0)
    input2 = jnp.where(index >= 0, operand[indices], jnp.nan)
    t_init, t_operand_stacked = lax.scan(
        step, tangents, xs=(input1, input2), reverse=True)
    t_operand = lax.scatter_add(
        jnp.zeros_like(operand),
        jnp.stack(indices, axis=-1),
        updates=t_operand_stacked,
        dimension_numbers=lax.ScatterDimensionNumbers((), (0, 1), (0, 1))
    )
    return t_operand, t_init.sum()

reduce_window.defvjp(reduce_window_fwd, reduce_window_bwd)

x = jnp.linspace(-12., 12., 25).reshape(5, 5)
test = jax.grad(lambda x, y: jnp.cos(reduce_window(x, y, lax.max, (3, 3), (1, 1), ((1, 1), (1, 1)))).sum())(x, -1e7)
true = jax.grad(lambda x: jnp.cos(lax.reduce_window(x, -jnp.inf, lax.max, (3, 3), (1, 1), ((1, 1), (1, 1)))).sum())(x)
jnp.allclose(test, true) # Array(True, dtype=bool)

I did the jvp for this. Working on transpose.

I did the jvp for this. Working on transpose.

Very cool. I think I final did get a jvp and transpose working based on an the inverse op from oryx. Honestly forgot why I needed this in the first place but here's the colab: https://colab.research.google.com/drive/1B0o4P1T4UTLI4Q8eKOdzUjI4DnfzR6nP?usp=sharing

Oh cool! Yeah the jvp is landed in main as of this week.
Ty for sharing the colab. I’m afraid to click that link. I already have
transpose mostly working (higher orders, and composing nicely with jvp, all
passing grad accuracy checks etc) except without dilation yet (gonna add
that today).
On Sat, May 11, 2024 at 5:04 AM deas-mhumhna @.***>
wrote:

I did the jvp for this. Working on transpose.
Very cool. I think I final did get a jvp and transpose working based on an
the inverse op from oryx. Honestly forgot why I needed this in the first
place but here's the colab:
https://colab.research.google.com/drive/1B0o4P1T4UTLI4Q8eKOdzUjI4DnfzR6nP?usp=sharing
—
Reply to this email directly, view it on GitHub
https://github.com/google/jax/issues/7815#issuecomment-2105712527, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABEI6NBKZLWUEITJO4J6OQ3ZBYCOHAVCNFSM5DMWMYH2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMJQGU3TCMRVGI3Q
.
You are receiving this because you commented.Message ID:
@.***>


HDH-330-illegal-characters-in-armory-file-names-for-windows

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: __________________________________
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://671f7df12d211a0ca0eeb45d--harness-developer.netlify.app

@rohanmaharjan100 have you also changed the links accordingly after renaming the files?


chore: add .npmignore

Please describe the changes this PR makes and why it should be merged:
These are all the files that are installed currently:

Could also use files in the package.json file, with something like **/*.js


Bump assistant packages

Finally everything is working and this is ready for review

Pending changes on sketch-assistants on https://github.com/sketch-hq/sketch-assistants/pull/185


Warn when generating "n+1" queries

See #11340

I suggest throwing an exception by default, which may be turned off entirely by configuration, or locally within query, like  IQueryable.WithPolicy(QueryPolicy.AllowNested) or something

Closing since the 3.0 query pipeline does not generate these queries.


DocIndex: Validate if search_field is valid

When a user passes a search_field we should check in the abstract class if it correspons to one of the columns that was parsed from the schema. That we the backend implementer does not have to worry about it, and we can give a uniform error message.

@JohannesMessner I would like to take up the issue.

Update on the issue🔔
I feel to have found the right file where the code needs to be added i.e. here
And I have a brief idea about what code needs to be added as well. That goes like this:
class DocIndex:
    def __init__(self, schema):
        self.columns = [column['name'] for column in schema['columns']]

    def validate_search_field(self, search_field):
        if search_field in self.columns:
            return True
        else:
            raise ValueError(f{search_field} is not a valid search field. Valid search fields are: {', '.join(self.columns)})

Though this is not the actual code this has to be the logic. But I cannot rightly insert the code.
Any input is appreciated.
P.S.: This is my 1st contribution to this project.

Hey @srini047, sorry for the delayed response!
Your logic looks about right!
The only thing is that __init__() doesn't actually accept a schema, but the abstract class already stores self._column_infos.
So your code could look something like this:
class DocIndex:
    def validate_search_field(self, search_field):
        if search_field in self._column_infos.keys():
            return True
        else:
            raise ValueError(f{search_field} is not a valid search field. Valid search fields are: {', '.join(self._column_infos.keys())})

Don't hesitate to open a (draft) PR for this, even before you are completely done!

Hey @srini047, sorry for the delayed response!
Your logic looks about right! The only thing is that __init__() doesn't actually accept a schema, but the abstract class already stores self._column_infos. So your code could look something like this:
class DocIndex:
    def validate_search_field(self, search_field):
        if search_field in self._column_infos.keys():
            return True
        else:
            raise ValueError(f{search_field} is not a valid search field. Valid search fields are: {', '.join(self._column_infos.keys())})

Don't hesitate to open a (draft) PR for this, even before you are completely done!

Thanks for such a humble reply. I'm in the process of making a draft PR.


Partial fix for #4289 (change active profile at runtime)

Overview
This change is a partial fix for #4289. Applications can now switch the MixedRealityToolkit.ActiveProfile value at runtime (with some side-effects):

There is a collection changed error from LateUpdate when changing profiles (#6042)
The DefaultCursor gets duplicated during some profile transitions (#6041)

Verification

Created a simple scene with a single button that switches between two profiles (default and HoloLens2)
Use input simulation to toggle profiles in the editor
Confirmed expected services are enabled

closing... will open new PR when this is no longer a partial fix


[Mobile]/[Desktop] Error: The non-abstract class 'RawEditorState' is missing implementations for these members:

My issue is about [Mobile]
My issue is about [Desktop]
After switching to flutter 3.0.0, flutter_quill 4.1.9 stopped working and is throwing exception on launch.
...
Running Gradle task 'assembleDebug'...
../../.pub-cache/hosted/pub.dartlang.org/flutter_quill-4.1.9/lib/src/widgets/raw_editor.dart:233:7: Error: The non-abstract class 'RawEditorState' is missing implementations for these members:
 - TextInputClient.insertTextPlaceholder
 - TextInputClient.removeTextPlaceholder
Try to either
 - provide an implementation,
 - inherit an implementation from a superclass or mixin,
 - mark the class as abstract, or
 - provide a 'noSuchMethod' implementation.
...

Tried on Mobile and Desktop. Most likely it affects all platforms.
Details
[✓] Flutter (Channel stable, 3.0.0, on macOS 12.3.1 21E258 darwin-arm, locale en-HK)
    • Flutter version 3.0.0 at /Users/Aurimas/FlutterProject/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ee4e09cce0 (2 days ago), 2022-05-09 16:45:18 -0700
    • Engine revision d1b9a6938a
    • Dart version 2.17.0
    • DevTools version 2.12.2

not all users are using 3.0.0.
So please don't scream just because you are using 3.0.0.


fix: Include model_type in loadModel modelKey json passed by the puller

Motivation
When using the puller with non-builtin runtimes, the modelType provided in the Predictor is passed within some json in the modelKey field because the internal modelType field is used for model placement constraints (it's historical/unfortunate and we hope to change that soon).
However, after the recent storage-related refactor this separate model_type attribute is no longer being passed through.
Also, the storage_key and storage_params attributes are passed along by the puller but this doesn't really make sense because they're consumed by the puller and intended to be abstracted away from the runtime.
Modifications

Ensure the model_type json attribute is passed through
Remove storage_key, storage_params and bucket attributes from the transformed request
Update unit tests to cover this behaviour

Result
Non-built-in runtimes have direct access to the predictor's modelType and are shielded from storage parameters that they shouldn't have to know about.

Thanks @tjohnson31415 have addressed your comments, PTAL


feat: add inception v3 support

This PR adds Inception V3 support.
The model has a transformation block, which does not have a gradient function:
x_ch0 = torch.unsqueeze(x[:, 0], 1) * (0.229 / 0.5) + (0.485 - 0.5) / 0.5
x_ch1 = torch.unsqueeze(x[:, 1], 1) * (0.224 / 0.5) + (0.456 - 0.5) / 0.5
x_ch2 = torch.unsqueeze(x[:, 2], 1) * (0.225 / 0.5) + (0.406 - 0.5) / 0.5
x = torch.cat((x_ch0, x_ch1, x_ch2), 1)

Having encountered an input node without a gradient function, I skip the propagation. Although, this works on this model, since shapes before and after transformation match, we may face shape mismatch issue in future.

Looks good to me.


Add download link for MDS 2019 CTP Add-In

Add download link for MDS 2019 CTP Add-In

@v-redu : Thanks for your contribution! The author, @leolimsft, has been notified to review your proposed change.

@craigg-msft - Could you review the proposed changes? The listed author @LeoLiMSFT isn't showing up in the Assignees box as Microsoft-internal. Thank you.

the change looks good.  #sign-off @v-redu its preferable if you make changes through the internal repo rather than the external. it looks like Leo has changed his git id to @lrtoyou1223 I will follow-up with him.

@craigg-msft: I'm sorry - only the author of this article, @leolimsft, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

Hi @v-redu - for future reference:
Microsoft authors and contributors need to make content contributions through the private repository so the content can be staged and validated by the current validation rules.
Read about authors working in the public repo for more information.
If you need help getting set up to work in the private repo, see Set up Git repository locally for documentation.


Feature/data collection

Scripts for collecting reviews from Steam API and merging returned csv files.
Sample data included.

ok


operator external-secrets-operator (0.10.5)

bump external-secrets-operator 0.10.5

@Skarlso I'm merging this - your name listed in ci.yaml skarlso should be fixed to Skarlso so you can unblock auto merging for your PRs.

Ah thanks very much. I'll take care of that.

@mantomas created the fix for the username. Thanks again 🙇 https://github.com/redhat-openshift-ecosystem/community-operators-prod/pull/5448


Let crossterm to initialyze with file for stdout

Currently crossterm chooses /dev/tty by default for *nix however it may be required to initialize it with e.g. /dev/stdout
it can be used like this
let cur = cursive::CursiveRunnable::new(|| {
            cursive::backends::crossterm::Backend::init_with_stdout_file(std::fs::File::create(
                "/dev/stdout",
            )?)
        })

Sorry for the delay - this looks great! Thanks!

Do we have an ETA on when this is going to be put into an official release? I'm working on a crate that lets you control two terminals with one Cursive application (the normal terminal and another tty) but it needs this MR to be up on crates.io


Whisper Implementation in Levanter

Hi @dlwh!
Have all the basic functionality implemented. I've confirmed that the code loads from the HuggingFace config and at least forward passes without error when provided with a real input!
Next steps

Implement the HuggingFace conversion scripts
Properly test parity in a variety of situations with the HuggingFace implementation

Before I take next steps, I want to make sure that this implementation looks at least reasonable from Haliax and Levanter best practices, since this is my first time working with either!
Not planning on merging this until I get the full HF loading completed, but since that code all requires the architecture to be static, I'm hoping to get a preliminary review that the Haliax code looks reasonable (most of it is adapted from the GPT-2 implementation, so hopefully it is!)

Alright @dlwh! I think this is ready for a real review (esp if you have suggestions for tests other than the simple check I have here for parity with a model loaded from HF)
Fixed the comments you mentioned before, so LMK if there's anything that seems off!
A few points that I had to touch Levanter code outside of Whisper:

In order to have an optional code block work with checkpointing, I added a check that omits the field from the PyTree if it was None in both the serialized model and the model in memory.
Since the call signature wasn't consistent with the LmModel class, I separated out the required parts for serialization and created a subclass for models that have the same LmModel call signature.

Ok - comments addressed and did one cleanup on an unused config item!

Exciting! Thanks!

@Helw150 oops, can you fix tests in CI? I think it's mostly just missing some imports? (please instlal them in CI or add them as extra or something to pyproject.toml)

Ah - yes. Sorry! Forgot transformers doesn't install the soundfile dependency itself.


Color Picker display

Microsoft PowerToys version
0.51.1
Running as admin

[X] Yes

Area(s) with issue?
ColorPicker
Steps to reproduce
activate color checker (win+shift+c shortcut works fine)  and mouse over screen color
✔ Expected Behavior

To display CIELAB color as natural whole numbers per the color picker drop down choice in settings; see .jpg's
When active, colors list display window is always able to be fully seen; regardless of mouse position on any screen

.
❌ Actual Behavior

Settings are set to display whole numbers; display shows decimal numbers.

If you position cursor at far right edge of any screen (I use 3 display monitors) part of the displayed colors list window is either cut-off on right side, or is overlapping next screen. Overlap is understandable and acceptable; however losing the display info on most farthest right screen makes color checking on far right edge useless. Other 3 monitor screen edges behave correctly. Decimal numbers display also contributes causing a larger width window.

Other Software
n/a

Number 2 is a known limitation, mentioned in #5936
Number 1 - is a question somebody else can answer better than I can :-)

@drms I'm not familiar with CIELAB, but is your first point asking for rounding it to a value without decimals, as shown in Settings?

Other thing: shouldn't the correct notation be L*a*b* (...) ?

Yes, and that would match the drop down choice setting showing no decimals
Or you could provide 2 choices; for those who want decimals and those that don’t.
In any case, the window that shows many results (see below) should also match the CIELAB settings choice of decimal notation, or whole numbers.
Lab color mode is extremely useful for color analysis and adjustment because objects have easily known common color numbers, and color is separated from luminosity for easier adjustments. Additionally Lab matches how our eyes actually see colors; better than the RGB model.
Thanks,
Doug
From: Niels Laute @.>
Sent: Monday, December 6, 2021 10:48 AM
To: microsoft/PowerToys @.>
Cc: drms @.>; Mention @.>
Subject: Re: [microsoft/PowerToys] Color Picker display (Issue #14863)
@drms https://github.com/drms  I'm not familiar with CIELAB, but is your first point asking for rounding it to a value without decimals, as shown in Settings?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/microsoft/PowerToys/issues/14863#issuecomment-986900905 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4EVUJWG2T3QSDPL5V3WSTUPTLKXANCNFSM5JO42VDQ .
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675  or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .   https://github.com/notifications/beacon/AA4EVUI4D44VBWWVBLNO3HDUPTLKXA5CNFSM5JO42VD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHLJOTKI.gif

Maybe officially, as an alternate. But common usage is Lab or LAB  x,x,x
https://en.wikipedia.org/wiki/CIELAB_color_space
Doug
From: Jay @.>
Sent: Monday, December 6, 2021 10:52 AM
To: microsoft/PowerToys @.>
Cc: drms @.>; Mention @.>
Subject: Re: [microsoft/PowerToys] [Color Picker] CIELAB format rounding to whole numbers (Issue #14863)
Other thing: shouldn't the correct notation be Lab* (...) ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/microsoft/PowerToys/issues/14863#issuecomment-986904800 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4EVUPK2KQNEHKML53OAOLUPTL3ZANCNFSM5JO42VDQ .
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675  or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .   https://github.com/notifications/beacon/AA4EVUPL5R6KZSNXA2IEMELUPTL3ZA5CNFSM5JO42VD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHLJPRYA.gif

Right we don't really have the option for heavy customization for something like this.  As they allow decimals, we support it natively.
Due to that, i think this is a larger work item.


Tests | Add tests for SQLServerConnection to improve code coverage

Codecov Report

Merging #1047 into dev will increase coverage by 2.31%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##                dev    #1047      +/-   ##
============================================
+ Coverage     50.62%   52.93%   +2.31%
- Complexity     3057     3141      +84
============================================
  Files           119      119
  Lines         27941    27943       +2
  Branches       4668     4668
============================================
+ Hits          14144    14792     +648
+ Misses        11476    10925     -551
+ Partials       2321     2226      -95

Impacted Files
Coverage Δ
Complexity Δ

...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java
60.9% <ø> (+7.96%)
0 <0> (ø)
:arrow_down:

.../microsoft/sqlserver/jdbc/SQLServerConnection.java
49.77% <0%> (+3.54%)
395 <0> (+31)
:arrow_up:

...m/microsoft/sqlserver/jdbc/SQLServerStatement.java
68.36% <66.66%> (+2.27%)
169 <0> (+9)
:arrow_up:

...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java
38.36% <0%> (-0.44%)
42% <0%> (-1%)

...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java
47.94% <0%> (+0.21%)
112% <0%> (+1%)
:arrow_up:

...oft/sqlserver/jdbc/SQLServerParameterMetaData.java
73.86% <0%> (+0.22%)
103% <0%> (ø)
:arrow_down:

...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java
51.56% <0%> (+0.43%)
255% <0%> (+1%)
:arrow_up:

...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java
36.81% <0%> (+0.46%)
69% <0%> (+1%)
:arrow_up:

...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java
68.7% <0%> (+0.64%)
0% <0%> (ø)
:arrow_down:

.../com/microsoft/sqlserver/jdbc/SQLServerSQLXML.java
12.69% <0%> (+0.79%)
9% <0%> (+1%)
:arrow_up:

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e12d68...e8e3308. Read the comment docs.


Fixes IDNA netloc issue and adds idna_percent_encoded property

This adds the idna_percent_encoded property to get a "safe" version of the URL. In adding this, I discovered that there was a bug with how the IDNA netlocs were being created if there was a port in the URL. This fixes that issue as well.

Codecov Report

Merging #59 (b715e98) into master (becad98) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #59   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           14        14
  Lines          903       908    +5
=========================================
+ Hits           903       908    +5

Impacted Files
Coverage Δ

urlfinderlib/url.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update becad98...b715e98. Read the comment docs.


Fix op-not-defined error while trying to print error message

@ChrisRackauckas can you approve please?


Scan the code base for k8s incompatible usage of host:port

Summary
We previously use host and port pair  or InetSocketAddress to indicate location of the worker. We can not do that in k8s world, we need to use WorkerNetAddress abstraction, which has physical host, containerhost and port
Urgency
Urgent as it breaks some k8s usecases..

@yuzhu Seems like we are not having issue with this any more. I'm closing this on Apr 11 if no other concerns raised.


Add context actions in the viewport

Moves selection-dependent actions in Indications.gd
Simplifies the building blocks of the inspector, like path command editors, in doing so.
Resolves #323
Resolves #338
Fixes #355

Merging this despite a bug with popup positions, since all of the basic logic is in place.


No Typescript support ?

In the favourite languages Typescript is missing!

We get our language identifiers directly from github if you want them to add a language name then you need to ask them.
Typescript is likely identified as JavaScript


Allow customizing the Istio version to use in the e2e tests

Currently, the e2e test suite runs against the latest Istio version. This change allows setting the E2E_ISTIO_VERSION to the version of Istio to be used. If left empty (default) the latest Istio version will still be installed.
It can be used as:
E2E_ISTIO_VERSION=1.21.0 E2E_TEST_OPTS=-v make e2e/istio

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: nacx
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [nacx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: nacx, sergicastro
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [nacx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[Feature Request] Add delete button to model list

At the moment there is only the "Create" button that appears, but could also do with the delete button to delete multiple items from the list, or at least the option to add it.
Cheers

Hi Daniel. Builder doesn't edit or delete PHP files, it's one of the design concepts. Please read the plugin documentation.

Hi @alekseybobkov, I think you misunderstand me, I don't mean to delete PHP files, i mean to delete modal table items. Once you've created your modal, fields.yaml & columns.yaml and hooked up your controller, when you navigate to your plugin page in the backend there is only a create button, but once you created a few items in your plugin database table, there's then no way to delete multiple items other than to go into each one & delete it - hope that makes more sense?

Ah, thanks for updating the title, that explains it better ;)

This feature is already implemented:


False positive for validate when the type is set

A new collection is created using Astro.Class with a field with type 'string' with validator.string().
The field is set to a number and the object validated. The result of the validation is a true because the set method converted the number to a string (because the type was a string).
Was this what was intended for the combination of set and validate?

Yes, Astronomy is always automatically converting types.


Not working  with Material-UI ListItemText elements

Not working with this type of elements:
<Linkify>
  <ListItemText primary={message}  className={class}/>
</Linkify>

Is there any known workaround or alternative?

          <ListItemText
            primary={
              <Linkify>
                Trash https://github.com/tasti/react-linkify/issues/64{" "}
              </Linkify>
            }
          />

Thank you, also I was able to get it working using this format:
<ListItemText>
    <Linkify properties={{target: '_blank'}}>{message}</Linkify>
</ListItemText>


public not accessible to all users

It seems like either new authenticated accounts or perhaps any non-staff accounts don't have access to public in the /user/scenes page.  Discover public scenes is blank and you can't clone scenes.

All public scenes now listed on dev1 from https://github.com/conix-center/arena-account/commit/997911184e338ff91e04a039838c0a6723c76bbc


chore: september 2nd release

Summary by Sourcery
Introduce new components for referral and onboarding features, enhance existing components with improved state management and UI updates, and refactor code for better data handling and validation. Remove unused configurations and update styles for consistency.
New Features:

Introduce a new 'IconReferal' component to the UI icons set.
Add a 'PresaleTokenBalance' component to display token balances in the presale section.
Implement a referral system with a 'ReferralSection' and 'ReferralHomeBanner' to promote user engagement.
Add a new 'OnboardingCarousel' component for user onboarding with a step-by-step guide.
Introduce a 'Carousel' component for creating carousels with navigation controls.

Enhancements:

Refactor the 'PresaleTransactionsCard' to improve state management and update the UI to include transaction status.
Update the 'StepsSection' component to include an optional 'id' prop for better navigation.
Enhance the 'NewHomeHero' component to include a referral banner that appears based on URL parameters.
Improve the 'SessionDialogContent' to include a link for learning more about the Bitcash KYC process.
Refactor the 'savePresaleDepositIntent' function to use an extended schema for better data validation.

Chores:

Remove unused chains from the WagmiProvider configuration.
Update the Tailwind CSS configuration to include new color variants.

 [Bitlauncher] Development Support - Andler, September 2024

 General Management - September '24


Swagger UI is not available

Describe the bug
The URL /api-docs/ shows an empty page.
To Reproduce
Steps to reproduce the behavior:

Go to https://ratingtracker.mruder.dev/api-docs/
Observe empty page

Expected behavior
A Swagger UI documenting the Rating Tracker API is visible.
Screenshots and Logs

Environment (please complete the following information):

Version: 2.1.8
OS: macOS 13.5 (build 22G74)
Browser: Safari Version 16.6 (186<IP_ADDRESS>.2)

Caused by https://github.com/scottie1984/swagger-ui-express/issues/339

Fixed in #371


workflow is longer than maximum allowed size. compressed size 1049974 > maxSize 1048576Tried

Describe the bug
Hi All, I am facing the below error while running a pipeline, this pipeline is 1001k in size. It say the workflow is longer than maximum allowed size. Here is the same issue https://github.com/kubeflow/pipelines/issues/4170  where it say there is a limit of pipeline size? Do we have any fix for this ? cc
time="2023-06-29T17:51:38.732Z"` level=warning msg="Failed to dehydrate: workflow is longer than maximum allowed size. compressed size 1049974 > maxSize 1048576Tried to offload but encountered error: offload node status is not supported" namespace=dev workflow=ml-project-rxqzr
time="2023-06-29T17:51:38.732Z" level=info msg="Updated phase Running -> Error" namespace=dev workflow=ml-project-rxqzr
time="2023-06-29T17:51:38.732Z" level=info msg="Updated message -> workflow is longer than maximum allowed size. compressed size 1049974 > maxSize 1048576Tried to offload but encountered error: offload node status is not supported" namespace=dev workflow=ml-project-rxqzr
time="2023-06-29T17:51:38.732Z" level=info msg="Marking workflow completed" namespace=dev workflow=ml-project-rxqzr
time="2023-06-29T17:51:38.737Z" level=info msg="cleaning up pod" action=deletePod key=dev/ml-project-rxqzr-1340600742-agent/deletePod
time="2023-06-29T17:51:38.985Z" level=warning msg="Error updating workflow: rpc error: code = ResourceExhausted desc = trying to send message larger than max (2430673 vs. 2097152) " namespace=dev workflow=ml-project-rxqzr
Environment

Kubernetes version :- v1.22.17-eks-48e63af
Kubeflow version :- v1.6.1-aws-b1.0.0
KFP Client version :- 1.8.x

Hi @pantlavanya  have you tried the method  to reduce the pipeline size by deleting the component_spec annotation and if the issue still persist?

Could this work?
https://argoproj.github.io/argo-workflows/offloading-large-workflows/#:~:text=Argo stores workflows as Kubernetes,This can be over 1MB.
I did try to enable this in my kubeflow cluster but I am getting some issues with the postgres connection for some reason:
time="2023-09-11T21:33:26.580Z" level=info msg="Persistence configuration enabled" time="2023-09-11T21:33:26.580Z" level=info msg="Creating DB session" time="2023-09-11T21:33:26.590Z" level=info msg="Get secrets 200" time="2023-09-11T21:33:26.594Z" level=info msg="Get secrets 200" time="2023-09-11T21:33:26.607Z" level=fatal msg="Failed to update config: EOF"
But I am curious if this is even a viable option


Updated fmt tarball

I've updated the version of fmt. The older version does not support GCC7 with C++11, but they have fixed the bug upstream.
See: this issue.

Let's wait for all the CI to go green, and then merge this!


Load information about a region on card

Want to load data about region (i.e. description, population, etc)
Max said he would have a table for this alongside variant relational database so check details of that

@Tangerine2001 @benburns20 Is this still relevant? If so, we need to add metadata about regions in the database if you want me to be able to use it. Another solution would be to edit the countries json we use for country search with that kind of info but im not much of a fan because we cant update it in the future without rebuilding the project.

https://restcountries.com/#api-endpoints-v3-all

All the info I found relevant or interesting is on the card. Planning on changing it a little bit aesthetically and functionally but overall is very close to the final iteration. The API supplies more info than this so if we wanted we could have a "Show More" button that just gives the raw json or something but idk; it does not seem that useful.


Add standard name to District, Piece and Civil Parish.

Given that there are no standards on case control and special characters for TNA names and that transcriber input may vary in case there will be occasions when we will not be able to do a match. Hence we propose to add a standard name for the District, Piece and Civil Parish in the same manner as we did for Freecen2 Place and select based on that.

@geoffj-FUG Databases updated with new field Code changed to use the new field and deployed to test3 for testing.

JohnT tested and we deployed.

JohnT tested and we deployed.

Done and dusted!

Done and dusted!


RSS: use full year, instead of 2-digit truncation

This is in the bskyweb golang code. Just need to tweak the stdlib datetime formatting I guess.

Technically, we are following the spec:

All date-times in RSS conform to the Date and Time Specification of RFC 822, with the exception that the year may be expressed with two characters or four characters (four preferred).

We are using the golang standard library time.RFC822Z formatting, which defaults to 2-digit years.


What's the difference between Subscribe and SubscribeReusable in NetPacketProcessor?

Hi, I don't understand the difference between these two; can anyone explain them?

Subscribe calls = new SomeClass(). SubscribeReusable - uses one instance of object without memory allocation.


areas features needed : types of geometries receiving water

I'm wishing objects connected to waterways :

wastewater plants
basins
areas of water

By this way we would be able to figure from upstream to downstream.

I'm not sure exactly what you mean. Can you reword it or explain another way?


Add and update doc links

More or less the same change as ngrok-go#133.
Add the final destination links. I'll run a permalinking script after we've
agreed on the permalinks themselves.

Current dependencies on/for this PR:

main

PR #121   👈

This comment was auto-generated by Graphite.


Scrolling in preview window with the mouse

I am not able to scroll in the preview window. I am using the example configuration provided in the README.
Uncommenting
preview = {
      -- default     = 'bat',           -- override the default previewer?

allows me to scroll the preview window in all :Fzflua files commands. But for all remaining commands (helptags, lines) the preview window is no interactive. Scrolling there scrolls the buffer that you have opened instead.
( BTW Thank you for this plugin. fzf.vim has been my fav plugin for a long time. Wanted to switch to lua but was reluctant to move to telescope. This is the saviour)

The default previewer is a neovim floating window, by uncommenting bat you delegate the preview functionality (and the keybind) to fzf. Maybe there is an issue with neovim’s shift mapping in your case.

Can you restore the default previewer again and try any of the other default mappings?
Does <F4> toggle the preview hidden? Does <F2> toggle full screen? <F5>/<F6>?
While fzf-lua is active with a preview window, press <C-\><C-n> to get into normal mode and run:

:tmap <S-down>, what does the output show?
:lua require'fzf-lua.win'. preview_scroll(1), does this scroll the preview down?

This command
:tmap <S-down>
gave the output
t  <S-Down>    *@<Cmd>lua require('fzf-lua.win').preview_scroll(1)<CR>
And :lua require'fzf-lua.win'. preview_scroll(1) did scroll the preview.
But when I scroll in preview, the buffer behind scrolls

~<F4> is bound to another window manager key~ (Unbounded and working). All other function keys work.
This command
:tmap <S-down>
gave the output
t <S-Down> *@<Cmd>lua require('fzf-lua.win').preview_scroll(1)<CR>
And :lua require'fzf-lua.win'.preview_scroll(1) did scroll the preview.
But when I scroll in preview, the buffer behind scrolls

This is very helpful, so the keybind works but for some reason it scrolls the calling window instead of the preview window.
I’m confused why calling lua require('fzf-lua.win').preview_scroll(1) manually while using the bind has a different behavior given that they call the same function, would you be able to try with a minimal init.lua? This will help us understand if there’s a config issue causing this (another plugin, autocmd, etc).

I tried the minimal lua config.
nvim -u fzf-min.lua
But same problem. THere's a difference tho.
I can now (with minimal vim lua) click in preview window and select things. Previously it would close as soon as I clicked on preview window.
In minimal lua, scrolling actually scrolls the main window instead of preview window even if scrolled in any of those two windows.
In non-minimal it scrolls buffer, acting if preview window is non-existant.

(Its late now maybe look at some day later. Thank you)

Good night :)
Certainly sounds like there is some sort of bug here, what’s your neovim version?
Can you try with the neovim 0.5.1 appimage?

I can now (with minimal vim lua) click in preview window and select things. Previously it would close as soon as I clicked on preview window.

This is probably not fzf-lua related, there are no handlers for mouse at all, I don’t even have mouse enabled in my neovim.

In minimal lua, scrolling actually scrolls the main window instead of preview window even if scrolled in any of those two windows.
In non-minimal it scrolls buffer, acting if preview window is non-existant.

Not sure I understand the difference, by “main” window do you mean the fzf window?
Since you mentioned manually calling :lua require('fzf-lua.win').preview_scroll(1) works there is another thing we can try, the terminal buffer scroll uses the same method but calls it differently (due to neovim terminal limitations), can you try running :new | term and filling it with lines (run ls -la ~ few times or cat <big file>) and then run :FzfLua buffers and see if you can scroll the terminal window?

By main window I meant fzf buffer window.
I didn't get last para. But all others (disabling mouse) scrolls in fzf buffer even when I am scrolling in preview window.
Is the scrolling working for you?
Can I checkout your config

I didn't get last para. But all others (disabling mouse) scrolls in fzf buffer even when I am scrolling in preview window.

Terminal buffer scroll works a bit differently, I wanted you to test with a terminal buffer, you can start one with :term and just fill it with content, then open :FzfLua buffers and see if you can preview scroll the terminal buffer.

Is the scrolling working for you? Can I checkout your config

My config is here but I’m not sure if that would solve it, for me the minimal init.lua you tried before also works (which doesn’t work for you), so this might be the same case again.

Try the latest commit and let me know if the preview scroll works for you?

Terminal buffer scroll works a bit differently, I wanted you to test with a terminal buffer, you can start one with :term and just fill it with content, then open :FzfLua buffers and see if you can preview scroll the terminal buffer.

I tried this but there is no output for this :FzfLua buffers that allows for scrolling.

Did you manage to try with neovim 0.5.1 appimage

I tried it but same issue. One thing I could confirm is that,
  keymap = {

    builtin = {

      ["<S-down>"]    = "preview-page-down",
      ["<S-up>"]      = "preview-page-up",

    },

With these on, I can scroll in the preview window using Shift + (Down/Up) arrow keys

With these on, I can scroll in the preview window using Shift + (Down/Up) arrow keys.

That’s how you’re supposed to use the builtin preview scroll to begin with, what were you doing until now?

Same. Even after updating

I don’t understand, you mentioned you can scroll with <S-down|up>, but now you’re saying it is the same, how are you trying to scroll? With the mouse?

That’s how you’re supposed to use the builtin preview scroll to begin with, what were you doing until now?
I don’t understand, you mentioned you can scroll with <S-down|up>, but now you’re saying it is the same, how are you trying to scroll? With the mouse?

I am sorry for the confusion but I was trying to scroll with the mouse. Not the Shift + arrow keys combo. I was able to use that when using bat as the default previewer so that I thought it would be possible with the built-in previewer as well.

Great timing I was just in the process of writing a reply and your post came in :-)
Reading through this whole thread I now understand we had a miscommunication error and what you meant was "unable to scroll with the mouse",  I just tried enabling the neovim mouse with :set mouse=a and trying to scroll and the behavior is exactly as you mentioned in the OP (and the rest of your replies).
Unfortunately scrolling the preview with the mouse is not supported, I'll have to explore if that's possible with a temp buffer and what will be the implications for the code for such change.

No worries, this is not an essential feature. I created this issue thinking it was bug or an issue with my own config and seek help to fix it. But if it's something difficult to implement or even if its simple but time consuming, I rather not have it. Having this plugin maintained like this is way better than having mouse scrolling. Shift + arrow keys scrolling will soon become intuitive for me.

No worries, this is not an essential feature. I created this issue thinking it was bug or an issue with my own config and seek help to fix it. But if it's something difficult to implement or even if its simple but time consuming, I rather not have it. Having this plugin maintained like this is way better than having mouse scrolling. Shift + arrow keys scrolling will soon become intuitive for me.

Let me explore before closing, might be simple to fix :)

Turns out fixing this wasn't a big deal and for now it seems to not affect anything else in the code, this does come with a few limitations (for now):

The window is scroll-able but not click-able (so you can't select contents with the mouse), fixing this requires the cleanup code to be called from the WinClosed event as opposed to the WinLeave event which does come with some unintended consequences.

Scrolling works but does not update the fzf-lua preview scrollbar, I'm looking into fixing this with the WinScrolled event.

Thank you for the quick fix. I'm sorry some time was wasted due to miscommunication.

I haven't tried this update yet, but there was a simple workaround that my dumb brain couldn't figure out earlier.

  keymap = {
    builtin = {
      ["<ScrollWheelDown>"]    = "preview-page-down",
      ["<ScrollWheelUp>"]      = "preview-page-up",
    },

Thank you for the quick fix. I'm sorry some time was wasted due to miscommunication.

I haven't tried this update yet, but there was a simple workaround that my dumb brain couldn't figure out earlier.

  keymap = {
    builtin = {
      ["<ScrollWheelDown>"]    = "preview-page-down",
      ["<ScrollWheelUp>"]      = "preview-page-up",
    },

I thought about it but I didn't like this solution because this comes at the expense of the main fzf window scroll, with the above mapping you can't use the mouse to scroll the fzf results, it will scroll the preview instead.
Restore these to Shift and try the latest update, I guarantee it will work.

Yes, its working great. Can scroll both fzf window and preview window. Can scroll with shift arrow keys as well. All good. Thank you!!