Search with distinctAttribute returns offset+limit hits

Describe the bug
Search with distinctAttribute and non-zero offset returns offset+limit hits, instead of limit.
To Reproduce
Make an index with distinctAttribute,  without ranking_rules.
Add 40 documents with 20 distinct attribute values.
Empty search request, only limit=10, offset=20.
Expected behavior
10 hits, same as limit
Actual behavioir
30 hits, actually offset+limit
Screenshots
If applicable, add screenshots to help explain your problem.
Meilisearch version:
1.3.5
Additional context
Looks like a bug in bucket_sort.rs - results contains matches max size limit+offset, and there's no drop first offset matches.
https://github.com/meilisearch/meilisearch/blob/bb79bdb3f8e04afdc531ea663b93c47317b118c9/milli/src/search/new/bucket_sort.rs#L48-L65

Hello @mitallast

Make an index with distinctAttribute, without ranking_rules.

Not sure what you mean with this
Can you give more details about the steps you make to describe the issue you have? We need to be able to reproduce it in order to fix it
To simplify it for you, you can maybe give an example with only 10 hits?

I apologize for the long example, I shortened it as much as possible:

create index

POST localhost:7700/indexes
Content-Type: application/json

{
  "uid": "test",
  "primaryKey": "productId"
}

set up distinctAttribute

PATCH localhost:7700/indexes/test/settings
Content-Type: application/json

{
  "distinctAttribute": "shopId"
}

add 10 documents

POST localhost:7700/indexes/test/documents
Content-Type: application/json

[
  {"productId": 1, "shopId": 1},
  {"productId": 2, "shopId": 1},
  {"productId": 3, "shopId": 2},
  {"productId": 4, "shopId": 2},
  {"productId": 5, "shopId": 3},
  {"productId": 6, "shopId": 3},
  {"productId": 7, "shopId": 4},
  {"productId": 8, "shopId": 4},
  {"productId": 9, "shopId": 5},
  {"productId": 10, "shopId": 5}
]

try search first 2 documents, expected 2 hits

GET localhost:7700/indexes/test/search?limit=2

response has 2 hits as expected, same as limit:
HTTP/1.1 200 OK
content-type: application/json

{
  "hits": [
    {"productId": 1, "shopId": 1},
    {"productId": 4, "shopId": 2}
  ],
  "query": "",
  "processingTimeMs": 0,
  "limit": 2,
  "offset": 0,
  "estimatedTotalHits": 8
}

try search next 2 documents with offset 2, expected 2 hits

GET localhost:7700/indexes/test/search?limit=2&offset=2

response has 4 hits instead of 2, like limit+offset=2+2=4, the first two hits match the previous request:
HTTP/1.1 200 OK
content-type: application/json

{
  "hits": [
    {"productId": 1, "shopId": 1},
    {"productId": 4, "shopId": 2},
    {"productId": 5, "shopId": 3},
    {"productId": 7, "shopId": 4}
  ],
  "query": "",
  "processingTimeMs": 0,
  "limit": 2,
  "offset": 2,
  "estimatedTotalHits": 6
}

try search with offset 10, empty response expected:

GET localhost:7700/indexes/test/search?limit=2&offset=10

response has 5 hits, instead of empty result
HTTP/1.1 200 OK
content-type: application/json

{
  "hits": [
    {"productId": 1, "shopId": 1},
    {"productId": 4, "shopId": 2},
    {"productId": 5, "shopId": 3},
    {"productId": 7, "shopId": 4},
    {"productId": 9, "shopId": 5}
  ],
  "query": "",
  "processingTimeMs": 0,
  "limit": 2,
  "offset": 10,
  "estimatedTotalHits": 5
}

Hello @mitallast
Indeed, I succeeded in reproducing the issue with your examples. Thanks for the really clear examples!
I get more hits than required!
I discussed with the developers of the @meilisearch/engine-team  and I come back to you!

More investigation: this bug has been introduced in v1.2.0

same issue in "meilisearch": "^0.35.0",

Hello again people following this issue
The team cannot spend time fixing the bug now, but we are available to review any PR fixing it.
@mitallast you have indeed spotted the part that needs to be changed in the code.
For the contribution, we don't recommend contributing if you have never contributed in Rust, because the code bsae is auite big.
⚠ We need to add tests to ensure this bug will not happen again

Opened PR #4108 to fix this issue. Requesting review.
cc/ @curquiza @Kerollmops

Thank you @vivek-26
@Kerollmops or @ManyTheFish will review it when they have some time! 😊

Hello @bultas
We are supposed to release it tomorrow.
However we have an issue with a PR merging currently. And this PR must absolutely be in v1.4.1
So if we cannot make it tomorrow, it will be beginning of next week (Monday or Tuesday maximum)
If the issue is more complex than we expect, I'll let you know

@curquiza thanks for the quick info

Fixed by #4108
Launching CIs for the release in the coming hour since all PRs for v1.4.1 have been merged! 🎉


Create animals table

project-1- create animals table with the following functionalities implemented

Find all animals whose name ends in "mon".

List the name of all animals born between 2016 and 2019.

List the name of all animals that are neutered and have less than 3 escape attempts.

List the date of birth of all animals named either "Agumon" or "Pikachu".

List name and escape attempts of animals that weigh more than 10.5kg

Find all animals that are neutered.

Find all animals not named Gabumon.

Find all animals with a weight between 10.4kg and 17.3kg (including the animals with the weights that equals precisely 10.4kg or 17.3kg)

Hi @fithamlak,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Highlights

The Pull Request has a proper title and description. ✔
You have added a descriptive Readme file. Good Job. ✔
There is no linter error is present. ✔
Project has met all the technical aspects you needed for this project. Keep rocking! ✔

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

thank you


Vulnerability roundup 92: aerospike-server-<IP_ADDRESS>: 1 advisory [9.8]

search, files

[ ] CVE-2020-13151 CVSSv3=9.8 (nixos-20.03, nixos-unstable)

Scanned versions: nixos-20.03: 925ae0dee63; nixos-unstable: c59ea8b8a0e.
Cc @kalbasit

Needs to bump to <IP_ADDRESS> at a min - but the submodule modules/common appears to be broken past tags/4.2.0.
[red@evil:~/projects/aerospike-server]$ git checkout tags/<IP_ADDRESS>
Previous HEAD position was 537fc25 AER-5908 - fixed single-bin memory leak in UDF cache.
HEAD is now at 6efb5fe AER-5908 - properly handle old bin values during UDF operations.

[red@evil:~/projects/aerospike-server]$ git submodule update

[red@evil:~/projects/aerospike-server]$ git checkout tags/<IP_ADDRESS>
M       modules/common
Previous HEAD position was 6efb5fe AER-5908 - properly handle old bin values during UDF operations.
HEAD is now at dfdfe9e AER-5911 - Fixed race caused by recycling duplicate resolution (destination) fabric message for replica write/ping.

[red@evil:~/projects/aerospike-server]$ git submodule update
fatal: remote error: upload-pack: not our ref 767777a3e3459f6ea9082a479e0adcaa0aa8766b
fatal: the remote end hung up unexpectedly
Fetched in submodule path 'modules/common', but it did not contain 767777a3e3459f6ea9082a479e0adcaa0aa8766b. Direct fetching of that commit failed.

This is how other distro versions sit:
  <IP_ADDRESS>: funtoo_1.4
  <IP_ADDRESS>: aur
  <IP_ADDRESS>: funtoo_1.4
  <IP_ADDRESS>: funtoo_1.4
  <IP_ADDRESS>: funtoo_1.4
  <IP_ADDRESS>: funtoo_1.4
  <IP_ADDRESS>: funtoo_1.4
  <IP_ADDRESS>: liguros_21_1, liguros_20_7, gentoo, funtoo_1.4
  <IP_ADDRESS>: nix_unstable, nix_stable
  <IP_ADDRESS>: wikidata
  9999: liguros_21_1, liguros_20_7, gentoo, funtoo_1.4

@kalbasit  - Can you please take a look at this as the maintainer and let us know how you think it's best to proceed?
Thanks


Add working dotnet integration example

Tested minimal and 3D secure examples pretty extensively and they behave as expected. Omitted item based pricing for now -- only Ruby example seems to support at the moment though. I encountered issues with (a) mapping form field names with dashes and (b) enabling the pre-requisite revenue recognition feature for my test account. Dockerfile works well-enough for a sample app, but could probably use some cleanup if we want to reflect best practices.

👍

👍


Firefox Developer Edition renders page as if it were mobile

I'll start this off by saying I don't think this is actually gatsby-starter-saas-marketing's fault, but I am not familiar enough with gatsby to know where to look.  It would be super helpful if you could point me in the right direction 😺
Repro:

gatsby new gatsby-starter-saas-marketing https://github.com/keegn/gatsby-starter-saas-marketing
cd gatsby-starter-saas-marketing
gatsby develop
Open http://localhost:8000 in Firefox Developer Edition.

Note that the page renders correctly when loaded in Firefox; it only seems to render incorrectly in Firefox Developer Edition.

Expected Result:

Actual Result:

Oh that's interesting. Thanks for mentioning. I'll check it out 👍

@todofixthis I'm running Firefox Developer Edition 77.0beta and it seems to be rendering like it should. This screenshot was taken at 1280px window width.

Hmmm.  Very interesting; thanks for looking into this!  I'll do some more digging; maybe it's related to an extension or similar.  Will report back with my findings.

Weird; I cleared my cache and reloaded, and now it is rendering correctly 🤷🏻♂
Maybe not the most satisfying ending, but a happy one nonetheless 😅  Thanks again for looking into this; it was super helpful to eliminate some variables!


x/tools/internal/lsp/diff/difftest: test is overly sensitive to system language settings

2020-12-03T17:03:53-bdde162/linux-amd64-wsl
2020-12-03T17:00:53-8b44681/linux-amd64-wsl
2020-12-03T16:35:28-2ecf2a5/linux-amd64-wsl
2020-12-02T20:03:35-bef1c47/linux-amd64-wsl
--- FAIL: TestVerifyUnified (0.04s)
    --- FAIL: TestVerifyUnified/replace_no_newline (0.01s)
        difftest_test.go:25: unified:
            "--- from\n+++ to\n@@ -1 +1 @@\n-A\n\\ No newline at end of file\n+B\n\\ No newline at end of file\n"
            diff -u:
            "--- from\n+++ to\n@@ -1 +1 @@\n-A\n\\ 文件尾没有换行符\n+B\n\\ 文件尾没有换行符\n"
    --- FAIL: TestVerifyUnified/add_end (0.00s)
        difftest_test.go:25: unified:
            "--- from\n+++ to\n@@ -1 +1 @@\n-A\n\\ No newline at end of file\n+AB\n\\ No newline at end of file\n"
            diff -u:
            "--- from\n+++ to\n@@ -1 +1 @@\n-A\n\\ 文件尾没有换行符\n+AB\n\\ 文件尾没有换行符\n"
    --- FAIL: TestVerifyUnified/add_newline (0.00s)
        difftest_test.go:25: unified:
            "--- from\n+++ to\n@@ -1 +1 @@\n-A\n\\ No newline at end of file\n+A\n"
            diff -u:
            "--- from\n+++ to\n@@ -1 +1 @@\n-A\n\\ 文件尾没有换行符\n+A\n"
FAIL
FAIL	golang.org/x/tools/internal/lsp/diff/difftest	0.048s

This builder is configured with LANG=zh_CN.UTF-8 (CC @mengzhuo). If difftest wants to compare exact output text, it should probably set and/or unset LANG and the LC_* variables explicitly.

Duplicate of #42962


fix(command): Fix tail order tags

Closes #81

@rafinskipg can we merge this PR or you want to add/test something?

I don't see any changes on this PR, maybe the code was merged already

I don't see any changes on this PR, maybe the code was merged already

Oh, I think it should be dropped. Master already have these changes you made in https://github.com/rafinskipg/git-changelog/commit/06eebc4ddc477842d0e12cf7fb68c5b22814ffbf


View_Root macro does not work properly with FetchStrategy = SELECT

Description

The base query restricts the query root but the VIEW_ROOT macro for the correlation uses an unrestricted query root.
Expected behavior

Actual behavior

Steps to reproduce

Environment

Version:
JPA-Provider:
DBMS:
Application Server:

Could you please give me more details on this? Generally, when a VIEW_ROOT is involved, the following happens when using the SELECT strategy.

Invoke main query and extract correlationBase
Invoke query for correlated entity with a where clause containing the correlation expression and a select item for the correlationBase and another item for the view root id. The results are then matched with the results from the main query by the correlation value and view root id
Go to 2. until all results for all correlation values were fetched

An example model would already help a lot

As far as I can tell, this was fixed by f78bf07


Endpoint: Get Profile

Get Profile
GET /api/profiles/:username
Authentication optional, returns a Profile

Assumptions:
If authenticated, the Profile will have "following" data
If NOT authentication, the Profile will always have "following" as false

Unit/integration tests in, docs in.
BUT
Can't really finish this until "follow/unfollow" is implemented


Unable to login to steamCMD

I entered my login details to start the server manager and it keeps failing. I have logged in manually with the steamCMD and logged in with no issues but it still says invalid password even changed the password.

This can be the case if the password contains some exotic letters.
Try using just a-zA-Z0-9 (when in doubt increase the length of the password to ensure security)
However, I am going to close this, as its really old.
If the issue persists, please open another one.


Allow hints for specific metadata SQLs

This PR has two changes:

Provide a system property to specify hint string to be included in specific metadata SQLs.
Fix a minor bug in extracting load-balance properties from url.

nit: You want to use NESTED for NEST

Done


Add a reproduction case for #2242

Please do not merge. This is for testing purpose for #2242

We have a failures but this is unrelated. I will take a look. Otherwise we can see that we have one less error with the patch from #2242

Failing only on Rails6 (but oddly not on JRuby Rails6).
Still feel free to let me know if it would be helpful if I made a standalone repro app (that passes with the code change, but fails without it, only on Rails6).
This stuff definitely gets tricky, the Rails internals and how rspec tries to mimic them, and how they can differ in slightly different environments.

No no it's ok. I revert your patch to see that test fails.
Everything LGTM.

Closing. I push on 2242.


feat: ID Generators

#6  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tazarov and the rest of your teammates on  Graphite


Feature: go to commands

Add support for go to commands (G and gg)

@danrasmuson can you tell me if this is OK? Thanks.

Thank you for your work on this plugin @brenton-leighton. Multiple cursors are a brilliant feature and similar to you I haven't found what I'm looking for in any other neovim plugin.
The functionality I'm anticipating with these commands is that each cursor will receive the command in the same way as if it was the only cursor. Take this example from sublime when I press CMD + ↓ both cursors go to the last line. Once this happens the cursors merge

Here is a demonstration of what I mean

The functionality in this PR right now is that when I press G one cursor goes to the last line and the other cursor goes to the line before the last. I would expect both cursors to go to the last line and for them to merge into one another so just one cursor remains.

I would expect both cursors to go to the last line and for them to merge into one another so just one cursor remains.

@danrasmuson can you just exit multiple cursors, then execute G? If you want to have this bound to the G command you could add this to custom_key_maps:
{"n", "G", function()
  require("multiple-cursors").normal_escape()
  vim.api.nvim_feedkeys("G", "n", false)
end},

Does that do what you want?

Yes I can. This will work


Add falco-0-31-0.md Chinese file

Add falco-0-31-0.md Chinese file
Signed-off-by: tianying<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: cytianying
Once this PR has been reviewed and has the lgtm label, please assign vjjmiras for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cytianying, vjjmiras
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS [vjjmiras]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 7cf632a447aadfb6b7ec829c10d125106ca64999


Update pyproject.toml

Hey @FredAdiv, can you elaborate on this PR a bit? I'm already listed as an author on line 5: https://github.com/gopherball/gbs/blob/875bff72b4791facd6a99567a9c8051d198162aa/pyproject.toml#L5

Ohh, sorry. Didn't see it.
You can close this PR.
Freddy
On Thu, Apr 27, 2023 at 7:24 PM Simon de Vlieger @.***>
wrote:

Hey @FredAdiv https://github.com/FredAdiv, can you elaborate on this PR
a bit? I'm already listed as an author on line 5:
https://github.com/gopherball/gbs/blob/875bff72b4791facd6a99567a9c8051d198162aa/pyproject.toml#L5
—
Reply to this email directly, view it on GitHub
https://github.com/gopherball/gbs/pull/1#issuecomment-1525993867, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ANGBDLIVPKVVNR4L25S7ICTXDKMTVANCNFSM6AAAAAAXN3LYKI
.
You are receiving this because you were mentioned.Message ID:
@.***>


Resuming games when disconnected

Related to #110 and #352, I have found it useful in other games (Minesweeper Flags Extreme) to be able to continue unfinished games when you get suddenly disconnected.

Would this apply to games that are against two real players, or only to games that are against a real player and an AI?

I believe it should be applicable for both (with possibly a time limit for a player-vs-player game so that the opponent doesn't get bored waiting for the player to return)

speaking of time limits, #34

There could possibly be an agreement system like this:

"Your opponent would like to take a break now. They say they will be available again in: ".

Then, the server might ask:

"Will you be available then?"

Or something along the lines of that.


Test fixes caused by Live Broker PR

Please hold on with the merge, I need to fix the Python3 related issues first.

Changes Unknown when pulling c3f0cd5a1f95bc3a2ae878329406ff2ee4e39041 on tibkiss:test_fixes into ** on zipline-live:live**.

Finally a semi-green build. The failing testcases (test_examples under Python3 @ Travis) are likely related to the ^GSPC -> SPY change. I'm not sure how to fix the missing ibpy2 package under appveyor (and I'm not so motivated to fix the problems for windows platform....)
@bartosh  / @pbharrin  : Could you please review this PR?

Great work! Thank you for fixing this!
Hmm, I should've run python3 tests. Remaining issues look like unicode and python3 specific ones.
Will look at them tomorrow.
We need to fix all failures, including windows ones I believe.

The error appears to be Python 3 reading a pickle that was written in Python 2.
See this post.
This is happening with the different example algorithms: olmar, buyapple, etc.
I think this stems from creating new algo results for the new benchmark SPY.  We should figure out how to create the tests/resources/example_data.tar.gz without creating this issue.

Here is a link to the Pickle library section on data formats perhaps setting this when creating example_data.tar.gz will solve this problem.
https://docs.python.org/3.4/library/pickle.html#data-stream-format

It makes me wonder how is this problem not present in quantopian's zipline?

@bartosh How was this file created?

I think the problem can be solved by running tests/resources/rebuild_example_data from python3. It will use pickle:2 serialization which should work for both python versions.


Confusing Wording with Azure Active Directory Federation Services

Wording... "Azure Active Directory Federation Services" should be "Active Directory Federation Services".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 01f0813b-5ee7-62bc-d427-4b1783a1fa0a
Version Independent ID: 61e41303-0118-1179-fc50-121c54ed4f34
Content: Configure Azure AD SSO for applications
Content Source: articles/active-directory/manage-apps/configure-single-sign-on-non-gallery-applications.md
Service: active-directory
GitHub Login: @barbkess
Microsoft Alias: barbkess

@nickgailloux Thanks for your feedback! We will investigate and update as appropriate.

@nickgailloux The PR for the fix has been created and it will be merged soon. Thanks again for pointing this out, I am closing the issue based on this update, please let us know if there is something else that we can help you with.


Meta: Compile .Net Dependencies

Perhaps you can use http://bridge.net/ to compile the .Net dependencies and libraries.

Not sure there'll be much value for it, as developers using F# will probably have installed .Net or Mono on their machines and the code compiled to JS with Fabel will not have any .Net dependency. Besides that, most of the dev dependencies including the compiler itself are written in F# and Bridge's site only talks about C#. I'm closing the issue but anyway I'd love to see a PR with a proof of concept if you've the time to do it :) Cheers!


Domain Activation Failed

Before opening, please confirm:

[X] I have checked the custom domains troubleshooting guide.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
d2wvgb2x0c7scd
Region
us-west-2
Step
Domain activation
Status
Failed
Issue or question
I have successfully added my domain to a previous amplify app, but I deleted it as I had some issues and deiced to create a new app.
Since I tried to add the same domain to the new app, I cannot longer activate the same domain again. I made sure to check the dns records in GoDaddy but without success. I suspect something went wrong when deleting the old app and dns wasn't deleted correctly.
Will appreciate any help! Thank you!
Error message
Something went wrong. Please refer to our troubleshooting guide below to diagnose the issue. After fixing the issue, choose retry below.
Error message: One or more aliases specified for the distribution includes an incorrectly configured DNS record that points to another CloudFront distribution. You must update the DNS record to correct the problem. For more information, see https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/CNAMEs.html#alternate-domain-names-restrictions
Additional information

I have the same problem, how did you solve that?


UserID is shown when you scroll over the name of a user

Proposal:
Proposal written by Monkeyyy11
Is it a proposal for the website or for the bot?: website
What is the title of your proposal?: UserID is shown when you scroll over the name of a user
Explain your proposal more accurately (It's best to give as much information as possible, so that we can implement the proposal better): If you scroll over the name of a user on his profile page, you see his userid: https://i.imgur.com/z66TGbd.png
Why should we add this feature?: If someone asks him his userid, he can see it like this or if a user wants to know if it's a fake account or not
ReportID: 162

➤ LenoxBot commented:
Approve:
good idea!
Denarioyt#3352

➤ LenoxBot commented:
Approve:
good idea
Wandi#9576

➤ LenoxBot commented:
Approve:
agree with wandi
Dadi#7808


Data framing in TCP at the socket level and not at the application level.

:+1:   https://stackoverflow.com/questions/73237486/creating-tcp-connection-and-getting-the-header
Protocols like http detect the framing of your data through the stream, and create the framing at the application level, Netly's function is to provide the socket and optionally contains the framing at the application level since version 3, much more I think netly it should be smart enough to create frames through the headers received by the sender. And that:
Relying on TCP headers to create a "frame" rather than creating a frame based on the data received.
Advantage of application-level framing?

Easy to maintain.
Disadvantage of application-level framing?
Private protocol (When creating your framing, you use its resources to customize it so that it works perfectly in applications with the same protocol. The problem is when you are trying to communicate with libraries that have not been customized to use your framing protocol )
Private in the bubble/Non-resilient (creating a protocol is easy, but it can be difficult to create clients and servers to keep them working with other clients)
Overhead (you are adding more data than you actually need to receive)

Advantage of framing at socket level?

Resilient (if you can put framing at the socket level, it means all applications communicate without dependency and overhead)

No overhead (This is by sending both and receiving data the libraries do not need to send extra data in the message body to handle framing at the application level.

What am I trying to say with framing?
TCP has a very low data limit and if you want to send 1 megabyte you cannot send it linearly, that is, you need to divide this data and send it in small pieces and the framing function both at the application level and at the socket level is to detect and accumulate the data until it reaches 1 megabytes and only then release it to the receiving target. in case of download, it can be a file on the disk to write to the buffer each time it receives a fragment of data.
Netly by default will use the memory as a buffer, this works well if the data to be received is small, i.e. less than ~10 megabytes, and in case of receiving Gigabytes, Netly will need to use the gigabytes in RAM, and that's where the danger lies. and problem. Netly currently has framing at the application level and has a limit of 8 megabytes that it allows to receive and this can be customized up to as much GB, TB, etc. as you want. The next update to fix this should be to allow netly to write the buffer to disk in a temporary folder and then pass the file path instead of data in a parameter. This can be customized, for example from 10MB. In any case, this is a danger that resides in the framing of any layer,
But being realistic, most users don't even use 1MB, they use it to browse messages and small data and will rarely send large files. In any case, netly being able to deal with framing at the socket level brings compatibility without overhead and with data resilience.

:sob:  It's not possible to read package header, it mean we must implement message framing in application layer like now.
https://stackoverflow.com/questions/73237486/creating-tcp-connection-and-getting-the-header
https://stackoverflow.com/questions/11034870/how-do-you-get-raw-tcp-packet-in-c


ResourceNotFound: ndt_localize in build from master

Fill-out only one section depending on whether you are reporting a bug or a new feature.
Bug
ndt_localizer fails to load when trying to run the sample_moriyama. Build process works fine and finishes building everything.
Expected Behavior
localization should work when running the sample.
Actual Behavior
Cannot find the resource..ResourceNotFound: ndt_localize
Steps to Reproduce the Problem
From a build from git master

Run sample simulation
Pick my_map.launch and set
Pick my_localization.launch and set

Console logs the error messages.
ResourceNotFound: ndt_localize
source_path_to_packages=source_path_to_packages)
File "/opt/ros/kinetic/lib/python2.7/dist-packages/roslaunch/substitution_args.py", line 197, in _find_executable
full_path = _get_executable_path(rp.get_path(args[0]), path)
File "/usr/lib/python2.7/dist-packages/rospkg/rospack.py", line 203, in get_path
raise ResourceNotFound(name, ros_paths=self._ros_paths)
ResourceNotFound: ndt_localizer
ROS path [0]=/opt/ros/kinetic/share/ros
ROS path [1]=/home/castleguard/Autoware/ros/src
ROS path [2]=/home/castleguard/projects/gym-gazebo/gym_gazebo/envs/installation/catkin_ws/src
ROS path [3]=/opt/ros/kinetic/share
Specifications

Ubuntu version: 16.04
ROS version: kinetic
Autoware branch: master

Another ResourceNotFound error when trying to load my_sensing.launch from the sample. This is from a fresh build off the head, with all submodules checked out. The build itself goes flawless, runtime has issues.
raise ResourceNotFound(name, ros_paths=self._ros_paths)
ResourceNotFound: pointgrey

Package names have been changed in release 1.7 but it seems like the demo launch files have not been updated.
You can fix this by editing my_localization.launch and replace ndt_localizer with lidar_localizer and remove the line below it which uses the use_openmp argument.

Yes, it is now called autoware_pointgrey_drivers.

Thanks, that gets a bit further. However, looks like grasshopper has been renamed as well?
ERROR: cannot launch node of type [autoware_pointgrey_drivers/grasshopper3_camera]: can't locate node [grasshopper3_camera] in package [autoware_pointgrey_drivers]

It's been renamed to grasshopper3.launch

hmm, there are references in cmake files to grasshopper3_camera and ladybug_camera.. so this one seems a bit more involved.

Oh, sorry my bad, the name hasn't changed. It is still grasshopper3_camera and ladybug_camera. Have you recompiled since pulling the latest source?

Yes, a couple of times. Ended up changing cmake files and seeing if that works. Based on your comment, it seems like that's the wrong track to take.

No luck with that as expected.

The issue turned out to be that the grasshopper3 node wasn't being built due to missing dependencies. Had to get the flycapture SDK among other sub dependencies.
It seems excessive to need this for running the sample..

The issue turned out to be that the grasshopper3 node wasn't being built due to missing dependencies. Had to get the flycapture SDK among other sub dependencies.

Is that dependency not defined in package.xml anywhere? If it is, the ResourceNotFound error may or may not be because of a few bugs in rospkg I've been reporting (e.g. https://github.com/ros-infrastructure/rospkg/issues/142 and/or https://github.com/ros-infrastructure/rospkg/issues/131).

How about this issue ? The same problem occurs in my environment.


Article on appydroid.tk

Hey there!
I wrote a small article about Toffeed on appydroid.
Link

Cool, thanks!


fix(diagnostic): text is nil

#1290

@cseickel Isn't this handled by this function? https://github.com/nvim-neo-tree/neo-tree.nvim/blob/396ff81e6bb384b0ef12ae427346cbf97d08f808/lua/neo-tree/sources/common/components.lua#L116C4-L116C4

@cseickel Isn't this handled by this function? https://github.com/nvim-neo-tree/neo-tree.nvim/blob/396ff81e6bb384b0ef12ae427346cbf97d08f808/lua/neo-tree/sources/common/components.lua#L116C4-L116C4

Yes, it looks like it is. Sorry I didn't remember about that as I was reading the changes.


Bugfix/fix config saving bug

Hey,
Thanks for the contribution.. Can you explain a bit more about what's happening here? Ideally adding a description?


text sticker not showing after hit done button

Hi , using latest update , when I use text sticker and user hit done button I found it gets empty box without text and sometimes it shows part of the text ,
but when I sent background to text and remove the background again , it fully shows
" pls not this only happen when I type arabic , and English is working "
screen shot
note : I was set red circle to show u the empty text box

If your iPhone region is Arabic, you can set ZLImageEditorUIConfiguration.default().languageType = .system, otherwise set ZLImageEditorUIConfiguration.default().languageType = .arabic to avoid this problem!
But when your iPhone region is non-Arabic, there will be a bug if you input Arabic, this issue will be fixed later!

If your iPhone region is Arabic, you can set ZLImageEditorUIConfiguration.default().languageType = .system, otherwise set ZLImageEditorUIConfiguration.default().languageType = .arabic to avoid this problem.
But when your iPhone region is non-Arabic, there will be a bug if you input Arabic, this issue will be fixed later.

@longitachi ok I'm waiting your fix as soon as possible ,
I want to ask u how to change default font to custom font in text sticker , I was trying to add font to Xcode main project and in plist file also and in your pod as private var font = UIFont(name: "IBMPlexSansArabic", size: 18) ?? UIFont.systemFont(ofSize: 18)
in ZLInputTextViewController file , but seems not reading it

Use fontChooserContainerView. You should provide a view that confirmed the protocol of ZLTextFontChooserDelegate. You can refer to the implementation of FontChooserContainerView in the demo.
ZLImageEditorConfiguration.default().fontChooserContainerView(FontChooserContainerView())

Use fontChooserContainerView. You should provide a view that confirmed the protocol of ZLTextFontChooserDelegate. You can refer to the implementation of FontChooserContainerView in the demo.
ZLImageEditorConfiguration.default().fontChooserContainerView(FontChooserContainerView())

thanks for your respond , but I use this package as pod in my flutter app project , so I have only source files swift code without full example app so I can't open the ZLImageEditior full project In Xcode .
can u help me to where I can edit the text sticker vars to include my custom front


Add code to creat a Docker image based on Debian

Please have a look at the individual commit messages for the details.

This change is

Documentation will be added later.


[stable/grafana] Add tolerations, nodeselector and affinity to the te…

…st pod
Signed-off-by: Ben Corlett<EMAIL_ADDRESS>

/ok-to-test
/lgtm

@ rtluckie @maorfr
Should we force merging the code that fixes the test code?

/retest


[Feature Request]: increment sample numbers

Contact Details
No response
Is your feature request related to a problem?
Probably not trivial, and probably the goal should not be to rebuild all Excel.
But it might help to be able to just enter e.g. the name of a first sample "Sample 1" and incrementally fill down the column (Sample 2, Sample 3, ...).
Describe the solution you would like!
Just offer two options

if last character of cell value is a numeric, add +1 (Sample 4, Sample 5, Sample 6, ...)
if last character is not numeric, add numeric to next cell and increment as above (Sample xy, Sample xy 1, Sample xy 2, ...)

Additional context!
No response
Host
Applies to All
Host Details
any


Can't run the program

When I try to run the program, it gives me the following error in the line 84 of "track_generator.py":
vor.filtered_regions = np.array(vor.regions)[vor.point_region[:vor.npoints//5]]
ValueError: setting an array element with a sequence. The requested array has an inhomogeneous shape after 1 dimensions. The detected shape was (301,) + inhomogeneous part.

I can't figure out how to solve the problem as I haven't changed the code

This should have been fixed now. Please install the specific package versions according to the requirements.txt


FilterQuery ignored for DbSet.Find

I set up a FilterQuery for a DbSet<Person> for when the person.DeletedEventId is not null to ignore people that have been deleted.
It works as expected when I use context.People.FirstOrDefault(p => p.PersonId == personId) but when I use context.People.Find(personId) it returns the entity.
Is this by design?
Steps to reproduce
[Fact]
public async Task WillNotFindEntitiesWithDeletedEventId()
{
    using (var context = InMemoryDb.CreateDbContext())
    {
        //arrange
        var deletedEvent = new Event();
        await context.Events.AddAsync(deletedEvent);
        var entity = new Person
        {
            DeletedEventId = deletedEvent.EventId
        };

        await context.People.AddAsync(entity);
        await context.SaveChangesAsync();

        //act
        // var actual = context.People.FirstOrDefault(p => p.PersonId == entity.PersonId);
        var actual = context.People.Find(entity.PersonId);

        //assert
        Assert.Null(actual);
    }
}

public class MyDbContext : IdentityDbContext<MyUser>
{
    public MyDbContext(DbContextOptions<MyDbContext> options)
        : base(options)
    {

    }

    protected override void OnModelCreating(ModelBuilder builder)
    {
        base.OnModelCreating(builder);

        FilterOutEntitiesWithDeletedEventId(builder);
    }

    private void FilterOutEntitiesWithDeletedEventId(ModelBuilder builder)
    {
        foreach (var e in builder.Model.GetEntityTypes().Where(e => typeof(IEventEntity).IsAssignableFrom(e.ClrType)))
        {
            var entityParameter = Expression.Parameter(e.ClrType, "e");
            var deletedEventIdProperty = Expression.Property(entityParameter, nameof(IEventEntity.DeletedEventId));

            var filter = Expression.Lambda(
                Expression.Equal(
                    deletedEventIdProperty,
                    Expression.Constant(null, deletedEventIdProperty.Type)),
                entityParameter);

            builder.Entity(e.ClrType).HasQueryFilter(filter);
        }

        public DbSet<Person> People { get; set; }
    }
}

public class Person : IEventEntity
{
    [Key]
    public int PersonId { get; set; }

    public int? DeletedEventId { get; set; }

    public virtual Event DeletedEvent { get; set; }
}

public interface IEventEntity
{
    int? DeletedEventId { get; set; }
}

static class InMemoryDb
{
    public static MyDbContext CreateDbContext() => new MyDbContext(
        new DbContextOptionsBuilder<MyDbContext>()
        .UseInMemoryDatabase(databaseName: Guid.NewGuid().ToString())
        .Options);
}

Further technical details
EF Core version: 2.0
Database Provider: InMemoryDatabase
Operating system: Windows
IDE: VS Code

@EdwinSaenz Thanks for filing this issue. We had discussed this in the past and also re-assessed today and we are going to keep the current behavior. It's certainly not an easy choice, but it stems from this:

Query filters only apply to queries against the database. Once an entity is tracked by the state manager it is always accessible regardless of what filters are being used. There are several reasons for this, one of which is preserving filter semantics when they are applied in memory as opposed to in SQL.
Find sometimes runs a query, but only if the entity was not found in the state manager. This means that if a query filter is applied, then the behavior of Find can be confusing--sometimes it will return an entity, sometimes it won't depending on whether that entity has been cached in the state manager or not.

If it is important that a query filter be used to find an entity by ID, then running a FirstOrDefault query will ensure that the query is always run on the server and hence the always has consistent filter semantics.


Update goreleaser.yml

Config scheme is changing, you can check goreleaser/goreleaser#81 for more details.

Awesome thanks Carlos 👍


Update Partitioner with new imports

I found the imports don't work anymore for shapeless 2.2.5.

Thanks, @coltfred—I'll get this merged and updated as soon as possible.

Thanks, @coltfred! I've just finally merged this and updated the site.


Added space after prefix symbol for Windows platform

Since space exists in prefixes for non Windows platform.
Also modified the symbol for pending from . to - to keep it consistent with non windows platform symbol

Coverage remained the same at 55.682% when pulling 02c7083915a09ef8e0e80c7e199801dea763d0ed on souvikbasu:master into 881d19f71e9d7444577332b778eed201a6b72934 on mlex:master.

Coverage remained the same at 55.682% when pulling d20a0b3a44fd2c6ce10a83e2c9e509bb39f8e835 on souvikbasu:master into 881d19f71e9d7444577332b778eed201a6b72934 on mlex:master.

This is fine, but I will need to include the fix into another PR #57
So, I will likely just pull your changes into #57 instead of merging this.


HELP readthedocs nightmare!

I have no idea why but it seems like readthedocs is stuck reading from an old commit. It won't update the additional pages. Seems to update index ok. I'm using MKDocs which is supposed to make life simple. If I start a server locally it all looks ok :(

@TomTranter maybe try creating a webhook to automatically update the docs with every push in the repository.

I've no idea why but it seems fixed now. Latest and main are the same


[Enhancement] Move io coalesce input stream below cache input stream

What type of PR is this：

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

The reason why to put logic of io coalesce under cache input stream is because, io coalesce will amplify IO size which will affect block cache finally.
For example, right now it's like  [IOCoalesceStream] -> [CacheInputStream]

if we wants to read [10, 20], [30, 40]
IOCoalesceStream will merge them into [10,40]
CacheInputStream will cache [10,40]
which is unecessary, because we don't need to cache [20,30]

So if we work like this  [CacheInputStream] -> [IOCoalesceStream],  cache size won't be affect by io coalesce.

However the downside of this is that we can not use following API any more
    virtual Status get_bytes(const uint8_t** buffer, size_t offset, size_t* nbytes, bool peek) = 0;

So there will be an extra memcpy.
UPDATED:  since I've implemented zero copy read bytes, times of extra memcpy is less

if data is from block cache, because block cache memory is segmented, we have to use memcpy to gather them into a single piece
but if data is from shared buffer stream, we can use shared buffer directly without copy.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

run starrocks_be_unittest

run starrocks_be_unittest

run starrocks_clang-format

run starrocks_fe_unittest

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test


The default user password cannot log in

Did you run migrate and loaddata command?

use docker compose

The user can query in the database

We added installation script and updated documentation try to install from scratch

ok


Document the philosophy/difference around Props and Options

Component in question:
// e.g., "AB-52 Button"
Metronome documentation for component
Screenshot of component in your project:
Description of issue:

This app uses the options object to pass data internally, which is a thing that Crystal just came up with.  So I should write this down.

Description of desired behavior:
Overrides (if any) you've added to solve the problem:
.example-project {}

from Slack:
-Types is the most distinct and straightforward.  They’re enums (https://github.com/NYPL/nypl-design-system/blob/development/src/react-components/src/components/Hero/HeroTypes.tsx) and should be used when there are large categories of a component.  They should be passed in by the consumer, which means they should be exported in index.ts https://github.com/NYPL/nypl-design-system/blob/development/src/react-components/src/index.ts#L18
-Props are the props that should be passed to the component itself.  It represents the state of the data on construction.  For example,
https://github.com/NYPL/nypl-design-system/blob/development/src/react-components/src/components/HelperErrorText/HelperErrorText.tsx#L15
When a HelperErrorText object is created, it must have an id and isError.
Notice that HelperErrorTextProps  is not exported.
-Options are the -Props object in exportable form.  It is a holding place for the -Props object before HelperErrorText is constructed.  Notice that here, everything is optional.
-Options objects have identical to -Props objects, with the addition of the content?: JSX.Element field.  That is because, when the component is created, the content should be passed as a child.
For an example of the benefits that the -Options object can have, see DateRangeForm.stories.tsx
https://github.com/NYPL/nypl-design-system/blob/16d57cdc7345926e184db4f0441283dc6948a803/src/react-components/src/components/DateRangeForm/DateRangeForm.stories.tsx#L14
This DateRangeForm has a fromHelper and a toHelper .  What is passed into those props is of type HelperErrorTextOptions
Without this, we would have to pass
fromHelperContent=
fromHelperId=
fromHelperIsError=
toHelperContent=
toHelperId=
toHelperIsError=
(and so on)


pass arbitrary arguments to #authorize

this facilitates the usecase where an query method would want to conditionally authorize based on the content of the request parameters

So this PR has been open for a long time, and activity here has died down a bit. This is probably the most requested feature for Pundit, and so I realize that this will be a bit of an unpopular move, but I have decided to close this PR without merging it.
Here are my reasons for doing this:

Currently using policies is straightforward and obvious. The query method dictates what we are asking, and the object dictates what we are asking from. In the cases where multiple objects are involved in whether a particular action should be allowed, they should be wrapped up in something, for example by utilizing the form object pattern. This is good practice anyway, and Pundit is all about encouraging good practice.

Adding parameters to the query methods makes them harder to use in views, adding parameters to the policy constructor makes the caching situation of policies (introduced after this PR iirc) much more non-obvious.

The usecase that @lanej has described, which I think is valid, is much less relevant given the establishment of the permitted_attributes pattern. I have an upcoming PR which expands this functionality and should solve @lanej's usecase in a much more elegant way.

The context pattern established in the README since this PR solves a lot of what people want to use this kind of pattern for, and it's a much better, much more convenient solution. We use this very successfully in a multi-tenant app, and it works very nicely. If we would have to pass in the tenant everywhere, a lot of the convenience of Pundit would be lost.

This is a feature which is very, very easily abused, and by Murphy's law will be abused. The original intent behind Pundit was establishing a simple good-practice pattern for authorization, we should not be encouraging bad patterns.

I want to clarify that I have thought about this a lot. Please respect that this is my final decision on the matter.

Proper explanation. Thanks for the time @jnicklas


"Directives" should be indented

The purpose of this pull request
The purpose of this pull request is to fix typo in documentation.

Coverage increased (+0.05%) to 71.584% when pulling c0e989a5fb1f9c5ea37491b55b2dd89d2edcc9a3 on serii833:patch-1 into edc8a43b9b6ca5209a0bcf23e852c02a08c548a9 on trivago:master.


[FEATURE] Add support for GPT-4o model from Azure OpenAI

Describe the feature you'd like
I would like Flowise to support the new GPT-4o model available on Azure OpenAI. This feature would allow users to integrate and utilize the capabilities of the GPT-4o model within the Flowise platform.
Additional context
The GPT-4o model has been recently released on Azure OpenAI, and it offers advanced capabilities that can enhance the functionalities provided by Flowise. Integrating this model would require updating the relevant code sections to support API calls to Azure OpenAI for the GPT-4o model. Detailed documentation and examples from Azure OpenAI can be referenced to facilitate this integration.

https://github.com/FlowiseAI/Flowise/pull/2402
I think it's already supported

#2402 I think it's already supported

Not yet for Azure OpenAI.

It appears that the support for GPT-4o in FlowiseAI is due to the upstream update in the langchainjs repository. The issue langchain-ai/langchainjs#5346 discusses the addition of GPT-4o support, and it seems to have been resolved with a new version update. This upstream change likely enabled the GPT-4o support in FlowiseAI.


Release tags?

Are there any plans to publish a stable release? I'd like to provide antigen as a Debian package so people can easily install it and a release or a tag would make packaging a lot easier.

Any chances that we will see a new release tag? There have been quite a few additions since v1.

I think the best time for a v2 tag would be when #129 is complete, as it is a lot of code changes and will be a large update to antigen.


Fix failing tests

Changes

Dropped support for Node.js 8
Fixed lint with latest XO
Fixed AVA usages
Removed AppVeyor and Travis CI configuration files
Started using GitHub Actions

For the latest AVA, we should use t.throwsAsync for writing tests.
I'm fixing these failing tests. I will push my fixes to this pull request in these days.

Codecov Report

Merging #138 into master will decrease coverage by 17.25%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           master     #138       +/-   ##
===========================================
- Coverage   96.31%   79.05%   -17.26%
===========================================
  Files           7        7
  Lines         190      191        +1
===========================================
- Hits          183      151       -32
- Misses          7       40       +33

Impacted Files
Coverage Δ

lib/task.js
85.71% <ø> (-14.29%)
:arrow_down:

lib/task-wrapper.js
38.09% <0%> (-51.91%)
:arrow_down:

lib/listr-error.js
33.33% <0%> (-66.67%)
:arrow_down:

lib/state.js
33.33% <0%> (-44.45%)
:arrow_down:

index.js
92.72% <0%> (-7.28%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fb0c38...f8b7b90. Read the comment docs.

This pull request failed on a Node.js branch. Should I remove these Node.js 6 envs from .travis-ci.yml and appveyor.yml?

@SamVerschueren I have no idea why this CI failed. I don't have a Windows machine for reproducing this.

Looking good @LitoMore  :-)

:+1: for merging this. It would the other folks allow to rebase this change.

Oh sorry, I dismissed this PR. Let me remove the console.log code.

@SamVerschueren Code updated. Please review :)

We should also change the build badges in the readme.md

@SamVerschueren Updated.

@LitoMore Any idea why the action doesn't trigger? Is it because it's not yet present on the master branch?

Is it because it's not yet present on the master branch?

Yes.

@SamVerschueren AppVeyor still there. You can deactivate this project on your AppVeyor dashboard.

I removed it just now :)

@SamVerschueren By the way, I can help maintain this repo. Now we can close some related issues and pull requests.

Definitely could use some help triaging and fixing issues. Would be wonderful! Didn't I already added you to the repo? I'll check later, if not, I'll add you.

Didn't I already added you to the repo?

No, I'm not the collaborator yet. Thank you :)


How to configure project-specific settings?

I want to set different texlab.build.args for different projects. Can we override its value in the *.sublime-project file? Or how can we do this?
Thanks!

https://lsp.sublimetext.io/guides/client_configuration/#per-project-overrides


Add area-coords attribute

I've implemented setting coordinates on the scope using an 'area-coords' attribute as I described in https://github.com/alexk111/ngImgCrop/issues/4

Please, can we get this merged? :)

Same here. Merging this would enable us to enjoy ngImgCrop even more ;)!

For those interested, I've forked the repo to add the expected feature at https://github.com/Javarome/ngImgCrop
See demo at http://codepen.io/Javarome/pen/RPLZvd

Any chance to see it merged?

Could be, but it looks that this project is not managed anymore.

So annoying when a decently sized project gets abandoned and the owner does not give anyone ownership of the repo.


No module named combobox

When I launch labelImg.py . Result :
File "labelImg.py", line 29, in
from combobox import ComboBox
ModuleNotFoundError: No module named 'combobox'

OS : Windows
PyQt version: 5

Thanks

I tested with the recent version of python (3.8.5) but it doesn't work. So I installed the 3.4.5 version which is older and it's ok.


Video 50807 - NameError: name 'static_cache' is not defined

When attempting to run the project in the video, an error is reported.
I was pretty careful to make sure I have all the same files and their content to align with what's in the video, but I must have missed a critical piece.
Traceback (most recent call last):
File "/Users/stevepiercy/projects/entre/env/lib/python3.5/site-packages/pyramid_debugtoolbar/toolbar.py", line 215, in toolbar_tween
response = _handler(request)
File "/Users/stevepiercy/projects/entre/env/lib/python3.5/site-packages/pyramid_debugtoolbar/panels/performance.py", line 57, in resource_timer_handler
result = handler(request)
File "/Users/stevepiercy/projects/entre/env/lib/python3.5/site-packages/pyramid/tweens.py", line 62, in excview_tween
reraise(*attrs['exc_info'])
File "/Users/stevepiercy/projects/entre/env/lib/python3.5/site-packages/pyramid/compat.py", line 148, in reraise
raise value
File "/Users/stevepiercy/projects/entre/env/lib/python3.5/site-packages/pyramid/tweens.py", line 22, in excview_tween
response = handler(request)
File "/Users/stevepiercy/projects/entre/env/lib/python3.5/site-packages/pyramid/router.py", line 155, in handle_request
view_name
File "/Users/stevepiercy/projects/entre/env/lib/python3.5/site-packages/pyramid/view.py", line 612, in _call_view
response = view_callable(context, request)
File "/Users/stevepiercy/projects/entre/env/lib/python3.5/site-packages/pyramid/viewderivers.py", line 438, in rendered_view
result = view(context, request)
File "/Users/stevepiercy/projects/entre/env/lib/python3.5/site-packages/pyramid/viewderivers.py", line 123, in _class_requestonly_view
response = getattr(inst, attr)()
File "/Users/stevepiercy/projects/entre/blue_yellow_app/blue_yellow_app/controllers/home_controller.py", line 11, in index
'build_cache_id': static_cache.build_cache_id
NameError: name 'static_cache' is not defined

check your import statements on home_controller.py - it should include
import blue_yellow_app.infrastructure.static_cache as static_cache

At this point in the course, I gave up on following along. There were files missing here and there. Eventually I just pulled all the files from the repo for this chapter, stopped typing along, and watched the videos. This could have been better, for example, by breaking this chapter's directory into subdirectories for each video in the chapter. We do something like that for all the official Pyramid tutorials, except we substitute written narrative for videos.
Chapter/Tutorial: https://github.com/Pylons/pyramid/tree/master/docs/quick_tutorial
Source code for the Authentication step: https://github.com/Pylons/pyramid/tree/master/docs/quick_tutorial/authentication

Thanks for the feedback Steve. Sorry you got stuck.
I think the challenge might be you imagine chapter N to be "here's where I start for chapter N". What it is actually meant to be is the final result of that chapter, not the beginning.
I'll go back through and see if there are reasons it won't run. Each chapter should be exactly as it was at the end of that chapter's videos. It ran when I checked it in, so it would maybe be due to a missing github add for a file? We'll see.

Hi Steve,
I'm happy to look at your code and see what's missing with the static_cache file. But I just cloned this repo into a totally clean environment and ran every chapter without an error. I also tested the cache busting stuff and it seemed to work from what I had in github.
My best guess is that you missed a step. But I can't think where it is right now... Please post a link to a zipped project or something and I'll have a look.

I got that the directory was the end result. We do the same thing with Pyramid tutorial docs: at the end of each step within a chapter, this is what your code should look like. We often tell users to diff their code against the directory to find mistakes.
Instead of a chapter/repo directory level (macro), I wanted to follow along at each video/step level (micro) within the chapter. There were some points where I blinked, missed something, and had to replay the video several times to find my error or omission. And a couple of times, I couldn't find my mistake, so I filed issues in the GitHub tracker.
I ended up just copying all the files over for the whole chapter. That worked, and I'm not disputing this point. But then I became a passive viewer of the video, instead of actively typing along.
Ultimately I suggest a structure like this:
4-applied-web/...name of step where code changes
4-applied-web/Dark navbars and overriding bootstrap
4-applied-web/...
4-applied-web/From theme to Blue/Yellow
4-applied-web/...

Thanks for your consideration.

Hey Steve,
Sure that makes sense. I could have considered that more realistically had I done it along the way. I already have people asking why there are so many folders and versions. It's a tough balance to strike. But I appreciate the value of following along for sure.
Best,
Michael


isEmail fails to exclude Chinese characters

Step to reproduce:
<EMAIL_ADDRESS>It returns true, instead of false.
Please help to fix this issue:  to exclude Chinese characters

Set the allow_utf8_local_part option to false.
<EMAIL_ADDRESS>{ allow_utf8_local_part: false }); // false

I see. Thanks.


Add child scope to permission directive.

Reopened PR. References #163

@masterspambot Do you mean in my fork? I reopened the PR against Nazerus:development. I may be misunderstanding what you are asking.


More granular oath scopes

It is great that you folks have publicly documented the API, it would be good if sooner rather than later (as apps further uptake it) you could enhance the granularity of the oath scopes.   I have a hard time not imagining there are plenty of applications that do not need to remotely start the car, or unlock it, or add another key, or access the live camera.  Right now the vehicle_cmds is all or nothing posing quite a security issue if you need any of those commands you need to give access to all.   Similarly vehicle_device_data which various analytic tools use require giving access to real time location as well, which again is not needed for different applications.
It may also be worthwhile to document the official protobuf protocol rather than requiring to reverse it from the go code.    You announced the public API documentation and EOL'ed it in the same step.  It is a minor detail but for those not looking to run a secondary app to convert all commands to the new standard (as even new apps in not-go would need to do this by default) would make things easier.

Worth noting: for intelligent EV charging like https://evcc.io, really only the wakeup and start/stop charging commands are needed. Maybe create groups of commands for specific use cases?


Empty dir /var/lib/awx/public/static/

Frontend is not working due to empty /var/lib/awx/public/static/ in container awx_web.
Temporary (and ugly) workaround is entering the container and set a symlink:
docker exec -ti awxcontainer_awx_web_1 bash
cd /var/lib/awx/public
rm -rf static
ln -s /usr/lib/python2.7/site-packages/awx/ui/static

Anyway, thanks heaps for your work, Jeff! 🏆

Ah, that could be why I seem to sometimes get errors with JS and CSS not loading as mentioned in https://github.com/geerlingguy/awx-container/issues/7 ...
Though it does work for me if I use the docker-compose.yml file as it currently exists :/

Well, what do you know... switching to user: root in docker-compose.yml (in #7) and then running the above commands makes it so the UI works and playbooks work.
Hmm, now how to best capture the changes above (at least for the short term!)?

Maybe I'll just add a web_setup role that does:
---
- name: Remove existing static assets folder.
  file:
    path: /var/lib/awx/public/
    state: absent

- name: Symlink awx UI folder into place.
  file:
    path: /var/lib/awx/public/static
    src: /usr/lib/python2.7/site-packages/awx/ui/static
    state: link

Going to test this now, hopefully I can get it working today!

So, not 100% sure what I did to fix things... but I think they might be fixed. Going to push a new container up in a minute once I do one more test run.
I didn't have to run the web_setup role as shown above, to get everything working, nor did I manually run the other commands to remove and symlink the UI directory.

Seems to be working with the latest set of images I pushed, still have to wait 5-10 min for the database migration to be completed.

It works, but  ONLY in a up-down-up way over here.
After stopping and restarting the whole Docker-train I see lots of copy-actions upon the 2nd start:
awx_web_1    | Copying '/usr/lib/python2.7/site-packages/awx/ui/static/ ...
and the frontpage shows the evil potato.

It did trick for me: In case of upgrade
yum reinstall -y python2-*
yum remove -y python2-paramiko*
yum install -y python2-paramiko*
rerun setup


Kia Seltos 2021

Checklist

[x] added to README
[x] test route added to test_car_models
[ ] route with openpilot:
[ ] route with stock system:

Nice work. All the tests are passing with your test route. Looks good to merge after adding CAR.KIA_SELTOS to the IGNORED_FINGERPRINTS list in values.py.

Nice work. All the tests are passing with your test route. Looks good to merge after adding CAR.KIA_SELTOS to the IGNORED_FINGERPRINTS list in values.py.

Added that

@speedking456 What harness type do you use with your vehicle?


button "stop" or "restart

Type: Bug
when i use jupyter, the button "stop" or "restart is not working
VS Code version: Code 1.81.1 (6c3e3dba23e8fadc360aed75ce363ba185c49794, 2023-08-09T22:22:42.175Z)
OS version: Windows_NT x64 10.0.22621
Modes:

/extJupyter

It looks like this is caused by the Jupyter extension. Please file the issue to the Jupyter extension repository. Make sure to check their issue reporting template and provide them relevant information such as the extension version you're using. See also our issue reporting guidelines for more information.
Happy Coding!


New version with 404 to 400 fix

When will the new version be released with 404 to 400 fix made below?
https://github.com/swagger-api/swagger-node-express/commit/ba486f0b6c0938f39d906a8892e4e58e1497c1cb

+1

This is handled in #209


No bitrate adaptation with recent Shaka Player v2.0.0-beta2 and manifests from Wowza

One of the recent commits, sometime between Shaka Player v2.0.0-beta and Shaka Player v2.0.0-beta2, seems to have disabled bitrate adaptation with manifests provided by Wowza. Should be reproducible with http://w01.quickmedia.tv/mbr/x/manbeast/manbeast.smil/manifest.mpd .
With enabled logging by using the 'vv' URL parameter, the console log in Chrome keeps repeating "Still within switch interval..." and no bitrate adaptation takes place. On the other hand, default multi bitrate content such as "Car" properly reports in console debug log
Calling switch_()... bandwidth=9571 kbps
switch_
switch: Stream (audio:8) already active
switch: switching to Stream (video:1)
and the player switches to higher video bitrate.
Multi bitrate content from Wowza used to work fine until Shaka Player v2.0.0-beta, still can be confirmed when using http://v1-6-5.shaka-player-demo.appspot.com/

Actually, after some further testing, this appears to be caused by bandwidth estimation.
If I have ample bandwith available and the chunks are delivered very quickly, the bitrate adaption event is not even triggered and the playback is stuck on the first video track with the lowest quality. However, if I saturate my download speed to the max with some bandwidth-hungry connection like downloading a big file, bitrate adaptation suddenly starts working.
That is also possibly why the bitrate adaptation works for me with default content from Shaka demo as the delivery is a bit slower due to geographical distance to my location, but the connection between our local Wowza server and me is fast and this leads to some likely faulty bandwidth estimation. This also means that my manifest example will not likely exhibit the same behavior, say, in the US, and it might not be reproducible there.
Still, this needs to be influenced by a recent commit, as older Shaka versions behave properly in this regard.

Can you try reverting a commit for me locally to see what happens?  I'm suspicious of 60d2944.

Yes, that was exactly it. After I reverted the commit, bitrate adaptation started to work from our server as usual. Good call, Joey.

Okay, then I'll go ahead and revert that commit and reopen the bug it was supposed to fix.  Thanks for testing!


ARM64 Support for Android

Hi,
is it planned to support ARM64 for android in the future? Or is it already possible, i did not see it...

not in the near future. but the code is 64bit-safe. you can just compile it for arm64 if you want. but you won't get arm assembly optimizations.

Really? Is it that easy? What do i have to change to make it working?
would be great!

Hello,
Actually this isn't quite correct. Our ASM optimizations work only on 32-bit CPUs. Somebody recently contacted me directly about ARM64v8 support and we came to the conclusion that we'd need updated ASM code for 64-bit support.

Update on this question, I got arm64 NEON optimizations working on iOS and MacOS (arm64) using code from this repo:
https://github.com/linnaea/theora/tree/master
This user rewrote arm specific code using llvm intrinsics, which are usable on both 32 and 64 bit archs. I suspect I'll have success porting to android as well. Hope it helps!


Research Mozzila i18n support

Not sure how this could be useful yet, need to research https://hacks.mozilla.org/2014/12/introducing-the-javascript-internationalization-api/

You might want to consider looking at https://github.com/yahoo/ember-intl and https://github.com/andyearnshaw/Intl.js/ as well.


Add google analytics

I inspected the results of a mkdocs build and the expected js is in each page. Overriding review requirement


Submit SWE-bench results to the official leaderboard?

Describe your question
Curious if there are plans to submit the SWE-bench results to the official leaderboard; and/or if there is a reason why they haven't been yet.
Additional context

https://github.com/swe-bench/experiments#leaderboard-participation

Leaderboard Participation
If you are interested in submitting your model to the SWE-bench Leaderboard, please do the following...

https://x.com/xingyaow_/status/1787862432888545665

OpenDevin CodeAct 1.0 - achieves a 21% unassisted resolve rate on SWE-Bench Lite

https://x.com/gneubig/status/1791498953709752405

OpenDevin CodeAct 1.3 agent with browsing and github support. With GPT-4o, 25% accuracy on SWE-Bench Lite

https://x.com/_devalias/status/1795994610746998934

My tweet asking about submitting the results

https://github.com/swe-bench/experiments/pull/7

aider recently added their results

Tangentially related:

https://github.com/OpenDevin/OpenDevin/issues/2072
https://github.com/OpenDevin/OpenDevin/issues/1693
https://github.com/OpenDevin/OpenDevin/issues/1289

The recent experiments had some problems - they used the hint column from the benchmark, which the original SWE-Agent team claimed they didn't use. Removal of that column as part of prompt dropped the benchmark score, but the community is still running benchmarks. Stay tuned.

@0xdevalias if that answered your question, please consider closing the issue :)

please consider closing the issue

@mamoodi I mean.. technically it does answer it, but there is also no current resolution to it, so I would tend to leave an issue open until it's been resolved; which in this case, would be when the results are fixed up/re-run and submitted.
If you have differing opinions as repo maintainers, close it if you need to.

Hey @0xdevalias , also for additional context, we're working on a paper with a deadline next Wednesday, we'll probably submit to the leaderboard after that!

@neubig Awesome, appreciate the update! :)

THis is finished thanks to @li-boxuan

THis is finished thanks to @li-boxuan

Submission PR for continuity:

https://github.com/swe-bench/experiments/pull/44


fix: update @smoya/multi-parser to v5.0.8

This PR will update @smoya/multi-parser dependency to the latest version.
cc @smoya

:tada: This PR is included in version 2.4.8 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


CCDB GE/025 - Section <IP_ADDRESS>.3

Para 200
Comment:
Why do you make a link to a zip-file here and not in the other abstracts? In addition, the link is not marked as a link and only in text style. How will it be made sure that it can be downloaded in future?
Proposal:
Please remain consistent.
Priority: 1

duplicate of #61
v1.1

Closed by #353


feat: new hook useMap

What new hook does?
Tracks the state of a Map.
Checklist

[x] Have you read contribution guideline?
[x] Does the code have comments in hard-to-understand areas?
[x] Is there an existing issue for this PR?

#33

[x] Have the files been linted and formatted?
[x] Have the docs been updated?
[x] Have the tests been added to cover new hook?
[x] Have you run the tests locally to confirm they pass?

:tada: This PR is included in version 3.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

I don't understand why this has a mutable object api in contrast to useList which returns the operations distinct to the list. This makes the library inconsistent?

Сopying a map of 1k numbers is two orders of magnitude slower than copying same size array (like it is slow af).
There is no way of giving an access to a map without making it mutable, Map method mutates its source and there is nothing to do with it.

Understood. I wonder if it would be better to return the proxied apis in the way list does, although then risk of people mutating the map directly without the proxied versions unless they are removed from the returned map. All quite difficult trade offs so I understand your decision now.

Understood. I wonder if it would be better to return the proxied apis in the way list does, although then risk of people mutating the map directly without the proxied versions unless they are removed from the returned map. All quite difficult trade offs so I understand your decision now.


[DOC] Install instructions omit starting opensearch

What do you want to do?

[ x ] Request a change to existing documentation
[ x ] Report a technical problem with the documentation

Under Option 2, between steps 3 & 4 there should be a step to start opensearch.
(https://opensearch.org/docs/latest/install-and-configure/install-opensearch/tar/)

@peterzhuamazon - can ypu provide some info for this? I'm not sure what to add. Himanshu said the path might be wrong, too: should be  /opensearch in that location. Thanks.

@hdhalter
Step2 of this: https://github.com/opensearch-project/documentation-website/blob/main/_install-and-configure/install-opensearch/tar.md#option-1-test-your-opensearch-settings-with-security-enabled
Should change Run the demo security script. to Run OpenSearch Startup script with security demo configuration.


[bug] Display two identical data when creating a resource

Setup

Rancher version:  v2.6.3
Browser type & version:

Describe the bug

After creating a resource, the list page displays two identical messages.  （The list is displayed normally after refreshing the page）

To Reproduce

Result
Expected Result

Screenshots

Additional context

Detailed Description

Context

@WuJun2016 It looks like this is associated with https://github.com/harvester/harvester/issues/1111 / https://github.com/rancher/dashboard/pull/4783. Is there a clear and reproducible way to get the situation (without changing devtool settings)?

No stable way to reproduce.

Without a repro, we can't do much. Will close for now but if there's a way to do this in the future, feel free to reopen.


Add issue and PR templates

What this PR does / why we need it:
Add issue and PR templates for GitHub
Release note:

None

/cc @akrejcir
/cc @ksimon1

/lgtm

/approve


O(n) instead of O(n^2) for TableRenderer.CreateNextBottomBorderPosition()

If you think there is a bug in MigraDoc then please use the IssueSubmissionTemplate to make the issue replicable.
http://www.pdfsharp.net/wiki/IssueSubmissions.ashx
Thanks.
Resources
The official project web site:
http://pdfsharp.net/
The official peer-to-peer support forum:
http://forum.pdfsharp.net/
Reporting an Issue Here
Expected Behavior
Actual Behavior
Steps to Reproduce the Behavior
We strongly recommend using the IssueSubmissionTemplate to make sure we can replicate the issue.
http://www.pdfsharp.net/wiki/IssueSubmissions.ashx

Hello!
Where can I find the code for this?


inlining of async functions into other async functions.

VM currently does not inline async functions. Users (see e.g. https://github.com/dart-lang/sdk/issues/40522#issuecomment-584549535) expect compiler to be able to turn this
@pragma('vm:prefer-inline')
@pragma('dart2js:tryInline')
Future<int> functionToBeInlined() async {
  var result = await someFuture();
  return result + 5;
}

void main() async {
  print(await functionToBeInlined());
}

into this
void main() async {
  var result = await someFuture();
  print(result + 5);
}

However this does not work in either VM or dart2js.
I have checked with @lrhn and he says that this transformation is considered legal from the language perspective, so we should consider implementing it - it might be quite beneficial for the code with considerable amounts of async.

/cc @mkustermann

Are there currently any plans to implement this functionality?

@jayjah not at the moment. any specific reason you are interested in this particular optimization (e.g. do you happen to have a (macro) benchmark that benefits from this sort of inlining?).

@mraleph Thanks for your response! No not really, actually I wondered about the fact that non-async functions could be inlined and async functions not.
I thought about the usage of this optimization in my dart-projects, but that would require extra testing/benchmark testing. Moreover because only non-async function can be properly inlined I am not sure to invest my time in this optimization.

No not really, actually I wondered about the fact that non-async functions could be inlined and async functions not.

@jayjah It is more complicated for async functions, because async functions start synchronously but return asynchronously (e.g. in await foo() the foo() function will start synchronously but has to return asynchronously (i.e. after yielding back to a microtask queue / event loop)). If there's something else in the queue it has to be executed before the await foo() returns.
Preserving this semantics makes this more challenging than the simple inlining we do of synchronous code.


Compiler messages are hard to find in editor hover when documentation is also shown

If multiple diagnostics apply to a cursor position for which a hover tooltip is shown, documentation appears before compiler messages. Not sure how other types of diagnostics (if there are) would mingle in.
To reproduce, hover on a function reference that is also part of a compile error as shown in the screenshot.

The compiler message is buried at the end of the contents of the editor hover. Is this a known issue that I couldn't find, or would you agree to try to change the order to: compiler messages first, then documentation?
If so, I would volunteer to investigate how to change the order - unless someone who is reading this already knows.

Duplicate of https://github.com/rust-analyzer/rust-analyzer/issues/6070


daskhub didn't enable scratchBuckets by default, now silently ignored faulty config has been removed

In #1045 I removed this section.
https://github.com/2i2c-org/infrastructure/blob/689db10eee7ac806aa95d0a927953900b98b10fe/helm-charts/daskhub/values.yaml#L1-L6
It wasn't functional and instead silently ignored. It should be located under basehub.jupyterhub.custom.cloudResources.scratchBucket.enabled to be functional and not ignored.
In #1045 I opted to not change any behavior but instead remove the misconfiguration that was silently ignored and open this issue to raise awareness about the situation: daskhub won't create a scratch bucket by default etc, and you must enable this for each hub that wants it.
I lean towards thinking that any custom resources that one may want, should be explicit configuration for a cluster's hubs rather than default configuration. If there is agreement about that, there may be no action point at all but to close this issue.

Creating the scratch bucket is something the config connector should be able to do (on GKE), but I never got it to work. We should scope another project, similar to the CI/CD one, that refactors/overhauls our terraform infra to make it consistent.

@sgibson91 do you want to create an issue to start writing down a list of things that we can shape into a broader project?

I will put it on my to-do list and get to it when I can

sounds good - I don't think there's a strong hurry there, just want to make sure that we don't forget about it.
For this issue, it then sounds like we can close it simply by documenting in infrastructure/ that scratch buckets must be created first before the hub can be configured to use them. Is that right? It seems like these docs are where we describe the setup process so maybe we can refine those a bit?

Creating the scratch bucket is something the config connector should be able to do (on GKE), but I never got it to work https://github.com/2i2c-org/infrastructure/issues/669

I would bet this is the underlying issue!

For this issue, it then sounds like we can close it simply by documenting in infrastructure/ that scratch buckets must be created first before the hub can be configured to use them. Is that right?

IIUC, we are currently creating that bucket with terraform, ie: https://github.com/2i2c-org/infrastructure/blob/master/terraform/gcp/projects/pangeo-hubs.tfvars#L16-L18
@sgibson91 might know better if there is any other place where this is actually already documented.

@sgibson91 might know better if there is any other place where this is actually already documented.

I'm not sure there is any documentation yet. I caught this in the LEAP config though. https://github.com/2i2c-org/infrastructure/pull/1074#discussion_r826767521

https://github.com/2i2c-org/infrastructure/pull/1130 is relevant

We need to basically rip out the config-connector stuff completely, as we've moved all scratch bucket stuff to terraform. Unassigning myself as I'm not currently working on it.

The tasks to do is:

Make sure the cloudResources config is removed from config for:

[ ] pangeo-hubs
[ ] dask-staging
[ ] ohw
[ ] catalyst-cooperative

Remove set of resources from our config, under helm-charts/
Remove custom code we have in our values.yaml to support this
Remove terraform code that supported setting up config-connector


Add example for JetBrains Exposed library

In this example, some users and orders are made, after which they're retrieved in various ways.
Closes #17.

Merged, thanks Jasper!


Skeleton for cluster provider reconcilers

Description of changes:

Skeleton for vsphere cluster reconciler
Skeleton for docker cluster reconciler

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm


[Feature Request]: Having a vertical header

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Instead of a horizontal header, will create a vertical header
Use Case
it looks good and space for the content to be added in the body
Benefits
No response
Add ScreenShots

This type of header i'm saying.
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@Trisha-tech ?


Fix Docker Requirement initializer type

What are you trying to accomplish?
The signature takes a splatted argument, but it's been typed as a String. I'm updating this so that it is compatible with current uses of Docker Requirement in the service 👇
TypeError:Parameter 'requirements': Expected type String, got type Array with value [">= 2.0.20230809182251.a", "< 2.0.20230809182252"]
Caller: /home/dependabot/.local/share/gem/ruby/gems/sorbet-runtime-0.5.11430/lib/types/private/methods/call_validation.rb:133
Definition: /home/dependabot/.local/share/gem/ruby/gems/dependabot-docker-0.261.0/lib/dependabot/docker/requirement.rb:31 (Dependabot::Docker::Requirement#initialize)

Anything you want to highlight for special attention from reviewers?
No, but I do see that Requirement.requirement_string accepts a T.nilable(String) and immediately uses T.must(requirement_string). This does not seem to be intentional, but is outside the scope of what I need to do here.
How will you know you've accomplished your goal?
Sorbet compilation is successful.
Checklist

[x] I have run the complete test suite to ensure all tests and linters pass.
[x] I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
[x] I have written clear and descriptive commit messages.
[x] I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
[ ] I have ensured that the code is well-documented and easy to understand.

Could we add a test that shows how this is used in the real world?


Add Lamp Time and Software Version

Great JVC integration!  Do you think it's possible to add read commands for Lamp Time and SW Version so they can be exposed as sensors in HA?  I peeked through the JVC docs and it seems they are available:

http://pro.jvc.com/pro/attributes/PRESENT/manual/2018_ILA-FPJ_Ext_Command_List_v1.2.pdf

Sure I can add that

I was adding some other commands and came across this issue, went ahead and put up a PR for these ones while I was in there.


[feat]: Watch Viral Doodstream Intake Videos - Latest from Indonesia 2024

Feature description

Watch Viral Doodstream Intake Videos - Latest from Indonesia 2024
Welcome to the hub of Viral Doodstream Intake Videos 2024! Watch the best and trending viral Doodstream videos from Indonesia. We bring you the most popular and newest viral intake videos on Doodstream, the top streaming platform for exciting content.
Are you looking for the latest viral intake? Discover the most talked-about viral Doodstream videos across Indonesian social media. Our collection of viral intake from Indonesia offers top entertainment and the freshest trends.
Visit japanmovie.my.id to catch the hottest viral Doodstream intake videos from Indonesia. Don’t miss out on our full range of viral content, from the funniest clips to the most entertaining videos trending in Indonesia.
Watch Viral Doodstream Intake Videos on japanmovie.my.id

Affected component/components
No response
Additional Context
Additional details here...
Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues and PRs

FG

vf

FG

vf

FG

vf

cxvxcv


added remark about eventually missing double-quote

Tried out the tutorial an run into the mentioned error. Adding the double-quotation marks solved the issue.

Hi @mlvandijk, I have committed the double quoted example and removed the remark block again.
I feel uncertain about the string {{% version "cucumberarchetype" %}}. What happens to it, if you copy and paste the example?

Hi @frank-at-work,
Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾
In return for this generous offer we hope you will:

✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
ℹ Don't feel obliged to help, just do what you can if you have the time and the energy.
🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber


AVRO-1887 Integrate Yetus

All,
First PR that will kick off the tests using Apache Yetus. It is a crude implementation since it will only kick off the ./build.sh, but this will be refined later on.
The C++ and the interop tests are failing and are therefore disabled for now.
cc @kojiromike
Cheers, Fokko

Thanks for the review @kojiromike
Enabling shellcheck is easy by adding it in the list of plugins: https://github.com/Fokko/avro/blob/fd-fix-tests/.travis.yml#L34
There is also support for hadolint etc.

@kojiromike @cutting PTAL.
I know there are a crazy amount of changes. Instead of having fixed paths, I updated all the tests to use TemporaryDirectories using junit. Also, I've rewritten a lot of the file operations using try-with-resource. A lot of the streams weren't closed at all.

@kojiromike My suggestion would be to merge this first, and then you can freely rework the shell scripts. You're much better at it than me :-)

@Fokko Congratulations/Thanks for getting this merged. I'll take a look at those shell scripts. Am I correct that now we can rely on automated checks to validate a lot of our PRs? Is there a way to trigger the tests on all the open PRs?

@kojiromike with pleasure. They need to rebase onto master, then Travis will run automatically. I'm going through a couple of the PR's that are still open.

FWIW, very specific support for Travis (and other CI systems) is something that will hopefully be coming to Yetus soon.   I've got it in a fork already: https://github.com/aw-was-here/buretoolbox/commit/f055aa3c78ffdd9bf42e11b457b1283bc3582960


Columns added to sys.dm_os_memory_objects DMV in SQL Server 2016 release are not labelled as such

The columns partition_type, contention_factor, waiting_tasks_count, and exclusive_access_count in the sys.dm_os_memory_objects DMV were added in the SQL Server 2016 release (see the Bob SQL post SQL 2016 - It Just Runs Faster: Dynamic Memory Object (CMemThread) Partitioning for details).
The columns' descriptions don't indicate that, so end users may be confused when they try to find them on versions of SQL Server older than 2016. An "Applies to: SQL Server 2016 (13.x) and later." label should be applied to those columns' descriptions to reflect this correctly.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1115cb11-99d6-a4b9-80d5-9b50b090351e
Version Independent ID: 4590c1d7-b55d-4d3e-473a-ba92a2a14b15
Content: sys.dm_os_memory_objects (Transact-SQL) - SQL Server
Content Source: docs/relational-databases/system-dynamic-management-views/sys-dm-os-memory-objects-transact-sql.md
Product: sql
Technology: system-objects
GitHub Login: @CarlRabeler
Microsoft Alias: carlrab

Thank you for your feedback.  I have updated the documentation and it should be live by tomorrow.


fix: Adjust autocomplete results ranking for function arguments

Description

Leverage function arguments type generated in #28214 to better rank autocomplete results for function arguments.

PR fixes following issue(s)
Fixes #28107

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

[ ] Manual
[ ] JUnit
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test

/build-deploy-preview

/ok-to-test

/build-deploy-preview skip-tests=true

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test

/build-deploy-preview

/ok-to-test

/build-deploy-preview skip-tests=true

/ok-to-test

/ok-to-test


Allow accesslint to comment without personal access token on public repos

We'd like to use accesslint on various public repos at 18F, but we're not able to provide an access token due to our restrictive GitHub permissions policy. Can we allow accesslint to comment without personal access token?
@ckundo Is there any progress on this issue and standing up a standalone service to post comments on public repos?

Hi Maya! Thank you for the note, that's super exciting. @tysongach and I are talking about streamlining setup today in fact, and will post notes. We're pretty far along with a standalone service, and will post that too.

@maya Woo!! Our goal is to make it as easy as Hound is to setup, with a very similar workflow to do so.

Hi @maya, we've release v0.2.4, which allows accesslint-bot to comment through the accesslint.com API, instead of commenting as a project collaborator directly.
This new version requires OAuth at https://accesslint.com, and that you set the resulting accessint API token as an environment variable in CircleCI. See the readme for the env variables you'll need:
machine:
  environment:
    CIRCLE_TOKEN: <CircleCI API token>
    ACCESSLINT_TOKEN: <API token from https://accesslint.com>
    ACCESSLINT_GITHUB_USER: <GitHub user that authenticated at https://accesslint.com>

You can also add these variables directly to the CI environment via CircleCI project settings at https://circleci.com/gh///edit#env-vars.
Comment or let us know in accesslint.slack.com if you have questions!

@ckundo Fantastic! We're so looking forward to getting to try this out on our projects! 🎉

@ckundo @maya I just tried to implement this here and ran into this log:
No existing logs for comparison.
'about:blank | moderate | Documents must have <title> element to aid in navigation | ["html"]'
'about:blank | serious | <html> element must have a valid lang attribute | ["html"]'

Will it always do this because I am starting a new server, or is it going to compare these errors to previous errors that exist within on that account with that ACCESSLINT_API_TOKEN?

@gemfarmer please check out issue #37: the comparison happens against the last successful master build. Also, those errors suggest the server hasn't started yet. I'll follow up soon with our next steps for comparing logs. Thanks!

Hi @gemfarmer, I'm able to get legitimate errors when chaining jekyll server with accesslint-ci as demonstrated at https://github.com/accesslint/18f.gsa.gov/pull/1/files#diff-29944324a3cbf9f4bd0162dfe3975d88R21. I'm going to close this issue an move the conversation to #39.

@ckundo Regarding your previous comment: your example CircleCI config has ACCESSLINT_TOKEN, but I was seeing an error saying that ACCESSLINT_API_TOKEN could not be found, so I think there may have been a typo? I believe it should be:
machine:
  environment:
    CIRCLE_TOKEN: <CircleCI API token>
-     ACCESSLINT_TOKEN: <API token from https://accesslint.com>
+     ACCESSLINT_API_TOKEN: <API token from https://accesslint.com>
      ACCESSLINT_GITHUB_USER: <GitHub user that authenticated at https://accesslint.com>


xADUser: Add ProxyAddresses Property

Pull Request (PR) description
This PR adds the ProxyAddresses property to the 'xADUser' resource.
The ProxyAddresses AD Property is an Array type, the same as ServicePrincipalNames. Therefore rather than add specific additional code to handle ProxyAddresses, the ServicePrincipalNames code was generalised so that it could be reused for other array type properties.
At the same time, the following logic changes were made to the code, so that string and string array properties could be processed with the same code, and correctly handle setting values to empty strings:

Use Compare-Object instead of the standard -ne comparison operator.
Use the Clear parameter rather than the Remove parameter of Set-ADUser.

This Pull Request (PR) fixes the following issues

Fixes #254
Fixes #375

Task list

[x] Added an entry under the Unreleased section in the CHANGELOG.md.
Entry should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in resource directory README.md.
[x] Resource parameter descriptions added/updated in schema.mof
and comment-based help.
[ ] Comment-based help added/updated.
[x] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[x] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[x] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Codecov Report

Merging #379 into dev will decrease coverage by <1%.
The diff coverage is 92%.

@@         Coverage Diff         @@
##            dev   #379   +/-   ##
===================================
- Coverage    92%    92%   -1%
===================================
  Files        20     20
  Lines      2512   2505    -7
  Branches     10     10
===================================
- Hits       2313   2305    -8
- Misses      189    190    +1
  Partials     10     10

@X-Guardian My bad, I hit the LGTM button by mistake 😕 There are review comments on this one that need to be resolved. 😃 I will start to enforce style more now when we are getting closer and closer to getting this "HQRM".

No problem, I'll go through the review this evening.


chore(golangci-lint): Update default version to v1.51.0 (ARCH-121)

Follow our detailed thought process here: https://typeform.slack.com/archives/C2C0NBBJS/p1675255536771549
TL;DR:
The default linter and go versions are (very) outdated; teams have moved up their go version once they could, and they should continue to have that freedom, which is why we do not want to touch the linter workflow's go version right now. The old default linter version does not work well with new go versions (see https://github.com/golangci/golangci-lint-action/issues/545), so we want to update the golangci-lint default to its newest version. With this change, we are betting (a hedged bet, since I made a couple of tests) that golangci-lint is fully backwards-compatible.
In the unexpected case (I did some tests) that this would break workflows of other teams, we'll rollback and recommend to override both versions (or none).

Might as well just update to v1.51.0 (same statements re: tests mentioned above)
Thanks @xespona !


block references and block range references no longer work since 9.0

Description
Since the update to Dendron 0.9.0 & 0.9.1 I no longer can include block references or block range references, as soon as I am trying to supply the header or a header range it stops rendering and only displays the reference text instead of the note content.
Steps to reproduce the behavior:

Create note daily.tasks.md (contains headings Tasks and Backlog)

Create note daily.journal.2020.09.01.md

Try to reference ((ref:[[daily.tasks]]#Tasks))

Works
((ref:[[daily.tasks]]))
No longer works
((ref:[[daily.tasks]]#Tasks))
((ref:[[daily.tasks]]#Tasks:#Backlog))
Screenshot

Desktop
Windows 10 - 1809;
Visual Studio Code
Version: 1.48.2 (user setup)
Commit: a0479759d6e9ea56afa657e454193f72aef85bd0
Date: 2020-08-25T10:13:11.295Z (1 wk ago)
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.17763

Took a look. this is currently a bug in how we parse headings
if the heading you want happens to also be the first heading in the file, Dendron will return the link. You can fix this temporarily by adding a dummy header ahead of Tasks. meanwhile, will push a fix that should be out later this week!

this should be fixed in markdown-preview-enhanced 0.9.2. will put this ticket into pending for user confirmation

Thanks @kevinslin awesome work, can't wait to try it :)


only display positions if at least one trade has occured in that market

Coverage increased (+0.008%) to 69.449% when pulling 1bf00115fe5e76c46d764c904c6da90864dc172b on 662-pos-change into 57075f2b05a007ec444d4662b2346bf9380ab917 on master.

Coverage increased (+0.008%) to 69.449% when pulling 1bf00115fe5e76c46d764c904c6da90864dc172b on 662-pos-change into 57075f2b05a007ec444d4662b2346bf9380ab917 on master.