Replacing label with a list of Label elements in Format.

According to ISO/IEC 23009-1 [4], clause <IP_ADDRESS> Table 13, an AdaptationSet could include several Label elements (0..N), not only one. But right now Exoplayer only fetches the first Label and ignores the rest.
This PR fetches all the Labels and stores them in Format.labels that is a List of labels instead of only one label String. Also, instead of just storing a String, it creates the class Label that stores the three possible fields that can be related to the Label: id, lang and the value of the Label.
When a "label" field is included in the AdaptationSet, it will be added to the list as a Label without id or lang only when there are not actual Label elements. It will be ignored otherwise.

Hi @jekopena,
Thank you for this high-quality PR, your input is very appreciated.
Without delving much further into it, the immediate problem I see is that this looks like a breaking change. We tend to deprecate methods/fields first and remove them after a couple of releases to give people a chance to migrate. And Format is a very widely used class. In your case, I assume you'd want to deprecate setLabel(String s) and forward the call to setLabels(immutableList.of(s))

Good point, let me keep label as deprecated and add labels.

Could you describe in a bit more detail what you are trying to achieve? As @oceanjules noted above, this is quite a drastic change given how widely used this Format object is, so it's worth considering if and why this is really needed. As far as I can tell the 'label` field is already fully custom and could contain any String without following a specific contract. So, assuming you have to parse the output anyway based on your knowledge of what you expect, would it work to concatenate all labels together as a comma-separated string?

@oceanjules I have updated the PR to keep label and mark it as deprecated and also adding labels. label is doing the same:  store the adaptationSet label or the last  element if there are any. And labels is a list that only keeps the list of  elements with their corresponding id, lang and value. This shouldn't be a breaking change anymore.
@tonihei concatenating all labels in the current label field wouldn't work because that would break what current users are expecting from label, that is to only contain the adaptationSet label or the last of the  elements.
What I'm trying to achieve is that a track with Director's commentary in English, for example, should contain a list of Labels with a description of the content in different languages. For example:
<AdaptationSet ... lang="en">
  ...
  Director's commentary
  Kommentar des Regisseurs
  Comentarios del Director
  ...
</AdaptationSet>

So the client can show a track description in the track selector depending on the language used by the client. If the client is using English, it can describe the track as "Director's commentary", or "Comentarios del Director" if it's using Spanish.

What I'm trying to achieve is that a track with Director's commentary in English, for example, should contain a list of Labels with a description of the content in different languages. For example:
<AdaptationSet ... lang="en">
  ...
  Director's commentary
  Kommentar des Regisseurs
  Comentarios del Director
  ...
</AdaptationSet>

So the client can show a track description in the track selector depending on the language used by the client. If the client is using English, it can describe the track as "Director's commentary", or "Comentarios del Director" if it's using Spanish.

If you're only adding a List<String> to the Format, how will consumers of this field access the lang part of your example?

What I'm trying to achieve is that a track with Director's commentary in English, for example, should contain a list of Labels with a description of the content in different languages. For example:
<AdaptationSet ... lang="en">
  ...
  Director's commentary
  Kommentar des Regisseurs
  Comentarios del Director
  ...
</AdaptationSet>

So the client can show a track description in the track selector depending on the language used by the client. If the client is using English, it can describe the track as "Director's commentary", or "Comentarios del Director" if it's using Spanish.

If you're only adding a List<String> to the Format, how will consumers of this field access the lang part of your example?

I created a model called Label that contains the id, lang and value. And I'm not adding a List<String> to Format, it's a List so you would be able to access the lang from the Label.

Ah right, sorry - read it too quickly and missed that.

Sorry for the delay. It wasn't super clear to us yet how we think this should look like, but your change is definitely a sensible start. One of the issues is that it should not be too DASH specific, but rather represent a generic concept every streaming format could fill in if needed.
I was wondering if we really need the Label class for example. The main purpose at the moment is to add id and language fields to each String label. The language makes sense as differentiating element, but the id has a very specific grouping function in the DASH spec. I haven't seen an example where this is used, but it feels like the GroupLabel tag would translate to something like TrackGroup.label in ExoPlayer and the Format instances are already grouped together in the TrackGroup.
Is your goal to support the language tags or do you actually care about the group ids as well? If the main goal of your PR is the translation of the labels, then we could make this more explicit by adding for example a ImmutableMap<String, String> Format.localizedLabels, which also helps to describe the purpose of this field more clearly. If we then want to add support for label grouping as well, we can consider this separately.

Hi @tonihei, yeah, I'm not interested in id either for my use case, I just added it because it was in the ISO spec but what you say seems logic since the different Formats are already grouped in the TrackGroup.
Your suggested ImmutableMap<String, String> in Format.localizedLabels looks good to me. Do you want me to change it in my PR?

Thanks for all these useful comments! We discussed this a bit more and ended up with something similar to what you have already:

Use a named Label class to make it more future-proof even if the main use case for now is translation in other languages.
Do not add the id field as long as we don't know the exact use case. We can treat it as a separate feature request if this is required in the future. It would get a more descriptive name as well at this point (like groupId or similar).
Add the new Format.labels field, but do not deprecate the existing Format.label field. The existing field is still useful as a "default" label (which we should also point out in the Javadoc).
The point above means we should also make sure both fields can be relied upon by consumers of Format. This can be ensured in Format.Builder:

if no labels are set, automatically populate them with a single entry matching label.
if no label is set, automatically populate it by either the label matching Format.language or by the first one in the list.
if both values are set, throw an lllegalStateException in Format.Builder.build() if labels doesn't contain label.

Overall, that should be pretty close to your existing pull request. Not deprecating the old field and having this default consistency update in Format.Builder also means you won't have to change many of the files touched in your current version. Do you want to make the remaining updates? We are to merge it with these changes.

This sounds good to me, I'll start working in the changes!

@tonihei working on this, I don't understand very well the lllegalStateException condition. After doing the first two points, we ensure that there will always be consistency if only one of them (label or labels) are set. It none are set, nothing changes, both will be empty. But if both are set in theory it should be possible to have a manifest that is setting a label that is not part of the  list and I think we shouldn't throw an exception when this happens.
I pushed a commit with all the changes so you can take a look except the IllegalStateException part and without adding Format unit tests.

it should be possible to have a manifest that is setting a label that is not part of the  list and I think we shouldn't throw an exception when this happens

I was under the assumption that all labels are signalled via  elements in the DASH manifest and there is no separate label that can be defined differently? If so, the situation you describe wouldn't happen, but I may be missing something. Could you explain where the label that is not part of the labels list comes from?

@tonihei Correct, following the DASH manifest ISO, label shouldn't even exist. But currently it's implemented in Exoplayer because of a PR asking for it in 2018 (https://github.com/google/ExoPlayer/pull/4391). Maybe  list didn't exist by that time in the ISO? I don't know.
But I guess you want to keep label for legacy purposes, so clients that are currently relying on it, even when it's not part of the ISO, can keep using it. So thinking on these legacy clients not following ISO that are using label, I was thinking that they could have a legacy label beside a list of modern  and not receiving an exception when they don't match. As for your answer, I guess maybe this is completely non sense.
So anyway, maybe I'm overthinking it, if you still want me to throw the lllegalStateException because a manifest will never set both label and  list on its own, I'm ok doing it.

But I guess you want to keep label for legacy purposes, so clients that are currently relying on it, even when it's not part of the ISO

A singular label also makes sense for other formats, e.g. Matroska, see Track > Label: https://www.matroska.org/technical/elements.html

The exception is nice because it means we can document Format.label as definitely being derived from/related to one of the entries in Format.labels. This means an app that wants to inspect all labels only has to look at Format.labels. Without this guarantee, we have to document things more vaguely, and apps are then obliged to check both Format.label and Format.labels and add some de-duping logic in case labels does contain label.

@icbaker cool, I've added the IllegalStateException and some unit tests in FormatTest, so this should be ready for review.

@tonihei I addressed your PR feedback except one I didn't understand. Feel free to resolve the conversations when you review the changes if you are ok with them!

Thanks a lot! We'll work on merging the PR internally (you may see some additional commits for formatting fixes etc).


Why only train conv5 of VGG?

Hi! First of all, congratulations for your great work, very inspiring! I would like to know the reasons for only training the last layers of VGG instead of the full network. Have you tried to see if the results improve? I recall the original NetVLAD paper also did this for memory reasons, but GPUs are more powerful now.
Thank you and congrats again!

Hi @jmorlana, many thanks for your interest in our work, and for your kind words. We have not tried to train all VGG layers - indeed this might improve performance. In the NetVLAD TPAMI paper, Table 2, they performed some experiments with AlexNet - there the difference between training just the last conv layer or the whole network wasn't too big.
Feel free to report back if you decide to train the all VGG layers.


Operator doesn't revalidate cluster state if node decommission failed due to disk size check

What happened?
During node decommission operator detected that a pod in the statefulset doesn't have enough space to absorb data from decommission node.
Operator log:
2024-04-22T12:59:54.887Z	ERROR	Reconciler error	{"controller": "cassandradatacenter_controller", "controllerGroup": "cassandra.datastax.com", "controllerKind": "CassandraDatacenter", "CassandraDatacenter": {"name":"data","namespace":"NAMESPACE"}, "namespace": "NAMESPACE", "name": "data", "reconcileID": "25b7c6a7-a9dc-4fb3-9e7f-64a1c858c3ab", "error": "datacenter data is not in a valid state: Not enough free space available to decommission. k8ssandra-data-default-sts-5 has<PHONE_NUMBER>512 free space, but<PHONE_NUMBER>087 is needed."}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.0/pkg/internal/controller/controller.go:326
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.0/pkg/internal/controller/controller.go:273
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2

Cluster status:
Status:
  Cassandra Operator Progress:  Updating
  Conditions:
    Last Transition Time:    2023-11-21T07:18:34Z
    Message:
    Reason:
    Status:                  True
    Type:                    Healthy
    Last Transition Time:    2023-08-10T13:19:30Z
    Message:
    Reason:
    Status:                  False
    Type:                    Stopped
    Last Transition Time:    2023-08-10T13:19:30Z
    Message:
    Reason:
    Status:                  False
    Type:                    ReplacingNodes
    Last Transition Time:    2023-08-10T13:19:30Z
    Message:
    Reason:
    Status:                  False
    Type:                    Updating
    Last Transition Time:    2023-08-10T13:19:30Z
    Message:
    Reason:
    Status:                  False
    Type:                    RollingRestart
    Last Transition Time:    2023-08-10T13:19:30Z
    Message:
    Reason:
    Status:                  False
    Type:                    Resuming
    Last Transition Time:    2024-03-28T13:42:51Z
    Message:
    Reason:
    Status:                  True
    Type:                    ScalingDown
    Last Transition Time:    2024-03-28T13:42:52Z
    Message:                 Not enough free space available to decommission. k8ssandra-data-default-sts-5 has<PHONE_NUMBER>512 free space, but<PHONE_NUMBER>087 is needed.
    Reason:                  notEnoughSpaceToScaleDown
    Status:                  False
    Type:                    Valid
    Last Transition Time:    2023-08-10T13:19:30Z
    Message:
    Reason:
    Status:                  True
    Type:                    Initialized
    Last Transition Time:    2023-08-10T13:19:30Z
    Message:
    Reason:
    Status:                  True
    Type:                    Ready

We've increased PVC for all pods in the statefulset but operator doesn't revalidate cluster:
 kubectl -n NAMESPACE exec k8ssandra-data-default-sts-5 -c cassandra -- df -B1 /var/lib/cassandra
Filesystem         1B-blocks          Used     Available Use% Mounted on
/dev/nvme1n1<PHONE_NUMBER>136<PHONE_NUMBER>920<PHONE_NUMBER>000  39% /var/lib/cassandra

Currently this cluster is kinda locked as we can't either add or remove a node to the cluster. Looks like operator always stops on this step https://github.com/k8ssandra/cass-operator/blob/v1.14.0/pkg/reconciliation/reconcile_racks.go#L2293 and doesn't proceed to step of updating cluster status.
What did you expect to happen?
Operator revalidates status of the cluster and decommission a node.
How can we reproduce it (as minimally and precisely as possible)?

Create a cluster and generate some amount of data.
Inside any pod of the cluster create file which consumes disk space on /var/lib/cassandra , e.g. fallocate -l SIZEG file_name
Remove one node by updating size in corresponding CassandraDatacenter object
Remove the generated file and try to either increase or decrease cluster size again

cass-operator version
v1.14.0
Kubernetes version
Server Version: v1.23.2
Method of installation
Argo
Anything else we need to know?
No response

Hey, you're right, the check should include something like Generation check to verify if CassandraDatacenter has been modified to fix the Valid state.
You can workaround this with some status changes however:
# Get the index of the correct place
kubectl get cassdc dc1 -o yaml | yq '.status.conditions[] | select(.type=="Valid") | path | .[-1]')

# Update
kubectl patch cassdc dc1 --subresource=status --type=json -p='[{"op": "replace", "path": "/status/conditions/7/status", "value": "True"}]'

Replace with correct index the latter /7 and also correct resource name (dc1)

Hi @burmanm , thank you a lot for the assistance. I confirm that workaround you've provided helps!


Increase PHP memory limit in AppVeyor

Could you reopen this against the release/9.0.0 branch? It’s the one that’s failing.
In truth I never considered this could be just a memory limitation because I’m so used to memory limit errors being the result of some kind of recursive operation gone wrong.

Could you reopen this against the release/9.0.0 branch? It’s the one that’s failing.
In truth I never considered this could be just a memory limitation because I’m so used to memory limit errors being the result of some kind of recursive operation gone wrong.

Well, we are very near to the default 128MB memory limit in develop branch too...

Gotcha.
Sent from my iPhone

On Mar 4, 2019, at 6:47 AM, Michele Locati<EMAIL_ADDRESS>wrote:
Could you reopen this against the release/9.0.0 branch? It’s the one that’s failing.
In truth I never considered this could be just a memory limitation because I’m so used to memory limit errors being the result of some kind of recursive operation gone wrong.
Well, we are very near to the default 128MB memory limit in develop branch too...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


Enable players to view and cancel their current actions

Players should be able to view their current actions (possibly on the home screen in a table) and cancel selected actions if needed.
This feature depends on backend implementation.

Not going to implement.


Edit Hold - Fx Menu

Hello
the fx menu does not remain available in touch mode, as soon as you release the buttons on the screen, it makes the selection difficult but the haptic feedback is present and very satisfying but this little problem spoils the pleasure a little, of course, it must work better with a externe pad!  could you perhaps add a button that would bring together the combo of the Edit button or be able to maintain / hold it so that the fx menu does not disappear when your fingers are released, that would be great!  it's missing that ^^.  Thanks in advance if you find a tip.

I confirm this. On the M8 we display app, this works like this: keeping pressed the modify button keeps the menu opened, and you can navigate with the directional buttons. As soon as you leave the other button, the menu closes selecting the effect you were on.

Should be fixed in https://github.com/v3rm0n/m8c-android/releases/tag/v1.0.23

it's better like that yes, but the instrument fx menu is missing, we don't see it appear!  only sequencer fx and mixer effect x (

Perfect !! thanks you !!
Le jeu. 10 août 2023 à 19:29, Maido @.***> a écrit :

Should be fixed in
https://github.com/v3rm0n/m8c-android/releases/tag/v1.0.23
—
Reply to this email directly, view it on GitHub
https://github.com/v3rm0n/m8c-android/issues/91#issuecomment-1673624421,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH6OJHAN3QR765EWTTBFMMDXUULARANCNFSM6AAAAAA2SUF25U
.
You are receiving this because you authored the thread.Message ID:
@.***>


Can black be downgraded to 19.3b0 for use with pypy support for devolper#early-feedback

Be sure to check the existing issues (both open and closed!), and make sure you are running the latest version of Pipenv.
Check the diagnose documentation for common issues and the PEEP list before posting! We may close your issue if it is very similar to one of them. Please be considerate and follow the PEEP process, or be on your way.
Make sure to mention your debugging experience if the documented solution failed.
Is your feature request related to a problem? Please describe.
I like trying to use pypy to help develop pipenv but with black >  19.3b0 it need typed-ast which does not work with the latest (of this writing) pypy aviable from downloads. I doing this on a raspbery 4 pi with 4gb of ram. I have pypy working fine , But since there is no wheel for arm32 it has to a build  typed-ast.
typing
pipenv install --dev
which fails to build some header files an is a know issue in typed-ast and thjere sulltion is to wait for a new pypy to support python 3.8 wich they say might take a while.  Looking at black issues the now about it and say  black==19.3b0 works good.
I changed the pipfile.lock to use black==19.3b0 and remove the typed-ast dependency and install fine now..  I was wondering if i make a pull request if this change would be acceptable and if there was reason you black ~> 19.30b  version.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
It is very frustrating right now to have to use python instead of pypy just because black is too new and pipenv does not allow you to use both without deleting the other.
Describe the solution you'd like
A clear and concise description of what you want to happen.
This was explain above, I want black downgraded and typed-ast dependency removed.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
work on support for more the one virtual enviorments as i already mentioned in this issue
Additional context
the incompatibility with black is
mentioned in this issue
Add any other context or screenshots about the feature request here. It may be a good idea to mention that platform and Python version you are on.

Please run $ pipenv --support, and paste the results here. Don't put backticks (`) around it! The output already contains Markdown formatting.
If you're on macOS, run the following:
$ pipenv --support | pbcopy

If you're on Windows, run the following:
> pipenv --support | clip

If you're on Linux, run the following:
$ pipenv --support | xclip

19.3b0 is a relatively old release. You can ignore that failure and manually install via pipenv run pip install black==19.3.b0 if you still require the package. I prefer to keep the lock file unchanged.

Please reconsider reopen this, your work around does not work and does not address the feature  I am requesting which was Pipenv to support pypy development enviorment).
This is my fault with how I worded my feature request I am sorry about that.  I have a hard time with wording and write in general.  I should of not put the question can black be downgraded in the title(I will rename properly).
you said

19.3b0 is a relatively old release

I understand you want to use the latest but there are thing you should consider

using to new of  release breaks things  pypy in my case and black does not want to fix it ,it is not high enough priority (at least that want it sound to me when going thought there issues about it.)

In some way this is a bug in pipenv I thought it said it support pypy but you can't use it to devlope  pipenv itself.  If you use

pipenv run pip install black==19.3.b0.  It still fail the pytest (even thought i have not tried to do this, want i have done should do the same thing and fail several imports).
I know nothing about pytest though and the document on configuring pytest for pipenv  IMHO is lacking as of right now i was thinking about make a new feature request on that too but  I hate keep opening feature request and want to fix these type of  Issue myself, because I know you don't have much for time.  Who does?

I came across older packages still be used like( Sphinx and Pytest ) who are worse.
I think it is for python 2.7 support which is no longer supported

I am very frustrated with pipenv not doing the thing I wanted and working with pypy is one of them.

The whole purpose of a lock file is to keep the development environment the same to avoid breakage,

in generally can use older function but you can't use newer ones.

I don't want to just complain and  I was trying to fix the problem myself i just asking for a little support by keeping this open.  I want a central place to talk about this issue in case anyone else like me wanted to work on it.

I find it odd , for me  the whole purpose of putting programs on the web is to get people to work together to make a program better, but i just seem to find it to be a big time sync;  Trying to explain want i trying to do.

I prefer to keep the lock file unchanged

Is there a reason why?  Are you use some important new feature in a new version of black(which is what i was really trying to ask when i posted this ?)

As of right know
I don't know if it because of pytest(which is relay old which does not help) or I have pytest miss configured.  But i can't
understand the output it pytest is give me.  I going to keep reading on how to use pytest and How make files are used etc.  I was hoping to try make pipenv better but it's looking to be beyond my abilities.


Update extensions config for OTel collector

Proposed changes
Update extensions config for Otel collector
Checklist
Before creating a PR, run through this checklist and mark each as complete.

[ ] I have read the CONTRIBUTING document
[ ] I have run make install-tools and have attached any dependency changes to this pull request
[ ] If applicable, I have added tests that prove my fix is effective or that my feature works
[ ] If applicable, I have checked that any relevant tests pass after adding my changes
[ ] If applicable, I have updated any relevant documentation (README.md)
[ ] If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

Branch testing passed - Can see data in the logs and the Graphana with the extensions in nginx-agent.conf


fixed blockBreak trigger

now injects instead of using the server side forge event
also hitBlock trigger now returns the correct block pos instead of always returning (0, 0, 0)
no idea why these triggers don't work in dev, but they're working in prod
edit: was an idiot and didn't read the contributing.md file
fixes #219

@Squagward thank you very much for implementing this!


Added disableLocalAuth property to Microsoft.AppConfiguration/configurationStores

Added the disableLocalAuth property to the latest preview version of Microsoft.AppConfiguration/configurationStores.
The disableLocalAuth property will be required for all Azure Resources that support AAD Authentication and local authentication schemes. When disableLocalAuth is set to true only AAD authentication can be used to access the respective configurationStore.

@jimmyca15 , please follow comment posted by @openapi-workflow-bot

@erich-wang can you point me to the breaking change guidelines? Are we expected to introduce a new api version for any tweak or new property in a preview API version? What if the version is only a week old?

https://aka.ms/AzBreakingChangesPolicy, basically you need to get exceptional approval by following up policy if you don't want to introduce new api version.

@jimmyca15, is this PR still valid? Have you gone thru breaking change process?

@erich-wang this was replaced with the pr #13490 to avoid breaking changes. I'll go ahead and close it.


Made SMTPOutputOperator Idempotent.

Looks like build failed

Just Built on my system with same core as I had when I created this pull request, it built fine.
You might be building with latest core.
Let me merge latest dt-dev into this branch and checkin.


Dropdown added in People page, Sign-up page responsive, Login-Page minor change,  Icon Bar removal in mobile view

@BAAHUBALI7781 Overall +1. Home page looks cleaner now in smaller screens. The People tab can be refined more. Decrease the card size of each person to half of what it is now. also "Meet the first year students of IT department" font needs to be decreased in smaller screens.

Okay! Will make the changes 👍

Hi @shivam-51 , I have updated the people.vue and first.vue. I have made some changes in the cards (mobile responsive) but decreasing the size of cards was not a good idea. So I haven't done that. Made changes the heading ( made the font size responsive).


Fix errors and styling

If you run through this tutorial you will fail for multiple reasons, they are listed here and fixed in this commit:

[x] The Nuget package Microsoft.Azure.CognitiveServices.Personalizer is published as a preview, fixing the suffix to make that command work
[x] The tutorial is missing the actions and seems to be mixing up actions and context. Adding the actions and splitting them up.
[x] The main loop was copy pasted. Added it as a snippet from program.cs instead.
[x] Marked names of methods as code

@PeterOrneholm : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thank you for your contribution - reviewing changes. #in-progress

@diberry - because the public repo doesn't have staging tools, we can't verify that the code samples will render correctly. can you and @PeterOrneholm check this after it's live to make sure? alternatively, we can move the commits to the private repo and use the staging tools there.  thanks.

@Jak-MS I can check - when will it be merged?

It's now available here:
https://docs.microsoft.com/en-us/azure/cognitive-services/personalizer/csharp-quickstart-commandline-feedback-loop
Looks good to me :)
Thanks for merging!

@PeterOrneholm Thank you for checking. #please-close


Metasenter page on X-server for Windows link not working

In FAQs there is a link to "Metasenter page on X-server for Windows":  <../../../metacenter/metacenter-documentation/metacenter_user_guide/x-server-for-windows>
It came from http://hpc.uit.no/docs/guides/... , but the link doesn't work any more. Shall we just remove it?

I also think we should just remove it.

Removed.


Add a build option to duplicate non-page (e.g. images) resources across languages

See #11453.
That is mostly a good thing.
But it doesn't work if:

The multilingual site doesn't have image render hooks.
The multilingual site have Markup formats (e.g. HTML, Asciidoc) that does not support render hooks.

So,  I suggest that we extend the build options to look something like this:
[_build]
  list = 'always'
  publishResources = true
  duplicateResourceFiles = false
  render = 'always'

When duplicateResourceFiles = true we copy non-page resources (e.g. foo.png) for the languages without a dedicated version.

In support of #11453, for multilingual sites with page resources shared between languages, sites will need both link and image render hooks that capture the page resource and use its .RelPermalink.
structure
content/
├── my-bundle/
│   ├── index.de.md
│   ├── index.en.md
│   ├── kitten.en.jpg
│   └── notes.en.pdf
├── _index.de.md
└── _index.en.md

published
├── de/
│   ├── my-bundle/
│   │   └── index.html
│   └── index.html
├── en/
│   ├── my-bundle/
│   │   ├── index.html
│   │   ├── kitten.jpg  <-- de site will need image render hook to get this URL
│   │   └── notes.pdf   <-- de site will need link render hook to get this URL
│   └── index.html
├── favicon.ico
└── index.html

@jmooring yea, I have slept on this, and the hook approach doesn't really work. See my revised proposal above.

I have revised the proposal a little:

Put the setting in front matter
Make the default behave the way it does today, which means we can remove #11453, the "noisiest" of the breaking changes, I suspect.

My thoughts...
Not duplicating page resources is a huge win for multilingual, single host sites. For something this valuable, it would be great if there were a simple on/off switch somewhere.
The challenges with enabling it by default are:

The site must use link and image render hooks to capture the markdown destination as a resource.
Markdown is the only content format that supports render hooks.

Item 1 doesn't concern me so much; I have advocated for these before in #10585. Proper resolution of markdown link and image destinations has been a challenge for site, theme, and content authors for a very long time. We can handle this initially with documented examples, and perhaps create embedded templates at some point.
With respect to Item 2:

99% of sites use markdown only.
The other 1% may be entirely of one format, or a mix of formats. For example, I've seen sites where one section is markdown, while another is reStructuredText. I've also seen a mix of formats in the same section.

Enabling render hooks for other content formats is a non-starter, so... can we limit resource de-duplication to markdown pages?  There's an edge case that looks like this, but probably uncommon:
content/
└── posts/
    └── post-1/
        ├── a.jpg
        ├── index.de.adoc
        ├── index.en.md
        ├── index.es.org
        ├── index.fr.pdc
        ├── index.it.html
        └── index.pt.rst

If we can limit resource de-duplication to markdown pages...
A) Disable the feature by default with an on switch in site config under markup.goldmark (the feature is specific to markdown, and render hooks are limited to Goldmark).
B) Document its usage.

Are you using link and/or image render hooks? If no, use these examples, if yes, proceed to next step
Build site and run link checker (e.g., muffet) to verify internal links
If you have related errors, compare your render hooks to the examples...

And we have to do B regardless of how this feature is enabled.

can we limit resource de-duplication to markdown pages?

I hadn't thought about that, but that actually makes sense and should be a decent compromise.
content/
└── posts/
    └── post-1/
        ├── a.jpg
        ├── index.de.adoc
        ├── index.en.md
        ├── index.es.org
        ├── index.fr.pdc
        ├── index.it.html
        └── index.pt.rst

That looks ... made up. But if we say:
[markup]
  [markup.goldmark]
        duplicateResourceFiles = false

It is the owner of the resource that dictates the behaviour; in the example above (assuming the default content language is en), the resource owner is index.en.md. The site owner would need to switch to duplicateResourceFiles = true in Goldmark to make it work for the other formats.
Does this sound like a plan?

we probably need some default render hooks

See https://github.com/gohugoio/hugo/issues/11904#issuecomment-1900837816 for candidates and test cases. I am very comfortable with these for any new sites, and mostly comfortable for existing sites, but difficult to know for certain (there's some wacky stuff out there).
Multilingual, single host sites with existing render hooks will have to run a link checker before going live to make sure their hooks work as required. See my previous comment.

We could probably safeguard this by doing:

Only use the default render hooks when len(languages) > 1 and
add a way to disable

[markup]
  [markup.goldmark]
        duplicateResourceFiles = false
        disableDefaultRenderHooks = false

Withorks for me.
At some point, though, default render hooks for every site would be good. But that's for another day...
If you're mostly comfortable with the candidate hooks above, let me know and I can submit a PR with tests.

What about something like this instead:
[markup.goldmark.renderhooks.image]
enable = true
multilingualOnly= true

[markup.goldmark.renderhooks.link]
enable = true
multilingualOnly= true

This gives us (obviously) granular control, and sets up for future capability. For example:
[markup.goldmark.renderhooks.image]
enable = true
multilingualOnly= true
errorLevel = 'warning' # ignore (default), warning, or error (fails the build)

[markup.goldmark.renderhooks.link]
enable = true
multilingualOnly= true
errorLevel = 'warning' # ignore (default), warning, or error (fails the build)

Yea, that makes sense.


fixed grpc.ServerOption order to catch panic

Signed-off-by: wander1024<EMAIL_ADDRESS>

[ ] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes

Verification
due to panic and recover atribute
we met the issue as #4080

This seems pretty close to the finish line. Looking forward to it.

Seems like the linting tests are failing, can you run  make lint and make docs? Else the tests won't pass 😅

it's too strange.
I only modified 2 lines. just changed the positions.why docs and lint test failed.
I did make lint and make docs
make docs is passed.
but make lint get js error
/usr/local/lib/node_modules/yarn/lib/cli.js:46100
  let {
      ^

SyntaxError: Unexpected token {
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:374:25)
    at Object.Module._extensions..js (module.js:417:10)
    at Module.load (module.js:344:32)
    at Function.Module._load (module.js:301:12)
    at Module.require (module.js:354:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/usr/local/lib/node_modules/yarn/bin/yarn.js:24:13)
    at Module._compile (module.js:410:26)
    at Object.Module._extensions..js (module.js:417:10)
Makefile:91: recipe for target 'pkg/ui/react-app/node_modules' failed

Looks like it's passing on CI though?

I re-ran the tests and they passed :slightly_smiling_face:


[Snyk] Security upgrade com.amazonaws:aws-java-sdk from 1.12.257 to 1.12.279

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `maven` dependencies of this project.
:sparkles: Snyk has automatically assigned this pull request, set who gets assigned.
As this is a private repository, Snyk-bot does not have access. Therefore, this PR has been created automatically, but appears to have been created by a real user.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

uasdm-server/pom.xml

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Upgrade
Breaking Change
Exploit Maturity

539/1000  Why? Has a fix available, CVSS 6.5
Directory Traversal SNYK-JAVA-COMAMAZONAWS-2952700
com.amazonaws:aws-java-sdk:  1.12.257 -> 1.12.279
No
No Known Exploit

509/1000  Why? Has a fix available, CVSS 5.9
Denial of Service (DoS) SNYK-JAVA-COMFASTERXMLJACKSONCORE-2326698
com.amazonaws:aws-java-sdk:  1.12.257 -> 1.12.279
No
No Known Exploit

589/1000  Why? Has a fix available, CVSS 7.5
Denial of Service (DoS) SNYK-JAVA-COMFASTERXMLJACKSONCORE-2421244
com.amazonaws:aws-java-sdk:  1.12.257 -> 1.12.279
No
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
👩💻 Set who automatically gets assigned
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Directory Traversal

Updated in another PR


Optional types should allow null, in addition to undefined, #170

@kriszyp  sorry about the delay getting back to you, thanks for this but I've decided to deprecate this repo in favour of https://codemix.github.io/flow-runtime/
In this case, Flow does not allow null in place of optional - https://flowtype.org/try/#0GYVwdgxgLglg9mABAEwKYFs6IBQEMD8AXIgM5QBOMYA5gJSIDeAUIohAiXADaoB0XcanloBuJgF8mTNJmxgQXLqKZA


feat: move all colors to separate repository (DEV-122)

TL;DR
Deleted (now) unnecessary color files for Terra themes.
What changed?
Removed Terra theme color files (spring, summer, fall, winter) for day and night appearances.
How to test?
Ensure that the Terra themes still function correctly without the deleted color files, when having both modules cloned appropiately.
Example:
---@type LazyPluginSpec
M.spec = {
    "black-atom-industries/black-atom-core.nvim",
    dependencies = {
            "black-atom-industries/black-atom-terra-collection.nvim",
    },
    lazy = false,
    priority = 1000,
    ---@type BlackAtomCore.Config
    opts = {
        debug = false,
        theme = require("vin.config").colorscheme,
        styles = {
            dark_sidebars = require("vin.config").custom_highlights.enable_contrast,
            transparency = "none",
            cmp_kind_color_mode = "bg",
            diagnostics = {
                background = true,
            },
        },
    },
}

Why make this change?
To remove redundant or unused color files and improve maintainability.

#66  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nikbrunner and the rest of your teammates on  Graphite

Merge activity

Mar 26, 1:50 PM EDT: @nikbrunner merged this pull request with Graphite.


Steam: ability to ignore installed games from other accounts

Hey!
As discussed on my Reddit Post:
https://www.reddit.com/r/playnite/comments/eu68ne/hiding_games_not_owned
Would be great to have the ability to filter games from other users accounts, as a recap, after setting up my partner as a second user on my PC and installing Playnite for her to sort her games, as we share the same install location for the physical copies of games (Drive D:) Playnite will show all games installed regardless of who owns that copy of the game.

Done in the latest update.


Test Results are not shown in workflow run job list

Hello,
as we update to v.2.11.0, test results are not shown in workflow run summary job list on the left.
It worked fine with v2.10.0.
Examples:
v2.11.0

v2.10.0

Is this an expected behavior?
Thanks,
Dzenan

Did you introduce other workflows while upgrading to v2.11.0? The test results might end up at some other workflow that ran on the same commit. See #12.

No i didnt introduce other workflows.

Hi, do you have any other idea what could cause this problem? Here you can see a all jobs and there subjobs

The Test Results are shown under the annotations block

Can you provide the log of one of the runs of this action?

In a different run of the same workflow. The run number shown above is 20 and the results are in run number 19

Can you work with this information or do you need more informations? Its an important topic for us because we might have to downgrade to an older version.

Ok, but why does it work with an older version?

Did you have multiple events for your workflow before?
Did each workflow run for one commit have the checks before?
Do both events fire simultaneously (push and sync) or at different times (sync and schedule)?

No, i only changed the version to 2.11.0.

Sorry, I cannot help if you don't answer those three questions specifically.

Ah, I saw now that I added new events for testing purpose i forgot about. I removed the events and now it works fine.
Thanks for your time and help :)

Just as I suspected. Glad I could help.


Logs infinite requests

When you have no logs client app will be sending requests as fast and frequent as it can

It's because backend doesn't keep long poll request, will fix it in 1.2


853 added tests to reproduce the issue

This is a PR to reproduce the issue.
@ILoveMyTortoise  Dmytro, feel free to merge/close/remove this branch whenever you're happy to do so.

This is a PR to reproduce the issue.
@ILoveMyTortoise Dmytro, feel free to merge/close/remove this branch whenever you're happy to do so.

we should merge and remove the skip when the fix is done
can we mer @anna-naumova25 ?


Update Partner DID through UI

This should be temporary, but allow update of Partner DID in UI to aid development and testing.
Currently, the receiver of a connection uses a bad DID for the initiator and must be set correctly in the db.
Signed-off-by: Jason Sherman<EMAIL_ADDRESS>

The reason is that ACA-Py always uses a new "peer" DID when requesting a connection. There is a long standing issue in ACA-Py that discusses this:
https://github.com/hyperledger/aries-cloudagent-python/issues/358
We have currently two mechanisms in place to handle this issue:

Request a "Commercial Registry Credentials" that includes the public DID of the other party.
A hack: You can set the agent label according to the following schema publicDID:label, e.g. "did:sov:iil:123:label".

btw. while updating the api wrapper i noticed that the connection record now has a a new field: their_public_did I have not tested if this field is set yet, but this might be the fix we are looking for.

This is only set in the DID Exchange protocol, but event then it seems not to address our issue.


Revert "NTP-1292: Fix Inconsistent Domain Resolution for https://www.find-tuition-partner.service.gov.uk"

Reverts DFE-Digital/find-a-tuition-partner#398

Reverting the changes as we created the DNS zone and associated Front Door custom domain without the Terraform on the production.


SQLite with presets creation and connection

@zamazaljakub 👍

https://troytae.github.io/game-of-life/
https://conwaylife.com/wiki/Category:Lists_of_patterns

due to time pressure sqlite database will not be implemented :) find your plain text on game of life wiki


ENH: Notebook now runs on Google Colab.

Bump version to 2.1.3.
Install python3-openslide.
Add tensorflow>=2.6.0,<2.7 dependency.
Add advice that Google Colab may require Runtime->Restart runtime.
Add GitHub badge to README.md.
This works in docker and in Python virtual environments, etc, but does not work on Google Colab unless the user selects Runtime->Restart runtime after installing the large_image package.  A change to large_image to work around this is in the works.

The recent force-push separates the version bump into its own commit.


"Allow Open Initially" sensor names in Armed alert as a wildcard same as "Bypassed"

Checklist

[x] I checked for similar existing requests (both open and closed) before posting.
[x] My request is generic, other users may benefit from it too.

Proposal
Right now, Alarmo allows us to use the Bypassed wild card when arming the alarm to see what is bypassed, I think it would be great to have the same data for Open Initially.
This request is so that users can see what windows are open so that they can keep track and close the windows later that are open.
Additional info
Add a wild card open in the notifications area similar to Bypassed

I agree with your request.
I just don't really know (yet) how to make this happen in the code.
The bypassed sensors are handled differently than sensors which are initially ignored. So I might need to reshuffle some things to be able to add this feature.


remove new A()

so we can get past 3.9.0

I guess we can also point the app at my fork:branch too

closing and pointing app at my fork 🍴


ShapedRecipie builder

The ShapedRecipe.Builder is a bit annoying/odd to use.
Current:
builder
    .width(2)
    .height(2)
    .ingredient(2, 2, ItemStack.builder().build());

In my opinion, something like this (as seen in vanilla/forge to a point) would be nice:
builder
    .aisle("~~~", "~~~", "~~X")
    .where('~', ItemStack.builder().build())
    .where('X', ItemStack.builder().build());

Closing as there is now a PR for this. Comment on it.


Reduce the total number of test payloads

We started accumulating a lot of test payloads, and that's great!
However, there is a lot of redundancy in our tests as of now, with some payloads only checking a few CSR registers. It approach is not going to scale as we implement more and more features.
It is probably time for some refactoring to group tests into fewer payloads, maybe by testing multiple CSRs in a single payload.
Also, note that implementing #19 would provide the ability to print, and thus to use assert! with string comments to indicate which tests failed. Once implemented, that would make it easy to detect what went wrong in a payload in case of crash, despite testing a few functionalities at once.

@CharlyCst What do you mean exactly? I can take care of it


Revised path aggregation, edge attributes & paths as edges

 Add support for returning each path as a feature collection of edges having noise/AQ attributes. Currently the app returns paths only as aggregated geometries & attributes.


isErrorFromAlias not finding errors when uri have undefined params

Hello,
TLDR; isErrorFromAlias is checking the isErrorFromPath does.
I have an issue where, now I can fix easily but what really hard to debug.
I was using isErrorFromAlias but was returning false and I was not able to figure out why. I tried using a z.any() schema, an 'default' status but none of them worked.
After copying the code of isErrorFromAlias in my project and add many many console.log I was able to find the issue.
It's related to this code :
https://github.com/ecyrbe/zodios/blob/e8232fcb5490263dd24b4effde622245843073f7/src/utils.ts#L111-L125
Even it's looking for the endpoint using the alias it's still checking the uri.
The issue is in the pathMatchesUrl method ;
https://github.com/ecyrbe/zodios/blob/e8232fcb5490263dd24b4effde622245843073f7/src/utils.ts#L127-L130
But in my case the endpoint URI is /api/:apiKey/config/whitelist/:oldApiKey and the url of the Axios response is /api/SOME_KEY/config/whitelist/
The regex is resolved to /api/([^/]+)/config/whitelist/([^/]+) but that don't match the response url because oldApiKey was undefined.
The easy fix it to make sure the oldApiKey is defined.
My question, if it's looking with the alias why it's still checking the uri ?
And a side question, does the alias need to be uniques in the api ?
Thanks

it's checking the uri, because that's all the error that got rejected has to provide to match the call. The alias alone can't allow to match the error uri.
In v11, i'am now evaluating to remove this entirely and make the call return the object error, like this :
const { data: user, error } = client.getUser();

instead of :
try {
 const user = client.getUser();
 } catch (e) {
   if(isErrorFromAlias('getUser')) {
   ...
   }
 }

But the decision to do this breaking change is not yet settled

Yes but you could use the alias to get the endpoint (like you did) and only the status for the error ;
   const endpoint = findEndpointByAlias(api, alias);

   return (endpoint &&
     err.config &&
     endpoint.method === err.config.method)
     ? findEndpointErrors(endpoint, err)
     : undefined;

Also you probably should add ( ) around the condition, it's more readable and typescript don't complain that way

I want to use https://github.com/causaly/zod-validation-error for better errors, what would be nice is to check the error like this:
if(err instanceof ZodiosError) {
   console.log(fromZodError(err.zodError).toString())
}


Handlebars

Setup the handlebars to load in data from the API for adding to the collection.
Setup the handlebars to load the data from the database when viewing the collection.

Almost complete. Need to finish formatting handlebars so that page titles Wishlist and Collection display properly, profile pic uploads properly, all navbar links display correctly in each handlebar.


Api

Add api enpoints for:

Listing all posts for a user.
Listing all comments for a user's post.
Adding a comment to a post. Remember that the owner of the comment is the user that makes it.
All API endpoints receive JSON and respond JSON as well.

Hi Team,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
Kindly ensure to remove Live demo link from the ReadMe if app is not yet deployed.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.

We believe this is no reason to invalidate the review since previous code reviewers asked us to add the demo link even with no working link.


Set user attributes based on the IdP in use, not an attribute

I've got a multi-IdP setup, with a custom loader, that varies based on the Company (pulled from the URL) you're attempting to log into. That side of the equation seems to work well.
The problem is new users. The User (custom model) instance gets created. And can be used, but I need to link that to the Company. There's a company FK (so company_id in raw terms) field.
This ID is not communicated from the IdP. And that's by-design. allowing the IdP to set the company would be a security hole. I need some way to tie new users on a given IdP to their company.
I have one config per company. Ideally I'd be able to set something that poisoned the attributes, or something that explicitly got used in backends._get_or_create_saml2_user. A config-static dictionary eg NEW_USER_DEFAULTS, seems reasonable but I can't figure out how to access the IdP config in use from within backends._get_or_create_saml2_user. That data doesn't appear to exist by that point.
I've also considered hooking djangosaml2.signals.pre_user_save but again, I don't think I have access to the saml config in use by that point.
Can somebody point me in the right direction?

Found djangosaml2.signals.post_authenticated, thought it would save me from insanity. While I now have access to the issuer, I don't have access to the request, so I can't stuff the Company ID into a session var and pick it up afterwards.
I'm very close to losing it. I've seen the comment on #135 telling everybody to create their own ACS view but honestly, recreating all that logic for a little bit of extra context at the end seems just as backwards as the hoops I'm jumping through.
"I think middleware might be the solution" said no sane developer ever. Even so, that's looking like my last best option to hack the company from the session into the user model.

ARGL the login process is nuking the session!

You can handle this behaviour in many ways, I suggest you to do a purpose and after a brain storming about what would be a good solution we could move to a PR.
Is there any news on this?

Not able to set the attributes other then Username set by SAML_USE_NAME_ID_AS_USERNAME = True
Pls help as its showing The attributes dictionary is empty

Not able to set the attributes other then Username set by SAML_USE_NAME_ID_AS_USERNAME = True
Pls help as its showing The attributes dictionary is empty

Tell us which version you're using.
It sounds like a misconfiguration in settings.py

Fixed here:
https://github.com/knaperek/djangosaml2/pull/194


operators [R] eclipse-che (7.30.0)

chore: change 7.30.0 to not replace 7.29; remove obsolete eclipse-che operators from 7.0 - 7.29
Change-Id: Ieadc010477a579657bf394cc8dbc6b10aacd2506
Signed-off-by: nickboldt<EMAIL_ADDRESS>

To be merged along with https://github.com/redhat-openshift-ecosystem/community-operators-prod/pull/364


Capture C* logs even when job fails

Frequently I have to cancel jobs because they have hung. Cstar perf has consistently failed to preserve the C* logs on those jobs, making it impossible for me to tell if C* was the reason behind the job's failure.

handled in #204

Can we close this?

I guess yes


support pinecone serverless indexes

Pinecone has released a new type of index (serverless) that according to their documentation aim to reduce by "Up to 50x lower costs" and improve performance (see documentation --> https://www.pinecone.io/blog/serverless/)
Attention
After this change you won't need to put the pinecone's index environment param as part of pinecone's credentials.
The only parameter you need to provide is the pinecone's API-KEY.
@HenryHengZJ

@0xi4o if I'm not mistaken, you already have something in work?

@HenryHengZJ Yep. Here's the related Github issue: #1552. I haven't started on it though. I'll review and test the changes here.

Thanks @HenryHengZJ
Can you please merge it and add me as a contributor 🙏🏼?

will be automatically added as contributor once its merged. thanks again for the changes @niztal !

Verified on my end as well. Nice work @niztal!

Doesn't seem to be working for me, I'm on 1.5.0:
2024-02-07 18:21:59 [ERROR]: PineconeNotFoundError: A call to https://api.pinecone.io/indexes/cmessage returned HTTP status 404.
Error: PineconeNotFoundError: A call to https://api.pinecone.io/indexes/cmessage returned HTTP status 404.
    at Pinecone_VectorStores.upsert (/usr/local/lib/node_modules/flowise/node_modules/flowise-components/dist/nodes/vectorstores/Pinecone/Pinecone.js:40:27)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async buildLangchain (/usr/local/lib/node_modules/flowise/dist/utils/index.js:273:17)
    at async App.upsertVector (/usr/local/lib/node_modules/flowise/dist/index.js:1345:13)
    at async /usr/local/lib/node_modules/flowise/dist/index.js:1017:13
2024-02-07 18:21:59 [ERROR]: [server]: Error: Error: PineconeNotFoundError: A call to https://api.pinecone.io/indexes/cmessage returned HTTP status 404.
Error: Error: PineconeNotFoundError: A call to https://api.pinecone.io/indexes/cmessage returned HTTP status 404.
    at buildLangchain (/usr/local/lib/node_modules/flowise/dist/utils/index.js:331:19)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async App.upsertVector (/usr/local/lib/node_modules/flowise/dist/index.js:1345:13)
    at async /usr/local/lib/node_modules/flowise/dist/index.js:1017:13

curl -X GET "https://api.pinecone.io/indexes/cmessage" -H "Api-Key: 621f1f82-c85a-4524-8b0d-xxxxxxxx"
{
    "name": "wmessage",
    "metric": "cosine",
    "dimension": 1536,
    "status": {
        "ready": true,
        "state": "Ready"
    },
    "host": "cmessage-639j5gj.svc.apw5-xxx-81fa.pinecone.io",
    "spec": {
        "serverless": {
            "region": "us-west-2",
            "cloud": "aws"
        }
    }
}

@robertofabrizi please make sure you're providing the right details, make sure that the API key is the right one. Pay attention that the API key of the serverless is different than the pod indexes.
Also make sure there's a different bug who holds the user from switching between pinecone's credentials. So it may be that the API key you're providing is not updated.

@niztal I went under Create and manage API Keys in Serverless here, pressed the Copy Key button, updated the key in flowise (just in case), then went into the flow, deleted the pinecone module, added it again, selected the proper credentials, index and namespace, nothing, same error.

Yes it may be related to the bug I told earlier, try to delete all pinecone's credentials in flowise and reset it.
The best test for that would be to take API and try to hit it via curl/postman and let me know what the results are

It works via curl:
ubuntu@ip-172-31-33-45:~/volumes/n8n-tmp/xml$
curl -X POST "https://cmessage-639j5gj.svc.apw5-5e31-81fa.pinecone.io/vectors/upsert" \
  -H "Api-Key: 621f1f82-c85a-4567-8b0d-5f244946e401" \
  -H 'Content-Type: application/json' \
  -d '{
    "vectors": [
      {
        "id": "vec1",
        "values": [0.1, 0.1, 0.1, 0.1, 0.1, 0.1, 0.1, 0.1],
        "metadata": {"genre": "drama"}
      },
      {
        "id": "vec2",
        "values": [0.2, 0.2, 0.2, 0.2, 0.2, 0.2, 0.2, 0.2],
        "metadata": {"genre": "action"}
      },
      {
        "id": "vec3",
        "values": [0.3, 0.3, 0.3, 0.3, 0.3, 0.3, 0.3, 0.3],
        "metadata": {"genre": "drama"}
      },
      {
        "id": "vec4",
        "values": [0.4, 0.4, 0.4, 0.4, 0.4, 0.4, 0.4, 0.4],
        "metadata": {"genre": "action"}
      }
    ],
    "namespace": "ns1"
  }'
{"code":3,"message":"Vector dimension 8 does not match the dimension of the index 1536","details":[]}

@niztal sorry I should have specified that I masked the API in the last post, that's why they are different. Ok I'll try to delete the pinecone credentials and see if that works, thank you.

621f1f82-c85a-4524-8b0d-xxxxxxxx
vs
621f1f82-c85a-4567-8b0d-xxxxxxxx
@robertofabrizi

Yes I masked it changing some numbers here and there and I also changed the name of the index. Anyways, I went to flowise credentials, deleted the pinecone credentials (had 2, a normal and a serverless one), recreated a new pinecone credential just with the serveless api key, went into the workflow, selected this new credential (it became empty ofc), tried again, nothing.

Please share screenshot or log

Not that I got much further, I created a Multi Retrieval Q&A Chain from the template, filled it all in, asked a question, it worked, then I decided to delete one of the three vector stores leaving just the other two in the flow, deleted all connections and the vector store retriever, asked another question, now it's broken, tried duplicating it, tried restarting all containers, nothing...

2024-02-08 10:55:58 [ERROR]: [server]: Error: Cannot read properties of undefined (reading 'text')
TypeError: Cannot read properties of undefined (reading 'text')
    at App.buildChatflow (/usr/local/lib/node_modules/flowise/dist/index.js:1557:24)
    at async /usr/local/lib/node_modules/flowise/dist/index.js:1057:13

Not that I got much further, I created a Multi Retrieval Q&A Chain from the template, filled it all in, asked a question, it worked, then I decided to delete one of the three vector stores leaving just the other two in the flow, deleted all connections and the vector store retriever, asked another question, now it's broken, tried duplicating it to a new flow, tried restarting all containers of flowise, nothing...

2024-02-08 10:55:58 [ERROR]: [server]: Error: Cannot read properties of undefined (reading 'text')
TypeError: Cannot read properties of undefined (reading 'text')
    at App.buildChatflow (/usr/local/lib/node_modules/flowise/dist/index.js:1557:24)
    at async /usr/local/lib/node_modules/flowise/dist/index.js:1057:13

@robertofabrizi it seems like different issue which not related to pinecone. I suggest open a dedicated bug for that and let all community trying to resolve that.
Thanks,


Error plotting if data set not loaded and spelling in the title bar of the dialog box

Describe the bug
When you start the application and click on "Plot Stars" without selecting an active data set, the program pulls up a dialog box titled "Choice Data set to display".  That should say "Choose data set to display".
And, after clicking OK (on the 150LY data set, although I don't think that matters), I get the Astrographic data view error "Error.  No Astrographic data was loaded".
This works fine if you select a data set first and then plot, which leads me to believe that the "Choose data set to display dialog is not actually calling the "Select active dataset" routine.
Error trace:
2021-04-03 21:09:23.152  INFO 26316 --- [lication Thread] c.teamgannon.trips.routing.RoutingPanel  : adding routes
2021-04-03 21:09:23.465  INFO 26316 --- [lication Thread] c.t.t.j.r.impl.StarObjectRepositoryImpl  : created the predicates
2021-04-03 21:09:24.341  INFO 26316 --- [lication Thread] c.t.t.j.r.impl.StarObjectRepositoryImpl  : number of records found=0
2021-04-03 21:09:24.370  INFO 26316 --- [lication Thread] c.t.t.service.DatabaseManagementService  : New DB Query returns 0 stars
2021-04-03 21:09:24.380  INFO 26316 --- [lication Thread] c.t.t.service.DatabaseManagementService  : Filtered by distance Query returns 0 stars
2021-04-03 21:09:24.381  INFO 26316 --- [lication Thread] c.teamgannon.trips.graphics.PlotManager  : DB Query returns 0 stars
2021-04-03 21:09:24.518  INFO 26316 --- [lication Thread] com.teamgannon.trips.routing.RouteCell   : show route:Route: 1:
Route Sol to 85 Pegasi Aa, path 2
has 2 segments
2021-04-03 21:09:24.524  INFO 26316 --- [lication Thread] com.teamgannon.trips.routing.RouteCell   : show route:Route: 1:
Route Sol to 85 Pegasi Aa, path 2
has 2 segments
2021-04-03 21:09:24.527  INFO 26316 --- [lication Thread] com.teamgannon.trips.routing.RouteCell   : show route:Route: 2:
Route Sol to 15 Sagittae A, path 3
has 2 segments
2021-04-03 21:09:24.530  INFO 26316 --- [lication Thread] com.teamgannon.trips.routing.RouteCell   : show route:Route: 3:
Route Sol to 15 Sagittae A, path 5
has 3 segments
2021-04-03 21:10:26.633 ERROR 26316 --- [lication Thread] c.teamgannon.trips.support.AlertFactory  : No Astrographic data was loaded
TRIPS version

[ ] 0.52
[ ] 0.53
[ ] 0.54
[ ] 0.55
[X] 0.6.7

Desktop (please complete the following information):

[ ] IOS
[ ] Windows 10
[ ] Windows Vista, 7 or 8
[ ] Windows XP
[ ] Linux (add distribution and version to this line)
[X] macOS

**Additional info **
Add any other context about the problem here.

This is in two places.
PlotManager.java line 99
MainPane.java line 1653
not sure which is being used by this particular dialog, but we should change both to "Choose data set to display"

fixed
The second item is an old bug that I have currently fixed in the working version that will be released


Bug Finding (Exercise)

Hello Binyam.
I hope this message finds you well. I wanted to bring to your attention an issue with the form functionality on your website. Currently, the form successfully sends data using Formspree, but it does not save the data in the browser's LocalStorage as expected. Additionally, when the page is refreshed or reloaded, the form field values are not persisting.
Upon reviewing the code, it seems that there may be an issue with the script-preservedData.js file and its import in the index.html file. It's crucial to ensure that the file is imported correctly to enable the desired functionality.
Here are the specific problems identified:
The form data is not being saved in the browser's LocalStorage.
The form field values are not persisting on page refresh or reload.
To address this issue, I recommend performing the following steps:
Double-check the import statement for the script-preservedData.js file in your index.html file. Ensure that the file path is correct and that the script is being loaded successfully.
Review the implementation in the script-preservedData.js file. Check for any errors or omissions related to saving the form data in LocalStorage and retrieving it on page load.
I believe resolving these issues will allow the form data to be saved in LocalStorage and enable the persistence of form field values on page refresh or reload.
Please let me know if you need any further assistance or if you have any questions. I'm here to help.
Thank you for your attention to this matter.
Best regards,
Faiz Mohammad

Thank you @the-faizmohammad for the suggestions. I will address them accordingly. Thank you again.


"Size Your Images" challenge missing critical instruction

Hi.
I could not find instructions on how to add the "smaller-image" class to an image link.
I understood the challenge but there is no actual example of how to add that to <img src...
In the end I asked someone in the chatroom and got the following: <img class="smaller-image" src="https://bit.ly/fcc-relaxing-cat" but I never would have known to put "class" next to "img" and move "src" on its own.
Challenge Size your Images has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_1) AppleWebKit/602.2.14 (KHTML, like Gecko) Version/10.0.1 Safari/602.2.14.
Please describe how to reproduce this issue, and include links to screenshots if possible.

I see MANY people come everyday with the same problem, that they do not know that they need to apply that created class to their image element.
If people would analyze what test is failing they should see that you need to use that class on image
Your img element should have the class smaller-image.
But I would agree, that extra line in the instructions to say: you need to apply created class to your existing image element would help out a little bit.

Hi Lauri,
I don’t think the issue is just telling people that the “img element” should have “class smaller-image”
The issue is that people don’t know HOW to break up the traditional “img src…” tag and modify it to accommodate the class.
They need to see an example. There’s no other way of knowing how to do this.
From: Lauri Välja <notifications<EMAIL_ADDRESS>Reply-To: freeCodeCamp/freeCodeCamp <reply<EMAIL_ADDRESS>Date: Thursday, January 26, 2017 at 1:51 PM
To: freeCodeCamp/freeCodeCamp <freeCodeCamp<EMAIL_ADDRESS>Cc: Ira Josephs <ijosephs<EMAIL_ADDRESS>Mention <mention<EMAIL_ADDRESS>Subject: Re: [freeCodeCamp/freeCodeCamp] "Size Your Images" challenge missing critical instruction (#12874)
@zeyergithttps://github.com/zeyergit Thank you for reporting this issue.
I see MANY people come everyday with the same problem, that they do not know that they need to apply that created class to their image element.
If people would analyze what test is failing they should see that you need to use that class on image
Your img element should have the class smaller-image.
But I would agree, that extra line in the instructions to say: you need to apply created class to your existing image element would help out a little bit.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/freeCodeCamp/freeCodeCamp/issues/12874#issuecomment-275370687, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AYCdlGjG_z7Os44ivAFH7XysQl_soR9hks5rWIjAgaJpZM4LuhZL.

I don't think we should add "you need to apply created class to your existing image element". That coupled with existing instructions is like handing over the solution directly. We may changeYour img element should have the class smaller-image. to The img element should have.. because your makes it seem like you should be creating one.  Another change I'd suggest is to change Create a class called smaller-image to Add a class called smaller-image to the image tag.
What do others suggest? I can work on this if needed.

Hi. I’m new to FCC and don’t want to overthink this but I just want to make sure I’m being clear.
What I’m saying is that I did not know how to break up an img ref and add this other element.

In my opinion, the simplest way to make sure students know how to do this would be to show an example in the left margin just like you do for so many other things.
Really enjoying this program.
Thank you.
From: Ayushi Jain <notifications<EMAIL_ADDRESS>Reply-To: freeCodeCamp/freeCodeCamp <reply<EMAIL_ADDRESS>Date: Thursday, January 26, 2017 at 6:18 PM
To: freeCodeCamp/freeCodeCamp <freeCodeCamp<EMAIL_ADDRESS>Cc: Ira Josephs <ijosephs<EMAIL_ADDRESS>Mention <mention<EMAIL_ADDRESS>Subject: Re: [freeCodeCamp/freeCodeCamp] "Size Your Images" challenge missing critical instruction (#12874)
I don't think we should add "you need to apply created class to your existing image element". That coupled with existing instructions is like handing over the solution directly. We may changeYour img element should have the class smaller-image. to The img element should have.. because your makes it seem like you should be creating one. Another change I'd suggest is to change Create a class called smaller-image to Add a class called smaller-image to the image tag.
What do others suggest? I can work on this if needed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/freeCodeCamp/freeCodeCamp/issues/12874#issuecomment-275431535, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AYCdlAW0aK3HHm4c1C0DxGVcHuqLDbaBks5rWMdNgaJpZM4LuhZL.

I've just completed this challenge. Although I had no issue I agree with @ajain17 for those that do.
You wouldn't want to just give the answer away but maybe make it more clear on what you are supposed to be doing.

Yeah, I agree with the person. I could tell that I needed to get the class in, but was confused because I already had the SRC in there. I managed to get it, but only after spending 15 minutes trying various ways and then finally finding this thread and implementing what they did. It should really tell us how to break it apart so that I can have both an SRC and a class because I had no clue.


Code coverage tooling

Adding some thoughts here. Apologies about some confusion earlier in this PR, I was playing with multiple strategies and artifacts from both were left in the commits.
grcov uses one of two strategies to generate code coverage: source-based or "gcov"-based coverage (presumably via the gcc utility). Some internal concerns were raised that our code coverage reports were skewed due to the code's use of macros. Perhaps this is an effect of using source-based coverage (which this PR has only ever implemented, despite the presence of RUSTC_BOOTSTRAP=1 and my own misinformed comments there)? If this is the case, we can attempt to use gcov-based coverage instead, though that will require code coverage be generated using rustc nightly.


Vim/Neovim using vim-flow and install eslint globally

CHANGE LOG
Moving vim-flow to be installed in vim and neovim, since we're using neomake with it too.
Install eslint with syntastic and neomake (this one fix #13)

Hey @renatoagds I attempted to do a fresh install with your fork and it didn't seem to globally install eslint on my machine. I don't know how vim scripts work, but would it make sense to have the install.sh script run the install?
I'm also not so sure how I feel about having something else globally install node modules on my machine, I've always felt that was a little hard to swallow, @zperrault maybe it would make sense to just update the README to let people know they need eslint? Not sure which solution is the best. ¯_(ツ)_/¯

@renatoagds First of all, thank you for opening this PR!
@eanplatter @renatoagds 🤔 Right now the project installs tern globally. I feel like if don't want to install eslint and flow-bin globally then we should remove that and add add tern to the list of prereqs in the README.
Do the atom plugins work without installing things globally?
More: The flow stuff should work with the project's local copy of flow. We probably want to do the same for all of this.

Yeah I think keeping things as close to atom would be good. Auto installing global deps seems really heavy handed. I'd say the eslint stuff should work from the users project config. I'll try to do some more debugging on it later tonight.

@eanplatter about the eslint, we have few plugins that search for local eslint instead global:
https://github.com/benjie/neomake-local-eslint.vim
https://github.com/mtscout6/syntastic-local-eslint.vim
But it's not the default for Neomake and Syntastic.
IMO, any of the ways that we follow will be good.

I'm leaning more towards adopting ale and getting rid of neomake. I'd like to avoid having to install things globally. I want these features to work if eslint or flow are being used locally--not globally.


How to get callback_data from context

I have a lot of inline buttons that change the language of the bot.
I want to make one function in my AppUpdate that would change the language depending on the callback_data of the button that was pressed:
@Action(['en', 'ru', ...])
   async changeLanguage(@Ctx() ctx: Context) {
      await ctx.deleteMessage();
      ctx.session.language = ??????????????
     ...
   }

Buttons:
export default Markup.inlineKeyboard([
   [Markup.button.callback('🇬🇧 English', 'en')],
   [Markup.button.callback('🇷🇺 Русский', 'ru')],
  ...
]);

Hello, how did you solve this?


Fix issues and their colors

.yml? wasn't expecting that from you!

@thanpolas lol, not an option, the probot only supports yaml.

:trollface: much @thanpolas? 😏