Unknown error detected on device

Successfully installed tensorflow with sycl support, but when I try to run some benchmarks I get errors like this one:
2019-05-01 19:15:40.179893: I ./tensorflow/core/platform/cpu_feature_guard.cc:141] Your CPU supports instructions that this TensorFlow binary was not compiled to use: SSE4.1 SSE4.2 AVX
2019-05-01 19:15:40.316940: I ./tensorflow/core/common_runtime/sycl/sycl_device.h:70] Found following OpenCL devices:
2019-05-01 19:15:40.316988: I ./tensorflow/core/common_runtime/sycl/sycl_device.h:72] id: 0, type: GPU, name: Ellesmere, vendor: Advanced Micro Devices, Inc., profile: FULL_PROFILE
 SYCL Exception: Error: [ComputeCpp:RT0301] Work-group size is invalid (The local work-group size for all dimensions exceeds the max work group size)
Error detected Inside Sycl Device.
 SYCL Exception: Error: [ComputeCpp:RT0301] Work-group size is invalid (The local work-group size for all dimensions exceeds the max work group size)
Error detected Inside Sycl Device.
 SYCL Exception: Error: [ComputeCpp:RT0301] Work-group size is invalid (The local work-group size for all dimensions exceeds the max work group size)
Error detected Inside Sycl Device.
Traceback (most recent call last):
  File "tt.py", line 164, in <module>
    session.run(tf.global_variables_initializer())
  File "/home/maximzxc/.local/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 900, in run
    run_metadata_ptr)
  File "/home/maximzxc/.local/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1135, in _run
    feed_dict_tensor, options, run_metadata)
  File "/home/maximzxc/.local/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1316, in _do_run
    run_metadata)
  File "/home/maximzxc/.local/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1335, in _do_call
    raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.InternalError: Unknown error detected on device /job:localhost/replica:0/task:0/device:SYCL:0

Can you please tell me, what does it mean and is it possible to fix?

Hi,
It seems that an invalid local work-group size is given when launching some kernel. Could you give us the output of the clinfo command? It could be that we don't handle well certain work-group sizes.
Could you also try to run the computecpp-sdk samples to check that your OpenCL driver is working as expected? In particular some operations like simple-vector-add, matrix-multiply or reduction would be interesting.

Hi, thank you for the response!
clinfo:
Number of platforms                               1
  Platform Name                                   AMD Accelerated Parallel Processing
  Platform Vendor                                 Advanced Micro Devices, Inc.
  Platform Version                                OpenCL 2.1 AMD-APP (2527.3)
  Platform Profile                                FULL_PROFILE
  Platform Extensions                             cl_khr_icd cl_amd_event_callback cl_amd_offline_devices
  Platform Host timer resolution                  <printPlatformInfo:6: get CL_PLATFORM_HOST_TIMER_RESOLUTION : error -30>
  Platform Extensions function suffix             AMD

  Platform Name                                   AMD Accelerated Parallel Processing
Number of devices                                 1
  Device Name                                     Ellesmere
  Device Vendor                                   Advanced Micro Devices, Inc.
  Device Vendor ID                                0x1002
  Device Version                                  OpenCL 1.2 AMD-APP (2527.3)
  Driver Version                                  2527.3
  Device OpenCL C Version                         OpenCL C 1.2
  Device Type                                     GPU
  Device Board Name (AMD)                         Radeon RX 580 Series
  Device Topology (AMD)                           PCI-E, 04:00.0
  Device Profile                                  FULL_PROFILE
  Device Available                                Yes
  Compiler Available                              Yes
  Linker Available                                Yes
  Max compute units                               36
  SIMD per compute unit (AMD)                     4
  SIMD width (AMD)                                16
  SIMD instruction width (AMD)                    1
  Max clock frequency                             1386MHz
  Graphics IP (AMD)                               8.0
  Device Partition                                (core)
    Max number of sub-devices                     36
    Supported partition types                     none specified
  Max work item dimensions                        3
  Max work item sizes                             1024x1024x1024
  Max work group size                             256
  Preferred work group size (AMD)                 256
  Max work group size (AMD)                       1024
  Preferred work group size multiple              64
  Wavefront width (AMD)                           64
  Preferred / native vector sizes
    char                                                 4 / 4
    short                                                2 / 2
    int                                                  1 / 1
    long                                                 1 / 1
    half                                                 1 / 1        (cl_khr_fp16)
    float                                                1 / 1
    double                                               1 / 1        (cl_khr_fp64)
  Half-precision Floating-point support           (cl_khr_fp16)
    Denormals                                     No
    Infinity and NANs                             No
    Round to nearest                              No
    Round to zero                                 No
    Round to infinity                             No
    IEEE754-2008 fused multiply-add               No
    Support is emulated in software               No
  Single-precision Floating-point support         (core)
    Denormals                                     No
    Infinity and NANs                             Yes
    Round to nearest                              Yes
    Round to zero                                 Yes
    Round to infinity                             Yes
    IEEE754-2008 fused multiply-add               Yes
    Support is emulated in software               No
    Correctly-rounded divide and sqrt operations  Yes
  Double-precision Floating-point support         (cl_khr_fp64)
    Denormals                                     Yes
    Infinity and NANs                             Yes
    Round to nearest                              Yes
    Round to zero                                 Yes
    Round to infinity                             Yes
    IEEE754-2008 fused multiply-add               Yes
    Support is emulated in software               No
  Address bits                                    64, Little-Endian
  Global memory size<PHONE_NUMBER> (7.99GiB)
  Global free memory (AMD)                        8322840 (7.937GiB)
  Global memory channels (AMD)                    8
  Global memory banks per channel (AMD)           16
  Global memory bank width (AMD)                  256 bytes
  Error Correction support                        No
  Max memory allocation<PHONE_NUMBER> (3.953GiB)
  Unified memory for Host and Device              No
  Minimum alignment for any data type             128 bytes
  Alignment of base address                       2048 bits (256 bytes)
  Global Memory cache type                        Read/Write
  Global Memory cache size                        16384 (16KiB)
  Global Memory cache line size                   64 bytes
  Image support                                   Yes
    Max number of samplers per kernel             16
    Max size for 1D images from buffer            134217728 pixels
    Max 1D or 2D image array size                 2048 images
    Base address alignment for 2D image buffers   256 bytes
    Pitch alignment for 2D image buffers          256 pixels
    Max 2D image size                             16384x16384 pixels
    Max 3D image size                             2048x2048x2048 pixels
    Max number of read image args                 128
    Max number of write image args                8
  Local memory type                               Local
  Local memory size                               32768 (32KiB)
  Local memory syze per CU (AMD)                  65536 (64KiB)
  Local memory banks (AMD)                        32
  Max number of constant args                     8
  Max constant buffer size<PHONE_NUMBER> (3.953GiB)
  Preferred constant buffer size (AMD)            16384 (16KiB)
  Max size of kernel argument                     1024
  Queue properties
    Out-of-order execution                        No
    Profiling                                     Yes
  Prefer user sync for interop                    Yes
  Profiling timer resolution                      1ns
  Profiling timer offset since Epoch (AMD)<PHONE_NUMBER>124451763ns (Thu May  2 22:25:13 2019)
  Execution capabilities
    Run OpenCL kernels                            Yes
    Run native kernels                            No
    Thread trace supported (AMD)                  Yes
    Number of async queues (AMD)                  2
    Max real-time compute queues (AMD)            0
    Max real-time compute units (AMD)             0
    SPIR versions                                 1.2
  printf() buffer size                            4194304 (4MiB)
  Built-in kernels
  Device Extensions                               cl_khr_fp64 cl_amd_fp64 cl_khr_global_int32_base_atomics cl_khr_global_int32_extended_atomics cl_khr_local_int32_base_atomics cl_khr_local_int32_extended_atomics cl_khr_int64_base_atomics cl_khr_int64_extended_atomics cl_khr_3d_image_writes cl_khr_byte_addressable_store cl_khr_fp16 cl_khr_gl_sharing cl_amd_device_attribute_query cl_amd_vec3 cl_amd_printf cl_amd_media_ops cl_amd_media_ops2 cl_amd_popcnt cl_khr_image2d_from_buffer cl_khr_spir cl_khr_gl_event

NULL platform behavior
  clGetPlatformInfo(NULL, CL_PLATFORM_NAME, ...)  No platform
  clGetDeviceIDs(NULL, CL_DEVICE_TYPE_ALL, ...)   No platform
  clCreateContext(NULL, ...) [default]            No platform
  clCreateContext(NULL, ...) [other]              Success [AMD]
  clCreateContextFromType(NULL, CL_DEVICE_TYPE_DEFAULT)  Success (1)
    Platform Name                                 AMD Accelerated Parallel Processing
    Device Name                                   Ellesmere
  clCreateContextFromType(NULL, CL_DEVICE_TYPE_CPU)  No devices found in platform
  clCreateContextFromType(NULL, CL_DEVICE_TYPE_GPU)  Success (1)
    Platform Name                                 AMD Accelerated Parallel Processing
    Device Name                                   Ellesmere
  clCreateContextFromType(NULL, CL_DEVICE_TYPE_ACCELERATOR)  No devices found in platform
  clCreateContextFromType(NULL, CL_DEVICE_TYPE_CUSTOM)  No devices found in platform
  clCreateContextFromType(NULL, CL_DEVICE_TYPE_ALL)  Success (1)
    Platform Name                                 AMD Accelerated Parallel Processing
    Device Name                                   Ellesmere

sdk samples:
➜  matrix-multiply git:(master) ✗ ./matrix-multiply 512 syscl
 Incorrect number of parameters
 Usage:
./matrix-multiply [matrix size] [omp|sycl]
[matrix size] : Size of the matrix to multiply (minimum 32)
[omp|sycl]    : Run the OpenMP or the SYCL variant.  Default is to use both
 Input matrix
C++: Time: 1142
GFLOPs: 0.235057
Success
 ***** SYCL
 The Device Max Work Group Size is : 256
 The order is : 512
 The blockSize is : 8
SYCL: Time: 51
GFLOPs: 5.26344
 Output
Success

➜  simple-vector-add git:(master) ✗ ./simple-vector-add
The results are correct!

➜  reduction git:(master) ✗ ./reduction
 SYCL Sample code:
   Reduction of an STL vector
 Device Name: Ellesmere
 Platform Name AMD Accelerated Parallel Processing
SYCL Reduction result: 717
 STL Reduction result: 717

Hi, so it seems there was indeed some issues with theses particular work group sizes (max work group size being smaller than max work item sizes). I pushed a fix in the experimental branch which will hopefully fix your issue.
Unfortunately (for you) I will be on holiday for the next 3 weeks so I won't be able to help you more until I get back!

Thanks a lot! It works like a charm now.
Hope you are having great holidays :)


Migrate from k8s.gcr.io to registry.k8s.io

This PR migrate from k8s.gcr.io to registry.k8s.io
Fixes https://github.com/kubernetes/k8s.io/issues/4780

Thanks, you'll need to bump the chart version as well. Please bump the minor version for this


Remove Maven Central badge

~Updates the Maven Central badge in the README to the new artifact coordinates.~
Removes the Maven Central badge in the README since the 4.x artifact is superseded by the 5.x artifact, which is maintained in a different branch.

Thanks a lot. Maven coordinates changed between master (version 4.x) and 5.x (version 5.x) branches. The right thing to do is removing the badge and promoting 5.x to the default branch. Care to adjust your PR to remove the badge? Afterwards, I'll apply the branch changes.

Thanks a lot!


Update deep learning guide

Typo in Optimization - pull/2124
Have two sections for Training and Inference (rather than Optimization?)

@saadrahim. Would you please merge the PR if there would be no more comments? Thank you.

@saadrahim. Would you please merge the PR if there would be no more comments? Thank you.

Hi Li,
There are still changes I would like to see. I don't need your contribution on the changes. I need to find a writer with sufficient time to add the functionality. As an example, the document name and nav organization structure of the your commit needs revision. This should be in by early next week.

@saadrahim Hi! Please re-review:

Rebased due to conflicting changes.
Uses footnotes for references.

Also removed references.md.

Renamed "Examples" to "Tutorials & Examples" in TOC.
Uses all.md filenames as is common with other directories.
Converted machine learning landing page to grids.
Minor markup improvements.


[Feature] marten evenstore add LastModifiedBy metadata

currently the normal document store supports the LastModifiedBy metadata, unfortunatly that is not possible with the event store at all. the only way is to set it as a header or something.

Why isn't it sufficient to be able to use the headers?

consistency (of course another solution would be to deprecate the other ones)
easier to index

feel free to close, if it is not suiteable


[dev] Can't  out of tags dashboard

On dev branch, <tab>ing out of tags view to the next one doesn't work anymore.
Blame: https://github.com/divmain/GitSavvy/pull/998/commits/e6445654f02a05931ba6bb8e496df7fdf3d44327
#998

Afaik fixed in 2.18.0


LOG issue

Bug description
As shown in the below's screenshot, 710144 is my total number of samples, but 100 is the batch amount. Since my batch size is 64, so I expect the total number is 710144/64=11096, I think 11096 should be at the position of 710144. Can someone explain me this? Which makes me a little bit confused.
This is the way I log during training step:
self.log('train_loss', loss, on_step=True, rank_zero_only=True)'
Thanks in advance!
JJ

`
self.log('train_loss', loss, on_step=True, rank_zero_only=True)
self.trainer.strategy.barrier()`

The progress bar doesn't show the number of samples, but just the total number of batches (the length of the dataloader). You can confirm this by printing len(train_dataloader) in your training step.
In previous versions of Lightning, it also included the validation dataloader size. I'm not sure which version you are using here.
I'm not aware of any bugs here, so if you see something incorrect, could you please provide a code example?


DOC: Punctuation should not be part of link 2

Following #240

This is delightful! @yarikoptic is very proud of all of you!


Wrong generated query with WHERE constraint following a SELECT MANY statement

It looks like the query builder of the DocumentDB .NET SDK has a bug when generating SELECT MANY with WHERE constraints
See the following model
public class Player
{
            public string Name { get; set; }
            public bool IsGood { get; set; }
            public double Skills { get; set; }
}

//root document
public class FootballClub
{
        public string Name { get; set; }
        public Player[] TeamMembers {get; set;}
}

public class ClubPlayer
{
        public string ClubName { get; set; }
        public Player Player { get; set; }
}

I am trying to retrieve the association ClubPlayer but only for the good ones so I create this query
var goodPlayers = client.CreateDocumentQuery<FootballClub>(uri)
                .SelectMany(c => c.TeamMembers.Select(f => new ClubPlayer() { ClubName = c.Name, Player = f }))
                .Where(f => f.Player.IsGood).AsQueryable().AsEnumerable().ToArray();

But the generated query is incorrect see the generated query
{"query":"SELECT VALUE {\"ClubName\": root[\"Name\"], \"Player\": f} FROM root JOIN f IN root[\"TeamMembers\"] WHERE f[\"Player\"][\"IsGood\"] "}

the Where constraint is incorrect we should have f[\"IsGood\"]
I could filter within the Where constraint like this
.SelectMany(c => c.TeamMembers.Where(f => f.IsGood).Select(f => new ClubPlayer() { ClubName = c.Name, Player = f }))`

But it prevents me from ordering or filtering with a combination of Club and Player values.
For example now my query is a bit more complex, I want to orderby descending on player Skills
Due to the wrong generated query the following does not work
 var players = client.CreateDocumentQuery<FootballClub>(uri)
                .SelectMany(c => c.TeamMembers.Select(f => new ClubPlayer() { ClubName = c.Name, Player = f }))
                .Where(comb => comb.Player.IsGood)
                .OrderByDescending(c=>c.Player.Skills).AsQueryable().AsEnumerable().ToArray();

While this one throws the error Order-by over correlated collections is not supported.
 var players = client.CreateDocumentQuery<FootballClub>(uri)
                .SelectMany(c => c.TeamMembers.Where(f => f.IsGood).Select(f => new ClubPlayer() { ClubName = c.Name, Player = f }))
                .OrderByDescending(c=>c.Player.Skills).AsQueryable().AsEnumerable().ToArray();
throws the following exception

For my case which is similar to this one. I could not use the Linq query but a brut SQL string query.

This really needs to be fixed.  Are there any updates at all on this?

This has been fixed with the latest release 2.4.0.


Refactor utils into a common folder

Description
Converts version check of 2.12 and later to give myStrongPassword123! instead of admin to a common util function and converts all semver checks to use this util function.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gaiksaya @prudhvigodithi is this what you folks had in mind? Please let me know and if not I can change this PR accordingly.

@derek-ho Do you want to move forward with this PR? Looks like it could be useful.

@derek-ho Do you want to move forward with this PR? Looks like it could be useful.

Just got back from vacation. I will hopefully get this PR fixed up by end of day.

Hi @derek-ho, can I know the status of the PR?

@Divyaasm I think it is ready for review - I got kind of confused with the direction the build team wants me to go with the logic in the benchmark_test_cluster.py file, but everything else should be fine and I cleaned up that file to what makes sense to me. Can you leave some more feedback or merge if it looks good?

@Divyaasm seems like you merged in something similar recently. Should I close this out?

Hi @derek-ho, The changes are to make src/test_workflow/integ_test/utils.py more flexible. You can still refactor the code in benchmark_test workflow to re-use the get_password method from utils.py

Hi @derek-ho seems like this PR is outdated now.
Closing now and please feel free to re-open.
Thanks.


vim plugin: support nushell

Checklist

[X] I have read through the manual page (man fzf)
[X] I have searched through the existing issues
[X] For bug reports, I have checked if the bug is reproducible in the latest version of fzf

Output of fzf --version
0.56.0 (brew)
OS

[ ] Linux
[X] macOS
[ ] Windows
[ ] Etc.

Shell

[ ] bash
[ ] zsh
[ ] fish

Problem / Steps to reproduce
I am using nushell, which is not working properly with the fzf vim plugin.
Specifically, the vim systemlist call fzf --version --no-height in is this file is giving an error because the fzf command is passed to shellescape before being passed into systemlist.
Setup:
I have $SHELL == 'User/jasha/.cargo/bin/nu and have set 'shell' and 'shellxquote' to appropriate values.

I've created PR #4067 to address this issue.


Use more specific name for mandatory plugin check selectively

Commit 7a051f337d419f14a1223c2a1514b57a53a34037 reverted the use of a
more specific plugin name for the mandatory plugin
check (e.g. specifying mandatory.plugin=x-pack instead of
``mandatory.plugin=x-pack-security`), however, more specific names are
still required for benchmarking release versions <6.3.
Selectively use a more specific name for the mandatory plugin check
depending on the Elasticsearch version.
Also add test cases for both scenarios.
Relates: 7a051f337d419f14a1223c2a1514b57a53a34037
Relates: https://github.com/elastic/elasticsearch/pull/28710

@danielmitterdorfer I addressed the comments, could you please have a look again?


unfortunately the latest Valhiem patch prevents SimpleRecycling from working

Hello,
Unfortunately the latest Valhiem patch prevents SimpleRecycling from working at all.  It's a great mod and I hope someone is able to fix/update it.
Thanks,
Chend0w

someone already posted the issue.  Closing this ticket


Mac with configured default RecipeCreateLocation that doesn't exist causes failure

Describe the bug
When a fresh Mac has autopkg & Recipe Robot installed but the default RecipeCreateLocation directory path does not exist, produces error.
To Reproduce
Steps to reproduce the behavior:

On Mac with autopkg & recipe robot, delete the RecipeCreateLocation key from ~/Library/Preferences/com.elliotjordan.recipe-robot.plist
Delete the default folder path from system
Have Recipe Robot attempt to create recipes for an item
See error

Expected behavior
A message indicates that the folder doesn't exist, or Recipe Robot automatically creates this path for the user.
Screenshots

Desktop (please complete the following information):

macOS: 10.15.7
Recipe Robot Version: 2.2.0
autopkg version: 2.2
/usr/local/autopkg/python --version: Python 3.7.5

Hi @apizz - Thanks for reporting this. Could you check the output you get for:
defaults delete com.elliotjordan.recipe-robot Initialized

~ > defaults read-type com.elliotjordan.recipe-robot Initialized                                                                                255 19:09:25
Type is boolean

~ > defaults read com.elliotjordan.recipe-robot Initialized                                                                                19:07:00
1

I did some more testing and confirmed that if RecipeCreateLocation value is present but folder doesn't exist that it will create the folder.
Error was slightly different in most recent testing.

~ > defaults read-type com.elliotjordan.recipe-robot Initialized                                                                                255 19:09:25
Type is boolean

~ > defaults read com.elliotjordan.recipe-robot Initialized                                                                                19:07:00
1

I did some more testing and confirmed that if RecipeCreateLocation value is present but folder doesn't exist that it will create the folder.
Error was slightly different in most recent testing.


[DO-287] Add x-button to the "Filter" field so that it can be easily emptied

For example, like in a lot of search fields (e.g. Google search), there is an "x"-button to delete filter/search phrase
From SyncLinear.com | DO-287

Can be done with using type="search" for the input, however it doesn't work in firefox right now https://bugzilla.mozilla.org/show_bug.cgi?id=1654288


AssertionErrors may occur

At line : https://github.com/nortxort/pinylib/blob/master/rtmp/rtmp_protocol.py#L539
You have specified that when receiving any user control message we should assert the STREAM_BEGIN UserControlTypes. This will not hold true if the packet is anything else i.e. PING_REQUEST/PING_RESPONSE. I just received an error since the bot uses the ping request at intervals. This could be changed possibly.
.EDIT: I think if you just change the line to read:
elif amf_data['msg'] == data_types.USER_CONTROL and amf_data['event_type'] == user_control_types.STREAM_BEGIN:
it should then work and not return an AssertionError if anything other than STREAM_BEGINs are encountered. Though an AssertionError will still occur as the packet is not handled, so we just need a way of handling packets which are new or unknown without receiving assertion errors. Maybe the handle packet call could be moved elsewhere in the _callback function?

elif amf_data['msg'] == data_types.USER_CONTROL and amf_data['event_type'] == user_control_types.STREAM_BEGIN:
And/or if your not doing anything particular with the PING_RESPONSE you could add
elif amf_data['msg'] == data_types.USER_CONTROL and amf_data['event_type'] == user_control_types.PING_RESPONSE:
return True

Didn't see your edit before after posting. If a new or unknown packet causes assertion error, then a new elif  will be added inside the handle_packet method. rtmp_protocol worked on both tinychat and that other site with no changes made. Both clients use handle_packet in the same way in the _callback, so i don't actually think it will be a issue.

Sure, thanks.


Link to thoughtbot's contributor code of conduct

Looks good to me!

No objections here, feel free to merge.


purge_seq should be String not int according to docs of 2.3.1

See: https://docs.couchdb.org/en/stable/api/database/common.html

Fixes https://github.com/helun/Ektorp/issues/290

Your changes are not complete yet. The code does not compile, unit tests also have to be fixed.

@Ruudieboy Sorry, seems to work now

Unable to use change feeds without this fix. @Ruudieboy When it's possible to merge?

Any updates on this?

Any updates on this?


valid AST? Escodegen with markdown-to-ast

I've tried using escodegen to parse the AST output from markdown-to-ast, but it fails.
Is markdown-to-ast valid AST?

markdown-to-ast is a implementation of TxtAST and Unist.
It is not JavaScript AST well-known as ESTree.
escodegen only treat JavaScript AST.

I've tried using escodegen to parse the AST output from markdown-to-ast, but it fails.

So, It it expected behavitor.
FYI: If you want to get Markdown parser/generator, use directly https://github.com/wooorm/remark.

Ah ok. Thanks for the explanation.


problem in the code bro

Backend code is not working with frontend .I tried so many times. Bro check the code properly.

Hello,
It was an issue with the api endpoit port. It should have been http://backend:8080/predict/ rather than http://backend/predict/ in Diet-Recommendation-System/Streamlit_Frontend/Generate_Recommendations.py. Nevertheless, if you are running front end and backend directly on your machine, you should change the endpoit to http://your_ip:8080/predict/.

bro i can't understand can you explain and can you give commands to run the code

I corrected the issue so you have to retry the setup part https://github.com/zakaria-narjis/Diet-Recommendation-System#whale-again


Can't change storage class

Can you please provide examples on supported storage classes?
I tried "One Zone-IA" and it was throwing out errors saying it's unsupported

All good. Found it in the code: https://github.com/gdrapp/hass-addons/blob/master/amazon-s3-backup/rootfs/usr/bin/amazon-s3-backup/config.py#L14


[ROCm] float8 does not work

Hi @hongxiayang @hliuca ,
It seems like float8 training using torchao.float8 is not support at the moment. Is there a different library or code path I should be using for float8 training or what the timelines around ROCm supporting torchao.float8?
Attempting Install From Nightly
From using the ROCm nightly torchao wheel, the torchao.float8 module is not present
pip3 install --pre torch --index-url https://download.pytorch.org/whl/nightly/rocm6.2
pip install --pre torchao --index-url https://download.pytorch.org/whl/nightly/rocm6.2
python -c "import torchao; print(dir(torchao))"
['__all__', '__builtins__', '__cached__', '__doc__', '__file__', '__loader__', '__name__', '__package__', '__path__', '__spec__', 'apply_dynamic_quant', 'apply_weight_only_int8_quant', 'dtypes', 'kernel', 'quantization']

Attempting Install From Source
From installing from source, I run into an triton datatype issue. If I disable torch.compile, then i run into the eager mode fp8 dtype not being the AMD format but the Nvidia fp8 format.
pip3 install --pre torch --index-url https://download.pytorch.org/whl/nightly/rocm6.2
pip install git+https://github.com/pytorch/ao.git

Eager Mode Error
   tensor_out = addmm_float8_unwrapped(
  File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torchao/float8/float8_python_api.py", line 55, in addmm_float8_unwrapped
    output = torch._scaled_mm(
RuntimeError: false INTERNAL ASSERT FAILED at "../aten/src/ATen/hip/HIPDataType.h":102, please report a bug to PyTorch. Cannot convert ScalarType Float8_e4m3fn to hipDataType.

Compile Mode Error
    tmp15 = 448.0
    tmp16 = triton_helpers.minimum(tmp14, tmp15)
    tmp17 = tmp16.to(tl.float8e4nv)
            ^

Set TORCH_LOGS="+dynamo" and TORCHDYNAMO_VERBOSE=1 for more information

You can suppress this exception and fall back to eager by setting:
    import torch._dynamo
    torch._dynamo.config.suppress_errors = True

Reprod Script is From The torchao.float8 README Example
import torch
import torch.nn as nn
from torchao.float8 import convert_to_float8_training

# create model and sample input
m = nn.Sequential(
    nn.Linear(2048, 4096),
    nn.Linear(4096, 128),
).bfloat16().cuda()
x = torch.randn(4096, 2048, device="cuda", dtype=torch.bfloat16)
optimizer = torch.optim.SGD(m.parameters(), lr=0.1)

# optional: filter modules from being eligible for float8 conversion
def module_filter_fn(mod: torch.nn.Module, fqn: str):
    # don't convert the last module
    if fqn == "1":
        return False
    # don't convert linear modules with weight dimensions not divisible by 16
    if isinstance(mod, torch.nn.Linear):
        if mod.in_features % 16 != 0 or mod.out_features % 16 != 0:
            return False
    return True

# convert specified `torch.nn.Linear` modules to `Float8Linear`
convert_to_float8_training(m, module_filter_fn=module_filter_fn)

# enable torch.compile for competitive performance
m = torch.compile(m)
# toy training loop
for _ in range(10):
    optimizer.zero_grad()
    y = m(x)
    y.sum().backward()
    optimizer.step()

Can you make sure to set: https://github.com/pytorch/ao/blob/e7b33bc91c831d10249c1222c8b4b667f18f28b7/torchao/float8/config.py#L246 to True

Here are my thoughts on what we need to do to enable ROCm support for float8:

ensure torch._scaled_mm's path for ROCm is fast an accurate
there is a config setting for the nuz float8 flavors here (https://github.com/pytorch/ao/blob/0b71b8d38f6b238e510876bf2d75b4280a651175/torchao/float8/config.py#L246), but it's not tested at the moment.  We should enable testing across all of our test suite, first locally and then in CI.
get e2e performance/accuracy to be good, measured by benchmarks on real workloads

#1142 might help partially fix this by automating the setting of these types depending on the hardware deteted.

@OrenLeung please install latest torchao and try again.  #1142 was reverted but #1150 (reland) merged.

Do we close this issue now that #1150 is merged?

@jeffdaily Have you verified that the existing fp8 routines work on ROCm? Unfortunately we still dont have ROCm runners in CI/CD and at least personally dont have much access to RoCM machines to test

I think "done" here would mean that we have float8 training working on ROCm with compelling reproducible perf/accuracy benchmarks that we can communicate.  I don't feel strongly if that should be tracked in this issue or a higher level issue - if you prefer to close this one, happy to track this elsewhere.

@vkuzo I'd look into this. Do you have particular workloads in mind? I'd love to leverage your training scripts for apple-to-apple comparison.

@vkuzo I'd look into this. Do you have particular workloads in mind? I'd love to leverage your training scripts for apple-to-apple comparison.

Awesome!
For microbenchmarks, we have a couple of representative benchmarks where it would be great to measure how float8 gemm compares to bfloat16 on ROCm:

https://github.com/pytorch/ao/blob/main/benchmarks/float8/bench_matmul.py for benchmarking only torch._scaled_mm
https://github.com/pytorch/ao/blob/main/benchmarks/float8/bench_linear_float8.py for benchmarking torch.nn.Linear, which includes casting/scaling

For multi GPU real training runs with float8 on LLaMa model variants, we have been using https://github.com/pytorch/torchtitan, having good ROCm numbers there would be fairly representative of real workloads
Let me know how I can help!

If https://github.com/pytorch/pytorch/pull/140856 lands we're closer to fully passing ao's unit test suite.  That PR only works for e4m3 currently.  I'll either fix it up to also allow e5m2 or do a follow-up PR.  There are a handful of ao UTs that expect to use e5m2 rowwise gemm.


add environment.yml, binder link

This adds the environment.yml used at JupyterDay Atlanta such that binder can find it, and a direct link to the /lab endpoint through the deep-linking mechanism. Exactly what else one would want in the binder environment remains to be seen!
Here's my one built off this:
http://mybinder.org/repo/bollwyvl/jupyterlab/lab
(the PR has the correct repo)
It only runs off master, and does have to be updated each time a new conda-forge release is cut, but as it is provides a pretty good experience.
Fixes #659.

:tada:

Thanks!

@bollwyvl, I released 0.2 on conda-forge, and triggered a build, but I'm getting "could not build image jupyter-jupyterlab: Error: build failed for imageName: jupyter-jupyterlab"
http://mybinder.org/status/jupyter/jupyterlab

Re-kicked it, and it appears good to go!

Confirmed, thanks!


Feature/item question feedback

Add better feedback to parsons questions.

I don't think we gain enough from this to go forward any longer. Closing, but not deleting the branch in case we review later on!


[ACS][CallAutomation][Answer]update autorest to update Answer api with custom context

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.


[newArch] Crash when going back from a view that has PagerView

Environment
Only on Android.
    "react-native": "0.76.3",
    "react-native-pager-view": "^6.6.0",

Description
Hello,
When I go back from a view that has PagerView, the application crashes.
It appears with react-native new architecture, I don't reproduce this problem when new arch is not activated.
This problem has appeared since the 6.6.0 version.
Reproducible Demo
https://github.com/TomCorvus/RNavigation
Fatal Exception: java.lang.IllegalArgumentException: Scrapped or attached views may not be recycled. isScrap:false isAttached:true androidx.viewpager2.widget.f$m{306a6fa VFED..... ......ID 0,0-1080,1766 #6}, adapter:com.reactnativepagerview.i@4e728ec, layout:androidx.viewpager2.widget.f$h@2adbdbc, context:com.facebook.react.uimanager.C0@e204f60
       at androidx.recyclerview.widget.RecyclerView$Recycler.recycleViewHolderInternal(RecyclerView.java:7071)
       at androidx.recyclerview.widget.RecyclerView.removeAnimatingView(RecyclerView.java:1597)
       at androidx.recyclerview.widget.RecyclerView$ItemAnimatorRestoreListener.onAnimationFinished(RecyclerView.java:13655)
       at androidx.recyclerview.widget.RecyclerView$ItemAnimator.dispatchAnimationFinished(RecyclerView.java:14157)
       at androidx.recyclerview.widget.SimpleItemAnimator.dispatchRemoveFinished(SimpleItemAnimator.java:286)
       at androidx.recyclerview.widget.DefaultItemAnimator$4.onAnimationEnd(DefaultItemAnimator.java:216)
       at android.view.ViewPropertyAnimator$AnimatorEventListener.onAnimationEnd(ViewPropertyAnimator.java:1112)

Thank you.

https://github.com/callstack/react-native-pager-view/releases/tag/v6.6.1

Hi, I've noticed that the error is still in v6.6.1.

@marcoamt could you provide repro steps ?


fix: playing state/stream updates & compatibility with libmpv 0.28.x

This was one regression in last pull-request #90.
Having compatibility with older libmpv versions is a concern for GNU/Linux, you never know what people may install...


howto scale image with different aspect ratio

I want to provide images with complete different and unknown aspect ratios and sizes in Mailjet templates.
In top of the template I've got a paragraph to place the image. It should fit the place in optimal matter and keep it's aspect ratio.
Example:
https://mjml.io/try-it-live/f_KCXBYyWTz
The SWLB logo looks nice in the first version, but not acceptable in the second one.
And vice versa for the KIWIGRID logo.
It seems there is no proper solution for this?

There's no way to do so as mj-image rely on width (that need to be defined as pixel not percent as you've done) to handle older Outlook Desktop versions.
You can try to use HTML img tag within mj-text and hope that you won't have any overflow issue in older clients.


Changed favicon with base on notebook status

https://user-images.githubusercontent.com/30236552/137034419-41d2dbc8-dee0-4850-a91a-6b7d84c47b69.mp4
I added the icons temporarily as this is just an idea, they might have to be redrawn.
I thought of following the colors of the current status of the elixir cell

but while it's loading the color is blue and when it's finished it's green, and these colors in the favicon you can hardly see the changes.
And in case of error, the status of the elixir cell is displayed in green color.
Because of this, the result was:

Color
Status

Yellow
Loading

Gray
Stopped

Red
Error

Green
Completed

issue #586

I played with the icon a bit, maybe it's not that similar after all?

Btw. we actually don't need the red one, because the global indicator is never aborted either.
But the more I think about it, the more I like just having blue when in progress and regular icon otherwise. When someone is on a different tab, the only relevant information is whether the computation finished or not.

Hmm, but the red indicator is not related to error actually. It indicates aborted cell, which is either if the user explicitly stops evaluation or the runtime randomly dies (which is fairly unlikely).

What if instead of using the dot, which associates with the indicator, then we use an x like GitHub? this way people won't think they are the same? Should we also use x for aborted/runtime crashed?

Alright, let's go with only blue and yellow for now then. :)

I've just updated the icon, ftr here's how it works:
https://user-images.githubusercontent.com/17034772/137210097-a845a8e5-5d50-4b1c-a01b-1160fc8d1a74.mp4

Thanks @jeantux!


⚠ Bofrost.at has degraded performance

In 4c494f6, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2046 ms

Resolved: Bofrost.at performance has improved in d61909e.


Some questions about Attention weights

Hello, thanks for sharing your excellent work!
May I ask how to get the attention weights for each edge? I want to try to draw Figure 3 ( Left ).
Another question is about using directed graphs for anomaly localization. As mentioned in the paper, 1_FIT_001_PV is the attacked object, and 1_MV_001_STATUS is detected as abnormal, and we are checking the weight of the edge pointed to 1_MV_001_STATUS (neighbor-->1_MV_001_STATUS). Do we need to check edges (1_MV_001_STATUS-->neighbor) which have high attention weights? Is this the point of the model using a directed graph?
Thank you very much!

You could refer to the previous issue #30 for the attention weight visualization.
We take it as a directed graph. Yes, you could use the first setting you mentioned: using the abnormal sensor as the target and trace back the neighbors.

Thanks a lot for your answer!


Fix to unresovable imports

write_decimal has been added since eosio.cdt v1.6.3 to stringify asset amount, but it causes a failure on legacy-server.wasm of history-tools. (Unresolvable imports like set_blockchain_parameters ..., in eosio.cdt/libraries/eosiolib/eosiolib.cpp, are added to binary)

#33 adds write_decimal to eosiolib. This issue should be resolved before release.


Correct switch fallthrough warnings

GCC 7.3.0 gave the following warning:
src/pugixml.cpp:10193:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
without these attributes.

Which pugixml version were you building? This should have been fixed in #134 (using comments as opposed to attributes that have portability issues)

Oh, I see. I had compiled against "latest" (which now is pointing to v1.8). Right, there were comments, but I see #134 adjusted them so that the compiler can see them properly. I'll use the code at master instead. Thanks!


Table sort column APIs

Description
Sorted column can be accessed using sortOrder table widget api. Add onSort action that lets user trigger an action whenever column sorting is changed
Fixes #5906
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:red_circle: Total coverage has decreased
// Code coverage diff between base branch:release and head branch: feature/table-sort-column-properties

Status
File
% Stmts
% Branch
% Funcs
% Lines

:red_circle:
total
54.62 (0)
36.65 (-0.03)
33.05 (0.01)
55.23 (0.01)

:green_circle:
app/client/src/components/designSystems/appsmith/TableComponent/Constants.ts
85.48 (0.73)
73.53 (1.65)
91.3 (0.39)
85.48 (0.73)

:red_circle:
app/client/src/utils/autocomplete/TernServer.ts
50.47 (-0.24)
37.72 (-0.88)
36.21 (0)
55.08 (-0.27)

:red_circle:
app/client/src/widgets/TableWidget/derived.js
54.26 (0)
53.57 (-2.68)
37.84 (0)
54.07 (0)

:green_circle:
app/client/src/widgets/TableWidget/index.tsx
27.71 (0.07)
6.25 (-0.04)
25.49 (0)
27.9 (0.08)

@vicky-primathon Functionality is working fine but can you please add tooltip for sort property.

@vicky-primathon can you merge the latest release as well and check for the the failing test cases?

@vicky-primathon Tooltip is also fixed.

Rerunning all tests, Unrelated failures found.
@vicky-primathon please assert.

/ok-to-test sha=a8e98c2

@vicky-primathon Testing in-progress for this feature and please find the observations below

asc:true or asc:false key and value should not be displayed when the table column is bind-ed with text widget

Text Widget - Label field - {{JSON.stringify(Table1.sortOrder)}}

2.By default when the table's column and order is sorted and stored in a text widget - 'undefined, undefined' key and value is displayed

@vicky-primathon Verified this PR and it is working as expected

@vicky-primathon Issue 1 and 2 now exists in release environment


Add Lab 01 problem and solution from class F

Lab01_F.md: Include only the instructions and hints from lab01_ddp2017.pdf
Lab01_F.py: Solution by Giovan Isa Musthofa

Thanks!


feat(connection): ALPN protocols support

PR Checklist
If you have any questions, you can refer to the Contributing Guide
What is the current behavior?
No support for setting ALPN Protocols
Issue Number
Example: #916
What is the new behavior?
Support for setting ALPN Protocols
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Specific Instructions
Are there any specific instructions or things that should be known prior to review?
Other information

@twankamp Thank you so much for the PR! We truly appreciate your contribution. However, could you provide more detailed documentation or descriptions regarding this feature update? It would be great if you could update the documents or provide usage steps and screenshots within the PR.
Additionally, is ALPN a widely adopted capability? I'm uncertain if its application is exclusive to AWS or if it's also common elsewhere.
Looking forward to your updates!

@ysfscream certainly

This feature is applicable if you are using a TLS connection (so e.g. MQTTS or WSS) and the server needs the client to specify ALPN protocol for connecting. In that case when you select SSL/TLS in the MQTTX desktop app, it will unfold extra options like SSL Secure and Certificate, and in there now also ALPN is added. Then you simply specify the desired ALPN protocol in that field alongside all other parameters you need, then click connect and it will work. Note that officially ALPN can be an array but that is an extremely niche use-case so I didn't want to mention about it to avoid confusion. However just in case if the user specifies multiple protocols in a way like p1,p2 or something like [p1, p2 ] then I made sure it will work as well.

This is a universally recognized capability, it doesn't have anything specific to do with AWS - I think the person in the feature request #916 (whom I don't know) just used it as an example. This feature is often used to improve performance if you host multiple protocols on the same port (for example a broker that supports both mqtts and wss on 443, or a reverse proxy that covers both an https and mqtts server). Even the library you use (mqtt.js) already supports it out of the box, so the only thing I did was expose it in the UI so users of the desktop app can actually use it. Other clients use it as well (e.g. https://mosquitto.org/man/mosquitto_pub-1.html), but the benefit of your app is that it has a GUI.

@twankamp A huge thanks for your contribution! 🚀 We're excited to roll this out in our upcoming release.


HMAC-SHA256 signature support

Is there a way to add HMAC-SHA256 support to the CoreOAuthSignatureMethodFactory class? Currently only Plaintext and SHA1 are supported.
I would think the added support of SHA256+ would be a priority since SHA1 hasn't been considered standard in years.

Hi is there any update on this? We are facing the same.


[REQUEST] A variable to hold CLIPBOARD content

Is your feature request related to a problem? Please describe.
Currently, OB does not have access to clipboard content. It would be beneficial to have a variable that holds it so we can use clipboard content.
Describe the solution you'd like
A variable named for example CLIPBOARD which holds clipboard content and is accessible via <CLIPBOARD>
Additional context
Sometimes in selenium pipelines, we copy some data by clicking buttons but there is no way to access its value as is copied to clipboard.

No it would not be beneficial. Maybe a user copied some sensitive banking information and through automation a malicious third party can retrieve those and send a request to his server to collect the info. I will not do this, if you have a secure way to do this then feel free to explain further.

Oooow, I didn't see that from the security point of view but it seems, implementing it would make OB vulnerable! Thank you for mention it. Of course, implementing it in a secure way remains a question! Right now I'm also answerless. Maybe others could help with this. watching out whether others need this feature and could come up with a secure solution ...


issue #197 use JsonBuilder and JsonReaderFactory to improve performance

Signed-off-by: Albert Wang<EMAIL_ADDRESS>

not sure if it's related, but I did find that the integration tests finished within 2 minutes which seems faster than before.


DOCKER-311 Raise requirements for chown in 90-init-alfresco.sh

Recent experience has pointed out that mounting a large, existing
alf_data with incorrect permissions/ownership resulted in a very
extensive chown. The prefered solution would have been to fix the issue
through changes to the users/groups on the host, or even to the user
set in the image/container.
This change adds an additional check on permissions, and a check on
whether the alf_data folder is too big to be effeciently chowned. The
size check is set to 10000 items in the dir by default, but can be changed through
an environment variable.
The change will allow the acting operator to decide on the correct solution

I don't think it is a good solution to pick an arbitrary value for when to chown or not.
The chown is already there for a long time (I lost track of it in a commit from 2017), so the question is what purpose does it serve?
Starting up Alfresco with a non-writable contentstore is bad, because everything will work fine until new content is created, which fails. This will only be discovered some time after the system is started up, which is bad.
To resolve this problem, I see 2 options:

chown everything on startup when permissions are incorrect
check permissions and exit with an error when permissions are incorrect

Doing different actions based on the amount of content that is present may lead to unexpected behavior, and this construction looks considerably more complex.

I don't think it is a good solution to pick an arbitrary value for when to chown or not.
The chown is already there for a long time (I lost track of it in a commit from 2017), so the question is what purpose does it serve?
Starting up Alfresco with a non-writable contentstore is bad, because everything will work fine until new content is created, which fails. This will only be discovered some time after the system is started up, which is bad.
To resolve this problem, I see 2 options:

chown everything on startup when permissions are incorrect
check permissions and exit with an error when permissions are incorrect

Doing different actions based on the amount of content that is present may lead to unexpected behavior, and this construction looks considerably more complex.

When we discussed this IRL I also said this: do not check, bail out early with an error. Maybe that wasn't clear enough. The responsibility should be left with the caller, not the script IMO.

I can see how removing the check on content can simplify the script, but it removes the old behaviour completely, and I think it could lead to frustration in dev and test environments?

Not doing a chown may indeed be a problem when starting a fresh Alfresco with a volume, which is used all the time during development.
To make that work, we may need to chown just the root folder. The content store is an empty folder at that point in time.
However, if we do a chown on the root folder, we lose the ability to detect the content store ownership problem on the next startup.
I did not test this scenario out, but please do when you make changes.

I don't think it is a good solution to pick an arbitrary value for when to chown or not.
The chown is already there for a long time (I lost track of it in a commit from 2017), so the question is what purpose does it serve?
Starting up Alfresco with a non-writable contentstore is bad, because everything will work fine until new content is created, which fails. This will only be discovered some time after the system is started up, which is bad.
To resolve this problem, I see 2 options:

chown everything on startup when permissions are incorrect
check permissions and exit with an error when permissions are incorrect

Doing different actions based on the amount of content that is present may lead to unexpected behavior, and this construction looks considerably more complex.

When we discussed this IRL I also said this: do not check, bail out early with an error. In other words, Lars' 2nd solution. Maybe that wasn't clear enough.
The responsibility should be left with the caller, not the script IMO.

Comments on the ticket deviate.
I guess I'll simplify.

Comments on the ticket deviate.
I guess I'll simplify.
If it's too unclear, we can always do a quick call

Looks good to me :shipit: but I'll leave the official approval to docker peeps.


Complex method call with -barewords generates bad code

Complex method call with -barewords generates bad code.  For example (from CGI.pm):
return $self->header(
-nph => 0,
-type => $type,
-charset => $charset,
(map { split "=", $_, 2 } @other),
) . "WARNING" . $self->multipart_end;

Fixed  in v1.019


[HUDI-4509] filter out files not exist

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request
When I read hudi table with spark readStream, FileNotFoundException happens after a while. This happens when a compaction happens and completes quickly while reading, deleting the file that was being read. Details I described at jira ticket.
The code I read hudi
    val df: DataFrame = spark.readStream.format("org.apache.hudi")
      .load("hdfs://<IP_ADDRESS>:8020/tmp/hudi/ss_bucket")
    df.writeStream
      .format("console")
      .trigger(Trigger.ProcessingTime("5 seconds"))
      .option("checkpointLocation", "/tmp/hoodie/checkpoint_xicm")
      .start()
      .awaitTermination()

It seems that there is no mechanism to ensure no compaction while doing incremental read.
Because of the checkpoint the job can't succeed even after a restart.
This pr filter files not exist to make stream read successful after a spark retry.
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

This fix is not good, is there any advice I can go into?

Maybe this is what you need: https://github.com/apache/hudi/pull/6141

Maybe this is what you need: #6141

Hi @danny0405 , thanks for your help.
Alse check with you, can https://github.com/apache/hudi/pull/6096 solve the FileNotFoundException in flink stream read?

https://github.com/apache/hudi/blob/c72d895fed4b8f0ca899f15ff07d3446143811ac/hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java#L319-L323
When I look into #6096 , I find a typo spillableMapPath, do we need to fix this?

Will be fixed by https://github.com/apache/hudi/pull/6141

Will be fixed by https://github.com/apache/hudi/pull/6141

Maybe this is what you need: #6141

Hi @danny0405 , thanks for your help. Alse check with you, can #6096 solve the FileNotFoundException in flink stream read?

No, #6090 would only solve the incremental read for batch mode.


Dashboard offline access

Make dashboard offline-able by using service workers & smart caching. Should enable instant booting of the app.

[ ] Use postmessage from browser extension into iFrame with user current location
[ ] Make user current location non-blocking of main app UI (move to SelectedPlaceComponent)
[ ] Cache /places in localstorage

✅


Role nodes-config playbook fails when any host is in reboot state

The issue happens when all nodes do not boot at once. For example, if master-1 is booted and available with ssh connection and master-2 delays ssh connection (say after 5 mins). Till the time all masters ssh connection check is complete master-1 may go into reboot state (via machineconfig). Playbook exits during such scenarios with 'unreachable' error for master-1.
Need to figure out a way for hosts not to wait for other nodes' ssh connections and run shell commands as soon as ssh is available for a particular host.

@Prajyot-Parab any update? The fix will be critical for release-4.5 and master branch.

@yussufsh using strategy: free in the playbook achieves the required parallelism but it also results in additional error handling requirement as any_errors_fatal: true is not supported with strategy: free, I am still exploring on how to do error handling in this scenario.

Going with serial: 1 option here which will wait and execute commands on the rhcos nodes one by one.


added daily read feature

Pull Request Checklist

[ ] I have added screenshots and videos to show before and after the working of my code.
[yes ] I have ensured that the screen size is set to 100% while making the video.
[yes ] I have synced the latest fork with my local repository and resolved any conflicts.
[yes ] I have mentioned the issue number which I created before making this PR .(format to mention issue number is : fixes #1717
[ yes] I understand that if any the above conditions are not met , my PR will not be MERGED .

hey , great job , but instead of implementing this in in the navbar can you find some other space ? maybe near word of day section or newsletter section ? or on some other page ? im open to your input on the same !

kindly fix and make a new PR , sync fork as well


Mixed content warnings when loading some referrers favicon

My install runs over https, and I noticed a Mixed Content Warning in my browser (Firefox). After some investigation I tracked this down to the favicon of a referrer which used the http protocol. My browser blocked this icon and the default images is shown in the install but wanted to mention it here.

I'm not sure what the best solution is, perhaps checking to see if it can be loaded over https and if not falling back may make the most since but that complicates the logic a bit.  Another solution could be to force https but that would surely break some favicons.

I don't think this is problematic. The favicons are just visual enhancements. Ackee is also just guessing that there's a favicon at /favicon.ico which isn't always the case.
Upgrading them to https: Could work, but when the referrer is http than there's a small chance that the site is available via the https (would be a badly configured server in this case).

According to MDN this is type of warning from the browser is known as a passive mixed content warning. The biggest risks appears to be revealing the URL and allowing some tracking of an otherwise private Ackee install to the third-party site:

The attacker could also infer information about the user's activities by watching which images are served to the user; often images are only served on a specific page within a website. If the attacker observes HTTP requests to certain images, they could determine which webpage the user is visiting.

I looked into a few solutions and found a node package favrat  as well as some solutions in other languages. It seems in most cases the idea is to cURL the site, see if there's a favicon and you get a 200 response then do something with the icon.
By far the easiest method is to use the Google API but we should keep Google out of Ackee by all means :)
http://s2.googleusercontent.com/s2/favicons?domain_url=http://github.com
Let me know if I can be of any other assistance here.

The solutions aren't very satisfying, so I will stay with the current implementation. I don't think that revealing the URL of the Ackee instance is problematic enough.

Thanks for the update here. I found an easy way to prevent this (but also not show icons at all over HTTP) is to add the following to the NGINX config:
        add_header          Content-Security-Policy "block-all-mixed-content";
I totally get wanting to show icons over http so blocking things at the server level seems like a good way for users, like me, who would rather not show mixed content warnings and instead always have https.


[Cloud] Perform cloud discovery with API Version 2022-09-01 and support dataplaneEndpoints for Azure Stack

Related command
az cloud
Description
Close https://github.com/Azure/azure-cli/issues/25815
Testing Guide
Populate dataplaneEndpoints from metadata:
az cloud register -n mycloud --endpoint-resource-manager https://management.azure.com/

Populate dataplaneEndpoints from local cloud config JSON file:
az cloud register -n mycloud --cloud-config @D:\cloud\cloud-config.json

Cloud enhancement

Although the main post mentioned that a new nested group called dataplaneEndpoints is being supported, there should also be support for new suffixes and endpoints that is not passed by a cloudconfig.json file. Currently, Azure CLI is using a deprecated method to populate the hard-coded metadata which should be updated to read all endpoints and suffixes:
https://github.com/Azure/azure-cli/blob/091c6b1c40c19d4076376f9dfa0d4994b291a7c6/src/azure-cli/azure/cli/command_modules/cloud/custom.py#L69
https://github.com/Azure/msrestazure-for-python/blob/8e3def8c9927a349596e575de93df76de7a3a2b6/msrestazure/azure_cloud.py#L204

@jiasli

If these new suffixes and endpoints are not passed by a cloudconfig.json file, how will Azure CLI even know them?
The new endpoints and suffixes will appear in the metadata endpoint URL.

Reading all endpoints and suffixes is simply against our modeling principal which enforces all endpoints to be an attribute of the cloud object.
Is there a reason there is an exception made for reading all endpoints and suffixes from the cloudconfig.json but not from the metadata endpoint?
For example, the following code just adds all endpoints from cloudconfig.json:
https://github.com/Azure/azure-cli/blob/091c6b1c40c19d4076376f9dfa0d4994b291a7c6/src/azure-cli/azure/cli/command_modules/cloud/custom.py#L46

Is there a reason there is an exception made for reading all endpoints and suffixes from the cloudconfig.json but not from the metadata endpoint?

I didn't write that code, but I guess it is because cloudconfig.json is designed/used specifically for Azure CLI. On the other hand, metadata endpoint is merely a supplemental way to extract information we want.

@jiasli Bumping this.
FYI 2022-09-01 is a breaking change for the metadata endpoint. Prior versions returned a JSON array of cloud endpoints for multiple environments. This version returns a single JSON object for the endpoints associated with the ARM instance being queried.
Is the goal to support both schemas with this for backwards compatibility?


[Inline] Install when necessary

The RubyGems change just means setting remote! will always cause specs to be fetched remotely
\c @indirect

yesssssssssssssssssssssssssssssssssssss
@homu r+

:pushpin: Commit ec75943 has been approved by indirect

:hourglass: Testing commit ec75943 with merge 6ce55fd...

:sunny: Test successful - status


fix: add example pairing support

:tada: This PR is included in version 1.0.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Make external CA support more generic

The existing external CA support implies the use of the CFSSL protocol.
This change makes ExternalCAs a list of structs instead of strings. Each
struct specifies the type of the external CA (currently, only CFSSL is
supported). In the future we may add other items to this struct such as
options.
cc @jlhawn @diogomonica @jefferai @stevvooe

[Current coverage][cc-pull] is 54.33%

Merging [#1101][cc-pull] into [master][cc-base-branch] will increase coverage by 0.12%

@@             master      #1101   diff @@
==========================================
  Files            76         77     +1
  Lines         11839      11890    +51
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           6419       6461    +42
- Misses         4498       4510    +12
+ Partials        922        919     -3

[][cc-pull]

Powered by Codecov. Last updated by [f1e2643...ff3f584][cc-compare]
[cc-base-branch]: https://codecov.io/gh/docker/swarmkit/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/docker/swarmkit/compare/f1e2643f563717b49dcb9be03de96847fb51ac23...ff3f5843410343d130290a4edcea870a81740445
[cc-pull]: https://codecov.io/gh/docker/swarmkit/pull/1101?src=pr

Updated to add Options, key-value pairs that can be interpreted specifically to the type of external CA being used.
@stevvooe @jefferai PTAL

Just looked through the whole thing -- looks great! Many thanks!

LGTM Thanks for adding this @aaronlehmann

LGTM after s/type/protocol/

@stevvooe: Changed Type to Protocol, thanks.

LGTM
merge after CI passes.


Split mode, header and footer

This one comes from Kolja Windeler on the forums. Add a mode that splits the header in two (header and footer at once) with buttons and header text on one and tabs on the other.

Added in the latest version 1.1.4


[Event Request] new Event OnAfterGetRecordReminderHeaderOnBeforeMakeReminder Report 189 Suggest Reminder Lines

Please add new Event in Report 189
[IntegrationEvent(false, false)]
local procedure OnAfterGetRecordReminderHeaderOnBeforeMakeReminder(ReminderHeader: Record "Reminder Header"; var CustLedgEntry: Record "Cust. Ledger Entry"; OverdueEntriesOnly: Boolean; IncludeEntriesOnHold: Boolean; var CustLedgEntryLineFeeOn: Record "Cust. Ledger Entry"; var Result: Boolean; var IsHandled: Boolean)
and call it in the same way like in Report 188
trigger OnAfterGetRecord()
var
IsHandled: Boolean;
Result: Boolean;
begin
RecordNo := RecordNo + 1;
Clear(MakeReminder);
MakeReminder.SuggestLines("Reminder Header", CustLedgEntry, OverdueEntriesOnly, IncludeEntriesOnHold, CustLedgEntryLineFeeOn);
if NoOfRecords = 1 then begin
Result := false;
IsHandled := false;
OnAfterGetRecordReminderHeaderOnBeforeMakeReminder(
"Reminder Header", CustLedgEntry, OverdueEntriesOnly, IncludeEntriesOnHold, CustLedgEntryLineFeeOn, Result, IsHandled);
if not IsHandled then
MakeReminder.Code();
Mark := false;
end else begin
NewDateTime := CurrentDateTime;
if (NewDateTime - OldDateTime > 100) or (NewDateTime < OldDateTime) then begin
NewProgress := Round(RecordNo / NoOfRecords * 100, 1);
if NewProgress <> OldProgress then begin
Window.Update(1, NewProgress * 100);
OldProgress := NewProgress;
end;
OldDateTime := CurrentDateTime;
end;
Result := false;
IsHandled := false;
OnAfterGetRecordReminderHeaderOnBeforeMakeReminder(
"Reminder Header", CustLedgEntry, OverdueEntriesOnly, IncludeEntriesOnHold, CustLedgEntryLineFeeOn, Result, IsHandled);
if IsHandled then
Mark(Result)
else
Mark := not MakeReminder.Code();
end;
end;

Hi,
are there any updates on this event request?
Would be a good event for the next release, if possible :)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 10481.


fix: docker builds are broken

Motivation
Fix #347 broken docker builds
Change Summary

Update Dockerfile according to monorepo structure
Use turbo prune to optimize docker build

Merge Checklist
Choose all relevant options below by adding an x now or at any time before submitting for review

[x] The title of this PR adheres to the conventional commits standard
[ ] The PR has been tagged with the appropriate change type label(s) (i.e. documentation, feature, bugfix, or chore)

Additional Context
Currently, the Docker build attempt to run yarn build, which compiles Typescript files into Javascript. But in the last stage of the Dockerfile, TS code of the hub is copied into the image and it is run with tsx instead of the JS compiled files.
I believed it is done in this way because the hub uses tsconfig's path aliases (i.e. compilerOptions.paths) to map ~ to the project root but this mapping isn't carried into the JS files generated by tsc. Therefore, the compiled JS files of hub can't be run directly with node because node can't resolve the imports.
I tried to add wrapper scripts to override the default module resolution to follow tsx behavior. It works but the code is more complex than I would prefer. So, this PR keeps the existing behavior (i.e. using tsx).

Thank you, @kcchu!
This was on my list to tackle. Agree that (for now) the pragmatic solution is to continue to use tsx. I had looked into figuring out the module resolution with ~ and was similarly disappointed with how seemingly ugly it made things.
Appreciate your contribution.


FlxRepeatSprite changes and fixes

Heya thanks for the PR! But atm i rather not get PRs for FlxRepeatSprite since its something i wanna work individually on by myself for flixel addons, sorry for the inconvenience

eh its fine at least i tried to contribute ig mayb
https://github.com/MaybeMaru/Maru-Funkin/assets/99792114/9a0baee7-974d-45a3-b4d1-a05f2eb292b0


kill: move from getopts to clap

Code is in:
https://github.com/uutils/coreutils/blob/master/src/uu/kill/src/kill.rs
Tests (definitely need some):
https://github.com/uutils/coreutils/blob/master/tests/by-util/test_kill.rs
As example:
https://github.com/uutils/coreutils/commit/9081e120d6b866c94679d9e29c7bdb17ccccb4d0

I can take this.


Implement class BaseMrg32 (c++20)

Take benefit of c++11 implementation.

Completed; Compiles; Still to be tested.


BYS Homepage Copy Changes

We currently detect dependencies from JavaScript (NPM), PHP (Composer), .NET (Nuget), Go (dep) and Ruby (Gem). Want to see something else? See how to contribute.

Ruby (Gem) (...) To add new languages, please see how to contribute.

You have two different options to perform an analysis of your code to know which Open Source Projects you are going to contribute to.

Use one of the two options below to scan your organization's code and find out which of your dependencies are seeking funding. You can now support them!

Use your github link

Public Repositories

Just copy and paste the URL of the repository that you want to scan and set a contribution.

add your organization's slug and we'll scan all public repositories under it.

Upload your own file

option 1: Private repositories or repositories not on Github.
option 2: Upload a dependency file.

If you want to analyze non-public repositories, sign in with your GitHub account or simply upload dependency files. At the moment, we do support composer.json, *.csproj, packages.config, Gopkg.lock and Gemfile.lock.

(...) or simply upload your dependency file. At the moment we support (...)

The uploaded files will not be shared with anyone and will be deleted when your session expire.

The uploaded files will not be shared and we will store them only with your explicit consent.

"Public Repositories" is misleading -> "Use a GitHub profile" ?
Option 2 -> "Upload dependency files" ?

"Use a GitHub profile"
ok - you don't think it'll make user think they must login? I guess having the url immediately afterwards makes it clear.

"Upload dependency files"
Ah, I always thought it was one file.


FullAncillaAllocation for backends witout a coupling map

Summary
The transpiler can transpile to a given target. In some situations there is no coupling map. This can occur at the beginning of device bring-up when the two-qubit gates have not yet been calibrated. In the absence of a coupling map the FullAncillaAllocation fails to enlarge the circuit to a number of total qubits that match the number of qubits specified by the target. This PR fixes this behavior.
Details and comments
The behavior is fixed by catching the case when coupling map is None. In this case we refer to the number of qubits specified by the target. The test illustrates the desired behavior.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
15 unchanged lines in 5 files lost coverage.
Overall coverage increased (+0.03%) to 85.934%

Files with Coverage Reduction
New Missed Lines
%

qiskit/transpiler/passes/synthesis/unitary_synthesis.py
1
90.18%

crates/qasm2/src/lex.rs
2
91.65%

qiskit/extensions/quantum_initializer/squ.py
2
80.0%

crates/accelerate/src/sabre_swap/layer.rs
4
97.32%

crates/qasm2/src/parse.rs
6
97.58%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
71359

Relevant Lines:
83039

💛  - Coveralls


Add missing usage of EdgeConnect Spec for: Env, Resources, NodeSelector, Toleration, TopologySpreadConstraints

Description
This PR fixes the absence of a few missing fields from CRD that are landed correctly yo deployment:
Missing fields:

Env
resources
NodeSelector
Tolerations
TopologySpreadConstraints

How can this be tested?
kubectl apply -f - <<EOF
apiVersion: dynatrace.com/v1alpha1
kind: EdgeConnect
metadata:
  name: andrii-test
  namespace: dynatrace
spec:
  apiServer: "<tenant>.dev.apps.dynatracelabs.com"
  oauth:
    clientSecret: edge-connect-client-secret
    endpoint: https://<sso-url-here>/sso/oauth2/token
    resource: urn:dtenvironment:<tenant>
 env:
   - name: DEBUG
     value: "true"
EOF

Check env vars of the pod has DEBUG=true:
k get pods andrii-test-5d894dbcf9-wn8p5 -o=jsonpath='{range .items[*]}{.spec.containers[*].env}' | jq
[
  {
    "name": "DEBUG",
    "value": "true"
  },
  {
    "name": "EDGE_CONNECT_NAME",
    "value": "andrii-test"
  },
  {
    "name": "EDGE_CONNECT_API_ENDPOINT_HOST",
    "value": "duc19273.dev.apps.dynatracelabs.com"
  },
  {
    "name": "EDGE_CONNECT_OAUTH__ENDPOINT",
    "value": "https://sso-dev.dynatracelabs.com/sso/oauth2/token"
  },
  {
    "name": "EDGE_CONNECT_OAUTH__RESOURCE",
    "value": "urn:dtenvironment:duc19273"
  }
]
➜  dynatrace-operator git:(improve-edgeconnect-deployment)

Checklist

[x] Unit tests have been updated/added
[x] PR is labeled accordingly with a single label
[x] I have read and understood the contribution guidelines

Codecov Report

Merging #2092 (fdc517f) into main (280acb5) will increase coverage by 0.03%.
The diff coverage is 89.28%.

:exclamation: Current head fdc517f differs from pull request most recent head 8ebe5c1. Consider uploading reports for the commit 8ebe5c1 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main    #2092      +/-   ##
==========================================
+ Coverage   63.20%   63.23%   +0.03%
==========================================
  Files         242      242
  Lines       15357    15379      +22
==========================================
+ Hits         9706     9725      +19
- Misses       4909     4911       +2
- Partials      742      743       +1

Files Changed
Coverage Δ

...c/controllers/edgeconnect/deployment/deployment.go
97.88% <89.28%> (-2.12%)
:arrow_down:


Missing Msg.get_sign_bytes implementation

All of the Handshake Msgs right now are missing implementation of get_sign_bytes function

Implemented now in the Msg trait.


Ignore .Trashes directory

Currently node-dir will attempt to find all files and directories in a given path.  On a mac a .Trashes directory may exist which causes node-dir to exit with the following error:
/Users/daniel/Projects/bin/slurp.js:59
                if (err) throw err;
                               ^
Error: EACCES, readdir '/Volumes/Media/.Trashes'

When inspecting the .Trashes dir in bash it is clear this is a permissions issue.
$ ls -al
d-wx-wx-wt   2 daniel  staff    68 Jun  8 15:53 .Trashes

When inspecting .Trashes with fs.stat the stat.mode value is 17115.  This can be reproduced by using chmod on any folder:
chmod 41333 ./TestFolder

This PR simply ignores directories with a mode of 17115.  If merged this will resolve issue #11.

I believe this closes #11.


[TS2742] Occurs building a library that depends on @reduxjs/toolkit

🔎 Search Terms
TS2742, redux, rtk
🕗 Version & Regression Information
I refered to this comment from #42873 and I found that this does not work in typescript@beta (5.5.0-beta) as well.
And if I try import * as foo from<EMAIL_ADDRESS>d.ts emission works like a charm.
This doesn't work as d.ts ends up with empty export {};
⏯ Playground Link
https://github.com/ryuujo1573/rtk-ts2742-demo
💻 Code
// only this line fixes the problem
import * as _ from "../node_modules/@reduxjs/toolkit/dist/createSlice"

🙁 Actual behavior
TS2742
🙂 Expected behavior
Resolve type definitions from "@reduxjs/toolkit" (@reduxjs/toolkit/dist/createSlice.d.ts) properly, and generate types as expected
Additional information about the issue
reduxjs/redux-toolkit#3962
and this
reduxjs/redux-toolkit#4066
### Tasks

This was fixed upstream in @reduxjs/toolkit - they had some inaccessible internal types that needed to be exported.


Test: ng-schematics jest test is flaky

https://github.com/puppeteer/puppeteer/actions/runs/7652374569/job/20852025719

Closed by https://github.com/puppeteer/puppeteer/pull/12711


"staticServe" sending wrong file issue

Hi,
I have been testing this framework today and stubbled over this issue.
I implemented the build-in static file module:
const staticServe = require('nanoexpress-pro/cjs/static');
app.use(staticServe(__dirname + '/public'));
I have two files in two different folders:

"/public/img/flag/in.svg"
"/public/img/testin.svg"

When trying to check in the browser for image number 2 (example.com/img/testin.svg), I'm getting the first image instead. You can type any name instead of "test", as long as I have a file ending "in.svg" it will send back the first file.
Thanks a lot.

Hi @dnohr
I'm uploaded new fixed and better documented version at here

@dnohr
If new middlewares static fixes your issue, please close issue


spike fix order of properties for API Form

https://github.com/restarone/violet_rails/issues/555
@Pralish  @alis-khadka  I have added some helpful breakpoints so yall can debug the above issue:
when you change the order of the attributes in the API namespace here and hit save -- the breakpoints should get hit:

@Pralish have you had some time to think about this one? I believe the issue is not in the params (the shape of the object is preserved when transmitted to the server)


Add additional columns lei_company and isin_company to dataset ald_demo

@vintented I would appreciate if you could check this over quickly and see if the updated ald_demo reflects the proposed AR changes.
Note: this does not yet included the addition of: aviation, nor hdv, that will occur in a different PR.
In particular, I'd like to discuss the naming convention for the new columns:
lei_company and isin_company
as well as the existing column:
id_company
I don't think these are the names AR was initially planning on releasing, so I use them as placeholders for now.
Maybe closes #233

@vintented you can check out what the "new" ald_demo would look like by executing something like the following in R.
WARNING: Running this will install this PR version of r2dii.data.
Make sure to re-install the production version after if you want
library(dplyr)
library(devtools)

install_github(
  repo = "2DegreesInvesting/r2dii.data",
  ref = github_pull(236)
)

names(r2dii.data::ald_demo)

r2dii.data::ald_demo %>%
  select(id_company, name_company, lei_company, isin_company) %>%
  unique()

Thanks @maurolepore. I think we now need to wait for the go ahead from @vintented before moving forward, so I will ping him quickly and see if he has any time to do a super quick review.
As for the seed issues, I will have a look first thing tomorrow!

@jdhoffa @maurolepore it's exciting to see the updates! I get back to you regarding the column names. I would also suggest adding @tposey28 as a review.
In the meantime, it was never on my radar (or AR's, but I'll let @tposey28 confirm) that we would include ISINs in the PACTA for Banks free dataset. This makes distributing the data more complicated because the banks would need to prove they have a CUSIP license before we share ISINs.

@vintented no problem!! I will remove them (it wasn't on my radar either), I just noticed that ISINs were present in the data dictionary you sent, and have been modeling all my updates on that.


[Feature] webpackfile/index.js

Being able to have the webpackfile be a folder (besides having an interesting name) would allow people to organise more complex webpack configs in a single place
This should be easy to implement, just add 'webpackfile/index' to the array on https://github.com/webpack/webpack/blob/master/bin/convert-argv.js#L36
any thoughts / ideas before I submit a PR??

Can you re-open this at cli repo if still interested? Thanks.


ember-cli-rails mount cannot be excluded from devise authentication

I was attempting to put together a single rails app which hosted an ember-cli-rails frontend and an API back-end with devise authentication, which would allow the user to login within the ember UI (using ember-simple-auth).
After fiddling with the code, I concluded that I couldn't exclude the ember mountpoint from the devise authentication, so I opened an issue with the devise project.
The conclusion from their end was that there was no way to allow this as the ember-cli-rails mount is implemented as a callable constraint rather than as a hash constraint, and so Rails itself is unable to apply both rules.
Here is the issue which was opened with devise - https://github.com/plataformatec/devise/issues/3977
Is there any way to change the ember-cli-rails mount constraint to a hash constraint so additional rules can be applied to it?

@Ikariusrb thanks for opening this issue, bringing it to our attention.
Also, a big thank you for first opening the issue against Devise for additional context! :+1:
What code changes do you need to make your use case work?
Would you be able to on a PR against this line, with the necessary modifications?
If you can get your use case to work, we could work together to ensure existing behavior still works.

I have to admit, I believe I'm changing my mind for my particular use;  I am now looking at having my ember app require authentication before it can be accessed, and using some static HTML pages with minimal javascript (no full framework) to authenticate users before they are granted to access the ember application.
On the other hand, I suspect that hosting an ember front-end from the same rails app which provides a back-end API and authentication would likely be a fairly common use-case.  To do that would require the ember app to be served without requiring authentication- user gets the ember app first, then logs in from the ember-provided UI.
Devise is a pretty common authentication module for rails, and when it is installed, it adds authentication to all routes by default, and the method for configuring an unauthenticated route in config/routes.rb looks like this:
  unauthenticated do
    root to: "main#index"
  end

I tracked the implementation of that back to https://github.com/plataformatec/devise/blob/master/lib/devise/rails/routes.rb#L318
Unfortunately, that implementation doesn't appear to play nicely with engine mounts, or at least that's my take-away from the devise team's response to the issue I opened with them- it sounds like there are some limitations in applying configuration to routes in rails itself, if I correctly understand their response.
The line you referenced in ember-cli-rails certainly looks like the place where this would be addressed, if it can be.  If it can't be fixed, at least this issue can stand as documentation that this won't be a fruitful path for others in the future.

Thanks for all that extra context.

I am now looking at having my ember app require authentication before it can be accessed

We've had success with this approach. One of my favorite aspects of this approach is that the Ember application doesn't need to know anything about authentication (or the current user most of the time), and it depends on the API itself to restrict access / include user-specific context in the responses.
However, utilizing this approach means using both Rails-generated views (in your case Devise's login, password reset, signup, etc.) in addition to the Ember frontend.
Your mileage may vary.

Oh wow, I've been tearing my hair out over this issue for the past 24-36 hours. Strangely, it has alternated back and forth, working then not working for no apparent reason. I suspected some kind of weird race condition, but I honestly don't know. I've done a crazy amount of Ruby stack tracing in my day and this thing takes the cake.

@Ikariusrb

Devise is a pretty common authentication module for rails, and when it is installed, it adds authentication to all routes by default

That's totally not my understanding. Devise even gives you a user_signed_in? method to check whether a user is signed in. If you want to restrict a route to only authenticated users, you have to wrap the route in an authenticate block.
Although I am indeed experiencing this issue, so I'm a little confused here.


errands does not start anymore

hi,
for a cpuple of days, errands does not start any more on my main computer. on my second machine, it ist still working.
both machines are running fedora 39 + 40.
below i attached the putpunt of the logfile:
09:26:24 errands: IndexError: list index out of range
09:26:24 errands: IndexError: list index out of range
09:26:24 errands:                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^
09:26:24 errands:     list_dict = [lst for lst in lists_dicts if lst.uid == task_dict.list_uid][0]
09:26:24 errands:   File "/app/share/errands/errands/widgets/trash/trash.py", line 138, in update_ui
09:26:24 errands:     State.trash_page.update_ui()
09:26:24 errands:   File "/app/share/errands/errands/widgets/trash/trash_sidebar_row.py", line 84, in update_ui
09:26:24 errands:     State.trash_sidebar_row.update_ui()
09:26:24 errands:   File "/app/share/errands/errands/widgets/window.py", line 123, in __finish_load
09:26:24 errands:     self.__finish_load()
09:26:24 errands:   File "/app/share/errands/errands/widgets/window.py", line 42, in init
09:26:24 errands:                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
09:26:24 errands:     State.main_window = Window(application=State.application)
09:26:24 errands:   File "/app/share/errands/errands/application.py", line 84, in do_activate
09:26:24 errands: Traceback (most recent call last):
09:26:23 errands: IndexError: list index out of range
09:26:23 errands:                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^
09:26:23 errands:     list_dict = [lst for lst in lists_dicts if lst.uid == task_dict.list_uid][0]
09:26:23 errands:   File "/app/share/errands/errands/widgets/trash/trash.py", line 138, in update_ui
09:26:23 errands:     State.trash_page.update_ui()
09:26:23 errands:   File "/app/share/errands/errands/widgets/trash/trash_sidebar_row.py", line 84, in update_ui
09:26:23 errands:     State.trash_sidebar_row.update_ui()
09:26:23 errands:   File "/app/share/errands/errands/widgets/window.py", line 123, in __finish_load
09:26:23 errands:     self.__finish_load()
09:26:23 errands:   File "/app/share/errands/errands/widgets/window.py", line 42, in init
09:26:23 errands:                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
09:26:23 errands:     State.main_window = Window(application=State.application)
09:26:23 errands:   File "/app/share/errands/errands/application.py", line 78, in do_startup
09:26:23 errands: Traceback (most recent call last):

I think, I fixed it in 46.0.2. When update will arrive can you test it? After update you will need to reboot or re-login.

I had the same issue and it's working fine after the update and reboot.

it is working again - thank you very much! :)
Am Samstag, dem 04.05.2024 um 09:07 -0700 schrieb mrvladus:

I think, I fixed it in 46.0.2. When update will arrive can
you test it? After update you will need to reboot or re-
login.
—
Reply to this email directly, view it on GitHub, or
unsubscribe.
You are receiving this because you authored the
thread.Message ID:
@.***>


Provide a way to implement a HealthChecker with peioric polling easily.

A user wants to implement a HealthChecker that updates its healthiness by polling an external source (e.g. database) periodically, so that HealthChecker.isHealthy() merely returns a cached value. This is mainly because:

HealthChecker.isHealthy() that takes long time can make a server look unhealthy.
Each health check request triggers HealthChecker.isHealthy(), and thus it is suboptimal to actually check the health of the external source.

It'd be nice if we provide a utility that simplifies the implementation of this pattern, e.g.
HealthChecker.ofFixedRate(Supplier<CompletionStage<Boolean>> healthChecker, Duration interval, double jitter)
HealthChecker.ofFixedDelay(Supplier<CompletionStage<Boolean>> healthChecker, Duration delay, double jitter)

Discussion at Slack: https://line-armeria.slack.com/archives/C1NGPBUH2/p1615691261133800

Alternatively, we could keep the timestamp of last healthChecker.get() and return the cached result only when the recorded timestamp is old enough. This is simpler to manage because we don't have to schedule a periodic task using an event loop.

@trustin Is it okay if I take a stab at this?


Handling int fields from MySQL OK_Packets

Hi @jchrys ,
#39
Motivation: Incoming values from MySQL OK_Packets that exceed 2^63-1 will incorrectly be represented as negative numbers in the string representation of the message object.
Modifications: I changed the toString method in the OkMessage class so that the unsigned long fields are converted into unsigned strings. I'm not aware of any other classes that deal with mySQL length encoded integer fields.
Results: When a value greater than 2^63-1 is received from a MySQL OK_Packet, that value is preserved in the string representation of the OkMessage object.

Hello, @svats0001.
This looks great to me.
Thanks very much.
if you have time could you make your commit message follow below format like other commit messages?
title

motivation:

modifications:

results:

Unfortunately, we're currently experiencing issues with our CI system when running tests on forked pull requests. Once this issue is resolved, I would be happy to merge your changes into our codebase.

No worries. I've updated my original commit message.

Thanks a lot!


doctl: 1.3.1 -> 1.5.0

Motivation for this change
doctl auth login on 1.3.1 doesn't work as it looks for /usr/bin/xdg-open which is not available on NixOS. doct 1.5.0 doesn't use xdg-open anymore and doctl auth init works just fine. And as a bonus we get an update :angel:.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

/cc @offlinehacker @fpletz

Other than the above comment, LGTM 👍

Updated :angel:

Updated. It now only generate doctl binary and not the other ones that should not be there.

@Mic92 updated :wink:

Thanks!


Can't figure out how to start FSI

From everything that I read in the docs, FSI just comes with Ionide. So how do you start the FSI feature? I can't see this anywhere.
In a video tutorial, I saw that it's an option in the terminal. Is this in the docs anywhere?

https://fsharp.org/use/windows/
https://docs.microsoft.com/en-us/dotnet/fsharp/tutorials/fsharp-interactive/


Move docs requirements to a dedicated file

Issue #, if available:
The docs framework requires a bunch of dependencies that are not needed by other setup.py commands (e.g. bdist_wheel or bdist_egg). This PR separates requirements needed in order to run python setup.py $some_command from the ones required to run python setup.py docs).
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-142/1 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-142/1/index.html

Codecov Report

Merging #142 into master will decrease coverage by 2.32%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #142      +/-   ##
=========================================
- Coverage   79.12%   76.8%   -2.33%
=========================================
  Files         110     110
  Lines        6401    6401
=========================================
- Hits         5065    4916     -149
- Misses       1336    1485     +149

Impacted Files
Coverage Δ

src/gluonts/dataset/split/__init__.py
0% <0%> (-100%)
:arrow_down:

src/gluonts/model/prophet/__init__.py
0% <0%> (-100%)
:arrow_down:

src/gluonts/model/canonical/__init__.py
0% <0%> (-100%)
:arrow_down:

src/gluonts/model/r_forecast/__init__.py
0% <0%> (-100%)
:arrow_down:

src/gluonts/core/log.py
0% <0%> (-88.89%)
:arrow_down:

src/gluonts/model/canonical/_estimator.py
0% <0%> (-55.56%)
:arrow_down:

src/gluonts/dataset/split/splitter.py
0% <0%> (-46.94%)
:arrow_down:

src/gluonts/dataset/validate.py
0% <0%> (-45.46%)
:arrow_down:

src/gluonts/model/canonical/_network.py
0% <0%> (-34.7%)
:arrow_down:

src/gluonts/model/prophet/_predictor.py
0% <0%> (-27.09%)
:arrow_down:

... and 2 more


Only send slack notifications for local builds and (local + remote) deployments

The _track_event() function notifies graphite, slack, & an "external rest api endpoint". We don't really care about non-deploy & non-rollback events in graphite. And posting to slack for every single event can get a little extraneous.

This can be extraneous for services that are deployed to multiple servers...

Unless I am missing something and y'all would be fine having this?

you went from too much, to not doing a single slack call. I think just leaving it in deploy is probably enough

Lol it is doing slack calls during deploys and rollbacks. Just not for
every single stage except builds when they do happen locally
On Friday, October 5, 2018, Brian Cordonnier<EMAIL_ADDRESS>wrote:

you went from too much, to not doing a single slack call. I think just
leaving it in deploy is probably enough
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sproutsocial/mendel/pull/39#issuecomment-427493456,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHXUreZlTa92yfNKw4rYdyLXBXfYhZuzks5uh8SsgaJpZM4XKy3l
.


⚠ Bofrost.de has degraded performance

In f593ad9, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1571 ms

Resolved: Bofrost.de performance has improved in a701c2a after 6 minutes.


fix: respect useDefineForClassFields tsconfig value

Fixes #739
Currently, useDefineForClassFields is not read from tsconfig.json and not set in the SWC config.
This PR updates the tsCompilerOptionsToSwcConfig function to read the value of useDefineForClassFields from tsconfig.json (using the default value based on target as specified at https://www.typescriptlang.org/tsconfig#useDefineForClassFields)
See: https://swc.rs/docs/configuration/compilation#jsctransformusedefineforclassfields

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Support auto injection of @HelpArgument

Placing
  @HelpArgument()
  late bool help = false;

In every command is getting a little old. I would love to see @Parser() auto support the @HelpArgument() for basic implementations.

All SmartArg instances have help by default. So this is now no-longer required.


[BIA-477] GitHub Actions: Run Unit and Integration Tests

Update message newline to use Environment.Newline.
Enable unit e integration tests.

This looks great! We are already executing our unit and integration tests on GitHub Actions.


User Search

There should be a type ahead search input within the navbar that lets users find other users via Full name.

I'm going to start on this.


Fix typos in main.cpp and README

Just fixes some minor typos maintaining much as the original text.
Two points to discuss:

Other than that I'd suggest replacing the text
Launches the distro's default behavior. By default, this launches your default shell
by something simpler like
Open a new shell with your default settings

I am not native, so not sure if its better to use third singular person (with s) or not for the description. But at least I like to be consistent in the docs and use the same for all. wdyt we should do?

Ok,I think that is better.
Yes.
Sorry for my bad English...

2. Sorry for my bad English...

I apologize if my words had that impression in you.
I am very nitpicky about documentation and this kind of details.


cdnjs.cloudflare.com 404 error

Thanks for this great package - it was just what I needed. I thought you might like to know that that cloudflare.com are no longer providing Jodit. Instead I used these with your package and it worked fine:

Hi Matthew,
Thanks for informing me.
I've updated the readme file, so it uses unpkg.com instead of cloudflare.com.


Link back to GitHub repo from pkgdown site

Very minor, but it could be nice to have a more visible link back to the github repo from the pkgdown site.  Right now the easiest way to get back to the repo page is to click on one of the function names in the code, but this isn't very obvious at first.

That makes sense.  I think to get a link section I need to add to the _pkgdown.yml file:
  links:
  - text: BirdFlow Science
    href: https://https://birdflow-science.github.io/

And so there's a report an issue link I should add to the DESCRIPTION file:
BugReports: https://github.com/birdflow-science/BirdFlowR/issues

And update the DESCRIPTION URL line to:
URL: https://birdflow-science.github.io/BirdFlowR/, https://github.com/birdflow-science/BirdFlowR

I think that will result in a reasonably full set of links on the homepage, including one to source code.

Yeah, sounds good to have links to the organization, the package, and the issues.