Make the JavaComponent definitions polymorphism and expose fqdn for sba and eureka

ARM (Control Plane) API Specification Update Pull Request

[!TIP]
Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

[!NOTE]
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

 Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
You believe there is no need for you to request breaking change approval, for any reason.
Such claims must be reviewed, and the process is the same.

 Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)

For help with Step 2 / "ARM review", see https://aka.ms/azsdk/pr-arm-review.

 Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ ] New resource provider.
[ ] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix OpenAPI spec quality issues in S360.
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[ ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[ ] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

 Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Hi @Juliehzl  @jijohn14 ,
I have problem resolve the lint check of this pr.
I want to do some refactor to the JavaComponent definition, which makes the Type into a discriminator and make the definition polymorphism.
The discriminator has to be a required property while the failed check is "No required property in Patch Body". Can I somehow bypass/suppress this check for this pr?

Hi @Juliehzl @jijohn14 ,
I have problem resolving the lint check of this pr. I want to do some refactor to the JavaComponent definition, which makes the Type into a discriminator and make the definition polymorphism.

The discriminator has to be a required property while the failed check is "No required property in Patch Body". Can I somehow bypass/suppress this check for this pr?

For PATCH this should not be bypassed since you must allow single property PATCH. If you need this as mandatory in a PUT, you need to separate out the objects so that the PATCH has a different definition from the PUT. Check this repo many teams have a separate definition for PATCH objects with _Update definition.

Hi @Juliehzl @jijohn14 ,
I have problem resolving the lint check of this pr. I want to do some refactor to the JavaComponent definition, which makes the Type into a discriminator and make the definition polymorphism.

The discriminator has to be a required property while the failed check is "No required property in Patch Body". Can I somehow bypass/suppress this check for this pr?

For PATCH this should not be bypassed since you must allow single property PATCH. If you need this as mandatory in a PUT, you need to separate out the objects so that the PATCH has a different definition from the PUT. Check this repo many teams have a separate definition for PATCH objects with _Update definition.

I know how to seperate a Patch object, but that won't help in this case.
we need this discriminator value to decide what 'kind' of resource this request body is trying to patch.
For example here are two JavaComponent resource definitions with ComponentType as the discriminator:
In this "componentType": "SpringBootAdmin", the fqdn & httpEndpoint are unique properties belongs to SpringBootAdmin
"properties": {
          "componentType": "SpringBootAdmin",
          "configurations": [
            {
              "propertyName": "spring.boot.admin.ui.enable-toasts",
              "value": "true"
            },
            {
              "propertyName": "spring.boot.admin.monitor.status-interval",
              "value": "10000ms"
            }
          ],
          "httpEndpoint": "External",
          "fqdn": "myjavacomponent.myenvironment.test.net"
        }

And another Java Component: SpringCloudConfig, and it has its own unique property configUniqueProperty
"properties": {
          "componentType": "SpringCloudConfig",
          "configurations": [
            {
              "propertyName": "spring.boot.admin.ui.enable-toasts",
              "value": "true"
            },
            {
              "propertyName": "spring.boot.admin.monitor.status-interval",
              "value": "10000ms"
            }
          ],
          "configUniqueProperty": "abcdefg",
        }

So when there is a Patch request that comes in, we need the ComponentType to know what properties should be allowed in this patch request body, right? For example, if the componentType = SpringBootAdmin, the allowed properties to be patched should include fqdn & httpEndpoint, butconfigUniquePropert should not exist in the request body.
It's just like polymorphism. In the PUT request, I can use the componentType to distinguish which sub-class of the JavaComponentProperties I'm trying to create. I want to do the same thing in the PATCH requests.

The suppression reason makes sense to me.

@Caoxuyang  Sorry I am not following. If the resource is getting PATCHED then you already know what resource it is in your storage. You can still fail it based on the saved resource type right ?
for eg : The customer should be able to only specify fqdn in the body , but you can fail it if the saved is not of type SpringBootAdmin.
@TimLovellSmith  please let me know if you disagree on this.

@Caoxuyang Sorry I am not following. If the resource is getting PATCHED then you already know what resource it is in your storage. You can still fail it based on the saved resource type right ?
for eg : The customer should be able to only specify fqdn in the body , but you can fail it if the saved is not of type SpringBootAdmin.
@TimLovellSmith please let me know if you disagree on this.

Hey @raosuhas, you are right. Of course we can verify the request body based on our resource provider's DB information.
But in my opinion, the meaning of our swagger is just to reduce the ambiguity and provide customers a clear view of what should they request be like.
In your proposal, what we should do is that we put every single property into one big PatchObjectDefinition. In the customer's point of view, they have so much choice to put into Patch body but they will be really possible to get a 400 Bad Request from the server for adding invalid properties according to the ComponentType.
I hope this makes sense to you. I don't think an all-in-one Patch model can provide good customer experience in this case. cc @bowen5 @TimLovellSmith

@Caoxuyang Sorry I am not following. If the resource is getting PATCHED then you already know what resource it is in your storage. You can still fail it based on the saved resource type right ?
for eg : The customer should be able to only specify fqdn in the body , but you can fail it if the saved is not of type SpringBootAdmin.
@TimLovellSmith please let me know if you disagree on this.

Hey @raosuhas, you are right. Of course we can verify the request body based on our resource provider's DB information. But in my opinion, the meaning of our swagger is just to reduce the ambiguity and provide customers a clear view of what should their requests be like.
In your proposal, what we should do is that we put every single property from different JavaComponents into one big PatchObjectDefinition, even though they are not compatible with each other. In the customer's point of view, they have so much choice to be put into Patch body but they will be really possible to get a 400 Bad Request from the server for adding invalid properties to a not compatible ComponentType. What's more, this can also bring much confusion to toolset developers like terraform.
I hope this makes sense to you. I don't think an all-in-one Patch model can provide good customer experience in this case. cc @bowen5 @TimLovellSmith

OK yeah makes sense. Approving this


add biplot support

This came up on the forum here.

We are working on this: https://github.com/biocore/emperor/pull/543

Cool! I'll leave this issue open since we'll need to hook up biplot support to the plugin when it's available in Emperor.

I wanted to give everyone a heads up that I have put together the first prototype of biplots in the new version of Emperor, if you have any suggestions or feature requests, please refer them to this PR:
https://github.com/biocore/emperor/pull/646
Currently the only example available is found in a notebook in that PR, but if you have any questions, let me know and we can figure something out.

Another question would be to decide what biplot-generating methods should we include in QIIME2, RDA and PLS might be good ideas, but

Awesome!
On Mar 16, 2018 1:25 PM, "Yoshiki Vázquez Baeza"<EMAIL_ADDRESS>wrote:
Closed #26 https://github.com/qiime2/q2-emperor/issues/26.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/qiime2/q2-emperor/issues/26#event-1526348884, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AD_a3US-W6LsLVIwFU9Wdq9J8kJUr91vks5tfB-kgaJpZM4LBp__
.

The current release of emperor now supports display of biplots. The main missing piece to this puzzle is that we don't have a method in QIIME2 to compute the biplots. @mortonjt helped me put together this notebook with an implementation of compositional principal component analysis. I assume that the ideal case would be to put this in scikit-bio and then create a method in q2-diversity to call this method.
@gregcaporaso @ebolyen An alternative to what I mention above is to put the code from the notebook directly into q2-diversity, that way we could have the method sooner rather than later. Though I acknowledge this is not ideal.

It seems like scikit-bio is pretty well on its way to being "unstuck" as it were. Maybe this is an easy target to hit for a hypothetical June release?

forum xref

🥇


Bootstrap tower

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #327
Special notes for your reviewer:
Documentation:

Does this PR introduce a user-facing change?:

NONE

/lgtm

/lgtm
/retest

/retest


add wrr lb fallback strategy

What problem does this PR solve?
Issue Number:
Problem Summary:
wrr添加兜底策略
What is changed and the side effects?
Changed:
wrr添加兜底策略，防止节点较少时, 开启了backup request，但选取节点失败
Side effects:

Performance effects(性能影响):

Breaking backward compatibility(向后兼容性):

Check List:

Please make sure your changes are compilable(请确保你的更改可以通过编译).
When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

LGTM

LGTM


Requirements.txt Could not find version cairosvg==2.1.3

(Please take the time and describe the problem you're having before you propose a solution.)
What I'm trying to achieve
I stuck on installation becasue a error en requirements.txt
Exactly on:
python -m pip install -r requirements.txt
Steps to reproduce the problem
1 .python -m pip install -r requirements.txt
The full error:
Could not find a version that satisfies the requirement cairosvg==2.1.3 (from -r requirements.txt (line 16)) (from versions: 2.0.0rc1.linux-x86_64, 2.1.3.linux-x86_64, 0.1, 0.1.1, 0.1.2, 0.2, 0.3, 0.3.1, 0.4, 0.4.1, 0.4.2, 0.4.3, 0.4.4, 0.5, 1.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.0.5, 1.0.6, 1.0.7, 1.0.8, 1.0.9, 1.0.10, 1.0.11, 1.0.12,1.0.13, 1.0.14, 1.0.15, 1.0.16, 1.0.17, 1.0.18, 1.0.19, 1.0.20, 1.0.21, 1.0.22, 2.0.0rc2, 2.0.0rc3, 2.0.0rc4, 2.0.0rc5, 2.0.0rc6, 2.0.0, 2.0.1, 2.0.2, 2.0.3, 2.1.0, 2.1.1, 2.1.2) No matching distribution found for cairosvg==2.1.3 (from -r requirements.txt (line 16))

Resolved, i use now:
python3 -m pip install -r requirements.txt
and works


test task invokes xcodebuild with a -target option instead of -scheme

I have a scheme for a framework target (TestFramework) that also has a test target (TestFrameworkTests) set for running tests against the framework target. There is also a scheme created for the test target.

invoking xcodebuild -scheme TestFramework[Tests] -sdk iphonesimulator test runs the tests fine, but xctool -scheme TestFramework[Tests] -sdk iphonesimulator test fails. I noticed by using -showTasks that the xctool invocation generates the following xcodebuild invocation:
/Applications/Xcode7_1_1/Xcode.app/Contents/Developer/usr/bin/xcodebuild \
    -configuration \
    Debug \
    -sdk \
    iphonesimulator9.1 \
    PLATFORM_NAME=iphonesimulator \
    -project \
    //Users/amcknight/Desktop/TestFramework/TestFramework.xcodeproj \
    -target \
    TestFrameworkTests \
    OBJROOT=/Users/amcknight/Desktop/TestFramework/Build/Intermediates \
    SYMROOT=/Users/amcknight/Desktop/TestFramework/Build/Products \
    SHARED_PRECOMPS_DIR=/Users/amcknight/Desktop/TestFramework/Build/Intermediates/PrecompiledHeaders \
    TARGETED_DEVICE_FAMILY=1,2 \
    test \
    -showBuildSettings

simply replacing the -target with -scheme fixes the issue. Is there a reason this doesn't happen?
Test project can be downloaded from: https://www.dropbox.com/s/ulq1433uhcm9euw/TestFramework.zip?dl=0
The invocations I used are in xcodebuild-test.sh and xctool-test.sh

OK, I found this comment
  // For Xcode 6, we can pass `test -showBuildSettings` to xcodebuild and get
  // build settings that are specific to the `test` action.  But in Xcode 7
  // `-scheme` should be passed along with `test` action which isn't always
  // defined. So we are using `build` action which doesn't require to specify
  // scheme.
  NSString *action = ToolchainIsXcode7OrBetter() ? @"build" : @"test";

here: https://github.com/facebook/xctool/blob/master/xctool/xctool/TestableExecutionInfo.m#L94
If there were a way to find if a scheme exists for the target (I'm sure there is somewhere in the project), I wonder if it would then be as easy as always providing test as the action and swapping out the @"-target", target with @"-scheme", <corresponding name of scheme>, and fall back to the current logic otherwise?

tracking work at https://github.com/armcknight/xctool/pull/1


Publish trajectory as NavSatFix message if GNSS is used

If GNSS state is used (see #666) , cartographer could also publish robot position as NavSatFix message. Means to convert local pose back to WGS84 using the same fundamental point, which will then allow to use cartographer as navigation backup (temporary satellite dropout etc.).

Closing for inactivity, feel free to post when there is something new.


Advice on setExpiration() for exp claim

Could you provide examples on how to set the jwt 'exp' claim with setExpiration():

a date four months from the current date
a date 16 hours from the current date

Thank you

Are the examples in the README not sufficient @PaulFish-Radius ?

working now ty - just having a hard time with javascript's Date/Time API's.

Glad it works now @PaulFish-Radius ! I share your feelings about the JavaScript Date API :)


Only pipe stdio if it doesn't support color

Because we were piping the output when color was supported it treated it like it was no longer supported since it was no longer TTY.
This updates it to only pipe when we want to strip ansi characters.
I updated the lint example locally to use chalk to test this, if you want I can add that back. We could also probably update the ansi example to have something more complicated since it should have caught that.

@jamiebuilds bump


fix: duplicate refID in grafana panel

Maintainers will complete the following section

[ ] Commit messages are descriptive enough (hints)
[ ] Code coverage from testing does not decrease and new code is covered (check the PR coverage on codecov)
[ ] Controllers diagrams are updated when PR changes controllers code  (if applicable)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@7430659). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #927   +/-   ##
=======================================
  Coverage        ?   66.58%
=======================================
  Files           ?       43
  Lines           ?     5695
  Branches        ?        0
=======================================
  Hits            ?     3792
  Misses          ?     1570
  Partials        ?      333

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Change type of data object for NatsGenericClaims

Proposed change
Currently NatsGenericClaims uses Dictionary<string, JsonObject> for its Data property.
I think this should be changed to Dictionary<string, JsonNode>
Use case
Some of the properties of the Data dictionary object need to be other types other than a JsonObject.
E.g. when calling "$SYS.REQ.CLAIMS.DELETE" we need a GenericClaims with a string array property called accounts.
Go example from https://github.com/nats-io/nats-server/blob/a07bde9fa7d499c7039f74cac9d11f4c046b9250/server/jetstream_jwt_test.go#L1005C2-L1010C28
generateRequest := func(accs []string, kp nkeys.KeyPair) []byte {
		t.Helper()
		opk, _ := kp.PublicKey()
		c := jwt.NewGenericClaims(opk)
		c.Data["accounts"] = accs
		cJwt, err := c.Encode(kp)

Contribution
No response

resolved by #16


⚠ ClamAV has degraded performance

In efc3c24, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 209 ms

Resolved: ClamAV performance has improved in dfa6ee5.


WinterCMS Port?

Check if a WinterCMS port is possible with just a little effort.
Related:
https://github.com/RatMD/newshub-theme/issues/3

Hi
@SamBrishes
Greetings.
I used this plugin in octobercms, very advanced and works well.
If this plugin can be used in wintercms, it would be great. If it can be used in wintercms after a bit of work, I strongly urge you to make it.
thank you.

Seems like someone already did a WinterCMS fork of my bloghub plugin. Probably the best (and only) solution at the moment.
-> https://github.com/for-wintercms/wn-bloghub-plugin


Top and low students

Write a function that takes a list of dictionaries with students data and return a list with the top and the low students.
StudentData = Dict[str, Union[str, List[int]]]  # student data type alias
StudentsList = List[StudentData]  # students data type alias

Resolved with b969453f984dc837fca0698913b7aff56a16af08


docs: clarify that status === 'loading' is equivalent to isLoading

In the section on background fetching indicators in the docs, make it clearer that status === 'loading' is equivalent to the isLoading variable.

Closing because this repo has been succeeded by TanStack Query.
@DamianOsipiuk It was not clear to me that this project was moved to TanStack Query because I was looking mainly at the docs at https://vue-query.vercel.app/ and pages other than the main readme.md page when I made this PR. We had several team members make the same mistake because we were only looking at the deployed docs and we didn't see the message on readme.md. Please consider either archiving this GitHub repo or putting an obvious warning in the GitHub project's description, and updating https://vue-query.vercel.app/ with an obvious warning to stop others from following the same path we did. Thank you!

@curtgrimes Thanks for suggestion.
I have added a section on top of the main page in docs.
As for the package deprecation, it might happen when v5 will be out.

Thank you! Really appreciate your work on this.


the pretrained checkpoint of Total3DUnderstanding for ODN

Hello!
Is the link of the pretrained checkpoint of Total3DUnderstanding for ODN in Training and Testing wrong?
I find it is same as the link of the preprocess SUN-RGBD data in Data preparation

Hi. Thanks for your response! The link is fixed in the latest commit.

Thx!


Add -isystem flag in CPPFLAGS of Makefile, because if Lua and Lua internals are installed in the same machine, sometimes compiler finds it troublesome regarding which Include directory to use, /usr for Lua or /usr/local for Lua internals. Maybe don't need this if Lua internals always copes up with the upstream Lua version, but I would like to keep it just incase. Noteworthy to mention, using -I won't do.
Update tracebacks tests, removing the change directory to each tests. Makes the tracebacks inconsistent (module traces having path prefix where Lua traces does not) in the tests and also unnecessary now that we don't have separate Makefiles to take care of.

Resolves #13

Since renaming pt-run is an API change that will break Pallene builds, can we implement pallene-tracer version numbers before we merge this?

Let's do it after we are done stabilizing it? We are almost done tbh

I think we better merge this after Lua internals and Pallene is bumped up to 5.4.7.

Agreed on merging this after 5.4.7
As for the version numbers, I suppose we might as well do it now? We already had unrelated Pallene PRs breaking because of ptracer API changes.

Yes, let's do version tagging after this merge. I will come up with commits fixing the nits tomorrow. We won't be releasing on this tag though. Also it would be wise to mark the tag as alpha if possible.

The problem is that since we switched Pallene to use the separate pallene tracer repo, any changes we make here break the CI on all the Pallene PRs, including that one that Gabriel is working on. Can we please do the version numbers first?

Fine by me. But it would have been great if we had atleast pt-lua. If version numbers can wait one more day, I can complete this PR and then can do version numbering.

Have I tested with LUA_PREFIX=/usr/local? Yes.
It does not work, simple as that. There is nothing to be convinced about. the -I prefix supposed to append the dir to the leftmost (or topmost) header searching path string, but clearly the verbose logging I showed you earlier does not follow that. I also have double checked for multiple times, it does not work.

In the verbose logging, you use -I/usr/include and -L/usr/lib compilation flags. Why wasn't it /usr/local?

@hugomg Again, that's not the point. I used it because in my case if I wanted to compile pt-lua against my system Lua. It was still grabbing Lua internal headers from /usr/local/include, the -I was not working. So, I had to switch to -isystem for that. Now, the situation can be very well vice versa, say you have a backdated Lua in your system that you want to compile against and a newer version of Lua is installed in /usr/local.
By the way, using /usr/local was still giving me errors, because as usual with -isystem the /usr/local was getting resolved first.

I highly suggest that you try the -isystem flag yourself. Also try having Lua internals 5.4.6 with you, that would make my point aloud.

That is not a configuration that we have to support. The C header file include system is not designed to handle using ptracer from usr/local but then not using the Lua from /usr/local. If the user really wants to do that, they should install lua-internals and ptracer to different prefixes.

I am not convinced. The -I flag is not clearly working as the documentation suggested. Moreover, users won't be using our Makefile to build other projects, so I think the flag is fine. If the -I flag works as intended, we may change it back.
As for prefixes. I am pretty much sure users won't like to make their life a hassle by installing to a different prefix and adding it to their path just for a single goddang flag, which is not total taboo.

Should we create version tag after merging this? Because regardless, we have to make changes to Pallene with another PR.

We're overdue for a version tag Em 14 de ago. de 2024 9:24 AM, SD Asif Hossein @.***> escreveu:
Should we create version tag after merging this? Because regardless, we have to make changes to Pallene with another PR.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>


AnimatedSprite: Remove play()'s backwards, add methods to compensate

Closes https://github.com/godotengine/godot-proposals/issues/5286 (see comments).
Closes https://github.com/godotengine/godot-proposals/issues/4506.
Supersedes https://github.com/godotengine/godot/pull/41821.
A bit of a backstory:
#65148 added the ability to set speed_scale to a negative value and if it is, the animation plays in reverse. This is good. However, the original intention of the proposal was to have play()'s second parameter, "backwards", implicitly switch speed_scale's sign if necessary. Doing this would have closed the proposals above. This was not agreed upon. Instead, what ended up happening was that... basically, setting "backwards" to true and speed_scale to -1 has the animation moving forward. This is not just confusing, but defeats the original purpose of that PR, because now there is one "backwards" that is not exposed to the user.

This PR outright removes play()'s second parameter from AnimatedSprite2D and AnimatedSprite3D. This makes speed_scale > 0.0 the one consistent way to verify if an animation is playing in reverse.
To compensate, adds play_forward() and play_backwards() as shorthand methods. Both of these methods change the sign of speed_scale only when necessary, then call play(). This is like #65148 's original implementation, but split in two separate, way more explicit methods.
I should follow this up with a Proposal.

This breaks consistency with AnimationPlayer. It is theoretically correct that reverse playback in negative scale is forward playback, and I don't see this as a problem.
If you don't need the reverse playback feature, just don't use it, and this is not a reason to remove it. You can always just guarantee it as false in your project.
Moreover, at least you can get the direction of playback of the animation correct by just storing the flags on the script during playback and inverse speed_scale as needed.

Closes godotengine/godot-proposals#5286 (see comments).
Closes godotengine/godot-proposals#4506.

I think, given the changes/discussion from #65148, to solve these proposals the backwards property should be exposed instead (as suggested in https://github.com/godotengine/godot/pull/65148#issuecomment-1244055452). Whether play() should still have backwards parameter would be up to debate, for me it would be no longer needed. I don't think separate play_forward() and play_backwards() are needed.

This breaks consistency with AnimationPlayer. It is theoretically correct that reverse playback in negative scale is forward playback, and I don't see this as a problem.

If we want to bring up consistency with AnimationPlayer, play_backwards() should still be a method, in that case.

I think, given the changes/discussion from https://github.com/godotengine/godot/pull/65148, to solve these proposals the backwards property should be exposed instead.

I wouldn't expose it as a property at this point. It seems like is_playing_backwards() may still be the solution to go for, and a very simple one, at that.

If we want to bring up consistency with AnimationPlayer, play_backwards() should still be added, in that case.

This can be supported. Perhaps just implement it as a wrapper function, but it is good for consistency.

I wouldn't expose it as a property at this point. It seems like is_playing_backwards() may still be the solution to go for, and a very simple one, at that.

I was thinking about the easiness of checking/unchecking backwards from the inspector contrary to typing in the negated speed_scale (for use cases like the one from https://github.com/godotengine/godot-proposals/issues/5286). But if already allowed negative speed_scale is considered good enough for it then just adding is_playing_backwards() would be sufficient indeed.

I wouldn't want users to write (speed_scale < 0.0 !=stored_flag_i_have_created_by_overridding_play) for the sake of consistency

The user should know in which mode is playing. Therefore, there is no need to implement the function is_playing_backwards() in the core for a one-line branch that can be confusing, since the documentation can explain it.
e.g.)
To know if the frames of the animation are playing in the order in which they are set, the following code can be used:
var speed_scale: float = -1.0
var played_backward: bool = true

AnimatedSprite.set_speed_scale(speed_scale)
AnimatedSprite.play("AnimationName", played_backward)

if speed_scale > 0.0 != played_backward:
    # Playing forward
else:
   # Playing backward

Closing, as this makes things more complicated than they actually are. It goes against the simplicity and ease of use of AnimatedSprite.

Closing, as this makes things more complicated than they actually are. It goes against the simplicity and ease of use of AnimatedSprite.


520 errors

some users are reporting HTTP 520 errors. See https://wordpress.org/support/topic/getting-a-520-error-on-wp-admin-after-plugin-install?replies=3
520 is a catchall error code for issues the server doesn't otherwise know how to handle. That's going to make this difficult to troubleshoot. Possibly HHVM resonated?

Possibly helpful? https://support.cloudflare.com/hc/en-us/articles/200171936-Error-520

Hi Dave, I just installed your plugin to take advantage of the recent support of server push by cloudflare and I had the same issue, I am using bluehost hosting and no HHVM. Maybe it's cloudflare related since server push support is recent.
Let me know if there is anything I can do to help you.
Thanks.

In Cloudflare's 520 doc linked above, they mention an issue if HTTP headers are bigger than 8k. Here are Cloudflare's docs on testing against the "origin" server to rule out the header issue https://support.cloudflare.com/hc/en-us/articles/219304477

Same issue here, however this is occurring more with asset-heavy plugins (eg. Visual Composer).
Is it perhaps an idea to have an option to run http2 server push only on the front-end and have it disabled in wp-admin?


FIX: Pipe subprocess stdin to DEVNULL

I'm running a pyaedt script from a process that does not always have a stdin. When I call pyaedt.Desktop(), it fails to create the subprocess with this exception:
Exception in thread Thread-1 (launch_desktop_on_port):
Traceback (most recent call last):
  File "C:\Python311\Lib\threading.py", line 1038, in _bootstrap_inner
    self.run()
  File "C:\Python311\Lib\threading.py", line 975, in run
    self._target(*self._args, **self._kwargs)
  File "C:\Python311\Lib\site-packages\pyaedt\desktop.py", line 80, in launch_desktop_on_port
    subprocess.Popen(" ".join(command), env=my_env, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)
  File "C:\Python311\Lib\subprocess.py", line 892, in __init__
    errread, errwrite) = self._get_handles(stdin, stdout, stderr)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Python311\Lib\subprocess.py", line 1340, in _get_handles
    p2cread = self._make_inheritable(p2cread)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Python311\Lib\subprocess.py", line 1387, in _make_inheritable
    h = _winapi.DuplicateHandle(
        ^^^^^^^^^^^^^^^^^^^^^^^^
OSError: [WinError 6] The handle is invalid

The launch_aedt() function is already setting subprocess.Popen()'s stdout and stderr to subprocess.DEVNULL, but not stdin. Setting the stdin parameter to subprocess.DEVNULL too fixes the issue.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.63%. Comparing base (6785a3b) to head (b29ab73).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4683      +/-   ##
==========================================
+ Coverage   75.78%   80.63%   +4.84%
==========================================
  Files         121      121
  Lines       54810    54810
==========================================
+ Hits        41540    44196    +2656
+ Misses      13270    10614    -2656


Show original torrent names

[X] I have checked the existing issues to avoid duplicates
[X] I have redacted any info hashes and content metadata from any logs or screenshots attached to this issue

Is your feature request related to a problem? Please describe
Show original torrent names in the torrent browser and search results, Most of the time torrent titles may contain valuable information about the content which may or may not be included in the automatically generated tags. As such it would make sense to also show the original title even if it has been indexed by TMDB. This way browsing to the contend may become easier as you don't have to open each torrent individually to see the title and estimate its quality.
Describe the solution you'd like
Add an additional line beneath the indexed title showing the original name.
Describe alternatives you've considered
I've considered opening all the indexed torrents individually which is workable, but very time consuming.
Additional context
Something like this would suffice, or maybe a show the original title toggle.

I've tested the beta, great addition thanks!


vendor prefix

I noticed that inline styles are not prefixed
display:flex

should be:
 display: -ms-flexbox;
 display: -webkit-flex;
  display: flex;

This comment might help you. In the meantime. I'm closing this issue as we are moving aways from the inline-style approach to a CSS-in-JS one. The auto-prefixing was working as far as I know. Feel free to try out the next branch.

ahhh.. so it's
//getMuiTheme.js
import autoprefixer from '../utils/autoprefixer';
(which uses 'inline-style-prefixer')

  const transformers = [autoprefixer, rtl, callOnce].map((t) => t(muiTheme))
    .filter((t) => t);
  muiTheme.prepareStyles = compose(...transformers);

and each component will do their own vendor prefix. e.g. for AppBar, it explicitly autoprefix it's left icon item, its tile and its right icon item
    const titleElement = React.createElement(titleComponent, {
      onTouchTap: this.handleTitleTouchTap,
      style: prepareStyles(Object.assign(styles.title, styles.mainElement, titleStyle)),
    }, title);

I passed in a custom component as the iconElementRight, and the style I was talking about was applying to the custom component, so Mui has no visibility to it, hence it won't autoprefix it. I can call prepareStyle explicitly to autoprefix my style if I want.
anyway, thanks for your help and I think I've got the answer.
the next branch seems more promsing. I'll try it now. thanks again!!

I though it was a different issue, sorry.
I'm glad you found the answer on you own.


After completing the challenge it shows something is not right and map is not working while doing challenges

Get Set for our Responsive Web Design Projects

https://beta.freecodecamp.org/en/challenges/applied-responsive-web-design-projects/get-set-for-our-responsive-web-design-projects
Issue Description
After completing this challenge it shows something went wrong and doesn't redirects to next page also the map won't work when you are on challenges in case you want to navigate through the map then you need to open a separate tab for it and work in other tabs
Browser Information

Chrome, Version 62.0.3202.94 (Official Build) (64-bit)
Operating System: Linux Mint Cinnamon
Mobile, Desktop, or Tablet: Desktop

Your Code

Screenshot

@RitikPatni Are there any messages in the developer tools console?

@Bouncey nothing is working now not even the search box or the map so I can't navigate to the error I'm attaching the console screenshots so that you can look into the issue


Reorganise tests

What kind of change does this PR introduce?
Reorganise tests in feature folders
Does this PR introduce a breaking change?
No

Coverage remained the same at 100.0% when pulling 1df1beda36c0c441b78b125f6213b0b75e3f2fde on test-restructuring into 684b03ce3b4efece46d93570c389ebf7d8891559 on master.

Hey @Meemaw,
I checked the the filing test output end it might be related to the way we interact with testing-library and JSDOM when we render html/head/body elements.
This is the JSDOM DOM structure when test fails:

            [...]

            [index page, count 1]

                [...]

                [index page, count 1]

        [...]

        [index page, count 1]

Interesting. Given the flaky nature, it almost feels like DOM is not properly cleaned up and it leaks into next test?
Did you manage to reproduce it locally by any chance? Its a bit hard to debug without that.

Still not, but I've stumbled upon issues between useDocument and client navigation. Still investigating... 👀  client-navigation tests seem to break by enabling useDocument.

When enabling useDocument in client-navigation tests, it seems that the router object becomes null after the first client navigation re-render.
I suspect it might deal with the way we currently wrap the page with RouterProvider and NavigationProvider. Currently the full page is rendered like this:
<RouterProvider>
  <NavigationProvider>
    <Document>
      <App>
        <Page>
      </App>
    </Document>
  </NavigationProvider>
</RouterProvider>

...which means that we re-render the custom Document runtime in NavigationProvider. I suspect custom  is designed to be rendered server-side once and then selectively updated with its own context. (Please close both eyes for the inaccuracies I just wrote 😄 ).
The following composition makes client-navigation green but breaks real-world-example tests since head element doesn't update.
<Document>
  <RouterProvider>
    <NavigationProvider>
      <App>
        <Page>
      </App>
    </NavigationProvider>
  </RouterProvider>
</Document>

I should probably make this comment an issue and move the discussion there.

Yeah, let's create an issue and I can look into this. It would be great to have a reproducer (maybe just the test that fails when setting useDocument=true).


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_502a9301-677c-42e4-96d8-48de89ee63c2/pull/1 is merged into live branch.
Auto archive content to https://github.com/OPS-E2E-PPE/docs-archive-test-target_502a9301-677c-42e4-96d8-48de89ee63c2.git

Docs Build status updates of commit 1873588:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Archive_master_2019-09-30-16-42-06 has been deleted or has been force pushed: fatal: Couldn't find remote ref Archive_master_2019-09-30-16-42-06

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fail to switch language to Chinese (Traditional)

When I switch language to Chinese (Traditional), it always switch to Chinese (Simplified). I guess it's related to  https://github.com/edumeet/edumeet/blob/707c486ba650d6cbc25c246fc2308b0f9d113140/app/src/translations/locales.js#L127
I'm on master branch

Hi @ray1422, should be fixed now on develop branch and soon on master. Please test.
Thanks again.


update the tikv adopters

Signed-off-by: Wenting Liu<EMAIL_ADDRESS>
What problem does this PR solve?
The list of TiKV adopters is out of date, so it needs to be updated.
What is changed and how it works?
The list of TiKV adopters is updated.

/merge

/merge


[UX] Provide Focus State for Buttons, etc.

Hi! This seemed like a very useful site/app from the moment I first saw it and now that I’ve had the chance to play around with it a little, that impression hase proven true. Thanks for making it!
Now the only thing that I think could use a little work is the user experience, most notably that it’s impossible to see which buttons / elements have focus when using tab to navigate the interface (for example when creating fields for a POST request).
In general, I feel like the UI could be streamlined and made more concise to make better use of space, but I get that this project is in its early days and that might not be the focus yet. Keep up the great work!

Glad you liked it 💜
Improving UI/UX is a must. Keep suggesting your thoughts and we will consider them.

Sure, here are some more thoughts:

The request group is probably the most used group next to the response and request body groups, but the way the application is currently set up, it scrolls down after every request and then requires to scroll back up to change the request and send it again. How about putting the request options and the response field next to each other on displays of a sufficient size? And on mobile, where this option isn’t possible, perhaps at least the entire request group could become sticky when the view is scrolled down so it’s always reachable?
It’s not very clear that the name of a group has to be clicked in order to expand it, perhaps the entire frame could be clickable, or there could be dedicated expand/collapse buttons?
When clicking the Use button in the history, I would expect the entire request to be restored, i.e. including body and other fields
This last one might be personal, but I feel the dark background in the dark theme is too dark and causes too harsh a contrast with the light text and the colors, maybe that could be brightened up a little, or it could be split up in a dark and a dimmed theme

I think that’s it for now (I haven’t been using the app a lot yet after all), but if something else comes up, I’ll try to tell you about those as well. :blush:
Thanks for being open and recognising the importance of good UX!

I'll get on these and submit a PR with a bunch of UI tweaks!

Added few of of @amxmln suggestions

Fixed in #130

Hye guys.. @amxmln @NBTX @abraham @larouxn @izerozlu @yubathom @nickpalenchar @AndrewBastin @reefqi037
Check this out: Podcast about Postwoman: https://www.opensourcedevpod.com/episodes/postwoman-flying-through-the-network

@amxmln Would you mind checking out the updated color schemes and give review?
Don't forgot to force refresh (Ctrl + Shift + R) and apply color schemes from Settings page.

Hi, @liyasthomas, I had a quick look and it’s already much better.👍 Great work! I’m also happy about the new focus state for buttons, however, I think that the input and select fields would also benefit from one.

@liyasthomas Sorry, I've been kinda swamped this week!
I checked out the new color scheme and it's 🔥! Though I think we're gonna need to put a bit more work into the light theme at some point.
...and I'm just listening to the podcast now.

Major UI update is on the way 🔥
postwoman.io had a silly, non-professional UI.
It has been updated with better color schemes, icons and components.
Please review and give suggestions ✨

Reached 100/100 Lighthouse score 🎉 🎉


Improve storage SDK IPFS upload error logging

Problem solved

This PR makes logging of upload errors more explicit by outputting the status, status text, and server response of the upload

Changes made

[x] Internal API changes

How to test

[x] Manual tests: step by step instructions on how to test

This can be tested by attempting to upload a file on a broken Internet connection

/release-pr


treat ollama run model < file as entire prompt, not prompt-per-line

Previously, ollama run treated a non-terminal stdin (such as ollama run model < file) as containing one prompt per line. To run inference on a multi-line prompt, the only non-API workaround was to run ollama run interactively and wrap the prompt in """...""".
 For example, if myprompt.txt is a multi-line file, then ollama run model < myprompt.txt would treat myprompt.txt's entire contents as the prompt.
This breaks backcompat, but I believe this behavior is better than the old behavior. It is strictly more powerful than the prior behavior because callers can split a file by lines outside of Ollama and then invoke ollama run once per line on their own.
This is related to https://github.com/jmorganca/ollama/issues/357, but that refers to interactive usage.

I'm unsure about this change. It's already possible to ingest an entire file using positional parameters: `ollama run  llama2 "$(cat input.txt)". It's not idiomatic nor is it obvious but it's possible.
OTOH, reading a file and processing by line is only possible by reading stdin. This is different than something like while read LINE; do ollama run llama2 $LINE; done <$FILE because each subsequent prompt is passed the context from the previous prompts. It makes it possible to do things like this:
cat <<EOF | ollama run llama2
Write a story about llamas.
Now rewrite it in the style of Shakespeare.
Now rewrite it in the style of Dr. Seuss.
EOF

I have been thinking about how to ingest an entire file because the current methods aren't great. Here are a few inspirations:

jq --slurp

           Instead of running the filter for each JSON object in the input, read
           the entire input stream into a large array and run the filter just
           once.

xargs -0

             Change xargs to expect NUL (``\0'') characters as separators,
             instead of spaces and newlines.  This is expected to be used in
             concert with the -print0 function in find(1).

There's also --file which can indicate a file input in addition to positional arguments, e.g.:
$ ollama run -f input.txt llama2 'summarize this file'

The downside of every options is the need for additional flags which I'm not keen on

My assumption: I assume ollama run will be primarily invoked by people building applications that use LLMs during testing, and by those applications in the background at runtime. That describes how I intend to use ollama run, at least. You all obviously have a much broader view of the userbase and your own vision, which I totally respect!
--
@jmorganca:

This is great! I've been thinking about the combination as well:
ollama run codellama "write unit tests for this code" < main.go

I don't think that is viable. Invoking ollama run in that way leaves unspecified the prompt construction and context formatting. For example, how is the final prompt actually constructed? Which parts of the file are included? Etc. All of these are absolutely critical to a good result.

@mxyng:
Thank you for the pointer about ollama run llama2 "$(cat input.txt)". I had not thought of that, but yeah, something like that should work. Under my assumption stated above, this would be the primary way ollama run is invoked and would merit being the default, but that's your call.
Thank you both!

this sounds like a breaking change,
for any usages that depended on there being a single prompt per line
many automated tests might want to have this precise behaviour
I recommend to reject this change
if you need to do long prompt processing, you can always use the API endpoint method

@sqs is it possible to rebase this branch onto main ? otherwise happy to open a new PR from a branch in this repo if that's easier!


Adding Coveralls

This PR should add test coverage monitoring to Travis builds.
Feedback is appreciated, since I've never messed with Travis or Coveralls before! I'm especially not sure if there is a better way to send coverage results to Coveralls in the Travis config. Right now it does some stuff along side the tests:
npm test && echo "Reporting coveralls" && cat coverage/lcov.info | node_modules/coveralls/bin/coveralls.js && rm -rf ./coverage

Let's see if this thing works - testing on my fork seemed to work
ember-cli-code-coverage and coveralls is added to the project.
Coverage can be triggered by setting environment variable COVERAGE=true
You can get the test coverage locally if you want: COVERAGE=true npm test which will create a ./coverage directory with the results.

You can't send results to Coveralls locally without the repo_token

So many package-lock.json changes

All of this looks great! Just to make sure, have you enabled coveralls for the OA-PASS repo?

Yep, enabled for OA-PASS/pass-ember. Do we want it to leave comments on PRs? I just saw a setting for the repo that has comments coveralls comments disabled by default

I'm fine just having it in the Checks section. Stays out of the way a little bit more.

Also, this looks great, everything is properly configured. Merging!


Exceptions are raised because of utf-8 string in function names.

I try to analyze some java project which includes functions that use 한글 (Hangul) as function name.
한글 (Hangul) is used rarely for test functions like, test_ABC_성공() (it means test_ABC_success())
In that case, I encountered following python exceptions.

This exception is reported at first time when I run Infer with the utf-8 string (not English) functions.

Starting analysis (Infer version v0.7.0)
Computing dependencies... 100%
Analyzing 318 clusters....................................................................................................................................................................................
..........................................................................................................................................
Traceback (most recent call last):
  File "/infer/infer/bin/infer", line 170, in <module>
    main()
  File "/infer/infer/bin/infer", line 156, in main
    analysis.analyze_and_report()
  File "/opt/infer-linux64-v0.7.0/infer/lib/python/inferlib/analyze.py", line 577, in analyze_and_report
    report_status = self.create_report()
  File "/opt/infer-linux64-v0.7.0/infer/lib/python/inferlib/analyze.py", line 534, in create_report
    issues.clean_json(self.args, json_report)
  File "/opt/infer-linux64-v0.7.0/infer/lib/python/inferlib/issues.py", line 131, in clean_json
    rows = utils.load_json_from_path(json_report)
  File "/opt/infer-linux64-v0.7.0/infer/lib/python/inferlib/utils.py", line 135, in load_json_from_path
    return json.load(file_in, encoding=config.LOCALE)
  File "/usr/lib/python2.7/json/__init__.py", line 286, in load
    return loads(fp.read(),
  File "/usr/lib/python2.7/codecs.py", line 674, in read
    return self.reader.read(size)
  File "/usr/lib/python2.7/codecs.py", line 480, in read
    newchars, decodedbytes = self.decode(data, self.errors)
UnicodeDecodeError: 'utf8' codec can't decode byte 0xed in position 10615: invalid continuation byte

This exception is reported when I run it again.

Traceback (most recent call last):
  File "/infer/infer/bin/infer", line 170, in <module>
    main()
  File "/infer/infer/bin/infer", line 120, in main
    analyze.remove_infer_out(args.infer_out)
  File "/opt/infer-linux64-v0.7.0/infer/lib/python/inferlib/analyze.py", line 191, in remove_infer_out
    shutil.rmtree(infer_out, True)
  File "/usr/lib/python2.7/shutil.py", line 247, in rmtree
    rmtree(fullname, ignore_errors, onerror)
  File "/usr/lib/python2.7/shutil.py", line 241, in rmtree
    fullname = os.path.join(path, name)
  File "/usr/lib/python2.7/posixpath.py", line 73, in join
    path += '/' + b
UnicodeDecodeError: 'ascii' codec can't decode byte 0xeb in position 80: ordinal not in range(128)

I run it in docker which is built by Dockerfile, but I checked that same exceptions are reported on my local Ubuntu environment.
P.S. Line numbers in above call trace could not exactly same with others log, because I added some debug code in python code.

It is hard to set an environment and code which triggers above exceptions. I will figure out how to set an environment to reproduce the above bug, and share it on this issue.

Hi @kstreee, have you tried with the latest master? there's a good chance that this issue was solved in dc52ce8158c51e22e16c36997324f6b089d6b560. Let me know if it works for you.

@jvillard I tested above bug using Infer version v0.7.0-379d185, but exceptions are reported again.
Some UTF-8 characters are handled well by Infer, but some other characters causes the exceptions. I will find reasons of it more.

I am also experiencing this issue. bump thread

@kstreee, @adamhowardprice What's your locale? (locale)
I cannot reproduce this locally, so a minimal example would help.

Also, what's the full path of the current directory you are running Infer from?
@adamhowardprice which trace do you get? @kstreee reported two different ones.
Thanks!

Actually, I can reproduce this if the locale is set to something that doesn't support the characters in the files that are analysed, eg LC_ALL=C and some function names have utf-8 names. Working on a fix.

@jvillard The Infer binary lives in /Users/spotify-buildagent/.vulcan/cache/infer-0.7.0-osx-x86_64.zip-7476817ede427b9e2a2586f57d09a216fa353117/extracted/infer/lib/python/infer and is being invoked from /Users/spotify-buildagent/buildAgent/work/c2c5a1e10baf8cc9
locale:
LANG="en_US.UTF-8"
LC_COLLATE="en_US.UTF-8"
LC_CTYPE="en_US.UTF-8"
LC_MESSAGES="en_US.UTF-8"
LC_MONETARY="en_US.UTF-8"
LC_NUMERIC="en_US.UTF-8"
LC_TIME="en_US.UTF-8"
LC_ALL=

My trace:
Traceback (most recent call last):
[23:24:52]W:	 [Step 2/3]   File "/Users/spotify-buildagent/.vulcan/cache/infer-0.7.0-osx-x86_64.zip-7476817ede427b9e2a2586f57d09a216fa353117/extracted/infer/lib/python/infer", line 170, in <module>
[23:24:52]W:	 [Step 2/3]     main()
[23:24:52]W:	 [Step 2/3]   File "/Users/spotify-buildagent/.vulcan/cache/infer-0.7.0-osx-x86_64.zip-7476817ede427b9e2a2586f57d09a216fa353117/extracted/infer/lib/python/infer", line 156, in main
[23:24:52]W:	 [Step 2/3]     analysis.analyze_and_report()
[23:24:52]W:	 [Step 2/3]   File "/Users/spotify-buildagent/.vulcan/cache/infer-0.7.0-osx-x86_64.zip-7476817ede427b9e2a2586f57d09a216fa353117/extracted/infer/lib/python/inferlib/analyze.py", line 587, in analyze_and_report
[23:24:52]W:	 [Step 2/3]     issues.print_and_save_errors(json_report, bugs_out)
[23:24:52]W:	 [Step 2/3]   File "/Users/spotify-buildagent/.vulcan/cache/infer-0.7.0-osx-x86_64.zip-7476817ede427b9e2a2586f57d09a216fa353117/extracted/infer/lib/python/inferlib/issues.py", line 233, in print_and_save_errors
[23:24:52]W:	 [Step 2/3]     text = _text_of_report_list(errors)
[23:24:52]W:	 [Step 2/3]   File "/Users/spotify-buildagent/.vulcan/cache/infer-0.7.0-osx-x86_64.zip-7476817ede427b9e2a2586f57d09a216fa353117/extracted/infer/lib/python/inferlib/issues.py", line 182, in _text_of_report_list
[23:24:52]W:	 [Step 2/3]     line,
[23:24:52]W:	 [Step 2/3]   File "/Users/spotify-buildagent/.vulcan/cache/infer-0.7.0-osx-x86_64.zip-7476817ede427b9e2a2586f57d09a216fa353117/extracted/infer/lib/python/inferlib/source.py", line 82, in build_source_context
[23:24:52]W:	 [Step 2/3]     for line in source_file:
[23:24:52]W:	 [Step 2/3]   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 687, in next
[23:24:52]W:	 [Step 2/3]     return self.reader.next()
[23:24:52]W:	 [Step 2/3]   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 618, in next
[23:24:52]W:	 [Step 2/3]     line = self.readline()
[23:24:52]W:	 [Step 2/3]   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 533, in readline
[23:24:52]W:	 [Step 2/3]     data = self.read(readsize, firstline=True)
[23:24:52]W:	 [Step 2/3]   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 480, in read
[23:24:52]W:	 [Step 2/3]     newchars, decodedbytes = self.decode(data, self.errors)
[23:24:52]W:	 [Step 2/3] UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 0: ordinal not in range(128)
[23:24:52]W:	 [Step 2/3]
[23:24:52]W:	 [Step 2/3]
[23:24:52]W:	 [Step 2/3]      [31mCOMMAND FAILED: infer -- xcodebuild NSUnbufferedIO\=YES SPT_EXTRA_CFLAGS\=-fno-modules CODE_SIGN_IDENTITY\= CODE_SIGNING_REQUIRED\=NO -workspace Spotify\+features.xcworkspace -scheme Spotify -configuration Release -sdk iphoneos -derivedDataPath build/infer-dd [0m
[23:24:52]W:	 [Step 2/3] Process exited with code 1


Registering your Native Module code example out of date

The C Sharp example in the "Registering Your Native Module" section of the docs is out of date. I'm not sure what you're using as an html editor, so I'm creating a bug instead of a PR.
https://microsoft.github.io/react-native-windows/docs/native-modules#2-registering-your-native-module
It needs to look like the NativeModuleSample code in order for things to compile.
using Microsoft.ReactNative;
using Microsoft.ReactNative.Managed;

namespace NativeModuleSample
{
    public partial class ReactPackageProvider : IReactPackageProvider
    {
        public void CreatePackage(IReactPackageBuilder packageBuilder)
        {
            CreatePackageImplementation(packageBuilder);
        }

        /// <summary>
        /// This method is implemented by the C# code generator
        /// </summary>
        partial void CreatePackageImplementation(IReactPackageBuilder packageBuilder);
    }
}

@jonthysell : I had actually updated the samples when updating the docs, but you asked me to revert the samples. Do you remember why and if that is still valid?

The samples now have the right code changed in PR #209

The samples now have the right code changed in PR #209


[Enhancement] Sniping edited messages

Users can ghost ping by editing the message which contains the mention. Implement a feature to tackle this 😎
also enjoy your :pain:

Implemented in<PHONE_NUMBER>6f97a0c52edb2f507bd8ee573d4cdb


Feature/testing

This PR adds proof-of-concept for E2E Testing of UI based on cypress.
UnitTesting of single Components is in progress and I'm undecided to use cypress or not for it (see this ).
The added 'Feature' (here called Spec) is only a stub for now to test the framework integration.
Library support for:

Mocking remote requests via MSW: support is both during developement, to use Mock API and/or during E2E

[x] Adding a *.mocks.ts file, enable Mocks during Developement AND Testing. These are 'global', always enabled.
[x] Mocks can be further added/overriden during Testing on each Test cases
[x] Reset RTKQ cache between Test cases
[ ] Test correct RTKQ cache cleanup between tests
[ ] Avoid MSW worker and library to be included in build (neither in /public nor bundles)

Navigation via Menu OR Router: navigation cannot be done using the Url bar (cy.visit) as that reloads the entire page, instead of navigating as an SPA.

[x] Custom Cypress commands for Navigating via the Menu or the internal Router
[ ] support Navigating via 'closed' Accordion menu entries (or remove the Accordion ?)
[ ] Test for tracking the 'active' menù entry and ensuring Accordion is opened correctly in case of Hardlink usage to a default closed section

CI pipeline:

[x] GihHub Actions
[ ] Azure Dev Ops

Next steps:

Support for CodeCoverage

[ ] Library integration
[ ] GitHub CI
[ ] ADO CI

Support for Testing the Build output

[ ] use build output via vite preview when using headless e2e:ci to ensure to test the same code that goes in PROD.

there is a slight conflict as in PROD we don't want to include MSW dependency (both for security and bundle size) but we need MSW to test the production build.

Test all 'library' capabilities

[ ] GDPR Cookie Banner
[ ] Table Components including Pagination, Spinners and Error handling
[ ] Form Components including 'binding' remote call payload, validation messages, submit error handling
[ ] i18n translations testing, both support for cimode and for LocaleSwitcher component
[ ] Global Loading Bar
[ ] Global and Router Error Boundary
[ ] Auth: Login flow including Auth0 and AzureAD, token expiration and refresh
[ ] Authz: Permission handling, including protected routes and 'disabled' actions/buttons via hooks

RFC @AndreaLandiArk @MarcoGix @sean-sligo @Mirko92 @thomasdonlon5
To see it in action:

npm run e2e:start to see how cypress work, used during development
npm run e2e:ci to run headless

Comments welcome on what you think is useful to improve UI reliability reducing regressions and improving quality.


DIT with no sigma_D sampling in a evenly-spaced log grid (MODIT)

DIT for a evenly-spaced logarithm wavenumber grid (ESLOG) is straightforward for the framework of exojax, considering the instrument response, RV, and a rotation broadening.
Based on the snippet and with the great help by @dcmvdbekerom, I made a modified version of DIT in addit prior to the implementation in exojax. This modified version (herafter tagged by MODIT) assumes

Input wavenumber grid evenly spaced in logarithm
Common Doppler width normalized by line center (i.e. common T for a single isotope)

The second assumption can remove the dimension of Doppler width from a DIT grid, which reduces the computational complexity.
I will implement these features into exojax prior to checking auto-diff and/or HMC works.

The branch is features/logdit.

MODIT looks better than DIT+interpolation to the log grid. It is likely the interpolation introduces errors, or a common T in MODIT improves the error (not sure though).

Emission spectrum and the response matrix worked for MODIT.

The raw spectrum and the response-applied one for CH4 using MODIT.

I should check the optimal zero padding (note).

closed w/ merge of #100

#156
Comparison for the Luhman16A model


np-api-server: wallet processblocks loop

What current issue(s) does this address, or what feature is it adding?
Added process blocks loop for open wallets to np-api-server (see #479)
How did you solve this problem?
Adding a task.loopingCall
How did you make sure your solution works?
Manual test
Are there any special changes in the code that we should be aware of?
No
Please check the following, if applicable:

[ ] Did you add any tests?
[X] Did you run make lint?
[X] Did you run make test?
[X] Are you making a PR to a feature branch or development rather than master?
[X] Did you add an entry to CHANGELOG.rst? (if not, please do)

Coverage remained the same at 79.892% when pulling b594429574296e3884fe7da98f3124c1565ba0bd on api-server-wallet-loop into 65d3240801b945ebd383c902cd9df7302937d8be on development.


MAISTRA-1920 preserve unmapped fields from SMCP v1 resources

Signed-off-by: rcernich<EMAIL_ADDRESS>The only areas where fields may be lost is when the object is part of a list, which are gateway secret and config volumes (e.g. gateways..secretVolumes), label selectors for anti/affinity, and tolerations.
Any values remaining after conversion to v2 will be stuffed into the techPreview field.  This should provide lossless conversion between v1 and v2, i.e. v1->v2->v1 should equal the original object.

v1->v2->v1 should equal the original object

This part is not really achievable I'm afraid. I wrote a quick test that does it, and I can't get it to pass, namely because we're setting a bunch of defaults (like global.meshExpansion.enabled=false) that don't convert back cleanly

I pushed my test, which is failing for the reasons I mentioned above. I really think we should try to make it pass, for two reasons:

I think it's going to avoid quite a few possible regressions regarding 1.1 deployments
We introduced yet another place where we apply defaults, which we shouldn't do IMO. I think we should put those new defaults into their values.yaml counterparts

Regarding defaults, specifically for meshExpansion, the idea behind the new config is to allow as much as possible to be configured automatically.  This means the code that configures clustering does a lot of work based on a few settings, and expansion is not configured at all if clustering is not enabled.  For example, default expansion ports are automatically added to the cluster ingress gateway, as are networks, dns suffixes, etc. when multicluster is enabled.  That said, I was considering adding an enabled field to all of this, so at least the properties could be maintained, even if they weren't being used.  I didn't do that because I didn't think many folks would be using this, but...good catch.

I've added enablement flags to the multi-cluster and mesh expansion fields to allow them to be stubbed out.  This should preserve multi-cluster configuration from v1 resources.  However, if unspecified, multi-cluster and mesh expansion are disabled (i.e they need to be manually enabled).  Also, the current logic is that if multi-cluster is enabled, so is mesh expansion.
I modified the test to remove the results of fields fanning out from v2 to v1.  For example, enabling tracing in v1 causes the tracer to be set to jaeger too (default tracer if none is specified).  This may have some effect if default values differ, but we should be configuring things so they match the default.  For example, to enable tracing with v1, you would have to set all those fields, but some of those may have been the same defaults used in values.yaml, or may have been coded in the charts for correct behavior.  The v2 resource provides explicit support for things like this, so changing the tracing provider doesn't require changes to numerous other fields (although it may look a little verbose for cases that are defaulted sensibly in values.yaml).

/test all

This also appears to partially fix MAISTRA-1902, although only by way of preserving the field from v1.  For v2, it does not get converted into telemetry.mixer.

/test istio-operator_unittests

This fixes many issues with the conversion code as well as cleaning things up a bit.  The only changes to the structure of the SMCP spec are the addition of enabled fields to multiCluster, meshExpansion, and autoScaling (where previously they were enabled if not null).  I've also added more tests, specifically around profiles, and fixed bugs that I found there.  This should get merged as soon as possible.

@luksa, mind giving this a review?  Sorry it's so big.  I'm mostly concerned about the updates to the validation logic.  I added logic to ensure the smcp resource is configured consistently, as some mixer settings are shared between policy and telemetry in v1.x.


Problem with your middleware location and references also

ReflectionException in Container.php  Class Escuccim\Resume\Http\Middleware\AdminMiddleware does not exist

Fixed. Thank you.


{"name":"cardano-graphql","hostname":"08b292cf80dc","pid":1,"level":30,"msg":"Initializing { module: 'HasuraClient' }","time":"2021-06-11T05:15:09.571Z","v":0} {"name":"cardano-graphql","hostname":"08b292cf80dc","pid":1,"level":30,"msg":"GraphQL HTTP server at http://<IP_ADDRESS>:3100/ started","time":"2021-06-11T05:15:09.911Z","v":0}

I use "docker logs -f  cardanographql_cardano-graphql_1",Iti is this, but I cant connect to it , telnet is not usable

I'm not sure if it's related as your issue reports and very vague, but please use only #514 until we get you up and running

"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Initializing { module: 'HasuraClient' }","time":"2021-06-11T07:13:26.168Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"GraphQL HTTP server at http://<IP_ADDRESS>:3100/ started","time":"2021-06-11T07:13:26.628Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Initializing { module: 'HasuraClient' }","time":"2021-06-11T07:13:26.653Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Initialized { module: 'HasuraClient' }","time":"2021-06-11T07:16:25.565Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Initializing { module: 'DataSyncController' }","time":"2021-06-11T07:16:25.566Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Initialized { module: 'HasuraClient' }","time":"2021-06-11T07:18:58.205Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Initializing { module: 'DataSyncController' }","time":"2021-06-11T07:18:58.205Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 1 }","time":"2021-06-11T07:19:00.664Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 2 }","time":"2021-06-11T07:19:02.306Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 1 }","time":"2021-06-11T07:19:04.756Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 1 }","time":"2021-06-11T07:19:32.392Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 1 }","time":"2021-06-11T07:20:17.087Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 1 }","time":"2021-06-11T07:20:35.760Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 1 }","time":"2021-06-11T07:21:03.812Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 1 }","time":"2021-06-11T07:21:06.828Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 1 }","time":"2021-06-11T07:21:12.491Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 1 }","time":"2021-06-11T07:21:21.416Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 1 }","time":"2021-06-11T07:21:26.073Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 3 }","time":"2021-06-11T07:22:03.365Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 2 }","time":"2021-06-11T07:22:07.730Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 1 }","time":"2021-06-11T07:22:09.498Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 1 }","time":"2021-06-11T07:22:11.079Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 2 }","time":"2021-06-11T07:22:25.049Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 1 }","time":"2021-06-11T07:22:30.490Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 1 }","time":"2021-06-11T07:22:34.135Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 2 }","time":"2021-06-11T07:23:20.449Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"DB ready","time":"2021-06-11T07:23:26.450Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 1 }","time":"2021-06-11T07:23:36.916Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 1 }","time":"2021-06-11T07:23:53.048Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 1 }","time":"2021-06-11T07:23:56.236Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 1 }","time":"2021-06-11T07:24:05.921Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 1 }","time":"2021-06-11T07:24:25.214Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 1 }","time":"2021-06-11T07:24:44.479Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 2 }","time":"2021-06-11T07:24:54.793Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 1 }","time":"2021-06-11T07:27:14.037Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 1 }","time":"2021-06-11T07:28:54.152Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 1 }","time":"2021-06-11T07:30:05.672Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 1 }","time":"2021-06-11T07:30:11.223Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 2 }","time":"2021-06-11T07:31:11.382Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":40,"msg":"DbClient.pgSubscriber: cardano-db-sync-extended starting, schema will be reset","time":"2021-06-11T07:31:29.925Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 1 }","time":"2021-06-11T07:31:31.522Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 3 }","time":"2021-06-11T07:31:48.001Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 1 }","time":"2021-06-11T07:32:01.362Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Adding metadata to assets { module: 'HasuraClient', value: 1 }","time":"2021-06-11T07:32:09.803Z","v":0}
ClientError: database query error: {"response":{"errors":[{"extensions":{"path":"$","code":"unexpected"},"message":"database query error"}],"status":200},"request":{"query":"query {\n          cardano { \n              currentEpoch {\n                  adaPots {\n                      reserves\n                  }\n              }\n          }\n          rewards_aggregate {\n              aggregate {\n                  sum {\n                      amount\n                  }\n              }\n          }\n          utxos_aggregate {\n              aggregate {\n                  sum {\n                      value\n                  }\n              }\n          }\n          withdrawals_aggregate {\n              aggregate {\n                  sum {\n                      amount\n                  }\n              }\n          }\n      }"}}
at GraphQLClient. (/app/node_modules/graphql-request/dist/index.js:170:35)
at step (/app/node_modules/graphql-request/dist/index.js:63:23)
at Object.next (/app/node_modules/graphql-request/dist/index.js:44:53)
at fulfilled (/app/node_modules/graphql-request/dist/index.js:35:58)
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:95:5) {
response: { errors: [ [Object] ], status: 200 },
request: {
query: 'query {\n' +
'          cardano { \n' +
'              currentEpoch {\n' +
'                  adaPots {\n' +
'                      reserves\n' +
'                  }\n' +
'              }\n' +
'          }\n' +
'          rewards_aggregate {\n' +
'              aggregate {\n' +
'                  sum {\n' +
'                      amount\n' +
'                  }\n' +
'              }\n' +
'          }\n' +
'          utxos_aggregate {\n' +
'              aggregate {\n' +
'                  sum {\n' +
'                      value\n' +
'                  }\n' +
'              }\n' +
'          }\n' +
'          withdrawals_aggregate {\n' +
'              aggregate {\n' +
'                  sum {\n' +
'                      amount\n' +
'                  }\n' +
'              }\n' +
'          }\n' +
'      }',
variables: undefined
}
}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Initializing { module: 'HasuraClient' }","time":"2021-06-11T07:32:22.913Z","v":0}
ClientError: database query error: {"response":{"errors":[{"extensions":{"path":"$","code":"unexpected"},"message":"database query error"}],"status":200},"request":{"query":"query {\n          epochs (limit: 1, order_by: { number: desc }) {\n              protocolParams {\n                  protocolVersion\n              }\n          }\n      }"}}
at GraphQLClient. (/app/node_modules/graphql-request/dist/index.js:170:35)
at step (/app/node_modules/graphql-request/dist/index.js:63:23)
at Object.next (/app/node_modules/graphql-request/dist/index.js:44:53)
at fulfilled (/app/node_modules/graphql-request/dist/index.js:35:58)
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:95:5) {
response: { errors: [ [Object] ], status: 200 },
request: {
query: 'query {\n' +
'          epochs (limit: 1, order_by: { number: desc }) {\n' +
'              protocolParams {\n' +
'                  protocolVersion\n' +
'              }\n' +
'          }\n' +
'      }',
variables: undefined
}
}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Initialized { module: 'HasuraClient' }","time":"2021-06-11T07:34:34.017Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Initializing { module: 'DataSyncController' }","time":"2021-06-11T07:34:34.017Z","v":0}
{"name":"cardano-graphql","hostname":"67c14eedc5a1","pid":1,"level":30,"msg":"Initialized { module: 'DataSyncController' }","time":"2021-06-11T07:35:50.833Z","v":0}


closing a application running under wine with killactive will not close side applications such as explorer.exe etc started with the wine prefix

Regression?
No
System Info and Version
 System/Version info
<Paste the output of the command here>
hyprctl systeminfo
Hyprland, built from branch  at commit 9a09eac79b85c846e3a865a9078a3f8ff65a9259  (props: bump version to 0.42.0).
Date: Wed Aug 7 19:17:10 2024
Tag: v0.42.0, commits: 5069

flags: (if any)

System Information:
System name: Linux
Node name: fedora
Release: 6.10.3-200.fc40.x86_64
Version: #1 SMP PREEMPT_DYNAMIC Mon Aug  5 14:30:00 UTC 2024

Description
When killing a wine application (in this case launched trough lutris) with Super + C
so killactive this will kill the process for the application but background processes in the wine prefix like explorer.exe winedevice.exe etc will still keep running even trough their parent process (including lutris) is already dead.
How to reproduce
Launch Windows software trough wine (in this case with lutris) also launch it in gamescope and then kill the application with Super+C explore.exe and Winedevice.exe will keep running even trough said application said wine prefix should execute is already closed.
Crash reports, logs, images, videos
No response

Suddenly i cannot reproduce the issue anymore for some reason

I cannot reproduce it reliably so i am gonna close it until i get more reproduction steps

This might be actually more related to Gamescope / umu etc than Hyprland.


Prevent aggressive tagger retry by keeping failed fetch in cache

What does this PR do?
This PR solves issue https://github.com/DataDog/datadog-agent/issues/8341
In order to prevent aggressive tagger to aggressively retry fetching tags for the metric we rather save empty tags list into the tagstore(which is basically cache for fetched tags) but only for 1 second. After 1 second cache expires and tagger will retry again. In order to have expiring cache tagstore was modified. Now when we computeCache all the expired tags are removed.
Describe how to test your changes
Test using changes in this PR https://github.com/boh-dan/datadog-agent/pull/1.

#8420 has been merged (and backported to the upcoming 7.29 release), and I also opened #8429 to address the lifetime of the cached results. Closing this one. Again, thanks for the contrib!


All Enhancement proposals in single webpage | KEPs

This PR is for https://github.com/kubernetes/enhancements/issues/2095 and we want a KEP webpage to find out about specific kep and its metadata easily.

keps.json is generated from enhancements repo using gen-content.sh
sigs.yaml is fetched from community/sigs.yaml file

Refer: https://github.com/kubernetes/website/pull/28295

Please check the page: https://deploy-preview-222--kubernetes-contributor.netlify.app/keps/

Instead of importing directly with the hack script we can use data template to call a url and grab an updated copy of the data. A postsubmit job in the enhancements repo that generates it and dumps it to a gcs bucket with an always up to date copy would be super.

Thanks for the suggestion. Yes, we need to have CI script that will generate the YAML/JSON file if the merge has been done for new KEP and upload it. I would like to this TODO to be completed once this page is ready and merged.
If you have suggestion how to upload in gcs bucket , please share any link/documentations/sample PR.

https://deploy-preview-222--kubernetes-contributor.netlify.app/keps/ is looking pretty good.
(IMO) we should only merge this if we're happy with the toil to keep it current, though. If not, let's find a way to help get that JSON document with the KEP and SIG data available so it Hugo can fetch it via HTTP GET.
(One option that springs to mind: a GitHub Pages site).

A GitHub bot need to upload it either in Gist/repo or any storage bucket whenever a KEP is merged in enhancement repo similarly any changes in sigs.yaml file : https://raw.githubusercontent.com/kubernetes/community/master/sigs.yaml

The main thing I think this needs is automation. I'd be reluctant to see this merge unless either:

someone commits to keep this up to date manually, as often as is needed
we instead have some code to do that updating and are happy that it'll work

Yeah @sftim , automation is needed. I want to use a URL. instead of having keps_data.yaml file in data folder, so that it will fetch from there. We can have something like this : https://github.com/kubernetes/community/blob/master/sigs.yaml so that we can get it from raw github userdata URL: https://github.com/kubernetes/community/raw/master/sigs.yaml
I have started the discussions here:

https://github.com/kubernetes/enhancements/pull/2801
https://github.com/kubernetes/community/issues/5862

Since Hugo doesn't suppot getYAML we only have getJSON so I want to have sig metadata in JSON

I have explored hack/gen-content.sh and now this PR do not have any dependency.

It is fetching the sigs.yaml from the community repo
It is generating keps.json file from the enhancements repo - kepctl query command

Only one change we have to do : https://github.com/kubernetes/enhancements/pull/2801
kep-number should be kep_number otherwise Hugo do not understand the key name in json

Preview available: https://deploy-preview-222--kubernetes-contributor.netlify.app/keps/

@shekhar-rajak the sort of automation I'm thinking of is a scheduled GitHub Action to build the KEP list page automatically so that if upstream changes, this site is then updated within a few hours.
(Triggered updates would be a nice-to-have but can wait for a long time - few people are looking for instant updates in a page like this).

Thanks @sftim , yes we have to have such automation:

Either we have trigger the build job if enhancement repo is updated
Or we have to put the keps.json file in some storage if any PR is merged in enhancement related to KEP change.

Hi,
I believe this PR is complete for now. Once we get to know solution for AWS S3 storage or GCP storage to put the KEPs JSON data, we will just need to put the URL instead of the file path.  So this PR can be merged with TODOs and TODOs can be done in next PR.
Please let me know which team can help in providing the storage.

The team to ask about storage is, I think, WG Kubernetes Infrastructure - #wg-k8s-infra on Kubernetes Slack.

Starting the slack thread https://kubernetes.slack.com/archives/CCK68P2Q2/p1628494118056300 for storage

To briefly repost from https://github.com/kubernetes/k8s.io/issues/2490#issuecomment-896318679
I'm not saying no, but simply asking are you sure you want a GCS bucket for this?  Multiple sources of truth tend to drift.  I'm a much bigger fan of trying to keep source of truth in a single location (repo) if it can be helped.  I suggested a few alternatives.

To briefly repost from kubernetes/k8s.io#2490 (comment)
I'm not saying no, but simply asking are you sure you want a GCS bucket for this? Multiple sources of truth tend to drift. I'm a much bigger fan of trying to keep source of truth in a single location (repo) if it can be helped. I suggested a few alternatives.

I think @spiffxp proposed some good suggestions in this linked post above and think they are worth considering as I agree that it's preferable to maintain a single source of truth as opposed to a repo and bucket.

Poke.  If it's a bucket you want, I have https://github.com/kubernetes/k8s.io/pull/2570 up for consideration, PTAL

Hi. When I imagined this with a bucket, the job of keeping its contents current was going to fall to automation that builds based on what's in k/enhancements.
That approach plus this PR plus a bit more automation in this repo ought to entail no extra effort for folks proposing an enhancement, but better rendering (automatically) when they do, and possibly also better short links such as https://kep.k8s.io/2225 (not yet working)

Poke again.

When I imagined this with a bucket, the job of keeping its contents current was going to fall to automation that builds based on what's in k/enhancements.

https://github.com/kubernetes/k8s.io/pull/2570 is written with that perspective in mind.  Does that set of infra meet our needs?
Where we are blocked is deciding who the appropriate humans are for purposes of ownership for troubleshooting, support, and escalation.  It's k8s-infra's job to make sure that the appropriate set of infrastructure is present and that the right group of people can access it.  But we're not going to provision it if there are no humans willing to support it.

Rebased https://github.com/kubernetes/k8s.io/pull/2570, arbitrarily chose enhancements-approvers to own the infrastructure, please raise objections there.
And please confirm it's what you want and you're going to use it.  Last thing we want is zombie infrastructure.  I'm going to close due to lack of activity before too long.

As far as I understand the usecase

Write access the latest keps.yaml generate by each PR in GitHub repo kubernetes/enhancements  to the gap bucket
Read access to the account in this repo kubernetes/contributor-site

I would like to know , which account will be having read/write access to the bucket when CI/CD runs.
Please share If there is any sample PR/template that I can refer.

@salaxander you previously suggested you might have time to help out with parts of this improvement. Does this PR look like a part you'd have time to help with?

The PR https://github.com/kubernetes/k8s.io/pull/2570 is merged. I will continue work on this PR.

How's this going? What help would you like, @shekhar-rajak ?

Hi @sftim ,
Please share a sample PR that uses GCP bucket for read and write to a file ?

I want to upload file in GCP bucket automatically once any PR is merged into repo kubernetes/enhancements (later on we will improve it to trigger it when specific file is updated) - if there is bot or any CI/CD is integrated then please let me know

Repo kubernetes/contributor-site will use the uploaded file to fetch the YAML/JSON data to display in website.

share a sample PR that uses GCP bucket for read and write to a file ?

The read should be easy (HTTP fetch and get Hugo to load that JSON rather than locally from data/keps/*). The write, I'm not sure how we usually do this.

CI/CD for Kubernetes projects is something I don't know much about I'm afraid. I can try to find people who do.

Hi @shekhar-rajak , I came across this issue (thanks to @sftim) while exploring something similar to what you are doing (writing to a bucket). I don't have a PR yet for the work I am doing, but found some useful resources and prior art that might give you hints on how to write what you want to write to the Google Cloud Bucket.

So general way to read/write to GCB is using gsutil cp command. More in docs here: https://cloud.google.com/storage/docs/quickstart-gsutil#upload_an_object_into_your_bucket

One example where this is used with Prow is in this shell script, which is used in this job

Please ignore me if you have already figured this out :)

Thank you @PushkarJ ! I will explore and try to use the similar existing way.

I'm no Prow expert - I'm not even a novice, really - but I'm happy to try to clarify any docs, provide pointers, interpret advice etc if it helps move this work forward. Feel free to ask questions @shekhar-rajak !

Still worth doing IMO.
/remove-lifecycle stale

/close
(in favor of #324)


soc: stm32: Remove direct COUNTER_RTC_STM32 to COUNTER dependency

COUNTER_RTC_STM32 used to be enabled directly based on COUNTER status.
This should not be the case anymore as we should first check
DT_HAS_ST_STM32_RTC_ENABLED status (which is already done in
drivers/counter/Kconfig.stm32_rtc).
Remove these 3 lines that are not correct anymore.
Fixes following build issues:

2022-07-31 12:44:15,667 - twister - ERROR - nucleo_l476rg             tests/drivers/counter/counter_basic_api/drivers.counter.basic_api FAILED: Build failure
2022-07-31 12:46:02,804 - twister - ERROR - stm32f4_disco          tests/drivers/counter/counter_basic_api/drivers.counter.basic_api FAILED: Build failure
2022-07-31 12:46:03,072 - twister - ERROR - nucleo_l433rc_p           tests/drivers/counter/counter_basic_api/drivers.counter.basic_api FAILED: Build failure

@erwango can you rebase this please?

@erwango can you rebase this please?

Done, @ABOSTM, @galak can you check this again ?


Fixed Twitter Text Link (Deprecated)

https://github.com/twitter/twitter-text-objc is Deprecated
twitter-text-objc was merged into twitter-text

Thx


ipyvizzu support

Description
Quick test to show iPyVizzu chart with py-shinywidget.
Don't know how to coerce <ipyvizzu.chart.Chart object at 0x7f0322007a30> into a ipywidget.Widget object. Instead of using shinywidgets to render this object, try using shiny's @render.ui decorator  https://shiny.posit.co/py/api/ui.output_ui.html#shiny.ui.output_ui
What I Did

from shiny import reactive
from shiny.express import ui, render, input
from shinywidgets import render_widget

import pandas as pd
from ipyvizzu import Chart, Data, Config

ui.panel_title("iPyVizzu Test")

@render_widget
def chart():
    df = pd.read_csv(
    "https://ipyvizzu.vizzuhq.com/latest/showcases/titanic/titanic.csv"
    )
    data = Data()
    data.add_df(df)

    chart = Chart(width="640px", height="360px")

    chart.animate(data)

    chart.animate(
        Config(
            {
                "x": "Count",
                "y": "Sex",
                "label": "Count",
                "title": "Passengers of the Titanic",
            }
        )
    )
    chart.animate(
        Config(
            {
                "x": ["Count", "Survived"],
                "label": ["Count", "Survived"],
                "color": "Survived",
            }
        )
    )
    chart.animate(Config({"x": "Count", "y": ["Sex", "Survived"]}))

    return chart

shinywidgets version:
shiny                              0.7.1
shinylive                          0.2.2
shinywidgets                       0.3.0

Python version: 3.10

Operating System: Ubuntu LTS

As that error message tries to point out, shinywidgets is only designed to work with ipywidgets, and ipyvizzu doesn't integrate with ipywidgets.
ipyvizzu does, however, implement a _repr_html_() method, and as a result, can be rendered via shiny's @render.ui decorator.
Unfortunately, to get the example working, you also need to set display=DisplayTarget.MANUAL in Chart():
import pandas as pd
from ipyvizzu import Chart, Config, Data, DisplayTarget
from shiny.express import input, render, ui

ui.panel_title("iPyVizzu Test")

@render.ui
def chart():
    df = pd.read_csv("https://ipyvizzu.vizzuhq.com/latest/showcases/titanic/titanic.csv")
    data = Data()
    data.add_df(df)

    chart = Chart(width="640px", height="360px", display=DisplayTarget.MANUAL)

    chart.animate(data)

    chart.animate(
        Config(
            {
                "x": "Count",
                "y": "Sex",
                "label": "Count",
                "title": "Passengers of the Titanic",
            }
        )
    )
    chart.animate(
        Config(
            {
                "x": ["Count", "Survived"],
                "label": ["Count", "Survived"],
                "color": "Survived",
            }
        )
    )
    chart.animate(Config({"x": "Count", "y": ["Sex", "Survived"]}))

    return chart

Closing this since, if there is anything to improve upon here, shinywidgets isn't the right place for it.

Thank you @cpsievert That is really helpful


Fixed typo in Gather example

@Mabaria : Thanks for your contribution! The author(s) have been notified to review your proposed change.