Nature builder

Nature builder is not competitive and unpickable now.
You should buff his passive ability.

done


[Bug Report] el-input-number defaultValue

Element UI version
2.4.1
OS/Browsers version
all
Vue version
2.5.13
Reproduction Link
https://jsfiddle.net/api/post/library/pure/
Steps to reproduce
Initializes the el-input-number，Why is the default value is equal to zero？
I think should be what all don't show，otherwise seem to be very abrupt
What is Expected?
Initializes the el-input-numbe,The initial value is empty
What is actually happening?
el-input-number defualt value is equal to zero

Maybe it's a similar issue that with #11596. InputNumber can only accept numerical values.

set the property of v-model equal to undefined


Support Custom Slack Channels

what

add SLACK_CHANNEL parameter

why

with this feature, one webhook url can be used to send to different channels

@EladDolev this is great! Thanks for submitting.
@aknysh gets final approval.


MNT: Re-rendered with conda-smithy 1.5.3 [skip ci]

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Pr 11547

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
Closes #11547
Closes #1934
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements

[ ] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:

LGTM

I'd like to see more tests for this but overall nice work :)

@benjamingr - what further tests would you like to see?

Well, the only test right now is that events are passed in one way - there is a single test, I'd like to se more coverage.
I'm also not sure how users are supposed to mock it, that should probably be documented.

@benjamingr could you be more explicit. What code paths are not being covered?

@benjamingr Can you create a new issue for improving the documentation of mocking the events so that we can track it?


Feedback for Huawei page

This means there is no other way to fix proper app functionality on Huawei than installing PowerGenie.

Shouldn't this be uninstalling?

Many thanks, fixed it!


changeset tag creates tags that already exist

Affected Packages
@changesets/cli

Problem
When using changeset tag (specifically in a workflow), it creates tags that already exist
What happened
The following workflow has failed due to changeset tag creating tags that already exist instead of skipping them.
https://github.com/guildedts/guilded.ts/runs/7689876479?check_suite_focus=true#step:7
Expected behaviour
These tags should have been skipped so git wouldn't throw an error when i try to push tags.
🦋  Skipping tag (already exists<EMAIL_ADDRESS>🦋  Skipping tag (already exists<EMAIL_ADDRESS>🦋  Skipping tag (already exists<EMAIL_ADDRESS>🦋  Skipping tag (already exists<EMAIL_ADDRESS>🦋  Skipping tag (already exists<EMAIL_ADDRESS>🦋  Skipping tag (already exists<EMAIL_ADDRESS>
The repo that is experiencing this is guildedts/guiled.ts.

Proposed solution

See the thread here: https://github.com/changesets/action/issues/201#issuecomment-1206237040


"I'm afraid I can't do that" response

Depending on normalization, batch correction, etc, there are matrices that the matrix service could mechanistically create that would mislead data consumers. For example, an expression matrix generated from HCA data could contain obvious batch effects, but a user may not know that or how to address it.
We need to figure out how (and if) to prevent such a situation. There are a few ways we could do it, from just returning a 4xx based on some policy, to sometimes delivering multiple matrices, to running some future standard batch correction method.
This is a broad concern and requires guidance from HCA scientific leadership. This issue is mostly to flag the problem and solicit that guidance.

At a first glance:

I think the matrices I would be timid to deliver would be ones that combine assays (like SS2 and 10X measurements in the same matrix) and multispecies matrices (if we have multiple species in the DCP).
Although I don't think we will have this in the DCP, I would not combine outputs from different pipeline versions that are scientifically different (or are derived from different reference versions).
We would need to clearly error with no delivery so the scientists know they did not have something delivered, anything outside of an error has the potential for being used.
If normalization is performed, it would need to be performed on all cells in the matrix.
If batch effect correction is performed, it would need to be performed using all cells in the matrix as input unless the methodology indicated otherwise.
Once filtering or batch effect correction is included the order of operations becomes important.

I added this to the next AWG pipelines subworking group meeting agenda.

@TimothyTickle - when is the next AWG pipelines subworking group meeting?


拼写错误

拼写错误

Q
A

Is bugfix?
yes/no

New feature?
yes/no

Breaks BC?
yes/no

Tests pass?
yes/no

Fixed issues
comma-separated list of tickets # fixed by the PR, if any

多谢！


JSON parsing/serialization for Avro types

Is there a convenient way to read/write types with FromAvro/ToAvro instances as JSON rather than Avro's binary format, using the corresponding Avro schema?
This would be particularly nice with the types generated by deriveAvro as it would let me easily support both formats.
If there's no easy way to do this as is, what would adding that to the library look like? Would a good option be to move from Avro.Value to Aeson.Value?
I'm up for implementing a PR if it isn't too tricky :).

You can decode any Avro value into Aeson.Value by just using decodeAvro, but you still need schema because without schema Avro decoder doesn't know what to do.
ToJSON instance for Data.Avro.Types.Value already exists.
decodeAvro mySchema myPayload :: Either String Aeson.Value

I don't know about decoding from JSON though. I think it should be possible: knowing the schema you could traverse Aeson.Value and create Data.Avro.Types.Value. So it should be possible to write a generic function like fromJSON :: HasAvroSchema a => Aeson.JSON -> a.
Maybe even FromJSON instance for Data.Avro.Types.Value.
However, for both operations you would still need schema. Without Schema it isn't possible to determine types of fields.
For example, when JSON says:
{
    "severity" : 12,
    "mitigationType": null
}

then only schema can tell us that severity should be of type Double and not Int32, that mitigationType is of type Maybe Mitigation, etc.
So once you say that the schema is required (or the result type is known as the schema can be obtained from it) then it shouldn't be too tricky.

Yeah, I think that HasAvroSchema a => Aeson.JSON -> Either String a should be possible.
Try making it happen, maybe looking at . ToJSON as an example: https://github.com/GaloisInc/avro/blob/master/src/Data/Avro/Schema.hs#L307

@AlexeyRaga Oh hey, there's a parseAvroJSON function in Data.Avro.Schema, but not exported.
Doesn't this do almost exactly what I want? It seems like I can just compose it with fromAvro:
fromJSON :: HasAvroSchema a => Aeson.JSON -> Result a
fromJSON json = parseAvroJSON env schema json >>= fromAvro
  where {- ... -}

Of course, I found this function after I was most of the way through writing my own version of parseAvroJSON :).

@TikhonJelvis I wouldn't know for sure because I haven't used it, but it does look what you need! Good to know!
Perhaps some unit/property testing would be nice to have to make sure that it works properly :)

I'll give it a try.
I did figure out one awkward thing though: parseAvroJSON depends on Type from Data.Avro.Schema and the FromJSON instance of Type depends on parseAvroJSON. This means we can't move parseAvroJSON into a separate module without incurring a circular dependency :/.
One option would be moving Type into Data.Avro.Types and reexporting it from Data.Avro.Schema. How does that sound?

Yes,  it can be cleaned up a bit in my opinion too.
I am not against moving Type and its synonym Schema to Data.Avro.Types. I think it is quite logical.
I would even turn them around and made Schema to be a real data type name, and had type Type a synonym so we could eventually deprecate Type and just use Schema everywhere :)
But these are just my thoughts.

I would even turn them around and made Schema to be a real data type name

I was going to suggest exactly that! Type is too generic...

Actually, never mind: moving Type to Data.Avro.Types wouldn't solve my problem—I'd still either have to put parseAvroJSON into Data.Avro.Types or have circular dependencies or have an orphan FromJSON instance. None of these are great choices.
This is one of those cases where the open-world assumption really bites us :/.

Okay, I've written code for this, now I just need to write some tests :).
My change might actually not be backwards compatible with the library because the previous version was too permissive in parsing default values for unions. The spec only allows the default value to be of the first schema in a union, but the existing code tries all of the specs in the union:

Default values for union fields correspond to the first schema in the union.

(See https://avro.apache.org/docs/1.8.2/spec.html#schema_record)
By the way, is this the right repo to open a PR?

By the way, is this the right repo to open a PR?

From my understanding, @TomMD is not actively interested in this lib at the moment, and is not actively reviewing/merging PRs.
I don't have any special rights on this repo so all the patches I and my colleagues make are going through this repo: https://github.com/haskell-works/hw-haskell-avro
We always send PRs to this repo, but we have no way to tell when and if they'll be accepted. We also publish to Hackage from haskell-works.
You can make your PR against https://github.com/haskell-works/hw-haskell-avro and then it will probably be merged and end up on Hackage a bit quicker.

@AlexeyRaga's understanding is correct.  I am happy to give the commit bit on this repo to any interested contributors but do not currently have the time to manage the project.

I don't have strong preferences between the repos, but it would be really helpful if one or the other was clearly marked as the "official" repo for the package. This means either:

move development to this repo and give a commit bit to @AlexeyRaga and whoever else is needed
keep active development on the haskell-works repo and have a link from this repo to that one

It's much easier to contribute to a repo if all the issues and PRs are in one place.
Also, I noticed that the Hackage page links to both repos, which doesn't help with the confusion :).

@TomMD If we either have commit rights on this repo or if we transfer this repo to haskell-works and kill that fork (obviously keeping the license, copyrights, etc.), both solutions work for me.
If you don't think that you are going to be back to this project then maybe transfer works a bit better, but again, I am happy with either.

I thought you did have commit rights... checks... hurm ok.  Well you now have an invite as admin on this repository.  Feel free to invite people as you see fit.  If I catch flak for giving away "admin" rights or there's a compelling reason then we can move the code, I'm not sensitive to the URL it's at.

Thanks @TomMD! I'll do releases from this repo from now on.

JSON parsing and serialization has been implemented in #21.


the older value didn't chang when user invokes the undo

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Steps:

modify the page
first you type a name and then invoke the undo

Current behavior 😯
No response
Expected behavior 🤔
No response
Context 🔦
No response
Your environment 🌎
No response

https://github.com/JerryWu1234/mui-toolpad/blob/8d29d72523eaef1b5d8fb466491b4df61e8d4b22/packages/toolpad-app/src/toolpad/AppEditor/NodeNameEditor.tsx#L29
const handleNameCommit = React.useCallback(async () => {
    const oldname = dom.nodes[node.id];
    console.log('undo', oldname.name, nameInput);
    if (isNameValid) {
      if (nameInput !== oldname.name) {
        domApi.setNodeName(node.id, nameInput);
      }
    } else {
      setNameInput(node.name);
    }
    if (isNameValid && oldname.type === 'page' && nameInput !== oldname.name) {
      await client.mutation.deletePage(oldname.name);
    }
  }, [isNameValid, domApi, node.id, node.name, nameInput, dom]);

Yes, renaming the page seems to do strange things. This is where our AppDom model conflicts a lot with our file system model. We should stop using the NodeNameEditor for the purpose of renaming files and instead have an input that calls a renamePage function on the server that renames the actual file on disk. We should not operate on the appdom at all for the case of renaming/creating/deleting files.

Yes, renaming the page seems to do strange things. This is where our AppDom model conflicts a lot with our file system model. We should stop using the NodeNameEditor for the purpose of renaming files and instead have an input that calls a renamePage function on the server that renames the actual file on disk. We should not operate on the appdom at all for the case of renaming/creating/deleting files.

@Janpot https://github.com/mui/mui-toolpad/pull/2171
should this pr's renamepage remove to serve side to finish it ?

Yes, I think when the page is renamed on the frontend it should call a function on the backend that renames the folder. And doesn't do anything with the dom at all.


Ensure we do not (transitively) rely on deprecated libraries

npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported

Maybe we want the CI to check for this as well.

We could do this using our renovate bot, which will make issues per deprecated lib: https://renovate.whitesourcesoftware.com/blog/new-feature-dependency-deprecation-warnings/

I've looked into this a bit, and it looks like Renovate will by default already open issues for deprecated dependencies, but only if they are direct dependencies.
I'm also wondering if we really want warnings about transitive deprecations. If our direct dependencies are not deprecated themselves, but are using deprecated packages, they are responsible themselves for updating. If they don't, then the deprecation may not be a problem.
Also, even if we receive notifications for transitive deprecations, I'm not sure we'd be able to fix all of them. For example, request is being used in a bunch of our (dev) depencies that we really rely on (coveralls, jsonld, jest-environment-jsdom, ...). Other than updating all of those depencies ourselves, I don't see a way around this.

Fair enough, thanks for checking.


Amplify Predictions convert text to audio does not work for voice: Kevin

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
16.13.2
Amplify CLI Version
10.8.1
What operating system are you using?
Mac
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No manual changes made
Describe the bug
When I run amplify add predictions, Generate speech audio from text, I choose speaker: Kevin - Male.
When I try to run Predictions.convert({textToSpeech .... }) without giving a voiceId, I get the following error from the backend:
"This voice does not support the selected engine: standard"
When I explicitly add the voiceId of "Kevin", it also does not work.
Only when I add voiceId of "Amy" does it work.
CLI commands:
Evertsons-MacBook-Pro:theamplifyapp evertsoncroes$ amplify add predictions
✔ Please select from one of the categories below · Convert
✔ What would you like to convert? · Generate speech audio from text
✔ Provide a friendly name for your resource · speechGenerator11c4cfca
? What is the source language? ...  (Use arrow keys or type to filter)
✔ What is the source language? · US English
✔ Select a speaker · Kevin - Male
✔ Who should have access? · Auth users only
Successfully added resource speechGenerator11c4cfca locally
Expected behavior
That the polly /speech endpoint returns a success response
Reproduction steps

Check out this project at this commit: https://gitlab.com/evertson90/theamplifyapp/-/commit/87db85a1acf0bf057fc86070cf3271d6990540c8
run "amplify add predictions"
See "describe the bug" section for answers I used
run "amplify push"
Run convert in the following way:

Predictions.convert({       textToSpeech: {         source: {           text: this.textInput         }       }     })
Project Identifier
bfaf6cb7a4743f03f665dbc0848381fe
Log output

# Put your logs below this line
{"message":"This voice does not support the selected engine: standard"}

Additional information
No response
Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

Hey @evertson90 :wave: thanks for raising this! Since this issue involves the amplify-js library I'm going to transfer this issue for better assistance 🙂


[BUG] Night vision doesn't do anything.

Description:
https://github.com/AztechMC/Modern-Industrialization/issues/29
Technical Information:

Minecraft: 1.16.3
Fabric API: fabric-api-0.25.0+build.415-1.16
Industrial Revolution: indrev-1.7.8-BETA
Modpack: The Adventures of Halk

Will be fixed in the next release, thanks for the report!


Cleaning up auth methods for AAD Database users and Logins

"Azure Active Directory Integrated" was listed twice for aad logins.  "Using an Azure AD principal name and a password" should be changed to "Azure Active Directory Password" , and "Using integrated Windows authentication" changed to "Azure Active Directory Integrated".  And is it really the case that token auth is not supported for AAD Logins?

@davidbaxterbrowne : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Token auth is supported for AAD logins
The rest looks OK to me
Thanks,
Mirek

u

Token auth is supported for AAD logins
The rest of the Text above looks good to me

Token auth is supported for AAD logins
The rest of the text above looks OK to me

#sign-off

@VanMSFT: I'm sorry - only the author of this article, @GithubMirek, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


Add definition for JRuby <IP_ADDRESS> and <IP_ADDRESS>

These JRubies has been released.

http://jruby.org/2017/06/14/jruby-9-1-11-0.html
http://jruby.org/2017/06/15/jruby-9-1-12-0.html

Thanks.

@koic @hsbt thoughts on auto updating homebrew ruby-build formula on addition of new definitions?
https://github.com/Homebrew/homebrew-core/blob/master/Formula/ruby-build.rb

I have no plan to auto-update mechanism yet.


How to change position of tabline when neo-tree is opened

Is it possible to change the position of the tabline when neo-tree is opened.
I would like to see the buffer auth.service.ts in the tabline to be positioned passed the dividing line when the neo-tree is opened.

So the first buffer in the tabline would instead be shown above auth instead of currently it shown above "Files"
require("lualine").setup({
	options = {
		icons_enabled = true,
		theme = custom_codedark,
		component_separators = { left = "|", right = "|" },
		section_separators = { left = " ", right = " " },
		disabled_filetypes = {
			statusline = {},
			winbar = {},
		},
		ignore_focus = {},
		always_divide_middle = true,
		globalstatus = false,
		refresh = {
			statusline = 1000,
			tabline = 1000,
			winbar = 1000,
		},
	},
	sections = {
		lualine_a = { "mode" },
		lualine_b = { "branch", "diff" },
		lualine_c = { "filename" },
		lualine_x = { "diagnostics", "encoding", "fileformat", "filetype" },
		lualine_y = { "progress" },
		lualine_z = { "location" },
	},
	inactive_sections = {
		lualine_a = {},
		lualine_b = {},
		lualine_c = { "filename" },
		lualine_x = { "location" },
		lualine_y = {},
		lualine_z = {},
	},
	tabline = {
		lualine_a = { "buffers" },
		lualine_x = {},
		lualine_y = {},
		lualine_z = { "tabs" },
	},
	winbar = {
	},
	inactive_winbar = {},
	extensions = {},
})

@kaykhan did you managed to achieve the desired result? I also wanted to create issue for exact same reason


Can't logout

From being logged, I can not log out. If I want to switch accounts or users I have to wait for some unknown timeout to occur.
We need to be able to actually log out when you click "logout".

I created an issue for backend - https://github.com/almighty/almighty-core/issues/987

We now have a new endpoint in api:
GET /api/logout
Optional param: redirect=<encodedURL>, if not set then referrer will be used to redirect to after logout.
Please use it to logout users :)

Thanks @alexeykazakov, @dgutride when you get time, please update this.


XVG transfer from electrum wallet to Binance stuck with 0 confirmations for several days.

Issue Template
Context
I transferred some xvg from my local electrum wallet to binance. It has been stuck with 0 confirmation since January 12th and binance says the issue is not on their end they cannot help me.
Transaction ID: a53a50c4d5bdc1cdfe744a48c80f6d2bacfa24b4b7d95cc6e0c7e2baa7c0605d
Link to the blockchain explorer
https://verge-blockchain.info/tx/a53a50c4d5bdc1cdfe744a48c80f6d2bacfa24b4b7d95cc6e0c7e2baa7c0605d
Prerequisites

[x] Are you running the latest version?

No I am running electrum 2.4.1
User Story:

"I'm submitting a ... " Support Request

[ ] bug report
[ ] feature request
[ X] support request
[ ] translation request

Your Environment

Verge Release: Electrum - XVG 2.4.1
CPU: i7 8700k
GPU: Gtx 1080
RAM: 16gb
OS: Windows 10

[ ] I'm using Mac
[ ] I'm using Linux
[ ] I'm using Mac

@justinvforvendetta  close this one out plz

@justinvforvendetta nudge

I've been waiting for an update to Electrum, which would fix the unverified coins problem, but even now after the fork, it hasn't started working and there is no updates to the Electrum  wallet. My coins are locked in the wallet. Even the screenshot shows Electrum is disconnected, it connects every now and then, but the status won't change.

You don't need to hide the TX's and addresses and stuff, that stuff actually helps us troubleshoot better.
Have you tried 'uninstalling' the electrum XVG wallet and re-importing your wallet address?

do a wallet -> private key -> export ... i would advise not saving it as a CSV .. just grab the private key of the address you want (probably just DDPVCBroBkeWaZnJyJ8fiwhsaA6gniT3vR ? )
close down electrum
go to c:\users<YOU>\AppData\Roaming\Electrum-XVG\wallets
back up the file first, copy it to a jump drive or somewhere safe
then rename it to like default_wallet_old
then re-start electrum-xvg... should ask if you want to recover a wallet or create new one .. and go from there.  Either create a new wallet and import your private key...
Bottom line is...
  You can easily fix this yourself by importing your private key somewhere else.  Either QT wallet.. or a new Electrum wallet.

Also --- check this one out :
https://www.reddit.com/r/vergecurrency/comments/7uelnl/electrum_wallet_offline_please_help/
There's a link to a youtube video that looks good

Nutshell instructions:
Step 1) Close down Electrum wallet
Step 2) Browse to where your Electrum 'installation' is
Step 3) Go into the Lib folder
Step 4) Open network.py in notepad or textpad , some kind of text editor
Step 5)
Replace this chunk of code:
DEFAULT_SERVERS = {
    'electrum-verge.xyz':{'t':'50001', 's':'50002'},
    'electrum-xvg.stream':{'t':'50001', 's':'50002'},
    'electrum-xvg.party':{'t':'50001', 's':'50002'}
}

With this chunk of code:
DEFAULT_SERVERS = {
    'electrum-verge.xyz':{'t':'50001', 's':'50002'},
    'electrum-xvg.stream':{'t':'50001', 's':'50002'},
    'electrum-xvg.party':{'t':'50001', 's':'50002'},
    'e1.verge-electrum.com':{'t':'50001', 's':'50002'},
    'e2.verge-electrum.com':{'t':'50001', 's':'50002'},
    'e3.verge-electrum.com':{'t':'50001', 's':'50002'}
}

step 6)  Open Electrum
step 7)  Go to tools -> network
step 8)  Make sure "Auto-connect" is checked, and the 3 electrum servers are listed:
e1.verge-electrum.com
e2.verge-electrum.com
e3.verge-electrum.com


Adding strum

This adds the possibility of iterating through an enum in Roqoqo:
use strum::IntoEnumIterator;

for gate in TwoQubitGateOperation::iter() {
    println!("{:?}", gate.hqslang());
}

Better solution here


expect not installed on CI machine

getty-containerd test needs inspect installed see https://github.com/linuxkit/linuxkit-logs/commit/45fc7f585cf5b0fc013215eef5e9e5e76658ca72#diff-45abc448478fe2f1907cce047d595e85
We really need to dogfood the config with linuxit, so we can actually control it directly.

cc @talex5 @dave-tucker

Weirdly it passes on PRs and fails on master merges. Why?

I think for PRs we spin up a new VM and for master builds we may have a permanent VM running. I vaguely recall @dave-tucker mentioned something about a pretty beefy instance running...

Rolf is correct.
We have a fixed machine with 16 vCPUs, 104 GB RAM for PRs which could be a tad excessive IMHO. I think we should probably create machines on demand for master too and ideally with the same config used for PRs (albeit with secrets).
The process for updating the VM images used isn't documented but @talex5 has done this in the past.
I'm working on using LinuxKit for this but I'm waiting on my mount PR's to merge before I continue.

expect (not inspect, but that seems to be what it wants from the error) is already installed on all build VMs. Perhaps it is trying to execute it on the CI host? In that case, it needs adding to the LinuxKit CI Dockerfile: https://github.com/linuxkit/linuxkit-ci/blob/master/Dockerfile

Closed via https://github.com/linuxkit/linuxkit-ci/commit/a042a1c76eefa73a82d30bf629957ceac5e82382


Fix - Room - Workspace the current user is not member appears in workspace list during room creation flow

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/53315
PROPOSAL: https://github.com/Expensify/App/issues/53315#issuecomment-2507845541
Tests

Precondition:
Account only has one workspace.
Invoices feature is enabled.

Go to FAB > Send invoice.
Send an invoice to another user.
As invoice receiver, open the invoice room and pay the invoice via Pay with business.
Go back to the invoice sender.
Delete the workspace.
Create a new workspace.
Go to FAB > Start chat > Room.
Click Workspace.
Verify that only the workspace you created in (6) is in the list.

[x] Verify that no errors appear in the JS console

Offline tests

Same as above
QA Steps

Same as above

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/295d6a51-d660-40fe-a07d-40ced40492e2

Android: mWeb Chrome

https://github.com/user-attachments/assets/a73b350b-89ca-482d-804b-6c271c44b650

iOS: Native

https://github.com/user-attachments/assets/86c32f81-276c-446f-9626-0b0c85f3268a

iOS: mWeb Safari

https://github.com/user-attachments/assets/f42acb6b-8f37-44d9-be92-b0928d4f2890

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/ee08589c-72f7-41cd-a199-2568b2624e09

MacOS: Desktop

https://github.com/user-attachments/assets/7b936e22-a470-4cab-8ced-60e59c8844bd

Added comment and test.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@shubham1206agra @cristipaval @FitseTLT this caused regression.
See https://github.com/Expensify/App/pull/54197

@shubham1206agra @cristipaval @FitseTLT this caused regression.
See #54197

@lakchote Can you link the issue this PR caused pls ?


reduce font size on "Region XYZ" title bars

I would reduce the font size of the plot titles ("Region XYZ") to be more comparable (or just slightly larger) to the font in the plots themselves. It would also make the title bars take less real estate, they're a bit wasteful right now.

Oh yes, that's an even better idea! I would just add a bit of horizontal space (half an ex, no more) between the toolbar and the plot. And maybe make the purple circle a bit smaller, so it's not touching the plot (and is horizontally centred within the toolbar).

Hmm wait now it's really odd:

Having it vertical in the bottom left was better!

I see it, I think I'm having compatibility issues between firefox and chrome. I'm checking on it. The helper is also running but the image isn't down-sampling. That's why the scale changed also


kbnm: Use keybase id and parse log output

Use keybase id ... instead of keybase sigs ... because sigs does not include a reliable mapping to the keybase username.
Parse log output instead of JSON, because id does not support JSON.
Parse error output to give more sensible errors (otherwise it's just exit status code 2 for everything).
Capture logged out and not running states (we consume both stderr and stdout for that).
Also added a whitelist id for our production extension (lmk if we prefer a separate PR for that, very minor).

Questions:

[ ] Do I need to parse the reddit line of the keybase id shazow@reddit output specifically, or is it sufficient to just parse the first line (which is the keybase username for shazow@reddit? What happens when the reddit proof is broken?

Go ahead and merge; CI failures are connection flakes.


LP00068434402473

LP00071653567725
YANWEN international express

Done

Cainiao also shows info
https://global.cainiao.com/detail.htm?mailNoList=LP00068434402473&spm=a3708.7860688.0.d01
We should save the ctt id too.

Done


Update Actions to run on push to development

Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.

[x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your default branch!
[ ] Make sure you are making a pull request against the default branch (left side). Also you should start your branch off default branch.
[ ] Check the commit's or even all commits' message styles matches our requested structure.
[x] Check your code additions will fail neither code linting checks nor unit test.
[x] I have added necessary documentation (if appropriate)

Description
Linked Issue that will be closed by this: #83
❤Thank you!
Post merge checklist

[ ] Follow steps from the guidelines for contributing to this repository.
[ ] If you are a new contributor, ping in the thread and one of the maintainers will add you to all-contributors list.

Merge this before #82 to be able to confirm if push trigger works


⚠ 한경주요지수-코스피200 has degraded performance

In 2b3ea4d, 한경주요지수-코스피200 (https://markets.hankyung.com/indices/kospi200) experienced degraded performance:

HTTP code: 200
Response time: 6685 ms

Resolved: 한경주요지수-코스피200 performance has improved in a1d7bcb.


Object not showing in editor

Current Behavior
Trying to export a bridge to MSFS that i created in blender but not showing up in the editor from MSFS,
Can anyone help me with that, ive linked the project and the blend file at the bottom.
Thanks.
Expected Behavior
does not show under objects in editor
Steps To Reproduce
nvt
Environment
- OS: windows 11
- Blender: 3.3.5 LTS
- glTF-Blender-IO-MSFS: 1.3.0

Anything else?
Here's my project and blend file:
https://mega.nz/folder/2aRUiQRS#IQB4FG6jrnAHDFsWGndr5g

Only this when i run it with fpackagetool

Can you send me your package ? with your model exported.


Adds typescript in sdk sources

Dev Docs PR
Description
Adds typescript in sdk sources
Deadline
N/A
Change type

[ ] Doc bug fix. Fixes #[insert issue number]. Amplitude contributors include Jira issue number.
[ ] Doc update.
[ ] New documentation.
[x] Non-documentation related fix or update.

PR checklist:

[x] My documentation follows the style guidelines of this project.
[x] I previewed my documentation on a local server using mkdocs serve.
[x] Running mkdocs serve didn't generate any failures.
[x] I have performed a self-review of my own documentation.

@amplitude-dev-docs
@caseyamp

@kevinpagtakhan merge when you're ready.


Allow to reference registered components in 'extends' property

What problem does this feature solve?
A registered component could be referenced by its identifier when using the extends property. Currently it only works if you set a component directly, so in order to get a registered component it would look like this:
{
  extends: Vue.component('myComponent')
}

What does the proposed API look like?
However a shorter syntax could be by just using a string to reference a previously registered component.
{
  extends: 'myComponent'
}

I think this may lead to subtle issues regarding the timing when a component is defined/extended vs. when the global one is registered. I prefer to keep it explicit as it is now.


Configure monitoring for Registry Sweeper ECS cluster

Setup health monitors to monitor the CPU / Memory Utilization for each ECS task for registry-sweeper service

Currently working on setting up EventBridge to schedule up a task for each domain targeting prod. Will need PROV_Endpoint var value to move forward for each domain.

@tloubrieu-jpl @jordanpadams
What's completed?

10 new ECS Provenance task definitions, with 10 new schedules
ECS Registry-Sweeper Monitoring Dashboard (All ECS Registry-Sweeper Domains tasks). Currently we're monitoring for CPU and Memory Utilization for each task. Also, TaskCount at Cluster Level.
4 Alarms (CPU, Memory, TaskCount) setup for Provenance Monitoring (1 is a composite alarm that goes off if either of the remaining 3 alarms go off).

What's pending?

Do we really need a new Registry-Sweeper Cluster? If so we'll need to switch all of the above tasks to point to that new cluster and also have to create new Alarm. Effort wise that's 1 full day worth of effort including testing.
Do we need to setup monitoring and task definitions for EN-DELTA and ATM-DELTA clusters?
Do we need to setup alarms for each OpenSearch Cluster? If so which metrics should we monitor? Currently we have a FreeStorageSpace alarm already setup. If we create more alarms for more metrics, then we might need to create a composite alarm for each to reduce noise.
Do we need to setup Cluster level alarms and task level alarms separately for each ECS cluster?

I am happy to give you guys a demo of what's already done and then we can decide on the above questions.

Thanks @sjoshi-jpl , a demo sounds like a good idea for the up coming sprint review, this Thursday.

@tloubrieu-jpl as discussed over chat with @jordanpadams we can leave what we have for now and then if the cluster level alarms for provenance are not actively helping us manage the task level resources, we can work on creating CPU/Memory alarms at the task level for provenance.
For now we have the essential alarms covered and it might not be worth to turn on container insights for every Registry-API cluster, especially if we are planning to move towards multi-tenancy. We can make more robust monitoring once we're using multi-tenancy because at that point we won't have multiple clusters / tasks to manage.

An initial pass at this has been completed and demoed at last sprint review on  8/10


Downloading Symbols with windows auth fails

Please include the following with each issue:
1. Describe the bug
Download symbols failed
2. To Reproduce
Steps to reproduce the behavior:
Download symbols with windows authentication from a NST
launch.json:
{
"version": "0.2.0",
"configurations": [
{
"name": "Your own server",
"request": "launch",
"type": "al",
"environmentType": "OnPrem",
"server": "https://xxx.xxx.net",
"serverInstance": "POPS",
"authentication": "Windows",
"breakOnError": true,
"launchBrowser": true,
"enableLongRunningSqlStatements": true,
"enableSqlInformationDebugger": true,
"tenant": "popsbe"
}
]
}
3. Expected behavior
Symbols should be downloaded without any issue (like with AL Language 9.5.674382)
4. Actual behavior
[2022-10-18 11:56:41.79] Using reference symbols cache path: c:\Users\Van Lyssebettens\Documents\GIT\bc-pops\app.alpackages
[2022-10-18 11:56:41.87] Targeting server 'https://xxx.xxx.net', server instance 'POPS' and tenant 'popsbe'.
[2022-10-18 11:56:41.87] Using Windows authentication.
[2022-10-18 11:56:41.92] Sending request to https://xxx.xxx.net:7049/POPS/dev/metadata?tenant=popsbe
[2022-10-18 11:56:42.94] Sending request to https://xxx.xxx.net:7049/POPS/dev/metadata?tenant=popsbe
[2022-10-18 11:56:43.19] Sending request to https://xxx.xxx.net:7049/POPS/dev/metadata?tenant=popsbe
[2022-10-18 11:56:43.62] Sending request to https://xxx.xxx.net:7049/POPS/dev/metadata?tenant=popsbe
[Error - 11:56:44] Please report this issue to https://github.com/microsoft/al/issues including information on how to reproduce it, if possible.
Processing of message 'al/downloadSymbols' failed with error: 'The target principal name is incorrect.'
Details:
System.ComponentModel.Win32Exception (0x80090322): The target principal name is incorrect.
at System.Net.NTAuthentication.GetOutgoingBlob(Byte[] incomingBlob, Boolean throwOnError, SecurityStatusPal& statusCode)
at System.Net.NTAuthentication.GetOutgoingBlob(String incomingBlob)
at System.Net.Http.AuthenticationHelper.SendWithNtAuthAsync(HttpRequestMessage request, Uri authUri, Boolean async, ICredentials credentials, Boolean isProxyAuth, HttpConnection connection, HttpConnectionPool connectionPool, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
at System.Net.Http.AuthenticationHelper.SendWithAuthAsync(HttpRequestMessage request, Uri authUri, Boolean async, ICredentials credentials, Boolean preAuthenticate, Boolean isProxyAuth, Boolean doRequestAuth, HttpConnectionPool pool, CancellationToken cancellationToken)
at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at Microsoft.Dynamics.Nav.Deployment.Telemetry.TelemetryHttpClientHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.Deployment\Telemetry\TelemetryHttpClientHandler.cs:line 62
at Microsoft.Dynamics.Nav.Deployment.Http.NavHttpClientHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.Deployment\Http\NavHttpClientHandler.cs:line 35
at System.Net.Http.HttpClient.g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
at Microsoft.Dynamics.Nav.Deployment.ApiClients.ServerInfoApiClient.GetServerInfo() in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.Deployment\ApiClients\ServerInfoApiClient.cs:line 46
at Microsoft.Dynamics.Nav.Deployment.ApiClients.ServerRegistry.QueryMetadata(ConnectionOptions options, IEmitLogger logger) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.Deployment\ApiClients\ServerRegistry.cs:line 153
at Microsoft.Dynamics.Nav.Deployment.ApiClients.ServerRegistry.GetServerInfo(ConnectionOptions options, IEmitLogger logger) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.Deployment\ApiClients\ServerRegistry.cs:line 56
at Microsoft.Dynamics.Nav.Deployment.ApiClients.PackagesApiClient.SendRequest(IHttpClient client, SymbolReferenceSpecification reference) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.Deployment\ApiClients\PackagesApiClient.cs:line 135
at Microsoft.Dynamics.Nav.Deployment.ApiClients.PackagesApiClient.DownloadPackage(IHttpClient client, SymbolReferenceSpecification specification, String directory, Boolean isSecondLevelDependency) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.Deployment\ApiClients\PackagesApiClient.cs:line 172
at Microsoft.Dynamics.Nav.Deployment.ApiClients.PackagesApiClient.DownloadPackages(ImmutableArray1 references, String targetDir) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.Deployment\ApiClients\PackagesApiClient.cs:line 61    at Microsoft.Dynamics.Nav.Deployment.ReferenceDownloader.NavDevServerPackageDownloader.DownloadPackages(ImmutableArray1 packages, String targetDirectory) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.Deployment\ReferenceDownloader\NavDevServerPackageDownloader.cs:line 32
at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.Extensions.DownloadSymbolsRequestHandler.DownloadFiles(DownloadSymbolsRequest request, String cacheDirectory, ImmutableArray1 referencesToDownload) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\Extensions\DownloadSymbolsRequestHandler.cs:line 130    at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.Extensions.DownloadSymbolsRequestHandler.ProcessRequestAsync(DownloadSymbolsRequest request, Int32 requestId, CancellationToken cancellationToken) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\Extensions\DownloadSymbolsRequestHandler.cs:line 98    at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.Extensions.NavServerRequestHandler2.HandleAsync(T request, Int32 requestId, CancellationToken cancellationToken) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\Extensions\NavServerRequestHandler.cs:line 40
at Microsoft.Dynamics.Nav.EditorServices.Protocol.MessageProtocol.RequestHandlerBase`1.HandleAsync(JToken requestContents, Int32 requestId, CancellationToken cancellationToken) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\MessageProtocol\RequestHandlerBase.cs:line 84
at Microsoft.Dynamics.Nav.EditorServices.Protocol.RequestRegistry.Process(Message message) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\Endpoints\RequestRegistry.cs:line 86
5. Versions:

AL Language: v10.0.687650
Visual Studio Code: 1.72.2
Business Central: 20.0.44266.44359

Let's get the issue to a team who will fix and backport it, as this repository is only for issues related to the latest developer preview environment for Dynamics 365 Business Central. We suggest that you open a support case or file a bug in Collaborate, to ensure that all Business Central users benefit from your catch as soon as possible.
To open a support case, you can:

Open a support request to CSS through the PartnerSource portal
Contact your Service Account Manager (SAM) in your local subsidiary to understand what is included in your contract as of support incident and PAH (Partner Advisory Hours). Your SAM might also direct you "step by step" how to open a support request or how to get credentials, if this is the first time for you or your company

If you file the bug in Collaborate, remember to include steps to reproduce the issue, and the Business Central build number and country version you're using.


Fix pre-commit ci configuration

Fixes

Fixes the pre-commit ci to correctly run.
Description
The pre-commit ci previously did not run correctly.
Tests
As can be seen from this sample PR, the pre-commit CI runs correctly and modifies a file using black.
Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main or master).
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[x] I added or updated tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

I'll need approval to run the workflow. There should be two checks now, like so:
.
If the pre-commit ci check does not appear, you will have to go to the marketplace and install it for the repository using the free plan.

Should I close this?


[Refactor][config-ui] delete unused params in usePipelineValidation.jsx

What and why to refactor
https://github.com/apache/incubator-devlake/blob/7b0199a6d8557d4f18b73200d619a96d10df0163/config-ui/src/hooks/usePipelineValidation.jsx#L22-L45

We rarely use params here and I don't think we will use projectId/boardId/... in validation in the future.
Describe the solution you'd like
Delete them.
Deleting unnecessary params will help us read code without worrying about where the vars are used.

This is fine to cleanup, A majority of the validation rules was removed from the Pipeline Validator and moved to Blueprint Validator as a consequence of v0.12.0 changes.

@likyh

usePipelineValidation has been deleted, so close this issue.


fix build and startup

Fixed

linking issue on Linux due to open ssl
on startup if ssh key is missing a segmentation fault exception occurs because m_cts is not initialized to nullptr

Also added a default index file to root folder

Merged, thanks.


Squelch a 3.7+ Decprecation warning ...

which will be breakage in 3.9.
For compatability 2.7, is still supported.
Fixes #6

(Thought I had done this before but apparently not. If you want this in a branch here and in the next one, let me know.)

Looks good! I'll merge this. There are some CI errors, but they are best resolved with #7

Ok. Working on it now.Thanks.


Fix f_onchar_delete not launch when delete account

Issue #1029
Need to be review. DeleteChars() was already on this function:
CAccount::~CAccount()
But this function seem to never be use so I added the DeleteChars(); in the account delete function.
Since we want a notification in script, I mannualy add NotifyDelete(1) and add a bool value to block the return 1 function in the  @f_onchar_delete  or @destroy trigger. Without this check, If this return is present, we get an infinite while loop.

I tested for different way and seem work correctly.


SPLAT-1851: Make VSphereMultiVCenters feature gate GA

SPLAT-1851
Changes

Promoted VSphereMultiVCenters feature gate to GA (default)

E2E Test Data:

This feature gets tested by the Periodical jobs

IPI

https://prow.ci.openshift.org/job-history/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.17-e2e-vsphere-ovn-multi-vcenter
https://prow.ci.openshift.org/job-history/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-multi-vcenter

UPI

https://prow.ci.openshift.org/job-history/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.17-e2e-vsphere-ovn-upi-multi-vcenter
https://prow.ci.openshift.org/job-history/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-upi-multi-vcenter

There isn't an origin E2E test for this feature, so I expect the verify job automation to fail. We will require manual QE Signoff
Created New pre-submits to help catch issues

https://github.com/openshift/release/pull/58794

/jira refresh

/retest

/payload-job periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-multi-vcenter

/payload-job periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-multi-vcenter

QE also have CI against vsphere-ipi-multi-vcenter, the storage regression test result looks good. (Although we need a fix in our auto code in some snapshot cases)
https://qe-private-deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/qe-private-deck/logs/periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-vsphere-ipi-multi-vcenter-f28
https://qe-private-deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/qe-private-deck/logs/periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-vsphere-ipi-multi-vcenter-f28
From the storage part, we are good on the feature.

/payload-aggregate periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-multi-vcenter 3

/payload-aggregate periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-multi-vcenter 3

/payload-aggregate periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-multi-vcenter 6

Updating here so it's in multiple places.  2/3 of attempts using this functionality on periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-upi-multi-vcenter have failed this week on PVC related tests.   33% success does not meet our quality bar.  We need to see 95% success prior to merge.
The IPI jobs  are failing on the too many watches and removed API checks.

Jobs are fixed and working except for two identified and unrelated bugs
/approve
/override ci/prow/verify

/override ci/prow/verify

/test e2e-aws-serial

ugh aws serial is taking over 4 hours so failing
/test e2e-aws-serial

/test e2e-upgrade e2e-aws-serial-techpreview

For the record, this PR has broken single vCenter vSphere jobs, e2e-vsphere-operator-test job in vmware-vsphere-csi-driver-operator repo.

Note to storage team: we need a periodic job for e2e-vsphere-operator-test.

@jsafrane Do you understand how it broke? Would be good to have the RCA so that we can try to avoid issues in the future

Yes - https://github.com/openshift/vmware-vsphere-csi-driver-operator/pull/276 . It broke tests that disable storage capability from vSphere. Once the feature was turned GA, then it operator started using an interface that didn't had ability to remove storageclasses if users disable storage. So, it started to fail.
I actually noticed this awhile back - https://github.com/openshift/vmware-vsphere-csi-driver-operator/pull/261/commits/eb86108ce549f1c4c9109387240742c1f55ba7bb but then, we chose not to merge that PR because that PR also had code that removes reading of feature-gate. In 4.18 - we decided we are going to keep reading the feature-gate for GA status of multi-VC and hence we will merge #261 in 4.19.