Superbuild fail

Hi, I am having a lot of problems compiling this repo. I am running ubuntu 20.04, ROS Noetic, Gcc 11.1.0 and cmake 3.26.1.
I issue the following commands:
git clone https://github.com/jedeschaud/ct_icp
cd ct_icp
mkdir .cmake-build-superbuild && cd .cmake-build-superbuild
cmake ../superbuild
cmake --build . --config Release

everything seems to be going well except for some minor warnings such as
CMake Warning (dev) at /home/MyUserName/.local/lib/python3.8/site-packages/cmake/data/share/cmake-3.26/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
  The package name passed to `find_package_handle_standard_args` (SUPERLU)
  does not match the name of the calling package (SuperLU).  This can lead to
  problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  cmake/FindSuperLU.cmake:93 (find_package_handle_standard_args)
  bench/spbench/CMakeLists.txt:32 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

However, when trying to build ceres everything crashes down:
[ 95%] Building CXX object internal/ceres/CMakeFiles/small_blas_gemm_benchmark.dir/small_blas_gemm_benchmark.cc.o
/home/MyUserName/ct_icp_NEW/.cmake-build-superbuild/MappingResearchKEU_superbuild/src/MappingResearchKEU_superbuild-build/Ceres/src/Ceres/internal/ceres/small_blas_gemv_benchmark.cc:81:6: warning: no previous declaration for ‘void ceres::BM_MatrixVectorMultiply(benchmark::State&)’ [-Wmissing-declarations]
   81 | void BM_MatrixVectorMultiply(benchmark::State& state) {
      |      ^~~~~~~~~~~~~~~~~~~~~~~
/home/MyUserName/ct_icp_NEW/.cmake-build-superbuild/MappingResearchKEU_superbuild/src/MappingResearchKEU_superbuild-build/Ceres/src/Ceres/internal/ceres/small_blas_gemv_benchmark.cc:97:6: warning: no previous declaration for ‘void ceres::BM_MatrixTransposeVectorMultiply(benchmark::State&)’ [-Wmissing-declarations]
   97 | void BM_MatrixTransposeVectorMultiply(benchmark::State& state) {
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/MyUserName/ct_icp_NEW/.cmake-build-superbuild/MappingResearchKEU_superbuild/src/MappingResearchKEU_superbuild-build/Ceres/src/Ceres/internal/ceres/schur_eliminator_benchmark.cc:130:6: warning: no previous declaration for ‘void ceres::internal::BM_SchurEliminatorEliminate(benchmark::State&)’ [-Wmissing-declarations]
  130 | void BM_SchurEliminatorEliminate(benchmark::State& state) {
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/MyUserName/ct_icp_NEW/.cmake-build-superbuild/MappingResearchKEU_superbuild/src/MappingResearchKEU_superbuild-build/Ceres/src/Ceres/internal/ceres/schur_eliminator_benchmark.cc:153:6: warning: no previous declaration for ‘void ceres::internal::BM_SchurEliminatorBackSubstitute(benchmark::State&)’ [-Wmissing-declarations]
  153 | void BM_SchurEliminatorBackSubstitute(benchmark::State& state) {
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/MyUserName/ct_icp_NEW/.cmake-build-superbuild/MappingResearchKEU_superbuild/src/MappingResearchKEU_superbuild-build/Ceres/src/Ceres/internal/ceres/schur_eliminator_benchmark.cc:181:6: warning: no previous declaration for ‘void ceres::internal::BM_SchurEliminatorForOneFBlockEliminate(benchmark::State&)’ [-Wmissing-declarations]
  181 | void BM_SchurEliminatorForOneFBlockEliminate(benchmark::State& state) {
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/MyUserName/ct_icp_NEW/.cmake-build-superbuild/MappingResearchKEU_superbuild/src/MappingResearchKEU_superbuild-build/Ceres/src/Ceres/internal/ceres/schur_eliminator_benchmark.cc:195:6: warning: no previous declaration for ‘void ceres::internal::BM_SchurEliminatorForOneFBlockBackSubstitute(benchmark::State&)’ [-Wmissing-declarations]
  195 | void BM_SchurEliminatorForOneFBlockBackSubstitute(benchmark::State& state) {
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 96%] Linking CXX executable ../../bin/small_blas_gemv_benchmark
[ 97%] Linking CXX executable ../../../bin/autodiff_benchmarks
[ 98%] Linking CXX executable ../../bin/schur_eliminator_benchmark
/home/MyUserName/ct_icp_NEW/.cmake-build-superbuild/MappingResearchKEU_superbuild/src/MappingResearchKEU_superbuild-build/Ceres/src/Ceres/internal/ceres/invert_psd_matrix_benchmark.cc:65:6: warning: no previous declaration for ‘void ceres::internal::BenchmarkDynamicallyInvertPSDMatrix(benchmark::State&)’ [-Wmissing-declarations]
   65 | void BenchmarkDynamicallyInvertPSDMatrix(benchmark::State& state) {
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/MyUserName/ct_icp_NEW/.cmake-build-superbuild/MappingResearchKEU_superbuild/src/MappingResearchKEU_superbuild-build/Ceres/src/Ceres/internal/ceres/small_blas_gemm_benchmark.cc:89:6: warning: no previous declaration for ‘void ceres::internal::BM_MatrixMatrixMultiplyDynamic(benchmark::State&)’ [-Wmissing-declarations]
   89 | void BM_MatrixMatrixMultiplyDynamic(benchmark::State& state) {
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/MyUserName/ct_icp_NEW/.cmake-build-superbuild/MappingResearchKEU_superbuild/src/MappingResearchKEU_superbuild-build/Ceres/src/Ceres/internal/ceres/small_blas_gemm_benchmark.cc:135:6: warning: no previous declaration for ‘void ceres::internal::BM_MatrixTransposeMatrixMultiplyDynamic(benchmark::State&)’ [-Wmissing-declarations]
  135 | void BM_MatrixTransposeMatrixMultiplyDynamic(benchmark::State& state) {
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 99%] Linking CXX executable ../../../bin/autodiff_benchmarks_fast_math
[100%] Linking CXX executable ../../bin/invert_psd_matrix_benchmark
[100%] Linking CXX executable ../../bin/small_blas_gemm_benchmark
/usr/bin/ld: CMakeFiles/schur_eliminator_benchmark.dir/schur_eliminator_benchmark.cc.o: in function `ceres::internal::BM_SchurEliminatorEliminate(benchmark::State&)':
schur_eliminator_benchmark.cc:(.text+0x6c): undefined reference to `ceres::internal::ThreadPool::ThreadPool()'
/usr/bin/ld: schur_eliminator_benchmark.cc:(.text+0x10f): undefined reference to `ceres::internal::SchurEliminatorBase::Create(ceres::internal::LinearSolver::Options const&)'
/usr/bin/ld: schur_eliminator_benchmark.cc:(.text+0x12b): undefined reference to `ceres::internal::BlockSparseMatrix::block_structure() const'
/usr/bin/ld: schur_eliminator_benchmark.cc:(.text+0x39e): undefined reference to `ceres::internal::ThreadPool::~ThreadPool()'
/usr/bin/ld: schur_eliminator_benchmark.cc:(.text+0x47d): undefined reference to `ceres::internal::BlockSparseMatrix::block_structure() const'
/usr/bin/ld: CMakeFiles/schur_eliminator_benchmark.dir/schur_eliminator_benchmark.cc.o: in function `ceres::internal::BM_SchurEliminatorBackSubstitute(benchmark::State&)':
schur_eliminator_benchmark.cc:(.text+0x69c): undefined reference to `ceres::internal::ThreadPool::ThreadPool()'
/usr/bin/ld: schur_eliminator_benchmark.cc:(.text+0x73f): undefined reference to `ceres::internal::SchurEliminatorBase::Create(ceres::internal::LinearSolver::Options const&)'
/usr/bin/ld: schur_eliminator_benchmark.cc:(.text+0x756): undefined reference to `ceres::internal::BlockSparseMatrix::block_structure() const'
/usr/bin/ld: schur_eliminator_benchmark.cc:(.text+0x956): undefined reference to `ceres::internal::BlockSparseMatrix::block_structure() const'
/usr/bin/ld: schur_eliminator_benchmark.cc:(.text+0xa30): undefined reference to `ceres::internal::ThreadPool::~ThreadPool()'
/usr/bin/ld: schur_eliminator_benchmark.cc:(.text+0xaec): undefined reference to `ceres::internal::BlockSparseMatrix::block_structure() const'
/usr/bin/ld: CMakeFiles/schur_eliminator_benchmark.dir/schur_eliminator_benchmark.cc.o: in function `ceres::internal::BM_SchurEliminatorForOneFBlockEliminate(benchmark::State&)':
schur_eliminator_benchmark.cc:(.text+0xd20): undefined reference to `ceres::internal::BlockSparseMatrix::block_structure() const'
/usr/bin/ld: schur_eliminator_benchmark.cc:(.text+0x105c): undefined reference to `ceres::internal::BlockSparseMatrix::block_structure() const'
/usr/bin/ld: CMakeFiles/schur_eliminator_benchmark.dir/schur_eliminator_benchmark.cc.o: in function `ceres::internal::BM_SchurEliminatorForOneFBlockBackSubstitute(benchmark::State&)':
schur_eliminator_benchmark.cc:(.text+0x12b0): undefined reference to `ceres::internal::BlockSparseMatrix::block_structure() const'
/usr/bin/ld: schur_eliminator_benchmark.cc:(.text+0x14ae): undefined reference to `ceres::internal::BlockSparseMatrix::block_structure() const'
/usr/bin/ld: CMakeFiles/schur_eliminator_benchmark.dir/schur_eliminator_benchmark.cc.o:schur_eliminator_benchmark.cc:(.text+0x15dc): more undefined references to `ceres::internal::BlockSparseMatrix::block_structure() const' follow
/usr/bin/ld: CMakeFiles/schur_eliminator_benchmark.dir/schur_eliminator_benchmark.cc.o: in function `ceres::internal::ContextImpl::~ContextImpl()':
schur_eliminator_benchmark.cc:(.text._ZN5ceres8internal11ContextImplD2Ev[_ZN5ceres8internal11ContextImplD5Ev]+0x14): undefined reference to `ceres::internal::ThreadPool::~ThreadPool()'
/usr/bin/ld: CMakeFiles/schur_eliminator_benchmark.dir/schur_eliminator_benchmark.cc.o: in function `ceres::internal::ContextImpl::~ContextImpl()':
schur_eliminator_benchmark.cc:(.text._ZN5ceres8internal11ContextImplD0Ev[_ZN5ceres8internal11ContextImplD5Ev]+0x18): undefined reference to `ceres::internal::ThreadPool::~ThreadPool()'
/usr/bin/ld: CMakeFiles/schur_eliminator_benchmark.dir/schur_eliminator_benchmark.cc.o: in function `ceres::internal::BenchmarkData::BenchmarkData(int)':
schur_eliminator_benchmark.cc:(.text._ZN5ceres8internal13BenchmarkDataC2Ei[_ZN5ceres8internal13BenchmarkDataC5Ei]+0x22d): undefined reference to `ceres::internal::BlockSparseMatrix::BlockSparseMatrix(ceres::internal::CompressedRowBlockStructure*)'
/usr/bin/ld: schur_eliminator_benchmark.cc:(.text._ZN5ceres8internal13BenchmarkDataC2Ei[_ZN5ceres8internal13BenchmarkDataC5Ei]+0x3ce): undefined reference to `ceres::internal::BlockRandomAccessDenseMatrix::BlockRandomAccessDenseMatrix(std::vector<int, std::allocator<int> > const&)'
/usr/bin/ld: CMakeFiles/schur_eliminator_benchmark.dir/schur_eliminator_benchmark.cc.o: in function `ceres::internal::BM_SchurEliminatorEliminate(benchmark::State&) [clone .cold]':
schur_eliminator_benchmark.cc:(.text.unlikely+0x36): undefined reference to `ceres::internal::ThreadPool::~ThreadPool()'
/usr/bin/ld: CMakeFiles/schur_eliminator_benchmark.dir/schur_eliminator_benchmark.cc.o: in function `ceres::internal::BM_SchurEliminatorBackSubstitute(benchmark::State&) [clone .cold]':
schur_eliminator_benchmark.cc:(.text.unlikely+0x92): undefined reference to `ceres::internal::ThreadPool::~ThreadPool()'
collect2: error: ld returned 1 exit status
make[8]: *** [internal/ceres/CMakeFiles/schur_eliminator_benchmark.dir/build.make:102: bin/schur_eliminator_benchmark] Error 1
[100%] Built target small_blas_gemm_benchmark
make[7]: *** [CMakeFiles/Makefile2:229: internal/ceres/CMakeFiles/schur_eliminator_benchmark.dir/all] Error 2
make[7]: *** Waiting for unfinished jobs....
[100%] Built target small_blas_gemv_benchmark
[100%] Built target invert_psd_matrix_benchmark
[100%] Built target autodiff_benchmarks_fast_math
[100%] Built target autodiff_benchmarks
make[6]: *** [Makefile:146: all] Error 2
make[5]: *** [CMakeFiles/Ceres.dir/build.make:86: Ceres/src/Ceres-stamp/Ceres-build] Error 2
make[4]: *** [CMakeFiles/Makefile2:260: CMakeFiles/Ceres.dir/all] Error 2
make[3]: *** [Makefile:136: all] Error 2
make[2]: *** [CMakeFiles/MappingResearchKEU_superbuild.dir/build.make:86: MappingResearchKEU_superbuild/src/MappingResearchKEU_superbuild-stamp/MappingResearchKEU_superbuild-build] Error 2
make[1]: *** [CMakeFiles/Makefile2:83: CMakeFiles/MappingResearchKEU_superbuild.dir/all] Error 2
make: *** [Makefile:91: all] Error 2

I have tried with clang 10 and got the same error. I also tried most of the alternative branches of this repo

master
python_bindings
pdell-kitware-patch-1
fix_#37
and none of them solved my problem. Do you have any suggestions on what to do?
Thanks in advance to anyone in my situation

I believe it may be useful to show how cmake was configuring everything to compile ceres:
[ 48%] Performing configure step for 'Ceres'
-- The C compiler identification is GNU 11.1.0
-- The CXX compiler identification is GNU 11.1.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/lib/ccache/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/lib/ccache/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Detected Ceres being used as a git submodule, adding commit hook for Gerrit to: /home/MyUserName/ct_icp/.cmake-build-superbuild/MappingResearchKEU_superbuild/src/MappingResearchKEU_superbuild-build/Ceres/src/Ceres/.git
-- Detected Ceres version: 2.0.0 from /home/MyUserName/ct_icp/.cmake-build-superbuild/MappingResearchKEU_superbuild/src/MappingResearchKEU_superbuild-build/Ceres/src/Ceres/include/ceres/version.h
-- Detected available Ceres threading models: [CXX_THREADS, OPENMP, NO_THREADS]
-- Building with C++17
-- Found Eigen version 3.3.7: /home/MyUserName/ct_icp/install/Eigen3/include/eigen3
-- Enabling use of Eigen as a sparse linear algebra library.
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Found LAPACK library: /usr/lib/x86_64-linux-gnu/liblapack.so;/usr/lib/x86_64-linux-gnu/libblas.so;/usr/lib/x86_64-linux-gnu/libf77blas.so;/usr/lib/x86_64-linux-gnu/libatlas.so
-- Found AMD headers in: /usr/include/suitesparse
-- Found AMD library: /usr/lib/x86_64-linux-gnu/libamd.so
-- Found CAMD headers in: /usr/include/suitesparse
-- Found CAMD library: /usr/lib/x86_64-linux-gnu/libcamd.so
-- Found COLAMD headers in: /usr/include/suitesparse
-- Found COLAMD library: /usr/lib/x86_64-linux-gnu/libcolamd.so
-- Found CCOLAMD headers in: /usr/include/suitesparse
-- Found CCOLAMD library: /usr/lib/x86_64-linux-gnu/libccolamd.so
-- Found CHOLMOD headers in: /usr/include/suitesparse
-- Found CHOLMOD library: /usr/lib/x86_64-linux-gnu/libcholmod.so
-- Found SUITESPARSEQR headers in: /usr/include/suitesparse
-- Found SUITESPARSEQR library: /usr/lib/x86_64-linux-gnu/libspqr.so
-- Found Intel Thread Building Blocks (TBB) library (2020.1 / 11101) include location: . Assuming SuiteSparseQR was compiled with TBB.
-- Found SUITESPARSE_CONFIG headers in: /usr/include/suitesparse
-- Found SUITESPARSE_CONFIG library: /usr/lib/x86_64-linux-gnu/libsuitesparseconfig.so
-- Found LIBRT library: /usr/lib/x86_64-linux-gnu/librt.so
-- Adding librt: /usr/lib/x86_64-linux-gnu/librt.so to SuiteSparse_config libraries (required on Linux & Unix [not OSX] if SuiteSparse is compiled with timing).
-- Did not find METIS library (optional SuiteSparse dependency)
-- Found SuiteSparse: TRUE (found version "5.7.1")
-- Found SuiteSparse 5.7.1, building with SuiteSparse.
-- Found CXSparse: /usr/include/suitesparse (found version "3.2.0")
-- Found CXSparse version: 3.2.0, building with CXSparse.
-- Building without Apple's Accelerate sparse support.
-- Found Google Flags (gflags) version 2.2.2: /usr/lib/x86_64-linux-gnu/cmake/gflags
-- No preference for use of exported glog CMake configuration set, and no hints for include/library directories provided. Defaulting to preferring an installed/exported glog CMake configuration if available.
-- Failed to find installed glog CMake configuration, searching for glog build directories exported with CMake.
-- Found exported glog build directory: /home/MyUserName/ct_icp/.cmake-build-superbuild/MappingResearchKEU_superbuild/src/MappingResearchKEU_superbuild-build/glog/src/glog-build
-- Detected glog version: 0.5.0
-- Found Glog: glog::glog
-- Found Google Log (glog). Assuming glog was built with gflags support as gflags was found. This will make gflags a public dependency of Ceres.
-- Using Ceres threading model: CXX_THREADS
-- Found Google benchmark library. Building Ceres benchmarks.
-- Building Ceres as a shared library.
-- Performing Test CHECK_CXX_FLAG_Wmissing_declarations
-- Performing Test CHECK_CXX_FLAG_Wmissing_declarations - Success
-- Performing Test CHECK_CXX_FLAG_Wno_unknown_pragmas
-- Performing Test CHECK_CXX_FLAG_Wno_unknown_pragmas - Success
-- Performing Test CHECK_CXX_FLAG_Wno_sign_compare
-- Performing Test CHECK_CXX_FLAG_Wno_sign_compare - Success
-- Performing Test CHECK_CXX_FLAG_Wno_unused_parameter
-- Performing Test CHECK_CXX_FLAG_Wno_unused_parameter - Success
-- Performing Test CHECK_CXX_FLAG_Wno_missing_field_initializers
-- Performing Test CHECK_CXX_FLAG_Wno_missing_field_initializers - Success
-- Creating configured Ceres config.h output directory: /home/MyUserName/ct_icp/.cmake-build-superbuild/MappingResearchKEU_superbuild/src/MappingResearchKEU_superbuild-build/Ceres/src/Ceres-build/config/ceres/internal
-- Enabling CERES_USE_EIGEN_SPARSE in Ceres config.h
-- Enabling CERES_NO_ACCELERATE_SPARSE in Ceres config.h
-- Enabling CERES_USE_CXX_THREADS in Ceres config.h
-- Enabling CERES_USING_SHARED_LIBRARY in Ceres config.h
-- Performing Test CHECK_CXX_FLAG_Wno_missing_declarations
-- Performing Test CHECK_CXX_FLAG_Wno_missing_declarations - Success
-- Do not build any example.
-- Configuring done (3.1s)
-- Generating done (0.0s)
-- Build files have been written to: /home/MyUserName/ct_icp/.cmake-build-superbuild/MappingResearchKEU_superbuild/src/MappingResearchKEU_superbuild-build/Ceres/src/Ceres-build

Maybe someone can pinpoint the bug

Hi,
So you seem not to be able to build and install ceres, which is weird, never had this problem before.
My advice would be to :

first try and install ceres independently on your machine through cmake (see the ceres github repo)
If it succeeds, that is weird, but quite indicative and you can probably use the ceres version instead of the superbuild (I'll guide you through the cmake if need be)
If it fails, try a different ceres branch ?

Let me know,
Cheers

Hi! In the end, I managed to solve the problem by changing the ceres version from 2.0.0 to 2.1.0 in the CMakeList.txt file ~/ct_icp/.cmake-build-superbuild/MappingResearchKEU_superbuild/src/MappingResearchKEU_superbuild\CMakeLists.txt Line 137.
My best guess is that having already installed ceres 2.1.0 previously messed something up in the linker part of the compilation. Either that or there are some incompatibilities between the compiler itself and ceres 2.0.0 which I find not that likely.
Before closing the issue I will try also to build the ROS portion of the repo. In the meantime, I kindly ask you to leave the issue open.

OK, I was finally able to build the project with ROS. the key takeaway points are that it's best to use the same ceres version you may have previously used and always remember to source the ros workspace before compiling.


FEATURE: Join team

depends on #40

Because of this test
https://github.com/Whist-Team/Whist-Core/blob/72cc45cb2515713a972803e41d5fc16cd991b5f9/tests/whist/core/session/test_table.py#L23-L27
we can close #42


TWW Beta: Investigate Possible SpellCooldown API Changes

Example:
Blacksmithing: https://www.wowhead.com/beta/spell=453727/everburning-ignition#recipes
seems to now show as "Available Crafts" instead of charges
also C_Spell.GetSpellCharges does not return anything for this spell like it did in Dragonflight
New possible api for such crafts?


Export to GIF Notification Action

How do you want to do this? Would be pretty straightforward with ffmpeg

I don't care

http://blog.pkh.me/p/21-high-quality-gif-with-ffmpeg.html


[Hosts] Workaround for context menu not opening

Summary of the Pull Request
Workaround for context menu not opening after selecting an entry.
Repro here: https://github.com/microsoft/PowerToys/issues/21263#issuecomment-1279979507
Side-effect of the workaround is that FlyoutShowMode.Transient doesn't focus the opened flyout.
Already addressed the issue: https://github.com/microsoft/microsoft-ui-xaml/issues/7838
Let's keep the issue opened.

PR Checklist

[x] Closes: #21263
[ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed
Context menu is opening as expected

/azp run


How to include bootstrap-files correctly?

I've spent many hours with bootstrap-datepicer, but I'm still not able to make it functional :(
I followed "Manual" instructions: jquery, moment, transition, collapse are OK
But where do I find "bootstrap.min.js" ?

you'll either need to inlcude Bootstrap from a CDN or download it from http://getbootstrap.com/getting-started/#download

I would like to have the 3rd example functional from page (just hours and minutes):
http://eonasdan.github.io/bootstrap-datetimepicker/
I have the following .html file:

and all the files are located in the same directory where is the .html file. Yet it is not working... :(

You don't need:
<script type="text/javascript" src="transition.js"></script>
<script type="text/javascript" src="collapse.js"></script>

if you have: (assuming you didn't customize bootstrap to remove them)
<script type="text/javascript" src="bootstrap.min.js"></script>

What does "not working" mean?
Do you have any console errors?

okay, I removed transition.js and collapse.js, but nothing has changed...
I have an empty input-text field, no errors on console, but the "time-hours-AM/PM" windows is not popping up for me, like in the example on your page.

please post a project somewhere with your setup.

could you like send me a zip file with an HTML in which is your datepicker located and also with .js files... thx

No, sorry. I don't have time for that. You can zip your project. You can use the any of the installation methods to get your project working.


Zigbee LED controller dimmer (GL-C-009) Gledopto 10-15s delay to switch off and unable to read states from Home assistant .

Zigbee LED controller dimmer (GL-C-009) Gledopto 10-15s delay to switch off and unable to read states from Home assistant .
I have two GL_C-009 ( led salone - Led cucina ) with Hassio v. 0.113.3 and zigbee2mqtt version: 1.14.2 - CC2531 firmware 20190608
When i switch on it works fine ( led is on immediatly ) but when I switch off, it spend 10-15 s to switch off led .
here my configuration :
data_path: /share/zigbee2mqtt
devices: devices.yaml
groups: groups.yaml
homeassistant: true
permit_join: false
mqtt:
base_topic: zigbee2mqtt
server: 'mqtt://xxxxx'
user: xxxxxxxxx
password: xxxxxxx
serial:
port: /dev/ttyACM0
advanced:
pan_id: 6754
channel: 11
network_key:
- 1
- 3
- 5
- 7
- 9
- 11
- 13
- 15
- 0
- 2
- 4
- 6
- 8
- 10
- 12
- 13
availability_blacklist: []
ban: []
whitelist: []
queue: {}
socat:
enabled: false
master: 'pty,raw,echo=0,link=/dev/ttyZ2M,mode=777'
slave: 'tcp-listen:8485,keepalive,nodelay,reuseaddr,keepidle=1,keepintvl=1,keepcnt=5'
restartdelay: 1
initialdelay: 1
options: '-d -d'
log: true

Here logs for command switch On :
zigbee2mqtt:error 2020-08-10 12:00:41: Publish 'set' 'state' to 'led cucina' failed: 'Error: Command 0x00124b001ad720e8/11 genOnOff.on({}, {"timeout":10000,"disableResponse":false,"disableDefaultResponse":false,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":null,"transactionSequenceNumber":null}) failed (Timeout - 51619 - 11 - 121 - 6 - 11 after 10000ms)'
zigbee2mqtt:info 2020-08-10 12:00:41: MQTT publish: topic 'zigbee2mqtt/bridge/log', payload '{"type":"zigbee_publish_error","message":"Publish 'set' 'state' to 'led cucina' failed: 'Error: Command 0x00124b001ad720e8/11 genOnOff.on({}, {"timeout":10000,"disableResponse":false,"disableDefaultResponse":false,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":null,"transactionSequenceNumber":null}) failed (Timeout - 51619 - 11 - 121 - 6 - 11 after 10000ms)'","meta":{"friendly_name":"led cucina"}}'

This logs for command to switch Off
zigbee2mqtt:error 2020-08-10 12:03:37: Publish 'set' 'state' to 'led cucina' failed: 'Error: Command 0x00124b001ad720e8/11 genOnOff.on({}, {"timeout":10000,"disableResponse":false,"disableDefaultResponse":false,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":null,"transactionSequenceNumber":null}) failed (Timeout - 51619 - 11 - 122 - 6 - 11 after 10000ms)'
zigbee2mqtt:info 2020-08-10 12:03:37: MQTT publish: topic 'zigbee2mqtt/bridge/log', payload '{"type":"zigbee_publish_error","message":"Publish 'set' 'state' to 'led cucina' failed: 'Error: Command 0x00124b001ad720e8/11 genOnOff.on({}, {"timeout":10000,"disableResponse":false,"disableDefaultResponse":false,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":null,"transactionSequenceNumber":null}) failed (Timeout - 51619 - 11 - 122 - 6 - 11 after 10000ms)'","meta":{"friendly_name":"led cucina"}}'

And this is the logs for 2nd entity with command switch on
zigbee2mqtt:info 2020-08-10 12:05:22: MQTT publish: topic 'zigbee2mqtt/bridge/log', payload '{"type":"device_announced","message":"announce","meta":{"friendly_name":"led salone"}}'
zigbee2mqtt:error 2020-08-10 12:05:48: Publish 'set' 'state' to 'led salone' failed: 'Error: Command 0x00124b001ad71a70/11 genOnOff.on({}, {"timeout":10000,"disableResponse":false,"disableDefaultResponse":false,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":null,"transactionSequenceNumber":null}) failed (Timeout - 17442 - 11 - 125 - 6 - 11 after 10000ms)'
zigbee2mqtt:info 2020-08-10 12:05:48: MQTT publish: topic 'zigbee2mqtt/bridge/log', payload '{"type":"zigbee_publish_error","message":"Publish 'set' 'state' to 'led salone' failed: 'Error: Command 0x00124b001ad71a70/11 genOnOff.on({}, {"timeout":10000,"disableResponse":false,"disableDefaultResponse":false,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":null,"transactionSequenceNumber":null}) failed (Timeout - 17442 - 11 - 125 - 6 - 11 after 10000ms)'","meta":{"friendly_name":"led salone"}}'

here command switch off logs :
zigbee2mqtt:error 2020-08-10 12:09:44: Publish 'set' 'state' to 'led salone' failed: 'Error: Command 0x00124b001ad71a70/11 genOnOff.on({}, {"timeout":10000,"disableResponse":false,"disableDefaultResponse":false,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":null,"transactionSequenceNumber":null}) failed (Timeout - 17442 - 11 - 126 - 6 - 11 after 10000ms)'
zigbee2mqtt:info 2020-08-10 12:09:44: MQTT publish: topic 'zigbee2mqtt/bridge/log', payload '{"type":"zigbee_publish_error","message":"Publish 'set' 'state' to 'led salone' failed: 'Error: Command 0x00124b001ad71a70/11 genOnOff.on({}, {"timeout":10000,"disableResponse":false,"disableDefaultResponse":false,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":null,"transactionSequenceNumber":null}) failed (Timeout - 17442 - 11 - 126 - 6 - 11 after 10000ms)'","meta":{"friendly_name":"led salone"}}'

Regards
Luigi

@pelusolu This is the wrong repo for such issues. This is just a wrapper for zigbee2mqtt to allow it to run as an addon in for Home Assistant.
Please post your issue here: https://github.com/Koenkk/zigbee2mqtt


H264 simulcast doesn't work well in chrome

I  try h264 simulcast at chrome(75) ,sometimes it can work,but sometimes it doesn't work well !
I used wireshark to grab the packet to observe the ssrc of  video.

I also find that VP8 simulcast doesn't work well in chrome(75),why?

please, fill in the template to give us more info. Closing in the meantime.


playbook: mount xfs device with pquota option

What type of PR is this?
/kind feature
What this PR does / why we need it:
mount xfs device with pquota option when docker-storage-option set overlay2-size.

Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

/lgtm


Memory heap getting bigger

Hi,
I am running the clique svn over a bam file from HIV virus about 140MB
java -Xms50000M -Xmx50000M -jar /clique-snv.jar -m snv-illumina -in TestHIV.trimmed_fastp.mapped_bowtie2.bam -threads 30 -outDir $TEMP_PATH
the bam is already cleaned
the memory expansion is getting larger and larger
-loop1 20GB failed
-loop2 30GB failed
-loop3 50 GB failed
-loop4 100GB still going
is there any way that we can decrease the amount of memory requirement?
Ideas1> removing duplicates from BAM
Ideas 2> splitting bam
how can I estimate the amount of memory required?
something like: the number of reads * number of core + cosmos diameter / IO speed
Thanks

Hi,
Thanks for the quick reply
here is the log file generated and it reached 91.2GB so I think is it going fail again
HIVtest.trimmed_fastp.mapped_bowtie2.haplotype_cliquesnv.log

Hi,
Thanks for the quick reply
here is the log file generated and it reached 91.2GB so I think is it going fail again
HIVtest.trimmed_fastp.mapped_bowtie2.haplotype_cliquesnv.log

It is strange. And what is the stack trace when it runs out of memory? So I can see at what exact place it fails

I am not sure how to get the stack trace, but I can hand you over the bam file if you want to try
let me know which method works for you

Yes, with bam file it will be even easier to find the problem.
Thanks
P.S. Stack trace is just the error with which it fails. Something like this:
Exception in thread "main" java.lang.OutOfMemoryError: GC overhead limit exceeded
at java.util.HashMap.newNode(HashMap.java:1742)
at java.util.HashMap.putVal(HashMap.java:630)
at java.util.HashMap.put(HashMap.java:611)
at java.util.HashSet.add(HashSet.java:219)
at edu.gsu.algorithm.AbstractSNV.slowCliquesMerging(AbstractSNV.java:401)
at edu.gsu.algorithm.AbstractSNV.getMergedCliques(AbstractSNV.java:59)
at edu.gsu.algorithm.SNVIlluminaMethod.getMergedCliques(SNVIlluminaMethod.java:213)
at edu.gsu.algorithm.SNVIlluminaMethod.getHaplotypes(SNVIlluminaMethod.java:103)
at edu.gsu.start.Start.illumina2SNV(Start.java:108)
at edu.gsu.start.Start.main(Start.java:56)

it seems the problem was with the bam file not the application


Add Show/Hide Password Functionality

This is my First contribution.
This pull request introduces a Show/Hide Password feature in the password input field.

https://github.com/user-attachments/assets/ddde106f-f135-4e5a-ae19-15fee2c80346
Changes Made:

Added a button to toggle the visibility of the password.
Updated the user interface to enhance usability and improve user experience.

Benefits:

Users can now easily view their password when needed, reducing the chances of input errors.
Improved accessibility for users managing their passwords.

Please review the changes and let me know if any modifications are required.

@SwanandD121 i have raised a PR, before merging add the labels here too or else it wont count for hacktoberfest 2024 thankyou

First you have to raise an issue and wait till you get assigned, then start working. I cant merge PRs if you do not raise that issue.
Also this feature has been implemented previously.


Hadoop and Spark set up on Local

Facing problem installing jupyter notebook on local hence using it on bluemix


Clean up velero buckets

Signed-off-by: yeya24<EMAIL_ADDRESS>Fixes https://issues.redhat.com/browse/OSD-4097

@jharrington22 @meowfaceman Would you guys mind reviewing this one?  I want to get your eyes on it since the request came from your way.
Thanks!

This lgtm -- as long as it deletes these velero buckets, we're good.
Does this get baked into a container somewhere? We'd love to use this directly.


Fix head stats and hooks when replaying a corrupted snapshot

When loading a snapshot and encountering a corrupted chunk, we discard previously loaded series from the snapshot and resort to replaying the wall. In such cases, we were not resetting the number of series in the head, leading to double counting them.
Additionally, we did not invoke the PostDeletion hook when resetting the memory - this needs to be called as the PostCreation was called for the series which we were able to replay from the snapshot but were subsequently discarded.

@bboreham PTAL?

@codesome is this something you could help review?

Thanks @alanprot, this lgtm ;)


Update Btn.svelte to have tabindex

I got the following error while building:
vite v4.3.9 building for production...
transforming (539) node_modules/@sveltepress/theme-default/dist/components/icons/PointLeft.s2:58:24 PM [vite-plugin-svelte] /node_modules/@sveltepress/theme-default/dist/components/pwa/Btn.svelte:9:0 A11y: Elements with the 'button' interactive role must have a tabindex value.
 7: </script>
 8:
 9: <div
    ^
10:   role="button"
11:   class="btn"

Best regards

Thanks for your feedback!
This is a warning, won't block the building process.
Will fix it in the next release

Thank you for your work!


[named_blobs] Integrate NamedBlobDb and support deletes

Use NamedBlobDb in AmbryIdConverter
Add support for getting the blob ID deleted after a delete call
Call delete from inside of AmbryIdConverter.

Codecov Report

Merging #1707 (9312cd2) into master (c28a89b) will decrease coverage by 58.43%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c28a89b...9312cd2. Read the comment docs.

Just went through the code. Will take another round of review tomorrow.
2 basic questions:
The NamedBlobPath is constructed by String accountName, String containerName, String blobName.
It looks like / is not allowed in blobName to indicate a user defined path. What's intention of not supporting user defined path?
Is URL encoding/decoding needed for blobName part? (Can people may use space or UTF8 chars in blobName? )

@zzmao

The NamedBlobPath is constructed by String accountName, String containerName, String blobName.
It looks like / is not allowed in blobName to indicate a user defined path. What's intention of not supporting user defined path?

With this change, slashes will be allowed in the user defined path. By using path.split("/", 4), the split string will include up to 4 parts and any extra / remaining in the path will go into the fourth part.
So named/acct-a/cont-a/a/b/c will split to [acct-a, cont-a, a/b/c].

Is URL encoding/decoding needed for blobName part? (Can people may use space or UTF8 chars in blobName? )

I think that it is a good practice to use URL encoding when possible. Spaces and international characters may be used in file names so it is useful to support them here as well. You bring up a good point though that we have to think about safe limitations on the blob name. In a future PR I may introduce additional validation for "dangerous" characters. Another alternative is to only support URL safe characters for now and then expand the scope as needed. What do you think?

I get confused here actually. If the browser send url encoded request, does our netty layer decode it?
I am good with a future PR to validate "dangerous" characters.
My understanding is that we are only supporting URL safe characters to this PR.

I get confused here actually. If the browser send url encoded request, does our netty layer decode it?
I am good with a future PR to validate "dangerous" characters.
My understanding is that we are only supporting URL safe characters to this PR.

You are right, I made the wrong assumption about what NettyRequest does. I thought it would leave URL encoded characters in the path as is, but that is not true since we use the QueryStringDecoder::path method instead of QueryStringDecoder::rawPath. This means that I should not be URL decoding a second time when parsing a path.
    QueryStringDecoder query = new QueryStringDecoder("/a/b%20/c?key=val%20ue");
    System.out.println(query.path());
    System.out.println(query.rawPath());
    System.out.println(query.parameters());

returns
/a/b /c
/a/b%20/c
{key=[val ue]}

I will update the PR.


Parsing of filter rules specific to Microsoft

This allows for filters typically used for gradients to be parsed. The following was taken from Bootstrap 4.
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#80000000', endColorstr='#00000000', GradientType=1);

I am not sold on the Value I've introduced here, especially as a child of PrimitiveValue. Please let me know how to adapt my patch should this change interest you.
Cheers!

I’m a bit biased against this as it really isn’t valid CSS and the more modern syntax (with -ms-filter is available to IEs dating back to IE 8). I’m not sure there is much use for the old-old syntax anymore. But maybe we can accept and silently discard it in lenient mode (on second thought, I think this may already be what we are doing but I’m not sure)? Or, add a new config that adds support for this. But then, please make it opt-in and make the class that represents the result a subclass of CSSFunction.

Now that you mention it, I discovered that IE9 does not even support this format. Strangely it is still found in Bootstrap 4 (as of today) as you can see here. I did change to only allow the old-style filters in lenient mode though, and tested that string quoting had no impact on IE8 using this:

Here

There

Over there

Thanks for suggesting to use a CSSFunction, I did not realise I could.
Cheers.
Fred

Great, thanks a lot!


Adds comma_first as an option for javascript

because after digging thru js-beautify's code:
atom-beautify/node-modules/js-beautify/js/lib/beautifier.js
on approximately line 1213 inside the Beautifier.prototype.handle_comma function, you can see on line 1227:
} else if  (this._options.comma_first){ // <--------

so the option "comma_first" both exists, and is usable and works as expected if you specify the option in your .jsbeautifyrc
:-)
What does this implement/fix? Explain your changes.
js-beautify has an option for comma first style. it exists in their code. i just added to the readme so people know it exists
Does this close any currently open issues?
had i made one rather than solving the problem directly, yeah
Any other comments?
ezpz. relates to my other pull request which just adds the example to the options.md
Checklist
Check all those that are applicable and complete.

[x] Merged with latest master branch
[x] Regenerate documentation with npm run docs
[x] Add change details to CHANGELOG.md under "Next" section
[x] Added examples for testing to examples/ directory
[x] Travis CI passes (Mac support)
[x] AppVeyor passes (Windows support)

i think the appveyor thing has nothing to do with this. i just updated readmes.


Pr218/master review fixes

Changes Unknown when pulling 6e251dd9c24546d00a62c6f1123ccd0e6e477309 on pr218/master-review-fixes into ** on pr217plus/master-with-fixes**.


Properly unload taskListManager if Start fails

Issue #308

Coverage decreased (-0.3%) to 67.626% when pulling d251665c9ed20aea21a1febf1589c5aa6f3a0710 on tamer-eldeeb:matching_start into 886a2dc0d9beb7badfa20bce499f514b1fc7153f on uber:master.

Coverage decreased (-0.3%) to 67.659% when pulling d251665c9ed20aea21a1febf1589c5aa6f3a0710 on tamer-eldeeb:matching_start into 886a2dc0d9beb7badfa20bce499f514b1fc7153f on uber:master.

Coverage decreased (-0.4%) to 67.515% when pulling d251665c9ed20aea21a1febf1589c5aa6f3a0710 on tamer-eldeeb:matching_start into 886a2dc0d9beb7badfa20bce499f514b1fc7153f on uber:master.

Coverage decreased (-0.1%) to 67.808% when pulling aa85cefb1e2c3388a1aa779d905ea4c6f09c374b on tamer-eldeeb:matching_start into 886a2dc0d9beb7badfa20bce499f514b1fc7153f on uber:master.

Coverage decreased (-0.2%) to 67.774% when pulling 867d008f34007aeb502da4dabc58ba3cd17d345a on tamer-eldeeb:matching_start into 886a2dc0d9beb7badfa20bce499f514b1fc7153f on uber:master.

Coverage decreased (-0.2%) to 67.689% when pulling 4cf4d170b785bb57e92a5d976117c605cfecc43c on tamer-eldeeb:matching_start into 886a2dc0d9beb7badfa20bce499f514b1fc7153f on uber:master.

Coverage increased (+0.01%) to 67.861% when pulling 41cae9d93bc74892b9c19e4185974f59b8528356 on tamer-eldeeb:matching_start into 721339672ce3901e91045667eed5b3f27ac83bdb on uber:master.


Contact page on townhallpledge.com not loading

https://www.townhallpledge.com/#contact

it was just an link to email I dont think we ever had a page. I fixed it though


Manually hide label created for screenreaders

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #119
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Applied styles to visually hide the manually created label for screenreaders.
Type of change:
Please delete options that are not relevant.

[ ] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

:tada: This PR is included in version 2.5.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Using a ruby syntax highlighter library instead of calling the pygments executable

I've took the pygments/highlight files from your project to use in a project of mine, where I generate documentation, and noticed something : executing pygments as an external program each time has a huge overhead. (if I remember well my Cygwin days, it may be even worse on windows)
Basically, generating all pages (about ~2000-3000 syntax highlighted blocks in total, which is quite extreme) took 7 minutes on my C2D Macbook.
I then switched to coderay (a pure ruby library that works the same as pygment, it supports fewer languages but the lexer syntax is nearly the same as pygments'). My generation time shrank from 7min to... 15s.
I know there is also a 'syntax' gem, but it has fewer languages, and 'ultraviolet' which I could not get to install (based on textpow which is based on oniguruma... lots of dependencies but it supports more languages).

config.yml
markdown: kramdown
kramdown:
  use_coderay: true
  coderay:
    coderay_line_numbers:


[WIP] Let/const

I've just started digging in my heels on this one. I'm keeping this in an open PR to get feedback and ensure I don't step on anyone's toes.
TODO:

[x] represent different scope types
[ ] rename "block" to "scope" (@jeffmo you mentioned this, seems like a good idea)
[x] create block-level scopes
[x] hoist vars, classes, functions
[x] allow defining let/const identifiers
[ ] test for-loop statement and iteration scope
[ ] strict mode vs. not
[ ] should functions be block level???
[ ] TDZ - I don't think we can statically ensure define before use, but best effort
[ ] error on const reassignment
[ ] let block
[ ] let expressions

Overview:
In order to support let/const, we need to know what kind of scope each
block is.
Currently, the only blocks we have are what I am calling "Hoist" blocks.
Whenever an entry which should be hoisted is added to the env, it should
be added to the closest "Hoist" block.
Let/const identifiers should be added to the nearest "Block" block.
Currently we only create blocks corresponding to hoist points.
Subsequent commits will need to create a great many more blocks to
support block-level scope.

cc @avikchaudhuri as well to follow along

The test failure in that last commit is throwing me for a loop. I'll look again tomorrow, but if anyone has some insight, I'd appreciate it.

OK! Figured that last error out. Some preliminary feedback on this approach would be really helpful.
Also, if anyone has a real-life project with let/const, and is able to try out this branch on their project, I'd be happy to look into any issues.

Haven't gotten to the meatier portion of the PR yet, but wanted to send what I have so far before I run to lunch. Will come back to finish out the comments later today/tonight

I completely agree about the renames, and it's encouraging that your suggestions are so in line with what I was thinking. The only reason I hesitated to rename now is that I didn't want to cause merge difficulties down the road, but I think a bit of upfront pain is better than wonky names. And hey, it's not my problem ;).

Heh. Well if it's not much harder for you, making the renames in a separate PR (that this one could be considered "stacked" on top of) might make my life a little easier :)
We can just make sure they get merged in proper order

Yeah, I think it makes sense to do a separate PR that renames block to scope, and some of the other changes you identified, so that change can be rolled in sooner. I'll go ahead and do that before moving on with this let/const stuff.

not sure where you guys ended up on the naming of the two different types of scopes (HoistedScope and BlockScope?) but the spec seems to refer to them as LexicallyScoped and VarScoped so perhaps we could go with LexicalScope and VarScope?

I can get behind that naming, for sure.

I've always found "lexically scoped" pretty confusing (both are "lexical"). I could live with it if someone feels strongly, but I'd be even happier with "VarScope" and "LetScope"

yeah I find it non-optimal too, but since we're following a spec I thought it might be easier if they matched so that you don't have to wonder about/remember the translation between the code and the spec. if we name one VarScope then LexicalScope vs LetScope probably doesn't matter as much because I can remember it as the "other" one.

Ok, will leave it up to you @samwgoldman -- I can live with either I guess

We're talking about these definitions, correct? It makes sense to me that VarScope is-a LexicalScope, and I don't see that as a problem. Not the most confusing subtyping relationship in flow. :)
Since it makes sense to me, and I like the idea of naming things close to the spec, I'll try it out and we can see how it feels.

I was actually looking at these:
http://people.mozilla.org/~jorendorff/es6-draft.html#sec-block-static-semantics-lexicallyscopeddeclarations
http://people.mozilla.org/~jorendorff/es6-draft.html#sec-block-static-semantics-varscopeddeclarations
(and similar sections all over section 13)

Closing in favor of rebased #431


Use base64 to fully encode basic auth creds

Not sure if you mind me reducing number of allocations, I think it would be better to use directly Display rather than Into<String> and allocate only formatted string instead of each String for username and password
Closes #320

Woops, sorry I wasn't clear, but the "basic " part isn't supposed be base64 encoded. So, the end result should look like Authorization: Basic QWxhZGRpbjpPcGVuU2VzYW1l.

Opps my bad, I'll correct it

Sorry about the delay, Github didn't alert me to the rebased commit. Thanks for fixing this!


Show QR code in fullscreen

Issue #1150
please review
It works in the following way:
after clicking create button to create qr code, the mouse become a pointer cursor and the qr preview can be clicked to enter full screen mode. You can exit by clicking esc button or by clicking "back" on mobile phone.

Internal Tracking ID: EXPOSUREAPP-14227

Hey, thanks for your first contribution! I made some slight code style improvement, but for some reason I'm lacking permission to push she changes.
Perhaps because I checked out this PR and you are working on a fork. I left you a change request instead.
@Ein-Tim It seems to display correctly for me in Chrome on a 2560x1440 screen. What are your specs / browser?

@brianebeling
I'm using Safari on macOS 12.6 with a 24" display.

@brianebeling
I'm using Safari on macOS 12.6 with a 24" display.

Thanks! We will check if we can reproduce the issue

@brianebeling
I'm using Safari on macOS 12.6 with a 24" display.

Thanks! We will check if we can reproduce the issue

I'm going to install safari and check that

@brianebeling
I'm using Safari on macOS 12.6 with a 24" display.

Thanks! We will check if we can reproduce the issue

I'm going to install safari and check that

To be honest it is very difficult to reproduce it without mac. I tried safari in windows but it does not work the same :(

@brianebeling
I'm using Safari on macOS 12.6 with a 24" display.

Thanks! We will check if we can reproduce the issue

I'm going to install safari and check that

To be honest it is very difficult to reproduce it without mac. I tried safari in windows but it does not work the same :(

Sadly Safari behaves very differently across operating systems. On MacOS it uses WebKit, while on Windows it might use an outdated version because it is discontinued. Testing Safari is best done on Safari, there is no substitute. However, there are services that grant you access to a Safari instance running on Mac. Its a slow-ish experience, but it works.
The only tool I have experience with in that regard is Playwright. Please note that this is strictly not a recommendation by the open-source team, but my personal recommendation for a quick test without costs.
I will check back with the team to see if we can reproduce this on a Mac. If we come to no conclusion through research or reproduction, I'd suggest we merge the PR. Its not a breaking change and I doubt a lot of people using this feature on a daily basis will use a Mac for that (e.g., public check in screens). We can still take care of the issue if it comes up and someone reports it as a real issue. Maybe we will get some additional information then.

Hey @przybciu, thanks so much for your contribution. You have done a great job! I would like to contribute a couple of ideas to improve this new functionality:

Implement a small indicative text under the generated QR with the following message: (EN) Click on the QR code for full screen - (DE) Klicken Sie auf den QR-Code für Vollbild
In case you are unable to fix the Safari error on macOS, disable this option just for Safari on macOS and hide the text mentioned in the previous point.

@przybciu Hey, we want to merge this as quickly as possible to quickly get it out, even without the text improvement.  Unfortunately, we can't merge your fork, but we want to give you the opportunity to create a branch with your work in our repository - so you will be correctly credited - and then we will merge it.

@przybciu
Please check out the GitHub help https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork
"Allow edits from maintainers" should be enabled in your pull request.

Thank you very much for your PR @przybciu! I created a new PR and closed this one, because of the permission trouble.
New PR is here: https://github.com/corona-warn-app/cwa-website/pull/3244


Swagger JSON generated by SpringFox shows 'Consumes' for GET and DELETE operations

I am using SpringFox to generate a Swagger UI and static doc from a Spring REST application.
Is there any way to stop SpringFox from adding a 'consumes' section to the generated Swagger for GET operations? As I understand it, GETs should not include a body, so they don't consume anything.
You can see this in the springfox-demos where the 'findPetsByStatusUsingGET' operation includes a 'consumes':
      "get": {
        "tags": [
          "pet-controller"
        ],
        "summary": "Finds Pets by status",
        "description": "Multiple status values can be provided with comma seperated strings",
        "operationId": "findPetsByStatusUsingGET",
        "consumes": [
          "application/json"
        ],
        "produces": [
          "application/xml",
          "application/json"
        ],

The same thing applies to DELETE operations:
       "delete": {
        "tags": [
          "pet-store-resource"
        ],
        "summary": "Delete purchase order by ID",
        "description": "For valid response try integer IDs with value < 1000. Anything above 1000 or nonintegers will generate API errors",
        "operationId": "deleteOrderUsingDELETE",
        "consumes": [
          "application/json"
        ],

NOTE: that this only true for media types that support payload. For example this doesnt apply to application/x-www-form-urlencoded and multipart/form-data.

This is not valid in all uses cases ☝so closing as won't-fix

I'm using springfox 2.7.0 and facing the same issue.
  {
  "swagger":"2.0",
  "info":{},
  "paths":
  "/api/v1/...":{
  	"get": {
  		"summary":"...",
  		"operationId":"getSmthWithGET",
  		"consumes":[
  			"application/json"
  		],
  		"produces":[
  			"application/json",
  		"application/json;charset=UTF-8"
  		]
  	     }
      }
  }

Based on swagger.json I'm generating API pdf with swagger2markup, which results in having 'Consumes
• application/json' for every GET and DELETE operation.
Will it be fixed one day?
Is there any workaround?
Thanks in advance.

That seems reasonable... let me see if there is a workaround

Hi here!
We are facing the same issue and it forced us to have an ugly hack in our code.
Is there an ETA for this issue? Happy to collaborate if necessary 😄

@toni-lopez would certainly appreciate your help. ETA is as soon as I have some bandwidth to work on it. Currently looking to support OAS 3.0 at a minimum

@dilipkrish , i knew the as the per the documentation swagger does not support this, but at least if you provide some work around to solve this issue (typeerror: failed to execute 'fetch' on 'window': request with get/head method cannot have body. in swagger). Note this issues are mainly happen only for spring boot actuator alone. thanks in advance.

I am having the same issue. I am on .Net Core 2.2 using Web API and having the same problem. consumes is showing following for me...
paths": {
    "/api/Search": {
      "get": {
        "tags": [
          "Search"
        ],
        "operationId": "SearchCars",
        "consumes": [
          "application/json-patch+json",
          "application/json",
          "text/json",
          "application/*+json"
        ],
        "produces": [
          "application/json"
        ],
        "parameters": [
          {
            "name": "input",
            "in": "body",
            "required": false,
            "schema": {
              "$ref": "#/definitions/CarSearchInputDTO"
            }
          }
        ],
        "responses": {
          "200": {
            "description": "Success",
            "schema": {
              "uniqueItems": false,
              "type": "array",
              "items": {
                "$ref": "#/definitions/CarSearchResultDTO"
              }
            }
          }
        }
      }
    }
  },

I think the problem is with expecting an object in get request params... Once, I switch to POST for this method, it started working fine, or even if I break the object into indiviual param fields, it works fine as well :)


Setup Instructions

Hi!
It would be nice if you could add a few lines explaining how to use/setup this script or plugin on Unity. I will try to download and try to make it work but a few lines of instructions would help people like me who are not very familiar with Unity plugins/extensions/whatever.
Best

Also, it would be nice on the existing code instructions to add the namespace to the method calls (or mention the needed "using" directive).


Fix links

Links should be constructed as https://mvlc.ent.sirsi.net/client/en_US/andover/search/results?te=ILS&qu=ISBN=[ISBN]. Currently they are constructed as https://mvlc.ent.sirsi.net/client/en_US/andover/search/results?te=ILS&qu=ISBN=[same hash].

Fixed with commit 856e7c3bab5d9e6c052ed4712d17ac65818446b6


Windows GUI: Perfect the alignment in Preferences window

More perfectly resolve #889

Perfected the line where the two sides touch too.


Allow app specific permissions

This depends on https://github.com/opendatakit/androidcommon/pull/37

runtests


HexCharacter() doesn't protect against end of stream

The code reads 4 characters without testing for end of stream:
        for (let idxNo = 0; idxNo < 4; idxNo++) {
            hexNumberString += this.read();
        }

Ouch!!
Thx for having a # eye ...

Fixed in repo, will create release later ...


Implement export * as ns from module syntax

This PR does the following:

implements support for export * as ns from "module" syntax a normative change PR to ecma262 which has tc39 consensus
See spec diff: https://spectranaut.github.io/proposal-export-ns-from/
See normative PR here: https://github.com/tc39/ecma262/pull/1174#issuecomment-425120082
This is placed behind a flag but set to default enabled
Adds some relevant tests
Fixes a bug where duplicate exports weren't always a syntax error (implementing this feature correctly without fixing this bug would have been awkward)
Some drive by syntax error message improvement for duplicate exports and alias'd exports

"Syntax error: Syntax error" -> "Syntax error: Duplicate export of name '%s'"
"Syntax error: Syntax error" -> "Syntax error: 'as' is only valid if followed by an identifier."

There are unfortunately some remaining related test262 failures due to #5778 and #5501
closes #5759
fixes #5777

Is there anything more I should do on this?


Added validation logic with further refactor

Added a class to validate the incoming request (with tests). Following the current API spec for validation.
Refactored MpicCoordinator further, extracting some logic into separate methods. Added a few tests around them.
Reworked building of async lambda (perspective) function calls to use a class instead of just a tuple.
Using more Enums and constants to avoid some of the "magic strings" in the codebase.
Extracted building of the HTTP response into a separate class (with tests).
Added a unit test and an e2e test to ensure integration of the request validator with MpicCoordinator.
Fixed some broken stuff! The previous logic may have invalidated dcv-with-caa checks; tests now exist to prevent that regression.
Caution: we will need to rename some fields in the API and flesh out the specified response object following this merge. And take another pass through it to make sure everything that's require is enforced and everything optional is treated as such.

I like the changes. I pushed an update to the spec moving from v 1.0.0 to v 1.0.1 to include the number-of-perspectives-used and required-quorum-count-used responses that this commit introduces. Now that the spec is up to date I will merge this into master.


Emmet will not expand tag names in pug files

When using emmet with html, typing in "sec" will show the suggestion box that will expand it to a section start and closing tag.
When using pug, the emmet abbreviations are not present at all. Typing in "sec" and hitting tab will not expand it into "section"

Note: the code for the VS Code Emmet extension is now at the microsoft/vscode repo https://github.com/microsoft/vscode.


Add the ability to take snapshots of views (especially for failed tests)

Started taking a look at this here, https://github.com/liamjdouglas/LayoutTest-iOS/tree/issue-1-adding-snapshots. Idea so far is that we'll take a snapshot of each failing test and save it into a directory in the derived data with the structure, /LayoutTestImages/{ClassName}/{MethodName}/{ImageName}.png.
The path to the folder will be output after each test case class and an index.html file is also generated for each class which contains the failure reasons, images and the data that the tests failed with.
Currently planning to have this in LYTLayoutTestCase or would you prefer that snapshot test cases have their own class which subclasses LYTLayoutTestCase?

This looks really promising. I like the idea of outputting HTML.
I'd say let's add this to LYTLayoutTestCase (but functionality in a separate class). I think it should be enabled by default since it seems like a useful tool. I had a brief look over your code, and have a few thoughts:

Sometimes with failures, everything fails and you end up with 1000+ failures. Any performance concerns? Do you think we should limit the failures to some reasonable number by default and stop taking screenshots? Not sure if this is necessary...if you're running on the simulator, 1000 images should be pretty trivial?
I think we should add an option to LYTConfig to turn this on or off
It looks like the data is being included in the filename. This can be really long for some views. Perhaps we should include a hash here and include the data in the HTML page?

Looking forward to the pull request.

I've started splitting out the functionality today and started putting it under test.

There will be a performance hit if the number of failing tests reach the 1000s, probably even the high hundreds. I'll take a look at some options see if the image creation can be optimised or like you say limit the number of images saved. Could be limited to 10 per test method or 100 per class something like that?
Yep no problem I'll add that in.
Yep good idea, I'll switch it to a hash.

One other thought. This only catches errors thrown by the library's automatic tests, not by custom tests. For instance:
runLayoutTests() { (view: MyView, data: [NSObject: AnyObject], context: Any?) {
    XCTAssertEqual(view.lyt_height, 30)
}

If this assertion fails, we won't generate a screenshot. Do you know of anyway to catch test failures like this?
I tried using a try catch, but it doesn't work here.

At the moment I'm using
- (void)recordFailureWithDescription:(NSString *)description inFile:(NSString *)filePath atLine:(NSUInteger)lineNumber expected:(BOOL)expected {
to catch the all the failures. From what I've seen so far and from the docs I think this should catch all XCTAssert failures.

@method -recordFailureWithDescription:inFile:atLine:expected:
Records a failure in the execution of the test and is used by all test assertions.

I've tried in the sample app in SampleTableViewCellLayoutTests replacing the contents of runLayoutTests() with multiple XCTAssertFalse(true) and recordFailureWithDescription:inFile:atLine:expected is called once for each failure. Currently this will save one image per iteration of runLayoutTests() with different data/view size that has a failing test.
Does that sound ok?

Nice. I didn't know about this method. This seems like exactly what we're looking for.

Added pull request #7

I'll take a look today. Thanks!

A bit slow getting round to reviewing all the code (busy start to the week)...probably some will come in chunks. Excited to get this in though...sorry about being slow to review.

Ok...first pass of the review done. Added a few comments here and there, but overall, looks really good.
Another thing: are you planning on squashing these commits for the merge? I'm not sure what the general practice is, but seems like there are a bunch of intermediate commits which may not compile/are buggy.
I'm used to working on a trunk model, so maybe the open source community tends to prefer something different and we shouldn't squash?

Probably best to squash them and then merge it in. Let me know if there's anything else to update and once ready to merge I'll squash.

Fixing in pull request - #9 Thanks @liamjdouglas for the code.


Issue with login popup with Outlook Client. Authentication popup not closed with Outlook Client

Login(Authentication) pop is not closing in Outlook Client. Same scenario worked fine in Outlook web app with Chrome,Edge.
Specifically observed with Outlook Client. Assuming due to "Office.context.ui.messageParent" not returning Error/Success data to parent window.
Expected behavior*
Popup should close as user is authenticated.
Environment

Platform [PC desktop, Mac, iOS, Office Online]: PC
Host [Excel, Word, PowerPoint, etc.]: Outlook
Office version number: Outlook version( 2002)
Operating System: Windows 10/ Server 2016
Browser (if using Office Online): NA ( Outlook Client)

Hi @abhsha,
I'm sorry for the late response on this issue. Can you confirm if you are still seeing this behavior? Also can you confirm if this is the sample where you see the bug behavior? https://github.com/OfficeDev/PnP-OfficeAddins/tree/main/Samples/auth/Outlook-Add-in-Microsoft-Graph-ASPNET
I see the popup auth dialog closing correctly. So please let me know if I'm looking at the correct sample, or if I need to follow any specific steps to reproduce the behavior.
Thanks!
David


⚠ Site ANTS has degraded performance

In 165e5e3, Site ANTS (https://ants.gouv.fr) experienced degraded performance:

HTTP code: 200
Response time: 8656 ms

Resolved: Site ANTS performance has improved in db78e0e.


Codegen logical operators

Codecov Report
Attention: Patch coverage is 91.66667% with 9 lines in your changes missing coverage. Please review.

Project coverage is 84.15%. Comparing base (c11070c) to head (52befa0).

Files
Patch %
Lines

src/Escalier.Codegen/Codegen.fs
91.66%
9 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
+ Coverage   84.00%   84.15%   +0.15%
==========================================
  Files          23       23
  Lines       11107    11193      +86
  Branches     1565     1571       +6
==========================================
+ Hits         9330     9420      +90
+ Misses       1777     1773       -4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Gradle wrapper doesn't respect HTTP 301 and 302 redirects to HTTPS

Expected Behavior
If distribution URL returns a 301 or 302 status code with a Location header, the wrapper should retry the request with the URL returned in the Location header.
Redirects should be followed recursively (until a reasonable upper bound in the count of redirects is reached).
Current Behavior
If the configured distribution url returns a 301 or 302 the wrapper fails:
Downloading http://my-local-dist-mirror.example.com/gradle-4.8.1-all.zip

Could not unzip C:\Users\reegnz\.gradle\wrapper\dists\gradle-4.8.1-all\2fm1bdco840fg368obqx86w8g\gradle-4.8.1-all.zip to C:\Users\reegnz\.gradle\wrapper\dists\gradle-4.8.1-all\2fm1bdco840fg368obqx86w8g.
Reason: error in opening zip file
Exception in thread "main" java.util.zip.ZipException: error in opening zip file
        at java.util.zip.ZipFile.open(Native Method)
        at java.util.zip.ZipFile.<init>(ZipFile.java:225)
        at java.util.zip.ZipFile.<init>(ZipFile.java:155)
        at java.util.zip.ZipFile.<init>(ZipFile.java:169)
        at org.gradle.wrapper.Install.unzip(Install.java:218)
        at org.gradle.wrapper.Install.access$600(Install.java:27)
        at org.gradle.wrapper.Install$1.call(Install.java:75)
        at org.gradle.wrapper.Install$1.call(Install.java:48)
        at org.gradle.wrapper.ExclusiveFileAccessManager.access(ExclusiveFileAccessManager.java:69)
        at org.gradle.wrapper.Install.createDist(Install.java:48)
        at org.gradle.wrapper.WrapperExecutor.execute(WrapperExecutor.java:107)
        at org.gradle.wrapper.GradleWrapperMain.main(GradleWrapperMain.java:61)

Context
We had the distribution available through http in the past.
Recently we changed the server to redirect all requests on port 80 to try again with https.
This broke the gradle wrapper downloads in our CI.
Steps to Reproduce (for bugs)

Have a webserver that redirects from a specific url to the gradle wrapper location
Configure gradle wrapper with that url

A possibly simple fix is to:

cast the used URLConnection to HttpURLConnection
set this flag to true: https://docs.oracle.com/javase/8/docs/api/java/net/HttpURLConnection.html#setFollowRedirects-boolean-

Reading up on this a bit more, the issue is that java designers decided not to follow redirects across protocols, despite that flag being set (it's default is true anyways).
Eg. from http to https a redirect is not followed.
Context:
https://bugs.java.com/bugdatabase/view_bug.do?bug_id=4959149
https://bugs.java.com/view_bug.do?bug_id=4620571

@reegnz I doubt we'll change this behavior based on the comments in those issues.
Can you change your wrapper URL to use https?

Yupp, that was our workaround, no big deal.
A remaining issue though is that not following the redirect also breaks caching the wrapper zip -> gradle assumes the wrapper is downloaded already but fails to unzip.
This is because the body returned with the 302 is usually not a ZIP file.
Would it be possible to at least NOT cache the response if it's not an HTTP 200?

Opened a separate bug for gracefully failing in case the response code is not 200 OK.


Dockerfile: only use http or https

Since rsync is not installed within the docker-container reflector will spit errors at you. This forces reflector to use http or https.

Shouldn't it be https for security?

It defaults to http,https and rsync. But I agree that https would make more sense


[Bug]: Kernel crashing with MetadataExtractor() when get_nodes_from_documents()

Bug Description
My kernel keeps crashing when I use the KeywordExtractor() while extracting nodes from a list of  178 documents. The document nodes don't have a lot of text either, so I don't think it's an issue with length. I do add my own metadata to the documents before using an LLM to extract keywords. It works fine, however, if I do it on a list of 5 documents using either OpenAI or Llama-2.
I've tried it in VS Code and Pycharm, so don't think it is an IDE issue.
llm = OpenAI(temperature=0.1, model="gpt-3.5-turbo-16k")
metadata_extractor = MetadataExtractor(
    extractors=[KeywordExtractor(keywords=10, llm=llm),
    ],
)
node_parser = SimpleNodeParser.from_defaults(metadata_extractor=metadata_extractor, include_metadata=True, callback_manager=callback_manager)
nodes = node_parser.get_nodes_from_documents(documents, show_progress=True)

I also tried it with llm = LLMPredictor(OpenAI(temperature=0.1, model="gpt-3.5-turbo-16k")) but that didn't work either.
Let me know if there's any additional information that is needed to troubleshoot this issue.
Version
0.8.4
Steps to Reproduce
doc_id_col = 'id'
documents=[]
for idx, row in df_studies.iterrows():
    doc = row[text_col[0]]
    meta = {val: row[val] for val in df_studies.columns if val not in text_col}
    document = Document(
        text=doc,
        metadata=meta,
        excluded_embed_metadata_keys=metadata_cols_exclude, # list(meta.keys()),
        excluded_llm_metadata_keys=metadata_cols_exclude, # list(meta.keys()),
        metadata_seperator="::",
        metadata_template="{key}=>{value}",
        text_template="Metadata: {metadata_str}\n-----\nContent: {content}",
    )
    document.id_ = row[doc_id_col]
    documents.append(document)

llm = OpenAI(temperature=0.1, model="gpt-3.5-turbo-16k")
metadata_extractor = MetadataExtractor(
    extractors=[KeywordExtractor(keywords=10, llm=llm),
    ],
)
node_parser = SimpleNodeParser.from_defaults(metadata_extractor=metadata_extractor, include_metadata=True, callback_manager=callback_manager)
nodes = node_parser.get_nodes_from_documents(documents, show_progress=True)

Relevant Logs/Tracbacks
No response

Is there any other information printed to the console? Or it just straight up crashes?

Just to confirm, you tried running a python file with the code directly?

@logan-markewich , it just crashes. In Pycharm I'm running the code directly in the console, not Jupyter.
Below is JupyterKernelCrash log from VS Code. Pycharm just gave me exit code -1073741571 (0xC00000FD).
Visual Studio Code - Insiders (1.82.0-insider, undefined, desktop)
Jupyter Extension Version: 2023.7.1002162226.
Python Extension Version: 2023.14.0.
Platform: win32 (x64).
Workspace folder ~\Desktop\VS_Code_Projects\BRICS\brics-tools, Home = c:\Users\armengolkm
15:02:54.539 [info] User belongs to experiment group 'FastKernelPicker'
15:02:54.539 [info] User belongs to experiment group 'NewRemoteUriStorage'
15:02:54.539 [info] User belongs to experiment group 'PasswordManager'
15:02:54.539 [info] User belongs to experiment group 'NewJupyterSession'
15:02:56.233 [info] Start refreshing Kernel Picker<PHONE_NUMBER>233)
15:02:56.249 [info] Using Pylance
15:02:59.527 [info] Starting Kernel startUsingPythonInterpreter, .jvsc74a57bd05196cd751021d6cca4d123eb88a71ebd2a0de9adefb82ede204f0985d1c46689.c:\Users<username>\Desktop\VS_Code_Projects\BRICS\brics-tools.venv\Scripts\python.exe.c:\Users<username>\Desktop\VS_Code_Projects\BRICS\brics-tools.venv\Scripts\python.exe.-m#ipykernel_launcher  (Python Path: ~\Desktop\VS_Code_Projects\BRICS\brics-tools.venv\Scripts\python.exe, Poetry, .venv, 3.10.2) for '~\Desktop\VS_Code_Projects\BRICS\brics-tools\examples\data_repository\study_semantic_search.ipynb' (disableUI=true)
15:03:12.688 [info] Start refreshing Interpreter Kernel Picker
15:03:16.093 [info] Process Execution: ~\Desktop\VS_Code_Projects\BRICS\brics-tools.venv\Scripts\python.exe -m pip list
15:03:16.654 [info] Process Execution: ~\Desktop\VS_Code_Projects\BRICS\brics-tools.venv\Scripts\python.exe -c "import ipykernel; print(ipykernel.version); print("5dc3a68c-e34e-4080-9c3e-2a532b2ccb4d"); print(ipykernel.file)"
15:03:21.058 [warn] Failed to get activated env vars for ~\AppData\Local\Programs\Python\Python311\python.exe in 4399ms
15:03:21.586 [info] Process Execution: ~\AppData\Local\Programs\Python\Python311\python.exe -c "import site;print("USER_BASE_VALUE");print(site.USER_SITE);print("USER_BASE_VALUE");"
15:03:24.085 [info] Process Execution: ~\AppData\Local\Programs\Python\Python311\python.exe c:\Users<username>.vscode-insiders\extensions\ms-toolsai.jupyter-2023.7.1002162226-win32-x64\pythonFiles\vscode_datascience_helpers\kernel_interrupt_daemon.py --ppid 2852
> cwd: ~.vscode-insiders\extensions\ms-toolsai.jupyter-2023.7.1002162226-win32-x64\pythonFiles\vscode_datascience_helpers
15:03:25.540 [info] ipykernel version & path 6.25.1, ~\Desktop\VS_Code_Projects\BRICS\brics-tools.venv\lib\site-packages\ipykernel_init_.py for ~\Desktop\VS_Code_Projects\BRICS\brics-tools.venv\Scripts\python.exe
15:03:27.089 [info] Process Execution: ~\Desktop\VS_Code_Projects\BRICS\brics-tools.venv\Scripts\python.exe -m ipykernel_launcher --ip=<IP_ADDRESS> --stdin=9003 --control=9001 --hb=9000 --Session.signature_scheme="hmac-sha256" --Session.key=b"a02be18d-3f69-44c5-a15c-6439cdef1cae" --shell=9002 --transport="tcp" --iopub=9004 --f=c:\Users<username>\AppData\Roaming\jupyter\runtime\kernel-v2-28527T0hV6Bhmbbu.json
> cwd: ~\Desktop\VS_Code_Projects\BRICS\brics-tools\examples\data_repository
15:03:42.042 [warn] StdErr from Kernel Process c:\Users<username>\Desktop\VS_Code_Projects\BRICS\brics-tools.venv\lib\site-packages\traitlets\traitlets.py:2548: FutureWarning: Supporting extra quotes around strings is deprecated in traitlets 5.0. You can use 'hmac-sha256' instead of '"hmac-sha256"' if you require traitlets >=5.
warn(
15:03:42.043 [warn] StdErr from Kernel Process c:\Users<username>\Desktop\VS_Code_Projects\BRICS\brics-tools.venv\lib\site-packages\traitlets\traitlets.py:2499: FutureWarning: Supporting extra quotes around Bytes is deprecated in traitlets 5.0. Use 'a02be18d-3f69-44c5-a15c-6439cdef1cae' instead of 'b"a02be18d-3f69-44c5-a15c-6439cdef1cae"'.
warn(
15:03:59.051 [info] End refreshing Kernel Picker<PHONE_NUMBER>233)

Can you open a regular terminal (no pycharm/vscode/jupyter) and just run the code like python file_name.py ?

@logan-markewich , no luck. i'll be debugging some more tomorrow morning and will let you know if I get anywhere.

@logan-markewich, so I finally got the KeywordExtractor() to proceed by excluding metadata as below:

llm = OpenAI(temperature=0.1, model=llm_model_name)

service_context = ServiceContext.from_defaults(llm=llm, context_window = 4096)

text_splitter = TokenTextSplitter(
  separator=" ",
  chunk_size=2048,
  chunk_overlap=20,
  backup_separators=["\n"],
  tokenizer=tiktoken.encoding_for_model(llm_model_name).encode
)

metadata_extractor = MetadataExtractor(
    extractors=[KeywordExtractor(keywords=10, llm=llm)],)

node_parser = SimpleNodeParser(
    text_splitter=text_splitter,
    include_metadata=False,
    metadata_extractor=metadata_extractor,
)

I'm not sure if it had to do something with the metadata string's text, but I didn't need it for extracting keywords with an llm at this step. Running doc.get_content(metadata_mode=MetadataMode.LLM)
Metadata: title=>Transforming Research and Clinical Knowledge in Traumatic Brain Injury (TRACK-TBI) - Adult::studyType=>Epidemiology::fundingSource=>NIH-NINDS::keywordSet=>[]::submissionType=>['Imaging', 'Genomics', 'Clinical Assessment']::goals=>Specific Aim 1: To create a widely accessible, comprehensive TBI Information Commons that integrates clinical, imaging, proteomic, genomic, and outcome biomarkers from subjects across the age and injury spectra, and provides analytic tools and resources to support TBI research.

Specific Aim 2: To validate imaging, proteomic, and genetic biomarkers that will improve classification of TBI, permit appropriate selection and stratification of patients for clinical trials, and contribute to the development of a new taxonomy for TBI. We hypothesize that validated imaging, proteomic, and genetic biomarkers will
permit improved patient classification, beyond traditional categories of mild, moderate and severe TBI.

Specific Aim 3: To evaluate a flexible outcome assessment battery in adult patients comprising a broad range of TBI‐CDEs that enables assessment of multiple outcome domains across all phases of recovery and at all levels of TBI severity.

Specific Aim 4: To determine which tests, treatments, and services are effective and appropriate for which TBI patients, and use this evidence to recommend practices that offer the best value.  ::numberOfSubjects=>3000.0::fundingAmount=>nan
-----
Content: Effective treatment of traumatic brain injury (TBI) remains one of the greatest unmet needs in public health. Each year in the US, at least 1.7 million people suffer TBI; an estimated 3.2 to 5.3 million people live with the long-term physical, cognitive, and psychological health disabilities of TBI, with annual direct and indirect costs estimated at over $60 billion. The unique public-private partnership of investigators, philanthropy, and industry leaders brought together in the multicenter Transforming Research and Clinical Knowledge in Traumatic Brain Injury (TRACK-TBI) proposal share a mission to accelerate clinical research in TBI. The goal is to create a large, high quality TBI database that integrates clinical, imaging, proteomic, genomic, and outcome biomarkers, and provides analytic tools and resources to establish more precise methods for TBI diagnosis and prognosis, improve outcome assessment, and compare the effectiveness and costs of tests, treatments, and services. The investigators hypothesize that this approach will permit better characterization and stratification of patients, allowing meaningful comparisons of treatments and outcomes, and thereby improving the next generation of clinical trials.
Specific Aim 1. To create a widely accessible, comprehensive TBI Information Commons that integrates clinical, imaging, proteomic, genomic, and outcome biomarkers from subjects across the age and injury spectra, and provides analytic tools and resources to support TBI research.
Specific Aim 2. To validate imaging, proteomic, and genetic biomarkers that will improve classification of TBI, permit appropriate choice and stratification of patients for clinical trials, and contribute to the development of a new taxonomy for TBI.
Specific Aim 3. To evaluate a flexible outcome assessment battery comprised of a broad range of TBI common data elements that enables assessment of multiple outcome domains across all phases of recovery and at all levels of TBI severity.
Specific Aim 4. To determine which tests, treatments, and services are effective and appropriate for which TBI patients, and use this evidence to recommend practices that offer the best value.
The project will directly impact public health by creating an open-access Information Commons populated with robust Common Data Elements that will make international research collaboration a reality. Detailed clinical data on 3,000 subjects (11 sites) across the injury spectrum, along with CT/MRI imaging, blood biospecimens, and detailed outcomes, will be collected and analyzed, permitting the identification/validation of biomarkers, and identification of structural abnormalities that may be predictive of outcomes, making strides toward a new taxonomy for TBI. The infrastructure of integrated databases and imaging and biosample repositories will create a high quality, legacy database for current and future generations of international researchers.

This is fixed as metadata extractors now have an option to pick which metadata to include
KeywordExtractor(..., metadata_mode=MetadataMode.NONE)


Use base 2 exponential histograms in BigQuerySinkMetrics

Use base 2 exponential histograms in BigQuerySinkMetrics. This shows better performance on load tests either because the bucket index computation is faster or because there are fewer buckets to send to DFE.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @m-trieu

Run Java_GCP_IO_Direct PreCommit


Replace Visual Basic token

For #4801

In general, for PRs that touch a large number of files, could you split the work into several PRs so that they'll be easier for us to review?

Sure, I'll do that for the remaining ones


CMake GLOB_RECURSE problem

After #50 all libraries are glued together now due to file(GLOG_RECURSE ...) three times
Now graph_headers, layers_headers, perf_headers are the same

@aobolensk

Something like this will fix this
file(GLOB_RECURSE graph_headers graph/*.h graph/*.hpp)
set(GRAPH_HEADERS "${graph_headers}" PARENT_SCOPE)

file(GLOB_RECURSE layers_headers layers/*.h layers/*.hpp)
set(LAYERS_HEADERS "${layers_headers}" PARENT_SCOPE)

file(GLOB_RECURSE perf_headers perf/*.h perf/*.hpp)
set(PERF_HEADERS "${perf_headers}" PARENT_SCOPE)

I agree, this fix is valid. Feel free to submit a PR


FrostedGlass doesnt work

Simply put, it doesnt make my discord transparent, it makes it dark gray. I dont know how to fix that, please send help.

Make sure the Transparency Option is enabled in BetterDiscord settings. If not, enable it, close Discord and open it again.

Yeah, background image is gray... I tryed to set a computer file and it doesn't work

That's url's not working:
https://discordstyles.github.io/RadialStatus/base.css
https://discordstyles.github.io/FrostedGlass/base.css

I don't know what they did... But I was working and changing some stuff when suddenly the background stopped being shown.
I can't really see the lines they changed or if it's just some bug or someone forgot to add something.

All my themes got a structure change meaning the base.css file doesn't exist anymore.
All you have to do is just change the end of the url from base.css to dist/[ThemeName].css.
Example with Frosted Glass:

All my themes got a structure change meaning the base.css file doesn't exist anymore.
All you have to do is just change the end of the url from base.css to dist/[ThemeName].css.
Example with Frosted Glass:

wow! it work! thx

Fixed it, thanks!

that was a pretty weirdchamp change

All my themes got a structure change meaning the base.css file doesn't exist anymore.
All you have to do is just change the end of the url from base.css to dist/[ThemeName].css.
Example with Frosted Glass:

I changed the import url but frostedglass still doesn't work for me

All my themes got a structure change meaning the base.css file doesn't exist anymore.
All you have to do is just change the end of the url from base.css to dist/[ThemeName].css.
Example with Frosted Glass:

I changed the import url but frostedglass still doesn't work for me

same..

Here's the newest theme file.
Just look how that does it.

The fix works but horizontal server list broke

Do the exact same thing but do "HorizontalServerList" instead of "FrostedGlass"

i did everything but im still not able to change theme or how blury it is

Just use this: https://gibbu.me/editor.
It's a tool that I made to help edit themes.


Array access in templates

Hello, great extension!
{{enum-t model attribute changes.[1]}}
{{!-- gets formatted into --}}
{{enum-t model attribute changes.1}}

Which then causes a template compiler error... Any hints?
Also, I'm trying to run prettier in the whole directory with prettier --write app/**/*.hbs and I would like to apply all of this vscode extension prettier options, what's are them? I'm not really used to config prettier, but... I copied what you mainly had over src/extension.ts { parser: glimmer, printWidth: 120 } not sure what else I need because I noticed that when I manually format a template with this extension i.e CMD + P + format..., my unnecessary new lines gets removed (which I like), but this is not happening when running the prettier command which reads from my .prettierrc
module.exports = {
  tabWidth: 2,
  useTabs: false,
  semi: true,
  singleQuote: true,
  quoteProps: 'as-needed',
  trailingComma: 'none',
  bracketSpacing: true,
  arrowParens: 'avoid',
  proseWrap: 'preserve',
  printWidth: 100,
  overrides: [
    {
      files: '*.hbs',
      options: {
        parser: 'glimmer',
        singleQuote: false,
        printWidth: 120
      }
    }
  ]
};

Hey @betocantu93 Sorry for the late response.
You have to pin your Prettier version to the same one used by this extension, at this time 1.18.2.
Prettier changes frequently between releases.
Also this extension doesn't handle singleQuote false :)

Also @betocantu93 regarding {{enum-t model attribute changes.[1]}}
This isn't "valid" syntax. It works but shouldn't be relied upon. I recommend using the get helper or the object-at helper from Ember Composable Helpers.

Thanks @Alonski will reopen if something shows up


Setup LITL pipeline for issues with respect to manifestation links to KBR publishers

The data issues kbr1 and kbr2 concern book translations which could not be linked to a KBR authority records because we either only have a publisher name which wasn't found in the KBR data or a publisher name with multiple matches in the KBR authority data.
The issues can be detected using Python scripts which process the output of the linking and deduplication pre-processing steps for KBR data.
Afterwards, the root cause should be identified by a human, before a human can fix the issue and document the corrected data (in such a way it can be used to take the corrections and root cause into account)

By simply writing a log during the existing KBR publisher deduplication step I get the following numbers:

multiple matches 199 (NL dump), 413 (FR dump)
no matches 531 (NL dump), 783 (FR dump)

However, these are not unique publishers, but the number of book translations which have a publisher with multiple matches or no matches in the KBR authority records.
Additionally, these are any publishers from the export and not necessarily ones relevant for the BELTRANS corpus. There would be also additional work in obtaining enough information from the KBR authorities dump for a human to make a decision (e.g. given the name of a publisher and showing different data fields of possible candidates).
To simplify the processing steps it would be easier to load the roughly 100k organization records including metadata into the triple store. Additionally, I can map the information which self-made publisher record has which KBR publisher ID as potential candidate as part of the regular KBR ETL pipeline.
Then, the identification of relevant publisher names with multiple KBR candidates or no candidates can happen via a single SPARQL query instead of several scripts.


ElastoDyn - Tower Modes

Hello,
Should be a quick question. I'm using an OC3 monopile offshore example as a template for a similar turbine I'm trying to study. In *_ElastoDyn_Tower.dat files, it appears the domain of the polynomial coefficients is 0-1, how does this domain map to physical space? Is 0 at the tower base? In reality, I would have thought there would be some displacement in the mode shape at the tower base because the foundation has a stiffness, so why are there no constant terms (and linear term)?
I've struggled to use BModes because I think the OC3Hywind.bmi input file I have is out of the date for the version I have installed. Therefore, I've decided to calculate the modal displacements using some other software which I'm more familiar with and I'm resolving everything down to the mudline (-30m) where I'm going to fix it (pinned) for simplicity. The interface is at 20m. Can I just take X as an array between [z_interface, z_towertop] and Y the corresponding displacements and plug them into the polynomial coefficient calculator spreadsheet I saw in the Fast_v8 archive?
I'd appreciate any wisdom you have to help me understand this better!
Many thanks,
Sam

Hi Sam (@sr3114),
I'm familiar with your question.  Similar questions have been discussed thoroughly on our user forum, e.g., see my post dated Apr 10, 2012 in the following forum topic: https://wind.nrel.gov/forum/wind/viewtopic.php?f=3&t=607.  NREL has provided the OC3Hywind.bmi input file along with a compatible version of BModes (called "BModes_JJ" on the forum) here: https://wind.nrel.gov/public/jjonkman/BModes/.
Best regards,

Thanks Jason, I'll give this ago.
Best wishes,
Sam

I find that when I use the improved direct method coefficients rather than direct method coefficients, the solution blows up - generally a Mach number error somewhere on the blades. I noticed that in the OC3 Offshore monopile the coefficients are similar to mine when I used direct method coefficients. Is there a reason to use one over the other?
Best wishes,
Sam

The slack channel notified me that a comment was posted on this issue, but I don't see it in the issue.  @sr3114 , did you post then remove a comment?

@andrew-platt I posted earlier before realising I had made an input error.

你好萨姆(@sr 3114)，
我很熟悉你的问题。类似的问题已经在我们的用户论坛上进行了彻底的讨论，例如，见我2012年4月10日在以下论坛主题中的帖子：Https://wind.nrel.gov/forum/wind/viewtopic.php?f=3&t=607。NREL在论坛上提供了OC3HyWind.bmi输入文件以及兼容版本的BModes(在论坛上称为“BModes_JJ”)：Https://wind.nrel.gov/public/jjonkman/BModes/.
诚挚的问候,

你好萨姆(@sr 3114)，
我很熟悉你的问题。类似的问题已经在我们的用户论坛上进行了彻底的讨论，例如，见我2012年4月10日在以下论坛主题中的帖子：Https://wind.nrel.gov/forum/wind/viewtopic.php?f=3&t=607。NREL在论坛上提供了OC3HyWind.bmi输入文件以及兼容版本的BModes(在论坛上称为“BModes_JJ”)：Https://wind.nrel.gov/public/jjonkman/BModes/.
诚挚的问候,


Fix typo in react-bugsnag Readme

Description
Fixes a tiny typo in the @shopify/react-bugsnag readme
Bugsang -> Bugsnag

@JonathanGin52 The build is failing with:

WARNING: docs/index.md and README.md no longer have identical content. Please correct this.

Can you also update docs/index.md?

@JonathanGin52 The build is failing with:

WARNING: docs/index.md and README.md no longer have identical content. Please correct this.

Can you also update docs/index.md?

The build looks like it's for a different PR / repo. Can you confirm that it is for this PR?

@JonathanGin52 Ah, right.... It's stuck at:


🐛 [firebase_remote_config] MissingPluginException

I am seeing the following error when trying to integrate with RemoteConfig:
I/flutter ( 4844): MissingPluginException(No implementation found for method RemoteConfig#instance on channel plugins.flutter.io/firebase_remote_config)

E/flutter ( 4844): [ERROR:flutter/lib/ui/ui_dart_state.cc(177)] Unhandled Exception: Unhandled error MissingPluginException(No implementation found for method RemoteConfig#instance on channel plugins.flutter.io/firebase_remote_config) occurred in Instance of 'RemoteConfigBloc'.

I recently upgraded to Android Embedding v2 following the instructions at https://firebase.flutter.dev/docs/migration/. This had me remove my custom MainActivity.kt class, and the flutter fire registrations with it.
Output of flutter doctor -v:
[✓] Flutter (Channel stable, 1.22.4, on Mac OS X 10.15.7 19H2 darwin-x64, locale en)
    • Flutter version 1.22.4 at /Users/br/development/flutter
    • Framework revision 1aafb3a8b9 (2 weeks ago), 2020-11-13 09:59:28 -0800
    • Engine revision 2c956a31c0
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/br/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.2, Build version 12B45b
    • CocoaPods version 1.9.1

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] IntelliJ IDEA Community Edition (version 2019.3.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 41.0.4
    • Dart plugin version 192.7402

[✓] VS Code (version 1.45.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.10.2

[✓] Connected device (1 available)
    • Android SDK built for x86 (mobile) • emulator-5554 • android-x86 • Android 10 (API 29) (emulator)

! Doctor found issues in 1 category.

Hi @barapa
Does the plugin work for you on a fresh project?
Thank you


Add build pipeline using electron-builder

This PR creates a build pipeline for electron builds on Ubuntu, MacOS, and Windows. It is favored over the existing usage of astilectron because it will simplify development in the long term such as variable imports (e.g. electronScreen.getPrimaryDisplay().workAreaSize vs implementing in go), auto updating, and a more standardized pipeline that can get better community support.
Artifacts are pushed to Github for now and can be downloaded from the Actions tab.
Outstanding issues:

[ ] Fix loading monaco editor
[x] Detection of kubeconfig and other environment variables
[ ] Allow navigation to use space currently occupied by header as the logo in the top left is no longer necessary
[ ] Design what an electron menu might contain via Menu.setApplicationMenu

Signed-off-by: GuessWhoSamFoo<EMAIL_ADDRESS>Co-authored-by: Wayne Witzel III<EMAIL_ADDRESS>

After talking yesterday, I changed my mind, lol. Let's put all the fixes for build-electron in this PR. Local building and the action should work after this merges.

Closing in favor of an upstream branch for multiple PR authors


generated_password file not exist after master init

Docklet don't create generated_password file, and the default password of root has been written in code.

#181 Done


[Bug] The template folder does not exist

Thank you Stefano,
Templates are here: https://github.com/gapmiss/livecodes-for-obsidian/tree/master/templates
I will fix the README to reflect this correct URL.