requestOptions.auth isn't saved in sessionStorage when using a function

Bug Report
Describe the Bug
I had the same problem described in #928. So I used its solution, setting requestOptions.auth in server configs as a function, to be called by getAuthorizationHeader() to get authorization headers.
The problem is that when the app starts it calls addServers, which call the dispatch function in redux:
addServers.js
const addServers = (servers, store) => {
  if (!servers || !store) {
    throw new Error('The servers and store must be defined');
  }

  Object.keys(servers).forEach(serverType => {
    const endpoints = servers[serverType];
    endpoints.forEach(endpoint => {
      const server = Object.assign({}, endpoint);
      server.type = serverType;

      store.dispatch({
        type: 'ADD_SERVER',
        server,
      });
    });
  });
};

But before save it, redux uses JSON.Stringify to convert to string and the stringify function ignores functions in the object, so the requestOptions ends up without auth key:
sessionStorage.js
export const saveState = state => {
  try {
    const serializedState = JSON.stringify(state);
    SessionStorageApi.setItem(sessionStorageKey, serializedState);
  } catch (e) {}
};

So, my config file is as shown below:
servers: {
    dicomWeb: [
      {
        name: 'DCM4CHEE',
        ...
        requestOptions: {
          auth: () => {
            return 'token';
          },
        },
      },
    ],
  },

But the config saved in sessionStorage is:
servers: {
    dicomWeb: [
      {
        active: true
        name: 'DCM4CHEE',
        ...
        requestOptions: {
        },
      },
    ],
  },

any method after this call the config in the sessionStorage, which does not have the auth function.
What would be the best approach to solve it?
I thought as a workaround I call the auth method before the app call addServers and update requestOptions.auth to have the token before saving it into the storage. But this is not even close to the best approach

I thought as a workaround I call the auth method before the app call addServers and update requestOptions.auth to have the token before saving it into the storage. But this is not even close to the best approach

Would it make sense to take that approach and bake it into addServers?
const addServers = (servers, store) => {
  if (!servers || !store) {
    throw new Error('The servers and store must be defined');
  }

  Object.keys(servers).forEach(serverType => {
    const endpoints = servers[serverType];
    endpoints.forEach(endpoint => {
      const server = Object.assign({}, endpoint);
      server.type = serverType;

      // Call auth function before saving to session storage
      if (server.requestOptions && server.requestOptions.auth && typeof server.requestOptions.auth === "function") {
        server.requestOptions.auth = server.requestOptions.auth(server.requestOptions)
      }

      store.dispatch({
        type: 'ADD_SERVER',
        server,
      });
    });
  });
};

I think this is a good workaround initially, but this creates some edge cases, i.e. what if the token generated has a time to live and need to be updated? I still don't have the answer to this question.

Ideally, you're using an authentication workflow that our oidc settings support. This allows for things like timeouts, refresh tokens, etc.
We can discuss pulling "authentication" configuration and lifecycle out of @ohif/viewer and into @ohif/core, then exposing those hooks with @ohif/viewer's application configuration. Most clientside auth isn't a "forever valid" token, so hooks to address common situations would be a nice value add.
What are the situations we should support? Where would you expect there to be hooks?

Thank you for your past contributions and for raising this issue related to legacy versions of our OHIF Viewer. Your time and effort have been invaluable in helping us improve the product.
We wanted to update you that our development focus has shifted to OHIF Viewer v3, which is now available for testing on viewer-dev.ohif.org. This site is deployed from our master branch and incorporates new features, optimizations, and bug fixes. If you're still using viewer.ohif.org, it's worth noting that this is deployed from our release branch and may not have the latest updates. You can read more about our branching strategies here.
Given the move to Version 3, we are closing older issues that pertain to Versions 1 and 2, as we are no longer providing support for those versions. If you find that the issue you've raised is still relevant in Version 3, we encourage you to reopen this issue or create a new one for proper triage.
Thank you for your understanding and continued support.


graphql should be a peerDependency

https://github.com/avantcredit/gql2ts/blob/master/packages/util/package.json#L31
This is causing a second version of graphql to be installed in my project. (which doesn't work)

@ecwyne why is it causing a second version to be installed? what version are you using?
i made the version range more inclusive yesterday w/ 1.4.4, can you make sure you have that version installed?

I had 1.5.0 installed. The ranged version (>= 0.10 <1.0.0) included my installed version (0.12.3) but installing @gql2ts/from-schema installed a separate version.
I have since discovered your cli package and am using that (which avoids installing @gql2ts/* in my project at all)

Because there can only be one version of graphql installed, peerDependencies seems to be the way everyone is specifying a dependency on graphql (though several also have it as a devDependency (for testing)
https://github.com/graphql/express-graphql/blob/master/package.json#L96
https://github.com/mickhansen/graphql-sequelize/blob/master/package.json#L50
https://github.com/apollographql/graphql-tools/blob/master/package.json#L58
https://github.com/apollographql/graphql-tag/blob/master/package.json#L34
https://github.com/apollographql/graphql-subscriptions/blob/master/package.json#L14

makes sense, i'll open a PR moving it to a peer dependency

@ecwyne 1.5.1 has it as a peer dependency


Add support for making nanobind classes weak-referenceable.

Adds an optional nb::weak_referenceable attribute. If present, we allow space for a weak reference list in the object and set tp_weaklistoffset.
This change incorporates the changes from https://github.com/wjakob/nanobind/pull/99

Thanks for this nice set of patches @hawkinsp. Before merging, I have one more request for a testcase with a more complex configuration: A type that is weak-referencable and has a per-instance dictionary (to make sure the layout is correct). A variation of that test could subclass the type in Python, deposit a value in the dictionary, and then test weak-referenceability.

Could you add a variation of that test that works as before, but which subclasses your test classes from within Python?  Extending C++ types from Python involves some extra complexity (nb_type_init) that would be good to test here as well. It should be as simply as writing
class MyStructWithWeakrefs(t.StructWithWeakrefs):
    pass
class MyStructWithWeakrefsAndDynamicAttrs(t.StructWithWeakrefsAndDynamicAttrs):
    pass

and then adjusting the rest of your existing test with those types.
Also: in the test, instead of assigning the int value 101 to the dynamic attributes dict, could you instead use t.Struct(101) and read the attribute using assert p.a_dynamic_attr.value() = 101? That way, nanobind's leak checker will be active on top of all the other checks.

It seems that there is something specific about this test that PyPy does not like. It's possible that there might be a bug in the PyPy CPython emulation (would not have been the first). On the other hand types are always weak-referenceable in pybind11, and the test suite passes there with PyPy. Not sure.

Hi @hawkinsp  -- any news on this change?

Hi @hawkinsp -- I have not heard back and will close the PR for now. If you change your mind, please @-mention me here and I will reopen it.

Yeah sorry I ran out of time to look at the failing tests. Closing the PR is the right action for now.


Update the release binary

Can you please update the binary to the latest commit. I don't know how to install go projects from the source itself and install it.


Socket.set*Timeout does not work

Given this code:
ReqSocket socket = new ReqSocket();
socket.setRecvTimeout(2000);
socket.connect("tcp://localhost:5555");
socket.send("Something");
socket.recvString();

I would expect the socket.recvString(); to timeout after 2 seconds (assuming there is nothing listening on localhost:5555). Instead it blocks forever.
It seems that the underlying code..
NativeLibrary.nn_setsockopt(socket, Nanomsg.constants.NN_SOL_SOCKET,
                                Nanomsg.constants.NN_RCVTIMEO, newSizeT(milis), Native.SIZE_T_SIZE);

Does not work as it passes a long, nanomsg expects an int for NN_RCVTIMEO. I have confirmed this with this c code which fails:
long timeout = 2000;
assert( nn_setsockopt (sock, NN_SOL_SOCKET, NN_RCVTIMEO, &timeout, sizeof(timeout)) >=0 );

This works:
int timeout = 2000;
assert( nn_setsockopt (sock, NN_SOL_SOCKET, NN_RCVTIMEO, &timeout, sizeof(timeout)) >=0 );

I am not familiar with jna, but this seems to work:
IntByReference receiveTimeout = new IntByReference(2000);
    NativeLibrary.nn_setsockopt(socket, Nanomsg.constants.NN_SOL_SOCKET, Nanomsg.constants.NN_RCVTIMEO, receiveTimeout.getPointer(), 4);

Thanks

That should be fixed in the last version.
Thanks to both!


WARNINGS due to errors on permission denied during installation to SERVER?

Hallo,
I receive the following WARNINGS when I enter the web address to execute the application via  the Web Browser.
http://localhost/usbong_gameoff/index.php/flashStage

Warning: mkdir(): Permission denied in /opt/lampp/htdocs/usbong_gameoff/system/core/Log.php on line 131

Warning: include(/opt/lampp/htdocs/usbong_gameoff/application/views/errors/html/error_php.php): failed to open stream: No such file or directory in /opt/lampp/htdocs/usbong_gameoff/system/core/Exceptions.php on line 268

Warning: include(): Failed opening '/opt/lampp/htdocs/usbong_gameoff/application/views/errors/html/error_php.php' for inclusion (include_path='.:/opt/lampp/lib/php') in /opt/lampp/htdocs/usbong_gameoff/system/core/Exceptions.php on line 268

Additional Notes:

Operating System (OS): Linux Ubuntu (LUBUNTU)
OUTPUT is after downloading and installing the ZIP file from GITHUB to the COMPUTER SERVER.

What is your recommended solution?
Thank you.

Hallo,
The "application" folder should also be writable by user classified as OTHER;
--> where: OTHER : NOT OWNER, NOT GROUP MEMBER
/opt/lampp/htdocs/usbong_gameoff/application/
COMMANDS:
cd /opt/lampp/htdocs/usbong_gameoff/
chmod -R 777 application/
INPUT:
drwxrwxr-x 5 unit_member unit_member  4096 Nov  5 11:38 application
OUTPUT:
drwxrwxrwx 6 unit_member unit_member  4096 Nov  5 11:54 application
Health!
p.s. notes: ELAPSED TIME: 16mins


[Core] Add debug file to config options

Hi,
Since it's possible to do custom bridges, whitelists and config.ini's, I think it makes sense to also add the debug functionality as described here.
This change just adds "DEBUG" as an option to the things you can configure using the mounted config folder.

Woops... branch was borked. will fix and start another one.


Fix potential exception when calling FinishTransforms results in child changes

As seen at https://sentry.ppy.sh/share/issue/8d469f0003bd446eb4bda7865b2e9bc9/.
Can probably figure out a repro case if test coverage is seen as beneficial, but it's obvious how this could happen (and the inline comment should guard against regression).

Am I right in that the "obvious" case for how this can happen is x.Transform().OnComplete(t => t.Expire());? Or am I missing a simpler case?

Yep, something like that. Any OnComplete or OnAbort or Schedule that causes a removal of drawables in some way.

I find this sort of usage of transforms extremely dodgy if that is the case, and am also confused as to why it wouldn't happen every time. I think I'll turn a blind eye but I don't agree with allowing this...

If you take a look at the linked example on sentry, the specific case is a high level component calling FinishTransforms on the full fail overlay, which in turn does some clean-up:
https://github.com/ppy/osu/blob/f8830c6850128456266c82de83273204f8b74ac0/osu.Game/Screens/Play/FailAnimation.cs#L121-L122

Yeah, but you have to understand how this is dodgy right? We're just blanket skipping over Drawables so now you potentially have to call FinishTransforms() multiple times to ensure that transforms are actually finished.

I see what you mean. Probably need a safer enumerator helper method for these cases which reverses or re-runs or something.
Probably worth opening an issue tracking, since as you say it'll probably cause weirdness that we will never know how to track.


Update LICENSE year

Should be better write 2015-2021?

Thank you!

Should be better write 2015-2021?

Meanwhile that makes sense ...
I'm not sure if noting the years is needed at all.

Thank you!

Should be better write 2015-2021?

Meanwhile that makes sense ...
I'm not sure if noting the years is needed at all.


[Suggestion] Flathub

It would be really awesome if this project was published on Flathub, even as a command line tool, to allow more people to use it with ease.
If required, I could try helping getting this done!

Thanks for the suggestion! I had actually started looking into this back around this past December but didn't have the time to take care of it.
Now, unless this has changed since the last time I messed around with it (2 or 3 years ago iirc), Flatpak packaging only supports applications with GUIs, so I would need to add one to this project. Tauri with Svelte as the UI would be ideal since I am very comfortable with Svelte and the UI should stay pretty consistent on all supported OSes. Otherwise, Relm4 seems promising but is GTK-based, so it would look out of place on Windows and macOS.
My day job work is pretty light this week, so I'm going to try to get this done. I hope to at least have a workable GUI by the end of this week. I'll let you know here if I think I could use any help.

A Tauri-based UI would be awesome! If you manage  to create one, you can then leave the Flatpak packaging process on me, I'll open up a PR!

Additionally, if/when you make the UI, I suggest you slightly refractor the code so as to be more modular in supporting translations, since now the outputs are hard-coded in English, which makes sense for a script, but not for a program with a user interface.


gui: use iterator insert for rtrees

@maliberty I don't see a particular drop in loading time, so I'm wondering if you see anything that could be further improved.

@maliberty this dropped the initial render time from ~19 seconds to 1.1 seconds for one of our designs


Aggregate PR

Aggregate of the following PRs:
https://github.com/wildfly/wildfly/pull/17995
https://github.com/wildfly/wildfly/pull/17565
https://github.com/wildfly/wildfly/pull/17923
https://github.com/wildfly/wildfly/pull/17984
https://github.com/wildfly/wildfly/pull/17988
https://github.com/wildfly/wildfly/pull/17994

<--- THIS SECTION IS AUTOMATICALLY GENERATED BY WILDFLY GITHUB BOT. ANY MANUAL CHANGES WILL BE LOST. --->

Wildfly issue links:

WFLY-19472
WFLY-11496
WFLY-19471
WFLY-19480
WFLY-18763
WFLY-19468
WFLY-19474
WFLY-18881

<--- END OF WILDFLY GITHUB BOT REPORT --->
More information about the wildfly-bot[bot]

All the linked PRs are merged.


YouTube videos redirect during linkcheck

And there are still warnings for youtube links:

Looks like a GDPR issue. I don't see redirects in the US.
We could add youtube to the list of ignored links, or just be aware of it. There is no open issue in Sphinx about GDPR compliance for linkcheck.
Alternatively we could embed the YouTube videos with https://github.com/sphinx-contrib/youtube, as suggested by https://github.com/executablebooks/sphinx-book-theme/issues/354#issuecomment-1046319108, which would remove the links.
Originally posted by @stevepiercy in https://github.com/plone/volto/issues/4181#issuecomment-1367878131

I would like to work on this issue

@SaiRev0 the @plone/documentation-team first needs to discuss and decide how to proceed. Once that decision is made, then you are welcome to work on it. @ksuess @polyester opinions?
Meanwhile, have you signed the Plone Contributor Agreement and been able to build the docs locally? See https://6.docs.plone.org/contributing/index.html for details. Thank you!

@stevepiercy I have filled and mailed the Agreement yesterday, but no response for it yet, and i have not setup it locally, so doing it now

@stevepiercy Can you please explain the issue and What I have to do, Its a bit unclear

I'm awaiting opinions of how to deal with this issue from the @plone/documentation-team. @polyester @ksuess I don't have enough experience with GDPR to have an informed opinion.

looks like sphinxcontrib-youtube has an easy way of setting the 'privacy mode which is a nice thing to do.
..  youtube:: dQw4w9WgXcQ
   :privacy_mode:

Nice. I also found the PR and noted that there is a Do Not Track mode for Vimeo, in case we need it.
https://github.com/sphinx-contrib/youtube/pull/30
```{eval-rst}
 .. vimeo:: 73214621
        :url_parameters: ?dnt=1
```

@SaiRev0 let's replace the links to the videos accordingly, and add this extension to Sphinx's conf.py and requirements-docs.txt. Then we can ask folks who are affected by the GDPR to check it.
This will also need to be applied to the main documentation repository.

I want to work on this issue please assign me this issue.

I would like to work on this issue, can you please tell me how to get started.

@MohdAnas07 @ShubhamKhati see my earlier comment.

Meanwhile, have you signed the Plone Contributor Agreement and been able to build the docs locally? See https://6.docs.plone.org/contributing/index.html for details. Thank you!

See also: https://github.com/plone/documentation/issues/1452 which will be incorporated into documentation soon by me.

@polyester would you please test this, now that https://github.com/plone/volto/pull/6486 was merged? Visit: https://volto--6486.org.readthedocs.build/tutorials/index.html

@ksuess @polyester I think this is now fixed. Can you run make linkcheckbroken to verify? Sorry, I don't have a VPN in the EU to test this out. Thank you!

@stevepiercy currently not in the EU as well

Running make docs-linkcheckbroken from Zurich,
on a freshly checked out https://github.com/plone/volto/   branch main,
I get the following:
% make docs-linkcheckbroken
Symlink to Volto news created or updated.
/Users/katjasuss/Volto/volto/lib/python3.12/site-packages/sphinx/builders/linkcheck.py:86: RemovedInSphinx80Warning: The default value for 'linkcheck_report_timeouts_as_broken' will change to False in Sphinx 8, meaning that request timeouts will be reported with a new 'timeout' status, instead of as 'broken'. This is intended to provide more detail as to the failure mode. See https://github.com/sphinx-doc/sphinx/issues/11868 for details.
  warnings.warn(deprecation_msg, RemovedInSphinx80Warning, stacklevel=1)
/Users/katjasuss/Volto/volto/docs/source/news/6482.documentation: WARNING: document isn't included in any toctree
/Users/katjasuss/Volto/volto/docs/source/news/6485.bugfix: WARNING: document isn't included in any toctree
/Users/katjasuss/Volto/volto/docs/source/news/6486.documentation: WARNING: document isn't included in any toctree
/Users/katjasuss/Volto/volto/docs/source/news/6487.bugfix: WARNING: document isn't included in any toctree
( tutorials/index: line   80) redirect  https://www.youtube.com/playlist?list=PLGN9BI-OAQkQmEqf6O8jeyoFY1b2hD1uL - with Found to https://consent.youtube.com/m?continue=https%3A%2F%2Fwww.youtube.com%2Fplaylist%3Flist%3DPLGN9BI-OAQkQmEqf6O8jeyoFY1b2hD1uL%26cbrd%3D1&gl=CH&m=0&pc=yt&cm=2&hl=de&src=1
( tutorials/index: line   74) redirect  https://www.youtube.com/playlist?list=PLGN9BI-OAQkQDLQinBwdEXpebDTQCwdGi - with Found to https://consent.youtube.com/m?continue=https%3A%2F%2Fwww.youtube.com%2Fplaylist%3Flist%3DPLGN9BI-OAQkQDLQinBwdEXpebDTQCwdGi%26cbrd%3D1&gl=CH&m=0&pc=yt&cm=2&hl=de&src=1
( tutorials/index: line   57) redirect  https://www.youtube.com/playlist?list=PLGN9BI-OAQkQxqQcCZeJefMC8XlA_qv3Z - with Found to https://consent.youtube.com/m?continue=https%3A%2F%2Fwww.youtube.com%2Fplaylist%3Flist%3DPLGN9BI-OAQkQxqQcCZeJefMC8XlA_qv3Z%26cbrd%3D1&gl=CH&m=0&pc=yt&cm=2&hl=de&src=1
( tutorials/index: line   75) redirect  https://www.youtube.com/playlist?list=PLGN9BI-OAQkTJPayNdKIZ8lLDm5RVOLV3 - with Found to https://consent.youtube.com/m?continue=https%3A%2F%2Fwww.youtube.com%2Fplaylist%3Flist%3DPLGN9BI-OAQkTJPayNdKIZ8lLDm5RVOLV3%26cbrd%3D1&gl=CH&m=0&pc=yt&cm=2&hl=de&src=1
make: *** [Makefile:119: docs-linkcheckbroken] Error 1

Can I test something else?

❯ make docs-linkcheckbroken
Symlink to Volto news created or updated.
/home/mahesh/volto/lib64/python3.10/site-packages/sphinx/builders/linkcheck.py:86: RemovedInSphinx80Warning: The default value for 'linkcheck_report_timeouts_as_broken' will change to False in Sphinx 8, meaning that request timeouts will be reported with a new 'timeout' status, instead of as 'broken'. This is intended to provide more detail as to the failure mode. See https://github.com/sphinx-doc/sphinx/issues/11868 for details.
warnings.warn(deprecation_msg, RemovedInSphinx80Warning, stacklevel=1)
/home/mahesh/volto/docs/source/news/6482.documentation: WARNING: document isn't included in any toctree
got this Running make docs-linkcheckbroken from Hyderabad

Can I test something else?

Oh, duh. My mistake, of course linkcheck won't check this directive, as there is no link for it to check.
```{youtube} kHec4MXH8vo
:privacy_mode:
:width: 100%
```

@ksuess, since you're in the EU, there are two things to check.

Check whether the result of viewing this rendered page results in a GDPR warning (or whatever cookie stuff gets thrown at EU residents). I just pushed this page to production so it has the new rendered directive.
https://6.docs.plone.org/volto/tutorials/index.html
Its iframe has this: src="https://www.youtube-nocookie.com/embed/kHec4MXH8vo".
The following earlier PR preview has the previous <iframe> version, for comparison:
https://plone6--1757.org.readthedocs.build/volto/tutorials/index.html

For this line:
( tutorials/index: line   80) redirect  https://www.youtube.com/playlist?list=PLGN9BI-OAQkQmEqf6O8jeyoFY1b2hD1uL - with Found to https://consent.youtube.com/m?continue=https%3A%2F%2Fwww.youtube.com%2Fplaylist%3Flist%3DPLGN9BI-OAQkQmEqf6O8jeyoFY1b2hD1uL%26cbrd%3D1&gl=CH&m=0&pc=yt&cm=2&hl=de&src=1

Can you edit the URL to:
https://www.youtube-nocookie.com/embed/playlist?list=PLGN9BI-OAQkQmEqf6O8jeyoFY1b2hD1uL

...and run linkcheck to see if that one still redirects? If this test works, then we can do a global find and replace. Otherwise we'll need to leave this ticket open. I'd prefer to find a different video host that does not profit from our personal information.

Thank you!

@kmahesh18 see https://6.docs.plone.org/volto/contributing/documentation.html#warnings-from-make-docs-commands.

I am not in the EU, but Switzerland. As I see the EU cookie consent popup when visiting youtube, it makes sense that I do the tests.

The embedded video is shown properly without any cookie dialog.

It's good to use the https://www.youtube-nocookie.com/embed/kHec4MXH8vo
Even better for privacy would be to use the https://www.youtube-nocookie.com/embed/VIDEO_ID?privacy_mode=1
Add the privacy_mode=1 parameter to the embed URL. This parameter further enhances privacy by ensuring YouTube doesn't store user information or track their activity while watching the embedded video.
See https://usercode.de/blog/how-to-embed-youtube-videos-with-maximum-privacy-gdpr-compliant#2-enable-privacy-mode
So this is the code to achieve it:

```{youtube} kHec4MXH8vo
:privacy_mode:
:url_parameters: ?privacy_mode=1
:width: 100%
```

@ksuess thanks for the thorough testing and PR!


Alphabetize common onnx ops for searchability

As title. No new content changes, only restructuring current ops -- proposed as new PR from discussion in #31.
Additional benefit of being easier to merge common code later on.

@jiafatom, gentle ping for feedback! :)

@jiafatom, gentle ping for feedback! :)

Have we done  this alphabetize also in onnxmltools?

Yes, see onnxmltools' current _apply_operation.pyand relevant updates in PR https://github.com/onnx/onnxmltools/pull/251.
I will port over the additional ops (i.e. affine, crop, scaledtanh etc. that are relevant to opset 10) from onnxmltools after restructuring PR has passed.


rosters and matchings

hey hey sorry I'd normally would put separate features into separate branches, but all the changes I'm doing for all of my assigned features needed to go together in one update (i.e. the db schema update and the updated check that everyone submitted prefs).
DB schema updated so please db migrate etc
Features

updated check for all users submitting preferences (all_submitted_preferences?) with edge cases (if no participants or no times set up, return a smart error) 🎉🎉
updated db schema to include Participant.last_responded -- nil by default, and a datetime when a participant has actually responded 🎉 please db migrate
redirected the roster button on the home page to go directly to the roster's edit page 🎉
updated roster view with a column for "Last Responded" for each participant - default is No response yet
added a button to randomly generate rankings on the roster's page 🎉🎉🎉
cuke tests for all the above features, we're still at 90%+ coverage 🎉🎉
updated one rspec lol

Cleaning

Updated paths.rb so as to clean up the step_definitions
Updated tests following the previous step for {rosters, times, see_matchings}.features

Note for everyone testing this: I had to run rake db:reset (pulls from schema.rb). db:migrate didn't help me change the DB correctly to add the column, probably because Joyce made the migrations to an existing migrations file, which rails thinks has already been run (or so I believe).

added a button to randomly generate rankings on the roster's page"

Sorry I can't seem to find this, where is it?

Sorry I can't seem to find this anywhere, did you remember to commit or did I miss it? It's not entirely necessary for this PR to go through, just nice to have

Homepage > Roster > Should be under "Actions" as a Generate Rankings button!

Sorry I can't seem to find this anywhere, did you remember to commit or did I miss it? It's not entirely necessary for this PR to go through, just nice to have

Homepage > Roster > Should be under "Actions" as a Generate Rankings button!

I can't seem to find it D:


sonar-scanner fails for PR (Travis-CI)

Everything passes and it fails on sonar-scanner, resulting in a negative overall result for PR.
Even for basic variable change PR #127 , sonar-scanner failed. There must be some issue with it.
This is the log from Travis-CI build.
The command "make" exited with 0.
0.11s$ sonar-scanner
sonar-scanner: command not found
The command "sonar-scanner" exited with 127.

Closing it as issue doesn't exists anymore.


Status line rendering broken with VIM 7.4 and CentOS 7

environment

vim: 7.4
vim-airline: 0.11
OS: CentOS 7
Have you reproduced with a minimal vimrc: Yes
What is your airline configuration:

set background=dark
call plug#begin()
Plug 'vim-airline/vim-airline'
Plug 'tpope/vim-fugitive'
call plug#end()
if you are using terminal:

terminal:
$TERM variable: xterm-256color
color configuration (:set t_Co?): t_Co=256

actual behavior
the status line display a default one.
expected behavior
the status line should be correct.
screen shot (if possible)

investigation:
The problem is pretty much like https://github.com/vim-airline/vim-airline/issues/2537.
When I open a file for the first time, the problem doesn't happen and the status line is correct.
When I go the bottom of the file(about 200 lines, more than one screen), the status line is broken.
I tried to debug and here is a discovery of the issue I am seeing:
line 19 of fugitiveline.vim(link), exists('*fugitive#repo') return false. when it goes to line 24, VIM resports that fugitive#buffer() does not exist error.
Please note: It seems that VIM 8 doesn't have such issue. exists('*fugitive#repo') return true as I test.
As tpope's advice, I open an issue here.
Thanks in advance!

hm, let me build a vim 7.4. What version exactly are you using please? Also, does it work, if you use:
let g:airline#extensions#fugitiveline#enabled=0

in your vimrc?

Hm, I see an error with the tagbar plugin. But this is caused by tagbar plugin. I tried to patch the tagbar plugin, but I believe the problem is a bug in vim, that an exception thrown in VimScript while evaluating the statusline causes the evaluation of the statusline to abort. I don't think there is anything vim-airline can do to fix this. For now I would disable the tagbar extension by using:
let g:airline#extensions#tagbar#enabled=0

hm, let me build a vim 7.4. What version exactly are you using please? Also, does it work, if you use:
let g:airline#extensions#fugitiveline#enabled=0

in your vimrc?

Version: VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Dec 15 2020 16:44:08)
Included patches: 1-207, 209-629
If I use
let g:airline#extensions#fugitiveline#enabled=0
in my .vimrc, everything goes well.

Hm, I see an error with the tagbar plugin. But this is caused by tagbar plugin. I tried to patch the tagbar plugin, but I believe the problem is a bug in vim, that an exception thrown in VimScript while evaluating the statusline causes the evaluation of the statusline to abort. I don't think there is anything vim-airline can do to fix this. For now I would disable the tagbar extension by using:
let g:airline#extensions#tagbar#enabled=0

Ok, If nothing can do to fix this, we can close this issue.

I did personally not see an error from fugitiveline. Can you please use: :set debug=msg and show me what error that plugin throws?

I did personally not see an error from fugitiveline. Can you please use: :set debug=msg and show me what error that plugin throws?

You are correct. Line 24 will report exception, but it should be caught because it's surrounded by try catch block as I tested.

I think I think we are seeing this bug here: https://github.com/vim/vim/commit/a742e084b677f76c67e9e52c4f9fb9ab24002e20
I have now removed those 2 conditions (as requested by @tpope )

I think I think we are seeing this bug here: vim/vim@a742e08
I have now removed those 2 conditions (as requested by @tpope )

That should work well for both VIM 7.4 and other VIM versions  I believe.
The only thing confused me is that  Line 19, exists('*fugitive#repo') return false on VIM 7.4, thus go the next elseif and trigger exception.
But exists('*fugitive#repo') return true on VIM 8, thus no problem for VIM 8.
I am not sure the reason behind that.


catalog output choices please

For outputting a catalog, these are the choice in order offered in Gibson's BASIS. Note the foxpro style... it is getting old, but the options are what are key. [note it also uses WordPerfect output - very old]
screens in order of catalog generation....

linked table options (from previous screen):

Crossreferencing to #1473

Crossreferencing to #1473


Vendor kubernetes/code-generator instead of using the code-gen image

Currently the SDK relies on running the container image gcr.io/coreos-k8s-scale-testing/codegen:1.9.3 which packages kubernetes/code-generator to do code generation for CRDs.
We should decouple the SDK from relying on an externally maintained image and instead vendor github.com/kubernetes/code-generator in the SDK to build and do the code generation.

I had the same problem because I wanted to use the defaulters as well as deepcopy generator.
For future reference, I solved it by vendoring the codegen package and calling it from my makefile:

add code-generator to Gopkg.toml:

[[constraint]]
  name = "k8s.io/code-generator"
  version = "kubernetes-1.10.0"

added 2 make jobs to build deepcopy and defaulters:

generate_deepcopy: $(BINDIR)/deepcopy-gen
	${BINDIR}/deepcopy-gen "$@" \
	 -v 1 --logtostderr \
	 --go-header-file "./tmp/codegen/boilerplate.go.txt" \
	 --input-dirs "github.com/RedisLabs/redis-enterprise-operator/pkg/apis/app/v1alpha1" \
	 --output-file-base "zz_generated.deepcopy"

generate_defaulters: $(BINDIR)/defaulter-gen
	${BINDIR}/defaulter-gen "$@" \
	 -v 1 --logtostderr \
	 --go-header-file "./tmp/codegen/boilerplate.go.txt" \
	 --input-dirs "github.com/RedisLabs/redis-enterprise-operator/pkg/apis/app/v1alpha1" \
	 --output-file-base "zz_generated.defaults"

generate_files: generate_defaulters generate_deepcopy

add pkg/apis/app/v1alpha1/doc.go header:

// +k8s:defaulter-gen=TypeMeta


fail to generate ego_vehicle

when I do roslaunch carla_autoware_agent carla_autoware_agent.launch town:=Town01 host:=<IP_ADDRESS>, it goes wrong and [carla_ego_vehicle_ego_vehicle-4] process has died [pid 13695, exit code 1, cmd /home/autoware/carla_ws/src/ros-bridge/carla_ego_vehicle/src/carla_ego_vehicle/carla_ego_vehicle.py __name:=carla_ego_vehicle_ego_vehicle __log:=/home/autoware/.ros/log/3b70b1fe-0c41-11eb-9010-ac1f6b8091ec/carla_ego_vehicle_ego_vehicle-4.log]. log file: /home/autoware/.ros/log/3b70b1fe-0c41-11eb-9010-ac1f6b8091ec/carla_ego_vehicle_ego_vehicle-4*.log  occured. Only map changed in the carla, there isn't a car generated in the road.
I want to get some suggestions to fix this.

Hi @lz1159435992!
Can you send me the complete log by running the following command:
roslaunch carla_autoware_agent carla_autoware_agent.launch town:=Town01 host:=<IP_ADDRESS> > log.txt

This will generate a log.txt inside the container. To copy the file to your host machine run:
docker cp <CONTAINER_ID>:/home/autoware/log.txt .

You can get the <CONTAINER_ID> by running docker ps:

log.txt
this is the log.

Hi @lz1159435992
Sorry for the delay. Can you run again the command and send me the log (the stderr was not redirected to the file):
roslaunch carla_autoware_agent carla_autoware_agent.launch > log.txt 2>&1

Thank you very much. After I use the computer with the display, I have already fix this problem. Maybe this is the root cause.


How to leave MP3s on USB-Stick

Sorry this is not a real issue, only a hint:
You may add this to the readme, how one can use RPi-Jukebox with MP3s on an USB stick.
The USB-stick is automatically mounted to
/media/usb0
I leave all MP3 there and put only softlinks to the audiofile folder with this command:
ln -s /media/usb0/* /home/pi/RPi-Jukebox-RFID/shared/audiofolders/

This may help some beginners.

@sigmaeo nice one, will do that.

@sigmaeo added it here: https://github.com/MiczFlor/RPi-Jukebox-RFID/blob/master/docs/MANUAL.md#playing-audio-files-from-a-usb-stick


Reduce size of subscription max results

MAX_SUBSCRIPTION_RESULTS was set to an arbitrarily high 50000. This resulted in a failures in hapi-fhir-jpaserver-starter
ca.uhn.fhir.jpa.starter.ElasticsearchLastNR4IT because it exceeds elasticsearch's default index.max_result_window of 10000.
Other constants, such as SearchParamRegistryImpl.MAX_MANAGED_PARAM_COUNT have a limit of 10000 as well. This aligns the MAX_SUBSCRIPTION results with that value.

Fixes #5195


unexpected behaviour of discard (or bug?)

Hi,
I found that discard breaks input matching in the action.  This seems to be a bug?  Below you can find a test case that shows two behaviours.  I'd have expected either to work.
The guts of it is in this rule:
struct word1 : seq<discard, bytes<4>> {};

In the action, I try to match the four byte input string, but find that the discard (which should throw away the three preceeding characters) throws away the first three characters of bytes<4>.
$ ./discard-test
Unexpected:
INPUT: 3/3: one
INPUT: 4/4: vase
WORD: e
INPUT: 3/3: two
INPUT: 4/4: pots
WORD: s
INPUT: 0/3:

Expected:
INPUT: 3/3: one
INPUT: 4/4: vase
WORD: vase
INPUT: 3/3: two
INPUT: 4/4: pots
WORD: pots
INPUT: 0/3:

#include <tao/pegtl.hpp>
#include <stringstream>
#include <iostream>

using namespace tao::pegtl;

struct word1 : seq<discard, bytes<4>> {};
struct grammar1 : star<discard, bytes<3>, word1> {};

struct word2 : seq<bytes<4>> {};
struct grammar2 : star<discard, bytes<3>, discard, word2> {};

template <typename Rule>
struct xaction : nothing<Rule> {};

template <>
struct xaction<word1> {
  template <typename Input>
  static void apply(const Input& in) {
    std::string str = in.string();
  std:
    std::cerr << "WORD: " << str << "\n";
  }
};

template <>
struct xaction<word2> : xaction<word1> {};

int main(int argc, char* argv[]) {
  std::stringstream data;
  data << "onevasetwopots";
  using reader_t =
      std::function<std::size_t(char* buffer, const std::size_t length)>;

  auto reader = [&data](char* buffer, const std::size_t length) mutable {
    std::streamsize sz = data.read(buffer, length).gcount();
    std::cerr << "INPUT: " << sz << "/" << length << ": ";
    std::cerr.write(buffer, sz);
    std::cerr << "\n";
    return sz;
  };
  std::cerr << "Unexpected:\n";
  buffer_input<reader_t> input1("reader", 1024, reader);
  parse<grammar1, xaction>(input1);

  std::cerr << "\nExpected:\n";
  data.clear();
  data.seekg(0, data.beg);
  buffer_input<reader_t> input2("reader", 1024, reader);
  parse<grammar2, xaction>(input2);
  return 0;
}

I'm not sure that this is a bug, Colin will mark it as such if it is.
My thinking is that anytime you use discard all rules involving it may not return the correct result for the matched input fragment. In your example only an action for bytes<4> will work correctly, the input for seq<discard, ...> will always be undefined.
@ColinH Could you clarify this in the documentation? Is it even allowed to access input.string() when the rule contains discard? Could we protect against that?

Your thinking does make sense in particular if one considers the case seq<A, discard, B> where A will be discarded.  I may have been tricked by the special case were discard is at the beginning of a sequence, which is not obviously illogical.

It might not look illogical at the beginning, but think about what happens:

seq<discard, bytes<4>> starts, the buffer is filled with 3 characters from before.
seq remembers the beginning of the input by storing a const char* into the buffer.
seq now calls the rules it contains, discard being the first one.
discard now shifts the buffer (which might contain pre-read input) 3 characters to the left.
bytes<4> reads 4 characters.
seq now ends, the end of the input is now poining at the 4th character in the buffer.
seq's action now gets called with the remembered first character (which was the 3rd character in the buffer) to the last character (which is now the 4th character).
You now see e as the input.

Looking at it this way is both logical, explains the result you are seeing and explains why discard may always trash the matched input.

It's not really a bug, at least not in the code; discard modifies the buffer, so it doesn't play well, and shouldn't be used, together with any rules that remember positions in the input. Invoking actions remembers the position to know which portion of the input to pass to the action.
We will update the documentation to make it clearer, and I now have an idea on how to use a static_assert to prevent these shenanigans from happening in the first place, we'll have to see whether it works and whether it's not too strict.

As expected the static_assert is too strict so we can't use it without some serious extensions to the core library; for now I'll clarify the restriction in the documentation.

Thanks everybody for the explanations, it is clear now!


[Adding Tool]: Add Kubernetes

What tool are you adding and to what category?
We need to add Production-Grade Container Orchestration
Add Tool Link
https://kubernetes.io/
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] The tool is free for use

We need Free-hit to include unique and lesser-known tools that people can use. Since the tool you mentioned is already well-known, I will be closing this issue for that reason.


BUG in the website: No contribute page

Neither the github.io nor the martinos stable version gives a contribute page. It is though working for the dev version.

It's a dead link problem, the page is here:
http://martinos.org/mne/stable/contributing.html#
cc @Eric89GXL

It is already fixed in dev, my solution would be just to wait for release. The number of people who miss the contributing page in the meantime is probably small


Loading old models with cudnn is broken

I've got this problem uncovered when moved to local install. I cannot load models with cudnn saved before December. The issue is with with Sequential models with cudnn inside, pretty generic.
So as I've got some global outdated installs that can load these models I tried to debug and search the module that causes troubles. So let's say this is my model:
nn.Sequential {
  [input -> (1) -> (2) -> (3) -> (4) -> (5) -> output]
  (1): nn.Reshape
  (2): cudnn.SpatialConvolution
  (3): cudnn.ReLU
  (4): cudnn.SpatialMaxPooling
  (5): cudnn.SpatialConvolution
}

I save it with old install and open with new install and got errors like this:
/opt/rocks/distro/install/share/lua/5.1/torch/File.lua:254: unknown object
stack traceback:
	[C]: in function 'error'
	/opt/rocks/distro/install/share/lua/5.1/torch/File.lua:254: in function 'readObject'
	/opt/rocks/distro/install/share/lua/5.1/torch/File.lua:211: in function 'readObject'
	/opt/rocks/distro/install/share/lua/5.1/torch/File.lua:248: in function 'readObject'
	/opt/rocks/distro/install/share/lua/5.1/torch/File.lua:234: in function 'readObject'
	/opt/rocks/distro/install/share/lua/5.1/torch/File.lua:248: in function 'readObject'
	/opt/rocks/distro/install/share/lua/5.1/torch/File.lua:248: in function 'readObject'
	/opt/rocks/distro/install/share/lua/5.1/torch/File.lua:234: in function 'readObject'
	/opt/rocks/distro/install/share/lua/5.1/torch/File.lua:271: in function 'load'

When I debug it recursively goes with readObject and finds the last SpatialConvolution with typeidx=1332609024 and doesn't know what to do with it.
If I split Sequential and save it module by module - it loads.

ugh with help of @fmassa we found out that old saved cudnn.SpatialConvolution had accGradParameters inside which could be serialized and written, and also loaded with old torch, but gave an error with new torch. So it's a function serialization issue related to https://github.com/torch/torch7/commit/12a1dc79aa0e41889ccceb2ae9d1544aeae43248
Nowhere near trivial to discover.
That's not the end, after Pointwise was introduces the old models do not know about their type any more, so ReLU and others don't work any more.


Add Support for the  Casio GBD-200 Watch

We would like to add support for the GBD-200. If any developer has this watch, and would like to contribute the project. please add a comment here, and I can assist with that.
Without any modification, the app can connect to this watch. Some functions work, and others do not:
What works:

the watch and the app are "pairing" (but the watch shows "failed")
the app is really fast
time sync
alarms

What does not work:

battery level
actions (lower-right button)
date format, language, illumination period are not as same as in specification
alarms have no snooze option
reminders cannot be set on the watch

In addition, the GDB-200 has some fitness functions, which are not present in the current app. It would be interesting to explore integrating the watch with Google Fit.
Realistically, what can be done with minimum effort is:

Get Actions working. This is a matter of detecting what button was pressed and invoking existing app functionality. As of now, the Lower-right button is either not recognised or has different functions for this watch.
Get reminders working. The format of data/commands for Reminders sent to to watch is apparently different, but should not be very difficult to implement. The App already has functionality to read the Google Calendar format.

@AntoniJakubiak Hey Antoni,
To answer your questions, I have been trying to add fitness functions to the app, but I do not own any watch with these capabilities. Here is a thread of trying to do this for a GG-B100 watch. It is a different watch, but it works with the Move app, so the data should be the same or similar. I don't have that watch either, so it is hard to work blind, but the person who is helping is very good at extracting the right data. In that thread, you can see my idea of integrating the fitness functions into the app.
There is almost no chance of damaging your watch when developing. The firmware is read-only. If some of the values are screwed up, you can always do a factory reset on your watch. In the past 2-3 years, nobody has reported such issues using my app. (Of course, I cannot be 100% sure).
What do you feel comfortable doing technically? Using Wireshark to collect BLE data, programming in Kotlin, Python? We are always looking for contributors at various skill levels, so I would be happy for you to join.

@AntoniJakubiak
BTW, your watch should be able to connect and work with this app, but of course, no fitness functions. The app will not set any new values to the watch unless explicitly requested (i.e., you press any of the [send] buttons). But people have used the app with your watch, so it should not be a problem even if you update values.

Hi @izivkov
I own a GBD-200 watch, know wireshark, don't know about BLE but open to learn, same for kotlin and python (can try and program, not proficient but can pick up).
I can't give commitments, but I am interested in adding support!
How can I get started, and where to start first?

OK, great!
The code is distrbuted between this project and this one. I norrmally combime the two projects into one. I will do that and will create a branch for you to work on.
To port the current functionality to the GBD-200 you probobly don't need to go into WireShark. I will show you how to selected features for your watch. If you like to add the fitnell fuctions, than you will need to use Wireshark.
In the mean time, get familiar with Android Studio and Kotlin, if you are not already.
I will let you know whan your branch is ready.
Regards,
Ivo

@ShivankChopra
Hi, I created a branch GBD-200 for you. Please fork the repository and checkout this branch.
The first thing I would do it to try to build the app in Android Studio from this branch. Try it with your watch, and please comment here on what works and what does not. We will take it from there.
Thanks

Hi @izivkov
Sure, I'll setup and try to run the app.
Will update here.
Thanks and regards

Hello I bought a gbd-200 and I want to change 2 things. First I would like to see DD/MM and not MM/DD. Is that possible? Also, I would like to make vibration go longer or repeat on phone calls.
is any of them possible?

You can select date format DD/MM or MM/DD from the settings in the app. At
least this is how it works for the supported watches, but give it a try
with the gbd-200. I am not sure about the vibration time. I hope I could
add support for this watch in the future, I am hoping somebody who owns
this model can add support for it.
Regards,
Ivo
On Sun, Nov 3, 2024 at 4:10 PM Mitsosxat @.***> wrote:

Hello I bought a gbd-200 and I want to change 2 things. First I would like
to see DD/MM and not MM/DD. Is that possible? Also, I would like to make
vibration go longer or repeat on phone calls.
is any of them possible?
—
Reply to this email directly, view it on GitHub
https://github.com/izivkov/CasioGShockSmartSync/issues/37#issuecomment-2453577960,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7M37XPLK574K3PRG547WTZ62GMHAVCNFSM6AAAAAAYUMVYIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJTGU3TOOJWGA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Is there any way to find the firmware and tweak it?

I think that would be very difficult
On Sun, Nov 3, 2024, 4:25 PM Mitsosxat @.***> wrote:

Is there any way to find the firmware and tweak it?
—
Reply to this email directly, view it on GitHub
https://github.com/izivkov/CasioGShockSmartSync/issues/37#issuecomment-2453582028,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7M37TFLIZ4EAX6VC3KK7LZ62IEZAVCNFSM6AAAAAAYUMVYIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJTGU4DEMBSHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Do not have this watch. I will close the issue for now. If somebody has the watch and would like to assist. let me know and I will reopen.


Success Confirmation Message in Contact us page

Success Confirmation Message: After the user submits the form, display a confirmation message like "Your message has been successfully sent. Our team will get back to you soon!

when user send message they have not idea about send or not send

sir you may have pulled a wrong request in main branch plz check it once because all the pages are mixed up and UI  is also mixed

@vivekvardhan2810 kindly please assign me with this task i'm looking forward for contribution.
[response]
by using this tag we can solve this issue

@pameladeysarkar2003 this issue was assigned before and please don't spam on every issue.

this issue was completed and solved, so i am closing this issue.


Capture serialized errors/stack traces when actions are dispatched

performAction() now creates an Error object and serializes it as a field in the lifted action.  This is a prerequisite for displaying stack traces in the DevTools Extension UI.
See https://github.com/zalmoxisus/redux-devtools-extension/issues/429 for the original request.

Okay, apparently linting matters.  I'll fix that this evening.

Hey @markerikson thanks for working on this. I fixed the linting, but tests still fail as stacks on importing actions don't match:
- "stack": "Error\n    at Object.performAction (instrument.js:43:101)\n    at liftAction (instrument.js:191:25)\n    at instrument.js:490:32\n    at Object.dispatch (/Volumes/DATA/gits/redux-devtools-instrument/node_modules/redux/lib/createStore.js:179:22)\n    at Context.<anonymous> (instrument.spec.js:702:34)\n    at callFn (/Volumes/DATA/gits/redux-devtools-instrument/node_modules/mocha/lib/runnable.js:315:21)\n    at Test.Runnable.run (/Volumes/DATA/gits/redux-devtools-instrument/node_modules/mocha/lib/runnable.js:308:7)\n    at Runner.runTest (/Volumes/DATA/gits/redux-devtools-instrument/node_modules/mocha/lib/runner.js:422:10)\n    at /Volumes/DATA/gits/redux-devtools-instrument/node_modules/mocha/lib/runner.js:533:12\n    at next (/Volumes/DATA/gits/redux-devtools-instrument/node_modules/mocha/lib/runner.js:342:14)\n    at /Volumes/DATA/gits/redux-devtools-instrument/node_modules/mocha/lib/runner.js:352:7\n    at next (/Volumes/DATA/gits/redux-devtools-instrument/node_modules/mocha/lib/runner.js:284:14)\n    at /Volumes/DATA/gits/redux-devtools-instrument/node_modules/mocha/lib/runner.js:315:7\n    at done (/Volumes/DATA/gits/redux-devtools-instrument/node_modules/mocha/lib/runnable.js:276:5)\n    at callFn (/Volumes/DATA/gits/redux-devtools-instrument/node_modules/mocha/lib/runnable.js:333:7)\n    at Hook.Runnable.run (/Volumes/DATA/gits/redux-devtools-instrument/node_modules/mocha/lib/runnable.js:308:7)\n    at next (/Volumes/DATA/gits/redux-devtools-instrument/node_modules/mocha/lib/runner.js:298:10)\n    at Immediate._onImmediate (/Volumes/DATA/gits/redux-devtools-instrument/node_modules/mocha/lib/runner.js:320:5)\n    at runCallback (timers.js:705:18)\n    at tryOnImmediate (timers.js:676:5)\n    at processImmediate (timers.js:658:5)
+ "stack": "Error\n    at Object.performAction (instrument.js:43:101)\n    at liftAction (instrument.js:191:25)\n    at liftReducerWith (instrument.js:201:23)\n    at liftReducer (instrument.js:668:14)\n    at instrument.js:671:37\n    at createStore (/Volumes/DATA/gits/redux-devtools-instrument/node_modules/redux/lib/createStore.js:65:33)\n    at Context.<anonymous> (instrument.spec.js:690:24)\n    at callFn (/Volumes/DATA/gits/redux-devtools-instrument/node_modules/mocha/lib/runnable.js:315:21)\n    at Hook.Runnable.run (/Volumes/DATA/gits/redux-devtools-instrument/node_modules/mocha/lib/runnable.js:308:7)\n    at next (/Volumes/DATA/gits/redux-devtools-instrument/node_modules/mocha/lib/runner.js:298:10)\n    at Immediate._onImmediate (/Volumes/DATA/gits/redux-devtools-instrument/node_modules/mocha/lib/runner.js:320:5)\n    at runCallback (timers.js:705:18)\n    at tryOnImmediate (timers.js:676:5)\n    at processImmediate (timers.js:658:5)"

I'll look into that. If you have any ideas on how to preserve it, let me know.

Hmm.  Hadn't thought about the importing case.  Which test, and can you give an example of how to repro the issue?

I'm trying to understand the necessity of added serializeError and destroyCircular functions. I guess errors stack is always a string, so stack: new Error().stack should be enough.

@markerikson can find it in travis error. Just run yarn test.

I pulled that code from https://github.com/sindresorhus/serialize-error , on the grounds that I wanted to make sure it got serialized properly.  Maybe it wasn't necessary, but it was pretty much the first thing that came up when I searched for something like "js serialize error" or something like that :)

Did you by any chance see if throwing an error on every action would decrease the performance significantly? Some applications dispatching lots of actions frequently, and could have issues if the performance would decrease much, especially that the extension is autoupdated automatically. Usually it doesn't affect the performance if not opened. In that case we should make this optional and not enabled by default.

No, I didn't do any perf checking.  FWIW, it's just creating Errors to capture the stack, not actually throwing them.  Not sure how much of a perf impact that might have.
It looks like the test failures are because the stack traces are being captured at the time the action is recorded, so the stack from a dispatch is different from the stack from an import, and therefore the old and new states are different.  Also not sure what a good way is to handle that.

Yep, it probably depends how fast Chrome is getting stack trace internally.

Ideally the monitor part would emit an action to generate the stack trace, then instrumentation part would recompute action and send the stack on request. But it would be more complicated. Probably easier, just to make it optional and mentioning in that tab that it should be added as parameter if needed. At least as the first step and not having regression in the performance.

Alright, so even though Error.stack is not standard, according to the specification it's string in Chrome and Firefox. Microsoft specs redirects to the same page so we could assume it should be string there too. Checked in Safari and it's also string.
I'll remove those parts then.
Will add it as an option as some others. If we can check the performance and it have no regressions, can make default in feature versions.
As per tests, we can just mention that it doesn't work on importing. We are not dispatching actions again, so not possible to make it work.

Actually, that's good, when we're importing we want to see the stack trace of the person who exported, not our stack trace. So it does that.

I published it as 1.9.1 and also implemented those changes discussed above in https://github.com/zalmoxisus/remotedev-app/pull/43/commits/7fd66e0d577170a229fae51101965351a1949779. Thanks a lot for the contribution!


code for benchmarks (large_string_join, etc.)

Hi there,
I am looking to use your bench suite here, to run it against a different Jsonnet implementation not covered in your comparison. would you mind sharing the code for the first 4 benchmarks? large_string_join, large_string_template, realistic1, realistic2
Thanks!

Benchmarks .md file is generated by this .nix flake (You can add your jsonnet implementation to it):
https://gist.github.com/CertainLach/5770d7ad4836066f8e0bd91e823e451b#file-flake-nix
Benchmarks you mentioned are ran from perf_tests directory of jsonnet repo

Got it, I will update the .nix flake soon when I can look into it, thanks!


[WIP]: Refactor the logger framework to accept more configurations.

Slightly refactor logger framework to resolve #175.
##Goals:

Add new command line and config options.

log-level
log-file
log-config-file

Compatible with logger config file like we used.

Changes:

Add new class ProxyLogger
Remove logger related code from utils.
Initialize logger in ProxyLogger class methods.
Apply the changes to all the file using logger.

Coverage decreased (-0.5%) to 85.402% when pulling b884c471d6f7d5356dff2c04f5f5ea2a7f273973 on logging-refactor-#175 into 7ecd4c8936034f8e0d751da4f3519728de7ba178 on master.

@chhsiao90 it's finished. Help me reviewed this thanks.

Coverage increased (+0.01%) to 85.891% when pulling 9728defe484087a0f14a68038fda7224c5596aff on logging-refactor-#175 into 7ecd4c8936034f8e0d751da4f3519728de7ba178 on master.


Added documentation to the PROTOCOL configuration

Type: feature
The following has been addressed in the PR: Missing documentation for PROTOCOL config
Added the documentation that was missing for my last pull request.

😄  thanks ! cool !

What do you think about an example kubernetes deployment json? It would maybe help some people. It took me a little while to figure it out myself how would it be good

Like this: https://gist.github.com/markpeterfejes/e3897eecb5d4541fc344d71225fa378d

Feel free to extend this one https://github.com/verdaccio/docker-examples/tree/master/kubernettes-example ⚠  the huge typo ⚠ I made 😄 . Also increase the doc is also good idea.

Ohh! Looks good! Will do! It definitely needs a link to it in this repo!


deadlock when a new client tries to connect to the broke with an existing clientId and a will message

When the MqttClientSessionManager tries to create a session, it calls GetOrCreateClientSessionAsync, if there's already a session with the same clientId and cleanSession equals true, the existing session will be closed. However if the session has a will message, it will be be dispatched via the ApplicationMessageReceivedCallback delegate, which calls DispatchApplicationMessageAsync.
Since both GetOrCreateClientSessionAsync and DispatchApplicationMessageAsync wait on the same SemaphoreSlim, this cause a deadlock.

Hi,
thanks for reporting this issue and providing the solution 😄
Please try again with the RC version 2.7.5-rc1 from nuget.
Best regards
Christian

Hi,
The problem is still there in 2.7.5,
A quick fix could be change the line# 286 in MqttClientSessionManager to
await clientSession.StopAsync(true).ConfigureAwait(false);
This will stop the will message being published. I think it's acceptable since we are creating a session with the same clientId anyway.
What do you think about it?

I am wondering why it still occurs. I was able to reproduce it and after the fix from 2.7.5 it was gone.

This will be fixed in 2.8.0 which will be released soon.


Config option to force upload file regarding application/cdfv2-corrupt

Hi
I've started a forum thread regarding uploading files problem
You can read it here:
http://forum.codeigniter.com/thread-61406.html
When I upload an excel file (generated from other app) in my CI app, I get the "The filetype you are attempting to upload is not allowed.", even If I have the detect_mime set to false and allowing all kind of files
$config['allowed_types'] = '';
$config['detect_mime'] = false;

When I upload a new excel file created from office/libreoffice, all works fine. Now that I'm aware of the cause (maybe bad file header from excel spreadsheet) I'd like to have an option to set in $config array so the upload library uploads file anyway, without throwing the wrong error "filetype not allowed".
$config["force_upload"] = 1;

allowed_types must be set to '*', not an empty string ...

@narfbg That is not the problem. I can set allowed_types = '*' (which would not be a good choice)
The problem I was trying to reference is that I get "The filetype you are attempting to upload is not allowed." when I upload an excel file and get the [file_type] => application/cdfv2-corrupt in the $this->upload->data() array
I'd need to do something so CI uploads it anyway and to be able to restrict allowed_types too
Thanks

So you want to ignore the type mismatch error and allow the upload anyway ... That is EXACTLY the same as allowing all types.
Please post on the forums if you need help with this.

Is it a type mismatch? Because the file IS an excel spreadsheet. Excel/Libreoffice open the file correctly, but the CI->upload returns [file_type] => application/cdfv2-corrupt and throws (incorrectly) "The filetype you are attempting to upload is not allowed", just because it could not match some mime?
I've solved the problem temporarily by opening each file and saving as xlsx again, but I thought I'd be able to force the upload anyway, without setting '*' to allowed_types
PS: posted in forum
Thanks again


Maria design

General Checks

[ ] the branch is up to date with main/master
[ ] the code works when pulled and run locally
[ ] All CI checks pass
[ ] all conflicts are resolved (if any)
[ ] PR has a descriptive title
[ ] PR has appropriate labels and milestones for easy identification
[ ] PR it is assigned to the owner
[ ] reviewers are assigned
[ ] the PR contributes only one focused change
[ ] It is in the appropriate column in the project board (if necessary)
[ ] has short and clear description
[ ] is linked to an issue (if it is related)
[ ] feedback is addressed (if any and if it is appropriate feedback.)

Markdown

[ ] the markdown source is formatted
[ ] spelling and grammar is correct in all text
[ ] The markdown looks correct when you preview the file
[ ] all links and images work

HTML

[ ] pages besides /index.html are stored in /pages
[ ] the code is well-formatted
[ ] the HTML is valid
[ ] there are no inline styles (example: style='color: red;')
[ ] there are no <style> tags with CSS, all styles are hrefs
[ ] there is no inline JavaScript (example: onclick='doSomething()')
[ ] there are no <script> tags with JS, all JS is in an separate file
[ ] ids are used for JavaScript only, not for CSS
[ ] semantic tags are used
[ ] spelling and grammar is correct in all site content

CSS

[ ] the code is well-formatted
[ ] passes all the linting checks

Hi @MMikhailova , You have done a great job Maria. so far all looks good and we will have a discussion about the design in the team. You set an amazing example for everyone here :) Keep up the great work.


Rollbacks

Add an API method to update a given row to a previous version of that row. Note that this should not modify the history for this row, but rather append a new historical entry for the row with the new data.

This has been implemented, Please review our pull request.


could you please show some examples how to use this role ?

It would be great if you write some examples in documentation, because it hard to understand how to use this role.

Sure thing, sorry been on holiday, I shall do this tonight.


Including #14561 into release to fix integration test

Unblocking integration tests due to outdated image on Archive cronjob.
https://github.com/MinaProtocol/mina/pull/14561

An interesting observation while debugging why integration tests fail:

Archive main Node fails to find a relation in DB and the container dies with Error. Nevertheless, it does not restart immediately, to we wait for the whole test to end before declaring the test as a failure and restarting.
This is avoidable by delaying the startup of the archive Node, effectively allowing db-bootstrap and PostgreSQL to bootstrap before the archive.

Will track here: https://app.zenhub.com/workspaces/platform-engineering-652fc5b78bd6b33584ffedf9/issues/zh/31

!ci-nightly-me


Module not found: Can't resolve 'dns'?

error - ./node_modules/ioredis/built/cluster/ClusterOptions.js:3:0
Module not found: Can't resolve 'dns'
Source:
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
const dns_1 = require("dns");

Looks the package.json does not include "dns" package.

Sorry for wrong way to run ioredis.

I ran into the same issue, what's wrong with
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
const dns_1 = require("dns");

Don't run with browser. XD

I actually fixed it by configuring my webpack config inside next.config.js to
module.exports = {
    webpack: (config, { isServer }) => {
        if (!isServer) {
            config.node = {
                dns: 'empty',
            };
        }

        return config;
    }
}

@baulml's solution using webpack 5
module.exports = {
    webpack: (config, { isServer }) => {
        if (!isServer) {
             config.resolve.fallback.fs = false
             config.resolve.fallback.dns = false
             config.resolve.fallback.net = false
        }

        return config;
    }
}

Still Error :(
Any update?

@thanhnx9368  dns is a built-in module in Node.js so I think the cause is you are including ioredis in a front-end bundle?


Convert LLVMCPU compiler target to a plugin.

Fixes https://github.com/openxla/iree/issues/15468 🥳

All compiler targets are now written as plugins
No more iree::compiler::Tools::init_targets target / compiler/src/iree/compiler/Tools/init_targets.cc file
compiler/src/iree/compiler/Dialect/HAL/Target now only contains generic/shared code

This was mostly mechanical, but I had to pay special attention to how CLI flags were set up. The other compiler targets had (nearly) 1:1 mappings between CLI flags and what the target consumed, but LLVMCPU has complex logic in LLVMTarget::create() (asking LLVM about CPU features, constructing target triples, etc.). To bridge that gap, I introduced a new LLVMCPUTargetCLOptions struct with the raw flag values that is converted into the regular LLVMTargetOptions struct fit for consumption throughout the rest of the plugin.
I also needed to move the LLVM_INITIALIZE_* code around to keep --iree-llvmcpu-list-targets working with the change in initialization order. Might be able to move that back around once this settles.

neat!

Triggered benchmarks just in case the changes to flags somehow passed tests but dropped attributes or other options on the floor.

No improved or regressed compilation metrics

Soooo... probably handled all flags correctly. Can merge tomorrow morning.


Improve content security policy in renderer and in webview iframe

There are some improvements we can make to tighten security by modifying our content security policy in renderer's index.ejs and in webview's WebViewService.ts:

[ ] Improve index.ejs connect-src ws: so it specifies the url we are supposed to connect to as listed in ClientNetworkConnector.ts
[ ] Improve index.ejs script-src and style-src so they don't use 'unsafe-inline'

I think this may need to be here because of hot reloading. It looks like we don't need this in production. We should probably figure out how to supply a different CSP between dev and production!
It looks like style-src 'unsafe-inline' is also necessary for importing libraries' css in webviews. It seems they at least probably mostly pull in styles inline bundled up with their script.
It seems 'script-src' needs to be here because iframes with srcdoc sources inherits the CSP of their parent frame and layer over it with their own. We need to move web view source to be served from the backend. Then they can have their own independent CSP.

Source: https://stackoverflow.com/questions/43236626/what-csp-child-iframe-inherits-from-its-parent
https://stackoverflow.com/questions/30428681/is-it-possible-to-have-csp-only-apply-to-the-parent-frame-not-any-iframes

We should also evaluate where is appropriate to allow our custom protocol (papi-extension:)

[ ] Determine if we should use script-src vs script-src-elem (disabling in-line attribute scripts) in index.ejs and in WebViewService.ts. Does this decision actually impact security?

Split a couple things out into higher priority #227


achievement.enchantments has no mapping for key class

Hi!
Getting this error when trying your test class on a 1.10.2 server (pelzz.net:25575)
Disconnected: io.netty.handler.codec.DecoderException: java.lang.IllegalArgumentException: Value achievement.enchantments has no mapping for key class org.spacehq.mc.protocol.data.game.statistic.Achievement. io.netty.handler.codec.DecoderException: java.lang.IllegalArgumentException: Value achievement.enchantments has no mapping for key class org.spacehq.mc.protocol.data.game.statistic.Achievement.
Maybe you can fix it :).

It looks like ENCHANTMENTS is missing from Achievement.java, as well as a few other ones.

Thanks, works like a charm!


common issue during the lab, unlimited key is generated but not activated, so it always fails for new beginners

It gives the opportunity to show / discuss the Products Policy where you can specify if a subscription is automatically approved or have to be admin approved.  The script should clarify that the admin has to approve Unlimited subscriptions - but not Starter subscriptions.

closed as it is part of the approval process of the admin portal and the products configuration


Add Hotels.com as user of Luigi to the README.rst

Description

Motivation and Context

Have you tested this? If so, how?

i'm fine adding this but the original intent was to link to any slides or public material documenting the usage. do you have anything public about your usage of Luigi?

My bad, sorry. We don't have anything public as of yet. Will try to get something though.

cool no problem. let's merge this and hopefully you can link to something cool later :)


⚠ Bofrost.es has degraded performance

In e98561a, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1442 ms

Resolved: Bofrost.es performance has improved in f5ce187 after 9 minutes.


Scaffolding Identity UI gives wrong code in Logout.cshtml.cs

.Net core 3.0 Preview4
Scaffolding Identity UI razor pages.
Logout.cshtml.cs has this
            if (returnUrl != null)             {                 return LocalRedirect(returnUrl);             }             else             {                 return Page();             }
whereas it should RedirectToPage(); instead as found here indeed.
https://github.com/aspnet/AspNetCore/blob/master/src/Identity/UI/src/Areas/Identity/Pages/V4/Account/Logout.cshtml.cs

@HaoK you were syncing with scaffolding? Can you look at this?

Yep this already is fixed in the scaffolding code
https://github.com/aspnet/Scaffolding/blob/master/src/VS.Web.CG.Mvc/Templates/Identity/Bootstrap4/Pages/Account/Account.Logout.cs.cshtml#L58
and
https://github.com/aspnet/Scaffolding/blob/master/src/VS.Web.CG.Mvc/Templates/Identity/Bootstrap3/Pages/Account/Account.Logout.cs.cshtml#L58

That said I'm not sure when scaffolding fixes show up in builds since the fixes are on the VS side


what do i use it on tampermonkey????

it doesnt say what to use please tell me

Yeh please tell me


ImportError: cannot import name MaxRetryError when trying to install_aliases on 0.17.0/0.17.1

I tried calling standard_library.instal_aliases() on my Fedora 30 host and it is resulting in an ImportError, as shown below:
$ cat /etc/redhat-release
Fedora release 30 (Thirty)
$ python2
Python 2.7.16 (default, Apr 30 2019, 15:54:43)
[GCC 9.0.1 20190312 (Red Hat 9.0.1-0.10)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from future import standard_library
>>> standard_library.install_aliases()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python2.7/site-packages/future/standard_library/__init__.py", line 466, in install_aliases
    import urllib
  File "urllib.py", line 3, in <module>
    from urllib.error import MaxRetryError
ImportError: cannot import name MaxRetryError
$ python
Python 2.7.16 (default, Apr 30 2019, 15:54:43)
[GCC 9.0.1 20190312 (Red Hat 9.0.1-0.10)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from urllib.error import MaxRetryError
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "urllib.py", line 3, in <module>
    from urllib.error import MaxRetryError
ImportError: cannot import name MaxRetryError
>>>
[ecooper@wkstn-ecooper onefs]$ python3
Python 3.7.4 (default, Jul  9 2019, 16:32:37)
[GCC 9.1.1 20190503 (Red Hat 9.1.1-1)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from urllib.error import MaxRetryError
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/ecooper/git/int/onefs/urllib.py", line 3, in <module>
    from urllib.error import MaxRetryError
ModuleNotFoundError: No module named 'urllib.error'; 'urllib' is not a package
>>>

This exception only appears to be implemented in urllib3.
More details:
$ python2 -c 'import future; print(future.__version__)'
0.17.0
$ python3 -c 'import future; print(future.__version__)'
0.17.0

Just tried with the latest version:
$ python2 -c 'from future import standard_library; standard_library.install_aliases()'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/ecooper/.local/lib/python2.7/site-packages/future/standard_library/__init__.py", line 466, in install_aliases
    import urllib
  File "urllib.py", line 3, in <module>
    from urllib.error import MaxRetryError
ImportError: cannot import name MaxRetryError

Can you submit a bugfix please? I'll include it in a release in the next few days.


[BACKLOG-16769] - a later version of wstx classes are provided by web…

…services-rt

Build Skipped
:white_check_mark: There was nothing to build. The changes are probably excluded by the build rules. If this is an error, please contact your system administrator.


Linked datasources POC

Description
Shortcut: https://app.shortcut.com/cartoteam/story/256962
Redux API
State
Links are stored in the linked source, i.e. the one that can be filtered as results or filtered applied on the other one, the 'foreign' source (this terminology matches the one used by the backend API on foreign filtererd).
Links can be set directly in the source parameters when adding it.
For example, to describe the customers source and declare it will be linked to the stores source so that filters applied on stores will have effect on customers:
{
  id: 'customers',
  type: MAP_TYPES.TABLE,
  connection: 'bqconn-front',
  data: 'carto-dev-data.public.customers',
  foreignFilteringSource: {
    foreignSourceId: 'stores',
    foreignColumn: 'store_id',
    column: 'store_id',
  }
}

Actions
Two new actions

ADD_SOURCE_LINK / addSourceLink, taking origin and linked as payload, both are { sourceId, column } objects
REMOVE_SOURCE_LINK / removeSourceLink, taking originSourceId and linkedSourceId as payload

Type of change

Feature

I think the current proposal will force the user to do multiple steps:
  dispatch(addSource(storesSource));
  dispatch(addSource(customersSource));
  dispatch(addSourceLink...);

I propose to simplify it as follows:
  const storesSource = {
    id: STORES_SOURCE_ID,
    type: MAP_TYPES.TABLE,
    connection: 'bqconn',
    data: 'carto-demo-data.demo_tables.retail_stores',
  };

  const customersSource = {
    id: CUSTOMERS_SOURCE_ID,
    type: MAP_TYPES.TABLE,
    connection: 'bqconn',
    data: 'carto-demo-data.demo_tables.retail_stores',
    linkedSource: {id: STORES_SOURCE_ID, sharedColumn: 'store_id' }
  };

 const  dispatch(addSource(storesSource));
 const  dispatch(addSource(storesSource));

So we only add a new property for DataSources, the rest is transparent.
I'm not opposed to keep the addSourceLink action available too.

@padawannn

On the other hand, we need to modify the remove source action to automatically remove links if this source was the original source or the linked source to avoid inconsistencies.

Indeed, I will add this.

Finally, we can not forget that we need to refresh the widget every time we remove or add a link. For the moment, don't focus on this because is the last task but have it in mind

Actually this won't need anything particular as the useWidget hook will depend on links so update will be automatic (it already is in my example app).

@alasarr About the data model…
I put a separate entry in state because I thought it was easier to manage, especially as it needs to be accessed both ways (from origin and from linked), filtered, etc.
But we discussed with @padawannn and I understand the point that putting the property directly in the DataSource model is simpler for C4R-template users.
I think this is no big deal to change for now, so I will.
Compared to your example code above, I will change two things:

replacing sharedColumn with two fields, as the column are not necessarily the same
changing linkedSource with something more explicit, as I think we have a vocabulary problem with "link" which is ambiguous to express the direction of the relationship.

Also, I have a concern about cardinality.
Javi explained to me you agreed to have only 1-1 links for now, but I think it will be a big limitation very soon…
I think having an array right away is better, even if we limit the possibility in UI.
WDYT?

In the last commit I've changed the data model so that the link can be set in the datasource itself, like you proposed @alasarr.
I've made some naming changes so that it's more explicit:
const customersSource = {
    // … other datasource props
    foreignFilteringSource: {
       foreignSourceId: STORES_SOURCE_ID,
       foreignColumn: 'store_id',
       column: 'store_id'
    }
};

This foreign term is the one used by the back-end API that we call in the case of global widgets, so I thought it was good to be consistent.
I'm still worried about the 0 or 1 cardinality of this prop for the near future. But this shouldn't be too hard to turn to multiple foreign filters if needed.
Also I've implemented the filtering for viewport mode on GeoJSON sources. Most of the job is done by the useForeignFilter hook which basically reads the link definition and turns it into a real IN filter with values fetched from the foreign source.
cc @padawannn

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

22 of 46 (47.83%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.7%) to 71.704%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/react-widgets/src/hooks/useRemoteForeignFilterSource.js
3
8
37.5%

packages/react-api/src/hooks/useForeignFilter.js
8
15
53.33%

packages/react-redux/src/slices/cartoSlice.js
8
20
40.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.7%

Covered Lines:
1675

Relevant Lines:
2186

💛  - Coveralls

@padawannn About the last changes:

I've added a helper selector (selectForeignFilterParams) to simplify the recovery of parameters and foreign source from the hook
I've added the management of the loading state, now isSourceReady depends on isForeignSourceReady if the source is filtered by another one
this isForeignSourceReady flag is used as a change trigger for updating the filter values. So, regarding the management of viewport change, there's no need for any specific code added elsewhere. When viewport changes, the feature loading cycle of the source triggers SET_FEATURES_READY actions, which will trigger changes to isForeignSourceReady and then the hook responsible for setting the filter in useWidgetFetch.
It's working fine in my C4R-template site and locally-linked builder.

Not useful now


fix: dont even have todo. err instead.

Summary
The existence of Content::V2(_) as a match arm was causing problems and crashing on the todo!()
This patch changes those todos to Err instead.

Really wild that iOS was hitting this. I'll have to dig deeper but atleast it shouldn't crash. 🙏

Sure.  Sorry that happened.  There's something to learn here about how and why that was happening.


[AutoRelease] t2-datafactory-2022-06-15-79696(Do not merge)

https://github.com/Azure/sdk-release-request/issues/2921
Live test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=987

issue link:https://github.com/Azure/sdk-release-request/issues/2921


Compatibility with svg outputs

Thank you for your amazing work with this component, which will be super useful for my blog. I was wondering if there was an easy way for the rendered notebook to also display vectorial images. I.e. have a cell like this actually display the output:
import matplotlib.pyplot as plt
import matplotlib_inline.backend_inline as backend_inline
backend_inline.set_matplotlib_formats('svg')
plt.plot([1, 2, 3, 4])
plt.show()

I'm asking because vectorial rendering is much prettier on any modern screen.
Thanks!

Thanks for your suggestion. I will take a look at this when I have time.


Additional compatible modules

I noticed, that you habe section for compatible modules in your README.
I have developed two modules that have optional compatible with your module. Would you be interested in adding them to your compatibilty section?
Rideable, Lock & Key

Sure no problem


[BUG] CLN Connection with Rune Shows Balances as NaN

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
Balance and historical incoming tx amounts all show as NaN
Screenshots [optional]

Steps To Reproduce

Connect via CLN with a Rune (in this case from StartOS)
Connection completes successfully
Balance and historical incoming tx amounts all show as NaN

Historical outbound tx amounts display properly

Expected behavior
Correct balances and payment history display in sats
Alby information
Alby 3.4.1 Firefox extension
Device information
Linux 6.1, Firefox 120
Additional context
No response
Are you working on this?
None

The balance issue has been fixed, however the NaN bug still remains for the tx history.  Suggest re-open

just had a quick test on cln. was unable to reproduce. what kind of transactions those are someone paying you rom specific website or something else?

Good thought - I rolled down and realized this is only happening on spam txs of 1sat, of which I've received a ton for some reason.  These are all keysends.  Legitimate txs (all > 1sat) are shown accurately.  Hopefully this is helpful.

Good thought - I rolled down and realized this is only happening on spam txs of 1sat, of which I've received a ton for some reason. These are all keysends. Legitimate txs (all > 1sat) are shown accurately. Hopefully this is helpful.

thanks for helping us @kn0wmad! issue should be resolved in next release


[Feature]: Enable HTTP 2.0/H2C on Caddy / Nginx

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
Currently, Appsmith application only seems to support HTTP 1.x protocol. APMU (please investigate further) - the API server is already HTTP 2 enabled, which means the issue resides with Nginx not being HTTP 2 enabled. Please check out the below references for more details:
Reference1
Reference2

Update:
looks like there might be another issue here - we need to enable http2 on webclient as well. Tracking it here.
Why should this be worked on?
Enable HTTP 2.0
On cloud setup:
There are 6 api calls that happen in http 1.0 and 2 get blocked right now on our cloud infrastructure. With HTTP 2.0, all the api calls, i.e 8 API calls should get executed in parallel now.

We encountered this issue during one of our use cases. We have a service running in ECS behind an ALB. This ALB is configured with an HTTPS:443 listener with an HTTP2 target group. Calling an endpoint on our service returns a 464 status code, which indicates an incompatible protocol. Therefore, this call does not exceed and we can not use our service behind this HTTP2 enabled ALB.

@Peterkrol12, can you confirm if I'm understanding this right. You're trying to build an API action on Appsmith, that hits an API running on ECS behind an ALB, that's running on HTTP2. Is that correct? In that case, you're looking for a solution to https://github.com/appsmithorg/appsmith/issues/28226 instead.
This issue is about having Appsmith itself be able to run with HTTP2.

Modern browsers don't support http2 without SSL. So having a docker image with HTTP2 isn't working. Closing this issue as this not possible technically.

Had a follow up with @sumitsum and we found out that we can use H2C instead of HTTP 2.0 and we should have the same benefits as HTTP 2.0 without SSL. This would be applicable to docker images running simply on an ip address without SSL.

Closing for now it seems that none of the major browsers support h2c protocol.
https://http2.github.io/faq/
However, some implementations have stated that they will only support HTTP/2 when it is used over an encrypted connection, and currently no browser supports HTTP/2 unencrypted.

https://bugzilla.mozilla.org/show_bug.cgi?id=1418832


Can ui4j run in Amazon EC2?

The commands for running it headless in linux does not seem to work (or seems to be incomplete). Kindly advice how to run it in EC2.

Have you tried xvfb? http://corpocrat.com/2015/08/25/screenshots-using-firefox-and-xvfb-in-amazon-ec2/. xvfb-run -a will automatically assign a screen number.

Monocle version is updated. Could you please update the ui4j version to 2.2.0 and monocle to 8u76
https://github.com/ui4j/ui4j/issues/86

Monocle version is updated. Could you please update the ui4j version to 2.2.0 and monocle to 8u76
https://github.com/ui4j/ui4j/issues/86


Feature Request: Current Audio Device Status

Been wanting a way for HA to know which audio device im using ie speakers or headphone and join that with the media states. Would be nice to notify the family upstairs if I had my headphones on so they are not yelling for me, wondering why I am not answering.

Thanks for creating an issue! Interesting idea. I'll have to do some research on how to query this.


[CodeCompletion] Skip to '=' after completion in 'if'/'guard' pattern

So that the parser can parse the subject expression which provides the expected type of the pattern.
rdar://problem/56802036

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test Linux


Persist ssh fingerprint

I'm not sure if we actually want this, or rather document something among the lines of:
stages:
   initramfs:
     - if: '[ -z "$(blkid -L COS_SYSTEM || true)" ]'
       name: "Persist"
       commands:
       - |
            target=/usr/local/.cos-state

            # Always want the latest update of systemd conf from the image
            mkdir -p ${target}/etc/systemd/
            rsync -av /etc/systemd/ ${target}/etc/systemd/
            # Only populate ssh conf once
            if [ ! -e ${target}/etc/ssh ]; then
            mkdir -p ${target}/etc/ssh/
            rsync -av /etc/ssh/ ${target}/etc/ssh/
            fi
            # make /tmp tmpfs
            cp -f /usr/share/systemd/tmp.mount ${target}/etc/systemd/system/
            # undo /home /opt mount from cos immutable-rootfs module
            sed -i '/overlay \/home /d' /etc/fstab
            sed -i '/overlay \/opt /d' /etc/fstab
            umount /home
            umount /opt
            # setup directories as persistent
            for i in root opt home var/lib/rancher var/lib/kubelet etc/systemd etc/rancher etc/ssh usr/libexec; do
            mkdir -p ${target}/$i /$i
            mount ${target}/$i /$i -t none -o bind
            done
            # This is hidden so that if you run some selinux label checking or relabeling the bind
            # mount won't screw up things.  If you have two files at different paths they will get
            # labeled with two different labels.
            mkdir -p ${target}/empty
            mount ${target}/empty ${target} -o bind,ro
            # persist machine-id
            if [ -s /usr/local/etc/machine-id ]; then
            cat /usr/local/etc/machine-id > /etc/machine-id
            else
            mkdir -p /usr/local/etc
            cp /etc/machine-id /usr/local/etc
            fi
            # ensure /var/log/journal exists so it's labeled correctly
            mkdir -p /var/log/journal

Closing for now


dice and loss

May I ask why I started with a high validation set and why the test DICE was very low?

I'm stupid, bother, there are a few classes, id is the number of classes, not the background, for example, a tumor is 1, id=1

I'm stupid, bother, there are a few classes, id is the number of classes, not the background, for example, a tumor is 1, id=1

Yes, ID is the label value of each category in the corresponding dataset.
We have provided a more detailed explanation of ID in SAMCT


Implement ProductVersionValidator

It merges some tokens into one such as product version number
in sentence which is written by Japanese.
Before:
0.1.0 -> tokenizer -> "0",".","1",".","0"
After:
0.1.0 -> tokenizer -> with this validator -> "0.1.0"
Using DoubledWordValidator which contains "." in skip list is
a workaround in such a situation, but it is too loose.

This is a proof of concept PR.
It is not actually validator, but token filter.
I have no idea how to implement this kind of thing as tokenizer correctly.
Anyway,  redpen claims to following sentences without above token filter.
% cat version.md
# RedPen

RedPen 1.2 は RedPen 0.6 よりも新しい。

RedPen 1.3.0 をリリースしました。
RedPen 1.4. をリリースしました。

version.md:3: ValidationError[DoubledWord], 一文に二回以上利用されている単語 "." がみつかりました。 at line: RedPen 1.2 は RedPen 0.6 よりも新しい。
version.md:5: ValidationError[DoubledWord], 一文に二回以上利用されている単語 "." がみつかりました。 at line: RedPen 1.3.0 をリリースしました。
version.md:6: ValidationError[DoubledWord], 一文に二回以上利用されている単語 "." がみつかりました。 at line: RedPen 1.4. をリリースしました。

Thank you very much for the contribution @kenhys! I will look into the PR.

I've found that it may be good enough in some cases to specify skip word.
 <validator name="DoubledWord">
          <property name="list" value=".,RedPen" />
        </validator>

At first, I thought this PR is good idea (although a bit ad-hoc way), but I came to think that this PR may be meaningless now.

Hello @kenhys I have understood the problem which derived from the Japanese tokenizer tokenizes input sentence into too small pieces (symbols).
I also think that the validator changes (replace) the token elements could have troublesome side effects since the behavior other validators could be change using this validator. We would like to keep Sentence and TokenElement objects immutable as possible.
I think that there are three solutions for this problem.

Add your token filter in JapaneseTokenizer as a post processor
Add your filter in DoubledWordValidator but not change tokens in Sentence objects
Your workaround (adding period to skip list item)

All three solutions are reasonable for me. First one is the most elegant but we need to consider many things. For example we should provide the setting item for adding the token filter. If we add the setting, we also need to extend the syntax of the configuration file. Maybe adding tokenizer block into redpen conf file for the filter configuration is a good idea. I want to try this idea someday.
Second one is simpler than first. In the second idea, we add the filter into DoubledWordValidator (not to change the token but duplicates the tokens) when the lang is "ja" and validate the input.
Third idea is also good workaround. I think sticking with the current validator could be best since we can keep the code simple.
Let me know your idea.

Add your token filter in JapaneseTokenizer as a post processor
Add your filter in DoubledWordValidator but not change tokens in Sentence objects
Your workaround (adding period to skip list item)

It seems that "1. Add your token filter in JapaneseTokenizer as a post processor" is the best, but I think "3." is good enough solution at the current point in time.
So, I close this PR. thanks @takahi-i .

Hi @kenhys. I added a issue for the token filter #474. I will add the design document for a while.


Feature/try to implement extract checksum

Oops, I just wanted to show you the extract_checksum function...

Taking the filename without extension is no enough, the formatting is more complex, you need also to split with ""
static-package-a_0.0.1ba7816bf8f01cfea414140de5dae2223b00361a396177a9cb410ff61f20015ad_f61f10025ad.packster
To simplify your code you could use :
let filename_without_extension = path.file_stem();


Adding protocol to the address:port reference

When clicking a naked address:port in a terminal window, the OS may or may not understand that it should be opened in a web browser. Adding the protocol to the address:port reference makes the link more click friendly in the terminal.

Will switch cmd implementation to cobra soon, so closing this.


Add image intensity metrics

Fixes #39
This PR adds a get_intensity_metrics function that calculates the following metrics for input image files:

Maximum pixel intensity
Average pixel intensity
16th, 50th, and 84th percentiles for the pixel intensities

This can be used as a pre-processing step to eliminate noisy images.

@milesjwinter A quick look at the image intensity metrics for the android images from 2017 shows a pretty heavy correlation between the average pixel intensity and the various percentiles. But I think it's still worth calculating all the different metrics and letting users pick the one that works best for their particular situation.


bedtools is a dependency for install_data.py

it may seem strange for a user in this space to lack bedtools, but it can happen...
https://www.dropbox.com/s/h1cqokbr8vjj5wc/encode_roadmap.bed.gz: HTTPS support not compiled in.
gunzip: can't stat: encode_roadmap.bed.gz (encode_roadmap.bed.gz.gz): No such file or directory
https://www.dropbox.com/s/8g3kc0ai9ir5d15/encode_roadmap_act.txt.gz: HTTPS support not compiled in.
gunzip: can't stat: encode_roadmap_act.txt.gz (encode_roadmap_act.txt.gz.gz): No such file or directory
/bin/sh: bedtools: command not found

It's already on the list https://github.com/davek44/Basset/blob/master/docs/requirements.md
Those files don't appear to have downloaded either. Do you know why that didn't work?

Oops I see you posted that as another issue. I'll address it there.

Apropos bedtools: yes, it is on the full requirement list, but the text in
README.md says you only
need to check the full requirements list if you don't use anaconda.  Minor
issue of course.
On Mon, May 23, 2016 at 7:38 PM, David Kelley<EMAIL_ADDRESS>wrote:

It's already on the list
https://github.com/davek44/Basset/blob/master/docs/requirements.md
Those files don't appear to have downloaded either. Do you know why that
didn't work?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/davek44/Basset/issues/17#issuecomment-221136033

Good point. I added it to the README. Thanks!


Druid Web console button sometime not available

Hello everyone.
I have built druid 0.14.
Then, When I use druid console(port 8888), some button can not be use.
For example, I want to disable datasource. I should  click "drop data" in datasource page, right?
But.. it always not be disable and running there.
Have someone can help or tell me solution.
Thanks,
Max

Hi Max,
Could you post a screenshot please?

Hi, vogievetsky
the screenshot is following:

Thanks.
Max

We have reworked that button and added more actions to each data source as part of: https://github.com/apache/incubator-druid/pull/7528

Hopefully that change will address this issue as it make the Actions column much narrower.

@clintropolis I believe this can be closed now (also tag plz!)

Closed by #7528


bws: 0.4.0 -> 1.0.0

Diff: https://github.com/bitwarden/sdk/compare/refs/tags/bws-v0.4.0...bws-v1.0.0
Changelog: https://github.com/bitwarden/sdk/releases/tag/bws-v1.0.0
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:

bws

FYI: I tried building without the Cargo.lock file, but I got an error:
       > ERROR: The Cargo.lock contains git dependencies
       >
       > This is currently not supported in the fixed-output derivation fetcher.
       > Use cargoLock.lockFile / importCargoLock instead.

so I updated the it instead.

@tangowithfoxtrot It is ok to have Cargo.lock if has git dependencies.

I'm still trying to wrap my head around Nix. What do I need to do to be able to nix-build -A bws, other than moving the files into pkgs/by-name/bw/bws and renaming default.nix to package.nix?
Is there a manifest that I have to add the bws "attribute" to somewhere?

@tangowithfoxtrot First merge conflicts. Secondly, remove it from pkgs/top-level/all-packages.nix