We should add the term money to oeo-social

Description of the issue
Money is used to exchange commodities, no matter if these are physical, energy-flows, financial, services .. .
Ideas of solution
Money is a universal medium for exchange
Money is also a commodity for storing exchangeable wealth.
Work along "An ontology of economic objects", Gloria Zuniga (1999).
https://mpra.ub.uni-muenchen.de/5566/1/Ontology_of_Economic_Objects.pdf
Workflow checklist

[ ] I discussed the issue with someone else than me before working on a solution
[x] I already read the latest version of the workflow for this repository
[x] I added this issue to the Project 'Issues'. If suitable, I add it to further Projects.
[x] The goal of this ontology is clear to me

I am aware that

[x] every entry in the ontology should have a definition
[x] classes should arise from concepts rather than from words

Couple of thoughts on this, because they are an issue for IAMs (and probably some ESMs as well):

money comes in different currencies
exchange rates vary over time
besides market exchange rates (MER), there's also purchase power parity (PPP), which is used in some contexts
the value of money changes over time through inflation (and possibly deflation)

So "money" strongly depends on spatial and temporal classifications.

Thanks for these thoughts that go beyond money as a medium for exchange. I wonder whether we could start defining money very generically as a medium for exchange first (this issue).
An then add further terms to the ontology that follow up on more specifics (which go along with money as a medium of exchange)?
So for example we could define: Money (either physical or virtual) is a medium for exchange.
And then determine what further definitions we need.
Further food for thought:
Money can be expressed in different currencies . An exchange rate helps to translate from money expressed in one currency to money expressed in another currency. Exchange rates can be determined based on different methods (MER, PPP). Inflation/deflation describes an increase/decrease in the price of commodities.
@jannahastings: what do you think about the thoughts above? I have marked bold these terms for which I think we may need further definitions based on @0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q  thoughts.

This is an important and broad topic.
From an ontological point of view, money is a dependent entity. It is a complex dependent entity as it partly depends on social entities and partly on physical entities.
Money is the bearer of economic value, which may be realised in economic exchanges.
Money is in some sense a generically dependent entity that has different concretizations (e.g. paper money, electronic money, coins, etc.)
In Barry Smith's 'Toward an Ontology of Commercial Exchange', he defines 'act of payment' as "act of payment=def. social act in which one party transfers an amount of money to another party, wherein the agent relinquishes ownership thereof and the other party acquires ownership thereof."  They go on to write "In modern commerce, the transfer of ownership is frequently assisted with instruments of payment such as cash, check, or electronic transfer. Such instruments are documents (a subclassof IAO:information content entity) which are specified as having some monetary value relative to some unit of currency. These documents can be concretized in metal (coins), on paper, or in computer systems. In the metal and paper (money) cases there is an independent document entity which is an amount of money which can be used to buy things with (can be transferred in an act of commercial exchange). In the computer system case the pixels on a screen or the electromagnetic excitations on a server merely represent money." (italics added).
As per the discussion above, we should distinguishing different sorts of entity:

A portion of money, e.g. $10
A concretization of a portion of money, e.g. a $10 note
A currency, e.g. dollars
A price, which is a specification of a quantity of money that a good or service is available for exhange for
The social and legal institutions, organisations and entities that define and regulate money

Some of these entities are defined in FIBO, we should also look there for inspiration? E.g. currency.

Definition:

Money is a generically dependent continuant that measures economic value and is defined by a numeral (the amount) together with a currency and a currency base year.

Description:

The currency base year establishes the year on which the value of money depends, and which is independent from the point in time at which value is measured with money.

class 'money' with three properties:

amount [numeric]
currency [either alphabetic or numeric ISO 4217 code, (I prefer alphabetic)]
currency base year [integer]

Energy system models care neither about how payments are made, nor how money is made, so we don't need the "concretization of a portion of money" or " social and legal institutions, organisations and entities that define and regulate money".

This is highly related to #342.

I wonder whether we could start defining money very generically as a medium for exchange first (this issue).

Money is a generically dependent continuant that measures economic value and is defined by a numeral (the amount) together with a currency and a currency base year.

I guess your suggestions fit for "portion of money".
I agree that generically dependent continuant seems suitable, since it can vary its form of "concretizations"
(even when we don't implement them). @jannahastings could a generically dependen continuant in this special case also be a "bearer" of a specifically dependent continuant, as economic value might be? Or would we need an independent continuant instance anyway?
I am not an economic expert, but a measure of economic value sounds rather like price (index) than money.

I am not an economic expert, but a measure of economic value sounds rather like price (index) than money.

A price is the relation of economic value (measured in money) to the quantity of something else (the good).  The price of electricity may be expressed in €/MWh.  17 MWh of electricity would than have an economic value of seventeen times the price – measured in € (money).

I think  economic value is not necessarily equal to the price price paid/asked.
And to make things even more complicated (but not necessarily more complicated for our definition): the economic value a thing has may be viewed differently from different perspectives (say from the perspective of an individual firm, or from society as a whole). But this may not matter for us right now in trying to find a proper definition of money.

An additional attribute scale would come in handy.
Million, billion, and trillion $/€/ are common, but billion and trillion are ambiguous (short v. long scale).  Possibly some energy market models may want to denote e.g. electricity prices in cents/kWhel.  I think our model notes investment costs for some technologies in 1'000 of $ somewhere.  Other models may want to denote lakh.
So I think an integer order of magnitude (10n) works best.

Coming back to the beginning, I wonder whether as a "foundation" we could define money as:
Money is a universal medium for exchange
Money is also a commodity for storing exchangeable wealth.
And then work along FIBO to get more specific, e.g. start to define  amount of money which is according to FIBO: a sum of money.  With the editorial note: This is an actual sum of money, not the measure of a sum of money in monetary units, although it has the same basic properties (decimal number with a currenct unit).
If this approach would be suitable, we could leave the definition of money very generic and add further issues for specification. The first one would then be for amount of money.

oeo dev meeting 14
We decided that we do not need this term as price, cost and currency suffice for our purposes.

As we have related things popping up, e.g. #867 on purchasing power parity, I wonder whether we should open this issue again and subsequently separate it into several other issues on:

money
currency
purchasing power parity
market exchange rate
base year
inflation

I think it would be great if we could have @jannahastings help structuring on how to approach this maybe start with a dedicated meeting in a smaller group, where @jannahastings asks us the right questions to move forward with this?
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q  - if you agree, I  think it would be great if you could organise such a meeting, I think we should at least invite @litotes18 along for it and at least one person from the @OpenEnergyPlatform/oeo-domain-expert-energy-modelling to help out our thoughts into perspective. What do you think?

Thanks.
I have created a pad in which we can collect some initial thoughts and ideas on the concepts involved. We can then use this pad to guide us through the meeting and take notes: https://etherpad.wikimedia.org/p/money-related-things
I'll try to provide some initial ideas there until then, happy if you chip in too.
This approach worked well in a previous meeting with @litotes18 et al. on market related terms: https://etherpad.wikimedia.org/p/oeo-dev-markets

Thanks @jannahastings for thumbs up! Anyone from @OpenEnergyPlatform/oeo-domain-expert-energy-modelling who would volunteer to participate? Then @0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q  would know who to contact with a date finder. Maybe a peek into the pad where I collected a few ideas already may help spark / purge or your interest?: https://etherpad.wikimedia.org/p/money-related-things

Thanks @stap-m !
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q  - it would be super, if you could now set up a date-finder for all those who would participate, so we can move forward (I think that would be @litotes18, @stap-m, @jannahastings, @0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q, @han-f ). I also think it would be super if you could then walk us through the meeting as this was kind of initiated by issue #867. In the smaller meetings we had previously we simply walked along the different terms and took them one by one - and we already have a pad which can help walk us through. https://etherpad.wikimedia.org/p/money-related-things

I can make a Teams appointment in case Teams works for all of us

Should be OK for me :-)

I am fine with DFN, but cannot organise it, can you please do it?

I am not sure I know which DFN room to visit coming monday.

While implementing it occured to me that, instead of having ratio as parent class for inflation rate, exchange rate and PPP, economic value (subclass of quantity value) might be the right place, in addition to the axiom has unit some ratio. @jannahastings @l-emele ?

I agree that the mentioned concepts are subclasses of economic value and ratio is the unit of these concepts.


Fix typings to allow import from TypeScript

Changed typings so it is similar to https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/enzyme-adapter-react-16/index.d.ts to allow import from TypeScript.
Fixes #10

I need someone to test your fork and confirm it's working correctly. We're already past half a million downloads per month, so it's getting serious.

I can confirm this change fixes the error appearing when trying to import this adapter in a typescript environment on a 300 test case project.
I don't have a big project to test with on javascript.

Thanks @ctamas. Let's try it then!

Are there any plans to make a release with this?

Ah sure, forgot about it, sorry. Released.


Move kyuubi extension to its own dir when building

Why are the changes needed?

Make Kyuubi jars clear.
How was this patch tested?
Manual test.  After this PR, the packaged dir looks like:

Codecov Report

Merging #634 (35063ea) into master (43f40dc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #634   +/-   ##
=======================================
  Coverage   79.88%   79.88%
=======================================
  Files         120      120
  Lines        4683     4683
  Branches      563      563
=======================================
  Hits         3741     3741
  Misses        625      625
  Partials      317      317

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43f40dc...35063ea. Read the comment docs.

thanks, merged to master for v1.3.0 and branch 1.2 for v1.2.0


Inconsistent string auto-complete when inside/outside string

Bug Report

🔎 Search Terms

inconsistent string auto complete intellisense suggestions tuple position
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about auto-complete / suggestions.
⏯ Playground Link

Playground link with relevant code
💻 Code

declare function foo(x: ["xa", "xb", "xc"]): void
foo([ ])
//   ^ ctrl+space shows "xa", "xb", "xc"
foo([""])
//    ^ ctrl+space shows "xa"

🙁 Actual behavior
The suggestion list outside of the string ignores the tuple position and suggests all members, while the suggestion list inside of a string suggests only the string for that position.
🙂 Expected behavior
Both suggestion lists would show "xa" but not "xb" or "xc".

Both suggestion lists would show "xa" but not "xb" or "xc".

I think the second one is correct, cause type definition constrains that the first array item is xa

@susiwen8 Yes, that is the expected behavior. (my original issue had the two reversed, but that was corrected shortly after posting)


docs: add missing link to PEP-440

It is a really small change but seeing it missing bugged me.

Codecov Report

Merging #724 (da0533e) into master (b0a8742) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #724      +/-   ##
==========================================
- Coverage   96.67%   96.63%   -0.04%
==========================================
  Files          41       41
  Lines        2915     2915
==========================================
- Hits         2818     2817       -1
- Misses         97       98       +1

Flag
Coverage Δ

unittests
96.63% <ø> (-0.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

copier/cli.py
96.47% <0.00%> (-1.18%)
:arrow_down:


Add {Node, Python} auto-labeling script

This script is intended for a (relatively) one-off job (hence the lack of ~tests or~ docs), but might be worth preserving for posterity.
TODO:

add tests
add php support
⚠python: properly label tests with decorators (e.g. this one)

Added tests + ~a dozen misc. bugfixes.


Prestige

Allowing users to change their goal level
Correcting problem where skills weren't displaying correctly when the plugin was shut down, started up or re-configured

Please don't close and open new prs. Keep pushing to the same branch and it will update the current pr.

My apologies. I thought the commit hash was wrong in the bot comment and thought I needed to open a new one. Noted for the future.


Ability to specify status code

Partly resolves #56

Hey @hivokas, could you update the PR to include a description of what you're trying to accomplish here? Like, I get that you want to add status codes to response...but I'm curious why?

I've updated the description.

@hivokas I merged another PR (#44), which has some implications on this PR. Do you mind updating? 🙏

I don't have an access to my laptop now. So maybe in a week. Ok?

@hivokas For sure, take your time. 👍

Hey @hivokas! Sorry for the delay. Curious, why did you close this?

@reinink is it still relevant?

I'm not sure, to be honest. I haven't had the need for this functionality. Nonetheless, this issue is here if we ever want to revisit. 👍


redirect validation resource

Do we have the HCL formatting linter in this repo? The spacing of the HCL example looks a little off


[Suggestion/Issue] Modular - Facade conduit unusable

Issue Description:
Im using the modular installation of Ender IO with only Base, Conduit and TiC.
We can't use Conduit facade without painting them but this machine is only on Ender IO Machines.

Affected Versions:

EnderIO Base: 5.0.50
EnderIO Conduit: 5.0.50
Minecraft: 1.12

https://minecraft.curseforge.com/projects/facade-painter

@tyler489 Thank you ! I didn't saw it.
But it would be great to have it in an "official" way

sorry i should say Third Party not Unofficial


Add Metrics from 1_Div/2_Gro/3_Risk to List of Metrics

We have a long list of all metrics and need to add to it the new metrics that we created in 1_Diversity-Inclusion, 2_Growth-Maturity-Decline, and 3_Risk.
I uniformly Title Cased all metric names and added a period at the end of every description.
Note, that some metrics overlap with existing metrics or are the same with different names. We can clean this up later.

Thank you @BenLloydPearson, I created issue #61


How to make Error cloneable and support context chaining

Hi,
I have a situation where I need an Error to be Cloneable. I saw #7 and tried implementing something like this:
#[derive(Clone, Error)]
pub struct AssetError(Arc<anyhow::Error>);
impl From<anyhow::Error> for AssetError {
    fn from(err: anyhow::Error) -> Self {
        Self(Arc::new(err))
    }
}
impl std::fmt::Display for AssetError {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        self.0.fmt(f)
    }
}
impl std::fmt::Debug for AssetError {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        self.0.fmt(f)
    }
}

fn a() -> Result<(), AssetError> {
    Err(anyhow!("a").into())
}

fn b() -> Result<(), AssetError> {
    Ok(a().context("b")?)
}

fn c() -> Result<(), AssetError> {
    Ok(b().context("c")?)
}

fn main() {
   if let Err(e) = c() {
      eprintln!("{:#}", e); // Prints: "c: b", i.e. a is left out
   }
}

The one problem though is that it will only store the "latest" two contexts. Any idea how I could change that implementation to store the full context? Here's a playground: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=2172afa004deb537f4c27d5e7bf54bc3

You haven't implemented a source method in AsserError's Error impl, so it's not possible for errors of type AssetError to be chained / be context for another error.
For your use case it sounds like you want #[error(transparent)] on AssetError (and remove the Display impl), since the source would need to be the same as the Arc<anyhow::Error>'s source.
In general you would need a #[source] attribute somewhere in the error in order to create chains of errors/contexts.

@dtolnay Awesome, that works. Thank you!
For anyone else seeing this, here's the final implementation I use:
#[derive(Clone, Error)]
#[error(transparent)]
pub struct AssetError(Arc<anyhow::Error>);
impl From<anyhow::Error> for AssetError {
    fn from(err: anyhow::Error) -> Self {
        Self(Arc::new(err))
    }
}
impl std::fmt::Debug for AssetError {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        self.0.fmt(f)
    }
}

Just wanted to mention this since I had the same issue:
If you're not using thiserror as well as anyhow, instead of using error(transparent) you can implement StdError manually like this:
impl std::error::Error for AssetError {
  fn source(&self) -> Option<&(dyn std::error::Error + 'static)> {
    self.inner.source()
  }
}


ARROW-16176: [Release][C#] Use .NET 6.0 on Ubuntu 22.04

Ubuntu 22.04 ships OpenSSL 3 and .NET 5.0 or earlier doesn't support
OpenSSL 3 yet.

@github-actions crossbow submit viery-rc-source-csharp-*

@github-actions crossbow submit verify-rc-source-csharp-*

@github-actions crossbow submit verify-rc-source-csharp-*

@eerhardt It seems that our tests can't be ran with .NET 6.0:
https://github.com/ursacomputing/crossbow/runs/5999340698?check_suite_focus=true
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
Testhost process exited with error: It was not possible to find any compatible framework version
The framework 'Microsoft.NETCore.App', version '3.1.0' (x64) was not found.
  - The following frameworks were found:
      6.0.4 at [/tmp/arrow-HEAD.6doHP/csharp/bin/shared/Microsoft.NETCore.App]
You can resolve the problem by installing the specified framework and/or SDK.
The specified framework can be found at:
  - https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=3.1.0&arch=x64&rid=ubuntu.22.04-x64
. Please check the diagnostic logs for more information.

Test Run Aborted.
  Apache.Arrow.Flight -> /arrow/csharp/artifacts/Apache.Arrow.Flight/Debug/netstandard2.1/Apache.Arrow.Flight.dll
  Apache.Arrow.Flight -> /arrow/csharp/artifacts/Apache.Arrow.Flight/Debug/netstandard2.0/Apache.Arrow.Flight.dll
  Apache.Arrow.Flight.AspNetCore -> /arrow/csharp/artifacts/Apache.Arrow.Flight.AspNetCore/Debug/netcoreapp3.1/Apache.Arrow.Flight.AspNetCore.dll
  Apache.Arrow.Flight.TestWeb -> /arrow/csharp/artifacts/Apache.Arrow.Flight.TestWeb/Debug/netcoreapp3.1/Apache.Arrow.Flight.TestWeb.dll
  Apache.Arrow.Flight.Tests -> /arrow/csharp/artifacts/Apache.Arrow.Flight.Tests/Debug/netcoreapp3.1/Apache.Arrow.Flight.Tests.dll
Test run for /arrow/csharp/artifacts/Apache.Arrow.Flight.Tests/Debug/netcoreapp3.1/Apache.Arrow.Flight.Tests.dll (.NETCoreApp,Version=v3.1)
Microsoft (R) Test Execution Command Line Tool Version 17.0.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
Testhost process exited with error: It was not possible to find any compatible framework version
The framework 'Microsoft.AspNetCore.App', version '3.1.0' (x64) was not found.
  - The following frameworks were found:
      6.0.4 at [/tmp/arrow-HEAD.6doHP/csharp/bin/shared/Microsoft.AspNetCore.App]
You can resolve the problem by installing the specified framework and/or SDK.
The specified framework can be found at:
  - https://aka.ms/dotnet-core-applaunch?framework=Microsoft.AspNetCore.App&framework_version=3.1.0&arch=x64&rid=ubuntu.22.04-x64
. Please check the diagnostic logs for more information.

Should we support .NET 6.0? Or should we disable verification with .NET 6.0?

Sorry for the delay.
Since 2.1 is EOL, I think it makes sense to update our projects to supported versions.
Do you want me to push changes to this PR to fix this? Or do you want me to send a separate PR?

Do you want me to push changes to this PR to fix this? Or do you want me to send a separate PR?

The former is better but you can choose the latter if you have a trouble.

@github-actions crossbow submit verify-rc-source-csharp-*

@github-actions crossbow submit verify-rc-source-csharp-*

@github-actions crossbow submit verify-rc-source-csharp-*

Thanks @eerhardt !


Vault Agent with Docker Compose

Investigate using Vault for local dev in Docker Compose.
https://medium.com/geekculture/using-vault-agent-with-docker-compose-f410d033026f

Out of scope.


Apps page: change text next to wallet images to reflect key wallet elements

This issues was dropped from the list due to lack of team consensus on the importance/need of the described feature


Update enUS.lua

add ["Commands"], should fix /profile command. probably the same issue on retail

Fixed with https://github.com/kkthnx-wow/KkthnxUI_Classic/commit/3966ad92bb094f266170e9d928b19183bdd2ae74


Adds Prometheus metrics and handler

Adds Prometheus metrics and updates the proxy to run a simple Prometheus server.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

36 of 37 (97.3%)  changed or added relevant lines in 3 files are covered.
4 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.03%) to 98.985%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core/ordering/cosipbft/pbft/mod.go
12
13
92.31%

Files with Coverage Reduction
New Missed Lines
%

core/ordering/cosipbft/pbft/mod.go
1
98.96%

core/ordering/pow/block.go
1
98.91%

mino/minogrpc/server.go
2
96.69%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
12293

Relevant Lines:
12419

💛  - Coveralls


Columns are not movable

Description
I can not rearrange the columns, i.e., I can't move Date Created before Date Modified.
Steps To Reproduce

Open Files
Click on a column like Date Created and try to move it to another position.

Requirements
The user should be able to rearrange the columns.
Files Version
3.0
Windows Version
22H2 Build 22621.2506
Log File
debug.log

Thanks for the feedback, we're tracking this in #8385


Add support for function components

It would be great if function components in heex were detected and all the support like regular functions works for it.

This would be an awesome addition. Does anyone have pointers on where I could start to implement this myself?

Is this project the right place to implement support for library specific DSLs?

I get that this might not be the right place, but I also have no idea what the right place would be?

A dedicated phoenix language server? I know there are vscode extensions


Improve command namings

The current command names are done with their exact task instead of sorting them like the example below shows as a possibility.

You can also set them up with subcommands.
https://discordnet.dev/guides/int_basics/application-commands/slash-commands/subcommands.html


add: Basic md files for the repo

After Padmaja finishes the Gatsby configuration, I will install eslint and create the required files for it.

Once Padmaja's PR is merged, I will add the ESLint files

If you want any changes in the README file, do let me know; I will send it in the next PR.

Once Padmaja's PR is merged, I will add the ESLint files. If you want any changes in the README file, do let me know; I will send it in the next PR.

Hey @Sonakshi1901 Padmaja's PR is merged


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter doorbird for common errors and appropiate suggestions to keep this adapter up to date.
This check is based the current head revisions (master / main  branch) of the adapter repository
Please see the result of the check below.
ioBroker.doorbird
   -
:thumbsup: No errors found
WARNINGS:

[ ] :eyes: [E851] .npmignore found but "files" is used at package.json. Please remove .npmignore.

SUGGESTIONS:

[ ] :pushpin: [S522] Please consider migrating to admin 5 UI (jsonConfig).

Please review issues reported and consider fixing them as soon as appropiate.
Warnings reported by repository checker should be reviewed. While some warnings can be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.
Suggestions reported by repository checker should be reviewed. Suggestions can be ignored due to a decision of the developer but they are reported as a hint to use a configuration which might get required in future or at least is used be most adapters. Suggestions are always optional to follow.
You may start a new check at any time by adding the following comment to this issue:
@iobroker-bot recheck
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
Note: This issue replaces issue #160
@mcm1957 for evidence

@iobroker-bot recheck

Thanks for contacting me.
I received your request to recheck this repository. I will start doing my work soon.
I will close an existing issue and create a new one if still any issues are to be evaluated and potentially to be fixed.
Thanks for spending your time and working at an ioBroker adapter.
your
ioBroker Check and Service Bot

This issue has been replaced by new isse #163
This issue can be closed.
your
ioBroker Check and Service Bot


GH-35932: [Java] Make JDBC test less brittle

Rationale for this change
A JDBC test is brittle because it compares string representations.
What changes are included in this PR?
Compare values directly.
Are these changes tested?
N/A
Are there any user-facing changes?
No.

Closes: #35932

hmm, that's a new failure

Weird, guess we somehow picked up java 20

Well. We can't upgrade Mockito to fix this.

I'm just going to take this opportunity and disable flaky tests.

CI is green


Doesn't break long React props

e.g.
<BaseForm url="/auth/google" method="GET" colour="blue" size="large" submitLabel="Sign in with Google" />

should probably be converted into
<BaseForm
  url="/auth/google"
  method="GET"
  colour="blue"
  size="large"
  submitLabel="Sign in with Google"
/>

And don't forget about this form:
const FooForm = ({colour}) => {
   const method = 'GET'
   return (
      <BaseForm {...{
        url: '/auth/google',
        method, colour
      }}/>
   )
}

Similarly, I tested:
const render = ({ styles }) => (

    Keep the wrapping params. Put each key on it's own line.

);

which results in:
const render = ({ styles }) =>

  Keep the wrapping params. Put each key on it's own line.

;

Here, IMO the best style would be the one that optimizes for diff readability on changes.
Like the one in the OP post.
Probably worth doing for any elements that don't fit within a single line completely.

I'm going to try to tackle this now.

The example by @ericclemmons now compiles to:
const render = ({ styles }) =>

  Keep the wrapping params. Put each key on it\'s own line.

;

which is an improvement, but I agree the parens should be maintained. I'll open a separate issue for that if one doesn't already exist, and try to tackle soon.

I am closing this in favour of #73. Please continue the discussion in that thread.


Implement commissions and delcom command

adding commission model + delete commission command
checklist

[x] add commission class and parts (inferred from addcom in UG)

[x] fee: Double
[x] deadline: LocalDate
[x] title: String
[x] tags: Set
[x] completed: Boolean
[x] description: String

[x] add commission list to Person class (trying to copy UniquePersonList)
[x] update storage (since i am not doing addcom i need to modify the json file to test later)

[x] JsonAdaptedCommission
[x] JsonAdaptedPerson

[x] add placeholder commission label to ui because if i try to implement Ui.png i think ill die
[x] integrate with model

[x] add current person to AddressBook
[x] add CRUD commission methods to AddressBook
[x] add CRUD commission methods to ModelManager

[x] fix the incoming merge conflicts :')
[x] move activeCustomer from AddressBook to modelManager
[x] addressBook: add a list of everything
[x] delcom feature

[x] parser
[x] command
[x] why does the thing need to click to update??? (fixed - probably some observable list magic)
[x] figure out what to do if no active person

[x] change customer commissions to set
[x] test updating equality methods - if works, remove getClone() - did NOT work - keeping getClone()
[x] remove temporary commissions label
[x] POC: filteredCommissionsList
[x] make commissions immutable
[x] what is builder pattern

Closes #22
plan
plan

how to test
current progress: it kinda works actually - how to test (because we have no addcom yet...)

go to terminal and type gh pr checkout 68
replace data/addressbook.json with

{
  "customers" : [ {
    "name" : "test",
    "phone" : "123",
    "email"<EMAIL_ADDRESS>    "address" : "",
    "tagged" : [ ],
    "commissions" : [ {
      "title" : "test 1",
      "description" : "desc",
      "fee" : 0.5,
      "deadline" : "2022-04-04",
      "tagged" : [ "test2", "test" ],
      "isCompleted" : true
    }, {
      "title" : "test 2",
      "description" : "desc",
      "fee" : 0.5,
      "deadline" : "2022-04-04",
      "tagged" : [ "test2", "test" ],
      "isCompleted" : true
    }, {
      "title" : "test 3",
      "description" : "desc",
      "fee" : 0.5,
      "deadline" : "2022-04-04",
      "tagged" : [ "test2", "test" ],
      "isCompleted" : true
    } ]
  }, {
    "name" : "test2",
    "phone" : "123",
    "email"<EMAIL_ADDRESS>    "address" : "",
    "tagged" : [ "test" ],
    "commissions" : [ {
      "title" : "test 4",
      "description" : "desc",
      "fee" : 0.5,
      "deadline" : "2022-04-04",
      "tagged" : [ "test2", "test" ],
      "isCompleted" : true
    }, {
      "title" : "test 5",
      "description" : "desc",
      "fee" : 0.5,
      "deadline" : "2022-04-04",
      "tagged" : [ "test2", "test" ],
      "isCompleted" : true
    } ]
  } ]
}

run ArtBuddy and type delcom 1
something changes

ui

future work

opencus implementer should use the selectCustomer and figure out what the initial state should be. @nvmdava
write test cases
currently i cannot add 2 commissions of the same name to different people. figure out if that is a bug or feature. if bug, add reference from commission back to customer in future PR and update equality checker

Codecov Report

Merging #68 (87fcef4) into master (257b705) will decrease coverage by 7.42%.
The diff coverage is 20.00%.

@@             Coverage Diff              @@
##             master      #68      +/-   ##
============================================
- Coverage     72.15%   64.73%   -7.43%
- Complexity      399      411      +12
============================================
  Files            70       80      +10
  Lines          1232     1429     +197
  Branches        125      150      +25
============================================
+ Hits            889      925      +36
- Misses          311      468     +157
- Partials         32       36       +4

Impacted Files
Coverage Δ

...main/java/seedu/address/commons/core/Messages.java
0.00% <ø> (ø)

...ddress/logic/commands/DeleteCommissionCommand.java
0.00% <0.00%> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
88.88% <0.00%> (-11.12%)
:arrow_down:

...ss/logic/parser/DeleteCommissionCommandParser.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/Model.java
100.00% <ø> (ø)

...ava/seedu/address/model/commission/Commission.java
0.00% <0.00%> (ø)

.../java/seedu/address/model/commission/Deadline.java
0.00% <0.00%> (ø)

.../main/java/seedu/address/model/commission/Fee.java
0.00% <0.00%> (ø)

...ain/java/seedu/address/model/commission/Title.java
0.00% <0.00%> (ø)

...ission/exceptions/CommissionNotFoundException.java
0.00% <0.00%> (ø)

... and 10 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Just one last thing from me: when I delete a commission from the 2nd customer, I would prefer the active customer to still be the same, but it currently jumps back to the first customer in the list. Otherwise, the rest looks good.


refactor: remove the unused _state slot from the Container

The __slots__ of the Container class has a declared _state attribute that is never used internally. Is there a reason for declaring it, maybe it should be removed?
I found a commit with the first addition of this attribute, but I still don't see a reason for it.
If there is, maybe it should be documented with a comment?

I think you’re right. Generally it does not hurt to have extra slots and there’s no automated mechanism to catch them. Hence why this slipped through the cracks. Thanks for taking a careful look.


fix: increase Tooltip's z-index to avoid overlap

Currently, the tooltip z-index is 10. Gets hidden by other layers having z-index. Popover has a z-index of 100: https://github.com/frappe/frappe-ui/blob/96ecd6adf3669bd231e59ee442ac9fb3711a840d/src/components/Popover.vue#L20
Bumping it up for Tooltip too

After

https://fantinel.dev/css-isolation-property

fantinel.dev/css-isolation-property

Yup, this helps too! But 10 is very low, so bumped it up to be consistent with Popover.


Clang doesn't recognize everything correctly as deprecated

There is some stuff that is not correctly marked as deprecated e.g. https://developer.apple.com/documentation/adsupport/asidentifiermanager/1614148-advertisingtrackingenabled?language=objc
The root cause seems to be that clang only recognizes something as deprecated, if the iOS version where it got deprecated is below the minimum iOS version. So currently everything that got deprecated in iOS 9+ is still be seen in java as non deprecated.
One fix could be to bump the min ios version always to the highest possible version.
Another fix could be to use the information from getCursorPlatformAvailabilities to determine whether there is a deprecation for any iOS version. The complete availability info (also other interesting stuff like, when the API was introduced, the deprecation note etc.) could be than also embedded into the JavaDocs.
I would think of something like this:

This is what I would end up with. I avoided using @since and the since parameter for the deprecated annotation to not mess accidentally with e.g. IDE's. This is done without upgrading the deployement target.


chore(main): release 0.1.3

:robot: I have created a release beep boop
0.1.3 (2024-09-03)
Features

inline auth for MAAS (#198) (ed78617)
support Azure plugin community gallery image rule (#181) (3d20725)

Bug Fixes

ensure ErrValidationFailed is returned for maas direct validation failures (#179) (0e0e7b9)
handle validation errors, result count mismatch (#204) (a2ea08b)
only require docker, kind when provisioning kind cluster (#180) (1bbdb0e)
remove duplicate maas base values from template (#182) (cfa39a8)
support validator rules check -f config.yaml without all plugins defined (#191) (6829834)

Other

cleanup comment (#176) (f371927)

Dependency Updates

deps: update anchore/sbom-action action to v0.17.2 (#184) (00d3a5c)
deps: update github.com/validator-labs/validator-plugin-maas digest to e903cc7 (#175) (09c3ad1)
deps: update golang.org/x/exp digest to 9b4947d (#190) (8c427e9)
deps: update module github.com/canonical/gomaasclient to v0.7.0 (#197) (f43a5ba)
deps: update module github.com/validator-labs/validator to v0.1.8 (#120) (fe587c6)
deps: update module github.com/vmware/govmomi to v0.42.0 (#172) (f0488c9)

Refactoring

move vsphere account under auth to match new plugin api (#189) (90352e1)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.1.3
:sunflower:


Use packit for upstream RPMs

https://packit.dev/docs/guide/

https://github.com/packit/notifications/issues/509

This appears to be the future of upstream RPM building. Currently used rpkg tooling seems to be inferior to this.
There is lots of outreach around the tool happening right now

Testing Tools mini-summit https://issues.redhat.com/browse/TT-213

For engaging external audience there are two opportunities right after:

PyVo Brno - Test Management Tool - Thursday 30th from 7p
DevConf Mini - Brno / Testing Farm, Testing System as a Service / Friday 31st from 4pm

See https://packit.dev/posts/2022-features/ for firehose-style overview of what this can do.
Example of the PR checks in action are at https://github.com/skupperproject/skupper-router/pull/1014, which triggered https://copr.fedorainfracloud.org/coprs/packit/skupperproject-skupper-router-1014/build/5705222/ which shows in the packit console as jobs https://dashboard.packit.dev/results/copr-builds/677809 and others (liked from the PR)

Dump of the rpkg version of .packit.yaml, for future reference
#
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements.  See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License.  You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

# See the documentation for more information:
# https://packit.dev/docs/configuration/

# https://packit.dev/docs/configuration/#top-level-keys
upstream_project_url: https://github.com/skupperproject/skupper-router
issue_repository: https://github.com/skupperproject/skupper-router

specfile_path: skupper-router.spec
srpm_build_deps: [rpkg]
actions:
  post-upstream-clone:
    # HACK: spec must be next to the generated tarball; https://github.com/packit/packit/issues/1637
    - cp packaging/skupper-router.spec.rpkg .
    - rpkg srpm --outdir ./
  fix-spec-file:
    - bash packaging/.packit.sh

# add or remove files that should be synced
files_to_sync:
  - .packit.yaml
  - src: packaging/skupper-router.spec.rpkg
    dest: systemd.spec

# name in upstream package repository/registry (e.g. in PyPI)
upstream_package_name: skupper-router
# downstream (Fedora) RPM package name
downstream_package_name: skupper-router

jobs:
  # run build/unit tests on some interesting architectures
  - job: copr_build
    trigger: pull_request
    targets:
      # big-endian
      - fedora-development-s390x

  - job: tests
    trigger: pull_request
    targets:
      - fedora-stable
      - fedora-development

# This script handles any custom processing of the spec file generated using the `post-upstream-clone`
# action and gets used by the fix-spec-file action in .packit.yaml.

# Inspiration taken from https://github.com/containers/skopeo/blob/main/.packit.sh

set -eo pipefail

PROJECT=skupper-router

# RPM Spec modifications

# Version should be accepted by python3 -c 'import packaging.version; print(packaging.version.parse("<IP_ADDRESS>-git"))'
sed -i "s/^Version:.*/Version: $PACKIT_PROJECT_VERSION/" ${PROJECT}.spec

# Update Release in spec with Packit's release envvar
sed -i "s/^Release:.*/Release: $PACKIT_RPMSPEC_RELEASE%{?dist}/" ${PROJECT}.spec


flutter run --trace-startup hangs when unable to connect to observatory

Steps to Reproduce

Cause the observatory to fail to start. As of today flutter run --trace-startup --profile does the trick on both Android and iOS.
Observe the stack trace about inability to acquire a debug connection.
The process hangs.

Logs and Crash Reports
Log
/cc @devoncarew @danrubel

@yjbanov, is this a regression?

I remember this to be a quick failure in the past, but I may be wrong.

how much does this impact the testing bots?

It causes the test bots to wait for timeout rather than fail fast and move on to the next task. This is why our build has been behind GitHub for the past several days. I reduced the timeout for the startup tasks to 2 minutes, which should help.

Haven't seen this in a while. Closing.


Allow array render

Codecov Report

Merging #66 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #66   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          12     12
  Lines         379    393   +14
  Branches      108    112    +4
=====================================
+ Hits          379    393   +14

Impacted Files
Coverage Δ

packages/molecule-jsx/src/molecule-jsx.ts
100% <100%> (ø)
:arrow_up:

packages/molecule-jsx/src/lib/vdom/diff.ts
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16f67f8...2d5deda. Read the comment docs.


Run Ruby server in background

Hello,
is there a way to make the ruby server run in the background as a service?

You will probably want to look at installing phusion passenger, they the ruby server will run as an apache module.  Here is what i did on Centos 6:
`
yum install httpd curl-devel httpd-devel
gem install passenger
passenger-install-apache2-module
vi /etc/httpd/conf/httpd.conf
`
Paste in
LoadModule passenger_module /usr/local/rvm/gems/ruby-2.2.0/gems/passenger-5.0.28/buildout/apache2/mod_passenger.so <IfModule mod_passenger.c> 	PassengerRoot /usr/local/rvm/gems/ruby-2.2.0/gems/passenger-5.0.28 	PassengerDefaultRuby /usr/local/rvm/gems/ruby-2.2.0/wrappers/ruby </IfModule>
Finally create a new VirtualHost entry in /etc/httpd/conf.d/
<VirtualHost *:80>   DocumentRoot /opt/staytus/public   ServerName  [put your server name here]   CustomLog /opt/staytus/log/access_log combined   ErrorLog /opt/staytus/log/error_log   <Directory "/opt/staytus/public">     AllowOverride All     Options -MultiViews   </Directory> </VirtualHost>


runtime error: integer divide by zero

We received a stack trace for a crash on this library:
runtime.errorString: runtime error: integer divide by zero
  File<EMAIL_ADDRESS>line 747, in (*PostingsIterator).nextDocNumAtOrAfterClean
  File<EMAIL_ADDRESS>line 632, in (*PostingsIterator).nextDocNumAtOrAfter
  File<EMAIL_ADDRESS>line 537, in (*PostingsIterator).nextAtOrAfter
  File<EMAIL_ADDRESS>line 526, in (*PostingsIterator).Next
  File<EMAIL_ADDRESS>line 88, in (*IndexSnapshotTermFieldReader).Next
  File<EMAIL_ADDRESS>line 89, in (*TermSearcher).Next
  File<EMAIL_ADDRESS>line 218, in (*ConjunctionSearcher).Next
  File<EMAIL_ADDRESS>line 246, in (*ConjunctionSearcher).Advance
  File<EMAIL_ADDRESS>line 241, in (*DisjunctionSliceSearcher).Advance
  File<EMAIL_ADDRESS>line 253, in (*ConjunctionSearcher).advanceChild
  File<EMAIL_ADDRESS>line 241, in (*ConjunctionSearcher).Advance
  File<EMAIL_ADDRESS>line 356, in (*BooleanSearcher).Advance
  File<EMAIL_ADDRESS>line 253, in (*ConjunctionSearcher).advanceChild
  File<EMAIL_ADDRESS>line 200, in (*ConjunctionSearcher).Next
  File<EMAIL_ADDRESS>line 165, in (*BooleanSearcher).advanceNextMust
  File<EMAIL_ADDRESS>line 316, in (*BooleanSearcher).Next
  File<EMAIL_ADDRESS>line 226, in (*TopNCollector).Collect
  File<EMAIL_ADDRESS>line 551, in (*indexImpl).SearchInContext
  File<EMAIL_ADDRESS>line 369, in (*indexImpl).Search

It looks like i.postings.chunkSize may need some checking as it can be zero.

We just received another similar crash, again caused by i.postings.chunkSize being 0, this time in the nextDocNumAtOrAfter function:
runtime.errorString: runtime error: integer divide by zero
  File<EMAIL_ADDRESS>line 644, in (*PostingsIterator).nextDocNumAtOrAfter
  File<EMAIL_ADDRESS>line 537, in (*PostingsIterator).nextAtOrAfter
  File<EMAIL_ADDRESS>line 526, in (*PostingsIterator).Next
  File<EMAIL_ADDRESS>line 88, in (*IndexSnapshotTermFieldReader).Next
  File<EMAIL_ADDRESS>line 89, in (*TermSearcher).Next
  File<EMAIL_ADDRESS>line 218, in (*ConjunctionSearcher).Next
  File<EMAIL_ADDRESS>line 218, in (*ConjunctionSearcher).Next
  File<EMAIL_ADDRESS>line 165, in (*BooleanSearcher).advanceNextMust
  File<EMAIL_ADDRESS>line 316, in (*BooleanSearcher).Next
  File<EMAIL_ADDRESS>line 396, in (*BooleanSearcher).Advance
  File<EMAIL_ADDRESS>line 253, in (*ConjunctionSearcher).advanceChild
  File<EMAIL_ADDRESS>line 190, in (*ConjunctionSearcher).Next
  File<EMAIL_ADDRESS>line 165, in (*BooleanSearcher).advanceNextMust
  File<EMAIL_ADDRESS>line 316, in (*BooleanSearcher).Next
  File<EMAIL_ADDRESS>line 226, in (*TopNCollector).Collect
  File<EMAIL_ADDRESS>line 551, in (*indexImpl).SearchInContext
  File<EMAIL_ADDRESS>line 369, in (*indexImpl).Search

Would you retest this with the latest v2.3.x release of bleve (v2.3.10)?
In situations such as these, it'd greatly help our team if you could give us a test case or some sample data with which we can deterministically reproduce the error.

We received another crash, same as before, on v2.3.10:
runtime error: integer divide by zero runtime.errorString<EMAIL_ADDRESS>(*PostingsIterator).nextDocNumAtOrAfter github.com/blevesearch/zapx/v15 in (*PostingsIterator).nextDocNumAtOrAfter
<EMAIL_ADDRESS>in (*PostingsIterator).nextDocNumAtOrAfter at line 644
<EMAIL_ADDRESS>in (*PostingsIterator).nextAtOrAfter at line 537
<EMAIL_ADDRESS>in (*PostingsIterator).Next at line 526
<EMAIL_ADDRESS>in (*IndexSnapshotTermFieldReader).Next at line 88
<EMAIL_ADDRESS>in (*TermSearcher).Next at line 92
<EMAIL_ADDRESS>in (*ConjunctionSearcher).Next at line 218
1
<EMAIL_ADDRESS>in (*BooleanSearcher).advanceNextMust at line 165
<EMAIL_ADDRESS>in (*BooleanSearcher).Next at line 316
<EMAIL_ADDRESS>in (*BooleanSearcher).Advance at line 396
<EMAIL_ADDRESS>in (*ConjunctionSearcher).advanceChild at line 253
<EMAIL_ADDRESS>in (*ConjunctionSearcher).Next at line 190
<EMAIL_ADDRESS>in (*BooleanSearcher).advanceNextMust at line 165
<EMAIL_ADDRESS>in (*BooleanSearcher).Next at line 316
<EMAIL_ADDRESS>in (*TopNCollector).Collect at line 228
<EMAIL_ADDRESS>in (*indexImpl).SearchInContext at line 580
<EMAIL_ADDRESS>in (*indexImpl).Search at line 371

@moshaad7 would you look into this, see if this covered or separate from what you've been looking into.

This is unrelated to the GetCardinality panic issue that we are working on at https://github.com/blevesearch/zapx/pull/259
This is essentially PostingsList.chunkSize being 0 and that is leading to divide by 0 error
func (i *PostingsIterator) nextDocNumAtOrAfter(atOrAfter uint64) (uint64, bool, error) {
    ...
    nChunk := n / uint32(i.postings.chunkSize)
   ...
}

I see previous attempts to avoid setting chunkSize to 0 in this PR raised by @abhinavdangeti  https://github.com/blevesearch/zapx/pull/151/files
But somehow we landed with 0 chunkSize.

Here is my proposal to solve this problem:
So we have a method named getChunkSize which return chunkSize and an error if any.
The problem with this method is that it can return chunkSize=0 and err=nil
Now in the previous PR that I mentioned , we are handling this case of chunkSize being 0 at only one place.
But there are several other places where we are calling this method getChunkSize()
So, we should update the implementation of getChunkSize() method to return error in case chunkSize is 0.
This way, caller will only have to worry about error being non-nil and they will be assured that chunkSize will never be 0

mattermost folks (@cpoile , @agarciamontoro , @streamer45 ), while we are adding checks to avoid "divide by zero" errors. We also want to figure out the source of the issue ( how chunkSize became zero).
There are several possibilities, like

usage of a premature value of type PostingsList. ( Say someone just created a postingsList but didn't set the right chunkSize, so it will take the default of 0 )
A segment reporting zero number of docs in it's header.
Maybe an issue while merging two segments, leading to docNum dropping to zero
etc ...

And also we ( couchbase) aren't able to reproduce this issue in-house.
It would be helpful, if you can try to reproduce it on staging/dummy data and share the index files to probe if there is an actual issue with segment headers etc ...
Thanks.

I am facing the same issue. Here are the files. Download Link
You wont be able to see the issue if you make 1 or 2 requests. I'm using blevesearch in a webapp, i found this issue when i was doing a testing. I tried to make request to blevesearch from 100 concurrent connections. each client was making 10,000 requests. after few thousand requests, i encountered this panic.

mattermost folks (@cpoile , @agarciamontoro , @streamer45 ), while we are adding checks to avoid "divide by zero" errors. We also want to figure out the source of the issue ( how chunkSize became zero).
There are several possibilities, like

usage of a premature value of type PostingsList. ( Say someone just created a postingsList but didn't set the right chunkSize, so it will take the default of 0 )
A segment reporting zero number of docs in it's header.
Maybe an issue while merging two segments, leading to docNum dropping to zero
etc ...

And also we ( couchbase) aren't able to reproduce this issue in-house.
It would be helpful, if you can try to reproduce it on staging/dummy data and share the index files to probe if there is an actual issue with segment headers etc ...
Thanks.

I am facing the same issue. Here are the files. Download Link
You wont be able to see the issue if you make 1 or 2 requests. I'm using blevesearch in a webapp, i found this issue when i was doing a testing. I tried to make request to blevesearch from 100 concurrent connections. each client was making 10,000 requests. after few thousand requests, i encountered this panic.

@mjm918  Thanks for your contribution
❯ ls -R
index_meta.json store

./store:
00000000000e.zap root.bolt

Can you also share index mapping related information and your query json ?

@mjm918
It would be really helpful for all of us bleve and zap users if u could address the questions in previous comment :)
The data that you shared can be really helpful for hunting down this peculiar bug.

Hi Sorry for late reply.

Can you also share index mapping related information and your query json ?

Index Mapping -
{
   "types":{
      "moss":{
         "enabled":true,
         "dynamic":true,
         "properties":{
            "product_code":{
               "enabled":true,
               "dynamic":true,
               "fields":[
                  {
                     "type":"text",
                     "analyzer":"standard",
                     "index":true,
                     "include_term_vectors":true,
                     "include_in_all":true
                  }
               ]
            },
            "product_desc":{
               "enabled":true,
               "dynamic":true,
               "fields":[
                  {
                     "type":"text",
                     "analyzer":"keyword",
                     "index":true,
                     "include_in_all":true
                  }
               ]
            },
            "product_id":{
               "enabled":true,
               "dynamic":true,
               "fields":[
                  {
                     "type":"number",
                     "index":true,
                     "include_term_vectors":true,
                     "include_in_all":true
                  }
               ]
            },
            "product_name":{
               "enabled":true,
               "dynamic":true,
               "fields":[
                  {
                     "type":"text",
                     "analyzer":"keyword",
                     "index":true,
                     "include_in_all":true
                  }
               ]
            },
            "product_status":{
               "enabled":true,
               "dynamic":true,
               "fields":[
                  {
                     "type":"number",
                     "index":true,
                     "include_term_vectors":true,
                     "include_in_all":true
                  }
               ]
            },
            "qr_code":{
               "enabled":true,
               "dynamic":true,
               "fields":[
                  {
                     "type":"text",
                     "analyzer":"en",
                     "index":true,
                     "include_in_all":true
                  }
               ]
            }
         },
         "default_analyzer":"standard"
      }
   },
   "default_mapping":{
      "enabled":true,
      "dynamic":true,
      "default_analyzer":"standard"
   },
   "type_field":"_type",
   "default_type":"_default",
   "default_analyzer":"standard",
   "default_datetime_parser":"dateTimeOptional",
   "default_field":"_all",
   "store_dynamic":true,
   "index_dynamic":true,
   "docvalues_dynamic":true,
   "analysis":{

   }
}

Query -
{
   "query":{
      "conjuncts":[
         {
            "conjuncts":[
               {
                  "match":"580",
                  "prefix_length":0,
                  "fuzziness":1
               },
               {
                  "match":"SONY",
                  "prefix_length":0,
                  "fuzziness":1
               },
               {
                  "match":"VOLUME",
                  "prefix_length":0,
                  "fuzziness":1
               }
            ]
         },
         {
            "conjuncts":[
               {
                  "query":"product_status:1"
               }
            ]
         }
      ]
   },
   "size":10,
   "from":0,
   "highlight":{
      "style":"ansi",
      "fields":[
         "*"
      ]
   },
   "fields":[
      "*"
   ],
   "facets":null,
   "explain":false,
   "sort":[
      "-product_name"
   ],
   "includeLocations":false,
   "search_after":null,
   "search_before":null
}

And were you performing any mutations while querying ? (or your data was stable with no ingestion)

There was no ingestion while querying

And are you sure your bleve index only have one segment ?
If yes, Did you use (*Scorch)ForceMerge API to achieve this ?

No ForceMerge was done. I indexed the data, tried to do a stress test and noticed the error.

Following fields have empty dictionary ( meaning no document had value corresponding to these )
product_desc, qr_code, product_promo

Yes it's correct. I was using a sample data database for testing.

Targeting some fixes here for bleve's v2.4.3 release.

Hi all, the fix has been merged and made available in Bleve v2.4.4.
We were able to reproduce this crash in-house as well.
Please let us know if the latest release resolves the crashes on your end as well
@streamer45 @cpoile
Thanks


allowed multiple dars to be provided to cucumber scenarios and unit tests

Can anyone look at this modification to allow scenarios to provide multiple dars, which will be key for real projects and daml finance based ones in particular.

There is an "unexpected termination of Daml script" - maybe later I can look into it.

There is an "unexpected termination of Daml script" - maybe later I can look into it.

That is a different issue. The script runner appears to be flaky.

Should rerunning be enough then?

Should rerunning be enough then?

It should. However, I would like to understand the reason of the flakiness. Although I think that should be in another PR.


bump gradle version to 6.2.2

In this PR, shall we try removing artifact renaming for KMP and use official KMP artifact naming conventions. Just to see if tests work.

Execution failed for task ':apollo-android-support:checkstyle'.
Unable to create Root Module: config {/home/travis/build/apollographql/apollo-android/checkstyle.xml}, classpath {null}.

In this PR, shall we try removing artifact renaming for KMP and use official KMP artifact naming conventions. Just to see if tests work.

I've done this and bumped the minimum Gradle version to 6.0


Possible to globally set default messages for built-in validators?

Is it be possible to programmatically define a default message for one of the built-in validators, such as required? That is, rather than defaulting to This field is required, can that string be set globally, perhaps at initiation, to something else? (I know that I can do this though data-attributes, but adding a data-attribute to every input becomes tedious pretty quickly, and I'm not seeing an alternative in the docs.)
If this is not already possible, perhaps the config object passed to new Pristine() could also take an object of messages, with keys there defining each of the built-in validators' default messages?
let defaultConfig = {
    classTo: 'form-group',
    errorClass: 'has-danger',
    successClass: 'has-success',
    errorTextParent: 'form-group',
    errorTextTag: 'div',
    errorTextClass: 'text-help',
    messages: {
        required: '🙅  This field is required!',
        email: 'Give us your email!',
       {...}
    }
};

@elseloop, there's a commit related to this in the feature/i18n branch.  It'll be merged into master soon!

@sha256 any update on this item? I see the feature/il8n branch is still open but it looks like this feature may have been merged in but I don't see it in the docs.


feat: add notification demo

Can you add such a sample, thx.

@gengjiawen Can you please explain in brief what kind of sample/demo do you want?

I want to set global notification, this won't work
import React from 'react'
import ReactDOM from 'react-dom/client'
import App from './App.tsx'
import './index.css'
import { MantineProvider } from '@mantine/core'
import { Notifications } from '@mantine/notifications'

ReactDOM.createRoot(document.getElementById('root') as HTMLElement).render(
  <React.StrictMode>
      <MantineProvider withNormalizeCSS withGlobalStyles>
      <Notifications />
      <App />
    </MantineProvider>
  </React.StrictMode>,
)

@gengjiawen One thing that i don't understand is that this is the nextjs tmplate and why are you talking or using the plain react method
ReactDOM.createRoot(document.getElementById('root') as HTMLElement).render(....)

It's sample code of working version without nextjs, sorry for the confusion. I tried adding <Notifications /> to this repo, couldn't find right way to to do it.

Check the above methods, it works fine

this is fixed in official version. See https://github.com/gengjiawen/next-app-template/tree/feat/notification.
But it has a bug (location not right), I will try to report it.


architecture & basic design

Code Architecture updated
Absolute path config
Bootstrap
Navbar
Footer
Banner section
Responsive Design

Hey @rahulxyz , I am not sure about this, but in the mobile view, the footer is supposed to move dynamically with the banner image?

Rest this basic layout looks good to me.

Banner and footer are independent of each other. Currently, the content in the footer is at the center since there isn't much content. And to maintain responsiveness the content of the entire page is aligned within the same boundary (and at center ), only background color stretches after a certain width.

Got it

Hi @rahulxyz, Before making such big changes I would appreciate you to come up with design mock ups. There are some features like the dark mode that I have added intentionally.Let me know if you need any help

I'm aware that these are major changes. But I noticed that you had just started with the boilerplate code and it would be better if we followed a better architecture at the start.
As far as I'm aware of there is no design. We have only a basic idea of what we want to build. I'm using bootstrap because of two reasons:

We do not have a specific design to follow. So it will be easier to utilize its prebuilt features
Currently, we are not focused on building a website where we need to ensure small build size, so it seems to be a viable choice.
As for theme transition, it can be handled even in this code as well
I'm not sure if React.Strict mode is necessary. Is there any particular reason you're using?

Thanks for the pull request. I can't see any comments resolved for now. So, I am closing it for now.


the elasticsearch and graphite comsume too much disk space

In GitLab by @tmon546596046 on Jan 17, 2019, 11:03
the elasticsearch can use the api to clean the index. the graphite may be replaced by promethues

In GitLab by @sokril on Nov 8, 2019, 08:30
assigned to @tmon546596046

In GitLab by @sokril on Dec 26, 2019, 03:01
changed the description


Markup example for type: ajax?

Hi there,
Thanks for the great script.
Is it possible to define the markup for the ajax content type, as it is with other content types? I'm trying to add the counter to a gallery of ajax items. Any guidance greatly appreciated, thanks!

I think it still would be nice to have this feature because this callback fires after the ajax request is complete. if we want to add html to the markup before, this is currently not possible, right?


TypeError: t.hasOwnProperty is not a function

Hi got
`TypeError: t.hasOwnProperty is not a function
at /home/user/Repos/next-auth-example/.next/server/app/resource-mgn-pivot/page.js:1:8273
at 3912 (/home/user/Repos/next-auth-example/.next/server/app/resource-mgn-pivot/page.js:5:13264)
at t (/home/user/Repos/next-auth-example/.next/server/webpack-runtime.js:1:128)
at 9683 (/home/user/Repos/next-auth-example/.next/server/app/resource-mgn-pivot/page.js:5:15263)
at t (/home/user/Repos/next-auth-example/.next/server/webpack-runtime.js:1:128)
at 1189 (/home/user/Repos/next-auth-example/.next/server/app/resource-mgn-pivot/page.js:1:2769)
at t (/home/user/Repos/next-auth-example/.next/server/webpack-runtime.js:1:128)
at F (/home/user/Repos/next-auth-example/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:91937)
at /home/user/Repos/next-auth-example/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:94352
at W._fromJSON (/home/user/Repos/next-auth-example/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:94790)
Error occurred prerendering page "/resource-mgn-pivot". Read more: https://nextjs.org/docs/messages/prerender-error
TypeError: t.hasOwnProperty is not a function
at /home/user/Repos/next-auth-example/.next/server/app/resource-mgn-pivot/page.js:1:8273
at 3912 (/home/user/Repos/next-auth-example/.next/server/app/resource-mgn-pivot/page.js:5:13264)
at t (/home/user/Repos/next-auth-example/.next/server/webpack-runtime.js:1:128)
at 9683 (/home/user/Repos/next-auth-example/.next/server/app/resource-mgn-pivot/page.js:5:15263)
at t (/home/user/Repos/next-auth-example/.next/server/webpack-runtime.js:1:128)
at 1189 (/home/user/Repos/next-auth-example/.next/server/app/resource-mgn-pivot/page.js:1:2769)
at t (/home/user/Repos/next-auth-example/.next/server/webpack-runtime.js:1:128)
at F (/home/user/Repos/next-auth-example/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:91937)
at /home/user/Repos/next-auth-example/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:94352
✓ Generating static pages (15/15) `
When trying to build the app under Next.js 14.0.4, not sure if you guys saw this build error before. I think this came from that the latest react-pivottable is not compatible, packages shows here
`  "dependencies": {
"@radix-ui/react-avatar": "^1.0.3",
"@radix-ui/react-collapsible": "^1.0.3",
"@radix-ui/react-dropdown-menu": "^2.0.5",
"@radix-ui/react-navigation-menu": "^1.1.3",
"@radix-ui/react-slot": "^1.0.2",
"class-variance-authority": "^0.7.0",
"clsx": "^2.0.0",
"lucide-react": "^0.274.0",
"next": "latest",
"next-auth": "beta",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-pivottable": "^0.11.0",
"tailwind-merge": "^1.14.0",
"tailwindcss-animate": "^1.0.7"
},
"devDependencies": {
"@types/node": "^18",
"@types/react": "^18.2.23",
"@types/react-dom": "^18.2.8",
"@types/react-pivottable": "^0.11.5",
"@types/react-table": "^7.7.19",
"autoprefixer": "^10.4.15",
"postcss": "^8.4.29",
"tailwindcss": "^3.3.3",
"typescript": "^5.2.2"
}`

any help would be greatly appreciated. thanks

That error occurred because the rendering of the following code used for pivot table.
import("react-plotly.js");
import dynamic from "next/dynamic";
const Plot = dynamic(() => import("react-plotly.js"), { ssr: false });
I used dynamic for import clause, and it works!


Document elevation tokens inside of Figma

Document the elevation tokens inside of the tokens page

[x] Light mode
[x] Dark mode

Done


Django/python project is shown as Javascript

https://github.com/hh8888/addressbook, is Django/python project but is shown as Javascript project.

It's because of all the JavaScript files in admin

great, thanks.


Would this be a good candidate for a Homebrew formula?

I install most of my Mac tooling via Homebrew, just wondering if someone would know better if this is a candidate for that?

I don't know the answer, but I do hope it's no! There is definitely a tension here. Supporting homebrew - in my mind - means supporting  apt / dpkg, yum / dnf / rpm and ... msi? Nice for users of these package formats / package managers, but it still leaves people in the cold (pacman) and is a lot of new knowledge / work / maintenance on this side of the fence.

Ahh, fair point - I selfishly was only thinking about one of my workflows :)

I won't object to a contribution of course. I personally won't devote time to learning 4 package formats and building this all out, but I will gladly review folks that want to contribute one or more.

Fair enough, that could be community run I suppose.

+1 for community supported packaging, and I'd be happy to contribute to the homebrew tap. (been having the same idea floating about but not yet surfacing..) :)

That would be excellent then. Maybe you two could take that over.

Hmm... I'm not sure if this will be accepted into the core homebrew tap, due to this issue for new formulas:
* GitHub repository not notable enough (<30 forks, <30 watchers and <75 stars)

It is easy enough to setup a custom tap, just slightly annoying when installing as it'll be more difficult to discover.

https://github.com/Homebrew/homebrew-core/pull/120557

As an example what that may look like, here's an small example tap: https://github.com/kaos/homebrew-shell

Is there no support for pre built binaries? It's pretty atrocious to go through the completely un-necessary work of re-building a pre-built binary. The hash will even be the same ... it's literally burning the planet down for absolutely no purpose.

Is there no support for pre built binaries? It's pretty atrocious to go through the completely un-necessary work of re-building a pre-built binary. The hash will even be the same ... it's literally burning the planet down for absolutely no purpose.

Ah, there is. That's the cask thing. I've always associated casks with "Apps", that is, mostly GUI applications, but what it really means is "install binary distribution".
I've created a cask for pants here: https://github.com/pantsbuild/homebrew-pants
@sureshjoshi please try it out see if it breaks/works for you. Seems to work for me.
@jsirois Brew seems to be supported on linux too, if you're up for it, could see if this cask formula works on linux too? 😁  (if we'd rather find out if it doesn't work than an adventurous end-user..?)

Says docker-man?!

Oh, I'm not touching docker at the moment... it's way to sluggish on ARM... :/

I may have to revisit once in a while in case there's been advancements, but a few months back it was a no-go perf wise.

That's not what I mean. I don't use brew; so would not muddy my machine, I'd test it out in a container. You could do the same.

That's not what I mean. I don't use brew; so I would not muddy my machine, I'd test it out in a container. You could do the same.

I got that.

Wow, ok.

I'll try it out tonight when I get back to a keyboard.

Ha! Ooops :)
 It seems there is already a Binary at '/usr/local/bin/pants'.

But, yes, it works!
⏺ ~/Desktop % brew install pantsbuild/pants/pants
==> Downloading https://github.com/pantsbuild/scie-pants/releases/download/v0.2.0/scie-pants-macos-x86_64
Already downloaded: /Users/sj/Library/Caches/Homebrew/downloads/bea575c6dc2edc4d3ece38ecd36120c7902cb7a10fe20fe613c2cd03dc9594f8--scie-pants-macos-x86_64
==> Installing Cask pants
==> Linking Binary 'scie-pants-macos-x86_64' to '/usr/local/bin/pants'
🍺  pants was successfully installed!

@jsirois thanks. just to be clear, it was an open question--meant mostly to highlight the possibility for this to be used on linux (and that I'm not going to explore that further)

Closing this as completed. Thanks @kaos !


Support for ES 6 modules

It would be nice to enhance this library with the "type": "module" specification. In this way also projects working with ES 6 modules could integrate easily.
Otherwise, is there a way to use this library without settings "type": "module" on the package.json?

Hey @davide97g ,
I would be happy to help with this. Do you know what changes would need to be made to support ES6 modules? PRs are also welcome!

Hey @davide97g ,
I would be happy to help with this. Do you know what changes would need to be made to support ES6 modules? PRs are also welcome!

Ok! I will try my best to set up the support for es6 modules and then I'll open the PR


live demo password?

how to login to this demo?

http://forms.viewflow.io/accounts/login/?next=/integration/city/

ok ,try admin/admin


List of items not supported

It seems that list of items is not supported?
{
 "type": "array",
 "items" : [{
          "type": "string"
         },
         {
          "type": "integer"
         },
         {
          "type": "boolean"
         }
         ]
}

I don't think this is a valid Schema. The items keyword must be an object.
If you'd like to have multiple type of items in an array, I suggesting using anyOf keyword:
{
 "type": "array",
 "items" : {
   "anyOf": [
     {"type": "string"},
     {"type": "integer"},
     {"type": "boolean"}
    ]
 }
}

I believe I've answered your question. I'm going to close this issue for now. If you, however, still think it's not resolved, feel free to reopen.


Enable transaction endorser role

see also this issue
The above patch to get issuer methods working unfortunately breaks transaction endorser mechanisms. That is because uplink fails to support Union return as is checks for the return type being a class instance, which Union is not.
This eventually/soon needs to be addressed

@TimoGlastra @vineeth14 Just created this to keep it on the radar


Adding sort option to Get Dictionary Keys Keyword

Changes for issue #3077

Looks pretty good on a quick look. I'm too busy with other tasks to do a full review, but I add the related issue to RF 3.1.2 scope so that this PR won't be forgotten.


Versions and Updates section in INSTALL.md needs an update

This section refers to build IDs while we are now using the actual version in the stack descriptions.
https://github.com/awslabs/aws-media-services-application-mapper/blob/master/docs/INSTALL.md#versions-and-updates

Duplicate of Update INSTALL.md showing stack descriptions with build timestamps #196


test: pa11y-ci action currently runs on older ubuntu version due to error when loading Chrome

We need to replace ubuntu-20.04 with ubuntu-latest in the pa11y workflow file.
We can do that when https://github.com/pa11y/pa11y/issues/651 is resolved.
There's an error when running the pa11y-ci workflow using the ubuntu-latest actions workflow runner.

When starting the HeadlessChrome instance, pa11y times out.
This leads to a difficult to debug error in pa11y-ci, because pa11y-ci doesn't pass through the debug messages.

The error looks like this:
Run npm exec -c 'pa11y http://localhost:9000/about --debug'
npm exec -c 'pa11y http://localhost:9000/about --debug'
  shell: /usr/bin/bash -e {0}

Welcome to Pa11y

 > Running Pa11y on URL http://localhost:9000/about
 > Debug: Launching Headless Chrome

Error: TimeoutError: Pa11y timed out (60000ms)
    at Timeout._onTimeout (/home/runner/work/project-portal-theme/project-portal-theme/node_modules/p-timeout/index.js:39:64)
    at listOnTimeout (node:internal/timers:559:17)
    at processTimers (node:internal/timers:502:7)

Error: Process completed with exit code 1.

Update: this still isn't working. Apparently, this is dependent on https://github.com/pa11y/pa11y/pull/664 and a corresponding update to pa11y-ci which is (apprently) coming.


demo site is not working

Dear Sir,
The demo site is not working and Can you please fix it.

It would be great if there is a working demo site.


Blocking waiting for file lock on build directory

I tried to checkout the source code of gutenberg and build it from source using:
$ cd /opt/
$ sudo git clone https://github.com/Keats/gutenberg.git
$ sudo chown -R babaei:babaei gutenberg
$ cd gutenberg
$ git submodule update --init
$ cargo build --release

But, cargo stucks with the following message:
Blocking waiting for file lock on build directory

I left it alone for half an hour or so, but it won't do anything. Furthermore, the CPU usage is very very low on my system (2 or 3 percent) which indicates it's not build anything.
This is the system I'm building it on (Funtoo Linux):
$ uname -a
Linux babaei-pc 4.9.63 #82 SMP Sat Nov 18 18:36:33 +0330 2017 x86_64 Intel(R) Core(TM) i5-2500K CPU @ 3.30GHz GenuineIntel GNU/Linux

$ cargo --version
cargo 0.21.0

$ rustc --version
rustc 1.19.0

Are you using Cargo from your IDE/text editors? That's usually the cause of that issue: https://stackoverflow.com/questions/39335774/cargo-always-starts-with-blocking-waiting-for-file-lock-on-build-directory

I don't. I do it from command-line.

Hmm maybe it's worth opening a Cargo issue if you don't have any other tools that could call Cargo. If you close the terminal, cargo clean && cargo build --release does it still hang?

Aha thanks. That did it. It starts compiling now. But, I face an error soon after in the one of the crates. My distribution ships with rustc v1.19.0. Is it compatible or I should install a different version?
$ cargo clean && cargo build --release
 Downloading num_cpus v1.7.0
 Downloading hyper v0.10.13
 Downloading percent-encoding v1.0.1
 Downloading base64 v0.6.0
 Downloading byteorder v1.1.0
 Downloading safemem v0.2.0
 Downloading sequence_trie v0.2.1
 Downloading base64 v0.7.0
 Downloading pulldown-cmark v0.1.0
 Downloading getopts v0.2.15
 Downloading syntect v1.8.1
 Downloading walkdir v1.0.7
 Downloading bincode v0.8.0
 Downloading fnv v1.0.6
 Downloading plist v0.2.3
 Downloading flate2 v0.2.20
 Downloading onig v1.6.1
 Downloading bitflags v1.0.1
 Downloading yaml-rust v0.3.5
 Downloading same-file v0.1.3
 Downloading xml-rs v0.6.1
 Downloading num v0.1.40
 Downloading num-integer v0.1.35
 Downloading num-iter v0.1.34
 Downloading miniz-sys v0.1.10
 Downloading cc v1.0.3
 Downloading rayon-core v1.3.0
 Downloading rand v0.3.18
 Downloading coco v0.1.1
 Downloading scopeguard v0.3.3
 Downloading either v1.3.0
 Downloading sass-sys v0.4.1
 Downloading pkg-config v0.3.9
 Downloading same-file v1.0.0
 Downloading atty v0.2.3
 Downloading textwrap v0.9.0
 Downloading sha1 v0.2.0
 Downloading slab v0.3.0
 Downloading mio v0.6.11
 Downloading bytes v0.4.5
 Downloading iovec v0.1.1
 Downloading lazycell v0.5.1
 Downloading net2 v0.2.31
 Downloading onig_sys v65.0.1
 Downloading cmake v0.1.27
 Downloading backtrace-sys v0.1.16
 Downloading inotify v0.3.0
 Downloading mio v0.5.1
 Downloading slab v0.1.3
 Downloading bytes v0.3.0
 Downloading nix v0.5.1
 Downloading miow v0.1.5
 Downloading bitflags v0.4.0
 Downloading ws2_32-sys v0.2.1
   Compiling rustc-serialize v0.3.24
   Compiling winapi v0.2.8
   Compiling quote v0.3.15
   Compiling sha1 v0.2.0
   Compiling matches v0.1.6
   Compiling bytes v0.3.0
   Compiling safemem v0.2.0
   Compiling itoa v0.3.4
   Compiling scopeguard v0.3.3
   Compiling unidecode v0.2.0
   Compiling traitobject v0.1.0
   Compiling pkg-config v0.3.9
   Compiling either v1.3.0
   Compiling language-tags v0.2.2
   Compiling yaml-rust v0.3.5
   Compiling unicode-xid v0.0.4
   Compiling percent-encoding v1.0.1
   Compiling fnv v1.0.6
   Compiling version_check v0.1.3
   Compiling modifier v0.1.0
   Compiling bitflags v0.4.0
   Compiling bitflags v0.7.0
   Compiling typeable v0.1.2
   Compiling pest v0.4.1
   Compiling serde v1.0.20
   Compiling libc v0.2.33
   Compiling utf8-ranges v1.0.0
   Compiling humansize v1.0.1
   Compiling slab v0.3.0
   Compiling sequence_trie v0.2.1
   Compiling strsim v0.6.0
   Compiling pulldown-cmark v0.1.0
   Compiling rayon-core v1.3.0
   Compiling regex-syntax v0.4.1
   Compiling log v0.3.8
   Compiling httparse v1.2.3
   Compiling cc v1.0.3
   Compiling getopts v0.2.15
   Compiling term v0.4.6
   Compiling slab v0.1.3
   Compiling void v1.0.2
   Compiling glob v0.2.11
   Compiling lazy_static v0.2.10
   Compiling ansi_term v0.9.0
   Compiling byteorder v1.1.0
   Compiling unicode-normalization v0.1.5
   Compiling cfg-if v0.1.2
   Compiling dtoa v0.4.2
   Compiling unicode-width v0.1.4
   Compiling same-file v0.1.3
   Compiling plist v0.2.3
   Compiling vec_map v0.8.0
   Compiling winapi-build v0.1.1
   Compiling same-file v1.0.0
   Compiling bitflags v0.9.1
   Compiling rustc-demangle v0.1.5
   Compiling num-traits v0.1.40
   Compiling lazycell v0.5.1
   Compiling bitflags v1.0.1
error: expected ident, found #
   --> /home/babaei/.cargo/registry/src/github.com-1ecc6299db9ec823/bitflags-1.0.1/src/lib.rs:423:29
    |
423 |                               #[allow(deprecated)]
    |                               ^
    |
   ::: /home/babaei/.cargo/registry/src/github.com-1ecc6299db9ec823/bitflags-1.0.1/src/example_generated.rs
    |
4   | / bitflags! {
5   | |     /// This is the same `Flags` struct defined in the [crate level example](../index.html#example).
6   | |     /// Note that this struct is just for documentation purposes only, it must not be used outside
7   | |     /// this crate.
...   |
13  | |     }
14  | | }
    | |_- in this macro invocation

error: Could not compile `bitflags`.
warning: build failed, waiting for other jobs to finish...
error: build failed

Looks like the minimum version of bitflags is 1.20 :/ (https://github.com/rust-lang-nursery/bitflags#rust-version-support).
Nothing I can do here sadly as it's a sub-dependency (or sub-sub dependency). I should download all releases of rust starting from 1.20 to see what is the minimum version required version though.

Thanks, I uninstalled my current version which was shipped with the distro and installed the latest stable (1.21.0) and that solved the issue. I can now happily utilize Gutenberg to build my new website :)
Thanks for this awesome piece of software. Keep up the good work!

Thanks a lot!


Add a sample of git pre-commit hook

@xiaoxiang781216 Clearly we are talking past each other here.  I am positive we both have the same goal: to make NuttX better. But the POV are myopic.  Possibly the language barrier is in the way. I say this because have been trying to express to you to add the "make helpers" that invokes the script with the arguments and uses make commands to get the params.
You can see this thing like this in action here:
https://github.com/PX4/Firmware/blob/master/Makefile#L321-L329

I already suggest you provide a patch

I want to make sure this subtle point is not getting lost" a patch and a PR are 2 different work flows.
I will not be providing any "patches". Now that the project has matured to using github. I will be providing PRs.

I already suggest you provide a patch to add check_format(actually check_patch may a better name) in Makefile, what I oppose is to call nxstyle directly in Makefile. It's better to call checkpatch.sh

We have been agreeing on this all along: Yes run the script for all of the functions, but do it from make with simple commands that do pieces of it AND the whole thing. make check_contrib is a better name for doing all of them it is not a patch or a PR.
The problem I see with me doing the changes is that I accept that git is part of the work flow. I would not ignore it nor would I ignore linux tools. (this is my myopic POV)
The whole non git and patch work flow is of zero value to me. So therefore I have not made changes to the makefile. I will be happy to do it, but we need buy-in from the PPMC that we are moving to a modern workflow and deprecating the less productive workflows and tools. With containers and VM dragging along support old tool, OS, and build environments puts and undo burden on the project and holds it back from using best practices.

so devloeper can get the same result in his machine as the github CI

But they will not unless they use ONLY the workflow you use, in the order you do you work. This is  because they will not have the correct version of nxstyle. This needs to be fixed.
I would not choose your work flow, as it is a waste of time cherry-pick back and forth. I also would never use patches because we now have a much better tools than that.  Did you see where Greg asked for the SPI patch to be a submitted as a PR?

If not, please enhance the description so everyone can get the benefit.

I wish I could, but it is not my tool and I am not going to reverse engineer it. I would ask you to have the person that wrote it add examples in this issue of all the commands with real arguments. I will be happy to do a PR form that if will help word it well.

BTW, how can you show something like this from Makefile naturally?

here is a start for you.
https://github.com/PX4/Firmware/blob/master/Makefile#L471-L489
I would suggest you install PX4 on ubuntu using the scriopt "ubuntu_sim_nuttx.sh: ubuntu_sim.sh + NuttX tools" found here https://dev.px4.io/v1.9.0/en/setup/dev_env_linux_ubuntu.html
and see how easy it is as a N00B to build, check the format of code, and even format code. Then you
may have a better understanding of what I have been saying about the user experience and removing barriers.
Mess up some c and h files formatting, then run
git diff
make check_format
make format
git diff
For an example of building targets try this:
make px4_<hit the tab key>
then try
`make px4_fmu-v5 menuconfig"
make some changes
then do a git diff.
All the stuff a new user has to do with nuttx can be simpler and less pron to to errors or loss of work.
Have you ever lost all you work in NuttX because you edited the copied or linked file form arch/chip?
Try an edit on a file in the bulid dir after making, In  PX4 it will not get lost.
Build 3 targets. You can also see the advantages of the out of tree build.

@xiaoxiang781216 Clearly we are talking past each other here. I am positive we both have the same goal: to make NuttX better. But the POV are myopic. Possibly the language barrier is in the way. I say this because have been trying to express to you to add the "make helpers" that invokes the script with the arguments and uses make commands to get the params.
You can see this thing like this in action here:
https://github.com/PX4/Firmware/blob/master/Makefile#L321-L329

Please tell me how can I check a specific commit id or all source files in a directory? make check_format? but it check all source files:
check_format:
	$(call colorecho,'Checking formatting with astyle')
	@"$(SRC_DIR)"/Tools/astyle/check_code_style_all.sh
	@cd "$(SRC_DIR)" && git diff --check

I have more experience with Makefile than you imagination: Makefile is a good tool but the shell script is better in some case. There is method to pass the runtime argument(e..g. commit id or directory) to Makefile, but the syntax is very urgly.

I already suggest you provide a patch

I want to make sure this subtle point is not getting lost" a patch and a PR are 2 different work flows.
I will not be providing any "patches". Now that the project has matured to using github. I will be providing PRs.

My patch mean PR here, do you saw I send any patch in email list after NuttX enter incubation? Actually I suggest that people is better to create PR many time in email list:
https://lists.apache.org/thread.html/r7583a3287ee74017e1d8d79be0306382d0e96764bea1721e1ec60f10%40<dev.nuttx.apache.org>

I already suggest you provide a patch to add check_format(actually check_patch may a better name) in Makefile, what I oppose is to call nxstyle directly in Makefile. It's better to call checkpatch.sh

We have been agreeing on this all along: Yes run the script for all of the functions, but do it from make with simple commands that do pieces of it AND the whole thing. make check_contrib is a better name for doing all of them it is not a patch or a PR.

That's fine if you want check_contrib, I just require to call checkpatch.sh.

The problem I see with me doing the changes is that I accept that git is part of the work flow. I would not ignore it nor would I ignore linux tools. (this is my myopic POV)
The whole non git and patch work flow is of zero value to me. So therefore I have not made changes to the makefile. I will be happy to do it, but we need buy-in from the PPMC that we are moving to a modern workflow and deprecating the less productive workflows and tools. With containers and VM dragging along support old tool, OS, and build environments puts and undo burden on the project and holds it back from using best practices.

You can send a VOTE to not support other version control tool.

so devloeper can get the same result in his machine as the github CI

But they will not unless they use ONLY the workflow you use, in the order you do you work. This is because they will not have the correct version of nxstyle. This needs to be fixed.

No, the patch must pass the precheck(checkpatch.sh) no matter what's workflow they use if they want to upstream their work. And checkpatch.sh must be the last version in master branch.

I would not choose your work flow, as it is a waste of time cherry-pick back and forth. I also would never use patches because we now have a much better tools than that.

How do you know my internal workflow? Xiaomi never use github internally at all, could you tell me how can I send  PR inside the company if we have internal tooling? So please don't make any assumption that my workflow is bad than yours.

Did you see where Greg asked for the SPI patch to be a submitted as a PR?

Why do you ignore my same question? I ask more than Greg. I have to list here to remember you again:
https://lists.apache.org/thread.html/r7583a3287ee74017e1d8d79be0306382d0e96764bea1721e1ec60f10%40<dev.nuttx.apache.org>

If not, please enhance the description so everyone can get the benefit.

I wish I could, but it is not my tool and I am not going to reverse engineer it.

The code is there, why you need reverse engineer?

I would ask you to have the person that wrote it add examples in this issue of all the commands with real arguments. I will be happy to do a PR form that if will help word it well.

The help usage is very clear. If you think it isn't enough plesae send a PR, thanks.

BTW, how can you show something like this from Makefile naturally?

here is a start for you.
https://github.com/PX4/Firmware/blob/master/Makefile#L471-L489

Here is the output from PX4 make:
make help
Usage: make <target>
Where <target> is one of:

aerotenna_ocpoc
airframe_metadata
airmind_mindpx-v2
all
all_config_targets
all_default_targets
alt_firmware
atlflight_eagle
atlflight_excelsior
auav_x21
av_x-v1
bitcraze_crazyflie
check
check_format
check_rtps
clang-tidy
clang-tidy-fix
clang-tidy-quiet
clean
coverity_scan
cppcheck
distclean
doxygen
excelsior_rtps
format
gazeboclean
help
holybro_durandal-v1
holybro_kakutef7
intel_aerofc-v1
list_config_targets
misc_qgc_extra_firmware
modalai_fc-v1
module_documentation
mro_ctrl-zero-f7
nxp_fmuk66-v3
omnibus_f4sd
parameters_metadata
parrot_bebop
px4_cannode-v1
px4_fmu-v2
px4_fmu-v3
px4_fmu-v4
px4_fmu-v4pro
px4_fmu-v5
px4_fmu-v5x
px4_io-v2
px4_metadata
px4_sitl
px4_sitl_default-clang
px4fmu_firmware
python_coverage
qgc_firmware
quick_check
rostest
rostest_run
scan-build
shellcheck_all
sizes
submodulesclean
submodulesupdate
tests
tests_avoidance
tests_coverage
tests_mission
tests_mission_coverage
tests_offboard
uorb_graphs
uvify_core
validate_module_configs

Or, make <config_target> [<make_target(s)>]
Use 'make list_config_targets' for a list of configuration targets.

Do you think it's clear than this:
./tools/checkpatch.sh -h
USAGE: ./tools/checkpatch.sh [options] [list|-]

Options:
-h
-c spell check with codespell(install with: pip install codespell
-r range check only (used with -p and -g)
-p <patch list> (default)
-g <commit list>
-f <file list>
-  read standard input mainly used by git pre-commit hook as below:
   git diff --cached | ./tools/checkpatch.sh -

If you have time please help PX4 community improve the above help usage, thanks.

I would suggest you install PX4 on ubuntu using the scriopt "ubuntu_sim_nuttx.sh: ubuntu_sim.sh + NuttX tools" found here https://dev.px4.io/v1.9.0/en/setup/dev_env_linux_ubuntu.html
and see how easy it is as a N00B to build, check the format of code, and even format code. Then you
may have a better understanding of what I have been saying about the user experience and removing barriers.
Mess up some c and h files formatting, then run
git diff
make check_format
make format
git diff
For an example of building targets try this:
make px4_<hit the tab key>
then try
`make px4_fmu-v5 menuconfig"
make some changes
then do a git diff.
All the stuff a new user has to do with nuttx can be simpler and less pron to to errors or loss of work.

Let me reemphasize again:
I never refuse check_format/check_contrib in Makefile!
If I said anything about this, please give me a link. What I refuse is to call nxsytle directly in Makefile.

Have you ever lost all you work in NuttX because you edited the copied or linked file form arch/chip?

No, I never lose my work. NuttX just use link.

Try an edit on a file in the bulid dir after making, In PX4 it will not get lost.

Why you complain NuttX make you lose the work?

Build 3 targets. You can also see the advantages of the out of tree build.

Please contribute your out of tree solution.
We use out of tree build, we have more complicated case than you: we have one chipset run three NuttX image on different MCU/DSP with different configuration.

I have more experience with Makefile than you imagination: Makefile is a good tool but the shell script is better in some case. There is method to pass the runtime argument(e..g. commit id or directory) to Makefile, but the syntax is very urgly.

I am sure you do and are very skilled at it. I think this is why it is so hard for you to gasp that a NOOB needs helper. This I all I am asking you to consider. Solve the simple cases for them, and they learn and grow.

Please tell me how can I check a specific commit id or all source files in a directory? make check_format? but it check all source files:

You can not - that is not what it is for. This is not a replacement for the script it is a tool for the first time contributor (We want to to grow the project)  The script does the git commands on the branch
to get the names of the change files and checks those files.
A precommit hook would be different.

That's fine if you want check_contrib, I just require to call checkpatch.sh.
Agreed!

My patch mean PR here,

I am just asking you to think about the newcomers to the project.  You and I understand your usage in context. But calling a PR a patch will get you patches emailed to you and confuse people.

Do you think it's clear than this:

Yes it tells you what to type to make the command work and has tab-completion.

How do you know my internal workflow? Xiaomi never use github internally at all, could you tell me how can I send PR inside the company if we have internal tooling? So please don't make any assumption that my workflow is bad than yours.

I do not: All I know is you told me I have to do: cherry-pick (or rebase) to master run the tools, fix the problems and submit. But If I cherry-pick to master, those commits came from somewhere and that STABLE branch is now out of syncing with ONLY the changes I am upstreaming.  This mean you have to bring those commits back to STABLE.
Compare that to:
run the tools from master on your branch fix the CS issue. Cherry-pick and submit.
It is better because there is no back and forth cherry-picking.

Why do you ignore my same question? I ask more than Greg. I have to list here to remember you again:

Sorry the link is bad.  If you use markup it will not get mangled.

The code is there, why you need reverse engineer?

Sorry that was bad wording on my part.  The elegant bash script that was submitted was to difficult for me to quickly decipher to find what the arguments should have been. I did not know we could pass HEAD to it.
Aging this fall into the category of the too skilled assuming their knowledge is common knowledge and , not understanding the needs of the newcomer.

Please contribute your out of tree solution.

It comes with cmake and nija - So this is not going to happen any time soon.
@xiaoxiang781216 What I am telling you is you are a very brilliant and skilled engineer, and need to consider making the project more inviting to those less skilled than you.

Let's close this until nxstyle is fully ready.


All templates created by polymer-cli should try to use shadow-dom if possible

I know this is not the perfect place to post this but I think it should require some decent visibility and can serve as a place of discussion.
So all the element templates that are created by polymer CLI tool by default DO NOT use shadow dom and  just operate on shady. This might be a problem long term because people might assume their components work correctly - where in fact this might be not the case because all kinds of things can go wrong if component was not written with proper encapsulation in mind.
I would suggest maybe it would make more sense to place:
  window.Polymer = {
    dom: 'shadow',
    lazyRegister: true
  };

Like PSK has to be consistent? This is a big change and has serious implications so probably needs some debate.

CC @robdodson @arthurevans @notwaldorf

I'm fine with adding it to the two templates that don't have it: application and element. It looks like starter-kit, and shop already use dom: shadow.

Given that the templates are now using Polymer 2, I think we can close this issue? @robdodson @abdonrd

i'm cool with that

Yep, thanks @TimvdLippe!


Change Puppet 4 specifics to support 3.4+

Future/Puppet 4 parser specifics have been removed to support Puppet
3.x, though requiring a minimum of 3.4 for the contain() function.

Thanks for this @domcleal! I mentioned this to some folks in #voxpupuli on Freenode today, here are some of the thoughts I fleshed out. I originally set out to make this module compatible with Puppet > 4 because I didn't want to maintain Puppet 3 compatibility and wanted to set an example for Puppet 4 modules going forward. Since releasing the module I've had a few people ask me to add backwards compatibility. I'm starting to think that my position on backwards compatibility, while principled, may not be practical.  I'm definitely interested in making this module as helpful to as many people as possible and that may mean supporting Puppet 3 for some period of time.
How long do you think we should maintain Puppet 3 compatibility, should we go forward with this?

How long do you think we should maintain Puppet 3 compatibility, should we go forward with this?

I'd want to use it for at least a year I think.  I'm hoping I may be able to add it to Foreman's installer modules, and that whole stack supports 3.x still (and only recent 4.x).

Thanks for your work on this @domcleal! Once the build goes green, I'll merge this, write up the changelog, and release as 1.0! CC: @pgassmann


Merge refs/heads/bug/error-cursor into alpha

Merge refs/heads/bug/error-cursor into alpha

This PR has been merged into alpha and tagged as 1.7.0-alpha-202306281916. Thanks for your contribution!


Add CeilometerIpmi service

Deploy ceilometer-ipmi agent on compute nodes. This change doesn't introduce a new api, this agent is deployed along with ceilometer compute agent

This depends on edpm-ansible changes https://github.com/openstack-k8s-operators/edpm-ansible/pull/208

I will wait for https://github.com/openstack-k8s-operators/edpm-ansible/pull/208 to merge before merging this one.


operator mondoo-operator (1.7.1)

Signed-off-by: Christian Zunker<EMAIL_ADDRESS>

/merge possible

/merge possible