I want to host a plugin in the Jenkins organization

Repository URL
https://github.com/synopsys-sig/synopsys-security-scan-plugin
New Repository Name
synopsys-security-scan-plugin
Description
Synopsys Security Scan for Jenkins
Synopsys Security Scan Plugin for Jenkins enables you to configure your Jenkins pipeline to run Synopsys security testing and take action on the results. Synopsys Security Scan leverages Synopsys Bridge, allowing you to run tests for several Synopsys products from the command line.

Install and configure Synopsys Security Scan plugin and Jenkins pipeline as described in the Readme section.

Synopsys Security Scan will use the following Synopsys products leveraging Synopsys-Bridge.

Polaris
Black Duck
Coverity
GitHub users to have commit permission
@sig-tithi
@kishorikumar
@dmamidisynopsys
Jenkins project users to have release permission
sig_tithi
kishorikumar
dmamidisynopsys
Issue tracker
GitHub issues

Security audit, information and commands
The security team is auditing all the hosting requests, to ensure a better security by default.
This message informs you that a Jenkins Security Scan was triggered on your repository.
It takes ~10 minutes to complete.
Commands
The bot will parse all comments, and it will check if any line start with a command.
Security team only:

/audit-ok => the audit is complete, the hosting can continue :tada:.
/audit-skip => the audit is not necessary, the hosting can continue :tada:.
/audit-findings => the audit reveals some issues that require corrections :pencil2:.

Anyone:

/request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository :mag:.
/audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings :eyes:.
	It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.26.3)

The Jenkins Security Scan discovered 16 finding(s) :mag:.
For each of them, either apply the recommended correction, suppress the warning or provide a justification.
Once you're done, either re-run the scan with /request-security-scan or request the Security team to review your justifications with /audit-review.

Remoting: Unsafe Callable
You can find detailed information about this finding here.
OsNameTask.java#22
Potentially unsafe Callable implementation OsNameTask#checkRoles

Stapler: Missing POST/RequirePOST annotation
You can find detailed information about this finding here.
SecurityScanStep.java#408
Potential CSRF vulnerability: If DescriptorImpl#doFillProductItems connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

Stapler: Missing permission check
You can find detailed information about this finding here.
SecurityScanStep.java#408
Potential missing permission check in DescriptorImpl#doFillProductItems

Jenkins: Plaintext password storage
You can find detailed information about this finding here.
ScannerGlobalConfig.java#67
Field should be reviewed whether it stores a password and is serialized to disk: polarisAccessToken

ScannerGlobalConfig.java#61
Field should be reviewed whether it stores a password and is serialized to disk: bitbucketToken

ScannerGlobalConfig.java#37
Field should be reviewed whether it stores a password and is serialized to disk: coverityConnectUserPassword

ScannerGlobalConfig.java#25
Field should be reviewed whether it stores a password and is serialized to disk: blackDuckApiToken

SecurityScanStep.java#87
Field should be reviewed whether it stores a password and is serialized to disk: bitbucket_token

SecurityScanStep.java#73
Field should be reviewed whether it stores a password and is serialized to disk: polaris_access_token

SecurityScanStep.java#57
Field should be reviewed whether it stores a password and is serialized to disk: coverity_passphrase

SecurityScanStep.java#43
Field should be reviewed whether it stores a password and is serialized to disk: blackduck_token

Api.java#17
Field should be reviewed whether it stores a password and is serialized to disk: token

Project.java#16
Field should be reviewed whether it stores a password and is serialized to disk: key

BlackDuck.java#16
Field should be reviewed whether it stores a password and is serialized to disk: token

User.java#16
Field should be reviewed whether it stores a password and is serialized to disk: password

Polaris.java#14
Field should be reviewed whether it stores a password and is serialized to disk: accessToken

/hosting re-check

/hosting re-check

Please recreate your repository using the Jenkins archetype for the maven plugin as base layout: https://www.jenkins.io/doc/developer/tutorial/create/
Choosing "4" and modifying the example java classes.

@NotMyFault
Are you requesting to restructure our repository with Maven as the build tool instead of Gradle?
If so, is this a new requirement to publish a plugin in the marketplace? As we have three plugins in the marketplace developed with Gradle.
Please checkout the repositories for the aforementioned three plugins.

synopsys-polaris-plugin

synopsys-coverity-plugin

synopsys-detect-plugin

Yes, @jahid1209 is requesting that you use Apache Maven for your plugin rather than Gradle.  The build tooling improvements that have been made over the last 12-18 months have been implemented in Apache Maven.  Jenkins core, Jenkins libraries, and the vast majority of Jenkins plugins use Apache Maven.  You'll have a better development Jenkins development experience if you use Apache Maven.
As an unrelated note, will Synopsys be removing the Prototype.js JavaScript library use from the Synopsys Coverity as noted in JENKINS-71308?  As announced in the May 2023 blog post, the Prototype.js library has been removed from Jenkins.  Weekly releases beginning with 2.426 no longer include that JavaScript library.  LTS releases beginning Nov 15, 2023 will no longer include that library.
Instructions on the steps to remove that library are in the blog post.

@MarkEWaite
Thanks for your detailed response. We will migrate our project accordingly.
Also, thanks for the heads up about Synopsys Coverity plugin. We will get back to you after necessary changes are done.

Hello @MarkEWaite Is this recommendation or absolute requirement? I am only asking since it is saying "Warning". Our current build/release pipelines are based out of gradle just like other plugins. Those all need to be changed. Can we make that change at a later point? Please advise. Thank you for your prompt responses!

I believe that @NotMyFault is trying to guide you to future success on this new plugin.  Switching this plugin from gradle to maven gives you a low risk location to explore the changes you'll need to make in your internal build and release processes.  This plugin has no users currently, since it is not yet released.  That's the safest place to learn more about the transition.
I'll leave it to @NotMyFault to answer if it is mandatory or a recommendation.  There have been discussions in the developer mailing list, but I don't recall the details of the discussions.

This seems a bit restrictive to me. Gradle is widely used and might be daunting change for existing build systems depending on the usage

If someone wants to provide and support the Maven based Jenkins tooling updates for Gradle projects, they are welcome to do so.  We've not had anyone offer to do that.  Are you interested in doing that?

Noting previous context: https://groups.google.com/g/jenkinsci-dev/c/lHQAiEepBiw/m/TiXBGbkpAwAJ

/request-security-scan

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! :tada:

:bulb: The Security team recommends that you are setting up the scan in your repository by following our guide.

/hosting re-check

/hosting re-check

Hello Jenkins hosting team! cc: @MarkEWaite and @NotMyFault
Now that all checks are complete and I believe we are good, Can you provide us en ETA if possible when hosting will be complete. Thank you for all your help!

/request-security-scan

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! :tada:

:bulb: The Security team recommends that you are setting up the scan in your repository by following our guide.

/hosting re-check

Hey @kishorikumar,
I took a brief look over your hosting request and have some feedback for you:

You picked the correct groupId in your pom (io.jenkins.plugins), but referenced the wrong class path.
https://github.com/synopsys-sig/synopsys-security-scan-plugin/tree/main/src/main/java/com/synopsys/integration/jenkins/scan should be located at io.jenkins.plugins.synopsys.security.scan, matching the groupId and artifactId.
https://github.com/synopsys-sig/synopsys-security-scan-plugin/blob/80f0aa918a26eb83e9918852c0781fc0a4a76f30/pom.xml#L31 Is obsolete and should be removed. The java version is defined at the parent pom level nowadays, and no longer on the project pom.
https://github.com/synopsys-sig/synopsys-security-scan-plugin/blob/80f0aa918a26eb83e9918852c0781fc0a4a76f30/pom.xml#L35 Instead of suppressing, I'd recommend addressing them.
https://github.com/synopsys-sig/synopsys-security-scan-plugin/blob/80f0aa918a26eb83e9918852c0781fc0a4a76f30/pom.xml#L74 is obsolete and should be removed. The version is defined in the bom.
https://github.com/synopsys-sig/synopsys-security-scan-plugin/blob/80f0aa918a26eb83e9918852c0781fc0a4a76f30/pom.xml#L79 is obsolete and should be removed. The version is defined in the bom.
Additionally, I recommend removing entries from your pom your plugin doesn't depend on.
https://github.com/synopsys-sig/synopsys-security-scan-plugin/blob/80f0aa918a26eb83e9918852c0781fc0a4a76f30/src/test/java/com/synopsys/integration/jenkins/scan/global/UtilityTest.java#L168-L169 It's unlikely that reflecting access that way done works in Java 17 or newer.

Hi @NotMyFault Than you for your feedbacks. We have addressed all the feedbacks.  Please have a look on it, re-review and provide us further feedbacks if you get any. Thank you for all your help!

/request-security-scan

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! :tada:

:bulb: The Security team recommends that you are setting up the scan in your repository by following our guide.

@NotMyFault All the items in your last comment are addressed now. Can you please let us know the ETA for hosting on "jenkinsci" org to be complete? Thank you for all your help.

/hosting host


How to scan RefCursor to map

func queryCursor(crows *go_ora.RefCursor) (list []map[string]interface{}, n int) {
srows, err := crows.Query()
if err != nil {
}
defer srows.Close()
defer crows.Close()
columns := srows.Columns()
//转换Oracle列名 小写
for i := 0; i < len(columns); i++ {
columns[i] = strings.ToLower(columns[i])
}
columnLength := len(columns)
cache := make([]interface{}, columnLength) //临时存储每行数据地址
for index := range cache {                 //为每一列初始化一个指针
var a interface{}
cache[index] = &a
}
n = 0
//scan to map
for srows.Next_() {
_ = srows.Scan(cache...)
item := make(map[string]interface{})
for i, data := range cache {
item[columns[i]] = *data.(*interface{}) //取实际类型
}
list = append(list, item)
n++
}
result   is  nil

there is an error return from rows.Scan(cache...)

fixed in next release

If RefCursor can be directly converted to sqlrows, it can be directly scan to map and struct using gorm；
The type of driver.rows used by the output cursor of the Godror library; You can use the godror.WrapRows function to convert to sql.rows

fixed in next release

tested ，ok

Just the implicit conversion that occurs internally when the cursor returned by the query function, and how to convert if the cursor returned by the stored procedure is executed

I define a new function WrapRefCursor same as WrapRows in last commit that convert *RefCursor into *sql.Rows

I don't see this function in the latest v2.7.16

last commit still not release.
it will be release in v2.7.17

released


paymentService.invoices.create throwing BAD_REQUEST_ERROR (The name format is invalid.)

We started getting the error stated in the title with 400 status.
            const createResponse = await paymentService.invoices.create(data);

Is there any restriction on the customer name length(I tried with 2 character customer name)? If so can you please have it in the api doc if anything like that exists?

Facing the same issue. Did you find anything related to this?

@gowthamvbhat A customer name should at least contain three characters . let us know if this issue is still persist

@ankitdas13 Why is this restriction in place? Couldn't find any documentation on it.

@gowthamvbhat @manwithsteelnerves You are right! We should add this in our documentation.
We will keep this issue open till our documentation is amended.

@kkyusufk If you don't mind, can you share why this restriction is in place? I have observed the same in other services

@gowthamvbhat Thats our business requirement, we do not allow less than 3 characters for first name.

@kkyusufk Ah! Thank you


Clarifications on EdgeRouter setup

Wanted confirmation on the setup for the EdgeRouter - just edit the eap sh script with proper devices / mac addresses go?
I noticed you had additional sample configuration, and was hoping for clarification on what if anything needed to be done with that.
Thank you!

The sample is there for guidance. I don't recommend making using eap_proxy unless you understand the configuration. Good luck.


⚠ Bofrost.at has degraded performance

In b4b49b4, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2108 ms

Resolved: Bofrost.at performance has improved in 5e98235.


[DEBUG] lastUpdated Not Displaying

It works locally, but somehow broken on Github. The built artifact on CI doesn't generate date info. Need to tweak CI for more debug info.

So the problem is f**king safe directory...
And it seems that ubuntu's git already patches to ignore safe directory anyway: https://github.com/Locietta/github-action-playground/actions/runs/12272623791/job/34241735785 So if strictly copy the deploy workflow from the official documentation, you won't hit the issue. But unluckily, I'm using alpine for deploy.
The vitepress build procedure doesn't give any warning and silently fail though, which is kinda confusing. But the fix is easy.


Bump UI_PLUGIN_API_VERSION

Summary

According to Rancher Extension Support Matrix (https://extensions.rancher.io/extensions/next/support-matrix) we should use 1.2.3 for Rancher 2.8. Indeed when I used trailing annotation, install button of the app was not shown.
"catalog.cattle.io/ui-extensions-version": ">= 1.2.3 < 2.0.0"

Occurred changes and/or fixed issues

Resolves #12724.
Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

[ ] The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
[ ] The PR has a Milestone
[ ] The PR template has been filled out
[ ] The PR has been self reviewed
[ ] The PR has a reviewer assigned
[ ] The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
[ ] The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@masap this annotation is not needed in this branch/rancher version since it only became mandatory when we released shell 3.0.0. This annotation won't have any effect.

Ah ok sorry for confusion.


flutter run breaks if at least one custom flavor is specified

If you specify at least one productFlavor in gradle, flutter run options --debug and --profile fail to work.
Steps to Reproduce

Specify a productFlavor, e.g.

productFlavors {
    fdroid {
        dimension "deploy"
        signingConfig null
    }
}

Run flutter run (optionally with --debug or --profile flags)
Observe error message:

The Gradle project does not define a task suitable for the requested build.
The android/app/build.gradle file defines product flavors: fdroid
You must specify a --flavor option to select one of them.
Gradle build aborted.

Logs
End of output of flutter run --debug -v
[  +26 ms] Android Debug Bridge version 1.0.40
           Version 4986621
           Installed as /home/user/Android/Sdk/platform-tools/adb
[   +1 ms] executing: /home/user/Android/Sdk/platform-tools/adb start-server
[  +13 ms] Building APK
[   +8 ms] The Gradle project does not define a task suitable for the requested build.
[   +1 ms] The android/app/build.gradle file defines product flavors: fdroid
[        ] You must specify a --flavor option to select one of them.
[   +7 ms] "flutter run" took 3,665ms.
Gradle build aborted.

#0      throwToolExit (package:flutter_tools/src/base/common.dart:26:3)
#1      _buildGradleProjectV2 (package:flutter_tools/src/android/gradle.dart:345:7)
<asynchronous suspension>
#2      buildGradleProject (package:flutter_tools/src/android/gradle.dart:300:14)
<asynchronous suspension>
#3      buildApk (package:flutter_tools/src/android/apk.dart:43:10)
<asynchronous suspension>
#4      AndroidDevice.startApp (package:flutter_tools/src/android/android_device.dart:379:13)
<asynchronous suspension>
#5      FlutterDevice.runHot (package:flutter_tools/src/resident_runner.dart:289:54)
<asynchronous suspension>
#6      HotRunner.run (package:flutter_tools/src/run_hot.dart:272:39)
<asynchronous suspension>
#7      RunCommand.runCommand (package:flutter_tools/src/commands/run.dart:398:37)
<asynchronous suspension>
#8      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:401:18)
<asynchronous suspension>
#9      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:335:33)
<asynchronous suspension>
#10     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:142:29)
<asynchronous suspension>
#11     _rootRun (dart:async/zone.dart:1124:13)
#12     _CustomZone.run (dart:async/zone.dart:1021:19)
#13     _runZoned (dart:async/zone.dart:1516:10)
#14     runZoned (dart:async/zone.dart:1463:12)
#15     AppContext.run (package:flutter_tools/src/base/context.dart:141:18)
<asynchronous suspension>
#16     FlutterCommand.run (package:flutter_tools/src/runner/flutter_command.dart:326:20)
#17     CommandRunner.runCommand (package:args/command_runner.dart:196:27)
<asynchronous suspension>
#18     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:401:21)
<asynchronous suspension>
#19     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:142:29)
<asynchronous suspension>
#20     _rootRun (dart:async/zone.dart:1124:13)
#21     _CustomZone.run (dart:async/zone.dart:1021:19)
#22     _runZoned (dart:async/zone.dart:1516:10)
#23     runZoned (dart:async/zone.dart:1463:12)
#24     AppContext.run (package:flutter_tools/src/base/context.dart:141:18)
<asynchronous suspension>
#25     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:361:19)
<asynchronous suspension>
#26     CommandRunner.run.<anonymous closure> (package:args/command_runner.dart:111:29)
#27     new Future.sync (dart:async/future.dart:224:31)
#28     CommandRunner.run (package:args/command_runner.dart:111:11)
#29     FlutterCommandRunner.run (package:flutter_tools/src/runner/flutter_command_runner.dart:241:18)
#30     run.<anonymous closure> (package:flutter_tools/runner.dart:60:20)
<asynchronous suspension>
#31     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:142:29)
<asynchronous suspension>
#32     _rootRun (dart:async/zone.dart:1124:13)
#33     _CustomZone.run (dart:async/zone.dart:1021:19)
#34     _runZoned (dart:async/zone.dart:1516:10)
#35     runZoned (dart:async/zone.dart:1463:12)
#36     AppContext.run (package:flutter_tools/src/base/context.dart:141:18)
<asynchronous suspension>
#37     runInContext (package:flutter_tools/src/context_runner.dart:43:24)
<asynchronous suspension>
#38     run (package:flutter_tools/runner.dart:51:10)
#39     main (package:flutter_tools/executable.dart:51:9)
<asynchronous suspension>
#40     main (file:///b/build/slave/Linux_Flutter_Packaging/build/archive/flutter/packages/flutter_tools/bin/flutter_tools.dart:8:3)
#41     _startIsolate.<anonymous closure> (dart:isolate/runtime/libisolate_patch.dart:287:32)
#42     _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:171:12)

Output of  flutter doctor -v:
[✓] Flutter (Channel stable, v1.0.0, on Linux, locale en_US.UTF-8)
    • Flutter version 1.0.0 at /home/user/flutter
    • Framework revision 5391447fae (3 months ago), 2018-11-29 19:41:26 -0800
    • Engine revision 7375a0f414
    • Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)

[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
    • Android SDK at /home/user/Android/Sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /opt/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
    • All Android licenses accepted.

[✓] Android Studio (version 3.2)
    • Android Studio at /opt/android-studio
    • Flutter plugin version 31.3.1
    • Dart plugin version 181.5656
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)

[✓] Connected device (1 available)
    • mydevice

Looks like a duplicate of #22856


Tagged releases

Could you make the tagged release on GitHub?
I am using dafny which requires boogie to build. The official release of dafny uses the last version of boogie (i.e. git clone https://github.com/boogie-org/boogie). This makes every build be different from the last and that's hard to debug if anything wrong during the build.
I noticed that you do maintain versions under "Source/version.cs", but there are no official releases on Github.

I second this. My perspective is a little different; I work on Debian in my spare time, and I noticed that the Debian package for boogie is quite outdated and in bad shape.
I briefly considered trying to fix this, but then I noticed that there aren't any tagged releases in the Boogie GitHub repository. This makes it difficult to know which commit should be used to update the Debian package; usually, we only package somewhat "polished" proper releases in order to avoid accidentally packaging a malfunctioning work-in-progress snapshot or something like that.
So, providing official tagged releases would help here, too (and I'm sure this also applies to other distributions beside Debian (at the very least, it does to Ubuntu et al., which are based on Debian)).

We rely on Boogie in various projects, and currently we pull it based on a hash of a particular commit to make sure our tools are released with a fixed version of Boogie. So having more official tagged releases would be helpful.
I propose that Boogie adopts the following git branching model:
https://nvie.com/posts/a-successful-git-branching-model/
In short, all development happens in the develop branch, while master branch is used only for releases. That way master branch can be "locked" so that only one-two people can push to it, which would be those that are also doing releases. We could agree on creating a release every 6 months let's say.

https://github.com/boogie-org/boogie/releases/tag/v1.0.0
I have created the first tagged release for Boogie.

@shazqadeer: I think the tagged releases should be consistent with what is in Source/version.cs (currently 2.4.1; I don't know what the trailing .10503 in the assembly version means). In particular, starting with 1.0.0 will be confusing for existing Boogie packages, for example the Debian package referenced above.
Regarding @zvonimir's suggestion: I think a separate development branch is not necessary. If (as it is already the case now) every new development is done in a separate branch/fork and goes through a pull request, then the one-two responsible people can just create a release by tagging a commit on the master branch.

I have renamed the release v2.4.1 (deleted the old one with the incorrect version number).
@RustanLeino : FYI.

Great. Thanks, @shazqadeer !
@bkragl , The history behind the trailing .10503 is that .NET assembly version numbers expected a fourth number. This particular number denotes May 3 of the year 2018+1. The year used to be an offset from 2008, but was changed to 2018 when it was no longer possible to use one decimal digit for the offset.


Added warning regarding the limitations of the wicket:enclosure-tag

A small update of the user guide pointing out the limitations of the wicket:enclosure-tag by just copying the JavaDoc of the EnclosureContainer.

Thank you, @JoachimRohde !


Add Textfield border

This PR add the withBorder property to the TextField component to be able to display the TextField with a themed border.
Without border :

With border :

Codecov Report

Merging #531 (1a38cad) into main (e88ec8a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #531   +/-   ##
=======================================
  Coverage   96.34%   96.34%
=======================================
  Files          70       70
  Lines         847      847
  Branches      124      124
=======================================
  Hits          816      816
  Misses         29       29
  Partials        2        2

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

:tada: This PR is included in version 1.18.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


PP-10642: Adds information about responsibilities and feature support

Context
For PP-10455https://payments-platform.atlassian.net/browse/PP-10455) and PP-10489, we created records of what services are responsible for when taking recurring payments and what optional Pay features are supported when taking recurring payments.
Changes proposed in this pull request
This PR:

adds additional responsibilities for services
changes wording of existing responsibilities
adds a list of supported Pay features

I've completed the pre-i and left a couple of comments that are just structural checks. Otherwise it looks good.


hbase: include hadoop native libs

Add hadoop native libs to image to so that compression (lz4, bzip2) can be applied to tables.
Don't merge - this is for compression tests only at the moment.
TODOs

hadoop version is currently hard-coded as the latestone (3.3.4). Do we want to add this to the argument matrix, or are the native libs static enough for it not to matter?
currently this adds the whole hadoop install, which makes the image really large. Only the native libs should be added.

Superseded by changes in branch compression_test_malte


feat: add dashboard templates, version 0.1.0 without server side functionality

This PR successfully replicates the original PR to allow for a linear merge history.

@jonas-rem successfully replicates #40 , with a single commit linear history. Have linked to the original PR incase someone would want to follow the history. 👍😄

Great, looks better now after squashing!


Support organization code filtering when fetching user course enrollments

Description
OSPR-1879
This PR uses the ORG_CODE set on config.yml to filter the course enrollments of a user when trying to fetch the videos in the background.
How to test this PR
Run the app with an ORG_CODE set on config.yml. When fetching videos in the background it should return only course enrollments for that specific organization.
Reviewers

[ ] Code review: @saeedbashir
[ ] Code review: @salman2013

cc @marcotuts @nedbat

Thanks for the pull request, @jagonzalr! I've created OSPR-1993 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.
Feel free to add as much of the following information to the ticket:

supporting documentation
edx-code email threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.
If you like, you can add yourself to the AUTHORS      file for this repo, though that isn't required.     Please see the CONTRIBUTING     file for more information.

@edx/mobile-product I don't know enough here to know whether this needs a product review.  Thoughts?

I'm on holiday until the 8th of January, please don't close this PR.

I can answer for product on this. I'm surprised we never implemement the filter on iOS. We did it for Android a year ago. https://github.com/edx/edx-app-android/pull/863

@edx/ios-devs Please review.

@jagonzalr Can you please rebase your branch with origin/master?

@saeedbashir done

@jagonzalr Could you please spare few minutes for this PR?

Done @saeedbashir

@saeedbashir I fixed the name but left the function to return a NSMutableString since the original url is a NSMutableString and this
else if ([type isEqualToString:URL_COURSE_ENROLLMENTS]) {
    URLString = [[OEXInterface sharedInterface] formatEnrollmentURLWith:URLString];
}

in both OEXNetworkInterface.m and OEXInterface.m expects a NSMutableString

@jagonzalr Everything is seems good. Could you please add tests for the newly added code?

done @saeedbashir

@jagonzalr @saeedbashir Where are we with this discussion? Have the necessary tests been added?

@mduboseedx I'm busy with other high priority tasks. I will come back to this soon.

@saeedbashir I made the changes but the tests is not detecting the current session or when I pass the ORGANIZATION_CODE to the config. Is there something I'm missing?

I made the changes but the tests is not detecting the current session

You have to call OEXSession.setShared(session) for setting session in mockSessionCredentials

when I pass the ORGANIZATION_CODE to the config. Is there something I'm missing?

TestRouterEnviornment and RouterEnviornment are two different entities that's why we pass enviornment from one controller to other. What you can do is, you can pass ORGANIZATION_CODE  or enviornment or config to formatEnrollmentURL

Done @saeedbashir your suggestion did the trick and tests are passing.


unreadable text at the unfocused display menubar

and yeah, that album art tend to disappear after some time

looked trough the code - album art is actually just an button ui element icon, which is likely supposed to not to be at the center
maybe you just using another macOS version with different ui elements handling or idk

Yep, saw someone commented this too. I'll try to figure what happened, and sort it out. But if you have some ideas how to fix this, it would be awesome!

But if you have some ideas how to fix this, it would be awesome!

firstly:
https://developer.apple.com/documentation/appkit/nscontrol/imageposition
you don't set it anywhere, so it fallbacks to something, which is right in your case, but not in mine (different macOS version or idk)
secondly:
not sure about "appearsDisabled", but maybe this is it:
https://developer.apple.com/documentation/appkit/nsstatusbarbutton
maybe this could help too:
https://developer.apple.com/documentation/uikit/uimenuelement/attributes

not sure why image is "unavailable", according to the checkAvailability function, which is replacing it by rays
I'd prefer to have ♪ symbol instead of that rays spinner in that cases
or maybe after some timeout when it's clearly that something wrong with album art fetching

not sure why image is "unavailable", according to the checkAvailability function, which is replacing it by rays
I'd prefer to have ♪ symbol instead of that rays spinner in that cases
or maybe after some timeout when it's clearly that something wrong with album art fetching

yeah, this seems to be a good fit for the icon, will definitely edit that!

edited that, could you try cloning the latest commit in fix-status-bar?

yep, unreadable text is fixed

it's still occurring as soon, as actual album art is fetched (I opened video, and it was ok on the other screen until image is fetched)
for me album arts is loading mostly for YouTube, Spotify is remaining without it most of the time (but I remember that it actually worked few times, which is strange enough)
so yeah, seems like that fix applied only for non-image style

yep, seems like a weird thing again. Mine doesn't show the art even. So I guess it's a Catalina problem again😥
I'll try to find a workaround

I'll take a look at this in a later date, if it's still occurring, please open a new issue or tag me here!


callback function for playOnce is called multiple times

My callback function is called repeatedly after the first time I called playOnce.
After the emitter has finished update still is called and this._completeCallback(); keeps being called because its not emitting and there are no active particles.
Maybe this._completeCallback should be nullified?
		//if we are all done and should destroy ourselves, take care of that
		if (!this._emit && !this._activeParticlesFirst)
		{
			if (this._completeCallback)
			{
				this._completeCallback();
			}
			if (this._destroyWhenComplete)
			{
				this.destroy();
			}
		}

Exactly the same here, using PIXI V5

Yep, the callback should be nulled. It works fine with playOnceAndDestroy(), but not playOnce().


fix: use standard side effects

Removes non-standard "sideEffects": false from package.json of @digirdir/designsystemet-react
This is a property only supported by Webpack and by Vite/Rollup
This property caused issues when importing Designsystemet into another project and then building with Vite - aka. an issue that is non-detectable in our own repository
Have verified with Øyvind this was just something originally copied from Altinn without further intentions
Many thanks to @unekinn for very good pinpong on resolving this issue <3

Vite building with non-standard "sideEffects": false:

Vite building when removing non-standard "sideEffects": false:

Does tree-shaking still work?

Just did a quick test with only using Accordion, and removing this causes a false positive. Its working because tree-shaking i no longer working and everything is bundled together 😩
The culprit is that to much is being tree-shaked away, its for example missing @u-elements/u-details which is suspect is causing this for only Accordion?
With:

Without sideEffect:false:

The culprit is that to much is being tree-shaked away, its for example missing @u-elements/u-details which is suspect is causing this for only Accordion?

Indeed, this was Eirik's initial finding. My hunch was that maybe @u-elements/u-details needed "sideEffects": true in its package.json, but looking into it that is the default behaviour when the property is unset.
I suspect we might need to specify all files which have side-effectful imports of @u-elements/*  in "sideEffects": [...filesWithSideEffects], which is a hassle 😭

A second note, setting "sideEffects": false normally shouldn't be required to get working tree-shaking, so I find that behaviour a bit weird. Might there be other reasons why tree-shaking doesn't work? E.g. circular dependencies (very easy to accidentally do with barrel index.ts files)

A second note, setting "sideEffects": false normally shouldn't be required to get working tree-shaking, so I find that behaviour a bit weird. Might there be other reasons why tree-shaking doesn't work? E.g. circular dependencies (very easy to accidentally do with barrel index.ts files)

yes we do have some circular dependencies.
They can be seen when building the package

A second note, setting "sideEffects": false normally shouldn't be required to get working tree-shaking, so I find that behaviour a bit weird. Might there be other reasons why tree-shaking doesn't work? E.g. circular dependencies (very easy to accidentally do with barrel index.ts files)

I thought it was need as long as we live in a world with cjs and esm modules? I think most component libraries out there have this in their package.json, due to this reason.
I did fix our circular dependencies during summer, but looks like we got some new ones now 🙈

Here's the current circular dependencies in packages/react on next
I'd prefer to set up a check in CI to keep these from popping up
> npx dpdm --no-warning --no-tree src/index.ts

✔ [174/174] Analyze done!
• Circular Dependencies
  01) src/components/index.ts -> src/components/Button/index.ts -> src/components/Button/Button.tsx
  02) src/components/form/Fieldset/FieldsetContext.ts -> src/components/form/useFormField.ts
  03) src/components/form/Select/Select.tsx -> src/components/form/Select/useSelect.ts
  04) src/components/Pagination/Pagination.tsx -> src/components/Pagination/PaginationButton.tsx -> src/components/Pagination/PaginationRoot.tsx
  05) src/components/Pagination/Pagination.tsx -> src/components/Pagination/usePagination.ts
  06) src/components/form/Checkbox/Checkbox.tsx -> src/components/form/Checkbox/useCheckbox.ts
  07) src/components/form/Radio/Radio.tsx -> src/components/form/Radio/useRadio.ts
  08) src/components/form/Switch/Switch.tsx -> src/components/form/Switch/useSwitch.ts
  09) src/components/form/Textfield/index.ts -> src/components/form/Textfield/Textfield.tsx -> src/components/form/CharacterCounter.tsx
  10) src/components/form/Textfield/Textfield.tsx -> src/components/form/Textfield/useTextfield.ts
  11) src/components/form/Textarea/Textarea.tsx -> src/components/form/Textarea/useTextarea.ts
  12) src/components/ToggleGroup/ToggleGroupItem.tsx -> src/components/ToggleGroup/useToggleGroupitem.ts
  13) src/components/form/Search/Search.tsx -> src/components/form/Search/useSearch.ts
  14) src/components/form/Combobox/Combobox.tsx -> src/components/form/Combobox/ComboboxContext.tsx
  15) src/components/form/Combobox/Combobox.tsx -> src/components/form/Combobox/ComboboxContext.tsx -> src/components/form/Combobox/useCombobox.tsx
  16) src/components/form/Combobox/ComboboxContext.tsx -> src/components/form/Combobox/useCombobox.tsx -> src/components/form/Combobox/Custom.tsx
  17) src/components/form/Combobox/ComboboxContext.tsx -> src/components/form/Combobox/useCombobox.tsx -> src/components/form/Combobox/Option/Option.tsx
  18) src/components/form/Combobox/ComboboxContext.tsx -> src/components/form/Combobox/useCombobox.tsx -> src/components/form/Combobox/Option/Option.tsx -> src/components/form/Combobox/Option/useComboboxOption.tsx
  19) src/components/form/Combobox/Option/Option.tsx -> src/components/form/Combobox/Option/useComboboxOption.tsx -> src/components/form/Combobox/utilities.ts
  20) src/components/form/Combobox/Option/Option.tsx -> src/components/form/Combobox/Option/useComboboxOption.tsx -> src/components/form/Combobox/utilities.ts
  21) src/components/form/Combobox/Combobox.tsx -> src/components/form/Combobox/internal/ComboboxError.tsx
  22) src/components/form/Combobox/Combobox.tsx -> src/components/form/Combobox/internal/ComboboxInput.tsx
  23) src/components/form/Combobox/Combobox.tsx -> src/components/form/Combobox/internal/ComboboxLabel.tsx
  24) src/components/form/Combobox/Combobox.tsx -> src/components/form/Combobox/internal/ComboboxNative.tsx

Here's the current circular dependencies in packages/react on next
I'd prefer to set up a check in CI to keep these from popping up
> npx dpdm --no-warning --no-tree src/index.ts
…

Interesting, I just used rollups warning during build, which is substantially less 🤔

As a comparison, here is a report from madge which I have also used before (bonus: also supports css)
> npx madge --extensions ts,tsx ./src --circular

Processed 270 files (1.2s) (8 warnings)

✖ Found 23 circular dependencies!

1) components/index.ts > components/Button/index.ts > components/Button/Button.tsx
2) components/Pagination/Pagination.tsx > components/Pagination/PaginationButton.tsx > components/Pagination/PaginationRoot.tsx
3) components/Pagination/Pagination.tsx > components/Pagination/usePagination.ts
4) components/ToggleGroup/ToggleGroupItem.tsx > components/ToggleGroup/useToggleGroupitem.ts
5) components/form/Checkbox/Checkbox.tsx > components/form/Checkbox/useCheckbox.ts
6) components/form/Fieldset/FieldsetContext.ts > components/form/useFormField.ts
7) components/form/Combobox/Combobox.tsx > components/form/Combobox/ComboboxContext.tsx
8) components/form/Combobox/Combobox.tsx > components/form/Combobox/ComboboxContext.tsx > components/form/Combobox/useCombobox.tsx
9) components/form/Combobox/ComboboxContext.tsx > components/form/Combobox/useCombobox.tsx > components/form/Combobox/Custom.tsx
10) components/form/Combobox/ComboboxContext.tsx > components/form/Combobox/useCombobox.tsx > components/form/Combobox/Option/Option.tsx
11) components/form/Combobox/ComboboxContext.tsx > components/form/Combobox/useCombobox.tsx > components/form/Combobox/Option/Option.tsx > components/form/Combobox/Option/useComboboxOption.tsx
12) components/form/Combobox/Option/Option.tsx > components/form/Combobox/Option/useComboboxOption.tsx > components/form/Combobox/utilities.ts
13) components/form/Combobox/Combobox.tsx > components/form/Combobox/internal/ComboboxError.tsx
14) components/form/Combobox/Combobox.tsx > components/form/Combobox/internal/ComboboxInput.tsx
15) components/form/Combobox/Combobox.tsx > components/form/Combobox/internal/ComboboxLabel.tsx
16) components/form/Combobox/Combobox.tsx > components/form/Combobox/internal/ComboboxNative.tsx
17) components/form/Radio/Radio.tsx > components/form/Radio/useRadio.ts
18) components/form/Search/Search.tsx > components/form/Search/useSearch.ts
19) components/form/Select/Select.tsx > components/form/Select/useSelect.ts
20) components/form/Switch/Switch.tsx > components/form/Switch/useSwitch.ts
21) components/form/CharacterCounter.tsx > components/form/Textfield/index.ts > components/form/Textfield/Textfield.tsx
22) components/form/Textfield/Textfield.tsx > components/form/Textfield/useTextfield.ts
23) components/form/Textarea/Textarea.tsx > components/form/Textarea/useTextarea.ts

Hmm, this definitely needs more testing. I suggest we make a separate issue for this to properly document this.
I would say the root problem here is tree-shaking not working correctly, as to whats the root cause of it remains to be discovered and fixed.
With or without "sideEffects": false, I understood its a common practice used by all component libraries? It should either way with it enabled also.

I thought it was need as long as we live in a world with cjs and esm modules? I think most component libraries out there have this in their package.json, due to this reason.

I think it is necessary for optimal tree shaking, but in the last library I worked on it made a smaller difference than turning tree shaking off entirely. At least with vite. This stuff is complex 😢
Anyhow. If possible, we should keep "sideEffects": false or use the array form to specify the files which have side effects. It would be ideal if this could be solved by u-elements, but I'm not sure how. Currently, each custom element js file has a side effect which does e.g.
customElements.define("u-details", UHTMLDetailsElement);
customElements.define("u-summary", UHTMLSummaryElement);

We could conceivably ask our consumers to do the customElements.define calls, but it's a hassle for them, and it requires knowledge of which of our components use which custom element

@eirikbacker Can you check if the code works if we replace "sideEffects": false with this?
  "sideEffects": ["./src/components/Accordion/AccordionItem.tsx"],

If it works, it's annoying to maintain manually. I experimented a bit and managed this magic incantation which finds files that depend on @u-elements, which could be expanded to a script to keep the sideEffects array updated 🤔
> npx madge ./src/index.ts --json --include-npm | npx repdeps -x<EMAIL_ADDRESS>-r '@u-elements' | npx madge --stdin --depends '@u-elements' --json

output:
[
  "components/Accordion/AccordionItem.tsx"
]

Hmm, this definitely needs more testing. I suggest we make a separate issue for this to properly document this.

Created an issue at #2474

Hmm, this definitely needs more testing. I suggest we make a separate issue for this to properly document this.

Created an issue at #2474

Nice! I have added it as part of #2475 as I suspect this will take some time to figure out.


[Bug] Strict mode does not allow function declarations in a lexically nested statement

I'm not quite sure why this issue is appearing. It seems to happen currently whenever I open the app I'm debugging and select "Stop Remote JS Debugging" after shaking.

When I visit the URL it refers to I get this blob: https://gist.githubusercontent.com/jamesqo/044cc1e4509e965af63007d603db1ef4/raw/784934ffc33be6f279575570c82dbaf69ed21ece/glob.json
It doesn't leave a stack trace of the location in the code where this occurs, so I assume the problem is with one of the JS scripts in the blob?

similar issue here too :(
don't know how to make sense of this.


Clarification on loss_adv and loss

Hi,
It seems that loss_adv and final loss are not the same as eq.8 and eq.9 in the paper (https://arxiv.org/pdf/1705.09655.pdf).
https://github.com/shentianxiao/language-style-transfer/blob/f078a9d342705ea62b04dd3ac5926d3467c2ac63/code/style_transfer.py#L131
https://github.com/shentianxiao/language-style-transfer/blob/f078a9d342705ea62b04dd3ac5926d3467c2ac63/code/style_transfer.py#L132
Any additional tricks / optimizations in the implementation?

Looking back at the previous git versions of the code, you would find out that the author changed the formulation of the losses in the code several months after having published the article. In particular, it looks like the author opted for the non-saturating loss formulation as suggested in the paper "Generative Adversarial Networks" (Goodfellow et al. - 2014) .

Ah, yes. You are right @WolfLo . Thanks!
Reference: 78380ae822d5f951a415acc7f89433d75169f0e1


stop collector

Hi,
I have a program written with colly and I have an issue with how can I stop the collector, the site I scrapping will never end because have too much data and I need to stop the collector.
It's possible to stop by channels but if the program has this feature already or can we add this to the project it will be great.

You can abort all requests.
c.OnRequest(func(r *colly.Request) {
  if cond {
    r.Abort()
  }
})

Also this


Update README examples

The commands did not work properly if the folder is not specified correctly.

@rtgdk Thanks. let me review this

Can you squash these commits?

@pombredanne  Commits squashed.

@rtgdk Thanks. Let me review and merge. @sschuberth would you know why travis and appevyor runs are not complete? I did not check the details though.

@pombredanne No idea why Travis CI and AppVeyor did not report back their statuses, as they seem to have build something, but I'm not seeing commit 4064a2b in there... let's see if this happens again for the next PR.

@rtgdk Thanks!


filter out disposable emails

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@aa740e5). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head d71e61f differs from pull request most recent head b71b639. Consider uploading reports for the commit b71b639 to get more accurate results

@@             Coverage Diff             @@
##             develop        #2   +/-   ##
===========================================
  Coverage           ?   100.00%
===========================================
  Files              ?         3
  Lines              ?        66
  Branches           ?         7
===========================================
  Hits               ?        66
  Misses             ?         0
  Partials           ?         0

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[RELEASE TRACK] 2.0.1 Bug List & Known Issues (v2.0.2 Changes)

Known Bugs - v2.0.1
This issue is an umbrella issue to keep track of bugs in the current version.  You can reply directly here, but opening a new issue would make life easier for us.
Issue List

[x] Duplicate L10N code #66 02161f0
[x] Color themes (system) #67 b4386cd cb71308
[x] Ability to select all/none in the Copy Favorites and Import screens.  02161f0
[x] We like the new titlebar on main window, repeat that change through the app. cb71308
[x] Allow canceling of direct dedi download. #68 ba95726
[x] "Deactivated" shows as "Unknown" caa9cbb
[x] Documentation is already outdated, rebuild.
[ ] Need the context clues a bit more clear on the detail window #73
[x] It'd be nice to be able to open the modhub page for a mod direct from the savegame compare screen

Is it possible for the slider on the scroll bar to have a more contrasting color?  It's hard to see where he is right now.

Is it possible for the slider on the scroll bar to have a more contrasting color? It's hard to see where he is right now.

Heh.  I was thinking this just last night.  Yeah, I'll give it a tweak.

Heh. I was thinking this just last night. Yeah, I'll give it a tweak.

Only the slider (and labels for the location of the selected mods), not the background of the scrollbar:

Is it possible, when viewing the log, to add commands to the context menu by right-clicking the mouse?

Is it possible, when viewing the log, to add commands to the context menu by right-clicking the mouse?

Sure.  You want it by line, or by highlighted text? (highlighted seems to make more sense to me)

by highlighted text?

Letter case in mod names should not be taken into account.
Due to the decrease in the distance between the characters in the category names (if there was any), the inscriptions became difficult to read.

Letter case in mod names should not be taken into account. [done]
Due to the decrease in the distance between the characters in the category names (if there was any), the inscriptions became difficult to read.

How bout this for the tags?

Lightened the weight of the font, upped the size, and added some extra spacing between letters.  Agreed, it was hard to read

Как насчет тегов?
Уменьшен вес шрифта, увеличен размер и добавлен дополнительный интервал между буквами. Согласен, тяжело читать
Great. Thank you very much.

If it's not difficult, raise the text of titles/tags by 1 px (no more) up. Now (2.0.10) is too low, not very nice.

Closing in favor of #77 - thank you for all your bug reporting efforts!


Initial feedback

Hi Cyril @cyrezdev
First, WOW. What a project this is, It is impressive, one of the best iterations of an APCA based library I've seen, possibly the best——I have not exercised it as yet, but have gone through the code, and all the basics look very good. I am not familiar with sass, so I might be missing unique features you might have going on.
There are a few minor bits that need to be addressed before a public release IMO, and I appreciate you asking for review.
ALSO, just as an FYI, before this repo goes public, I may want to delete this issue thread, as it may contain privileged IP at times.
Documentation
1) Careful with WCAG 3 mentions
On the main README, it is okay to say "APCA is the candidate for WCAG 3".
However, this line:

Level | Accessibility level as defined by APCA-W3 and WCAG 3: Bronze (minimum), Silver, Gold (higher).

We can not say "Accessibility level as defined by APCA-W3 and WCAG 3". We can say "Accessibility level as defined by APC-RC".
Nothing is defined in WCAG 3 at the moment, and therefore no reference can be made to WCAG 3 or W3C in terms of conformance until we are at the draft recommendation stage. But that is why IRT and APC-RC... but also, APC-RC is not at a stage of "conformance yet". I might be more comfortable with "Objectives to meet" sort of language, but this is not critical.
2) ARC is changing
I am going to change APCA Readability Criterion to something that does not spell ARC, as an accessibility company already has a product called ARC now. Up in the air as to what, but APC-RC will do for the time being.
Documentation AND code
3) Polarity, non-polar, and absolute Lc
This caught my attention:

Absolute (non-polar) Lc value

I'm sorry Cyril, as you had no way of knowing, but there is a non-polar mode and I'm afraid this is not it.
This can be called "absolute Lc" or something that does not refer to polarity, but not non-polar please, as there are some specific definitions for the non-polar version, and how it will be used.
Because it is woven all through your code, I am more than happy to adjust and issue a pull request for this.
Related question
It looks to me that throughout the code, the "Lnp" variable is being used often — but I didn't see how polarity was being checked or enforced? It's fine to use the absolute for connecting to a lookup table for instance, but does need to be tokenized in some way to ensure correct BoW/WoB.
While this may seem less important today, there are other color spaces where this will become very important.
Before I do anything, I'll wait to hear from you in terms of how you are handling polarity, particulary for Silver level.
4) x-height marks the spot...
Regarding font-size: what is actually important is xheight. Does sass have any utilities for using/finding xheight?
5) Backwards Scope
Again, here is something that you didn't know about because it is not public facing yet.
There will be one low level that is:

Non-polar mode only (authorized non polar, not abs(Lc))
Covers the same text and non-text scope as WCAG 2.2
Lc 75 = 4.5:1 and Lc 60 = 3:1
Non-text and very large text may get an Lc 15 break (down to Lc 45) for darker colors (if both darker than #c0c0c0 possibly), TBD.

This is the bassackwards compatible level.
Maybe call it the "Brass" level? Or maybe Iron, LOL (link to my general article on "metal rules", absolutely nothing at all to do with accessibility).
Bronze Scope
At the moment, scope for BRONZE is going to be "primary content and elements required to use/nav the site". But not non-polar.
Note: the maximum contrast ONLY applies to reverse (negative) Lc values, I.e. -90 or -85. It does not apply to light mode.
Covered: placeholders that are labels, nav icons, captions unless only a byline or covered in main content. Data viz needed for understanding (chart lines, pie pieces)
Not covered: placeholders that are NOT labels when a form label does exist, disabled controls, copyright, corp logos, ancillary, dataviz not needed for understanding (grid lines, alternating chart row highlighting) and anything not covered by WCAG 2.2.
As always this is interim.
Silver, Gold
You're gold man! amazing job over all, sorry about the errata above, I can help if you like. Seems to me the biggest deal is around the non-polar issue? Renaming to Lcat (Lc absolute) maybe?? I don't want to muck up any of your logic or workflow...
For the real non-polar, I don't want to release the actual non-polar mode yet for a variety of reasons. But just FYI, the actual non polar mode does not have a text/bg field, it has hi/lo fields, and the low field is always processed as if it was text, the high field is always bg (even if it is actually being used for text). The hi/lo of course is tested and inverted if needed, so a user can put whatever anywhere, and it acts like the webaim checker.
Nonpolar is only for the backwards compat mode.
Please feel free to hit me up with questions comments etc.
Thank you for reading... and for all your great work!

Hi @Myndex !
There we are: i've set the repo to public!
Thank you for your review! Next step: get feedback. ;-)


Check for Missing Cache Control Headers

Warn if any of the standard cache control headers aren't present on HTML pages.

This is done, except for parsing the Expires header.


Color run_simple's terminal output based on HTTP codes

This is similar to django's runserver.
Screenshot:

It requires termcolor & colorama currently, but consider this just a proof-of-concept, and a work in progress since the code is hacked together. If this functionality is desired, I'll make whatever changes are required to meet the code standards of the project.
I'm not too sure, but I guess #553 refers to this sort of functionality.

Maybe click's color support can be used?

@untitaker What about adding two new dependencies? That's what I'm worried about the most. Is that fine?

@davidism Click uses colorama, and Werkzeug doesn't depend on either
@dufferzafar Yeah, it should probably be an optional one. :laughing: So, try-except around your imports, and just don't do any coloring if it couldn't be imported. Also you might want to add your modules to extras_require.

Also since colorama is just a Windows compat library I think we don't need to import or use it in Werkzeug at all. The user can do that themselves before calling run_simple.

@untitaker Please have a look now.

Cool, could you add a changelog entry as well? Thanks!

Thanks!

Needs documentation too, something like: "To get colored request logs, install termcolor (with link), and colormama (with link) too if you're on Windows."

Ack, @dufferzafar could you file a new PR for the docs? Thanks!


Preprint history event data parse, update fixture.

Added new parsing functions to gather preprint version event history data.
The existing test fixture 2<IP_ADDRESS>2253.docmap.json is updated to reflect the latest docmap data available for it.

Re issue https://github.com/elifesciences/issues/issues/7721


New package: FluxExtra v0.1.0

Registering package: FluxExtra
Repository: https://github.com/OML-NPA/FluxExtra.jl
Created by: @a-ill
Version: v0.1.0
Commit: 1511ad55eec7cfe37865746f29c058fd8b7e107c
Git reference: main

[noblock]
Did you see some recent PRs to Flux? There is now a Parallel layer, and should soon be an Upsampling layer.

[noblock]
@mcabbott Yes, I saw the discussions. However, mentioned layers are not there yet and I do not know when all the layers that I have here will be added to Flux. Therefore, it seems reasonable to have a separate package for now. If the package becomes redundant I plan to deprecate it.

[noblock]
I hope it'll be a time-scale of weeks not months though. Is it worth registering a package as a stopgap? Maybe you have bigger plans for other layers too.
I have not read these very closely. Note that you can have ordinary functions in Flux's chain, like Chain(xs -> cat(xs...; dims=3), x -> σ.(x), sum), which I think covers some of these? The downside is that they don't print very nicely, but this could be solved... Activations can normally be written as part of the layer before, but writing cat is common, and should perhaps be made prettier.

[noblock]
@mcabbott The discussion regarding 4 out of 6 layers that this package has (Parallel, Catenation/Join,Decatenation/Split,Upscaling/Upsample) was going for half a year and the other two (Addition, Activation) do not seem to have been discussed. So I do not think that this package will be obsolete too soon.
The plan for this package was to include as fast as possible layers and features that for some reason are absent from Flux, but which me and other people want to have. Also, I plan to release another package called MLGUI in the comming months and these layers have to be there. If a person uses some layer that is absent from Flux, but is present in the MLGUI package and wants to use the resulting neural network without the MLGUI package (which is quite big), then it would be much more convenient to use a small package than to download and include a file containing absent layers.
Yes, I know that it is possible to use regular functions, but it is not convenient and does not look nice. Regarding activations, I prefer and needed for MLGUI package to have a separate layer for activations, therefore, Activation(f::Function) was added. It is also much more convenient to write, for example, Activation(tanh) than x -> tanh.(x).
The only problem that I am currently seeing is possible layer naming and structure differences between Flux and FluxExtra, which may complicate transition when some of the layers are added to Flux. However, that can be solved by automatic conversion on FluxExtra side or closer coordination with Flux (in progress).

[noblock]
Yes it's hard to deny that Flux has been neglected, the last year or so. It would be nice to do better, a few of us are trying, and more hands would be great.
What you call Catenation/Decatenation seems similar to Flux's stack/unstack? I managed to get a one-arg unsqueeze in, https://github.com/FluxML/Flux.jl/pull/1469, and I wonder if something similar should be done to these. (I'm not sure they are identical, haven't read super-closely.)
Activation is very nearly just Base.Fix1(broadcast, tanh), maybe that just needs a convenient way to write it?
Addition and Identity seem to be just sum, and identity, right?

@mcabbott Oh, so you participate in Flux development. I actually contacted the Flux development team a month ago to discuss the issues mentioned here and asked about collaboration, but did not get an answer yet. Could you possibly contact me by email<EMAIL_ADDRESS>then? I would like to continue this conversation in a more convenient settings and, therefore, come up with solutions quicker.


Fix UI responsive issues

F´ Version
F' GDS 2.0

Affected Component
JS

Problem Description
The current UI has many responsive issues that should be fixed.
1- Buttons do not change size and location on smaller screens
2- [DOM] Found 2 elements with non-unique id #command-text
3- DevTools failed to load source map: Could not load content for *.css.map or *.js.map
4- Navbar expands to a very long vertical list in md size
5- Unclosed HTML tags in different parts of the GDS
How to Reproduce

Start GDS
Resize window and observe HTML elements placement
Open chrome dev tool and see Devtool warnings

Expected Behavior
Responsive HTML behavior on resize, and no JS or HTML warning or error.

Says it was merged. Closing.


etcd_service_manager_docker: undefined method new_resource

Cookbook version
etcd 5.0.0 (latest available in https://supermarket.chef.io)
Chef-client version
Chef: 12.16.42
Platform Details
Host
Arch Linux x86_64, latest
linux kernel: 4.12.10
Vagrant 1.9.7
libvirtd (libvirt) 3.7.0
vagrant-libvirt (0.0.40)
Guest
Centos 7
linux kernel: 3.10.0-514.26.2.el7.x86_64
Chef: 12.16.42
Scenario
When trying to converge my recipe containing:
docker_service 'default'

etcd_installation_docker 'default' do
  action :create
end

etcd_service_manager_docker 'default' do
  action :start
end

I receive the following exception
================================================================================
Error executing action `start` on resource 'etcd_service_manager_docker[default]'
================================================================================

NoMethodError
-------------
undefined method `new_resource' for EtcdCookbook::EtcdServiceManagerDocker

Cookbook Trace:
---------------
/var/chef/cache/cookbooks/etcd/libraries/helpers_service.rb:65:in `etcd_name'
/var/chef/cache/cookbooks/etcd/libraries/etcd_service_manager_docker.rb:10:in `block in <class:EtcdServiceManagerDocker>'
/var/chef/cache/cookbooks/etcd/libraries/etcd_service_manager_docker.rb:15:in `block in <class:EtcdServiceManagerDocker>'

Resource Declaration:
---------------------
# In /var/chef/cache/cookbooks/etcd_node/recipes/service.rb

 13: etcd_service_manager_docker 'default' do
 14:   action :start
 15: end

Compiled Resource:
------------------
# Declared in /var/chef/cache/cookbooks/etcd_node/recipes/service.rb:13:in `from_file'

etcd_service_manager_docker("default") do
  action [:start]
  retries 0
  retry_delay 2
  default_guard_interpreter :default
  declared_type :etcd_service_manager_docker
  cookbook_name "etcd_node"
  recipe_name "service"
end

Platform:
---------
x86_64-linux

Steps to Reproduce
Create a cookbook that depends on etcd cookbook version 5.0.0 with the recipe mentioned above and try to do a kitchen converge.
Expected Result:
It should converge without errors and have etcd setup to run on docker.
Actual Result:
Fails with the above exception right after pulling the etcd image.

Fixed by https://github.com/chef-cookbooks/etcd/commit/b5cfa1eb54871140875027932f38251efc035ecb
Thanks for the report


Fix file logging for display messages

This PR will fix missing display (and probably other custom log messages) from not appearing in the file log, see #388.
@Marshall-Hallenbeck originally there was a filter to not log debug messages to the file, which prevented the logging of "display" messages. Any idea why this was the case? I did not find a case where this could cause problems (which doesn't mean there isn't)
Before&After:

I let @Marshall-Hallenbeck check this one :)

By the way, I implemented the following logging filter for a project of mine which will also show the file calling the logging module:
logging.Formatter('%(asctime)s | %(filename)-35s - %(message)s')

Which displays the following debug logs:

That way you know exactly what file is calling logger. Interested ? :P

By the way, I implemented the following logging filter for a project of mine which will also show the file calling the logging module:

Very interesting, the normal --debug log shows the source file, but the stuff logged to the file does not. I'm gonna steal your code if that's alright :D


The 'jss-to-styled' codemod errors out on every component

Hi!
I'm attempting to migrate to the latest beta to keep up with the changes for v5 and beyond. Currently, I'm on moving away from makeStyles to styled.

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
I tried using the new jss-to-styled codemod but it failed on me on every component with the following:
Transformation error (undefined does not match field "init": Expression | null of type VariableDeclarator).
Expected Behavior 🤔
Codemod succeeds and modifies my components to the styled API.
Steps to Reproduce 🕹
Steps:

Run npx @material-ui/codemod@next v5.0.0/jss-to-styled <source folder>

Context 🔦
I am using Typescript and have my own theme overrides, which I guess could cause the trouble? All my components look roughly like this:
import createStyles from '@material-ui/styles/createStyles';
import makeStyles from '@material-ui/styles/makeStyles';
import { MyCustomTheme } from '@material-ui/core/styles/createTheme';

const useStyles = makeStyles((theme: MyCustomTheme) =>
  createStyles({
    root: {
      // ...CSS styles
    },
  }),
);

type MyComponentProps = {...};

const MyComponent: React.FunctionComponent<React.PropsWithChildren<MyComponentProps>> = ({ props, children }) => {
  const classes = useStyles();

  return (

{children}
;
  );
};

**Edit: ** After playing around somewhat (I've never worked with jscodeshift or codemods) I figured the problem is caused by my calls to createStyles which I do because of TypeScript type widening as recommended by documentation. The case where makeStyles argument is a call expression is not handled by the codemod and additional issues are probably going to be caused by TS.
This concerns the getReturnStatement function that can be found here
I'll play around with it some more later tonight but as mentioned, I've got pretty much no idea what I'm doing here so don't expect much success. Hope this helps somebody :)
Your Environment 🌎

Environment info
System:

OS: macOS 11.4
CPU: (12) x64 Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
Memory: 533.31 MB / 16.00 GB
Shell: 5.8 - /bin/zsh

Binaries:

Node: 15.14.0 - ~/.nvm/versions/node/v15.14.0/bin/node
Yarn: 1.22.10 - /usr/local/bin/yarn
npm: 7.7.6 - ~/.nvm/versions/node/v15.14.0/bin/npm

Managers:

Homebrew: 3.0.10 - /usr/local/bin/brew
pip2: 18.1 - /usr/local/bin/pip2
pip3: 21.1.1 - /Library/Frameworks/Python.framework/Versions/3.9/bin/pip3
RubyGems: 3.0.3 - /usr/bin/gem

Utilities:

Make: 3.81 - /usr/bin/make
GCC: 4.2.1 - /usr/bin/gcc
Git: 2.16.2 - /usr/local/bin/git
Clang: 12.0.5 - /usr/bin/clang

Servers:

Apache: 2.4.46 - /usr/sbin/apachectl

IDEs:

Nano: 2.0.6 - /usr/bin/nano
VSCode: 1.54.3 - /usr/local/bin/code
Vim: 8.2 - /usr/bin/vim
Xcode: /undefined - /usr/bin/xcodebuild

Languages:

Bash: 3.2.57 - /bin/bash
Java: 1.8.0_101 - /usr/bin/javac
Perl: 5.30.2 - /usr/bin/perl
PHP: 7.3.24 - /usr/bin/php
Python: 2.7.16 - /usr/local/bin/python
Python3: 3.9.5 - /Library/Frameworks/Python.framework/Versions/3.9/bin/python3
R: 3.5.1 - /usr/local/bin/R
Ruby: 2.6.3 - /usr/bin/ruby

Databases:

SQLite: 3.32.3 - /usr/bin/sqlite3

Browsers:

Chrome: 92.0.4515.107
Edge: 91.0.864.64
Firefox: 86.0
Safari: 14.1.1

I use Edge but doubt that's relevant.

Looking further into this and since the styled function takes its types directly from node_modules, I'm not sure how to make it work with a custom theme TS overload reasonably simply.
Adding it as
const StyledComponent = styled(Component)(({ theme }: { theme: MyCustomTheme }) => ({
  // CSS
}))

results in an error in JSX
Property 'theme' is missing in type '...' but required in type '{ theme: MyCustomTheme; }'

while making it optional forces us to use optional chaining in style objects which is ugly. Not to mention having to ensure MyCustomTheme is imported in the file.
Thoughts?

@Brodzko currently the jss-to-styled codemod does not support scenarios where createStyled() is used. Could you try running it without that function?
Regarding the styled() usage with custom typings, you can take a look on the TS version of the example here https://next.material-ui.com/customization/theming/#custom-variables
Here it is exported in codesandbox - https://codesandbox.io/s/jsm6t?file=/demo.tsx

Regarding the styled() usage with custom typings, you can take a look on the TS version of the example here https://next.material-ui.com/customization/theming/#custom-variables

Yes, this is what I have in my project. What I meant was I'm not sure how to make post-codemod styled work with this custom type instead of the default one. Sorry if that wasn't clear.

What do you mean by post-codemod styled? Can you share a codesandbox illustrating the issue?

Scratch that last point, turns out I've probably been doing module augmentation wrong the whole time. I've played around in a sandbox here: Sandbox.
When I have my module declarations in a separate .d.ts file, they don't seem to get picked up (in theme.ts, createTheme throws an error).
But everything works fine if I put the code from the .d.ts right into theme.ts. Even type inference inside
styled('div')(({ theme }) => ({...}));

works fine.
Any idea why that is?
Before I've renamed all types to MyTheme etc. in a separate .d.ts and was force to explicitly type them in my createStyles calls.

You are probably didn't disable automatic export: export { };. Example: https://github.com/mui-org/material-ui/blob/next/packages/material-ui-lab/src/themeAugmentation/overrides.d.ts#L48

Thanks for that!
Anyway, if this is a known issue I think this can be closed. Is it planned to add support for createStyles users to this codemod before v5 or should I dig in and do the changes manually? :)

@Brodzko I will look into it this week.

@Brodzko I've merged the PR that adds the support for createStyles. Let me know if there are some problems once you test it

@mnajdova  I have started working on a different story in the meantime so it will take a while but I will ping when I try it out. Thanks for spending time on this!


Crash started happening only after I added a custom enchant glint

This is hard to reproduce because it only happens after playing for a couple minutes. Due to it's seemingly random occurrences, I cant definitively blame the enchantment glint but its an educated guess.
Here is my file structure:

And here is my blank.properties:

Visually it works fine until the crash.
Does it have to do with how I wrote the properties file? or is it a mod incompatibility?
Here are some crash reports:
crash-2023-04-10_18.04.00-client.txt
crash-2023-04-10_20.52.20-client.txt
crash-2023-04-10_20.57.19-client.txt

interesting it doesn't look like it should ever be null here
this is the relevant line https://github.com/SHsuperCM/CITResewn/blob/main/defaults/src/main/java/shcm/shsupercm/fabric/citresewn/defaults/cit/types/TypeEnchantment.java#L219

Try replacing the space between golden_hoe and netherite_hoe with a comma.
So: matchItems=golden_hoe,netherite_hoe

putting a comma gives an error

Try stating the namespace explicitly. matchItems=minecraft:golden_hoe,minecraft:netherite_hoe

as per the screenshot I sent, it doesn't allow for putting commas at all (only certain characters).
my problem isn't with the enchant not working (it works fine with the properties files I posted), it's with the crash
I seem to have found a way to make the game not crash by editing the lines of code in the mod that cause the error to check for null first (thanks traben)

I'm just now checking the documentation, and it looks list entries being separated with a space instead of a comma by CIT Resewn is intentional. Sorry about that :v
Taking a closer look at the crash logs, I think Essential might be the problem, given that one of its mixins is named Mixin_DisableArmorRendering (as per line 51 of "crash-2023-04-10_20.52.20-client.txt"). Armor won't be able to be made to render differently if it isn't rendered at all, I imagine.
(I cannot be sure how Essential goes about "disabling armor rendering", as the mod is closed source - but perhaps it's worth looking at nonetheless.)

Interesting theory
I have no idea how mixins work but to test it I played without essential but the crash still persisted
but the idea that an other mod might be influencing it is good to look into, ill try playing with just CITR for a bit to see if it still happens


Add ops-agent metric tests to integration tests for the exporter.

Ensure existing behavior for ops-agent self + host metrics remains as-is during rewrite.
cc @lingshi, @aabmass

I'll look into the test failure, looks like something small


Better title group DMs in Android notifications

In group DMs, the Android notification's conversation title currently displays only the latest sender's display name, such as "from Greg Price with 1 other".
Instead, it should name the other recipients too, up to 3 names (and excluding self). Beyond that, it should name 3 of the members of the thread and use the "N others" form for the rest, as in "Alice, Bob, Carol, and 2 others".
The difficulty here is that while for the message's sender, the server includes their display name (and avatar URL), for the other recipients we have just their user IDs but no details like display names. There are two options for how we could handle this:

We could have the server start including it in notification payloads. That'd start working promptly for users on Zulip Cloud and other servers regularly updated from Git. We'd fall back to the current text when it's not available.

This isn't ideal because it involves denormalizing more and more data into the notification payloads. But it would be easy to do.

We could start keeping the list of users, including their names, in the database so that we have it ready when a notification arrives.

We'll want to do this eventually for the sake of #477.
This is something we won't do soon, though, because it'll involve adding significant new complexity where we update data on server events. That's worth it for #477, because that's a major improvement to the UX, but is too much for this issue to justify.

Corresponding zulip-mobile issue: https://github.com/zulip/zulip-mobile/issues/5116

Thanks for filing this! I revised the description, including taking more text from https://github.com/zulip/zulip-mobile/issues/5116 .


3 errors left from new version

mirv:~/workspace (version2asyncAssigning) $ rake
Run options: --seed 43521

# Running:

......E.../home/ubuntu/workspace/lib/asynchronize.rb:48: warning: method redefined; discarding old test
/home/ubuntu/workspace/lib/asynchronize.rb:53: warning: previous definition of test was here
F.F...

Finished in 0.022986s, 696.0766 runs/s, 696.0766 assertions/s.

  1) Error:
Asynchronize::when there is an existing method_added#test_0001_should call that method_added before, and only once.:
NoMethodError: undefined method `+' for #<Thread:0x000000025e4258>
    /home/ubuntu/workspace/spec/spec.rb:118:in `block in method_added'
    /home/ubuntu/workspace/lib/asynchronize.rb:55:in `block (2 levels) in _build_method'

  2) Failure:
Asynchronize::when we asynchronize a method#test_0003_should be the same method if we call a second time [/home/ubuntu/workspace/spec/spec.rb:33]:
Asynchronized Inception has occurred.
No visible difference in the UnboundMethod#inspect output.
You should look at the implementation of #== on UnboundMethod or its members.
#<UnboundMethod: BasicSpec::Test(BasicSpec::Test::TestAsynchronized)#test>

  3) Failure:
Asynchronize::when we asynchronize a method#test_0005_should not create a method if the specified method does not exist [/home/ubuntu/workspace/spec/spec.rb:41]:
Expected: false
  Actual: true

16 runs, 16 assertions, 2 failures, 1 errors, 0 skips
Coverage report generated for RSpec to /home/ubuntu/workspace/coverage. 21 / 21 LOC (100.0%) covered.
rake aborted!
Command failed with status (1)
/usr/local/rvm/gems/ruby-2.3.4/gems/rake-12.3.1/exe/rake:27:in `<top (required)>'
/usr/local/rvm/gems/ruby-2.3.4/bin/ruby_executable_hooks:15:in `eval'
/usr/local/rvm/gems/ruby-2.3.4/bin/ruby_executable_hooks:15:in `<main>'
Tasks: TOP => default => test
(See full trace by running task with --trace)
``

Tweaked two things to make it go

@Mirv what did you tweak for this one?

I had to blow out my old repository & then sync to the new dev branch you setup - was mostly a git scripting thing.


Synchronous waiting using dart:cli waitFor and C API Dart_WaitForEvent is deprecated and disabled by default. This feature will be fully removed in Dart 3.4 release. You can currently still enable it by passing --enable_deprecated_wait_for to the Dart VM. See https://dartbug.com/52121.

get init

GetX Pattern (by Kauê)

CLEAN (by Arktekko)
Which architecture do you want to use? [1] Unhandled exception:
Synchronous waiting using dart:cli waitFor and C API Dart_WaitForEvent is deprecated and disabled by default. This feature will be fully removed in Dart 3.4 release. You can currently still enable it by passing --enable_deprecated_wait_for to the Dart VM. See https://dartbug.com/52121.
dart:cli-patch/cli_patch.dart 9:47                                                      _waitForEvent
dart:cli/wait_for.dart 64:12                                                            _WaitForUtils.waitForEvent
dart:cli/wait_for.dart 152:19                                                           waitFor
package:dcli/src/util/wait_for_ex.dart 38:17                                            waitForEx
package:dcli/src/functions/echo.dart 34:5                                               _Echo.echo
package:dcli/src/functions/echo.dart 24:13                                              echo
package:dcli/src/functions/ask.dart 157:7                                               Ask._ask
package:dcli/src/functions/ask.dart 113:11                                              ask
package:dcli/src/functions/menu.dart 135:22                                             menu
package:get_cli/common/menu/menu.dart 20:20                                             Menu.choose
package:get_cli/commands/impl/init/flutter/init.dart 21:25                              InitCommand.execute
C:\Users\dabhi\AppData\Local\Pub\Cache\hosted\pub.dev\get_cli-1.8.4\bin\get.dart 18:23  main
dart:isolate-patch/isolate_patch.dart 295:33                                            _delayEntrypointInvocation.
dart:isolate-patch/isolate_patch.dart 184:12                                            _RawReceivePort._handleMessage
package:dcli/src/util/wait_for_ex.dart 35:28                                            waitForEx
package:dcli/src/functions/echo.dart 34:5                                               _Echo.echo
package:dcli/src/functions/echo.dart 24:13                                              echo
package:dcli/src/functions/ask.dart 157:7                                               Ask._ask
package:dcli/src/functions/ask.dart 113:11                                              ask
package:dcli/src/functions/menu.dart 135:22                                             menu
package:get_cli/common/menu/menu.dart 20:20                                             Menu.choose
package:get_cli/commands/impl/init/flutter/init.dart 21:25                              InitCommand.execute
C:\Users\dabhi\AppData\Local\Pub\Cache\hosted\pub.dev\get_cli-1.8.4\bin\get.dart 18:23  main
dart:isolate-patch/isolate_patch.dart 295:33                                            _delayEntrypointInvocation.
dart:isolate-patch/isolate_patch.dart 184:12                                            _RawReceivePort._handleMessage

GetX Pattern (by Kauê)

CLEAN (by Arktekko)
Which architecture do you want to use? [1] Unhandled exception:
Synchronous waiting using dart:cli waitFor and C API Dart_WaitForEvent is deprecated and disabled by default. This feature will be fully removed in Dart 3.4 release. You can currently still enable it by passing --enable_deprecated_wait_for to the Dart VM. See https://dartbug.com/52121.
dart:cli-patch/cli_patch.dart 9:47                                                      _waitForEvent
dart:cli/wait_for.dart 64:12                                                            _WaitForUtils.waitForEvent
dart:cli/wait_for.dart 152:19                                                           waitFor
package:dcli/src/util/wait_for_ex.dart 38:17                                            waitForEx
package:dcli/src/functions/echo.dart 34:5                                               _Echo.echo
package:dcli/src/functions/echo.dart 24:13                                              echo
package:dcli/src/functions/ask.dart 157:7                                               Ask._ask
package:dcli/src/functions/ask.dart 113:11                                              ask
package:dcli/src/functions/menu.dart 135:22                                             menu
package:get_cli/common/menu/menu.dart 20:20                                             Menu.choose
package:get_cli/commands/impl/init/flutter/init.dart 21:25                              InitCommand.execute
C:\Users\dabhi\AppData\Local\Pub\Cache\hosted\pub.dev\get_cli-1.8.4\bin\get.dart 18:23  main
dart:isolate-patch/isolate_patch.dart 295:33                                            _delayEntrypointInvocation.
dart:isolate-patch/isolate_patch.dart 184:12                                            _RawReceivePort._handleMessage
package:dcli/src/util/wait_for_ex.dart 35:28                                            waitForEx
package:dcli/src/functions/echo.dart 34:5                                               _Echo.echo
package:dcli/src/functions/echo.dart 24:13                                              echo
package:dcli/src/functions/ask.dart 157:7                                               Ask._ask
package:dcli/src/functions/ask.dart 113:11                                              ask
package:dcli/src/functions/menu.dart 135:22                                             menu
package:get_cli/common/menu/menu.dart 20:20                                             Menu.choose
package:get_cli/commands/impl/init/flutter/init.dart 21:25                              InitCommand.execute
C:\Users\dabhi\AppData\Local\Pub\Cache\hosted\pub.dev\get_cli-1.8.4\bin\get.dart 18:23  main
dart:isolate-patch/isolate_patch.dart 295:33                                            _delayEntrypointInvocation.
dart:isolate-patch/isolate_patch.dart 184:12                                            _RawReceivePort._handleMessage
PS E:\MYWORK\MY_FLUTTER_PROJECT\Signature\CODE\signature>

i have same problem

me too

me too

for now i just downgrade my flutter

me too

for now i just downgrade my flutter

downgrade flutter or dart version?
i think this error because new dart

downgrade flutter otomaticly downgrade dart too

okay, thanks bro

same issue, stay focused about the status of fixing.

But this is not solution

But this is not solution

not a solution, get_cli will update
may be in progress

get init

GetX Pattern (by Kauê)
CLEAN (by Arktekko)
Which architecture do you want to use? [1] Unhandled exception:
Synchronous waiting using dart:cli waitFor and C API Dart_WaitForEvent is deprecated and disabled by default. This feature will be fully removed in Dart 3.4 release. You can currently still enable it by passing --enable_deprecated_wait_for to the Dart VM. See https://dartbug.com/52121.
dart:cli-patch/cli_patch.dart 9:47                                                      _waitForEvent
dart:cli/wait_for.dart 64:12                                                            _WaitForUtils.waitForEvent
dart:cli/wait_for.dart 152:19                                                           waitFor
package:dcli/src/util/wait_for_ex.dart 38:17                                            waitForEx
package:dcli/src/functions/echo.dart 34:5                                               _Echo.echo
package:dcli/src/functions/echo.dart 24:13                                              echo
package:dcli/src/functions/ask.dart 157:7                                               Ask._ask
package:dcli/src/functions/ask.dart 113:11                                              ask
package:dcli/src/functions/menu.dart 135:22                                             menu
package:get_cli/common/menu/menu.dart 20:20                                             Menu.choose
package:get_cli/commands/impl/init/flutter/init.dart 21:25                              InitCommand.execute
C:\Users\dabhi\AppData\Local\Pub\Cache\hosted\pub.dev\get_cli-1.8.4\bin\get.dart 18:23  main
dart:isolate-patch/isolate_patch.dart 295:33                                            _delayEntrypointInvocation.
dart:isolate-patch/isolate_patch.dart 184:12                                            _RawReceivePort._handleMessage
package:dcli/src/util/wait_for_ex.dart 35:28                                            waitForEx
package:dcli/src/functions/echo.dart 34:5                                               _Echo.echo
package:dcli/src/functions/echo.dart 24:13                                              echo
package:dcli/src/functions/ask.dart 157:7                                               Ask._ask
package:dcli/src/functions/ask.dart 113:11                                              ask
package:dcli/src/functions/menu.dart 135:22                                             menu
package:get_cli/common/menu/menu.dart 20:20                                             Menu.choose
package:get_cli/commands/impl/init/flutter/init.dart 21:25                              InitCommand.execute
C:\Users\dabhi\AppData\Local\Pub\Cache\hosted\pub.dev\get_cli-1.8.4\bin\get.dart 18:23  main
dart:isolate-patch/isolate_patch.dart 295:33                                            _delayEntrypointInvocation.
dart:isolate-patch/isolate_patch.dart 184:12                                            _RawReceivePort._handleMessage
GetX Pattern (by Kauê)
CLEAN (by Arktekko)
Which architecture do you want to use? [1] Unhandled exception:
Synchronous waiting using dart:cli waitFor and C API Dart_WaitForEvent is deprecated and disabled by default. This feature will be fully removed in Dart 3.4 release. You can currently still enable it by passing --enable_deprecated_wait_for to the Dart VM. See https://dartbug.com/52121.
dart:cli-patch/cli_patch.dart 9:47                                                      _waitForEvent
dart:cli/wait_for.dart 64:12                                                            _WaitForUtils.waitForEvent
dart:cli/wait_for.dart 152:19                                                           waitFor
package:dcli/src/util/wait_for_ex.dart 38:17                                            waitForEx
package:dcli/src/functions/echo.dart 34:5                                               _Echo.echo
package:dcli/src/functions/echo.dart 24:13                                              echo
package:dcli/src/functions/ask.dart 157:7                                               Ask._ask
package:dcli/src/functions/ask.dart 113:11                                              ask
package:dcli/src/functions/menu.dart 135:22                                             menu
package:get_cli/common/menu/menu.dart 20:20                                             Menu.choose
package:get_cli/commands/impl/init/flutter/init.dart 21:25                              InitCommand.execute
C:\Users\dabhi\AppData\Local\Pub\Cache\hosted\pub.dev\get_cli-1.8.4\bin\get.dart 18:23  main
dart:isolate-patch/isolate_patch.dart 295:33                                            _delayEntrypointInvocation.
dart:isolate-patch/isolate_patch.dart 184:12                                            _RawReceivePort._handleMessage
package:dcli/src/util/wait_for_ex.dart 35:28                                            waitForEx
package:dcli/src/functions/echo.dart 34:5                                               _Echo.echo
package:dcli/src/functions/echo.dart 24:13                                              echo
package:dcli/src/functions/ask.dart 157:7                                               Ask._ask
package:dcli/src/functions/ask.dart 113:11                                              ask
package:dcli/src/functions/menu.dart 135:22                                             menu
package:get_cli/common/menu/menu.dart 20:20                                             Menu.choose
package:get_cli/commands/impl/init/flutter/init.dart 21:25                              InitCommand.execute
C:\Users\dabhi\AppData\Local\Pub\Cache\hosted\pub.dev\get_cli-1.8.4\bin\get.dart 18:23  main
dart:isolate-patch/isolate_patch.dart 295:33                                            _delayEntrypointInvocation.
dart:isolate-patch/isolate_patch.dart 184:12                                            _RawReceivePort._handleMessage
PS E:\MYWORK\MY_FLUTTER_PROJECT\Signature\CODE\signature>

This can be used as a temporary solution
flutter pub global activate  --source=git https://github.com/inyong1/get_cli.git

get init

GetX Pattern (by Kauê)
CLEAN (by Arktekko)
Which architecture do you want to use? [1] Unhandled exception:
Synchronous waiting using dart:cli waitFor and C API Dart_WaitForEvent is deprecated and disabled by default. This feature will be fully removed in Dart 3.4 release. You can currently still enable it by passing --enable_deprecated_wait_for to the Dart VM. See https://dartbug.com/52121.
dart:cli-patch/cli_patch.dart 9:47                                                      _waitForEvent
dart:cli/wait_for.dart 64:12                                                            _WaitForUtils.waitForEvent
dart:cli/wait_for.dart 152:19                                                           waitFor
package:dcli/src/util/wait_for_ex.dart 38:17                                            waitForEx
package:dcli/src/functions/echo.dart 34:5                                               _Echo.echo
package:dcli/src/functions/echo.dart 24:13                                              echo
package:dcli/src/functions/ask.dart 157:7                                               Ask._ask
package:dcli/src/functions/ask.dart 113:11                                              ask
package:dcli/src/functions/menu.dart 135:22                                             menu
package:get_cli/common/menu/menu.dart 20:20                                             Menu.choose
package:get_cli/commands/impl/init/flutter/init.dart 21:25                              InitCommand.execute
C:\Users\dabhi\AppData\Local\Pub\Cache\hosted\pub.dev\get_cli-1.8.4\bin\get.dart 18:23  main
dart:isolate-patch/isolate_patch.dart 295:33                                            _delayEntrypointInvocation.
dart:isolate-patch/isolate_patch.dart 184:12                                            _RawReceivePort._handleMessage
package:dcli/src/util/wait_for_ex.dart 35:28                                            waitForEx
package:dcli/src/functions/echo.dart 34:5                                               _Echo.echo
package:dcli/src/functions/echo.dart 24:13                                              echo
package:dcli/src/functions/ask.dart 157:7                                               Ask._ask
package:dcli/src/functions/ask.dart 113:11                                              ask
package:dcli/src/functions/menu.dart 135:22                                             menu
package:get_cli/common/menu/menu.dart 20:20                                             Menu.choose
package:get_cli/commands/impl/init/flutter/init.dart 21:25                              InitCommand.execute
C:\Users\dabhi\AppData\Local\Pub\Cache\hosted\pub.dev\get_cli-1.8.4\bin\get.dart 18:23  main
dart:isolate-patch/isolate_patch.dart 295:33                                            _delayEntrypointInvocation.
dart:isolate-patch/isolate_patch.dart 184:12                                            _RawReceivePort._handleMessage
GetX Pattern (by Kauê)
CLEAN (by Arktekko)
Which architecture do you want to use? [1] Unhandled exception:
Synchronous waiting using dart:cli waitFor and C API Dart_WaitForEvent is deprecated and disabled by default. This feature will be fully removed in Dart 3.4 release. You can currently still enable it by passing --enable_deprecated_wait_for to the Dart VM. See https://dartbug.com/52121.
dart:cli-patch/cli_patch.dart 9:47                                                      _waitForEvent
dart:cli/wait_for.dart 64:12                                                            _WaitForUtils.waitForEvent
dart:cli/wait_for.dart 152:19                                                           waitFor
package:dcli/src/util/wait_for_ex.dart 38:17                                            waitForEx
package:dcli/src/functions/echo.dart 34:5                                               _Echo.echo
package:dcli/src/functions/echo.dart 24:13                                              echo
package:dcli/src/functions/ask.dart 157:7                                               Ask._ask
package:dcli/src/functions/ask.dart 113:11                                              ask
package:dcli/src/functions/menu.dart 135:22                                             menu
package:get_cli/common/menu/menu.dart 20:20                                             Menu.choose
package:get_cli/commands/impl/init/flutter/init.dart 21:25                              InitCommand.execute
C:\Users\dabhi\AppData\Local\Pub\Cache\hosted\pub.dev\get_cli-1.8.4\bin\get.dart 18:23  main
dart:isolate-patch/isolate_patch.dart 295:33                                            _delayEntrypointInvocation.
dart:isolate-patch/isolate_patch.dart 184:12                                            _RawReceivePort._handleMessage
package:dcli/src/util/wait_for_ex.dart 35:28                                            waitForEx
package:dcli/src/functions/echo.dart 34:5                                               _Echo.echo
package:dcli/src/functions/echo.dart 24:13                                              echo
package:dcli/src/functions/ask.dart 157:7                                               Ask._ask
package:dcli/src/functions/ask.dart 113:11                                              ask
package:dcli/src/functions/menu.dart 135:22                                             menu
package:get_cli/common/menu/menu.dart 20:20                                             Menu.choose
package:get_cli/commands/impl/init/flutter/init.dart 21:25                              InitCommand.execute
C:\Users\dabhi\AppData\Local\Pub\Cache\hosted\pub.dev\get_cli-1.8.4\bin\get.dart 18:23  main
dart:isolate-patch/isolate_patch.dart 295:33                                            _delayEntrypointInvocation.
dart:isolate-patch/isolate_patch.dart 184:12                                            _RawReceivePort._handleMessage
PS E:\MYWORK\MY_FLUTTER_PROJECT\Signature\CODE\signature>

This can be used as a temporary solution flutter pub global activate --source=git https://github.com/inyong1/get_cli.git

Thanks! 🧡

same problem how to fix

If you are using GetX-Pattern then run this command in your terminal
dart pub global activate -sgit https://github.com/iamrutudhvaj/get_cli.git --git-ref GetX-Pattern
If you are using Clean-Pattern then run this command in your terminal
dart pub global activate -sgit https://github.com/iamrutudhvaj/get_cli.git --git-ref Clean-Pattern
it is temporary solution!

Synchronous waiting using dart:cli waitFor and C API Dart_WaitForEvent is deprecated and disabled by default. This feature will be fully removed in Dart 3.4 release. You can currently still enable it by passing --enable_deprecated_wait_for to the Dart VM. See https://dartbug.com/52121.

flutter pub global activate --source=git https://github.com/inyong1/get_cli.git

flutter pub global activate  --source=git https://github.com/inyong1/get_cli.git

I also faced the same problem.
The solution worked for me: flutter pub global activate --source=git https://github.com/inyong1/get_cli.git
Thank you @inyong1