bug: html tag not removed in treesitter lsp markdown hover

Did you check docs and existing issues?

[X] I have read all the noice.nvim docs
[X] I have searched the existing issues of noice.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.9.0-dev-1324+ge30cc8be1
Operating system/version
MacOs 13.1
Describe the bug
It doesn't properly remove all html tags for the markdown render of lsp docs
Neovim:

VsCode:

Note the Option\<String\> in the neovim popup. I would expect something like in vscode where the tags are not included
Steps To Reproduce
Use this Rust file:
fn main() {
    let foo = Some("foo");
    foo.map(|_| "bar");
}

Try to hover the docs on map and notice the tags being there
Expected Behavior
I would expect something like this where the ` is gone:

Note I just set modifiable and removed the tags to make it look like it ideally should.
Repro
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  "folke/noice.nvim",
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

It seems like something like this could work for the escape character:
diff --git a/lua/noice/text/markdown.lua b/lua/noice/text/markdown.lua
index cef6b13..bb84214 100644
--- a/lua/noice/text/markdown.lua
+++ b/lua/noice/text/markdown.lua
@@ -63,7 +63,7 @@ end
 function M.parse(text, opts)
   opts = opts or {}
   ---@type string
-  text = text:gsub("</?pre>", "```"):gsub("\r", "")
+  text = text:gsub("</?pre>", "```"):gsub("\r", ""):gsub("(\\)(%p)", "%2")
   text = M.html_entities(text)

   ---@type Markdown

However, I am not too sure about how we should deal with the  tag. Because if we change it for a backtick, then all the text inside will be interpreted as a literal string, and the conceal won't work for the url which makes it a bit ugly. So I think maybe just doing :gsub("</?code>", "") could work okay. If you have a better idea, let me know!

Another potential expected behaviour is to have it all be wrapped in backticks, but that would probably require some changes to queries in nvim-treesitter for concealing or something like that. It seems like helix does it like this:

@folke that won't work correctly, because now the links will not be concealed properly:

Something like this seems to work good:
diff --git a/lua/noice/text/markdown.lua b/lua/noice/text/markdown.lua
index b14a2c0..1078679 100644
--- a/lua/noice/text/markdown.lua
+++ b/lua/noice/text/markdown.lua
@@ -64,7 +64,7 @@ end
 function M.parse(text, opts)
   opts = opts or {}
   ---@type string
-  text = text:gsub("</?pre>", "```"):gsub("\r", ""):gsub("</?code>", "`")
+  text = text:gsub("</?pre>", "```"):gsub("\r", ""):gsub("</?code>", ""):gsub("(\\)(%p)", "%2")
   text = M.html_entities(text)

   ---@type Markdown

I've reverted my changes. This should be fixed in the treesitter markdown parser. \\ should probably be concealed when inside  tags

Your suggested changes may work for rust, but will very likley break a lot of other markdown code

I don't think it will very likely break a lot of other markdown code. This fix has been suggested to upstream as well:
https://github.com/neovim/neovim/pull/13803
https://github.com/neovim/neovim/pull/14069
It looks like the reason they didn't go this route is because they wanted users to have more general control over syntax rules: https://github.com/neovim/neovim/pull/14073
I agree with mjlbach on this: I'm betting the frequency of unintended rendered \ >> frequency of intended \
And by replacing  with a backtick will always break the concealing of url since then it isn't parsed as a url anymore. Fixing this would probably require a lot of change in the markdown_inline parser


Zone#import record merge is too early, adds records with same name and type

The introduction of the Fully Qualified Domain Names feature (PR #324) exposed a critical flaw in the record merging behavior of Gcloud::Dns::Importer. The merge needs to occur after record names have been converted to their fully-qualified form.

Turned out the issue is a bit more subtle: The fix is to set the record name to the current zone file origin if it is @. Simple enough, but overlooked.


TSkAnimatedImage play and stop missed

Hi,
first, compliments! for the library!
I have read that there are no methods to start or stop an animation manually, but you have to use TSkAnimatedImage.enable or TSkAnimatedImage.visible.
I think a play / stop method allows you to better manage an animation ... for example a bell of the notifications ... as soon as a new one arrives ... the bell moves.
Using enable / visible the bell is always hidden ... and would only be seen during animation.
Another example that could be an animation for a process progress ... when it is active it moves ... when it is deactivated the image is still.
thank you
Antonello

Agreed. Here is a useful workaround in the meantime:
type
  TAnimatedImageHack = Class(TSkAnimatedImage)
    public property DisabledOpacity;
  end;

procedure TForm12.FormCreate(Sender: TObject);
begin
  TAnimatedImageHack(SkAnimatedImage1).DisabledOpacity := 1;

then you can just use SkAnimatedImage1.Enabled := True or False to play and pause.

In the new version v3.4.0 we fixed opacity when disabled, as Jim suggested. So to control start and stop just use Enabled true or false. In the next version I will add more properties to be able to better control the animations, like: Inverse, AutoReverse, Delay, StartFromCurrent. The idea will be to do something similar to FMX's TAnimation.

Very nice!

great! perfect

In the new version v3.4.0 we fixed opacity when disabled, as Jim suggested. So to control start and stop just use Enabled true or false. In the next version I will add more properties to be able to better control the animations, like: Inverse, AutoReverse, Delay, StartFromCurrent. The idea will be to do something similar to FMX's TAnimation.

I would add how many times the animation has to repeat ... n loop


Launch server & wait for completion as part of eventstream

Right now, we wait for the event stream to finish, and then redirect the user to a separate 'redirect' url that does the launching of the server and waiting for it to start & then redirecting.
Instead, we should do that as part of the eventstream itself.  It should just return the url + token at the end. Then the mybinder.org frontend code should be able to read that and construct appropriate URL to redirect to.
This way, other third party code can easily get the token + URL and use it as it sees fit.

/cc @minrk @ellisonbg (for JupyterLab desktop app support)

#135 implements this and a Python example for launching via the API

@minrk @yuvipanda Did #135 resolve this issue fully?

yup, forgot to auto-close


Smart Dashboard no longer works.

Think we fixed this. Deleted the save file and it reloaded fine.


Update Deploy_Gemma_in_Vertex_AI.ipynb

Update to Gemma 2 2B model

endpoint has been deleted, so it won't work anyway ;)


Trajectory functions

Waypoint list should be separate from the trajectory itself so that we can compare different kinds of trajectories for the same path.
struct aa_rx_traj should be opaque as well

move declaration to internal header
No need for an init/create function in the public API.  The generate functions for different trajectory types can handle allocation and initialization out of a provided memory region.

The code using the trajectory should not care about the specific type of trajectory being generated.  That is, I should be able to add points to a trajectory without caring (too much) about the type of trajectory.  Then, I generate the specific kind of trajectory I want.  Finally, the code tracking the trajectory shouldn't care about the specific type of trajectory that was generated.  Currently, it looks like too many details about the trajectory type leak into the aa_rx_trajpt_add()' and aa_rx_traj_value()` functions.
I think using C-style polymorphism in a public API is somewhat dubious, but I'm not sure if there's a strictly better alternative.

Please add the Rice copyright notice also.


EIP Qos support

Feature request
Add rate limit support for the EIP of custom VPC
Use case
To limit the bandwidth of EIP similar to limit the bandwidth of floating IP in Neutron.

I did some testing using TC ,and the commands are as follows:
ingress
tc qdisc  add dev net1 root handle 1:0 htb
tc class  add dev net1  parent 1:0 classid 1:1 htb rate 10mbit ceil 10mbit
tc filter add dev net1 protocol ip parent 1:0 prio 1 u32 match ip src {eip} flowid 1:1

egress
tc qdisc add dev net1 ingress
tc filter add dev net1 parent ffff: protocol ip prio 1 u32 match ip dst {eip} police rate 10000Kbit burst 10Mb drop flowid :1

It seem to work.
I am planning to add rate limit to EIP. Please let me know if you have any suggestions before I start coding.

我这边感觉没什么问题，可能我这边后续想把bfd下一跳网关的qos也这样做下，不知道他们那边有没qos相关的安排。 @shane965


Segment private state storage

Right now the private state storage stores

$privateTxHash_LOGS -> the logs emitted from a contract call
$privateTxHash_OUTPUT -> the return value of a contract call
$blockhash_$pmtHash_METADATA -> the resulting state root for each transaction in each privacy group

The goal is to use the comlumnar rocksdb approach to segment the private state storage such that each type of value is in its own column.
The benefit of doing this is that it will be a cleaner approach wrt maintainability and it will be more performant.
An alternative approach to consider is to squash the data in an object and have only 1 key for the private state storage. It is possible to derive the private tx hash from the combination of block hash and PMT hash. The resulting key value pair would look like this:
$blockhash_$pmtHash -> {the resulting state root for each transaction in each privacy group, the logs emitted from a contract call, the return value of a contract call}

Hey @iikirilov , I think I remember you working on this, is that correct?

Yes, but it was put in the backlog at the time.


Consider removing PyCryptodome from blacklist

As the maintainer of PyCryptodome, I have reservations on the library being blacklisted (B414).
Can you help me understand why you think it "has not fully addressed the issues inherent in PyCrypto"?
It shares none of the bugs, and it broke API compatibility with it by dropping the most dangerous ones (such as having ECB as the default cipher mode).
You can certainly shoot yourself in the foot with the low-level primitives, but the same can be achieved with cryptography (which is a great project, no doubts about it).

I am not in the know enough to be arbiter here.
I am guessing you have fixed https://github.com/dlitz/pycrypto/issues/176 , if so this sounds reasonable to me, I can see the project is maintained / active.
@sigmavirus24 @ericwb any thoughts.

@Legrandin when this was added, PyCryptodome had all of the same vulnerabilities. It hasn't been re-evaluated yet and would require an unbiased evaluation (IMO).

PyCryptodome had almost all PyCrypto vulnerabilities (like https://github.com/dlitz/pycrypto/issues/176) fixed right from the start, 4 years ago, whereas B414 was added one month ago as far as I can tell.
In 4 years, the whole C layer of PyCrypto has been rewritten and sanitized in stages (because honestly it was a potential dumpster fire) so it could be that more have been fixed along the road without me knowing it, but certainly that didn't happen after the evaluation that led to B414.

I think one of my concerns is all of the weak ciphers, hashes, etc are still included in PyCryptodome for backwards compatible purposes.  But IMO they should really be removed to avoid users shooting themselves in the foot.  Even for old designs, why are these okay to use?

Old algorithms are still useful to access, verify and/or import old data (which would be lost otherwise) or interface with old system (say, not so recent embedded hardware).
So, even though I would also like to see only the latest and greatest algorithms being used, I find that approach only works in environments where code updates are cheap and data somewhat volatile (like web services, etc).
Additionally, the threat of people selecting outdated algorithms is probably one order of magnitude less serious than incorrect key generation and management (like using fixed keys and passwords, using bad RNG, storing keys in the clear or not wiping them) or unsafe compositions of otherwise safe algorithms, which are unfortunately more difficult to detect.
All in all, I think it would be more fair for bandit to blacklist individual modules in pycryptodome you feel strongly against (like Crypto.Cipher.DES), as opposed to entire packages. I also just noticed that cryptography too gives you access to weak algorithms (ECB mode, RSAES-PKCS1-v1_5, MD5, SHA1, TDES, etc) but bandit does not warn the user in that case, so that is certainly not showing consistency.

:+1:
I don't see why you would blacklist the entire module vs specific unsafe methods and algorithms. Pycryptodome is vastly improved compared to pycrypto, and is an easy transition for systems using pycrypto. Most encryption libraries have some form of support for legacy algorithms, which is just part of the reality of supporting older or legacy systems (as well as migrations from them). It's definitely worth flagging insecure function usage, but flagging the entire library is an unnecessarily nuclear approach.

Is there a timeline for this? I'd also support bandit flagging individual modules. This would even promote the use of the newer safer algorithms in pycryptodome.

Fixed with https://github.com/PyCQA/bandit/pull/470

Just a final note: this process much more document weaknesses in the bandit blacklist process than everything else!


Callback not be called when transition to same state

I meet the problem that described here https://github.com/jakesgordon/javascript-state-machine/issues/14
I think the bug it's not completely repaired, please see the code below, it demonstrate what I mean.
 javascript
var count = 0
var fsm = StateMachine.create({
initial: 'hide',
events: [
{name: 'open', from: 'hide', to: 'show'},
{name: 'again', from: 'show', to: 'show'},
{name: 'close', from: 'show', to: 'hide'}
],
callbacks: {
onentershow: function () {
count++
}
}
})
fsm.open()   // expect count++
fsm.again()  // expect count++
fsm.again()  // expect count++
fsm.close()
assert.equal(count, 3) // error as count == 1

OK, I check the code which shows:
if (from === to) {
    StateMachine.afterEvent(this, name, from, to, args);
    return StateMachine.Result.NOTRANSITION;
}

Maybe I should use onafterevent instead of onenterstate

Thanks for noting this, saved me some time :)
I also vote for calling the onenterSTATE handler when a state transitions to itself.  Users who don't want to handle that case could just compare the "from" and "to" parameters.  Or could make this behavior optionally activated through a create() parameter.

I agree with the sentiment here:  we should have the choice to have state handlers called either once per state change or every time a state is entered (even if repeated like "red" to "red" to "red").  I suggest that the library allow for an optional config per state which defaults to the original behavior but offers a choice of something like 'trigger: always'
states: {
red:  {
trigger: always
}
}
... then, just for the 'red' state, all state handlers would be called every time 'red' is entered, even if from 'red', while all other states would default to the original behavior.

I also need the behavior

Mike Daly @seeq12 has pushed a change which does this I think... better have a look

This behavior can now be opted into with v3 by specifying observeUnchangedState: true in your state machine config.
(NOTE: it didn't make into v3.0.0-rc.1, but will be available in the next release candidate and the official v3 release)


add tabs in Configure View

:tada: This PR is included in version 1.9.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


SPIKE: Investigate replacement of Typeahead

The Typeahead component in currently used in the following components:

InputLang
InputLookupModal
ResourceTemplateChoiceModal
renderTypeaheadFunctions

PR #2518 upgrades the Typeahead to version 5 but this component is still using the depreciated componentDidUpdate call. This spike would determine if it is worth the effort to "roll-our-own" typeahead component of if we should stay with react-bootstrap-typeahead.
BLOCKS #2489

We probably want to replace the InputListLOC with QA first, as that will allow us to remove a bunch of this code.  When I did the update to version 5, I never see the componentDidUpdate warning message. I suspect our usage doesn't hit that anymore.


Fixed missing words in en.json

Also see: #27

I forgot that there was another placeholder. Also, the meaning of the message was not as intended. So I fixed the issue in the latest commit.

I forgot that there was another placeholder. Also, the meaning of the message was not as intended. So I fixed the issue in the latest commit.


Unable to open object (object 'UniqueGlobalKey' doesn't exist)

Dear All,
I got an error that I can't find a solution. I paste here the output after the process breaks just at the beginning.
Traceback (most recent call last):
File "/usr/lib/python3.6/multiprocessing/pool.py", line 119, in worker
result = (True, func(*args, **kwds))
File "/usr/lib/python3.6/multiprocessing/pool.py", line 44, in mapstar
return list(map(*args))
File "/disk2/Users/FLIR/Software/LongQC/lq_nanopore.py", line 155, in wrapper
c_id  = get_channel_id(fast5) -1
File "/disk2/Users/FLIR/Software/LongQC/lq_nanopore.py", line 120, in get_channel_id
return int(f['/UniqueGlobalKey']['channel_id'].attrs['channel_number'])
File "h5py/_objects.pyx", line 54, in h5py._objects.with_phil.wrapper
File "h5py/_objects.pyx", line 55, in h5py._objects.with_phil.wrapper
File "/disk2/Software/Venv/venv36/lib/python3.6/site-packages/h5py/_hl/group.py", line 288, in getitem
oid = h5o.open(self.id, self._e(name), lapl=self._lapl)
File "h5py/_objects.pyx", line 54, in h5py._objects.with_phil.wrapper
File "h5py/_objects.pyx", line 55, in h5py._objects.with_phil.wrapper
File "h5py/h5o.pyx", line 190, in h5py.h5o.open
KeyError: "Unable to open object (object 'UniqueGlobalKey' doesn't exist)"
Do you have any clue about how to fix this and make the script runs normally?
Thank you in advance.

Hello @felipelira,
Thank you for your interest in LongQC.
Can I ask the exact command you use?
From the error message, I think you would have tried longQC.py runqc for ONT data.
If this is the case, the format of Fast5 might have changed since the function was coded.
UniqueGlobalKey is the keyword previously existed in Fast5, but it may not exist anymore. I plan to deprecate runqc.
Having said, longQC.py sampleqc would run with ONT fastq file.
Hope this helps.
Yoshinori

let me close this thread, and feel free to reopen when needed.
Y.

I also have this problem when trying to QC a MinION run. I've used the Dockerfile to create a Docker image, but then had to convert to Singularity image.
As a background information, which is probably not relevant, I had to add two commands to the Docker image:

RUN chmod -R a+rX /root -- to run as a non-root user
RUN pip install --upgrade h5py -- Work around "undefined symbol: H5Pset_falp_ros3" error. Seems related to conda. https://github.com/h5py/h5py/issues/1880

After this, the singularity image produces the error in this issue. I'm using the runqc command on a MinION raw data output (also includes basecalled data). Here's the command and output:
$ singularity run -B $PWD:$PWD -W $PWD /boston/common/tools/longqc/20220131/longqc-20220131.sif runqc minion -o output_longqc no_sample/20220125_1444_MC-112514_FAR37726_776d5599/
lq_nanopore:2022-01-31 16:21:50,274:251:INFO:Started minion platform QC for no_sample/20220125_1444_MC-112514_FAR37726_776d5599/
lq_nanopore:2022-01-31 16:21:50,274:252:INFO:The num of channel:512, the num of process:15
lq_nanopore:2022-01-31 16:21:50,276:89:INFO:Go into subdir for listing fast5: no_sample/20220125_1444_MC-112514_FAR37726_776d5599/fast5_fail
lq_nanopore:2022-01-31 16:21:50,277:89:INFO:Go into subdir for listing fast5: no_sample/20220125_1444_MC-112514_FAR37726_776d5599/fastq_fail
lq_nanopore:2022-01-31 16:21:50,279:89:INFO:Go into subdir for listing fast5: no_sample/20220125_1444_MC-112514_FAR37726_776d5599/fast5_pass
lq_nanopore:2022-01-31 16:21:50,280:89:INFO:Go into subdir for listing fast5: no_sample/20220125_1444_MC-112514_FAR37726_776d5599/other_reports
lq_nanopore:2022-01-31 16:21:50,282:89:INFO:Go into subdir for listing fast5: no_sample/20220125_1444_MC-112514_FAR37726_776d5599/fastq_pass
lq_nanopore:2022-01-31 16:21:50,323:186:INFO:File list loaded. Size = 114
multiprocessing.pool.RemoteTraceback:
"""
Traceback (most recent call last):
  File "/opt/conda/lib/python3.9/multiprocessing/pool.py", line 125, in worker
    result = (True, func(*args, **kwds))
  File "/opt/conda/lib/python3.9/multiprocessing/pool.py", line 48, in mapstar
    return list(map(*args))
  File "/root/LongQC/lq_nanopore.py", line 155, in wrapper
    c_id  = get_channel_id(fast5) -1
  File "/root/LongQC/lq_nanopore.py", line 120, in get_channel_id
    return int(f['/UniqueGlobalKey']['channel_id'].attrs['channel_number'])
  File "h5py/_objects.pyx", line 54, in h5py._objects.with_phil.wrapper
  File "h5py/_objects.pyx", line 55, in h5py._objects.with_phil.wrapper
  File "/opt/conda/lib/python3.9/site-packages/h5py/_hl/group.py", line 305, in __getitem__
    oid = h5o.open(self.id, self._e(name), lapl=self._lapl)
  File "h5py/_objects.pyx", line 54, in h5py._objects.with_phil.wrapper
  File "h5py/_objects.pyx", line 55, in h5py._objects.with_phil.wrapper
  File "h5py/h5o.pyx", line 190, in h5py.h5o.open
KeyError: "Unable to open object (object 'UniqueGlobalKey' doesn't exist)"
"""

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/root/LongQC/longQC.py", line 957, in <module>
    main(args)
  File "/root/LongQC/longQC.py", line 63, in main
    args.handler(args)
  File "/root/LongQC/longQC.py", line 52, in command_run
    lq_nanopore.run_platformqc(args.platform, args.raw_data_dir, args.out, suffix=suf, n_channel=512)
  File "/root/LongQC/lq_nanopore.py", line 284, in run_platformqc
    process_uncompressed_multi(p, l, bag, fcs, kits, logger)
  File "/root/LongQC/lq_nanopore.py", line 190, in process_uncompressed_multi
    rtn_state = p.map(wrapper, l)
  File "/opt/conda/lib/python3.9/multiprocessing/pool.py", line 364, in map
    return self._map_async(func, iterable, mapstar, chunksize).get()
  File "/opt/conda/lib/python3.9/multiprocessing/pool.py", line 771, in get
    raise self._value
KeyError: "Unable to open object (object 'UniqueGlobalKey' doesn't exist)"

I posted a comment, but I had missed the fact that you plan to deprecate runqc. I've deleted my comment, and will use sampleqc.


Update requirements.txt

Added flasgger==0.8.1 for swagger docs.

Codecov Report

Merging #88 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #88   +/-   ##
=======================================
  Coverage   94.06%   94.06%
=======================================
  Files           4        4
  Lines         236      236
=======================================
  Hits          222      222
  Misses         14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b3fb5d...6d5ff27. Read the comment docs.


Demo + screenshots + usecases for V2

Hey, I am very interested in V2, but there does not seem to be a demo yet, or at least I have not been able to find it. Could you create a demo (either demo server or video) for V2?

Hey, yeah, thanks for the suggestion. I will definitely create video/screenshots for it.

Hi @andrasbacsai  yes I just stumbled on Coolify and the whole project looks incredible and almost too-good-to-be-true, so not being able to see actual proof of the Dashboard/Product working on the HomePage feels unnerving.
Looks like you're trending on GitHub! :)

Am I trending? Wow! Good to know! ( I do not see it btw )
I'm thinking of a demo instance lately, but people will surely destroy it pretty fast 😁, but 🤷♂. Lets rumble!
https://demo.coolify.io/
I'll add it to the README + landing page!

I'm closing this issue, because tracking features will be moved to GitHub discussions. Github issues will be only for bugs.
Version 4 is in full focus. v3 related issues will be closed, if it is not a critical bug.
Thanks for your understanding.


SA1609 code fix throws exception for empty summary

The code fix for SA1609 throws an exception for the following code:
public class ClassName
{
    /// <summary>
    /// </summary>
    public int Property
    {
        get;
    }
}

Grabbing :+1:


WhatManager2 can't seem to bring What.CD back online...

This should be fixed immediately

+1, this is a blocker priority bug :(

@MADindustries @dangerman200k It actually can. Make sure you keep your DB safe. It contains the metadata for all the torrents and that can, in fact, kind of bring What.CD back up.

Actually, yeah, I knew that. (awesome feature by the way. you saw it coming i guess)
The bug report was intentionally tongue in cheek. Guess it didn't function as intended. Buggy report?

I'm hoping when a new site springs up, the amazing and talented karamanolev will be able to plug WhatManager databases into their API and auto-upload from the metadata... Bare in mind we also have the ReleaseInfo2.txt for each torrent that also contains all the metadata - if there is no API on the new site this file can be parsed pretty easily to give a full description of the torrent

reddit, tracker forum

Any update on this?


attachments: fix links if only one language is present

Discussed in https://github.com/McShelby/hugo-theme-relearn/discussions/501

Originally posted by piotrzawadz March 13, 2023
I've followed documentation:
https://mcshelby.github.io/hugo-theme-relearn/shortcodes/attachments/index.html

Create folder structure with md file:
catalog1/catalog2/db_administration.md

Create folder:
catalog1/catalog2/db_administration.files

add several files into it

Then run hugo command to generate static files

Deploy them into github

Eventually files are properly displayed on the page generated from db_administration.md (styles work perfectly), however when I click attachment I receive:
"Woops. Looks like this page doesn't exist ¯_(ツ)_/¯."
The generated link is:
https:///catalog1/catalog2/db_administration/.files/configure_db_txt
I've noticed that when it is change it manually to:
https:///catalog1/catalog2/db_administration.files/configure_db_txt
the file can be open.
Therefore, it looks that / is somewhere added between db2_administration and .files. Is it a bug or should I change something in my code?

@piotrzawadz: This bug is fixed in version 5.12.3


Fix issue with TimeAfterIssueDateBeforeRenewal setting

An error in how TimeAfterIssueDateBeforeRenewal is checked caused excessive certificate renewal in our environment.
We tracked it down to IsCertificateValid where isNewEnoughAccordingToNotBeforeTime is false until TimeAfterIssueDateBeforeRenewal  had passed, caused behavior opposite to what we wanted.
Also in the case that no renewal is configured, this code checks if the certificate NotBefore and NotAfter is valid.

Thank you for helping clean this up!


Update Italian translations

Thanks!

Thanks!

You has been too fast!! :win: -> https://github.com/NickeManarin/ScreenToGif/pull/558


Bugfix to work with empty messages

@ctiller - PTAL. This fixes a bug that showed up when 0 length messages are sent/received.

Test this please.

@jtattermusch , @murgatroid99 - Are these failures flakes? I don't think my change (unused code in ObjC) can cause this. Please confirm.

I restarted the basic tests. Sanity seems to have failed again (not because of your changes), so we'll probably have to restart it again. That error seems to have been fixed in other pull requests.

test this please

The flakes are still there. Any objection to merging it?

In the most recent test run, the relevant failures (specifically sanity) are now passing, and the single remaining failure appears not to be new. So, I think it's fine to merge now.

LGTM modulo the style and documentation issues.

Awesome.
Are we still doing managed merges, or can I merge?

Please merge.
On Thu, May 26, 2016 at 12:01 PM, Jorge Canizales<EMAIL_ADDRESS>wrote:

Awesome.
Are we still doing managed merges, or can I merge?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/pull/6586#issuecomment-221963381

I get this message, with the "Merge" button disabled:

Required statuses must pass before merging
All required status checks on this pull request must run successfully to enable automatic merging.

It's just waiting for Interop tests to finish.


Incorrect container counts in 'By Hostname' view

While testing the 0.12 candidate with the ECS guide demo I've noticed that the container-count labels of the nodes from the 'By Hostname' view is wrong:
There are 3 containers mapped to httpserver.weave.local and another 3 mapped to dataproducer.weave.local, but the labels read 7 containers and 9 containers:

Note how the detail panes correctly list 3 containers each.
Report: https://gist.github.com/2opremio/0cf5a67a4bd56717b9ea
Container view:

This need to be fixed before 0.12 goes out.  I'll have a stab today.
On Thu, Jan 28, 2016 at 4:19 AM, Alfonso Acosta<EMAIL_ADDRESS>wrote:

While testing the 0.12 candidate with the ECS guide
http://www.weave.works/guides/service-discovery-and-load-balancing-with-weave-on-amazon-ecs-2/
demo I've noticed that the container-number labels in the nodes from the
'By Hostname' view is wrong:
There are 3 containers mapped to httpserver.weave.local and another 3
mapped to dataproducer.weave.local, but the labels read 7 containers and 9
containers:
[image: screen shot 2016-01-28 at 12 10 26]
https://cloud.githubusercontent.com/assets/2362916/12644082/433fe8fc-c5b8-11e5-8ae6-3b090d784abf.png
[image: screen shot 2016-01-28 at 12 13 48]
https://cloud.githubusercontent.com/assets/2362916/12644189/02f06a3c-c5b9-11e5-9d31-8ead5383312a.png
Note how the detail panes correctly list 3 containers.
Report: https://gist.github.com/2opremio/0cf5a67a4bd56717b9ea
Container view:
[image: screen shot 2016-01-28 at 12 08 36]
https://cloud.githubusercontent.com/assets/2362916/12644220/4a8437d4-c5b9-11e5-8faf-70d2bfee95a6.png
—
Reply to this email directly or view it on GitHub
https://github.com/weaveworks/scope/issues/870.

In case it helps, the 'By image' view is also affected:


Breaking change on 1.10.0?

safety version: 1.10.0, 1.10.1 and 1.10.2
Python version: 3.9.1
Operating System: ubuntu-latest

Description
I have many projects using safety for some time now. After upgrading from 1.9.0 to 1.10.0, all pipelines break (also running locally). Also 1.10.2 did not fix the issue.
What I Did
I use a nox session with the command safety check --file=requirements.txt --bare
Error:
nox > Running session safety
nox > Creating virtual environment (virtualenv) using python3.9 in .nox/safety
nox > poetry export --format=requirements.txt --output=.nox/safety/tmp/requirements.txt --dev
nox > pip install --constraint=.nox/safety/tmp/requirements.txt safety
nox > safety check --file=.nox/safety/tmp/requirements.txt --bare
py
nox > Command safety check --file=.nox/safety/tmp/requirements.txt --bare failed with exit code 255
nox > Session safety failed.
Error: Process completed with exit code 1.

Ex. https://github.com/staticdev/irpf-cei/pull/327/checks?check_run_id=1679307781

It is likely to be due to the january update of the safety database (not an issue with the safety package)
You should investigate the underlying packages - possibly py.
Check this PR on my project: https://github.com/hacf-fr/renault-api/pull/127

It is likely to be due to the january update of the safety database (not an issue with the safety package)
You should investigate the underlying packages - possibly py.
Check this PR on my project: https://github.com/hacf-fr/renault-api/pull/127

@epenet I thought it could be something like that. But should´t we see the result instead of just an error code? If is just a new package that is insecure I should see that on the execution logs, right?

@epenet I thought it could be something like that. But should´t we see the result instead of just an error code? If is just a new package that is insecure I should see that on the execution logs, right?

If you remove --bare from the safety check, then it will display the details.
The --bare is added to reduce exposure (you don't want the whole world to know what makes your package insecure) but you can remove it temporarily on your local system.

If you remove --bare from the safety check, then it will display the details.
The --bare is added to reduce exposure (you don't want the whole world to know what makes your package insecure) but you can remove it temporarily on your local system.

@epenet you are correct, taking off --bare I could see the problem. This is strange, because with --bare I should be abre to see. Anyhow I don't have a way to reproduce this non-output case so I am closing this issue (can also be already fixed in latests). Thanks.

@epenet you are correct, taking off --bare I could see the problem. This is strange, because with --bare I should be abre to see. Anyhow I don't have a way to reproduce this non-output case so I am closing this issue (can also be already fixed in latests). Thanks.


link to symfony5-compatible repo

Thank you so much for this :+1:

@stof do you support this or should we wait for a new release of stof/doctrine-extensions-bundle?

@kuraobi It's pretty clear from releases

#403 is now merged.


Update protonmail-bridge-deb

Updates protonmail-bridge-deb to version 1.8.9-1

[!] ERROR: URL doesn't exist

Fix the URL.


Add a GRPC client/server to kando to run/check processes

Change Overview
New Kando Commands
Server
./kando process server -h
server

Usage:
  kando process server [flags]

Flags:
  -h, --help   help for server

Global Flags:
  -a, --address string     The path of a unix socket of the process server (default "/tmp/kanister.sock")
  -v, --verbosity string   Log level (debug, info, warn, error, fatal, panic) (default "warning")

Client
./kando process client -h
Send commands to the process server

Usage:
  kando process client [command]

Available Commands:
  create      create
  list        list
  output      output

Flags:
  -j, --as-json   Display output as json
  -h, --help      help for client

Global Flags:
  -a, --address string     The path of a unix socket of the process server (default "/tmp/kanister.sock")
  -v, --verbosity string   Log level (debug, info, warn, error, fatal, panic) (default "warning")

Use "kando process client [command] --help" for more information about a command.

Generate proto updates:
:/go/src/github.com/kanisterio/kanister# ./build/protoc.sh
protoc '--go_out=.' '--go_opt=paths=source_relative' '--go-grpc_out=.' '--go-grpc_opt=paths=source_relative' ./pkg/kanx/kanx.proto

Pull request type
Please check the type of change your PR introduces:

[x] :sunflower: Feature

Test Plan
go test -v ./pkg/kanx
=== RUN   Test
{"File":"pkg/kanx/kanx_test.go","Function":"github.com/kanisterio/kanister/pkg/kanx.(*KanXSuite).TestError.func1","Line":168,"address":{"Name":"/tmp/KanXSuite.TestError1266107833/kanx.sock","Net":"unix"},"level":"info","msg":"Listening on socket","time":"2024-04-18T22:29:25.93761862-07:00"}
{"File":"pkg/kanx/kanx_grpc.pb.go","Function":"github.com/kanisterio/kanister/pkg/kanx._ProcessService_CreateProcesses_Handler","Line":190,"level":"info","msg":"pid:482191 state:PROCESS_STATE_RUNNING","stderr":"/tmp/KanXSuite.TestError1266107833/kando.2022764142.stderr","stdout":"/tmp/KanXSuite.TestError1266107833/kando.100297899.stdout","time":"2024-04-18T22:29:25.939380505-07:00"}
{"File":"runtime/asm_amd64.s","Function":"runtime.goexit","Line":1695,"level":"info","msg":"pid:482191 state:PROCESS_STATE_FAILED exitCode:-1 exitErr:\"signal: killed\"","time":"2024-04-18T22:29:25.940065676-07:00"}
{"File":"runtime/asm_amd64.s","Function":"runtime.goexit","Line":1695,"level":"info","msg":"Gracefully stopping. Context canceled","time":"2024-04-18T22:29:25.941803878-07:00"}
{"File":"pkg/kanx/kanx_test.go","Function":"github.com/kanisterio/kanister/pkg/kanx.(*KanXSuite).TestLongProcess.func1","Line":115,"address":{"Name":"/tmp/KanXSuite.TestLongProcess3405729663/kanx.sock","Net":"unix"},"level":"info","msg":"Listening on socket","time":"2024-04-18T22:29:25.942031333-07:00"}
{"File":"pkg/kanx/kanx_grpc.pb.go","Function":"github.com/kanisterio/kanister/pkg/kanx._ProcessService_CreateProcesses_Handler","Line":190,"level":"info","msg":"pid:482195 state:PROCESS_STATE_RUNNING","stderr":"/tmp/KanXSuite.TestLongProcess3405729663/kando.640450080.stderr","stdout":"/tmp/KanXSuite.TestLongProcess3405729663/kando.670754590.stdout","time":"2024-04-18T22:29:25.942692496-07:00"}
{"File":"runtime/asm_amd64.s","Function":"runtime.goexit","Line":1695,"level":"info","msg":"pid:482195 state:PROCESS_STATE_FAILED exitCode:-1 exitErr:\"signal: killed\"","time":"2024-04-18T22:29:25.9431854-07:00"}
{"File":"runtime/asm_amd64.s","Function":"runtime.goexit","Line":1695,"level":"info","msg":"Gracefully stopping. Context canceled","time":"2024-04-18T22:29:25.946201522-07:00"}
{"File":"pkg/kanx/kanx_test.go","Function":"github.com/kanisterio/kanister/pkg/kanx.(*KanXSuite).TestParallelStdout.func1","Line":225,"address":{"Name":"/tmp/KanXSuite.TestParallelStdout3622194217/kanx.sock","Net":"unix"},"level":"info","msg":"Listening on socket","time":"2024-04-18T22:29:25.946449017-07:00"}
{"File":"pkg/kanx/kanx_grpc.pb.go","Function":"github.com/kanisterio/kanister/pkg/kanx._ProcessService_CreateProcesses_Handler","Line":190,"level":"info","msg":"pid:482196 state:PROCESS_STATE_RUNNING","stderr":"/tmp/KanXSuite.TestParallelStdout3622194217/kando.3676522233.stderr","stdout":"/tmp/KanXSuite.TestParallelStdout3622194217/kando.1459663735.stdout","time":"2024-04-18T22:29:25.947107068-07:00"}
{"File":"runtime/asm_amd64.s","Function":"runtime.goexit","Line":1695,"level":"info","msg":"pid:482196 state:PROCESS_STATE_FAILED exitCode:-1 exitErr:\"signal: killed\"","time":"2024-04-18T22:29:25.947828873-07:00"}
{"File":"runtime/asm_amd64.s","Function":"runtime.goexit","Line":1695,"level":"info","msg":"Gracefully stopping. Context canceled","time":"2024-04-18T22:29:26.082038582-07:00"}
{"File":"pkg/kanx/kanx_test.go","Function":"github.com/kanisterio/kanister/pkg/kanx.(*KanXSuite).TestServerCancellation","Line":67,"address":{"Name":"/tmp/KanXSuite.TestServerCancellation881028328/kanx.sock","Net":"unix"},"level":"info","msg":"Listening on socket","time":"2024-04-18T22:29:26.082330192-07:00"}
{"File":"runtime/asm_amd64.s","Function":"runtime.goexit","Line":1695,"level":"info","msg":"Gracefully stopping. Context canceled","time":"2024-04-18T22:29:26.082690116-07:00"}
{"File":"pkg/kanx/kanx_test.go","Function":"github.com/kanisterio/kanister/pkg/kanx.(*KanXSuite).TestShortProcess.func1","Line":77,"address":{"Name":"/tmp/KanXSuite.TestShortProcess1010242134/kanx.sock","Net":"unix"},"level":"info","msg":"Listening on socket","time":"2024-04-18T22:29:26.083038901-07:00"}
{"File":"pkg/kanx/kanx_grpc.pb.go","Function":"github.com/kanisterio/kanister/pkg/kanx._ProcessService_CreateProcesses_Handler","Line":190,"level":"info","msg":"pid:482209 state:PROCESS_STATE_RUNNING","stderr":"/tmp/KanXSuite.TestShortProcess1010242134/kando.1760524628.stderr","stdout":"/tmp/KanXSuite.TestShortProcess1010242134/kando.3646466058.stdout","time":"2024-04-18T22:29:26.161016192-07:00"}
{"File":"runtime/asm_amd64.s","Function":"runtime.goexit","Line":1695,"level":"info","msg":"pid:482209 state:PROCESS_STATE_SUCCEEDED","time":"2024-04-18T22:29:26.161705947-07:00"}
{"File":"runtime/asm_amd64.s","Function":"runtime.goexit","Line":1695,"level":"info","msg":"Gracefully stopping. Context canceled","time":"2024-04-18T22:29:26.163238424-07:00"}
OK: 5 passed
--- PASS: Test (0.23s)
PASS
ok      github.com/kanisterio/kanister/pkg/kanx 0.239s

[x] :muscle: Manual
[x] :zap: Unit test
[ ] :green_heart: E2E

The functionality appears to be a duplication of K8s exec with the addition of tracking output per-command.
I believe the main difference is that unlike exec this one will not break the long-running command execution if exec interrupts.


adding error when key is missing

resolves #212
@andrerpbts let me know how to deal with multiple rails versions

I think we don't need to deal with multiple rails versions because it's only the fallback that we automaticaly set and Knock users can change it in the config/knock.rb file into their own applications. Then, I think the solution provided here, won't work if an user sets an empty string in that file... Can you confirm it, please?
My suggestion is to transform the mattr_accessor into a class method, that will handle empty strings to raise that error. I would leave it raise NoMethodError in older versions were Rails.application.secrets doesn't exist, and user can fix that changing for the more appropriated value...
Also, I suggest to create a specific error class for that empty string exception as well...
Last, please, add some test to that 👍

Thanks for clarifying me


Scalar GPU Resource Support

From the design document referenced below:
"the focus is on supporting a narrow initial use case: homogenous machine-level GPU support (i.e. only 1 kind of GPU per machine)"
Acceptance Criteria

[ ] Introduce a new field "gpus" in the app definition alongside "mem", "cpus" and "disk". Only integer values are allowed.
[ ] Consume the appropriate amount of "gpus" when launching tasks. To be decided: Do we match a "SCALAR" "gpus" value or a "INTEGER_SCALAR" "gpus" value?
[ ] Create the appropriate user-facing documentation.

Please note that this might not fulfill all requirements. E.g. look at this user comment @air
Testing
Can we test this by simply configuring a scalar custom resource "gpus" for now? For example:
{ "name": "gpus", "type": "SCALAR", "scalar": { "value": 8 } }

Or is INTEGER_SCALAR support already available and we should rather use:
{ "name": "gpus", "type": "INTEGER_SCALAR", "integer": { "value": 8 } }

I could not find it in mesos.proto yet.
/cc @bmahler @klueska
Related Issues

Support for arbitrary resource types #375

References
Internal JIRA ticket MARATHON-209 and the design document.

any update on this?

@kolloch We worked with @klueska on MESOS 4424, wondering what is the status on Marathon support for GPU. Have you started working on it? If not we can help to expedite the development for it. Let us know

Just FYI: Hi @vditya, I will not work on Marathon anymore. So better ask e.g. @aquamatthias

Thanks for update, Hey Matthias @aquamatthias , any update on GPU support for Marathon effort. If it helps we can support that effort and work with Marathon engineer to enable it.

@vditya I've just finished the marathon API support for "gpus". Can we contribute it to here if @aquamatthias confirmed this issue is still not solved?

@Yubo-Li can you verity that it runs through this properly:
https://github.com/klueska-mesosphere/mesos-gpu-docker

Sure, I'll try and give you the result.

@klueska I verified my modification based on your docker scrpits, and it seems work fine:
root@ubuntu-x86-gpu:~/liyubo/mesos-gpu-docker# ./deploy-task.sh
{"id":"/gpu-test","cmd":"nvidia-smi; sleep 60;","args":null,"user":null,"env":{},"instances":1,"cpus":0.1,"mem":128,"disk":0,"gpus":1,"executor":"","constraints":[],"uris":[],"fetch":[],"storeUrls":[],"ports":[0],"portDefinitions":[{"port":0,"protocol":"tcp","labels":{}}],"requirePorts":false,"backoffSeconds":1,"backoffFactor":1.15,"maxLaunchDelaySeconds":3600,"container":null,"healthChecks":[],"readinessChecks":[],"dependencies":[],"upgradeStrategy":{"minimumHealthCapacity":1,"maximumOverCapacity":1},"labels":{},"acceptedResourceRoles":null,"ipAddress":null,"version":"2016-05-31T02:38:23.234Z","residency":null,"tasksStaged":0,"tasksRunning":0,"tasksHealthy":0,"tasksUnhealthy":0,"deployments":[{"id":"a8cd75e8-b69b-4f82-89f6-5767fbc5b62b"}],"tasks":[]}

And the output of the command:
[root@ubuntu-x86-gpu d8ca7aab-e2c0-4ab8-a3fd-179d4c756a96]# ls
stderr  stdout
[root@ubuntu-x86-gpu d8ca7aab-e2c0-4ab8-a3fd-179d4c756a96]# cat stdout
Received SUBSCRIBED event
Subscribed executor on <IP_ADDRESS>
Received LAUNCH event
Starting task gpu-test.becdd2cd-26d8-11e6-9c94-2ee1446b5607
Forked command at 28
sh -c 'nvidia-smi; sleep 60;'
Tue May 31 02:38:24 2016
+------------------------------------------------------+
| NVIDIA-SMI 346.46     Driver Version: 346.46         |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|===============================+======================+======================|
|   0  GeForce GTX 750     On   | 0000:02:00.0     N/A |                  N/A |
| 36%   35C    P8    N/A /  N/A |      6MiB /  1023MiB |     N/A      Default |
+-------------------------------+----------------------+----------------------+

+-----------------------------------------------------------------------------+
| Processes:                                                       GPU Memory |
|  GPU       PID  Type  Process name                               Usage      |
|=============================================================================|
|    0            C+G   Not Supported                                         |
+-----------------------------------------------------------------------------+
Command exited with status 0 (pid: 28)

I have no server with 2GPUs on hand, so I tested on 1 GPU case. Also, to make the testing running on my local environment, I also made some modifications on the code. Please see the code diff here:
https://github.com/liyubobj/mesos-gpu-docker/commit/b3e021fb10a625faa5829f3586e85b5edbc698f8
Two anothers things also need to do:

Add webUI support of GPU
Add test cases

Hi, folks, Does anyone know what's going on right now? I'm interested in Marathon support GPU, who is working on it?

Since Mesos-0.29 and 1.0 have already supported Nvidia GPUs, I am looking forward to that it happens to Marathon.
Now I can find the code of GPU only in ./src/test/scala/mesosphere/mesos/ConstraintsTest.scala, from the path, it seems it's only for test. And can not find any other GPU code in other files.
Does anyone know the progress of GPU in Marathon?

I and @klueska are working on this now. The main function is ready, and I'm still working on the testing code and code review process. Will no long time for GPU landing to Marathon:)

I'm very much interested in this feature support and have a machine with dual Titan X that I would be willing to test on if you need a multi-GPU test env.
Also, perhaps unrelated to this specific item but is there any work being done to support images built for nvidia-docker?

The mesos docker containerizer GPU support is still on-going, @klueska could give you more details.

Test cases done.

@liyubobj What the progress is going on?

@Sun-zhe The basic function is ready but I still need to find somebody who can have a code review and give me feedback...

@DaedalusX As of last week, Mesos now supports images that run on nvidia-docker (which will be included in the 1.0.0 release).  Marathon integration hasn't been added yet, but you should be able to run these images on Mesos with the mesos containerizer just fine. I am still working on full documentation for this, but it will all be ready by the time the 1.0.0 release comes out in the next week or so.

Fantastic, I'll give it a spin.

Since the documentation isn't ready yet, here's a preview to see how I've
been testing it:
Start a master node:
sudo ./bin/mesos-master.sh
--ip=<IP_ADDRESS>
--work_dir=/var/lib/mesos
Start an agent:
sudo bin/mesos-agent.sh
--master=<IP_ADDRESS>:5050
--work_dir=/var/lib/mesos
--isolation="cgroups/devices,gpu/nvidia,docker/runtime,filesystem/linux,namespaces/pid"

--image_providers=docker
--executor_environment_variables="{}"
Run an nvidia-docker image:
src/mesos-execute
--master=<IP_ADDRESS>:5050
--framework_capabilities="GPU_RESOURCES"
--name=test
--docker_image=nvidia/cuda
--command="nvidia-smi"
On Mon, Jul 11, 2016 at 11:45 AM George Cooper<EMAIL_ADDRESS>wrote:

Fantastic, I'll give it a spin.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mesosphere/marathon/issues/3795#issuecomment-231827246,
or mute the thread
https://github.com/notifications/unsubscribe/AAF4o8RR9Fn4lKkfHSlIF-M2FTnbdfUFks5qUo9hgaJpZM4IJwZA
.

@liyubobj Hi, is the code in the branch 'nvidia-gpu' of yours?

@Sun-zhe Yes, can you help review the code or find someone for it? The changes are not too much.

@Sun-zhe<EMAIL_ADDRESS>thanks！

@Sun-zhe any update on the review:
https://github.com/liyubobj/mesos-gpu-docker/commit/b3e021fb10a625faa5829f3586e85b5edbc698f8
Thanks!

@klueska , what's the result now of the documentation?

fixed #4112

@kolloch please close this issue, thanks!

Available in https://github.com/mesosphere/marathon/releases/tag/v1.3.0-RC1 Please test!


Postpone CommComm Meeting until 10/26

Due to how many people showed an interest in the CommComm meeting at Node.js Interactive in Vancouver, we need to use our secondary live streaming setup that consists of streaming from a local machine out to YouTube. This presents a challenge, and the people I know who are able to help with this are currently unavailable.
Additionally, at least four members are unable to attend because they're at a conference in NYC. With this number of members missing, and the need for a unique technical setup, I think we should postpone the meeting.
I'm proposing we move the meeting to the next meeting date, 10/26. This will also allow us to get the nodejs/make-node-meeting tool set up effectively and repeatably.
cc @nodejs/community-committee
🙏

+1 Thank you Tierney!!

May want to at-mention those who listed themselves as interested too, so people who don’t check Github obsessively aren’t confused in ~30 mins ;)

Also pinging:
@chowdhurian (Manil Chowdhury)
Toby Farley tobyfarley [at] gmail.com
@ParidelPooya (Pooya Paridel)
@rykerrumsey (Ryker Rumsey)
@baez (Behzad Karim)
@BinarySo1o (Therese Stirling)
@JemBijoux (Jem Bezooyen)
@amiller-gh (Adam Miller)
@obensource (Ben Michel - ref: #142)
@yosuke-furukawa (Yosuke Furukawa)
@Maurice-Hayward (Maurice Hayward)
@dshaw (Dan Shaw)
@mikehostetler (Mike Hostetler)

Ha, thanks @amiller-gh - my bad. ❤

+1 on postponing

Thanks for making this work and happen @bnb! Really appreciate it! 🙌
Definitely understand postponement based on needing a better setup–regarding attendance tho it might be worth considering choosing a participant minimum based on the total number of members we have to avoid possible future postponement? At very least, might be good to have for the 26th.
Sincerely, a super stoked observer. 🎉

Thanks for pinging. For those of us who are newbies, mentioning the time would help immensely so we can block off that time now.

Also for those of us who are newbies, is there any agenda? Or anything I should be prepare for it?

@paridelpooya we usually post the agenda a little bit before, but we are behind due to conference travel and agenda items discussed at the collaborator summit last week.

Date/time for the next meeting: Thursday, October 26th at 12pm ET (9am PT).
For reference, you can also add the meeting time to your calendar with the Node.js Calendar: http://nodejs.org/calendar
As @rachelnicole said, we usually post an issue the day of, or the day prior. I'd suggest making a note to check the repo for meeting details + join info beforehand.
To address your question @ParidelPooya: We build an agenda of issues tagged with cc-agenda across the Node.js GitHub org. You can request that this label be added if you think it's appropriate and should be discussed, create an issue in this repo asking for it to be added to the agenda, or comment in the agenda issue we publish before the meeting.
Thanks for the questions and feedback everyone - we're looking forward to seeing you soon! If there are topics or discussions you'd like to have, please don't hesitate to create issues in the CommComm repo - we're always open to discussions, questions, and ideas... and you're all a part of this now! ❤
cc @dshaw, @mikehostetler, @ParidelPooya, and @obensource

Closing this, since the 10/26 meeting has happened! See y'all at the next meeting ❤


Added date separators if > 1 hour between messages

Hope this is somewhat useful, didn't see any support for this common chat feature.

Thank you both guys for contribution @gabrielPeart  @blakesplay


Added @listen_to decorator + tests

Added new decorator @listen_to to listen all messages on subscribed channels
Added reply_webapi() and send_webapi() functions to use Slack Web API (allow messages formatting when using bot integration)
Added support for bot_icon and bot_emoji (used by Web API)
Allowed multiples plugins to be called for the same message

Tests are here: https://travis-ci.org/gpailler/slackbot/builds/58080039

:+1:  This PR mostly looks good to me. See my comments about tests and code styles. I think we should also update REAMDE about the listen_to decorator? (Acutally when I add a new feature I tend to update README before writing any code).

I think I applied all your comments + updated README.
New tests result: https://travis-ci.org/gpailler/slackbot/builds/59854080

Thanks! I'll make a new release soon.


Update readme to latest in maven repo

Update readme to latest available in maven repo http://mvnrepository.com/artifact/org.ektorp/org.ektorp

This is great! I was on 1.3 for a while exactly because the README mentioned it.
What do you think about using something like maven-badges to automatically have the README show the latest version uploaded to central? Then maybe it wouldn't fall out of date again in the future.

<dependency>
    <groupId>org.ektorp</groupId>
    <artifactId>org.ektorp</artifactId>
    <version><!-- latest shown above --></version>
</dependency>

+1 for the maven badge.
also the link 'Download binaries here' to the old binaries hosted on github should be removed.


feat: タグによる表示切り替え (#27)

Description: 概要

Changes: 変更内容

Changes

feat: add progress tabs (2a2823eab91497ef627c64b2fc2a815633beb946)
chore: update snapshots (ef4594a3f93720a25e8bd47cfb52089e8a1cd214)
chore: tweaks (9b0c4145666ec4ce007c6ca18bf41ec0659f3159)

Expected Impact: 影響範囲

Operating Requirements: 動作要件

Additional context: 補足

Codecov Report

Merging #59 (9b0c414) into release/next-v0.4.0 (aab616a) will increase coverage by 0.04%.
The diff coverage is 95.45%.

@@                   Coverage Diff                   @@
##           release/next-v0.4.0      #59      +/-   ##
=======================================================
+ Coverage                96.72%   96.76%   +0.04%
=======================================================
  Files                      152      153       +1
  Lines                     1373     1390      +17
  Branches                   240      242       +2
=======================================================
+ Hits                      1328     1345      +17
- Misses                      27       28       +1
+ Partials                    18       17       -1

Impacted Files
Coverage Δ

src/infra/web/pages/index/hooks/data.ts
100.00% <ø> (ø)

src/infra/web/pages/index/view.stories.tsx
100.00% <ø> (ø)

src/infra/web/components/layout/tab.tsx
93.75% <93.75%> (ø)

src/domain/shared/task/valueObject/status.ts
100.00% <100.00%> (ø)

src/infra/web/pages/index/view.tsx
100.00% <100.00%> (ø)

src/infra/web/components/button/iconButton.tsx
100.00% <0.00%> (+33.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aab616a...9b0c414. Read the comment docs.


fix: updated to angular 7

Updated package to angular 7.1.2, including updating to rxjs 6.
All supporting applications being updated to latest version.
TSLint standards updated throughout codebase.
RXJS 6 implimentations of existing calls updated.
Import statments formatted for consistancy.
This update has updated the masl-angular project to be inline with the
lastest version of angular. The supporting packages have been updated
and many formatting changes have been made for consistancy.
The Sample package is out of date with the codebase as it wont work
without the lastest version of msal being in NPM. this will have its own
PR raised when appropriate.
I believe this is not completely compatible with Edge or IE still, as
there is other outstanding issues within the package, more PR's will be
raised for these issues also.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Dedme sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@nehaagrawal would you be able to review when you get a chance?
As a side note, would this PR be easier to review if the code formatting was postponed to a separate PR?

@danieladams456 @Dedme Thank you for your patience, I will be reviewing this PR later today. If possible, it would be very helpful to separate the code formatting into a separate PR. Thanks!

thank you for taking action on this so fast.

If possible, it would be very helpful to separate the code formatting into a separate PR.
i don't have time to get my hands on code for a little while, and it might take some time to rework this into 2 PR's. But if its too much in a single PR i can look at doing this towards the end of the month.

Are there any updates on this issue, or any official workarounds to use in the meantime? As this is going to be used in prod I'd rather not use @Dedme solution yet if the team have found issues with it.

Are there any updates on this issue, or any official workarounds to use in the meantime? As this is going to be used in prod I'd rather not use @Dedme solution yet if the team have found issues with it.
Not to my knowledge.
As @navyasric wrote the team is focusing on changing and improving the core library first. That work will result in a version 0.3 release of the msal js library.
Once that is done, the next release on the roadmap is an update of the msal-angular / msal-angularjs.

On a side note - my current project is using the existing msal-angular library with Angular 7, and we have not experienced any issues.
As far as I recall, the only thing I had to change back then was to add rxjs and rxjs-compat to my package.json
    "rxjs": "~6.3.3",     "rxjs-compat": "^6.3.3",

Are there any updates on this issue, or any official workarounds to use in the meantime? As this is going to be used in prod I'd rather not use @Dedme solution yet if the team have found issues with it.

Not to my knowledge.
As @navyasric wrote the team is focusing on changing and improving the core library first. That work will result in a version 0.3 release of the msal js library.
Once that is done, the next release on the roadmap is an update of the msal-angular / msal-angularjs.
On a side note - my current project is using the existing msal-angular library with Angular 7, and we have not experienced any issues.
As far as I recall, the only thing I had to change back then was to add rxjs and rxjs-compat to my package.json
"rxjs": "~6.3.3", "rxjs-compat": "^6.3.3",

@frjtrifork I have tried updating rxjs and rxjs-compat also, and it is working in certain scenarios.
My issue comes with ng build --prod, when I release a prod build in angular 7 I am getting null redirect URI passed back (see screenshot).  This does not happen on a normal dev build.
Secondly the dev builds appear to work fine on desktop, but are doing some odd stuff on Android chrome and Edge so have not persisted with these for now.

Are there any updates on this issue, or any official workarounds to use in the meantime? As this is going to be used in prod I'd rather not use @Dedme solution yet if the team have found issues with it.

Not to my knowledge.
As @navyasric wrote the team is focusing on changing and improving the core library first. That work will result in a version 0.3 release of the msal js library.
Once that is done, the next release on the roadmap is an update of the msal-angular / msal-angularjs.
On a side note - my current project is using the existing msal-angular library with Angular 7, and we have not experienced any issues.
As far as I recall, the only thing I had to change back then was to add rxjs and rxjs-compat to my package.json
"rxjs": "~6.3.3", "rxjs-compat": "^6.3.3",

@frjtrifork I have tried updating rxjs and rxjs-compat also, and it is working in certain scenarios.
My issue comes with ng build --prod, when I release a prod build in angular 7 I am getting null redirect URI passed back (see screenshot). This does not happen on a normal dev build.

I build the same way for production and don't have that issue.
I have specified the redirectUri for our different environments in environment.ts, environment.prod.ts, environment.staging.ts etc. files.
When just doing ng build, the environment.ts file is used directly, and when doing ng build --prod, the environment.prod.ts file replaces the environment.ts file. (Configured in angular.json in the "configurations" section).
This is just a guess, but if you have done the same, a null redirectUri only when building for production could indicate that you have defined the redirectUri in only one of the files?

Secondly the dev builds appear to work fine on desktop, but are doing some odd stuff on Android chrome and Edge so have not persisted with these for now.

I have only used it for desktops, so I don't have any experience with msal on mobile browsers yet.

Regarding the null redirectUri in production.
If you are using window.location to set the redirectUri in your msal configuration object dynamically then I think it is because of AOT you are getting null when making a production build.
See this issue for an explanation https://github.com/angular/angular-cli/issues/10957
We set static values for the redirectUri in different environment files that are replaced when building and that works, also with aot enabled.
/Flemming
On 14 Feb 2019, 22.53 +0100, silver-stack<EMAIL_ADDRESS>wrote:
Are there any updates on this issue, or any official workarounds to use in the meantime? As this is going to be used in prod I'd rather not use @Dedmehttps://github.com/Dedme solution yet if the team have found issues with it.
Not to my knowledge.
As @navyasrichttps://github.com/navyasric wrote the team is focusing on changing and improving the core library first. That work will result in a version 0.3 release of the msal js library.
Once that is done, the next release on the roadmap is an update of the msal-angular / msal-angularjs.
On a side note - my current project is using the existing msal-angular library with Angular 7, and we have not experienced any issues.
As far as I recall, the only thing I had to change back then was to add rxjs and rxjs-compat to my package.json
"rxjs": "~6.3.3", "rxjs-compat": "^6.3.3",
@frjtriforkhttps://github.com/frjtrifork I have tried updating rxjs and rxjs-compat also, and it is working in certain scenarios.
My issue comes with ng build --prod, when I release a prod build in angular 7 I am getting null redirect URI passed back (see screenshot). This does not happen on a normal dev build.
Secondly the dev builds appear to work fine on desktop, but are doing some odd stuff on Android chrome and Edge so have not persisted with these for now.
[msal-angulat-7-error]https://user-images.githubusercontent.com/39124050/52820019-ba4db200-30a2-11e9-8d7a-18e5e3c4e67c.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/AzureAD/microsoft-authentication-library-for-js/pull/524#issuecomment-463814221, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAxav5NsAer7bNqMyxfCvGze0UGXU152ks5vNdrAgaJpZM4ZmD7-.

Regarding the null redirectUri in production. If you are using window.location to set the redirectUri in your msal configuration object dynamically then I think it is because of AOT you are getting null when making a production build. See this issue for an explanation angular/angular-cli#10957 In our project, we set static values for the redirectUri in different environment files that are replaced when building and that works, also with aot enabled. We only deploy to 3-4 different locations - so that is ok for us. There is also a request for supporting dynamic configuration in this msal issue that has some helpful comments - #481

I think you have hit the nail on the head, with this one.  We are indeed setting the following in our prod config:
    redirectUri:  window.location.origin + '/',
    postLogoutRedirectUri:  window.location.origin + '/',

We are not going live for about a month, so things like this have been a bit on the back burner, however it is a real help to find this out now.
I'll update our prod and test later today then report back.

@frjtrifork You were spot on with that tip off, I changed the window.location.origin to the full redirect URI for prod env and it worked a treat thank you.  Maybe I should have done some more research before writing it off ;)
Thanks again, I appreciate you taking the time to comment.

Using the current msal-angular (0.1.2) with Angular 7.2.0. I added 'rxjs-compat' as @frjtrifork mentioned. Everything seems to work fine on my local testing. When I deployed the application to Azure web services, the application stuck in a dead loop of Sign In page. Anybody has the same problem?
Also I tried to use 'popup: true' as others' suggested, but got running time error.

Using the current msal-angular (0.1.2) with Angular 7.2.0. I added 'rxjs-compat' as @frjtrifork mentioned. Everything seems to work fine on my local testing. When I deployed the application to Azure web services, the application stuck in a dead loop of Sign In page. Anybody has the same problem?
Also I tried to use 'popup: true' as others' suggested, but got running time error.

If it works for you locally, then there should be no difference for a production environment except the configuration. Have you checked if your redirectUri is configured correctly for the production environment?
Also if an error is returned from azure when you start looping - that might also contain useful information for locating the issue. The error message is part of the URL redirect - I usually locate it using Chrome developer tools and inspect the network tab.

There's a new functioning workaround to the window.location issue if anyone still cares.  It delays initialization of Msal* until after the page loads by providing it manually.  You return the config in a factory / arrow function, which means you can do whatever you want on-client before setting the config.

any news on that?

Any news on this?

Our roadmap is updated now with tentative dates for angular upgrade with our core library msal 1.0.0 changes. Please expect this feature to be a part of the same.

Closing, as we'll be upgrading msal-angular to support the latest versions of Angular this quarter.

I have the following ==> error error: endpoint resolution error: endpoints cannot be resolved
What I have seen is that my authority changes to lowercase, the library converts to lowercase in the UserAgentApplication.js file
UserAgentApplication.prototype.loginPopup = function (scopes, extraQueryParameters) {         var _this = this;         /*         1. Create navigate url         2. saves value in cache         3. redirect user to AAD          */         return new Promise(function (resolve, reject) {             if (_this._loginInProgress) {                 reject(Constants_1.ErrorCodes.loginProgressError + "|" + Constants_1.ErrorDescription.loginProgressError);                 return;             }             if (scopes) {                 var isValidScope = _this.validateInputScope(scopes);                 if (isValidScope && !Utils_1.Utils.isEmpty(isValidScope)) {                     reject(Constants_1.ErrorCodes.inputScopesError + "|" + Constants_1.ErrorDescription.inputScopesError);                     return;                 }                 scopes = _this.filterScopes(scopes);             }             else {                 scopes = [_this.clientId];             }             **var scope = scopes.join(" ").toLowerCase();**             var popUpWindow = _this.openWindow("about:blank", "_blank", 1, _this, resolve, reject);             if (!popUpWindow) {                 return;             }             _this._loginInProgress = true;             _this.authorityInstance.ResolveEndpointsAsync().then(function () {                 var authenticationRequest = new AuthenticationRequestParameters_1.AuthenticationRequestParameters(_this.authorityInstance, _this.clientId, scopes, ResponseTypes.id_token, _this._redirectUri, _this._state);                 if (extraQueryParameters) {                     authenticationRequest.extraQueryParameters = extraQueryParameters;                 }                 _this._cacheStorage.setItem(Constants_1.Constants.loginRequest, window.location.href);                 _this._cacheStorage.setItem(Constants_1.Constants.loginError, "");                 _this._cacheStorage.setItem(Constants_1.Constants.nonceIdToken, authenticationRequest.nonce);                 _this._cacheStorage.setItem(Constants_1.Constants.msalError, "");                 _this._cacheStorage.setItem(Constants_1.Constants.msalErrorDescription, "");                 var authorityKey = Constants_1.Constants.authority + Constants_1.Constants.resourceDelimeter + authenticationRequest.state;                 if (Utils_1.Utils.isEmpty(_this._cacheStorage.getItem(authorityKey))) {                     _this._cacheStorage.setItem(authorityKey, _this.authority);                 }                 var urlNavigate = authenticationRequest.createNavigateUrl(scopes) + "&prompt=select_account" + "&response_mode=fragment";                 window.renewStates.push(authenticationRequest.state);                 window.requestType = Constants_1.Constants.login;                 _this.registerCallback(authenticationRequest.state, scope, resolve, reject);                 if (popUpWindow) {                     _this._logger.infoPii("Navigated Popup window to:" + urlNavigate);                     popUpWindow.location.href = urlNavigate;                 }             }, function () {                 _this._logger.info(Constants_1.ErrorCodes.endpointResolutionError + ":" + Constants_1.ErrorDescription.endpointResolutionError);                 _this._cacheStorage.setItem(Constants_1.Constants.msalError, Constants_1.ErrorCodes.endpointResolutionError);                 _this._cacheStorage.setItem(Constants_1.Constants.msalErrorDescription, Constants_1.ErrorDescription.endpointResolutionError);                 if (reject) {                     reject(Constants_1.ErrorCodes.endpointResolutionError + ":" + Constants_1.ErrorDescription.endpointResolutionError);                 }                 if (popUpWindow) {                     popUpWindow.close();                 }             }).catch(function (err) {                 _this._logger.warning("could not resolve endpoints");                 reject(err);             });         });     };


Add my first file

I have created a new branch, created a file, and made a commit.

Task completed.


Use Clipper2Lib/ subfolder for public headers?

https://github.com/AngusJohnson/Clipper2/blob/29003e6e3aded084ae53d47e4d7f6c75ddc625b3/CPP/CMakeLists.txt#L31-L32
--> It would be great if we could change the official include folders to be able to write #include <Clipper2Lib/clipper.h> instead of #include <clipper.h>. Since clipper.h is a very common name, and there can be confusion with clipper 1, enforcing the use of the subfolder name for public headers would avoid a lot of integration issues I think.

Angus,
following the common practice, it's better to use clipper2 subfolder, but the OP's idea is right one.
Regards,
Sergey

Thanks. This issue has been sitting here partly because I've been occupied with other things but also because I don't know what changes are needed in the makefile and whether the folder structure needs changing too.

Angus,
I am preparing the package for Fedora Core, so I have to push some changes to the c++ cmake file. I will include this as well and come back with PR to you.
Thank you,
Sergey

implemented in #243

As mentioned in #243, if we want to use clipper2/ as the official public header directory, then the folder structure will need changing accordingly. Copying header files to a different folder name at install is suboptimal as it only provide a cmake-specific solution when clipper2 is installed on the system via CMake. Having a folder structure that directly mimics the intended public folder structure is preferable, and would also work when using clipper2 as a subproject (e.g. via CMake FetchContent + add_subdirectory()).

Angus,
taking to account @jdumas' considerations, do we reorganize directories and split headers into separate subdir?


0 (zero) semantic_loss during training groupfree

Hello,
I have a custom pointcloud dataset of single class. I convert it into scannet format as:

I assign instance_mask=-1 for background points and instance_mask=0,1,2... for object points.
I assign semantic_mask=0 for background points and semantic_mask=1 for object points.

Then I set valid_cat_ids=[1] in config.
I use scannet dataset config and groupfree model config.
Center/objectness/size_res losses are non-zero and converging but semantic_loss'es are always zero.
How do I fix it? What am I doing wrong?

Can you provide your config? and have you ever checked the prediction and gt which are used to calculate the semantic_loss while training?

Close due to inactivity. Please feel free to reopen it if there is any further question.


Upgrade library to Turbo 7

Few days ago the new version of Turbolinks (7) got released, which fixes some of the Android problems existing with the 5 version.
Do you think it'll be possible to migrate to that new version to use it with React Native?

Sure its my plan, but will require some work mainly on android version.. I think i will need rewrite it in kotlin and has many breaking changes...

https://github.com/lazaronixon/react-native-turbo so far so good...

https://github.com/lazaronixon/react-native-turbo so far so good...


Ability to get item ID after save

I'm making a very basic API with the basic ResourceController using vapor.
Since there is already an id on the Model protocol, which is "nil when not saved yet", it would be cool if there was some way to get the id after saving.
Maybe save could populate the id field, or return an id, or maybe return a newly instantiated model with the id filled in.
That way, when a user makes a POST request, they can actually know the ID of the object to fetch it again.

Great idea.

👍

This has been implemented


$ionicDepoly.download is not working

$ionicDeploy.check();
This function is working fine, but download function is not working.
Here is my code.
$ionicDeploy.download().then(function() {
// Extract the updates
$ionicDeploy.extract().then(function() {
// Load the updated version
$ionicDeploy.load();
}, function(error) {
// Error extracting
alert(error);

  }, function(progress) {
    // Do something with the zip extraction progress
    //$scope.extraction_progress = progress;
   alert(progress)
  });
}, function(error) {
  // Error downloading the updates
  alert(error);
}, function(progress) {
  alert(progress);
});

Even I can't see any error alerts.
I tracked log, but no error logs too.
I attached last part of log as image.
Any helps would be great.
Thanks.

Have you deployed a version yet?

Thanks for your response.
Yes. I did it.
I tried to deploy it several times and now its working. Don't know why it didn't worked at the moment.
By the way, I noticed I can't use this function here in China.
Is there any solution for us?

I'm confused, you're saying it's working now, but you can't use it in China?


CoreOS to Flatcar migration

What feature would you like to be added?
Because of approaching CoreOS EOL we need to prepare migration to Flatcar: decide if we need to automate migration from CoreOS to Flatcat
UPDATE (26/04/2020):
Support for Flatcar Linux has landed in the source tree, now it depends on the machine-controller to start supporting all the providers (at the moment it's AWS only).
UPDATE (28/04/2020):
CoreOS -> Flatcar Linux migration doc and shell script

OK, since there is an upstream-provided migration shell script, we don't need to do anything here.


Better spy support + argumentCaptor + tests

Making a pull request against dev branch, as you requested

Great stuff!

Thanks for merging! Do you have plans to make a release soon?
On Fri, 19 Feb 2016, 20:52 Niek Haarman<EMAIL_ADDRESS>wrote:

Merged #12 https://github.com/nhaarman/mockito-kotlin/pull/12.
—
Reply to this email directly or view it on GitHub
https://github.com/nhaarman/mockito-kotlin/pull/12#event-556957497.

I'm looking into adding more of the Mockito API to the library for easy usage. Expect something in the next couple of days.

Any news on the release? :-)

Would love a release with the argumentCaptor!

Sorry it took a while guys, 0.3.0 has just been released.


[unstable option] enum_discrim_align_threshold

Tracking issue for unstable option: enum_discrim_align_threshold

I was looking at the vertical alignment options of rustfmt. I was suprised by this.
20:
enum Foo {
    A   = 0,
    Bb  = 1,
    RandomLongVariantGoesHere = 10,
    Ccc = 2,
}

enum Bar {
    VeryLongVariantNameHereA = 0,
    VeryLongVariantNameHereBb = 1,
    VeryLongVariantNameHereCcc = 2,
}

I would expect this:
enum Foo {
    A   = 0,
    Bb  = 1,
    RandomLongVariantGoesHere = 10,
    Ccc = 2,
}

enum Bar {
    VeryLongVariantNameHereA   = 0,
    VeryLongVariantNameHereBb  = 1,
    VeryLongVariantNameHereCcc = 2,
}

I think it would make more sense if the threshold would refer to the maximum number of spaces to insert to make things align. The length of the actual text doesn't seem to be very relevant here. It's just when one starts to align very long items with very short items it looks a bit weird to people, but personally I still prefer it most of the times. Another reason to limit vertical alignment might be the resulting total line length.
Maybe this could fall into a more general category of "align assignment operator"?

I agree with the above, and would be happy to look into making a PR if it's something that's wanted.

Any blocking issues on stabilizing this feature? We've been using it for years, pretty happy with it, and its currently the last remaining reason we still have nightly installed.

Any blocking issues on stabilizing this feature? We've been using it for years, pretty happy with it, and its currently the last remaining reason we still have nightly installed.

See #5365 and #5367 for general information on stabilization. I don't know the answers/details of those items for this specific option, but it's the material that would need to be attested to in order for this option to be judged as ready


Bug 2107073: [release-4.10] mark enableRookCSICephFS as true always in consumer cluster

We do not want to disable CephFS CSI driver in consumer mode since
CephFS storageclass is available by default.
This is a fix for the problem that ROOK_CSI_ENABLE_CEPHFS is "false" after upgrading the provider cluster alone to ODF 4.11.0.
Fixes-
https://bugzilla.redhat.com/show_bug.cgi?id=2110274
https://bugzilla.redhat.com/show_bug.cgi?id=2107073
This is the manual backport of this PR-https://github.com/red-hat-storage/ocs-operator/pull/1710.
Which was a fix for https://bugzilla.redhat.com/show_bug.cgi?id=2096823. A manual backport was chosen as there was a chain of merge conflicts with automated cherry-pick.

/bugzilla refresh

/hold

/bugzilla refresh

/hold cancel
/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest


enabling codecov

[ ] I have added the tests to cover my changes.
[ ] I have updated the documentation and CHANGELOG accordingly.
[ ] I have read the CONTRIBUTING document.

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@858c5e9). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop      #24   +/-   ##
==========================================
  Coverage           ?   96.64%
==========================================
  Files              ?        2
  Lines              ?      179
  Branches           ?        0
==========================================
  Hits               ?      173
  Misses             ?        6
  Partials           ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Update OpenChallenges app routes to use Ng v15 router

See the example from this article.

@rrchai Let's define all the routes we need this month or the next one. Meanwhile, we can start using Angular v15 route API (see article above).

focus on the router improvement of lazyLoad, or any other improvements from ng v15 can make app better. But if it's too complicate changes, make the conclusion here.

Moved to Sprint 23.02


Uncaught TypeError: Cannot read property 'item' of undefined (remote-ftp.js:333)

[Enter steps to reproduce below:]

Rightclick CSS file
Select "Sync Local -> Remote"
Get error message

Manual upload work. Download, too.
But I need such sync feature. :(
OS: Win 8.1
Atom Version: 0.188.0
System: WINDOWS
Thrown From: Remote-FTP package, v0.6.2
Stack Trace
Uncaught TypeError: Cannot read property 'item' of undefined
At C:\Users\User\.atom\packages\Remote-FTP\lib\remote-ftp.js:333

TypeError: Cannot read property 'item' of undefined
  at C:\Users\User\.atom\packages\Remote-FTP\lib\remote-ftp.js:333:20
  at e (C:\Users\User\.atom\packages\Remote-FTP\lib\client.js:490:18)
  at n (C:\Users\User\.atom\packages\Remote-FTP\lib\client.js:497:16)
  at C:\Users\User\.atom\packages\Remote-FTP\lib\client.js:522:7
  at e (C:\Users\User\.atom\packages\Remote-FTP\lib\client.js:381:14)
  at C:\Users\User\.atom\packages\Remote-FTP\lib\client.js:387:13
  at FSReqWrap.oncomplete (fs.js:100:15)

Commands
     -9:10.3 sass-watch:watch (atom-text-editor.editor)
     -8:59.7 core:confirm (atom-text-editor.editor.mini)
     -8:46.6 command-palette:toggle (atom-text-editor.editor)
     -8:43.7 core:move-down (atom-text-editor.editor.mini)
     -8:38.8 core:move-up (atom-text-editor.editor.mini)
     -8:38.6 core:confirm (atom-text-editor.editor.mini)
     -8:38.5 sass-watch:list (atom-text-editor.editor)
  3x -8:29.8 core:save (atom-text-editor.editor)
     -3:42.3 remote-ftp:connect (ul.progress.tool-panel.panel-top)

Config
{
  "core": {
    "themes": [
      "atom-light-ui",
      "atom-light-syntax"
    ],
    "disabledPackages": [
      "SFTP-deployment",
      "language-c",
      "language-clojure",
      "language-coffee-script",
      "language-csharp",
      "language-gfm",
      "language-go",
      "language-java",
      "language-make",
      "language-objective-c",
      "language-perl",
      "language-shellscript",
      "language-toml",
      "language-yaml",
      "language-mustache"
    ]
  },
  "Remote-FTP": {
    "hideLocalWhenDisplayed": true
  }
}

Installed Packages
# User
autocomplete-plus, v2.7.0
autocomplete-snippets, v1.2.0
color-picker, v1.5.0
keyboard-localization, v1.1.6
linter, v0.12.0
linter-php, v0.0.11
linter-phpcs, v0.0.12
minimap, v4.6.0
project-manager, v1.15.5
Remote-FTP, v0.6.2
sass-watch, v0.2.0
save-session, v0.12.4
wordpress-api, v1.2.0

# Dev
No dev packages

Fixed Sync remote -> local in 1625496e73186223eb2093478fb87975bd9fbdff
I cant reproduce this problem after the fix.


LLVM crosscompile x64 for ARM64

Linux x64 now properly builds ARM64 versions of LLVM. Unfortunately, I can't seem to power on my last Intel Mac, so until I find a system to test on I can't verify it. If the CI could run it in the meantime I'd much appreciate it. EDIT: I was able to get it to build in a Rosetta context. If it works I'll upgrade this PR to ready.

OK good news looks like the Mac cross compile path works as well. I've updated with the changes requested. The flag you mentioned didn't seem to be needed, but if it's there it's also not hurting anything so I'm inclined to leave it in case it's needed for a particular host configuration that I haven't tested.

Just did. Yep, looks like you'll need to apt install g++-aarch64-linux-gnu gcc-aarch64-linux-gnu before the build process. Unfortunately I'm not familiar with GitHub actions, but I'm assuming there's an easy way to do environment configuration. Mac looks like it's cooking along nicely tho. I'll try the generated artifacts shortly.


TL-28813: Add Transaction ID

Ticket: https://triplelift.atlassian.net/browse/TL-28813 - conversation screen grab is included in ticket
This PR allows for our bid adapter to pass auction ID to transaction ID. This PR includes 1 test - to check if the data object includes source.tid. We are using the bidRequests[0] similarly to other adapters that pass multiple bid requests.

@allison3lift Prebid has an actual field called transactionId. I believe that's the one we should be using (vs. auctionId,) I'd say 95% sure that will be the case per. https://github.com/prebid/Prebid.js/issues/8573
This is also worth keeping an eye on https://github.com/prebid/Prebid.js/issues/8543 but I need to digest that still

closing due to new direction from prebid


Add nomad installation and configuration to our ansible playbook

In #79, we improved the documentation for configuring Nomad for Poseidon. Another way to document these requirements would be to add the installation of Nomad (and required plugins) to our ansible playbook.
Originally posted by @mpass99 in https://github.com/openHPI/poseidon/pull/79#discussion_r773921190

The ansible playbook here may help implementing the automated Nomad configuration.

In the past days, I spent a lot of time to finally move this ticket forward. After finishing the resource creation via Terraform, I now also tackled the provisioning using Ansible:

By today, I am using a program called terraform-inventory to query the inventory for Ansible dynamically from the Terraform state.
Based on this inventory, I am running multiple playbooks to the different hosts and not only covered Nomad (with agents and servers), but also the generation of certificates (for the CA and the browser) and Poseidon.
Additionally, a GitLab CI/CD pipeline allows the execution of all steps remotely without a local setup.

In order to close this issue, I would kindly ask you to:

[ ] Checkout the repo locally:

[ ] Is the documentation clear?
[ ] Can you install the required dependencies and execute

[ ] Terraform
[ ] Ansible

[ ] Did I integrate everything from our the playbooks you created previously? (I used them as a base for the ones I create)

[ ] Test the GitLab CI pipeline:

[ ] Can you run it?
[ ] Is the pipeline clear?

[ ] Test the deployment:

[ ] Is everything working as expected? I deployed (Nomad + Poseidon) to Staging with the -terraform suffix. You may choose to remove and redeploy there (of course, you might also adapt the count value or other variables)  :)
[ ] Did I miss anything?

Please let me know what you think; looking forward to your feedback! Once you approved the changes (and we close this ticket), I'll switch to a Terraform + Ansible-managed system for Staging and Production.

It's awesome! Please have a look at codeocean-terraform/53 for the review

We finalised our playbooks and the Terraform integration and therefore can close this issue.


Proposal: Support UIViewController with custom components

I'm creating a custom component using a external SDK ( Scandit ).
The problem is:
The view method from RCTViewManger needs to return a  instance of UIView but the Scandit SDK provides me a UIViewController instance.
I can change the rootViewController with the ScanditViewController but doing that I lose the navigation and I can't render others react components in the same scene.

We have a couple of other components that wrap UIViewControllers, such as Navigator and TabBarIOS. Might be worth taking a look at how they are implemented.
The basic idea is that your component returns a view, but when that view is mounted, it walks up the responder chain to find the nearest parent view controller, then creates a view controller instance of its own and inserts it into the VC hierarchy.
In this way, we invert the normal order of things by having our views manage their view controllers instead of the other way round, which may seem a little weird, but it allows us to keep the concept of View Controllers out of the client side abstraction, and leave them as an iOS-specific implementation detail.

RCTScandit.m

#import "RCTScandit.h"
#import <ScanditBarcodeScanner/ScanditBarcodeScanner.h>
@implementation RCTScandit

/*
// Only override drawRect: if you perform custom drawing.
// An empty implementation adversely affects performance during animation.
*/

-(void)viewDidLoad {
  [super viewDidLoad];

  [self overlayAsView];

}

- (void)barcodePicker:(SBSBarcodePicker *)picker didScan:(SBSScanSession *)session {
  NSArray* recognized = session.newlyRecognizedCodes;
  SBSCode *code = [recognized firstObject];
  // add your own code to handle the barcode result e.g.
  NSLog(@"scanned %ld barcode: %@", (long)code.symbology, code.data);
}

- (void)overlayAsView {

  SBSScanSettings* scanSettings = [SBSScanSettings defaultSettings];
  scanSettings.cameraFacingPreference = SBSCameraFacingDirectionBack;
  [scanSettings setSymbology:SBSSymbologyEAN13 enabled:YES];
  [scanSettings setSymbology:SBSSymbologyUPC12 enabled:YES];
  [scanSettings setSymbology:SBSSymbologyQR enabled:YES];

  self.picker = [[SBSBarcodePicker alloc] initWithSettings:scanSettings];
  self.picker.scanDelegate = self;

  [self addChildViewController:self.picker];
  [self.view addSubview:self.picker.view];
  [self.picker didMoveToParentViewController:self];

  [self.picker startScanning];

}
@end

RCTScanditManager.m

#import "RCTScanditManager.h"
#import "RCTScandit.h"

@implementation RCTScanditManager
RCT_EXPORT_MODULE();

- (UIView *)view
{
  RCTScandit *scandit = [[RCTScandit alloc] init];
  return scandit.view;
}

@end

This is what I have.
I'm returning the view property of the UIViewController.
If I run this code in a native iOS project it works fine.
When I try to run as a react-native component it renders the view overlay but the camera doesn't start.
The app even ask for camera permission but the part of the camera in the view stays black.
I debugged it and it is passing through the part of the code which start the camera, so I kinda don't know what to expect.
I'm not a iOS developer so I'm struggling to gather some knowledge about the iOS concepts and functionalities

@lucasfeliciano the RCTScandit instance will be released as soon as the view has been created and returned in the RCTScanditManager.m file, as you aren't retaining any references to it.
Instead of making RCTScandit a UIViewController subclass, make it a UIView subclass, and return it directly instead of returning its view. Something like this:

RCTScandit.m

#import "RCTScandit.h"
#import <ScanditBarcodeScanner/ScanditBarcodeScanner.h>
@implementation RCTScandit

/*
// Only override drawRect: if you perform custom drawing.
// An empty implementation adversely affects performance during animation.
*/

- (void)barcodePicker:(SBSBarcodePicker *)picker didScan:(SBSScanSession *)session
{
  NSArray *recognized = session.newlyRecognizedCodes;
  SBSCode *code = [recognized firstObject];
  // add your own code to handle the barcode result e.g.
  NSLog(@"scanned %ld barcode: %@", (long)code.symbology, code.data);
}

- (instancetype)initWithFrame:(CGRect)frame
{
  if ((self = [super initWithFrame:frame])) {
    SBSScanSettings* scanSettings = [SBSScanSettings defaultSettings];
    scanSettings.cameraFacingPreference = SBSCameraFacingDirectionBack;
    [scanSettings setSymbology:SBSSymbologyEAN13 enabled:YES];
    [scanSettings setSymbology:SBSSymbologyUPC12 enabled:YES];
    [scanSettings setSymbology:SBSSymbologyQR enabled:YES];

    self.picker = [[SBSBarcodePicker alloc] initWithSettings:scanSettings];
    self.picker.scanDelegate = self;

    [self addSubview:self.picker.view];

    [self.picker startScanning];
  }
  return self;
}

- (void)layoutSubviews
{
  [super layotuSubviews];
  self.picker.view.frame = self.bounds;
}

@end

@nicklockwood Thank you for your reply man.
I got some progress here.
I make those changes and now the view doesn't show anything besides a white screen in the other hand it is handling the scan.
I can put a barcode in front of the camera and it is logging into the console the barcode.
I'll keep debugging here to try to figure it out what is going on, but if you have anything in mind let me know :)

Maybe because the frame is 0 0?
<RCTScandit: 0x1366de9d0; frame = (0 0; 0 0); layer = <CALayer: 0x1366deb50>>

The frame of RCTScandit will also be zero when it's created. It will then be updated after layout happens. The purpose of the layoutSubviews method is to update the underlying picker view's frame to match RCTScandit when that happens.

yeah, make sense but I need to call the the initWithFrame method, right?
RCTScandit *scandit = [[RCTScandit alloc] initWithFrame:CGRect];
Like this, and probably create the CGRect with the size of my screen, right?
How can I get this values from the RCTScanditManager.m
This are the headers that I'm importing
#import "RCTBridge.h"
#import "RCTViewManager.h"
#import "RCTScandit.h"

No. [[RCTScandit alloc] init] calls [[RCTScandit alloc] initWithFrame:CGRectZero] which is the expected behaviour. The frame will be set later by React Native - you shouldn't set it when the view is created because the frame is controlled by flexbox.
Of course, if you aren't setting the view size in your JS component styles then it will still have a size of zero.

Got it.
And makes sense.
Question, when the code execute the startScanning method is the component already rendered?
[self.picker startScanning];
Because the camera is working if I put a barcode in front of the camera it calls the callback and print the code but there is no camera rendered.

when the code execute the startScanning method is the component already rendered?

No, it wouldn't be. If you want to defer the scanning until the component is rendered, you could put this in RCTScandit.m:
- (void)didMoveToWindow
{
  [super didMoveToWindow];
  if (self.window) {
    [self.picker startScanning];
  } else {
    [self.picker stopScanning];
  }
}

@nicklockwood THANK YOU, really!
It is working!
:heart:
Time to implement the api and the property for the component :D
Closing issue :)


Populate staging with the same or bigger number of identities as prod

Hello @cichaczem . I have 9 years of programming experience but I'm new to rust and worldcoin
Could you assign me an issue for which I can have a lot of time?
Thanks and regards from Barcelona


Auto PR for Package Updates

Set up a system that automatically opens a PR whenever the project's packages need updates.

Option 1: renovate https://www.mend.io/renovate/


Clean FD conversion in syscall_common

PR for https://github.com/Lind-Project/lind_project/issues/209
Adds checks to syscall_common functions that utilize file descriptors to make sure they're positive and below FILEDESC_MAX.

Seems like pretty reasonable sanity checking. Is FILE_DESC_MAX really a tight bound? Or should it be >= FILE_DESC_MAX?

Good catch, just fixed that.


[release-0.44] virt-handler: use /proc instead of virt-chroot to stat virt-launcher files

and fix mis-uses of path instead of filepath
This is a manual cherry-pick of #6696
NONE

@jean-edouard Seems make generate is needed

@jean-edouard Seems make generate is needed

Yeah, I PRed before https://github.com/kubevirt/kubevirt/pull/7026 was merged, so that was expected.
Will rebase.
Thanks!

/lgtm
/retest