Version 0.62.1 requires .NET 6.0.8; installation fails in presence of .NET 6.0.9, error 0x80072efd

Microsoft PowerToys version
0.62.1
Running as admin

[X] Yes

Area(s) with issue?
Installer
Steps to reproduce

Install Windows 10
Install .NET Windows Runtime version 6.0.9
Try to install PowerToysSetup-0.62.1-x64.exe

✔ Expected Behavior
I have .NET Windows Runtime 6.0.9 installed and operational. This fulfills the needs of PowerToys. PowerToys must make no attempt, let alone fail, to install an outdated version of .NET.
Also, it is reasonable to expect to still be able to install PowerToys even after .NET 6.0.10, 6.0.11, or even 6.99.999 were released.
❌ Actual Behavior
The installation stalls briefly on the following stage:

Processing: Microsoft Windows Desktop Runtime - 6.0.8 (x64)

After a couple of seconds, the installation fails altogether with the following error message:

Setup Failed
One or more issues caused the setup to fail. Please fix the issues and then retry setup (sic.)
For more information see the log file.
0x8C072efd - Unspecified error

Here is the log:
[26BC:31DC][2022-09-16T07:48:17]i001: Burn v<IP_ADDRESS>26, Windows v10.0 (Build 19044: Service Pack 0), path: G:\Temp\{6917F1F7-A1B7-419F-90FF-6BFA1A57E547}\.cr\PowerToysSetup-0.62.1-x64.exe
[26BC:31DC][2022-09-16T07:48:17]i000: Initializing string variable 'InstallFolder' to value '[ProgramFiles64Folder]PowerToys'
[26BC:31DC][2022-09-16T07:48:17]i000: Initializing string variable 'MsiLogFolder' to value '[LocalAppDataFolder]\Microsoft\PowerToys\'
[26BC:31DC][2022-09-16T07:48:17]i000: Initializing version variable 'DetectedPowerToysVersion' to value '<IP_ADDRESS>'
[26BC:31DC][2022-09-16T07:48:17]i000: Initializing version variable 'TargetPowerToysVersion' to value '0.62.1'
[26BC:31DC][2022-09-16T07:48:17]i000: Initializing version variable 'DetectedWindowsBuildNumber' to value '0'
[26BC:31DC][2022-09-16T07:48:17]i009: Command Line: '-burn.clean.room=E:\Queue\PowerToysSetup-0.62.1-x64.exe -burn.filehandle.attached=560 -burn.filehandle.self=532'
[26BC:31DC][2022-09-16T07:48:17]i000: Setting string variable 'WixBundleOriginalSource' to value 'E:\Queue\PowerToysSetup-0.62.1-x64.exe'
[26BC:31DC][2022-09-16T07:48:17]i000: Setting string variable 'WixBundleOriginalSourceFolder' to value 'E:\Queue\'
[26BC:31DC][2022-09-16T07:48:17]i000: Setting string variable 'WixBundleLog' to value 'G:\Temp\powertoys-bootstrapper-msi-0.62.1_20220916074817.log'
[26BC:31DC][2022-09-16T07:48:17]i000: Setting string variable 'WixBundleName' to value 'PowerToys (Preview) x64'
[26BC:31DC][2022-09-16T07:48:17]i000: Setting string variable 'WixBundleManufacturer' to value 'Microsoft Corporation'
[26BC:0D74][2022-09-16T07:48:17]i000: Setting numeric variable 'WixStdBALanguageId' to value 1033
[26BC:0D74][2022-09-16T07:48:17]i000: Setting version variable 'WixBundleFileVersion' to value '<IP_ADDRESS>'
[26BC:31DC][2022-09-16T07:48:17]i100: Detect begin, 5 packages
[26BC:31DC][2022-09-16T07:48:17]i000: Setting version variable 'DetectedPowerToysVersion' to value '<IP_ADDRESS>'
[26BC:31DC][2022-09-16T07:48:17]i000: Setting string variable 'DetectedWindowsBuildNumber' to value '19044'
[26BC:31DC][2022-09-16T07:48:17]i000: File search: wfs548E783A531EE27DD188EFFC05A5FFEF, did not find path: C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App\6.0.8\System.Xaml.dll
[26BC:31DC][2022-09-16T07:48:17]i000: Setting numeric variable 'HasDotnet608' to value 0
[26BC:31DC][2022-09-16T07:48:17]i000: Registry key not found. Key = 'Software\Microsoft\EdgeUpdate\Clients\{F3017226-FE2A-4295-8BDF-00C3A9A7E4C5}'
[26BC:31DC][2022-09-16T07:48:17]i000: Setting numeric variable 'HasWebView2PerUser' to value 0
[26BC:31DC][2022-09-16T07:48:17]i000: Setting numeric variable 'HasWebView2PerMachine' to value 1
[26BC:31DC][2022-09-16T07:48:17]i000: Setting string variable 'DetectedVCRedistVersion' to value '32'
[26BC:31DC][2022-09-16T07:48:17]i102: Detected related bundle: {78440d7d-9b1e-400b-bfd1-2c8ac67887d8}, type: Upgrade, scope: PerMachine, version: <IP_ADDRESS>, operation: MajorUpgrade
[26BC:31DC][2022-09-16T07:48:17]i052: Condition 'HasDotnet608' evaluates to false.
[26BC:31DC][2022-09-16T07:48:17]i052: Condition 'HasWebView2PerMachine OR HasWebView2PerUser' evaluates to true.
[26BC:31DC][2022-09-16T07:48:17]i052: Condition 'DetectedVCRedistVersion >= 32' evaluates to true.
[26BC:31DC][2022-09-16T07:48:17]i103: Detected related package: {6CC5B8AF-74EB-4F0C-840D-45D8B0D6B587}, scope: PerMachine, version: <IP_ADDRESS>, language: 0 operation: MajorUpgrade
[26BC:31DC][2022-09-16T07:48:17]i103: Detected related package: {6CC5B8AF-74EB-4F0C-840D-45D8B0D6B587}, scope: PerMachine, version: <IP_ADDRESS>, language: 0 operation: MajorUpgrade
[26BC:31DC][2022-09-16T07:48:17]i101: Detected package: TerminatePowerToys, state: Absent, cached: Complete
[26BC:31DC][2022-09-16T07:48:17]i101: Detected package: DotnetRuntime6, state: Absent, cached: None
[26BC:31DC][2022-09-16T07:48:17]i101: Detected package: WebView2, state: Present, cached: None
[26BC:31DC][2022-09-16T07:48:17]i101: Detected package: VCRedist, state: Present, cached: None
[26BC:31DC][2022-09-16T07:48:17]i101: Detected package: PowerToysSetup_0.62.1_x64.msi, state: Absent, cached: None
[26BC:31DC][2022-09-16T07:48:17]i052: Condition 'TargetPowerToysVersion >= DetectedPowerToysVersion OR WixBundleInstalled' evaluates to true.
[26BC:31DC][2022-09-16T07:48:17]i052: Condition 'DetectedWindowsBuildNumber >= 19041 OR WixBundleInstalled' evaluates to true.
[26BC:31DC][2022-09-16T07:48:17]i199: Detect complete, result: 0x0
[26BC:0D74][2022-09-16T07:48:21]i000: Setting numeric variable 'EulaAcceptCheckbox' to value 1
[26BC:31DC][2022-09-16T07:48:21]i200: Plan begin, 5 packages, action: Install
[26BC:31DC][2022-09-16T07:48:21]w321: Skipping dependency registration on package with no dependency providers: TerminatePowerToys
[26BC:31DC][2022-09-16T07:48:21]i000: Setting string variable 'WixBundleLog_TerminatePowerToys' to value 'G:\Temp\powertoys-bootstrapper-msi-0.62.1_20220916074817_000_TerminatePowerToys.log'
[26BC:31DC][2022-09-16T07:48:21]w321: Skipping dependency registration on package with no dependency providers: DotnetRuntime6
[26BC:31DC][2022-09-16T07:48:21]i000: Setting string variable 'WixBundleLog_DotnetRuntime6' to value 'G:\Temp\powertoys-bootstrapper-msi-0.62.1_20220916074817_001_DotnetRuntime6.log'
[26BC:31DC][2022-09-16T07:48:21]w321: Skipping dependency registration on package with no dependency providers: WebView2
[26BC:31DC][2022-09-16T07:48:21]w321: Skipping dependency registration on package with no dependency providers: VCRedist
[26BC:31DC][2022-09-16T07:48:21]i000: Setting string variable 'WixBundleRollbackLog_PowerToysSetup_0.62.1_x64.msi' to value 'G:\Temp\powertoys-bootstrapper-msi-0.62.1_20220916074817_002_PowerToysSetup_0.62.1_x64.msi_rollback.log'
[26BC:31DC][2022-09-16T07:48:21]i000: Setting string variable 'WixBundleLog_PowerToysSetup_0.62.1_x64.msi' to value 'G:\Temp\powertoys-bootstrapper-msi-0.62.1_20220916074817_002_PowerToysSetup_0.62.1_x64.msi.log'
[26BC:31DC][2022-09-16T07:48:21]i201: Planned package: TerminatePowerToys, state: Absent, default requested: Present, ba requested: Present, execute: Install, rollback: None, cache: No, uncache: Yes, dependency: None
[26BC:31DC][2022-09-16T07:48:21]i201: Planned package: DotnetRuntime6, state: Absent, default requested: Present, ba requested: Present, execute: Install, rollback: None, cache: Yes, uncache: No, dependency: None
[26BC:31DC][2022-09-16T07:48:21]i201: Planned package: WebView2, state: Present, default requested: Present, ba requested: Present, execute: None, rollback: None, cache: No, uncache: No, dependency: None
[26BC:31DC][2022-09-16T07:48:21]i201: Planned package: VCRedist, state: Present, default requested: Present, ba requested: Present, execute: None, rollback: None, cache: No, uncache: No, dependency: None
[26BC:31DC][2022-09-16T07:48:21]i201: Planned package: PowerToysSetup_0.62.1_x64.msi, state: Absent, default requested: Present, ba requested: Present, execute: Install, rollback: Uninstall, cache: Yes, uncache: No, dependency: Register
[26BC:31DC][2022-09-16T07:48:21]i207: Planned related bundle: {78440d7d-9b1e-400b-bfd1-2c8ac67887d8}, type: Upgrade, default requested: Absent, ba requested: Absent, execute: Uninstall, rollback: Install, dependency: None
[26BC:31DC][2022-09-16T07:48:21]i299: Plan complete, result: 0x0
[26BC:31DC][2022-09-16T07:48:21]i300: Apply begin
[26BC:31DC][2022-09-16T07:48:21]i010: Launching elevated engine process.
[26BC:31DC][2022-09-16T07:48:22]i011: Launched elevated engine process.
[26BC:31DC][2022-09-16T07:48:22]i012: Connected to elevated engine.
[1B84:3360][2022-09-16T07:48:22]i358: Pausing automatic updates.
[1B84:3360][2022-09-16T07:48:22]i359: Paused automatic updates.
[1B84:3360][2022-09-16T07:48:22]i360: Creating a system restore point.
[1B84:3360][2022-09-16T07:48:22]w363: Could not create system restore point, error: 0x80070422. Continuing...
[1B84:3360][2022-09-16T07:48:22]i370: Session begin, registration key: SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\{4eb6cdf7-0d8c-41ed-9412-e0c35ed476f9}, options: 0x7, disable resume: No
[1B84:3360][2022-09-16T07:48:22]i000: Caching bundle from: 'G:\Temp\{C5D60DC1-330F-4D3C-9305-953232E7EA0F}\.be\PowerToysSetup-0.62.1-x64.exe' to: 'C:\ProgramData\Package Cache\{4eb6cdf7-0d8c-41ed-9412-e0c35ed476f9}\PowerToysSetup-0.62.1-x64.exe'
[1B84:3360][2022-09-16T07:48:22]i320: Registering bundle dependency provider: {4eb6cdf7-0d8c-41ed-9412-e0c35ed476f9}, version: <IP_ADDRESS>
[1B84:3360][2022-09-16T07:48:22]i371: Updating session, registration key: SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\{4eb6cdf7-0d8c-41ed-9412-e0c35ed476f9}, resume: Active, restart initiated: No, disable resume: No
[1B84:22FC][2022-09-16T07:48:22]i304: Verified existing payload: TerminatePowerToys at path: C:\ProgramData\Package Cache\CEEB2F4674AB44E9EBCE9175CE716612D979979C\terminate_powertoys.cmd.
[26BC:23C0][2022-09-16T07:48:22]w343: Prompt for source of package: DotnetRuntime6, payload: DotnetRuntime6, path: E:\Queue\windowsdesktop-runtime-6.0.8-win-x64.exe
[26BC:23C0][2022-09-16T07:48:22]i338: Acquiring package: DotnetRuntime6, payload: DotnetRuntime6, download from: https://download.visualstudio.microsoft.com/download/pr/b4a17a47-2fe8-498d-b817-30ad2e23f413/00020402af25ba40990c6cc3db5cb270/windowsdesktop-runtime-6.0.8-win-x64.exe
[26BC:23C0][2022-09-16T07:48:22]e000: Error 0x80072efd: Failed to send request to URL: https://download.visualstudio.microsoft.com/download/pr/b4a17a47-2fe8-498d-b817-30ad2e23f413/00020402af25ba40990c6cc3db5cb270/windowsdesktop-runtime-6.0.8-win-x64.exe, trying to process HTTP status code anyway.
[26BC:23C0][2022-09-16T07:48:22]e000: Error 0x80072efd: Unknown HTTP status code 0, returned from URL: https://download.visualstudio.microsoft.com/download/pr/b4a17a47-2fe8-498d-b817-30ad2e23f413/00020402af25ba40990c6cc3db5cb270/windowsdesktop-runtime-6.0.8-win-x64.exe
[26BC:23C0][2022-09-16T07:48:22]e000: Error 0x80072efd: Failed attempt to download URL: 'https://download.visualstudio.microsoft.com/download/pr/b4a17a47-2fe8-498d-b817-30ad2e23f413/00020402af25ba40990c6cc3db5cb270/windowsdesktop-runtime-6.0.8-win-x64.exe' to: 'G:\Temp\{C5D60DC1-330F-4D3C-9305-953232E7EA0F}\DotnetRuntime6'
[26BC:23C0][2022-09-16T07:48:22]w343: Prompt for source of package: DotnetRuntime6, payload: DotnetRuntime6, path: E:\Queue\windowsdesktop-runtime-6.0.8-win-x64.exe
[26BC:23C0][2022-09-16T07:48:25]i338: Acquiring package: DotnetRuntime6, payload: DotnetRuntime6, download from: https://download.visualstudio.microsoft.com/download/pr/b4a17a47-2fe8-498d-b817-30ad2e23f413/00020402af25ba40990c6cc3db5cb270/windowsdesktop-runtime-6.0.8-win-x64.exe
[26BC:23C0][2022-09-16T07:48:25]e000: Error 0x80072efd: Failed to send request to URL: https://download.visualstudio.microsoft.com/download/pr/b4a17a47-2fe8-498d-b817-30ad2e23f413/00020402af25ba40990c6cc3db5cb270/windowsdesktop-runtime-6.0.8-win-x64.exe, trying to process HTTP status code anyway.
[26BC:23C0][2022-09-16T07:48:25]e000: Error 0x80072efd: Unknown HTTP status code 0, returned from URL: https://download.visualstudio.microsoft.com/download/pr/b4a17a47-2fe8-498d-b817-30ad2e23f413/00020402af25ba40990c6cc3db5cb270/windowsdesktop-runtime-6.0.8-win-x64.exe
[26BC:23C0][2022-09-16T07:48:25]e000: Error 0x80072efd: Failed attempt to download URL: 'https://download.visualstudio.microsoft.com/download/pr/b4a17a47-2fe8-498d-b817-30ad2e23f413/00020402af25ba40990c6cc3db5cb270/windowsdesktop-runtime-6.0.8-win-x64.exe' to: 'G:\Temp\{C5D60DC1-330F-4D3C-9305-953232E7EA0F}\DotnetRuntime6'
[26BC:23C0][2022-09-16T07:48:25]w343: Prompt for source of package: DotnetRuntime6, payload: DotnetRuntime6, path: E:\Queue\windowsdesktop-runtime-6.0.8-win-x64.exe
[26BC:23C0][2022-09-16T07:48:28]i338: Acquiring package: DotnetRuntime6, payload: DotnetRuntime6, download from: https://download.visualstudio.microsoft.com/download/pr/b4a17a47-2fe8-498d-b817-30ad2e23f413/00020402af25ba40990c6cc3db5cb270/windowsdesktop-runtime-6.0.8-win-x64.exe
[26BC:23C0][2022-09-16T07:48:28]e000: Error 0x80072efd: Failed to send request to URL: https://download.visualstudio.microsoft.com/download/pr/b4a17a47-2fe8-498d-b817-30ad2e23f413/00020402af25ba40990c6cc3db5cb270/windowsdesktop-runtime-6.0.8-win-x64.exe, trying to process HTTP status code anyway.
[26BC:23C0][2022-09-16T07:48:28]e000: Error 0x80072efd: Unknown HTTP status code 0, returned from URL: https://download.visualstudio.microsoft.com/download/pr/b4a17a47-2fe8-498d-b817-30ad2e23f413/00020402af25ba40990c6cc3db5cb270/windowsdesktop-runtime-6.0.8-win-x64.exe
[26BC:23C0][2022-09-16T07:48:28]e000: Error 0x80072efd: Failed attempt to download URL: 'https://download.visualstudio.microsoft.com/download/pr/b4a17a47-2fe8-498d-b817-30ad2e23f413/00020402af25ba40990c6cc3db5cb270/windowsdesktop-runtime-6.0.8-win-x64.exe' to: 'G:\Temp\{C5D60DC1-330F-4D3C-9305-953232E7EA0F}\DotnetRuntime6'
[26BC:23C0][2022-09-16T07:48:28]w343: Prompt for source of package: DotnetRuntime6, payload: DotnetRuntime6, path: E:\Queue\windowsdesktop-runtime-6.0.8-win-x64.exe
[26BC:23C0][2022-09-16T07:48:31]i338: Acquiring package: DotnetRuntime6, payload: DotnetRuntime6, download from: https://download.visualstudio.microsoft.com/download/pr/b4a17a47-2fe8-498d-b817-30ad2e23f413/00020402af25ba40990c6cc3db5cb270/windowsdesktop-runtime-6.0.8-win-x64.exe
[26BC:23C0][2022-09-16T07:48:31]e000: Error 0x80072efd: Failed to send request to URL: https://download.visualstudio.microsoft.com/download/pr/b4a17a47-2fe8-498d-b817-30ad2e23f413/00020402af25ba40990c6cc3db5cb270/windowsdesktop-runtime-6.0.8-win-x64.exe, trying to process HTTP status code anyway.
[26BC:23C0][2022-09-16T07:48:31]e000: Error 0x80072efd: Unknown HTTP status code 0, returned from URL: https://download.visualstudio.microsoft.com/download/pr/b4a17a47-2fe8-498d-b817-30ad2e23f413/00020402af25ba40990c6cc3db5cb270/windowsdesktop-runtime-6.0.8-win-x64.exe
[26BC:23C0][2022-09-16T07:48:31]e000: Error 0x80072efd: Failed attempt to download URL: 'https://download.visualstudio.microsoft.com/download/pr/b4a17a47-2fe8-498d-b817-30ad2e23f413/00020402af25ba40990c6cc3db5cb270/windowsdesktop-runtime-6.0.8-win-x64.exe' to: 'G:\Temp\{C5D60DC1-330F-4D3C-9305-953232E7EA0F}\DotnetRuntime6'
[26BC:23C0][2022-09-16T07:48:31]e000: Error 0x80072efd: Failed to acquire payload from: 'https://download.visualstudio.microsoft.com/download/pr/b4a17a47-2fe8-498d-b817-30ad2e23f413/00020402af25ba40990c6cc3db5cb270/windowsdesktop-runtime-6.0.8-win-x64.exe' to working path: 'G:\Temp\{C5D60DC1-330F-4D3C-9305-953232E7EA0F}\DotnetRuntime6'
[26BC:23C0][2022-09-16T07:48:31]e313: Failed to acquire payload: DotnetRuntime6 to working path: G:\Temp\{C5D60DC1-330F-4D3C-9305-953232E7EA0F}\DotnetRuntime6, error: 0x80072efd.
[26BC:31DC][2022-09-16T07:48:31]e000: Error 0x80072efd: Failed while caching, aborting execution.
[1B84:3360][2022-09-16T07:48:31]i372: Session end, registration key: SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\{4eb6cdf7-0d8c-41ed-9412-e0c35ed476f9}, resume: None, restart: None, disable resume: No
[1B84:3360][2022-09-16T07:48:31]i330: Removed bundle dependency provider: {4eb6cdf7-0d8c-41ed-9412-e0c35ed476f9}
[1B84:3360][2022-09-16T07:48:31]i352: Removing cached bundle: {4eb6cdf7-0d8c-41ed-9412-e0c35ed476f9}, from path: C:\ProgramData\Package Cache\{4eb6cdf7-0d8c-41ed-9412-e0c35ed476f9}\
[1B84:3360][2022-09-16T07:48:31]i371: Updating session, registration key: SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\{4eb6cdf7-0d8c-41ed-9412-e0c35ed476f9}, resume: None, restart initiated: No, disable resume: No
[26BC:31DC][2022-09-16T07:48:32]i399: Apply complete, result: 0x80072efd, restart: None, ba requested restart:  No

Other Software
N/A

/dup https://github.com/microsoft/PowerToys/issues/20236


Add insertlog query

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#383  👈
#382
#381
#380
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @insipx and the rest of your teammates on  Graphite


accessLog won't filter

Do you want to request a feature or report a bug?
Report a bug

Bug

What did you do?
Configured traefik.yml to log access for 401, 403 and 404 errors.

What did you expect to see?
AccessLog which shows only 401, 403 and 404 errors.
What did you see instead?
All status codes logged.
Output of traefik version: (What version of Traefik are you using?)

As this is my first issue, I hope I didn't do something wrong :)

Hello @edipdincer,
Thanks for your interest in Traefik!
Can you please provide more configuration (static configuration, docker configuration) in order to reproduce your bug ?
Can you also provide more logs of Traefik by setting the log level to DEBUG ?

Hi, thanks for the response. Here are my conf files and debug log:
traefik.yml
api:
  dashboard: true
  insecure: true

log:
  filePath: "log/traefik.log"
  level: WARN

accessLog:
  filePath: "log/access.log"
  filters:
    statusCodes:
      - "401"
      - "403"
      - "404"
    retryAttempts: true
    minDuration: "10ms"

entryPoints:
  http:
    address: ":80"
  https:
    address: ":443"

providers:
  docker:
    endpoint: "unix:///var/run/docker.sock"
    exposedByDefault: false

certificatesResolvers:
  http:
    acme:
      email<EMAIL_ADDRESS>      storage: acme.json
      httpChallenge:
        entryPoint: http

docker-compose.yml
version: '3'

services:
  traefik:
    image: traefik:latest
    container_name: traefik
    restart: unless-stopped
    security_opt:
      - no-new-privileges:true
    networks:
      - proxy
    dns:
      - <IP_ADDRESS>
      - <IP_ADDRESS>
    ports:
      - 80:80
      - 443:443
      - 9006:8080
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock:ro
      - ./traefik.yml:/traefik.yml:ro
      - ./acme.json:/acme.json
      - ./log:/log
    environment:
      - "DYNU_API_KEY=DYNU_API_KEY"
      - "TZ=TZ/TZ"

networks:
  proxy:
    external: true

Debug Log: https://pastebin.com/raw/6EZvpAEU

Thanks for coming back to us fast.
As the documentation states:

To filter logs, you can specify a set of filters which are logically "OR-connected".

Your filters tell Traefik to log request that have a status code of {401, 403, 404} or with a minDuration of 10ms. And all your requests took more than 10ms, thus Traefik logged them.
It seems your issue is a configuration error, thus this issue will be closed.
If you have more questions regarding the configuration, please join our Community Forum and reach out to us on the Traefik section.
In case I'm wrong feel free to re-open the issue.


Use named pipe to decrease local Windows runtime

This uses PowerShell to spawn a process that listens on a named pipe for
Base64 encoded commands and executes them. This drastically decreases
the total runtime when running locally on Windows by using a single
PowerShell session to execute commands instead of spawning a new session
for each command.
Huge thanks to @sdelano for the initial idea!
Signed-off-by: Jerry Aldrich<EMAIL_ADDRESS>

Good catch @chris-rock @adamleff. I have fixed this to append a hex string to the end of the pipe name.


As an artist apart of a collaboration effort I would like to have an account we all can access so we can share credit for the art.

Create the Profile (*GROUP)

Require a logged in user
Add Logged in user as Profile Owner
Require a profile name
Allow a description
Allow privacy setting default to public
Return Profile DTO

Add members

Authorize for Profile Admin
Require Valid user ID for addition
Don't allow for private users
Allow permission level default to member
Maybe allow added user to confirm the addition
Return Profile DTO
If user ID is invalid return a 404 error with body saying "member not found" or something of that sort

Remove member

Authorize for profile admin or higher
Require profile member ID with permission less than current user
Return Profile DTO
Remove member

Change member permissions

Authorize for profile admin or higher
Require profile member
Require permission level less than current user
If profile member level is higher than new level throw bad request
If permission level is higher than current user level throw bad request
Set profile member permission to designated level
Return Profile DTO

Controller -


Plugin not compatible with Unreal Engine 4.17.2

I'm running 4.17.2 of Unreal Engine on Win 10 64bit. I just tried to install UE-4-OSC for the first time with no luck.
I'm also running Visual Studio 2017 15.4.1
I think I have all the C++ addons installed, but I am a newb.
Any help would be super appreciated.

Hi!
I know that getting into UE4 is not an easy step for a "newb"!  :)
An awesome user of this plugin struggled a lot, and then produced a video tutorial!
https://www.youtube.com/watch?v=GGGs-n-CKtY
Good luck!


WIP: Fix fetch-kde-qt.sh

In https://github.com/NixOS/nixpkgs/pull/97391 you mentioned, that the fetch script was broken. Maybe this helps?!
Cause: signature file extension changed from ".sha256" to ".sig".
Fix: accept both for now

It's not as easy as I thought. Will come back, if I find a fix.


Document expected behaviour of profiles

For included, excluded, sequence, inverse paths, and the listing predicates what is the expected behaviour and allowable combinations.
For object predicates: (sh:path, dash:hidden, sh:sequencePath, sh:inversePath)

include or exclude are mandatory and exclusive, both cannot be specified (sh:path or sh:path + dash:hidden)
sh:sequencePath and sh:inversePath are optional includes.
sequence paths where the first predicate is excluded should not be returned. (?)

For listing predicates:

the system should return a minimal set of paginated results
the system should return the union of all objects related to the focus item (or general class) via one or more listing predicates.
(in the case of listing endpoints, only one type of listing predicate is configured in the system)
where the system is listing items in the "item" or "object" pages, included/excluded predicates specified for the object should be ignored. For example if rdfs:member is not included via sh:path, or is excluded via dash:hidden, and a listing predicate specifies rdfs:member, the results for the listing predicate should still be returned.

draft - please provide feedback @nicholascar @edmondchuc @hjohns

Is this for user-facing documentation on how to configure Prez or is this an internal design discussion on the behaviours of Prez?

internal design first

Design document required:

Outline of current state?
Target state design
Capture flow (@recalcitrantsupplant)
Cookbook documentation with recipes (additional scenarios to new doco)

going to push this issue to next week

https://lucid.app/lucidchart/b5660138-0e38-427b-aab4-18eb4c4b73cb/edit?viewport_loc=-80%2C-302%2C2269%2C1137%2C0_0&invitationId=inv_76a1d32b-5fbf-4c39-ace5-85152cb3f69f

David to add some examples to dev readme and add the diagrams from Lucid to the dev readme. Two Lucid chart diagrams related to this will be merged into one.

I think it would be good if we all add our current use cases and how we are using profiles to establish a common set of behaviours that need to be supported.
For example, in some of the projects I'm working on, I need reg:status and schema:color to appear in both the listing and object pages.
Once we have a set of use cases, we can then document how the profiles syntax cater for these use cases by using the available predicates (e.g., alt-ext:otherAnnotationProps, etc.).


Remove duplicate systemd parameters from kernel-mshv cfg

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] Ready to merge

Summary

What does the PR accomplish, why was it needed?
When booting, grub should still be getting its systemd-related parameters from one place: systemd.cfg which is packaged in systemd.rpm. Prevent the kernel-mshv package from stomping over these settings.
Change Log

Remove "net.ifnames=0 plymouth.enable=0 systemd.legacy_systemd_cgroup_controller=yes systemd.unified_cgroup_hierarchy=0" from $kernel_cmdline_mshv

Does this affect the toolchain?

NO
Associated issues

https://microsoft.visualstudio.com/OS/_workitems/edit/45063749/

Test Methodology

Buddy building and installing the resulting rpm artifact to ensure no regressions.
https://dev.azure.com/mariner-org/mariner/_build/results?buildId=382761&view=results

Tested locally, works!


Maven plugin

Maven is the defacto build tool for Java. I know some people love Bazel or Gradle, but almost every loves Maven.
Please can we have either (a) a plugin, or (b) how to run without downloading.

It has been on our mind to make Sorald's usage as convenient as possible, but we never got to it because of priorities. As of now, Sorald is meant to be used as a CLI tool, and not as an API. However, if you want to use it with maven, you can plugin the spec as suggested here. Then you could run sorald as we run it in our tests. We run it as a CLI and capture the STDOUT and files created to test the output. You could see this test as an example.
We are presenting Sorald at EclipseCon 2022 and before that we have some todos; one of them being to make its usage as easy as possible. We have some ideas regarding it and we are working on them. I will keep you posted when it is done. Nevertheless, I will update the documentation.

@alexec Hey! We found time to work on the maven-plugin and implemented a first prototype for it. Please run the following command to give it a whirl :)
mvn se.kth.castor:sorald:repair -DruleKey=<ruleKey>

The maven-plugin is released and from now on, it will be maintained as well. Hence, closing.

Do we have CD to Maven Central for the maven-plugin? That would be great.

We do not, as of now. If we have CD, we need to ensure that we deploy releases, not SNAPSHOTs because the latter is not hosted on Maven central. We would need a CD like gumtree-spoon that deploys a release on every commit.


Fixed-point decimal type

Adds a fixed-point decimal type to Typst, decimal. The intended usage is for calculations which require high precision in basic arithmetic operations, such as in finance. (Worth noting that greater precision cannot be guaranteed for more complex operations, such as power to non-integer exponents and logarithm.)
The current implementation uses rust_decimal, in which there isn't a fixed amount of fractional digits for each decimal number (in principle). Rather, a fixed-size integer is used for all decimal numbers for efficiency purposes, which means that numbers with more fractional digits have less non-fractional digits available (i.e. a smaller range), and vice-versa - there is a limit of about 28 significant digits in base 10, and operations can decrease the precision as values get too large. We think this is an acceptable tradeoff for now, and could consider introducing some sort of "big decimal" support in the future (with arbitrary amounts of digits), but it wouldn't be interesting to do so now due to the potential (and likely unnecessary in most cases) performance implications.
Usage
In principle, this type can be used through the decimal("123.456") constructor. It only accepts a string. A literal format could be introduced in the future to make it easier to create decimals, but I think we can refrain from changing the syntax for now and wait until we get proper feedback on usage of decimal numbers.
One alternative could be to accept an integer and a scale as well, e.g. decimal(123456, 3) == decimal("123.456"). I'd want to be able to construct decimals like this somehow without going through a string, though just decimal(integer, scale) could be confusing to read - I'd love to hear other opinions on this (maybe we could use a function with named arguments).
Typical operations are available: + - * /. Also, we'll attempt to support as many calc functions for decimal as possible, such as calc.pow, calc.rem and so on. Worth noting that many operations, such as logarithm, sqrt, power to non-integer exponents etc. will not have great precision guarantees (i.e. will not be much better than using a float) due to computational limitations.
Note that decimal does not support plus or minus infinity, so overflow/underflow in operations will result in an error.
Additionally, while operations between decimal and integers are always supported, operations between decimal and floats (e.g. decimal("2.5") * 3.4) are an error to avoid unintentional loss of precision. You'd need to explicitly cast your decimal to a float first.
:warning: Breaking Changes

calc.floor(float), calc.ceil(float) and calc.trunc(float) now return floats instead of integers as the rounded float might be larger than the max integer (or less than the minimum integer).
calc.round no longer accepts negative digits.
calc.round(int) will now always return an integer, even if the digits parameter is non-zero.
int(float) will now error instead of saturating if the float is greater than the maximum integer or less than the minimum integer.

TODO

[x] Finish adding decimal support to calc functions (div-euclid, rem-euclid included).
[x] Add more conversions between decimal and other numeric types, e.g. float(decimal) to cast to a float. Include a warning if trying to write decimal(float literal).
[x] Adapt str(decimal) for consistency with float and int (use minus sign).
[x] Evaluate the semantics of decimal.display(digits: ...) and whether this function should be kept.
[x] Cleanup/Remove unnecessary Decimal internal trait implementations and operations.

calc.round no longer accepts negative digits.

You mean negative numbers? This restriction makes no sense.
https://typst.app/docs/reference/foundations/calc#functions-round


User service should not abort updateRoles if no corresponding person entry can be found

Makes admin users etc. difficult as they need to currently be tied to a Person record.

This was likely the root cause of: #3489


listProfiles is missing support for active parameter

The listProfiles API supports an active parameter. See here
This parameter is missing. See here

Thanks for the hint! I added the active parameter to v2.17.2. 😊


decode: Tests for unknown/arp counters

Issue: 5761
This commit adds tests for decode counters which are new

decode.arp
decode.unknown_ethertype

Requires https://github.com/OISF/suricata/pull/8295

Suricata PR was merged

Merged. Thanks!


AMQP changes for C++ Claim Based Security - also fixed session close issue that affected reliability

This pull request introduces several important changes to the azure_core_amqp and azure_messaging_eventhubs SDKs. The most significant updates involve adding lifetime parameters to various structs and implementations to ensure proper borrowing and memory management. Additionally, there are some minor improvements and refactorings to enhance code clarity and error handling.
Lifetime Parameter Additions:

sdk/core/azure_core_amqp/src/cbs.rs: Added lifetime parameter 'a to the CbsImplementation type alias and AmqpClaimsBasedSecurity struct to ensure proper borrowing of AmqpSession. [1] [2]
sdk/core/azure_core_amqp/src/fe2o3/cbs.rs: Added lifetime parameter 'a to Fe2o3ClaimsBasedSecurity struct and its methods to ensure proper borrowing of AmqpSession.
sdk/core/azure_core_amqp/src/noop.rs: Added lifetime parameter 'a and a PhantomData field to NoopAmqpClaimsBasedSecurity struct to ensure proper borrowing of AmqpSession. [1] [2] [3]

Refactorings and Improvements:

sdk/core/azure_core_amqp/src/fe2o3/connection.rs: Simplified error handling and removed unnecessary unwrap calls by using if let instead of ok_or_else. [1] [2]
sdk/eventhubs/azure_messaging_eventhubs/src/consumer/mod.rs and sdk/eventhubs/azure_messaging_eventhubs/src/producer/mod.rs: Updated AmqpClaimsBasedSecurity::new calls to pass a reference to AmqpSession instead of taking ownership. [1] [2]

The generated summary covers the what, but that's obvious in a fairly small PR. I'm curious as to the why. Is it because the AmqpSession was being copied? Was the Arc<> causing delays?

The problem was that when the types underlying the session were copied, somehow the underlying fe2o3::session::SessionHandle got dropped. That shouldn't have been possible, but the traces were unambiguous: The underlying AMQP layer felt it was necessary to drop the session handle. Possibly that was because I didn't clone the session properly, I honestly don't know.
However, while I was trying to figure out why the sessionhandle was dropped, I realized that the session lifetime was always going to be longer than the CBS lifetime, so instead of taking a reference to the underlying Arc, I could just take a reference to the session.  And once I switched from taking a reference to the Arc<Mutex<SessionHandle>> to taking a reference to the Session, the problem went away.


V6 component button docs

Description
Updates Button docs. There's some additional work that will need to be done here, but that's for another ticket.
Obligatory GIF

Great work 🚀
Should the muted button variant have any hover styles?
Visually the only indication I get is the cursor style changing and that might be difficult for individuals with vision deficiencies (I know it was hard enough for myself to notice)

I think it does, but it's the same color as the background-color. I was going to make the hover a color with alpha instead, but didn't because I learned rectangular Muted buttons aren't a real thing. They were in the Figma file I worked from and so I did them, but they aren't in DT5 CSS, Vue, or in our product. So, I have a ticket coming up soon for cleaning up things like that.
In short: I'm gonna pull them out.


Updates to Clearing Operations and Compound Map

Action taken:
changed the script to rely on the script tool to set the symbology and
labels.
Note:
Based on best practices coming from the gp core team I have commented
out the steps that apply symbology in the script and set the script tool
to look at the layer file.

More commits coming please do not merge yet.

Why are you changing the arcmap functionality when it works exactly as it should?

@adgiles going with the approach that we currently had was not matching up with what the gp team gave us for feedback. Also, it did not produce the results with labels in the correct place. Now that we have applied the advice that they have given us the script tool symbolizes and labels correctly. This was why we took this approach.  Going forward it could be useful to have all our script tools drive symbology unless that is not possible based a more complex workflow such as dealing with adding group layers to the ToC.

Can the symbology task steps be removed from pro then?

I am finished with my commits and this can now be reviewed

@adgiles unfortunately not because this is still a bug in ArcGIS Pro 2.0. I have explained to them that we are seeing the same results; however, we will be ready for ArcGIS Pro 2.1 when they make those changes.

@topowright

Desktop 10.3.1 is good.
Desktop 10.5 is good.
Pro 1.4 is still giving me bad models (GitHub screwing with things?):

Script tool is running without errors, but is not picking up the LYRX stored in the Script Tool parameters. No symbols, no layers.
😠

Pro 2.0 also has a bad Number Features model (still GitHub?). But the Number Features Script tool will run and use the LYRX (but no labels.... yet).

@topowright I'm noticing that I can't add the NumberedStructures.lyrx to my map directly. It should be added with a broken data link at least. Wasn't sure why until I cracked it open:
{
  "type" : "CIMLayerDocument",
  "version" : "2.0.0",
  "build" : 8933,
  "layers" : [
    "CIMPATH=clearing_operations/numberedstructuressample.xml"
  ],
  "layerDefinitions" : [
    {

So a version 2.0 LYRX won't work in 1.4.
Was able to add the NumberedStructure.lyr to my may but got an interesting layer name int he doc...

We need to rename that guy in ArcMap 10.3.1.
Now if I export the .LYR to a new .LYRX in 1.4 ...
{
  "type" : "CIMLayerDocument",
  "version" : "1.4.0",
  "build" : 7198,
  "layers" : [
    "CIMPATH=map/asdfasde.xml"
  ],
  "layerDefinitions" : [

HA!!!! VERSION SPECIFIC LAYERS!!!!!!!!!!!
The modified 1.4 LYRX symbolizes nicely in 1.4 then...

The script tool not working with Kurd file is a known bug in Pro. I have replicated it on 2.1 as well. The script losing its link is also another known issue logged with the go code team. I did no work in ArcGIS Pro 1.4 only 2.0 and 2.1

I am working right now on creating a lyrx file in 1.4. I did not have a 1.4 system set up because I did not think we were doing this. I will push the new lyrx file soon as I finish.

@mfunk I have added the lyrx files created in ArcGIS Pro

Good. Good. Good. Number Features Script tool is showing yellow block (no labels) in Pro 1.4 now

Same in Pro 2.0, got yellow blocks (no labels).


Alignment support blank/comment lines in the signals declaration area?

Alignment support blank/comment lines in the signals declaration area?
like:
wire   [127:0]  a;
reg    [    7:0]  b;
//comments
reg    [    1:0]  c;

I added a new option (sv.align_group_decl) in latest version that you can set to true so that alignment behaves like you want.

Thank you very much.


Enhancements to CPF

Extends the CPF computation to add a threshold for low-signal regions and a symmetric option to consider both tails of a distribution equally important.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.68%. Comparing base (1e3c54a) to head (2c67c46).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #28      +/-   ##
===========================================
+ Coverage    98.66%   98.68%   +0.02%
===========================================
  Files            8        8
  Lines          672      684      +12
  Branches        26       26
===========================================
+ Hits           663      675      +12
  Misses           7        7
  Partials         2        2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix the comment functionality

Comments 🎯

I fixed the comments functionality

[ ] According to the requirements of the project each item should have different comments, currently whatever comment is being posted, is displayed on all items, please change that.
[ ] Items that already have comments on them should display before the button comment is clicked in the popup and when a new comment is posted, the comment window should update with new comment on it
[ ] When Comment button is clicked comment popup window should appear displaying previous comments and new comment form


Tidy data and support for Visualization and other output presentation

Yes. Best solution might be to have a method to convert indexed sectors to DataFrames. I have this on a global scale with generate_report, but a micro scale would be nice too. Column for variable name, index columns, and value.
So if Y is a variable with domain A, B we get a DataFrame with four columns, :variable_name, :A, :B, :value.
In fact we could be clever here and set the axis names on creation of an indexed variable. And IndexedVariable is just a DenseAxisArray which space for axis names. I was prototyping something earlier and will circle back to this.

I don't know how far we want to take this as an issue, but there's probably a list of intersting, useful and slightly complicated output and report methods that might be nice to offer.
Probably for some simple ones like a bar chart or scatter plot of results, better to just show in tutorial.


m_bDormant

m_bDormant
I can't find it on the dumper and it's a offset I really need. I don't know how I could collaborate to make this available in the dumper

I know this is 2 years late but I made a video on how to find m_bDormant:
https://www.youtube.com/watch?v=YCv3sqcPb6E
Hope it helps


Fix cache policy and return with response

Changes:

fix cache id (contains query parameters as well)
cache only for  GET
invalidate cache for changes (POST, PUT, DELETE)
return with data, status, headers, config -> breaking change

Why return with additional response params?
Headers may contains necessary data like x-total-count (needed for pagination for example)

oops, I forgot the tests :)
I'll fix. How do you like the concept?

@hekike I like it. I used to have a similar approach in the past and noticed the two following issues:

For the URL id, you need to use a canonical representation.
I am not sure it make sense to remove the cache when a side effecting method happens. Since side effects happen from other clients as well. The usefulness seems limited no?

@wcandillon I think it's better if we invalidate it when we are sure that it's changed, instead of doing nothing. But yes, still should have expiration date for cache entries.
Would you be open to use a 3rd party cache library for expiration? It's saddly not implemented in $cacheFactory.
I'm using your library for an admin and it's pretty strange when I save something and don't see the changes. But without caching it's too slow. Maybe should provide an option to controlling these kind of invalidations by method and expiration.

@hekike I used http://jmdobry.github.io/angular-cache/ but it still required a lot of manual work. Maybe http://angular-data.pseudobry.com/documentation/api/angular-cache/angular-cache is the solution but I haven't check it out.

@wcandillon thanks. I will investigate/implement it and update you here.

@hekike Feel free to reopen if necessary.


Do not disable side volume buttons in tablet mode

For more information: https://bugzilla.redhat.com/show_bug.cgi?id=2048628, and https://gitlab.freedesktop.org/libinput/libinput/-/merge_requests/741

The side buttons are not handled by AT Keyboard. On intel it is the intel virtual buttons.

The side buttons are not handled by AT Keyboard. On intel it is the intel virtual buttons.

I used evtest to investigate which input the side buttons are and for jinlon it is AT keyboard.

Also, what really matters is fact the one line I changed for libinput quirks fixes the issue.
Without keyd: Side buttons work in tablet mode
With keyd: Side buttons don't work in tablet mode
With keyd + the quirk I added: Side buttons work in tablet mode

wtf google

so just checked, intel virtual buttons exists but seems to do nothing


Added extra info about yasm 64bit with visual studio 2019

Good point. Added. 👍

Thanks, looks all good now!


AccessViolation when try to cancel ProcessAsync()

Whisper.Net version: 1.2.2
Environment: win10-x64
.NET version: Framework 4.7.2
Model: Small.bin
wav file language: Japanese
Use Whisper.net.Demo sample code, in Program.cs, pass a 1 minute cancellation token to ProcessAsync():
    var cts = new CancellationTokenSource(TimeSpan.FromMinutes(1));
    await foreach (var segment in processor.ProcessAsync(fileStream, cts.Token))
    {
        Console.WriteLine($"New Segment: {segment.Start} ==> {segment.End} : {segment.Text}");
    }

After 1min, the Demo crashed by AccessViolationException:
0x00007FFB245934AE (whisper.dll)处(位于 Whisper.net.Demo.exe 中)引发的异常: 0xC0000005: 读取位置 0x000001D0863A1D90 时发生访问冲突。

I tried using new Thread() instead of Task.Run() then call processor.Process() in it.
After call thread.Abort(), the thread terminated normally without throwing AccessViolationException.
But Thread.Abort() seems only works in .NET Framework + Windows, this may not be a perfect solution.

Yes, the problem is that the underlying whisper.cpp library was not supporting cancellation so even if you cancel whisper.net processor, the processing is still running under the hood. Will check if whisper.cpp have any plans of adding cancellation options. and will keep this updated.

I added a commit to fix it and will release it in 1.3.0 version. However, after cancelling, you'll have to call DisposeAsync() instead of Dispose now on the processor as otherwise Dispose method will throw (as the processing is still happening).
DisposeAsync will wait until all resources can be safely released.
Also, a newer encoder will be cancelled now, so the rest of processing will finish faster, but the decoders cannot be cancelled (as whisper.cpp is not supporting that option yet).


Add plugin name structure.

Describe the bug
Spear has plugins feature (#70 ). In this feature, plugins doesn't have plugin name and version ...etc.
This name will be displayed on error or warn during the proceeding.
Expected behavior
Plugin has own name and version, then displayed plugin information when plugin proceeding failed.

#154 fixed this issue


Ionic 2 Side menu not working correctly in some android and IOS device

Hi,
I have side menu on home page. When user click on logout sidemenu is closed and app will redirect to signin page. But the problem is Sometimes It successfully close the menu and redirect to signin Page and Sometimes menu is not closed and it stills open on signin page and on IPhone when I swipe sidemenu is open with white blank Screen and nothing is shown and im not be able to close the sidemenu.

Hey there! So it looks like your issue is not related to the ionic site repo, but rather a framework question/issue. Please open an issue on the ionic repo
https://github.com/driftyco/ionic


Allow to construct MerkleBlock using the header and txids

More efficient in cases where the list of txids in the block is already known, as is the case in esplora.

Codecov Report

Merging #415 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
+ Coverage   85.81%   85.87%   +0.05%
==========================================
  Files          40       40
  Lines        7461     7552      +91
==========================================
+ Hits         6403     6485      +82
- Misses       1058     1067       +9

Impacted Files
Coverage Δ

src/util/merkleblock.rs
92.73% <100.00%> (+2.09%)
:arrow_up:

src/util/psbt/raw.rs
79.16% <0.00%> (-1.69%)
:arrow_down:

src/util/address.rs
85.41% <0.00%> (-0.90%)
:arrow_down:

src/consensus/encode.rs
89.24% <0.00%> (-0.76%)
:arrow_down:

src/network/message.rs
95.17% <0.00%> (+0.03%)
:arrow_up:

src/util/amount.rs
89.02% <0.00%> (+0.03%)
:arrow_up:

src/blockdata/script.rs
78.59% <0.00%> (+0.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cff794...7e32032. Read the comment docs.

Hmm but it is slightly less efficient in the general case.

Thanks for the review! I accepted your changes and squashed them.
If efficiency is a concern, I could separate the implementation for the two cases instead of delegating from_block to from_header_txids.


User needs to wait even when the site is ready

Though it might not be the common case, I found that the user needs to wait 1.5 seconds even if the site is ready. I think this has anti-pattern written all over the place and I would encourage to completely remove it.
👉 https://github.com/Jam3/generator-jam3/blob/master/templates/react/src/components/Preloader/index.js#L60

@jeremenichelli There is definitely a reason for this. I had to use it on my last project as the preloader animation needed to finish before we could leave the section (design trumping user experience). I agree that its wrong, but its something we have to change in our designs before we can remove it completely. I'll change the default to 0 for now.

Putting the default to 0 works for me, at least for now.

Fixed as of<EMAIL_ADDRESS>


[Suggestion] Make Auto Crafter keep non consumed items in the input inventory

When trying to use the Auto Crafter for Pam's HarvestCraft recipes, the crafter outputs tools like the pot or skillet to the output after every craft. If you set the crafter to Keep mode then it won't craft at all. It would be very useful if the crafter behaved the same as a Cyclic Assembler does, in that it crafts the item, but keeps non consumed items in the internal inventory and can keep using them for repeated crafting.

Yeah totally agree here. This is definitely something that would be really handy. I mean sure it's possible to fix this by extracting single stack crafting items and pump them around in a loop but that's just more lag on the server and client. (depending on the transport method).

Agree- this would be v useful... I currently have a chain of cyclic assemblers making carrot cake, but they get jammed up. I'd far prefer to use the crafter as it has better control of inputs... but the only solution seems to be to look the bakeware around (not good).

Will be implemented next release (for 1.9.4/1.10)


Can't run tensorflow on Ubuntu 20.10 with RX580

Similar to (but not the same): https://github.com/ROCmSoftwarePlatform/tensorflow-upstream/issues/1106
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 20.10 with 5.10 LTS Kernel
TensorFlow installed from (source or binary): pip/binary
TensorFlow version (use command below): 2.3.2 (tensorflow-rocm==2.3.4)
Python version: 3.8.6
GPU model and memory: Radeon RX 580

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
v2.3.0-2335-g6e65a385034 2.3.4
/src/external/hip-on-vdi/rocclr/hip_code_object.cpp:120: guarantee(false && "hipErrorNoBinaryForGpu: Coudn't find binary for current devices!")

Interestingly enough I get the error only when I output python console:
python
import tensorflow as tf
>>> tf.version.GIT_VERSION
'v2.3.0-2335-g6e65a385034'
>>> tf.version.VERSION
'2.3.4'
>>>
/src/external/hip-on-vdi/rocclr/hip_code_object.cpp:120: guarantee(false && "hipErrorNoBinaryForGpu: Coudn't find binary for current devices!")

Describe the current behavior
When I run tensorflow I always get:
/src/external/hip-on-vdi/rocclr/hip_code_object.cpp:120: guarantee(false && "hipErrorNoBinaryForGpu: Coudn't find binary for current devices!")
Describe the expected behavior
Run.
Standalone code to reproduce the issue
python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Other info / logs Include any logs or source code that would be helpful to

Hi @staticdev , RX580 (gfx803) is not supported by ROCm stack.
If you want to try it out with ROCm, I'd suggest you to install the rock-dkms kernel driver from the following ROCm3.5 release:
http://repo.radeon.com/rocm/apt/3.5/
And go with the following ROCm3.5 based docker images:
https://hub.docker.com/r/rocm/tensorflow/tags?page=1&ordering=last_updated&name=rocm3.5

Hi @staticdev , I was able to use ROCm 3.5 tensorflow ROCm public docker image to run workloads on my Radeon RX 580 using my threadripper 3960X work station, using Ubuntu18.04 system.
More details on my system configuration and steps:

kernel driver - use the stock upstream 5.4.0 kernel driver without any ROCm kernel driver modules, steps:

# optional - purge any rock-dkms packages installed on your system
sudo apt autoremove -y rock-dkms

# Install the upstream 5.4.0 kernel driver, which has gfx803 firmware support built-in
sudo apt-get install --install-recommends linux-generic-hwe-18.04

# reboot your systems to switch to 5.4.0 kernel driver
sudo reboot

# after reboot confirm if you kernel driver is using 5.4.0, here's my log:
~$ uname -a
5.4.0-71-generic #79~18.04.1-Ubuntu SMP Thu Mar 25 05:45:39 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

docker container - use the ROCm3.5 docker container we published on Dockerhub.com

# install docker support if not already, more details https://github.com/RadeonOpenCompute/ROCm-docker/blob/master/quick-start.md
curl -sSL https://get.docker.com/ | sh

# pull and launch the ROCm3.5 docker images
alias drun=' sudo docker run -it --network=host --device=/dev/kfd --device=/dev/dri --group-add video --cap-add=SYS_PTRACE --security-opt seccomp=unconfined -v $HOME/dockerx:/dockerx -v /data:/data --shm-size=16G'

drun rocm/tensorflow:rocm3.5-tf2.1-dev

confirm GPU is recognized and run some benchmarks

# check rocm-smi and confirm if GPU is shown up
# /opt/rocm/bin/rocm-smi
========================ROCm System Management Interface========================
================================================================================
GPU  Temp   AvgPwr  SCLK    MCLK    Fan     Perf  PwrCap  VRAM%  GPU%
0    38.0c  7.165W  300Mhz  300Mhz  23.92%  auto  110.0W    2%   0%
================================================================================
==============================End of ROCm SMI Log ==============================

# execute tf_cnn_benchmark
cd ~/benchmarks/scripts/tf_cnn_benchmarks
python3 tf_cnn_benchmarks.py
...
2021-04-12 17:23:00.572668: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1241] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 7478 MB memory) -> physical GPU (device: 0, name: E
llesmere [Radeon RX 470/480/570/570X/580/580X], pci bus id: 0000:01:00.0)
TensorFlow:  2.1
Model:       trivial
...
100     images/sec: 6725.5 +/- 27.4 (jitter = 341.4)    14.298
----------------------------------------------------------------
total images/sec: 6684.21
----------------------------------------------------------------

The gfx803 with ROCm-3.5.1 can run properly. Only need fix the LD_LIBRARY_PATH for /opt/rocm/lib.
And I wrote a documents for how to re-compile ROCm-4.1 components for gfx803.
https://github.com/xuhuisheng/rocm-build/tree/master/gfx803
If just want to fix the hipErrorNoBinaryForGpu, we only need re-compile rocRAND with AMDGPU_TARGETS=gfx803.
if want to run GEMM properly, we need re-compile rocBLAS with patch.


set janitza-gridvis 2.1.25 into stable

just updated some bugfixes / comments for logging --- no functional changes

honestly ... yes also with "no functional changes" we should please keep the process to have  a new version in latest for some days ... I will merge now last time directly

OK, thanks


Separate initialization from execution in CommandApp

As a user of the API, I'd like the ability to perform global setup and teardown in my application without utilizing base classes for my Command<> / AsyncCommand<> subclasses.
Is your feature request related to a problem? Please describe.
At the moment, if I want to perform some global initialization and/or cleanup, I am required to use base classes or other obscure hacks. The problem with the base class solution is that it creates a lot of constructor boilerplate and makes the code difficult to maintain when changes are needed in that common base class, especially when that change involves modifying dependencies (parameters for DI).
Describe the solution you'd like
I'd like the logic in CommandApp.RunAsync() to be separated such that the following is separated into distinct phases of execution controlled by the user of the API:

Parsing of the command tree. Registration of internal types and dependencies. Finally, creation of the implementation for ITypeResolver.
Execution of the actual commands.

This allows me to do the following:

Perform setup of my command line application as normal.
Invoke a new method (or even better: Use the builder pattern) to initiate step 1 above (e.g. CommandApp.Setup()).
Access the ITypeResolver via some property (e.g. CommandApp.Resolver) to perform DI resolution for any dependencies needed for my global initialization/cleanup.
Perform global initialization as needed in Program.Main()
Invoke CommandApp.Run() and store the result.
Perform global cleanup as needed in Program.Main()
Return the result of the previously executed CommandApp.Run() command.

Describe alternatives you've considered

Abusing my implementation of ITypeRegistrar to invoke a callback to perform custom initialization when ITypeRegistrar.Build() is called.
Implementing a base class shared by all command handlers that implements Command<> or AsyncCommand<>.

Additional context
I am willing to implement the changes needed here. I've already played around with some ideas in a local branch and landed on two approaches:

Quick & dirty: Add new methods to CommandApp with the goal of reducing footprint. Not the most ideal change and am not completely happy with it, but it at least gets that separation I'm aiming for.
Implement something like CommandAppBuilder that uses a syntax similar to new CommandAppBuilder().WithConfiguration(...).Build() to construct a CommandApp and return it, which will be responsible for the first phase of initialization. The returned CommandApp would actually be composed in a wrapper object that only allows users to invoke Run() / RunAsync() on it.

The second approach is more drastic, but I think there's a way to maintain backward compatibility in both scenarios.
The reason I'm creating an issue instead of a pull request:

I want to discuss the change before I spend time coding it. The change is non-trivial so I need to consider the maintainers' opinions.
I'm uncertain about how to split the logic gracefully in CommandExecutor.Execute(). There's a lot of separation of concerns issues in this method:

Initialization (registration) logic is mixed in with what appears to be processing logic.
There's a circular dependency between DI registration and command tree processing which further complicates separation of the two.
There's CLI parsing code for the version options here that probably belongs in its own Command subclass; however I believe cleaning this up properly requires implementing a way to add "global options" to the base command without introducing new subcommands/verbs. There are other issues here that call for this, and I imagine this code exists because of the lack of this functionality.

Happy to help invest time in this library if the developers have the time to help guide me! Thank you for reading!

@patriksvensson I apologize for the ping. I was hoping you might have time to read & respond to my issue. It's somewhat a blocker for me. I've resorted to some nasty workarounds that I'm not really fond of. I'm very interested in reading your thoughts on the matter. Thank you!

Hello @rcdailey, thanks for taking the time to write the above.  I've thought on several occasions the command setup/parsing could benefit from some rejigging to eliminate some of the statics, make better use of interfaces, support user-provided implementations through the DI somehow.
For example, see this PR: https://github.com/spectreconsole/spectre.console/pull/1133  I've basically encapsulated and exposed the help writer functionality such that users can call it directly from within a command eg. see: https://github.com/spectreconsole/spectre.console/blob/1fba0f97178c5bcf07e0bc51681413a7df199a4f/test/Spectre.Console.Cli.Tests/Data/Commands/DefaultCommand.cs
However, the instantiation of the help writer remains hardcoded instead of being instantiated through DI, currently preventing users from providing their own implementations of IHelpProvider if they wish to do so. I believe what you propose above would fix this but across the entire command lifecycle.
I'm interested in your second approach suggested above.  I'm the maintainer for the command line parsing aspect of spectre.console and would be willing to pursue this idea further with you, if you are still interested. I'd also be willing to have a look at any exploratory/POC etc code you may have for this sitting on a branch etc.

Hi @FrankRay78, thanks for responding. It's been quite a while since I posted this, so I'll need to go back to my fork and see if I had a local branch or something. I do remember in the process of coding option 2, that I ended up giving up because of the massive amount of refactoring I was doing, which wasn't ideal for backward compatibility concerns. There were also some challenges I couldn't solve really well. I think it had to do with that help/version processing code you mentioned. I think I did have some ideas about how to maintain backward compatibility despite that, but I've long forgotten that by now.
I'm happy to find some time to revisit this and refresh my memory. Will you be able to dedicated time to this over the next few weeks/months? I don't mean for this to sound rude or disrespectful, but I have my own projects I work on during my spare time. Because of the lack of free time and other obligations I have, I don't want to spend more cycles on this if it's going to go cold again for another 7-8 months.
In the meantime, you can see my workaround for global setup and teardown here:
https://github.com/recyclarr/recyclarr/blob/cdf4b2768602f1f4e988d43ee73d14bc097f37c8/src/Recyclarr.Cli/Program.cs#L75-L92
I essentially hacked my type registrar class to let me get access to the internal ILifetimeScope from autofac. This was necessary because ContainerBuilder.Build() doesn't get invoked until I've already called CommandApp.Run(). This is ultimately the problem we're aiming to solve here.
Again I appreciate your response, it means a lot! I hope we can find some solution :)

Hello @rcdailey, thanks for replying. I'm aware of the time lag in this issue and also the difficulty of the issue at hand.  I got involved in spectre.console late last year and picked up some of the maintainer role early 2023.
Improving the initialization is of personal/intellectual interest to me, however I have some general project issue/PR housekeeping to do first before getting stuck back into coding (my head isn't in the code at the moment). This will likely take a month of my time before I'm ready to dedicate some thinking to this particular issue.
May I suggest that I drop you a line here when I'm good to go, and we see how you are fixed then?  No obligation but this will at least ensure I have some dedicated time to collaborate on this issue.

@FrankRay78 I think that's a fantastic idea. I'm of course happy to work on this issue with you, so feel free to ping me here when you're ready. No rush at all. I do have a workaround that keeps me happy for now.
I appreciate your involvement with the project. It means a lot. I'd hate for such a fantastic CLI library to go unmaintained!

Hello @rcdailey, just checking in to say this has not been forgotten.
Rather the work on exposing the help writer needed to be re-implemented to better support DI in CommandExecutor.Execute() (see my comment here: https://github.com/spectreconsole/spectre.console/discussions/1224#discussioncomment-6476669)
Once done, I think the general usage of DI, and the further potential usage of DI for other, currently internal spectre.console classes, becomes easier and cleaner to do.

Thank you for the update! It is very promising that progress is being made that gets us closer to being able to do this. I'm still using my rather unsavory workarounds to have more control over initialization logic. I'm definitely still interested in the outcomes being shared here.
As always, let me know if I can help in any way. You're doing great!

FYI. PR now submitted, if you want a peek at making the help writer injectable and extensible:  https://github.com/spectreconsole/spectre.console/pull/1259

@FrankRay78 I wanted to circle back to this. It's been a minute, but I recall that the PR you submitted inches us closer to being able to address this issue, but nothing in there directly changes the situation here. Can you confirm is this is correct? And if so, what is the next step to being able to address this?

I'd be happy to work on this for you, if you think we're ready to tackle this. I was always willing to help since I have a personal interest in this issue.
Could you provide some direction/advice as to how we should address this? I'm not as familiar with the current and desired architecture for Spectre.Console. I understand that the DI registration logic needs to be removed from the Run() code path; but not sure the best tactical solution to that. That's where your advice would be beneficial and allow for a more productive code review later.
Thanks for all your hard work!

Hello @rcdailey, just to say that I've pegged your message above, I'm always grateful for contributions, and I will respond more fully soon.

So, I've given this some thought.  Basically, Patrik is the overall maintainer for spectre.console and he keeps the architectural decisions in check, It works and I've come to defer to his judgement in these matters. Nils is a co-maintainer who implemented most of the existing DI logic. Given the complexity of this issue, in the end it will come down to both of these individuals deciding the change is worthwhile and on point. That said, they are both open-minded and grateful for good quality contributions, and as the CLI sub-system maintainer, I'm happy to support this once it's at a good standard (ps. many of the currently open, stale PR's were unsolicited, low value, poor quality, didn't have prior support - none of which should happen here).
Secondly, given the complexity of the base class / DI / setup + execute paths you rightly outline, I think perhaps the best way forward is to submit an initial draft PR outlining the indicative changes being proposed, or even just outlining the areas where changes will be needed. Even just inline commentary, kind of like an impact assessment to kick things off. This got me thinking further @rcdailey, if you have a working local version you've used, perhaps you could rebase your existing code to the most recent spectre.console branch, then submit your local changes in a PR for us to take a look at? I could offer an opinion on how that aligns with the rest of the codebase, and it wouldn't take much effort upfront. Alternatively, I am open to other ideas.

Regarding the draft PR idea, I think before I do any further coding, I'd like to see guidance/opinion from @patriksvensson and @nils-a first. I think my initial post here as well as some of the discussion here provide a lot of detail regarding aspects of the problems I observed.
The original coding I did was never complete and IIRC didn't even compile. It was just an exploratory effort. And finally, it was over a year ago since I last touched it so I've forgotten most of what I learned at the time. For all of those reasons, I'd like to discard my original work.
I think it would be best to take a fresh start on this and do it in the proper order this time, by starting with opinions/thoughts from the current maintainers. Hopefully they are willing to provide some thoughts and guidance. If they're OK with my involvement and a particular direction, I'm of course more than happy to do the work and take the initiative on getting a PR through.
I appreciate your help @FrankRay78 and I hope my plan here sounds reasonable.

I discussed this with some of the other maintainers @rcdailey, and there is a feeling that it's currently a solution without a problem. Although several of them did recognise the description of the issue as valid, but equally couldn't recall the exact ways it had been coded around by users of spectre.console. What would be necessary in taking this issue forward, is actual code showing how the current DI implementation becomes unwieldy when used in an app that wants to manage the container life cycle ie. an example of the problem to be fixed. Until then, the issue will remain open as a placeholder waiting for that to come along. At any point, do feel free to submit a coded example, or point out one you may stumble across. There are also other issues, just waiting to be fixed, if you have spare cycles.

@FrankRay78 I already have provided an example of how I'm working around the issue in my open source project. The link below is from my 2nd post in this thread:
https://github.com/recyclarr/recyclarr/blob/cdf4b2768602f1f4e988d43ee73d14bc097f37c8/src/Recyclarr.Cli/Program.cs#L75-L92
As you can see, I have to hack my ITypeRegistrar implementation to provide a lambda used to obtain an instance of ILifetimeScope from the ITypeRegistrar.Build() method, which isn't invoked until CommandApp.Run().
I should be able to perform operations against my DI container before Run() is invoked. Again, I feel all of this was provided/explained in my initial posts.
It would be great to see direct participation here by the others. I don't see how this is a "solution without a problem" since I have code that clearly demonstrates the struggle I'm dealing with. If there are other approaches, they could pitch in here with those and we can discuss if they are satisfactory.
My response to your initial post might have been a misunderstanding. I thought you were asking for an MCVE or something; which I didn't feel like I needed to provide given 1) the detail I provided in my issue description and 2) the existing open source code example.

Also I want to make something super clear. You said this yourself:

couldn't recall the exact ways it had been coded around by users of spectre.console

The problem is exactly that, it's something we have to "code around". It's very clearly a design issue requiring users to do that, if they want to avoid the other workaround pitfalls/issues I mentioned in my OP.
The goal of this issue is to address the design deficiency to such an extent that "coding around" the issue is no longer necessary. It's admittedly a little upsetting that despite my effort, support I've offered so far, and the fact that I've volunteered to do all the coding that this is being referred to as a "problem without a solution" when you yourself said "several of them did recognise the description of the issue as valid".
It doesn't make sense to me how it can be a valid issue but at the same time not recognized as a problem with a solution, especially since I wouldn't bother them to do any of the coding. Surely I must be missing something here.

Thank you Frank, and I apologize that I let my frustration leak through. Happy Holidays to you.

Thank you Frank, and I apologize that I let my frustration leak through. Happy Holidays to you.

It's fine, no apology necessary.   But appreciated.   So much OSS goes nowhere, for lack of involvement or poor communication or a host of other reasons. It's good you care enough to push this along, that's a massively good indicator.

@rcdailey would you have the cycles to take a look at #1412? It may solve your requirement.

Fixed by https://github.com/spectreconsole/spectre.console/pull/1412.


Don't ship the extra rake tasks in the gem

We only need the rspec task which gets run from within the gem artifact
in the test phase. Skips all the other stuff.
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

Fixes #9104


[whiteboard][0.3.0] - New Package

Tested on my tablet using the Oxide launcher.
cc https://github.com/fenollp/reMarkable-tools/issues/1 (thanks for the info! the contributing.md helped a lot)

Tested on my tablet using the Oxide launcher.
cc fenollp/reMarkable-tools#1 (thanks for the info! the contributing.md helped a lot)

Hope you like oxide 😄

Alright I have applied your changes and rebased and squashed (however that lost your history)

Tested installing and it works, although there seems to be an upstream bug with resuming.


Introduce LinkedIn OIDC Authenticator

Purpose

$subject

Related Issues

https://github.com/wso2/product-is/issues/19643

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


InfluxDB 2.0 cloud: invalid: memory allocation limit reached: limit 10000000 bytes, allocated: 9999952, wanted: 64

Steps to reproduce:
List the minimal actions needed to reproduce the behavior.

Use a dashboard in Grafana that has been running for weeks without problems
Refresh
Get random memory allocation limit errors

Expected behavior:
No errors, just measurements
Actual behavior:
I've got a Grafana dashboard with 7 graphs/tables that query InfluxDB 2.0 Cloud . Since this weekend, sometimes randomly I get invalid: memory allocation limit reached errors on random queries. Refreshing the dashboard solves is, or sometimes makes other graphs give messages like these:
invalid: memory allocation limit reached: limit 10000000 bytes, allocated: 9999952, wanted: 64
3 out of 7 queries take a bit longer, about 1-2 seconds, but ran without problems the last couple of weeks.
Has something changed in InfluxDB 2.0 cloud over the last couple of days? Might it be that InfluxDB 2.0 can't handle the 7 queries simultaneously (dashboard refresh) anymore?
Environment info:

InfluxDB 2.0 cloud
Grafana 7.2.1 ( and later 7.3.1 to test any difference, but no difference)

hi @paulfirstimpression do your dashboards use influxql or flux?  We can take a closer look at this.

Hi @aanthony1243, thanks! We're using Flux on InfluxDB 2.0 cloud (https://eu-central-1-1.aws.cloud2.influxdata.com).
I can send you one of the queries and organization id if you'd like.

I'm experiencing this as well, whether querying Influx Cloud directly through its web UI, or using Grafana.  Our DB has a bit of a cardinality problem, however, the error happens even when filtering for low-cardinality series.  The default System dashboard in Influx Cloud sometimes exhibits this symptom; it appears unrelated to the particulars of the query.

I'm experiencing this as well, whether querying Influx Cloud directly through its web UI, or using Grafana.  Our DB has a bit of a cardinality problem, however, the error happens even when filtering for low-cardinality series.  The default System dashboard in Influx Cloud sometimes exhibits this symptom; it appears unrelated to the particulars of the query.

I'm having the same issue on InfluxDB 2.0 Cloud (https://westeurope-1.azure.cloud2.influxdata.com) using Flux. It randomly occurs around 15% of the time.

Same problem here on influxDB 2.0 Cloud (https://eastus-1.azure.cloud2.influxdata.com/) using Flux as well.

same here. using influxdb 2.0 (https://eu-central-1-1.aws.cloud2.influxdata.com/) and flux.

The queries were working earlier today, but i'm running into same memory allocation limit reached error. As a cloud provider it makes me worry about the stability of the product.
Query:
from(bucket: "xxxx")
|> range(start: -7d, stop: now())
|> drop(columns: ["_field", "_measurement"])
|> aggregateWindow(every: 3h, fn: count, column: "_value", createEmpty: true)
|> drop(columns: ["_start", "_stop"])
|> map(fn: (r) => ({ r with _time: int(v: uint(v: r._time)) / 1000 / 1000 / 1000 }))
I can't imagine it's actually hitting a 10mb limit, but I could be wrong. Starting the range from -6d is roughly ~200kb of compressed data.

Same problem here. Any update after 6 months?

We believe that the inconsistent memory allocation errors in cloud2 should be resolved.  They have not been eliminated, but the new system behavior is that the query will either always succeed, or always run out memory, consistently.  If you continue to get memory allocation errors, this would be a separate issue around query usage and a new issue should be opened.


[CWS] optimization to DNS event unmarshalling path

What does this PR do?
This PR improves the DNS event unmarshalling code path by:

switching the buffer to a string builder (skipping the bytes to string copy)
re-implement the validation function to be alloc-free

This PR also removes the sync the build tags with the file names
Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

/merge

/merge


Update core version

ENG-4680
:warning: requires

https://github.com/secretkeylabs/sats-connect-core/pull/31
https://github.com/secretkeylabs/sats-connect/pull/148
Running npm i to update package-lock version once core version released

Already taken care of by other PRs.


unshare: can now revoke access for non-email types

Fixes #503
Allows types like domain, roles like reader etc to
be revoked without having to supply emails. In fact
domain access revokation doesn't have a specific email
so also needs to be handled.

Setting up
$ drive new --folder --no-prompt vines && drive pub vines

Before
$ drive unshare -role reader -type anyone vines
Revoke access for accountType(s)
    anyone

For roles(s)
    reader

File(s) to unshare:
    + vines

Proceed with the changes? [Y/n]:y
no matches found!

After
rive unshare -role reader -type anyone vines
Revoke access for accountType(s)
	anyone

For roles(s)
	reader

Addressees:
	+

File(s) to unshare:
	+ vines

Proceed with the changes? [Y/n]:y
successful unshare for vines with email "", role "reader" accountType "anyone"


Added Dockerfile and docker-compose

fixes #324
Added Dockerfile and docker-compose and docs needed regarding that.

@HimanshuNarware Can you please add the labels to PR.
Thankyou
Regards
Ratan Gulati

@Ratangulati  feel free to create more issues also starred our repo :)

@Ratangulati feel free to create more issues also starred our repo :)

Sure


mTLS passphrase use.

We currently use a passphrase for the client side encrypted private key for mTLS and the phrase is gathered by the tenant code using ConfigParser.
I question what extra security this really brings. If someone with ill intention gains access to the system sufficient to steal the client certs, its trivial for them to open keylime.conf and grab the passphrase which is stored as plain text.
This is not to say its less secure than no passphrase, but its akin to buying a very expensive tungsten lock and leaving the key under the door mat.
Client side security will be bolstered once JWT is implemented and we will then be 'belt and braces' with both mTLS and tokens combined. With that in mind I wonder if we should drop support for the passphrase as it adds little value in it's current implementation and will only lead to a factor that will be reported on as insecure in any threat analysis / pen tests that occur.

@jetwhiz / @nabilschear any thoughts?

@lukehinds  I agree that a more mature access management (done correctly) can be a much better way to handle this than hard-coding a password in the configuration file.  I'm inclined to leave this in until we have that set up, though, since full compromise of the verifier or tenant is outside the threat model of Keylime.  There would likely be much more severe and profound consequences to a full verifier compromise, for instance, than someone just getting access to these keys, though I defer to @nabilschear to see his take.

hey @jetwhiz
I am having some trouble trying to create a client-private.pem with no passphrase. From what I can see the pw is set here globalcb
https://github.com/keylime/keylime/blob/610565d26bfc360ddf9cff39aba6461f70238aa5/keylime/ca_util.py#L118-L122
Looking at save_bio_key in M2Cyrpto it requires the passphrase as a callback (you cannot pass over '' or None etc).
https://fossies.org/dox/m2crypto-0.30.1/classM2Crypto_1_1EC_1_1EC.html#a09e1f2f3dc4966624b7a27d684f3874e
The only way I can see of doing this is removing it afterwards (which is a less than ideal solution).
Any ideas, is this perhaps set earlier somewhere in the verifiers private key?
Reason for doing this is we need to move to using python requests as it handles sessions better (for auth / jwt), but requests won't work with a passphrase. https://github.com/psf/requests/issues/1573

update:
    # write out the private key with password
    with os.fdopen(os.open("%s-private.pem"%name,os.O_WRONLY | os.O_CREAT,0o600), 'wb') as f:
        biofile = BIO.File(f)
        pk.save_key_bio(biofile, None)
        biofile.close()

See any complications with that @jetwhiz @nabilschear , it works fine (I no longer need a passphrase in the tenant).

I think that should do what you're looking for, but we should be careful about where we store those unprotected private keys (granted the password was stored in /etc/ before anyways, as you point out).
Is there any way psf can take the raw private key via a variable instead of from a file, so we never need to write keys out in the first place (though this would require more changes to keylime to accommodate)?

I think that should do what you're looking for, but we should be careful about where we store those unprotected private keys (granted the password was stored in /etc/ before anyways, as you point out).

So I think we can iron this out in documentation and guidance. We would remind users they should be mindful of protecting these assets, so for example 'tls_dir' be on a HSM or the like.

Is there any way psf can take the raw private key via a variable instead of from a file, so we never need to write keys out in the first place (though this would require more changes to keylime to accommodate)?

I don't know of anyway, but open to considering options.
As it stands now we will have this as our posture.

We no longer have a passphrase to protect the keys.
We now however require all sessions be authenticated.

  At the end of the day, the keys have to live unprotected somewhere (either encrypted with the password stored elsewhere on the disk (protected with fs permissions), or just stored unprotected with FS protections.  By using the password, we make the private keys a little more portable, but i agree the benefit is incremental at best.  Note that ca_util does have the --insecure option which will generate unprotected private keys for cert packages.


Support netstandard 2.1 and ef 6.3 for netcoreapp 3.0

There is already a PR for this in progress. Can you double check ?

@StefH Whichever PR makes my build warnings go away I'm fine with :)
What's the eta?

ETA - once the preview NuGets have been tested, a new NuGet will be released.


Can you add a paper from ASE 2022

https://conf.researchr.org/details/ase-2022/ase-2022-research-papers/56/Effectively-Generating-Vulnerable-Transaction-Sequences-in-Smart-Contracts-with-Reinf

Okay, this should be on the agenda


Basket::add() parameters problem

I do not understand why not use only a simple Product object as parameter instead of $sku, $name, $price, $action...
I store my all products in a database table and my API got a product ID from the frontend, find the product by ID, so I have a product record, in my case a Product eloquent object. I thought, that I wrap this eloquent object and create from it a new PhilipBrown\Basket\Product and add it to the basket. But I can not do this now.
public function add(Product $product)
{
    $this->products->add($product->sku, $product);
}

Have you any idea what is the best solution for my problem?
Thanks in advance!

https://github.com/ennosol/basket/pull/3
https://github.com/ennosol/basket/pull/4


Add Migration Guide for Opflow

Summary
This PR closes #9484
Details and comments
Open Questions:

[x] Should I remove the links to the opflow API ref?
[x] Any formatting improvements?
[ ] Any examples that you miss?

TO-DOs:

[x] Add StateFn and expectations examples
[x] Add links for gradient section (tutorial still not created)
[x] Add hyperlinks to other sections when mentioned (see ... example type of references)
[x] Make explanation for evolutions more concise

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.273%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
67223

Relevant Lines:
78833

💛  - Coveralls

Should I remove the links to the opflow API ref?

If this is published along with the API ref and by kept version, as the docs currently are, then this migration guide could be removed when opflow is removed. If not then afterwards the class refs will just be highlighted - just not links since they would not resolve. To me having them as class refs so they can be links seems better - since as links I can go to the opflow class itself for more detail if I need that.

I think this is very detailed and looks great! I left some small comments below. One thing we could add is that we lose some flexibility that opflow had but instead gain performance (we could e.g. add @a-matsuo's plots for the gradients) to motivate a bit more why we change to the primitves 🙂

Thanks for the review!! I think that the motivation you mentioned would be a great suggestion for the migration blog post. We could later link the post in the guide.

I will continue the review later today and tomorrow.


[e2e]: go workflow_dispatch main config-noldflags slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/3247294186
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.workflow_dispatch.main.config-noldflags.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.workflow_dispatch.main.config-noldflags.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Fri Oct 14 03:47:35 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/3252009082
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.workflow_dispatch.main.config-noldflags.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.workflow_dispatch.main.config-noldflags.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Fri Oct 14 18:27:49 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/3252520362
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.workflow_dispatch.main.config-noldflags.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.workflow_dispatch.main.config-noldflags.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Fri Oct 14 19:50:13 UTC 2022
Tests are passing now. Closing this issue.


Prepare script for creating xcframework

Hi, I have created script for producing XCFramework. It would be great if xcframework binary is part of next release for easy integration with Xcode project.

Thanks for the PR @marekpridal! I'll make sure to take a closer look at this over the weekend!

@marekpridal do we still need this script? I believe the latest version supports XCFrameworks.


Update README.md

I updated the README based on #7

Hey, @jdisho. I've decided to simply add implementation of orEmpty to README:

I've just released 0.7. Thanks for your contributions! I think RxNuke now looks and feels great.


Make image quality configurable

Encode always compresses jpegs at 95%, it would be nice if this was configurable, or accessible from Save
https://github.com/disintegration/imaging/blob/master/helpers.go#L94

Hi,
Save is meant to be a shortcut for a most basic usecase for each image format. That's why it doesn't take any of format-specific options like Quality (for JPEG) or Compression (for TIFF) or NumColors, Quantizer, Drawer (for GIF). I think that if you need these options it's better to use specific packages directly (e.g. jpeg.Encode), than incorporating all the options into imaging.Save.


Minor correction

The sentence "Application Insights has a rich out of the box with Service Fabric." should probably read something like "Application Insights comes with a rich out of the box experience when using Service Fabric."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cd08fcdd-5dd5-41b5-c433-049510ccf027
Version Independent ID: 83c2cef2-00a2-ce6b-3ccb-0471a9cdf18f
Content: Azure Service Fabric Event Analysis with Application Insights
Content Source: articles/service-fabric/service-fabric-diagnostics-event-analysis-appinsights.md
Service: service-fabric
GitHub Login: @srrengar
Microsoft Alias: dekapur; srrengar

@samiam236 Thanks for the feedback! We are currently investigating and will update you shortly.


Fix scripts to not execute when imported by ES module, calculate versions 10 at a time

These are prerequisites for some manual testing I'm doing on pnpm workspaces, but are beneficial separately from that effort, so I'm PRing to master.
I tested calculate-versions at this level of parallelism and it completed in less than 5 minutes and I wasn’t rate limited. I think it takes somewhere between 30 and 60 minutes normally.

I don’t need an npm release for these, but I guess I should still add a changeset.

I don’t need an npm release for these, but I guess I should still add a changeset.

Probably not required; I honestly expect that we'll do a mass bump for pnpm anyway.

Oh, also, do you need to path.resolve the filenames in the checks

Tested with Node 20 and they were absolute. Not sure about older versions.


Where is the Network Policy Configured?

For more clarity step 1 should read:

On the NPS Server, open the NPS (Local) console, expand Policies, and click Network Policies.

Configure Network Policy
Recall that the NPS server with the Azure MFA extension is the designated central policy store for the Connection Authorization Policy (CAP). Therefore, you need to implement a CAP on the NPS server to authorize valid connections requests.

In the NPS (Local) console, expand Policies, and click Network Policies.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 61df48bb-a963-b1f0-8f64-b55d0bd6904c
Version Independent ID: 677de59f-a222-8905-11c0-a3ac619d8b56
Content: Remote Desktop Gateway integration with Azure MFA NPS extension
Content Source: articles/active-directory/authentication/howto-mfa-nps-extension-rdg.md
Service: active-directory
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@jonwbstr Thanks for your feedback! We will investigate and update as appropriate.

@jonwbstr Thanks for the feedback to improve the content. The PR for the change has been created and it will be merged soon.


[Terraform] Check some allow-list before deploying Policy

Benefit/Result/Outcome
So that policy assignment doesn't fail if it's not supported in my cloud.
(Originally a part of #454 but broken up so that it's an independent task and can be triaged separately.)
Description
The policy assignment in a Terraform deployment may fail if some of the policies packaged in MLZ are not supported in a given cloud. Perhaps it's a good idea to create some allow-list of environments to compare before attempting to create policy assignments e.g.:
locals {
  mlz_policy_environments = ["public", "usgovernment"] # terraform azurerm environments where the MLZ policies are supported
}

module "hub-policy-assignment" {
  count = var.create_policy_assignment && contains(local.mlz_policy_environments, lower(var.environment)) ? 1 : 0
}

Acceptance Criteria

The Terraform implementation of MLZ only deploys policies into the clouds we know support the policies packaged in MLZ
Implement equivalent on Bicep

Closing per @shawngib's recommendation.


Add array_ufunc protocol to DataFrame and Series (#3044)

Add array_ufunc protocol to dask.dataframe
Example
In [1]: import numpy as np, dask.dataframe as dd, pandas as pd
In [2]: numpy_arr = np.random.randn(5)
In [3]: ps = pd.Series(numpy_arr)
In [5]: np.sum(np.ceil(ps))
Out[5]: 2.0
In [6]: ds = dd.from_pandas(ps,3)
In [9]: np.sum(np.ceil(ds))
Out[5]: dd.Scalar<series-..., dtype=float64>
In [6]: _.compute()
Out[6]: 2.0

Add out parameter support
Example
In [1]: import numpy as np, dask.dataframe as dd, pandas as pd
In [2]: ps = pd.Series(np.random.randn(5))
In [3]: ds = dd.from_pandas(ps, 3)
In [4]: dsc_out = dd.core.Scalar({('s', 0): 0}, 's', 'i8')
In [5]: np.sum(ds, out=dsc_out)
In [6]: dsc_out
Out[6]: dd.Scalar<series-..., dtype=float64>
In [7]: dsc_out.compute()
Out[7]: 0.2768562049182187
In [8]: np.sum(ps)
Out[8]: 0.2768562049182187

[ ] Tests added / passed
[ ] Passes flake8 dask
[ ] Fully documented, including docs/source/changelog.rst for all changes
and one of the docs/source/*-api.rst files for new API

I've only briefly gone through this, but in general this looks excellent to me.  I'm really looking forward to playing around with it.
cc @TomAugspurger @shoyer you may both find this interesting.  Also cc @sinhrks if he's around.

Merging.  Thanks @almaleksia !

@mrocklin thank you :)

This is one of the nicer first PRs I've seen.
If there is anything we can do to keep you busy here please don't hesitate to speak up :)

@mrocklin thank you for your feedback, I really appreciate it. I'll be happy to contribute further as soon as I find another issue that I could do. If you have something on mind I can take it :)

Happy to point you to good issues.  What are your interests?  Just
dataframes?  Also arrays?  Machine learning algorithms?  Network
communication and process handling?
On Thu, Apr 5, 2018 at 1:49 PM, Ksenia<EMAIL_ADDRESS>wrote:

@mrocklin https://github.com/mrocklin thank you for your feedback, I
really appreciate it. I'll be happy to contribute further as soon as I find
another issue that I could do. If you have something on mind I can take it
:)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/pull/3370#issuecomment-379020828, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszK-SfpR_8gl1dFBIYFrXrdBuuSduks5tllk6gaJpZM4TFJcC
.

@mrocklin I'm not picky but smth related to ML algos would be great!

@almaleksia you might have a look at the dask-ml repository then: https://github.com/dask/dask-ml
My short-term wishlist includes

dask-aware versions of scikit-learn's train_test_split / CV things (started at https://github.com/tomaugspurger/dask-ml/tree/train-test-split)
collaborative filtering / recommendation systems: https://github.com/dask/dask-ml/issues/139, because it'd be fun
High Cardinality Encoders: https://github.com/dask/dask-ml/issues/120
Anything you're interested working on :)

@TomAugspurger thanks a lot, I‘ll take a look :)

Some additional Dask issues that may be interesting.  They are either dataframe related, or are good introductions to other topics.

https://github.com/dask/dask/issues/3376
https://github.com/dask/dask/issues/3361 (I haven't looked deeply at this, but perhaps someone should)
https://github.com/dask/dask/issues/3336
https://github.com/dask/dask/issues/3333 (this gets into join code, which is a bit intense)
https://github.com/dask/dask/issues/3302 (a good introduction into dask arrays, which are, I think, somewhat more interesting algorithmically)
https://github.com/dask/dask/issues/3269
https://github.com/dask/dask/issues/3253 (an introduction into the local scheduler, this would result in an project that is external to the main codebase, living somewhere something like https://github.com/dask/dask-celery
https://github.com/dask/dask/issues/3241 (some more algorithmic and mathematical ideas)
https://github.com/dask/dask/issues/3240 (this connects to new work in pandas, cyberpandas, geopandas.  it would be very nice to see dask.dataframe adopt this as well)
https://github.com/dask/dask/issues/3206

@mrocklin great list, thanks!


chore: rename lint:prettier scripts to reflect their function

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
13

Relevant Lines:
13

💛  - Coveralls