======== Exception caught by widgets library ======================================================= The following assertion was thrown while finalizing the widget tree: 'package:flutter/src/widgets/framework.dart': Failed assertion: line 1197 pos 12: '_debugLifecycleState == _StateLifecycle.ready': is not true.

Steps to Reproduce

Execute flutter run on the code sample
...
...

Expected results:
Actual results:

Code sample

Logs

Hi @AravindNGA,
When opening an issue, please try to provide all or some of the information indicated in the template.

Issue Template
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
- https://flutter.dev/
- https://api.flutter.dev/
- https://stackoverflow.com/questions/tagged/flutter?sort=frequent

If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports

Steps to Reproduce

Please tell us exactly how to reproduce the problem you are running into.

Please attach a small application (ideally just one main.dart file) that
reproduces the problem. You could use https://gist.github.com/ for this.

If the problem is with your application's rendering, then please attach
a screenshot and explain what the problem is.

1. ...
2. ...
3. ...

Please tell us which target platform(s) the problem occurs (Android / iOS / Web / macOS / Linux / Windows)
Which target OS version, for Web, browser, is the test system running?
Does the problem occur on emulator/simulator as well as on physical devices?

Target Platform:
Target OS version/browser:
Devices:

Run your application with `flutter run --verbose` and attach all the
log output below between the lines with the backticks. If there is an
exception, please see if the error message includes enough information
to explain how to solve the issue.

Run `flutter analyze` and attach any output of that command below.
If there are any analysis errors, try resolving them before filing this issue.

Finally, paste the output of running `flutter doctor -v` here.

Closing this issue, since no information has been provided.
Thank you.


Use custom XDG_RUNTIME_DIR

This patch add custom XDG_RUNTIME_DIR so user can customize it as
needed. For RPM installation we use flotta user XDG_RUNTIME_DIR env var
unless user overwrite it.
Signed-off-by: Ondra Machacek<EMAIL_ADDRESS>

LGTM


Staging dns client

@blogic  there is a small bug fix that i want to merge but i there are merge conflicts with pending

merged into pending, Thanks !


The minimap has the wrong interpretation of the Y access

The Y location provided in the minimap in the Explorer (at least in .today) is wrong.
Looks like it is reversed (treated like -Y)
For example, check out:
https://explorer.decentraland.today/?position=10%2C10
looks like it is pointing at 10,-10 instead of 10,10

Fixed


clear setTimeout when useConditionalTimeout unmount

When I try to use the useConditionalTimeout hook to make a modal component which will appear after a specific time that API provided.The older callback doesn’t be cleared so that the component will appear at the wrong moment. So I add the clear callback to the return of the setTimeout effect.

@KakeruChang thank you very much for your PR, I'll have a look at it soon

Hi @KakeruChang I had a look at your PR and merged it but then I noticed tests where failing.
In addition to that to clear the timeout at on-mount there's an option you can pass... check the documentation

@antonioru Ok, thank you!


authentication_traces: second factor authentication (and IPs) not logged

Hi,
If I'm not mistaken, the second factor authentication is not logged.
Maybe it would be a good idea to replace “isAuthenticationSuccessful” by two distincts fields – one for each factor.
What's more, logging IP addresses would also be interesting, both for log analysis/forensics in a SIEM. and to trap bruteforce attempts.
My point is that bruteforce prevention could also be based on the originating IP address, rather than the username: as of now, if user foobar is subject to a bruteforce attack, it may be unable to legitimately log in – denial of service risk.
P.-S.: If anyone is interested in on how to prevent bruteforce attacks against Authelia's login page, one solution is to use Fail2Ban, with the following filter.
[Definition]

failregex = ^<HOST> -.*\] "POST /api/firstfactor.* HTTP/\d+\.\d+" [54]\d\d .*$
            ^<HOST> -.*\] "POST /api/totp.* HTTP/\d+\.\d+" 5\d\d .*$

ignoreregex =

This filter can be applied on an Nginx access log (default log format) dedicated to Authelia (to prevent false positives).

Nice! Good idea to use fail2ban to prevent bruteforce. I will definitely put it in the README.

You are right, second factor is not logged because I think the biggest threat is at first factor step.  But yes, it can be safer to regulate on second factor as well and that's why I put low priority on this issue.
For the IP part, I think Fail2ban is a better solution than implementing something at Authelia's level since it allows Authelia not to handle all the pressure of a DDOS from the same IP. I think it's better if caught early in the stack.

I totally agree with you: dedicated solutions like Fail2Ban should handle this, not Authelia.
However, to “feed” solutions like Fail2Ban, “accurate” log files are required, to minimize the number of false positives or false negatives. Therefore, relying on Nginx log file is definitely not the best option, for at least three reasons:
• in case the Nginx server providing access to Authelia's backend does not have a dedicated log file, such a Fail2Ban filter may trigger false positives – e.g., considering another site being served by Nginx and which logfile is shared with Authelia (default is /var/log/nginx/access.log for every server), then if somebody sends an HTTP POST /api/firstfactor and which results in an HTTP error 4xx, the Fail2Ban would match.
• a POST /api/firstfactor to Authelia which results in an HTTP error 500, does not ensure 100% it was actually a login attempt – an error 500 may be sent back to the client for plenty of other reasons (not necessarily by Authelia's backend: Nginx could do it, for some reason) –, for instance.
• it depends on Nginx log format
This is why I think Authelia should – itself – log information about the login attempts (succes or failure, for both factors, and corresponding IPs), because there wouldn't be therefore any ambiguity on what actually happened. Provided directly by Authelia, such login details would be “reliable”.
Furthermore, not only such information is important for bruteforce prevention, but it is actually very important for audit purposes and forensics – it would be very useful to feed a SIEM (e.g., Splunk) with such logs.

Hello @n4kre ,
I see your points and I have a good news for you. I improved the logs with #125. Now we can clearly track a session, a request and an IP since each of them are now logged for each log message. I think it will help fail2ban to track potential attackers.
Login attempts are not yet logged though but I can definitely do it. I'll update the thread once done.
Thanks.

Thank you @clems4ever!
As you suggest, It would be nice to be able to track login attempts, maybe in a less verbose way (for a log level greater than or equal to info) – e.g., <Date> - <IP> - <Username> - <Password|TOTP|U2F> validation: <success|failure> –, and in to a dedicated log file, which path is customizable in Authelia's configuration file.

In the same way, logging password reset and second factor registration request is a good idea – to prevent bruteforce and thus avoid mailboxes from being floode (potentially resulting in a denial of service).


Added transformation ops and binary logic ops

Codecov Report

Merging #13 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #13   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines         233    250   +17
=====================================
+ Hits          233    250   +17

Impacted Files
Coverage Δ

dist/partial.lenses.validation.cjs.js
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7025905...e5e8cef. Read the comment docs.


show the occupancy feedback more

Always show when the current time is more than 10 minutes more than the departure time.
(issue is that for some reason locally I keep seeing the old formula, even after changing it to this.)

Same here... Old formula is still in place...

How is that even possible?


Roll Flutter Engine from 703c9a14ac7f to a3c5a319fccb (23 revisions)

https://github.com/flutter/engine/compare/703c9a14ac7f...a3c5a319fccb
2023-06-22<EMAIL_ADDRESS>Workaround a release blocker after libc++ change (flutter/engine#43091)
2023-06-22<EMAIL_ADDRESS>Roll Skia from 8168c802c391 to 09b36b8ce0db (1 revision) (flutter/engine#43102)
2023-06-22<EMAIL_ADDRESS>[Impeller] Reland: Correctly compute UVs in texture fill (flutter/engine#43093)
2023-06-22<EMAIL_ADDRESS>[Impeller] Add validation forbidding SamplerAddressMode::kDecal on the OpenGLES backend (flutter/engine#43094)
2023-06-22<EMAIL_ADDRESS>Use minor version, ignore patches for CodeQL (flutter/engine#43088)
2023-06-22<EMAIL_ADDRESS>Print a warning when a message channel is used on the wrong thread. (flutter/engine#42928)
2023-06-22<EMAIL_ADDRESS>Roll Skia from 3f3e1da4b7eb to 8168c802c391 (4 revisions) (flutter/engine#43096)
2023-06-22<EMAIL_ADDRESS>[Impeller] default sample count back to 1 (but configure to 4 in defaults). (flutter/engine#43089)
2023-06-22<EMAIL_ADDRESS>[web] Don't get break type from v8BreakIterator (flutter/engine#43053)
2023-06-22<EMAIL_ADDRESS>Roll dart to 3.1.0-239.0.dev (flutter/engine#43083)
2023-06-22<EMAIL_ADDRESS>Revert "[Impeller] dont use concurrent runner to decode images on Android." (flutter/engine#43061)
2023-06-22<EMAIL_ADDRESS>[Impeller] Add fence waiter trace event. (flutter/engine#43092)
2023-06-22<EMAIL_ADDRESS>[Impeller] remove Vulkan pipeline cache mutex. (flutter/engine#43085)
2023-06-22<EMAIL_ADDRESS>Revert "[Impeller] Correctly compute UVs in texture fill" (flutter/engine#43087)
2023-06-22<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from 7EZeNE4aGd29VfDly... to tcVndpnH_jzGm5LsJ... (flutter/engine#43081)
2023-06-22<EMAIL_ADDRESS>Roll Skia from 117f57a53215 to 3f3e1da4b7eb (4 revisions) (flutter/engine#43080)
2023-06-22<EMAIL_ADDRESS>Roll ANGLE from<PHONE_NUMBER>a4 to bbcf54bcb738 (1 revision) (flutter/engine#43079)
2023-06-22<EMAIL_ADDRESS>Roll Skia from 5013b651f8ec to 117f57a53215 (1 revision) (flutter/engine#43078)
2023-06-22<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from QtQznuUmHMTyORqxJ... to Ylc35wOk0_j0NLzDv... (flutter/engine#43076)
2023-06-22<EMAIL_ADDRESS>Roll ANGLE from a2b3f9b64670 to<PHONE_NUMBER>a4 (1 revision) (flutter/engine#43075)
2023-06-22<EMAIL_ADDRESS>Roll ANGLE from ac263582dda4 to a2b3f9b64670 (1 revision) (flutter/engine#43074)
2023-06-22<EMAIL_ADDRESS>Roll Skia from 71047dca9f77 to 5013b651f8ec (4 revisions) (flutter/engine#43073)
2023-06-22<EMAIL_ADDRESS>[Impeller] Correctly compute UVs in texture fill (flutter/engine#43028)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 7EZeNE4aGd29 to tcVndpnH_jzG
fuchsia/sdk/core/mac-amd64 from QtQznuUmHMTy to Ylc35wOk0_j0
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Update aws-core, http-client-spi, ... to 2.21.10

About this PR
📦 Updates

software.amazon.awssdk:aws-core
software.amazon.awssdk:http-client-spi
software.amazon.awssdk:netty-nio-client

from 2.20.162 to 2.21.10
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "software.amazon.awssdk" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #1254.


move to node 17 for github workflows

Summary
There is a known bug in npm versions 16.14.1 and 16.14.2. The github workflows were fixed at node version 16.14.0 until a fix was in place. Node 17 is now released and stable, so moving to that version instead
Description for the changelog
move to node 17 for github workflows
Other info
This reverts the change that temporarily fixed the node version to 16.14.0 in commit 82c9d49d2d3a315650a7aed7e1b3a3308a7b44a7

Codecov Report

Merging #432 (536def3) into main (d99143c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #432   +/-   ##
=======================================
  Coverage   96.54%   96.54%
=======================================
  Files         127      127
  Lines        1826     1826
  Branches      111      111
=======================================
  Hits         1763     1763
  Misses         56       56
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d99143c...536def3. Read the comment docs.

Merging pull request after all checks have passed


Remove link between .default and permissions

/.default really has nothing to do with application permissions. We decided to use /.default on the client credentials flow as a forward compatibility mechanism - it means we can now use /.something-else in the future, because we know nobody is using that. Completely independently of this, on the client credentials flow, we happen to always include all your application permissions in the token (if you have any - it's also possible to do the client credentials flow without any application permissions, for authentication but not authorization). These behaviors aren't related, and so the documentation should not imply they are related.

@will-bartlett : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

Flagging for @mmacy to review the PR, also mentioned in Teams chat. Marsh, is there an extra . got that added in the example URL? Just checking. Thanks.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver Thanks, Kristine!


Handle concurrent creation of default GW network

Code is not protected against concurrent joins of overlay network

Signed-off-by: Alessandro Boch<EMAIL_ADDRESS>

LGTM

LGTM


JWT Timeout and refresh

Currently the JWT timeout is the default 5 min and no notification or refresh is enabled.

@syntheticgio


🐛 Skip doesnt work on mobile

Touch only use mouse click, need to also be touch screen

Will create a branch with the fix


ligand[polymer]-protein docking

Appreciate your outstanding work!
I'm trying to dock a ligand composed of multiple monomers with my target protein. I set Molecule Type to 'ligand' and Copies to 10, but the result showed 10 ligands binding to different sites on the protein. Is there a way to dock a polymer with the target protein? Can I input multiple ligands [using SMILES code] in the input box on web server at once ? Also, is there a method to modify the code in my locally deployed project to enable docking of a polymer with the target protein?

Hi Jason,
that's expected behavior: 10 copies = add 10 copies of molecule, no connections assumed.
If you want to add polysaccharide (I guess?), you'll need to unpack its formula for 10 copies. Something like
parts = [f'C{i}C(OC(C(C{i}O)O)O' for i in range(1, 11)]
print(''.join(parts))
# output:
# C1C(OC(C(C1O)O)OC2C(OC(C(C2O)O)OC3C(OC(C(C3O)O)OC4C(OC(C(C4O)O)OC5C(OC(C(C5O)O)OC6C(OC(C(C6O)O)OC7C(OC(C(C7O)O)OC8C(OC(C(C8O)O)OC9C(OC(C(C9O)O)OC10C(OC(C(C10O)O)O

note: above maybe incorrect, just giving the idea. Maybe there are better ways to generate smiles for n copies, or even some instruments - I'm not versed in this, maybe community has ideas/suggestions


XJoy.exe not showing up/not downloading

You need to go to the Releases page and download the zip from there


Update with-styled-component README.md

styled-components v2 is out of beta now.
So, we should remove warning beta message.

duplicate of #2081


factor:logging to list.

Checks

[ ] Your YAML file has required fields as listed in Specs
[ ] All checks have passed yaml-lint passed
[ ] You agree to contribute your work under MIT license

reviewed and achieved


AuthenticationExtension.cs methods not run by SSRS

I have an almost working implementation for forms authentication SSRS.
The only issue is that none of the methods implemented by AuthenticationExtension.cs are getting called by SSRS
I tried to log it using Nlog but the interface functions (and the property) implemented in AuthenticationExtension.cs don't seem to get run by the SSRS !

public class AuthenticationExtension : IAuthenticationExtension2, IExtension
 {
 // .... other stuff

  Logger _logger;

public AuthenticationExtension()
{
   _logger = LogManager.GetCurrentClassLogger();
}

LocalizedName
{
 get
   {
    _logger.Info("LocalizedName");
    return null;
 }
}

public bool LogonUser(string userName, string password, string authority)
{
    _logger.Info("LogonUser");
    return true;
}

public bool IsValidPrincipalName(string principalName)
{
  _logger.Info("IsValidPrincipalName");
  return true;
}

// other stuff
}

NLog logging works perfectly in Login.aspx.cs
But, no NLog logs for these 3 methods!

As per https://github.com/microsoft/Reporting-Services/issues/237#issuecomment-1125958610 comment,
I attached my debugger to the running processes
ReportingServicesService.exe
RSPortal.exe
but the breakpoints set at the beginning of LogonUser(),LocalizedName, IsValidPrincipalName() are still not hit.


Result of tasks

Add the apis for task results

Result.Submit
Result.Listen

fixes #93

Instead of Result.Listen, can we send the result back to Task.Execute? It will be way easier for application to get the result of a task.

Agreed for the id to track which execution I'll add it today, for the result directly from the Task.Execute I'm afraid that this will be too complicated for users with an input stream and an output stream. Also how do we call the Result.Listen function in this case, we cannot say Task.Listen because this is when we have to execute tasks, so if we keep the Result.Listen it kind of makes sense to have the Result.Submit at the same place
What do you think ?

In the system you did, I prefer Result.Listen.

My suggestion doesn't change the Task.Execute api. It's still a simple input, and a simple output. But instead of publishing the task job on the channel and return right after, the core could wait for the result of the task job (with a timeout), and send the result directly to the caller. It is still a 1 to 1 call (1 job -> 1 result). No stream needed.
Because anyway, what application will listen for every Result.Listen? It only want to listen to the result of the job it ask for.
Eg:
Application: execute query Task.Execute -> Core: publish in Task.Listen -> Service: Receive job. Execute job. Post result in Result.Submit -> Core: publish result in response of the first query Task.Execute.
What do you think?

Task.Execute cannot wait for the answer. What happen if it takes the service 10min to process the task, we will have timeouts, we might just open a stream and then when the result is coming from the service publish on the stream and close the stream but then what's the difference with a stream that stays open to listen any kind of results

@NicolasMahe i would love some feedbacks about this one, I'm writing the documentation and I would like to finish this one to have something full functional

I think it is more complicated to have to listen for the result of an task than wait for the response on the same query.
A lot of task with useful result will be fast to execute (eg: get data, generate a new ethereum wallet), but yes, some might take a long time.
The concept of timeout is a really vague on gRPC: https://grpc.io/docs/guides/concepts.html#deadlinestimeouts
It seems it's the client that decide.
After reflexion, we could use a stream with Result.Listen (as you did) and in our app lib, automaticaly listen for the result and return it in the same "promise" as the call. So we have the most generic way in the lowest level, and if we want, do a simpler version in our app lib.
What do you think?

100% agree, for me this is the low level API but sure we can use a lib to reduce the complexity but on the "client side" but the API will still be the same just for exemple in js something like that
const taskX = (inputs, onResult) => doSomeProcessing().then(onResult)

where onResult is a function that will be created already with the id of the task and everything and where you just need to call it with the results and that's it but this is just some help on the client side

What would be the best solution to generate a unique id to identify the task execution ?
At first I thought a random like an UUID but I really don't want to rely on a random, I would like to have a deterministic way to generate this executionID, I think this can be really helpful when we will have the network like that we can detect two similar executions.
Any thoughts about that ?
I was thinking a hash of

request execution time
task name
task data
signature of the core ? this one maybe too much for now

I added a new package to manage the state of the executions basically this package have 3 list :

pending executions
in progress executions
processed executions

With Create, Execute and Complete for every steps with all the time the right notifications to the right pub/sub.
@NicolasMahe ready for review

Nice job on the execution package 👍
I like your idea of a deterministic id for the execution. I'm ok with your list but i will also add the service name.
Also, the gRPC messages contain the parameters task and data with executionID. It's useless in this case, no?
I suggest for api_result.proto:
syntax = "proto3";

package types;

import "service.proto";

service Result {
  // Service
  rpc Submit (SubmitResultRequest) returns (SubmitResultReply) {}

  // Application
  rpc Listen (ListenResultRequest) returns (stream ListenResultReply) {}
}

message SubmitResultRequest {
  string executionID = 1;
  string output = 2;
}

message SubmitResultReply {
  string error = 1;
}

message ListenResultRequest {
  ProtoService service = 1;
}

message ListenResultReply {
  string executionID = 1;
  string output = 2;
}

and for api_task.proto:
syntax = "proto3";

package types;

import "service.proto";

service Task {
  // Service
  rpc Listen (ListenTaskRequest) returns (stream ListenTaskReply) {}

  // Application
  rpc Execute (ExecuteTaskRequest) returns (ExecuteTaskReply) {}
}

message ListenTaskRequest {
  ProtoService service = 1;
}

message ListenTaskReply {
  string executionID = 1;
  string task = 2;
  string data = 3;
}

message ExecuteTaskRequest {
  ProtoService service = 1;
  string task = 2;
  string data = 3;
}

message ExecuteTaskReply {
  string executionID = 1;
  string error = 2;
}

Otherwise, I really doesn't like the organization of the API we are doing. Each gRPC service has 1 endpoint for the application and another for the service. It's super confuse and we have to create so many different client to access only 1 endpoint per client:
cli := types.NewTaskClient(connection)
reply, err := cli.Execute(context.Background(), &args)
...
resultCli := types.NewResultClient(connection)
stream, err := resultCli.Listen(context.Background(), &args)

I was thinking why we just do one big service that group the task and result services?
Something like:
service Task {
  // Service
  rpc Listen (ListenTaskRequest) returns (stream ListenTaskReply) {}
  rpc Submit (SubmitTaskRequest) returns (SubmitTaskReply) {}

  // Application
  rpc Execute (ExecuteTaskRequest) returns (ExecuteTaskReply) {}
  rpc Result (ResultTaskRequest) returns (stream ResultTaskReply) {}
}

We could also organize into 1 gRPC service for the Services, and 1 gRPC service for the Application:
service Task {
  // Service
  rpc Listen (ListenTaskRequest) returns (stream ListenTaskReply) {}
  rpc Submit (SubmitTaskRequest) returns (SubmitTaskReply) {}
}
service Execution {
  // Application
  rpc Execute (ExecuteExecutionRequest) returns (ExecuteExecutionReply) {}
  rpc Listen (ListenExecutionRequest) returns (stream ListenExecutionReply) {}
}

I extracted your comment in the issue https://github.com/mesg-foundation/core/issues/112 like that we can finalize this PR.
I already added the name of the service and I just added the inputs in json too so now this feature should be finish


Fuzzy search

A textbox allowing to create nodes by type, in addition to right-click menu (#154)

A nice pair to #321

Though actually it's not fuzzy yet (or ever), just matches by indexOf.


fix high vulnerabilities in loadash and js-yaml

This PR fixes high vulnerabilities in loadash and js-yaml

Closing this PR.  The changes in this PR have already been made in other PRs.


[SPARK-28346][SQL] clone the query plan between analyzer, optimizer and planner

What changes were proposed in this pull request?
query plan was designed to be immutable, but sometimes we do allow it to carry mutable states, because of the complexity of the SQL system. One example is TreeNodeTag. It's a state of TreeNode and can be carried over during copy and transform. The adaptive execution framework relies on it to link the logical and physical plans.
This leads to a problem: when we get QueryExecution#analyzed, the plan can be changed unexpectedly because it's mutable. I hit a real issue in https://github.com/apache/spark/pull/25107 : I use TreeNodeTag to carry dataset id in logical plans. However, the analyzed plan ends up with many duplicated dataset id tags in different nodes. It turns out that, the optimizer transforms the logical plan and add the tag to more nodes.
For example, the logical plan is SubqueryAlias(Filter(...)), and I expect only the SubqueryAlais has the dataset id tag. However, the optimizer removes SubqueryAlias and carries over the dataset id tag to Filter. When I go back to the analyzed plan, both SubqueryAlias and Filter has the dataset id tag, which breaks my assumption.
Since now query plan is mutable, I think it's better to limit the life cycle of a query plan instance. We can clone the query plan between analyzer, optimizer and planner, so that the life cycle is limited in one stage.
How was this patch tested?
new test

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12639/
Test PASSed.

Test build #107513 has started for PR 25111 at commit 656ae55.

cc @hvanhovell @maryannxue @viirya @gatorsmile @HyukjinKwon

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107513/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12648/
Test PASSed.

Test build #107523 has started for PR 25111 at commit 656ae55.

Test build #107523 has finished for PR 25111 at commit 656ae55.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107523/
Test FAILed.

Test build #107534 has started for PR 25111 at commit 7ab8e49.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12660/
Test PASSed.

Test build #107534 has finished for PR 25111 at commit 7ab8e49.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107534/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12698/
Test PASSed.

Test build #107573 has started for PR 25111 at commit 58ff049.

Test build #107573 has finished for PR 25111 at commit 58ff049.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107573/
Test PASSed.

Test build #107587 has started for PR 25111 at commit 92095b7.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12713/
Test PASSed.

Test build #107587 has finished for PR 25111 at commit 92095b7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107587/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12784/
Test PASSed.

Test build #107657 has started for PR 25111 at commit f614cc6.

Test build #107657 has finished for PR 25111 at commit f614cc6.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107657/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12813/
Test PASSed.

Test build #107686 has started for PR 25111 at commit 5e0ab9a.

Test build #107686 has finished for PR 25111 at commit 5e0ab9a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107686/
Test PASSed.

cc @maryannxue @hvanhovell

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12875/
Test PASSed.

Test build #107753 has started for PR 25111 at commit 6f9b59f.

Test build #107753 has finished for PR 25111 at commit 6f9b59f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107753/
Test PASSed.

The code looks good, but one thing we should be aware of:
clone() actually creates different copies/instances of MultiInstanceRelation objects, while before this change identical relations in a single query always share the same instance. This is what exactly needed by AQE, but would this contradict with any other existing assumptions (e.g., in datasource)?

@maryannxue AFAIK we don't rely on plan instance equality in Spark. AQE is the only one I'm aware of that needs to check plan instance equality.

Thank you, @cloud-fan! LGTM.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13026/
Test PASSed.

Test build #107914 has started for PR 25111 at commit 66f1281.

Test build #107914 has finished for PR 25111 at commit 66f1281.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107914/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13152/
Test PASSed.

Test build #108044 has started for PR 25111 at commit 4f75ba4.

Test build #108044 has finished for PR 25111 at commit 4f75ba4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108044/
Test PASSed.

LGTM
Thanks! Merged to master

@cloud-fan I'm seeing some memory issues because of all these clone calls. I have a big query tree, maybe 20-30 nodes, but all the clone calls are recursive and keep everything in the stack alive: https://gist.github.com/MasterDDT/af98ad20ab0ed301476b9e8c58d8f5bb
In my fork, could I disable all the clone calls if AQE is off? Will that cause any issues?

To @MasterDDT , I'd like to recommend to file an official JIRA issue. Otherwise, it's difficult to get any further discussion or help because this is too old thread.


Single variables are re-calculated whenever they are called

f = sample(normal(5,2))
f - f

In this case, the answer to "f - f" should be 0, but instead it's not. This is because f is a different thing in both cases.
Related,

My impression is that this is not the intended behavior.

Works fine currently: https://www.squiggle-language.com/playground/#code=eNqrVirOyC8PLs3NTSyqVLIqKSpN1QELuaZkluQXwUQy8zJLMhNzggtLM9PTc1KDS4oy89KVrJTSFGwVihNzC3JSNfLyi3ITczRMdYw0NWPyotN0oDBWqRYAX0IjWw%3D%3D


Fix: MultiQC HTML visualisation change

MultiQC HTML visualisation not correct as it is in zip format. Liase with IRIDA core team.

As per conversation on IRIDA Gitter, IRIDA does not seem to have a good way to display compound datatypes. HTML support was added recently in https://github.com/phac-nml/irida/pull/849.
One option is to convert the output to a web page with https://github.com/zTrix/webpage2html and supply a simple HTML.

As noted in this issue https://github.com/phac-nml/irida/issues/1057, the problem comes when Galaxy turns the HTML into a ZIP at download time. If, as the last stage in the workflow, you change the Datatype to txt, then this conversion does not happen. This might be a solution to making the MultiQC output work.


API documentation is a bit behind

document new API calls like get_assets
as well as the new objects types that can be returned (like assets object)

Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

Moved to https://github.com/CounterpartyXCP/Documentation/issues/50


Wrap AERender Process

Wraps the aerender process in a trace to understand which parts are taking a long time.

@evantayloryates yeah I agree it is a bit funky of formatting. The only change is essentially just wrapping the existing function in a trace. IE:


Find files on storage drives other than the primary one

Description of the new feature / enhancement
There is a possibility that the Windows Search search plugin in PowerToys Run can index files from the other storage disks on my PC, that is, it can also find files from disk D, E, F, etc. The closest thing there is now is that it You can navigate through folders to the specific file.
Scenario when this would be used?
When I try to search for files that are on additional disks to the main one, such as drive D, E, F, it could even be with external disks or flash drives from cameras or the cell phone itself. Many times at work we have this situation.
Supporting information
No response

You can open Windows indexing options and add these drives to the search indexer.

/helped

Good contribution, but I already have that configured, the idea would be that this can be done with Powertoys run to use a single search engine


Get release 2.1 ready

@tbaranes please have a look at the descriptions for release 2.1. 👯👯👯

Perfect :100: Go for it! :tada:

@tbaranes  all done, 👏 https://github.com/JakeLin/IBAnimatable/wiki/How-to-develop-an-animator-(animation-controller) also updated. Thanks for your great help.


DCOS-8220: Construct Service URL from ID

Reviewer: @Poltergeist

@MatApple Could you please squash the two service not services commits?

Minor #nits reset looks good.

LGTM except hold merge.

Any update on this one?

@orlandohohmeier My apologies for the delay, I missed your message somehow. We are waiting on this ticket to see why the webui_url key is missing.


[SMASH] "parse error: Invalid numeric literal" instead of "Pool XYZ is delisted" when querying delisted pool

OS
Your OS:
Linux Mint
Versions
The db-sync version (eg cardano-db-sync --version):
tag: 13.0.0-rc1
commit c59164c88b6f7e1d4d389c3f66de2d3157e3c29e
Build/Install Method
nix
Run method

PGPASSFILE=config/pgpass-testnet smash-server/bin/cardano-smash-server --config /nix/store/5b6pry15w93fv0r0x9rc3r1ii5871lvr-config-0-0.json --port 3100 --admins admins.txt

Additional context
N/A
Problem Report
Querying delisted pool (smash v13) returns:
parse error: Invalid numeric literal
instead of:
Pool XYZ is delisted as it was in smash v12.
Steps to reproduce
This was performed on testnet.
a) Query some pool:
curl -X GET -v http://localhost:3100/api/v1/metadata/81e84003f3d2f65315b479dc3cdbe4aa8c8595a3d76818e284b29f27/8e123d238a44a91bab56ebd631020bede5a381d8487a46d1f2ebbdc52e3b3eba | jq .

{
  "name": "OZZIE",
  "ticker": "OZZIE",
  "homepage": "https://ozzieoffsec.github.io/pool",
  "description": "We love Turtles"
}

b) Delist it:
curl --verbose -u username:password --header "Content-Type: application/json" --request PATCH --data '{"poolId":"81e84003f3d2f65315b479dc3cdbe4aa8c8595a3d76818e284b29f27"}' http://localhost:3100/api/v1/delist

{"poolId":"81e84003f3d2f65315b479dc3cdbe4aa8c8595a3d76818e284b29f27"}

testnet=# select * from delisted_pool;
 id |                          hash_raw
----+------------------------------------------------------------
  1 | \x81e84003f3d2f65315b479dc3cdbe4aa8c8595a3d76818e284b29f27
(1 row)

c) Query pool after it was delisted:
Response from curl:

smash v12:

curl -X GET -v http://localhost:3100/api/v1/metadata/81e84003f3d2f65315b479dc3cdbe4aa8c8595a3d76818e284b29f27/8e123d238a44a91bab56ebd631020bede5a381d8487a46d1f2ebbdc52e3b3eba | jq .

Pool 81e84003f3d2f65315b479dc3cdbe4aa8c8595a3d76818e284b29f27 is delisted

smash v13:

parse error: Invalid numeric literal at line 1, column 5

Response from smash-server (for both smash v12 &smash v13):
[smash-server:Warning:40] [2021-11-25 10:02:36.40 UTC] Pool 81e84003f3d2f65315b479dc3cdbe4aa8c8595a3d76818e284b29f27 is delisted

Seems like a json parser error. We had to change aeson revision recently to match the used revision upstream.

@ArturWieczorek I've tried to reproduce this bug using docker containers and haven't managed to. Here is what I've tried
With cardano-db-sync:12.0.2 and cardano-node:1.34.1 in docker-compose.yml and SMASH from tag:12.0.2
RESTORE_SNAPSHOT=https://update-cardano-mainnet.iohk.io/cardano-db-sync/12/db-sync-snapshot-schema-12-block-7107980-x86_64.tgz \
NETWORK=mainnet docker-compose up && docker-compose logs -f

Select a suitable pool to delist:
$ select * from pool_hash join pool_metadata_ref on pool_hash.id = pool_metadata_ref.id;
  id  |                          hash_raw                          |                           view                           |  id  | pool_id |                               url                                |                                hash                                | registered_tx_id
------+------------------------------------------------------------+----------------------------------------------------------+------+---------+------------------------------------------------------------------+--------------------------------------------------------------------+------------------
    2 | \x0f292fcaa02b8b2f9b3c8f9fd8e0bb21abedb692a6d5058df3ef2735 | pool1pu5jlj4q9w9jlxeu370a3c9myx47md5j5m2str0naunn2q3lkdy |    2 |       2 | https://stakenuts.com/mainnet.json                               | \x47c0c68cb57f4a5b4a87bad896fc274678e7aea98e200fa14a1cb40c0cab1d8c |          2415602

Request the Metadata
$ curl --verbose --header "Content-Type: application/json" \
--request GET http://localhost:3100/api/v1/metadata/0f292fcaa02b8b2f9b3c8f9fd8e0bb21abedb692a6d5058df3ef2735/47c0c68cb57f4a5b4a87bad896fc274678e7aea98e200fa14a1cb40c0cab1d8c | jq .
Note: Unnecessary use of -X or --request, GET is already inferred.
*   Trying <IP_ADDRESS>:3100...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0* Connected to localhost (<IP_ADDRESS>) port 3100 (#0)
> GET /api/v1/metadata/0f292fcaa02b8b2f9b3c8f9fd8e0bb21abedb692a6d5058df3ef2735/47c0c68cb57f4a5b4a87bad896fc274678e7aea98e200fa14a1cb40c0cab1d8c HTTP/1.1
> Host: localhost:3100
> User-Agent: curl/7.79.1
> Accept: */*
> Content-Type: application/json
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< Transfer-Encoding: chunked
< Date: Fri, 24 Jun 2022 06:17:17 GMT
< Server: Warp/3.3.17
< Content-Type: application/json;charset=utf-8
< Cache-Control: no-store
<
{ [184 bytes data]
100   171    0   171    0     0   2012      0 --:--:-- --:--:-- --:--:--  2192
* Connection #0 to host localhost left intact
{
  "name": "StakeNuts",
  "description": "StakeNuts.com",
  "ticker": "NUTS",
  "homepage": "https://stakenuts.com/",
  "extended": "https://stakenuts.com/mainnet-extended.json"
}

Delist that pool
$ curl --verbose -u tmcgilchrist:tmcgilchrist --header "Content-Type: application/json" --request PATCH --data '{"poolId": "0f292fcaa02b8b2f9b3c8f9fd8e0bb21abedb692a6d5058df3ef2735"}' http://localhost:3100/api/v1/delist
*   Trying <IP_ADDRESS>:3100...
* Connected to localhost (<IP_ADDRESS>) port 3100 (#0)
* Server auth using Basic with user 'tmcgilchrist'
> PATCH /api/v1/delist HTTP/1.1
> Host: localhost:3100
> Authorization: Basic dG1jZ2lsY2hyaXN0OnRtY2dpbGNocmlzdA==
> User-Agent: curl/7.79.1
> Accept: */*
> Content-Type: application/json
> Content-Length: 70
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< Transfer-Encoding: chunked
< Date: Fri, 24 Jun 2022 06:19:07 GMT
< Server: Warp/3.3.17
< Content-Type: application/json;charset=utf-8
<
* Connection #0 to host localhost left intact
{"poolId":"0f292fcaa02b8b2f9b3c8f9fd8e0bb21abedb692a6d5058df3ef2735"}%

Request Metata again
$ curl --verbose --header "Content-Type: application/json" \
--request GET http://localhost:3100/api/v1/metadata/0f292fcaa02b8b2f9b3c8f9fd8e0bb21abedb692a6d5058df3ef2735/47c0c68cb57f4a5b4a87bad896fc274678e7aea98e200fa14a1cb40c0cab1d8c
Note: Unnecessary use of -X or --request, GET is already inferred.
*   Trying <IP_ADDRESS>:3100...
* Connected to localhost (<IP_ADDRESS>) port 3100 (#0)
> GET /api/v1/metadata/0f292fcaa02b8b2f9b3c8f9fd8e0bb21abedb692a6d5058df3ef2735/47c0c68cb57f4a5b4a87bad896fc274678e7aea98e200fa14a1cb40c0cab1d8c HTTP/1.1
> Host: localhost:3100
> User-Agent: curl/7.79.1
> Accept: */*
> Content-Type: application/json
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 403 Forbidden
< Transfer-Encoding: chunked
< Date: Fri, 24 Jun 2022 06:19:48 GMT
< Server: Warp/3.3.17
<
* Connection #0 to host localhost left intact
Pool 0f292fcaa02b8b2f9b3c8f9fd8e0bb21abedb692a6d5058df3ef2735 is delisted%

Note the response has a content type of application/json but the content is a plain text string and will cause a jq parse error.
With cardano-db-sync:13.0.0-rc1 and cardano-node:1.34.1 in docker-compose.yml and SMASH from tag:13.0.0-rc1
RESTORE_SNAPSHOT=https://update-cardano-mainnet.iohk.io/cardano-db-sync/13/db-sync-snapshot-schema-13-block-6429999-x86_64.tgz \
NETWORK=mainnet docker-compose up && docker-compose logs -f

Find a suitable pool to delist:
$ select * from pool_hash join pool_metadata_ref on pool_hash.id = pool_metadata_ref.id;
  id  |                          hash_raw                          |                           view                           |  id  | pool_id |                               url                                |                                hash                                | registered_tx_id
------+------------------------------------------------------------+----------------------------------------------------------+------+---------+------------------------------------------------------------------+--------------------------------------------------------------------+------------------
    1 | \x153806dbcd134ddee69a8c5204e38ac80448f62342f8c23cfe4b7edf | pool1z5uqdk7dzdxaae5633fqfcu2eqzy3a3rgtuvy087fdld7yws0xt |    1 |       1 | https://raw.githubusercontent.com/Octalus/cardano/master/p.json  | \xca7d12decf886e31f5226b5946c62edc81a7e40af95ce7cd6465122e309d5626 |          2415556

Request the Metadata
curl --verbose --header "Content-Type: application/json" \
  --request GET http://localhost:3100/api/v1/metadata/153806dbcd134ddee69a8c5204e38ac80448f62342f8c23cfe4b7edf/ca7d12decf886e31f5226b5946c62edc81a7e40af95ce7cd6465122e309d5626 | jq .

{
  "name": "OctasPool",
  "description": "Octa's Performance Pool",
  "ticker": "OCTAS",
  "homepage": "https://octaluso.dyndns.org",
  "extended": "https://raw.githubusercontent.com/Octalus/cardano/master/pe.json"
}

Delist that pool
$ curl --verbose -u tmcgilchrist:tmcgilchrist --header "Content-Type: application/json" --request PATCH --data '{"poolId": "153806dbcd134ddee69a8c5204e38ac80448f62342f8c23cfe4b7edf"}' http://localhost:3100/api/v1/delist
*   Trying <IP_ADDRESS>:3100...
* Connected to localhost (<IP_ADDRESS>) port 3100 (#0)
* Server auth using Basic with user 'tmcgilchrist'
> PATCH /api/v1/delist HTTP/1.1
> Host: localhost:3100
> Authorization: Basic dG1jZ2lsY2hyaXN0OnRtY2dpbGNocmlzdA==
> User-Agent: curl/7.79.1
> Accept: */*
> Content-Type: application/json
> Content-Length: 70
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< Transfer-Encoding: chunked
< Date: Fri, 24 Jun 2022 08:16:01 GMT
< Server: Warp/3.3.17
< Content-Type: application/json;charset=utf-8
<
* Connection #0 to host localhost left intact
{"poolId":"153806dbcd134ddee69a8c5204e38ac80448f62342f8c23cfe4b7edf"}%

Request Metata again
$ curl --verbose --header "Content-Type: application/json"   --request GET http://localhost:3100/api/v1/metadata/153806dbcd134ddee69a8c5204e38ac80448f62342f8c23cfe4b7edf/ca7d12decf886e31f5226b5946c62edc81a7e40af95ce7cd6465122e309d5626
Note: Unnecessary use of -X or --request, GET is already inferred.
*   Trying <IP_ADDRESS>:3100...
* Connected to localhost (<IP_ADDRESS>) port 3100 (#0)
> GET /api/v1/metadata/153806dbcd134ddee69a8c5204e38ac80448f62342f8c23cfe4b7edf/ca7d12decf886e31f5226b5946c62edc81a7e40af95ce7cd6465122e309d5626 HTTP/1.1
> Host: localhost:3100
> User-Agent: curl/7.79.1
> Accept: */*
> Content-Type: application/json
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 403 Forbidden
< Transfer-Encoding: chunked
< Date: Fri, 24 Jun 2022 08:16:40 GMT
< Server: Warp/3.3.17
<
* Connection #0 to host localhost left intact
Pool 153806dbcd134ddee69a8c5204e38ac80448f62342f8c23cfe4b7edf is delisted%

Note the response again has a content-type of application/json but returns a plain text response that will also cause a jq parse error.
If you're able to reproduce the smash v12 issue, could you please attach the docker images used or the specific git shas used. Many thanks.

Thanks for info @tmcgilchrist. I will get back to this once I am done with testing RC4 for db-sync (should be this week).

@tmcgilchrist Sorry, my bad - it looks like this issue was also present in v12, so it is not a new problem. I did not pipe the query result to jq for v12 and that's why I could see response (but it was in plain text) and I assumed it's OK.

@ArturWieczorek I went back and had a look at the previous version of SMASH (1.6.1) before it got merged into cardano-db-sync repo. The code returns a 403 when the pool is delisted https://github.com/input-output-hk/smash/blob/1.6.1/smash/src/Cardano/SMASH/Lib.hs#L244-L249
It doesn't seem to have returned a valid JSON response in any of the old versions of SMASH.
As a resolution to this issue I would suggest the behaviour is left as is, none of the other error responses have their messages returned as JSON objects and this case is consistent with how SMASH is returning other errors as Content-Type: application/json even if that is incorrect. cc @erikd are you happy with this resolution?

Based on the provided information, it seems that the issue has been addressed. We're closing this issue now. If you have any more concerns or if the problem reappears, please let us know by reopening this issue. We appreciate your help!


Merge pull request #3430 from WalterBright/rangestrip

Range-ify std.string.strip and stripRight()

We don't wanna release a rangified stripLeft w/o strip and stripRight.

See https://github.com/D-Programming-Language/phobos/pull/3430#issuecomment-129222441.


cannot pass image geolocation file (geo.txt) into project

very likely an ignorant question here... but when using pyodm, I am unable to pass or have odm recognize an image geolocation file (geo.txt). This works using the normal webodm and CLI approaches as long as I have it in the root of my project folder, but cannot resolve this with pyodm. When creating a task I used the --geo argument passing the geo.txt absolute path with no success either.
Any help would be much appreciated!
import glob
import os
from pyodm import Node, exceptions

node = Node("localhost", 3000)
try:
    # Get all JPG files in directory
    files = glob.glob("*.JPG") + glob.glob("*.jpg") + glob.glob("*.JPEG") + glob.glob("*.jpeg") + glob.glob("*.txt")
    geolist = glob.glob("*geo.txt")

    print("Uploading images...")
    task = node.create_task(files, {'orthophoto-resolution': 15, 'ignore-gsd': True, 'gps-accuracy': 0.05, 'use-hybrid-bundle-adjustment': True, 'fast-orthophoto': True, 'skip-3dmodel': True, 'time': True, 'geo': geolist})
    print(task.info())

    try:
        def print_status(task_info):
            msecs = task_info.processing_time
            seconds = int((msecs / 1000) % 60)
            minutes = int((msecs / (1000 * 60)) % 60)
            hours = int((msecs / (1000 * 60 * 60)) % 24)
            print("Task is running: %02d:%02d:%02d" % (hours, minutes, seconds), end="\r")
        task.wait_for_completion(status_callback=print_status)

        print("Task completed, downloading results...")

        # Retrieve results
        def print_download(progress):
            print("Download: %s%%" % progress, end="\r")
        task.download_assets(outputdir, progress_callback=print_download)
        print("Assets saved in output/results directory")
    except exceptions.TaskFailedError as e:
        print("\n".join(task.output()))
except exceptions.NodeConnectionError as e:
    print("Cannot connect: %s" % e)
except exceptions.OdmError as e:
    print("Error: %s" % e)

Could we move this conversation over to the forum at https://community.opendronemap.org? :pray: The forum is the right place to ask questions (we try to keep the GitHub issue tracker for feature requests and bugs only). Thank you! :+1:

Could we move this conversation over to the forum at https://community.opendronemap.org? :pray: The forum is the right place to ask questions (we try to keep the GitHub issue tracker for feature requests and bugs only). Thank you! :+1:

yes of course, my apologies!

yes of course, my apologies!

No worries, thank you for helping us keep the issue tracker orderly.

No worries, thank you for helping us keep the issue tracker orderly.

Reopening: https://community.opendronemap.org/t/cannot-pass-image-geolocation-file-geo-txt-into-project/6368/7?u=smathermather-cm

Reopening: https://community.opendronemap.org/t/cannot-pass-image-geolocation-file-geo-txt-into-project/6368/7?u=smathermather-cm

Fixed with NodeODM#140. :+1:

Fixed with NodeODM#140. :+1:


Feature Request: Tenant-Specific Subscription Management

Summary:
As a user managing multiple Azure subscriptions on behalf of various customers, I would like the ability to view and organize subscriptions by Tenant in my portfolio. This would significantly improve usability when dealing with a large number of subscriptions.
Description:
I manage numerous Azure subscriptions across multiple tenants. It would be highly beneficial to have the option to display the Tenant in its own column within the subscription management interface. Ideally, subscriptions could also be grouped by Tenant, allowing for more efficient navigation and management.
In an ideal scenario, I envision a workflow where I can first select a Tenant and then choose from the associated subscriptions. This hierarchical selection process would streamline the management experience, particularly for users handling a large number of subscriptions.
Considerations:
•	The ability to view subscriptions grouped by Tenant might not be relevant to all users, so it could be offered as an optional feature.
•	Implementing a “Select Tenant -> Select Subscription” workflow could significantly enhance the user experience for those managing multiple tenants.

Conclusion:
This feature would greatly enhance the management of multiple Azure subscriptions by simplifying navigation and improving the organization. The current product is already excellent, and this enhancement would make it even better.

I really like this idea! 👍
I'm thinking about how best to implement this, few ideas;

Run aztx --by-tenant or something like this and then start the program by selecting the tenant first as you've proposed
Start the program normally with an additional column indicating the parent tenant (this could also be configurable to show/hide)
Start the program normally and have a hotkey to filter by tenant and then, once selected, filter by subscription

Something else to consider is that this program manipulates the config file in $HOME/.azure/azureProfile.json and something that I've noticed, at least in my case, is that I have access to a couple of Azure environments and one is quite locked down so I can't see the tenantDisplayName field. I've sanitised the contents but take a look at this...

azureProfile.json snippet
{
  "subscriptions": [
    {
      "id": "11111111-1111-1111-1111-111111111111",
      "name": "N/A(tenant level account)",
      "state": "Enabled",
      "user": { "name"<EMAIL_ADDRESS>"type": "user" },
      "isDefault": false,
      "tenantId": "11111111-1111-1111-1111-111111111111",
      "environmentName": "AzureCloud"
    },
    {
      "id": "22222222-2222-2222-2222-222222222222",
      "name": "N/A(tenant level account)",
      "state": "Enabled",
      "user": { "name"<EMAIL_ADDRESS>"type": "user" },
      "isDefault": false,
      "tenantId": "22222222-2222-2222-2222-222222222222",
      "environmentName": "AzureCloud"
    },
    {
      "id": "33333333-3333-3333-3333-333333333333",
      "name": "User2 MSDN",
      "state": "Enabled",
      "user": { "name"<EMAIL_ADDRESS>"type": "user" },
      "isDefault": true,
      "tenantId": "44444444-4444-4444-4444-444444444444",
      "environmentName": "AzureCloud",
      "homeTenantId": "44444444-4444-4444-4444-444444444444",
      "tenantDefaultDomain": "company.com",
      "tenantDisplayName": "CompanyName",
      "managedByTenants": []
    }
  ],
  "installationId": "55555555-5555-5555-5555-555555555555"
}

As you can see in the first 2 subscriptions the tenantDisplayName field is missing we'd need consider whether to present the tenantId UUID field in the tenant selector (which obviously isn't very friendly or readable) or just group all the subscriptions together that don't have a tenantDisplayName field for better usability.
Would be keen to get your thoughts!

I Can see that in my case, not a single instance of the variable tenantDisaplyName even exists. making it either a "Group only" or the need for the user to create a custom map of tenantID > tenantDisplayName. perferably though i would personally like to not use parameters when i launch the application myself.

Interesting idea...so maybe a hotkey combo like Ctrl + N that lets you nickname the IDs?

That could work, but at this point, i think we need to go towards a ".config" file to store this outside memory right ?

Seems valid.


Generator improvements

The failure in the integration tests is irrelevant to the PR and has to do with issues in quarkus-kubernetes.


Modify LSFEnvironment to use more reliable environment variable

The environment variable LSB_HOSTS was being used to determine node rank and master address. This is not always populated. This PR updates LSFEnvironment to use LSB_DJOB_RANKFILE instead.
Fix #10216

Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

LGTM ! Great contribution!
@ajtritt I wonder if we could disclose Pytorch Lightning is running on the Summit Cluster using the LSFCluster environment? If yes, would you be interested to work on a shared blogpost to better explain how LSF cluster env works ?

@tchaton I don't think that would be a problem. @proutrc do you think that would be okay?

LGTM ! Great contribution!
@ajtritt I wonder if we could disclose Pytorch Lightning is running on the Summit Cluster using the LSFCluster environment? If yes, would you be interested to work on a shared blogpost to better explain how LSF cluster env works ?

@tchaton I don't think that would be a problem. @proutrc do you think that would be okay?

@tchaton @ajtritt I think that idea is perfectly fine

Hey @ajtritt @proutrc,
I create this Google Doc to keep track of it. Please, ask for permission. I would be pretty keen if you could help us write some content there once this PR is merged.

@tchaton I will talk to the folks here at OLCF today, to confirm permission. Certainly happy to help with content.

@proutrc @ajtritt @tchaton @awaelchli @carmocca, thank you all for your diligent work getting these LSF environment changes integrated for Summit. As @proutrc is already aware, Summit & Lightning users such as myself will certainly appreciate the ability to scale our training jobs to more than 72 concurrent GPUs!

@proutrc @ajtritt @tchaton @awaelchli @carmocca, thank you all for your diligent work getting these LSF environment changes integrated for Summit. As @proutrc is already aware, Summit & Lightning users such as myself will certainly appreciate the ability to scale our training jobs to more than 72 concurrent GPUs!

On this topic - @tchaton , @amorehead might be another good source for content in the blog post.

@proutrc I would be happy to help write this blog post in any way I can 🤓

Out of curiosity, which release branch for Lightning are these changes expected to be released? 1.5.9?

Hello
Yes, I will try to include the fix in 1.5.9 #11421. You can also install directly from master go get this feature/fix.


Added argument to AuthenticationSuccessHandler to stop token from being removed from response

Fixes #909 (the handler cannot be used when API and form login are used in the same application).
To use this feature, define the handler as success handler on the firewall
security:
  firewalls:
    main:
      json_login:
         check_path: my_login_check
         success_handler: lexik_jwt_authentication.handler.authentication_success
         failure_handler: lexik_jwt_authentication.handler.authentication_failure

And then define the fourth argument of the handler in your service.yaml:
services:
    Lexik\Bundle\JWTAuthenticationBundle\Security\Http\Authentication\AuthenticationSuccessHandler:
        arguments:
            $removeTokenFromBodyWhenCookiesUsed: false

Thank you @naitsirch.

I was looking for a way to return the JWT token in both cookies and the response body. I spent an hour looking for this solution, and only found it because of the property name I found when I started looking at the code to see where I could extend it to allow this. So I thought I would also leave some searchable terms in this issue so other people can find it a bit quicker :-)
Thank you for the work!
Quick update, I had to use the following service config for this to work:
Lexik\Bundle\JWTAuthenticationBundle\Security\Http\Authentication\AuthenticationSuccessHandler:
     arguments:
         $removeTokenFromBodyWhenCookiesUsed: false

lexik_jwt_authentication.handler.authentication_success:
     alias: Lexik\Bundle\JWTAuthenticationBundle\Security\Http\Authentication\AuthenticationSuccessHandler

I would welcome a PR to document this :)

I can't seem to get it to work with the service configuration as mentioned in the starting post. The container creates a second service definition for the AuthenticationSuccessHandler without the cookie providers. This service definition is not used because the bundle aliases the class. I tried aliasing the definition, hoping the cookie providers would be set later on.
I currently have it working by adding a new config value 'remove_token_from_body_when_cookies_used' which defaults to true. I have added the fourth argument to the service definition, defaulting to true. And a check in the LexikJWTAuthenticationExtension replacing the fourth parameter with false if the new config value is false.
If this approach is OK I can start a pull request for https://github.com/TjorvenB/LexikJWTAuthenticationBundle/tree/pr912 (with documentation)
I started from 2.x. Is this the correct branch to start from? There is also a 2.10.x branch.

I can't seem to get it to work with the service configuration as mentioned in the starting post. The container creates a second service definition for the AuthenticationSuccessHandler without the cookie providers. This service definition is not used because the bundle aliases the class. I tried aliasing the definition, hoping the cookie providers would be set later on.
I currently have it working by adding a new config value 'remove_token_from_body_when_cookies_used' which defaults to true. I have added the fourth argument to the service definition, defaulting to true. And a check in the LexikJWTAuthenticationExtension replacing the fourth parameter with false if the new config value is false. If this approach is OK I can start a pull request for https://github.com/TjorvenB/LexikJWTAuthenticationBundle/tree/pr912 (with documentation)
I started from 2.x. Is this the correct branch to start from? There is also a 2.10.x branch.

I think 2.x is fine.


Softmax warning using PyTorch backend

Running a transcription on my 2020 Macbook Air M1 with KERAS_BACKEND=torch, the following warning is printed to stderr, although transcription proceeds flawlessly (Thanks!)
/Users/<USER>/Desktop/moonshine_live/.venv/lib/python3.11/site-packages/keras/src/ops/nn.py:545:
UserWarning: You are using a softmax over axis 3 of a tensor of shape
torch.Size([1, 8, 1, 1]). This axis has size 1. The softmax operation will always
return the value 1, which is likely not what you intended.
Did you mean to use a sigmoid instead?

For the first token in the decoding loop, the attention score matrix's shape is 1x1, and that triggers the warning you point to. It's benign and you can ignore it. Or run with python -W ignore to make python not print them out. Closing, as there are no actionable followups.

I suggest adding this to the documentation as people will keep searching and finding this issue and reporting it.


Refined UI components and implemented user profile icon in the nav bar

Updated NavigationBar component: • Improved animation and blur effects for navigation links

• Added color extraction from user profile image
• Increased size of navigation bar for improved readability and ease of access
Implemented User Profile Icon:
• Designed and implemented a default user profile image to appear when a user isn't signed in, or their's hasn't been fetched yet • Implemented and centered in nav bar
• Used https://toolbox.signalsupply.co/apps/gradientblobcss/ to create a gradient blob to appear behind the user profile icon • Animated blob to subtly move behind the user profile icon

Also added Norwester font (norwester.regular.otf) to: juke/jukeos/src/fonts/


Open All In Tabs opens "root page"

Add-on version
Add-on version: 1.14
Describe the bug
"Open All In Tabs" opens the referencing page, not just the individual RSS items. It should only open the RSS items.
To Reproduce
Steps to reproduce the behavior:

Add a live bookmark to the bookmark toolbar (with your bookmark toolbar enabled)
Click on the live bookmark.
Scroll down to "Open All In Tabs"
See that the main page is opened along with the individual bookmarks.

Expected behavior
I would rather have NO "main page" listed than see it open with all of the bookmarks. "Open All In Tabs" should only open the RSS links. This is the behavior that Live Bookmarks previously had in Firefox, and is the only reason I was still using Firefox at all, to be honest.
Extra context
Any extra context you may have about the bug (feed URLs, screenshots, etc.)

@TimMensch The "Open All In Tabs" menu is provided by Firefox. If you don't want it to open the referencing page, you can go to the add-on settings, then clear the "Site URL" for the feed in question.

Awesome, that works. Didn't know that was optional. Maybe the fix is to add "(Optional)" to that field? And maybe some additional docs that show up after you do an import and that explain how to get rid of the site URL if you don't want it -- or the ability to auto-clear that on import would be really nice. I "only" had six feeds, so it wasn't terrible to go in to all of them, but for someone who had a lot more feeds it could get quite onerous.
It was filled in for all of my imported RSS links, which was really annoying, and I didn't realize that the option was even there, much less that I needed to dig for it and remove it for each imported feed.


update badges

I don't like the different badge sizes and styles. I like these flat Icons that shields.io provides.
If you don't like the flat-squared style, there are different styles available: http://shields.io/#styles.
Additionally the SLInsight badge isn't HiDPI rdy too.

Here you can see the result of my changes, for better comparison:

What do you guys think?

Much better, thanks Manuel!


Fixing a typo in 'com.google.fonts/check/unitsperem_strict'

Description
This pull request fixes a small typo in the rationale text for 'com.google.fonts/check/unitsperem_strict' check
"1000 UPM is too small"
To Do

[ ] update CHANGELOG.md
[x] wait for checks to pass (except github/pages, which is stuck)
[X] request a review

We typically add a line to CHANGELOG.md describing the code change. This is too simple, so we will not do so this time.
Thanks for the PR, @vv-monsalve :-D


No module named 'src'

Hi and thank you for your great work ! I have a problem running the code with Windows 10 and git bash though, when I do :
./scripts/na_train.sh 0 DAGNN
In the DAGNN repository, I get the following error :
Traceback (most recent call last):
File "train.py", line 7, in
from util import *
File "C:\Users\mat\Documents\Thèse\graphemb\DAGNN\dvae\util.py", line 20, in
from src.utils_dag import add_order_info
ModuleNotFoundError: No module named 'src'
Maybe I am doing something wrong but I can't figure out what

I solved a similiar error by adding the src folder to the sys path, like:
import sys
sys.path.append('/path_to_repo/DAGNN/src')
from utils_dag import add_order_info


About finetuning a DINO model you provided on my custom dataset

I want to finetune a DINO with swin-b you provided in Model Zoo on my custom dataset, but it shows that the number of categories does not match.

I guess this is because I didn't change the number of categories. Can you tell me where to change it? Or are there some parameters I need to ignore when loading the model? Where to change them if I need to? THX!

I want to finetune a DINO with swin-b you provided in Model Zoo on my custom dataset, but it shows that the number of categories does not match.  I guess this is because I didn't change the number of categories. Can you tell me where to change it? Or are there some parameters I need to ignore when loading the model? Where to change them if I need to? THX!

You should check your config and modify the classes num in the config file

I add model.num_classes to the config. It works. THX!

How to finetue on custom dataset using the pretrained ckpt? where is the script?


Implement Lazy Picking

This will implement a modification to our InputManager so that pickingInfo will only be generated when the user requests it.  Furthermore, any camera input classes will be modified to use the DeviceSourceManager directly so that scene.onPointerObservable can only be used for picking and user observers.

Task completed with:
https://github.com/BabylonJS/Babylon.js/pull/13145
https://github.com/BabylonJS/Babylon.js/pull/13044


Improvements related to DensfJob

Fixed an issue where DensfJob was not exposed at the tcutility.job level.
Fixed an issue where paths to spin-unrestricted cube-files were not correctly generated.
Fixed an issue where paths to cube-files did not contain the rigth orbital numbering for non NOSYM orbitals.

How does this work with pyfmo? I don't see pyfmo in the dependencies (pyproject.toml) so how does it know what to import?

It imports pyfmo in the DensfJob.orbital method. I think it might be a good idea to decouple pyfmo from tcutility. We could replace it with DensfJob.SFO and DensfJob.MO methods that allow the user to set the orbitals by setting the spin, symlabel and index manually. Pyfmo can then have a method for setting up a DensfJob for a given MO or SFO.


Why use Function.bind.call in polyfill?

Why do you use Function.bind.call(Function.call, Array.prototype.concat) instead of Array.prototype.concat?
It works the same but looks a little bit confused:
Function.bind.call(Function.call, Array.prototype.concat)([1,2,3,4], [1,2,3,4], [1,2,3,4])
[1, 2, 3, 4, 1, 2, 3, 4, 1, 2, 3, 4]
Array.prototype.concat([1,2,3,4], [1,2,3,4], [1,2,3,4])
[1, 2, 3, 4, 1, 2, 3, 4, 1, 2, 3, 4]

Because somebody might later delete Array.prototype.concat (or replace it with some other function), and your version would break in that case - mine would not.


ValueError: Unknown initializer: EfficientConv2DKernelInitializer

I trained the model on my custom dataset, and now when I am trying to import the .h5 file, it is throwing me this error

model = load_model('model/model_weights_efficient.h5')
Traceback (most recent call last):
File "", line 1, in
File "/home/eleven/ccd/tf12/lib/python3.6/site-packages/tensorflow/python/keras/saving/save.py", line 146, in load_model
return hdf5_format.load_model_from_hdf5(filepath, custom_objects, compile)
File "/home/eleven/ccd/tf12/lib/python3.6/site-packages/tensorflow/python/keras/saving/hdf5_format.py", line 212, in load_model_from_hdf5
custom_objects=custom_objects)
File "/home/eleven/ccd/tf12/lib/python3.6/site-packages/tensorflow/python/keras/saving/model_config.py", line 55, in model_from_config
return deserialize(config, custom_objects=custom_objects)
File "/home/eleven/ccd/tf12/lib/python3.6/site-packages/tensorflow/python/keras/layers/serialization.py", line 89, in deserialize
printable_module_name='layer')
File "/home/eleven/ccd/tf12/lib/python3.6/site-packages/tensorflow/python/keras/utils/generic_utils.py", line 192, in deserialize_keras_object
list(custom_objects.items())))
File "/home/eleven/ccd/tf12/lib/python3.6/site-packages/tensorflow/python/keras/engine/network.py", line 1121, in from_config
process_layer(layer_data)
File "/home/eleven/ccd/tf12/lib/python3.6/site-packages/tensorflow/python/keras/engine/network.py", line 1105, in process_layer
layer = deserialize_layer(layer_data, custom_objects=custom_objects)
File "/home/eleven/ccd/tf12/lib/python3.6/site-packages/tensorflow/python/keras/layers/serialization.py", line 89, in deserialize
printable_module_name='layer')
File "/home/eleven/ccd/tf12/lib/python3.6/site-packages/tensorflow/python/keras/utils/generic_utils.py", line 194, in deserialize_keras_object
return cls.from_config(cls_config)
File "/home/eleven/ccd/tf12/lib/python3.6/site-packages/tensorflow/python/keras/engine/base_layer.py", line 446, in from_config
return cls(**config)
File "/home/eleven/ccd/tf12/lib/python3.6/site-packages/tensorflow/python/keras/layers/convolutional.py", line 477, in init
kernel_initializer=initializers.get(kernel_initializer),
File "/home/eleven/ccd/tf12/lib/python3.6/site-packages/tensorflow/python/keras/initializers.py", line 194, in get
return deserialize(identifier)
File "/home/eleven/ccd/tf12/lib/python3.6/site-packages/tensorflow/python/keras/initializers.py", line 186, in deserialize
printable_module_name='initializer')
File "/home/eleven/ccd/tf12/lib/python3.6/site-packages/tensorflow/python/keras/utils/generic_utils.py", line 181, in deserialize_keras_object
config, module_objects, custom_objects, printable_module_name)
File "/home/eleven/ccd/tf12/lib/python3.6/site-packages/tensorflow/python/keras/utils/generic_utils.py", line 166, in class_and_config_for_serialized_keras_object
raise ValueError('Unknown ' + printable_module_name + ': ' + class_name)
ValueError: Unknown initializer: EfficientConv2DKernelInitializer

Any way around?

Read previous issues, duplicate.

I followed Issue 44, but it's the same error again.

Read previous issues, duplicate.

Well, sources?


bug: Fixed spelling of resource.

Codecov Report

Merging #68 (c6e74ac) into main (b3a867a) will decrease coverage by 13.95%.
The diff coverage is 100.00%.

:exclamation: Current head c6e74ac differs from pull request most recent head 3614925. Consider uploading reports for the commit 3614925 to get more accurate results

@@             Coverage Diff             @@
##             main      #68       +/-   ##
===========================================
- Coverage   80.54%   66.59%   -13.96%
===========================================
  Files          25       31        +6
  Lines         293      440      +147
  Branches       12       17        +5
===========================================
+ Hits          236      293       +57
- Misses         51      142       +91
+ Partials        6        5        -1

Impacted Files
Coverage Δ

...tionTests.Core/TestCommon/WebApi/WebApiTestBase.cs
100.00% <100.00%> (ø)

source/dotnet/WebApi/Startup.cs
94.59% <100.00%> (+1.73%)
:arrow_up:

...ntListener/MeteringPointCreatedListenerEndpoint.cs
0.00% <0.00%> (ø)

...stener/Factories/MeteringPointCreatedDtoFactory.cs
92.85% <0.00%> (ø)

...rationEventListener/Monitor/HealthCheckEndpoint.cs
0.00% <0.00%> (ø)

...gPointCreated/MeteringPointCreatedInboundMapper.cs
0.00% <0.00%> (ø)

source/dotnet/IntegrationEventListener/Program.cs
0.00% <0.00%> (ø)

...ntegrationEventListener/MeteringPointCreatedDto.cs
100.00% <0.00%> (ø)

source/dotnet/Domain/BatchAggregate/Batch.cs
100.00% <0.00%> (+12.50%)
:arrow_up:

...ce/dotnet/Domain/GridAreaAggregate/GridAreaCode.cs
100.00% <0.00%> (+28.57%)
:arrow_up:

... and 2 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


There are some problems with the accuracy of the model

Which Algorithm
Size Search Space
Cifar 10
Describe the Question
I get all 32768 architecture candidates‘ acc using the code followed, but all of them in under 90%.
The results in your paper of all method is above 90%. How can I get the result of table 4 in your paper?
from nats_bench import create
model_cifar10_rank = {}
api = create(None, 'sss')
for index in range(32768):
info = api.get_more_info(index, 'cifar10')
config = api.get_net_config(index, 'cifar10')
model_cifar10_rank[config['channels']] = info['test-accuracy']
models_cifar10_acc_rank 2.txt

@Littleyezi hp=12 is used during searching to obtain the validation accuracy. hp=200 is used to report the final performance of the searched architecture.
After search, it is not suggested to call simulate_train_eval.


Update network-endpoints.md

Added commercial endpoints end of the document. Added dRPC to the list which is decentralizd node provider for Aurora supporting its blockchain developers.

Hey guys, any chance of this getting deployd?


Derive attribute that specializes a user-provided function that gets to modify Arg

 Issue by marjakm
Thursday Nov 04, 2021 at 21:24 GMT
Originally opened as https://github.com/clap-rs/clap/issues/2991

Please complete the following tasks

[X] I have searched the discussions
[X] I have searched the existing issues

Clap Version
master  879dd23963f6ed968535d6ed7bc6f192f02a0a16
Describe your use case
I have a bunch of messages defined in protobuf, I'd like to make a CLI to send those messages - clap should be able to parse the messages from terminal. I generate rust structs from protobuf definitions using prost and I can automatically add clap_derive attributes, but I can't specify the attributes flexibly enough to solve my use-case.
Problematic cases are when one struct contains another optional struct:
struct A {
   simple: u32,
   inner: Option<B>
}

struct B {
   a: u32,
   b: String,
}

When automatically adding attributes, I can differentiate between protobuf native (u32, bool, ..) types and complex types (another struct), but I don't know if the complex type is Option<B> or Option<C>.
What I want is to parse these complex types (for example A::inner) from from json string from the command line. The default value in this case should be None (empty string), which is simple enough to implement currently. But, I'd also like to generate an example json value for the Some case in the CLI help. But what annotation can I add to the field A::inner, where I only know that its a optional struct, but don't know which struct type (B or C) it actually is?
Its really easy for me to write a function to generate the string:
fn example_json<T: serde::Serialize>(t: T) -> &'static str { todo!() }

All I'd need to have some attribute in clap_derive to call that function and I don't need to know which type is A::inner
#[derive(clap::Parser)]
struct A {
   simple: u32,
   #[clap(about = example_json]
   inner: Option<B>
}

which should call something like this in the right place:
Arg::about(arg, example_json::<Option<B>>())

default_value_t attribute actually does exactly the type-based fn specialization - I'd just like to be able to provide the generic fn and have it specialized by the field type.
Describe the solution you'd like
I implemented something that would solve my problems here:
https://github.com/clap-rs/clap/pull/2990
Alternatives, if applicable
No response
Additional Context
Conversation started on #2813

 Comment by epage
Thursday Nov 04, 2021 at 21:39 GMT

Thank you! This context helps a lot!
So you are wanting to determine the value for an attribute based on the type of the field it is applied to, with the example being given of dynamically generating about, instead of manually doing it, to help with your code-gen use case.
This seems quite specialized.  The first question to answer is if this is needed and then the second is how.
A key part stuck out in your comment

I don't know if the complex type is Option<B> or Option<C>.

This is what is leading you to wanting to defer to clap to generate this information.  Could you help me understand this problem a little more?  I'm wanting to learn more about how this clap struct generation is happening to see how all of this fits together and if there is a better, more general solution here.
If we do move forward with this,  clap::Arg::modify_fn  doesn't quite make sense on its own, only in the context of clap_derive.  I wonder if we can instead do this purely within clap_derive.
Its also unclear how https://github.com/clap-rs/clap/issues/2683 might impact any API design on clap in the future.


FIX unmount component

added lookup recursive 'el' checking.

Good one, as usual – thanks! 😎👍

Published in v3.1.0!


[all plugins] Create necessary indexes on each source database as well as goal database

Create necessary indexes on each source database to improve the speed of some queries.

@fedevergara for goal database indexes, here is an example:
https://github.com/colav/Kahi_plugins/blob/b9d5305d07378928fa81e05e787ec771ce851c15/Kahi_scienti_works/kahi_scienti_works/Kahi_scienti_works.py#L465C8-L465C8
Similarly, there should be a set of indexes for the source database.
These indexes are contextual to the ETL process. You must understand the queries on both the goal and the source database to determine the necessary indexes.


Add Pending block watcher in tree

Describe the feature
Currently, to fetch the pending block we need to go through the Blockchain tree:
https://github.com/paradigmxyz/reth/blob/fd12aba49c86d1d0da142f1efb2a8fd8b3e20c59/crates/blockchain-tree/src/blockchain_tree.rs#L230-L234
this tracks the pending block received from the CL:
https://github.com/paradigmxyz/reth/blob/fd12aba49c86d1d0da142f1efb2a8fd8b3e20c59/crates/blockchain-tree/src/block_indices.rs#L78-L86
we should make this available via shared state, ideally tokio::sync::Watch<Option<SealedBlock>
In order to do this we need to track two things:

when we insert a new block into the tree, check if it's the pending block (parent_hash == canonical tip), and update the block in the watcher
when we make a chain canonical: check if we can update the tracked pending block as well: https://github.com/paradigmxyz/reth/blob/fd12aba49c86d1d0da142f1efb2a8fd8b3e20c59/crates/blockchain-tree/src/blockchain_tree.rs#L1133-L1134

Additional context
No response

Can I take this one?

that'd be great!
assigned, lmk if you need some pointers/questions
can also dm on tg @mattsse

ref #6108
@Quertyy do you have the bandwidth to work on this? do you need any pointers?

ref #6108
@Quertyy do you have the bandwidth to work on this? do you need any pointers?

Yes, no worries about bandwidth
I don't mind some pointers, I've already been able to understand the code base a little better

Hi @Quertyy are you still working on this? If you don't have bandwidth I am happy to take it! 🙏

Hi @Quertyy are you still working on this? If you don't have bandwidth I am happy to take it! 🙏

Hey, I should open a first draft before end of week :)

@Quertyy any progress here?
if you don't have the bandwidth that's okay. This is now a blocker and I'd like to move forward with this

@Quertyy any progress here?
if you don't have the bandwidth that's okay. This is now a blocker and I'd like to move forward with this

Hey, sorry but I can't get anything working and I have a lack of free time. Sorry for the lost time, it would be my pleasure to help on a feature more affordable for me 🫡

hey @Quertyy, no worries! ty for trying.
we have a few more good first issues, if none of those are interesting to you, please let me know and we'll figure something out

#6286  is also related to this issue here

I will give it a try this weekend.


Update development.md

OPS Build status updates of commit 0db21df:
:clock10: Preparing: average preparing time is 50 sec(s)

OPS Build status updates of commit 0db21df:
:clock10: Incremental building: average incremental building time is 25 sec(s)

OPS Build status updates of commit 0db21df:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/development.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Adding cron scheduler metrics reporting

Description
Adding metrics for cron scheduler execution:

JMX report generates sample records below:
# HELP pinot_controller_cronSchedulerJobExecutionTimeMs_Count Attribute exposed for management ("org.apache.pinot.common.metrics"<type="ControllerMetrics", name="pinot.controller.githubEvents_OFFLINE.SegmentGenerationAndPushTask.cronSchedulerJobExecutionTimeMs"><>Count)
# TYPE pinot_controller_cronSchedulerJobExecutionTimeMs_Count untyped
pinot_controller_cronSchedulerJobExecutionTimeMs_Count{table="githubEvents_OFFLINE",taskType="SegmentGenerationAndPushTask",} 1.0

Codecov Report

Merging #6502 (4492e90) into master (1beaab5) will decrease coverage by 22.55%.
The diff coverage is 41.96%.

@@             Coverage Diff             @@
##           master    #6502       +/-   ##
===========================================
- Coverage   66.44%   43.89%   -22.56%
===========================================
  Files        1075     1334      +259
  Lines       54773    65635    +10862
  Branches     8168     9571     +1403
===========================================
- Hits        36396    28808     -7588
- Misses      15700    34408    +18708
+ Partials     2677     2419      -258

Flag
Coverage Δ

integration
43.89% <41.96%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ot/broker/broker/AllowAllAccessControlFactory.java
100.00% <ø> (ø)

.../helix/BrokerUserDefinedMessageHandlerFactory.java
52.83% <0.00%> (-13.84%)
:arrow_down:

...org/apache/pinot/broker/queryquota/HitCounter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...che/pinot/broker/queryquota/MaxHitRateTracker.java
0.00% <0.00%> (ø)

...ache/pinot/broker/queryquota/QueryQuotaEntity.java
0.00% <0.00%> (-50.00%)
:arrow_down:

...ker/routing/instanceselector/InstanceSelector.java
100.00% <ø> (ø)

...ceselector/StrictReplicaGroupInstanceSelector.java
0.00% <0.00%> (ø)

...roker/routing/segmentpruner/TimeSegmentPruner.java
0.00% <0.00%> (ø)

...roker/routing/segmentpruner/interval/Interval.java
0.00% <0.00%> (ø)

...r/routing/segmentpruner/interval/IntervalTree.java
0.00% <0.00%> (ø)

... and 1334 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf35e6e...4492e90. Read the comment docs.

Codecov Report

Merging #6502 (4492e90) into master (1beaab5) will decrease coverage by 22.55%.
The diff coverage is 41.96%.

@@             Coverage Diff             @@
##           master    #6502       +/-   ##
===========================================
- Coverage   66.44%   43.89%   -22.56%
===========================================
  Files        1075     1334      +259
  Lines       54773    65635    +10862
  Branches     8168     9571     +1403
===========================================
- Hits        36396    28808     -7588
- Misses      15700    34408    +18708
+ Partials     2677     2419      -258

Flag
Coverage Δ

integration
43.89% <41.96%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ot/broker/broker/AllowAllAccessControlFactory.java
100.00% <ø> (ø)

.../helix/BrokerUserDefinedMessageHandlerFactory.java
52.83% <0.00%> (-13.84%)
:arrow_down:

...org/apache/pinot/broker/queryquota/HitCounter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...che/pinot/broker/queryquota/MaxHitRateTracker.java
0.00% <0.00%> (ø)

...ache/pinot/broker/queryquota/QueryQuotaEntity.java
0.00% <0.00%> (-50.00%)
:arrow_down:

...ker/routing/instanceselector/InstanceSelector.java
100.00% <ø> (ø)

...ceselector/StrictReplicaGroupInstanceSelector.java
0.00% <0.00%> (ø)

...roker/routing/segmentpruner/TimeSegmentPruner.java
0.00% <0.00%> (ø)

...roker/routing/segmentpruner/interval/Interval.java
0.00% <0.00%> (ø)

...r/routing/segmentpruner/interval/IntervalTree.java
0.00% <0.00%> (ø)

... and 1334 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf35e6e...4492e90. Read the comment docs.


ORC-669. Reduce breaking changes in ReaderImpl.java

What changes were proposed in this pull request?
Although this is Implementation class, this PR aims to reduce two breaking changes in ReaderImpl.java due to ORC-520 at Apache ORC 1.6.0 ~ 1.6.5.
Why are the changes needed?
This helps Apache Hive and Spark works with Apache ORC 1.6.x. For example, this PR removes the following breaking changes with a minor and safe revision.
[info] org.apache.spark.sql.hive.orc.OrcHadoopFsRelationSuite *** ABORTED ***
[info]   java.lang.NoSuchFieldError: types
[info]   at org.apache.hadoop.hive.ql.io.orc.ReaderImpl.<init>(ReaderImpl.java:64)

[info] org.apache.spark.sql.hive.orc.HiveOrcHadoopFsRelationSuite *** ABORTED ***
[info]   java.lang.IllegalAccessError: tried to access field org.apache.orc.impl.ReaderImpl.compressionKind
from class org.apache.hadoop.hive.ql.io.orc.ReaderImpl

How was this patch tested?
Manually review because this adds back a field and changes visibility of the field like ORC 1.5.x,

Could you review this, @omalley ?

@omalley and @alanfgates .
I'm trying to make Apache Spark 3.1 (scheduled on December 2020) to use Apache ORC 1.6. We need at least

ORC-669. Reduce breaking changes in ReaderImpl.java (this PR)
[SPARK-33047][BUILD] Upgrade hive-storage-api to 2.7.2

The other stuffs I'm looking at are the followings

The ORC's case-insensitive predicate handling change (1.6.x shows a different result compared with 1.5.x)
OrcTail API change.

Is Spark using the details of ReaderImpl?

Thank you for merging, @omalley . The above two are not used Spark sql module, but are used in Hive library in Spark's hive module.

If you don't mind, please land this to branch-1.6, too.

done

Thank you so much!


Update the Businesses page design, refactor the sort-by helper

https://trello.com/c/1hyRXuy5/1157-businesses-page-html-design-revision-and-refresh-5
Description

Provide a Help with the Businesses page drop down with associated help text in the drop down
Update the Keywords search bar - making it longer and repositioning it
Provide a search results description below the Keywords search
Provide a Sort by filter on the right with the following sort by options: Name A-Z and Name Z-A
The table design and layout (including Name and Company number table header and footers)
For those users that have the psd_admin role - the corresponding XLSX (spreadsheet) link should be removed to be replaced on the left

IMPORTANT: This PR adds a new Elasticsearch index, so merging and deploying this will produce some downtime on the Products page. You must reindex products after deploy:
Business.__elasticsearch__.import force: true, refresh: :wait

Checklist:

[ ] Have you documented your changes in the pull request description?
[ ] Does the change present any security considerations?
[ ] Is any gem functionality overloaded? Eg: Devise controller methods being overloaded.
[ ] Has acceptance criteria been tested by a peer?
[ ] Has the CHANGELOG been updated? (If change is worth telling users about.)

General testing (author)

[ ] Test without JavaScript
[ ] Test on small screen

Accessibility testing (author)

[ ] Works keyboard only
[ ] Tested with one screen reader
[ ] Zoom page to 400% - content still visible
[ ] Disable CSS - does content make sense and appear in a logical order?

Codecov Report

Merging #1704 (b1814d7) into master (7fae5d5) will decrease coverage by 71.10%.
The diff coverage is 21.51%.

@@             Coverage Diff             @@
##           master    #1704       +/-   ##
===========================================
- Coverage   89.74%   18.63%   -71.11%
===========================================
  Files         399      399
  Lines        8578    11601     +3023
  Branches     1241      529      -712
===========================================
- Hits         7698     2162     -5536
- Misses        700     9347     +8647
+ Partials      180       92       -88

Impacted Files
Coverage Δ

app/controllers/businesses_controller.rb
0.00% <0.00%> (-85.30%)
:arrow_down:

app/controllers/products_controller.rb
0.00% <0.00%> (-82.70%)
:arrow_down:

app/helpers/businesses_helper.rb
46.42% <0.00%> (-45.88%)
:arrow_down:

app/helpers/investigation_search_helper.rb
26.74% <0.00%> (-66.28%)
:arrow_down:

app/helpers/investigations_helper.rb
16.00% <0.00%> (-81.60%)
:arrow_down:

app/helpers/products_helper.rb
38.09% <0.00%> (-53.97%)
:arrow_down:

app/helpers/search_params.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

app/models/product.rb
94.28% <ø> (-5.72%)
:arrow_down:

app/helpers/sort_by_helper.rb
41.37% <42.30%> (-58.63%)
:arrow_down:

app/models/business.rb
90.00% <100.00%> (-4.29%)
:arrow_down:

... and 308 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fae5d5...b1814d7. Read the comment docs.

Tested new design on the review app, looking good as expected.
Just a minor issue, I guess it's related to ES indexing, when I add a new business the existing cases/business gets disappear or maybe the deployment kicked in at the same time. Please take a look.


javaclass-ignore condition not implemented

See this failing test.
See also the rules development guide.

Can someone help me understand what this is supposed to mean and how is it supposed to be used?
It appears that these are like reverse info rules that get applied to everything.
something like if the filename or java class are equal to this, then filter out every violation that has that?
I think, if we need this feature, we need a higher-level construct in the rule set if this is the case.

@jmle @rromannissen
Can you confirm that the understanding is correct and if not can you help me understand?


how to use profiler

For bugs or installation issues, please provide the following information.
The more information you provide, the more likely people will be able to help you.
Environment info
Operating System: Ubuntu 14.04
Compiler:g++, nvcc
Package used (Python/R/Scala/Julia):python
MXNet version: latest
Or if installed from source:
MXNet commit hash (git rev-parse HEAD):
If you are using python package, please provide
Python version and distribution:
If you are using R package, please provide
R sessionInfo():
Error Message:
Please paste the full error message, including stack trace.
Minimum reproducible example
if you are using your own code, please provide a short script that reproduces the error.
Steps to reproduce
or if you are running standard examples, please provide the commands you have run that lead to the error.

recursively pull the code from your repo.
I modify the config.mk and set USE_PROFILER = 1
then I make
After that I run python /mxnet/example/profiler/profiler_executor.py
It says "/mxnet/dmlc-core/include/dmlc/./logging.h:300: [22:33:05] src/c_api/c_api.cc:85: Need to compile with USE_PROFILER=1 for MXNet Profiler"

What have you tried to solve it?

I try to build the source code again, but same errors.

Can you provide more details about how to use the MxNet profiler?

run
import mxnet
print(mxnet.__file__)

See if you are really using the mxnet you just compiled

Yep, I think this is the correct path I compiled.

import mxnet
print(mxnet.file)
/mxnet/python/mxnet/init.pyc

Have you executed make clean if you did make before?

make sure no space left at the end line USE_PROFILER = 1

Yep, that is the problem @ZihengJiang , thanks ziheng !


Fixes for a crash and also for proxy parameters

Review Error for DeRauk @ 2023-04-11 18:56:13 UTC
User failed mfa authentication, see go/mfa-help