Add confirmation prompt when approving held request via report preview

Details

Add confirmation prompt when approving held request via report preview
Fixed Issues

$ https://github.com/Expensify/App/issues/39335
PROPOSAL: https://github.com/Expensify/App/issues/39335#issuecomment-2030358362
Tests

Precondition: Workspace enabled approval

Go to the WS chat
Create two expenses
Open transaction thread report of one expense and hold the request
Submit the expense
As approver, open WS chat and click on approve in report preview
Verify that confirmation prompt appears

[x] Verify that no errors appear in the JS console

Offline tests

Same as above
QA Steps

Precondition: Workspace enabled approval

Go to the WS chat
Create two expenses
Open transaction thread report of one expense and hold the request
Submit the expense
As approver, open WS chat and click on approve in report preview
Verify that confirmation prompt appears

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/161821005/d0cf77a8-9fed-4af2-8a72-67d7971b2365

Android: mWeb Chrome
https://github.com/Expensify/App/assets/161821005/44c95b0a-9073-41a2-9b4a-fc04d36f14d8

iOS: Native
https://github.com/Expensify/App/assets/161821005/56e1d446-ae32-4f9b-91e7-8aa26f0fe5db

iOS: mWeb Safari
https://github.com/Expensify/App/assets/161821005/e7ec0eca-3a78-4a09-a608-dfa50d8adec4

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/161821005/b6682d62-c1e0-4ee1-9bda-e4d32a866b6e

MacOS: Desktop
https://github.com/Expensify/App/assets/161821005/5223397d-8983-4db6-8e9e-bffa8f3f35af

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@nkdengineer Please merge the latest main

@DylanDylann Merged the latest main.

@bondydaa Please help to review the PR when you have a chance. Thanks.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.82-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.82-4 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Use registered subdir version of NDTensors

Codecov Report

Merging #780 (91aef80) into main (3f459fb) will decrease coverage by 24.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #780       +/-   ##
==========================================
- Coverage   24.43%   0.00%   -24.44%
==========================================
  Files          64      64
  Lines        7374    7336       -38
==========================================
- Hits         1802       0     -1802
- Misses       5572    7336     +1764

Impacted Files
Coverage Δ

src/ITensors.jl
0.00% <ø> (-30.00%)
:arrow_down:

src/not.jl
0.00% <0.00%> (-100.00%)
:arrow_down:

src/arrow.jl
0.00% <0.00%> (-100.00%)
:arrow_down:

src/mps/projmpo.jl
0.00% <0.00%> (-100.00%)
:arrow_down:

src/mps/abstractprojmpo.jl
0.00% <0.00%> (-73.53%)
:arrow_down:

src/decomp.jl
0.00% <0.00%> (-67.25%)
:arrow_down:

src/mps/dmrg.jl
0.00% <0.00%> (-64.55%)
:arrow_down:

src/physics/autompo.jl
0.00% <0.00%> (-63.64%)
:arrow_down:

src/physics/site_types/generic_sites.jl
0.00% <0.00%> (-60.00%)
:arrow_down:

src/qn/qn.jl
0.00% <0.00%> (-59.80%)
:arrow_down:

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f459fb...91aef80. Read the comment docs.


class conflict in example

this is not an error, but still, please add a namespace to samples so that Player does not conflict with Player in the game. All the best

Thanks


Vertical gradients

JWM currently supports only horizontal gradients.  Horizontal gradients have been requested, which should be fairly easy to support.  Perhaps an option on the color tag to indicate the gradient type.  Other gradients (diagonal, for example) would take more effort to implement and would likely be slower.

Thanks , i made a small modification to border.c and gradient.c (jwm-2.3.5)
http://pastebin.com/UA63Rvu4
I can see nice horizontal gradients,the only issue for me if i move the cursor from bottom to the top from the menu i can see some gradients left,maybe the modification isn't clean and my skill somehow limited.
http://s5.postimg.org/6smtpa2g7/scr.png


Improve ENV

This adds a sample with all environment variables and attempts avoiding ambiguity.

:+1:

@jgorset sure

ok...

:+1: @zenangst

@jgorset: Shouldn't you be in Denmark?

@timkurvers: I am in Denmark.

BUT, HOW!?

It's the internet, @timkurvers.

Isn't Denmark to flat for the Internet?


Error while running analyze (solc missing)

Environment information

py-solc-x Version: x.x.x
solc Version: x.x.x
Python Version: x.x.x
OS: osx/linux/win

What was wrong?
Please include information like:

what command you ran
the code that caused the failure (see this link for help with formatting code)
full output of the error you received

How can it be fixed?
Fill this in if you know how the bug could be fixed.

Hello I cannot run my mythx analyze
I got
Usage: mythx analyze [OPTIONS] [TARGET]...
Error: Error installing solc version v0.9.0: 404 error when attempting to download from
https://github.com/ethereum/solidity/releases/download/v0.8.4/solidity-windows.zip - are you sure this version of solidity is available?
py-solc-x: ???
solc: I have truffle and I use ^0.8.4
Python: 3.10.4
OS: windows 10

If you using truffle solc, you likely are not using this package. This is a python package! We also use the tar ball links so I don' t think your issue is coming from us, or else I need more info.
The link this package would use is https://github.com/ethereum/solidity/releases/download/v0.8.5/solidity_0.8.5.tar.gz


Activation list limit

Hello. I've been doing some load tests executing cpu-heavy ow actions using FaasProfiler. I'm acessing the activation list to get all the results at the same time, but it seems that the activation list registers only the last 30 activations, no matter how many I invoke, while the rest just seems to dissapear. I've read all the documentation and I've found no information regarding this limit. How could I do to remove this 30 activation limit?
Environment details:
kubernetes, ubuntu 20.04, FaasProfiler

the default activation limit when running a list query is 30. You can increase this through a query param to 200 based on the default configuration of openwhisk. You can configure these two values, the default and max, through pureconfig

the default activation limit when running a list query is 30. You can increase this through a query param to 200 based on the default configuration of openwhisk. You can configure these two values, the default and max, through pureconfig

How would it be this query param? I found no documentation about this limit


rspec feature spec has no described_class

If a feature or request spec is in the features directory will not have a described_class:
describe "a simple feature" do
end

The response is
The first argument to describe should be the class or module being tested.

Could we turn off this check for feature specs pls?

Hmmm... what if you only want this feature shut off for specific classes but the rest of the cops active on those specs.  If you exclude the entire directory you omit everything right?

As @testbrian mentioned you can define excludes for cops based on any file glob. You can also do # rubocop:disable RSpec/DescribeClass inline in a single source file.

Correct, I am aware of that, but you would have to put an enable disable around ever describe when you want to only disable that specific feature on named classes.  TBH, that seems a bit extreme right?

I can't really tell what you mean to be honest. Can you give an example of a the sort of code you are concerned about?

Coolio.
Let me try to show some pseudo code here:
describe 'myapp:data:load ->' do
  include Cancun::Highline
  before { init_highline_test }
  include_context 'rake'

  let(:task_name) { 'myapp:data:load:from' }
  let(:path_to_task) { 'tasks/data' }

  describe ':from', focus: true do
    it 'processes from a specified starting point' do

    end
  end
end

I would think we could keep the cops for the rest of the spec but omit only the describe.

Ok I think I'm following. So in this case
RSpec/DescribeClass:
  Exclude:
    - spec/tasks/myapp_data_load.rb

Would only disable the DescribeClass cop for the file in question assuming spec/tasks/myapp_data_load.rb is the path of the code in your example there

Awesome, thank you so much.

Feature tests seem to be excluded if you explicitly set type: :feature on them.

Any of the Rails' types actually https://github.com/rubocop-hq/rubocop-rspec/blob/master/lib/rubocop/cop/rspec/describe_class.rb#L47

While disabling this cop on a feature folder works for me, I would like to see the Cop actually trying to understand if a spec is not a class description. I am using config.infer_spec_type_from_file_location! for rspec to set the test type by convetion rather than explicitly (and redundantly) on each test. Would it be possible to detect that automatically and switch the cop of for feature, system and maybe request specs?

Sure, that would be a nice addition.
Would you like to hack on it @TimMoser92 ?
Off the top of my head:

check existing cops that check metadata
in the initializer, figure out how to fetch this data from spec/spec_helper.rb (or spec/rails_helper.rb). I guess this is very unreliable and will fail with any dynamic declaration. So we'll need our own mapping in the configuration to repeat those for RSpec
inject metadata in examples/example groups; not sure if there should be a distinction between explicitly defined and inherited metadata

I will try to have a look at it later today. Thank you for the pointers, @pirj !


[ENHANCEMENT] Upgrade: optimize upgrade prepare process

Is your enhancement related to a problem? Please describe.

Even when running with very fast CPU/memroy, the upgradeprepare-on POD takes more than 6 minutes to prepare in ONE node,  for other environment, it will take more time.
cattle-system               apply-hvst-upgrade-v6mpd-prepare-on-harv31-with-3d4769489-dz4c7   1/1     Running     0              6m33s

cattle-system               apply-hvst-upgrade-v6mpd-prepare-on-harv31-with-3d4769489-dz4c7   0/1     Completed   0              6m43s

Describe the solution you'd like

Try to optimize.
Describe alternatives you've considered

Haveter v1.1.1 to v1.1.2-rc3 upgrade.
Additional context

One prepae-image log:
gh-issue-3616-log-upgrade-prepare-image.txt
Observed in
issue: https://github.com/harvester/harvester/issues/3616
pr: https://github.com/harvester/harvester/pull/3641
cc @bk201 @guangbochen @starbops @yasker

@w13915984028 any plan to improve this?

@bk201 No detailed plan yet.
I will check this in v1.4.0 to see if it has already been solved or some optimizations can be done.


Model loading

add llama configs for training
add the possibility of downsampling some molecular properties during the training
add special tokens for the property tags, smiles and safe
add CONFORMER tag to the tokenizer
verify logits matching with huggingface when download and exporting llama

LGTM


modifying ci_scripts/install_pmem_common.sh oap-ape/README.md

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

please change your target branch to ape


Missing Navbar in contributors page

🐞 Bug Report
📋 Description
The navigation bar is missing on the Contributors page, causing navigation inconsistencies across the website.
⚙ Steps to Reproduce
Steps to reproduce the behavior:
Open the website and navigate to the Contributors page.
Observe the absence of the navigation bar.
Try to navigate back or to other sections without the navigation bar.
✔ Expected Behavior
The navigation bar should appear on the Contributors page, allowing users to navigate to other parts of the website easily.
❌ Actual Behavior
The navigation bar is missing, limiting navigation on the Contributors page.
📷 Screenshots

🔧 Additional Information
The issue seems specific to the Contributors page. Other pages on the site have a visible and functional navigation bar.

🐞 Bug Report
📋 Description
The navigation bar is missing on the Contributors page, causing navigation inconsistencies across the website.
⚙ Steps to Reproduce
Steps to reproduce the behavior:
Open the website and navigate to the Contributors page. Observe the absence of the navigation bar. Try to navigate back or to other sections without the navigation bar.
✔ Expected Behavior
The navigation bar should appear on the Contributors page, allowing users to navigate to other parts of the website easily.
❌ Actual Behavior
The navigation bar is missing, limiting navigation on the Contributors page.
📷 Screenshots

🔧 Additional Information
The issue seems specific to the Contributors page. Other pages on the site have a visible and functional navigation bar.

Okay.Do what you want.

merged


SAK-29148 protect against trying to parseInt on a blank or null string

and more accurate logging
This is replacing a previous PR #288

Save the stringtest logic, use NumberUtils
https://commons.apache.org/proper/commons-lang/javadocs/api-2.6/org/apache/commons/lang/math/NumberUtils.html#toInt(java.lang.String)
NumberUtils.toInt(string)
Convert a String to an int, returning zero if the conversion fails.

If the string is null, zero is returned.

   NumberUtils.toInt(null) = 0
   NumberUtils.toInt("")   = 0
   NumberUtils.toInt("1")  = 1

Parameters:
    str - the string to convert, may be null
Returns:
    the int represented by the string, or zero if conversion fails
Since:
    2.1

Returns

Thanks Steve. I re-did the commit, squashed, and force pushed.


BE AS CLEAR AND CONCISE AS POSSIBLE.
describe the bug
apple emojis i use frequently (in callouts, to-do lists esp) such as ‼ and ⚠ changed by notion enhancer to what i believe are unicode versions, same weight as text, monochromatic etc
attempting to select 'apple' in the emoji sets option within notion enhancer does not change this issue
uninstalling notion enhancer reverts the emoji set back to colour/illustrated etc
expected behaviour
emojis should remain their colour/illustrated versions for easy visual reference (I use them to help me remember things and draw my eye)
screenshots
https://imgur.com/a/qj4h9yt (please let me know if this link does not work, I am not familiar with GitHub or imgur so this is a learning experience!)
platform
macOS (M1, Big Sur)

Sorry to bring up an old issue, but I'm having the exact same problem and this is the only mention of the problem that I've found after a spending a good while searching.
I'm Currently using notion-repackaged 2.0.18-1 on M1 & macOS 12.4.
I also see these "unicode" versions of emojis appearing in other Chrome-based apps like Todoist (Electron), and Chrome itself (but only in the address bar).
@noahbgf Did you eventually fix your issue?
@dragonwocky Why was this marked as completed?

@iliawnek certain emoji characters appear in this "unicode" form depending on the font assigned to the text/container they are within. This is entirely normal and not something uniquely caused by the notion-enhancer.
The specific occurrence described in this issue was caused by the emoji sets extension replacing Notion's emojis with actual emoji characters. The emoji sets extension now uses images rather than characters and so no longer causes this.


Error is not helpful when you forget to install template

In my case, I forgot to install graphql-codegen-typescript-template as specified in the README. But the error I got was not helpful.
11:39:25.970 - error:
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @ refresh:types: `gql-gen --require ts-node/register --template typescript --schema packages/graphql-endpoint-lambda/src/schema.ts --out packages/graphql-endpoint-lambda/__generatedTypes__/types.ts`
npm ERR! Exit status 1
npm ERR!

It would be nice to see something like "template not installed" or "you are trying to use graphql-codegen-typescript-template but it appears you forgot to install it."

Fixed in 0.12.0


Get real panda connected

Fixes the problems described in https://github.com/bluesky/ophyd-epics-devices/issues/34
To test, I ran a local PandABlocks IOC and managed to connect a real panda device with
async def test_set_panda_table():
    panda: PandA = PandA("WS103-PANDA")
    await panda.connect()

I'm not sure if the extra function get_type_hints_no_inheritance is the best fix so this is probably the main thing to look at in review

If the get_type_hints_no_inheritance looks okay, it might be better to add to utils - also I'm happy to write a test for it

Looks good, could you rebase it on top of main branch please? Looks like the panda isn't up to date.
Remember to do a git pull first

Getting real PandA connected done in https://github.com/bluesky/ophyd-epics-devices/pull/39 instead


Add skip_tls_verify option

Adds the ability to skip TLS verification of the server's certificate chain and host name.

Thank you very much for this pull request!


Use register aliases

:warning: I haven't tested this on arm :warning:
Use lldb's register aliases instead of specific architecture register names. The main reason for this change is that some commands, like bmessage, will print out the results that include the output of these functions. I think it would be beneficial to surface the aliases to users, to spread their existence and availability.
Todo:

[ ] Test on arm32
[ ] Test on arm64

Depends on #97

We should ship this. @kastiglione did you check it works on ARM yet?

Thanks for the ping, will put this on my todo list.


LinkedGeoData not getting fetched by app

Describe the bug
One of the remote sources available in the catalogue is LinkedGeoData. Unfortunately, errors are returned saying access control checks failed and that it is not possible to request the resource.
To Reproduce
Steps to reproduce the behavior:

Go to Catalog
Click on 'Add' next to LinkedGeoData
Go to Explore and click on, e.g., Classes
Observe errors thrown in Logs / DevTools console

Expected behavior
Would expect the data to be loaded from the remote resource into the application
Screenshots
Error messages in the logs:

Error messages in the console:

Desktop

OS: MacOS 14.6
Browser: Safari
Version: 17.6

Thanks for raising - I believe just from looking at the error there that this is probably because the remote source is serving http and the site itself is served out of https, so it should just be a case of updating the URL to https.


Add StopRulerAction

Ref

https://nanopay.atlassian.net/browse/NP-4553

Changes

Add StopRulerAction (needed for user-allow-duplicate-email-rule)

@kgrgreer @jlhughes @nanoscott please review when you have a chance. Thanks

This was in the initial design and we never implemented it?

We exposed ruler object in rule action, any action can call ruler.stop() but never make it an a standalone action on it own.


SetDefaultMinLogLevel based on Serilog's value

Fixes #14

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Oh nevermind, I believe that wouldn't work for folks using 1-step logger initialization. I am not able to find a way around in that case.

@alexalok What do you mean by 1-step logger initialization?

If you are using the sync you automatically get the min level. It's only for cases where you are manually creating logs using our API. What is your use case?

What do you mean by 1-step logger initialization?

In my code I initialize Serilog two times - first time at the very beginning of program execution and second time later when configuration options have been read. My PR code will crash if used during initial initialization because there won't be any level satisfying this condition.

If you are using the sink you automatically get the min level. It's only for cases where you are manually creating logs using our API. What is your use case?

My case is related to #14. When first trying this sink I had difficulty understanding why no events were sent. I am now using a modified version from this PR but as I said it won't work for everyone.

What was causing the crash? Why not just have it call set default log level multiple times? I see no harm in this? Also, please take a look at how we implemented logging with serilog (https://github.com/exceptionless/Exceptionless/blob/main/src/Exceptionless.Web/Program.cs) I'd be curious if this would work for you? Kinda looks like we are double initializing it as well???


Bug Fix #9617 - Disables hover focus on button disabled

This fixes - #9617
@ncoden for review

Nicolas i have done no 2 & 3 ..... and i am unsure about review 1 ( confused )

Consider the following situation:
.my-button {
  &:hover {
    background-color: red;
  }
}

<button class="my-button button primary" disabled>Button</button>

On :hover, should the button appear as blue (primary color) or red ?
Poke @kball

pointer-events: none;

will do the trick in that case ..... ??

How about this, a bit repititive and also is using that dreaded !important also but it's resolving the issue
@mixin button-disabled(
  $background: $primary-color,
  $color: $button-color
) {
  opacity: $button-opacity-disabled;
  cursor: not-allowed;
  background-color: $background;

  $color: color-pick-contrast($background, ($button-color, $button-color-alt));

  color: $color;
  &:hover, &:focus {
    background-color: $background!important;
    color: $color!important;
  }
}

Nothing. The pointer event is not disabled for now.
See: https://github.com/zurb/foundation-sites/issues/9121
This behavior was introduced at: https://github.com/zurb/foundation-sites/pull/8317

!important.
Never !
This is nothing more than a hack in specificity. It is saying "whatever the context, whatever what the user really want, this will works that way". Except in some very specific case, !important should never be used.
And you do not need important to solve this issue. It the code you provided, it works well without.

This is nothing more than a hack in specificity. It is saying "whatever the context, whatever what the user really want, this will works that way". Except in some very specific case, !important should never be used.

I know it already but if you gonna say dont let the user modify something they want to .... what else would i say :stuck_out_tongue:

Nothing. The pointer event is not disabled for now.

Ohk then let pointer events the way to go then.

I know it already but if you gonna say dont let the user modify something they want to .... what else would i say 😛

I am wondering if the :hover color modified by the user should also override the default [disabled]:hover color. This is a very specific case. I am not talking about "not letting the color be overridden whatever the situation".

Ohk then let pointer events the way to go then.

I do not understand.

i am asking whether should i add .... pointer events or not ?

See: https://github.com/zurb/foundation-sites/issues/9121 and #8317

The philosophical issue with pointer-events is that this CSS property actually affects behavior and functionality -vs- style and design.

There is also a UX argument. If pointer-events:none; is applied to your disabled elements then you lose the ability to provide meaningful feedback to the user. No interaction whatsoever will trigger from both a CSS or JS perspective. I think this is a major fallback.

And

If there is pointer-events: none; for buttons we can't use tooltips on buttons

First of all,

Pointer events isn't the solution
Important isn't surely the solution

and yes you are right morever first question would be whether this below should be red or blue...
<button class="my-button button primary" disabled>Button</button>

But for me the code i gave is ohk enough and there is no need to let user dont modify if they want to!

@andycochran as the architect behind our recent palette changes, what think you?

A though about it a while and now I think the color should not be overridden in the example I given. [disabled] is definitely about the whole state of the button, including :hover and :focus, these pseudo-classes should not modify it, even when defined after.

Let them do whatever they want to do man!!

To be clear: yes, we should always let the user do whatever ze want, it is the idea behind the idea of "low specificity" I always promote. But in this case, wanting a :hover color is different from wanting an [disabled]:hover color, so redefining the first one should not modify the second.

so nicolas ...... how can we solve this in that case then ?

By defining background and color for :hover, :focus. We ensure the background and color stay the same as for [disabled] when over/focus.

Nicolas the requested changes are done..... thanks ..... harry

We ensure the background and color stay the same as for [disabled] when over/focus.

That is exactly what I want, thanks!
Thanks all of you for this fix, really love it!

Requested Changes are done, dear nicolas

@kball Is this ready to merge now ?

Sorry, I forgot to reply.

Please put logic and variable definition in the top of the mixin, before declaring any property.

are you talking about anything else because this is what i did in my last commit
/// Adds disabled styles to a button by fading the element, reseting the cursor, and disabling pointer events.
/// @param [Color] $background [$primary-color] - Background color of the disabled button.
/// @param [Color] $color [$button-color] - Text color of the disabled button. Set to `auto` to have the mixin automatically generate a color based on the background color.
@mixin button-disabled(

I am talking about the logics for the functions. @if, @else if, variables, @include... So in our case: @if $color == auto { ... }.

Have done just that but i wonder that in other if statements within _button.scss there is no such comment ?

Ahah, we have definitely a problem in understanding each other:
I mean : Moving @if $color == auto { ... }. to the top of the mixin.
@if & cie is the logic, and it is better to have the logic first, then CSS properties.

Are you wanting this ?
@mixin button-disabled(
  $background: $primary-color,
  $color: $button-color
) {
  @if $color == auto {
    $color: color-pick-contrast($background, ($button-color, $button-color-alt));
  }

  opacity: $button-opacity-disabled;
  cursor: not-allowed;

  &, &:hover, &:focus {
    background-color: $background;
    color: $color;
  }
}

YES !

done !!!

Ahah, we have definitely a problem in understanding each other:

I dont think so! Just happens when we all are talking codes. :smiling_imp:

ready to merge ?

Looks good, nice work you two.
Do you think this is conceptually a "fix" that should be applied to the 6.3.x branch?

Yes, it is.

A huge thanks to @IamManchanda for the PR and to @ncoden for assistance and @kball for merging it so quickly!

Pleasure is our's buddy @Vuurvlieg


What if I have multiple Daily Notes from the same day?

I've been importing journal entries from the Journey app. As a result, I have Daily Notes with the date and the time in the title. Your plugin is only displaying the first note from the day in history. Is there any way to get all of the day's notes to display?
This is so close to replicating Journey's Throwback feature.

Hey, glad to hear you are using my plugin for that. I actually also imported my notes from Journey and stumbled upon a similar problem.
I only support the same note structure also supported by the standard daily/periodic notes, which to my knowledge does not support multiple notes per day. E.g the "open daily note" command can only open a single note per day, no?
I can try to parse several notes per day, but that's rather complex and not sure when I'd get to that, so no quick fix for that I think.
Out of curiosity, how did you import your notes from Journey to Obsidian? I had to write a short custom script, but it didn't work perfectly.

Hi Michael, and thanks for the reply.
That's funny that you're trying to import Journey notes. Is that what
prompted you to create this plugin?
I used a Journey to Obsidian converter which I found out about here:
https://disordered.me/notes/my-migration-from-journey-app-to-obsidian/
In Obsidian, I changed the daily note date format to include hours, minutes
and seconds. Then, when I ran the converter, I had to specify that I wanted
the output to show hours, minutes and seconds as well. It worked well
enough.
Ultimately, I just decided to keep using Journey though.
On Mon, Jan 8, 2024 at 10:53 AM Michael Seifarth @.***>
wrote:

Hey, glad to hear you are using my plugin for that. I actually also
imported my notes from Journey and stumbled upon a similar problem.
I only support the same note structure also supported by the standard
daily/periodic notes, which to my knowledge does not support multiple notes
per day. E.g the "open daily note" command can only open a single note per
day, no?
I can try to parse several notes per day, but that's rather complex and
not sure when I'd get to that, so no quick fix for that I think.
Out of curiosity, how did you import your notes from Journey to Obsidian?
I had to write a short custom script, but it didn't work perfectly.
—
Reply to this email directly, view it on GitHub
https://github.com/Kageetai/obsidian-plugin-journal-review/issues/12#issuecomment-1881329508,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BEXF75RC4C73UYVELLTOKSLYNQJAXAVCNFSM6AAAAABBJQEXPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBRGMZDSNJQHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Yes, I had been using Journey for a few years, but after starting to use Obsidian and liking it more and more, I thought I slowly wanna switch over to a platform where I have more control and thought it a good opportunity to get my hands dirty on some plugins for this wonderful software.
I see your use case now, but would need to investigate how to achieve this.
What made you stick with Journey in the end? What was missing for you in Obsidian?

Yeah, having more control was a big plus for me too. And I'd been paying
for a subscription to Journey, and I didn't want to do that anymore. There
are some things about Journey that I don't think work right, so I was
looking for a perfect experience.
In the end, I simply thought Journey did journaling better. One thing that
was missing from Obsidian is automation. I have Journey pulling in a few
RSS feeds that show what media I'm consuming. I use Trakt, for example, to
log my TV and movie watching. When I do that there, Journey automatically
creates an entry. I love to look back and see what I was watching and
reading. Obsidian has two RSS plugins that I could find, but neither of
them work the way I want them to.
Obsidian lacks the slick Throwback feature that Journey has, which is
another thing I love. So, I had high hopes when I found your plugin! It's a
great plugin, but again, just doesn't work the way I want it to.
I don't like how Obsidian's desktop and Android apps feel like two separate
experiences. I was able to get syncing going for free, but I disliked
having my entire vault on my phone's storage.
Those are the big 3. There are a few little things about Journey that I was
willing to sacrifice, such as the ability to create a post using a photo
and the date and other metadata are automatically changed to reflect when
the photo was taken.
Journey is rolling out an AI feature, too, which looks pretty useful.
I'd never used Obsidian before I went down this road, so I had a lot to
learn and figure out. I think if I were already using Obsidian for other
things, then it would make sense to use it for journaling.
I also feel like Obsidian is for people who really like to tinker and know
how to write and edit code, use command line interface, and so on. And none
of that describes me! 😆 I had to get Chat GPT to help me run that Journey
to Obsidian converter.
Having said all that, I do like Obsidian and maybe I'll have a use for it
someday.
Whew! Sorry for the long boring reply!
Have you completely moved away from Journey then? Using Obsidian for
journaling?
On Thu, Jan 11, 2024 at 9:37 AM Michael Seifarth @.***>
wrote:

Yes, I had been using Journey for a few years, but after starting to use
Obsidian and liking it more and more, I thought I slowly wanna switch over
to a platform where I have more control and thought it a good opportunity
to get my hands dirty on some plugins for this wonderful software.
I see your use case now, but would need to investigate how to achieve this.
What made you stick with Journey in the end? What was missing for you in
Obsidian?
—
Reply to this email directly, view it on GitHub
https://github.com/Kageetai/obsidian-plugin-journal-review/issues/12#issuecomment-1887323116,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BEXF75U62EZFKWS6QJYNJNTYN72MLAVCNFSM6AAAAABBJQEXPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBXGMZDGMJRGY
.
You are receiving this because you authored the thread.Message ID:
@.***>

Ah, I have never even tried the subscription, but makes sense that you are using even more features specific to Journey. I also found some of their features just a bit more restrictive, but otherwise a great product nonetheless.
Regarding the automations, as I have never tried them with Journey, I cannot speak for them, but actually thought it seems easier to have more powerful and flexible automations with Obsidian, as I can have the choice in plugins and such. But of course, it's also more of a chore potentially, to set up everything manually. As a developer myself, I don't usually mind it that much.
With that said, the biggest thing I was also missing was the throwback feature, so I thought to try making it myself.
If there is anything, apart from initial problem with multiple entries per day, that you mentioned, that you would miss here from Journey, I can add it to my to-do list ;)
Regarding adding photos and automatically use the metadata, I had also thought of that and considered using it, but for now I am just using the Obsidian Geocode Properties plugin for some of that.
Oh, and might I ask how you got the syncing to work for free? I am paying for Obsidian sync currently and did try some free methods, but nothing seemed to work perfectly yet, so decided to pay for the official solution for the time being.
Therefore, as you said, Obsidian is definitely more of a "tinker tool", which I enjoy, but I understand the hurdles that creates. I think the team tries to strive for a good balance for a majority of users, though. I enjoy that power of really "making the tool my own" :)
I haven't entirely moved away from Journey yet, mainly to see whether my plugin catches all past entries correctly and the same ones Journey would show me for a single day. So for the time being, I use both in parallel.
And never be sorry for a nice message like this, I am enjoying discussing a software I like and its features or something I am working on etc :)

I thought I'd have a better experience with automation plugins for
Obsidian. Like you said, I figured they'd be more powerful and flexible
than what I have with Journey. But, if that experience exists, I was unable
to find it. Unlike you, I'm not a developer in any way shape or form, so
I'm pretty much at the mercy of the plugin developer. I imagine it's very
satisfying to tinker until you get it just the way you want it. So, I can
understand what you're feeling.
Regarding syncing, I use an Android device and found an app called
DriveSync. I have my Obsidian desktop vault in a folder on Google Drive and
that app simply watches for changes to that folder. It works very well.
But, as I mentioned, the downside was that I had my entire vault on my
phone since Obsidian only uses local Android storage. (As far as I know.)
On Sat, Jan 13, 2024 at 12:27 PM Michael Seifarth @.***>
wrote:

Ah, I have never even tried the subscription, but makes sense that you are
using even more features specific to Journey. I also found some of their
features just a bit more restrictive, but otherwise a great product
nonetheless.
Regarding the automations, as I have never tried them with Journey, I
cannot speak for them, but actually thought it seems easier to have more
powerful and flexible automations with Obsidian, as I can have the choice
in plugins and such. But of course, it's also more of a chore potentially,
to set up everything manually. As a developer myself, I don't usually mind
it that much.
With that said, the biggest thing I was also missing was the throwback
feature, so I thought to try making it myself.
If there is anything, apart from initial problem with multiple entries per
day, that you mentioned, that you would miss here from Journey, I can add
it to my to-do list ;)
Regarding adding photos and automatically use the metadata, I had also
thought of that and considered using it, but for now I am just using the Obsidian
Geocode Properties
https://github.com/jose-elias-alvarez/obsidian-geocoding-properties
plugin for some of that.
Oh, and might I ask how you got the syncing to work for free? I am paying
for Obsidian sync currently and did try some free methods, but nothing
seemed to work perfectly yet, so decided to pay for the official solution
for the time being.
Therefore, as you said, Obsidian is definitely more of a "tinker tool",
which I enjoy, but I understand the hurdles that creates. I think the team
tries to strive for a good balance for a majority of users, though. I enjoy
that power of really "making the tool my own" :)
I haven't entirely moved away from Journey yet, mainly to see whether my
plugin catches all past entries correctly and the same ones Journey would
show me for a single day. So for the time being, I use both in parallel.
And never be sorry for a nice message like this, I am enjoying discussing
a software I like and its features or something I am working on etc :)
—
Reply to this email directly, view it on GitHub
https://github.com/Kageetai/obsidian-plugin-journal-review/issues/12#issuecomment-1890600974,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BEXF75TVWQK2WQK4QGF46BTYOK7Z3AVCNFSM6AAAAABBJQEXPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJQGYYDAOJXGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

I understand, finding and settings up all the specific features for a personal use case, can be cumbersome. I had the idea to create a "bundle of plugins" to provide a more fully-fleshed journaling experience and approximate something like Journey at some point. But that's a rather far future idea :D
Interesting, I have also tried apps like DriveSync (or FolderSync for me), but the problem triggering a new sync on the phone and the files on my phone would often be outdated, as no tool I found would watch the files on the phone and sync them automatically to Google Drive when I changed something reliably.
Is this the DriveSync you mean?

That bundle idea sounds great! Seems like a daunting task to be sure.
And yes, that app you linked to is the one. Funny how the app is titled
differently in the Play Store listing. The app when installed is titled
DriveSync.
On Sat, Jan 27, 2024, 12:39 PM Michael Seifarth @.***>
wrote:

I understand, finding and settings up all the specific features for a
personal use case, can be cumbersome. I had the idea to create a "bundle of
plugins" to provide a more fully-fleshed journaling experience and
approximate something like Journey at some point. But that's a rather far
future idea :D
Interesting, I have also tried apps like DriveSync (or FolderSync for me),
but the problem triggering a new sync on the phone and the files on my
phone would often be outdated, as no tool I found would watch the files on
the phone and sync them automatically to Google Drive when I changed
something reliably.
Is this the DriveSync
https://play.google.com/store/apps/details?id=com.ttxapps.drivesync&hl=en&gl=US
you mean?
—
Reply to this email directly, view it on GitHub
https://github.com/Kageetai/obsidian-plugin-journal-review/issues/12#issuecomment-1913271085,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BEXF75VZGVB3WBPHP5TO7SLYQU3VTAVCNFSM6AAAAABBJQEXPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGI3TCMBYGU
.
You are receiving this because you authored the thread.Message ID:
@.***>


Update show logic

Codecov Report

Merging #95 (d834df8) into main (cd8af9b) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
- Coverage   98.41%   98.40%   -0.01%
==========================================
  Files          26       26
  Lines         882      880       -2
  Branches       84       83       -1
==========================================
- Hits          868      866       -2
  Misses          8        8
  Partials        6        6

Impacted Files
Coverage Δ

src/wagtail_live/publishers/websocket.py
100.00% <ø> (ø)

src/wagtail_live/models.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd8af9b...d834df8. Read the comment docs.


Controller tests failing due to cache on v2.0.0-alpha.2

On a project at work, we started getting a lot of failing controller tests due to this error: 'Assertion Failed: Cannot call get with 'cache' on an undefined object.'
I  noticed that all of the failing tests depended on ember-validations, and saw that v2.0.0-alpha.2 was released yesterday. It seems like the error must be happening around here:
https://github.com/dockyard/ember-validations/compare/v2.0.0-alpha.1...master#diff-68a377996e559f04a75ca6ba1af084b1R34
I don't know enough about Ember/Qunit internals to see what the issue is, but I wanted to raise this in case others have the same problem. Validations were working in the app, the only issue was in testing. Moreover, some of our integration tests touch on validation functionality, and those were also passing.
This is what one of the failing tests looked like, just the standard ember g controller test:
`import { test, moduleFor } from 'ember-qunit'`

moduleFor 'controller:user', 'UserController', {
  needs: ['ember-validations@validator:local/presence',
          'ember-validations@validator:local/format',
          'ember-validations@validator:local/length']
}

test 'it exists', ->
  controller = @subject()
  ok controller

Using:
Ember : 1.7.0
Ember-cli : 0.1.2
Let me know if I can provide any more info

@coleww is this not happening in alpha.1?

@bcardarella Also seeing this after pulling in alpha.2.  Reverted to alpha.1 and could no longer reproduce the issue.

@bcardarella tests are all passing on alpha.1

Any chance you guys could create a sample app recreating? I'm not seeing it on my end.

@bcardarella - Created a minimal demo repo here - https://github.com/ehntoo/ember-validations-234.
See the WutController and corresponding unit test.

Can you try master branch?

@bcardarella Still appears to be failing for me in a slightly different manner in the ember-validations-234 project I created as a minimal testcase.
not ok 8 PhantomJS 1.9 - WutController: it exists
    ---
        actual: >
            null
        message: >
            Died on test #1     at http://localhost:7357/assets/test-support.js:418
                at test (http://localhost:7357/assets/test-support.js:284)
                at http://localhost:7357/assets/ember-validations-234.js:242
                at http://localhost:7357/assets/vendor.js:77
                at http://localhost:7357/assets/test-loader.js:14: 'undefined' is not an object (evaluating 'cache[validatorName]')
        Log: >
    ...

If I apply a similar strategy to line 34 and default the cache to an empty object as well, everything works fine, but my interpretation is that this is defeating the cache entirely as it will be re-created on every validator lookup.  This is fine for my usecase, but I'm unsure about it's general suitability.

@ehntoo ok, I should have it squashed now. Check out master. I've also added a regression test for this bug

@bcardarella Looks good to me. Thanks for the quick response on this!

mind sharing how to instal master branch? I'm having trouble building locally


Updated versions, added tag variables and updated java/nomad installation

Need to review Packer file for Ubuntu, Java and Docker not being installed

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes
Have you signed the CLA already but the status is still pending? Recheck it.


Fully document hpx_wrap behaviour and targets

Before I forget:

Document all three targets HPX::hpx, HPX::hpx_no_wrap_main, and HPX::wrap_main
Add troubleshooting entry for the common error messages resulting from not using the targets above correctly

Add troubleshooting entry for the common error messages resulting from not using the targets above correctly

Are there ways to diagnose problems at configuration time?

Add troubleshooting entry for the common error messages resulting from not using the targets above correctly

Are there ways to diagnose problems at configuration time?

I don't think so but will add it if I come up with something. Most likely having a way to do that implies having a way to do the linking correctly in the first place, in which case we don't need the troubleshooting section for that.


Documentation notes for Workbench — to integrate into pages

Some of this will eventually need to appear in the wiki; we'll have to separate out what is relevant generally and write it from the point of view of a BG+WB programmer/user.
The Task
This task will make more sense when you look at the commit keys on github. The details on this task have changed to include a commit key. This is more specifically asking if the version of the workbench during this specific revision functions as-is.
Clone The Repository Rather than Downloading the ZIP on Github...
You probably need to clone the repository to a directory and use that as an existing source during a new java project with existing sources setup. I think what you did was just downloaded the zip from github. That just gives you the most current version of whichever branch you are looking at. What you want to do is clone the repository to an empty folder using git bash. You can use the following command to clone it: git clone GitHub - UWB-Biocomputing/BrainGrid: A project to facilitate construction of high-performance neural simulations. BrainGrid. First you will have to make the BrainGrid directory and make sure it is empty. So, the state of the code that he wants you to test is here:
(1) Added simulation configuration test model. (2) Changed look and f… · UWB-Biocomputing/BrainGrid@0eda76e · GitHub
Use Git on the Commandline to Checkout the Specified Revision
You can use git bash again to change the revision to that commit by using the following command after navigating to the repository directory that you just cloned into: git checkout 0eda76e9ea75fd4608105309899ef1f3291f42ec
Make a New Project Using the Workbench Source Code You Just Cloned (Rather Than The Zipped Stuff from Github)
Now, in netbeans, make a new java project with existing sources but dont click finish. click next and it will ask you to add directories containing source code and test code. click add next to the source code and navigate to your repository and then into this directory BrainGrid/Tools/Workbench/ and then select the src folder. Then finish the new project dialog. If you expand the src folder you should see a workbench package (not one of its subpackages), expand that. Then, right click Workbench.java and select run. This will fail to run because it will throw an exception about missing dependencies (ClassNotFoundException). Download the lib folder from the BrainGrid google drive folder I shared with you. Extract those jar files somewhere. Now back in netbeans in the workbench project, right click libraries and select add jar/folder. Now select all those libraries and check the radio button that says relative path in the upper right corner. Then click the add button. That should have fixed it. Now run Workbench.java again.
Test the Workbench
Okay, so now that you have all that stuff installed, you can test what Mike wants you to test. What he wants to know is if the user can use the workbench in its state at the point in time where that particular commit was made. From what I remember, the second button in the workflow to build the script is what makes this tricky. When the default options for building the build/execution script come up, they don't specify an SHA1 hash key, but you can put one in. What happens if you don't put one in, is that the repository is cloned and the revision is set to the latest revision of the default branch. That used to work, but since the config file format doesn't match up with what the simulator expects, now you will have to make the build/execution script build the old version of the simulator. Namely, you will have to specify 0eda76e9ea75fd4608105309899ef1f3291f42ec in the box that says SHA1 in the script configuration dialog (2nd button on the workbench). You will also need to set the build option to build and the source code updating to pull. This should make it so that, when you "run" the script that it does the following:
ScriptSteps

Transfers the configuration file you build
Transfers the Neuron Lists that were specified in the config file
Transfers the build/exec script for the simulation
Attempts to make an empty directory called "Whatever was in the 'Folder' box in the script specification dialog"
Attempts to clone from the network location of the remote repository (probably github.com/UWB-Biocomputing/BrainGrid/blahblahblah) to the empty directory from step 4
Attempts to checkout the revision specified in SHA1 field of the script configuration dialog that popped up in the 2nd workflow step in the workbench
Attempts to "make -clean" to remove any existing binary files from the repository directory
Attempts to "make binaryname" to build the simulator
Attempts to execute "binaryname" (probably growth) with the configuration file as its input parameter

Now, if the simulator code that was in the repository during the revision: 0eda76e9ea75fd4608105309899ef1f3291f42ec is working correctly (correct make file, no bugs, etc.) and the configuration format matched the format in the workbench, then this task is complete. You will be able to tell if this was successful by looking at the output file that all the printf statements in the script went to. It should be called ProjectName_scriptOutput_vVersionNumber.txt. Download that and open it. After every step that was executed is an exit status. Exit statuses of 0 are successes and any other number is a failure. You should get at least one failure when it clones and pulls because for the clone to succeed, the directory must be empty, and for the pull to succeed, the repository cannot have been up to date. What you are looking for is the execution line near the bottom. It will be something like ./growth MyConfigFile.XML. If it failed, we want to know whether it was because of the config file or the make file (used to build the binaries off of the source code). If it failed, scroll up to where it says make growth, right after make -clean. If that failed then there was a bug during that particular revision... probably the old HDF5 bug, not the new one, there used to be a problem with the make file if I recall.

First Draft of the document. Will update and integrate into pages.
WorkbenchUserManual_v0.1.docx


inversion doesn't look like the face of img source

inversion doesn't look like the face of img source,How can I make it look more like img source?

Hi @molo32,
Can you provide further details? have you performed the required face alignment?

image_path = "/content/8.jpg"
original_image = Image.open(image_path)
original_image = original_image.convert("RGB")
input_image = run_alignment(image_path)

def run_on_batch(inputs, net):
    images, latents = net(inputs.to("cuda").float(), randomize_noise=False, return_latents=True)
    if experiment_type == 'cars_encode':
        images = images[:, :, 32:224, :]
    return images, latents

def display_alongside_source_image(result_image, source_image):
    res = np.concatenate([np.array(source_image.resize(resize_dims)),
                          np.array(result_image.resize(resize_dims))], axis=1)
    return Image.fromarray(res)

input_image.resize(resize_dims)
img_transforms = EXPERIMENT_ARGS['transform']
transformed_image = img_transforms(input_image)
with torch.no_grad():
    tic = time.time()
    images, latents = run_on_batch(transformed_image.unsqueeze(0), net)
    result_image, latent = images[0], latents[0]
    toc = time.time()
    print('Inference took {:.4f} seconds.'.format(toc - tic))
# Display inversion:
display_alongside_source_image(tensor2im(result_image), input_image)

It seems like you run our encoder correctly.
Generally speaking, our pretrained e4e encoder is specifically designed to balance the tradeoffs existing in the StyleGAN's latent space (See our paper for further details and examples).
By doing so, we lose some reconstruction accuracy to gain more editable latent codes (that can be better used by other existing latent-space manipulation techniques, StyleFlow for example) compared to other inversion methods.
If exact reconstruction is what you seek, direct optimization will always yield the best results, or alternatively, you can control the tradeoff yourself according to your needs.
For example,  you can train the encoder to favor reconstruction over editablity by not using the latent codes discriminator or by tuning the progressive training parameters.

Relevant: https://github.com/rolux/stylegan2encoder/issues/2#issuecomment-570191777


how to get vms in folder

I am trying to get VMs fro specific folder.
my code
from com.vmware.vcenter_client import VM
vm_svc = VM(stub_config)
vm_svc.list(VM.FilterSpec(folders=set(['vm'])))
In the result I got empty list.
What am I doing wrong ?
If don't use filter I get all VMs in venter.

Of course I have, it's the default folder in VMware group "VMs and Templates"

@navi86 Just realized what's the problem. The folders parameter in VM.FilterSpec takes IDs instead of names. You have to get the folder ID first. The below code snippet should work for you:
import ssl
import requests
from vmware.vapi.vsphere.client import create_vsphere_client
from com.vmware.vcenter_client import VM, Folder

session = requests.session()
session.verify = False
client = create_vsphere_client(server='xxxxx',
                               username='xxxxxx',
                               password='xxxxxx',
                               session=session)

folder_filter = Folder.FilterSpec(names=set(['vm']))
folder_id = client.vcenter.Folder.list(folder_filter)[0].folder
vm_filter = VM.FilterSpec(folders=set([folder_id]))
client.vcenter.VM.list(vm_filter)

open
But it doesn't get vms in subfolders.


Correct outside traversal

Change the node ordering in the outside pass and outside maximization algorithms. Add an example tree where this is an issue as well as a simulation/inference check.

What do you think about this @hyanwong ?

Looks good to me, but you can probably squash all the commits into one before merging


[Tracking] Caching GOG not possible due to ssl

Seems that they have indeed moved to HTTPS, Output of SNI-Proxy:
2018-09-10 16:30:22 [::ffff:X.X.X.X]:51136 -> [::]:443 -> <IP_ADDRESS>:443 [cdn-edge-1o-gra-fr-ovh.gogcdn.net] 1648160/1648160 bytes tx 2649/2649 bytes rx 12.621 seconds
2018-09-10 16:30:22 [::ffff:X.X.X.X]:51095 -> [::]:443 -> <IP_ADDRESS>:443 [cdn-edge-1k-rbx-fr-ovh.gogcdn.net] 10110555/10110555 bytes tx 2650/2650 bytes rx 30.921 seconds
2018-09-10 16:30:23 [::ffff:X.X.X.X]:51143 -> [::]:443 -> <IP_ADDRESS>:443 [cdn-edge-1d-sbg-fr-ovh.gogcdn.net] 10457625/10457625 bytes tx 2650/2650 bytes rx 13.084 seconds
2018-09-10 16:30:24 [::ffff:X.X.X.X]:51124 -> [::]:443 -> <IP_ADDRESS>:443 [cdn-edge-1k-rbx-fr-ovh.gogcdn.net] 15883268/15883268 bytes tx 4638/4638 bytes rx 20.078 seconds
2018-09-10 16:30:24 [::ffff:X.X.X.X]:51144 -> [::]:443 -> <IP_ADDRESS>:443 [cdn-edge-3h-waw-pl-ovh.gogcdn.net] 7221384/7221384 bytes tx 2619/2619 bytes rx 13.853 seconds
2018-09-10 16:30:24 [::ffff:X.X.X.X]:51168 -> [::]:443 -> <IP_ADDRESS>:443 [cdn-edge-1d-sbg-fr-ovh.gogcdn.net] 1119658/1119658 bytes tx 2618/2618 bytes rx 0.785 seconds
2018-09-10 16:30:24 [::ffff:X.X.X.X]:51157 -> [::]:443 -> <IP_ADDRESS>:443 [cdn-edge-3i-waw-pl-ovh.gogcdn.net] 2833037/2833037 bytes tx 3629/3629 bytes rx 5.911 seconds
2018-09-10 16:30:24 [::ffff:X.X.X.X]:51166 -> [::]:443 -> <IP_ADDRESS>:443 [cdn-edge-1o-gra-fr-ovh.gogcdn.net] 3072724/3072724 bytes tx 2619/2619 bytes rx 1.950 seconds
2018-09-10 16:30:24 [::ffff:X.X.X.X]:51164 -> [::]:443 -> <IP_ADDRESS>:443 [cdn-edge-1k-rbx-fr-ovh.gogcdn.net] 3653650/3653650 bytes tx 2619/2619 bytes rx 2.302 seconds
2018-09-10 16:30:24 [::ffff:X.X.X.X]:51162 -> [::]:443 -> <IP_ADDRESS>:443 [cdn-edge-1o-gra-fr-ovh.gogcdn.net] 2095924/2095924 bytes tx 2619/2619 bytes rx 2.606 seconds
2018-09-10 16:30:24 [::ffff:X.X.X.X]:51161 -> [::]:443 -> <IP_ADDRESS>:443 [cdn-edge-3c-waw-pl-ovh.gogcdn.net] 1685072/1685072 bytes tx 2618/2618 bytes rx 2.870 seconds
2018-09-10 16:30:24 [::ffff:X.X.X.X]:51156 -> [::]:443 -> <IP_ADDRESS>:443 [cdn-edge-3i-waw-pl-ovh.gogcdn.net] 4652808/4652808 bytes tx 2626/2626 bytes rx 5.949 seconds
2018-09-10 16:30:24 [::ffff:X.X.X.X]:51127 -> [::]:443 -> <IP_ADDRESS>:443 [cdn-edge-1i-rbx-fr-ovh.gogcdn.net] 14089884/14092584 bytes tx 3629/3629 bytes rx 18.234 seconds

No traffic hit the GOG container.
We can no longer cache GOG - Perhaps we can reach out to them.

um it seems cdn.gog.com can still be accessed without https but does the gog galaxy client force https?

Well maybe close this issue then since this will never be supported again

@nutterthanos we leave a few of these open otherwise we get inundanted with new issues about "gog doesn't work" (and similar). Thats why this is tagged with [Tracking]. If it ever resolves we can then close this issue

Ah I get you


Image pull failure on ghcr.io using k3s

Description
Running containerd installed using k3s. Specified an image hosted on ghcr.io (ghcr.io/open-webui/open-webui:main) for a container and keep getting ErrImagePull. At the same time, trying to pull the image directly on the node using crictl pull AND ctr image pull. All these methods fail with the same exact message:
failed to resolve reference "ghcr.io/open-webui/open-webui:main": failed to do request: Head "https://ghcr.io/v2/open-webui/open-webui/manifests/main": dial tcp: lookup ghcr.io: Try again

My intuition tells me that this is some DNS related issue but running nslookup ghcr.io on the node successfully returns a record and am even able to successfully curl the URL with a response. Pulling images on other domains work (i.e. docker hub). Any suggestions would be most appreciated!
$ crictl version
Version: 0.1.0
RuntimeName: containerd
RuntimeVersion: v1.7.20-k3s1
RuntimeApiVersion: v1

Steps to reproduce the issue

Install k3s using their quick start guide
Try to run a ghcr.io pod kubectl run --image ghcr.io/open-webui/open-webui:main open-webui
Get pods (kubectl get pods) to see the ErrImagePull

Describe the results you received and expected
Expected to see the image pulled successfully. Repository is public.
Received an ErrImagePull with the message of:
failed to resolve reference "ghcr.io/open-webui/open-webui:main": failed to do request: Head "https://ghcr.io/v2/open-webui/open-webui/manifests/main": dial tcp: lookup ghcr.io: Try again

What version of containerd are you using?
v1.7.20-k3s1
Any other relevant information
No response
Show configuration if it is related to CRI plugin.
$ cat /var/lib/rancher/k3s/agent/etc/containerd/config.toml
# File generated by k3s. DO NOT EDIT. Use config.toml.tmpl instead.
version = 2

[plugins."io.containerd.internal.v1.opt"]
  path = "/var/lib/rancher/k3s/agent/containerd"
[plugins."io.containerd.grpc.v1.cri"]
  stream_server_address = "<IP_ADDRESS>"
  stream_server_port = "10010"
  enable_selinux = false
  enable_unprivileged_ports = true
  enable_unprivileged_icmp = true
  sandbox_image = "rancher/mirrored-pause:3.6"

[plugins."io.containerd.grpc.v1.cri".containerd]
  snapshotter = "overlayfs"
  disable_snapshot_annotations = true

[plugins."io.containerd.grpc.v1.cri".cni]
  bin_dir = "/var/lib/rancher/k3s/data/e50868881d9744d0d0027dda983507e867b3787482eb00005d97239d9aa501a5/bin"
  conf_dir = "/var/lib/rancher/k3s/agent/etc/cni/net.d"

[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.runc]
  runtime_type = "io.containerd.runc.v2"

[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.runc.options]
  SystemdCgroup = true

[plugins."io.containerd.grpc.v1.cri".registry]
  config_path = "/var/lib/rancher/k3s/agent/etc/containerd/certs.d"

try curl https://ghcr.io/v2/open-webui/open-webui/manifests/main, if your network not work, it will throw this error

tcp: lookup and nslookup are different things. It may be that your network cannot connect to ghcr.io. You can try running ping ghcr.io  to determine if there is a network issue.


[Bug]: Translations are missing

Preflight Checklist

[X] I could not find a solution in the documentation, the existing issues or discussions
[X] I have joined the ZITADEL chat

Environment
Self-hosted
Describe the bug
I found some hard coded labels. Maybe there are more.
Relates to #5072, #4393.
To reproduce
Go to Branding > Colors
Screenshots

Expected behavior
No response
Version
No response
Operating System
No response
Relevant Configuration
No response
Additional Context
No response

@hifabienne could you assign this issue to me?


docker in docker: Error: there is no registered task type 'docker-run'

When using the docker in docker feature docker tasks are not detected:
The output gives:
Error: there is no registered task type 'docker-build'. Did you miss installing an extension that provides a corresponding task provider?
Error: there is no registered task type 'docker-run'. Did you miss installing an extension that provides a corresponding task provider?

My suspicion is that the tasks.json is parsed before the addon is installed.

devcontainer:
{
	"name": "Python 3",
	// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
	"image": "mcr.microsoft.com/devcontainers/python:0-3.11",

	// Features to add to the dev container. More info: https://containers.dev/features.
	"features": {
		"ghcr.io/devcontainers/features/docker-in-docker:2": {}
	},

	// Configure tool-specific properties.
	"customizations": {
		// Configure properties specific to VS Code.
		"vscode": {
			"settings": {
        "python.linting.pylintEnabled": true
      },
			"extensions": [
				"dbaeumer.vscode-eslint"
			]
		}
	}

tasks:
{
	"version": "2.0.0",
	"tasks": [
		{
			"type": "docker-build",
			"label": "redacted1-build",
			"platform": "python",
			"dockerBuild": {
				"tag": "redacted2:latest",
				"dockerfile": "${workspaceFolder}/dockerredacted1/Dockerfile",
				"context": "${workspaceFolder}",
				"pull": true
			},
			"problemMatcher": [],
			"group": {
				"kind": "build",
				"isDefault": true
			}
		},
		{
			"type": "docker-run",
			"label": "redacted1-run",
			"dockerRun": {
				"volumes": [
				]
			},
			"dependsOn": [
				"redacted1-build"
			],
			"python": {
				"file": "run.py"
			}
		}
	]
}

A fix is to reload the window using Developer: Reload. But if someone builds the container for the first time the python extension is not found at task detection.

I could reproduce the same issue with your configuration.
I wonder if this issue is related to https://github.com/microsoft/vscode/issues/173184 and https://github.com/microsoft/vscode/issues/173384. Can you comment on the issues linked ?

https://github.com/microsoft/vscode/issues/173384 seems to be related as it talks about timeouts. The problem is that the tasks are processed before the extensions are fully installed

@samruddhikhandale is there any timeline on fixing this?

The VS Code issues should provide a better timeline for the fix.
// cc @chrmarti

@cboostcvanrooijen Does it start working if you wait for the extension to finish installing or is the window reload the only workaround?
This might be a separate issue from the above linked ones in VS Code tasks. /cc @meganrogge

what version are you using? I believe this was already fixed, can you try insider's?

@chrmarti I'm in a similar situation.  In my case, the only workaround is to reload window.
In my case, I'm working in a multi-root workspace.  In one root folder I have a type "shell" task that is run on "folderOpen" and in an other root folder I have some type "docker-compose" tasks.
The project is opened in a devcontainer environment.
When the devcontainer is build, the "shell" task is run and I can see following log in Tasks output:
Error: there is no registered task type 'docker-compose'. Did you miss installing an extension that provides a corresponding task provider?
Error: there is no registered task type 'docker-compose'. Did you miss installing an extension that provides a corresponding task provider?
Error: there is no registered task type 'docker-compose'. Did you miss installing an extension that provides a corresponding task provider?
Error: there is no registered task type 'docker-compose'. Did you miss installing an extension that provides a corresponding task provider?
Error: there is no registered task type 'docker-compose'. Did you miss installing an extension that provides a corresponding task provider?
Error: there is no registered task type 'docker-compose'. Did you miss installing an extension that provides a corresponding task provider?
Activating task providers java

If I open Terminal --> Run Task...  only the "shell" one is included (despite I have waited and checked that all extensions have finished loading, specially the Docker extension).
If I run Develper: Reload Window, then all tasks are listed under Terminal --> Run Task....


Wrong code color when i use .css key to get Object value

VSCode Version:
OS Version: OSX 10.12.4

Steps to Reproduce:
var obj = {};
if(obj[`${name}.css`]) { // vs code render wrong color on this line
  // some code
}

Does this issue occur when all extensions are disabled?: No

This is caused by one of your extensions that contributes to the js grammar. Please file the issue against them

It's vscode-styled-jsx bug. When i remove this extension it work fine.


Incorrect import result for quantized model by gltfpack

I'm trying to get UnityGLTF to work with files compressed using gltfpack but have been getting incorrect results.
For example, this rigged character does not get imported correctly after running gltfpack whereas both gltf Viewer and gltFast import the model correctly before and after quantization. Even something as simple as the Avocado has different results before and after quantization.

UnityGLTF (Original)
UnityGLTF (Quantized)
gltFast (Quantized)

I'm guessing it has something to do with quantization and the extra node transform that's applied by gltfpack, but I can't be sure yet. If I run gltfpack with -noq (disable quantization) then it imports fine.
Unity Version: 2021.3.31f1
UnityGLTF Version: 2.9.0-rc
Any insights would be appreciated!

I guess you are right. Mesh is there, but it get not rendered. But also not in Scene view. I will take a closer look

hm...it seems to be more an scale issue here. When i set the import scale to 65000, then it has the same size as the gltfast import. So maybe it's a quantization issue here

Please only close PRs when the fix has actually landed in a release!


Add .cache/ to .gitignore file.

I think we don't need .cache/ directory in repo. It will be generated automatically.

I fell like that must have come from your config -- I don't have that directory.

@purcell OK, I need to check the code, I am not sure which config cause it.
I just change some key binding in my config https://github.com/lanzhiheng/emacs.d/blob/master/lisp/init-local.el It seems strange.

Happy it's helpful to you. In any case, it should be harmless to merge this change - thanks!

@purcell thanks.


Refactor: removed Result from FieldElement constructor

We apply modulo in the constructor instead.

Already removed ::one and ::zero constructors. Had to add a neutral_element() method for CyclicGroup.


EOL python:3.7 image

Python 3.7 is EOL (#25).

(Action were disabled due to inactivity :facepalm:)


bug: "Should not create replicas on node with non-tolerable taint" fails randomly

What happened:
The e2e test case "Should not create replicas on node with non-tolerable taint" fails randomly with the following error:
rpc error: code = Internal desc = AzVolumeAttachment (pvc-ef917682-bb89-45f5-925f-207531922061-k8s-agentpool1-27221923-0-attachment) created on a wrong node (k8s-agentpool1-27221923-0)

What you expected to happen:
It should pass consistently.
How to reproduce it:
Anything else we need to know?:
Environment:

CSI Driver version:
Kubernetes version (use kubectl version):
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

The test was disable by #284 pending the fix.


Update BRAIDED_GRIFFIN_FEATHER.json

i also forgot a eye so i made a 2nd pr cos idfk how github works


BeforeSuite addMochawesome Context support and DDT improve

BeforeSuite addMochawesome Context support
Add xadd for datatables to ignore this tests in run
Add Data(table).only.Scenario to give ability to launch only Data tests

Thanks! Looks good to me


fix: typing issues in uniswap.py

minor changes to uniswap.py to fix errors found in typecheck test.

Sadly doesn't fix my "TypeError: Unknown Transaction type: 0"


MM-22929 - Updating back button in Account modal

Summary
MM-22929 - Updating back button in Account modal
Ticket Link
https://mattermost.atlassian.net/browse/MM-22929

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-4980.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

Test server destroyed


meta-mender-tegra: Fix delta updates

Mount old and new filesystem as read-only to avoid breaking delta-updates
Signed-off-by: Niels Avonds<EMAIL_ADDRESS>

Looping in @dwalkes

A similar fix is needed in the Zeus branch. I think it would be simpler there, since bind mounts are already being used. It's probably as simple as adding "-o ro" to the mount in the Zeus branch.

Thanks very much @nielsavonds this looks good to me.  We will make sure this is incorporated on the dunfell branch we are currently working in on https://github.com/OE4T/meta-mender-community/pull/1 and get it backported to Zeus from there as well.  I actually haven't tested delta updates myself yet but this is something we need to try.

Note that since f0dcd9100566fe0ee0833ebb89c919beefb62cb3 from zeus, a chroot is used to access the new update payload instead of copying it back.

I don't know exactly what changes, but mounting a filesystem as read-write just once changes the checksum of that filesystem and thus breaks delta updates. I tested this on my host and on the target and got similar results. Since we don't expect to write anything to the new partition anyway, a read-only mount seems safer.

At least in the newer nv_update_engine, it creates an entry_table file in /opt/ota_package https://github.com/OE4T/meta-mender-community/pull/1#issuecomment-671440073 and offhand I'm not sure if it absolutely requires this, or will ignore errors here. So it remains to be seen if we can do this in newer L4T releases or we have to get a little fancier.

Is this good to go @dwalkes ?

Yes, this is good to go into the the warrior branch based on @neilsavonds testing. We still need to figure out what if anything we need to do on later branches.

Thanks, merged.


Partial page results were dropped issue 7

include partial page results

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello @rob-buskens-sp, good catch! This is fixed by https://github.com/sailpoint-oss/powershell-sdk/pull/10. The pagination results needed to be updated in a few areas. Closing this PR.


Toast component missing imports & code

Toast has a missing code from an import and incorrect installation or docs. these are some of the errors I can see, of course, this is easy to fix however it would be nice to have them installed by default.

another issue I ran into is that the toaster component wasn't created so that code was missing
What needs to be added or changed

cva being added to the package.json just like @radix-ui/react-toast
toaster.tsx needs to be created
X icon could have a comment next to it or add the UI library or alternatively, the SVG could be added
cn now this is defined in taxonomy under lib in the utils file again this would be nice to be in the toast.tsx file

"tailwind-merge"  and clsx being added in the package.json

Some of the errors are solved with the the installation steps (Not for a specific component, but the general installation), telling you that you need to install CVA, tailwind and create the cn util, maybe you missed this step? Regarding the Icon, you should change it with whatever icon package you prefer if not using lucide. Why would the cn function be defined in the toats.tsx file, it is meant to be used in various components so I think it fits better in the utils folder, however you can of course move it to where you prefer.
The toaster.tsx might be a bug that is missing from the CLI installation. Anyway this is just my opinion, hopefully the first part helps you fix some of the problems.

Ah ok I completely missed that step as I just skipped to the component as that's all I wanted that is my bad.
However it would still be nice if the cli tool checked those things when adding the component.
And yeh I'm assuming that there is a bug with adding the
toaster.tsxcomponent


Game and Author Operation

Game and Author Operation
in This PR I have implemented:

Create a Game class in a separate .rb file.
Create an Author class with an association to the Item class (in a separate .rb file).
All Game class properties visible in the diagram should be defined and set up in the constructor method.
All Author class properties visible in the diagram should be defined and set up in the constructor method.

Implement methods:

add_item method in the Author class
List of games
List all authors
Add a game
preserved data in .json files.
Create a schema.sql file for games and author's table

Thank you @peterboro for your feedback and for approving my code


Adding fast xml parser

Reason to add

Faster than any other pure JS implementation
don't loose any information in reverse transformation. (xml -> js -> xml)
can be used in NPM package, browser, or CLI

Any update?

Please read and adhere to the contributing guidelines. Thank you 🙌

any update?


Use FindBugs for static code analysis during build

I added FindBugs check to compile phase. It fails when bug with rank 14 and lower is found (these bugs are considered as troubling,  scary, scariest categories).
I also added @Nullable annotation when explicit check for null values is needed.
fixes #18

[INFO] --- findbugs-maven-plugin:3.0.4:check (default) @ euphoria-fluent ---
[INFO] BugInstance size is 0
[INFO] Error size is 0
[INFO] No errors/warnings found

i like this! :) many thanks so far.


One view 2D x-ray image to 3D images

Hello. Thank you for your great job!
I have a question for your code.
I try to convert a 2D x-ray image (only one view) to 3D images.
I just want to know if your code has this function or not.
If it has, then,
do the training data also only require only one view 2D x-ray image?

Hi, thanks for your interest.
I have not tried single-view reconstruction. But I think it is interesting to do that.
Just take a single projection in the pickle data to train by modifying the loaded data here:
https://github.com/caiyuanhao1998/SAX-NeRF/blob/master/src/dataset/tigre_mlg.py#L75
If you find our repo useful, please help us star it, thanks!


lib/oref0-setup/edisonbattery.json overrides ns-loop in lib/oref0-setup/mdt-cgm.json

The template for the edison battery https://github.com/openaps/oref0/blob/4b01147136573aa94765a9b2cdeb1b5785f276c0/lib/oref0-setup/edisonbattery.json#L20 overrides mdt-cgm https://github.com/openaps/oref0/blob/4b01147136573aa94765a9b2cdeb1b5785f276c0/lib/oref0-setup/mdt-cgm.json#L66 and causes get-ns-bg to be called even though it shouldn't for MDT cgm (since it's unlikely that a MDT cgm use will have uploaded cgm to Nightscout another way than through the openaps device - see #287). This can cause problems in identifying the gaps for entry uploads to NS.
I'm not sure if there's an easy fix for this since we want the edison battery behavior but not the get-ns-bg

Could we place the battery-status call in the appropriate place in the mdt-cgm.json, and then make the offending edisonbattery.json get imported before the mdt-cgm.json so the latter overrides?

if we could find a way, to get rid of it ans speed up the uploads would be nice. because it would be nice if it uploaded the CGM to nightscout faster than never being faster than 7 mins old, and normally 10 mins old.

@Bender1061 what I've observed is that there's a delay in the history record being written and I don't think the cgm value is available until several minutes after the cgm record timestamp. I think it may just be a matter of trying to use a history table for something no one anticipated. Do you often see newer history readings on your openaps rig than in nightscout?

CGM readings don't reach the pump on 5 minute boundaries.  It can often be 7 minutes since the last CGM timestamp before the next reading appears. Consistently having CGM data < 7 minutes old would be somewhere between difficult and impossible.

@tmecklem yes I do, at least in monitor/glucose but the ns/glucose does not update near as fast. I think if we made the ns/glucose part of the reformating of the cgm data, would help on that part at least a little

Did this get resolved?


[FRONTEND] Disable mlir llvm dialect optimizations under DISABLE_LLVM…

Disabling mlir llvm dialect optimizations under DISABLE_LLVM_OPT.

@manman-ren this PR is in draft mode. Can you please take a look before I undraft it? Thanks.

Looks good to me!

it only seems to disable some of the llvm dialect optimizations passes so the name will be confusing. What's the use case for this? Doesn't seem like something people would commonly use to debug. Can you tell a bit more about how you think that will help?

I was trying to get an unoptimized llir and PTX file from an end-to-end run to study TTGIR to LLVM transformations. Maybe it's not a common use. I was thinking that optimizations on the MLIR LLVM dialect is also a kind of LLVM optimizations that is orthogonal to Triton passes.

it looks like you only disable cse so this feels very ad hoc

it only seems to disable some of the llvm dialect optimizations passes so the name will be confusing. What's the use case for this? Doesn't seem like something people would commonly use to debug. Can you tell a bit more about how you think that will help?

I was trying to get an unoptimized llir and PTX file from an end-to-end run to study TTGIR to LLVM transformations. Maybe it's not a common use. I was thinking that optimizations on the MLIR LLVM dialect is also a kind of LLVM optimizations that is orthogonal to Triton passes.

it looks like you only disable cse so this feels very ad hoc

I see your point now. Do you think other passes such as add_scf_to_cf should also be disabled? But the compilation wouldn't work without them.

it only seems to disable some of the llvm dialect optimizations passes so the name will be confusing. What's the use case for this? Doesn't seem like something people would commonly use to debug. Can you tell a bit more about how you think that will help?

I was trying to get an unoptimized llir and PTX file from an end-to-end run to study TTGIR to LLVM transformations. Maybe it's not a common use. I was thinking that optimizations on the MLIR LLVM dialect is also a kind of LLVM optimizations that is orthogonal to Triton passes.

it looks like you only disable cse so this feels very ad hoc

I see your point now. Do you think other passes such as add_scf_to_cf should also be disabled? But the compilation wouldn't work without them.

right, the only other pass that would make sense to disable is canonicalization. But overall those are pretty basics pass and CSE merly cleans up the IR so it seems uncommon to want to turn it off

it only seems to disable some of the llvm dialect optimizations passes so the name will be confusing. What's the use case for this? Doesn't seem like something people would commonly use to debug. Can you tell a bit more about how you think that will help?

I was trying to get an unoptimized llir and PTX file from an end-to-end run to study TTGIR to LLVM transformations. Maybe it's not a common use. I was thinking that optimizations on the MLIR LLVM dialect is also a kind of LLVM optimizations that is orthogonal to Triton passes.

it looks like you only disable cse so this feels very ad hoc

I see your point now. Do you think other passes such as add_scf_to_cf should also be disabled? But the compilation wouldn't work without them.

right, the only other pass that would make sense to disable is canonicalization. But overall those are pretty basics pass and CSE merly cleans up the IR so it seems uncommon to want to turn it off

Probably. I don't have a strong opinion. For now I can just comment out the pass for my need.


Update fennel.py

I didn't want to raise an exception in get quote if there is 0 since depending on if it's an order check (dry run) you may just want to see if there are results first?


Callback must be a function

Getting this error when generating a random sequence "Callback must be a function"

You're initializing the generator with a source property that is not a function. The default is to use crypto.pseudoRandomBytes(...) which is almost always the right choice.
If you're still having an issue, post self contained working example that show cases how to reproduce the problem.

I ran into this exact same problem 1 day ago.  (my code hadn't changed, just re-installed the module)
narrowed down the problem to this line:
return cryptoRandomBytes(size, !cb ? null : function (buf){
            return cb(null, buf);
          });

replacing !cb ? null with !cb ? undefined fixes the problem. I am unclear as to what exactly caused the regression.
It is possible the nodejs has a regression.
calling c.randomBytes(10, undefined) works but calling c.randomBytes(10, null) throws an exception.

On Node 9.2 executing the require('rand-token').generate(32) causes an error:
TypeError [ERR_INVALID_CALLBACK]: Callback must be a function
  randomBytes (internal/crypto/random.js:44:11)
  Object.options.source (/rand-token/index.js:61:18)
  Object.generate (/rand-token/index.js:96:29)

@igorgo This should be resolved in the latest published version of the module, v0.4.0. If you're still encountering an error then open a new issue and make sure to include your node version and the module version in the description.

Really ran @sehrope. I was having the same problem on v9 as the @igorgo said.


Hitting 'negative last_insert_rowid' panic with Sqlite

Description
I have a table with a primary ID that is a hash, stored as a signed integer (since unsigned 64 bit is not supported). Auto-increment is turned off for that table.
When storing a new element, if the hash as signed is negative, then sea-orm panics on that line: https://github.com/SeaQL/sea-orm/blob/master/src/executor/execute.rs#L43
Steps to Reproduce

Create an SQlite table with an i64 primary key: https://github.com/nitnelave/lldap/blob/c64d32e2c0cc698c61ca40e8364ab0cd7934cd46/server/src/domain/model/jwt_refresh_storage.rs#L12
Insert a negative value.

Expected Behavior
Since auto-increment is turned off for that table, last_insert_id should probably not be called to avoid a panic.
Actual Behavior
Panic.
Reproduces How Often
Always.
Versions
Using sea-orm 0.10.3 (no other version override). Running on alpine, using the bundled Sqlite.
Additional Information
The query, for reference: https://github.com/nitnelave/lldap/blob/c64d32e2c0cc698c61ca40e8364ab0cd7934cd46/server/src/infra/sql_backend_handler.rs#L49

Hey @nitnelave, interesting! I never thought anyone could hit this panic.
You're right, since we have auto increment disabled, the primary key value should be given and invokcation of last_insert_id() method can be avoided.
https://github.com/SeaQL/sea-orm/blob/d80e61ed7e2991702a4fc5e95f105ffc16ea609c/src/executor/insert.rs#L128-L161

Small style note: a match for a boolean? Why not a if-else block?
Also, the nested match just below can probably be re-written as a match (last_insert_id, last_insert_id_opt) to reduce nesting.