x/website: Found an important typo in the text on first tutorial page.

What is the URL of the page with the issue?
https://go.dev/doc/tutorial/create-module
What is your user agent?
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:97.0) Gecko/20100101 Firefox/97.0

Screenshot
not needed

What did you do?
I tried to learn about golang, and read the first Tutorial page "Tutorial: Create a Go module".
At the end of the page it is explained with the sentence "In Go, the := operator is a shortcut for declaring..."
I found it very confusing that the following example does not contain a colon at all.
"message = fmt.Sprintf("Hi, %v. Welcome!", name)"
But, in the example above there is a colon.
"message := fmt.Sprintf("Hi, %v. Welcome!", name)"
That's how I finally understood that part.
That's just a small typo I think, but as a programming starter (as me) it can be very difficult to understand.
If ever this is NOT a typo, I hope someone could explain me the meaning of this part.

What did you expect to see?
A colon
What did you see instead?
nothing

If I am understanding this right, you are referring to the following piece of code on the page:

Yes.
Under "5. Paste the following code into your greetings.go file and save the file. " they use the declaration with a colon ":=" but later it is used without colon.
I don't understand the difference.
[Please someone confirm if that's right]
If I first declare a variable as "existant", then I dont use the colon. I may "fill" it later or leave it empty.
If I want to declare and "fill" the variable at the same time, I need to use the colon ":" just before the equal sign ":="

The tutorial is correct.
Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.
For questions please refer to https://github.com/golang/go/wiki/Questions

The tutorial is correct.

If you can't explain an answer you admit that you don't understand the topic.
This is one of the least professional answers I received since months. Congrats.

@differentstuff I'm sorry you feel disappointed.  We've learned over the years that the GitHub issue tracker is a poor place for answering questions.  The Go project has several active forums with more people who will respond faster and more interactively.  So we direct people with questions to those forums, rather than the issue tracker.  See https://go.dev/wiki/Questions.  This has been a clearly better experience for most Go users.  I'm sorry it doesn't feel that way in this instance.
In Go a := is used to declare and initialize a variable.  A = is used to assign to an existing variable that is already declared, either through an earlier := or a var.

In Go

Thank you for the explanation. That confirms my question.

We've learned over the years...

I totally understand the decission. I don't criticize this part.
There's nothing wrong closing a request that's not correct; as I learned mine is.
Whereas it should be normal to explain "why". Or where the mistake was.
Just saying "you're wrong" doesn't help. "You're wrong, because you misunderstood something. The tutorial is correct." would at least give a hint why. (Even a simple "Yes" would have at least confirmed my doubts.)


Fix: asumed 'id' as primary key name

It was assuming 'id' as primary key name

You're totally right, @manuelbarrero .
Thanks a lot for the fix. Merged it.
Cheers!


Revert "[Warhammer 4e Character Sheet] Channel button label fix"

Reverts Roll20/roll20-character-sheets#8327
Sorry can you please revert this change ASAP.
typo is breaking the JS code

Character Sheet Info Roll20 Internal Use only.


[TableSortLabel] Remove sort icon when not active

Table sort labels reserve space for the sort icon even when the column isn't the active sort. This prevents layout changes when clicking on a column for sorting, but this also uses horizontal space. I think the icon should be hidden rather than of 0% opacity.

[x] This is a v1.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
When a table header is not active for sort, the arrow is hidden (with `display: 'none'), i.e. it takes no horizontal space
Current Behavior
When a table header is not active for sort, the arrow is displayed, but with 0% opacity. If this actually hides the arrow, it also uses horizontal space.
Examples
Material Design doesn't specify that the space for the arrow should be reserved. I understand that it helps for a nicer animation (by transitioning the opacity), but the effect on horizontal space it too high a price.

Context
Especially for number columns, where the header is often larger than the content, horizontal space is sparse. Imagine a table with many columns, each containing only numbers. the spacing between each column (due to the space reserved for the arrow if active) makes the table too large to fit in one screen without scrolling

Note that this is achievable in userland by passing a custom classes to the <TableSortLabel>:
const styles = {
    icon: {
        display: 'none',
    },
    active: {
        '& $icon': {
            display: 'inline',
        },
    },
};

I just think it should be the default.

And another 2c: I understand that having the space for the arrow reserved avoids the table layout to change when the user clicks on a table header. But in many cases (when a table only displays a subset of the content for performance reason), reordering the table will load new content with, and this will modify the table layout anyway.

@fzaninotto Thanks for opening this issue. It's definitely challenging the current tradeoff. I think that you put it very well in this sentence:

This prevents layout changes when clicking on a column for sorting, but this also uses horizontal space.

Now, if we change the default, we will have people complaining the other way around. In this case, I think that we can only move the discussing forward by trying it out or with a benchmark (looking at the other implementations) as a proxy for understanding what works best. So, let's benchmark:

angular material 2: reserved space
vuetify: reserved space
devexpress: no reserved space
more idea?

One thing I have learn during this benchmark is how people can leverage table-layout: fixed; CSS to get ride of the layout change and to make large tables render faster.
I have added the waiting for users upvotes tag. Looking at your demo, it seems you would take advantage of rendering less data or making the table overflow to create some space between the columns. Please upvote this issue if you are looking for such change. We will prioritize our effort based on the number of upvotes.

One more thought. We could add an option to have this behavior. I think that it's generic enough to be considered. What do you think about it?

I agree with the property, makes all sides happy.

Also, why did you close the issue if it's waiting for upvotes?

Because I believe it's not a direction we should be taking, better be upfront about it than to pretend we might accept a pull request. Yet, I want the community to weight their voice. From my experience the open / close status of an issue doesn't change much the bottom line.
https://github.com/mui-org/material-ui/issues?q=is%3Aissue+label%3A"waiting+for+users+upvotes"+is%3Aclosed

That'd be great.

Alright, let's add a property for it 👍

Now it's not waiting for users upvotes anymore but it's still closed... What does that mean?

My bad.

Hello @fzaninotto I am new to material-ui and trying to contribute.  I tried to pass in the custom style as you have mentioned by passing in a custom style
const styles = {
    icon: {
        display: 'none',
    },
    active: {
        '& $icon': {
            display: 'inline',
        },
    },
};

I am trying to do this in the examples and I'm using the EnhancedTable.js example.  Maybe I'm trying it wrong, however what I'm trying to do is the following
                <TableSortLabel
                    active={orderBy === row.id}
                    style={styles}
                    direction={order}
                    onClick={this.createSortHandler(row.id)}
                  >

This does not work as expected since I'm passing in classes actually.  When I try to pass in the same using classes also it does not work, since classes are expecting class names as strings.  Since I'm new to this its very likely that I'm doing something wrong.  Any help.


[Augmentations] Analyzer error when augmenting representation variable

It is an error in the analyzer to augment extension type representation variable with a variable.
extension type ET(int v) {}

augment extension type ET(int v) {
  augment final int v = 42; // COMPILE_TIME_ERROR.EXTENSION_TYPE_DECLARES_INSTANCE_FIELD
}

I didn't find in the spec any statement that makes augmenting of the representation variable an error. So, I guess, it is allowed and there should be no such error.
See, for example, https://github.com/dart-lang/co19/blob/master/LanguageFeatures/Augmentation-libraries/augmenting_getters_setters_with_variable_A02_t01.dart
@jakemac53 @munificent to confirm.

These are not variables, they are the representation type, which is a different thing (even though they look like variables somewhat). This definitely should be an error (I have no idea what it would mean otherwise).
Similarly I think you should not be allowed to augment it with a getter (or setter, but there is no setter).


I can filter on WoS type of a publication record

Story
As a librarian, I can filter on the WoS type of a publication so I can see which records need follow-up.
Filters depend on the type that has been imported or added.
Context old Biblio

Success criteria

[ ] Available for publications
View other success criteria on https://github.com/ugent-library/biblio-backend/issues/519

Related
Editing WoS type #518
Implementation and context
View design and components on https://github.com/ugent-library/biblio-backend/issues/519

See https://github.com/ugent-library/biblio-backend/pull/552 (closed)


Cant download m3u firle from GD!

Hi,
Cant add the file.
When I'm on the file, I cant add it, progamme doesnt allow me to do it.

How areyou trying to add it?
On Apr 15, 2017 3:05 PM, "MikeFromUkraine"<EMAIL_ADDRESS>wrote:

Hi,
Cant add the file.
When I'm on the file, I cant add it, progamme doesnt allow me to do it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Fleker/CumulusTV/issues/279, or mute the thread
https://github.com/notifications/unsubscribe-auth/ADI585Tjfee5ABkDURJhh2vh_AWEogqQks5rwRT1gaJpZM4M-bq4
.

                                                                                When I'm on the file, I can't choice it. Just to cancel. ( in attachment)  Even can't add unless. When I'm adding url - the programme says it's updating through the Google drive.I can't understand the logic.When I'm adding the same url s through the iptv service - url works well.                                                                                Sent from my BlackBerry 10 smartphone.                                                                                From: NickSent: Неділя, 16 квітня 2017 р. 01:03To: Fleker/CumulusTVReply To: Fleker/CumulusTVCc: MikeFromUkraine; AuthorSubject: Re: [Fleker/CumulusTV] Cant download m3u firle from GD! (#279)How areyou trying to add it?

On Apr 15, 2017 3:05 PM, "MikeFromUkraine"<EMAIL_ADDRESS>wrote:

Hi,
Cant add the file.
When I'm on the file, I cant add it, progamme doesnt allow me to do it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Fleker/CumulusTV/issues/279, or mute the thread
https://github.com/notifications/unsubscribe-auth/ADI585Tjfee5ABkDURJhh2vh_AWEogqQks5rwRT1gaJpZM4M-bq4
.

—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/Fleker/CumulusTV","title":"Fleker/CumulusTV","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/Fleker/CumulusTV"}},"updates":{"snippets":[{"icon":"PERSON","message":"@Fleker in #279: How areyou trying to add it?\n\nOn Apr 15, 2017 3:05 PM, "MikeFromUkraine"<EMAIL_ADDRESS>wrote:\n\n\u003e Hi,\n\u003e\n\u003e Cant add the file.\n\u003e When I'm on the file, I cant add it, progamme doesnt allow me to do it.\n\u003e\n\u003e —\n\u003e You are receiving this because you are subscribed to this thread.\n\u003e Reply to this email directly, view it on GitHub\n\u003e \u003chttps://github.com/Fleker/CumulusTV/issues/279\u003e, or mute the thread\n\u003e \u003chttps://github.com/notifications/unsubscribe-auth/ADI585Tjfee5ABkDURJhh2vh_AWEogqQks5rwRT1gaJpZM4M-bq4\u003e\n\u003e .\n\u003e\n"}],"action":{"name":"View Issue","url":"https://github.com/Fleker/CumulusTV/issues/279#issuecomment-294320401"}}}

                                                                                I can't even add the url.It doesn't appear with the channel list nowhere                                                                                Sent from my BlackBerry 10 smartphone.                                                                                From: Mikhail SSent: Неділя, 16 квітня 2017 р. 08:54To: Nick; Fleker/CumulusTVCc: AuthorSubject: Re: [Fleker/CumulusTV] Cant download m3u firle from GD! (#279)                                                                                When I'm on the file, I can't choice it. Just to cancel. ( in attachment)  Even can't add unless. When I'm adding url - the programme says it's updating through the Google drive.I can't understand the logic.When I'm adding the same url s through the iptv service - url works well.                                                                                Sent from my BlackBerry 10 smartphone.                                                                                From: NickSent: Неділя, 16 квітня 2017 р. 01:03To: Fleker/CumulusTVReply To: Fleker/CumulusTVCc: MikeFromUkraine; AuthorSubject: Re: [Fleker/CumulusTV] Cant download m3u firle from GD! (#279)How areyou trying to add it?

On Apr 15, 2017 3:05 PM, "MikeFromUkraine"<EMAIL_ADDRESS>wrote:

Hi,
Cant add the file.
When I'm on the file, I cant add it, progamme doesnt allow me to do it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Fleker/CumulusTV/issues/279, or mute the thread
https://github.com/notifications/unsubscribe-auth/ADI585Tjfee5ABkDURJhh2vh_AWEogqQks5rwRT1gaJpZM4M-bq4
.

—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/Fleker/CumulusTV","title":"Fleker/CumulusTV","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/Fleker/CumulusTV"}},"updates":{"snippets":[{"icon":"PERSON","message":"@Fleker in #279: How areyou trying to add it?\n\nOn Apr 15, 2017 3:05 PM, "MikeFromUkraine"<EMAIL_ADDRESS>wrote:\n\n\u003e Hi,\n\u003e\n\u003e Cant add the file.\n\u003e When I'm on the file, I cant add it, progamme doesnt allow me to do it.\n\u003e\n\u003e —\n\u003e You are receiving this because you are subscribed to this thread.\n\u003e Reply to this email directly, view it on GitHub\n\u003e \u003chttps://github.com/Fleker/CumulusTV/issues/279\u003e, or mute the thread\n\u003e \u003chttps://github.com/notifications/unsubscribe-auth/ADI585Tjfee5ABkDURJhh2vh_AWEogqQks5rwRT1gaJpZM4M-bq4\u003e\n\u003e .\n\u003e\n"}],"action":{"name":"View Issue","url":"https://github.com/Fleker/CumulusTV/issues/279#issuecomment-294320401"}}}

Is there any solution or you've left it like it is?

I'm currently unsure of how to solve
On Sat, Apr 22, 2017, 8:49 AM MikeFromUkraine<EMAIL_ADDRESS>wrote:

Is there any solution or you've left it like it is?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Fleker/CumulusTV/issues/279#issuecomment-296371059,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADI5824bSHtAEb-kCNF5CkZkBZYKJku5ks5ryfdQgaJpZM4M-bq4
.


Documentation question: what are all the log topics?

Hi, sorry if this is the wrong place to ask this (I can't seem to get onto the slack channel without having an arango email).
On the documentation page "Log levels" it says:

For each log topic (authentication, cluster, queries, etc.), you can configure the lowest level to log.

The documentation says there are log topics, and it identifies three of them and indicates there are others.  But the documentation neither indicates what those other topics are, nor provides any reference to a place where a comprehensive list of log topics can be accessed.  I've tried internet searching and also the "AI" chatbot on the documentation site, with no success.
Is there a complete list of ArangoDB log topics it in the documentation?  If so, I suggest including a link to it on the "Log levels" page.  If not, I suggest considering whether adding that information might potentially be a net benefit for readers who want to know what the etc in “authentication, cluster, queries, etc.” above refers to.

The description of the --log.level startup option has a list of log topics, which you can access with arangod --help-log and also see here: https://docs.arangodb.com/stable/components/arangodb-server/options/#--loglevel
You can also find a list in the HTTP API docs, but unfortunately without proper descriptions - for each log message, a topic is set by an engineer, but there is some leeway and ambiguity which makes it difficult to capture what topic is used when:
https://docs.arangodb.com/stable/components/arangodb-server/options/#--loglevel
Adding a link as you suggest to either of the above pieces of content is a good suggestion, thanks!

Addressed by

https://github.com/arangodb/docs-hugo/pull/570
https://github.com/arangodb/docs-hugo/commit/f63648f4069d0dc35826c55d84c748627464453d
https://github.com/arangodb/docs-hugo/pull/579 (for 3.11)


Negative numbers in number field

Cannot enter negative numbers into number/value fields

Thanks for your feedback. Fixed in #26.


No response from host https://ssh.github.com/... Client network socket disconnected before secure TLS connection was established

Extension version: v0.17.0
VSCode Version:

1.46.1
cd9ea6488829f560dc949a8b2fb789f3cdc05f5d
x64

OS: Ubuntu 18.04 LTS
Node.js: 14.4.0

Steps to Reproduce:
As soon as vs code is opened, the extension starts to run, and is unable to connect to github. The full log of the issue from the OUTPUT tab is (emphasis mine):
[Info] Looking for git repository
[Info] Git repository found, initializing review manager and pr tree view.
[Info] Review> Validate state in progress
[Info] Review> Validating state...

### (emphasis mine)
[Info] GitHubServer> No response from host https://ssh.github.com/<org>/<repo>: Client network socket disconnected before secure TLS connection was established
###

[Info] No remote with name 'origin' found. Please update your 'githubPullRequests.remotes' setting.
[Info] No remote with name 'upstream' found. Please update your 'githubPullRequests.remotes' setting.
[Info] No GitHub remotes found
[Info] Review> no matching pull request metadata found for current branch master

Are you using a proxy? Can you check the value of your HTTP_PROXY and HTTPS_PROXY environment variables?

@RMacfarlane not using a proxy, just at home, using my wifi. This worked just fine a couple of weeks ago, so either something has changed in the plugin or vs-code, or my ISP is playing tricks on me.
As a side note, I do have the following set up in my .gitconfig to help me in cases where particular workpace wifi have ssh disabled:
[url<EMAIL_ADDRESS>	insteadOf = https://github.com/

Although, to reiterate, this worked fine a couple weeks ago.

Ran into same problem, what I have observed is using HTTPS instead of SSH and re-installing the extension solved the issue.
Now I am able to see the PR's

I think this is a duplicate of https://github.com/microsoft/vscode-pull-request-github/issues/1656


Why all the websites deployed using heroku stopped working

Installed libraries and their versions

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
Problem
I was trying to deploy using heroku but I'm getting an 503 error and when i searched for the problem I noticed that all the apps that uses heroku are giving the same error including the demo website on the official website

i had to install tslib and everything worked out

i had to install tslib and everything worked out


Naming collision detected by packager when using cocoapods

Ran into this after upgrading from 0.11.0 to both 0.12.0 and 0.13.0-rc.
This error didn't occur before as naming collisions were silently allowed, however now that an error is thrown I'm seeing this.
I have a pre-existing iOS app and I've integrated RN into it via Cocoapods. I also have my JavaScript source files using their own node_modules folder. My directory structure looks like this:
app/
  ios/
     Pods/
        React/
           node_modules/
  node_modules/
  src/
     index.ios.js
  package.json

When I now run the packager it reads the file system and reads the files found in both node_modules, which both have react-native installed and thus cause a name collision (as they're more or less duplicates).
I've resolved this when running the development server via:
./node_modules/react-native/packager/packager.sh --projectRoots `pwd`/src --projectRoots `pwd`/node_modules

However when trying to use the bundler it always implicitly adds the root folder as a project root, with no way to augment it or ignore a folder.
Happy to be told I'm 'doing it wrong' but I don't feel like this layout is completely abnormal.

Good point. We might be better off pulling RN from the pod repo BUT keeping CocoaPods support alive in the form of a local podspec. The idea is that you get RN from npm and in your Podfile link to "./node_modules/react-native/React.podspec" so you can still use CocoaPods.
@hswolff would you mind giving that a try and seeing if it fixes your problem and unblocks you? If so then I'm leaning towards having this be the way that people use RN with CocoaPods.

That did the trick!
I updated my Podfile to look like this:
pod 'React', :path => '../node_modules/react-native'
  pod 'React/ART', :path => '../node_modules/react-native'
  pod 'React/RCTActionSheet', :path => '../node_modules/react-native'
  pod 'React/RCTAdSupport', :path => '../node_modules/react-native'
  pod 'React/RCTGeolocation', :path => '../node_modules/react-native'
  pod 'React/RCTImage', :path => '../node_modules/react-native'
  pod 'React/RCTNetwork', :path => '../node_modules/react-native'
  pod 'React/RCTPushNotification', :path => '../node_modules/react-native'
  pod 'React/RCTSettings', :path => '../node_modules/react-native'
  pod 'React/RCTText', :path => '../node_modules/react-native'
  pod 'React/RCTVibration', :path => '../node_modules/react-native'
  pod 'React/RCTWebSocket', :path => '../node_modules/react-native'
  pod 'React/RCTLinkingIOS', :path => '../node_modules/react-native'

I used the Cocoapods podfile documentation
Using the files from a local path section for the proper syntax.
Bundling now works without issue and building from Xcode using this set-up worked as well.

Cool, check out the :subspecs key too, which lets you accomplish the same thing but with a little less verbosity.

In summary -- use the local podspec in your node_modules instead of installing from CocoaPods.

Oooh awesome, nice suggestion w/ :subspecs @ide  - thanks!
Updated final version:
pod 'React', :path => '../node_modules/react-native',
    :subspecs => [
      'ART',
      'RCTActionSheet',
      'RCTAdSupport',
      'RCTGeolocation',
      'RCTImage',
      'RCTNetwork',
      'RCTPushNotification',
      'RCTSettings',
      'RCTText',
      'RCTVibration',
      'RCTWebSocket',
      'RCTLinkingIOS'
    ]

I have a similar issue #3558 but am not using Cocoapods, this happened after updating from 0.12.0-rc to 0.13.0-rc

@hswolff I am using locally linked Pods as suggested above, but still getting this:
Error building DependencyGraph:
 Error: Naming collision detected: /Users/Param/Documents/my-app-master/Pods/React/Libraries/ActionSheetIOS/ActionSheetIOS.js collides with /Users/Param/Documents/my-app-master/node_modules/react-native/Libraries/ActionSheetIOS/ActionSheetIOS.js

I believe you did not run into this at that time because the packager did not follow symlinks, but now it does!


hubble-relay: failed to create gRPC client

Bug report
After upgrading from Cilium v1.9.7 to Cilium v1.10.0 hubble-relay stopped working: it can not connect to node:4244.
I did not change anything in Helm Chart values.yaml file, except Chart version replace.
I thought issue caused :

by CiliumNetworkPolicy -> removed -> nothing changed.
relay tls server is needed, so enabled option hubble.relay.tls.server.enabled: true > rerun cronjob -> killed hubble-relay Pod -> nothing changed.

Sample log lines:

level=info msg=Connecting address="<IP_ADDRESS>:4244" hubble-tls=true peer=prod-k8s-master-3 subsys=hubble-relay
level=warning msg="Failed to create gRPC client" address="<IP_ADDRESS>:4244" error="context deadline exceeded" hubble-tls=true next-try-in=10s peer=prod-k8s-master-3 subsys=hubble-relay

next-try-in is constantly increasing but nothing helped.
General Information

Cilium version (run cilium version)

Client: 1.10.0 952d9d3 2021-05-19T18:42:32+02:00 go version go1.16.4 linux/amd64
Daemon: 1.10.0 952d9d3 2021-05-19T18:42:32+02:00 go version go1.16.4 linux/amd64

Kernel version (run uname -a)

Linux prod-k8s-master-3 5.10.29-talos #1 SMP Wed Apr 28 14:43:26 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Orchestration system version in use (e.g. kubectl version, ...)

Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.1", GitCommit:"5e58841cce77d4bc13713ad2b91fa0d961e69192", GitTreeState:"clean", BuildDate:"2021-05-12T14:18:45Z", GoVersion:"go1.16.4", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.1", GitCommit:"5e58841cce77d4bc13713ad2b91fa0d961e69192", GitTreeState:"clean", BuildDate:"2021-05-12T14:12:29Z", GoVersion:"go1.16.4", Compiler:"gc", Platform:"linux/amd64"}

Link to relevant artifacts (policies, deployments scripts, ...)
N/A

Generate and upload a system zip:

curl -sLO https://git.io/cilium-sysdump-latest.zip && python cilium-sysdump-latest.zip

Can not attach cilium-sysdump - file size is 52M
How to reproduce the issue
Do not know.

I am unable to reproduce. Could you please share your Helm install options (at least the Hubble section) as well as the upgrade command?

Sure, @rolinh
Cilium installation and upgrading is managed by ArgoCD.
Chart.yaml
apiVersion: v2
appVersion: "1.0"
description: Helm chart for Cilium
name: cilium
version: 0.0.1
dependencies:
- name: cilium
  version: 1.10.0
  repository: "@cilium"

values.yaml
cilium:
  bpf:
    policyMapMax: 40960
  hubble:
    enabled: true
    metrics:
      enabled:
      - drop:sourceContext=pod;destinationContext=pod
      - icmp
      - tcp
      - flow
    relay:
      enabled: true
    serviceMonitor:
      enabled: true
    tls:
      enabled: true
      auto:
        enabled: true
        method: cronJob
        certValidityDuration: 70
        schedule: "0 0 1 */2 *"
    ui:
      enabled: true
      backend:
        resources:
          limits:
            cpu: 1000m
            memory: 128Mi
          requests:
            cpu: 100m
            memory: 32Mi
      frontend:
        resources:
          limits:
            cpu: 1000m
            memory: 160Mi
          requests:
            cpu: 100m
            memory: 96Mi
  operator:
    replicas: 2
    prometheus:
      enabled: true
      serviceMonitor:
        enabled: true
  prometheus:
    enabled: true
    serviceMonitor:
      enabled: true

hubble-relay-557d7cb747-tm9br-hubble-relay-20210528-185956.log

Ah, I see that you're using the cronjob method for cert generation, I'll try to reproduce again.
Did you encounter any issue with Helm during the upgrade? Asking because issue #16316 might be related.

ArgoCD did not report any issue during Cilium upgrade.
Here is the current manifest of cronjob method for cert generation:
apiVersion: batch/v1
kind: CronJob
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"batch/v1beta1","kind":"CronJob","metadata":{"annotations":{},"labels":{"app.kubernetes.io/instance":"cilium","k8s-app":"hubble-generate-certs"},"name":"hubble-generate-certs","namespace":"kube-system"},"spec":{"concurrencyPolicy":"Forbid","jobTemplate":{"spec":{"template":{"metadata":{"labels":{"k8s-app":"hubble-generate-certs"}},"spec":{"containers":[{"args":["--cilium-namespace=kube-system","--hubble-ca-reuse-secret=true","--hubble-ca-secret-name=hubble-ca-secret","--hubble-ca-generate=true","--hubble-ca-validity-duration=6048000s","--hubble-ca-config-map-create=true","--hubble-ca-config-map-name=hubble-ca-cert","--hubble-server-cert-generate=true","--hubble-server-cert-common-name=*.default.hubble-grpc.cilium.io","--hubble-server-cert-validity-duration=6048000s","--hubble-server-cert-secret-name=hubble-server-certs","--hubble-relay-client-cert-generate=true","--hubble-relay-client-cert-validity-duration=6048000s","--hubble-relay-client-cert-secret-name=hubble-relay-client-certs","--hubble-relay-server-cert-generate=true","--hubble-relay-server-cert-validity-duration=6048000s","--hubble-relay-server-cert-secret-name=hubble-relay-server-certs"],"command":["/usr/bin/cilium-certgen"],"image":"quay.io/cilium/certgen:v0.1.4","imagePullPolicy":"IfNotPresent","name":"certgen"}],"hostNetwork":true,"restartPolicy":"OnFailure","serviceAccount":"hubble-generate-certs","serviceAccountName":"hubble-generate-certs"}},"ttlSecondsAfterFinished":1800}},"schedule":"0 0 1 */2 *"}}
  creationTimestamp: "2021-05-28T16:38:55Z"
  labels:
    app.kubernetes.io/instance: cilium
    k8s-app: hubble-generate-certs
  name: hubble-generate-certs
  namespace: kube-system
  resourceVersion: "97540106"
  uid: bb38222a-26b4-4836-a082-97cc1fe9153b
spec:
  concurrencyPolicy: Forbid
  failedJobsHistoryLimit: 1
  jobTemplate:
    metadata:
      creationTimestamp: null
    spec:
      template:
        metadata:
          creationTimestamp: null
          labels:
            k8s-app: hubble-generate-certs
        spec:
          containers:
          - args:
            - --cilium-namespace=kube-system
            - --hubble-ca-reuse-secret=true
            - --hubble-ca-secret-name=hubble-ca-secret
            - --hubble-ca-generate=true
            - --hubble-ca-validity-duration=6048000s
            - --hubble-ca-config-map-create=true
            - --hubble-ca-config-map-name=hubble-ca-cert
            - --hubble-server-cert-generate=true
            - --hubble-server-cert-common-name=*.default.hubble-grpc.cilium.io
            - --hubble-server-cert-validity-duration=6048000s
            - --hubble-server-cert-secret-name=hubble-server-certs
            - --hubble-relay-client-cert-generate=true
            - --hubble-relay-client-cert-validity-duration=6048000s
            - --hubble-relay-client-cert-secret-name=hubble-relay-client-certs
            - --hubble-relay-server-cert-generate=true
            - --hubble-relay-server-cert-validity-duration=6048000s
            - --hubble-relay-server-cert-secret-name=hubble-relay-server-certs
            command:
            - /usr/bin/cilium-certgen
            image: quay.io/cilium/certgen:v0.1.4
            imagePullPolicy: IfNotPresent
            name: certgen
            resources: {}
            terminationMessagePath: /dev/termination-log
            terminationMessagePolicy: File
          dnsPolicy: ClusterFirst
          hostNetwork: true
          restartPolicy: OnFailure
          schedulerName: default-scheduler
          securityContext: {}
          serviceAccount: hubble-generate-certs
          serviceAccountName: hubble-generate-certs
          terminationGracePeriodSeconds: 30
      ttlSecondsAfterFinished: 1800
  schedule: 0 0 1 */2 *
  successfulJobsHistoryLimit: 3
  suspend: false
status: {}

I can even start it manually:
kubectl -n kube-system create job manual-cert --from=cronjob/hubble-generate-certs
job.batch/manual-cert created
kubectl -n kube-system logs manual-cert-g47rh
time="2021-05-31T08:41:46Z" level=info msg="cilium-certgen 0.1.4" subsys=cilium-certgen
time="2021-05-31T08:41:46Z" level=info msg="Loaded Hubble CA Secret" subsys=cilium-certgen
time="2021-05-31T08:41:46Z" level=info msg="Generating server certificates for Hubble" subsys=cilium-certgen
time="2021-05-31T08:41:46Z" level=info msg="Creating CSR for certificate" certCommonName="*.default.hubble-grpc.cilium.io" certUsage="[signing key encipherment server auth]" certValidityDuration=1680h0m0s subsys=generate
time="2021-05-31T08:41:46Z" level=info msg="generate received request" subsys=cfssl syslog=info
time="2021-05-31T08:41:46Z" level=info msg="received CSR" subsys=cfssl syslog=info
time="2021-05-31T08:41:46Z" level=info msg="generating key: ecdsa-256" subsys=cfssl syslog=info
time="2021-05-31T08:41:46Z" level=info msg="encoded CSR" subsys=cfssl syslog=info
time="2021-05-31T08:41:46Z" level=info msg="signed certificate with serial number<PHONE_NUMBER>69063360358372746673330085496126630961" subsys=cfssl syslog=info
time="2021-05-31T08:41:46Z" level=info msg="Generating client certificates for Hubble Relay" subsys=cilium-certgen
time="2021-05-31T08:41:46Z" level=info msg="Creating CSR for certificate" certCommonName="*.hubble-relay.cilium.io" certUsage="[signing key encipherment server auth client auth]" certValidityDuration=1680h0m0s subsys=generate
time="2021-05-31T08:41:46Z" level=info msg="generate received request" subsys=cfssl syslog=info
time="2021-05-31T08:41:46Z" level=info msg="received CSR" subsys=cfssl syslog=info
time="2021-05-31T08:41:46Z" level=info msg="generating key: ecdsa-256" subsys=cfssl syslog=info
time="2021-05-31T08:41:46Z" level=info msg="encoded CSR" subsys=cfssl syslog=info
time="2021-05-31T08:41:46Z" level=info msg="signed certificate with serial number<PHONE_NUMBER>07915508298520737236522438620418419498" subsys=cfssl syslog=info
time="2021-05-31T08:41:46Z" level=info msg="Generating server certificates for Hubble Relay" subsys=cilium-certgen
time="2021-05-31T08:41:46Z" level=info msg="Creating CSR for certificate" certCommonName="*.hubble-relay.cilium.io" certUsage="[signing key encipherment server auth]" certValidityDuration=1680h0m0s subsys=generate
time="2021-05-31T08:41:46Z" level=info msg="generate received request" subsys=cfssl syslog=info
time="2021-05-31T08:41:46Z" level=info msg="received CSR" subsys=cfssl syslog=info
time="2021-05-31T08:41:46Z" level=info msg="generating key: ecdsa-256" subsys=cfssl syslog=info
time="2021-05-31T08:41:46Z" level=info msg="encoded CSR" subsys=cfssl syslog=info
time="2021-05-31T08:41:46Z" level=info msg="signed certificate with serial number<PHONE_NUMBER>55931075501463104458300260112837948668" subsys=cfssl syslog=info
time="2021-05-31T08:41:46Z" level=info msg="Creating K8s ConfigMap" k8sConfigMapName=hubble-ca-cert k8sConfigMapNamespace=kube-system subsys=generate
time="2021-05-31T08:41:46Z" level=info msg="ConfigMap already exists, updating it instead" k8sConfigMapName=hubble-ca-cert k8sConfigMapNamespace=kube-system subsys=generate
time="2021-05-31T08:41:46Z" level=info msg="Creating K8s Secret" k8sSecretName=hubble-server-certs k8sSecretNamespace=kube-system subsys=generate
time="2021-05-31T08:41:46Z" level=info msg="Secret already exists, updating it instead" k8sSecretName=hubble-server-certs k8sSecretNamespace=kube-system subsys=generate
time="2021-05-31T08:41:46Z" level=info msg="Creating K8s Secret" k8sSecretName=hubble-relay-client-certs k8sSecretNamespace=kube-system subsys=generate
time="2021-05-31T08:41:46Z" level=info msg="Secret already exists, updating it instead" k8sSecretName=hubble-relay-client-certs k8sSecretNamespace=kube-system subsys=generate
time="2021-05-31T08:41:46Z" level=info msg="Creating K8s Secret" k8sSecretName=hubble-relay-server-certs k8sSecretNamespace=kube-system subsys=generate
time="2021-05-31T08:41:46Z" level=info msg="Secret already exists, updating it instead" k8sSecretName=hubble-relay-server-certs k8sSecretNamespace=kube-system subsys=generate
time="2021-05-31T08:41:46Z" level=info msg="Successfully generated all 4 requested certificates." subsys=cilium-certgen

Interestingly, I fail to reproduce even when using the values.yaml file that you provided. If you kubectl delete the cronjob, does it fix the issue?

@alex1989hu Could you please also provide a sysdump of the system, maybe host it elsewhere if it's too large for github?

@rolinh: I can not attach here.

Can not attach cilium-sysdump - file size is 52M

I have just uploaded (temporary) it here https://drive.google.com/file/d/1rN4Qc8Yi2BaT3ooBqqwMh_XFOGCWmOaO/view?usp=sharing

@alex1989hu I realized that we do not include the Hubble Relay configmap in the sysdump. Could you please provide it as well?

@rolinh sure
# kubectl -n kube-system get configmaps hubble-relay-config -o yaml
apiVersion: v1
data:
  config.yaml: "peer-service: unix:///var/run/cilium/hubble.sock\nlisten-address:
    :4245\ndial-timeout: \nretry-timeout: \nsort-buffer-len-max: \nsort-buffer-drain-timeout:
    \ntls-client-cert-file: /var/lib/hubble-relay/tls/client.crt\ntls-client-key-file:
    /var/lib/hubble-relay/tls/client.key\ntls-hubble-server-ca-files: /var/lib/hubble-relay/tls/hubble-server-ca.crt\ntls-server-cert-file:
    /var/lib/hubble-relay/tls/server.crt\ntls-server-key-file: /var/lib/hubble-relay/tls/server.key\n"
kind: ConfigMap
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"v1","data":{"config.yaml":"peer-service: unix:///var/run/cilium/hubble.sock\nlisten-address: :4245\ndial-timeout: \nretry-timeout: \nsort-buffer-len-max: \nsort-buffer-drain-timeout: \ntls-client-cert-file: /var/lib/hubble-relay/tls/client.crt\ntls-client-key-file: /var/lib/hubble-relay/tls/client.key\ntls-hubble-server-ca-files: /var/lib/hubble-relay/tls/hubble-server-ca.crt\ntls-server-cert-file: /var/lib/hubble-relay/tls/server.crt\ntls-server-key-file: /var/lib/hubble-relay/tls/server.key\n"},"kind":"ConfigMap","metadata":{"annotations":{},"labels":{"app.kubernetes.io/instance":"cilium"},"name":"hubble-relay-config","namespace":"kube-system"}}
  creationTimestamp: "2021-04-22T08:06:30Z"
  labels:
    app.kubernetes.io/instance: cilium
  name: hubble-relay-config
  namespace: kube-system
  resourceVersion: "97533158"
  uid: 75235e9a-7877-4980-b1b0-b916150b0603

ArgoCD did not report any issue during Cilium upgrade.

This is really curious as I'm unable to upgrade from v1.9 to v1.10 when hubble.tls.auto.method=cronJob due to #16316, no matter if I use helm upgrade or helm template + kubectl apply.

relay tls server is needed, so enabled option hubble.relay.tls.server.enabled: true > rerun cronjob -> killed hubble-relay Pod -> nothing changed.

To be clear, Relay TLS server is not needed unless you want to enable mTLS for Relay itself. I see that in your cronjob spec, it is set to generate certs for Relay server (this is not required but it shouldn't affect the problem you're seeing):
            - --hubble-relay-server-cert-generate=true
            - --hubble-relay-server-cert-validity-duration=6048000s
            - --hubble-relay-server-cert-secret-name=hubble-relay-server-certs

Have you tried to re-run the cronjob with a command like this one? It is perfectly OK to re-generate the TLS certs, they will be picked up automatically by Hubble server and Relay as these components support TLS hot-reloading.
kubectl -n kube-system create job --from=cronjob/hubble-generate-certs hubble-generate-certs-manual-001

Have you tried to re-run the cronjob with a command like this one?

Yes, see the last code snippet:
https://github.com/cilium/cilium/issues/16361#issuecomment-851326945

Have you tried to re-run the cronjob with a command like this one?

Yes, see the last code snippet:

I missed this somehow :facepalm:
So the job run looks OK to me. I also see that the cilium agent seem to pick the update:
2021-05-28T16:39:49.727070277Z level=info msg="Certificate authority updated" config=tls-server subsys=hubble
2021-05-28T16:39:49.727253174Z level=info msg="Keypair updated" config=tls-server keypair-sn=40ec90080f4e117d32d99d71221e84ca0c9c1304 subsys=hubble

I'd expect to see a similar message in the Hubble Relay logs but I don't. I guess, based on the logs timestamp, that you the Relay instance was re-created after the certs generation so it should have picked the new certificates as well.
Could you please run hubble status (hubble list nodes -o wide could be useful as well) against Relay and post the output?

I can execute commands in cilium-agent container, hubble-relay container does not have shell:

@alex1989hu I meant to target the Hubble Relay service using the CLI. This does not require exec'ing into a pod. Please, refer to the documentation for how to do this.

@rolinh sorry. Based on the documentation I downloaded hubble CLI and set up a port-forward. No luck.
Actually, this is v1.10:

$ kubectl -n kube-system port-forward service/hubble-relay --address <IP_ADDRESS> --address :: 4245:80
error: Service hubble-relay does not have a service port 80

 $ kubectl -n kube-system get svc hubble-relay
NAME           TYPE        CLUSTER-IP     EXTERNAL-IP   PORT(S)   AGE
hubble-relay   ClusterIP   <IP_ADDRESS>   <none>        443/TCP   40d

$ kubectl -n kube-system port-forward service/hubble-relay --address <IP_ADDRESS> --address :: 4245:443
Forwarding from <IP_ADDRESS>:4245 -> 4245
Forwarding from [::]:4245 -> 4245

# Open new terminal
$ nc -Czv localhost 4245
Connection to localhost 4245 port [tcp/*] succeeded!

$ hubble list nodes
failed to connect to 'localhost:4245': context deadline exceeded: connection closed

@alex1989hu This fail because you enabled TLS for the Hubble Relay service itself (which is why it needs to be accessed on port 443 and not 80 as the default). You would need to setup your CLI with appropriate certs and CA to connect to Relay. However, to troubleshoot this issue it would be easier if this is disabled, i.e. hubble.relay.tls.server.enabled=false.

@alex1989hu This fail because you enabled TLS for the Hubble Relay service itself (which is why it needs to be accessed on port 443 and not 80 as the default). You would need to setup your CLI with appropriate certs and CA to connect to Relay. However, to troubleshoot this issue it would be easier if this is disabled, i.e. hubble.relay.tls.server.enabled=false.

Gotcha, I put tls-allow-insecure: true into $HOME/.config/hubble/config.yaml solves the issue, thus I do not have to disable TLS for the Hubble Relay service.
It does not look good.
 $ hubble status
Healthcheck (via localhost:4245): Ok
Current/Max Flows: 0/0
Flows/s: N/A
Connected Nodes: 0/9
Unavailable Nodes: 9
  - prod-k8s-master-1
  - prod-k8s-master-2
  - prod-k8s-master-3
  - prod-k8s-worker-8da7da49
  - prod-k8s-worker-8ddbacc3
  - prod-k8s-worker-f08f772d
  - prod-k8s-worker-fc988125
  - prod-k8s-worker-fdd18af8
  - prod-k8s-worker-gmjqaj86

$ hubble list nodes -o wide
NAME                       STATUS        AGE   FLOWS/S   CURRENT/MAX-FLOWS   VERSION   ADDRESS             TLS
prod-k8s-master-1          Unavailable   N/A   N/A       N/A                 N/A       <IP_ADDRESS>:4244   Enabled
prod-k8s-master-2          Unavailable   N/A   N/A       N/A                 N/A       <IP_ADDRESS>:4244   Enabled
prod-k8s-master-3          Unavailable   N/A   N/A       N/A                 N/A       <IP_ADDRESS>:4244   Enabled
prod-k8s-worker-8da7da49   Unavailable   N/A   N/A       N/A                 N/A       <IP_ADDRESS>:4244   Enabled
prod-k8s-worker-8ddbacc3   Unavailable   N/A   N/A       N/A                 N/A       <IP_ADDRESS>:4244   Enabled
prod-k8s-worker-f08f772d   Unavailable   N/A   N/A       N/A                 N/A       <IP_ADDRESS>:4244   Enabled
prod-k8s-worker-fc988125   Unavailable   N/A   N/A       N/A                 N/A       <IP_ADDRESS>:4244   Enabled
prod-k8s-worker-fdd18af8   Unavailable   N/A   N/A       N/A                 N/A       <IP_ADDRESS>:4244   Enabled
prod-k8s-worker-gmjqaj86   Unavailable   N/A   N/A       N/A                 N/A       <IP_ADDRESS>:4244   Enabled

Troubleshooting why Hubble Relay fails to connect to peers is hard because of a limitation of the gRPC version that ships with Cilium. Would you mind trying out to deploy a Hubble CLI instance using the file in PR #16459? Then, run this command and paste the error you obtain:
kubectl exec -n kube-system deployment/hubble-cli -- \
    hubble observe --server 'tls://<IP_ADDRESS>:4244' \
        --tls-server-name 'prod-k8s-worker-8da7da49.default.hubble-grpc.cilium.io' \
        --tls-ca-cert-files /var/lib/hubble-relay/tls/hubble-server-ca.crt \
        --tls-client-cert-file /var/lib/hubble-relay/tls/client.crt \
        --tls-client-key-file /var/lib/hubble-relay/tls/client.key

I have just deployed hubble-cli from the referenced PR.
hubble-server-ca expired, see later.
kubectl -n kube-system get deployment hubble-cli
NAME         READY   UP-TO-DATE   AVAILABLE   AGE
hubble-cli   1/1     1            1           2m40s

Executed the command:
failed to connect to 'tls://<IP_ADDRESS>:4244': context deadline exceeded: connection error: desc = "transport: authentication handshake failed: x509: certificate has expired or is not yet valid: current time 2021-06-10T17:04:20Z is after 2021-05-17T10:57:00Z"
command terminated with exit code 1

Its weird, it looks like the certificate file differs what node on the given port serves:
openssl s_client -connect <IP_ADDRESS>:4244 -prexit -showcerts </dev/null 2>/dev/null

Certificate chain
 0 s:CN = *.default.hubble-grpc.cilium.io
   i:CN = hubble-ca.cilium.io
-----BEGIN CERTIFICATE-----
MIIB7TCCAZOgAwIBAgIUfGrvF2jgL4qFo6To4uO7rIgbTUQwCgYIKoZIzj0EAwIw
HjEcMBoGA1UEAxMTaHViYmxlLWNhLmNpbGl1bS5pbzAeFw0yMTA2MTAxNjQ0MDBa
Fw0yMTA4MTkxNjQ0MDBaMCoxKDAmBgNVBAMMHyouZGVmYXVsdC5odWJibGUtZ3Jw
Yy5jaWxpdW0uaW8wWTATBgcqhkjOPQIBBggqhkjOPQMBBwNCAAQUVz9Ilnl3JD36
X/QVxIDWAJOFmMNzo4Hefdbrt0QeyvBk1CwVuDLvYmmsmt8//WeDU2VcACAzK0zC
DagJ7Gw2o4GiMIGfMA4GA1UdDwEB/wQEAwIFoDATBgNVHSUEDDAKBggrBgEFBQcD
ATAMBgNVHRMBAf8EAjAAMB0GA1UdDgQWBBSmMyJyXF9yyyCMTiVjl75ms7jg9TAf
BgNVHSMEGDAWgBRARRrWcakVxc/g832SDBkCpmge/TAqBgNVHREEIzAhgh8qLmRl
ZmF1bHQuaHViYmxlLWdycGMuY2lsaXVtLmlvMAoGCCqGSM49BAMCA0gAMEUCIEiQ
HcC8bqpX3bDWhKL8XAPO+rKvHi7LbQPOdDcggO2oAiEAphl05pHlrdZYa8UqgLpq
BSvROcHt1mUzB8fwqXYiaGQ=
-----END CERTIFICATE-----

Let's see the certificate one by one.
Expired CA certificate is: /var/lib/hubble-relay/tls/hubble-server-ca.crt
-----BEGIN CERTIFICATE-----
MIIBgTCCASagAwIBAgIUEQcrOEugoWwyfIaRDcO5O8rzB/0wCgYIKoZIzj0EAwIw
HjEcMBoGA1UEAxMTaHViYmxlLWNhLmNpbGl1bS5pbzAeFw0yMTAzMDgxMDU3MDBa
Fw0yMTA1MTcxMDU3MDBaMB4xHDAaBgNVBAMTE2h1YmJsZS1jYS5jaWxpdW0uaW8w
WTATBgcqhkjOPQIBBggqhkjOPQMBBwNCAASeGWKjcjcQ52agSjZF2sb3WGrA2E9S
0UCnEDWsY4JadCkbMcUOt1v5G6v50Zbe1+8pFNo9YgNhC6qJ1kobBHL2o0IwQDAO
BgNVHQ8BAf8EBAMCAQYwDwYDVR0TAQH/BAUwAwEB/zAdBgNVHQ4EFgQUQEUa1nGp
FcXP4PN9kgwZAqZoHv0wCgYIKoZIzj0EAwIDSQAwRgIhAPp3fDkT6aZwXeEBd96H
l8GlstjrTeNW5rwZiTZ2CBmqAiEArjPFupdZ8RW4IbECFMEXNGpve/72f4U8lcvB
eidxPtU=
-----END CERTIFICATE-----

Probably it causes the issue. I don't understand why it is expired.
To give you full picture, here is the client certificate which is fine: /var/lib/hubble-relay/tls/client.crt
-----BEGIN CERTIFICATE-----
MIIB6TCCAY+gAwIBAgIUZsPHkmPWMNla4khfjQbuXTMpdDUwCgYIKoZIzj0EAwIw
HjEcMBoGA1UEAxMTaHViYmxlLWNhLmNpbGl1bS5pbzAeFw0yMTA2MTAxNjQ0MDBa
Fw0yMTA4MTkxNjQ0MDBaMCMxITAfBgNVBAMMGCouaHViYmxlLXJlbGF5LmNpbGl1
bS5pbzBZMBMGByqGSM49AgEGCCqGSM49AwEHA0IABCuB3DCSn/2DyI9LgjCU7BoC
7pPn7uHZywdH5lOVbiF+YLXGAwCCOgPVF5cUlk848+uajOisRxU8OcMGyp433sqj
gaUwgaIwDgYDVR0PAQH/BAQDAgWgMB0GA1UdJQQWMBQGCCsGAQUFBwMBBggrBgEF
BQcDAjAMBgNVHRMBAf8EAjAAMB0GA1UdDgQWBBROQNy/f56su9aiutyhOT6L8AbD
pzAfBgNVHSMEGDAWgBRARRrWcakVxc/g832SDBkCpmge/TAjBgNVHREEHDAaghgq
Lmh1YmJsZS1yZWxheS5jaWxpdW0uaW8wCgYIKoZIzj0EAwIDSAAwRQIhAPGbl1l3
VzK4TB8LM4h7YuBg7yUN0kqy+zZVyujd7xGUAiBrdbsiJOMtk1qkWclimLIXNt61
tQeuKPbfVemVxi1wbQ==
-----END CERTIFICATE-----

@alex1989hu I think I know what's going on. Could you try editing the hubble-generate-certs cronjob to remove the following line from Args?
- --hubble-ca-reuse-secret=true

Then trigger the job again and see if it fixes the issue (I think it should generate new CA certs).

@rolinh, I copied the original CronJob, removed that arg. Unfortunately, there is permission issue:

time="2021-06-11T13:20:33Z" level=fatal msg="failed to generate certificates" error="failed to create secret for Hubble CA: secrets "hubble-ca-secret" is forbidden: User "system:serviceaccount:kube-system:hubble-generate-certs" cannot update resource "secrets" in API group "" in the namespace "kube-system"" subsys=cilium-certgen

Meaning that the Helm chart has a defect:
https://github.com/cilium/cilium/blob/952d9d33740fc77e1a94d5a52b38d2a313e5c570/install/kubernetes/cilium/templates/hubble-generate-certs-clusterrole.yaml#L32-L39
Here is the Pod log:
time="2021-06-11T13:20:33Z" level=info msg="cilium-certgen 0.1.4" subsys=cilium-certgen
time="2021-06-11T13:20:33Z" level=info msg="Creating CSR for certificate authority" certCommonName=hubble-ca.cilium.io certValidityDuration=1680h0m0s subsys=generate
time="2021-06-11T13:20:33Z" level=info msg="generate received request" subsys=cfssl syslog=info
time="2021-06-11T13:20:33Z" level=info msg="received CSR" subsys=cfssl syslog=info
time="2021-06-11T13:20:33Z" level=info msg="generating key: ecdsa-256" subsys=cfssl syslog=info
time="2021-06-11T13:20:33Z" level=info msg="encoded CSR" subsys=cfssl syslog=info
time="2021-06-11T13:20:33Z" level=info msg="signed certificate with serial number<PHONE_NUMBER>81947435713081743050694512010640070268" subsys=cfssl syslog=info
time="2021-06-11T13:20:33Z" level=info msg="Generating server certificates for Hubble" subsys=cilium-certgen
time="2021-06-11T13:20:33Z" level=info msg="Creating CSR for certificate" certCommonName="*.default.hubble-grpc.cilium.io" certUsage="[signing key encipherment server auth]" certValidityDuration=1680h0m0s subsys=generate
time="2021-06-11T13:20:33Z" level=info msg="generate received request" subsys=cfssl syslog=info
time="2021-06-11T13:20:33Z" level=info msg="received CSR" subsys=cfssl syslog=info
time="2021-06-11T13:20:33Z" level=info msg="generating key: ecdsa-256" subsys=cfssl syslog=info
time="2021-06-11T13:20:33Z" level=info msg="encoded CSR" subsys=cfssl syslog=info
time="2021-06-11T13:20:33Z" level=info msg="signed certificate with serial number<PHONE_NUMBER>1069669743518100143765142861508975469" subsys=cfssl syslog=info
time="2021-06-11T13:20:33Z" level=info msg="Generating client certificates for Hubble Relay" subsys=cilium-certgen
time="2021-06-11T13:20:33Z" level=info msg="Creating CSR for certificate" certCommonName="*.hubble-relay.cilium.io" certUsage="[signing key encipherment server auth client auth]" certValidityDuration=1680h0m0s subsys=generate
time="2021-06-11T13:20:33Z" level=info msg="generate received request" subsys=cfssl syslog=info
time="2021-06-11T13:20:33Z" level=info msg="received CSR" subsys=cfssl syslog=info
time="2021-06-11T13:20:33Z" level=info msg="generating key: ecdsa-256" subsys=cfssl syslog=info
time="2021-06-11T13:20:33Z" level=info msg="encoded CSR" subsys=cfssl syslog=info
time="2021-06-11T13:20:33Z" level=info msg="signed certificate with serial number<PHONE_NUMBER>55476931839087825516408982269593816752" subsys=cfssl syslog=info
time="2021-06-11T13:20:33Z" level=info msg="Generating server certificates for Hubble Relay" subsys=cilium-certgen
time="2021-06-11T13:20:33Z" level=info msg="Creating CSR for certificate" certCommonName="*.hubble-relay.cilium.io" certUsage="[signing key encipherment server auth]" certValidityDuration=1680h0m0s subsys=generate
time="2021-06-11T13:20:33Z" level=info msg="generate received request" subsys=cfssl syslog=info
time="2021-06-11T13:20:33Z" level=info msg="received CSR" subsys=cfssl syslog=info
time="2021-06-11T13:20:33Z" level=info msg="generating key: ecdsa-256" subsys=cfssl syslog=info
time="2021-06-11T13:20:33Z" level=info msg="encoded CSR" subsys=cfssl syslog=info
time="2021-06-11T13:20:33Z" level=info msg="signed certificate with serial number<PHONE_NUMBER>72842499488164491968124808240241464862" subsys=cfssl syslog=info
time="2021-06-11T13:20:33Z" level=info msg="Creating K8s Secret" k8sSecretName=hubble-ca-secret k8sSecretNamespace=kube-system subsys=generate
time="2021-06-11T13:20:33Z" level=info msg="Secret already exists, updating it instead" k8sSecretName=hubble-ca-secret k8sSecretNamespace=kube-system subsys=generate
time="2021-06-11T13:20:33Z" level=fatal msg="failed to generate certificates" error="failed to create secret for Hubble CA: secrets \"hubble-ca-secret\" is forbidden: User \"system:serviceaccount:kube-system:hubble-generate-certs\" cannot update resource \"secrets\" in API group \"\" in the namespace \"kube-system\"" subsys=cilium-certgen

@alex1989hu now that #16508 is fixed in Cilium 1.10.2 or later, are you still observing an issue?

This issue has not seen any activity since it was marked stale. Closing. Feel free to re-open a new issue if it is still persisting. Thank you.


ARROW-15098 [R] Add binding for lubridate::duration() and/or as.difftime()

This PR adds bindings for base::difftime() and base::as.difftime().

I feel this is a trade-off between:

erroring on all doubles and having a clear message
erroring on pure doubles (function works on integer-like doubles) with a C++ message that might be less clear

Not sure where to go.

@jonkeane when you get the chance, would you mind having another look?


circular dependencies making knip stuck

Reproduction url
https://github.com/blephy/knip-circulare-dep
Description of the issue
Given a mono-repository, if it's contains project which are dependent on each other, knip is running in loop and never failed.
Yes, circular dependencies are bad, but there is some case you cannot do anything about :

a prettier-config project
an eslint-config project

Each are requesting each other.
I did manage to bypass this bug by not including in their package.json's devDependencies the package, but instead to rely on a relative import in configs.
instead of :
{
  "name": "prettier-config",
  "devDependencies": {
    "eslint-config": "workspace: *"
  }
}

and
module.exports = {
  root: true,
  extends: ['eslint-config'],
};

do :
{
  "name": "prettier-config",
  "devDependencies": {
  }
}

and
module.exports = {
  root: true,
  extends: ['../eslint-config/index.cjs'],
};

https://i-do-no-have.com/

it-is-required.though

https://i-do-no-have.com/

it-is-required.though

I will make it in a couple of hours. Sorry i do not have time right now

cc @webpro
https://github.com/blephy/knip-circulare-dep

No issues here:
❯ pnpm knip

><EMAIL_ADDRESS>knip /Users/lars/p/knip/exercises/knip-circulare-dep
> VITE_CJS_IGNORE_WARNING=true knip

Unused devDependencies (2)
eslint-config  libs/prettier-config/package.json
nx             package.json
Unlisted dependencies (1)
eslint-config-eslint-config  libs/prettier-config/.eslintrc.cjs
 ELIFECYCLE  Command failed with exit code 1.

Hum ...
is it relative to Node / OS ?
i'm on
ProductName:		macOS
ProductVersion:		14.5
BuildVersion:		23F79

You could try CSB or SB: https://knip.dev/guides/issue-reproduction#templates

Closing this due to unable to reproduce.


Deprecated k8s apiversion in yaml

extensions/v1beta1 is deprecated for DaemonSet in Kuberentes v1.16
https://github.com/RadeonOpenCompute/k8s-device-plugin/blob/661b5788a9362cfc05e7f82a1293caee9a2b6997/k8s-ds-amdgpu-dp.yaml#L1
https://github.com/RadeonOpenCompute/k8s-device-plugin/blob/661b5788a9362cfc05e7f82a1293caee9a2b6997/k8s-ds-amdgpu-dp-health.yaml#L7
better change to apps/v1, which is available since v1.9.
reference: https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/

Thanks for spotting the API change!


Emoji character width / spacing too large (Black Medium Square)

Environment
Windows Version: 10.0.18362.836
Terminal Version: 0.11.1333.0

Steps to reproduce
Paste the following into the terminal (command prompt or WSL): ◼◼◼◼◼◼◼◼◼
Expected behavior
The characters are normally spaced. Screen shot is from Version: 0.11.1251.0.
This has been the previous behaviour and is how other terminals (tested in gnome-terminal) display the same setup.

Actual behavior
The characters are too wide / too much spacing between them and this breaks the layout where mono fonts are expected and relied upon for layout.
Screenshot is from Version: 0.11.1333.0.

So, I've got to admit. I sorta hate this :smile:
We knew there'd be some regressions when we recategorized some of the codepoints as "wide", but like, I'm at a loss for what to do with this one.
Everything I can find about these two glyphs indicates that we're supposed to give them Emoji treatment.
From the Unicode Character Database (latest version):
PS> $chs=($ucd.ucd.repertoire.char | ? cp -in ("25FB", "25FC"))
PS> $chs | ft cp,ea,Emoji,ExtPict

cp   ea Emoji ExtPict
--   -- ----- -------
25FB N  Y     Y
25FC N  Y     Y

Perhaps the answer lies in emoji-sequences.txt? The emoji whose emoji presentations require U+FE0F might be good candidates for reshrinking?


[1.4.1] Large blank space after editing issue comment

I.E.

Also, clicking back after submitting issue takes you back to editing/creating issue, instead of back/up a level

@rancidfrog I can't seem to reproduce your issue on Android. Is the issue you were editing available somewhere so I can try to reproduce the conditions?
Also, I think that your last remark is covered in #432, can you confirm that this is the same problem?

@machour
The issue I was editing was #668, one of the recent ones I opened with long logcat.
I just tried again and same problem.
There seems to be an issue with displaying the editable ontent, as half screen is only used to display edit text area:
top,

middle,

bottom,

Yes, 432 covers it.


Remove warnings when building on non-linux env

@ymesika: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

test_ztunnel
653418999f3e08c7b940b41ef0ebb68286c01d7c
link
true
/test test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ymesika: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

test_ztunnel
ef941aaf31231f2f6a6f619ec9487d3f66ed65c0
link
true
/test test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


CarouselView crashing app (sometimes OS) when swiping down in scrollview

The app is crashing (sometimes causing OS reboot) when I'm scrolling from over the carouselView in Android (haven't tested iOS yet).
My hierarchy looks like this...
<ContentPage xmlns="http://xamarin.com/schemas/2014/forms"
             xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
             xmlns:cardView="clr-namespace:PanCardView.Controls;assembly=PanCardView"
             xmlns:carousel="clr-namespace:PanCardView;assembly=PanCardView"
             x:Class="App.Pages.HomePage">
    <ContentPage.Content>
        <cardView:ParentScrollView>
            <StackLayout x:Name="MainLayout" Style="{ DynamicResource BackgroundLightGray }">
                    .....

                <StackLayout x:Name="PromotionStack" VerticalOptions="Start" HorizontalOptions="FillAndExpand" />

                .........
            </StackLayout>
        </cardView:ParentScrollView>
    </ContentPage.Content>
</ContentPage>

And the code behind does this:
PromotionStack.Children.Add(new PanCardView.CarouselView() {
                HorizontalOptions = LayoutOptions.FillAndExpand,
                Items = new List<View>() {
                            new CardView()
                            {
                                Content = new StackLayout()
                                {
                                    HorizontalOptions = LayoutOptions.FillAndExpand,
                                    Children = { new CachedImage() { Source = "https://aldrichsolutions.com/images/app/banner.jpg?x=3", Aspect = Aspect.Fill } }
                                }
                            },
                            new CardView()
                            {
                                Content = new StackLayout()
                                {
                                    HorizontalOptions = LayoutOptions.FillAndExpand,
                                    Children = { new CachedImage() { Source = "https://aldrichsolutions.com/images/app/banner.jpg?x=3", Aspect = Aspect.Fill } }
                                }
                            }
                        }
            });

GIF showing behavior:

On a related note, if I set my images to any other aspect (or no aspect) the carousel is still just as tall, but the image scales properly, just with a bunch of white space underneath. Any suggestions on how to fix that? I'd like the carousel to just automatically height itself to the images being passed in if possible - as I won't know the height of the images beforehand.

@Nixon-Joseph I suggest to update cardsView up to 1.4.1 version and XF to latest stable one... maybe, it will help us to fix it) I hope..

Will attempt to give it a try soon. Thanks.

Im using 1.4.7 version with XF 3.1. I putted a Cardview into the ParentScrollView. So when I scroll up in section cardview. It scroll to header. And when I scroll down. My App was crash.
System.Collections.Generic.KeyNotFoundException: The given key 'd2cc4fca-7b8a-4712-9a96-662f8f265049' was not present in the dictionary.
How to fix it ?

Hi
I need some time for reproducing

Do you need a screenshot for this error ?

Maybe, video or code/xaml sample

Here is my code in Homepage
<ParentScrollView VerticalOptions="FillAndExpand" x:Name="outerScrollView">             <Grid x:Name="layeringGrid" RowSpacing="0" VerticalOptions="FillAndExpand">                 <Grid.RowDefinitions>                     <RowDefinition Height="Auto" />                     <RowDefinition Height="90" />                 </Grid.RowDefinitions>                 <Grid ColumnSpacing="0" RowSpacing="0" BackgroundColor="Accent"  HorizontalOptions="FillAndExpand">                     <ff:CachedImage x:Name="img" BitmapOptimizations="True" Source="{Binding HinhAnh}" Aspect="AspectFill"></ff:CachedImage>                 </Grid>                 <cards:CarouselView                           Grid.Row="2"                         IsAutoNavigating="True"                         HeightRequest="100"                         Items="{Binding ListHinhAnh}"                         CurrentIndex="{Binding Position}"                         x:Name="CarouselView">                     <cards:CarouselView.ItemTemplate>                         <DataTemplate>                             <ContentView>                                 <ff:CachedImage Aspect="AspectFill"                                                  DownsampleUseDipUnits="True"                                                 Source="{Binding Image}"                                                 HorizontalOptions="FillAndExpand"                                                 VerticalOptions="FillAndExpand">                                 </ff:CachedImage>                             </ContentView>                         </DataTemplate>                     </cards:CarouselView.ItemTemplate>                     <PanCardView:IndicatorsControl x:Name="indicator">                         <PanCardView:IndicatorsControl.Margin>                             <OnPlatform x:TypeArguments="Thickness" Android="10" iOS="5" />                         </PanCardView:IndicatorsControl.Margin>                         <PanCardView:IndicatorsControl.ItemTemplate>                             <DataTemplate>                                 <controls:IndicatorItemView />                             </DataTemplate>                         </PanCardView:IndicatorsControl.ItemTemplate>                     </PanCardView:IndicatorsControl>                 </cards:CarouselView>             </Grid>         </ParentScrollView>

Here is my error :
https://www.youtube.com/watch?v=ywGtP9cKerg
When I scroll up. It scroll to header. And scroll down. It crash

@nhdanh hmm, but it works fine in your video.. no?

oh you can see in this video. When I scroll. It has scroll very long into header. My layout hasn't height like this. So when I scroll down. It crash my app

ok, got it
I will try to figure out with this issue.
But you can try to work around if you extend ParentScrollView https://github.com/AndreiMisiukevich/CardView/blob/master/PanCardView/Controls/ParentScrollView.cs
You may manage scroll permission there.

try to fork my repo and create sample in your cloned repo.
I hope, I've just fixed this issue, but can't promise)

Image not coming if Source is from URL please solve and let me know

@Monikaprime create please issue and explain your case.
Have you tried FFImageLoading?


[DOC] Typo on Longhorn-specific StorageClass parameters

What's the document you plan to update? Why? Please describe
Based on https://longhorn.io/docs/1.6.0/snapshots-and-backups/scheduling-backups-and-snapshots/#with-storageclass-parameters, configuring a Longhorn-provided StorageClass with a Recurring Job selector parameters is done via parameters.recurringJobSelector key, but not on https://longhorn.io/docs/1.6.0/references/storage-class-parameters/#recurring-jobs-selector-field-parametersrecurringjobsselector which is parameters.recurringJobsSelector
I believe this is a typo on the latter part.
Additional context
Was configuring StorageClass with a recurring job selector, followed the second page, turns out didn't work because of the extra is in parameters.recurringJobsSelector.
Created a PR in longhorn/website#883

Thanks for the contribution @Hazmi35!


fix(ripple): Ripple effect displaced

MdcRipple service was completely rewritten.

Fixes ripple effect displacement issues
Fixes ripple effect occasionally failing on tab touch

fix #1914 fix #1990

For some reason I still have problem described in #1914 fix #1990.
The icon-button is placed in the custom modal like this:
<app-modal [...some props] (onModalClose)="closeModal()">

    {{ 'economy.forgot_anyone' | translate }}
    <button mdcIconButton (click)="closeModal()">
      <mdc-icon>clear</mdc-icon>
    </button>

  [...other stuff]
</app-modal>

"@angular-mdc/web": "^5.0.5",
Both examples
<button mdcIconButton (click)="closeModal()">
  <mdc-icon>clear</mdc-icon>
</button>

<button mdc-icon-button icon="clear" (click)="closeModal()"></button>

work the same way

...before I actually click on the button.


Dashboard broken after last update

Other apps are working fine.
Tried on IE, Chrome Firefox. All the same.
Log: http://pastebin.com/KT9JpBXW

Can confirm you already fixed this with the latest commit!


Thaumic Wand Rod can not be made

The thaumic wand rod can not be made with its research done.
It seems that there's no such a recipe.

There is currently a bug in the code, where the recipe requires the ROD_tb.thaumic research, which does not exists(there is a ROD_thaumic one). I've already fixed that, await the new update ;)


ci-heapster-canarypush seems broken for a long while

W0302 18:29:53.278] + docker build -t kubernetes/heapster:canary --no-cache=true --pull=true --file=deploy/docker/canary/Dockerfile .
W0302 18:29:53.313] unable to prepare context: unable to evaluate symlinks in Dockerfile path: lstat /var/lib/jenkins/workspace/ci-heapster-canarypush/go/src/k8s.io/heapster/deploy/docker/canary: no such file or directory

any ideas?

@timstclair @vishh any ideas?

I think the issue is https://github.com/kubernetes/heapster/pull/1387 removed deploy/docker/canary/Dockerfile, while the canarypush job is still referencing it. Is the job still needed? @luxas

I don't think that explicit canary Dockerfile is needed, instead we can use the normal Dockerfile for building a canary image just by a retagging

shall I delete the ci job?

No objections from me


Support for Zod Schema .transform

Today I used patch-package to patch<EMAIL_ADDRESS>for the project I'm working on.
I wanted to use .transform() for my zod schema, which broke the openapi generator. Here's an example:
limit: z
    .number()
    .optional()
    .openapi({
      description: "Number of results to return. Always default to 3 unless specified otherwise by the user.",
      type: "integer",
    })
    .default(3)
    .transform((v) => v.toString())

Here is the diff that solved my problem:
diff --git<EMAIL_ADDRESS><EMAIL_ADDRESS>index d82c957..23f5a53 100644
---<EMAIL_ADDRESS>+++<EMAIL_ADDRESS>@@ -641,7 +641,7 @@ class OpenAPIGenerator {
             return this.unwrapChained(schema._def.innerType);
         }
         if ((0, zod_is_type_1.isZodType)(schema, 'ZodEffects') &&
-            schema._def.effect.type === 'refinement') {
+           ['refinement', 'transform'].includes(schema._def.effect.type)) {
             return this.unwrapChained(schema._def.schema);
         }
         return schema;

This issue body was partially generated by patch-package.
Happy to turn this into the PR if you approve of the suggestion

@dvargas92495 to be honest we previouslly labeled this as "unsupported" and I can't even fully remember why. And it was actually brought as a topic in this PR just a few days ago. So we are definitely planning to try and support this. I am not sure if that is the only change we'd need to make but you could go ahead and give it a go with a PR.
Some notes:

This is mentioned in the README and would need to be updated there as well.
We maintain a sort of a TDD approach in this repository since the expected state is pretty obvious. There is a transform.spec.ts. You would need to go ahead and modify it, presumably some more tests might occur as well.

It should now be available in v4.7.0

I am trying to use a transform with a query schema but the following error:

TS2740: Type 'ZodEffects<ZodObject<{ fromDttmUTC: ZodEffects<ZodString, Instant, string>; toDttmUTC: ZodEffects<ZodString, Instant, string>; }, "strip", ZodTypeAny, { ...; }, { ...; }>, { ...; }, { ...; }>' is missing the following properties from type 'ZodObject<any, any, any, { [x: string]: any; }, { [x: string]: any; }>': _cached, _getCached, shape, strict, and 14 more.

Below is the schema
export const querySchema = z
  .object({
    fromDttmUTC: z.date(),
    toDttmUTC: z.date(),
  })
  .transform(({ fromDttmUTC, toDttmUTC }) => ({
    range: {
      from: fromDttmUTC,
      to: toDttmUTC,
    },
  }));

@codeinabox are you passing this directly to request.query. We only support a ZodObject there. Internally each key can have a transform on its own but not the whole object.
It might be possible to add a support for ZodEffect where the base was a ZodObject. Would you open up a new issue that specifies this particular usage and I'll see what can we do.


Changes to reflect the storage of URL-encoded key-value pairs as [String: [String]

rather than [String: String] in the larger Kitura project.
See https://github.com/IBM-Swift/Kitura/pull/1237 for all the info. Both of these PRs are dependent on each other.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Closing as this requirement was fulfilled via https://github.com/IBM-Swift/Kitura/pull/1238 - thanks @NocturnalSolutions!


image to data

hi,
is there any way to pass "invoice image".
I mean can we apply tesseract ocr on the image first and then invoice2data.
thanks in advance.

Ran into the same problem.
Some invoices have crucial data encaptured in images.
This library had either "text extraction" or "ocr".
What you are looking for is propably an HOCR function.
Which applies OCR to the images and extracts the texts from the PDF.
This library supports pdfminer.
Recently pdfminer got hocr support.
pdfminer/pdfminer.six#651
Didn't have time yet to play with that functionality, and how it can be used in this library.
Maybe we need to update documentation how to use it.

Sorry, my previous statement was wrong.
Best method for now, is to pass the whole invoice to the tesseract input method.

@aditya11ad
I've made a pr, in which ocrmypdf is used as a pre-processor for invoice2data.
Can you review that one? Check if it covers your use case?

Implemented in #409


Jump-to-definition ignores arity for function in different file

Environment

Elixir 1.15.0
Erlang/OTP 26
Elixir Language Server version: v0.15.1
Operating system: ArchLinux
Editor or IDE name (e.g. Emacs/VSCode): NeoVim
Editor Plugin/LSP Client name and version: lspconfig

Current behavior
In two separate files:
defmodule Test do
  def demo do
    Second.example()
    Second.example(:one)
    Second.example(:one, :two)
  end
end

defmodule Second do
  def example() do
    :ok
  end

  def example(:one) do
    :ok
  end

  def example(:one, :two) do
    :ok
  end
end

Using the "jump to definition" function on each function call in Test.demo/0, the cursor always jumps to Second.example/0, even for the functions calls where the arity does not match.
Expected behavior
The cursor should jump to the function with the correct arity. Note that this works correctly if both modules are in the same file.

Addressed in https://github.com/elixir-lsp/elixir_sense/pull/247
and released in v0.16.0. Please update
Note that it is not currently working for erlang functions (https://github.com/elixir-lsp/elixir_sense/issues/186)


Refactor/update neon 0.8

Based on work by @lucasfernog and @oeed, referenced from upstream discussion to get coverage for newer versions of neon at https://github.com/GabrielCastro/neon-serde/pull/67.

[ ] 0.7.1 support is "done" (hasn't really been tested), but 0.8.0 hasn't been tried yet.

One issue to note with my PR is that it does tie you to N-API. I can't recall exactly why I did that anymore, it may have simply been because I wanted N-API for my use cases. Might be worth double checking that.

My preliminary testing of this branch with extremely minor changes for Neon 0.8 has been positive. Granted, I am only using N-API, and very basic features at that.
https://github.com/antonok-edm/neon-serde/tree/refactor/update-neon-0.8

My preliminary testing of this branch with extremely minor changes for Neon 0.8 has been positive. Granted, I am only using N-API, and very basic features at that.
https://github.com/antonok-edm/neon-serde/tree/refactor/update-neon-0.8

Hey, this doesn't work for me. I get an error when compiling. Seems to be version conflicts I think.
This is my Cargo.toml
[package]
name = "test-neon"
version = "0.1.0"
license = "ISC"
edition = "2018"
exclude = ["index.node"]

[dependencies]
serde = { version = "1.0.126", features = ["derive"] }
neon-serde = { path = "neon-serde" }

[lib]
crate-type = ["cdylib"]

[dependencies.neon]
version = "0.8"
default-features = false
features = ["napi-6"]


Ambiguity of @…@

Apparently Haddock interprets @…@ as a code block rather than an inline element if it's all by itself.  Is this an intended feature or a bug in the parser?  The official docs isn't clear on this: the example shows
-- @
--     f x = x + x
-- @

so I had always assumed that the newline after the first @ and before the last @ was required for it to be interpreted as a code block.
When this occurs inside the documentation of a parameter, it expands in height, which makes it rather ugly.
Example
-- ^ @(tj1, tm1, tj2, tm2, tj3, tm3)@

If I add a dot to the end, Haddock interprets it differently (and it looks a lot nicer as a result):
-- ^ @(tj1, tm1, tj2, tm2, tj3<EMAIL_ADDRESS>
Screenshots

Indeed haddock code blocks are behaving unexpectedly.  I was assuming a similar behavior to literate haskell code blocks or code blocks in markdown.
It seems that the current rules are (reverse engineered from example):

The opening @ needs to be preceded by an empty line.
The closing @ needs to be followed by a line break.
If the opening @ was not followed by a line break, the closing @ needs to be even followed by an empty line.

I find rule 1 counterintuitive.  The better rule would be: The opening @ needs to be followed by a line break.
Rule 3 seems a completely pointless artifact.
As a consequence of the rules, the following very naturally looking code block fails to render as such:
-- | This function does blaaah.
--
-- Examples:
-- @
--   test 1 = 2
--   test 2 = 3
-- @
-- These examples should be instructive.

Instead, something worse looking like
-- | This function does blaaah.
--
-- Examples:
-- @  test 1 = 2
--   test 2 = 3 @
--
-- These examples should be instructive.

renders fine.
Imho, the following rules for code blocks (need not be exclusive) would be intuitive:

If @ is followed by a newline (ignoring other whitespace), it opens a code block.
Any @ encountered from there which is followed by a newline closes the code block.
The indentation of the code block is determined by the column of the opening @ and the column of the first non-space token on the following line.

If the token is (weakly) to the right of the @, then the indentation is the difference of the column numbers.  In particular, if the token is on the same column than @, the indentation is zero.

If the token is to the left of the @, then the indentation is determined by the column of the --.  It is the token column minus the column of the -- minus 3, such that -- bla has zero indentation of bla.

I attach files with more experiments and their rendering with Haddock 2.16.1.  According to the changelog, the rendering of code blocks has not changed since then.
haddock-issue-447.zip

I suspect main confusion arises because @…@ actually has 3 different uses.

Codeblock
Monospace
@since

The rules are. Firstly we I have to point out how Haddock parses. It grabs a paragraph of content. Paragraphs are blocks of text separated by newlines.
{-|
This is paragraph 1.

This is paragraph 2.
-}

Codeblocks are paragraphs which begin with a @ and terminate with @ before whitespace delimiting end of paragraph.

{- |
This is a start of paragraph.

@
This is a code block from paragraph 2.
@

@
This is also a code block because it's in a paragraph on its own, the closing \@ sign is followed by whitespace with newline/end of doc. @
-}

Haddock will grab the content from between the @ and run the parser on it again. This allows you to use other markup inside code blocks, such as function links &c.

Monospace is simply any other content between two @.

{- |
This is paragraph 1. @This is monospaced in paragraph<EMAIL_ADDRESS>@
This should still be part of paragraph 1 but monospaced.
@
-}

Last case is uninteresting. If @since appears in a paragraph on its own then it's used for some metadata. It's irrelevant here.

Having ran Haddock 2.17.3 on the example you provided in the zip file (the HTML file you provided is not enough for it to render properly). everything I see there aligns with what I wrote above. I agree that the documentation at (http://haskell-haddock.readthedocs.io/en/latest/markup.html#code-blocks) should mentioned that a @-delimited codeblock should start in a new paragraph or without explaining what paragraph means, "following a newline/at start of comment" and should terminate with a @ followed by newline (with optional horizontal whitespace first, for those who commit trailing whitespace…).
I think we will get what you expect if only I can amend your first rule:

If @ is preceded and followed by a newline, it opens a code block.

With regards to indentation level, I agree it's not the best behaviour there and should be considered as an improvement to the parser.


CEWP with embedded Iframes do not modernize properly

Thank you for reporting an issue or suggesting an enhancement. We appreciate your feedback - to help the team to understand your needs, please complete the below template to ensure we have the necessary details to assist you. Thanks!
Category
[x] Bug
[ ] Enhancement
Problem Area
[ ] Page Transformation: Error during the setup/use of the Page Transformation UI solution (did you check our troubleshooting guide?)
[ ] Page Transformation: Error during the use of page transformation from PnP PowerShell
[ ] Page Transformation: Error during the use of page transformation from .Net
[x ] Page Transformation: Page is not looking correct after transformation
[ ] Modernization Scanner: something went wrong...
Expected or Desired Behavior
Content Editor webparts that include Iframes in the html should display on modernized version of page.
Observed Behavior
The modernized page Looks like this:

The actual text of the CEWP is attached.
clocks.txt
Not sure if its even possible to include an iframe in a modern text webpart

Hey @russgove ,
If an iframe is used for embedding a video than it's modernized...but only if not inside a table. In this case, the iframe is inside a table and modern text editor does not support rich content inside a table. Second thing is that this is not a video embed...so what you see is by design. In this case it's recommended to manually update this page and use the modern clock web part to show the time for the respective places.
I'm closing this question, feel free to re-open if you need more info.


add Stage.

This PR implements the Stage + the Sign in flow for it.
This is how the Sign in flow looks:

great!
Some things I noticed:

[ ] the discord link doesn't work. Please use: https://discord.gg/JP9bWxNbwS

[ ] we need a navigation point for stage. Let's replace "speaker" with "stage"

we need a navigation point for stage. Let's replace "speaker" with "stage"

Addressed at https://github.com/gitpod-io/devxconf.org/pull/99


more parse jets

I'm moving this back to draft because it's not clear it actually improves anything.

Appears all clear from my end, after latest changes. Boot times:
Before = 12m 00s
After = 11m 06s

@eamsden Ping - this PR is good to merge, pending your review


MAVSDK rocks.  Kudos to the developers.

MAVSDK rocks.  Kudos to the developers.  Thanks for sharing.

Best issue so far! Thanks @linuxguy123, very much appreciated! I'll leave it open for a bit longer :smile:

Thanks @linuxguy123, really appreciated :blush:

Let's close the other 100 issues and then this one, shall we? :smile: