Allow Meta mixins

this small change allows Meta mixins, I talked about this on discord in #beginner (2023-08-04)
dir might be a bit slower than __dict__ since it bubbles though mro, but I don't think it runs often enough to be even noticeable
My usecase is: I have 5 different tables and 6 different forms for the same model based on user "role", they differ too much to have one class but still share some properties. I use inheritance now, but I think Meta mixins would make it much cleaner
@jlubcke should check this for potential problems

hmm, is it possible the dir changed the order of links in test_edit_table? 🤔

yeah, dir() - The resulting list is sorted alphabetically :(
I havent thought about it, then this PR is useless and can be closed
sorry for bothering you, I forgot to test it localy first

yea, that's what I was trying to do, but thanks to current for key in class_.Meta.__dict__: the foo = 1 gets lost, because Meta.__dict__ does not contain properties of BaseMeta

there might be a way to go through mro(class_.Meta) and read from all of their .__dict__, not sure if it isnt too complicated or slow?

tests ok, but I havent checked if it works :D maybe a new test would be needed too
but the question also is, would you agree with such a change...?

jlubcke says "helt rätt!" (absolutely correct) :P

I'm even a bit happy :)

nice, thanks!
btw there I have value = getattr(class_.Meta, key) which might also be value = getattr(meta_class_, key), but I didn't see a reason for that, because in the end it's gonna be the same value :)


URLEncoding with %2F leads to request issues

If you request an URL e.g. http://example.com/thumbnails/testfolder%2Fimage.png AsyncHttpClient converts this to: http://example.com/thumbnails/testfolder/image.png and requests this url instead (which it defently shouldn't)!

%2F is the URLEncoded char /

Quick workaround is: asyncHttpClient.setURLEncodingEnabled(false) (use with caution)

You pointed out correct way to solve your problem, however automatically encoding/decoding urls is something that works for everyone else, and not converting %2F to slash char seems a tad weird to me. This won't be addressed on library side.


Split protable vector types tests into multiple crates

The tests are still defined inline with the code but now there are a bunch of macros that control whether they are compiled or not.
The crates/coresimd_v{...}_tests then define these macros to include the tests.
To avoid recompiling coresimd, these crates add it as a dependency, and they include ppsv module using #[path = "..."].

Looks great to me! My only real comment is about moving these to unit test crates rather than actual crates (which I think won't be too hard?), but otherwise looks good!

@alexcrichton done! I've never thought about the files in the tests/ directory as "crates" ! But that's exactly what they are, thanks!

I've merged the rustc reduction intrinsics here to remove the codegen modules.

#379

#492


fix: upgrade to version 3.1.53

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign hferentschik
You can assign the PR to them by writing /assign @hferentschik in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
1b8353f63bac96054ddef03984e47ffb9f3dfd80
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/retest

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
1b8353f63bac96054ddef03984e47ffb9f3dfd80
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


Can I get the releases of repository by gogs api?

Very interested for me.

Same to me

I wanted also


BUG: NO PROPER ALLIGNMENT OF NAV BAR

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

hey  @HS202022  i have fixed this in  PR #355  kindly check the updated site


Trigger chat variable completion on word start

closes #216757
Added optional boolean parameter to computeCompletionRanges called onlyOnWordStart, which dictates to return the range only if the found varWord is at word start.
Set it as true on chat input variable completion (#)

@roblourens Right you are, changed it to use matched word start column

With this change, if I just type c# I still get the suggest widget popup

fell for the classic off by 1 error, fixed and tested


[FLINK-32734][build] Adds .mvn/maven.config to .gitignore

What is the purpose of the change
This allows the checkout-specific customization of the Maven build (e.g. setting a different local repository).
Brief change log

Added .mvn/maven.config to .gitignore

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

LGTM
P.S. In theory support of user properties should help here
however it was added in 4.0.0 only https://issues.apache.org/jira/browse/MNG-6303

I'm merging this one despite the feature freeze because it's unrelated to the Flink code base.


Add one-of functionality to verification of list claims

Add one-of functionality to verification of list claims
Currently the verification of a claim implemented as a list using withArrayClaim() verifies the claim object using a containsAll()-function. Meaning the token must include all of the elements present in the list input to withArrayClaim().
Problem:
A "one-of" check when verifying a list claim is valid. (See for example: https://github.com/auth0/java-jwt/pull/472 and the verification of Issuer.  They both use the "one-of" verification. ) However it is now limited to only the hardcoded issuer and audience.
Use-case:
My company uses company-roles as a a claim in the token. ("roles: ["admin", "team-member"]). The roles I would like to verify a token with could be mutually exclusive, meaning a user only has one of them. For example: "grant access if user has either "admin" or "consultant" role.
Solution: Add "anyOf" methods in addition to the withArrayClaim()-methods.
Extend the interface to also include withAnyOfArrayClaim() similar to the withAnyOfAudience() that will verify if the claim in the token contains any of the elements in the given list.
Current workaround:
Currently we remove the withArrayClaim() from the JWTVerifier usage and rather validate the claim manually from the DecodedJWT. This has created some structural issues in the code and feels unsafe going outside the library for such an important validation step.
Additional context
This PR: https://github.com/auth0/java-jwt/pull/472 essentially makes the changes, but only for audience. However audience is not the only valid "one-of" claim.
I realise withArrayClaim() is to be deprecated in the next version: https://github.com/auth0/java-jwt/pull/403
This functionality will not easily be implemented with the map-based objects, as you'd have to specify each map-level as either a "one-of" or a "exact-match".
I've seen multiple attempts at "custom" or "map base" validation functionality being denied. In my eyes this is not added functionality so much as it should have been available from the get-go when withArrayClaim was added.

Thanks for the detailed information and use case. This does seem like a valid use case to support. We'll add it to our backlog; it may not be something we tackle immediately, but will be good to support.

Thanks! Is there anything I can do to help speed up the process? At the moment we are using the workaround, but I'd prefer it if we could avoid it as soon as possible, :)

śr., 10 lut 2021, 09:04 użytkownik Jørund Amsen @.***>
napisał:

Add one-of functionality to verification of list claims
Currently the verification of a claim implemented as a list using
withArrayClaim() verifies the claim object using a containsAll()-function.
Meaning the token must include all of the elements present in the list
input to withArrayClaim().
Problem:
A "one-of" check when verifying a list claim is valid. (See for example:
#472 https://github.com/auth0/java-jwt/pull/472 and the verification of
Issuer. They both use the "one-of" verification. ) However it is now
limited to only the hardcoded issuer and audience.
Use-case:
My company uses company-roles as a a claim in the token. ("roles:
["admin", "team-member"]). The roles I would like to verify a token with
could be mutually exclusive, meaning a user only has one of them. For
example: "grant access if user has either "admin" or "consultant" role.
Solution: Add "anyOf" methods in addition to the withArrayClaim()-methods.
Extend the interface to also include withAnyOfArrayClaim() similar to the
withAnyOfAudience() that will verify if the claim in the token contains
any of the elements in the given list.
Current workaround:
Currently we remove the withArrayClaim() from the JWTVerifier usage and
rather validate the claim manually from the DecodedJWT. This has created
some structural issues in the code and feels unsafe going outside the
library for such an important validation step.
Additional context
This PR: #472 https://github.com/auth0/java-jwt/pull/472 essentially
makes the changes, but only for audience. However audience is not the
only valid "one-of" claim.
I realise withArrayClaim() is to be deprecated in the next version: #403
https://github.com/auth0/java-jwt/pull/403
This functionality will not easily be implemented with the map-based
objects, as you'd have to specify each map-level as either a "one-of" or a
"exact-match".
I've seen multiple attempts at "custom" or "map base" validation
functionality being denied. In my eyes this is not added functionality so
much as it should have been available from the get-go when withArrayClaim
was added.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/auth0/java-jwt/issues/474, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE2EW4GAWAT3WAKPBWIH7VDS6I4XNANCNFSM4XMPHBQA
.


Error after restart

EROR[12-06|09:26:10] error getting scheduler state            err="Get http://<IP_ADDRESS>:5000/debug/state: net/http: request canceled (Client.Timeout exceeded while awaiting headers)"

Could not recover it.
I needed to create a new cluster.
I found some similar issues: #3424 #4155 #4167 #4107.
There is a wondering way to recover this?
I'm coming from dokku and today I was 4hs offline.
This is worrying.

Without the full cluster logs, we will not be able to diagnose the issue and fix bugs (if any).

I really missed the logs.
How can I generate them? If needed again.
flynn-host collect-debug-info gave me
EROR[12-06|09:26:10] error getting scheduler state err="Get http://<IP_ADDRESS>:5000/debug/state: net/http: request canceled (Client.Timeout exceeded while awaiting headers)"
flynn-host fix --min-hosts = 1 everything was green but did not solve ...
I was very happy with Flynn
It's a great job.

Flynn is unmaintained and our infrastructure will shut down on June 1, 2021. See the README for details.


Center title and links in README

This is intended to improve accessibility of documentation and better UI. But, this comes at cost of including HTML directly inside markdown due to limitations of markdown syntax and affects readability of README.
Included Changes

Title, tagline and badges centered
Quick link to website, install instructions, features, options and API. Centered and separated with vertical bar (|)
Moved preview to top, So user don't have to scroll the lengthy features list to see how beautiful the prompt looks
Link to contributors pages
Link to preview setup just below preview (It have been asked so.. many times)

Direct link to branch page: salmanulfarzy/spaceship-prompt@center-doc

Before

After

Could you also check #396 ? Our documentation on website haven't updated in the last several months. Anything that I could to get that merged ?


Handle ObjcCompile actions with CppCompileInfo [phab:D1476]

Created by salguarnieri at 2017-04-03 15:58:59:
Sometimes ObjcCompile actions will have CppCompileInfo instead of
SpawnInfo for the extra action info. CppCompileInfo doesn't contain the
necessary environmental variables, but we can still make a best effort
to reconstruct the clang arguments.

salguarnieri wrote at 2017-04-03 16:00:31:

add newline

shahms commented inline (context lost during migration) at 2017-04-03 16:07:05:
Don't return success if we can't load the config?

shahms wrote at 2017-04-03 16:07:05:
One minor nit

shahms accepted this revision at 2017-04-03 16:07:05

salguarnieri wrote at 2017-04-03 16:12:59:

return non-zero if we can't load the extra info

salguarnieri commented inline (context lost during migration) at 2017-04-03 16:13:33:
PTAL

shahms wrote at 2017-04-03 16:19:23:
Still LGTM

salguarnieri closed via commit 14eb2098957e722b10c8c292c1db98e0b48f41f3 at 2017-04-03 16:20:43


chore: switch default branch to main

Switching all master references before switching the branch over

🚀 Styleguide deploy preview ready!https://5f21c64b9bc04de8713946ab--gamut-preview.netlify.appDeploy Logs


Black Coach's Damage Table doesn't display correctly

Issue: When using the Black Coach from Age of Sigmar's "Death - Nighthaunt" army the Damage Table doesn't show up correctly
Example of current bug:

Expected outcome:
Have a table that shows the chart of distance and attack count by wounds taken
Example from BattleScribe:

Example from AoS Mobile App:

rosz file containing only Black Coach (in a zip file):
BlackCoachOnly.zip
Things I've tried:

Switching optional weapon between Soulreach Grasp and Reaper Scythe
Naming the unit
Adding other units to the same roster

Possibly related, can open a new bug if you'd like:
The table for "Evocation of Death" doesn't appear in numerical order:
Example from PrettyScribe:

As displayed in BattleScribe:

Fixed.

Would you like me to open a second bug report for that part with the Evocation of Death levels?

Yes, please.  There is a general sorting problem in Prettyscribe.  Some Damage Tables are not sorted and some ability tables are not sorted.

Done in #67 - thanks for taking a look at all of this!


bos balance fluctuates with HTLCs

This may be an issue for LND not serving enough info in the APIs, but it seems that bos balance is fluctuating as the HTLCs are adjusting. As a node with dozens of in-flight HTLCs constantly, using bos balance does not provide a reliable snapshot of the funds that belong to the node. Running bos balance repeatedly returns amounts that are +- hundreds or millions of sats.
Is this because one side of the HTLC may be accounted for but not the other? Or is it a timing issue with gathering the stats while an HTLC comes or goes?
To illustrate, running this on my node just now:
for i in {1..10}; do bos balance; done

produces 10 outputs that contain the following numeric diffs from the prior output:
0
131,262
29,475
-183,471
418,886
-45,778
200,202
-19,258
-42,071
-312,242

To clarify user expectations, I would think that bos balance would return an answer to the question of "What number of sats does this node own if all current HTLCs are assumed to fail/cancel?"

did you try using bos balance --detailed

That seems to be more what I'm looking for (the offchain_balance output from --detailed). Thanks!


fix: useBreakpoint fix nextJS warning

Closes #
📝 Description

Add a brief description

⛳ Current behavior (updates)

Please describe the current behavior that you are modifying

🚀 New behavior

Please describe the behavior or changes this PR adds

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.93%. Comparing base (2c1bd30) to head (223ab90).
Report is 1 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   99.18%   98.93%   -0.25%
==========================================
  Files          19       12       -7
  Lines         366      281      -85
  Branches      106       81      -25
==========================================
- Hits          363      278      -85
  Misses          3        3

Flag
Coverage Δ

PhoneInput
98.36% <ø> (ø)

useBreakpoint
?

useClickOutside
100.00% <ø> (ø)

usePreserveInputCaretPosition
100.00% <ø> (ø)

usePrevious
100.00% <ø> (ø)

useSelectionRange
100.00% <ø> (ø)

useToggle
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


HTML5 export, not all objects exported

Godot version: 3.2.3

OS/device including version: running godot on Linux (Lubuntu/Ubuntu)

Issue description: When export to HTML5 and run in (firefox) browser, the game kind of runs but no red ball is shown. When I run the game in Godot or when I generate executable for Linux, it works correctly, the red ball is shown:

Steps to reproduce: clone the https://gitlab.com/isokissa/games/zivac, export game to HTML5, start the local server and goto localhost:, or go to https://isokissa.gitlab.io/games/zivac/ to see the game which does not show the red ball. When you run within Godot, or exported to Linux executable, there is a red ball
Minimal reproduction project: https://gitlab.com/isokissa/games/zivac (it is just a beginning of the project: look at the arena/arena scene, where Ball scene is instantiated. That Ball scene from Arena is not shown when run in HTML5 export)

I can confirm this on Chromium 87 and Firefox 86 (Linux).

@Calinou using sprite did not help. It is again visible when running as application, but not in browser.

@Calinou apparently it depends on the shape of the browser screen. If it's wide so that black areas are shown on the side, then the ball does not show. If the windows is narrow, so that black areas are on top and bottom, then the ball is shown, but at wrong place (I guess also in wide case it is in wrong place, but out of screen, so that's the reason why it is not shown)

This means, the problem is that HTML5 export, this code
func ball_spawn():
	var middle: Vector2 = OS.window_size / 2
	get_node("Ball").position = middle

does not put Ball in the middle of the window as when ran standalone  (Ball's position (0,0) is in the origin)

This is not a bug, you're using the wrong variable, OS.window_size gives you the size of the container the game exists within not the size of the game's viewport or in other words the size including the black bars. the correct variable you wanted would be get_tree().get_root().get_size(), this give you want the game's main viewport size after stretch mode has been applied / after the black bars have been applied.


denylist not working for freetype and mingw-openssl

freetype and mingw-openssl are part of the autobuild denylist, but both have build attempts daily.  Examples:

https://koji.mbox.centos.org/koji/taskinfo?taskID=266644

https://koji.mbox.centos.org/koji/taskinfo?taskID=266403

https://koji.mbox.centos.org/koji/taskinfo?taskID=265957

https://koji.mbox.centos.org/koji/taskinfo?taskID=266646

https://koji.mbox.centos.org/koji/taskinfo?taskID=266405

https://koji.mbox.centos.org/koji/taskinfo?taskID=265959

Fixed by 65a9e1c199cabb709e744d9a8e9b4ebc2d809272

In #25 I switched freetype and mingw-openssl to the nvr=<nvr> syntax, but that doesn't appear to be working.  Builds were recently attempted for the exact nvrs I'm trying to exclude.  Am I doing that syntax wrong or is this a bug?

https://koji.mbox.centos.org/koji/taskinfo?taskID=268383
https://koji.mbox.centos.org/koji/taskinfo?taskID=268382

Ok, maybe/hopefully fixed by 525da6b


fix(api): use npa@5 for spec parsing

BREAKING CHANGE: spec objects can no longer be realize-package-specifier objects. Pass a string or generate npa@>=5 spec objects to pass in.

late night review says: looks good


Broken links, continued

Summary
Fixing broken links. We had a bunch of links changed in includes without specifying version, so everything before 3.0.x broke.
Reason
Broken links: https://github.com/Kong/docs.konghq.com/runs/8123641467?check_suite_focus=true
Testing
Netlify

@cloudjumpercat fixed. The old doc-assets images are not going to be findable, unfortunately - a couple of months ago, this hosting site was taken down (I think it was a wordpress site?), and we don't have access anymore. For the most part, the old images hosted at doc-assets are no longer relevant though, as in the case of the Cognito doc.
The good thing is, the link checker now catches these broken images, so we can fix them as we run into them going forward.


Cannot build docker image

Describe the bug
Cannot build docker image using Dockerfile.
To Reproduce

run command docker build -t <image-name> .
docker fails to build the image with following error: ERROR: failed to solve: process "/bin/sh -c python3 setup.py install" did not complete successfully: exit code: 1

According to the output, docker fails to solve RUN python3 setup.py install, specifically, by the following error: huggingface-hub 0.17.3 is installed but huggingface_hub<0.17,>=0.16.4 is required by {'tokenizers'}
Temporal fix is that commenting out RUN python3 setup.py install, then resolving the conflict after building the image. However this is not ideal.

@p4thie Do you mind explaining what you mean by this?

then resolving the conflict after building the image

By the way, this worked for us:
FROM nvidia/cuda:12.1.0-base-ubuntu22.04
# replace CUDA version to your CUDA version.
# You can check your CUDA version with below.
# nvcc -V

RUN apt-get update && \
    apt-get install -y git python3 python3-pip

RUN pip3 install torch torchvision torchaudio huggingface-hub==0.17.3 fastapi uvicorn[standard] fsspec[http]==2023.1.0 --no-cache-dir

COPY ../ .

RUN python3 setup.py install

EXPOSE 8503

CMD ["uvicorn", "app:app", "--host", "<IP_ADDRESS>", "--port", "8503"]
# Run this using 'docker run -it -d -p <YOUR PORT>:8503 --gpus all <IMAGE NAME>

@mikeb-btw I was trying to run pip command in the docker environment after building the image (this is what I meant by resolving the conflict ...). Your solution is a lot better than that. For now, anyone has the similar problem might want to modify Dockerfile as you did, then wait for the fix by the nougat team. Thanks a lot!

This fix might help:
https://github.com/facebookresearch/nougat/pull/208


Fix Shell Concurrency

what

aws-vault: error: Server failed: exit status 2

why

aws-vault server should only be run once globally across all shell because it binds to <IP_ADDRESS>

references

https://github.com/cloudposse/root.cloudposse.co/issues/8#issuecomment-408674720

curl -sSL -o /dev/null http://<IP_ADDRESS>/latest/meta-data/iam/security-credentials
result=$?
if [ $result -eq 0 ]; then
  echo "Metadata server already running"
fi


Add service control policy managed notification

Add managed notification to send to customers when cloud credentials are insufficient to satisfy credentials request:
If you see a log with this kind of error message in the cloud credential operator pod logs:
oc logs cloud-credential-operator-6458c79b99-xns6m --tail=50 -c cloud-credential-operator

error syncing credentials: cloud credentials insufficient to satisfy credentials request" controller=credreq cr=openshift-cloud-credential-operator/openshift-machine-api-aws secret=openshift-machine-api/aws-cloud-credentials
time="2022-08-31T22:17:57Z" level=error msg="errored with condition: InsufficientCloudCreds" controller=credreq cr=openshift-cloud-credential-operator/openshift-machine-api-aws secret=openshift-machine-api/aws-cloud-credentials
time="2022-08-31T22:18:42Z" level=info msg="reconciling clusteroperator status"
time="2022-08-31T22:18:42Z" level=info msg="clusteroperator status updated" controller=status

Then it's likely that the customer needs to review their Service Control Policy. See this KCS for more information. We can then send this service log (based on the credreq above)

/lgtm


Issue with DisabledRange component causing "Null check operator used on a null value" error

While using your Flutter library, I have encountered an issue related to the DisabledRange component. When configuring the disabledRange property in my component, the app throws a "Null check operator used on a null value" error during runtime.
The error seems to be triggered by the following code snippet:
dart
disabledRange: DisabledRange(     initTime: _disabledInitTime,     endTime: _disabledEndTime,     disabledRangeColor: Colors.grey,     errorColor: Colors.red,   ),
In this context, either _disabledInitTime or _disabledEndTime (or both) might be null, and the DisabledRange component or its internal logic might be using a null check operator (!) without first checking for null values.
To resolve this issue, I suggest considering the following approaches:
Perform null checks inside the DisabledRange component for _disabledInitTime and _disabledEndTime to avoid using the null check operator when they are null.
Update the documentation for the DisabledRange component to clarify if _disabledInitTime and _disabledEndTime should not be null, or if they can be null, how they should be handled properly.
If _disabledInitTime and _disabledEndTime can be optional, consider providing default values or nullable types for them in the DisabledRange constructor.
I hope this information helps you fix the problem. If you need more details about my setup or code, please let me know.
Thank you for your attention and support. I am looking forward to updates on this issue!

@2811267153 can you please provide me entire code related to this issue, thanks

Closing this issue for now. Please reopen it with more details if needed.


[CARBONDATA-3025]add more metadata in carbon file footer

Changes Proposed in this PR:

Add more info to carbon file footer, like written_by (which will be spark application_name) in case of insert into and load command. To read this info one can use CLI
For SDK this API will be exposed to write this info in footer and one API will exposed to read this info from SDK.
footer will have information about in which version of carbon the file is written, which will be helpful for getting details, for comaptibility etc

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1037/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9105/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/846/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9111/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1043/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/860/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9124/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1058/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1108/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/908/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9174/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/915/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1115/

retest this please

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9181/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1123/

@akashrn5 Instead of changing many classes to pass writtenBy and appName can't we set to CarbonProperties and in writer step we can get from the same and write to thrift??

@akashrn5 Instead of passing writtenBy and appName to all the classes can't we set to CarbonProperties and in writer step we can get from the same and write to footer??

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9187/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/932/

retest this please

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1133/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9194/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/936/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1138/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9200/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1142/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/946/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9211/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1154/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1162/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/957/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1170/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/962/

Build Success with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9230/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/969/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1179/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1002/

Build Success with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9268/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1215/

@akashrn5 Instead of changing many classes to pass writtenBy and appName can't we set to CarbonProperties and in writer step we can get from the same and write to thrift??

handled

LGTM


Refreshed tokens not applied

If socket has already connected through a valid token and token gets refresh after a while, the library still using the old token and that will cause 401 subscription_error on subscribe requests!
I'm experiencing this on socket.io adapter.
Any ideas on how solve this?

I experience the same issue due to working with nuxt-auth + laravelJWT refresh scheme. I've tried to listen for axios.onResponse data with new access_token but didn't helped. So dirty workaround for now it that I set actual access_token by this:
 this.$echo.options.auth.headers['Authorization'] = this.$auth.strategy.token.get()
have found better fix?


gosrc: Use unmodified clone URL from import meta tag for cloning.

This fixes a regression in #353 that caused vcs.download to fail for some valid go gettable packages because an incorrect clone URL value was being used.
The clone URL value had a possible ".git" suffix trimmed, which is not correct according to how remote import path resolution is documented at https://golang.org/cmd/go/#hdr-Remote_import_paths.
Fixes #356.

There are 2 commits in this PR (at this time). The first one does a minimum diff fix, the second refactors it to make the end result cleaner and more readable for future maintainers.

Here's some more background on the issue (as reported in #356).
This logic is where the problem (in original code) was:
// getDynamic gets a directory from a service that is not statically known.
func getDynamic(client *http.Client, importPath, etag string) (*Directory, error) {
	metaProto, im, sm, redir, err := fetchMeta(client, importPath)
	if err != nil {
		return nil, err
	}

	if im.projectRoot != importPath {
		...
	}

	repo := strings.TrimSuffix(im.repo, "."+im.vcs)
	i := strings.Index(repo, "://")
	if i < 0 {
		return nil, NotFoundError{Message: "bad repo URL: " + im.repo}
	}
	proto := repo[:i]
	repo = repo[i+len("://"):]
	dirName := importPath[len(im.projectRoot):]

	resolvedPath := repo + dirName
	dir, err := getStatic(client, resolvedPath, etag)
	if err == errNoMatch {
		resolvedPath = repo + "." + im.vcs + dirName
		match := map[string]string{
			"dir":        dirName,
			"importPath": importPath,
			"repo":       repo,
			"scheme":     proto,
			"vcs":        im.vcs,
		}
		dir, err = getVCSDirFn(client, match, etag)
	}
	if err != nil || dir == nil {
		return nil, err
	}

The value of im.repo is initially "https://gitlab.com/xojoc/engine.git". Then ".git" suffix is trimmed in this line:
repo := strings.TrimSuffix(im.repo, "."+im.vcs)

That eventually gets passed to downloadGit via matches["repo"], but that's an incorrect value to use there since it has stripped out the ".git" suffix, which is not correct according to go get logic (as specified in https://golang.org/cmd/go/#hdr-Remote_import_paths).
I initially tried to modify matches["repo"] to not strip out the vcs suffix, but that affects too many other things. The entire codebase relies on matches["repo"] not having a .git or .hg suffix, and I'm not familiar enough with the entire codebase and the redis data scheme to be able to safely change that design decision.
Instead, I opted for a less nice (because it adds more code) but simple and reliable solution, adding a new variable "clonePath", which is exactly like repo but without trimming the vcs suffix. It's the repo URL as specified in import meta tag, with the schema and "://" prefix trimmed. This new "clonePath" variable is used only for downloading VCS data.

I think this one line change has the same result.
@@ -340,7 +340,7 @@ func getDynamic(client *http.Client, importPath, etag string) (*Directory, error
                match := map[string]string{
                        "dir":        dirName,
                        "importPath": importPath,
-                       "repo":       repo,
+                       "repo":       im.repo[i+len("://"):],
                        "scheme":     proto,
                        "vcs":        im.vcs,
                }

@CrunchMilk, are you suggesting that one line diff has the same effect as this entire PR?
If so, I don't think that's true. That was the first thing I tried, but I described it in this paragraph why it doesn't work:

I initially tried to modify matches["repo"] to not strip out the vcs suffix, but that affects too many other things. The entire codebase relies on matches["repo"] not having a .git or .hg suffix, and I'm not familiar enough with the entire codebase and the redis data scheme to be able to safely change that design decision.

I looks like the fields set from matches["repo"] are reset before getDynamic returns.

That may be so, but the problem will happen even before that. downloadGit itself uses the value of matches["repo"] in various ways. One of those ways is for cloning path, but other ways include lines such as:
dir := filepath.Join(TempDir, repo+".git")
If that value of repo doesn't trim .git suffix, dir may end up having a ".git.git" suffix which will cause failures down the line.
It would also be confusing to reuse the same variable matches["repo"] having different values in different contexts. The entire point of 79480da4edc50a29841ab53881abd66dfe899e5f was to try to document and make it more clear what's going on.

Friendly ping.

This fixes a regression in #353 that caused vcs.download to fail for some valid go gettable packages because an incorrect clone URL value was being used.

Generally looks good. Commented on one thing.


@vue/compiler-sfc Please use @jridgewell/sourcemap-codec

What problem does this feature solve?
warning vue > @vue/compiler-sfc > magic-string ><EMAIL_ADDRESS>Please use @jridgewell/sourcemap-codec instead
What does the proposed API look like?
Please use @jridgewell/sourcemap-codec

Duplicated #7329


Added Baseline Color Policy

Description
Also add #159
Add a policy that looks at a color
Testing procedure
Testing is TODO, but worked with 2 participants yesterday, so will merge.

[x] Run your code through pylint and address all warnings/errors. The only warnings that are acceptable to not address is TODOs that should be addressed in a future PR. From the top-level ada_feeding directory, run: pylint --recursive=y --rcfile=.pylintrc ..

Before Merging

[ ] Squash & Merge

@amalnanavati Merging now to work on infra in a separate branch.


S02-172. Steve dockerfile update

WELCOME TO DEVOPS-EASY-LEARNING PULL REQUEST SYSTEM
Description of the change
Steve dockerfile update
Checks and balances

[ ] Tests added and run
[ ] (External) Interfaces documented
[ ] Has security implications (describe below)

Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)

Related stories, issues and pulls
https://devopseasylearning.atlassian.net/browse/S02-172
Security considerations
None

thank you


Support async subscribe callbacks

For example:
space.subscribe('update', async () => {
  const members = await space.members.getAll();
});

@ttypic

Could you also slightly update demo project, right now it is using IIFE for async callbacks

Can I please leave that to you (or someone else) to do as a follow up? I won't have time for it, but this issue is blocking the cursors evaluation that I'm working on.


Help using rootfinder

Hello,
rootfinder solves equation 0 = f(y,\theta). This equation may have no solution. Does it return a value, or a parameter that I can use to detect this is no solution ?
Thanks !

If there is no solution found, then it will raise a warning and return the values y that makes f(y,\theta) closest to 0.


this link https://raw.githubusercontent.com/second-state/wasmedge-seL4/main/build.sh  Is it not working?

hello！ please ask this link https://raw.githubusercontent.com/second-state/wasmedge-seL4/main/build.sh
Is it not working?

this link https://gerrit.googlesource.com/git-repo/ is also not work?   Is there something wrong with my network?

It seems like you need to jump the wall.

It seems like you need to jump the wall.

Thank you! but i have jump the wall to America, and it does not work. Can you guys access this link?

We did.

Everything is fine. I believe the only issue is the GFW.

Everything is fine. I believe the only issue is the GFW.

I got it, then I found a mirror that successfully solved the problem, https://github.com/GerritCodeReview/git-repo. But now I'm still missing the last step, it looks like there's something wrong with cmake, reporting an error as shown here


Rebase closingiterator and apply changes since it was first posted.

This is a resubmission of https://github.com/getsentry/raven-python/pull/630 which I have confirmed fixes https://github.com/getsentry/raven-python/issues/599.
I'll let @mattrobenolt and @mitsuhiko rehash their conversation here and close the past PR.

This change is

Huge thanks for looking into this fix!! Just verified locally that this branch fixes the issue with our setup:
Python 3.5.1
aiohttp (0.21.6)
gunicorn (19.5.0)

Merged this in a modified version.


unify servicer & unix_servicer

Fell into a rabbit hole when fixing a tiny test in #1925 and realized I wanted support for using the same servicer in both the client and the container. Previously we actually had two different instances of MockClientServicer which managed all the fake backend state.
Unifying it makes it a bit easier to write container tests that deploy objects and then look them up from the container.
It would have been fairly easy to work around it, but I decided to go the slightly harder and more annoying route and unify the two objects so it's just one.

@prbot approve

yolo merge since this is blocking me – low risk since it's just test changes

yolo merge since this is blocking me – low risk since it's just test changes

Oh sorry, I took a look this morning but forgot to add my review! Lgtm


Fix accessibility issues

Fix issues identified in accessibility testing for screenreading and
high contrast.
Fixes:
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/976599
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/976603
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/976611
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/976620
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/977013
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/977015
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/979315
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1002299

🚢


Warning: datetime.datetime.utcnow() is deprecated

Seeing this warning from the test suite.

TIL: https://til.simonwillison.net/python/utc-warning-fix


Alignment and Overlapping of Buttons

Hi @SurajPratap10,  I wanted to bring an issue to your attention regarding the alignment and overlapping of buttons on the Webpage.
Description:

I would like to raise an issue regarding the alignment and overlapping of buttons on the webpage. This issue is impacting the user experience, particularly on tablet and desktop devices. I believe addressing this problem will greatly enhance the usability of the platform.

Problem:
The current alignment of the "Try It" and "Generate" buttons is not visually appealing and can confuse users. Specifically, the "Try It" button is overlapping with the image description section on tablet and desktop devices, which hampers user interaction. Additionally, the "Generate" button within the image description section has excessive vertical spacing, which negatively affects the overall aesthetics of the page.
Proposed Solution:
To improve the alignment and usability of the buttons, I suggest implementing the following solutions:

Adjust the alignment of the "Try It" and "Generate" buttons to ensure they are visually separated and positioned correctly within their respective sections.
Fix the overlapping issue by ensuring that the "Try It" button does not overlap with the image description section on tablet and desktop devices.
Reduce the excessive spacing above and below the "Generate" button in the image description section, achieving a more compact and visually balanced layout.

Alternative Considerations:
While the proposed solutions should address the alignment and overlapping issues effectively, alternative approaches could be considered. These may include:

Adjusting button sizes: Evaluate the size of the buttons to ensure they are proportionate to the surrounding elements. Enlarging the buttons slightly or reducing their size can help achieve better alignment and spacing within the page layout.

Optimizing button placement for different devices: Consider responsive design techniques to ensure the buttons are appropriately positioned on various devices. Testing the placement on different screen sizes and resolutions can help identify any issues specific to certain devices and allow for adjustments accordingly.

Additional Context:
Mobile

Tablets and Desktops

I am participating in GSSOC 23 and have previous experience in resolving similar issues related to UI/UX improvements. With my expertise, I am confident in my ability to tackle this issue effectively and contribute.
Regards,
Premsai Varma

I am not facing these issues , check the website again https://imagine-ai-17zf.vercel.app/


feat!: fix parse errors, update grammar to v3.5.1

Breaking changes:

Renamed (redirected_statement) to (redirect_statement)
Removed (comand_substitution_fish) and (command_substitution_dollar)
Those nodes were added only because fish 3.4.0 allowed the following syntax:echo "$$(echo TERM)"

In version 3.5.0 this syntax is no longer valid.
This effectively changes the node tree, so:(command_substitution
  (command_substitution_dollar (_))

Now becomes:(command_substitution (_))

test 0 = 0 is no longer (test_command) - it is now (command name: (word) (_))
This change was made because only [ <expr> ] is a special syntax for test command.
(test_command) node only matches [ <expr> ]

Fixes:

Fixed parsing error of the following example
systemctl 2>/dev/null $argv

Previously, redirects were expected to be at the end of the statement.
Now, (command) has additional field called redirect.

This should make highlighting builtin commands easier.
I reverted addition of (builtin). IMO this will have to wait until the parse problem with function --help is solved.
https://github.com/ram02z/tree-sitter-fish/blob/84436cf24c2b3176bfbb220922a0fdbd0141e406/grammar.ts#L2
Update: I also removed todo to support function --help since such commands make sense only in REPL. I doublt it is the use case of this parse.

Having (builtin) node increases src/parser.c size to  940 KB. Without it the size would go down to 501 KB.
Up to discussion whether it is worth to have ;]

@taekwombo Thanks for the PR! Sorry I haven't had much time to take a look at the PR properly, but the changes look good. Thanks again for the informative PR description :)
One thing I am wondering is if  https://github.com/nvim-treesitter/nvim-treesitter/pull/3752 needs to be updated since you are using the builtin node in that PR but you ended up removing it from this PR.

Yes, it needs to be updated.
Fortunately changes from this PR won't break anything until I also update lockfile in nvim-treesitter. So I will have some time to adjust another PR event after this is merged.


Use kubecli API instead of k8s client API

During PR reviews of code merge from POC branch to master we moved away from kubecli  API and started using k8s client API. But that has caused regressions and also does not support all the features that come from kubevirt.
Moving back to using kubecli API.
Also fixed couple of bugs found during testing. GetVolumeFormat was missing check for PVC type.
Was able to start apps of all types.

VMs 2) Container as VM and 3) Native container

sshd-app-native-cont-0b01b               1/1     Running   0          24m
cf4b1766-574b-4974-bfac-be568107225c:/# kubectl get vmi -A
NAMESPACE      NAME                 AGE   PHASE     IP    NODENAME                 READY
eve-kube-app   ubuntu-vm-a0165      40m   Running         hp-server-bottom-shelf   True
eve-kube-app   sshd-vm-cont-c92a1   36m   Running         hp-server-bottom-shelf   True

Btw. I also tested it and can confirm that all types of apps do work now.


[SP-3586] Backport of PDI-15982 - Incomplete/Missing logs when Main Job with sub jobs are scheduled (7.1 Suite)

backport of #3906

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f core/build.xml clean-all resolve jacoco && ant -f core/build.xml checkstyle publish-local
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -f engine/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  core/src/org/pentaho/di/core/logging/LogChannel.java
  core/src/org/pentaho/di/core/logging/LogChannelFileWriterBuffer.java
  core/src/org/pentaho/di/core/logging/LoggingRegistry.java
  core/test-src/org/pentaho/di/core/logging/LogChannelFileWriterBufferTest.java
  core/test-src/org/pentaho/di/core/logging/LoggingRegistryTest.java
  engine/src/org/pentaho/di/core/logging/LogChannelFileWriter.java
  engine/src/org/pentaho/di/www/CarteSingleton.java
  engine/test-src/org/pentaho/di/core/logging/LogChannelFileWriterTest.java

Newly Fixed Tests:
org.pentaho.di.trans.steps.syslog.SyslogMessageConcurrentTest.concurrentSyslogMessageTest:
:large_blue_circle: org.junit.runners.model.TestTimedOutException
org.junit.runners.model.TestTimedOutException: test timed out after 10000 milliseconds
	at java.net.PlainDatagramSocketImpl.datagramSocketCreate(Native Method)
	at java.net.AbstractPlainDatagramSocketImpl.create(AbstractPlainDatagramSocketImpl.java:80)
	at java.net.DatagramSocket.createImpl(DatagramSocket.java:337)
	at java.net.DatagramSocket.<init>(DatagramSocket.java:239)
	at java.net.DatagramSocket.<init>(DatagramSocket.java:196)
	at org.productivity.java.syslog4j.impl.net.udp.UDPNetSyslog.cr

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.core.logging.KettleLogLayout

Branch Change:  + 7.69%
Complexity Change:  + 4.76%
Instruction Change:  + 5.97%
Line Change:  + 4.17%

org.pentaho.di.core.logging.LogChannel

Branch Change:  + .85%
Complexity Change: -.56%:small_red_triangle_down:
Instruction Change:  + .54%
Line Change:  + .48%

org.pentaho.di.core.logging.LogChannelFileWriterBuffer

Branch New Coverage: 100.00%
Complexity New Coverage: 100.00%
Instruction New Coverage: 88.10%
Line New Coverage: 100.00%
Method New Coverage: 100.00%

org.pentaho.di.core.logging.LoggingRegistry

Branch Change:  + 4.21%
Complexity Change:  + 5.12%
Instruction Change:  + 7.21%
Line Change:  + 4.97%
Method Change:  + 5.61%

org.pentaho.di.core.lifecycle.KettleLifecycleSupport

Branch Change:  + 8.33%
Complexity Change:  + 9.09%

org.pentaho.di.core.logging.LogChannelFileWriter

Complexity Change:  + 21.43%
Instruction Change:  + 40.00%
Line Change:  + 41.86%
Method Change:  + 21.43%

org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics

Branch Change: -.39%:small_red_triangle_down:
Complexity Change: -.51%:small_red_triangle_down:
Instruction Change: -.08%:small_red_triangle_down:

org.pentaho.di.job.entries.evaluatetablecontent.JobEntryEvalTableContent

Branch Change: -2.02%:small_red_triangle_down:
Complexity Change: -2.13%:small_red_triangle_down:
Instruction Change: -.34%:small_red_triangle_down:

org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change:  + 1.00%
Complexity Change:  + 1.41%
Instruction Change:  + .30%

org.pentaho.di.job.entries.syslog.SyslogDefs

Branch Change:  + 5.88%
Instruction Change:  + 1.72%
Line Change:  + 5.97%

org.pentaho.di.trans.step.BaseStep

Branch Change: -.15%:small_red_triangle_down:
Complexity Change: -.18%:small_red_triangle_down:
Instruction Change: -.05%:small_red_triangle_down:
Line Change: -.08%:small_red_triangle_down:

org.pentaho.di.trans.steps.combinationlookup.CombinationLookupMeta

Instruction Change:  + .04%

org.pentaho.di.trans.steps.constant.ConstantMeta

Instruction Change:  + .10%

org.pentaho.di.trans.steps.datagrid.DataGridMeta

Instruction Change: -.09%:small_red_triangle_down:

org.pentaho.di.trans.steps.dbproc.DBProcMeta

Instruction Change: -.11%:small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change:  + 3.12%
Complexity Change:  + 3.16%
Instruction Change:  + .28%
Line Change:  + .74%

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change: -2.00%:small_red_triangle_down:
Complexity Change: -1.89%:small_red_triangle_down:
Instruction Change: -.17%:small_red_triangle_down:

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change: -.06%:small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change: -1.18%:small_red_triangle_down:
Complexity Change: -1.35%:small_red_triangle_down:

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change: -.10%:small_red_triangle_down:

org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta

Instruction Change:  + .18%

org.pentaho.di.trans.steps.syslog.SyslogMessage

Branch Change:  + 3.33%
Instruction Change:  + 3.80%
Line Change:  + 5.19%

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change: -.91%:small_red_triangle_down:
Complexity Change: -.82%:small_red_triangle_down:

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change:  + .53%

org.pentaho.di.trans.steps.webservices.WebServiceMeta

Branch Change:  + 1.79%
Complexity Change:  + 1.19%
Instruction Change:  + .07%

org.pentaho.di.www.TransformationMap

Branch Change: -9.09%:small_red_triangle_down:
Complexity Change: -6.15%:small_red_triangle_down:
Instruction Change: -10.03%:small_red_triangle_down:
Line Change: -10.00%:small_red_triangle_down:

@mchen-len-son @pamval please review


two editor in one controller

In my view, there are two editors, and seems the $scope.editor and $scope.editable will conflict. In callback function, only one editor can be accessed.

Hello,
I'm also having the same problem.
I have a page with two Summernote components, but only as an editor can be accessed, can not run on-image-upload event two Summernote.
Please someone could help me.
Thank you.

Hello,
I'm also having the same problem.
Thank you.

Hi! I'm also having the same problem.
I have an array of items, wich inside an ng-repeat use the  directive.
¿Has anybody found a solution for this issue?

Hello,
I managed to resolve this without using the editor.


Add German translation

Bumping this issue, as it seems to be stale

Bumping this issue, as it seems to be stale

Sorry, didn't have much time lately...
I fixed some of the untranslated strings in the most recent commit now.

All good. Gonna try to get a proper review of this so its merged next week 👍

Bumping this pr, as it seems to be stale.

Sorry for this taking so long. Holidays set up all my german translation reviewers to be busy, including glisco. I have found someone with more MM knowledge to finally review the translation, and it should hopefully be done in the coming days/weeks. Going to post one of the review comments here, and add the rest of them once the review is complete.

Alright, I addressed most of the issues you/your second party noted. If I didn't, I should have provided comments.
Happy Easter!

I addressed the previously unresolved notes.

Ah thank you! Just to let you know, I plan on having this merged for the last 1.20 release, followed by porting it to 1.20.6+.
A sidenote: some of the tag translations might change for the port, due to the major tag unification between NeoForge and Fabric. I would appreciate if you are available to look at it when the time comes

If you need me to look at some changes in the translation, feel free to contact me.


CheckMarkCard

Feature
New component: CheckMarkCard 🥳
Similar to RadioCard but with a "checkbox" style functionality.
Solution

Adds a new prop to ChoiceGroup => multiSelectLimit which allows you to pass a number and limit the number of items selected, once the limit is reached the rest get disabled; deselecting an item and thus being under the limit, re-enables the choices.
Adds new component CheckMarkCard, which is used in a similar manner to RadioCard

The main difference with this is that the user should provide the content as opposed to using multiple props for rendering:

// RadioCard

<RadioCard
      icon="fab-chat"
      content="some content"
      heading="Chat"
      value="chat"
      maxWidth="214px"
/>

// CheckMarkCard
<CheckMarkCard label="Derek" value="derek">
        <Avatar size="xl" image={AvatarSpec.generate().image} name="Derek" />
		<div> Name </div>
		<div> Location </div>
</CheckMarkCard>

/*
	It's up to the user to decide what to render and style accordingly
*/

Use it inside of ChoiceGroup in the same way as RadioCard:

<ChoiceGroup multiSelectLimit={3}>
	<CheckMarkCard label="Derek" value="derek" />
	<CheckMarkCard label="Hansel" value="hansel" />
	<CheckMarkCard label="Matilda" value="matilda" />
</ChoiceGroup>

While using the component generator I found some mistakes in the templates, they're fixed here.

Depends on:

https://github.com/helpscout/hsds-react/pull/872
https://github.com/helpscout/hs-app/pull/8824

Relevant Links:

Jira
Spec
Figma
Codepen prototype

Screenshots

A little update on the CheckMarkCard components not reflected on these screenshots is the extra grey border when checked that has now been removed.

Checkbox using the multi-select limit functionality:

Simple CheckMarkCards with different states:

CheckMarkCards with content, inside a ChoiceGroup with a multi-select limit:

Not sure why in this screenshot items seem to flash on selection, try the story to see it properly

Looking great functionally, and I only have a couple of tweaks to the visual design:
1. The default (inactive) state of the cards should have a border, currently they don't (see [c.hlp.sc/mXuynEG1](https://c.hlp.sc/mXuynEG1))

2. The selected state adds a blue border, however it should replace the existing one. Currently the grey stroke is still visible (see [c.hlp.sc/P8ubpWKx](https://c.hlp.sc/P8ubpWKx))

@digitaldesigner Thanks for looking at it!
I made the updates, regarding the borders and shadows I noticed they are slightly different from the RadioCard (I copied some styles from it thinking they were the same):

Do you think they should be the same?

Pull Request Test Coverage Report for Build 3337

54 of 56 (96.43%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.002%) to 94.529%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/CheckMarkCard/CheckMarkCard.jsx
27
28
96.43%

src/components/RadioCard/RadioCard.jsx
11
12
91.67%

Totals

Change from base Build 3336:
-0.002%

Covered Lines:
6388

Relevant Lines:
6621

💛  - Coveralls

Great catch @tinkertrain — I think they should be consistent. See attached image and here's the corresponding Figma file

I guess the larger question is how we move towards a more consistent set. In the Figma files we use one of 7 different depths, each of which has a matching hover state. See HSDS Depth Guide

Great catch @tinkertrain — I think they should be consistent. See attached image and here's the corresponding Figma file

I guess the larger question is how we move towards a more consistent set. In the Figma files we use one of 7 different depths, each of which has a matching hover state. See HSDS Depth Guide

That looks great, one thing we could do is having the "depth set" as UI components or set of styles inside HSDS, that then we can just use all over HSDS to ensure consistency and make it easier fo everyone, then in figma you can leave the little comments like you do with colours /* depth 300 */.
Let's continue this conversation off here, I'll release this and then have another PR dedicated to Depth


Exercise 1 completed

Exercise 1

Thank you for your PR! @SriHarshaGajavalli
Since we want to keep the spelling and test mistakes for other participants to work on, we wouldn't be merging this PR. Hope the practice was good nevertheless 😄


MGMT-15054: FCP devices (multipath) do not show correct size

https://issues.redhat.com/browse/MGMT-15054
If a disk has defined holders, it is not included in the total storage size calculations.

However, I have noticed that the function createHostInventoryWithDiskHolders does not really create fixtures with the expected master/workerDisk. It overwrites the disks with fixed data defined as disksWithHolders.
I suggest to fix it, perhaps by changing the function createHostInventoryWithDiskHolders (removing the declared diskSpace param, and send a dummy diskSpace value (eg. 0) to createHostInventory.). Or make diskHolders dynamic and use the received diskSpace.

I decided to remove the diskSpace parameter. I don't have the best understanding of how exactly the host inventory data works, I'm just using mock data provided here for the disks with holders.


Allow multiple keys to be required and extracted

 plug PlugRequireHeader, api_key: "x-api-key", magic_header: "magic-header"

Planned to be addressed by #3.

Handled by #3.


[raz] Allow users to list root path in ABFS

The PR is open for review and the unit tests for the changes are added.


Performance of has time series in IS

requires testing for https://github.com/NREL-Sienna/InfrastructureSystems.jl/pull/416


Width in percentage on left column doesn't work as it should

Hi,
When setting the property: width in percentage under Left data source, I expect that the complete column becomes wider and not only the left column on the top row.
Also when i keep the value on 0, I expect that the text in the left column is visible. Now it just becomes invisible.

This is when the percentage is set to 25

This is when the percentage is set to 0

Fixed in version 2.2. New version is pending on the App Store or you can download the .mpk directly here on Github.


[Feature] Support Bytebase as KubeVela addon

Is your feature request related to a problem? Please describe.
Bytebase is an open-source database DevOps tool, it's the GitLab for managing databases throughout the application development lifecycle. It offers a web-based workspace for DBAs and Developers to collaborate and manage the database change safely and efficiently.
We can make Bytebase as KubeVela addon as app developers may need this tool. The web portal is important in this case.
Describe the solution you'd like
The installation procss is clear:  https://www.bytebase.com/docs/get-started/install/deploy-to-kubernetes
It requires a postgres database that we can provision with this addon: https://github.com/kubevela/catalog/tree/master/experimental/addons/postgres-operator
Describe alternatives you've considered
We can also create a posgress database without relying on the postgres-operator.
Additional context

@wonderflow assign this issue to me.


Issue installing mxnet R package with drat

I followed the installation instructions and received the following error
> library(drat)
> drat:::addRepo("dmlc")
> install.packages("mxnet")
Installing package into ‘/home/ssoi/R/x86_64-pc-linux-gnu-library/3.3’
(as ‘lib’ is unspecified)
downloaded 0 bytes

Error in download.file(url, destfile, method, mode = "wb", ...) :
  cannot download all files
In addition: Warning message:
In download.file(url, destfile, method, mode = "wb", ...) :
  URL 'http://dmlc.ml/drat/src/contrib/mxnet_0.7.tar.gz': status was '404 Not Found'
Warning in download.packages(pkgs, destdir = tmpd, available = available,  :
  download of package ‘mxnet’ failed
>

Got the same error today, I had to compile from code. But I had to use a previous version of the repo. It is possible that there is some error in the compilation and that's why the  method with drat is now working

@ssoi You got this error because we don't provide pre-built package for linux.

Sorry I missed that in the installation instructions. Thanks!

I'm getting the same 404, even though I'm running R / R Studio on a mac laptop.


Create a medical specialty branch

Will research and add a list of terms to be added.

can we get some more background on this need? there are already such nomenclatures out there. seems like the sort of hting that would be referenced within a data model rather than included directly in maxo.

Also in light of the recent EFO presentation, maybe its time to generally try to refer to a canonical set of medical specialities (or what they call therapeutic areas)..

This came from another ticket: https://github.com/monarch-initiative/MAxO/issues/154
But the issue was that I wanted to build a few terms using DOSDP patterns using medical specialty under medical examination and medical consultation.
Terms like 'orthopedic consultation', 'dental examination', 'ophtamalogic consultation' and 'eye examination' are all issues.
This started because I wanted to add obstetric terms, like 'fetal examination', so that would have to be in there too (neonatal specialties?)
Looking around, there are a couple of terms in OMIT and a couple in NCIT.  But it is not comprehensive in any way.
Currently, I am trying to gather a comprehensive list of what I think we would need, but it is definitely a bigger undertaking than I had thought. :)

Oh, to be clear, I wasn't saying this had to be in MAXO, I was actually looking for this to be elsewhere, but I am not sure where.  If there isn't an obvious place, then it would be a branch that would not be under 'medical actions' because they aren't medical actions.  But having access to an ontology branch with this info would be helpful.

perhaps having a computable list from https://www.abms.org/ would be ideal. I think this exists somewhere but I can't recollect

Yes, they have a list here: https://www.abms.org/member-boards/specialty-subspecialty-certificates/
I don't think MAxO would need all of them, but a complete list  somewhere. should be helpful.

These list seems ideal. I theory we could also report what type of specialty usually provides a certain MAxO treatment, but that is likely to be burdensome.

Any idea where this should go?

@mellybelly Here is a rather quick list of things I am trying to add/deal with for MAxO terms. Mainly consultation and examination. I found so many I didn't look for other use cases, but I know there are others. I  will add those when I find them.
'X' consult
Examples: orthopedic consult, Consultation w/a gastroenterologist, Referral to an orthopedic surgeon, Referral to orthopedist, Consultation w/a pediatric neurologist, Consultation w/a nutritionist, Consultation w/a developmental specialist, Consultation w/a clinical geneticist and/or genetic counselor, Consultation w/a rehabilitation specialist, Referral to neurologist, Referral to craniofacial team, referral to feeding specialist, Consultation w/metabolic physician / biochemical geneticist & specialist metabolic dietician, Referral to developmental pediatrician, Referral to neurosurgeon, Referral to a specialist in pediatric pain management, Referral to a pediatric neurologist, Referral to a palliative care specialist, consultation w/endocrinologist
'X' exam
Examples: eye exam, ophthalmologic assessment/ Ophthalmologic examination, audiology assessment, Dermatologic evaluation, radiologic examination, Neurologic evaluation, Developmental assessment, Neuropsychiatric evaluation, Clinical evaluation of feeding/Feeding and nutrition evaluation, dental evaluation, Endocrine evaluation, Cardiac evaluation

Probably for MAxO eye exam and ophthalmology consultation (etc) are close enough to be synonyms ?

True, I thought about getting rid of the 'consultation' branch, but they are abundant in GeneReviews.  Exam would also have things like 'fetal exam' and a few other items listed in NCIT: http://www.ontobee.org/ontology/NCIT?iri=http://purl.obolibrary.org/obo/NCIT_C25305
But their group isn't structured, which is why/how this brought me to this question of medical specialties.


Compiling from source

Hi.
I'm trying to compile casa-arrow from source with Spack (with GCC 9.3.0 and Python 3.10 on a RH7 system).
Regarding the "custom Python 3.8 pyarrow manylinux_2_28 wheel" listed in the requirements, is the source code publicly available? When trying to install from the wheel I get compatibility issue (ERROR: pyarrow-12.0.0.dev13242+gdbb4473-cp38-cp38-manylinux_2_28_x86_64.whl is not a supported wheel on this platform.) so I would like to install it from source.
Thank you.

Hi @orliac. Yes the source code is available at https://github.com/apache/arrow
The manylinux-2-28 pyarrow wheel is useful for development environments where the newer C++11 ABI is configured:  -D_GLIBCXX_USE_CXX11_ABI=1.
If you can use the older ABI -D_GLIBCXX_USE_CXX11_ABI=0, it should be  possible to use the manylinux2014 pyarrow 12.0.0 wheels. https://github.com/ratt-ru/casa-arrow/blob/master/docker/py310-wheel-manylinux2014.docker should provide insight on how to build this from scratch.
Also pyarrow 13.0.0 should provide manylinux-2-28 wheels https://github.com/apache/arrow/issues/33804

Hi @sjperkins,
Many thanks for the feedback. I thought the wheel was built from a fork with some in house implementations, hence my request.
Closing the Issue since I could install from source and run the provided example with minor changes with Python 3.10.


Token or Prototype Token unclickable

TypeError: An error occurred while rendering TokenConfig 75. Cannot convert undefined or null to object
[Detected 1 package: system:dnd5e]
at Function.keys ()
at TokenDocument5e._getTrackedAttributesFromSchema (token.mjs:55:82)
at TokenDocument5e.getTrackedAttributes (token.mjs:24:67)
at TokenConfig.getData (foundry.js:70956:53)
at async TokenConfig._render (foundry.js:5108:18)
at async TokenConfig._render (foundry.js:5822:5)

onError
@
foundry.js:747

🎁call_wrapped
@
libWrapper-wrapper.js:507

🎁Hooks.onError#lib-wrapper
@
listeners.js:138

🎁Hooks.onError#0
@
libWrapper-wrapper.js:187

(anonymous)
@
foundry.js:5069

Promise.catch (async)

render
@
foundry.js:5067

render
@
foundry.js:6394

render
@
foundry.js:70940

_onConfigureToken
@
foundry.js:61422

onclick
@
foundry.js:61380

(anonymous)
@
foundry.js:5239

dispatch
@
jquery.min.js:2

y.handle
@
jquery.min.js:2

Duplicate of recently resolved issue https://github.com/foundryvtt/dnd5e/issues/2295


new function imread_reduced()

by this new function we can set libjpeg "scale_denom" parameter and load jpeg images scaled 1/2 - 1/4 - 1/8
other image formats resized after loading

all commits squahed see https://github.com/Itseez/opencv/pull/4162
i am thinking of some other improvements. for example
1.now the function reduces jpeg images 1/2 1/4 1/8 (as main goal of the function ) . other formats can be reduced 1/n.maybe it need normalization for all image formats.
2. adding other parameters maybe a good idea like aimed_with , aimed_height etc.

:+1:

thank you for your help.
i have a question. i am still thinking of some other improvements. i wonder if i can change the name of the function with more inclusive name?

@sturkmen72 I believe you can (we don't make public releases with current name). Feel free to create new PR.

@alalek where can i discuss for finding a good name.
for example some alternatives i thought
"imreadresize" or "imreadResize"  - means function basicly imread+resize
"imreadEx" - means imreadExtra
etc. maybe someone suggest more meaning name

have another question if i don't bother you.

I believe @vpisarev can help you with function name.
Overload is possible but you need to drop default parameters values:
imread( const String& filename, int flags /* IMREAD_COLOR */, int scale_denom /* 1 */)

BTW, More general case is to use "float scale" and make inner checks for 1/2 1/4 (via fabs(scale - 0.5) < FLT_EPSILON)

if overload possible then i think no need to new function. what is your opinion.
may i make it overload

existing applications will look for imread_2Arg so you must not remove it in favour of your imread_3Arg. (see C++ name mangling for details)


Typo in install.md

There are some typos at the install OpenSSL to Windows section.
The easiest way to elevate the Command Prompt is to press and hold down the both the <CTRL> and <SHIFT> key while clicking the menu item in the task menu.
should be:
The easiest way to elevate the Command Prompt is to press and hold down both the <CTRL> and <SHIFT> keys while clicking the menu item in the task menu.

Should be closed.


Revisit platform integration tests

Get them working again
Add Cloud Run support
Ideally run in Kokoro

Closing for now - we may come back to this once the CI work has been completed.


EGL without a display server on Linux

Needed for Stardust, great for many other things! This basically tries to get a display and if that fails it tries DRI from the default card, if that fails the app fails to load.

Removed that all, made it so in XR mode the x window failing won't break
everything, and it all seems to work so that's pushed!


Add pretty name with auto generation

Description
This PR adds a prettyName field on the instance which has the purpose of letting the user specify a custom name to identify the instance.
How Has This Been Tested?

[x] Integration tests
[ ] Staging

/deploy-staging


Add a self update job into the pipeline

The roles are deploying fine, but now the sandbox smoke tests are timing out - I wouldn't have thought anything I did would have affected this so it may be coincidence, but still worth looking into


weird spacing in bio links

Yo my parser deals with reassembling chunks on proper whitespace

it has nothing to do with new parsing, that hasn't been deployed yet. it only happens in the modal.

it seems to be fixed now


"Query requires iterating over all vertices" warning when using g.V().hasId(x)

As discussed in this topic, Titan raises a warning when a g.V().hasId(123) that has a direct impact on the blvp performance:
WARN StandardTitanTx  - Query requires iterating over all vertices [(~id = 123)]. For better performance, use indexes.
Marko suggests that the TitanGraphStepStrategy could handle the transformation of hasId(x) into vertices(x)

The PR 267 introduces the method GraphStep.processHasContainerIds() that will help to fix this.

@mikedias can we then close this issue over here in titan? or is there more for titan to implement?

@spmallette no. The TitanGraphStepStrategy needs to be optimized yet. The PR 267 AFAIK only introduces a helper method to implement the optimization.

https://issues.apache.org/jira/browse/TINKERPOP-1219


add a complex example using multiple regularly used plugins related t…

add a complex example using multiple regularly used plugins related to the following use-cases

build optimization plugins

compile time plugins

webpack-dev-server enhancement plugins

Read and sign the CLA. This needs to be done only once. PRs that haven't signed it won't be accepted.

Make sure your PR complies with the writer's guide.

Read through the PR diff carefully as sometimes this can reveal issues. The work will be reviewed, but this can save some effort.

Remove these instructions from your PR as they are for your eyes only.

@simon04 i have signed the agreement but its not getting reflected here
Its the first time i am contributing to a js.org repo. am i doing something wrong
here is the screenshot for the signed agreement http://prnt.sc/e56rxe

@simon04 thanks for reviewing. I have updated my PR

You committed using an email address not associated with your GitHub user. See the second part of https://github.com/webpack/webpack.js.org/pull/834#issuecomment-277667274

@simon04

fixed the commits user meta to comply with CLA agreement.
CI tests also passed

Can your merge it.


Live Announcements Beta

Live display has become unavailable with Live announcements, certain stations get stuck on 'still announcing service' when announcement finished a minute ago. Also other voices are available - TFW Ruth 175, Merseyrail Julie 777, Michael Comyn IÉ stations (same pack as DITRA), ScotRail stations newer announcement voice, London Overground onboard and stations Emma Hignett. These are publicly available now and I think we'd all love to see them uploaded. Keep up the excellent work, it's my new favourite website

Live display has become unavailable with Live announcements
Should be fixed
certain stations get stuck on 'still announcing service' when announcement finished a minute ago
This can happen if you leave the tab in the background.

It can also happen while it's trying to download files for the next announcement. Sometimes this takes a while due to browser limits and other schenanigans.

Merseyrail Julie 777

Check out issue #32


GOG integration not working anymore

Probably related to #87 and duplicate of #97 (since I take too much time to write this..)
GOG's overlay can't be summoned (shift+tab) since 0.9.
Can't take in-game screenshotsd with GOG's integration (F12).

Tried to rollback to 0.7: overlay still not working
Tried to remove all files: same, no overlay
Tried restart GOG: no overlay
Tried installing 0.10: no overlay
Tried closing Discord: no overlay
Tried another game on GOG: overlay is working

If it helps: First launch after installing 0.9, I got a crash at the seizure warning screen saying my AMD drivers weren't responding.
EDIT:

Adding duplicate issue (#97)
Adding crashreport Cyberpunk2077-20201216-213628-19468-25276.zip

It may be related to GOG Galaxy update earlier today.
In addition to the patch, this update is the only thing that have changed since yesterday.

If there is no overlay even without the mod, it's not the mod.


fix: play icon visibility on game cards ⚒✨

Close #962
Screenshots

BEFORE
AFTER

Your review is appreciated @panwar8279

Please merge this PR @panwar8279


Change Setting Checkboxes Do Not Work

Windows 10 + Chrome 105 + TW 5.2.3

same issue

Seems fixed in latest release


groupBy regression going from 0.6 to 0.7

"aggregations": [
{ "type": "longSum", "name": "foo", "fieldName": "foo" },
{ "type": "longSum", "name": "foo_bar", "fieldName": "foo_bar" }
],
having{"type": "greaterThan", "aggregation": "foo", "value": 0}
The having makes an aggregation with an _ go 0 (i.e. foo_bar has a value w/o having, but is always 0 if having is added).
This used to work in 0.6 and it still works for aggregations without _ (this might be a coincident)

@sixtus I created a test case for the behavior you are seeing in https://github.com/druid-io/druid/pull/1176. The test passes and I am so far unable to reproduce the problem. Please make sure the test case is covering the error you are reporting.
I have a sneaking suspicion the root of the problem you are seeing is related to something else, possibly casing. If you remove the having spec, does foo_bar have a value? Does the case of foo_bar match in your data, ingestion spec, and in your query?

It's all lower case and it has worked reliably for the last 2 years (it's very old code I was totally surprised to break after upgrading).
I have multiple metrics in my query, they all work fine, except the one with the underscore. Removing the having clause makes 0.7 return correct results.
If you are interested I send you a PM with the true query and results.

I am unable to work on this issue atm (we fixed it by using a different query), I am sorry.
Again, if you are interested I send you the true query and response via PM.

I am closing this as unable to reproduce. Please reopen if it is still an issue


Use EncodeUri() if part of the URL path or EncodeUriComponent() if used as a URL parameter

https://github.com/TheNewco/tncjs-gtm-template/blob/def0faa75968441f20578417cee701144a2ecd59/template.tpl#L377C49-L377C111
When reviewing your template we've noticed that it is using parameters to build a url. It's a best practice to use EncodeUri() if part of the URL path or EncodeUriComponent() if used as a URL parameter.

Good point, thank you. Fixed!


Standalone: abc module not has "file" after build

Nuitka version, full Python version, flavor, OS, etc. as output by this
command.

python -m nuitka --version

1.7.2
Commercial: None
Python: 3.10.6 (main, May 29 2023, 11:10:38) [GCC 11.3.0]
Flavor: Debian Python
Executable: /home/chen/my-project/text-generation-python-client/no-dep/bin/python
OS: Linux
Arch: x86_64
Distribution: Ubuntu (based on Debian) 22.04.2
Version C compiler: /usr/bin/gcc (gcc).

How did you install Nuitka and Python

pip install
torch package is pip install torch -t lib after build success
I build sucess and run main.bin,and find error as follow
Then I trace the code and find abc module is frozen and not has __file__ property
/home/chen/my-project/text-generation-python-client/out/main.dist/lib/peft/tuners/lora.py:240: UserWarning: fan_in_fan_out is set to False but the target module is `Conv1D`. Setting fan_in_fan_out to True.
  warnings.warn(
trainable params: 589824 || all params: 102658560 || trainable%: 0.5745492631106456
/home/chen/my-project/text-generation-python-client/out/main.dist/lib/transformers/optimization.py:411: FutureWarning: This implementation of AdamW is deprecated and will be removed in a future version. Use the PyTorch implementation torch.optim.AdamW instead, or set `no_deprecation_warning=True` to disable this warning
  warnings.warn(
Exception in thread Thread-4 (_handle_eio_message):
Traceback (most recent call last):
  File "/home/chen/my-project/text-generation-python-client/out/main.dist/threading.py", line 1016, in _bootstrap_inner
  File "/home/chen/my-project/text-generation-python-client/out/main.dist/threading.py", line 953, in run
  File "/home/chen/my-project/text-generation-python-client/out/main.dist/lib/socketio/client.py", line 705, in _handle_eio_message
    self._handle_event(pkt.namespace, pkt.id, pkt.data)
  File "/home/chen/my-project/text-generation-python-client/out/main.dist/lib/socketio/client.py", line 581, in _handle_event
    r = self._trigger_event(data[0], namespace, *data[1:])
  File "/home/chen/my-project/text-generation-python-client/out/main.dist/lib/socketio/client.py", line 629, in _trigger_event
    return self.handlers[namespace][event](*args)
  File "/home/chen/my-project/text-generation-python-client/out/main.dist/main.py", line 84, in train
  File "/home/chen/my-project/text-generation-python-client/out/main.dist/lora/train_lora.py", line 18, in <lambda>
  File "/home/chen/my-project/text-generation-python-client/out/main.dist/lora/train.py", line 71, in train
  File "/home/chen/my-project/text-generation-python-client/out/main.dist/lib/transformers/trainer.py", line 1645, in train
    return inner_training_loop(
  File "/home/chen/my-project/text-generation-python-client/out/main.dist/lib/accelerate/utils/memory.py", line 132, in decorator
    return function(batch_size, *args, **kwargs)
  File "/home/chen/my-project/text-generation-python-client/out/main.dist/lib/transformers/trainer.py", line 1728, in _inner_training_loop
    self.create_optimizer_and_scheduler(num_training_steps=max_steps)
  File "/home/chen/my-project/text-generation-python-client/out/main.dist/lib/transformers/trainer.py", line 1067, in create_optimizer_and_scheduler
    self.create_optimizer()
  File "/home/chen/my-project/text-generation-python-client/out/main.dist/lib/transformers/trainer.py", line 1111, in create_optimizer
    self.optimizer = optimizer_cls(optimizer_grouped_parameters, **optimizer_kwargs)
  File "/home/chen/my-project/text-generation-python-client/out/main.dist/lib/transformers/optimization.py", line 427, in __init__
    super().__init__(params, defaults)
  File "/home/chen/my-project/text-generation-python-client/out/main.dist/lib/torch/optim/optimizer.py", line 218, in __init__
    self.add_param_group(param_group)
  File "/home/chen/my-project/text-generation-python-client/out/main.dist/lib/torch/_compile.py", line 22, in inner
    import torch._dynamo
  File "/home/chen/my-project/text-generation-python-client/out/main.dist/lib/torch/_dynamo/__init__.py", line 1, in <module>
    from . import allowed_functions, convert_frame, eval_frame, resume_execution
  File "/home/chen/my-project/text-generation-python-client/out/main.dist/lib/torch/_dynamo/convert_frame.py", line 31, in <module>
    from .eval_frame import always_optimize_code_objects, skip_code, TorchPatcher
  File "/home/chen/my-project/text-generation-python-client/out/main.dist/lib/torch/_dynamo/eval_frame.py", line 51, in <module>
    from . import config, convert_frame, external_utils, skipfiles, utils
  File "/home/chen/my-project/text-generation-python-client/out/main.dist/lib/torch/_dynamo/skipfiles.py", line 72, in <module>
    ] + [
  File "/home/chen/my-project/text-generation-python-client/out/main.dist/lib/torch/_dynamo/skipfiles.py", line 74, in <listcomp>
    _module_dir(m)
  File "/home/chen/my-project/text-generation-python-client/out/main.dist/lib/torch/_dynamo/skipfiles.py", line 62, in _module_dir
    return _strip_init_py(m.__file__)
AttributeError: module 'abc' has no attribute '__file__'. Did you mean: '__name__'?

With no reproducer, I will have to consider this as invalid unfortunately.

With no reproducer, I will have to consider this as invalid unfortunately.

the demo like this https://www.philschmid.de/fine-tune-flan-t5-peft
I use Huggingface Trainer
--nofollow-import-to torch,transformers,peft,datasets
after build I pip install in lib folder (with  sys.path.append(lib_dir))
When I didn't use Trainer before, it worked normally
I trace the source code skipfiles.py
#....other code
def _module_dir(m: types.ModuleType):
    return _strip_init_py(m.__file__)# if input `abc` throw error
SKIP_DIRS = [
    # torch.*
    _module_dir(torch),
    # torchdynamo.*
    os.path.dirname(__file__) + "/",
    "<frozen importlib",
    "<__array_function__ internals>",
] + [
    # skip some standard libs
    _module_dir(m)
    for m in (
        abc, #--------------> no __file__
        collections,
        contextlib,
        copy,
        copyreg,
        dataclasses,
        enum,
        functools,
        importlib,
        inspect,
        linecache,
        logging,
        multiprocessing,
        operator,
        os,
        posixpath,
        random,
        re,
        selectors,
        signal,
        tempfile,
        threading,
        tokenize,
        traceback,
        types,
        typing,
        unittest,
        weakref,
        _collections_abc,
        _weakrefset,
    )
]
#...other code

it seems all packages that are technical, and abc is on recent enough Python3, but also encodings which is everywhere, at some point started having only __path__ and no __file__ and the code that goes over the technical imports to correct the __file__ values for anything not built-in checked for presence of __file__ before setting it. In Python2 it wasn't like that, in 3.8 it was, I do not care much whne it really started, I just added the check on __path__ presence as well.

Thanks for your report, this is fixed on the factory branch, which is a development version under rapid development. You can try it out by going here: https://nuitka.net/doc/factory.html
Feedback if this is working is very welcome, just please do not share plans of doing it, but rather confirmations or denials of it working.

Since it might be an invasive change, potentially breaking, I consider this should be done only for the new release 1.8 and not as a hotfix of 1.7 which this could also be.

This is part of the current pre-release and will be part of 1.8

if input `abc` throw error

I use development versiong1.8rc.3.But the error still exists,should I add any options?

Uhm, that's correct. No idea why, but I had analysed, that encodings would have to have the same issue, and it does. So for this code:
import encodings
print(encodings.__file__)
import abc
print(abc.__file__)

The first one works, and the second does not, which is very strange of course. Maybe the loading of packages from bytecode that is not technical, does not set it too, and that's a separate bug.

So, the time module is built-in and has no __file__ and that's how we recognize those in the respective code. The abc module however needs it. We might have to check the __loader__ and do corrections if it was the FrozenImporter which apparently doesn't do it, or maybe better use sys.builtin_module_names to identify them.

This fix is on factory again, I wasn't aware that for non-packages __file__ is used as well. Obviously going to be used a lot less, since they do not have a folder to care about, but compatibility rules. The sys.builtin_module_names makes it easily work on all Python versions.

This is on develop now, and will be in 1.8 release too.

Part of the 1.8 release I just made.


' Output tensors to a Model must be Keras tensors ' when i use functional api to build QA model

I want to build the network shown in the picture

    question_input = Input(shape=(maxlen,),dtype='int32')
    answer_input = Input(shape=(maxlen,),dtype='int32')
    good_answer_input = Input(shape=(maxlen,),dtype='int32')
    bad_answer_input = Input(shape=(maxlen,),dtype='int32')

    embedding_layers=Embedding(dicSize,length,input_length=maxlen,weights=[embedding])
    question_embeds=embedding_layers(question_input)
    answer_embeds=embedding_layers(answer_input)

    maxpool = Lambda(lambda x: K.max(x, axis=1), output_shape=lambda x: (x[0], x[2]))
    question_maxpool = maxpool(question_embeds)
    answer_maxpool = maxpool(answer_embeds)

    dot = lambda a, b: K.batch_dot(a, b, axes=1)

    similarity = lambda x: dot(x[0], x[1]) / K.sqrt(dot(x[0], x[0]) * dot(x[1], x[1]))

    similarity_value=merge([question_maxpool, answer_maxpool], mode=similarity,output_shape=lambda x: x[0])

    qa_model=Model(input=[question_input, answer_input], output=similarity_value)

    good_output = qa_model([question_input, good_answers])
    bad_output = qa_model([question_input, bad_answers])

    M=0.03
    max_margin_loss = merge([good_output, bad_output], mode=lambda x:K.maximum(1e-6, M - x[0] + x[1]), output_shape=lambda x: x[0])

    training_model = Model(input=[question_input, good_answer_input, bad_answer_input], output=max_margin_loss)

    training_model.compile(loss=lambda y_true, y_pred: y_pred, optimizer='adam')
    print(training_model.layers)

`
Traceback (most recent call last):
File "/Users/insuranceQA-master/rnn.py", line 233, in
build_model(questions,good_answers,bad_answers)
File "/Users/insuranceQA-master/rnn.py", line 172, in build_model
training_model = Model(input=[question_input, good_answer_input, bad_answer_input], output=max_margin_loss)
File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/keras/engine/topology.py", line 1571, in init
'Keras tensors. Found: ' + str(x))
Exception: Output tensors to a Model must be Keras tensors. Found: Elemwise{true_div,no_inplace}.0
`
I think problem may be happened from qa_model to training_model

Just skimming your code a little bit (it's a bit messy and please add code highlighting) the first thing that looks a little weird is how you get the output_shape for your lambda merge.

Also, please consider clarifying the issue title and make it more precise to your problem.

@ssdf93 Hey! Did you find any solution to your problem?

@CNiallDemensha  did you find any solution to debug the error?


Make x-axis ticks in (now ordinal) rank plot look prettier

Ideas:

[x] use labelAngle of 0
[ ] display ticks, but only for the currently displayed labels (for some reason I can't seem to get a label for x = 1 and x = [highest-currently-ranked feature]). Using the values axis parameter might be the best option, but it'll require some planning.

actually on second thought using a label angle of 45 or something (whatever matches the sample plot behavior with a categorical x axis) will likely look better, since it can get hard to read now