create_tarball_command needs change

For create_tarball_command there is the following info in the docs:
A command which generates upstream tarball in the root of the upstream directory
(defaults to git archive -o "{package_name}-{version}.tar.gz"
--prefix "{package_name}-{version}/" HEAD)

After the past changes in the code, the tarball is by default created in the specfile dir:
git archive -o "{specfile_dir}/{package_name}-{version}.tar.gz" --prefix "{package_name}-{version}/" HEAD and _sourcedir in the rpmbuild command is set to the specfile dir . Therefore when users use custom create_tarball_command and have spec file in the subdirectory, the SRPM creation fails.
Do we want to change the docs so that the command should generate upstream tarball in the directory with the spec file or do we want to create a symlink to the archive from the specfile directory or do you have some other suggestions?

Oh no, tarballs, again.
First, we shouldn't break backward compatibility - did we do that?

Therefore when users use custom create_tarball_command and have spec file in the subdirectory, the SRPM creation fails.

I'd definitely update the docs as you suggest.

First, we shouldn't break backward compatibility - did we do that?

Probably yes. (We place the tarball into a different directory than before.)

First, we shouldn't break backward compatibility - did we do that?

I found it here https://sentry.io/share/issue/cc6d9144f3064bc3a70839191d1ff2c9/

can you please also try to fix their problem?

can you please also try to fix their problem?

But what is the fix?

Revert to the old behaviour? (That isn't probably what we want.)
Do we want to use a symlink as we do for actions? (Than we need to find the created archive, but we cannot use any info from the output.)

Any update here?
Did we indeed break some projects with the change? Which projects? Can we get a list?

Yes, I will try to fix it. I have found just this one yet.

OK, so this happened just in Dominika's fork [https://github.com/dhodovsk/convert2rhel/pull/1] so we did not break any project for real.

nice! can we close then since our docs is now up to date?

Yes


[RFC] README.md template

a nice-looking standard template for README.mds. Has

[ ] nice centered logo
[ ] centered badges
[x] eg "about mongodb"
[x] "from chef brigade"
[ ] defined structure
[ ] compatible with knife-cookbook-doc https://github.com/realityforge/knife-cookbook-doc
[ ] bake the logo and front-matter into the overview.md file.

without stretching food metaphors beyond the breaking point

This should probably go in https://github.com/chef-brigade/cookbook-skeleton

centered?

I swear I've seen centered badges. I may be insane.

Here is an example of centered badges:
https://github.com/badges/shields/blob/master/README.md

The code:

I think we should stick to markdown only and not mix in HTML, at least until the supermarket can render it properly (first thing that comes to mind is how HTML tables are rendered in supermarket, we'd want to avoid that coming from a template).

I'm going to close this one down. Until we know we can make some good progress on it


reduce lag in opt tab toggles

Describe your changes
Partially reverts #1819, and update methodology:

Use React.memo to memoize components against needless updates,
Add a new hook, useConstObj to allow prop checking for updated complex obj data.

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

[x] I have commented my code in hard-to understand areas.
[x] I have made corresponding changes to README or wiki.
[x] For front-end changes, I have updated the corresponding English translations.
[x] I have run yarn run mini-ci locally to validate format and lint.
[x] If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Builds are rerendering when toggling main stats, so this is incomplete

I am not sure how you are determining that, I couldn't see any rerendering of the build list/children when mains are toggled, in the profiler or even directly via console.log in the components.

Addressed those additional child rerenders in BuildDisplayItem, by making optimizationTarget const.

My concern is deep equality is slower than shallow equality and this cost is paid on every render
This is a valid concern, this will only be used in cases like this, where the user can perceive the lag, it won't be used in general UI until it can prove to be an general improvement.


Throwing captcha in response?

I'm getting a captcha response after using the sheet package. How do you bypass?
I'm using a service account.

I've just a published a new version of this module which is a complete rewrite using Google's V4 Sheets API (v3 is being deprecated on March 3, 2020).
Docs available here - https://theoephraim.github.io/node-google-spreadsheet
I do believe this issue should be fixed in the new version.
Please test it out and if you find that there is still a problem, reopen the issue.
Thanks! 😄


[SRTP/DTLS] consider totally switch RustCrypto crates to Ring/webpki crates

Why do you want to switch? From what I've heard ring is harder to maintain and use...

I don’t have too much preference, just want to simplify the dependency on one crypto crate.


[Question][Enhancement] Support output to multiple indexes

What would you like to be added:
Hi team,
I'm looking to implement Splunk helm which can output to multiple indexes in one helm chart.
Why is this needed:
Because our case is each of project will stay in a namespace, and we want only one Splunk helm to scrape the logs from each namespace and then output to the correct index.
For instance:
    Splunk logs (one helm chart):
        namespace A (project A) => output to index A
        namespace B (project B) => output to index B
        ......

Therefore we can avoid having multiple fluentd installations (not installing many times Splunk helm).
Or if you don't have time, that would be nice if you could give me some solution to workaround. Thank you

See README.md section Managing SCK Log Ingestion by Using Annotations

How Splunk know with logs of the pod should be sent to the correct index? since there are could be many indexes.

SCK decides in which index logs should be sent. If SCK finds an index in pod annotations, it will be sent it to the given index otherwise it will be sent to the default index.

I guess because if I set annotation for namespace then all the pods inside that namespace will be sent to the index that I set in annotation, isn't it?

Yes, you are correct. If you are interested in how it is done, here is the code where it happens:
https://github.com/splunk/splunk-connect-for-kubernetes/blob/928a45d36819eb9fa415272e5582a0ef89ec8ef6/helm-chart/splunk-connect-for-kubernetes/charts/splunk-kubernetes-logging/templates/configMap.yaml#L276-L277

@harshit-splunk many thanks for your support, now I can use annotation with multiple indexes <3

I am trying to achieve similar objective and was able to get it done using annotation . But issue is we have an index called openshift where we collect all the namespaces and I was hoping once I set annotation for namespace then all the pods inside that namespace will be sent to the index that I set in annotation and I will not see same namespace in index called "openshift". This is causing redundant namespaces in index. Any way I can filter out /exclude namespaces in index ? Thanks


Update readme

The way the script is used has been changed and the examples in the readme needs to be updated.

Include information about how to enable atrun for Mac users. See man atrun.


Frends.SFTP.UploadFiles needs attributes for OperationTimeout and KeepAliveInterval

These attributes needs to be added to the SftpClient so the connection is not closed before timeout

This was fixed in PR #82


[staging] evcxr: fix build with rust 1.70

Description of changes
https://github.com/NixOS/nixpkgs/pull/235438#issuecomment-1577334364

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 236140 run on x86_64-linux 1

1 package built:

evcxr


Regenerating SPI layer

Converting Error Reporting and Monitoring to use resource name types
Removing formatX/parseX methods from pubsub, converting usage of the
same to resource name types
New methods in Logging and PubSub

Coverage increased (+0.03%) to 83.546% when pulling 9ab33c3dbcf02c6feaa53ef2fddf3777359d2b7f on garrettjonesgoogle:master into 15c9e238316dcdcd55b5ae2b86ffa2f260ea2334 on GoogleCloudPlatform:master.

LGTM


[5.0][Proposal] AJAX Create & Update forms

Save/Update forms submit AJAX, so there's only one validation (PHP, in FormRequest), but the page does not refresh at all.

I thought about this once.
But then didn’t like the idea of having another dependency to work with if I need to make changes, displaying error messages is a pain, reinitalising fields with js, creating custom components will have to work with the js. Debugging errors becomes harder as hidden in network tabs etc, handling session timeouts and expired csrf tokens etc. Is big job to do wel!

Ugh... You might be right @OwenMelbz - might be better to "keep it simple"...

I don't know, but this is my understanding of your concerns:

error messages are logged to laravel.log by default while in dev, it's just a matter of where people are used to see their error, in the browser or in a log file?
reinitializing fields (if needed in any circumstance) are pretty easy with initializeFieldsWithJavascript ($form)
the components should still be plain html/js (when needed), as long as you are providing a field in a form.
session timeout happens with or without Ajax forms, but currently I think there are multiple ways of dealing with that problem.

Maybe I am missing the point here, but anyway at first I though this is a good idea. I think user experience will be greatly improved, also resource usage etc. I don't expect this to be a straight foward change, but I see it as an improvement.

I agree the end user experience could be better, but I believe one of the fundamental features of backpack is that it is an easy development tool, which newcomers can adopt.
When I said error messages, I meant general debugging eg if there’s a stack trace displaying on the webpage people won’t see it and maybe confuse less experienced.
Custom components - this is assuming that people are making the components “compatible” for example we used to create mostly custom components in Vue. These components would take properties from the blade files, and would take validation errors from the $errors variable in blade. By moving the form to JS it means that those components will need to adhere to your specific way of doing things. Eg if Ajax errors come back, you’ll need your custom JS to then handle from JavaScript rather than blade. Which again just makes it harder for new comers.
Csrf and session timeouts can happen yeah, but it again just goes back to the it’s harder for newcomers. They will then need to learn how your JavaScript layer works as well as the laravel layer, eg do you offer a “login prompt” if it expires on JS? If so, what about users that do not use passwords to login, and use socialite, you need to make the user flow work with both of these.
So in summary, yes it would be nice for the end user (maybe? Not sure what qualifies it as being  nicer? What benefit does the user actually get?)
But this would come at the price of added complexity, which could increase entry hurdles for new Devs.
So those would just be some considerations :)

I mirror @OwenMelbz thoughts. Right now, the way backpack is set up, it is easy just fall back on the "Laravel way" for more complex scenarios and still keep a consistent overall UX. I feel like if everything is moved to AJAX, that disrupts the workflow for more complex scenarios because you will have to do those "the backpack way" to keep a consistent UX. Which to me just means more code that I need to customize (like Owen mentioned, I would have to re-engineer all of the ajax functionality on my own forms as well) and more docs to read through (and write and maintain if I contribute features). I like using backpack because it is fast to get the basics set up and gets out of my way when I need additional complexity.


[WeldxFile] fix show header in non interactive sessions

Changes
In non interactive sessions the output was not printed, but simply returned. This made it harder to write code running in different environments. Now WeldxFile.show_asdf_header() prints.
Checks

[x] updated CHANGELOG.md
[x] updated tests
[ ] updated doc/
[ ] update example/tutorial notebooks

Hello @marscher! Thanks for opening this PR.

In the file weldx/tests/asdf_tests/test_weldx_file.py:

Line 6:1: F401 '_curses.use_env' imported but unused

Do see the Hitchhiker's guide to code style

what do you think about using asdf.info for console outputs? @marscher
https://asdf.readthedocs.io/en/al-503-document-2.8-features/asdf/features.html#rendering-asdf-trees

what do you think about using asdf.info for console outputs? @marscher
https://asdf.readthedocs.io/en/al-503-document-2.8-features/asdf/features.html#rendering-asdf-trees

Yes, that produces pretty output. I will stick to that and remove the doctest or think of another example. Thanks for your feedback!

what do you think about using asdf.info for console outputs? @marscher
https://asdf.readthedocs.io/en/al-503-document-2.8-features/asdf/features.html#rendering-asdf-trees

Yes, that produces pretty output. I will stick to that and remove the doctest or think of another example. Thanks for your feedback!

agreed, for a simple console output that is pretty nice
should be simple to get the full yaml style output simply using print() when desired


vue-cli · tunneling socket could not be established, cause=socket hang up

when i used  vue init webpack  demo
it reported this error : "   vue-cli · tunneling socket could not be established, cause=socket hang up"

It looks like an issue with npm caused by http proxies. Do you use a http proxy?
See npm/npm#2472

Closing this for now. Please re-open if you feel this is an issue with vue-cli.

im having the same problem .. and yes im using an http proxy except .. npm is working ...

For me, I had to make sure the HTTPS_PROXY variable was set. I did it in ~/.zshrc but you could declare it in ~/.bashrc and then source it, or export it system-wide as well and then open a new terminal window.

I am still having this problem. I'm using
windows7,
<EMAIL_ADDRESS><EMAIL_ADDRESS>and
<EMAIL_ADDRESS>I am behind a corporate proxy and I am able to use npm and git through the proxy. My system environment variables are set as follows
HTTP_PROXY = "http://{IP address}:{port}/"
HTTPS_PROXY = "https://{IP address}:{port}/"
The proxy IP and port number in my system environment match the proxy settings I have in my npm config which I verify from the command line with npm config -g list and reading both proxy="http://{IP Address}:{Port}/ and https-proxy="https://{IP Address}:{Port}/". And yet when I command
vue init webpack vue-xperiment
I receive the error
vue-cli · Failed to download repo vuejs-templates/simple: tunneling socket could not be established, cause=socket hang up
How can I check directly from the command line which proxy settings the vue-cli is trying to use? Because either it isn't reading from the system environment vars, or else something else is blocking the connection.

@grugknuckle  use proxychains  resolve this problem

Almost the same error as above.
Docker:
Version 17.09.0-ce-mac35 (19611)
Channel: stable
a98b7c1b7c
Docker proxies:
Use system proxy
Docker Image:
https://hub.docker.com/r/ebiven/vue-cli/
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>npm install works well.  Target directory exists. Continue? Yes
   vue-cli · Failed to download repo vuejs-templates/webpack: tunneling socket could not be established, cause=connect EINVAL <IP_ADDRESS>:80 - Local (<IP_ADDRESS>:0)

@tonywangcn Did you fixed the problem? I meat the same problem.

@grugknuckle  Did you manage to find out what was causing the issue? Same is happening for me.

@blueprintChris It was awhile ago. But I handled it with a hack. You won't like it.
The problem was the corporate proxy where I work. At the time, the IT administrator was changing things around and I couldn't be certain of the state of our internet access and what not. So, I went home - where I had internet access and no proxy - performed the cli command
vue init webpack vue-xperiment
to get an initial project. Then I committed the project to a remote git repository and drove back to work. I was able to then clone the repo to my local (at work) system. I have no idea why the git command line would tunnel through the proxy when the vue cli wouldn't.
But before you do that, try the following -

In your internet options, disable the proxy (if you can) and try the vue cli command that way.
if that doesn't work, try setting your environment variables with lower case property names. For example, use http_proxy instead of HTTP_PROXY. This worked for me on another proxy issue I had. (maybe with npm?)

@lifeMiik solved by remove http_proxy, https_proxy ...... in configuration of vuejs container (kitematic).

I have been faced with this problem for some time but now i found this other post where it was talking of cloning the templates e.g
git clone https://github.com/nativescript-vue/vue-cli-template.git  C:\Users\Your name.vue-templates\nativescript-vue-vue-cli-template
here wanted to use nativescript-templelate if you want to used webpack template replace the nativescript with webpack
And when initialize an application append '--offline' so this will use the local template which you have cloned......Hope this will help someone.

I solve the problem in centos 7(behind proxy):

vue-cli's proxy base on your system'config, not npm etc. So make sure your system config "HTTPS_PROXY"(UPPER case) is correct.
"<IP_ADDRESS>" can work in system, but not work in vue-cli. So add "http://" prefix.


fix unbound knapsack problem with items more than 1(default value)

fix bug #63

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #73   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          89     89
  Lines        1927   1930    +3
  Branches      341    342    +1
=====================================
+ Hits         1927   1930    +3

Impacted Files
Coverage Δ

src/algorithms/sets/knapsack-problem/Knapsack.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d154015...fd1965e. Read the comment docs.

Thank you for the fix @shSina!


Added Solution to Array Left Rotation using Python

Closing Issue/Referencing Issue
issue reference (#)
Changes Made In Pull Request
Added Solution
*
*

I have made my first pull request.Thank you


Json parser error.

Hi Camunda Team,
I am getting Json parser error when using TaskSearch class as a post request body. The problem is with TaskState variable. Below is my response body for TaskSearch
{
"group": "GROUP",
"pagination": {
"pageSize": 10
        },
        "assignee": "firstname.lastname",
        "assigned":true,
        "state": "COMPLETED",
        "withVariables": true

}
Getting below error
JSON parse error: Input mismatch reading Enum io.camunda.tasklist.dto.TaskState: properties-based @JsonCreator ([method io.camunda.tasklist.dto.TaskState#fromJson(java.lang.String)]) expects JSON Object (JsonToken.START_OBJECT), got JsonToken.VALUE_STRING; nested exception is com.fasterxml.jackson.databind.exc.MismatchedInputException: Input mismatch reading Enum io.camunda.tasklist.dto.TaskState: properties-based @JsonCreator ([method io.camunda.tasklist.dto.TaskState#fromJson(java.lang.String)]) expects JSON Object (JsonToken.START_OBJECT), got JsonToken.VALUE_STRING\n at [Source: (org.springframework.util.StreamUtils$NonClosingInputStream); line: 9, column: 23] (through reference chain: io.camunda.tasklist.dto.TaskSearch["state"])

I found that in Jackson 2.13 version we need to use @JsonCreator(mode = JsonCreator.Mode.DELEGATING). Can you please make this change in the TaskState Enum class. Thank you

Hi, I'll look into it !

Hi,
I will look into it. But I would recommand not using that taskState in your TaskSearch object and rather use something like this in your endpoint : TaskState.fromJson(taskSearch.getState())

Below is the JSON Input I am passing to my endpoint
{
"group": "GROUP",
"pagination": {
"pageSize": 10
    },
    "assignee": "firstname.lastname",
    "assigned":true,
    "state": "COMPLETED",
    "withVariables": true

}


Allow multiple directives per test

This test with two directives will not work as it only recognizes one of them.
playlist(id: "aihSOj7Qs0yzd6Kfc4x7Bg") @sla(maxResponseTime: "600ms") @wait(waitTime: "1s")

This issue was fixed in v1.20


DBAAS-999 Full Provisioning with CockroachDB Provider - data model changes and v1beta1 support

This PR replaces https://github.com/RHEcosystemAppEng/dbaas-operator/pull/305 which had rebasing issues.
This PR includes the data model changes for full provisioning of CRDB and RDS clusters in PR (https://github.com/RHEcosystemAppEng/dbaas-operator/pull/294) and adoption of v1beta1 APIs with the following additional changes:
Add a flag GroupVersion to DBaaSProviderSpec to indicate the DBaaS API version (v1alpha1 or v1beta1) the provider supports.
Change DBaaS Inventory, Instance and Connection reconcilers so that the corresponding version (v1alpha1 or v1beta1) of provider custom resources are created.
Unit test cases updated.
Description

Verification Steps

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist (Definition of Done)

[ ] All acceptance criteria specified in JIRA or in issue number have been completed
[ ] Unit tests added that prove the fix is effective or the feature works
[ ] Documentation added for the feature
[ ] all relevant tests are passing
[ ] Code Review completed
[ ] Verified independently by reviewer

@jianrongzhang89 I think you need rebase on main branch

@jianrongzhang89 I think you need rebase on main branch

I ran into rebasing issues, so I created another PR to replace this PR:
https://github.com/RHEcosystemAppEng/dbaas-operator/pull/319.
This PR is closed.


Pt 159364208 maps and oracles contracts

Leave the oracle contract for the time being to get this one out.

APIs are changing in master, will need rebasing. Marking as WIP.

After the release I will rebase this.

Keeping labelled as WIP as needing rebase, and assigning to @rvirding

I see two approvals. CI passed.


chore(deps): update dependency image-webpack-loader to v7

This PR contains the following updates:

Package
Type
Update
Change

image-webpack-loader
devDependencies
major
6.0.0 -> 7.0.1

Release Notes

tcoopman/image-webpack-loader
v7.0.1
Compare Source
v7.0.0
Compare Source

require node 10
upgrade imagemin-pngquant to 9.0.1
upgrade imagemin-webp to 6.0.0
upgrade imagemin-mozjpeg to 9.0.0
bump some packages for security fixes

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

Available now for Enterprise: Renovate Pro with real-time webhook handling and priority job queue.

:tada: This PR is included in version 5.4.6 :tada:
The release is available on:

v5.4.6
GitHub release

Your semantic-release bot :package::rocket:


Persistent Syncer connection failures not exposed for readiness reporting

If the KDD Syncer's watch ends with a persistent network error then it just keeps retrying (with warning logs) but it doesn't tell its client that it's having trouble.  Ideally, consistent failures would be exposed in some way, so that we can feed them into the healthcheck and report Felix/Typha as not ready.
Possible Solution

Could have the Syncer optionally register with the healthcheck
Could have the Syncer spot consistent failures and either resync or flag it using the status API.

Steps to Reproduce (for bugs)

Let syncer come into sync
kill the API server
Syncer logs warnings but keeps retrying

Context
This was desired behaviour for the Felix/Typha readiness feature
TODO

[ ] resolve in libcalico-go
[ ] add k8sfv tests

@fasaxc does this affect KDD and etcd or just KDD?
Could this just be triggered by the Syncer indicating "WaitForDatastore"?

Yeah, that sounds like a good option.

Went to have a look a reproducing this today and saw something perhaps interesting (or maybe I'm just tired?)
I noticed that following the repro steps of killing the apiserver _did _ result in Felix going to not-ready in KDD mode. Looking closer though, it only seems to do so after receiving an update over the syncer that says the IPIP tunnel address has been deleted, triggering Felix to restart.
2019-03-08 03:10:11.737 [INFO][42] resource.go 260: Target config /etc/calico/confd/config/bird_ipam.cfg has been updated
2019-03-08 03:10:11.730 [INFO][3095] watchercache.go 242: Failed to create watcher ListRoot="/calico/resources/v3/projectcalico.org/nodes" error=Get https://<IP_ADDRESS>:443/api/v1/nodes?resourceVersion=5344&watch=true: dial tcp <IP_ADDRESS>:443: connect: connection refused performFullResync=false
2019-03-08 03:10:11.730 [INFO][3095] watchercache.go 242: Failed to create watcher ListRoot="/calico/resources/v3/projectcalico.org/networkpolicies" error=Get https://<IP_ADDRESS>:443/apis/networking.k8s.io/v1/networkpolicies?resourceVersion=4985&watch=true: dial tcp <IP_ADDRESS>:443: connect: connection refused performFullResync=false
2019-03-08 03:10:11.731 [INFO][3095] watchercache.go 242: Failed to create watcher ListRoot="/calico/resources/v3/projectcalico.org/clusterinformations" error=Get https://<IP_ADDRESS>:443/apis/crd.projectcalico.org/v1/clusterinformations?resourceVersion=4985&watch=true: dial tcp <IP_ADDRESS>:443: connect: connection refused performFullResync=false
2019-03-08 03:10:11.732 [INFO][3095] watchercache.go 242: Failed to create watcher ListRoot="/calico/resources/v3/projectcalico.org/globalnetworksets" error=Get https://<IP_ADDRESS>:443/apis/crd.projectcalico.org/v1/globalnetworksets?resourceVersion=4985&watch=true: dial tcp <IP_ADDRESS>:443: connect: connection refused performFullResync=false
2019-03-08 03:10:11.733 [INFO][3095] watchercache.go 242: Failed to create watcher ListRoot="/calico/resources/v3/projectcalico.org/globalnetworkpolicies" error=Get https://<IP_ADDRESS>:443/apis/crd.projectcalico.org/v1/globalnetworkpolicies?resourceVersion=4985&watch=true: dial tcp <IP_ADDRESS>:443: connect: connection refused performFullResync=false
2019-03-08 03:10:11.733 [INFO][3095] watchercache.go 242: Failed to create watcher ListRoot="/calico/resources/v3/projectcalico.org/felixconfigurations" error=Get https://<IP_ADDRESS>:443/apis/crd.projectcalico.org/v1/felixconfigurations?resourceVersion=4985&watch=true: dial tcp <IP_ADDRESS>:443: connect: connection refused performFullResync=false
2019-03-08 03:10:11.733 [INFO][3095] customresource.go 282: Error listing resources error=Get https://<IP_ADDRESS>:443/apis/crd.projectcalico.org/v1/hostendpoints: dial tcp <IP_ADDRESS>:443: connect: connection refused
2019-03-08 03:10:11.733 [INFO][3095] watchercache.go 188: Failed to perform list of current data during resync ListRoot="/calico/resources/v3/projectcalico.org/hostendpoints" error=Get https://<IP_ADDRESS>:443/apis/crd.projectcalico.org/v1/hostendpoints: dial tcp <IP_ADDRESS>:443: connect: connection refused
2019-03-08 03:10:11.734 [INFO][3095] config_batcher.go 61: Host config update for this host: {{HostConfig(node=casey-crc-kadm-ms,name=IpInIpTunnelAddr) <nil>  0s} 3}
2019-03-08 03:10:11.734 [INFO][3095] config_batcher.go 112: Sending config update global: map[LogSeverityScreen:Info IpInIpEnabled:true ReportingIntervalSecs:0 ClusterGUID:69c74524a0264bfd8dceeb9a5ee668e2 ClusterType:k8s,bgp,kdd CalicoVersion:v3.5.2], host: map[].
2019-03-08 03:10:11.734 [INFO][3095] event_sequencer.go 210: Possible config update. global=map[string]string{"CalicoVersion":"v3.5.2", "LogSeverityScreen":"Info", "IpInIpEnabled":"true", "ReportingIntervalSecs":"0", "ClusterGUID":"69c74524a0264bfd8dceeb9a5ee668e2", "ClusterType":"k8s,bgp,kdd"} host=map[string]string{}
2019-03-08 03:10:11.734 [INFO][3095] config_params.go 220: Merging in config from datastore (global): map[CalicoVersion:v3.5.2 LogSeverityScreen:Info IpInIpEnabled:true ReportingIntervalSecs:0 ClusterGUID:69c74524a0264bfd8dceeb9a5ee668e2 ClusterType:k8s,bgp,kdd]

I'm a bit confused where this is coming from - based on the logs it's sorta out of the blue. I will retry with debug and see if anything looks more clear.

Ah! Figured it out. With debugging on I spotted that the watchersyncer was sending a bunch of deleted through for the node objects, seemingly it thought that the nodes had disappeared!
Tracing it back, turns out we weren't returning an error on a failed List() call for nodes only...I think this will do the trick: https://github.com/projectcalico/libcalico-go/pull/1057
I'll try with that, expecting that persistent syncer errors will no longer result in Felix reporting unready...

OK, can confirm this is still an issue!


Is it possible to send a stream to .addfile without knowing content-length?

I am wondering if there is, or could ever be, a way to stream data to .addfile without sending options.headers['content-length'].  For example, if the file being sent to cloudfiles is not fully written (yet) when .addfile is called.
thanks

Currently it is not supported, but support could be added by implementing : http://docs.rackspace.com/files/api/v1/cf-devguide/content/Chunked_Transfer_Encoding-d1e2092.html

Hello Bradley,
Thanks for the link.  That would be so sweet in this module.  I will definitely be following this repo to see if/when it gets implemented.

Fixed : 130196b2e1f936171833149a800081ef888ce9a1

Oh my goodness! You already did it.


Modify the timing at which mbed_main() is called in IAR compiler.

Hi
Renesas modified the timing at which mbed_main() is called in IAR compiler.
Because we failed about test "mbed call before main" in IAR compiler.
Ref:https://github.com/mbedmicro/mbed/pull/2018#issuecomment-229236123
Regards,
Tomo Yamanaka

Is this required - main() should invoked wrapped main where mbed_main() is invoked, or?

Main isn't wrapped for IAR which is why this is needed.  This was done for the Cortex-M here:
https://github.com/mbedmicro/mbed/blob/9f33ba87b0acf0c4b9f4083f9568343000a6d303/rtos/rtx/TARGET_CORTEX_M/RTX_CM_lib.h#L743

we Renesas revised RTX_CM_lib.h in consideration of the startup process in Cortex-M implementation.
For reference information.
Cortex-M:
https://github.com/mbedmicro/mbed/pull/1998/commits/93773bad68609a2ca6eb611c616e8c7232230730
Discussion for this matter:
https://github.com/ARMmbed/mbed-renesas/issues/2


Build failed when i put the masonry directory into my project

Delete the NS_NOESCAPE can solve the problem,pod masonry dosen't has this problem

I have the same problem

I have the same problem
did you solve this problem?


test: add image api tests

Signed-off-by: letty<EMAIL_ADDRESS>
1.Describe what this PR did
Add an image test
Add "-check.v" args to print verbose info when run integration test.
2.Does this pull request fix one issue?

3.Describe how you did it
4.Describe how to verify it
5.Special notes for reviews

LGTM


Noam first branch

please add a description of the commit.
Adding the "close number" is good. But after it please add a comment about the commit


Implement .par_map_inplace() and .par_map(f) -> Array

Successor to #252

rust-ndarray/pull/264 adopts most of this, in a separate crate. par_map next, I guess.


Cleanups for Distance Request PR

This issue tracks all cleanup items for https://github.com/Expensify/App/pull/25707

[x] Extract getWaypointMarkers to DistanceRequestUtils

[x] Implement better waypoint validation to be used on the Distance Request page.
Because of the offline first approach, unless the number of waypoints exceed the max allowed number, we allow the user to click the "Next" button.

[x] Select only a token in the withOnyx selector DistanceRequest

[x] Check the decimal support for currencies in NewDot
https://expensify.slack.com/archives/C03TQ48KC/p1695519779789089 -> https://expensify.slack.com/archives/C03TQ48KC/p1695521035370409?thread_ts=1695519779.789089&cid=C03TQ48KC
I remember this one was handled in one of the regression issues.

[x] Check the need for serialization of waypoints
https://expensify.slack.com/archives/C05DWUDHVK7/p1695520363474629
[Refactor of xhr code?](https://expensify.slack.com/archives/C05DWUDHVK7/p1698796111107849?thread_ts=1695520363.474629&cid=C05DWUDHVK7)

[x] Use Onyx selector to get only what we need

[x] Cleanup the logic for checking if the money request is a distance request
Tim is working on this

[x] Pass the reportID of the workspace to the distance request page
https://expensify.slack.com/archives/C05DWUDHVK7/p1695520989309769

Proposal
Please re-state the problem we are trying to solve
Implement better waypoint validation to be used on the Distance Request page. Also, this PR(https://github.com/Expensify/App/pull/25707) has introduced some bugs, which are listed in the root cause. Also, I have filed a bug related to this PR on slack: https://expensify.slack.com/archives/C049HHMV9SM/p1693644109050329
What is the root cause of this problem?

In the PR, we changed Boolean(loadashGet(...)) to loadshHas but this causes problem because even if errorFields.route is null, loadashHas still returns true because the errorFields.route property exists.
https://github.com/Expensify/App/blob/9701fbe5ec24bf5031da390075b2a9fb125b3ce3/src/components/DistanceRequest.js#L89
We don't disable the Next button if hasRouteError is true
https://github.com/Expensify/App/blob/9701fbe5ec24bf5031da390075b2a9fb125b3ce3/src/components/DistanceRequest.js#L259
When a waypoint with invalid route is entered the error is shown, but while editing if we add the same invalid point again, the error gets deleted and the app doesn't fetch the route from BE because shouldFetchRoute is false as waypoint has not changed. Therefore, we end up clearing the error even though the route is invalid.
We are making a mistake by clearing the errors immediately if the waypoints are changed here:
https://github.com/Expensify/App/blob/9701fbe5ec24bf5031da390075b2a9fb125b3ce3/src/libs/actions/Transaction.js#L83-L87

What changes should be made to fix this?

We should reverse the lodashHas change for hasRouteError and use Boolean(lodashGet(...)).
We should add the hasRouteError condition to the isDisabled prop of the Next button.
We should add the isLoading prop to the Next button and set it to isLoadingRoute because it can prevent user from going ahead with invalid route with fast clicking.
We should stop clearing the errorFields when waypoint is changed because they will automatically get cleared when new route is fetched.
(BE change) There should be a minimum distance (like 1 km) shorter than which the user cannot take a trip because currently, we allow user to have the start and finish as the same which should not be allowed. The distance is I think calculated on the BE, so this fix should be there, but I think it is also possible to invalidate the distance on frontend as well.

@hayata-suenaga I know this issue was meant for engineering but since we need to have MVP for distance requests before Wed, please consider my proposal. I can make these changes on the weekend as well. Please let me know if you would like me to work on any other issues listed here (or if I should submit a proposal for each of them)

Proposal
Please re-state the problem we are trying to solve
Issue 6: Use Onyx selector to get only what we need.
What is the root cause of this issue?
It currently seems like we are getting unnecessary data from Onyx in DistanceRequestPage here:
https://github.com/Expensify/App/blob/9701fbe5ec24bf5031da390075b2a9fb125b3ce3/src/pages/iou/DistanceRequestPage.js#L68-L73
And we should use selector to get only the things we need.
What changes should be made to fix this?
I think we should copy the logic being used in the NewRequestAmountPage where the NewRequestAmountPage subscribe to the ONYXKEYS.IOU and passes a onSubmitButtonPressed prop to the MoneyRequestAmountForm and handles all the IOU logic in the NewRequestAmountPage component itself.
https://github.com/Expensify/App/blob/9701fbe5ec24bf5031da390075b2a9fb125b3ce3/src/pages/iou/steps/NewRequestAmountPage.js#L198-L202
https://github.com/Expensify/App/blob/9701fbe5ec24bf5031da390075b2a9fb125b3ce3/src/pages/iou/steps/NewRequestAmountPage.js#L163
Summary

Using the approach, we would not need to pass iou, iouType, report, reportID to the DistanceRequest component. We can just pass the onSubmitButtonPressed prop like this:

<DistanceRequest
   onSubmitButtonPressed={() => IOU.navigateToNextPage(iou, iouType, reportID, report)}
   transactionID={iou.transactionID}
/>

We can modify the DistanceRequest component to use the props.transactionID directly passed instead of using iou.transactionID in the withOnyx:
https://github.com/Expensify/App/blob/9701fbe5ec24bf5031da390075b2a9fb125b3ce3/src/components/DistanceRequest.js#L269-L272
Change all instances in DistanceRequest component where iou.transactionID is used to use the transactionID prop passed directly.

With these changes, DistanceRequest only has prop that it actually requires and prevents unnecessary updating and this mirrors the NewRequestAmountPage logic to maintain consistency.

bump @hayata-suenaga I think many of the urgent issues that are coming up for distance requests can be solved if we do the clean-up PR, could you please once review the proposals I have provided? I think this one is especially important: https://github.com/Expensify/App/issues/26451#issuecomment-1703780536

@esh-g I think some of the issues have been already solved
But I'm so impressed by your research and proposals. We might ask contributors' help in some of these follow up items so please keep an eye on this issue 😄

Changing this to weekly

gonna work on this over this weekend

@esh-g hi do you have a good question on the last item on the original post?

Pass the reportID of the workspace to the distance request page

@hayata-suenaga I investigated this and here are the findings:

From the convo you linked, I think you may be referring to the reportID on MoneyRequestConfirmPage because in DistanceRequestPage we already are getting the reportID from the URL (iou.participants will not be defined anyway before the participants selector page) so the rest of the points are about MoneyRequestConfirmPage
https://github.com/Expensify/App/blob/5aa7f6da94ddb1c8ca55a6cce714555f819c1dd0/src/pages/iou/DistanceRequestPage.js#L73-L75

Currently we first see the reportID passed in the URL and if it's not passed, we the the participants.0.reportID
https://github.com/Expensify/App/blob/5aa7f6da94ddb1c8ca55a6cce714555f819c1dd0/src/pages/iou/steps/MoneyRequestConfirmPage.js#L361-L371

The only case where I see that reportID will not be defined in the URL, is if the user explicitly edits the url or clicks on an edited link because the MoneyRequestConfirmationPage would always come after the participants selection is done.  Could you please elaborate on the "global create"?
Moreover, we cannot rely on the iou.participants.0.reportID for long, because we plan on only storing the participantsIDs as mentioned here:
https://github.com/Expensify/App/blob/5aa7f6da94ddb1c8ca55a6cce714555f819c1dd0/src/libs/actions/IOU.js#L2062-L2066

Here is a related issue that I reported on slack when the reportID passed in the URL is invalid. Basically the app crashes because then the reportID is invalid because we are trying to access report.policyID in the last withOnyx selector when the report doesn't exist.
https://github.com/Expensify/App/blob/5aa7f6da94ddb1c8ca55a6cce714555f819c1dd0/src/pages/iou/steps/MoneyRequestConfirmPage.js#L381-L384

Inference: I think we should skip checking iou.participants.0.reportID and just rely on reportID from navigation, because the iou.participants is going to be refactored to use only accountIDs. Unless, there is a case where reportID isn't defined (without user editing the link), I think we can rely on this parameter.

@hayata-suenaga It might seem a little lengthy but let me know if you need any elaboration about the things mentioned in the above comment 😇

thank you so much for the explanation. I'm held up in different projects but I'll come back to this by the end of this week

gentle bump @hayata-suenaga

We're keeping an eye on this one and Hayata said he'll finish it off within a week.

yep @esh-g I'll preview your proposal and might assign that part to you.
I'll get back to this issue over the weekend

@esh-g thank you for reminding about this. I'll work on this sometime next week

okay... I think I can get to this tomorrow

Checked off all cleanup items. Closing this issue now


[ServiceBus] Docs update - Readme, Changelog, Dosctring

[x] Readme

[x] Troubleshooting section

[x] Changelog
[x] Docstring
[x] Code snippets
[x] Migration guide

Closed per preview 1 code complete.


feat: azure publish with orchestrator

Description
In azure publish we use the old build flow and copy some code from local build and generate the crosstrain config by itself. It is difficult to upgrade this part code of build and add new feature for azure publish.
In this PR:

remove the duplicate code for build and use the builder instance from current project to build the bot.

add orchestrator build for azure publish

update the build result in orchestrator.setting.json.(use relative path)

copy the orchestrator build model to bot folder

Task Item
closes #4980

Screenshots

@taicchoumsft @luhan2017 can you help verify this?

Coverage decreased (-0.05%) to 55.347% when pulling ef1e5bc4a19d777350d4ba25b1384339936bba06 on lei9444:azurebuild into 6ad49456415e154794cc8936fe50b3e6fcb5c391 on microsoft:main.

@VanyLaw can you also help take a look at this one, there is some refactor along with the new feature, we basically removed a lot of duplicated code, can you confirm if it make sense?

The qna build error is not properly handled:

The publish is success, but I can't query the remote bot

The qna build error is not properly handled:

The publish is success, but I can't query the remote bot

fixed it


ci: fix ubuntu version to 22.04

This PR sets ubuntu version to 22.04 for scripts run with python 3.7.
Reference: ADDON-75861
Python version for pre-commit can not be updated to latest version due to open issue with the docformatter hook.
Reference: https://github.com/PyCQA/docformatter/issues/289, https://github.com/PyCQA/docformatter/issues/293

:tada: This PR is included in version 5.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 5.5.0-beta.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Mixing of AE Properties and JS Attributes in a Single Key Path

new version allows to change values and expressions in key paths with a mix of properties and attributes
the main functionality for this has been moved to the nexrender.jsx such that it is not copied for every asset
evaluation of expressions to change attributes has been improved such that a mix of variable scoping is minimised
update of documentation with an example and short explanation of this feature

@inlife Can you release this feature as soon as you can?? I need this feature :)
@brassel thx, good job!

thank you, @blaswan ! And thanks to @inlife for merging and overall for this great project!!!!

no, thank you @brassel for the contribution!!

A PR may not be the best place to ask, but my question is very specific.
I'm using Source Text.font and Source Text.fontSize and both work well.
Now I'm trying Source Text.autoLeading (boolean) and Source Text.leading (integer) and they seem to be ignored.
Are they supported? Are the names wrong? Thanks!

Hi @romanws,
this is a bit hard to answer, but looking here
https://ae-scripting.docsforadobe.dev/other/textdocument/?highlight=leading#textdocument-leading
there seems nothing special about "leading" but I cannot find anything called "autoleading". I guess you have to debug your way through this with some alerts to see if the values are correctly set or not.

Hi @brassel. Thank you for the quick answer. And I have to apologize because I've just found that I had an error in my code.
Everything works fine. In After Effects I have a project that has line leading = Auto, which means leading is 120% of the font size. Via nexrender I could override that and set a custom leading:
  {
   "type": "data",
   "layerIndex": 62,
   "property": "Source Text.autoLeading",
   "value": false,
   "composition": "comp1"
  },
  {
   "type": "data",
   "layerIndex": 62,
   "property": "Source Text.leading",
   "value": 58,
   "composition": "comp1"
  },


do not lower keys

Fix https://github.com/docker/swarm/issues/1795

ping @chanwit any idea why we used ToLower ?

Job: Swarm-PRs (engine 1.9) [FAILED](https://jenkins.dockerproject.org/job/Swarm-PRs (engine 1.9)/36/console):

---
- docker network rm
ok 154 mesos - docker network disconnect connect
ok 155 mesos - docker ps
ok 156 mesos - docker run with wrong user
ok 157 mesos - docker run
ok 158 mesos - docker run short lived
ok 159 mesos - docker run no resources
ok 160 mesos - docker run with long pull
ok 161 mesos - docker stats
ok 162 mesos - docker-compose ps
ok 163 mesos - docker-compose scale
ok 164 mesos - docker-compose up
ok 165 mesos - zookeeper
Build step 'Execute shell' marked build as failure
[PostBuildScript] - Execution post build scripts.
[Swarm-PRs (engine 1.9)] $ /bin/sh -xe /tmp/hudson1948078883045168190.sh
+ set +x

---

LGTM

@vieux @chanwit Looking at the file's history, it seems like ToLower has been around for a while.

yes
On Thu, Feb 11, 2016 at 1:46 PM, Nishant Totla<EMAIL_ADDRESS>wrote:

@vieux https://github.com/vieux @chanwit https://github.com/chanwit
Looking at the file's history, it seems like ToLower has been around for
a while.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/swarm/pull/1800#issuecomment-183070659.

--
Victor Vieux
Docker Core Engineer
<EMAIL_ADDRESS>

Was there a limit on what the constraints could be at one point? Earliest valid matching code looks like 4726477dbe1dd5ac3a7eee6430aee2f54f516b50.

It's started by having node and all other labels in lower cases. A bad design of me :(
Removal is just fine.
LGTM

LGTM
(test failure seems unrelated)


replace uWSGI with Gunicorn

Currently, the training doesn't work, as it's using uWSGI settings for galaxy and Gunicorn settings for NGINX.
I updated it to be fully Gunicorn complaint.
As soon as https://github.com/galaxyproject/ansible-galaxy/issues/160 will be closed, I can finish updating it.

Yep, we got most of this in the last PR which updated everything but the roles. Thanks for finalising it! I'll have a look at this tomorrow

0.10.1 is released.


Hardcoded parse logic

Presently the logic to parse types is hardcoded https://github.com/juancarlospaco/cliche/blob/nim/src/cliche.nim#L122-L139 . Is there any specific reason this does not use a generic interface like the following?
proc parseCommand[T](input: openarray[char]): T

This would enable support for any user type, without any added support from you.

The idea was to parse Primitives with decent performance for any targets,
not so much complex big types or any arbitrary unstructured data.
What would you put inside that proc ?
Just the same of the lines https://github.com/juancarlospaco/cliche/blob/nim/src/cliche.nim#L122-L139 ?
I am not complaining just wondering. PR are welcome too.

It would not be a single proc it'd be one for each type so you'd have:
import std/parseutils

proc parseCommand(oa: openarray[char], T: typedesc[bool]): T =
  if oa == "true":
    true
  elif oa == "false":
    false
  else:
    raise newException(ValueError, "Could not parse")

proc parseCommand(oa: openarray[char], T: typedesc[int]): T =
  parseint(oa) # 1.7.x only sorry :P

This would allow support for user defined data types, and make it less tedious to add new first class types.


log() with '%s' does not work with booleans

Sample:
console.log('%s', true);
console.log('%s %s', 'test', true);

Output:
%strue
%s %stesttrue

That is not a Scribe problem, that's is a JS problem. Your using something called printf formatting, printf never had a boolean flag. So a workaround to this would be
console.log('B: %s', true ? 'true' : 'false');
This will print out
B: true

Locally I changed line 142 in /lib/console2.js from
if (!(typeof elem === 'string' || typeof elem === 'number')) {

to
if (!(typeof elem === 'string' || typeof elem === 'number' || typeof elem === 'boolean')) {

and it helped.


Dependency Injection: Scopes

Follows #1
When a constructor is registered in the DI Container, registrar can define a scope of the instance created by the constructor. I think of them as an Enum of objects (functions? objects with state?), that know when they want to create a new instance and when to return the old one.
I think of them as something like the code below:
from enum import Enum
import typing as t

from pca.utils.functools import reify

class Container:

    _singleton_objects = {}

    @reify
    def _thread_local(self):
        from threading import local
        return local()

    def find_by_interface(self, interface):
        raise NotImplementedError

    def register_by_interface(self, interface):
        raise NotImplementedError

def instance_scope(container: Container, constructor: t.Callable) -> t.Any:
    """Every injection makes a new instance."""
    return constructor()

def thread_scope(container: Container, constructor: t.Callable) -> t.Any:
    _thread_local = container._thread_local
    try:
        objects = _thread_local.objects
    except AttributeError:
        objects = {}
        _thread_local.objects = objects

    if constructor in objects:
        return objects[constructor]
    else:
        obj = constructor()
        objects[constructor] = obj
    return obj

def request_scope(container: Container, constructor: t.Callable) -> t.Any:
    """
    Created once per request in the container. Uses Container to find the request
    (whatever it is in your application), so don't get caught into infinite recursion
    using the scope onto request.
    """
    # TODO should request has the same API find/register_by_interface?
    # TODO or should request generate some UUID which is used as a key for the container
    # TODO but when & how to clean objects for requests that are already dead

    request = container.find_by_interface(IRequest)
    try:
        return request.find_by_interface[constructor]
    except KeyError:
        obj = constructor()
        request.register_by_interface[constructor] = obj
        return obj

def session_scope(container: Container, constructor: t.Callable) -> t.Any:
    # TODO same problem as in the request_scope
    raise NotImplementedError

def singleton_scope(container: Container, constructor: t.Callable) -> t.Any:
    """Created only once in the container."""
    try:
        return container._singleton_objects[constructor]
    except KeyError:
        obj = constructor()
        container._singleton_objects[constructor] = obj
        return obj

class Scopes(Enum):
    INSTANCE = instance_scope  # every injection makes a new instance
    REQUEST = request_scope  # per a "request" (whatever a request is in your application)
    SESSION = session_scope  # per session (whatever is a user session in your application)
    THREAD = thread_scope  # per thread (via `threading.local`)
    SINGLETON = singleton_scope  # always the same instance in this container

    def get_object(self, container: Container, constructor: t.Callable):
        return self.value(container, constructor)

Flag with Important: goals of incoming version (see roadmap) will need session scope and request scope, at least in the context of CLI.

Note: the request scope in the context of CLI is just a singleton scope, as the process running CLI command finishes at the end of the request. I See two solutions:

scope choosing has some kind of fallback mode (I have no request scope then I choose the singleton)
or it has to be by passing strategies to Container construction?


Automated cherry pick of #10452: fix: avoid panic when use idc vpc

Cherry pick of #10452 on release/3.6.
#10452: fix: avoid panic when use idc vpc

Codecov Report

Merging #10454 (be2e979) into release/3.6 (b9d30c0) will increase coverage by 2.20%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release/3.6   #10454       +/-   ##
================================================
+ Coverage         5.86%    8.07%    +2.20%
================================================
  Files              828      107      -721
  Lines           129133    13008   -116125
================================================
- Hits              7577     1050     -6527
+ Misses          120876    11838   -109038
+ Partials           680      120      -560

Flag
Coverage Δ

aFlag
8.07% <0.00%> (+2.20%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apigateway/handler/auth.go
0.00% <0.00%> (ø)

pkg/apigateway/handler/auth_totp.go
0.00% <0.00%> (ø)

pkg/apigateway/handler/idp.go
1.84% <0.00%> (ø)

pkg/apigateway/handler/misc.go
0.00% <0.00%> (ø)

pkg/apigateway/handler/resource.go
0.00% <0.00%> (ø)

pkg/monitor/alerting/eval_context.go
34.25% <0.00%> (-3.89%)
:arrow_down:

pkg/monitor/alerting/rule.go
1.86% <0.00%> (-1.03%)
:arrow_down:

pkg/multicloud/esxi/manager.go
0.61% <0.00%> (-0.09%)
:arrow_down:

pkg/util/sysutils/kvm.go
2.91% <0.00%> (-0.06%)
:arrow_down:

pkg/multicloud/esxi/host.go
0.77% <0.00%> (-0.01%)
:arrow_down:

... and 614 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 686d314...be2e979. Read the comment docs.


Bug Report: Reaction to Keyboard input is anomalous

Environment
Windows build number: [Version 10.0.18898.1000]
Windows Terminal version (if applicable): <IP_ADDRESS>

Steps to reproduce

Start terminal
ssh to a remote host
disconnect from the internet while connected to the network
Try to type something on the terminal and observe

Expected behavior
The keyboard input should be working properly

Actual behavior
Weird reaction to input. Although on enter the write input is processed.

Also if an editor like vim was open as can be seen the screen is not cleared on loss of connection.
It will be nice to have the normal error telling you of a timeout error and the terminal goes back to working as it was working before.

This is with ssh.exe Hadn't checked with wsl.

I'm going to say that there's a 99% chance then that this belongs in PowerShell/Win32-OpenSSH instead then.
Does this only repro in the Windows Terminal, or does this repro from a standard console window too? (try opening cmd.exe or powershell.exe, then launching ssh.exe)

@zadjii-msft The standard console window has the issue with not clearing the screen as well but the input is handled fine as well. As shown below:

Powershell, on the other hand, results in both screen not being cleared and the reaction to keyboard input being anomalous. Find below the output from PowerShell:

This looks like a standard case of what happens when the remote application has requested a specific terminal mode and been terminated without resetting it to default. In the vim case specifically, there’s nothing we can do about that!

@DHowett-MSFT understood. I guess the issue with the keyboard is caused by vim open vim aswell as this is not reproducable when it was not open.
Thanks for the feedback.

This seems to have been answered.


Revise actions on view page into dropdown (or something)

Actions toolbar across the top makes search sort of invisible

Done.


Make code buildable with AWS-LC

Nothing is tested with AWS-LC, but it builds.

[approve ci]

[approve ci]

It's not 10.0 blocker, but I'd like to merge this before it gets conflicts.

Cherry-picked to v10.0.x


ISSUE-52: fix bug where a mesh with at leat one vertex without…

weights causes an exception
Fixes #52

Coverage remained the same at 94.251% when pulling 5c168366baa0c47bf7daa785c6c5f331602eefd9 on bugfix/ISSUE-52-weights-error into 47577c17b6ff9de8cb438778dcef25d6f2795f95 on develop.


Amendments to deploy.sh

Amending how deploy grabs workspace name for main branches, change identical to previous fix for apply terraform

DEPLOY_URL=https://d2sforw18q69g6.cloudfront.net/
cloudfront_id=E3S8MKGP563FTQ


Proper minimallyValidated implementation for initial ELT setup process

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/643
Originally created by @derek-knox on 2019-05-06 13:40:50

Problem to solve

The user could get confused by being able to access UIs that require previous steps to have been accomplished before they are useful

Target audience

UI users

Further details

During the ELT setup process we want to intentionally funnel and guide the user through a sequence of steps. Only after the first successful passthrough should every step (glorified tab) be accessible without requiring a specific sequence

Proposal

Each step in the process will have a minimallyValidated state (that's an aggregate of 2+ conditions being met) that unlocks/enables the next step to be accessed (which we additionally deep link to for further streamlining the setup process)

What does success look like, and how can we measure that?

The steps that are irrelevant are disabled until the prior step conditions are minimallyValidated

Regression test
(Ensure the feature doesn't cause any regressions)

[ ] Write adequate test cases and submit test results
[ ] Test results should be reviewed by a person from the team

Links / references
Please note that this was taken from GitLab, to be changed accordingly

View 4 previous comments from the original issue on GitLab


Improve the division emulation in the Arm backend

This commit improves the division emulation in the Arm backend to enhance code reusability and eliminate potential issues.
Close #135

Thank @DrXiao for contributing!


Retry flushing after errors functioning correctly?

Hi –
First of all, thanks for making this an Open Source library.
I just looked briefly at the code trying to figure out what the retry behavior is when tracking events in case the user is on a bad network.
The relevant code is this:
- (void)flushQueue:(NSMutableArray *)queue endpoint:(NSString *)endpoint
{
    while ([queue count] > 0) {
        NSUInteger batchSize = ([queue count] > 50) ? 50 : [queue count];
        NSArray *batch = [queue subarrayWithRange:NSMakeRange(0, batchSize)];

        NSString *requestData = [self encodeAPIData:batch];
        NSString *postBody = [NSString stringWithFormat:@"ip=1&data=%@", requestData];
        MixpanelDebug(@"%@ flushing %lu of %lu to %@: %@", self, (unsigned long)[batch count], (unsigned long)[queue count], endpoint, queue);
        NSURLRequest *request = [self apiRequestWithEndpoint:endpoint andBody:postBody];
        NSError *error = nil;

        [self updateNetworkActivityIndicator:YES];

        NSURLResponse *urlResponse = nil;
        NSData *responseData = [NSURLConnection sendSynchronousRequest:request returningResponse:&urlResponse error:&error];

        [self updateNetworkActivityIndicator:NO];

        if (error) {
            MixpanelError(@"%@ network failure: %@", self, error);
            break;
        }

        NSString *response = [[NSString alloc] initWithData:responseData encoding:NSUTF8StringEncoding];
        if ([response intValue] == 0) {
            MixpanelError(@"%@ %@ api rejected some items", self, endpoint);
        }

        [queue removeObjectsInArray:batch];
    }
}

This gets called on a serial background queue, so that part is fine. This tries to flush an eventQueue (just an array) every 60 seconds or when the app is backgrounded. If there's an error making the request, it doesn't remove the current batch (due to the break) and it will retry those the next time around.
Assuming there is no error, the Mixpanel client code here seems to expect a very primitive server response: 1 in case of success, 0 otherwise (0 is in fact only handled with a print, under the assumption that it's the Mixpanel server that decided that "some items should be rejected").
However, these seem like poor checks. There's a number of other recoverable failures that don't result in a non-nil error and will result in data loss.
Just one example: Say the user is in a coffee shop / on a hotel WiFi and the café/hotel runs a proxy through which the user must connect. If the app tries to send the request before the proxy allows it, then the error will be nil, but you will have sent the data to the proxy which will just discard it and the data is lost.
To simulate this, one thing you can do is just change the serverURL to something like http://google.com. Then what will happen is this:
2015-10-23 00:17:31.679 TestCenter[17879:4620107] <Mixpanel: 0x7f9982a39d30 2178e0df6f413afb8c43afe3bbd13f04> /track/ api rejected some items
<Breakpoint triggers at the end of the `flush` method>
(lldb) po error
 nil
(lldb) po response
<!DOCTYPE html>
… further stuff from Google …

While still not ideal, a simple patch that would not require server-side patches (and thus hopefully be backwards-compatible) would be:
diff --git a/Mixpanel/Mixpanel.m b/Mixpanel/Mixpanel.m
index 5d8a927..6e893ec 100755
--- a/Mixpanel/Mixpanel.m
+++ b/Mixpanel/Mixpanel.m
@@ -662,6 +662,13 @@ static __unused NSString *MPURLEncode(NSString *s)
         NSString *response = [[NSString alloc] initWithData:responseData encoding:NSUTF8StringEncoding];
         if ([response intValue] == 0) {
             MixpanelError(@"%@ %@ api rejected some items", self, endpoint);
+        } else if ([response intValue] == 1) {
+            // Success
+        } else {
+            // Another failure occurred. We expected a response of either `0` or `1`, but received something else.
+            // Maybe we were on hotel WiFi and had the request intercepted. Don't drop the data but retry again later.
+            // XXX Ideally we'd do something more intelligent, maybe by looking at `urlResponse` more closely.
+            break;
         }

         [queue removeObjectsInArray:batch];

Does that make sense? Is this something that should be patched? Just in case the answer is yes, I'll attach a PR.

I think you are correct. But the example you give is actually the only case I can think of in which this would happen. Would happily review a PR.
THANKS!

@samgreen Here you go: https://github.com/mixpanel/mixpanel-iphone/pull/370
Do with that what you will. I am not to be held liable if this breaks the universe. :-)
(I think a more rigorous backwards-compatible check would also look at the response headers and look for a header field that's only set by the Mixpanel server. But this might just be good enough for most cases, and is really all I can do without access to the servers.)


RepositoryToken is invalid. Provided token has invalid permissions and cannot be used to setup Github Action CI/CD. Admin rights are required for the repository.

RepositoryToken is invalid. Provided token has invalid permissions and cannot be used to setup Github Action CI/CD. Admin rights are required for the repository.

Hi @ParageeSharma! It sounds like you may be trying to set a GitHub Action against this repository, instead of your own. To create your own version of this, and set up Actions to deploy, you will need to start by forking this to your own (https://github.com/education/codespaces-project-template-js#create-your-portfolio).
I'm going to close this issue, but if you have any questions or issues, please feel free to open a new GitHub issue or discussion.


Resin deploy ux improvements

A couple of other small changes I noticed along the way with the deploy gzipping stuff, pulled out as a separate PR. This PR:

Shows the correct error if a build fails (instead of 'could not delete bufferFile', which happened before, because the finally step fails in that case)
Shows an 'Initializing deploy...' message after the build, so you can tell what's going on during the couple of seconds gap while we get the docker image and buffer it to disk.
Tweaks the docs slightly for clarity (mainly to be consistent about deploying images, not containers)

This PR reminds me about an issue that @imrehg found, and I think it would kinda make sense to also handle it here. Basically he was using resin deploy and aiming it at a raspberry pi docker daemon. This is something that I never tested, but basically there is a significant delay with this method on the image.get call (exporting to a tar archive from the remote to the client/host), so we should add at least an output message there informing the user what is going on.

With this PR, you now get the Initializing deploy... message before that image.get() starts, so there's a little feedback here (although not in detail, and not a progress bar or anything). Is that what you were looking for, or something more in depth?


[Feature Request]: Information in StatusBar

Likes https://github.com/vrtmrz/obsidian-livesync sync informationin StatusBar.
Status：
⏹ Stopped
💤 SyncFTP is enabled. Waiting for changes.
⚡ Synchronize is now in progress.
⚠ Error occurred.
↑ Uploaded pieces
↓ Downloaded pieces
⏳ Count of the pending process

Thanks for the recommendation and pointing me to the livesync plugin as well. I do not have a strict timeline but will consider these.

Further updates may happen but are not planned, as core functionality was my primary goal. Closing this now, further update consideration will be at my discretion.


TELEWORK: FormsFlow PIA

User Story
As an employee, I want my completed form to be purged from the Formsflow system so I know my personal information is protected.
Tasks

[x] Investigate privacy implications of storing completed applications within Formsflow

[x] Write business rules for when completed and incomplete applications should be purged from the system

[x] Get approval from client for these business rules

[x] Liaison with PMO to make sure business rules met legal standards

[x] Update PIA (if need be)

Acceptance Criteria

[x] All above tasks are complete

[ ] Business rules met legal security and privacy requirements

@alexandralloyd Sure, can you please give me more details before I can estimate? Thank you
Are we deleting the submissions as soon as the workflow ends (Rejected/Approved for Telework)? Or it is a batch delete after a certain time interval?
What involves in terms of UI/UX for deletion? things such as showing a notification on TOOL that says it is deleted or any plan to send email to users?

@iman-jamali-fw We'll be notifying employees that once they finish the application and it is approved/rejected that the application will be automatically deleted via the front end of the form, the landing page, and the email after submission.
For the pending applications that don't get approved/denied, tentatively we wanted to have these batch deleted after 30 days. This information will be communicated to managers in their notification email.
We don't anticipate the need for any in tool notification of the deletion of the form to the users (manager/employee).

So dev work for this ticket would be:

Delete completed submissions (On complete)
Delete pending submissions after 30 days ( supervisor will be notified by an email)

Hi Alex, I believe we will need to update/amend the PIA (and or FOIPPA statements?) with some language such as....
Completed Telework forms are those that have an approved or rejected status. Completed Telework forms will be deleted/nor stored in the formsflow Application.
Incomplete/pending applications that don't get approved or are denied will be batch deleted after 30 days. (Where would these one get stored until then?)
I don't believe we need the client's approval about the 30 days, but I will check with Sean/Policy.
Suggestion only: The email language say something like: Your Telework submission was not completed and is no longer available. Please resubmit a new Telework agreement...."

PIA with Jennifer, will need to be resigned but doesn't anticipate it will impact timeline.

@alexandralloyd, once the MPO signs it, do we have to get Rueben to resign it? If so, we should leave the ticket open, if not, I think we can close it.

waiting for Dwayne/Reuben signature before closing

@alexandralloyd Can you share an update where the PIA is now - is it with Jennifer/Privacy?

@MeghanStothers Still waiting for MPOs signatures

Confirmed with Igor it is okay to change Indy's name to Rueben Bronee. Meeting arranged by Nass

Updated PIA signed by Rueben and will be saved to the Teams folder .
Our team is waiting for OCIO approved list of gov't domains from Nic Berry and Igor Krasnov about approved gov’t email addresses/domains for sending personal information – captured in pdf versions of the digital telework form – across the internet. They confirmed we are clear to launch on August 2.
Our team has one further piece of technical work to do before launch to potentially restrict some email domains outside the gov’t network. Our goal is to make as many email addresses available as possible within the digital form, in addition to all “gov.bc.ca” ones.
Meghan/Alison to advise Rueben and Sean know of any groups that might be restricted from completing the digital Telework form.
Igor and Nic noted further PIA/STRA updates will likely be requested post-launch.


Update vpn-deploy-ras.md

adding recommendation on  IPv4 subnet assignment

@cstraessner : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Teresa's suggested changes were added to a different PR, see comment above.


Update Docs

The old version of documentation (about class-based components) doesn't seem to have updated the new changes.
Can you check if these fixes are correct?

The other change makes sense but it should instead be rewritten so that the new behavior is described by default. I.e. the docs always describe the latest behavior.


[openvino] disble apiValidator search

Closes https://github.com/microsoft/vcpkg/issues/38221
Ports https://github.com/openvinotoolkit/openvino/pull/25069

[X] Changes comply with the maintainer guide.
[ ] SHA512s are updated for each updated download.
[ ] The "supports" clause reflects platforms that may be fixed by this new version.
[ ] Any fixed CI baseline entries are removed from that file.
[ ] Any patches that are no longer applied are deleted from the port's directory.
[X] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[X] Only one version is added to each modified port's versions file.

Thanks for the port from upstream!


The Date constructor can't be passed string | Date, but takes either individually.

TypeScript Version: 2.7.0-dev.20171209
Code
How come these are both error-free individually:
new Date(new Date())
new Date("123")

But this is a type error?
  new Date(Math.random() ? new Date() : "123");

Expected behavior:
I would expect the second code sample to not give a type error.
Actual behavior:
I get the following error:
Argument of type 'Date | "123"' is not assignable to parameter of type 'VarDate'.
  Type 'Date' is not assignable to type 'VarDate'.
    Property 'VarDate_typekey' is missing in type 'Date'.

I don't understand what VarDate is, so this is a little confusing.

VarDate is a type that's only supposed to be present when you use --lib scripthost 🤔
Anyway, it seems that src/lib/es5.d.ts is missing a version of the constructor that accepts string | number, and src/lib/es2015.core.d.ts is missing a version that accepts Date | string | number. (new Date appears to not officially accept Date objects before ES2015; they do work because they go through ToPrimitive, which converts them to number, which is then processed, so maybe that should be unified with es5.d.ts?)
https://www.ecma-international.org/ecma-262/5.1/#sec-<IP_ADDRESS>

thanks @alan-agius4!

@Kovensky, could you post a link to where the motivation for this stricter behavior is discussed? I can't seem to find anything about it (it doesn't seem to be a bivariance thing, and I do not have --strictFunctionTypes enabled anyway), and I'd be interested to know what the motivation was.

I've got this issue as well, just updated VS to 15.6 which prompted to update TS to 2.6 and my build broke.
Is there a workaround or should I just revert to 2.5 until this is fixed?

There are two sets of overloads for Date constructor. one in the ES6/S2015 lib, this was fixed by #21757. #21757 missed the set of overloads in ES5 though. this should be fixed by https://github.com/Microsoft/TypeScript/pull/23203.


Make Caffeine the default in-memory cache

Per #4062, Druid now requires a Java 8 runtime. Previously the JDK7 support meant that the Caffeine integration was provided as an optional plugin. The default in-memory cache is a synchronized LinkedHashMap, which has low performance in production usages.
Switching was approved so this should improve the out-of-the-box experience.

@ben-manes would you be willing to contribute a patch that does the necessary shuffling around of things?

I could try, but I wouldn't be able to get to it for a week or two.

You might still get to it first!
Going to mark this 0.10.1 since it seems like something we should be able to do for the next release.
Btw, there is no "default" cache (by default cache is disabled, and enabling it requires setting a specific cache type) so imo, what this issue should be about is:

Move caffeine-cache from an extension to core
Update the example cache configs (where most users get their first cache configs from) to use caffeine instead of local
Update other caching related docs, and release notes, to push people towards choosing caffeine over local
Possibly deprecate local

An alternative interpretation is we should merge local with caffeine so they both do the same thing, but I don't think we should do this right now, in part because the configs are different and so it wouldn't be a fully compatible change with folks' existing configs. imo, it would make sense to do that in the next major release when local is not just deprecated, but removed.

To play Devils' advocate here:
Is there any advantage to moving it to core vs updating the example configs to include it by default?

My thinking is that since local and memcache are not-extensions, having caffeine be an extension makes it feel less "recommended". If local cache and memcache became extensions too then it would make sense for caffeine to stay an extension.

Would moving memcached and local to extensions make sense?

Or maybe just memcached

A "reference implementation" with no external dependencies is a good thing to keep in core druid

Having quality extensions helps serve as examples and templates for new developers.

Are you envisioning a path to deprecating and eventually removing local in that case? I was thinking a process like (1) move caffeine to core, (2) deprecate local, (3) remove local, (4) now caffeine is the only remaining local mode cache.
If caffeine stays an extension that at steps (3) and (4) we won't have any cache impl in core.

I was thinking:

Make things that are extension point AND require external dependencies be an extension
Move memcached to an extension
Make "local" the reference implementation inside of Druid and memcached/caffeine the reference extensions in extensions-core.
Since the hybrid cache doesn't require external dependencies, I'm not quite sure where it would fall here.

I'm not convinced this is the right way to go, this is just the first time we've had an extension that is hands down superior to the things that have been packaged in druid before. So spending some time figuring out what should be a core-extension vs what should be packaged in druid default makes some sense.
Core extensions are already packaged in every release, and cache is disabled by default, so since people have to choose the cache impl anyways and modify configs, I don't think it is undue burden.

so by "make default" if this means "use in all the examples and highly recommend it" then that can (and should) be done in either scenario.

I don't see a purpose of keeping local around if caffeine is just straight up better. caffeine can still serve as a reference implementation, even though it delegates to another library it still does a good job of demonstrating how to write a Druid cache implementation.

Retaining local becomes the easiest (preferred) solution for users looking to quickly solve a performance problem. You might later want to enable it by default if you want a good out-of-the-box experience. I'd argue for removal of local because there seems to be no benefit, there is more code to maintain, and it might confuse users.
I have no opinion on whether it should be replaced by Caffeine going into core or all caches becoming extensions. I'd only advise to favor towards a new user's experience where they will make minimal changes to your distribution's configuration.

so there are 3 things and my thoughts are below ...
(1) what should be default cache when user does not specify anything in the properties? Ans: caffeine cache, and everyone agrees on this
(2) when user says local in the properties, what implementation should be used? Ans: caffeine cache impl given that it is a drop-in much better replacement of MapCache.
(3) should we or should we not keep caffeine impl in an extension? Ans: We should keep it in the extension where it also serves as good reference. Have concept of "enforced extensions in loadList" in Druid and always include caffeine extension in the loadList in addtion to user's supplied loadList . I think this model also gives us flexibility to have more things that can be done in extension but still available to user without any extra configuration.

For (1) do you mean "if the user uses the default configs from the distribution"? Since right now, if a user really specifies no cache properties (deleting the ones that come by default in the distribution) then they will get no caching at all. Or did you just mean we should update the default configs to switch from local to caffeine? (PS I also think we should switch the cache from running broker-side, to running historical-side, since it scales better)
For (2) I think it's good to have local really mean caffeine, and delete the existing local impl; that will really help people that have local cache set and don't read release notes to realize they should switch.
For (3) "enforced extensions" seems weird, but I could propose an even weirder (but also maybe cooler?) thing: some code in core Druid that knows that if druid.cache.type=local is set, then it has to load the caffeine extension, and it would just add it to your loadList dynamically. It may look like a hack at first but it is kind of neat: it means that if someone uses memcached (or disables caching entirely) then the caffeine extension won't need to be loaded.

For (1) i meant if they enable caching but don't set cache type , then caffeine cache should be used.
For (3) I was imagining "enforced extensions" a more general thing than used in this context and use same thing whenever we wanted to do things in extensions but still make them available to user without explicitly specifying in loadList. Is there any problem to have caffeine cache extension always being loaded ? it would be same even if we moved it to druid-core .
Dynamic loading is more magical and less general. That said, given that this is all internal to Druid code and is not visible to user, I don't have too strong an opinion here since it can be changed anytime we want with no impact to user.

For (1), I agree with using "caffeine" as the default if caching is enabled on broker/historical but no type has been specified.
For (2), since the configuration is different for "local" vs. "caffeine", I think we should just drop the "local" type completely instead of having a transition period where "local" means the same thing as "caffeine" (since the user would have to update to a different configuration format anyway if we switched the implementations internally).
For (3) I don't have a strong opinion; having default behavior rely on an extension feels a little weird to me, if something will always be loaded I feel like it should be in core, but as others have pointed out it could be useful as a reference.

So in terms of a sequence of steps I'm thinking:

Update all docs and examples to use "caffeine" as default instead of "local", strongly indicate in the docs that "local" is totally inferior to Caffeine and will be deprecated->removed.
Decide after that whether to keep the cache implementations in core or as extensions
Remove "local" implementation completely in a later release

For 0.10.1 release, since it looks like it might take some time to reach consensus on all aspects of this issue, should we just update the docs/examples to use Caffeine as default and recommend that users switch from "local"?

Huzzah!


Remove vestigal conbench integration

Which issue does this PR close?
Part of https://github.com/apache/arrow-datafusion/issues/5504
Rationale for this change
The arrow monorepo https://github.com/apache/arrow has a nice automated system called conbench that tracks performance. At some point it was partially integrated into DataFusion as part of https://github.com/apache/arrow-datafusion/pull/1791 but that work was not completed
Now that @gruuya  and @Dandandan  are working on an alternate strategy (e.g.  https://github.com/apache/arrow-datafusion/pull/9461) we can just get rid of the old vestigal code
What changes are included in this PR?
Remove conbench directory

Are these changes tested?
By CI

Are there any user-facing changes?
No, this is a developer only change

While you're at it do you mind removing the two ./bench.sh run tpch_mem10 lines in the Benchmarks workflow (in relation to #9800 (comment))?

https://github.com/apache/arrow-datafusion/pull/9856

Thanks @alamb


The hint for step 11 of tutorial "Time Flies" is incorrect in Chinese

Describe the bug
The hint for step 11 of tutorial "Time Flies" is incorrect in Chinese
Steps to reproduce the behavior
1.Navigate to https://arcade.makecode.com/beta#
2.Change language to Chinese
3.教程----->Time Flies
4.Click step 11
Expect behavior
It should be like this:

Actual behavior
The hint for step 11 of tutorial "Time Flies" is incorrect in Chinese. This step need us to drag game over . But the hint is game over.

Additional context
1.OS: Windows(rs6)
2.arcade version: 1.5.27
3.Microsoft MakeCode version: 7.1.4

I can reproduce this

English is fine.

@jwunderl - When I plug both English and Chinese block strings in for these with Playground I can make them work OK. Not sure why the Chinese game.over() block isn't displaying the toggle button with the Crowdin string.

//% color="#AA278D" weight=100
namespace hello {
    /**
     * Finish the game and display the score
     */
    //% group="Gameplay"
    //% blockId=gameOverA block="game over %win=toggleWinLose || with %effect effect"
    //% weight=80 help=game/over
    export function overA(win: boolean = false, effect?: effects.BackgroundEffect) {
    }

    /**
     * Finish the game and display the score
     */
    //% group="Gameplay"
    //% blockId=gameOverB block="游戏结束 %win=toggleWinLose || 附上 %effect 效果"
    //% weight=79 help=game/over
    export function overB(win: boolean = false, effect?: effects.BackgroundEffect) {
    }
}

The downloaded translation is this: "game.over|block":"游戏结束 %win=toggleWinLose || 附上 %effect 效果". This matches the Chinese block string I used in Playground, but...
The game.over() block in the game namespace category:

Unassigning as this appears to not be a translation bug. This is failing somewhere in the render since the block string is correct - "game.over|block":"游戏结束 %win=toggleWinLose || 附上 %effect 效果". Of note, (when expanded to force the toggle button to show) is that the zh-cn string for "LOSE" will overflow the area of the toggle button.

The block is behaving as if there are || before the %win=toggleWinLose and not as the received block string.


Limit cipher suites used for controller https

Read the details in the recent similar PR dedicated for Kafka SSL https://github.com/apache/incubator-openwhisk/pull/3604
Description

Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[x] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[ ] Tests
[x] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[x] Bug fix (generally a non-breaking change which closes an issue).
[ ] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[x] I signed an Apache CLA.
[x] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

PG3 2297 is on its way

Codecov Report

Merging #3706 into master will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3706      +/-   ##
==========================================
+ Coverage   75.01%   75.14%   +0.13%
==========================================
  Files         126      126
  Lines        6023     6023
  Branches      385      385
==========================================
+ Hits         4518     4526       +8
+ Misses       1505     1497       -8

Impacted Files
Coverage Δ

...whisk/connector/kafka/KafkaProducerConnector.scala
80.55% <0%> (+22.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b392330...487d92b. Read the comment docs.

Playground1/2958 is green


Member deafened is removed in the latest version of Store Member Info

Member deafened is removed in the latest version of Store Member Info

Shit. I'll look into it

This is intentional, it was moved to use check if member mod as it was already in there.

Ok, just wish it had
Store in:
Temp Variable
option.


⚠ Jenkins Plugins Artifactory has degraded performance

In e73f25c, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1193 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 6deb02e after 22 minutes.


Provide breadcrumbs of prev visited tickets

User Story
As a Sia user, I want to be able to navigate to previously viewed tickets.
Given I am within Sia on an incident ticket page
And I navigate to several other incident ticket pages
When I click on the hamburger dropdown menu
Then I should see a list of incidents
And that list should have all recently visited incidents
And that list should not have the current incident.
Caveats
As implemented there is no ceiling on the number of incidents displayed within the menu and they are not ordered. Before merging you should verify that this behavior is correct, or adjust the behavior to limit the number of incidents displayed and sort them reverse chronologically by recency of visit.

Codecov Report

Merging #75 into master will decrease coverage by 0.16%.
The diff coverage is 38.46%.

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   50.32%   50.15%   -0.17%
==========================================
  Files          88       88
  Lines        1242     1252      +10
==========================================
+ Hits          625      628       +3
- Misses        617      624       +7

Impacted Files
Coverage Δ

src/components/Incident/Ticket.js
0% <0%> (ø)
:arrow_up:

src/components/TopNav/NavMenu.js
54.54% <50%> (-20.46%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e395114...ee53ab8. Read the comment docs.

Coverage decreased (-0.2%) to 46.954% when pulling ee53ab83805db32eddb66d3990f7d443b2951e9f on strand:add-recent-tickets-to-menu into e395114b5f5123d488649e72c4c07ac6547aec7d on Azure:master.


Refactor coinstac-server-core

Problem: coinstac-server-core is a mess. Also, #100.
Solution: Refactor into a class. Add the getSyncedDatabase utility to computation database fetch to ensure the database is synced before making a response.
Testing: npm test in packages/coinstac-server-core/

aaeea93f2258c46e51f21782e02120aa6c82e46e added an integration test to ensure duplicate comp docs aren’t synced. Going ahead and merging.


Added Water Button

Fixes Issue #1472
Added a amazing button called Water Button with a Impressive UI.
Video -
Screencast from 21-06-23 07:32:54 PM IST.webm

[x] You've linked this PR to the correct issue.
[x] You have checked that the code is working correctly.
[x] You ⭐ the repository!

It is ready to MERGE 👍🏻

@Spyware007 ,
Hello I think you forget to review this.

@Spyware007 hi sir


revise concurrency control in kernel/userspace.c

The concurrency control in kernel/userspace.c used to be implemented completely in terms of irq_lock()/irq_unlock(), and ports poorly to SMP-safe spinlocks.
The current port to spinlocks will not really work well on a real SMP system, the locks are not used consistently and some are "protecting" code and not data. In addition, we would like in some cases to use k_mutex for protecting things like the dynamic object lists, which would reduce the amount of interrupt suppression going on.

SMP is being around for while and it seems to be working fine. If a related problem appears I re-open it.


Added support for ES 5

Hello,
this is an upgrade of dependencies and configuration to allow ES 5.
Works well with ES 5.4 installed on my computer, but it breaks the compatibility with ES 1.7.
Mickaël

Hey Michael! Cool thanks! I'll try this at home :)


Add Needed: replication label

This was brought up in https://github.com/rtfd/readthedocs.org/issues/2775, and will be useful to add along with the bug label.
Once this has been merged, we can create the label accordingly.
Note: I mistakenly opened this PR automatically from my CLI with old text. I have since edited it. Sorry about that.

Makes sense. There are probably a number of cases I've not responded to a bug because I didn't have time to replicate the issue.
I can push this out to all of our repos, I have this scripted. I'll leave this open until I've completed the push out.

Poke

LGTM!


Use CNCF's FOSSA tooling

[x] https://github.com/openfga/openfga
[x] https://github.com/openfga/api
[x] https://github.com/openfga/openfga.dev
[ ] https://github.com/openfga/sdk-generator
[ ] https://github.com/openfga/js-sdk
[ ] https://github.com/openfga/go-sdk
[x] https://github.com/openfga/dotnet-sdk
[ ] https://github.com/openfga/python-sdk
[ ] https://github.com/openfga/helm-charts

@aaguiarz was going to close this as done, but before we do so, I would like us to do a last pass across the repos to make sure it is running everywhere.
Last week, it seemed not to be running on a few repos, but I'm not sure of that was a fluke or a misconfiguration.

Checking the last PR to be merged openfga/openfga it seems not to have run 🤔
https://github.com/openfga/openfga/pull/652

Confirmed working + example PRs.
It has been set as required for merging to main on all the repos where it has been confirmed working.
.NET SDK / https://github.com/openfga/dotnet-sdk/pull/14

openfga.dev / https://github.com/openfga/openfga.dev/pull/411

openfga / See https://github.com/openfga/openfga/pull/677

api / https://github.com/openfga/api/pull/71

syntax-transformer / https://github.com/openfga/syntax-transformer/pull/128

sdk-generator / https://github.com/openfga/sdk-generator/pull/103


⚠ Bofrost.at has degraded performance

In 8624643, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 842 ms

Resolved: Bofrost.at performance has improved in 9ce1e4d.


Draw tab bezel differently if the tab is disabled

Tabs which cannot be selected currently look like any non-active tab. I'd expect these to be greyed-out or something else.
Maybe an OptionSet for drawing states makes sense to group the current isSelected and the new isEnabled.

I've added a NSBeep by default when trying to select an unselected tab, and I've also added a new entry in Theme for that. Hence, a new "TabSelectionState" enum etc etc...


jffi Reporting CVE-2017-1000376

Hi team,
When the latest jffi 1.3.11 is being security scanned, it's reporting CVE-2017-1000376, which due to dependency on libjffi-1.2.so, instead of 3.2.1 or above.

Does jffi really affected by CVE-2017-1000376?
Thanks
Denny

It's possible but I am pretty sure I have update the FFI part of the library many times since 2017. The version number of jffi is unrelated to the version of FFI it includes.
I'm on mobile now but you could look into the jni dir and figure out which version of FFI we ship.

thanks @headius
yes, I think that's the possible reason as our tool take libjffi.so as libffi.so.


New integration tests to test use of the darling/php-reflection-utilities library.

Defined the following new integration test:
tests/integration/libraries/PHPReflectionUtilities/ReflectionTests.php

This file is meant to test that the darling/php-reflection-utilities
library's use by roady.

Related to resolving issue #418


barcode scanner

an issue has been detected i created a sidedrawer template  by using
tns create my-project-name --template nativescript-angular-drawer-template
and i added a simple scan button in home page and added bar code scanner plugin all worked fine
on clicking scan button for barcodescanner it goes to camera after scanning qr code it is coming to its same page that is where i have kept simple scan button. In the same page i have kept label

it is not fetching the data to label but while creating simple app it works fine in drawer template only its not working how to get rid of it

Hi @radhakrishnan0404,
First of all thank you for your interest in NativeScript,
Could you provide some more info about the problem you are facing? it would help if you could provide the specific error, which is thrown and sample project, which could be debugged locally.
Bear in mind that the above-mentioned template is not officially supported by the NativeScript team and if there is an issue related to it, you could report them to its repository.


Add support for Mentor Questa simulator, fix seed and other warnings

We noticed that the seed was not working for Xcelium so we fixed that
We got new compile and simulation warnings when we ran on Questa so we fixed those
We are unable to test these changes on VCS but we made sure that Xcelium still works
Please see individual commit messages for details of the changes made

We would like to mention here that we have observed Mentor's Questa runs 2x faster than Cadence Xcelium in our environment when using ./run -test all option which makes a case for us to go with the Mentor flow for now. We don't have VCS available for comparing.
In wall clock time we see Mentor takes 22 minutes vs 51 mins on Cadence.