Terminal suggest: Don't do any filtering of builtins/globals on the extension side

Looks like filtering it happening here: https://github.com/microsoft/vscode/blob/c99c6e2e9262c37b32d887a719e7a987fdea75ea/extensions/terminal-suggest/src/terminalSuggestMain.ts#L312-L319
This filtering should be done exclusively on the renderer size so we can backspace without needing to hide the widget, as well as properly fuzzy matching items.

The condition that I think firstCommand is doing should also be pulled to the top so it's only checked once.

The condition that I think firstCommand is doing should also be pulled to the top so it's only checked once.

Yes, that's already happening https://github.com/microsoft/vscode/blob/e3d033cf31ffba88c2185b1f79f6e57caea39fa3/extensions/terminal-suggest/src/terminalSuggestMain.ts#L250


Adapter stuck in 'Interface bussy during ...' loop.

Adapter gets stuck in ‚Interface busy during …’ loop.
Will be fixed in next release.

closed with release v0.3.0


feat: add collapsible component

Description
Adds a collapsible component.
Design - https://www.figma.com/file/30Q23cmfsjB96flrrh26vT/Widget-discoverability?type=design&node-id=264-10377&mode=design&t=Y69TWwEBPHrK1fhB-0
Fixes https://github.com/appsmithorg/appsmith/issues/24948

every PR in the design-system repository should have a corresponding PR in the appsmith repository to ensure that changes
here don't break existing flows. Link the corresponding PR here to trigger dpulls and prevent accidental merging.
If relevant, link the enterprise PR here as well.

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manual on storybook

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

@dhruvikn to test this you can use<EMAIL_ADDRESS>Once you've addressed the comments I'll create another alpha for you, please DM me on slack to make it happen.

@dhruvikn can you please link the design files for this component in the PR description?

@dhruvikn

Colour of the collapsible icon is incorrect
Size of the title text is deviating from design. Expected: 14 px, Current: 16 px
Colour of the title text is incorrect: Expected: #4C5664, current: #202939
Functionality of the component when isOpen is toggled, isn't seen. Attached Loom.

Design File: zpl://components?pid=63f7601064ab77243cf1eca1&coids=64b69a0b126402539ca29b43

@laveena-en - the callouts have been resolved. Please take a look.
Moreover, I want to elaborate upon point 2 of your comment -

Size of the title text is deviating from the design. Expected: 14 px, Current: 16 px

The CollapsibleHeader component is responsible for the collapsible header. This component accepts any children wrapped around it and renders them. So the devs can put anything, such as icons, text (headings, body, actions), buttons, etc in the header.
Therefore, the text size was 16px in the last testing because it was the Text component from ADSv2 of kind=heading-s. When the text component is of this kind, according to ADSv2 designs, the font size of the rendered text should be 16px.
Now, in my latest commit, I have simply fixed this callout by changing it to kind=body-m. This will result in the text having a font size of 14px.
Just thought my above brief would be helpful in understanding the abilities of the collapsible component.

@tanvibhakta / @albinAppsmith - can you please trigger an alpha release? I will then update my main PR with the new changes.

@dhruvikn
<EMAIL_ADDRESS>

@dhruvikn classname isn’t getting applied to the component. Can you please check?

@laveena-en - That's because we have not set up passing the class names in the storybook. This is working fine in the component, we just haven't configured to story to modify this. Should not be an issue. Let's proceed please, if we can.

@laveena-en - have made the change. Please take a look once the deployment is ready.

I'm not sure @laveena-en. Are our other components keyboard accessible? @albinAppsmith @tanvibhakta

Checked a couple of components and some of them do seem to be keyboard accessible. Menu for example @dhruvikn

@laveena-en, I think that's because we are using Radix's menu component there.
I understand we should not take accessibility lightly, but is it a hard no-go at this moment for us? What do you folks think @albinAppsmith @tanvibhakta?

There's a lot that goes into making a component accessible and unfortunately that hasn't yet been a focus for us here. Since we're thinking about it, @laveena-en and @dhruvikn feel free to leave a TODO with what your keyboard a11y expectations are (should the collapsible open on pressing enter or on pressing space? Both?) but otherwise we can go ahead with merging this in for now.

@dhruvikn Have all the tests passed in cypress on appsmith with you using the latest alpha? I couldn't find it.

@dhruvikn Have all the tests passed in cypress on appsmith with you using the latest alpha? I couldn't find it.

Running them now. Will update.

All tests have passed on the main PR. Let's merge? @tanvibhakta @albinAppsmith

tada! 🎉

I'll create a new release by EOD

Yay. 🎉
Will you create a minor release? And if possible can create that a little earlier so that I can plug that in my main PR and close it today?

Yes, I'll be creating a minor release. ETA 4pm is okay?

Works. Thank you!


It's a exciting node!When will it support Comfyui?

It's a exciting node!When will it support Comfyui?

Thank you for your interest! We don't have this plan recently, sorry for that.


python312Packages.censys: 2.2.15 -> 2.2.16

Diff: https://github.com/censys/censys-python/compare/refs/tags/v2.2.15...v2.2.16
Changelog: https://github.com/censys/censys-python/releases/tag/v2.2.16

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 351283

x86_64-linux

:white_check_mark: 6 packages built:

python311Packages.censys
python311Packages.censys.dist
python312Packages.censys
python312Packages.censys.dist
theharvester
theharvester.dist


Add space around navigation links

Bottom navigation was too close to translation links due to inline elements not respecting padding. Changing display property of navigation links to block solves the issue.

Thanks


Memory leak in circuit

I'm chasing a memory leak in examples/circuit as part of trying to diagnose https://github.com/StanfordLegion/legion/issues/711. This may or may not be the same as what we see there, but debugging this in circuit has the advantage of taking Regent out of the picture.
For what it's worth, I checked this in examples/realm_stencil and did not see any leak there; memory usage was 100% flat. This suggests an issue either in Legion or in the way that Legion uses Realm.
The leak I'm seeing seems to be on the order of a couple MB per minute. I'm intentionally running small tasks to cause as much churn as possible.
See sample memory usage here: out.txt
As best I can tell, this memory usage will continue going up no matter how long I keep the run going. For a sufficiently long run, this might become a problem for overall memory usage.
Example command line: ./circuit -ll:cpu 4 -p 20 -l 100000 | tee out.log
Here's the diff I'm using to track memory usage.
diff --git a/examples/circuit/circuit.cc b/examples/circuit/circuit.cc
index d267319..3014f0a 100644
--- a/examples/circuit/circuit.cc
+++ b/examples/circuit/circuit.cc
@@ -26,6 +26,9 @@
 #include "circuit_mapper.h"
 #include "legion.h"

+#include <sys/time.h>
+#include <sys/resource.h>
+
 Logger log_circuit("circuit");

 // Utility functions (forward declarations)
@@ -138,6 +141,13 @@ void top_level_task(const Task *task,
   bool simulation_success = true;
   for (int i = 0; i < num_loops; i++)
   {
+    if (i % 1000 == 0) {
+      runtime->issue_execution_fence(ctx).get_void_result();
+      struct rusage usage;
+      if (getrusage(RUSAGE_SELF, &usage) != 0) assert(false);
+      printf("memory usage at timestep %6d: %.1f MB\n", i, usage.ru_maxrss / 1024.0);
+      fflush(stdout);
+    }
     TaskHelper::dispatch_task<CalcNewCurrentsTask>(cnc_launcher, ctx, runtime,
                                                    perform_checks, simulation_success);
     TaskHelper::dispatch_task<DistributeChargeTask>(dsc_launcher, ctx, runtime,

This could be the same memory leak that currently prevents Soleil-x from running to completion.
On Mar 27, 2020, at 2:26 PM, Elliott Slaughter <notifications<EMAIL_ADDRESS>wrote:
I'm chasing a memory leak in examples/circuit as part of trying to diagnose #711https://github.com/StanfordLegion/legion/issues/711. This may or may not be the same as what we see there, but debugging this in circuit has the advantage of taking Regent out of the picture.
For what it's worth, I checked this in examples/realm_stencil and did not see any leak there; memory usage was 100% flat. This suggests an issue either in Legion or in the way that Legion uses Realm.
The leak I'm seeing seems to be on the order of a couple MB per minute. I'm intentionally running small tasks to cause as much churn as possible.
See sample memory usage here: out.txthttps://github.com/StanfordLegion/legion/files/4396009/out.txt
As best I can tell, this memory usage will continue going up no matter how long I keep the run going. For a sufficiently long run, this might become a problem for overall memory usage.
Here's the diff I'm using to track memory usage.
diff --git a/examples/circuit/circuit.cchttp://circuit.cc b/examples/circuit/circuit.cchttp://circuit.cc
index d267319..3014f0a 100644
--- a/examples/circuit/circuit.cchttp://circuit.cc
+++ b/examples/circuit/circuit.cchttp://circuit.cc
@@ -26,6 +26,9 @@
#include "circuit_mapper.h"
#include "legion.h"
+#include <sys/time.h>
+#include <sys/resource.h>
+
Logger log_circuit("circuit");
// Utility functions (forward declarations)
@@ -138,6 +141,13 @@ void top_level_task(const Task *task,
bool simulation_success = true;
for (int i = 0; i < num_loops; i++)
{

if (i % 1000 == 0) {

 runtime->issue_execution_fence(ctx).get_void_result();

 struct rusage usage;

 if (getrusage(RUSAGE_SELF, &usage) != 0) assert(false);

 printf("memory usage at timestep %6d: %.1f MB\n", i, usage.ru_maxrss / 1024.0);

 fflush(stdout);

}
TaskHelper::dispatch_task(cnc_launcher, ctx, runtime,
perform_checks, simulation_success);
TaskHelper::dispatch_task(dsc_launcher, ctx, runtime,

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/StanfordLegion/legion/issues/790, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAORXXR6OFFGATDIUVG6UXLRJUKYFANCNFSM4LVJSWFQ.

@streichler I think this needs to be a blocker for the release

I'm not sure if I can reproduce this, it's growing, but nowhere near as fast as you say it should:
mebauer@sapling:~/legion/examples/circuit$ ./circuit -ll:cpu 4 -p 20 -l 100000
[0 - 7fbff02b6700] {3}{circuit}: circuit settings: loops=100000 pieces=20 nodes/piece=2 wires/piece=4 pct_in_piece=95 seed=12345
[0 - 7fbff02b6700] {3}{circuit}: Initializing circuit simulation...
[0 - 7fbff02b6700] {3}{circuit}: Finished initializing simulation...
Starting main simulation loop
memory usage at timestep      0: 51.4 MB
memory usage at timestep   1000: 63.4 MB
memory usage at timestep   2000: 63.6 MB
memory usage at timestep   3000: 63.7 MB
memory usage at timestep   4000: 63.7 MB
memory usage at timestep   5000: 63.8 MB
memory usage at timestep   6000: 63.8 MB
memory usage at timestep   7000: 63.9 MB
memory usage at timestep   8000: 63.9 MB
memory usage at timestep   9000: 63.9 MB
memory usage at timestep  10000: 63.9 MB
memory usage at timestep  11000: 63.9 MB
memory usage at timestep  12000: 64.1 MB
memory usage at timestep  13000: 64.1 MB
memory usage at timestep  14000: 64.1 MB
memory usage at timestep  15000: 64.7 MB
memory usage at timestep  16000: 64.7 MB
memory usage at timestep  17000: 64.7 MB
memory usage at timestep  18000: 64.7 MB
memory usage at timestep  19000: 64.7 MB
memory usage at timestep  20000: 64.7 MB
memory usage at timestep  21000: 64.7 MB
memory usage at timestep  22000: 64.9 MB
memory usage at timestep  23000: 64.9 MB
memory usage at timestep  24000: 64.9 MB
memory usage at timestep  25000: 64.9 MB
memory usage at timestep  26000: 64.9 MB
memory usage at timestep  27000: 65.1 MB
memory usage at timestep  28000: 65.1 MB
memory usage at timestep  29000: 65.2 MB
memory usage at timestep  30000: 65.2 MB
memory usage at timestep  31000: 65.2 MB
memory usage at timestep  32000: 65.2 MB
memory usage at timestep  33000: 65.2 MB
memory usage at timestep  34000: 65.2 MB
memory usage at timestep  35000: 65.5 MB
memory usage at timestep  36000: 65.5 MB
memory usage at timestep  37000: 65.5 MB
memory usage at timestep  38000: 65.5 MB
memory usage at timestep  39000: 65.5 MB
memory usage at timestep  40000: 65.5 MB
memory usage at timestep  41000: 65.5 MB
memory usage at timestep  42000: 66.2 MB
memory usage at timestep  43000: 66.4 MB
memory usage at timestep  44000: 66.4 MB
memory usage at timestep  45000: 66.4 MB
memory usage at timestep  46000: 66.4 MB
memory usage at timestep  47000: 66.4 MB
memory usage at timestep  48000: 66.4 MB
memory usage at timestep  49000: 66.5 MB

certainly no leaks in Legion from TRACE_ALLOCATION:
[0 - 7f9ddf000700] {2}{allocation}: Future on 0: total=41 total_bytes=28864 diff=8 diff_bytes=5632
[0 - 7f9ddf000700] {2}{allocation}: Future Map on 0: total=982 total_bytes=667760 diff=768 diff_bytes=522240
[0 - 7f9ddf000700] {2}{allocation}: Physical Region on 0: total=20 total_bytes=5600 diff=-30 diff_bytes=-8400
[0 - 7f9ddf000700] {2}{allocation}: Executing Children on 0: total=981 total_bytes=47088 diff=767 diff_bytes=36816
[0 - 7f9ddf000700] {2}{allocation}: Logical Field States on 0: total=21 total_bytes=3696 diff=1 diff_bytes=176
[0 - 7f9ddf000700] {2}{allocation}: Current Logical Users on 0: total=1714 total_bytes=246816 diff=122 diff_bytes=17568
[0 - 7f9ddf000700] {2}{allocation}: Previous Logical Users on 0: total=6 total_bytes=864 diff=-1 diff_bytes=-144
[0 - 7f9ddf000700] {2}{allocation}: Memory Manager Instances on 0: total=75 total_bytes=9000 diff=15 diff_bytes=1800
[0 - 7f9ddf000700] {2}{allocation}: Runtime Distributed IDs on 0: total=134 total_bytes=1072 diff=-832 diff_bytes=-6656
[0 - 7f9ddf000700] {2}{allocation}: Distributed Collectables on 0: total=1519 total_bytes=72912 diff=806 diff_bytes=38688
[0 - 7f9ddf000700] {2}{allocation}: Task Reservations on 0: total=504 total_bytes=4032 diff=-360 diff_bytes=-2880
[0 - 7f9ddf000700] {2}{allocation}: Task Barriers on 0: total=280 total_bytes=4032 diff=-200 diff_bytes=-2880
[0 - 7f9ddf000700] {2}{allocation}:
[0 - 7f9ddf000700] {2}{allocation}: Future on 0: total=22 total_bytes=15488 diff=-19 diff_bytes=-13376
[0 - 7f9ddf000700] {2}{allocation}: Future Map on 0: total=981 total_bytes=667080 diff=-1 diff_bytes=-680
[0 - 7f9ddf000700] {2}{allocation}: Executing Children on 0: total=980 total_bytes=47040 diff=-1 diff_bytes=-48
[0 - 7f9ddf000700] {2}{allocation}: Logical Field States on 0: total=22 total_bytes=3872 diff=1 diff_bytes=176
[0 - 7f9ddf000700] {2}{allocation}: Current Logical Users on 0: total=1715 total_bytes=246960 diff=1 diff_bytes=144
[0 - 7f9ddf000700] {2}{allocation}: Memory Manager Instances on 0: total=60 total_bytes=7200 diff=-15 diff_bytes=-1800
[0 - 7f9ddf000700] {2}{allocation}: Runtime Distributed IDs on 0: total=262 total_bytes=2096 diff=128 diff_bytes=1024
[0 - 7f9ddf000700] {2}{allocation}: Distributed Collectables on 0: total=1469 total_bytes=70512 diff=-50 diff_bytes=-2400
[0 - 7f9ddf000700] {2}{allocation}: Task Reservations on 0: total=144 total_bytes=1152 diff=-360 diff_bytes=-2880
[0 - 7f9ddf000700] {2}{allocation}: Task Barriers on 0: total=80 total_bytes=1152 diff=-200 diff_bytes=-2880
[0 - 7f9ddf000700] {2}{allocation}:
[0 - 7f9ddf000700] {2}{allocation}: Future on 0: total=32 total_bytes=22528 diff=10 diff_bytes=7040
[0 - 7f9ddf000700] {2}{allocation}: Future Map on 0: total=982 total_bytes=667760 diff=1 diff_bytes=680
[0 - 7f9ddf000700] {2}{allocation}: Physical Region on 0: total=50 total_bytes=14000 diff=30 diff_bytes=8400
[0 - 7f9ddf000700] {2}{allocation}: Executing Children on 0: total=981 total_bytes=47088 diff=1 diff_bytes=48
[0 - 7f9ddf000700] {2}{allocation}: Logical Field States on 0: total=20 total_bytes=3520 diff=-2 diff_bytes=-352
[0 - 7f9ddf000700] {2}{allocation}: Current Logical Users on 0: total=1712 total_bytes=246528 diff=-3 diff_bytes=-432
[0 - 7f9ddf000700] {2}{allocation}: Previous Logical Users on 0: total=7 total_bytes=1008 diff=1 diff_bytes=144
[0 - 7f9ddf000700] {2}{allocation}: Runtime Distributed IDs on 0: total=198 total_bytes=1584 diff=-64 diff_bytes=-512
[0 - 7f9ddf000700] {2}{allocation}: Distributed Collectables on 0: total=1480 total_bytes=71040 diff=11 diff_bytes=528
[0 - 7f9ddf000700] {2}{allocation}: Task Reservations on 0: total=864 total_bytes=6912 diff=720 diff_bytes=5760
[0 - 7f9ddf000700] {2}{allocation}: Task Barriers on 0: total=480 total_bytes=6912 diff=400 diff_bytes=5760
[0 - 7f9ddf000700] {2}{allocation}:
[0 - 7f9ddf000700] {2}{allocation}: Future on 0: total=41 total_bytes=28864 diff=9 diff_bytes=6336
[0 - 7f9ddf000700] {2}{allocation}: Physical Region on 0: total=20 total_bytes=5600 diff=-30 diff_bytes=-8400
[0 - 7f9ddf000700] {2}{allocation}: Logical Field States on 0: total=21 total_bytes=3696 diff=1 diff_bytes=176
[0 - 7f9ddf000700] {2}{allocation}: Current Logical Users on 0: total=1714 total_bytes=246816 diff=2 diff_bytes=288
[0 - 7f9ddf000700] {2}{allocation}: Previous Logical Users on 0: total=6 total_bytes=864 diff=-1 diff_bytes=-144
[0 - 7f9ddf000700] {2}{allocation}: Memory Manager Instances on 0: total=75 total_bytes=9000 diff=15 diff_bytes=1800
[0 - 7f9ddf000700] {2}{allocation}: Runtime Distributed IDs on 0: total=134 total_bytes=1072 diff=-64 diff_bytes=-512
[0 - 7f9ddf000700] {2}{allocation}: Distributed Collectables on 0: total=1519 total_bytes=72912 diff=39 diff_bytes=1872
[0 - 7f9ddf000700] {2}{allocation}: Task Reservations on 0: total=504 total_bytes=4032 diff=-360 diff_bytes=-2880
[0 - 7f9ddf000700] {2}{allocation}: Task Barriers on 0: total=280 total_bytes=4032 diff=-200 diff_bytes=-2880
[0 - 7f9ddf000700] {2}{allocation}:

As I told @lightsighter privately, his trace looks similar to what I posted here. I may not have computed the rate correctly, I was just doing it in my head. At any rate, it if you see my trace, it seems to keep growing and I do think with a sufficiently long-running application it could be an issue, so it seems worth fixing. (Whether it should block the release or not I'll leave up to the rest of you, I personally have no opinion on this.)

@elliottslaughter can you run your test for 10x as long?  I did a run that also showed about 4MB of gain over 100k iterations, but it was nearly all front-loaded, with very little change for the bulk of the run, which looks more to me like convergence to a memory high water mark.

Ok, here's the new log: out.txt
Here is the same in graph form: memory usage graph
The run leaked 46.6 MB (measuring from timestep 1000 to the end) in 86 minutes, a rate of 0.54 MB/minute. Though memory does grow faster in the beginning, it seems to be basically constant throughout the run.

Yes, the growth from 400k to 1M does look pretty linear.  That said, a leakage rate of 0.54MB/min is only 800MB for a 24 hour run, so this doesn't seem like it should be a showstopper.  (And it's probably not the same thing that's OOM'ing the soleil runs.)

I did some runs with valgrind with increasing numbers of iterations and they all show that the stuff we're leaking is invariant with the number of iterations. What that means is that we're not really leaking anything, but have a linearly growing data structure that grows very slowly. The last time we had one of these it was the CompletionQueue. Are we sure that we fixed it?

I've been poking at this with the gperftools heap profiler and it's still too slow to do really long runs, but two things I'm seeing so far:

I don't see any steady leakage from snapshot to snapshot.  It looks more like the dynamic heap churn gets bigger over time.
When disabling the heap profiler but still running with tcmalloc, the heap growth rate seems much smoother - between 0 and 0.3MB per 1k steps rather than the chunkier version @elliottslaughter and I have both seen in the long runs with the default malloc.

Ok, I think I've found/fixed the principal component of the memory growth.  This application causes Legion to use some very wide event merges (nearly 1000 untriggered events), and Realm was holding onto some dynamic allocations in case they could be reused.  (Given long enough, they would have been, but that'd be a real long time.)
Behavior after commit c2e3401:
$ ./circuit -ll:cpu 4 -p 20 -l 500000
[0 - 7fde34294700] {3}{circuit}: circuit settings: loops=500000 pieces=20 nodes/piece=2 wires/piece=4 pct_in_piece=95 seed=12345
[0 - 7fde34294700] {3}{circuit}: Initializing circuit simulation...
[0 - 7fde34294700] {3}{circuit}: Finished initializing simulation...
Starting main simulation loop
[0 - 7fde34294700] {3}{circuit}: memory usage at timestep 0: 50.0312 MB
[0 - 7fde34294700] {3}{circuit}: memory usage at timestep 1000: 65.4141 MB
[0 - 7fde34294700] {3}{circuit}: memory usage at timestep 6000: 66.4453 MB
[0 - 7fde34294700] {3}{circuit}: memory usage at timestep 7000: 69.2812 MB
[0 - 7fde34294700] {3}{circuit}: memory usage at timestep 15000: 69.5391 MB
[0 - 7fde34294700] {3}{circuit}: memory usage at timestep 39000: 71.6016 MB
[0 - 7fde34294700] {3}{circuit}: memory usage at timestep 81000: 71.8594 MB
[0 - 7fde34294700] {3}{circuit}: memory usage at timestep 107000: 72.1172 MB
[0 - 7fde34294700] {3}{circuit}: memory usage at timestep 359000: 72.375 MB
[0 - 7fde34294700] {3}{circuit}: memory usage at timestep 375000: 72.8906 MB
SUCCESS!

@elliottslaughter can you give this a try and confirm you see the benefit as well?

Yes, it seems to be fixed.
Circuit Memory Usage Over Time.pdf


Submit DropTracker for review

The DropTracker is an integration with discord webhooks to send loot automatically to loot leaderboards. Clans can set their own leaderboards up by contacting me.
You can come check ours out if you'd like, just hmu! Here's my reddit thread for more reference:
https://www.reddit.com/r/2007scape/comments/13n0q9w/droptracker_a_discord_addon_bot_for_osrs_clans/
Simply put, the plugin just listens for onLootReceived and onNpcLootReceived events and submits webhooks if the serverId config is in our list of servers.
Sorry for the double pull request. Other one was incorrect.

Don't close your PRs and keep creating new ones, push to the existing PR to resolve issues.

Don't close your PRs and keep creating new ones, push to the existing PR to resolve issues.

Not sure what I've done wrong here; I'm fairly new to Java and even more so to working on GitHub collaboratively; so I apologize for my arrogance.
Looks like something to do with libraries based on the build output?
If you (or anyone) could point me in the right direction I'd appreciate you!

You could use Gson instead since runelite uses it already. i.e.
@Inject
private Gson gson;

then you won't have to deal with adding libraries.

Looked through a few other pull requests and noticed that outbound connections usually mean the plugin requires a warning on install; hopefully I've added that where it belongs.


For Tabs component, the 'active' indicator is initially invisible

Using the tabs, on page load no active tab is indicated. This HTML:

seems to be the indicator for the active tab. But the style is:
element.style {
    left: 0px;
    width: 0px;
}

Once I toggle the other tab, then the underline appears and works as it is supposed to. I.e. clicking back to the initial tab the underline appears, and has this style:
element.style {
    left: 0px;
    width: 160px;
}

I am using @materil-ui/core v4.11.0

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Attached is a giff that illustrates what I have (tried) to indicate above

Please provide a minimal reproducible example.

Hi - I am going to provide an example once I can clearly provide one (this requires some work)

I've had this problem for over a year now. It's inconsistent, sometimes when I use the Tabs component everything works fine. Other times, I see exactly what you see @zachsa

Any solution?


Update FFI Table in wiki

The FFI documentation has been fully updated, you can view the document here.
Here are some links to the source for further information

The source for the interpreters implementation of the standard foreign functions
The source for the compilers runtime, and standard foreign function implementations

PROS C Api, what robomode foreign functions are built off of


[Suggestion] - Add support for PodDisruptionBudget

Suggestion
Support for PodDisruptionBudget for the application pods.
(relevant for the Data Center version)
The use case I have:
When I am upgrading the Kubernetes version, every worker gets upgraded in a rolling upgrade yet the application pods (for example bitbucket) take a few minutes to become ready.
This means that once all workers have been upgraded (which includes node drain and cordon), there are a few minutes of downtime until the first pod becomes ready.
If needed I can work on a PR myself :)
Product
Jira, Confluence, Bitbucket
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@Roia5 https://github.com/atlassian/data-center-helm-charts/pull/636 it'll make it to the next release


Notebook screen cheese

open my-endgame.github-issues
scroll so that "My Issues (verification-steps-needed)" is showing atop, it cell tool bar should be showing uncropped
select "Execute Notebook" (image 1)
🧀 the output of the cell about is too low
🧀 scroll up and see how the output overlays the "Verification" heading

(1) scroll like this

(2)after run, output too close

(3) scroll up, full screen cheese

It does recover when I scroll further but the overall experience is somewhat poor. Even when scrolling quickly you can "feel" that something is wrong

well, the screen cheese is gone but now there is flicker...


[Feature Request] Could you please consider adding Start & End Control Step for IP Adapter?

If IP Adapter is employed in the entire generation process, the overall image is highly impacted.
Would you please adding something like: Starting Control Step & Ending Control Step?
Starting Control Step would be the key to preserve the quality of image generation, and apply the IP Adapter at the last stage.
Without that, we can never generate good results in A1111 webui, something like Osato28 did in his example:
https://github.com/Mikubill/sd-webui-controlnet/issues/2208#issuecomment-1821438246

I'm a bit confused... I remember you said IP Adapter is not actually ControlNet, and dragging a picture to the text prompt will show up the ReVision/IP Adapter section.
Do you mean now I can additionally expand ControlNet and make use of the new ControlNet Start & End? If this is the case, would it be cleaner to put everything about IPAdapter inside ControlNet like A1111, or consistently keep them in ReVision section?

I completely glossed off the IP Adapter part of the post, sorry.
No, IP Adapter is not controlnet. I added the controlnet start/stop parameters. These are unrelated to IPAdapter, which has no such option.


Check the RequiredAttribute's AllowEmptyStrings property

Prerequisites

[x] I have written a descriptive pull-request title
[x] I have verified that there are no overlapping pull-requests open
[x] I have verified that I am following the Nancy code style guidelines
[x] I have provided test coverage for my change (where applicable)

:heart:


Could not pass event PlayerJoinEvent to ServersNPC v4.0

https://mclo.gs/FWNhpR2
Server: PurPur 1.19.3

I join the problem


[firebase_storage]Add missing template type parameter to invokeMethod calls. Bump minimum Flutter version to 1.5.0. Replace invokeMethod with invokeMapMethod wherever necessary.

https://github.com/flutter/flutter/issues/26431

@collinjackson  I had to make more type updates to pass the driver test. Could you take a look again just to make sure?

lgtm!


Remove BestAuthorities struct

It doesn't seem to be used at all.

Could you please merge master again with your fixes for the failing tests?


The ASP.NET Core 2.1 release has made enough changes that stepping through this no longer works.

I am not smart enough to know the fixes.  Would my identifying the failings be an assist or a waste of time?  Or even be perceived as an insult to those that have built these pages.  Or should I post this elsewhere?
chuck

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7a54c97f-ddd4-b041-5e5f-a2df009ace50
Version Independent ID: fa488196-1f98-08ea-adcc-17d9dac86727
Content: Razor Pages with Entity Framework Core in ASP.NET Core - Tutorial 1 of 8
Content Source: aspnetcore/data/ef-rp/intro.md
Service: unspecified
Product: asp.net-core
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Please not what has changed. Be sure to install the latest .Net Core SDK 2.1

Installing that latest SDK (2.1) worked for me. I started the tutorial with .NetCore 2.0, then I got errors at the point of running the scaffolding because my I had a mix of 2.0 and 2.1 packages. Which were resolved by installing 2.1, and replacing AspNetCore with a 2.1.X version

@crbeckman  I'll be starting on this soon, hopefully you can review it when I'm finished.

Hello, Not sure if its just me but "dotnet new webapp -o ContosoUniversity" command is not working.  It's saying that webapp is not a template.  I usually substitute webapp with razor.  Is there a reason why?

@Pangar   webapp requires the 2.1 version of the .NET Core SDK.


Remove request

This wont work on windows since wget isn't a command there.

Um if you squash merged when you updated with HoeenCoder:master, that can cause you to take credit for others work..

ok


Added Ekm detection

List of sites using EKM:
https://www.simplyarganoilshop.com/
https://www.skatebritain.net/
https://brookhousehops.com/
https://www.gazegillorganics.co.uk/
https://www.littlethingstocherish.co.uk/
https://slam69.co.uk/
https://www.pewtergiftware.com/
https://www.gwr-fasteners.co.uk/
https://www.thewilloughbybookclub.co.uk/
https://www.dantaylormodelworks.com/
https://www.rosecottagejewellery.co.uk/
http://richardgoodallgallery.com/
http://lamazetoys.co.uk/
https://shop.hearinglink.org/
https://www.ropeseller.co.uk/
https://shop.leadingedgesafety.co.uk/
https://www.thewhiskyvault.com/
https://www.moseyhome.co.uk/
https://kcwatches.co.uk/

Thanks!


make check failed

I build the matio-1.5.9 which downloaded from sourceforge on unbuntu14.04. When i  run make check,Write Mat version 4 and Write Uncomoressed Mat version 5 failed at writing 2D double/single/int64/uint64 array.

Sorry, I cannot reproduce on Travis CI.

Did you run the tests with MATLAb verification?


Update board thickness

This PR updates the board thickness to 0.062" (1.57mm) in the current card ordering information.

Thanks @ngadiyar93. Can you please update the Altium files as well?

Updated the layer stackup in Altium to be the following:
The core is 0.039" or 1mm
The copper layers are all 1Oz (or 1.4mil / 0.036mm)
The solder mask is 0.01mm
Here is how the stackup looks:

Altium updated w/ proper stack height. approved.

@elsevers this PR closed due to deleting its target branch. Do you still want this content to be merged?

Oops. I did not intend to close this PR.


[Question] How can I specify a field to be String or null using PactDslJsonBody?

As a part of a Pact, I want to specify a field to be String or null, for example.
PactDslJsonBody body = new PactDslJsonBody()
...
.stringType("nickname")
....;
But the Pact verification fails when 'nickname' is null :'( :(
I was using JSON Schema before and it allows me to do it. like this:
{
...
"nickname": [ "string", null ]
...
}
Is there any workaround to achieve this? this is getting problematic for us...
Thanks a lot!

There is currently no way to do this, but there is a specification change that adds support for OR: https://github.com/pact-foundation/pact-specification/tree/version-3#allow-arrays-of-matchers-to-be-defined-against-a-matcher-path
We do have some concern about this feature. Including this in the contract could result in the condition where all the tests use the null value and hence pass, and then an invalid value is used in production.
For related discussions: #311 and #261

Thanks!
It's a shame that it doesn't support that yet. In relation to your concern: I wouldn't be worried about it: if you define all fields on the payload optional,  then a payload with all fields null is correct! In json schema you can specify additional rules like 'at least one of these fields must be not null'.  In my opinion the pact definition 'has' to be very flexible  to define these kind of rules, similar to json schema, otherwise ppl are not going to use it because doesn't suit their requirements.
Thanks for your response!  And I will be happy to contribute on extending the pact definition if it's possible.


Implement algorithm traits on geo scalars as well as geoarrow scalars

That'll lead to a really seamless API, and it'll be future compatible because both geo scalars and arrow scalars implement the same geometry access traits

Started in #138; it's just a bit more copy-pasting to get it working for all the algorithms where the right hand side can be a scalar

Note: this is being switched to favor blanket implementations on geometry traits

I don't want to implement traits on both scalar types because of so much code duplication. Hopefully with blanket implementations on geometry traits it should be less code.


Fixing #1

Fixing issue #1

Well, that's embarrassing :joy: Thanks for looking into this and finding my dumb commits


CI: add pytorch 2.0 cpu/gpu

What does this PR do?
Adds CI for PT 2.0 pre release for CPU and GPU

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @carmocca @akihironitta @borda

Looks like onnx is now a required dependency for the onnx tests.

seems some size leaking:
>       assert cuda_memory < model.start_cuda_memory
E       assert 17039872 < 2048
E        +  where 2048 = BoringModelGPU(\n  (layer): Linear(in_features=32, out_features=2, bias=True)\n).start_cuda_memory


[Question] Mailman with Mailbox

Hi,
Has anybody integrated Mailman with Mailbox (https://github.com/mailboxer/mailboxer)?
Thanks.

What kind of integration is needed?

Has anybody integrated Mailman with Mailbox to receive email from pop3?

But this mailbox gem sends stuff and mailman process incoming emails. So the gems set looks orthogonal to me and can work independent.


Also set secure processing feature for the PolicyRestrictor

We should also set the secure processing feature for the PolicyRestrictor, to prevent various DoS style attacks.

Thanks !


What's the meaning of provided data

Hi @syb7573330 I am trying to visualize the .h5 data, but I found the data had 4 dimensions. Could you tell me what's the meaning of each dimension?
Thanks a lot.

I found the meaning is [depth, height, width, dim].
Thanks.


Core/Thread: fix comparison of of different signedness

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Bram Oosterhuis seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Power Automate visual for Power BI not working after embed in Power App Application

Hi Team,
My power automate for Power BI  is working in my power bi web and desktop. But when I embed in Power App Application its showing triggering message but not working at all. Please help.
Thanks,
Jagan

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: de472a84-f62c-d01c-a8b2-e6ea168a222d
Version Independent ID: da8c0056-7e3d-fc14-c5a4-1bd3bab573de
Content: Create a Power Automate visual for Power BI (preview) - Power BI
Content Source: powerbi-docs/create-reports/power-bi-automate-visual.md
Service: powerbi
Sub-service: pbi-reports-dashboards
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

Hi Team,
Any update on this pls?
Regards,
Jagan

Thanks for your comment, @jaganpt. This issue has been assigned to the doc author for review.

Hi, @jaganpt -- so sorry for the delay! This sounds like a question for the Power Automate team. Here's a link to the Power Automate documentation:
https://learn.microsoft.com/en-us/power-automate/getting-started
I hope they can help!


Why do errors appear in console after cancelling tasks?

ℹ Please fill out this template when filing an issue.
All lines beginning with an ℹ symbol instruct you with what info we expect. You can delete those lines once you've filled in the info.
Per our *CONTRIBUTING guidelines, we use GitHub for
bugs and feature requests, not general support. Other issues should be opened on Stack Overflow with the tag alamofire.
Please remove this line and everything above it before submitting.

[ ] I've read, understood, and done my best to follow the *CONTRIBUTING guidelines.

What did you do?
ℹ Please replace this with what you did.
What did you expect to happen?
ℹ Please replace this with what you expected to happen.
What happened instead?
ℹ Please replace this with of what happened instead.
Alamofire Environment
Alamofire version:
Xcode version:
Swift version:
Platform(s) running Alamofire:
macOS version running Xcode:
Demo Project
ℹ Please link to or upload a project we can download that reproduces the issue.

Cancellation is represented as an error by URLSession and so is printed like other errors in the debug info printed in the Xcode console.


Adds Tapjoy v11

Using version 11 of Tapjoy's SDK seems to work, I show up in real time, whereas I don't using v10 (refs #999)
Here's the debug log:
2016-04-28 10:10:33.987 DoSomething[445:124663] [TJLog level: 4] Connect success with type:0
Apr 28 10:10:34  DoSomething[445] <Notice>: starting profile request using - 3.1-77 with options: 1fc7e
2016-04-28 10:10:34.019 DoSomething[445:124663] Tapjoy connect Succeeded
2016-04-28 10:10:36.179 DoSomething[445:124663] -canOpenURL: failed for URL: "about:blank" - error: "This app is not allowed to query for scheme about"
2016-04-28 10:10:36.188 DoSomething[445:124663] [TJLog level: 4] Events proxy is ready

We heard back from Tapjoy re: SDK 11 vs SDK 10:

It's a matter of preference at this point. When we first launched SDK 11, the advertiser dashboard wasn't fully complete, so there would have been no way for you to set up campaigns. However, things are better now and you can always have our team set up any campaigns you need. I recommend SDK 11 as well because it's up to date with our bug fixes and store requirements as well.

Their explanation for the -canOpenURL: failed for URL: "about:blank"  warning:

I believe it is because we use canOpenURL and in order to use that in iOS 9, you need to whitelist the URL in the LSApplicationQueriesSchemes key of your info.plist. We used to use it for some legacy features, but we never got rid of it in the code.

I'm running this branch locally and see my Simulator in the real time Users, so let's go with SDK 11 to close #995


when create two map from the same db,  throw exception

the code is blow:
DB db = DBMaker.fileDB("D:\test0.db").closeOnJvmShutdown().make();
HTreeMap map = db.hashMap("szl").createOrOpen();
HTreeMap map1 = db.hashMap("szl1").createOrOpen();
map.put("shuzhongling", "luyuhuan");
map.close();
map1.put("shuzhongling1", "luyuhuan1");
the last line will throw exception.   java.lang.IllegalAccessError: Store was closed

map.close() will close underlying database, not just single map


Load Error

While passing jruby -G -S rakeup iam getting the following error

Please give me a solution.

Can you try running gem install bundler first?
Jeremy B. Merrill
Sent from my mobile device
On Mar 2, 2017 9:20 AM, "OrsuSuni"<EMAIL_ADDRESS>wrote:

While passing jruby -G -S rakeup iam getting the following error
[image: capture]
https://cloud.githubusercontent.com/assets/26080134/23510913/638d10a4-ff81-11e6-937a-2fb4ef9732f4.PNG
Please give me a solution.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tabulapdf/tabula/issues/639, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAhdmqr0bInMkyPp9JwrOlQTXYPC5_Qoks5rhtAagaJpZM4MRCv3
.

I have done it and bundler installed successfully...

@OrsuSuni,
If you have both Ruby and JRuby on the same machine, it's possible that the commands gem and bundler default to being executed with Ruby and not JRuby.
Run these commands instead:

jruby -S gem install bundler
jruby -S bundle install.

Let us know how that goes.

Thanks for your response...
I have executed the commands you said to use..

Does it work now, if you visit localhost:9292? I'm seeing what look like successful web requests.

No it doesn't opened any browser and i tried running the same command again but it showed the error message  "No such file or directory".. I am very new to this technology and need to converter Pdf table data into text.. Please help me with this..

It might be easier to try the packaged Windows version if you don't need to modify Tabula: https://github.com/tabulapdf/tabula/releases/tag/v1.1.1
Otherwise, you'll need to install git.


toThrow doesn't seem to capture the error...

I am doing this:
expect(async () => {await doSomething()}).toThrow('myThrownErrorMessage');

but this throws an error in the terminal:
(node:12725) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 575): Error: myThrownErrorMessage

Is this simply a case of node capturing the error before Jest does?

return (async () => {await doSomething()}).rejects.toThrow('myThrownErrorMessage');
https://facebook.github.io/jest/docs/en/tutorial-async.html#rejects
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions. Thank you :)

I'm raising it as a bug because I would expect the toThrow function to handle the thrown error.

What happens if you make the surrounding it async?

Nothing different happens. The only way to get this to work is to do:
const mockError = new Error('someErrorMessage');
try {
    await doSomething();
} catch (e) {
    expect(e).toEqual(mockError);
}

This issue is easier to find than the relevant Stack overflow question: https://stackoverflow.com/questions/50807170/jest-test-fails-when-trying-to-test-an-asynchronous-function-throws
The answer of @SimenB here actually does not work. The way to make it work is to make the lambda in expect async, and put .rejects. before .toThrow
Example production code:
import fetch from "node-fetch";

export async function ConfigLoaderService():Promise<void> {
  try {
    let response = await fetch("/config.json");
  } catch(error) {
    throw new Error("Config can't be loaded: "+ error);
  }
}

example test code:
import { ConfigLoaderService } from "../../src/com.kodekonveyor.frontend/config/ConfigLoaderService";
import { enableFetchMocks } from 'jest-fetch-mock'

enableFetchMocks()

describe("ConfigLoaderService", () => {
  it("throws error if config.json not found", async () => {
    fetchMock.mockAbort()
    expect(async () => {await ConfigLoaderService()}).rejects.toThrow(Error);
  })
});


Spaces in texts in custom config are removed

https://github.com/thomasschwarz96/grav-plugin-simple-cookie/blob/3d0ddcbe40d93779da005059e1739e20d5cb0132/templates/partials/init-simple-cookie.html.twig#L18
"content": {
"message":  "This website uses cookies to ensure you get the best experience on our website." [...]
becomes
Thiswebsiteusescookiestoensureyougetthebestexperienceonourwebsite

I committed a bugfix.
Should be available soon on grav.


Suppress warnings about breaking changes to Newtonsoft.Json dependency in SignalR

Resolves https://github.com/aspnet/AspNetCore-Internal/issues/1940
This adds support for listing a reference removal as an allowable breaking change.

Hard to tell but the build failures in attempt 1 are likely flakiness. I started attempt 2.

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=156855&view=logs

This comment was made automatically. If there is a problem contact ryanbrandenburg.
I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/2267


⚠ T:Riza Community Forum has degraded performance

In afdce27, T:Riza Community Forum (https://community.triza.dev) experienced degraded performance:

HTTP code: 200
Response time: 3244 ms

Resolved: T:Riza Community Forum performance has improved in 009b6ed.


Make smart scroll when approaching loop handle to viewport edges on mouse pos x instead of loop end pos

Done for regions, not yet for loop handle


pagectl: refactor ctl and support dump kv in delta

Problem
Summary of changes
This PR refactors the original page_binutils with a single tool pagectl, use clap derive for better command line parsing, and adds the dump kv tool to extract information from delta file. This helps me better understand what's inside the page server. We can add support for other types of file and more functionalities in the future.
Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

I'll let https://github.com/neondatabase/neon/pull/4290 merge first and fix merge conflicts later.

I'll let #4290 merge first and fix merge conflicts later.

merged

I've resolved merge conflicts and we now directly parse LSN in clap. PTAL, thanks!


起项目流程

Hello, I'm a front-end developer. I downloaded our project and entered the front-end directory. I downloaded all the necessary packages and executed the NPM run start command. As a result, the server got up, but the page is always in a loading state. So I want to ask how to load the project normally locally and then modify some UI styles. Thank you

Ok, you need to run the .NET application (back-end) too. The start command in the package.json will only run the parcel build but you need to connect with the back-end. Otherwise the front-end won't start properly.

OK, can you tell me in detail how to run the back-end application? I may not understand this. Thank you

You need to run the command "dotnet run" to start the webapp.

Does the current version of. Net support the development on Mac? Can it be realized through. Net core at present

Yes, you can start the webapp in .NET Core for Mac.


Scale cmd_vel vx from app

The app tries to command the robot to go at 1 m/s on vx. The robot can only go 0.08 m/s in practice. This results in high accelerations and lots of jerk.

superflous


FLIR driver listed is incorrect

Driver listed for use:
Linux/Ubuntu16.04/spinnaker-<IP_ADDRESS>-Ubuntu16.04-i386-pkg.tar.gz
Drivers required for Raspberry Pi:
Linux/Ubuntu16.04/spinnaker-<IP_ADDRESS>-Ubuntu16.04-armhf-pkg.tar.gz

Additionally, for python download this file:
spinnaker_python-<IP_ADDRESS>-Ubuntu16.04-cp37-cp37m-linux_armv7l.tar.gz
Both can be found under Spinnaker > Linux > archive > <IP_ADDRESS>. You may have to switch to page 2 to find them.
Here are the links that worked for me:
https://flir.app.boxcn.net/v/SpinnakerSDK/folder/109034499134?page=1
https://flir.app.boxcn.net/v/SpinnakerSDK/folder/109034499134?page=2


Enter place holder on roommate posting error

Getting error on line 111 of roommate_model

Fixed. Needed to do a verification before calling property of non-object.


Implement real-time calculate ComputeScreenSpaceDrawQuad in KaraokeSpriteText

As title, missing the calculation in the KaraokeSpriteText
protected override Quad ComputeScreenSpaceDrawQuad()
{
    // make draw size become bigger (for not masking the shader).
    var newRectangle = DrawRectangle.Scale(2);
    return ToScreenSpace(newRectangle);
}

It should be the union value of:

Shaders
LeftLyricTextShaders
RightLyricTextShaders

Implemented.


No Money or Exp for breaking Crops [1.8.1], but in 1.7.1 Api7 it did.

Sponge Version:  1.12.2-2705-7.1.0-BETA-3361
Forge Version:  1.12.2 - <IP_ADDRESS>68
Total Economy Version:  1.8.1
For breaking crops you dont get any money or exp...
I tried different configurations to fix it. But i cant fix it however.
I tried to group all jobs into one job as "worker".
Then i got exp and money for breaking crops but didnt got money or exp for killing mobs.
If this issue would be fix as soon as possible. It would be very nice of you.
But in 1.7.1 Api7, breaking Crops worked.
NO CONSOLE ERRORS.

Someone already submit this issue. It was post "#282 farmer bug?". But he got now answer or any fix possibles. And i myself found any fixes too, after trying a lot.

Please attach your config files and the server log using a gist.
I will take a look at them later today or tomorrow depending on when I have the time.

https://gist.github.com/Play4K/ca8cb7e86ae725acccb518c08645203e

Even reinstalling it and letting it by default, doesnt do anything... Just so you know it..
I tried to start the server without any mods, only with the Total economy plugin. It didnt fix it.

I didn't find anything immediately catching my eye so I will try to reproduce this issue during the next days.

Not exactly "the next days" and I'm sorry for keeping you waiting.
But I have found the culprit.
The default configuration does not match the source code of the plugin.
While the configuration uses growthTrait, the plugin looks for growth-trait.
This is a bug and I will talk to Eric about what of both we want to use.
For your part exchanging all occurrences of growthTrait with "growth-trait" in the job sets file should resolve your issue.

You could also wait for this PR to get approved and a hotfix to be released in order to have the issue fixed without having to change the sets file.


Dynamically change locale

How to change the locale dynamically?
The locale should change dynamically when the user selects a language.

<template>
  <MonacoEditor
    style="height: 100px"
    v-model="value"
    :lang="lang"
    ref="editorRef"
  />
  <button @click="toggleLanguage">goggle language</button>
</template>

<script setup>
import * as monacro from "monaco-editor";
const value = ref("");
const lang = ref("html");
const editorRef = ref(null);
const toggleLanguage = () => {
  const editor = toRaw(editorRef.value.$editor);
  monacro.editor.setModelLanguage(editor.getModel(), "javascript");
};
</script>

This is a demo that switches languages, I hope it can help you

@cc-hearts
Thanks for your comment.
The issue is not the language of the editor (e.g. javascript, css) but the locale (e.g. en, ja).
https://e-chan1007.github.io/nuxt-monaco-editor/guide/configuration#locale
For example, if a user changes the locale from en to ja, we cannot tell nuxt-monaco-editor to change the locale.
Thanks.

As far as I have tried, it is not able to change the locale dynamically due to the specification of monaco-editor.
I will continue to find an alternative way to implement this.


How to configure docker cert path?

How to configure dockerCertPath in dockerfile-maven-plugin?

找到答案了吗


MnKAlpha fitter return negative background

Original report by Galen O'Neil (Bitbucket: oneilg, GitHub: oneilg).

That doesn't make any sense.

Original comment by Galen O'Neil (Bitbucket: oneilg, GitHub: oneilg).

I remember this all now, and I agree it was quite confusing and unsatisfying. I think this example is a bit more clear cut. The slope is fixed at 0, so only the background parameter matters. If I remember correctly all negative values of background should actually give zero values of background, so my result is essentially bg = 0 and the uncertainty is meaningless.
This specific example seems like it would be improved if there was a lower limit on background of 0 (eg negative values are not allowed). This wouldn't fix the fact that a slope parameter can still introduce locally negative backgrounds. Is there a downside to adding a lower bound to background?

Original comment by Joseph Fowler (Bitbucket: joe_fowler, ).

What bounds can you set on the slope and offset that guarantee that the function never goes negative? We discussed this before (see issue #71). The bounds that you set will have to be coupled, which is beyond the scope of what our fitter does.
(Yes, I know you suggested that we start using LMFIT at some point in the past. I'll bet it can take linear constraints on the parameters.)
I'm inclined to do nothing now, because the background model is physical (non-negative) everywhere, though you might argue that a kinky background function is non-physical. But the problem seems to be more with the weird numbers appearing in text on the plot than with the actual result of the fit.

Original comment by Galen O'Neil (Bitbucket: oneilg, GitHub: oneilg).

Can't we just set bounds on the parameter?

Original comment by Joseph Fowler (Bitbucket: joe_fowler, ).

Yes, I have seen this before. I'll investigate. I think that there's something ridiculous, like that a background of -5 is the same as +5??
Oh, I remember. I think that the model is
BG = maximum of (0 and "background" + "bg_slope"*bin number).
So this guarantees internally that BG < 0 never happens, but the reported values can then make no sense, or appear to make no sense.
Given this, what should we do in the report?

Original comment by Joseph Fowler (Bitbucket: joe_fowler, ).

Well, if the slope is unconstrained, then you can't make a sensible constraint on the background. (Strictly, it's the bin-0 background.) That's why there is none.
On the other hand, when the slope is fixed to zero, then it's fair to say that the background should be at least zero. And in fact, when the slope is fixed to any particular value, then we can combine that value with the # of bins and come up with a strict minimum on the bin-0 background level.
This idea is not totally satisfying, but it's definitely an improvement. Let me attempt to put a min-constraint on the bin-0 BG level when the slope is held. Good plan.

Original comment by Joseph Fowler (Bitbucket: joe_fowler, ).

The convention is that BG[bin_number] = bg + bg slope x bin_number. So yes, it's the zero-bin background.
I can see the advantage about having it be the middle bin, but the nice thing about the expression above is that it's easy to initialize bg as the 0-bin's contents and bg slope as the difference between the last and first bin.

Original comment by Galen O'Neil (Bitbucket: oneilg, GitHub: oneilg).

If it is the zero bin background, I think you’re right. If it is the middle bin background, then a zero minimum always makes sense.

Original comment by Joseph Fowler (Bitbucket: joe_fowler, ).

Sets a minimum bound on the constant BG level if its slope isn’t varying.
The bound, combined with the fixed slope, is such that the lowest bin
can have no less than 0 background values. Fixes #126 and includes a
test of the fix.

Original comment by Joseph Fowler (Bitbucket: joe_fowler, ).

Removing milestone: v0.6 (automated comment)


Manifest URL not working

It comes up 404 not found.

Hi there, thanks for your interest. I can't seem to replicate this, unfortunately. Are you able to provide more details on the steps to get the 404?

@trechriron Try using https://github.com/callunaborealis/fvtt-mutants-and-masterminds-3e/releases/latest/download/system.json instead. The one in the README is broken, I'll change that. It isn't playable at the moment I'm afraid as I stopped working on it after setting up the system.


catches malformed regex and throws a new type of exception

For a features search, if a search field contains a malformed regular expression, a server error was produced.  It's just a flake styling error in exceptions that's holding this one up.
Aside, I don't think there's another good way to handle this without altering how the RDF is queried to enforce string matching, as opposed to allowing regex for the features search endpoint. https://github.com/ga4gh/server/issues/1486
For completeness, you might construct a test in tests/end_to_end/test_g2p.py You can construct a query like in testGenotypeSearchByName then use a malformed regex pattern and assert it returns your exception. +1 mergeable when it passes

Formatting fixed and test added.

Current coverage is 86.07% (diff: 100%)

Merging #1499 into master will increase coverage by 0.01%

@@             master      #1499   diff @@
==========================================
  Files            29         29
  Lines          6820       6828     +8
  Methods           0          0
  Messages          0          0
  Branches        867        867
==========================================
+ Hits           5869       5877     +8
  Misses          800        800
  Partials        151        151

Powered by Codecov. Last update 0926cbc...0a86962


Check scanner err

This checks the scanner's .Err() function should an error condition arise that you don't want to ignore.
Request merge onto latest branch per @jhendrixMSFT request.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: deckarep sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Request header field Content-type is not allowed by Access-Control-Allow-Headers in preflight response

When I try executing the code
Cockpit.request('/collections/get/xxx').success(function(items){         console.log(items);     });
in JavaScript I get an error saying XMLHttpRequest cannot load https://mydomain.com/admin/rest/api/collections/get/xxx?token=yyy. Request header field Content-type is not allowed by Access-Control-Allow-Headers in preflight response. The JS file has been included from another domain. Is there a way I can work around this?

This is configured in the web server settings. If you are running behind Apache2 you can modify the .htaccess file to add the access-control-allow-content-type header. Behind nginx it is more difficult. I would recommend running Cockpit behind Apache unless you are very familiar with nginx configuration.


Information button

Hovering on this information button would provide the user with the main purpose of this website.
It will look like this

Please assign this issue to me.

@Chinmayeep58 go ahead.

I have applied through SSOC'24


Reporting mismatched jsdoc tags (params, etc.)

Could you add the option to report any mismatches between say a function whose parameter did not match (or was missing) on  @param or vice versa? Likewise for @return/@returns, etc...

All error checking is handled by TypeScript itself. So, unless it can do that, which I don't think it can, no.

Ok, thanks! Closing in favor of https://github.com/Microsoft/TypeScript/issues/15852 and/or https://github.com/Microsoft/TypeScript/issues/11378


[REQUEST] Searching Help and Information for Openbullet

Hey iam searching for help with open bullet.
There are much configs online. I got some configs for different things.
But i cant find explanation to this configs or the usage of openbullet.
There is nothing explained what the DATA region in the runner must show and what is happen when it only retry.
I don't know if I'm using it correctly or doing something wrong.
If there is someone who can help me with my problems and explane me some things.
Please Add me to Discord and write me. My Name is: xGismos#4114

Please use the forum for stuff like this. I am planning to make a separate documentation site and possibly some videos, but I don't have an estimated date for it.

Hey do you have a link to the forum for me

It's in the readme of the repository https://discourse.openbullet.dev/


Geocoder map marker loses precision when zooming out

Great library. However, there is a bug when zooming out. Using your Fiddle "as is", when you enter a location (e.g. Toronto) click the zoom out button a few times. You will see the marker re position itself with every zoom change until eventually it becomes inaccurate.
How can the Geocoder marker position be retained so that it's accurate when the user zooms in and out?

This should be a problem of how the marker is made. If you look at the marker.png the middle of the picture is not the tip of the marker. So if you are zoomed in really far, it seems like the marker is in correct position (even though it isn't). If you zoom out the middle of the picture stays at the correct position, but not the tip of the marker.
An easy workaround is to display your own marker. You can adjust the ol-geocoder.js and add your own marker.

@gHupf would you provide a PR to fix this behavior?

Not sure if this is still relevant, it looks like a solution can be provided on userland.


Port number guard checks valid port range

Should it check that port matches t:inet.port_number/0?

@mtrudel if it makes you feel better :gen_tcp.connect which eventially leads to :inet_tcp.do_connect has a guard that checks the valid port range, although it's using bitwise operators:
https://github.com/erlang/otp/blob/master/lib/kernel/src/inet_int.hrl#L403
I don't know which would perform better, but either way we could make a guard (I can PR it if you want but I don't know where a good module would be for it)?
Also would be interesting to benchmark which way performs best but is that getting too ridiculous?

@mtrudel if you're interested
setup
Mix.install([
  {:benchee, "~> 1.0"}
])

import Bitwise

ports = -999_999..999_999

Benchee.run(
  %{
    "bitwise" => fn ->
      Enum.each(ports, fn port ->
        band(port, bnot(0xffff)) === 0
      end)
    end,

    "comparison" => fn ->
      Enum.each(ports, fn port ->
        port >= 0 and port <= 65535
      end)
    end,

    "range" => fn ->
      Enum.each(ports, fn port ->
        port in 0..65535
      end)
    end
  }
)

Output
Operating System: macOS
CPU Information: Intel(R) Core(TM) i5-9600K CPU @ 3.70GHz
Number of Available Cores: 6
Available memory: 32 GB
Elixir 1.14.3
Erlang 25.2.3

Benchmark suite executing with the following configuration:
warmup: 2 s
time: 5 s
memory time: 0 ns
reduction time: 0 ns
parallel: 1
inputs: none specified
Estimated total run time: 21 s

Benchmarking bitwise ...
Benchmarking comparison ...
Benchmarking range ...

Name                 ips        average  deviation         median         99th %
bitwise            34.22       29.22 ms     ±1.22%       29.19 ms       30.63 ms
comparison         27.11       36.89 ms     ±3.33%       36.37 ms       43.88 ms
range              24.67       40.53 ms     ±3.11%       39.88 ms       43.82 ms

Comparison:
bitwise            34.22
comparison         27.11 - 1.26x slower +7.67 ms
range              24.67 - 1.39x slower +11.31 ms

I ran it multiple times and was always similar...

lmao you beat me to it:
Given:
Mix.install([:benchee])

defmodule Bandit.Ports do
  def is_port_number_in(port), do: port in 0..65_535
  def is_port_number_inequality(port), do: port >= 0 and port <= 65_535
  def is_port_number_bitwise(port), do: Bitwise.band(port, 0xffff) == port
end

list = Enum.to_list(1..100_000)

Benchee.run(
  %{
    "in" => fn -> Enum.each(list, &Bandit.Ports.is_port_number_in(&1)) end,
    "inequality" => fn -> Enum.each(list, &Bandit.Ports.is_port_number_inequality(&1)) end,
    "bitwise" => fn -> Enum.each(list, &Bandit.Ports.is_port_number_bitwise(&1)) end
  },
  time: 10,
  memory_time: 2
)

we get the following results:
Operating System: macOS
CPU Information: Apple M1 Max
Number of Available Cores: 10
Available memory: 32 GB
Elixir 1.14.1
Erlang 25.1

Benchmark suite executing with the following configuration:
warmup: 2 s
time: 10 s
memory time: 2 s
reduction time: 0 ns
parallel: 1
inputs: none specified
Estimated total run time: 42 s

Benchmarking bitwise ...
Benchmarking in ...
Benchmarking inequality ...

Name                 ips        average  deviation         median         99th %
bitwise           2.74 K      365.61 μs    ±38.59%      317.21 μs      774.66 μs
inequality        1.84 K      544.94 μs    ±10.04%      540.33 μs      568.08 μs
in                1.74 K      576.31 μs     ±9.09%      571.71 μs      604.94 μs

Comparison:
bitwise           2.74 K
inequality        1.84 K - 1.49x slower +179.33 μs
in                1.74 K - 1.58x slower +210.70 μs

Memory usage statistics:

Name          Memory usage
bitwise            1.52 KB
inequality         1.52 KB - 1.00x memory usage +0 KB
in                 1.52 KB - 1.00x memory usage +0 KB

So it's likely worth it to golf this up a bit


[no-merge] Add unit tests for Issue389

This tries to address #389
Note, this PR may never get merged.

The resolve this issue , the test class should reference the next class:
	 public class BaseTest
		{
			public BaseTest()
			{
				//in case multi target project,use #if because no appdomain in netcore
	#if NETFRAMEWORK

				var assembly = Assembly.GetCallingAssembly();

				var manager = new AppDomainManager();
				var entryAssemblyfield = manager.GetType().GetField("m_entryAssembly", BindingFlags.Instance | BindingFlags.NonPublic);
				entryAssemblyfield?.SetValue(manager, assembly);

				var domain = AppDomain.CurrentDomain;
				var domainManagerField = domain.GetType().GetField("_domainManager", BindingFlags.Instance | BindingFlags.NonPublic);
				domainManagerField?.SetValue(domain, manager);

	#endif
			}
		}

The solution is tested  for the same issue#389 here

The test case is involved and Pass in PR 389 in both net461 and netcoreapp2.0  after resolving the null EntryAssemply problems

@ericnewton76
It's added and merged to PR #430


Could not find module for target 'x86_64-apple-ios-simulator'

Hi all✌
When I have SPM + Pods on mac m1 you get error:  Could not find module for target 'x86_64-apple-ios-simulator'
Then I setted VALID_ARCHS = "arm64, x86_64" and got errors for Inject lib.
Maybe somebody had the same issue and knows how to fix.
Here Pods settings:
post_install do |installer|
  installer.pods_project.build_configurations.each do |config|
    config.build_settings["EXCLUDED_ARCHS[sdk=iphonesimulator*]"] = "arm64"
  end
  installer.pods_project.targets.each do |target|
    puts target.name
    target.build_configurations.each do |config|
      config.build_settings.delete 'IPHONEOS_DEPLOYMENT_TARGET'
    end
  end
end

The issue is in SPM because you can not Exclude arm64 for it... and only one way to use it it's run under Rosseta

This issue is usually the case when SPM's include a XCFramework which doesn't include the appropriate architecture slice.
However this repo does not use a XCFramework. @VitaliiDeveloper are you sure the error is due to this package?


Fix integration in run_lv and small fix for setup.py

Fix integration in run_lv and small fix for setup.py

Closed due to a failure in considering noise addition to ODE solutions in proposed fix for run_lv. I will submit a new pr soon.


[SITE] No info/visibility that TP signed the consent

This is the case when one particular TP got into two trials.
TP signed the consent.

It is not shown as signed the level of SITE.

Patient should not be able to participate in the same time in 2 trials: for mock trial we fixed this in #374
in clinical site patients will be marked as Unavailable if they are already enrolled in another trial.

Access to Consents | Answers will be limited


Search incidents pagination not working

Hello together,
I'm trying to use the api client to fetch incidents with pagination from our cortex xsoar system. Therefore I'm using the below code snippet to do that:
import logging
import os

import demisto_client
from demisto_client.demisto_api import Incident, IncidentFilter, InlineResponse200
from demisto_client.demisto_api.rest import ApiException

api_key = os.getenv("DEMISTO_API_KEY")
base_url = os.getenv("DEMISTO_BASE_URL")
api_instance = demisto_client.configure(base_url=base_url, api_key=api_key, debug=True)

incidents: list[Incident] = []
total_incidents: int = 1

incidents_filter = IncidentFilter(
    query="occurred:>=\"2023-07-01T00:00:00\" occurred:<\"2023-08-01T00:00:00\"",
    size=100,
    page=0
)
incidents_filter.sort = [{"asc": True, "field": "occurred"}]

while total_incidents > len(incidents):
    try:
        query_filter = demisto_client.demisto_api.SearchIncidentsData(filter=incidents_filter)
        api_response: InlineResponse200 = api_instance.search_incidents(query_filter)
    except ApiException as error:
        logging.error(str(error))
        break

    if not api_response.data:
        break

    total_incidents = api_response.total
    incidents.extend(api_response.data)
    incidents_filter.page += 1

print(incidents)

The problem is that in every iteration the same 100 incidents are returned although I increment the page. Therefore I think maybe the pagination is not working as I have guessed or this is a bug. Can someone maybe help me with that?

Can you attach the results with the debug arg? Feel free to email the to me if they contain sensitive info instead of posting them here<EMAIL_ADDRESS>

This ticket is managed internally at https://jira-hq.paloaltonetworks.local/browse/CIAC-8350. Any updates will also be updated here.
@marcelkwaschny Please note we'll try to reproduce this issue, but it'll help us if you get to do as @amshamah419 suggested.

Sorry, I tried to generate results with dummy tickets in our development system because unfortunatly I'm not allowed to send the results from our productive system. As I tried to generate these dummy results in our development system I figured out why the pagination isn't working with our productive system.
In the above code I'm using this query:
query="occurred:>=\"2023-07-01T00:00:00\" occurred:<\"2023-08-01T00:00:00\""

But this was not the full query that I've used. As there are multiple tenants in our productive system I used the following query:
query="account=\"customer1\" occurred:>=\"2023-07-01T00:00:00\" occurred:<\"2023-08-01T00:00:00\""

When the account field is added to the query the pagination isn't working. But if I add the account to the base url like this:
base_url = f"{os.getenv('DEMISTO_BASE_URL')}/acc_{os.getenv('DEMISTO_ACCOUNT')}"

Then the pagination is working properly. So in my opinion this can be closed because I don't know if it's valid to add the account to the query instead of the base url.

I'm glad to hear you were able to work it out! Good job :)


Allow users to set PullPolicy for pipeline jobs

I had an issue where an old image was used, because the default PullPolicy seems to be PullIfNotPresent and it took an old :latest version (which is in itself weird).
Changing the PullPolicy to Always manually solved it, but there has to be a way to do it for the entire pipeline.
Thanks!

Hi @kalugny, this PR will make it so that if you use the :latest tag, the PullPolicy defaults to Always.

stale


chore: formatting

formatting
mostly whitespace changes
some typo fixes

Wow. This is a major update. I tend to use extra new lines between things due to aesthetic reasons. Do you prefer a tighter formatting?

I usually have only one newline to split ideas / functions / ..., this allows me to see more code in the same area, while keeping a break between ideas / functions / ...
In e. g. Markdown lists I don't use extra lines, because they are separated through the *, - or 1. indicator....
In the end, you can still decide if you like it or not. And I theoretically can also undo some changes.

Closing, and maybe later reopening with smaller scope.


DP-1153: text navigation shortcuts

disable home/end in TextNavigationTrait, add tests, enable selection with Ctrl+Shift+Left

I have two failing tests:
jetbrains.jetpad.projectional.util.CellNavigationControllerTest#macEndOnEditable, endOnEditable
Do they pass for you?

Sorry, I forgot to update them. Now they do pass.


[state sync] add size limit to pending LI store to prevent OOM

Motivation
add configurable size limit on pending LIs to store, to prevent OOM if state sync is too slow
Test Plan
Existing tests

/land


amberol: 0.6.3 -> 0.7.0

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I added this package to my config, rebuild NixOS and tested playing a song with amberol. Everything seems to work as expected. :+1:

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/518


xsl:fallback Code Coverage Non-Conformance

Current Non-Conformance
The xslt-code-coverage-behavior-by-element.md file says that xsl:fallback elements should be marked based on their child elements.
The coverage-report.xsl in 3.0.3 marks them as 'missed' because there is no hit element in the XSpec trace file and there is no rule in coverage-report.xsl to process them.
Changes in xsl-fallback-01.xsl and xsl-fallback-01.xspec
The xsl-fallback-01 test should have a test where the children of the xsl:fallback element are not executed, showing the xsl:fallback element is correctly marked as 'missed'.
Changes in coverage-report.xsl
A rule needs to be added to coverage-report.xsl as follows for xsl:fallback:
If node has no children, mark it as 'unknown'.
If the trace data has a "hit" element for a child of this node, then mark this node as a 'hit'.
Otherwise, mark it as 'missed'.
Changes in test/end-to-end/cases-coverage/expected
In the coverage report xsl-fallback-01-coverage.html the xsl:fallback element  will be marked as 'hit' rather than 'missed'.

Regarding "Changes in coverage-report.xsl" above, see the amendment mentioned in item 2 of https://github.com/xspec/xspec/issues/1943#issuecomment-2227139850.


Use withTracker on flowdesigner.js

This pull request contains the following:

Use withTracker instead of react-komposer with flowdesigner.js
Fix errors and warnings + refactor code.

Yes, sure !
I am just waiting for tomscholz's opinion on this: https://github.com/vanila-io/wireflow/issues/12


tests: Add timeout to receive_line()

The tests will no longer freeze if the server doesn't send anything. Instead, they will wait for one second, and if the server still hasn't sent anything, they fail with an error that looks e.g. like this:
============================= test session starts ==============================
platform linux -- Python 3.9.2, pytest-6.2.5, py-1.11.0, pluggy-1.0.0
rootdir: /home/akuli/MantaTail, configfile: pytest.ini
collected 4 items

tests/test_mantatail.py .Disconnected.
..Disconnected.


Fix display content when employee list empty

Added overlay display on top of InfoPanel when employee list becomes empty due to clear and delete commands.
Also edited delete command to switch to viewing the first person in the employee list if list is not empty.
Resolves #157 and resolves #175

Codecov Report

Merging #190 (f440e89) into master (8752594) will decrease coverage by 0.36%.
The diff coverage is 17.07%.

@@             Coverage Diff              @@
##             master     #190      +/-   ##
============================================
- Coverage     62.67%   62.30%   -0.37%
- Complexity      656      658       +2
============================================
  Files           130      130
  Lines          2532     2547      +15
  Branches        295      296       +1
============================================
  Hits           1587     1587
- Misses          862      877      +15
  Partials         83       83

Impacted Files
Coverage Δ

src/main/java/seedu/address/model/Model.java
100.00% <ø> (ø)

src/main/java/seedu/address/ui/InfoPanel.java
0.00% <0.00%> (ø)

...ava/seedu/address/logic/commands/ClearCommand.java
100.00% <100.00%> (ø)

...va/seedu/address/logic/commands/DeleteCommand.java
100.00% <100.00%> (ø)

...rc/main/java/seedu/address/model/ModelManager.java
93.22% <100.00%> (-0.53%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8752594...f440e89. Read the comment docs.

In addition to taking account your comments, I have also changed up the Observer implementation for InfoPanel
(🙏 ps for stacking so many different kind of updates here, probably should have opened up another branch )

With regards to the Optional suggestion, I feel that with the current implementation its redundant to change it to Optional, as either way we need to return a null back with the getPerson() method.
I tried utilising Optional in the ModelManager instead though.


RDKit pose generator

Description
This PR adds a new ASAP-Alchemy prep constrained pose generator based on RDKit.
Todos
Notable points that this PR has either accomplished or will accomplish.

[x] Check structures
[x] add tests

Questions

[ ] Question 1 ..

Status

[ ] Ready to go

Developers certificate of origin

[x] I certify that this contribution is covered by the MIT license as defined in our LICENSE and adheres to the Developer Certificate of Origin.

Codecov Report

Merging #754 (0019457) into main (c814c7d) will increase coverage by 3.78%.
The diff coverage is 100.00%.

Additional details and impacted files

@JenkeScheen this should be ready for review and testing now. The last thing is to decide before we merge is the default pose generator settings do we want to swap to rdkit or keep it as openeye?

Nice! I'll review later today. We can keep RDKit as default behavior because it's more directed towards productization of asap-alchemy. Looks like CI is failing.

I compared docking using RDKit and OE, and RDKit seems to work much better, albeit a bit slow. I had 32/32 go without fail, whereas with OE only 23/32 docked succesfully.

crying

crying

FWIW, this is mostly dependent on the quality of the MCS match, not the docking itself.

@JenkeScheen I think we are ready for a full review now!


Documentation

Add docs

@julian-evers  can you add docstring to the classes and functions and we can discuss docs next week

Done in #18


Build fails with "Unexpected token ] in JSON" after updating to version 9

This issue impacts 9.0.0-rc.0 and happened while updating https://github.com/SAP/cloud-commerce-spartacus-storefront.
After updating successfully to version 9, but build fails with Unexpected token ] in JSON at position 195 after seeming to finish successfully.
kamik@RED-X1C6 MINGW64 /d/sandbox/cloud-commerce-spartacus-storefront (update-9)
$ yarn build
yarn run v1.17.3
$ ng build storefrontapp --prod
Generating ES5 bundles for differential loading...
ES5 bundle generation complete.

chunk {0} runtime-es2015.52756d3ab8e6582f0541.js (runtime) 1.45 kB [entry] [rendered]
chunk {0} runtime-es5.52756d3ab8e6582f0541.js (runtime) 1.45 kB [entry] [rendered]
chunk {2} polyfills-es2015.9d25e173e20e35a89c7c.js (polyfills) 49.4 kB [initial] [rendered]
chunk {3} polyfills-es5.c526f8e419af7aac625d.js (polyfills-es5) 138 kB [initial] [rendered]
chunk {1} main-es2015.229b1ef42e6e191943e4.js (main) 1.29 MB [initial] [rendered]
chunk {1} main-es5.229b1ef42e6e191943e4.js (main) 1.5 MB [initial] [rendered]
chunk {4} styles.da4c41d41cbf7725e5f1.css (styles) 350 kB [initial] [rendered]
Date: 2019-11-01T18:08:48.998Z - Hash: 2dc34f91b4b37faf77fa - Time: 120820ms
Unexpected token ] in JSON at position 195
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

The root cause of the issue seems to be the same as https://github.com/angular/angular-cli/issues/15462 to be more precise the appendValueInAstArray https://github.com/angular/angular-cli/blob/07780b9272d985606d318da16d732dd28a41d592/packages/schematics/angular/utility/json-utils.ts#L152 method.
The failing part here is the SW generation and the error is coming from when trying to parse the ngsw config.

Also related https://github.com/angular/angular-cli/issues/14776


Emit MarkedSource instead of formats in the Java indexer. [phab:D1188]

Created by zarko at 2016-12-16 00:53:12:

fromberger commented inline (context lost during migration) at 2016-12-16 15:20:47:
nit: "…returns…"

fromberger commented inline (context lost during migration) at 2016-12-16 15:20:47:
If ownerName.isEmpty() is true, would that not silently skip over anonymous types?

fromberger commented inline (context lost during migration) at 2016-12-16 15:20:47:
Separate from this change, do we want to open the door to snake_case in fact labels? The grammar allows it, of course, but so far we've managed to avoid it.

fromberger accepted this revision at 2016-12-16 15:20:47

zarko commented inline (context lost during migration) at 2017-01-07 01:15:14:
This comes from the MarkedSource-to-graph conversion done in the verifier. They match the field names of the proto message. These labels shouldn't be introduced into the schema.

zarko commented inline (context lost during migration) at 2017-01-07 01:15:14:
This turned out to be exciting.

zarko wrote at 2017-01-07 01:15:20:

Come up with a better story about anonymous/inner classes.

zarko wrote at 2017-01-07 01:15:53:
I've handled anonymous/inner types a bit better now. PTAL.

zarko wrote at 2017-01-09 22:42:18:

Add a clarifying comment.

zarko closed via commit f9d86171b87559e930e06b517a7afd72df8e6115 at 2017-01-09 22:44:14


Clean up implementation of Plutarch.Internal.Utilities

The proofs can in hindsight be made much more elegant.
Performance also needs to be considered, everything that can be represented as an integer
should be an integer.
Many GADTs should be made into fully erased data families too.

 Should probably be made a priority.


App crashing when loading filters

All of the questions were answered by YuAo and all of the solutions worked for me so I will ask one more about technical stuff.
I have photo editing application which is based on MetalPetal framework. The main question is why this application crashes for people who have iPhone 7 or iPhone 8 and better one. But for mine iPhone SE and my friend iPhone 6 it's working just great. It crashes when application starts loading 9 filters. I'm applying them on the same picture and then I'm keeping 9 UIImages.  Maybe the problem is memory? On my main screen with filters memory is around 100mb for me. (on iPhone SE)
For bigger screens it's 150mb. I don't know about iPhone 8 Plus.
I'm using unwind segues so after editing memory is always normal. Around 30-40mb.
Is it possible to do something to make it work great for every device?
P.S I'm using image compression tools. Size of the image is from 100kb to 1mb after compressing. And I edit only compressed images.
I don't know if it's necessary but there's my code. (Result after MetalPetal is GREAT. The only problem is that it's crashing for someone...)
`guard let thumbnail2 = original else { return }
guard let cgImage = thumbnail2.cgImage else { return }
guard let lookupimage1 = UIImage(named: "lookup_amatorka.png") else { return }
guard let cgImage1 = lookupimage1.cgImage else { return }
let filter1 = MTIColorLookupFilter()
    filter1.inputImage = MTIImage(cgImage: cgImage, options: [MTKTextureLoader.Option.SRGB: false]) // cia
    filter1.inputColorLookupTable = MTIImage(cgImage: cgImage1, options: [MTKTextureLoader.Option.SRGB: false]) // cia
    filter1.intensity = 0.6 // cia

    if let device = MTLCreateSystemDefaultDevice(),
        let outputImage = filter1.outputImage { //cia
        do {
            let context = try MTIContext(device: device)
            let filteredImage = try context.makeCGImage(from: outputImage)

            image1 = UIImage(cgImage: filteredImage)
            context.reclaimResources()
        } catch {
            print(error)
        }`

Any help would be appreciated. I hope this question is normal.
Thank you.

Any crash log/report? We are currently using MetalPetal in very intensively and we have not encountered any similar problem.

@YuAo As I said I can't tell you the problem because I only have iPhone SE and Metal don't work with xCode Simulators. (I did some research on google they said it's normal).
Also, I can't tell pixel size because it depends from the user what image he is editing. On my device every single image is working no matter if the size is big or not.
Anyway, if you mentioned maybe there's any option how to handle HD images?
But something is really weird for me. I sent low resolution image for my friend and she said that it's still crashing on her iPhone 8.
I'm really confused, buddy.

Can't help if you cannot get any possible leads or crash reports. If you cannot get a test device, maybe you can try a third party crash report collect tool, for example https://fabric.io/


[BUG] SSL connection problem with Cient Certificates Auth

What is the bug?
When trying to connect to OpenSearch Instace with client certificate and key i get this error:
opensearchpy.exceptions.SSLError: ConnectionError([SSL: SSLV3_ALERT_BAD_CERTIFICATE] sslv3 alert bad certificate (_ssl.c:2635)) caused by: SSLError([SSL: SSLV3_ALERT_BAD_CERTIFICATE] sslv3 alert bad certificate (_ssl.c:2635))

OpenSearch logs shows this, i believe to be relevant
io.netty.handler.codec.DecoderException: javax.net.ssl.SSLHandshakeException: Empty client certificate chain

How can one reproduce the bug?

Configure a docker compose file to create a Opensearch instance with basic auth and client certificate auth enabled. With the next configuration files.
and then i've run the securityadmin.sh bash

opensearch.yml
cluster.name: os-cluster
network.host: <IP_ADDRESS>

bootstrap.memory_lock: "true" # along with the memlock settings below, disables swapping

plugins.security.allow_unsafe_democertificates: true
plugins.security.ssl.http.enabled: true
plugins.security.ssl.http.pemtrustedcas_filepath: certificates/ca/ca.pem
plugins.security.ssl.http.clientauth_mode: REQUIRE
plugins.security.ssl.transport.enabled: true
plugins.security.ssl.transport.pemtrustedcas_filepath: certificates/ca/ca.pem
plugins.security.ssl.transport.enforce_hostname_verification: false

plugins.security.authcz.admin_dn:
  - CN=ADMIN,O=ORG,L=XXXXXXXXX,ST=XXXXXXXXX,C=XX
plugins.security.nodes_dn:
  - CN=node1,O=ORG,L=XXXXXXXXX,ST=XXXXXXXXX,C=XX

plugins.security.audit.type: internal_opensearch
plugins.security.enable_snapshot_restore_privilege: true
plugins.security.check_snapshot_restore_write_privileges: true
plugins.security.restapi.roles_enabled: ["all_access", "security_rest_api_access"]
cluster.routing.allocation.disk.threshold_enabled: false

config.yml
_meta:
  type: "config"
  config_version: 2

config:
  dynamic:
    http:
      anonymous_auth_enabled: false
    authc:
      internal_auth:
        order: 0
        description: "HTTP basic authentication using the internal user database"
        http_enabled: true
        transport_enabled: true
        http_authenticator:
          type: basic
          challenge: false
        authentication_backend:
          type: internal
      clientcert_auth_domain:
        description: "Authenticate via SSL client certificates"
        http_enabled: true
        transport_enabled: true
        order: 1
        http_authenticator:
          type: clientcert
          config:
            username_attribute: cn #optional, if omitted DN becomes username
          challenge: false
        authentication_backend:
          type: noop

What is the expected behavior?
It's expected to authenticate correctly with opensearch and make the connection.
What is your host/environment?
NAME="Ubuntu"
VERSION="20.04.6 LTS (Focal Fossa)"
Do you have any additional context?
I've try connecting just with curl client, and javascript client and it works fine, so its not related to the certificates.

Are you using the python client? What's your code? What does curl http... return?

Sorry i did not specify that part, so yes i'm using the python client with this code (replaced sensitive values):
from opensearchpy import OpenSearch
import os
# connect to an instance of OpenSearch

host = os.getenv('HOST', default='MY_HOST')
port = int(os.getenv('PORT', 9200))
auth = (
    os.getenv('USERNAME_OPENSEARCH', 'myusername'),
    os.getenv('PASSWORD', 'mypassword')
)
print("host: ", host, "port: ", port, "auth: ", auth)
# ca_certs_path = '/path/to/ca.pem' # Provide a CA bundle if you use intermediate CAs with your root CA.

# Optional client certificates if you don't want to use HTTP basic authentication.
client_cert_path = '/path/to/cert.pem'
client_key_path = 'path/to/cert.key'

# Create the client with SSL/TLS enabled, but hostname verification disabled.
client = OpenSearch(
    hosts = [{'host': host, 'port': port}],
    http_compress = True, # enables gzip compression for request bodies
    http_auth = auth,
    client_cert = client_cert_path,
    client_key = client_key_path,
    use_ssl = True,
    verify_certs = False,
    ssl_assert_hostname = False,
    ssl_show_warn = False,
    ca_certs = ca_certs_path
)

Found a solution, Sorry for the trouble and thanks:
In your case, since you're using Client Certificate Authentication, you need to use the RequestsHttpConnection class because it supports sending client certificates. The Urllib3HttpConnection class does not support this feature.
So i just imported the class and added a line to the Client
from opensearchpy import OpenSearch, RequestsHttpConnection
client = OpenSearch(
    ...
    ...
    connection_class = RequestsHttpConnection,
    )

@EdEngineering is that something we (you?) could add to the user guide? The https://github.com/opensearch-project/opensearch-py/blob/main/guides/ssl.md doc is severely lacking


Clarify/Improve Container.forceReadonly usage during connect

Apparently calling Container.forceReadonly during the load sequence doesn't work, which feels a bit surprising. @kmui reported that calling it after the "connected" event comes back doesn't work, but wrapping it with a setTimeout() after the "connected" did work.
Either the API should work whenever it's called, or it should be clearly documented how/when to use it. See also, documentation here.
cc @vladsud as FYI

What exactly doesn't work?

I expect "readonly" event to fire due to readonly bit being flipped.
calling forceReadonly did not trigger the readonly event to fire when calling it immediately after the container resovles, or even right after "connected" event.

Where do you listen for "readonly" event? I.e. is it Container, DeltaManager, or something else?
Does Container.readonly property reflects changes or also broken for you?

@kmui can you provide additional information or a repro?

@kmui can you provide additional information or a repro?

Container.readonlyPermission reflects the correct state
Container.readonly event was never triggered.

Container.readonlyPermission reflects the correct state
Container.readonly event was never triggered.

I believe we had a discussion about it somewhere else, but I do not remember details.
More detailed description would help, as not clear what exactly does not work (event where? I believe events are fired only by delta manager, which might be a gap, but they do fire).
Event better - please add UT to demonstrate what does not work.
There are already UTs in this space, so it should be rather trivial to add, and will be the ultimate test of the fix working.

I believe we had a discussion about it somewhere else, but I do not remember details.
More detailed description would help, as not clear what exactly does not work (event where? I believe events are fired only by delta manager, which might be a gap, but they do fire).
Event better - please add UT to demonstrate what does not work.
There are already UTs in this space, so it should be rather trivial to add, and will be the ultimate test of the fix working.


Feature/refactor to new api gdev 898

`Refactored to use new UCS API
Adjusted existing API calls to new endpoints
Adjusted processing of reponses
Added API call to get information about a specific upload (currently unused)
`

Please especially check, if the new tecnical specs api has been correctly followed:
https://editor.swagger.io/?url=https://raw.githubusercontent.com/ghga-de/epic-docs/main/4-star-nosed_mole/api_definitions/rest/ucs.yaml


printer() causes Not a Constant Expression exception when using with Flutter, Dart2 preview

Trying to initialise the store with logging middleware:
import 'package:redux_logging/redux_logging.dart';

class MyApp {
  final store = new Store<AppState>(appReducer,
    initialState: new AppState(),
    middleware: [new LoggingMiddleware.printer()]
  );
}

But get the following exception at runtime:
Exception has occurred.
'package:redux_logging/redux_logging.dart': error: Not a constant expression.

Appears to be a Flutter/Dart 2 issue, works fine with Flutter and Dart 1.
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, v0.1.5, on Mac OS X 10.13.3 17D102, locale en-AU)
[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
[✓] iOS toolchain - develop for iOS devices (Xcode 9.2)
[✓] Android Studio (version 3.0)
[✓] VS Code (version 1.21.1)
[✓] Connected devices (1 available)

Hey @MichaelMarner -- Thanks for the report, and sorry about the trouble!
Did you run into this problem using the Dart 2 version of this lib (0.2.x) or the Dart 1 version of this lib (0.1.x)? Thanks!

Tracked down the problem. Thanks for reporting! A new version 0.3.0 has been deployed that fixes this bug and supports Redux 3.0.0

Thanks for fixing, and sorry I should have been more specific on the version I was using. But you were correct:
When testing with Dart 2 I was using 0.2.x